Fix GitHub check

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
3m  8s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m  5s
Maven dependency ordering for patch

-1 :x:
mvninstall
0m  5s
root in the patch failed.

-1 :x:
compile
0m  5s
root in the patch failed.

-1 :x:
javac
0m  5s
root in the patch failed.

-1 :x:
scalac
0m  5s
root in the patch failed.

-1 :x:
checkstyle
0m 10s
The patch fails to run checkstyle in root

-1 :x:
markdownlint
0m  2s
The patch generated 11 new + 101 unchanged - 0 fixed = 112 total (was 101)

-1 :x:
whitespace
0m  0s
The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
yamllint
0m  0s
There were no new yamllint issues.

-1 :x:
javadoc
0m  7s
phoenix5-spark in the patch failed.

-1 :x:
javadoc
0m  7s
phoenix5-spark3 in the patch failed.

-1 :x:
javadoc
0m  5s
root in the patch failed.

-1 :x:
scaladoc
0m  7s
phoenix5-spark in the patch failed.

-1 :x:
scaladoc
0m  6s
phoenix5-spark3 in the patch failed.

-1 :x:
scaladoc
0m  5s
root in the patch failed.

-1 :x:
spotbugs
0m  7s
phoenix5-spark in the patch failed.

-1 :x:
spotbugs
0m  6s
phoenix5-spark3 in the patch failed.

-1 :x:
spotbugs
0m  5s
root in the patch failed.

_ Other Tests _

-1 :x:
unit
0m  5s
root in the patch failed.

+1 :green_heart:
asflicense
0m 20s
The patch does not generate ASF License warnings.

17m 23s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-137/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix-connectors/pull/137

Optional Tests
dupname asflicense yamllint markdownlint javac javadoc unit spotbugs hbaseanti checkstyle compile scalac scaladoc

uname
Linux 72f1542e138c 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-connectors-personality.sh

git revision
master / 4c880e2

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

mvninstall
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-137/1/artifact/yetus-general-check/output/branch-mvninstall-root.txt

compile
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-137/1/artifact/yetus-general-check/output/branch-compile-root.txt

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-137/1/artifact/yetus-general-check/output/buildtool-branch-checkstyle-root.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-137/1/artifact/yetus-general-check/output/branch-javadoc-phoenix5-spark.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-137/1/artifact/yetus-general-check/output/branch-javadoc-phoenix5-spark3.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-137/1/artifact/yetus-general-check/output/branch-javadoc-root.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-137/1/artifact/yetus-general-check/output/branch-scaladoc-phoenix5-spark.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-137/1/artifact/yetus-general-check/output/branch-scaladoc-phoenix5-spark3.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-137/1/artifact/yetus-general-check/output/branch-scaladoc-root.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-137/1/artifact/yetus-general-check/output/branch-spotbugs-phoenix5-spark.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-137/1/artifact/yetus-general-check/output/branch-spotbugs-phoenix5-spark3.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-137/1/artifact/yetus-general-check/output/branch-spotbugs-root.txt

mvninstall
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-137/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt

compile
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-137/1/artifact/yetus-general-check/output/patch-compile-root.txt

javac
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-137/1/artifact/yetus-general-check/output/patch-compile-root.txt

scalac
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-137/1/artifact/yetus-general-check/output/patch-compile-root.txt

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-137/1/artifact/yetus-general-check/output/buildtool-patch-checkstyle-root.txt

markdownlint
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-137/1/artifact/yetus-general-check/output/diff-patch-markdownlint.txt

whitespace
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-137/1/artifact/yetus-general-check/output/whitespace-eol.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-137/1/artifact/yetus-general-check/output/patch-javadoc-phoenix5-spark.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-137/1/artifact/yetus-general-check/output/patch-javadoc-phoenix5-spark3.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-137/1/artifact/yetus-general-check/output/patch-javadoc-root.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-137/1/artifact/yetus-general-check/output/patch-scaladoc-phoenix5-spark.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-137/1/artifact/yetus-general-check/output/patch-scaladoc-phoenix5-spark3.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-137/1/artifact/yetus-general-check/output/patch-scaladoc-root.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-137/1/artifact/yetus-general-check/output/patch-spotbugs-phoenix5-spark.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-137/1/artifact/yetus-general-check/output/patch-spotbugs-phoenix5-spark3.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-137/1/artifact/yetus-general-check/output/patch-spotbugs-root.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-137/1/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-137/1/testReport/

Max. process+thread count
52 (vs. ulimit of 30000)

modules
C: phoenix5-spark phoenix5-spark3 . U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-137/1/console

versions
git=2.7.4 maven=3.3.9 markdownlint=0.22.0 yamllint=1.20.0

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Fix: Remove unused imports

This PR

[x] removes unused imports in test code

@localheinz A little fiddling is needed from me on your PRs as master is now dev branch for v2 with a lot of changes locally. If you have time would you be able to re submit them against the 1.x. If you don't have time please let me know and I will do it manually and bring them across to master for v2.
Thanks for these by the way.

@philipobenito
No problem, give me a moment!

@philipobenito
Turns out that this has already been fixed in develop, closing!

@philipobenito
Not sure, shouldn't you make develop the default branch, then?

@localheinz
Yeah I'm in the process of changing the dev strategy as I'm building v2. Should all be finalised quite soon, just been a mad few months, but will be sorting it asap.

@philipobenito
:+1: Take it easy!

@localheinz
Idea is that develop will disappear completely, there are just too many changes going through that will break master completely so it's a bit of a stop gap :+1:


Question about mamba edition.

Dear Lee,
Awesome job and congratulation!
It seems that their is only multi-head self attention edition SpatialNet here. Will you release the online mamba edition in the future?
Best!

@TungyuYoung Thank you for your interest in our work. The code will be released soon.

The code of mamba version is released, see models/arch/OnlineSpatialNet.py
The corresponding config is configs/onlineSpatialNet.yaml

The code of mamba version is released, see models/arch/OnlineSpatialNet.py
The corresponding config is configs/onlineSpatialNet.yaml

Thanks again! Have a nice day!


Make Spake2+ output arguments size-safe

Problem

Both Spake2p::Mac() and Spake2p::HashFinalize expected properly
sized output buffers without ensuring it, leading to possible
buffer overruns.

Fixes #4189
Change overview

This PR makes it necessary to pass a MutableByteSpan to ensure
size is checked, and adds the proper checks throughout

Testing

Updated unit tests to match and they still pass
Integration tests pass

/rebase

/rebase


URL for the game?

Where can I find the URL to actually play the game? I thought I looked everywhere in README but couldn't find it.

A link to the demo is in the footer of this page https://ninegua.github.io/reversi/

It has been deployed to mainnet at https://ivg37-qiaaa-aaaab-aaaga-cai.ic0.app/


fix large K correctness issue

non-power-of-2 GSU
non-power-2 of GSU need divide operation.
LargeK will make salu divide overflow
use valu to handle non-power-2 of GSU case.

set buffer limit to ffffffff

@TonyYHsieh Can we please add a simple test to e.g. precheckin to cover this issue?  Thanks.


BlankLineAfterNamespaceFixer - do not remove indent, handle comments

prove of https://github.com/FriendsOfPHP/PHP-CS-Fixer/issues/4130

What about:
<?php
namespace Foo; /** comment 1 */              /**
 * comment 2
 */
    use Bar;

Should we add new line before use or before comment 2 (as it has break line itself)?

(dropping milestone as this is WIP)

Thank you @kubawerlos.


feat: Added "status" and "code" to errors

I added status and code to the errors.

Closes #337

Changes

Adds status and code to the different exceptions
New exception types added as constant

Flags
N/A
Screenshots or Video
N/A

Related Issues

Issue #337
Pull Request N/A

Author Checklist

[x] Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
[x] Vital features and changes captured in unit and/or integration tests
[x] Commits messages follow AP format
[ ] Extend the documentation, if necessary
[x] Merging to main from fork:branchname

@mttrbrts
I have created this PR to add status and code in the exceptions so that they can be accessed easily.

This is a great start, thank you @kailash360.
I'd like to start a discussion about the design of the error codes before we fix them. For example, I think that there are semantic groups that we should use to categorise the similar codes (e.g. taking inspiration from the HTTP Status codes, e.g. https://www.npmjs.com/package/http-status-codes).

Considering the HTTP Status codes, we can obviously define our own error codes. I referred to this resource explaining the context of numbering the HTTP Status codes. On a higher ground, they are categorized based on the nature or aspect of the HTTP request. In our case, we need to define the depth that we need to cover.
For example, we can define status codes for TypeNotFoundException or SecurityException and use them anytime we get these errors. But for a detailed explanation, we can also define the family of TypeNotFoundException errors as 3xx and specify the error code for each of the sub-types, and follow this for the other exceptions as well. I personally feel the latter approach will add a big overhead.
If you recommend, I can group the existing exceptions in the below format:
Syntax Errors
Starts with 3 and follows 3x  format

31 TypeNotFoundException
32 ValidationException
33 MetaModelException

Semantic Errors
Starts with 4 and follows 4x format

41 BaseFileException
42 IllegalModelException
43 SecurityException

Let me know if this sounds good to proceed.

Yes, this is the right direction. I recommend that we discuss this design live on a Working Group call. They run weekly at 8am EST
Also, can you rebase you PR on top of the v4.0.0 branch, please? If you look at the commit log, your PR also includes lots of unrelated changes.

@kailash360
We reviewed this change in the working group call on 13 March (https://vimeo.com/922895729). The consensus was that a previous change has already addressed this issue sufficiently by adding types to Errors. We haven't solved the categorisation problem but we should first come up with a design for that in an issue, before writing code.
I'm sorry for any wasted time here on your part.


[Death on the Reik] Boat length and Modification measurements

There was an error in the Death on the Reik that all measurements were in feet rather than yards. So all the boats ended up tiny. You'd only get 6 oarsmen in a 10 foot row boat if they are cremated first ;) See Unofficial FAQs. Not a big deal but thought i'd point it out.From: simulacrum #7888wfrp4e: 4.2.0wfrp4e-core: 2.1.1wfrp4e-dotr: 2.0.5wfrp4e-eis: 2.0.4wfrp4e-rnhd: 2.1.1wfrp4e-starter-set: 2.0.2wfrp4e-ua1: 2.0.1

Unless it is acknowledged by C7 I'm not considering Unofficial FAQs anymore than that, unofficial


Cylinders in URDF are parsed as Capsule

When encountering tag cylinder in URDF, pinocchio parser builds a fcl::Capsule. The reason for this is that URDF does not support capsules (and it does not seem it will: https://github.com/ros/urdfdom_headers/pull/24).
I see several way to handle this:

use a negative radius and or length to specify that a cylinder should be a capsule,
add an attribute or a tag below tag cylinder in the URDF and parse it with pinocchio,
use the tag collision_checking mentioned at the bottom of this page,
do not support capsule.

I can work on this. Any preference on the method ?

I think

is the shortest to handle your cases
BUT
might be investigated as a long term solution as we will be able to handle new features that are not provided by URDF yet.

In conclusion, I would go for the second solution.

As the capsule are mostly used for doing collision checking and that this is ignored by the URDF parser why @jcarpent do you prefer 2 over 3 ?

Just be because in the two scenarios, we will need to add an additional parsing stage. So you're right, 2. and 3. are equivalent, except we can give precise naming with the second option.

yes but if we use 3 and if the block checking_collision is ignored we could use directly capsule in place of cylinder which to me looks more readable.

According to the discussion, I chose solution 3.

Solved by #425.


WORKFLOW & ISSUE TEMPLATES

Resolving issue
closes #10 add .github folder inside the source-web/ folder
Be sure to complete and check the following steps:

[ ] My changes were made in the source-web/src/assets/db folder.
[x] The resource(s) is completely or partially free.
[x] The resource(s) is not already in the database.
[x] All resources have an id, order, name, link and img.
[x] The ids and urls of the images are not repeated.

I just notice that you decide to include the database in the repo. that is nice to see.
However, I still believe that this would be a great implementation.

With the ability for users to contribute, the repo-lockdown action is no necessary. Additionally, codespell is redundant as I already perform a spelling check before merging a pull request.
Regarding the issue templates, I find them unnecessarily complex and restrictive. For instance:

The template for suggesting new resources allows only one suggestion at a time.
The "Category Request ⚡" template requests a subcategory that does not exist.
The "Category Description 📝" template is unnecessary since the categories do not have a description.
The "Documentation 📋" template is not necessary since the project does not have documentation yet.
The "Refactor Code 🔧" template restricts suggestions to one file at a time.

ok


Release v0.7.0

Release Process

[x] Create and push new release branch
Local release preparations (on the release branch)

[x] Run e2e tests
[x] Sync/tidy up dependencies.

[x] Run go mod tidy.
[x] Run git commit -m 'go.mod,go.sum: update dependencies.' go.{mod,sum}, if necessary.

[x] Run git tag -a -m "NRI plugins $VERSION" $VERSION.

Publishing

[x] Push the tag with git push $VERSION.
[x] Check that new container images are published for the tag.

for i in nri-resource-policy-topology-aware nri-resource-policy-balloons nri-resource-policy-template nri-config-manager nri-memory-qos nri-memtierd; do \
    skopeo inspect --format "$i: {{.Digest}}" docker://ghcr.io/containers/nri-plugins/$i:$VERSION;
done

[x] Finalize the new draft release created by CI

[x] Check that all artefacts (Helm charts) were uploaded
[x] Write the change log to the release.
[ ] Get the change log OK'd by other maintainers.

[x] Publish the draft as a release.
[x] Verify that the Helm repo was updated
[x] Add a link to the tagged release in this issue.
[ ] Generate the operator bundle by running make bundle within deployment/operator directory and submit the generated content to the community-operators.

[ ] Create and push unannotated development tag X.Y.0-devel for next release cycle.
[ ] Close this issue.

v0.7.0 release tagged and published

/cc @fmuyassarov Could you take care of the operator bundle ?

/cc @fmuyassarov Could you take care of the operator bundle ?

https://github.com/k8s-operatorhub/community-operators/pull/4597


Clarify that the GPO & registry key is for Outlook only in the a…

…dd-ins section

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

outlook/Concepts/Getting-Started/support-for-keeping-add-ins-enabled.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Version 3.20.0 broke something with minZoom

Please have a look at this jsfiddle which runs with version 3.20.1 : https://jsfiddle.net/202a443s/1/
In this sample I have set "minZoom" to less than zero on ol.View :

with version 3.20.0 and upper :  if you zoom out and if zoom goes under 0, panning the map will become slow and sluggish. The more you zoom under 0, the more the map will be slow when panning.
with version 3.19.1 : everything is smooth for all zooms.

Please also note that once the map goes under zoom 0, it will also become sluggish when panning when zoom comes back over 0, but I could not demonstrate this with this sample. This is however the behavior wee see in our app which use a custom tile source (I can't do a Jsfiddle with that). Somehow our app cannot run smoothly at all with versions > 3.19.1 because of this.

This is because we switched back to using an intermediate canvas for tile layer rendering, like we did before v3.14.0. The reason is because the intermediate canvas is always created for a zoom level that is available for the tile source. Which will be 0 in your example, even if the zoom level is -10.
Out of curiosity: why are you using negative zoom levels? I'm surprised it works at all, and I could not think of a use case why someone would want that.

Our map show an airport (a tile map).
This map is surrounded by radar circles which go very var outside the visible tiled map.
We need to be able to zoom out very far out of the bounds of the tiled map to be able to see all radar circles (for planes in approach or departing).
Sorry for me bad english, hope your understand what I mean

Was this change the source of the behaviour I see ?
https://github.com/openlayers/openlayers/pull/6082
I can also confirm that event without the minZoom problem, our app seems less snappy with version 3.20.1 than with 3.19.1. This is very subjective and hard to measure (we have two targets : chrome on Windows, and IOS 10)

Yes, #6082 was the change that caused the behaviour you are seeing. Does your application have multiple tile layers? If so, that would explain the reduced snappiness. And we have a plan to improve that in the future.
Regarding the negative zoom levels, you should probably change the tile grid setup of your tile layers, and modify your application to not use negative zoom levels - I still consider negative zoom levels an ugly hack, and we should probably forbid zoom levels < 0.

Thank for your response :) I also forgot to tell you in my first question than I find OL to be a fantastic framework for map applications ...
We use only one tile layer. We need two zoom steps less than the minimum zoom level. As the minimum zoom level is 0 or one, the "real" minimum goes under 0. If the tile map would have a minimum zoom at 2 would it work to go down to 0 ? In fact the problem is caused by the zoom going under 0 or the zoom being lower than the minimum zoom level of the tile source ?
Moreover I suspect there may be a bug in the new implementation because :

if I zoom lower than the minimum zoom level of the tile source, I see in the profiler that the application is spending a lot of time (something like 40%) in "clearRect". Maybe OL is trying to clear an "gigantic" surface (just a guess ?)
if I zoom lower than the minimum zoom level, the map stutters, but will continue to stutter even if I zoom back to normal zoom levels. I was not able to demonstrate this in my jsfiddle sample, but this is what we see in our app. Any clue of what could be the cause of this ?

I've made a test in our app. If I change zoom levels used by tile layers to be for example 2 to 10 (instead of 2 to 8) and set minZoom to 0, I also have the problem (sluggishness forever at soon as I zoom out to level 0). So zoom does not need to be negative at all to have this problem. In this case, at zoom 0 a tile is displayed at normal size (256pixels), not reduced at all.

Please provide a JSFiddle that shows the issue, instead of letting us guess what's going on in your application. I'd like to close this issue and create new tickets for the underlying problem(s), but we need to be able to identify them.

if I zoom lower than the minimum zoom level of the tile source, I see in the profiler that the application is spending a lot of time (something like 40%) in "clearRect". Maybe OL is trying to clear an "gigantic" surface (just a guess ?)

This is correct. It results from the oversampling of the tile layer and the large tile ranges.

if I zoom lower than the minimum zoom level, the map stutters, but will continue to stutter even if I zoom back to normal zoom levels. I was not able to demonstrate this in my jsfiddle sample, but this is what we see in our app. Any clue of what could be the cause of this ?

Maybe you are using OpenLayers v3.13.1 or older in your app? In these old versions, the canvas was never shrunk once its size was increased.

We were using version 3.19.1 before having this problem.
I think I have found were the problem is, and you can somehow reproduce it with the jsfiddle given in my first post. You have to :

use chrome (tested with v56 only on windows)
make the map very big on screen before running the sample
zoom out under 0. It will become very sluggish
zoom in again. You will see that it stays somehow sluggish, but it will only happen if the map is big on screen (and probably if your pc is not very fast)

I fiddled with the OL code, and found this in ol/renderer/canvas/tilelayer.js, line 179 and next :
 if (canvas.width != width || canvas.height != height) {
      canvas.width = width;
      canvas.height = height;
} else {
 context.clearRect(0, 0, width, height);
}
The problem is that this code can create gigantic canvas, and chrome doesn't like that at all (or my gpu or both I don't know). Safari on IOS does not seem to be affected by that.
For example on my screen which is 1920x1200 (HD screen), i get this :

at zoom 0 : 2304x1280
at zoom -4 : 7936x5120 which is more than 17x the size of the screen. Once chrome has created a canvas of this size it seems like it will stay sluggish forever.

If i replace the code with this one (which is incorrect and stupid but just to explain my point) :
 if (canvas.width != width || canvas.height != height) {
   canvas.width = Math.min(width,1920);
     canvas.height = Math.min(height,1200);
   console.log ('new canvas  ' + width + ' ' + height);
  } else {
  context.clearRect(0, 0,  Math.min(width,1920), Math.min(height,1200));
}
Then the map is displayed incorrectly but flies again not matter what I do with the zoom.
Hope it will help you (and sorry again for my poor wording in english)

We were using version 3.19.1 before having this problem.
I think I have found were the problem is, and you can somehow reproduce it with the jsfiddle given in my first post. You have to :

use chrome (tested with v56 only on windows)
make the map very big on screen before running the sample
zoom out under 0. It will become very sluggish
zoom in again. You will see that it stays somehow sluggish, but it will only happen if the map is big on screen (and probably if your pc is not very fast)

I fiddled with the OL code, and found this in ol/renderer/canvas/tilelayer.js, line 179 and next :
 if (canvas.width != width || canvas.height != height) {
      canvas.width = width;
      canvas.height = height;
} else {
 context.clearRect(0, 0, width, height);
}
The problem is that this code can create gigantic canvas, and chrome doesn't like that at all (or my gpu or both I don't know). Safari on IOS does not seem to be affected by that.
For example on my screen which is 1920x1200 (HD screen), i get this :

at zoom 0 : 2304x1280
at zoom -4 : 7936x5120 which is more than 17x the size of the screen. Once chrome has created a canvas of this size it seems like it will stay sluggish forever.

If i replace the code with this one (which is incorrect and stupid but just to explain my point) :
 if (canvas.width != width || canvas.height != height) {
   canvas.width = Math.min(width,1920);
     canvas.height = Math.min(height,1200);
   console.log ('new canvas  ' + width + ' ' + height);
  } else {
  context.clearRect(0, 0,  Math.min(width,1920), Math.min(height,1200));
}
Then the map is displayed incorrectly but flies again not matter what I do with the zoom.
Hope it will help you (and sorry again for my poor wording in english).

Changing the code like this does indeed fix the issue completely for us (correct rendering, and normal performance) :
var widthC = Math.min(width, 2 * size[0]);
var heightC = Math.min(height, 2 * size[1]);
if (canvas.width != widthC || canvas.height != heightC) {
canvas.width = widthC;
canvas.height = heightC;
} else {
context.clearRect(0, 0, widthC, heightC);
}
Intuitively I don't get how the intermediate canvas would need to be more than two times bigger than the viewport when zoom > 0. When zoom <= 0, when only one tile can be displayed, maybe something could be done to use a very small canvas ? Just my two cents.
The new PinchZoom default behavior also allow to zoom out to very low (and negative) values ...

Good suggestions, thanks @ogo-adp. See #6439 for a fix of your negative zoom levels problem, and an improvement for sluggish panning/zooming in general.


pull request for e2e test at 12/06/2016 16:26:00

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


FormData ignores Non-Ascii characters on filename

Description
https://github.com/jaydenseric/apollo-upload-client/issues/244
Uploading file using FormData works well on Web.
But on React Native, it keep ignores Non-Ascii characters on filename.
How can I send filename properly?
I created file object like below
  const nativeFile ={
    uri: file.url,
    type: file.mime,
    name: file.name,
  };

And passed it like below
const formData = new FormData();
formData.append('file', nativeFile);

console.log(filename) before upload
이름변경-2.jpg

after upload
-2.jpg

(Edit)
Server Log (nodejs with Koa)
  {
    filename: '-2.jpg',
    mimetype: 'image/jpeg',
    encoding: '7bit',
    createReadStream: [Function: createReadStream]
  }

I had to send formData without content-type header.
Does this can cause problem?
React Native version:
System:
    OS: macOS 10.15.7
    CPU: (4) x64 Intel(R) Core(TM) i5-4690 CPU @ 3.50GHz
    Memory: 329.11 MB / 24.00 GB
    Shell: 5.7.1 - /bin/zsh
  Binaries:
    Node: 12.18.3 - /usr/local/bin/node
    Yarn: 1.22.5 - /usr/local/bin/yarn
    npm: 6.14.8 - /usr/local/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  Managers:
    CocoaPods: 1.10.0 - /usr/local/bin/pod
  SDKs:
    iOS SDK:
      Platforms: iOS 14.2, DriverKit 20.0, macOS 11.0, tvOS 14.2, watchOS 7.1
    Android SDK: Not Found
  IDEs:
    Android Studio: 4.0 AI-193.69<IP_ADDRESS>26763
    Xcode: 12.2/12B45b - /usr/bin/xcodebuild
  Languages:
    Java: 11.0.8 - /usr/bin/javac
    Python: 2.7.16 - /usr/bin/python
  npmPackages:
    @react-native-community/cli: Not Found
    react: 16.13.1 => 16.13.1
    react-native: 0.63.3 => 0.63.3
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Steps To Reproduce
Provide a detailed list of steps that reproduce the issue.

Create FormData object like above
append file
send it to nodejs based server (like Koa.js)

Expected Results
Same result with Web's FormData

System

React Version

Is there any update on this?

Any update? RN 0.70 still has this issue

Is there any update?

+1

You need to urlencode on the client side. Seems like it' a ISO thing 🤷


Request: source code for inf2cat and signtool

Since inf2cat and signtool are important tools used to make drivers, I think the Windows driver community would benefit from seeing how they work and being able to modify them.  I request that you add the source code of those two utilities to this repository.  (Or if the source code is available somewhere else, please let me know.  I could not find it.)  Thanks!

Other tool like devcon is useful because IHV might need to write their own setup utility; but I cannot think of any user case when IHV need to write another signtool.

I can think of a big reason to make signtool open source.  The "signtool verify" feature is supposed to check whether your signature is good, but there are many cases where "signtool verify" shows no errors and yet developers still run into problems when trying to use the signed files (e.g. Code 52 when loading a driver).  I'm helping someone over email right who is in that situation.  I wrote this big article with the requirements for a successful signature and I think signtool doesn't check most of those requirements.  I know Vista is almost dead, but "signtool" never warned about how kernel modules have to be signed with SHA-1 to work in Windows Vista.  I have not tested this recently but I don't think it provides any warnings against using SHA-1 now that it is being phased out.


Data Error/Bug: Living Sun-Spire's Construct Armor does not affect hardness

The Living Sun-Spire's Construct Armor's description does not match the description in the book or in AON. In addition, the automatic reduction in hardness is not automated as it is with other construct enemies.
IS:

Construct Armor (Hardness 14): Like normal objects, the Living Sun-Spire has Hardness. This Hardness reduces any damage it takes by an amount equal to the Hardness.
Once the statue is reduced to less than half its Hit Points, or immediately upon being damaged by a critical hit, its construct armor breaks and its Armor Class is reduced to 32.

SHOULD BE:

Construct Armor: Like normal objects, the living sun-spire has Hardness. This Hardness reduces any damage the sun-spire takes by an amount equal to the Hardness. Once a sun-spire is reduced to fewer than half its Hit Points, or immediately upon being damaged by a critical hit, its construct armor breaks, removing the Hardness and reducing its Armor Class to 32.

(Emphasis mine)
IS: When the living sun-spire is reduced to half HP, or when the "Construct Armor Broken by a Critical Hit" box is checked, the living sun-spire's AC is automatically reduced to 32, but it's hardness stays at 14.
SHOULD BE: When the living sun-spire is reduced to half HP, or when the "Construct Armor Broken by a Critical Hit" box is checked, the living sun-spire's AC is automatically reduced to 32, AND the hardness should automatically reduce to 0. The Animated Armor NPC in the compendium already has this behavior automated correctly.

Unable to reproduce. Did you grab a fresh copy from the compendium?

Agreed, pulling from the compendium fixed the issue.

Unable to reproduce. Did you grab a fresh copy from the compendium?


Squares and cubes in a range

Issue Id you have worked upon -
#222
Briefly explain your program logic -
Helps to find the squares and cubes within a given range
Screenshots(Attach 2 screenshots of your own input and output) -
Attach

By raising this PR I affirm that -

[x] My code follows the guidelines of this project.

[x] I have performed a self-review of my own code.

[x] I have commented my code.

[x] My code gives the correct output.

[x] I affirm that I strictly follow contributing guidelines and code of conduct.

Congratulations 🎉 @Upadhyay-Harshit on your contribution.
Thanks for adding value to this repository. 😊
Let's celebrate this fest 😃 by providing more developers 👨💻👩💻 an opportunity to contribute. Help us make this repository reach far and more by sharing this to your friends and colleagues.
Your efforts can make difference.

Hey 👋, may you also encourage us by clicking the star icon on the repository main page. ⭐


AI scraper fails

It seems they changed the wording for the confirmed cases.

They also started publishing isolated and quarantined


LDAPS auth broken on upgrade to 1.6.17

Rancher versions:
rancher/server 1.6.17
Docker version: (docker version,docker info preferred)
17.03.2-ce
Operating system and kernel: (cat /etc/os-release, uname -r preferred)
Debian 8 - 3.16.0-6-amd64
Type/provider of hosts: (VirtualBox/Bare-metal/AWS/GCE/DO)
VMWARE
Setup details: (single node rancher vs. HA rancher, internal DB vs. external DB)
rancher HA with external DB
Environment Template: (Cattle/Kubernetes/Swarm/Mesos)
Steps to Reproduce:

stop old rancher/server container,
sudo docker pull docker-public.recette.local/rancher/server:stable
sudo docker run -d --restart=unless-stopped -p 8080:8080 -p 9345:9345 -v /root/ac.crt:/var/lib/rancher/etc/ssl/ca.crt  docker-public.recette.local/rancher/server:stable --db-host dbserver --db-port 3306 --db-user rancher --db-pass password --db-name rancher
try  to login

Results:
Webui show :

Error communicating with authentication provider
Container logs :

time="2018-05-09T13:36:46Z" level=info msg="Now generating Ldap token"
time="2018-05-09T13:36:46Z" level=error msg="GetToken failed with error: Error creating ssl connection: LDAP Result Code 200 \"\": x509: certificate is not valid for any names, but wanted to match ad1.domain.local"
2018-05-09 13:36:46,327 ERROR [:] [] [] [] [p1020391880-141] [.a.a.i.e.ExternalServiceAuthProvider] Got error from Auth service. statusCode: 500, message: Error creating ssl connection: LDAP Result Code 200 "": x509: certificate is not valid for any names, but wanted to match ad1.domain.local

LDAP auth was working like a charm with 1.6.16, the certificates didn't change on AD side so I don't get what's wrong here. The certificate CN on AD side is *.domain.local
should be working.

Thanks for your report!
With the release of Rancher 2.0, development on v1.6 is only limited to critical bug fixes and security patches.
If you think we should keep this issue open, please let me know.


Unbreak build on FreeBSD

udev on systemd-less Linux could be used via libudev-zero but since the ship has sailed let's use libinotify-kqueue on BSDs.

Thanks for this. Pardon my ignorance, but what is the $(NULL) for?

An old trick from Firefox to avoid readjusting line contiunation via backslash. ad6d734d51a3 added extra \  to -L/usr/local/lib which broke adding LDFLAGS+=... on the subsequent line.

I've removed $(NULL) to avoid confusing other contributors.

Neat trick, though I would rather just remember to omit the backslash. The more you know :P.


[BUG] running ragas evaluate tries to post results to local langsmith

I don't have any langchain env vars set but I am getting a network error as seen below.

hmm this is interesting, most likely due to something with langchain's end but to confirm could you give me your langchain version, python version and ragas version
let me see if I can reproduce this
Thanks a ton for raising the issue @mikeldking :)

langchain==0.0.265
ragas==0.0.10
langsmith==0.0.22

are you still facing these issue consistently ?

are you still facing these issue consistently ?

It's not blocking, it just shows up next to the progress bars

@jjmachan this is pretty annoying and pervasive for us. Are we planning on fixing?


Failed push leaves origin tags in funny place

Do a push on an http repo, then fail to enter in the right password. Push doesn't happen. Then try again and get it right. It goes, but then origin/branchname label appears next to both old commit and new.

I'm seeing this bug sometimes even when I've got the password correctly.


Teaser block in core

This is the port of @kitconcept/volto-blocks-grid teaser to Volto core.
Supersedes https://github.com/plone/volto/pull/573 see history and discussion there.
Features

[x] Standalone teaser block
[x] Local cache of hardcoded title, description and head_title of the target element in block fields
[x] These cached fields are the ones that are used in the Teaser rendering
[x] The user can modify them at will
[x] The Teaser does not update until you reset it and choose another target
[x] [Teaser] Uses component registry for defining templates for default content types teases
[x] Alignment widget, left, right, center
[x] Add handler for resetting the teaser completely (target and overrides)
[x] Images do not use "the shortcut" but the image cataloged data for the target object
[ ]

Wishlist

[ ] Extend the default local cache fields
[ ] Sync the original teaser with the overrides
[ ] The cache can be refreshed on demand by the user, overriding the current values (UX TBD)
[ ] Optional switch that makes the data is always "live", unless override values are present (UX TBD)
[ ] Extend the Teaser with "slots". These slots could be: bottom-left, bottom-middle and bottom-right.
[ ] Improved serialization for teasers using transforms and the upcoming Relations serializers (as in the RelatedChoices fields.
[ ] Able to extend (and show) metadata if the teaser is linked to an object then we would also be able to show Tags or any other object metadata
[ ] Inline editing of the teaser text elements?
[ ] Round image (variations?)
[ ] Ribbons (variations?)
[ ] Using SVG for images (to create a stripe of icons instead of images)

/cc @plone/volto-team FYI, if we want to make it happen during the conference

@tiberiuichim

make the teaser variations also available for Listing block items

Not sure I get this. The teaser variations we have are "image left", "image right" and "image center". How would that translate to a listing block variant (especially "image center")?

allow the teaser grid to pick source of data: manually or query-based (listing block). Would we be able to "hack it" by doing block transformations?

I don't get this either tbh. Do you want to be able to select a single teaser based on a query?

@tisto
Let's take the kitconcept/volto-carousel-block as an example. In your addon screencast, you use a Card layout for each item in the carousel. One problem that I, as an integrator would have, is that I want to reuse the components for the Carousel Cards, also in the Teaser. They look the same, only the "layout" behavior is different. But what if I want that the Carousel item come from a querystringsearch query, rather then manually defining each item? For example, I might want to showcase the latest news or events as a Carousel. Again, I would want to reuse the same basic Card component.
Let's asume that I have a website where I have two implementations for the Carousel: one with "teaser items", handpicked with the ObjectBrowser and another one automatically generated, with a Listing Block variation named "Carousel". What would a user story look like:

As a website editor
When I want to create a "carousel listing of items"
I need to create a Listing block with a Carousel variation

So, how should a website function when it integrates volto-carousel-block and provides the Carousel behavior for the listing block?
And there's always a big mess and confusion, for both editors and developers. On large websites, we keep piling up variations on top of the listing block. As a developer, I want the "layout behavior" (carousel, slideshow, listing, etc) to be separate from what it's actually listing, so that I can reuse that layout component.
With Volto as it's shaped right now, the best UX is for website editors to have separate blocks: Carousel, Slideshow, etc. But if we want to change the block type? "I want to take this carousel block and see how it would look like as a slideshow of cards". We need block transformations. Right now we don't have them, so we piggyback the Carousel and Slideshow behaviors and instead of exposing them at top level, as separate blocks, we expose them "deep inside" as variations for Listing block (or, potentially, Teaser Grid block).
Possible solution 1
Let's say, in my projects, I rename the "Listing block" to "Collection block". Then I have several abstract components, where each one is pluggable and can be switched, as a variation, by the editors:

Data source (either query-based or manual source (teasers).
Layout behavior (listing, carousel, slideshow, gallery, etc) (with a pagination subcomponent)
Individual item display (card, image, listing item, etc).

Possible solution 2
How about exposing making the variations directly available from the block choosers? Of course, the UI would have to be enhanced, but it's an option.
Existing work
For the EEA website we created volto-listing-block which defines a new extensible component, the UniversalCard. This component (together with its own schema enhancers and sub-variation layout templates) is then use by the Listing block and the Teaser Grid block. Typically, on websites, for the Listing block, we'd have variations such as "News listing", "Event listing", "Horizontal Cards", etc. This time, we only have "Listing", "Carousel", "Gallery" which only control how the overall layout is done. Then, at the UniversalCard level, we have its sub-variations: Image Card, Listing item, etc.
With this type of code setup it's possible to switch freely between variations and "block types" without too much issue. For a perfect UX, though, we should expose some of the main combinations (ex: "Events carousel", "Latest news carousel") as "precooked blocks". Maybe as an enhancement in the block chooser.

@tiberiuichim I see where you are trying to go with seperate sources from layout etc and ability to coerce one block into another type. My fear is that its going to create for a more complicated UI.
For us we choose to give the user a choice of either Listing (with variations) or a Teaser Group (with variations) (called a grid in this screencast) but regardless of the name its a manually curated group of content.

We don't let them create individual teasers/cards
You can add and remove items and reorder them as you need
Changing the variation of the group changes the appearance of all the items so you can see the same information displayed in different ways
It doesn't get the text from the linked item yet (like this teaser block) but it could. But the variations also don't even need to have a linked item or could have an external link.

Before we had a grid with individual blocks but there was no way to switch how it looks quickly so I personally think this works better.
I think the usecase for a user wanting to switch between an automatic list of items vs a manual one is limited? Hopefully the user knows if they want automatic or manual in advance? You could still support switching via a generic "convert to:" block action but you can only really covert a automated listing to a manual one, not the other way around right?

@plone/volto-team I think this one is ready. Let's merge the basics in this one, then merge further development on the work done by @steffenri in the Alpine City Sprint 2023: https://github.com/plone/volto/tree/teaser-core-wishlist
@tiberiuichim I guess your comments was more focused for the row block, right? Let's continue the discussion in there then.
@djay I share your view on this one. Although I'd let the "door open" for further customization options like the ones proposed and implemented in volto-listing-block.
The ability to "share" variations for listings/rows - let's say "shared variants on collections of elements" is very interesting and I think that is worth to explore. We'll have to solve the problem of collections coming from the catalog vs collections coming from pre-designated/selected content (eg. teaser'd elements), I've found myself in this situation and ended up by writing an "Adapter" for mapping props for making both use cases work.

@tiberiuichim How about now?

For the failing docs build, see https://github.com/plone/volto/issues/4441

After merging https://github.com/plone/volto/pull/4444, update this branch to rerun the failing docs build and hopefully pass.


Is Timemachine able to generate an xml dump resembling pages-articles.xml

Documentation says Timemachine is able to generate a JWPL databases, I wonder if it is possible to get a xml dump resembling the one offered by wikipedia (pages-articles.xml).
If not would it imply a lot of refactor changes on jwpl to make it get one out?
Thanks

I don't think JWPL is the right tool for that. The time machine creates a JWPL database resembling a previous Wikipedia state, but not old dump (xml) files.
However, many older dump files can be found on archives such as the ones listed here: https://dumps.wikimedia.org/archive


Support APK split based on architecture

Why not support this ?

We're currently working on adding support for Android App Bundles. Would that suit your needs?


Voting on videos?

I have read the roadmap and any developers update and documentation I could find, but I found no mention about a future implementation of voting on videos. I saw #2598 but it discusses voting on comments for moderation purposes, which is different.
I think voting is an important feature to have for two reasons:

because it allows the users to signal what content they like (or dislike) which is very useful metric for the content creator.

this can help with the recommender system to triage what videos to recommend (in addition to the views count for example).

users are simply too used to voting by now, and some may pass on trying LBRY because of this lack.

Is voting on videos planned at some point?

Thanks for the feedback. Voting on LBRY is currently done through the tip and supports mechanism (lbry.com/faq/tipping / lbry.com/faq/trending) but we don't expose some of the values in the app yet. I don't think we'll have a different voting mechanism, and this one will continue to evolve UI wise.

Hello, thank you for the reply. I have experimented a bit more with lbry, and I think I understand how it's intended to work. I noticed that there were LBC rewards everyday just for watching content, so if this continues indefinitely (and is not just a temporary giveaway until LBRY is more widespread), indeed this mechanism gives the possibility to any viewer to cast a certain number of votes/tips per day.
However, it still is not like a voting system, particularly because there is no dislike. So I still would strongly suggest to reconsider the possibility to add such a voting system. Maybe not in the blockchain, and there is no need to monetize votes since there is the tip system in place, but votes just for themselves would have great value to gauge content quality and feed the search engine and recommender system.

Since I cannot vote using LBRY, I switch to Odysee to vote.


'Window' object has no attribute 'Ot_log_folder'

09:25:43 AM:INFO:Foraging:Foraging.py:_LoadTrainingPar:line 1120:loading training stage parameters
09:25:43 AM:ERROR:MyFunctions:MyFunctions.py:_GetTrainingParameters:line 1728:'Window' object has no attribute 'Ot_log_folder'

logfile at ~/allen/programs/mindscope/workgroups/behavioral-dynamics/aind_logs/W10DT714027_gui_log/447-2-C_gui_log_2024-03-14_09-24-53.txt

This should be resolved by #299


support windows and linux

appify should support windows and linux builds.

Hehe. Me too.
I think windows is a tough one.
There are a few tools out there but they need to be wrapped a bit in golang to make it less confusing.
Anyway will see what I can find.

Btw I am using mage instead of makefiles so that the same make works on all desktops.
Using ming64 and other bits can make things fragile I have found.
Mage has saved me heaps of time and it makes it very easy to tap into various things you need to package on windows

https://github.com/mh-cbon/go-msi
Makes an msi.
But for windows 10 you want an appx. the new windows 10 way....

Linux
https://github.com/mh-cbon/go-bin-rpm

@gedw99 great job - do you want to join the project?

You can use appx and distribute it without the store


DeepLinkHandler is not defined

After updating to 2.7.0 ha got this error.

Hello,
I apologize. This version should have been 3.0.0 instead of 2.7.0 since it had a breaking change: https://github.com/BranchMetrics/cordova-ionic-phonegap-branch-deep-linking/commit/7a4cf3895ce26b6a85c805e67212289648d16493. Our continuous integration did not handle the versioning correctly.
The new way to read deep link data is through a promise off of Branch.initSession().then(data). The function DeepLinkHandler is no longer defined. You can read more about how to make this change here, or you can revert to the previous version of the Branch Cordova SDK.
I appologize again for this inconvience.

Ok, I'll return to 2.6.24 version and i'll wait for the new npm package.

Hi @ethanneff
the error is still printed in the console on Android even when we are using a promise.

Hello again,
This may be a file rename issue with the latest version. Can you please follow this guide to make sure you clear the Branch Cordova SDK and then reinstall it?

It also happens when I reinstall the complete Cordova project completly.
Can it be related to this line?
https://github.com/BranchMetrics/cordova-ionic-phonegap-branch-deep-linking/blob/master/src/android/io/branch/BranchSDK.java#L834

Yes! Good find. I have just updated the Branch Cordova SDK. I would recommend updating to the latest version 3.0.0. You can use this guide to update Branch Cordova SDK.
This version finally represents the breaking change (3.0.0 instead of 2.7.0+). Additionally, I am in the process of deprecating 2.7.0+ since this version could cause confusion and headache.
Again, I apologize for all this convenience.
Thanks,


Add ability to authenticate only for edtiing

I wanted read only knowledge base but one that admins can edit.

Thanks for the PR.
Could this already be accomplished in the current project with
config.allow_editing = true
config.authentication = true

or am I misunderstanding?

No, that would authenticate all requests, even to view only.
This PR allows public readable knowledgebase, that authenticated users can edit.

Wait, I'm not sure about that any more. I can't remember exactly as it was over a month ago, but the use case I was needing was not fully supported by that config. Maybe it was just showing the edit button if there was not a user logged in? Not entirely sure any more, I'll have to look into it in detail

I understand, there has been a lot of confusion around the various "modes" of Raneto (I'm confused myself!). I'll make updating docs a priority.

Integrated, and is now the default. Thank you!


Adds Filters support to Query Criteria.

Resolves #58
Resolves #59
See README update for sample code.

@mbhnyc  Check out new support for Filters within the Criteria.  This should let you accomplish your complex query.  See the README for an example.

ah kickass!


Can't update to the last version

Hello,
I am trying to update the package to it's last version (0.2.0) and I am getting the following error.
Running "flutter packages get" in centraldofranqueado-flutter...
The current Dart SDK version is 2.1.0-dev.9.4.flutter-f9ebf21297.

Because app_central depends on photo_view >=0.2.0 which requires SDK version >=2.1.0 <3.0.0, version solving failed.

There is something that I need to change in my flutter app?

Dupe of #94
Releasing fixes now to 0.2.1.

Thanks! Closing.

Released


nix-shell PS1 formatting issue

Issue description
when I run nix-shell, I get a malformed PS1 that has printed escape characters.
currently:  \[\][nix-shell:~/git/secproxy]$\[\]

bold represents green text in shell

Steps to reproduce
run nix-shell
echo $PS1 yields: \n\[\033[1;32m\][nix-shell:\w]$\[\033[0m\]
Proposed solution
Modify line 297 of nix-shell executable:
currently:             '[ -n "$PS1" ] && PS1="\n\[\033[1;32m\][nix-shell:\w]$\[\033[0m\] "; ' .
works for me:             '[ -n "$PS1" ] && PS1="\033[1;32m[nix-shell:\w]$\033[0m "; ' .

I assume this is a very hacky, non-portable fix, but this does fix the issue.

Technical details

System: macOS version: 10.12.2 (16C67)
Nix version: nix-env (Nix) 1.11.5
Nixpkgs version: 17.03pre98135.3ac20e9
Shell: GNU bash version: 3.2.57(1)-release (x86_64-apple-darwin16)

This is probably better suite for the Nix repo. nix-shell has been rewritten in C so the new file is at src/nix-build/nix-build.cc line 431.

Sounds good, I will close this issue and create an issue there.

actually this looks like a dupe (possibly): nixos/nix#644


Update move_to scripts for Spark version 2.1.0.

Coverage remained the same at 32.353% when pulling 005c7c2ec66016affa9f89b5b0d7ac28285c27af on heuermh:update-move-scripts into 6415a43fa664ca128d50684c05fffd58857ac9cb on bigdatagenomics:master.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/cannoli-prb/51/Build result: FAILURE[...truncated 15 lines...] > /home/jenkins/git2/bin/git fetch --tags --progress https://github.com/bigdatagenomics/cannoli.git +refs/pull/:refs/remotes/origin/pr/ # timeout=15 > /home/jenkins/git2/bin/git rev-parse origin/pr/61/merge^{commit} # timeout=10 > /home/jenkins/git2/bin/git branch -a -v --no-abbrev --contains d3b34c7aab8d7619e592b0f7644c65b62e99929a # timeout=10Checking out Revision d3b34c7aab8d7619e592b0f7644c65b62e99929a (origin/pr/61/merge) > /home/jenkins/git2/bin/git config core.sparsecheckout # timeout=10 > /home/jenkins/git2/bin/git checkout -f d3b34c7aab8d7619e592b0f7644c65b62e99929aFirst time build. Skipping changelog.Triggering cannoli-prb ? 2.6.0,2.11,1.6.1,centosTriggering cannoli-prb ? 2.3.0,2.11,2.0.0,centosTriggering cannoli-prb ? 2.6.0,2.10,2.0.0,centosTriggering cannoli-prb ? 2.6.0,2.10,1.6.1,centosTriggering cannoli-prb ? 2.3.0,2.10,2.0.0,centosTriggering cannoli-prb ? 2.3.0,2.11,1.6.1,centosTriggering cannoli-prb ? 2.6.0,2.11,2.0.0,centosTriggering cannoli-prb ? 2.3.0,2.10,1.6.1,centoscannoli-prb ? 2.6.0,2.11,1.6.1,centos completed with result FAILUREcannoli-prb ? 2.3.0,2.11,2.0.0,centos completed with result SUCCESScannoli-prb ? 2.6.0,2.10,2.0.0,centos completed with result SUCCESScannoli-prb ? 2.6.0,2.10,1.6.1,centos completed with result SUCCESScannoli-prb ? 2.3.0,2.10,2.0.0,centos completed with result SUCCESScannoli-prb ? 2.3.0,2.11,1.6.1,centos completed with result SUCCESScannoli-prb ? 2.6.0,2.11,2.0.0,centos completed with result SUCCESScannoli-prb ? 2.3.0,2.10,1.6.1,centos completed with result FAILURENotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

Jenkins, retest this please

Coverage remained the same at 32.353% when pulling 005c7c2ec66016affa9f89b5b0d7ac28285c27af on heuermh:update-move-scripts into 6415a43fa664ca128d50684c05fffd58857ac9cb on bigdatagenomics:master.

Coverage remained the same at 32.353% when pulling 005c7c2ec66016affa9f89b5b0d7ac28285c27af on heuermh:update-move-scripts into 6415a43fa664ca128d50684c05fffd58857ac9cb on bigdatagenomics:master.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/cannoli-prb/52/Build result: FAILURE[...truncated 15 lines...] > /home/jenkins/git2/bin/git fetch --tags --progress https://github.com/bigdatagenomics/cannoli.git +refs/pull/:refs/remotes/origin/pr/ # timeout=15 > /home/jenkins/git2/bin/git rev-parse origin/pr/61/merge^{commit} # timeout=10 > /home/jenkins/git2/bin/git branch -a -v --no-abbrev --contains d3b34c7aab8d7619e592b0f7644c65b62e99929a # timeout=10Checking out Revision d3b34c7aab8d7619e592b0f7644c65b62e99929a (origin/pr/61/merge) > /home/jenkins/git2/bin/git config core.sparsecheckout # timeout=10 > /home/jenkins/git2/bin/git checkout -f d3b34c7aab8d7619e592b0f7644c65b62e99929aFirst time build. Skipping changelog.Triggering cannoli-prb ? 2.6.0,2.11,1.6.1,centosTriggering cannoli-prb ? 2.3.0,2.11,2.0.0,centosTriggering cannoli-prb ? 2.6.0,2.10,2.0.0,centosTriggering cannoli-prb ? 2.6.0,2.10,1.6.1,centosTriggering cannoli-prb ? 2.3.0,2.10,2.0.0,centosTriggering cannoli-prb ? 2.3.0,2.11,1.6.1,centosTriggering cannoli-prb ? 2.6.0,2.11,2.0.0,centosTriggering cannoli-prb ? 2.3.0,2.10,1.6.1,centoscannoli-prb ? 2.6.0,2.11,1.6.1,centos completed with result FAILUREcannoli-prb ? 2.3.0,2.11,2.0.0,centos completed with result SUCCESScannoli-prb ? 2.6.0,2.10,2.0.0,centos completed with result SUCCESScannoli-prb ? 2.6.0,2.10,1.6.1,centos completed with result SUCCESScannoli-prb ? 2.3.0,2.10,2.0.0,centos completed with result SUCCESScannoli-prb ? 2.3.0,2.11,1.6.1,centos completed with result SUCCESScannoli-prb ? 2.6.0,2.11,2.0.0,centos completed with result SUCCESScannoli-prb ? 2.3.0,2.10,1.6.1,centos completed with result SUCCESSNotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

Jenkins, retest this please

Coverage remained the same at 32.353% when pulling 005c7c2ec66016affa9f89b5b0d7ac28285c27af on heuermh:update-move-scripts into 6415a43fa664ca128d50684c05fffd58857ac9cb on bigdatagenomics:master.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/cannoli-prb/53/Build result: FAILURE[...truncated 15 lines...] > /home/jenkins/git2/bin/git fetch --tags --progress https://github.com/bigdatagenomics/cannoli.git +refs/pull/:refs/remotes/origin/pr/ # timeout=15 > /home/jenkins/git2/bin/git rev-parse origin/pr/61/merge^{commit} # timeout=10 > /home/jenkins/git2/bin/git branch -a -v --no-abbrev --contains d3b34c7aab8d7619e592b0f7644c65b62e99929a # timeout=10Checking out Revision d3b34c7aab8d7619e592b0f7644c65b62e99929a (origin/pr/61/merge) > /home/jenkins/git2/bin/git config core.sparsecheckout # timeout=10 > /home/jenkins/git2/bin/git checkout -f d3b34c7aab8d7619e592b0f7644c65b62e99929aFirst time build. Skipping changelog.Triggering cannoli-prb ? 2.6.0,2.11,1.6.1,centosTriggering cannoli-prb ? 2.3.0,2.11,2.0.0,centosTriggering cannoli-prb ? 2.6.0,2.10,2.0.0,centosTriggering cannoli-prb ? 2.6.0,2.10,1.6.1,centosTriggering cannoli-prb ? 2.3.0,2.10,2.0.0,centosTriggering cannoli-prb ? 2.3.0,2.11,1.6.1,centosTriggering cannoli-prb ? 2.6.0,2.11,2.0.0,centosTriggering cannoli-prb ? 2.3.0,2.10,1.6.1,centoscannoli-prb ? 2.6.0,2.11,1.6.1,centos completed with result FAILUREcannoli-prb ? 2.3.0,2.11,2.0.0,centos completed with result SUCCESScannoli-prb ? 2.6.0,2.10,2.0.0,centos completed with result SUCCESScannoli-prb ? 2.6.0,2.10,1.6.1,centos completed with result SUCCESScannoli-prb ? 2.3.0,2.10,2.0.0,centos completed with result SUCCESScannoli-prb ? 2.3.0,2.11,1.6.1,centos completed with result SUCCESScannoli-prb ? 2.6.0,2.11,2.0.0,centos completed with result SUCCESScannoli-prb ? 2.3.0,2.10,1.6.1,centos completed with result SUCCESSNotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

Jenkins, test this please.

Coverage remained the same at 32.353% when pulling 005c7c2ec66016affa9f89b5b0d7ac28285c27af on heuermh:update-move-scripts into 6415a43fa664ca128d50684c05fffd58857ac9cb on bigdatagenomics:master.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/cannoli-prb/54/
Test PASSed.

Merged! Thanks @heuermh!


Generate reference fields & custom configuration API

Description of your changes
This PR introduces a custom configuration that could be used to configure LateInitializationConfiguration and ReferencingConfiguration while generating the CRD. This PR also handles generating reference fields as well as passing required markers down to crossplane-tools to generate reference resolver functions.
Fixes #56
I have:

[x] Read and followed Crossplane's contribution process.
[x] Run make reviewable to ensure this PR is ready for review.
[x] Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested
Tested with https://github.com/crossplane-contrib/provider-tf-aws/pull/22

@muvaf I've resolved/responded to all your comments.


Extend Github action to cross-compile to aarch64/arm/i686 for Linux

Extend the Github workflow to set up QEMU and the Rust toolchain, and then build/test evdev for various targets (aarch64, arm and i686).
This way we can also easily catch issues like #95 and #96 and also #82.

Can we have a 0.12.1 in the meantime that can properly compile again? Not sure if there's a bit issue to post this in.

I see no reason to hold this back. If it causes problems we can revert it.


download getting struck

Till yesterday (sept 04 2020) everything was fine. In two days I was able to download the 50% of the course and today when i tried to resume the task it got struck. then I tried to download a new course and there was no issue with it. am unable to resume previously downloaded course

. so once look into this.

maybe one day we get this work again

1st close the udeler and try this
delete the last downloaded file of that course , i mean your are downloading full stack web development for beginners which is downloaded to downloads folder in pc , delete that last file in last folder so
download continues after that


Upstream changes to zora-drops-utils package

See https://github.com/public-assembly/zora-drops-utils/issues/69

Upstream lib is not maintained.


onLongPress prop not working under TouchableHighlight, TouchableNativeFeedback [android]

🐛 Bug Report
onLongPress prop not working under TouchableHighlight or TouchableNativeFeedback with Android.
To Reproduce
The code under here is enough to reproduce it.
Expected Behavior
Should display an alert message saying "You long-pressed the button" if you press the button long enough.
Code Example
Code example has been and can be taken from official ReactNative docs under this link specifically.
Environment
  React Native Environment Info:
    System:
      OS: Windows 10
      CPU: (8) x64 Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz
      Memory: 8.06 GB / 15.93 GB
    Binaries:
      Yarn: 1.13.0 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
      npm: 6.7.0 - C:\Program Files\nodejs\npm.CMD
    IDEs:
      Android Studio: Version  <IP_ADDRESS> AI-182.5<IP_ADDRESS>14842 ```

Thanks for filing @saifali96! This is a dupe of https://github.com/facebook/react-native/issues/24001 and we're actively investigating


Show inverted polygon for allowed zone

Out of interest I experimented with adding an inverted polygon for the limited area, as a potential addition to #347.

shows the outside area in a darker shade
shows a not-allowed cursor
stops clicks on the polygon and thus prevents adding markers outside the area - but cannot avoid dragging markers out

@bagage what do you think, would that be a useful addition (I don't mind if not)?

Very nice enhancement @nrenner, it isn't much more code and the result looks way better like that!
Do you think we could do a release for that to be available on brouter.de main instance? It would be a really great enhancement for French users :).

Do you think we could do a release for that to be available on brouter.de main instance?

Done.


test(frontend): Settings logic and new API key UI

End-user friendly description of the problem this fixes or functionality that this introduces

Remove settings context in favor of the useSettings query hook and useSaveSettings mutation fn
Move "are settings updated" logic to a provider
Add basic e2e tests for settings
Improve api key UI

[ ] Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions

Link of any specific issues this addresses

To run this PR locally, use the following command:
docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:ecde867-nikolaik   --name openhands-app-ecde867   docker.all-hands.dev/all-hands-ai/openhands:ecde867

I wasn't able to replicate the issue since I can't seem to find settings.json. What I have done though is have the modal open if the GET settings returns an error off any kind


Package request: stl-thumb-kde

Project description
this software allows STL files to be thumbnailed in dolphin and other qt based file-managers
Metadata

homepage URL: https://github.com/unlimitedbacon/stl-thumb-kde
source URL: https://github.com/unlimitedbacon/stl-thumb-kde
license: mit
platforms: linux

( i'm going to try to take a crack on packaging this, but i'm not super experienced )
Add a :+1: reaction to issues you find important.

This is a duplicate of 292685.

If you could thumb up 292685 and 233835, that might help draw attention to the request for stl-thumb.

ok did !


readiness probe fails

Hi I'm trying to deploy rqlite with multiple nodes. The first node spin up normally while the other fails to be ready:
NAME                       READY   STATUS    RESTARTS   AGE
rqlite-0                   1/1     Running   0          14m
rqlite-1                   0/1     Running   0          13m
rqlite-2                   0/1     Running   0          13m

Events:
  Type     Reason     Age                    From     Message
  ----     ------     ----                   ----     -------
  Warning  Unhealthy  2m26s (x127 over 12m)  kubelet  Readiness probe failed: HTTP probe failed with statuscode: 503

This are the logs for the first node
[rqlited] 2024/12/29 08:28:53 rqlited starting, version v8.36.3, SQLite 3.46.1, commit 92bcff8e0b50570294c3d13f6b598821ad3daff6, branch master, compiler (toolchain) gc, compiler (command) musl-gcc
[rqlited] 2024/12/29 08:28:53 go1.23.4, target architecture is arm64, operating system target is linux
[rqlited] 2024/12/29 08:28:53 launch command: /bin/rqlited -node-id rqlite-0 -http-addr <IP_ADDRESS>:4001 -http-adv-addr rqlite-0.rqlite-svc-internal.default.svc.cluster.local:4001 -raft-addr <IP_ADDRESS>:4002 -raft-adv-addr rqlite-0.rqlite-svc-internal.default.svc.cluster.local:4002 -disco-mode=dns -disco-config={"name":"rqlite-svc-internal"} -bootstrap-expect=1 -join-interval=1s -join-attempts=120 /rqlite/file/data

            _ _ _
           | (_) |
  _ __ __ _| |_| |_ ___
 | '__/ _  | | | __/ _ \   The lightweight, distributed
 | | | (_| | | | ||  __/   relational database.
 |_|  \__, |_|_|\__\___|
         | |               www.rqlite.io
         |_|

[mux] 2024/12/29 08:28:53 mux serving on [::]:4002, advertising rqlite-0.rqlite-svc-internal.default.svc.cluster.local:4002
[rqlited] 2024/12/29 08:28:53 preexisting node state detected in /rqlite/file/data
[cluster] 2024/12/29 08:28:53 service listening on rqlite-0.rqlite-svc-internal.default.svc.cluster.local:4002
[http] 2024/12/29 08:28:53 execute queue processing started with capacity 1024, batch size 128, timeout 50ms
[http] 2024/12/29 08:28:53 service listening on [::]:4001
[store] 2024/12/29 08:28:53 opening store with node ID rqlite-0, listening on rqlite-0.rqlite-svc-internal.default.svc.cluster.local:4002
[store] 2024/12/29 08:28:53 ensuring data directory exists at /rqlite/file/data
[store] 2024/12/29 08:28:53 old v7 snapshot directory does not exist at /rqlite/file/data/snapshots, nothing to upgrade
[snapshot-store] 2024/12/29 08:28:53 store initialized using /rqlite/file/data/rsnapshots
[store] 2024/12/29 08:28:53 0 preexisting snapshots present
[store] 2024/12/29 08:28:53 raft log is 32768 bytes at open, indexes are: first 1, last 10
[rqlited] 2024/12/29 08:28:53 discovery mode: dns
[cluster-join] 2024/12/29 08:28:53 failed to join via node at <IP_ADDRESS>:4002: no leader (did you forget to set -join-as?)
[cluster-join] 2024/12/29 08:28:53 failed to join cluster at [<IP_ADDRESS>:4002], after 1 attempt(s)
[store] 2024/12/29 08:28:53 reached expected bootstrap count of 1, starting cluster bootstrap
[store] 2024/12/29 08:28:53 cluster bootstrap failed: bootstrap only works on new clusters
[cluster-bootstrap] 2024/12/29 08:28:53 succeeded notifying all targets: [<IP_ADDRESS>:4002]
[cluster-join] 2024/12/29 08:28:54 failed to join via node at <IP_ADDRESS>:4002: no leader (did you forget to set -join-as?)
[cluster-join] 2024/12/29 08:28:54 failed to join cluster at [<IP_ADDRESS>:4002], after 1 attempt(s)
[cluster-bootstrap] 2024/12/29 08:28:54 succeeded notifying all targets: [<IP_ADDRESS>:4002]
[raft] 2024/12/29 08:28:55 [WARN]  heartbeat timeout reached, starting election: last-leader-addr= last-leader-id=
[store] 2024/12/29 08:28:55 this node (ID=rqlite-0) is now Leader
[cluster-bootstrap] 2024/12/29 08:28:56 boot operation marked done
[rqlited] 2024/12/29 08:28:56 node HTTP API available at http://rqlite-0.rqlite-svc-internal.default.svc.cluster.local:4001
[rqlited] 2024/12/29 08:28:56 connect using the command-line tool via 'rqlite -H rqlite-0.rqlite-svc-internal.default.svc.cluster.local -p 4001'

And this are the logs for the second/third node
[rqlited] 2024/12/29 08:30:44 rqlited starting, version v8.36.3, SQLite 3.46.1, commit 92bcff8e0b50570294c3d13f6b598821ad3daff6, branch master, compiler (toolchain) gc, compiler (command) musl-gcc
[rqlited] 2024/12/29 08:30:44 go1.23.4, target architecture is arm64, operating system target is linux
[rqlited] 2024/12/29 08:30:44 launch command: /bin/rqlited -node-id rqlite-1 -http-addr <IP_ADDRESS>:4001 -http-adv-addr rqlite-1.rqlite-svc-internal.default.svc.cluster.local:4001 -raft-addr <IP_ADDRESS>:4002 -raft-adv-addr rqlite-1.rqlite-svc-internal.default.svc.cluster.local:4002 -disco-mode=dns -disco-config={"name":"rqlite-svc-internal"} -bootstrap-expect=3 -join-interval=1s -join-attempts=120 /rqlite/file/data
[mux] 2024/12/29 08:30:44 mux serving on [::]:4002, advertising rqlite-1.rqlite-svc-internal.default.svc.cluster.local:4002
[rqlited] 2024/12/29 08:30:44 preexisting node state detected in /rqlite/file/data
[cluster] 2024/12/29 08:30:44 service listening on rqlite-1.rqlite-svc-internal.default.svc.cluster.local:4002
[http] 2024/12/29 08:30:44 execute queue processing started with capacity 1024, batch size 128, timeout 50ms
[http] 2024/12/29 08:30:44 service listening on [::]:4001
[store] 2024/12/29 08:30:44 opening store with node ID rqlite-1, listening on rqlite-1.rqlite-svc-internal.default.svc.cluster.local:4002
[store] 2024/12/29 08:30:44 ensuring data directory exists at /rqlite/file/data
[store] 2024/12/29 08:30:44 old v7 snapshot directory does not exist at /rqlite/file/data/snapshots, nothing to upgrade
[snapshot-store] 2024/12/29 08:30:44 store initialized using /rqlite/file/data/rsnapshots
[store] 2024/12/29 08:30:44 0 preexisting snapshots present

[rqlited] 2024/12/29 08:30:44 rqlited starting, version v8.36.3, SQLite 3.46.1, commit 92bcff8e0b50570294c3d13f6b598821ad3daff6, branch master, compiler (toolchain) gc, compiler (command) musl-gcc
[rqlited] 2024/12/29 08:30:44 go1.23.4, target architecture is arm64, operating system target is linux
[rqlited] 2024/12/29 08:30:44 launch command: /bin/rqlited -node-id rqlite-2 -http-addr <IP_ADDRESS>:4001 -http-adv-addr rqlite-2.rqlite-svc-internal.default.svc.cluster.local:4001 -raft-addr <IP_ADDRESS>:4002 -raft-adv-addr rqlite-2.rqlite-svc-internal.default.svc.cluster.local:4002 -disco-mode=dns -disco-config={"name":"rqlite-svc-internal"} -bootstrap-expect=3 -join-interval=1s -join-attempts=120 /rqlite/file/data
[mux] 2024/12/29 08:30:44 mux serving on [::]:4002, advertising rqlite-2.rqlite-svc-internal.default.svc.cluster.local:4002
[rqlited] 2024/12/29 08:30:44 preexisting node state detected in /rqlite/file/data
[cluster] 2024/12/29 08:30:44 service listening on rqlite-2.rqlite-svc-internal.default.svc.cluster.local:4002
[http] 2024/12/29 08:30:44 execute queue processing started with capacity 1024, batch size 128, timeout 50ms
[http] 2024/12/29 08:30:44 service listening on [::]:4001
[store] 2024/12/29 08:30:44 opening store with node ID rqlite-2, listening on rqlite-2.rqlite-svc-internal.default.svc.cluster.local:4002
[store] 2024/12/29 08:30:44 ensuring data directory exists at /rqlite/file/data
[store] 2024/12/29 08:30:44 old v7 snapshot directory does not exist at /rqlite/file/data/snapshots, nothing to upgrade
[snapshot-store] 2024/12/29 08:30:44 store initialized using /rqlite/file/data/rsnapshots
[store] 2024/12/29 08:30:44 0 preexisting snapshots present

The only modification I did to the manifest was to open specify port 4002 to rqlite
https://github.com/rqlite/kubernetes-configuration/blob/03f69bc6fee6bbf2240b0491bdc3b20bb410adfb/service.yaml#L10
and in
https://github.com/rqlite/kubernetes-configuration/blob/03f69bc6fee6bbf2240b0491bdc3b20bb410adfb/statefulset-3-node.yaml#L22
Am I doing something wrong?

Does everything work if you don't specify the port 4002?

Basically it looks like you used the stateful-set-1 file to launch one node, and then used stateful-set-3 file to launch the other two.  Example bootstrap-expect in each file and you'll see what I mean.
Make sure you follow the instructions exactly. Alternatively you could try the Helm charts.
https://github.com/rqlite/helm-charts

Yes you are right, there was no need to specify port 4002 and the error was somewhere else, I think I did a mistake with the storage class, using the default storage class everything went up normally. Thanks!

Well, that doesn't entirely make sense due to what I said about the bootstrap option being wrong for node 1. I still think you are/did something else wrong too. But as long it's working now, that's good.


query annotations by label [REPLACEMENT ISSUE]

The original issue
Id: 54
Title: query annotations by label

could not be created.
This is a dummy issue, replacing the original one. It contains everything but the original issue description. In case the gitlab repository is still existing, visit the following link to show the original issue:
TODO

no useful info


Create OnRegistering & OnConventionalRegistering events and they should be triggered when registrations are begin

If RegisterAssemblyByConvention(Assembly) is called then

OnConventionalRegistering is triggered immediately for that Assembly.
OnRegistering is triggered for each conventional marked services (ITransientDepency, ISingletonDependency, ILifetimeScopeDependency)

If  any Register<TS,TI> or other Register methods are called then

OnRegistering is triggered for each of them

Thus we can intercept any registration that done by Autofac.Extras.IocManager and we do sort of things way what we want.

Closed with https://github.com/osoykan/Autofac.Extras.IocManager/commit/c19f84c4a5dd5a9b2022f44a4e465390a73aefc9


provide a run-once mode that disables container reuse

Today we reuse containers for performance reasons. There are many advantages however to run-once that disables container reuse. Just as @tysonnorris is adding support for intra-container concurrency via an opt-in annotation, we can do the same to prevent container reuse for an action annotated accordingly to create a new container every time. This has the nice property of ensuring that every function starts from the same pristine environment.

We'd be interested for security reasons. Any updates on this issue?


feat: allow optional installation of cluster role

This change allows the Helm chart be installed without including the creation of cluster-wide resources (ClusterRoles/ClusterRoleBindings). Specifically, this change supports the use case where the engineer installing the chart has limited (i.e. namespace only) access and cannot install cluster-wide resources. This change allows the cluster-wide resources to be installed separately by cluster administrators while still allowing the engineers to manage the operator itself without having full cluster-wide access.
It is understood that if clusterRole.create=false is set without the cluster role/cluster role binding being installed beforehand the operator will not function as expected but this gives the option to have the namespaced resources installed/managed by individuals with namepace-only access without giving access to create cluster-wide resources.

Hey. Just one question before we merge it. Does it work for you as expected, have you tested this?

Thanks for taking the time to take a look! Yes, this works as expected. The role definitions are the same as what you have in charts/aiven-operator/templates/cluster_role.yaml and charts/aiven-operator/templates/cluster_role_binding.yaml but would be installed via a separate step by a cluster administrator before this chart is installed by an engineer with namespace-only access.
I've also updated the docs indicating how others can make use of this setting.

@ryaneorth thanks for you contribution :+1:
I see one problem with that solution, operator will still try to listen for all namespaces regardless of the RBAC settings.
As you can see our Manager has no Namespaces restriction: https://github.com/aiven/aiven-operator/blob/d6fe2e8dc764dfdaff24916469331dd75f949df0/main.go#L58-L65
        // Namespace, if specified, restricts the manager's cache to watch objects in
	// the desired namespace. Defaults to all namespaces.
	//
	// Note: If a namespace is specified, controllers can still Watch for a
	// cluster-scoped resource (e.g Node). For namespaced resources, the cache
	// will only hold objects from the desired namespace.
	Namespace string

I would propose adding NewCache:  cache.MultiNamespacedCacheBuilder(namespaces), to the manager, more info on this here:  https://pkg.go.dev/sigs.k8s.io/controller-runtime/pkg/cache#MultiNamespacedCacheBuilder
And we can propagate namespaces as an environment variable (or a flag). If it is empty, Manager will be watching resources in ALL namespaces (the default behaviour we have now). In your use case, it will be watching resources only in a set of namespaces that we can configure using Helm chart.
@ryaneorth WDYT?
Moreover we can extend Helm charts with the logic to add RBAC only to the set of namespaces we want instead of the cluster wide role.


REFACTOR move parts of MetaTags to MetaComponents

resolves #5

I believe I've moved whatever's appropriate into MetaComponents. I'd love to get some tests written as well, however I'm not sure how quickly I'll be able to do that.

Thanks so much for this! I had a look through and left some comments.

I'll take this and finish it up. Thanks so much!

This is now in version 7.0.0 of the module, I had to remove updateSocialMetaTags hook because there was nothing left to update, which makes it a breaking change.

Thanks for merging, this week got away from me. We've already started using the module on a few projects, so once we get those caught up with the new tag I'll see if I can help a bit more with another pass on some of the feedback items.


Roles tab is missing in Applications

Describe the issue:
From the roles tab inside the application edit, we can configure the audienace of the roles and we can create/assign application roles to the application as well. Now that is not available in there.

This happened after the fix [1]. This config was validated in the application edit page[2]. This config was introduced for a previous version of the role management we need to come up with a solution for this.

Enable the applicationRoles.
Introduce a new config and find the references of the applicationRoles and change those configs to the new config to handle the new implementation.

[1] https://github.com/wso2/identity-apps/pull/6240
[2] https://github.com/wso2/identity-apps/blob/6d590c068d5e77cc2d3530703d1c1b291eeadd49/features/admin.extensions.v1/configs/application.tsx#L448
How to reproduce:

Go to console and create an app.
Go to edit page and the roles tab is not available there.

Expected behavior:

Roles tab should be available in the application edit.

Environment information (Please complete the following information; remove  any unnecessary fields) :

Product Version: wso2is-7.0.1-SNAPSHOT
OS: Mac
Database: H2
Userstore: JDBC

Closing the issue since this is done.


Look in to CircleCI

Lots of other projects are moving from travis to circle, citing benefits like improved build times.  With the recent acquisition of travis, it's worth investigating.

I suppose it would be worthwhile to look in to Azure DevOps or VSTS or whatever it's called these days; not sure whether MSFT offers free CI for open-source projects.

Bleh.  Due to permission issues, this isn't a viable change to make.


Api End point is exposed even if PropertyValue bool = false of Navigational property

Short summary (3-5 sentences) describing the issue.
Swagger displays API on the UI even if PropertyValue bool = false
OData validation rules do not currently check if annotations containing properties of navigation or property paths are valid or reachable
Assemblies affected
Which assemblies and versions are known to be affected e.g. OData .Net lib 7.x
Reproduce steps

We see that even though property value bool = false, we still see the API end points exposed on the swagger UI
The above IEdmModel is parsed and converted to OpenApiDocument and later which is displayed in swagger

The End points Put, Post and Delete should not be displayed as it is not reachable. This may be because of the property value attribute bool = false.
This causes an issue when trying to invoke these api’s
For Example If I try to post

As we can see the endpoint does not exists and there by we get 405 exception. Is the exception occurring due to property value attribute bool = false? And the swagger displaying the endpoint. What should be done to hide such API's
Expected result
All the API End points which are not reachable should not be displayed on swagger.
Actual result
The API End points which are not reachable are displayed on swagger.
Additional detail
Optional, details of the root cause if known. Delete this section if you have no additional details to add.

This issue should be filed with the library you're using to generate your API definition. In my experience it is not an issue with Swagger UI as that just renders what it's provided, so if it renders something you don't expect, it means whatever is generating the API definition provides it.


feat: improve analyze command

Closes #332
📑 Description
Made the following changes-

Added \n between yellow sections and the top of the yellow GPT response for better readability.
Made the index start from 1 instead 0 for the results.
Added index for the errors too.
Parentheses would be omitted if the value of result.ParentObject would be empty.

Here's a reference image for these issues-

✅ Checks

[x] My pull request adheres to the code style of this project
[ ] My code requires changes to the documentation
[ ] I have updated the documentation as required
[ ] All the tests have passed

There were two more changes suggested-

Hide the server could not find the requested resource errors by default (enable in verbose or details mode)
Hide internal cache related errors

but I am not being able to get around these. Can I get some help here?

I pushed a commit quickly, I think it can inspire you for the rework of the logs concerning the cache : https://github.com/k8sgpt-ai/k8sgpt/compare/main...matthisholleville:k8sgpt:feat/rework-cache-log

Made the index start from 1 instead 0.

👀

Made the index start from 1 instead 0.

eyes

For the results*

Hey @matthisholleville
From what I can understand, after going through your commit, we are now handling the cache errors in the ai package itself, rather than handling it in file_based.go but how can we hide the internal system errors?
I was thinking of just returning false from the file_based.go but that won't be a good idea, or would it be?

I think we should add a global argument to handle the verbosity of these logs

I think we should add a global argument to handle the verbosity of these logs

Ohh something like if a user provides --versbose then we print the logs else we just return something like error while testing if cache key exists, use --verbose to get more details

Is this ready for review?

Is this ready for review?

Nope, still have this question that do we introduce a --verbose flag to print the logs? I think Matthis is busy so can you help me out here?


[BUG] TypeError: expected str, bytes or os.PathLike object, not NoneType. File "", line 824, in fsdecode

setuptools version
75.2.0
Python version
3.11.8
OS
Ubuntu 20.04.6 LTS
Additional environment information
Server: Intel(R) Xeon(R) CPU E5-2695 v4 @ 2.10GHz
Python: 3.11.8 (conda)
pip: 24.2 (latest)
pandas-ta: 0.4.19b0 (latest)
attributedict: 0.3.0
Description
Problem: I can not import pandas-pta lib because of error below. I created issue on official page https://github.com/twopirllc/pandas-ta/issues/831, but author said I need to ask here. Error is because of importing attributedict lib. Without it everything works.
Expected behavior
print('ok')
How to Reproduce
# Version: 0.3.0
from attributedict.collections import AttributeDict

# Version: 0.4.19b0
import pandas_ta as pta

if __name__ == "__main__":
    print('ok')

Output
Traceback (most recent call last):
  File "/home/sirjay/python/ethereum/test_pta/eth_newHeads.py", line 4, in <module>
    import pandas_ta as pta
  File "/home/sirjay/miniconda3/envs/eth/lib/python3.11/site-packages/pandas_ta/__init__.py", line 7, in <module>
    from pandas_ta.maps import EXCHANGE_TZ, RATE, Category, Imports, version
  File "/home/sirjay/miniconda3/envs/eth/lib/python3.11/site-packages/pandas_ta/maps.py", line 4, in <module>
    from pkg_resources import get_distribution, DistributionNotFound
  File "/home/sirjay/miniconda3/envs/eth/lib/python3.11/site-packages/pkg_resources/__init__.py", line 3672, in <module>
    @_call_aside
     ^^^^^^^^^^^
  File "/home/sirjay/miniconda3/envs/eth/lib/python3.11/site-packages/pkg_resources/__init__.py", line 3656, in _call_aside
    f(*args, **kwargs)
  File "/home/sirjay/miniconda3/envs/eth/lib/python3.11/site-packages/pkg_resources/__init__.py", line 3685, in _initialize_master_working_set
    working_set = _declare_state('object', 'working_set', WorkingSet._build_master())
                                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/sirjay/miniconda3/envs/eth/lib/python3.11/site-packages/pkg_resources/__init__.py", line 652, in _build_master
    ws = cls()
         ^^^^^
  File "/home/sirjay/miniconda3/envs/eth/lib/python3.11/site-packages/pkg_resources/__init__.py", line 645, in __init__
    self.add_entry(entry)
  File "/home/sirjay/miniconda3/envs/eth/lib/python3.11/site-packages/pkg_resources/__init__.py", line 701, in add_entry
    for dist in find_distributions(entry, True):
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/sirjay/miniconda3/envs/eth/lib/python3.11/site-packages/pkg_resources/__init__.py", line 2281, in find_distributions
    importer = get_importer(path_item)
               ^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/sirjay/miniconda3/envs/eth/lib/python3.11/pkgutil.py", line 416, in get_importer
    path_item = os.fsdecode(path_item)
                ^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen os>", line 824, in fsdecode
TypeError: expected str, bytes or os.PathLike object, not NoneType

Hi @fridary, the code you highlighted iterates over sys.path, so it is indeed surprising that it is finding a None object.
Could you please double check that all the entries in sys.path are not None in your environment, before AND after importing the attributedict?

@abravalheri is it what you are asking for?
Before importing attributedict:
/home/sirjay/python/ethereum
/home/sirjay/miniconda3/envs/eth/lib/python311.zip
/home/sirjay/miniconda3/envs/eth/lib/python3.11
/home/sirjay/miniconda3/envs/eth/lib/python3.11/lib-dynload
/home/sirjay/.local/lib/python3.11/site-packages
/home/sirjay/miniconda3/envs/eth/lib/python3.11/site-packages

After importing attributedict:
/home/sirjay/python/ethereum
/home/sirjay/miniconda3/envs/eth/lib/python311.zip
/home/sirjay/miniconda3/envs/eth/lib/python3.11
/home/sirjay/miniconda3/envs/eth/lib/python3.11/lib-dynload
/home/sirjay/.local/lib/python3.11/site-packages
/home/sirjay/miniconda3/envs/eth/lib/python3.11/site-packages
None found in sys.path!

Traceback (most recent call last):
  File "/home/sirjay/python/ethereum/test31_del.py", line 21, in <module>
    import pandas_ta as pta
  File "/home/sirjay/miniconda3/envs/eth/lib/python3.11/site-packages/pandas_ta/__init__.py", line 7, in <module>
    from pandas_ta.maps import EXCHANGE_TZ, RATE, Category, Imports, version
  File "/home/sirjay/miniconda3/envs/eth/lib/python3.11/site-packages/pandas_ta/maps.py", line 4, in <module>
    from pkg_resources import get_distribution, DistributionNotFound
  File "/home/sirjay/miniconda3/envs/eth/lib/python3.11/site-packages/pkg_resources/__init__.py", line 3672, in <module>
    @_call_aside
     ^^^^^^^^^^^
  File "/home/sirjay/miniconda3/envs/eth/lib/python3.11/site-packages/pkg_resources/__init__.py", line 3656, in _call_aside
    f(*args, **kwargs)
  File "/home/sirjay/miniconda3/envs/eth/lib/python3.11/site-packages/pkg_resources/__init__.py", line 3685, in _initialize_master_working_set
    working_set = _declare_state('object', 'working_set', WorkingSet._build_master())
                                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/sirjay/miniconda3/envs/eth/lib/python3.11/site-packages/pkg_resources/__init__.py", line 652, in _build_master
    ws = cls()
         ^^^^^
  File "/home/sirjay/miniconda3/envs/eth/lib/python3.11/site-packages/pkg_resources/__init__.py", line 645, in __init__
    self.add_entry(entry)
  File "/home/sirjay/miniconda3/envs/eth/lib/python3.11/site-packages/pkg_resources/__init__.py", line 701, in add_entry
    for dist in find_distributions(entry, True):
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/sirjay/miniconda3/envs/eth/lib/python3.11/site-packages/pkg_resources/__init__.py", line 2281, in find_distributions
    importer = get_importer(path_item)
               ^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/sirjay/miniconda3/envs/eth/lib/python3.11/pkgutil.py", line 416, in get_importer
    path_item = os.fsdecode(path_item)
                ^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen os>", line 824, in fsdecode
TypeError: expected str, bytes or os.PathLike object, not NoneType

import sys

# Check before importing
print("Before importing attributedict:")
for path in sys.path:
    if path is None:
        print("None found in sys.path!")
    else:
        print(path)

from attributedict.collections import AttributeDict

print("\nAfter importing attributedict:")
for path in sys.path:
    if path is None:
        print("None found in sys.path!")
    else:
        print(path)

import pandas_ta as pta

Yes, so for some reason,attributedict is adding None to sys.path, which seems to be the root cause of the problem.
That does not seem quite right, does it?
According to the docs, it's supposed to contain a list of strings: https://docs.python.org/3/library/sys.html#sys.path
You should probably try contacting attributedict about that.


There is a Newer Version available...

I found a newer version here:
https://github.com/SamDel/ChromeCast-Desktop-Audio-Streamer
Seems to work very well !!!

Awesome! Thanks for referencing it here :-)


Cannot preview media files in remote azure repo

Testing #177535
This doesn't work for me when I click the file from the explorer or in the markdown preview

https://user-images.githubusercontent.com/29464607/226638076-a5136d63-4508-48b8-bbcf-9f04ff712cbc.mov

The mp4 link needs to be video tag syntax, but for the gif and png I cannot repro, are you on the latest pre-release of Azure Repos? If you right click on the file and select reopen with text editor what do you see?

Here's the gif if you want to see if it reproduces for you with this

@meganrogge that is the pre-release of Remote Repos, can you also provide the version number of the Azure Repos extension please?

Hm that gif works exactly as expected for me (both opening the file directly and as a referenced artifact in markdown preview in an Azure Repos repo). I saved it under filepaths with and without spaces in the path and it works as expected both ways, so I'm not sure what's going on, are there any errors in the logs?
Not that it should matter, but it looks like you're editing a repo that doesn't have LFS tracking enabled. Were you able to confirm that committing LFS files works in Azure Repos for a repo that does have LFS tracking set up?

How do I enable LFS tracking for that repo or check whether that's enabled?

I set up my own Azure org, imported the vscode-docs repo, opened the remote repository, committed LFS-tracked files, and that worked


Update to 5.0.0~rc1-1

https://www.elastic.co/guide/en/logstash/5.0/installing-logstash.html

LGTM :heart:

Oh man, forgot this repo has a template: 21dab9683ac2c3fcf89d5eef107bace618c3b294

Updated template/update.sh in e74e696dafc84ae97fa50b5341bd2126cb66d61e

(Full diff from before this PR to after it: https://github.com/docker-library/logstash/compare/e8bb8f5b6dafbfb010797d1f90d4d3b3e36a26f4...e74e696dafc84ae97fa50b5341bd2126cb66d61e)


Add age column to generated crd yaml

our pre-commit should be expanded to prevent this.   I'll take a look at what codeflare is doing and back port.