[BUG] ACF.GetHitAngle occasionally receiving invalid HitNormal

Description
Under rare circumstances, the ACF.GetHitAngle will get called despite having no valid hitnormal. To fix this we need more information, such as the whole bullet data table instead of the current hitnormal and bulletvel, so that it can get dumped to console when the error is called.
https://github.com/Stooberton/ACF-3/blob/75c9e33f0d65a2e9d0288e78bebab86cb87e6891/lua/acf/base/util/sh_util.lua#L309
Once we get more information we can narrow down any fatal flaws in bullet calculations, as the function will return a 0, which is equivalent to a direct hit, possibly causing issues with damage being higher than it should.
Branch and Version
All branches, all versions after error check was initially made (with the replacement of the original function).
Console Error Logs (Optional)
invalid angle in ACF.GetHitAngle
>HitNormal: 0.000000 0.000000 0.000000, HitDir (BulletVel): 7200.185547 2.327452 -53.340588
How to Reproduce (Optional)
Inconsistent when it occurs, requires a slight change to the function to take the BulletData to dump to console when this occurs.

Fixed in f3fcaa4a54e063e413a4326e998ec8ff5461c04a
When shooting at a prop, particularly one that is moving towards the shooter, it is possible for the trace to start inside an object.
Traces exhibit unexpected behavior in two relevant ways in this case:

Ending inside an object produces a HitNormal of 1, 0, 0
Starting and ending inside an object produces a fraction of 0 and normal of 1, 0, 0

In the event of issue 1 a ray-mesh intersection is run to calculate the real HitNormal value using the function's second argument rayNormal (usually bullet.Flight) as the ray direction to circumvent issue 2.


Explore implications of compiling to Webgl and gopherjs

Specifically, I'm curious about file size and performance overhead.
Initial attempts to get a Gopherjs binary for a hello world was 900kb of JavaScript. I stopped there, but then found this thread:
https://github.com/gopherjs/gopherjs/issues/136
This indicates much, much smaller binaries are possible. Need to look more closely at some point.
We'll also need a WebglSurface adapter and from that thread, me might need to limit our usage of Reflection and Time primitives to minimize file sizes.

Introduced browser build target(s) and verified build as of 6/13/2018.
The compiled and minified JS bundle is ~1MB, and gzips to 175kb. This feels way too big, but there might be some simple and large parts of the stdlib that are getting pulled in for no good reason. Worth checking further.

Done


Create a User Interface with CAP (SAP HANA Cloud)

Tutorials: https://developers.sap.com/tutorials/hana-cloud-cap-create-ui.html
Once completed this step (as well as the following authentication step) I find that I cannot build the MTA without it going into an infinite loop and using up all the disk space in my BAS workspace.
To be able to build the MTA I had to add this to the ui deployer module:
build-parameters:
      ignore: [".*/"]

Now that I have a built MTA if I try and deploy it, it fails on the ui deployer.
Error uploading content module "MyHANAApp_ui_deployer" in service "MyHANAApp_html_repo_host" /// + heaps more

When I look at the ui deployer module in the mat file I see this:
  - name: MyHANAApp_ui_deployer
    type: com.sap.application.content
    path: .
    requires:
      - name: MyHANAApp_html_repo_host
        parameters:
          content-target: true
    build-parameters:
      ignore: [".*/"]

This does not seem right to me. It missing the bit about what .zip file to pick up that contains the built app? I have re-done the tutorial a second time and got exactly the same result. Any ideas what I could be doing wrong?
I also cant see any ui5 tooling yaml file which build the Fiori app?
Thanks, Jason.

The first item you hit is a bug in the MBT tool that is known and being addressed.
Building the MTAR and deploying the full project is not actually within the scope of this tutorial. We've tried to keep the deployment descriptor (mta.yaml) up to date in this tutorial but the focus on the development experience. There are other tutorials that cover the deployment process and that step might require additional adjustments to the mta.yaml beyond what the wizard has generated into the mta.yaml at this point.

oh. ok thanks or the update. Do you have a specific tutorial in mind on how to convert this to a deployable project? The other tutorials are structured quite differently without moving the html5 modules under the app folder (which doubles as the approuter).
I can easily add a ui5.yaml to build the Fiori app and adjust the package.json (of the Fiori app) to do that but that's where I get lost. Do we need to have a new module for the Fiori app in the MTA to make it deployable?

I did add a new tutorial for the deployment steps.  I didn't adjust the project structure but instead the mta.yaml and used the build-parameters/ignore to optimize the output even with the CAP service running from the root.
I did choose to remove the HTML5 repo UI deployer section and run the UI5 content directly from the Application Router. I wanted to simplify things for those that aren't used to the more advanced UI deployment options. But I tried to leave in some explanation of those other options.
https://developers.sap.com/tutorials/hana-cloud-cap-deploy-mta.html

@jung-thomas brilliant - thanks!
Will test this out tomorrow and will try and get the html5 repo working with it as well.


Strip link extensions

Make https://redisred.herokuapp.com/hello.png equivalent to https://redisred.herokuapp.com/hello if target hellog.png is not registered already (i.e. strip "file" extension).
This allows forums which filter on valid sources for [img] tags being png/gif/jpg static files to be fooled to redirect to svg or any dynamic content (github badges?).
http://ow.ly does it.

I guess I don't understand fully - if hello.png isn't registered, why can't you just manually redirect hello.png to /hello (if you don't supply a http:// it redirects to the relative path). Then, you can make the hello redirect whatever you want

Oops, my bad. I though keys were sanitized (as all other redirectors do).
Will close this now.


feat(AlgebraicGeometry/ProjectiveSpectrum/Scheme): morphism of locally ringed space $\mathrm{Proj}|_{D(f)} -> \mathrm{Spec} A^0_f$

We construct a morphism of locally ringed spaces α : Proj| (pbo f) ⟶ Spec.T A⁰_f as the following: by the Gamma-Spec adjunction, it is sufficient to construct a ring map A⁰_f → Γ(Proj, pbo f) from the ring of homogeneous localization of A away from f to the local sections of structure sheaf of projective spectrum on the basic open set around f. The map A⁰_f → Γ(Proj, pbo f) is constructed in awayToΓ and is defined by sending s ∈ A⁰_f to the section x ↦ s on pbo f.

Co-authored-by: Andrew Yang<EMAIL_ADDRESS>

Thanks!
bors merge


Update Cardano-node on test stack

Sanchonet has been respin and new version of node is updated.
Release page : https://github.com/IntersectMBO/cardano-node/releases/tag/8.11.0-sancho
Acceptance Criteria:

[ ] Update node version in docker stack configuration file to 8.11.0
[ ] Updated version of docker stack is deployed and test stack is ready for use.

It's added as part of https://github.com/IntersectMBO/govtool/pull/1041


getting a simple DBC file to be interpreted

Have a simple dbc file and small log file i am trying to validate that the dbc was assembled correctly and i must be missing something because I am unable interpret any frames.  Any help or guidance would be terrific.  Alarm_Warning is a dbc file.
Alarm_Warning.txt
8-9-2022_Last_Log.csv

On mobile, so just took a quick glance. I think your can ids might be off. Have you checked them?
Example for message Channel_Faults:

Dec in dbc:<PHONE_NUMBER>
Hex: 0x98FF2AAA
Hex minus 0x80000000: 0x18FF2AAA

Thanks juleq,  I will try that now and let you know. I originally developed the dbc from a table I was supplied from my work team.   If I still have issues will share the table details.

Thanks juleq,  appears I somehow modified the can ids.  Channel_fault message dec in dbc is 16722264,  hex 0xff2a20.  I originally used Kvaser dbc editor to create.  I developed from the attached few lines on table using PGN dec 65322.  Either way still must have something wrong as I am unable to interpret frames.   I am using savvy v204 which in DBC file manager shows its loaded.  My apologies for providing wrong dbc yesterday  in my question.  DBC is alarm_warning.
Alarm_Warning.txt
Alarm_Warning_Table.xlsx
8-9-2022_Last_Log.csv
.

There might still be something off with your id construction.
You can try an online calculator to check, like this one (there might be others, too):
J1939 ID to PGN calculator


Fix autofill for full name input row

cc @luacmartins
Details

Fix autofill for first and last name on the profile page and the request a call modal. For some reason first and last name fill separately on the profile page and they fill simultaneously on the request a call modal. I'm not sure why that is, but I think any autofill is better than none.
Fixed Issues

$ https://github.com/Expensify/App/issues/7529
Tests

First set up autofill:

For Chrome go to chrome://settings/addresses
For Mobile Web Safari go to Settings > Safari > Autofill and turn on 'Use Contact Info'

Add an address and enter a first and last name in the name field. Add a phone number including a country code (e.g, +1-945-881-9540).

Then test autofill on the profile page and the request a call modal.

Create a new account on new expensify.

Go to Settings > Profile.

Click into the first name field.

Make sure you see an autofill prompt like so:

Click the autofill prompt and verify that the first name is entered.

Click into the last name field

Click the autofill prompt and verify that the last name is entered.

Click save and make sure it is successful.

Create a chat with concierge.

Click the call button in the upper right.

Click into the first name field and make sure you see an autofill prompt.

Click the autofill prompt and verify that the first name, last name, and phone number are entered.

Click 'Request a Call' and make sure that it is successful.

[ ] Verify that no errors appear in the JS console

QA Steps

Same as the test steps above.

[ ] Verify that no errors appear in the JS console

Tested On

[x] Web
[x] Mobile Web
[ ] Desktop
[ ] iOS
[ ] Android

Screenshots

Web

https://user-images.githubusercontent.com/26260477/155400538-6b9404c1-4e97-4f57-8b2e-23beacb0c1d2.mov
Mobile Web

https://user-images.githubusercontent.com/26260477/155401074-ec51fa75-aca3-4778-b15a-cb6f0ee73107.mp4
Desktop

iOS

Android

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @nickmurray47 in version: 1.1.41-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
failure ❌

🚀 Deployed to staging by @nickmurray47 in version: 1.1.41-0 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
failure ❌

Seems like Applause could not verify this worked as expected: https://github.com/Expensify/App/issues/7982

🚀 Deployed to production by @francoisl in version: 1.1.41-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

Issue 1 -
Title - [Medium] Chrome: Color Contrast: Insufficient color contrast for text.
Actual - Background/foreground color combinations with an insufficient contrast ratio was found on text. For instance, the #7D8B8F "The current wait time is 0 minutes.  Please note that our Guides are typically available from Sunday at 5pm CT to Friday at 5pm CT.Call me" text has an insufficient color contrast ratio of 3.5.1 with a #FFFFFF background.
Expected - The "The current wait time is 0 minutes.  Please note that our Guides are typically available from Sunday at 5pm CT to Friday at 5pm CT.Call me" text should have a contrast ratio against the page background of 4.5:1 or greater.
WCAG failure - 1.4.3
Reproducible in staging?: - Yes
Version Number: - v1.1.40-2
Platforms - Web, Desktop, Mobile-web, iOS
Suggested Fix - Ensure that each text/background color combination presents a contrast ratio of at least 4.5:1.
Note - Due to the installation of the build not able to check on the Android.

Issue 2 -
Title - [Medium]: Chrome+Jaws : Insufficient color contrast for form controls.
Actual - Background/foreground color combinations with an insufficient contrast ratio was found on the screen. For instance, the #ECECEC border of "First name", "Last name", "Phone number" and "Extension (Optional)" form fields has a contrast ratio of 1.2:1 with the #FFFFFF background.
Expected - The border of the input field should have a contrast ratio against the page background of 3:1 or greater.
WCAG failure - 1.4.11
Reproducible in staging? - Yes
Version Number: - v1.1.40-2
Platforms - Web, Desktop, Mobile-web, iOS
Suggested Fix - Ensure that the color contrast for all user interface controls in their default as well as active, hover, and focus states is 3:1 with the adjacent content.
Note - Due to installation of build not able to check on 'Android'.

Issue 3 -
Title - [High]: Chrome+Jaws : Screen reader: Role and label are not defined for "back" control.
Actual - Role is not defined for the "back (<)". interactive element. This made it difficult for screen reader users to access the functionality associated with it. Additionally, the label is not defined for the mentioned interactive element in the source code of the page.
Expected - When a role is defined appropriately for the interactive element, the screen reader user will interact with the element effectively.
WCAG failure - 4.1.2, 2.5.3
Reproducible in staging? - Yes
Version Number: - v1.1.40-2
Platforms - Web, Desktop, Mobile-web, iOS
Suggested Fix - Ensure that all the page functionality is available for all users irrespective of the device being used.
Apply the following changes:

Specify role="button" for the 'div' element containing the "back (<)" control.
Provide aria-label value such as "back" for the 'div' element containing the "back (<)" control.

Note - Due to installation of build not able to check on 'Android'.

Issue 4 -
Title - [High]: Chrome+Jaws: Screen reader: Role is not defined for 'Call me' control.
Actual - Role is not defined for the "Call me" control. This made it difficult for screen reader users to access the functionality associated with it.
Expected - Role should be defined as a 'button' for the "Call me" control.
WCAG failure - 4.1.2
Reproducible in staging?: - Yes
Version Number: - v1.1.40-2
Platforms - Web, Desktop, Mobile-web, iOS
Suggested Fix - Ensure that all the page functionality is available for all users irrespective of the device being used.
Apply the following changes:

Specify role="button" for the 'div' element containing the "Call me" control.

Note - Due to installation of build not able to check on 'Android'.

Issue 5 -
Title - [Medium] Chrome: Color Contrast: Insufficient color contrast for 'Call me' control.
Actual - Background/foreground color combinations with an insufficient contrast ratio was found on control. For instance, the #03D47C "Call me" control text has an insufficient color contrast ratio of 2.0.1 with a #FFFFFF background.
Expected - The "Call me" text control should have a contrast ratio against the page background of 4.5:1 or greater..
WCAG failure - 1.4.3
Reproducible in staging?: - Yes
Version Number: - v1.1.40-2
Platforms - Web, Desktop, Mobile-web, iOS
Suggested Fix - Ensure that each text/background color combination presents a contrast ratio of at least 4.5:1.
Note - Due to the installation of the build not able to check on the Android.

Issue 6 -
Title - [Medium] Chrome: Color Contrast: Insufficient color contrast for error message text.
Actual - Background/foreground color combinations with an insufficient contrast ratio was found on error message text (which becomes available when "Phone number field is empty"). For instance, the #FC3826 "Please enter a valid phone number without brackets or dashes. If you're outside the US please include your country code, eg. +447782339811" text has an insufficient color contrast ratio of 3.7.1 with a #FFFFFF background.
Expected - The "Please enter a valid phone number without brackets or dashes. If you're outside the US please include your country code, eg. +447782339811" error message text should have a contrast ratio against the page background of 4.5:1 or greater.
WCAG failure - 1.4.3
Reproducible in staging?: - Yes
Version Number: - v1.1.40-2
Platforms - Web, Desktop, Mobile-web, iOS
Suggested Fix - Ensure that each text/background color combination presents a contrast ratio of at least 4.5:1.
Note - Due to the installation of the build not able to check on the Android.


Changes to build tool plugin sources do not cause targets using that plugin to rebuild

Is it reproducible with SwiftPM command-line tools: swift build, swift test, swift package etc?

[X] Confirmed reproduction steps with SwiftPM CLI. The description text must include reproduction steps with either of command-line SwiftPM commands, swift build, swift test, swift package etc.

Description
If I have a build tool plugin (in my case, Java2SwiftPlugin) and a target that uses it (JavaProbablyPrime), once the target has built, changes to the sources of Java2SwiftPlugin won't cause that target to rebuild.
Expected behavior
The implementation of a build tool plugin can affect the build of any targets that use that plugin. When the sources to the build tool plugin change, I'd expect those targets to rebuild.
Actual behavior
Changes to the build tool plugin sources do not cause targets using that plugin to rebuild.
Steps to reproduce

git clone https://github.com/swiftlang/swift-java (tested at b9122bde780a7b66080a6065707977718357cac1)
cd Samples/JavaProbablyPrime
swift build (build succeeds)
Put a fatalError at the beginning of  createBuildCommands in Plugins/Java2SwiftPlugin/Java2SwiftPlugin.swift (patch below)
cd Samples/JavaProbablyPrime  if not already there
swift build (should fail due to fatal error, but doesn't rebuild so it doesn't fail)

Swift Package Manager version/commit hash
6.0
Swift & OS version (output of swift --version ; uname -a)
swift-driver version: 1.115 Apple Swift version 6.0 (swiftlang-<IP_ADDRESS>.10 clang-16<IP_ADDRESS>)
Target: arm64-apple-macosx15.0

The "patch" to add the fatalError is this:
diff --git a/Plugins/Java2SwiftPlugin/Java2SwiftPlugin.swift b/Plugins/Java2SwiftPlugin/Java2SwiftPlugin.swift
index 30be39a..4e753a3 100644
--- a/Plugins/Java2SwiftPlugin/Java2SwiftPlugin.swift
+++ b/Plugins/Java2SwiftPlugin/Java2SwiftPlugin.swift
@@ -20,6 +20,7 @@ fileprivate let Java2SwiftConfigFileName = "Java2Swift.config"
 @main
 struct Java2SwiftBuildToolPlugin: BuildToolPlugin {
   func createBuildCommands(context: PluginContext, target: Target) throws -> [Command] {
+    fatalError("Java2SwiftBuildToolPlugin is not supported.")
     guard let sourceModule = target.sourceModule else { return [] }

     // Note: Target doesn't have a directoryURL counterpart to directory,

@dschaefer2 i think this is a great repro for the missing rebuilds I had mentioned a couple months back


create_address -- no longer there in #cpp branch

Hi,
I am adding this as a separate issue here and realize that this is not related to the master branch. But for our intents we are relying on the cpp branch as that branch can be packaged by the latest version of react-scripts.
However, earlier using the code in the master branch, we were able to generate a public address and private spend key, by providing a seed (and networkType) to the mymoneroCoreJs.monero_utils.create_address function like so:

this.account = mymonero.monero_utils.create_address(this.moneroSeed, this.netType);

and then elsewhere use this.account to get:
let pubAddress = moneroAccount.account.public_addr
let privateKey = moneroAccount.account.spend.sec

With the #cpp branch, the create_address function is no longer available. So how do we go about getting the public address and the private spend key?

Hi, the function for creating a wallet on master was in monero_wallet_utils, NewlyCreatedWallet or similar. Nowadays it's on monero_utils called newly_created_wallet, and it returns all the info you requested.

Hey @paulshapiro ,
The function that seems to meet our needs is seed_and_keys_from_mnemonic.
From what I can see in the code, This function expects the mnemonic (instead of the seed that the removed create_address used.
However, when I call the
this.account = mymonero.monero_utils.seed_and_keys_from_mnemonic(this.mnemonic, this.netType);

it is complaining that
You must call OnceModuleReady to wait for _CNCrypto to be ready

Adding this line before I call seed_and_keys_from_mnemonic:
mymonero.monero_utils.OnceModuleReady();
does not help.
TypeError: mymonero.monero_utils.OnceModuleReady is not a function

Hi @bityogi ah yes thanks for pointing this out. It's a regression from one of the last things I did.

Hey @paulshapiro ,
Could you specify how I should be using this function, or does this require a change in the code base for us to be able to use it?
For now, I can't create wallets using monero_utils.seed_and_keys_from_mnemonic(this.mnemonic, this.netType); because of the You must call OnceModuleReady to wait for _CNCrypto to be ready error.
Thanks so much for all your help on this.

In a few moments I'll push my fix and update you

Hi @bityogi, the issue was merely that OnceModuleReady was missing from the bridge between the interface to monero_utils and the functions in cryptonote_utils. These files are going to get renamed soon for clarify. You can go ahead and call OnceModuleReady now, and I've clarified the tests to show you how to do it. You just go
monero_utils.OnceModuleReady(function() {
    monero_utils.create_address(…) …
})

Eventually I would like to promisify this stuff so that someone has the option of doing async-await to roll these two steps into one. If they do, the usage of the function loaded_CNCrypto within cryptonote_utils can be removed since blocking until load would no longer be necessary.

And for what it's worth I'm also going to be able to remove the whole bridging code in monero_utils.js once I get mymonero-core-cpp going as a Node.JS native addon which works with Electron. That will be mymonero-core-nodejs.

Hi @paulshapiro ,
I'm not sure I quiet understand this usage:
I tried something like this:
     this.mnemonic = mnemonic;

     this.netType = network === 'test' ? mymonero.nettype_utils.network_type.STAGENET : mymonero.nettype_utils.network_type.MAINNET;

        let account;

        mymonero.monero_utils.OnceModuleReady(() => {
            account = mymonero.monero_utils.seed_and_keys_from_mnemonic(this.mnemonic, this.netType);
            console.log('seed_and_keys executed! account: ', account);
        });
        this.account = account;```

From what you have in your `tests`:

mymonero.monero_utils.OnceModuleReady(function(Module)
{
var decoded = mymonero.monero_utils.decode_address(
"49qwWM9y7j1fvaBK684Y5sMbN8MZ3XwDLcSaqcKwjh5W9kn9qFigPBNBwzdq6TCAm2gKxQWrdZuEZQBMjQodi9cNRHuCbTr",
nettype,
);
console.log("decoded", decoded)
})

What is this `Module` that you are sending in as an argument? (I noticed in the code that you are calling methods of of this `Module`), but your example in the [comment above](https://github.com/mymonero/mymonero-core-js/issues/55#issuecomment-418463814) and my code don't have this is an argument.

Just ignore Module

Promisifying won't really simplify much. It's already functioning in the same way. You have to wait monero_utils itself to become ready before you call stuff on it. That's what OnceModuleReady is for.

One reason I haven't promisified the API is that combining the async module load with each call makes each of them asynchronous; in other words, it sacrifices the ability to do any calls synchronously. Meanwhile one could instead simply front-load the wait with the present method.

mymonero.monero_utils.OnceModuleReady(() => {
           console.log('OnceModuleReady!');
            account = mymonero.monero_utils.seed_and_keys_from_mnemonic(this.mnemonic, this.netType);
            console.log('seed_and_keys executed! account: ', account);
        });

In the above code, the line console.log('OnceModuleReady') is NEVER called.

Can you trace it out and see where it's getting stuck? I'm not able to reproduce this. Run tests/index.node.js.

Just dealing with an emscripten issue blocking promise/await'd loading

Hey @paulshapiro ,
When I load this library in a standalone node.js app, I am able to execute the code in the function I send to OnceModuleReady.
However, it never executes the function passed to OnceModuleReady in our electron app. I know you load the monero_utils through some other way if its an electron app and wondering if that is an issue.
On a separate note, I'm wondering if it would be better to do the necessarily loading in some sort of a constructor which would make it easy for the people using this library down-stream.
i.e,
const MoneroCore = require(`mymonero-core-js`);

let myMonero = new MoneroCore(); //Do what OnceModuleReady does in here

// use library without having to call any other extraneous code or wrap it inside some other function
myMonero.monero_utils.seed_and_keys_from_mnemonic();

Just dealing with an emscripten issue #5820 related to promise/await'd loading

OK, I missed this comment. This might be the issue then.

So if you never had to call OnceModuleReady and could still call methods synchronously (so that async code doesn't have to pollute your app code), how do you feel about an API like this?
require("../monero_utils/monero_utils").then(function(monero_utils) { });
Then you just call your monero_utils function in there.

Hm it, of course, still disturbs the previously synchronous functions which must import monero_utils. Will need to keep fiddling with this.

So I think the way I'm going to do this is require that every function which (a) must remain synchronous and (b) wants to use monero_utils must take a monero_utils as an argument. Things like requestURI parsing, key image generation, etc.

Hi @bityogi please look at the updated cpp branch. It functions as I mentioned just before. Just require monero_utils and it will handle doing the IPC to your electron remote for you.

Hi @paulshapiro ,
We were primarily using this library to generate addresses for our monero cold wallets by providing our own mnemonic.
I have for now been able to integrate source code from this site, and it seems to be working. It has added a lot of size to our code bundle but it seems to be working.
Nevertheless, I'll try it over the weekend as well to let you know if this code base is also compatible.

Hey @paulshapiro ,
Actually, the code in the site may also not work, but neither would the function we were using in the cpp branch -- seed_and_keys_from_mnemonic().
We are using extended pub/priv keys to generate multiple wallets using the same mnemonic.
i.e, we'll create the privateKey ourselves
Something akin to this:
mnemonic -> extenedPrivateKey --> PrivateKey at a particular index
Then use this privateKey as the seed to generate the account information (address, viewKeys, etc) for the monero wallet.
The code in the master branch accomplished this using create_address(seed, networkType) (the seed was the privateKey we generated above.
Is there anything like this create_address function that we could possibly use in the cpp branch?

Scratch this, now I get what you're saying.

Thanks for your understanding. Just to re-iterate, we are creating multiple wallets (with different address, view/spend keys)... but we use the same mnemonic.
Basically the same as using one extended private key to generate child private-keys/public-keys/addresses.
This is why the create_address was perfect for us, because it just accepted whatever privateKey we gave it as a seed.
Do you think this will be implemented in cpp?

I probably don't have an issue adding create_address to my list of new functions to add but let me be clear that you can already do what you want – you just need to take whatever "child seed" you're generating, convert it to mnemonic, then call seed_and_keys_from_mnemonic, so at best you're saving the computational overhead of converting a seed to a mnemonic… but it sounds to me like the work you're doing to to generate child keys should actually already be in the core... do you know if it is or isn't, and if not, why it's not ?

I'll try the code in the cpp branch based on the test you have for decode and let you know of my findings.

Hello @paulshapiro , I've tried this code as well, but the problem remains the same:
here is my code:
async function getMoneroMnemonic(seed) {
    let deferred = Q.defer();
    try {
        console.log('getting monero mnemonic using seed: ', seed);
        let mnemonic = (await mymonero.monero_utils_promise).mnemonic_from_seed(seed, 'english');
        console.log('mnemonic from monero: ', mnemonic);
        deferred.resolve(mnemonic);
    } catch (error) {
        console.error('error in getMoneroMnemonic: ', error);
    }
    return deferred.promise;
}

The code hits the line:
console.log('getting monero mnemonic using seed: ', seed);
But never hits the line:
console.log('mnemonic from monero: ', mnemonic);

Hey, so I've just pushed create_address as requested, however, just note that I've changed the name and slightly changed the return format. I'm going to document the JS API soon. But, the documentation for the return format can at least be found in the JSON API documentation on mymonero-core-cpp.
New name for create_address is address_and_keys_from_seed.
Returns an object containing: err_msg: String OR address_string: String, pub_spendKey_string: String, pub_viewKey_string: String, sec_viewKey_string: String, and sec_spendKey_string: String
Test https://github.com/mymonero/mymonero-core-js/blob/develop/tests/monero_utils.spec.js#L45
Added in https://github.com/mymonero/mymonero-core-js/commit/299c0c4bd65e29a5983361bbf478ddcc14d9ecd8

Yep that code is shared with mymonero.com, and was the precursor to the original mymonero-core-js which had create_address. Enjoy!


Add labeled address to page title

An address with a label should have its label appear in the page title. This would make bookmarks and page history easier to manage in the browser.

do you mean the textual representation of it? i.e. ENS name, hardcoded name, etc.?

Yes, exactly. If it has a text label, any of those, it should appear somewhere in the page title once it is determined.

ok, we can iterate over it.


[hplsql] hplsql_session reuse solution

What changes were proposed in this pull request?

Solving the session_reuse problem
adding application='hplsql' for HPLSQL mode

needed to add the application='hplsql' otherwise, it will use the simple HIVE mode. (https://github.com/cloudera/hue/pull/2576/files#diff-95ac03d3f59e20ed88fa520fef4c4235e09158ff94327d7a859f6991baafdea8R181)
Any other good way to solve the problem of reuse_session? @romainr

What I found is that
1-> So here we are searching for session in Session model.
2 -> and here need to put some different application name, then only it separates the sessions of hive and hplsql. otherwise how it will differentiate between them?
@romainr


Replaced WebL10n to i18next in Calculate Activity

Issue #1378
This PR migrates the Calculate activity to i18next from webL10n library.

Good start but some strings are not localized (clear button, placeholder, tooltips)
Before

After

Hey @llaske I've tried to debug this issue, but I haven't been able to resolve it. Could you please help me understand what might be causing this issue and how I can fix it?

Buttons and placeholder are localized here https://github.com/llaske/sugarizer/blob/dev/activities/Calculate.activity/js/calculate-app.js#L258. You should debug there to see what happens.
Tooltips are automatically localized using the data-l10n-id property https://github.com/llaske/sugarizer/blob/dev/activities/Calculate.activity/index.html#L24 coming from webL10n. I don't think there is a such feature in i18next so you have to localize manually these items. Why not in the transateGui function above?

Fixed in https://github.com/llaske/sugarizer/pull/1458


Add @stderr tag. Close #57.

This is an implementation of @stderr. This close #57.
It is a copy/paste of the code for @stdout.
I've updated readme file, unit tests and example file.

Hey, looks good, let's add some tests?

I'll do what i can to add tests. Do you have some requests on what tests to add ? I've already updated the main function-tags test.


without mono normal

hi, thanks for your great work, how to modify the codes to infer depth without mono normal? @Wuuu3511
Looking forward to your reply, thanks.

I have the same question.


fman-np: installer tweaks

The installer(setup.exe) automatically opens fman (as a child process of the installer) before closing. This installer.script deals with the problem.

Change license URL from https://fman.io/buy to https://fman.io/legal.

Please let me know if there are any problems. Thanks.

Thank you!


add symfony http kernel terminate hook

According to Symfony The Workflow of a Request
We need to trigger the kernel.terminate event after response was sent.

Looks nice to me :+1:

I agree with this. Thank you.
But can you make this PR to https://github.com/php-runtime/runtime?
This repo is read only


Add version 2.0 to Parts Inc

Fixes #1

We should consider making this dynamic

It looks good for now


fix: error on trait impl generics count mismatch

Description
Problem
Resolves #5542
Summary
Push an error instead of asserting.
Additional Context
None.
Documentation*
Check one:

[x] No documentation needed.
[ ] Documentation included in this PR.
[ ] [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

[x] I have tested the changes locally.
[x] I have formatted the changes with Prettier and/or cargo fmt on default settings.

Looks good but can you fix the formatting of the changes? It looks like it is spread out across more lines than necessary to me.

Sorry, I don't know how to fix that. I think it's because now it's nested inside an and_then? Is it the self.resolve_type_inner call?

I ended up extracting a helper function... in any case the original method was getting too long already.


Error computing planning mask

Hi Sam,
I ran into this error while computing the planning mask. It's only on my computer (I managed to get it to work with identical files on a different iMac). My computer is a MacBook Pro (Intel 2 GHz Quad-Core Intel Core i5, 16GB RAM).
Would you know what this is and how to fix it please?
Thanks,
Siti
The error comes after Code block 'skin voxelization' and the error is as follows:
Code block 'skin voxelization' took: 1.31554 s
--Babel-Brain-Low-Error
Traceback (most recent call last):
File "/Users/sitiyaakub/Documents/Software/BabelBrain/BabelBrain/CalculateMaskProcess.py", line 73, in CalculateMaskProcess
DataPreps.GetSkullMaskFromSimbNIBSSTL(**kargs)
File "/Users/sitiyaakub/Documents/Software/BabelBrain/BabelBrain/BabelDatasetPreps.py", line 437, in GetSkullMaskFromSimbNIBSSTL
skin_grid = VoxelizeFilter(skin_mesh,targetResolution=SpatialStep*0.75,GPUBackend=VoxelizeCOMPUTING_BACKEND)
File "/Users/sitiyaakub/Documents/Software/BabelBrain/BabelBrain/GPUVoxelize/Voxelize.py", line 558, in Voxelize
Points_dev=ctx.buffer(Points_part.nbytes)
metalcompute.error: Could not make buffer
Could not make buffer

***** Error in execution.

Hi sitiny,
The issue is that you are using an Intel-based Macbook Pro system. Those devices have some simple GPUs that are not adequate for GPU calculations. As you can see in the error "metalcompute.error: Could not make buffer", the GPU may not have enough memory for the processing. Intel-based systems work great if you have a dedicate AMD GPU (either internally or externally via Thunderbolt). I used BabelBrain often with an Intel-based Mac with an external AMD 6800 PRO.
Was the other Mac based on the newer M1 or M2 processors? Those processors have their GPU sharing the whole memory, allowing running these memory-intense calculations.  I may have to be much more specific in the instruction to be sure people are aware of the limitations when using Intel-based  Mac systems. I do not have any other suggestion other than switching to a newer Mac system based on the M1/M2 processors or getting an external GPU to run simulations.

Added more details on requirements for Intel-based Mac systems on Readme (ecd849d4460b4cccd58a2a94e4668664c59d8c5f) and in documentation (beb5d63baff47f2a66fe5625283348aed82df94e)


envoy: fix lb backend endpoint calculation

Currently, mapping loadbalancing backends to Envoy endpoints contains a bug that the LbEndpoints are kept/appended over the
whole backendMap. Therefore, later endpoints will contain the LBEndpoints of all previous backends.
This commit fixes this by putting the variable lbEndpoints into the right scope (per port).

/test

Looks good, sorry for the delay, was there an issue for this bug? I'm curious what the effects where?

rebased to main without any further changes

Looks good, sorry for the delay, was there an issue for this bug?

no there isn't.

/test

@mhofstetter This probably needs backports right? (looks like the same issue might exist back to at least v1.13).


design doc for the externally-manage-pf support

cc @adrianchiris @zeeke

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
6 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.07%) to 24.532%

Files with Coverage Reduction
New Missed Lines
%

controllers/sriovibnetwork_controller.go
2
66.04%

controllers/sriovnetwork_controller.go
4
65.71%

Totals

Change from base Build<PHONE_NUMBER>:
-0.07%

Covered Lines:
2084

Relevant Lines:
8495

💛  - Coveralls

LGTM

Hi @adrianchiris please give it another look


Accents import fails

When I try to import a csv it's all OK, but when some string contains an accent, it returns me a NULL value, tried to put UTF-8, but didn't works.
}, 'UTF-8')->get();

You mean a csv with chars like é, è,... ?

Yes!

Maybe the file you are loading is not saved as UTF-8.
Check related issue https://github.com/Maatwebsite/Laravel-Excel/issues/431


[PowerToys Run] Updating iconography for plugins

The icons currently used in Run are in a different style and some look pretty Android-ish.
This issue would track the effort to upgrade the icons to a style that fits in better with Windows. It would make the launcher feel more native in terms of UX.
Plug-ins

Name
Current icon
Symbol
Unicode point
Description

Calculator

E8EF
Calculator

Copy

E8C8
Copy

Delete file/folder

E74D
Delete

File

E7C3
Page

Folder

F12B
FolderHorizontal

User

E77B
Contact

Indexer

E773
SearchAndApps

Shell

E756
CommandPrompt

Disable

F140
StatusCircleBlock

Program

Custom
Based on CommandLine without C:\

Window Walker

EBEC
SiteScan

PT Run

Name
Current icon
Symbol
Unicode point
Description

Default app icon

E773
SearchAndApps

App

Custom
Based on CommandLine without C:\

App_error

Custom
Based on CommandLine without C:\

Here's a mock of what it looks like if the calc plugin would use MDL2:

Questions:

What is the list of active plugins that we'd need to update?
What would be the preferred style? I'd recommend going for MDL2 - since these are actions (and not apps (that Fluent Design icons represent). There's also a wide range of different icons available in MDL2 already that we can use.
It would also be nice to have some sort of design system for this: plug-ins / actions would use MDL2, launching apps would use the app icon.

Folder, Program, Calc, Indexer (am I missing anything @jyuwono)
For now, the MDL2 are preferable, esp with calculator since we're not leveraging their engine

Another idea which has to be mentioned here is #3450.

Small thing, but the "Copy to clipboard" action in the Run Calculator might even be better with the actual icon for "copy"?

@jay-o-way Good call, we need to update all icons (and probably more than that, such as font-sizes) for all plug-ins. I'll go through all plug-ins and open up separate issues if it requires (minor) UX changes.

Small thing, but the "Copy to clipboard" action in the Run Calculator might even be better with the actual icon for "copy"?

Not sure. I think the calc icon indicates thet the number is calculated.

@htcfreek @Jay-o-Way Oh, I miss understood. Yes, I'd keep the calculator icon to show it's coming from that specific plug-in.
Resolution and theme:
@saahmedm Plug-ins currently only have 1 size for their app-icon. Ideally, we'd have multiple to cater to different screen sizes / DPIs. They look kind of blurry at the moment on my SL3. We also need to think about having a light/dark icon so it's always visible when using different themes.
@alekhyareddy28 did some excellent work around this topic already in #4008. Could this be a class we can call in every plug-in to 1) get the right icon size and icon color? Plug-ins would then, ideally, have multiple icon sizes in both white/black.

@niels9001
When do we show the "Placeholder" icon? I have never seen it.

On "Access denied" error the user see the app icon at the moment. I think we could use the StatusCircelBlock icon (F140) instead.

On "Access denied" error the user see the app icon at the moment. I think we could use the StatusCircelBlock icon (F140) instead.

Good suggestion - do you have a screenshot of this? I saw the icon, and will update it with StatusCircleBlock but just curious when it shows up.

It shows for me as message when searching in c:\windows\system32.

On "Access denied" error the user see the app icon at the moment. I think we could use the StatusCircelBlock icon (F140) instead.

Good suggestion - do you have a screenshot of this? I saw the icon, and will update it with StatusCircleBlock but just curious when it shows up.

It shows for me as message when searching in c:\windows\system32.

@niels9001
The Program icon you have added in the table as "custom" is for Favicon (E737).
BTW: I think the PreviewLink (E8A1) would be better for this.
Instead of the TaskSwitch icon I would use the TaskView (E7C4) icon.

@niels9001
The Program icon you have added in the table as "custom" is for Favicon (E737).
BTW: I think the PreviewLink (E8A1) would be better for this.
Instead of the TaskSwitch icon I would use the TaskView (E7C4) icon.

No, Favicon has a higher 'titlebar' (but yes they look alike quite a bit ;)).
Yes, I agree on your recommendations. Will update to TaskView and PreviewLink.

On "Access denied" error the user see the app icon at the moment. I think we could use the StatusCircelBlock icon (F140) instead.

Good suggestion - do you have a screenshot of this? I saw the icon, and will update it with StatusCircleBlock but just curious when it shows up.

Here is the screenshot you requested:

On "Access denied" error the user see the app icon at the moment. I think we could use the StatusCircelBlock icon (F140) instead.

Good suggestion - do you have a screenshot of this? I saw the icon, and will update it with StatusCircleBlock but just curious when it shows up.

Here is the screenshot you requested:

Hi @niels9001.
Do we need an extra issue for that which gets fixed with version 0.20.0?

Last item in in PR, the always wonderful installer

@niels9001, is this wrapped up?

Yep, with #4149. This issue can be set to done.

We just released 0.20 and this should be resolved there.  Please try it out.


iQMC Fixed-Source Algorithm

iQMC is functioning in MCDC for fixed source, multigroup, problems. Tested with Reeds multimedia problem and a high-density-polyethylene multigroup problem in infinite medium. iQMC should work on 2D/3D problems but this has yet to be tested.  The Halton and Sobol Sequences are the available LDS along with ''random''.
To run any problem with iQMC the ''material index' and ''fixed source'' variables must be defined and passed through.  iQMC uses a separate tally for the scalar flux, so no need to use MCDC's traditional tally. The iQMC mesh and tallies are saved in the same H5 file as traditional grids/tallies.
Currently, the Source Iteration (equivalent to a Picard Iteration) is the only available iterative method. Krylov methods including GMRES and LGMRES will follow, as will k-eigenvalue problems.
All tests are passing.

Should also mention that all tests are passing.


fix: More reliable (and correct) download

The chrome version info may contain a trailing new line.
This broke our url generation.
The broken chrome url lead to the process crashing which lead to
a broken tmp file. And once that tmp file existed, it was blindly
copied. We're now waiting for the download to complete and then
copy the file to a new name once it was actually validated.
There's still a small window where we may end up in a broken
state but it's progress.

Actually, I reverted most of the selenium code changes. Pulling out the method didn't provide value in the last iteration.

@EndangeredMassa Looks like I don't have access to this on npm. Could you release this change (and/or add me as an owner :))?

@EndangeredMassa Ping? :)

Added. Sorry for the delay!


Combine TabBarCoordinator with NavigationCoordinator

Hello,
I have a TabBarCoordinator, and I want to implement a router which is triggered from navigation bar. How can I solve this? Should I create a parent route which includes both of coordinators for TabBar and Navigation or is there a simpler solution for this? I don't want trigger this router (in navigation bar) for each coordinator in TabBarCoordinator. Is it possible to implement a centralized router for navigation bar?
Thanks

I'm not quite sure, whether I understand your issue.
So, you have a UITabBarController with multiple UINavigationControllers as its children? From each or multiple of these UINavigationControllers you want to perform the same transition, right?
Would it be an option to handle the transition in the TabBarCoordinator and injecting it as an UnownedRouter into the child coordinators?

Closed due to inactivity.


Fix typos + formatting

Be careful of copy-paste from pdf to text files.
Nice CV!

It would be great if @simonrabate could take a look at this PR and merge it.

Any news on this issue?

Maybe @adabbas

No news, I hope @simonrabate is all right !

@deepcharles this is done


chain icon dark

          chain icon @Popoulosss

Originally posted by @2nthony in https://github.com/opensquare-network/ui/issues/91#issuecomment-1871828116

Updated @2nthony
Preview

Updated @2nthony

Shiden
Altair
Rococo
Westmint
Zeitgeist
Basilisk
Hydradx
Stafi
Creditcoin


Window does not resize when dragged to a new monitor with a different resolution

It seems that when you drag a window to a new monitor with a different resolution the window does not resize appropriately resulting in a clipped imgui draw result. This persists until you manually resize the window by dragging out from the corners or double clicking on the title bar to collapse it

I think it is something to do with the change in dpi scale. It looks as though the draw commands are not appropriately scaled until a resize window call is performed. When going from high to low dpi the window size stays the same, but the content gets clipped, when going from low to high dpi the content is drawn in a smaller area with black borders within the window. The window size stays the same throughout

I've made a pull request that fixes this

Merged PR https://github.com/VesCodes/ImGui/commit/67b82c1812b70e9a53f7f2142a49c8cee6d33c2c


extrude selection doesnt work

https://github.com/KittyCAD/modeling-app/assets/1445228/555ba4c5-9bae-4036-bd27-3c270de461e5

part of https://github.com/KittyCAD/engine/issues/2003


How to replicate this

How would you replicate this new OwnedVehicle {name = definition.name} part with BNM?
This is just an example, I'd like to know how to create a new class instance with fields initialized like this.

Even in C# fields got initialized after object created (you can see IL code to prove that). So just create it using BNM::Class().CreateNewObjectParameters(). And then using BNM::Field setup all fields that you need.

it should be like this if i'm not wrong
Class OwnedVehicleCls = Class("","OwnedVehicle");
Field<String*> nameField = OwnedVehicleCls.GetField("name"); //or maybe Property

auto newOwnedVehicle = OwnedVehicleCls.CreateNewObjectParameters();
nameField[newOwnedVehicle].Set(CreateMonoString("New Vehicle"));

it should be like this if i'm not wrong
Class OwnedVehicleCls = Class("","OwnedVehicle");
Field<String*> nameField = OwnedVehicleCls.GetField("name"); //or maybe Property

auto newOwnedVehicle = OwnedVehicleCls.CreateNewObjectParameters();
nameField[newOwnedVehicle].Set(CreateMonoString("New Vehicle"));

Thanks! I'll try this.
I did my own setup based on what BNM dev said. But I got things mixed up.
I created the object first, and then got the class and field from it or something. Also didn't use the Set method

Ok this seems to be work. Doesn't behave exactly like the c# counterpart but it's probably related to other things I need to fix.


5.7 crash recovery with 8.0 collation-server options

Thanks for opening a PR. Please make sure you've read and followed the Contributing guide, including signing the Contributor License Agreement.
Feature or Bug Description
pre-start script for Percona 5.7 crash recovery
Motivation
A Percona 8.0 my.cnf is incompatible with Percona 5.7. This allows crash recovery to succeed if that configuration value is set.
Related Issue
If this PR was first opened as an issue, please provide the link to that issue here.

This looks good.  Because I am not an approvers I am unable to Approve.


Helm release create returns error "command needs 1 argument: chart name"

This morning I was able to create a k8s 1.8.7 cluster in the latest supergiant beta admin. I then attempted to create a helm release from the stable/redis chart. When I did so, I observed this error at the end of the helm run:
stable" has been added to your repositories\nError: This command needs 1 argument: chart name\n
I have sent you the full JSON as a private gist since it may contain private information.

I am pretty sure that the cluster is operational, as I was able to create a helm release of traefik via the CLI on the master node.

I think this is fixed now with this pull. https://github.com/supergiant/supergiant/pull/465
We will release again, and you can check for sure.


Pass on Obfs4 Explainer Site

Current (non-content related) issues:

[ ] Using the Expand Padding toggle inserts newlines before and after the padding bytes (?)
[ ] The codesample element in the client handshake is not hidden / hide-able with button


Two issues!

Hello,
Thank you for providing such a good tool! I now have two issues and need your help. Any input would be very much appreciated!

The first issue is the error message:

sig.sigProfilerExtractor("vcf", "output_SNV_VCF", "SNV_vcf", reference_genome="mm10", opportunity_genome="mm10", minimum_signatures=1, maximum_signatures=10)

************** Reported Current Memory Use: 0.29 GB *****************
Starting matrix generation for SNVs and DINUCs...Completed! Elapsed time: 3.76 seconds.
Matrices generated for 16 samples with 0 errors. Total of 30452 SNVs, 0 DINUCs, and 0 INDELs were successfully analyzed.
Traceback (most recent call last):
File "", line 1, in
File "/home/xrao/.local/lib/python3.6/site-packages/SigProfilerExtractor/sigpro.py", line 647, in sigProfilerExtractor
excecution_parameters["context_type"]=",".join(mtypes)
UnboundLocalError: local variable 'mtypes' referenced before assignment

Then I tried this without success:
def sigProfilerExtractor():
global mtypes

The following files are not contained in the output folders:
Cluster_of_Samples.txt
dendogram.pdf

I am using Python Version: 3.6.4 and Sigproextractor Version: 1.0.17
Many thanks in advance!
XR

I will check that let you know.

I could not replicate the error so far. So, let us do a test with my code at your side.  Please upgrade the SigProfilerExtractor to its current version (Version: 1.0.18). Then download and unzip the file is attached. After that, please navigate to the "public_test" folder and run "python sigpro.py" there.
Please see what happens with the test.
public_test.zip
Also, we have some modifications in the results folder structure and you will get the Cluster_of_Samples.txt and
dendogram.pdf files there. Here I attached a sample results folder.
results.zip


Equals sign (=) in string breaks highlighting

Example text
command "twitter" "tw" url="https://twitter.com/" {
    match regexp="^@(?<username>[A-Za-z_]+)$" url="https://twitter.com/{username}" encoding="path"
    default url="https://twitter.com/search?q={}" encoding="query"
}

If I remove the = from the string, it looks fine:

I think that's because this line doesn't exclude invalid chars like = from matching in attributes, so instead of stopping at the first invalid char = it matches everything until the last =
https://github.com/kdl-org/vscode-kdl/blob/646d7b819d72b2f0d9dd05102a305506bafa3cf6/syntaxes/kdl.tmLanguage.json#L101


Cursor not blink when style "line" or "

VSCode Version: 1.11.1
OS Version:

Steps to Reproduce:

duplicate


Cannot Login

Hello!
I've got an issue for login with the github:
{"code":-1,"message":"Error 1290: The MySQL server is running with the LOCK_WRITE_GROWTH option so it cannot execute this statement"}
Thank for any futur reply.

@KevinCastel mysql storage space is full and has been repaired


docs: add guide for running envoy as a daemonset

Description:

Describe the desired behavior, what scenario it enables and how it
would be used.

[optional Relevant Links:]

Any extra documentation required to understand the issue.

dup of https://github.com/envoyproxy/gateway/issues/3457


Integrate Noosphere Name System with CLI gateway

As of #93 and the resolution of #67, we will have the bones of a name system capable of publishing names to and resolving names from a DHT.
Once these pieces are in place, we should integrate the "name system" as a worker thread that is managed by the gateway process (as implemented by the orb CLI). The gateway will spin up the name system thread and share access to local sphere data with it. The name system thread will read from sphere "address books." Address books should probably be in the form of a VersionedMap<String, String> where the key is an arbitrary string and the value is a DID. In our examples, we call this field on the sphere "names," but that's not set in stone. Names in address books will be queued for periodic resolution by querying the DHT.
Additionally, there should be a way for the main gateway process to notify the name system thread that it should publish a new version of a given sphere to the DHT.

I'm putting in some of the data structure work for this via #153

As of #253 and related work, this is broadly completed and tracked in remaining issues.


WKWebView?

At some point Apple will drop support for UIWebView.  Are there any reasons why this component can't use WKWebView currently?

This isn't the first time I've gotten this request. It could probably be done. How easy the conversion would be, I'm not quite sure. Maybe this will be the next big breaking change?
When I first made it, we were still supporting iOS 7, which is why it was made with UIWebView.

Given that your component is in Swift, I think it's a natural and worthy next step.

Started working on this a little bit, but it turns out you can't synchronously get responses from JS with WKWebView. This isn't really a big deal in making the changes on my side, but it does make usability a bit awkward. Things as simple as editingEnabled or getHTML(), getText() will need a completion block :confused:
For things like editingEnabled, I could try to keep a variable updated when changes are made, but no actual interactions with the web view are going to be synchronous like they used to be. Although maybe it's not a huge issue.

This should help albeit in ObjC:
- (NSString *)stringByEvaluatingJavaScriptFromString:(NSString *)script
{
    __block NSString *resultString = nil;
    __block BOOL finished = NO;

    [self evaluateJavaScript:script completionHandler:^(id result, NSError *error) {
        if (error == nil) {
            if (result != nil) {
                resultString = [NSString stringWithFormat:@"%@", result];
            }
        } else {
            NSLog(@"evaluateJavaScript error : %@", error.localizedDescription);
        }
        finished = YES;
    }];

    while (!finished)
    {
        [[NSRunLoop currentRunLoop] runMode:NSDefaultRunLoopMode beforeDate:[NSDate distantFuture]];
    }

    return resultString;
}

Here's an untested Swift version:
func stringByEvaluatingJavaScriptFromString(script: String) -> String {
    var resultString: String? = nil
    var finished: Bool = false
    self.evaluateJavaScript(script, completionHandler: {(result: AnyObject, error: NSError) -> Void in
        if error == nil {
            if result != nil {
                resultString = "\(result)"
            }
        }
        else {
            NSLog("evaluateJavaScript error : %@", error.localizedDescription)
        }
        finished = true
    })
    while !finished {
        NSRunLoop.currentRunLoop().runMode(NSDefaultRunLoopMode, beforeDate: NSDate.distantFuture())
    }
    return resultString!
}

Yeah I found similar approaches when I was looking for solutions. There are a few things I don't like about it. If people want to lock up the current thread while it waits for the WebKit process to return with a result, then they are free to do it, but I don't think it belongs inside the library itself.
It might be a little awkward to require an asynchronous API, but I think it's the preferable option, to be honest.

I'm trying to write my own rich text editor by WKWebView. And I'd like to be able to customize both inputView and inputAccessoryView at the same time. Tried to follow what this library does but doesn't seem to work. Can anyone help? Thanks

I'm trying to write my own rich text editor by WKWebView. And I'd like to be able to customize both inputView and inputAccessoryView at the same time. Tried to follow what this library does but doesn't seem to work. Can anyone help? Thanks

That's not really what this thread is about. I'd be glad to see if I can help out in another thread, but this issue is about changing the underlying implementation of RichEditorView from UIWebView to WKWebView.

I'm going to close this as wontfix, because refactoring this would basically be a rewrite, and it would merit being its own repo. Thanks for all the interest, everyone 👍


FIX: Manifest should ignore vendor folders within packages contained in vendor

Without this change vendor/silverstripe/framework/vendor/silverstripe/config
will be pick up by the manifest, which is inappropriate.
Although this doesn’t happen often, it can occur if you have run
“composer install” within vendor/silverstripe/framework, which can be
done either accidentally or (in my case) as part of running the
framework tests isolated from the rest of your project (which is closer
to the execution model on Travis)
Note that the presence of the ‘nestedvendor.txt’ file tests that this
works without any explicit changes to the PHP of the tests, since it’s
merely confirming that such a file is not picked up.

I haven't looked into this much at all, but off the top of my head - when you do this you get lots of errors for duplicate class names in the autoloader, etc. If we ignore that in SilverStripe's class manifest, do you think we might be hiding a very visible error in a way that may surface in a less visible and harder to debug way further down the line? I kind of feel like it's a good thing that the errors are obvious when you do this


[OT] Netlify

Another alternative to using your awesome bash scripts build.sh and refresh-portfolio.sh might be @netlify (homepage). I think you should stay with your bash scripts for now but maybe Netlify might be an option for another project or the project of a visitor of your repo.

Yeah, Netlify is great for that, and I have even considered it while developing the bash script, but I'll try to keep the control over my web server as long as I can. Maybe in future I'm going to link my web server to a GitHub webhook.

In the meantime, we got GitHub Actions and I decided to put the shell scripts into a CI and CD workflow.
This issue should be fixed by #5.


HAI-2341 Show hanke areas in johtoselvitys form

Description
Show hanke areas in johtoselvitys form areas page if they exist. By default they are shown. Functionality to control what layers are displayed will be implemented later.
Jira Issue: https://helsinkisolutionoffice.atlassian.net/browse/HAI-2341
Type of change

[ ] Bug fix
[x] New feature
[ ] Other

Instructions for testing

Create new johtoselvitys for hanke which has hanke areas
Fill first page of johtoselvitys form and go to second page
Check that hanke areas are displayed on map

Checklist:

[ ] I have written new tests (if applicable)
[ ] I have ran the tests myself (if applicable)
[ ] I have made necessary changes to the documentation, link to confluence
or other location:

Other relevant info
Please describe here if there is e.g. some requirements for this change or
other info that the tester/user needs to know.

Hanke areas become visible only after entering dates. Is this as expected?

Changed it so that date filter is based on hanke dates if there are no application dates set yet, so that hanke areas are visible from the start.


Native Editor - implement dirty tracking files for ipynb

In issue #7258 there are multiple options discussed. The ideal situation is option 4:

Option 4: Implement behavior similar to VSCode's auto-recover functionality that stores a dirty copy of what was edited and when VSCode is launched again, it displays that file as dirty. This is considerably more expensive than the other options here.

This issue is to make sure option 4 is implemented at some point.

I felt like I got it in a state once where it was asking me to save a file on close that I hadn't made dirty, but I was unable to get a repro on that with a bunch of trying. So validated.


imports syscall/js: build constraints exclude all Go files in D:\Go\src\syscall\js

What version of Go are you using (go version)?

$ go version
go 1.15.6

Does this issue reproduce with the latest release?
i don't know
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
set GO111MODULE=
set GOARCH=wasm
set GOBIN=
set GOCACHE=C:\Users\Sxy\AppData\Local\go-build
set GOENV=C:\Users\Sxy\AppData\Roaming\go\env
set GOEXE=
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOINSECURE=
set GOMODCACHE=D:\Study\ProgramData\GoPath\pkg\mod
set GONOPROXY=
set GONOSUMDB=
set GOOS=js
set GOPATH=D:\Study\ProgramData\GoPath
set GOPRIVATE=
set GOPROXY=https://proxy.golang.org,direct
set GOROOT=D:\Go
set GOSUMDB=sum.golang.org
set GOTMPDIR=
set GOTOOLDIR=D:\Go\pkg\tool\windows_amd64
set GCCGO=gccgo
set GOWASM=
set AR=ar
set CC=gcc
set CXX=g++
set CGO_ENABLED=0
set GOMOD=
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-fPIC -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=C:\Users\Sxy\AppData\Local\Temp\go-build345168030=/tmp/go-build -gno-record-gcc-swi
tches

What did you do?
run a program in goland:
package main
import "syscall/js"
func main() {
alert := js.Global().Get("alert")
alert.Invoke("Hello World!")
}
What did you expect to see?
no errors
What did you see instead?
Run 'go build main.go'
package command-line-arguments
imports syscall/js: build constraints exclude all Go files in D:\Go\src\syscall\js
Compilation finished with exit code 1
or
go run main.go
exec: "C:\Users\Sxy\AppData\Local\Temp\go-build246431802\b001\exe\main": file does not exist

syscall/js is only valid for the js and wasm platforms
For questions please refer to https://github.com/golang/go/wiki/Questions

syscall/js is only valid for the js and wasm platforms
For questions please refer to https://github.com/golang/go/wiki/Questions


feat: allow more time creating envs

The CMP migrator library is not allowing enough time to clone the CTF environments. It can take minutes to complete (for environment with lots of entries). We make the timeout configurable in  this PR

If I want to wait for, say, three minutes, I would set the GET_ENV_WAITING_MILLISECONDS to 180_000. This means the loop would wait for 18s before checking again which is too long between checks, if I understand this correctly.
I'd like it to work in another way: The delay before retrying is fixed to 1s, but the number of retries is configurable via a variable called e.g.  NUMBER_OF_RETRIES_WHEN_CREATING_ENVIRONMENT
Wouldn't that be better, more precise, and easier to understand?

NUMBER_OF_RETRIES_WHEN_CREATING_ENVIRONMENT

Yes! that's better I would say :) done


Inline Typographical Elements

Inline Typographical Elements - code examples added

Excellent thank you! :+1:

It seems there are some problems with this solution. I'll fix it.

Already done :)


OCPBUGS-6016: UpdateStrategy RegistryPoll with nil Interval

Adds protection against a nil-pointer panic when an UpdateStrategy with nil value for RegistryPoll Interval is supplied. Also adds a unit test to ensure that the code does not panic but instead returns an error when this situation is encountered.
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 4bae06a5d2230e62328f5d82ce36c09a7522cea8
Bug: OCPBUGS-6016

/retest

/retest

/restest

/retest

/jira refresh

/retest

/retest

@dtfranz Please hold on the retest as this e2e-upgrade is failing for real due to some issues.

/hold
until e2e-upgrade is fixed (non-olm related)

Hi @bandrade , thanks for checking on this.
The test you are running has a CatalogSource with an updateStrategy that is nil, however the code change here is meant only to address an updateStrategy that is non-nil and contains a nil registryPoll.
I've also confirmed from both the v0.23.1 and v0.24.0 upstream OLM releases that updateStrategy: {} will cause the catalog-operator pod to crash-loop. These two releases are before and after this code change respectively. I also tested this on a 4.12 cluster and encountered the same issue. It's safe to say that this is an existing issue not introduced by this code change, and I feel as though it should be addressed through another PR.
If that's acceptable to you then I'd like to merge this change and start a follow-up to fix the problem arising from updateStrategy: {}. But if not it will take some time to fix the other issue and pull that fix into this PR as well.

Looks like the e2e-upgrade test is passing again, gonna retest here.
/retest

/retest

The CI has passed.
/unhold

/approve

/lgtm

/retest

/retest


Add github action that runs unittest and linter

Hello, I think it would be good to have a github action that runs the tests on PR or Push, and runs a linter. Happy to contribute this during Harmony. @jakebeal
Do you have a problem with using black as a linter?

We do have an action for push & PR, it had just switched itself to idle since nobody's done a push or PR for a couple of months. I've turned it on again.
For running a linter, we've found black to be too restrictive. I'd prefer to match pysbol3, which usees pycodestyle and pylint with the following configuration: https://github.com/SynBioDex/pySBOL3/blob/main/setup.cfg
Note that this might find a massive number of issues, since it hasn't been run recently, so we'll likely want to see how bad it is before deciding how to best proceed, in terms of time prioritization.


witch address

Related Safe Addresses
0x798d328407055649acd4360201912e375413e999
0x05c81b8886a8f7c7efbac200d9effd8d7921200b
0xa4a5971ab41cd5af29d11849ab2a376c90f65441
0x59c97465be5b3c3fe1032ce30dd74404564d20dd
0x9d9d9ea1d9422375c6696c953cfba966e6c6c3a0
0xf0833df8eab2f7c4fd1f2d36831364103e844197
0xdd0a87380f8cd911e4ce2dfa82d8c983b002163d
0x8948837501562c53648a82fc5461942189bc65de
0x556f7b2318ec0060c8adc81982838e1a2e10315c
0xd58ac7c455fa89a64bdb271b1237f9d083f639cc
0x6c1cb30ad73f628fb5d0e99a94648a5802f6b51d
0x33d1f73fd14c73f064e4eb0217d7b56b2e0aef8c
0x7fddbf26e0d413f4b18cc8ecd8cb6cb1830f195b
0x069e1ea1c27d09c569cb8b24c7035fdefeed8e73
0x381033fd735a7b7b25d7c75674913e9a7259de4f
0x261c4a747ead7372a314567ed78c9ef7b9b5f5b9
0x014145161be0a3b0fb9000803d1bdddabe532d0e
0x4837044eb492842d6a504475bcf6bd014fb16fb0
Reasoning
All the above addresses are transferred from 0x5769770F5EFe8fB017FB09B6dE3B2d096668377D to eth, which is obviously witch
Methodology
https://etherscan.io/tx/0x0bda5a5272520cbd9761b7d1ac95e4d4fc516ba3668ce2e4c224feb42706bbcb
https://etherscan.io/tx/0xe762691cd6a72c47a69b7d4f5c25281ba22796642e57871c0683a8f736a4e53a
https://etherscan.io/tx/0x9b6b52fa18aa5c0bab842ac710e9c2effee02831ebb121afb239d158fa1e25bd
https://etherscan.io/tx/0x17f7ce028f3f7eac0ceca1bba386ded9309060fb306ef5f0a74ed66b32083e08
https://etherscan.io/tx/0x17f7ce028f3f7eac0ceca1bba386ded9309060fb306ef5f0a74ed66b32083e08
Safe Address
0x188950d274A7C23Ec2e180Aa0E5cf92997B69D70

Related Safe Addresses
0x798d328407055649acd4360201912e375413e999 0x05c81b8886a8f7c7efbac200d9effd8d7921200b 0xa4a5971ab41cd5af29d11849ab2a376c90f65441 0x59c97465be5b3c3fe1032ce30dd74404564d20dd 0x9d9d9ea1d9422375c6696c953cfba966e6c6c3a0 0xf0833df8eab2f7c4fd1f2d36831364103e844197 0xdd0a87380f8cd911e4ce2dfa82d8c983b002163d 0x8948837501562c53648a82fc5461942189bc65de 0x556f7b2318ec0060c8adc81982838e1a2e10315c 0xd58ac7c455fa89a64bdb271b1237f9d083f639cc 0x6c1cb30ad73f628fb5d0e99a94648a5802f6b51d 0x33d1f73fd14c73f064e4eb0217d7b56b2e0aef8c 0x7fddbf26e0d413f4b18cc8ecd8cb6cb1830f195b 0x069e1ea1c27d09c569cb8b24c7035fdefeed8e73 0x381033fd735a7b7b25d7c75674913e9a7259de4f 0x261c4a747ead7372a314567ed78c9ef7b9b5f5b9 0x014145161be0a3b0fb9000803d1bdddabe532d0e 0x4837044eb492842d6a504475bcf6bd014fb16fb0
Reasoning
All the above addresses are transferred from 0x5769770F5EFe8fB017FB09B6dE3B2d096668377D to eth, which is obviously witch
Methodology
https://etherscan.io/tx/0x0bda5a5272520cbd9761b7d1ac95e4d4fc516ba3668ce2e4c224feb42706bbcb https://etherscan.io/tx/0xe762691cd6a72c47a69b7d4f5c25281ba22796642e57871c0683a8f736a4e53a https://etherscan.io/tx/0x9b6b52fa18aa5c0bab842ac710e9c2effee02831ebb121afb239d158fa1e25bd
Safe Address
0x188950d274A7C23Ec2e180Aa0E5cf92997B69D70

All the above addresses are transferred from 0x5769770F5EFe8fB017FB09B6dE3B2d096668377D to eth, which is obviously witch

Please elaborate on how transferring ETH from 1 account to many Safes is airdrop farming per se.

All the above addresses are transferred from 0x5769770F5EFe8fB017FB09B6dE3B2d096668377D to eth, which is obviously witch

Please elaborate on how transferring ETH from 1 account to many Safes is airdrop farming per se.

0x569770F5EFe8fB017FB09B6dE3B2d096668377D is a personal address. The first transaction of the above safe deposit box address is the eth transferred from 0x5769770F5EFe8fB017FB09B6dE3B2d096668377D. Without the eth safe address transferred to this first transaction, no other on-chain behavior can be generated. This operation shows that the above safe deposit box address belongs to The same user, this is obvious witch behavior, real users will not appear such operations.

We haven't received any further information on this ticket and therefore deemed this submission invalid.
Unfortunately just the pure fact that Safes...

were created by the same address
have the same owner
conducted the same transactions
received assets from the same address

... is not enough reasoning for a valid submission, as there are legit user behaviour leading to such as well (relayer, scripts, power users, exchanges)
This submission didn't provide sufficient indicators to convince the team that there is some targeted airdrop farming behind the provided addresses. As per the rules, when in doubt we will default in favor of the airdrop recipients in order to not risk any false positives when sorting out airdrop hunters.


Anime Vintage effect

Here animefy  function implement the classic animated effects on the user provided images resulting in 4 output files (as a result of 1 effect's call). A variety of cartoon effects can be generated for a single input (so as to demonstrate).
Results are really mesmerizing (by local survey on different images) [added in assets directory].

Greetings Sir.
Update the Python script as per requirement.
Please can you label this PR as "hacktoberfest_accepted" as well.
Please review the code and if everything's fine please do the merge and accept the PR.
Thank you Sir.

Some error occured


package updates, feature removal

#19 - shifted files under internal/cyberark
#19 - renamed provider files for clarity
#18 - Remove delete feature, updated logging

Closes #19 #18


add delete-non-replicated-pods flag

#46

I also added some code to filter out pods controlled by DeamonSet.

Yes. rescheduler with delete-non-replicated-pods=true flag is running in company's aws cluster(@aroundus-inc), and seems to work well :)

I wanted to write some detailed test code, but actually this is my almost first time golang experience and not familiar with go tests, so I just tested in actual cluster directly.


Request: setting to disable [description] for parameters

Most times my parameter names are relatively self explanatory, so it would be nice if I could just disable the description for each one so I don't have to clear them out every time I start a new docblock.

Set "jsdocs_param_description": true in Menu > Preferences > Package Settings > DocBlockr > Settings - User.
See https://github.com/spadgos/sublime-jsdocs#configuration


fix: gas cost calculation in eip-3860

The gas calculation for the initcode analysis introduced in EIP-3860 contained a bug in that it did not round up the code size to the nearest 32-byte word multiple.
The evm-tests repo has been updated with the most recent Ethereum tests for Shanghai: https://github.com/rust-blockchain/evm-tests/pull/19.
FYI, there are more test failures for the Shanghai changes, this was just one of the bugs I could find. I'll send fixes for the other bugs as separate PRs.

There were still a bunch of unrelated clippy lints (assuming that came from the update). I fixed those now. Can we retry @sorpaas?


Status for Xcode 10 beta

As per the docs:
"xib2Storyboard works and was tested using the Xcode 8 and Xcode 9 file formats. xib2Storyboard will be thoroughly tested when new beta versions of Xcode become available."
How is xib2storyboard looking for Xcode 10?

Hi Nicholas!
Thanks for pointing that out! Did you log this issue because you had a problem with Xcode 10?
We'll be sure to test X2S against Xcode 10 at a later point!

I haven't actually, but I wanted to. When the code I am refactoring is ready for this, I can test it out and see. I just asked on the off chance that perhaps it had been tested, but the documentation hadn't been updated 😄

Great! I look forward to your feedback once you tested with Xcode 10...

@DriesVS doesn't work with XCode 10.2, it is a Cocoa xib so I got following error:

MainMenu.storyboard:-1: iOS storyboards do not support target device type "mac".


Zalo token

PLEASE READ: If you have a support contract with Google, please create an issue in the support console instead of filing on GitHub. This will ensure a timely response.

PLEASE READ: If you have a support contract with Google, please create an issue in the support console instead of filing on GitHub. This will ensure a timely response.


github: run the build on schedule

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
38

Relevant Lines:
38

💛  - Coveralls


Transfer ETH functionality implemented and tested on Rinkeby test network

Transaction working, Merging!!!

Transaction working, Merging!!!


更新到3.0后縮略圖全部無法顯示

如題所述，更新前一切正常，更新后在線流覽，查看已下載，點進某一漫畫查看縮略圖，這三個地方的圖片都不能正常顯示，但是其他地方並無異常，能正常下載

I don't know if Google translate worked well, but maybe you should check the data usage settings.
If it's not that, please send the details in English because I don't understand Chinese

I don't know if Google translate worked well, but maybe you should check the data usage settings.
If it's not that, please send the details in English because I don't understand Chinese

OK，the problem is that all thumbnails don't show in the application on version 3.0. The application worked normally before this update, but after it ,every picture can't be shown in the app.However, downloaded picture are as usual outside the app.
I've check all the settings in the application,but it seems this can't solve the problem. If you are talking about the mobile phone setting , I ensure that there was no setting change during the updating.
These are my problems, maybe my description can help you solve bugs

I don't know if Google translate worked well, but maybe you should check the data usage settings.
If it's not that, please send the details in English because I don't understand Chinese

OK，the problem is that all thumbnails don't show in the application on version 2.3.0. The application worked normally before this update, but after it ,every picture can't be shown in the app.However, downloaded picture are as usual outside the app.
I've check all the settings in the application,but it seems this can't solve the problem. If you are talking about the mobile phone setting , I ensure that there was no setting change during the updating.
These are my problems, I hope my description can help you solve bugs

Have you checked the app permissions? Maybe you or your system accidentally disabled some of the permissions that the app needs. Or you might have checked "Do not ask again" ?

I don't know if Google translate worked well, but maybe you should check the data usage settings.
If it's not that, please send the details in English because I don't understand Chinese

OK，the problem is that all thumbnails don't show in the application on version 2.3.0. The application worked normally before this update, but after it ,every picture can't be shown in the app.However, downloaded picture are as usual outside the app.
I've check all the settings in the application,but it seems this can't solve the problem. If you are talking about the mobile phone setting , I ensure that there was no setting change during the updating.
These are my problems, I hope my description can help you solve bugs

Have you checked the app permissions? Maybe you or your system accidentally disabled some of the permissions that the app needs. Or you might have checked "Do not ask again" ?

I just checked the permission settings.This app only asks for usual permissions, and is permitted.It seems this is not the reason.
Besides, my Android system is version 4.42, is this related to the problem?

Well this app support API 14< (Kitkat and above) then it shouldnt be the problem. Have you tried reinstalling the app or rebooting your device (I cant help any further sorry :( )

Well this app support API 14< (Kitkat [4.4.x] and above) then it shouldnt be the problem. Have you tried reinstalling the app or rebooting your device (I cant help any further sorry :( )

I tried turn it back to v2.2.9, and reinstalling ,but these don't works.
Maybe this problem can be fixed after next update.Thanks for your kindness :)

In addtion, I tested the network during using the app. It seems that the problem is that the app doesn't request for pictures but just basic details from the server. However ,it's strange that allready-downloaded pictures can't be shown through the apps.

In addtion, I tested the network during using the app. It seems that the problem is that the app doesn't request for pictures but just basic details from the server. However ,it's strange that allready-downloaded pictures can't be shown through the apps.

If thats the case did you try cleaning your cache and switching "Use nhent.ai" on/off?

In addtion, I tested the network during using the app. It seems that the problem is that the app doesn't request for pictures but just basic details from the server. However ,it's strange that allready-downloaded pictures can't be shown through the apps.

If thats the case did you try cleaning your cache and switching "Use nhent.ai" on/off?

thanks, I just solved it ,but not in this way.
I tried uninstall and return to v2.28,but come across the same problem, even this version used to be normal.
However, when I update it to v2.30, the problem just solved! what a stange thing. :)
maybe this has something to do with remained files or cache in the phone?


Accent Color in Editor Settings makes console messages icons unreadable.

Godot version
4.0 dev 20211004
System information
Windows 10
Issue description
Changing Accent Color in editor theme setting affects icons in console. If you change it to red, then everything looks like a warning etc. It is confusing. That setting probably should not affect those icons.
Before:

After:

I think Accent Color should not affect icons for messages in console.
Steps to reproduce
Just change Accent Color to red and check Console.
Minimal reproduction project
No response

Accent color is used throughout the editor to modulate active icons, that's kind of the point of having it user-configurable 🙂

Accent color is used throughout the editor to modulate active icons, that's kind of the point of having it user-configurable 🙂

Totally agree and 100% understand, but in this situation (those 4 icons) exception would be nice and it should provide more readability and less confusion.

Well, I don't think we need an exception, I think we just need a better solution. We can't really use the default accent color here, as it would make theming unpredictable. And also because it doesn't really work well in the light theme and with yellow icons. So we need to find another way to indicate that the buttons are pressed, that would work in every case.

I'm not sure about removing the icon modulation entirely. While it makes sense for colored icons, the modulation should be kept for grayscale icons.

Maybe we could change those 2 grayscale icons (pencil and warning icon with "!" sign). That way every icon will be colored by default and not changed with modulation:

I think the icon colors match the message colors. The only thing is that the pencil icon should be gray.

I think that editor messages icons in software should not be affected by modulation and have static/default color. For example:

The icon modulation is a helpful feature for people with low vision, so that they can see whether a button is enabled or not. If we remove it, it won't be easy to see at a glance whether a button is active due to the relatively thin text being colored (and a small border).

Disabled and inactive are different states. Buttons there are not disabled, they are inactive. In your proposal they do look disabled, but they shouldn't. They should look like something that can be activated.

I think the icon colors match the message colors. The only thing is that the pencil icon should be gray.

I think this issue can be considered fixed? (Although there is still room for improvement in these buttons IMO.)


Update xsbt-web-plugin to 4.2.3

Updates com.earldouglas:xsbt-web-plugin from 4.2.2 to 4.2.3.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Files still referring to the old version number
The following files still refer to the old version number (4.2.2).
You might want to review and update them manually.
tests/src/test/scala/org/http4s/Ipv6AddressSuite.scala

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.earldouglas", artifactId = "xsbt-web-plugin" } ]

labels: sbt-plugin-update, semver-patch, old-version-remains

#4957

Superseded by #4963.


generate training data for the name model

part of https://github.com/elifesciences/sciencebeam-issues/issues/229

Some of the remaining tasks:

split authors (re-use functionality from name extractor?)
add citations version of the model (with citations in the filename)


Sqlite3: Use SQLite3 database instead of postgres and embed server in android app

I am working on a flutter app that needs to embed a server as well as a client. Thus for peer communication.
I cannot have a postgresql installation for mobile devices.
I would like to know if it's possible to change the default database configuration to use sqlite3.
And if it's even possible to embed the server in an Android app.

Currently it's not possible to run Serverpod without Postgres. However, you have a valid use case so we should make this possible in the future! Postgres is the only external needed dependency, so otherwise everything should work.

Will it be possible to abstract the database layer, so that anyone can write specific inplementations for the database?

@Joetib - We are slowly moving towards that structure. But currently, postgres is quite tightly coupled with the workings of Serverpod.

Closing this as duplicate of https://github.com/serverpod/serverpod/issues/160


Cannot find module elm-svg-generator

Hi! I just tried to use it and got this error:
$ npx iconsToElm assets/images
Cannot find module './src/elm-svg-generator.js'

Took a peek at the repo and I think you might have forgotten to commit this file.

Hi!, Not sure I will take a look today.
Thanks for open the issue.

Sorry for the late response but I already remove the import and release a new version of the npm Package with the fix


[docs] Lists can have 5,000 members

https://dev.twitter.com/rest/reference/post/lists/members/create
Also documents add_list_members to docs, which is there in code.

TODO for someone else for the future:

[ ] check if add_list_member needs its documented params updating
[ ] remove_list_members needs documenting

Is this okay to merge?

The additional listed tasks have been completed with https://github.com/tweepy/tweepy/commit/68f7f702ba2a5ce4ca14dbfe8f8cae4f05b914fa and https://github.com/tweepy/tweepy/commit/c8a6b67b3288869b8972622fb1f12c0a72d350b4.
Also see #1210.


type_of_data - validate school_id and student_id

Level of data supports only student and school based on that we need student_id or school_id to process the data.
Note - Main ticket #585

This issue will be addressed in cQube v5.0.

Implemented


Remove host warnings

Specifically these warnings:
You have configured application :vintage_net in your configuration file,
but the application is not available.

This usually means one of:

  1. You have not added the application as a dependency in a mix.exs file.

  2. You are configuring an application that does not really exist.

Please ensure :vintage_net exists or remove the configuration.

You have configured application :nerves_time in your configuration file,
but the application is not available.

This usually means one of:

  1. You have not added the application as a dependency in a mix.exs file.

  2. You are configuring an application that does not really exist.

Please ensure :nerves_time exists or remove the configuration.

You have configured application :mdns_lite in your configuration file,
but the application is not available.

This usually means one of:

  1. You have not added the application as a dependency in a mix.exs file.

  2. You are configuring an application that does not really exist.

Please ensure :mdns_lite exists or remove the configuration.

Fix the warnings by removing the no-longer needed configurations
Also fix a host test error
And fixes dialyzer warnings (albeit in a rather hacky way) by adding Mix.target checks throughout the code.
Based on and merges into https://github.com/livebook-dev/nerves_livebook/pull/237

Any thoughts on this? Perhaps it's too hacky? Should we create a behavior-based adapter system instead?

Sorry. I just hadn't gotten to it yet. My time is being consumed with finding hardware for NervesConf/ElixirConf, and then making it user friendly. On brief skim, I think that it's fine. I will get to it!

No worries! I'm looking forward to NervesConf!

I just looked over this in more detail. It looks good to me, so I'm going to merge and then we can iterate on improvements. Thanks for sending this!!!

Great, thanks!


feedback and suggestions

Issue: feedback and suggestions: https://github.com/suwebdev/nifty-club/issues/5
Added a text box so the user can add feedback and suggestions.

I think update to 2019


Using MIDI input, only one signal is playing at a time

(Apologies for the newb issue, but I'm relatively new to the world of MIDI and sound synth.)
I'm sure I'm doing something wrong, but every time I create a new signal with ofxTonic, the previous signal is stopped.  I would think that there is a way to play all of the signals (i.e., play a C chord and have them all play together), but I am at a loss.
Thanks,

hi there, i'm facing a lot of issues to make PolyMIDIDemo work at Yosemite.
I copied the RtMidi.cpp and h. I removed ofxTonic.h.
Undefined` symbols for architecture i386:
  "_kMIDIPropertyName", referenced from:
      EndpointName(unsigned long, bool) in RtMidi.o
      ConnectedEndpointName(unsigned long) in RtMidi.o
  "_kMIDIPropertyConnectionUniqueID", referenced from:
      ConnectedEndpointName(unsigned long) in RtMidi.o


Generate-defaults script is broken

The script currently fails if executed and trying to fix it will inevitably lead one to the likes of ERR_REQUIRE_ESM errors.
Someone should probably take a look at this

As mentioned in #3006 we should maybe think about replacing axios with fetch to get rid of that dependency when doing this.


Minimal Proxy

Seems that there's a lot of folks who do not like diamond. Instead, minimal proxies seem to be more favorable.
We should measure the pros and cons of diamond vs minimal and see if there's any work that can be reused if we decide to convert.
This is a research bounty and a report should be delivered.
https://twitter.com/bantg/status/1671664719671746563?s=46&t=fLzoRySawhTzZHfr3g9x9A

/assign

/assign

Seems that there's a lot of folks who do not like diamond. Instead, minimal proxies seem to be more favorable.
We should measure the pros and cons of diamond vs minimal and see if there's any work that can be reused if we decide to convert.
This is a research bounty and a report should be delivered.
https://twitter.com/bantg/status/1671664719671746563?s=46&t=fLzoRySawhTzZHfr3g9x9A

Diamond storage and minimal proxies serve different purposes.
Diamond proxy makes your contract to be upgradable while minimal proxy makes contract deployments cheaper. So minimal proxy is not about upgrading but about cheaper deployments of similar contracts.

You can mark as unplanned if you think this isn't applicable.

Seems that there's a lot of folks who do not like diamond. Instead, minimal proxies seem to be more favorable.
We should measure the pros and cons of diamond vs minimal and see if there's any work that can be reused if we decide to convert.
This is a research bounty and a report should be delivered.
https://twitter.com/bantg/status/1671664719671746563?s=46&t=fLzoRySawhTzZHfr3g9x9A

Diamond storage and minimal proxies serve different purposes.
Diamond proxy makes your contract to be upgradable while minimal proxy makes contract deployments cheaper. So minimal proxy is not about upgrading but about cheaper deployments of similar contracts.

100%

You can mark as unplanned if you think this isn't applicable.

@malik672 closing this as "not planned" then

@pavlovcik are you trying to put upgradability in your contractrs


Make Consumer thread safe and lock-free

Motivation
Lock-free solution for https://github.com/apache/pulsar/pull/10240

The performance test results are in two folders 2.6.1 and 2.8.0
https://github.com/315157973/openmessaging-benchmark/tree/executor/bin
5 IO Thread
It seems that the performance has been improved by 50%, which is similar to the previous test results
client 2.6.1 :

client:2.8.0-snapshot (use executor)

Wow, all unit tests are done at once

I will re-trigger CI several times to see if there will be some occasional problems

In the case of adding lock, there are still the following flaky tests
https://github.com/apache/pulsar/pull/10240/checks?check_run_id=2435235663#step:9:783

In the case of adding thread pool
https://github.com/apache/pulsar/pull/10352/checks?check_run_id=2440197210#step:9:782

Therefore, the performance of adding a thread pool and adding a lock is the same. I haven't seen other flaky errors when using the thread pool.

@merlimat @sijie @rdhabalia @codelipenghui  @eolivelli PTAL, thanks

nice

waiting for @linlinnn approval before merging

thank you @linlinnn for your comment.
let's wait for CI to complete


Social agent name should map to mission.

This should make Scenario.missions[] contain the social agent name instead of the mangled id.

It appears like this change causes a problem with combining groups of social agents.
The agent mission ids are marked like "social-actor-"+<group id>+<actor id>.
I can strip away the prefix "social-actor-" but then group id is still integrated. This is necessary because missions are combined between groups which may share the underlying actor name.

@Adaickalavan

Given this case, I have now resorted to searching for the vehicles of interest in Scenario.missions.keys() using a substring match criteria. Hence, this PR may be closed. Thanks.

There is some consideration still here that the actor names should still be exactly named and unique between groups considering the actors are being combined across groups.


Add Privacy Link To Home Page in GUI App

Describe the bug
While a PRIVACY.md file exists in the program folder the user should be able to easily get to the notice details from the control where they are asked whether to allow telemetry or not.
To Reproduce
Steps to reproduce the behavior:

Go to application home page
See control for Enable / Disable Telemetry

Expected behavior
A visible link or instructions to find privacy details
Screenshots
If applicable, add screenshots to help explain your problem.
System Configuration (please complete the following information):

OS: [e.g. Windows]
OS Version: [e.g. Windows 10 1803]
Application Version: [e.g. 2.0.1-beta+50af283871]
CLI or GUI: GUI

Additional Context
Add any other context about the problem here.

Where should the link go?

I think the link should go to PRIVACY.md on GitHub, so "https://github.com/Microsoft/AttackSurfaceAnalyzer/blob/master/PRIVACY.md". Or we could go to the one associated with the commit of the build (e.g. "https://github.com/Microsoft/AttackSurfaceAnalyzer/blob/v2.0.59-beta%2Bb585cf3fe9/PRIVACY.md").
@Guydalf Any preference there?


Resolution Mismatch

Hello Sir,
I'm working with this repo and i'm stuck on the following:
If i use input-resolutions with dar 16:9 on 1920x1080 or below like 1280x720 or 640x360 the pipglshader works fine.
But if i have other resolutions the texture(s) is/are screwed up.
I've put a sample into my repo on: SAMPLE
I've looked into the source and tried some stuff but i can't get it right.
I've patched FFmpeg-n4.3.1 with your code. (SOURCES)
I would like to use different (full) resolutions that i can use in the GPU shaders so i can zoom in on them....
Maybe you got a fix?
Thanks for reading, have a nice day.
Gerard W.

If i use input-resolutions with dar 16:9 on 1920x1080 or below like 1280x720 or 640x360 the pipglshader works fine.
But if i have other resolutions the texture(s) is/are screwed up.

Resolution:
If your render-window's aspect ratio is not match video's aspect ration,  you should scale the video's aspect same sa windows's aspect;   last,  after render, scale it back to your target~

If i use input-resolutions with dar 16:9 on 1920x1080 or below like 1280x720 or 640x360 the pipglshader works fine.
But if i have other resolutions the texture(s) is/are screwed up.

Resolution:
If your render-window's aspect ratio is not match video's aspect ration, you should scale the video's aspect same sa windows's aspect; last, after render, scale it back to your target~

What should I do when using vertical video?
Currently, it can support 16:9 on 1920x1080, but if it is 9:16 on 1080x1920?
thanks

What should I do when using vertical video? Currently, it can support 16:9 on 1920x1080, but if it is 9:16 on 1080x1920? thanks

I have the same question.
Also, what if the original video resolution is higher than the screen? Is there a simple demo that we can learn about

What is the cause? Can you provide an idea to let us modify the source code to achieve the purpose

If i use input-resolutions with dar 16:9 on 1920x1080 or below like 1280x720 or 640x360 the pipglshader works fine.
But if i have other resolutions the texture(s) is/are screwed up.

Resolution:
If your render-window's aspect ratio is not match video's aspect ration, you should scale the video's aspect same sa windows's aspect; last, after render, scale it back to your target~

What is the reason? Can you provide an idea for us to modify the source code to solve the problem? Because scaling video can lead to quality loss and performance loss


Allow for setting minimum backing array size for Sequence

Some Sequence<T> instances may be used for large sequences but appended to in very small increments. This can mean many thousands of 32 byte arrays are allocated instead of just a few 4K arrays, for example, which would be much more efficient.
Sequence<T> should allow the owner to set the minimum size for any allocated backing array, so that if someone calls Sequence<T>.GetSpan(5) and a new array must be allocated, it will be that minimum size (e.g. 4K) instead of the ArrayPool minimum of 32 bytes.

See also https://github.com/dotnet/corefx/issues/12644#issuecomment-461918966