Adding Full Transitve Check on Schema Evolution (V2)

Codecov Report

Merging #396 into master will increase coverage by 0.02%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##           master     #396      +/-   ##
==========================================
+ Coverage   91.28%   91.31%   +0.02%
==========================================
  Files         139      139
  Lines        3006     3015       +9
  Branches      133      137       +4
==========================================
+ Hits         2744     2753       +9
  Misses        262      262

Impacted Files
Coverage Δ

...ain/scala/hydra/avro/registry/SchemaRegistry.scala
89.28% <83.33%> (-0.19%)
:arrow_down:

...in/scala/hydra.ingest/services/IngestionFlow.scala
92.30% <100.00%> (ø)

...scala/hydra/kafka/ingestors/KafkaTopicsActor.scala
100.00% <0.00%> (+3.57%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57ceb6e...eeabf9a. Read the comment docs.


Metadata in status messages

Some status mesages include metadata that should not itself trigger a status message.
For example, when you subscribe to signal group status in a TLC, you want a status update whenever any of the signal groups change state. When that happen, you the current cycle counter should be included. See https://github.com/rsmp-nordic/rsmp_sxl_traffic_lights/issues/21
But you don't want a status message each time just the cycle counter changes, but not the actual signal group status. This is already a problem when the cycle counter changes once per second, but it becomes much worse when we want to include the resolution of the cycle counter.
To support this, I suggest we distinguish between data and metadata in status attributes. Attributes marked as 'meta' should not trigger status updates.

Instead of marking some attributes in the SXL as metadata, we could make it possible to choose, when you subscribe, which attribute should trigger an update. More flexible, but also maybe more complex to implement.

Here's an example of a status subscription message:
{
     "mType": "rSMsg",
     "type": "StatusSubscribe",
     "mId": "d6d97f8b-e9db-4572-8084-70b55e312584",
     "ntsOId": "O+14439=481WA001",
     "xNId": "",
     "cId": "O+14439=481WA001",
     "sS": [
         {
             "sCI": "S0001",
             "n": "signalgroupstatus",
             "uRt": "5",
             "sOc": false
         },{
             "sCI": "S0001",
             "n": "cyclecounter",
             "uRt": "5",
             "sOc": false
         },{
             "sCI": "S0001",
             "n": "basecyclecounter",
             "uRt": "5",
             "sOc": false
         }
     ]
}

As shown, updateRate and sendOnChange is specified for each attribute.
Could we use these two existing flags to indicate that an attribute should only be send when other attributes change?
From https://rsmp-nordic.github.io/rsmp_core/3.2.2/applicability/basic_structure.html#structure-for-a-status-subscription-request-message:

It is not valid to set updateRate=0 and sendOnChange=false since it means that no subscription updates will be sent

A possibility would be change that definition to something like:

If updateRate=0 and sendOnChange=false then the attribute is considered metadata and will be send when another non-metadata attribute changes.

For example, when you subscribe to S0001, the cyclecounter could be subscribed to as metadata, so you only get a message when the signalgroupstatus attribute change, which will then include the cyclecounter:.
{
     "mType": "rSMsg",
     "type": "StatusSubscribe",
     "mId": "d6d97f8b-e9db-4572-8084-70b55e312584",
     "ntsOId": "O+14439=481WA001",
     "xNId": "",
     "cId": "O+14439=481WA001",
     "sS": [
         {
             "sCI": "S0001",
             "n": "signalgroupstatus",
             "uRt": "0",
             "sOc": true
         },{
             "sCI": "S0001",
             "n": "cyclecounter",
             "uRt": "0",
             "sOc": false
         }
     ]
}

The benefit of this would be:

no fields added or removed
no new types introduces (still string for uRt and boolean for sOc)

Added a PR #197 with the above of using uRt=0 and sOc=false to indicate lazy updates.


Changing the icon

Hi,
Would be nice to change the icon of collapse :)
Best wishes

you can add some styles, like:
.nestable-item-icon.icon-minus-gray {
    background: linear-gradient(to bottom, transparent 30%, pink, green, transparent 70%);
}

need another way?

1.1.0: added renderCollapseIcon which accepts a render function.


Delegate: SectionPostDelete

Should there not be a post delete delegate too?
I'm trying to develop something that fires after all create/edit/delete actions in sections and entries, and can't because there aren't a full set of delegates :(

That seems like an odd omission!

Should there not be a post delete delegate too?

I think so, yes.

Thanks.


Unhandled exception. System.NullReferenceException: Object reference not set to an instance of an object

Bicep CLI version 0.2.212 (a19d66c04c)
I'm absolutely loving bicep! Thankyou for the great work.  Just a minor issue when building the following (used for userAssignedIdentities):
var propname = 'ptest'
var issue = true ? {
    prop1: {
        '${propname}': {}
    }
} : {}

output out object = issue

you get
Unhandled exception. System.NullReferenceException: Object reference not set to an instance of an object.
   at Azure.Deployments.Expression.Expressions.JTokenExpression..ctor(String value, TemplateErrorAdditionalInfo additionalInfo)

Super easy workaround is to just use a intermediate variable, then it works fine
var propname = 'ptest'
var prop1_val = {
    prop1: {
        '${propname}': {}
    }
}
var issue = true ? prop1_val : {}

output out object = issue

Thanks for reporting this. We will take a look...

Thanks for reporting this. We will take a look...

I've looked closer at this issue and main reason is that public JTokenExpression(string value, TemplateErrorAdditionalInfo additionalInfo = null); from Azure.Deployments.Expression.Expressions does not take null as first argument.
I went briefly though the code and besides the https://github.com/Azure/bicep/blob/9e308aa7b2c7317d4213fb6fc07be9938318f0e5/src/Bicep.Core/Emit/ExpressionConverter.cs#L388 (cause of this NRE) are more places where we pass string? variables. I think we should go though the code and add ?? string.Empty in those places.
I could take this one, if you don't mind.
As a followup - it would be nice if the library supported nullables :)

I've looked closer at this issue and main reason is that public JTokenExpression(string value, TemplateErrorAdditionalInfo additionalInfo = null); from Azure.Deployments.Expression.Expressions does not take null as first argument.
I went briefly though the code and besides the https://github.com/Azure/bicep/blob/9e308aa7b2c7317d4213fb6fc07be9938318f0e5/src/Bicep.Core/Emit/ExpressionConverter.cs#L388 (cause of this NRE) are more places where we pass string? variables. I think we should go though the code and add ?? string.Empty in those places.
I could take this one, if you don't mind.
As a followup - it would be nice if the library supported nullables :)

Although looking deeper it's not that simple as it seems - Thing is that currently bicep does not support interpolating property names - we use TryGetLiteralValue in
https://github.com/Azure/bicep/blob/9e308aa7b2c7317d4213fb6fc07be9938318f0e5/src/Bicep.Core/Syntax/ObjectPropertySyntax.cs#L24
So the real fix is not just to avoid null but allow object's property names to be interpolated in this case.

Although looking deeper it's not that simple as it seems - Thing is that currently bicep does not support interpolating property names - we use TryGetLiteralValue in
https://github.com/Azure/bicep/blob/9e308aa7b2c7317d4213fb6fc07be9938318f0e5/src/Bicep.Core/Syntax/ObjectPropertySyntax.cs#L24
So the real fix is not just to avoid null but allow object's property names to be interpolated in this case.

Btw, this bug happened because the underlying library wasn't built with c# nullability enabled. I opened #1382 to track the work to enable it.

Btw, this bug happened because the underlying library wasn't built with c# nullability enabled. I opened #1382 to track the work to enable it.

@miqm Is this ok to merge?

@miqm Is this ok to merge?

yes :shipit:

yes :shipit:

Merged it.

Merged it.

yes :shipit:

yes :shipit:


[fuzzing] jellyfish fuzzers

Motivation
Convert proptests to fuzzers

@mimoo  Is the propfuzz still beta? https://fb.workplace.com/groups/2044217752540140/permalink/2332383197056926

@bors-libra land


app: check asset id in fee stateful check

Fix #4106.
@hdevalence I remember discussing with you making the fee method return a Value, but I don't recall why we decided against it.

Hmm, I didn't remember that discussion (could very well have happened though). Fix looks good!


cli: secrets not available in containers while running popper installed by the installation script

How to reproduce?

Install popper using the installation script
Take a workflow (wf.yml) like the one shown below,

steps:
- uses: "popperized/bin/sh@master"
  args: ["echo $NAME"]
  secrets: ["NAME"]

- uses: "docker://alpine:3.11"
  args: ["ls"]

As the workflow requires a secret NAME to be defined in the current shell, define it by doing,
$ export NAME=xxx

Now, try running the workflow

$ popper run -f wf.yml

It would be found that although the NAME environment variable is defined in the current shell, popper does not detect it and prompts the user to enter the value of the secret which should not happen. Maybe this is because currently, the docker run command in the executable script does not bind the environment variables from the current shell.

thanks for checking @JayjeetAtGithub. This is an outcome of running Popper in Docker. What I thought of is to tweak the installer so that the popper script captures all variables from the current environment, put them in a file, then remove PATH, HOME, TERM, HOSTNAME, SHLVL and _ variables, and then use the --env-file flag of docker run to capture the environment from the host.

Yeah. sounds good. I have currently added a printenv > envfile  command in my /usr/local/bin/popper script and passed it using --env-file to docker run and it works.

I have currently added a printenv > envfile command in my /usr/local/bin/popper script and passed it using --env-file to docker run and it works.

That should be enough actually, since the popper run command (and hence the container) doesn't rely on any of these variables.

Yeah, I am opening a PR shortly.


Move to using ROOT source of Afterimage

This uses the latest version of Afterimage from the ROOT sources, since the official Afterimage has not been updated since 2010. The changelog mentions 1.21, so I'll call this 1.21, though the original ROOT source version is there and important, too.

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

Jinja2 variable definitions are suggested to take a {%<one space>set<one space><variable name><one space>=<one space><expression><one space>%} form. See lines [2]

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin please rerender


ADE20K testset

Hi! I didn't find the testset  download link in official website. So where I can download the testset? Looking fowrard to your reply. Thanks!

http://sceneparsing.csail.mit.edu/

The above link does not host the model files - are they hosted anywhere else?


Update Latest Dapr Protos

Signed-off-by: Bernd Verst<EMAIL_ADDRESS>Description
Update to latest Dapr Protos

Once this PR has been merged #315 should be rebased.


Add CI/CD pipelines for backend services

As a DevOps
I need to add CI/CD pipelines for backend services
So that the deployment process is automated, consistent and reliable.
Details and Assumptions
* The CI/CD pipelines should automate the building, testing and deployment of backend services.
* The pipelines should be configured to run on code commits and merges to the main branch.
* Ensure that the pipelines include steps for running unit tests and integration tests.
* The deployment process should be configured to deploy services to the designated environment (e.g., staging, production).
* Proper notifications and logging should be set up to monitor pipeline execution and detect failures.

Acceptance Criteria
Given the requirements for CI/CD pipelines
When I add CI/CD pipelines for the backend services
Then the pipelines should automatically build and test the code on commits
And the pipelines should deploy the services to the designated environment
And the pipelines should include steps for running tests
And proper notifications and logging should be in place

I'm working on it at the moment.


No mention of AddRazorSupportForMvc although warning links to this page

C:\Program Files\dotnet\sdk\3.0.100\Sdks\Microsoft.NET.Sdk.Razor\build\netstandard2.0\Sdk.Razor.CurrentVersion.targets(838,5): warning RAZORSDK1004: One or more Razor view or page files were found, but the project is not configured to add Razor support for MVC. The MSBuild property 'AddRazorSupportForMvc' must be set to correctly compile Razor files that target MVC. For more information, see https://go.microsoft.com/fwlink/?linkid=868374.

I expected to find more information.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8e930c44-70f6-8820-1451-d1f781ded7a0
Version Independent ID: 6a25fc79-b9b3-4bbf-4fde-8e44b3d8014e
Content: ASP.NET Core Razor SDK
Content Source: aspnetcore/razor-pages/sdk.md
Product: aspnet-core
Technology: aspnetcore-razorpages
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

@pranavkm can we add info for
The MSBuild property 'AddRazorSupportForMvc' must be set to correctly compile Razor files that target MVC.

@pranavkm let's get this covered in docs.

Possible Solution:
Edit Project Class File so it reads below:

netcoreapp3.1
true

.....

I just hit this issue while following some Javier Blazor guidance.

Thanks for your comment, I just got the same issue, @AnotherRandomTech your comment is very helpful.

Is there any remaining work here? It seems that https://github.com/dotnet/AspNetCore.Docs/pull/16690 already added the missing content for AddRazorSupportForMvc.
@mkArtakMSFT @guardrex

Looks right to me ... resolved by #16690 and in the live topic at ...
https://learn.microsoft.com/en-us/aspnet/core/razor-pages/sdk?view=aspnetcore-7.0#properties


Alpha 123 crash / blank window

OS: MacOS bigsur 11.1
Terminus version Alpha 122 -> Alpha 123
Try update and re-install ways, no help.
Crash in the loading process, have to force quit each time.
for Alpha 122 or even elder versions, everything is ok.
looking forward to fix asap, really a perfect app.
https://user-images.githubusercontent.com/749762/103192685-808f9880-4914-11eb-861b-fe95b09d43f9.mov

Seems to find the reason, crash when load local machine (folder), but in 122, it's OK.
BTW:
copy (text or content) not work sometimes, have to right click mouse to use copy.

I also got this problem

sadly I lost all my nodes config, because the auto login as last time, and last time I opened local tab, so dead end.....

same problem, downgrading fixes it temporarily.
Here's the error in the window console:
GET file:///Applications/Terminus.app/Contents/Resources/app.asar/dist/[object%20Module] net::ERR_FILE_NOT_FOUND

I have fixed it doing this:
Disable auto-updates and install Terminus version Alpha 122

How do you disable auto updates?

Ah nvm, I found it in the general preferences. Somehow I couldn't find it earlier

Please post the crash report (it's found under Console.app -> Crash Reports).

Please post the crash report (it's found under Console.app -> Crash Reports).

There is no crash report listed for Terminus.

In system.log of Console.app I see this:
Dec 30 21:23:39 Matiass-MacBook-Pro-2 Terminus Helper (GPU)[8402]: getattrlist failed for /System/Library/Extensions/AppleIntelKBLGraphicsGLDriver.bundle/Contents/MacOS/AppleIntelKBLGraphicsGLDriver: #2: No such file or directory
Dec 30 21:23:39 Matiass-MacBook-Pro-2 Terminus Helper (GPU)[8402]: getattrlist failed for /Library/GPUBundles/AMDRadeonX6000GLDriver.bundle/Contents/MacOS/ATIRadeonX6000SCLib.dylib: #2: No such file or directory
Dec 30 21:23:39 Matiass-MacBook-Pro-2 Terminus Helper (GPU)[8402]: getattrlist failed for /System/Library/Extensions/AMDRadeonX6000GLDriver.bundle/Contents/MacOS/ATIRadeonX6000SCLib.dylib: #2: No such file or directory
Dec 30 21:23:39 Matiass-MacBook-Pro-2 Terminus Helper (GPU)[8402]: getattrlist failed for /System/Library/Frameworks/OpenGL.framework/Resources//GLRendererFloat.bundle/GLRendererFloat: #2: No such file or directory

I have graphics AMD Radeon Pro 5500M 4 GB, if that helps..

Fixed in Alpha 124

Fixed in Alpha 124


feat: Adds postgres support

Signed-off-by: Andrii Soluk<EMAIL_ADDRESS>

Codecov Report

Merging #37 (2b46eb2) into main (1f29038) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
- Coverage   86.45%   86.32%   -0.13%
==========================================
  Files           8        8
  Lines         893      885       -8
==========================================
- Hits          772      764       -8
  Misses         77       77
  Partials       44       44

Impacted Files
Coverage Δ

cmd/vct/startcmd/start.go
83.66% <100.00%> (-0.43%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f29038...2b46eb2. Read the comment docs.


STAT-159 ⁃ eosd to mongodb storing json fails for native contract

Noticed following error on node4 in testnet when we execute native eos transfer from one accoutn to another. It only occurs on node 4.
to convert Message.data to ABI type: nonce, what: Assert Exception (10)
itr != structs.end(): Unknown struct

3060039ms thread-1   db_plugin.cpp:210             add_data             ] Unable to convert Message.data to ABI type: nonce, what: Assert Exception (10)
itr != structs.end(): Unknown struct

ATC:

Transfer from one account to another using -f option which will create a nonce. Verify no error in the log.

➤ Dhanesh Valappil commented:
made a transfer between two producers successfully from node1
confirmed the account balance from node2
in all the steps, no errors were reported


Backend should be updated to serve requests asynchronously.

Update twisted code to be async.

Should be async now.


JSONRPC Api doesn't work in dev

Hi, there!
Thank you for using SoftEther.
Before you submit an issue, please read the following:
Is this a question?

If the answer is "yes", then please ask your question on www.vpnusers.com.
The issue section on GitHub is reserved for bugs and feature requests.

If the answer is "no", please read the following:

We provide a template which is specifically made for bug reports, in order to be sure that the report includes enough details to be helpful.
Please use or adapt it as needed.

Prerequisites

[x] Can you reproduce?
[x] Are you running the latest version of SoftEtherVPN?

Latest dev
Server and Bridge
Linux
64 Bit
[In case it's a computer with known specs, such as the Raspberry Pi, you can specify it omitting the details.]
Intel i7 NUC
Description
The API doesn't work and keeps giving the following errors when trying to use it
 raise ConnectionError(err, request=request)
requests.exceptions.ConnectionError: ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response',))

Expected behavior:
It should control the server or bridge
Actual behavior:
Gives error and nothing happens
Steps to reproduce

Setup server/bridge
Try a simple test api call to it
Watch as it refuses to function

It works for me.
This shortest snippet that I tried to test the JSON RPC.
git clone https://github.com/SoftEtherVPN/SoftEtherVPN.git
./configure && make -C tmp
cd ./build
sudo ./vpnserver start

curl -k --basic --user administrator  https://localhost:5555/api/ --data '
{
  "jsonrpc": "2.0",
  "id": "rpc_call_id",
  "method": "GetCaps",
  "params": {}
}'

The JSON-RPC returns the following JSON.
{
    "result": {
        "CapsList": [
            {
                "CapsDescrption_utf": "最大 Ethernet パケットサイズ",
                "CapsName_str": "i_max_packet_size",
                "CapsValue_u32": 1600
            },
            {
                "CapsDescrption_utf": "最大仮想 HUB 数",
                "CapsName_str": "i_max_hubs",
                "CapsValue_u32": 100000
            },
            {
                "CapsDescrption_utf": "最大同時接続可能セッション数",
                "CapsName_str": "i_max_sessions",
                "CapsValue_u32": 100000
            },
            {
                "CapsDescrption_utf": "最大作成可能ユーザー数",
                "CapsName_str": "i_max_user_creation",
                "CapsValue_u32":<PHONE_NUMBER>
            },
            {
                "CapsDescrption_utf": "最大クライアントセッション数",
                "CapsName_str": "i_max_clients",
                "CapsValue_u32":<PHONE_NUMBER>
            },
(snip)

Have the same issue by trying either with the C# client or already with Invoke-Webrequest in Powershell. It works fine with stable but not with dev.
Tried with 5.01 Build 9672 as precompiled windows binary and my own inside a docker container but both show the same error.

when I use the node pkg, I have got the same problem: A client which is non-SoftEther VPN software has connected to the port., but if the admin page https://<IP_ADDRESS>:5555/admin/ is working
what is the diffrence between the html5 ajax client sdk and the node package client sdk ?

I still got this issue in version 5.02.5180 using vpnrpc.ts nodejs library

Have any solution to resolve this issue?

I'll have a look

@weidi , can you help with you powershell repro steps ?
I wrote simple PowerShell script (it requires PowerShell 6 and above due to -SkipCertificateCheck flag. However, it works even with mentioned 5.01 Build 9672
https://gist.github.com/shipitsin-ilia/5b31c3415187d91947854b2064641b61

Issue happens when specifying X-VPNADMIN-HUBNAME and X-VPNADMIN-PASSWORD instead of basic auth like so
$ErrorActionPreference = 'Stop'

$body = @"
{
    "jsonrpc": "2.0",
    "id": "rpc_call_id",
    "method": "GetCaps",
    "params": {}
}
"@

$headers = @{
    'Content-Type'='application/json'
    'X-VPNADMIN-HUBNAME'= ""
	'X-VPNADMIN-PASSWORD'= "Administrator"
    }

$r = Invoke-WebRequest -UseBasicParsing -Method 'Post' -Uri 'https://<IP_ADDRESS>:444/api/' -Body $body -Headers $headers -SkipCertificateCheck
$r.Content

2023-01-03 20:19:29.928 On the TCP Listener (Port 443), a Client (IP address <IP_ADDRESS>, Host name "a46a01f2-07a2-42c4-aa6b-e475f3fe82cc.fritz.box", Port number 51708) has connected. 2023-01-03 20:19:29.928 For the client (IP address: <IP_ADDRESS>, host name: "a46a01f2-07a2-42c4-aa6b-e475f3fe82cc.fritz.box", port number: 51708), connection "CID-5" has been created. 2023-01-03 20:19:29.948 SSL communication for connection "CID-5" has been started. The encryption algorithm name is "TLS_AES_256_GCM_SHA384". 2023-01-03 20:19:29.978 Connection "CID-5" terminated by the cause "A client which is non-SoftEther VPN software has connected to the port." (code 5). 2023-01-03 20:19:29.978 Connection "CID-5" has been terminated. 2023-01-03 20:19:29.978 The connection with the client (IP address <IP_ADDRESS>, Port number 51708) has been disconnected.
This is mentioned in the Help
For JSON-RPC client logins:Instead to HTTP basic
authentication, you can also specify the HTTP header parameters as following.

        X-VPNADMIN-HUBNAME: Empty to login to the VPN Server as the entire
        server administrator, or specify the target Virtual Hub name as the hub
        administrator.
        X-VPNADMIN-PASSWORD: Specify the administrative password.

I tried modify vpnrpc.ts with Authorization header but issue still exist with error
return _super.call(this, message) || this;
                      ^

Error: HTTP Error: Error socket hang up
    at new HttpClientException (E:\hoangnd\javascript\vpnrpc.ts\dist\vpnrpc.js:3581:23)
    at ClientRequest.<anonymous> (E:\hoangnd\javascript\vpnrpc.ts\dist\vpnrpc.js:3680:24)
    at ClientRequest.emit (node:events:527:28)
    at TLSSocket.socketOnEnd (node:_http_client:478:9)
    at TLSSocket.emit (node:events:539:35)
    at endReadableNT (node:internal/streams/readable:1345:12)
    at processTicksAndRejections (node:internal/process/task_queues:83:21)

Finally I found the issue is send empty X-VPNADMIN-HUBNAME header. If ignore it when it empty vpnrpc.ts will be working fine.
Working constructor:
constructor(vpnserver_hostname?: string, vpnserver_port?: number, hubname?: string, password?: string, nodejs_https_client_reject_untrusted_server_cert?: boolean)
    {
        let headers: { [name: string]: string } = {};
        let send_credentials: boolean = false;

        nodejs_https_client_reject_untrusted_server_cert = is_null(nodejs_https_client_reject_untrusted_server_cert) ? false : nodejs_https_client_reject_untrusted_server_cert!;

        if (is_null(vpnserver_hostname))
        {
            this.rpc_url = "/api/";
            send_credentials = true;
        }
        else
        {
            if (is_null(vpnserver_port)) vpnserver_port = 443;
            this.rpc_url = `https://${vpnserver_hostname}:${vpnserver_port}/api/`;

            if (hubname) {
                headers["X-VPNADMIN-HUBNAME"] = hubname!;
            }
            if (password) {
                headers["X-VPNADMIN-PASSWORD"] = password!;
            }
        }

        if (is_null(nodejs_https_client_reject_untrusted_server_cert)) nodejs_https_client_reject_untrusted_server_cert = false;

        this.rpc_client = new JsonRpcClient(this.rpc_url, headers, send_credentials, nodejs_https_client_reject_untrusted_server_cert);
    }


WIP: Different error handling

This is a WIP-PR for better error management

[x] RCPT TO: 550 response
[ ] ...

closed for now (priority is #15 )


add constructor to main widget

Hey,
This issue ( #94 ) looked interesting and beginner-friendly,
I just wanted to know if this was a good start.

Hi @vaniisgh thanks for taking this on! This looks like a good start but there are a few things to clean up.
TODO:

Add some examples documenting this
Add a docstring to __init__ with  parameters section
Cleanup checking for string in the from_json method (I'll add an inline review)
Add a check for neo4j graphs
Change the name from graph_file to something more general.

It's not necessarily a file that user will be passing in.

Make the formatter happy by running black .

Also looking at the test failures there are unfortunately several due to neo4j which aren't your fault. This makes it trickier to see if your are causing issues but you can look more closely by clicking on the details next to the failing test.

hey thank you so much for the feedback!
I tried to take the things you mentioned into account and made a few changes though, I still think I might need to revise my work a bit.
Also, I apologize forgot to rebase my work on the current master I hope I did it correctly now.

I think it should be better now :)

Thanks for the ping! This slipped through the cracks for me - can look later

are there any other changes that I could make :) ?

@ianhi should i close this ?

Thank you @vaniisgh !! This is a great addition and we can always iterate more as needed.

@ianhi should i close this ?

Definitely not that - I'm really sorry about the long periods of non-responsiveness that's totally on me. I really appreciate you coming and putting the effort to make a positive change. I can't promise to be perfect, but I can promise that I will at least try to be more honest myself about what I can claim to do. Also don't be scared to ping more and more often (though ideally course you shouldn't have to :/ )

This should be live in version 1.3.0 soon!


HADOOP-18816. Rebuild exceptions on Client side

Description of PR
In current's RPC design, if Server sends an exception back, Client can only rebuild the exception according to the original exception's error message, if the exceptions has some fields containing important information, they will be discarded since we can not rebuild them based on message string easily.
This ticket is to introduce a new interface for Exceptions which supports reconstructing. If Clients want to rebuild the exception, they can just implement the methods and the reconstruction will be done automatically.
The interface uses String[] as parameter for simplicity.  I thought of using Protobuf to store all the exceptions or fields, but the generacity can not be perfectlly met. So we need Client to support it by accepting "String[]" and transform the String to it's original type.
JIRA: https://issues.apache.org/jira/browse/HADOOP-18816
How was this patch tested?
unit test.
For code changes:

[x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@steveloughran Thank you for the review. Updated most of the comment, please have a look.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 39s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
buf
0m  0s

buf was not available.

+0 :ok:
buf
0m  0s

buf was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 34s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
32m 49s

trunk passed

+1 :green_heart:
compile
19m 28s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
17m 46s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
4m 26s

trunk passed

+1 :green_heart:
mvnsite
3m  8s

trunk passed

+1 :green_heart:
javadoc
2m 30s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 52s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
5m 36s

trunk passed

+1 :green_heart:
shadedclient
35m 58s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 32s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 53s

the patch passed

+1 :green_heart:
compile
18m 33s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
cc
18m 33s

the patch passed

+1 :green_heart:
javac
18m 33s

the patch passed

+1 :green_heart:
compile
18m  5s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
cc
18m  5s

the patch passed

+1 :green_heart:
javac
18m  5s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
4m 18s
/results-checkstyle-root.txt
root: The patch generated 4 new + 242 unchanged - 0 fixed = 246 total (was 242)

+1 :green_heart:
mvnsite
2m 56s

the patch passed

-1 :x:
javadoc
1m 14s
/results-javadoc-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1.txt
hadoop-common-project_hadoop-common-jdkUbuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
javadoc
1m 52s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
5m 57s

the patch passed

+1 :green_heart:
shadedclient
37m  7s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
36m 33s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

+1 :green_heart:
unit
2m 47s

hadoop-hdfs-client in the patch passed.

+1 :green_heart:
asflicense
1m  5s

The patch does not generate ASF License warnings.

277m 42s

Reason
Tests

Failed junit tests
hadoop.ipc.TestProtoBufRpc

hadoop.ha.TestHealthMonitor

hadoop.ha.TestHealthMonitorWithDedicatedHealthAddress

hadoop.ipc.TestRpcServerHandoff

hadoop.ipc.TestProtoBufRPCCompatibility

hadoop.ipc.TestSaslRPC

hadoop.ipc.TestMultipleProtocolServer

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5863/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5863

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets cc buflint bufcompat

uname
Linux 316093f06a96 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 42569b32bcee1d1c50027214ee95e354476b31b1

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5863/2/testReport/

Max. process+thread count
3150 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5863/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 40s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
buf
0m  1s

buf was not available.

+0 :ok:
buf
0m  1s

buf was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
46m 27s

trunk passed

+1 :green_heart:
compile
17m 22s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
16m 16s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m 25s

trunk passed

+1 :green_heart:
mvnsite
1m 47s

trunk passed

+1 :green_heart:
javadoc
1m 23s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 57s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
2m 37s

trunk passed

+1 :green_heart:
shadedclient
35m 21s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
35m 49s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 59s

the patch passed

+1 :green_heart:
compile
16m 30s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
cc
16m 30s

the patch passed

+1 :green_heart:
javac
16m 30s

the patch passed

+1 :green_heart:
compile
16m 18s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
cc
16m 18s

the patch passed

+1 :green_heart:
javac
16m 18s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m 22s
/results-checkstyle-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common: The patch generated 1 new + 236 unchanged - 6 fixed = 237 total (was 242)

+1 :green_heart:
mvnsite
1m 49s

the patch passed

+1 :green_heart:
javadoc
1m 18s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m  0s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

-1 :x:
spotbugs
2m 48s
/new-spotbugs-hadoop-common-project_hadoop-common.html
hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
shadedclient
36m  3s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
19m 29s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
1m 11s

The patch does not generate ASF License warnings.

226m 43s

Reason
Tests

SpotBugs
module:hadoop-common-project/hadoop-common

Unchecked/unconfirmed cast from java.io.IOException to org.apache.hadoop.ipc.ReconstructableException in org.apache.hadoop.fs.protocolPB.PBHelper.getReconstructParams(Throwable)  At PBHelper.java:org.apache.hadoop.ipc.ReconstructableException in org.apache.hadoop.fs.protocolPB.PBHelper.getReconstructParams(Throwable)  At PBHelper.java:[line 143]

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5863/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5863

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets cc buflint bufcompat

uname
Linux dec971ccdf69 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 8f83da4a1b1d55c7a10edc715e3ed09d44952248

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5863/4/testReport/

Max. process+thread count
3149 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5863/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@ZanderXu could you please take a look at this PR when you are available? Thanks

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 39s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
buf
0m  1s

buf was not available.

+0 :ok:
buf
0m  1s

buf was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
45m  5s

trunk passed

+1 :green_heart:
compile
17m 26s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
16m 18s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m 24s

trunk passed

+1 :green_heart:
mvnsite
1m 46s

trunk passed

+1 :green_heart:
javadoc
1m 25s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 59s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
2m 44s

trunk passed

+1 :green_heart:
shadedclient
35m 20s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
35m 48s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 57s

the patch passed

+1 :green_heart:
compile
16m 43s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
cc
16m 43s

the patch passed

+1 :green_heart:
javac
16m 43s

the patch passed

+1 :green_heart:
compile
16m  6s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
cc
16m  6s

the patch passed

+1 :green_heart:
javac
16m  6s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 22s

hadoop-common-project/hadoop-common: The patch generated 0 new + 236 unchanged - 6 fixed = 236 total (was 242)

+1 :green_heart:
mvnsite
1m 47s

the patch passed

+1 :green_heart:
javadoc
1m 17s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 52s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

-1 :x:
spotbugs
3m 13s
/new-spotbugs-hadoop-common-project_hadoop-common.html
hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
shadedclient
40m  2s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
19m 19s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
1m 11s

The patch does not generate ASF License warnings.

228m 55s

Reason
Tests

SpotBugs
module:hadoop-common-project/hadoop-common

Unchecked/unconfirmed cast from java.io.IOException to org.apache.hadoop.ipc.ReconstructableException in org.apache.hadoop.fs.protocolPB.PBHelper.getReconstructParams(Throwable)  At PBHelper.java:org.apache.hadoop.ipc.ReconstructableException in org.apache.hadoop.fs.protocolPB.PBHelper.getReconstructParams(Throwable)  At PBHelper.java:[line 144]

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5863/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5863

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets cc buflint bufcompat

uname
Linux 6ca14feb20f8 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 7d9bc8aa0438b55facef45feddb879d0211a37d8

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5863/5/testReport/

Max. process+thread count
1263 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5863/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@jojochuang Could you also help to review this PR when you are available?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 37s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
buf
0m  0s

buf was not available.

+0 :ok:
buf
0m  0s

buf was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
46m 38s

trunk passed

+1 :green_heart:
compile
19m 35s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
17m 51s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m 25s

trunk passed

+1 :green_heart:
mvnsite
1m 48s

trunk passed

+1 :green_heart:
javadoc
1m 22s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 53s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
2m 49s

trunk passed

+1 :green_heart:
shadedclient
35m 43s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
36m  9s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 58s

the patch passed

+1 :green_heart:
compile
18m 21s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
cc
18m 21s

the patch passed

+1 :green_heart:
javac
18m 22s

the patch passed

+1 :green_heart:
compile
17m 46s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
cc
17m 46s

the patch passed

+1 :green_heart:
javac
17m 46s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m 23s
/results-checkstyle-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common: The patch generated 1 new + 236 unchanged - 6 fixed = 237 total (was 242)

+1 :green_heart:
mvnsite
1m 46s

the patch passed

+1 :green_heart:
javadoc
1m 11s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 57s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

-1 :x:
spotbugs
3m  4s
/new-spotbugs-hadoop-common-project_hadoop-common.html
hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
shadedclient
36m 22s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
19m 33s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
1m  4s

The patch does not generate ASF License warnings.

234m  7s

Reason
Tests

SpotBugs
module:hadoop-common-project/hadoop-common

Unchecked/unconfirmed cast from java.io.IOException to org.apache.hadoop.ipc.ReconstructableException in org.apache.hadoop.fs.protocolPB.PBHelper.getReconstructProto(Throwable)  At PBHelper.java:org.apache.hadoop.ipc.ReconstructableException in org.apache.hadoop.fs.protocolPB.PBHelper.getReconstructProto(Throwable)  At PBHelper.java:[line 148]

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5863/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5863

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets cc buflint bufcompat

uname
Linux 6e5899ab2c02 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 365e43a75c8b2ee943d6675a712899cd37f9a57a

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5863/6/testReport/

Max. process+thread count
3149 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5863/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 38s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
buf
0m  1s

buf was not available.

+0 :ok:
buf
0m  1s

buf was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
45m 35s

trunk passed

+1 :green_heart:
compile
19m  7s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
18m  7s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m 27s

trunk passed

+1 :green_heart:
mvnsite
1m 47s

trunk passed

+1 :green_heart:
javadoc
1m 20s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 58s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
2m 45s

trunk passed

+1 :green_heart:
shadedclient
37m 20s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
37m 48s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 58s

the patch passed

+1 :green_heart:
compile
18m 22s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
cc
18m 22s

the patch passed

+1 :green_heart:
javac
18m 22s

the patch passed

+1 :green_heart:
compile
17m 39s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
cc
17m 39s

the patch passed

+1 :green_heart:
javac
17m 39s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m 18s
/results-checkstyle-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common: The patch generated 1 new + 236 unchanged - 6 fixed = 237 total (was 242)

+1 :green_heart:
mvnsite
1m 50s

the patch passed

+1 :green_heart:
javadoc
1m 18s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 53s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

-1 :x:
spotbugs
2m 57s
/new-spotbugs-hadoop-common-project_hadoop-common.html
hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
shadedclient
36m 34s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
19m 34s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
1m 12s

The patch does not generate ASF License warnings.

234m 49s

Reason
Tests

SpotBugs
module:hadoop-common-project/hadoop-common

Unchecked/unconfirmed cast from java.io.IOException to org.apache.hadoop.ipc.ReconstructableException in org.apache.hadoop.fs.protocolPB.PBHelper.getReconstructProto(Throwable)  At PBHelper.java:org.apache.hadoop.ipc.ReconstructableException in org.apache.hadoop.fs.protocolPB.PBHelper.getReconstructProto(Throwable)  At PBHelper.java:[line 148]

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5863/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5863

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets cc buflint bufcompat

uname
Linux 96a3fc6e21a3 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 365e43a75c8b2ee943d6675a712899cd37f9a57a

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5863/7/testReport/

Max. process+thread count
2887 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5863/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 39s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
buf
0m  0s

buf was not available.

+0 :ok:
buf
0m  0s

buf was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
47m  1s

trunk passed

+1 :green_heart:
compile
17m 14s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
17m 53s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m 20s

trunk passed

+1 :green_heart:
mvnsite
1m 42s

trunk passed

+1 :green_heart:
javadoc
1m 18s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 56s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
2m 44s

trunk passed

+1 :green_heart:
shadedclient
39m  5s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
39m 33s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 59s

the patch passed

+1 :green_heart:
compile
16m 41s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
cc
16m 41s

the patch passed

+1 :green_heart:
javac
16m 41s

the patch passed

+1 :green_heart:
compile
16m 12s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
cc
16m 12s

the patch passed

+1 :green_heart:
javac
16m 12s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 21s

hadoop-common-project/hadoop-common: The patch generated 0 new + 249 unchanged - 6 fixed = 249 total (was 255)

+1 :green_heart:
mvnsite
1m 45s

the patch passed

+1 :green_heart:
javadoc
1m 16s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m  0s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
2m 45s

the patch passed

+1 :green_heart:
shadedclient
36m  2s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
19m 16s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
1m  9s

The patch does not generate ASF License warnings.

231m 40s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5863/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5863

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets cc buflint bufcompat

uname
Linux 2bfb52ed7eaf 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 79b91bab0065cae2460f2ed43d3dc3f1cb98edc2

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5863/8/testReport/

Max. process+thread count
1263 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5863/8/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 39s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
buf
0m  1s

buf was not available.

+0 :ok:
buf
0m  1s

buf was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
43m 49s

trunk passed

+1 :green_heart:
compile
17m 24s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
16m 20s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m 24s

trunk passed

+1 :green_heart:
mvnsite
1m 48s

trunk passed

+1 :green_heart:
javadoc
1m 25s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m  0s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
2m 41s

trunk passed

+1 :green_heart:
shadedclient
36m  4s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
36m 32s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 57s

the patch passed

+1 :green_heart:
compile
16m 32s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
cc
16m 32s

the patch passed

+1 :green_heart:
javac
16m 32s

the patch passed

+1 :green_heart:
compile
16m 21s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
cc
16m 21s

the patch passed

+1 :green_heart:
javac
16m 21s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 21s

hadoop-common-project/hadoop-common: The patch generated 0 new + 249 unchanged - 6 fixed = 249 total (was 255)

+1 :green_heart:
mvnsite
1m 49s

the patch passed

+1 :green_heart:
javadoc
1m 20s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m  0s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
2m 49s

the patch passed

+1 :green_heart:
shadedclient
35m 53s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
19m 15s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
1m 14s

The patch does not generate ASF License warnings.

224m 48s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5863/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5863

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets cc buflint bufcompat

uname
Linux 5421522b5377 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / b6b0b7f75f07c82c3985b47d3b91b60a485a67d9

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5863/9/testReport/

Max. process+thread count
3149 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5863/9/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
13m 32s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
buf
0m  0s

buf was not available.

+0 :ok:
buf
0m  0s

buf was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
44m 24s

trunk passed

+1 :green_heart:
compile
17m 37s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
16m  0s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
1m 23s

trunk passed

+1 :green_heart:
mvnsite
1m 51s

trunk passed

+1 :green_heart:
javadoc
1m 23s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
1m  1s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
2m 42s

trunk passed

+1 :green_heart:
shadedclient
36m  6s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
36m 34s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 56s

the patch passed

+1 :green_heart:
compile
16m 37s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
cc
16m 37s

the patch passed

+1 :green_heart:
javac
16m 37s

the patch passed

+1 :green_heart:
compile
16m  6s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
cc
16m  6s

the patch passed

+1 :green_heart:
javac
16m  6s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 23s

hadoop-common-project/hadoop-common: The patch generated 0 new + 249 unchanged - 6 fixed = 249 total (was 255)

+1 :green_heart:
mvnsite
1m 47s

the patch passed

+1 :green_heart:
javadoc
1m 18s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
1m  1s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
2m 47s

the patch passed

+1 :green_heart:
shadedclient
35m 56s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
19m 18s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
1m 12s

The patch does not generate ASF License warnings.

238m  0s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5863/11/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5863

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets cc buflint bufcompat

uname
Linux<PHONE_NUMBER>ef 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 64814889c8427099de9f3e73ba04fc9d5817b27d

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5863/11/testReport/

Max. process+thread count
1263 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5863/11/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@ZanderXu PR updated, PTAL.


Invalid version string on composer installation

I tried installing with the animate.css package and not work.
Error message:
  [UnexpectedValueException]
  Invalid version string "~3.2.0"

My composer.json:
    "require": {
    ...
        "bower-asset/animate.css": "3.2.0",
    ...
    },

bower.json file of the https://github.com/daneden/animate.css
{
    "name": "animate.css",
    "version": "~3.2.0",
    "main": "./animate.css"
}

It's not work because of the "~"?

Fixed by a54431994e8524dc09730e7985a9d7c9a9d636c0.

Thanks!


External Temperature - is it reported somewhere

I am trying to extract the external temperature as reported in the raw evohome json data (weather.temperature). I cannot see a function in this API which returns it. Is there one that I am missing?

Unfortunately I don't think so. If I remember correctly, the app goes directly to an external service to collect the external temperature - it doesn't come through the honeywell API. If you want API access to weather data, weather underground is often a good source and from memory free if you don't make large numbers of calls each day


Cards don't work on mobile devices

On mobile devices there's no way to invoke the transition to show the call to action button. We should enable the transition on a tap.

Fixed in PR #227


If prefixPath is empty, just use objectLocation

What does this change?
This fixes an issue where if prefixPath is empty a leading slash is appended to the path written to S3 resulting in "/" becoming the "folder name" for the object 😖
How to test

[x] Deploy this change, observe it publish to the correct location.

How can we measure success?
Files are published to their correct location with and without a prefix.

ooh good catch!


Live score isn't working

In web interface livescore doesn't works.

Hi,
I need a little more information.

Did you install the csgo-rcon-plugin on your CS:GO Server?
When you run sm plugins list in the CS:GO server terminal do you see that the plugin is active?
Did you update the baseUrl in the config.json to match the CS:GO server IP?
Is the CS:GO server able to access the Web panel over the network?

I haven't updated the baseUrl in config.json
Thanks a lot!
One more question: is it possible to made live round panel like on hltv scoreboard
for example:
player1 killed player2 with ak47
player4 killed player3 with m4a1

No problem!
In theorie it would be possible to get that data from SourceMod en then send it to the panel.
But then the question remains how would that look like on the panel?
If you need this I can have a look if itś possible to implement

It would be great, really want to see it. You can do separate tab called "Live" and there can be list of live matches. In every live match page can be scoreboard with round live panel like this

or like now on hltv

hello guys, i am new with this. Can help me to install csgo-rcon-nodejs? i have linux. thx

Hello again, i install all and when i execut command for start like npm run dev the web it's working but can't connect to rcon.
ERROR [RCON INIT][<IP_ADDRESS>:27015] Failed to connect to rcon: Error: connect ECONNREFUSED <IP_ADDRESS>:27015

This means that the Panel can't connect to that address. Are the devices able to communicate to each other? For example does a simple ping work? Because this could be firewall related. And are these devices on the same network?

i dont have firewall active on the linux.

I tried with <IP_ADDRESS> or localhost, but the same error

If the csgo server is on the same machine as the panel then <IP_ADDRESS>:27015 can be used. However if that already does not work then it means the csgo server maybe has rcon disabled. Are you running a dedicated csgo server of are you just launching a session from your csgo client?

Have you tried setting up rcon first: https://shockbyte.com/billing/knowledgebase/355/How-to-enable-RCON-on-your-CSGO-Server.html ?

i set the rcon_password in server.cfg also i set the rcon in console server but nothing.

Unable to connect to remote server (<IP_ADDRESS>:27015): (9) retries left :(

But thats a public ip. So now we are going 2 steps further. Because if it doesn't work locally then it will never work externally

Can you try this: telnet <IP_ADDRESS> 27015

in ssh connection: telnet: Unable to connect to remote host: Connection refused

i dont understand :/

Yeah oke if that is not working then there is something wrong with your server. Because this should reply with the server name if the connection is working

ok. thx for answare bro!

How is your network topology and system configuration. Because sometimes you mention it is running locally. And on the last message you mention a ssh connection?

i have 2 pc one is the server on linux and my pc on windows. i mentioned the server cs go and web panel is install on the same pc and i connect with putty from <IP_ADDRESS>. but the server it's working my site it's working.... everithing it's working, but one day I wanted to install an smtp server, and when I got to a test of telnet connection to the smtp server it worked once, and the second time it didn't work ... I don't know what happened but then it doesn't work anymore.

sorry for my english:/

i have ubuntu 20.04.. sorry i dont understand all you say

mmm That is really strange, but it sounds like something is then indeed blocking the network flow on the server itself. My suggestion would be to try to setup an empty virtual machine maybe locally on your Windows PC to see if that fixes the connection issues. But other then that I think there is nothing I can try from my side, I have the exact same setup as you but then on Ubuntu 18.04.

i search on google and i find this: sudo apt-get install telnetd
now telnet it's work but not telnet <IP_ADDRESS> 27015 same error

anyway thx for trying to help me. I'll look to see what I can do, maybe I'll find a solution .. if I don't reinstall ubuntu: /

i found the problem :)). The problem was that I didn't start the server with the ip given by the router ... it worked, the world could connect, but I couldn't connect to the rcon. I added + ip <IP_ADDRESS> + port 27015 and now everything is fine

I have one more question. as I add in crontab to start at startup npm run webpack and npm run dev?

Great to hear. No you can't use the crontab for that. The crontab is only used for running commands on specified times. What you what is a service file for systemd. With that you can setup a service that keeps de program running. An example on how to create such a file can be found here: https://www.shellhacks.com/systemd-service-file-example/


Remove TF dependency in reduce_on_plateau example

This PR removes Tensorflow as a dependency in reduce_on_plateau.ipynb, and uses only TFDS, with grain for loading and preparing the dataset.
Addressing issue #656

Sure, much more cleaner this way.

Hey @fabianp, looks like there is a problem with python 3.9 and grain.

ouch! yeah, I'm seeing from https://github.com/google/grain/blob/main/pyproject.toml that they require Python 3.10 ....

ouch indeed! 😅 What do you think? should we stick to notebook downloads until we get rid of either TensorFlow or Python 3.9?

I'm unsure. Let me talk today with the other optax devs to see what they
think
On Sun, Feb 4, 2024, 19:50 Mohammed Hamdy @.***> wrote:

ouch indeed! 😅 What do you think? should we stick to notebook downloads
until we get rid of either TensorFlow or Python 3.9?
—
Reply to this email directly, view it on GitHub
https://github.com/google-deepmind/optax/pull/768#issuecomment-1925895311,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACDZBYXEP4G7ZGONXUNHQDYR7Q6XAVCNFSM6AAAAABCYTNHXOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRVHA4TKMZRGE
.
You are receiving this because you were mentioned.Message ID:
@.***>

Sounds great!

BTW I submitted a PR fixing python 3.9 errors: https://github.com/google/grain/pull/338

That's QUITE a PR! 😅😅

yeah, one thing that worries me a bit more about pygrain is that it it doesn't seem to build on OSX (tried and failed), and probably also Windows (haven't tried there). Before committing replacing TF with pygrain it would be important to make sure that those platforms are supported (just to say that it might take a bit before we merge these PRs unfortunately)

Well, replacing TensorFlow wasn't expected to be a walk in the park anyway 😃. But we've come a long way and I see that the people at pygrain are working daily on it.


Extend existing CyHy service capabilities to support 24k users

Summary
We have been tasked with the objective to scale the Cyber Hygiene program to support 6,000 customers per service. This would be a total of 24,000 customers, given CyHy is currently made up of four services:

Vulnerability Scanning (VS)
Phishing Campaign Assessments (PCA)
Web Application Scanning (WAS)
Posture and Exposure (P&E)

Motivation and context
The MVP includes prioritizing setting up a new public facing application that can be accessed by our customers to request services, modify the scope of their services, and retrieve information like their reports. It also includes setting up a new database to store the CyHy stakeholders’ information as well as data that is generated from the multiple CyHy services in a centralized location. It also includes integration between that data system, the consumer facing applications, and the operational engines (scanners, report generation scripts, etc.) The initial timeline our leadership has provided to achieve this goal is end of June 2023. We currently expect this timeline to shift to the right slightly (est. Sept 2023), given there are other priority tasks also on the table.
Implementation notes
TBD
Acceptance criteria
Note: this is written as applicable to the CyHy engine scope. This list can be expanded upon, including subsequent tickets, when more information is available to further define the functional requirements.

[ ] Send and retrieve data to the long-term data storage system via API.
[ ] Accept modifications and log events when updated data is received due to service request scope changes entered via the consumer facing application.
[ ] Send data that is collected as the output of vulnerability scanning related activities to the long-term data storage system for user access via the consumer facing application.
[ ] Include plug ins for additional service scanning capabilities via the CyHy engine (tbd).
[ ] Integrate with long-term data storage system and consumer facing application in support of the MVP requirements.

MVP requirements list
Note: this scope is applicable to the larger CyHy 6k objective and portions of these requests may be implemented by teams outside of the development teams using GitHub.

Access for stakeholders to view/download their CyHy reports of any file type/size for all CyHy services.
Reports to be made available to existing stakeholders when they are ready, in alignment with service report cadences, which is as often as daily.
Automatic notifications to be emailed to existing stakeholders when a new document (either a report or ad-hoc alert) has been added to the portal so that they know they have a new item to review.
Fully automate the stakeholder enrollment process in a way that sets up new stakeholders for the services they select. Creates their stakeholder profile in the appropriate service database.
Self-service capability for existing stakeholders to make changes to their CyHy service basic info (e.g. IP addresses, domains, phishing targets, URLs, POCs, asset tags, etc.) for all CyHy services.
In-portal notifications for stakeholders when submitting unacceptable self-service changes for any of CyHy service (i.e. user input validation).
Notify CyHy service teams when; 1. New stakeholder profiles are set up and ready for review, so they can do validation prior to starting the subscription scanning/phishing. 2. Existing stakeholders make/request unacceptable changes/edits/updates to investigate and follow up with the stakeholder.
Procure enough SW licenses to support increased capacity.
The environment should have the ability to host a database of phishing templates (with Python libraries) for Con-PCA and Li-PCA.

It is currently unclear how the ASM strategy impacts this initiative. Closing the ticket until more information on priorities, team plans, and impact is available.


Fix project build issues [closes #504]

See #504.

I have read the CLA Document and I hereby sign the CLA

recheck

BTW, note that both the issues fixed in this pull request come from Dependabot changes being automerged even though the builds failed. How can we prevent this in future?

Ah, it appears that our current Dependabot workflow approves all patch and minor updates, regardless of the build status. We need to fix that so Dependabot doesn't break the build.

This is superseded by #577.


feat: added exmple .env

added example .env file

Hello, I suppose this is related to #7.
LOCALAPPDATA, PROGRAMFILES, PROGRAMFILES(X86) always are already defined variables in Windows, so there is no need to specify a .env.
Tell me if I am wrong.


test for complicated batch structure

test for complicated batch structure

Hello @williamFalcon! Thanks for opening this PR.

In the file tests/trainer/logging/test_train_loop_logging_1_0.py:

Line 435:51: E241 multiple spaces after ','

Do see the Hitchhiker's guide to code style