Consider CoreFuture/Future split

We've talked a couple of times before about splitting the Future trait into a CoreFuture trait that covers all the required methods, and Future that is all defaulted methods.
Such a split could have a couple of benefits:

The docs for each trait could be more focused on that "level" of work; that means, in particular, that docs for Future would be strictly oriented around combinator use, without delving into details about polling/task mechanics. That might make it easier to get a handle on the library.

Potentially CoreFuture can use associated types for Item and Error, while Future uses type parameters. (There's currently a compiler bug blocking this).

OTOH, this would make life worse for people who want to use the lower-level APIs. A prelude might help.

I am personally hesitant to make splits that are primarily for documentation reasons as, IMO this could be handled at the doc layer.
If there is a good API reason to make the split, than sure, but i'd rather hear about the API justification for it than to do it for docs.

I'm also personally quite hesitant to do this. I have yet to be sold on type parameters (I thought we put that to rest already?) and I wouldn't want to take such a core concept and split it (e.g. would we do this for iterators?)

I'm going to close this out; I don't see us taking this step.


question about codeblocks and codeblock rendering

roadmap says:

React-based Views: Javascript swaps to using React for views, which eliminates the "flickering" during re-renders, and also allows for access to Datacore visual components.

does this mean jsx syntax will be supported in datacore-js codeblocks? if not, should there be helper functions implemented to render out views from pure js code in api/local-api.ts ?

So I had an earlier pass which supported full JSX. The problem is that this requires including the entirety of babel as a dependency in order to transpile JSX -> plain JS, which increases the size of the Datacore binary by 12x (~400kb -> 6mb). That was... not good.
It's possible to use React without touching JSX at all which is what I am currently aiming for... maybe using babel can be opt-in via an addon plugin.

how will a query string "translate" to a view (i.e., table, card, etc)?
i remember that in Dataview there were functions like createTaskView, createTableView, etc. to return a jsx component to pass to a MarkdownPostProcessorContext to be rendered. however, i've noticed that the view components require more than just a simple query AST to be rendered:
https://github.com/blacksmithgu/datacore/blob/62a14ba053d157226ae758d96a7a17739b90f1c4/src/ui/table.tsx#L14-L44
what am i supposed to do with this interface? i've been trying to figure out how to create the components to be rendered in codeblocks (for testing/tinkering purposes)

The translation later isn't present yet. Datacore is going to use plain YAML for it's codeblocks (instead of a query language), so the flow will be something like this. You start with a codeblock describing the view:
table:
  source: "@page and #game and rating > 7"
  columns: ["$link", "rating"]
  initial-sort: rating DESC

This is parsed and converted into the TableProps and then rendered as a react component.
I'm planning on adding some initial logic for this, this week to demonstrate.

So I had an earlier pass which supported full JSX. The problem is that this requires including the entirety of babel as a dependency in order to transpile JSX -> plain JS, which increases the size of the Datacore binary by 12x (~400kb -> 6mb). That was... not good.

An alternative to babel is sucrase. It's smaller and faster than babel because what it aims to do is a bit simpler. It's not trying to convert every modern JavaScript feature to something that decade-old browsers can understand. I've been using it to strip TypeScript type annotations and convert ES Module syntax to CommonJS syntax for my Dataview scripts.

Very interesting! I will give this library a try instead.

I tried sucrase and the binary bundled with everything installed and not minified is about 1.4mb (instead of 5.4mb). That is still a bit meaty, but I think it's acceptable enough since being able to natively use TypeScript and JSX is great for coding UX!

I'm just thinking loud:
I wonder if size could be reduced even further by using a AST builder that's implemented in wasm. (considering wasm is actually supported in obsidian)
I'll look into that..

I haven't personally bundled things using WASM but if it's possible to bundle sucrase as a compressed WASM library that seems appealing.

apparently self-hosted-livesync is bundling a wasm module for fast file hashing.

Closing this since we've adopted sucrase for JSX/TSX support.


Add support for linux/riscv64

Allows to run bin/syz-extract -build -os=linux -arch=riscv64 to generate sys/linux/*_riscv64.const files.

I will look into adding g++-riscv64-linux-gnu to the syz-env docker image used on CI. Does the debian:buster stock package expected to work already?

Sorry, didn't run make presubmit locally. Will do so now and address issues before marking ready for review.

We update all *.const files periodically, this can be done by any contributor who needs it. So we either need to (1) make extract for risc-v work when run as part make extract on stock linux-next, or (2) disable it for now, or provide some other workaround.

Please add g++-riscv64-linux-gnu to make install_prerequisites target.
The kvm headers can be faked here:
https://github.com/google/syzkaller/blob/master/sys/syz-extract/linux.go#L54-L69
(this can effectively fake any header with any contents, and if you look at the history we faked some kvm headers for arm, so you may take that as a starting point).
With these changes maybe it will even work on linux-next?

I will look into adding g++-riscv64-linux-gnu to the syz-env docker image used on CI. Does the debian:buster stock package expected to work already?

Haven't used the one from debian:buster so far, but the stock package from ubuntu:20.04 works fine (we e.g. use it to generate linux/riscv64 consts in golang.org/x/sys/unix)

We update all *.const files periodically, this can be done by any contributor who needs it. So we either need to (1) make extract for risc-v work when run as part make extract on stock linux-next, or (2) disable it for now, or provide some other workaround.
1. Please add `g++-riscv64-linux-gnu` to make install_prerequisites target.

2. The kvm headers can be faked here:
   https://github.com/google/syzkaller/blob/master/sys/syz-extract/linux.go#L54-L69
   (this can effectively fake any header with any contents, and if you look at the history we faked some kvm headers for arm, so you may take that as a starting point).
   With these changes maybe it will even work on linux-next?

Indeed, thanks. I think this approach should work. FWIW, I also needed to exclude it in sys-szygen similar to how it is done for arm.

I've updated syz-env image with g++-riscv64-linux-gnu package and restarted CI testing, let's see...

Should be good to go now. Not sure though about the codecov/patch CI check failure?

Perfect! It's not that I did not look, I just don't have any comments.
Did you try to run it already? I think we also need few bits in vm/qemu/qemu.go.
What do people use for the image for riscv? What's the simplest way to download/build an image?

Perfect! It's not that I did not look, I just don't have any comments.

Thanks!

Did you try to run it already? I think we also need few bits in vm/qemu/qemu.go.
What do people use for the image for riscv? What's the simplest way to download/build an image?

I didn't fully manage to run it yet and just noticed the missing vm/qemu bits. I will send a follow-up PR once I got it working. So far I've been using a manually built image but will try to get a Debian image working for further experiments.

Debian may boot too slowly in qemu tcg for fuzzing. So something like buildroot may be better.
If you do it, please leave some references re buildroot/kernel config required in a doc, similar to:
docs/linux/setup_linux-host_qemu-vm_arm-kernel.md

Ah, good point. buildroot sounds like a good option as well. Will make sure to leave some notes in a doc once I got it working.


Fix; typo in authentication.py

Fixed typo in authentication.py which resulted in a 500 error when passing a non existing token

Coverage remained the same at 100.0% when pulling 0b3b5add16492174efb8c148d0b7df4b20fb1fe2 on karuso:master into 126252b69825777fb681668d65b9a4afb0b39c66 on JamesRitchie:master.

Coverage remained the same at 100.0% when pulling feff74163a4e4fd6110c0ab6804d74d166cadb7e on karuso:master into 126252b69825777fb681668d65b9a4afb0b39c66 on JamesRitchie:master.

Coverage remained the same at 100.0% when pulling 42a4a925e56a367d88dd0bb32cc25a6be2ad7e62 on karuso:master into 126252b69825777fb681668d65b9a4afb0b39c66 on JamesRitchie:master.

I just had the same problem here.
@JamesRitchie what do you think about @karuso 's PR? It sounds good for me.

Same problem and it's a critical one, please merge the PR.

Please merge, it is a critical bug.

Fixed with #12


AnimationNodeStateMachine missing travel function?

Hello, I have KinematicBody2D node that has child node AnimationTree. Tree Root for AnimationTree is set to AnimationNodeStateMachine. KinematicBody2D has attached script (part of _physics_process):

     // Access to AnimationTree node - working i can "manually" run animation
    let animation_tree = owner.get_node("AnimationTree").expect("Node Should Exist");
    let animation_tree = unsafe { animation_tree.assume_safe() };
    let animation_tree = animation_tree.cast::<AnimationTree>().expect("Node should cast to AnimationTree");

    // Playback control for AnimationNodeStateMachine.
    let animation_state = animation_tree.get("parameters/playback");

  // Problematic part, should switch animation
    animation_state.travel("Run");

I'm getting error:

no method named travel found for struct gdnative::prelude::Variant in the current scope
method not found in gdnative::prelude::Variantrustc(E0599)
player.rs(68, 29): method not found in gdnative::prelude::Variant

is travel function implemented? I searched in source but i found only 1 mention of it in /gdnative-bindings/api.json
I'm using gdnative 0.9.0-preview.0
https://docs.rs/gdnative/0.9.0-preview.0/gdnative/api/struct.AnimationNodeStateMachinePlayback.html
BTW is there a way to move all that let ... to _ready function and still using it in other loops? I have tried to move it to struct but no luck :(

It's literally there in the link you've given: https://docs.rs/gdnative/0.9.0-preview.0/gdnative/api/struct.AnimationNodeStateMachinePlayback.html?search=#method.travel

Yea i saw that it's there but i wrote because compiler says that can't find method.
Are You sure about returning Variant?
let animation_state = animation_tree.get("parameters/playback");
godot_print!("animation_state: {:?}", animation_state);
gives:
animation_state: Object([AnimationNodeStateMachinePlayback:1227])
When i try cast:
let animation_state= animation_state.cast::<AnimationNodeStateMachinePlayback>()
        .expect("Node should cast to AnimationNodeStateMachinePlayback");
it give me :

      error[E0599]: no method named `cast` found for struct `gdnative::prelude::Variant` in the current scope
       --> src/player.rs:55:46
        let animation_state= animation_state.cast::<AnimationNodeStateMachinePlayback>()
                                              ^^^^ method not found in `gdnative::prelude::Variant`

I don't know what I'm doing wrong, I just started learning Rust.

Rust is a statically-typed language. Object::get returns Variant because there is no way to know the type of a property named by an arbitrary string at compile time. To convert from Variant to a GodotObject type, you may use Variant::try_to_object.
let animation_state = animation_state.try_to_object::<AnimationNodeStateMachinePlayback>().expect("cast should be valid");

Thank You very much for helping me, but it's still don't work :(

    let animation_state = animation_state.try_to_object::<AnimationNodeStateMachinePlayback>().expect("cast should be valid");
    godot_print!("animation_state: {:?}", animation_state);

prints output:
animation_state: AnimationNodeStateMachinePlayback(0x6f23e60)
but when i add:
animation_state.travel("Run");
I get compile error for travel:
method not found in gdnative::Ref<gdnative::gdnative_bindings::AnimationNodeStateMachinePlayback>

That's because Refs are Shared by default, and Shared Refs cannot be used directly. Instead you'll have to call assume_safe to obtain a safe view to the object before you can call its methods.
Please make sure you read the type-level documentation on Ref: https://docs.rs/gdnative/0.9.0-preview.0/gdnative/struct.Ref.html

Thank You very much! It's working now :D here is code if somebody will need help accessing and controlling node:

    // Access to AnimationTree node
    let animation_tree = owner.get_node("AnimationTree").expect("Node Should Exist");
    let animation_tree = unsafe { animation_tree.assume_safe() };
    let animation_tree = animation_tree
        .cast::<AnimationTree>()
        .expect("Node should cast to AnimationTree");

    // Access to AnimationNodeStateMachinePlayback inside AnimationTree node
    let animation_state = animation_tree.get("parameters/playback");
    let animation_state = animation_state
        .try_to_object::<AnimationNodeStateMachinePlayback>()
        .expect("cast should be valid");
    let animation_state = unsafe { animation_state.assume_safe() };

    // Controlling AnimationNodeStateMachinePlayback
     animation_state.travel("Control parameter");


🌱 Include all gomods in different directories for Dependabot

Dependabot is currently not updating gomodules in api/ and hack/tools dir. This PR updates it.

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

/lgtm

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

/hold
Why are we not including test as well?

Why are we not including test as well?

It doesn't have any go.mod so it would not make sense

Why are we not including test as well?

It doesn't have any go.mod so it would not make sense

Duh... it is only for fuzzing stuff in IPAM. Lol me.
/unhold


[T2A2][T14-A1] Advay Pal

Ready for review.

in general, pay more attention to coding standards violation.
some useful ones include checking how conditional statements are written, naming conventions etc.,


Increasing duration of pause between sentences?

Hi
I was wondering whether there is a way of increasing the length of the pause generated by the pre-trained model between sentences. Obviously this could be done in post-production, but is there a means of extending this pause when generating the audio?

Not trivial without training a new model. Did you try increasing the number of spaces between words?

Hi @rafaelvalle yes, I tried this but it didn't work. Spacing doesn't seem to make any difference.
However, adding an ellipsis increases the length of the pause between sentences from 200ms to 420ms, e.g 'The cat sat on the mat. And then got up'/'The cat sat on the mat...and then got up'

Yes, ellipsis could also work!


Build wheels for macOS AArch64

Extend our wheel automation to produce wheels for macOS AArch64 (Apple Silicon).
If we want to do this in GitHub Actions, we might need to wait until an appropriate runner is added: https://github.com/actions/virtual-environments/issues/2187.

my vote goes on waiting for github actions

Yes, I think that's pretty much a prerequisite in either case. (Unless anyone wants to connect some Apple Silicon via a custom GH Actions worker.)

There seem to be a wheel version for arm osx. see https://pypi.org/project/orjson/#files that published them as universal2 wheels
No clue how to create them yet

It is apparently possible to cross-compile [1] from an x86 Mac, but that also sounds risky in terms of distributing broken builds, or maybe there is a way to emulate?

See, e.g., https://github.com/conda-forge/falcon-feedstock/commit/13e1085d2ba0bb29551ea7ba78a229a22384b075

There is now a package maintained by the pypi people that should handle all that for you. it's called cibuildwheel

Yeah, but is it possible to also run pytest etc in some emulated environment?

it seems so, see here https://github.com/pypa/cibuildwheel#options

Testing 	CIBW_TEST_COMMAND 	Execute a shell command to test each built wheel

Hm, I may be wrong, but it seems that you're responsible for setting up the Docker host infrastructure or emulator yourself in order to be able to run the said container.

Update: GitHub Actions: Self-hosted runners now support Apple M1 hardware.

It seems that we somehow built some of them without knowing, since Actions now support these.
In any case, both Apple archs will be formalized when moving to Cibuildwheel: #2259.


Problem adding another param to the action

Hello,
I've got a very weird issue. I have an action that works:
export function fetchMetadades() {
  const url = `${API_ROOT_URL}/${API_METADADES}`;
  const request = axios.get(url);

  return {
    type: FETCH_METADADES,
    payload: request
  };
}

But if I add another parameter, for instance:
export function fetchMetadades() {
  const url = `${API_ROOT_URL}/${API_METADADES}`;
  const request = axios.get(url);

  return {
    type: FETCH_METADADES,
    payload: request,
    newParam: "withANewValue"
  };
}

It doesn't work :fearful: What I'm doing wrong?

Sorry. I applied the the solution of https://github.com/acdlite/redux-promise/issues/28 and it worked perfectly.


make search_status() a vim function to get search match index

Is your feature request related something that is currently hard to do? Please describe.
https://github.com/vim/vim/issues/453 introduces the possibility to print match index as a message.
However, I'd like to use it directly in my statusline in order to make it easier to read when editing in a split buffer located at the top of the screen.
Describe the solution you'd like
Would it be possible to make search_status() a vim function returning [idx,total]?

There is an item in the todo list:

Patch to provide search stats in a variable, so that it can be used in the
statusline. (Fujiwara Takuya, #4446)

And the PR #4446 provides a searchcount() function which can be used to access this information.

Yes, I proposed the PR.
Now I found it has conflicted with current master. I will fix it.
But @brammool seems currently working on vim9 script a lot and other new features has not been included recently.
It is a tough work, so I'm just waiting and hoping the stable release ... ;)

closing for #4446


Blank page

I have Ionic app which so far i made android app and app is working just fine in fact it's released to google store as well, so everything is really fine with my app until I added Cordova Windows Platform in order to have another version of my app and now when I open my project on VS17 and run the app this is what I get:

Blank window.
Info
OS: Windows 10
IDE: VS17
Installed Windows 10  SDK
Installed MSbuild
Installed UWP

Note: if I run command ionic cordova build windows I get:

ENV var MSBUILDDIR is set C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\15.0\Bin
rm: could not remove directory (code ENOTEMPTY): C:\laragon\www\ionic\xxxx\platforms\windows\build/windows

rm: could not remove directory (code ENOTEMPTY): C:\laragon\www\ionic\xxxx\platforms\windows\build/windows
rm: could not remove directory (code ENOTEMPTY): C:\laragon\www\ionic\xxxx\platforms\windows\build

Building project: C:\laragon\www\ionic\xxxx\platforms\windows\CordovaApp.Windows10.jsproj
        Configuration : debug
        Platform      : anycpu
        Buildflags    : /p:AppxBundle=Never
        MSBuildTools  : C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\15.0\Bin
buildProject spawn: C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\15.0\Bin\msbuild [ 'C:\\laragon\\www\\ionic\\xxxx\\platforms\\windows\\CordovaApp.Windows10.jsproj',
  '/clp:NoSummary;NoItemAndPropertyList;Verbosity=minimal',
  '/nologo',
  '/p:Configuration=debug',
  '/p:Platform=anycpu',
  '/p:AppxBundle=Never' ] { stdio: 'inherit' }
  prebuild.js: Patching platform `10`
  - Injected `base.js` reference to `/www/index.html`
  - Removing /( *)(<script\s+(?:type="text\/javascript"\s+)?src="\/\/Microsoft.WinJS.2.0\/js\/base.js">\s*<\/script>)(\s*)/ from /www/index.html
  - Removing /( *)(<script\s+(?:type="text\/javascript"\s+)?src="\/\/Microsoft.Phone.WinJS.2.1\/js\/base.js">\s*<\/script>)(\s*)/ from /www/index.html
C:\laragon\www\ionic\xxxx\platforms\windows\CordovaApp.Windows10.jsproj(86,9): error : The following component requires .NET Native compilation which is not available when targeting 'Windows10' and 'AnyCPU'. Consider changing the targeted processor architecture to one of the following: 'x86, x64, ARM' (if you are using command line this could be done by adding '--archs' parameter, for example: 'cordova build windows --archs=x64'). C:\laragon\www\ionic\xxxx\platforms\windows\plugins\onesignal-cordova-plugin\OneSignalSDK_WP_WNS_WRTC.winmdNo valid MSBuild was detected for the selected target: Error: C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\15.0\Bin\msbuild: Command failed with exit code 1

And If I use VS17 I get blank screen.
Any idea what might be wrong?

Does it work for a new project created with cordova create?
Did you remote debug your app to see if there are any Javascript errors in the console?

@janpio
1- cordova create as I'm working on ionic app i have no idea about this command! :)
2- When I opened my app with VS17 there was no error in there but i didn't try to open in in browser :)
BUT
I've made a total new app with VS17 (100% cordova app) and when I tried to run it i got this:
The targeted toolset could not be found on disk. Please go to Visual Studio Setup and run a repair to reinstall it.

So based on that I am updating my VS now not sure if it will work or no or even if that's the issue, so please feel free to share your thoughts in the meantime.

1- cordova create as I'm working on ionic app i have no idea about this command! :)

Then please use it now to make sure your local system can create a working Cordova Windows app: cordova create, cd ..., cordova platform add windows, cordova run windows.

I've made a total new app with VS17 (100% cordova app) and when I tried to run it i got this:

You can only create pure Cordova apps with the Cordova CLI (as described above). Everything else uses software that is not directly supported by Apache Cordova.

Then please use it now to make sure your local system can create a working Cordova Windows app: cordova create, cd ..., cordova platform add windows, cordova run windows.

C:\Users\xxxxx\Desktop\New
λ cordova create
Directory not specified. See `cordova help`.

Yes, you just made sure that Cordova can actually build a successful working app on your system - so the problem is with your existing app somehow.
You can use https://www.microsoft.com/en-us/p/microsoft-edge-devtools-preview/9mzbfrmz0mnj?activetab=pivot:overviewtab to remote debug the running app and look at the console of the webview, maybe this can tell you what is going wrong there. (Super difficult to help here without having the actual app.)


Null vals work -- simple update in app.py creation code to account for null magnitude values

Description
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Change Status

[ ] Complete, tested, ready to review and merge
[x] Complete, but not tested (may need new tests)
[ ] Incomplete/work-in-progress, PR is for discussion/feedback

How Has This Been Tested?

[ ] Test A
[ ] Test B

Checklist

[x] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] My code has been reviewed by at least one peer
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] There are no merge conflicts

Excellent, thanks for testing it. From here we'll focus on how to refactor the code to make it cleaner in the future, hopefully!


Features/rm feather

Related to #112. unified to Vaex for large files.

not only the trans but also the states file is saved as the Vaex format.
To do so, changed the input of exomolapi.pickup_gE to numpy array of the state from pandas.

Do you have a read/write performance benchmark of Feather vs Hdf5?

No, but @ykawashima should know.

Hi @erwanp. I found that while the cpu time is almost the same or even a little shorter for Feather when the file size is small, for large-size files, time for reading the data from Hdf5 is much shorter compared to Feather. I am sorry that this is just my rough memo when I did the comparison for the Exomol transition files, but here it is. (I did the selection of the transitions with Einstein A coefficient larger than 1e-4 after reading the data from Feather or Hdf5. Also, I am sorry that at that time, I did not know the way to directly convert the data from vaex to numpy while implementing the selection so I used the pandas in between them.)


JavaScript (and sound) will not load in Safari

See https://stackoverflow.com/questions/64406194/content-security-policy-hash-not-recognized-by-safari-13-1-2
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy/script-src
Safari does not support CSP 3.0 hash attribute.
Thank you for this wonderful site!

呢個問題我哋改唔到。呢個網站係用Hugo 再加 docsy模板生成嘅，你可唔可以去佢哋嗰度開 issue？
另外我喺 iOS 16.0 嘅 Safari 上面試咗下，啲錄音都可以正常播放。


Symbol not found errors when using the rerun-built arrow-cpp

Error
A user reported the following error when trying to run one of the examples:
./example_minimal
dyld[24822]: Symbol not found: __ZN5arrow11dense_unionENSt3__16vectorINS0_10shared_ptrINS_5FieldEEENS0_9allocatorIS4_EEEENS1_IaNS5_IaEEEE

Known workaround
It appears we can work around this issue by specifying
-DRERUN_ARROW_LINK_SHARED=off

Speculation
User may have a system instrall of arrow-cpp that's getting picked up at runtime instead of the version we are building.

I've confirmed this can happen on Linux if you happen to have a system install of arrow-cpp that matches the version we are compiling.

This has now been mitigated. We now link with arrow statically by default:

https://github.com/rerun-io/rerun/pull/4101


PP-8716 Web performance - add hash to image assets in Nunjucks file

Add the 'staticify.getVersionedPath' function to app.locals

This makes the function available in Nunjuks templates.
For production - it will return hashed versions of image assets

E.g. Change image.png to image.d5e5c73.png

Update Nunjuks templates

Update image tags to use getVersionedPath

E.g.  to

WHAT

Add the staticify.getVersionedPath to  Express app.locals.  So it is available in Nunjucks templates.
Use the Staticify library to do the following:
For Production - generate Hashed image paths using the staticify.getVersionedPath

HOW

Go to the Charge pages and check the inline images - you should see the assets appearing Hashed.

Closed this - will need to think more about this.


druid.javascript.enabled=true did not work

I had set
druid.javascript.enabled=true
at the last of file
/home/ec2-user/druid-0.12.0/conf/druid/_common/common.runtime.properties
and then I started zk and druid service
but when I submit a demo queryjob like
$ curl -L -H'Content-Type: application/json' -XPOST --data-binary @quickstart/myquery.json http://localhost:8082/druid/v2/?pretty

{
    "aggregations": [
        {
            "fieldNames": [
                "delta",
                "added"
            ],
            "fnAggregate": "function(current, delta, added) { return current + delta + added; }",
            "fnCombine": "function(partialA, partialB) { return partialA + partialB; }",
            "fnReset": "function() { return 0; }",
            "name": "result",
            "type": "javascript"
        }
    ],
    "dataSource": "wikiticker",
    "dimensions": [
        "cityName"
    ],
    "granularity": "hour",
    "intervals": "2015-09-12T00:00:00.000Z/2015-09-12T10:00:00.000Z",
    "queryType": "groupBy"
}

I got an exaption:
{
  "error" : "Unknown exception",
  "errorMessage" : "JavaScript is disabled",
  "errorClass" : "java.lang.IllegalStateException",
  "host" : "ip-172-31-23-148.cn-north-1.compute.internal:8083"
}

the answer of this question is
it has two conf folders: 'conf' and 'conf-quickstart'


Type-check when serializing protocol buffer objects

Explicit type-checks are generally only warranted in Python when the effects of a type defect only manifest far from the point of the mistake. Proto serialization is such a case: if one passes a message of the wrong type to be serialized and sent across the wire, it serializes just fine, and it's only far across the network at the other side of the RPC that on deserialization the mistake is detected.

Good news! We get this functionality for free from protobuf because our serializations are of the form
serialized_message = <message class>.SerializeToString(<message>)

and not
serialized_message = <message>.SerializeToString()

. @haberman, is there anything incorrect about this assessment? I checked and double-checked that protobuf is doing this type-checking; is there a formal statement of support anywhere that it will continue to do so and that calling <message class>.SerializeToString(<message object>) is the supported way to achieve a type-checked serialization?


vendoring @types/node

The Electron typescript definitions need to include some stuff from node like EventEmitter.
It was suggested during our recent mini-summit that we should just npm install @types/node and call it a day, but I'm thinking it would be nicer if instead we bundle the node definitions right into the generated electron.d.ts file. That way when we publish electron.d.ts as an Electron release artifact it will be complete and self-contained.
This approach would make things easier (and safer) in a number of ways:

pulling the new electron.d.ts file into electron-prebuilt when a new Electron is published will be easier than making it prebuilt's responsibility to figure out which @types/node to be using.
same goes for pushing the new electron.d.ts to DT/DT. No extra footwork, just a single file.
no risk of dependency installation failures when people npm install electron
no direct reliance on npm scoped packages

To make sure we're bundling the right version of node, we can line up electron<->node version numbers using this file: https://atom.io/download/electron/index.json
{
  "version": "1.6.4",
  "date": "2017-03-22",
  "node": "7.4.0",
  "v8": "5.6.326.50",
  "uv": "1.10.1",
  "zlib": "1.2.8",
  "openssl": "1.0.2j",
  "modules": "53",
  "chrome": "56.0.2924.87"
}

cc @miniak @felixrieseberg @MarshallOfSound does this sound reasonable?

I'm okay with this, if it makes things easier. I'm usually against "let's copy dependencies in" approaches, but I think the downside is small enough that you shouldn't have to sweat it :wink:

Normally I would be against this kind of thing, but in this case, I think it makes sense.  Technically the user isn't using Electron and Node.JS.  They are using Electron which wraps / includes Node.JS so it semantically makes sense for our typings to include the Node.JS typings 👍

A change of heart: https://github.com/electron-userland/electron-prebuilt/pull/249

We ended up shipping with @types/node bundled as a dependency of electron-prebuilt: https://github.com/electron-userland/electron-prebuilt/pull/249


OAI not added to S3 bucket policy in cross-region deployments

When deploying medplum outside of us-east-1...

We create one CDK stack in your primary region with the majority of AWS resource
We create another CDK stack in us-east-1 for "global" resources such as CloudFront distributions
We need to update the S3 bucket policy to grant access to CloudFront....

I have experimented with a bunch of different ways to do this, and it's all gross.
It is difficult enough to share the OAI across region boundaries.  That ends up being a solveable problem using the experimental crossRegionReferences feature.
But the real kicker is that there is no mechanism in CDK or CloudFormation to update an S3 bucket policy outside of the "stack" that created it.  So all attempts at using a 3rd stack failed.
There is still one unexplored option, which should work, but I am disgusted by it that I don't really want to do it out of principle:

Add the OAI to a Parameter Store value (yuck)
Use AWS CDK "CustomResource" (yuck)
Custom resource includes a Lambda (yuck)
Lambda reads the OAI and adds it to the S3 bucket policy manually using the AWS SDK (yuck)
That lambda will re-run on every diff and deploy forever thereafter, even if there are not any related resource changes

Instead, we're considering a separate "touch up" step using the Medplum CLI.
After the first CDK deploy completes, you should be able to run medplum aws update-bucket-policies.  Our existing code and infra will have all of the necessary information to directly and surgically modify the bucket policy directly.  It's a one-time step, and only required when deploying outside of us-east-1.

https://github.com/medplum/medplum/pull/2924


R: Incorrect results from rolling window summation

I would imagine that this affects duckdb as a whole, but here is an example in R of computing a size 2 rolling summation of the current row + 1 row before it. I've compared with SQLite for the correct results:
library(duckdb)
library(RSQLite)
library(DBI)

con_sqlite <- dbConnect(SQLite())
con_duck <- dbConnect(duckdb())

dbWriteTable(con_sqlite, "cars", mtcars)
dbWriteTable(con_duck, "cars", mtcars)

query <- "
  SELECT
    mpg,
    SUM(mpg) OVER (ROWS BETWEEN 1 PRECEDING AND CURRENT ROW) AS mpg_roll
  FROM
    cars
"

head(dbGetQuery(con_sqlite, query), n = 10)
#>     mpg mpg_roll
#> 1  21.0     21.0
#> 2  21.0     42.0
#> 3  22.8     43.8
#> 4  21.4     44.2
#> 5  18.7     40.1
#> 6  18.1     36.8
#> 7  14.3     32.4
#> 8  24.4     38.7
#> 9  22.8     47.2
#> 10 19.2     42.0

head(dbGetQuery(con_duck, query), n = 10)
#>     mpg mpg_roll
#> 1  21.0    642.9
#> 2  21.0    642.9
#> 3  22.8    621.9
#> 4  21.4    600.9
#> 5  18.7    578.1
#> 6  18.1    556.7
#> 7  14.3    538.0
#> 8  24.4    519.9
#> 9  22.8    505.6
#> 10 19.2    481.2

Created on 2020-09-28 by the reprex package (v<IP_ADDRESS>01)

Possibly related to missing order by clause?  Without order by, correct interpretation may be that multiple preceding rows are tied/included.  TBH, not sure if there is constant handling here, with at least some dbms issuing a syntax error.
Behavior appears correct with order by clause:
query="""
SELECT
mpg,
SUM(mpg) OVER (order by model ROWS BETWEEN 1 PRECEDING AND CURRENT ROW  ) AS mpg_roll
FROM
cars order by model
"""
print(cur.execute(query).fetchall())
(15.2, 15.2),
(10.4, 25.6),
(13.3, 23.7),
(14.7, 28.0),
(22.8, 37.5),
(15.5, 38.3),
(14.3, 29.8),
(19.7, 34.0),
(32.4, 52.1),
(27.3, 59.7),
(15.8, 43.1),
(30.4, 46.2),
(21.4, 51.8),
(18.7, 40.1),
(10.4, 29.1),
(30.4, 40.8),
(15.0, 45.4),
(21.0, 36.0),
(21.0, 42.0),
(22.8, 43.8),
(24.4, 47.2),
(19.2, 43.6),
(17.8, 37.0),
(16.4, 34.2),
(17.3, 33.7),
(15.2, 32.5),
(19.2, 34.4),
(26.0, 45.2),
(33.9, 59.9),
(21.5, 55.4),
(18.1, 39.6),
(21.4, 39.5)

Oh interesting. I probably would have expected the implicit row number to be used when order-by isn't specified here.
Nevertheless, I think there might still be some issues? Here is a similar example with a row number specified, again we just compute the rolling sum of the current value + 1 value before. Results seem to be incorrect at seemingly random locations
library(duckdb)
#> Warning: package 'duckdb' was built under R version 4.0.2
#> Loading required package: DBI
library(DBI)
library(data.table)

con_duck <- dbConnect(duckdb())

n_row <- 1e5L

df <- data.frame(
  x = seq_len(n_row) + 0,
  row_number = seq_len(n_row)
)

query <- "
  SELECT
    SUM(x) OVER (ORDER BY row_number ROWS BETWEEN 1 PRECEDING AND CURRENT ROW) AS x_roll
  FROM
    temp
"

duckdb_register(con_duck, "temp", df)

roll_duck <- dbGetQuery(con_duck, query)$x_roll
roll_dt <- frollsum(df$x, 2)

# frollsum() doesn't compute on partial windows so hack this to mimic duckdb behavior
roll_dt[[1]] <- df$x[[1]]

issues <- roll_duck != roll_dt

# quite a few differences
sum(issues)
#> [1] 6305

first_diff <- which(issues)[1]

df$roll_duck <- roll_duck
df$roll_dt <- roll_dt

# check out the rows around the first issue
df[first_diff + -5:5,]
#>       x row_number roll_duck roll_dt
#> 892 892        892      1783    1783
#> 893 893        893      1785    1785
#> 894 894        894      1787    1787
#> 895 895        895      1789    1789
#> 896 896        896      1791    1791
#> 897 897        897      1857    1793
#> 898 898        898      1923    1795
#> 899 899        899      1925    1797
#> 900 900        900      1927    1799
#> 901 901        901      1929    1801
#> 902 902        902      1931    1803

Created on 2020-09-28 by the reprex package (v<IP_ADDRESS>01)

Thanks for the report! I can confirm this is a bug, even with the ordering specified. The following SQL statements reproduces your results:
create table temp as select * from range(0, 10000) temp(x);
SELECT *,
       expected=x_roll
FROM
  (SELECT x,
          rowid,
          CASE WHEN x=0 THEN 0
          ELSE x*2-1
          END AS expected,
          SUM(x) OVER (ORDER BY rowid ROWS BETWEEN 1 PRECEDING AND CURRENT ROW) AS x_roll
   FROM temp) t1(x)
WHERE x BETWEEN 892 AND 902
ORDER BY x;

This gives the following results:
----------  ----------  ----------  ----------  ---------------
892         892         1783        1783        true
893         893         1785        1785        true
894         894         1787        1787        true
895         895         1789        1789        true
896         896         1791        1855        false
897         897         1793        1921        false
898         898         1795        1923        false
899         899         1797        1925        false
900         900         1799        1927        false
901         901         1801        1929        false
902         902         1803        1931        false

The case where no ORDER BY is specified is a bit more fuzzy indeed. This case is not as important as the results are not well defined (and many systems throw an error here). I do think the results you are seeing are a result of a bug as well (likely the same bug). Likely when we fix this bug the results will match the ones by SQLite.

Both issues should be fixed in #970. These were actually two separate problems. The first was caused by the transformer not correctly handling the ROWS BETWEEN... case, and instead parsing it as RANGE BETWEEN.... Because there was no ORDER BY supplied, the range is the entire result (everything is tied in order). This caused the first two rows to be the sum of all values, the third result to be the sum of all values minus the first, etc.
The second problem was caused by an intermediate chunk not being properly reset, which lead to a read-only part being written to in an edge case, which caused incorrect results.
Thanks again for the report!


Mapping ResourceRequirement using JS

The tool definition to mainly investigate and discuss https://github.com/umccr-illumina/ica_v2/issues/103 with Illumina

Sweet, looks good, will wait for the sync on https://github.com/umccr/cwl-ica/pull/163 to finish first and then approve

TODO

[ ] Wait for #163 and then update with main branch

@alexiswl - FYI, I have merged main into this branch.

@alexiswl - FYI, I have merged main into this branch.

Which commit are you referring to here?

TODO

[ ] Wait for https://github.com/umccr/cwl-ica/pull/167

Which commit are you referring to here?

Ah, I see you had already pulled main, and repeating that locally only pulled in those changes https://github.com/umccr/cwl-ica/pull/164/commits/f3b1b650af3f83030172fce497abfb12f8b4daaa

Re-running GH actions now


Create static JSON for about & service providers

For #32, create a hard-coded JSON that maps project types to about text and service providers list.

We discussed "Project Type" as something that only exists for the default Projects (at least for now).
For custom projects the user creates, what should show in that pane?

We discussed "Project Type" as something that only exists for the default Projects (at least for now).
For custom projects the user creates, what should show in that pane?

For custom projects, let's assume there is a project type called "custom" with a static About & Service Provider content.

For custom projects, let's assume there is a project type called "custom" with a static About & Service Provider content.


Conversion of Dicom Image to Base64  and Downloading of Dicom Images

please tell me how can i get image108Base64 encoder and decoder because i want to store images in my SQL Database so i can retrieve and store it into database if i have image in base64 formate.
So kindly guide me how to set image108Base64 for dicom image that you explain in your example by defining static set of image with image108Base64 formate.
In which format you are giving value to image108Base64 and image109Base64 variable
And if i have multiple images in my canvas that i am referring on my mouse scroll and i want to download all the images on single click at particular user define location  in dicom format only than what should i have to do.
Please do the needfull
Thanks in Advance
Vivek

Hi! I'm just interested on it, too.
I want to convert a .dcm file to base64, since I'm developing a javafx aplication and cornerstone (js) can't read local files.
I'd tried some normal image-to-base64 examples but none of them is converting .dcm properly.
I would be grateful if you can explain how to do this convertion with .dcm files, like you do in cornerstone examples.
Thanks in advance.

I also have the same question.

Hello @chafey , @vivek00712 , @FMCalisto ,@swederik
i also facing same problem , i tried some method but i cant get the output , i have some 16bit grayscale images and i convert as a base64 and i assigned that value in this "image108Base64" but its not work, i get some sparkle images like this http://prntscr.com/g31fb4 , what is procedure for "image108Base64" value , how can we create the value for this variable. please help us to fix this issues.

Did anyone solve this problem, I'm on the same boat. Thanks

Technically speaking, this isn't a great approach. I believe base64 encoding increases file sizes by 33%, you'd be bloating your DB, and you'd hit some speed/performance issues when encoding/decoding.
That being said, there shouldn't be any crazy technical hurdles to accomplishing this.

Controller encodes DICOM to base64, stores in DB
Controller grabs base64 representation of DICOM from DB, decodes, passes down original file

Unless I'm missing something (entirely possible), this should all work well enough with the cornerstoneWADOImageLoader. It doesn't care what happens on your server, so long as the endpoint it hits returns a DICOM file.
If you want to pass down the base64 encoded version, you'd likely need to modify the existing image loader to decode the image before using it. I don't think we support base64 encoded images as a type, but I may be mistaken.

@dannyrb Thanks for replying so quickly, I'm working on a angular 2 project and am trying to display a .dcm file using a component. The .dcm file is on a fileshare structure not on a DB. I was not able to find any recent example of a simple dicom image being displayed using angular 2/4 I was able to display an image by using the base64 code that was at this url https://rawgit.com/cornerstonejs/cornerstone/master/example/exampleImageIdLoader.js hence why I was looking for a way to maybe in node pass the file to a function that would convert to base64 so cornerstone could display it. I thought cornerstoneWADOImageLoader was very confusing and it looked like it was expecting the file to be fed from an URL. Do you know of anything or can you point me on the right direction? thank you

I have a rough, not maintained, Angular POC repo located here:
https://github.com/dannyrb/cornerstone-angular-poc
cornerstoneWADOImageLoader can be used to load DICOM images that can be accessed via a URL. If it's setup and configured correctly, you load your image by prefixing the URL when you call .loadImage
For Example:
var imageUrl = 'http://www.example.com/path/to/myFile.dcm'
var imageId = 'wadouri:' + imageUrl
cornerstone.loadAndCacheImage(imageId).then(function(image) {
...
}

The wadouri: prefix tells cornerstone which image loader to use. The cornerstoneWebImageLoader can load PNG/JPEG images, and looks for the https: and http: prefixes.

It looks like my POC may be a major version behind, but it should be easy to tweak it to work with latest. I believe it's only missing the changes that dropped jQuery support:
Setup: https://github.com/dannyrb/cornerstone-angular-poc/blob/master/src/app/cornerstone/cornerstone.component.ts#L1-L31
Loading a DICOM image: https://github.com/dannyrb/cornerstone-angular-poc/blob/master/src/app/cornerstone/cornerstone.component.ts#L1-L31
If you're worried about auth, you can put your images behind a protected route and then use an authorization header to give the image loader access

Overview of Image Loaders

You register an image loader that should be used when an imageId starts with a specific scheme. Here's the simplest example:

cornerstone.registerImageLoader('http', cornerstoneWebImageLoader.loadImage)
cornerstone.registerImageLoader('https', cornerstoneWebImageLoader.loadImage)

Where the scheme is really just a string, and the "imageLoader" is really any function that returns an image object in this format: example image object

So.. The imageId is whatever input the imageLoader needs to consistently and reliably return the same image object. For the CornerstoneWebImageLoader, it's often something as simple as:

https://my-example-website.com/imageId=some-unique-id-value
But again, anything URL that would return a JPEG or PNG image.
By default, the CornerstoneWADOImageLoader works in a similar way, only instead of prefixing URLs with https or http, the wadouri loader uses the following schemes

wadouri
dicomweb
dicomfile

While the wadors loader uses only the wadors scheme
Summary

An image loader is a function that returns an image object
You can register an image loader to be associated with a scheme like http or https
The scheme is used to tell Cornerstone which loader to use when you pass an imageId to loadImage

It may all feel like magic, but when you pull back the covers, it's actually really simple. Let me know if you need more guidance @rahulbhatia123

Could you help me with an example code for this? I am kinda lost at the image loader part

This was the example code given by the cornerstone library , I am trying to edit the code respectively , but the output is to no avail

Could you just give me an example code if you don't mind , I am not sure how to write the exact code for my image loader and the respective image id for that

Is .dcm file set of multiple images or a single image ?

@dannyrb  Hi Please share some sample how we can implement scroll for dicom images ?

@Im-Goutham if you have an unrelated question, please create a new topic.
I'm locking this. This topic seems to garner a lot of misc. comments/questions. If you're reading this and have any questions, please create a new topic with a descriptive title.


Support for wheels

@hhk7734 I think it would be very simple to support wheels, and would enable installing of this package in some ways that can't handled source distributions.  I've made a pull request with what I think the changes would be, what do you think? https://github.com/hhk7734/python3-gpiod/pull/33

Thank you so much!


Fix spelling error: "prevered" to "preserved"

Codecov Report

Merging #38 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #38   +/-   ##
=======================================
  Coverage   83.55%   83.55%
=======================================
  Files           6        6
  Lines         304      304
=======================================
  Hits          254      254
  Misses         50       50

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e01400...ad98e45. Read the comment docs.

great, thanks @Hydrotoast

:+1: Thanks @Hydrotoast !


Not working for TFVC

I receive the following error when using TFVC.

This only works for Git.  If you look at what the code is doing, it's running a git command in powershell to get the list of changed files.  It could theoretically be extended to work with TVFS by doing a TVFS pathway, but the code isn't currently there.

Hi @nickolas-heirbaut,
@AJH16  is correct. This extension was made using Git in TFS.
We don't use TFS anymore so I didn't bother looking into it.
It's open source, feel free to fork and make adjustment in order to support it :)


Socket Integration

Progress can be tracked via this Google Sheets Link:
Socket Integration Progress

Closed for later issues.


Gunicorn Alternative??

This appeared when I shutdown with Waitress:
2024-10-20T02:24:04.187+00:00 - [   DEBUG] - API Request - Get Valid Assets By Owner (verbose=true address=bc1q5jkphpsns0dnsmv6jde4uz34rmdgqzvdehu5lw)
2024-10-20T02:24:04.188+00:00 - [   DEBUG] - API Request - Get Balances By Addresses (verbose=true addresses=1DtU6ECcpubup7QbmG1sP89568jexucS2P limit=50)
2024-10-20T02:24:04.189+00:00 - [   DEBUG] - API Request - Get Mempool Events By Addresses (verbose=true addresses=bc1qrjhe5r2ekjy28p3dl50zuwc0rjjjthpyhdd5ee limit=1000 show_unconfirmed=true) - Response 200 - 5ms
2024-10-20T02:24:04.193+00:00 - [   DEBUG] - API Request - Get Valid Assets By Owner (verbose=true address=bc1q5jkphpsns0dnsmv6jde4uz34rmdgqzvdehu5lw) - Response 200 - 6ms
2024-10-20T02:24:04.208+00:00 - [   DEBUG] - API Request - Get Balances By Addresses (verbose=true addresses=1DtU6ECcpubup7QbmG1sP89568jexucS2P limit=50) - Response 200 - 20ms
2024-10-20T02:24:04.434+00:00 - [   DEBUG] - API Request - Get Events By Addresses (verbose=true addresses=bc1q9kcw8jhqlr64llkcww8dlpl77lcjkvrt3fnvau limit=1000 show_unconfirmed=true event_name=ENHANCED_SEND,ASSE
T_ISSUANCE,DISPENSE,OPEN_DISPENSER,REFILL_DISPENSER,RESET_ISSUANCE,ASSET_CREATION,DISPENSER_UPDATE,NEW_FAIRMINT,NEW_FAIRMINTER)
2024-10-20T02:24:04.437+00:00 - [   DEBUG] - API Request - Get Events By Addresses (verbose=true addresses=bc1q9kcw8jhqlr64llkcww8dlpl77lcjkvrt3fnvau limit=1000 show_unconfirmed=true event_name=ENHANCED_SEND,ASSE
T_ISSUANCE,DISPENSE,OPEN_DISPENSER,REFILL_DISPENSER,RESET_ISSUANCE,ASSET_CREATION,DISPENSER_UPDATE,NEW_FAIRMINT,NEW_FAIRMINTER) - Response 200 - 3ms
^C2024-10-20T02:24:05.329+00:00 - [ WARNING] - Keyboard interrupt!
2024-10-20T02:24:05.330+00:00 - [    INFO] - Stopping API Server...
2024-10-20T02:24:05.331+00:00 - [    INFO] - Stopping API Watcher...
2024-10-20T02:24:07.332+00:00 - [   ERROR] - API Server did not stop in time. Terminating...
2024-10-20T02:24:07.333+00:00 - [    INFO] - Stopping API Status Poller...
2024-10-20T02:24:07.558+00:00 - [    INFO] - Stopping API Server v1...
2024-10-20T02:24:08.206+00:00 - [   DEBUG] - Creating connection to `/home/adam_krellenstein/.local/share/counterparty/counterparty.db`...
/usr/lib/python3.11/multiprocessing/pool.py:345: RuntimeWarning: coroutine 'BlockchainWatcher.handle' was never awaited
  def _setup_queues(self):
RuntimeWarning: Enable tracemalloc to get the object allocation traceback
2024-10-20T02:24:08.217+00:00 - [    INFO] - Closing database connections...
2024-10-20T02:24:08.218+00:00 - [    INFO] - Stopping AddrIndexRs thread...
2024-10-20T02:24:08.218+00:00 - [    INFO] - Shutting down logging...
2024-10-20T02:24:08.219+00:00 - [   DEBUG] - Creating connection to `/home/adam_krellenstein/.local/share/counterparty/counterparty.api.db`...
ERROR:root:SQLITE_LOG: recovered 1 frames from WAL file /ramdisk/counterparty/counterparty.api.db-wal (283) SQLITE_NOTICE_RECOVER_WAL
2024-10-20T02:24:08.221+00:00 - [    INFO] - Shutdown complete.

See https://github.com/CounterpartyXCP/counterparty-core/issues/2494


[Feature Request] CSV Input/Export of clients/products/orders

https://github.com/boxbilling/boxbilling/issues/1057

We have the ability to export CSVs as of version 0.4.0.
An import feature doesn't sound very practical, especially in comparison to a proper migration wizard from other existing products which is already on our roadmap for FOSSBilling in the long-term. Closing

a note, csv import would be practical in the case of trying to migrate from different "non-standard products".
example case: a modified drupal, wouldn't make it (i suspect...) in a fossbilling migration wizard.. so another "manual" way to migrate data from there, would probably be very helpful/practical.
just 2c.

a note, csv import would be practical in the case of trying to migrate from different "non-standard products". example case: a modified drupal, wouldn't make it (i suspect...) in a fossbilling migration wizard.. so another "manual" way to migrate data from there, would probably be very helpful/practical.
just 2c.

I realize this is a rather late response, but:
Even then, I think it would be more useful for the migration wizard to accept CSV files & provide the functionality to match columns in that CSV to the associated parameter inside of FOSSBilling. That'll cover the use-case you've mentioned, be more flexible, and ensure we keep import / migration functionality separate from everything else & have it all in one place, which is good for organization of the application.


feat: Add env override capability for common configuration

closes #4448

If your build fails  due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:

[x] I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
[x] I am not introducing a new dependency (add notes below if you are)
[ ] I have added unit tests for the new feature or bug fix (if not, why?)
[x] I have fully tested (add details below) this the new feature or bug fix (if not, why?)
[ ] I have opened a PR for the related docs change (if not, why?)
TBD

Testing Instructions
Run non-secure EdgeX stack
Build core-common-config from this branch
Set the following

export ALL_SERVICES_WRITABLE_TELEMETRY_INTERVAL=50s
export APP_SERVICES_WRITABLE_TELEMETRY_METRICS_MESSAGESRECEIVED=true
export DEVICE_SERVICES_WRITABLE_TELEMETRY_METRICS_EVENTSSENT=true

run common config from command line

./core-common-config-bootstrapper -cp -cf configuration.yaml -o

verify consul has the appropriate overridden values
verify logs contain the following:
"Variables override of 'app-services/Writable/Telemetry/Metrics/MessagesReceived' by environment variable: APP_SERVICES_WRITABLE_TELEMETRY_METRICS_MESSAGESRECEIVED=true"
"Variables override of 'all-services/Writable/Telemetry/Interval' by environment variable: ALL_SERVICES_WRITABLE_TELEMETRY_INTERVAL=50s"
"Variables override of 'device-services/Writable/Telemetry/Metrics/EventsSent' by environment variable: DEVICE_SERVICES_WRITABLE_TELEMETRY_METRICS_EVENTSSENT=false"
"Common configuration loaded from file with 3 overrides applied"
"Common configuration has been pushed to into Configuration Provider with overrides applied"

New Dependency Instructions (If applicable)

Codecov Report

Merging #4449 (09c0485) into main (d51f32b) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##             main    #4449   +/-   ##
=======================================
  Coverage   41.73%   41.73%
=======================================
  Files         106      106
  Lines        9749     9749
=======================================
  Hits         4069     4069
  Misses       5333     5333
  Partials      347      347

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

As expected by #4448, the snap tests have started failing since this change because the overrides no longer apply on top of configurations coming from config provider: Common configuration loaded from the Configuration Provider. No overrides applied
Need to change the snap tests to no longer test that.
@MonicaisHer


Sublime Text 2: Trailing comma before closing bracket in range.sublime, number.sublime, treewalker.sublime

Sublime Text 2
Error trying to parse settings: Trailing comma before closing bracket in ~/Library/Application Support/Sublime Text 2/Packages/JavaScript Completions/sublime-completions/range.sublime-settings:30:3
Even the default settings have extra comma in the end which is making it fail.
"description-jquery": false,  <--

Thank you! I updated it!


webcord-vencord: 4.7.1 -> 4.8.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for webcord-vencord is: Webcord with Vencord web extension
meta.homepage for webcord-vencord is: https://github.com/SpacingBat3/WebCord
meta.changelog for webcord-vencord is: https://github.com/SpacingBat3/WebCord/releases/tag/v4.8.0
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 4.8.0 with grep in /nix/store/9y7wzd9l0kw8xp7v0bsnydl5dlp6hmcs-webcord-vencord-4.8.0
found 4.8.0 in filename of file in /nix/store/9y7wzd9l0kw8xp7v0bsnydl5dlp6hmcs-webcord-vencord-4.8.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath
webcord
webcord-vencord

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/9y7wzd9l0kw8xp7v0bsnydl5dlp6hmcs-webcord-vencord-4.8.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A webcord-vencord https://github.com/r-ryantm/nixpkgs/archive/647ee995f2730e336ec2bf3b25f317c7fa901742.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/647ee995f2730e336ec2bf3b25f317c7fa901742#webcord-vencord

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/9y7wzd9l0kw8xp7v0bsnydl5dlp6hmcs-webcord-vencord-4.8.0
ls -la /nix/store/9y7wzd9l0kw8xp7v0bsnydl5dlp6hmcs-webcord-vencord-4.8.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

2 packages built:

webcord
webcord-vencord

Maintainer pings
cc @FlafyDev @NotAShelf for testing.

Drafting as there's an open PR to update webcord properly that the bot is missing. Will keep this in draft until the PR is merged, so that the bot doesn't try to open a new PR.


Data augmentation

Hello, thanks for your great work!
I have a little question about the data augmentation. In your paper, you mentioned, " At each epoch, we apply METIS graph partition algorithm on G′ to get slightly different node partitions {V1, ..., VP}". So for every epoch, the partition can be slightly different, am I right?
But the code in this repository makes the partition fix for all the epochs in a single run. (train_helper.py, line 32) So maybe in this repository, you have not used the data augmentation mentioned in your paper?

I didn't notice the online parameter and the subtle design of data_loader before. The code does realize the data augmentation. I get it now. I will close this issue. Thanks for your great work!


Crash on inexistant column validation

rails new tst
cd tst
rails g model book
rails db:create db:migrate

and model
class XxxValidator < ActiveModel::Validator
  def validate(_record)
  end
end

class Book < ApplicationRecord
  validates :title, presence: true, xxx: true
end

leads to crash and report a bug request:
…/database_consistency-1.1.5/lib/database_consistency/checkers/validators_fraction_checkers/column_presence_checker.rb:47:in `column': Missing column in books for title (DatabaseConsistency::Errors::MissingField)
	from …/database_consistency-1.1.5/lib/database_consistency/checkers/validators_fraction_checkers/column_presence_checker.rb:32:in `check'
	from …/database_consistency-1.1.5/lib/database_consistency/checkers/base_checker.rb:25:in `report'
	from …/database_consistency-1.1.5/lib/database_consistency/checkers/base_checker.rb:34:in `report_if_enabled?'
	from …/database_consistency-1.1.5/lib/database_consistency/processors/validators_fractions_processor.rb:23:in `block (3 levels) in check'
	from …/database_consistency-1.1.5/lib/database_consistency/processors/validators_fractions_processor.rb:21:in `map'

Hi @ojab,
Thank you for pointing this out!
Looking at your error: Missing column in books for title and the way you generated model: rails g model book, it seems that you don't have title column defined in the schema but you have a presence validation for it.

Yep, it's completely bogus code, but we have this in one, ugh, proprietary project and got after trying to update the gem.
While we cannot do anything about it, crash is not good.

I see and agree with you, we have a rescue per each check to create a file with all failures, probably, this one happens sooner.
I'll have a look and fix it this week or do you want to contribute?

Unfotunately don't think that I would have the capacity to read the code in the coming weeks, otherwise it would be PR already :crying_cat_face:

Just released 1.1.6, please try it out and say if it works fine for you.

https://github.com/djezzzl/database_consistency/pull/105


Fix small typo in configuration doc

What changes were proposed in this pull request?
Easy fix in the documentation.
How was this patch tested?
N/A
Closes #20948

Can one of the admins verify this patch?

Can one of the admins verify this patch?

that's fine but mind taking a look for other typoes while we are here?

@HyukjinKwon Great idea! I've found and fixed some other issues using a spell checker.

It would be better to check other docs, not only in configurations here.

ok to test

Test build #88741 has started for PR 20928 at commit efebd5b.

Test build #88741 has finished for PR 20928 at commit efebd5b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88741/
Test PASSed.

I'm gonna check other docs.

 BTW, mind adding Closes #20948 in the PR description too so that that PR can be automatically closed when this PR is merged? That PR includes the same change included here.

Test build #88816 has started for PR 20928 at commit 8f7dac2.

@HyukjinKwon I think I'm gonna fininsh today. And I've added the issue in the description.

Test build #88816 has finished for PR 20928 at commit 8f7dac2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88816/
Test PASSed.

Test build #88820 has started for PR 20928 at commit 28a0dad.

Test build #88820 has finished for PR 20928 at commit 28a0dad.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88820/
Test PASSed.

retest this please

test this please

@HyukjinKwon I think that's it! Please let me know if there's anything else I can do.

Seems there's some problems with Jenkins. Will make the tests run and merge it later.

retest this please

Merged to master.


Fixed typo in package.json

:tada: This PR is included in version 8.1.6 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


add The Genesis Project to derivatives

The Genesis Project
Etherscan link: https://etherscan.io/token/0x8db687aceb92c66f013e1d614137238cc698fedb#writeProxyContract
Website: https://genesisproject.xyz/
Twitter: https://twitter.com/GenesisLoot
Discord: https://discord.com/invite/YUYyPSuwfU
OpenSea: https://opensea.io/collection/genesisadventurer

Please verify the contract on etherscan

@ravindranrahul  :  the verification exists for the implementation here: https://etherscan.io/address/0xe3a345c71e626b5589f6a9ac570e11613bf66237#code  .  the GA contract uses the proxy contract pattern to allow for upgradeability. you can see the link to implementation contract in the proxy contract Etherscan (https://etherscan.io/token/0x8db687aceb92c66f013e1d614137238cc698fedb#writeProxyContract) , so you know the proxy points to implementation that is verified.
our project is gaining steam , we're excited to get on the Loot derivs list!

Gotcha! Thanks for your contribution.


Reg\Events - Internal User can transfer an operation to another operator

Dependencies

Blocked by #1432 , #2427
Blocking #2447

Description:
As an internal user, I need to be able to transfer an Operation between Operators
Acceptance Criteria:
Given that I am on the BCIERS dashboard and click the Transfer an Operation or Facility
OR Given that I am on the Transfer Grid, and I click Make a transfer
Then I am brought to the form Figma
Given I have selected "Operation" as my answer to the question "What is being transferred?"
Then only the "Operation" and "Effective date of transfer" fields are displayed in the form
Given that I submitted the form,
Then I am brought to the transfer complete success page
Figma
Note: this ticket only covers creating a new transfer. Editing the transfer will be covered in a separate ticket.
Development Checklist:

[x] apply RBAC to API endpoint(s) for making a transfer so that it's only accessible to "cas_admin" and "cas_analyst" users
in registration/models/event/transfer_event

[x] a new record should be created in the transfer_event table for the operation in the Transfer Entity form

[x] a new record should be created in operation_designated_operator_timelinhe table with the form fields. The "effective date of transfer" in the form should be inserted into the start_date column for the new OperationDesignatedOperatorTimeline record, and it should also be inserted into the end_date columns for the OperationDesignatedOperatorTimeline record of the previous designated operator. The status of the new record should be set to To be transferred. Transferring an operation should not change any data in the operation table => Sep: After processing the transfer, we create an entry in the FacilityDesignatedOperationTimeline table. (we don't do it if transfer is in the future)

[ ] for each facility currently assigned to the operator, a new record should be created in facility_designated_operation_timeline table with the form fields. The "effective date of transfer" in the form should be inserted into the start_date column for the new FacilityDesignatedOperationTimeline record, and it should also be inserted into the end_date column for the FacilityDesignatedOperationTimeline record of the previous designated operation. The status of the new record should be set to To be transferred. => Sep: This is not valid

[x] the dropdown options for "Operation" should only include the operations currently associated with the "Current operator" selection

[ ] create several mock fixtures for transfers of operations, with effective dates both in the distant future and in the past. Mock fixtures should also include both LFOs and SFOs

[x] recommended: add explanation in docs/backend folder to explain how transfers work - it's complicated and confusing

[ ] Meets the DOD

Definition of Ready (Note: If any of these points are not applicable, mark N/A)

[ ] User story is included
[ ] User role and type are identified
[ ] Acceptance criteria are included
[ ] Wireframes are included (if required)
[ ] Design / Solution is accepted by Product Owner
[ ] Dependencies are identified (technical, business, regulatory/policy)
[ ] Story has been estimated (under 13 pts)

·Definition of Done (Note: If any of these points are not applicable, mark N/A)

[ ] Acceptance criteria are tested by the CI pipeline
[ ] UI meets accessibility requirements
[ ] Configuration changes are documented, documentation and designs are updated
[ ] Passes code peer-review
[ ] Passes QA of Acceptance Criteria with verification in Dev and Test
[ ] Ticket is ready to be merged to main branch
[ ] Can be demoed in Sprint Review
[ ] Bugs or future work cards are identified and created
[ ] Reviewed and approved by Product Owner

Notes:

Refinement Notes:

Dev Checklist still required.

Refinement Notes:

@andrea-williams will be providing the Dev Checklist

Refinement Notes:

@andrea-williams - will refine this to be the operation one

Why do we need to ask the user to select the current operator if we already know which operator an operation belongs to? 🤔

Why do we need to ask the user to select the current operator if we already know which operator an operation belongs to? 🤔

it's just for internal users to help them find the correct operation.
Example use cases:

select an operator first so that there's only 3 operations to choose from, rather than having a dropdown list of every operation in BCIERS.
if multiple operations have the same name (no constraint against this as far as I can remember), we can help ensure the internal user is selecting the correct operation by first specifying the operator

Sorry - I put my review notes in the other ticket, but they apply here as well

was able to confirm that this works.


Replace println! with assert! if possible in DataFusion examples

we can use assert! in DataFusion examples to let the user know the expected output
Originally posted by @comphead in https://github.com/apache/datafusion/pull/11088#discussion_r1662795223

I added this as a subtask of https://github.com/apache/datafusion/issues/11230
I would like to propose we migrate some of the smaller examples over from datafusion-examples and into the user guide (to make them more discoverable)
Perhaps we can update them to use assert at the same time, as I found I had to do in https://github.com/apache/datafusion/pull/11217

take

take


Microsoft.Extensions.Configuration.Json preview4 not compatible with netstandard2.0

Describe the bug
preview4 of the Microsoft.Extensions.Configuration.Json package does not work with netstandard2.0 projects, I believe because of a (now fixed) bug in Microsoft.Bcl.Json.Sources. Preview3 was fine, as it still used Newtonsoft.Json.
To Reproduce
Steps to reproduce the behavior:

Upgrade a netstandard2.0 library project to reference Microsoft.Extensions.Configuration.Json 3.0.0-preview4.19216.2.
Try to run it.

Expected behavior
No exception.
Screenshots
N/A
Additional context
I believe this can be fixed by simply updating to the latest Microsoft.Bcl.Json.Sources nightly.

Preview4 didn't have the issue you linked. Could you give more details of what errors you're seeing?

That issue was only closed 2 days ago so I figured that was the problem. I have a library that targets netstandard2.0 and netcore2.1. netstandard2.0 fails at load time if I upgrade to preview4. Getting the exception while take a little bit - I'll update this issue in a few hours.

That issue was only closed 2 days ago so I figured that was the problem.

Yes, but it was a very short lived issue that only affected nightly preview 5 bits.


StyleCop Analyzers

So here it what I've got:

StyleCopAnalyzers as a nuget in Stratis.Bitcoin

I originally wasn't too keen on adding a nuget for that, but apparently, static analyzers are a thing from the past while Roslyn analyzers are the way forward and that's one everone is doing.

2 rulesets:

one called Stratis.ruleset which is where we have the rules
one called None.ruleset where the rules are all disabled.

stylecop.json

some of the rules are configurable. This is done in stylecop.json.

Stratis.Bitcoin is referencing Stratis.ruleset and had been partially fixed.
All the other projects are referencing None.ruleset and therefore don't show any warnings.
The goal is too either change a project to use Stratis.ruleset and fix all the warnings there OR to enforce a rule in None.ruleset and fix it for the whole solution.
I'm in favour of the second solution as it's fewer clicks.
When all is done and clean we can remove the None.ruleset.

Excepts for points mentioned I really like it.


Bug bounty test - PLEASE DO NOT APPROVE. gfppoj

Bug bounty test - PLEASE DO NOT APPROVE. gfppoj

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Registry for holding InstaScale images

Container registry is needed to store InstaScale images

@Maxusmusti I think we have a quay repo setup, do you think we can close this issue?

Yes, quay.io/project-codeflare has rendered this issue solved


Tests and Python Upgrade

Purpose and background context
A few minor changes: this adds additional tests to verify that the code processes the origin-request JSON objects correctly, it updates the Python version to 3.11 to match what is now available in AWS with the update AWS Provider in Terraform, and it removes any Sentry references since we don't use Sentry in Lambda@Edge functions (for now?).
Additionally, this PR (and its eventual merge to main will be a test of the automated deployment of the Lambda function in Stage-Workloads. This code is already running in Stage-Workloads as part of the infrastructure updates and verifying that the make upload-zip command can write a file to the Stage-Workloads S3 shared-files-xxxx bucket. Once this PR is approved, we'll track the automation behavior when it is merged to main.
How can a reviewer manually see the effects of these changes?

Checkout this branch locally and run make tests to see all the tests run

Includes new or updated dependencies?
YES: Updates Python version to 3.11 and removes Sentry dependency.
Changes expectations for external applications?
NO
What are the relevant tickets?

GDT-97
GDT-106

Developer

[x] The Dev CF Lambda@Edge Full Deploy workflow has been run to update CloudFront in Dev1
[x] All related Jira tickets are linked in commit message(s)
[x] Stakeholder approval has been confirmed (or is not needed)

Code Reviewer(s)

[x] The commit message is clear and follows our guidelines (not just this PR message)
[ ] There are appropriate tests covering any new functionality
[ ] The provided documentation is sufficient for understanding any new functionality introduced
[ ] Any manual tests have been performed and verified
[ ] New dependencies are appropriate or there were no changes

I suspect this is an oddity in the shared workflow this uses, but tests run twice because it runs make test which runs the tests as well as make coveralls which runs make test before it runs. It may be a minor thing as these tests are fast, but repos that have extensive test suites running twice would be annoying. The shared workflow this inherits from should likely consider just running make coveralls to avoid double test runs in CI.

ah, crud. just realized that I had forgotten to uncomment the automation piece of stage workflow before submitting this PR! I'm going to push one more commit...


cam subfolder broken with nginx

With versions 6.6.14 onwards selecting a cam subfolder in the installer no longer works, as the url http://host/subfolder is not found (404). This is because the sub folder is now appended to the root field in /etc/nginx/sites-available/rpicam e.g. root /var/www/subfolder; On version 6.6.13 and prior the root was set to root /var/www; and the url http://host/subfolder works.
A work around is to edit the root field in /etc/nginx/sites-available/rpicam to root /var/www; and do a systemctl restart nginx.service

This is due to a pull request entered for issue 600 where the webport was not being honoured. The request code change also set the root as you saw.
Some users prefer to avoid the subfolder in the url which is why this change was probably included but it is inconsistent with the other web server set ups so I propose to revert that part.
It is line 226 in install.sh

Version 6.6.16 upgraded without problems across my 6 pi's - thanks!


Automated Semantic Versioning via GitVersion

What
The implementation of determining a semantic version (semi-)automatically through the use of the tool GitVersion — which takes as input things such as the git commit history, branching strategy, and "smart" commits (specially formatted commit messages).
This work includes 4 parts:

[x] Enhancing the existing CICD workflow to have the capability to provide the output of running the gitversion command to determine the version.
[x] Automatic Nuget Package Version Updates
[x] Automatic Assembly Version Updates
[x] Release Versioning Semantics

This should be implemented following the publishing of version 1.6.1.


cadvisor error

I am getting this error with btrfs partition:
eth-docker-cadvisor-1                   | W0201 08:33:18.608983       1 fs.go:595] Unable to get btrfs mountpoint IDs: stat failed on /dev/md4 with error: no such file or directory
eth-docker-cadvisor-1                   | W0201 08:33:18.708159       1 fs.go:595] Unable to get btrfs mountpoint IDs: stat failed on /dev/md4 with error: no such file or directory

Fun. Suggestions on how to handle that? I don't have a btrfs to test

All I can find is https://github.com/google/cadvisor/issues/3357 . Short of a fix for cadvisor, there's not much I can do.


Preload is never resolved when an empty array is passed in.

When an empty array is passed into the preload() function, the promise is never resolved. Changed the code so that is checks for an empty array.
Also might be a good idea to add a Prettier file into the project so the styling is consistent.

Unfortunately i messed up when adding the pull requests but this is added in the latest release.
Best regards 🚀


Migrate article: Rotating Grafana service credentials

Migrate the content from this article to fit the documentation portal format https://help.aiven.io/en/articles/5799962
(Assign this issue to yourself before you start, and remember to mention the issue number when you open your pull request)

Fixed by https://github.com/aiven/devportal/pull/868


Hotfix/broken tests

fix this PR #138 , related to issue #137

Coverage increased (+2.06%) to 92.304% when pulling f359e393c31bd958371e629941a52042bee265e3 on hotfix/broken-tests into 6c2966e1a5b2dd634457325b0691a216d2c6f8bd on develop.


[TASK] Evaluate ideas to design a troubleshoot tool to help simplify the debugging path

What's the task? Please describe.
The complexity to figure out the reasons for the reported issues keeps growing especially depending on the different factors like the number of volumes/replicas/nodes/disks, separate logs of different components (managed components, CSI containers, Kubelet, host, etc), HA behavior causing the logs of a volume behavior across different nodes, etc.
We need to think further about a tool or toolset to help clarify the path to identify the root cause based on the logs across the nodes.
Describe the items of the task (DoD, definition of done) you'd like.
Given based on the support bundle

[ ] evaluate some search engines (ex: es, logi, etc) to help aggregate logs across the logs across nodes
[ ] evaluate a solution to associate the logs across nodes based on the filters to aggregate storytelling time-series logs
[ ] based on the evaluation, come out a proposal for this troubleshooting tool development

Additional context
N/A

ref #5013


New camera film back is not updating when camera is published.

Issue submitted via PipeBot
Reporting user: Erik Bostrom

Was republishing cameras that have the new filmback settings, but they were loading into the anim scene file with the old filmback and had to be changed manually.

Older shotfiles were generated without an embeded fileInfo with key code.


Release 1.6

Hi @jgoldhammer, could you please release version 1.6? Deploying Maven snapshots in production environments is something I'd like to avoid.

I have released version 1.7 because I have made a little mistake.
Currently it is not available in Maven repositories because of the delayed staging process of Nexus Sonatype.

Thanks!


dependency_links does not work in setup.py

Kota-no-MacBook-Air-2:resource kota$ pip install git+https://github.com/ishikota/HoleCardHandicapper
Collecting git+https://github.com/ishikota/HoleCardHandicapper
  Cloning https://github.com/ishikota/HoleCardHandicapper to /var/folders/jl/cjx89kr14ll3q4zf_hxf4vd80000gn/T/pip-ERVBw1-build
Collecting Keras==1.0.4 (from HoleCardHandicapper==0.0.1)
Collecting h5py==2.6.0 (from HoleCardHandicapper==0.0.1)
  Using cached h5py-2.6.0-cp27-cp27m-macosx_10_6_intel.macosx_10_9_intel.macosx_10_9_x86_64.macosx_10_10_intel.macosx_10_10_x86_64.whl
Collecting PyPokerEngine==0.0.1 (from HoleCardHandicapper==0.0.1)
  Could not find a version that satisfies the requirement PyPokerEngine==0.0.1 (from HoleCardHandicapper==0.0.1) (from versions: )
No matching distribution found for PyPokerEngine==0.0.1 (from HoleCardHandicapper==0.0.1)

setup.py
from setuptools import setup

setup(
    name = 'HoleCardHandicapper',
    version = '0.0.1',
    ...,
    packages = ['holecardhandicapper', 'holecardhandicapper.model'],
    install_requires = ['Keras==1.0.4', 'h5py==2.6.0', 'PyPokerEngine==0.0.1'],
    dependency_links =<EMAIL_ADDRESS>    )

Now PyPokerEngine is distributed on pypi.
So do not need to use dependency_links.
Close this issue


Missing and reordered verses in Serval drafts

We've had multiple reports of missing or re-ordered verses in Serval drafts over the past few days. Its possible this should be two issues but I'm initially combining as all the reports have come in since Friday.
These chapter-final verses are missing from 2 projects, but were present in the source:
Hyolmo:  Exo 40:38; Esther 10:3; Jonah 4:11
SCP_U:  Esther 10:3; Jonah 4:11
Peter reports here investigating missing verses for a PNG project.
The image below shared by James Cuénod shows wrongly-ordered verses in the kyu project. (This issue was also reported in SILNLP drafts for the CTB project this week; possibly unrelated since they were not run through Serval.)

@bhartmoore @pmachapman For those that were drafted through SF/Serval, would it be possible to have the engine and build ids? I'd like to make sure we have a complete list of those experiencing issues so I can verify that any solution we come up with solves all existing issues. Also, if you could send me any projects (and the file path to the experiments themselves if possible) for which silnlp had the same issue. I may be wrong, but I believe silnlp is using alignment code from machine.py which mirrors the code in Machine (C#) exactly, so it could very well be a single problem across both. Thank you!

Thanks, @Enkidu93. I found two Hyolmo (scp) builds on the day Mike B reported finding the error. Both projects he reported it for were Hyolmo, but one is their "AI" project, so these most likely represent the two problemmatic builds:

@Enkidu93 The silnlp draft that was pointed out was GEN c. 49 in this folder: "S:\MT\experiments\FT-Bod\NLLB.1.3B.bod_NTB-bo_CTB\infer\8000\NTB_2024"
The experiment can be found on the same path in "S:\MT\experiments\FT-Bod\NLLB.1.3B.bod_NTB-bo_CTB"
Screenshot of the chapter in Notepad++:

Thank you! This is very, very helpful!

Note that this issue should be resolved with https://github.com/sillsdev/machine/pull/204 with release 1.4.5.  It is on QA right now and will be on production hopefully by the end of the week.

Have we tested these projects to see if they are fixed?

I'm not sure that this will have fixed all the issues we're seeing - particularly in silnlp - this didn't involve changes to machine.py (at least yet), did it? Do those just need to be ported over?

Just to make sure this is recorded somewhere: There's also a bug where introductory material is not being translated. @bhartmoore, is there an example you could send my way?

@Enkidu93 I believe this should affect anything translated since the most recent Serval update went live in SF. An example would be the Pentateuch translated from NIV11 to French in project SFDF. Here is the handy new "Admin" view of the most recent build for that project from Scripture Forge, but let me know if you need more/other information.
Diagnostic Information
Build Id: 6657975aec58cd36956de963
Corpora Ids: 6657975aec58cd36956de962
Date Finished: 2024-05-30T03:35:17.134+00:00
Message: Completed
Percent Completed: 1
Revision: 2263
Queue Depth: 0
State: COMPLETED
Step: 20000
Translation Engine Id: 66579759ec58cd36956de95f

@bhartmoore - the most recent fixes should be in Serval Live as of Wed. night.  Can this project be re-run to see if they are still getting the same results?

@johnml1135 Great! I'm guessing you mean the SF builds and not the silnlp one, correct? I'll need to ask Mike Bacon if he can re-request drafts for this team. His were missing chapter-final verses. We'd also want to check with Peter Chapman or James Cuénod to see if they can re-run the SF projects that saw wrongly-ordered verses.

Yes, these changes only affect SF/Serval. We still need to replace the USFM parser in silnlp.

User Mike Bacon reports that final verses are still missing from Serval-via-SF drafts for the scp_U project generated on 6/16.

Peter reports that his comments were about verses missing from the target, so a different issue.
I've reached out to James Cuénod to ask whether he can have the team that saw both dropped and re-ordered verses regenerate their drafts. This team reported that the missing verses were different based on which source text they used.

I will open a separate issue for the Intro and first section heading to be included in drafts.

Just saw issue #408 opened by Pchapman which sounds very much like what Mike Bacon is facing.

@johnml1135 @ddaspit Back to work. Where does this stand? Have some of these issues been addressed elsewhere? Did you, @johnml1135 ,  verify that any were fixed by the previous changes?

We have fixed the missing last verse issue in #408. Once we finish #405, SF should be able to fix the rest of this issue.

We have fixed the missing last verse issue in #408. Once we finish #405, SF should be able to fix the rest of this issue.

Excellent! Thank you.

@johnml1135 Should this be closed since the only remaining work is on the SF side?

Yes, I believe this is fully resolved.


[FR] Feedback for: /fundamentals/getting-started/your-first-multi-screen-site/responsive.html

Honestly your blogpage is the example of what not to do.... Your page may display well on a smartphone and gets displayed on a desktop but it is by far not adapted for a desktop screen. How can you display a method for multi-screen in a way leaves 2/3 of the desktop screen unused or uses front size 46? If your method for multi-screen is make a smartphone page and display it on a desktop well than no tanks. Your page gets so long that it is a pain to navigate with a mouse scroll. No sidebar for navigation on a web developer page ? really ?
You are a web developer so why not develop something like a table that gets displayed side by side on large screens but one below the other on a small screen.
like
A1 A2 A3
B1 B2 B3
on desktop and
A1
A2
A3
B1
B2
B3
on smartphone
I don't know something that is really suited for all screens....

It's an example of what you can do and is a good first starting point.  Centering and using a max width is  valid technique to handle larger desktop screens.
We are in no way making a smartphone page and showing on desktop.
You don't need sidebars for navigation if you don't want it.


Feature - Add LTC simnet configuration to lnd

This PR adds configuration for LTC simnet on LND and removes the error that was thrown for "ltc simnet not supported".
This was tested by funding the relayer. This PR also have go fmt changes

 Simnet LTC


[SPARK-36033][SQL][TEST] Validate partitioning requirements in TPCDS tests

What changes were proposed in this pull request?

Make sure all physical plans of TPCDS queries are valid (satisfy the partitioning requirement).
Why are the changes needed?

improve test coverage
Does this PR introduce any user-facing change?

no
How was this patch tested?

N/A

@Ngone51 @yaooqinn

Test build #140763 has started for PR 33248 at commit 274e642.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45275/

Test build #140763 has finished for PR 33248 at commit 274e642.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140763/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45275/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45275/

Test build #140780 has started for PR 33248 at commit 1edbb3a.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45292/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45292/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45292/

Test build #140780 has finished for PR 33248 at commit 1edbb3a.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140780/

Test build #140807 has started for PR 33248 at commit e671eb4.

Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45318/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45318/

Test build #140807 has finished for PR 33248 at commit e671eb4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140807/

thanks for the review, merging to master/3.2 (to improve test coverage)


Can't download from globoplay.globo.com

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2016.08.07. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2016.08.07

Before submitting an issue make sure you have:

[x] At least skimmed through README and most notably FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add -v flag to your command line you run youtube-dl with, copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
C:\Apps\youtube-dl>youtube-dl.exe --version
2016.08.07

C:\Apps\youtube-dl>youtube-dl.exe -v https://globoplay.globo.com/v/5217401/
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['-v', 'https://globoplay.globo.com/v/5217401/']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2016.08.07
[debug] Python version 3.4.4 - Windows-8.1-6.3.9600
[debug] exe versions: ffmpeg N-34549-g13b7781, ffprobe N-79000-g66edd86
[debug] Proxy map: {}
[Globo] 5217401: Downloading JSON metadata
[Globo] 5217401: Downloading security hash for 5217401_90_720_wmsm
[Globo] 5217401_90_720_wmsm: Downloading m3u8 information
WARNING: Failed to download m3u8 information: HTTP Error 403: Forbidden
[Globo] 5217401: Downloading security hash for 5217401_360_720_wmsm
[Globo] 5217401_360_720_wmsm: Downloading m3u8 information
WARNING: Failed to download m3u8 information: HTTP Error 403: Forbidden
[Globo] 5217401: Downloading security hash for 5217401_360_360_wmsm
[Globo] 5217401_360_360_wmsm: Downloading m3u8 information
WARNING: Failed to download m3u8 information: HTTP Error 403: Forbidden
ERROR: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type
  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpj2cm3udp\build\youtube_dl\YoutubeDL.py", line 682, in extract_info
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpj2cm3udp\build\youtube_dl\extractor\common.py", line 347, in extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpj2cm3udp\build\youtube_dl\extractor\globo.py", line 382, in _real_extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpj2cm3udp\build\youtube_dl\extractor\common.py", line 898, in _sort_formats
youtube_dl.utils.ExtractorError: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

C:\Apps\youtube-dl>

<end of log>

Description of your issue, suggested solution and other information
Can't download from globoplay.globo.com. I can see this video (https://globoplay.globo.com/v/5217401/) without problems in the browser.

Works fine here:
PS C:\Dev\youtube-dl\master> py -2.7 .\youtube_dl\__main__.py https://globoplay.globo.com/v/5217401/  --proxy 'socks5://
<IP_ADDRESS>:29668' -v
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'https://globoplay.globo.com/v/5217401/', u'--proxy', u'socks5://<IP_ADDRESS>:29668', u'-v']
[debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251
[debug] youtube-dl version 2016.08.07
[debug] Git HEAD: 082395d
[debug] Python version 2.7.12 - Windows-10-10.0.10240
[debug] exe versions: ffmpeg N-81192-g04da20e, ffprobe N-81192-g04da20e, rtmpdump 2.4
[debug] Proxy map: {u'http': u'socks5://<IP_ADDRESS>:29668', u'https': u'socks5://<IP_ADDRESS>:29668'}
[Globo] 5217401: Downloading JSON metadata
[Globo] 5217401: Downloading security hash for 5217401_90_720_wmsm
[Globo] 5217401_90_720_wmsm: Downloading m3u8 information
WARNING: Failed to download m3u8 information: <urlopen error [Errno 10054] An existing connection was forcibly closed by the remote host>
[Globo] 5217401: Downloading security hash for 5217401_360_720_wmsm
[Globo] 5217401_360_720_wmsm: Downloading m3u8 information
[Globo] 5217401: Downloading security hash for 5217401_360_360_wmsm
[Globo] 5217401_360_360_wmsm: Downloading m3u8 information
[debug] Invoking downloader on u'https://vodstreaming02.video.globo.com/r360_720/v2/f0/3b/0c/5217401_0c306aa799d7a796ecd337a117e7ed3bcc132625/5217401-manifest.wmsm/manifest/web720.mp4.m3u8'
[hlsnative] Downloading m3u8 manifest
[hlsnative] Total fragments: 1550
[download] Destination: Cerimnia de abertura dos Jogos Olmpicos Rio 2016, na ntegra-5217401.mp4
[download]   0.0% of ~4.91GiB at 20.98KiB/s ETA 85:43:46
ERROR: Interrupted by user

I use Allavsoft to download from Globo, YouTube, Vimeo, Linkedin etc
Here is the easy guide http://www.allavsoft.com/how-to/download-globo-videos.html


Add the  Tag Helper

Adds the  Tag Helper, which supports a fallback stylesheet href path. Done without VS 'cos that's how I'm rollin' this week :sunglasses:

#1580

Come one, come all to review! @dougbu @NTaylorMullen

:watch:

Done without VS 'cos that's how I'm rollin' this week

It would be super-awesome if you blogged about how you did this without VS. If you have already, please forgive my ignorance and let me know where I can read about it.

Looks good 2 me, :shipit:

:watch:

Merged in 3d33418f315ef73c03e777538360746878be744d


dnst-signzone should default iterations to zero

To match best practices:
Questions:

and ldns-signzone too? (But would be backeard incompatible)
and ldns-nsec3-hash too?

This is blocked pending a decision on how to manage behaving as both dnst and ldns-xxx and how to manage the differences in CLI argument behaviour going forwards.

This is done for ldns-signzone in PR #8, but not yet for ldns-nsec3-hash.