Editor tablet pen support

Description
I'm not sure how common it is to edit terrain with a graphics tablet, but it seems pretty natural to me. Godot automatically provides pen information through InputEventMouseMotion, which should make this feature pretty straightforward to add.
Pen pressure in particular should be very easy to support. Simply multiply the brush opacity by InputEventMouseMotion.pressure, or something along those lines.
There's also pen "tilting" which could change the angle of the brush, I suppose.

Zylann also uses pressure from the input event.
https://github.com/Zylann/godot_heightmap_plugin/blob/74437e6d1c106adee38f9c0fd0e775759b6e2974/addons/zylann.hterrain/tools/plugin.gd#L502

Pen pressure support added in https://github.com/TokisanGames/Terrain3D/commit/a67d5801a6d9edc7973f4634d396b7566bd228ea
If pen pressure is non-zero, strength is ignored. This means though that pen pressure cannot draw stronger than 100%, unlike the mouse.
@aristides86 @dkaste Try it in a nightly build. Download the artifact.
https://github.com/TokisanGames/Terrain3D/actions/runs/10465611812

Thank you. Pressure works but could it be that it breaks strength for the mouse now? In the video the first stroke made with the stylus with increasing pressure, the second with the mouse with 1% strength. Strength works well in 0.9.2-beta release.
https://github.com/user-attachments/assets/81a84fe6-7e7b-4eeb-9a0e-af3fac543f85

This looks beautiful. Please send me info so I can include it here
https://terrain3d.readthedocs.io/en/latest/docs/games.html
In 0.9.3-dev raise/lower strength was reduced 90%. However, you can increase strength up to 10,000%.
I can reproduce the issue. The current code says:

If mouse_pressure is >0 use it, else use brush_strength

The problem is that if the mouse is clicked, pen pressure is 1 instead of 0. And when the tablet is pressed, godot reports that as the left mouse button. I see no way to determine if the user is moving the pen or the mouse when pressure is 0 or 1.
So which is better:

effective strength = mouse_pressure * brush_strength
effective strength = mouse_pressure if 0-.999; brush_strength if 1
or ?

The first means brush strength applies to the pen and the mouse. The second means it does not unless you press really hard. Then between .999 and 1.0 the mouse strength will jump. This is probably the worst option.

To make pressure work we need to enable Pen driver in the project settings, so Godot can understand if the pen or mouse is currently being used. Without it any input is a mouse. Can it be a switch for tablet/mouse input? This would also make it possible to use the Strength parameter for both mouse and tablet input, so users don't have to adjust pressure sensitivity in their tablet settings.

I didn't know about the project settings. However using my Huion tablet, regardless of if I use project settings / pen tablet none, wintab, or winink, all three options report a pen click as left mouse button, and provide pressure.
.001-.999 pressure isn't the problem. I know it's a pen with those values, and 0 doesn't matter. I have no way to determine if 1 is a pen or a mouse. I wanted 1 * brush_strength for a mouse and 1 for a pen. My question is can we do 1 * brush_strength for both? Then I don't need to care if it's a mouse or a pen, it's the same.

This would also make it possible to use the Strength parameter for both mouse and tablet input, so users don't have to adjust pressure sensitivity in their tablet settings.

It sounds like you would like 1 * brush_strength as well, which means the strength slider works for the pen. I was concerned
this wouldn't work well in usage, but trying it I see it does works well. Plus it gives access to brush strengths > 100%. So I'll do this tomorrow.
The operation will be:

If mouse_pressure is 0, use brush_strength (this allows 1-click operations at full strength from the mouse, eg alpha stamps)
Else use mouse_pressure * brush_strength

The operation will be:
If mouse_pressure is 0, use brush_strength (this allows 1-click operations at full strength from the mouse, eg alpha stamps)
Else use mouse_pressure * brush_strength

This works fine most of the time. Mouse clicks have 0 pressure, mouse down w/ movement have 1 pressure. Pen is usually .001-1. Also, unlike the mouse, the pen seems to be constantly sending move events.
However, on my tablet it often registers a 0 pressure click at the start and end of a stroke, but not always. This means at the start or right at the end it suddenly goes full strength. In use, I don't it as an issue at start, but I have noticed it at the end.
What I'm doing now is, tracking the time of the last pen movement (pressure .001-.999). If a 0 pressure click comes in > 100ms after the last pen movement, then pressure is inverted to 1 for full strength. So far, this allows every mouse click and cuts off almost all of the pen jumps at the end of strokes.
I think this is a fair compromise. But I really wish Godot had better identification of tablet and mice input. Even if mouse clicks reported a pressure of 1 would be sufficient to avoid this extra tracking.
Fixed in 59b681ef3bb7cc464dd09c6500fc189d4c38fcba


Hard arbitrary limit on Saved model size

Please make sure that this is a bug. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 18.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: N/A
TensorFlow installed from (source or binary): Both
TensorFlow version (use command below): 1.10+
Python version: N/A
Bazel version (if compiling from source): 17.2
GCC/Compiler version (if compiling from source): 7.3.0
CUDA/cuDNN version: N/A
GPU model and memory: N/A

Describe the current behavior
I am trying to load a 1.4GiB binary saved model and am getting an error saying that the protobuf message is too big i.e. over 1GiB
Describe the expected behavior
Current default limits for protobuf messages loaded by a CodedInputStream are 2GiB so my model should load without error.
Code to reproduce the issue
Comment out line 503 in env.cc:
//coded_stream.SetTotalBytesLimit(1024LL << 20, 512LL << 20);
rebuild and everything works as expected.
Other info / logs
Also the second parameter to SetTotalBytesLimit has been deprecated and is no longer enforced.

@blair0011 ,
Protobuf has a hard limit of 2GB, because many implementations use 32-bit signed arithmetic. For security reasons, many implementations impose a size limit of 64MB by default, although you can increase this limit manually.
Also could you take a look at this SO link which delivers the required information. Thank you!


WAP to find area of a circle, a rectangle and a triangle, using concept of function overloading.

doing this

can u assign me, i want to work on this


inardini -- bqml/04_model_training_and_prediction review

This PR is about reviewing 04_model_training_and_prediction.

LGTM, very minor fixes on top of Ivan's fixes.


Resource Abstractor Service

#169
PR tackles:

[x] Creation of new abstract service.
[x] Cloud Scheduler in Root utilizes the new service. Cloud Scheduler no longer access the database.
[x] Add readme
[x] Add new service to docker-compose.

Futuer PR:

Next PR should include having the system_manager also utilizing the new service.
Move jobs endpoint to another service.

@melkodary, all good; just make sure to resolve these conflicts, and we can merge this 💫💫


1.20 staffcasting can draw from casting items

hexcasting-forge-1.20.1-0.11.1-7-pre-607
staff casting with casting items in inventory causes them to be used as media sources, prioritized over standard forms of media too it appears

Casting items as in cyphers/trinkets/artifacts?

Casting items as in cyphers/trinkets/artifacts?

yep sorry for not being clear, i noticed this specifically with artifacts and trinkets, havent tried cyphers

looked into it a bit.
it is cause all three of these extend ItemMediaHolder which extends MediaHolderItem which implements MediaHolderItem
which then gets the component/capability attached to them meaning that they get their media consumed but canProvideMedia is set to false... but that is not respected in MediaHelper#scanPlayerForMediaStuff or mabey the check for canProvideMedia should perhaps be checked in PlayerBasedCastEnv#extractMediaFromInventory


monitor kills thread on exception

I would prefer trap most exceptions - e.g.
doing an expand before select gets an error but its non fatal.

fixed


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/83026

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

TagBot fix

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/84414

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/85256

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/105713


Create recipes for Oreganized 1.20 lead and silver not properly registered.

Missing recipes for smelting & washing crushed ores, Crushing Galena does not give crushed raw lead.

Applies to 1.19.2 as well.


Adding freeplay only songs is confusing

Nothing is explained in the wiki, and adding them is just genuinely confusing
I suggest updating the wiki with this

It's not confusing, you literally just have to add a Week but hide the Week from Story Mode


Fix issue #45:out of range bug

See issue #45.

Your explanation and fix make sense to me. But I've been bitten enough times by "looks correct"....
Let me run a test on one of my ~10TB datasets just to make sure I get the same results before and after to make sure though. This shouldn't take too long, I'll post and update here when it finishes.

Hi Nicholas, ok thank you!

I've confirmed this doesn't change results on my test case. Thanks, merged!

Thank you so much!


Auto-build documentation

My roguelike repository is set up so that every time a commit is pushed to master, Travis builds the docs and puts them on the Github Page for the repository.
Would you like me to set this up for tcod-rs? People would be able to access the latest docs at tomassedovic.github.io/tcod-rs.

Is this a secret ploy to make me write documentation? It's pretty much nonexistent atm, but yeah we need that. The Rusty wrapper is different enough to warrant its own docs.
If you could set it up, that would be absolutely fantastic.

I've actually got a branch which I was going to start writing documentation on, but even without doc-strings the documentation rustdoc generates is quite useful. If I've got time tonight I'll set it up then, if not I'll do it tomorrow.

Awesome, thanks :-).

Well, it's working for my fork, so I should in theory just be able to commit the change and have it work automatically for this repo too.

It's working! http://tomassedovic.github.io/tcod-rs/

Yep! Now there's no excuse for not writing proper docstrings.


Add crictl [create,runp,run,pull] jsonschema subcommands

What type of PR is this?
/kind feature
What this PR does / why we need it:
The jsonschema / js subcommands will print the pod and/or container config JSON schemas for end users to understand where the data is coming from.
Which issue(s) this PR fixes:

Refers to https://github.com/kubernetes/website/issues/40360
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?

Added `crictl [create,runp,run,pull] jsonschema` subcommands to display the pod and/or container config JSON schema.

@kubernetes-sigs/cri-tools-maintainers PTAL

@kubernetes-sigs/cri-tools-maintainers PTAL


Add support for texture binding based on template parameters for 1 Band Images

In order to support textures, we first need to add templates that create and bind the correct textures for the templates types.

Finished Texture Foundation. Need to update existing logic/kernels to utilize the new textures.


Any plans to support older browsers?

The README doesn't explicitly state this as a feature, but are there any plans to support old browsers? For example, on old iOS Safari (9.3.5), I found that the hamburger dropdown doesn't work at all.
EDIT: For some reason this submitted as a blank issue, sorry! I think it's because I clicked on the "New Issue" button while not logged in and it skips the issue chooser screen.

@ericswpark No, this is not a priority currently.


Using outdated PIL library

Having compatibility issue with the old PIL library, it needs to be the new Pillow library and then the imports PIL need to be changed to pil

Hi, I'm a bit confused by this.  I thought pillow was essentially completely standard now.  It is what I am using, see the requirements.txt file.  But I thought you still imported it as PIL.  See the docs, for example:
https://pillow.readthedocs.io/en/stable/handbook/tutorial.html#using-the-image-class
Could you post some more information about your setup, and the exact error message (or problem) you're getting?

Hi, I'm a bit confused by this.  I thought pillow was essentially completely standard now.  It is what I am using, see the requirements.txt file.  But I thought you still imported it as PIL.  See the docs, for example:
https://pillow.readthedocs.io/en/stable/handbook/tutorial.html#using-the-image-class
Could you post some more information about your setup, and the exact error message (or problem) you're getting?

Nope sorry figured out what it was.  There is a pillow package and a Pillow package, I had both installed and pillow was being imported rather than Pillow.  Happy to close this

Nope sorry figured out what it was.  There is a pillow package and a Pillow package, I had both installed and pillow was being imported rather than Pillow.  Happy to close this

Also, love the package!  Thanks

Also, love the package!  Thanks


[Fix #8925] Add --display-time option for outputting time.

This shows the elapsed time of the Rubocop command without needing to show all of the output of --debug.
Before
$ rubocop
...
865 files inspected, 218 offenses detected, 148 offenses auto-correctable
$

After
$ rubocop --display-time
...
865 files inspected, 218 offenses detected, 148 offenses auto-correctable
Finished in 16.146678999997675 seconds
$

Fixes #8925.

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.

I tried testing this through the CLI specs but because it occurs outside of the CLI - essentially wrapping the CLI command itself - it wasn't working. Any thoughts or tips on testing this?

[x] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

I'm fine with the proposed change in general, but it seems to me an option name like --display-time would probably be better. We can also skip a shorthand for it, as we don't have that many of those available, so I'd be careful with their assignment.

@bbatsov Yup, was thinking something like --display-elapsed-time but --display-time is nice and succinct while still being descriptive.
Quick Question: For testing, I tried testing this through the CLI specs but because it occurs outside of the CLI - essentially wrapping the CLI command itself - it wasn't working. Any thoughts or tips on testing this?
Thanks!

Rebased and updated to --display-time now.

Quick Question: For testing, I tried testing this through the CLI specs but because it occurs outside of the CLI - essentially wrapping the CLI command itself - it wasn't working. Any thoughts or tips on testing this?

Can't you just emulate the --debug tests?

Quick Question: For testing, I tried testing this through the CLI specs but because it occurs outside of the CLI - essentially wrapping the CLI command itself - it wasn't working. Any thoughts or tips on testing this?

Can't you just emulate the --debug tests?

Good idea but the --debug tests seem to be contained inside Cli and not testing rubocop/exe/rubocop, which is where the elapsed time is displayed.
Regardless, I used it as a bit of a base and added tests for --display-time with and without the command line option, regex'ing the STDOUT from the command.
Ready for your review again, and thanks for your help.

Good idea but the --debug tests seem to be contained inside Cli and not testing rubocop/exe/rubocop, which is where the elapsed time is displayed.

My bad. I didn't get what you mean initially. I guess it'd be best to move the timing logic to the CLI class.  :-)

Good idea but the --debug tests seem to be contained inside Cli and not testing rubocop/exe/rubocop, which is where the elapsed time is displayed.

My bad. I didn't get what you mean initially. I guess it'd be best to move the timing logic to the CLI class.  CLI was my first guess too.


Added message color

Let me know if this works. First time looking through the code so I'm sure I missed something.

Thanks, this looks good. I commented on a tiny thing that isn't ideal, should be an easy fix tho. :)

Updated

Awesome work! Thanks! :)


fix issue of cluster deployment

Cluster are being deployed, but the test fails later. Since that seems to move the issue forward, I'm going to force merge this issue.

Test failed with:
+ kubectl apply -k /workspace/source/operator/test/manifests/test/tekton-chains -n plnsvc-tests
serviceaccount/chains-test created
rolebinding.rbac.authorization.k8s.io/chains-test-edit-rolebinding created
rolebinding.rbac.authorization.k8s.io/chains-test-scc-rolebinding created
error: resource mapping not found for name: "simple-copy" namespace: "plnsvc-tests" from "/workspace/source/operator/test/manifests/test/tekton-chains": no matches for kind "Pipeline" in version "tekton.dev/v1"
ensure CRDs are installed first
command terminated with exit code 1


Volumes attached to exitted instances cannot be Detached

I created a VM instance, and stopped it.  I then created a volume and attached the volume to the stopped instance.  I rebooted the instance and check that the volume really was attached by netcatting into the instance.  I then tried to detach the volume.  The volume was detached from the instance, but controller still reports the instance in the detaching state.    I see some errors in the launcher logs
I0224 19:16:59.645636    6302 qmp.go:282] {"arguments":{"id":"drive_947ba937-4ccf-474f-a5a8-a60b9d1c1cb6"},"execute":"x-blockdev-del"}
I0224 19:16:59.645987    6302 qmp.go:147] {"error": {"class": "GenericError", "desc": "Cannot find block backend drive_947ba937-4ccf-474f-a5a8-a60b9d1c1cb6"}}
E0224 19:16:59.646035    6302 qemu.go:572] Failed to execute x-blockdev-del: QMP command failed

which implies that the detach code is not working properly.  Here's the steps I took.
$ ciao-cli instance add --workload 319701f1-82e1-4ad3-8c8b-8015d929535d
Created new (pending) instance: 164d7f06-05bf-4409-a1a3-9b914fe87382

$ ciao-cli instance list
# UUID                                 Status Private IP SSH IP        SSH PORT
1 164d7f06-05bf-4409-a1a3-9b914fe87382 active <IP_ADDRESS> <IP_ADDRESS> 33002

$ ciao-cli volume add
Created new volume: 947ba937-4ccf-474f-a5a8-a60b9d1c1cb6

$ ciao-cli instance stop --instance 164d7f06-05bf-4409-a1a3-9b914fe87382
Instance 164d7f06-05bf-4409-a1a3-9b914fe87382 stopped

$ ciao-cli instance list
# UUID                                 Status Private IP SSH IP        SSH PORT
1 164d7f06-05bf-4409-a1a3-9b914fe87382 exited <IP_ADDRESS> <IP_ADDRESS> 33002

$ ciao-cli volume attach --instance 164d7f06-05bf-4409-a1a3-9b914fe87382 --volume 947ba937-4ccf-474f-a5a8-a60b9d1c1cb6
Attached volume: 947ba937-4ccf-474f-a5a8-a60b9d1c1cb6

$ ciao-cli instance show --instance 164d7f06-05bf-4409-a1a3-9b914fe87382
	UUID: 164d7f06-05bf-4409-a1a3-9b914fe87382
	Status: exited
	Private IP: <IP_ADDRESS>
	MAC Address: 02:00:ac:10:00:02
	CN UUID: e28a5d93-814c-4432-8cc6-ad587d2fbd20
	Image UUID:
	Tenant UUID: f0fc522c00314db4b653a726031bd055
	SSH IP: <IP_ADDRESS>
	SSH Port: 33002
	Volume: c97cf5dd-a1c0-48ba-acc7-0e56ffa69066
	Volume: 947ba937-4ccf-474f-a5a8-a60b9d1c1cb6

$ ciao-cli instance restart --instance 164d7f06-05bf-4409-a1a3-9b914fe87382
Instance 164d7f06-05bf-4409-a1a3-9b914fe87382 restarted

$ ciao-cli instance show --instance 164d7f06-05bf-4409-a1a3-9b914fe87382
	UUID: 164d7f06-05bf-4409-a1a3-9b914fe87382
	Status: active
	Private IP: <IP_ADDRESS>
	MAC Address: 02:00:ac:10:00:02
	CN UUID: e28a5d93-814c-4432-8cc6-ad587d2fbd20
	Image UUID:
	Tenant UUID: f0fc522c00314db4b653a726031bd055
	SSH IP: <IP_ADDRESS>
	SSH Port: 33002
	Volume: c97cf5dd-a1c0-48ba-acc7-0e56ffa69066
	Volume: 947ba937-4ccf-474f-a5a8-a60b9d1c1cb6

$ ciao-cli volume detach --volume 947ba937-4ccf-474f-a5a8-a60b9d1c1cb6
Detached volume: 947ba937-4ccf-474f-a5a8-a60b9d1c1cb6

$ ciao-cli instance show --instance 164d7f06-05bf-4409-a1a3-9b914fe87382
	UUID: 164d7f06-05bf-4409-a1a3-9b914fe87382
	Status: active
	Private IP: <IP_ADDRESS>
	MAC Address: 02:00:ac:10:00:02
	CN UUID: e28a5d93-814c-4432-8cc6-ad587d2fbd20
	Image UUID:
	Tenant UUID: f0fc522c00314db4b653a726031bd055
	SSH IP: <IP_ADDRESS>
	SSH Port: 33002
	Volume: 947ba937-4ccf-474f-a5a8-a60b9d1c1cb6
	Volume: c97cf5dd-a1c0-48ba-acc7-0e56ffa69066

$ ciao-cli volume list
Volume #1
	Name             [Storage for instance: 075c49fe-b833-403f-9846-a488f7663ee8]
	Size             [1 GB]
	UUID             [3eaa0d5f-5fa7-417b-bc5c-dccfd2c3a540]
	Status           [in-use]
	Description      []

Volume #2
	Name             [Storage for instance: 164d7f06-05bf-4409-a1a3-9b914fe87382]
	Size             [3 GB]
	UUID             [c97cf5dd-a1c0-48ba-acc7-0e56ffa69066]
	Status           [in-use]
	Description      []

Volume #3
	Name             []
	Size             [1 GB]
	UUID             [947ba937-4ccf-474f-a5a8-a60b9d1c1cb6]
	Status           [detaching]
	Description      []

$ sleep 60 && ciao-cli instance show --instance 164d7f06-05bf-4409-a1a3-9b914fe87382
	UUID: 164d7f06-05bf-4409-a1a3-9b914fe87382
	Status: active
	Private IP: <IP_ADDRESS>
	MAC Address: 02:00:ac:10:00:02
	CN UUID: e28a5d93-814c-4432-8cc6-ad587d2fbd20
	Image UUID:
	Tenant UUID: f0fc522c00314db4b653a726031bd055
	SSH IP: <IP_ADDRESS>
	SSH Port: 33002
	Volume: c97cf5dd-a1c0-48ba-acc7-0e56ffa69066
	Volume: 947ba937-4ccf-474f-a5a8-a60b9d1c1cb6

$ ciao-cli volume list
Volume #1
	Name             [Storage for instance: 075c49fe-b833-403f-9846-a488f7663ee8]
	Size             [1 GB]
	UUID             [3eaa0d5f-5fa7-417b-bc5c-dccfd2c3a540]
	Status           [in-use]
	Description      []

Volume #2
	Name             [Storage for instance: 164d7f06-05bf-4409-a1a3-9b914fe87382]
	Size             [3 GB]
	UUID             [c97cf5dd-a1c0-48ba-acc7-0e56ffa69066]
	Status           [in-use]
	Description      []

Volume #3
	Name             []
	Size             [1 GB]
	UUID             [947ba937-4ccf-474f-a5a8-a60b9d1c1cb6]
	Status           [detaching]
	Description      []

This will be fixed when we fix #1315

@markdryan i'm a little bit confused by the title here. Reading your report it seems to be that you try and detach after you have restarted the instance. Not when when it is in exitted state? Could you confirm and check the title?


mixer: disable L2 cache

Ref: #9596
/assign @mandarjog
/assign @geeknoid

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: kyessenov
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: greghanson
If they are not already assigned, you can assign the PR to them by writing /assign @greghanson in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyessenov: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow//e2e-simpleTests-minProfile.sh
4afd3d093ae89d58d61bae0f89f3461c9b4c1ec6
link
/test e2e-simpleTestsMinProfile

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow//e2e-simpleTests-minProfile.sh
4afd3d093ae89d58d61bae0f89f3461c9b4c1ec6
link
/test e2e-simpleTestsMinProfile

prow/e2e-mixer-no_auth.sh
4afd3d093ae89d58d61bae0f89f3461c9b4c1ec6
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow//e2e-simpleTests-minProfile.sh
4afd3d093ae89d58d61bae0f89f3461c9b4c1ec6
link
/test e2e-simpleTestsMinProfile

prow/e2e-mixer-no_auth.sh
4afd3d093ae89d58d61bae0f89f3461c9b4c1ec6
link
/test e2e-mixer-no_auth

prow/e2e-mixer-no_auth-mcp.sh
4afd3d093ae89d58d61bae0f89f3461c9b4c1ec6
link
/test e2e-mixer-no_auth-mcp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: kyessenov, mandarjog
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS [mandarjog]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyessenov mixer e2e tests are failing, are there tests that rely on cache being enabled?

@mandarjog No, I don't think we have e2e tests for the L2 cache. The same change did not cause errors in 1.0 branch. I'll investigate why the tests are failing (assuming it's not just flakes).
/retest

Build fails in tests :/

If the cache is fundamentally broken, then we should turn it off in the
code rather than config, so that it is guaranteed not to be used.
The StringMap string is an excellent catch. I agree this code needs more
testing. Do you think there are reported failures which aren't explained by
this map bug?
On Mon, Dec 3, 2018 at 11:41 AM Kuat<EMAIL_ADDRESS>wrote:

@kyessenov commented on this pull request.
In install/kubernetes/helm/subcharts/mixer/templates/deployment.yaml
https://github.com/istio/istio/pull/10225#discussion_r238409805:

@@ -28,6 +28,7 @@
- --monitoringPort={{ .Values.global.monitoringPort }}
- --address
- unix:///sock/mixer.socket

     - --numCheckCacheEntries=0

I found one cause of the problem. It's caused by the change of the
underlying type for the stringmap values here:
https://github.com/istio/istio/blob/master/mixer/pkg/checkcache/keyShape.go#L198-200
At some point it got swapped to attribute.StringMap and the case
statement did not have a default clause.
I think the lesson here is that we have insufficient test coverage for the
check cache. I am not convinced this is the only mistake in the cache.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/10225#discussion_r238409805, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AVucHZJZ1uflNQd6-Kp7LZa6EmN8s305ks5u1X5ugaJpZM4Y8oDj
.

I suggest we turn it off in code by changing the default size to 0 (as well as setting the flag to 0 to make it obvious).
Yes, there's another non-deterministic error that does not involve string maps. I'm having trouble reproducing that one.
We also need to track down map[string]string vs attribute.StringMap across the entire code base, and that is going to take some time. There are several

Superseded by #10260


Working Files closing issue.

Closing an Item in the Working files and choosing 'dont save' does not close the file. It works identically to cancel.
Steps to reproduce:

Open a file
Alter it. A little dot appears to the left of the unsaved file.
You change your mind, lets just close that file.
Click the x, a popup appears "save, don't save and cancel"
select "don't save". Nothing happens. It is the same as choosing the cancel button. It was expected the file would close, discarding your changes.

@the-simian I do NOT see the issue!!   For me, it works as one would expect it to.
Can you please share the OS and version of Brackets you are using.
You can try reloading without extensions OR try after deleting your preferences. Refer Troubleshooting.

Its possible an extension is interfering. I am using Windows and version 1.3.0.
I'll audit my extensions. I'll close the issue, then. Thanks for confirming!

Actually I was opening an issue just like that but searched before post....
Well, I do have this same behavior in my as well.
Yes, I already reload it with no extensions, and still having this same behavior
Yes, I already did a fresh install, same error
Yes, nothing on console
Yes, this is driving me crazy
And, another issue I could noticed is, sometime a dozen of files randomly open with anyone asked to open them, and stay on my open files as if i alter them and they are waiting to be saved and closed, and as long I cannot click in ""don't save"" and expect them to be closed with no changes at all, I'm forced to click in "Save" and really hope to have no changes at all in that file.
How can i proceed to help you guys?
cheers =)

@tofanelli : I had to switch to atom. It was unuseable

Keep in mind that uninstalling Brackets doesn't remove everything. See https://github.com/adobe/brackets/wiki/Cache-Folder
You could take a backup of your extensions before remove that folder, so you can copy them back without reinstalling all of them.

@the-simian .... unfortunately i'm trying Sublime now... i personally didn't liked Atom.... i don't know why... if anything works as intended, i will give a shot on VS Code.... I've been heard good words from it =)
@ficristo .... Sorry about misunderstanding, but when I said "Yes, I already did a fresh install, same error", i was talking about a real fresh one.... I installed windows from scratch... and still got this same error...
Even on its latest version i still experiencing this behavior. Using Windows 8.1 english fully updated.
Cheers =D


Superlearnerl on google colab (python 3.10 or 3.7)

I am trying to run Superlearner on google colab (python 3.10 or 3.7), but I am getting an error in the Superlearner import (from mlens.ensemble import SuperLearner). The error is:
from collections import Sequence
ImportError: cannot import name ‘Sequence’ from ‘collections’ (/usr/lib/python3.10/collections/init.py)
Do you know how to solve this issue?
Thank you in advance.

I found the following:
To solve the Python "ImportError: cannot import name 'Sequence' from 'collections'" error:
Import the Sequence class from collections. abc , as a change was made in Python 3.10.
Update the versions of any modules that have old import statements.
But I did not try it. Could you update this Sequence class from collections. abc , please?

Please, see this on:
https://github.com/skorch-dev/skorch/issues/895
python3.10 -c "from collections.abc import Sequence"

Solved


Add flake8 bugbear, eradicate, docstyle, docstring plugin

@5A11 I removed darglint from the flake8 extension.


feat: accept stripe webhooks events to sync state faster

A new RPC BillingWebhookCallback(/v1beta1/billing/webhooks/callback/{provider}) allows accepting stripe webhook events being sent to frontier
This reduces the delay between the state sync between stripe and frontier for customer changes, checkout success, etc.
Stripe endpoint secret needs to be set in frontier config under billing.stripe_webhook_secrets. It accepts an array of keys and all keys will be tried to validate the event. If the validation fails, event will be discarded.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

1 of 570 (0.18%)  changed or added relevant lines in 18 files are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.04%) to 9.379%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

core/event/listener.go
0
1
0.0%

internal/api/v1beta1/v1beta1.go
0
1
0.0%

cmd/serve.go
0
3
0.0%

internal/store/postgres/billing_customer_repository.go
0
5
0.0%

pkg/server/interceptors/enrich.go
0
5
0.0%

billing/customer/customer.go
0
7
0.0%

internal/store/postgres/billing_checkout_repository.go
0
8
0.0%

billing/customer/service.go
0
12
0.0%

billing/checkout/service.go
0
13
0.0%

internal/api/v1beta1/billing_webhook.go
0
14
0.0%

Files with Coverage Reduction
New Missed Lines
%

proto/v1beta1/frontier_grpc.pb.go
1
0.0%

proto/v1beta1/frontier.pb.gw.go
2
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.04%

Covered Lines:
9560

Relevant Lines:
101934

💛  - Coveralls


[Bug]: Not able to edit queries when user has edit app role

Is there an existing issue for this?

[X] I have searched the existing issues

Description
When a user has edit permission at workspace level in application resources tab, on opening any query in that app gives "An unexpected error occurred" error and user is not able to edit the query.

Steps To Reproduce

Create a new role with edit permission at workspace level
Assign the role to user1
Login as user1
Click on query from entity explorer , it will take you to query editor
Observe An unexpected error occurred is shown

Public Sample App
No response
Issue video log
No response
Version
http://<IP_ADDRESS>/

This issue is reproducible if you give edit access to the application but do not give view access to the datasource. The client reaches this erroneous state.


Add a warning if the debugger is not signed and running on OS X

@gregg-miskelly @jacdavis @andrewcrawley @chuckries

Otherwise LGTM

My only concern here is that if the user has taken the option of disabling SIP instead of signing the binary, they're going to get a warning popup at every launch anyway.  Doesn't GDB print some error message about Mach ports or something if it fails due to the signing issue?  It might be better to detect that error and tell the user how to fix it rather than warning proactively.

if the user has taken the option of disabling SIP instead of signing the binary

We will point our instructions to the gnu instructions that only specify self-signing.

they're going to get a warning popup at every launch anyway

This is output to the Debug Window at the moment.

Doesn't GDB print some error message about Mach ports or something if it fails due to the signing issue?

Yeah, that was my original plan. However, as we have discussed today, the errors don't get written into the pipe until a different command gets executed (gdb bug) when stdout is redirected, so it leaves as not knowing this has occurred.

Fair enough.  If the intent is to display the message in the output window, is there a reason you used MT_MESSAGEBOX instead of MT_OUTPUTSTRING?

The intent is to show it prominently, ideally as a message from the top in VSCode. If people are really annoyed because they decide to turn off the security feature, then we can revisit this (but I don't see this happening).

:shipit:

Changing the target to branch release-cpptools


Support Configurable Paths for Reporters

HtmlReporter should provide a way to set the output directory instead of using a hardcoded value
    /** Output directory */     private static final String OUTPUT_DIRECTORY = "test-output" + File.separator + "citrus-reports";

Fixed! You can customize the reporter using properties:
citrus.html.report.enabled: Enables/disables HTML report generation (default=true).
citrus.html.report.directory: Output directory path (default=${project.build.directory}/test-output/citrus-reports).
citrus.html.report.file: File name for the report file (default=citrus-test-results.html).
citrus.html.report.template: Template HTML file with placeholders for report results.
citrus.html.report.detail.template: Template file for detailed test results.
citrus.html.report.logo: File resource path pointing to a image that is added to top of HTML report.


Rename hasTextContaining() to includesText()

Refactors hasTextContaining() to includesText()
Adds containsText() as an alias for includesText();
Generates docs;

sweeeet! 😍

do you think you could also adjust https://github.com/simplabs/qunit-dom-codemod accordingly?

@Turbo87 I'll take a look at it this evening!


Improve and tests

Purpose
This PR sets adds unit tests for the python codebase with test coverage 81%. It also adds data classes for the response that follows the Microsoft Chat Protocol. It also fixes some typing errors and improves the workflow for code quality analysis.

Does this introduce a breaking change?
[ ] Yes
[x] No

Type of change
[ ] Bugfix
[ ] Feature
[x] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Code quality checklist
See CONTRIBUTING.md for more details.

[x] The current tests all pass (python -m pytest).
[x] I added tests that prove my fix is effective or that my feature works
[x] I ran python -m pytest --cov to verify 100% coverage of added lines
[x] I ran python -m mypy to check for type errors
[x] I either used the pre-commit hooks or ran ruff manually on my code.

The test setup for the database still needs work.

Thanks for the PR! Unfortunately been too busy with conferences and streams, but I will take a look as soon as I get a chance. I'm excited about all the improvements!

@john0isaac
I made a few typing improvements. Mypy seems to be confused by the editable app install, and I'm not sure how to make it happy.
There's also an issue with SQLAlchemy on these lines:
sql = text(fulltext_query).columns(id=Integer, rank=Integer)
I'm not sure what the issue is there. We could punt on making mypy happy, as I said in a comment, or we could spend a little more time trying to get the rest of the errors away, possibly via configuring what to ignore.

Let me take a look and see what I can do.
I will let you know what I reach here.

I asked about SQLAlchemy issue here: https://github.com/sqlalchemy/sqlalchemy/discussions/11600

Asked pgvector for type annotation support here:
https://github.com/pgvector/pgvector-python/issues/82
I think we should ignore pgvector in pyproject.toml for now.

The other issue is: "tests/conftest.py:225: error: Cannot instantiate abstract class "MockAzureCredential" with abstract attributes "aexit" and "close"  [abstract]"
I'm surprised to see that error as that's the same mock as azure-search-openai-demo, and I don't see the same error there.

The other issue is: "tests/conftest.py:225: error: Cannot instantiate abstract class "MockAzureCredential" with abstract attributes "aexit" and "close" [abstract]"
I'm surprised to see that error as that's the same mock as azure-search-openai-demo, and I don't see the same error there.

How can I reproduce this error?
Maybe it's this line that I changed?
Original

What I changed

I made a few typing improvements. Mypy seems to be confused by the editable app install, and I'm not sure how to make it happy.

fixed here https://github.com/Azure-Samples/rag-postgres-openai-python/pull/55/commits/addd3dafe6fadc4c299884f5930bf14c8d70b475

The other issue is: "tests/conftest.py:225: error: Cannot instantiate abstract class "MockAzureCredential" with abstract attributes "aexit" and "close" [abstract]"
I'm surprised to see that error as that's the same mock as azure-search-openai-demo, and I don't see the same error there.

AsyncTokenCredential is a Protocol
You just had to reimplement the functions in it's children without changing anything lol.

Asked pgvector for type annotation support here: pgvector/pgvector-python#82 I think we should ignore pgvector in pyproject.toml for now.

Done here https://github.com/Azure-Samples/rag-postgres-openai-python/pull/55/commits/39abb0fa8c7fede9987843eeacd9a1870bfe15c0

I asked about SQLAlchemy issue here: sqlalchemy/sqlalchemy#11600

In the sqlalchmey docs, there are two ways of doing this:
First Option / Passes mypy I tested it and pushed it here https://github.com/Azure-Samples/rag-postgres-openai-python/pull/55/commits/121b3417c509ff41f6aa893bf3bf348e40d5d4f9
stmt = text("SELECT id, name, timestamp FROM some_table")
stmt = stmt.columns(
            column('id', Integer),
            column('name', Unicode),
            column('timestamp', DateTime)
        )

for id, name, timestamp in connection.execute(stmt):
    print(id, name, timestamp)

Second Option / Original code - not working with mypy
stmt = text("SELECT id, name, timestamp FROM some_table")
stmt = stmt.columns(
            id=Integer,
            name=Unicode,
            timestamp=DateTime
        )

for id, name, timestamp in connection.execute(stmt):
    print(id, name, timestamp)

this https://github.com/Azure-Samples/rag-postgres-openai-python/pull/55/commits/5c17e9a404e772a40d24562c34aeb52f97441d13 fixes all of the errors related to mypy and the global_storage, it also follow the FastAPI way for creating application dependencies, the tests are faster now (I don't know why lol) maybe because I moved all of the code from the app startup 🤔
I created the routes folder to remove the noqa and to also follow the FastAPI app structure the rest of the files in the fastapi_app folder needs to be organized in folders too but I didn't want to make that change here too as it's not gonna affect anything.
I'm working on the last mypy error and will add mypy to the workflow run after I fix it.

@pamelafox I did it 🎉
All the errors are fixed and we are not using any type: ignore, tests are passing, app is working.
I also added mypy to the app_tests workflow as it requires a full installation of the packages (can't be added with ruff)

@john0isaac Nice work making mypy happy, that's a tall feat. I have a few questions about possibly redundant calls.

There is only one issue left.. the engine is being created with each db_session which is being created with each request. It's not affecting the performance much but I wanted to raise it to you.
I will work on it tomorrow, maybe in another PR if you merged this one or here.
I tried solving this and I did it the same way you'd create an engine with FastAPI. (they just define it as a variable not inside a function in the dependencies folder) saying that our engine creation function is an async func which can't be used outside an event loop (tried workarounds for that using asyncio but nothing worked)
finally, I changed all of the function related to dealing with Postgres to become normal not async and everything worked.
But all of the tests failed 🤣 I tried to do a bunch of stuff for the tests to fix it but I came across lots of async errors and even when it worked there were some dangling background tasks for tests (tests were randomly passing and the tests that don't get a db session I think were failing)

Ah, I see, thanks for raising that. It'd be best if we can reuse a session, like Flask-SQLAlchemy-Lite does: https://flask-sqlalchemy-lite.readthedocs.io/en/latest/session/
I do think it's less obvious how to architect app globals in FastAPI apps than in Quart/Flask apps, it's been interesting.
We're not in a rush to merge this, so I'll keep it open.

session won't work, that was my first go to.
only accessible from request.session.something which is gonna be only available at the endpoint, I also looked at the globals for them and they have something called app.state which you can store stuff inside not the application level but it won't be initialized until the app get initialized which means that we can't use it in creating sessions.
After reconsidering everything I'm thinking of reusing the lifespan and globals approach for application wide global vars as it will work with the dependency I think. That is most likely what I will do if I didn't find a solution for the engine issue.
I will keep you posted here.

Done ✅
I combined between the app.states and the dependencies and it looks amazing, everything is now created once in the lifespan then accessed from there. It's looking great! I'm satisfied with this now. 😄
I also created the item data model that matches the db table (db table class is not usable as it's not a valid pydantic type) this now types the whole api.

All of the endpoints has example responses now.

Cool! I just learnt about Depends. Seems like a nice pattern for FastAPI.


How to preselect an item?

Hi there,
I was wondering if it is possible to set the first in the datasource as selected when it loads?

It's on Readme: You can manually (pre)select a row with: dropDown.selectRow(at: 3)

Could we show selected row in preview view in case the dropdown not show


Allow TIM2 to remap to ETH_PTP even if TIM8 is present

This aligns with the manual and 9dd5bce
IMPORTANT INFORMATION
Contributor License Agreement (CLA)

The Pull Request feature will be considered by STMicroelectronics after the signature of a Contributor License Agreement (CLA) by the submitter.
If you did not sign such agreement, please follow the steps mentioned in the CONTRIBUTING.md file.

ST Internal Reference: 199457


install bootstrap with import maps

Prerequisites

[X] I have searched for duplicate or closed issues
[X] I have validated any HTML to avoid common problems
[X] I have read the contributing guidelines

Describe the issue
when installing bootstrap I install the css from the gem and install javascript using importmaps
If I do this ./bin/importmap pin<EMAIL_ADDRESS>it pins bootstrap and popper and works in the application if I use import "bootstrap". in application.js
Bootstrap and functions that use popper work in the application
if I use a different version of boot strap it does not ./bin/importmap pin<EMAIL_ADDRESS>bs_test.zip (Edited by maintainer: please don't upload zip files, won't take the risk to open them)
Reduced test cases
i think its internal
What operating system(s) are you seeing the problem on?
macOS, Linux
What browser(s) are you seeing the problem on?
Chrome, Safari, Microsoft Edge
What version of Bootstrap are you using?
5.2.2

I don’t use either of those systems
Good luck living ith your bugs

On 18 Apr 2023, at 19:58, github-actions[bot] @.***> wrote:
Hello @Russell108 https://github.com/Russell108. Bug reports must include a live demo of the issue. Per our contributing guidelines https://github.com/twbs/bootstrap/blob/main/.github/CONTRIBUTING.md, please create a reduced test case on CodePen https://codepen.io/ or StackBlitz https://stackblitz.com/ and report back with your link, Bootstrap version, and specific browser and Operating System details.
—
Reply to this email directly, view it on GitHub https://github.com/twbs/bootstrap/issues/38449#issuecomment-1513655046, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEYL33KAVS7BPF4DERFKPDXB3P5JANCNFSM6AAAAAAW3ZTUZ4.
You are receiving this because you were mentioned.


Unexpected Groovy syntax highlight for Jenkinsfile.tsx

Type: Bug

Create a file named "Jenkinsfile.tsx"
Write regular React TypeScript scripts.
The source code is highlighted as Groovy, which should have been TSX

VS Code version: Code 1.80.2 (Universal) (2ccd690cbff1569e4a83d7c43d45101f817401dc, 2023-07-27T21:05:41.366Z)
OS version: Darwin arm64 22.5.0
Modes:

System Info

Item
Value

CPUs
Apple M1 (8 x 24)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
5, 7, 7

Memory (System)
16.00GB (0.13GB free)

Process Argv
--crash-reporter-id d8a6592f-2241-4ef9-a60f-5fbf895c504b

Screen Reader
no

VM
0%

Extensions (1)

Extension
Author (truncated)
Version

vscode-language-pack-zh-hans
MS-
1.80.2023071209

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492:30256859
vslsvsres303:30308271
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vsdfh931cf:30280410
vshan820:30294714
vstes263:30335439
vscorecescf:30445987
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
pythonvs932:30410667
py29gd2263cf:30792227
vsclangdf:30486550
c4g48928:30535728
dsvsc012cf:30540253
pynewext54:30695312
azure-dev_surveyone:30548225
vscccc:30803845
2e4cg342:30602488
89544117:30613380
a9j8j154:30646983
showlangstatbar:30737416
vsctsb:30748421
pythonfmttext:30731395
pythoncmv:30756943
fixshowwlkth:30771522
showindicator:30805244
pythongtdpath:30769146
i26e3531:30792625
gsofb:30804716
pythonnosmt12:30797651
pythonidxptcf:30805731
pythonnoceb:30805159
e537b577:30795824
dsvsc013:30795093
dsvsc014:30804076

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.81.0. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

This is because of this:
https://github.com/microsoft/vscode/blob/67ea2e95eb3f17ac07e4f759e51bce76da9697dc/extensions/groovy/package.json#L29-L33

Thanks @TylerLeonhardt for figuring that out. Looks like Jenkins configuration file typically start with Jenkinsfile so we have that association rule. A file name match wins against the extension match.
The rule has been there for a while and I'm not aware of requests to remove it due to false matches. That's why, for now, I wouldn't take any action.
@SevenOutman You can overwrite that default by having the following setting
	"files.associations": {
		"jenkinsfile.ts": "typescript"
	}

Looks like Jenkins configuration file typically start with Jenkinsfile so we have that association rule. A file name match wins against the extension match.
@SevenOutman You can overwrite that default by having the following setting
	"files.associations": {
		"jenkinsfile.ts": "typescript"
	}

@aeschli Thanks for your reply. I understand that a file name match is reasonable as users may have multiple Jenkinsfiles for different scenarios, e.g. multiple environments
- Jenkinsfile.prod
- Jenkinsfile.qa

But IMHO an extension that is a known language type should take precedence, and users that want to regard a file with a known language extension as a different file type should be overwriting default settings.

The rule has been there for a while and I'm not aware of requests to remove it due to false matches.

I guess it's not because users having this issue thinking it's unnecessary to fix, but not many users are having this issue - it's a not-so-everyday (yet reasonable) use case. My actual use case is that I'm creating this React component that acts as a page of my application where user reviews a Jenkinsfile.
There will eventually be the first request anyway, and here is it :) And actually I'm not requesting to remove the file name match rule, but to modify it so that the extension match takes precedence. I'm also willing to contribute if you're open to it.

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


Cannot set Task.statusReason in Medplum App

Repro

Open Medplum App
Navigate to Task
Click New
Enter a value for statusReason
Save

Observed Behavior
No statusReason saved to task
Expected Behavior
statusReason input either presents a dropdown of option, or allows a user to input their own.
User input value should be saved as a CodeableConcept with a text element

This is a bug in AsyncAutocomplete, I'll take it.
Task.statusReason does not have a binding, and then never triggers the "+ Create" code path.


Invalid SPDXID

Describe the bug
An SPDXID cannot contain underscores.
Tern generates:
SPDXID: SPDXRef-ncurses-terminfo-base-6.2_p20210109-r0

To Reproduce
Steps to reproduce the behavior:
tern report -f spdxtagvalue -i fsfe/reuse:latest -o reuse.spdx

Error in terminal
none

Expected behavior
SPDXID should be valid. Replace "_" with e.g. "-".
Environment you are running Tern on
Enter all that apply

Output of 'tern --version'

Tern version 2.9.1

   python version = 3.9.7 (default, Sep 10 2021, 14:59:43)

Operating System: Ubuntu 21.10

Ah, this is because the package version has an underscore in it. I can fix it. Thanks for opening, @vargenau .


Update QaSchemaIT using TestKit [ECR-3054]

Overview
Update QaSchemaIT using TestKit.

See: https://jira.bf.local/browse/ECR-3054
Definition of Done

[x] There are no TODOs left in the code
[x] Change is covered by automated tests
[x] The coding guidelines are followed
[x] Public API has Javadoc
[x] Method preconditions are checked and documented in the Javadoc of the method
[x] Changelog is updated if needed (in case of notable or breaking changes)
[ ] The continuous integration build passes

Coverage remained the same at 86.259% when pulling dd014b1eddbbf81d1f0bdc46965d3c0bb9e05e60 on ECR-3054-QA into 16087f8102ce8126d47dcf554f445267e3ad0524 on master.

Shall we use testkit here as we don't rely on any of its operations? It helps, however, to get rid of the Cleaner instantiation. Maybe, to make MemoryDb easier to use, we shall add withSnapshot to it, shan't we?

I prefer using TestKit for consistency and replace MemoryDb with it when possible.

:ok_man: , though MemoryDb is also good as its use doesn't violate local consistency :upside_down_face:


network rm (via API & UI) must fail for reserved networks

Reserved networks such as (bridge, none and host) should not honor network rm.

I could help on this any hints where to focus ?

@codergr thanks. @nerdalert beat you to it :)
We have no short of issues to handle, will check with you @codergr

Closed in #208


set LIBSPDM_DEBUG_LIBSPDM_ASSERT_CONFIG=0 to avoid ASSERT_DEADLOOP.

Get the test result by checking the return value of test program.
Add a new command 'copy_seed' to copy the seed files.
Enable the basic test with initial seed.
Signed-off-by: Zhao, Zhiqiang<EMAIL_ADDRESS>

Just for test, no need merge, so close it.


Adding CosmosDB Javascript template

This change adds a Cosmos DB Trigger template for Javascript/Node

@ealsur,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot


NFC Tool: Example Updated

NFC Tool example updated as per the changes made in the FusionNFC library.

This FusionNFC app is tested by @bulantsevajo and it works fine.


get user email fix

This would fix getting a user email

This does not fix it!
What if you restart your application? Where this email will be stored?

Read http://docs.spring.io/spring-social/docs/1.0.x/reference/html/serviceprovider.html JDBC-based persistence. We need to store email as we do it with accessToken.

Why should we store an email ?
This give us an opportunity to fetch an email with user profile ( not it's returned null )

We need to store it to be consistent with the rest of the data that we retrieve while logging in.
How do you want to describe behaviour of getEmail method?

"Well guys, you know, sometime this method returns user email, but if you restart your application it will not." :)

Thanks, @spereverziev. It works even after application restart.

Hello, guys!
Any way to get merged this commit to main repository?
https://github.com/RomanSyroeshko/spring-social-vkontakte/commit/2cba070094169ec35a985ac0327b6a1cc813d1d3

yeah it works good, thx
to get changes just fork repo and apply this fix

This fix is really necessary. Could you merge it to master, please, or implement another solution.

Fixed with latest version, see https://github.com/vkolodrevskiy/spring-social-vkontakte/issues/19


Added support for the partial and static modifier in methods

Codecov Report

Merging #66 (4f86772) into main (7a7df8a) will increase coverage by 0.76%.
The diff coverage is 99.60%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
+ Coverage   98.87%   99.63%   +0.76%
==========================================
  Files          30       28       -2
  Lines         266      546     +280
==========================================
+ Hits          263      544     +281
+ Misses          3        2       -1

Impacted Files
Coverage Δ

...CodeGen.Core/TemplateLoaders/FileTemplateLoader.cs
100.00% <ø> (ø)

...er.Commons.StringHelpers/CasingStringExtensions.cs
100.00% <ø> (ø)

...CodeGen.CSharp/Model/CSharpConstructorParameter.cs
90.00% <90.00%> (ø)

...apping.Avro/Mappers/AvroModelsCompilationMapper.cs
97.05% <97.05%> (ø)

...ure.DataAttributes/AutoNSubstituteDataAttribute.cs
100.00% <100.00%> (ø)

...tler.Commons.CodeGen.CSharp/CSharpCodeGenerator.cs
100.00% <100.00%> (ø)

...ler.Commons.CodeGen.CSharp/CSharpTemplateLoader.cs
100.00% <100.00%> (ø)

...antler.Commons.CodeGen.CSharp/Model/CSharpClass.cs
100.00% <100.00%> (ø)

....Commons.CodeGen.CSharp/Model/CSharpCompilation.cs
100.00% <100.00%> (ø)

....Commons.CodeGen.CSharp/Model/CSharpConstructor.cs
100.00% <100.00%> (ø)

... and 18 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Update versions according to Docker hub images

Use the latest versions of docker images for some components. Depends on #86
Docker hub link - https://hub.docker.com/u/radarcns/
Created new releases for RADAR MongoDB Sink Connector 0.1 and RADAR Backend 0.1.

@blootsvoets i have made the changes. Can you review again please ?
Thanks.


⚠ Bofrost.lu has degraded performance

In 2ba839d, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1800 ms

Resolved: Bofrost.lu performance has improved in f6ebbdb after 15 minutes.


vLLM support for FAQGen

Description
Added langchain vLLM support for  Faq-Generation. Added new folder called vllm under faq-generation and have maintained the same file structure similar to tgi. Dockerfile, compose yaml and README contains details about how to build and use FaQ with vLLM.
This also contains changes related to authentication support for remote vLLM endpoints in llm.py file.
Since model is mandatory parameter for vLLM updated the FaqGenGateway to include the new parameter called "model" in Mega service gateway.py file
Issues
N/A
Type of change

[x] New feature (non-breaking change which adds new functionality)

Dependencies
N/A

@sgurunat,
Please update comps/llms/faq-generation/vllm/langchain/Dockerfile to .github/workflows/docker/compose/llms-compose-cd.yaml. The yaml is used for release images build.

@chensuyue @lvliang-intel Updated the git workflows to include vllm faqgen build in llm-compose.yaml file

at next release, we need consider how to merge such instances with others to avoid code duplication.


Default codon tables

We should add default codon tables of the following organisms:

Escherichia coli MG1655
Bacillus subtilis 168
Vibrio natriegens (whatever type strain)
Saccharomyces cerevisiae BY4741/BY4742 (used for knockdown collections)
Yarrowia lipolytica (apparently used quite a bit in production, use type strain)
Pichia pastoris NRRL Y-7556
Kluyveromyces marxianus NRRL Y-6860 (it zoom speed yeast)
Homo sapiens (kinda yucky)

Just the type strain genomes. I've suggested a few of them above.

@Koeng101 you mean something like this package ?
https://github.com/Edinburgh-Genome-Foundry/codon-usage-tables/tree/master/python_codon_tables

Depends on #313, so deprioritizing for now and upping priority there


Segresnet algo update to re-save input config.

Segresnet algo update to re-save input config with auto adjustments upon training.

/integration-test

https://github.com/Project-MONAI/research-contributions/actions/runs/5000635172/jobs/8958284563
Test looks good to me.


Fields also validated when deleting resource

When deleting a resource, the fields on the resource are also validated. Validation fails and makes my resource not deletable:

Solution is here: https://laraveljsonapi.io/docs/1.0/requests/resources.html#helper-methods
Documentation should be updated to reflect this.

The relevant sections of the docs did already have tips about exactly this scenario. I've changed those tips to warnings so they are more prominent, plus updated the withValidator() examples to show it using the isCreatingOrUpdating() helper method - which is a more accurate example:
/**
 * Configure the validator instance.
 *
 * @param \Illuminate\Validation\Validator $validator
 * @return void
 */
public function withValidator($validator)
{
    if ($this->isCreatingOrUpdating()) {
        $validator->after(function ($validator) {
            if ($this->somethingElseIsInvalid()) {
                $validator->errors()->add(
                  'field',
                  'Something is wrong with this field!'
                );
            }
        });
    }
}


Ignore scan of same RFID id within 2 seconds

Solves https://github.com/MiczFlor/RPi-Jukebox-RFID/issues/910
This allows you to leave an RFID card on the reader without triggering any unwanted action - especially not the "second swipe" action.
Without this change you have to set the second swipe option to do nothing if you want to have the ability (or phoniebox case form factor that does not prevent you) to leave the card on the reader.
The time of 2 seconds between swipes is chosen at random. Possibly this could be controlled via a setting. For RC522 readers, this is more than enough since it (or its library) reports the scanned ID ever 100ms or so..

Hi @jo-me
if I understand correctly, you set the value to the delay variable to 2 for this pull request and deleted the line 47 where previous time previous_time = time.time() is set again in the while loop.
Can you walk me through: why delete previous_time = time.time() is necessary?

So, like I wrote above, the 2 seconds are chosen arbitrarily. Depends on how much time you want to allow between first and second scan.
The previous_time variable holds the last time a given tag ID was scanned. Before the PR it was updated only in the IF block, so when either a different ID was scanned or the same_id_delay was exceeded (0 before PR, so always if same ID was scanned twice).
However, if you actually set a delay and you scan the same ID a second time withing the given delay, the ELSE block is executed, so the previous_time was not updated anymore resulting producing a second scan if the same card is left on the reader for more than 2 seconds, which is not desirable in my opinion.
So, the previous_time needs to be updated in IF and ELSE, right? That's why I moved it outside of the block.

@jo-me I tested your workaround for the 2 second delay. Basically it's working, but I have to say, that one and the same card is resetting the delay back to 2 seconds, when the delay before hat not yet expired.
So your workaround prevents also from scanning a card again which is not removed from the rfid reader for more than the delay time.

This is fine, but the user has to know that the card MUST be removed, to let the delay time pass.

I'd say that it only makes sense to HAVE to remove the card in order for a second swipe to be detected.
You can of course dial down on the 2 seconds, but enforcing an actual second swipe (with a period where no card is detected in between) is essential to prevent misfirings of the 2nd swipe setting.

Hi @jo-me @princemaxwell @s-martin
I will close this pull request and merge #1030 which  has this one included.


How can I retrieve metrics from training and testing

❓ Questions and Help
How can I extract the metrics returned from training_step, training_epoch_end, validation_step, validation_epoch_end, test_step, test_epoch_end after a train() or a test() run?
I'd like to return some dictionary (e.g. {'loss': ..., 'log': ..., 'param a: 'a', 'param b': 'b', 'param c': {...}}) from e.g. test_epoch_end and retrieve this after calling trainer.test(net). It seems like the data is available some where, as the Weights and Biases logger prints at least the training metrics before uploading. Where can I find those metrics from training and testing?

It seems it's a duplicate. See #1694 .
BTW, If you need just postprocessing, I hacked this problem by putting everything (including plotting, I/O, etc.) in test_epoch_end . I think it's not best practice but I also couldn't find any method to get the test result.
I just write the file that records what I need. After then, I write another script to process the file. I wish this helps you.


UML-1507 : Changes that dashboard doesn't break when donor date of birth is  missing

Purpose
https://opgtransform.atlassian.net/browse/UML-1507
Fixes UML-1507
Approach
Explain how your code addresses the purpose of the change
Learning
Any tips and tricks, blog posts or tools which helped you. Plus anything notable you've discovered about the Use a Lasting Power of Attorney service
Checklist

[X] I have performed a self-review of my own code
[ ] I have added relevant logging with appropriate levels to my code
[ ] I have updated documentation (Confluence/GitHub wiki/tech debt doc) where relevant
[X] I have added tests to prove my work
[ ] I have added welsh translation tags and updated translation files
[ ] I have run an accessibility tool on any pages I have made changes to and fixed any issues found
[ ] The product team have tested these changes

When users create a code and give it to an organisation, the LPA summary on the viewer side will either break or the donors DOB will be blank. I'm not sure how organisations will feel about this and whether it means the LPA can still be used. I think we need to go back to Sarah and see how we'd like to deal with this

The viewer side  [and the actor side] would not break, but would show a blank entry for the dob.
This has been discussed [with Jude in Sarah's absence] and I think for now, business is OK with a blank entry  for DB in view summary[Than have a breaking dashboard on the actor side].Is mentioned in the ticket I think.
What Jude mentioned to me was the new ticket 1588 would be the new feature to make users aware and be proactive.
I also think it's a data cleansing  activity which is in discussion.


Rework of ThingSet CAN subsystem

This rework PR fixes a few issues:

Make all required data was instance-specific to avoid any data races.
Add single-instance mode for simple applications, running automatically in a thread in the background.
Use _inst suffix for functions supporting multiple CAN instances.
Use work queue of the ThingSet SDK instead of the system work queue.
Offload address-claiming to work queue to avoid sending a CAN frame from an ISR context, which is not allowed.
Allow processing of received reports by the application (useful for control applications).

Looks good! :)


Added skip blank feature.

Skip blank fields on create/update
You are able to skip blank fields (like password, and password_confirmation) for form settings
on update or create action:
form:
  display: [name, password, password_confirmation]
  skip_blank: [password, password_confirmation]

The feature can be useful when user admin wish not to change a password of a user record, but
the user model validates that password must be not null.

is it really worth it?
  # user model
  validates_presence_of     :password, if: :password_required?
  validates_confirmation_of :password, if: :password_required?

  def password_required?
    crypted_password.blank?
  end

What should do crypted password? I no specific settings for password, just ones derived from devise.

it's the database field where the password is stored, so it's only required if the user has no password, i think same could be done with new_record? there are also hooks that will give you all the params to your model and you can do very crazy things. Adding validation to the bhf.yml doesn't scale, it will never end, we will need to add skip_blank_for_new, skip_blank_for_persisted, skip_blank_for_hidden, skip_blank_for_unsorted ect


[Question] Is this a usecase for django-pgtrigger?

Hi there,
I need to make a pg trigger and I am using Django 2.2
the use case is like this:

i have auto primary key id is integer in the table called teams
i have another field called business_identifier that needs to be based on id value like this "TEAM000007"

I wanted to use trigger to autogenerate the values for business_identifier based on the id.
So if I insert a new row, the auto primary key will auto fill in the id and i hope that the business_identifier will also auto update.
I have the sql code for postgres
CREATE OR REPLACE FUNCTION team_insert() RETURNS trigger AS $emp_stamp$
     BEGIN
         NEW.business_identifier:= 'TEAM' || LPAD(NEW.id::text, 6, '0');
         RETURN NEW;
     END;
$emp_stamp$ LANGUAGE plpgsql;

CREATE TRIGGER team_insert BEFORE INSERT OR UPDATE ON teams FOR
 EACH ROW EXECUTE PROCEDURE team_insert();

How do I do this using django-pgtrigger?

Without testing it, perhaps something like:
@pgtrigger.register(
    pgtrigger.Trigger(
        name='set_team_identifier',
        operation=pgtrigger.Update | pgtrigger.Insert,
        when=pgtrigger.Before,
        func='NEW.business_identifier:= 'TEAM' || LPAD(NEW.id::text, 6, '0'); RETURN NEW;',
    )
)
class YourModel(Model):
    ....

That said, there's also a new feature in PG 12 called "generated column" (https://www.postgresql.org/docs/12/ddl-generated-columns.html) which might do the trick for you. Unfortunately, there's no Django ORM support for those as far as I know (there's been some talk on it, but I really haven't dug in: https://code.djangoproject.com/ticket/31565).
As an alternative I'd also try push back on it as much as possible and see if there are some alternative ways to get around it (i.e. ask your analysts/engineers to find ways to use the ID column directly) - but there may be totally valid reasons for why this isn't feasible. I always get a bad feeling when I'm asked to add data redundancy like this, but sometimes one just gotta do it :)
Hope this helps!

I'll give this a shot later today or tomorrow
As for checking whether it's necessary I agree that's the bigger question
I was reluctant to add this field to be frank but it seems required for now

I'll give this a shot later today or tomorrow
As for checking whether it's necessary I agree that's the bigger question
I was reluctant to add this field to be frank but it seems required for now

Yeah - sometimes it's really just the best way forward for now.. Bit of redundancy could end up saving a lot of time for other people/groups and give some clarity as well. I know that in my main project, I for sure got plenty of that going around :)
Feel free to ping me if you can't it working!

Feel free to ping me if you can't it working!

@tomage I think this doesn't really work. Not sure where I went wrong.
Django 2.2.19
pgtrigger 2.3.0
postgres 10.13
@pgtrigger.register(
    pgtrigger.Trigger(
        name="set_warehouse_business_identifier",
        operation=pgtrigger.Update | pgtrigger.Insert,
        when=pgtrigger.Before,
        func="NEW.business_identifier:= 'WH' || LPAD(NEW.id::text, 6, '0'); RETURN NEW;",
    )
)
@reversion.register()
class Warehouse(
    ComputedFieldsModel,
    DirtyFieldsMixin,
    TimeStampedModel,
    SoftDeletableModel,
    PersonStampedModel,
    OrganizationOwnedModel,
):

    # making this nullable might make it easier to do the postgres trigger on create-update
    business_identifier = models.CharField(
        max_length=255, editable=False, unique=True, null=True
    )
    name = models.CharField(max_length=255)
    address = models.TextField()

the migration file was
# Generated by Django 2.2.19 on 2021-03-18 05:54

import computedfields.resolver
import dirtyfields.dirtyfields
from django.conf import settings
from django.db import migrations, models
import django.db.models.deletion
import django.utils.timezone
import model_utils.fields

class Migration(migrations.Migration):

    dependencies = [
        ('organizations', '0007_auto_20190925_0313'),
        migrations.swappable_dependency(settings.AUTH_USER_MODEL),
        ('rea', '0126_auto_20210317_0723'),
    ]

    operations = [
        migrations.CreateModel(
            name='Warehouse',
            fields=[
                ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
                ('created', model_utils.fields.AutoCreatedField(default=django.utils.timezone.now, editable=False, verbose_name='created')),
                ('modified', model_utils.fields.AutoLastModifiedField(default=django.utils.timezone.now, editable=False, verbose_name='modified')),
                ('is_removed', models.BooleanField(default=False)),
                ('business_identifier', models.CharField(editable=False, max_length=255, null=True, unique=True)),
                ('name', models.CharField(max_length=255)),
                ('address', models.TextField()),
                ('is_used', models.BooleanField(default=False)),
                ('created_by', models.ForeignKey(editable=False, null=True, on_delete=django.db.models.deletion.CASCADE, related_name='created_rea_warehouse', related_query_name='query_created_rea_warehouses', to=settings.AUTH_USER_MODEL)),
                ('forked_from', models.ForeignKey(default=None, null=True, on_delete=django.db.models.deletion.DO_NOTHING, related_name='forks', to='rea.Warehouse')),
                ('modified_by', models.ForeignKey(editable=False, null=True, on_delete=django.db.models.deletion.CASCADE, related_name='last_edited_rea_warehouse', related_query_name='query_last_edited_rea_warehouses', to=settings.AUTH_USER_MODEL)),
                ('organization', models.ForeignKey(editable=False, null=True, on_delete=django.db.models.deletion.CASCADE, related_name='rea_warehouse_organization', to='organizations.Organization')),
            ],
            options={
                'ordering': ('business_identifier',),
            },
            bases=(computedfields.resolver._ComputedFieldsModelBase, dirtyfields.dirtyfields.DirtyFieldsMixin, models.Model),
        ),
    ]

@simkimsia I know this issue is a bit old, but can you clarify what went wrong and if you are still experiencing it? Currently django-pgtrigger does not install triggers in migrations, so it will not appear in a migrations file. We are working towards making it compatible with django migrations in the future though. For now, just manage.py migrate will install the registered triggers.
I believe the example @tomage gave should have worked if your previous trigger definition was working

It doesn't work but the need for this has also gone down for the time being. In this case, I will temporarily close this issue and revisit it when the need for this goes back up again.
Thank you @wesleykendall


Javascript Librarys/framework updates

I have a long list of updates of javascript related files that will be getting updated from now into 3.42

KCFinder will be updated in 3.42.00


Add support for Wasm plugin

My attempt at updating the extension to support being included in WasmPlugin
Most likely this means that it will stop working with SME (which is now deprecated anyway)

This should work on boht SME and WASMPlugin now, but it is a bigger change because WasmPlugin requires only one layer so we can have only one COPY command, so I separated the original directory and the crd deployment examples


[TEST][FLAKY] test_auo_scheduler_layout_rewrite

=================================== FAILURES ===================================
__________ test_correctness_layout_rewrite_rewrite_for_preTransformed __________

    @tvm.testing.requires_llvm
    def test_correctness_layout_rewrite_rewrite_for_preTransformed():
        N = 128
        target = tvm.target.Target("llvm")
        task = auto_scheduler.SearchTask(func=matmul_auto_scheduler_test, args=(N, N, N), target=target)
        dag = task.compute_dag

        with tempfile.NamedTemporaryFile() as fp:
            log_file = fp.name

            search_policy = auto_scheduler.SketchPolicy(task)

            measure_ctx = auto_scheduler.LocalRPCMeasureContext()
            tuning_options = auto_scheduler.TuningOptions(
                num_measure_trials=2,
                runner=measure_ctx.runner,
                verbose=2,
                measure_callbacks=[auto_scheduler.RecordToFile(log_file)],
            )
            task.tune(tuning_options, search_policy=search_policy)
            inp, _ = auto_scheduler.load_best_record(log_file, task.workload_key, target)
            s, bufs = dag.apply_steps_from_state(
>               inp.state, layout_rewrite=auto_scheduler.LayoutRewriteOption.REWRITE_FOR_PRE_TRANSFORMED
            )
E           AttributeError: 'NoneType' object has no attribute 'state'

tests/python/unittest/test_auto_scheduler_layout_rewrite.py:89: AttributeError
=============================== warnings summary ===============================

https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/main/625/pipeline

cc @comaniac @merrymercy

This happens when no valid schedules can be applied (load_best_record returns None in this case). Maybe in the i386 machine it's easy to get timeout and results in this error. We could consider either of the following:
A. Only perform this test on x86.
B. Improve this test by mocking a valid record.
@merrymercy which one do you prefer or do you have other suggestions?

I remember we had this problem before @jcf94

We can use this tuning option to make sure we always get a valid schedule. It will try at most 100 schedules but stops immediately when we get a valid one.
https://github.com/apache/tvm/blob/51dc332646d90b77ae29e2e2dbe21f40008a0082/tests/python/relay/test_auto_scheduler_tuning.py#L42-L44

I'm afraid that this would make the CI time longer especially on slower machines such as i386.

How about to set a smaller N?

Combining the above ideas, I'll file a PR to

Reduce the workload size (i.e., N) from 128x128 to 16x16.
Enlarge trial number to 100 with early_stopping=1.


[AIRFLOW-2753] Add dataproc_job_id instance var holding actual DP jobId

Make sure you have checked all steps below.
JIRA

[x] My PR addresses the following Airflow JIRA issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-2753
In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a JIRA issue.

Description

[x] Here are some details about my PR, including screenshots of any UI changes:
See https://issues.apache.org/jira/browse/AIRFLOW-2753

Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:

{{tests/contrib/operators/test_dataproc_operator.DataProcHadoopOperatorTest.test_dataproc_job_id_is_set}}
{{tests/contrib/operators/test_dataproc_operator.DataProcHiveOperatorTest.test_dataproc_job_id_is_set}}
{{tests/contrib/operators/test_dataproc_operator.DataProcPySparkOperatorTest.test_dataproc_job_id_is_set}}
{{tests/contrib/operators/test_dataproc_operator.DataProcSparkOperatorTest.test_dataproc_job_id_is_set}}

Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Documentation

[x] In case of new functionality, my PR adds documentation that describes how to use it.

Updated docstrings with appropriate var and vartype items.

Code Quality

[x] Passes git diff upstream/master -u -- "*.py" | flake8 --diff

I assume that an cli status of 0 means that the above passes.

Codecov Report

Merging #3622 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3622      +/-   ##
==========================================
+ Coverage   77.13%   77.14%   +<.01%
==========================================
  Files         204      204
  Lines       15733    15733
==========================================
+ Hits        12136    12137       +1
+ Misses       3597     3596       -1

Impacted Files
Coverage Δ

airflow/models.py
88.56% <0%> (+0.04%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52c745d...46b5a5a. Read the comment docs.


Pull request try #2

Hopefully this works this time... I cannot seem to find where I am going wrong.

Ok, so Andre's suggestion here is WRONG -- you shouldn't ever have to fork again and doing so will overwrite your own repository. What you need to do is pull from the main repository: git pull https://github.com/EcoForecast/TeamGOATS master. Indeed, Kelly didn't even need to close her earlier pull request. Other people have changed the same file and those changes will need to be resolved with the changes she's made. From git's perspective it's seeing multiple edits to the same lines in a file and it can't figure out which version of the edits is correct, so it's telling you that it needs to be sorted out manually. Sometimes file conflicts are unavoidable, so learning how to resolve them is an important lesson! That said, at other times file conflicts can be avoided by merging pull requests promptly.
GENERAL LESSON TO EVERYONE: alway do a git pull from the OWNER before pushing to github and submitting a pull request to insure that your code is up-to-date with the latest code.


Feat/add proper logging

related to this Issue

PR-Codex overview
This PR introduces additional logging throughout various command files in the eo2js project to enhance visibility into the execution flow, making it easier to debug and understand the processes involved in dataizing, testing, linking, and transpiling.
Detailed summary

Added logging for the object being dataized and the main file used in dataize.js.
Logged the directory where tests are running and any excluded patterns in test.js.
Logged the creation of package.json and the copying of dependencies in link.js.
Logged the copying of main files and completion of project builds in link.js.
Logged the reading of foreign files and the output directory in transpile.js.
Logged the number of verified tojos found and processed in transpile.js.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Closes: #85

@rultor merge

@rultor merge

@maxonfjvipon OK, I'll try to merge now. You can check the progress of the merge here.

@rultor merge

@maxonfjvipon Done! FYI, the full log is here (took me 22min).

@HaidarJbeily7 thanks


Notebook for SPARCL + Jdaviz

This PR adds a how-to for displaying SPARCL spectra in Jdaviz (specifically Specivz).  This notebook was initially developed at .Astronomy 12.

Hi @weaverba137 I've gone through and added section descriptions and other small formatting edits. Jdaviz is available on gp02 if you would like to review/test it on there. @rnikutta and @galaxyumi , can yall take a look at this notebook as well?

@weaverba137 and @jacquesalice, here are more comments:

The last two commente-out lines in the cell where you define the function on_selected can be deleted if they are no longer in use.
The last cell for making plot could have more description in the markdown. For example, featuring a drop down bar where one can select a target to display its spectrum with the best-fit model.
The y-axis label is not following the scientific unit style conventions, e.g.,[erg s^{-1} cm^{-2} A^{-1}].
The x-axis ticks are too busy to read. Maybe changing to nm? I am getting a long warning box complaining about the Angstrom anyway.
It would be great if the plot's legend could be more informative. Currently, they are random(?) two alphabets in red and black colors for model and data.
Please take care of this long warning if possible. Otherwise, please leave a comment about the warnings in the markdown not to scare the users.

From the comments above:

Fixed.
Fixed.
Waiting on a fully viable notebook server to test. This may be an internal feature of Jdaviz that cannot be changed.
Waiting on a fully viable notebook server to test. This may be an internal feature of Jdaviz that cannot be changed.
The alphabetical indexes are an internal feature of Jdaviz. We cannot change that in this notebook.
Waiting on a fully viable notebook server to fix.

Updates:

The warnings are now fixed.
The y-axis label looks fine to me.
The x-axis looks fine to me.

@jacquesalice, I think this is ready to go, but it should be tested on gp02 when it becomes available again, and also tested on gp12 when Jdaviz is installed on that system.

PS, I updated the HTML version on the last commit. Please double-check that it looks OK.

I've retested this notebook with the new 'Python 3' kernel on gp02. Please review again. There are no major changes from last time, but it has been a while since we were able to test this.

Hi @weaverba137 , @jacquesalice , @galaxyumi : checking on the status of this notebook. From Ben's last comment it was retested on gp02. What are the next steps after reviewing this version before it can be deployed to prod/gp12?

I believe it requires the Python 3.10 kernel to be installed on the production server, so that might also be a question for @mjfitzpatrick.

@jacquesalice, it should be possible to at least review this notebook on gp13 so that it is ready to merge if not yet fully merged.


Tilemaps

This issue existed before and was solved: https://github.com/GoodBoyDigital/pixi.js/issues/48
I thought I'd start a fresh issue now that v3 has arrived.
Is tilemap support on the roadmap?

Nope, tilemaps are not something we will put into core pixi.js. It is really more of a game feature, and its implementation will be specific to a game engine or application and doesn't make sense to be in our thin rendering layer.
That being said, nothing is stopping anyone from making a v3 plugin for it. It just will never be in core.

Doh, I think I was in the grapefruit headspace. Thanks.

Ha, no problem!


Fatal Server error: no screens found, crouton on dell 11 Chromebook

When I try to open unity, I get this this error message:
Entering /mnt/stateful_partition/crouton/chroots/precise...
_XSERVTransmkdir: Owner of /tmp/.X11-unix should be set to root
X.Org X Server 1.11.3
Release Date: 2011-12-16
X Protocol Version 11, Revision 0
Build Operating System: Linux 2.6.42-61-generic x86_64 Ubuntu
Current Operating System: Linux localhost 4.4.44-07169-g8391de9 #1 SMP PREEMPT Mon Feb 13 03:00:01 PST 2017 x86_64
Kernel command line: cros_secure console= loglevel=7 init=/sbin/init cros_secure oops=panic panic=-1 root=/dev/dm-0 rootwait ro dm_verity.error_behavior=3 dm_verity.max_bios=-1 dm_verity.dev_wait=1 dm="1 vroot none ro 1,0 3584000 verity payload=PARTUUID=f1c10cce-c7db-5147-843e-0f2260bbfe4d/PARTNROFF=1 hashtree=PARTUUID=f1c10cce-c7db-5147-843e-0f2260bbfe4d/PARTNROFF=1 hashstart=3584000 alg=sha1 root_hexdigest=b0ca2ac0fb3482649c4335b6687072532b59098f salt=50b7f42a1b5e16bb0327354a050dbc4298bf21aff3247a11db290f8f1a0683f5" noinitrd vt.global_cursor_default=0 kern_guid=f1c10cce-c7db-5147-843e-0f2260bbfe4d add_efi_memmap boot=local noresume noswap i915.modeset=1 tpm_tis.force=1 tpm_tis.interrupts=0 nmi_watchdog=panic,lapic
Build Date: 12 February 2015  02:49:01PM
xorg-server 2:1.11.4-0ubuntu10.17 (For technical support please see http://www.ubuntu.com/support)
Current version of pixman: 0.30.2
Before reporting problems, check http://wiki.x.org
to make sure that you have the latest version.
Markers: (--) probed, (**) from config file, (==) default setting,
(++) from command line, (!!) notice, (II) informational,
(WW) warning, (EE) error, (NI) not implemented, (??) unknown.
(++) Log file: "/tmp/Xorg.crouton.1.log", Time: Sun Feb 19 14:25:37 2017
(==) Using system config directory "/usr/share/X11/xorg.conf.d"
Fatal server error:
no screens found
Please consult the The X.Org Foundation support
at http://wiki.x.org
for help.
Please also check the log file at "/tmp/Xorg.crouton.1.log" for additional information.
ddxSigGiveUp: Closing log
Server terminated with error (1). Closing log file.
/usr/bin/xinit: giving up
/usr/bin/xinit: unable to connect to X server: No such file or directory
/usr/bin/xinit: server error
Unmounting /mnt/stateful_partition/crouton/chroots/precise...
And when I do sudo edit-chroot -al it says:
name: precise
encrypted: yes, locked
Unmounting /mnt/stateful_partition/crouton/chroots/precise...
Please help me

Make sure your chroot is up to date, see 'Common issues and reporting'


How to print a latexstring out

I am trying to print a latexstring using LatexStrings package:
println(L"gap at \gamma is: %$(gap) eV")
but get the following printed out:
$gap at \gamma is: 0.08904209804025498 eV$
which is not what I want. I know latexstring will work when plotting a figure using Plots . Why I cant print it in Latex style?

LaTeXStrings does not do any LaTeX rendering; it just makes it easier to type the strings without escaping backslashes.  The LaTeX rendering is up to the display environment.
Moreover, print is for outputting text, and in general a LaTeX equation cannot be represented as plain text.   If you just want Greek letters, however, you can just type them directly in an ordinary string: println("gap at γ is: %$(gap) eV")


[EMB-313] Feature/collections

Purpose

Collections needs the features service
makePublicOnSave option for making the node public in the project-metadata component

Summary of Changes
Add features service (used in osf-components).
Side Effects
N/A
Feature Flags

No new flags

QA Notes
Project is public after saving the metadata (so it can be indexed by search)
Ticket
https://openscience.atlassian.net/browse/EMB-313
Reviewer Checklist

[ ] meets requirements
[ ] easy to understand
[ ] DRY
[ ] testable and includes test(s)
[ ] changes described in CHANGELOG.md

Pull Request Test Coverage Report for Build 1636

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 62.374%

Totals

Change from base Build 1634:
0.0%

Covered Lines:
3660

Relevant Lines:
5584

💛  - Coveralls


CPU utilization with IterativeImputer

Hi,
Thanks for your work on this package.
One clarification.
I am using the IterativeImputer in an implementation on AWS and although I have tried several instances they all seem to use only 50% of the available cores (50% is the highest utilization i can get).
Any direction on how i could surpass this setting?
code:
n_imputations = 2
XY_completed = []
for i in range(n_imputations):
imputer = IterativeImputer(initial_strategy='median', n_iter=5,
sample_posterior=True, random_state=i,n_nearest_features=35,
verbose=2)
print("round:",i)
XY_completed.append(imputer.fit_transform(data_0))

Hmm, I think unfortunately you can't make it use more of your CPU. It's sequential by nature, and the underlying model being fit is sklearn's RidgeCV http://scikit-learn.org/stable/modules/generated/sklearn.linear_model.RidgeCV.html, which has no parallel mode =(
Sorry!


update RCNN example for BaseModule::init_params

It seems that a new argument(allow_extra) is added into BaseModule::init_params, which makes the old RCNN example unable to run. So I append it into the example.

Need to pass it down.


display person records

Done

Displays record table showing only those of the person being looked at.
centralizes person details display into a separate html file so that it can be called into other pages.
removes unused imports.

Something to flag is the datasource_id variable.
I'm a bit on the fence on whether it follows naming conventions with respect to where the underscores are placed. Should it be data_source_id instead?

On one hand, I don't think so because the model is called DataSource and so it is intuitive to name its id datasource_id.
On the other hand, when we load the DataSource objects into a variable as such data_sources = DataSource.objects.all(), it seems intuitive to put an underscore between the words.

Is this inconsistent or is it okay? @cyramic

A few thoughts:

The service data view's table requires scrolling to see. Could you rotate it so that the headers are along a column on the left, and the values on the right?

For the person view, the "view records" button is split for me. See the picture for details. This only happens when I use a smaller browser window.  It may be just a matter of adding the text-wrap: nowrap; CSS property, but there may be a better way to do this.

The new search leads to the wrong URL. It currently points to home (/home), when it should point to root (/)

A few thoughts:

The service data view's table requires scrolling to see. Could you rotate it so that the headers are along a column on the left, and the values on the right?

| Header 1 | Value | | Header 2 | Value |

For the person view, the "view records" button is split for me. See the picture for details. This only happens when I use a smaller browser window.  It may be just a matter of adding the text-wrap: nowrap; CSS property, but there may be a better way to do this.

The new search leads to the wrong URL. It currently points to home (/home), when it should point to root (/)

Thank you !
I've made the record table vertical now. and pulled in the changes from main that fix the "New search" path.
Still figuring out what is causing the button text to overflow. It didn't initially do that. I'll push a fix when that works.