FNT nightly failure: Nokia

FNT nightly failure: Nokia

Pull Request Functional Test Report for #3149 / 953547674f229162104c0e11178cbdb7fb2e40ff
Virtual Devices

Device
Test
Test Documentation
Job
Raw Log

Arista cEOS

RT-1.19: BGP 2-Byte and 4-Byte ASN supportgNMI-1.5: Telemetry: Port Speed Test
cd08d19f
Log

Cisco 8000E

RT-1.19: BGP 2-Byte and 4-Byte ASN supportgNMI-1.5: Telemetry: Port Speed Test
3f383a16
Log

Cisco XRd

RT-1.19: BGP 2-Byte and 4-Byte ASN supportgNMI-1.5: Telemetry: Port Speed Test
e6e25ac7
Log

Juniper ncPTX

RT-1.19: BGP 2-Byte and 4-Byte ASN supportgNMI-1.5: Telemetry: Port Speed Test
cd6e250f
Log

Nokia SR Linux

RT-1.19: BGP 2-Byte and 4-Byte ASN supportgNMI-1.5: Telemetry: Port Speed Test
e69000a1
Log

Openconfig Lemming

RT-1.19: BGP 2-Byte and 4-Byte ASN supportgNMI-1.5: Telemetry: Port Speed Test
a8d59e3f
Log

Hardware Devices

Device
Test
Test Documentation
Raw Log

Arista 7808

RT-1.19: BGP 2-Byte and 4-Byte ASN supportgNMI-1.5: Telemetry: Port Speed Test

Cisco 8808

RT-1.19: BGP 2-Byte and 4-Byte ASN supportgNMI-1.5: Telemetry: Port Speed Test

Juniper PTX10008

RT-1.19: BGP 2-Byte and 4-Byte ASN supportgNMI-1.5: Telemetry: Port Speed Test

Nokia 7250 IXR-10e

RT-1.19: BGP 2-Byte and 4-Byte ASN supportgNMI-1.5: Telemetry: Port Speed Test

Help

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.5%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1983

Relevant Lines:
3573

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.5%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1983

Relevant Lines:
3573

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.5%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1983

Relevant Lines:
3573

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.5%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1983

Relevant Lines:
3573

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.5%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1983

Relevant Lines:
3573

💛  - Coveralls


[WIP] encoder: allow 1 CDEF bits for key frames

This exposes a weird issue, where rdo_loop_decision gets stuck in an infinite loop where it's alternating between two loop restoration filters:
New best_new_lrf Sgrproj 12 0 -20
New best_new_lrf Sgrproj 13 0 -24
New best_new_lrf Sgrproj 12 0 -20
New best_new_lrf Sgrproj 13 0 -24
New best_new_lrf Sgrproj 12 0 -20
New best_new_lrf Sgrproj 13 0 -24
New best_new_lrf Sgrproj 12 0 -20
....

@xiphmont any ideas?
To reproduce (with this branch):
target/release/rav1e /derf-media/objective-1-fast/aspen_1080p_60f.y4m --quantizer 172 -o out.ivf

Coverage increased (+0.003%) to 75.581% when pulling f1913ff5feac6092655e11383412f046565af08b on feature/better-cdef-strengths into 7ca4b39e9e0b445213f18ef139c9177807525e26 on master.

The loop in rdo_loop_decision checks if both cdef or lrf has changed. Are you sure cdef isn't changing as well?

The loop in rdo_loop_decision iterates until both cdef or lrf have stopped changing. Are you sure cdef isn't changing as well?

No, cdef_change is always false here, it's just lrf_change that keeps flipping.

OK, I see what's happening.  The logic behind my 'cost always goes down' invariant is incorrect.

r+
The bug being caused in loop rdo is unrelated and I will fix it separately-- this change is simply triggering it.

Yeah that's what I gathered, unfortunately I can't run AWCY for this PR until that bug gets fixed (speaking of which, should I open a proper issue?)

OK, I see what's happening. The logic behind my 'cost always goes down' invariant is incorrect.

_ Okay, I haven't seen this.
Nice catch, @tmatth!

PR #1800 fixes your test case.

PR #1800 fixes your test case.

Confirmed!

@tmatth is this ready to land?

@tmatth is this ready to land?

No still a WIP.

@tmatth is this ready to land?

No still a WIP.

Why? Still weird?!


上传报错

progress: 99.06%
progress: 99.69%
upload finished
D, [2023-04-23T11:21:23.955367 #9488] DEBUG -- : begin to callback api
E, [2023-04-23T11:21:23.955568 #9488] ERROR -- : upload binary ... error ! "\x9E" followed by "," on GBK
E, [2023-04-23T11:21:23.955689 #9488] ERROR -- : binary upload to ali fail, "\x9E" followed by "," on GBK
上传快成功了，一直返回这个错误导致失败
ruby版本和fir版本分别是
ruby 2.7.6p219 (2022-04-12 revision c9c2245c0a) [x64-mingw32]
fir-cli 2.0.21

老哥您可能遇到的是windows 的编码问题,
建议您将编码从 GBK 改为 utf8
或者使用 powershell 启动shell

确实是这个问题，刚刚把cmd的编码格式改了之后就上传成功了，谢谢了


Feature request: Add ability to copy a node in the UI.

You can also do this already, simply right-click on the node.

thanks for the quick responses!!
on mac os using chrome, i dont see a copy option:

“Nodes” in CF refer to the nodes like prompt nodes, textfield nodes, etc. It seems like you are right-clicking inside the response inspector. If you meant you’d like an easier way to copy LLM responses, please add an issue for that specifically (I agree we should make that easier! :)

no node appears to work for me

You need to right-click on the node itself.
From chainforge.ai/play:

interesting. from /play right click works
locally it does not.

My thought is that you might be running an earlier version.

✋ 😵💫
OMG, TY, i got latest and it works!


Adding text-ellipsis as an utility

Fixes: #31332
This PR adds text-overflow: ellpisis as util.
Demo

Please stop opening and closing issues, you can work on a single PR instead of spamming a public repos where thousands get notified.

@ffoodd Yep, my bad. Realised that I had a different username logged in github CLI. Gotcha!

See https://v5.getbootstrap.com/docs/5.0/helpers/text-truncation/

@florianlacreuse I think text-truncate should suffice the need of the bug #31332

Closing per previous comments.


JavaScript keywords not allowed as Python identifiers

Currently
function = 1

is not allowed, but it should be allowed.
Suggestion: We can use $ (not allowed within Python identifiers) to make sure Python identifiers are not confused with JavaScript keywords. The example above then becomes, for example:
$function$ = 1;

in JavaScript.

resolved


Add norwegian bokmål language

Hi,
This is to add Norwegian bokmål to your application.
Loving it so far! Thank you.

The error in CI does not seem to correspond with my changes.


chore: rename obm to bmc across the repo

As part of this PR, we are changing usage of obm to bmc across the repo.

I'll aim to land this tomorrow.


[H] Improve documentation regarding padding for dialogs.

This should in theory have no semantic change, though the code is tweaked a bit to put the defaults in the constructors where possible and to use the cheaper EdgeInsets class where possible (rather than EdgeInsetsDirectional).

cc @goderbauer

Thanks, will land on green.


How to work with observable?

It's very likely that I'm doing something wrong, but when I try to run an example with Observable, I get this error
 ✖ Success

   → Observable is not defined
   Failure
{ ReferenceError: Observable is not defined
    at Task.task (/home/exeteres/gulp-project/test.js:6:9)
    at Promise.resolve.then.then.skipped (/home/exeteres/gulp-project/node_modules/listr/lib/task.js:168:30)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:118:7)
    at Function.Module.runMain (module.js:705:11)
    at startup (bootstrap_node.js:193:16)
    at bootstrap_node.js:660:3 context: {} }

The code I am trying to run
const Listr = require('listr');
const tasks = new Listr([
{
    title: 'Success',
    task: () => {
        return new Observable(observer => {
            observer.next('Foo');

            setTimeout(() => {
                observer.next('Bar');
            }, 2000);

            setTimeout(() => {
                observer.complete();
            }, 4000);
        });
    }
},
{
    title: 'Failure',
    task: () => Promise.reject(new Error('Bar'))
}
]);
tasks.run().catch(err => {
    console.error(err);
});

Sorry for disturbing.
I just installed the package zen-observable.
const Observable = require('zen-observable');

Yes, use whatever Observable package you want like zen or RxJS. Glad you got it working!

Sorry for re-posting on this, but there's something I can't get to understand : I can't find where observer variable comes from / is defined in your example.

Oh damn, by the Observable itself 😅
Sorry for polluting the messages thread 😓


Cannot find the folder "bin" to run "dserver.sh"

OrientDB Version: 3.0
Java Version:
openjdk version "1.8.0_161"
OpenJDK Runtime Environment (build 1.8.0_161-b14)
OpenJDK 64-Bit Server VM (build 25.161-b14, mixed mode)

OS: CentOS 7
I am installing a distributed version of OrientDB from source following these guidelines:
https://orientdb.com/docs/3.0.x/admin/installation/Installation-from-Source.html
After executing mvn clean install, I cannot find the folder bin in order to run dserver.sh. I found the script dserver.sh under the path distributed->script, but then I get the error:
./script/dserver.sh: line 50: cd: /home/centos/orientdb/distributed/bin: No such file or directory
./script/dserver.sh: line 114: /home/centos/orientdb/distributed/bin/orient.pid: No such file or directory
Error: Could not find or load main class com.orientechnologies.orient.server.OServerMain

Hi @LianaN
After the build is executed, you will find the final distribution in the /distribution/target/ folder
I hope it helps
Thanks
Luigi

Hi @LianaN
I hope it was helpful, I'm closing this ticket for now, but feel free to re-open if you need further help
Thanks
Luigi


feat(cli/version): print core version as well

For example,
$ haetae --version

cli: v0.0.2
core: v0.0.1

-i, --info option would do that instead.


Performance on EfficientSplade

Hello,
congratulations on winning the bigANN challenge at NeurIPS and also thank you for sharing the code. I have tested your method on a different set of embeddings (representations), generated using EfficientSplade. This model generates vectors with a different distribution of non-zero values.
The following table compares it with the dataset of the challenge.

Dataset
#Document
#Query

BigANN
127
49

EffSplade
180
6

where #Document indicates the average number of non-zero terms in the documents, and #Query indicates the average number of non-zero terms in the queries. In my experiments, your method is much slower on the Efficientsplade, which is kind of string.

Dataset
Recall (%)
Latency (us)

BigANN
90
867

EffSplade
90
3656

Evaluation is performed in single-thread. I tried several efsearch parameters and picked the first result that surpasses 90% of recall.
Do you have any idea why it could happen?

Hello,
Thank you for your kind words and congratulations. I appreciate your effort in testing our method on a different set of embeddings generated using EfficientSplade.
Regarding the issue you mentioned, it's possible that the observed challenges stem from two if statements in space_ip.h:
if (q_col < p_col) {
    q_col = (++q_indices)->indice;
}
else if (q_col > p_col) {
    p_col = (++p_indices)->indice;
}

Specifically, it seems like the first non-zero dimension of the query vector (q_col) is much larger than that of p_col in the first if statement. This leads to a significant chunk of computation time being consumed by the ++q_indices operation. The situation is similar for the second if statement.
I would be happy to delve deeper into this issue or address any further questions you may have. Your insights and feedback are valuable in refining our approach.
Best regards.


[Feature Request] Compatibility with Levels

I would love to see compatibility with the levels module.
This would require an option to adjust the Z level of the drawing that is generated. I imagine this could also be achieved by making the floor be generated as a tile. I am not sure how feasible either of these would be, but being able to draw dungeons on the fly with Level's functionality is just what I am looking for.

Came here looking for exactly this. I think all we would need is a config option to manually specify the Z level.

This would be helpful especially with the doors.
I am currently running SimpleFog for dungeon exploration (I use a TV on my table as the game board and don't import player tokens to the map to control lighting & fog normally), and the doors appear through the fog.


bigquery: insert sample

Hi, is there any sample with bigquery insert struct? I can't find any.

Is https://github.com/GoogleCloudPlatform/golang-samples/blob/main/bigquery/snippets/table/bigquery_table_insert_rows.go what you're looking for?  It uses an Inserter with a struct.

Closing this due to lack of further response.  If I've misunderstood, please revisit the issue with more details.


user-docs: add-a-bot-or-integration (user-level)

Splitting out the articles from to todo list here: 32f6a76
@zulipbot label "area: documentation (user)"

@Lyla-Fischer  I noticed that https://zulipchat.com/help/add-a-bot-or-integration already exists. Would you want me to add an example for adding an integration on that page?

Nope. We have separate sections for users and administrators, and the page that you found is mostly for administrators. We would want a separate page for non-privileged users.

Because of some work that we are doing with documentation templates, we are going to try to centralize the creation of documentation (https://github.com/zulip/zulip/issues/8889). Would you be interested in reading newly created documentation for clarity instead of writing the first draft?


merge from konsum-frontend-svelte

package.json

chore(deps): add ^9.0.2 remove ^9.0.1 (devDependencies.npm-pkgbuild)

:tada: This PR is included in version 1.31.16 :tada:
The release is available on:

npm package (@latest dist-tag)
v1.31.16
GitHub release

Your semantic-release bot :package::rocket:


can you upload the source to pypi again?

I'm currently working on a Synology SPK for mitmproxy which will allow users of Synology Devices an easy installation. more info on that toppic can be found here: https://github.com/SynoCommunity/spksrc/issues/2554 Sadly i noticed that you've stopped uploading the source code to pypi with version 0.15. Since spksrc (the framework im using) skips wheel files because pip isn't able to distinguish between the different types of wheels (pure-python, manylinux etc) as a temp fix for debugging i linked to the github release but it would be nice to see the source in pypi again.
Thank you!

Hi,
We do not plan to publish source distributions on pypi, as those would be
picked up by pip2. Our next release will be Python 3 only and we prefer to
have a clear "no distribution found" message for Python 2 users then. Sorry.
cytec<EMAIL_ADDRESS>schrieb am Di., 13. Dez. 2016, 21:04:

I'm currently working on a Synology SPK for mitmproxy which will allow
users of Synology Devices an easy installation. more info on that toppic
can be found here: SynoCommunity/spksrc#2554
https://github.com/SynoCommunity/spksrc/issues/2554 Sadly i noticed
that you've stopped uploading the source code to pypi with version 0.15.
Since spksrc (the framework im using) skips wheel files because pip isn't
able to distinguish between the different types of wheels (pure-python,
manylinux etc) as a temp fix for debugging i linked to the github release
but it would be nice to see the source in pypi again.
Thank you!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mitmproxy/mitmproxy/issues/1853, or mute the thread
https://github.com/notifications/unsubscribe-auth/AA-NPp0wp7Qv6bCMvDEHIo4v_jXYzqqPks5rHvpQgaJpZM4LMKka
.

well i guess we have to go with the github source linking then.
Thanks anyway!

If that works for you, that'd be great - thanks. We'd be willing to reconsider things if this poses insurmountable obstacles, but right now the benefits of not having a source distribution clearly outweigh the costs of it, especially given the fact that a source distribution can be easily downloaded from GitHub. Thanks for your understanding!


bundleDimension requires sylvester

Hi there,
I'd really like to be able to use pc.bundleDimension() without having to include sylvester.js in my html header. The vector function in this library is used for computeCentroids and returns Uncaught ReferenceError: $V is not defined at computeCentroids when sylvester.js is not included in the script.
The good news is there is a somewhat new library sylvester-es6 which should be compatible with parcoords-es and would be a quick fix.
I'd be happy to submit a pull request if you're ok with the dependency. Let me know.

Sure, go ahead.

Thank you for this feature!
v2.2.4 is released


Collection pagination

Steps to reproduce

go to any collection (tested on /rmrk/collection/800f8a914281765a7d-KITTY)
click on page 3
click on any nft
click on go back to previous page
you're now on page 1 while you have page 3 in url

Expected Behavior
I should be on page 3 instead of page 1
video
https://user-images.githubusercontent.com/9987732/159443990-d0c98a5b-6e07-4226-9c6f-cbaa572da9f5.mov

I will handle with it.

Seems same bug as we had on the gallery?

Seems same bug as we had on the gallery?

I think yes. The same problem in different components.


Add callback for property groups

Enhancement request
Add the ability to add a callback for a property change to a group of property names.   The callback is called if all of the property names are marked as changed.   This may require some sort of change timing strategy or eviction strategy for property changes over multiple properties.

Closing this issue for now since we haven't seen any traction on the need.


Datasets/lm evaluation library

Description

This PR aims at adding Benchmark Datasets For QA task
Datasets Added:

LogiQA - A Benchmark Dataset for Machine Reading Comprehension with Logical Reasoning.

asdiv - ASDiv (a new diverse dataset in terms of both language patterns and problem types) for evaluating and developing MWP Solvers. It contains 2305 english Math Word Problems (MWPs), and is published in this paper "A Diverse Corpus for Evaluating and Developing English Math Word Problem Solvers".

Google/Bigbench - The Beyond the Imitation Game Benchmark (BIG-bench) is a collaborative benchmark intended to probe large language models and extrapolate their future capabilities. Tasks included in BIG-bench are summarized by keyword here, and by task name here
We added some of the subsets to our library:
  1. AbstractUnderstanding
  2. DisambiguationQA
  3. Disfil qa
  4. Casual Judgement

➤ Fixes: Explore lm evaluation library for good datasets #556
Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update

Usage

Checklist:

[ ] I've added Google style docstrings to my code.
[ ] I've used pydantic for typing when/where necessary.
[ ] I have linted my code
[ ] I have added tests to cover my changes.

Screenshots (if appropriate):

@RakshitKhajuria @Prikshit7766  have you prepared any NB for it. Give link to NB in PR dexription with some screenshots of generated results.

NB for it. Give link to NB in PR description with some screenshots of generated results.

Updated


Add initial get_xxx methods

Adds initial get_xxx() methods for:

[ ] locations
[ ] location_attributes
[ ] location_crosswalks
[ ] attributes
[ ] units
[ ] variables
[ ] configurations
[ ] primary_timeseries
[ ] seconday_timeseries
[ ] joined_timeseries

I think we want to utilize spark.sql for this since we are trying to lean that direction.  DuckDB will be OK if necessary.


Kitematic will not open docker cli

macOS Sierra
Version 10.12.6
Expected behavior
When you click on "Docker CLI" or "EXEC" it should open a terminal window.
Actual behavior
It dose not open a terminal window
Information about the Issue
Some times, usually when kitematic is opened for a day or so, when I try to connect to the cli using the kitematic buttons, it will not do anything. I am not getting an error or anything.
Steps to reproduce the behavior
The issue is intermitent.

Keep kitematic opened for some time (1 day for example) in the background
Try clicking on "DOCKER CLI"

I cannot reproduce this behavior - What container image are you using? Can you share a small video showing the issue?


Record local timestamps, not microseconds since start

This makes it easier to correlate with other logs.
Before:
+5817us    conduit [INFO] Waiting for connections on Unix socket tcp://<IP_ADDRESS>:5640

After:
2016-09-09 15:32    conduit [INFO] Waiting for connections on Unix socket tcp://<IP_ADDRESS>:5640

Does anyone need the monotonic time for something?
Might be nice to include ms and tz offset from GMT, but Unix API doesn't make this very easy.
Signed-off-by: Thomas Leonard<EMAIL_ADDRESS>

dbuenzli/mtime#14 gives you a way to access the system-relative mtime for log correlation purposes. If you want precise event ordering across different processes on the same machine in the same boot session, it contains the functionality you want. I don't think it is particularly confusing or needs further work but I also haven't put in the effort since the original patch to get it into upstream. Docker for Mac uses the patch for file system event logging.

That won't work across machines, though, right? e.g. if GitHub says it sent me a webhook message at 2016-09-09 15:01:16 then I can't find the corresponding place in the DataKit logs.

No, it won't work across machines. The best you can do is record a wall-clock and monotonic clock pair to provide known moments for cross-machine correlation (but still have nice monotonicity properties for local events).


Add CSRF to Flow Analysis export (#745)

Rationale
Cherry picking the commit from prior release, since I'm not sure if we are doing the auto merges at this point.
Flow module analysis export form is missing the the CSRF token, so it fails
Related Pull Requests

https://github.com/LabKey/commonAssays/pull/745

Changes

Added a CSRF token to the export form

works for me.


Linux native menus checked entries

This PR adds functionality so that entries in the native Linux menus reflect their checked / unchecked status.

@pelatx Thanks for this PR! I will review this. A quick comment. I see that there the unit tests are missing for this PR. Could you add unit tests for the new code?

I'm sorry @nethip . I'm completely new programming in C/C++. I had to learn the basics of GTK+ and get acquainted with the Brackets-shell code to write this. But I do not know how to write unit tests following the methodology you use in this project.
Maybe you could give me some guidance to know where to start.
Thank you.

@pelatx No issues! We can guide you through the process. Please refer to https://github.com/adobe/brackets-shell/wiki. This should be a good place to get started.
About unit tests: I just looked at what needs to be written/enabled. We don't have to write any new unit tests as most of it is covered in existing tests. Please refer to this piece of code.
https://github.com/adobe/brackets/blob/master/test/spec/NativeMenu-test.js#L1291
All of our existing tests can be found in Brackets repo at https://github.com/adobe/brackets/tree/master/test
And good job on the PR :+1:

@pelatx I have reviewed your code and I think we can simplify it much further.
I have created a branch for Linux enhancements and pushed some changes relating to check marks of menus on Linux. Would you take a look at it and see if the solution is simple? I did not unit test this on Debian though.
https://github.com/adobe/brackets-shell/compare/nethip/LinuxEnhancements
Quite a no of things to consider.

Upon calling gtk_check_menu_item_set_active, menu activation was getting triggered because of which a psuedo command firing was happening. So had to restrict that here
With the check marked menus, just upon clicking the menus, the check mark was getting toggled by default. So kind of handled this too here. Since this is a hack, need to verify on Debian and Ubuntu 17.0.

Let me know if it is OK for you to contribute to branch nethip/LinuxEnhancements. We still have some couple of enhancements on Linux side. It would be great if you are willing to have this.

Wow, you have eliminated in a moment several problems that I found when I wrote this and that they complicated it a lot.
If I understand it well, with those changes there will be no need to call the callback of a check menu item twice and this can be simplified.
On the other hand, I tried another solution at the beginning, which was based on replacing gtkMenuItem with gtkCheckMenuItem in AddMenuItem (), as I see in the LinuxEnhancements branch. But I did not like that all the items in the menus appear with the check box if they do not really have a toggle function.
This would be the view we would have, right?
I agree with what you propose @nethip. I will try to contribute what I can.
Later I will try to test these changes in Debian and adapt the PR code.
Thank you very much for the help about the unit tests.

@pelatx Ah huh! I get it now. So the checkbox is getting displayed irrespective of wheter the menu is switchable or not. So the way you fixed this is by recreating a menu each time a menu item state set has been requested.
I think we can go ahead tweaking this PR itself and merging some of my changes with this. Can you tweak on the menu re-creation side a little while I can contribute with other related things, like blocking the menu command recreation when not required e.t.c?

Of course, yes, I had already decided to adapt it and show it to you later, so that you can consider it.
With your hack, I think that the callback for the GtkCheckMenuItem can be simplified.
This PR works by creating a GtkCheckMenuItem pair of the original item the first time it is checked. And hiding the original item. Then we only play with the visibility of one and the other. The entire menu is not recreated each time.
The corresponding GtkCheckMenuItem callback activates the original item and thus the checked item is transparent in terms of functionality. It is a purely visual element.
I will try to adapt it to the branch and complete it by modifying removeMenuItem () as well, so that the GtkCheckMenuItem is eliminated when the original is. Which I had overlooked.

I had compiled and tested the PR (as it was before this last commit) only on linux-1547 branch. Later I have seen that the same code does not work on master. Sorry for this.
That is why I have searched for another way to obtain the checked items and it has resulted in a simpler code.
Please, you could review it @nethip?

Thanks @pelatx! Apologies for not being able to respond to you. I will review this in a day or two.

No problem @nethip.
Actually this PR, in general, it works as expected.
In the case of the three menu items related to split the view, they work well when we select a different one from the one currently selected.
If we select the same, the CheckMenuItem will be unchecked but it will not be changed by a MenuItem. It seems that, by acting as a group of radio buttons, the SetMenuItemState() function is not called in this case.
To solve this, the hack you made is perfect. I have included my code in your LinuxEnhancements branch. And I added a condition here to avoid the cast errors that occur when the function receives a MenuItem instead of a CheckMenuItem.
In this way, it seems that everything works well (on Debian 8 at least).

@pelatx Awesome! This works as expected.
I checked this on both Ubuntu 16 and Debian 9 and they seem to be working fine there. I don't think you would require any of the hacks that I had in my LinuxEnahacements branch. If you think you require any, please update this PR with them and I will check and merge this PR.
I found a small bug, with which we can live as well actually. Upon clicking the No Split menu entry, the box stays there.
About unit tests: There may be some unit tests failing already. They may not be related to this PR. It would be great if you can have a look at some. If not we can go ahead merging this PR and take a look at the unit test case failures later, as those failures are not related to this PR.
Good job :clap:

Thanks @nethip.
I also think that the failures in unit tests are not related to this PR. Exactly the same failures have arisen when I tried in Master branch.
Your hack fixes precisely the small bug of No Split. Later I will update this PR so you can check it.

@pelatx the changes look absolutely fine! Just add some NULL checks pointed above, so that I can go ahead with the merge.

Thanks @pelatx . Awesome job :+1:


pagination not defined

getting pagination not defined, though able to see the included simplepagination.js and the css in source code.
html-

script-
$(function() {
$('#light-pagination').pagination({
items: 6,
itemsOnPage: 3,
cssStyle: 'light-theme'
});
});

There was some JS files conflict. Was able to resolve by jumbling the JS files order.


Unable to run report

Running against Veeam 12.1 & PostgreSQL.
Fails when trying to run any combination of the command.  Main difference is it's V12.1 & PostgreSQL.
New-VeeamDiagram -Target SERVER-NAME -Credential $Creds -DiagramType  Backup-to-Repository  -Format pdf,png -Direction top-to-bottom -OutputFolderPath C:\temp\temp -EdgeType polyline -Verbose -EnableEdgeDebug -EnableSubGraphDebug
Graph : Index operation failed; the array index evaluated to null.
Has worked well in past in different environments.  1st time running on 12.1 & PostgreSQL
VERBOSE: Loading module from path 'C:\Program Files\Veeam\Backup and
Replication\Console\Veeam.Backup.PowerShell..\Veeam.Backup.PowerShell.dll'.
VERBOSE: Trying to import Veeam B&R modules.
VERBOSE: Loading module from path 'C:\Program Files\Veeam\Backup and
Replication\Console\Veeam.Backup.PowerShell..\Veeam.Backup.PowerShell.dll'.
VERBOSE: Identifying Veeam Powershell module version.
VERBOSE: Using Veeam Powershell module version 11.
VERBOSE: Loading module from path 'C:\Program Files\Veeam\Backup and
Replication\Console\Veeam.Backup.PowerShell..\Veeam.Backup.PowerShell.dll'.
VERBOSE: Establishing initial connection to Backup Server: XXX .
VERBOSE: Looking for veeam existing server connection.
VERBOSE: No existing veeam server connection found
VERBOSE: Connecting to XXX with XXX credentials
VERBOSE: Validating connection to XXX
VERBOSE: Successfully connected to XXX:9392 Backup Server.
VERBOSE: Operation '' complete.
VERBOSE: Collecting Backup Server information from XXX.
Graph : Index operation failed; the array index evaluated to null.
At C:\Program Files\WindowsPowerShell\Modules\Veeam.Diagrammer\0.5.3\Src\Public\New-VeeamDiagram.ps1:271 char:18

...      $Graph = Graph -Name VeeamVBR -Attributes $MainGraphAttributes {

              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : InvalidOperation: (:) [Graph], RuntimeException
FullyQualifiedErrorId : NullArrayIndex,Graph

Hello,
Can you run the script with the EnableErrorDebug option and send me the output text to<EMAIL_ADDRESS>Regards.

i have the same problem

I found the bug. The issue will be fixed in the next release.

Fixed in v0.5.5 please update the module and do the test again.
update-module -Name Veeam.Diagrammer -force

works great thank you!


Components enhancements

Currently components lacks really powerful features:

Lifecycle. There is only 2 methods initialize and template and last one is called first then first one. That means that developer can decide which template to render based on input information from the attributes. For example, I'd like to have a component which is something similar to input tags with different types but more complex, e.g. datepicker, autocomplete, etc. So, that I do this in HTML:

<form-field type="datepicker" value="birthDate"></form-field>

And my component is this:
rivets.component['form-field'] = {
  initialize: function(el, attrs) {
    return new FormField(attrs);
  },

  template: function(scope) {
    return TEMPLATES.get(scope.type);
  }
};

Currently it's not possible. The only possible solution is to create separate component for each form-field. But logically it should be one component with extendable points and some shared behaviour
2. initialize accepts 2 arguments: object of attributes and HtmlElement and this allows devs to write worse code as it mixes concepts (view - element, parsed attrs - kind of model). Another reason why it should be split into 2 because view (rivets binders) assigns view related variables (i.e. rv-each-*) right into my component controller what can lead to names collisions and unpredictable behaviour. So, something like { [componentName]: component.initialize() } should be view scope and not just component.initialize() result.
3. Sometimes you have a component with its default template but then you want to use it in another place with a bit different template. Currently there is no way to change components parts. This is what transclusion cares about. So, it allows to define parts inside components which can be overridden if necessary. So, you can do like this:
<form-field type="number">
  My custom label

My custom error message

</form-field>

And Components template:

   { label }
   <input type="number" rv-value="value" class="form-control">

{ error }

In this example form-field will replace part which is called label inside default template with the provided tag.
4. Components doesn't not allow to return document fragment from their template. In the same time document fragment is the most performant way to put a bunch of HTML in DOM tree.
5. Sometimes you want to specify component's template as a string (when there is no need in function, you just have prepared HTML or want to put it right there without writing extra function)
rivets.components.tabset = {
  template: `

{ tab.title }

  `,

  initialize: ....
};

Here no need in function, so more convenient to pass just a string.
6. No support for dependent components like tabset and tab. For example currently this is not possible as components just remove inner html
<tabset>
  <tab title="Overview">Tab Content</tab>
  <tab title="Settings">Settings</tab>
</tabset>

Also it's not possible to access parent component inside child one at the moment.
@blikblum, @Leeds-eBooks, @jccazeaux want to hear your thoughts about this as I have already done all this (and a bit more in my fork). So, if we are ok with that we could split these tasks to smaller one and I will create a separate pull-request for each.

Component implementation now really falls short.
Although i would go for a subset of webcomponent specification something like Vue did.

One more point: currently there is no way to clean up component (for example clearInterval, etc). So, need to add one more method unbind which is called when component is unbound

Just to summarize efforts

[x]  Optional "template", "template" as string, element/document fragment based templates #545
[ ] change the order of "template" and "initialize" invokations (initialize first then template)
[ ] dependent components
[ ] transclusions or template parts substitution
[ ] formatters in component's attributes
[ ] unbind component's method for cleaning stuff when view of the component is unbound (like clearInterval, clear custom subscriptions, etc)
[ ] add controller method as replacement for initialize which accepts only passed attributes and dependencies. Basically when this method is specified we can use standard initialize-r. That solves 2 statement in issue description.

  if (typeof this.component.controller === 'function') {
    this.component.initialize = defaultInitializer;
  }

  function defaultInitializer(el, attrs) {
    var scope = {};
    scope[this.type] = this.component.controller.call(this, attrs);

    return scope;
  }

I have a question about transclusion:
<form-field type="number">
  My custom label

My custom error message

</form-field>

What will be rv-part? It looks like a binder but its value is more like an alias than an expression.

@jccazeaux in my fork I use block-name  attr and its name may be configured. So, no worries about that

@stalniy I took some time to go deeper in components. I want to have your opinion on something I found.
Doc says

All attributes on the element will get evaluated as keypaths before being passed into the component's initialize function.
<todo-item item="myItem"></todo-item>
These keypaths will also be observed in both directions so that the component will update if the value changes from the outside and it will set the value if the component changes it from the inside.

It is not true, initialize function receives copy and not observed keypath. So if parent's value changes, component will not be notified. See this fiddle
In the code I found that Rivets binds component's attributes at root of component's model. This means we can access attributes directly without initialize function like that
<todo-item item="myItem">

  { item }
</todo-item>

There, databinding is activated like doc describes it.
See this fiddle
There is only a glitch here : component's model is not initialized at first. You have to change parent's value at least once. This glitch is very easy to fix if necessary
Were you aware of this?
CC: @Duder-onomy @Leeds-eBooks @blikblum

Hey @jccazeaux I have finally got round to this. I thought that this bug you found was because you were declaring the component as a function rather than as a class, so I forked your fiddle here and as I thought, when declaring the component as an es6 class it works correctly, updating the parent property. I don't know enough about JS classes to explain why this is the case but if you follow the docs, declaring a component using new, components as they are currently work correctly.

Hi @Leeds-eBooks your fiddle is interesting. It's not the using of JS class that changed the thing. Look at this.
What i saw since :

If initialize returns empty object, databinding still works but the component's model is not  initialized.
If initialize returns undefined, databinding does not work (i think it's normal, it's just to say)
See all of it here

So to set initial value in binding you have to do it in initialize. I don't find that very convenient.


Preventing the assets from being compiled into the Jar

Hello everyone,
I was looking for a way to disable the static assets being compiled into the jar file.
Why? I am making changes to the javascript and css files while I'm running the server, however, I need the calculated results that the API provides me. Hence it's a bit of an annoying process to rebuild and launch the whole package for every change.
I've looked into this post: https://github.com/dropwizard/dropwizard/issues/54 , however, I can not seem to get this work.
Is there a newly updated method or should I open a support ticket for the fact that I get 404's using this the above-shown technique?

If you are looking to serve static assets from files, you're probably best to register Jetty's DefaultServlet via environment.servlets().addServlet(...)

Closing this issue. If the provided solution is not appropriate, please respond to have this issue reexamined.


Cannot load homebridge-ewelink - Error: certificate has expired

What issue do you have? Please be as thorough and explicit as possible.
Upgrade plugin "homebridge-ewelink" to version 2.25.0 and restart server
Details of your setup.
Homebridge v1.1.6
homebridge-ewelink v2.25.0
Which version of Homebridge/HOOBS do you have?
1.1.6
Which version of this plugin (homebridge-ewelink) do you have?
2.25.0
**Please paste any relevant logs below. It helps if you can turn
[9/9/2020 2:33:47] [eWeLink] 🔴  Cannot load homebridge-ewelink - Error: certificate has expired
(node:592) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'close' of undefined
    at eWeLinkWS.closeConnection (/usr/local/lib/node_modules/homebridge-ewelink/lib/eWeLinkWS.js:278:15)
    at httpClient.getHost.then.then.then.then.then.then.catch.err (/usr/local/lib/node_modules/homebridge-ewelink/lib/eWeLink.js:98:33)
    at process._tickCallback (internal/process/next_tick.js:68:7)
(node:592) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 2)
(node:592) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

same issue here
Ewelink Plugin version 2.25
Homebridge 1.1.6
Important to warn: even downgrading for 2.24.3 didn't solved the issue
[2020-9-8 21:44:54] [eWeLink] 🔴  Cannot load homebridge-ewelink - Error: certificate has expired
at TLSSocket.onConnectSecure (_tls_wrap.js:1474:34)
at TLSSocket.emit (events.js:310:20)
at TLSSocket._finishInit (_tls_wrap.js:917:8)
at TLSWrap.ssl.onhandshakedone (_tls_wrap.js:687:12) {
code: 'CERT_HAS_EXPIRED',
config: [Object],
request: [Writable],
response: undefined,
isAxiosError: true,
toJSON: [Function: toJSON]
}
(node:6328) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'close' of undefined
at eWeLinkWS.closeConnection (C:\Users\jroch\AppData\Roaming\npm\node_modules\homebridge-ewelink\lib\eWeLinkWS.js:278:15)
at C:\Users\jroch\AppData\Roaming\npm\node_modules\homebridge-ewelink\lib\eWeLink.js:98:33
at processTicksAndRejections (internal/process/task_queues.js:97:5)
(node:6328) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag --unhandled-rejections=strict (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2)
(node:6328) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Same problem here.
Raspberry Pi4 8GB
Homebridge 1.1.6
Node Js Version: v12.18.3
NPM Version: v6.14.8
This message more or less 30min after update.
Doesnt work downgrade.
Error Message:
[eWeLink] 🔴  Cannot load homebridge-ewelink - Error: certificate has expired
at TLSSocket.onConnectSecure (_tls_wrap.js:1501:34)
at TLSSocket.emit (events.js:315:20)
at TLSSocket._finishInit (_tls_wrap.js:936:8)
at TLSWrap.ssl.onhandshakedone (_tls_wrap.js:710:12) {
code: 'CERT_HAS_EXPIRED',
config: [Object],
request: [Writable],
response: undefined,
isAxiosError: true,
toJSON: [Function: toJSON]
}
(node:3921) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'close' of undefined
at eWeLinkWS.closeConnection (/usr/lib/node_modules/homebridge-ewelink/lib/eWeLinkWS.js:278:15)
at /usr/lib/node_modules/homebridge-ewelink/lib/eWeLink.js:98:33
at processTicksAndRejections (internal/process/task_queues.js:97:5)
(node:3921) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag --unhandled-rejections=strict (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2)
(node:3921) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Can anyone let me know if they are still getting this error?

its working now for me THANKS!

Can anyone let me know if they are still getting this error?

its working now for me THANKS!

This Error: certificate has expired error was most likely due to a temporary problem at the eWeLink server end - which is why the error still appeared after downgrading to v2.24.3.
In fact I had not changed anything in the code when I asked if anyone was still getting the error. Pure coincidence (and sod's law!) that eWeLink had a small issue themselves not long after me releasing the update.
I will make a small change to the code, so if this ewelink problem ever happens again then this plugin will not show the consequent further UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'close' of undefined error.

@AzagraMac @heyjhoow
all working for you now?

Update to v2.25.1, SonOff devices are back, that's good.
And everything is already working correctly!!!
Murphy's Law 😝
Great job!

Fab. Will close this issue now but do reach out if you have further issues!

just adding my feedback
update to 2.25.1  makes all work fine now!
tnkx for the help!


Add test Coverage

Configiring Instanbul, Travis and Covealls.io

Changes Unknown when pulling cd7c4bcf43cc9212c7bec143f6a861c762be0ab0 on coverage into ** on master**.


Add  support for zigzag layout neopixel matrix

Hi,
I have a Neopixel array like these:

https://www.amazon.es/Longruner-Integrado-Flexible-Iluminación-Completo/dp/B07KT1H481
https://www.adafruit.com/product/2294

I wanted to use your crate to drive the array, but I found that it is not supported (or I have not found the way). I found as reference the NEO_MATRIX_ZIGZAG option in https://learn.adafruit.com/adafruit-neopixel-uberguide/neomatrix-library
I wonder if you would like to add this functionality on your crate. If it is the case, I can send to you a PR with the changes but I would need some guidance.
Regards.

NeoPixel can be in any possible wiring order. ws2812_esp32_rmt_driver::lib_embedded_graphics::LedPixelShape trait is provided for the functionality to represent a Point to LED pixel address conversion.
In order to use the ZigZag-layout LED matrix, it is currently necessary to create a new LedPixelShape your own. (unstable option required)

Thanks for your comments and please excuse the delay in answering.
Following your guide, I have developed a pair of LedPixelShape that cover my needs. If you are interested, they are here .


Apply the new design for Companion Pane

let's have some watermark stating that the controls are mocks and not actually doing anything, otherwise folks will think it's a bug...

@guymerin

let's have some watermark stating that the controls are mocks and not actually doing anything, otherwise folks will think it's a bug...

Do you mean watermark in the image or some text next to the control?

@guymerin

let's have some watermark stating that the controls are mocks and not actually doing anything, otherwise folks will think it's a bug...

Do you mean watermark in the image or some text next to the control?

I think in the image will be easier and doesn't touch the code.

@guymerin

let's have some watermark stating that the controls are mocks and not actually doing anything, otherwise folks will think it's a bug...

Do you mean watermark in the image or some text next to the control?

I think in the image will be easier and doesn't touch the code.

@scorpmel-meshah Can you help me with this?

Updating with watermarks. Do you have any suggestions for the watermark? Microsoft logo? Surface duo logo?

@Mehul1995 , what I meant with watermarks is not about logo, but to let developers understand that the controls / sliders are mocks and don't actually change the image...

@guymerin Updated image with the watermark. How is that?

The sample water mark is on this image, dev will still think the controls will be usable...

Passed on new design changes to Joy!

@Mehul1995 , can we all see it :-)

@guymerin @Mehul1995 please have a look.

it is good.
It is very good
It is very very good
Good job!

hahahaha.. I guess I have to figure out a way to make it look less like a movie poster with stamps everywhere.


mac: Unhandled promise rejections are deprecated

when run index.js，i get this error:
index.js

const puppeteer = require('puppeteer');

async function run() {
    const browser = await puppeteer.launch({
        args: [
          '--no-sandbox',
          '--disable-setuid-sandbox',
        ],
      });
    const page = await browser.newPage();

    await page.tracing.start({path: 'trace.json'})
    await page.goto("https://github.com");
    await page.tracing.stop()
    await page.screenshot({path: 'screenshot/github.png'});
    browser.close();
}

run();

node index.js
(node:2199) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error: Navigation Timeout Exceeded: 30000ms exceeded
(node:2199) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

env:
node: v8.3.0
os: 10.12.6

The script works just fine for me.
The error states that page.goto call failed to load the page in 30 seconds. Are you sure the script has access to the internet?

thanks, it's my fault. when i clean the proxy, it's ok.

@uimator Could you please tell me what you meant by clean the proxy?
Experiencing the same error and trying to rectify it.

@manujadev feel free to file a separate issue with your script, we'll be happy to help


Net Wrapper for Google's Filament

Summary of feature
Google's Filament is a C++, cross platform, straightforward graphics engine being developed by Google.
A while ago, they published a C compliant API so people could write wrappers over it.
Considering that Low level APIs like OpenGL/DirectX are not easy to use, this might be a good alternative for many developers.
Comments
Someone already tried to write a wrapper, but I think it's outdated and no longer supported.
https://github.com/google/filament/discussions/5923

That project looks really interesting! But I'm not sure how likely we'd be to add filament bindings ourselves.
Given it isn't a standard (like OpenGL/Vulkan) and isn't a widely accepted "standard" library (such as SPIRV-Cross), it doesn't fit the "feel" of the main Silk.NET project.
While that may be true, feel free to hop on our discord and discuss making community bindings based off of our code generator! We already have an example of this at the JackCS repo, which is a fully separate bindings project, still using the Silk.NET bindings generator.


Close gap with CLI

This may be a meta issue, it's not specific to the Go bindings (feel free to close/move the issue), but I'm opening it here since I'd be using the Go bindings.
Motivation
Users expect to be able to do the same things from the Go code than from the wasmer CLI.
Very concretely I need --mapdir and --env (https://github.com/wasmerio/wasmer/issues/475).
Proposed solution
Tediously implement all new CLI features in all the bindings.
Alternatives
Generate an Options struct that would be passed as a parameter to a NewInstance() constructor. The struct could be generated from a simple struct definition in the wasmer repo.

Thanks for the proposal. I'm not sure we can reflect all the wasmer CLI options with the current C/C++ bindings, but it's totally achievable.
Let's keep this issue open and let's address one feature at a time!

The CLI has been removed as we prefer to keep wasmer-go as a library. Closing this issue :-).


Drop support for ruby 2.3

Towards https://github.com/grpc/grpc/issues/25194
Plan to followup to drop support for ruby 2.4 in the next few months

cloud to cloud test failure: https://github.com/grpc/grpc/issues/25090

cloud to cloud test failure: https://github.com/grpc/grpc/issues/25090

basic tests c windows passed in https://source.cloud.google.com/results/invocations/038ec017-a811-4962-af4e-8b335694afec/targets, but the result is still shown as "pending" here

basic tests c windows passed in https://source.cloud.google.com/results/invocations/038ec017-a811-4962-af4e-8b335694afec/targets, but the result is still shown as "pending" here


[ClangImporter][NOMERGE] Redeclarations as Refinements

Try to curb the double-imports behavior seen today by rejecting all
properties that fail the override check. This also happens to catch and
provide a reasonable semantics for the protocol test declared in the
previous commit.
The second commit loosens the conditions under which we merge getter/setter pairs in disparate DeclContexts and will require more rigorous qualification.  If I'm right, though, it will solve a whole class of SDK problems in the post-re-entrant Clang Importer.
⚠ DO NOT MERGE THIS ⚠

@swift-ci test

@swift-ci test

@swift-ci test

@swift-ci test source compatibility

@swift-ci test source compatibility

Note to self: Stick rdar://59125907 into the commit message too.

@swift-ci please smoke test

@swift-ci please smoke test

⛵


refactor!: rename outdated channel type names to new

About
Title.
link to merged ddocs pr https://github.com/discord/discord-api-docs/pull/5322
Checklist

[ ] I've ran pre-commit to format and lint the change(s) made.
[ ] I've checked to make sure the change(s) work on 3.8.6 and higher.
[ ] This fixes/solves an Issue (If existent):.

resolves #

I've made this pull request for/as: (check all that apply)

[ ] Documentation
[x] Breaking change
[ ] New feature/enhancement
[ ] Bugfix

Can we maybe also keep the old names so it's not breaking?

Can we maybe also keep the old names so it's not breaking?

Ignore it


How to overrite calendar directive?

When I am impliment my own directive its give following error:
angular.js:13920 Error: [$compile:multidir] Multiple directives [mwlCalendarWeek (module: mwl.calendar), mwlCalendarWeek (module: mwl.calendar.docs)] asking for new/isolated scope on:
Link to error:
https://docs.angularjs.org/error/$compile/multidir?p0=mwlCalendarWeek&p1= (module: mwl.calendar)&p2=mwlCalendarWeek&p3= (module: mwl.calendar.docs)&p4=new%2Fisolated scope&p5=<mwl-calendar-week events%3D"vm.events" view-date%3D"vm.viewDate" on-event-click%3D"vm.onEventClick" on-event-times-changed%3D"vm.onEventTimesChanged" day-view-start%3D"vm.dayViewStart" day-view-end%3D"vm.dayViewEnd" day-view-split%3D"vm.dayViewSplit" day-view-event-chunk-size%3D"vm.dayViewEventChunkSize" on-timespan-click%3D"vm.onTimespanClick" on-date-range-select%3D"vm.onDateRangeSelect" custom-template-urls%3D"vm.customTemplateUrls" ng-switch-when%3D"week">
The github issues tracker is for bug reports and feature requests ONLY. Please use stackoverflow or read the documentation and examples for support issues, as well as checking previous issues.
Issues that ignore this template will be closed without notice!
Bug description / Feature request:
Link to minimally-working plunker that reproduces the issue (starter template: http://plnkr.co/edit/LE4F4U7AnnD3tjM9ZH4G?p=preview)
Versions
Angular:
Calendar directive:
Browser name and version:

Sounds like you have 2 directives with the same name (mwlCalendarWeek) maybe? Please use stackoverflow for support questions


Algebraic sum update function

Update Function for modifying integer values by addition or subtraction

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 18 Jul 2010 at 6:06

Blocking: #18

Original comment by<EMAIL_ADDRESS>on 19 Jul 2010 at 5:43

Changed title: Algebraic sum update function
Added labels: Priority-Medium, Project-Terrastore

Original comment by<EMAIL_ADDRESS>on 18 Jul 2010 at 6:07

Changed state: Accepted

Yes - Closed as of this comment.

Original comment by<EMAIL_ADDRESS>on 23 Jul 2010 at 1:14

Changed state: Fixed

Sven,

can we close this one as fixed?

Original comment by<EMAIL_ADDRESS>on 23 Jul 2010 at 12:50


ORM Cookbook Updates (TryCRUD, Immutable, Test Suites, Model Organizations)

It contains a lot of updates due to the fact that I had organized the models into single folder. I could not run my Setup.cs for now on my DEV machine. Will revisit it later.
https://github.com/Grauenwolf/DotNet-ORM-Cookbook/issues/71
https://github.com/Grauenwolf/DotNet-ORM-Cookbook/issues/70
https://github.com/Grauenwolf/DotNet-ORM-Cookbook/issues/69
https://github.com/Grauenwolf/DotNet-ORM-Cookbook/issues/68
https://github.com/Grauenwolf/DotNet-ORM-Cookbook/issues/67
https://github.com/Grauenwolf/DotNet-ORM-Cookbook/issues/20

When you move .cs files, you may have to update the .md files to reflect the new locations.
For example, I have to change this line in SingleModelCrud.md
@snippet cs [../Recipes.RepoDb\Entities\EmployeeClassificationSingleModelCrud.cs] EmployeeClassificationSingleModelCrud

In case you were unaware, the @snippet is what allows us to embed source code directly into the markdown files without having to manually keep them in sync.

I was able to fix some of the tests, but the ImmutableTests and SingleModelCrudAsync tests are failing and I don't know why.

When you move .cs files, you may have to update the .md files to reflect the new locations.

I wasn't aware TBH, until earlier before I commit I found some conflicting files with regards to these. I had never pushed it as I do not have time. Will check for it.

I was able to fix some of the tests, but the ImmutableTests and SingleModelCrudAsync tests are failing and I don't know why.

I will look at it now.

I used to have these additional conflicts. Do not know why! I will investigate.

I found out that on the Recipes.RepoDb.SingleModelCrudAsync, the calls to UpdateAsync is recurring. So I fixed this!
For the Immutable, RepoDb does not support it actually. I have to somehow download the data from the DB as a mutable then set manually the result as immutable.

You can ignore conflicts in the .htm files. They are regenerated from the .md files when the project is built.

I have to somehow download the data from the DB as a mutable then set manually the result as immutable.

That's essentially what I do for NHibernate.

It is now working on my machine, I am updating the MD files now.

Confirmed all tests passing.


Sample not running on Safari

Safari: Version 9.0.3 (11601.4.4)
OSX: El Capitain 10.11.3 (15D21)
Throw this error at page load(http://codepen.io/darlanmendonca/full/JRGoxv)
[Error] Error while parsing the 'sandbox' attribute: 'allow-modals' is an invalid sandbox flag. (JRGoxv, line 239)

[Error] SyntaxError: Unexpected use of reserved word 'let' in strict mode
	(anonymous function)

Looks like my safari does not support the let, const and new ES keywords... Idk if it helps, but i've tried to declare let x = "hello" in my safari console and didn't worked, but on chrome have worked, so...

thanks @irineu I'm checking, in codepen I really forgot to enable babel transpile (es6 to es5)
I enabled in codepen now, probably works
I will publish in a gh-page, is more easy to publish and dont forget anything :D

check out pls, https://minimalist-components.github.io/mn-dialog/


Fix this build failure

let spring = Spring(to: 1, threshold: 0.1, system: coreAnimation)

Ambiguous reference to member 'coreAnimation(_:initialValue:)'

Solution is to cast:
let spring = Spring(to: CGFloat(1), threshold: 0.1, system: coreAnimation)

But we should support using literal numbers as well.

Obsolete.


Fix ".Experimental" VSIX renaming

The newly-split Cpp and Cs VSIX projects now use .Experimental in the Id for experimental builds, but there was logic leftover from the old legacy VSIX that said .Preview.

/azp run

/azp run

This is superseded by https://github.com/microsoft/WindowsAppSDK/pull/1341.


v0.74

upstream: https://github.com/PiotrDabkowski/Js2Py
Changes

Bump version and SHA
Fix for pip check not getting ran

Notes

Adds python 3.11 support
There is no HTTPS support for the home URL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_64zgya1q2s/clone/recipe/meta.yaml:15: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_64zgya1q2s/clone/recipe/meta.yaml:45: missing_pip_check: For pypi packages, pip check should be present in the test commands
ERROR: /tmp/abs_64zgya1q2s/clone/recipe/meta.yaml:57: http_url: http://piter.io/projects/js2py is not https
Errors were found

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_fb1ykqf35k/clone/recipe/meta.yaml:57: http_url: http://piter.io/projects/js2py is not https
Errors were found

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_77kofhan40/clone/recipe/meta.yaml:57: http_url: http://piter.io/projects/js2py is not https
Errors were found

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_7b_5apcz2i/clone/recipe/meta.yaml:57: http_url: http://piter.io/projects/js2py is not https
Errors were found

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_a6ubfyr07t/clone/recipe/meta.yaml:57: http_url: http://piter.io/projects/js2py is not https
Errors were found


Improve formatting and fix grammar in v3.4.0 guide

Preview: https://github.com/acjh/changeDbInAspnetboilerplate/blob/3e09bfd27f97cbf6c0a555b26b9140742c2c0455/abptemplate_3_4_0_NETcore_mvc_modulezero.md

@acjh : Thanks!

Could you explain why the downgrade is required?


fix: NavigationStarted Event for sub-frames

Is this part of https://github.com/GoogleChromeLabs/chromium-bidi/issues/1018?
If yes, then please add Bug: #1018 to the PR desc.


Buffers in LWJGL

I have a few questions about buffers in LWJGL 3.

Can I specify offset and length of an nio.Buffer? glBufferData simply accepts a buffer object but there is no offset and length parameter.
I found out that glBufferData can also accept a java array, but still, no offset and length parameter.

So what should do to reuse a big block of data with different offsets and lengths? Do I have to recopy them out? That sounds quite inefficient!

The method put of direct buffers is really fast. So it shouldn't be an issue. The best way to do is to use them directly. You can allocate them with BufferUtils.create<Float|Int|Byte|Char|Double|Int|Long|Pointer|Short>Buffer(int capacity);

For the offset, you have to use glBufferSubData.

@HackeurD Hi, thank you for your reply. But there are still some problems.

The put method may be fast, but why should I incur unnecessary copy at all? Also I have to allocate new buffers, which is also a problem.
The wiki says that we should use MemoryUtil class to allocate buffers, are you suggesting me to use BufferUtils instead?
I think glBufferSubData is used to modify part of the server-side buffer, not client-side buffer? Am I wrong?

Can I specify offset and length of an nio.Buffer? glBufferData simply accepts a buffer object but there is no offset and length parameter.

You set the buffer's position() and limit(), just like in any API that consumes NIO buffers. The only difference is that LWJGL only reads and never mutates the current position, which reduces the need for additional flip() and rewind() calls. This is all covered in the Bindings FAQ.

The put method may be fast, but why should I incur unnecessary copy at all? Also I have to allocate new buffers, which is also a problem.

You can do anything in LWJGL with zero copies. You don't even have to allocate that much, most short allocations can be replaced with stack allocations (see the MemoryStack class).

The wiki says that we should use MemoryUtil class to allocate buffers. Are you suggesting me to use BufferUtils instead?

BufferUtils should be your last option. The Memory FAQ contains more information.

I think glBufferSubData is used to modify part of the server-side buffer, not client-side buffer. Am I wrong?

You are correct.

I found out that glBufferData can also accept a java array, but still, no offset and length parameter.

That's true, array overloads do not support the equivalent of position/limit. One reason is that it would require introducing synthetic parameters to JNI functions, which is against LWJGL's design. Another reason is that using array overloads for functions like glBufferData is not recommended. This has to do with how Hotspot Critical Natives work (you generally don't call glBufferData enough times for it to be JIT compiled, which means additional copies anyway). Array overloads should only be used with small arrays and such functions either don't require custom offsets/lengths or the overhead from copying such short arrays is negligible.
Using a custom position for array parameters is out of the question, but if you really want to use a custom length, you can do it by having a look at LWJGL's source code. For example, glBufferData(int target, float[] data, int usage) is implemented with a call to JNI.callPPV(__functionAddress, target, (long)(data.length << 2), data, usage). You can see that there's an explicit size parameter (in bytes). Parameters like data are called "auto-sized" parameters in LWJGL and the corresponding size/length/count parameter is calculated automatically. This protects against crashing the JVM with illegal memory accesses.

@Spasi Oh thank you very much for the info. position() and limit() are exactly what I am looking for.
And the binding FAQ is quite informative. I have read the Memory FAQ but not the binding one, should've done that.
But I really don't think that offset and length are synthetic. The native C APIs have such parameters and almost every java method which operates arrays has them too.
Another problem. Though that I see Hotspot Critical Natives will block GC when calling in the JNI function. But does that mean that the array may still get moved after the function returns? And since OpenGL is highly asynchronous, wouldn't that be a problem?

But I really don't think that offset and length are synthetic. The native C APIs have such parameters and almost every java method which operates arrays has them too.

Most have a length parameter, but not an offset (pointer arithmetic in C does the job just fine). As I said above, for rare cases where you need to use the length parameter explicitly, LWJGL provides access to it via the "unsafe" overloads (methods with an n prefix) or via the JNI class.

But does that mean that the array may still get moved after the function returns? And since OpenGL is highly asynchronous, wouldn't that be a problem?

Most OpenGL functions, including glBufferData, consume the data specified before returning. If the actual work is done later (asynchronously), the driver copies the data internally. The buffer may be deallocated by the user or moved by the GC and nothing bad will happen.
This is a problem only for functions that store the pointer to the data, such as glVertexAttribPointer. Which means such functions should not have array overloads. I'm reopening this issue until they are removed. If anyone can compile a list of similar functions, I would appreciate it.


WebView?

Does WebUI-Nim already support WebView?

Error: attempting to call undeclared routine: 'showWv'
In the latest version after importing
import webui

Error: attempting to call undeclared routine: 'showWv' In the latest version after importing import webui

use webui#head

error continues to occur, in addition nimble install installs versions from the neroist repository

good I see where there is an error "nimble install webui and nimble install https://github.com/webui-dev/nim-webui" they install the old version by some miracle

trying to install latest code, but nimble install webui@#head fails with: Version may only consist of numbers and the '.' character but found '-'.

@ITwrx try installing now, it should be fixed. (also seems like you should've opened a new issue for this?)

@neroist It works now, thanks!  I was just trying to be "low key" with only a comment instead of an issue. I figured i would just comment, and if anyone saw it and wanted to address it great, otherwise i would just wait on 2.5.0 (non beta) to have a tagged release. I wasn't in a huge hurry.


C# UWP NuGet v1.0.2: System.Exception when specifying videoProfileKind in LocalVideoTrackSettings

EDIT: updating because I was a dingbat and it's actually videoProfileKind that causes the exception, not width/height.
Summary
I'm getting a generic System.Exception when calling PeerConnection.AddLocalVideoTrackAsync(LocalVideoTrackSettings localVideoTrackSettings) where videoProfileKind is specified within the localVideoTrackSettings parameter.
Platform/Build

C# UWP app
Microsoft.MixedReality.WebRTC.UWP v1.0.2 NuGet package

Details
Below is the code snippet I'm using:
PeerConnection.LocalVideoTrackSettings localVideoTrackSettings = new PeerConnection.LocalVideoTrackSettings()
{
    enableMrc = false,
    framerate = 30.0,
    videoDevice = captureDevice,
    width = 1920,
    height = 1080,
    videoProfileKind = PeerConnection.VideoProfileKind.VideoConferencing
};

await Peer.AddLocalVideoTrackAsync(localVideoTrackSettings); ===> System.Exception thrown

If I don't specify videoProfileKind or set it to PeerConnection.VideoProfileKind.Unspecified, the above works and I receive frame events via Peer.I420LocalVideoFrameReady with a frame resolution of 1920x1080.
I can confirm that the above framerate, width and height are available for my camera as I enumerate all its capabilities (the above hardcoded values are for simplicity).

Exception Info
"Exception of type 'System.Exception' was thrown."

-	Data	{System.Collections.ListDictionaryInternal}	System.Collections.IDictionary {System.Collections.ListDictionaryInternal}
		Count	0	int

There was no inner exception.
Stack Trace
   at Microsoft.MixedReality.WebRTC.Interop.Utils.ThrowOnErrorCode(UInt32 res)
   at Microsoft.MixedReality.WebRTC.PeerConnection.<>c__DisplayClass74_0.<AddLocalVideoTrackAsync>b__0()
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)

Even if there is something bad I was passing in, which it doesn't seem like, it would be useful to have some more details on what the error could be.  Luckily this is not a blocker as I should be able to specify the desired widthxheight I need.
Cheers,
Andrej

Yes I agree with you in principle on error details. Unfortunately when WebRTC fails to create some object often it does not return any info, just a nullptr, so there is not a lot we know about the failure. And for video capture init, there are multiple calls like this. Also because of the interop we return just error codes, which is poorer than an actual message.
In this case I still suspect the video format is mismatching, since it works in the default case. Since I see you specify both the profile kind AND the resolution/framerate, are you 100% sure that the webcam supports that format (resolution + framerate) when that particular profile kind is selected? Can you please try to specify either the profile kind OR the resolution/framerate, and see if that works?

Try to see if 83119150dbce530a281c0be12bb231a8fadbc7f2 helps also, I added some logging that should show up in Debug builds in the VS Output window (or any other debugger).

Hi,
I did a bit more testing and created a blank UWP demo app and it still crashes even if only profile kind is set.  Here is my code snippet for the UWP MainPage OnLoaded event:
        private async void OnLoaded(object sender, RoutedEventArgs e)
        {
            // Request access to microphone and camera
            var settings = new MediaCaptureInitializationSettings();
            settings.StreamingCaptureMode = StreamingCaptureMode.AudioAndVideo;
            var capture = new MediaCapture();
            await capture.InitializeAsync(settings);

            // Retrieve a list of available video capture devices (webcams).
            List<VideoCaptureDevice> deviceList =
                await PeerConnection.GetVideoCaptureDevicesAsync();

            if (deviceList.Count == 0)
            {
                Log("ERROR: no video capture devices found.");
                return;
            }

            // Print out the webcam devices found.
            foreach (var device in deviceList)
            {
                // This message will show up in the Output window of Visual Studio
                Log($"Webcam: name={device.name}, id={device.id})");
            }

            _peerConnection = new PeerConnection();

            var config = new PeerConnectionConfiguration
            {
                IceServers = new List<IceServer> {
                    new IceServer{ Urls = { "stun:stun.l.google.com:19302" } }
                }
            };

            await _peerConnection.InitializeAsync(config);
            Log("Peer connection initialized successfully.");

            _peerConnection.I420LocalVideoFrameReady += OnI420LocalVideoFrameReady;

            // ##################### AREA OF INTEREST ###################
            Log("Adding local audio and video tracks");
            PeerConnection.LocalVideoTrackSettings localVideoTrackSettings = new PeerConnection.LocalVideoTrackSettings()
            {
                enableMrc = false,
                videoDevice = deviceList[0],
                videoProfileKind = PeerConnection.VideoProfileKind.VideoRecording
            };

            await _peerConnection.AddLocalVideoTrackAsync(localVideoTrackSettings);
            await _peerConnection.AddLocalAudioTrackAsync();
        }

I have 1 webcam and my output is:
Webcam: name=HD Pro Webcam C920, id=\\?\USB#VID_046D&PID_082D&MI_00#6&2053ea0a&2&0000#{e5323777-f976-4f5b-9b55-b94699c46e44}\global)
Peer connection initialized successfully.
Adding local audio and video tracks

Testing it further if I just set width, height and framerate, but not a video profile there is no exception:
PeerConnection.LocalVideoTrackSettings localVideoTrackSettings = new PeerConnection.LocalVideoTrackSettings()
{
    enableMrc = false,
    videoDevice = deviceList[0],
    framerate = 30.0,  <<==== works if setting framerate, width, height
    width = 640,
    height = 480,
    //videoProfileKind = PeerConnection.VideoProfileKind.VideoRecording
};

And just to see what happens when I set a ridiculous value, like framerate=1000.0 then I actually do get the same System.Exception as with passing in video profile kind.
Currently I'm using the NuGet package and haven't built from sources so I can't try 8311975  yet.  I think at this point though it's probably worthwhile for me to get jamming on building my own DLLs  :)
Cheers,
Andrej
p.s. I'd be happy to provide my sample UWP app VS solution if it helps.

Yes that's weird, the easiest way would be to at least build the MixedReality-WebRTC solution, that will get you a bit more information and it is relatively easy. Compiling the Google code is more difficult, but will get you all debug info. I am not quite sure yet why the detection algorithm is failing to find a matching format.

Quite strange indeed.  I'm going to dive into the docs for building from sources today.
One thing which would be great is to be able to toggle on verbose logging.  I've built the webrtc-uwp-sdk from sources and in debug I'm able to get low level verbose debug messages, for example:
(basicportallocator.cc:922): Discarding candidate because it doesn't match filter.
(basicportallocator.cc:1347): AllocationSequence: UDPPort will be handling the STUN candidate generation.
...
(peerconnection.cc:1231): Adding video transceiver in response to a call to AddTrack.
(peerconnection.cc:1231): Adding audio transceiver in response to a call to AddTrack.

I'm guessing this is because webrtc-uwp-sdk builds the webrtc.lib (707MB) from scratch.

I built the debug DLL from sources and it looks like the error result is because the webcam doesn't support video profiles.  The relevant log snippet:
(impl_webrtc_videocapturer.cpp:1172): Using local detection for orientation source
(impl_webrtc_videocapturer.cpp:1232): Init called for device \\?\USB#VID_046D&PID_082D&MI_00#6&2053ea0a&2&0000#{e5323777-f976-4f5b-9b55-b94699c46e44}\global
(impl_webrtc_videocapturer.cpp:1303): webrtc::VideoCapturer::init: Video capture device \\?\USB#VID_046D&PID_082D&MI_00#6&2053ea0a&2&0000#{e5323777-f976-4f5b-9b55-b94699c46e44}\global does not support video profiles, cannot assign requested video profile  or kind #1.
(interop_api.cpp:178): Failed to find a local video capture device matching the capture format constraints. None of the 1 devices tested had a compatible capture format.
(interop_api.cpp:727): Failed to open video capture device.
Exception thrown: 'System.Exception' in Microsoft.MixedReality.WebRTC.dll
An exception of type 'System.Exception' occurred in Microsoft.MixedReality.WebRTC.dll but was not handled in user code
Object not found.

As a solution, if the device doesn't support video profiles, how about logging a warning and then continuing with the standard path as if no video profile was specified?
Cheers,
Andrej

Ok right I didn't think about that one, sorry. I assumed you knew video profiles were available.
I already discussed a similar design question, and the rationale is that MixedReality-WebRTC is a library for developers, not an end user product. So I took the decision to always have hard errors when the implementation cannot honor the constraints passed by the caller, instead of trying a fallback alternative. This allows devs to implement any logic they want on top of this, like a fallback mechanism as you suggested, or anything else. But if we start to use hard-coded fallback mechanisms here and there, although convenient in some usage scenarios, they force a particular behavior, and devs using the library and expecting a video profile to be selected maybe want to know if something went wrong instead of getting back a video feed which is not using the profile they selected. The same approach is true for capture format : although we could have a fallback when the resolution specified is not found, this fallback is easily implemented on top of the existing library, while a developer targeting a very specific capture format will be notified of any failure instead of getting another capture format they did not request.
I agree though that we should have a better error reporting such that you don't have to build the core library from scratch, and can easily identify why an API call failed and how to make it work.

Would it be convenient for developers to have a "bool bestEffort" (defaults to false) in the options struct? How much boilerplate is needed for the dev to emulate this?

+1 on having some better error capture/warnings for unexpected cases such as this.  I totally understand the design approach of not doing a fallback procedure by default, but then the dev needs to know if something went wrong.  A warning log message is great and/or returning an error struct that is similar to an exception:
struct
{
   bool Success;
   ErrorCode ErroCode;   // optional enum
   string FailureReason;
}

Although at that point I guess it would be simpler to just toss an exception :)
I'd like to point out that many devs using this library are likely not seasoned and don't (yet) know all the details of WebRTC/SDP/Video Profiles/... so any help they can get figuring out what went wrong is most welcome.
Cheers,
Andrej


How much @nguniversal/express-engine adds to the bundle

This is not an issue, but rather just a question which I don't know where else to ask.
Since nguniversal/express-engine is required, how much it adds to the final bundle, assuming the AOT (tree-shaking) is done?
I wouldn't use this module if it uses a lot of code from nguniversal/express-engine. If it's the case, I would go with something smaller since I only need to detect a browser. The only way is for me to compile it twice and compare the stats.json output file, but my production compile times are pretty long, so it's easier for me to jusk ask. Thanks for understanding.

@flackjap
The support for @nguniversal/express-engine has been removed temporarily. Closing this issue.
Please try the release 1.2.2.
Feel free to re-open the issue if it persists.


refactor(data-toolbar): update chip-group structure

update for parity w/react implementation

PatternFly-Next preview: https://patternfly-next-pr-2445.surge.sh

:tada: This PR is included in version 2.41.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Failing on large digraph

Hey there!
I'm a huge fan of the library! I'm running into an issue where by using a ConvLSTM I'm getting a gigantic digraph. I was wondering if you had dealt with this issue before? You'll first need to .
To reproduce this:

run ! wget -q https://www.cs.toronto.edu/~nitish/unsupervised_video/mnist_test_seq.npy to get the data
run git clone git@github.com:IanQS/torchviz_convlstm_issue.git to get the repo
check out line 66 and 67 in debug_clstm.py where you'll see the issue.

            bla = make_dot(
                output, params=dict(model.named_parameters()), show_attrs=True, show_saved=True
            )
            bla.render("/tmp/model_y_hat_ob", format="png")

(you might want to put a breakpoint on bla.render("/tmp/model_y_hat_ob", format="png") but basically, you should see a digraph of size 2914

Might you have any solutions in mind?

Hey!
Is the problem that the graph is that the library fails to generate such a graph? Or that the final graph is so big it is not really usable anymore?
If it is the second case, then an approach like the one from https://github.com/ahgamut/torchrecorder might help as it will allow you to collapse nodes at a higher level (nn.Module level).

Ho. For the first one, if the "render" part is the slow one then I'm not sure there is much we can do about this here as that function is provided by the "dot" library that renders the graph.
And I've definitely seen it struggle before with very large graph (and the final image is not very readable anyways).


[Backport] Fix filtering on boolean values in transformation

Backport of #9812 to 0.18.0-iap.

Clean backport

All tests have passed except jdk11 integration tests, docs, and web console, which aren't needed to verify this PR


Entire section needs to be updated - 'Let anonymous people start a meeting'

[Hello, the setting in the below attached link isn't only associated with dial-in scenarios, but really controls if an anonymous user can start a meeting or not. For example, picture this: An organization allows anonymous join in their meetings and later decides that those users also should be able to start a meeting. This includes any anonymous user with access to the meeting link.
When these anonymous settings (join and start) are enabled the anonymous users can consequently join and start a meeting. The graphical UI was recently updated when I made the Teams team aware of the misleading informational text in TAC. You can see the improved info in the Teams meeting policies under Participants & guests when hovering.
Thanks,
https://docs.microsoft.com/en-us/microsoftteams/meeting-policies-participants-and-guests#let-anonymous-people-start-a-meeting
]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4521de2b-1aae-93de-ee1a-222146194700
Version Independent ID: b4f9087c-e1a3-8b47-917c-7c294d46fcca
Content: Manage meeting policies for participants and guests - Microsoft Teams
Content Source: Teams/meeting-policies-participants-and-guests.md
Service: msteams
GitHub Login: @CarolynRowe
Microsoft Alias: crowe

@ChristianJBergstrom thank you for reaching out. Just for clarity, are you suggesting having a note added advising that anonymous users can join/start a meeting if they have the meeting link?

@lindspea Hello! Well, more of removing all of the "dial-in" wording as this setting goes beyond that. It's basically a setting to decide if an anonymous user should be able to start a meeting, and not only join a meeting which is a separate setting.
This is just an example of how I would like to change it.
Original:
This setting is a per-organizer policy that allows for leaderless dial-in conferencing meetings. This setting controls whether dial-in users can join the meeting without an authenticated user from the organization in attendance. By default, this setting is turned off, which means dial-in users will wait in the lobby until an authenticated user from the organization joins the meeting.
Updated:
This setting is a per-organizer policy that allows an unauthenticated user to start a meeting. This setting controls whether anonymous users can join the meeting without an authenticated user from the organization in attendance. By default, this setting is turned off, which means unauthenticated/anonymous users will wait in the lobby until an authenticated user from the organization joins the meeting.

Let's do some research on this.  If this article pertains specifically to audio conferencing, then the dial-in conferencing  reference is correct.

Hello again, this is the suggested text I gave the Teams PG.

This is how the changed it in Teams admin center as it's not only for dial-in.

@scanum The dial-in reference is unchanged. Should be updated as the setting controls all unauthenticated users. Thanks.

Finally find the answer here, thanks!
We have some meetings that want to let the unauthenticated users join first and start the meeting from the meeting link. Without any authenticated users to join the meeting first.
I think this is the key option setting.


Implement cJSON and re-do CURL request structure

This should solve most of our memory problems.
This PR rips JSMN out of the project and replaces it with cJSON. As such, it re-does basically all of the JSON parsing.
Strings are re-designed as well, as is the structure of CURL requests to the OctoPrint server. Hopefully all of this will culminate into a reliable piece of software.
A few minor tweaks also include using q to quit cleanly, and the refresh rate being displayed on the UI.
Closes #3 #8 (and maybe #9).
valgrind --tool=memcheck --leak-check=full --track-origins=yes  ./odc
==356433== Memcheck, a memory error detector
==356433== Copyright (C) 2002-2017, and GNU GPL'd, by Julian Seward et al.
==356433== Using Valgrind-3.16.1 and LibVEX; rerun with -h for copyright info
==356433== Command: ./odc
==356433==
==356433==
==356433== HEAP SUMMARY:
==356433==     in use at exit: 569,481 bytes in 226 blocks
==356433==   total heap usage: 73,301 allocs, 73,075 frees, 18,529,019 bytes allocated
==356433==
==356433== 363 bytes in 1 blocks are definitely lost in loss record 23 of 48
==356433==    at 0x483BCE8: realloc (vg_replace_malloc.c:834)
==356433==    by 0x403777: writefunc (api.c:8)
==356433==    by 0x48B6E2A: ??? (in /usr/lib64/libcurl.so.4.6.0)
==356433==    by 0x48C5EAA: ??? (in /usr/lib64/libcurl.so.4.6.0)
==356433==    by 0x48AD496: ??? (in /usr/lib64/libcurl.so.4.6.0)
==356433==    by 0x48AE689: curl_multi_perform (in /usr/lib64/libcurl.so.4.6.0)
==356433==    by 0x48847B2: curl_easy_perform (in /usr/lib64/libcurl.so.4.6.0)
==356433==    by 0x40395E: octoprint_comm_recv (api.c:49)
==356433==    by 0x4027BC: main (main.c:101)
==356433==
==356433== LEAK SUMMARY:
==356433==    definitely lost: 363 bytes in 1 blocks
==356433==    indirectly lost: 0 bytes in 0 blocks
==356433==      possibly lost: 0 bytes in 0 blocks
==356433==    still reachable: 569,118 bytes in 225 blocks
==356433==         suppressed: 0 bytes in 0 blocks
==356433== Reachable blocks (those to which a pointer was found) are not shown.
==356433== To see them, rerun with: --leak-check=full --show-leak-kinds=all
==356433==
==356433== For lists of detected and suppressed errors, rerun with: -s
==356433== ERROR SUMMARY: 1 errors from 1 contexts (suppressed: 0 from 0)```

I'm gonna merge this. It's been running for months and has been doing really well.


Suppress progress bar depending on stdout context

The progress bar module will crash when firebase-import is running from cron or piping the stdout. Also, in some cases the progress bar "animation" can be annoying.

Thanks!  What would you think of using process.stdout.isTTY to auto-detect when stdout isn't a TTY instead (or additionally, if you really think the flag is also warranted)?

Hi @mikelehen! Your solution is much more elegant! Thanks. At the end, the flag looked very patchy... I will update the pull request.

Sorry, reckless edit directly from Github + lack of sleep. God bless peer-review! :) Thanks @mikelehen!

@mikelehen Could this PR be merged? Thanks!

Ack, sorry!  I missed the updated PR.  Merged!

Terrific, thanks.

And this is now included in the latest firebase-import (1.1.3) available on npm.

Great! Thanks!


cdc-debezium-source-kafka crashes at incoming delete event

When deleting a row the source crashes.
Steps to reproduce (what i did):

Build the cdc-debezium-source-kafka-jar according to the readme (tested on newest commit and the 1.0.0.M1 milestone)
Create docker conatiner according to the readme for mySQL
Additionally grant rights to another master user from where I can insert and delete
Start the jar with the configs from readme
Insert row into inventory.customers : (1005, 'Johannes', 'M'<EMAIL_ADDRESS>
This works fine, i get a log
2019-11-21 13:16:22.615  INFO 13271 --- [pool-1-thread-1] i.debezium.connector.mysql.BinlogReader  : 1 records sent during previous 00:00:09,37, last recorded offset: {ts_sec=1574338582, file=mysql-bin.000003, pos=824, row=1, server_id=223344, event=2}
and the message appears in the output topic.
<EMAIL_ADDRESS>
Delete the previously inserted row, source crashes

2019-11-18 14:02:51.393 ERROR 5848 --- [pool-1-thread-1] o.s.c.s.a.c.common.core.EmbeddedEngine   : Stopping connector after error in the application's handler method: null

java.lang.NullPointerException: null
    at org.springframework.cloud.stream.app.cdc.common.core.CdcCommonConfiguration.lambda$valueSerializer$1(CdcCommonConfiguration.java:81) ~[spring-cloud-starter-stream-common-cdc-debezium-core-1.0.0.BUILD-SNAPSHOT.jar!/:1.0.0.BUILD-SNAPSHOT]
    at org.springframework.cloud.stream.app.cdc.common.core.CdcStreamConfiguration.lambda$engine$0(CdcStreamConfiguration.java:59) ~[spring-cloud-starter-stream-common-cdc-debezium-core-1.0.0.BUILD-SNAPSHOT.jar!/:1.0.0.BUILD-SNAPSHOT]
    at org.springframework.cloud.stream.app.cdc.common.core.CdcStreamConfiguration.lambda$engine$1(CdcStreamConfiguration.java:83) ~[spring-cloud-starter-stream-common-cdc-debezium-core-1.0.0.BUILD-SNAPSHOT.jar!/:1.0.0.BUILD-SNAPSHOT]
    at org.springframework.cloud.stream.app.cdc.common.core.EmbeddedEngine$1.handleBatch(EmbeddedEngine.java:402) ~[spring-cloud-starter-stream-common-cdc-debezium-core-1.0.0.BUILD-SNAPSHOT.jar!/:1.0.0.BUILD-SNAPSHOT]
    at org.springframework.cloud.stream.app.cdc.common.core.EmbeddedEngine.run(EmbeddedEngine.java:839) ~[spring-cloud-starter-stream-common-cdc-debezium-core-1.0.0.BUILD-SNAPSHOT.jar!/:1.0.0.BUILD-SNAPSHOT]
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) ~[na:1.8.0_162]
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) ~[na:1.8.0_162]
    at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_162]

but still writes this message on the output topic
{"schema":{"type":"struct","fields":[{"type":"int32","optional":false,"field":"id"},{"type":"string","optional":false,"field":"first_name"},{"type":"string","optional":false,"field":"last_name"},{"type":"string","optional":false,"field":"email"}],"optional":true,"name":"my_app_connector.inventory.customers.Value"},"payload":null}
Maybe this is just some kind of misunderstanding of me of how to use the source-app and how to handle deletes/tombstones. I eventually want to deploy this on dataflow and build a custom application using the generated topic of events.

@JohannesM24 , thanks for reporting this issue! It is indeed a but in handling delete events when the dropTombstone is true (e.g. the default value).  This problem is likely to affect all deletion events for DB sources.
I'm working on a patch hopefully the PR will submitted later today. In the meat time you can use the --cdc.flattering.dropTombstones=false configuration which in case of delete generates additional Tombstones event.


fix(api-client): hotkey component

this pr does the following:

sets back the hotkey component to a ui component only
fixes style
moves the meta+k to the layout level so it can be called from any views (currently not working if we load from another view than request)
displays hotkey element on sidebar button only on app vs web
favors meta+n for handler (create request, cookie, env) while meta+k remains for the global command palette
constrains event action fired to route (first naive approach) which fix the meta+n displaying the request command palette in every view

before
on cookie page (both app + web)

after
on cookie page app

on cookie page web

I dig it. We need to show the ⌘K somewhere though!

still displayed in the request view sidebar

Looks good! Might be nice to provide the isApp logic instead of passing it down through so many layers. Maybe something like provide('layout', 'desktop', 'web', 'modal')?
Doesn't need to be in this PR though

i like that! let's ff with this


Helm-release slug should not allow capital letters

distorhead@werf:~$  werf slugify --format helm-release "greetingash-Dev"
greetingash-Dev

Then during deploy process:
Error: release install failed: release name greetingash-Dev is invalid: a DNS-1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')

Fixed in https://github.com/flant/werf/pull/2155


 fix typing and grammatical errors in README.md

Assign me this issue as I'm trying for hacktoberfest and will be a good start for me.

Thank you for your raising the issue and fixing the typos. I'll add the hacktoberfest-accepted label as soon as the PR#8 has been merged.


Flake8 Changes + Fixing Warnings

Overview: What does this pull request change?

Removed almost all of the warnings from pytest. Readded the flake8 plugins removed in #1323 for unknown reasons. Minor pre-commit changes to help with flake8 compliance.

Reviewer Checklist

[ ] The PR title is descriptive enough for the changelog, and the PR is labeled correctly
[ ] If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
[ ] If applicable: newly added functions and classes are tested

I do know this is nearly impossible to properly review. It's just some minor changes to code to remove flake8 ignores. The bulk of this is the fact that the trailing whitespace pre-commit hook got out of hand.

Should we be able to resolve all of the remaining open discussions here in time, I propose to merge this right after the release. (This almost certainly introduces merge conflicts with other PRs, which is inconvenient for the last few hours of work before the release.)

Ok, remind me after the release to update the pull to the latest version.

I did the requested changes.
I would prefer to do this merge sooner rather than later due to the merge conflicts it would likely cause.

Thanks :)

Thanks!


[Issue] nodejs and python terraform templates - Planning infrastructure provisioning failed

Templates todo-python-mongo-terraform and todo-nodejs-mongo-terraform fails during Planning infrastructure provisioning with same error
Pipeline run - https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1846110&view=results
Logs:
Terraform has been successfully initialized!
You may now begin working with Terraform. Try running "terraform plan" to see
any changes that are required for your infrastructure. All Terraform commands
should now work.
If you ever set or change modules or backend configuration for Terraform,
rerun this command to reinitialize your working directory. If you forget, other
commands will detect it and remind you to do so if necessary.
Generating terraform parameters...
Planning infrastructure provisioning |
Validating terraform template...
Planning infrastructure provisioning |
Generating terraform plan...
Planning infrastructure provisioning |
╷
│ Error: building AzureRM Client: Authenticating using the Azure CLI is only supported as a User (not a Service Principal).
│
│ To authenticate to Azure using a Service Principal, you can use the separate 'Authenticate using a Service Principal'
│ auth method - instructions for which can be found here: https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/guides/service_principal_client_secret
│
│ Alternatively you can authenticate using the Azure CLI by using a User Account.
│
│   with provider["registry.terraform.io/hashicorp/azurerm"],
│   on provider.tf line 18, in provider "azurerm":
│   18: provider "azurerm" {
│
╵
Error: planning deployment: planning infrastructure provisioning: terraform plan failed: err failed running terraform plan:  (exit status 1)
Planning infrastructure provisioning |
##[error]Bash exited with code '1'

Did not see this issue when running the terraform templates locally. Not sure if this is an issue with pipelines.

How was this run? Logged in as standard user or service principal? Running locally or in a pipeline?

How was this run? Logged in as standard user or service principal? Running locally or in a pipeline?
@wbreza
Pipeline run - https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1846110&view=results

@rajeshkamal5050  looking at the pipeline the ARM vars are set as pipeline variables but are not added to the task that runs the test. the fix is by adding an Env section to the task on line 170.
env:
# Required for Terraform service principal authentication
ARM_CLIENT_ID: $(arm-client-id)
ARM_CLIENT_SECRET: $(arm-client-secret)
ARM_TENANT_ID: $(arm-tenant-id)
I do not see to have access to this pipeline yaml though to update it.

@danieljurek can you help @HadwaAbdelhalem

This looks like we need to copy over the environment variables from our live testing and put them in our template testing step.
Making the PR now.

@rajeshkamal5050  can we close this one as fix PR got merged?

Done @HadwaAbdelhalem


Cannot Click to item4 in example

Hi
I can not click to item4 in example download on Github.

can't reproduce