Windows progress

First off, thank you for your wonderful work!
I've been tinkering on Windows with this, and anything that requires raylib.dll works, atleast the samples I tried. I'll be playing with this more!

Download the Windows release from: https://github.com/raysan5/raylib/releases, but don't choose the installer, choose the other one, like for the 3.5.0 release you download: raylib-3.5.0_win64_mingw-w64.zip if you are on a 64bits system or raylib-3.5.0_win32_mingw-w64.zip if you are on a 32bits system.
In the downloaded archive there is a /lib folder in there you'll find raylib.dll,  put this dll in the same folder as your resulting .exe file.

So say we want to run this https://github.com/greenfork/nimraylib_now/blob/master/examples/shapes/bouncing_ball.nim example. cd yourself into the folder, run nim c -r .\bouncing_ball.nim and make sure the dll is in the same folder, and you'll find yourself seeing this:

Current issues
Testing doesn't work
Running nimble testExamples gives the following error
PS P:\dev\gamedev\nimraylib_now> nimble testExamples
  Executing task testExamples in P:\dev\gamedev\nimraylib_now\nimraylib_now.nimble
no tests were found for pattern: 'tests/examples/**/*.nim'

Maybe this is has to do with how paths are handled differently on Windows and Linux?
Raygui
I downloaded raygui.dll from your release page, put it next to raylib.dll but the example still fails with:
could not load: raygui.dll
Running buildRaygui gives me the following error:
  Executing task buildRaygui in P:\dev\gamedev\nimraylib_now\nimraylib_now.nimble
stack trace: (most recent call last)
C:\Users\Rishi\AppData\Local\Temp\nimblecache-0\nimscriptapi_2903036856.nim(187, 16)
P:\dev\gamedev\nimraylib_now\nimraylib_now.nimble(26, 8) buildRayguiTask
C:\Users\Rishi\.choosenim\toolchains\nim-1.4.2\lib\system\nimscript.nim(186, 19) exec
C:\Users\Rishi\.choosenim\toolchains\nim-1.4.2\lib\system\nimscript.nim(186, 19) Error: unhandled exception: The system cannot find the file specified.
 [OSError]
     Error: Exception raised during nimble script execution

This might have to do with me not having raygui.o anywhere. I'll try to troubleshoot this tonight or tomorrow.

Thanks very much for the docs, this will definitely go to readme!
I fixed the issue with / so that it should be \ on Windows, this should solve testing.
With raygui it is a bit harder, the exact commands in nimble file are:
  let sourceFile = "raygui"/"src"/"raygui.h"
  exec "cc -x c -fPIC -c -o raygui.o -DRAYGUI_IMPLEMENTATION -DRAYGUI_SUPPORT_ICONS " & sourceFile
  exec "cc -shared -o libraygui.so -lraylib raygui.o"

On windows at least -o libraygui.so should be -o raygui.dll (as per conventions) and God knows what else. I searched for "how to compile a dynamic library for Windows" and got:

https://docs.microsoft.com/en-us/cpp/build/walkthrough-creating-and-using-a-dynamic-link-library-cpp?view=msvc-160
https://www.codeproject.com/Articles/84461/MinGW-Static-and-Dynamic-Libraries

The commands should be similar though. And raygui.h requires raylib.h to be in path, you can just download it from raylib if it's not loaded by default https://github.com/raysan5/raylib/blob/master/src/raylib.h

Thanks very much for the docs, this will definitely go to readme!
I fixed the issue with / so that it should be \ on Windows, this should solve testing.
With raygui it is a bit harder, the exact commands in nimble file are:
  let sourceFile = "raygui"/"src"/"raygui.h"
  exec "cc -x c -fPIC -c -o raygui.o -DRAYGUI_IMPLEMENTATION -DRAYGUI_SUPPORT_ICONS " & sourceFile
  exec "cc -shared -o libraygui.so -lraylib raygui.o"

On windows at least -o libraygui.so should be -o raygui.dll (as per conventions) and God knows what else. I searched for "how to compile a dynamic library for Windows" and got:

https://docs.microsoft.com/en-us/cpp/build/walkthrough-creating-and-using-a-dynamic-link-library-cpp?view=msvc-160
https://www.codeproject.com/Articles/84461/MinGW-Static-and-Dynamic-Libraries

The commands should be similar though. And raygui.h requires raylib.h to be in path, you can just download it from raylib if it's not loaded by default https://github.com/raysan5/raylib/blob/master/src/raylib.h

Could you test raygui usage with -d:nimDebugDlOpen, it should give more info on what's actually wrong with this dll. I personally took it from here: https://github.com/Guevara-chan/Raylib-Forever/releases
nim r -d:nimDebugDlOpen examples\original\basic.nim

Could you test raygui usage with -d:nimDebugDlOpen, it should give more info on what's actually wrong with this dll. I personally took it from here: https://github.com/Guevara-chan/Raylib-Forever/releases
nim r -d:nimDebugDlOpen examples\original\basic.nim

@zetashift could you update the bindings from latest master and try again. It should just work. Only raylib.dll should be present in the same directory

@zetashift could you update the bindings from latest master and try again. It should just work. Only raylib.dll should be present in the same directory

Running the shapes/bouncing_ball and the shapes/draw_ring example gives me on the latest master currently this error:
C:/Users/Rishi/.choosenim/toolchains/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/6.3.0/../../../../x86_64-w64-mingw32/bin/ld.exe: cannot find -lraylib
collect2.exe: error: ld returned 1 exit status
Error: execution of an external program failed: 'gcc.exe   -o P:\dev\gamedev\nimraylib_now\examples\shapes\bouncing_ball.exe  C:\Users\Rishi\nimcache\bouncing_ball_d\stdlib_io.nim.c.o C:\Users\Rishi\nimcache\bouncing_ball_d\stdlib_system.nim.c.o C:\Users\Rishi\nimcache\bouncing_ball_d\stdlib_dynlib.nim.c.o C:\Users\Rishi\nimcache\bouncing_ball_d\stdlib_winlean.nim.c.o C:\Users\Rishi\nimcache\bouncing_ball_d\stdlib_times.nim.c.o C:\Users\Rishi\nimcache\bouncing_ball_d\stdlib_os.nim.c.o C:\Users\Rishi\nimcache\bouncing_ball_d\@m..@s..@ssrc<EMAIL_ADDRESS><EMAIL_ADDRESS>-lraylib   '

I think I have to pass in the raylib headers somewhere then?

Running the shapes/bouncing_ball and the shapes/draw_ring example gives me on the latest master currently this error:
C:/Users/Rishi/.choosenim/toolchains/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/6.3.0/../../../../x86_64-w64-mingw32/bin/ld.exe: cannot find -lraylib
collect2.exe: error: ld returned 1 exit status
Error: execution of an external program failed: 'gcc.exe   -o P:\dev\gamedev\nimraylib_now\examples\shapes\bouncing_ball.exe  C:\Users\Rishi\nimcache\bouncing_ball_d\stdlib_io.nim.c.o C:\Users\Rishi\nimcache\bouncing_ball_d\stdlib_system.nim.c.o C:\Users\Rishi\nimcache\bouncing_ball_d\stdlib_dynlib.nim.c.o C:\Users\Rishi\nimcache\bouncing_ball_d\stdlib_winlean.nim.c.o C:\Users\Rishi\nimcache\bouncing_ball_d\stdlib_times.nim.c.o C:\Users\Rishi\nimcache\bouncing_ball_d\stdlib_os.nim.c.o C:\Users\Rishi\nimcache\bouncing_ball_d\@m..@s..@ssrc<EMAIL_ADDRESS><EMAIL_ADDRESS>-lraylib   '

I think I have to pass in the raylib headers somewhere then?

Yes, here is the line:
{.passL:"-lraylib".}

Possible problem is that mingw (gcc.exe) doesn't see the raylib.dll file. Possible solution: -L flag
nim r --passL:"-L<path/to/directory>" -d:nimDebugDlOpen examples\original\basic.nim

Another solution is to change {.passL:"-lraylib".} to something else, but I'm not sure what exactly
Searches on the topic, nothing seems to have the exact answer but for reference:

https://stackoverflow.com/questions/1985764/how-to-add-3rd-party-libraries-to-mingw
https://stackoverflow.com/questions/43311621/c-correct-way-to-statically-dynamically-link-with-mingw-w64
https://docs.microsoft.com/en-us/troubleshoot/windows-client/deployment/dynamic-link-library

Mingw website is currently down for some reason, would be good to browse their wiki once it's up e.g. this one http://www.mingw.org/wiki/LibraryPathHOWTO

Yes, here is the line:
{.passL:"-lraylib".}

Possible problem is that mingw (gcc.exe) doesn't see the raylib.dll file. Possible solution: -L flag
nim r --passL:"-L<path/to/directory>" -d:nimDebugDlOpen examples\original\basic.nim

Another solution is to change {.passL:"-lraylib".} to something else, but I'm not sure what exactly
Searches on the topic, nothing seems to have the exact answer but for reference:

https://stackoverflow.com/questions/1985764/how-to-add-3rd-party-libraries-to-mingw
https://stackoverflow.com/questions/43311621/c-correct-way-to-statically-dynamically-link-with-mingw-w64
https://docs.microsoft.com/en-us/troubleshoot/windows-client/deployment/dynamic-link-library

Mingw website is currently down for some reason, would be good to browse their wiki once it's up e.g. this one http://www.mingw.org/wiki/LibraryPathHOWTO

According to these answers:

https://stackoverflow.com/questions/185326/whats-a-dll-a-file
https://stackoverflow.com/q/13998575/8598954
And wiki:
https://en.wikipedia.org/wiki/Dynamic-link_library#Import_libraries

Seems that libraylibdll.a is also needed for linking
Raylib ships with 3 binaries:
raylib-3.5.0_win64_mingw-w64/lib/libraylib.a
raylib-3.5.0_win64_mingw-w64/lib/libraylibdll.a
raylib-3.5.0_win64_mingw-w64/lib/raylib.dll

and I assume that you need both libraylibdll.a and raylib.dll present.
Alternatively we might want to pass it like this "--passL:libraylibdll.a" as @enthus1ast did it here https://github.com/enthus1ast/raylib/blob/master/src/draylib.nim#L4

According to these answers:

https://stackoverflow.com/questions/185326/whats-a-dll-a-file
https://stackoverflow.com/q/13998575/8598954
And wiki:
https://en.wikipedia.org/wiki/Dynamic-link_library#Import_libraries

Seems that libraylibdll.a is also needed for linking
Raylib ships with 3 binaries:
raylib-3.5.0_win64_mingw-w64/lib/libraylib.a
raylib-3.5.0_win64_mingw-w64/lib/libraylibdll.a
raylib-3.5.0_win64_mingw-w64/lib/raylib.dll

and I assume that you need both libraylibdll.a and raylib.dll present.
Alternatively we might want to pass it like this "--passL:libraylibdll.a" as @enthus1ast did it here https://github.com/enthus1ast/raylib/blob/master/src/draylib.nim#L4

I remove this passL pragma from master so you have easier time tinkering with it. For me it now works like this:
nim r --passL:-lraylib examples/original/crown.nim

My current understanding is that one of these options should work for Windows if you have libray.dll and libraydll.a files in the same directory as exe:
nim r --passL:"-lraylib" examples\original\crown.nim
nim r --passL:"-L/path/to/exe/folder -lraylib" examples\original\crown.nim
nim r --passL:"libraylibdll.a" examples\original\crown.nim
nim r --passL:"-L/path/to/exe/folder libraylibdll.a" examples\original\crown.nim

Please let me know if one of these commands work or you find anything else. I think I will be able to automate path finding after we find the correct command and flags

I remove this passL pragma from master so you have easier time tinkering with it. For me it now works like this:
nim r --passL:-lraylib examples/original/crown.nim

My current understanding is that one of these options should work for Windows if you have libray.dll and libraydll.a files in the same directory as exe:
nim r --passL:"-lraylib" examples\original\crown.nim
nim r --passL:"-L/path/to/exe/folder -lraylib" examples\original\crown.nim
nim r --passL:"libraylibdll.a" examples\original\crown.nim
nim r --passL:"-L/path/to/exe/folder libraylibdll.a" examples\original\crown.nim

Please let me know if one of these commands work or you find anything else. I think I will be able to automate path finding after we find the correct command and flags

I remove this passL pragma from master so you have easier time tinkering with it. For me it now works like this:
nim r --passL:-lraylib examples/original/crown.nim

My current understanding is that one of these options should work for Windows if you have libray.dll and libraydll.a files in the same directory as exe:
nim r --passL:"-lraylib" examples\original\crown.nim
nim r --passL:"-L/path/to/exe/folder -lraylib" examples\original\crown.nim
nim r --passL:"libraylibdll.a" examples\original\crown.nim
nim r --passL:"-L/path/to/exe/folder libraylibdll.a" examples\original\crown.nim

Please let me know if one of these commands work or you find anything else. I think I will be able to automate path finding after we find the correct command and flags

I remove this passL pragma from master so you have easier time tinkering with it. For me it now works like this:
nim r --passL:-lraylib examples/original/crown.nim

My current understanding is that one of these options should work for Windows if you have libray.dll and libraydll.a files in the same directory as exe:
nim r --passL:"-lraylib" examples\original\crown.nim
nim r --passL:"-L/path/to/exe/folder -lraylib" examples\original\crown.nim
nim r --passL:"libraylibdll.a" examples\original\crown.nim
nim r --passL:"-L/path/to/exe/folder libraylibdll.a" examples\original\crown.nim

Please let me know if one of these commands work or you find anything else. I think I will be able to automate path finding after we find the correct command and flags

nim r --passL:"libraylibdll.a" examples\original\crown.nim works! As long as libraylibdll.a is in the same folder. nim r --passL:"-L/path/to/exe/folder libraylibdll.a" examples\original\crown.nim works too!
nim r --passL:"-lraylib" examples\original\crown.nim
nim r --passL:"-L/path/to/exe/folder -lraylib" examples\original\crown.nim
nim r --passL:"libraylibdll.a" examples\original\crown.nim
nim r --passL:"-L/path/to/exe/folder libraylibdll.a" examples\original\crown.nim

The first one errored out with: ld.exe: cannot find -lraylib collect2.exe: error: ld returned 1 exit status
Errors out with the same as above.
Works whoop whoop!
Works too!

The raygui example I tried worked too.

nim r --passL:"libraylibdll.a" examples\original\crown.nim works! As long as libraylibdll.a is in the same folder. nim r --passL:"-L/path/to/exe/folder libraylibdll.a" examples\original\crown.nim works too!
nim r --passL:"-lraylib" examples\original\crown.nim
nim r --passL:"-L/path/to/exe/folder -lraylib" examples\original\crown.nim
nim r --passL:"libraylibdll.a" examples\original\crown.nim
nim r --passL:"-L/path/to/exe/folder libraylibdll.a" examples\original\crown.nim

The first one errored out with: ld.exe: cannot find -lraylib collect2.exe: error: ld returned 1 exit status
Errors out with the same as above.
Works whoop whoop!
Works too!

The raygui example I tried worked too.

nimble testExamples still gives me the error:
PS P:\dev\gamedev\nimraylib_now> nimble testExamples
  Executing task testExamples in P:\dev\gamedev\nimraylib_now\nimraylib_now.nimble
no tests were found for pattern: 'tests\examples\**\*.nim'

nimble testExamples still gives me the error:
PS P:\dev\gamedev\nimraylib_now> nimble testExamples
  Executing task testExamples in P:\dev\gamedev\nimraylib_now\nimraylib_now.nimble
no tests were found for pattern: 'tests\examples\**\*.nim'

Running a single example using testament r I get this monstrosity:
https://play.nim-lang.org/#ix=2LLJ

Running a single example using testament r I get this monstrosity:
https://play.nim-lang.org/#ix=2LLJ

Thank you very much for the feedback, I'm glad we finally found the right flag!
Current master fixes problem with passL flags like this in raylib.nim:
when defined(windows):
  when defined(vcc):
    # Should it be `link` instead of passL?
    {.passL:"raylibdll.lib".}
  else:
    {.passL:"libraylibdll.a".}
else:
  {.passL:"-lraylib".}

And "no tests were found for pattern" problem by replacing "**" glob to just single "*" asterisk since double asterisk is not present in power shell, so the testament command is fixed to be like this:
task testExamples, "checks that all examples are correctly compiled":
  let pattern = "'tests"/"examples"/"*"/"*.nim'"
  exec "testament pattern " & pattern

In short, everything should work in regards to running and compiling any code if dll files are in the same directory as exe.
I don't know how to solve the problem with testament output though.
Let me know if the latest master works for you and I will release a new version and update readme accordingly.

Thank you very much for the feedback, I'm glad we finally found the right flag!
Current master fixes problem with passL flags like this in raylib.nim:
when defined(windows):
  when defined(vcc):
    # Should it be `link` instead of passL?
    {.passL:"raylibdll.lib".}
  else:
    {.passL:"libraylibdll.a".}
else:
  {.passL:"-lraylib".}

And "no tests were found for pattern" problem by replacing "**" glob to just single "*" asterisk since double asterisk is not present in power shell, so the testament command is fixed to be like this:
task testExamples, "checks that all examples are correctly compiled":
  let pattern = "'tests"/"examples"/"*"/"*.nim'"
  exec "testament pattern " & pattern

In short, everything should work in regards to running and compiling any code if dll files are in the same directory as exe.
I don't know how to solve the problem with testament output though.
Let me know if the latest master works for you and I will release a new version and update readme accordingly.

Samples I have tried, like crown/draw_ring/bouncing_ball work great on latest master by simply running:
nim c -r foo.nim ofcourse having the .dll and .a file in the same folder as resulting .exe.
Thank you!!

Samples I have tried, like crown/draw_ring/bouncing_ball work great on latest master by simply running:
nim c -r foo.nim ofcourse having the .dll and .a file in the same folder as resulting .exe.
Thank you!!

Great, thanks! A new version will be released soon

Great, thanks! A new version will be released soon

I can finally try this on my Linux laptop :P.
I'll close this, the examples might be a whole other issue.

I can finally try this on my Linux laptop :P.
I'll close this, the examples might be a whole other issue.

Mission completed indeed. Thank you for your time!

Mission completed indeed. Thank you for your time!


Update Envoy config to v3 APIs, bumps executor udpa go-control-plane

Finishes https://github.com/cloudfoundry/diego-release/issues/521

This looks good to me.

I somehow managed to lose the merge commit message when merging this PR, so I'm manually closing this PR.


Make DataWriter use DataWriterQos instead of WriterQos

Build status:

Linux
Mac
Windows
Performance

Build status:

Linux
Mac
Windows
Performance


{AzureIoT} fixes Azure/azure-sdk-for-python#27252 update description

fixes Azure/azure-sdk-for-python#27252
PR to update the description for create_device_with_sas method to "Creates a device identity on IoTHub that will use SAS as authentication method."

Learn Build status updates of commit 9c3d5da:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-autogen/azure-iot-hub/azure.iot.hub.IoTHubRegistryManager.yml
:warning:Warning
View (azure-python)
Details

docs-ref-autogen/azure-iot-hub/azure.iot.hub.IoTHubRegistryManager.yml

Line 7, Column 3: [Warning: xref-not-found] Cross reference not found: 'builtins.object'.
Line 40, Column 11: [Warning: xref-not-found] Cross reference not found: '<xref:if the HTTP response status is not in >[<xref:200>]<xref:.>'.
Line 92, Column 7: [Warning: xref-not-found] Cross reference not found: 'Union'.
Line 92, Column 43: [Warning: xref-not-found] Cross reference not found: ','.
Line 98, Column 11: [Warning: xref-not-found] Cross reference not found: '<xref:if the HTTP response status is not in >[<xref:200>]<xref:.>'.
Line 160, Column 7: [Warning: xref-not-found] Cross reference not found: 'Union'.
Line 160, Column 43: [Warning: xref-not-found] Cross reference not found: ','.
Line 166, Column 11: [Warning: xref-not-found] Cross reference not found: '<xref:if the HTTP response status is not in >[<xref:200>]<xref:.>'.
Line 228, Column 7: [Warning: xref-not-found] Cross reference not found: 'Union'.
Line 228, Column 43: [Warning: xref-not-found] Cross reference not found: ','.
Line 234, Column 11: [Warning: xref-not-found] Cross reference not found: '<xref:if the HTTP response status is not in >[<xref:200>]<xref:.>'.
Line 258, Column 11: [Warning: xref-not-found] Cross reference not found: '<xref:if the HTTP response status is not in >[<xref:200>]<xref:.>'.
Line 293, Column 11: [Warning: xref-not-found] Cross reference not found: '<xref:if the HTTP response status is not in >[<xref:200>]<xref:.>'.
Line 328, Column 11: [Warning: xref-not-found] Cross reference not found: '<xref:if the HTTP response status is not in >[<xref:200>]<xref:.>'.
Line 347, Column 11: [Warning: xref-not-found] Cross reference not found: '<xref:if the HTTP response status is not in >[<xref:200>]<xref:.>'.
Line 371, Column 11: [Warning: xref-not-found] Cross reference not found: '<xref:if the HTTP response status is not in >[<xref:200>]<xref:.>'.
Line 432, Column 11: [Warning: xref-not-found] Cross reference not found: '<xref:if the HTTP response status is not in >[<xref:200>]<xref:.>'.
Line 440, Column 11: [Warning: xref-not-found] Cross reference not found: '<xref:if the HTTP response status is not in >[<xref:200>]<xref:.>'.
Line 462, Column 11: [Warning: xref-not-found] Cross reference not found: '<xref:if the HTTP response status is not in >[<xref:200>]<xref:.>'.
Line 481, Column 11: [Warning: xref-not-found] Cross reference not found: '<xref:if the HTTP response status is not in >[<xref:200>]<xref:.>'.
Line 500, Column 11: [Warning: xref-not-found] Cross reference not found: '<xref:if the HTTP response status is not in >[<xref:200>]<xref:.>'.
Line 514, Column 11: [Warning: xref-not-found] Cross reference not found: '<xref:if the HTTP response status is not in >[<xref:200>]<xref:.>'.
Line 522, Column 11: [Warning: xref-not-found] Cross reference not found: '<xref:if the HTTP response status is not in >[<xref:200>]<xref:.>'.
Line 536, Column 11: [Warning: xref-not-found] Cross reference not found: '<xref:if the HTTP response status is not in >[<xref:200>]<xref:.>'.
Line 555, Column 11: [Warning: xref-not-found] Cross reference not found: '<xref:if the HTTP response status is not in >[<xref:200>]<xref:.>'.

This comment lists only the first 25 errors (including error/warning/suggestion) in the pull request.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Actually, I'm revoking my approval. I did a bit of digging and this isn't the correct place to update.
here is the actual place to update. If you don't update it there, the next release of that package will remove the manual update that you're adding here.
FYI @sima-zhu @danieljurek . No action here, I was just directly pinged which is why I'm looking at this PR.

@scbedd Thanks for your review. As per your suggestion, I have created the below PR: https://github.com/Azure/azure-iot-hub-python/pull/10

Closing this PR and tracking it here https://github.com/Azure/azure-iot-hub-python/pull/10


Enhance chat box

Feature ISSUES:

GTranslate Integration
Accessibility Features
Aria-labels
Flexible Layout
Overflow Control

UI ISSUES:

Enhanced Theme Toggle
Smooth Transition
Icon Visibility
Automatic Welcome Message
Browser Language Detection

I'd like to contribute these.
Pls do add gssoc extd,hacktoberfest labels.
@kvcops

try on the new features and let me know...as i want to see the changes in the ui that you make

Waiting for your update @EvanSingee

@EvanSingee
CC: @Wahid7852 @kvcops @techy4shri

It seems like we have to Close the issue...it takes a lot more time than expected

Closing this then @kvcops


JSONResultsReader not iterable when the result of the query is empty

Describe the bug
When using  oneshot, the JSONResultsReader object is not iterable, if the result of the query is empty. Other type of jobs haven't been tested.
To Reproduce
Adjust the script below for your own environment and construct a query which doesn't return results
from splunklib.results import JSONResultsReader
from splunklib import client as splunkclient

from getpass import getpass

HOST = "yourhost"
PORT = 8089
USER = "youruser"

if __name__ == "__main__":
    splunkservice = splunkclient.connect(
                host=HOST,
                port=PORT,
                username=USER,
                password=getpass(),
                scheme="https",
                autologin=True)

    kwargs = {
                "latest_time": "now",
                "earliest_time": "-1h",
                "output_mode":"json",
                "f":["*"]
            }

    query = 'search index=yourindex blablabla'

    r = splunkservice.jobs.oneshot(query=query, kwargs=kwargs, output_mode='json')
    print("done with query")
    res = JSONResultsReader(r)
    print("created JSONResultsReader object")
    l = list(res)
    print("converted to list")

Expected behavior
The program ends and the variable l is empty
Logs or Screenshots
The program doesn't terminate trying to iterate over res indefinitely
(venv) [user@system]$ python oneshot.py
Password:
done with query
created JSONResultsReader object

Splunk (please complete the following information):

Version: 8.1.2
OS: RHEL

SDK (please complete the following information):

Version: 1.7.2
Language Runtime Version:  Python 3.9
OS: RHEL 8

More updates and a possible workaround.
If one tries to read the content of ResponseReader returned by oneshot by using readall(), the program hangs. This doesn't happen though by trying to read one byte at the time gradually expanding the buffer size:
    r = splunkservice.jobs.oneshot(query=query, kwargs=kwargs, output_mode='json')
    print(f"Is empty:{r.empty}")
    for i in range (1,100):
        print(f"bytes read:{i}, content {r.read(i)}")

The program painfully and slowly tries to read the number of bytes requested:
[user@system]$ python oneshot.py
Password:
Is empty:False
bytes read:1, content b' '
bytes read:2, content b'  '
bytes read:3, content b'   '
bytes read:4, content b'    '
bytes read:5, content b'     '
bytes read:6, content b'      '
bytes read:7, content b'       '
bytes read:8, content b'        '
bytes read:9, content b'         '
bytes read:10, content b'          '
bytes read:11, content b'           '
bytes read:12, content b'            '
bytes read:13, content b'             '
bytes read:14, content b'              '
bytes read:15, content b'               '
bytes read:16, content b'                '
bytes read:17, content b'                 '
bytes read:18, content b'                  '
bytes read:19, content b'                   '
bytes read:20, content b'                    '
bytes read:21, content b'                     '

What is actually the content of that buffer?
    r = splunkservice.jobs.oneshot(query=query, kwargs=kwargs, output_mode='json')
    print(binascii.hexlify(r.read(5)))

---------------------------------------------------------------------------
[user@system]$ python oneshot.py
Password:
b'2020202020'

Possible workaround
Read the first n-bytes of ResponseReader, if they all equal to \x20, the response is empty
    r = splunkservice.jobs.oneshot(query=query, kwargs=kwargs, output_mode='json')
    if r.read(5) == b'\x20\x20\x20\x20\x20':
        print('empty response')
        sys.exit(0)

@lc4nt thank you for the details of the issue as well as for the workaround. We will look into this and provide an update soon.

Hi @lc4nt , we were not able to reproduce the issue. The given script executed successfully in our testing without any changes in the SDK.
Please let us know if anything is missed from the script that needs to be tested.

Closing the Issue as we haven't received any response. @lc4nt please reopen the Issue if you are still facing the issue.


Rearrange directory structure to use /vendor folder?

I'm curious what the plan is in light of this proposal to add a -vendor flag to the go tool?
https://groups.google.com/d/msg/golang-dev/74zjMON9glU/4lWCRDCRZg0J
related #127

The very rough plan is to change godep to use the new /vendor/ directory layout, possibly guarded by a command line flag. Then if the go tool -vendor flag is successful, godep will use that layout by default and remove import path rewriting (the -r flag) entirely.

Do you think it makes sense to keep modifying godep, or perhaps the directory change is a good time to come up with a tool under a new name (possibly using a lot of the same code)?

I'm going to help update godep to support the new format, but I won't have the time it would take to devote to a whole new tool.

However, that certainly shouldn't stop anyone else if they want to try that route. Godep is open source, so if its code would help they are welcome to use it!

@nathany What would be the purpose of "coming up with a tool under a new name"?

@ngrilly It just seems a little awkward to support multiple ways of doing it from a single tool, as a user.
But eventually godep will get there (once -r is gone and only one directory structure is supported, at least for new projects).

See #240. I'm going to close this and urge anyone with input to discuss there. Thanks!

d to r/c/Godeps/_workspace/src/d and copy r/p to r/c/Godeps/_workspace/src/r/p. Change any import statement in r/c and the tree rooted at r/c from "d" to “r/c/Godeps/_workspace/src/d” and from “r/p” to “r/c/Godeps/_workspace/src/r/p”. Note that import statements in r/p remain unchanged.


liblapack: disable select tests on all darwin platforms

Motivation for this change
I missed broken x86-64-darwin in #116579.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Thank you!


[Bug]: Mocking in one test function is applied to all test function globally.

Description
$subject
main.bal
function intAdd() returns string {
    return "hey";
}

test.bal
@test:Config {before: intAddBefore, after: intAddAfter}
function testMockFunction() {
    test:when(mockFun).thenReturn("hello");
    test:assertEquals(intAdd(), "hello");
}

@test:Config {}
function testMockFunction2() {
    test:assertEquals(intAdd(), "hello"); // "hey" should be the result.
}

In the above test cases, both of the tests are passing. But,  testMockFunction2 should fail.
Steps to Reproduce
No response
Affected Version(s)
No response
OS, DB, other environment details and versions
No response
Related area
-> Compilation
Related issue(s) (optional)
No response
Suggested label(s) (optional)
No response
Suggested assignee(s) (optional)
No response

We can use the below implementation to resolve the issue.
@test:Mock {functionName: "intAdd"}
test:MockFunction mockFun = new ();

function intAddBefore() {
    test:when(mockFun).thenReturn("hello");
}

function intAddAfter() {
    test:when(mockFun).callOriginal();
}

@test:Config {before: intAddBefore, after: intAddAfter}
function testMockFunction() {
    test:assertEquals(intAdd(), "hello");
}

@test:Config {}
function testMockFunction2() {
    test:assertEquals(intAdd(), "hello");
}

Closing since a workaround is provided. This will be fixed with the new mocking framework.


fix (dashboard import): update  cross filter scoping chart id references during dashboard import

during the dashboard import, cross filter scoping is not retained because of not updating chart id references. this commit contains the necessary fix for the same.
this  pull request provides the fix for the issue
#19944
slack discussion: https://apache-superset.slack.com/archives/C015WAZL0KH/p1699248398108929
SUMMARY
updated the utils.py to update the chart id references for cross filter scoping also. currently chart id reference updates is present for native filters, position and few others, but not for cross filter scoping.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

create dashboard with more than 2 charts and apply cross filter scoping.  as shown below.
export the dashboard.
if you are importing in the same environment, then delete dashboard and charts.
import the dashboard again.
expectation is cross filter scoping should be retained.
actual is cross filter scoping has been removed and global cross filter scoping changes to all charts.
dashboard in env1

BEFORE FIX
dashboard after importing to env2

AFTER FIX
dashboard after importing to env2

TESTING INSTRUCTIONS

create dashboard with cross filter scoping.
export the dashboard.
delete the dashboard and charts used in dashboards.
import the dashboard
check the cross filter scoping

ADDITIONAL INFORMATION

Fixes "#19944"

[x] Has associated issue: #19944
[ ] Required feature flags:
[ ] Changes UI:
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

@john-bodley @michael-s-molina @villebro  could you please review this PR. This is kind of blocker to use import/export feature for dashboard, since people need to make the changes manually after importing dashboard as cross filter scoping was not retained.
i am contributing first time, please let me know if any changes required or to furnish more info.

@betodealmeida do you think it would make sense to start phasing both the pseudo-ids that are used on the frontend, and the serial ids used on the backend, and replace them all with their respective uuid representations? This way we wouldn't have to do all this complicated remapping during import/export..

@john-bodley @michael-s-molina @villebro could you please review this PR. This is kind of blocker to use import/export feature for dashboard, since people need to make the changes manually after importing dashboard as cross filter scoping was not retained. i am contributing first time, please let me know if any changes required or to furnish more info.

@chanduapple thanks for the contribution, and I agree with the changes done here. I'll let CI complete before reviewing the code. Also, I'm not sure if our current test suites have tests for similar re-mappings (the native filters may have one), but if it's possible, it would be great if you could add a test to cover this particular fix.

@villebro is there any guideline/info about adding tests, like how to add test and run, I will go through once, I have tested manually.

@chanduapple the CONTRIBUTING.md has some directives for running the test suites: https://github.com/apache/superset/blob/master/CONTRIBUTING.md#testing The relevant tests I think you're interested in are in https://github.com/apache/superset/blob/master/tests/integration_tests/import_export_tests.py.

@villebro i have fixed below earlier CI workflow issues.

pull request title has been modified.
removed trailing white spaces.
List error
R0912: Too many branches (18/15) (too-many-branches)

Could you please approve the workflow to be rerun and review the code changes?
@betodealmeida @john-bodley

@villebro @betodealmeida  could you please review and approve, let me know if any thing to be modified. please help me out here.

Looks like this one needs the pre-commit hooks  run. Hope we can get it through and close out the old issue!

Any updates on this folks? We are blocked by this issue to export->import charts with cross-filter scoping.


fixes #5379

Type of Change

[x] Bug fix (non-breaking change, fixes #5379 )
[ ] New feature (non-breaking change, adds functionality)
[ ] Breaking change (effects multiple commands or functionality)
[x] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[x] Pester test is included
[ ] If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
[ ] Nunit test is included
[ ] Documentation
[ ] Build system

Purpose
Removing "LATEST" needs, PS code is already compatible, it was mostly needed for the old logic of get-dbabuildreference and the webpage (https://sqlcollaborative.github.io/builds)
Approach
I just updated the webpage code to avoid considering LATEST, so for all intents and purposes this is not breaking behaviours in both the PS code (Get-DbaBuildReference, Test-DbaBuild) and the webpage.
Everything works with the index carrying "LATEST" and the one not carrying it, so IMHO it's safe to merge as soon as tests pass. Other than modifying the buildreference I just stripped the test that were checking that a LATEST was in the correct place, since it's not needed anymore.
BEWARE: once merging this it'd be better to update https://github.com/sqlcollaborative/sqlcollaborative.github.io/blob/master/assets/dbatools-buildref-index.json too.

thanks, niph!


Remove paper wrappers around the text.

There is a listener that is causing focus to trigger on the first letter of the paragraphs when typing.  So, getting rid of the paper wrappers, which was there in the first place to reuse css rule.

This change is

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io


Create a script to ease release process

references to version should be incremented,
changelog should be populated
tag should be created
github release should be created

Reference: https://github.com/camptocamp/devops-stack/blob/master/docs/modules/ROOT/pages/howtos/release.adoc


Learn more text appearing under log window during launch

Which version of kubefirst are you using?
Not known
Which cloud provider?
None specific
Which DNS?
None specific
Which installation type?
UI (Console app)
Which distributed Git provider?
None specific
Did you use a fork of gitops-template?
No
Which Operating System?
None specific
What is the issue?
Learn more about text appearing under log window. Shouldn't be there.

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Reported by @jarededwards

Reported by @jarededwards

dealt with in this PR: https://github.com/kubefirst/console/pull/428


chgP2 function is missing

Function chgP2 is missing and causes a stack error when using url: localhost:4200/dumpobj/.  The value
 is the object name that is to be shown from global memory in the 'vpk' object.

function chgP2 was added to the utl.js module.  The fix was incorporated with the Compare Snapshot pull request.

The fix was tested and resolved the issue.


HDFS-17570 Respect Non-Default HADOOP_ROOT_LOGGER when HADOOP_DAEMON_ROOT_LOGGER is not specified in Daemon mode

Description of PR
the -Dhadoop.root.logger will use the value of HADOOP_ROOT_LOGGER.
In most cases, hadoop administrator tends to setup HADOOP_ROOT_LOGGER directly, it is effective in non-daemon mode and most hadoop administrator are not even aware of the existence of HADOOP_DAEMON_ROOT_LOGGER.
So when he started up HADOOP as daemon mode, no matter how he set up HADOOP_ROOT_LOGGER, the -Dhadoop.root.logger is not changed because in Daemon mode, the HADOOP_ROOT_LOGGER is set up by HADOOP_DAEMON_ROOT_LOGGER which is in fact a default value. The code is as below:
  if [[ "${HADOOP_DAEMON_MODE}" != "default" ]]; then
    HADOOP_ROOT_LOGGER="${HADOOP_DAEMON_ROOT_LOGGER}"
    if [[ "${HADOOP_SUBCMD_SECURESERVICE}" = true ]]; then
      HADOOP_LOGFILE="hadoop-${HADOOP_SECURE_USER}-${HADOOP_IDENT_STRING}-${HADOOP_SUBCMD}-${HOSTNAME}.log"
    else
      HADOOP_LOGFILE="hadoop-${HADOOP_IDENT_STRING}-${HADOOP_SUBCMD}-${HOSTNAME}.log"
    fi
  fi

This makes log setup and troubleshooting becomes very time consuming before we finally figure out the reason and the best practice without reading the code.
My change is:
In daemon mode

If user has customize(changed) HADOOP_ROOT_LOGGER but no HADOOP_DAEMON_ROOT_LOGGER, then we will respect HADOOP_ROOT_LOGGER as the final -Dhadoop.root.logger value, instead of setting up HADOOP_ROOT_LOGGER with the default HADOOP_DAEMON_ROOT_LOGGER and print a warning
In other cases, we will use HADOOP_DAEMON_ROOT_LOGGER(no matter it is default or customized), we will setup the HADOOP_ROOT_LOGGER  with this customized HADOOP_DAEMON_ROOT_LOGGER

How was this patch tested?

Testing Case
Expected Result

Customized HADOOP_LOGLEVEL
Respect HADOOP_LOGLEVEL

Without customizing anything
Respect default HADOOP_DAEMON_ROOT_LOGGER in daemon mode

Customize the HADOOP_DAEMON_ROOT_LOGGER without customizing HADOOP_ROOT_LOGGER
Respect customized HADOOP_DAEMON_ROOT_LOGGER

Customize the HADOOP_ROOT_LOGGER but not customize HADOOP_DAEMON_ROOT_LOGGER
Respect customized HADOOP_ROOT_LOGGER with a warning

Customize both HADOOP_ROOT_LOGGER and  HADOOP_DAEMON_ROOT_LOGGER
Respect customized HADOOP_DAEMON_ROOT_LOGGER

Customize the HADOOP_LOGLEVEL, should respect the HADOOP_LOGLEVEL and HADOOP_DAEMON_ROOT_LOGGER
export HADOOP_LOGLEVEL=DEBUG

root@rccd101-6a:/home/hadoop/current-hadoop# ps -ef|grep NameNode
hadoop   2852464       1 45 04:04 pts/1    00:00:09 /usr/lib/jvm/java-11-openjdk-amd64/bin/java -Dproc_namenode -Djava.net.preferIPv4Stack=true -Dhdfs.audit.logger=INFO,NullAppender -Dlog4j.configuration=file:/home/hadoop/current-hadoop/etc/hadoop/log4j-namenode.properties -XX:+UseG1GC -Xmx4096m -Dcom.sun.management.jmxremote=true -Dcom.sun.management.jmxremote.authenticate=false -Dcom.sun.management.jmxremote.ssl=false -Dcom.sun.management.jmxremote.port=1029 -Dhadoop.security.logger=ERROR,RFAS -agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=*:5005 -Dyarn.log.dir=/home/hadoop/hadoop-3.2.4/../logs -Dyarn.log.file=test-host-name.dev.corp.com.log -Dyarn.home.dir=/home/hadoop/hadoop-3.2.4 -Dyarn.root.logger=INFO,console -Djava.library.path=/home/hadoop/hadoop-3.2.4/lib/native -Dhadoop.log.dir=/home/hadoop/hadoop-3.2.4/../logs -Dhadoop.log.file=test-host-name.dev.corp.com.log -Dhadoop.home.dir=/home/hadoop/hadoop-3.2.4 -Dhadoop.id.str=hadoop -Dhadoop.root.logger=DEBUG,RFA -Dhadoop.policy.file=hadoop-policy.xml org.apache.hadoop.hdfs.server.namenode.NameNode

Without customizing anything, should respect default HADOOP_DAEMON_ROOT_LOGGER
root@rccd101-6a:/home/hadoop/current-hadoop# ps -ef|grep NameNode
hadoop   2855220       1 43 04:05 pts/1    00:00:07 /usr/lib/jvm/java-11-openjdk-amd64/bin/java -Dproc_namenode -Djava.net.preferIPv4Stack=true -Dhdfs.audit.logger=INFO,NullAppender -Dlog4j.configuration=file:/home/hadoop/current-hadoop/etc/hadoop/log4j-namenode.properties -XX:+UseG1GC -Xmx4096m -Dcom.sun.management.jmxremote=true -Dcom.sun.management.jmxremote.authenticate=false -Dcom.sun.management.jmxremote.ssl=false -Dcom.sun.management.jmxremote.port=1029 -Dhadoop.security.logger=ERROR,RFAS -agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=*:5005 -Dyarn.log.dir=/home/hadoop/hadoop-3.2.4/../logs -Dyarn.log.file=test-host-name.dev.corp.com.log -Dyarn.home.dir=/home/hadoop/hadoop-3.2.4 -Dyarn.root.logger=INFO,console -Djava.library.path=/home/hadoop/hadoop-3.2.4/lib/native -Dhadoop.log.dir=/home/hadoop/hadoop-3.2.4/../logs -Dhadoop.log.file=test-host-name.dev.corp.com.log -Dhadoop.home.dir=/home/hadoop/hadoop-3.2.4 -Dhadoop.id.str=hadoop -Dhadoop.root.logger=INFO,RFA -Dhadoop.policy.file=hadoop-policy.xml org.apache.hadoop.hdfs.server.namenode.NameNode

Customize the HADOOP_DAEMON_ROOT_LOGGER without customizing HADOOP_ROOT_LOGGER, should respect customized HADOOP_DAEMON_ROOT_LOGGER
export HADOOP_DAEMON_ROOT_LOGGER=TRACE,RFA

 root@rccd101-6a:/home/hadoop/current-hadoop# ps -ef|grep NameNode
 hadoop   2857093       1 99 04:06 pts/1    00:00:07 /usr/lib/jvm/java-11-openjdk-amd64/bin/java -Dproc_namenode -Djava.net.preferIPv4Stack=true -Dhdfs.audit.logger=INFO,NullAppender -Dlog4j.configuration=file:/home/hadoop/current-hadoop/etc/hadoop/log4j-namenode.properties -XX:+UseG1GC -Xmx4096m -Dcom.sun.management.jmxremote=true -Dcom.sun.management.jmxremote.authenticate=false -Dcom.sun.management.jmxremote.ssl=false -Dcom.sun.management.jmxremote.port=1029 -Dhadoop.security.logger=ERROR,RFAS -agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=*:5005 -Dyarn.log.dir=/home/hadoop/hadoop-3.2.4/../logs -Dyarn.log.file=test-host-name.dev.corp.com.log -Dyarn.home.dir=/home/hadoop/hadoop-3.2.4 -Dyarn.root.logger=INFO,console -Djava.library.path=/home/hadoop/hadoop-3.2.4/lib/native -Dhadoop.log.dir=/home/hadoop/hadoop-3.2.4/../logs -Dhadoop.log.file=test-host-name.dev.corp.com.log -Dhadoop.home.dir=/home/hadoop/hadoop-3.2.4 -Dhadoop.id.str=hadoop -Dhadoop.root.logger=TRACE,RFA -Dhadoop.policy.file=hadoop-policy.xml org.apache.hadoop.hdfs.server.namenode.NameNode
 root     2857504 2745542  0 04:07 pts/1    00:00:00 grep --color=auto NameNode

Customize the HADOOP_ROOT_LOGGER but not customize HADOOP_DAEMON_ROOT_LOGGER, should respect customized HADOOP_ROOT_LOGGER with a warning
export HADOOP_ROOT_LOGGER=TRACE,console

root@rccd101-6a:/home/hadoop/current-hadoop# sudo -u hadoop bin/hdfs --daemon stop namenode;
Using customized HADOOP_ROOT_LOGGER as final hadoop.root.logger. Recommending using HADOOP_LOGLEVEL or customize HADOOP_DAEMON_ROOT_LOGGER for logging in daemon mode.

root@rccd101-6a:/home/hadoop/current-hadoop# ps -ef|grep NameNode
hadoop   2874729       1 99 04:16 pts/1    00:00:07 /usr/lib/jvm/java-11-openjdk-amd64/bin/java -Dproc_namenode -Djava.net.preferIPv4Stack=true -Dhdfs.audit.logger=INFO,NullAppender -Dlog4j.configuration=file:/home/hadoop/current-hadoop/etc/hadoop/log4j-namenode.properties -XX:+UseG1GC -Xmx4096m -Dcom.sun.management.jmxremote=true -Dcom.sun.management.jmxremote.authenticate=false -Dcom.sun.management.jmxremote.ssl=false -Dcom.sun.management.jmxremote.port=1029 -Dhadoop.security.logger=ERROR,RFAS -agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=*:5005 -Dyarn.log.dir=/home/hadoop/hadoop-3.2.4/../logs -Dyarn.log.file=test-host-name.dev.corp.com.log -Dyarn.home.dir=/home/hadoop/hadoop-3.2.4 -Dyarn.root.logger=INFO,console -Djava.library.path=/home/hadoop/hadoop-3.2.4/lib/native -Dhadoop.log.dir=/home/hadoop/hadoop-3.2.4/../logs -Dhadoop.log.file=test-host-name.dev.corp.com.log -Dhadoop.home.dir=/home/hadoop/hadoop-3.2.4 -Dhadoop.id.str=hadoop -Dhadoop.root.logger=TRACE,console -Dhadoop.policy.file=hadoop-policy.xml org.apache.hadoop.hdfs.server.namenode.NameNode

Customize both HADOOP_ROOT_LOGGER and  HADOOP_DAEMON_ROOT_LOGGER, should respect customized HADOOP_DAEMON_ROOT_LOGGER
export HADOOP_DAEMON_ROOT_LOGGER=TRACE,RFA
export HADOOP_ROOT_LOGGER=TRACE,console

root@rccd101-6a:/home/hadoop/current-hadoop# ps -ef|grep NameNode
hadoop   2877521       1 61 04:18 pts/1    00:00:07 /usr/lib/jvm/java-11-openjdk-amd64/bin/java -Dproc_namenode -Djava.net.preferIPv4Stack=true -Dhdfs.audit.logger=INFO,NullAppender -Dlog4j.configuration=file:/home/hadoop/current-hadoop/etc/hadoop/log4j-namenode.properties -XX:+UseG1GC -Xmx4096m -Dcom.sun.management.jmxremote=true -Dcom.sun.management.jmxremote.authenticate=false -Dcom.sun.management.jmxremote.ssl=false -Dcom.sun.management.jmxremote.port=1029 -Dhadoop.security.logger=ERROR,RFAS -agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=*:5005 -Dyarn.log.dir=/home/hadoop/hadoop-3.2.4/../logs -Dyarn.log.file=test-host-name.dev.corp.com.log -Dyarn.home.dir=/home/hadoop/hadoop-3.2.4 -Dyarn.root.logger=INFO,console -Djava.library.path=/home/hadoop/hadoop-3.2.4/lib/native -Dhadoop.log.dir=/home/hadoop/hadoop-3.2.4/../logs -Dhadoop.log.file=test-host-name.dev.corp.com.log -Dhadoop.home.dir=/home/hadoop/hadoop-3.2.4 -Dhadoop.id.str=hadoop -Dhadoop.root.logger=TRACE,RFA -Dhadoop.policy.file=hadoop-policy.xml org.apache.hadoop.hdfs.server.namenode.NameNode

For code changes:

[x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[x] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
10m  8s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
shelldocs
0m  0s

Shelldocs was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 43s

trunk passed

+1 :green_heart:
mvnsite
0m 48s

trunk passed

+1 :green_heart:
shadedclient
19m 42s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 30s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
0m 41s

the patch passed

+1 :green_heart:
shellcheck
0m  2s

No new issues.

-1 :x:
shadedclient
2m 13s

patch has errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
0m 55s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch failed.

+1 :green_heart:
asflicense
0m 23s

The patch does not generate ASF License warnings.

69m 16s

Reason
Tests

Failed TAP tests
hadoop_basic_init.bats.tap

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6922/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6922

Optional Tests
dupname asflicense mvnsite unit codespell detsecrets shellcheck shelldocs

uname
Linux 72b4515ca60b 5.15.0-106-generic #116-Ubuntu SMP Wed Apr 17 09:17:56 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e65cb38acefe97017455c5cf2c6a39a319769969

TAP logs
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6922/1/artifact/out/patch-hadoop-common-project_hadoop-common.tap

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6922/1/testReport/

Max. process+thread count
552 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6922/1/console

versions
git=2.25.1 maven=3.6.3 shellcheck=0.7.0

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 21s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
shelldocs
0m  0s

Shelldocs was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
35m 33s

trunk passed

+1 :green_heart:
mvnsite
0m 53s

trunk passed

+1 :green_heart:
shadedclient
23m 12s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 34s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
0m 46s

the patch passed

+1 :green_heart:
shellcheck
0m  2s

No new issues.

+1 :green_heart:
shadedclient
23m 19s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
1m  2s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 24s

The patch does not generate ASF License warnings.

87m 23s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6922/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6922

Optional Tests
dupname asflicense mvnsite unit codespell detsecrets shellcheck shelldocs

uname
Linux fd88dc2efd10 5.15.0-106-generic #116-Ubuntu SMP Wed Apr 17 09:17:56 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 13dcc40d082bd1f1136aee9c383de4900c37a347

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6922/2/testReport/

Max. process+thread count
557 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6922/2/console

versions
git=2.25.1 maven=3.6.3 shellcheck=0.7.0

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 18s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
shelldocs
0m  0s

Shelldocs was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 34s

trunk passed

+1 :green_heart:
mvnsite
0m 47s

trunk passed

+1 :green_heart:
shadedclient
19m 44s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 29s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
0m 44s

the patch passed

+1 :green_heart:
shellcheck
0m  2s

No new issues.

+1 :green_heart:
shadedclient
19m 29s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 59s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 26s

The patch does not generate ASF License warnings.

76m 39s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6922/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6922

Optional Tests
dupname asflicense mvnsite unit codespell detsecrets shellcheck shelldocs

uname
Linux fbf8e0079eba 5.15.0-106-generic #116-Ubuntu SMP Wed Apr 17 09:17:56 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 6a82029851b37ac9b49e1cb716f52aae25cae5bd

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6922/3/testReport/

Max. process+thread count
552 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6922/3/console

versions
git=2.25.1 maven=3.6.3 shellcheck=0.7.0

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@aw-was-here @aajisaka  Would you please take a look for this?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
4m  1s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
shelldocs
0m  0s

Shelldocs was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
36m 47s

trunk passed

+1 :green_heart:
mvnsite
0m 47s

trunk passed

+1 :green_heart:
shadedclient
21m 43s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 30s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
0m 41s

the patch passed

+1 :green_heart:
shellcheck
0m  2s

No new issues.

+1 :green_heart:
shadedclient
22m 14s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 55s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 22s

The patch does not generate ASF License warnings.

89m 27s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6922/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6922

Optional Tests
dupname asflicense mvnsite unit codespell detsecrets shellcheck shelldocs

uname
Linux 5da9cb7bc23f 5.15.0-106-generic #116-Ubuntu SMP Wed Apr 17 09:17:56 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 83659c7c7a6346b4e51f83ff0770834bf5722d7d

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6922/4/testReport/

Max. process+thread count
552 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6922/4/console

versions
git=2.25.1 maven=3.6.3 shellcheck=0.7.0

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 21s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
shelldocs
0m  0s

Shelldocs was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
13m 43s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
23m  9s

trunk passed

+1 :green_heart:
compile
10m 46s

trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
compile
10m  9s

trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
checkstyle
2m 13s

trunk passed

+1 :green_heart:
mvnsite
1m 56s

trunk passed

+1 :green_heart:
javadoc
1m 31s

trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javadoc
1m 56s

trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
spotbugs
3m 40s

trunk passed

+1 :green_heart:
shadedclient
28m 17s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 21s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 19s

the patch passed

+1 :green_heart:
compile
10m 50s

the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javac
10m 50s

the patch passed

+1 :green_heart:
compile
9m 55s

the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
javac
9m 55s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
2m 19s

the patch passed

+1 :green_heart:
mvnsite
1m 45s

the patch passed

+1 :green_heart:
shellcheck
0m  2s

No new issues.

+1 :green_heart:
javadoc
1m 19s

the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javadoc
1m 40s

the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
spotbugs
3m 47s

the patch passed

+1 :green_heart:
shadedclient
28m 51s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
16m 20s

hadoop-common in the patch passed.

-1 :x:
unit
207m 16s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 47s

The patch does not generate ASF License warnings.

383m 43s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.TestAddOverReplicatedStripedBlocks

hadoop.hdfs.server.namenode.TestDefaultBlockPlacementPolicy

hadoop.hdfs.server.namenode.TestReencryption

hadoop.hdfs.server.blockmanagement.TestBlocksWithNotEnoughRacks

hadoop.hdfs.server.balancer.TestBalancer

hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes

hadoop.hdfs.TestReconstructStripedFile

hadoop.hdfs.TestErasureCodingMultipleRacks

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6922/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6922

Optional Tests
dupname asflicense mvnsite unit codespell detsecrets shellcheck shelldocs compile javac javadoc mvninstall shadedclient spotbugs checkstyle

uname
Linux 4dbaabf14a14 5.15.0-106-generic #116-Ubuntu SMP Wed Apr 17 09:17:56 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / cf8ead07201dd715ae12702aacc8553a58275066

Default Java
Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6922/5/testReport/

Max. process+thread count
4188 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6922/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2 shellcheck=0.7.0

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 19s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
shelldocs
0m  0s

Shelldocs was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
36m 30s

trunk passed

+1 :green_heart:
mvnsite
0m 51s

trunk passed

+1 :green_heart:
shadedclient
24m 51s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 29s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
0m 40s

the patch passed

+1 :green_heart:
shellcheck
0m  2s

No new issues.

+1 :green_heart:
shadedclient
25m  0s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 56s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 20s

The patch does not generate ASF License warnings.

91m 26s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6922/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6922

Optional Tests
dupname asflicense mvnsite unit codespell detsecrets shellcheck shelldocs

uname
Linux 5068e7a51e84 5.15.0-106-generic #116-Ubuntu SMP Wed Apr 17 09:17:56 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 0535f2d94a79e6eebb6effdedb92c6211f52fdbe

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6922/6/testReport/

Max. process+thread count
551 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6922/6/console

versions
git=2.25.1 maven=3.6.3 shellcheck=0.7.0

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


Remove --cfg uuid_unstable requirement for uuid_v7 feature

Issue #, if available:
Description of changes:
This PR removes the requirement that RUSTFLAGS="--cfg uuid_unstable" be provided to use the uuid_v7 feature flag, and thus the v7 feature flag from the uuid crate.
The uuid crate stabilized support for UUID v6-v8 in uuid-rs/uuid#718, which was included in the 1.6.0 release of the uuid crate. Since tracing-actix-web pulls the uuid crate using only the major version (1) and does not include the minor version, I believe it is safe to remove the --cfg uuid_unstable requirement.
Essentially, I just went through the changes done in #116 and removed some lines which were no longer applicable.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

That works, thanks!


Generalizing snapshotting

Summary of Changes
Changes the pod log aggregator to use labels instead of pod name.
Unit Tests
Ran snapshot tool to see if pods with correct labels were gathered.
Documentation Updates
N/A
Upgrade Considerations
N/A
Linked Issues
Closes #196

Misinterpreted how everything was setup, should capture everything correctly  now.


Using the Military Overlay datamodel does not show symbols in legend

When features are drawn using the Military Symbology Editor the features do not show in a legend in a map using ArcGIS Pro Layout.
using the dictionary render does show these symbols.

This is not necessarily an issue with the Military Overlay data model but an issue with any layers that are symbolized with the dictionary renderer so this issue should be reported to the Core.
They may not be able to make this a dynamic thing (adding symbols to the legend as they are edited/created), but a first step might be to allow a "generate legend"command from the Symbology "More" options:

This issue is not clear. There are contradicting statements made regarding the legend results from using the Dictionary Renderer. @csmoore and @topowright please update this issue with clear steps and screenshots showing the different behavior between MSE and Dictionary Renderer regarding the legend output.

I have not seen the legend updated using the dictionary renderer but there may be some workflow to do this that I am not familiar with.
Here is the legend -created by just switching the renderer with no extra steps- with:
Simple Renderer:

DictionaryRenderer:


feat: make search optional

trumps #292

:tada: This PR is included in version 2.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Type annotations for torchvision.ops

Addresses #2025

Thanks for the PR!
Unfortunately, torchscript currently doesn't support Union, so for the type annotations we need to use only one of the overload that are supported (and in many cases we only support one for torchscript)
Also, if a function argument is not annotated, torchscript assumes that the argument is a Tensor, so for the functions that are missing type annotations you can safely annotate them with Tensor.
Can you look into fixing this?

Thanks for the fast review! I have locally updated the code, but still have minor issues before pushing it.

Unfortunately, torchscript currently doesn't support Union, so for the type annotations we need to use only one of the overload that are supported (and in many cases we only support one for torchscript)

What to do with check_roi_boxes_shape(boxes) in _utils.py as boxes can be List[Tensor], Tuple[Tensor] or Tensor? Which one is preferred?

Also, if a function argument is not annotated, torchscript assumes that the argument is a Tensor, so for the functions that are missing type annotations you can safely annotate them with Tensor.

Is this for functions nested in _register_custom_op() in _register_onnx_ops.py, since they are only without annotations?

Is this for functions nested in _register_custom_op() in _register_onnx_ops.py, since they are only without annotations?

No, this is for all functions in torchvision which support torchscript.

What to do with check_roi_boxes_shape(boxes) in _utils.py as boxes can be List[Tensor], Tuple[Tensor] or Tensor? Which one is preferred?

As I mentioned in my previous comment, if there is no type annotation for an argument, torchscript assumes the argument is a tensor, so for check_roi_boxes_shape, we should use Tensor

Hi,
Test failures look weird, and might be due to the fact that CircleCI is running on your account. Let me have a look to understand what is going on.
cc @seemethere for thoughts

@iamvukasin I think the reason this is happening is because you have enabled builds for your fork on CircleCI.
Could you go and disable builds on your fork

Click this link -> https://app.circleci.com/settings/project/github/iamvukasin/vision
Click this button

@seemethere Definitely the problem was that the builds had been running with my CirceCI plan. I have stopped any further builds by following your guide.

@iamvukasin Can you try rebasing this PR on top of master to try running new CI jobs?


Crash due to invalid BankSignitures, caused by a locale issue

I did it 2 times. It gives this error at startup. I tried removing all the mods but its still same so i know its not mods. After trying the first time, i fixed files with steam verify. Then tried again to make sure but its still same error. I have +200gb free space on my SSD too. I even tried copying "PackedFileBackup" folder's backup files but it gives another error (I found it online "https://preview.redd.it/crash-on-start-up-v0-dqy5jmvb6djc1.png?width=696&format=png&auto=webp&s=69e948bb1fe8824d47b3b04a11f67cb167f3ffff")

BankSignatures.zip

If the game does not boot stock after running a Steam verify then you have a problem completely unrelated to my script.
I suggest completely deleting the No Man's Sky folder and then running a verify again.
Something strange is also going on in your BankSignitures, all your filenames with the letter I in it are showing up as ?s, which I have no idea what the cause of that might be.

I only have two guesses as to what could cause this:

Your system has some sort of untested locale or filesystem wreaking havoc that I could never have possibly accounted for. (I have no easy way of figuring this out without you giving me detailed system information.)
You are experiencing some sort of hardware failure, and you just don't know it yet.

If you'd rather, we could try and debug this over Discord instead so I can get some further details, but I sincerely doubt there's any problem that is caused by the script itself. If you want to, join the official No Man's Sky Discord and ping @cheatfreak in #modding.

Hi, thanks for the info but my game does work when i use steam verify. It only breaks after the script. I have English as main language for my PC but im Turk so there is a second language which is Turkish on my system. I guess that's the problem because in our language there is different letters like big i "İ" and small I "ı" that might be the problem. And the funny thing with windows is that after format my first language was Turkish, so when i changed to English some of the things duplicated like "denetim masası" in english its "control panel". When i type any one of them the control panel pops up. So i can use both language to find some of the things but not all of them.

Well from the info provided It looks like the problem is your Turkish locale with specifically NMSResign, so this is very likely a bug in the upstream tool NMSResign, but I need to A-B test it with you, and also verify the bug isn't in PSARC or some other part of the process (eg- PSARC is extracting the normal filenames to bad file names and the archives are bad or whatever).
Made an issue on the NMSResign tracker for this too, but for now we'll keep discussion on this issue thread.
#https://github.com/cheatfreak47/NMSResign/issues/1

@GreenSkull8 if you could hop back on the discord and help me A-B test a possible fix, that would be fine as well.

#https://github.com/cheatfreak47/NMSResign/issues/1 is confirmed as the cause by testing with @GreenSkull8, so this issue was invalid- the problem comes from upstream.


implement fill match arm assist for tuple of enums

This updates the fill match arm assist to work in cases where the user is matching on a tuple of enums.
Note, for now this does not apply when some match arms exist (other than the trivial _), but I think this could be added in the future.
I think this also lays the groundwork for filling match arms when matching on tuples of non-enum values, for example a tuple of an enum and a boolean.

I believe I've cleaned up / fixed all review feedback. I'm not sure who typically presses the 'Resolve conversation` button.
Let me know if you'd like to see anything else before this merges.

I'm not sure who typically presses the 'Resolve conversation` button.

GitHub does that when you change the code in a newer commit.

GitHub does that when you change the code in a newer commit.

That only works for me when I apply the code suggestions.

I'm not sure who typically presses the 'Resolve conversation` button.

Afaik, it's visible only for you, here's my version of the interface, with no button at all:

But there's a limited number of persons who can write bors r+ and fire the final check & merge, that's what important.

bors r+
Thanks!
To reiterate, if you feel like this, moving this to hir (somewhere around here) as a proper exhaustive match checking, that would be awesome. This will probably require reading rustc source code to learn how to do this properly though.

bors r+
Thanks!
To reiterate, if you feel like this, moving this to hir (somewhere around here) as a proper exhaustive match checking, that would be awesome. This will probably require reading rustc source code to learn how to do this properly though.

Thanks for the merge. I'll take a look at moving this to hir after tackling some of the low hanging fruit follow ups mentioned in this PR.


Hpcs for luks v2.7

Hi @sandeep-at-ibm.  Please merge this new PR.
Bump version and push out 2.7 packages:

  - Add complete partitioning and full move to new device to
    hpcs-for-luks-rootfs-config.sh; significantly reorder to
    ensure all data except necessary differences are
    synchronized between old and new devices.
  - Change Makefile parsing of utility version to work with
    older versions of GNU make.

Looks like there is nothing to merge on my end

@sandeep-at-ibm ^^^


Training?

Hello, I am trying to replicate your SFCN brain age prediction model to do my undergraduate thesis on top of it. My idea is to use your model that has great results and retrain it with part of my data and your input data. But I'm having some problems with the code, because machine learning is kind of new to me, could you share the code that was used to train the model or part of it, some parameters, anything would help? Thanks.

Yes. Nearly there - I'll release a tutorial notebook in a week or two.

But I'm having some problems with the code
Can you locate the bug (if any)?

Thanks, I'll be waiting for the tutorial, apreciate a lot.

Sorry to bother, but do you have some feedback for the tutorial?


use current json-c

Try using conda-forge's current version of json-c, adding the relevant patch from master.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe:

Jinja2 variable references are suggested to take a {{<one space><variable name><one space>}} form. See lines [35, 35].
License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Login Error in ubuntu

I am trying to host on my linux system
ubuntu@ip-172-31-43-83:~/gdrive-copy$ npm run clasp:login

><EMAIL_ADDRESS>clasp:login /home/ubuntu/gdrive-copy
> clasp login

Logging in globally...
🔑 Authorize clasp by visiting this url:
https://accounts.google.com/o/oauth2/v2/auth?access_type=offline&scope=https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fscript.deployments%20https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fscript.projects%20https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fscript.webapp.deploy%20https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fdrive.metadata.readonly%20https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fdrive.file%20https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fservice.management%20https%3A%2F%2Fwww.googleapis.com%2Fauth%2Flogging.read%20https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fcloud-platform&response_type=code&client_id=1072944905499-vm2v2i5dvn0a0d2o4ca36i1vge8cvbn0.apps.googleusercontent.com&redirect_uri=http%3A%2F%2Flocalhost%3A42920

(node:13988) UnhandledPromiseRejectionWarning: Error: Exited with code 3
    at ChildProcess.cp.once.code (/home/ubuntu/gdrive-copy/node_modules/opn/index.js:84:13)
    at Object.onceWrapper (events.js:317:30)
    at emitTwo (events.js:126:13)
    at ChildProcess.emit (events.js:214:7)
    at maybeClose (internal/child_process.js:915:16)
    at Socket.stream.socket.on (internal/child_process.js:336:11)
    at emitOne (events.js:116:13)
    at Socket.emit (events.js:211:7)
    at Pipe._handle.close [as _onclose] (net.js:561:12)
(node:13988) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:13988) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
^Cubuntu@ip-172-31-43-83:~/gdrive-copy$ npm run clasp:login

><EMAIL_ADDRESS>clasp:login /home/ubuntu/gdrive-copy
> clasp login

Logging in globally...
🔑 Authorize clasp by visiting this url:
https://accounts.google.com/o/oauth2/v2/auth?access_type=offline&scope=https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fscript.deployments%20https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fscript.projects%20https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fscript.webapp.deploy%20https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fdrive.metadata.readonly%20https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fdrive.file%20https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fservice.management%20https%3A%2F%2Fwww.googleapis.com%2Fauth%2Flogging.read%20https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fcloud-platform&response_type=code&client_id=1072944905499-vm2v2i5dvn0a0d2o4ca36i1vge8cvbn0.apps.googleusercontent.com&redirect_uri=http%3A%2F%2Flocalhost%3A36138

(node:14118) UnhandledPromiseRejectionWarning: Error: Exited with code 3
    at ChildProcess.cp.once.code (/home/ubuntu/gdrive-copy/node_modules/opn/index.js:84:13)
    at Object.onceWrapper (events.js:317:30)
    at emitTwo (events.js:126:13)
    at ChildProcess.emit (events.js:214:7)
    at maybeClose (internal/child_process.js:915:16)
    at Socket.stream.socket.on (internal/child_process.js:336:11)
    at emitOne (events.js:116:13)
    at Socket.emit (events.js:211:7)
    at Pipe._handle.close [as _onclose] (net.js:561:12)
(node:14118) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:14118) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

What version of node are you using?
You can try using clasp globally instead of the local version. Try
npm i -g clasp
clasp login

And see if that works?

Node version is:
ubuntu@ip-172-31-38-16:~$ node -v
v8.17.0
ubuntu@ip-172-31-38-16:~$ npm -v
6.13.4

I installed node using the following command:
curl -sL https://deb.nodesource.com/setup_8.x | sudo -E bash -
sudo apt-get install nodejs

Anyways, after running the above commands I get this:
root@ip-172-31-38-16:/home/ubuntu/gdrive-copy# npm i -g clasp

><EMAIL_ADDRESS>postinstall /usr/lib/node_modules/clasp
> node .

Installing @google/clasp...
Install failed. Must run with sudo.
+<EMAIL_ADDRESS>updated 1 package in 0.915s

root@ip-172-31-38-16:/home/ubuntu/gdrive-copy# sudo npm i -g clasp

><EMAIL_ADDRESS>postinstall /usr/lib/node_modules/clasp
> node .

Installing @google/clasp...
Install failed. Must run with sudo.
+<EMAIL_ADDRESS>updated 1 package in 0.921s
root@ip-172-31-38-16:/home/ubuntu/gdrive-copy#

I can't assist with debugging why clasp won't install on your machine, that is completely outside the realm of this application.


whitespace to allow vscode navigate the error location quickly

This change is to help when error detected, vscode terminal can quickly navigate the location(whitespace makes the loc clickable). cc @lijunchen

Pull Request Test Coverage Report for Build 1557
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.005%

Totals

Change from base Build 1556:
0.0%

Covered Lines:
2558

Relevant Lines:
2874

💛  - Coveralls


Existing  nodeclaims READY status becomes Unknown

Description
Observed Behavior:
When upgrading from 1.0.2 to 1.1.0, the existing nodeclaims READY status becomes Unknown and new nodeclaims created after the upgrade are READY: True . The nodeclaims in the Unknown state are registered to the cluster, and I don't see any errors in the debug logs.
Status of existing nodeclaim:
Status:
  Allocatable:
    Cpu:                        3920m
    Ephemeral - Storage:        89Gi
    Memory:                     29471Mi
    Pods:                       350
    vpc.amazonaws.com/pod-eni:  18
  Capacity:
    Cpu:                        4
    Ephemeral - Storage:        100Gi
    Memory:                     30310Mi
    Pods:                       350
    vpc.amazonaws.com/pod-eni:  18
  Conditions:
    Last Transition Time:  2024-12-06T01:24:44Z
    Message:
    Reason:                Launched
    Status:                True
    Type:                  Launched
    Last Transition Time:  2024-12-06T01:25:28Z
    Message:
    Reason:                Registered
    Status:                True
    Type:                  Registered
    Last Transition Time:  2024-12-06T01:25:59Z
    Message:
    Reason:                Initialized
    Status:                True
    Type:                  Initialized
    Last Transition Time:  2024-12-06T01:34:44Z
    Message:
    Reason:                ConsistentStateFound
    Status:                True
    Type:                  ConsistentStateFound
    Last Transition Time:  2024-12-06T20:55:32Z
    Message:               NodePoolDrifted
    Observed Generation:   1
    Reason:                NodePoolDrifted
    Status:                True
    Type:                  Drifted
    Last Transition Time:  2024-12-06T21:17:10Z
    Message:
    Observed Generation:   1
    Reason:                Consolidatable
    Status:                True
    Type:                  Consolidatable
    Last Transition Time:  2024-12-06T19:17:06Z
    Message:               Initialized=True, Registered=True, Launched=True
    Observed Generation:   1
    Reason:                ReconcilingDependents
    Status:                Unknown
    Type:                  Ready
  Image ID:                ami-02ebe9cc28f2e32f8
  Last Pod Event Time:     2024-12-06T21:07:10Z

Additionally, when a nodeclaim in an Unknown status is deleted, it briefly (before being terminated) updates its Status  to Ready.  The nodeclaims appear to be functional, as karpenter can disrupt them, and they are registered to the cluster so pods can be scheduled to their underlying nodes.
Expected Behavior:
Existing nodeclaims after the upgrade remain in READY: True status.
This was also discussed in slack
Reproduction Steps (Please include YAML):
Versions:

Chart Version: 1.1.0
Kubernetes Version (kubectl version):  v1.30

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

This should have been resolved with https://github.com/kubernetes-sigs/karpenter/pull/1869 and we are planning to release this with a v1.1.1 patch


Fix render issues refactoring

I have been running a whole year with this fix without any issues and I
am syncing it now. Fix #919

Thank you - this fix solved the problem!


fix: remove invalid es-builtins

These globals don't belong to ecma262, I moved them to node builtins. :)
fixes #260

It may introduce new linting errors, which, according to eslint's versioning policy, I categorize as feat.
https://github.com/eslint/eslint?tab=readme-ov-file#semantic-versioning-policy

it's to fix the issue: https://github.com/eslint-community/eslint-plugin-n/issues/260

tips: it's recommended to use rebase, to help release-please generate better changelogs. :)

As we're using squash merge, it actually makes no difference, as only the PR title is kept 👀
If we're using merge / rebase merge then 100% we'd need to worry :)

"node builtins" is repeated 2 times, and I'm not sure if it has anything to do with the use of merge:
https://github.com/eslint-community/eslint-plugin-n/blob/a70789a90c118f1ab69b8e1f5d4f1ac7f5dc3869/CHANGELOG.md#-features

😱 that makes no sense. I guess I will steer clear for now!


Support for JWKS?

I'm interested in support for JWKS. To me that means:

Create a public/private key set
Sign JWKs with private key
Verify JWKs with a public key

In the past I have typically used https://mkjwk.org but I would much prefer a holistic solution from this great library. Thanks!

Endorse! I don't touch JWTs these days unless there is a JWKs involved. Makes things like secret rotation and aggregation so much simpler and is pretty standard for OIDC implementations.


can't get response data

I'm sure service return data to me ,but when I use "response.body.toString()" there is nothing.
So I print out :java.io.InputStreamReader@42951fe0
what is that means?how can i get return data?

Try using string() instead of toString().


Putting  tag with navPush directive inside  tag forces user to double click on IOS

Ionic version:
[ ] 1.x (For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] 2.x
[X] 3.x
I'm submitting a ...
[X] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
on iOS, when a navPush directive is put inside an  that is inside a
 tag, the user has to click the link twice on ios to open (not an issue on desktop
Expected behavior:
On ios, the link should open on first click
Steps to reproduce:

   Link NameSome other text

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
cli packages: (/Users/tekm/projects/apricot-hybrid-web-app/node_modules)

    @ionic/cli-plugin-cordova       : 1.6.2
    @ionic/cli-plugin-ionic-angular : 1.4.1
    @ionic/cli-plugin-proxy         : 1.4.1
    @ionic/cli-utils                : 1.7.0
    ionic (Ionic CLI)               : 3.7.0

global packages:

    Cordova CLI : 7.0.1

local packages:

    @ionic/app-scripts : 2.1.3
    Cordova Platforms  : android 6.2.3 ios 4.4.0
    Ionic Framework    : ionic-angular 3.6.0

System:

    Android SDK Tools : 26.0.2
    Node              : v8.2.1
    OS                : macOS Sierra
    Xcode             : Xcode 8.3.3 Build version 8E3004b
    npm               : 5.3.0

Hello! Thank you for opening an issue with us! Would you be able to provide a sample application via GitHub that demonstrates the issue you are having?
I attempted to duplicate your issue in a sample application I have but could not. I tried this on both the emulator and on my iPhone.
Here is my markup:

    You really should Click Me!! I will open up a child window. It is cool. One Last Try!!

As you can see, I just took your markup and modified it slightly to work in my app (and added extra text), but it is essentially the same as yours.
Thanks for using Ionic!

Hello! Is this still an issue with the latest version of ionic? If so, can you please provide a GitHub repo with a sample app that demonstrates the issue? I will re-open this issue if that is the case.
Thanks!

Sorry @kensodemann I have a temp fix for this, I will create a repo next week and create a new issue. Thanks

@tolgaek - OK. You can also just link the repo here and I will re-open this issue rather than creating a new one. That would probably be best. Thanks!


Modifiers don't work with $replace rules

Steps to reproduce

Add this rule:
||example.com^$replace=/Example/Test/,script
Go here - http://example.com/

Expected behavior

Rule should be applied only to script
Actual behavior

Rule is applied to all requests
Screenshot:

Your environment

AdGuard for Windows nightly 7.1.2874 (CL 1.4.127)

core/pull-requests/1428


VARCHAR(MAX) : MAX unknown

Unknown what this means
While implementing the drug_exposure table I came across VARCHAR(MAX)
Currently this is implemented as so:
self['VARCHAR(MAX)'] = lambda x : x.fillna('').astype(str).apply(lambda x: x)

I have no idea how BCLink defines MAX, so it is currently undefined
All this information comes from https://github.com/CO-CONNECT/co-connect-tools/blob/master/coconnect/data/cdm/OMOP_CDM_v5_3_1.csv
which Tom once sent to me. It provides information about what format BCLink is expecting the data.

not relevant now


java.lang.UnsatisfiedLinkError on Android

Hi,
I'm about to move from sqldroid to your library, as I want to use encrypted files in an Android App.
When I open an connection with the code snippet you provided I get the following exception:
java.lang.UnsatisfiedLinkError: dlopen failed: library "libsqlitejdbc.so" not found         at java.lang.Runtime.loadLibrary0(Runtime.java:1087)         at java.lang.Runtime.loadLibrary0(Runtime.java:1008)         at java.lang.System.loadLibrary(System.java:1664)         at org.sqlite.core.NativeDB.<clinit>(NativeDB.java:34)         at org.sqlite.core.NativeDB.load(NativeDB.java:54)         at org.sqlite.SQLiteConnection.open(SQLiteConnection.java:256)         at org.sqlite.SQLiteConnection.<init>(SQLiteConnection.java:62)         at org.sqlite.jdbc3.JDBC3Connection.<init>(JDBC3Connection.java:23)         at org.sqlite.jdbc4.JDBC4Connection.<init>(JDBC4Connection.java:19)         at org.sqlite.JDBC.createConnection(JDBC.java:104)         at org.sqlite.JDBC.connect(JDBC.java:77)         at java.sql.DriverManager.getConnection(DriverManager.java:580)         at java.sql.DriverManager.getConnection(DriverManager.java:236)
Line where I open the connection:
this.connection = DriverManager.getConnection("jdbc:sqlite:"+path);
Line from my build.gradle:
implementation 'io.github.willena:sqlite-jdbc:3.37.2'
Am I doing anything wrong? The same line of code works fine, when in "desktop"-java
Thanks for your help

First of, I'm not an expert of android developement.
Here is what I was saying a similar issue: https://github.com/Willena/sqlite-jdbc-crypt/issues/48#issuecomment-913041722

I've never used it on android, but:

You should import the library usual
If you are getting an Error for missing library, Either the platform is not precompiled [...] or the binary file is not included as resource during the build time. If I remember well, it might be necessary [to create a libs folder or] to extract the DLL for android arm in the libs folder of your project (do not open the jar, just download them from releases, all DLL are available as a zip file).

I also found this Stack Overflow answer: https://stackoverflow.com/a/6295760/4346098
Hope it helped :)

Thanks for your answer. The posts in the links aren't completly right. But they helped me to find a solution.
If anyone else is having the same issue:

Download the .jar File and open it with 7zip/winrar or similar
Go to org/sqlite/native/Linux-Android
Copy all folders to the jniLibs-Folder of your Android-projekt (project/src/main/jniLibs; Complete folder structure: https://stackoverflow.com/a/24360361/9046587)

Additionally NDK has to be installed in Android Studio:
https://developer.android.com/studio/projects/install-ndk
Hope this helps somebody.


Setup.exe does not support Proxy Auth

The Setup.exe is not able to authenticate against Proxy. Setup will stop with ERROR 407.

As a school, we also use a proxy and the setup fails. Is there anyway of downloading the exe without needing to use the online setup?
ERROR DETAILS
Following errors were detected during this operation.
* [23/06/2021 10:19:39] System.Deployment.Application.InvalidDeploymentException (AppFileLocationValidation)
- HTTP redirect is not allowed for application files and assemblies. Cannot download IdFix.exe.
- Source: System.Deployment
- Stack trace:
at System.Deployment.Application.DownloadManager.ProcessDownloadedFile(Object sender, DownloadEventArgs e)
at System.Deployment.Application.FileDownloader.DownloadModifiedEventHandler.Invoke(Object sender, DownloadEventArgs e)
at System.Deployment.Application.FileDownloader.OnModified()
at System.Deployment.Application.SystemNetDownloader.DownloadSingleFile(DownloadQueueItem next)
at System.Deployment.Application.SystemNetDownloader.DownloadAllFiles()
at System.Deployment.Application.FileDownloader.Download(SubscriptionState subState, X509Certificate2 clientCertificate)
at System.Deployment.Application.DownloadManager.DownloadDependencies(SubscriptionState subState, AssemblyManifest deployManifest, AssemblyManifest appManifest, Uri sourceUriBase, String targetDirectory, String group, IDownloadNotification notification, DownloadOptions options)
at System.Deployment.Application.ApplicationActivator.DownloadApplication(SubscriptionState subState, ActivationDescription actDesc, Int64 transactionId, TempDirectory& downloadTemp)
at System.Deployment.Application.ApplicationActivator.InstallApplication(SubscriptionState& subState, ActivationDescription actDesc)
at System.Deployment.Application.ApplicationActivator.PerformDeploymentActivation(Uri activationUri, Boolean isShortcut, String textualSubId, String deploymentProviderUrlFromExtension, BrowserSettings browserSettings, String& errorPageUrl, Uri& deploymentUri)
at System.Deployment.Application.ApplicationActivator.PerformDeploymentActivationWithRetry(Uri activationUri, Boolean isShortcut, String textualSubId, String deploymentProviderUrlFromExtension, BrowserSettings browserSettings, String& errorPageUrl)
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Deployment.Application.ApplicationActivator.PerformDeploymentActivationWithRetry(Uri activationUri, Boolean isShortcut, String textualSubId, String deploymentProviderUrlFromExtension, BrowserSettings browserSettings, String& errorPageUrl)
at System.Deployment.Application.ApplicationActivator.ActivateDeploymentWorker(Object state)

dont use the single launch setup.exe..  download the full zip package run direct from ..\idfix-master\publish\Application Files\IdFix_2_3_0_0\idfx.exe

Many thanks for the advice, works well.
On Thu, 24 Jun 2021, 04:45 trevevs, @.***> wrote:

dont use the single launch setup.exe.. download the full zip package run
direct from ..\idfix-master\publish\Application Files\IdFix_2_3_0_0\idfx.exe
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/idfix/issues/41#issuecomment-867311756, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ASWL4XMVK532ZDI3WOJBF2LTUKS4JANCNFSM4UR6TPHA
.

An MSI is available for install to those that cannot run the ClickOnce application:  https://github.com/microsoft/idfix/tree/master/MSIs


Upgrade ember to v4

Closes #371
Closes #370
@sbatson5 perhaps it makes sense to merge this one before releasing your #372 ? As you can see i've upgraded to the latest v4 but i kept all the ember-try scenarios starting from v3.12.

I believe this PR should have triggered a major semver update
from https://github.com/ef4/ember-auto-import/blob/main/docs/upgrade-guide-2.0.md

addons that upgrade to ember-auto-import >= 2 will only work in apps that have ember-auto-import >= 2, so they should do their own semver major releases when they upgrade