Fix bug where function invocations are not expanded for project .bal files in File Overview

Purpose
$title
Check List

[x] Read the Contributing Guide
[ ] Required Balo version update
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #18731 into master will decrease coverage by 0.12%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master   #18731      +/-   ##
==========================================
- Coverage   15.57%   15.44%   -0.13%
==========================================
  Files          47       47
  Lines        1220     1230      +10
  Branches      184      187       +3
==========================================
  Hits          190      190
- Misses       1016     1026      +10
  Partials       14       14

Impacted Files
Coverage Δ

tool-plugins/vscode/src/overview/activator.ts
0% <0%> (ø)
:arrow_up:

tool-plugins/vscode/src/overview/renderer.ts
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5bad92...899fc6b. Read the comment docs.


MAINT: Fixed several unused imports in scipy/fft.

Reference issue
Further work on gh-11529
What does this implement/fix?
Removes six(6) imports, to reduce Pyflakes warnings.

@peterbell10  I did not remove warnings from _pocketfft.  E.g.
scipy/fft/_pocketfft/helper.py:4: '.pypocketfft.good_size' imported but unused
scipy/fft/_pocketfft/helper.py:5: redefinition of unused 'operator' from line 3
scipy/fft/_pocketfft/helper.py:6: 'sys' imported but unused
scipy/fft/_pocketfft/tests/test_basic.py:13: 'numpy.double' imported but unused
scipy/fft/_pocketfft/tests/test_basic.py:348: local variable 'out' is assigned to but never used
scipy/fft/_pocketfft/tests/test_basic.py:853: local variable 'y' is assigned to but never used
scipy/fft/_pocketfft/tests/test_real_transforms.py:4: 'platform' imported but unused

Is this code under our control so we can change it, or is it a drop-in from an external vendor?

All of the python code in _pocketfft is our code.

Added warning fixes for scipy/fft/_pocketfft/...

Thanks @pvanmulbregt & @peterbell10


[Clojure] Fix for flaky concat test failures

Fix for issue https://github.com/apache/incubator-mxnet/issues/14045
Ran new concat test 10000 times with no failures
Also ran the whole Operator Suite 1000 times with no failures

@mxnet-label-bot add [pr-awaiting-review, Clojure]


shell: add an option for minimal default configuration

The default shell configuration has heavy flash and memory requirements,
requiring project maintainers to set many configuration options to "n"
to keep flash and memory requirements within reason.
This adds a new configuration option, CONFIG_SHELL_MINIMAL, which
will disable flash and memory heavy options by default, and allow
project maintainers to select/imply only the options they want.
On a quick test from an ARM board I'm working on, enabling this option
cut flash space requirements by ~8 KB, and memory requirements by ~1 KB.
Signed-off-by: Jack Rosenthal<EMAIL_ADDRESS>

@jackrosenthal
Would you mind update documentation about this configuration option?
On top of that, it might be good to add CONFIG_SHELL_MINIMALconfig file in tests here:
https://github.com/zephyrproject-rtos/zephyr/tree/master/tests/subsys/shell/shell
and update testcase.yaml accordingly.

@jakub-uC  Sure, I updated the documentation and the testcases accordingly.
For the test cases, they generally had the pattern of setting all of the config options to n except for the options desired.  I changed them to use CONFIG_SHELL_MINIMAL=y and enable the options they required instead.  Let me know if this is acceptable.


Uses ResourceType for filtering list directories instead of workaround

Which issue does this PR close?
Closes #5451.

Test pass for me, thank you


[PUI] Part Stock Scheduling

Follow up to https://github.com/inventree/InvenTree/pull/6985
Implement the "stock scheduling" panel in PUI

Closed in https://github.com/inventree/InvenTree/pull/8163


Having issue with ncm2_complete_popup

When you try to save a file before ncm2 popup appears it appends a message to the command line.
Something like this: :w<Plug>(ncm2_complete_popup). This happens when I finish typing and then I simultaneously press escape > :w really fast. (before popup appears)
OS
MacOS - High Sierra
neovim :version output
0.3.0
Minimal vimrc for reproducing the issue
https://gist.github.com/neilgarcia/2abe03f2b6060a6d34f38d6709aa441e

Hey thanks man!


feat: expand full-border plugin compatibility

Fixes:

[x] #2
[X] #3

Now that I know they can be fixed, I will start working on a less hacky solution, particularly for the max-preview one.

This is it. I don't think I can improve it further. Both issues have been addressed. Also, it should support cases when the Parent column is hidden, e.g:
ui.Layout()
	:direction(ui.Layout.HORIZONTAL)
	:constraints({
		ui.Constraint.Percentage(0),
		ui.Constraint.Percentage(30),
		ui.Constraint.Percentage(70),
	})
	:split(area)

That is the reason why I had to keep the following line:
x == 0 and ui.Bar.NONE or ui.Bar.TOP

I couldn't found a better way to handle it. For some reason I can't understand yet, the Current column render relies on this ui.Bar.
Anyway, there may be some use cases still missing, but overall, I think the full-border has become much more reliable.
Any feedback would be greatly appreciated. I'm open to addressing any requests for changes or clarifications. Also, feel free to take it from here.

Thanks for the patch!
I'll take a look later to see if there's a simpler way to implement it.


Add functionality to "feedback" and "support"

[ ] decide what support should do
[ ] decide what feedback should do

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Maybe
redirect to tec support
some form that can be filled out and send to an moderator

We could have the button "help" and on click we open a new window, with an info text, which contains things like:
-When do I contact tec support.
-What should I do before contacting tec support(like restart etc.).
-U should provide a detailed description etc.
Maybe be could also Link our GutHub issues and make clear guide lines like:
-When shell i craete an issue...
-If it is reproducable
-If it is a client bug and not in game error
-Only after reinstalling or so
-Provide Screenshots and a clear description
-If u looked through and made sure if that issues does not exist already
And maybe force the user to read the text by enabling the buttons(to tec support and GitHub) only after like a minute

Hi, speaking from experience: that seems a bit full-on to me. You'll be lucky if anyone has the patience to submit a bug that way.
I would be careful about a form, because it implies that someone will respond and support the user, and then you need someone to man the post and reply and interpret issues.
As this is open source project, for support I would redirect the user to github, and show them those instructions to help them raise the issue in github. Keep it all in one place.
A feedback button sounds good, but again, who is going to be responsible to interpret all the feedback. Again I would make it easier on the devs and direct issues to github, and general chat/feedback to the slack group.

Sentry has a user feedback feature: https://docs.sentry.io/learn/user-feedback/
The default way is showing a html page which uses js to show the form but there should a (easy) way to implement it in java, too. When #351 is implemented, we could also get more context on reported errors using this way.

Will just remove the feedback button as nothing has been thought of


build system updates

ECL should be a standalone cmake project with several libraries.

EKF
attitude_fw
l1
tecs
validation
geo (would need to be fully moved from PX4)

When included as a subdirectory in another cmake project (like PX4) the same cmake configuration would be used. https://github.com/PX4/Firmware/issues/8191
TODO

ECL cmake project with each component generating a static and shared library
fully move geo from PX4 (https://github.com/PX4/Firmware/issues/8192)
remove PX4 mathlib usage (L1 and TECS)
basic testing for all components
update CI system to build on linux (range of gcc and clang versions), OSX, and windows (appveyor)
fix EKF python testing and post plots (https://github.com/PX4/ecl/pull/317)
setup astyle or clang-format (need to ignore EKF autogenerated portions)
code coverage

Mostly implemented.


Crash on 1.20.4

[18:09:54] [Render thread/ERROR]: Unreported exception thrown!
java.lang.NoSuchMethodError: 'void net.minecraft.class_634.method_2883(net.minecraft.class_2596)'
	at com.gxlg.librgetter.Worker.tick(Worker.java:231) ~[libr-getter-1.3.2-Warden.jar:?]
	at net.minecraft.class_636.handler$zmp000$librgetter$tick(class_636.java:1604) ~[client-intermediary.jar:?]
	at net.minecraft.class_636.method_2927(class_636.java) ~[client-intermediary.jar:?]
	at net.minecraft.class_310.method_1574(class_310.java:1962) ~[client-intermediary.jar:?]
	at net.minecraft.class_310.method_1523(class_310.java:1289) ~[client-intermediary.jar:?]
	at net.minecraft.class_310.method_1514(class_310.java:888) ~[client-intermediary.jar:?]
	at net.minecraft.client.main.Main.main(Main.java:265) ~[minecraft-1.20.4-client.jar:?]
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:470) ~[fabric-loader-0.15.3.jar:?]
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) ~[fabric-loader-0.15.3.jar:?]
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) ~[fabric-loader-0.15.3.jar:?]
	at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:87) ~[NewLaunch.jar:?]
	at org.prismlauncher.EntryPoint.listen(EntryPoint.java:130) ~[NewLaunch.jar:?]
	at org.prismlauncher.EntryPoint.main(EntryPoint.java:70) ~[NewLaunch.jar:?]

Additional notes:

Can reproduce in both singleplayer and multiplayer
Updating the build.gradle for specifically 1.20.4 works - Not sure why

I've also changed the Java from 1.8 to 17

Seems that 1.20.4 is not compatible with the Warden release. This will require a new version. I will work on it ASAP.
If you have any suggestions for a cool name for the version based on what is "new" in 1.20.4, let me know!

Can I suggest "Waxed Lightly Weathered Cut Copper Stairs" (or name it after the new Sniffer)

Fixed in v.1.3.3


e2e: fix balloons test CPU frequencies

Use kHZ instead of MHz in minFreq and maxFreq as required in the real interface. Using wrong units in the tests did not fail because configuring CPU frequencies with any values does not really work in our test VMs. However, using wrong units in tests is misleading for anyone who tries to use similar configuration on bare metal.

@askervin This is a bit late and only tangentially related, but having the unit be allowed in those configuration frequency values would allow the user to specify them in a human-friendly syntax and reduce the possibility for mistakes. If we don't do that, then using parameter names like minFreqkHz and maxFreqkHz would make the settings' unit self-documenting/obvious.

allow the user to specify them [units] in a human-friendly syntax

Definitely something we should do.


Energy preprocessing for model training

Thank your for providing such a large dataset covering a large proportion of chemical space. I try training EGNN (EquiformerV2) using Pubchem subset of SPICE (SPICE_PubChem_Set_1_Single_Points_Dataset_v1.3). However, I find the formation energies cover a wide range (as shown below, I convert the unit from hartree to kcal/mol), and the model has problem converging in training. I wonder how should I preprocess the energies for stable training.  Currently, I standarize the conformation energies.

The subsets are not intended to be used individually.  To train a general purpose model that can simulate arbitrary molecules over a large area of chemical space, you need a lot of data.  If you only use a tiny fraction of the available data, it's unlikely to learn successfully.
A lot of what you're seeing in that graph is the variation in size.  Some molecules have a lot more atoms than others, and those ones have larger formation energies.

Thank you for your reply. I still have two questions:

"The subsets are not intended to be used individually." for subsets you mean SPICE_PubChem_Set_1_Single_Points_Dataset_v1.3 or the whole PubChem subset? I wonder why can't I use SPICE_PubChem_Set_1 to train and test model performance. I think I can use it as a mixture of MD17.
As shown in spice-models, we can just use formation energies as the target energy of the model.  Considering the the formation energies vary in a large scale, do your recommend standaring the formation energies for model training? If so, as there are many Subsets, should I standarize within each subset and use different prediction head for each subset, or standarize all the subsets as a whole?

The PubChem molecules were split into multiple datasets just for computational convenience.  The version of QCFractal we were using at the time would run out of memory if a dataset was too large, so it had to be split up.
The subsets (PubChem, DES370K, etc.) are intended to be complementary.  Each one was included to provide a certain type of information, with the goal that when all of them were combined, they would together have enough information to define a general potential function.
I'm not sure what you mean by standardizing the formation energies.  They are what they are.  They cover a big range, but that's because real energies of real molecules cover a big range.  A good model should be able to reproduce it.  Most models produce per-atom energies that are summed to get the total energy, so scaling with the number of atoms happens automatically.

Here standardizing means computing the mean and std of formation energies for molecules in the training set, and the model predictions $y_{pred}$ will be compared to ground truth formation energy $y_{form}$ after $y_{pred}*std + mean$. I have seen OC20 adopts standardizing for their energy prediction.

You can try, but I doubt it will be useful in this case.


The number of operation IDs (20) should match the number of operations (21). Check that all your IDs are unique.

Summary
After bump version from 2.2.0 to 2.4.0 I receive that error while compilation: The number of operation IDs (20) should match the number of operations (21). Check that all your IDs are unique.
Version
2.4.0

Thanks for the report! This would happen if there's somehow a duplicate operationId or if two queries have the same queryDocument.
A few questions to help diagnose the issue:
Do you use a custom OperationIdGenerator ?
Can you check your queries, would two of them be the same?

I do not use a custom OperationIdGenerator.

Can you check your queries, would two of them be the same?

Do you mean the same name?

Do you mean the same name?

Same query text, something like a duplicate .graphql file somewhere or something similar. The operationId is by default computed from the sha1 of the query text (query document, what is sent to the server)
https://github.com/apollographql/apollo-android/pull/2476 enforced that there's no duplicate. It's possible that this was ignored before but I don't thing having duplicate queries is desirable. Unless I'm missing a use case?
The other option would be a sha1 collision but I doubt that very much

Ok, I found two the same query in project. Thanks for quick response!

Glad to hear that, I'll try to make that error message more explicit, I think we can make it better.

Been looking a bit into this and it turns out we already have code to detect duplicates but duplicate queries with different package names could be theoretically allowed, which is why I believe is why your case wasn't caught. Maybe we can relax the format of operationOutput.json to allow duplicate queries...


User-defined type guard method can be overridden with any non-type-guard return type

TypeScript Version:  master (07966dcb124ee379a4f062c1032fec0a6c4eaf19)

Search Terms: user-defined type guard predicate method override overridden return
Code
interface A {
    isB(): this is B;
}
interface B extends A {
    isB(): "this is nonsense";
}

Expected behavior: Error on "this is nonsense".
Actual behavior: No error.
Playground Link: link
Related Issues: none found

@RyanCavanaugh I'll be happy to make a PR if you tell me the intended behavior.  A this type guard function can be overridden with any function returning a boolean, or it can only be overridden with a this type guard function for the same type (as is the rule for parameter type guards)?  The previous discussion I found is here.

I'd be curious to see the results of both, but if I had to pick one without seeing RWC results I'd say "must be boolean or the same guarded type".


Ui modification

Coverage decreased (-0.7%) to 77.085% when pulling 1893a5fd96c830d7ddfd4d1a08b82ef3a5797123 on ALim95:ui_modification into 168ca7bec82cf4519528eeff83dffa4df110facb on CS2103AUG2017-T15-B4:master.

Coverage decreased (-0.7%) to 77.065% when pulling 1893a5fd96c830d7ddfd4d1a08b82ef3a5797123 on ALim95:ui_modification into 168ca7bec82cf4519528eeff83dffa4df110facb on CS2103AUG2017-T15-B4:master.

Coverage decreased (-0.4%) to 77.327% when pulling f123b12b695f4273e582120c865c3fac50f9c8cd on ALim95:ui_modification into 168ca7bec82cf4519528eeff83dffa4df110facb on CS2103AUG2017-T15-B4:master.

Coverage decreased (-0.3%) to 77.477% when pulling a797c07916208ecf758ef597d759585d8ac773ee on ALim95:ui_modification into 168ca7bec82cf4519528eeff83dffa4df110facb on CS2103AUG2017-T15-B4:master.

Coverage decreased (-0.3%) to 77.469% when pulling 5a79f54f2d94846f92c3e70d7af9c4b06d6536d2 on ALim95:ui_modification into 168ca7bec82cf4519528eeff83dffa4df110facb on CS2103AUG2017-T15-B4:master.

Coverage decreased (-0.5%) to 77.295% when pulling 5a79f54f2d94846f92c3e70d7af9c4b06d6536d2 on ALim95:ui_modification into 168ca7bec82cf4519528eeff83dffa4df110facb on CS2103AUG2017-T15-B4:master.

Coverage decreased (-0.5%) to 77.295% when pulling f7528e31a82883edb1b53c6f86ff80f79f19178e on ALim95:ui_modification into 168ca7bec82cf4519528eeff83dffa4df110facb on CS2103AUG2017-T15-B4:master.


fixed #2029 - [closed]

In GitLab by @liyanq528 on Mar 27, 2019, 02:10
Merges issue#2029 -> dev

In GitLab by @wknet123 on Nov 13, 2019, 11:41
The test coverage for backend is %  38.85%  , check  console log

In GitLab by @wknet123 on Nov 13, 2019, 11:41
closed


Fastlane scan launches a new test session while current test session is not finished

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description

I have some test cases failing due to a new test session started during this test case execution. This makes the current test case crashing.
As you can see in the provided logs, there is a first test session launched:
[16:42:35]: ▸ 2019-10-22 16:42:35.341 xcodebuild[91170:10223499] [MT] IDETestOperationsObserverDebug: (BA6E9994-B774-43D3-A58C-DBD1AB068B48) Beginning test session ProjectExampleTests-BA6E9994-B774-43D3-A58C-DBD1AB068B48 at 2019-10-22 16:42:35.340 with Xcode 10E1001 on target <DVTiPhoneSimulator: 0x7fdf07a8f0f0> {
[16:42:35]: ▸ 		SimDevice: iPhone 5s iOS 9.0 (4353112F-6BFA-4DD4-AE7A-5E772AB438D5, iOS 9.0, Shutdown)
[16:42:35]: ▸ } (9.0 (13A344))

Then while the test cases are not all executed yet, another session is started on the same simulator, making the current test case failing:
[16:43:15]: ▸ 2019-10-22 16:43:15.243 xcodebuild[91170:10223499] [MT] IDETestOperationsObserverDebug: (7BC2DA5F-0765-4705-83F0-D2F215E7F2ED) Beginning test session ProjectExampleTests-7BC2DA5F-0765-4705-83F0-D2F215E7F2ED at 2019-10-22 16:43:15.244 with Xcode 10E1001 on target <DVTiPhoneSimulator: 0x7fdf07a8f0f0> {
[16:43:15]: ▸ 		SimDevice: iPhone 5s iOS 9.0 (4353112F-6BFA-4DD4-AE7A-5E772AB438D5, iOS 9.0, Booted)
[16:43:15]: ▸ } (9.0 (13A344))
[16:43:15]: ▸ 2019-10-22 16:43:15.247 xcodebuild[91170:10223499] [MT] IDETestOperationsObserverDebug: (7BC2DA5F-0765-4705-83F0-D2F215E7F2ED) Finished requesting crash reports. Continuing with testing.
[16:43:16]: ▸     ✗ bridges_ProjectExample_Badge_set, Test crashed

I already checked that I have only 1 simulator matching each simulator name provided in the command.
Also I set max_concurrent_simulators to 1 and disable_concurrent_testing to true but this doesn't help solving this issue.
Is this due to a missing configuration?
Thanks.
Command executed

Complete output when running fastlane, including the stack trace and command used

 [16:41:32]: ------------------------------
[16:41:32]: --- Step: default_platform ---
[16:41:32]: ------------------------------
[16:41:33]: Driving the lane 'ios unit_tests' 🚀
[16:41:33]: --------------------------------
[16:41:33]: --- Step: clear_derived_data ---
[16:41:33]: --------------------------------
[16:41:33]: Derived Data path located at: /Users/claude/Library/Developer/Xcode/DerivedData
[16:41:34]: Successfully cleared Derived Data ♻
[16:41:34]: ------------------
[16:41:34]: --- Step: scan ---
[16:41:34]: ------------------
[16:41:34]: $ xcodebuild -showBuildSettings -workspace ./ProjectExample.xcworkspace -scheme ProjectExampleTests
[16:41:36]: $ xcodebuild -showBuildSettings -workspace ./ProjectExample.xcworkspace -scheme ProjectExampleTests
+------------------------------------------------+-----------------------------------------------------------------------------------------------+
|                                                            Summary for scan 2.134.0                                                            |
+------------------------------------------------+-----------------------------------------------------------------------------------------------+
| scheme                                         | ProjectExampleTests                                                                           |
| devices                                        | ["iPhone 5s iOS 9.0", "iPhone 6s iOS 10.3", "iPhone X iOS 12.2"]                              |
| skip_build                                     | true                                                                                |
| disable_concurrent_testing                     | true                                                                                |
| prelaunch_simulator                            | true                                                                                |
| max_concurrent_simulators                      | 1                                                                                |
| workspace                                      | ./ProjectExample.xcworkspace                                                                  |
| derived_data_path                              | /Users/claude/Library/Developer/Xcode/DerivedData/ProjectExample-hkcobndhrmxnnkbkrtfhglxkvvbm |
| skip_detect_devices                            | false                                                                                |
| force_quit_simulator                           | false                                                                                |
| reset_simulator                                | false                                                                                |
| reinstall_app                                  | false                                                                                |
| clean                                          | false                                                                                |
| open_report                                    | false                                                                                |
| output_directory                               | ./fastlane/test_output                                                                        |
| output_types                                   | html,junit                                                                                |
| buildlog_path                                  | ~/Library/Logs/scan                                                                           |
| include_simulator_logs                         | false                                                                                |
| should_zip_build_products                      | false                                                                                |
| result_bundle                                  | false                                                                                |
| use_clang_report_name                          | false                                                                                |
| slack_use_webhook_configured_username_and_icon | false                                                                                |
| slack_username                                 | fastlane                                                                                |
| slack_icon_url                                 | https://s3-eu-west-1.amazonaws.com/fastlane.tools/fastlane.png                                |
| skip_slack                                     | false                                                                                |
| slack_only_on_failure                          | false                                                                                |
| xcodebuild_command                             | env NSUnbufferedIO=YES xcodebuild                                                             |
| fail_build                                     | true                                                                                |
| xcode_path                                     | /Applications/Xcode.app                                                                       |
+------------------------------------------------+-----------------------------------------------------------------------------------------------+
[16:41:38]: $ set -o pipefail && env NSUnbufferedIO=YES xcodebuild -workspace ./ProjectExample.xcworkspace -scheme ProjectExampleTests -destination 'platform=iOS Simulator,id=4353112F-6BFA-4DD4-AE7A-5E772AB438D5' -destination 'platform=iOS Simulator,id=B2AD710C-3F80-4A5E-B02B-A72DE36B787A' -destination 'platform=iOS Simulator,id=CBD79494-ADD4-404D-AA94-87BF758EA8D3' -derivedDataPath '/Users/claude/Library/Developer/Xcode/DerivedData/ProjectExample-hkcobndhrmxnnkbkrtfhglxkvvbm' -maximum-concurrent-test-simulator-destinations 1 -disable-concurrent-testing test | tee '/Users/claude/Library/Logs/scan/ProjectExampleTests-ProjectExampleTests.log' | xcpretty  --report html --output '/Users/claude/Dev/ProjectExample/fastlane/test_output/report.html' --report junit --output '/Users/claude/Dev/ProjectExample/fastlane/test_output/report.junit' --report junit --output '/var/folders/m7/y78wyb0n2rqf74b98_rc1rbr0000gn/T/junit_report20191022-91121-r6mvwk'
...
[16:42:35]: Running Tests: ▸ Touching ProjectExampleTests.xctest
[16:42:35]: ▸ Signing /Users/claude/Library/Developer/Xcode/DerivedData/ProjectExample-hkcobndhrmxnnkbkrtfhglxkvvbm/Build/Products/Debug-iphonesimulator/ProjectExampleTests.xctest
[16:42:35]: ▸ 2019-10-22 16:42:35.340 xcodebuild[91170:10223615]  IDETestOperationsObserverDebug: Writing diagnostic log for test session to:
[16:42:35]: ▸ /Users/claude/Library/Developer/Xcode/DerivedData/ProjectExample-hkcobndhrmxnnkbkrtfhglxkvvbm/Logs/Test/Test-ProjectExampleTests-2019.10.22_16-41-41-+0200.xcresult/1_Test/Diagnostics/ProjectExampleTests-27FC4C1D-77D3-45BC-BC16-B20769DB5E27/ProjectExampleTests-CEB88879-DFF1-4E64-839E-D4625B7BA4C0/Session-ProjectExampleTests-2019-10-22_164235-Msfqlj.log
[16:42:35]: ▸ 2019-10-22 16:42:35.341 xcodebuild[91170:10223499] [MT] IDETestOperationsObserverDebug: (BA6E9994-B774-43D3-A58C-DBD1AB068B48) Beginning test session ProjectExampleTests-BA6E9994-B774-43D3-A58C-DBD1AB068B48 at 2019-10-22 16:42:35.340 with Xcode 10E1001 on target <DVTiPhoneSimulator: 0x7fdf07a8f0f0> {
[16:42:35]: ▸ 		SimDevice: iPhone 5s iOS 9.0 (4353112F-6BFA-4DD4-AE7A-5E772AB438D5, iOS 9.0, Shutdown)
[16:42:35]: ▸ } (9.0 (13A344))
[16:42:45]: ▸ 2019-10-22 16:42:45.014 xcodebuild[91170:10223499] [MT] IDETestOperationsObserverDebug: (BA6E9994-B774-43D3-A58C-DBD1AB068B48) Finished requesting crash reports. Continuing with testing.
[16:42:47]: ▸ All tests
[16:42:47]: ▸ Test Suite ProjectExampleTests.xctest started
...
[16:43:15]: ▸ 2019-10-22 16:43:15.243 xcodebuild[91170:10226022]  IDETestOperationsObserverDebug: Writing diagnostic log for test session to:
[16:43:15]: ▸ /Users/claude/Library/Developer/Xcode/DerivedData/ProjectExample-hkcobndhrmxnnkbkrtfhglxkvvbm/Logs/Test/Test-ProjectExampleTests-2019.10.22_16-41-41-+0200.xcresult/1_Test/Diagnostics/ProjectExampleTests-27FC4C1D-77D3-45BC-BC16-B20769DB5E27/ProjectExampleTests-CEB88879-DFF1-4E64-839E-D4625B7BA4C0/Session-ProjectExampleTests-2019-10-22_164315-GhePTp.log
[16:43:15]: ▸ 2019-10-22 16:43:15.243 xcodebuild[91170:10223499] [MT] IDETestOperationsObserverDebug: (7BC2DA5F-0765-4705-83F0-D2F215E7F2ED) Beginning test session ProjectExampleTests-7BC2DA5F-0765-4705-83F0-D2F215E7F2ED at 2019-10-22 16:43:15.244 with Xcode 10E1001 on target <DVTiPhoneSimulator: 0x7fdf07a8f0f0> {
[16:43:15]: ▸ 		SimDevice: iPhone 5s iOS 9.0 (4353112F-6BFA-4DD4-AE7A-5E772AB438D5, iOS 9.0, Booted)
[16:43:15]: ▸ } (9.0 (13A344))
[16:43:15]: ▸ 2019-10-22 16:43:15.247 xcodebuild[91170:10223499] [MT] IDETestOperationsObserverDebug: (7BC2DA5F-0765-4705-83F0-D2F215E7F2ED) Finished requesting crash reports. Continuing with testing.
[16:43:16]: ▸     ✗ bridges_ProjectExample_Badge_set, Test crashed
[16:43:16]: ▸ Selected tests
[16:43:16]: ▸ Test Suite ProjectExampleTests.xctest started

Environment

🚫 fastlane environment 🚫
Stack

Key
Value

OS
10.14.4

Ruby
2.6.3

Bundler?
true

Git
git version 2.20.1 (Apple Git-117)

Installation Source
~/.rvm/gems/ruby-2.6.3/bin/fastlane

Host
Mac OS X 10.14.4 (18E226)

Ruby Lib Dir
~/.rvm/rubies/ruby-2.6.3/lib

OpenSSL Version
OpenSSL 1.1.1d  10 Sep 2019

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
10.2.1

System Locale

Error

No Locale with UTF8 found 🚫

fastlane files:
`./fastlane/Fastfile`
# This file contains the fastlane.tools configuration
# You can find the documentation at https://docs.fastlane.tools
#
# For a list of all available actions, check out
#
#     https://docs.fastlane.tools/actions
#

# Uncomment the line if you want fastlane to automatically update itself
# update_fastlane

default_platform(:ios)

platform :ios do

  desc "build and launch unit tests"
  lane :unit_tests do
    run_unit_tests
  end

  def run_unit_tests
    clear_derived_data
    run_tests(scheme: "ProjectExampleTests",
              devices: ["iPhone 5s iOS 9.0", "iPhone 6s iOS 10.3", "iPhone X iOS 12.2"],
              skip_build: true,
              disable_concurrent_testing: true,
              prelaunch_simulator: true,
              max_concurrent_simulators: 1,
              slack_url: "https://hooks.slack.com/services/xxx")
  end

end

No Appfile found
fastlane gems

Gem
Version
Update-Status

fastlane
2.134.0
✅ Up-To-Date

Loaded fastlane plugins:

Plugin
Version
Update-Status

fastlane-plugin-versioning
0.3.4
✅ Up-To-Date

fastlane-plugin-badge
1.3.0
✅ Up-To-Date

fastlane-plugin-aws_s3
1.6.1
✅ Up-To-Date

Loaded gems

Gem
Version

did_you_mean
1.3.0

executable-hooks
1.6.0

bundler-unload
1.0.2

rubygems-bundler
1.4.5

bundler
1.17.3

etc
1.0.1

forwardable
1.2.0

CFPropertyList
3.0.1

concurrent-ruby
1.1.5

i18n
0.9.5

minitest
5.12.2

thread_safe
0.3.6

tzinfo
1.2.5

activesupport
<IP_ADDRESS>

public_suffix
2.0.5

addressable
2.7.0

httpclient
2.8.3

json
2.2.0

algoliasearch
1.27.1

rubyzip
1.3.0

apktools
0.7.3

atomos
0.1.3

aws-eventstream
1.0.3

aws-sigv4
1.1.0

jmespath
1.4.0

aws-sdk-core
2.11.374

aws-sdk-resources
2.11.374

aws-sdk
2.11.374

babosa
1.0.3

curb
0.9.10

fastimage
2.1.7

colored
1.2

highline
1.7.10

commander-fastlane
4.4.6

dotenv
2.7.5

emoji_regex
1.0.1

excon
0.67.0

multipart-post
2.0.0

faraday
0.17.0

unf_ext
<IP_ADDRESS>

unf
0.1.4

domain_name
0.5.20190701

http-cookie
1.0.3

faraday-cookie_jar
0.0.6

faraday_middleware
0.13.1

gh_inspector
1.1.3

jwt
2.1.0

memoist
0.16.0

multi_json
1.14.1

os
1.0.1

signet
0.12.0

googleauth
0.6.7

mime-types-data
3.2019.1009

mime-types
3.3

declarative
0.0.10

declarative-option
0.1.0

uber
0.1.0

representable
3.0.4

retriable
3.1.2

google-api-client
0.23.9

digest-crc
0.4.1

google-cloud-env
1.2.1

google-cloud-core
1.3.2

google-cloud-storage
1.16.0

mini_magick
4.9.5

multi_xml
0.6.0

plist
3.5.0

security
0.1.3

naturally
2.2.0

simctl
1.6.6

slack-notifier
2.3.2

terminal-notifier
2.0.0

unicode-display_width
1.6.0

terminal-table
1.8.0

tty-screen
0.7.0

tty-cursor
0.7.0

tty-spinner
0.9.1

word_wrap
1.0.0

claide
1.0.3

colored2
3.1.2

nanaimo
0.2.6

xcodeproj
1.13.0

rouge
2.0.7

xcpretty
0.3.0

xcpretty-travis-formatter
1.0.0

badge
0.11.0

fuzzy_match
2.0.4

nap
1.1.0

cocoapods-core
1.8.4

cocoapods-deintegrate
1.0.4

cocoapods-downloader
1.2.2

cocoapods-plugins
1.0.0

cocoapods-search
1.0.0

cocoapods-stats
1.1.0

netrc
0.11.0

cocoapods-trunk
1.4.1

cocoapods-try
1.1.0

escape
0.0.4

fourflusher
2.3.1

molinillo
0.6.6

ruby-macho
1.4.0

cocoapods
1.8.4

fastlane-plugin-aws_s3
1.6.1

fastlane-plugin-badge
1.3.0

fastlane-plugin-versioning
0.3.4

generated on: 2019-10-22

Does anyone has a suggestion or workaround ?

Have you had any luck with this @cjosepha?

@cjosepha I found that the only way to absolutely disable concurrent testing and make fastlane tests work is to disable in to build schemas.
disable_concurrent_testing and max_concurrent_simulators options does not work as we all expect

And one more notice:
If you are running UI tests by any CI to make tests more stable you should have active user UI session of user and launched Simulator app in it. Just log in, launch app and press control+command+Q to Lock Screen


Use named exports in HelmetConstants

You're using named exports but only exporting a default object, this is not valid ES6 module usage. It only works because currently babel sets the default export as module.exports = default for compatibility with CommonJS. This behavior is deprecated, precisely to avoid this kind of scenario from happening.
Helmet.jsx
import {TAG_NAMES, TAG_PROPERTIES} from "./HelmetConstants.js";

HelmetConstants.js
export default {TAG_NAMES, TAG_PROPERTIES};

This PR updates HelmetConstants.js so it has two named exports.

Thanks for the PR! We don't have an individual CLA online yet, so in the meantime can you send me an email at<EMAIL_ADDRESS>and we'll send you a CLA to sign, so that we can land this and any future PRs.


feat: nested pool display

fixes #99
PoolDetail:

indent tokens of nested pool(s)
show tokens of nested pool(s) in weight chart (instead of nested bpt(s) )
show legend below weight chart
add nested pools risk link (@uiuxxx this needs copy on .../risks#nested-pools)
update pool token pills (also for PoolList)

PoolList:

no design so no work needed?

Nested token amounts and weights should have a lighter font. See design, it's quite subtle.

updated with values from design

Instead of the BPT token we should be showing the underlying token icons here I think. Same in the pool list.

added support for boosted to token pills
note: api still needs to expose underlying tokens in displayTokens

converted to draft again because of api updates not yet available in prod

can be reviewed, api needs to deploy before merge

All checks are failing here, can you fix?

api is synced and merge conflicts are solved, all green now

empty hook string https://mono-test-v3-git-feat-nested-pool-display-balancer.vercel.app/pools/sepolia/v3/0x711fd80b36723bce3b42ad6622903e1e39d911dd

fixed!

hm, I know it's not about this pr, but seems hook icon lost from pool page header? may be some problems when we cherry picked commits from previous pr? also icon seems cut
btw I checked and hook is null here

yeah i saw the icon was cut off and looked briefly into it but couldn't find the issue yet
as it is a hook in a nested pool (which probs won't be launched in prod yet) I left it for now
same goes for the hook badge in the pool header, I didn't add nested pool hook support there yet (but left a TODO comment for when we do need it)


Fixed annoying warnings from cvat-canvas

Motivation and context
Related https://github.com/webpack/webpack/issues/7378
How has this been tested?
Manual testing
Checklist

[x] I submit my changes into the develop branch
[ ] I have added description of my changes into CHANGELOG file
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] I have linked related issues (read github docs)
[ ] I have increased versions of npm packages if it is necessary (cvat-canvas,
cvat-core, cvat-data and cvat-ui)

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[x] I have updated the license header for each file (see an example below)

# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

Coverage increased (+0.03%) to 62.749% when pulling 0d15d6ce7ca68f74149d43d8e7c951608fa20a38 on bs/fixed_warning into 33b9f8bc55eaa5ad876b727c3c91dd00732cb8e2 on develop.


Not compatible with latest version of Teensyduino

Hi! Im trying to make my own fightstick with the teensy lc but when I just replace the files there the sketches wont compile and I dont understand the code enough to get it to work on my own.
Adding a custom usb types seems really complicated

@henkv
I just installed a fresh copy of Arduino 1.6.11 and Teensyduino 1.30
These is the latest combination I can have of these two software and it compiles fine.  Copy paste some error messages for me.
The most common overlooked thing is selecting teensylc as the board.

User never replied.  Considering this issue resolved


Find HIP libraries through generated config file

As suggested by @haampie , custom CMake modules are replaced with config files provided by ROCm. In the past, they were not compatible with other compilers such as GCC, but this is no longer the case, so this is a cleaner solution.

Looks like the HIP config files in our CI are broken. Will have check if that's a general issue with ROCm 4.0.

Looks like the HIP config files in our CI are broken. Will have check if that's a general issue with ROCm 4.0.

This might be the first CI run with ROCm 4.0, so it could be unrelated tot he PR...

This might be the first CI run with ROCm 4.0, so it could be unrelated tot he PR...

I've tested it with a fresh install from their Ubuntu repository and it worked fine. So it seems to be related to how spack installs ROCm.
But I also think the way they determine the path for the linker, is not good practice. They look for the header file stddef.h here and without checking whether that file actually exists, use that variable with an appended relative path for locating libraries.

I've tested it with a fresh install from their Ubuntu repository and it worked fine. So it seems to be related to how spack installs ROCm.
But I also think the way they determine the path for the linker, is not good practice. They look for the header file stddef.h here and without checking whether that file actually exists, use that variable with an appended relative path for locating libraries.

Yeah, this is the questionable cmake practices I was talking about...
The whole branch here is questionable: https://github.com/ROCm-Developer-Tools/HIP/blob/main/hip-config.cmake.in#L67-L90. ${ROCM_PATH}/llvm is definitely not an existing path to llvm-amdgpu when installed with spack.
In the end they do a lot of work to add these targets:
  set_property(TARGET hip::device APPEND PROPERTY
    INTERFACE_INCLUDE_DIRECTORIES "${HIP_CLANG_INCLUDE_PATH}/.."
  )

  set_property(TARGET hip::device APPEND PROPERTY
    INTERFACE_SYSTEM_INCLUDE_DIRECTORIES "${HIP_CLANG_INCLUDE_PATH}/.."
  )

  # Add support for __fp16 and _Float16, explicitly link with compiler-rt
  set_property(TARGET hip::host APPEND PROPERTY
    INTERFACE_LINK_LIBRARIES -L${HIP_CLANG_INCLUDE_PATH}/../lib/linux -lclang_rt.builtins-x86_64
  )
  set_property(TARGET hip::device APPEND PROPERTY
    INTERFACE_LINK_LIBRARIES -L${HIP_CLANG_INCLUDE_PATH}/../lib/linux -lclang_rt.builtins-x86_64
  )

I'm pretty sure it's possible to generate a cmake config file which defines the prefix of llvm / clang as an absolute path, so that you don't have to seach for it during find_package(hip). I'll take a look tomorrow

Yeah, this is the questionable cmake practices I was talking about...
The whole branch here is questionable: https://github.com/ROCm-Developer-Tools/HIP/blob/main/hip-config.cmake.in#L67-L90. ${ROCM_PATH}/llvm is definitely not an existing path to llvm-amdgpu when installed with spack.
In the end they do a lot of work to add these targets:
  set_property(TARGET hip::device APPEND PROPERTY
    INTERFACE_INCLUDE_DIRECTORIES "${HIP_CLANG_INCLUDE_PATH}/.."
  )

  set_property(TARGET hip::device APPEND PROPERTY
    INTERFACE_SYSTEM_INCLUDE_DIRECTORIES "${HIP_CLANG_INCLUDE_PATH}/.."
  )

  # Add support for __fp16 and _Float16, explicitly link with compiler-rt
  set_property(TARGET hip::host APPEND PROPERTY
    INTERFACE_LINK_LIBRARIES -L${HIP_CLANG_INCLUDE_PATH}/../lib/linux -lclang_rt.builtins-x86_64
  )
  set_property(TARGET hip::device APPEND PROPERTY
    INTERFACE_LINK_LIBRARIES -L${HIP_CLANG_INCLUDE_PATH}/../lib/linux -lclang_rt.builtins-x86_64
  )

I'm pretty sure it's possible to generate a cmake config file which defines the prefix of llvm / clang as an absolute path, so that you don't have to seach for it during find_package(hip). I'll take a look tomorrow

I've narrowed the issue down to the following:
/usr/bin/g++ \
-march=x86-64 \
-mtune=generic \
...
-o libsirius.so \
... many object files and shared libs ...
/opt/spack/opt/spack/linux-ubuntu20.04-x86_64/gcc-9.3.0/hip-4.0.0-yti4dvpkjsoqc3ce6yetorcmymhvfzlh/lib/libamdhip64.so.4.0.21021-
...

Seems like gcc does not like the final dash - in the shared library, even though it is a file:
file /opt/spack/opt/spack/linux-ubuntu20.04-x86_64/gcc-9.3.0/hip-4.0.0-yti4dvpkjsoqc3ce6yetorcmymhvfzlh/lib/libamdhip64.so.4.0.21021-
/opt/spack/opt/spack/linux-ubuntu20.04-x86_64/gcc-9.3.0/hip-4.0.0-yti4dvpkjsoqc3ce6yetorcmymhvfzlh/lib/libamdhip64.so.4.0.21021-: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, BuildID[sha1]=ad24bca9e306e8e10048ff3aa7b16f0867cdddac, stripped

Linking works fine when I use the symlink libamdhip64.so. I'll check what the suffix is supposed to be.

I've narrowed the issue down to the following:
/usr/bin/g++ \
-march=x86-64 \
-mtune=generic \
...
-o libsirius.so \
... many object files and shared libs ...
/opt/spack/opt/spack/linux-ubuntu20.04-x86_64/gcc-9.3.0/hip-4.0.0-yti4dvpkjsoqc3ce6yetorcmymhvfzlh/lib/libamdhip64.so.4.0.21021-
...

Seems like gcc does not like the final dash - in the shared library, even though it is a file:
file /opt/spack/opt/spack/linux-ubuntu20.04-x86_64/gcc-9.3.0/hip-4.0.0-yti4dvpkjsoqc3ce6yetorcmymhvfzlh/lib/libamdhip64.so.4.0.21021-
/opt/spack/opt/spack/linux-ubuntu20.04-x86_64/gcc-9.3.0/hip-4.0.0-yti4dvpkjsoqc3ce6yetorcmymhvfzlh/lib/libamdhip64.so.4.0.21021-: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, BuildID[sha1]=ad24bca9e306e8e10048ff3aa7b16f0867cdddac, stripped

Linking works fine when I use the symlink libamdhip64.so. I'll check what the suffix is supposed to be.

@AdhocMan, the current situation is not great, but it works after specifying HIP_CXX_COMPILER. Hopefully this is just temporary as someone in the hip-team suggested they'd drop linking to clang_rt.builtins-x86_64 for hip::host.
And the other compilation error is gone as a result of https://github.com/spack/spack/pull/20780.

@AdhocMan, the current situation is not great, but it works after specifying HIP_CXX_COMPILER. Hopefully this is just temporary as someone in the hip-team suggested they'd drop linking to clang_rt.builtins-x86_64 for hip::host.
And the other compilation error is gone as a result of https://github.com/spack/spack/pull/20780.


Fails to restore build on ubuntu-latest (22.04.1 LTS)

It looks like libzip5 isn't available for 22.04.1 as it was published for 20.x.x to fix/workaround something by pinning the libzip version installed by libzip5 to an older version than libzip4: https://github.com/actions/runner-images/issues/1084#issue-642250128
Reading package lists...
Building dependency tree...
Reading state information...
E: Unable to locate package libzip5
Error: The process '/home/runner/work/_actions/pmmp/setup-php-action/7e0f5f0a95e9d45d1d5fab0e1ee7555fa3b04339/install-dependencies.sh' failed with exit code 100

I'll just stick to using ubuntu 20.x for now but this should be addressed so the action can be more widely used.

22.04 is generally unsupported right now. There are compatibility issues with the system version of OpenSSL as well.

Fixed by using prebuilts from pmmp/PHP-Binaries directly (ea71138ee1f044a5e037253cca8bf3d3a5ccb5e2), at the expense of not being able to specify a patch version (but I don't think anyone really cared about that anyway).


Update external data location support for Azure

This is an attempt to add external Azure storage to a DL for DW etc. per @cmperro 's community article

@wmudge let's connect on the best way to test this, as it looks complex

Are we separating this (purposefully) from the Idbroker changes that would need to be made in "platform"? Because this, on it's own, doesn't "do" anything. It just creates another storage account and adds the perms to the MSI.
Actually, when does the "data" layer run?


Add some unit tests to the project to improve coverage

Added some unit tests which can be run locally prior to Travis CI being set up.
Closes #38

Thanks for your contribution, unfortunately I figured that this should be done after #37 is completed. You could work on that if you want. To avoid doing work that is invalid always be sure to

Check the repo's contributing instructions
Make sure the issue is clear (discuss possible doubts you have) and assigned to you
before submitting a PR

As mentioned in my comment, it is normal for a project to have unit tests before being set up on a CI platform. These tests will run locally on the developer's machine and ensure the quality of the code. I am unsure why you have added the restriction of this happening after Travis CI being set up

The problem is not the CI not being set up, but the code refactoring. If I include this changes now, they would need to be done again after the code is refactored

Ok sure, of course it is your choice but again I would say it's common practice to write tests and then rewrite them as your code base changes, so would encourage to get some in there as soon as poss to get some confidence on code quality

Yeah I agree with you, otherwise we would never write any tests because code is always changing. I'll look this up later today


Feed view: Give visited links a different colour

Alternatively (maybe even better): Leave out the explicit colour definition .item a { color: #0060df; } for links so they take the default colour of the browser.

I agree, there doesn't seem to be a downside to using the default link color.

@evilpie happy to use the default link color too


[build] XCode 10

As of XCode 10 it no longer builds 32-bit applications.
https://developer.apple.com/documentation/xcode_release_notes/xcode_10_release_notes#3035631

The macOS 10.14 SDK no longer contains support for compiling 32-bit applications. If developers need to compile for i386, Xcode 9.4 or earlier is required. (39858111)

After creating the raylib binary compiled with the command make PLATFORM=PLATFORM_DESKTOP as per the instructions on https://github.com/raysan5/raylib/wiki/Working-on-macOS I get the following error when building my game (that uses the raylib binary) in XCode 10:
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Full log attached:
log.txt
Edit: I think the issue is not that it the library is built only for 32-bit (the makefile seems to build a "fat binary" that supports both?) but perhaps the issue is that the mac 10.14 SDK that is part of XCode 10 has a different API for the x86_64 architecture?

I could just be missing how to build the raylib library for x86_64, is there a flag I can pass to do that on mac?

The _CF Prefix hints that CoreFoundation.framework is missing. You need -framework IOKit -framework CoreFoundation -framework CoreVideo. There should be some list where you can add it in the XCode project settings.

Thanks for the hint, I managed to get it to build now by adding more dependencies, this is the full list


[SPARK-47818][CONNECT][FOLLOW-UP] Introduce plan cache in SparkConnectPlanner to improve performance of Analyze requests

What changes were proposed in this pull request?
In this previous PR, we introduced two new confs for the introduced plan cache - a static conf spark.connect.session.planCache.maxSize and a dynamic conf spark.connect.session.planCache.enabled. The plan cache is enabled by default with size 5. In this PR, we are marking them as internal because we don't expect users to deal with it.
Why are the changes needed?
This two confs are not expected to be used under normal circumstances, and we don't need to document them on the Spark Configuration reference page.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.
Was this patch authored or co-authored using generative AI tooling?
No.

cc @hvanhovell


Feature/core #109 fishnet

Codecov Report

Merging #110 into develop will decrease coverage by 0.40%.
The diff coverage is 96.18%.

@@             Coverage Diff             @@
##           develop     #110      +/-   ##
===========================================
- Coverage    98.89%   98.49%   -0.41%
===========================================
  Files           41       43       +2
  Lines         1265     1458     +193
===========================================
+ Hits          1251     1436     +185
- Misses          14       22       +8

Impacted Files
Coverage Δ

.../nn/models/classification/efficientnet/__init__.py
98.03% <ø> (ø)

...ses/nn/models/classification/mobilenet/__init__.py
98.82% <ø> (ø)

...s/nn/models/classification/wide_resnet/__init__.py
100.00% <ø> (ø)

test/test_ResNet.py
100.00% <ø> (ø)

...asses/nn/models/classification/fishnet/__init__.py
94.85% <94.85%> (ø)

glasses/nn/blocks/__init__.py
100.00% <100.00%> (ø)

glasses/nn/models/classification/__init__.py
100.00% <100.00%> (ø)

...sses/nn/models/classification/densenet/__init__.py
100.00% <100.00%> (ø)

...lasses/nn/models/classification/resnet/__init__.py
100.00% <100.00%> (ø)

glasses/nn/models/classification/senet/__init__.py
100.00% <100.00%> (ø)

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9887c8...d77c339. Read the comment docs.


Hide dashboard sidenav item

@nwmac There are additional changes required to side-nav.component.html to support the hiding of a SideNavItem.

@irfanhabib Thanks - looks like I missed a file.. I'll sort that out


fix: initial grid does not match initial grid in tests file

The supplied tests always fail since the supplied starting grid does not match that in the test file. This change makes them the same.

Ignore me.


Opinions regarding a category wise listing of posts?

I've implemented the same on my website, just wanted to check if there's enough traction to get it merged upstream.

Yes that would be very useful for me.


CRDT ?

Hey,
I'm a bit confused between orbitjs and orbitdb beeing very similar (though I'm coming from ember and was going that way). I have two questions, which I hope can be answered here:

What exactly is the difference between orbitjs and orbitdb?
Since I couldn't find anything regarding this: does orbitjs support CRDT (out of the box)? Or is it still up to me to manage conflicts?

Thanks

My question would be then, what are common strategies for certain merge conflicts and how to solve them? I would assume there is some experience already gained in the field of orbitjs?

There's a great recent discussion of related topics:
https://github.com/orbitjs/orbit/issues/790

And here is an external blog post which demonstrates undo history:
https://medium.com/@mudflye/undo-and-redo-with-orbit-js-ember-example-8df226b6ea52


CLOUDSTACK-9049: fix Centos7 with Tomcat7 packaging and python libs

CLOUDSTACK-9049: Fix Centos7 with Tomcat7 packaging and python libs

I haven't tested these changes yet, hopefully will have time tomorrow to do it.

Thanks @davidamorimfaria will give it a go.

Ping @davidamorimfaria @remibergsma
How can I help testing it? Steps...???
Cheers,
Wilder

I will build RPMs and try to install the management server form the RPM in a machine with tomcat7 installed. is that how it is supposed to work?

@wilderrodrigues that would be a way, a problem that was identified is that tomcat as dependency will not be installed. I don't think that is arddessed in this.

This PR needs fixes, I cannot even build the RPMs.
I did:

git fetch origin pull/1052/head:pr/1052
git checkout pr/1052
cd packaging
./packaging -d centos7

Result below:
7-nonssl.conf /data/git/cs1/cloudstack/dist/rpmbuild/BUILDROOT/cloudstack-4.6.0-SNAPSHOT.el7.centos.x86_64/etc/cloudstack/management/tomcat7-nonssl.conf
mv: cannot stat '/data/git/cs1/cloudstack/dist/rpmbuild/BUILDROOT/cloudstack-4.6.0-SNAPSHOT.el7.centos.x86_64/usr/share/cloudstack-management/webapps/client/WEB-INF/classes/tomcat7-nonssl.conf': No such file or directory
error: Bad exit status from /var/tmp/rpm-tmp.YrDgHw (%install)

RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.YrDgHw (%install)
RPM Build Failed
[root@cs1 packaging]#

Cheers,
Wilder

@wilderrodrigues @davidamorimfaria RPM build now works properly:
+ exit 0
RPM Build Done

@davidamorimfaria Here's another glitch you may want to look at:
[root@cs2 x86_64]# cloudstack-setup-management
  File "/usr/bin/cloudstack-setup-management", line 36
    if options.tomcat7
                     ^
SyntaxError: invalid syntax

You mis a : after if options.tomcat7.
I edit it locally, then run: cloudstack-setup-management --tomcat7 (suppose I need that option when I look at the code?)
Now I get:
Starting to configure CloudStack Management Server:
Configure Firewall ...        [OK]
Configure CloudStack Management Server ...Configure CloudStack Management Server failed, Please check the /var/log/cloudstack/setupManagement.log for detail, due to:globalEnv instance has no attribute 'srvConf'
Try to restore your system:
Restore Firewall ...          [OK]

@davidamorimfaria Ooops... something went wrong! You got like 10 commits of other people pushed and created conflicts. I'd suggest squashing your own commits and making sure it's the only commit in the pr.

The mess has been sorted and the code is ready for testing.

Just tested and managed to deploy the management server without issues.

@davidamorimfaria Thanks, will retest soon.

validated the build and install with centos7. validation on centos6 started

added pr for docs-install https://github.com/apache/cloudstack-docs-install/pull/24

LGTM, Tested on CentOS7 with Tomcat 7.
The package builds fine:
+ exit 0
RPM Build Done

Install also works:
Installed:
  cloudstack-common.x86_64 0:4.6.0-SNAPSHOT.el7.centos
  cloudstack-management.x86_64 0:4.6.0-SNAPSHOT.el7.centos

Complete!

Setup, now requires --tomcat7 as parameter:
[root@cs2 x86_64]# cloudstack-setup-management --tomcat7
Starting to configure CloudStack Management Server:
Configure Firewall ...        [OK]
Configure CloudStack Management Server ...[OK]
CloudStack Management Server setup is Done!

Files in /etc/:
[root@cs2 management]# pwd
/etc/cloudstack/management
[root@cs2 management]# ls -la
total 136
drwxr-xr-x. 3 root root   4096 Nov 10 09:10 .
drwxr-xr-x. 3 root root   4096 Nov  9 17:06 ..
drwxrwx---. 3 root cloud  4096 Nov 10 09:06 Catalina
-rw-r--r--. 1 root root   8945 Nov 10 08:56 catalina.policy
-rw-r--r--. 1 root root   3794 Nov 10 08:56 catalina.properties
-rw-r--r--. 1 root root   1653 Nov 10 08:56 classpath.conf
-rw-r--r--. 1 root root   1357 Nov 10 08:56 commons-logging.properties
-rw-r-----. 1 root cloud  3125 Nov 10 09:08 db.properties
-rw-r-----. 1 root cloud  3125 Nov  9 21:27 db.properties.rpmsave
-rw-r--r--. 1 root root    972 Nov 10 08:56 environment.properties
-rw-r--r--. 1 root root    927 Nov 10 08:56 java.security.ciphers
-rw-r--r--. 1 root root      8 Nov 10 09:08 key
-rw-r--r--. 1 root root   7020 Nov 10 08:56 log4j-cloud.xml
-rw-r--r--. 1 root root   6722 Nov 10 08:56 server7-nonssl.xml
-rw-r--r--. 1 root root   7251 Nov 10 08:56 server7-ssl.xml
lrwxrwxrwx. 1 root root     45 Nov 10 09:10 server.xml -> /etc/cloudstack/management/server7-nonssl.xml
-rw-r--r--. 1 root root   1383 Nov 10 08:56 tomcat-users.xml
-rw-r--r--. 1 root root  50475 Nov 10 08:56 web.xml

Enabling and starting:
[root@cs2 management]# systemctl enable cloudstack-management
[root@cs2 management]# systemctl start cloudstack-management
[root@cs2 management]# systemctl status cloudstack-management
cloudstack-management.service - CloudStack Management Server
   Loaded: loaded (/usr/lib/systemd/system/cloudstack-management.service; enabled)
   Active: active (running) since Tue 2015-11-10 09:11:41 GMT; 5s ago
 Main PID: 12381 (java)
   CGroup: /system.slice/cloudstack-management.service
           └─12381 java -Djava.awt.headless=true -Dcom.sun.management.jmxremote=false -Xmx2g -XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=/var/log/cloudstack/management/ -XX:PermSize=512M -XX:MaxPermSize=800m -cla...

Deployed data center:

Currently running some Marvin tests and that looks good. Will post results later.

Ping @PaulAngus to have a look.

@davidamorimfaria Please squash the commits, thanks.

squashed

LGTM on centos 6:
[root@cs3 x86_64]# cloudstack-setup-databases cloud:password@localhost --deploy-as=root
Mysql user name:cloud                                                           [ OK ]
Mysql user password:******                                                      [ OK ]
Mysql server ip:localhost                                                       [ OK ]
Mysql server port:3306                                                          [ OK ]
Mysql root user name:root                                                       [ OK ]
Mysql root user password:******                                                 [ OK ]
Checking Cloud database files ...                                               [ OK ]
Checking local machine hostname ...                                             [ OK ]
Checking SELinux setup ...                                                      checkSelinux failed with error continuing...                                    SELinux is set to enforcing. There are two options:
1> Set it permissive in /etc/selinux/config, then reboot the machine.
2> Type 'setenforce Permissive' in commandline, after which you can run this program again.

We strongly suggest you doing the option 1 that makes sure SELinux goes into permissive after system reboot.
[ OK ]
Detected local IP address as <IP_ADDRESS>, will use as cluster management server node IP[ OK ]
Preparing /etc/cloudstack/management/db.properties                              [ OK ]
Applying /usr/share/cloudstack-management/setup/create-database.sql             [ OK ]
Applying /usr/share/cloudstack-management/setup/create-schema.sql               [ OK ]
Applying /usr/share/cloudstack-management/setup/create-database-premium.sql     [ OK ]
Applying /usr/share/cloudstack-management/setup/create-schema-premium.sql       [ OK ]
Applying /usr/share/cloudstack-management/setup/server-setup.sql                [ OK ]
Applying /usr/share/cloudstack-management/setup/templates.sql                   [ OK ]
Processing encryption ...                                                       [ OK ]
Finalizing setup ...                                                            [ OK ]

CloudStack has successfully initialized database, you can check your database configuration in /etc/cloudstack/management/db.properties

[root@cs3 x86_64]# cloudstack-setup-management
Starting to configure CloudStack Management Server:
Configure Firewall ...        [OK]
Configure CloudStack Management Server ...[OK]
CloudStack Management Server setup is Done!
[root@cs3 x86_64]#

Verified RPM build after squash to be sure:
+ exit 0
RPM Build Done

Executed a few tests just to see if it actually does something:
Test advanced zone virtual router ... === TestName: test_advZoneVirtualRouter | Status : SUCCESS ===
ok
Test Deploy Virtual Machine ... === TestName: test_deploy_vm | Status : SUCCESS ===
ok

It is still running the tests against the RPM deployed CentOS 7 box.

Verified with @dahn that cloudstack-management started on CentOS 6 as well and that he was able to use the UI.


hostfxr.dll was found, but loading it from [hostfxr.dll path] failed

Trying to run the test cases in the source code (EFCore.Tests), but this error always occurs:
[7/8/2019 9:33:42 AM Error] Testhost process exited with error: Failed to load the dll from [C:\Users\Daniel Li\source\repos\EntityFrameworkCore.dotnet\host\fxr\3.0.0-preview8-27905-07\hostfxr.dll], HRESULT: 0x800700C1
The library hostfxr.dll was found, but loading it from C:\Users\Daniel Li\source\repos\EntityFrameworkCore.dotnet\host\fxr\3.0.0-preview8-27905-07\hostfxr.dll failed

Installing .NET Core prerequisites might help resolve this problem.
https://go.microsoft.com/fwlink/?linkid=798306

However, I think I have all the prerequisites installed:
Further technical details
OS Name: Microsoft Windows 10 Enterprise
IDE: Visual Studio Community 2019 Version 16.1.5
Microsoft .NET Framework Version 4.7.03056
.NET Core 3.0.100-preview6-012264 (in C:\Program Files\dotnet\sdk)
I can't seem to view the SDK version and runtime version with "dotnet --info", I get a similar output:
dotnet : Failed to load the dll from [C:\Users\Daniel Li\source\repos\EntityFrameworkCore.dotnet\host\fxr\3.0.0-preview8-27905-07\hostfxr.dll], HRESULT: 0x800700C1
At line:1 char:1

dotnet --info

  + CategoryInfo          : NotSpecified: (Failed to load ...ULT: 0x800700C1:String) [], RemoteException
  + FullyQualifiedErrorId : NativeCommandError

The library hostfxr.dll was found, but loading it from C:\Users\Daniel Li\source\repos\EntityFrameworkCore.dotnet\host\fxr\3.0.0-preview8-27905-07\hostfxr.dll failed

Installing .NET Core prerequisites might help resolve this problem.
https://go.microsoft.com/fwlink/?linkid=798306

@daniel-li-djl87 Are you running build from the command line?
Note from triage: try on a clean machine.

Yes, I ran the build command and followed the instructions from: https://github.com/aspnet/EntityFrameworkCore/wiki/getting-and-building-the-code

@daniel-li-djl87 I'll try it on a clean machine in the coming days and see if I can reproduce.

@daniel-li-djl87 I tried on a clean machine and didn't run into any issues. I updated https://github.com/aspnet/EntityFrameworkCore/wiki/Getting-and-Building-the-Code to make a few things clearer. I tested with 16.1.5 Community Edition, with the "ASP.NET and web development" workload.
Some things to make sure of:

build on the command line is working
You are using startvs to open the Visual Studio solution

Thanks! I tried on a clean machine and I was able to get it to work.


Add Python 3 support

This was fairly straight forward to do. I used django.utils.six where required. Most of the changes required were to do with text/bytes. The XML generated by pysaml2(?) also differs between Pythons, with py2 having the <?xml .. ?> header, and py3 not.

Thanks!


Fix the auth_time claim in the OIDC support

Backport of https://github.com/apereo/cas/pull/5191

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Use jupytext-compatible markdown files instead of notebooks?

Notebooks don't work well with versioning, but the markdown files produced by jupytext do.  I suggest we only version the markdown versions in the repository, and render the notebooks for the documentation.
Edit: We use MyST-nb to build documentation from notebooks, and it does support notebooks in jupytext format. It is just a matter of converting the notebooks and configure the build in CI.

I see. I just noticed you have assigned yourself to this issue. If you've already started working on this issue already, I can take a look at other issues. thank you.

Got it. Thank you!


about example data

I would like to ask if I don't seem to find the subset tag in the sample data, only 'celltype_major' and 'celltype_minor'.
In addition, results from other methods are provided in the data, and I found that the different methods predicted a large disparity in the number of classes. However, these methods are based on marker data for classification, and removing the effect of unknown types, they should predict the same number of classes, right? I hope to get your help.

Hi
'celltype_major' and 'celltype_minor' are the manual annotation. They were created from the original manual annotation in 'celltype' column in obs field. I just renamed them to compare with HiCAT results.
HiCAT results are stored in 'HiCAT_major', 'HiCAT_minor' and 'HiCAT_subset', where the first two can be compared with the manual annotations to evaluate accuracy.
Regarding the question "However, these methods ...., right?", Yes, exactly, because I used the same markers (at different level) for all the tools I ran.
If you want to run other annotation tools I used, you can use the R wrapper package RCTI_collection at https://github.com/combio-dku/RCTIcollection


--onsite doesn't work on dune global pool

So you need a different GLIDEIN_SITE name (FNAL_GPGRID vs Fermigrid) for dune global pool versus the jobsub pools, for obscure glidein factory  config reasons.  Should we maybe make this an environment variable setting for what site is considered "onsite", or is there /should there be a classad we can read somewhere Ii.e. on the schedd's) that will tell us what is "onsite"?   Then we wouldn't need a new code release if it changes...

I actually wanted to talk about not just this issue, but also the idea of having a dune global pool "mode" (or maybe a different RPM/config install) for DUNE, so that things "just work" out of the box.  Right now, to submit to the dune global pool, they have to set _condor_COLLECTOR_HOST, etc.  It'd be nice if we could help them through either configuration, an easier environment variable, or a flag.
It would be easy enough to make this an environment variable, but I do like the idea of a schedd classad so we can read it dynamically.

In case it's useful we've been adding the GLIDEIN_DUNESite factory attribute to all sites where DUNE runs. For FermiGrid it's US_FNAL-FermiGrid. The CMS T1 is US_FNAL-T1. So you could consider looking at that when running in global pool mode.

This is related to #274.  So when that closes, this will be fixed.

Just talked with @njpfnal about how this would all work.  The tentative design is this.
Setup
Schedd
We propose that all global pool schedds that want to use jobsub_lite need to advertise the following classad attributes:

IsJobsubLite (already exists)
InDownTime (already exists)
Jobsub_OnsiteSiteName (NEW, name not fixed yet)
Jobsub_AccountingGroupTemplate (NEW, name not fixed yet)

(3) will be the site name that jobsub_lite uses if a user passes the --onsite flag.  It should match the GLIDEIN_Site classad that the glideins will advertise back to the collector.  For Fermilab, for example, this is FNAL_GPGrid.
(4) is a template in a yet-to-be-determined form (probably jinja, since we use it already), for the accounting group convention the global pool uses.  This is needed because, for example, GPGrid uses group_<experiment>.<subgroup>.<user>, whereas the DUNE Global pool uses <subgroup>.<user>, or (tentatively) just <user> if no subgroup is given.  If, for example, we do decide to have this template string be jinja2, it'd be something like "{% if subgroup is defined and subgroup %}{{subgroup}}.{{user}}{% else %}{{user}}{% endif %}".
Local
We need to have the collector host for the global pool specified locally so jobsub_lite knows where to get the schedd list.  This can be specified in either the Condor configuration as a separate RPM with just the config file, or in our jobsub_lite configurations as environment variables.  The first is tougher to deploy, but a lot cleaner of an architecture than the second.
Order of operations for jobsub_lite
Assume user submits something like jobsub_submit -G dune --subgroup mars --global-pool dune file://blah

Get collector from local configuration
Query onsite schedd (how we determine that is TBD - maybe we need to match the IP address of a submitter's node to the schedds) for (1)-(4) above.
Use (3) and (4) to populate submission template

Items to figure out before starting development in jobsub_lite code:

[ ] How should we configure the collector name?
[ ] How do we determine which schedd in a pool is onsite?
[ ] Finalize names of classad attributes that schedds must advertise

So the collector name is pretty much already done -- we ask condor.  That means it can be either in the condor config files, or in _condor_COLLECTOR_HOST  in the environment.   We can do either way in the config rpms.
I think for determining local schedd's, we were discussing in #351 having yet another new classad on the schedd with a list of subnet masks or wildcarded domain names for hosts that can submit.    Not sure if that means we should roll #351 into this ticket or what.

I think #351 should remain separate, only because it's closely related but slightly different.  That ticket is talking about saying which nodes can submit to a schedd, whereas in the design laid out above, we need to somehow specify on the schedd which domains are "onsite".  The problem lies in the fact that we might be able to submit (at some point in the future) to a schedd that's offsite, but allowed according to the standard established in #351.
I would be satisfied for the time being just matching domain-names, but that would mean that we would cut out support for, say, me installing jobsub_lite on my own laptop, having access to all the proper credentials, and then submitting to the global pool.  So I'm hoping we can come up with a different way to do it.

Now, with #376 closed, this should now work.  I will test.
ETA:  Test job<EMAIL_ADDRESS>jobsub_command:  jobsub_submit -G dune --global-pool dune --onsite file:///usr/bin/sleep 300

We have received management direction that this item, while it should remain open, should not be a top priority.  DUNE users using the global pool are expected to operate under the assumption that everything is "offsite", and thus not use the --onsite/--offsite flags in best practice.  So while we will come back to this and fix it at some point, it does not need to be addressed immediately.


StackOverflow cleanup Track 1 references, answer unanswered questions for Service Bus

Issue
Link
Status
Action
SDK Version
Python Version
Platform

Receive Topic is Slow
Link
✔
Post a sample in v7
v0.5
-
-

to send to a queue and listen for the answer in another
Link
✔
give an example from track2
0.5
-
-

failed to open session
Link
✔
already have a t2 example
0.5
-
-

look at the content of message
Link
✔
give a t2 example
0.5
-
-


./scripts/run_cmd.sh: 174: scripts/utils.sh: Syntax error: "(" unexpected (expecting "}")

When following Send commands to rockpaperscissors chaincode the following occurs:
sh ./scripts/run_cmd.sh createGame 0 1 "game1" 100 "user1"
./scripts/run_cmd.sh: 174: scripts/utils.sh: Syntax error: "(" unexpected (expecting "}")

Sorry for the late response I never saw this issue but I was not able to reproduce it. Were you using the latest versions?


Revert "1644 - Hide "Create space"-button on top level"

Reverts verji/matrix-react-sdk#49

Will revert as I think this PR was meant to be merged into verji-develop. And not develop
The changes in this PR - was accepted into verji-develop via Reza's PR - #51


Mesmer Inference Plugin

@Nick, This PR should be closed as there is another PR recently opened.
https://github.com/PolusAI/polus-plugins/pull/433


Ability to run one's own HTCondor instance

Hello,
I've ran the pipeline without HTCondor up until the processing results part (which I assume is not currently possible without running the pipeline in HTCondor unless I write a custom script that takes the non-HTCondor energize_output and packages it into a database understandable by metl).
From my understanding, it's unfeasible to generate a good enough training set without parallelizing the computation of rosetta's energy parameters for all variants. I've setup my own HTCondor instance to which I'm able to connect a few execute nodes, and would like to run metl-sim on my this cluster. The part that I don't understand is: do I really need to upload rosetta and python to osdf/squid if I'm running the algorithm only on my own machines? Or is there another way (such as adding the rosetta and python env to all execute nodes through my docker-compose)?
I might be wrong, but it seems like I would only need to upload to squid if I'm connecting to a highly distributed HTCondor cluster to which I don't have admin privileges to right?
Where in the scripts are the osdf python/rosetta env being accessed? Is there a workaround to skip that step and instead use a local install?

Great question @Ferryistaken. We have been thinking about ways to make melt-sim more accessible to others. Our initial ideas were around OSG, but running HTCondor locally is another approach.
If you are running HTCondor locally, there are a lot of code and data preparation steps you can skip. You do not need to upload anything to osdf/squid, it can stay on your local machine.
Regarding your last question code/energize.py specifies the path to Rosetta:
$ python code/energize.py -h
usage: energize.py [-h] [--rosetta_main_dir ROSETTA_MAIN_DIR]
                   [--variants_fn VARIANTS_FN] [--chain CHAIN]
                   [--pdb_dir PDB_DIR]
                   [--allowable_failure_fraction ALLOWABLE_FAILURE_FRACTION]
                   [--mutate_default_max_cycles MUTATE_DEFAULT_MAX_CYCLES]
                   [--relax_repeats RELAX_REPEATS]
                   [--relax_nstruct RELAX_NSTRUCT]
                   [--relax_distance RELAX_DISTANCE] [--save_wd]
                   [--log_dir_base LOG_DIR_BASE] [--cluster CLUSTER]
                   [--process PROCESS] [--commit_id COMMIT_ID]

 this is the run script that executes on the server

optional arguments:
  -h, --help            show this help message and exit
  --rosetta_main_dir ROSETTA_MAIN_DIR
                        path to the main directory of the rosetta distribution
  --variants_fn VARIANTS_FN
                        path to text file containing protein variants
  --chain CHAIN         the chain to use from the pdb file
  --pdb_dir PDB_DIR     directory containing the pdb files referenced in
                        variants_fn
  --allowable_failure_fraction ALLOWABLE_FAILURE_FRACTION
                        fraction of variants that can fail but still consider
                        this job successful
  --mutate_default_max_cycles MUTATE_DEFAULT_MAX_CYCLES
                        number of optimization cycles in the mutate step
  --relax_repeats RELAX_REPEATS
                        number of FastRelax repeats in the relax step
  --relax_nstruct RELAX_NSTRUCT
                        number of structures (restarts) in the relax step
  --relax_distance RELAX_DISTANCE
                        distance threshold in angstroms for the residue
                        selector in the relax step
  --save_wd             set this flag to save the full working directory for
                        each variant
  --log_dir_base LOG_DIR_BASE
                        base output directory where log dirs for each run will
                        be placed
  --cluster CLUSTER     cluster (when running on HTCondor)
  --process PROCESS     process (when running on HTCondor)
  --commit_id COMMIT_ID
                        the github commit id corresponding to this version of
                        the code

@samgelman what other steps can @Ferryistaken skip in the setup?

To add to what @agitter said, you should be able to use a local HTCondor with modifications to the existing framework.
The key files are:

The script condor.py that puts together everything needed for a condor run. It currently assumes a run on CHTC/OSG/OSDF, but it should be possible to use it for local runs with some modifications.
The submit file energize.sub. This will need to be modified so the job is correctly submitted to the local HTCondor installation. I'm guessing some flags like +WantFlocking = true and  +WantGlideIn = true, which are currently set in the file, won't be needed for a local run. This file also contains some keywords like {osdf_rosetta_distribution}, {osdf_python_distribution}, and {transfer_input_files}. These keywords get replaced with actual values by the condor.py script. These specify file paths to the execute nodes for the packaged Rosetta and Python distributions and additional input files. You may be able to leave these as-is and just specify local paths instead of OSDF paths in osdf_rosetta_distribution.txt and osdf_python_distribution.txt
The shell script which runs on the execute node run.sh. This file sets up the environment for Rosetta and launches energize.py with the appropriate arguments. Depending on how you package and transfer Python and Rosetta, this file will need to be modified.

Hopefully this is enough to get started, and if you encounter additional questions, I would be happy to help.

I wanted to add that if you plan to have a local install of Python and Rosetta on each execute node, then you won't need to transfer those from the submit node. You would need to modify the files I listed above, especially run.sh, to assume that Python/Rosetta are already installed on the execute nodes, rather than needing to be packaged and set up.

Yes, my current architecture involves having the python and rosetta installs on each execute node, and a modification to the run.sh and energize.sub to account for that. I might work on making a script and doing a PR if you guys would be interested.

@Ferryistaken I would be interested in having you contribute your solution back to this repo if you get everything working. We would need to decide the best way to organize that based on how many files you modified and how much they changed.


search fix for #9

maybe not the most elegant, but because cleanFieldName is only used in one spot for searching, I thought this would be sufficient
fix cleaning of name to not remove dots (allows for searching into an ob...ject) and also removes brackets, making it a dot notation which will allow mongo to properly query the array of the object.
for example:

"profile.name" does not become "profile" but stays "profile.name".
"emails[0].address" becomes "email.address" which makes the db query something like db.users.findOne({'emails.address': {$regex:"gmail.com"}})

Thank you for the PR, but I don't think this will work as written. We use the fields array for the publication, and that syntax is different (can't have dots), so there will need to be two different clean functions. Yours is fine for the search properties.

I manually merged this into the 1.0 code, now released. Thanks!


Class 'dbName.collectionName' does not exist

Why  am I getting this exception all of a sudden. This is happening for one of the queries I am building using aggregation builder.
I checked the dbName and collectionName which is correct.
Trace is given below:
{"trace":[{"file":"vendor/doctrine/common/lib/Doctrine/Common
/Persistence/Mapping/RuntimeReflectionService.php","line":41,"function":"nonExistingClass","class":"Doctrine
\\Common\\Persistence\\Mapping\\MappingException","type":"::","args":["dbName.collectionName"]},{"file"
:"vendor/doctrine/common/lib/Doctrine/Common/Persistence/Mapping
/AbstractClassMetadataFactory.php","line":281,"function":"getParentClasses","class":"Doctrine\\Common
\\Persistence\\Mapping\\RuntimeReflectionService","type":"->","args":["dbName.collectionName"]},{"file"
:"vendor/doctrine/common/lib/Doctrine/Common/Persistence/Mapping
/AbstractClassMetadataFactory.php","line":311,"function":"getParentClasses","class":"Doctrine\\Common
\\Persistence\\Mapping\\AbstractClassMetadataFactory","type":"->","args":["dbName.collectionName"]
}

The Doctrine ODM version I am using:
doctrine/doctrine-mongo-odm-module : 0.10.0
doctrine/mongodb-odm : 1.0.6

Could you please show some code that is leading to this error?

@alcaeus  below is the snippet. I think calling createQueryBuilder() after createAggregationBuilder() is causing the issue. But I had the same code before and it was working. I don't know which update broke this.
```
$collection = $this->dm->getDocumentCollection(Document::class);
$ab = $collection->createAggregationBuilder();
$qb = $this->dm->createQueryBuilder($collection);
$metadata = $this->dm->getMetadataFactory()->getAllMetadata();
/* @var $filterManager  \ZF\Doctrine\QueryBuilder\Filter\Service\ODMFilterManager */
$filterManager->filter($qb, $metadata[0], $params['filter']);
$ab->match()->equals($qb->getQuery()->getQuery()['query']);

hmm...
Changing
$qb = $this->dm->createQueryBuilder($collection);
to
$qb = $this->dm->createQueryBuilder(Document::class)
works. I don't remember why I was passing $collection before instead of Document::class and how did it work?

Ok my bad! It must be document name.

Ok my bad! It must be document name.

FWIW, it has always been that way. On the other hand, thanks for reminding me about filters. I had almost forgotten them for the ODM aggregation builder....again ;)


Adding more instruments in band

I would like to work on this issue. Please assign this to me under LGM SOC.

I would like to work on this issue as LGM Soc participant

Hey @akshatvirmani which instruments would you like to add

I would like to work on this issue as LGM Soc participant

@nilisha-jais I would like to add guitar, violin and other instruments.

I would like to work on the issue. along with adding new instruments in the drum I will make it play with the keyboard keys.


Top level changes (first part)

Issue #: /bcgov/entity#6546
Description of changes:

update app version
updated shared enums dependency
updated shared fee summary dependency
moved fee summary affix to main page
added fee summary error message (WIP)
misc cleanup
updated alteration section header
updated phone ext per uxpin
deleted obsolete local enum
updated unit tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

See no issues, LGTM


Deprecate --ssh flag

Closes #265
Because of the latest BE changes and the fact that the problems we had with https are now resolved, we can deprecate the --ssh flag and use https permanently. For backward compatibility, we are not going to remove it completely just yet so passing it will do noting (keep using https) and log a warning to notify the user.

[x] Did you write/update appropriate tests
[ ] Release notes updated (if appropriate)
[x] Appropriate logging output
[x] Issue linked

should add a bullet to release notes for this

should add a bullet to release notes for this

Yup :) while I was adding it I noticed that it'd be a good idea to also test for option.IsHidden in the command tests. Adding the ReleaseNotes now 😃


False positive for creating Moodle Course - Description field

Description
Message: Warning. detected XSS using libinjection. [file "/usr/local/etc/apache24/Includes/mod_security/crs/rules/REQUEST-941-APPLICATION-ATTACK-XSS.conf"] [l
ine "56"] [id "941100"] [msg "XSS Attack Detected via libinjection"] [data "Matched Data: XSS data found within ARGS:summary_editor[text]:
Test for WAF
"] [severity "CRITICAL"] [ver "OWASP_CRS/4.0.0-rc1"] [tag "application-multi"] [tag "language
-multi"] [tag "platform-multi"] [tag "attack-xss"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/242"]
Message: Warning. Pattern match "(?i)(?:(?:<\\w[\\s\\S]*[\\s/]|['\"](?:[\\s\\S]*[\\s/])?)(?:on(?:d(?:e(?:vice(?:(?:orienta|mo)tion|proximity|found|light)|live
ry(?:success|error)|activate)|r(?:ag(?:e(?:n(?:ter|d)|xit)|(?:gestur|leav)e|start|drop|over)|op)|i(?:s(?:c(?:hargingtimechange| ..." at ARGS:summary_editor[te
xt]. [file "/usr/local/etc/apache24/Includes/mod_security/crs/rules/REQUEST-941-APPLICATION-ATTACK-XSS.conf"] [line "175"] [id "941160"] [msg "NoScript XSS In
jectionChecker: HTML Injection"] [data "Matched Data: <p dir=\x22ltr\x22 style= found within ARGS:summary_editor[text]:
Test for WAF
"] [severity "CRITICAL"] [ver "OWASP_CRS/4.0.0-rc1"] [tag "application-multi"] [tag "language-multi"] [tag "plat
form-multi"] [tag "attack-xss"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/242"]
Message: Warning. Unconditional match in SecAction. [file "/usr/local/etc/apache24/Includes/mod_security/crs/rules/RESPONSE-980-CORRELATION.conf"] [line "96"]
 [id "980170"] [msg "Anomaly Scores: (Inbound Scores: blocking=10, detection=10, per_pl=10-0-0-0, threshold=20) - (Outbound Scores: blocking=0, detection=0, p
er_pl=0-0-0-0, threshold=20) - (SQLI=0, XSS=10, RFI=0, LFI=0, RCE=0, PHPI=0, HTTP=0, SESS=0)"] [ver "OWASP_CRS/4.0.0-rc1"] [tag "reporting"]
Apache-Error: [file "apache2_util.c"] [line 271] [level 3] [client IPv6] ModSecurity: Warning. detected XSS using libinjecti
on. [file "/usr/local/etc/apache24/Includes/mod_security/crs/rules/REQUEST-941-APPLICATION-ATTACK-XSS.conf"] [line "56"] [id "941100"] [msg "XSS Attack Detect
ed via libinjection"] [data "Matched Data: XSS data found within ARGS:summary_editor[text]:
<st
rong>Test for WAF
"] [severity "CRITICAL"] [ver "OWASP_CRS/4.0.0-rc1"] [tag "application-multi"] [tag "language-multi"] [tag "platform-multi"] [ta
g "attack-xss"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/242"] [hostname "DOMAIN"] [uri "/moodle/moodle/course/edit.ph
p"] [unique_id "YpWsZoHqbzV6-5op7MRNLQAAARA"]
Apache-Error: [file "apache2_util.c"] [line 271] [level 3] [client IPv6] ModSecurity: Warning. Pattern match "(?i)(?:(?:<\\\
\\\\\w[\\\\\\\\s\\\\\\\\S]*[\\\\\\\\s/]|['\\\\"](?:[\\\\\\\\s\\\\\\\\S]*[\\\\\\\\s/])?)(?:on(?:d(?:e(?:vice(?:(?:orienta|mo)tion|proximity|found|light)|livery
(?:success|error)|activate)|r(?:ag(?:e(?:n(?:ter|d)|xit)|(?:gestur|leav)e|start|drop|over)|op)|i(?:s(?:c(?:hargingtimechange| ..." at ARGS:summary_editor[text
]. [file "/usr/local/etc/apache24/Includes/mod_security/crs/rules/REQUEST-941-APPLICATION-ATTACK-XSS.conf"] [line "175"] [id "941160"] [msg "NoScript XSS Inje
ctionChecker: HTML Injection"] [data "Matched Data: <p dir=\\\\x22ltr\\\\x22 style= found within ARGS:summary_editor[text]:
Test for WAF
"] [severity "CRITICAL"] [ver "OWASP_CRS/4.0.0-rc1"] [tag "application-multi"] [tag "language-mu
lti"] [tag "platform-multi"] [tag "attack-xss"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/242"] [hostname "DOMAIN"] [ur
i "/moodle/moodle/course/edit.php"] [unique_id "YpWsZoHqbzV6-5op7MRNLQAAARA"]
Apache-Error: [file "apache2_util.c"] [line 271] [level 3] [client IPv6] ModSecurity: Warning. Unconditional match in SecAct
ion. [file "/usr/local/etc/apache24/Includes/mod_security/crs/rules/RESPONSE-980-CORRELATION.conf"] [line "96"] [id "980170"] [msg "Anomaly Scores: (Inbound S
cores: blocking=10, detection=10, per_pl=10-0-0-0, threshold=20) - (Outbound Scores: blocking=0, detection=0, per_pl=0-0-0-0, threshold=20) - (SQLI=0, XSS=10,
 RFI=0, LFI=0, RCE=0, PHPI=0, HTTP=0, SESS=0)"] [ver "OWASP_CRS/4.0.0-rc1"] [tag "reporting"] [hostname "DOMAIN"] [uri "/moodle/moodle/course
/edit.php"] [unique_id "YpWsZoHqbzV6-5op7MRNLQAAARA"]
Apache-Handler: application/x-httpd-php73
Stopwatch:<PHONE_NUMBER>645471 414603 (- - -)
Stopwatch2:<PHONE_NUMBER>645471 414603; combined=40900, p1=1757, p2=37374, p3=363, p4=729, p5=677, sr=200, sw=0, l=0, gc=0
Response-Body-Transformed: Dechunked
Producer: ModSecurity for Apache/2.9.5 (http://www.modsecurity.org/); OWASP_CRS/4.0.0-rc1.
Server: Apache
Engine-Mode: "ENABLED"

Moodle Version: 4.0.1+ (Build: 20220527)
reproduce

.../mod_security/crs/rules/REQUEST-941-APPLICATION-ATTACK-XSS.conf"] [line "175"] [id "941160"] [msg "NoScript XSS InjectionChecker: HTML Injection"] [data "Matched Data: <p dir=\x22ltr\x22 style= found within ARGS:summary_editor[text]:
Test my cat course
"] [severity "CRITICAL"] [ver "OWASP_CRS/4.0.0-rc1"] [tag "application-multi"] [tag "language-multi"] [tag "platform-multi"] [tag "attack-xss"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/242"]

Audit Logs / Triggered Rule Numbers
Blocked by: 941100 and 941160
Your Environment

CRS version (e.g., v3.2.0): 4.0.0-rc1
Paranoia level setting: 1
ModSecurity version (e.g., 2.9.3): 2.9.5
Web Server and version (e.g., apache 2.4.41): 2.4.53
Operating System and version: FreeBSD

Confirmation

[x] I have removed any personal data (email addresses, IP addresses,
passwords, domain names) from any logs posted.

Hi @pesc!
Thank you for reporting your false positive with Moodle and the CRS.
We currently have no rule exclusion plugin for Moodle, so you have to tune the rules for your environment by writing the following rules after your CRS include:
SecRuleUpdateTargetById 941100 !ARGS:summary_editor[text]
SecRuleUpdateTargetById 941160 !ARGS:summary_editor[text]

I hope this helps.

Hi @franbuehler
Yes, sure this helps 👍
Will look into it and may create a Moodle plugin if there are many FP. Do you know if Moodle and the CRS work well together?

Some of my customers are using it and i have written only 5 exclusion rules so far, so it probably work quite well (but definitely not 100%).


Sticks Bug

According to your testing, does the issue occur with ONLY Immersive Portals mod and Farbic API?
No
Describe the issue
There is a huge bug running on my version of Inmersive portals in forge.  In first place, there are a lot of sticks that dont work. They are the ones that rotate the portal (X, Y, Z), the unbreakable portal, the fuse view, the "pos teleport, pos adjust", the one that dont render yourself, the one that ables and disables the isometric view, the ones that accelerat (and desacelerate), the ones that change your scale and the one with the wiki. Also in the creative page where the sticks and portals appears, the sticks multiplicate. This error also appears when I stop using mods.
Forge version is 40.1.76 running on 1.18.2.
The version of IP is the last one.
The mods active are Security Craft (1.9.31), Mr Crayfish Furniture, Chipped, Framed Blocks, Geckolib, Macaw Doors, MouseTweaks, Mowzies Mob, Secret Rooms and Selene.
I am not using any kind of shaders, but I tried to  use Optifine in that same version.

latest.log
Post the log here
I upload the log in the message because it was too long or uploading it.

Thanks for the report. I suppose this is easy to fix, though I need a bit of extra information. When using the broken sticks, what happens? Nothing? An error message in the chat? Something else?
Also, I know this is quite some work, but could you please list all broken command sticks so I don't forget to fix one.

Immersive Portals Version is 1.4.10-mc1.18.2. (Note for the future: Please write out the version. Latest is not static and as such quite useless.)

Yeah, I found the cause will fix it soonTM.

Yeah, I found the cause will fix it soonTM.

so what, was it that hard to check the issue instead of just blaming me?

Thank you very much 🙏

This will actually take longer as I thought, as this requires me to rewrite at least one protocol completely, also containing it's countless codecs...

I suggest usage of commands for now and then reloading the world to manually sync the portals

Please try with the newest version 1.4.11


optimize the implementation of header::content_type()

Coverage decreased (-0.3%) to 69.507% when pulling c0ae30849a118a8757b98a7633bddd7e8d4d1c0d on input-header into d10c601671256252596836ea9b74f78f2dc376c5 on master.


Connection tracking leak in HttpClient

When using HttpClient.maxConnectionsPerHost, there seem to be a few unhandled cases that end with the number of connections the client thinks it has open creeping up, eventually leading to all requests being blocked since there is no room for real connections left. I noticed this since I use that option in my flutter app. After the app is open for a few days, the HttpClient will start hanging on all requests to the most-frequently used host.
A really easy reproduction can be found on macOS with a flutter sandboxed app where you don't have com.apple.security.network.client entitlement. When making any network request, a SocketException will be thrown to the caller, but the _ConnectionTarget._connecting count will remain increased by 1, even though the connection failed. So if you have maxConnectionsPerHost set to 1, you will get an exception on the first request, and all subsequent requests to the same host will hang.
I can see a similar reproduction when toggling Wi-Fi with active HTTP connections. But I don't know whether dart or macOS is keeping those dead sockets open.
So depending on in which phase socket errors occur, it might not properly update the count of open connections.
Version: 2.19.0-226.0.dev, macOS (arm64)

CC @brianquinlan

I can reproduce this.
_ConnectionTarget.connect(...) is a bit of a beast...


RCTRootView: add needsReRender flag - fixes 20115

See https://github.com/facebook/react-native/issues/20115
I know there is probably a lot wrong with this implementation:

Not sure if this bug should be fixed in this file
Not sure if you want a flag like this just for this reason?
Even if you want the flag, the name should probably be something else..

Please view it as a first take on fixing 20115 (this is my first ReactNative PR \0/).
Test Plan:
See https://github.com/facebook/react-native/issues/20115
Release Notes:
[IOS] [BREAKING] [RCTRootView] - Fix bug where view is not re-rendered if AppProperties change while bridge is loading

Note sure why tests fail, seems like the packager can't start..

Thanks for the comment Bot!
I've rebased my commit.
Not sure about the reviewers, but I can see @javache did a couple of reviews for the code around the changed lines. Maybe he could scan through the issue and PR?

Sure. Rebased. Maybe one of @javache, @fkgozali, @sophiebits, @shergin, @alexeylang, @nicklockwood could take a look? It's been 2.5 months now 😅

Thank you for the PR. I think to be honest we should change the documentation to point out that changing the props while the bridge is loading is not a good idea. On the issue you posted there are some workarounds that you can use instead of adding complexity to RN. I'm going to close this PR.

Ok. But you closed both the PR and the issue without pointing it out in the docs?

Please feel free to send a PR to the react-native-website repo to add this as a note. Thank you!

Please feel free to send a PR to the react-native-website repo to add this as a note. Thank you!

Sorry, no time for this at the moment

Btw, last time I tried to add / ask something about the documentation, this was the result: https://github.com/facebook/react-native-website/issues/671


CB-20961: Multiple Python3 versions on the same image, depending on image type and RT version

Original requirement from Slack:
<IP_ADDRESS> (and all subsequent 7.2.16.x service packs) CentOS7 images:
Python 2 present on the Cloudbreak images
Python 3 present on the Cloudbreak images, Py 3.6 remains the default for “python3”, but Py3.8 is also present (for Hue)
7.2.17 (and all subsequent 7.2.17 service packs:) CentOS7 images:
Python 2 present on the Cloudbreak images
Python 3 present on the Cloudbreak images, Py 3.6 remains the default for “python3", but Py3.8 is also present (for Hue)
7.2.17 (and all subsequent 7.2.17 service packs:) RHEL8 images:
Python 2 present on the Cloudbreak images
Python 3 present on the Cloudbreak images, Py 3.8 becomes the default for “python3”, but Py3.6 is also present (for legacy apps, including pyspark2)
Also, additional info:
<IP_ADDRESS> (and all subsequent 7.2.16.x service packs) RHEL8 images:
Python 3 present on the Cloudbreak images, Py 3.6 remains the default for “python3”, but Py3.8 is also present (for Hue)
Base RHEL8 images:
Python 3 present on the Cloudbreak images, Py 3.6 remains the default for “python3”, but Py3.8 is also present (for Hue)
Base CentOS images:
Python 2 present on the Cloudbreak images
Python 3 present on the Cloudbreak images, Py 3.6 remains the default for “python3", but Py3.8 is also present (for Hue)

Image contents for a 7.2.17 image:

CentOS 7 base image contents burned with this branch:

Image contents for a RHEL8 7.2.16 image burned with this branch:


Error: Cannot find module 'laravel-elixir/ingredients/commands/Utilities'

Error: Cannot find module 'laravel-elixir/ingredients/commands/Utilities'

This package is Deprecated since you can use babel options directly on Elixir https://github.com/joecohens/laravel-elixir-react#deprecated-babel-is-now-included-on-elixir-by-default

Also you can look at https://github.com/joecohens/laravel-elixir-react/issues/6


Apple MFI support

Hi,
We want to use Bluetooth Classic with iOS device.
Can we support Apple MFi with this firmware? Please support.
Best regards,
Dat.

@boyhuesd Sorry, We don't support Apple MFi with Bluetooth.

@boyhuesd Sorry, We don't support Apple MFi with Bluetooth.

Thank you.