BIGTOP-3740: Add Zeppelin support for Bigtop 3.1.0 Mpack

Description of PR
Add Zeppelin support for Bigtop 3.1.0 Mpack
How was this patch tested?
Need to test with #953
Visit localhost:9995 to access zeppelin web ui(if you are using docker env, remember to expose the port to your local machine).
For code changes:

[ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'BIGTOP-3638. Your PR title ...')?
[ ] Make sure that newly added files do not have any licensing issues. When in doubt refer to https://www.apache.org/licenses/

Sorry, I left tests info under wrong pull request, please redirect to #953

Simple tests for python and shell succeed, others may need to install interpreter manually.

change notebook storage dir to /user/zeppelin/

It would take a while to rebuild Ambari and pls give me some time to test this PR, thanks

Re-build and deploy zeppelin based on Bigtop 3.1.0 repo:
It seems Zeppelin Notebook Start failed:
Python script has been killed due to timeout after waiting 10000 secs
2022-07-21 06:19:47,512 - get_user_call_output returned
 (0, u'{"RemoteException":{"exception":
"FileNotFoundException","javaClassName":"java.io.FileNotFoundException",
"message":
"File does not exist: /user/zeppelin/notebook/R Tutorial/2. Shiny App_2EZ66TM57.zpln"}}404', u'')

2022-07-21 06:19:47,512 - Creating new file /user/zeppelin/notebook/R Tutorial/2.
Shiny App_2EZ66TM57.zpln in DFS
2022-07-21 06:19:47,514 - call['ambari-sudo.sh su hdfs -l -s /bin/bash -c
 'curl -sS -L -w '"'"'%{http_code}'"'"' -X PUT --data-binary '"'"'@/var/lib/zeppelin/notebook/R Tutorial/2.
Shiny App_2EZ66TM57.zpln'"'"' -H '"'"'Content-Type: application/octet-stream'"'"'
'"'"'http://ambari-agent-01:50070/webhdfs/v1/user/zeppelin/notebook/R%20Tutorial/2.%20Shiny%20App_2EZ66TM57.zpln?op
=CREATE&user.name=hdfs&overwrite=True'"'"' 1>/tmp/tmptNTDU6 2>/tmp/tmpIDDAyp'']
 {'logoutput': None, 'quiet': False}

Does it caused by BIGTOP-3714 too?

Re-built Ambari with #953, and deployed zeppelin based on Bigtop 3.1.0 repo:
It seems Zeppelin Notebook Start failed: Python script has been killed due to timeout after waiting 10000 secs
2022-07-21 06:19:47,512 - get_user_call_output returned
 (0, u'{"RemoteException":{"exception":
"FileNotFoundException","javaClassName":"java.io.FileNotFoundException",
"message":
"File does not exist: /user/zeppelin/notebook/R Tutorial/2. Shiny App_2EZ66TM57.zpln"}}404', u'')

2022-07-21 06:19:47,512 - Creating new file /user/zeppelin/notebook/R Tutorial/2.
Shiny App_2EZ66TM57.zpln in DFS
2022-07-21 06:19:47,514 - call['ambari-sudo.sh su hdfs -l -s /bin/bash -c
 'curl -sS -L -w '"'"'%{http_code}'"'"' -X PUT --data-binary '"'"'@/var/lib/zeppelin/notebook/R Tutorial/2.
Shiny App_2EZ66TM57.zpln'"'"' -H '"'"'Content-Type: application/octet-stream'"'"'
'"'"'http://ambari-agent-01:50070/webhdfs/v1/user/zeppelin/notebook/R%20Tutorial/2.%20Shiny%20App_2EZ66TM57.zpln?op
=CREATE&user.name=hdfs&overwrite=True'"'"' 1>/tmp/tmptNTDU6 2>/tmp/tmpIDDAyp'']
 {'logoutput': None, 'quiet': False}

Was it caused by BIGTOP-3714 too?

Yes @guyuqi

Re-built Ambari with #953, and deployed zeppelin based on Bigtop 3.1.0 repo:
It seems Zeppelin Notebook Start failed: Python script has been killed due to timeout after waiting 10000 secs
2022-07-21 06:19:47,512 - get_user_call_output returned
 (0, u'{"RemoteException":{"exception":
"FileNotFoundException","javaClassName":"java.io.FileNotFoundException",
"message":
"File does not exist: /user/zeppelin/notebook/R Tutorial/2. Shiny App_2EZ66TM57.zpln"}}404', u'')

2022-07-21 06:19:47,512 - Creating new file /user/zeppelin/notebook/R Tutorial/2.
Shiny App_2EZ66TM57.zpln in DFS
2022-07-21 06:19:47,514 - call['ambari-sudo.sh su hdfs -l -s /bin/bash -c
 'curl -sS -L -w '"'"'%{http_code}'"'"' -X PUT --data-binary '"'"'@/var/lib/zeppelin/notebook/R Tutorial/2.
Shiny App_2EZ66TM57.zpln'"'"' -H '"'"'Content-Type: application/octet-stream'"'"'
'"'"'http://ambari-agent-01:50070/webhdfs/v1/user/zeppelin/notebook/R%20Tutorial/2.%20Shiny%20App_2EZ66TM57.zpln?op
=CREATE&user.name=hdfs&overwrite=True'"'"' 1>/tmp/tmptNTDU6 2>/tmp/tmpIDDAyp'']
 {'logoutput': None, 'quiet': False}

Was it caused by BIGTOP-3714 too?

Yes @guyuqi

Thanks, @kevinw66
I'm working on Bump Zeppelin to 0.10.1.
I'd like merge this PR after BIGTOP-3700 resolved.

Re-built Ambari with https://github.com/apache/bigtop/pull/953 and successfully deployed Zeppelin against on Hadoop-3.3.4.
LGTM, +1
And one more thing, could you please expose port 9995 like -p 9995:9995 in https://github.com/apache/bigtop/blob/master/bigtop-packages/src/common/bigtop-ambari-mpack/dev-support/docker/centos7/build-containers.sh#L44?  @kevinw66

Re-built Ambari with #953 and successfully deployed Zeppelin against on Hadoop-3.3.4.
LGTM, +1
And one more thing, could you please expose port 9995  in this PR like -p 9995:9995 in https://github.com/apache/bigtop/blob/master/bigtop-packages/src/common/bigtop-ambari-mpack/dev-support/docker/centos7/build-containers.sh#L44?
@kevinw66

@guyuqi I can only choose one container to expose the port(default is ambari-agent-01), but this is useless if we choose different container to install zeppelin.

Just expose port 9995 in https://github.com/apache/bigtop/blob/master/bigtop-packages/src/common/bigtop-ambari-mpack/dev-support/docker/centos7/build-containers.sh#L44,  not in Mpack service module.
In Mpack test, Zeppelin server would be always installed ambari-agent01.

Thanks, @kevinw66


[BEAM-6011] Phrase triggering nexmark

This PR enables running Nexmark jobs from PRs using Phrase Triggering.
Phrase triggered Jobs:

run exactly the same option sets as the PostCommit ones
have separate jenkins jobs definitions
publish results to "nexmark_PRs" dataset whereas the original jobs use "nexmark" dataset. Thanks to that there is no "data pollution"

Additionally, I created a special "Nexmark Builder" that encapsulates all tasks common to Nexmark.
Despite the fact that I checked if the jobs run as they should, I didn't want to touch original jobs code yet give everyone time to spot any differences between the jobs (original/phrase triggered) if they occur. This can be easily done later in a separate PR by replacing the gradle goals code from origial jobs with the following line (example for direct runner):
Nexmark.standardJob(delegate, Nexmark.Runner.DIRECT, JOB_SPECIFIC_OPTIONS, Nexmark.TriggeringContext.POST_COMMIT)

If you think this should be done now, let me know.

Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.
 Please don't mind the commit history - I will rebase this branch after your review if that's ok.

Run seed job

Run Direct Runner Nexmark Tests

Run Dataflow Runner Nexmark Tests

Run Flink Runner Nexmark Tests

Run Spark Runner Nexmark Tests

(double checking after rebase)

I fixed a typo in Github UI hints:  "Direct Flink Nexmark Tests" -> "Flink Runner Nexmark Tests"

Run seed job

Run Dataflow Runner Nexmark Tests

Run Spark Runner Nexmark Tests

Run Flink Runner Nexmark Tests

Run Direct Runner Nexmark Tests

@lgajowy thanks for that ! Nice ! Is there an easy wayto consult the output of PR trigerred nexmark runsso that we can detect regression on other PRs with nexmark?

I think developers can compare the results of PR triggered job printed to the job console output with graphs here, am I right? This may require some logs searching though (might be cumbersome).
Another idea that I have is to copy the plots for periodic jobs but add another line (set of datapoints) in different color on them for PR jobs. Invalid results would be then super visible on the plots. We could also think of ways of displaying this stuff in the PR directly (I don't know yet how, though)...
What do you all think about this?

Fair enough

Nice!


Android HeadlessJS Crash - Tried to finish non-existent task with id

Description
Hi there, I've seen this crash to happen much more since Android 12 and 96% Samsung devices.
I cannot reproduce and I do not use any library that uses Headless tasks.
Crashlytics:
Fatal Exception: java.lang.AssertionError: Tried to finish non-existent task with id 1.
at com.facebook.infer.annotation.Assertions.assertCondition(Assertions.java:88)
at com.facebook.react.jstasks.HeadlessJsTaskContext.finishTask(HeadlessJsTaskContext.java:173)
at com.facebook.react.jstasks.HeadlessJsTaskContext$3.run(HeadlessJsTaskContext.java:211)
at android.os.Handler.handleCallback(Handler.java:938)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loopOnce(Looper.java:226)
at android.os.Looper.loop(Looper.java:313)
at com.facebook.react.bridge.queue.MessageQueueThreadImpl$4.run(MessageQueueThreadImpl.java:228)
at java.lang.Thread.run(Thread.java:920)
Related https://github.com/facebook/react-native/issues/27597
Version
0.68.2
Output of npx react-native info
npx react-native info
info Fetching system and libraries information...
System:
OS: Windows 10 10.0.22000
CPU: (16) x64 AMD Ryzen 7 3700X 8-Core Processor
Memory: 10.64 GB / 31.92 GB
Binaries:
Node: 14.16.0 - C:\Program Files\nodejs\node.EXE
Yarn: 1.22.11 - ~\AppData\Roaming\npm\node_modules\yarn\bin\yarn.CMD
npm: 6.14.11 - C:\Program Files\nodejs\npm.CMD
Watchman: 20200816.222424.0 - C:\sites\tools\watchman\bin\watchman.EXE
SDKs:
Android SDK: Not Found
Windows SDK: Not Found
IDEs:
Android Studio: Version  <IP_ADDRESS> AI-201.87<IP_ADDRESS>99119
Visual Studio: Not Found
Languages:
Java: <IP_ADDRESS> - /cygdrive/c/Program Files/Eclipse Adoptium/jdk-<IP_ADDRESS>-hotspot/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: ^17.0.2 => 17.0.2
react-native: ^0.68.2 => 0.68.2
react-native-windows: Not Found
npmGlobalPackages:
react-native: Not Found
Steps to reproduce
Cannot reproduce it.
Snack, code example, screenshot, or link to a repository
No response

Same issue here on Android 9+ and 94% Samsung react-native: 0.68.2

Having the same issue and I'm unable to reproduce the issue

That's the issue, I cannot reproduce it in any ways and I have a Samsung with Android 12. Never saw the crash happening but I have some users complaining about it.

I am having this same as well. Mostly on android samsung 12. Not sure how to reproduce this issue.

That's the issue, I cannot reproduce it in any ways and I have a Samsung with Android 12. Never saw the crash happening but I have some users complaining about it.

We can't really help further without a reproducer

Did you guys figure out any fix for this? It seems that this particular code is written here in react native repo, https://github.com/facebook/react-native/blob/main/ReactAndroid/src/main/java/com/facebook/react/jstasks/HeadlessJsTaskContext.java#L174

Nope, and yes it looks like that particular code is the responsible, maybe don't throw exception if doesn't find the task to finish?

Yeah as long as the app does not crash :(

Did any one got the fix for this crash?

Nope happening still 😅

I am having same issue

Still having same issue

Did anyone got solution for this issue?

@Saad-Bashar What did you comment on in HeadlessContext class? Can you please help

@pedrolopes10 Did you find any solutions?

El sáb, 10 jun 2023 5:28, malikzype @.***> escribió:

@pedrolopes10 https://github.com/pedrolopes10 Did you find any
solutions?
—
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/issues/33883#issuecomment-1585475831,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A6XCIFDOYFMHEQZCV2XCUCLXKPZYJANCNFSM5WQGIW2A
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

@pedrolopes10 Did you find any solutions?

Nope, still happening here

any update here?

Yes, even we are facing this issue.

facing this issue +1

Facing this issue

Same issue here


SECP256K1 calculation wrong

"v" value is calculated in a wrong way. It should be either 27 or 28.

@biboran/z please, pay attention to this issue

You @kondranton/z need to have one of these roles in order to do "Request order start": ARC, PO; I'm sorry to say this, but at the moment you've got no roles in this project

@kondranton could you give an example of input for EthTransactionBytes which output an incorrect sequence of bytes?
Afaik v has nothing to do with ecdsa and is an incorrect convenience people use in web3 libraries implementation. Our implementation currently supports only EIP-155 transaction signing scheme as you can see here which is v = networkID * 2 + 35 + ecdsa.recid instead of v = 27 + ecdsa.recid and a couple more arguments for an ecdsa.
I guess if we need a support for legacy signing we should declare something like LegacyTransactionBytes and use pre EIP-155 transaction signing scheme.

I believe this is not longer relevant. Here is a sample for 0x transaction signing instead.

The job is not in WBS, won't close the order


Changed the version variable in init

Needed for the release script to work and because it is more logical in this way.

Coverage remained the same at 98.442% when pulling f20d6ff2da1c37d781736ecb7ee874d5dcbd0155 on gdm_move_version_number into 76b4bac2e37c779a43dd52ffc127302075f9d59c on master.


Better relocation tests

This test reporduces the same project in two locations, and runs the following checks:

does the results load from cache when the project is executed from a different location?
does the task in question stay up-to-date when there are no changes?
does the task produce the same (normalized) results in both locations?

This test is more capable and allows for simpler tests than
AbstractTaskRelocationIntegrationTest, which relies on changing individual parameters of
a task to simulate relocation.

Feedback build: https://builds.gradle.org/viewQueued.html?itemId=9865852

There are still some tests using it.

Feedback build again, because timeout: https://builds.gradle.org/viewQueued.html?itemId=9874730


Patch upgrade feature

Pull Request summary:
Add Patch upgrade api support for new feature
Description of changes:
Create testing interface to trigger patch upgrade job. Sample usage below:
// Create session and chose vmanage device
session = create_manager_session(...)
device = DevicesAPI(session).get().filter(personality = Personality.VMANAGE)[0]
// The patch image with the specified version needs to be uploaded beforehand.
version = "20.15.1-023"
// Patch device. Requires passing the vmanage version vmanage will be patched to.
PatchAction(session, device).execute(version)
Checklist:

[x] Make sure to run pre-commit before committing changes
[x] Make sure all checks have passed
[x] PR description is clear and comprehensive
[x] Mentioned the issue that this PR solves (if applicable)
[x] Make sure you test the changes

Let's start with this https://github.com/CiscoDevNet/catalystwan/issues/495 so Task can be free of restart detection logic and can be reused in all APIs.

REPOSITORY MOVED TO NEW ORIGIN !
https://github.com/cisco-open/cisco-catalyst-wan-sdk

REPOSITORY MOVED TO NEW ORIGIN !
https://github.com/cisco-open/cisco-catalyst-wan-sdk


Prevent lock up on regular expressions with infinite matches. Fixes #77

If we check and skip empty matches, the browser still bogs down a little, but doesn't lock up.

I've tried this and it seems to fix the problem. Thanks!

Thanks @Mottie for this solution approach.
Unfortunately this doesn't follow the max 80chars line length rule:

Please move this check into the loop, like I've done for the filterCb (see screenshot above).
Also affected by the max line length issue are the tests (describe and it statements). You can take e.g. ignore-joiners-synonyms-diacritics as a reference.
I'm going to integrate a code style checker as a next step, to make sure you'll be notified about such annoying things while implementing.
Furthermore you're using 0 as an index. As you can see from the other match accesses, matchIdx should be used instead. This is necessary because the index changes depending on the custom parameter.

Unfortunately this doesn't follow the max 80chars line length rule:

The code style file actually has javascript set to 120 chars. Only HTML is set to 80.
Also if I use Atom beautify, it adds a space after all if (if () and while (while {) statements.
Lastly, how strict is this 80chars rule? Is it a plus one is okay, or absolute?

Please move this check into the loop

The infinite loops occur if you move the check inside the while loop because there are infinite matches.
Maybe the update I just submitted where match.join("") !== "" is used is better?

The code style file actually has javascript set to 120 chars. Only HTML is set to 80.

That's true, because atom-beautify otherwise creates strange line breaks (it actually seems to wrap lines before 80chars – you can test this yourself). Anyway, my fault that this strict rule isn't included in the contribution guidelines.

Also if I use Atom beautify, it adds a space after all if (if () and while (while {) statements.

That's true. I've already tried to find an option to disable that but weren't successful. When I'm jusing jsbeautify directly via CLI this doesn't happen. Unfortunately there is no jsbeautify plugin for Atom, which is the reason why I'm using atom-beautify.

Lastly, how strict is this 80chars rule? Is a plus one is okay, or absolute?

It's strict. I'd say plus one is okay. But, I'm currently implementing a linter which will throw warnings/errors when you do something wrong. So to avoid these messages in future, I'd recommend to break after 80chars. I've already fixed the example you mentioned a few hours ago (didn't know that there is a deviation).

Maybe the update I just submitted where match.join("") !== "" is used is better?

What would be better? The matchIdx index is an index that will always match the group containing the actual search term. When you're using 0 as a fixed value or .join() a check === "" might be unsuccessfully because of the lookbehind group which may contain a blank (!== ""). To be safe, I'd recommend to use the named index.

To be safe, I'd recommend to use the named index.

The .join() is on the entire match. If I change the code to
while((match = regex.exec(node.textContent)) !== null) {
    if(!filterCb(match[matchIdx], node) && match[matchIdx] !== "") {

the browser locks up.

I created this demo with the changes I mentioned above to show that it locks up when using /\b/g as a query. I'm not really sure where to add that same check inside the wrapMatchesAcrossElements loop... I was thinking inside the wrapRangeInMappedTextNode callback, but again I'm not sure:
this.wrapRangeInMappedTextNode(dict, start, end, node => {
    return match[matchIdx] !== "" && filterCb(match[matchIdx], node);
}, (node, lastIndex) => {

It looks like GitHub implemented a method that would allow repo contributors, and owners, to modify the PR source... I won't be around for a few hours (Dr. appointment), so if you want to expedite things, you can update changes in my fork. Otherwise, I'll be back later.

the browser locks up.

You're right. Just tested it too and my solution approach doesn't work.

The .join() is on the entire match. If I change the code to

Exactly, and that's the problem. When you're using accuracy: "exactly" it will add a group containing a blank before the actual matching term, because of a lookbehind. From my point of view this is the reason why we can't join the entire match, as a blank isn't === "".
My tests with:
while(
    (match = regex.exec(node.textContent)) !== null &&
    match[matchIdx] !== ""
) {

were successfully.
Can you confirm this too?

It looks like GitHub implemented a method that would allow repo contributors, and owners, to modify the PR source.

True, but limited. Only via GitHub website and only on files the author already changed. Also this will only work for each file separately, it's not possible to update multiple files at once. You can hack the URL to also update files the author didn't change, but as mentioned this wouldn't work with e.g. the dist files as I don't want to upload them all separately. Last but not least it seems to use the wrong line endings when uploading on the GitHub website.

@Mottie Thank you very much for your contribution! I'm going to release this today.

Glad I could help! 😁

Thanks guys for fixing this!

@nikicc @Mottie Released. :tada:


LibraryJarInBootstrapTest activated in ScalaDebugTestSuite

This test also requires GUI support, you can't enable it. But you can ignore it instead of commenting it out.

LGTM

LGTM


Redirect instead of Popup

I would like to choose whether to use a popup or go the "long way" with a redirect. Is this possible? I could not find any info regarding the display property.

Popup is the only option that's available. Doing page redirect (not sure why you would want to in a single page app) would involve re-writing a lot of parts of Satellizer.

Could anybody tell me why there is a "display" option set to "popup" so ? Thanks :)


Addressing Markdown issues pointed out by Markdownlint

This PR addresses violations of rules enforced by Markdownlint. I am unsure with the issue, with C#, where I tried to apply a solution from StackOverflow.
Do note the addition of a .markdownlint.json file, with a proposed configuration for Markdownlint.
Since this project is quite fast moving, new violations might have been introduced since I originally made the changes.

Awesome, thanks!
I'll schedule some time to take a look at how we can integrate Markdownlint with a pipeline.

hi @viatsko
Sounds good, I am conducting my own research since I have several Markdown heavy projects and this would be a most welcome part. I will let you know what works for me, if any.

Thanks for the investigation!
I'm pretty sure that nvm should be available for ruby-based .travis.yml tho. I can check tomorrow night if that's the case and update this thread


[Snyk] Upgrade Rails 7.1.3 -> 7.1.5 for security fix

Snyk has created this PR to fix 1 vulnerabilities in the rubygems dependencies of this project.
Snyk changed the following file(s):

app/Gemfile

⚠ Warning
Failed to update the Gemfile.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue
Score

Cross-site Scripting (XSS) SNYK-RUBY-ACTIONPACK-8496389
  65

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
Max score is 1000. Note that the real score may have changed since the PR was raised.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Cross-site Scripting (XSS)

Closing due to https://github.com/DSACMS/iv-cbv-payroll/commit/3c31c43a976dd0d44f3aef07d2f9e7116fbeb184


Use .json data for Api Key

Hi,
I would like to use a .json file to get api key, but I get this error

ERROR in Error encountered resolving symbol values statically.

Here is my code in app.module.ts :
import * as googleConfig from './shared/googleConfig/googleApi.json';
AgmCoreModule.forRoot({       apiKey : (<any>googleConfig).key,       libraries: ["places","drawing"]     }),
And my .json:
{   "key": "MyKey" }
I already use .json data like this in other files, but it doesn't work like this. Any explanation ? :)
Thanks

Could you show your googleApi.json file ?

You should just be able to do AgmCoreModule.forRoot(require('./shared/googleConfig/googleApi.json'))


Dataset titles/labels in Explorer

Hi,
What is the intended way to control the displayed label/title of datasets when indexing from STAC documents (using s3-to-dc --stac)? Currently, all datasets are labeled by the filename of the STAC document. Unfortunately for us, this means all datasets are called the same thing.
Is this something we can change in Explorer, or is it an effect of the STAC-to-EO3 conversion?
This is what it looks like in Explorer:

Here's a snippet from the STAC document itself:

Hi,
I have included the chain of code that is responsible for displaying the label, the metadata definition required is label as per https://github.com/opendatacube/datacube-explorer/blob/322086297110396fb162853f69661c245ab71611/cubedash/_utils.py#L131
Here is a working example we host in Digitalearth Australia program: https://explorer-aws.dea.ga.gov.au/products/ga_ls7e_ard_3/datasets
https://github.com/opendatacube/datacube-explorer/blob/322086297110396fb162853f69661c245ab71611/cubedash/templates/search.html#L120
https://github.com/opendatacube/datacube-explorer/blob/ab2e114e779ceb12eefa2bc7712b33ffa6f662ef/cubedash/_filters.py#L44-L51
https://github.com/opendatacube/datacube-explorer/blob/322086297110396fb162853f69661c245ab71611/cubedash/_utils.py#L125-L142

Thank you. It appears the issue is not with Explorer. I will need to look into why the label field is not generated for us when indexing from our STAC documents.

Answered. Closing. May require an issue against https://github.com/opendatacube/odc-tools , but would need more information.


articles sections in careers page

Just do these in the career page for now

For all other pages, we'll pull the articles from the relevant sub-section in Coda (they all correlate to one of the designed pages now) within the How Can I Help section.
We'll also need some way to group the careers articles into the three categories. Any thoughts for how to do this?

Pull them in Coda's order

If the title exceeds four lines, use an ellipses at the end
Once the user clicks the right arrow, show 3 new articles (unless there are less than 3 to show, in which case just show 2 or 1)

Bonus: some sort of animation showing the cards sliding into place, rather than just instantaneously showing new cards

The button shown is secondary - alt. size small, so use this component

Use the disabled state when user cannot go right or left any further (changes are: no drop shadow, and color of arrow becomes cool grey 400)

Mobile will look like either of these, you choose

Nemo's etc for this is EOD thurs, EOD fri at latest

@mruwnik looks great. Only issues are

The articles are not the correct ones (work with @LeMurphant and @bryceerobertson on creating those new sections in Coda)
Mobile is a bit off (feel free to leave this one to me, just lmk)

yeah, I didn't do the css - sorry about that :/

@mruwnik the section is pulling in the top level (the 8 heading sections) and not the individual articles inside them. We can discuss at standup tomorrow.
I'll take care of the CSS


Added custom.css for own CSS styles

Users can add their custom CSS styles to the custom.css which will not be removed while updating Wikitten

Thanks!


Installation Instructions Required

This repo does not contain any instructions to build let alone run this program.

Please view the documentation at https://rocm.docs.amd.com

That doesn't help a Windows user on WSL2 bud.

There is currently no Windows version of ROCm available, and using WSL2 isn't helping as it does not detect my hardware.

ROCm is not supported on Windows including WSL2.

Bulls***, because I have it installed, and it successfully ran in TinyGrad.

Obviously there were error's, but that's fine.
The error's where due to myself not specifying an operation to run.

Unsupported configuration does not imply that something won't work in part... It just implies that it should be assumed that any issues with a particular unsupported configuration won't get support.

Its intended to fail if it runs on WSL2.
This is normal.


Compose window ready state

The first time I call the compose window (I think that it happens on the first uncached RainLoop instance), the To field gets focused but the window is not actually ready yet (you can see that the signature takes a while to load). So, if I start typing the recipient's e-mail right away (which I normally do), once the window is ready, all typed characters are reset so instead of<EMAIL_ADDRESS>I end up with something weird like<EMAIL_ADDRESS>

It seems fixed in v<IP_ADDRESS>1 (just updated now) on Chrome.


Write button & icon stories; change to variant & appearance

Please add designs to each story

Can we do something with?
/* eslint-disable import/no-unresolved */
import React, { SVGAttributes } from 'react'
import { DOMProps } from '@react-types/shared'

in components/icon/index.tsx
It's already in code, but would be good to fix before merging this one.

Can we do something with?
/* eslint-disable import/no-unresolved */
import React, { SVGAttributes } from 'react'
import { DOMProps } from '@react-types/shared'

in components/icon/index.tsx
It's already in code, but would be good to fix before merging this one.

done!

Please add designs to each story

done!


How to use multi-forms

Hi,
I've seen your multi-form branch, but I'd like to know how to use it correctly.
I have 1 form that always appears in the footer of the website (newsletter), and sometimes the contact form appears on other pages.
In that case, how do I call the recaptcha?
Can I use "@captcha()" in each form, or should I encode JS for face form?

I'm having this error after installing the "multi-forms" branch:

The error appears in this script

@albertcht Would you help me?

Hi @marcelogarbin ,
It looks like you didn't require jquery before calling @captcha(), did you?

Hi @albertcht , first thank you for your feedback.
That's right, I usually use the webpack to join all the JS and put it at the end of the tag body.
As it was at the end I did not pay attention to that. I put it in the beginning of the body and it worked.
But I am still in doubt about the operation.
I have 2 forms, 1 contact and 1 newsletter. One is in the center of the body, another in the footer.
When I send the data, I always use the request, in case:
RequestContato
return [
            'g-recaptcha-response' => 'required|captcha',
            'nome'                 => 'required|alpha_spaces|max:255',
            'email'                => 'required|email',
            'telefone'             => 'required|regex:/\([1-9]{2}\)\040[0-9]{4}\-[0-9]{4,5}/',
            'mensagem'             => 'required|min:10',
        ];

RequestNewsletter
return [
            'g-recaptcha-response' => 'required|captcha',
            'nome_newsletter'      => 'required|alpha_spaces|max:255',
            'email_newsletter'     => 'required|email',
        ];

When using multi-forms, is not it necessary to validate g-recaptcha-response?
Because when I try to send via the contact form, I get the following inputs:

And in the case of the newsletter:

What can this be? I'm not using AJAX.

Hi @marcelogarbin ,
Sorry for the late response, I'm currently busy working on another project. I will reply to you in few days.

Hi @marcelogarbin ,
g-recaptcha-response token should be taken to your request.  Can you listen the captcha event and dump your recaptcha token?
{!! Form::open(['url' => '/']) !!}
@captcha()
{!! Form::submit('Sumbit', ['id'=>'button_id']) !!}
{!! Form::close() !!}


Installing Canvas note generates Filename collision and exits build process

When I follow the setup and use the command:
cargo install canvas-node --git https://github.com/paritytech/canvas-node.git --tag v0.1.5 --force --locked
After a while the build process errors out with filename collision.  I've tried building it twice with same error. I'm running this on a terminal on windows 10 running WSL ubuntu 20
canvas-node.txt

@DjangoMaker Have you followed the setup from here?
There is this at the end of the log file which you posted:
the `wasm32-unknown-unknown` target may not be installed

Could you try executing
rustup component add rust-src --toolchain nightly
rustup target add wasm32-unknown-unknown --toolchain stable

before your install?

rustup component add rust-src --toolchain nightly
rustup target add wasm32-unknown-unknown --toolchain stable

before your install?
Yes, I did that before, as per install instructions I was following step by step from this page:
https://substrate.dev/substrate-contracts-workshop/#/0/setup

Looks like we are set here? If not, please let's open a new issue and reference this in:
https://github.com/substrate-developer-hub/substrate-docs/issues/


check cxxoptions

Codecov Report

Merging #8 (d0db774) into main (a25e2cc) will increase coverage by 0.02%.
The diff coverage is 68.83%.

@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
+ Coverage   45.41%   45.44%   +0.02%
==========================================
  Files         115      116       +1
  Lines       20600    20638      +38
  Branches    11225    11260      +35
==========================================
+ Hits         9356     9379      +23
- Misses       9461     9474      +13
- Partials     1783     1785       +2

Flag
Coverage Δ

buildmgr-cov
74.34% <68.83%> (-0.18%)
:arrow_down:

packchk-cov
50.52% <ø> (ø)

packgen-cov
81.72% <ø> (ø)

projmgr-cov
77.88% <ø> (ø)

svdconv-cov
24.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

tools/buildmgr/cbuild/src/CbuildLayer.cpp
76.04% <0.00%> (ø)

tools/buildmgr/cbuild/src/CbuildModel.cpp
68.15% <0.00%> (ø)

tools/buildmgr/cbuild/src/CbuildProject.cpp
41.66% <ø> (+1.54%)
:arrow_up:

tools/buildmgr/cbuildgen/src/CbuildGen.cpp
68.44% <68.44%> (ø)

tools/buildmgr/cbuild/src/CbuildMsgs.cpp
100.00% <100.00%> (ø)

tools/buildmgr/cbuildgen/src/Console.cpp
100.00% <100.00%> (+26.50%)
:arrow_up:

Codecov Report

Merging #8 (d0db774) into main (a25e2cc) will increase coverage by 0.02%.
The diff coverage is 68.83%.

@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
+ Coverage   45.41%   45.44%   +0.02%
==========================================
  Files         115      116       +1
  Lines       20600    20638      +38
  Branches    11225    11260      +35
==========================================
+ Hits         9356     9379      +23
- Misses       9461     9474      +13
- Partials     1783     1785       +2

Flag
Coverage Δ

buildmgr-cov
74.34% <68.83%> (-0.18%)
:arrow_down:

packchk-cov
50.52% <ø> (ø)

packgen-cov
81.72% <ø> (ø)

projmgr-cov
77.88% <ø> (ø)

svdconv-cov
24.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

tools/buildmgr/cbuild/src/CbuildLayer.cpp
76.04% <0.00%> (ø)

tools/buildmgr/cbuild/src/CbuildModel.cpp
68.15% <0.00%> (ø)

tools/buildmgr/cbuild/src/CbuildProject.cpp
41.66% <ø> (+1.54%)
:arrow_up:

tools/buildmgr/cbuildgen/src/CbuildGen.cpp
68.44% <68.44%> (ø)

tools/buildmgr/cbuild/src/CbuildMsgs.cpp
100.00% <100.00%> (ø)

tools/buildmgr/cbuildgen/src/Console.cpp
100.00% <100.00%> (+26.50%)
:arrow_up:

Codecov Report

Merging #8 (3adb82d) into main (a25e2cc) will increase coverage by 0.11%.
The diff coverage is 77.67%.

@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
+ Coverage   45.41%   45.53%   +0.11%
==========================================
  Files         115      116       +1
  Lines       20600    20638      +38
  Branches    11225    11261      +36
==========================================
+ Hits         9356     9398      +42
+ Misses       9461     9454       -7
- Partials     1783     1786       +3

Flag
Coverage Δ

buildmgr-cov
74.95% <77.67%> (+0.44%)
:arrow_up:

packchk-cov
50.52% <ø> (ø)

packgen-cov
81.72% <ø> (ø)

projmgr-cov
77.88% <ø> (ø)

svdconv-cov
24.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

tools/buildmgr/cbuild/src/CbuildLayer.cpp
76.04% <0.00%> (ø)

tools/buildmgr/cbuild/src/CbuildModel.cpp
68.15% <0.00%> (ø)

tools/buildmgr/cbuild/src/CbuildProject.cpp
41.66% <ø> (+1.54%)
:arrow_up:

tools/buildmgr/cbuildgen/src/CbuildGen.cpp
77.66% <77.66%> (ø)

tools/buildmgr/cbuild/src/CbuildMsgs.cpp
100.00% <100.00%> (ø)

tools/buildmgr/cbuildgen/src/Console.cpp
100.00% <100.00%> (+26.50%)
:arrow_up:


refactor: use workspace types with v1 pkg

What type of PR is this?

What this PR does / why we need it:
use workspace types with v1 pkg
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?

Additional documentation e.g., design docs, usage docs, etc.:

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

49 of 78 (62.82%)  changed or added relevant lines in 8 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.02%) to 74.611%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/engine/backend/config.go
8
10
80.0%

pkg/workspace/operator.go
5
8
62.5%

pkg/workspace/validation.go
19
23
82.61%

pkg/workspace/util.go
9
29
31.03%

Files with Coverage Reduction
New Missed Lines
%

pkg/engine/operation/watch.go
1
85.93%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
7282

Relevant Lines:
9760

💛  - Coveralls


Restrict exam, section, question IDs to match regex for valid html IDs

This is important, because otherwise an exam that uses non-hashing uuid generation could generate IDs that are invalid HTML IDs. This is a bug and manifests by causing a parsing issue.

Also student uniqnames need to be restricted.


Need for a Viable Security Scanning Tool

A security workflow does not currently exist as part of the CI/CD or security workflows in the Ruby repository. This is to satisfy the requirements as per open-telemetry/opentelemetry-specification#1333.
CodeQL is the common security scanning tool that is used currently for all of OpenTelemetry’s supported language repositories (Go, Java, Javascript, Python, C++, etc.). Since CodeQL does not offer support for Ruby, an alternative must be found. The security tool found must be able to be integrated with Github Actions.
We evaluated different possibilities but there seems to be limited available code scanning tools for Ruby that could be integrated with Github Actions. The following code scanning tools for Ruby could work:

Snyk
Codacy. This tool uses the following tools to analyze the code:

brakeman
bundler-audit
robocop
flay

We’d like to better understand the opinions from Ruby engineers on a recommended code scanning tool so that one may be added to address #144 (https://github.com/open-telemetry/oteps/issues/144).
cc @alolita @xukaren

What is the intended timeframe for this? I ask because the GitHub public roadmap has CodeQL ruby support available in Q3 of this year: https://github.com/github/roadmap/issues/136
If it's not an urgent requirement, we could delay for a month or so and see about getting into that beta. We'd align with the other languages that way.

@ahayworth lets chat with the codeql team. Let's see what their status is and see if we can get early access to the Ruby analyzer. Also I think we could extend it to use brakeman. I'll take a look and see what is possible next week.

It seems that Brakeman is specifically designed to check vulnerabilities in Ruby On Rails applications and not specifically in gems and it seems like bundler-audit may be a viable solution .
It would be nice if it integrated with CodeQL the same way that brakeman is today using SARIF output, however it looks like bundler-audit only supports text or json output. I suppose we could transform the json output to SARIF or contribute one upstream.
Thoughts?
E.g. of Brakeman/CodeQL integration:
# This workflow integrates Brakeman with GitHub's Code Scanning feature
# Brakeman is a static analysis security vulnerability scanner for Ruby on Rails applications

name: Brakeman Scan

on:
  push:
    branches: [ main ]
  pull_request:
    # The branches below must be a subset of the branches above
    branches: [ main ]
  schedule:
    - cron: '16 13 * * 6'

jobs:
  brakeman-scan:
    name: Brakeman Scan
    runs-on: ubuntu-latest
    steps:
    # Checkout the repository to the GitHub Actions runner
    - name: Checkout
      uses: actions/checkout@v2

    # Customize the ruby version depending on your needs
    - name: Setup Ruby
      uses: actions/setup-ruby@v1
      with:
        ruby-version: '2.7'

    - name: Setup Brakeman
      env:
        BRAKEMAN_VERSION: '4.10' # SARIF support is provided in Brakeman version 4.10+
      run: |
        gem install brakeman --version $BRAKEMAN_VERSION

    # Execute Brakeman CLI and generate a SARIF output with the security issues identified during the analysis
    - name: Scan
      continue-on-error: true
      run: |
        brakeman -f sarif -o output.sarif.json .

    # Upload the SARIF file generated in the previous step
    - name: Upload SARIF
      uses: github/codeql-action/upload-sarif@v1
      with:
        sarif_file: output.sarif.json

I use bundler-audit for rails projects as part of ci to just raise when there are dependencies with known CVEs.  I'm not sure how applicable its use would be here as a lot of our gems only depend on the API and the API doesn't depend on any gems.
I'm in favour of waiting for CodeQL if that's a reasonable option, it keeps us consistent with the rest of the language implementations.

@open-telemetry/ruby-approvers The CodeQL contacted me and they are offering us a private beta of the Ruby scanner.
Would you all be amenable to opting into the private beta and trying it out on this repo?

@open-telemetry/ruby-approvers The CodeQL contacted me and they are offering us a private beta of the Ruby scanner.
Would you all be amenable to opting into the private beta and trying it out on this repo?

Sure


update rxswift version

Hello @jiangmingz thank you for contributing
As you can see RxSwift', '~> 5' it is required by .podspec file, and  this error compile error displayed because of changes in Single object constructor which error changed to failure.
So I would prefere to create new release which depend on RxSwift', '~> 6' and updating .podspec file too.


feat: make custom attributes function async

Which problem is this PR solving?
In the applyCustomAttributes function, we are provided the request and response objects which each have async functions that can be used to read the response body and request body and use those to add different attributes to the spans. The problem is that this function call is not awaited in the fetch instrumentation, so there are times where the span is ended before the attributes can be added and are therefore missed.
This change will properly await the custom attributes function and will not affect synchronous usages of the function. I have also moved up the calculation of the span end time to make it more accurate to the length of time that the request took and not include the time that it took to run the custom attributes function
Fixes # (issue)
Short description of the changes

Typing applyCustomAttributes to accept an async function
Awaiting applyCustomAttributes so that it can apply attributes without worry of the span being ended
Moving calculation of end time up further in callstack to make it more accurate to the request length of time

Type of change

[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

I set up a applyCustomAttributes function that includes a 10 second timeout before returning
I ran the fetch instrumentation without these changes and got the Can not execute the operation on ended Span error in the console
I added my changes and used yalc to add the package to my setup
I ran the application again and saw the attributes being added after my ten second timeout without error

Checklist:

[x] Followed the style guidelines of this project
[x] Unit tests have been added
[x] Documentation has been updated

Sorry for the group ping, but am wondering if anyone has the time to review this one? Or if I'm missing a step in the contribution flow can someone let me know? Thanks!
cc @Flarna, @haddasbronfman, @hectorhdzg, @JamieDanielson, @martinkuba, @mwear, @naseemkullah, @MSNev, @pkanal, @svetlanabrennan, @trentm

Hmm, I think I'm missing some context on the use-case of this. :thinking:
Possibly a naive theory on my end, but I'd assume that most request's bodies will contain data that's mainly important to your application logic. If that's the data that needs to be added, wouldn't it make more sense to create a span in your application and attach the attributes there?

Thanks for taking a look @pichlermarc!
The use case for this is for when you want to add some of those attributes directly to the network span. Right now we make use of the applyCustomAttributes function to broadly add attributes to every network request that we trace in our app. Some of that includes reading the response and request body which is an async operation.
If we went the route of adding it to a span in our application then it wouldn't be directly tied to the network span that we are tracing. There's probably many ways to go about it, but to me if we're offering an interface like applyCustomAttributes that surfaces data that is received async, then just from a design perspective we should also be making the applyCustomAttributes function async to allow for that data to be used if desired

@pichlermarc any thoughts on above? ☝

If we went the route of adding it to a span in our application then it wouldn't be directly tied to the network span that we are tracing.

The network span would be the parent of the application span, and they'd be part of the same trace, so the info would be visible there, right? :thinking:

There's probably many ways to go about it, but to me if we're offering an interface like applyCustomAttributes that surfaces data that is received async, then just from a design perspective we should also be making the applyCustomAttributes function async to allow for that data to be used if desired

Yes, that's understandable. :thinking: I could be completely wrong (and I understand that my opinion on it may be controversial) but I think having all these extra functions that can be passed to instrumentation that allow users to attach span attributes were somewhat of mistake. :disappointed:
From what I can tell we're going against the grain compared to what other OTel language SIGs offer in their instrumentation and it also adds adds a lot to the effort it takes to maintain such an instrumentation.
So there's a reasonably large chance that I'm just the wrong person to review this PR as I've been always failing to see the value it brings. :sweat_smile: Maybe my fellow @open-telemetry/javascript-approvers have more insights than I do. I'll also bring it up during the SIG meeting tomorrow to see if others have an idea on where this idea originally came about - I'd be happy to change my opinion in light of new info.

So I asked around a bit what the original intent of that hook was: it's original intention was for users to be able to apply header values to their spans (which seems to be possible with the current implementation). Reading the body is generally considered to be application-specific, so we usually don't encourage doing this.
I've also reviewed other language's http-client instrumentation implementations, and in places where I found hooks to be available their stated purpose is also only to apply header values to the span.
I also read up on the semantic conventions which basically state that the span should be ended just after headers were received when reading the body of a request is optional for a library, which seems to apply to fetch.
To avoid any discrepancies, we'd therefore not await the user provided hook as it would violate the semantic conventions for HTTP client instrumentation. If data from the body is needed, we recommend creating a span in your app and attach any information there.

I also read up on the semantic conventions which basically state that the span should be ended just after headers were received when reading the body of a request is optional for a library, which seems to apply to fetch.

Agreed, based on this.

Closing this PR based on the reasons mentioned above.
As a workaround please use the other option (manually creating a span when handling the body and attaching the necessary data there) instead.

@pichlermarc thanks for getting back to me! Our usage relies heavily on the custom attributes hook so I'm a little nervous to hear that it's supported use case is really only for applying headers.
I'm interested in the thinking that adding parent/child spans can solve this issue as our use case for adding a lot of attributes to spans is for when the spans get run through our span collector and we generate metrics from it. Our implementation doesn't allow for reading from parent/child spans so all the relevant data needs to be included on the spans that represent the network calls. And since the instrumentation methods are all private there's not a lot of ways outside of this hook we have to add custom attributes to the spans created by this instrumentation.
Also in terms of timing I did make changes to make sure that the timing of the spans would not be affected by waiting. And the waiting would only apply when the passed function is async so it wouldn't have any unintended side effects to users passing in custom attributes functions today? There's already a setTimeout in the method today that prevents the span from being ended right away so I can't fully understand how this would break semantic conventions more than that?


confirm jQuery CDN is accessible to Tor clients

We have received anecdotal reports from jQuery CDN users that StackPath/Highwinds may be blocking Tor clients.
It is not uncommon for CDN providers to offer WAF protection to avoid abuse, e.g. when serving a blog open to comments, or some other kind of dynamic service with an abuse vector. I'm guessing Highwinds has a blocklist of sorts that includes IPs of customers who happen to run Tor relays at home.
I was not able to find any kind of WAF or traffic filtering rules in Highwinds StrikeTracker, nor could I find anything about it in the Highwinds StrikeTracker support pages. However, the general StackPath support pages do mention their WAF service, and indeed that offers a preset for TOR exit nodes. I'm guessing a version of this rule is implicitly turned on for Highwinds, without any ability to turn off, or at least not in a way we can control ourselves.
https://support.stackpath.com/hc/en-us/articles/360001091666-Review-and-Allowlist-CDN-WAF-IP-Blocks
Depending on the timeline for switching from StackPath Highwinds to Fastly, it might not be worth escalating with StackPath. Instead, we can make sure that post-switch we can check and make sure Fastly does not block access to jQuery CDN from home IPs that use Tor.

Ref https://github.com/jquery/codeorigin.jquery.com/issues/95, \cc @vincejv.

The https://releases.jquery.com domain and legacy https://codeorigin.jquery.com domain have been switched over to Fastly.
I don't run a Tor exit node myself, but as I understand it, merely using Tor would make my IP address (from the POV of the server) will effectively be that of the exit node part of the chain for my Tor session. As long as I pick a chain that has an exit node with an uptime of more than 10 days, that's presumably enough time for any WAF blocks to come into effect.
I tested the following URLs:

https://releases.jquery.com/jquery/
https://code.jquery.com/jquery-3.7.1.min.js
https://code.jquery.com/mobile/1.4.0/images/icons-png/eye-black.png
https://codeorigin.jquery.com/jquery-3.7.1.min.js
https://codeorigin.jquery.com/mobile/1.4.0/images/icons-png/eye-black.png

And to check the exit node and uptime, I used https://check.torproject.org/.
I tested it through three different chains. In all three cases, none of the requests timed out failed or failed in any way. Both through Fastly and through StackPath.

uptime: 8 days.
uptime: 69 days.
uptime: 43 days.

Closing for now. If anyone finds themselves blocked again for any reason, feel free to reach out by creating an issue at https://github.com/jquery/codeorigin.jquery.com/.


Change permissions on moved files before writing

I was trying to import my JC Superstar album.
beets offered my a substitution of single quotes:

I accepted and got this:
 'Music/Andrew Lloyd Webber/Jesus Christ Superstar/16 Peter\xe2\x80\x99s Denial.mp3'```

The file itself was copied to the destination is not corrupt and playable:

ls ~/Music/Andrew\ Lloyd\ Webber/Jesus\ Christ\ Superstar/ -lh
total 2.1M
-r--r--r-- 1 dimka dimka 2.1M Nov  3  2011 16 Peter’s Denial.mp3

Notice that `\xe2\x80\x99` in file name.
Googling this string pops up quite some questions on StackOverflow regarding python and single quote unicode encoding.
I know very little of python programming, so hoping some expert will find an easy fix.

My OS is Arch Linux:
Linux dimsuzhost 3.9.9-1-ARCH #1 SMP PREEMPT Wed Jul 3 22:45:16 CEST 2013 x86_64 GNU/Linux
Python 2.7.5
FS is ext4

does the new permissions plugin solve this now? or not?

Good point, @jrobeson!


GlobalItem.PreOpenVanillaBag does not prevent consuming bag items, nor does it indicate which inventory item is being opened

Description
See title.
Steps to Reproduce
See title.
Expected behavior
See title.
Actual behavior
See title.
Reproduction frequency
Always
Versions
v<IP_ADDRESS>
Mods
Any.

I'm not sure, what do you mean @hamstar0 ? It should prevent if you return false, and it indicates which item it is by the context and arg parameters.

I believe he might be referring to the lack of a 'slot' in Terraria, so if you have multiple of the same item in your inventory you don't know which one was clicked.

Exactly. Even a direct Item reference (as opposed to an inventory index) would give me something to work with...
Also,, again, the bag is consumed no matter whether one returns true or false.

K, but the documentation says "Return false to stop the default items from being dropped; returns true by default. ". I don't think preventing consumption is intended for this hook. With <IP_ADDRESS>, I believe ConsumeItem will be properly hooked up to the items and happens before PreOpenVanillaBag. Does that solve your intended use?

Actually, this was implemented in <IP_ADDRESS>, so you can use ConsumeItem for that already.

I seem to have complications using it for bags.

K, post a minimal reproducible example and we can see.

`using System.Collections.Generic;
using Terraria;
using Terraria.ID;
using Terraria.ModLoader;
namespace ConsumeItemBagFail {
class ConsumeItemBagFailMod : Mod {
public ConsumeItemBagFailMod() {
this.Properties = new ModProperties() {
Autoload = true,
AutoloadGores = true,
AutoloadSounds = true
};
}
}
class ConsumeItemBagFailItem : GlobalItem {
	public override bool ConsumeItem( Item item, Player player ) {
		if( item.Name == "Treasure Bag" ) {
			Main.NewText( "No soup for you!" );
			return false;
		}
		return base.ConsumeItem( item, player );
	}
}

class ConsumeItemBagFailPlayer : ModPlayer {
	public override void SetupStartInventory( IList<Item> items ) {
		var bag1 = new Item();
		var bag2 = new Item();
		bag1.SetDefaults( ItemID.CultistBossBag );
		bag2.SetDefaults( ItemID.EyeOfCthulhuBossBag );

		items.Add( bag1 );
		items.Add( bag2 );
	}
}

}
`

		public override bool ConsumeItem(Item item, Player player)
		{
			if (item.Name == "Treasure Bag")
			{
				// Main.NewText("No soup for you!");
				return false;
			}
			return base.ConsumeItem(item, player);
		}

		public override bool PreOpenVanillaBag(string context, Player player, int arg)
		{
			if (context == "bossBag")
			{
				Main.NewText("No soup for you!");
				return false;
			}
			return base.PreOpenVanillaBag(context, player, arg);
		}

Works for me.

Other than knowing which bag opens (I guess doable by communicating between ConsumeItem and PreOpenVanillaBag), that works, and is in fact what I've been using in Nihilism mod as my solution.

It's somewhat unintuitive, but it seems to work. Setting a flag in ConsumeItem should be fine.

As stated, it is somewhat unintuitive but it works for this scenario. I will go ahead and close this issue since the proposed solution seeems adequate.


Docker information

There doesn't appear to much information on using docker here and it seems a bit underdeveloped.  Can one of the people who are using Docker perhaps add a readme for it?
From what I gather you can make this work by overriding the entrypoint with bash or mapping to /root/Videos/Tesla_Dashcam
How are people using this after that?  Are you running a disposable container that exits after processing?  WHat variables are you inputting?

Perhaps I'm overthinking this but could we add some stuff to the wiki maybe?
Looks like you can pass variables in such as
docker run tesla_dashcam -h

I've attempted to show a README and improved version here - I'm happy to just add this as a subdirectory (the README and Dockerfile should be very minimal and shouldn't affect current operations) or I can keep on my own.
https://github.com/magicalyak/tesla_dashcam
https://hub.docker.com/r/magicalyak/tesla_dashcam

i need to test this further (just a note to self)

This should be good to test, I welcome feedback on it.  I included example configurations in the README.rst

I'll have a look at it. :-) I do not use Docker so fully dependent on others for this. :-)

Looks like you've got something going, but this is how I'm using it currently:
mv /path/to/local/TeslaCam/SavedClips/* /path/to/local/TeslaCam/ ; rm -R /path/to/local/TeslaCam/SavedClips ; mv /path/to/local/TeslaCam/SentryClips/* /path/to/local/TeslaCam/ ; rm -R /path/to/local/TeslaCam/SentryClips ; find /path/to/local/TeslaCam/ -mindepth 1 -type d -exec sh -c 'sudo docker run -it --rm -e TZ=America/Indiana/Indianapolis --network=host -v /path/to/local/TeslaCam:/TeslaCam tesla_dashcam --output /TeslaCam/$(basename $1).mp4 --rear --compression ultrafast --no-notification /TeslaCam/$(basename $2)' _ {} {} \; -exec mv {}.mp4 /path/to/local/TeslaCam\ Archive/Combined/ \; -exec mv {} /path/to/local/TeslaCam\ Archive/Raw/ \;

@ehendrix23 wanted to ask if you'd be willing to create a Dockerhub repo based on this github to have a docker image available?  It should just build off the Dockerfile in the root and default to master (but you can point to any branch as default).
I am hosting my version here (I am going to open a PR soon to update/replace the Dockerfile on yours) but the format is the same.  You just create the repo on dockerhub and point it here, it would then be  https://hub.docker.com/r/ehendrix23/tesla_dashcam and you could use it inline, for example:
docker run --rm -e TZ=America/New_York ehendrix23/tesla_dashcam -h

@3rdStng can you open a new issue on this though?  That would be the right way to do new work instead of reopening a closed issue.

Thank you @magicalyak. I was trying to get around to opening a new issue for you, but by the time I got around to it I saw you had already updated your docker image. I pulled the new update and my docker starts up just fine. (It didn't when I was manually trying to update it.) I need to get some sentry clips generated by the car to test if the issue is resolved. But thank you for the updates.


learn_app_concurrent_count inconsistent bug

learn_app_concurrent_count's increment and decrement may be not matched, which causes learn_app_concurrent_count inconsistent, and makes learning blocked:
W2018-08-15 16:42:44.772<PHONE_NUMBER>772409072 206e2) replica.replica6.0405000600000122: replica_learn.cpp:676:on_learn_reply(): 43.1@<IP_ADDRESS>:31801: on_learn_reply[0000004700000002]: learnee = <IP_ADDRESS>:31801, exceed learn_app_max_concurrent_count(5) limit, skip this round

The reason is:

some replica is learning app after increment learn_app_concurrent_count
meta server disconnected
the replica status changes to INACTIVE by replica::on_meta_server_disconnected()
but the learn_app_concurrent_count is not decrement

closed as resolved


feat: Tests/Workflows Improvements

What happened to the coverage badge of f9d9bd8?

I removed the coverage report after I saw that the reports by CodeCov differ from the ones you'd generate locally. My local report said that a class was 100% covered while CodeCov said only ~70% was covered. Since I could not get any explanation why it said it's only partially covered I decided to remove this feature again... Maybe something to look into in the future.


Fix slowness of relayer with 3+ chains and low average block time

Closes: https://github.com/informalsystems/ibc-rs/issues/1978
Description
The cause of slowness in https://github.com/informalsystems/ibc-rs/issues/1978 was that the height of the events we were pulling from the subscriptions would drift exponentially from the real latest height, because we were not pulling them from the event monitor stream fast enough.
We were trying to get an event from the stream of events (with try_recv_multiple) every 500ms.

So we get an event per chain roughly once every second.

So we were getting a NewBlock event per chain every 1.5s.
But since the block time for testing is 1s, we end up drifting behind more and more.
I guess that's why we only see this in testing and not in prod, because in prod we query often enough that we are always up to date.
The problem gets worse the lower the block time and the higher the number of chains the relayer is connected to.
To fix this, we now use a blocking recv_multiple on the subscriptions stream so that we get the events as fast as they are emitted, which solves the drift.

PR author checklist:

[ ] Added changelog entry, using unclog.
[ ] Added tests: integration (for Hermes) or unit/mock tests (for modules).
[ ] Linked to GitHub issue.
[ ] Updated code comments and documentation (e.g., docs/).

Reviewer checklist:

[ ] Reviewed Files changed in the GitHub PR explorer.
[ ] Manually tested (in case integration/unit/mock tests are absent).

Should we try also with https://github.com/informalsystems/ibc-rs/pull/1977?

I have verified that #1977 has been fixed with this PR.
I have also put a fix to correct the use of spawn_background_task. In short, the step runner given to spawn_background_task is not supposed to block forever. This is because when the TaskHandle is dropped, we want to send the shutdown signal to the task runner for it to exit the loop and terminate the task cleanly. If the step runner is blocking forever, then the shutdown signal is never handled, and so the thread join handle never return and cause a deadlock.


Cannot add extra fileds when validate_assignment is True

Bug

OS: Ubuntu Linux 18.04.2 LTS
Python version: 3.6.7
Pydantic version: 0.32

When validate_assignment option is on, adding an extra field to existing pydantic object causes KeyError:
import contextlib
import datetime
import pydantic

class ModelWithoutValidation(pydantic.BaseModel):
    name: str = None
    birthdate: datetime.date = None

    class Config:
        extra = pydantic.Extra.allow
        validate_assignment = False  # <<< !!!

obj = ModelWithoutValidation(name="Jim Smith")
obj.name = "John Doe"  # OK: Does not fail because assignment is not validated
obj.birthdate = "1983-16-11"  # OK: Does not fail because assignment is not validated
obj.fake_stuff = "asdf"  # OK: Can assign new field

class ModelWithValidation(pydantic.BaseModel):
    name: str = None
    birthdate: datetime.date = None

    class Config:
        extra = pydantic.Extra.allow
        validate_assignment = True  # <<< !!!

import pydantic; print(pydantic.VERSION)
obj = ModelWithValidation(name="Jim Smith")
obj.name = "John Doe"  # OK: Does not fail because the value is acceptable
with contextlib.suppress(pydantic.ValidationError):
    obj.birthdate = "1983-16-72"  # OK: Fails because the value is wrong
obj.fake_stuff = "asdf"
# FAIL: Cannot assign new field becaue there's no valiator
# Traceback (most recent call last):
#   File "/home/yaraslau/Projects/Dialogue/tmp/test.py", line 34, in <module>
#     obj.fake_stuff = "asdf"
#   File "pydantic/main.py", line 294, in pydantic.main.BaseModel.__setattr__
# KeyError: 'fake_stuff'

The problem is actually here: https://github.com/samuelcolvin/pydantic/blob/master/pydantic/main.py#L286
As far as I understand the failure is caused by __setattr__ trying to get the validator(s) for a non-existent field.
I guess, it should just ignore any validation for extra fields if they are not explicitly defined within the model.
P.S.: Will add a PR shortly.

Mildly related to https://github.com/samuelcolvin/pydantic/issues/515


Support rate formatters

Hello!
Thank you for this great library!
Right now, library gives no control to how :rate is actually formatted. It's pretty standard use case (it's actually used in the README) when bytes are used for total and tick values. However, the library would output rate in plain bytes, which is absolutely unpractical for end users.
I would suggest to introduce a rate formatter function, e.g.:
import prettyBytes from 'pretty-bytes';

const bar = new ProgressBar('  downloading [:bar] :rate/sec :percent :etas', {
  complete: '=',
  incomplete: ' ',
  width: 20,
  total: totalBytes,
  rateFormat: prettyBytes, // <--- using third-party formatter
});

This will output byte rate in a user-friendly fashion, e.g.: 1.56 MB/sec.
Thanks!

I couldn't really find a solution for this. As the lib seems abandoned, I decided to rewrite it.
If the people reading this in the future want to use it, my version includes this functionality
https://github.com/NathanPB/progress.js

This is a gravely needed feature. Every now and then I come across a need to display download progress, and I have to copy & paste some lines to add faux tokens to my progress bar:
data.on('data', (chunk) => {
        let curr = progress.curr + chunk.length;
        progress.tick(chunk.length, {'currM': (curr / 1000000).toFixed(2)})
    })

@NatanPB's version definitely provides an elegant way to specify these formatters and even includes a library of standard formatters. It is a bit more verbose though for the "regular" tokens and also it cannot be used as a drop-in replacement for progress in other contexts.


Created a dialog box for username input

Closes #64

@AnjaliPatle Thank you for the contribution 🔥

@DhairyaBahl  kindly add the labels🙌

@AnjaliPatle Added the labels ^_^


Add SwiftChart

A simple line and area charting library for iOS.
Project URL
https://github.com/gpbl/SwiftChart
Category
Charts
Description
A simple line and area charting library for iOS.
Why it should be included to awesome-ios (optional)
Checklist

[x] Only one project/change is in this pull request
[x] Addition in chronological order (bottom of category)
[x] Supports iOS 9 / tvOS 10 or later
[x] Supports Swift 4 or later
[x] Has a commit from less than 2 years ago
[x] Has a clear README in English

Thanks.


feat(model): use softplus, readd q to norm, simplify output

I like cleanup you did here. The change from exp(param) to softplus(param) is potentially significant, so I'll try both out before making that switch. I'm really appreciating the 2x speedup that I'm seeing on my 8-core CPU laptop.

I did a comparison of the exponential and softplus methods of ensuring non-negative parameters and the exponential performed better. I didn't explore different p_scale and q_scale values, which could change the story, but for now I've incorporated the other changes and will set this one aside.


check charset in HTML meta tags

In some cases, there is no charset in response headers, such as www.baidu.com.
so I edited the _guess_encoding method to check charset in HTML meta tags.
And in some cases, sites using 'gb2312' encoding can cause decoding errors, such as www.qq.com.
So I changed 'gb2312' and 'gbk' to 'gb18030'. The latter is the superset of the first two.

Sorry. I don't have time to write test cases now. I will add it when I have time.

We can close this..

Thanks for the heads-up!


Discussion: Missing classes and types in Microsoft.Foundation

Currently many of the WinUI classes and methods depend directly on types from Windows.Foundation. An example would be TypedEventHandler, and I am there are many other examples.
It would be more logical to eliminate this dependency on Windows by putting the types into Microsoft.Foundation. After all, the objective is to separate the UI classes from Windows.
Is it planned to make that change, or to just keep using Windows.Foundation namespace in WinUI ? If the latter then what other Windows namespaces are going to remain embedded in WinUI ?
sjb

It would be more logical to eliminate this dependency on Windows by putting the types into Microsoft.Foundation. After all, the objective is to separate the UI classes from Windows

This should be non-goal. The UI always dependents on Windows. The goal is to dependent on a fixed version of Windows with different versions of UI.

It would be more logical to eliminate this dependency on Windows by putting the types into Microsoft.Foundation. After all, the objective is to separate the UI classes from Windows

This should be non-goal. The UI always dependents on Windows. The goal is to dependent on a fixed version of Windows with different versions of UI.


Replacing usage of whitelist/blacklist

whitelist -> allowlist
blacklist -> blocklist
There are some references to these terms due to the underlying tools used. For example:

Checkov - Rules, filters
Credscan - config file
Findsecbugs - Results
bandit - Results

This issue will track the requests and comments from the underlying tools.

checkov issue - https://github.com/bridgecrewio/checkov/issues/330

There has been some traction on this with the checkov issue now resolved. The new terms allowlist and blocklist definitely sound more self-explanatory than the color codes it replaces.
There is another movement in tech to rename master branch to main. I believe this is unnecessary since the master branch is like the master copy of a tape and has nothing derogatory associated with the usage.
I'm marking this issue as closed.


If there are n or more editor declarations, the focus movement does not work normally

Declare n editors within the same component and shift the focus to the editor first.
If you click another editor without entering a value, the focus will not move.

I have exactly the same behavior in Chrome.
And this error is only visible if the editor has no content.

@andylwelch @abvas  Still can't reproduce this issue. :(
Can you show me exactly how you created the two editors?

@JiHong88
There's nothing special. Reproduce the source shown in the example URL below by inserting it locally and executing it.
The reason why you can't check the same phenomenon seems to be because of the difference in versions of different modules.
I temporarily solved the "suneditor-react" version by lowering it to 2.12.

Thanks for the reply. The issue has been opened in suneditor-react too
https://github.com/mkhstar/suneditor-react/issues/262

Hi @JiHong88 this issue is reproducible with the core suneditor package.
Demo here https://codepen.io/mkhstar/pen/YzVxbrL

The 2.43.0 version has been updated.
If this issue has not been resolved, please reopen this issue.
Thank you.


Transpiled super in method can produce invalid code where super var is shadowed in method

Problem
Input:
const s = { foo() { return 1; } };
const o = {
  foo() {
    const x = super.foo();
    let y;
    {
      const o = null;
      y = super.foo();
    }
    return x + y;
  }
};
Object.setPrototypeOf(o, s);
export default o;

Running o.foo() on original code return 2. In output code, it throws TypeError: Cannot read property 'prototype' of null.
Output:
const scopeIndex = (o$0 => [
    _o$0 => o$0 = _o$0,
    {
      foo() {
        const x = Reflect.get(Object.getPrototypeOf(o$0), 'foo', this).call(this);
        let y;
        {
          const o = null;
          y = Reflect.get(Object.getPrototypeOf(o), 'foo', this).call(this);
        }
        return x + y;
      }

    }.foo
  ])(),
  Object$0 = Object,
  index = Object$0.assign(Object$0.create({
    foo() {
      return 1;
    }
  }), {
    foo: scopeIndex[1]
  });
scopeIndex[0](index);
export default index;

Exact same problem in class methods.
Cause
Problem is that 2nd transpiled super refers to local var o rather than o$0.
Babel plugin checks that the var is not shadowed where super occurs here:
https://github.com/overlookmotel/livepack/blob/a4b3aedf71b05cd259a365d4777eef89f27216a5/lib/babel/visitor.js#L808
Problem is it only does this on first occurrence of super. In the above case, super.foo() appears twice and only the 2nd time it's shadowed.
Actually, this check shouldn't be required at all in Babel plugin. The tracker code is inserted in top scope of the function so all that matters is whether there's a var shadowing the super var name in the top scope of the function, which would prevent access to it in the tracker.
Then ensuring no var name clashes when creating the transpiled super could be dealt with during serialization.
If the method contains eval() would need to create a 2nd scope var for use in transpiled super as o cannot be renamed to scope function params.
Related to #247, #248.

Fixed in 2e4401f.


[Sampler] FlashInfer sampling func integration

This PR integrates the sampling function in FlashInfer. We integrate the one without top-p for now.

Depending on FlashInfer upstream and version bump in TVM. Marked as draft for now.


convert bulk processing scripts to use fileinput

see https://docs.python.org/3/library/fileinput.html, in particular methods like fileinput.filename(), fileinput.lineno(), etc.
this should allow us to remove the *_all.py versions of scripts; all scripts now accept any number of files or read directly from stdin. they also output a single file; no need to maintain the segmentation of the input. hopefully this will help obscure differences in segmentation between the JDSW and SBCK editions of texts.

[ ] sbck2csv (add file name as a column in output)

xml2conllu accepts a single file and thus remains unchanged.

made irrelevant by #22


Failed to install

Hello,
First of all i want to thank you for fixing this problem.
I tried to install the the code put got some errors.
Im getting a "node-gyp rebuild" error.
I have the latest version of node.js and npm installed.
Thank you!
Andreas
npm-debug.txt

I have the same issue on openSUSE Tumbleweed.
npm-debug.txt

i2c-bus build is failing. Unfortunately there is no information about the cause of i2c-bus install failing in attached npm-debug.txt. Were there more info on console when install failed? Did you see some gcc compiler errors? Could you recover some more logs of node-gyp?
Please also check the page of i2c-bus project:
https://github.com/fivdi/i2c-bus

If you're using Node.js v4 or higher and seeing lots of compile errors when installing i2c-bus, it's very likely that gcc/g++ 4.8 or higher are not installed.

Iv tried installing latest version of gcc/g++ and same problem occures.

Seems like it's a problem with your Node.js installation:
https://github.com/n-riesco/ijavascript/issues/35
I never use system versions of Node.js, because they are often broken and outdated. Yours Node.js is v4.x which is outdated too as of now. The better way to install node is using NVM:
https://github.com/creationix/nvm

Ok! So now i have deleted node.js and nvm. After installation according to the link you posted I was able to get further. screenshot is from terminal after npm i. But i dont get any multitouch. npm start shows touchpads signals i terminal.

Yes, thats what it project is about. It is about finding Magic packet to switch TouchPad into MutliTouch mode and start receiving MultiTouch signal. It is not a driver. But at this stage we have a userspace MultiTouch driver, the code is located here:
https://github.com/redmcg/FTE1001