Signature extraction failed

Hi when I try "play spaceman hardwell"
this happen
ERROR: Signature extraction failed: Traceback (most recent call last):   File "/usr/local/lib/python3.5/dist-packages/youtube_dl/extractor/youtube.py", line 1005, in _decrypt_signature     video_id, player_url, s   File "/usr/local/lib/python3.5/dist-packages/youtube_dl/extractor/youtube.py", line 932, in _extract_signature_function     cache_res = res(test_string)   File "/usr/local/lib/python3.5/dist-packages/youtube_dl/extractor/youtube.py", line 984, in <lambda>     return lambda s: initial_function([s])   File "/usr/local/lib/python3.5/dist-packages/youtube_dl/jsinterp.py", line 254, in resf     res, abort = self.interpret_statement(stmt, local_vars)   File "/usr/local/lib/python3.5/dist-packages/youtube_dl/jsinterp.py", line 55, in interpret_statement     v = self.interpret_expression(expr, local_vars, allow_recursion)   File "/usr/local/lib/python3.5/dist-packages/youtube_dl/jsinterp.py", line 174, in interpret_expression     return obj[member](argvals) KeyError: 'qC'  (caused by KeyError('qC',))

Do you have any idea?
I am not very familiar with python.

Maybe the rebuild of the docker image helped

This is a youtube_dl bug (https://github.com/rg3/youtube-dl/issues/11663) and is fixed. You need to update ytdl using our dependency update scripts:

Windows: Open update_deps.bat
Linux: Run python3.5 -m pip install --upgrade -r requirements.txt
Mac: Open update_macdeps.command in Terminal

You can also update ytdl manually using the command sudo pip install -U youtube-dl.


Support for top level JSON array?

Hello,
I'm running into a weird behavior with RSpec when writing the specs for a callback controller in our application. The goal is to have a callback endpoint for services that submit data to us on regular intervals.
This is an example of how the data is being posted to our endpoint:
[
      {
        "source_subregion": 'Oklahoma',
        "source_reach": 0,
        "source_name": 'Norman Observer',
        "source_information_type": 'news',
        "source_country_code": 'us',
        "metadata": {
          "search_name": '01) Supplier',
          "search_id": 2_727_969,
          "hook_id": 'f77ab22ba62684b35a3743ce6f41f18d800e977b'
        },
        "document_url": 'http://normanobserver.com/analysts-see-2-03-eps-for-watsco-wso-denver-investment-advisors-trimmed-agilent-technologies-a-holding/',
        "document_title": 'Analysts See $2.03 EPS for Watsco (WSO), Denver Investment Advisors Trimmed Agilent Technologies (A) Holding',
        "document_sentiment": 'neutral',
        "document_publish_date": '2017-07-19T10:26:27.937Z',
        "document_opening_text": 'Denver Investment Advisors Llc decreased Agilent Technologies Inc (A) stake by 27.36% reported in 2016Q4 SEC filing. Denver Investment...',
        "document_matched_keywords": ['A in', 'Buy', 'firm'],
        "document_language_code": 'en',
        "document_key_phrases": [
          { "relevance": 0.8547191703197672, "phrase": '” rating'},
          { "relevance": 0.8386967921058046, "phrase": 'Watsco Inc’s analysts' },
          { "relevance": 0.8232013419439597, "phrase": 'Agilent Technologies Inc' },
          { "relevance": 0.8147191703197671, "phrase": 'Buy” rating' },
          { "relevance": 0.799491900000467, "phrase": 'stock' },
          { "relevance": 0.7983554547916699, "phrase": 'shares' },
          { "relevance": 0.7959034696485439, "phrase": 'Analysts' },
          { "relevance": 0.7776051777228943, "phrase": 'Watsco Inc' },
          { "relevance": 0.6676763159365867, "phrase": 'equipment products' },
          { "relevance": 0.6430989199874523, "phrase": 'Kalmar Investments Inc De' }
        ],
        "document_image_link": 'http://normanobserver.com/wp-content/uploads/2017/07/WSO-Chart.jpg',
        "document_id": 'fThrkvtoal3MTu4-A4uNIMJppDY',
        "document_hit_sentence": '” rating. Deutsche Bank initiated the shares of A in report on Wednesday, January 18 with “Buy” rating. The firm has “Outperform” rating by',
        "document_author": 'Richard Conner'
      }
    ]

The service we work with submits a JSON array to us.
Now I am trying to make a spec for this, so I can test whether our controller is properly implemented. Yet I am struggling with submitting a top level array to the controller.
attempt 1
post :create, params: meltwater_data.to_json, headers: { 'CONTENT_TYPE' => 'application/json', 'ACCEPT' => 'application/json' }
This results in
NoMethodError: undefined method `symbolize_keys' for #<String:0x007feb2b073f00>

attempt 2
post :create, params: meltwater_data, headers: { 'CONTENT_TYPE' => 'application/json', 'ACCEPT' => 'application/json' }
This results in
NoMethodError: undefined method `symbolize_keys' for #<Array:0x007fd79daa5d80>

attempt 3
post :create, { params: meltwater_data }, { headers: { 'CONTENT_TYPE' => 'application/json', 'ACCEPT' => 'application/json' } }
This allows me to call params[:params] which returns me another ActionController::Parameters object that contains my data.
The problem I experience here however is:
request.format
=> #<Mime::Type:0x007f85b88d03e8 @synonyms=["application/xhtml+xml"], @symbol=:html, @string="text/html", @hash=3390589049612789453>

0> request.content_type
=> "application/x-www-form-urlencoded"

0> params
=> <ActionController::Parameters {"params"=>[{"document_author"=>"Richard Conner", "document_hit_sentence"=>"” rating. Deutsche Bank initiated the shares of A in report on Wednesday, January 18 with “Buy” rating. The firm has “Outperform” rating by", "document_id"=>"fThrkvtoal3MTu4-A4uNIMJppDY", "document_image_link"=>"http://normanobserver.com/wp-content/uploads/2017/07/WSO-Chart.jpg", "document_key_phrases"=>[{"phrase"=>"” rating", "relevance"=>"0.8547191703197672"}, {"phrase"=>"Watsco Inc’s analysts", "relevance"=>"0.8386967921058046"}, {"phrase"=>"Agilent Technologies Inc", "relevance"=>"0.8232013419439597"}, {"phrase"=>"Buy” rating", "relevance"=>"0.8147191703197671"}, {"phrase"=>"stock", "relevance"=>"0.799491900000467"}, {"phrase"=>"shares", "relevance"=>"0.7983554547916699"}, {"phrase"=>"Analysts", "relevance"=>"0.7959034696485439"}, {"phrase"=>"Watsco Inc", "relevance"=>"0.7776051777228943"}, {"phrase"=>"equipment products", "relevance"=>"0.6676763159365867"}, {"phrase"=>"Kalmar Investments Inc De", "relevance"=>"0.6430989199874523"}], "document_language_code"=>"en", "document_matched_keywords"=>["A in", "Buy", "firm"], "document_opening_text"=>"Denver Investment Advisors Llc decreased Agilent Technologies Inc (A) stake by 27.36% reported in 2016Q4 SEC filing. Denver Investment...", "document_publish_date"=>"2017-07-19T10:26:27.937Z", "document_sentiment"=>"neutral", "document_title"=>"Analysts See $2.03 EPS for Watsco (WSO), Denver Investment Advisors Trimmed Agilent Technologies (A) Holding", "document_url"=>"http://normanobserver.com/analysts-see-2-03-eps-for-watsco-wso-denver-investment-advisors-trimmed-agilent-technologies-a-holding/", "metadata"=>{"hook_id"=>"f77ab22ba62684b35a3743ce6f41f18d800e977b", "search_id"=>"2727969", "search_name"=>"01) Supplier"}, "source_country_code"=>"us", "source_information_type"=>"news", "source_name"=>"Norman Observer", "source_reach"=>"0", "source_subregion"=>"Oklahoma"}], "controller"=>"callbacks", "action"=>"create"} permitted: false>

0> params[:params]
=> [<ActionController::Parameters {"document_author"=>"Richard Conner", "document_hit_sentence"=>"” rating. Deutsche Bank initiated the shares of A in report on Wednesday, January 18 with “Buy” rating. The firm has “Outperform” rating by", "document_id"=>"fThrkvtoal3MTu4-A4uNIMJppDY", "document_image_link"=>"http://normanobserver.com/wp-content/uploads/2017/07/WSO-Chart.jpg", "document_key_phrases"=>[{"phrase"=>"” rating", "relevance"=>"0.8547191703197672"}, {"phrase"=>"Watsco Inc’s analysts", "relevance"=>"0.8386967921058046"}, {"phrase"=>"Agilent Technologies Inc", "relevance"=>"0.8232013419439597"}, {"phrase"=>"Buy” rating", "relevance"=>"0.8147191703197671"}, {"phrase"=>"stock", "relevance"=>"0.799491900000467"}, {"phrase"=>"shares", "relevance"=>"0.7983554547916699"}, {"phrase"=>"Analysts", "relevance"=>"0.7959034696485439"}, {"phrase"=>"Watsco Inc", "relevance"=>"0.7776051777228943"}, {"phrase"=>"equipment products", "relevance"=>"0.6676763159365867"}, {"phrase"=>"Kalmar Investments Inc De", "relevance"=>"0.6430989199874523"}], "document_language_code"=>"en", "document_matched_keywords"=>["A in", "Buy", "firm"], "document_opening_text"=>"Denver Investment Advisors Llc decreased Agilent Technologies Inc (A) stake by 27.36% reported in 2016Q4 SEC filing. Denver Investment...", "document_publish_date"=>"2017-07-19T10:26:27.937Z", "document_sentiment"=>"neutral", "document_title"=>"Analysts See $2.03 EPS for Watsco (WSO), Denver Investment Advisors Trimmed Agilent Technologies (A) Holding", "document_url"=>"http://normanobserver.com/analysts-see-2-03-eps-for-watsco-wso-denver-investment-advisors-trimmed-agilent-technologies-a-holding/", "metadata"=>{"hook_id"=>"f77ab22ba62684b35a3743ce6f41f18d800e977b", "search_id"=>"2727969", "search_name"=>"01) Supplier"}, "source_country_code"=>"us", "source_information_type"=>"news", "source_name"=>"Norman Observer", "source_reach"=>"0", "source_subregion"=>"Oklahoma"} permitted: false>]

Which is confusing. Rails seems to have properly parsed the data and stored it inside the params hash, but it doesn't flag the incoming request as proper JSON, meaning I cannot check for the correct content in my specs/controller.
I can probably work with attempt 3, but I have the feeling that something is going wrong somewhere. I expect to  be able to call my params, possibly my params[:params] and have an array with all parsed data inside of it...
Is this a communication problem between RSpec and Rails, or is this caused by the StrongParameters?
I've looked at the documentation and trying to do what it says there, but it simply doesn't seem to work.
Gems and Versions
rspec -v
RSpec 3.6
  - rspec-core 3.6.0
  - rspec-expectations 3.6.0
  - rspec-mocks 3.6.0
  - rspec-rails 3.6.0
  - rspec-support 3.6.0
rails -v
Rails 5.0.5

This is not an rspec-core issue.  Since it's an issue with rails, please ask on the rspec-rails issue tracker.

moved to https://github.com/rspec/rspec-rails/issues/1852


Add image transformation

Transformations like different geometric transformation to images like translation, rotation, affine transformation etc. These are what I will be trying to implement.

hi this is not in terms with face-x repo like there should be some implementation on faces


_multiPartFooter Returning Function Instead of String

Should _multiPartFooter be returning a Function? _multiPartHeader functions as I would expect.
Here is the printed _streams array, and you can see the function gets stringified:
_streams:    [ '----------------------------825868152491961295908473\r\nContent-Disposition: form-data; name="locations"\r\n\r\n',      '96683cc9126741d1',      [Function],      '----------------------------825868152491961295908473\r\nContent-Disposition: form-data; name="line_item_id"\r\n\r\n',      '2f5vr',      [Function] ],
https://github.com/felixge/node-form-data/blob/0.2/lib/form_data.js#L40

Can you elaborate on the issue and maybe provide some code for better understanding. Thank you.

Closing. Let me know if you have further questions.


dlite ssh and dlite tty fail to work properly on latest 2.0.0-beta7

dlite ssh just hangs indefinitely. dlite tty seems to start but cannot see that the vm is running.
$ dlite status
vm_state:       started
ip_address:     <IP_ADDRESS>
pid:            3195
id:             04323bea-9bb3-11e6-bc79-a45e60ee1a85
hostname:       local.docker
disk_size:      20
disk_path:      /Users/dkl/.dlite/disk.qcow
cpu_cores:      2
memory:         2
dns_server:     <IP_ADDRESS>
docker_version: latest
docker_args:
$ dlite ssh
^C
$ dlite tty
You may have to press enter a few times to get a login prompt
Username is 'root', password is 'dlite'
When you're finished press Ctrl+A then D to exit
Failed to get a terminal, is your virtual machine running?

tty i'm aware is broken, ssh should be working though.. are you able to ping the vm? what happens if you ssh<EMAIL_ADDRESS>

the tty command works now, i'll have a new build released today with that fix.
as for why ssh was failing, this sounds like more of a networking or vm related problem so i'm going to re-title this issue as such until we can diagnose it


WIP: Update k8s.io and sigs.k8s.io direct dependencies

What does this PR do?:
This PR help us mitigate the Rapid Reset CVE inside the devfile/library repo. It tries to update the following direct dependencies:

k8s.io/api: 0.26.1 => 0.26.10
k8s.io/apimachinery: 0.26.1 => 0.26.10
k8s.io/apimachinery: 0.26.1 => 0.26.10
k8s.io/apiextensions-apiserver: 0.26.1 => 0.26.10
k8s.io/client-go: 0.26.1 => 0.26.10
k8s.io/pod-security-admission: 0.26.1 => 0.26.10
sigs.k8s.io/controller-runtime: 0.14.4 => 0.14.7

These updates will lead to an update of the indirect dependency golang.org/x/net from v0.3.1-0.20221206200815-1e63c2f08a10 to 0.17.0.
Which issue(s) this PR fixes:

PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened and linked to this PR, if they are not in the PR scope due to various constraints.

[x] Unit/Functional tests

[x] QE Integration test

[x] Documentation (READMEs, Product Docs, Blogs, Education Modules, etc.)

[ ] Client Impact

[x] Gosec scans

How to test changes / Special notes to the reviewer:

WIP as this PR requires testing to ODC, odo. The PR uses the same versions that HAS is actually using.


Rename firewall-rules in "Control Ingress Traffic"

Resolves #1352.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Tahler
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun
Assign the PR to them by writing /assign @linsun in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/assign @vadimeisenbergibm @frankbu

Done.


is there a way to have side by side images in the html

Hi , thanks fro the great work.
I was wondering if there is a way to generate the html having some images side by side, instead of haveing a "newline" between them.
Thanks

As far as I can see from code, it doesn't add newlines/BR's explicitly:
https://github.com/dchaplinsky/visual-logging/blob/master/vlogging/__init__.py#L94
Feel free to give it a try

Hello,
indeed there are no newlines between images.
I managed to have side by side images by zooming out the browser page.
Thanks


Multi-GPU distribution support

Hello,
I'm new to iree, and just went through all tutorials and tests. I'm interested in keras model training using iree similar to keras_model_train_test.py. And I have some related questions

Do you have multigpu distribution supported?
What is 'tf' backend? Is it the only backend supported for e2e training?

Thanks for your response in advance!

Hi! Thanks for the question. There are a few things to unpack here, which could benefit from some extra documentation in the README or on our website.
For more background on our thoughts on "training" in IREE, see @stellaraccident 's comment here on our mailing list.
@rybakov recently added keras_model_train_test.py as a place for us to test and develop support for training. The "tf" backend is the full TensorFlow system (see this README). The test only runs on that backend right now, since there are missing pieces in the lowering from TF -> SavedModel -> IREE -> various IREE backends. @silvasean has also been working on triaging the issues there. (We can and should move some of those discussions onto GitHub)
As for multi-gpu, we're definitely planning on supporting heterogenous inference (e.g. CPU + GPU + TPU cooperating for a single workload) in various ways. From what I understand, IREE's core design has been set up to support those cases, but there is still substantial work across the stack to fully realize it (for example, see device placement on the roadmap, cc @benvanik). Hopefully any work there will support both heterogenous/distributed inference and training, but see Stella's comment for some of the caveats there - we expect that TensorFlow and other libraries will still be the place for the support mechanisms like file IO, tf.data, etc.

+1 to what Scott says. Training support in IREE is nascent, and the reason it is only enabled on the "tf" backend is because nothing there works on the native IREE backends yet.
In general, the mental model that may make sense to apply is that IREE exists at the lower levels of the stack where you want compilation support to help you integrate with your devices (we explicitly target smaller scale devices and deployments). For general purpose, high-end training, the new TensorFlow runtime is being designed around similar technology at the next layer up, and is likely to be the entrypoint for people wanting to run more classic distributed training workloads. Neither IREE nor TFRT are ready for real users yet (unless if you are looking to contribute and are ok with the bleeding edge).
At an appropriate time, we will likely layer IREE under TFRT as a gateway to more standard ML workloads/users. In such a scenario, IREE will continue to directly serve people who want to do controlled deployments with AOT compilation to supported CPU and GPU targets, but it is not trying to be a solution for everyone (and will integrate with the other parts of the ecosystem to meet people with higher level use cases).

(hope that helped, feel free to ask more questions or reopen if you want to talk more about these topics!)


Fix triplicated content-type headers on gql_dio_link

I've fixed an issue with the package that was adding twice the content-type header, thus causing the request to fail for graphql.
There's a discussion here for further details:
https://github.com/TarekkMA/gql_dio_link/issues/4

I think you can merge now.
Thanks for the PR.

I think you can merge now.

@TarekkMA I think I don't have permissions to merge here XD
Not sure who could merge it tho


Airflow xxxx GitHub actions2

Issue link: WILL BE INSERTED BY boring-cyborg

[ ] Description above provides context of the change
[ ] Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
[ ] Unit tests coverage for changes (not needed for documentation changes)
[ ] Commits follow "How to write a good git commit message"
[ ] Relevant documentation is updated including usage instructions.
[ ] I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@70af358). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #585   +/-   ##
=========================================
  Coverage          ?   85.07%
=========================================
  Files             ?      683
  Lines             ?    39152
  Branches          ?        0
=========================================
  Hits              ?    33308
  Misses            ?     5844
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70af358...36c6bed. Read the comment docs.


Add code coverage badge to README

Coverage remained the same at 60.798% when pulling 858c4eb8089236895f397b1d94cfa30f1f7fbcc6 on seils:coverage-badge into 0579b2935c555a9763b3d93be2ce2f0f8ccb7423 on Netflix:master.


Add unused import check in to if and foreach

Purpose
This will fix the unused import search not looking in if and foreach.
Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

@SupunS  Will send another PR for this... for now will close this.


Rework --compile and add a seperate --build option

This issue addresses #254 (and #273).
Changes
In the Runner we now have two methods, build just for building an executable and eval for then evaluating (running) said executable. Furthermore, we now have one new flag in addition to the --compile flag, which also has been reworked.

The --build flag builds executables when selecting certain backends (LLVM and MLton) instead of only outputting the transpiled code. This option overwrites the --compile option, as the transpiled code is needed for building.
The --compile flag only outputs (saves) the transpiled code.

Discussion
I am not quite sure how to handle the ChezScheme and JS backend in terms of "building" an executable. Prepending a shebang (#!/usr/bin/env node ...) only works on UNIX systems. Furthermore, this would require more drastic changes to the current implementation, as I would need to edit the pretty-printed output of Compiler.compile in the respective runner, which is currently not available in the Runner.

Thanks, as for the discussion: I am not sure whether you would need to edit the pretty printed output. It should suffice to prefix it. I think for the JS backend, it would be enough to output a script next to the compiled result (maybe called like a binary would) that contains a shebang and the require(...).main().run() boilerplate.
For Chez, there is an option to create a binary that does WPO and bundles the interpreter. Maybe this one helps: https://github.com/gwatt/chez-exe/blob/master/compile-chez-program.ss

However, I think for the JS backend, it would be enough to output a script next to the compiled result (maybe called like a binary would) that contains a shebang and the require(...).main().run() boilerplate.

Good idea! I will do just that.

For Chez, there is an option to create a binary that does WPO and bundles the interpreter. Maybe this one helps: https://github.com/gwatt/chez-exe/blob/master/compile-chez-program.ss

It seems to be using the compile-whole-program function which does not output a binary but some object file which can be executed by the scheme interpreter just like an .ss file. The actual process of turning that into a standalone executable is a bit more elaborate and goes beyond just executing a reasonable amount of commands in the build function but rather embedding in it custom C code.

I haven't tested it, but I thought the idea of the chez-exe project is that we could just reuse their implementation and run one chez command?

I thought there was a way to automatically generate a binary that also bundles petit, see https://cisco.github.io/ChezScheme/csug9.5/use.html#./use:h8

I thought there was a way to automatically generate a binary that also bundles petit, see https://cisco.github.io/ChezScheme/csug9.5/use.html#./use:h8

Unless I am missing something, it is not possible to create a single standalone binary. See this part of the link you posted:

Here is how we might create and run a simple "echo" application from a Linux shell:
echo '(suppress-greeting #t)' > myecho.ss
echo '(scheme-start (lambda fns (printf "~{~a~^ ~}\n" fns)))' >> myecho.ss
echo '(compile-file "myecho.ss")
(make-boot-file "myecho.boot" (quote ("petite")) "myecho.so")'
| scheme -q
scheme -b myecho.boot hello world
If we take the extra step of installing a copy of the Petite Chez Scheme executable as myecho and copying myecho.boot into the same directory as petite.boot (or set SCHEMEHEAPDIRS to include the directory containing myecho.boot), we can simply invoke myecho to run our echo application

Tldr: Using this approach, you can only compile a .boot file from a .ss file and then have a copy of the petite named like the .boot file besides it.
Therefore, it is only up to discussion if

We simply want to output a simple bash script (with a shebang) calling the scheme interpreter with the transpiled .ss file.
Use the aforementioned chez-exe project to create a real standalone binary. With this approach, however, the user has to have yet another program installed in their environment.

I think it would also suffice to do something similar to the JS solution: compile the ss scheme as much as possible using the documented process. Then put a bash script next to it that just starts it.

Ideally, we would have some CI to check whether a binary can be created for each backend using build. However, running the backend specific tests probably already covers this?

Yes, it does. However, only for the platform we run the CI on. So only Linux (Ubuntu) if I am not mistaken. It also "runs on my system" (OSX). Windows will probably be problematic, though.

Looks good to me! Feel free to merge (if you have the permission, otherwise I'll do it).

Hm looks like I do not have permission. I'll just message you when I have implemented your proposed changes and it's ready.

Windows will probably be problematic, though

Yeah, that's annoying to setup and maintain.

Thanks @dvdvgt!


Hosting data for example scripts

During the hackathon we decided to put the phantom data for the example scripts into a single zenodo DOI / dataset (or maybe split it into 2 datasets; one for siemens sequences and one for pulseq sequences).
However, I would suggest that we create one zenodo DOI / dataset for each example script. Maybe I'm just incapable, but when trying to add the seq-files for the pulseq .h5 files, I accidentally deleted all the available ISMRMRD files. Not sure if there is an option to simply ADD new files or if a new version of a dataset always requires to upload all files again, which is very error prone because you can easily forget a file...
Furthermore, using separate DOIs / datasets for the individual example scripts would allow to switch back to using zenodo_get() instead of `requests.get()', which is more cumbersome imo (we need to create a tmp file, create the request, write the data) and is also susceptible to timeouts (at least at PTB).
Maybe simply react with 👍 if you agree to switch to separate DOIs for each example script.

I think it is a good idea to have smaller "chunks" of data with their own DOI but I am not sure that we can that easily separate data between notebooks. It is more likely that we will partially reuse data for different notebooks. If each file has its own DOI then things might become quite messy.
In the short term I would simply use !curl filename url to download individual files from a zenodo dataset. In the long term I think we will need a separate example_utils.py where we can collect general functions for downloading, viewing... the data needed by all notebooks.

I still get a bit annoyed by tests randomy failing due to zenodo.
what about using LFS and the public PTB gitlab?
https://docs.gitlab.com/ee/topics/git/lfs/
So creating a repository for the example data, enabling LFS, and storing the data there?
It seems like LFS is installed in our instance (at least there is a toggle to disable it, I have not tested if it actually works...)


[Suggestion] Prevent named items from being used in recipes

There are a few recipes that use items that you might have enchanted, like bows. It would be nice to stop your main bow from being crafted into a dispenser, for instance.

I have no clue how to implement that but the idea is good so i'll try to add it.


How to properly do List right after Update/Create

Type of question

General operator-related help

Question
What did you do?

I'm currently trying to add Update request handling for my cluster. Say I have a StatefulSet which has several pods and one of my application is deployed in each of them. Now I want to handle an Update request that want more pods in this StatefulSet. What I want to do in my Reconcile() is first change the size of my StatefulSet (using r.Client.Update(ctx, sts)), then right after that I want to list all the newly created pods (using r.Client.List(ctx, podList, listOpts...) with my selector) and do custom configuration for my application in each of them.
The problem is the interval between these two operations is so small, that maybe the new pods are not yet created or maybe the read cache in r.Client doesn't get a chance to flush before I do List(). As a result, I'm not able to get the new pods and perform my configuration. So, how do you make sure that the List right after Update can get me the proper results? Is there anyway I can perform a "sync" before calling List()?
What did you expect to see?

A List() call right after Update() can give me all the newly created pods.
What did you see instead? Under which circumstances?

A List() call right after Update() is not able to give me the proper results.
Possible Solutions

Sleep for a (few) second(s) before calling List(). Not a robust solution.

Do Requeue after Update(). Need to refactor a huge part of my code. And, does it make sure I can get the newly created pods, if so, how does it do it?

Environment
Operator type:

/language go

$ operator-sdk version

operator-sdk version: "v1.0.0", commit: "d7d5e0cd6cf5468bb66e0849f08fda5bf557f4fa", kubernetes version: "v1.18.2", go version: "go1.13.11 linux/amd64", GOOS: "linux", GOARCH: "amd64"
$ go version (if language is Go)

go version go1.14 linux/amd64
$ kubectl version

Client Version: version.Info{Major:"1", Minor:"14+", GitVersion:"v1.14.10-tk8s.1", GitCommit:"b050d81c44c53f0eeb2a72142ca2e9d6d46ee6fa", GitTreeState:"clean", BuildDate:"2020-04-23T13:23:39Z", GoVersion:"go1.12.9", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"14+", GitVersion:"v1.14.10-tk8s.1", GitCommit:"b050d81c44c53f0eeb2a72142ca2e9d6d46ee6fa", GitTreeState:"clean", BuildDate:"2020-04-23T13:23:39Z", GoVersion:"go1.12.9", Compiler:"gc", Platform:"linux/amd64"}

The idea behind a reconcile loop is to take advantage of Kubernetes' eventual consistency concept, meaning that eventually the state of the system (cluster) will look how you want it to after you apply some changes. On each run of your controller's Reconcile() method, your operator is effectively checking if the state of the cluster is what you programmed it to look like; if it doesn't, it will eventually (assuming there are no issues external to your operator or bugs in your operator's code), so continue checking cluster state.
Effectively: you should never be blocking within Reconcile(), and instead should be requeuing when you don't get the results you want from List().
Hopefully this explanation helps!
/triage support

The idea behind a reconcile loop is to take advantage of Kubernetes' eventual consistency concept, meaning that eventually the state of the system (cluster) will look how you want it to after you apply some changes. On each run of your controller's Reconcile() method, your operator is effectively checking if the state of the cluster is what you programmed it to look like; if it doesn't, it will eventually (assuming there are no issues external to your operator or bugs in your operator's code), so continue checking cluster state.
Effectively: you should never be blocking within Reconcile(), and instead should be requeuing when you don't get the results you want from List().
Hopefully this explanation helps!
/triage support

Thank you for your reply!
Now I think understand the logic behind requeuing. It's like dividing my operation into different stages, before moving on to the next stage (i.e. configure the new pods), I should check if the current stage is satisfied (i.e. new pods are already created), and requeue if it is not, until it is ready for the next stage.
The only problem here though is, since my applications in the cluster are highly complicated and involve many steps of configuration, to divide them and allow requeuing means I need to add tons of stage checks (if-elsees). I guess that's the pain I have to undergo then XD.

Hi @GreaTdANie1,
Just to supplement the info provided already.
The reconcile solution ought to be idempotent which means that it will be looking for the state in the cluster in order to have the desired state at the end.
See that, the reconcile function is responsible for synchronizing the resources and their specifications according to the business logic implemented on them. In this way, it works like a loop, and it does not stop until all conditionals match its implementation. The following is pseudo-code with an example that clarifies it.
reconcile App {

   // Check if a Deployment for the app exists, if not create one
   // If has an error, then go to the beginning of the reconcile
   if err != nil {
       return reconcile.Result{}, err
   }

   // Check if a Service for the app exists, if not create one
   // If has an error, then go to the beginning of the reconcile
   if err != nil {
       return reconcile.Result{}, err
   }

   // Looking for Database CR/CRD
   // Check the Database Deployments Replicas size
   // If deployment.replicas size != cr.size, then update it
   // Then, go to the beginning of the reconcile
   if err != nil {
       return reconcile.Result{Requeue: true}, nil
   }
   ...

   // If it is at the end of the loop, then:
   // All was done successfully and the reconcile can stop
   return reconcile.Result{}, nil

}

The following are a few possible return options to restart the Reconcile:

With the error:

return ctrl.Result{}, err

Without an error:

return ctrl.Result{Requeue: true}, nil

Therefore, to stop the Reconcile, use:

return ctrl.Result{}, nil

Reconcile again after X time:

return ctrl.Result{RequeueAfter: nextRun.Sub(r.Now())}, nil

Note: For more details, check the Reconcile and its Reconcile godoc. The changes proposed in https://github.com/operator-framework/operator-sdk/pull/4021, which might help you better get its idea.
However, shows that your question is answered so I am closing this one. However, please, feel free to ping us and/or raise new issues.


CI flakiness issues

Summary
Over the last few weeks I've noticed an increase in flakiness when running PR tests. Typically the tests pass again after being re-run. We should look into why these tests are flaky and fix it if possible
Issue 1
# Host config
  bazelisk test --local_test_jobs=1 -- //... -//tests/ios/...

  # `deleted_packages` is needed below in order to override the value of the .bazelrc file
  bazelisk test --local_test_jobs=1 --apple_platform_type=ios --deleted_packages='' -- //tests/ios/...
  shell: /bin/bash -e {0}
2022/08/17 17:[3](https://github.com/bazel-ios/rules_ios/runs/7884302805?check_suite_focus=true#step:4:3)0:30 Downloading https://releases.bazel.build/5.0.0/release/bazel-5.0.0-darwin-x86_6[4](https://github.com/bazel-ios/rules_ios/runs/7884302805?check_suite_focus=true#step:4:4)...
Extracting Bazel installation...
Starting local Bazel server and connecting to it...
Loading:
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 26 packages loaded
    currently loading: tests/ios/frameworks/dynamic/c ... (2 packages)
Loading: 34 packages loaded
    currently loading: tests/ios/lldb/app ... (2 packages)
Loading: 70 packages loaded
    currently loading: tests/ios/lldb/app ... (4 packages)
Loading: 70 packages loaded
    currently loading: tests/ios/lldb/app ... (4 packages)
Analyzing: 194 targets (74 packages loaded, 0 targets configured)
Analyzing: 194 targets (87 packages loaded, 317 targets configured)
Analyzing: 194 targets (88 packages loaded, 317 targets configured)
Analyzing: 194 targets (89 packages loaded, 322 targets configured)
Analyzing: 194 targets (89 packages loaded, 322 targets configured)
Analyzing: 194 targets (110 packages loaded, 34[5](https://github.com/bazel-ios/rules_ios/runs/7884302805?check_suite_focus=true#step:4:5) targets configured)
Analyzing: 194 targets (134 packages loaded, 730 targets configured)
Analyzing: 194 targets (135 packages loaded, 730 targets configured)
Analyzing: 194 targets (135 packages loaded, 730 targets configured)
Analyzing: 194 targets (135 packages loaded, 730 targets configured)
Analyzing: 194 targets (135 packages loaded, 730 targets configured)
DEBUG: /Users/runner/work/rules_ios/rules_ios/rules/library/xcconfig.bzl:21:12: CLANG_TRIVIAL_AUTO_VAR_INIT: "unknown" not a valid value, must be one of ["uninitialized", "pattern"]
Analyzing: 194 targets (145 packages loaded, 5738 targets configured)
Analyzing: 194 targets (145 packages loaded, 5738 targets configured)
Analyzing: 194 targets (145 packages loaded, 5738 targets configured)
ERROR: /private/var/tmp/_bazel_runner/c2342bca25[6](https://github.com/bazel-ios/rules_ios/runs/7884302805?check_suite_focus=true#step:4:6)9556[7](https://github.com/bazel-ios/rules_ios/runs/7884302805?check_suite_focus=true#step:4:7)c[8](https://github.com/bazel-ios/rules_ios/runs/7884302805?check_suite_focus=true#step:4:9)c3f3be166b56b3/external/bazel_tools/tools/cpp/BUILD:57:1[9](https://github.com/bazel-ios/rules_ios/runs/7884302805?check_suite_focus=true#step:4:10): Target '@bazel_tools//tools/cpp:current_cc_toolchain' depends on toolchain '@local_config_cc//:cc-compiler-darwin', which cannot be found: error loading package '@local_config_cc//': cannot load '@local_config_cc_toolchains//:osx_archs.bzl': no such file'
ERROR: Analysis of target '//tests/framework/platforms:framework_deps_macos_[10](https://github.com/bazel-ios/rules_ios/runs/7884302805?check_suite_focus=true#step:4:11)1000' failed; build aborted:
INFO: Elapsed time: 265.202s
INFO: 0 processes.
FAILED: Build did NOT complete successfully ([14](https://github.com/bazel-ios/rules_ios/runs/7884302805?check_suite_focus=true#step:4:15)5 packages loaded, 57[38](https://github.com/bazel-ios/rules_ios/runs/7884302805?check_suite_focus=true#step:4:39) targets configured)
ERROR: Couldn't start the build. Unable to run tests
FAILED: Build did NOT complete successfully (1[45](https://github.com/bazel-ios/rules_ios/runs/7884302805?check_suite_focus=true#step:4:46) packages loaded, 5738 targets configured)
Error: Process completed with exit code 1.

Majority of flaky failures seem to be related to:
Target '@bazel_tools//tools/cpp:current_cc_toolchain' depends on toolchain '@local_config_cc//:cc-compiler-darwin', which cannot be found: error loading package '@local_config_cc//': cannot load '@local_config_cc_toolchains//:osx_archs.bzl': no such file'

More info: https://github.com/bazelbuild/bazel/issues/14603

Looks like the fix for the osx_toolchain issue is to update to Bazel 6.0.0

@luispadron 💯 I've seen similar longstanding Bazel flake - e.g. over 6 years where these config rules failed under host CPU resource contention. The ones you linked are also here:
https://github.com/bazel-ios/rules_ios/issues/329
https://github.com/bazel-ios/rules_ios/issues/361
If it continues without fix, I'd propose to quickly add back a vendorized toolchains - to side-step the flake until someone addresses it

Oh wow its been around for a while the. The issue i linked, links out to a patch made to Bazel to fix this but i cant find the commit Bazels change logs 🤔.
From the PR it looks like it should've made it to one of the 6.0 tags though so whenever that gets released we could possibly update. Would we want to use the rolling 6.0 releases on this repo at all? I see rules_apple does this

This had just sat in code review - maybe we should re-open it: https://github.com/bazelbuild/bazel/pull/14328

Yeah - I also think it'd be reasonable to temporarily vendorize and iterate on a the autoconfig repo rule in rules_ios with the intention to upstream them back longer term

CI is less flaky now


Half-shaft cogwheels not connecting to shafts

From this image you can see that the left one connected fine, but the right one did not.

They always favor south, east, and up, and won't face the shaft north, west or down.
They should always to to favor the shaft they are being placed on, and the wrench should be able to turn them in all directions, not half of them.
Mod version: 2.0.2-1.19.2-0.5.0i-forge

Found a temporary workaround (and another related bug): if the half-shaft cogs are placed against another cog then the sidedness is flipped; they will always face north, west or down, not being able to wrench them south, east and up.

Just noticed that this repo is for the flywheels mod, not the cogwheels. The link on the cogwheels curseforge page points to this repo, and should be corrected.


update make clean to remove coverage.out

/cc @jeremyje

/sig windows
/sig node
/ok-to-test
/lgtm
/approval
/priority important-soon

I forgot add coverage.out to .gitignore as well.

/hold
Add .gitignore and then remove the hold.

/lgtm
/approve

/unhold

/lgtm
/approve


Support DateTime as filter

It would be extremely useful to support DateTime objects in the filters expression when viewing messages.  We would like to view, for instance, message with EnqueuedTimeUtc between dates A and B.

@lonevvolf sounds like a good idea. Would you want to take a stab at it?

I will see if we can allocate some time to it in our project.


Print on sunmi t2 (InnerPrinter) problem

Hi,
Thanks for your package. I use a Sunmi T2 Terminal with a virtual bluethooth (INNERPRINTER).
When I print a ticket, a 'V0' caracter is write at each lines. Another problem when the ticket is finished, the printer cut 2 times at the end.
Thanks for your help

Hi,
I also use Sunmi device (Sunmi V2), I've created a separate package for it: flutter_sunmi_printer. I'm not sure if it's compatible but you could try


@chunk and reltable

Since the chunk task is executed after the mapref, the exploded topics (<topciref chunk="by-topic" href="..."/>) are excluded from reltable processing. So none of them can have related links section generated from ditamap. And they cannot be included into other topics related links.
Is this the expected behavior?

Could you add a very simple test case to reproduce this?

Sure. Sorry for not having done this before.
test.tar.gz


[WIP] sensu-check code as document

use aodh role as example for review first:

all check definition move to sensu-check/default/main.yml
install role related sensu-check by role dependency on role
'sensu-check' with attribute 'sensu_check_role'
existing monitoring playbook can be removed.

Can one of the admins verify this patch?

"ok to test" to accept this pull request for testing
"test this please" for a one time test run
"add to whitelist" to add the author to the whitelist

I still want each role to install its own checks.  The purpose of the sensu-checks role is to have a central dictionary of the checks and to do any directory creations required.   see how sitecontroller does it - https://github.ibm.com/bluebox/sitecontroller/tree/master/roles/sensu-check

I agree that each should role should install it's own checks and that we should mimic the SiteController approach and use the sensu-checks dict for all checks (if possible).
This will allow operators to override check settings per customer but still allow Developer and Operator to inspect monitoring within the role.

@paulczar @scoop206 please review again.
use aodh/ceilometer/common role as example for review:

all check definition move to role sensu-check, which include
-- sensu check definition
-- existing role monitoring-common's definition
-- each role's monitoring related definition, like criticality

each role include sensu-check's monitoring playbook with variables.

both sensu_check_dict and sensu_metrics_check support ucarp_node_only
Another reason for VIP is better choice is: VIP works for non-HA deployment too.

closing all PRs with no recent activity.


chore: Add PULL_REQUEST_TEMPLATE.md

:tada: This PR is included in version 1.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


MINOR: [C++] Add mising pragma-once

Rationale for this change
The C compilation model.
What changes are included in this PR?
Adding a #pragma once that I forgot to add when I created this header.
Are these changes tested?
N/A.

CI failures are unrelated. @westonpace @pitrou can it be merged?

Hi @felipecrv , I see this is tagged as 12.0.1 but doesn't have an associated issue. Our cherry-pick scripts can't pick issues for minor releases automatically if there is no a linked GitHub issue. I can cherry-pick this manually but is this required?

@raulcd I don't think this is required if it doesn't fix any breakage.


Roll Flutter Engine from 65d1291c3add to ddb3b354a30b (2 revisions)

https://github.com/flutter/engine/compare/65d1291c3add...ddb3b354a30b
2024-01-26<EMAIL_ADDRESS>Roll Dart SDK from 5636e338e0b9 to 7337995bc851 (1 revision) (flutter/engine#50087)
2024-01-26<EMAIL_ADDRESS>Fix Shell::Screenshot for Impeller (flutter/engine#50072)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Group icons with a NRK TV specific look

Ever since core-icons was last updated, I have been thinking about the style influenced by the new NRK TV design. And I am not convinced that change was a good idea.
To me, the success of an icon set is all about a consistent style, combined with clear, easy to understand shapes and symbols. This isn't the case with some of the redesigned icons.
 It took a surprising amount of time before I realised this was the play button inside NRK Radio.
My main issue is with the new play icon, but I believe other icons have become less obvious as well. I do understand the need for NRK to strengthen the NRK TV brand, but I have serious doubts that the new icon style is solving this problem. And I can't see how the change is possible to measure in any meaningful way. As Luke Wroblewski puts it, obvious always wins. My two cent.
As an attempt to please everyone, I suggest keeping these icons as an alternate style that NRK TV can apply to their product, and bring back other icons as a more neutral style that suits other products better.
I also suggest that we do another review of our icons, to ensure that they share a clear and consistent style across the whole set.

Is the problem really grouping, or the play-button? :)
I think the current grouping (including media) is very good, but as stated before - maybe the play-icon itself can be a bit problematic (ref. https://nrk.workplace.com/groups/1441367842612360/permalink/2466291940119940/)

The main issue is certainly, but not limited to, the play icon.
I believe all these icons should be the alternate version, not the main:

nrk-media-play
nrk-media-play--fail
nrk-media-ffw
nrk-media-rwd
nrk-media-next
nrk-media-previous
nrk-broadcast
nrk-heart
nrk-heart--active
nrk-latest-news
nrk-latest-news--active
nrk-search
nrk-search--active

There is something about the angles and line endings that doesn't fit with the rest of the icons.
Grouping probably isn't the right way to describe what I am looking for, so I've updated the title to better reflect my issue.

Sounds like a continuation of the discussion here https://app.slack.com/client/T04MCF2QC/C0C4KG11N/thread/C0C4KG11N-1568294395.040400 before resolving as a issue with redesign in the repo? :)


heading style not working as expected in sharpen

Expected vs Actual

<sharpen-alert type="warning" icon="warning" heading="Action Needed">

Please complete Gunther's profile by filling in the Date of Birth, the Kindergarten Start Year, and Opting in or out of the Sharpen Research Program.

</sharpen-alert>

PS. ignore the icon we can change that with alert but the heading style

@deepakmahakale We don't see this in Storybook, so you probably have another style definition from outside Kezuri that's cascading and styling this text. When you inspect the "Action Needed" element, what are all the styles that get listed?

Out of the box, it should look quite close to the original:

I'll close this as invalid but we can open a new issue if we notice problems after removing Craft.


Password validation not working. (2.0.5)

I'm not sure what the cause is, but this is happening even though the passwords match.
![Semantic UI bug]
(https://dl.dropboxusercontent.com/u/27714141/semantic-bug.png)
This is the code for my form:
setupForm() {
    var minPasswordLength = 6;
    $(React.findDOMNode(this)).form('destroy');
    $(React.findDOMNode(this)).form({
      fields: {
        firstName: {
          identifier: 'firstName',
          rules: [
            {
              type: 'empty',
              prompt: this.app.translate('Auth.EmptyFirstNameWarning')
            }
          ]
        },
        lastName: {
          identifier: 'lastName',
          rules: [
            {
              type: 'empty',
              prompt: this.app.translate('Auth.EmptyLastNameWarning')
            }
          ]
        },
        email: {
          identifier: 'email',
          rules: [
            {
              type: 'email',
              prompt: this.app.translate('Auth.InvalidEmailWarning')
            }
          ]
        },
        password: {
          identifier: 'password',
          rules: [
            {
              type: 'length[' + minPasswordLength + ']',
              prompt: this.app.translate('Auth.PasswordTooShortWarning', { length: minPasswordLength })
            }
          ]
        },
        passwordConfirm: {
          identifier: 'passwordConfirm',
          rules: [
            {
              type: 'match[password]',
              prompt: this.app.translate('Auth.MismatchedPasswordWarning')
            }
          ]
        },
        agreeToTerms: {
          identifier: 'agreeToTerms',
          rules: [
            {
              type: 'checked',
              prompt: this.app.translate('Auth.MustAgreeToTerms')
            }
          ]
        }
      },
      inline: true,
      onSuccess: this.submit.bind(this)
    });
  }

I ran into the same issue in version 2.0.4 after upgrading from 2.0.3. Rolled back to 2.0.3 and the validation worked again. Likely a bug introduced in 2.0.4

@sinning @voodooattack
Can you provide the HTML with that example, or an example. You can fork the JSFiddle in readme.
I'd like to get this patched today.

Here: https://jsfiddle.net/cm2dtoLu/2/

I'm confused, i tried a 6 letter password in both password and password confirm and no error message shows.

Try with the passwords 'asdfasdf' or 'testtest'.

Ohhhh. Yeah... i see..
Fixed fiddle
https://jsfiddle.net/vmpLeymu/
So the issue is really simple. In 2.0.4 I fixed all the validation rules. Previously length was operating as minLength even though it was suppose to be "exact length". But now there are three separate validations, minLength, length, and maxLength
It's kind of a sophie's choice because although the rule was previously named incorrectly people are already using it in code, so modifying its functionality is breaking peoples code. However people who are expecting length to operate as exactLength will have issues.
I think the safest way is to make minLength and length both work the same (to avoid issues with updates breaking changes), and add exactLength

Thank you for clarifying that! However, I just tried with minLength and it still says that passwords do not match (for 'asdfasdf').

I copy and pasted "asdfasdf" into both fields in
https://jsfiddle.net/vmpLeymu/
No validation errors were added.
Can you confirm that you are using the same fiddle? If you still have issues, what OS/Browser.

https://github.com/Semantic-Org/Semantic-UI-Docs/commit/62ba9ccaf56cac064331b7ee0416f91bb12b91de

Thanks for helping out with this. Sore spot.

You're welcome. I'm glad it's resolved. It looks like the bug isn't happening in the fiddle but still happens in my project. I'll see if I can find out anything.

Here's another example:
https://jsfiddle.net/sinning/dhm4jo0s/1/
Type in sdfsdfsdfsdfs into username or password :)

Again you are using length and not minLength.

Hello, i'm going to write my question here even though i don't experience that particular problem.
@jlukic i see that @voodooattack used some kind of translation for the prompts error messages:

Hello again, i came back, this time with some kind of bug ( i think ) regarding password confirmation.
The validation works fine with one form, but in my situation i have a login modal, which is placed somewhere in the background. So, it is also available on the registration page. And i think there is a conflict between the 2 password fields of each form.
Here is a fiddle as example.
https://jsfiddle.net/wnxjx29e/
If i try to register first, the password validation will fail. If i play around with the login form, or just pop the modal, and then come back to register, it works.
Am i missing something? Thanks

@badeamihai thanks for your comment, it helped me as I was in the same situation : I had 2 fields in differents forms with same id. Making the ids unique solved the issue (they should be as per HTML spec anyway)

guys, i think i found it, if you have password field then password_confirmation field, then put the match rule to password field


Detected by youtube

Starting yesterday, YouTube detected my adskipper, and then today I updated my extension to latest version but nothing changed. I also screenshot the errors shown in Developer Mode, not sure it will help or not.

Thanks a lot for the report, it is really helpful.
You don't have any other adblocking extension installed?

Yes I do have other adblock extension installed, but I disabled all adblock except adskipper when using youtube.

What AdSkipper version are you using?

updated to 2.8.8 version. But the issue persists.

I see. Could you do this

Remove AdSkipper fully
Go to youtube and pay few videos to see if the issue still persists

If it does, then some other extension is causing the issue. I've seen some cases on reddit here youtube detected that adblocker was installed even tho it was disabled.

I removed all Adblock on Chrome, but the issue persists. However, I tried the same thing on Microsoft Edge, and Adskipper worked. I'm not sure if it is related to the Eset anti-virus extension on Chrome because I didn't install this extension on Edge. Thank you!

It could be related to that extension. I will close this issue for now but please feel free to open another issue if you encounter any problems.
Thank you so much for helping


Add IREE_SAVE_CALLS to tflite_text_classification notebook.

Recording a trace is useful when when the next step after running the notebook may be to download its outputs and work with them locally.
Relates to https://github.com/google/iree/issues/6688

This PR is stale, closing. Might fold a similar change into the next Colab notebook updates.


Static file with UTF-8 characters can not be served from ubuntu 18.04 with UTF-8 system encoding.

Expected Behavior
Static file from under static path should be served if it has UTF-8 encoded characters in its name.
I'm running Flask in combination with Gunicorn. Although my ubuntu system encoding is UTF-8 it doesn't seem to behave correctly.
# simple file name:
42%C3%A9.jpg

Actual Behavior
I get a 404 status code
Environment

Python version: 3.6.8
Flask version: 1.0.2
Werkzeug version: 0.14.1

Does this happen with the latest versions of Flask and Werkzeug?

Yes, updating flask to v1.1.1 and werkzeug to v0.16.0 doesn't affect the behaviour


[AutoRelease] t2-appcontainers-2022-09-23-62388(Do not merge)

https://github.com/Azure/sdk-release-request/issues/2985
Live test success
https://dev.azure.com/azure-sdk/internal/_build?definitionId=1031

issue link:https://github.com/Azure/sdk-release-request/issues/2985


[SPARK-33818][SQL][DOC] Add descriptions about spark.sql.parser.quotedRegexColumnNames in the SQL documents

What changes were proposed in this pull request?
According to https://github.com/apache/spark/pull/30805#issuecomment-747179899,
doc spark.sql.parser.quotedRegexColumnNames since  we need user know about this in doc and it's useful.

Why are the changes needed?
Complete doc
Does this PR introduce any user-facing change?
No
How was this patch tested?
Not need

Test build #132929 has started for PR 30816 at commit 93e1c1f.

Test build #132929 has finished for PR 30816 at commit 93e1c1f.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
CREATE TABLE person (id INT, name STRING, age INT, class INT, address STRING);

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132929/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37532/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37532/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37532/

Test build #132938 has started for PR 30816 at commit 9df29ca.

Test build #132938 has finished for PR 30816 at commit 9df29ca.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132938/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37541/

cc @maropu @huaxingao @dilipbiswal FYI

@maropu Have updated as what you said. Can you review again? thanks.

@maropu Have updated as what you said. Can you review again? thanks.

Test build #133650 has started for PR 30816 at commit 5f7ca84.

Test build #133650 has started for PR 30816 at commit 5f7ca84.

Test build #133650 has finished for PR 30816 at commit 5f7ca84.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #133650 has finished for PR 30816 at commit 5f7ca84.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133650/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133650/

Test build #133653 has started for PR 30816 at commit aa52dd9.

Test build #133653 has started for PR 30816 at commit aa52dd9.

Test build #133653 has finished for PR 30816 at commit aa52dd9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #133653 has finished for PR 30816 at commit aa52dd9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133653/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133653/

Test build #133656 has started for PR 30816 at commit 1c042d1.

Test build #133656 has started for PR 30816 at commit 1c042d1.

Test build #133656 has finished for PR 30816 at commit 1c042d1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #133656 has finished for PR 30816 at commit 1c042d1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38242/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38242/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133656/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133656/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38239/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38239/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38242/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38242/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38242/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38242/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38239/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38239/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38239/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38239/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38245/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38245/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38245/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38245/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38245/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38245/

For reviews, could you put the screenshot of the updated doc in the PR description?

For reviews, could you put the screenshot of the updated doc in the PR description?

For reviews, could you put the screenshot of the updated doc in the PR description?

Yea, add whole page snapshot about changed place, looks pretty fine.

For reviews, could you put the screenshot of the updated doc in the PR description?

Yea, add whole page snapshot about changed place, looks pretty fine.

gentle ping @HyukjinKwon @dongjoon-hyun

gentle ping @HyukjinKwon @dongjoon-hyun

Thank you for pinging me, @AngersZhuuuu .

Thank you for pinging me, @AngersZhuuuu .


[Bug] [UI] Missing feature: Enter sub workflow

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
Missing feature: enter sub workflow

What you expected to happen
add "enter sub workflow"
How to reproduce

Create "sub"_ process“

Double click or edit "sub workflow"

Click "enter sub workflow" in the upper right corner of the edit box to enter the corresponding sub workflow

Anything else
No response
Version
dev
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

i will fix it


Recursive doesn't seem to work as expected

I have an automation test framework built using appium. I am using mocha as the test framework. I am facing some problems when using the --recursive flag.
My Project structure is something like this.
e2e
     -Test folder1
          -Test case file1
          -Test case file2
     -Test folder2
          -Test case file1
          -Test case file2
     -Test folder3
          -Test case file1
          -Test case file2

When I do a npm run e2e -- --runType configuration --recursive e2e/Testfolder1, all the folders are picked up for test execution
When I do a npm run e2e/Testfolder1 -- --runType configuration I get an error saying that it cannot find the scripts.
@boneskull , any inputs?

@gkvappium What is e2e? Could you reproduce the case you think is failing with the mocha command line tool instead, so we don't have to debug some external code that is not under our control?

Hi, please ask in the chat room or StackOverflow. be sure to provide an MCVE.  Thanks.


Document key-share requests

Documentation: https://docs.google.com/document/d/1m4gQkcnJkxNuBmb5NoFCIadIY-DyqqNAS3lloE73BlQ
We should document the events used by riot to do keyshare requests

(richvdh, using your prop as testdata)

it's in use, so I guess this is pr-missing

related to #501


ChaiScript

https://github.com/ChaiScript/ChaiScript

Note: https://github.com/ChaiScript/ChaiScript/issues/602

Thanks!


Update libraries.python* packages to use XML

Updated libraries.python*.vm to use XML instead of JSON.
Investigated the error "py -2 not available". Turns out Python3 installs "Python Launcher for Windows" (see: https://docs.python.org/3/using/windows.html#python-launcher-for-windows). We previously had the libraries.python2.vm package depend on Python3 -- this was the reason. I recommend we stick with that, even though it's slightly counterintuitive for simplicity. Added a comment in libraries.python2.vm's nuspec file to document this reasoning.
Removed stringsifter from libraries.python3.vm's modules.xml file since I couldn't get it to build locally. Until we figure out how, or the stringsifter folks update their installer, I'm in favor of skipping for now.

Linter says: FAIL: packages\python2.vm\python2.vm.nuspec - the version has not been updated: update the version in the nuspec file but I didn't update this file?

@MalwareMechanic rebasing this should fix the linter fail


Create documentation and samples for the Secret Store configuration provider implementation

Describe the proposal
Create documentation and samples for the Secret Store configuration provider implementation described in #238

@cmendible since Secret store configuration cannot be used with aspnet core currently due to the requirement that app must start a server before secret api is available in runtime. Would it be ok, if we stop building the Dapr.Extensions.Configuration.csproj project and dotn publisht he nuget for it unless it works out of the box.

closing the issue until we resurrect the secret store configuration provider.


NullPointer exceptions

fixed some null pointer exceptions so that the views display

Resolved conflicts relating to import statements.


use_test_for_validation - no longer needed?

In ulmfit/train_clas.py there is a somewhat confusing setting use_test_for_validation.
Am I correct to assume that it's just a work-around for this bug?
https://github.com/fastai/fastai/issues/1292
If so, the proper fix has been merged a few days ago: https://github.com/fastai/fastai/pull/1293
In such a case it could be useful to get rid of this work-around. I can give it a try, but only after a confirmation that it is not needed for other reasons.

It is implemented like that to be able to compare with the fastai notebooks as they are using Test set for validation. Besides as far as I remember the constructors for text databunches were ignoring labels for testset, I'm not sure if it is fixed already in fastai. Create a PR if the code can be simplified.

I've removed that in https://github.com/n-waves/ulmfit-multilingual/tree/multifit


CORS is not allowing privacy overlay to run

Bug Description
CORS is not allowing the privacy overlay to run locally.
Steps to Reproduce

build 2.15.0 locally
enable privacy experience and notices in the about section
visit the cookie house site
select a location

Expected behavior
privacy overlay is loaded
Screenshots

Environment

Version:
OS:
Python Version:
Docker Version:

Additional context
Add any other context about the problem here.

this may be fixed by this open PR- https://github.com/ethyca/fidesplus/pull/913/commits/b65988de4afed9203d7fe7da14469cd9d78a6fe4#diff-42b4c5203b6c4d86f8d86ea45b1deb841ee746eeeea9f5afcc2a13c7d55a150c but need to confirm

@eastandwestwind I'm still not able to get this to show up in a local build. I do not see the cors errors anymore. so I am sure that I am just missing something. let me know when you have a chance to chat quickly.

moving to done


Vesting module: Remove ensure_lockable

This check is not actually needed.
https://github.com/laminar-protocol/open-runtime-module-library/blob/c7a9a0ea79f3d3713ac4677e5462adf35c1c9226/vesting/src/lib.rs#L228

Fixed by #92


Set min date to Current Date

Be able to use native method datePickerDialog.getDatePicker();

Reply to the title:
dpd.setMinDate(Calendar.getInstance());

I don't undertand the question you're asking in the body of the issue.

if I need to set min date to today's date, then ?


Adding support for Python

Previously we only had support for shell sample code. This PR adds code snippets in python as well.
I have tested every python snippet that has been added, however additional checks would be good.
Make sure you've checked off all these things before submitting:

[x] This pull request isn't for a company's fork, it's intended for the upstream Slate shared by everybody.
[x] This pull request is submitted to the master branch.
[x] If it makes frontend changes, this pull request has been tested in the latest version of Firefox, Chrome, IE, and Safari.

Hi @anas1md @jaywonder20 can I get a review on this please?

Or if there is someone else who is better suited to review this, please let me know

The Authentication part has no Sample request for python

@rishabh-dhar , yup everything else looks good!

@anas1md @jaywonder20 can you please review and if it looks good merge and deploy


What happened?
Some parameters have inconsistent naming

What operating system are you seeing the problem on?
Mac OS
What browsers are you seeing the problem on?
Firefox
What wallet extension are you using?
Metamask
Rules

[X] I agree to follow this project's rules

oops, missed repository, sorry


docs: First stab at ReadTheDocs

Convert the LaTeX docs to Sphinx + Myst Markdown extension
I think this is in decent shape. It's going to need a lot of thorough proofreading to ensure that thing got lost or mangled on the way from the original docs. I suspect we will have several follow-up PRs to fix things.
After we're reasonably happy with it, we'll eventually remove the .tex and the pdf.

Preview of the staged docs: https://open-shading-language.readthedocs.io/en/latest/

This is looking great already!

Is there anything additional I should do before a first merge?  (Knowing that there will probably be lots of little fixes and enhancements I find later and will follow up with additional PRs as needed.)

If there are no objections surfacing, I'm going to merge this today, then we can move on to more careful proofreading and smaller patches to fix anything we see that needs to be fixed.

I didn't read through the text in detail, but the overall structure looks good to me.
We should definitely handle the next steps in follow up commits, this is already a great start.


chore: Update CODEOWNERS

Please comment below if you don't want to be notified while receiving PRs.
@silver-ymz @Ji-Xinyou @oowl

And do you want to receive all PRs (as PPMC members)?
@PsiACE @ClSlaid @sundy-li

I am cool with receiving emails upon PR on C bindings😘


Fixed issue while running Docker build image

Description:
$subject. We can not build Docker images without any open editor.
Suggested Labels:
Type/Bug

Fixed in - https://github.com/wso2/devstudio-tooling-platform/pull/279


Inserting a column to the right will bring dataVerification in the front column to the inserted column

Inserting a column to the right will bring dataVerification in the front column to the inserted column

hi @dxxx032 , thanks for submitting this issue. can you please post a screen recording of this?

@dxxx032 It seems intentional, Google sheets behaves the same.


Refactor JSG exception decoding, add relevant test cases

This commit resolves a TODO about refactoring code for different error types in decodeTunneledException. This should make the code more maintainable if there are future additions. I also added some test cases for handling compile errors and DOM exceptions since tunneling them was not tested before and adding them made it easier to spot potential bugs while refactoring the function.

I have read the CLA Document and I hereby sign the CLA


Camera permanently running needlessly drains battery

I had the app running on my phone for an event last weekend when there was no queue but only occasional scans required. Keeping it running continuously would have drained the battery a lot with the camera being active all the time.
My workaround was to close the app in between, but it would have been very useful to have a mode where a scan (and thus activation of the camera) would only be done on pushing a "scan now" button.
Ideally one would have some slider or similar toggle to switch between "one off" scans and "continuously scanning" so if some larger group arrives at a time one won't need to press the scan button again and again in this case...

I honestly think the workaround of "lock the phone when you don't need it" is the best, otherwise the screen will still draw a lot of power.

Does locking the phone switch off the camera? How can one be sure of it?
Also I think just having the screen on alone would be far less of a drain than also having the camera active and the app trying to scan for some QR code within the image it reads from the camera...

Yes, locking the phone switches off the camera. I'm not sure how you could verify.


Check build dependencies

Make sure that the user is running with the correct version of cudf. Similar to what MODIN does with the pandas version.

Also this issue should tackle not only cudf version but all the other dependencies needed in modin-gpu

@pastranakike @kvu35
cuDF dependency cannot be added to setup.py, since cuDF currently is only available through conda.


Update Flush to work only when enough data available

If the size of the part sent is less than 5MB it fails. With this change, the flush waits until there's enough information to send to S3.

Looks like a good, safe change.

FYI, I'm using this in production now successfully with this change applied. Great work! 👏


Mamba documentation broken display

Describe the issue as clearly as possible:
The documentation page of Mamba is not displaying correctly. It is showing extra large icons and basic text, so there must be something wrong with the markdown file.
link: https://outlines-dev.github.io/outlines/reference/models/mamba.md
Steps/code to reproduce the bug:
1) Go to https://outlines-dev.github.io/outlines/reference/models/mlxlm/

Expected result:
Mamba documentation page

Error message:
No response
Outlines/Python version information:
n/a
Context for the issue:
No response

Thank you for opening an issue! This is because the file was recently removed but the navigation was not updated. This is being fixed in #1072.


Error uploading events from batch file

Describe the bug
message= Error uploading events from batch file
fileUrl="/data/user/0/package_id/app_segment-disk-queue/UfVKIEDDpKxJ37CXxuFpSsOybierN7HW-778"
msg=/data/user/0/package_id/app_segment-disk-queue/UfVKIEDDpKxJ37CXxuFpSsOybierN7HW-778: open failed: ENOENT (No such file or directory), event=null
Platform (please complete the following information):

Library Version in use: com.segment.analytics.kotlin:android:1.7.0
Platform being tested: Android

hey @abdullahjhussein, this looks like the sdk is trying to upload a file that's been already uploaded. can you provided more context in terms of the following:

are you still experiencing this issue? if so, how often do you see this happening?
does this error interrupt the sdk or crash your app? if it does crash your app, can you provide a stack trace?

theoretically this issue shouldn't happen, since we serializes the file uploading with a single thread. even if it does, it shouldn't interrupt anything.

@wenxi-zeng
Thank you for your response
This issue is still appearing in the LogCat but not interrupt the SDK or crash the app

I'm also seeing this issue. Here's a sample error message:
message= Error uploading events from batch file
fileUrl="/data/user/0/my.package.name.here/app_segment-disk-queue/ddMUo4VVm1FQiNDZBBGJlaHG5y9l5wsX-26"
msg=/data/user/0/my.package.name.here/app_segment-disk-queue/ddMUo4VVm1FQiNDZBBGJlaHG5y9l5wsX-26: open failed: ENOENT (No such file or directory)

I'm on v1.10.6:
implementation("com.segment.analytics.kotlin:android:1.10.6")

I see this error on Android APIs 30 and 33; those are the only ones I've tested so far.
When I open the directory referenced in the error, that directory is empty, so the error makes sense. It seems like Segment is not writing the file to begin with.
This appears to be stopping the app from sending data from the device, so we're kind of blocked without a fix for this issue. Please let me know if there was anything discovered to resolve this.

@wenxi-zeng thanks for the reply. That's good information to have. I'll let you know if I do see any failures to upload, but for now this doesn't seem to be causing any, so I'll look at the log settings.


vertica-nodejs dependences changed to 0.9.0-pre.1

We missed the dependencies from vertica-nodejs to v-protocol, v-connection-string and v-pool.

I had not noticed Jonathan put up the same PR.  I approved his and I'm closing this one.


S3 Bucket name already in use

Testing the stack I received the error that the S3 Bucket name was already in use. I went through most of the code and couldn't find where to change it. Any help would be greatly appreciated.

The article & documentation definitely need some clarification.  I ran into this as well.
If you're following the Walkthrough, you define the following module:
module "stack" {
  source      = "github.com/segmentio/stack" # the module source
  name        = "pingdummy" # the name for our project
  environment = "prod" # the environment we're running in
  key_name    = "<my-ssh-key>" # reference a key you've previously created
}

However the name property is combined with the environment name to create an S3 bucket which must be globally unique.
That happens here:
resource "aws_s3_bucket" "logs" {
  bucket = "${var.name}-${var.environment}-logs"
  //more stuff
}

So what you need to do is modify the name property in your "stack" module to be globally unique:
module "stack" {
  source      = "github.com/segmentio/stack" # the module source
  name        = "unique-name-pingdummy" # the name for our project
  environment = "prod" # the environment we're running in
  key_name    = "<my-ssh-key>" # reference a key you've previously created
}

@stdevops That should do the trick.


404 for one file, but not for others

phpinfo.php is giving me a 404 result, where another file is accessed without a problem.
ls -l test.html phpinfo.php
-rw-r--r--  1 christiannally  wheel  18 27 Feb 14:39 phpinfo.php
-rw-r--r--  1 christiannally  wheel  26 27 Feb 14:40 test.html
I can edit test.html and the changes work right away. Accessing phpinfo.php returns a 404.
Codebase
mounted codebase
Host OS
macOS Sierra
Docker info output
Containers: 8
 Running: 8
 Paused: 0
 Stopped: 0
Images: 8
Server Version: 17.12.0-ce
Storage Driver: overlay2
 Backing Filesystem: extfs
 Supports d_type: true
 Native Overlay Diff: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: bridge host ipvlan macvlan null overlay
 Log: awslogs fluentd gcplogs gelf journald json-file logentries splunk syslog
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Init Binary: docker-init
containerd version: 89623f28b87a6004d4b785663257362d1658a729
runc version: b2567b37d7b75eb4cf325b77297b140ea686ce8f
init version: 949e6fa
Security Options:
 seccomp
  Profile: default
Kernel Version: 4.9.60-linuxkit-aufs
Operating System: Docker for Mac
OSType: linux
Architecture: x86_64
CPUs: 2
Total Memory: 3.855GiB
Name: linuxkit-025000000001
ID: SFX6:7VI3:P3KC:TDPE:54AQ:R2OX:DMDB:MGQR:BNVU:XMZJ:5IAG:MAQN
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): true
 File Descriptors: 96
 Goroutines: 136
 System Time: 2018-02-27T23:44:29.744893581Z
 EventsListeners: 4
HTTP Proxy: docker.for.mac.http.internal:3128
HTTPS Proxy: docker.for.mac.http.internal:3129
Registry: https://index.docker.io/v1/
Labels:
Experimental: true
Insecure Registries:
 <IP_ADDRESS>/8
Live Restore Enabled: false

Docker compose file
version: "2"

services:
  mariadb:
    image: wodby/mariadb:10.2-3.0.2
    environment:
      MYSQL_ROOT_PASSWORD: password
      MYSQL_DATABASE: drupal
      MYSQL_USER: drupal
      MYSQL_PASSWORD: drupal
    volumes:
      - ./mariadb-init:/docker-entrypoint-initdb.d # Place init .sql file(s) here.
#      - /path/to/mariadb/data/on/host:/var/lib/mysql # I want to manage volumes manually.

  php:
    image: wodby/drupal-php:5.6-dev-3.3.1
    environment:
      PHP_SENDMAIL_PATH: /usr/sbin/sendmail -t -i -S mailhog:1025
      PHP_FPM_CLEAR_ENV: "no"
      DB_HOST: mariadb
      DB_USER: drupal
      DB_PASSWORD: drupal
      DB_NAME: drupal
      DB_DRIVER: mysql
#      PHP_XDEBUG: 1
#      PHP_XDEBUG_DEFAULT_ENABLE: 1
#      PHP_XDEBUG_REMOTE_CONNECT_BACK: 0
#      PHP_XDEBUG_REMOTE_HOST: "<IP_ADDRESS>"
#      PHP_XDEBUG_PROFILER_OUTPUT_DIR: /mnt/files/xdebug/profiler
#      PHP_XDEBUG_TRACE_OUTPUT_DIR: /mnt/files/xdebug/traces
#      PHP_BLACKFIRE: 1
    volumes:
      - .:/var/www/html
## Options for macOS users (https://docker4drupal.readthedocs.io/en/latest/macos)
#      - codebase:/var/www/html:cached # User-guided caching
#      - docker-sync:/var/www/html # Docker-sync
## For Xdebug profiler files
#      - files:/mnt/files

  nginx:
    image: wodby/drupal-nginx:7-1.13-3.0.2
    depends_on:
      - php
    environment:
      NGINX_STATIC_CONTENT_OPEN_FILE_CACHE: "off"
      NGINX_ERROR_LOG_LEVEL: debug
      NGINX_BACKEND_HOST: php
      NGINX_SERVER_ROOT: /var/www/html
#      NGINX_DRUPAL_FILE_PROXY_URL: http://example.com
    volumes:
      - .:/var/www/html
# Options for macOS users (https://docker4drupal.readthedocs.io/en/latest/macos)
#      - codebase:/var/www/html:cached # User-guided caching
#      - docker-sync:/var/www/html # Docker-sync
    labels:
      - 'traefik.backend=nginx'
      - 'traefik.port=80'
      - 'traefik.frontend.rule=Host:drupal.docker.localhost'

#  adminer:
#    image: wodby/adminer:4.3-1.1.0
#    environment:
#      ADMINER_SALT: adminer-salt
#    labels:
#      - 'traefik.backend=adminer'
#      - 'traefik.port=9000'
#      - 'traefik.frontend.rule=Host:adminer.drupal.docker.localhost'

  pma:
    image: phpmyadmin/phpmyadmin
    environment:
      PMA_HOST: mariadb
      PMA_USER: drupal
      PMA_PASSWORD: drupal
      PHP_UPLOAD_MAX_FILESIZE: 1G
      PHP_MAX_INPUT_VARS: 1G
    labels:
      - 'traefik.backend=pma'
      - 'traefik.port=80'
      - 'traefik.frontend.rule=Host:pma.drupal.docker.localhost'

  solr:
    image: wodby/drupal-solr:7-5.4-2.3.0
    environment:
      SOLR_HEAP: 1024m
    labels:
      - 'traefik.backend=solr'
      - 'traefik.port=8983'
      - 'traefik.frontend.rule=Host:solr.drupal.docker.localhost'

  mailhog:
    image: mailhog/mailhog
    labels:
      - 'traefik.backend=mailhog'
      - 'traefik.port=8025'
      - 'traefik.frontend.rule=Host:mailhog.drupal.docker.localhost'

  portainer:
    image: portainer/portainer
    command: --no-auth -H unix:///var/run/docker.sock
    volumes:
      - /var/run/docker.sock:/var/run/docker.sock
    labels:
      - 'traefik.backend=portainer'
      - 'traefik.port=9000'
      - 'traefik.frontend.rule=Host:portainer.drupal.docker.localhost'

  traefik:
    image: traefik
    command: -c /dev/null --web --docker --logLevel=INFO
    ports:
      - '8000:80'
#      - '8080:8080' # Dashboard
    volumes:
      - /var/run/docker.sock:/var/run/docker.sock

volumes:
  codebase:
## Docker-sync for macOS users
#  docker-sync:
#    external: true
## For Xdebug profiler
#  files:

Logs output
nginx_1      | <IP_ADDRESS> - - [27/Feb/2018:23:46:46 +0000] "GET /phpinfo.php HTTP/1.1" 404 193 "-" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.167 Safari/537.36"
nginx_1      | <IP_ADDRESS> - - [27/Feb/2018:23:46:46 +0000] "GET /favicon.ico HTTP/1.1" 200 43 "http://drupal.docker.localhost:8000/phpinfo.php" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.167 Safari/537.36"

php_1        | <IP_ADDRESS> -  27/Feb/2018:22:31:47 +0000 "GET /index.php" 500
php_1        | <IP_ADDRESS> -  27/Feb/2018:22:37:38 +0000 "GET /index.php" 500
php_1        | [27-Feb-2018 22:41:48] NOTICE: Terminating ...
php_1        | [27-Feb-2018 22:41:48] NOTICE: exiting, bye-bye!
php_1        | [27-Feb-2018 23:19:30] NOTICE: fpm is running, pid 1
php_1        | [27-Feb-2018 23:19:30] NOTICE: ready to handle connections

For security reasons the drupal-nginx image returns 404, for all not whitelisted PHP files. You can see it in the template https://github.com/wodby/drupal-nginx/blob/master/templates/d7-vhost.conf.tpl#L228-L230.
If you like to see the phpinfo, you can always log in into your Drupal installation as an admin and open admin/reports/status/php

Thanks @szeidler
While I have you on the line, I've not yet been able to get my own Drupal code working. I could see php info via 'php -i' in that container, but setting the error log location etc. in settings.php hasn't enabled me to get full 500 error text.
I am getting some log entries that show the occurance of the 500 error, but not the actual error message itself.
php_1        | <IP_ADDRESS> -  27/Feb/2018:19:52:10 +0000 "GET /index.php" 500
php_1        | <IP_ADDRESS> -  27/Feb/2018:20:08:42 +0000 "GET /index.php" 500
php_1        | <IP_ADDRESS> -  27/Feb/2018:22:25:29 +0000 "GET /index.php" 500
php_1        | <IP_ADDRESS> -  27/Feb/2018:22:31:47 +0000 "GET /index.php" 500

nginx_1      | <IP_ADDRESS> - - [28/Feb/2018:17:20:18 +0000] "GET / HTTP/1.1" 499 0 "-" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.167 Safari/537.36"
nginx_1      | 2018/02/28 17:20:18 [info] 24#24: *3 epoll_wait() reported that client prematurely closed connection, so upstream connection is closed too while sending request to upstream, client: <IP_ADDRESS>, server: drupal, request: "GET / HTTP/1.1", upstream: "fastcgi://<IP_ADDRESS>:9000", host: "drupal.docker.localhost:8000"
nginx_1      | <IP_ADDRESS> - - [28/Feb/2018:17:20:59 +0000] "GET / HTTP/1.1" 500 5 "-" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.167 Safari/537.36"

I may be having trouble because I'm not used to nginx administration. Do you have a "tip jar" I can contribute too?

Thanks for the work on this excellent project!

When you set $conf['error_level'] = 2; in your settings.php, Drupal should present you errors and exceptions on the screen.
As I'm "only" a Docker4Drupal user and no maintainer I cannot explain why they are not streamed to the logs :)

I cannot explain why they are not streamed to the logs :)

Don't you see errors in stdout after changing the error_level?

I added $conf['error_level'] = 2; in my settings.php, but I don't see any php errors in stdout yet (running docker-compose logs php).

AFAIK, Drupal (at least Drupal 7) uses its own error handlers and have two error log destinations: dblog and syslog. There's no syslog daemon in php container because, you know, containers, we have one process per container. You can check it by commenting the following lines in _drupal_bootstrap_configuration():
  set_error_handler('_drupal_error_handler');
  set_exception_handler('_drupal_exception_handler');

Solutions:

implement your own _watchdog hook and stream errors to the default error_log (which is container's output)
Use monolog module with udp syslog plugin and stream all errors to rsyslog container as described at https://wodby.com/stacks/drupal/docs/containers/rsyslog/, this way you'll see all errors in rsyslog container output


Gallery of contributors

While investigating for another issue, I stumble upon this project that shows its list of contributors:
https://github.com/Karumi/Dexter#contributors

How about having the same?
Merits:

Show how diverse we are, which probably lowers the level of entry for most of the world's population
Increased incentive to participate
Uses GitHub avatar / name, for which people who don't like publicity use an empty icon already
Demerits:
Takes space
Requires a bit of initial effort and maintenance ever 6 months or so.

Source code:
# Contributors

Thank you all for your work!

| [
Carlos Morera de la Chica](https://github.com/CarlosMChica) | [
Alex Florescu](https://github.com/anothem) | [
Pedro Veloso](https://github.com/pedronveloso) | [
Dion Segijn](https://github.com/DanielMartinus) | [
Christian Panadero](https://github.com/PaNaVTEC) |
| :---: | :---: | :---: | :---: | :---: |
| [
Vignesh](https://github.com/VigneshPeriasami) | [
Andy French](https://github.com/AndyFrench) | [
Bernat Borrás Paronella](https://github.com/alorma) | [
Bastien Paul](https://github.com/bastienpaulfr) | [
Bas Broek](https://github.com/BasThomas) |
| [
Bartek Lipinski](https://github.com/blipinsk) | [
emmano](https://github.com/emmano) | [
Konrad Morawski](https://github.com/Konrad-Morawski) | [
Hrant Alaverdyan](https://github.com/rid-hrant) | [
Carla](https://github.com/iriberri)
| [
Pavel Stepanov](https://github.com/stefan-nsk) | [
Emmett Wilson](https://github.com/EmmettWilson) | [
Max](https://github.com/TheMaxCoder) | [
Al B.](https://github.com/albodelu) | [
Vladislav Bauer](https://github.com/vbauer)
| [
Jc Miñarro](https://github.com/JcMinarro) | [
handrenliang](https://github.com/handrenliang) | [
jcruzsousa](https://github.com/jcruzsousa) | [
lzdon](https://github.com/lzdon)

The list at https://github.com/commons-app/apps-android-commons/graphs/contributors is a good place to get a list of our contributors. Any volunteer to write a script (in your favorite language) that scraps that web page and turns it into a table like above?

@nicolas-raoul I'd like to take this up

@ashishkumar468 It is yours :-)

@nicolas-raoul  Just to make sure everybody is on the same page, an item will be added to the nav drawer named as Contributors which on click would lead to a screen where the list of contributors from   https://github.com/commons-app/apps-android-commons/graphs/contributors would be shown.

Sounds great! I probably need to get around to putting up a real avatar.... someday, haha.
I wonder if it would be a good idea to limit to those with >10 commits? Otherwise we would have a very long list. But I'm OK with either.

Sounds great! I probably need to get around to putting up a real avatar.... someday, haha.

This is what I exactly thought:)

@ashishkumar0207 I was only talking about putting it as HTML code in https://github.com/commons-app/apps-android-commons/blob/master/README.md (or it could be in https://github.com/commons-app/apps-android-commons/wiki/Volunteers-welcome! actually).
If you really want to put it in the app:

"About" is the best place, adding another item to the nav drawer would crowd it for no good reason
Make sure that it does not become a crash cause, in particular make sure that it fails gracefully when no Internet access is available.

A long list is OK, I would say. If you want to cut, I would suggest "First X committers when ordering by number of commits" rather than a strict "all committers with Y commits", because it allows us to make a nice rectangular table :-)

@nicolas-raoul  I am not that great with html, will take me a lot of time to implement, I was hoping if someone more fluent in web ui can take it up, for the app @neslihanturan @misaochan @nicolas-raoul We have I think 100 people with at-least one commit, thats not a lot (which will be anyways sorted by the number of commits). We can show all of them if all of us agree or we can show top x contributors based on the number of commits. @nicolas-raoul Are you suggesting adding a filter based on the number of commits. ?

I agree that the readme or wiki would be the ideal place for it. But if we do have it in the app, I think a separate fragment that is linked via About would be best.
I'm good either way, a complete list or "first 40 committers" (or other value) both sound OK to me. :)

@misaochan @nicolas-raoul @neslihanturan Lets clear a few things out
1.Do we need this feature in the app
2.If yes, How many contributors do we show (I will keep that configurable by a variable from where it could be easily updated)
One of you guys please confirm.

How about we say at first:

In the README, not in the app
40 biggest committers

But in open source a feature only gets implemented when a volunteer comes in and does it. So if you don't want to do HTML but rather want to implement it in the app instead, and send us a good pull request, we will probably accept it :-)

@nicolas-raoul @misaochan I actually did a bit of research. We cannot insert script in the readme file. @nicolas-raoul The repository which you have mentioned, Dexter, even that, if you see their readme file, you will find that  they have hardcoded the list, do we want the same in our readme ?

@ashishkumar0207  We want a script (in any language, for instance Groovy) that generates that list. Writing it by hand would require too much maintenance.

@nicolas-raoul @misaochan I have actually written the script to generate the list of contributors in the required format. I had a few questions.

Where should we put show it ie. in  https://github.com/commons-app/apps-android-commons/blob/master/README.md or in https://github.com/commons-app/apps-android-commons/wiki/Volunteers-welcome!
*The script which generates it is in python, so where do we want to put this file?

Cool thanks!
Could you please create a new GitHub project for it called "maintenance", commit your script into it, and then transfer that repository (in settings) to the commons-app organization? Thanks a lot :-)

@nicolas-raoul Tried doing that, github needs two things for that
Type the name of the repository to confirm & New owner’s GitHub username or organization name. Can you help me with those ?

Just enter the name of the repository you have created, and "commons-app" :-)
If it still does not make sense, please post a screenshot of that screen.

I am getting this "You don’t have the permission to create repositories on commons-app"

Ah yes you are right.
I just forked it from the commons-app account, it achieved the same thing: https://github.com/commons-app/maintenance
Thanks! :-)

Readme looks great :-)

Readme looks great :-)

Looks great, thanks for working on it @ashishkumar0207 ! :)


Composed Modal does not call optional functions when closed by clicking or escape

Detailed description

Describe in detail the issue you're having.

This pull request fixed this issue regarding composed modals not closing when clicking outside the modal. While composed modals do indeed close now upon clicking outside the modal area, no optional function gets called to handle the close. This is true for both the handleKeyDown (with the escape button) and handleClick methods of closing the modal.

Is this issue related to a specific component?

The <ComposedModal> and its children: <ModalHeader> and <ModalFooter>.

What did you expect to happen? What happened instead? What would you like to see changed?

Both the <ModalHeader> and <ModalFooter> components seem to have an optional closeModal function in the source code that should be called when the modal is closed, but neither are. These functions should be correctly called when the modal closes, or the <ComposedModal> itself should have an optional function to do the same.

What browser are you working in?

Tested in Firefox and Chrome.

What version of the Carbon Design System are you using?

<EMAIL_ADDRESS><EMAIL_ADDRESS>
What offering/product do you work on? Any pressing ship or release dates we should be aware of?

Working on an IBM internal portal, no pressing release date.
Steps to reproduce the issue
(See code sandbox below, but know that it is not up-to-date and will not close the composed modal upon clicking outside)

Create a <ComposedModal> component with a header and/or footer (and body I suppose, though irrelevant).
Give the header and/or footer the property closeModal set to a function of your choice.
Open the composed modal, then click outside or press escape to close it. The function provided to closeModal will not run.

Please create a reduced test case in code sandbox
https://codesandbox.io/s/z2kvxqn89m

I'm unsure how to fully replicate this in code sandbox because its carbon version is older.
Additional information
I was able to fix this locally by implementing an onRequestClose property to the composed modal itself by changing carbon-components-react/es/components/ComposedModal.js to include the following (added the second line):
defineProperty(_assertThisInitialized(_assertThisInitialized(_this)), "closeModal", function () {
     _this.props.onRequestClose();
     _this.setState({
          open: false
     });
});

I'm certain there's a better way to do this, but I'm not familiar enough with carbon to write a pull request.

Hi 👋 thank you for reporting! Given your example code at last alludes that you simply want an event fired on close in <ComposedModal>, I'm changing the title as such.


WIP 471 project view basic layout

Addresses #471 (summary of progress is in the issue page)

@ptgott let me know what you think!