Doc sidebar does not expand full viewport height in v2.3.1

Have you read the Contributing Guidelines on issues?

[X] I have read the Contributing Guidelines on issues.

Prerequisites

[X] I'm using the latest version of Docusaurus.
[X] I have tried the npm run clear or yarn clear command.
[X] I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
[ ] I have tried creating a repro with https://new.docusaurus.io.
[X] I have read the console error message carefully (if applicable).

Description
Doc sidebar does not expand full viewport height when the content in the page does not take up full viewport height. This issue is likely reintroduced after v2.2.0.
Reproducible demo
No response
Steps to reproduce

Initialise new docusaurus project: npx -y create-docusaurus@latest test classic
Reduce content in one of the pages, say, docs/intro.md, delete most content keeping only couple of lines
Start development server: npm start

This is what I see

Expected behavior
Sidebar should expand full viewport height.
Actual behavior
Sidebar only extend up to content height.
Your environment

Docusaurus version used: 2.3.1
Environment name and version: Safari 16.3, Node.js 18.14.2
Operating system and version: macOS 12.6.3

Self-service

[ ] I'd be willing to fix this bug myself.

@slorber Can I work on this issue?

The issue seems resolved in the latest canary 0.0.0-5500. docusaurus.io website itself does not have this issue. Perhaps all we need is a stable point release with the fix commit. Thank you.


How see error value and number iterations after training ?

In time training I see  error value, so:
net.train(myarray, {
        log: true,
        });

But, how to see in the future error value and number iterations?
How can I see this? How to keep it?

:(

net.train returns what you need. just assing it to some variable:
const res = net.train(myarray, {
        log: true,
        });

Yes.
And I will see the values throughout the training
But I ask:
how to see this varible after train? Without use  log: true,

Like this?
console.log(res)

Example: (please see line no. 15)
https://jsfiddle.net/jn056e7L/8/


all the syntax change .. can use anymore usestager and other

Empire Version 2.2
linux
all the syntax change .. can use anymore usestager and other
is there a new syntax to use in Empire version 2.2 ?

Screenshot of error, embedded text output, or Pastebin link to the error
Any additional information

to much problems in version 2.2 !!!! nothing work
when you put a command it gives always error message ..really dont now how people work with this version???

Use [tab]
Please see #573 and all others issues related.


Deleting too many role bindings

The current PSPT logic deletes any and all role bindings associated with a service account when it modifies PSPT related resources.  It should only delete role bindings associated with PSPTs.

Darren encountered this during the meetup. The specific usecase he ran into was this:

Create a GKE cluster through google, not through rancher
Import the cluster
Move all namespaces (most importantly kube-system into a project)
Attempt to create a service load balancher.

Expected result:
Service LB created successfully and traffic properly blanced
Actual result:
The service LB API request goes through, but the balancer ultimately does not get setup properly. Traffic wasnt properly balanced/forwarded and if you did a kubectl describe svc foo

@cjellick
Tested with latest build from master:

Create a GKE cluster through google, not through rancher
Import the cluster
Made sure that creating a LoadBalancer for a workload , creates a LB successfully and is functional.
Move all system namespaces to a project.
Create  LoadBalancer for a workloads (in existing namespace and new namespace).
Service LBs get created successfully and traffic is properly balanced between the pods of the workloads.

Tested with latest build from master:
Create 3 psps , psps1 , psp4 , psp5.
Create a DO cluster with default psp set to psp1.
Create a project p1 with psp set to psp5. Create a namespace - hello1.
Create a project p2 with psp set to psp4.
Outside of rancher server , create a  role binding ( read-secrets) associated with service account in namespace - hello1.
LaviniapleWatch:bin sangeethahariharan$ kubectl get rolebindings read-secrets -n hello1 -o yaml
apiVersion: rbac.authorization.k8s.io/v1
kind: RoleBinding
metadata:
  creationTimestamp: 2018-04-20T22:03:16Z
  name: read-secrets
  namespace: hello1
  resourceVersion: "7227"
  selfLink: /apis/rbac.authorization.k8s.io/v1/namespaces/hello1/rolebindings/read-secrets
  uid: a0f242f9-44e6-11e8-bb37-4aed3ec7b3e5
roleRef:
  apiGroup: rbac.authorization.k8s.io
  kind: ClusterRole
  name: view
subjects:
- kind: ServiceAccount
  name: default
  namespace: hello1
LaviniapleWatch:bin sangeethahariharan$

From rancher server UI , move namespace hello1 from project p1 to p2 , so that the PSP role bindings associated with Service account needs to be deleted and recreated with new psp.
PSP role binding got updated as expected and after this the role binding ( read-secrets) associated with service account continues to be present.
LaviniapleWatch:bin sangeethahariharan$ kubectl get rolebindings -n hello1
NAME                                        AGE
clusterrolebinding-gh7d7                    22m
clusterrolebinding-x25sj                    27m
clusterrolebinding-xj8s6                    22m
clusterrolebinding-xx9tm                    27m
default-hello1-psp5ac-clusterrole-binding   22m
read-secrets                                6m

After moving "hello1" to a different project

LaviniapleWatch:bin sangeethahariharan$ kubectl get rolebindings -n hello1
NAME                                      AGE
clusterrolebinding-gh7d7                  23m
clusterrolebinding-x25sj                  28m
clusterrolebinding-xj8s6                  23m
clusterrolebinding-xx9tm                  28m
default-hello1-psp4-clusterrole-binding   10s
read-secrets                              7m


Single Connection Per Service

Force user to connect with only one account per service

Good idea! +1

Good idea! +1


feat: soft keyboard events

Description
Provides space/character event emulation on platforms that are not equipped with hardware keyboard (e.g. Android/iOS).
Emulation is based on diff between delta, so it happens after the change is committed to the document rather than on key press.
Enable it by setting true to QuillEditorConfigurations.softKeyboardShortcutSupport (This disables hardware events)
There might be some issues I haven't foreseen/came across yet, but it seems to work fine with all the standard  shortcuts.
https://github.com/user-attachments/assets/4c3be427-afe4-4d66-b676-78000507035a
Related Issues

Fix #2214

Type of Change

[x] ✨ New feature: Adds new functionality without breaking existing features.
[x] 🛠 Bug fix: Resolves an issue without altering current behavior.
[ ] 🧹 Code refactor: Code restructuring that does not affect behavior.
[x] ❌ Breaking change: Alters existing functionality and requires updates. (MINOR: breaking change, affects classes overriding QuillController.replaceText )
[ ] 🧪 Tests: Adds new tests or modifies existing tests.
[ ] 📝 Documentation: Updates or additions to documentation.
[ ] 🗑 Chore: Routine tasks, or maintenance.
[ ] ✅ Build configuration change: Changes to build or deploy processes.

@CatHood0 @EchoEllet thanks for the thorough review 🙇  applied all the remarks, let me know if I can make it any better

@EchoEllet @CatHood0  I've started wondering about one thing in my PR:
https://github.com/singerdmx/flutter-quill/blob/27343d56ba7f5b911bdc7b6d1cd2ba5f2f272dfd/lib/src/editor/raw_editor/config/events/soft_keyboard_shortcut_support.dart#L37-L38
Does delta diff gets more costly the bigger the doc is? Is there maybe a better way to detect this key press than doing a diff on the delta? Obviously key press events are not available on mobile but is there maybe some API of intercepting delta inserts? Could this maybe be more efficient this way? 🤔

@EchoEllet @CatHood0 I've removed delta diffing from my PR, it should make things faster 🤞 Now to detect if we're getting a new character:

added a flag to differentiate if the replaceText is called by an input client
https://github.com/singerdmx/flutter-quill/blob/e27ba2a12aef1f0f33328fafa08b91fd35a68cbe/lib/src/controller/quill_controller.dart#L311-L319

checking if the incoming delta is single character insert
https://github.com/singerdmx/flutter-quill/blob/e27ba2a12aef1f0f33328fafa08b91fd35a68cbe/lib/src/controller/quill_controller.dart#L331-L333

passing relevant delta to the logic I've written so far at the end of this method
https://github.com/singerdmx/flutter-quill/blob/e27ba2a12aef1f0f33328fafa08b91fd35a68cbe/lib/src/controller/quill_controller.dart#L388-L395

I probably should be able to make _softKeyboardShortcutSupport!.onNewChar static and get rid of the _softKeyboardShortcutSupport instance from QuillController

@EchoEllet I will leave this PR to you regarding whether to merge or when to merge

Apologize for requesting too many changes many times but we will take code reviews more seriously than before from now on (at least try to). If you want, you can leave it to me and I will address those changes but will probably take longer than expected and I might ask you a few questions.
Thank you for your efforts on this PR.

No worries, my knowledge of the library internals is limited so I learn as I poke things around. I appreciate all the feedback!

@EchoEllet

refactored everything soft keyboard related to be in a separate folder -> soft_keyboard_shortcut_support (some unavoidable code duplication)
added the aforementioned ReplacedTextCallback support to QuillController (this is minor breaking change, unsure if this can be done any smarter)
adapted quill_screen.dart to the refactored code

Let me know what you think and where it would be fine to store these soft_keyboard_shortcut_support classes. I might be the only person needing these so might not make sense to keep them in this library 😅

To be honest, I'm hesitant to merge or reject this change:

[!NOTE]
To be clear, we're discussing the project issues that are not related to the issues of this change, but merging
more changes we're not sure about can make the maintenance process harder and can contribute to them. It's a issue
We have for a long time. We do appreciate your time and efforts though this is not the main issue.

All files related to a specific feature should be feature-based and not based on the file type.
We previously added directories such as models, config, and widgets, and files of each feature will be separated across those directories, the config directory of the raw editor and the editor should be the config for the editor itself and not for the newly added feature, this change has quite a lot of changes.
We do have other tasks to focus on and prioritize, I couldn't understood quite a lot of changes without contacting the contributors who made them. This will be a long process and we will probably need to put the library in maintenance mode, no longer accepting changes, only bug fixes and code cleanup, big projects are doing something very similar, see gson
We don't want to introduce something to the public as stable and then remove it after very short while, to clean up a lot of design issues we need to break things instead of introducing new changes that we're not sure about, making it more overwhelmed to maintain. This is not an issue I have, @CatHood0, @AtlasAutocode, and the others are also unable to fix some issues due to the codebase we have even though they put efforts more than what I do since they joined at the start of 2024, take a search at Google (I fork flutter quill) and you will find threads and article discussing this, users are moving away from Flutter Quill and I have seen some posts around from there and here, so it's not necessarily a personal issue. You will see quite a lot of forks and other projects that handle things very differently, we do plan on improving this.
I don't plan on rejecting this PR, if I'm unsure will leave the decision to @singerdmx, @CatHood0, @AtlasAutocode. If this PR was not merged, then it's not necessarily an issue with the PR or the changes, or efforts you made, we do appreciate your help with the project but the issue is not mainly with your changes.
You did put efforts to abstract this change but introducing low-level code that gives you more control (closer to the core) is not something we can make, our next plan is to review all PRs that have been introduced since 2020, understanding the changes and cleaning them up, since not all contributors will be available to contact, it will be more difficult task, you will find that many of the previous contributors have left the project and decided to move into another project and one of the main reasons are the issues we have, I have tried to avoid saying this for a year but the first step of solving an issue is to identify it. It's very likely we will be unable to solve those issues but we have to at least try, so we can't give promises we can't keep up to. I have tried (didn't put much effort due to the like of time) to fix as many issues as I can in 2023 and many of the users were disappointed since they were expecting too much.
I think we're being too rush when merging things and make decisions, every decision need to be discussed first before making it for long enough, to be clear this is not an issue with this PR, but when I asked in this comment is to give me an example of how this low-level API will abstract your implementation, it seems that you introduced changes very quickly.
Focusing on something that is simple doesn't mean it's simple to execute, you will find that the Dart team still hasn't decided on the plugin_platform_interface  regarding it should be removed or maintaining this package, the package itself is very simple, they are more than capable of managing it, they also know the differences if they should remove or maintain it (Flutter #127396). Similar issues in Compose Multiplatform

I can't reject this change since you made efforts while working on this change and I didn't make all of this clear from the start, we should have open an issue and then put a warning in README.md and CONTRIBUTING.md about the maintenance mode or at least indicate that making new features or changes this big should be discussed somewhere in Github discussion or Slack before attempting to make them, otherwise there will be a high chance of rejecting changes.
So I will have to leave the final decision to the other maintainers.
For now, I'm waiting for your response regarding the first point mentioned in the comment above, by "file type", I meant the type of class (whether it's a widget, a model, a data class, etc.).

I have seen the changes made recently and I am also in doubt whether we should merge them or not. It's quite complex.
Obviously we thank you for not only taking the time to do it, but also explaining why many parts were added and the changes you made when we requested them. However, a lot of low-level code is involved to make a feature that it is quite likely that mobile users will not use very frequently.
Above all, it would be even better to create a native package that allows us to listen to keyboard events on mobile devices (which would completely eliminate the need to add all this code just to do the same thing) and create a widget similar to the Focus widget it does. The latter is already quite complicated in itself. I tried to do it but I still need time to be able to do it (I'm not very good with Kotlin code and that has taken its toll on me in not being able to create this package).

I agree with @EchoEllet that this discussion is not a reflection on the OP and the quality of their PR.
We have the highest regard for his contributions and quality of work.

However, this issue has sparked an important milestone in the future of the Flutter Quill project.

What is the future of the Flutter Quill project?

We have an opportunity to decide the future of this project:

Is this an amateur/hobbyist project where things get added without planning for future maintenance and functions get lost or broken?
Or, is this a serious project where programmers can rely on this editor to create projects that are going to be used by millions (hopefully) of end users?

I think this project is a serious project and is worth putting in the effort to make it stable, reliable and dependable.
I agree with @EchoEllet that we need to have a plan. There must be a stable version that people can rely on. It must not have experimental or incomplete functions. There will always be bugs and edge cases where the behavior is incorrect and these need to be fixed on a priority basis. There will always be implementation differences between the platforms supported.
There is also a need to add functionality (because: why are we programmers? - we always want to improve the capabilities of whatever we are working on and it is fun to challenge ourselves the solve impossible problems). But this must not affect the end users who use our programs to do their critical work.
I agree with @EchoEllet

We must make this project 'Stable'
We must fix, or address, all outstanding issues - there are 200 unresolved issues.
We must add unit tests and even integration tests. (Code coverage would be nice but implementing that is a nightmare IMO.)
We must plan, and agree, how new features will be integrated into the project. New features must not be added because one person needs it. Proposed new features must be important to a major proportion of our users. Hooks and callbacks and API are time-tested methods of allowing individual programmers to implement custom actions because, if anything goes wrong, they have the means to fix it without updating the project's code.

I have no idea if this is possible, or even desirable. This community needs to decide.
@EchoEllet has done an admirable job of trying to keep the project organized and understandable. But we all know that we only understand 10% of the current code and many functions are incomprehensible. I have seen many functions that look totally wrong, but I do not know what their purpose is or why the code is used. So, I cannot fix it because I would probably break something.
I understand the complexity and commitment required to achieve this. Implementing this will elevate the project to a whole new level.

Are we up to the challenge?

I'm not very good with Kotlin code and that has taken its toll on me in not being able to create this package

If this issue is only on mobile, I will probably be able to solve it since I'm already familiar with Kotlin, Java, and the JVM platform.
iOS implementation (using Swift) is likely very easy to implement, most of the time I take on Android implementation (regarding my recent PR), I'm not familiar with native iOS and it only take me a few minutes from searching to implementing the feature, see the code difference in #2230 for more details.
I will only need time. Being able to do something doesn't mean we should do it. There are priorities. Updates for Clipboard and Spell checking issues will probably arrive soon.
Regarding the keyboard events, it's also a missing feature.
This comment will be updated soon.

I made my team aware of the problem - we decided we can live without this soft keyboard feature. It would have been a nice UX addition to our app but it doesn't make sense just to fork everything to have it. That said, I'm closing this issue since there is no point in keeping it open and distracting authors of this package from solving more important issues.

I appreciate your understanding, it's unfortunate that we couldn't merge this feature built-in or at least provide a way for users to implement their own custom changes seamlessly, let's assume we have access to native mobile keyboard events, would it require fewer changes to implement?
Looking forward to your future contributions.

I have minimized our comments that are unrelated to the PR. My comments were unnecessarily longer than they should and I wasn't aware of this.

I have minimized our comments that are unrelated to the PR. My comments recently were unnecessarily longer than they should and I wasn't aware of this.


Migrate API token to secure json

Migrate away from local storage for the API token.  Possibly create a Grafana route for security reasons.

After investigating this, I don't think this is feasible unless using the Go plugin SDK.  This might be in a future release.


candy-icons: init at unstable-2023-10-03

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Thanks for contributing to nixpkgs!

Thank you! I have resolved all suggested changes, if there is anything else to solve please let me know!

Hi! I have just accepted the suggestions and organized all commits. I am very thankful for all the help!

Result of nixpkgs-review pr 259294 run on x86_64-linux 1

1 package built:

candy-icons

@clr-cera can you refer the source to the latest commit please?

@clr-cera thanks. Can you squash changing source info to latest commit commit and change the commit message of candy-icons: init at unstable-2023-10-03 to "candy-icons: init at unstable-2023-12-31"?

Thank you for your advice! All suggested changes have been committed and I hope this package can be merged!

Apologies, the closure was accidental.
Can the PR title be updated to the right version?

Apologies, the closure was accidental.
Can the PR title be updated to the right version?

Sure!

@clr-cera can you apply the proposal made by @AndersonTorres ?

Thank you @clr-cera for the update. Can you also squash the last commit?

@h7x4 what is it needed to merge this PR?


Admin Router: Prevent reusing tcp sockets by AR's cache code [1.9]

High-level description
This is a backport of https://github.com/dcos/dcos/pull/2511 to 1.9. Due to the fact that 1.9 is very old and it is impossible to port the test, I am making here only the functional change.
Corresponding DC/OS tickets (obligatory)
These DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:

DCOS-21451 debug and fix for SOAK-68

Related PRs:
EE PR:
1.11 PR: https://github.com/dcos/dcos/pull/2511

@mesosphere-mergebot bump-ee

@mesosphere-mergebot label Ready for review

@mesosphere-mergebot override-status teamcity/dcos/test/azure/arm  https://jira.mesosphere.com/browse/DCOS-21492-

@mesosphere-mergebot override-status teamcity/dcos/test/azure/arm https://jira.mesosphere.com/browse/DCOS-21492

teamcity/dcos/test/aws/cloudformation/simple cannot be overridden with  DCOS-21492 as that is not the core issue in the failure. Rather, the cluster failed to deploy due to somewhat common reasons and we can use this JIRA fore that: https://jira.mesosphere.com/browse/DCOS_OSS-2215

@mesosphere-mergebot teamcity/dcos/test/aws/cloudformation/simple https://jira.mesosphere.com/browse/DCOS_OSS-2215

@mesosphere-mergebot override-status teamcity/dcos/test/aws/cloudformation/simple https://jira.mesosphere.com/browse/DCOS_OSS-2215

@mesosphere-mergebot ship_it_label_status_check


Feature request: Use EPS with raspibolt via internet

Hi,
I just successfully configured my raspibolt to be used as electrum backend and it works flawlessly! Thank you so much for sharing your know-how, it is much appreciated!
Now is it possible (via dyndns or some other stuff) to be able to use my raspibolt as electrum backend when I am out and about, and not only in the local network? If so how would I do that? Can you add a bonus guide?

That should be pretty straight-forward. I just noticed that I did not include the UFW setup in the EPS bonus guide and fixed that.
You just need to extend the protective UFW rule to allow access to port 50002 from everywhere and set up port-forwarding in your router.
$ sudo ufw allow 50002 comment "allow EPS"
$ sudo ufw enable
$ sudo ufw status

Please be aware that this opens an additional attack vector and might make your RaspiBolt vulnerable to DoS attacks. Use at your own risk.

Thanks!

I'm not quite sure how to proceed. I added the rule and I opened a dyndns account which is working(verified by pinging the address and it finds the correct ip and the ping is successfull).
I made port forwards in my router to my raspibolt for the port 50002. When I input my dyndns address and the port 50002 in my electrum wallet it doesn't work tho. Any pointers? Tell me if this is out of scope then I will look elsewhere.

I switched my DynDNS provider and nmap show the port as "filtered" now, not as closed anymore. Still my Electrum wallet can't seem to connect to it despite pinging the dynamic dns name works fine.


Add Revision instance to page_published signal

@kaedroho is this what you had in mind for #1765?

Yep, thanks very much!

Merged in 1a262fe


Fixes for using nested Agents, languse upgrade needed

Summary

Update langfuse to fix errors using nested agents
Improve logger with extra data (datetime, filepath)
Add return_direct to saml schema for SuperagentAgentTool

@elisalimli is trying to run return_direct. Can you test this and see that it works properly?

@elisalimli is this ready?

Hi, just finished testing this this morning, it does seem to be working well.


Verilog output for rem()

I can't believe this hasn't been discovered yet, but I didn't find anything other than #240.
circuit Test :
  module Test :
    input in : UInt<8>
    output out : UInt<1>
    node mod = rem(in, UInt<1>("h0"))
    out <= mod

gives me the following verilog:
wire mod;
assign mod = in % 8'h0;

mod is correctly given width 1, but I think 8'h0 should be 1'h0 (and perhaps the low bit should be extracted from in). Verilator is giving me unpleasant warnings about Operator ASSIGNW expects 1 bits on the Assign RHS, but Assign RHS's MODDIV generates 8 bits in similar rocket code.

This is a problem with firrtl verilog mismatch. Verilog seems to say the width of (a % b) is Max(a, b), whereas firrtl (sensibly) says Min(a, b)


add basic test for requestMatchDetails

Oh wait this is a legit pull req too.  Wonder if the tests will run once I merge it! Lets find out!

Oh wait this is a legit pull req too.  Wonder if the tests will run once I merge it!
Send help!
https://travis-ci.org/RJacksonm1/node-dota2/builds/99670573
  1) Dota2 Matches #requestMatchDetails should fetch data on a given match id:
     Uncaught AssertionError: expected undefined to exist
      at test/test.js:222:28
      at Dota2Client.onMatchDetailsResponse (handlers/match.js:141:19)
      at Object.<anonymous> (handlers/match.js:84:42)
      at SteamGameCoordinator.handlers.(anonymous function) (node_modules/steam/lib/handlers/game_coordinator/index.js:105:28)
      at SteamGameCoordinator.<anonymous> (node_modules/steam/lib/handlers/game_coordinator/index.js:19:28)
      at SteamClient._netMsgReceived (node_modules/steam/lib/steam_client.js:172:10)
      at SteamClient.handlers.(anonymous function) (node_modules/steam/lib/steam_client.js:259:10)
      at SteamClient._netMsgReceived (node_modules/steam/lib/steam_client.js:157:26)
      at Connection._readPacket (node_modules/steam/lib/connection.js:50:8)
      at emitReadable_ (_stream_readable.js:411:10)
      at emitReadable (_stream_readable.js:405:7)
      at readableAddChunk (_stream_readable.js:157:11)
      at Connection.Readable.push (_stream_readable.js:110:10)
      at TCP.onread (net.js:523:20)

shit I merged it and it didn't even work. whoops.
Send help!
https://travis-ci.org/RJacksonm1/node-dota2/builds/99670573
  1) Dota2 Matches #requestMatchDetails should fetch data on a given match id:
     Uncaught AssertionError: expected undefined to exist
      at test/test.js:222:28
      at Dota2Client.onMatchDetailsResponse (handlers/match.js:141:19)
      at Object.<anonymous> (handlers/match.js:84:42)
      at SteamGameCoordinator.handlers.(anonymous function) (node_modules/steam/lib/handlers/game_coordinator/index.js:105:28)
      at SteamGameCoordinator.<anonymous> (node_modules/steam/lib/handlers/game_coordinator/index.js:19:28)
      at SteamClient._netMsgReceived (node_modules/steam/lib/steam_client.js:172:10)
      at SteamClient.handlers.(anonymous function) (node_modules/steam/lib/steam_client.js:259:10)
      at SteamClient._netMsgReceived (node_modules/steam/lib/steam_client.js:157:26)
      at Connection._readPacket (node_modules/steam/lib/connection.js:50:8)
      at emitReadable_ (_stream_readable.js:411:10)
      at emitReadable (_stream_readable.js:405:7)
      at readableAddChunk (_stream_readable.js:157:11)
      at Connection.Readable.push (_stream_readable.js:110:10)
      at TCP.onread (net.js:523:20)

Whew I solved it.  219e5729255da80c1ed73ce4f2a72f613662f6a7 I'm really good.

Whew I solved it.  219e5729255da80c1ed73ce4f2a72f613662f6a7 I'm really good.

And modest, kappa
On 1 Jan 2016 2:30 am, Rob Jackson<EMAIL_ADDRESS>wrote:
Whew I solved it. 219e572 I'm really good.
—
Reply to this email directly or view it on GitHub.

And modest, kappa
On 1 Jan 2016 2:30 am, Rob Jackson<EMAIL_ADDRESS>wrote:
Whew I solved it. 219e572 I'm really good.
—
Reply to this email directly or view it on GitHub.


Mod Support Request

Would you please make vertical slab for :

Blockus
Thank you very much.

Please add me on discord and we can talk about it Hyrlost#6321

Would you please make vertical slab for :

Blockus
Thank you very much.

Please add me on discord and we can talk about it Hyrlost#6321


SIGSEGV during C2 CompileTask

Please provide a brief summary of the bug
Hi, it seems that since we started using eclipse-temurin:21-jdk-noble (21.0.5+11) in our CI (via maven:3-eclipse-temurin-21), we get random JVM crashes during execution of the C2 compiler. It's always with the same trace and always during the compilation of com.fasterxml.jackson.databind.introspect.POJOPropertiesCollector::_addFields.
I didn't find anything resembling this error in the OpenJDK JIRA nor anywhere on the internet :/
Did you test with the latest update version?

[X] Yes

Please provide steps to reproduce where possible
Not sure how, it's quite random
Expected Results
No crash :P
Actual Results
Random crashes :)
What Java Version are you using?
OpenJDK 64-Bit Server VM Temurin-21.0.5+11 (21.0.5+11-LTS, mixed mode, sharing, tiered, compressed oops, compressed class ptrs, g1 gc, linux-amd64)
What is your operating system and platform?
Ubuntu 24.04.1 LTS on x86
How did you install Java?
Docker image maven:3-eclipse-temurin-21
Did it work before?
Yes, I think in the previous version (21.0.4+7) but it's hard to exactly know.
Did you test with other Java versions?
Because it's using a docker image, I don't have a way to use an older version of Java unfortunately, but I will try to find a way to do that next.
Relevant log output
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  SIGSEGV (0xb) at pc=0x00007d5f17168bd9, pid=85, tid=103
#
# JRE version: OpenJDK Runtime Environment Temurin-21.0.5+11 (21.0.5+11) (build 21.0.5+11-LTS)
# Java VM: OpenJDK 64-Bit Server VM Temurin-21.0.5+11 (21.0.5+11-LTS, mixed mode, sharing, tiered, compressed oops, compressed class ptrs, g1 gc, linux-amd64)
# Problematic frame:
# V  [libjvm.so+0xf0dbd9]  BoolNode::Ideal(PhaseGVN*, bool)+0x19
#
# Core dump will be written. Default location: /core.%e.85.%t
#
# If you would like to submit a bug report, please visit:
#   https://github.com/adoptium/adoptium-support/issues
#

---------------  S U M M A R Y ------------

Command Line: -javaagent:/cache/.m2/repository/org/jacoco/org.jacoco.agent/0.8.12/org.jacoco.agent-0.8.12-runtime.jar=destfile=/builds/server/target/jacoco-it.exec -Dmaven.repo.local=/cache/.m2/repository -Xmx8192m -XX:ActiveProcessorCount=2 -Xverify:none --add-opens=java.base/java.io=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.base/java.lang=ALL-UNNAMED /builds/server/target/surefire/surefirebooter9049070912728376033.jar /builds/server/target/surefire 2024-11-07T13-53-41_126-jvmRun1 surefire3272181257269677729tmp surefire_018442978085457632387tmp

Host: AMD EPYC 7B13, 16 cores, 9G, Ubuntu 24.04.1 LTS
Time: Thu Nov  7 14:07:52 2024 UTC elapsed time: 851.233062 seconds (0d 0h 14m 11s)

---------------  T H R E A D  ---------------

Current thread (0x00007d5f100cb350):  JavaThread "C2 CompilerThread0" daemon [_thread_in_native, id=103, stack(0x00007d5eed0b2000,0x00007d5eed1b2000) (1024K)]

Current CompileTask:
C2:851233 108248       4       com.fasterxml.jackson.databind.introspect.POJOPropertiesCollector::_addFields (1097 bytes)

Stack: [0x00007d5eed0b2000,0x00007d5eed1b2000],  sp=0x00007d5eed1ad6d0,  free space=1005k
Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code)
V  [libjvm.so+0xf0dbd9]  BoolNode::Ideal(PhaseGVN*, bool)+0x19
V  [libjvm.so+0xd5acfe]  PhaseIterGVN::transform_old(Node*)+0x9e
V  [libjvm.so+0x6b30e0]  Conv2BNode::Ideal(PhaseGVN*, bool)+0x180
V  [libjvm.so+0xd5acfe]  PhaseIterGVN::transform_old(Node*)+0x9e
V  [libjvm.so+0xd56c19]  PhaseIterGVN::optimize()+0xf9
V  [libjvm.so+0x67072f]  Compile::Optimize()+0xf9f
V  [libjvm.so+0x671e66]  Compile::Compile(ciEnv*, ciMethod*, int, Options, DirectiveSet*)+0xf26
V  [libjvm.so+0x597fbb]  C2Compiler::compile_method(ciEnv*, ciMethod*, int, bool, DirectiveSet*)+0x18b
V  [libjvm.so+0x67833e]  CompileBroker::invoke_compiler_on_method(CompileTask*)+0xc9e
V  [libjvm.so+0x67b538]  CompileBroker::compiler_thread_loop()+0x6a8
V  [libjvm.so+0x92a798]  JavaThread::thread_main_inner()+0x1d8
V  [libjvm.so+0xf7eeb8]  Thread::call_run()+0xa8
V  [libjvm.so+0xd08a8a]  thread_native_entry(Thread*)+0xda
C  [libc.so.6+0x9ca94]

@victornoel which version of Jackson are you usin and do you experience these crashes with Jacoco diasble?

Hi @karianna, sorry for the delay.
So what I can already tell is that with 21.0.4+7 we don't get the problem (the CI has been using it for 4-5 days).
We use Jackson 2.17.2 (and seen it happen with 2.17.1 too.
We do use jacoco (0.8.11) indeed, and I haven't had the opportunity to test without it, but I will try to set that up as soon as I can.

Thanks @victornoel - It could well be a genuine 21.0.5 bug, but it could also be a genuine 21.0.5 C2 change that jacoco needs to adjust for (this is a not uncommon problem with trivial versions of Java and tools like it).  If we can eliminate jacoco then it's easire for me to get this properly looked at upstream :-)

I have setup a jacoco-less CI pipeline that runs regularly using maven:3-eclipse-temurin-21, we will see how it behaves after a few days :)

Hello! I have the same issue in my company's pipeline after making a refactor on the code. Our GitHub action workers with temurin 21.0.5+11 have been upgraded on Friday and we started seeing issues right away on one of the two PRs.
It happens in 90% of the executions of the pipeline for the refactored code. Unfortunately, I can't provide it due to privacy policies, but if I am able to reproduce it, I'll let you know. Cheers!

@vzedano hi, since you are so "lucky" that it fails often, would you mind checking if it fails with jacoco disabled (if you use it)? Is it also using Jackson and falling on the same place as in my report? Thanks

Hi @karianna, after a week of running latest jdk 21 with jacoco disabled, I did not see the issue appear. What would be the next step then? Thanks!

@victornoel - I'd report this to the Jacoco team in that case.  https://groups.google.com/g/jacoco

@karianna will do, thx for all the help! I will report back here before closing this ticket.

I created https://github.com/jacoco/jacoco/issues/1801 and also posted a message in the ML.

Hey @karianna, so I'm here acting just as a messenger (:P), it seems that jacoco people are happy to help us finding the problem, but they basically say (see https://github.com/jacoco/jacoco/issues/1801#issuecomment-2502362021) that they don't see how they could fix this in jacoco to avoid such a bug because jacoco is about bytecode enhancement.
They did say that many time in the past helped track down JDK bugs and so they can help. Luckily it seems that @Godin may have also encountered that issue at its job but it's hard to reproduce. Ideally if we can get output from a fastdebug build of the JDK, that would greatly help.
Do you know if we have such an image at adoptium? Cheers

++


Can we create a new exception type when Password is Null/Missing?

Currently, when a password is null or empty, the following is thrown:
throw new ZipException("empty or null password provided for AES decryption");
Other exceptions have a type associated except for this one. It would be useful to have a "PASSWORD_EMPTY" zip exception type, or something along those lines.

Sure. I will add it.

Actually, after analysing the code, I will reuse the WRONG_PASSWORD type for this case as well. ZipStandardDecrypter throws this type of exception when the password is empty. Doing the same for AesDecrypter will keep this behaviour consistent.

Fixed in v2.9.1 released today.


npm install freezes at node-sass and can't run npm start

When I run npm install, the installation process somehow freezes at
<EMAIL_ADDRESS>install /Users/yangfan/Development/Javascript/react-slingshot/node_modules/node-sass
node scripts/install.js
And I have to ctrl+c to terminate the process
After that if I try to run npm start, it will give me this error:

/usr/local/lib/node_modules/babel/node_modules/babel-core/lib/transformation/file/options/option-manager.js:126
if (!option) this.log.error("Unknown option: " + alias + "." + key, ReferenceError);
^

TypeError: Cannot read property 'error' of undefined

(the caret above is point to  this.log)
Not sure if this is my setting issue.
I am running on Mac OS X

This issue is gone after remove the whole directory and clone it again

Yes, this sort of issue can occur if you install new packages without removing references to old (potentially conflicting) packages. For instance, this can happen when you do this:

git pull
npm install

Why? Because there might have been a conflicting version of some package in node_modules. Your solution of wiping out node_modules works. An alternative that often works: npm prune.


fix comments spelling mistake

What type of PR is this?

/kind documentation

What this PR does / why we need it:
Fixes comments spelling mistake in flexvolumedriver.go
Which issue(s) this PR fixes:

https://github.com/kubernetes-csi/drivers/issues/162
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

I signed it

/assign @lpabon


Avoid commiting build folder into upstream

Hey @mcnamee,
It's me again, another small improvement here:
You don't need to commit the build folder neither have the bash script. I would recommend to use gh-pages as CLI and previously run the build.
The same way as CRA have documented to Deploy their app to Github Pages: https://facebook.github.io/create-react-app/docs/deployment#step-2-install-gh-pages-and-add-deploy-to-scripts-in-packagejson

Looks like a great option, thanks @davesnx


physical_processor information missing

Earlier we used to get physical_processor value populated with something like "Intel Xeon family" for some of the instances like "t2.micro".
Why this is null now for all instances?

Closed by #389


Fs 4105 cof eoi form page missing if user selects yes

https://dluhcdigital.atlassian.net/browse/FS-4105
https://dluhcdigital.atlassian.net/browse/FS-4122
https://dluhcdigital.atlassian.net/browse/FS-4085
https://dluhcdigital.atlassian.net/browse/FS-4084
Description
EOI forms bug fixes

@RamuniN Can you change the title please as this PR is referencing several tickets. Otherwise looks all good to me.


Publish events related to Journeys

Allows developers to add event listeners for the following Journey events:

willNotShowJourney
willShowJourney
didShowJourney
didClickJourneyCTA
didClickJourneyContinueCTA
didClickJourneyClose
willCloseJourney
didCloseJourney

Example Usage:
var listener = function(event) { console.log(event); }
branch.addListener('didClickJourneyCTA', listener);

@jsaleigh review and give some feedback?

@rubinsingh just a couple of minor things. Also, it would be a good idea to update the comments in 6_branch starting at line 1464 to represent the new listeners.

@rubinsingh you should only update the comments in 6_branch. The other ones get auto-generated

👍


Translation string missing: short source descriptions

seems to be hardcoded in psgeo.

What do you refer to when you say source descriptions?
(Background info btw: I changed the psgeolang.js code so that it will give the short description if one exists, but will not fail if it doesn't exist.)

(Background info btw: I changed the psgeolang.js code so that it will give the short description if one exists, but will not fail if it doesn't exist.)

Good bug fix

psgeo.js:
const psgeoSourcesPlain
const psgeoSourcesSwimming
const psgeoSourcesCaving
const psgeoSourcesCavingTest
const psgeoSourcesLuolaseura

all these have a

name: { en: "english-text", fi: "finnish-text" }, // but no swedish or any other for that matter
longName similarly

const psgeoFinnishCaveClassification
has a link for english and finnish language sites, but no other languages are conted in
All these should use psgeolang.js

Fixed.

Saw the changes. Nice fix. Thanks!


StackOverflowError: null at org.scalactic.ObjectDiffer.difference

We have a test that is sometimes failing with a huge stack trace starting with:
sbt.ForkMain$ForkError: sbt.ForkMain$ForkError: java.lang.StackOverflowError: null
	at java.lang.Class.getDeclaredFields(Class.java:1915)
	at org.scalactic.source.ObjectMeta$$anon$1.privFields$lzycompute(ObjectMeta.scala:36)

complete stacktrace at https://gist.github.com/yanns/6bcd708be2e7bbf73655449548036efb

I could not figure out what piece of code is producing that.
Any ideas / pointers would be welcome.

Some experiments are showing that this might be related to the JVM version.
Trying with the JVM 12 seems to fix the issue.
I'll update this issue if I can confirm that.


CreateSrsMedia.ps1 cannot process if Microsoft.PowerShell_profile.ps1 is present and contains actionable content

CreateSrsMedia.ps1 (1.5.1 and 1.6.0 tested) as provided here: https://docs.microsoft.com/en-us/microsoftteams/rooms/console#prepare-the-installation-media produces the following error if the user executing the script has Microsoft.PowerShell_profile.ps1 present in Documents\WindowsPowerShell and it contains actionable commands:
PS C:\Users\*****\Teams Rooms CreateSrsMedia> powershell.exe -noprofile -executionpolicy unrestricted -file .\CreateSrsMedia.ps1 -verbose
Transcript started, output file is C:\Users\*****\OneDrive - *****\Documents\PowerShell_transcript.S*****.EZGbDWYz.20200728163731.txt
Host OS version 10.0.19041.330
Script version 1.6.0
Downloading CreateSrsMedia... done
Validating signature for update.ps1... success.
Transcript stopped, output file is C:\Users\*****\OneDrive - *****\Documents\PowerShell_transcript.S*****.EZGbDWYz.20200728163731.txt
C:\Users\*****\Teams Rooms CreateSrsMedia\CreateSrsMedia.ps1 : Cannot convert the "System.Object[]" value of type "System.Object[]" to type "System.Version".
    + CategoryInfo          : MetadataError: (:) [CreateSrsMedia.ps1], ArgumentTransformationMetadataException
    + FullyQualifiedErrorId : RuntimeException,CreateSrsMedia.ps1

Full transcript:
**********************
Windows PowerShell transcript start
Start time:<PHONE_NUMBER>1726
Username: AzureAD\*****
RunAs User: AzureAD\*****
Configuration Name:
Machine: S***** (Microsoft Windows NT 10.0.19041.0)
Host Application: powershell.exe
Process ID: 36272
PSVersion: 5.1.19041.1
PSEdition: Desktop
PSCompatibleVersions: 1.0, 2.0, 3.0, 4.0, 5.0, 5.1.19041.1
BuildVersion: 10.0.19041.1
CLRVersion: 4.0.30319.42000
WSManStackVersion: 3.0
PSRemotingProtocolVersion: 2.3
SerializationVersion: <IP_ADDRESS>
**********************
Transcript started, output file is C:\Users\*****\OneDrive - *****\Documents\PowerShell_transcript.S*****.bt01OfaZ.20200728161726.txt
Host OS version 10.0.19041.330
Script version 1.6.0
Downloading CreateSrsMedia...
done
Validating signature for update.ps1...
success.
**********************
Windows PowerShell transcript end
End time:<PHONE_NUMBER>1730
**********************

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6f8b204f-9650-d268-8566-7a75ba0a1b6a
Version Independent ID: 9a963e63-6716-7522-8abe-c8a407d3a46d
Content: Configure a Microsoft Teams Rooms console - Microsoft Teams
Content Source: Teams/rooms/console.md
Service: msteams
GitHub Login: @LanaChin
Microsoft Alias: v-lanac

@SteveZerrSourced Thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.


adding support for hardware wallets

added this part to the code:
const walletChecks = [
{ checkName: 'derivationPath' },
{ checkName: 'accounts' },
{ checkName: 'connect' },
{ checkName: 'network' },
{ checkName: 'balance', minimumBalance: '1000000' }
]

https://streamable.com/w4vt3l


Transfer Learning Guide

What does this PR do?
Adds a Transfer Learning guide which includes:

Loading a pre-trained model
Doing parameter surgery
Freezing layers and implementing Differential Learning Rates using optax.multi_transform

Live preview: https://flax--2394.org.readthedocs.build/en/2394/guides/transfer_learning.html
Notes

I couldn't use vit_jax because jax versions conflict, so I used a model from HuggingFace's transformers library. Only quirk here is that transformers downgrades jax so a fix is added to upgrade it on CI.
Expanded guide with complete example moved to #2429

Codecov Report

Merging #2394 (c256185) into main (82daae3) will decrease coverage by 0.37%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2394      +/-   ##
==========================================
- Coverage   69.76%   69.38%   -0.38%
==========================================
  Files          62       63       +1
  Lines        5493     5566      +73
==========================================
+ Hits         3832     3862      +30
- Misses       1661     1704      +43

Impacted Files
Coverage Δ

flax/traverse_util.py
99.03% <100.00%> (+0.04%)
:arrow_up:

flax/training/common_utils.py
0.00% <0.00%> (ø)

flax/training/dynamic_scale.py
0.00% <0.00%> (ø)

flax/linen/linear.py
97.50% <0.00%> (+0.05%)
:arrow_up:

flax/metrics/tensorboard.py
92.77% <0.00%> (+1.46%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Hey @jheek, using jupytext we are syncing the .ipynb and .md files, the .ipynb will be rendered but the .md are there to ease the review process.

@8bitmp3 thanks a lot for the feedback! It was really useful, I've made the stylistic changes and will keep them in mind for future guides.

Reviewed and updated in https://github.com/cgarciae/flax/pull/1. LMKWYT!


browser.pause() is not working. It waits forever.

Environment:
Node version - any (tried 0.10.32, 0.12.0 and 0.12.2)
Protractor 2.0.0
Selenium (2.45.0) and Chromedriver 2.14
Config:
exports.config = {
seleniumServerJar:'/usr/local/lib/node_modules/webdriver-manager/selenium/selenium-server-standalone-2.45.0.jar',
chromeDriver : '/usr/local/lib/node_modules/webdriver-manager/selenium/chromedriver',
specs:['../firstSpec.js']
};
Command:
./node_modules/.bin/protractor test/conf/protractor.conf.js
When I run my tests, it says starting debugger but never takes me to console, it waits forever. Tried assigning different port numbers still no luck.

Protractor 1.8.0 and Node 0.10.32 seems to be fine though.

Encountered this myself last night. It's because of some breaking changes in webdriver 2.45.0

Fixed here: https://github.com/angular/protractor/pull/2046

fix is merged and will be released in the next version

2.1 is out.


[Feature request] Can you develop a Windows desktop?

Hello, This project is excellent. can you develop the desktop side?

Hi, thank you! I have already answered here

@BlueBlue7891
There is cross platform library for that on java...
checkout :
https://github.com/eix128/WhisperJET


Fix/scr hard coded password

Description
Part of SCR fixes:
Remove hardcoded db credentials from .env.development
Motivation and Context
[Explain the motivation or the context behind this pull request. Why is it necessary?]
Type of Change

chore: Routine tasks, maintenance, or tooling changes

How to Test
[Provide clear instructions on how to test and verify the changes introduced by this pull request, including any specific unit tests you have created to demonstrate your changes.]
Checklist
Please check all the boxes that apply to this pull request using "x":

[ ]  I have tested the changes locally and verified that they work as expected.
[ ]  I have added or updated the necessary documentation (README, API docs, etc.).
[ ]  I have added appropriate unit tests or functional tests for the changes made.
[ ]  I have followed the project's coding conventions and style guidelines.
[ ]  I have rebased my branch onto the latest commit of the main branch.
[ ]  I have squashed or reorganized my commits into logical units.
[ ]  I have added any necessary dependencies or packages to the project's build configuration.
[ ]  I have performed a self-review of my own code.
[ ]  I have read, understood and agree to the Developer Certificate of Origin below, which this project utilises.

Screenshots (if applicable)

Console log messages when spinning up apigw
Additional Notes
[Add any additional information or context that might be relevant to reviewers.]

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
   have the right to submit it under the open source license
   indicated in the file; or

(b) The contribution is based upon previous work that, to the best
   of my knowledge, is covered under an appropriate open source
   license and I have the right under that license to submit that
   work with modifications, whether created in whole or in part
   by me, under the same open source license (unless I am
   permitted to submit under a different license), as indicated
   in the file; or

(c) The contribution was provided directly to me by some other
   person who certified (a), (b) or (c) and I have not modified
   it.

(d) I understand and agree that this project and the contribution
   are public and that a record of the contribution (including all
   personal information I submit with it, including my sign-off) is
   maintained indefinitely and may be redistributed consistent with
   this project or the open source license(s) involved.

A couple of API-GW unit tests might fail at times because mock data generator seems to create duplicate properties in some objects where there should not be. Will investigate and fix this in separate PR.
Portal coverage changes and some lint fixes will be done in separate PR

Authentication Error Test Case Validated:

Username and Password Not Found in .env:

Frontend Testing For Docker Passed

Smoke Test For Docker Passed
Smoke Test Report For Docker.zip

Pipeline Testing For Docker Passed
Pipeline Testing For Docker.zip


Pick up build strategy knowledge from BuildStrategy API

https://github.com/redhat-developer/build/blob/master/pkg/controller/build/build_controller.go#L115

Design the API
Update Controller to generate task from the BuildStrategy object
Potentially delete https://github.com/redhat-developer/build/blob/master/pkg/controller/build/buildpacksv3.go and https://github.com/redhat-developer/build/blob/master/pkg/controller/build/s2igo ?

Making use of https://github.com/otaviof/tekton-pipeline-chart/blob/672961906029b9c5a4c6a0f0051c3655bed64dc9/templates/10-task.yaml & https://github.com/otaviof/tekton-pipeline-chart/blob/672961906029b9c5a4c6a0f0051c3655bed64dc9/templates/_steps-buildpacks.tpl & https://github.com/otaviof/tekton-pipeline-chart/blob/672961906029b9c5a4c6a0f0051c3655bed64dc9/values-custom.yaml
I could come up with this:
apiVersion: build.dev/v1alpha1
kind: BuildStrategy
metadata:
  name: custom-buildpacks-v3-strategy
spec:
  source:
    name: repository
    type: git
  steps:
    - name: prepare
      image: alpine
      securityContext:
        runAsUser: 0
      command:
        - /bin/sh
      args:
        - -c
        - chown -R "1000:1000" "/workspace/{{ source.name }}" #from the same YAML
    - name: detect
      image: {{ build.builderImage }} #from Build CR
      securityContext:
        runAsUser: 1000
      command:
        - /cnb/lifecycle/detector
      args:
        - -log-level=debug
        - -app=/workspace/{{ source.name }} #from the same YAML
        - -group=/layers/group.toml
        - -plan=/layers/plan.toml
      volumeMounts:
        - name: layers-dir
          mountPath: /layers
    - name: analyze
      image: $BUILDER_IMAGE
      securityContext:
        runAsUser: 1000
      command:
        - /cnb/lifecycle/analyzer
      args:
        - -log-level=debug
        - -layers=/layers
        - -group=/layers/group.toml
        - {{ build.outputImage }} #from Build CR
      volumeMounts:
        - name: layers-dir
          mountPath: /layers
    - name: restore
      image: {{ build.outputImage }} #from Build CR
      securityContext:
        runAsUser: 1000
      command:
        - /cnb/lifecycle/restorer
      args:
        - -log-level=debug
        - -group=/layers/group.toml
        - -layers=/layers
        - -path=/cache
      volumeMounts:
        - name: cache-dir
          mountPath: /cache
        - name: layers-dir
          mountPath: /layers
    - name: build
      image: {{ build.outputImage }} #from Build CR
      securityContext:
        runAsUser: 1000
      command:
        - /cnb/lifecycle/builder
      args:
        - -app=/workspace/{{ source.name }}
        - -layers=/layers
        - -group=/layers/group.toml
        - -plan=/layers/plan.toml
      volumeMounts:
        - name: layers-dir
          mountPath: /layers

And similarly,
apiVersion: build.dev/v1alpha1
kind: BuildStrategy
metadata:
  name: custom-s2i-strategy
spec:
  source:
    name: repository ## eventually gets mapped into a Task.Spec.Resources[0]
    type: git
  steps:
    - name: s2i-build-as-dockerfile
      image: otaviof/s2i:latest
      workingDir: /workspace/{{ source.name }}  #from the same YAML
      args:
        - build
        - .
        - {{ build.builderImage }} #from Build CR
        - otaviof/nodejs-ex:latest
        - --as-dockerfile=Dockerfile
    - name: buildah-bud
      image: quay.io/buildah/stable:latest
      workingDir: /workspace/{{ source.name }}  #from the same YAML
      args:
        - buildah
        - bud
        - --tag="otaviof/nodejs-ex:latest"
        - /workspace/{{ source.name }}  #from the same YAML

Do we need BuildStrategy and ClusterBuildStrategy to allow both cluster-scope and namespace-scoped strategies?

I'm avoiding ClusterBuildStrategy to begin with.
In the current state of the API,
you can specify the namespace, optionally. if not specified, we look for it in the same namespace. but we could change what the default behaviour is.
  # Strategy defined in the buildpacks-v3 CR
  # in the 'openshift' namespace.
  strategy:
    name: "buildpacks-v3"
    namespace: "openshift"

Full CR
apiVersion: build.dev/v1alpha1
kind: Build
metadata:
  name: example-build-buildpack
spec:
  # Git Source definition
  source:
    url: https://github.com/sclorg/nodejs-ex
    credentials:
      name: github-auth-sbose78

  # Strategy defined in the buildpacks-v3 CR
  # in the 'openshift' namespace.
  strategy:
    name: "buildpacks-v3"
    namespace: "openshift"

  # Build to be run in this image.
  builderImage: "cloudfoundry/cnb:bionic"

  # Generated image.
  output:
    image: "image-registry.openshift-image-registry.svc:5000/sbose/nodejs-ex"
    credentials:
      name: github-auth-sbose78

This was discussed for Tekton as well but community opted for 'Task'/'ClusterTask', 'TriggerBinding'/'ClusterTriggerBidning', etc to avoid the RBAC issues when referencing another namespace. The other argument was that this pattern of referencing a resource in a different namespace generally does not exist on Kubernetes and there too are separate objects for 'Role'/'ClusterRole', 'RoleBinding'/'ClusterRoleBinding'.
The other issue with referencing a namespace is what we have with imagestreams and templates: one would not know what is available on the cluster unless they are aware of the special treatment the 'openshift' namespace gets.

This was discussed for Tekton as well but community opted for Task/ClusterTask, TriggerBinding/ClusterTriggerBidning, etc to avoid the RBAC issues when referencing another namespace. The other argument was that this pattern of referencing a resource in a different namespace generally does not exist on Kubernetes and there too are separate objects for Role/ClusterRole, RoleBinding/ClusterRoleBinding.

I was trying to keep the number of APIs/CRDs low, without a very strong opinion.
However, if you have your weight behind this, I'm Okay with have with a ClusterBuildStrategy 👍

The other issue with referencing a namespace is what we have with imagestreams and templates: one would not know what is available on the cluster unless they are aware of the special treatment the 'openshift' namespace gets.

Agreed, and vanilla Kubernetes will not even have such a namespace.

That’s a valid point too. Shall we just have a cluster-scope strategy for now and gauge the interest for a namespace-scoped one?

Yup, we could do that.

Hi @siamaksade or @sbose78 ,
We also require this ClusterBuildStrategy feature. And I think there is a valid case :)
I saw your build spec definition is:
  // StrategyRef refers to the BuildStrategy to be used to
  // build the container image.
  // Note: Using metav1.ObjectMeta  instead of corev1.LocalObjectReference
  // because the BuildStrategy may or may not be in the same namespace.
  StrategyRef metav1.ObjectMeta `json:"strategy"`

Our platform is a multi-tenants platform.

It means we cannot create all same buildstrategies in each tenant namespaces.
And it is also not good that a build in a namespace calls the buildstrategy in another namespace.

I also suggest that do the samiliar way like Tekton (Such as Task and ClusterTask) that:

Provide a BuildStrategy and ClusterBuildStrategy
Refine the StrategyRef from metav1.ObjectMeta to a new StrategyRef type like :

type StrategyRef struct {
	// Name of the referent; More info: http://kubernetes.io/docs/user-guide/identifiers#names
	Name string `json:"name,omitempty"`
	// StrategyKind inficates the kind of the buildstrategy, namespaced or cluster scoped.
	Kind StrategyKind `json:"kind,omitempty"`
	// API version of the referent
	// +optional
	APIVersion string `json:"apiVersion,omitempty"`
}

Then provide the addtional logic in build controller retrieveCustomBuildStrategy method to get differnt types of the buildstrategy:

if tr.Spec.StrategyRef != nil && tr.Spec.StrategyRef.Kind == v1alpha1.ClusterBuildStrategyKind {
  ...
  buildStrategyInstance = fake_get_from_cluster_scope()
} else {
  ...
  buildStrategyInstance = fake_get_from_namespaced_scope()
}

I am not sure did you start developing this feature?
Because this is a blocker of our design, if doesn't start, we can pick up and do it soon.
Pls let me know if you have any suggestion or comment :)

Hey! Thank you!
I haven't started working on it, please go ahead. I would suggest you have a PR open early so that we can collaborate?

Sure thing @sbose78 ,
I will prepare the PR which follow by the above flow this week.
And will let you know or discuss the PR later together.

Hi @sbose78 ,
I provided a PR (https://github.com/redhat-developer/build/pull/62) for this new ClusterBuildStrategy support. The introduction is in the PR comment. Please review and let me know if you have any comment or idea, or we have have a quick call or meeting to review or discuss the PR.
BTW, during the development, I also see there are some improvements that we can do, such as:

Add API validation
Add API default setting (Such as set default value for the optional parameters)
Add operator-sdk fake client for deep test coverage in controller unit test (https://github.com/operator-framework/operator-sdk/blob/master/doc/user/unit-testing.md)
If it is possible to generate the TaskRun name instead of using the hardcode name from build name, so that can store more build log?
There is a problem when executing function applyCredentials, if there is a wrong or bad secret in the serviceaccount, this func won't update the secrets in sa, and always report error and end-user is hard to know the real problem

Now we are verifying running build v2 on our platform. If possible, we can also have some discussions, and we can help improve them one by one.


.pre-commit-config.yaml

Following the ROSE convention, the conventional commit should be used.
The .pre-commit-config.yaml can integrate a solution such as Commitizen
repos:
  - repo: https://github.com/commitizen-tools/commitizen
    rev: v2.40.0
    hooks:
      - id: commitizen
        stages:
          - commit-msg

I feel like it outside the scope of the IaC guidelines and highly depends on the project context contribution guidelines.


Cmake error

`sudo cmake -B build .
CMake Error at CMakeLists.txt:21 (find_package):
By not providing "Findimgui.cmake" in CMAKE_MODULE_PATH this project has
asked CMake to find a package configuration file provided by "imgui", but
CMake did not find one.
Could not find a package configuration file provided by "imgui" with any of
the following names:
imguiConfig.cmake
imgui-config.cmake

Add the installation prefix of "imgui" to CMAKE_PREFIX_PATH or set
"imgui_DIR" to a directory containing one of the above files.  If "imgui"
provides a separate development package or SDK, be sure it has been
installed.
-- Configuring incomplete, errors occurred!`

https://github.com/AlexAltea/orbital/issues/83


[Feature]: CFServiceInstance names should be unique within a space

Blockers/Dependencies
No response
Background
As an API Client
I want Service Instance names to be unique within a given Space
So that I can use existing API filters (like GET /v3/service_instances?names=my-service&space_guids=7354c643-1ea8-4001-b718-f5d45aa9107a to reliably fetch a single Service Instance
Acceptance Criteria
Applying a duplicate CFServiceInstance CR
GIVEN I have created a CFServiceInstance in a namespace
WHEN I try to create another CFServiceInstance with the same spec.name
THEN I the second CFServiceInstance is rejected for being invalid
Via the APIs
GIVEN I have an existing Service Instance
WHEN I try to create another Service Instance with the same name via POST /v3/service_instances
THEN I get back a 422 error
{
  "errors": [
    {
      "code": 10008,
      "detail": "The service instance name is taken: my-service-2.",
      "title": "CF-UnprocessableEntity"
    }
  ]
}

Dev Notes
See how we handle name uniqueness on apps as the logic should map directly here.

Oh might have closed this early before someone else had a chance to review the A/C. Reopening.


[5.3] Diagnose exclusivity in the presence of coroutines.

Potentially source breaking: SR-11700 Diagnose exclusivity violations
with Dictionary.subscript._modify:
Exclusivity violations within code that computes the default
argument during Dictionary access are now diagnosed.
struct Container {
   static let defaultKey = 0

   var dictionary = [defaultKey:0]

   mutating func incrementValue(at key: Int) {
     dictionary[key, default: dictionary[Container.defaultKey]!] += 1
   }
}
error: overlapping accesses to 'self.dictionary', but modification requires exclusive access; consider copying to a local variable
     dictionary[key, default: dictionary[Container.defaultKey]!] += 1
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
note: conflicting access is here
     dictionary[key, default: dictionary[Container.defaultKey]!] += 1
                              ~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~

This reworks the logic so that four problems end up being fixed:
Fixes three problems related to coroutines:
(1) DiagnoseStaticExclusivity must consider begin_apply as a user of accessed variables. This was an undefined behavior hole in the diagnostics.
(2) AccessedSummaryAnalysis should consider begin_apply as a user of accessed arguments. This does not show up in practice because coroutines don't capture things.
(3) AccessedSummaryAnalysis must consider begin_apply a valid user of
noescape closures.
And fixes one problem related to resilience:
(4) AccessedSummaryAnalysis must conservatively consider arguments to external functions.
Fixes rdar://problem/56378713 Investigate why AccessSummaryAnalysis is crashing
(cherry picked from commit 6823b100a74b9841dfa339a9eab626df813ec37e)

@swift-ci test

@swift-ci test

Build failed
Swift Test Linux Platform
Git Sha - 56b457048779f27d0082acaea93d6277b39affa0

@swift-ci test

@shahmishal I'm not sure why OS X testing won't kick off

Build failed
Swift Test OS X Platform
Git Sha - 56b457048779f27d0082acaea93d6277b39affa0


Constant ReadAsset errors since upgrade ThemeKit today

Anytime I'm running themekit today after updating to the latest version on a non-M1 MacBook Pro Intel:
I now get this error when everything has been working fine for months.
[development] error loading /Users/ck/Documents/repos/OruKayak/snippets: readAsset: open /Users/ck/Documents/repos/OruKayak/Users/ck/Documents/repos/OruKayak/snippets: no such file or directory
1
If I save 5x times the error goes away and the theme is updated, but it comes back with each new file I modify.
Yes all the files exist.

I experience the same issue after the update.
macOS V11.1
It randomly happens after I run theme watch
13:29:35 [development] processing /Users/zerg/Work/fr/bajio-theme/theme/assets [development] error loading /Users/zerg/Work/fr/bajio-theme/theme/assets: readAsset: open /Users/zerg/Work/fr/bajio-theme/theme/Users/zerg/Work/fr/bajio-theme/theme/assets: no such file or directory

I experience the same issue after the update.
macOS V11.1
It randomly happens after I run theme watch
13:29:35 [development] processing /Users/zerg/Work/fr/bajio-theme/theme/assets [development] error loading /Users/zerg/Work/fr/bajio-theme/theme/assets: readAsset: open /Users/zerg/Work/fr/bajio-theme/theme/Users/zerg/Work/fr/bajio-theme/theme/assets: no such file or directory

dup of https://github.com/Shopify/themekit/issues/885

dup of https://github.com/Shopify/themekit/issues/885


Toast max-width is width and padding-y is not set for body

The $toast-max-width Sass variable is mapped to the width property:
https://github.com/twbs/bootstrap/blob/d05c42a3979be30efc7a932c3c0f483098841b19/scss/_toasts.scss#L19
The $toast-padding-y Sass variable is mapped to the toast-header class, but not to the toast-body class:
https://github.com/twbs/bootstrap/blob/d05c42a3979be30efc7a932c3c0f483098841b19/scss/_toasts.scss#L68
(only x is being applied)

Not saying that it is normal or not but just for information for the one who will study/tackle this issue: it was already the case before the integration of CSS vars.

Both of these are intentional based on the project history. We didn't want to break existing Sass variables, so we kept them as-is and changed their property. Not the best, but easier than removing or deprecating.
As for the padding, for the toast body yes I wanted increased padding so I assigned the -x padding to all sides.

We can clean this up in v6 btw :).


Roaming data not working at all for ApplicationData sample.

I have deployed the sample on my Surface Pro 4 and my Lumia 950. I followed the in-app instructions for scenario 6 (High priority), but I do not see any syncing of data between my phone and surface. Does this API actually work?

I've asked the feature team to investigate.


Server panic in 0.9.0 on show series, causes rollback with data lost

I just installed 0.9.0 and was running some tests on it to see how it behaved.   I am using the Go InfluxDB client (rc33, didn't see a tag for 0.9.0...) .  I should note I'm a novice Go dev, so my client code is less than perfect, but it basically tries to insert a whole bunch of events extracted from a JSON file.  These events have timestamps, so I am setting the Time in the insert as well.
I just inserted a bunch of entries which were showing up in the web interface, but when I tried to query them, Influx crashed and apparently rolled back the insert.
Here is some of the influxdb.log:
[http] 2015/06/14 20:35:00 <IP_ADDRESS> - root [14/Jun/2015:20:35:00 -0700] POST /write?consistency=&db=test&precision=&rp=default HTTP/1.1 500 55 - InfluxDBClient 8097b3af-130f-11e5-801c-000000000000 2.860268ms
[http] 2015/06/14 20:36:52 <IP_ADDRESS> - - [14/Jun/2015:20:36:52 -0700] GET /query?u=root&p=root&q=show%20series&db=test HTTP/1.1 200 211 http://<IP_ADDRESS>:8083/ Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/40.0.2214.91 Safari/537.36 c309eace-130f-11e5-801d-000000000000 1.613299ms
panic: runtime error: invalid memory address or nil pointer dereference
	panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xb code=0x1 addr=0x1 pc=0x70adc1]

goroutine 332 [running]:
github.com/boltdb/bolt.(*Tx).Rollback(0x0, 0x0, 0x0)
	/root/.gvm/pkgsets/go1.4.2/global/src/github.com/boltdb/bolt/tx.go:210 +0x31
github.com/influxdb/influxdb/tsdb.(*LocalMapper).Close(0xc20812cc60)

There are a bunch more stack traces all related to this Rollback (I think).  The startup looks like this:
created by github.com/influxdb/influxdb/tsdb.(*QueryExecutor).ExecuteQuery
	/root/.gvm/pkgsets/go1.4.2/global/src/github.com/influxdb/influxdb/tsdb/query_executor.go:211 +0x22b
GOMAXPROCS set to 2
2015/06/14 20:41:52 [INFO] raft: Node at <IP_ADDRESS>:8088 [Follower] entering Follower state
2015/06/14 20:41:52 read local node id: 1
2015/06/14 20:41:53 [WARN] raft: Heartbeat timeout reached, starting election
2015/06/14 20:41:53 [INFO] raft: Node at <IP_ADDRESS>:8088 [Candidate] entering Candidate state
2015/06/14 20:41:53 [DEBUG] raft: Votes needed: 1
2015/06/14 20:41:53 [DEBUG] raft: Vote granted. Tally: 1
2015/06/14 20:41:53 [INFO] raft: Election won. Tally: 1
2015/06/14 20:41:53 [INFO] raft: Node at <IP_ADDRESS>:8088 [Leader] entering Leader state
2015/06/14 20:41:53 [INFO] raft: Disabling EnableSingleNode (bootstrap)
2015/06/14 20:41:53 [DEBUG] raft: Node <IP_ADDRESS>:8088 updated peer set (2): [<IP_ADDRESS>:8088]
2015/06/14 20:41:53 [DEBUG] raft: Node <IP_ADDRESS>:8088 updated peer set (2): [<IP_ADDRESS>:8088]
[httpd] 2015/06/14 20:41:56 listening on HTTP: [::]:8086

Not sure what is causing the issue, and I'm not exactly sure how much to put in this issue, so please ask if you need more detail.

Looking around, this may be the same as #2971, not sure as I didn't test the command line.

@ckmaresca I think this is fixed in v0.9.0 - I couldn't reproduce it. If you can, see if you can give us some more steps to recreate.


Database backup/ restore scenarios

Hi,
I have a question about Dexie.js  for restoring and backing up databases. lets imagine we have at least 2 GB database (for offline map data) and they have a (key,value) structure which Key is an string and value is blob (image or binary vector data).
So in my scenario users select a database and my web application should start to download that database for them for offline access. So what approach do you think gives me the best performance in this case?
Firstly How can I make those databases in the first place?
How can I restore those backups? Is there any high-performance method to do so?
Does the key data type has effect on the performance of IndexedDB?

Please file this question on stack overflow. The question seems to require a dialog to understand what you are after.

@dfahlander Hi,
Thanks for your suggestion. I asked it here
https://stackoverflow.com/questions/66500333/indexeddb-database-backup-restore-scenarios
Can you please have a look at it and tell me what are your advice? I really appreciate it


How was the red fill pattern for fugitive diff acheived?

I can't see in any of the configuration where this would be done apart from maybe:

the font you're using?
that you're using neovide instead of something like alacritty?

In neovide, where i guess it's using neovides default font?

in alacritty where my font is Cozette

aha, it's this part is it?
https://github.com/Civitasv/runvim/blob/master/lua/user/options.lua#L41

Guess i just need to find a sane character for that now 👍🏻 🤝


Linter should be more strict about code styling rules

One such rule is not to leave whitespace between the function declaration and function body.

Maybe to ensure this and any other Style rules, go fmt and  go linter should be extended.

Originally posted by @goshawk-3 in https://github.com/dusk-network/dusk-blockchain/pull/864#discussion_r560872779

We can also check if any gofmt-like tool already can format functions body with this rule.

We can also check if any gofmt-like tool already can format functions body with this rule.

@goshawk-3 On that note, it seems gofumpt would do the trick.

@goshawk-3 On that note, it seems gofumpt would do the trick.


Fix the 404 in the clang docs

Most of them moved in:
https://reviews.llvm.org/D128072

Hi,
Changing URLs is done in this PR: #3702. We should choose one and check which is more complete. Some additional checkers have been added in the meantime.

#3702 Has been merged.


Error rendering elements on Firefox Mobile

Firefox Mobile 131.0.2
OS: Android 14
When opening the demo page with Firefox Mobile v131 the source elements get incorrectly replicated. The internal lists are updated correctly, so this is only a display-glitch. Please see the attached screenshots.

When doing remote debugging, it seems as if the cloned elements get false ids, which is why they are not removed, I guess:

@chemicha Seeing this as well. Will take a look.

The same problem occurs on Firefox Desktop, the whole example page doesn't work on Firefox.

Unfortunately, it is still broken on Firefox Mobile 132.

It is broken on FF 132.0.2 64-bit Linux.

Fix is ready, release is coming up in a few days

Well, that is awesome; I figured this was a corner case.
Thank you.
On Thu, 21 Nov 2024 at 20:12, Sasha Milenkovic @.***>
wrote:

Fix is ready, release is coming up in a few days
—
Reply to this email directly, view it on GitHub
https://github.com/formkit/drag-and-drop/issues/109#issuecomment-2492171738,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAG76RXXF2GCPQPZECZOILL2BY5BLAVCNFSM6AAAAABP7M5YIWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJSGE3TCNZTHA
.
You are receiving this because you commented.Message ID:
@.***>


About GitHub-hosted runners article contains wrong information about the macOS version of macos-latest

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners
What part(s) of the article would you like to see updated?
Specifically the table in Standard GitHub-hosted runners for Public repositories says that macos-latest uses the macOS 14 runner image. This seems to be wrong as the table in the documentation for runs-on specifies that macos-latest is actually using the macOS 12 runner image.
Additional information
No response

@Brezak Thank you for opening this issue! I'll get this triaged for review ✨

Hey @Brezak, thank you for opening this issue!
You are right, the information in these articles does not match. 👍 However, the documentation for runs-on that you linked is the article that is out of date. I'm going to open a PR to address this, and will come back and update you when those changes are live. Thank you again!

The runs-on doc has been updated to use the right image for macos-latest.


Run sanitizers on CI

This adds AddressSanitizer/MemorySanitizer/ThreadSanitizer tests to CI.
See #589 (tsan: data race in deque), #644 (tsan: data race in atomic), and #614 (asan: memory leak in skiplist) for issues reported by sanitizers.
Closes #154
Closes #589
Closes #644
Refs:

https://doc.rust-lang.org/nightly/unstable-book/compiler-flags/sanitizer.html
https://github.com/google/sanitizers/wiki

lsan

Asan can detect memory leaks, so we probably don't need to run lsan separately.

lsan

Asan can detect memory leaks, so we probably don't need to run lsan separately.

blocked on #613

blocked on #613

This should be ready for review now.
See #589 (tsan), #644 (tsan), and #614 (asan) for issues reported by sanitizers.

This should be ready for review now.
See #589 (tsan), #644 (tsan), and #614 (asan) for issues reported by sanitizers.

@jeehoonkang Are there any changes that you'd like me to make?

bors r=jeehoonkang


Enable AgentX Integration in LLDP

Addressing issue https://github.com/opnsense/plugins/issues/3563
This PR adds a checkbox into the form and model for the os-lldpd plugin. With this checkbox enabled and the corresponding AgentX support checkbox enabled in net-snmpd, lldp neighbour information can be queried via snmp.

@TotalGriffLock thanks! let's give @mimugmail a chance to review. Ping me again next week if it hasn't happened and well get this in either way. From my perspective it looks reasonable.

Bump!

Merged, thanks!


Enforce CSS and add a black version, please?

Hi,
I am using a custom Windows 7 theme called Plastic and it changes the windows' colors. Could you, please, add custom CSS for the preview? And since you're at it, maybe add a toggle button for changing the colors from light to dark (maybe even have 2, one for the code and one for the preview).

A couple of things here.

You can edit the template that MDE uses (F8)
You can change themes (Ctrl+T)


The event of scrollEnd never trigger

I find the reason is 'isInTransition' is always false when refresh.

But I need scrollEnd to excute refreshing code when scrolling to bottom

My code is easy as follows:
       var myScroll = new IScroll("#wrapper", {
          probeType: 2,
          preventDefault: false,
          interactiveScrollbars: true,
          useTransform: true
        });

        var positionJudge = function() {
          console.log(this.y, this.maxScrollY);
        }

        myScroll.on('scroll', positionJudge);

        myScroll.on('scrollEnd', positionJudge)

scroll event is triggered

@cubiq

I solve it but I do not kown why.The result is good anyway.

Hi There, same issue here, would you pls share how u solve it?


Updated all dotnet and nuget dependencies.

Info
This Pull Request is related to reviving this useful library.
Changes

updated dependencies to .NET7
updated all Nuget Packages
removed deprecated Nuget Packages

Approved


Thunder CLI UX

Re the UX of the CLI for this software.
CLI and daemon with RPC
This software needs to run as a daemon to at least watch the blockchain for revoked transactions being publish.
If such transaction is published then a punishment transaction should be broadcasted.
The preferred way would be to write one daemon, similarly to bitcoind or lnd, that exposes a json rpc or grpc interface (or both) and also write a cli that communicate with said interface.
The issue with that is that we would then need to design said interface (not sure we have time in the given timeframe).
Example
$ thor &
$ thor-cli connect <peerid>
$ thor-cli open <localamount> <remoteamount> <peerid>
$ thor-cli pay <amount> <channelid/peerid>
$ thor-cli close <channelid>

No RPC
Another possibility is for the daemon to simply get the revoked transactions from the database and watch the blockchain for those. It could then punish when it sees one but it is likely to be an issue if it also writes in the DB in concurrence with another call that updates the channel.
We could take the risk for this PoC or simply not write in the DB and just give an alert, providing either a punish command or a update command to update the DB from seen blockchain actions.
Example
$ thor watch & # Start a daemon that reads from the db and punishes
$ thor-cli connect <peerid>
$ thor-cli open <localamount> <remoteamount> <peerid>
$ thor-cli pay <amount> <channelid/peerid>
$ thor-cli close <channelid>
$ pkill thor # Stop watch command
$ thor update # Update DB with any punishment that might have happened.

Sounds like we prefer a proper solution with RPC?
Shall we roll with REST json as we are more familiar with that?

@luckysori @bonomat FYI, the issue moved here.


fix: solve precision problem when decode bigint in json

Fixes #379
slightly modify json.decode to solve precision problem when decode bigint in json

Thanks for your review and suggestion

LGTM. just waiting for #407

Can you rebase master please?

It's done.

Thanks! Can you look into the failing test please? You’ll likely need to change the tests to account for  int types

My bad, forgotten to test all modules :-)
The latest patch shall pass all tests.

@geseq @gufeijun This fix seems introduced a new bug in json module. The detail is:
tengo code:
fmt := import("fmt") json := import("json") fmt.println( json.decode("[1e3]"))  // expected: [1000]
but:
in v2.16.0: output is [0]  (❌)
in v2.12.0: output is [1000] (✅ )
Could you please help fix it ?

https://github.com/d5/tengo/pull/424


Secrets created from json is different from secrets created using the go-client api

func  CreateSecret(name string, encryptedData map[string][]byte, unencryptedData map[string]string) error {
	var secret *corev1.Secret
	if (len(encryptedData) == 0) && (len(unencryptedData) == 0) {
		return fmt.Errorf("Secret data cannot be blank")
	}
	secret = &corev1.Secret{
		Type: corev1.SecretTypeOpaque,
		ObjectMeta: metav1.ObjectMeta{
			Name: name,
			Labels: map[string]string{
				"heritage": "component-testing",
				"app":      "super8",
			},
		},
	}
	if encryptedData != nil || len(encryptedData) != 0 {
		secret.Data = encryptedData

	}
	if unencryptedData != nil || len(unencryptedData) != 0 {
		secret.StringData = unencryptedData
	}
	secretOut, err := kubeClient.client.CoreV1().Secrets(kubeClient.namespace).Create(secret)
	fmt.Println(secretOut.Name)
	return err
}

encrypts all the data provided in secret.Data and secret.StringData irrespective of the content
where as the same when created with below method matches creating a secret using kubectl create -f secrets.yaml
func CreateSecretFromJson(b []byte) {
	var s corev1.Secret
	err := json.Unmarshal(b, &s)
	if err != nil {
		fmt.Printf("unmarshall error")

	}
	secret, poderr := kubeClient.client.CoreV1().Secrets(kubeClient.namespace).Create(&s)
	if poderr != nil {
		fmt.Println(poderr.Error())
	} else {
		fmt.Printf("Created Secret %q.\n", secret.GetObjectMeta().GetName())
	}
}

My data in secret has both base 64 encrypted  and unencrypted (which is already an encrypted or binary data)

this is the documented behavior of the stringData field:
// stringData allows specifying non-binary secret data in string form.
// It is provided as a write-only convenience method.
// All keys and values are merged into the data field on write, overwriting any existing values.
// It is never output when reading from the API.

your json.Unmarshal(b, &s) call will load stringData into s, but the API never returns stringData, so secret will only contain data
for example:
$ curl -k https://localhost:6443/api/v1/namespaces/default/secrets \
  -X POST -H "Content-Type: application/json" \
  --data '{"metadata":{"name":"test"},"data":{"a":"YmFy"},"stringData":{"b":"test"}}'

{
  "kind": "Secret",
  "apiVersion": "v1",
  "metadata": {
    "name": "test",
    "namespace": "default",
    "selfLink": "/api/v1/namespaces/default/secrets/test",
    "uid": "82ef45ee-4fdd-11e8-87bf-00e092001ba4",
    "resourceVersion": "25758",
    "creationTimestamp": "2018-05-04T20:55:43Z"
  },
  "data": {
    "a": "YmFy",
    "b": "dGVzdA=="
  },
  "type": "Opaque"
}

also, the values in the data field are not encrypted, they are simply base64-encoded in json form, which decodes to normal strings in the go structs

Can you describe your setup more completely, and include API request/response after creating the secret each way (with replacement data so you don't disclose any data you care about protecting)

Using the same sample in your comment.
$ curl -k https://localhost:6443/api/v1/namespaces/default/secrets
-X POST -H "Content-Type: application/json"
--data '{"metadata":{"name":"test"},"data":{"a":"YmFy"},"stringData":{"b":"test"}}'
{
"kind": "Secret",
"apiVersion": "v1",
"metadata": {
"name": "test",
"namespace": "default",
"selfLink": "/api/v1/namespaces/default/secrets/test",
"uid": "82ef45ee-4fdd-11e8-87bf-00e092001ba4",
"resourceVersion": "25758",
"creationTimestamp": "2018-05-04T20:55:43Z"
},
"data": {
"a": "WW1GeQ==",
"b": "dGVzdA=="
},
"type": "Opaque"
}
P.S: I am not curling.  I create secret through the func CreateSecret I mentioned in my initial bug report

I see. You are putting a base64 encoded string into the go object. Don't do that. Just put the string you want in, and when it is JSON encoded it is transformed to base64

In my case the string i assign to Data go object is a private key. if go-client is transforming it to base64 when it is JSON encoded, then it should be able to get the information back to original when mounted as volume to a pod. It is not able to do so.

it's all about what object ends up in the API. If you can create a secret using client-go that is identical when retrieved from the API as one created with kubectl create -f file.json, then they will behave the same when used within a pod

when I create a pod with reference to Secret created from Json - pod gets created successfully

is that using kubectl create -f ... or your CreateSecretFromJson method? can you give an example of the json file you fed in that worked as expected?

for example, you would write this in client-go:
kubeClient.client.CoreV1().Secrets(kubeClient.namespace).Create(&v1.Secret{
  ObjectMeta: metav1.ObjectMeta{
    Name: "test",
  },
  Data: map[string][]byte{
    "a": []byte(`bar`),
    "b": []byte(`test`),
  },
})

which would produce this API object (kubectl get secret/test -o json):
{
  "kind": "Secret",
  "apiVersion": "v1",
  "metadata": {
    "name": "test",
    "namespace": "default",
    "selfLink": "/api/v1/namespaces/default/secrets/test",
    "uid": "82ef45ee-4fdd-11e8-87bf-00e092001ba4",
    "resourceVersion": "25758",
    "creationTimestamp": "2018-05-04T20:55:43Z"
  },
  "data": {
    "a": "YmFy",
    "b": "dGVzdA=="
  },
  "type": "Opaque"
}

which when mounted into a pod, would produce two files:
$ cat a
bar
$ cat b
test


Register and login

fixes #148
Dashboard (or any authenticated route) checks the redux user store and redirects you to login/index.html?redirect=%2fdashboard.html if you are an anonymous user or your user object says you are not authenticated (so it should wait for session.json fetch to complete).
After login, it redirects you to the route in the redirect query string, or dashboard.html
If you register, it redirects you directly to no_petition.html
If you have no petitions, dashboard.html redirects you to no_petition.html.
We match legacy (plus it's easier) in that register and login are not protected and you can still use them if you are logged in, and it will clear your user object and register/login you again.
I added a proxy to port 8000 in webpack dev server, so you can use a running local mop with export API_URI="/api/v1" and npm run dev

[x] Make sure to call window.analytics.identify() when they log in or register

thanks for reviewing @schuyler1d . everything should be fixed if you look at the last few commits.
Also sorry that the webpack and react updates are in this branch. I had already resolved the conflicts and didn't want to keep doing that. So ideally we can test these things together.


Order Serialization Order Value Multiplier

Expected Behavior
The "value" field has the value from Order.GetValue method.
Actual Behavior
The multiplier is not taken into account for option:

Time,Symbol,Price,Quantity,Type,Status,Value,Tag
2021-01-08T20:30:00Z,SPXW  210115C03870000,9.1,-5,Market,Filled,-45.5,"CreateIronCondor: Short Call Order placed with strike 3870 at the current SPX of 3816.93."

"orders": {
    "1": {
        ...
        "symbol": {
            "value": "SPXW  210115C03870000",
            "id": "SPXW XL80P536WOB2|SPX 31",
            "permtick": "SPXW  210115C03870000",
            "underlying": {
                "value": "SPX",
                "id": "SPX 31",
                "permtick": "SPX"
            }
        },
        "price": 9.1,
        ...
        "quantity": -5.0,
        ...
        "value": -45.5,

Checklist

[x] I have completely filled out this template
[x] I have confirmed that this issue exists on the current master branch
[x] I have confirmed that this is not a duplicate issue by searching issues
[x] I have provided detailed steps to reproduce the issue

The order Value property is currently deprecated because of this issue, please use Order.GetValue(security) or security.Holdings.HoldingsValue. We could potentially serialize it instead of Value


If an observer is removed during notify, then some observers will not be run.

Offending line: https://github.com/optimizely/nuclear-js/blob/master/src/change-observer.js#L30
__observers is iterated over using a simple forEach, meaning that mutations to __observers during iteration will lead to skipping of some later observers.
Minimal reproduction:
var testReactor = new Reactor();

var test = new Nuclear.Store({
  getInitialState() {
    return 1;
  },

  initialize() {
    this.on('TEST', (_state, v) => v)
  }
});

testReactor.registerStores({ test });

// Setup a first logger.
testReactor.observe(['test'], () => console.log('logger 1'));
console.log('-- test 1 --');
testReactor.dispatch('TEST', 2);
// All above runs fine

// Setup an unregistering observer and a second logger.
var unreg = testReactor.observe(['test'], () => unreg());
testReactor.observe(['test'], () => console.log('logger 2'));

// No logger 2 on this trigger
console.log('-- test 2 --');
testReactor.dispatch('TEST', 3);

// Now fine
console.log('-- test 3 --');
testReactor.dispatch('TEST', 4);

Prints:
-- test 1 --
logger 1
-- test 2 --
logger 1
-- test 3 --
logger 1
logger 2

Missing a logging observation on test 2. This removing of observers during a notify is very likely to occur when using with React, where a state change causes the displayed components to unmount. (This manifested in my application as an inner component properly re-rendering but an outer one depending on the same state to not do so, leading to broken UI. Confusingly, this only occurred when a particular state was first loaded, due to the dependency on ordering of observers for the bug to occur, much fun.)

Thanks for filing this @c-spencer.


How to remove an item (without an id)  from a board?

When I use the addElement API ot after drag and drop, there will be no id assigned to the item. In this case, how do I remove the item using the item from a board?
Thanks
Alex

Please ignore this. I can assig

Please ignore this. I can  assign an id while adding a new element.


[CLI-290] Fix relative mount dedupe

Ensure deduplication of mounts when using modal run on a relative parent directory (having .. in path segments)
Mostly a superficial change as this didn't have real world effects previously, but this will help preventing false positives in warnings when we disable auto mounting.

Check these boxes or delete any item (or this section) if not relevant for this PR.

[ ] Client+Server: this change is compatible with old servers
[ ] Client forward compatibility: this change ensures client can accept data intended for later versions of itself

Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.

Changelog

@prbot approve

@prbot automerge


[dns] fix dns failed to append names of length 255

This PR is fine to merge now. However, I labeled it as WIP so that it's to be merged after #6074 to reduce the rebasing burden of #6074.
@jwhui @wgtdkp @abtink @librasungirl

This PR is fine to merge now. However, I labeled it as WIP so that it's to be merged after #6074 to reduce the rebasing burden of #6074.
@jwhui @wgtdkp @abtink @librasungirl

This PR is fine to merge now. However, I labeled it as WIP so that it's to be merged after #6074 to reduce the rebasing burden of #6074.
@jwhui @wgtdkp @abtink @librasungirl

SGTM :+1:  Thanks!

This PR is fine to merge now. However, I labeled it as WIP so that it's to be merged after #6074 to reduce the rebasing burden of #6074.
@jwhui @wgtdkp @abtink @librasungirl

SGTM :+1:  Thanks!