[WFLY-9978] Fix RA deployment failure due to unready ConnectionDefinitionService in combined with legacy security-domain

RA deployment sometimes fails as explained in https://issues.jboss.org/browse/WFLY-9978
RA deployment service activation depends on raxml connections configuration attributes to determine security implementation type, and it assumes ConnectionDefinitionService is ready (see RaServicesFactory.java#L96 and ActivationSecurityUtil.java#L39) which is not always true.
This change allows to wait explicitly 500 ms to make sure ConnectionDefinitionService is ready to use.

@soul2zimate My gut reaction is that this is not the right fix (essentially sleeping in the add thread). We're discussing internally, and am adding the hold label in the meantimg

@maeste Hi Stefano, should I close this one for the moment?

@soul2zimate yup, we are working on a different solution. Thanks!


Integrate with ActionDispatch::SystemTest

TODO:

[x] Implementation cleanup
[x] ensure it works with infer_spec_type_from_file_location
[x] docs
[ ] blog post with example
[x] get some user testing in real rails apps

Great work! Any estimate on when this will be merged?

@elsurudo we'd gladly accept help on this, in the mean time our type: :feature specs work well with the new transactional setup and you can capybara on

This is now ready for user testing. Please let me know if you'd like to use this and give me some feedback

@jonrowe would you be able to provide review here?

I tried this out on a Rails 5.1 project and got things mostly working. Here was my general process:

Update my rspec-rails dependency to point at this branch, and point other rspec-* deps at their master branch.
Remove database_cleaner gem and associated configuration! 🎊
Turned on config.use_transactional_fictures because no more DatabaseCleaner! 🎆 🍾
Move all tests from spec/features to spec/system because we use infer_spec_type_from_file_location! (sorry (not sorry), Sam).
Add the following global configuration to maintain our previous use of Rack::Test for tests that don't require JS.

RSpec.configure do |config|
  config.before(:each, type: :system) do
    driven_by :rack_test
  end

  config.before(:each, type: :system, js: true) do
    driven_by :headless_chrome # a driver I define elsewhere
  end
end

Results
It kinda worked... I had a couple of problems.

We use an outermost feature keyword in our "feature" (now "system") specs with nested scenarios rather than describe and it. The use of feature seems to override both the location-inferred spec type and an explicitly set spec type and set the example group to feature. Doing a replace of feature with describe in spec/system fixed this issue.
I was not able to set the driver in a global before as specified above. Capybara would always use the Rails system test default. I was able to set the driver in line in the test.
System tests are configured to take a screenshot when a test fails. The screenshot is always written to tmp/screenshots/failure_.png which means you only get to review the last failure's screenshot. I've never used the Rails system tests, but judging by the dangling _ in the filename, I'm guessing there's supposed to be some sort of unique identifier there.

The first problem, stems from the use of feature syntax. This is an old habit that maybe should just go away. I'm not sure how many people use it, but we use it extensively and exclusively at thoughtbot. I can't think of a good reason to keep it, but it's rather puzzling when one can't figure out why their global type: :system before blocks aren't running.
I also encountered what I consider to be an unfortunate, if minor, annoyance. I like my test output to be as clean as possible -- just the test status indicators with no output. System tests seem to muck this up quite a bit. See:

The first bit of output is from puma starting up, presumably when RSpec hits its first system test. I'm glad to see it doesn't log all requests, but it'd sure be awesome if we could suppress this output somehow.
Then you see my test failures. The screenshot writes a log in-line. The "RSpec-friendly" way to do this would be to include that output with the detailed failure message.
I'm guessing that these annoyances are mostly out of RSpec's control and have to do with how system tests are implemented in Rails. Is there something we could contribute back to Rails to make the output play nicer? It seems to be that if this outputs during minitest runs, it'd be equally annoying for folks like me? Maybe I'm just too much of a neat freak?

I've followed the steps @derekprior describes in his comment above. Things work smoothly, besides the custom driven_by block:
RSpec.configure do |config|
  config.before(:each, type: :system) do
    driven_by :rack_test
  end

  config.before(:each, type: :system, js: true) do
    driven_by :chrome
  end
end

The driver isn't actually switched to rack_test or chrome for me, but the default selenium is used. Maybe that's because it's overwritten in this before block?

This is now ready for release pending https://github.com/rails/rails/commit/eba361824d9eb242f186bb711ef82381ac50ef9e being released in a stable version of rails (presumably 5.1.3)

@samphippen Excited for this, and stable Rails 5.1.3 shipped today. Let's 👊  it?

@maschwenk https://github.com/rails/rails/commit/eba361824d9eb242f186bb711ef82381ac50ef9e didn't make it into 5.1.3 - will be in 5.1.4

What's the timeline/ETA for this being in a gem release now that it's merged? i.e. when will 3.7.0 be out?

can this be released now since rails 5.1.4 is now out?

@hass-laughingman you probably already know this, but in case not, you can do the following in your gemfile to get it now:
gem 'rspec-rails', git: 'https://github.com/rspec/rspec-rails.git', branch: 'master'
  %w[rspec-core rspec-expectations rspec-mocks rspec-rails rspec-support].each do |lib|
    gem lib, :git => "https://github.com/rspec/#{lib}.git", :branch => 'master'
  end

@elsurudo yeah i have been doing that for now... but would like to go back to using released versions for stability. Not that i'm seen any instability issue so far, but you never know ¯_(ツ)_/¯

Trying this out, works great with chromedriver locally but for some reason it won't allow firefox (selenium) at all. Anyone have any suggestions?

@mhenrixon Use of chromedriver is also through selenium - how exactly are you configuring it to use Firefox, what version of Firefox, what version of geckodriver, and what version of selenium?

require 'capybara/rails'
require 'capybara/rspec'
require 'selenium/webdriver'
require_relative 'wait_for_ajax'

Capybara.register_driver :selenium do |app|
  Capybara::Selenium::Driver.new(
    app,
    browser: :firefox,
    desired_capabilities: Selenium::WebDriver::Remote::Capabilities.firefox(marionette: false)
  )
end

RSpec.configure do |config|
  config.before(:each, type: :system) do
    driven_by :selenium
  end

  config.before(:each, type: :system, js: true) do
    driven_by :selenium
  end
end

Before upgrading it is using firefox (3.6.1) after using the master branch it always picks chrome for some reason. I can't force firefox anymore locally. Maybe something is just cached locally. I got it working on circleci so no big deal. Just curious why I can't pick firefox anymore.

@mhenrixon Most likely because Rails overwrites your registration of :selenium when driven_by is called - https://github.com/rails/rails/blob/5-1-stable/actionpack/lib/action_dispatch/system_testing/driver.rb#L23 .  Either change the name of the driver you're registering to something other than :selenium (:poltergeist and :webkit would get overwritten too) or pass the requisite options through to driven_by

Ah! That makes sense, I kind of like that approach. It avoids confusion with naming. Thanks a bunch @twalpole

Hi guys, I've already read the comments but it'd be really nice to be able to use this from a released version, even a beta one. What's missing to have a new release out?

How does this affect the feature/scenario syntax?
https://relishapp.com/rspec/rspec-rails/docs/feature-specs/feature-spec
I've got things working in our test suite, but we have some specs that use the feature/scenario syntax, and those are having trouble loading our auth helpers.

@Petercopter Using RSpec.feature to specify your tests sets the test type to :feature, so if you've changed your auth helpers to only load in system tests, that would explain it.  I'm wondering what you are gaining by swapping them all from feature tests to system tests?

@twalpole You must be the one of the busiest guys in the Rails community. Thanks so much for your quick response to my random questions in several different repos.
I guess the problem we have would be that we have inconsistent syntax in our test suite. It seems like the best course of action would be to convert to the same syntax throughout the suite.
I'm curious as well, about what is to be gained. It's new and shiny, so it must be better! 😸

@Petercopter Really the only difference between system tests and feature tests when using RSpec with Capybara is a little being of configuration that can be saved - both get the biggest new feature which is shared DB connections in Rails 5.1 (obviating the need for database_cleaner in most cases)

Ah, rspec feature tests get shared DB connections in Rails 5.1, meaning database cleaner config can be changed?  I did not realize this, I assumed it would need to be a 'system' test to take advantage of this new rails 5.1 feature.

@jrochkind Yes, it's enabled when RAILS_ENV == test

@twalpole, I just got rid of Database Cleaner from my feature specs and everything is working great (very nice). So would you recommend I stop there or should I convert these feature specs over to system specs?
Reading between the lines it seems your suggestion would be to leave feature specs as is (why change something that does not need changing)? Hence, I assume RSpec will respect feature specs for the long-term? Not deprecate as an old and not-modern way.
Many thanks.

@bluz71 Correct, I don't really see any gains worth the effort of moving existing feature tests over to system tests, especially if tests are written using things like the feature syntactic sugar.  I haven't read about any plans to deprecate feature specs, but I can't really say what the future plans around that are.

Hey everyone,
Just wanted to say, THANKS for all the awesome work! Super excited to be system specs inside of RSpec.
In case you were looking for any fodder for that blog post, I would love an explanation of the implementation difference between a feature and system spec. I'm weighing on if I should bother converting feature specs to system specs.

I'm having trouble with selenium-driven tests not seeing records in the database. Consider the following:
RSpec.describe 'User logs in' do
  let!(:user) { create(:user, email: email, password: password, password_confirmation: password) }
  let(:email) {<EMAIL_ADDRESS>}
  let(:password) { '12345678' }

  scenario 'with valid email and password' do
    visit new_user_session_path
    fill_in 'Email', with: email
    fill_in 'Password', with: password
    click_button 'Sign in'
    expect(page).to have_content('You are signed in.')
  end
end

This test passes when RSpec.configure is set to driven_by :rack_test, but it results in "Invalid email or password" and test failure when driven_by is set to :selenium or any other selenium-based driver.
Using Rails 5.1.4, RSpec 3.7.0, selenium-webdriver 3.6 and capybara 2.15.4.

@moveson Prior to Rails 5.1 that would have been caused by running transactional testing, and not having database_cleaner installed.  In Rails 5.1 however the DB connection is shared between threads in testing mode, which would tend to imply whatever server you're using with Capybara isn't running in process.  What server are you using?  If puma, check the output produced for something like "clustered mode" and fix it to run in single mode.

@twalpole I'm using puma in dev and production. I don't see the familiar puma output on startup in my RSpec log. How can I tell what server is running in the test environment? In any case, to be safe, I changed my config/puma.rb to workers 1 and threads 1,1, but it did not fix the problem.

@moveson You actually need workers 0 to ensure in process mode - there's a PR that was accepted into the next Rails 5.1 release to ensure it gets set that way - https://github.com/rails/rails/commit/bc02a011d397cc4fa92724c977c91e1d75d681a1 .  You should be able to get the Puma output back by setting ActionDispatch::SystemTesting::Server.silence_puma = false - Unfortunately it was chosen to make silence the default in rspec-rails, rather than letting experienced users opt into silence, and hides the issue with puma.

@twalpole Setting workers to 0 and threads to 0,1 did the trick. Thank you! Do you happen to know an elegant way to set these values in the test environment without affecting my settings in dev/prod?

@moveson - You could monkey patch in the rails change I linked above, or configure a different config file for puma --- Puma reads it's config from a number of possible places, try config/puma/test.rb IIRC

Got it. Again, thanks!

I'm currently having some trouble get this running with a dockerized application (while the same application works fine without docker involved).
In the docker case the tests are driven_by a selenium remote driver, with a chrome standalone docker container. So far the interaction between the two containers (one with the web application, one with the browser) works (as I can tell from the created screenshots), except for stubbing of authentication (the session is just not logged in via login_as).
I already tried adjusting puma settings in the docker container (worked fine for the non-docker-case), but the symptoms of the problem are quiet different (with more then one threads the authentication problem occurs in a number of cases only, in this case it fails on every try).
Anybody an idea? Could it be that the in other places suggested disabling of self.use_transactional_fixturesis still necessary in my use case and that I would need database cleaner?

@aptituz You don't fully define your use case, nor what login_as you're referring to.  The Warden provided login_as (Devise), Rails 5.1 DB connection sharing (transactional testing, no need for database_cleaner), and Capybara's request completion detection all depend on the tests and the application under test running in the same process (multiple threads, but 1 process).
If you're referring to that login_as and are trying to run your AUT in a docker instance but run the tests on your local host - then you lose all that, will have to log in manually by filling in the fields everytime (or write your own login shortcut that depends only on parameters passed in the request), will need to use database_cleaner, and will need to be very careful about any extra requests from your app which your tests don't specifically wait to finish.
If, instead, you are running the tests on the docker instance and letting Capybara start the AUT on the docker instance all in one process (but the browser is in a different docker instance) then you should be fine.

@twalpole You are right. Thanks that you ask for clarification.
I'm referring to the Warden provided login_as method and only the browser is in a different docker instance. The application itself and the tests are in the same container, but ... well ... it could be that the tests ran against a previously started instance, I'll have to check that. According to your explanations this could be the culprit, so thanks: these hints are helpful to me.

@twalpole
I just wanted to drop a note that I got it running eventually. So, thanks again for your help.
For some reasons I don't remember I had a Capybara. run_server = false line around. So yeah, the tests were indeed run again a different, accidentally running container. After removing that setting it was basically just a host! "http://#{ip}:#{Capybara.server_port}" in a before(:each) to let capybara actually use the AUT containers external address for the tests instead of <IP_ADDRESS> as per default.

I have a problem with system tests:
RSpec.describe "Authentification", type: :system, js: true do
  let(:valid_attributes) { attributes_for(:user) }
  before :each do
    @user = User.create!(valid_attributes)
    visit '/users/login'
  end
    it "Enable second factor auth" do
      sign_in_with(valid_attributes[:email], valid_attributes[:password])
      @user.update! direct_otp: "111111" # on js: true, the user is not updated on the browser database
<EMAIL_ADDRESS>@user.direct_otp)
      expect(page).to have_content 'Se ha activado correctamente el segundo factor de autentificación.'
    end
end

This example only works when javascript is disabled, when I add js: true to the test, I get an error because the direct_otp field its not correct because user is not updated on the browser database.
Any suggestion on why this is happening?
Because user is created via code and I can login but late, on the middle of the test, when I update the user, the changes are not shared.

@Xosmond Assuming you're using Rails 5.1+, if the app code isn't seeing DB changes made in the test code it's usually that you have the app running in a separate process rather than separate thread.   Turn off the silencing of puma that rspec-rails does by default (it's a bad default option for beginners trying to troubleshoot) and see if the output puma generates tells you it's running in 'single mode'.  If it doesn't you need to check where/how your puma is getting it's config from and make sure it's set to run with 0 processes and some > 1 number of threads.

I have turn off the silencing and I got:
Puma starting in single mode...
* Version 3.11.0 (ruby 2.3.5-p376), codename: Love Song
* Min threads: 0, max threads: 1
* Environment: test
* Listening on tcp://<IP_ADDRESS>:9887
Use Ctrl-C to stop

Thats why I can login with the user created via code, but the app is not seeing the later change (user.update!) done by the test code on the it macro.
But if I do that change on the before macro , it works:
RSpec.describe "Authentification", type: :system, js: true do
  let(:valid_attributes) { attributes_for(:user) }
  before :each do
    @user = User.create!(valid_attributes)
    @user.update! direct_otp: "111111"
    visit '/users/login'
  end
    it "Enable second factor auth" do
      sign_in_with(valid_attributes[:email], valid_attributes[:password])
<EMAIL_ADDRESS>@user.direct_otp)
      expect(page).to have_content 'Se ha activado correctamente el segundo factor de autentificación.'
    end
end

Something happens after the before macro.

@Xosmond Ok, since it is running in single mode it's probably a timing issue with the way your tests are written (or possible you aren't actually running in transaction mode). This really isn't the right place for that discussion.  You should post over on stack overflow, add a capybara tag to the question and provide details of exactly what your sign_in_with and activate_second_factor methods do.

@twalpole I'm using config.use_transactional_fixtures = true and I have tried to sleep 5 it and nothing works. Oh I will. Same, thanks.


Broken link goes to 404

on https://docs.microsoft.com/en-us/microsoftteams/room-systems/skype-room-systems-v2#feedback "Country and region availability for Audio Conferencing and Calling Plans" there's a broken link
https://docs.microsoft.com/en-us/microsoftteams/room-systems/skype-room-systems-v2.md
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.
Content:skype-room-systems-v2
Content Source: Teams/room-systems/skype-room-systems-v2.md
Service: msteams
GitHub Login: @LanaChin
Microsoft Alias: v-lanac

@scanum Found this one today while working on Support.

PR #3162

@LanaChin is this an artifact of your rebranding work?

closing as this appears to have been filed in error

I've tested the link and it works.

Hi @LanaChin  @jambirk
The link works correctly when you're in the US or using an English location.
The link is broken for Latin or Spanish locations...
I'm talking to @kenwith about it on our MS teams of our team.
It's a weird issue because it works correctly for English languages, but when comes into Spanish...


fix(proxy) prioritize longer regex path matches

Summary
Let’s say we have two Routes, each with a single path and otherwise identically-configured:

/api/users/(?<userId>\w+)
/api/users/(?<userId>\w+)/profile

In the current behavior, unless regex_priority is set, a request coming in to /api/users/30/profile will match the former route (the one without the profile suffix) if it was created first—so the current behavior is to fallback to prioritizing based on created-time.
With non-regex paths, Kong currently (very helpfully) defaults to giving precedence/priority to longer paths. This is a great default.
This change simply makes the same true for regex paths, which is a more reasonable/predictable default (compared to created-time based priority, which is implicit and undesirable).
Full changelog

Update router.lua to include regex paths in calculating max_uri_length for routes

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

with regex you only know which regex is longer but that doesn't answer which matches the longest uri.

@bungle Good point. Isn’t that significantly more 'intrusive' to implement, though?
To be clear, I don’t at all disagree that the semantic considering real match lengths is preferable—but it seems like basing this on regex length, while not ideal, is still preferable to the current behavior.
Thoughts?
(Also, just noticed a couple of the tests need to be updated. Will do that if the approach seems reasonable).

@hishamhm any opinions about this?

@chrisaljoudi while I agree that created-time is not a great default criteria (and that's of course why the regex_priority field exists to override that), I think applying length  of the regex as criteria could be very misleading to users because it would in many cases appear to filter by match length (especially since non-regex matches already do that), but, as @bungle correctly pointed out, not all.
Running all regexes and applying the longest match would IMO make more sense, I think, and yes, the implementation would look very different, etc. (Though regex_priority would still need to apply because you may still want to match shorter regexes). But doing that would be a big behavior compatibility breakage (just like this PR is). It would have to be done in a major version, because for better or worse, sorting by created-at is the currently documented behavior.

Thanks for the feedback @hishamhm and @bungle. Makes sense that this behavior change should be in a major version, probably.
With that in mind, what do you guys think if the logic was to default regex_priority to the number of capture groups in the regex?
Again, this would still be in a major version, just wondering what you semantically think of that vs. length (trying to support the use-case exemplified above for more ‘specific’ router being matched first).
Number of capture groups is one idea, and another is the number of ‘path segments’ (though that’s less deterministic as you point out, because regex’s may match multiple segments).
Thoughts?

@chrisaljoudi Sorry for missing out your last reply!

With that in mind, what do you guys think if the logic was to default regex_priority to the number of capture groups in the regex?
Again, this would still be in a major version, just wondering what you semantically think of that vs. length (trying to support the use-case exemplified above for more ‘specific’/drilled-down parameterized routes being matched first).

Yes, semantically it would make more sense in my opinion, but as you said, it would still need to be a Kong 3.0 thing, which is still far away.
Number of path segments, as you also observed, has a similar issue as regex length.
I'll be closing this PR for now since we agreed on not pursuing the particular path this one is taking (no pun intended!) and we'll try to revisit this question when we get towards Kong 3.0!


Unable to properly set RancherOS hostname in Azure VM Scale Set

RancherOS Version: v1.5.4
Where are you running RancherOS? Azure VM Scale Set
Hello,
I am having a hard time trying to properly set DNS valid (as in 1123 valid) hostnames.
I deployed a RancherOS 1.5.4 VM Scale Set on Azure with a cloud-config file as custom-data.
Without specifying a custom hostname in cloud-config file, it gets set by cloud-init and the metadata file provided by Azure. This results in the hostname to be set on Azure VM name (which for a VMSS includes an underscore...) and not the VM hostname.
The result of the hostname command provides the right output format (ranchervmss00002) but /etc/hostname is overriden by cloud-init and the dynamic DNS entry also (ranchervmss_2).
Is there any way to keep the hostname as a hostname and prevent the hostname to be set by the metadata ? Or can I set it in cloud-config.yml including a dynamic Azure instance id ?
I would like something as clean as possible since we want to be able to scale (scaling set...) the cluster.
I spent almost all the day on it... I would really appreciate a quick answer so I can move on :)
Best Regards,
Julien Plaquevent
Thales Alenia Space

I already looked at https://github.com/rancher/os/issues/733 but I don't want to run ros config since it is not automatic when scaling a scale set.

And I think it is also linked to https://github.com/rancher/os/issues/2834 but still... no answer yet :)


Fixes for swift generator

We have introduced some clean-up in our api spec. Existing implementation of helium has small issue with output code.  Current PR fixes it.

I see that parameters are excluded from body, but where are they added to URL query?
Also, it looks like we do not have any tests for this piece of code. We should add them.

@roman-mazur They are added in formattedPathExtensionsForServiceMethod()

What class?
Please add a test that checks how parameters are treated.

I'll add all the missing tests

Ok, looks better now. Merging.


[Help Wanted] Optimize binary matmul kernel

The current kernel is fairly slow compared to the theoretical optimum, considering the small memory footprint of weight deltas. So right now it functions more as as proof of concept (eg. it outperforms naive simultaneous inference). Can expect an additional 4-8x latency improvement if further optimized.
I don't have much kernel optimization experience yet, though - if anyone in the OSS community is interested, would love some help!
Afterwards, it'd be super interesting to run some benchmarks against LoRA-based multi-tenant systems like Punica/S-LoRA.

Ended up using the BitBLAS W1A16 kernel which is pretty fast -- when serving 16 models at once, its 5x faster than the triton kernel. will update repo soon


Fix test test_output_mode_dict

There was a problem with checking the backend (the () were forgotten), and hence the condition always evaluated to False.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 57.70%. Comparing base (cb6ece3) to head (7069740).

:exclamation:  There is a different number of reports uploaded between BASE (cb6ece3) and HEAD (7069740). Click for more details.
HEAD has 14 uploads less than BASE

Flag
BASE (cb6ece3)
HEAD (7069740)

keras.applications
4
0

keras.applications-numpy
1
0

keras
4
1

keras.applications-torch
1
0

keras.applications-jax
1
0

keras.applications-tensorflow
1
0

keras-torch
1
0

keras-tensorflow
1
0

keras-jax
1
0

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #20228       +/-   ##
===========================================
- Coverage   82.12%   57.70%   -24.42%
===========================================
  Files         501      501
  Lines       47440    47440
  Branches     8711     8711
===========================================
- Hits        38958    27374    -11584
- Misses       6570    18358    +11788
+ Partials     1912     1708      -204

Flag
Coverage Δ

keras
57.70% <ø> (-24.28%)
:arrow_down:

keras-jax
?

keras-numpy
57.70% <ø> (-0.15%)
:arrow_down:

keras-tensorflow
?

keras-torch
?

keras.applications
?

keras.applications-jax
?

keras.applications-numpy
?

keras.applications-tensorflow
?

keras.applications-torch
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


docs: fill gaps in docs

Description
Replace this with a description of the PR. Explain the problem it solves and the proposed solution.
List Github/JIRA issue(s) this PR fixes.
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Internal change (a change which is not visible to the package consumers)
[ ] Documentation change or requires a documentation update

How Has This Been Tested?

[ ] Tested manually
[ ] Added automated tests

Checklist:

[ ] Unit tests have been added/updated
[ ] Documentation has been updated
[ ] Change file has been generated (npm run change:new)
[ ] Delete this branch (after the PR is merged)

Codecov Report

Merging #275 (0d0f3b6) into main (489b9e8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #275   +/-   ##
=======================================
  Coverage   94.89%   94.89%
=======================================
  Files          10       10
  Lines         294      294
  Branches       75       75
=======================================
  Hits          279      279
  Misses         15       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 489b9e8...0d0f3b6. Read the comment docs.


[BUG] Theme was resetting to light mode on refresh

Description
When i navigate to the Dev Tools > More Dev Tools on refresh it was resetting to light mode even though the dark mode was set.
Expected Behavior
It should be dark mode even we refresh in the More Dev Tools page
Screenshots (if applicable)

I think it should be set in localstorage, if this is what you mean.
Do you want to work on it?

Sure ill work on it.

Is this issue solved now??

Not yet

it is solved now because i can't see the issue you mentioned on the site


Fix exceptions when some config is not present + Code optimization

Description
LEARNER-7456

Fix crash when discovery is disabled in configuration file
Optimise the code for configuration functions

How to Reproduce:

Remove Discovery Dict from shared.yaml
Register a new user
Crash on home screen

Thanks for the pull request, @omerhabib26! I've created OSPR-4340 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.
Feel free to add as much of the following information to the ticket:

supporting documentation
edx-code email threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.

@omerhabib26 Thank you for your contribution. Please let me know once all checks are green.

@omerhabib26 🎉 Your pull request was merged!
Please take a moment to answer a two question survey so we can improve your experience in the future.

@natabene it's done now


Update to reqwest 0.10

I needed to update to solve https://github.com/sfackler/rust-openssl/issues/987.

Reminder.
I wish to add KAS, but am waiting on this first.

Sorry to have kept you waiting so long.


AzGovVizParallel.ps1 - ParserError: The '<' operator is reserved for future use.

Hello,
While running the script I am getting this error.
PS C:\Users\Admin\Downloads> .\AzGovVizParallel.ps1 -ManagementGroupId bxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
Security warning
Run only scripts that you trust. While scripts from the internet can be useful, this script can potentially harm your
computer. If you trust this script, use the Unblock-File cmdlet to allow the script to run without this warning
message. Do you want to run C:\Users\Admin\Downloads\AzGovVizParallel.ps1?
[D] Do not run  [R] Run once  [S] Suspend  [?] Help (default is "D"): R
ParserError: C:\Users\Admin\Downloads\AzGovVizParallel.ps1:210
Line |
210 |  … k Button--medium Button d-lg-none color-fg-inherit p-1">    <span cla …
|                                                                ~
| The '<' operator is reserved for future use.
PS C:\Users\Admin\Downloads>
Please refer to image too.

Regards,
WVDAdminTF

@WVDAdminTF Hello, please log azGovViz errors at aka.ms/azgovviz
This very much looks like a copy paste issue. Please try to clone the repo or download the zip

Thank you so much, the Issue has been resolve after downloading the Zip file and executing it from the PWSH directory
Regards,
WVDAdminTF


MAINT: add codecov commenter bot

Description
This PR

configured jacoco to generate xml report for codecov to identify
add codecov.yml config file
add codecov as an action in the github workflow
add codecov badge in project README

Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Blocking: We will need CODECOV_TOKEN to be added as secrets: https://app.codecov.io/gh/opensearch-project/data-prepper/

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@7479209). Click here to learn what that means.
The diff coverage is n/a.

:exclamation: Current head fe73c93 differs from pull request most recent head efb5b1f. Consider uploading reports for the commit efb5b1f to get more accurate results

@@           Coverage Diff           @@
##             main     #549   +/-   ##
=======================================
  Coverage        ?   92.59%
  Complexity      ?      558
=======================================
  Files           ?       68
  Lines           ?     1675
  Branches        ?      140
=======================================
  Hits            ?     1551
  Misses          ?       94
  Partials        ?       30

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7479209...efb5b1f. Read the comment docs.

This looks very nice!
Can we move the file codecov.yml file into the config/ directory? I'd like to try to avoid expanding our root directory.

Can we move the file codecov.yml file into the config/ directory? I'd like to try to avoid expanding our root directory.

@dlvenable According to https://docs.codecov.com/docs/codecov-yaml#can-i-name-the-file-codecovyml, I have moved it to .github

@dlvenable @jianghancn Thanks!


Symbol support breaking change

Would you consider changing the symbol support from 7d659e78d43e69e6afc604e12b3ba3a5def0e46f to an optional feature enabled by a flag of some kind?
I get the improvement this brings, however it creates a MAJOR change for libraries and projects that depend on traverse.
For example older versions of Loopback 4 use babel/traverse which depends on traverse. They specify any MINORs or PATCHes as OK with the ^ symbol in their package.json file. Since this feature wasn't released as a new MAJOR version, they may start using it. The interface never contained anything other than strings, so this breaks when iterating over data with symbols.

Can you elaborate? Enumerable own symbols are rare; in what concrete case is this causing breakage for someone?

Loopback depends on traverse. They use it to walk REST connector objects.
This behavior is fine while all leaves of the object are non-symbol. However, nothing's stopping you from setting one of the leaves to another complex object.
In our project, which depends on both loopback and traverse, we include an instance of forever-agent in the tree. Forever agent likely contains request, response and other complex objects. These contain symbols.
Thus the new feature breaks dependant libraries who were expecting the interface to be string up until now.

https://github.com/loopbackio/loopback-connector-rest/blob/3d0ea7b8ff59050796c09a8d037eefc8835d0658/lib/template.js#L52
In this file, loopback-rest-connector expects the output of traverse to be string. They call RegExp.exec() on the item, which can now be a symbol. This crashes.

That is… impressively convoluted, and I think technically and unfortunately makes it qualify as an actual breaking change.

likely contains request, response and other complex objects. These contain symbols.

can you confirm that they do, in fact, contain enumerable symbols?
If it's just theoretical, then I don't necessarily need to change anything, but if existing non-contrived code that worked before, breaks now, then I do.

This screenshot was taken in the debugger during the operation I described:

It seems the agent doesn't contain a request and response as I thought. However, it does contain its own symbols.

I filed an issue with loopback as well, but I feel like this needs to be fixed in both places.


Introduce ElmFlutterView class

This class is the FlutterView class available in EFL UIFW.
According to the Elementary widget api rule(?),
Evas_Object type parent widget is always required before engine run.
When FlutterView starts the Flutter engine normally through RunFlutterEngine(),
it can acquire the Evas Image handle.
Example)
ElmFlutterView flutter_view;

if (flutter_view.RunFlutterEngine(box, 550, 550)) {
  RegisterPlugins(&flutter_view);
  Evas_Object* evas_image = (Evas_Object*)flutter_view.GetEvasImageHandle();

  elm_box_pack_end(parent_box, evas_image);
}

related PR : https://github.com/flutter-tizen/engine/pull/292

contribute to https://github.com/flutter-tizen/flutter-tizen/issues/351

Can you share an example like the app you showed here?

Can you share an example like the app you showed here?

@bbrto21
https://github.com/JSUYA/gallery/tree/test_flutterview
This is sample here

I added a patch to update the engine hash. thank you for check

Thanks! It is now expected that there will be no problems.


Validation : Stderr mismatch

On running validate rule on my terminal today, there were many tests failing due to mismatching stderrs (489). An overall summary is:
6363 total tests, which gave rise to
24929 test cases, of which
18636 were skipped
  58 had missing libraries
5231 expected passes
  87 expected failures

   2 caused framework failures
   0 caused framework warnings
   1 unexpected passes
 888 unexpected failures
  27 unexpected stat failures

I am currently making an alternate setup using make and try to figure out the difference in the implementations for possible errors.

I am currently finding out the difference in the make based implementation and currentimplementations tolook for the sources of these errors

@angerman How can this issue be fixed? Currently, I am installing the packages that are in inplace to stage1 also, using a new validate rule.

@snowleopard @angerman
There are 4 main problems with current validation module:

3 missing libraries: check-ppr, check-api-annotations, hp2hs
Incorrect path to compiler.
ghc-iserv should be in lib/bin and not bin.
An error with rts library.

I have solved the problems #1,2&3 as follows:

added the libraries and wrote the need rule.
additional argument to make command
added ghc-iserv to lib/bin path same as with unlit/touchy.

SUMMARY for test run started at Sat May 12 22:51:44 2018 IST
0:45:14 spent to go through
6357 total tests, which gave rise to
23650 test cases, of which
16920 were skipped
  56 had missing libraries
6514 expected passes
  95 expected failures

   0 caused framework failures
   0 caused framework warnings
   1 unexpected passes
  62 unexpected failures
   2 unexpected stat failures

I still couldn't figure out the source of error in rts problem. I believe by solving the issue with rts, number of failures will fall down below 20.

@chitrak7 Start sending small PRs to fix validation errors. No need to fix everything in one go.

As I mentioned elsewhere. Please don’t move binaries around. Adapt the testsuite to find binaries in it’s new places.

@angerman Could you create an issue where you explain:

Why you moved some binaries from their usual (for GHC's Make) location bin/lib to bin in Hadrian.
Why we shouldn't move these binaries back where they are expected both by the GHC infrastructure and GHC developers.
What should be the general approach for dealing with binaries that live in the new location.

Without this, the most natural path to fixing validation errors and other issues (e.g. see #591) is to bring everything back to bin/lib. In fact, I'm inclined to just move everything back to bin/lib to have a fully working Hadrian build as soon as possible. Migrating binaries without a clear rationale and technical solution seems to have been rather disruptive for Hadrian development.

I'm just afraid this will break the bindist rule. Which are currently a simple compaction of bin and lib:
https://github.com/snowleopard/hadrian/blob/44368b61d78b4ccf4e5aa6312cd64f4b2466efc4/src/Rules/BinaryDist.hs#L25-L29
moving binaries from bin to lib/bin. @alpmestan and I have spent a lot of time killing off ghc-cabal, keeping the source tree as pristine as possible and by that making the binary distribution rule trivial. I'd just be very sad to see all this work (partially) reversed by not making the test-suite parameterized over the location of the tools.

@angerman It looks to me that copying one more directory bin/lib is not such a big deal, whereas the snowfall of issues due to the removal of bin/lib is quite substantial. Anyway, this definitely deserve a separate issue, please create one.

Why you moved some binaries from their usual (for GHC's Make) location bin/lib to bin in Hadrian.

Because they were there for a technical limitation that @angerman lifted. Hadrian's GHC builds are fully relocatable, we can now just move {bin, lib}/ around together and GHC will keep working just fine. Hadrian is currently (and likely will stay forever) the only build system to take advantage of this.

Why we shouldn't move these binaries back where they are expected both by the GHC infrastructure and GHC developers.
What should be the general approach for dealing with binaries that live in the new location.

The existing GHC infrastructure has been growing for over 25 years and has been built around the "technical limitations" that we were mentionning: everything expected under inplace/..., wrappers in bin/ and actual binaries in lib/bin/, etc. The testsuite has not had to accomodate anything else and people are used to that. I think the proper solution in all aspects is to make all these things configurable. I think it's okay to compromise (like with the ghc-iserv case) for a bit but I'm definitely inclined to do the work needed to make all these things configurable myself, and offer Hadrian a chance to make our lives simpler whenever it can. This doesn't have to all happen now, but I think this is overall the right direction. This will require a few patches to GHC (especially the SysTools module I suppose), the testsuite and what not, but I personally see no good reason not to go down that path. Thoughts?

@alpmestan Thanks for the detailed answer! This is an important issue and should be documented separately -- so, could you please open a new ticket to track its progress?

I'm definitely inclined to do the work needed to make all these things configurable myself, and offer Hadrian a chance to make our lives simpler whenever it can. This doesn't have to all happen now, but I think this is overall the right direction.

Sounds great, thank you for helping with this! Even more reasons to document and track this separately.

Done: #603.

I believe this has been fixed.


TypeError with Synchronous Function in Dependencies When Using Local Handler

I've encountered a TypeError when a synchronous function is used as a dependency with the local event handler. It seems the dependency function is expected to receive the event object leading to a mismatch in arguments passed. Is this indeed intended?
Here's a snippet that reproduces the possible issue:
@router.get("")
def status():
    dispatch("status")
    return {"status": "ok"}

def get_dependency():
    return "dependency"

@local_handler.register(event_name="*")
async def handle_all_events(event: Event, dependency=fastapi.Depends(get_dependency)):
    pass

This results in the following error:
TypeError: get_dependency() takes 0 positional arguments but 1 was given
Changing get_dependency signature to async def get_dependency runs successfully.
Thanks for this awesome library!

Thanks for the quick reply. Just to provide more color on this, we currently use Depends to reuse db queries or other operations that might be async. But also for dependency injection, for which we usually don't need them to be async, something like the below
def get_repository() -> Repository:
    return Repository()

def get_service(repository=Depends(get_repository)) -> Service:
    return Service(repository=repository)

Thanks! @melvinkcx


REST API : /api/chat endpoint not working

Refering to the the examples of the main page:
Generate a response: Works perfectly
curl http://localhost:11434/api/generate -d '{
  "model": "llama2",
  "prompt":"Why is the sky blue?"
}'

Chat with a model: Not Working
Response is "404 page not found"
curl http://localhost:11434/api/chat -d '{
  "model": "llama2",
  "messages": [
    { "role": "user", "content": "why is the sky blue?" }
  ]
}'

I tried restarting the server and also with mistral model and I am getting the same result.

Hi @slovanos! Which version of Ollama are you on? (you can check with ollama -v)
The chat api is available in 0.1.14 or later (just released yesterday :-). To upgrade simply re-download Ollama: https://ollama.ai/ on Linux or macOS. Hope this helps!

Thank you very much for the fast response. ollama version 0.1.13. So that may be the issue. Thanks!

I see this issue consistently when using the "mistral" model, but all works ok when using the "llama2."  My installed version is "ollama version is 0.1.17" running on MacOS, Mac M1.  With Ollama serving, I also get a 404 at http://localhost:11434/api/chat when trying to hit that URL in a browser.

@ghassett read the error.message, and not just the status line. 404 means you haven't installed that model. use "ollama run mistral" first.
And GET requests, which you're sending in your browser, are routed differently. See also /Ollama/server.log


Please consider fixing issues detected by repository checker

Notification from ioBroker Check and Service Bot
Dear adapter developer,
I'm the ioBroker Check and Service Bot. I'm an automated tool processing routine tasks for the ioBroker infrastructure. I have recently checked the repository for your adapter emby for common errors and appropiate suggestions to keep this adapter up to date.
This check is based the current head revisions (master / main  branch) of the adapter repository
Please see the result of the check below.
ioBroker.emby
   -
ERRORS:

[ ] :heavy_exclamation_mark: [E204] Version "1.0.3" listed at common.news at io-package.json does not exist at NPM. Please remove from news section.
[ ] :heavy_exclamation_mark: [E506] Word "Timeout" is not translated to russian in admin/words.js. You can use https://translator.iobroker.in/ for translations
[ ] :heavy_exclamation_mark: [E506] Word "TimeoutDesc" is not translated to russian in admin/words.js. You can use https://translator.iobroker.in/ for translations

WARNINGS:

[ ] :eyes: [W040] "keywords" within package.json should contain "ioBroker"
[ ] :eyes: [W173] Potential sensitive data "apikey" not listed at "protectedNative" in io-package.json
[ ] :eyes: [W174] Potential sensitive data "apikey" not listed at "encryptedNative" in io-package.json
[ ] :eyes: [W184] "common.materialize" is deprecated for admin >= 5 at io-package.json. Please use property "adminUI".
[ ] :eyes: [W853] .npmignore found - consider using package.json object "files" instead.

SUGGESTIONS:

[ ] :pushpin: [S522] Please consider migrating to admin 5 UI (jsonConfig).

Please review issues reported and consider fixing them as soon as appropiate.
Errors reported by repository checker should be fixed as soon as possible. Some of them require a new release to be considered as fixed. Please note that errors reported by checker might be considered as blocking point for future updates at stable repository.
Warnings reported by repository checker should be reviewed. While some warnings can be ignored due to good reasons or a dedicated decision of the developer, most warnings should be fixed as soon as appropiate.
Suggestions reported by repository checker should be reviewed. Suggestions can be ignored due to a decision of the developer but they are reported as a hint to use a configuration which might get required in future or at least is used be most adapters. Suggestions are always optional to follow.
You may start a new check at any time by adding the following comment to this issue:
@iobroker-bot recheck
Please note that I (and the server at GitHub) have always plenty of work to do. So it may last up to 30 minutes until you see a reaction. I will drop a comment here as soon as I start processing.
Feel free to contact me (@iobroker-bot) if you have any questions or feel that an issue is incorrectly flagged.
And THANKS A LOT for maintaining this adapter from me and all users.
Let's work together for the best user experience.
your
ioBroker Check and Service Bot
@mcm1957 for evidence
Last update at Fri, 06 Sep 2024 07:35:07 GMT

Issue outdated due to RECREATE request. Follow up issue #116 has been created.
This issue will be closed.
your
ioBroker Check and Service Bot


Startup failure/freeze when additional discontinuity tags in alternate audio/text tracks

Media3 Version
ExoPlayer 2.17.1
Devices that reproduce the issue
All devices
Devices that do not reproduce the issue
No response
Reproducible in the demo app?
No
Reproduction steps
Configure the player to disallow chunkless startup: setAllowChunklessPreparation(false)
Details
Media must contain a track that that has isMasterTimestampSource set to false during the preparation step and contains 1 or more additional #EXT-X-DISCONTINUITY tags before the first sample chunk.
This scenario causes the timestampAdjuster provided for that discontinuity sequence to be provided for  only to a single track. That HlsMediaChunk is unable to initialize the timestampAdjuster causing the call : timestampAdjuster.sharedInitializeOrWait(isMasterTimestampSource, startTimeUs); to block loading until the timestampAdjuster initialization can be completed.
Since no other tracks contain the same discontinuity sequence and will not be provided with the same timestampAdjuster as the waiting HlsMediaChunk's - loading will never complete.
Expected result
Playback starts
Actual result
Playback is stuck in loading state
Media
https://storage.googleapis.com/mlbapp-streaming-resources/big_buck_bunny_disc/x36xhzz.m3u8
Bug Report

[ ] You will email the zip file produced by adb bugreport to<EMAIL_ADDRESS>after filing this issue.

I can repro this with 2.17.1 where startup hangfs in STATE_BUFFERING but not with v2.18.0 and later. I have tried with the GitHub tag r2.18.0 and on tip of tree in the internal source tree and I can not repro with a recent version.
May I ask you to try this out with a recent release of ExoPlayer? Either with the demo app or your own app?
I did repro in the demo app with 2.17.1 and then checked out tag r2.18.0. You can do the same with the most recent release if that's easier than upgrading your app:

Check out the repo

git clone https://github.com/androidx/media.git

Change PlayerActivity

On L276 set the media source factory to use an HlsMediaSourfce.Factory with chunkless preparation disabled.

ExoPlayer.Builder playerBuilder =
      new ExoPlayer.Builder(/* context= */ this)
          .setMediaSourceFactory(
              new HlsMediaSource.Factory(dataSourceFactory)
                  .setAllowChunklessPreparation(false));

on L286 comment out the call to configurePlayerWithServerSideAdsLoader() to avoid a null pointer.

on L391 comment out the call to releaseServerSideAdsLoader() to avoid a null pointer.

I have applied these changes above for 2.17.1, 2.18.0 and tip of tree and I can repro on 2.17.1 only.

I was able to test 2.18.5 and that did work when the additional #EXT-X-DISCONTINUITY exists within an alternative audio stream. However I am still seeing a similar problem when the discontinuity is in a text track. The text track issue can still occur on startup if there are mismatching discontinuity tags but it can also occur during playback.
I created an example here: https://storage.googleapis.com/mlbapp-streaming-resources/big_buck_bunny_disc/bunny_text.m3u8
This has a couple discontinuity tags about 2 min in to the text track and will start playing fine - but will not allow playback at any point past the text's discontinuity tags.  I tested this on 2.18.5 (without the chunkless preparation change)

The stream that you shared above, includes subtitle renditions that have discontinuities that are not present in the media or audio renditions. When encountering such a discontinuity, the player/timestamp adjuster waits until the adjustment in the main track to be adjusted. If this does not happen, the player falls into the buffering state that you observe and is stalling playback.
I can repro this behavior. That's not much news for you, it's what you mentioned above.
This behavior is in place in ExoPlayer since a good while and worked in the sense that we never got complaints that I am aware of. I was wondering why because it obviously stalls playback and we would have people tell us.
I think the reason for not hearing such complaints is that the HLS Authoring Guide from Apple who owns the spec says:
8.15. All variants and renditions MUST have discontinuities at the same points in time.

https://developer.apple.com/documentation/http_live_streaming/http_live_streaming_hls_authoring_specification_for_apple_devices
I understand that you created such a stream for testing purposes by adding the discontinuities in the text rendition. I haven't tested on Apple devices or with other players but it seems to me that the implementation in ExoPlayer is following the authoring specification. Given this I was wondering what the reason for having such streams are. Personally I wouldn't go beyond the authoring guidelines from Apple when producing content because it may not work with some players and player makers may point to that spec regarding this.
Can you give me some context on why you are attempting to create such content?

Thanks for the context.
In general I think its a good strategy to stick to the authoring guidelines for us as a player. This allows players to make changes in the future and not to be locked into something specific to partners content or suddenly not supporting it anymore with an update in the future.
However, I also think that if this is a function of the exceptional network conditions described above, playback shouldn't silently stall without the player or app being aware of it. If the player would throw an exception in this case, the app can decide to restart playback from the live edge and continue playback that way. Hence what we can do is to throw an Exception when playback stalls for too long.  The resulting playback exception for live stream can then be caught and the live stream can be restarted.

I agree with that solution - an error would be much more helpful to at least get an understanding of what is wrong allow that to report the error so we can react to the failure.

Thanks for the feedback. We look into this and update the issue here when a fix lands.  It's planned to include this in the next release. Thanks again for reporting!

@marcbaechinger this is related to an issue that has been on my plate for years now :-(  https://github.com/google/ExoPlayer/issues/8952
There are some live packagers in the wild that independently package segments from transcoded streams that can dropout (UDP streams, or just raw un-conditioned TS streams).  They have a variety of methods that fall under the HLS "standard" but do not play to the guidelines (similar in the DASH world to meeting the ISO standard but falling short of the DASH-IF Guidelines).   These produce fun things like:

Jumps in the playlist timeline marked only by a PROGRAM-DATE-TIME jump (Pseudo GAP)
EXT-X-DISCONTINUITY randomly in one or more playlists
Large jumps in the media time (PTS or CTS) un-marked by any EXT-X-DISCONTINUITY

Oliver and I went back and forth a lot on this, and I have come to his camp, these are media problems the player should not try to fix.
That said, freezing playback (either stuck in ready or stuck in buffering) is not good either.  We'll be pulling in the solution that @tof-tof put in for our version when this happens (retrying "fixes" the freeze, and allows logging the issue).
Might be time to visit un-commenting this code as well: https://github.com/androidx/media/blob/d13a0f4ec62ca092b79746a5725b62a3244cc5b4/libraries/exoplayer_hls/src/main/java/androidx/media3/exoplayer/hls/HlsSampleStreamWrapper.java#L1773
Perhaps with a settable threshold that defaults to infinite (effectively then the same behavior as the commented out code has).
Love your thoughts on this?

@stevemayhew

these are media problems the player should not try to fix

Still agreeing to this part. It really comes down to: how can we detect the problem and what the is the right reaction to it. Am I right in assuming that the code stayed commented because it was unclear how to automatically handle the error? (see https://github.com/google/ExoPlayer/issues/7030#issuecomment-598110143). If not, please remind me why we left it commented out as I can't seem to find the right comment trail for it.

Perhaps with a settable threshold that defaults to infinite

Do you know a good reason to make the actual threshold configurable vs a simple on-off switch? If we leave it as a threshold configuration, it's unclear to other apps what value makes sense for the purpose. A simple boolean throwAtUnexpectedDiscontinuities (or similar) might be more readable and understandable. The default can be off initially, or we can consider turning it on by default if it feels safe enough.

@stevemayhew

these are media problems the player should not try to fix

Still agreeing to this part. It really comes down to: how can we detect the problem and what the is the right reaction to it. Am I right in assuming that the code stayed commented because it was unclear how to automatically handle the error?

@tonihei  IMO report it as an error (a specific PlaybackException and allow the client to recover (enough info to seek past the failed position if any then issue a prepare() ).   This allows logging it operationally and reporting media/origin issues to the source origin vendor.
Oliver was pushing for silent automatic recovery, so that is why it stalled as commented out code.
Automatic recovery is tricky, especially if the issue occurs mid-segment.  I experimented with it a bit and determined it would take recovery at the timestamp adjustment level, hence the relationship to this issue: https://github.com/google/ExoPlayer/issues/8952
I have an asset still I can share (the Pro Bowl recording) that "plays" in Safari (but it looses A/V sync) but hangs in ExoPlayer

Perhaps with a settable threshold that defaults to infinite

Do you know a good reason to make the actual threshold configurable vs a simple on-off switch?

I think an on-off is fine,  the simple threshold is enough time to exceed a buffering span (50 seconds for VOD, much less for live) as one of the worst manifestations of the issue is the player will stall in buffering mode forever (if timestamp mismatch between audio and video exceeds the buffer window).    This is because of the way the value for SequenceableLoader.getBufferedPositionUs() is determined assumes clean adjusted timestamps.
Happy to work with a member of my team to clean this up to some release form if we can agree on a design,  I think we should:

Promote the exception (UnexpectedSampleTimestampException) to a documented common level (It can happen in DASH too, if the origin vendor does not follow DASH-IF Restricted Timing Model and allows gaps in their media timeline
Use the boolean as you suggested, we can choose a pretty large tolerance for the timestamp, as the stall occurs if it exceeds the buffer threshold

Automatic recovery is tricky, especially if the issue occurs mid-segment

Given how much we need to reset in this case, it would probably involve setting the ExoPlaybackException.isRecoverable flag and let the core player retry automatically. We already do this with some renderer errors, but not with source errors that are meant to be retried lower down the stack. This involves adding the right core logic for it, but this can be done later after the error already exists.

Promote the exception (UnexpectedSampleTimestampException) to a documented common level (It can happen in DASH too, if the origin vendor does not follow DASH-IF Restricted Timing Model and allows gaps in their media timeline

Sounds good to me. Having a dedicated error type allows to identify this problem explicitly for manual retry if needed.

Use the boolean as you suggested, we can choose a pretty large tolerance for the timestamp, as the stall occurs if it exceeds the buffer threshold

That's interesting in that a large tolerance only helps to detect 'stuck' cases and a lower tolerance would be closer to a correctness check that kicks in even if playback could recover itself. Am I right in saying that the current commented-out thresholds are actually better because they detect malformed media directly? As long as it's an opt-in for now, we can use the lower thresholds. If we get around to add an automatic recovery attempt, we can think about making the setting opt-out.


gnome-boxes: can't create a VM with UEFI firmware

Describe the bug
When I try to create a simple Ubuntu 24.04 VM from official ISO image with UEFI firmware, I get this error:

Steps To Reproduce
Steps to reproduce the behavior:

Install gnome.gnome-boxes package
Run gnome-boxes
Try to create a VM with UEFI firmware

Expected behavior
VM is created and boots just fine.
Screenshots
Shown above.
Notify maintainers
@NixOS/gnome

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
 - system: `"x86_64-linux"`
 - host os: `Linux 6.6.32, NixOS, 24.05 (Uakari), 24.05.20240531.805a384`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.2`
 - nixpkgs: `/nix/store/i1aw9jjgxcvyd642s12kw3iasmarwd42-source`

Add a :+1: reaction to issues you find important.

I encountered this as well. I was able to work around it by adding qemu to my environment.systemPackages and the following snippet to my nixos config (longer explanation here):
systemd.tmpfiles.rules =
  let
    firmware =
      pkgs.runCommandLocal "qemu-firmware" { } ''
        mkdir $out
        cp ${pkgs.qemu}/share/qemu/firmware/*.json $out
        substituteInPlace $out/*.json --replace ${pkgs.qemu} /run/current-system/sw
      '';
  in
  [ "L+ /var/lib/qemu/firmware - - - - ${firmware}" ];

@lasandell this works, thanks!


Updates the image version of examples/external-dns.yaml

Fixes: #1245
As a test, I've confirmed that the Route53 hosted zone was successfully updated.

thanks for making this change :D
/lgtm
/approve


[Question] How to save video titles or URLs alongside the IDs when using (download archive)?

Checklist

[x] I'm asking a question
[x] I've looked through the README and FAQ for similar questions
[x] I've searched the bugtracker for similar questions including closed ones

Question

Hi! 👋
When using --download-archive function youtube-dl saves the video IDs to a .txt file. How can i add video titles/URLs to it so that it becomes something like this:
Ducks having a conversation
youtube xJVwvq5z3MI

OR:
Ducks having a conversation
https://www.youtube.com/watch?v=xJVwvq5z3MI

Or if there's any other way to save the title+IDs/URLs together in a text file with no more info than that?

Download archive is not intended to store anything apart from video identifier. You have to store metadata separately.

Download archive is not intended to store anything apart from video identifier. You have to store metadata separately.

@dstftw Thanks!
Is there any other way to save the title+IDs/URLs together in a text file? only these two.
The metadata file has more info than needed in my case and creates a text file for each video instead of having all the info in one single text file


AZ400_M04_L10_Creating_a_Release_Dashboard.md

Contact Details
<EMAIL_ADDRESS>What happened?
Exercise : 01
Task: 01
Step: 02
Description of issue: DevOps Starter is not available through the search box in azure. It is available through the marketplace. As the DevOps Starter is now retired On 31 March 2023, should we update this lab?
Repro steps:

On your lab computer, start a web browser, navigate to the Azure Portal and sign in with the user account that has the Owner or Contributor role in the Azure subscription you will be using in this lab.

n the Azure portal, search for and select the DevOps Starter resource type and, on the DevOps Starter blade, click + Create.

Lab
Other
Relevant screenshots

Do you want to help us? 👏

[ ] Create a Pull Request by following this project's Contribution Guide

Closing this PR since the lab is now deprecated by #422. Thanks!


Content-Security-Policy-Report-Only

Feature request
Add support for Content-Security-Policy-Report-Only. We can use the standard CSP header with 'contentSecurityPolicy' but it would be nice to be able to instead use it in Report-Only mode. This would help many users to develop their CSP using web-tools before deploying it into their 'production' or (in my case as a home user) homelabs.
What did you expect to see?
contentSecurityPolicyReportOnly in available header middlewares.
Reference
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy-Report-Only

While we wait for this, note that you can use a custom response header:
customResponseHeaders:
  Content-Security-Policy-Report-Only: >-
    connect-src self;
    default-src none;
    font-src self;
    img-src self;
    script-src self;
    style-src self inline-unsafe;

I think it is time to give this request a bump
While it should be possible to use a customResponseHeader to express this, it causes issues when trying to express a configuration as 'infrastructure as code'.
It is very easy to switch between "contentSecurityPolicy" and "Content-Security-Policy-Report-Only" using an environment variable also having to switch between a builtin header definition and a customResponseHeader is not so easy, with the result not being as easy to follow when the config is revisited by another person.
As an example, my definition within a docker-compose file currently looks like this
     - "traefik.http.middlewares.security-headers.headers.${DOCKER_TRAEFIK_CSP_CMD}${DOCKER_TRAEFIK_CSP_LINE1};${DOCKER_TRAEFIK_CSP_LINEEND}"
With a growing number of 'LINEx' variables being added as the CSP becomes more of an essay than a line entry. To support both header types all I would need to do is change the value of DOCKER_TRAEFIK_CSP_CMD to switch between them. Instead, I have to be creative and include more of the traefik label within the environment variable, which makes things harder to read.


Add WalletConnect

it may very well be possible that the wallet is not available on non https domains. i am thinking that is half of the problem i am running into when trying to test locally. can't confirm it though. seeing odd things like
{"error":{"code":-32503,"message":"wallet address undefined"},"id":0,"jsonrpc":"2.0"}

fixes #247

close #247

closes #247

Unfortunately the documentation does not match exported code. this is going to take longer than anticipated

Is this referring to WalletConnect's documentation? Or where can we improve our documentation?

a good move is probably to just find someone who has already implemented and use their code

Hey @3commascapital I'm following up on this. Any luck?


Company Page - Custom Field for Non recurring Service - No Possible way to add

Problem -

Before "Company Page" Auto Billing changes
Company Services (now "Recurring Services") Field was accepting All Service which a Company is Taking (Recurring / Non-Recurring)
Project are scheduled if Service has Scheduler and Company is attached for Service
Now after Auto billing -

Company Services is now "Recurring Services" and not accepting any Services which are non-recurring
so any user who are providing non-recurring service to Company , and have custom field set for Service for Company, are not accepting or no option at all
there should be any way at least

Suggested Solution

None

initiated by @mitulpanch
verified by @vinpahilwani

My take on this

There should at least Option to support Other type of User
If Process Flow can create Project of any Service (Recurring / Non recurring) beyond any settings, this will make things worse for Automation friendly Customers
Any kind of Third Party integrations will require this
A User create Project in No of manners, not only straight way every time
Software should have All easy Option without Ignoring Advance Users
Process Flow is the Future, when we integrate with Other Software this will lead to lot of Problems, because of non support of  advance structures

I think this is taken care by

Company custom fields
Company custom fields based on legal structure field (new feature as suggested by me)

My take on this

There should at least Option to support Other type of User
If Process Flow can create Project of any Service (Recurring / Non recurring) beyond any settings, this will make things worse for Automation friendly Customers
Any kind of Third Party integrations will require this
A User create Project in No of manners, not only straight way every time
Software should have All easy Option without Ignoring Advance Users
Process Flow is the Future, when we integrate with Other Software this will lead to lot of Problems, because of non support of  advance structures

We can have alternate sollution for Point No 2 for Project Creation...is that we can provide ADD Service and REMOVE service  via process flow. It will help in creation of projects.

No possible solution, Closing now


Updates to pipeline artifact packing / publishing

Overview

Moves some more task-y templates into the tasks folder
Clarifies and decouples upm pack/publish from the old nuget pack/publish

/azp run

/azp run

/azp run

/azp run


Fix/listener tests

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
a83c991518e3ded8b08a34bd218fa66bd2f09a5b
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
a83c991518e3ded8b08a34bd218fa66bd2f09a5b
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
a83c991518e3ded8b08a34bd218fa66bd2f09a5b
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
a83c991518e3ded8b08a34bd218fa66bd2f09a5b
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
a83c991518e3ded8b08a34bd218fa66bd2f09a5b
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
a83c991518e3ded8b08a34bd218fa66bd2f09a5b
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
a83c991518e3ded8b08a34bd218fa66bd2f09a5b
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
a83c991518e3ded8b08a34bd218fa66bd2f09a5b
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
a83c991518e3ded8b08a34bd218fa66bd2f09a5b
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
a83c991518e3ded8b08a34bd218fa66bd2f09a5b
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
a83c991518e3ded8b08a34bd218fa66bd2f09a5b
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
a83c991518e3ded8b08a34bd218fa66bd2f09a5b
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
a83c991518e3ded8b08a34bd218fa66bd2f09a5b
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
a83c991518e3ded8b08a34bd218fa66bd2f09a5b
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
a83c991518e3ded8b08a34bd218fa66bd2f09a5b
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
a83c991518e3ded8b08a34bd218fa66bd2f09a5b
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
a83c991518e3ded8b08a34bd218fa66bd2f09a5b
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
f90262579d54ab36fa42435cf6aa320579b823e7
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
a83c991518e3ded8b08a34bd218fa66bd2f09a5b
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
a83c991518e3ded8b08a34bd218fa66bd2f09a5b
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
f091b33651e236fa6a7d3090146797c4636d929b
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
df1fffb67d20a7073b636f0c5b93febe34119e75
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

Benchmark results before/after allocation change
Before :
BenchmarkListenerGeneration/empty-12         	     134	   9295216 ns/op	 2773969 B/op	   37808 allocs/op
BenchmarkListenerGeneration/telemetry-12     	     100	  10570073 ns/op	 3170342 B/op	   42789 allocs/op
BenchmarkListenerGeneration/virtualservice-12        124	   9174470 ns/op	 2774603 B/op	   37812 allocs/op

After :
BenchmarkListenerGeneration/empty-12         	     154	   7735643 ns/op	 2735749 B/op	   37410 allocs/op
BenchmarkListenerGeneration/telemetry-12     	     128	   9000032 ns/op	 3132330 B/op	   42391 allocs/op
BenchmarkListenerGeneration/virtualservice-12        154	   7369656 ns/op	 2736207 B/op	   37413 allocs/op


access-permissions-on-github.md

Why:
Closes [issue link]

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

[x] I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
[x] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[x] This pull request impacts the contribution experience

[x] I have added the 'writer impact' label
[x] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

teste

This seems to have been a test PR, I am going to close it now :yellow_heart:
Take a look at the contributing.md to learn how to contribute in this repo. You can open a discussion if you have any questions or check out issues with the help wanted label. :sparkles:
Thank you for your interest in improving GitHub Docs! :sparkling_heart:


Refactor recent emojis to store up to 18

Signed-off-by: Jay Clark<EMAIL_ADDRESS>Fixes #1
Hello! I came across this issue and was able to implement a fix. The 'recent emoji' section will now show up to 18 recently used unique emojis. As currently written, when you click on a recently used emoji to use it again, that emoji will move to the front of the list (i.e. most recently used.) I think this is the behavior that the extension should have (it just makes a little less sense at the moment because the copy function & copy window is buggy), but if this isn't desired let me know and I can adjust the PR.

@jayeclark

After merge ForEach is not a function error occurred. I searched for this error and found that it was a similar arrangement ('Array-type-object') problem.  It's a link to what a similar arrangement is.
https://developer.mozilla.org/en-US/docs/Web/API/Element/getElementsByTagName
The solution is as follows.
Array.from (Array-type-object).forEach(
function(element, index, array){
// The code that I want to apply.
}
);
After applying the solution it works well.
Thank you very much for spending time on my repo.

Hey, thanks. Is it line 123 that was the issue? I didn’t get any errors on my end and the array that forEach runs on  is just a simple array of strings. I’m familiar with needing to use Array.from() on array-like objects, but what it’s being applied to is just a regular array.
I wonder if the problem is actually that on very first load the local storage is undefined?) That would explain why I didn’t get the error but you did (because once I started working I always had an array in local storage.)
Anyway, sorry about that! I should have uninstalled and reloaded once I got everything working, to test if there were issues with initiation.

@jayeclark
Right, first load the local storage is undefined.
It works well when there is data in local storage,
Error occurs when first load (when there is no recent emoji data in local storage).
And the issue occurred in the underlined part.

You're welcome, you've been very helpful to me. :)

Ah, yep, makes total sense. Sorry for not catching that!


[SPARK-8480] [CORE] [PYSPARK] [SPARKR] Add setName for Dataframe

What changes were proposed in this pull request?
Add name / setName to Dataset/DataFrame in all languages, to match RDD.
How was this patch tested?
New unit tests added for these methods.

@davies do you have any thoughts on this for Python?
And @felixcheung I can't be sure at all I added the method for R correctly.

Test build #66321 has started for PR 15343 at commit 1dbd129.

Test build #66321 has finished for PR 15343 at commit 1dbd129.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66321/
Test FAILed.

How does the storage page looks like after this patch? The cache manager only have logical plan.
Could you show some real use case that the name will be useful?

cc @rxin

Yeah will do. The use case was pretty much what you refer to -- the storage page in my case had huge logical plans as names on the storage page. Which is maybe fine as a default but would be nice, I suppose, to be able to override it. An app or library might benefit from showing a friendlier more meaningful name. I don't feel strongly about it though, mostly just picking up and old JIRA.

@davies I'd appreciate you double checking my concern if the pattern in the python name function is really necessary (or if its not we can maybe take this opportunity to clean it up in rdd.py too).

For R, to make public this should be listed in the NAMESPACE file and the generics.R. Also would be great to add a quick test for this in R/pkg/inst/tests/testthat/test_sparkSQL.R.
I do think there might be a minor naming concern on this - there is already an existing names function on DataFrame to return column names. This new function name might be too similar to it?

Seems useful to have!

@davies OK I think I'm 'fixing' this in the wrong place. RDD.setName() will change the name displayed in the storage tab, but, this new Dataset.setName() won't. You're right that it's always the logical plan, before and after the change:

I think I need to figure out how to plumb through the new Dataset name to make this do the thing I think it's useful for.

Hm, I think I'm going to close this for now because it doesn't actually fix the issue I thought it would, and I honestly could not trace how the cached Dataset logical plan becomes RDD info in the UI. I can trace both ends of it to some degree but don't see the connection in the end. It's reopenable if someone would help with that. Otherwise this might be a method that does nothing but change toString and that's not so useful.

@srowen I would find this really useful, it would be great if it could be made to work.
What happens if you pass the name through to cacheManager.cacheQuery here instead of a None?

@emlyn try it out :) If you can figure out how to pass the name through, feel free to reopen the JIRA and propose a PR.

I've managed to get the name appearing on the storage UI tab by passing it through to the cache manager, PR in #16609.
I'd appreciate any comments (e.g. whether that's a reasonable way to do it at all).


No final result, python error

I frequently get the error below which seems to be non-impacting, but I don't get a final result. I know it's done when I get an adaptation state.
Any ideas?
Thanks!
From /opt/worker.log:
2019-03-26 23:00:45 -    INFO:   decoder2: 76218ab3-2e7f-43ae-8c28-32c40b087d8e: Got partial result: AH LONELY WHAT'S THE WHETHER IN SAN FRANCISCO AUGUST
2019-03-26 23:00:45 -    INFO:   main: 76218ab3-2e7f-43ae-8c28-32c40b087d8e: Postprocessing (final=False) result..
2019-03-26 23:00:45 -   DEBUG:       root: 76218ab3-2e7f-43ae-8c28-32c40b087d8e: Starting postprocessing: AH LONELY WHAT'S THE WHETHER IN SAN FRANCISCO AUGUST
2019-03-26 23:00:45 -   ERROR: tornado.application: Future exception was never retrieved: Traceback (most recent call last):
File "/usr/local/lib/python2.7/dist-packages/tornado/gen.py", line 1107, in run
yielded = self.gen.throw(*exc_info)
File "/opt/kaldi-gstreamer-server/kaldigstserver/worker.py", line 214, in _on_full_result
full_result = yield self.post_process_full(full_result)
File "/usr/local/lib/python2.7/dist-packages/tornado/gen.py", line 1099, in run
value = future.result()
File "/usr/local/lib/python2.7/dist-packages/tornado/concurrent.py", line 260, in result
raise_exc_info(self._exc_info)
File "/usr/local/lib/python2.7/dist-packages/tornado/gen.py", line 315, in wrapper
yielded = next(result)
File "/opt/kaldi-gstreamer-server/kaldigstserver/worker.py", line 335, in post_process_full
self.full_post_processor.stdin.write("%s\n\n" % json.dumps(full_result))
IOError: [Errno 32] Broken pipe
2019-03-26 23:00:45 -    INFO:   main: a133dca6-c4a3-4490-8799-5b8e3a993bbd: Sending adaptation state to client...
2019-03-26 23:00:45 -   DEBUG:       root: 76218ab3-2e7f-43ae-8c28-32c40b087d8e: Postprocessing returned: AH LONELY WHAT'S THE WHETHER IN SAN FRANCISCO AUGUST.
2019-03-26 23:00:45 -    INFO:   main: 76218ab3-2e7f-43ae-8c28-32c40b087d8e: Postprocessing done.

I'm having the same issue, the worker seems to be dropping the EOS (even though it was sent) and keeps waiting for it.
The problem is likely to be in the worker and not in the client as I'm experiencing this behavior with a custom written/completely independent client.
As a work around I'm trying to keep sending EOS until I get a final hypothesis back from the worker.
Note: This issue is a duplication from #180

subprocess.stdin.write's arguments should be byte type.

you have to convert string to byte like self.full_post_processor.stdin.write("{0}\n\n".format(json.dumps(full_result))).
Use sys.stdin.buffer.readline() instead of sys.stdin.readline() in sample_full_post_processor to read into bytes and decoding the data.
you decode self.full_post_processor.stdout.readline() (subprocess.stdout.readline() return byte type)


test: more json escape test

Pull Request Test Coverage Report for Build 2780
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 85.46%

Totals

Change from base Build 2777:
0.0%

Covered Lines:
3738

Relevant Lines:
4374

💛  - Coveralls


Avoid users having to cast resource handlers to raw types

Reviewer checklist

[ ] Ensure relevant issues are linked (description should include text like "Fixes #")
[ ] Ensure any appropriate documentation has been added or amended

Coverage increased (+0.02%) to 99.614% when pulling b345518e90182dcaf6e167cdf942de60c77a7699 on avoid_raw into babc4881cd781709ea41e6684161b4166c26295e on main.


[MLS Spec change] Enforce uniqueness of PreSharedKeyIDs in PreSharedKey proposals (#579)

Description of the changes
As the title says.
Link to the exact changes
https://github.com/mlswg/mls-protocol/pull/579

Can you assign me this issue please?

So it seems the change referred in the ticket was undone by this commit. Should I do it anyways?

@raphaelrobert, could you help here?

It looks like this has moved indeed. There's nothing to do about this issue.


Household Account Settings are not respected for Household Naming

Critical Changes
Changes
Issues Closed
New Metadata
Unpackaged Metadata
Deleted Metadata
Testing Notes

Looks good. Approved!

QA Passes, Merging


Tinygo

I was playing with the code
the way gs and indexdb is used is really impressive and highly useful
I am thinking that tinygo might be mature enough to deal with this code now .
the main thing was to avoid reflection ( like the standard golang json encoder ). The solution was generally to use flatbuffers.
Flatbuffers is nature now and very useable .
Anyways your project is really awesome . Just wanted to add my thoughts about strategies for using tinygo :)
if you need examples of what I am referring to above just yell

What about a separate branch so others can help port code to tinygo ?

Hey again @gedw99! 🙂 That would be interesting.
I think I'd first need to understand the differences between Go's and TinyGo's Wasm syscalls setup. Go Wasm may be able to accommodate another runtime if they're compatible. I see some mentions of Wasm in the tinygo repo, but I didn't find the "js implementation of syscalls" right away. Are you familiar with tinygo's runtime?

Yes I am using tinygo and there are tons of examples of other gophers using it.
Tinygo standard lib is a good doc !
https://tinygo.org/docs/reference/lang-support/
https://tinygo.org/docs/reference/lang-support/stdlib/
Reflection and net ( http ) are not yet supported. But PR’s are merging in every few days for it. They generally copy the official golang code in and then just clean it up so it works with tinygo.
For the reflection problem just use the JSON that genji uses.
https://github.com/genjidb/genji/blob/main/go.mod#L6
This is where they compile to tinygo:
https://github.com/genjidb/genji.js
They recently stopped using tinygo because of a minor bug.
there are many many projects using tinygo for WASI also but more for servers of course
if you want more examples or whatever just yell :)

Hmm this ?
https://github.com/tinygo-org/playground/blob/master/runner.js

Hey @gedw99, FYI Go Wasm is now Hackpad!
I may be splitting things into new even more repos in the coming weeks, possibly including the runtime and the Go installation system. We may take another look at tinygo with all these changes 🙂

thanks @JohnStarich for letting me know.
I will kick the tires....


[Suggestion] Staff of Traveling Upgrades

Can you, like for the Dark Armor, add "Enchant upgrades" for the staff ?
You can maybe reduce the base energy storage of the staff to 100kRf and make like :
Basic Capacitor + 10lvl = 250krf
Double-layer Capacitor + 15lvl = 500krf
Octadic Capacitor + 20lvl = 1MRf

@CrazyPants why are you closing that without even answering something ? -_-

because adding a comment to over 650 old tickets would be an insane amount of work?

ofc if you wait 2 years without answering anything... the solution is not to close everything in one row and start again wtf :D


Allow auto merge to Dependabot PR if they pass CI

This is a blatant copy of @HarelM's https://github.com/maplibre/maplibre-gl-js/pull/2345 . Should ease up maintenance a bit.

Let me know if this works :-) I haven't tested it yet... I hope it will do the job...

They adjusted the code in https://github.com/maplibre/maplibre-gl-js/pull/2345, do we need to update this PR too?

They adjusted the code in maplibre/maplibre-gl-js#2345, do we need to update this PR too?

Yes, very likely. They've enabled it three days ago, so I'd ilke to wait a bit and see if it really works as expected (before enabling it on the Leaflet repo).

Got something similar that we used for a recent project of mine.

I think the above didn't work as expected for maplibre. If you find a good solution, let me know...


Unable to change borderColor color for blinkOn style

Version info:
block-cursor: 0.13.1
Atom: 1.0.3
No matter if I change directly in config or via settings, borderColor is not reflecting. It's always coming by default as white. Pls. let me know how to correct it.
Here is how my config looks:
"block-cursor":
    selector: "atom-text-editor"
    scopes: [
      "*"
    ]
    blinkOn:
      backgroundColor: "transparent"
      borderStyle: "i-beam"
      borderColor: "red"
      borderWidth: 2
    blinkOff:
      backgroundColor: "transparent"
      borderStyle: "none"
      borderColor: "transparent"
      borderWidth: 1
    pulseDuration: 800
    cursorLineFix: true
    global:
      blinkOn:
        backgroundColor:
          red: 0
          green: 0
          blue: 0
          alpha: 1
        borderColor:
          red: 49
          green: 39
          blue: 233
          alpha: 1
        borderStyle: "i-beam"
        borderWidth: 3
      blinkOff:
        backgroundColor:
          red: 0
          green: 0
          blue: 0
          alpha: 0
        borderStyle: "none"
        borderColor:
          red: 0
          green: 0
          blue: 0
          alpha: 0
      pulseDuration: 900
      cursorLineFix: true

I took the liberty to change that thing into something readable :) Hope you don't mind.
The structure of the config should be:
'*':
  'block-cursor':
    'global':
      'blinkOn':
        # blink on styling
      'blinkOff':
        # blink off styling
    'cursorType2':
      'blinkOff':
        # ...
    'cursorType3':
      # ...

It looks like you're trying to set the properties directly on the "block-cursor" object, though they should be on one of the cursorTypes. Try to override the global style for example:
  'block-cursor':
    'global':
      selector: "atom-text-editor"
      scopes: [
        "*"
      ]
      blinkOn:
        backgroundColor: "transparent"
        borderStyle: "i-beam"
        borderColor: "red"
        borderWidth: 2
      blinkOff:
        backgroundColor: "transparent"
        borderStyle: "none"
        borderColor: "transparent"
        borderWidth: 1
      pulseDuration: 800
      cursorLineFix: true

I'll see if I can find a better solution for the config in the future, it's quite complicated...

I changed it to the above format, still borderColor in blinkOn doesn't applies correctly, it's just plain white.
All other color changes work fine.
Also, to let you know, this issue is there since v0.13.0
I do doubt on any package/theme conflict. I've a hell lot of them installed.
Could it be the issue?
Let me know any more info you need to fix this.

Hmm, it seems to work just fine for me. I'll look into it. Please try it with Atom's default themes, one-dark or one-light.

I got the issue! You were right. It works with all syntax themes except a few..
I was using Brahalla-syntax theme which is based off Seti-syntax.
Cursor remains white in Seti-syntax too.
So, it is possible to make it work for Seti-syntax too ?

Aha! I'll look into it. Shouldn't be too hard.

I just looked at Seti syntax, and it sets the !important flag on the border color of the cursor... There's not a lot I can do about that, except for also setting the !important flag, but I don't want to go down that road. I suggest you open an issue on the respective repositories to remove the flag