imgui[metal-binding] build failure

Host Environment

OS: OSX 10.15.7
Compiler: clang-1<IP_ADDRESS>

To Reproduce
Steps to reproduce the behavior:
./vcpkg install imgui[metal-binding]
Failure logs
The following packages will be built and installed:
    imgui[core,metal-binding]:x64-osx -> 1.79#4
Detecting compiler hash for triplet x64-osx...
Could not locate cached archive: /Users/kristijan/.cache/vcpkg/archives/98/983120f2ec7b2a614622a31b9d050cd651a375b8.zip
Starting package 1/1: imgui:x64-osx
Building package imgui[core,metal-binding]:x64-osx...
-- Using cached /Users/kristijan/Projects/portscanner/vcpkg/downloads/ocornut-imgui-v1.79.tar.gz
-- Cleaning sources at /Users/kristijan/Projects/portscanner/vcpkg/buildtrees/imgui/src/v1.79-6f119773fb.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source /Users/kristijan/Projects/portscanner/vcpkg/downloads/ocornut-imgui-v1.79.tar.gz
-- Using source at /Users/kristijan/Projects/portscanner/vcpkg/buildtrees/imgui/src/v1.79-6f119773fb.clean
-- Configuring x64-osx-dbg
-- Configuring x64-osx-rel
-- Building x64-osx-dbg
CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:145 (message):
    Command failed: /Users/kristijan/Projects/portscanner/vcpkg/downloads/tools/cmake-3.19.2-osx/cmake-3.19.2-macos-universal/CMake.app/Contents/bin/cmake --build . --config Debug --target install -- -v -j13
    Working Directory: /Users/kristijan/Projects/portscanner/vcpkg/buildtrees/imgui/x64-osx-dbg
    See logs for more information:
      /Users/kristijan/Projects/portscanner/vcpkg/buildtrees/imgui/install-x64-osx-dbg-out.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_build_cmake.cmake:96 (vcpkg_execute_build_process)
  scripts/cmake/vcpkg_install_cmake.cmake:27 (vcpkg_build_cmake)
  ports/imgui/portfile.cmake:73 (vcpkg_install_cmake)
  scripts/ports.cmake:128 (include)

Error: Building package imgui:x64-osx failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `./vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: imgui:x64-osx
  Vcpkg version: 2021-01-13-unknownhash

Additionally, attach any relevant sections from the log files above.

install-x64-osx-dbg-out.log:
[1/8] /Library/Developer/CommandLineTools/usr/bin/c++  -I/Users/kristijan/Projects/portscanner/vcpkg/buildtrees/imgui/src/v1.79-6f119773fb.clean -fPIC -g -arch x86_64 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk -MD -MT CMakeFiles/imgui.dir/misc/cpp/imgui_stdlib.cpp.o -MF CMakeFiles/imgui.dir/misc/cpp/imgui_stdlib.cpp.o.d -o CMakeFiles/imgui.dir/misc/cpp/imgui_stdlib.cpp.o -c /Users/kristijan/Projects/portscanner/vcpkg/buildtrees/imgui/src/v1.79-6f119773fb.clean/misc/cpp/imgui_stdlib.cpp
[2/8] /Library/Developer/CommandLineTools/usr/bin/c++  -I/Users/kristijan/Projects/portscanner/vcpkg/buildtrees/imgui/src/v1.79-6f119773fb.clean -fPIC -g -arch x86_64 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk -MD -MT CMakeFiles/imgui.dir/imgui_demo.cpp.o -MF CMakeFiles/imgui.dir/imgui_demo.cpp.o.d -o CMakeFiles/imgui.dir/imgui_demo.cpp.o -c /Users/kristijan/Projects/portscanner/vcpkg/buildtrees/imgui/src/v1.79-6f119773fb.clean/imgui_demo.cpp
[3/8] /Library/Developer/CommandLineTools/usr/bin/c++  -I/Users/kristijan/Projects/portscanner/vcpkg/buildtrees/imgui/src/v1.79-6f119773fb.clean -fPIC -g -arch x86_64 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk -MD -MT CMakeFiles/imgui.dir/imgui_draw.cpp.o -MF CMakeFiles/imgui.dir/imgui_draw.cpp.o.d -o CMakeFiles/imgui.dir/imgui_draw.cpp.o -c /Users/kristijan/Projects/portscanner/vcpkg/buildtrees/imgui/src/v1.79-6f119773fb.clean/imgui_draw.cpp
[4/8] /Library/Developer/CommandLineTools/usr/bin/c++  -I/Users/kristijan/Projects/portscanner/vcpkg/buildtrees/imgui/src/v1.79-6f119773fb.clean -fPIC -g -arch x86_64 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk -MD -MT CMakeFiles/imgui.dir/imgui_widgets.cpp.o -MF CMakeFiles/imgui.dir/imgui_widgets.cpp.o.d -o CMakeFiles/imgui.dir/imgui_widgets.cpp.o -c /Users/kristijan/Projects/portscanner/vcpkg/buildtrees/imgui/src/v1.79-6f119773fb.clean/imgui_widgets.cpp
[5/8] /Library/Developer/CommandLineTools/usr/bin/c++  -I/Users/kristijan/Projects/portscanner/vcpkg/buildtrees/imgui/src/v1.79-6f119773fb.clean -fPIC -g -arch x86_64 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk -MD -MT CMakeFiles/imgui.dir/imgui.cpp.o -MF CMakeFiles/imgui.dir/imgui.cpp.o.d -o CMakeFiles/imgui.dir/imgui.cpp.o -c /Users/kristijan/Projects/portscanner/vcpkg/buildtrees/imgui/src/v1.79-6f119773fb.clean/imgui.cpp
[6/8] /Library/Developer/CommandLineTools/usr/bin/c++  -I/Users/kristijan/Projects/portscanner/vcpkg/buildtrees/imgui/src/v1.79-6f119773fb.clean -fPIC -g -arch x86_64 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk -MD -MT CMakeFiles/imgui.dir/examples/imgui_impl_metal.mm.o -MF CMakeFiles/imgui.dir/examples/imgui_impl_metal.mm.o.d -o CMakeFiles/imgui.dir/examples/imgui_impl_metal.mm.o -c /Users/kristijan/Projects/portscanner/vcpkg/buildtrees/imgui/src/v1.79-6f119773fb.clean/examples/imgui_impl_metal.mm
FAILED: CMakeFiles/imgui.dir/examples/imgui_impl_metal.mm.o
/Library/Developer/CommandLineTools/usr/bin/c++  -I/Users/kristijan/Projects/portscanner/vcpkg/buildtrees/imgui/src/v1.79-6f119773fb.clean -fPIC -g -arch x86_64 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk -MD -MT CMakeFiles/imgui.dir/examples/imgui_impl_metal.mm.o -MF CMakeFiles/imgui.dir/examples/imgui_impl_metal.mm.o.d -o CMakeFiles/imgui.dir/examples/imgui_impl_metal.mm.o -c /Users/kristijan/Projects/portscanner/vcpkg/buildtrees/imgui/src/v1.79-6f119773fb.clean/examples/imgui_impl_metal.mm
/Users/kristijan/Projects/portscanner/vcpkg/buildtrees/imgui/src/v1.79-6f119773fb.clean/examples/imgui_impl_metal.mm:540:5: error: cannot create __weak reference in file using manual reference counting
    __weak id weakSelf = self;
    ^
1 error generated.
ninja: build stopped: subcommand failed.

Additional context
I could successfully build the metal-binding package by adding add_compile_options(-fobjc-arc) to the CMakeLists.txt in the imgui port folder.

@krisweiss ,I added add_compile_options(-fobjc-arc) to CMakeLists according to the method you said, but I still can’t compile imgui[metal-binding] successfully. The following figure shows the location I added:
CMakeLists.txt:
cmake_minimum_required(VERSION 3.8)
project(imgui CXX)

set(CMAKE_DEBUG_POSTFIX d)

add_library(${PROJECT_NAME} "")
add_library(${PROJECT_NAME}::${PROJECT_NAME} ALIAS ${PROJECT_NAME})

1080:portscanner kristijan$ ./vcpkg/vcpkg remove imgui[metal-binding]
The following packages are not installed, so not removed:
    imgui:x64-osx
Package imgui:x64-osx is not installed
1080:portscanner kristijan$ ./vcpkg/vcpkg install imgui[metal-binding]
Computing installation plan...
The following packages will be built and installed:
    imgui[core,metal-binding]:x64-osx -> 1.79#4
Detecting compiler hash for triplet x64-osx...
Could not locate cached archive: /Users/kristijan/.cache/vcpkg/archives/98/983120f2ec7b2a614622a31b9d050cd651a375b8.zip
Starting package 1/1: imgui:x64-osx
Building package imgui[core,metal-binding]:x64-osx...
-- Using cached /Users/kristijan/Projects/portscanner/vcpkg/downloads/ocornut-imgui-v1.79.tar.gz
-- Cleaning sources at /Users/kristijan/Projects/portscanner/vcpkg/buildtrees/imgui/src/v1.79-6f119773fb.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source /Users/kristijan/Projects/portscanner/vcpkg/downloads/ocornut-imgui-v1.79.tar.gz
-- Using source at /Users/kristijan/Projects/portscanner/vcpkg/buildtrees/imgui/src/v1.79-6f119773fb.clean
-- Configuring x64-osx-dbg
-- Configuring x64-osx-rel
-- Building x64-osx-dbg
CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:145 (message):
    Command failed: /Users/kristijan/Projects/portscanner/vcpkg/downloads/tools/cmake-3.19.2-osx/cmake-3.19.2-macos-universal/CMake.app/Contents/bin/cmake --build . --config Debug --target install -- -v -j13
    Working Directory: /Users/kristijan/Projects/portscanner/vcpkg/buildtrees/imgui/x64-osx-dbg
    See logs for more information:
      /Users/kristijan/Projects/portscanner/vcpkg/buildtrees/imgui/install-x64-osx-dbg-out.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_build_cmake.cmake:96 (vcpkg_execute_build_process)
  scripts/cmake/vcpkg_install_cmake.cmake:27 (vcpkg_build_cmake)
  ports/imgui/portfile.cmake:73 (vcpkg_install_cmake)
  scripts/ports.cmake:128 (include)

Error: Building package imgui:x64-osx failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `./vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: imgui:x64-osx
  Vcpkg version: 2021-01-13-unknownhash

Additionally, attach any relevant sections from the log files above.
1080:portscanner kristijan$ ./vcpkg/vcpkg install imgui[metal-binding]
Computing installation plan...
The following packages will be built and installed:
    imgui[core,metal-binding]:x64-osx -> 1.79#4
Detecting compiler hash for triplet x64-osx...
Using cached binary package: /Users/kristijan/.cache/vcpkg/archives/7d/7d63b3d6aa5ca16dd636cda80c30b969734511b6.zip
Starting package 1/1: imgui:x64-osx
Building package imgui[core,metal-binding]:x64-osx...
Building package imgui[core,metal-binding]:x64-osx... done
Installing package imgui[core,metal-binding]:x64-osx...
Installing package imgui[core,metal-binding]:x64-osx... done
Elapsed time for package imgui:x64-osx: 37.83 ms

Total elapsed time: 1.181 s

The package imgui:x64-osx provides CMake targets:

    find_package(imgui CONFIG REQUIRED)
    target_link_libraries(main PRIVATE imgui::imgui)

It works for me when I add it in the same place.
Can I provide something else that would help the issue?
I'm installing vcpkg as a submodule.
I can also make the repo I use public so you can test it if you wish.

@krisweiss ,I tried several times locally, and even deleted vcpkg and re-clone to test, but still no success. From the error point of view, it does not seem to be a vcpkg error. I need to continue to investigate and determine whether to submit pr.Thanks for posting this issue
error: cannot create __weak reference in file using manual reference counting
    __weak id weakSelf = self;
    ^

Thank you for your effort.
The function that uses the __weak reference is only present in example/imgui_impl_metal.mm which isn't used by the bindings at all.
As a "dirty" workaround you can just patch it and change __weak with __unsafe_unretained. I'm by no means competent enough with objective-C and the Apple ecosystem to say if this is fine or a terrible way to do this.
What I did:
vcpkg/ports/imgui/0001-metal-binding.patch
diff -Naur imgui-1.79/examples/imgui_impl_metal.mm imgui-1.79.patched/examples/imgui_impl_metal.mm
--- imgui-1.79/examples/imgui_impl_metal.mm	2020-10-08 16:01:59.000000000 +0200
+++ imgui-1.79.patched/examples/imgui_impl_metal.mm	2021-02-09 16:41:00.000000000 +0100
@@ -537,7 +537,7 @@
         indexBufferOffset += cmd_list->IdxBuffer.Size * sizeof(ImDrawIdx);
     }

-    __weak id weakSelf = self;
+    __unsafe_unretained id weakSelf = self;
     [commandBuffer addCompletedHandler:^(id<MTLCommandBuffer>)
     {
         dispatch_async(dispatch_get_main_queue(), ^{

and added to vcpkg/ports/imgui/0001-metal-binding.patch:
else()
    vcpkg_from_github(
    OUT_SOURCE_PATH SOURCE_PATH
    REPO ocornut/imgui
    REF v1.79
    SHA512 35ed7af89123e09989ef81085f19ed15f97f4798e2b35834fd8b4ae918889b51132d85901f867ab2f379711a734bc7b2edd309d74f3f7527eaaaebfd766d3737
    HEAD_REF master
    PATCHES
        0001-metal-binding.patch
    )
endif()

@krisweiss Sorry for late, can you please report this to imgui?
Thanks.

@krisweiss, Is this problem solved? I can't reproduce this problem locally with the latest vcpkg version
vcpkg@VCPKGMM-12 vcpkg % ./vcpkg install "imgui[metal-binding]" --editable
Computing installation plan...
A suitable version of cmake was not found (required v3.21.1). Downloading portable cmake v3.21.1...
Downloading cmake...
  https://github.com/Kitware/CMake/releases/download/v3.21.1/cmake-3.21.1-macos-universal.tar.gz -> /Users/vcpkg/Jon/vcpkg/downloads/cmake-3.21.1-macos-universal.tar.gz
Extracting cmake...
The following packages will be built and installed:
    imgui[core,metal-binding]:x64-osx -> 1.86
  * vcpkg-cmake[core]:x64-osx -> 2021-12-20
  * vcpkg-cmake-config[core]:x64-osx -> 2021-12-28
Additional packages (*) will be modified to complete this operation.
Detecting compiler hash for triplet x64-osx...
Restored 2 packages from /Users/vcpkg/.cache/vcpkg/archives in 14.06 ms. Use --debug to see more details.
Starting package 1/3: vcpkg-cmake:x64-osx
Installing package vcpkg-cmake[core]:x64-osx...
Elapsed time for package vcpkg-cmake:x64-osx: 4.537 ms
Starting package 2/3: vcpkg-cmake-config:x64-osx
Installing package vcpkg-cmake-config[core]:x64-osx...
Elapsed time for package vcpkg-cmake-config:x64-osx: 2.909 ms
Starting package 3/3: imgui:x64-osx
Building package imgui[core,metal-binding]:x64-osx...
-- Downloading https://github.com/ocornut/imgui/archive/v1.86.tar.gz -> ocornut-imgui-v1.86.tar.gz...
-- Extracting source /Users/vcpkg/Jon/vcpkg/downloads/ocornut-imgui-v1.86.tar.gz
-- Using source at /Users/vcpkg/Jon/vcpkg/buildtrees/imgui/src/v1.86-7944920afc
-- Found external ninja('1.10.2').
-- Configuring x64-osx-dbg
-- Configuring x64-osx-rel
-- Building x64-osx-dbg
-- Building x64-osx-rel
-- Installing: /Users/vcpkg/Jon/vcpkg/packages/imgui_x64-osx/share/imgui/copyright
-- Performing post-build validation
-- Performing post-build validation done
Installing package imgui[core,metal-binding]:x64-osx...
Elapsed time for package imgui:x64-osx: 15.95 s

Total elapsed time: 22.66 s

The package imgui provides CMake targets:

    find_package(imgui CONFIG REQUIRED)
    target_link_libraries(main PRIVATE imgui::imgui)

I'm terribly sorry for the late response.
I cannot reproduce the issue anymore with the latest vcpkg build so I'll close this issue.
Thank you for keeping track of the issue.


Pick random temaplate to provision in case several matches the label

In case the first matching template got misconfigured (unable to provision, snapshot not working, etc.), plugin keeps picking it for further provisioning. It would be better to pick one at random if more matches the label to avoid it. Additional advantage is it will constantly test all other templates for early problem discovery.

This can, however, cause problems to people that for some reason do not want to provision one of the latter templates unless necessary. Consider job that can run everywhere will pick a template that takes several times longer to provision, uses more resources, will use limited number of licences, etc. An alternative can be to detect one template have a poor provisioning success record and move on to a more stable.

We can implement better heuristics once https://github.com/jenkinsci/cloud-stats-plugin gets ready.

Hi, I think that the list of templates should be ordered (templates with less resources are first) and plugin should use first matching template. If the provisioning fails then plugin can continue to next template in ordered list. It can safe some resources.


Does not pull views from Tableau

Installed and configured the application as described in the readme file and am unable to pull any views in from Tableau.
I noticed that there are a few issues in the master branch.

There is a left over merge comment in selfserviceanalytics.html
The application could not resolve the reference to scl-alpha.js
The application could not resolve the reference to tableau-server-client.js

@matthewreily thanks for posting this. will take a look to see what is wrong.

@matthewreily Thanks again for reporting these issues. I've resolved the issues you reported:

Cleaned these up. Looks like there was a conflict that we missed when we renamed 'tableau-server-client.js' to 'scl-alpha.js'.
added 'scl-alpha.js' to the webpack config file.
removed references to 'tableau-server-client.js'

I also added 'ArtistFinder.twbx' to the repo. This workbook needs to be published to your server if you are going to use the New Artist Finder page and the d3 network diagram.
Let us know if you run into any other issues.

Thanks @benlower! I'll run through it in the morning and let you know if I run into any other issues.  I appreciate you taking the time to look at this.


Correction for raw affiliation Inserm U1242, University of Rennes, Centre de Lutte Contre le Cancer Eugene Marquis, Rennes, France

Correction needed for raw affiliation Inserm U1242, University of Rennes, Centre de Lutte Contre le Cancer Eugene Marquis, Rennes, France
raw_affiliation_name: Inserm U1242, University of Rennes, Centre de Lutte Contre le Cancer Eugene Marquis, Rennes, France
new_rors: 01yezas83;02vjkv261;015m7wh34;00bf6bf92
previous_rors: 01yezas83;02vjkv261;015m7wh34
works_examples: W4360960443
contact: e6c6d311ac3f4753741c4db40cf1800c:322b540c4d7dd32de5db98abb10b7acf @ univ-rennes.fr

This issue was accepted and ingested by the OpenAlex team on 2024-10-10. The new affiliations should be visible within the next 7 days.


Figures not loading: "ReferenceError: atob is not defined"

Environment data

VS Code version: 1.59.0-insider (user setup)
Jupyter Extension version: v2021.8.1066828098
Python Extension version: v2021.7.1060902895
OS and version: Windows_NT x64 10.0.19041
Python and/or Anaconda version: Python 3.8.5 & Conda 4.10.3
Type of virtual environment used : conda
Jupyter server running: Local

After the last update of vscode, all my notebooks were unable to render figures. Installing previous versions of the extensions didn't fix the issue. Here is a full log from one of the figures:

Log
ReferenceError: atob is not defined
  at d (c:\Users\Usuario\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\extensions\ipynb\dist\ipynbMain.js:1:138755)
  at y (c:\Users\Usuario\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\extensions\ipynb\dist\ipynbMain.js:1:143435)
  at v (c:\Users\Usuario\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\extensions\ipynb\dist\ipynbMain.js:1:143731)
  at Array.map (<anonymous>)
  at c:\Users\Usuario\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\extensions\ipynb\dist\ipynbMain.js:1:144883
  at c:\Users\Usuario\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\extensions\ipynb\dist\ipynbMain.js:1:145125
  at c:\Users\Usuario\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\extensions\ipynb\dist\ipynbMain.js:1:145132
  at Array.map (<anonymous>)
  at e.jupyterNotebookModelToNotebookData (c:\Users\Usuario\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\extensions\ipynb\dist\ipynbMain.js:1:144441)
  at e.NotebookSerializer.deserializeNotebook (c:\Users\Usuario\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\extensions\ipynb\dist\ipynbMain.js:1:146368)
  at _.$dataToNotebook (c:\Users\Usuario\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:85:211883)
  at d._doInvokeHandler (c:\Users\Usuario\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:89:12819)
  at d._invokeHandler (c:\Users\Usuario\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:89:12503)
  at d._receiveRequest (c:\Users\Usuario\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:89:11107)
  at d._receiveOneMessage (c:\Users\Usuario\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:89:10142)
  at c:\Users\Usuario\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:89:8039
  at u.fire (c:\Users\Usuario\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:57:1712)
  at l.fire (c:\Users\Usuario\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:65:15825)
  at c:\Users\Usuario\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:104:30061
  at u.fire (c:\Users\Usuario\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:57:1712)
  at l.fire (c:\Users\Usuario\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:65:15825)
  at r._receiveMessage (c:\Users\Usuario\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:65:21091)
  at c:\Users\Usuario\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:65:17969
  at u.fire (c:\Users\Usuario\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:57:1712)
  at v.acceptChunk (c:\Users\Usuario\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:65:13186)
  at c:\Users\Usuario\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:65:12534
  at Socket.w (c:\Users\Usuario\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:104:13219)
  at Socket.emit (events.js:315:20)
  at addChunk (internal/streams/readable.js:309:12)
  at readableAddChunk (internal/streams/readable.js:284:9)
  at Socket.Readable.push (internal/streams/readable.js:223:10)
  at Pipe.onStreamRead (internal/stream_base_commons.js:188:23)

Dupe of #microsoft/vscode#129212
Should be fixed in tomorrow's VS code insiders build.

Are you sure its the same issue? I am positive it should be a vscode issue though, should I post it there instead?

@DonJayamanne do you have any thoughts?
There's another VS code issue which matches what you're seeing @grudloff :
https://github.com/microsoft/vscode/issues/129393

I've closed the upstream issue mentioning where it has been fixed.


False positive for Style/SelectByRegexp

I have the following code:
self.foos.select do |foo| # C: [Correctable] Style/SelectByRegexp: Prefer grep to select with a regexp match.
  foo.match?(:bar)
end

Rubocop expects self.foos.grep(:bar).
self.foos is an ActiveRecord association. match? is a function we wrote on a specific ActiveRecord model. It takes 1 required positional argument and 2 optional keyword arguments. Neither the receiver nor the argument to match? are a Regexp or String here.

Expected behavior
Rubocop would see that a Regexp with a String are not at play, and not register an offense.
Actual behavior
Rubocop registers an offense that it claims it can autocorrect, but the suggested change doesn't actually work.
Steps to reproduce the problem

class Foo < ApplicationRecord
  has_many :blahs

  def things
    self.blahs.select do |blah|
      blah.match?(:bar)
    end
  end

end

class Blah < ApplicationRecord
  belongs_to :foo

  def match?(opt)
    opt == :bar
  end

end

RuboCop version
$ rubocop -V
1.22.1 (using Parser <IP_ADDRESS>, rubocop-ast 1.12.0, running on ruby 2.7.4 x86_64-linux)
  - rubocop-performance 1.11.5
  - rubocop-rails 2.12.4
  - rubocop-rspec 2.5.0

Is there a way for Rubocop to understand that there's no Regexps involved? It's not aware of the datatype of foo in my original example, is it?

Nope. Rubocop does not know datatypes of variables since it is a static analyzer. I am not sure if rubocop should handle this case.

Seems like there's not much Rubocop can do on this. So I'll just close it.


Question about how to use envoy Oauth2

If you are reporting any crash or any potential security issue, do not
open an issue in this repo. Please report the issue via emailing
<EMAIL_ADDRESS>where the issue will be triaged appropriately.
Title: Question about how to use envoy Oauth2
Description:
I very want to learn how to use envoy's Oauth2 functionality. Is it possible can integrate with github Oauth or Azure AD Outh2 ? If yes, is someone can provide example let me understand how to use that.and I also not quite understand what if the sds_config I need to provide. I look at the test case, but not find any thing related.
I am not sure what this line mean:
credentials:
client_id: foo
token_secret:
name: token
sds_config:
path: "/etc/envoy/token-secret.yaml"
hmac_secret:
name: hmac
sds_config:
path: "/etc/envoy/hmac.yaml"
[optional Relevant Links:]

Any extra documentation required to understand the issue.

Maybe related to #13637.
cc: @williamsfu99

Thank you, i think it is similar

@hsuyuming
Did you find what you were looking for in the other thread?

The documentation is wrong regarding the token and hmac. If you want to reference a file for the token and hmac, they have to be in separate files that look like this:
resources:
- "@type": "type.googleapis.com/envoy.extensions.transport_sockets.tls.v3.Secret"
  name: hmac
  generic_secret:
    secret:
      inline_string: g1iXBWBfGSIBgIyTcG699G/Zh+Ty20kW+BWiO6aYhwM=

The example "yaml file" provided for defining the credentials only works if it's defined in your envoy.yaml config file where the oauth filter is defined.
Please fix the documentation. I spent probably 4 hours trying to figure out how to do this, and managed to figure it out after looking at https://github.com/envoyproxy/envoy/issues/13637#issuecomment-715536227


import fail: SyntaxError: invalid syntax

I installed manim by conda install -c conda-forge manim.
Imported manim and ran some examples on jupyter notebook successful last day, until raised dvisvgm not found.
Then I installed and updated some depends for dvisvgm include Clipper2, FreeType2, Ghostscript, Kpathsea, potracelib, ttfautohint, woff2 , brotli , xxHash, zlib.
Finally make install dvisvgm , and manim.NumberPlane().add_coordinates() run OK.
But the other day (today), when import manim , it went wrong:
Python 3.12.4 | packaged by conda-forge | (main, Jun 17 2024, 10:23:07) [GCC 12.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import manim
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/soma/gs/envs/opt/lib/python3.12/site-packages/manim/__init__.py", line 51, in <module>
    from .mobject.graph import *
  File "/home/soma/gs/envs/opt/lib/python3.12/site-packages/manim/mobject/graph.py", line 14, in <module>
    import networkx as nx
  File "/home/soma/gs/envs/opt/lib/python3.12/site-packages/networkx/__init__.py", line 23, in <module>
    config = utils.backends._set_configs_from_environment()
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/soma/gs/envs/opt/lib/python3.12/site-packages/networkx/utils/backends.py", line 574, in _set_configs_from_environment
    backends=Config(
             ^^^^^^^
  File "/home/soma/gs/envs/opt/lib/python3.12/site-packages/networkx/utils/configs.py", line 84, in __new__
    cls = dataclass(
          ^^^^^^^^^^
  File "/home/soma/gs/envs/opt/lib/python3.12/dataclasses.py", line 1265, in wrap
    return _process_class(cls, init, repr, eq, order, unsafe_hash,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/soma/gs/envs/opt/lib/python3.12/dataclasses.py", line 1063, in _process_class
    _init_fn(all_init_fields,
  File "/home/soma/gs/envs/opt/lib/python3.12/dataclasses.py", line 619, in _init_fn
    return _create_fn('__init__',
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/home/soma/gs/envs/opt/lib/python3.12/dataclasses.py", line 473, in _create_fn
    exec(txt, globals, ns)
  File "<string>", line 1
    def __create_fn__(__dataclass_type_nx-loopback__, __dataclass_HAS_DEFAULT_FACTORY__, __dataclass_builtins_object__, __dataclass_return_type__):
                                         ^
SyntaxError: invalid syntax

I've try reinstall manim but not work. May it a C lib issue? Which lib?

it's strange when I change my env to another, import goes well !!!!
Python 3.12.0 | packaged by conda-forge | (main, Oct  3 2023, 08:43:22) [GCC 12.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import manim
>>>

This seems like something broken with your python installation, as it looks like it cannot import the stdlib module dataclasses. I'm not sure what could cause it, as it seems you have a relatively recent python version?
I'll close this issue for now - feel free to reopen it if the issue pops up again.


set the width of content area with a max, min or dynamic value

Describe the feature you'd like

Since people are using more and more large 4k screens/widescreens, it would be nice to be able to set the width of the content area in the middle of the page with a max, min, default or dynamic value (images/tables would scale; right now just when you minimize the browser window it scales).
Kinda like the online retailer Galaxus/Digitec announced for their shop (https://www.digitec.ch/en/page/galaxus-and-digitec-now-for-widescreen-23475).

Describe the benefits this would bring to existing BookStack users

Content better readable.
More shelves and books displayable.
Optimized for high resolutions.
Optimal use of space (reduction of unused space in between).

Can the goal of this request already be achieved via other means?

By modification of the CSS files probably.

Have you searched for an existing open/closed issue?

[X] I have searched for existing issues and none cover my fundemental request

How long have you been using BookStack?
0 to 6 months
Additional context
No response

Thanks for the input @libroc.
To be honest, like most design decisions, this can very much come down to preference.
I prefer to keep the main content within BookStack to a fixed-maxed-width since it somewhat aligns with common print widths and has a read length that most find comfortable, while working to the "Page" paradigm and giving us a fixed with to work to in other aspects (Such as generating full-width image sizes). Although high resolution screens are becoming more popular, in most instances they are scaled up to be equivilent to 1080/1440 sizing.
This was previously discussed in #1757 and you can find some workarounds in there which can be applied without altering any core application files.

fair enough, but then again, what about to implement just 2 layout setting options for the middle content part: "default" (like now) and "dynamic"?

Because its not just the effort of adding the option, We are then beholden to support that wider view going forward if added to core, in terms of making other features work with it, handling related support request & feature ideas and in terms of having an extra layout possibilities to support if making design changes in the future. Having a defined max width gives us a something tangable to work to & support. We provide the methods of customization/overriding for such scenarios where tweaks are desired (With expectation of being "experimental") without placing extra burden on the project.

Since conversation has come to a close I will close this issue off.


update_2020_12_17

This PR adds the latest update (release note) to the service.

I believe the review app might be failing due to no write access, so I asked Rose to be given write access.


Tensorflow 1.15 doesn't exists within pip install

Thank you for submitting a TensorFlow documentation issue. Per our GitHub
policy, we only address code/doc bugs, performance issues, feature requests, and
build/installation issues on GitHub.
The TensorFlow docs are open source! To get involved, read the documentation
contributor guide: https://www.tensorflow.org/community/contribute/docs
URL(s) with the issue:
Please provide a link to the documentation entry, for example:
https://www.tensorflow.org/install/pip
Description of issue (what needs changing):
It says tensorflow 1.15 is final version for 1xx versions yet pip install 1.15 returns this
"$ pip3 install tensorflow==1.15
Collecting tensorflow==1.15
Could not find a version that satisfies the requirement tensorflow==1.15 (from versions: 0.12.1, 1.0.0, 1.0.1, 1.1.0rc0, 1.1.0rc1, 1.1.0rc2, 1.1.0, 1.2.0rc0, 1.2.0rc1, 1.2.0rc2, 1.2.0, 1.2.1, 1.3.0rc0, 1.3.0rc1, 1.3.0rc2, 1.3.0, 1.4.0rc0, 1.4.0rc1, 1.4.0, 1.4.1, 1.5.0rc0, 1.5.0rc1, 1.5.0, 1.5.1, 1.6.0rc0, 1.6.0rc1, 1.6.0, 1.7.0rc0, 1.7.0rc1, 1.7.0, 1.7.1, 1.8.0rc0, 1.8.0rc1, 1.8.0, 1.9.0rc0, 1.9.0rc1, 1.9.0rc2, 1.9.0, 1.10.0rc0, 1.10.0rc1, 1.10.0, 1.10.1, 1.11.0rc0, 1.11.0rc1, 1.11.0rc2, 1.11.0, 1.12.0rc0, 1.12.0rc1, 1.12.0rc2, 1.12.0, 1.12.2, 1.12.3, 1.13.0rc0, 1.13.0rc1, 1.13.0rc2, 1.13.1, 1.13.2, 1.14.0rc0, 1.14.0rc1, 1.14.0, 2.0.0a0, 2.0.0b0, 2.0.0b1)
No matching distribution found for tensorflow==1.15
"
It should be corrected I think.

Hi, I just came across the problem myself, and I fixed it by upgrading pip to 19.0.

@ugurkanates, PIP install TF 1.15 is available.
Please see the gist here. Thanks!

Please upgrade pip.

Getting this issue even with updated pip and setuptools, both on Windows and Arch Linux:
C:\windows\system32>python -m pip install tensorflow==1.15
ERROR: Could not find a version that satisfies the requirement tensorflow==1.15 (from versions: none)
ERROR: No matching distribution found for tensorflow==1.15

C:\windows\system32>python -m pip --version
pip 19.3.1 from C:\Program Files (x86)\Python37-32\lib\site-packages\pip (python 3.7)

C:\windows\system32>python --version
Python 3.7.4

col@col-siris ~/AIDungeon> python -m pip install tensorflow==1.15.0
ERROR: Could not find a version that satisfies the requirement tensorflow==1.15.0 (from versions: none)
ERROR: No matching distribution found for tensorflow==1.15.0
col@col-siris ~/AIDungeon> python -m pip --version
pip 19.3.1 from /usr/lib/python3.8/site-packages/pip (python 3.8)
col@col-siris ~/AIDungeon> python --version
Python 3.8.1

https://pypi.org/project/tensorflow/#files
Also, please see https://github.com/tensorflow/tensorflow/issues/33374#issuecomment-571074915

Even with the latest pip there is no 1.15 package available

@MasterGroosha : 32 bits python? Python 2? Python 3.8?

@mihaimaruseac Yeah, my bad, I didn't understand your messages. With Python 3.8, I cannot install TF-1.15, but I did install it with 3.7.6

Also encountered this issue but pip showed a different message for me
ERROR: Could not find a version that satisfies the requirement tensorflow==1.15 (from versions: 2.2.0rc1, 2.2.0rc2, 2.2.0rc3, 2.2.0rc4, 2.2.0)
ERROR: No matching distribution found for tensorflow==1.15

@raphtlw that is because you are using python3.8 which is not supported in TF before 2.2

@mihaimaruseac So what are the correct versions for the issue that @raphtlw is having? Should I downgrade from python3.8 to something else?

Yes, any version of Python above 3.5 and below 3.8

Check your python version, tensorflow officially supports up to 3.7


Video Metadata Tags

As videos are most likely always going to be H.264 + AAC stereo .mp4 files from TIDAL, the metadata around this is pretty well established. I am using as my guide:

Tag Mapping table from Hydrogen Audio
MusicBrainz Picard
Kodi video file tagging

There is the mp4v2 tool, but mutagen handles all the tags so far, and adding another binary would be silly. So, read the above guides and implement as many of the tags as possible from the (limited) TIDAL API endpoints for music videos.

New resource: QuikTime TagNames. The value of 1 means music and the value of 6 means music video!

Just a note here that all of this work is moot for those who use the pyinstaller-created binaries. This is because I cannot figure out how to compile FFmpeg with libopenh264 and configure minimal filters/bitstreams/operations/whatever-they-are-called to simply remux the concatenated .ts files into an MP4... Because the user of those binaries will leave the videos retrieved as they were, not even attempting to add metadata with FFmpeg :disappointed:

Brought into trunk upon commit 62636164ee83f7929753581c7cb35970ed7b71a9


4.x

Only creating this PR to show the comparison: this should never be merged so long as we continue to support 3.5.x.

Closing, because this is being promoted to become the main branch. :)


text size and text color overwrites each other

Describe the bug
text size and text color overwrites each other
const button = tv({
  base: 'rounded-sm',
  variants: {
    variant: {
      primary: 'bg-primary text-neutral-white',
      secondary: '',
      tertiary: ''
    },
    size: {
      small: 'py-2 px-6 text-button-small',
      medium: 'py-3.5 px-8 text-button-medium',
      normal: 'py-4 px-8 text-button-normal'
    }
  },
  defaultVariants: {
    variant: 'primary',
    size: 'medium'
  }
})

Expected Result
"rounded-sm bg-primary py-3.5 px-8 text-neutral-white text-button-medium"
Result
"rounded-sm bg-primary py-3.5 px-8 text-button-medium"

Hey, since you're using custom tailwind classes, you need to use a custom tailwind merge config https://github.com/dcastil/tailwind-merge/blob/v1.14.0/docs/configuration.md
To pass a custom tailwind-merge config use the twMerge prop.
e.g.
const button = tv({
  base: 'rounded-sm',
  variants: {
    variant: {
      primary: 'bg-primary text-neutral-white',
      secondary: '',
      tertiary: ''
    },
    size: {
      small: 'py-2 px-6 text-button-small',
      medium: 'py-3.5 px-8 text-button-medium',
      normal: 'py-4 px-8 text-button-normal'
    }
  },
  defaultVariants: {
    variant: 'primary',
    size: 'medium'
  }
},
{
 twMerge: YOUR_TW_MERGE_CONFIG
}
)

@jrgarciadev is there a way to just disable the tailwind-merge step all together? I don't really care about having conflicting styles and wouldn't mind not having that overhead. Thanks!

@jrgarciadev incredible! Thank you so much!


updatePointer stuck in a refocus loop (?) in certain applications

Problem Description
Using certain applications with updatePointer seems to cause a refocus loop of sorts.
e.g. obs (Open Broadcaster Software):
The mouse pointer is stuck in the current focus sub window of obs.
I assume the reason being that obs is sending a constant stream of some sort of "focus" action?
Steps to Reproduce
Start obs and e.g. try deleting a scene.
The mouse pointer is stuck in the small confirmation box.
Recording of the issue: https://streamable.com/mplu0n (You can see me trying to move the mouse pointer out of the small confirmation box and being "stuck")
Configuration File
Please include the smallest full configuration file that reproduces
the problem you are experiencing:
import XMonad
import System.Exit
import XMonad.Util.EZConfig
import XMonad.Util.Loggers
import Control.Monad
import Data.Monoid
import System.IO
import XMonad.Util.Run
import XMonad.Layout.NoBorders
import XMonad.Layout.Fullscreen hiding (fullscreenEventHook)
import XMonad.Layout.Grid
import XMonad.Layout.ResizableTile
import XMonad.Layout.Reflect
import XMonad.Layout.PerWorkspace (onWorkspace)
import XMonad.Layout.TrackFloating
import XMonad.Hooks.EwmhDesktops
import XMonad.Hooks.SetWMName
import XMonad.Hooks.ManageHelpers
import XMonad.Hooks.UrgencyHook
import XMonad.Hooks.DynamicLog
import XMonad.Hooks.StatusBar
import XMonad.Hooks.StatusBar.PP
import XMonad.Hooks.ManageDocks
import XMonad.Hooks.RefocusLast (refocusLastLayoutHook, refocusLastWhen, isFloat)
import XMonad.Actions.GridSelect
import XMonad.Actions.CycleRecentWS
import XMonad.Actions.CycleWS
import XMonad.Actions.Navigation2D
import XMonad.Actions.WindowGo
import XMonad.Actions.UpdatePointer
import qualified Data.Map as M
import qualified XMonad.StackSet as W

background, currentline, foreground, comment, cyan, green, orange, pink, purple, red, yellow :: [Char]
background = "#282a36"
currentline = "#44475a"
foreground = "#f8f8f2"
comment = "#6272a4"
cyan = "#8be9fd"
green = "#50fa7b"
orange = "#ffb86c"
pink = "#ff79c6"
purple = "#bd93f9"
red = "#ff5555"
yellow = "#f1fa8c"

myManageHook :: ManageHook
myManageHook = composeAll . concat $
    [ [ className =? c --> doCenterFloat | c <- floats ]
    , [ resource =? r --> doIgnore | r <- ignore ]
    , [ resource =? "stalonetray" --> doIgnore ]
    , [ resource =? "trayer" --> doIgnore ]
    , [ isFullscreen --> doFullFloat ]
    , [ isDialog --> doCenterFloat ]
    ] where floats =  [ -- "foo"
                      --, "bar"
                      ]
            ignore = []

myLogHook :: X ()
myLogHook = updatePointer (0.5, 0.5) (0.0, 0.0)

myLayoutHook = onWorkspace "4" wwwL $ onWorkspace "2" wwwL $ onWorkspace "6" discordL standardLayouts
   where
    standardLayouts = Grid ||| tiled |||  reflectTiled ||| Mirror tiled ||| full
    tiled = ResizableTall 1 (2/100) (1/2) []
    reflectTiled = reflectHoriz tiled
    full = noBorders (fullscreenFull Full)
    wwwL = full ||| tiled ||| reflectHoriz tiled ||| Grid
    discordL = Mirror (ResizableTall 1 (2/100) (3.23/5) []) ||| full ||| Grid

main :: IO()
main = xmonad
    . ewmhFullscreen
    . ewmh
    . withEasySB (statusBarProp "xmobar ~/.config/xmobar/xmobarrc" (pure myXmobarPP)) defToggleStrutsKey
    $ myConfig

myXmobarPP :: PP
myXmobarPP = def
        { ppCurrent = xmobarColor green currentline . wrap " " " "
        , ppTitleSanitize   = xmobarStrip
        , ppVisible = xmobarColor purple  ""
        , ppHidden = xmobarColor orange ""
        , ppHiddenNoWindows = xmobarColor yellow ""
        , ppTitle  = xmobarColor cyan "" . shorten 100
        , ppUrgent = xmobarColor red "" . xmobarStrip
        , ppOrder = \[ws, l, _, wins] -> [ws, l, wins]
        , ppSep = "<fc=#f8f8f2> \xe621 </fc>"
        , ppExtras = [logTitles formatFocused formatUnfocused]
        }
    where
        formatFocused   = wrap (xmobarLowWhite    "[") (xmobarLowWhite    "]") . xmobarGreen . ppWindow . shorten 30
        formatUnfocused = wrap (xmobarLowWhite "[") (xmobarLowWhite "]") . xmobarPink  . ppWindow . shorten 30
        ppWindow :: String -> String
        ppWindow = xmobarRaw . (\w -> if null w then "untitled" else w)

        xmobarPurple, xmobarLowWhite, xmobarPink, xmobarWhite, xmobarGreen :: String -> String
        xmobarPink = xmobarColor pink ""
        xmobarPurple = xmobarColor purple ""
        xmobarGreen = xmobarColor green ""
        xmobarWhite = xmobarColor foreground ""
        xmobarLowWhite = xmobarColor currentline ""

myEventHook :: Event -> X All
myEventHook = refocusLastEventHook
    where
        refocusLastEventHook = refocusLastWhen isFloat

myConfig = withUrgencyHook NoUrgencyHook def
            { workspaces = ["1", "2", "3", "4", "5", "6", "7"]
            , normalBorderColor = comment
            , focusedBorderColor = green
            , borderWidth = 2
            , modMask = mod4Mask
            , terminal = "alacritty"
            , layoutHook = smartBorders . refocusLastLayoutHook . trackFloating . avoidStruts $ myLayoutHook
            , manageHook = myManageHook <+> manageHook def
            , handleEventHook = myEventHook
            , logHook = myLogHook
            } `additionalKeysP` myKeys
myKeys :: [([Char], X ())]
myKeys =
        [ ("M-x l", spawn "xset dpms force standby && slock")
        , ("M-p", spawn "rofi -show")
        , ("M-S-p", spawn "passmenu")
        , ("M-S-s", spawn "sshot.sh")
        , ("M-<Esc>", focusUrgent)
        , ("M1-<Tab>", cycleRecentWS [xK_Alt_L] xK_Tab xK_grave)
    ]

Checklist

[x] I've read CONTRIBUTING.md

I tested my configuration

[x] With xmonad version dbe9c4f799fd826c199169d012c2d2687b210a7f
[x] With xmonad-contrib version 2a02fb37531ee9ba1ac59e5483b8bec60e90bc36

I think that your intuition is correct.  As far as I can tell, OBS sends an EnterNotify event when the float loses focus (which causes us to focus it, which moves the pointer).  When updatePointer is not active, the float is also refocused (just the pointer doesn't move)

Closing this for now, since I don't think there's anything we can do about this (there's no way for us to tell which EnterNotify events are bogus and which aren't—though I suppose you could write your own small eventHook to check some property of the focused window and do nothing if it's e.g. an OBS window)


Connection Approval.

Is there any plans to add connection approval to enet?

It's a low-level networking library. Any high-level abstractions that should sit at application-level will not be implemented.

I don't see any problem with that, in my application I've implemented that functionality for only a few lines of code, and instant connection rejection using peer.DisconnectNow(). Don't know what you are talking about.


Use interface for type hinting (less strict)

Hi,
You are type hinting the wrong Class/Interface - StreamSelectLoop will only work when no PHP-extension (libev/libevent or event) is installed. Instead typehint with LoopInterface

Thanks!


Auto-generate listing of downloads

This is to speed up grabbing the link when a test build is ready.
The page at https://mapbox.s3.amazonaws.com/mapbox-studio/index.html gets auto-updated whenever you push with a commit message like -m [publish gitsha].
/cc @amyleew @camilleanne @samanpwbb @willwhite @bsudekum @yhahn @BergWerkGIS

@springmeyer @camilleanne added link to build request on listing: https://github.com/mapbox/mapbox-studio/commit/dab4ebda6b4cb82a7835d3f96e64f1adb90dcaf1


[BugFix][Lake] Fix unexpected I/O operation in bthread

lake::DeltaWriter::open() may be invoked in a bthread so should not
perform any I/O operation(e.g., Tablet::get_schema()) in it otherwise
the RPC threads may be blocked by I/O operations.
What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] I have added user document for my new feature or new function

run starrocks_admit_test


Prevent late registration of models.

@timgraham here's what I had in mind. There's a couple of migration tests failures that would require adjustments but I'm pretty sure they could work with isolated_apps.

Not actively working on this.


Rename and extend or merge and remove the repository

We also have a repository called utils that contains a sliceutil and mapsutil.
We should either rename this repository into collectionutil and move the code slice and maputil here from the general utils repository, or move the code from this repository to the utils repository and remove this project.

Todo list:

[ ] Complete ongoing developments
[ ] Final release
[ ] Archive the repository (read only) => Developments will continue at https://github.com/projectdiscovery/utils


add covariance annotation

declare field final where its necessary
add @SuppressWarnings where necessary
transfer parallel flags

Coverage decreased (-0.02%) to 90.088% when pulling 595145fd7ea90561592f7d92aca1a6481fc93896 on forax:master into 11f743fa1005c61fdb16143fa7ee6cd0e81b98fe on JosePaumard:master.

Thank you Rémi!


Create the red-orange palette from #B32700

Current Behavior
The existing #B32700 has more of red-orangish range of hues.
If you were to take a look at the palette generator from the color above, the range doesn't meet in the #ff0 red color.
https://maketintsandshades.com/#B32700
It would be better to create a red-orange palette to differentiate against the existing the new red palette
Desired Behavior

Implementation

Acceptance Tests

Mockups

Contributor Guide

🎨 Wireframes and designs for Sistent site in Figma (open invite)

Hi,
can I work on this issue ?


why use pytorch model replace onnx model in pointpillars detection

hi, I found the model update recently, and why use pytorch model replace onnx model in pointpillars detection, and rpn still use onnx model? Does this improve the speed? and how much? Looking forward to your reply.

Hi @chasingw , thanks for your interest and passion in Apollo. We replace PFE onnx model with a torch model to reduce the inference time of the PFE stage for around 25ms, but not working if applying the same operation to RPN stage.

@jeroldchen thanks.


Deprecation of Stream

While we did a good job for the OCaml 5.0 readiness by removing biniou and easy-format OCaml 4.14 will deprecate the Stream module.
We should consider what to do:

Use the camlp-stream polyfill that provides this module
Migrate to something else like Seq

The issue with 1. is that we're adding another dependency. It's probably not a big problem, but it is still not great to depend on something that was removed from the standard library, for most likely good reasons.
The problem with 2. is that this might decrease the performance and since it breaks the interface, it would need to happen for 2.0.0 (or 3.0.0…).

After discussing this with @NathanReb and @panglesd we agreed that for 2.0.0 it would be sufficient to depend on camlp-stream and deprecate the Stream.t APIs after 2.0.0.
As such I created a PR to allow us to depend on camlp-stream for all our supported OCaml versions: https://github.com/ocaml/camlp-streams/pull/3

I'm pretty sure that moving to Seq will improve performance for your use-case, not decrease it. It also looks like a trivial code change. On the other hand, Seq was only added in 4.07, so you would need another clutch library for older OCaml versions.

Or alternatively, since we're breaking compatibility, just move to 4.08 for a 3.0.0 release. But yes, I don't consider this a permanent solution.

I think a sensible choice would be to move from Stream to Seq (it's very simple; do you want a PR?) and update the version requirement to 4.07 accordingly, for 2.00 if it's not out already. When is your next major-bump-release planned?

I wouldn't want to bump the requirement up from 4.02 to 4.07 for 2.0.0 since we're nearing release and this is mostly a "get rid of ancient dependencies" release, so people who used to use it can just continue to use it, even if they need to support older versions of OCaml. OTOH, if there is some shim-library to retrofit Seq, that would be completely alright for 2.0.0.
I guess we plan to release it "real soon"- so far @panglesd has been inspecting how much of the ecosystem will break if we release it as-is now.

stdcompat has a Seq implementation starting from OCaml 3.08, so you should be good to go.
My thoughts:

I certainly don't want to mess with the ongoing release process, that is stressful.
But I think that the correct long-term change is to replace Stream with something else, not keep it around, because no one should use this module anymore outside camlp{4,5}.
I think the right time to do the replacement is now, instead of going through pains with camlp-streams in an intermediate period; this will be a compatibility-breaking change, so you could have a 3.0 right after 2.0, which I guess is fine?

I'm just going to say that the seq compat shim is absolutely tiny and is a no brainer dependency in my book (and in containers). :-)

I agree Stream should not be kept around in the long run. It's not our plan to do so but since we didn't really plan on this we were pondering whether we could keep it around for 2.0.0 while still allowing yojson to be compatible with OCaml 5.0.
At first I thought camlp-streams would act as some kind of reverse shim but it redefines Stream no matter what so it's not strictly speaking compatible with OCaml < 5.0's Stream.
About moving to Seq I think we'd be perfectly happy to do so if that's what people tend to use in place of Stream. That's what I would personally do but having a bit of community feedback here would soothe my mind.
We could also drop Stream without adding Seq directly, this can easily be done in a later minor release if we need more time to think about it.
CC @Leonidas-from-XIV, what do you think?

I think that @gasche's #131 convinced me that the migration to Seq is worth it. It is both faster and actually properly part of the stdlib (and not just a left-over from the time Camlp4 was split out). Even if we were to keep Stream for 2.0.0 it would make sense to replace it with something later on so that API breakage will always happen - sooner or later.
The only downside is that if we do this in 2.0.0 we don't include any time for deprecation of the old APIs. Though we didn't do this when removing Bi_outbuf.t either and maybe it is better to just do all these breaking changes related to external libraries at once instead of forcing people through a number of breaking changes all the time. The fact that we use Buffer and Seq should be good enough for the next 5+ years, eventually we could as well upgrade to 4.08 as lowest version in the future and avoid the shim library altogether.
So yeah, :+1: for #131 , :-1: for #130 from me.

I agree with @Leonidas-from-XIV. Besides, this is a 2.0, it's fine to break some edge cases. People can stay on 1.7 for a long, long time if they need to (like python 2.7, in a way).


refine regexp for parsing oracle versions

match only to the first occurrence of Release  substring in Oracle Banner. For certain versions of oracle databases the current regular expression fails to parse the version.
Old Regexp:
Oracle Database 12c Enterprise Edition Release <IP_ADDRESS>.0 - 64bit Production => ✅ => <IP_ADDRESS>.0 is correctly parsed
Oracle Database 23c Free, Release <IP_ADDRESS>.0 - Developer-Release Version <IP_ADDRESS>.0 => ❌ => failed to parse version
new Regexp only matches until the first occurrence of Release :
Oracle Database 12c Enterprise Edition Release <IP_ADDRESS>.0 - 64bit Production => ✅ => <IP_ADDRESS>.0 is correctly parsed
Oracle Database 23c Free, Release <IP_ADDRESS>.0 - Developer-Release Version <IP_ADDRESS>.0 => ✅ => <IP_ADDRESS>.0 is correctly parsed

@baabgai Thank you very much for the PR. Could you please create a Jira for the issue and change commit message to
DBZ-xxx Refine regexp for parsing oracle versions where xxx is Jira number? It is always good to have it handy to track history.
Also I see you have multiple vrsion Banners available. Would it be possible to create a unit test that would test different version banners so we'd be safe in case of future changes?

@Naros But is it technically possible to use that version with some effort? If yes then I wonder if we could allow the user to override the version check if necessary?

Hi @baabgai, we'll look at adding this in Debezium 2.5.0.Alpha1 in a couple of weeks.  That will allow me to review all the Oracle 23 compatibility requirements, despite the performance concerns, before we open this up.

Closed  in favor of PR #5050


cython 0.29 produces invalid path, breaking nose

Cython 0.29 produces invalid __path__ module attributes, breaking nosetests (and possibly other tools).
According to the Python reference, "__path__ must be an iterable of strings, but it may be empty" (Python language reference, section 5.4.5).

In cython 0.29, the __path__ attribute on a compiled module is None, which is not an iterable.
In cython 0.28.5, there is no __path__ attribute on a compiled module.

Expected behaviour: Compiled modules have a valid __path__ attribute (or omit it altogether).
Impact on nosetests:

When collecting tests to run, nose checks the __path__ attribute on each module; if it exists, nose attempts to iterate over it in order to find submodules to test. (If the attribute doesn't exist, nose skips the iteration.)
In cython 0.29, nose attempts to iterate the invalid __path__ attribute, giving a "'NoneType' object is not iterable" error.
In cython 0.28.5, there is no __path__ attribute on a compiled module, so nose skips the iteration and proceeds without error; the new behaviour is therefore a regression as far as projects using nosetests are concerned.
Error message given by nose when testing a module compiled by Cython 0.29:  File ".../lib/python3.6/site-packages/nose/loader.py", line 343, in loadTestsFromModule
    for module_path in module_paths:
TypeError: 'NoneType' object is not iterable

It seems that this line of code
https://github.com/cython/cython/blob/c9eda12b4806fba3931f7b791be7a672c92d9ca0/Cython/Compiler/Symtab.py#L1169
was recently added and affects __path__

That seems like it should be an easy fix to initialise this one to () instead of None, which would make it valid (and acceptable to nose), though not informative.

Yeah, but i would like to hear something from a Cython developer. They will probably want a test to ensure it doesn't keep breaking things in the future.

Yes, we should be setting this to something valid, if anything at all. (It should probably typically be omitted.)

Could also just be this code: https://github.com/cython/cython/blob/da657c8e326a419cde8ae6ea91be9661b9622504/Cython/Utility/ModuleSetupCode.c#L975
According to PEP 302, only packages (incl. namespace packages) are supposed too have a __path__. We should therefore avoid setting it at all for normal modules.

Hopefully fixed in 792263575b900eafd99ee0bbfbff1f14fcd70cc3.


stuck in crash loop

I'm experiencing an issue that seems similar to #121 in that it's crashing all of HomeBridge - it appears to be due to homebridge-weather-plus not handling the TypeError correctly. This has put HomeBridge in a restart loop.
[5/27/2020, 11:05:45 AM] TypeError: Cannot read property 'pressure' of undefined
    at OpenWeatherMapAPI.parseWeather (/usr/local/lib/node_modules/homebridge-weather-plus/apis/openweathermap.js:156:40)
    at OpenWeatherMapAPI.parseReport (/usr/local/lib/node_modules/homebridge-weather-plus/apis/openweathermap.js:111:8)
    at /usr/local/lib/node_modules/homebridge-weather-plus/apis/openweathermap.js:95:11
    at Request._callback (/usr/local/lib/node_modules/homebridge-weather-plus/apis/openweathermap.js:250:5)
    at Request.self.callback (/usr/local/lib/node_modules/homebridge-weather-plus/node_modules/request/request.js:185:22)
    at Request.emit (events.js:310:20)
    at Request.<anonymous> (/usr/local/lib/node_modules/homebridge-weather-plus/node_modules/request/request.js:1154:10)
    at Request.emit (events.js:310:20)
    at IncomingMessage.<anonymous> (/usr/local/lib/node_modules/homebridge-weather-plus/node_modules/request/request.js:1076:12)
    at Object.onceWrapper (events.js:416:28)
    at IncomingMessage.emit (events.js:322:22)
    at endReadableNT (_stream_readable.js:1187:12)
    at processTicksAndRejections (internal/process/task_queues.js:84:21)
[5/27/2020, 11:05:45 AM] Got SIGTERM, shutting down Homebridge...

the error has occurred 110 times in the span of 29 minutes:
cat homebridge.log|egrep "TypeError: Cannot read property 'pressure' of undefined" |wc -l
     111

full details showing timing
[5/26/2020, 3:02:08 PM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:36:14 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:36:26 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:36:38 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:36:50 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:37:02 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:37:15 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:37:27 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:37:39 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:37:51 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:38:03 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:38:16 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:38:32 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:38:44 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:38:57 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:39:10 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:39:22 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:39:35 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:39:48 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:40:01 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:40:13 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:40:25 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:40:38 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:40:52 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:41:04 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:41:18 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:41:34 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:41:47 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:42:00 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:42:13 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:42:27 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:42:40 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:42:52 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:43:04 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:43:17 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:43:29 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:43:42 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:43:55 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:44:09 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:44:22 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:44:34 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:44:46 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:44:58 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:45:11 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:45:23 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:45:35 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:45:47 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:45:59 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:46:11 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:46:24 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:46:37 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:46:49 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:47:01 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:47:13 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:47:26 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:47:38 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:47:51 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:48:05 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:48:17 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:48:29 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:48:41 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:48:54 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:49:06 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:49:18 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:49:31 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:49:40 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:49:52 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:50:04 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:50:16 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:50:29 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:50:41 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:50:53 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:51:06 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:51:18 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:51:31 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:51:43 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:51:55 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:52:07 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:59:13 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:59:25 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:59:37 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 10:59:50 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 11:00:02 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 11:00:14 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 11:00:27 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 11:00:39 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 11:00:51 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 11:01:03 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 11:01:15 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 11:01:28 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 11:01:40 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 11:01:52 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 11:02:06 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 11:02:18 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 11:02:30 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 11:02:42 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 11:02:54 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 11:03:06 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 11:03:19 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 11:03:31 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 11:03:43 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 11:03:55 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 11:04:07 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 11:04:20 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 11:04:32 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 11:04:44 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 11:04:56 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 11:05:08 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 11:05:21 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 11:05:33 AM] TypeError: Cannot read property 'pressure' of undefined
[5/27/2020, 11:05:45 AM] TypeError: Cannot read property 'pressure' of undefined

This is probably further exacerbating issue #135, which I just logged, but I suppose it may also be caused by issue #135 if I'm getting rate limited by their API, but the "block logs" section of their site doesn't show that I've been blocked.

after removing the homebridge-weather-plus config from config.json homebridge is stable and not stuck in a restart loop.

Got exactly same issue. Is started doing this few days ago. Maybe API has changed.

@kfalkiewicz are you also getting emails from OpenWeather stating you're making a large number of API calls as I describe in issue #135?

No, only this error message.

Thanks for reporting! The OWM API seems a bit unstable. I will release a fix in the next few minutes.

Fixed in v3.2.2 (hopefully 😃)
@loudgazelle I'm still invastigating your api limit exceeding issue.

yes, i can confirm 3.2.2 fixed it, and I'm able to run w/o issue.


Bugfix: base64 decoding

Fixed an issue decoding base64. The first base64 characters of consecutive payload chunks were not handled correctly. The first two base64 characters matter, not just the first one.
This should fix #208.

Thanks a lot! 👍


Version 0.7.0 is broken with NextJS

Checks

[X] Not a duplicate.
[X] Not a question, feature request, or anything other than a bug report directly related to React Splide. Use Discussions for these topics: https://github.com/Splidejs/splide/discussions

Version
0.7.0
Description
SyntaxError: Cannot use import statement outside a module

This error happened while generating the page. Any console logs will be displayed in the terminal window.
Call Stack
<unknown>
file:///C:/Users/toms/Documents/Projects/GitHub/node_modules/%20(splidejs/react-splide/dist/js/react-splide.esm.js (2526)
Object.compileFunction
node:vm (352:18)
wrapSafe
node:internal/modules/cjs/loader (1032:15)

Reproduction Link
No response
Steps to Reproduce

Install NextJS
Install React-Splide
Error

Expected Behaviour
Should load the module like it did previously.

Can you try 0.7.1?

Thank you the latest version 0.7.2 works!


Image gallery integrated into File Explorer

Summary of the new feature/enhancement
Often times, I just want to quickly view images in a full size (or zoom in) in my currently opened folder in the file explorer. To do that, you have to open it in Photos or any other external app which takes some time to start up and you will only see one image at a time.
Having a simple gallery "integrated" into file explorer - activated by a shortcut or some button in a ribbon would make browsing through images smoother and faster.
I have implemented such a functionality in my project. More details and demos here - https://github.com/martinchrzan/FileExplorerGallery

Proposed technical implementation details (optional)
I am happy to integrate my project into PowerToys - https://github.com/martinchrzan/FileExplorerGallery

This would be a welcome addition.

This is awesome :)!

Looking good. Any plans for the future? 🙂

I am not the one to decide. People who do did not respond.

My request was re-routed to this one, which is similar. I suggest an "OS X like QuickLook" feature be added to PowerToys. Pressing space (or F12 like in description above, or other hotkey) would open a separate QuickLook window that would preview the currently selected item on the Desktop or File Explorer. It should support photos, music, videos, documents, etc.
My original Feature Request has more information.

I really want this thing to happen. I could have given a 👍 but I thought you all might have forgotten about this issue. That's why I am sending you the notification or the email.

@crutkas There's wvery week about 1-2 suggestion for something like this. The community want's this really. I know we don't have the time for this before the 1.0 release but I think we should take some priority on that after 1.0

I don't want to confuse the two items here.  THere is a quick look item on the backlog, https://github.com/microsoft/PowerToys/issues/80
This is for images only.  While similar, still different.

Can this become more expanded ala issue #80?  As is it seems like a good idea.

Sure, it can have different rendering engine inside and handle different file types, other than just images

/dup #80


Changed the hostname of freenode in the default config

As suggested in erming/shout#647 the default freenode hostname is not correct. Yes, it works, but Freenode suggests to use chat.freenode.net instead.
It's a super easy fix, so why not?

If you are doing that, you should probably change it here, too so we are consistent.

@YaManicKill I think that default in the code should go away, and the server should just refuse to open a connection if there is no host specified.

@xPaw Yeah, good point actually. Just need some checks, and just remove the options.

I do like having Freenode as a default, actually...
Counter proposal: can we make the change this @YaManicKill suggested and then see in a different issue/PR for what @xPaw is proposing? That would avoid delaying this trivial and needed PR :-)

I do like having Freenode as a default, actually...

It would stay in the config file, it doesn't need to be in code itself.

Right, I see, and nothing in the config file if the admin wants no default. Still, I prefer this in a different PR as it needs a bit more testing/checks than what @dubzi offers here.

Yeah, I agree with @astorije as it's a different issue.

:+1: Keeping freenode in is good, IMO. I've seen a lot of clients start off with their project channel/network in the default settings so new users are immediately directed to where they can get help.

@dgw That's what the config variable is for. It doesn't need to have a hard fallback in the code.

@xPaw This PR is about the config variable…

@dgw I know, keeping freenode in the config default is fine.
But here: https://github.com/erming/shout/blob/35587f3c35d0a8ac78a2495934ff9eaa8f1aa71c/src/client.js#L128 it needs to be removed, and the connection must be refused if there is no server specified.

Yes, we all agree @xPaw, but this is really a different issue that deserves a different PR :-)
Let's ship this quickly when @dubzi makes the change, and also consider your proposition after that.

Alright, I've also fixed the hostname in the client.js file for consistency.

:+1:

:+1:


Adds methods to set band start and stop frequencies, & corresponding unit tests

@zebanaqviWAT Please could you apply the suggested modifications. Thanks

@zebanaqviWAT Please could you apply the suggested modifications. Thanks

@Samuelopez-ansys

@zebanaqviWAT I reopened the this PR, in the comments you can see the suggested modifications you should make before merging this pull request to the main.


Support inline hints

Search Terms
editor, lsp, parameterHints

Suggestion
VSCode has supported decorators what could be implementation as label before some node.
We need to provide some text span to let vscode know .

Use Cases

Examples

Checklist
My suggestion meets these guidelines:

[ ] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[ ] This wouldn't change the runtime behavior of existing JavaScript code
[ ] This could be implemented without emitting different JS based on the types of the expressions
[ ] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
[ ] This feature would agree with the rest of TypeScript's Design Goals.

I'd like to work on this both of ts and vscode If i may.

https://github.com/microsoft/vscode/issues/113276

I think it could also fix #41297

@RyanCavanaugh @DanielRosenwasser any update？

@RyanCavanaugh @DanielRosenwasser any update？

@xiaoxiangmoe No.

@xiaoxiangmoe No.


Update flow-js-testing handlebars templates to<EMAIL_ADDRESS>

Closes: #276
Description

For contributor use:

[x] Targeted PR against correct branch (see CONTRIBUTING.md)
[x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[x] Code follows the standards mentioned here.
[x] Updated relevant documentation
[x] Re-reviewed Files changed in the Github PR explorer
[x] Added appropriate labels

@alse @MrDSGC please take a look into this one if it's still relevant

@jribbink I'm seeing this error when exporting a project. It's not happening on the staging branch. src/templates/js/scriptUnitTest.hbs:20
Uncaught (in promise) SyntaxError: Unexpected token, expected "," (20:11) (at parser-babel.js?6103:1:1)
  18 |             code,
  19 |
> 20 |         });
     |           ^
  21 |     )
  22 |
  23 |     // Add your expectations here
    at t (parser-babel.js?6103:1:1)
    at Object.eval [as parse] (parser-babel.js?6103:1:1)
    at Object.parse (standalone.js?325b:15:1)
    at ts (standalone.js?325b:15:1)
    at us (standalone.js?325b:15:1)
    at eval (standalone.js?325b:55:1)
    at Object.format (standalone.js?325b:55:1)
    at prettify (generator.ts?e988:18:1)
    at generateScriptUnitTest (generator.ts?e988:251:1)
    at eval (generator.ts?e988:288:1)
    ```

@jribbink I'm seeing this error when exporting a project. It's not happening on the staging branch. src/templates/js/scriptUnitTest.hbs:20
Uncaught (in promise) SyntaxError: Unexpected token, expected "," (20:11) (at parser-babel.js?6103:1:1)
  18 |             code,
  19 |
> 20 |         });
     |           ^
  21 |     )
  22 |
  23 |     // Add your expectations here
    at t (parser-babel.js?6103:1:1)
    at Object.eval [as parse] (parser-babel.js?6103:1:1)
    at Object.parse (standalone.js?325b:15:1)
    at ts (standalone.js?325b:15:1)
    at us (standalone.js?325b:15:1)
    at eval (standalone.js?325b:55:1)
    at Object.format (standalone.js?325b:55:1)
    at prettify (generator.ts?e988:18:1)
    at generateScriptUnitTest (generator.ts?e988:251:1)
    at eval (generator.ts?e988:288:1)
    ```

Apologies, that should be fixed now.

closing, will need to reevaluate after polish sprint and mvp testing


Add a dot product function

It should handle inner-product, matrix-vector product, and matrix-matrix product functions. It is better if it supports a batch mode.

I implemented dot and batchdot functions separately, though currently they don't support GPU computation.
https://github.com/muupan/chainer/commit/6a0863486ebad31455ff2e3dbf69497863c24edb

Think you for your code.
I will use this for reference.


Don't call sysctl -a

Running sysctl -a takes multiple seconds and returns ~17k lines, while
requesting only the required 9 lines is much faster.
Also, page size (vm.stats.vm.v_page_size) is unlikely to change at run
time, further work could be done there.

@swills Thank you for your report! Currently I am ill, had a very short look on it and I do see also other bsd compatibility issues. Will provide a fix for all as soon as I am recovered.

@swills I found also other spaces, where was able to optimize it. Thank you once again for pointing to the right direction. ... version 5.9.10 just released.

Perhaps I'm misreading, but it looks like the sysctl changes are after the release of 5.9.10, so they're not included in that release.

@swills not sure what you mean, it is in the current release, just double checked. Installed from NPM and there is no sysctl -a... am I missing something??

Ok, I guess I was looking at this:
https://github.com/sebhildebrandt/systeminformation/compare/v5.9.9..v5.9.10


PHP 7 Compatibility

It seems like the latest version dependencies ultimately resolve a sub-dependency in the lcobucci library to a version that requires PHP 8.
What I am seeing when checking out v2.14.1, is that the sub-dependency lcobucci/clock resolves to 2.1.0 which requires PHP 8.0.
"name": "lcobucci/clock",
"version": "2.1.0",
"source": {
"type": "git",
"url": "https://github.com/lcobucci/clock.git",
"reference": "903513d28e85376a33385ebc601afd2ee69e5653"
},
I am using Composer version 2.1.9 2021-10-05 09:47:38

Sorry but I can't reproduce. Our CI runs fine on PHP 7, and I managed to install the bundle locally on php 7.4 with no issue (composer rightly picked lcobucci/clock:2.0.0).

User error


(Question) Do you plan on making a discord server for this mod?

I think it would be nice and could potentially be nice to get legacy console community involved.

Please avoid creating a Discord server for this mod. There is already a Discord server about Legacy Console research and development which has a section for #java-edition. https://discord.gg/5WqYCMfN
Additionally, hiding issue information behind a Discord server makes it impossible for users to use search engines to find and report issues. Github is a better location for that sort of thing!

Nah make a Discord server, i don't know what the other dude is yapping about but i shouldn't have to be forced somewhere else to see updates for this mod and ONLY this mod, Github is a better place for reporting issues yes, sure but Discord is a better place for catering a community, and honestly that's all i want.

w spring, i vouch

I was planning make a Discord server, more for suggestions and questions about the mod than other things, probably I'll can do this after fixing the actual issues


fix(test): remove duplicated discriminator decorators

fix #217
Cadl Ranch Contribution Checklist:

[ ] I have written a scenario spec
[ ] I have meaningful @scenario names. Someone can look at the list of scenarios and understand what I'm covering.
[ ] I have written a mock API
[ ] I have used @scenarioDocs for extra scenario description and to tell people how to pass my mock api check.

Could this be handled at dotnet codegen side? I believe this does not introduce any invalid behavior, right?

Could this be handled at dotnet codegen side? I believe this does not introduce any invalid behavior, right?

@lirenhe I've confirm with Mark on teams. He agreed to remove this duplicated decorator. I think it would be better to keep the emitter simpler.


Discover shared-type entity types by convention

We could find the enity type name from the DbSet if it's explicitly initialized.
 public DbSet<Dictionary<string, object>> Orders { get; } = Set<Dictionary<string, object>>("Order");

Or we could add an annotation
[EntityType("Order")]
public DbSet<Dictionary<string, object>> Orders { get; set; }

IMO the attribute makes it nice.

See also #15748


Fix client reaction if action worker is done too quickly

Describe the bug
If an action.worker is done too fast then the client throws a snackbar error and Errors in the console:
Snackbar text:
"An unknown error occurred"
First Error from the console:
Unknown error thrown by the http client:
NullInjectorError: NullInjectorError: No provider for e!
    at io.get (￼chunk-MUFP2MHQ.js:7:1170)
    at Pn.get (￼chunk-MUFP2MHQ.js:7:10756)
    at Pn.get (￼chunk-MUFP2MHQ.js:7:10756)
    at bg (￼chunk-MUFP2MHQ.js:4:2414)
    at R (￼chunk-MUFP2MHQ.js:4:2490)
    at e.ɵfac [as factory] (￼chunk-P5BJY2OF.js:161:77469)
    at Pn.hydrate (￼chunk-MUFP2MHQ.js:7:11550)
    at Pn.get (￼chunk-MUFP2MHQ.js:7:10672)
    at get actionWorkerWatch (￼chunk-P5BJY2OF.js:4:43288)
    at e.<anonymous> (￼chunk-P5BJY2OF.js:4:43842)

Second Error thrown in the console:
chunk-P5BJY2OF.js:2 Unknown error thrown by the http client:
TypeError: this.actionWorkerWatch.watch is not a function
    at e.<anonymous> (chunk-P5BJY2OF.js:4:43860)
    at Generator.next (<anonymous>)
    at h (chunk-EPGI56E7.js:1:1793)
    at u.invoke (polyfills-24N7KSB2.js:1:6410)
    at Object.onInvoke (chunk-MUFP2MHQ.js:7:61623)
    at u.invoke (polyfills-24N7KSB2.js:1:6350)
    at _.run (polyfills-24N7KSB2.js:1:1725)
    at polyfills-24N7KSB2.js:2:554
    at u.invokeTask (polyfills-24N7KSB2.js:1:7035)
    at Object.onInvokeTask (chunk-MUFP2MHQ.js:7:61439)

backend log with time stamps:
backendaction 2024-07-23T15:04:43.377240591+02:00 INFO:openslides_backend.shared.handlers.base_handler:Performing action user.create.
backendaction 2024-07-23T15:04:44.622692282+02:00 INFO:openslides_backend.shared.handlers.base_handler:Request was successful. Send response now.
backendaction 2024-07-23T15:04:44.759295133+02:00 INFO:openslides_backend.action.action_worker:action_worker: Action (user.create) lasts too long. action_worker/1169 written to database. Get the result from database, when the job is done.
backendaction 2024-07-23T15:04:44.760093912+02:00 INFO:openslides_backend.action.action_worker:finish action_worker 'action_worker/1169' (user.create):<PHONE_NUMBER>

How to Reproduce:
The Error so far was only thrown with the new setup
You need a fast setup to get the action worker response "too" fast

on orga-level
create a new account
error is thrown

Expected behaviour
Even if an action worker is done fast, the client should know how to respond

Seems like resolving a circular dependency by loading it on demand is not a good idea.
To fix this instead of directly calling the ActionWorkerWatchService from the HttpService we could use http interceptors https://angular.dev/guide/http/interceptors

This seems to always happen on 202.


A quetion about the way MCU use the key

As you know ,if you wrap the Key in the format of M1-M5, you will load the M1-M3 to the key slot.
So how did the MCU use the key as a ciphertext? Or does the MCU decrypt the M1-M3 inside?
I don't quite understand this , do you have a chance to share your point of view of this?Thanks for your attention.

The MCU decrypt the M1-M3 data.
This script can't decrypt M1-M3 to plain key(only encrypt plainkey to M1-M3).
Thank you.

OK, Got it. Thanks.


Add override mark to ResourceFormat class

Add override to class derived from ResourceFormatSaver and ResourceFormatLoader. It helps me understand codes.

we might want to add this commit, or a more extensive one, to the blame ignore

I wouldn't, I think the blame ignore should only include cosmetic changes, but this one actually has implications on how code is compiled. If a downstream user has their custom code fail compiling because of this change (missing override in user code), they need to find it in the blame.

Isn't that compile issue only if you mix it in the same class?

Possibly. Still, it's not a cosmetic change so I wouldn't hide it from blame :)

Thanks! And congrats for your first merged Godot contribution :tada:


Fix CTF stream picking logic.

Stream picking logic for CTF trace incorrectly assumes that channel name is set to default "channelX" where X is sequence number. Using custom channel names causes no streams to be parsed because containing files has different than default names. In my read of CTF specification all data files contains streams with exception of one file - "metadata". This is what this change implements, all files with exception of "metadata" will be parsed for event streams.

Also, 8 LTTng UTs are now failing which may be related to the comment I have above.
https://github.com/microsoft/Microsoft-Performance-Tools-Linux/pull/19/checks?check_run_id=2381893215

Noticed that after creating the PR, will look at it next days. Don't think it's related to not correctly formatted data, it fails with correct streams also but only if they are more than one.

FYI - moved to draft PR since it's not ready yet


Kubernetes compatibility

Hi,
I'm currently building out my platform using Kubernetes.
I have Sonarr, Radarr, Nzbget, qBittorrent etc configured to run as k8s pods and am trying to integrate sickbeard_mp4_automator.
I've written a wrapper program that will spin up a k8s job for each file to be converted/processed.  This uses a docker image that is still a work in progress (https://github.com/jameseck/docker-sba).
The problem I'm facing is the way that sickbeard_mp4_automator handles the autoProcess.ini file.
I want to use the same autoProcess.ini file for all integrations so I want that to be mounted from a shared directory (I'd prefer to be able to mount it from a k8s configMap but since sickbeard_mp4_automator seems to want to write to this file that doesn't seem possible as configMap mounts are read-only).
I have a shared directory called downloads which is mounted in all the above pods and I'd like to keep the autoProcess.ini in this directory.
If I use manual.py I can specify where the autoProcess.ini file is, but using the qbittorrentpostprocess.py it only looks for the autoProcess.ini in the directory the py script lives.
I'd like to be able to specify an environment variable (something like AUTOPROCESS_INI=/path/to/autoProcess.ini) that could be used by whatever python scripts need to find it.
I know I could put the sickbeard_mp4_automator code in the same shared directory but I'd prefer to separate the code from the config.
So out of all this I think there are two points for discussion:

Can we have the ability to specify where the autoProcess.ini file is found?
Can we allow the autoProcess.ini file to be read-only?

Thanks
J

Config file being read only shouldn't be a problem and I've tested this scenario. This was fixed maybe a month ago. You'll get can error message that writing failed but the script should proceed without issues (it will only attempt to write if you're missing options that have been added in recent patches so updating your autoProcess.ini should eliminate this error too)
As for specifying where autoProcess.ini is located, I pushed an update just now to override the default path using an environment variable named SMACONFIG
Set this to the full path to an ini file, not just a directory, and the file needs to exist ahead of time for the override to work but should override in all scenarios
94c26635a8aa6481d00e34473450cc0b8d32ece9
Let me know if this works for you and feel free to close the issue. I'll update the readme once you confirm.

Made some subtle tweaks
324cbc716b43b954d5ca92ea03c8d4bc9aca07e0
Relaxed some of the above restrictions, test this version instead

Thanks in advance for indulging my use case so quickly!
I'm seeing an error when I try using the latest code:
sba/mkvtomp4.py:381: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if self.settings.abitrate is 0:
/sba/mkvtomp4.py:435: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if self.settings.abitrate is 0:
/sba/mkvtomp4.py:813: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if len(lang) is 2:
2020-02-28 09:42:02 - qBittorrentPostProcess - INFO - qBittorrent post processing started.
2020-02-28 09:42:03 - qBittorrentPostProcess - INFO - Performing conversion
Traceback (most recent call last):
  File "/sba/qBittorrentPostProcess.py", line 119, in <module>
    path = converter.output_dir
AttributeError: 'MkvtoMp4' object has no attribute 'output_dir'

The SyntaxWarning errors I've been seeing for quite a while and ignoring as they don't seem to affect anything, but the AttributeError is new.
I thought maybe my autoProcess.ini was missing something and because of the read-only mount it was failing to add missing entries, but I get the same error when the autoProcess.ini is read-write.

Nah this was a bug that was missed from an update a month ago (qBT doesn't see a lot of use I don't think)
Just pushed 2 updates, one to address the error you're seeing an another to fix that syntax warning
6ce4a95940d2f97372e4a351e8fdc2170a6c078b
709f6db40827eb3a37eac9801dd2ffb5bfccc79f
Let me know if that fixes things

Thanks dude.  Everything is working great now with the env variable.
I've been using Deluge for years but thought I'd give qbt a try.
One pesky SyntaxWarning remains.
/sba/mkvtomp4.py:815: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if len(lang) is 2:

That last syntax warning should be fixed now
ec025c2835e04e7a552020dcbee190fa60497059
Thanks! Gonna close this

Just a quick note, I modified the environment variables to be uniform and the config variable was changed to SMA_CONFIG instead of SMACONFIG


Write alerter functionality

Alerter should support different kinds of alerting mechanisms (slack, pagerduty, email to start?).
Spawn an alert channel; checks write to the alert channel when they want to send out an alert; alerter listens on alert channel for incoming messages and spins up alerter workers to handle the message sending via whatever alerting method.
We could cache the entirety of the alerting config in mem to save on a bunch of fetchAlertConfig() calls to etcd. Not sure yet. Bonus points for this. Oh. If etcd ever goes away, so does the node's alerting abilities - so we should probably just cache it from the getgo - that way we can survive an etcd outage/restart without (too many) issues.

Reminder: checks reference thresholds (OK, WARNING, CRITICAL), each threshold is associated with an alert key entry.
YAML wise, this would look something like:
WarningThreshold:
  Alerter: core-slack-all-hours
  FailCount: 2 # or some other key that the check requires (?)
CriticalThreshold:
  Alerter: core-pagerduty-all-hours
  FailCount: 5

^ above is in YAML as its probably the easiest way to get a configuration into etcd.

#18

This has been completed.


Feature auto reconnect

Feature auto reconnect
Objectives

[x] Add recreate channel strategy if it closes the channel unexpected
[x] Add reconnect strategy if it closes the connection unexpected
[x] Create tests to channel recreation
[x] Create tests to reconnection
[x] Create tests to publish messages when channel closes unexpected
[x] Create tests to publish messages when disconnect unexpected
[x] Create tests to publish message method
[x] Prevents connection errors when trying to send a message
[x] Avoid racing conditions

Why I did this changes?
I created these mods because we had a necessity to ensure that the rabbitmq is connected when sending a message and that it will not makes a deadlock if we have some connection/channel issue

Issue 1
Tests seem to fail.
Issue 2
Need to merge with the main branch.
At the time of writing, the major change was a fix to how the channels are initiated. We now use the listener's "id" in registering the channel and queue.
See the changes from L61 to L76:
https://github.com/Problem-Company-Toolkit/rabbitmqstore/blob/main/listener.go#L61
https://github.com/Problem-Company-Toolkit/rabbitmqstore/blob/main/listener.go#L76
I suggest adding "id" as a parameter to your configureChannel function, then implementing the configurations above.

Closed; implemented differently in the main branch.


Release: 3.0.0-alpha.0

First Clear Container 3.0.0 alpha release
Support for Docker create, run, version, list, exec, rm, stop
Initial CRI-O support
CNM networking enabled
Travis and Semaphore CI support
Signed-off-by: Samuel Ortiz<EMAIL_ADDRESS>

Do you think it's worth getting #69 resolved first?

I don't think #69 is a blocking issue for an alpha release.
lgtm

Coverage decreased (-0.3%) to 74.863% when pulling 218be49a0edcbf8e510c8b098d058dfc9305dcbe on sameo/topic/releases into 8b2978d044f5efce201d5f2977fcc51b89e742c0 on master.

I tagged the tree and did a github release instead.


Feat: Allow interaction on text-field i.e clicking on text-field

Kindly update README (KomposeCountryCodePicker Textfield Composable customizations) with the new component added on the composable.


[IMPROVMENT] Add support for TMX multi-tileset layers

Refer to #1136
I'll make tests now.

@aismann Something happened that made me think this implementation has a bug, this bug made so tiles look wrong and out of order, after hours of trying to find that bug turns out it was non-existent, but rather it was Tiled, when you save tmx files in Tiled it doesn't update the tsx files automatically based on the new image, so you need to save them manually anytime you change your texture size, I'm saying this to save you hours of frustration.

@aismann Something happened that made me think this implementation has a bug, this "bug" made tiles look wrong and out of order, after hours of trying to find that bug turns out it was non-existent, but rather it was Tiled, when you save tmx files in Tiled it doesn't update the tsx files automatically based on the new image, so you need to save them manually anytime you change your texture size, I'm saying this to save you hours of frustration.

Can you add  a comment plz (on APPENDIX.md ?)

@aismann Unfortunately I couldn't fix this bug, spent hours to no avail, I think at that point I should just stop.
expected this:

and got:

I shuffled the code and rinsed over and over but I couldn't get that bug to be fixed for the life of me.. I think that entire class needs a rewrite or someone with better experience can do it

@aismann Unfortunately I couldn't fix this bug, spent hours to no avail, I think at that point I should just stop.
expected this:

and got:

I shuffled the code and rinsed over and over but I couldn't get that bug to be fixed for the life of me.. I think that entire class needs a rewrite or someone with better experience can do it

Is this the "new example for multi tilesets?
Please add  an issue and let add "pinned".
Add the issue number on the tester subtilte too.
Thanks

@halx99
What does you mean?
New branch for this for testing/fixing?