Add terser minification

The rolled-up src/.build/bidiMapper/mapper.js script has a size of 936K.
With the terser minification it gets reduced to 528K (43% size
reduction).
Integrate terser to the build process as a rollup plug-in.
Bug: #89

LGTM but please wait for Maksim to also take a look

Actually, Maksim is out for a few days. I suppose it’s fine to land this as-is, and address any comments he has afterwards.

As per https://terser.org/docs/api-reference#format-options, we can add a @license comment in order to preserve the copyright notice without having to customize terser().

It turns out there are too many copyright notices, it's not practical to add @license to all of them. Instead, prefer https://terser.org/docs/api-reference#keeping-copyright-notices-or-other-comments to keep comments that match copyright (case insensitive).

The final size with the copyright notices is still pretty lightweight: 540K (up from 528K).
Here's a sample of what it looks like:
!function(){"use strict";
/**
     * Copyright 2021 Google LLC.
     * Copyright (c) Microsoft Corporation.
     *
     * Licensed under the Apache License, Version 2.0 (the "License");
     * you may not use this file except in compliance with the License.
     * You may obtain a copy of the License at
     *
     *     http://www.apache.org/licenses/LICENSE-2.0
     *
     * Unless required by applicable law or agreed to in writing, software
     * distributed under the License is distributed on an "AS IS" BASIS,
     * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
     * See the License for the specific language governing permissions and
     * limitations under the License.
     */function e(e){return(...t)=>{if(globalThis.document?.documentElement){console.log(e,...t);const n=function(e){const t=e+"_log",n=document.getElementById(t);if(n)return n;const i=document.createElement("div");return i.id=t,i.innerHTML=`<h3>${e}:</h3>`,document.body.appendChild(i),i}
/**
     * Copyright 2022 Google LLC.

I'd consider adding a step verifying the compiled size in the given diapason.


iOS no Take/Pick UI Appearing after XamForms 2.3.4 upgrade

A bug appears to exist on iOS only, for Xam.Plugin.Media 2.6.2 under XamForms 2.3.4
Calls to "await CrossMedia.Current.TakePhotoAsync(...)" and "await CrossMedia.Current.PickPhotoAsync(null)" no longer show the expected UI for take or pick.
All setup is correct.
Rollback to XamForms <IP_ADDRESS> working again :)
Version Number of Plugin: 2.6.2
Device Tested On: iPhone 6 (take & pick)
Simulator Tested On: iPhone 7 iOS 10.3 (pick only)
Expected
Expected respective take/pick forms to appear on relevant Async calls.
Actual
Calls just disappear into the await method.
Subsequent calls give the expected error indicating only one (1) active call at a time is allowed.
Steps to reproduce the Behavior
Upgrade a working iOS app to XamForms 2.3.4
Downgrade to XamForms 2.3.3.x and all happy again.

We are having the exact same issue. This is the line that is throwing the error: https://github.com/jamesmontemagno/MediaPlugin/blob/master/src/Media.Plugin.iOS/MediaImplementation.cs#L240.

Same here

Found a workaround. See here: https://github.com/xamarin/Xamarin.Forms/pull/848
I am displaying an action sheet before calling the media plugin. Adding a 100ms in between prevents the issue for now. Looks like a fix will be in place with the next version of Xamarin.Forms
string choice = await this.CoreMethods.DisplayActionSheet(null, "Cancel", null, TAKE_TEXT, CHOOSE_TEXT);             await Task.Delay(100);             MediaFile mediaFile = null; PickMediaOptions options = new PickMediaOptions();                 options.CompressionQuality = COMPRESSION_QUALITY;                 options.PhotoSize = PhotoSize.Medium;                 mediaFile = await CrossMedia.Current.PickPhotoAsync(options);

Fixed here: https://github.com/jamesmontemagno/MediaPlugin/issues/186

Thanks for the 'fix' - much appreciated!


Const stylesheet support

Changes the usages of Vec in favor of const arrays.


Allow modifying devices and bridge settings without restart

One question because of the "saveConfig" method ... will always all objects be written or only on change?

One question because of the "saveConfig" method ... will always all objects be written or only on change?

the methods should only write the objects if something has changed in the config


Bulid list of existing extensions when adding empty release (and maybe when making record too?)

Done when ma


Update how react-popper.d.ts imports PopperJS

popper.js's TypeScript definition now exports default, so it's now throwing an error when importing with * as PopperJS from "popper.js". This is a small bug, but it prevents anyone using TypeScript from building their application.

Hi @souporserious, merging this PR is important to anyone using typescript.
It would also make sense to upgrade dependency popper.js to ^1.12.1 given that the new typings are in versions >= 1.11.1.

Sorry, I've been super busy lately. I'll get this out today, thanks!


Custom CSS on Button

I want to change the on focus css of the sveltestrap Button component.  How should I target the component? There is no prop to add custom css.

You can pass the style prop, but Svelte also has the <style> support.  Can you explain the CSS effect you would like to accomplish?

You can pass the style prop, but Svelte also has the <style> support. Can you explain the CSS effect you would like to accomplish?

I want to change the on focus and and active box-shadow to none.  Not able to target the Button component with class.

Try something like:
<style>
  :global(.btn:focus) {
     /* Your CSS */
   }
</style>

If you are trying to do this on just a single button you should be able to use an #id selector, etc.   There's no prop we can provide here for this focus use case afaik.

Both the solutions are working.  Thanks 👍


Fix logs and general improvements.

Signed-off-by: i1i1<EMAIL_ADDRESS>

Description of the Change
There were too many logs on various levels. This pr improves debuging experience with fixing log levels and removing useless ones.
Issue

Benefits

Possible Drawbacks

Usage Examples or Tests [optional]

Alternate Designs [optional]

Should we link #1499 here?


how to contain multiple images in one item?

Hi
I wanted to put several images in one item (see: https://www.lib.uidaho.edu/digital/hjccc/data/hjccc-163.html). I read the documentation and it wasn't mentioned how to do it.
Thanks,
Apple

@chrkibo thanks for the question! And yes, sorry that isn't a feature that is documented or built in right now.
We typically call item pages with multiple images or other files "compound objects". We have implemented them in many different ways in different collections--but don't have a method directly built into any of the templates right now. We are likely to roll out a built in method this summer.
In the meantime, if you are familiar with Jekyll, it is not many steps to customize your project to support compound objects.
There is a few approaches:

A new column: the simplest approach if you just have images and don't need additional metadata, is to add a new column to your main metadata CSV called "compound" that lists all the additional filenames. Then modify the item page layout to look at that column to add the additional images. There is an example implemented in cb-gh-postcards.
Two CSVs: In the example you mention, if you look at HJCCC source code there is two CSVs: one for the "objects" describing the full items (each record in this CSV will become an item page) and one for all "images" (each image is one row in the CSV with minimal metadata, plus a "objectid" that matches one of the item in the "objects" CSV). Item pages are generated from the "objects" CSV, and the item page layout checks the "images" CSV to pull in any related images. This is a flexible approach because each object can have any number of images associated, and the images can have additional metadata applied.
One CSV: another approach is to add the additional images as rows in your main metadata csv, leaving the "objectid" column blank. Any row with an "objectid" value will be a full "object" record and generate an item page. The rows without "objectid" will be additional images, and use a key value to be associated with one of the "object" records. This approach is likely to be built into the templates eventually, but is a bit more complicated to get set up right now.

If you are working on a specific project right now, please let us know and we would be happy to help get it set up!

Hi Evan,
Thanks for this guide. My colleagues and I were able to customise it using
the second approach. Attached is the screenshot of the page.
Collection Builder is awesome! Thank you for making it accessible for
everyone :)
Apple/KIBO
On Fri, 25 Jun 2021 at 00:51, EvanWill @.***> wrote:

@chrkibo https://github.com/chrkibo thanks for the question! And yes,
sorry that isn't a feature that is documented or built in right now.
We typically call item pages with multiple images or other files "compound
objects". We have implemented them in many different ways in different
collections--but don't have a method directly built into any of the
templates right now. We are likely to roll out a built in method this
summer.
In the meantime, if you are familiar with Jekyll, it is not many steps to
customize your project to support compound objects.
There is a few approaches:

A new column: the simplest approach if you just have images and
don't need additional metadata, is to add a new column to your main
metadata CSV called "compound" that lists all the additional filenames.
Then modify the item page layout to look at that column to add the
additional images. There is an example implemented in cb-gh-postcards
https://github.com/evanwill/cb-gh-postcards.
Two CSVs: In the example you mention, if you look at HJCCC source
code https://github.com/uidaholib/HJCCC_source there is two CSVs:
one for the "objects" describing the full items (each record in this CSV
will become an item page) and one for all "images" (each image is one row
in the CSV with minimal metadata, plus a "objectid" that matches one of the
item in the "objects" CSV). Item pages are generated from the "objects"
CSV, and the item page layout checks the "images" CSV to pull in any
related images. This is a flexible approach because each object can have
any number of images associated, and the images can have additional
metadata applied.
One CSV: another approach is to add the additional images as rows
in your main metadata csv, leaving the "objectid" column blank. Any row
with an "objectid" value will be a full "object" record and generate an
item page. The rows without "objectid" will be additional images, and use a
key value to be associated with one of the "object" records. This approach
is likely to be built into the templates eventually, but is a bit more
complicated to get set up right now.

If you are working on a specific project right now, please let us know and
we would be happy to help get it set up!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/CollectionBuilder/collectionbuilder-sa/issues/28#issuecomment-867797691,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AURNKHAIB7O36E4C73CY333TUNPA3ANCNFSM47IGQXPQ
.


Proof of concept on the usage of crit features for reading memory pages

This proof of concept introduces the following new flags:

pid: to specify the PID of a process to display
ps-args: to display command line arguments of a process
ps-env-vars: to display environment variables of a process
ps-memory-pages: to display the content of memory pages in hexadecimal and ascii format (similar to hexdump)

Example output
Information about the new flags:
$ ./checkpointctl show --help
Show information about available checkpoints

Usage:
  checkpointctl show [flags]

Flags:
      --all               Display all additional information about the checkpoints
      --full-paths        Display mounts with full paths
  -h, --help              help for show
      --mounts            Print overview about mounts used in the checkpoints
      --pid uint32        The PID of the process to display. This option should be used with [--ps-args | --ps-env-vars | --ps-memory-pages]
      --ps-args           Display the arguments for the specified pid
      --ps-env-vars       Display environment variables for the specified pid
      --ps-memory-pages   Display memory pages for the specified pid in hexdump format
      --stats             Print checkpointing statistics if available

Example of ps-args:
$ ./checkpointctl show --pid=1 --ps-args /path/to/checkpoint.tar.gz

Displaying container checkpoint data from /path/to/checkpoint.tar.gz

+---------------+---------------------------------+--------------+---------+---------------------------+--------+------------+-------------------+
|   CONTAINER   |              IMAGE              |      ID      | RUNTIME |          CREATED          | ENGINE | CHKPT SIZE | ROOT FS DIFF SIZE |
+---------------+---------------------------------+--------------+---------+---------------------------+--------+------------+-------------------+
| awesome_booth | docker.io/library/ubuntu:latest | 695b77deb382 | crun    | 2023-03-08T08:45:33+03:00 | Podman | 2.8 MiB    | 309.0 KiB         |
+---------------+---------------------------------+--------------+---------+---------------------------+--------+------------+-------------------+

Arguments of process 1

/bin/bash

Example of ps-env-vars:
$ ./checkpointctl show --pid=1 --ps-env-vars /path/to/checkpoint.tar.gz

Displaying container checkpoint data from /path/to/checkpoint.tar.gz

+---------------+---------------------------------+--------------+---------+---------------------------+--------+------------+-------------------+
|   CONTAINER   |              IMAGE              |      ID      | RUNTIME |          CREATED          | ENGINE | CHKPT SIZE | ROOT FS DIFF SIZE |
+---------------+---------------------------------+--------------+---------+---------------------------+--------+------------+-------------------+
| awesome_booth | docker.io/library/ubuntu:latest | 695b77deb382 | crun    | 2023-03-08T08:45:33+03:00 | Podman | 2.8 MiB    | 309.0 KiB         |
+---------------+---------------------------------+--------------+---------+---------------------------+--------+------------+-------------------+

Environment variables of process 1

PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
TERM=xterm
container=podman
HOME=/root
HOSTNAME=695b77deb382

Example of ps-memory-pages:
$ ./checkpointctl show --pid=1 --ps-memory-pages /path/to/checkpoint.tar.gz | head -n 25

Displaying container checkpoint data from /path/to/checkpoint.tar.gz

+---------------+---------------------------------+--------------+---------+---------------------------+--------+------------+-------------------+
|   CONTAINER   |              IMAGE              |      ID      | RUNTIME |          CREATED          | ENGINE | CHKPT SIZE | ROOT FS DIFF SIZE |
+---------------+---------------------------------+--------------+---------+---------------------------+--------+------------+-------------------+
| awesome_booth | docker.io/library/ubuntu:latest | 695b77deb382 | crun    | 2023-03-08T08:45:33+03:00 | Podman | 2.8 MiB    | 309.0 KiB         |
+---------------+---------------------------------+--------------+---------+---------------------------+--------+------------+-------------------+

Memory pages info (vaddr, hexadecimal, ascii) of process 1

5614ced87000  f3 0f 1e fa 48 83 ec 08  48 8b 05 e1 de 11 00 48   |....H...H......H|
5614ced87010  85 c0 74 02 ff d0 48 83  c4 08 c3 00 00 00 00 00   |..t...H.........|
5614ced87020  ff 35 c2 d6 11 00 f2 ff  25 c3 d6 11 00 0f 1f 00   |.5......%.......|
5614ced87030  f3 0f 1e fa 68 00 00 00  00 f2 e9 e1 ff ff ff 90   |....h...........|
*
5614ced870a0  f3 0f 1e fa 68 07 00 00  00 f2 e9 71 ff ff ff 90   |....h......q....|
5614ced870b0  f3 0f 1e fa 68 08 00 00  00 f2 e9 61 ff ff ff 90   |....h......a....|
5614ced870c0  f3 0f 1e fa 68 09 00 00  00 f2 e9 51 ff ff ff 90   |....h......Q....|
5614ced870d0  f3 0f 1e fa 68 0a 00 00  00 f2 e9 41 ff ff ff 90   |....h......A....|
5614ced870e0  f3 0f 1e fa 68 0b 00 00  00 f2 e9 31 ff ff ff 90   |....h......1....|
5614ced870f0  f3 0f 1e fa 68 0c 00 00  00 f2 e9 21 ff ff ff 90   |....h......!....|
5614ced87100  f3 0f 1e fa 68 0d 00 00  00 f2 e9 11 ff ff ff 90   |....h...........|
*
5614ced871a0  f3 0f 1e fa 68 17 00 00  00 f2 e9 71 fe ff ff 90   |....h......q....|

I am still uncertain about the design of the new flags. 🤔
Please note that the CI is expected to fail because the version of the crit package used in this code is copied from  https://github.com/checkpoint-restore/go-criu/pull/133.

Codecov Report
Patch coverage: 22.50% and project coverage change: -13.57 :warning:

Comparison is base (34bab99) 80.56% compared to head (d1a0b1b) 66.99%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #69       +/-   ##
===========================================
- Coverage   80.56%   66.99%   -13.57%
===========================================
  Files           3        4        +1
  Lines         391      509      +118
===========================================
+ Hits          315      341       +26
- Misses         55      144       +89
- Partials       21       24        +3

Impacted Files
Coverage Δ

memory_info.go
0.00% <0.00%> (ø)

container.go
78.90% <7.69%> (-3.89%)
:arrow_down:

checkpointctl.go
87.60% <96.29%> (+3.39%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Now that #56 is merged maybe you could extend the process view with the full command-line. Instead of:
counter
└── [1]  bash
    ├── [7]  bash
    ├── [7]  counter.py
    ├── [8]  bash
    └── [8]  tee

This uses the information from the core image filed comm. In you example I see the output that can also be seen when running ps aux. You copy the complete command-line from the pages images. Maybe that would be nice first use case of your go-criu interface.
You can just include go-criu with the SHA and date, not using a released version, but the current latest version from git.

With the introduction of the inspect sub-command. I believe that some of the features for reading memory pages content should also be part of inspect parameters.  I would like to discuss how we should incorporate these features.

For command-line arguments, as @adrianreber suggested, it would make sense to add them alongside the process tree. I am wondering if we can keep a default  output (use only the information from core image filed comm) and add another flag (e.g: --ps-args only usable with --ps-tree) to display the full command line from memory pages (Only in this case we will need to extract all pages-*.img, pagemap-*img and mm-*.img images)?

Examples:
$ checkpointctl inspect /path/to/checkpoint.tar.gz --ps-tree
counter
└── [1]  bash
    ├── [7]  bash
    ├── [7]  counter.py
    ├── [8]  bash
    └── [8]  tee

$ checkpointctl inspect /path/to/checkpoint.tar.gz --ps-tree --ps-args
counter
└── [1]  bash
    ├── [7]  bash -c 'python counter.py'
    ├── [7]  python counter.py --input data.txt --output result.txt
    ├── [8]  bash -c 'tee output.log'
    └── [8]  tee output.log

For processes environment variables, maybe we can also have a flag (--ps-env-vars) only usable with --ps-tree.

Example:
$ checkpointctl inspect /path/to/checkpoint.tar.gz --ps-tree --ps-env-vars
counter
└── [1]  bash
    ├── [7]  bash
    │   ├── [7]  counter.py
    │   │   ├── [7]  PYTHONPATH=/usr/local/lib/python3.9/site-packages
    │   │   └── [7]  DEBUG_MODE=true
    │   ├── [8]  bash
    │   └── [8]  tee
    └── [8]  tee
        └── [8]  OUTPUT_DIR=/var/log

Finally, for inspecting the content of processes memory pages. I am not sure if it will make sense to have it alongside the tree or json view. Maybe a new sub-command for would be better ?

What do you think @rst0git , @adrianreber ?

I am wondering if we can keep a default output and add another flag to display the full command line from memory pages?

It makes sense. For example, we can introduce something like the following two options:

--ps-tree-cmd: Show command-line arguments
--ps-tree-env: Show environment variables

for inspecting the content of processes memory pages. I am not sure if it will make sense to have it alongside the tree or json view.

The content of memory pages could be several gigabytes and it might not be appropriate to show all of it in a terminal. However, we can introduce a sub-command, for example checkpointctl memparser, that can save the output in a file. We can also extend this sub-command with additional options for more effective memory analysis.
@adrianreber What do you think?

@behouba A container checkpoint may include multiple processes, each with potentially large amount memory. To analyze the memory of a checkpoint it might be useful to display an overview of the memory size of each process, as well as to show the memory pages for a specific process.
Would it make sense to implement this as a table showing all PIDs, process names, and memory size for each process? For example, when the --pid option has been specified it could show the memory pages (vaddr, hexadecimal, ascii) for the specified PID, and use --output option that could allow to write the output to a specified file instead of STDOUT.
We could implement this as new sub-command for checkpointctl with description "Analyze container checkpoint memory", or extend the existing (show and inspect) sub-commands.
@behouba @adrianreber What do you think?

Would it make sense to implement this as a table showing all PIDs, process names, and memory size for each process? For example, when the --pid option has been specified it could show the memory pages (vaddr, hexadecimal, ascii) for the specified PID, and use --output option that could allow to write the output to a specified file instead of STDOUT.

Implementing this as a table with PIDs, process names, and memory sizes for each process seems to me like a good approach. Also, the --pid  an --output options would add flexibility and usability to view to content of the memory pages.

We could implement this as new sub-command for checkpointctl with description "Analyze container checkpoint memory", or extend the existing (show and inspect) sub-commands.

In my option, adding a new sub-command for this use case is more appropriate. However, I am unsure about the most suitable name for this sub-command. What about memscan or memparser as you suggested earlier @rst0git ?

What about memscan or memparser as you suggested earlier @rst0git ?

checkpointctl memparse might be more appropriate.
"parse" is defined as "to examine computer data and change it into a form that can be easily read or understood".
The following wiki page has some relevant examples of the Volatility interface for memory analysis:
https://github.com/volatilityfoundation/volatility/wiki/Linux-Command-Reference#process-memory

"parse" is defined as "to examine computer data and change it into a form that can be easily read or understood".

I totally agree, memparser is more appropriate according to the definition. Thank you @rst0git, I will work on that.


Documentation update: setAdvertisingIdentifier API reference

Description
Documentation for setAdvertisingIdentifier API with Java (from gitbook docs) and Kotlin (from sample app) examples.  Required imports have been put into a collapsed section for visual clarity.
Thanks to @emdobrin for the initial template for this API's documentation!
Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Thanks for the review @addb! Updated to include more context for key terms when they are introduced for the first time, with one question on nil vs null terminology

About null vs nill, Even though it is relevant with the UUID lingo, I would say let's adjust it to the context of the platform, so null in case of Java.


QnA Maker fix code snippet - wrong package name

@nerajput1607 - wrong package named in code snippet

@sarangan12 Can you help reviewing this PR?

#sign-off

Closing this in favor of #10213


[ICD] missing dependenc/wrong dependency from ReliableMessageMgr.cpp

In https://github.com/project-chip/connectedhomeip/blob/master/src/messaging/ReliableMessageMgr.cpp#L41 we have:
#if CHIP_CONFIG_ENABLE_ICD_SERVER
#include <app/icd/ICDManager.h>  // nogncheck
#include <app/icd/ICDNotifier.h> // nogncheck
#endif

which includes ICDManager, however dependencies in https://github.com/project-chip/connectedhomeip/blob/master/src/messaging/BUILD.gn#L70 only include src/app/icd:notifier
This is not ok, if you include ICDManager you must also depend on :manager. Using //nogncheck is a bad "workaround" (and it was used previously just because ifdefs ... it does not apply here).
Logic has to be changed to:

depend on what you use
dependency to ICD should be done based on CHIP_CONFIG_ENABLE_ICD_SERVER not always as it is currently

//nogncheck was not used as a bad workaround, ICDManager was conditionnally included in the dependency of the messaging static_lib
  if (chip_enable_icd_server) {
    public_deps += [ "${chip_root}/src/app/icd:manager" ]
  }

It should still be as it is used at line 262
mrpBackoffTime += app::ICDManager::GetFastPollingInterval();
it seems it was removed by mistake by someone.
So the solution is to add back the dependency in the build.gn. Or remove the include and change how the FastPollingInterval value is retrieved for the mrpBackoffTime calculation

Should icd:notifier have also been part of CHIP_ENABLE_ICD_SERVER?

The reason was probably:
2023-11-16 20:59:25 INFO    ERROR Dependency cycle:
2023-11-16 20:59:25 INFO      //third_party/connectedhomeip/src/app/icd:manager ->
2023-11-16 20:59:25 INFO      //third_party/connectedhomeip/src/app/icd:sender ->
2023-11-16 20:59:25 INFO      //third_party/connectedhomeip/src/lib/address_resolve:address_resolve ->
2023-11-16 20:59:25 INFO      //third_party/connectedhomeip/src/messaging:messaging ->
2023-11-16 20:59:25 INFO      //third_party/connectedhomeip/src/app/icd:manager

Address_resolve depends on messaging which depends on ICD.
Our layering is wrong.

It looks to me like #30385 did this.

Yeah this circular dependency is newly added code it seems. I can clean this up by remove icd:manager from :messaging and creating a new icd:dataclass
For the icd:notifier. It is a clean dependency, I can gate it in #ifdef CHIP_ENABLE_ICD_SERVER if you prefer. It is mostly a virtual call with a class to register and broadcast to listeners.

The reason for AddressResolve dependency seems to be #include <messaging/ReliableMessageProtocolConfig.h>.
We could maybe split that out in a separate source set.

Also and option. I have some time tomorrow to clean that up

This PR https://github.com/project-chip/connectedhomeip/pull/30552/files#diff-e876b9bac9dbe61d8a74bf89603d90d47850fef5167ca794d37fd58f17ea3c3d
remove the ICDManager Include and its use in favour of the definition for the time being.
I will now work on the AddressResolve dependency we discussed, And @mkardous-silabs should have already started working on the icd Data Class I mentioned.


Grammar update

An is reserved to precede words that start with vowels. Changed from 'an validation' to 'a validation'.

Thanks! :+1:


[Feature Request]: Improvement of Scroll Bar.

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
Improvement of scroll bar
Record

[X] I agree to follow this project's Code of Conduct
[X] I want to work on this issue
[X] I'm willing to provide further clarification or assistance if needed.

Hi, since hacktoberfest is almost over, I dont have time for new features. But thanks for the idea. Maybe next year✌🏻.


Suporting u+ is in plan?

If there is a plan to support u+ device?
Thanks so much!

See https://github.com/f4pga/prjuray - https://github.com/SymbiFlow/f4pga-arch-defs/pull/1651

Support for Ultrascale and Ultrascale+ will most likely end up happening through the FPGA Interchange Format rather than this architecture definitions approach.
You can see some initial xczu7ev support in that method -> https://chipsalliance.github.io/fpga-interchange-tests/#xczu7ev

Support for Ultrascale and Ultrascale+ will most likely end up happening through the FPGA Interchange Format rather than this architecture definitions approach.
You can see some initial xczu7ev support in that method -> https://chipsalliance.github.io/fpga-interchange-tests/#xczu7ev

FPGA interchange tests — fpga-interchange-tests 0.1 documentation

Ok,thanks so much!
This project fpga-interchange seems like that next-pnr generate *bba through rapidwright,and the use next-pnr place and route! It may meet problem while device's data over the limit of capnp!
It means that the work generating vpr's device data through rapidwright for Ultrascale+ is in plan?


[BEAM-8315] Clean-up unused fields for splitting SDFs

I kept output watermark around since this is expected to be reported for streaming SDFs.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

R: @boyuanzz


Added Supra's VRF documentation.

Description
Added Supra's VRF documentation into new folder structure.
Additional context
Adding a resource for developers.

I just made a minor update to the align with the contributing guide. Thank you for your contribution!

Thank you, what is the link so that I can see the update?

@ksdumont I'm sorry I wasn't very clear. This is just on github right now, but its developer focused so we can easily point folks to resources. We are going through a docs refresh currently. So our contribution paths are going to be more clear for something that is hosted on a website.


Search field in a List view

Guys, the application went into production on Monday and my users asked me for some views that list the items in the database, a search tool, where I can type the name and a Job or Error for example and list only that information.
Is there any way to implement this today or some project for those who know how to add this functionality in the future?

Yes you should:

build a filter view for this table where you include a search bar
build a page where you embed both the filter view and your list

does this solve your problem?

Thanks a lot, it worked! I didn't know how to correctly use the filter, I thought it was to generate a view with the data and it would show the table as a whole, but doing it this way worked!
Just a strange thing, after selecting the item I want in the combo box, the page reloads, filtering the data, but the combo box comes back empty, instead of with the Job Name value selected for example.
But this is just something aesthetic, the functionality is perfect!
Thanks!

@glutamate I tried doing that but im having a hard time figuring it out for searching on tables when one of the columns has one-to-many relationship to another table.
Example: customer has many locations. Customer table has name and a column "location" that references "Location" table.  I want to search on both name AND location. So I built a list view on "Location" table, and in the view, I use JoinField to show the customer name along with the location address. When I add filter for the "Location" table, it searches neither location nor customer.
Is there a workaround?


Update part2.md

login cmd needs -u parameter. Added to instruction.

Proposed changes

Unreleased project version (optional)

Related issues (optional)

Deploy preview for docsdocker ready!
Built with commit c7d9aa0f06b9adae0d2c704c27e6f23564994c5c
https://deploy-preview-9030--docsdocker.netlify.com

https://deploy-preview-9030--docsdocker.netlify.com/get-started/part2/

@ronaldkuip
Thank you for taking the time to review and update our docs. In this introductory example, we have deliberately left out the the -u flag because the command prompts the user if it's left out, and so that a new user doesn't have to remember the -u flag. Therefore, I'm closing this pr without merging it. We appreciate the feedback and hope to see more prs from you!


Creating home page, using Bootstrap.#1 #10

Created our own classes for vertical align as bootstrap vertical align wasn't centring for us.

done


Update parameter sweeper to run head epochs, unfreeze, and body epochs

Description
Parameter sweeper can be used to find good parameters. However, parameter sweeper does not support training of head, then unfreeze, then further training of full DNN. Need to be consistent with 03 notebook.

Was already implemented and is default option. Uses a quarter of the epochs to train the head.


Replication Controller syncs current replica count with api server #4429

We currently figure out the replica count by filtering through all active pods and counting those in an active state. These actions are duplicated across the replicationcontroller (in SyncReplicationController) and the apiserver (in fillCurrentState). This PR syncs the replica count computed in the former directly with the apiserver, obviating the need for the latter.

Please don't merge, still running e2e
@bgrant0607 @lavalamp

I think this is exactly what we were looking for, thanks!
Can you squash these commits? I think you've got some debug-only stuff in the first commit. :)

Cool, thanks! I'm going to let @lavalamp review this, unless you have a specific question for me.

Apologies. Squashed.
I have an update after some local testing. This PR effectively exchanges a couple of reads (to list pods) for a write (to the replication controller), causing flake in kubectl. Specifically if I try to create an rc and resize soon after in a tight loop, one of the updates in the apiserver or kubectl will fail. For a more concrete benchmark 5/20 runs of test-cmd.sh flaked, so I think I should fix #4691 before proceeding. If that's lower priority I can just shove an until into test-cmd.sh and call it a day. Thoughts?

Yeah I think a retry loop and/or a sleep statement with a TODO is an ok temporary solution to get this in.

Can you rebase this? It should be good to go now, right?

sure, I'm running e2e but can't tell if it's failing because of general instability (eg: https://github.com/GoogleCloudPlatform/kubernetes/issues/4566), or what, so for now I've decided to retry :|

Rebased, but e2e tests seem to be pretty unstable on master currently so I'm thinking wait till they recover and rerun?

what e2e errors are you seeing? This PR does change the status to be delayed by the replication controller binary's poll period, which could conceivably break some assumptions.

True, the failures I saw were on master. But I'll run the controller tests with ginkgo.focus on my branch to check.

Sorry, I was too slow with the merge button-- can you rebase again?

I need https://github.com/GoogleCloudPlatform/kubernetes/pull/5193 before I can separate flake from fail in e2e

#5193 merged :)

After a lot of fun with e2e I finally got them to pass. Sorry for the wait, PTAL.

LGTM

Rebased

PTAL

Added tests and ran e2e, PTAL

LGTM, thanks!


customizable request payload

PR allows to select a payload for the request from the one in payload/. Default is a 100 bytes string.

Looks really useful, thank you!


Point Slack badge to Pion Slack info page

The current link doesn't include the invite link or any info on how to get to it.
The updated one is the same link that's used on the main pion/ion repo.
Might save the next person 10 minutes :)

:fire: thanks @vicramon


Stood on path triggers observer every tick

Turn on sound for this (and loop it)!
https://user-images.githubusercontent.com/8464472/128274418-13f222dc-788d-4e95-a9e6-fa60f36cbd31.mp4
I think this might be an easy fix.
Surely it's calling this each tick:
https://github.com/lebonq/Automatic-Path/blob/adf8b3a1e585e37652a0159d0de371103272a495/src/main/java/fr/lebon/autopath/mixin/BlockOnStepped.java#L22
By default setBlockState() uses the Block.NOTIFY_ALL flags, which is NOTIFY_NEIGHBORS and NOTIFY_LISTENERS combined.
I'm not sure exactly on the semantics of those flags, they are documented inside Block, it says:
/**
 * Sends a neighbor update event to surrounding blocks.
 */
public static final int NOTIFY_NEIGHBORS = 1;
/**
 * Notifies listeners and clients who need to react when the block changes.
 */
public static final int NOTIFY_LISTENERS = 2;

I'm assuming the neighbor updates are what does it, so this might be fixed by using
world.setBlockState(pos,AutoPath.PATH_BLOCK.getDefaultState(), Block.NOTIFY_LISTENERS);

Ah, I got the wrong code snippet, the one above turns grass blocks to path, for which it is probably okay to notify neighbors - though I would change it too.
It's this one here which is the culprit:
https://github.com/lebonq/Automatic-Path/blob/cf9c30ecb200216562d25e7328196a7d57449551/src/main/java/fr/lebon/autopath/blocks/PathBlock.java#L57

Any news on this issue? It's fairly annoying to have my sheep farms non-stop clicking like this. :)

I think @Fourmisain got it right !
Right now I don't have time to dig more than this. So @Fourmisain if you can make a pull request  I will test it and release the jar !
Don't worry in the following week I'll fix more issue ;)

Ok I have a strange issue with my hardware, Windows 11, Java 16 and Minecraft :(
I need to use my laptop so I'm a little bit late

@BrekiTomasson Fix in 1.4.4 ! you can find it on github ! or curseforge in a couple of minutes


Publish only works when throwable is triggered

I'm trying to publish to a topic from PHP-CLI 7.2.
require_once __DIR__ . '/vendor/autoload.php';

define('AUTHID', 'server');
define('REALM', 'realm1');
define('URL', 'ws://<ip>:<port>');
define('SECRET', '<secret-token>');

try {
    $connection = new \Thruway\Connection([
        'realm' => REALM,
        'url' => URL,
        'authmethods' => ['wampcra'],
        'onChallenge' => function (\Thruway\ClientSession $session, $method, \Thruway\Message\ChallengeMessage $challenge) use (&$config) {
            if ($method != 'wampcra') {
                echo 'Client attempted to authenticate with unsupported method: ' . $method, PHP_EOL;
                return false;
            }
            $cra = new \Thruway\Authentication\ClientWampCraAuthenticator(AUTHID, SECRET);
            return $cra->getAuthenticateFromChallenge($challenge)->getSignature();
        },
        'authid' => AUTHID,
    ], new \React\EventLoop\StreamSelectLoop);
}
catch(\Throwable $e) {
    throw $e;
}

$connection->on("open", function (\Thruway\ClientSession $session) {
    $count = 0;
    while(++$count <= 6) {
        echo "Publishing #".$count, PHP_EOL;
        $session->publish('tour.nomination-68', [$count], ['test'=>'me'], ['acknowledge' => false]);
        echo "Published #".$count, PHP_EOL;
        sleep(2);
    }
}
);

$connection->on("close", function ($reason) {
    die("The connected has closed with reason: {$reason}\n");
});

$connection->on("error", function ($reason) {
    echo "The connected has closed with error: {$reason}\n";
});

$connection->open();

This snippet is not working.
I get the Publishing #n and Published #n messages, but the topic is not emitted.
BUT, if i intentionally make an error, i get the first submit, but only the first:
        $session->publish('tour.nomination-68', [$count], ['test'=>'me'], ['acknowledge' => false])->then();

I also tried acknowledge, but it doesn't work either:
        $session->publish('tour.nomination-68', [$count], ['test'=>'me'], ['acknowledge' => true])->then(function(){ echo 'Success!',PHP_EOL; });

Success! is never output.

EDIT: Versions:
            "name": "thruway/client",
            "version": "0.5.3",

            "name": "thruway/pawl-transport",
            "version": "0.5.0",

Router: Crossbar.io

@lajosbencz The sleep inside the while loop is blocking everything from happening. You should instead use a timer:
$connection->on("open", function (\Thruway\ClientSession $session) {
    $count = 0;
    $session->getLoop()->addPeriodicTimer(2, function (TimerInterface $timer) use ($session, &$count) {
        echo "Publishing #".$count, PHP_EOL;
        $session->publish('tour.nomination-68', [$count], ['test'=>'me'], ['acknowledge' => true])
            ->then(function () use ($count) {
                echo "Published #".$count, PHP_EOL;
            });

        if (++$count >= 6) {
            $timer->cancel();
        }
    });
});

I am not sure if that fixes everything, but it is working for me with that change.

@lajosbencz Not sure if you are using a reactphp redis lib. If you are not, you may want to look into that (possibly https://github.com/clue/php-redis-react). This will keep your redis calls from blocking.


Speakleash Data Visualization

Sample charts + descriptions in jupyter notebook, here: https://github.com/mglabska/speakleash_pckg/blob/master/README.md
Charts generation code here: https://github.com/mglabska/speakleash_pckg/blob/master/charts.py

May resolve:
https://github.com/speakleash/speakleash-examples/pull/13


Add TokenGate to core

This PR adds the TokenGate component to the core package.

The core version of the TokenGate builds on top of its counterpart in components.

Looks nice. 👍🏻


VSCode extension seems to hang

Describe the bug
Upon opening any given repository in VSCode, I can see from the logs that the language server has started from the DevSkim VS Code Client output logs, however, nothing else happens.
To Reproduce
Steps to reproduce the behavior:

Run devskim analyze -I . in a repository that has devskim items to address
Confirm that there is some output from the previous command
Open the repository in VSCode
Install the DevSkim extensions if it is not already installed
Click on Output tab (Ctrl+Shift+U)
Select DevSkim VS Code Client form the sources dropdown on the right hand side
Observe logs stating that language server has started
Navigate to a file that contains problems identified in step 1
Observe that nothing identifies the problem

Expected behavior
VSCode should visually identify the problems that were found by running devskim analyze -I . in the same repository.
Screenshots

Versions(please complete the following information):

OS:

Windows 10.0.22621 Build 22621
WSL - Ubuntu 20.04.6 LTS

Devskim CLI: 1.0.8
Devskim VSCode Extension: 1.0.8

Additional context
Example:
The following image shows a TODO comment that is not identified as a problem in VSCode with the DevSkim extension running:

But running the CLI identifies the problem correctly:

@robjackstewart The issue you're seeing may be related to the issue that will be fixed by #559, but I don't see this specific behavior specifically at this time with either the published or fixed versions when scanning files on the windows file system from a windows VS Code window on a fresh install of Windows 10.
I notice that you list a WSL version, and the interface here shows "WSL" as part of the project name. Can you clarify how WSL is being used here so I can attempt to more accurately reproduce this?

Closed due to no repro on latest version. Feel free to reopen this or open a new issue with the additional details requested about how WSL factors in here if you're still experiencing this problem.


No WebGL : Adding fallback or support page

as webvr-boilerplate is webgl only - you may add a fallback or support page at line https://github.com/borismus/webvr-boilerplate/blob/master/index.html#L88
currently the switch to CanvasRender causes troubles with the get/setsize value from webvr-manager,
so it's uncommented here:
function webglAvailable() {
    try {
      var canvas = document.createElement( 'canvas' );
      return !!( window.WebGLRenderingContext && (
        canvas.getContext( 'webgl' ) ||
        canvas.getContext( 'experimental-webgl' ) )
      );
    } catch ( e ) {
      return false;
    }
  }

  if ( webglAvailable() ) {
    renderer = new THREE.WebGLRenderer({antialias:true});
  } else {
    //renderer = new THREE.CanvasRenderer();
    window.open("add custom page or url here - eg. https://get.webgl.org/","_self")
  }

Additionally, it is necessary to handle lack of canvas support, e.g.
    function PlayerManager(canvas, id, caption) {
    this.loadIcons_();
    // Save a canvas reference.
    this.canvas = canvas;
    ...
    // Warning when HTML5 canvas not supported.
    this.canvasWarn = 'Your browser does not support HTML5 Canvas. You need to upgrade to view this content.';
    ...
    // Set the message if web browser doesn't support canvas.
    canvas.textContent == (canvas.textContent || this.canvasWarn);
    ...

This is related to why a 'player' wrapper is needed for the canvas and its controls, if the canvas is embedded in an HTML page. canvas child elements can only be text, displayed in browsers lacking canvas. So, the canvas and its controls have to be sibling elements wrapped inside a 'player' container.

does the boilerplate actually need a fallback to CanvasRenderer? of course it’s great to have even more support with CanvasRenderer, but it doesn’t run out of the box and with complex scene you will have to do a lot of internal fallbacks with shaders, materials, lights/shadows .. not to mention performance distinctions. i think it’s better to stay with WebGLRenderer only and if there’s no WebGL Support i would suggest to forward to get.webl.org

I don't think a fallback to canvas is going to be performant enough. I like the idea of having a "WebGL required" error, though.


React 15.2.1

Looks like it is not possible to use shrinkwrap because of libsass (and different OS)


Added 2 nodes of 2 users

Added:
@ech0.re:matrix.org 1 node
@oleg-plakida:matrix.org 1 node

@ironoa Element handles were verified


add nitime to intersphinx; deduplicate some docstrings

follow-up to #10030, I realized too late that all those docstrings were identical.
@guiomar FYI, this PR does what I would have suggested you do in #10030 if I had thought of it before merging:

make nitime into a link that goes to their documentation; this is possible because both packages use sphinx to build their docs so we can use intersphinx to cross-link to their module
since all 5 instances of the normalization docstring entry were identical, I've abstracted them out into our docdict so that in future we only need to change it in one place.

Oh! That's very smart, I didn't know that this thing existed (utils/docs.py), it seems to help a lot in homogenizing things!

Thanks @drammock


Add logging of Clang version

PR to address #152 for logging libclang version for debugging purposes. Let me know if it needs tweaking!

 Warning

These commits modify unsafe code. Please review it carefully!

Travis seems to be timing out on this one.

Travis seems to be timing out on this one.

Really strange... The logs seem to be empty... I'll restart them and see if that works.

Thanks for all the feedback! I've gone through and implemented your advice, hopefully it's more robust now.

:pushpin: Commit 59468b9 has been approved by emilio

@bors-servo r+
Thanks!

:hourglass: Testing commit 59468b9 with merge 20c6f45...

:sunny: Test successful - status-travis


Set version for maven-compiler-plugin.

Fixes the maven build warnings:
[WARNING] 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-compiler-plugin is missing. @ line 42, column 21
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.```

LGTM


Add function for get ManufacturerData and AdvertisingData with more tests

Hello, it is the same PR #53 , but with added unit tests, as it was requested in the comment
          Hello, thanks for this useful PR. Can you integrate it with some unit tests.

Originally posted by @chrvadala in https://github.com/chrvadala/node-ble/pull/53#pullrequestreview-1284036695

Hello @chrvadala,
Any chances to have this PR reviewed and possibly merged into your repo?
Thanks in advance!
CC: @Raffone17

@gmacario I reviewed the original PR https://github.com/chrvadala/node-ble/pull/53.
If you prefer to continue here, we can close the old one start from here.

@chrvadala we can continue from here.

That's fine, I'm going to close the other PR. Anyway, I commented your code there and I see that same requests apply here. Can you review your code? Thanks

Superseed by #67

Released with 1.11


Update CHANGELOG.md

Changelog category (leave one):

New Feature
Improvement
Bug Fix (user-visible misbehaviour in official stable or prestable release)
Performance Improvement
Backward Incompatible Change
Build/Testing/Packaging Improvement
Documentation (changelog entry is not required)
Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
...

Information about CI checks: https://clickhouse.tech/docs/en/development/continuous-integration/

run this test

run this test

test this please

test this please

test this please

retest this please

ok to test

test this please

retest this please

ok to test

test this please

test this please


Migrate from k8s.gcr.io to registry.k8s.io

This PR migrate from k8s.gcr.io to registry.k8s.io
Part Of https://github.com/kubernetes/k8s.io/issues/4780

gcloud (418.0.0) seems still using staging-k8s.gcr.io

Just an FYI - staging-k8s.gcr.io used to be a push only endpoint, however that is no longer the case and largely acts as a placeholder to swap out for other addresses. It should be safe to remove, but also fine to leave as is. It won't really be used for anything.


Highlight and let me navigate to back relation belonging to a relation

For huge schemas, being able to follow a relation not only to the model but the back relation is pretty useful - especially if there are multiple relations between the same models.
It woudl be great if we could visually highlight the back relation belonging to a relation, and also have a way to navigate to it directly.

Navigation as described was somewhat implemented, it's not as direct as simply go-to-definition but finding references will open up a menu that you can then navigate from
https://github.com/prisma/prisma-engines/pull/4934


HTML Working Demo with CRUD operations for local db.json

Hi there!
This looks great and I got the basic http://localhost:3000 to display the data fine.  What I'm interested is building a little sample web page or few web pages that can also create, update and delete data from the local db.json file - has anyone created such a working demo which can be shared?
Many thanks
Philip
PS I've never posted on to a GitHub project before but couldn't see anywhere else to put this message so forgive me if this is not the right place to post this request.

Hi @philanderson888,
You can post in issues :+1:
https://github.com/typicode/json-server/issues
That's a good question and I don't really have a definitive answer to it. I would suggest giving a try to
admin-on-rest for something quick.
There may be other similar tools that lets you turn a REST API into a CRUD interface.
Developing your own interface using a front-end framework like Vue, React or Angular can be another option but it may take some time.
I'm closing this since it's not a real PR but feel free to copy this question to the issues or ask on Stack Overflow, maybe other people will come with some other ideas :)

Thank you for responding; I'll pay someone to write up a quick front end as I'm not sure where to start.


Cooperate flutter_rust_bridge with package:rfw(Remote Flutter Widgets), for example, downloading the rust compiled library at runtime and binding with that

@Hixie, from Flutter official team, said at https://www.reddit.com/r/FlutterDev/comments/q5mmtz/comment/hg77jtj/?utm_source=share&utm_medium=web2x&context=3 that:

I wonder if there's an interesting synergy with package:rfw... imagine downloading the rust compiled library at runtime and binding with that, for example

Also related: https://github.com/flutter/flutter/issues/90218
Feasibility
Again, as is always said, this lib does nothing but simply generate some code that a human being will otherwise write down manually. So there should be no problem as long as one can make a human-written-down ffi work.
Challenges
We may need to cooperate with authors of package:rfw to see what we can do.

I was imagining something similar to https://github.com/flutter/packages/tree/main/packages/rfw/example/wasm — the first step would be to experiment with creating a similar example that uses this package instead of wasm. It may not even require any changes in the packages themselves.

@Hixie Sounds great! Will work in https://github.com/fzyzcjy/flutter_rust_bridge/issues/297

@Hixie Hi may I know the future, i.e. how promising is it, for rfw (and its cooperation with flutter_rust_bridge)? For example, will it be a suggested-to-use or widely used package, or is it just a small experiment?

@Hixie Hi may I know the future, i.e. how promising is it, for rfw (and its cooperation with flutter_rust_bridge)? For example, will it be a suggested-to-use or widely used package, or is it just a small experiment? If it is promising, we may put more efforts on it and prioritize it.

We don't have plans to make rfw a Flutter Favorite plugin, but it's pretty stable and I don't expect it to go away. We ensure that we keep Flutter compatible with it. Patches to rfw to add new features (especially widgets) are welcome.

@Hixie Thanks!


storage_driver.go: property name be "offset"

Signed-off-by: Guangming Wang<EMAIL_ADDRESS>Ⅰ. Describe what this PR did
just correct code typos in comments :)
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #797 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #797   +/-   ##
=======================================
  Coverage   39.23%   39.23%
=======================================
  Files         108      108
  Lines        6313     6313
=======================================
  Hits         2477     2477
  Misses       3630     3630
  Partials      206      206

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0ecd29...b8afbdf. Read the comment docs.

Thanks for your contribution.
Can you please move this typo to https://github.com/dragonflyoss/Dragonfly/pull/798 and sign off your DCO?

LGTM


Rename run training environment script

This commit renames the “run training environment” script to make it clear it uses bowl rather than upstart. It also adds a comment to this effect in the file.

I've amended the comment to hopefully make it clearer what it's used for, which is development of the training environment.

I've amended the comment to hopefully make it clearer what it's used for, which is development of the training environment.

Ok, thanks :)


Remove interchange and generalize pattern calls

Linalg generic interchange and strategy generelize patterns are retired, see below. This revision removes calls that are removed.
https://reviews.llvm.org/D132368
https://reviews.llvm.org/D132363

Thanks!


Add test coverage badge to README

This pull request aims to enhance the visibility of our project's test coverage by adding a test coverage badge to the README file. By including this badge, we make it easier for contributors, users, and stakeholders to quickly assess the quality and comprehensiveness of our test suite.
Changes Made

Added a test coverage badge to the README file.
Integrated a coverage reporting tool to track and calculate test coverage.

Why is this important?
Maintaining a high level of test coverage is crucial for ensuring the reliability and stability of our software. The test coverage badge serves as a visual indicator of our commitment to producing robust code. This addition not only encourages transparency but also helps build trust among our community and potential users.

/kind documentation

/approve
looks great!


first conversation with Blue Tile

Blue Tile explains their whole deal, while Posty is captured by the compulsion to take the painting

bt: My brain can't comprehend the composition of it all!!!
p: Ah yeah, I love how... orderly and serene it is.
p: (Here is the prize! Just need to wait for an opportunity)
bt: You said it!!! This exhibition makes me feel things like astonishment and awe and glory-
p: (That painting is so close to me, why can't he go away)
bt: Ever since these beautiful masterpieces fell from the clear skies, I always had to watch out for jealous vandals whom I won't name-
bt: coughs Red Tile coughs
bt: who have a vendetta against this exquisite cultural array due to it being "the wrong colour".
bt: Personally, I don't have a particular favorite colour, I like all the colours of the rainbow: Blue, Zaffre, Periwinkle, Azure, Denim, Glaucous and Eclipse!
bt: But that doesn't mean I shun other colours like Mr "Paint the Whole Gallery" Red, I just like these pieces because of the message and the meaning behind every stroke and every frame...
p: (Damn this exhibition is putting me to sleep, maybe a splash of brown could perk this up)
p: Me too.
bt: I am so glad we can come to such total agreement about these pieces, not just because of colours!
p: Hahaha.

I like blue tile's dialogue here, but taking the painting is not an explicit goal for Posty, at least not at the start of the scene, it's more of a spontaneous compulsion

label .painting:
    if saw.bluetile == False:
        show bg museum_blue_p_rusty
        show posty neutral
        show bluetile giddy
        $ saw.bluetile = True
        bluetile "Hello!! Another lover of this exhibit! Yay!!!"
        bluetile "This artwork in particular really speaks to me!! What about you?"
        p "Oh no I'm just looking aro-"
        show posty astonished anim
        "As soon as Posty glanced at the painting Blue Tile refered to, she was suddently captured by the compulsion to take it."
        p astonished "..Woahh..."
        bluetile "You said it!!! This exhibition makes me feel things like astonishment and awe and glory!"
        bluetile "Ever since these beautiful masterpieces fell from the clear skies, I always had to watch out for jealous vandals whom I won't name-"
        extend annoyed "{i} coughs Red Tile coughs{/i}"
        bluetile "who have a vendetta against this exquisite cultural array due to it being \"the wrong colour\"."
        p "Uh huh..."
        extend quiet "{i} If only those bars weren't in the way..{/i}"
        bluetile "Personally, I don't have a particular favorite colour, I like all the colours of the rainbow: Blue, Zaffre, Periwinkle, Azure, Denim, Glaucous and Eclipse!"
        bluetile "But that doesn't mean I shun other colours like Mr \"Paint the Whole Gallery\" Red, I just like these pieces because of the message and the meaning behind every stroke and every frame..."
        p "Yeah yeah.."
        extend quiet "{i} How would I even carry it?{/i}"
        bluetile "I am so glad we can come to such total agreement about these pieces, not just because of colours LIKE SOMEONE WHO I HAVE THE GRACE TO NOT NAME AND SHAME!"
        #114
        if item.ladle_full:
            jump .painting_ladle_blocked
        else:
            p neutral "Huh- Oh I should probably go. Cya!"
            jump museum_blue

label .painting:
if saw.bluetile == False:
show bg museum_blue_p_rusty
show posty neutral
show bluetile giddy
$ saw.bluetile = True
bluetile "Hello!!! Another lover of this exhibit! Yay!!!"
bluetile "I'm Blue Tile! My friends call me Blue! That's my friend Red Tile! Who are you?"
p "Name's Posty. What's going on?"
p "This is the new blue exhibit they curated just a few days ago! This is the one of the happiest days in my life!"
bluetile "This artwork in particular really speaks to me! It's a portrait of Crayon Box, the host of that reality show in the dome! What about you?"
p "Oh no, I'm just looking aro-"
posty astonished anim "!"
"As soon as you clance at the painting Blue Tile refered to, you are suddently raptured with the feeling of {color=#ffff00}{i}inspiration{/i}{/color}."
p astonished -anim "...Woahh..."
bluetile "You said it!!! This entire exhibition makes me feel things like astonishment and awe and glory!"
bluetile "Ever since these beautiful masterpieces fell from the clear skies, I always had to watch out for jealous vandals whom I won't name-"
extend annoyed "{i}coughs{/i} Red Tile {i}coughs{/i}"
bluetile "who have a vendetta against this exquisite cultural array due to it being "the wrong colour"."
p "Uh huh..."
extend quiet "{i} If only those bars weren't in the way...{/i}"
bluetile "Personally, I don't have a particular favorite colour, I like all the colours of the rainbow: Blue, Zaffre, Periwinkle, Azure, Denim, Glaucous and Eclipse!"
bluetile "But that doesn't mean I shun other colours like "Mr Paint the Whole Gallery Red", I just like these pieces because of the message and the meaning behind every stroke and every frame..."
p "Yeah yeah..."
extend quiet "{i} How would I even carry it?{/i}"
bluetile "I am so glad we can come to such total agreement about these pieces, not just because of colours LIKE SOMEONE WHO I HAVE THE GRACE TO NOT NAME AND SHAME!"
if item.ladle_full:
p astonished "SCREW IT! I HAVE TO SET IT FREE!"
 I'm sorry! I think dozed off there."
bluetile giddy "Oh, that's alright! I get that way sometimes when I stand here for too long."
p "I should probably go. Cya!"
jump museum_blue


memory leak in jvm application

Hyprland Version
 System/Version info
Hyprland, built from branch HEAD at commit 03ebbe18ed8517ee22591eac82cd54322f42cb7d  (props: bump ver to 0.34.0).
Date: Mon Jan 1 12:03:15 2024
Tag: v0.34.0

flags: (if any)

Bug or Regression?
Bug
Description
When JVM application windows are rapidly and significantly resized, memory can quickly increase until the system becomes unresponsive
How to reproduce

Have a float jvm application window(e.g. IDEA or compose multiplatform application)
Quickly resize window

Crash reports, logs, images, videos
No response

how is this a hyprland issue?

If I use plasma(wayland), this issue won’t occur

what about sway?

It won't happen in Sway either

I still would take it to whoever is maintaining your jvm, after all it's a leak in their code, not mine.

After trying version 0.35, this issue no longer occurs.
In previous version, Electron also encountered the same issue.


Sprint/2102

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.11 out of 12 committers have signed the CLA.:white_check_mark: mfiess:white_check_mark: vijs:white_check_mark: acheri988:white_check_mark: anand-ky:white_check_mark: emutavchi:white_check_mark: npoltorapavlo:white_check_mark: rdamod:white_check_mark: bobseamon:white_check_mark: sborushevsky:white_check_mark: anaswarakookkal:white_check_mark: vdinak240:x: ManojBhattaTELYou have signed the CLA already but the status is still pending? Let us recheck it.

Please resubmit the necessary changes to the latest sprint branch.


[Question] Recommended way to get a raw string value from a custom query

Since the JSON output type will return quoted value strings (e.g. "foo" instead of foo), what is the recommended solution for getting the raw/unquoted value of a string that is returned from using a custom --query flag? Using -otsv seems to work, but feels kind of "hacky" (?), and obviously piping JSON output to jq -r would work, but seems strange to need to use JQ strictly to remove the quotes from a string.
Maybe -otsv is the right solution, and I'm just hung up on the name. Is the tsv output expected to be the "raw" format for scalar values? Is there a way to achieve this behavior via JMESPath? I looked at the spec but couldn't find anything. Either way, I'd love to hear what the recommended solution is for this, since I'm probably missing something.

I ran into exactly this issue last night and ended up replacing the whole query with jq (thankfully they're the same syntax):
vm_ip_json=$(az vm list-ip-addresses \
    --name "$name" \
    --resource-group capturetest)

vm_ip=$(jq --raw-output \
    '.[0].virtualMachine.network.publicIpAddresses[0].ipAddress' \
    <<<"$vm_ip_json")

Nice to know you can combine the --query and -otsv though.

@valencik Yeah that's definitely another solution, but I was curious how to achieve this without needing to rely on jq at all, since the --query option (and -ojsonc) for the AZ CLI provides most of what I typically need.

@lostintangent, using --out tsv is indeed intended way to get "raw" string data. If the collective community can come up with a better name, I'd be more than happy to make the change to support it.
The argument against "raw" was the possible confusion between "don't touch the data that I received from Azure" (which would imply json since that is what is on the wire) and the "don't quote strings" that you are expecting here...

@johanste Sounds good. I'm cool with -otsv, I just wanted the confirmation that this was the correct solution here. Thanks so much!


[Feature Request] Add preference to allow using the system LLDB on macOS

OS: macOS
It would be useful to add a setting to with one click use the system lldb on macOS.  The motivation here is that macOS privileges the system lldb in ways the lldb shipped with codelldb isn't when launching application bundles on macOS.
As some background:
I noticed while debugging an application that requests access to a user's photo library by using [PHPhotoLibrary requestAuthorization] that the Apple crash for not providing NSPhotoLibraryUsageDescription was occurring, but only when debugging under codelldb.  After investigation, I determined that because of codelldb using a builtin lldb, macOS treats VSCode as the responsible process and VSCode obviously doesn't provide NSPhotoLibraryUsageDescription.
I was able to work around this issue by providing lldb.libpython and pointing it to the version in Xcode at /Applications/Xcode.app/Contents/SharedFrameworks/LLDB.framework/Versions/Current/liblldbPluginScriptInterpreterPython3.dylib which seems to result in the debugserver binary from within LLDB.framework being used, which uses the system lldb for debugging and has the necessary privileges to treat the launched app as a standalone application and not tagging VSCode as the responsible application for the access request.
(As additional data, codelldb seems to still use liblldb.dylib from within the CodeLLDB extension)

What happens if you just add "lldb.adapterEnv": { "LLDB_DEBUGSERVER_PATH": "<system debugserver path>" } is workspace configuration?

That does not seem to work.  If I just add "lldb.adapterEnv": { "LLDB_DEBUGSERVER_PATH": "/Applications/Xcode.app/Contents/SharedFrameworks/LLDB.framework/Resources/debugserver" } it does seem to use the system debugserver that I specify, but it does not seem to privilege the debugger properly.

debugserver is the process doing actual debugging, I'd have expected it to be the one whos privileges matter.  CodeLLDB (or lldb for that matter) is just the UI.
If MacOS somehow propagates the permissions of debugserver's parent process(es), you could try remote-debugging, i.e. launch debugserver from terminal, attach to it as if debugging on a remote machine, etc.
Not sure what else could be done here...

Yeah, the entire behavior is very strange I agree. I think the process that launches the binary may be the one that matters.
From my perspective I’m more than happy with my workaround from the first comment. I figured I’d report my findings to you in case you had a better idea

This commit has broken the workaround

Yeah, Python is not bundled.  Have you tried replacing liblldb?  You can also do this manually by setting lldb.library.
Actually, the library you've used before, liblldbPluginScriptInterpreterPython3.dylib, looks like an instance of liblldb, not a Python runtime.    I wonder if its symbols simply took precedence over the bundled liblldb because of having been loaded first.

Interesting.  This seems to work.
I never actually tried dumping the symbols as I trusted the library name and once it worked as lldb.libpython I naturally assumed it was python.
I had tried setting lldb.library to /Applications/Xcode.app/Contents/SharedFrameworks/LLDB.framework/LLDB which is an lldb dylib, but that didn't work.
Does it make sense to expose "use the System LLDB" as a checkbox setting? From my perspective, setting lldb.library makes a lot more sense to me why it works, so I'm no longer convinced it's necessary.  Maybe just document how to fix the permissions crashing issue by using the System LLDB?  Happy to send a pull request updating documentation and/or help in any way I can


[docs] Fix collapse API docs description of 'hidden' style condition

[ ] I have followed (at least) the PR section of the contributing guide.

Fix #24046

@jaiwanth-v Thanks


fix renovate action so that an onboarding PR is generated

The last successful renovate run included the following logs
WARN: No repositories found - did you want to run with flag --autodiscover?

The following variable should be added to get renovate to actually generate the onboarding PR

RENOVATE_REPOSITORIES: ${{ github.repository }}
RENOVATE_ONBOARDING: "true"
RENOVATE_USERNAME: "kubearchive-renovate[bot]"
RENOVATE_GIT_AUTHOR: "kubearchive-renovate<EMAIL_ADDRESS>

#115 solves this issue


Prevent null section_id after creating first_free_subnet resource

Fix will prevent cases when section_id will be null after creating first_free_subnet resource:
Changes to Outputs:
  ~ subnet_test         = {
        id                     = "11"
      ~ section_id             = 1 -> null
        # (28 unchanged attributes hidden)
    }

Hi @lord-kyron , I can't approve my own pull requests
Can you add permissions for that?

@pavel-z1 - This one was manually approved.


Builder is not accepting overridden (using default on the interface) toString(), equals(), and hashCode()

merged


Convert to Typescript

Convert all Javascript to Typescript

Hey @ganderzz  . If convenient to you, can I join in?
It's an cool project and I am looking for an opportunity to contribute. Also, I have worked on TypeScript.

@thisis-Shitanshu Definitely. I have a branch out there that partially implements Typescript, but there are still quite a few build errors. Feel free to take that branch over, or use it as a base to contribute!

@ganderzz Great! I am starting working from the branch right away. I will reach out if I need your help somewhere and notify progress.

PR #117
Solves the error with the tests.


[FancyZones] stops working with space around zones less than -10

Microsoft PowerToys version
0.35.0
Running as admin
No
Area(s) with issue?
FancyZones
Other Software
No response
Steps to reproduce
Set space around zone to a value lower than -10
✔ Expected Behavior
FZ continue to work as expected
❌ Actual Behavior
FZ stops working

This is fixed in 0.53, get it at https://aka.ms/installPowerToys


[Misc] Bump transformers version

Bump transformers version to >=4.39.1. This is necessary since 4.39.1 patched some breaking changes to LLaVA model that would block https://github.com/vllm-project/vllm/pull/3042.

Waiting for CI to pass then I'll open the PR and merge it.


core: evaluate possibilities to improve responsive layouts

We already have pretty good responsive layout building. However, with patterns such as left-right, right-left (image, content) we get top-bottom bottom-top arranged mobile views. Also other issues such as hiding specific cells on mobile are currently not possible.
We need to evaluate possibilities for improving this.

#757
https://hostcloud.com.br


Zombies recover faster from crit. They heal Piercing damage

About the PR
Resolve a bug where Zombies would never heal from piercing damage (guns for instance). Also the healing now scales over time in crit so we don't have bored zombie players dead for multiple minutes (up to 8 minutes before).

Add Piercing damage (leaving it out was a mistake, did I miss any other damage types?)
Healing scales over time the zombie is in crit, to 2x rate after 5 seconds up to 10x rate after 45 seconds. If the zombie has 200 damage (100 over crit) they will take up to 70 seconds to be up and moving again.

Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl:

tweak: "Dead" zombies have a chance to spring back to life at any moment, they also passively heal most damage types slowly while alive. If you crit or kill them you have a chance to perma-kill.

@keronshb another zombie change, this one is more minor but will lead to zombies reviving faster.

As per our discussion in discord @EmoGarbage404 you don't have to gib zombies to perma-kill them anymore. You just need to do an additional 50 damage or so to make killing them very likely.
A medical analyzer will show an additional 100 blunt damage when they die for real. When exactly is random to make it more interesting.
This PR overall is aimed to ensure zombie players either die permanantly or respawn quite quickly, so we don't leave players in limbo.

Horay! Thanks @AJCM-git it's been an adventure.


Server is doesn't get started

Hello!
When I type in the console "npm start", I receive only this:
madpack@ubuntu:~/steam-microtransaction-api$ npm start

><EMAIL_ADDRESS>start /home/madpack/steam-microtransaction-api
> ts-node -r tsconfig-paths/register ./src/entrypoint.ts

Why don't I receive any logs, and when trying to check API Status, I get a 404 error?
The test "npm run test" passes without errors.
I will be glad of any help, thanks!

In the end, I wrote my own server...


Style CSS for pre-game page

Need to finish styling for pre-existing username display message

Styled pre-existing username error message


Use dev schema when uploading to Dev

$schema should be the dev schema.

refinement 13.11.2023:

sumo-core should change the $schema attribute on upload


Could I change data type of JDBC event table?

I use mysql as a event table for some reasons.
LEventStore.findByEntity function with entityType and entityId is slow and sometimes I am getting java.util.concurrent.TimeoutException.
I want to create index on this columns to improve performance.
https://github.com/PredictionIO/PredictionIO/blob/65a64c902ad7671dfb2fb0e29d8af806a01c55d0/data/src/main/scala/io/prediction/data/storage/jdbc/JDBCLEvents.scala#L43-L56
So, I modified these columns after creating table in my scripts such as below.
alter table pio_event_1_1 modify column entityType varchar(10) not null;
alter table pio_event_1_1 modify column entityId varchar(255) not null;
create index pio_event_1_1_idx1 on pio_event_1_1 (entityId);
create index pio_event_1_1_idx2 on pio_event_1_1 (entityType);

Is there any better way for this situation?

You could try using HBase rather than MySQL

Does your method work? Have you noticed appreciable speedup?

It works.

Insert about 3,500,000 event data.
Start pio eventserver --verbose
run curl command like this.
http://<HOST>:7070/events.json?accessKey=<ACCESS_KEY>&entityId=2113110721001555235805&entityType=user&limit=1000

First Query

without index. It takes 4837 ms

  [SQL Execution]
   select id, event, entityType, entityId, targetEntityType, targetEntityId, properties, eventTime, eventTimeZone, tags, prId, creationTime, creationTimeZone from pio_event_27 where entityType = 'user' and entityId = '2113110721001555235805' order by eventTime asc limit 1000; (4837 ms)

with index . It takes 6 ms

  [SQL Execution]
   select id, event, entityType, entityId, targetEntityType, targetEntityId, properties, eventTime, eventTimeZone, tags, prId, creationTime, creationTimeZone from pio_event_15 where entityType = 'user' and entityId = '2113110721001555235805' order by eventTime asc limit 1000; (6 ms)

Second Query

Both of them is fast from the second query if the query statement is the same.
Probably innodb_buffer_pool_size in mysql config works from second query.

Sounds like it's worth putting into the framework. I'm no SQL expert but making an enhancement request.
@schon could you create a pull request against the "develop" branch, that would be a big help.

@pferrel Thank you for your consideration. I'll do it.

@schon don't see a PR for this, we'll be releasing 0.9.6 soon, so if you'd like to get it in, please submit. [thank you for your other PR btw!]

Sorry to late. I have tested both mysql and postgresql.
To keep it backward compatibility, creating index is set configurable option.
Please check this PR.
Thanks


PHP 7.4 support

Hello @arshidkv12,
bolt is a great contribution to the PHP community - thanks for the hard work! I was wondering if you plan to provide a PHP 7.4 extension of bolt.so and PHP 8 in the future?

?

https://phpbolt.com/wp-content/uploads/2020/11/phpBolt-extension-1.0.2.zip


Implement Diff & Patch algorithm

Stop handling virtual DOM since 0.0.5 to focus on real DOM only.


inventory changer new feature suggestions

Can you consider adding a feature in the inventory changer that allows the user to input the skin attributes (such as float, seed, etc.) ?

The idea is very good!


Allow different text styling for header comments

Problem Description
Syntax coloring for cell comments should have a different text color/size scheme. This helps getting a quicker overview of the code, just like Problem Description and Versions headers in this post helps finding relevant information quicker.
Matlab example:

Further improvements
Multiple header levels
Further improvements could be adding additional header levels, similarly to how it works in the Notebook plugin:

# %% Header 2
# %%% Header 3
# %%%% Header 4

I'm unsure how running the current cell should work though, maybe it should only be limited to # %% and the rest is for syntax highlighting?
Alignment with the Notebook plugin
The Notebook plugin also uses # to indicate header levels instead of %. Not using the same standard is unintuitive and makes it more difficult to seamlessly jump between the editor and the Notebook.

# # Header 1
# ## Header 2
# ### Header 3
# ####Header 4

Versions

Spyder version: 4.0.0b2
Python version: 3.7.3

Thanks for reporting. About your suggestions:

Syntax coloring for cell comments should have a different text color/size scheme

I don't know about this. We already show an horizontal line on top of cells and change the background color inside a cell. I think that's enough.
@bcolsen, what do you think?

Further improvements could be adding additional header levels

That was already added and it'll be part of Spyder 4.

I see that the outline pane is much improved and recognizes the headers correctly, that's a great improvement! I do still think that the cell comments look too similar to ordinary comments in the editor. I'll show some examples:
Spyder 4:

Spyder 4 Notebook:

Spyder 3 comparison:

I do still think that the cell comments look too similar to ordinary comments in the editor

No one has said that those have changed, and I'm -1 on that, as I said above. Let's see what @bcolsen thinks about it.

The Notebook plugin also uses # to indicate header levels instead of %

And this definitely not going to change. For one, the notebook uses #, ##, etc to separate sections, not to separate cells. And #%% is a convention already used by several other editors as well (e.g. PyCharm and VSCode).

I think the outliner helps with navigating to different cells and alleviates some of the the problems with finding cells by scrolling through the script.
The lines to mark the top of the cells are easy to see in the scripts but it would be nice to more easily read the cell name especially with the new runcell function using cell names. I don't think it would hurt to give cell name the string color(a new color wouldn't be defined in all themes) and maybe make them bold.
I don't think that the code cell levels need to be differentiated. I can't think of a good way to do that anyways. Definitely not different sizes or colors.

I don't think it would hurt to give cell name the string color(a new color wouldn't be defined in all themes)

That would make things confusing for people that don't understand what cells mean, I'd say. So I'm -1 on this.

and maybe make them bold.

Sure, that would be good. Unfortunately, not all monospaced fonts support the bold weight. But I agree it would be an improvement.
I'm leaving this to the community because it's very low priority for us. @Illviljan, you're welcome to submit a PR to make cells font bold in case you want to see this as part of Spyder 4.


interpreters/lua: replace sourceVersion with lib.versions

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Mostly vim plugin rebuilds. We could keep targeting master. This would also reduce merge conflicts with the other PR I have open.


Wanted to add footer in the website

Please assign me to do it.

please assign this to me i understand the issue and add the tag [gssoc-ext] [hacktoberfest]

Please assign the issue to me!


Syntax highlighting support for various languages (tree-sitter grammars list)

Having looked through the majority of the issues, I would like to collectively address the state of the tree sitter language support currently in Lapce.
Here follows current support:

[ ] Agda
[ ] Angular
[ ] AutoIt
[X] Bash PR: #282 #690
[X] C PR: #274
[X] C++ PR: #276
[x] C# PR: #273, #1104
[ ] Carbon
[ ] Crystal
[x] CSS PR: #315
[x] D PR: #1335
[x] Dart PR: #1153
[x] Dockerfile PR: #1104
[x] Elixir PR: #317
[x] Elm PR: #625
[x] Fish PR: #1161
[ ] Fluent
[ ] Fortran
[x] Glimmer PR: #656
[X] Go bf79a35a5c427eb2d4bd2e079f75fd5911797f3f
[ ] Haml
[x] Haskell PR: #636
[x] Haxe PR: #656
[x] HCL (Terraform) PR: #656
[x] HTML PR: #428
[x] Java PRs: #266 #429
[X] Javascript bf2e4959fd10688fc24fbd1c7fb44ca5f80026ee
[X] JSON PR: #318, #280
[x] Julia PR: #762
[x] Kotlin PR: #1299
[x] LaTeX PR: #1161
[ ] Lean3
[ ] Lean4
[x] Lua PR: #1375
[x] Markdown PR: #320
[x] NIX PR: #798, #1104
[x] OCAML PR: #656
[ ] Pascal
[X] Php PR: #246
[x] Python bf2e4959fd10688fc24fbd1c7fb44ca5f80026ee
[x] QL PR: #636
[x] R PR: #1370
[ ] RenPy
[ ] Rhai
[x] Ruby PR: #430
[X] Rust
[ ] Scala
[x] Scheme PR: #1416
[x] SCSS PR: #656
[x] SQL | PR: #1472
[x] Svelte PR: #1161
[x] Swift PR: #636
[X] TOML
[X] Typescript bf2e4959fd10688fc24fbd1c7fb44ca5f80026ee
[ ] Vala
[ ] Verilog
[x] Vue PR: #1326
[x] WGSL PR: #807
[x] XML | PR: #1554
[X] Zig PR: #690

I would like to get a few more of these up and running, I'll see what others remain which are more low hanging fruit (Already on version 0.20 of tree-sitter and already expose the highlight query).
One other thing I would like to address is whether or not we wish to put a feature flag on these? Not sure how large all of these + build time impact this would have for lapce. Something to think about...
Cheers, I am really enjoying this editor!

Feature flags don't make much sense for a released binary, but I think they are a good idea for development!

Looking at how slowly a simple version change goes through in the upstream grammar repos, I wonder if we should temporarily use the forks instead. We aren't building to publish on crates.io so git dependencies should be just fine. We can track here which packages use the upstream versions and which ones use the forks. This would allow us to add support faster, as well as fix issues without being blocked on low traffic crates.

Haxe language related
https://github.com/vantreeseba/tree-sitter-haxe
https://github.com/ghishadow/lapce/commit/4b2f8f89b12d4c08ff6e8d364136774f797d5ec6
( https://github.com/vshaxe/haxe-language-server )

Can Glimmer (#539) and SCSS (#540)be added to the list so that these two issues can be closed?

Really minor thing I noticed when perusing this task roadmap, the PHP links to the C# repo instead of what I presume should be tree-sitter-php

As an Elm dev interested in Lapce I'd like us to add to the list
https://github.com/elm-tooling/tree-sitter-elm

As an Elm dev interested in Lapce I'd like us to add to the list elm-tooling/tree-sitter-elm

just added https://github.com/lapce/lapce/pull/625/files

The current swift grammar linked is abandoned. Update it with this one: https://github.com/alex-pinkus/tree-sitter-swift

I've just made prs to a lot of these. Here you are!
We're waiting on:
Verilog
Swift
SCSS
Scala
QL can be implemented right now! Is up to date and highlights exposed.
OCaml
HCL
Haxe
Haskell can be implemented right now! Is up to date and highlights exposed.
Glimmer
Fluent

@VixieTSQ for HCL updated repo is https://github.com/MichaHoffmann/tree-sitter-hcl

@ghishadow
list updated

@ghishadow ~list updated~ that one doesn't have it's bindings generated. I'll send a PR. But it also doesn't have a highlights file...

you can copy from https://github.com/nvim-treesitter/nvim-treesitter/tree/master/queries/hcl or https://github.com/helix-editor/helix/tree/master/runtime/queries/hcl I think with attribution.
Looks like HTML syntax highlighting is also not working as HIGHLIGHTS_QUERY is commented in  https://github.com/tree-sitter/tree-sitter-html/blob/master/bindings/rust/lib.rs#L38

https://github.com/lapce/lapce/pull/636 has been merged! go ahead and check those langs of, @Tiggilyboo

I've done that :)

Can I pick up the tasks for Julia and Scala?

you can pick Scala I think, @VarLad was working on Julia you can ask him about it (I tried but it was not syntax highlighting properly).
@bugadani you can check Elm lang off.

Okay, @ghishadow. Will pick up Scala

@deepto98 I'm busy these days
I intend to try Julia again, but it would be nice if you could take a look as well

@VarLad okay, sure

Can we add wgsl to the list? Seems like there is a tree-sitter grammar for it: https://github.com/szebniok/tree-sitter-wgsl

Hey all, would love to add Nix. There is also a tree-sitter grammar for it. Thanks for the hard work!  https://github.com/cstrahan/tree-sitter-nix

Julia

Added in https://github.com/lapce/lapce/pull/762

C#, Dockerfile, Nix added via #1104

Please add support for Svelte: https://github.com/Himujjal/tree-sitter-svelte

Added support for dart in #1153 (not merged yet) Please add dart to this list if possible!

What do you think about adding Kotlin to the list as well?
https://github.com/fwcd/tree-sitter-kotlin

For SQL there seem to be a bunch of options. This seems to be the most active:
Also can we add perl to the list?

Carbon?

Carbon?

There isn't a tree-sitter grammar for it (not surprising given the language exists publicly just few months)

Can we add Angular to the list?
https://github.com/steelsojka/tree-sitter-angular

I would like to ask for adding Fortran to the list, as well.
https://github.com/stadelmanma/tree-sitter-fortran

#1472 and #1554 brought support for SQL and XML, respectively.  At the time of this writing, this progress seems not to be mirrored in the checklist at the top of this issue, yet; neither the respective checkboxes are marked nor any Tree-Sitter is linked.  These are the URLs for the Tree-Sitters which were added by the mentioned Pull Requests:

SQL:  https://github.com/oknozor/tree-sitter-sql
XML:  https://github.com/RenjiSann/tree-sitter-xml

At the time of this writing, this progress seems not to be mirrored in the checklist at the top of this issue, yet; neither the respective checkboxes are marked nor any Tree-Sitter is linked.

It's informative, not definitive

Would like to have INI support: https://github.com/justinmk/tree-sitter-ini

There is a small issue with the python tree.
Some elements do not correspond to those set in the settings, for example, int is not highlighted in any way.
I don’t know how correct it is to compare with PyCharm, but I noted in the screenshot which places I would like to see with syntax highlighting.

I'm currently working on implementing astro - can this be added to the list?

error: failed to get tree-sitter-julia as a dependency of package lapce-core v0.2.5 (/home/builder/.cache/aurutils/sync/lapce-git/src/lapce/lapce-core)
Caused by:
failed to load source for dependency tree-sitter-julia
Caused by:
Unable to update https://github.com/varlad/tree-sitter-julia?branch=master#eff3e0f5
Caused by:
object not found - no match for id (eff3e0f57512ecb2e72024732d66dba64bdeaecf); class=Odb (9); code=NotFound (-3)

that's because @VarLad broke the repository with latest update #1862

@The-Repo-Club if you're building from source, I'd recommend that you build master (after the PR is merged)
It won't happen again :)

its ok github will build it again for my arch linux repo when its merged :) until then my repo can be on a stand still :)
thanks for the fast reply though :)

ColdFusion / Lucee support, anyone ?

Makefile syntax highlighting: https://github.com/alemuller/tree-sitter-make

Tree sitter Scala: https://github.com/tree-sitter/tree-sitter-scala

Tree sitter hoon: https://github.com/urbit-pilled/tree-sitter-hoon

Here is the Scala related PR https://github.com/lapce/lapce/pull/2280 not mentioned in the https://github.com/lapce/lapce/issues/272#issue-1181159046. It has been waiting for four months, so we'll need to resolve some minor conflicts and it's ready for another review probably then.

@panekj Thank you for the clarification.
Can you elaborate more what is "external grammar store" that blocks it? Which issue to track?
Is there a way to enable syntax highlighting locally, from within the editor, without adding it to lapce-core/Cargo.toml through a PR?

Can you elaborate more what is "external grammar store" that blocks it?

Place to get additional grammars from

Which issue to track?

There isn't any

Is there a way to enable syntax highlighting locally, from within the editor, without adding it to lapce-core/Cargo.toml through a PR?

No

AT&T asm?

I'm currently working on implementing astro - can this be added to the list?

Idem 👀

I'm currently working on implementing astro - can this be added to the list?

Idem 👀

https://github.com/lapce/lapce/pull/1874

Typst:
https://github.com/uben0/tree-sitter-typst
(or https://github.com/frozolotl/tree-sitter-typst )

tree sitter nim:
https://github.com/alaviss/tree-sitter-nim

I would love to have AutoIt or AHK (v2) syntax highlighting if possible. I might have to have a look at tree-sitter.

Assembler, NASM?

Question: both Dockerfile and bash are checked, but in the nightly build as of 2023-12-31, neither Dockerfiles nor .sh files are getting any hightlighting. Is there anything we need to do to get highlighting for such file types to work?
XML file highlighting also isn't working, at least not "out of the box".
C, C++ and yaml files do appear to have hightlighting "out of the box".

Highlighting changed due to dynamic grammar loading and some languages might be broken for now

Got it. Thanks for clarifying. Thanks for working on this. :+1:

Maybe reset the checkmarks then, to avoid confusion?

Highlighting for Markdown (.md) does currently work, at least in the most recent nightly build.

Highlighting for DOS/Windows batch (.bat) files currently does not work, at least in the most recent nightly build.

Highlighting for Ruby (.rb) files currently does not work, at least in the v0.3.1. ❌

Highlighting changed due to dynamic grammar loading and some languages might be broken for now

Does this mean that we are able to externally load grammars now? I had written a TSG for Unison and was going to file a PR and that same week, it was announced that Lapce would not incorporate any more TSGs until an "external store" was available (unsure what that means, like a central Lapce-hosted repository of TSGs?), and so I bailed on Lapce as an IDE because it officially could not support my language. I stepped away from Lapce since fall of 2023 and decided to check back in.

Does this mean that we are able to externally load grammars now?

Yes, but adding new languages is not possible without modifying Lapce and building it

Ada: https://github.com/briot/tree-sitter-ada


Socket-child can be left orphaned on parent crash

I'm submitting a ...
[*] bug report

Summary
I noticed today that I had a few socket-child processes running on my system with no node processes running that would be utilising an atem-connection.

I have tried to reproduce this and have managed to do so if the parent application crashes with an unhandled exception, but there could be other ways of achieving the same result.

I'm not sure how the memory usage got so high. I suspect that they have been running for a few days and have a huge number of commands to send to the parent buffered.

Tested in Ubuntu 18.04 and fixed in atem-connection 0.7.0
Please reopen if the issue occurs again!


Added an OpenGL book to the Finnish list

What does this PR do?
Add Resource(s)
For resources
Description
This is an in-progress OpenGL book from the Finnish version of Wikibooks.
Why is this valuable (or not)
OpenGL is widely used and there's not too much free material in Finnish. Even though the book is not finished, it already contains a lot of useful information about the basics and a bit of more advanced material too.
How do we know it's really free?
It's created and hosted on Wikibooks.
For book lists, is it a book?
Yes
Checklist:

[X] Not a duplicate
[X] Included author(s) if appropriate
[X] Lists are in alphabetical order
[X] Needed indications added (PDF, access notes, under construction)

Good addition. The linter wants an extra space - see the travis-ci output. While you're at it, consider translating "in process" to Finnish.

Oops, my bad. Fixed and also translated the "in process" text.


Namespace defaultMeta with either labels or tags.

I noticed when I was working with the ECS NodeJS loggers that Metadata fields weren't name spaced.
I can see one of three scenario's:

Make the default namespace be labels per [https://www.elastic.co/guide/en/ecs/current/ecs-base.html](Base Fields)
Make the default namespace be tags per [https://www.elastic.co/guide/en/ecs/current/ecs-base.html](Base Fields)
Allow for a customized namespace via a configuration parameter.

Here's an example configuration:
const logger = winston.createLogger({
   format: ecsFormat(),
   level: "debug",
   defaultMeta: {
      defaultMeta: {
         'environment': 'dev'
      }
   },
   transports: [
      new winston.transports.Console()
   ]
})

and a resulting output:
{
   "@timestamp": "2021-08-20T15:43:32.147Z",
   "log.level": "debug",
   "message": "Example with the default Meta Data fields.",
   "ecs": {
      "version": "1.6.0"
   },
   "environment": "dev"
}

Yes, agreed. Would you mind moving to https://github.com/elastic/ecs-logging-nodejs/issues/68 -- which I believe is the same general issue?

@trentm Moved my comment over there so feel free to close this.

Thanks.


GA availability date?

The page says "This feature is currently in Public Preview and will move to GA in March 2022.". Its now April 2022. Did it move to GA, or is the GA date pushed out?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 08217244-82bb-13b5-46f7-454801d8f865
Version Independent ID: 4a8b0a32-bf57-7544-c60d-6b7f250c4477
Content: Azure service tags overview
Content Source: articles/virtual-network/service-tags-overview.md
Service: virtual-network
GitHub Login: @allegradomel
Microsoft Alias: kumud

@bubbletroubles , thank you for your query. We'll review this and get back to you shortly!

@bubbletroubles , the doc has been updated now and below is the updated Note:

We are closing this issue for now. If there are further questions regarding this matter, please reply and we will gladly continue the discussion.

Fantastic and well done getting it to GA :)


Click event won't work with data-bs-toggle

I'm not sure if someone else is running into this same issue, but it seems like onclick/click event doesn't work when I have data-bs-toggle in a p tag for example.
This don't work:

Show alert

function showAlert(){
  alert("Alert");
}

But this works:

Show alert

function showAlert(){
  alert("Alert");
}

Is there any way to access the click event with javascript and keep data-bs-toggle="dropdown"?

Thanks for reporting the issue @tguimmaraess
But it is a duplicate of #30267

NVM, it may not be a duplicate actually but that's not the proper way of using data-bs-toggle="dropdown"

You closed my issue without providing any details...I'm using data-bs-toggle="dropdown" in the proper way it's just that click events don't work with data-bs-toggle

Thano you but that's just an example.  Dropdown is working but I need to add a click event too and it's not working.

@tguimmaraess I am also having the same issue, have you found any solutions ???