Application Gateway before Firewall Model - Errors

[Enter feedback here]
Application Gateway before Firewall Model needs revision to the VISIO diagrams and the steps are missing how the Https traffic from On-Prem to Azure triages and differentiate with Non-https traffic reaching same resource (E.g. VM with IIS (443)and RDP (3389)access.
errors.docx

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bb4e04dc-fc84-e958-89a8-e144ed5564b0
Version Independent ID: 795ef2fa-a126-8ded-d75d-3eb8811f4a23
Content: Firewall, App Gateway for virtual networks - Azure Example Scenarios
Content Source: docs/example-scenario/gateway/firewall-application-gateway.yml
Service: architecture-center
Sub-service: example-scenario
GitHub Login: @erjosito
Microsoft Alias: pnp

@shinojsn , thank you for your feedback. We'll review this and get back to you shortly!

@shinojsn , I believe you have tagged the wrong doc and the correct doc is as below:
https://docs.microsoft.com/en-us/azure/architecture/example-scenario/gateway/firewall-application-gateway#application-gateway-before-firewall
Hence, I have updated the issue with the correct doc link.

@erjosito , could you please review this feedback and provide your insights?

Hey @shinojsn , I already answered you per email, hopefully that clarified some of your questions regarding the IP addresses. About how non-HTTP traffic flows, I am hesitant to include additional diagrams, since non-HTTP(S) traffic is not the focus of this doc. Essentially, for non-HTTP(S) flows the Application Gateway is not in the data path, so it is the normal traffic flow as documented in the Azure Firewall documentation. If it is not clear, I could include some notes in each section explaining how non-HTTP(S) traffic works. Would that help?

Hello Jose
Thanks for your response, I appreciate if you could look into updating the
documents for the following, especially as you mentioned explaining more on
https and non-https traffic triaging

Document to highlight the where the traffic originates from ( For. Eg.
from On-Prem or from Azure VM)
The design is to address Securing https and non-https traffic with WAF
and Azure Firewall, It is quite vital to understand how both traffic
patterns triages.(E.g. Based on the feedback from Philip, All https traffic
from On-Prem, *Urls for Azure app services should be resolving to App
Gateway *and then the App gateway (Listeners + rules) redirects the traffic
to  azure firewall using UDR). That part was missing in the document.
It will avoid some confusion if the visio can be updated.

Appreciate your help to update the documents as we struggled to find it out
and hope no one may have the difficulty in future around the same concerns.
Once again thank you very much for looking into it and addressing the same
Thank you
Shinoj
On Fri, 24 Sept 2021 at 19:21, Jose Moreno @.***> wrote:

Hey @shinojsn https://github.com/shinojsn , I already answered you per
email, hopefully that clarified some of your questions regarding the IP
addresses. About how non-HTTP traffic flows, I am hesitant to include
additional diagrams, since non-HTTP(S) traffic is not the focus of this
doc. Essentially, for non-HTTP(S) flows the Application Gateway is not in
the data path, so it is the normal traffic flow as documented in the Azure
Firewall documentation. If it is not clear, I could include some notes in
each section explaining how non-HTTP(S) traffic works. Would that help?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/81512#issuecomment-926833699,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVYVU3D5HC45ONTAOWO2N73UDS6RXANCNFSM5EVSNLBQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

I have created PR https://github.com/MicrosoftDocs/architecture-center-pr/pull/3802 (not sure if you have access to it, since it is in the private repo). The challenge is that it is a lot of different flows (5 scenarios, 4 flows for each), and I don't want to distract the user with topics that are covered elsewhere. Hence I added a brief (but potentially confusing) paragraph in each of the 5 scenarios with some words about each flow. Does this help?

Good Morning Jose,
I am unable to access the private link
Thanks
Shinoj
On Wed, 29 Sept 2021 at 10:13, Jose Moreno @.***> wrote:

I have created PR MicrosoftDocs/architecture-center-pr#3802
https://github.com/MicrosoftDocs/architecture-center-pr/pull/3802 (not
sure if you have access to it, since it is in the private repo). The
challenge is that it is a lot of different flows (5 scenarios, 4 flows for
each), and I don't want to distract the user with topics that are covered
elsewhere. Hence I added a brief (but potentially confusing) paragraph in
each of the 5 scenarios with some words about each flow. Does this help?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/81512#issuecomment-929995317,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVYVU3DFIQT63EI6VJCY7A3UELKFDANCNFSM5EVSNLBQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

It has already been merged, so you can check the new paragraphs in the public link: https://docs.microsoft.com/azure/architecture/example-scenario/gateway/firewall-application-gateway. I tried to keep them short, so that the focus stays on inbound HTTPS flows. Still, do they clarify your questions better?

#please-close


Documentation does not work.

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 097456af-6293-8c24-3991-fc815b94dcbf
Version Independent ID: 978264ac-18f8-e937-30db-7050e53ac7d1
Content: Use ASP.NET Core SignalR with Blazor
Content Source: aspnetcore/tutorials/signalr-blazor.md
Product: aspnet-core
Technology: aspnetcore-tutorials
GitHub Login: @guardrex
Microsoft Alias: riande

System.InvalidOperationException: 'Unable to find the required services. Please add all the required services by calling 'IServiceCollection.AddSignalR' inside the call to 'ConfigureServices(...)' in the application startup code.'

Hello @RobertFinger ... I'm not seeing a problem here with 6.0. Are you saying that you're trying to use the tutorial for 5.0? If so, then you'll need to use the doc version selector to select the 5.0 version of the topic ...

As for the current (6.0) guidance, it looks good here ...

Edge ...

FF ...

If you're hitting a bug or strange behavior, open an issue for the product unit for investigation at ...
https://github.com/dotnet/aspnetcore/issues
Add the following to the bottom of your opening comment so that I can follow along. If we need to make updates to the doc, then I'll re-open this issue and work it from there.
cc: @guardrex https://github.com/dotnet/AspNetCore.Docs/issues/24717


Integrate repo-tools.

This is the initial integration of repo tools into this library. I released 2.0.0-beta.1 of the repo tools, and we can use its 2.0.0 branch to refine it as we discover more pieces of these repos that should be automated.
Currently repo-tools:

Generates the root README.md file
Generates the samples/README.md file
Generates the CODE_OF_CONDUCT.md file
Generates the LICENSE file.
Lints files using semistandard (samples file only for now)

Looks like I'll need to produce a Node4-compatible build of repo tools.


FUSETOOLS2-226 - provides Coverage report

Signed-off-by: Aurélien Pupier<EMAIL_ADDRESS>

when launched locally:


Channels class in Netty 3.

In Netty 3, there is a Channels class. What is the equivalent of Channels class in Netty 4?
Thanks.

@stickFigure1235 what exactly you are looking for ? This utility class is not needed in Netty anymore. That said please use stackoverflow or our google group for questions.


Implement match type amendment: extractors follow aliases and singletons

This implements the change proposed in
https://github.com/scala/improvement-proposals/pull/84.
The added pos test case presents motivating examples, the added neg test cases demonstrate that errors are correctly reported when cycles are present. The potential for cycle is no worse than with the existing extraction logic as demonstrated by the existing test in tests/neg/mt-deskolemize.scala.

I think it'd be useful to get this in 3.5.0-RC1 for testing purposes, we'd then revert it before the release if the sip committee votes against it.

I think it'd be useful to get this in 3.5.0-RC1 for testing purposes, we'd then revert it before the release if the sip committee votes against it.

We will not be merging this before SIP committee decision.
Since it won't land in 3.5.0-RC1, we will postpone this until 3.6.0.

I'd like to formally appeal that decision. As can be seen in https://github.com/scala/improvement-proposals/pull/84, there is support among the SIP committee members for not unnecessarily delaying this. Delaying makes sense if we believe that it will improve the quality of the final outcome, but we shouldn't stale things for purely procedural reasons. The procedures were put in place to achieve a certain result (build consensus, give enough time for experimentation, ...), so we should always ask ourselves if what we're doing is aligned with the result we want.

I've now moved the new logic under an experimental language feature so that it can be merged without SIP approval.


Clarify usage of react-otion as SSR only

Great idea, thank you! I was thinking about including a special JSX pragma, making room for a css prop. However, a Babel-based approach would be more efficient, but I haven't wrapped my head around AST transforms yet. So, the name react-otion just sticked along with a vague description of what it does.

@all-contributors please add @jaredpalmer for docs!


Console spammed to death with errors

What is the output link of /viaversion dump?
https://gist.github.com/anonymous/31e8319c4acf15796f374630b4490440
Are you using any additional software like BungeeCord? If so, what software and version?  Using an item?
All the time when people are online
Is there an error in the console? Use pastebin.com. Is there a kick message?
https://pastebin.com/2hBxyizq
No kick message
Logfile at the end of the day is 2 gigabytes big - disabled logging for now.

You're using a bad plugin that doesn't inject properly into packets. Best idea is to remove half your plugins, see if it's still there and retry. There's nothing we can do to fix this and it's down to another plugin badly handling packet exceptions which are canceled.


Page not found message updated

I previously had requested to pull this into master, but now I have changed it to frontend-dev!

@ishchhabra I tried to do that but couldn't figure out the steps. Can you help?


Advanced data download for datasets

To make data download compliant with eventual DCRF (in particular in RDB contexts), advanced data download features should be put in place, including:

[x] capacity to download the data in simplified format (in line with the one used for data upload). This supposes to implement the reverse business logic to transform data from CWP RH generic (normalized / long) format into simplified (denormalized / wide) format
[x] capacity to download the data with column names being the preferred alias (if any)
[x] capacity to download data enrich with codelist item labels (for columns controlled by codelists).

Fixed with https://github.com/fdiwg/dcf-shiny/commit/bd6e1b21de7ede0bc629cfa0e6b16fbb263d278c


[C++] Fix main page for Doxygen.

What is the purpose of the change
Doxygen doesn't have a \ul tag and therefore it's currently displayed as a plain text on a web page. This commit removes it.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation

Does this pull request introduce a new feature? no

We will need JIRA issues for the changelog:

go to https://selfserve.apache.org/jira-account.html and request a JIRA account
once you have an account you can create a new issue at https://issues.apache.org/jira/browse/AVRO
the PR title should start with AVRO-1234:  (the actual id) and the PR description should have a link to the JIRA issue
the commit messages should start with AVRO-1234: . No need to force-push - we squash the commits anyway.

This PR is trivial, so no issue is needed!

I've requested a jira login for the future anyways :) Will follow this for the next PRs.

Thank you, @mkmkme !


Implement VTree::left_linear, use in semantic hash benchmark

This PR:

implements VTree::left_linear and the associated predicate
writes a quick quickcheck! test to validate that the generator/predicate pair works properly
use it in the semantic hash experiment

benchmark thoughts
Left-linear is so slow! I can't run the benchmarks from #67 locally; I'll run some on the server in a moment.
Interestingly, consider
$ cnfgen randkcnf 3 6 20 > cnf/rand.cnf && cargo run --bin semantic_hash_experiment --release -- 2> err.txt --file cnf/rand.cnf
num vars: 6
c: 00003 nodes | 000422 uniq | 0020791 rec | 1409 g/i | 2380/3081 compr/and
s: 00032 nodes | 000566 uniq | 0035425 rec | 1381 g/i
c time: 2.97275ms
s time: 200.627042ms
h: 156400995

versus
$ cnfgen randkcnf 3 7 20 > cnf/rand.cnf && cargo run --bin semantic_hash_experiment --release -- 2> err.txt --file cnf/rand.cnf
num vars: 7
c: 00003 nodes | 000953 uniq | 0063249 rec | 4436 g/i | 6820/9417 compr/and
s: 00064 nodes | 001105 uniq | 0304646 rec | 3540 g/i
c time: 4.436125ms
s time: 18.737464459s
h: 242354000

Increasing the number of variables by 1 and fixing everything else increased the order of magnitude! In addition, we don't get the reduction in recursive calls we saw elsewhere; but, we do have less gets/inserts into the apply cache.

Result from running on server:
num vars: 8

c: 00004 nodes | 007773 uniq | 0749221 rec | 51620 g/i | 68617/116103 compr/and
s: 00128 nodes | 002810 uniq | 3234863 rec | 12073 g/i

c time: 60.85103ms
s time:<PHONE_NUMBER>08s

h: 439246229


Code block is not working in ubuntu 16.04

Even if I select from the menu or click the short-cut key the code block is not appearing. Version
0.11, even the previous version this error was there.
Thanks

And it does not work on MAC OS either.

It looks like an issue on Evernote side, the code-block option disappears from their editor when running it on Chrome. Visit their issue tracker for more info.

Yes, it's been an issue at least since March this year (https://discussion.evernote.com/topic/112445-how-do-i-add-code-blocks/), and Evernote team don't seem to give it any kind of priority.


Help

ADD ISSUE DESCRIPTION HERE
Version: 1.96.2
Commit: fabdb6a30b49f79a7aba0f2ad9df9b399473380f
User Agent: Mozilla/5.0 (Linux; Android 10; K) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Mobile Safari/537.36
Embedder: github.dev
Extension version: 5.16.0

Please write what you wanted.

I'm closing this as a probable spam. Please if you still need help with somenthing, create a new issue detailing your problem.


Add a Report a problem page

The Report a problem page replaces the current mailto hyperlink with a web form which users can use to report technical issues about the service.
It also replaces the hidden and unused Feedback page.

@leoapost just going to add tests, please keep this branch open for now. Thanks

I've removed the submit feedback test as I need time to work out why it's failing. Work on this test will be done on a separate branch. I will manually test this journey.


Function name "main" not used in single file examples

From John Blau
On http://godoc.org/code.google.com/p/go.net/websocket#example-Handler there is an error.
func ExampleHandler(){  should be func main(){

If you click the ‘play’ link, the version that loads is correct.
The standard godoc tool does the same thing.

func main, not func Main, right?

yes, main

@garyburd can you give a look if this is an acceptable way to fix this, and if I missed something? It seems to work well where I tested it, but maybe I missed some corner cases.

Fixed by 9f70e16d88bc3af0685c69788dca18545c909622


Only import CHANGES from an RWexport file.

Try to figure out how to only import changes from an RWoutput file.

User could provide BOTH old and new files, and the module compares each individual element looking for changes, and the updates those parts.
However, a change in a snippet in a journal entry will be complicated to replace, since it would have to be determined where the old snippet was in the journal entry (and that could be further affected by manual edits on a journal entry).

Version 1.0.0 switched to using the RWexport file.
This means that the UUID is available for us to store in Foundry so that we can match topics to journal entries, and portfolio/statblock snippets to actors.
There is still no information in the RWexport file to indicate WHEN a snippet was changed; so we need some other way to know if a JE/actor was changed in Foundry.

Only one processing option is required:

overwrite previously imported entries: yes/no (yes = use RWexport version; no = use world version)

If the user only wants to import new entries, then they can set the above flag to false.


baptiste preview does not work on geting individual repo or list of repos

What article on docs.github.com is affected?

https://docs.github.com/en/rest/reference/repos
What part(s) of the article would you like to see updated?

currently the document lists examples of template_repository in the response objects of the following endpoints:

GET /repos/{owner}/{repo}
GET /users/{username}/repos
GET /orgs/{org}/repos

and hints at needing the application/vnd.github.baptiste-preview+json Accept header for enabling these properties.
However, this doesn't work, none of the endpoints return template_repository values for repositories that should.
Additional information

http https://api.github.com/orgs/{org}/repos?per_page=100 "Authorization: token $GH_TOKEN" "Accept: application/vnd.github.baptiste-preview+json" | jq .[].template_repository

@ahmadnassri Thanks so much for opening an issue! I'll triage this for the team to take a look 👀

Thanks @ahmadnassri I've checked in with folks and it sounds like this is a question better suited to our support team!


Update npm packages

I think it's fine since npm update shouldn't pick up any major updates that would be breaking.  That being said, this is why we're doing it post-release in case it does break the extension somehow.
But I'll wait for Eric to say something too 😏

Yeah what Nathan said. I wouldn't do this kind of change right before a release, but otherwise it doesn't worry me too much


Add support to point to SQL sources

Adding some basic support for the major SQL engines would be nice:

Postgres
MySQL
Snowflake
Bigquery
Redshift

@jcorrado76 Sure, I wonder can Polars directly read those rdbms with some minimal config? I'm using polars to do all the heavy lifting so far.

For whoever winds up taking this on:
https://pola-rs.github.io/polars/py-polars/html/reference/api/polars.read_database.html

@danielbeach - Can I pick this up ?

@lordirah all yours!


User should not be added twice to the same plant as caretaker

A user should not be added to a plant as a caretaker multiple times. If user is added to a space in which there is a plant of which he/she is already caretaker of, then he/she should not be added again as a caretaker.
Please implement a check which makes sure that a user will not be added twice to the same plant as a caretaker.

I will do this today

I just went over it and the code already has such a check when calling addPlantToSpace(). I also just added a test to ensure this works.
When did you encounter this bug? Because on my side it seems to work as expected

I just saw that sometimes a plant has the same user more then once in its caretakers list. I think the check you implemented should now prevent this. (It could be that these users were added already before any checks were implemented)


Performance improvements

[ ] inline method cache
[ ] inline constant cache
[ ] String interning (two level cache table)

Just to add a memo for performance:
a = 0
100000.times do |x|
  a = a + x
end
puts(a)

Brief benchmark:
$ time goby tmp.gb
4999950000

real	0m0.326s
user	0m0.364s
sys	0m0.019s

$ time ruby tmp.gb
4999950000

real	0m0.155s
user	0m0.068s
sys	0m0.023s

I know that it is a little bit too early to tune-up Goby in current stage. Note that Ruby has long been tuned while Goby is younger, so I guess there's a plenty of rooms to tune-up in Goby.


[5.0.0-rc4] [.NET CORE 3.0] Swagger does not add Authorization header to request

Hello,
I made a new Web API. I got Swagger and IdentityServer4.AccessTokenValidation set up and running, but Swagger does not seem to add an Authorization header to my request.
Startup.cs -> ConfigureServices method
public void ConfigureServices(IServiceCollection services)
		{
			services.AddControllers(c => {
				var policy = ScopePolicy.Create("openid", "api");
				c.Filters.Add(new AuthorizeFilter(policy));
			});

			services
				.AddAuthentication(IdentityServerAuthenticationDefaults.AuthenticationScheme)
				.AddIdentityServerAuthentication(options => {
					options.Authority = Configuration["Identity:Identity"];
					options.ApiName = Configuration["Identity:IdentityScope"];
					options.ApiSecret = Configuration["Identity:IdentityScopeSecret"];
					options.SupportedTokens = SupportedTokens.Both;
					options.LegacyAudienceValidation = true;
				});

			services.AddSwaggerGen(c => {
				c.SwaggerDoc("v1", new OpenApiInfo { Title = "Printer API", Version = "v1" });
				c.OperationFilter<SwaggerAuthorizationOperationFilter>();
			});

			RegisterDbContexts(services);
			RegisterServices(services);
		}

Startup.cs -> Configure method
public void Configure(IApplicationBuilder app, IWebHostEnvironment env)
		{
			if (env.IsDevelopment()) {
				app.UseDeveloperExceptionPage();
			}

			app.UseHttpsRedirection();
			app.UseRouting();
			app.UseAuthentication();
			app.UseAuthorization();

			var swaggerEndpoint = "/swagger/v1/swagger.json";
			if (Environment.IsStaging()) {
				swaggerEndpoint = "/int/printerapi/swagger/v1/swagger.json";
			}
			if (Environment.IsProduction()) {
				swaggerEndpoint = "/int/printerapi/swagger/v1/swagger.json";
			}

			app.UseSwagger();
			app.UseSwaggerUI(c => {
				c.DocumentTitle = "Printer API";
				c.SwaggerEndpoint(swaggerEndpoint, "Printer API V1");
				c.RoutePrefix = string.Empty;
			});

			app.UseEndpoints(endpoints => {
				endpoints.MapControllers();
			});
		}

SwaggerAuthorizationOperationFilter.cs
public class SwaggerAuthorizationOperationFilter : IOperationFilter
	{
		public void Apply(OpenApiOperation operation, OperationFilterContext context)
		{
			var filterDescriptors = context.ApiDescription.ActionDescriptor.FilterDescriptors;
			var isAuthorized = filterDescriptors.Select(filterInfo => filterInfo.Filter).Any(filter => filter is AuthorizeFilter);
			var allowAnonymous = filterDescriptors.Select(filterInfo => filterInfo.Filter).Any(filter => filter is IAllowAnonymousFilter);

			if (isAuthorized && !allowAnonymous) {
				if (operation.Parameters == null) {
					operation.Parameters = new List<OpenApiParameter>();
				}

				operation.Parameters.Add(new OpenApiParameter {
					Name = "Authorization",
					In = ParameterLocation.Header,
					Description = "access token",
					Required = true,
					Schema = new OpenApiSchema {
						Type = "string",
						Default = new OpenApiString("Bearer {access token}"),
					}
				});
			}
		}
	}

I attached a screenshot of Swagger after I press Execute.
What am I doing wrong?

Thank you.

As per the readme, you need to a) define the security scheme in use (i.e. via AddSwaggerGen(c => c.AddSecurityDefinition(... AND b) specify which operations the scheme applies to (i.e. via AddSwaggerGen(c => c.AddSecurityRequirement(… for all operations or with an operation filter for per-operation requirements). From you configuration, it looks like you've done the latter but not the former.

Dup of #1277

A REMINDER for anyone following this issue or the referenced duplicate …
This is NOT an issue with Swashbuckle! It's a limitation (seemingly by design) of the swagger-ui:

The Authorization header parameter defined in /auth/credentials and /system/info won't be used because OpenAPI Specification says that tools should ignore explicit header parameters named Authorization. The Authorization header should be defined as a security scheme instead.

@domaindrivendev, Swagger UI is simply following the explicit instructions of OpenAPI 3.0:

If in is "header" and the name field is "Accept", "Content-Type" or "Authorization", the parameter definition SHALL be ignored.
ref

Authorization header parameters are quite simply illegal in OpenAPI 3.0, so no tool should be supporting or generating them.

In HTTP Context string requestUrl = string access_token = httpContext.Request?.Headers["Authorization"].ToString(); any other solution ? to get authorization field

Simple solution for people who just have a bearer token and not a full oauth2 flow.
Change your OperationFilter so that the OpenApiParameter Header name you are adding is "X-Authorization" instead of  "Authorization".
Then add this to your Startup.cs:
public void Configure(IApplicationBuilder app, IWebHostEnvironment env, ApplicationDbContext context, TBSCDbContext tbscContext)
{
   app.Use((httpContext, next) => // For the oauth2-less!
   {
      if (httpContext.Request.Headers["X-Authorization"].Any())
      httpContext.Request.Headers.Add("Authorization", httpContext.Request.Headers["X-Authorization"]);

      return next();
   });
//..
}

I Integrate swagger with firebase and automatically password flow authentication
https://stackoverflow.com/questions/61540706/configure-swagger-authentication-with-firebase-google-in-net-core/61540707#61540707


DSN validation fails if password contains '=' sign

If password contains = sign, dsn validation fails. Postgres exporter should accept all special chars in password files, including = sign. I was using release v0.5.1 but this bug is already in v0.5.0.
Reason is that dsn is firstly splitted by spaces and then each items are splitted by = sign. DSN is malformed if split result len is different than 2.
func parseFingerprint(url string) (string, error) {
	dsn, err := pq.ParseURL(url)
	if err != nil {
		dsn = url
	}

	pairs := strings.Split(dsn, " ")
	kv := make(map[string]string, len(pairs))
	for _, pair := range pairs {
		splitted := strings.Split(pair, "=")
		if len(splitted) != 2 {
			return "", fmt.Errorf("malformed dsn %q", dsn)
		}
		kv[splitted[0]] = splitted[1]
	}
...

When I changed url in GOPATH/src/github.com/wrouesnel/postgres_exporter/cmd/postgres_exporter/postgres_exporter_test.go to "postgresql://userDsn:password=Dsn@localhost:55432/?sslmode=disabled" the tests started to fail.
¨ERRO[0000] Wrong constant labels format " xyz", should be "key=value"  source="postgres_exporter.go:950"

----------------------------------------------------------------------
FAIL: postgres_exporter_test.go:186: FunctionalSuite.TestParseFingerprint

postgres_exporter_test.go:213:
    c.Assert(err, IsNil)
... value *errors.errorString = &errors.errorString{s:"malformed dsn \"host=localhost password=password=Dsn port=55432 sslmode=disabled user=userDsn\""} ("malformed dsn \"host=localhost password=password=Dsn port=55432 sslmode=disabled user=userDsn\"")

OOPS: 9 passed, 1 FAILED
--- FAIL: Test (0.00s)
FAIL
exit status 1
FAIL	github.com/wrouesnel/postgres_exporter/cmd/postgres_exporter	0.014s

With original test file
go test
ERRO[0000] Wrong constant labels format " xyz", should be "key=value"  source="postgres_exporter.go:950"
OK: 10 passed
PASS
ok  	github.com/wrouesnel/postgres_exporter/cmd/postgres_exporter	0.014s

Hopefully fixed by #318 which was just merged to master.

Thanks @wrouesnel for merging my PR.
I've verified that now it's working for my case. Hopefully it'll works also in yours.
$ DATA_SOURCE_NAME='postgresql://USERNAME:PASSWORD-WITH-EQUAL-SIGN@localhost:5432/postgres?sslmode=disable' ./postgres_exporter
INFO[0000] Established new database connection to "localhost:5432".  source="postgres_exporter.go:814"
INFO[0000] Semantic Version Changed on "localhost:5432": 0.0.0 -> 10.10.0  source="postgres_exporter.go:1335"
INFO[0000] Starting Server: :9187                        source="postgres_exporter.go:1576"

Verified with 0.7.0. Thanks for fixing this.


Styling of header

In the header section i would like to add more animation on the iron man symbol because it seems little unresponsive

please assign me with the task @aslams2020


For Discussion: Reimplement Marker-InfoWindow mechanism.

Currently the marker infowindow interaction Looks like this:

The MapView contain Marker-s
A Marker contain a (Marker)InfoWindow
Markers contain data (Title, Description, Bitmap) that should be displayed in the infowindow
Each InfoWindow is added to the MapView, even if it currently not visible/closed.
The InfoWindow Needs to know the MapView to work.

I see these problems with the current design:

When the android activity is recreated (i.e. because of orientation Change) Markers with data and infowindows must be recreated, too.
Special care must be taken to avoid Memory leaks because of the circular reference between MapView-Marker-InfoWindow.  If a Marker or InfoWindow is not proper deleted a reference to MapView is kept which prevents the owning Activity from beeing deleted.

Points of improvements:

Marker should have a factory-method to create an InfoWindow on demand instead of containing a precreated InfoWindow . The object "InfoWindow" should only exist as long as the popup-bubble is opend.
Refactor Marker into

MarkerData (Title, Description, Bitmap implemented in OverlayWithIW) plus
MarkerOverlay (the visual part with click-hanlding).

Opening the the InfoWindow should only depend on MarkerData  and not on Marker(Overlay) itself.

love the diagrams by the way. @MKergall was the author of the majority of these features and I'd be interested in what he has to say.

I also love the diagrams.
"When the android activity is recreated (i.e. because of orientation Change) Markers with data and infowindows must be recreated, too."
=> This is also the case for all overlay classes, for views, etc. When Android activity is recreated, all view elements have to be recreated.
"Memory leaks" => is the InfoWindow.onDetach not sufficient to avoid them?
"Marker should have a factory-method to create an InfoWindow on demand instead of containing a precreated InfoWindow . The object "InfoWindow" should only exist as long as the popup-bubble is opend."
=> Why not.
"Refactor Marker into:
MarkerData (Title, Description, Bitmap implemented in OverlayWithIW) plus
MarkerOverlay (the visual part with click-hanlding)"
=> Why not, as long as it's only internal. Users should not have to manipulate both classes, just Marker one. For both Google Maps compatibility, and simplicity.

May be relevant to #1828


Provide Perspective Versus CSS Layouts

I must confess to finding it difficult to fully grasp the 3 or 4 dimensional chess this description forces me to grasp, given all the default and override rules it expresses.  I would welcome some perspective on the pros and cons of this layout scheme versus using CSS layouts.

Hello @CincySteve ... Please re-open the issue from the bottom of the topic that you're looking at with the This page feedback form. It will attach metadata and ping the author of the topic.


Fix the github pages link in project description

Current: https://fcomb.github.io/redux-logger/ -> 404
Should be: https://theaqua.github.io/redux-logger/

Also the travis icon and link in README.md is incorrect: https://travis-ci.org/fcomb/redux-logger

Thanks!


Adds new placeholders

this is the full list of dibi supported placeholders.

Thank you.
Please add tests for at least a few of the newly added placeholders.
Also please a new test for the logic which now uses rewriting but didn't before

looks good thanks.
in case the state we have reached is already "good enough" for you to consume as a phpstan-dba stable release, please give me a hint and I will tag a release.
otherwise we will keep iterating on it with new PRs, which is fine too

before tagging a new version, i'd like to finish the return type extension to return either array or Row (including magic access).
Then I can ask the Czech community on our slack to start testing it (its quite heavily used here)


Update issue template with proper plunker

work with ng admin > 1.0.0-alpha7
Fix  https://github.com/marmelab/ng-admin/issues/1220

Awesome, thanks!


[SPARK-22287][MESOS] SPARK_DAEMON_MEMORY not honored by MesosClusterD…

…ispatcher
What changes were proposed in this pull request?
Allow JVM max heap size to be controlled for MesosClusterDispatcher via SPARK_DAEMON_MEMORY environment variable.
How was this patch tested?
Tested on local Mesos cluster

Can one of the admins verify this patch?

Hello @pmackles, thanks for this. It would be set to the value of SPARK_DRIVER_MEMORY by default correct? What to you think about introducing a new envvar (SPARK_DISPATCHER_MEMORY) so that it can be individually configured? Only motivated by the fact that the Dispatcher is a pretty unique beast compared to the other Spark daemons.

Hi @ArtRand - Based on my testing and interpretation of the code, SPARK_DRIVER_MEMORY has no affect on MesosClusterDispatcher. Heap size always winds up being set to -Xmx1G (the default).
I went with SPARK_DAEMON_MEMORY because that's what is used for the Master/Worker in a standalone cluster and I think Dispatcher is pretty similar in nature to those daemons. That said, I don't have a strong opinion and SPARK_DISPATCHER_MEMORY works fine for my use case so I am happy to switch it in the name of getting this PR accepted.

@ArtRand - WDYT? I was going to switch it to SPARK_DISPATCHER_MEMORY but then I noticed that the other env vars for MesosClusterDispatcher or also prefixed with SPARK_DAEMON_* so I thought it might be better to keep the names consistent.

Yeah that sounds good. Thanks for this!

LGTM

@ArtRand - yeah default would remain the same which is 1g

LGTM

@felixcheung - any chance of getting this tiny change merged and included in the upcoming 2.2.1 release?

Jenkins, test this please

@susanxhuynh or anyone from the mesos side would you please review?

@pmackles perhaps you could email this to<EMAIL_ADDRESS>to get some visibility to this and hopefully someone else on the mesos side can review?

Test build #83648 has started for PR 19515 at commit 33a8e68.

Test build #83648 has finished for PR 19515 at commit 33a8e68.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83648/
Test PASSed.

LGTM, merging to master / 2.2.


API Libraries > Sidecar REST API

This page aims to add the Sidecar REST API

@themacexpert can you please do a formatting review on this one?

@themacexpert I think that, with your approval, this PR would be good to merge :) 🚀


Simple wrapper class on apache http library to GET multiple URLs in parallel

Created a simple utility to read multiple HTTP URLs in parallel using
apache http client library. The utility returns responses as they arrive.
Testing: UT + manual

LGTM
I will merge once travis clears it

[Current coverage][cc-pull] is 49.87%

Merging [#142][cc-pull] into [master][cc-base-branch] will increase coverage by <.01%

@@             master       #142   diff @@
==========================================
  Files           699        701     +2
  Lines         38295      38319    +24
  Methods           0          0
  Messages          0          0
  Branches       6163       6165     +2
==========================================
+ Hits          19094      19108    +14
- Misses        19181      19191    +10
  Partials         20         20

Powered by Codecov. Last updated by [94beba5...374d919][cc-compare]
[cc-base-branch]: https://codecov.io/gh/linkedin/pinot/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/linkedin/pinot/compare/94beba5f4dbe78d1ee87201ab4c575d56602c729...374d9199984b3c6802989aedfe2c7369f6a07ba4
[cc-pull]: https://codecov.io/gh/linkedin/pinot/pull/142?src=pr


Checkpoint 3 ready for review

@pawaitemadisoncollege Checkpoint 3 is ready for review! :)

Indie Project link: http://specific-pet.us-east-2.elasticbeanstalk.com/

Hi @eferr216 - I was able to sign up, log in and crud data on your site.   I wasn't able to search for any pets on the home page. Can you either record a video showing this working or let me know a few values that I can search for to see results.
To demonstrate a met level for checkpoint 3:

[ ] Add your deployed app link to the student repo project list: https://github.com/mad-ent-java-f24/student/blob/main/IndividualProjects.md

[ ] Update your time log and project plan

I took a bit of time to review your application for the items I'd look for in a final project.  Here is what needs improvement:

Unit tests do not thoroughly test the relationships between the three tables. Unit tests should be added to test the delete between all the tables. Example: if a user has one or more pets, and those pets are deleted, what happens to the user? If a user is deleted, what happens to their pets. Same thing with pets and additional details.

When a user signs up, they should be added to the database. Is this happening? I didn't see any indication of it on the site - showing their user name and their pet requests seems to make sense..

SearchPets is doing a lot of work and has some duplicate code - refactor so that the duplication is removed and so the class itself is easier to maintain.

There is a lot of duplicate code across your pages. Eliminate this duplication by creating reusable jsps and including them in the main pages.

Hello, I've completed all of the points above so far other than #3. Will be doing that in a few hours when I get back home. At the moment you can search for any of the inserted Pet values such as these that are currently in the database:

@eferr216 - let me know when that last change is pushed and I'll review for CP 3 and as the final version of your project.

Hello I finished making those changes! :)

Hi @eferr216 - this looks good for meeting checkpoint 3.
For your final version, here are the changes needed:

[ ] Appears to be some duplicate code on viewRequests and viewResults jsps.

[ ] The delete tests for the relationships do not make sense to me -  the unit tests should attempt to retrieve the relationship records AFTER the delete and then confirm that they either are or are not there depending on the expected behavior.  In the current tests, the records are retrieved before the delete and then the test checks that those records aren’t there.  I’m unsure that this works as expected – how many records were there in the first place? Here https://github.com/eferr216/specificPet/blob/531476c329ba5de12fb53bd8f17995f0dbdec9e9/src/test/java/edu/matc/persistence/PetDaoTest.java#L87, check that the expected number of records are in the set, keeping the ids so you can retrieve them. Then, delete the pet, and then try to get the additional detail records by id. This will truly verify the records are deleted. Do this for each of your relationships - take screenshots showing all unit tests run and pass in a single execution.

[ ] It doesn’t seem like any of these daos are used in this class. Create them where you actually need them rather than passing them around like this: https://github.com/eferr216/specificPet/blob/531476c329ba5de12fb53bd8f17995f0dbdec9e9/src/main/java/edu/matc/controller/SearchPets.java#L26-L28.

Changes that should be considered in the near future:

[ ] It would be better to put the entire user in the session here, https://github.com/eferr216/specificPet/blob/531476c329ba5de12fb53bd8f17995f0dbdec9e9/src/main/java/edu/matc/controller/Auth.java#L295, so that you have access to the user and all of their requests without making a round trip to the database like this: https://github.com/eferr216/specificPet/blob/531476c329ba5de12fb53bd8f17995f0dbdec9e9/src/main/java/edu/matc/controller/SearchPetsHelper.java#L31-L32

[ ] Usability – entering a search for max weight doesn’t appear to return pets under that max weight. Seems to be an exact match. I was assuming “max” meant the search would return any pets under that weight, but this isn’t the behavior I observed. If that is incorrect, please let me know – a video showing this working would be helpful.

[ ] Dropdown for color would be better than allowing the user to enter any value. This would help avoid bad. It woud be nice not to be required to select a color.

[ ] Pet type is not required - seems like it should be?

[ ] Pet images file names/locations would be better stored in the database rather than hard-coded on the jsp.

I think I may have it done now. Hopefully!

Good job with the revisions here @eferr216.  You've achieved a met level with your project - congratulations! I'll update blackboard and your final grade in the system. :)

OMG this might be the best moment of my life thank you!! This was literally the last course I needed to get my degree I appreciate it so much!!!


add rowClass option

I am using a namespaced bootstrap library. The bootstrap class for a row is row, mine is rs-row. I can set that in the source, but having a configurable option to match the column class one would be nice.

alright, this will be added to default options


Added reverting Zulrah uniques into 20k scales like in-game

Description:
In game, you can break down Zulrah uniques (Serp. visage, Tanz & Magic fang) into 20k zulrah scales. This has been added to the bot using the revert command. IE: +revert Tanzanite fang gives 20k Zulrah scales. This process CANNOT be reversed.
This will be especially helpful to players who are preparing for the Inferno or herblore training, as they can now have more sources of Scales.
I didn't know where to put the items though, so I tossed them under Graceful set reversion because that section has miscellaneous items.
Changes:

Added Serpentine visage, Tanz. Fang and Magic fang to revertables, allowing them to breakdown into 20k scales

Other checks:

[ ] I have tested all my changes thoroughly.

made a lot of mistakes lol

bump

cleaning up my PRs


[#566] [#687] HTTP REST API

Solves #566 and #687.

All API calls go through a single handler now.
New GET /rest/ call as an interface to get_rows database queries.
New POST /rest/ call as an interface to compose_transaction calls.
JSON-RPC doesn't listen on / anymore (that access route not documented anyway).
RPC_PASSWORD config setting is no longer mandatory.
Adds xmltodict requirement.

The API is documented here for now:
http://docs.counterpartylib.apiary.io/#

Coverage remained the same at 68.0% when pulling db5b76747564515b74cb142fade9d285a8a7fa68 on Millz0r:develop into fb390982afd15f2091ee2123e277d4a166e62852 on CounterpartyXCP:develop.

Minor point: the ChangeLog should note that authentication for the JSON-RPC API is disabled by default and the password parameter is no longer required.
The syntax for multiple parameters looks strange to me, but maybe it's the standard way to do it? E.g. sends/source/mn6q3dS2EnDUx3bmyWc6D4szJNVGtaR7zc/destination/mtQheFaSfWELRB2MyMBaiWjdDm6ux9Ezns/AND In that case, could source and mn6q3dS2EnDUx3bmyWc6D4szJNVGtaR7zc be separated by something other than a /? Could source/mn6q3dS2EnDUx3bmyWc6D4szJNVGtaR7zc and destination/mtQheFaSfWELRB2MyMBaiWjdDm6ux9Ezns be separated by a third character as well?
Can we redirect /rpc/ to /api/, so the docs can just list /rpc/ and /rest/?
Otherwise, on a first read-through, it looks pretty good to me!

Some nitpicking:

REST url should contains resource names and ID's, and the last part can eventually be an "action". The action parameters should be in the query string. If you consider an address as a resource, we can have something like:
/rest/source/mn6q3dS2EnDUx3bmyWc6D4szJNVGtaR7zc/compose?destination=mtQheFaSfWELRB2MyMBaiWjdDm6ux9Ezns&quantity=3&asset=XCP
To be really REST, this query, to compose a transaction, should be used with GET method (POST is used when there is something written in the database). BUT in our case I think we should ALSO accept POST for privacy (POST query string can be crypted with SSL).

handle_rest_get and handle_rest_post are very similar! Do you think it's possible to DRY a little bit this 2 functions ?

Coverage remained the same at 68.0% when pulling b32ea739ef12c6b4a557987bc1376c49450046cf on Millz0r:develop into fb390982afd15f2091ee2123e277d4a166e62852 on CounterpartyXCP:develop.

I just added more ChangeLog changes.
Redirection to /rpc/ will be easy, I'll add that today.
Considering URL building, the more RESTful way would be to keep most data as params, however I thought it would be more readable current way. I agree it's better to stick with the standard and use params as not to surprise users at any time.
They are indeed very similar, I'll see if I could consolidate it into one function, espcially if we are gonna support GET on both queries.

@ouziel-slama:

What about table-wide selects for get_rows (with no additional arguments)? For instance /rest/balances/get, which would return SELECT * FROM balances? The resource name would then be either table name or transaction type, and all other arguments would be passed as action parameters.

@Millz0r :
Yes, GET /rest/balances should return the first 1000 (the default/max limit is 1000) rows in balances table.
Also the filterop should be in the query string, not in the url: /rest/sends/source/mn6q3dS2EnDUx3bmyWc6D4szJNVGtaR7zc/destination/mtQheFaSfWELRB2MyMBaiWjdDm6ux9Ezns?op=AND
In general, only things that can be considered as resource or as resource ID should be part of the URL.

@ouziel-slama, shouldn't that then be /rest/sends?source=mn6q3dS2EnDUx3bmyWc6D4szJNVGtaR7zc&destination=mtQheFaSfWELRB2MyMBaiWjdDm6ux9Ezns&op=AND
@Millz0r, I think that's more readable anyway.

@adamkrellenstein: :-) yeah you right, if we want to be really REST the only resource we have here is the sends table.. so the cleanest way is:
sends/{tx_index or tx_hash} to get one row, and sends?source=..&dest=.. to get rows.
... but it's very usual to see REST APIs that passes search parameters in the URL.. I'am not against the two formats of the url.. is up to you and @Millz0r ..

I strongly prefer keeping the parameters out of the URL.

Coverage remained the same at 68.34% when pulling cdcd2b318e85e46dab3269d3c57002f42e5b3da0 on Millz0r:develop into fb390982afd15f2091ee2123e277d4a166e62852 on CounterpartyXCP:develop.

Changes above, here are some example URLs that work now:
curl -X GET "localhost:14000/rest/send/compose?source=mn6q3dS2EnDUx3bmyWc6D4szJNVGtaR7zc&destination=mtQheFaSfWELRB2MyMBaiWjdDm6ux9Ezns&asset=BTC&quantity=100000"

"01000000025c5ea576702be46253a239bd1aa6b2dbed1f5ace830bbaa9939e80209c76eee4000000001976a9144838d8b3588c4c7ba7c1d06f866e9b3739c6303788acffffffff4986e0b01495bcd00dcf9e5d112c386f5bf0d5d8d926b9811e3ac9d31657f902000000006951210282b886c087eb37dc8182f14ba6cc3e9485ed618b95804d44aecc17c300b585b0210378ee11c3fb97054877a809ce083db292b16d971bcdc6aa4c8f92087133729d8b21037af2e06061b54cdfe3657bbc8496d69000b822e2db0c86ccbe376346a700b83353aeffffffff02a0860100000000001976a9148d6ae8a3b381663118b4e1eff4cfc7d0954dd6ec88ac850ae011000000001976a9144838d8b3588c4c7ba7c1d06f866e9b3739c6303788ac00000000"

curl -X GET "localhost:14000/rest/balances/get?address=mn6q3dS2EnDUx3bmyWc6D4szJNVGtaR7zc&quantity=10000&op=OR"`

[{"asset": "SLVBARTEN", "quantity": 10000, "address": "n3PQ3R4Hc4C7FnDoYTBSfo3wuVPxXxvKRW"}, {"asset": "BIZBAZQUX", "quantity": 50, "address": "mn6q3dS2EnDUx3bmyWc6D4szJNVGtaR7zc"}, {"asset": "A11001756367432399000", "quantity": 10000, "address": "muv4ujHQmbW8G7YtVmAFboN8Y431ZpvQyK"}]

curl -H "Accept: application/xml" -X GET "localhost:14000/rest/balances/get?address=mn6q3dS2EnDUx3bmyWc6D4szJNVGtaR7zc&quantity=10000&op=OR"

<?xml version="1.0" encoding="utf-8"?>
<balances><item><asset>SLVBARTEN</asset><quantity>10000</quantity><address>n3PQ3R4Hc4C7FnDoYTBSfo3wuVPxXxvKRW</address></item><item><asset>BIZBAZQUX</asset><quantity>50</quantity><address>mn6q3dS2EnDUx3bmyWc6D4szJNVGtaR7zc</address></item><item><asset>A11001756367432399000</asset><quantity>10000</quantity><address>muv4ujHQmbW8G7YtVmAFboN8Y431ZpvQyK</address></item></balances>

Coverage remained the same at 68.34% when pulling 6b79205d55459d51e1715bdccc2fcb905d8a940c on Millz0r:develop into fb390982afd15f2091ee2123e277d4a166e62852 on CounterpartyXCP:develop.

Coverage remained the same at 68.38% when pulling 1be065b90113f3e888df8faa1aefacf56f45d9dc on Millz0r:develop into fb390982afd15f2091ee2123e277d4a166e62852 on CounterpartyXCP:develop.

ACK, with the caveat that the docs say the API isn't yet finalized.
@ouziel-slama?

Also, needs a rebase.

ACK

Merged here: https://github.com/CounterpartyXCP/counterpartyd/commit/0695ac8f645411767d71b11327f323467254866e


[Issue #11298]pulsar-daemon script support restart

Fixes #11298
Motivation
Add ability to restart service for easy use
Modifications
In pulsar-daemon script, add restart
Verifying this change

[ ] Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (yes / no) no
The public API: (yes / no) no
The schema: (yes / no / don't know) no
The default values of configurations: (yes / no) no
The wire protocol: (yes / no) no
The rest endpoints: (yes / no) no
The admin cli options: (yes / no) no
Anything that affects deployment: (yes / no / don't know)no

Documentation

Does this pull request introduce a new feature? (yes / no) no
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) not documented

Hi @eolivelli  Could u please review this pr?

Generally looks good.
What about stopping the daemon using '-force'?
Otherwise you are not guaranteed that the process is really killed

support  '-force' argument as before in last commit

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

It's duplicated with #12279. Close this PR first. If you have some improvement to #12279, please submit a new PR.

Could you open a new PR to fix it?


Change cascade_and_unite to connect.

Add a deprecation to avoid breaking code. Closes #10.

Codecov Report

Merging #26 into master will increase coverage by 0.06%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
+ Coverage   94.82%   94.88%   +0.06%
==========================================
  Files           8        8
  Lines         560      567       +7
==========================================
+ Hits          531      538       +7
  Misses         29       29

Impacted Files
Coverage Δ

src/AdmittanceModels.jl
100% <ø> (ø)
:arrow_up:

src/circuit_components.jl
100% <100%> (ø)
:arrow_up:

src/circuit.jl
86.36% <100%> (+0.92%)
:arrow_up:

src/admittance_model.jl
91.93% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbbae88...fe3ee98. Read the comment docs.


Adding species but not repeating the mapping of existing species

Hello,
I'd like to add more species to the previously built tree. Is there a way to re-use the mapping information of the previously included species and add this information to the mapping information of the newly added species, instead of re-mapping all previously included species again?
Thank you.

I guess you could just back up your concatenated MSA (.phy) and the tree files in a different folder. Then just run:
read2tree --standalone_path marker_genes/ --output_path output --reads species3_R1.fastq species3_R2.fastq
An n' number of times depending on how many samples you want to add, then finally:
read2tree --standalone_path marker_genes/ --output_path output --merge_all_mappings --tree
You will basically create a new concatenated alignment with the newly incorporated samples with the new tree inference at the end. Hope it helps.


Support for $refs inside schemas

Using openapi v3.0.1
I run into the issue that when I use $refs inside schemas, I get the error: should NOT have additional properties.
It would be nice if this would be supported or at least dont throw an error.
But if you want to implement this you have to concider, that they could not always be provided from the server so it should check it the nested schmea exists in the response and if so, validate it.
Also thank you for this tool. 👍

Thanks for this as well @Nitwel. Do you have a specific example or test case to recreate this?

Have a look at the project I'm currently working on:
https://github.com/directus/SDK-Generator/blob/e2c9a90f90b9df3b63e9628ddd3e93757e0ae6a9/specs/components/file.yaml#L79
My solution at the moment is that I merge all files into one big json file and remove all $ref's with openapi-cli.

Hi @Nitwel,
The link you provided is now dead. Is this still a problem for you? If it is, consider forking this repo, recreating the bug in the bugRecreationTemplate, and then linking to your forked repo here.

I'm closing this issue as it seems stale, but people can reopen if they need the enhancement

I'm closing this issue as it seems stale, but people can reopen if they need the enhancement


middleman creating README/index.html from README.md?

I first noticed this when building my project would throw errors related to a layout that references "current_page.data" (NoMethodError: undefined method `first' for nil:NilClass), then saw that it was trying to build a "README/index.html", which doesn't exist, only a README.md does. E.g., in the build output, I saw:
Request: /bower_components/fastclick/README/index.html
       error  build/bower_components/fastclick/README/index.html

Going to http://<IP_ADDRESS>:4567/bower_components/fastclick/README/index.html in development throws the same NoMethodError.
Why is Middleman trying to find a README/index.html when there's only a README.md? What can I do to stop this? It seems like Middleman is supposed to prevent this from happening? https://github.com/middleman/middleman/blob/master/middleman-core/features/more-extensionless_text_files.feature
I'm on middleman/middleman-core 3.4.0, adding onto a previously started project's code, so maybe it's a gem version conflict somewhere...

Added this to my config.rb after "activate :directory_indexes":
ignore /.*\/[\w,\s-]+\.md/ # ignore .md files

Still wondering why this happened in the first place with the .md files? And why apparently the previous contributors to the middleman project I'm working on never encountered this.

This confusion feature was removed in v4, so our currently releases don't have this bug.


Cache model workflow

I gather this is part of the CI workflow. Should I merge and push the CI workflow first before pushing this?

It is part of the CI. The reasoning behind this is that caching only happens when a workflow finishes successfully. This one does less so it finishes. I didn't think I'd finish the full version and I wanted to get ready by caching the model files. That's what this pull request adds. Now that the other one works, this can be skipped. It might be a good idea to keep around anyway.


Unittest organization - [merged]

In GitLab by @cmastalli on Jun 13, 2019, 18:06
Merges topic/unittest-organization -> cpp_devel
In this PR I re-organize the unit-test folder and include few CMake files for that. Now the organization is as follows:

unittest (root folder for c++ unit-tests)
unittest/python (Python unit-tests folders, legacy from Python library)
unittest/bindings (Python bindings for the moment)

@MaximilienNaveau be aware that you might need to code extra stuff inside unittest/CMakeLists.txt

In GitLab by @cmastalli on Jun 13, 2019, 18:06
merged

In GitLab by @cmastalli on Jun 13, 2019, 18:06
mentioned in commit 26107857e6e544bacec44d295412894f22a02336


modify discretized-ssm.ipynb to plot every time steps for the PF example

Description

Modified the notebook to plot every time step for the particle filtering example, including true x(k), observed y(k), filtered mean E[x(k) | y(1:k)] and variance +- sqrt{Var[x(k)|y(1:k)} and smoothed mean E[x(k) | y(1:T)] and variance +- sqrt{Var[x(k)|y(1:T)}, in a line plot. Also plotted the full posterior p(x(k) | y(1:k)) and p(x(k)|y(1:T)) as a heatmap to capture multi-modality.
Colab link

https://colab.research.google.com/github/benlau6/probml-notebooks/blob/discretized-ssm-patch/notebooks/discretized_ssm.ipynb
Related PR
Resolves #692
Related Issue

exact 1d Bayesian filtering
Figures

gist for line plot and heatmap
Checklist:

[x] Performed a self-review of the code
[x] Tested on Google Colab.

Potential problems/Important remarks

@murphyk My code is ready as requested, please note that I replaced for loops with jax.lax.scan and also made a few changes as requested by gerdm at pyprobml PR #700

@murphyk Updated. Please note that I marked red 'X's as actual values on heatmap. I also refactored the code a bit by correcting indentations, rearranging some code blocks, and removing some duplicated code blocks, functions, and line breaks.

Thanks, the new visualizations look good. (Although in the line plot I would label the x axis as 'time' rather than then meaningless 'k' index.)
I am trying to find an example that will look good in the book, and which will make intuitive sense to the reader. The first and third example are rather complicated, but the second one is perfect: a Gaussian random walk in which some of the observations are outliers. This could in principle also be a good test bed for evaluating Kalman smoothing variants that can handle robust noise models.   However it seems there may be a bug in your code, since the performance of the smoother is worse than the filter, which seems wrong. This can be seen in your 2 plots:

Also when you plot a single time slice (like in fig 2 of the paper) you get this

The smoothed distribution seems close to unimodal (as is to be expected, since there is less posterior uncertainty), but it is centered at the wrong point. Maybe the bug is in mapping from the discrete states to the correspond continuous values?
One way to debug this would be to replace the student likelihood with a Gaussian likelihood and then compare to the optimal estimate computed using my Kalman filtering and smoothing code at https://github.com/probml/JSL/blob/main/jsl/lds/kalman_filter.py.

Here's an illustration from book 2 on how smoothing is better than filtering in the linear-Gaussian case.
We should get something qualitatively similar even if the observation model is Student not Gaussian.

Soure code : https://github.com/probml/JSL/blob/main/jsl/demos/kf_tracking.py

It would also be very cool if the heatmap illustrated true multi-modality in the filtering distribution, which then gets 'resolved' in the smoothing distribution. This might just be a question of choosing the 'right' RNG key or increasing the heavy-tailedness of the Student observation model, to make the state estimation problem more ambiguous.

The bug is from x_pdf function and it is fixed now. Besides, rng_key of the particle filter example and students' t random walk example are changed to illustrate multi-modality being resolved by smoothing distribution.

LGTM, thanks


Refactor design system

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#160  👈
#159
#158
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ksharma-xyz and the rest of your teammates on  Graphite


Crash on Neoforge 1.20.4 with Extended AE

https://mclo.gs/64xbSdR
Crash when attempting to open in game config with the Extended AE Mod and Carbon Config.
MC 1.20.4
CarbonConfig-Neoforge-1.20.4-1.2.5.jar

@Saereth oh god. Yeah Looks like i need to rewrite the forge implementation to support a lot more.
Yeah i will try to get a patch out ASAP.
Might take a few days at worst.

Fixed in 1.20.4 + other bugs found now propagating the fix to other versions


Pact how to do contract testing by hitting the real service url

hi,
In my application I am consuming a service and I want to generate a pact file by actually hitting the provider service url. Right now I notice that my current code is always going to Mock provider and then only Pact file is getting generated. This is due to the below PactproiderRule configuration
@rule
public PactProviderRule rule = new PactProviderRule("weatherprovider",
PactSpecVersion.V3, this);
My run test code is as below:
assertEquals(new WeatherService(rule.getConfig().url()).getMaxTemp().toString(),"{"MaxTemp":300.01}");
rule.getconfig() is always hitting mockprovider getconfig method.
Can someone please guide me on how to hit the real provider service url from my consuming application ?

The whole idea of pact is to separate the consumer and provider with a contract, if you want to test the provider you should use a pact provider test and replay the contract afterwards.

As @Nalha mentioned, the point of the PactProviderRule in a consumer test is to pretend to be the provider so you can test your code without having to have the provider running.
Have a look at the pact-jvm-provider modules for a number of ways of replaying the pact file against your actual provider.


Move try-catch to thermo_state function

This PR reverts #1197 and moves the try-catch into thermo_state!, since it's called in many places (e.g., wfact!, precomputed_quantities!, implicit_vertical_advection_tendency! (and in callbacks).
Using time instead of debug, could also be useful in determining when to use the cached air temperature (always unless it's the initial condition)

bors r+


No support in docs for rails 3.x

Following the directions in the link for rails earlier than 5.0 results in a a bundler error:
    rails (~> 3.2.0) was resolved to <IP_ADDRESS>, which depends on
      actionpack (= <IP_ADDRESS>)

    rspec-rails was resolved to 4.1.0.pre, which depends on
      actionpack (>= 4.2)

The docs should be updated to replace 'master' with the correct maintenance branch name

What is the problem you're experiencing with the following exactly?
group :development, :test do
  gem 'rspec-rails', '~> 3.9'
end

That the other gems it depends on are not also current

Can you please elaborate?

I suggest you to skip declaring the version constraint, and let Bundler install the correct version of rspec-rails and dependent gems basing on the Rails version you use.
It's clearly a miss in the documentation, along with mentioning the now non-existent master branch (we're using main).
However, we're not too interested in keeping it up to date with other priorities in sight.
To keep you out of dependency conflicts, just keep in mind that main is 4.x now, and the most recent development in general. With an older version of Rails to work with, pick an earlier release from RubyGems.
You're welcome to send a PR to main and optionally to rails-6-1-dev branches to add

Use rspec-rails 3.x for Rails 3 and 4.

next to

Use rspec-rails 1.x for Rails 2.x.

@pirj The issue is we link to the 3-9-maintenance readme from the main readme. So we should update that one to reflect correct instructions...

Skipping the version constraint results in a bundler error.  The only way I can update rspec for rails 3.2 is to explicitly define the maintenance branch via the block gem declaration.
And if it's clearly a miss in the documentation, then the request to update the documentation seems like a reasonable change to make.

The only way I can update rspec for rails 3.2 is to explicitly define the maintenance branch via the block gem declaration.

Surely not, this should work:
gem "rspec-rails", "~> 3.9.0"

It surely doesn't:
  In snapshot (Gemfile.lock):
    rspec-mocks (= 2.14.6)

  In Gemfile:
    rspec-sidekiq was resolved to 1.1.0, which depends on
      rspec (~> 2.0) was resolved to 2.14.1, which depends on
        rspec-mocks (~> 2.14.0)

    rspec-rails (~> 3.9.0) was resolved to 3.9.1, which depends on
      rspec-mocks (~> 3.9.0)```

Again, I really don't see the issue in simply updating the docs to be accurate.

Have you tried running
bundle update --conservative rspec-rails rspec-mocks rspec-core rspec-expectations rspec-support rspec-sidekiq

What would be the output?

As per the PR I'm happy to update the old docs on this occasion, as it does help people using older versions, it's just there is no difference between the code in that branch and the releases on rubygems and thus won't help your issue. You've run into a common problem with (older at least) bundler where you have locked versions of gems and are trying to install a newer version, as @pirj suggests you need to update all the gems, theres nothing we can do about that and the git branch shouldn't help you there.

Yes, the bundle update command also works since it updates all the rspec gems, but the whole point was that the current docs as they exist are not accurate for their intended use case, and we've already spent far more time arguing about this than it would have taken to update two lines in the readme to be more accurate.

I have taken the extra time to try to help you, and future people who may come across this. The documentation pointing to the branches was outdated, but its also the wrong solution for your issue. The problem was the ~> 3.9 which tries to load 4.0.x and Bundler gets terrible confused.
I've now improved this further and pointed out the end of life issues, and provided hopefully clearer instructions.
Thank you for bring this to our attention.


Remove all Catena-X (NG) references

This issue tracks the removal of all occurrences of CatenaX-ng in this repository as part of the broader goal to deprecate this organization.

[ ] Search for Catena-X (NG) in code, configuration, and documentation.
[ ] Remove or adapt references accordingly.
[ ] Close this issue once zero references remain.

Use this query to track your progress (overall): GitHub Search Query
This query should display only results in related repository
Work summarized in https://github.com/eclipse-tractusx/sig-release/issues/838

@nitin-vavdiya could you please provide un update on this?
As the MIW was involved in https://github.com/eclipse-tractusx/managed-identity-wallet/issues/342 very unfortunate issue, I'd assume the reference would have certainly been removed by now.

@evegufy
I did not check yet as MIW is not in use in the new release and it is not compatible with new IATP/DCP flow.
Can we think of archiving this repository?

@nitin-vavdiya I added the repo to the list of repos which are possibly deprecated soon: https://github.com/orgs/eclipse-tractusx/projects/61/views/6?pane=issue&itemId=88268044
And I'll follow up on step 2-2 of the deprecation process next week. Is that list ok for you?

@nitin-vavdiya I added the repo to the list of repos which are possibly deprecated soon: https://github.com/orgs/eclipse-tractusx/projects/61/views/6?pane=issue&itemId=88268044 And I'll follow up on step 2-2 of the deprecation process next week. Is that list (under Final list for deprecation process) ok for you?

@borisrizov-zf is that also ok for you? Besides the miw also the ssi-agent-lib is part of the list: https://github.com/orgs/eclipse-tractusx/projects/61/views/6?pane=issue&itemId=88268044


Remove references to service.call_id

service.call_id it doesn't exist anymore, calling it throws an exception in the component and render it unusable

@ohadbenita
Sorry bro, I was away for some time and I had this change already done on my station.
I've only noticed your pull request after uploading my own fix which of course created a conflict with your change, so there's no need for this pull request anymore.
Thanks man!


[GURPS] 2.10.2

Submission Checklist
Required

[x] The pull request title clearly contains the name of the sheet I am editing.
[x] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[x] The pull request makes changes to files in only one sub-folder.
[x] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

Changes / Description

REVISION: Moved the custom macros for each repeating table to a Global Custom Macro section, under the Options tab.

For most of the repeating tables with skill rolls, you will be able to apply your custom macros to a skill by expanding the skill and checking which custom macros you would like to use for that skill.
ACTION: If you have created a custom macro, you will find it under the new Global Custom Macro. I would suggest renaming the macro to something appropriate. Next, apply the macro to the skills of your choice, you are no longer limited to a specific repeating table.
NEW: Add a Hearing Distance tool to help calculate hearing modifiers based on sound and listener's distance.
ENHANCEMENT: Tweaked layout of roll result for success/fail notes and layout of custom note boxes.

Character Sheet Info Roll20 Internal Use only.


CPU fallback for Map scalars with key vectors

Fixes #6282.
This change fixes the failure of queries where a scalar map is
looked up via a vector of keys. Rather than fall back to CPU,
such queries used to evade detection during planning, and failed
at runtime, as described in #6282:
java.lang.IllegalStateException: Map lookup keys must be scalar values
        at org.apache.spark.sql.rapids.GpuGetMapValue.doColumnar(complexTypeExtractors.scala:231)
        at com.nvidia.spark.rapids.GpuBinaryExpression.$anonfun$columnarEval$3(GpuExpressions.scala:258)
        at com.nvidia.spark.rapids.Arm.withResourceIfAllowed(Arm.scala:73)
        at com.nvidia.spark.rapids.Arm.withResourceIfAllowed$(Arm.scala:71)
        at org.apache.spark.sql.rapids.GpuGetMapValue.withResourceIfAllowed(complexTypeExtractors.scala:190)
        at com.nvidia.spark.rapids.GpuBinaryExpression.$anonfun$columnarEval$2(GpuExpressions.scala:253)
        at com.nvidia.spark.rapids.Arm.withResourceIfAllowed(Arm.scala:73)
        at com.nvidia.spark.rapids.Arm.withResourceIfAllowed$(Arm.scala:71)
...

This change allows the query plan to correctly fall back to
CPU mode.
(This change also includes fixes for incorrect whitespaces
and indentation errors in map_test.py.)
Signed-off-by: MithunR<EMAIL_ADDRESS>

Closing this. Will reopen against branch-22.08.


discuss: Enable webhook in apisix-ingress-controller

Describe
I noticed that webhook is not used in our project, and I suggest enable it.
Advantage：

It can help verify the schema of plugin.
Because kubebuilder generate CRD resource does not support oneOf and anyOf verification methods Need the help of webhook.
For example, for resources such as Gateway API Ingress etc.. We can configure plugins through annotations, and verifying plugins through webhook

Position:
Do not attempt to verify the entire crd resource through the APISIX schema, so the CRD resource usually has its own meaning, which is inconsistent with the apisix schema and easy to cause conflicts.

This feature PR #1355  has been merged, I will close this issue.


Information Architecture Redesign: Navigation Tree for Docs site

Is your feature request related to a problem? Please describe.
Current navigation on docs site has the shown the following user issues:

Users do not understand what an operator manual is and how it is different from user manual
Examples are often confused with tutorials and lead to users trying solutions that do not fit their user need
Users claim that information is difficult to find in tree
Information is not sorted by action or role

Describe the solution you'd like
Conduct user testing on current state to get more feedback

[ ] Card Sort
[ ] Survey
[ ] Usability testing (observation and feedback)

Redesign the Navigation tree

[ ] Mock tree in figma or other tool
[ ] Retest for validation

Make changes in the code

[ ] Change developer guide > Contribute to Zarf
[ ] Remove operator manual

Describe alternatives you've considered
blowing it all up lol jk but kind of.
Additional context
Add design files and research finding as they come

@Racer159 how do we want to track this work in milestones. This is the overarching epic that @jessy and I will use to track the work related to the IA redesign of the docs sites.

commenting

I think we could split it into three issues as you outlined above (and more as needed) along the user interview -> redesign -> implement lines.  Not sure how we feel about the spike issue pattern but it is one that I have liked for prototyping and researching solutions for an end product (usually an issue is labeled as a spike and then there is some documented outcome from that (i.e. documented user interview notes/analysis) that is used to build the next story or spike.

Done!


breakage when container names are syntactically invalid as hostnames

For example, Compose generates names with underscores.

@errordeveloper what is the actual problem here? I tried...
$ weave launch && weave launch-dns && weave launch-proxy
233175e68b3f1acdb4b575365b65873bb4e6f2fdde4540ee58fb5a940fa1cc0e
eab7f5de2f66576835a4e119570304ab16b6bbae26a8f752315d46b6c5d29e53
9f22c0618999ba92de2ca1fe038ca6700470e6ee5a5c3e6b8adae7772c23deaf
$ eval $(weave proxy-env)
$ docker run --name=a_1 -ti ubuntu
root@a_1:/#

which works just fine.

Apparently the restriction is that hostname components may contain only the ASCII letters 'a' through 'z' (in a case-insensitive manner), the digits '0' through '9', and the hyphen ('-'), and must not start or end in a hyphen.
So underscores are indeed not valid. However, I'd quite like to know what actually broke for @errordeveloper, so we can be sure that we are solving a real rather than theoretical problem here. I've tried `gliderlabs/alpine' and, just like ubuntu, it is perfectly happy with underscores.

@rade indeed, so far this was a theoretical one. I didn't see anything breaking specifically, it looks like the _ in DNS names is widely accepted.


Add support TomoSwap transaction

Great to see more info (rate, amount) in the tx that user swap TOMO and CONST

https://github.com/tomochain/tomoscan/commit/6a461d5e412879d60f688f919b1389c984047e60
https://github.com/tomochain/tomoscan/commit/3284dfe15dbbc853f9f42fb55fa94903a69c1e4b


config: compile out inline config comments

Description: Compile out inline config comments.
Risk Level: Low
Testing: CI
Signed-off-by: Mike Schore<EMAIL_ADDRESS>

cc @mattklein123
This is one take on compiling out yaml comments. I'm not sure it's the best since:

The syntax is maybe a bit esoteric.
All this stuff gets zipped anyways, so the comments probably don't amount to much by the time it's packaged for distribution.

One potential plus to this approach though is it keeps the comments inline.


Update dependencies in react-scripts to pull in latest babel traverse to get past known vulnerability.

This updates dependencies (mainly in packages/react-scripts) to update babel/traverse to get past a security vulnerability (CVE-2023-45133) see #13470
Steps taken

update babel-core (which transitively pulls in babel/traverse) to latest in package/react/scripts
run npm audit fix in root to update package-lock.json with the new babel-traverse and other dependencies.

the tests pass and running a skeleton app appears to work.

@thekbb Please can you provide the solution for this issue so it can be fixed in our environment for now? while upgrading the transitive dependency it breaks in other cases and throws different errors. We may not know when it would be the next release. Any ETA you're aware of? Thanks for creating a PR and helping the community.

@AnupSingh97, you had issues with upgrading babel/core to  7.23.6? to update babel/traverse? What happened? It is working for me.

@AnupSingh97, you had issues with upgrading babel/core to 7.23.6? to update babel/traverse? What happened? It is working for me.

If I consume your changes from here, it may work but the PR hasn't merged yet. I was asking about the alternate option to update the babel/traverse dependency to remove the critical vulnerability. I found an overrides section approach to update the transitive dependency for now. if you have any other approach please suggest and what's your input on the overrides section approach?
thanks, @thekbb for replying and looking forward.

Hi, is there an update regarding this PR?
This is a critical vulnerability of remote code execution.
It doesn't make sense that it hasn't been fixed yet.
Is there a reason for the delay with fix it??

@thekbb any update as to when this will get merged?

@thekbb any update as to when this will be merged?

I can't say when or if it will be merged, I am not a maintainer. This project is abandoned - I've moved on and would advice you to do so as well.


Frontend handles user access to group session

[x] Design addition to current user interface
[ ] Implement necessary code to frontend
[ ] Tests

Neccessary components added, except the code to show the group token in the right corner.


Start osbuild-composer button is shown when user has no permissions to start

Description of problem
If you prepare an VM and login as admin you are shown a start service button but lack permissions to do so.
Component (web, API, etc)
web
Version or commit hash (if applicable)
9ba8ddbe89dc5429f7a1a75af4c73e835c30b5b9
How often reproducible
Always
Steps to Reproduce

Login as admin
Click on start osbuild-composer service

Actual results
The service osbuild-composer was not started. Message: Not permitted to perform this action.

Expected results
Do not show the button when you have no permissions to start it.

Closed in favor of #1754


Query for upgrading move_node.jstree from v1 to v3

First of all, thanks for such a nice plugin.
This is not actually an issue, but query for help on how to upgrade for particular task with jstree.
I am trying to upgrade jstree plugin for existing project. Earlier project was using 1.0-rc3, then I've upgraded jquery version to latest version from 1.11 to 3.x and so decided to upgrade jstree version to latest one, at this moment it is 3.3.4.
A functionality I am looking is that there are two root nodes in single jstree. One root node is a source node and another is target node. I am using "dnd" plugin to use drag and drop functionality. From source root node, drag a child node and drop it to target root node or to any of its children. The final result should be node from source root node should be there only and target root node will initiate an ajax request which will eventually persist node detail to database and then render the entire tree again with new node included under target root node. So basically it is Copy operation in the same jstree, but is performed using drag and drop move operation.
With 1.x, this functionality was performed with below code snippet:
$(<selector>).jstree({ ... <data and plugin related information> ... }
).bind("move_node.jstree", function (event, data) {
	//delete newly inserted node
        // Find children nodes of target node and iterate over it
	data.inst._get_children(data.rslt.np).each(function () {
                // If child node is of type "CONTENT" then delete that node from target root node
		if ("CONTENT" == $(this).attr("dataType")) {
			data.inst.delete_node(this);
		}
	});
        // Is jstree editable or not (boolean flag)
	if (treeEditable) {
        // Initiate ajax request to open form which captures detail for new node.
		dropContent(data.rslt.r.attr("dataID"), data.rslt.r.attr("dataType"), data.rslt.o.attr("dataID"));
	}
});

I couldn't find mapping of data maps from older version to new one.
Can anyone suggest how to upgrade this code snippet to latest version of jstree?

jsTree v.1 has not been supported for years. From what I gather you might find this option useful:
https://www.jstree.com/api/#/?q=dnd.always&f=$.jstree.defaults.dnd.always_copy
As for data attached to a node you can access it (inside the handler) using data.instance.get_node("node_id").data, or if you want the moved/copied node - data.node.data
Let me know if I can help any further.

dnd.always_copy did works. It now triggers copy_node.jstree event instead of move_node.jstree.
https://www.jstree.com/api/#/?f=copy_node.jstree
One more thing I am expecting for  mogration. Can we get children for any node? I see there is a function for get_children_dom(), which returns DOM LI elements for the node. Instead is there any helper function available which returns jstree object for children elements? Earlier with 1.x it was supported using _get_children() function.

Any input on this is greatly appreciated @vakata
Thanks


Windows 10 : getting error while configuring detekt plugin

I am getting below error after running below command on Windows 10 :
java -jar detekt-cli/build/libs/detekt-cli-1.0.0.RC8-all.jar -p /home/artur/Repos/detekt -c /home/artur/Repos/detekt/default-detekt-config.yml -f "./test/." --parallel
Error :
The following option is required: [--input | -i]
Usage: main class
Appreciate your help. Thanks

You have to specify the input path which detekt should analyse for you.
Further information can be found under the cli usage section
https://arturbosch.github.io/detekt/cli.html
If you need further assistance feel free to reopen this issue.

Thank You @schalkms. Can you please give one example ? it will be great help.

Sure
-home/artur/repos/your_repo
Your_repo contains your Kotlin project/files

Thanks. let me try out.

Hi @schalkms. I am still getting same error.  basically I am trying to integrate detekt plugin to Sonarqube.

There is a separate detekt plugin for sonarqube available.
https://github.com/arturbosch/sonar-kotlin/

@schalkms. Thanks.


QGB update relayer to work in multiple validators environment

This fixes the relay mechanism for valsets in multiple validators' environment.
However, it does not address data commitments as the following issue is still not addressed https://github.com/celestiaorg/celestia-app/issues/370

depends on: https://github.com/celestiaorg/celestia-app/pull/444

Codecov Report

:exclamation: No coverage uploaded for pull request base (qgb-integration@d5d3834). Click here to learn what that means.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##             qgb-integration     #445   +/-   ##
==================================================
  Coverage                   ?   11.44%
==================================================
  Files                      ?       60
  Lines                      ?    11518
  Branches                   ?        0
==================================================
  Hits                       ?     1318
  Misses                     ?    10113
  Partials                   ?       87

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5d3834...5b36440. Read the comment docs.


Regional Music System

Implement a music system which plays tracks based on which region the player is standing in. I'll write all the data.

What kind of system are you looking for? A bit more detail would be nice. If you're just after something that plays music upon entering a region, you can do the following:
enum class RegionalSongs(val region: Int, val song: Int) {
    LUMBRIDGE(region = 12850, song = 123);

    companion object {
        val values = enumValues<RegionalSongs>()
    }
}

RegionalSongs.values.forEach { regionalSong ->
    on_enter_region(regionId = regionalSong.region) { player.playSong(regionalSong.song) }
}

Closed due to inactivity


golines: 0.11.0 -> 0.12.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/segmentio/golines/releases.
meta.description for golines is: A golang formatter that fixes long lines
meta.homepage for golines is: https://github.com/segmentio/golines
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.12.1 in filename of file in /nix/store/kcv0nbgmj9znygzwb2b1qp4rf91xfi61-golines-0.12.1

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
golines

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/kcv0nbgmj9znygzwb2b1qp4rf91xfi61-golines-0.12.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A golines https://github.com/r-ryantm/nixpkgs/archive/5d6516de96501769bd3091f253b769ed3a808cf6.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/5d6516de96501769bd3091f253b769ed3a808cf6#golines

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/kcv0nbgmj9znygzwb2b1qp4rf91xfi61-golines-0.12.1
ls -la /nix/store/kcv0nbgmj9znygzwb2b1qp4rf91xfi61-golines-0.12.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

golines

Maintainer pings
cc @meain for testing.

@ofborg eval

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/segmentio/golines/releases.
meta.description for golines is: A golang formatter that fixes long lines
meta.homepage for golines is: https://github.com/segmentio/golines
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.12.2 in filename of file in /nix/store/qrxxlmxldvxspj4sryydxkl6x06s64y5-golines-0.12.2

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
golines

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/qrxxlmxldvxspj4sryydxkl6x06s64y5-golines-0.12.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A golines https://github.com/r-ryantm/nixpkgs/archive/3a36ae7c1280c8329160dc1ce8067a95fefd9de9.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/3a36ae7c1280c8329160dc1ce8067a95fefd9de9#golines

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/qrxxlmxldvxspj4sryydxkl6x06s64y5-golines-0.12.2
ls -la /nix/store/qrxxlmxldvxspj4sryydxkl6x06s64y5-golines-0.12.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

golines

Maintainer pings
cc @meain for testing.


fix: create account drawer to toast

Try out this version of the Hiro Wallet - download extension builds.

This PR removes the account drawer steps and separates create account and switch account. The create account drawer has been changed here to a toast. So, what was AccountsDrawer handling both as steps, is now SwitchAccountDrawer and a hook use-create-account that handles a toast for creating an account.

cc/ @kyranjamie @fbwoolf @beguene @He1DAr

@landitus if you can prioritize reviewing this, that would be great. It will fix some failing integration tests we are seeing on multiple branches. It would be nice to get this merged into dev if possible.

We can go with this new UX for now, as I think they it's better than what we have now. Note the following:

Thanks for reviewing. Yep, just hoping to get past these failing tests. I know you have an issue to redesign this flow. The refactoring I did here will make the transition to a new design easier.

When creating an account from the Switch account menu, there's no dark overlay that blocks the screen, so the user can still click on the elements.

Thanks for catching, will add the overlay here.

There are times where the toast for "Account created" doesn't show up. To test this, I've created two accounts in a row, and the second time it's when it's missing.

This is coming from react-hot-toast, so I'm not sure it is something we can control but will look into it. Hoping it doesn't happen very often and is ok for now.

I found another issue with the toast, this time when testing connecting the wallet to a dApp. In this situation, the "account created" toast never appears.
https://user-images.githubusercontent.com/239215/164061911-9e4f1f19-32d4-49e0-b405-f2e52061f376.mp4

@fbwoolf
Quick question:
https://user-images.githubusercontent.com/38872890/164088031-2d758232-63d2-479c-96dc-bd19d91a0735.mov
This may be related to performance as test data has over 200 separate accounts but thought will bring it to your attention
There is two ways where an user can create a new account

First method: 3 dots dropdown on the wallet -> Select the 'Create account' from the list
Second method : Scroll to the end of of all the accounts ->Select the 'Create account'

In the screen recording above:noticed that the 'Account created' in green info was only visible in second method when the user creates an account ,however I didn't see it during the first method of creating the account. Is this expected?
cc @landitus @markmhx

@fbwoolf Quick question:
account.toast.mov
This may be related to performance as test data has over 200 separate accounts but thought will bring it to your attention
There is two ways where an user can create a new account

First method: 3 dots dropdown on the wallet -> Select the 'Create account' from the list
Second method : Scroll to the end of of all the accounts ->Select the 'Create account'

In the screen recording above:noticed that the 'Account created' in green info was only visible in second method when the user creates an account ,however I didn't see it during the first method of creating the account. Is this expected?
cc @landitus @markmhx

Notice that @landitus also caught the issue while creating two accounts in a row.I will monitor if the issue is reproducible.

Notice that @landitus also caught the issue while creating two accounts in a row.I will monitor if the issue is reproducible.

Yep, I did respond to this already. We are using a library called react-hot-toast and their promise to show the success toast. I think it is ok for now bc we plan to redesign this with our own toast soon. The account is clearly created bc the home page switches to that account. It is nice to have the success toast but it's not totally necessary to create the account successfully.
Also, this has been merged into dev so it can be tested there once we create a release PR.

I found another issue with the toast, this time when testing connecting the wallet to a dApp. In this situation, the "account created" toast never appears.
Wallet.-.create.account.toast.from.dapp.-.not.showing.toast.mp4

I was able to reproduce the same issue in several sites such as stxnft .com and stacksart.com as well.
This seems like a lower priority bug unless product/design says otherwise, will create separate ticket based on the input.
cc @markmhx @fbwoolf

Notice that @landitus also caught the issue while creating two accounts in a row.I will monitor if the issue is reproducible.

Yep, I did respond to this already. We are using a library called react-hot-toast and their promise to show the success toast. I think it is ok for now bc we plan to redesign this with our own toast soon. The account is clearly created bc the home page switches to that account. It is nice to have the success toast but it's not totally necessary to create the account successfully.
Also, this has been merged into dev so it can be tested there once we create a release PR.

Tested the scenario above on a new account with next steps on the new onboarding flow. Test passed as well

I found another issue with the toast, this time when testing connecting the wallet to a dApp. In this situation, the "account created" toast never appears.

Created a separate issue for the above in #2377. Moving the ticket out to Merge from QA

Again, this is not an issue that we need to create.


Modrinth/Curseforge?

Please publish it on modrinth/curseforge, thx

I started to working for it, but I'm not sure if it be completed.
sorry

fmm… I think it too.
so I added "a wynncraft mod" to description.
is it not enough?

Both of them are approved and published.

Thank you very much!! I appreciate it


[HPRO-1312] Module 3 Saliva Aliquot

Q
A

Target Release?
Next available

Bug fix?
❌

New feature?
✅

Database migration?
✅

New configuration?
❌

Composer updates?
❌

NPM updates?
❌

Jira Ticket(s)
HPRO-1312

Summary
Adds changes to saliva aliquots to allow for glycerol volume collection for saliva aliquots.

Instructions for testing
Screenshots

@Ehaic Looks like the validation error message is not formatted properly and it's breaking the form fields layout.


[Bug]The link for the tutorial is linked to a forked repo from @morganersery1

Summary
The link for the tutorial is linked to a forked repo from @morganersery1
How to reproduce
I am not sure if it is designed to be this way. Seems not official.
Please include screenshots.
Additional context
Add any other context about the problem here.

@wangyuchen333 Hello! This appears to be a duplicate of https://github.com/skills/introduction-to-github/issues/929 - I'll go ahead and close this issue 💛


GLTF loading dirty mechanism perf

Lets try to not dirty the entire scene if possible when only adding new nodes/materials without changing the current state of the scene.

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Snapshot stored with reference name:
refs/pull/14487/merge
Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14487/merge/index.html
To test a playground add it to the URL, for example:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14487/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/14487/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/14487/merge
https://gui.babylonjs.com/?snapshot=refs/pull/14487/merge
https://nme.babylonjs.com/?snapshot=refs/pull/14487/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/14487/merge#BCU1XR#0


Update codecov token

Why are the changes needed?

Enable code coverage report
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before make a pull request

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@ca94d7b). Click here to learn what that means.
The diff coverage is n/a.

:exclamation: Current head 8866b76 differs from pull request most recent head 90d9f00. Consider uploading reports for the commit 90d9f00 to get more accurate results

@@            Coverage Diff            @@
##             master     #811   +/-   ##
=========================================
  Coverage          ?   78.70%
  Complexity        ?       10
=========================================
  Files             ?      132
  Lines             ?     5108
  Branches          ?      638
=========================================
  Hits              ?     4020
  Misses            ?      740
  Partials          ?      348

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca94d7b...90d9f00. Read the comment docs.

comment to test mailing list

thanks, merged to master


Downloading an entire collection, ref #624

Using WorkZipService as a basis, create a zip file from a collection containing individual zip files of each work.
Refactors the work zip service so the two can share more code, and renames the spec test to match the Ruby file name.

Coverage decreased (-0.8%) to 53.625% when pulling e291952e1e50a3a2218fe55c229b2be0ce122f92 on i#624 into 58b671984335bb5af22a564a9f1fe33cc48e3420 on develop.