Always tries to fetch from web

When I use this example code (modified from the readme):
import { addSchema } from "@hyperjump/json-schema/draft-2020-12";
import { bundle } from "@hyperjump/json-schema/bundle";
import * as yaml from 'yaml'

addSchema({
  "$id": "https://schema.datum.microntech.io/main",
  "$schema": "https://json-schema.org/draft/2020-12/schema",

  "type": "object",
  "properties": {
    "foo": { "$ref": "/string" }
  }
});

addSchema({
  "$id": "https://schema.datum.microntech.io/string",
  "$schema": "https://json-schema.org/draft/2020-12/schema",

  "type": "string"
});

const bundledSchema = await bundle("https://schema.datum.microntech.io/main"); // {
//   "$id": "https://schema.datum.microntech.io/main",
//   "$schema": "https://json-schema.org/draft/2020-12/schema",
//
//   "type": "object",
//   "properties": {
//     "foo": { "$ref": "/string" }
//   },
//
//   "$defs": {
//     "https://schema.datum.microntech.io/string": {
//       "$id": "https://schema.datum.microntech.io/string",
//       "type": "string"
//     }
//   }
// }

console.log(yaml.stringify(bundledSchema))

Then everything works as expected and I get output.
When I try any other code that uses my own schema files, which I have verified are being added to the schemaStore by the right IDs, then I always get an error that the url cannot be found.
Is there something special I need to do to make this work without having an actual domain name that hosts the files? Why would it work with two example schema but not with 50  real ones?

I can share the code I used if it would be helpful, but I can't share the schemas as they are proprietary at present.

It will only try to fetch the schema if it doesn't exist in the schemaStore. I don't have a lot of information to go on, so it's hard for be to help too much. When you get the error that he URL couldn't be found, it should tell you what the offending URL is, right? I'd start by trying to figure out why a schema with that URL isn't in the schemaStore and try to rectify that problem.
If you can provide more information, I'd be happy to try to help more. Sharing code and specific error messages might help, but I suspect there's not much I can figure out without seeing the schemas. If you're able to share over a private channel such as email or the JSON Schema Slack, I'd be happy to look over it. Otherwise I'd suggest trying to create a minimal reproducible example that you can share.

Is there any way to see what ID caused the fetch to be made? It may be a simple spelling mistake but with ~50 schemas it's going to be hard to track it down.

Ok so it was a minute spelling mistake on my part. That took some finding!
Thanks for your time on this though. It would be great to have some way of knowing where the error was being raised in terms of the schema as well as the calling code.

Can you share the exact error you were getting or a minimal reproduction of the error? I'd like to see what I can do about improving the experience, but that's hard to do unless I can reproduce that experience.

Here's a copy of the error caused by a mis-identified schema being referenced in another:
/reference/node_modules/undici/index.js:109
      Error.captureStackTrace(err, this)
            ^

TypeError: fetch failed
    at fetch (/reference/node_modules/undici/index.js:109:13)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async Module.get (file:///reference/node_modules/@hyperjump/json-schema/lib/schema.js:167:22)
    at async Object.compile (file:///reference/node_modules/@hyperjump/json-schema/lib/keywords/ref.js:8:28)
    at async file:///reference/node_modules/@hyperjump/json-schema/lib/keywords/validation.js:49:28
    at async file:///reference/node_modules/@hyperjump/pact/lib/index.js:12:5
    at async asyncCollectArray (file:///reference/node_modules/@hyperjump/pact/lib/index.js:226:20)
    at async Object.compile (file:///reference/node_modules/@hyperjump/json-schema/lib/keywords/validation.js:33:65)
    at async Object.compile (file:///reference/node_modules/@hyperjump/json-schema/lib/keywords/items.js:15:32)
    at async file:///reference/node_modules/@hyperjump/json-schema/lib/keywords/validation.js:49:28 {
  cause: Error: getaddrinfo ENOTFOUND schema.datum.microntech.io
      at GetAddrInfoReqWrap.onlookupall [as oncomplete] (node:dns:118:26) {
    errno: -3008,
    code: 'ENOTFOUND',
    syscall: 'getaddrinfo',
    hostname: 'schema.datum.microntech.io'
  }
}

I've seen other errors about invalid schema that have an empty errors array when I use bundle as opposed to validate
file:///reference/node_modules/@hyperjump/json-schema/lib/core.js:103
      throw new InvalidSchemaError(metaResults);
            ^

InvalidSchemaError: Invalid Schema
    at Object.pubsub_subscription_0 (file:///reference/node_modules/@hyperjump/json-schema/lib/core.js:103:13)
    at publishAsync (file:///reference/node_modules/@hyperjump/json-schema/lib/pubsub.js:34:61)
    at Object.compile (file:///reference/node_modules/@hyperjump/json-schema/lib/keywords/validation.js:14:9)
    at compile (file:///reference/node_modules/@hyperjump/json-schema/lib/core.js:29:38)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async collectExternalIds (file:///reference/node_modules/@hyperjump/json-schema/bundle/index.js:61:30)
    at async bundle (file:///reference/node_modules/@hyperjump/json-schema/bundle/index.js:25:23)
    at async file:///reference/bundle.js:47:17 {
  output: {
    keyword: 'https://json-schema.org/evaluation/validate',
    absoluteKeywordLocation: 'https://json-schema.org/draft/2020-12/schema#',
    instanceLocation: 'https://schema.datum.microntech.io/api/arrange/relationship#',
    valid: false,
    errors: []
  }
}

That one made it hard to track down the errors.
I hope these help :)

This is helpful, thank you!

Here's a copy of the error caused by a mis-identified schema being referenced in another:

I get what the problem is now. The error is that the domain is unreachable, but it doesn't include the full URI, which makes it hard to track down the offending schema. I'll probably need to catch this error and return a more helpful one of my own.

I've seen other errors about invalid schema that have an empty errors array when I use bundle as opposed to validate.

You need to configure how you want errors to be presented. The default is the FLAG format that only provides pass/fail info. There are several output formats defined by the JSON Schema specification, but they aren't considered stable and may change. Therefore, I require you to opt-in if you want to use them. It's safe to use them for human consumption, but if you write code that depends on them, you need to accept the risk that they might change without warning.
This is something that has confused others as well. I'll see about adding some additional info to the error message to point people in the right direction.

Thanks for the feedback and info :)


Remove wrapping of links with buttons

I removed the button-elements, which makes imho no sense from a semantic point of view. Also it breaks the links in Firefox and makes them unusable.
Atm the disabled-styles are missing. I'll add them, when the styles "issue" is solved.

Thanks for looking into this! The problem is that this should be directly fixed in ampstart. Until then the best approach would be to add the required rules in templates/styles/shared.css.

(didn't intent to close the PR)

The styles for disabled a[class=*"ampstart-btn"]-elements are added. PTAL.

I took the liberty to add the suggested changes to your PR.
Thanks a lot for looking into this!


fix(demo): keep component active in the menu even when not on "Examples" tab

@quentinderoubaix Thank you for reviewing and merging my PR


Search function of the user doc is scuffed

Issue type
Styling or Accessibility
Problem description
When you search for information about "Project properties", the search gives you irrelevant information exclusively.

Context (optional)
It really should find an exact match of a chapter heading...
https://docs.gradle.org/current/userguide/build_environment.html#sec:project_specific_properties
Page with the problem
https://docs.gradle.org/current/userguide/build_environment.html#sec:project_specific_properties

Actually the user doc has at least 2 redundant pages about project properties... the search seems to find none of them:
https://docs.gradle.org/current/userguide/project_properties.html


Environments: Error should help me solve action

Dev Home version
No response
Windows build number
No response
Other software
No response
Steps to reproduce the bug
First: it would be ideal for errors not to occur.
Second: can we fix them automatically?
Third: Let's give the user an quick fix instead of just text.
In this case the error that I get from our UI is that devbox needs me to log in. Why not add functionality to "Click this message to login, or click this message to go to the settings pane"
Expected result
Click here to fix.
Actual result

Included System Information
No response
Included Extensions Information
No response

We can't really prevent this error.
We can't fix this error automatically, but we can try to get the logged in user account and set it to default.
The error is actually shown from the Azure extension. And an action, if any, will have to come from the Azure extension. Navigation to the Settings page won't be possible since the extension doesn't have that kind of control over the host, Dev Home. But we can pursue the idea presented above.

And I think that this should be a feature request, instead of a bug.


Sleuth giving different traceIds for each RxJava's Single execution

Spring sleuth is giving different traceIds for each execution call with Single#fromSupplier(). Usually these are all should be under same traceId which is not happening here. I have tried creating a scoped span but didn't worked out. Here is the sample reproducible code
Single<Object> externalIOBoundApiCallOne = Single.fromSupplier(
						() -> {
							Span span = tracer.nextSpan();
							try (Tracer.SpanInScope ws = tracer.withSpanInScope(span.start())) {
								Future<Object> obj =
										appExecutorService.submit(() -> {
											return restTemplate.getForObject("https://random-data-api.com/api/address/random_address", Object.class);
										});
								return obj.get();
							}
						}
				)
				.timeout(5000, TimeUnit.MILLISECONDS)
				.subscribeOn(Schedulers.io())
				.onErrorReturn(t -> appExecutorService.submit(() -> "ERROR"));

		Single<Object> externalIOBoundApiCallTwo = Single.fromSupplier(
						() -> {
							Span span = tracer.nextSpan();
							try (Tracer.SpanInScope ws = tracer.withSpanInScope(span.start())) {
								Future<Object> obj =
										appExecutorService.submit(() -> {
											restTemplate.getForObject("https://random-data-api.com/api/app/random_app", Object.class);
											if (!Thread.currentThread().getName().isEmpty())
												throw new RuntimeException("Error while doing http call");
											return null;
										});
								return obj.get();
							}
						}
				)
				.timeout(5000, TimeUnit.MILLISECONDS)
				.subscribeOn(Schedulers.io())
				.onErrorReturn(t -> appExecutorService.submit(() -> "ERROR"));

Logs:
2023-12-04 17:14:50.135  INFO [rxjava-and-spring-sleuth,,] 21914 --- [           main] c.e.r.RxjavaAndSpringSleuthApplication   : Started RxjavaAndSpringSleuthApplication in 2.485 seconds (JVM running for 2.759)
2023-12-04 17:14:50.339  INFO [rxjava-and-spring-sleuth,5da4526dc52f3654,5da4526dc52f3654] 21914 --- [nio-8080-exec-1] o.a.c.c.C.[Tomcat].[localhost].[/]       : Initializing Spring DispatcherServlet 'dispatcherServlet'
2023-12-04 17:14:50.339  INFO [rxjava-and-spring-sleuth,5da4526dc52f3654,5da4526dc52f3654] 21914 --- [nio-8080-exec-1] o.s.web.servlet.DispatcherServlet        : Initializing Servlet 'dispatcherServlet'
2023-12-04 17:14:50.340  INFO [rxjava-and-spring-sleuth,5da4526dc52f3654,5da4526dc52f3654] 21914 --- [nio-8080-exec-1] o.s.web.servlet.DispatcherServlet        : Completed initialization in 1 ms
2023-12-04 17:14:50.391  INFO [rxjava-and-spring-sleuth,af855cc1c07de96c,c67bdecfa53bc526] 21914 --- [pool-3-thread-1] c.e.r.RequestResponseLoggingInterceptor  : Request Start
2023-12-04 17:14:50.391  INFO [rxjava-and-spring-sleuth,8e9d1c9fead65b58,2d86758d9754864a] 21914 --- [pool-3-thread-2] c.e.r.RequestResponseLoggingInterceptor  : Request Start
2023-12-04 17:14:50.391  INFO [rxjava-and-spring-sleuth,af855cc1c07de96c,c67bdecfa53bc526] 21914 --- [pool-3-thread-1] c.e.r.RequestResponseLoggingInterceptor  : URI         : https://random-data-api.com/api/address/random_address
2023-12-04 17:14:50.391  INFO [rxjava-and-spring-sleuth,8e9d1c9fead65b58,2d86758d9754864a] 21914 --- [pool-3-thread-2] c.e.r.RequestResponseLoggingInterceptor  : URI         : https://random-data-api.com/api/app/random_app
2023-12-04 17:14:50.392  INFO [rxjava-and-spring-sleuth,af855cc1c07de96c,c67bdecfa53bc526] 21914 --- [pool-3-thread-1] c.e.r.RequestResponseLoggingInterceptor  : Method      : GET
2023-12-04 17:14:50.392  INFO [rxjava-and-spring-sleuth,8e9d1c9fead65b58,2d86758d9754864a] 21914 --- [pool-3-thread-2] c.e.r.RequestResponseLoggingInterceptor  : Method      : GET
2023-12-04 17:14:50.392  INFO [rxjava-and-spring-sleuth,af855cc1c07de96c,c67bdecfa53bc526] 21914 --- [pool-3-thread-1] c.e.r.RequestResponseLoggingInterceptor  : Headers     : [Accept:"application/json, application/*+json", Content-Length:"0", X-B3-TraceId:"af855cc1c07de96c", X-B3-SpanId:"c67bdecfa53bc526", X-B3-ParentSpanId:"47a65fa33eadbd5e", X-B3-Sampled:"1"]
2023-12-04 17:14:50.392  INFO [rxjava-and-spring-sleuth,8e9d1c9fead65b58,2d86758d9754864a] 21914 --- [pool-3-thread-2] c.e.r.RequestResponseLoggingInterceptor  : Headers     : [Accept:"application/json, application/*+json", Content-Length:"0", X-B3-TraceId:"8e9d1c9fead65b58", X-B3-SpanId:"2d86758d9754864a", X-B3-ParentSpanId:"c399e24a1765ef98", X-B3-Sampled:"1"]
2023-12-04 17:14:50.392  INFO [rxjava-and-spring-sleuth,af855cc1c07de96c,c67bdecfa53bc526] 21914 --- [pool-3-thread-1] c.e.r.RequestResponseLoggingInterceptor  : Request body:
2023-12-04 17:14:50.392  INFO [rxjava-and-spring-sleuth,8e9d1c9fead65b58,2d86758d9754864a] 21914 --- [pool-3-thread-2] c.e.r.RequestResponseLoggingInterceptor  : Request body:
2023-12-04 17:14:50.392  INFO [rxjava-and-spring-sleuth,af855cc1c07de96c,c67bdecfa53bc526] 21914 --- [pool-3-thread-1] c.e.r.RequestResponseLoggingInterceptor  : Request End
2023-12-04 17:14:50.392  INFO [rxjava-and-spring-sleuth,8e9d1c9fead65b58,2d86758d9754864a] 21914 --- [pool-3-thread-2] c.e.r.RequestResponseLoggingInterceptor  : Request End
2023-12-04 17:14:52.091  INFO [rxjava-and-spring-sleuth,af855cc1c07de96c,c67bdecfa53bc526] 21914 --- [pool-3-thread-1] c.e.r.RequestResponseLoggingInterceptor  : Response Start
2023-12-04 17:14:52.091  INFO [rxjava-and-spring-sleuth,8e9d1c9fead65b58,2d86758d9754864a] 21914 --- [pool-3-thread-2] c.e.r.RequestResponseLoggingInterceptor  : Response Start
2023-12-04 17:14:52.091  INFO [rxjava-and-spring-sleuth,af855cc1c07de96c,c67bdecfa53bc526] 21914 --- [pool-3-thread-1] c.e.r.RequestResponseLoggingInterceptor  : Status code  : 200 OK
2023-12-04 17:14:52.091  INFO [rxjava-and-spring-sleuth,8e9d1c9fead65b58,2d86758d9754864a] 21914 --- [pool-3-thread-2] c.e.r.RequestResponseLoggingInterceptor  : Status code  : 200 OK
2023-12-04 17:14:52.091  INFO [rxjava-and-spring-sleuth,af855cc1c07de96c,c67bdecfa53bc526] 21914 --- [pool-3-thread-1] c.e.r.RequestResponseLoggingInterceptor  : Status text  : OK
2023-12-04 17:14:52.091  INFO [rxjava-and-spring-sleuth,8e9d1c9fead65b58,2d86758d9754864a] 21914 --- [pool-3-thread-2] c.e.r.RequestResponseLoggingInterceptor  : Status text  : OK
2023-12-04 17:14:52.091  INFO [rxjava-and-spring-sleuth,af855cc1c07de96c,c67bdecfa53bc526] 21914 --- [pool-3-thread-1] c.e.r.RequestResponseLoggingInterceptor  : Headers      : [Server:"nginx/1.18.0 (Ubuntu)", Date:"Mon, 04 Dec 2023 11:44:52 GMT", Content-Type:"application/json; charset=utf-8", Transfer-Encoding:"chunked", Connection:"keep-alive", X-Frame-Options:"SAMEORIGIN", X-XSS-Protection:"1; mode=block", X-Content-Type-Options:"nosniff", X-Download-Options:"noopen", X-Permitted-Cross-Domain-Policies:"none", Referrer-Policy:"strict-origin-when-cross-origin", ETag:"W/"4c899233d87069c8f80da79c13c4dcff"", Cache-Control:"max-age=0, private, must-revalidate", X-Request-Id:"af0367ee-5204-452b-aea9-b49ae40b9c07", X-Runtime:"0.009164", Strict-Transport-Security:"max-age=31536000; includeSubDomains", "max-age=15768000", Vary:"Origin"]
2023-12-04 17:14:52.091  INFO [rxjava-and-spring-sleuth,8e9d1c9fead65b58,2d86758d9754864a] 21914 --- [pool-3-thread-2] c.e.r.RequestResponseLoggingInterceptor  : Headers      : [Server:"nginx/1.18.0 (Ubuntu)", Date:"Mon, 04 Dec 2023 11:44:52 GMT", Content-Type:"application/json; charset=utf-8", Transfer-Encoding:"chunked", Connection:"keep-alive", X-Frame-Options:"SAMEORIGIN", X-XSS-Protection:"1; mode=block", X-Content-Type-Options:"nosniff", X-Download-Options:"noopen", X-Permitted-Cross-Domain-Policies:"none", Referrer-Policy:"strict-origin-when-cross-origin", ETag:"W/"f5c223dbc7c6afb3507609a83c0adbac"", Cache-Control:"max-age=0, private, must-revalidate", X-Request-Id:"78e57367-e48b-4958-94e2-b6e186bcc0ab", X-Runtime:"0.012449", Strict-Transport-Security:"max-age=31536000; includeSubDomains", "max-age=15768000", Vary:"Origin"]
2023-12-04 17:14:52.092  INFO [rxjava-and-spring-sleuth,af855cc1c07de96c,c67bdecfa53bc526] 21914 --- [pool-3-thread-1] c.e.r.RequestResponseLoggingInterceptor  : Response body: {"id":4876,"uid":"0c26addb-cb29-4279-b4dd-e1fb7cfc061a","city":"Kimberliefort","street_name":"Toy Valley","street_address":"46585 Valentine Shoal","secondary_address":"Suite 519","building_number":"9927","mail_box":"PO Box 9180","community":"Park Court","zip_code":"35324-9167","zip":"71882","postcode":"80285-5638","time_zone":"Europe/Copenhagen","street_suffix":"Squares","city_suffix":"port","city_prefix":"Port","state":"Minnesota","state_abbr":"VT","country":"Kazakhstan","country_code":"SO","latitude":-45.18655087019896,"longitude":85.33671235235875,"full_address":"802 Jon Run, West Marshaburgh, WY 37769-2197"}
2023-12-04 17:14:52.092  INFO [rxjava-and-spring-sleuth,8e9d1c9fead65b58,2d86758d9754864a] 21914 --- [pool-3-thread-2] c.e.r.RequestResponseLoggingInterceptor  : Response body: {"id":3758,"uid":"1235740f-e330-4098-92de-f491e80b596f","app_name":"Konklux","app_version":"3.1.9","app_author":"Kam Dooley Ret.","app_semantic_version":"3.7.8","app_major_version":"3.1.2","app_minor_version":"9.109.5","app_patch_version":"7.1.6"}
2023-12-04 17:14:52.092  INFO [rxjava-and-spring-sleuth,af855cc1c07de96c,c67bdecfa53bc526] 21914 --- [pool-3-thread-1] c.e.r.RequestResponseLoggingInterceptor  : Response End
2023-12-04 17:14:52.092  INFO [rxjava-and-spring-sleuth,8e9d1c9fead65b58,2d86758d9754864a] 21914 --- [pool-3-thread-2] c.e.r.RequestResponseLoggingInterceptor  : Response End

Attaching here complete source code. Please assist on this.
Using
Java8
Sleuth version: 3.1.2
Spring cloud: 2021.0.2
Spring boot: 2.6.0
cc: @marcingrzejszczak

Spring Cloud Sleuth is out of oss support (https://spring.io/projects/spring-cloud-sleuth#support).

The only thing that comes to my mind is that you would need to wrap a Scheduler that it stores a previous Span and continues it when the signal is processed, but I'm not an expert in RxJava by no means


Integrating server client

Work still under progress merging to main just to share the latest work

Work still under progress but merging the branch to main just to update latest work


Add ruby 2.4 to travis (bump 2.2 and 2.3 versions)

Add ruby 2.4 and bump the 2.2 and 2.3 versions tested in travis

👍

Done...
thanks!


IntelliSense marks all callables in VS 2019 as "already exists"

Describe the bug
When I open a project in VS 2019, IntelliSense often errorneously underlines all callables with red squiggles, claiming "QS6001 A function or operation already exists". The build passes (correctly), since these callables are defined only once.
To Reproduce
I cannot pinpoint what exactly causes this; it often happens if I've worked with this project before, and deleting bin and obj folders before restarting VS sometimes helps, but right now I'm looking at a restarted VS for which it didn't. QDK version in the project not matching extension version might factor in
Expected behavior
IntelliSense only reporting callables that are indeed duplicates.
System information

Extension 0.20.2110.171573
.NET Core 3.1.415
VS 16.11.5

This is tricky without repro steps - I haven't seen this, but something similar is a known issue when target packages are used. You are not using target packages, are you?

I'm using regular kata projects, and I get this behavior on multiple ones -
just opened the TruthTables kata from a fresh repository clone (so no old
builds of mismatched versions hanging around) and I'm getting this again.
On Thu, Nov 18, 2021 at 6:18 PM bettinaheim @.***>
wrote:

This is tricky without repro steps - I haven't seen this, but something
similar is a known issue when target packages are used. You are not using
target packages, are you?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/qsharp-compiler/issues/1256#issuecomment-973665797,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACNFAADFD37OFBVEHPXYXBTUMWXW5ANCNFSM5H5SNEVA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


[Bug]:   The prompt is not displayed in Chinese when entering the break

Version

[X] I'm using version 1.13.1

Known issues

[X] I've checked Known issues

Existing issues

[X] I've checked Existing issues

What operating system are you using?
macOS
Operating System Version
MacBook Pro 16 inch，2021,  version 12.5.1
Reproduction steps
1.start break on Mac
2.

the description does not display as chinese
...
Reproduces how often: 100%

Expected Behavior
The text is displayed in Chinese because I have checked that the translation already exists
Actual Behavior
The text is displayed in English
Relevant log output
No response
Preferences
No response
Additional information
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

The latest version does not have this problem


Fixes #2984 by considering already existing framework:id node before …

…trying to migrate.

frameworkId will only be migrated if framework:id not already exists.
if a value is already stored in framework:id, this value wins
added tests to verify correct behaviour

I made the frameworkId migration part a little more verbose so we can see in the logs what happened.
Note: This will need to be cherry picked into releasing-0.14

LGTM! Please confirm my comment, though.
Waiting for the tests.


Open Source Community Collaboration Invitation.

Hello Developer Team,
I am the author of the GeneralUpdate open source project, which is a cross-platform desktop client upgrade component. I would like to invite your team to contribute an interface for automatic updates. It would be my honor if I could successfully extend this invitation to you.
The communities that have already been invited can be found here:
https://github.com/GeneralLibrary/GeneralUpdate-Samples/tree/main/UI

可以，我去看看，为社区做点贡献

好的，期待您的贡献。


bug: ad happened

🔍 Is there already an issue for your problem?

[X] I have checked older issues, open and closed

ℹ Environment / Computer Info
- Spotify version:
- Spicetify version:

📦 Extension name
ad block
📝 Description
I am finding that ad blocking is not working as intended. I have verified the settings in my browser, and they appear to be correct. However, I am still receiving advertisements. I have attempted to refresh the page, but this did not resolve the issue.
📸 Screenshots
No response

You did not fill the template with versions. Closing


Create methods in data_warehouse to add measurement information

In this order:

[x] units methods
[x] measurementgroup methods
[x] measurementtype methods
[x] category methods
[x] measurementtypetogroup methods
[x] boundsint, boundsreal and boundsdatetime methods

Dependencies:

units depends on study
measurementgroup depends on study
measurementtype depends on study and (optionally) units
category depends on study and measurementtype
measurementtypetogroup depends on study, measurementgroup and measurementtype
boundsint, boundsreal and boundsdatetime depend on study and measurementtype

The data addition methods should not permit an entry to be created unless the dependencies are satisfied and exist.

Implemented with https://github.com/NewcastleRSE/data-warehouse-client/pull/11


Transferoperator in COOrdinate format

This draft PR contains the code for a TransferOperator using COO format. Alongside this will be a PR for TransferOperator with CSC format. As of when I am writing this, neither have been tested! I just wanted to have them up so one can see what the code will look like, gauge code complexity, etc.
I will add comments about the testing / benchmarking results once those are finished.

A (mostly) working version of the COO transferoperator is now up as well. It seems to have trouble converging on eigenvalues sometimes, though. I'm still looking into it.


Add setup for building a documentation with Sphinx

This PR adds a configuration for Sphinx to build documentation for twisterV2.
To build documentation use tox:
tox -e docs
Documentation is created in build/html directory.

Codecov Report

Merging #15 (adf2a2a) into main (7d5ded7) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
- Coverage   75.49%   75.42%   -0.08%
==========================================
  Files          37       37
  Lines        1355     1355
==========================================
- Hits         1023     1022       -1
- Misses        332      333       +1

Impacted Files
Coverage Δ

src/twister2/device/native_simulator_adapter.py
90.32% <0.00%> (-1.08%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gmarull I believe all your comments were addresses. Can you have another look?


Simplify components serialization

Simplify writing all components and also speed the whole thing up.

Codecov Report

:exclamation: No coverage uploaded for pull request base (mirror@6d33fae). Click here to learn what that means.
The diff coverage is 0%.

@@           Coverage Diff            @@
##             mirror    #139   +/-   ##
========================================
  Coverage          ?   6.47%
========================================
  Files             ?      29
  Lines             ?    6274
  Branches          ?     873
========================================
  Hits              ?     406
  Misses            ?    5855
  Partials          ?      13

Impacted Files
Coverage Δ

Mirror/Runtime/NetworkIdentity.cs
0% <0%> (ø)

Mirror/Runtime/NetworkServer.cs
0% <0%> (ø)

Mirror/Runtime/NetworkBehaviour.cs
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d33fae...d21ffc8. Read the comment docs.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Issue#389 Solved

Related Issue
Resolved Navbar and Footer Responsiveness for devices having less than 400px width
Closes: #389
Describe the changes you've made
I used media queries to solve responsiveness of Navbar and Footer having width less than 400px.
Type of change
What sort of change have you made:

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Code style update (formatting, local variables)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Documentation update.
[x] This change requires a documentation update

How Has This Been Tested?
Using the dev tools and checking for each and every devices. Adjusting width.
Checklist

[x] My code follows the guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented on my code, particularly wherever it was hard to understand.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have added tests that prove my fix is effective or that my feature works.
[x] Any dependent changes have been merged and published in downstream modules.

Screenshots (if applicable)

Original
Updated

original screenshot
updated screenshot

Original

Updated

Code of Conduct

[x] I agree to follow this project's Code of Conduct

Hello @Vidip-Ghosh 👋 Thanks a lot for your work and your contribution. Unfortunatly, i'm not seeing navbar issue since 67b0327 fixed it!
You can test more here: https://webxdao.xyz/
Can you verify if you still facing this issue?

Working fine for all devices and Navbar is alright in home page but I still found the following in Contributors Page:

Oh, well spotted for the contributors page. But it's isn't the navbar, it's due too ContributorCard which have padding in pixel.. 🙈

Even footer is also causing the issue.

Hello @Vidip-Ghosh 👋 Thanks a lot for your work and your contribution. Unfortunatly, i'm not seeing navbar issue since 67b0327 fixed it!
You can test more here: https://webxdao.xyz/
Can you verify if you still facing this issue?

Working fine for all devices and Navbar is alright in home page but I still found the following in Contributors Page:

Oh, well spotted for the contributors page. But it's isn't the navbar, it's due too ContributorCard which have padding in pixel.. 🙈

Even footer is also causing the issue. Actually, in dark mode I observed that some in footer some portion was in black instead of violet.

Mmm, that's strange.. Let's continue this together. 🤝
We just merged opened PR, this maybe caused the production code to have issues. In the last pr merged, the footer get some fix (Btw it cause a merge conflict on this PR, i can help you to fix it).
Can you merge main in this PR to see if the issue still persist ?

@WebXDAO/gssoc-mentors Hi :wave: What is the state of this PR?

any update on this?

any update on this?

It seems to be alright. You can close this PR

It seems to be alright. You can close this PR

Thanks! Will close this now 🚀


Added Builder Tool: Cardano Light Tools

Name: Cardano Light Tools
Description: A set of lightweight tools to operate and maintain a Cardano Stake Pool. Focuses on simplicity, low resource utilization (CPU, memory) and portability across platforms.
Link: https://github.com/orpheus-antpool/cardano-light-tools
Source: https://github.com/orpheus-antpool/cardano-light-tools
Tags:

operatortool

Hi,
Just following the guidelines, the 'current status' of repo versus description seems to be off, as the repo provides atm a single tool for monitoring metrics.

@rdlrt: the intent is to provide multiple mini-tools. Of course, in the beginning, we have to start with one. Would it make more sense to submit a separate request for each mini-tool?

For consistency in approvals, I would say can start by having description for current status - and edit in future once there are more?

Sounds good, I'll keep the description up to date


feat: add wxt suite

https://github.com/wxt-dev/wxt
https://github.com/wxt-dev/wxt/issues/241

Thanks for the PR @btea! You'll also need to add wxt to the workflows. Check out the files modified when Remix was added: https://github.com/vitejs/vite-ecosystem-ci/pull/275/files
A question about the tests in wxt. I think these will be useful given that we don't have a similar project being tested right now. It would be interesting to know your take, and what kind of things you think will have more coverage because wxt is also part of vite-ecosystem-ci.

@aklinker1  did you have a chance to look at this yet?


REFACTOR-#5607: Fix missing formatting with 'black'

What do these changes do?

[x] first commit message and PR title follow format outlined here

NOTE:  If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

[ ] passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
[ ] passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
[ ] signed commit with git commit -s
[ ] Resolves #5607
[ ] tests added and passing
[ ] module layout described at docs/development/architecture.rst is up-to-date

@dchigarev if these changes are not compatible with previous versions of black, then we must update our environments by adding black minimum version.

@dchigarev if these changes are not compatible with previous versions of black, then we must update our environments by adding black minimum version.

All of the changes are actually backward compatible, meaning that the old 'black' won't complain about this new formatting. The only lines that cause problems are these two at test_series.py. I've marked them as # fmt: skip as the latest black + latest flake8 can't agree on how to format this place.

@anmyachev does test_io failure should be fixed in #5603?

@anmyachev does test_io failure should be fixed by #5603?

I believe so

@anmyachev does test_io failure should be fixed by #5603?

I believe so

Well, we can't get green CI on these PRs separately then... One of them has to be merged with failing CI, unfortunately.
@modin-project/modin-core, opinions, what should we do?

@anmyachev does test_io failure should be fixed by #5603?

I believe so

Well, we can't get green CI on these PRs separately then... One of them has to be merged with failing CI, unfortunately.
@modin-project/modin-core, opinions, what should we do?

It's just a code style change, it's very unlikely that something will break, let's just merge it and fix another problem.


simplify way to change user's expiry/reminder dates

Signed-off-by: mshneorson<EMAIL_ADDRESS>

show the edit icon only if the member has not expired.

expiry edit must be available at all times.


GMA Network

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I remove or skip any mandatory* field

Checklist

[X] I'm reporting a new site support request
[X] I've verified that I'm running yt-dlp version 2022.11.11 (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that none of provided URLs violate any copyrights or contain any DRM to the best of my knowledge
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[X] I've read about sharing account credentials and am willing to share it if required

Region
Worldwide
Example URLs
https://www.gmanetwork.com/
https://www.gmanetwork.com/fullepisodes/
https://www.gmanetwork.com/fullepisodes/home/more_than_words/87059/more-than-words-full-episode-80/video?section=home
https://www.gmanetwork.com/fullepisodes/home/running_man_philippines/168677/running-man-philippines-catch-the-thief-full-chapter-2/video?section=home
https://www.gmanetwork.com/music/artists/gmamusic/165/sanyalopez/artist/ => https://aphrodite.gmanetwork.com/records/songs/Hot-Maria-Clara.mp3
https://www.gmanetwork.com/radio/streaming/dzbb
https://www.gmanetwork.com/regionaltv/
https://www.gmanetwork.com/entertainment/tv/kapuso_stream/videos/#176114
Provide a description that is worded well enough to be understood
The site is a Philippines based TV network, and which is currently not supported by the yt-dlp.
I have seen some videos are embedded from YouTube or daily motion.
Please have a look into the site for the possible support.
There are few exclusive contents like tv dramas  restricted to south east asia or around Philippines due to the license (eg. https://www.gmanetwork.com/gtv/drama/the_merciless_judge/175785/the-merciless-judge-the-devil-judge-becomes-an-evil-doctor-episode-9/video).
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
yt-dlp -vU https://www.gmanetwork.com/fullepisodes/home/running_man_philippines/168677/running-man-philippines-catch-the-thief-full-chapter-2/video?section=home
[debug] Command-line config: ['-vU', 'https://www.gmanetwork.com/fullepisodes/home/running_man_philippines/168677/running-man-philippines-catch-the-thief-full-chapter-2/video?section=home']
[debug] User config "C:\Users\USER\AppData\Roaming\yt-dlp\config.txt": ['-o', 'E:\\yt-dlp_dls\\%(title)s.%(ext)s', '--sub-langs', 'en.*', '--extractor-args', 'youtube:skip=translated_subs', '--embed-subs', '-f', '((137/136)+140)/mpd-4/1/500/(hls-3462/hls-3192/hls-1960/hls-1660)', '--merge-output-format', 'mp4', '--ignore-no-formats-error', '-i', '--no-abort-on-error']
[debug] Encodings: locale cp1252, fs utf-8, pref cp1252, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version 2022.11.11 [8b64402] (win_exe)
[debug] Python 3.8.10 (CPython AMD64 64bit) - Windows-10-10.0.19043-SP0 (OpenSSL 1.1.1k  25 Mar 2021)

[debug] exe versions: ffmpeg n5.1.2-9-g807afa59cc-20221210 (setts), ffprobe n5.1.2-9-g807afa59cc-20221210, phantomjs 2.1.1
[debug] Optional libraries: Cryptodome-3.15.0, brotli-1.0.9, certifi-2022.09.24, mutagen-1.46.0, sqlite3-2.6.0, websockets-10.4
[debug] Proxy map: {}
[debug] Loaded 1723 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Latest version: 2022.11.11, Current version: 2022.11.11
yt-dlp is up to date (2022.11.11)
[debug] [generic] Extracting URL: https://www.gmanetwork.com/fullepisodes/home/running_man_philippines/168677/running-man-philippines-catch-the-thief-full-chapter-2/video?section=home
[generic] video?section=home: Downloading webpage
WARNING: [generic] Falling back on generic information extractor
[generic] video?section=home: Extracting information
[debug] Looking for embeds
ERROR: Unsupported URL: https://www.gmanetwork.com/fullepisodes/home/running_man_philippines/168677/running-man-philippines-catch-the-thief-full-chapter-2/video?section=home
Traceback (most recent call last):
  File "yt_dlp\YoutubeDL.py", line 1485, in wrapper
  File "yt_dlp\YoutubeDL.py", line 1561, in __extract_info
  File "yt_dlp\extractor\common.py", line 674, in extract
  File "yt_dlp\extractor\generic.py", line 2721, in _real_extract
yt_dlp.utils.UnsupportedError: Unsupported URL: https://www.gmanetwork.com/fullepisodes/home/running_man_philippines/168677/running-man-philippines-catch-the-thief-full-chapter-2/video?section=home

Ingle videos have been implemented, but not playlists.


Save analyzed packages

Closes #227
Signed-off-by: Jason Lam<EMAIL_ADDRESS>

Thanks for the PR!
We'll take a look at this PR next week.


SQL Targets: varchar columns generally require maxlength

Migrated from GitLab: https://gitlab.com/meltano/sdk/-/issues/371
Originally created by @tbriggs2 on 2022-05-04 15:27:03

Summary
Most databases require a max length to be specified for varchar columns. Not all do (SQLite, Postgres, and Snowflake do not) but most do. The SDK currently creates varchar columns without a max length and thus table creation fails when the DB requires it. If the schema provided by the tap provides a max length it should be used.
Steps to reproduce

Create a SQL target using the SDK for a database such as MySQL
Feed the target data with a stream containing a string field where the schema record specifies a max length

What is the current bug behavior?
Creation of the table in the destination DB will fail due to a lack of a length.
What is the expected correct behavior?
If the tap provides a max length in the schema record it should be used.
Possible fixes
The relevant code is in singer_sdk/typing.py. MR incoming too.

View 3 previous comments from the original issue on GitLab


update headings documentation

Update of the heading docs (H2, H3, H4, H5, H6)

Thank you for the pull request but the component was rewritten completely.


Cannot resolve tilde character in Gardener store configuration

Example configuration.
  config:
    gardenerAPIKubeconfigPath: "~/.kube/kubeconfig/kubeconfig-garden-core.yaml"

Close for now due to low priority.


sync: release 0.38.x

What type of PR is this?
/kind release
Any specific area of the project related to this PR?
What this PR does / why we need it:
Cherry picks various PRs from master. Should be last sync before the release.

https://github.com/falcosecurity/falco/pull/3208
https://github.com/falcosecurity/falco/pull/3212
https://github.com/falcosecurity/falco/pull/3217
https://github.com/falcosecurity/falco/pull/3219

Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/milestone 0.38.0

/unhold

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, LucaGuerra
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP,LucaGuerra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP, LucaGuerra
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP,LucaGuerra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Ability to intercept links

Currently, markymark handles opening all links internally in AttributedInteractiveLabel with:
 @objc func didTap(_ tapGesture:UITapGestureRecognizer) {
        guard let view = tapGesture.view else { return }

        let locationInView = tapGesture.location(in: view)
        if let url = getUrlAtLocationInView(locationInView) {
            UIApplication.shared.openURL(url)
        }
    }

I would like to be able to intercept link handling and handle them myself. This would let me use SFSafariViewController to open the link or perform other actions. What would be the be the best way to bring this capability to markymark? Originally I was thinking of adding a link handler on AttributedInteractiveLabel like so:
let linkHandler: ((_ link: URL) -> Void)? = nil

...

@objc func didTap(_ tapGesture:UITapGestureRecognizer) {
    guard let view = tapGesture.view else { return }

    let locationInView = tapGesture.location(in: view)
    if let url = getUrlAtLocationInView(locationInView) {
        if let handler = linkHandler {
            handler(url)
        } else {
            UIApplication.shared.openURL(url)
        }
    }
}

Given how it's used internally I'm not sure that's the right approach.

Hi @illyabusigin,
I just created https://github.com/M2Mobi/Marky-Mark/pull/74, this will allow injecting opening url behavior by providing an implementation of URLOpener to Markymark. I will let you know when this feature is released.

Just release the new version!


feat: allow loading tls certificate in ioredis

closes https://github.com/quirrel-dev/quirrel/issues/1031

If there is anything more I should take care of, let me know @Skn0tt !

looks great! thanks for addressing all my comments so swiftly :)

looks like CI is failing. I'll do some debugging around the failing E2E tests. The Docker push step should hopefully be fixed by https://github.com/quirrel-dev/quirrel/pull/1035.

the failure of the v14 step doesn't seem like it's related to this PR. merging!


FileChooser unusable with dirselect:True

If you use FileChooser with dirselect set to True, and you double click the directories (required because of dirselect), your clicks seem to be registered twice which basically makes FileChooser unusable.
This was working fine in Kivy 1.8 and stopped working either in 1.9.0 or 1.9.1
from kivy.app import App
from kivy.uix.boxlayout import BoxLayout
from kivy.lang import Builder

from os.path import join, isdir

Builder.load_string("""
<MyWidget>:
    FileChooserListView:
        filters: [root.is_dir]
        dirselect: True
""")

class MyWidget(BoxLayout):
    def is_dir(self, directory, filename):
        return isdir(join(directory, filename))

class MyApp(App):
    def build(self):
        return MyWidget()

if __name__ == '__main__':
    MyApp().run()

Sigh... I just noticed this is a duplicate of #3708 which has already been fixed and merged (to 1.9.2?)


Slideshow from zip archive

Great app :-) One feature request, sometimes I upload images in a zip archive. It would be good to start the slideshow directly from the zip, without unpacking. Similar concept like comics, the CBZ or CBR file types.

That's a neat idea! I haven't worked on this app for a long time but will definitely keep this on the planned features list


How train the model for the detection of Waymo test dataset?

Hello, thanks you excellent work. I want to how train the model for the detection of Waymo test dataset. In the pillarnet, I train the model in the train dataset, use trained model to detect waymo test dataset, but the result not perfect.

@StiphyJay

Hello, thanks you excellent work. I want to how train the model for the detection of Waymo test dataset. In the pillarnet, I train the model in the train dataset, use trained model to detect waymo test dataset, but the result not perfect.

Add the val set to train, could improve the performance in test set.


Maybe unsound in store

Hello, thank you for your contribution in this project. I am scanning the unsound problem in rust project and I notice the following code.
pub fn store(ts: *mut ffi::PyThreadState) -> PyThreadStateUnlimited {
    match VERSION.1 {
        6 => {
            let ts = ts as *mut PyThreadStateUnlimited3_6;
            unsafe {
                let unlimited = PyThreadStateUnlimited {
                    frame: (*ts).frame,
                    recursion_depth: (*ts).recursion_depth,
                    exc_type: (*ts).exc_type,
                    exc_value: (*ts).exc_value,
                    exc_traceback: (*ts).exc_traceback,
                    ..Default::default()
                };
                (*ts).frame = std::ptr::null_mut();
                (*ts).recursion_depth = 0;
                (*ts).exc_type = std::ptr::null_mut();
                (*ts).exc_value = std::ptr::null_mut();
                (*ts).exc_traceback = std::ptr::null_mut();
                unlimited
            }
        }
...................................

consider this is a pub fn and loader is a pub mod, I assume the user can direct call the store function. If the user pass a eg. null pointer to ts, it will lead to a UB in rust.

if there is no external usage for store, maybe we should mark it as pub(crate) or mark it as unsafe?

same for https://github.com/MegEngine/MegFlow/blob/41cb9f85828aa080f6004674904fe430d8268052/flow-rs/src/loader/python/unlimited.rs#L249


replace usage of options with cli

and do the necessary refactoring.
Fixes #92

there is some flakyness in how errors are printed to stderr, gonna investigate how to fix this.

@mfelsche should this be "do not merge for now"?

This is good to go from my side. Fixed the test issue. Depends on if you want to have the renaming get merged first.

I've built this locally and took it for a spin.
One change in behaviour I've noticed is when using stable env CMD with a CMD that has parameters. Concretely: with stable from master, I could do
$ stable env ponyc --debug jylis/

with this branch, it fails,
$ stable env ponyc --debug jylis/
Error: unknown long option at: 'debug'

usage: stable [<options>] <command> [<args> ...]
[...]

but passes when using --:
$ stable env -- ponyc --debug jylis/

Now, I'm not saying that this is incorrect -- my expectations aren't violated, putting -- after stable env is the proper thing to do in this case -- it's just a small change in behaviour we might want to make users aware of when releasing this? 😃

This change was actually not intended, but it makes total sense to me. Previously it was interpreting a simple call of stable env as calling the  env executable, which might not be intended after all. So this explicit separation with -- is an improvement imho.
I just think, I need to update the documentation in that respect. And check if cli catches all edge-cases. Gonna update the PR shortly.

Discussed at Sync. We will merge this once we renamed to tack

Feels weird to approve my own PR. But this is good to go from my side, if it is good for you @SeanTAllen


File (Explorer) tab randomly disappear

I don't understand why and how to reproduce this bug, but just sometimes the 'File' tab in the left panel (see attachment) randomly disappears. I have to later get it back by going to menu View/ Explorer. After that, the tab is back.
Please note that there is no recent extension installation. I've been working with my current set of extensions for quite a long time and this issue happens recently
Update: I see that it happens more when I use Ctrl + Shift + F to do search

Windows 10

This tab

Bug happens

I can not reproduce. Can you reproduce using Visual Studio Code Insiders https://code.visualstudio.com/insiders/

hi @isidorn, Insiders version doesn't have this behavior

Then the issue is probably related to on of your extensions. I suggest that you disable them one by one. Or to swtich to insiders.
Anyways there is nothing actionable we can do here, thus closing this issue

Okay, thanks @isidorn
I just wanna get back to you that even I disabled all my extensions, the problem is still there. Seems like switching to the insiders version is the only choice for me in this case.


MissingSubscription

Hi,
I'm getting an error message after running command
I'm user access administrator and owner on subscription

Create a new role assignment by subscription and object. By default, the role assignment will be tied to your default subscription. Replace $subscriptionId with your subscription ID, $resourceGroupName with your resource group name, and $assigneeObjectId with generated assignee-object-id (the newly created service principal object id).

$ az role assignment create --role contributor --subscription xxxxxxxxxxxxxxxxx --assignee-object-id xxxxxxxxxxxxxxxxxxxxxxxxx --assignee-principal-type ServicePrincipal --scope /subscriptions/xxxxxxxxxxxxxxxxxxxxxxxx/resourceGroups/rg-tst-mgt-mon-amba-01
(MissingSubscription) The request did not have a subscription or a valid tenant level resource provider.
Code: MissingSubscription
Message: The request did not have a subscription or a valid tenant level resource provider.

Hello @jerrolmossel,
in our deployment and as per our deployment guide, we do not create any new role. We just do built-in role assignment as you can see in the documentation at Azure Monitor Baseline Alserts.
Could you please clarify which part of the documentation you are following and what goal are you trying to achieve.
Thanks.

Hi @Brunoga-MS

Configure and run the workflow
First, configure your OpenID Connect as described here.

Use the Azure login action with OpenID Connect
Create a Microsoft Entra application and service principal
Using Azure CLI

Hi @jerrolmossel,
thanks for pointing me to the right direction. You seem to have issue with some prerequisites that falls outside of AMBA documentation and support (they are part of Microsoft Docs). However, I tried to run that part and was successful. The only think I noted is that the you need to pass the ObjectId of the Enterprise Application and not the one of Application Registration during execution of command at step 3 as per your first message.
Let me know if that helps.

Hi @Brunoga-MS
I managed to create it via Azure portal. First I had dive into the subject app registrations versus enterprise applications for good understanding.
After this works I will try it again with cli or ps.
Thank you for so far.


fix: Fix Platform Detection Logic on Fabric

Related Issues/PRs
Based on Internal Bug Reports
What changes are proposed in this pull request?
Fix wrong platform detection result when the utility function is first run in a thread with no spark context access.
How is this patch tested?

[ ] I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change any dependencies?

[x] No. You can skip this section.
[ ] Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

[x] No. You can skip this section.
[ ] Yes. Make sure you have added samples following below steps.

/azp run

/azp run

/azp run

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 2.05%. Comparing base (a8820fe) to head (2ae32b0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #2234       +/-   ##
==========================================
- Coverage   86.23%   2.05%   -84.18%
==========================================
  Files         327     327
  Lines       16715   16715
  Branches     1495    1495
==========================================
- Hits        14414     344    -14070
- Misses       2301   16371    +14070

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[wish] Additional remappings for Microsoft Natural Ergonomic 4000 Keyboard

I have a Microsoft Natural Ergonomic 4000 Keyboard, and Karabiner neatly allows me to swap the left-side modifier keys to the Mac-native order in Device Specific Mixed Settings / For Microsoft Natural Ergonomic 4000 Keyboard (UK). The option Use Windows Key as Option remaps COMMAND_L to OPTION_L, and the option Use Alt Key as Command remaps OPTION_L to COMMAND_L. That's great.
However, the old Microsoft keyboard driver (which no longer works on El Capitan) also had an additional option to swap the right-side modifier keys. So I'd like to suggest the following changes:

Keep the checkbox Use Windows Key as Option that remaps COMMAND_L to OPTION_L,
Rename the checkbox Use Alt Key as Command to Use Left Alt Key as Command and keep it to remap OPTION_L to COMMAND_L (which it currently does).
Add a checkbox Use Right Alt Key as Command and make it remap OPTION_R to COMMAND_R.
Add a checkbox Use Application Key as Option and make it remap PC_APPLICATION to OPTION_R.

These four settings together would give back the options available in the Microsoft driver.
Below is the updated contents of include/checkbox/devices/microsoft_natural_ergonomic_keyboard.xml that reflects those changes. For now, I have placed this into the private.xml file and disabled Misc & Uninstall / Use prepared settings. It works great! Thank you for making Karabiner, it’s fantastic! :)
<?xml version="1.0"?>
<root>

  <!-- Dave Griffin customisation for the Microsoft Natural Ergonomic Keyboard 4000 (UK) -->

  <item>
    <name>For Microsoft Natural Ergonomic 4000 Keyboard (UK)</name>

    <item>
      <name>fix Backquote(`) key</name>
      <identifier>remap.microsoft_natural_ergonomic_keyboard.fix_backquote</identifier>
      <device_only>DeviceVendor::MICROSOFT, DeviceProduct::MICROSOFT_NATURAL_ERGONOMIC_4000</device_only>
      <!-- note that BACKQUOTE is actually BACKSLASH, and UK_SECTION is the real BACKTICK -->
      <autogen>__KeyToKey__ KeyCode::BACKQUOTE, KeyCode::UK_SECTION</autogen>
    </item>

    <item>
      <name>fix backslash(\) key</name>
      <identifier>remap.microsoft_natural_ergonomic_keyboard.fix_backslash</identifier>
      <device_only>DeviceVendor::MICROSOFT, DeviceProduct::MICROSOFT_NATURAL_ERGONOMIC_4000</device_only>
      <!-- UK_SECTION to BACKQUOTE - makes the actual backslash key sends backslash ! -->
      <autogen>__KeyToKey__ KeyCode::UK_SECTION, KeyCode::BACKQUOTE</autogen>
    </item>

    <item>
      <name>Use Windows Key as Option</name>
      <identifier>remap.microsoft_natural_ergonomic_keyboard.Windows_key_as_Option</identifier>
      <device_only>DeviceVendor::MICROSOFT, DeviceProduct::MICROSOFT_NATURAL_ERGONOMIC_4000</device_only>
      <autogen>__KeyToKey__ KeyCode::COMMAND_L, KeyCode::OPTION_L</autogen>
    </item>

    <item>
      <name>Use Left Alt Key as Command</name>
      <identifier>remap.microsoft_natural_ergonomic_keyboard.Alt_key_as_Command</identifier>
      <device_only>DeviceVendor::MICROSOFT, DeviceProduct::MICROSOFT_NATURAL_ERGONOMIC_4000</device_only>
      <autogen>__KeyToKey__ KeyCode::OPTION_L, KeyCode::COMMAND_L</autogen>
    </item>

    <item>
      <name>Use Right Alt Key as Command</name>
      <identifier>remap.microsoft_natural_ergonomic_keyboard.Right_Alt_key_as_Command</identifier>
      <device_only>DeviceVendor::MICROSOFT, DeviceProduct::MICROSOFT_NATURAL_ERGONOMIC_4000</device_only>
      <autogen>__KeyToKey__ KeyCode::OPTION_R, KeyCode::COMMAND_R</autogen>
    </item>

    <item>
      <name>Use Application Key as Option</name>
      <identifier>remap.microsoft_natural_ergonomic_keyboard.Application_key_as_Option</identifier>
      <device_only>DeviceVendor::MICROSOFT, DeviceProduct::MICROSOFT_NATURAL_ERGONOMIC_4000</device_only>
      <autogen>__KeyToKey__ KeyCode::PC_APPLICATION, KeyCode::OPTION_R</autogen>
    </item>

    <item>
      <name>Swap @ and double-quote(") Done by default if 'British PC'keyboard already specified?</name>
      <!-- this is done by default it seems -->
      <identifier>remap.microsoft_natural_ergonomic_keyboard.switch_doublequote</identifier>
      <device_only>DeviceVendor::MICROSOFT, DeviceProduct::MICROSOFT_NATURAL_ERGONOMIC_4000</device_only>
      <autogen>__KeyToKey__ KeyCode::KEY_2, MODIFIERFLAG_EITHER_LEFT_OR_RIGHT_SHIFT, KeyCode::QUOTE, ModifierFlag::SHIFT_L</autogen>
      <autogen>__KeyToKey__ KeyCode::QUOTE, MODIFIERFLAG_EITHER_LEFT_OR_RIGHT_SHIFT, KeyCode::KEY_2, ModifierFlag::SHIFT_L</autogen>
    </item>

  </item>

</root>

Thank you!
I've updated prepared settings at Karabiner 10.14.10.
Please confirm the latest beta version.
How to upgrade to the latest beta version:
https://pqrs.org/osx/karabiner/document.html#check-for-updates

The above changes do not work with the latest version. Have all of them ticket, yet, the ALT key is not linked to the command key.

@binarykitchen Karabiner does not work if you installed IntelliType. Please confirm that IntelliType is not installed in your system.

@tekezo confirming here, it is intellitype is not installed. still does not work ...

@binarykitchen Could you show me the EventViewer result in the following cases?
https://pqrs.org/osx/karabiner/document.html.en#eventviewer

Press the ALT key with Karabiner settings are enabled.
Press the ALT key with Karabiner settings are disabled.

If both results are same, I guess you've installed another keyboard driver that is conflicting with Karabiner.
Please show me your loaded kexts by this command in Terminal.

Open Terminal app from Launchpad.
Execute this command in Terminal.

kextstat | grep -v com.apple

before i do that, i let you know that i am using another trick to make it work. in mac os, under settings > keyboard > modifier keys i remapped the keys to their commands there. without karabiner and seems to work fine so far.

@binarykitchen OK, you can do that way. Please consider using Karabiner if you want to change the left and right modifiers separately.

sweet, all good then

check out #703


Async

We don't want to slow pages down, so push onto a queue and send data out of band.

Workaround: Don't use await when doing calls, just use client.call({...}).finally(() => {}) to send request and not wait for it


sorting breaks for line and area marks

Hi - you can observe this in Polestar as well - if you choose line or area types and try to sort, it breaks in visually interesting ways. It looks like the axes are sorted, but the vectors connecting the points aren't aware of the sorting.
I'm doing the following, and the axes are sorted correctly and for bar and point types it works (all my aggregations are done server-side, hence the aggregate: 'max'):
        spec.encoding.x.sort = [{
           name: 'y',
           aggregate: 'max',
           reverse: true
         }];

The problem seems to relate to the sort attribute on the scales overriding the data sorted via a transform. It also looks like Vega itself sorts ordinal scales even if the sort field is not set, and since nominal maps to ordinal scales, it gets sorted lexicographically. While this makes sense for ordinal values, it's a bit arbitrary for nominals. In particular, when plotting quantitative against nominal, I think that what you'd normally want is to sort the nominal by the values of the quantitative scale.

Thank you for reporting.  We plan to fix this after we migrate to use Vega 2 :)

I noticed some traces of the migration in the vega-lite code, thanks. Are there any blockers for the migration? If not then I can take a crack at it.

@richardhundt  we wanted to create more tests, refactor code and fix some bugs before migrating.

@richardhundt Do you have an example spec / data that I can test this?

Sort property is totally rewritten based on changes in Vega 2.  So I do not think this issue is no longer applicable.  If you find similar problems with the current version of Vega-Lite, please re-create another issue.


bump springboot and dependents

What and why?
How to test?
Trello

/deploy harrisonj

/deploy harrisonj

/deploy manna

/deploy manna


fix cargo test error when running rebar3 eunit

fix rebar3 eunit error when processing cargo test output bellow

running 1 test
test tests::it_works ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

Thanks for this, but is there maybe a way how we can get rid of the non-JSON output messages?

It will be better if any option can be pass to cargo-test to suppress output like above. But I don't find any usefully option from cargo-test help.

This is outdated, I found a parameter combination to make the additional output at least JSON.


SPQR discussion

Feature request
https://github.com/Vahe1994/SpQR
@TimDettmers already published on Twitter, the new 3.35 bit per parameter technique by SPQR
I am watching the progress and in the near time they want to add the inference code.
Motivation
https://github.com/huggingface/text-generation-inference/pull/438
As there is already an PR for gptq which still needs more than 4 bit per parameter in 4bit precision I thought maybe you are open for that new technique too.
Your contribution
While I just tried the inference server the first time today (shame on me) and directly added to some production deployments as replacement I am very new in that code base.
If the inference code is published I could give it a try to adapt it to this repository, but if the authors themselves or the inference server team already have plans to take that part I definitely won't be sad about it 😁

Hello!
Thanks for your interest in this repo and in spqr! We are communicating with tim to add spar to tgi as soon as possible so stay tuned :)

Hi Olivier, just for interest
Did they told you any kind of information about the time ?
It seems like the dedup PR of SPQR will be merged soon and hopefully the save function for models will follow fast.

https://github.com/Vahe1994/SpQR/pull/32
Just found that model saving is WIP


wrapCompilerAsTypeGuard and wrapValidatorAsTypeGuard are not usable in Deno build

Hello! First off thanks for writing this library! It's awesome and just keeps getting better!
One thing I noticed is in the Deno build the wrapper functions cannot be used because its packaged as only type definitions and the implementations are stripped by rollup
https://github.com/ThomasAribart/json-schema-to-ts/blob/d8faafb4603aab1e0496858bd727f591940cc137/builds/deno/index.d.ts#L307
https://github.com/ThomasAribart/json-schema-to-ts/blob/d8faafb4603aab1e0496858bd727f591940cc137/builds/deno/index.d.ts#L312
Trying to import it and use it throws
error: SyntaxError: The requested module<EMAIL_ADDRESS>does not provide an export named 'wrapCompilerAsTypeGuard'

I fixed it by just adding the implementation real quick and changing it to a .ts file since Deno doesnt always play nice with .d.ts files. That may not work the best with your rollup setup though and im sure you know a more compatible fix!

Hi @curtislarson ! Good catch, thanks for the heads up.
It seems that I now export more than types but forgot to modify the rollup configuration for deno export: https://github.com/ThomasAribart/json-schema-to-ts/blob/master/rollup.config.js
I'm gonna look into that !

Hi @curtislarson ! I found https://www.npmjs.com/package/@rollup/plugin-typescript which seems to bundle the typescript in cjs or esm.
I could use it along with dts to export an index.js in parallel to the index.d.ts. BUT I'm not sure if this is the best approach. Wouldn't it be better to simply export a single index.ts file ? Sorry, I'm not familiar with Deno.

@ThomasAribart The .js and .d.ts is a valid approach that some libraries like esbuild take with the <reference types notation.
I think most Deno people prefer importing from ts files since they may not be aware of the typing inclusion in the js file or would have to do the awkward @deno-types annotation. Definitely make sure it's ESM though and people can import it directly from github / unpkg / denoland / esm etc
Although honestly it feels like there will be a shift back to js extensions soon with typescript never allowing .ts imports and the shift away from typechecking in Deno. That's a bit too off topic though :)

https://gist.github.com/curtislarson/0253736b428c641411183cc41dec3202 This is pretty much what the file I use looks like, where you just import type/export type instead of import/export and include the function definitions.
Although you can go even further and use the optimized pinned urls from skypack...

@curtislarson Yes, that's what I had in mind. It sounds easy but it is in fact quite hard to automate :/ I couldn't find a rollup plugin that flattens ts like that. It seems simpler to export it as d.ts on one side and .js or .mjs on another.

I haven't experimented with them a lot but there are packages like unplugin and unbuild that seem to give you a lot of flexibility and additional options when it comes to generating output with rollup, esbuild, etc.

Sorry, those plugin don't allow to flatten ts filte easily either.
I've release a beta of v2.5.2 with the same d.ts as usual, but with js and mjs rollups containing both wrappers in cjs and esm. Can you try those and tell me if it works for you ? If it does, I'll officially release the 2.5.2.
<EMAIL_ADDRESS>

@ThomasAribart I'm able to import them but have to manually specify the correct typings via @deno-types in order to get it working.

Which you can resolve by just reference the types in the .mjs/.js file

The banner option seems to have done the job 👍
Can you try the second beta<EMAIL_ADDRESS>

@ThomasAribart Yep this code worked for me
import {
  wrapCompilerAsTypeGuard,
  $Compiler,
  JSONSchema,
} from<EMAIL_ADDRESS>
import Ajv from<EMAIL_ADDRESS>
const instance = new Ajv();

const $compile: $Compiler = (schema: JSONSchema) => instance.compile(schema);

const wrapped = wrapCompilerAsTypeGuard($compile);

const validate = wrapped({
  type: "object",
  required: ["name"],
  properties: { name: { type: "string" } },
} as const);

const res = validate({ name: "Curtis" });
console.log(res); // true

I don't think the .js version will ever be compatible with Deno though unless exports is shimmed but the .mjs worked great.

Awesome 😎
Does the type guard work as well ?
if (validate(data)) {
  ... // data should be correctly typed here
}

If so, I'll release and close this issue tomorrow 👍
Cheers !

Yep it works perfect. Thanks for the fixes!


t2 linux

Thanks for the amazing work with mac speakers.
Probably you already know, there is a project call T2 linux. We are facing exact same issue with T2 mac speakers.
You work is so helpful for us.  I have been testing your tirs in my macbook 16.1 2019. Unfortunately they don't much exactly but is an starting point.
I just wanted to contact and  let you know that we are following your work.
If you need any help from me for testing stuff just let me know. I know that speakers are not exactly them same.
Subwoofer are very similar, tweeter no. Better try it,
https://wiki.t2linux.org/
https://discord.com/invite/68MRhQu
Thanks
Galder

Hi James,
thanks for your quick reply. I understand that must be difficult to find new models. Specially when macs are very expensive.
Maybe we could try by ourself and try to help you with other models. Also maybe find some student of sound engineering that would like to collaborate. It would be very useful if you could share your Carla, Rew scenes.
About last night IRs, I just want to give some feedback. Feel free to correct me if I'm wrong.
Basses sounds much better. But still I missing very low freq. In MacOS I can hear strong 40hz 30hz signal generated with Audacity.In Linux almost nothing. Maybe is model difference?
About using same IR for subwoofer, I think is correct, I believe their are dual opposed subwoofers. At least for 6 speakers models.
I could confirm it last night.  Decreasing one of the speakers I could notice a vibration, with 2 not vibration in my laptop. So I understand that they cancel each other. "High‑fidelity six‑speaker system with force‑cancelling woofers"
Tweeter are very high but probably because different models?  For now I need to decrease them 30%.
Overall,  I would say that it sounds much better,  like 70% of what MacOs does. Which is far much better that no dsp horrible sound!
Feel free to close this issue. If I need to contact you I can raise a new one or send you an email.
Also come by to the T2 group, there is many people collaborating there.
Feel free to contact  me if I can help with anything.
Thanks for everything, at least now I can watch a film in my linux mac :)
Galder

The current woofer IR has a HPF set at 50 Hz, which is why you can't hear anything below that. Trying to bump the bass response much harder results in severe clipping, and I'm all but certain Apple's doing some funky stuff
with phasing to overcome this (their IR plists make reference to imaginary numbers). I don't really
fancy going down that route at this point in time.
As for Carla/REW settings, I dropped using Carla a long time ago and just do everything in REW now since I captured
the response curves of the drivers with a calibration mic. REW doesn't really have scenes or presets, you just set EQ
filters based on the response curve and then export that as an IR in a format of your choosing.

Thanks for your reply.
Very interesting the phasing thing in very low freq.
I'll try to follow some Rew tutorials as this tool is new for me.
I have some experience with DAWs but I never did anything like sound
engineering and calibration.
I'm thinking of buying a second hand calibration mic(miniDSP UMIK-1), just
to have some fun and learn something.
Looks like it is the cheapest mic for this job.
Thanks for your time, I don't want to bother you more.
Regards
Galder
On Fri, 28 Oct 2022 at 02:37, James Calligeros @.***>
wrote:

The current woofer IR has a HPF set at 50 Hz, which is why you can't hear
anything below that. Trying to bump the bass response much harder results
in severe clipping, and I'm all but certain Apple's doing some funky stuff
with phasing to overcome this (their IR plists make reference to imaginary
numbers). I don't really
fancy going down that route at this point in time.
As for Carla/REW settings, I dropped using Carla a long time ago and just
do everything in REW now since I captured
the response curves of the drivers with a calibration mic. REW doesn't
really have scenes or presets, you just set EQ
filters based on the response curve and then export that as an IR in a
format of your choosing.
—
Reply to this email directly, view it on GitHub
https://github.com/chadmed/asahi-audio/issues/5#issuecomment-1294306303,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEFKRHD4SMKVRT5ZBM4FTTTWFMU63ANCNFSM6AAAAAARPGILFM
.
You are receiving this because you authored the thread.Message ID:
@.***>

Hello James,
finally I manage to adjust the settings to make it work on my MacBook pro 16,1 2019 with T2 audio driver.
I would like to share those settings with T2 kernel team but first I  need to ask you for permission.
The FIRs are not specific for a 16,1 but is much better that nothing and it would be an starting point to understand the process for T2 kernel team.
here my changes:
https://github.com/chadmed/asahi-audio/compare/main...lemmyg:asahi-audio:macbookT2_16_1
Regards
Galder

Of course you have my permission, this project is MIT licensed.
I've left some comments on that branch.

that's great.
Unfortunately I can't see your comments

Hello James,
finally I manage to get a  UMIK-1 measurement microphone.  I took some measurements and upload them in my branch in case can give some extra information for mac speakers. I noticed that there is some floor noise in the low frequencies as I don't have a proper place. I do my best., still learning :)
https://github.com/lemmyg/asahi-audio/blob/macbookT2_16_1/test_notes/mac161_fr/speaker_16_1.mdat
I can see that measurement from MacOs and Linux with your FIRs are pretty similar.
Regards
Galder

@lemmyg I have some new unpublished work which drastically improves performance (on my machine at least)
Also re the noise at the low end, there is a fix for that which I will be touching on briefly in a blog post soon. It
involves a lot of magic and DSP operations that I have no clue how to implement, so I have no ETA on it dropping
in Linux :P

Your measurements also look fine to me but you should read up on providing cal files to REW so that it's repeatable. I don't have a calibrated mic so I can't really help you on the specifics of that but the UMK-1 is well supported and IIRC is
the example used in the REW help files for calibration.

Hi @chadmed,
thanks for taking the time to have a look my measurements. I was looking in the REW forums and it looks like the floor noise is normal for home environments. I'm also following REW and UMK-1 documentation. UMK-1 microphone only needs the calibration file that I'm already using it. So I will just to ignore those very  low frequencies.
I took the measurement with -12dbfs signal and the system volume to 75 dbs.
About missing Apple low subs. Apple probably have best sound engineers doing black magic:). Because how is possible that they manage to reproduce 30hz clearly in those tiny speakers.
About following your work, I find difficult to adjust your FIRs as once imported in REW is like a black box. I don't really know which filters were applied. Also when I exported again, I got like a delay. Probably because that's not the way to do it.
If you could share your measurements and filters, would be more easy to follow your work and adjust it for other models.
I can understand if you are not happy with it.
Looking forward to see those latest changes.
Regards
Galder

I understand exactly what magic Apple are using and how it works, I'm just not good enough at writing DSP code or the maths behind it to actually implement it (it's a feature that LADSPA is missing but sorely needs) :P
As for my data, I have no problem sharing if you really need it, but I don't think it's going to help you really. You won't
be able to see the "filters" I apply because the IR in a way abstracts them away. Keep in mind that what you're aiming to
do here is apply EQ filters to the measurement that flatten it out (or better yet sound good to your real human ears).
Seeing what filters I apply for this specific machine is irrelevant for the purposes of the T2 machines since you will need
different ones based on your measurements. It's all about evening out the frequency response so that there aren't
huge differences between frequencies. I recommend using the psychoacoustic smoothing feature for visualising this
since it will take noise out of the graph. You should aim to flatten out the response such that the largest delta in
response between "nearby" frequencies is no greater than 3 dB. Once you get good, you can try dialing it in even further!

And the delay effect is because you have not applied the IR window to your exported IR. Tick the "Apply IR Window"
option when you're exporting.

thanks for your reply. About the filters, I think you could export them as text. It would be a good reference. Is a shame that REW doesn't have  a proper scene save mechanism.
So in theory I need create some crossovers to separate the speakers. subwoofers and tweeters and them try to flatten the response as much that I can. finally test them with different samples and take more measurements.
Thanks for the  "Apply IR Window". I was suspicious with that feature but I thought that maybe import  FIRS and exporting it maybe wasn't the way to do it.

About the apple magic, does it have any name or is there any paper about it?

If you do a search for "psychoacoustic bass" theres a couple of IEEE papers about it but not much else. It's a really
neat trick though, and you should be able to implement it with a couple of biquads.

thanks for your reply. it looks like the famous maxxbass plugin.
Ill have a look if I can find any code example in github.

Hi @chadmed,
I was looking for bass enhancement examples. I found that Easy effects has a plug-in but also Carf.
https://calf-studio-gear.org/doc/Bass Enhancer.html
Calf's plug-ins are LV2, so it should be possible to integrate in the pipe-wire chain.
Just that.
Regards and have a good Christmas :)
Galder

Hi chadmed,
I pushed some changes in https://github.com/lemmyg/asahi-audio/tree/macbookT2_16_1
you maybe interested.
I added the REW measurement  with EQ filters.
Regards

Nice!
I have a feeling that the speakers probably still sound boxy/honky when the volume is not set to the maximum, or
wherever you took your calibration measurements. Is this the case?

Hi chadmed,
I'm not sure. I could be that you don't have same speakers? Also I have been taking measures in my room. Could not be the best place for this job. Or finally me, no having any idea. :)
The best way I found to get some improvements was taking measurements on MacOs and then in Linux each speakers separated. Add the filters to each FIR until the measurement matches macOS. Now I'm continuing tweaking, listening some samples in different places and comparing again.
Some people in T2 team has started testing my setup. Probably Ill get some feedback soon.
Regards


4 arrows bug

Describe your bug here.
I'm making a song, so at the time of trying it, in the moments of pressing the 4 keys, it bugs, because sometimes if it presses and sometimes not.
Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
Nop.

This is a common issue with some keyboards, but this is not a bug with Psych Engine.

your keyboard does not have antighosting and may result in keypresses not being registered, or known as key rollover

Okay.


Handle ArrayValues without a values field

When doing a documents::list, I got a deserialization failure, not on my own structures but on the dto::ListDocumentsResponse. Turns out that in ArrayValue the values field is optional. This one was confusing/fun to debug :smile:

Could you sign your commits (use "-s" on the command line)? It's not exactly necessary for small changes, but it's a good habit. It basically means that you accept that your contributions are made available under the license of this repo.

Signing done :)


Parent-child relationship help

I was using your library to ElasticSearch and I am able to create a basic index for my tables. But I was having trouble creating the Parent-Child relationship, using the example you have in the rule config section.
In my example I have 2 tables: organization and promotion. The promotion table has a has a field named organization_id that has 1 to 1 relationship with organization. How do I properly create the river.toml for this?
MySQL data source
[[source]]
schema = "test"
tables = ["organization", "promotion"]
[[rule]]
schema = "test"
table = "promotion"
index = "promo"
type = "promo"
parent = "organization_id"

/cc @EagleChen , maybe you can help us.

@ebisrat
Did you manually set up the index mapping in ElasticSearch?
If not, you need to set them correctly first. Please refer to this doc on how to set up the relationship. Basically, you need to set:
"mappings": {
    "promotion": {
        "_parent": { "type":  "organization"},
       ....
    }
}

This library will help you "exporting" data to  ElasticSearch and set the "_parent" part for each document( one row in mysql ). But you need to specify the relationship explicitly in the first place.
Hope my answer will help you.

@EagleChen Ok I see. I was able to create the correct ES mapping.
{"promotion":{"mappings":{"promotion":{"_all":{"enabled":false},"_parent":{"type":"organization"},"_routing":{"required":true}}}}}
Now that I have set up the correct index/_parent mapping in ES, can you tell the correct way to setup the river.toml so that "organization_id" of the table organization in turn populates promotion's index "_parent".

@ebisrat
Then the configuration in your first question is right.
[[rule]]
schema = "test"
table = "promotion"
index = "promotion"
type = "promotion"
parent = "organization_id"

By the way, you need to put promotion(type) and organization(type) in the same index.


Open compressed files that were not made by godot

Godot version: 33897d9b5844aa0147d55841845427ed599d069f

OS/device including version: Linux 4.14.113-1-MANJARO

Issue description:

I was trying to load a gzipped json file from an external web server, and found out that I can't seem to find a way to do so in godot without making a gdnative plugin. File has the method open_compressed() which supports gzip, but the format it expects for gzip has this bizarre gcpf magic header that encapsulates the format.

I kind of expected that it would at the very least open up compressed files that weren't made using the godot editor, assuming encryption wasn't used, considering at the end of the day it's just a bunch of strings or whatever other bytes in there. I'm not sure why the magic header exists in the compression format, but ideally if it could fall back to not requiring the magic header at all and just open up the file without it instead that would be cool.
If I ever need to edit a gzipped file that godot has made i can't just do a quick change from any other archive tools, i'll have to open up godot, open it up, edit it, and then re-export it in order for godot to continue being able to read it which is kind of annoying.
Steps to reproduce:

download a gzip'd file from anywhere or make one yourself using the command line
try and load it into godot using open_compressed or any other manner

Minimal reproduction project:

test_compression.zip

there's a test.json.gz file at the root of the project file that was made using gzip on the command line, which has the same contents as the text edit that is in the project.
If you click the "save gz" button it will save out a file to user://test.json.gz, and load it with "load gz". you can use this to compare the output that godot is expecting compared to the output from command-line gzip
You can try to load the command-line gzip file by clicking the button on the bottom of the text edit, and if it fails it will spit out the error below. It will generally always be error 15 until something changes.
There's also a checkbox to verify if the input is valid json or not.

Has there been any update on this?

I was trying to load RexPaint images (.xp files) and it seems I'm having the same problem. Error 15, file unrecognized.
I'm an ignorant when comes to compression formats, but according to RexPaint's manual:
Appendix B: .xp Format Specification (and Import Libraries)
-----------------------------------------------------------------
    (...)
    The .xp files are deflated with zlib (specifically they are gzipped files created
    via gzofstream); once decompressed the format is binary (...)

So I tried File.COMPRESSION_GZIP first, but then I also tried all the others and none worked. If I manually extract the file with 7z then it works fine, but I'd rather not have to be doing that...

@R-033 where does the compressedSize and decompressedSize come from?
Also, do you use the Directory class to save the file before re-reading it? I'm asking because I'm not seeing anything in the File class that seems to allow reading from a File instance.

@Skaruts compressedSize is the size of data between header and footer in bytes, decompressedSize is expected size of data after it's being decompressed by open_compressed() method

@R-033 I'm confused, though. At that point I don't know the size of the decompressed data, or what to expect the size to be.

@Skaruts usually this value is used for creating output array internally, so maybe if you'll make it big enough there won't be a problem? I'm just guessing though, I didn't check dogot sources

Ran into this today. Especially annoying since the compression formats already seem to use magic numbers...

I was trying to load a gzipped json file from an external web server

Note that for this particular use case, transparent gzip compression is now supported in HTTPRequest in the master branch: https://github.com/godotengine/godot/pull/38944

NOTE: this is also weird: every store_string() call will create a new gzip header! so you should pre-buffer your content before writing to a compressed file or you will bloat it with extra gzip block headers?

I wrote a little program to compress files outside of Godot, which can then be loaded normally inside Godot:
https://gist.github.com/paulmiller/a5e593eda3a14e3ffa9acd8f0a4fac4e
It also gets way better compression ratios for some files, with the downside that Godot will decompress the entire file at once.

I had to do some trial and error, but I was able to use the advice in this thread to successfully get Godot to read a file that was externally compressed. Check it out here: https://gist.github.com/DanielKilgallon/5936bd6b5020202ce5dc61c0295ee10f

I tried opening NBT files (in my case Minecraft schematics) which are documented as being some binary data wrapped in GZIP.
Unfortunately I hit this issue too, Godot can't recognize the file.
I could not identify magical characters like this "GCPF" header in the file.
I can't know the decompressed size without relying on an external tool.
I also can't apply this hack because it assumes the file actually isn't compressed. In my case, the NBT file is compressed.
Of course 7zip can open the file just fine (also indicates there is a 10 bytes header), so there is surely some kind of trick to recognize its format, but I have no idea what.


luci-theme-material: missing panel title in with client-side view

When using client-side view, panel title is missing:

Server-side view is normal:

I think it's because the code that creates it excutes on load, but the view is not loaded at that time.
https://github.com/openwrt/luci/blob/e459683822925bcdeb552673a4811aa3b4322640/themes/luci-theme-material/htdocs/luci-static/material/js/script.js#L174-L180

Yet another material theme specific bug.

Fixed as side-effect of 92eecedc8a52b0ba814daddb5167449a2ebb7f26

I am on current master branch and can confirm this is still there. The trigger luci-loaded is executed when actually no legend element exists yet. The GUI is created asynchronously, so the conversion from legend to span needs to take place some time later. Any chance to get this fixed?

The View class will most probably need to emit a notification when the DOM is ready - in luci.js in constructor of View class:
https://github.com/openwrt/luci/blob/0d0816ca107c84631ab03b5ef2e6d373e102d09a/modules/luci-base/htdocs/luci-static/resources/luci.js#L1945-L1958

I have no interest in adding additional logic to fix the material theme, the theme should be fixed no not fiddle with the DOM. Where it makes sense we could think about revising the default markup to accommodate for more complex CSS.

The legend element should be first child of fieldset element, but the code does not create any fieldset, so it looks like the Material theme is trying to fix the HTML structure actually.

Long time ago, section elements used to be <fieldset>, nowadays they're <div> ones but the legend tag remained as a leftover. I did some cursory googling and it appears <legend> is indeed only legal below <fieldset> and quirky to style in some situations, which likely is the reason why material tries to replace it.
So <legend> should be changed to <div> or <span> in form.js and the legacy templates then.

Something like this:
Original:
https://github.com/openwrt/luci/blob/0d0816ca107c84631ab03b5ef2e6d373e102d09a/modules/luci-base/htdocs/luci-static/resources/form.js#L3140-L3141
Changed:
 if (typeof(this.title) === 'string' && this.title !== '')
 	sectionEl.appendChild(E('div', { 'class': 'cbi-section-title' }, this.title));

Other places are trying to render this.title as <h2> or <h3>, which would make sense too.

Right, the standard openwrt, bootstrap and openwrt2020 themes treat legend equivalent to an h3, so we should use that instead and fix whatever CSS breaks due to this.

The Material theme is doing some other DOM tweaks, so the question is whether it actually does anything - especially when views are being loaded asynchronously, so they do not exist when those tweaks are tried to be made.

Material theme is not the only one, also Rosy theme is trying to manipulate DOM. Both themes need to be updated to work with client-side rendered views, maybe rendering code of form.js could be updated somehow to allow changes by themes.

Well, I don't particularly like either theme. Rosy went out of maintenance the moment it got dropped into the tree and Material has these pesky jQuery dependency and ugly DOM manipulations (which Rosy copy-pasted afair).
I prefer to fix the generic markup to be better workable with CSS styling instead of allowing themes to manipulate the DOM. I think that just leads to maintenance hell and incompatibilities.


Fix redundant exception handling

Describe the bug
When an unhandled exception occurs, the Spring framework iterates through a list of exception handlers looking for someone to consume the unhandled exception. This is the Java for loop in the Spring framework that is looking for 1 and only one exception handler to swallow the exception.
The existing BugSnag code explicitly sets BugsnagMvcExceptionHandler as the first Exception Handler by setting Ordered.HIGHEST_PRECEDENCE on line 22. The code on line 47-48 then explicitly lets some other exception handler try to consume the exceptions. This breaks the expectation that only 1 handler should be invoked.
It's more reasonable that the BugSnag library should run last in the chain and not first in the chain. Allowing other exception handlers to consume the exception first allows the application to consume or 'handle' the exception and swallow it before it reaches BugSnag.
For example, my Java application throws custom defined exceptions to perform URL redirects and display custom HTML error pages. I have a @ControllerAdvice class that then properly renders the content. However, the BugSnag library catches the exception, logs it to your API, and then finally my application code runs. Since I handled the exception, it should never have been logged by the library.
Another example, in my class with custom exception handling using @ControllerAdvice, for 1 particular exception, I explicitly invoke BugSnag to log an exception as handled. But then your code also logs it as unhandled in your own handler..
Steps to reproduce
Create a spring boot project
Create a class to handle a custom exception and create a @ControllerAdvice annotated class to custom handle the exception.
Invoke the exception and watch BugSnag log it as unhandled as well as watch the @ControllerAdvice annotated class handle the exception.
Environment

Bugsnag version:3.6.1
Java version: 8
Spring framework version (if any): 2.1.4.RELEASE
Maven version (if any): 3.6.3

Example
I created this branch to solve the issue, but I couldn't understand the test that I broke. This example fix and the above referenced parts of the code explain well what the observed yet expected result should be.
https://github.com/bugsnag/bugsnag-java/compare/master...nkavian:lower-precedence?expand=1
Change the order on BugsnagMvcExceptionHandler from highest to lowest. This allows the application to handle exceptions. If an exception truly was not handled by any one else, then finally it should be logged to BugSnag as unhandled.
Using bugsnag.setIgnoreClasses() is a workaround but it's undesirable as a long term solution. I have to maintain a list of 10+ classes to exclude here.

@nkavian - in your change, I believe the tests fail because Spring's DefaultHandlerExceptionResolver handles the error and so it would not make it to Bugsnag as the lowest priority handler.
In order to allow ControllerAdvice beans to swallow exceptions before the Bugsnag handler and also to catch exceptions thrown by these beans, it looks like we could make the BugsnagMvcExceptionHandler a ControllerAdvice bean with the lowest priority. (A helpful explanation of the mechanism is here.)
However, I believe this would only work for Spring MVC, and I'm not sure we could find a solution that would not risk the handler not firing for different use cases. Therefore you may wish to consider such an approach using a fork of this repo, but I believe we'd need a more general purpose approach to change the library itself.

Great link that's very detailed. Regarding your last paragraph, this issue is specific to Spring MVC and the suggested code change is to code within the bugsnag-spring folder, so there are no other use cases to be concerned with right?

The ControllerAdvice is relevant to a Spring web application but not to a Spring console application, for example.

I might have missed the nuance there, but that sounds like a good thing. This change would be to the Bugsnag MVC exception handler dealing with the Spring MVC.
https://github.com/nkavian/bugsnag-java/blob/master/bugsnag-spring/src/main/java/com/bugsnag/BugsnagMvcExceptionHandler.java#L22

Yes - I think it's achievable. I've raised it in our system to have a look at when priorities allows.


New Google browser uploads caused the browser to crash

I'm submitting a ...

[ ] bug report
[x] feature request
[ ] other
Current behavior:

New Google browser uploads caused the browser to crash. I used angularjs 1.4.6 in  Chrome  69.0.3497.92
Expected / new behavior:

Minimal reproduction of the problem with instructions:

AngularJS version: 1.4.6

Browser: [all | Chrome  69.0.3497.92 | Firefox XX | Edge XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

Anything else:

New Google browser uploads caused the browser to crash

This doesn't sound like an AngularJS issue. Try upgrading to the latest version and if you believe this is a bug in AngularJS, please open a new issue providing a minimal reproduction.


Twitter: Force SSL/HTTPS

Ripme version: 1.7.89

Java version:
OpenJDK Runtime Environment (build 1.8.0_161-b14)
Java(TM) SE Runtime Environment (build 12.0.1+12)

Operating system:  Linux

Exact URL you were trying to rip when the problem occurred: https://www.twitter.com

Please include any additional information about how to reproduce the problem:

Any twitter URL with media
Expected Behavior
Twitter is redirecting to http links for abs.twitter.com, while that is certainly a twitter problem ideally ripme would either forbid insecure requests outright or attempt to mimic browsers which warn
Actual Behavior
ripme attempts to fetch so-called cross origin "insecure" requests.  Example
http://pbs.twimg.com/media/A8-BsOWCUAAndx6.png:orig
vs
https://pbs.twimg.com/media/A8-BsOWCUAAndx6.png:orig
This likely applies to other modules.  Twitter may infact be relying on a quirk with some browsers that now try https automatically, first.

I think ripme should start forcing ssl everywhere by default and store any exceptions in the config file


Update MiddleChinese.tsv

a few corrections

Not sure if I am doing this right. But here is a try.

Yes, now I pressed on the green MERGE butten and changes are now in the original document, and I can re-run the code.