feat: spend fidelity bond

Partly addresses #547
First iteration of moving a fidelity bond after it expired.
Feedback is highly welcome, especially in regard to wording.
A follow-up PR for "renewing" the FB is in the making (also part of #547).
First attempts of this feature were based on the "Create FB" flow:

Select target jar
Freeze non-participating UTXOs manually
Unfreeze the Fidelity Bond UTXO
Display payment info and confirm
Send FB UTXO via direct-send
Restore state of previously frozen UTXOs

While this method gives users a better understanding of what is going on, it was annoying, resulted in so much code and just felt bloated.
Now it is just:

Select target jar
Display payment info and confirm

With the current approach, the necessary intermediate steps are hidden from the user. This makes for a much nicer UX. Any input on this is highly appreciated.
Also, the resulting method has been generalized: Sending any amount of specific UTXOs to a generic destination (internal or external). This can be reused in the upcoming PR when renewing the FB and also elsewhere.
Other stuff

disallow unfreezing of expired fidelity bonds from JarDetailsOverlay component

this is necessary as unfrozen, expired FB cannot take part in taker operations (when starting a maker operation they are auto-frozen by JM, but unfortunately not for taker operations)
Fidelity Bond UTXOs will always show the lock icon

externalized PaymentConfirmModal to be used from other components than Send
prepare and lay ground for #252 to improve error messages coming from the backend
order fidelity bond UTXOs by value and locked state
prevent Balance component from unnecessary re-renders (+handle possible NaN values)

Note: Spending an expired fidelity bond UTXO can still fail if the median time of the chain is still lower than the locktime of the bond. There is currently no way to verify if it is successfully spendable and a bond will always be marked as "expired" if its locktime is in the past.
How to test?
Create an expired fidelity bond (only possible when starting via npm run dev:start) and try moving it into a jar.
Also note, that only the actual fidelity bond UTXO should be spent, all other UTXOs should be frozen and not be moved. Once the payment is done (regardless of success), UTXOs should have their original state again.
:camera_flash:

Nice work so far!
Is the source jar selectable to move the fb utxo inside there? If not, Maybe it should be grayed out?
„Payment without privacy improvements“ I think will stick stay with „moving without privacy improvements“ because we are not paying anything in the users eye
I like it. Where is this „moving“ icon inside the button from?

Nice work so far!
Is the source jar selectable to move the fb utxo inside there? If not, Maybe it should be grayed out?

Yes. You can move the expired FB anywhere.

„Payment without privacy improvements“ I think will stick stay with „moving without privacy improvements“ because we are not paying anything in the users eye

I was thinking of completely removing this phrase, as users might be confused and it is not really needed here. What do you think?

I like it. Where is this „moving“ icon inside the button from?

"Transfer" icon on https://bitcoinicons.com
I know that there is no icon in your template. Can also be removed, if you say so!

All good so far. Will have a look asap from my desktop. But overall you nailed it. Maybe we should rephrase it to something like: make fb usable again… bla bla
so the user gets the context that before that it’s not possible to access the funds

All good so far. Will have a look asap from my desktop. But overall you nailed it. Maybe we should rephrase it to something like: make fb usable again… bla bla
so the user gets the context that before that it’s not possible to access the funds

That's true.. maybe "Move to Jar" is misleading as it already is in Jar A, it is just not able to take part in a taker/maker operation.
Any input is highly appreciated. Maybe just something plain and simple "Spend"?

Oh wow, that's big. Will do my best to review this fully until EOW.

Conflicts introduced due to merge of #566 - please resolve @theborakompanioni 🙏

Conflicts introduced due to merge of #566 - please resolve @theborakompanioni pray

Resolved. :pray:

What about: "Unlock expired fidelity bond?"
That's what you want to do after all, no? In some sense the FB is locked away, both in time and space. Once the timelock expires you can unlock it completely, by moving it to any jar.
Thoughts on this terminology @theborakompanioni @editwentyone?

Another thought: Why give the user the option to select a jar in the first place?
I'd default to Jar A, or at least pre-select A and hide the selection below a fold. Why make the user think? It's not terribly important, is it? The user just wants to press "Unlock" and wants to use the funds again.
Here is how I would simplify the flow & the language:

Two clicks, the second one being a confirmation.

Another thought: Why give the user the option to select a jar in the first place?
I'd default to Jar A, or at least pre-select A and hide the selection below a fold. Why make the user think? It's not terribly important, is it? The user just wants to press "Unlock" and wants to use the funds again.

Done.

Two clicks, the second one being a confirmation.

Not too convinced, as this is an action not performed very often and the described approach provides less freedom users.
It is now changed to skip the selected automatically and default to Jar A - the code to selected a Jar is still present for now and can be enabled with a flag - hope that is okay (in case it is decided to enable this flow or provide a toggle)

(I'd also remove the red warning that tells the user that this is a send without privacy improvement. The user can't change it at this point, there is no need to show a warning. It's just scary and confusing.)

Done.

Nice! I like it. Much more streamlined.

It is now changed to skip the jar selection and default to Jar A automatically - the code to select a Jar is still present for now and can be enabled with a flag - hope that is okay (in case it is decided to enable this flow or provide a toggle).

If we want to keep it in, we could add an Unlock Options to the Unlock modal, just like we have on Receive?
Add this "fold" ...

...to this screen:

Would still default to A (unless you go through the trouble of changing it) and would hide the complexity nicely, while still providing the option.
What do you think?

What do you think?

Full ACK.. Much better, imho. : -)
I'll merge this as it's an improvement to the current state and it feels "good enough" for now.
It is more important that users are able to spend their expired fidelity bonds. Currently, only acting as maker would freeze expired bonds automatically (in case it was unfrozen), but not when acting as a taker. This can potentially lead to confusion and/or needing additional support.
An issue for this has been created: https://github.com/joinmarket-webui/jam/issues/574


Replace stdlib flag with kingpin. Issue #43

Also added some debug statements and updated the README.
NOTE: this change breaks backwards compatibility. Stdlib flag format does not appear to be compatible with kingpin.
Solves #43

Made a comment, also any idea why the build didn't go through?

Looks like a logrus dependency issue. The master appears to be failing for the same reason (unless I'm readying it wrong).
I can "*****" everything between ":" and "@" out in the scrape url or just hide the entire string...

I've removed the debug statements completely. I figured they can be added for an issue specifically dedicated to providing more information in debug mode. Also, I was curious to see if the build would fail again.
I'm not sure what's going on. It's failing on one specific platform (without trying any further) on the IsTerminal method. I have no idea what could be causing it.


Escaped characters in help URL are replaced with non-escaped value when going back to edit

if you enter a help URL that contains a %20, if you go back to edit after you saving the %20 character is replaced with a space character   and the user would have to go back and replace each space    with %20 before being able to save again.

@rmmayo - cannot reproduce this

@cjmoses - it happens when editing a skill.  Subject seems to work correctly

PR: #672

:+1:


delete template CVE-2024-4358. It added to upstream

https://github.com/projectdiscovery/nuclei-templates/pull/9966

https://github.com/projectdiscovery/nuclei-templates/blob/main/http/cves/2024/CVE-2024-4358.yaml


Optimisation

Add posibility to generate snippet for prefetching scripts and styles to adding into layout

Not relevant for inline usages


[Bug]: [ERROR]No module named 'FlagEmbedding'

Is there an existing issue for the same bug?

[X] I have checked the existing issues.

Branch name
main
Commit ID
last
Other environment information
- uname -a: Linux ubuntu02 5.15.0-72-generic #79-Ubuntu SMP Wed Apr 19 08:22:18 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Actual behavior
[ERROR]No module named 'FlagEmbedding'

Expected behavior
Fix

Steps to reproduce
bash
sudo sysctl -w vm.max_map_count=262144
git clone https://github.com/infiniflow/ragflow.git
cd ragflow/docker
docker compose -f docker-compose.yml up -d
docker logs -f ragflow-server

result
 * Running on all addresses (<IP_ADDRESS>)
 * Running on http://<IP_ADDRESS>:9380
 * Running on http://x.x.x.x:9380
 INFO:werkzeug:Press CTRL+C to quit

web browser Analyze PDF
Task has been received.
Page(1~13): [ERROR]No module named 'FlagEmbedding'
Task has been received.
Page(13~15): [ERROR]No module named 'FlagEmbedding'

Additional information
docker logs -f ragflow-server
[INFO] [2024-11-08 09:48:01,000] [_internal._log] [line:97]: <IP_ADDRESS> - - [08/Nov/2024 09:48:01] "GET /v1/user/info HTTP/1.1" 200 -
[INFO] [2024-11-08 09:48:01,008] [_internal._log] [line:97]: <IP_ADDRESS> - - [08/Nov/2024 09:48:01] "GET /v1/user/tenant_info HTTP/1.1" 200 -
[INFO] [2024-11-08 09:48:01,013] [_internal._log] [line:97]: <IP_ADDRESS> - - [08/Nov/2024 09:48:01] "GET /v1/kb/detail?kb_id=bb9ee2509cdf11ef8251ac1f6b83a6fe HTTP/1.1" 200 -
[INFO] [2024-11-08 09:48:01,111] [_internal._log] [line:97]: <IP_ADDRESS> - - [08/Nov/2024 09:48:01] "GET /v1/document/list?kb_id=bb9ee2509cdf11ef8251ac1f6b83a6fe&keywords=&page_size=10&page=1 HTTP/1.1" 200 -

@KevinHuSh ragflow:dev-slim size will become increase ~6GB after adding following packages
bcembedding = "0.1.3"
fastembed = "^0.3.6"
flagembedding = "1.2.10"

@Night-Quiet  ragflow images are not up-to-date. Please try the latest one.

Close due to no response.


Rename bcgov/indy-catalyst to hyperledger/aries-vcr

indy-catalyst is being renamed to aries-vcr and being contributed to Hyperledger
https://github.com/bcgov/aries-vcr/issues/464

Signed-off-by: Wade Barnes<EMAIL_ADDRESS>

Staging these changes for when the transfer is complete.

Given that the link in the note still works and that this is purely a historical note change, I'm going to go ahead and close this PR.


MaxRetryCount test

Description
This PR adds tests to validate that SDK-internal retry policies have some guard-rails for the number of requests issued in place.
Multi-Master account with 3 regions
404/1002

Failure condition
Max. requests
Algorithm
Explanation
First Cross region retry

404/1002 (remote preferred)
13
Math.max(1, MaxRetriesInLocalRegion) * (1 + (ReplicaCountPerPartition * NumberOfPreferredRegions)
MaxRetriesInLocalRegion default value is 1, ReplicaCountPerPartiiton is 4
~40ms

404/1002 (local preferred)
221
expectedMaxNumberOfInnerRegionalRetries * (1 + (ReplicaCountPerPartition * NumberOfPreferredRegions)
ReplicaCountPerPartiiton is 4, expectedMaxNumberOfInnerRegionalRetries default value is 17 - it depends on system properties COSMOS.DEFAULT_SESSION_TOKEN_MISMATCH_INITIAL_BACKOFF_TIME_IN_MILLISECONDS,  , COSMOS.DEFAULT_SESSION_TOKEN_MISMATCH_MAXIMUM_BACKOFF_TIME_IN_MILLISECONDS and COSMOS.DEFAULT_SESSION_TOKEN_MISMATCH_WAIT_TIME_IN_MILLISECONDS - basically the 1 plus the number of retries that fit into wait time assuming you start with initial backoff and duplicate the backoff (with enforced max backoff) for every retry
~5s

410/0 (Server Gone)

Failure condition
Consistency Level
OperationType
Max. requests
Algorithm
Explanation
First Cross region retry

410/0
Eventual
Read/Query
28
(PreferredRegionsCount + 1) * MaxRetriesInLocalRegion
Max retry 30s in GoneAndRetry with backoff 0s, 1s, 2s, 4s, 8s, 15s, 15s. --> MaxRetriesInLocalRegion = 7 times
~30s

410/0
Session
Read/Query
112
(PreferredRegionsCount + 1) * MaxRetriesInLocalRegion * 4
There are 4 replicas per partitions, will first loop through each replica before bubble up the exception to GoneAndRetryPolicy.  Max retry 30s in GoneAndRetry with backoff 0s, 1s, 2s, 4s, 8s, 15s, 15s --> MaxRetriesInLocalRegion = 7 times
~30s

410/0
BoundedStaleness
Read/Query
128
(PreferredRegionsCount + 1) * (4 * 2 + (MaxRetriesInLocalRegion-1) * 4)
There are 4 replicas per partitions, for BoundedStaleness, first do quorum reads on three secondary replicas, when QuorumNotSelected, will read from primary replica. This process will repeat 2 times before bubble up the exception to GoneAndRetryPolicy. Max retry 30s in GoneAndRetry with backoff 0s, 1s, 2s, 4s, 8s, 15s, 15s -->MaxRetriesInLocalRegion = 7 times
~30s

410/0
Eventual/Session/BoundedStaleness
Create/Replace/Delete without nonIdempotentWriteRetries
7
MaxRetriesInLocalRegion
Max retry 30s in GoneAndRetry with backoff 0s, 1s, 2s, 4s, 8s, 15s, 15s --> MaxRetriesInLocalRegion = 7 times. ClientRetryPolicy will not retry
No cross region retry. After fix, around ~30s

410/0
Eventual/Session/BoundedStaleness
Create/Replace/Delete with nonIdempotentWriteRetries
28
(PreferredRegionsCount + 1) * MaxRetriesInLocalRegion
Max retry 30s in GoneAndRetry with backoff 0s, 1s, 2s, 4s, 8s, 15s, 15s --> MaxRetriesInLocalRegion = 7 times.
~30s

Note

for 503 retry, we are doing A, B, C, A
for 503 retry, it does not retry for write (even if it failed with server gone)
missing primary replica status tracking if it failed
503/0 -> 503/21005

449 (Server RetryWith)

Failure condition
Consistency Level
OperationType
Max. requests
Algorithm
Explanation
First cross region retry

449
Eventual/Session/BoundedStaleness
*
>1K
>1K
Max retry 30s in GoneAndRetry with backoff 10ms, 20ms, 40ms, 80ms,  160ms, 320ms, 640ms, 1s, 1s, 1s, 1s etc, which should cap the total retry around 30-40 times. But there is a bug https://github.com/Azure/azure-sdk-for-java/issues/37047 currently which causing high retries.
~30s

TransitTimeout(5s)

Failure condition
Consistency Level
OperationType
Max. requests
Algorithm
Explanation
First cross region retry

5s
Eventual
Read/Query
20
(PreferredRegionsCount + 1) * MaxRetriesInLocalRegion
In each region Max retry 30s with backoff 0s, 1s, 2s, 4s, 8s, 15s, 15s --> MaxRetriesInLocalRegion = 5 times
~30s

5s
Session
Read/Query
32
(PreferredRegionsCount + 1) * MaxRetriesInLocalRegion * 4
There are 4 replicas per partitions, will first loop through each replica before bubble up the exception to GoneAndRetryPolicy.  In each region Max retry 30s with backoff 0s, 1s, 2s, 4s, 8s, 15s, 15s  --> MaxRetriesInLocalRegion = 2 times
~30s

5s
BoundedStaleness
Read/Query
48
(PreferredRegionsCount + 1) * (4 * 2 + (MaxRetriesInLocalRegion - 1) * 4
There are 4 replicas per partitions. it will first loop through each replica before bubble up the exception to GoneAndRetryPolicy. In each region Max retry 30s with backoff 0s, 1s, 2s, 4s, 8s, 15s, 15s --> MaxRetriesInLocalRegion = 2 times
~45s

5s
Eventual/Session/BoundedStaleness
Create/Replace/Delete without nonIdempotentWriteRetries
1
1
Write operation is not idempotent, so without nonIdempotentWriteRetries being enabled, SDK will not retry.
No cross region retry.

5s
Eventual/Session/BoundedStaleness
Create/Replace/Delete with nonIdempotentWriteRetries
20
(PreferredRegionsCount + 1) * MaxRetriesInLocalRegion
In each region Max retry 30s with backoff 0s, 1s, 2s, 4s, 8s, 15s, 15s --> MaxRetriesInLocalRegion = 5 times
~30s

TransitTimeout(1s)

Failure condition
Consistency Level
OperationType
Max. requests
Algorithm
Explanation
First cross region retry

1s
Eventual
Read/Query
28
(PreferredRegionsCount + 1) * MaxRetriesInLocalRegion
In each region Max retry 30s with backoff 0s, 1s, 2s, 4s, 8s, 15s, 15s --> MaxRetriesInLocalRegion = 7 times
~30s

1s
Session
Read/Query
96
(PreferredRegionsCount + 1) * MaxRetriesInLocalRegion * 4
There are 4 replicas per partitions, will first loop through each replica before bubble up the exception to GoneAndRetryPolicy.  In each region Max retry 30s with backoff 0s, 1s, 2s, 4s, 8s, 15s, 15s  --> MaxRetriesInLocalRegion = 6 times
~30s

1s
BoundedStaleness
Read/Query
112
(PreferredRegionsCount + 1) * (4 * 2 + (MaxRetriesInLocalRegion - 1) * 4
There are 4 replicas per partitions. it will first loop through each replica before bubble up the exception to GoneAndRetryPolicy. In each region Max retry 30s with backoff 0s, 1s, 2s, 4s, 8s, 15s, 15s --> MaxRetriesInLocalRegion = 6 times
~30s

1s
Eventual/Session/BoundedStaleness
Create/Replace/Delete without nonIdempotentWriteRetries
1
1
Write operation is not idempotent, so without nonIdempotentWriteRetries being enabled, SDK will not retry.
No cross region retry.

1s
Eventual/Session/BoundedStaleness
Create/Replace/Delete with nonIdempotentWriteRetries
28
(PreferredRegionsCount + 1) * MaxRetriesInLocalRegion
In each region Max retry 30s with backoff 0s, 1s, 2s, 4s, 8s, 15s, 15s --> MaxRetriesInLocalRegion = 7 times
~30s

408/0 (Server Timeout)

Failure condition
Consistency Level
OperationType
Max. requests
Algorithm
Explanation
First cross region retry

408/0
Eventual
Read/Query
20
(PreferredRegionsCount + 1) * MaxRetriesInLocalRegion
In each region Max retry 30s with backoff 0s, 1s, 2s, 4s, 8s, 15s, 15s --> MaxRetriesInLocalRegion = 5 times
~30s

408/0
Session
Read/Query
32
(PreferredRegionsCount + 1) * MaxRetriesInLocalRegion * 4
There are 4 replicas per partitions, will first loop through each replica before bubble up the exception to GoneAndRetryPolicy.  In each region Max retry 30s with backoff 0s, 1s, 2s, 4s, 8s, 15s, 15s  --> MaxRetriesInLocalRegion = 2 times
~30s

408/0
BoundedStaleness
Read/Query
48
(PreferredRegionsCount + 1) * (4 * 2 + (MaxRetriesInLocalRegion - 1) * 4
There are 4 replicas per partitions. it will first loop through each replica before bubble up the exception to GoneAndRetryPolicy. In each region Max retry 30s with backoff 0s, 1s, 2s, 4s, 8s, 15s, 15s --> MaxRetriesInLocalRegion = 2 times
~45s

408/0
Eventual/Session/BoundedStaleness
Create/Replace/Delete without nonIdempotentWriteRetries
1
1
Write operation is not idempotent, so without nonIdempotentWriteRetries being enabled, SDK will not retry.
No cross region retry.

408/0
Eventual/Session/BoundedStaleness
Create/Replace/Delete with nonIdempotentWriteRetries
20
(PreferredRegionsCount + 1) * MaxRetriesInLocalRegion
In each region Max retry 30s with backoff 0s, 1s, 2s, 4s, 8s, 15s, 15s --> MaxRetriesInLocalRegion = 5 times
~30s

429/3200(Server RequestRateTooLarge)

Failure condition
Consistency Level
OperationType
Max. requests
Algorithm
Explanation
First cross region retry

429/3200
Eventual/Session
Read/Query/Create/Replace/Delete
5-10
MaxRetriesInLocalRegion
SDK will retry based on the backoff header returned from server
There is no cross region retry

429/3200
BoundedStaleness
Read/Query/Create/Replace/Delete
10-20
MaxRetriesInLocalRegion * 2
SDK do quorum reads. SDK will retry based on the backoff header returned from server
There is no cross region retry

429/3200
Eventual/Session/BoundedStaleness
Read/Query/Create/Replace/Delete
5-10
MaxRetriesInLocalRegion
SDK will retry based on the backoff header returned from server
There is no cross region retry

503/0(Server ServiceUnavailable)

Failure condition
Consistency Level
OperationType
Max. requests
Algorithm
Explanation
First cross region retry

503/0
Eventual/Session
Read/Query
4
(PreferredRegionsCount + 1)
503 from server will trigger cross region retry immediately.
Bounded by request latency

503/0
BoundedStaleness
Read/Query
8
(PreferredRegionsCount + 1) * 2
SDK do quorum reads. 503 from server will trigger cross region retry immediately.
Bounded by request latency

503/0
Eventual/Session/BoundedStaleness
Create/Replace/Delete without nonIdempotentWriteRetries
1
1
SDK currently does not retry(should have), will fix
No cross region retry.

503/0
Eventual/Session/BoundedStaleness
Create/Replace/Delete with nonIdempotentWriteRetries
4
(PreferredRegionsCount + 1)
Bound by request latency

500/0(Server InternalServerError)

Failure condition
Consistency Level
OperationType
Max. requests
Algorithm
Explanation
First cross region retry

500/0
Eventual/Session
Read/Query
1
1
SDK does not retry for 500.
No Cross region retry

500/0
BoundedStaleness
Read/Query
2
2
SDK do quorum reads. SDK does not retry for 500.
No Cross region retry

500/0
Eventual/Session/BoundedStaleness
Create/Replace/Delete
1
1
SDK does not retry for 500.
No Cross region retry

Single-Master account with 3 regions

Failure condition
Max. requests
Algorithm
Explanation

Changes Included:

Added e2e tests for maxRetryCount for 404/1002, server449, server429, server408, server503, server500, transitTimeout
Fixed https://github.com/Azure/azure-sdk-for-java/issues/37073
Fixed https://github.com/Azure/azure-sdk-for-java/issues/37047
Fixed https://github.com/Azure/azure-sdk-for-java/issues/37050)

All SDK Contribution checklist:

[ ] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

API change check
API changes are not detected in this pull request.

/azp run java - cosmos - tests

/azp run java - cosmos - tests

/azp run java - cosmos - tests

/azp run java - cosmos - tests

/azp run java - cosmos - tests

/azp run java - cosmos - tests

/azp run java - cosmos - tests


DOM event globalZoneAwareCallback slow on Edge

Using Microsoft Edge 40.15063.674.0, Angular 4.4.6 and Zone.js 0.8.18, I'm experiencing very slow performance. The performance session says that all of the time is being spent on DOM events (globalZoneAwareCallback to be specific).  Here's a snapshot of my performance window. I'm unable to share a public copy of the source, but if necessary, I can try to replicate it in a demo repo.
This may or may not be related to #703 and #757

For now, I've gone back to 0.8.14 - which is the same version that the AngularCLI uses - and it's much better.
It does seem that these function durations do get inflated when the Edge developer tools window is open but I can't find a way to profile within Edge with the developer tools window closed.

@clabough , please try to add this in index.html before load zone.js.
<head>
  <script>
    __Zone_enable_cross_context_check = true;
 </script>
</head>

Between that and an update to the Kendo dropdowns I'm using, things are better. Thanks.


JetBrains: Chat history don't show up until user click "New Chat" for a fresh install.

IDE Information
IntelliJ IDEA 2024.2 (Community Edition)
Build #IC-242.20224.300, built on August 7, 2024
Runtime version: 21.0.3+13-b509.4 aarch64 (JCEF 122.1.9)
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
Toolkit: sun.lwawt.macosx.LWCToolkit
macOS 14.3
GC: G1 Young Generation, G1 Concurrent GC, G1 Old Generation
Memory: 2048M
Cores: 8
Metal Rendering is ON
Registry:
ide.experimental.ui=true
Non-Bundled Plugins:
DevKit (242.20224.159)
PythonCore (242.20224.300)
idea.plugin.protoeditor (242.20224.155)
gherkin (242.20224.159)
com.jetbrains.space (242.20224.155)
cucumber-java (242.20224.159)
com.sourcegraph.jetbrains (7.0.4-nightly)
Kotlin: 242.20224.300-IJ
Bug Description
Platform: macOS
Steps to reproduce:

Have Cody plugin installed in your JB IntelliJ editor
Login to Cody with Free/Pro user
Click on Chat History tab

Observed behavior:
Chat History shows empty. If user click on New Chat then it will load correctly.
Expected behavior:
Chat History associated with this account should load correctly.
Additional context
Video link:
https://drive.google.com/file/d/1HMyuJmzgX71M6kAiJzfTW_ZTUDPpxzdt/view?usp=drive_link

This is fixed now. Closing.


feat(table): The name of newly created list/table entities should be default name of attribute + index

Steps to Reproduce:

go to proxy. app and fetch table, create a new row, and open it. It will now have the name "date".

Expected behavior.

Want the name of the tab to be the name of the attribute + index. (counter)

This is not a bug. The blueprint for Task (job) extends from /mtsmo/basic/NamedEntity in which "date" is the default value for name. This is correct behaviour in other words


Update kubernetes.md

Added useClusterAdmin to the Azure Resource Manager section which wasn't documented here, yet.
You can find the details here:

KubernetesV1/task.json
Kubernetes@1 - Support for admin credentials?
KubernetesV1/src/clusters/armkubernetescluster.ts

@heoelri : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@azooinmyluggage - Could you review the proposed changes as the content owner/author? Thanks.

@heoelri could you fix the merge conflicts?

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ds-ms The merge conflict is resolved now.

looks good

@ktoliver if you have write access, could you merge this PR?


Convert the input text in the form to json object

This will return a json object containing data entered by the user when he/she clicks the "Submit" button.

Merging.


Make darksidewalletd compatible with getAddressUtxo call

Right now darksidewalletd is not compatible with the new getAddressUtxo call for lightwalletd.
Desired outcome: In darksidewalletd mode the getAddressUtxo call will return the correct results based on the blocks that have been created in the darkwalletd instance

Merged. But the plan to "return the correct results based on the blocks that have been created in the darkwalletd instance" did not pan out; it was necessary to add a new darksidewallet gRPC to populate the list of Utxos which are then returned by the production gRPC GetAddressUtxos. Kevin and Pacu said this is okay.


Add Example for demo Entity and EntityManager please

Hi @DonnYep
I am learning the framework, and the Examples list is awesome so far. For now, I am learning Entity and EntityManager but I can not search for any example code in CosmosFramework
A simple game with players, enemies, and bullets with reuse entities, and exchange events, would be great!
Thank you!

Hi @codingwatching
Thank you very much for your approval of my framework, entity module I will add new cases based on your suggestions. Also please contact me if you have any questions, it is a great encouragement for me that you use my framework!
Thank you!

@DonnYep I am waiting for this!  Thank you so much for the added examples so far
Have a nice weekend!

@codingwatching The example of entity module is in the development, I will finish and submit it as soon as possible.

Hi @codingwatching
I have uploaded a simple entity demo. if you want to learn how to write a full game by using cosmosframework, please follow the cosmosframework-demo repo and I will develop a more fully functional rpg game in my spare time in the future : ) .

The name of entity demo is "23_EntityLauncher".

Hi @DonnYep It is a big gift for me! Let start a week with learning Entity Example!
Thank you so much!


NTR: phenylalanine restricted diet

Parent: dietary intervention (MAXO:0000088)
Label: phenylalanine restricted diet
Exact synonym: low phenylalanine diet
Definition: Dietary approaches avoid excessive phenylalanine consumption, including stringent dietary restriction of natural protein intake, and supplementation of amino acids other than phenylalanine by a chemically manufactured protein substitute.
Reference: PMID:20720592, PMID:20971365
Avoidance: phenylalanine containing foods or derivatives, artificial sweeteners, excess protein intake
Primary use cases:
Phenylketonuria, Tyrosinemia Type 1, potentially therapeutic for ochronosis from alkaptonuria

Yes, add this.


Minor spelling errors.

'space-ime' to 'space-time'
'vaccum' to 'vacuum'

Fixes #198 <Put_Issue_Number_Here>

@arnav257 Thanks for your contribution. Welcome to the EPY community.
@shreyasbapat LGTM

Amazing @arnav257 :)
Looking forward to more contributions :) Congratulations !


enable per custom resource vault password usage in ansible operator

Feature Request
Describe the problem you need a feature to resolve.
As an ansible operator user, I would like to be able to configure the vault password used to eventually decrypt secrets encrypted with ansible-vault.
Describe the solution you'd like.
I would like to be able to put a specific secret name in the custom resource watched by the operator, like: "vaultPasswordSecretRef" or similar
Based on that parameter, during the reconciliation, the underlying ansible command would be launched with the "-e vault-password=<my_vault_password_secret_ref.data.password|b64decode>" (or dumping a temporary file in the container and using vault-password-file).
This way I would be able to use one of the most interesting feature of ansible; encryption of parameters, and this on a per custom resource bases.
The only way I found at the moment is to declare the default vault password on an environment variable at operator deployment time, which is not multi-tenant (I can only use one password per ansible operator deployment).
I did not consider vault password id in the solution, I would like to keep - one secret = one set of custom resources - logic.

/language ansible

Adding on the story,

the Secret reference(s) could be a list instead of a single reference
the key used in the Secret data could be a parameter, potentially a list - with a defaulted value - default value could be all keys values or a single key value
Secret reference sample:

apiVersion: v1
kind: Secret
type: Opaque
data:
  vaultPassword1: "b64(password1)"
  vaultPassword2: "b64(password2)"
  vaultPassword3: "b64(password3)"

the CustomResource could read the secret references in multiple ways, maybe the specifications is not the most appropriate, it could also be "a" or "some" annotation(s), this way it will not impact the CRD specifications at all. For example something like:

ansible.sdk.operatorframework.io/vaultSecretReference<Name>:  <Secret name in the same namespace as the CR>
ansible.sdk.operatorframework.io/vaultSecretReference<Name>Keys: <comma separated list of keys to consume - default to all (or "password" for example)>

@fabianvf, @camilamacedo86
Sorry to disturb you, I think you are relevant people to contact when it comes to ansible operators, but could you give your opinion on this idea? Would it be possible? Do you think it worth it?

With who that discussion must be initiated? Can somebody act upon it ?

@fabianvf and @asmacdo would be the best contacts here.


DNN-6404 There should be more meaningful word

in the help text. SImple change, but somebody has to do it.
Good excercise for working with GitHub as well

code reviewed and MarkAllPagesTranslated does not use placeholders, so I will merge this into 7.4.1


Add numeric header to histogrammar

Hi, I added the  header as that is technically where std::iota is to be found. It will work without  on some compilers but not all, but with  it should work everywhere. Found out because it didn't want to compile on g++ 5.3.1, but works on g++4.9.3 without issues.
See: https://www.daniweb.com/programming/software-development/threads/421379/stl-iota-not-found

Thanks! I didn't know anyone was watching. I'm pushing an API-change through the three implementations: Scala is done, Python is next, and C++ will follow. I'll additionally need to add a Cut primitive to C++ for the change to be testable. (It's the first item on the brand-new https://github.com/diana-hep/histogrammar/wiki/RoadMap)
Out of curiosity, how did you hear about this?

I think I saw it posted somewhere a few weeks ago (maybe the Fermilab facebook page?) and I've been wanting to look at it ever since. Had a bit of time on my hands this week (waiting for jobs to finish running) and thought I would look into the code a bit. Also, Scala is next on my to-learn list so i wanted to have a look at scaroot.


faust: make faust2sc script available

Description of changes
faust2sc is a script that is part of faust to generate SuperCollider UGens this pr makes it availble via nixpkgs.

Things done

Built on platform(s)

[ x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2083

@magnetophon i had to add some path arguments to the faust2supercollider that I would expect to be already setup by faust itself.
The problem doesn't appear if i Faust within my setup, but when i use faust2supercollider within a flake i had to use those two path arguments:
faust -I ${pkgs.faust}/share/faust -A ${pkgs.faust}/include

(-pathlist shows the paths visible to Faust)
I made faust2supercollider work. But I would suggest to wrap Faust itself having these two arguments.

I realized there is a better build script for SuperCollider UGens provided by faust. The suggestion to wrap faust is still relevant.

@olafklingt Thanks for making this!
Unfortunately I only used supercollider briefly, a long time ago and I have never used any flakes.
I'm happy to test this, but you're going to have to give me some guidance!

hi @magnetophon  i am also still learning how to use flakes but it was a good exercise to create a test environment test a faust generated UGen you can use this repository as described in the readme to test this PR https://github.com/olafklingt/faust2sc_test
if it doesn't work please tell me here or on matrix

@olafklingt Thanks for the test repo!
Unfortunately, when I run nix run github.com:olafklingt/faust2sc_test#, I get:
error: input 'github.com:olafklingt/faust2sc_test#' is unsupported.

@magnetophon ah sorry nix run github:olafklingt/faust2sc_test#

Cool, that works.
Except that's not a 200Hz tone, but OK.  :grin:

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/920

what needs to be done to merge this?


Build Option is not visible for WPF app in app center

[I have using WPF app in app center, but could not able to find the Build option for WPF apps, is build option  available wpf app?]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6bad7023-e00b-b6af-b71f-1823e7829dec
Version Independent ID: 77a10f16-f669-3934-08b3-ceefa52b2059
Content: App Center Build Troubleshooting - Visual Studio App Center
Content Source: docs/build/troubleshooting/index.md
Service: vs-appcenter
Sub-service: app-center-build
GitHub Login: @King-of-Spades
Microsoft Alias: kegr

Unfortunately Build doesn't support WPF: https://docs.microsoft.com/en-us/appcenter/general/platform-service-matrix


Create a docker image.

Please create a working docker image for image processing.

Hi, thanks for your interest.
I do not use docker. We have introduced how to install the environment in the README.MD file. Please follow it :)


lammps crashes without exception

If an error occurs in the lammps library (e.g. using lammps.py etc), the process immediately exists (without an exception).  The current Lammps library (written in c++) just prints out an error message and returns a non-zero exit status (i.e. exit(1) ) when an internal error occurs.

We have to evaluate changing this so an exception is thrown that is seen by the python-lammps interface and ultimately SimPhoNy.


Better phone number filtering for twillio and SMS in integrations page

Problem
Right now if you enter a phone number without the area code or have the wrong formatting in phone number section it will fail silently and not work. We should make sure that there is a country code and that it can work regardless of the text formatting

Solution
It should validate that it has a country code and we shouldn't care about formatting

@a8t you might have some context on this

Twilio has a free phone number validator service that we already use for something else. Maybe we can also pair with a client-side validation. (is a phone number regex stupid?)

Yeah I think just some client side validation + string formatting would be ideal. It doesn't work if we add spaces in to the phone number


maybe export instance with conifg argument better than export class and configed in rc

open a entrance for config friendly
easy config builder in app, express, koa and egg.js
easy make a plugin by builder in koa and egg.js
class SequelizeSearchBuilder {
  constuctor (config) {
    // merge defaultConfig
    this.config = config;
  }
}

module.exports = config => new SequelizeSearchBuilder(config);

Fixed in 77941eeb0fb47ea247328b854046682064b81962

README.md has been updated.
You can use setConfig method for redefining configs (not third argument in constructor)

https://github.com/axolo/sequelize-query


(WIP/Collaboration) rewrites for delegation graph issues

The core task here is to rewrite roledb, a central TUF module, and the code that uses it.
The primary motivation comes from issue #660, a confusion regarding roles and delegations that has led to a variety of issues in the code.
Additional motivation comes from these principles:

This is a reference implementation and code must be intuitive and readable.
Define once and use that definition.
Constrain TUF users (including systems like Uptane...) as little as possible.  Expose simple APIs.

The result of this work should be a codebase that:

Does not confuse core TUF concepts like role and delegation.
Has deterministic verification of delegated role metadata.
Has only one internal structure for metadata.  Any representation of metadata in memory should be in the basic structure that the metadata would take when written to disk.  This means that the schemas used for roledb (or any in-memory representation of metadata) should avoid any extra fields and avoid being organized in a different way than the written metadata would.  For example, this means that delegation information like paths and keyids go in the delegating role, not in the delegated-to role (as they now do).
Employs and validates data structures defined in tuf.formats and securesystemslib.formats.
Uses flexible, simple code like build_dict_conforming_to_schema (or that style of code) wherever reasonable.

@adityasaky
Plan of action for the next steps:
Step 1: Schema updates
So, I'm changing the schemas in tuf.formats that define data structures in the reference implementation.  That's going to break lots of things.  I'm almost done, and it's hard to assign something out before that, but I can show you what I have so far in a WIP commit I'll push to this branch in a few minutes and you can plan out changes to make following them.  Additional changes might be necessary later, of course, but I expect to have the schemas done before I leave today.  We can chat, though, too, and maybe some parallel task will emerge from something one of us thinks of. :)
Note that every little thing doesn't need to have its own schema.  We want the schema definitions to be succinct and readable, so bouncing around a lot is not ideal.
Step 2: RoleDB Rewrite
After the new definitions, one of the main things that needs to happen is that someone needs to go over roledb to see how things need to change based on those schema changes, keeping in mind the stuff that motivated those schema changes (see top post in this PR)
Note that there are some comments / TODOs I added / am adding suggesting how things should work.
Step 3: updater and repository_lib edits
Updater and repository_lib will need to employ the new roledb code, which in some cases will result in refactoring in that code, and a few API changes.  Repository_tool and some other modules may also require similar adjustments.

The most breaking thing in the last commit (draft of new schema definitions in formats.py) is the removal of ROLEDB_SCHEMA.  That was was another internal representation for metadata (the one reorganized such that delegation information was stored under a delegatee).  Instead, roledb should use ANYROLE_SCHEMA or the individual metadata roles' schemas as appropriate (e.g. TIMESTAMP_SCHEMA).
ROLES_SCHEMA is what will live in roledb._roledb_dict, one for each repository

Once we're all done, writing metadata will just involve canonicalization, serialization, and signing.  It won't require rebuilding roles based on information listed under other roles, for example.  That will then mean we can expose that internal representation in roledb (indirectly but pretty transparently) to users of TUF, to allow things like Uptane adding a Timeserver key to root metadata, then telling TUF to write and sign.

Rebased after merge of #836.

@adityasaky tells me that he has the basic roledb tests working after the schema changes now, so the next step will be looking through repository_lib to make the changes necessary there, guided by test failures.  After that (or, possibly during, depending on how far repository_tool's issues extend into repository_lib), it'll be time to deal with repository_lib, and that's where this work will start to get pretty involved.  The interface that repository_tool provides (e.g. repository.targets.threshold) will need substantial refactoring or API changes to deal with the fact that delegation properties like keyids, threshold, paths, etc. are properties of the delegating role, and specific to a delegation (identified by two roles, not one role).
After that, we can move on to the client side and updater.py, where verification code will need to be updated and the edge-case security issues related to #660 will be resolved.  If the interface issues with repository_tool prove onerous to work around, it may be reasonable to deal with updater.py before repository_lib and repository_tool.

@adityasaky is working with updater first, so here's where the bulk of the load there lies:
updater has one primary mechanism for obtaining trustworthy target information for a particular target: Updater.get_one_valid_targetinfo().  That function performs a pre-order depth-first walk down the delegation graph until it finds a trustworthy source of that target info, updating (and verifying) any necessary delegated targets role metadata along the way.  That stack -- which needs to be refactored, probably at another time -- is explained well in #841.  In short, the stack, in seeking to update and verify the delegated targets role, eventually calls tuf.sig.verify, without passing the optional keyids and threshold arguments that it should pass, just expecting, instead, tuf.sig.verify() to figure out how to verify a delegated targets role, which it cannot reliably correctly do without knowing the delegating role.
That's where the fix for the primary part of #660 lies: providing tuf.sig.verify() with the right keyids and threshold, which Updater.get_one_valid_targetinfo() knows because it knows what delegation it's following to get to the delegated targets role it's updating and verifying.
Because the #841 stack is so stringy before a refactor is done, the easiest way to do this is to pass down keyids and threshold through all those function calls, as new optional arguments....
So that's your next task, @adityasaky. :)
I'll push to this PR some changes to tuf.sig.verify() that will make it exacting about when keyids and thresholds are passed to it.  The only times verify() doesn't need keyids and thresholds are when it's verifying a top-level role, because then the information always comes from root.
Aside from this, there will doubtless be other, more minor changes, to match the updated schemas and renamed roledb functions, but I hope those are much easier.

Great work, guys, keep it up!

@adityasaky
Pushed changes to tuf.sig that you can use for tuf.client.updater revisions.  They'll be maximally annoying about arguments provided to verify() / get_signature_status() to make sure that the revised tuf.client.updater code is correct about how it uses them.  (They'll expect keyids and threshold to be provided to them unless they're verifying top-level roles.)
Didn't fix test_sig.py here yet.

@adityasaky
Those test_sig.py edits remove some unneeded stuff and add TODOs for after the roledb changes are merged into here.  (The tests will require that roledb be functional.)

Great job, guys, your hard work has not gone unnoticed 🙇
Would there be a simple API for users to verify all signatures on a loaded repository?

Would there be a simple API for users to verify all signatures on a loaded repository?

Such an API function would depend on this work, but not come as part of it.  It's possible to write a function afterwards that loads a repo and verifies all top-level roles, then crawls down the full delegation graph and verifies every edge or reports any unverified edges.

Got it, thanks!

@adityasaky
You asked about where to get the keyids and threshold to pass down to tuf.sig.verify().
Note that _preorder_depth_first_walk() reads delegations and adds (relevant-to-the-target) roles that it finds there to its stack (LIFO) of roles to process as a result.  Since it's reading the delegations, it simultaneously has access to the keyids and thresholds the delegating role expects, and that's the information you'll have to pass down through the function stack all the way to tuf.sig.verify() when you're trying to verify that delegated-to role.
Personally, I thought about a 3-mer queue (role, keyids, threshold) instead of a role queue, but there are a few ways to handle this....
Note that part of the task when updating something like this is considering the expectations in edge cases.  For example:

Is there a traversal dictated by _preorder_depth_first_walk that results in keyids & threshold associated with a role when they're read not being the right ones when they're later processed? ((I don't think so.))
Is there something about the visited-roles system (intended to avoid cycles) that breaks when multiple delegations to the same role are considered?  For example, if a role is considered visited when it fails to be verified along one delegation, will it be skipped if encountered along a different delegation (where a verification might succeed)?  ((I don't think this is an issue because of what is supposed to happen when role verification fails, but see what you think.))

Due to imminent refactor efforts this code is unlikely to merge.


Online Exhibition: banner issue

Adding the Neon Signs exhibition as 'banner' content to the homepage breaks the site (it returns a 404).
Steps to recreate:

Add new banner content on Homepage Matrix.
Select Neon Signs from search and save the page.
Observe results.

Thanks, fixed!


Add AppVeyor integration

Build with #491: https://ci.appveyor.com/project/davidebeatrici/softethervpn/build/Build-1
Build without #491: https://ci.appveyor.com/project/davidebeatrici/softethervpn/build/Build-2
Commit ee1d84361efcccf480b3b4ab23a91a70429e2e3c adds support for Visual Studio 2008 Express, as the ATL/MFC resources are included in Windows Driver Kit 7.1.0.
Visual C++ 2008 Express and Windows Driver Kit 7.1.0 are pre-installed on both Visual Studio 2013 and Visual Studio 2015 images.
The LNK4099 warnings happen because the static libraries we have in the repository should have dedicated PDB files, but they are missing.
@dnobori Could you add these files to the repository, please?

SoftEther VPN Patch Acceptance Policy:
http://www.softether.org/5-download/src/9.patch
I choose option 1.

Done.

Cool. This time, I'd actually like to rebase these commits into the master branch instead of squash, since each commit is actually self contained and achieve one isolated task. Agree?

I strongly agree.

Cool. Then please adapt the version in .appveyor.yml as agreed and we can merge :)

I replied to your comment, but the discussion is now marked as outdated as I pushed the changes.

{build} is required.
What about {build}-{commit-sha1}?

4-1e94d9e
https://ci.appveyor.com/project/davidebeatrici/softethervpn/build/4-1e94d9e

I see that you have created the project on AppVeyor, but the build failed.
That's because I decided to change the default configuration name appveyor.yml to .appveyor.yml.
You can set it in the project settings, under the General tab: "Custom configuration .yml file name".

build-{build}-{commit} is fine

Ah ok. then we can use my appveyor for the time being, until we agree on the others on how to actually manage this kind of stuff, in case me or Daiyuu died tomorrow :)

I changed {build}-{commit} to build-{build}-{commit}.
https://ci.appveyor.com/project/davidebeatrici/softethervpn/build/build-5-69347d3
When you login to AppVeyor via GitHub, you can choose between your personal profile and the organization one.
If you login with the organization one, you can create the project which will be accessible by everyone who is part of the team.
The URL will be https://ci.appveyor.com/project/softethervpn/softethervpn.

It turned out that I should not login into appveyor using my github, instead create a new account using username/password then add authorize apveyor to use github

I just rebased your changes and I'm really excited about them. Many thanks for your hard work

You're welcome!

The build failed, as expected: https://ci.appveyor.com/project/SoftEtherVPN/softethervpn/build/build-2-b29ca0b
Once #491 is merged, it should succeed.


Add resource metrics for Druid

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Global Administrator Required

When trying to implement this policy I get an error saying Global Administrator is required even though the documentation says Security Administrator (my current active role) and Conditional Access Administrator should also be able to create.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 53b567e4-ba41-7042-f978-08fd33c4bb39
Version Independent ID: 263331ca-358e-420d-4ae7-dde93c69ed84
Content: Conditional Access - Block legacy authentication - Azure Active Directory
Content Source: articles/active-directory/conditional-access/howto-conditional-access-policy-block-legacy.md
Service: active-directory
Sub-service: conditional-access
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@brettaweston
Thanks for your feedback! We will investigate and update as appropriate.

@brettaweston
Thanks again for your input.
Findings:
I was able to create a conditional access policy to enable MFA with the Security and Conditional Access Administrator roles. However, following the documentation, I received the same error message you did, when trying to block legacy authentication via CA.

Looking into this further, I found that you do need to be a Global Admin to enable a Conditional Access Policy with 'Exchange ActiveSync' enabled.

I have created a PR to update the documentation so it's more clear, and will now close out this issue. Please allow some time for the changes to reflect and if you don't see the document update, please let me know.
I will be more than happy to re-open this issue and look into what happened.
Thank you for your time and patience!


Fix incorrect implementation of IAsyncDisposable in BackgroundService

https://docs.microsoft.com/en-us/dotnet/standard/garbage-collection/implementing-disposeasync

Fixed by https://github.com/zcoinofficial/zsharp/commit/94547ae38a36fd30093f340fa6dab0eef970fc27


Query how is this compared to christopherbatty/SDFGen?

I have been using the christopherbatty/SDFGen about a year ago, where the SDFs are used in our filter from the link below
https://www.myminifactory.com/object/3dfilters?frame=0&model=33936&target=sphere&filter=Morphing
I am just queries how does your sdfgen compared to his?

Heyho,
armory3d/sdfgen is a gpu-based implementation, christopherbatty/SDFGen appears to be a cpu-based implementation. Generally armory3d/sdfgen aims to favor speed, so the results may be less precise.


Email templates

Updates and adds templates as provided by @APherwani, updates and adds helper functions as applicable.
Adds static files, (temporary solution, should have static assets hosted on a CDN in the future)

resolves: #47
resolves: #48

Checklist:

[x] Add or update the relevant docs.
[x] Add an entry in CHANGELOG.md summarizing the change.
[x] Run tests, with no tests failed.

One more thing, can you send me an email from both templates as an additional sanity check. You have my email.

One more thing, can you send me an email from both templates as an additional sanity check. You have my email.

I can; however, the static assets will not render as that required the backend to be updated with this pr.


Getting val_loss=nan always

Hey guys so just to clarify in your case, after how many epochs you start getting a loss different than nan?
I first tried and stopped after 5 epochs. Then I changed to 100. I just wanted to know how many epochs you will start getting some results !

Your code is outdated. Update it first. See the commit b7cbd24.

@qqwweee @elcronos do you fix it? I have the same problem. And  the code is new

Here is my solution, hope it would help
https://github.com/qqwweee/keras-yolo3/issues/171#issuecomment-522287613


Compilation warning

Ubuntu 14.04
gcc 4.9.4
curlite.hpp:298:57: warning: comparison between ‘enum curlite::OptionLongCode::<anonymous>’ and ‘enum curlite::OptionInvalidCode::<anonymous>’ [-Wenum-compare]
         static_assert( OptionTypeCode<ValueType>::value != OptionInvalidCode::value, "the type is not supported by curl_easy_setopt" );

Hi Victor,
I'm sorry for this long delay in my response. The issue is fixed after d91a907.
Thank you.

It does fix the warning thank you!


Can't install on OSX

I have install openssl with homebrew and ran brew link --force openssl.
I tried installing go-sqlcipher with go install github.com/xeodou/go-sqlcipher and I get the following:
ld: library not found for -lcrypto
clang: error: linker command failed with exit code 1 (use -v to see invocation)

I was messing around trying to get this working and I found that if I change:
#cgo LDFLAGS: -lcrypto

to
#cgo LDFLAGS: -L/usr/local/opt/openssl/lib -lcrypto

in sqlite3.go then it compiles properly. I can't figure out how to get it working without that modification which I feel should probably not be needed.

This seems to have fixed it for me.
export LIBRARY_PATH="/usr/local/opt/openssl/lib"


Fixed Swift 2.2 build warnings

This change fixes build warnings in the OAuthSwift target when using the latest version of Xcode.

I think converting a for to a while must move the increment/modification code at the end of the block
Or the first case will be missing

Good spot @phimage on the while issue, this should be fixed now.


ability to rename tinker console files

add ability to rename tinker console files
autoincrement files default by IntelliJ
naming convention without spacers and brackets

@Roboroads any feedback?


[Blueprints, all] Loadbalancer not being deleted causes tf destroy to fail

Could possibly be a race condition
╷
│ Warning: EC2 Default Network ACL (acl-0bb1c751ce6d3b468) not deleted, removing from state
│
│
╵
╷
│ Error: deleting EC2 Subnet (subnet-0d21d5729923852e9): DependencyViolation: The subnet 'subnet-0d21d5729923852e9' has dependencies and cannot be deleted.
│ 	status code: 400, request id: f381ee78-69dc-4c57-940b-f3aac1ad945f
│
│
╵
╷
│ Error: deleting EC2 Subnet (subnet-03d24ee9f4bd6e5be): DependencyViolation: The subnet 'subnet-03d24ee9f4bd6e5be' has dependencies and cannot be deleted.
│ 	status code: 400, request id: 8dbec214-976f-417e-ae73-eeca60abac76
│
│
╵
╷
│ Error: deleting EC2 Subnet (subnet-08b859259dae46484): DependencyViolation: The subnet 'subnet-08b859259dae46484' has dependencies and cannot be deleted.
│ 	status code: 400, request id: 349641d0-3c79-431a-9171-673fc1ed45c5
│
│
╵
╷
│ Error: deleting EC2 Internet Gateway (igw-0e686cb558c91368b): detaching EC2 Internet Gateway (igw-0e686cb558c91368b) from VPC (vpc-018c607b6927cd288): DependencyViolation: Network vpc-018c607b6927cd288 has some mapped public address(es). Please unmap those public address(es) before detaching the gateway.
│ 	status code: 400, request id: e9835b5c-ea6e-4d94-a0c5-1771e8820b47
│
│
╵
╷
│ Error: uninstallation completed with 1 error(s): context deadline exceeded
│
│
╵

After deleting the loadbalancer, tf destroy fails with
╷
│ Error: deleting EC2 VPC (vpc-018c607b6927cd288): operation error EC2: DeleteVpc, https response error StatusCode: 400, RequestID: c73aca26-db62-4cb2-bd82-ee1cda52a579, api error DependencyViolation: The vpc 'vpc-018c607b6927cd288' has dependencies and cannot be deleted.

The dependencies are two security groups:

[k8s] Shared Backend SecurityGroup for LoadBalancer
[k8s] Managed SecurityGroup for LoadBalancer

After those are deleted, tf destroy worked.

I have opted finally from separating the namespace creation out of the helm release resources. It is expected to delete all the  objects which depends on it


Convert Command Line Codes To Client

Hello,
I have one command in Linux which is working. I want to use your client but I could not figure it out how.
sudo  docker build . -t tagName && docker run -it --network=host --add-host raspberrypi:address tagName
Can you help me how I can change it to your client?
Thanks

Have you read the user manual? That is a good place to get started.
If you've already read that and tried a few things but you’re still stuck, then let us know what you've tried, what did or didn't work, what errors you saw, etc.

Closing due to inactivity. Please open another issue if you're still having problems.


i installed luckPerms in my plugins foldier but it doesnt work

Iv put luckPerms in my plugins foldier but its not installed

A bit more info would be appreciated.

What server platform are you running (Spigot, Sponge, etc) and what version?
Which version of LuckPerms have you tried to install?
Are there any errors in your console during start up? Check your console logs.

Reply with that info and we might be able to help you.

Feel free to reopen this ticket when you have more info to give


Getting an error

Hello, I am getting this error.
D:\app\app\orderingapp2\android\app\build\generated\rncli\src\main\java\com\facebook\react\PackageList.java:15: error: package com.pusherwebsocketreactnative does not exist
import com.pusherwebsocketreactnative.PusherWebsocketReactNativePackage;
^
D:\app\app\orderingapp2\android\app\build\generated\rncli\src\main\java\com\facebook\react\PackageList.java:121: error: cannot find symbol
new PusherWebsocketReactNativePackage(),
symbol:   class PusherWebsocketReactNativePackage
I am using
"@pusher/pusher-websocket-react-native": "^1.1.1"
"react-native": "^0.64.2"
OS: Windows 10
Platform: Android
Can you please let me know how I can solve it?

I'm not sure of react native 0.64 is supported, that's quite an old verion

Can you please let me know if there is any way to work pusher for this react native version?
Thanks

Did manually linking the library help resolve this for you, @avijit-ordering ?

Hi @tdammy92 - best to raise your own issue here.
Closing this one as we haven't had a response since providing a solution at https://github.com/pusher/pusher-websocket-react-native/issues/49#issuecomment-1315700385

Hi @benw-pusher .
First, I am very sorry for the late response. As per your instruction, I have tried with manually linking (react-native link) but getting same issue still now.
Thanks.

Same issue here using exact the same environment
OS: Windows 10
Platform: Android
"react-native": "^0.64.2",
"@pusher/pusher-websocket-react-native": "^1.1.1",
Any solution yet, please?

@MursiDirect
Please add the bellow into build.gradle
classpath ('org.jetbrains.kotlin:kotlin-gradle-plugin:1.6.10')


[REVIEW]

Please ensure that you dont have any personal details in your Portfolio that you dont want to share publicly.
Portfolio link: https://skyhero-admin.github.io/
You can also join the discord community here
Feel free to check out other cool repositories of EddieHub Community here

NIce portfolio, looks good, some I have for you:

the text above these icons is not clearly visible (HTML, CSS). It is almost the same as the background color.

The social media links on the left side will look better if they are left-aligned.

These are just my preferences tho...🙂

Take a look at the text here

This is a duplicate I think

Thanks for the suggestions @Prince-Shaikh  I am planning on fixing the dark text  😅
Should I remove that text or change the color ?

Take a look at the text here

This is a duplicate I think

Ohh
thanks for the suggestion
Are you talking about the last two sentences ?
Should I change the footer text to make it look a little different 🤔

Thanks for the suggestions @Prince-Shaikh  I am planning on fixing the dark text  😅
Should I remove that text or change the color ?

Changing the coulor to white should look good...🙂
Add some space above it too.. it'll give some breathing room to the text.

Check this out aswell

Check this out aswell

Sure I will check it out

Can you suggest me about what type of fonts I should use @Prince-Shaikh

Can you suggest me about what type of fonts I should use @Prince-Shaikh

Helvetica and roboto are the fonts that I like to use. You'll have to see which one suits you better tho. 🙂

ohk

Can you explain the text issue again I didn't get it properly @schmelto 😅

Ohh
thanks for the suggestion
Are you talking about the last two sentences looking very similar?
Should I change the footer text to make it look a little different 🤔

and

Can you explain the text issue again I didn't get it properly @schmelto 😅

Yes thats what I would say :)

ohk 👍

@Skyhero-admin you meant to close this one? It would be still up for Livestream review if you reopen it :)

ohk
thanks for informing @schmelto 😁

I will probably open it again after some time


Create Threat-Model-Owasp-Pages.md

HI,
When the merge is done, can you please put this content to the top of the content section. The three groups in the session will upload their own outcomes which need to go under this current pull requests content.
Thanks!
Andrew

Let me know if merge worked as intended.


clamscan reports released rpm may have coinminer (even 1.30)

I'm running clamscan on ntfy binary distributed with the rpm bundle and its reporting
/usr/bin/ntfy: Unix.Packed.Coinminer-6856324-0 FOUND

Not quite sure the details. But I ran this on 1.30 as well.

This is a dup of https://github.com/binwiederhier/ntfy/issues/576.
This has been addressed and will likely not happen again in the next release.

My apologies. This is such a rare occurrence it did not even dawn on me to search for it already :-)

It is quite annoying. upx is fantastic at making binaries a lot smaller. But somehow upx-compressed Go binaries have been getting flagged by virus scanners for years. :shrug:


Website reference

Reference to a whole website or a specific article on a website.
User Stories
Author

Production staff

But what if . . . ?

Considerations

eLife requires an accessed date for all web references (date-in-citation).
At eLife, the minimum information for this reference type is:

Authors
Year
Title
URL
Accessed date

Source website is optional.

XML requirements
eLife uses the attribute publication-type="web".
<element-citation publication-type="web">
    <person-group person-group-type="author">
      <name>
        <surname>Harmon</surname> <given-names>A</given-names>
      </name>
    </person-group>
    <year iso-8601-date="2019">2019</year>
    <article-title>James Watson had a chance to salvage his reputation on race. He made things worse</article-title>
    <source>The New York Times</source>
    <ext-link ext-link-type="uri" xlink:href="https://www.nytimes.com/2019/01/01/science/watson-dna-genetics-race.html">https://www.nytimes.com/2019/01/01/science/watson-dna-genetics-race.html</ext-link>
    <date-in-citation iso-8601-date="2019-01-01">January 1, 2019</date-in-citation>
  </element-citation>

eLife allows the following children of element-citation[@publication-type="web"]:

person-group
year
article-title
source
ext-link
publisher-loc
publisher-name
date-in-citation

person-group can contain child name or collab.
It would make sense to mandate the following elements:

person-group (containing at least one name or collab)
either a article-title or a source
ext-link

further examples:
<element-citation publication-type="web">
    <person-group person-group-type="author">
        <collab>NIfTI-1 Data Format</collab>
    </person-group>
    <year iso-8601-date="2016">2016</year>
    <article-title>Neuroimaging informatics technology initiative</article-title>
    <ext-link ext-link-type="uri" xlink:href="https://nifti.nimh.nih.gov/">https://nifti.nimh.nih.gov/</ext-link>
    <date-in-citation iso-8601-date="2018-02-11">February 11, 2018</date-in-citation>
</element-citation>

<element-citation publication-type="web">
  <person-group person-group-type="author">
    <name>
      <surname>Sever</surname> <given-names>R</given-names>
    </name>
  </person-group>
  <year iso-8601-date="2018">2018</year>
  <article-title>Twitter post. 1 Nov 2018, 9:29 AM</article-title>
  <ext-link ext-link-type="uri" xlink:href="https://twitter.com/cshperspectives/status/1058002994413924352">https://twitter.com/cshperspectives/status/1058002994413924352</ext-link>
  <date-in-citation iso-8601-date="2019-04-12">April 12, 2019</date-in-citation>
</element-citation>

Taken from: https://github.com/elifesciences/TextureRequirements/issues/81

partial support - uri used in place of ext-link

No user stories at present to check this feature against


Updated desktop and mobile values for component-edge-to-visual-only

Updated desktop and mobile values for component-edge-to-visual-only tokens.

Spacing changed due to new workflow icon sizes.

N/A

N/A

[ ] Patch (bug fixes, typos, mistakes; non-breaking change which fixes an issue)
[x] Minor (add a new token, changing a value; non-breaking change which adds functionality)
[ ] Major (deleting a token, changing token value type; fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] I updated the token in all applicable sets. This applies if updating, adding, or deleting a token that has data across different sets (for example, if the value differs across color themes.)

TESTING spectrum2-non-colors
READING spectrum-tokens: /spectrum-tokens/packages/tokens/src/
READING   tokens studio: /spectrum-tokens-studio-data/src/tokens-studio/spectrum2-non-colors/
TOKENS STUDIO DATA IS NON-COLOR ONLY
SPECTRUM SYNC SUMMARY
CHANGED VALUES: (8) component-edge-to-visual-only-100/desktop, component-edge-to-visual-only-200/desktop, component-edge-to-visual-only-300/desktop, component-edge-to-visual-only-50/mobile, component-edge-to-visual-only-75/mobile, component-edge-to-visual-only-100/mobile, component-edge-to-visual-only-200/mobile, component-edge-to-visual-only-300/mobile impacting 5 tokens

TEST COMPLETE

SYNCING spectrum2-non-colors
READING spectrum-tokens: /spectrum-tokens/packages/tokens/src/
READING   tokens studio: /spectrum-tokens-studio-data/src/tokens-studio/spectrum2-non-colors/
TOKENS STUDIO DATA IS NON-COLOR ONLY
SPECTRUM SYNC SUMMARY
CHANGED VALUES: (8) component-edge-to-visual-only-100/desktop, component-edge-to-visual-only-200/desktop, component-edge-to-visual-only-300/desktop, component-edge-to-visual-only-50/mobile, component-edge-to-visual-only-75/mobile, component-edge-to-visual-only-100/mobile, component-edge-to-visual-only-200/mobile, component-edge-to-visual-only-300/mobile impacting 5 tokens

WROTE: /spectrum-tokens/packages/tokens/src/layout.json
SYNC COMPLETE
Spectrum Tokens Pull Request


Install pip for compatibility with Vagrant ^2.2.5

Initially running vagrant up gave me the following error:
    drupal-cms: Installing pip... (for Ansible installation)
The following SSH command responded with a non-zero exit status.
Vagrant assumes that this means the command failed!

pip install  --upgrade ansible

Stdout from the command:

Stderr from the command:

bash: line 5: pip: command not found

This led me to https://github.com/hashicorp/vagrant/issues/9584 and https://github.com/hashicorp/vagrant/issues/10950#issuecomment-514023810. The following change fixed it for me.

I had the same issue and this change fixed it for me!

Thanks @geerlingguy! I tried to do something similar in Vagrantfile.local and couldn't figure it out. Could you elaborate?

Also, regarding:

especially one that sudo bash's a downloaded file

Giving this a closer read hashicorp/vagrant#9584:

Vagrant's ansible does the sudo bash to install pip. The "bug" in this case seems to be that  "ansible_local installs pip before it installs ansible"
@gildegoma says the reporter did, "the right thing [by] implementing your own ansible setup via a shell provisioner"
@gildegoma then proposes as a fix to, "introduce a new pip_install_command option, with
"curl https://bootstrap.pypa.io/get-pip.py | sudo python" as default."

To be clear, I'm all in favor of avoiding scripts piped to bash, but if I'm understanding, it seems avoiding that would mean writing your own ansible installer.
Perhaps a route forward for DrupalVM is here:

you can extend your shell provisioner to also install ansible, and then configure the ansible_local provisioner to not install ansible by setting the install option to false.

Thoughts on the above @geerlingguy ?


Ability to use ChatGPT session token?

I pay for ChatGPT premium and wondering if it's possible to use my session token so I don't need to pay for api usage?

I doubt that the session token will work on the API because they are separate services. I could be wrong though. I agree with you; it's a bummer that we have to pay for both. I sometimes think about canceling my premium and just use the API instead.


Exception when using .analyzeImage in v3.0.0-beta.4

iOS
Trying to execute:
MobileScannerController barcodeCameraController = MobileScannerController(formats: [BarcodeFormat.upcA]);
late StreamSubscription barcodesStreamSubscription;

...

barcodesStreamSubscription = barcodeCameraController.barcodes.listen((capture) {
      capture.barcodes.forEach((barcode) {
        print('CAM: ${barcode.rawValue}');
      });
      barcodesStreamSubscription.cancel();
    });

    await barcodeCameraController.analyzeImage(_myImgFile.path);

Get exception.
flutter: type '_InternalLinkedHashMap<Object?, Object?>' is not a subtype of type 'List<dynamic>' in type cast
flutter:
#0      MobileScannerController._handleEvent (package:mobile_scanner/src/mobile_scanner_controller.dart:349:30)
#1      new MobileScannerController.<anonymous closure> (package:mobile_scanner/src/mobile_scanner_controller.dart:31:27)
#2      _rootRunUnary (dart:async/zone.dart:1399:47)
#3      _CustomZone.runUnary (dart:async/zone.dart:1300:19)
#4      _CustomZone.runUnaryGuarded (dart:async/zone.dart:1209:7)
#5      _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:339:11)
#6      _DelayedData.perform (dart:async/stream_impl.dart:515:14)
#7      _PendingEvents.handleNext (dart:async/stream_impl.dart:620:11)
#8      _PendingEvents.schedule.<anonymous closure> (dart:async/stream_impl.dart:591:7)
#9      _rootRun (dart:async/zone.dart:1383:47)
#10     _CustomZone.run (dart:async/zone.dart:1293:19)
#11     _CustomZone.runGuarded (dart:async/zone.dart:1201:7)
#12     _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:1241:23)
#13     _rootRun (dart:async/zone.dart:1391:13)
#14     _CustomZone.run (dart:async/zone.dart:1293:19)
#15     _CustomZone.runGuarded (dart:async/zone.dart:1201:7)
#16     _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:1241:23)
#17     _microtaskLoop (dart:async/schedule_microtask.dart:40:21)
#18     _startMicrotaskLoop (dart:async/schedule_microtask.dart:49:5)

Noticed that in mobile_scanner_controller.dart
case 'barcode':
        if (data == null) return;
        final parsed = (data as List)
            .map((value) => Barcode.fromNative(value as Map))
            .toList();

When scanning with camera data is list, and when with analyzeImage it's a single element of the list.

Facing the same Error. Tried to get the BarCode out of the Controller after analyzeImage returned true

Can you please try again with version 3.0.0?

Tried it but its not really working
Its just not detecting any QR Codes which are detected without problems in the camera


[CI] Migrate e2e conformance test to prow

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:
/kind bug
/kind feature

What happened:
This issue is to track migration of e2e conformance tests to prow
parent issue: https://github.com/kubernetes/cloud-provider-openstack/issues/1613
What you expected to happen:
How to reproduce it:
Anything else we need to know?:
Environment:

openstack-cloud-controller-manager(or other related binary) version:
OpenStack version:
Others:

related issue to be taken care https://github.com/kubernetes/cloud-provider-openstack/issues/1562

/unassign

/remove-lifecycle stale


The page will not be updated

I changed my code, but when I hot restarted or recompiled, the page didn't change. The version of flutter is 1.22.3.

Hello @WangVkwind ,
Could you please post the outputs of flutter run -v and flutter doctor -v and a complete minimal reproducible code sample?
Thank you!

@sidrao2006 For example, I added a new menu option, but it is not displayed on the app page. I deleted the build folder, recompiled, and restarted; none of this worked.


Suppress CS1702 warning

Motivation
We suppress CS1701 already, but the 1702 binding redirect warnings is also unnecessary. This is triggered in some more advance SDK configurations.
(cherry picked from commit 6d1d7bddcd1aa92638d7f81f79f39c0bda594ff5)

/merge


Avoid showing tags from remote visualizations

Related: https://github.com/CartoDB/product/issues/208
In \tags we should only return the ones from visualizations with derived or table type.

You are right. I thought that remote visualizations were hidden, but I see they are shown in the data library tab from the old dashboard... I'll add the type parameter. Thanks!

@jesusbotella can you have a look to the front change? https://github.com/CartoDB/cartodb/pull/14661/commits/cf15eb2bcaf7976285ef6b6d5fb70fa85ff80790

retest this please

Acceptance 🍏


Consider dropping YAML 1.0 support

For the v2 release, I'm thinking of dropping support for YAML 1.0. If this would inconvenience you, please let me know by commenting here.

For attranslate, I would prefer to not drop YAML 1.0: https://github.com/fkirc/attranslate
In the world of translations, all kinds of ancient and unexpected files can occur.
The aim of attranslate is to take any YML-file and "just work".

@fkirc Have you encountered any actual YAML 1.0 file that would not properly parse using a later version of the spec? I've collected a list of the differences here: https://eemeli.org/yaml/#version-differences

Until now, I did not know the differences between those versions, therefore it is hard for me to give a definite answer right now.
Nevertheless, I would propose to keep YAML 1.0 in a "best effort" support:

Retain compatibility in cases where a breakage would only lead to minor code-simplifications.
Only break compatibility for sub-features that actually complicate internals of the YAML-parser (as opposed to just a few more lines of code).

For some context, YAML 1.0 came out in January 2004, and YAML 1.1 in January 2005. Most simple "YAML 1.0" documents will parse fine with any YAML version, it's only in some of the deeper details that differences emerge.
And I do think that in order to continue supporting a spec that's now 15 years out of date, a bare minimum would be to identify at least one user with one actual YAML 1.0 document that requires some special consideration. I don't really know what else might be required, but that at the very least.

For some context, YAML 1.0 came out in January 2004, and YAML 1.1 in January 2005. Most simple "YAML 1.0" documents will parse fine with any YAML version, it's only in some of the deeper details that differences emerge.

This is exactly the thing that I meant with "best effort support". On one hand, I hope that most simple "YAML 1.0" documents will continue to work in the future.
On the other hand, I fully understand if you drop support for arcane features that are hard to maintain and hard to test.


Update AutoRest C# version to 3.0.0-beta.20220901.3

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
API changes are not detected in this pull request.

@archerzz  Thank you very much for the merge!


Fix incorrect 'install Mattermost server' section in Ubuntu 20.04LTS guide

Thanks to @esadur for noticing!
@justinegeffen @svelle @amyblais I'm going to merge this after one review because someone going through the install guide won't successfully complete the installation. However, Amy/Sven/Justine I would ask each of you to verify that the doc I added is the correct one.
The doc section I added is the same one used for Ubuntu 16.04LTS and 18.04LTS guides: https://github.com/mattermost/docs/blob/master/source/install/install-ubuntu-1604-mattermost.rst

To add:
20.04LTS guide TOC

18.04LTS guide TOC


SAK-49258 Webapi: Add endpoints to get and bulk update various entities

https://sakaiproject.atlassian.net/browse/SAK-49258

Could you check the Maven Build please? It's failing

Yes, I have a fix. I needed to do change to the GradingService

@mpellicer This should be ready now!


Improve sweeper stats

The introduction of exclusive groups in the sweeper means multiple sweeping transactions might be published in the same sweep round, but currently only the last one is stored and published back on restart.
Ideally, the sweeper should actually track all published transactions and act on them according to what happens afterwards (whether they are successfully mined, RBF'd, whether they are now invalid due to one of its inputs getting spent on a different mined transaction, etc).
Opening this issue in lnd to see if it's reasonable here since I need to solve (some aspects of) this in dcrlnd due to some differences in SPV vs Neutrino mode.

The introduction of exclusive groups in the sweeper means multiple sweeping transactions might be published in the same sweep round, but currently only the last one is stored and published back on restart.

The rebroadcast of the last transaction is in order to handle an edge case (is this still an issue @joostjager?). The sweeper does not offer any guarantees that inputs offered will be swept if a shutdown occurs, they need be to re-offered on startup to resume.

Ideally, the sweeper should actually track all published transactions and act on them according to what happens afterwards (whether they are successfully mined, RBF'd, whether they are now invalid due to one of its inputs getting spent on a different mined transaction, etc).

Could you describe what problems this would solve for you? The current design acts on a best-effort basis and does not rely on broadcast errors (since it can't for light clients). Inputs are rescheduled randomly regardless of the broadcast result to eventually converge on a valid set of inputs that will result in a valid transaction. Things get tricky here of course when taking into account all of the RBF rules, but we've decided not to implement those for now.

Ideally, the sweeper should actually track all published transactions and

Could you describe what problems this would solve for you?

Allow external clients to track what's happening on the sweeper (which transactions were attempted, fees, what happened to them, etc) without having to go through logs.
See next answer for what prompted opening this.

The current design acts on a best-effort basis and does not rely on broadcast errors (since it can't for light clients).

Indeed. I must've made a mistake running the test, because I was sure it was actually relying on the broadcast errors. But anyway, the issue I'm facing can be surfaced by running this diff with the following icase:
make build-itest itest-only backend="neutrino" icase="test_multi-hop_htlc/committype=anchors/remote_chain_claim"
The test failure itself is unrelated to this particular issue (I already have a fix for that). A sample of the debug data introduced in the diff:
lnd_test.go:139: vvvvvvvvvvvvv  before close vvvvvvvvvvv
lnd_test.go:139: vvvvvvvvvvvvv  before mining close vvvvvvvvvvv
lnd_test.go:135: 973f7ffd1639a9624aeb6b93e29aef749a2db97997fdae851dc1f4e69cf032a4:0
lnd_test.go:135: 1d771c9dae17aa7a52387b710877283f1903fca675245e3d069ad318b0982ca8:0
lnd_test.go:139: vvvvvvvvvvvvv  after mining close vvvvvvvvvvv
lnd_test.go:135: 973f7ffd1639a9624aeb6b93e29aef749a2db97997fdae851dc1f4e69cf032a4:0

And the relevant lines from output-2-Alice log:
2020-05-08 08:19:02.802 [INF] SWPR: Creating sweep transaction 1d771c9dae17aa7a52387b710877283f1903fca675245e3d069ad318b0982ca8 for 2 inputs (440ef8164df227e82543be7c504b10337a1f664809a6ca65337cd83f4c140aeb:0 (CommitmentAnchor), dcdedb8ccd6ae221c09736e3427294e0792b2fb620209516f772b9a771df194c:1 (WitnessKeyHash)) using 253 sat/kw, tx_fee=0.00000181 BTC

2020-05-08 08:19:03.304 [INF] SWPR: Creating sweep transaction 973f7ffd1639a9624aeb6b93e29aef749a2db97997fdae851dc1f4e69cf032a4 for 2 inputs (b567d0e7818a07719ee628a0ee0db3d2f4da1286d8a1615c08b5281a52e6983d:0 (CommitmentAnchor), 79342a7482441971d7a6b18a76adf473eb01c5cadf3f3b987fcf5ca36405f907:0 (WitnessKeyHash)) using 253 sat/kw, tx_fee=0.00000181 BTC

2020-05-08 08:19:07.885 [DBG] SWPR: Dispatching sweep success for 440ef8164df227e82543be7c504b10337a1f664809a6ca65337cd83f4c140aeb:0 to 1 listeners

2020-05-08 08:19:07.885 [DBG] SWPR: Dispatching sweep error for b567d0e7818a07719ee628a0ee0db3d2f4da1286d8a1615c08b5281a52e6983d:0 to 1 listeners: other member of exclusive group was spent

ChanArb creates two transactions to redeem the anchor outputs (one for the local commitment tx, one for the remote). One of them gets confirmed, the other one just became invalid. However, the neutrino wallet will now have an unconfirmed utxo "forever". Note that the other commitment is technically an orphan (not a double spend) since the other commitment tx was never even broadcast.
This is how I'm solving this for the moment: https://github.com/matheusd/dcrlnd/compare/master...matheusd:upstream-v0.10-priv
This is kinda crappy though because it only works "incidentally" for the test. Whence the purpose of this issue: to actually take correct actions in regards to the wallet, the sweeper should be keeping track of every published sweep attempt so that it can detect when something got invalidated (so it can abandon the specific tx instead of blankly attempting to abandon transactions-spending-an-input), how many different attempts it made via RBF/CPFP to sweep something, stats for what actually got swept and when, etc.
I don't expect fixing this to be simple or immediate though: I opened this more to get an opinion on whether this is a reasonable thing to do and to be able to track progress (in case that it is).

I haven't looked through your changes thoroughly yet, but perhaps it is better to introduce this logic at the btcwallet level (the repo itself, not our wrapper over it)? It already has some logic to remove double spend conflicts, but I'm not sure if it can handle the case you've outline above.

We briefly discussed this alternative around here (solving in {btc,dcr}wallet).
AFAICT, to have this solved in the wallet would require the wallet tracking the entire chain of unconfirmed of transactions, so it can act when any one of the transactions in the chain becomes invalid. It would have to be presented the other commitment tx, so it can know which inputs to track or alternatively, it would have to track orphan credits (that is, credits originating in transactions which inputs can't be found in the utxo set) separately as well.

The rebroadcast of the last transaction is in order to handle an edge case (is this still an issue @joostjager?). The sweeper does not offer any guarantees that inputs offered will be swept if a shutdown occurs, they need be to re-offered on startup to resume.

Yes, this is still code that is needed.
// Republish in case the previous call crashed lnd. We don't care about
// the return value, because inputs will be re-offered and retried
// anyway. The only reason we republish here is to prevent the corner
// case where lnd goes into a restart loop because of a crashing publish
// tx where we keep deriving new output script. By publishing and
// possibly crashing already now, we haven't derived a new output script
// yet.

Sweeper has been reengineered significantly. Don't think this issue applies anymore. Should be reassessed and reopened if still an issue.


Can't Highlight/Copy DBeaver Version

In dBeaver <IP_ADDRESS>908041900, on Windows 10, it will not allow you to highlight and copy the dBeaver version from the Help > About dialog.
Since the version numbers are 15 characters long, this ability would be helpful during bug reporting.

Good point

Verified

Yep. I noticed this today. You can copy the version now. Thanks.


[microTVM] Enable micro tvmc tutorial testing in CI

This PR changes micro_tvmc.py tutorial to a bash script tutorial. Also it adds a python script which converts a bash script tutorial to python format for doc generation.
I have added the script conversion to lint task to make sure the generated python tutorial passes the format.
cc @areusch @driazati

@areusch I added test file and address your comments. PTAL, thanks!


Set job descriptions in benchmark runner

Signed-off-by: Andy Grove<EMAIL_ADDRESS>The benchmark runner causes multiple jobs to run to set up the input files as tables, and potentially multiple jobs can run to execute the query being benchmarked. This makes it difficult to collect metrics from the Spark event log during benchmark runs because it isn't obvious which jobs and stages are for setup rather than query execution.
This PR sets job descriptions so that it is easier to parse the Spark event logs for benchmark runs.
Example output:
{"Event":"org.apache.spark.sql.execution.ui.SparkListenerSQLExecutionStart",
  "executionId":0,
  "description":"Register input tables"

{"Event":"org.apache.spark.sql.execution.ui.SparkListenerSQLExecutionStart",
  "executionId":24,
  "description":"Benchmark Run: query=q16; iteration=0"

This closes https://github.com/NVIDIA/spark-rapids/issues/1118

build

build


The HTTP request to the Query Service should be sent from the back-end

The HTTP request to the Query Service could be sent from the back-end, and not the Front-End (JavaScript). In most scenario, it may be better.
https://github.com/OpenRefine/SparqlExtension/blob/95784b3577395bf3f13faabae0e318f4ec9dd649/module/scripts/index/sparql-source-ui.js#L27

Sure. Then we will have to do away with the Sparql.js

Nice. Good work.
Regards, Antoine


Add badges

close: https://github.com/chaspy/gh-contrib/issues/5

@kamontia please review and merge

OK! No problem! Yahoo~


Collapse - do not prevent event for input

Stop preventing event for input in Collapse
/CC @mdo and @bardiharborow
Fixes #22049, fixes #21079

Seems fine by me!


crash when backstabbing

crashes while backstabbing an enemy

i have it too

@danielkrupinski pls fix

It only happens if you have a custom knife from the skin changer and It's not only backstabbing but when you kill some with the knife from front too. Verified the game files, didn't work.


Build failed due to missing data folder at root directory

Hi,
I found a fix for this but unfortunately I don't have time to pull/modify/push etc., so I figured I would put it here so you can make the quick update.
Playbook failed here:
TASK [emmetog.jenkins : Create Jenkins user] **********************************************************************************************************************************************************************************************************************************
fatal: [hostname]: FAILED! => {"changed": false, "failed": true, "msg": "useradd: cannot create directory /data/jenkins\n", "name": "ubuntu", "rc": 12}
Manual fix:
If there is no /data directory on the target, create one manually.
This means that I have to add an extra step to my VM creation script to create a /data directory. Obviously that works for me for now, but it would be good to have this fixed / improve the error handling for it so other users don't run into the same issue.
Hope this helps.

In your playbook you should override the setting for jenkins_home. Based on the error you posted I assume you are installing it on Ubuntu. If you want to use the default Jenkins work directory (defined by the jenkins_x.y.z_all.deb) your playbook could look like
---
- name: your Jenkins install playbook
  hosts: ...

  vars:
    # default Jenkins home
    jenkins_home: /var/lib/jenkins
    ...

  roles:
    - emmetog.jenkins

I just ran into this - running on centos with yum.
You are currently setting the default in defaults/main.yml as /data/jenkins.
If it is the case that we must redefine the jenkins_home variable, you should remove it from the default and error out if it is not defined. Otherwise maybe verify/create the directory ?


feat: add support for useragent Fluent filter

This PR adds support for using the https://github.com/bungoume/fluent-plugin-ua-parser Fluent plugin where Fluent plugins are applicable.
Depends on: https://github.com/kube-logging/fluentd-images/pull/88

I'm stuck a bit, can't really interpret the failing E2E test, or connect it to my changeset.

I'm stuck a bit, can't really interpret the failing E2E test, or connect it to my changeset.

I reran the CI and it passed, seems like the TestVolumeDrain_Downscale might be flaky, sorry about that!

The  directives don't seem to render right in Markdown, that's why I left with ```yaml.
Not sure what's downstream, if this'll be straightened out in the docs, just checking in if this was intended.

 The directives don't seem to render right in Markdown, that's why I left with ```yaml.
Not sure what's downstream, if this'll be straightened out in the docs, just checking in if this was intended.

Yeah, that is alright, it is deliberate. The generated *.md files will be consumed by Hugo and it will render it properly (indentation and highlighting wise as well).


Make block enum/flag values discoverable in the toolbox

For example, in Arcade sprite flags are not discoverable from the toolbox. You have no clue there's a "destroy on wall" option until you drag this block out and use the drop down:

I suggest that we create a separate block in the flyout for each value in the enum so that each flag value is discoverable, and perhaps each flag value could even be sorted into the appropriate category (e.g. "physics", "image", etc).
This would also have the nice side-effect of fixing: https://github.com/Microsoft/pxt/issues/5364

I don't think we are doing this.


crome debugger not working

Issue Type: Bug
crome debugger not working with new vs code version
VS Code version: Code 1.21.1 (79b44aa704ce542d8ca4a3cc44cfca566e7720f1, 2018-03-14T14:46:47.128Z)
OS version: Windows_NT x64 10.0.15063

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-4590 CPU @ 3.30GHz (4 x 3292)

Memory (System)
15.92GB (8.00GB free)

Process Argv
C:\Program Files (x86)\Microsoft VS Code\Code.exe c:\dev.net14\deviceF1\OrganizerO365

Screen Reader
no

VM
0%

Extensions (21)

Extension
Author (truncated)
Version

angular-material
1to
0.13.0

html-snippets
abu
0.2.1

vscode-angular2-files
ale
1.4.3

ng-template
Ang
0.1.9

angular2-snippets
dan
1.0.19

jshint
dba
0.10.18

githistory
don
0.4.0

gitlens
eam
8.2.0

tslint
eg2
1.0.28

git-project-manager
fel
1.5.1

auto-close-tag
for
0.5.6

auto-rename-tag
for
0.0.15

githd
hui
1.1.3

Angular2
joh
2.16.1

Angular-BeastCode
Mik
6.0.6

vs-keybindings
ms-
0.2.0

team
ms-
1.122.0

debugger-for-chrome
msj
4.3.0

rxjs-snippets
pko
0.0.2

vscode-icons
rob
7.22.0

autoimport
ste
1.5.3

Reproduces only with extensions

Please include as many details as possible about the problem, and try updating to 1.22 which was just released.


System-wide webhooks

#10545 was indeed too basic. This PR attempts to add webhooks that work system-wide, regardless of repository. The intent is to allow a savvy sysadmin to extend Gitea's functionality by being able to listen for all events - opened PRs/comments to add Jira cards to, deleting Docker images for the repo, etc. This also leaves default webhooks intact with a lot of code reuse but I fear it may be a tad confusing.
Tasks:

[X] Create a new column to differentiate system webhooks from default ones
[X] Adjust the router to serve both hooks and system-hooks reusing the same handlers
[X] Tweak the creation of webhooks to determine if setting a value in the new column is necessary
[x] Create modifications to the template and locales to explain the differences between the two
[x] Fetch system webhooks and make use of them during events
[ ] Add API endpoints (will attempt in a separate PR)
...and probably something else

I'm more than happy to receive any feedback. This is my biggest PR so far but I'm growing quite fond of Go! 🚀

@lafriks Oh yep! false and 0 should be different things... 👍

Looking at what's currently there, there's no API for default webhooks. Should I look at trying to add that for both default and system webhooks (maybe another PR) or just leave everything as-is?

You can leave that for different PR. If code is too large it is harder to review and it takes more time to get it merged

Codecov Report

Merging #10546 into master will decrease coverage by 0.02%.
The diff coverage is 8.69%.

@@            Coverage Diff             @@
##           master   #10546      +/-   ##
==========================================
- Coverage   43.76%   43.73%   -0.03%
==========================================
  Files         586      587       +1
  Lines       81764    81836      +72
==========================================
+ Hits        35784    35791       +7
- Misses      41542    41606      +64
- Partials     4438     4439       +1

Impacted Files
Coverage Δ

models/migrations/migrations.go
4.16% <ø> (ø)
:arrow_up:

routers/admin/hooks.go
0% <0%> (ø)
:arrow_up:

models/migrations/v128.go
0% <0%> (ø)

routers/repo/webhook.go
1.24% <0%> (-0.04%)
:arrow_down:

routers/routes/routes.go
86.27% <100%> (ø)
:arrow_up:

models/webhook.go
66.98% <38.09%> (-1.73%)
:arrow_down:

modules/webhook/webhook.go
43.88% <50%> (+0.27%)
:arrow_up:

modules/indexer/stats/queue.go
62.5% <0%> (-18.75%)
:arrow_down:

modules/indexer/stats/db.go
40.62% <0%> (-18.75%)
:arrow_down:

modules/git/utils.go
65.67% <0%> (-4.48%)
:arrow_down:

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 421e7b7...cb03e88. Read the comment docs.

Please resolve the conflicts

Make lgtm work

What about adding a changelog label?


run on push and PR for main and develop branch

Trigger github actions on PR and push for develop and main branches

THe CI is now running as expected it can be merged in. We might use this in future to deploy to GCP 'automatically'