Styling: standardize icons

Apologies if there is already an issue for this!
We've discussed it in the front end meetings but i found a really obvious example of mixing icons, so felt it was worth a github issue:

There are two different trash cans and two different copy icons in the above image.
May be advantageous to address at the same time as web-eda #933
Depends on https://github.com/VEuPathDB/CoreUI/issues/67

other related tickets:
https://github.com/VEuPathDB/web-eda/issues/936
https://github.com/VEuPathDB/web-eda/issues/927


Itch problems

v.0.9.24 - Windows UI
This new version where icons are preferred to BigPicture is nice! 👍
But, I keep having problems with icons for games from itch

None of the games from itch have their icons downloaded.

I cannot reproduce this in the newest version, can you try 0.9.25 ?

Reproduced on windows, fix incoming

Should be fixed in version 1.0.0 (if not, let me know)


undefined when try to access to object property

Hi, probably a stupid question, but when i try to access to a property of this object, for example Trasm or RevDateTime i see undefined on the console.
This is the output of the parsed result
console.dir(res);
{   'n1:DatiCorrispettivi': {     '$': {       'xmlns:n1': 'http://local.doc/docs/xsd/corrispettivi/dati/v1.0',       versione: 'COR10',       'xmlns:ds': 'http://www.w3.org/2000/09/xmldsig#',       'xmlns:xsi': 'http://www.w3.org/2001/XMLSchema-instance'     },     Trasm: [ [Object] ],     RevDateTime: [ '2021-04-01T20:49:37+02:00' ],     DatiRT: [ [Object] ]   } }
when i try this console.dir(res["RevDateTime"]); i see undefined
usually i access object property with the dor or square brackets property accessor but nothing work here.


fix: reload changed configuration file on watch mode

Fixes issues where configuration file changes were not reloaded in watch mode, https://github.com/vitest-dev/vitest/pull/2886#issuecomment-1436519446

The options here is mutated by multiple Vite hooks.
https://github.com/vitest-dev/vitest/blob/b67a5fbdf9940191573c5f90d94be7a2ecb26a36/packages/vitest/src/node/plugins/index.ts#L155-L161
Once it has been initialized by first server setup, the deepMerge will take previous values of options instead of using the fresh viteConfig. This PR will restore the options back to initial values when in watch mode.
Tested watch mode locally in linked project by changing test.reporters and test.coverage.provider. I don't think Vitest has any watch mode related tests set so just manual testing for now.

Also I don't really understand what is happening here

The VitestPlugin is created only once. Its hooks are called first when server is initially set up, and again always when watch mode re-triggers it. As the hooks are modifying the given options, the deepMerge on the shown lines will behave differently when watch mode re-triggers.
https://github.com/vitest-dev/vitest/blob/b67a5fbdf9940191573c5f90d94be7a2ecb26a36/packages/vitest/src/node/plugins/index.ts#L155-L161
Here on the first run the options is the CliOptions. On second run it is the complete merged configuration of the first run, as VitestPlugin is not re-created. As options is the last argument, it has priority over the viteConfigTest. So the fresh values from viteConfigTest are overwritten by earlier run's options.
To be honest it's quite difficult to follow the flow here as all hooks are sharing the mutable options and modifying it. Does the explanation make any sense? 😅

Conflict 👀


We need a way to know if we handled the current url

Hi. I can reproduce the issue with the example project.

The app is successfully launched from a deep link
I leave the app and either I terminate the app or I wait for the app to be terminated by the OS
I open the app again
The deep link logic is being triggered again with the same deep link

This impacts the user experience as they do not expect to be taken to a deep link page when opening the app from scratch. Surely there must be a way to clear the deep link history.

There is no history. This package is all about forwarding intents to flutter side.
Are you sure your app was terminated? On which platform?

You are right. It is not actually terminated, but restarted from VS Code. If the app is truly started from scratch, it does not have the deep link anymore.
Sorry for the confusion.


Default config

Do you think print() and StatusCodes should be made default? We'd definitely want to see percentiles at the end of the test run and HTTP status codes are useful as well. I'm thinking more towards new users.

We already committed a a PR to print() by default which will be in 0.16 when released, see:
As of https://github.com/tag1consulting/goose/pull/379
I'm not opposed to changing --status-codes to --no-status-codes so we collect and display the Status Code table by default, PR welcome (documentation will also need to be updated). The current default is because there is a small amount of performance and memory overhead to enabling this option, but I generally always enable it when I'm running load tests anyway so it's a logical default.

Where's the Goose binary?
$:~/projects/goose$ cargo build --release
Finished release [optimized] target(s) in 0.12s
$:~/projects/goose$ cd target/release/
$~/projects/goose/target/release$ ls
build  deps  examples  incremental  libgoose.d  libgoose.rlib

Goose itself is a library, so there is no binary. You can build an example to create a binary, or create a load test as documented in the book to create a binary with it.


I can't download the PDF again on Safari

Hi there, I am using HTML2PDF.JS to make a PDF from an HTML page that I have but I am facing some issues on it.
My code looks like this and it works perfectly on chrome/firefox/etc except Safari. Could you please help?
In the commented part I was trying to just save it without opening, it works perfectly everywhere except on Safari where it works for the first time but then it doesn't work at all after that until a session is restarted.
function ExportToPDF(element){
                var elementA = $(element)[0];
                html2pdf().from(elementA).toPdf().get('pdf').then(function (pdf) {
                    window.open(pdf.output('bloburl'), '_self');
                    /*pdf.save('PaySlip.pdf');*/
                    /*window.location.reload();*/
                });
            }

I'm experimenting around with things that I'm somehow probably not even understanding but I'd really appreciate the help on anyone who is aware of how this issue can be solved. Safari is the only browser causing this issue on both iOS and MacOS.

I had the same problem, do you fix it?

Yes, I have the same issue, Please help me to resolve this issue


Dependency updates

Hey @arimus, looks like there are a lot of dependency updates in the queue. We can configure renovate to automerge patch and minor updates if that's helpful, but the major versions should get a closer look from a maintainer. Let me know if you need any help here!

@trevor-scheer Not a worry. I've had some family stuff to take care of and have been afk / out-of-town off and on for the past month. Didn't mean to fall behind, but such is life :) Pushed a new version with almost all the upgrades, but the node-fetch upgrade was a royal pain and will have to be done later. Happy to accept a pull request if you know the magic combo of dep updates and settings.


TOOLS-2897 Add shared workflow

Description
This is part of the ITGC initiative ensuring all business-critical repos are compliant. The codeowners-validator must be present to ensure the integrity of the code review process

Adds codeowners-validator to workflow

Jira Ticket
https://scribdjira.atlassian.net/browse/TOOLS-2897
Testing Considerations

[x] See github actions workflow

@athtran it looks like the shared workflow is failing to parse for this repository. It was failing before as well. From a quick glance I'm not sure what the problem is. Wanna have a look?
cc: @kamranf

Superseded by #13.


exa: remove perl dependency

Motivation for this change
The perl dependency does not seem to be necessary (anymore?).
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 115056 at 4f841cba run on aarch64-linux 1

1 package failed to build:

exa

Result of nixpkgs-review pr 115056 at 4f841cb run on aarch64-linux 1
1 package failed to build:

Unrelated failure in building the pandoc dependency.


[BUG] Pomodoro page Bug

https://akshitagupta15june.github.io/Moksh/Pomodro_page/reward.html
The lower text is merging with footer

Hi @akshitagupta15june can you assign this to me as part of GSSOc?

@Developer-Swati would u like to work on this

Ok I will try.

can i work on this issue akshitagupta15june if any one are not working


Include filter icon at SvgIcon component

Release Type: non breaking feature
Fixes https://x-team-internal.atlassian.net/browse/XP-2462
Description
New SVG icon called filter was added to SvgIcon.
Checklist

[x] set yourself as an assignee
[x] set appropriate labels for a PR (In Review or In Progress depending on its status)
[x] move respective Jira issue to the IN REVIEW column
[x] make sure your code lints (npm run lint)
[x] Flow typechecks passed (npm run flow)
[x] my change requires a change to the component's documentation (.snap)
[x] component's documentation (.snap) is changed or added accordingly
[x] if any snapshots have been changed, verify that component still works and looks as expected and update the changed snapshot
[x] manually tested the component by running it in the browser and checked nothing is broken and operates as expected!

Steps to Test or Reproduce

Check out http://localhost:6060/#!/SvgIcon

Impacted Areas in Application
SvgIcon
Screenshots

Remember to include the built lib. npm run build

oh, good call. I was sure that I had included that 😅

@reyronald the build was included, please take a look again when possible, thanks!


Create table of known good links for big companies

Done: Store 25 of the biggest employers official job links

This is done : https://docs.google.com/spreadsheets/d/1Kw5r6E0SZWXMAZ1kCRVW1xhgNVdm1i_sCjS8LPfhfYQ/edit?usp=sharing


Data viewer: add "Open with" menu

It would be handy to have new sub menu "Open with".
Initially we'll add Excel, outlook and HTML formats there.

XLSX and HTML apps are ready. Extra formats can added easily.
Also some extra UI buttons/switchers can be added.


remoteHub.logLevel not working ....repository button error on operation

Environment (please complete the following information):

OS (e.g., Windows 10):
Extension version (e.g., 1.2.3):

Describe the bug:

Repro steps:

Expected behavior:

Additional context:

Closing as incomplete. Please add more information about your exact problem for us to investigate.


Consider adding an option to not embed JS/CSS into the report

Jenkins serves static content with Content Security Policy enabled. By default, it doesn't allow to execute inlined CSS/JavaScript code and this prevents users to open Robot Framework reports when they were published during a build.
There is known workaround that people have documented: https://issues.jenkins-ci.org/browse/JENKINS-32118 but the only way to make it fixed properly is to modify the generated report to create separate files with JS/CSS code.
I suggest to add an option that will do that.

P.S. I've just realized that as part of this, we also need to decide on how to eliminate eval usage.

Having an option to save Javascript and CSS files into external files sounds good to me. But there are some design decisions to be made:

Should all JS content be written to a single file and all CSS to another, or should we just save the same JS/CSS files we normally embed to log/report on disk?

Should we allow disabling writing JS/CSS files? They don't change between runs (may change between releases) so old files can be reused.

Would the location where JS/CSS files are read by log/report be configurable? At least 2. doesn't make much sense otherwise.

Anyone interest to think about the design and, once we can agree on it, implement this enhancement?

@pekkaklarck Thank you for the quick feedback!

Should all JS content be written to a single file and all CSS to another, or should we just save the same JS/CSS files we normally embed to log/report on disk?

From CSP point of view, it doesn't matter because it only cares about the source (location) of the code and not about the number of files. So, I'd say this decision is more about maintenance and developers comfort.

Should we allow disabling writing JS/CSS files? They don't change between runs (may change between releases) so old files can be reused.

This looks like a minor optimization that affects only generation report time. I see that this procedure is performed often only when developers run Robot Framework locally. Is my understanding correct?
If yes, then we can start without this option and always overwrite generated files. This reduces a chance to have stale resources and violate of the least astonishment principle. Later, if we see a demand, we can implement it.

Should the location where JS/CSS files are read by log/report be configurable? At least 2. doesn't make much sense otherwise.

What the use cases are covered by this? I couldn't make up any, so I'd suggest to wait until we will get some.

I thought the problem with CSP was that Javascript originated from the workspace, not that it was embedded into the same file. If that's not the case, then just splitting JS to separate files ought to be enough. I'd be somewhat surprised about this because it would make avoiding CSP super easy in general.

I thought the problem with CSP was that Javascript originated from the workspace, not that it was embedded into the same file.

I looked at the page https://wiki.jenkins.io/display/JENKINS/Configuring+Content+Security+Policy again and I see that you're right -- Jenkis doesn't allow JavaScript in any forms :-(
So, in fact, we can't fully fix the issue on Robot side, only reduce a number of violations by not embedding CSS/images.

Closing this as the proposed change doesn't fix the CSP problem.


light/dark mode not working on website

Going to MVP site:
https://andybrewer.github.io/mvp/
...the light/dark mode nav option doesn't change the mode of the site. The text changes from dark-->light and back again, but nothing else.

Which browser? Seems to be working for me on Chrome.
On Fri, Oct 1, 2021 at 8:16 PM Chance Smith @.***>
wrote:

Going to MVP site:
https://andybrewer.github.io/mvp/
...the light/dark mode nav option doesn't change the mode of the site. The
text changes from dark-->light and back again, but nothing else.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/andybrewer/mvp/issues/71, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAABXNIWSSBVHAQROQFPHVDUEZ2QVANCNFSM5FF4NOTA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--
Andy Brewer


Automate FINOS Active Participants Quarter over Quarter Report

Grooming To Do
Related Bitergia issues :
Tracking month-over-month active participation
https://gitlab.com/Bitergia/c/symphony/support/issues/99

Given the introduction of LFX in our infrastructure, we are going to rely on those collaboration tools.
Closing issue and marking it with LFX label.


Implement new design of actions bars on mobile

Description
Implementation of the redesigned menu bars for mobile screens according to this design template.
Changelog

[x] Menu bars transform into expandable Fab on smaller screens
[x] Change the color of disabled icons for better visibility

ToDo

[x] Disable tooltips for action bar on mobile screens or enable them by long press (https://github.com/inovex/scrumlr.io/issues/1722)
[x] Layout the bars vertically and horizontally on mobile screens hidden in a burger menu
[x] Add activated buttons to fab in contracted state
[x] Find a better way to animate the expanding Fab options
[x] Remove old menu switch
[x] Fix Voting & Timer Menu on screens between smartphone and tablet size

Checklist

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] The light- and dark-theme are both supported and tested
[x] The design was implemented and is responsive for all devices and screen sizes
[x] The application was tested in the most commonly used browsers (e.g. Chrome, Firefox, Safari)

Looks good, thanks for the fixes.
It'd be nice if the menu would close automatically if the users press outside of it, and maybe even when pressing one of the menu buttons (i.e., the ready button). But we can implement that later (maybe even with a nice animation of the menu/close icons?) and merge this branch now

Oh sorry, I forgot about that 🙈  I have implemented a close-on-click-outside with the hook you mentioned.


question about cheat software

can we go through the wargods cleanly
Can we also hide the cheat when a person enters to control our computer via teamwiver?

It has not been attempted.
NO. but it's easy to add.
This was a test project. I don't plan on modifying or supporting anything else.

you can add hitbox fix or you can make a dll in such a way that it's not obvious in any way

This is not a problem, at least for this project, no.


Remove old Optimizely code snippets.

Changes

Removes old A/B test stuff. Not used by Drupal, and has since been built into the pitch page.

For review: @weerd

There was an issue for this! https://github.com/DoSomething/dosomething/issues/3251 hash tag refactor hash tag epic

A ha! Added the magic incantation to close that issue.

:boom: :+1:


Update parametric pulse documentation.

Summary
Closes #5226. Updates the documentation of gaussian, gaussian square and drag to include a description of pulse lifting.
Details and comments

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 83.117%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
51944

Relevant Lines:
62495

💛  - Coveralls

@taalexander: if you get a second and would like to check that I haven't messed your maths up, please do, but otherwise I'll leave this a day and merge tomorrow - I had another look through with fresh eyes and didn't spot any transcription errors.

Thank you very much for the help @jakelishman. I've made one minor correction that I noticed on review (I think it my error to begin with).


API Endpoint upload files to s3

summary:

install AWSSDK.S3
has a api endpoint to upload to s3, in local we need

S3_ACCESS_KEY
S3_SECRET_KEY
S3_BUCKET_NAME
S3_SERVICE_URL

I have the same variables in openshift

call api you may want to set the limit numbers of files and updatedBefore of for filter

looks good to me


typo issue with calendar part of docs

I found a typo while checking the calendar part of the document.
In Calendar Parameters, 'yearPicker' is spelled 'yeadPicker'.
Here is the image of that issue.


Implementing standardjs Linter

Description (Required)
Implements the standardjs linter. https://standardjs.com
Scripts
This modifies the npm run lint command as well as adds the standard options to package.json itself.
Dependency Changes
standard - https://standardjs.com
Also note that this removes all eslint* dependencies

Looks good @aphelionz! Thank you for adding the linter 👍

Agreed. Thanks, @aphelionz and @haadcode.


Logarithmic scale & interleaved data

Hi there,
your lib (almost) made my day, because I've been trying to read data from this website.
It contains traces of a frequency response analysis of a guitar effects pedal.
Spoiler alert: this falls in the "help needed" category, I couldn't select this while writing the issue.
I tried to read the following file with your lib and it kinda worked at the end, but I needed to make some changes and I ended up with three major questions.
The file: https://heartfx.net/ts9/disk/FRTONMID.DAT
What I changed:

In line 234, I needed to add value 4 to the data_type_decoder dict. No idea what it refers to, unfortunately. I just gave it an arbitrary name and it worked. No biggie.
I needed to comment line 585, where you're trying to incorporate the channel_correction_factor with the np.sqrt(2) division. That didn't work for an entire array of data. Maybe it's even a subsequent error. Also, no biggie imho.

 How on earth do I get the corresponding x-tics with the frequency? I mean, sure, the header shows start frequency and the range, but how do I need to iterate? Especially if like in my case, frequency was plotted/traced logarithmically?
How do I iterate over the y-values logarithmically?
I tried to determine the x-tics (frequency) by basically starting at the abscissa_first_x: 20 (Hz) and then dividing the entire frequency range (20Hz - 20kHz) by the number of points (401 in this case) and I'm getting the following plot.

Which absolutely irritates me, because it seems as if there are actually two sets of data kind of interleaved in there. What's happening there? I mean one of the graphs actually looks almost right. That hump shouldn't be at 16k, but at 10k. But that could have something to do with log vs. linear scale. But where's the second graph coming from?
I would appreciate ANY hint on how to correctly interpret this weird SDF format by HP. I can only find tiny pieces of information online, it seems as if this is very closed source. :(

The Standard Data Format (SDF) is defined in Appendix B of the "Standard Data Format Utilities User's Guide" version B.02.01, P/N 5963-1715. Figure B-6 shows the file structure and Table B-1 shows common records. Page B-27 starts the section Reconstructing a Trace, which has information calculating the x-values and y-values for a trace. I think that's your best bet to answer your questions.
Per the SDF Utilities User's Guide, the x-values are calculated as follows, since your x_resolution_type is logarithmic:
x0 = abscissa_firstX
x1 = x0 * abscissa_deltaX
x2 = x0 * abscissa_deltaX^2
x3 = x0 * abscissa_deltaX^3
.
.
.
xn = x0 * abscissa_deltaX^n (where n = num_of_points - 1)
given
abscissa_delta_x = 1.0174193661806048
abscissa_first_x = 20.0
x0 = 20 Hz
x1 = 20.34838732 Hz
x2 = 20.70284333 Hz
x3 = 21.063473742594 Hz
x400 = 19999.9999999607 Hz

In line 234, I needed to add value 4 to the data_type_decoder dict. No idea what it refers to, unfortunately. I just gave it an arbitrary name and it worked. No biggie.

I hadn't added all the data_type_decoder values. I'll add 4, which is Frequency response.

I needed to comment line 585, where you're trying to incorporate the channel_correction_factor with the np.sqrt(2) division. That didn't work for an entire array of data. Maybe it's even a subsequent error. Also, no biggie imho.

I was cheating, since I've only read data from an HP 35670A. This section of code needs to be cleaned up.

It also looks like I'm returning the wrong number of y-values when the values are complex.

Thanks for getting back!
The reconstruction of a trace on page B-27 is absolute gold! Thanks for sharing! Finally it makes sense :)
I think you're right about the number of points, I'm getting n=400, when in fact I get 200 points each of which being a complex value. Also, thanks for pointing out that my y values are complex, I wouldn't have figured that out on my own. But in that case, it makes total sense to interleave both real and imaginary values like that.
The only thing is, now I don't really know how to interpret the y values. You were right, the trace shows a frequency response of a guitar effects pedal from 20-20kHz. However, I was expecting the y values to be scalar values representing the amplitude of the signal in dB. Can I simply take the real values or do I have to sqrt(real^2 + img^2)?

I updated the code (v0.7.0) to return the y-data as python complex numbers when y_is_complex is true in the header file. You should be able to use abs() to determine the magnitude of the data.

There was an error in handling the complex data, which I believe is now fixed in v0.8.2. I created a sample repository that plots the data for the FRTONMAX.DAT, FRTONMID.DAT, and FRTONMIN.DAT files.  The plots match what is shown at Ibanez TS-9 Tube Screamer on the bench
, so I believe this issue is resolved and ready to be closed.

Thank you so much for all the info and the fixes of course.
I tested it and it works like a charm!
The only line of code I "stole" from your create_plot.py is:
y_data = 20 * np.log10(np.abs(sdf_data)) :)
I learned a lot about SDF format and HP analyzers.
Here's a piece of rationale why I'm doing this:
I wanted to figure out, where the TS effects pedal starts to "cut" low frequencies, i.e. where the graph crosses the zero line in the lows. Seems to be at around 170Hz. That's useful information for guitarists :)

Glad I could help. The sdfascii library is better for it and now supports more than just FFT measurements from an HP35670A.
FYI: I moved the sample repository to https://github.com/matthewrankin/sdfascii-examples


flatbuffers: 1.4.0 -> 1.8.0

Semi-automatic update. These checks were performed:

built on NixOS
ran /nix/store/2zfi5j6wmfb6hbaqmmsbarbjz8r5f333-flatbuffers-1.8.0/bin/flatc --version and found version 1.8.0
found 1.8.0 with grep in /nix/store/2zfi5j6wmfb6hbaqmmsbarbjz8r5f333-flatbuffers-1.8.0
found 1.8.0 in filename of file in /nix/store/2zfi5j6wmfb6hbaqmmsbarbjz8r5f333-flatbuffers-1.8.0

@GrahamcOfBorg build flatbuffers

Success on x86_64-darwin (full log)
Partial log (click to expand)
-- Installing: /nix/store/wgs37xag5zkxxbzahnln0mppd53zsq82-flatbuffers-1.8.0/lib/cmake/flatbuffers/FlatbuffersTargets.cmake
-- Installing: /nix/store/wgs37xag5zkxxbzahnln0mppd53zsq82-flatbuffers-1.8.0/lib/cmake/flatbuffers/FlatbuffersTargets-release.cmake
-- Installing: /nix/store/wgs37xag5zkxxbzahnln0mppd53zsq82-flatbuffers-1.8.0/bin/flatc
-- Installing: /nix/store/wgs37xag5zkxxbzahnln0mppd53zsq82-flatbuffers-1.8.0/lib/cmake/flatbuffers/FlatcTargets.cmake
-- Installing: /nix/store/wgs37xag5zkxxbzahnln0mppd53zsq82-flatbuffers-1.8.0/lib/cmake/flatbuffers/FlatcTargets-release.cmake
post-installation fixup
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/wgs37xag5zkxxbzahnln0mppd53zsq82-flatbuffers-1.8.0/lib  /nix/store/wgs37xag5zkxxbzahnln0mppd53zsq82-flatbuffers-1.8.0/bin
patching script interpreter paths in /nix/store/wgs37xag5zkxxbzahnln0mppd53zsq82-flatbuffers-1.8.0
/nix/store/wgs37xag5zkxxbzahnln0mppd53zsq82-flatbuffers-1.8.0

Success on aarch64-linux (full log)
Partial log (click to expand)
-- Installing: /nix/store/a4j7zcvlkxb8vvpnhk15qzgl9gzv7sqr-flatbuffers-1.8.0/lib/cmake/flatbuffers/FlatcTargets.cmake
-- Installing: /nix/store/a4j7zcvlkxb8vvpnhk15qzgl9gzv7sqr-flatbuffers-1.8.0/lib/cmake/flatbuffers/FlatcTargets-release.cmake
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/a4j7zcvlkxb8vvpnhk15qzgl9gzv7sqr-flatbuffers-1.8.0
shrinking /nix/store/a4j7zcvlkxb8vvpnhk15qzgl9gzv7sqr-flatbuffers-1.8.0/bin/flatc
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/a4j7zcvlkxb8vvpnhk15qzgl9gzv7sqr-flatbuffers-1.8.0/lib  /nix/store/a4j7zcvlkxb8vvpnhk15qzgl9gzv7sqr-flatbuffers-1.8.0/bin
patching script interpreter paths in /nix/store/a4j7zcvlkxb8vvpnhk15qzgl9gzv7sqr-flatbuffers-1.8.0
checking for references to /build in /nix/store/a4j7zcvlkxb8vvpnhk15qzgl9gzv7sqr-flatbuffers-1.8.0...
/nix/store/a4j7zcvlkxb8vvpnhk15qzgl9gzv7sqr-flatbuffers-1.8.0

Success on x86_64-linux (full log)
Partial log (click to expand)
-- Installing: /nix/store/2zfi5j6wmfb6hbaqmmsbarbjz8r5f333-flatbuffers-1.8.0/lib/cmake/flatbuffers/FlatcTargets.cmake
-- Installing: /nix/store/2zfi5j6wmfb6hbaqmmsbarbjz8r5f333-flatbuffers-1.8.0/lib/cmake/flatbuffers/FlatcTargets-release.cmake
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/2zfi5j6wmfb6hbaqmmsbarbjz8r5f333-flatbuffers-1.8.0
shrinking /nix/store/2zfi5j6wmfb6hbaqmmsbarbjz8r5f333-flatbuffers-1.8.0/bin/flatc
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/2zfi5j6wmfb6hbaqmmsbarbjz8r5f333-flatbuffers-1.8.0/lib  /nix/store/2zfi5j6wmfb6hbaqmmsbarbjz8r5f333-flatbuffers-1.8.0/bin
patching script interpreter paths in /nix/store/2zfi5j6wmfb6hbaqmmsbarbjz8r5f333-flatbuffers-1.8.0
checking for references to /tmp/nix-build-flatbuffers-1.8.0.drv-0 in /nix/store/2zfi5j6wmfb6hbaqmmsbarbjz8r5f333-flatbuffers-1.8.0...
/nix/store/2zfi5j6wmfb6hbaqmmsbarbjz8r5f333-flatbuffers-1.8.0


fix: new version

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign jstrachan
You can assign the PR to them by writing /assign @jstrachan in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

:star: PR built and available in a preview jstrachan-nodey510-pr-15 here

:star: PR built and available in a preview jstrachan-nodey510-pr-15 here


Show only errors and warnings

Can a configuration option (like "quiet") be added to only show errors and warnings in the standard maven output?
If such an option is made available, it would nice to have a single line summary to show that plugin ran (something like Audited dependencies: 14, Errors: 0, Warnings: 0, Ignored: 0, Time elapsed: 5.3 s).

I am not really sure what would qualify as a warning. I have written some code (not published to central yet -- not tested fully) which writes vulnerabilities to the log, and reports as follows:
[INFO] Audited dependencies: 59, Vulnerabilities: 0, Ignored: 0, Time elapsed: 1991 ms

See this commit
As mentioned, I still have testing a some other features to go in, but this should be published in reasonably short order.

Still needs testing and not published.

I can't think of any differences between "warning" and "ignore" at this time other than in a summary like this, a "warning" might be for any "we were supposed to check but didn't" situation, while "ignored" is you told us not to check.
You might also want to warn on ignored dependencies that are not actually dependencies (you instructed me to ignore foo:bar:3.0.0, but do not use it).

The -Daudit.quiet option will cause only the errors (and soon, warnings) to be logged to stdout, along with an [Info] summary line.
Printing warnings on ignored issues will be released shortly.
This is fixed in release 2.3.5 (published on maven central).


Add Helper Methods to System.ServieModel.Federation for creating different versions of WsFederation

We want two static helper methods
WsFederationBinding.CreateWs2007FederationBinding and CreateWsFederationBinding so that users will not need to set the version of WS protocols that are needed to talk to the RelyingParty.
The results should be the same as a new desktop WsFederationHttpBinding and Ws2007FederationHttpBinding

System.ServiceModel.Federation code has moved to the WCF team.


formatTime (and formatDateTime) return time in browser time zone, not Salesforce User time zone

Not sure if it's intended or not, but here's my scenario:

My user is in PST.
I'm located in the midwest, so my browser is in the CST timezone.

And with the following debug:
console.log(myDateTime);
console.log($A.get("$Locale.timezone"));
console.log($A.localizationService.formatTime(myDateTime));

I get the following output:
2017-09-26T20:30:00.000Z
America/Los_Angeles
3:30:00 PM
The issue is "3:30 PM" is the time in CST, not in PST. This presents difficulties for me since all other parts of the aura/lightning interface display the time in the proper PST, as 1:30 PM.

I'll file a bug. Agree, this is just wrong.

I know this was a while ago when I logged it, but was there any update or resolution to this issue?


Sparse fieldsets are not reflected in SELECT query

Hi. I'm considering using json:api in next API project, but I have serious performance concerns.
Let's say I want to get titles of articles in DB. Thanks for sparse fields response will be light, because it will not contain long article text and other not needed attributes.
http://localhost/api/v1/articles?fields[articles]=title
But in mysql log I can see:
Execute	select * from `articles`

Why?
It should be
Execute	select id, title from `articles`

Is this normal? This package does not prepare query with select's that are actually needed, instead just always fetching full rows?
I cannot find other issues about this or in docs. Can this be handled?
Currently it will affect server performance, because this query can take 10MB instead 10KB...
Regards :)

Hi! Yes, so this is very high-up on my to-do list. The reason I haven't implemented it yet is all the apps I use this package for can handle just doing SELECT * - i.e. it would be a performance improvement but the performance issue isn't huge on the apps I use this package for, so it hasn't been a high priority yet.
Saying that, your issue highlight that I should probably get this in sooner rather than later.
One thing worth pointing out is that this isn't as straightforward as your description makes it seem. It involves some analysis of the include paths to determine if there are any has-one relationships where the key is stored on the inverse model of the relationship.
I will also need to change all the eager loading to factor in any fields that have been specified by the client. And if that's a deep path, e.g. posts.comments.user then I need to change the eager loading at each path becasue different fields could have been specified for posts, comments and/or users.
So as you can hopefully see, none of this is straightforward and there's quite a bit to work through to get this working.
The other thing that needs to be decided is what to do if the client hasn't specified any fields for a specific resource type... should I just do a SELECT * or should I select all the columns that the resource has fields for?? Would be interested to hear your thoughts on that.

Sure relations are always tricky with manual SELECT, I understand that it's not one-line fix but more tricky one. Even lighthouse (graphql) did not figured this out if I remember correctly.
About priorities - I'm glad that you already considered this and it's high on TODO. But even that it's my issue, in my opinion much more important than this would be generating openapi spec #19 , because I saw that many people here tried and failed ;) We can buy better server to overcome SELECT * performance, but we cannot buy more time for ourselves for writing manually api docs, that for JSON:API are horrific complicated and long.
Anyway thank's for your work. It makes old good REST much more useable.

Any progress or updates on this feature?

Yeah this is towards the top of my list of priorities now. As in, the next major release of this package will have it as a feature.
I don't have any Open Source time at the moment - that's the limiting factor. I'm hoping to get some from May onwards.

Hi and thanks for keeping optimizing this amazing package!
For what it's worth, on the topic of what to do if no sparse fields are specified, it seems to me that taking the fields present in the resource should be the appropriate approach, as the client is only interested in the resource and there might be thinner and fatter resources over one and the same model which could be very big and its underlying table even bigger.
Sorry if I'm making an obvious point, but there is also something else I realised, which further complicates how sparse fieldsets would translate to the select statement - since the resource attribute names might not follow the name-mapping convention to corresponding column names and, what is more, they could be calculated in some custom way, e.g. combining first and last name from db in a single attribute 'name' in the resource, probably there should be some mechanism to register custom rules as to what column names to include in the sql statement in case a field has been requested (and it should allow for one-to-many mapping). With this figured out for the cases when sparse fieldsets are included in the request, I guess it should be straightforward, though, to only include what is needed for the fields in the resource rather than 'select *'.
I'd be happy to help if you think an outside person could work it out with some guiding points about what approach you have in mind.

Thanks for the offer of help. Yeah, I need to work through all these problems when I start looking at how to implement the feature. An added complication is I also need to specify all the columns when loading models via eager loading. So there's quite a few things to work out.