eager.function.defun and Autograph integration

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 16.04
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): nightly (1.13.0-dev20190118)
Python version: 3.5.2
CUDA/cuDNN version: 9.0
GPU model and memory: NVIDIA TITAN Xp (12196MB)

Describe the current behavior
From tensorflow 1.13, there is integration between autograph and tf.eager.function.defun (alias of tf.function in tf2.0 maybe?)
The logic flow is if programmer enables autograph option as True in defun decorator,
func_graph_from_py_func function in tf.python.framework.func_graph.py will be called with autograph=True.
Inside that function, it will call converted_call which is defined in autograph.impl.api.py and convert py_function to graph_funcion via autograph lib
However, inside converted_call, it should shows some log information about conversion in current version, but in my simplest example, it does not in actual execution.
Moreover, if I add some redundant print statement inside converted_call, it prints nothing.
I think rewrapping autograph wrapper in line 445-446 inside of tf.python.framework.func_graph.py does not wrap autograph's converted_call
Describe the expected behavior
The program should print some logging information in autograph conversion
e.g. autograph converted code information
Code to reproduce the issue
import tensorflow as tf

from tensorflow.python import autograph
from tensorflow.python.eager.function import defun

tf.enable_eager_execution()

@defun(autograph=True)
def add(x, y):
    return x + y

print(add(tf.constant(4), tf.constant(3))

Other info / logs
I think this issue occurs because
Inside unwrap function in tf.python.util.tf_decorator.py, it does nothing if innermost_decorator is None
Thus, if I change line 445-446 in tf.python.framework.func_graph.py as
converted_func = tf_decorator.make_decorator(original_func, wrapper)
if not hasattr(python_func, '_tf_decorator'):
    python_func = converted_func
else:
    tf_decorator.rewrap(python_func, original_func, converted_func)

it works.

Thank you for the detailed report and tracking down the fix! Sorry for the delay.
Your suspicion is right, defun is a precursor of function in 2.0. In integrates with a stable version of autograph, one which converts control flow only.
We recently changed the logging mechanism in Autograph to make it easier to control. It is also quite verbose now. You can now enable it either by calling tf.autograph.set_verbosity or by setting the AUTOGRAPH_VERBOSITY environment variable. Levels are 0-4, with 0 being no logging and 1 showing the generated code.
Unfortunately, logging doesn't seem to redirect to the cell output in Jupyter - that is a bug we're working to fix. But it should show up in the kernel logs.
I'm looking to replicate the bug, but it seems to be gone. Here are the commands I ran:
!pip install tf-nightly

import tensorflow as tf

print(tf.__version__)

1.13.0-dev20190207
from tensorflow.python import autograph
from tensorflow.python.eager.function import defun

tf.enable_eager_execution()

@defun(autograph=True)
def add(x, y):
    return x + y

print(add(tf.constant(4), tf.constant(3)))

tf.Tensor(7, shape=(), dtype=int32)
Please reopen the issue if it still occurs on your side of if you have further questions.

After a bit more digging into the logging, it seems that defun indeed does not call Autograph! I'll look into applying the fix you suggested.


Buttons for Window Commands Missing

I just upgraded Azure Data Studio to v1.41.2 on Pop Os.
In my settings.json I have the following entry: "window.titleBarStyle": "custom"
It worked with the previous version, and it works on VSCode v1.75.1
¯_(ツ)_/¯

Azure Data Studio version: azuredatastudio 1.41.2 (0f0960d0e774e1ce903b79378addff96117c27a6, 2023-02-08T20:08:18.398Z)
OS version: Linux x64 6.0.12-76060006-generic
Restricted Mode: No
Preview Features: Enabled

System Info

Item
Value

CPUs
AMD Ryzen 7 PRO 5850U with Radeon Graphics (16 x 1915)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: disabled_softwarevideo_encode: disabled_softwarevulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
0, 1, 1

Memory (System)
62.14GB (54.21GB free)

Process Argv
--unity-launch

Screen Reader
no

VM
0%

DESKTOP_SESSION
pop

XDG_CURRENT_DESKTOP
Unity

XDG_SESSION_DESKTOP
pop

XDG_SESSION_TYPE
x11

Extensions (2)

Extension
Author (truncated)
Version

vscode-markdownlint
Dav
0.49.0

material-icon-theme
PKi
4.23.1

(1 theme extensions excluded)

Closing as resolved.


structure format

Hello,
I am running fastStructure on Ubuntu 18. The test data provided works in my environment (bed files)
I have a large SNP dataset from a complete chromosome. I converted the vcf to a Structure format using PDGSpider and the file works in Structure, but I cannot get it to work in fastStructure.
I use the following command:
python structure.py -K 3 --format=str --input=Tse_43samples_scaff_22_SNP-INDEL_variants_filt_rnd2_TRUNC2 --output=Tse43_Chr24 --full --seed=100 --prior=logistic
and get the error:
Traceback (most recent call last):
  File "structure.py", line 172, in <module>
    G = parse_str.load(params['inputfile'])
  File "parse_str.pyx", line 10, in parse_str.load
    L = loci.shape[1]
IndexError: tuple index out of range

The file looks like the following for 43 taxa, so 86 rows + Header:
SNP_1 SNP_2 SNP_3 SNP_4 SNP_5 SNP_6 SNP_7 SNP_8 SNP_9 SNP_10
AHP1168		2 1 3 3 4 2 2 1 2 2
AHP1168		2 1 3 3 4 2 2 1 2 2
AHP2709		-9 1 3 3 -9 -9 2 3 2
AHP2709		-9 1 3 3 -9 -9 2 3 2
NOTE: My structure input file has the .str extension, but fastStructure appends it with another .str and then says it cannot find file, So in the command line I omit the .str extension and is gets past file loading.
thanks in advance.

SOLUTION: I was able to convert the GATK4 generated vcf file into a bed file plus the .fam and .bim files required by fastSTRUCTURE using plink2.
plink2 --vcf 41samples_scaff_22.vcf --allow-extra-chr --out 41samples_scaff_22

I had the same issue while using stacks' populations module. I used it to convert VCF to STRUCTURE format, but I had to fix the file a little bit afterwards, to make it acceptable by faststructure. I used stacks 2.1 as later versions (2.3 & 2.4 in particular) gave me some errors while converting files. You can install both stacks and faststructure using conda manager and Bioconda channel.
populations -V filtered.vcf --structure

mv filtered.p.structure filtered.p.str # fix file extension

The file had incorrect header, with comment on line 1 and missing column names for first two columns at line 2:
$ awk '{print NF}' filtered.p.str | head -3
8
217474
217476

$ head -2 filtered.p.str | cut -f 1-8
# Stacks v2.1;  Structure v2.3; December 04, 2020
		1_0	2_0	4_0	5_0	7_0	9_0

Note the two leading tabulators at the beginning of line 2!
So I had to remove the comment and add the two missing column names at the beginning of the header line:
awk 'NR>1' filtered.p.str | sed 's/\t\t1_0/id\tpop\t1_0/' > filtered.p.fixed.str

After this fix, the file had correct format and faststructure no longer showed the error.
$ awk '{print NF}' filtered.p.fixed.str | head -3
217476
217476
217476

$ head -1 filtered.p.fixed.str | cut -f 1-8
id	pop	1_0	2_0	4_0	5_0	7_0	9_0

However the format is still wrong, as stacks currently doesn't assign -9 as missing values. I reported the issue to stacks developers.

Hej,
regarding parsing the output of stacks2 populations:
I pull apart the vcf file, mask the loci/chromosome names with an 'X', and recombine the vcf file. Then, I created the bed files (*.bed, *.bim, *.fam) with plink.
This is not a pretty solution but it worked for me.
$ grep -v "#" populations.snps.vcf | sed -E 's/^/X_/g' > body.snps.vcf
$ grep "#"  populations.snps.vcf > header
$ cat header body.snps.vcf >> recombined.snps.vcf
$ plink --vcf recombined.snps.vcf --double-id -aec --make-bed
plink produces plink.bed, plink.bim, plink.fam (and two more), and you could then run faststructure like so
$ structure.py -K 9 --input=plink --output=populations_k9 --seed=2021 --full --format=bed


Plugin stopped sending location

Describe the bug
The plugin was working fine for me.but now a days it only sent at the initial time after it doesn't give any location
To Reproduce
Steps to reproduce the behavior:
Install the plugin with latest capacitor and run the project
Expected behavior
Need to work continuously.
Is it due to the latest capacitor version?

Are you experiencing this problem when the app is in the foreground, background or both? What device and operating system are you using? What version of the plugin & Capacitor are you using?

In both. I tested in a nee project as well but not working. Anybody having the issue?? It sent location at first time🥺

Please try running the app in the example/ directory and let me know what happens.

sure i will check and let you know

same here. the fist time it gives the location after there is no updates. and there is no error too

2023-02-01 11:54:28.512101+0530 App[8459:2405287] [SceneConfiguration] Info.plist contained no UIScene configuration dictionary (looking for configuration named "(no name)")
2023-02-01 11:54:28.512182+0530 App[8459:2405287] [SceneConfiguration] Info.plist contained no UIScene configuration dictionary (looking for configuration named "(no name)")
2023-02-01 11:54:28.733926+0530 App[8459:2405287] KeyboardPlugin: resize mode - native
⚡  Loading app at capacitor://localhost...
2023-02-01 11:54:28.898795+0530 App[8459:2405287] [Sandbox] Could not enable Mach bootstrap, errno = 1.
2023-02-01 11:54:28.898868+0530 App[8459:2405287] [Sandbox] Could not enable Mach bootstrap, errno = 1.
⚡  WebView loaded
⚡  To Native ->  App addListener 23724426
⚡  To Native ->  BackgroundGeolocation addWatcher 23724427
2023-02-01 11:54:39.429175+0530 App[8459:2405287] [Accessibility] WKContentView[@] set up: @ pid: @ MACH_PORT 25412608
⚡  TO JS {"longitude":75.542713801786633,"simulated":false,"altitudeAccuracy":25.629905700683594,"speed":null,"accuracy":8.6939967608949278,"altitude":198.73445129394531,"time":1675232679442,"latitude":12.125589638800754,"bearing":null}
⚡  [log] - loaction {"longitude":75.54271380178663,"simulated":false,"altitudeAccuracy":25.629905700683594,"speed":null,"accuracy":8.693996760894928,"altitude":198.7344512939453,"time":1675232679442,"latitude":12.125589638800754,"bearing":null}
⚡  [log] - {"longitude":75.54271380178663,"simulated":false,"altitudeAccuracy":25.629905700683594,"speed":null,"accuracy":8.693996760894928,"altitude":198.7344512939453,"time":1675232679442,"latitude":12.125589638800754,"bearing":null}

i found the issue. when i use distanceFilter:0 it was not getting the data. when i removed it.its working fine.

The README states that distanceFilter:0 means no filter. This should be fixed in v.1.2.8.


Context Cancel Artifacts

2018-10-12T17:11:04.930 [  logger] INFO    {2006-01-02T15:04:05.000 8 0}Finalizing logger, due to termination pending request

What are the options there for?  Why is the date in 2006?
https://github.com/d2r2/go-logger/blob/49d264032dafcd45eee4c04ec41e25de6ea66a12/logger.go#L319

Hi @jnovack! Thank you, for pointing to this - this is a bug. This will be fixed in nearest update.


Spotify connect stopped working? (Disregard)

I've been using Balena sound for more than year now, and I'm running version 3.8.4 ( Balena OS [balenaOS 2.83.21+rev1 ) on a raspberry pi 3 b+, everything was working fine till this am. Now no matter what I do I cannot get music to play with Spotify connect. Connecting with Airplay works correctly. Also bluetooth doesn't seem to connect either, although I don't use that much anyway.
I can click on the speaker icon, and connect to my balena sound device, and spotify shows as playing, but no sound comes out.
Not sure if this is a bug with spotify or what's going on. I can connect to other devices on my network using spotify connect, just not balena sound.

For some reason it started working again... took a couple of hours.. weird.


Cognitiveservices template fails on property qnaAzureSearchEndpointKey

Describe the bug
When exporting the CognitiveServices/accounts resource in Azure, the validate runner fails because the value of the property qnaAzureSearchEndpointKey is null. The Whatif deployment does not allow this to be null and fails.
This issue happens to the resource type:
"Microsoft.CognitiveServices/accounts",
Steps to reproduce

Pull the resources from Azure
Validate the resources by using a Whatif deployment

Screenshots

Thank you for reporting this!
We are striving to support all resource providers in pull, but also rely on that the RPs return all the correct schema.
We are currently working on improving this to enable higher quality, but for now, it is best effort.
Out of curiosity, in this particular case, do you always run a validate after pull, or is this after changing the resource through a PR?


Make endpoint type configurable in openstack service discovery

@d-kuhn you've got conflicts.

Obsolete because of https://github.com/prometheus/prometheus/pull/7494


luarocks does not work on windows when trying to install luacurl

C:\Windows\System32>luarocks install Lua-cURL --server=https://luarocks.org/dev
C:\Program Files (x86)\Lua\5.1\lua: C:\Program Files (x86)\Lua\5.1\lua/luarocks\fs.lua:37: attempt to concatenate local
'loaded_platform' (a nil value)
stack traceback:
C:\Program Files (x86)\Lua\5.1\lua/luarocks\fs.lua:37: in main chunk
[C]: in function 'require'
...rogram Files (x86)\Lua\5.1\lua\luarocks\command_line.lua:7: in main chunk
[C]: in function 'require'
C:\Program Files (x86)\Lua\5.1\luarocks.lua:3: in main chunk
[C]: at 0x004020f0
What do you think the problem might be?

Fixed it by changing the command to: luarocks install lua-curl --server=https://luarocks.org/dev
the upper case Lua-cURL was causing the error

This is known feature of LuaRocks. You have to use lower case in command. Even if module has upper case in its name. Not sure is it documented thoug.
Just curious. Did your LuaRocks uses wget to get archive or you install LuaSec.
When I try install I fail because of wget can not download archive.
Also why you need dev version. In fact in dev I have only one bug fix reletad with HTTP2

Luarocks didnt use wget i was able to get luasec to work. It worked after i made it lowercase and i updated to the latest version of luarocks.
I like using the latest even if it ts dev stuff


Update to Roslyn 2.0.0-beta3

Note: I removed the references to Roslyn from src/OmniSharp.Plugins/project.json. I'm not sure why those were there.

Wonder if I should turn off LGTM now that github has native approvals... probably should, lol.

yup :smile:

Turned on approvals required, turned off the lgtm webhook.

LGTM CURSES!


Minor documentation questions

This is part of JOSS review.
[pu,pf] = tmd_nodal(constituents,p,N): what are pu, pf?
tmd_ll2ps(lat,lon,SLAT,SLON,HEMI): allowed inputs (vector, array, etc.)?
tmd_harp(t,hc,constituents,p,N,ph,omega): physical units of input/outputs?
dh = tmd_InferMinor(hc,constituents,t,s,h,p,N): what is a "correction"?
tmd_astrol.m: why are there question marks on line 51?  Given there are several time formats within TMD stack code: days since Jan 1, 1992; days since Nov 17, 1858, and MATLAB datenum (days since 00-Jan-0000'); the "???" does not inspire user confidence.

We've made changes to the function headers to clarify some of the points above, but we should note: These functions are not user-facing, and should not be interacted with directly. Accordingly, the bar for documentation needs only to meet that of stream3c or any of the other hundreds of official MATLAB functions you'll find under the hood.
And we agree, the mish-mash of time formats in some of the underlying functions is lousy coding practice and it's just begging to introduce errors (or at least erode confidence in the code, as you point out). However, these are the exact equations that have been employed in all previous versions of TMD and we felt it was best not to mess with them.

These functions do not meet the bar for stream3, and the expectation for documentation of open-source software (including under-the-hood functions) is that which allows a future user to modify or contribute to software. This revision of TMD was presented as addressing prior clarity issues, one such being undocumented magic numbers  and lack of documentation in under-the-hood functions.

For example, the outputs of tmd_harp says:
% Outpus:
%    hhat: reconstructed tide (size Tx1).

The function body of tmd_astrol includes:
t_mjd = t - datenum(1992,1,1) + 48622;

% Convert time from UTC in decimal MJD to ???
T = t_mjd - 51544.4993;

% Mean longitude of moon:
s = 218.3164 + 13.17639648 * T;

Note, I was referencing stream3c, not stream3.
These time conversions, including the corresponding comments, are the exact code that has been part of TMD for decades, and the conversions occur inside a function that users should never need to directly interact with. Our approach in this update to TMD has been to keep the exact calculations that have stood the test of time, but write the user-facing functions in such a way that users never have to think about the conversions.

I understand @chadagreene's reasoning for not changing the code since part of the goal here is apparently to keep that the same over time. I don't see why you shouldn't add more documentation to make things clearer, especially when specifically requested. @lnferris's reasoning is good that that is part of the point of having open source code and there is an extra level of expectation when publishing open source code. The answers to the questions above could be notes in the function(s).

[pu,pf] = tmd_nodal(constituents,p,N): what are pu, pf?

We have clarified "Nodal correction outputs pu,pf have units of radians and are are MxN dimensions, corresponding to M timesteps and N constituents."

tmd_ll2ps(lat,lon,SLAT,SLON,HEMI): allowed inputs (vector, array, etc.)?

Any input dimensions are allowed. By convention, we only specify dimension limitations when they are in fact limited, or when some meaningful insight can be gained through describing the dimensions. Neither is the case here, so we keep it unchanged.

tmd_harp(t,hc,constituents,p,N,ph,omega): physical units of input/outputs?

Output hhat is the reconstructed tide, as described in the function header, and has the same units accordingly. Input t is described in the function header as having datum units, hc contains the complex harmonic constants and will of course have whatever units the complex harmonic constants have, p is the lunar perigee, N is the lunar node, and phase is in radians as is consistent throughout the TMD3.0 package, and the units of omega are specified as s^-1 in the function header.

dh = tmd_InferMinor(hc,constituents,t,s,h,p,N): what is a "correction"?

This is a question about tide theory, and if the concept is not understood, then this does not feel like the appropriate place to provide such a lesson. The tmd_InterMinor function is not user-facing, and no one should ever need to open it or even call it directly. The only time anyone should ever need to open this function is if they wish to adapt it into something else, and we assume that anyone who is ever tasked with altering code for minor constituent corrections will understand what minor constituent corrections are. We have described what the function does in the header, we point users to Richard Ray's perth2 function that it is based on, and we described all of the changes we made to the code in this update. No further changes are warranted here.

tmd_astrol.m: why are there question marks on line 51? Given there are several time formats within TMD stack code: days since Jan 1, 1992; days since Nov 17, 1858, and MATLAB datenum (days since 00-Jan-0000'); the "???" does not inspire user confidence.

The question marks are preserved intact from the legacy code that we have adapted, and we haven't touched the code or time formats, so it doesn't seem appropriate to erase the comments from previous coders.

We have clarified "Nodal correction outputs pu,pf have units of radians and are are MxN dimensions, corresponding to M timesteps and N constituents."

You have a typo in this section.

Any input dimensions are allowed. By convention, we only specify dimension limitations when they are in fact limited, or when some meaningful insight can be gained through describing the dimensions. Neither is the case here, so we keep it unchanged.

Explicit is better than implicit and this has the potential to create confusion. Please update.

Output hhat is the reconstructed tide, as described in the function header, and has the same units accordingly. Input t is described in the function header as having datum units, hc contains the complex harmonic constants and will of course have whatever units the complex harmonic constants have, p is the lunar perigee, N is the lunar node, and phase is in radians as is consistent throughout the TMD3.0 package, and the units of omega are specified as s^-1 in the function header.

Explicit is better than implicit. If you can write it out here to improve clarity, you can add it to the docs to improve clarity.

This is a question about tide theory, and if the concept is not understood, then this does not feel like the appropriate place to provide such a lesson. The tmd_InterMinor function is not user-facing, and no one should ever need to open it or even call it directly. The only time anyone should ever need to open this function is if they wish to adapt it into something else, and we assume that anyone who is ever tasked with altering code for minor constituent corrections will understand what minor constituent corrections are. We have described what the function does in the header, we point users to Richard Ray's perth2 function that it is based on, and we described all of the changes we made to the code in this update. No further changes are warranted here.

You can still say something useful. For example: you can add to the docs that the function is not user facing but also be aware that users look at the code and add more detail to improve your codebase. Perhaps you can briefly summarize the correction or you can link to something that provides a longer explanation.

The question marks are preserved intact from the legacy code that we have adapted, and we haven't touched the code or time formats, so it doesn't seem appropriate to erase the comments from previous coders.

This is your chance to improve the comments in the code. If you can figure out what the "???" should be, you should fix the comment.

You have a typo in this section.

Fixed.

Explicit is better than implicit and this has the potential to create confusion. Please update.

Done.

Explicit is better than implicit. If you can write it out here to improve clarity, you can add it to the docs to improve clarity.

Done.

You can still say something useful. For example: you can add to the docs that the function is not user facing but also be aware that users look at the code and add more detail to improve your codebase. Perhaps you can briefly summarize the correction or you can link to something that provides a longer explanation.

Perhaps it's best to let the original author of the code describe it in his own words. In the function header I've added the note that "tmd_InferMinor returns correction for 16 minor tidal constituents... This is based on Richard Ray's code perth2. For further description, see Ray, Richard D. "Global ocean tide models on the eve of TOPEX/POSEIDON." IEEE transactions on Geoscience and Remote Sensing 31.2 (1993): 355-364."

This is your chance to improve the comments in the code. If you can figure out what the "???" should be, you should fix the comment.

I've removed the question marks.


feat: branch refresh

Based on the changes here

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
- Added 8

Complexity increasing per file
==============================
- frappe/app.py  2
- frappe/integrations/doctype/webhook/webhook.py  1
- frappe/public/js/frappe/form/toolbar.js  1

Complexity decreasing per file
==============================
+ frappe/public/js/frappe/web_form/webform_script.js  -1

See the complete overview on Codacy

Pull Request Test Coverage Report for Build 956

42 of 162 (25.93%)  changed or added relevant lines in 15 files are covered.
1419 unchanged lines in 86 files lost coverage.
Overall coverage decreased (-2.6%) to 48.165%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

frappe/desk/doctype/tag/tag.py
1
2
50.0%

frappe/desk/form/utils.py
0
1
0.0%

frappe/test_runner.py
3
4
75.0%

frappe/handler.py
0
2
0.0%

frappe/app.py
0
3
0.0%

frappe/exceptions.py
0
3
0.0%

frappe/integrations/doctype/webhook/webhook.py
5
8
62.5%

frappe/website/doctype/web_form/web_form.py
11
30
36.67%

frappe/desk/form/linked_with.py
13
49
26.53%

frappe/api.py
0
51
0.0%

Files with Coverage Reduction
New Missed Lines
%

frappe/api.py
1
0%

frappe/core/doctype/activity_log/feed.py
1
66.67%

frappe/core/doctype/server_script/server_script.py
1
64.71%

frappe/core/doctype/version/version.py
1
94.23%

frappe/custom/doctype/custom_field/custom_field.py
1
59.78%

frappe/data_migration/doctype/data_migration_connector/connectors/base.py
1
68.75%

frappe/desk/doctype/notification_log/notification_log.py
1
48.57%

frappe/model/base_document.py
1
68.51%

frappe/model/create_new.py
1
81.61%

frappe/recorder.py
1
97.22%

Totals

Change from base Build 955:
-2.6%

Covered Lines:
20530

Relevant Lines:
42624

💛  - Coveralls

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
- Added 8

Complexity increasing per file
==============================
- frappe/app.py  2
- frappe/public/js/frappe/form/toolbar.js  1
- frappe/integrations/doctype/webhook/webhook.py  1

Complexity decreasing per file
==============================
+ frappe/public/js/frappe/web_form/webform_script.js  -1

See the complete overview on Codacy


Voice calls on iOS are too low

When you open a voice call on iOS, the sound is almost inaudible, butit is fine on Android phones

When you open a voice call on iOS, the sound is almost inaudible, butit is fine on Android phones

+1

When you open a voice call on iOS, the sound is almost inaudible, butit is fine on Android phones

+1

0.8.5 solves this problem, you can also turn on the iPhone microphone to turn on the speaker mode yourself


Name tags present in creative inventory

Name tags need more work to be enabled. Leaving them in the creative inventory was not intentional.
Also needs a fix for the unlocalized name being wrong.

Fixed for 1.1.5


DORA with releases and bugs

Description
DORA metrics but instead of using cicd_Deployment and ims_Incident, we use cicd_Release and tms_Task (with the bug label). It is located in the DORA - Releases and Bugs collection.

This change also renames the old collection and dashboard to DORA - Deployments and Incidents for consistency. Current users will essentially have the old DORA collection being a dup of that renamed collection, but this is a good tradeoff for future consistency.
Type of change

New feature (non-breaking change which adds functionality)

Checklist

[x] Have you checked to there aren't other open Pull Requests for the same update/change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you successfully run tests with your changes locally?

is anything has to be updated in the docs?

no; links have been updated on the welcome dashboard.


feat: add support for transfer entire balance for vesting accounts

Description
This allows for the "transfer entire balance" feature to work for vesting accounts.
closes: #7658

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against the correct branch (see CONTRIBUTING.md).
[ ] Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
[ ] Code follows the module structure standards and Go style guide.
[ ] Wrote unit and integration tests.
[ ] Updated relevant documentation (docs/).
[ ] Added relevant godoc comments.
[ ] Provide a conventional commit message to follow the repository standards.
[ ] Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
[ ] Re-reviewed Files changed in the GitHub PR explorer.
[ ] Review SonarCloud Report in the comment section below once CI passes.

Looks good to me. Would be nice to have a corresponding issue for bug, though.

Added!

GetBalance shouldn't be used elsewhere atm right? Can be removed from expected keeper interface. (Though it is used in the impl of OnSendPacket for transfer v2 on feat/ibc-eureka where it should also be tweaked)

Right! Removed it, and will merge this into feat/ibc-eureka and deal with that after this is merged.

I'd slam this in if you feel confidently about it tbh

I would if I had access to do so :D

Oh wait, I did. Nevermind.


[BUG]:

What version of drizzle-orm are you using?
0.29.4
What version of drizzle-kit are you using?
n/a
Describe the Bug
I have the following query
const subjectsQuery = (value: "MAX" | "MIN") => {
  return db
    .select({ label: sql.raw(`'${value} Subjects'`) as SQL<string>, count: sql<number>`count`, id: sql<number>`subject` })
    .from(
      db
        .select({
          subject: booksSubjects.subject,
          count: sql<number>`COUNT(*)`.as("count"),
          rank_val: sql<number>`RANK() OVER (ORDER BY COUNT(*) ASC)`.as("rank_val")
        })
        .from(books)
        .innerJoin(booksSubjects, and(eq(books.id, booksSubjects.book), eq(books.userId, userId)))
        .groupBy(booksSubjects.subject)
        .as("t")
    )
    .where(eq(sql.raw("rank_val"), 1));
};

this fails with the error below. Running toSQL on the query, the SQL that's generated looks like this (with arguments pasted in) - which runs and executes just fine in PlanetScale
select 'MIN Subjects', count, subject
from (
    select `books_subjects`.`subject`, COUNT(*) as `count`, RANK() OVER (ORDER BY COUNT(*) ASC) as `rank_val`
    from `books` inner join `books_subjects` on (`books`.`id` = `books_subjects`.`book` and `books`.`userId` = '60a93babcc3928454b5d1cc6')
    group by `books_subjects`.`subject`
) `t`
where rank_val = 1

Error generated:
Error reading user summary DatabaseError: target: my-library.-.primary: vttablet: rpc error: code = Unknown desc = Window name 'subject' is not defined. (errno 3579) (sqlstate HY000) (CallerID: ui6anhj711qnlwez28fw): Sql: "select :vtg1 /* VARCHAR */, count(*), :vtg2 /* INT64 */ from books where books.userId = :books_userId /* VARCHAR */ union select :vtg3 /* VARCHAR */, `count`, subject from (select books_subjects.subject, count(*) as `count`, rank() over ( order by count(*) asc) as rank_val from books join books_subjects on books.id = books_subjects.book and books.userId = :books_userId /* VARCHAR */ group by books_subjects.subject) as t where rank_val = :rank_val /* INT64 */ union select :vtg4 /* VARCHAR */, `count`, subject from (select books_subjects.subject, count(*) as `count`, rank() over ( order by count(*) asc) as rank_val from books join books_subjects on books.id = books_subjects.book and books.userId = :books_userId /* VARCHAR */ group by books_subjects.subject) as t where rank_val = :rank_val /* INT64 */ union select :vtg5 /* VARCHAR */, :vtg2 /* INT64 */, id from subjects where subjects.userId = :books_userId /* VARCHAR */ and not exists (select 1 from books_subjects where books_subjects.subject = subjects.id and subjects.userId = :books_userId /* VARCHAR */) union select :vtg6 /* VARCHAR */, count(*), books_tags.tag from books join books_tags on books.id = books_tags.book and books.userId = :books_userId /* VARCHAR */ group by books_tags.tag having count(*) = (select count(*) from books join books_tags on books.id = books_tags.book where books.userId = :books_userId /* VARCHAR */ group by books_tags.tag order by count(*) asc limit :vtg7 /* INT64 */) union select :vtg8 /* VARCHAR */, count(*), books_tags.tag from books join books_tags on books.id = books_tags.book and books.userId = :books_userId /* VARCHAR */ group by books_tags.tag having count(*) = (select count(*) from books join books_tags on books.id = books_tags.book where books.userId = :books_userId /* VARCHAR */ group by books_tags.tag order by count(*) desc limit :vtg9 /* INT64 */) union select :vtg10 /* VARCHAR */, :vtg2 /* INT64 */, id from tags where tags.userId = :books_userId /* VARCHAR */ and not exists (select 1 from books_tags where books_tags.tag = tags.id)", BindVars: {REDACTED}
    at Connection.execute (file:///Users/arackis/Documents/git/booklist/svelte-kit/node_modules/@planetscale/database/dist/index.js:78:19)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async PlanetScalePreparedQuery.execute (file:///Users/arackis/Documents/git/booklist/svelte-kit/node_modules/drizzle-orm/planetscale-serverless/session.js:30:22)
    at async Module.userSummary (/Users/arackis/Documents/git/booklist/svelte-kit/src/data/user-summary.ts:61:18)
    at async GET (/Users/arackis/Documents/git/booklist/svelte-kit/src/routes/api/user-summary/+server.ts:13:29)
    at async Module.render_endpoint (/Users/arackis/Documents/git/booklist/svelte-kit/node_modules/@sveltejs/kit/src/runtime/server/endpoint.js:49:18)
    at async resolve (/Users/arackis/Documents/git/booklist/svelte-kit/node_modules/@sveltejs/kit/src/runtime/server/respond.js:448:17)
    at async handleFn (/Users/arackis/Documents/git/booklist/svelte-kit/src/hooks.server.ts:88:20)
    at async Module.respond (/Users/arackis/Documents/git/booklist/svelte-kit/node_modules/@sveltejs/kit/src/runtime/server/respond.js:324:20)
    at async file:///Users/arackis/Documents/git/booklist/svelte-kit/node_modules/@sveltejs/kit/src/exports/vite/dev/index.js:523:22

Expected behavior
Query should work
Environment & setup
Node

Pass logger: true to drizzle when instantiating just to make sure that's the actual query that's being sent to planetscale.  This query is part of (inserted into) a larger union, which somehow I’m only now realizing.


[platform] NXP platform toolchain cmake file update

Add link target finding folder and correct readline target variable.
Added the arm toolchain file. This enabled the cross compile based on NXP
i.MX6ULL Linux SDK.
TEST:  source ${PATH_TO_NXP_LINUX_SDK}/environment-setup-cortexa53-crypto-poky-linux
./script/cmake-build -DOTBR_BORDER_ROUTING=ON -DOTBR_REST=ON
-DOTBR_WEB=ON -DOTBR_BACKBONE_ROUTER=ON
-DOT_BACKBONE_ROUTER_MULTICAST_ROUTING=ON -DBUILD_TESTING=OFF
-DOTBR_DBUS=ON -DOTBR_DNSSD_DISCOVERY_PROXY=ON
-DOTBR_SRP_ADVERTISING_PROXY=ON -DOT_THREAD_VERSION=1.2
-DOTBR_INFRA_IF_NAME=mlan0
-DCMAKE_TOOLCHAIN_FILE=./examples/platforms/nxp/linux-imx/arm.cmake

@jwhui could you please help to review this change?
Thanks!

Hi @jwhui  and @bukepo , could you please help to merge this? Since we encourage customer to build otbr for i.MX8 and i.MX6 directly based on community codes. This patch fixed the arm64 new SDK toolchain configuration bugs and add arm32 SDK toolchain configuration to support imx6 series SoC.
Thanks.


Changue status option wrong text

In GitLab by @cguzman95 on Oct 13, 2022, 11:53
Hello,
I tried the "changue status" option to my job "a582". For the job selected it gives me "a582_20160720_000_2_HERMESv3_GR WAITING".
As far as I understand, to changue the status in Autosubmit I have to use this command: "autosubmit setstatus -s -t WAITING -ft HERMESv3_GR a582"
As you see, the command is pretty different from the text copied. Can we update the text that gives the GUI to the command to paste?
Thanks,
Christian

In GitLab by @ggcr on Oct 13, 2022, 12:42
Hi @cguzman95
I think you are clicking in the below feature instead on the "set status to"

Can you confirm me that the command that you want is the one of the image at the top?

In GitLab by @ggcr on Oct 13, 2022, 13:09
To change the status of a job, Autosubmit uses a temporary file called "update_list_cxxx.txt" which is located in the directory of the experiment itself. In your case, since you want to change it to waiting it would have the following format:
/esarchive/autosubmit/a591/update_list_a591.txt

a591_20160720_000_2_HERMESv3_GR WAITING
You can put as many (jobs + new status) as you want here...
...

We have a worker that is in charge of reading all the update_list files and updating the jobs of each experiment.
The setstatus command does this in an automated way.

In GitLab by @cguzman95 on Oct 13, 2022, 12:58
True. And for what it is used the file text?


Practice Issue

this is my first trial issue
can use at sign to mention a person and they will get a notification

Issue corrected!


Unable to start TmStorage_source

I am able to execute SimpleImageStorage but while starting the TmStorage_source there is an error that is attached below. How should I execute this without the following error?

Hi Sowmya,
you cannot start it because it's a class library. What are you trying to
accomplish actually?
Regards
Tomaz
On Wed, Feb 19, 2020 at 9:17 AM SowmyaPolumahanti<EMAIL_ADDRESS>wrote:

I am able to execute SimpleImageStorage but while starting the
TmStorage_source there is an error that is attached below. How should I
execute this without the following error?
[image: Error]
https://user-images.githubusercontent.com/58174293/74814863-2ef2a680-531e-11ea-9e29-315f84ad006d.jpg
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/tomazk8/TmStorage/issues/1?email_source=notifications&email_token=ACKR3ZK2BLPYRGOCRYBZL4TRDTTJ3A5CNFSM4KXUFDY2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IORXDCQ,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACKR3ZJUFDMZNA6AAYUJLJ3RDTTJ3ANCNFSM4KXUFDYQ
.

Hello Tomaz ,
I am still a beginner. I am working on storage management systems.So, in that process i got to see  this TmStorage. I wanted to know more about this project like how to execute it and what will be the output of the project so that i can implement and make changes for other file systems.
Regards
Sowmya
<EMAIL_ADDRESS>

Hi Sowmya,
ok, no problem. Simply check the code in SimpleImageStorage and you'll see
how it uses the TmStorage library.
Regards
Tomaz
On Thu, Feb 20, 2020 at 5:26 AM SowmyaPolumahanti<EMAIL_ADDRESS>wrote:

Hello Tomaz ,
I am still a beginner. I am working on storage management systems.So, in
that process i got to see this TmStorage. I wanted to know more about this
project like how to execute it and what will be the output of the project
so that i can implement and make changes for other file systems.
Regards
Sowmya
<EMAIL_ADDRESS>—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/tomazk8/TmStorage/issues/1?email_source=notifications&email_token=ACKR3ZNLL6GPWXSTNZHRROTRDYBBFA5CNFSM4KXUFDY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMKV45A#issuecomment-588602996,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACKR3ZNBUIY4OSOHI23HDODRDYBBFANCNFSM4KXUFDYQ
.

Hello Tomaz,
Thanks a lot for the reply. I executed the SimpleImageStorage and got the output as follows.Can you please explain how these tools work and how the storage is created?

Regards
Sowmya

Hi Sowmya,
Here is the CodeProject article I wrote for my library some years ago. You
can find all the information there:
https://www.codeproject.com/Articles/843465/TmStorage-open-source-storage-engine-for-NET
Regards
Tomaz
On Thu, Feb 20, 2020 at 10:14 AM SowmyaPolumahanti<EMAIL_ADDRESS>wrote:

Hello Tomaz,
Thanks a lot for the reply. I executed the SimpleImageStorage and got the
output as follows.Can you please explain how these tools work and how the
storage is created?
[image: output]
https://user-images.githubusercontent.com/58174293/74917907-4bf6aa80-53ee-11ea-9314-5a93586de856.jpg
Regards
Sowmya
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/tomazk8/TmStorage/issues/1?email_source=notifications&email_token=ACKR3ZNOUYSS762HJBMH3TDRDZCW5A5CNFSM4KXUFDY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMMK7GY#issuecomment-588820379,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACKR3ZNXBK6KBCKECPW7B5DRDZCW5ANCNFSM4KXUFDYQ
.


proto: avoid pointer arithmetic with invalidField

In the case of a tag of zero, we perform some pointer arithmetic
where we add -1 to the pointer. Even though we do not end up dereferencing
the pointer, this still causes issues with the Go GC, which expects that
every Go pointer is a valid pointer.
This causes crashes on Go1.7 and below because the function arguments
are considered live throughout the entire function causing the GC to
scan this invalid pointer. On Go1.8 and above, this is not an issue
since the argument is not considered live and is not scanned.
To be on the safer side, perform pointer arithmetic that is effectively
a noop, so that we don't cause a valid pointer to become invalid.

@cherrymui, can you review this?

Did I do it right? I have never done review on GitHub. Let me know if there is anything needed.


[binance.js] Error -1100: Illegal characters found in parameter 'price'

I'm submitting a ...
[x] bug report
Action taken (what you did)
Start a new gekko, settings: binance, BTC-BCN, live tradebot
Expected result (what you hoped would happen)
Bot starts trading
Actual result (unexpected outcome)
After warmup period gekko gives an error:
"Gekko encountered an error and can't continue"
In console error message:
RECEIVED ERROR IN GEKKO<PHONE_NUMBER>45839
Gekko encountered an error and can't continue
Gekko encountered an error and can't continue
Error:
[binance.js] Error -1100: Illegal characters found in parameter 'price'; legal range is '^([0-9]{1,20})(.[0-9]{1,20})?$'.
Meta debug info:
Gekko version: v0.5.14
Nodejs version: v8.11.2
Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, etc)
I'm new to trading bots. I have no idea if I made a mistake or if I misinterpreted the error message. These settings run cleanly during backtesting but not in live mode.
I run the bot in windows 10 bash with ubuntu.
last lines of the tradebot.log:
2018-06-01 12:58:03 (DEBUG):	[binance.js] (addOrder) BUY 3449 BCN @9.2e-7 BTC
2018-06-01 12:58:04 (ERROR):	[binance.js] (addOrder) returned an irrecoverable error: Error: Error -1100: Illegal characters found in parameter 'price'; legal range is '^([0-9]{1,20})(.[0-9]{1,20})?$'.
2018-06-01 12:58:04 (DEBUG):	[binance.js] entering "setOrder" callback after api call, err: [binance.js] Error -1100: Illegal characters found in parameter 'price'; legal range is '^([0-9]{1,20})(.[0-9]{1,20})?$'. data: {"code":-1100,"msg":"Illegal characters found in parameter 'price'; legal range is '^([0-9]{1,20})(\.[0-9]{1,20})?$'."}
Is it possible that the scientific notation of the price is causing this problem?

Apologies for the delayed response, I am confident this bug has been fixed in the new Gekko release 0.6. Please update and try again, if the problem persists please comment here.

Thanks for the answer. I did a fresh installation of gekko 0.6. Same settings as above. Unfortunately, the error still exists. Am I perhaps doing something wrong since no one else seems to have this error? I have absolutely no idea what I could do wrong as all settings are self-explanatory and very simple.
handleCreate [binance.js] Error -1100: Illegal characters found in parameter 'price'; legal range is '^([0-9]{1,20})(.[0-9]{1,20})?$'.
RECEIVED ERROR IN GEKKO INSTANCE 2018-07-04-21-48-tradebot-780583332161955
{ name: 'AbortError',
message: '[binance.js] Error -1100: Illegal characters found in parameter 'price'; legal range is '^([0-9]{1,20})(\.[0-9]{1,20})?$'.' }


WIP: Standardize how types are printed

Part of the eth2 interop cleanup.
What was wrong?
This PR attempts to standardize how types are printed.
I'd prefer to start from a uniform base and then deviate from this format when/if it is necessary.
How was it fixed?
Fixing how types print.
Adds a __str__ for a Bitfield type, although it seems to only apply through one application of __str__, not recursively.
TODO

[x] Remove unnecessary __str__ (thanks @carver !)
[ ] Calls to str(TYPE) via the logging package do not seem to apply str recursively, only once... consult the logging docs to see if we can fix this behavior to improve the logs

Cute Animal Picture

wip: want to take another look at the stuff under TODO before merging this in

update: we get logging.debug calls in a class that derives p2p.BaseService that prints the repr instead of the str. tried a few things to replicate in an isolated example but could not recreate the behavior. going to move ahead for now and move this last part to an issue


KEP-3619: Implement  RuntimeStatus.features.supplemental_groups_policy in CRI

For:

https://github.com/kubernetes/enhancements/issues/3619

Depends on:

https://github.com/kubernetes/kubernetes/pull/125470
https://github.com/containerd/containerd/pull/10250

Depended by:

https://github.com/kubernetes-sigs/cri-tools/pull/1438

This PR is related to #9737. This PR also implements RuntimeStatus.features.supplemental_groups_policy in CRI so that kubernetes users can recognize if the CRI implementation does support SupplementalGroupsPolicy. This also helps CI tests can gracefully skip if the CRI implementation does not support SupplementalGroupsPolicy.
Note: I'm aiming to alpha-release this feature in Kubernetes 1.31(expected release date is 13th August 2024). Thank you, in advance🙇🙇

/ok-to-test

Needs rebase

@ktock this already has two approvals. Could you kindly put this into merge queue??

Needs rebase again

@AkihiroSuda Could you kindly put this into the merge queue again? 🙇


fix a couple race conditions in function worker

Motivation
The two potential race conditions:

RuntimeSpawner - make sure to interrupt the processLivenessCheckTimer so that we that the processLivenessCheckTimer doesn't potentially restart a functions during the shutdown of the functions

FunctionRuntimeManager - stop all the functions instances owned by this worker only after we close functionactioner and functionAssignmentTailer, to prevent worker from potentially starting functions during a worker shutdown

rerun integration tests


Support for mingw on Windows

Hi!
Thanks for the great job you have done so far!
Can you please add support for mingw builds on Windows?
So far i'm getting this error when trying to build.
...\ThirdParty\cppfs\source\cppfs\source\windows\LocalFileHandle.cpp:341:10: error: 'CreateSymbolicLinkA' was not declared in this scope
     if (!CreateSymbolicLinkA(dst.c_str(), src.c_str(), 0))
          ^~~~~~~~~~~~~~~~~~~

Cheers :)
🍻

Thanks for reporting, we'll have a look at this.

Please check if #13 solves this for you (the minimal windows version needed to be set)

can this be closed?


make example notebook concise

[ ]  Can we get rid of the last markers? We never talk about them, and they will only confuse most users. And should we just say "Averaged frequency" (ylabel, legend and title), just in case the user chooses to not use the orbit-averaged-omega22?

[ ] Similar change in the title,


tsdb: Fixed race in chunks.Chunks method.

Added regression test.
Fixes #6512
Without this fix, regression test result: (not deterministic result due to concurrency):
=== RUN   TestChunkReader_ConcurrentRead
--- FAIL: TestChunkReader_ConcurrentRead (0.01s)
    db_test.go:2702: unexpected error: checksum mismatch expected:597ad276, actual:597ad276
    db_test.go:2702: unexpected error: checksum mismatch expected:dd0cdbc2, actual:dd0cdbc2
FAIL

cc @brian-brazil @roidelapluie
@roidelapluie I literally used your code with small tweaks.
Signed-off-by: Bartlomiej Plotka<EMAIL_ADDRESS>

The alternative is to use sync.Pool in place of the buffer.

:+1:
I'd focus on getting a fix in and released, we can always microoptimise later.

Addressed comments. Once tests passes, let's merge.


Send rollbar_comment during deploys

Pretty self-explanatory.
FWIW I'm using this with the capistrano-pending gem to publish a changelog as the comment (I'm not on Github so I don't get the free commit log):
set :rollbar_comment, Proc.new { `cap #{fetch :stage} deploy:pending`.split("\n").grep(/^    /).join("\n\n") }

Hey there, this is great. Thanks!
Can you add a test or two for this?
Once the tests pass we'll take a second look and hopefully merge it! It would fix my (poor attempt) in #398.

Ok. So I'm told that adding Capistrano tests is challenging/difficult. What I'll do is test this manually once the other tests pass. :D

Maybe it's better to make current_revision configured? I've redefined it with
# deploy.rb
require 'rollbar/capistrano'

def current_revision
  `git log #{branch} -n 1 --pretty=format:"%H"`
end

@wemcdonald I'm worried about this change cause it forces a user input, no? I guess some customers have automated deploys where they can't enter that value.

I agree with Jon. Can we make this optional and not enabled by default?

We can do this yes. I think we should first tests this manually since we don't have capistrano tests for now.

@jondeandres I just used the interactive case as an example since it seemed the most self-explanatory. See my first comment above for something non-interactive.
@coryvirok is your concern the same, or that we're including the key in the request with a null value? That doesn't seem like it's different from any of the other values...

I was agreeing with Jon about not requiring users to enter a comment. After reading your README change more closely, it says that it's optional. Which is 👍 by me.

I just updated the text in the readme to describe what the example does and to provide another suggestion. I didn't include my use case because deploy:pending is no longer standard.

I can't think of a natural default comment, but it is something that is easy to add if there is something obvious that I am missing. Otherwise, I think we should merge this.

@ArturMoczulski Can you review this PR?

LGTM. Merging.
@mengqing you should be able to easily configure the comment using
set :rollbar_comment, Proc.new {}


chore: Added build container, devcontainer, and vscode project settings

Created .vscode and .devcontainer

Proxies azure login credentials through to host machine so you don't have to login again
Installs all necessary build dependencies to be reusable as a build container

Updated .gitignore to include build container files.
Updated environment.yml to pin all dependencies and update pandas to 1.5.0 (1.4.0 is no longer published as a binary and building from source slows down environment restoration significantly)
Added tools/docker/build/ including a Dockerfile and easy build scripts for the build/dev container setup.
Added website/environment.yml to pin website tool version without ballooning global environment size

Acrolinx Scorecards
A minimum total score of 80 is required.
Select the total score link to review all feedback on clarity, consistency, tone, brand, terms, spelling, grammar, readability, and inclusive language. You should fix all spelling errors regardless of your total score. Fixing spelling errors helps maintain customer trust in overall content quality.

Article
Total score(Required: 80)
Words + phrases(Brand, terms)
Correctness(Spelling, grammar)
Clarity(Readability)

:white_check_mark: website/README.md
100
100
100
100

:white_check_mark: website/environment.yml
100
100
100
100

More information about Acrolinx

Install Acrolinx locally for VSCode
False positives or issues
Troubleshooting issues with Acrolinx

Acrolinx Scorecards
A minimum total score of 80 is required.
Select the total score link to review all feedback on clarity, consistency, tone, brand, terms, spelling, grammar, readability, and inclusive language. You should fix all spelling errors regardless of your total score. Fixing spelling errors helps maintain customer trust in overall content quality.

Article
Total score(Required: 80)
Words + phrases(Brand, terms)
Correctness(Spelling, grammar)
Clarity(Readability)

:white_check_mark: website/README.md
100
100
100
100

:white_check_mark: website/environment.yml
100
100
100
100

More information about Acrolinx

Install Acrolinx locally for VSCode
False positives or issues
Troubleshooting issues with Acrolinx

Very interesting is this a rehydration of Dan Cs work?

Acrolinx Scorecards
A minimum total score of 80 is required.
Select the total score link to review all feedback on clarity, consistency, tone, brand, terms, spelling, grammar, readability, and inclusive language. You should fix all spelling errors regardless of your total score. Fixing spelling errors helps maintain customer trust in overall content quality.

Article
Total score(Required: 80)
Words + phrases(Brand, terms)
Correctness(Spelling, grammar)
Clarity(Readability)

:white_check_mark: website/README.md
100
100
100
100

:white_check_mark: website/environment.yml
100
100
100
100

More information about Acrolinx

Install Acrolinx locally for VSCode
False positives or issues
Troubleshooting issues with Acrolinx

/azp run

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 25.24%. Comparing base (46f16e0) to head (c750f7a).

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2227       +/-   ##
===========================================
- Coverage   79.55%   25.24%   -54.31%
===========================================
  Files         327      327
  Lines       16773    16773
  Branches     1511     1511
===========================================
- Hits        13343     4234     -9109
- Misses       3430    12539     +9109

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


rdMolDraw2D Depictions - setFontSize has no effect - 2020.09.1 release

Configuration:
Configuration:
import rdkit
rdkit.version
-->
RDKit Version: 2020.09.1
Operating system: MacOSX Darwin 10.15.7  and Ubuntu 20.04
Python version (if relevant): 3.7
Are you using conda? Yes
If you are using conda, which channel did you install the rdkit from? rdkit
What:
All depictions to .png file type have the same font size when changing SetFontSize()
Expected:
To be able to set the pixel size of the font as outlined in release docs
The fontSize()/setFontSize() (FontSize()/SetFontSize()) methods in MolDraw2D
now work in units of pixels (more or less) instead of the molecule units.
Code:
from rdkit import Chem
from rdkit.Chem import Draw
from rdkit.Chem.Draw import rdMolDraw2D

if hasattr(Draw, 'MolDraw2DCairo'):
    print('can do Cairo')
if hasattr(Draw, 'MolDraw2DSVG'):
    print('can do SVG')

smarts = 'cncO'
mol = Chem.MolFromSmiles('c1cccnc1O')
mc = rdMolDraw2D.PrepareMolForDrawing(mol)
d = Draw.MolDraw2DCairo(300, 300)

# Is it possible to change min and maxFontSize as draw properties and this changes the range?
#_options = d.drawOptions()
#_options.minFontSize = 40
#_options.maxFontSize = 200

# Default max size - try 6 to 40 with no change in the depiction
d.SetFontSize(6)

d.DrawMolecule(mc, highlightAtoms = mol.GetSubstructMatch(Chem.MolFromSmarts(smarts)))
d.FinishDrawing()
txt = d.GetDrawingText()
with open('demo1_6pixel_font_size.png', 'wb') as pngf:
    pngf.write(txt)

Exploring the docs further and experiments the default max and min font sizes are 6 and 40 'pixels'.
I understand that the font size scale automatically with bond length?
Debate:
Is this a bug or intended behaviour change?
Should setFontSize have the expected effect?

The drawMolecule function ignores setFontSize and scales the characters in the picture to be in proportion to the drawing.  The drawOptions minFontSize and maxFontSize stop them getting too big and too small as the picture is scaled, but that is currently the only way of changing the relative size of the letters wrt bond lengths etc.  it would be useful to have some use cases where that isn't sufficient, so that we can see what else might be needed.  Two things that occur and wouldn't be too much work would be an option not to scale the characters along with the rest of the picture, though I wouldn't be surprised if that didn't have knock-on effects that would make it a pain to implement; and an option to change the relative size of the characters. There is already a draw option annotationFontScale that defaults to 0.5, so that atom and bond annotations are half the size of the atom symbols.  Something similar could be introduced.  The font size would still scale with the drawing, but would be bigger or smaller compared to the bonds and such.  This would be relatively unobtrusive and in particular wouldn't change the API.
Possibly the documentation for setFontSize should explain some of this.
Input from other people, especially @greglandrum would be appreciated.


next(false) clears path on global Navigation Guards

@posva, sorry my bad in the example, but I found the reason behind my "path flashes", it's ensureURL method in the HTML5History class.
// next(false) -> abort navigation, ensure current URL
this.ensureURL(true)

If we take a look at this method
ensureURL (push?: boolean) {
  if (getLocation(this.base) !== this.current.fullPath) {
    const current = cleanPath(this.base + this.current.fullPath)
    push ? pushState(current) : replaceState(current)
  }
}

if I try to go straight to the restricted path, at some point, in my app I have next(false), that causes half-second absolutely clear URL.
When I logged vars in this method I noticed that it pushes to to url WITH aborting navigation.

When I commented that ensureURL(true) app worked as expected without annoying flashes.
Could you plz explain why do we need it?

Hi, thanks for your interest but Github issues are for bug reports and feature requests only. You can ask questions on the forum, the Discord server or StackOverflow. And please do not ping directly maintainers just to ask questions 🙏


Fix for Issue#23

Recursion error happens while trying to get code_analysis
Running that code in try-except to see if it resolves this exception

Codecov Report

Merging #24 (c193d92) into master (1398be7) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
- Coverage   98.15%   98.12%   -0.03%
==========================================
  Files          17       16       -1
  Lines         488      481       -7
==========================================
- Hits          479      472       -7
  Misses          9        9

Impacted Files
Coverage Δ

...ery_profiler_storage/django_stack_trace_analyze.py
96.55% <100.00%> (-0.06%)
:arrow_down:

..._query_profiler/django/db/backends/sqlite3/base.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1398be7...c193d92. Read the comment docs.


Running git push triggers reloading

reported by @rauchg

@nkzawa @rauchg just tried, can't reproduce 🤔, can you give some context.
 Fake news by @rauchg

👍


Cleanup package hierarchy again

in general we still have way too many packages, ex "cmd" vs "binary" etc. Once the main entanglement caused by the object model is done #232, let's clean up more
Ex. you'll notice the "binary" thing makes the hierarchy more bizarre also, particularly with "envoytest" in there
internal
internal/globals
internal/cmd
internal/transport
internal/test
internal/test/morerequire
internal/test/manifest
internal/manifest
internal/version
internal/binary
internal/binary/envoytest
internal/binary/envoy
internal/binary/envoy/debug
internal/errors
internal/tar

current status: most of the weird stuff and tension is between "envoy" and "envoy/debug" and "envoy" vs "cmd"
internal/globals
internal/cmd
internal/test/morerequire
internal/envoy
internal/envoy/debug
internal/version
internal/tar

debug is better named now as shutdown (as in shutdown hooks). As issues are best defined in a way they can be solved, and this is not very actionable anymore, I'll close it!


container details are missing from details panel on containers by images view.

Should be fixed by #228

probe needs to emit image topology
produce rendered nodes from endpoints -> process -> containers -> images


Mismatch in function signature between doc and header file for SSL_group_to_name()

The documentation reports:
const char *SSL_group_to_name(const SSL *ssl, int id);

but the header includes:
https://github.com/openssl/openssl/blob/74fd6823884e27c18ec3fe7bd99b9bc02e6f31f3/include/openssl/ssl.h.in#L1511

This was noticed by @botovq in https://github.com/sfackler/rust-openssl/pull/2201#discussion_r1516756496

I think this makes sense for master, but I'm not sure we can make the corresponding change in 3.1 or 3.2 as it would constitute an API change in a stable release
OTC: Can we modify a public api to qualify a type as const in a stable release

Can we modify a public api to qualify a type as const in a stable release

No, but we can change the documentation to match reality.

fixed


HTTPTrigger: Recommend way to keep connections hot?

Is your question related to a specific version? If so, please specify:
What binding does your question apply to, if any? (e.g. Blob Trigger, Event Hub Binding, etc)
HTTPTrigger
Question
We are using Azure Functions with Python (with custom Docker Image) using the Premium Plan to build rest api. It is important for these to reply fast. Hence we would like to ensure that connections stay alive/ tokens are refreshed even though no work is arriving and that they are ready before they receive requests.
My question is therefore two-fold:

What is the recommend way to ensure that connections stay alive/ tokens stay fresh? Is that using the health check or using a Timer Trigger? I can see that health checks a some point weren't recommended for premium https://github.com/Azure/Azure-Functions/issues/2273 . On the other hand - are Time triggers guaranteed to happen per process running the function such that they will renew the token at hand? .

When the function receives the first call it needs to authenticate with a Service Principal to get a token which is used for connecting to other Azure Resources. This can take a some seconds. Is it possible to limit traffic so a newly started function doesn't get incoming requests routed to it before  it is ready (similar to readiness probe in Kubernetes).  Ì can´t determine if post_function_load_app_level  from azure.functions.AppExtensionBase can be used as it is not clear if requests are still routed (and just wait for post_function_load_app_level  to complete) or they will go to other instances of the function.

I had missed warm-up trigger so I guess that solves 2. https://learn.microsoft.com/en-us/azure/azure-functions/functions-bindings-warmup?tabs=in-process&pivots=programming-language-python but my question for 1 still stands :-)

Hi @thomasfrederikhoeck,
Can you give more context on what connections stay alive/ tokens stay fresh you are referring to here?
Also, could you give an example on how the connections are being used?

Hi @gavin-aguiar something like a static client like the following
from azure.identity.aio import ClientSecretCredential

client = ClientSecretCredential(tenant_id, client_id, client_secret)

SCOPE = "some-scope"

async def main():
   token = await client.get_token(SCOPE)
   await some_func(token)

The first time this client calls it fetches it (slow) and subsequent calls uses a cache until the token expires.

So something that warms up by calling .get_token() and then keeps calling it every minute so there is always a cached token without delay.

Cross-linking to issue with warmup trigger for full picture: https://github.com/Azure/azure-functions-python-worker/issues/1135


Can this be used for Jambo inference

Can I use this solution for inference https://huggingface.co/ai21labs/Jamba-v0.1/discussions with offloading mamba moe layers?
Jambo it SOTA open source long context model and its support would be very useful for this library.

Hey, @freQuensy23-coder! The code in this repo is quite transformer-moe specific. I'm not too familiar with mamba-like architectures, but afaik @lavawolfiee has plans for adapting Jamba to work with our offloading strategy.


[psetv2] Add new partial input fields

The spec now defines 3 new per-input proprietary fields that must be added to our implementation:

PSBT_ELEMENTS_IN_EXPLICIT_ASSET
PSBT_ELEMENTS_IN_ASSET_PROOF
PSBT_ELEMENTS_IN_BLINDED_ISSUANCE

NOTE: By adding the PSBT_ELEMENTS_IN_BLINDED_ISSUANCE input field, we don't need the argument issuanceInputBlindingArgs in generator.blindOutputs anymore.
That argument was needed to know if an input issuance (ONLY issuance, not reissuance) is blinded or not. Now, we can know this directly from the partial input field.


Added full stack resourses

Added some full stack resources to full stack development dir.

I haven't assigned anyone on the Issue to which your Pull Request is linked to as I think that the issue should remain opened for others to contribute as well.
That's why I request you to change the Description of your PULL REQUEST
& dont include Closes/Close/Fixes/Fix words in your PR.
Instead add the resources in the PR as well to make it more meaningful.

Ohh ok my bad

No it's not your bad.
You are doing a well, i.e. learning !

Looks good
Thanks @Virtual4087 ❤


ListFirewallEgressRulesCmd: extend from BaseListTaggedResourcesCmd an…

…d cleanup
Fixes API duplicate parameter in docs and makes it more clear.
Fixes a bunch of typos.

@resmo can you check and fix the build issue? Travis is failing too while building.

@bhaisaab It's been a while since I coded JAVA, have no clue, why it is failing. May I ask you for a hint?

@resmo looks like an interface/type issue, see the error here: https://builds.apache.org/job/cloudstack-pull-requests/160/console I can help fix it next week, but if you've an IDE just fix the type and interface usage

@bhaisaab a good IDE helps indeed.

@resmo looks good to me, Travis is green too. Will merge tonight or tomorrow after some build tests. Thanks.

Builds fine, merging.


CodeGen update for Object Detection

Should be able to share one CodeGen project for both ML.Net and Azure AutoML Object Detection
How to show object frame in console app

PR isn't in for this. IMO we should just close this item because 1. We're not shipping it and 2. This will be verified in an Object detection bug bash.
We could reopen but I think this was more for Tevin's tracking.


add increment and multiply operators

Thank you, Dimitar, for a valuable contribution! 🥇
I'll review it ASAP

Thank you for four comments, i've fixed the jsdoc issues, and added decrement and divide operators on the way.


Document sorting algos

done https://github.com/strongSoda/data-structures-and-algorithms/commit/781482dcb6c8f8930244411af8bbb3aaf67021b2


go mod: replace package path

Stack:

#14 ⬅
#13

⚠ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.


Problem with automations using Input Number's to write to registers

Home Assistant release with the issue:
0.90.0
Last working Home Assistant release (if known):
0.86.2 where I was using @Monkey-House multiple modbus hub workaround and @gertdb fix (to write to single values) which became incorporated to 0.90.0 recently
Operating environment (Hass.io/Docker/Windows/etc.):
QNAP NAS Docker-Container Station
Component/platform:
https://www.home-assistant.io/components/modbus/ in particular the 'Write register' service.
Description of problem:
Using 0.90.0 I have several automations using Input Number's to write to registers. These have all been working fine using @Monkey-House multiple modbus hub workaround and @gertdb fix (to write to single values) which became incorporated to 0.90.0 recently.
To make this new inbuilt system work I have modified the automations like:
- id: IrrigationShadehouseSetpoint
  alias: Irrigation Shadehouse Setpoint
  trigger:
    platform: state
    entity_id: input_number.slider3
  action:
    service: modbus.write_register
    data_template:
      hub: hub1
      unit: 3
      address: 3079
      value: "{{ states.input_number.slider3.state|int }}"

Also my config is all up and running now (with no trouble at all for modbus sensors, modbus binary sensors and modbus switches) for multiple modbus hubs using:
modbus:
  - name: hub5
    type: tcp
    host: MyIP
    port: 5003

  - name: hub3
    type: tcp
    host: MyIP
    port: 5001

  - name: hub1
    type: tcp
    host: MyIP
    port: 5002

However I now get this error in my logs when I try to set the register value with input number:
Traceback (if applicable):
Sat Mar 30 2019 15:58:42 GMT+1000 (Australian Eastern Standard Time)
Error while executing automation automation.irrigation_start_time. Unknown error for call_service at pos 1:
Traceback (most recent call last):
  File "/usr/src/app/homeassistant/components/automation/__init__.py", line 381, in action
    await script_obj.async_run(variables, context)
  File "/usr/src/app/homeassistant/helpers/script.py", line 131, in async_run
    await self._handle_action(action, variables, context)
  File "/usr/src/app/homeassistant/helpers/script.py", line 210, in _handle_action
    action, variables, context)
  File "/usr/src/app/homeassistant/helpers/script.py", line 299, in _async_call_service
    context=context
  File "/usr/src/app/homeassistant/helpers/service.py", line 88, in async_call_from_config
    domain, service_name, service_data, blocking=blocking, context=context)
  File "/usr/src/app/homeassistant/core.py", line 1138, in async_call
    self._execute_service(handler, service_call))
  File "/usr/src/app/homeassistant/core.py", line 1162, in _execute_service
    await self._hass.async_add_executor_job(handler.func, service_call)
  File "/usr/local/lib/python3.7/concurrent/futures/thread.py", line 57, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/src/app/homeassistant/components/modbus/__init__.py", line 149, in write_register
    hub_collect[client_name].write_register(
KeyError: 'default'

Additional information:
Is there something I have missed in my config or automation changes?
Cheers in advance for any help with this problem!

UPDATE:
On creation of a new container just now with the new version 0.91.0 and testing all functions are as expected I found that it appears that writing to modbus registers has been fixed?
I looked here and could not find anything that would indicate work having been done on the issue of writing to modbus issues but in any case the issue appears to be resolved for me so thanks to anyone who may have tidied something up that was causing the problem.
Cheers!


undefined method `total_pages' when using Kaminari

I know this has been reported before (back in 2014 with #208), but none of the mentioned workarounds fix this issue.
To cover the basics, I do have the kaminari gem before elasticsearch-model and elasticsearch-rails in my Gemfile.  ElasticSearch is installed and configured properly, and the .search() method does return valid results if no extra scopes are used after the .records call.
Versions:

rails 4.2.8
kaminari 1.0.1
elasticsearch-model 5.0.2
elasticsearch-rails 5.0.2
ElasticSearch 6.2.2, Build: 10b1edd/2018-02-16T19:01:30.685723Z, JVM: 1.8.0_151

Here is actual code from my application:
# In a controller action:
@listings = Listing.active
  .includes(:category, seller: :user_segment)
  .search(params[:q])
  .page(params[:page])
  .records

# Later on in that same action, after checking filter/sort params:
@listings = @listings.where(auction: true)
# ...
@listings = @listings.where(condition: (params[:condition_min]..params[:condition_max]))
# ...
@listings = @listings.order(params[:order_by])

In the view, we're simply using the paginate kaminari helper:
= paginate @listings

And the exact error:

Now what is interesting about this, is that .records has proper pagination methods attached to the relation unless a where() and/or order() clause is called after the fact:
[1] pry(main)> Listing.active.search('bluetooth').page(1).records.class
=> Elasticsearch::Model::Response::Records
[2] pry(main)> Listing.active.page(1).class
=> Listing::ActiveRecord_Relation
[3] pry(main)> Listing.active.search('bluetooth').page(1).records.where(auction: false).class
=> Listing::ActiveRecord_Relation
[4] pry(main)> Listing.active.page(1).total_pages
=> 127
[5] pry(main)> Listing.active.search('bluetooth').page(1).records.total_pages
=> 1
[6] pry(main)> Listing.active.search('bluetooth').page(1).records.where(auction: false).total_pages
NoMethodError: undefined method `total_pages' for #<Listing::ActiveRecord_Relation:0x000055a190f67bb0>
from /home/<cut>/.rbenv/versions/2.4.3/gemsets/<cut>/gems/activerecord-4.2.8/lib/active_record/relation/delegation.rb:136:in `method_missing'

It's almost as if the pagination methods are removed from the AR Relation after calling .records.where(), as the pagination methods (#total_pages, etc) work just fine on an AR Relation that does not go through the ES Records wrapper.  There is no default_scope on that model that could be interfering.

@karmi Can I get an update on this?

For what it's worth, I just switched over to will_paginate in that same application and the exact same problem exists with that library.

Hi @Oshuma, this sounds either like a bug in the "wrapper", as you suggest, or some gotcha in the integration between the pagination library and a) elasticsearch-model b) ActiveRecord. Just to be sure, Listing.active.page(1).total_pages does work or no?
I'm afraid I won't have time to properly look into it soon, but we've scheduled some significant effort for May/June this year to pick up the issues again.

@karmi Yes, Listing.active.page(1).total_pages does work and returns a valid value.  If you could point me in the right direction, I could try taking a look at fixing this if I get some time.  I briefly glanced at the code, but nothing really stuck out as being "wrong".

Just checking in since it's been a while since this was reported a few weeks ago. I'm not familiar with elasticsearch-rails, so correct me if I'm wrong.
I wonder what happens under the hood when calling Listing.active.search('bluetooth').page(1).records. If I understand this correctly, once we call the search method then it'll become an elasticsearch scope, which is the receiver of the page call. Then there's a following records call, which I think returns a ActiveRecord Relation object. From that point the ES scope is sort of discarded and now it relies solely on ActiveRecord, so I'm not sure how all these pieces work together.
I would think that this is an edge case where the user of the gem needs to call an additional page explicitly as ES scope is not directly transferable to AR scope.

I don't understand what it semantically means to chain pagination-related methods after the query is "handed over" to ActiveRecord. For instance, using this example:
Listing.active.search('bluetooth').page(1).records.where(auction: false).total_pages
What do you expect 'total_pages' to refer to? The Elasticsearch query or the ActiveRecord query?
There are two queries to 2 separate data sources in the above command, the first to Elasticsearch and the second to your ActiveRecord data storage. It doesn't make sense to pagination the two queries separately. If you could do this, for example, it'll only ever return 1:
Listing.active.search('bluetooth').page(n).records.where(auction: false).total_pages
That said, what is the request in this issue?

@estolfo The issue is that pagination methods are getting "lost" somewhere along the way.  As in, #total_pages doesn't exist after chaining AR methods (filtering the results from ES).

Hi @Oshuma Did you see my above comment? This code:
Listing.active.search('bluetooth').page(1).records.where(auction: false).total_pages

actually makes two requests: first it queries Elasticsearch, then it fetches the records from your other datastore using the ids obtained in the Elasticsearch query. It doesn't make sense to apply the pagination to both requests. The pagination should apply to only one. If you want to get the total_pages from the pagination on the Elasticsearch query, you should do:
Listing.active.search('bluetooth').page(1).total_pages

as soon as you call #records, you are doing a separate query using ActiveRecord. If you want to paginate the results there, you should called a pagination method after #records in the method chain. For example:
Listing.active.search('bluetooth').records.where(auction: false).page(1).total_pages

I'm going to close this, as there's nothing the gem can do about where the pagination is intended.
Please call a pagination method on either the Elasticsearch query chain or ActiveRecord query chain.

We had this issue about two years ago when updating our implementation on search.
I think I got to the bottom of it today..
Will add my discoveries for the next developer that comes around.
We have an elasticsearch method that hides a couple of things under the rug like pagination. The only thing is that it will always return the same class.
Player.elasticsearch(params).class
> Elasticsearch::Model::Response::Response

now trying to use the .records method...
Player.elasticsearch(params).records.class
> Elasticsearch::Model::Response::Records

At this stage, pagination is kept, total_pages can be called and we can just use that as any active record collection too.
Now, the "issue" happens when we start chaining methods onto that .records method. Let say I just want to remove SQL N+1, that won't change the size of the collection, the number of searched records, or anything else... but!
Player.elasticsearch(params).records.includes(:user).class
> Player::ActiveRecord_Relation

From there, pagination is lost, we aren't relying on the ES Records class anymore but on ActiveRecord.
Hope someone else finds this useful.


BUG | Responding to self

Expected Behavior
When the user send messages in the chat, ValGPT should not answer. Only messages sent by other players should be answered
Current Behavior
When the user has an unsupported character in their name, ValGPT answer their messages, then answering those messages, creating an infinite loop.
Steps to Reproduce

Start the soft
Insert GPT Key
Start VALORANT on an account with an unsupported character (eg: Céleste)
Start listener and ValGPT
Queue in game
Receive message or send a message

Context

Operating System: Windows 11
Release : v1.1.0

does your username in game contain special or non alphanumeric characters?

Yes it does "é"

this probably originates from the username being used as is
const username = await getUsername(lockData)

and the the message author name being fixed to the openAI specs
const unfixedName = msg["game_name"];
const name = unfixedName.replace(/[^a-zA-Z0-9_-]/g, '_');

Published a new release that should fix the mismatch
https://github.com/idkfelix/ValGPT/releases/tag/v1.1.2


Pwa 438 test coverage

Pull Request Test Coverage Report for Build 1296

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 35.818%

Totals

Change from base Build 1295:
0.0%

Covered Lines:
1235

Relevant Lines:
3345

💛  - Coveralls


Cancelling an Android job leads to the agent getting 'stuck'

The problem
When a job is cancelled while running Android Instrumentation tests (i.e. tests run on a device/emulator) the agent gets 'stuck' when starting the next job.
Symptoms
Here's the error log output from the agent when launched in debug mode:

2016-06-02 09:28:08 INFO   Canceling job d68c870e-7c92-4499-b025-b2aef4f94dc5
2016-06-02 09:28:08 DEBUG  [Process] Sending signal: terminated to PID: 3773
2016-06-02 09:28:08 DEBUG  [Process] Checking to see if PID: 3773 is still alive
2016-06-02 09:28:18 DEBUG  [Process] Sending signal: killed to PID: 3773
2016-06-02 09:28:21 DEBUG  GET https://agent.buildkite.com/v3/jobs/d68c870e-7c92-4499-b025-b2aef4f94dc5
2016-06-02 09:28:21 DEBUG  ↳ GET https://agent.buildkite.com/v3/jobs/d68c870e-7c92-4499-b025-b2aef4f94dc5 (200 OK 116.545637ms)
2016-06-02 09:28:24 DEBUG  GET https://agent.buildkite.com/v3/jobs/d68c870e-7c92-4499-b025-b2aef4f94dc5
2016-06-02 09:28:24 DEBUG  ↳ GET https://agent.buildkite.com/v3/jobs/d68c870e-7c92-4499-b025-b2aef4f94dc5 (200 OK 109.835149ms)
2016-06-02 09:28:27 DEBUG  POST https://agent.buildkite.com/v3/heartbeat
2016-06-02 09:28:27 DEBUG  ↳ POST https://agent.buildkite.com/v3/heartbeat (200 OK 108.81019ms)
2016-06-02 09:28:27 DEBUG  Heartbeat sent at 2016-06-02T09:28:27.232635014+01:00 and received at 2016-06-02T08:28:27.292+00:00
2016-06-02 09:28:28 DEBUG  GET https://agent.buildkite.com/v3/jobs/d68c870e-7c92-4499-b025-b2aef4f94dc5
2016-06-02 09:28:28 DEBUG  ↳ GET https://agent.buildkite.com/v3/jobs/d68c870e-7c92-4499-b025-b2aef4f94dc5 (200 OK 110.906448ms)
2016-06-02 09:28:31 DEBUG  GET https://agent.buildkite.com/v3/jobs/d68c870e-7c92-4499-b025-b2aef4f94dc5
2016-06-02 09:28:31 DEBUG  ↳ GET https://agent.buildkite.com/v3/jobs/d68c870e-7c92-4499-b025-b2aef4f94dc5 (200 OK 109.952588ms)

As you can see, after the previous job is cancelled it repeatedly GETs the next job but does nothing else. This cycle - GETting the job every 3 seconds and POSTing a heartbeat every 20 seconds - repeats indefinitely.
Other symptoms:

In the Buildkite web interface, the job it is 'stuck' on shows up in the 'scheduled' list. However, the agent is shown as busy running the first step in that job.
The Android Emulator on the CI machine is left in a strange state - it is still present in the Dock, but there's no UI. (We don't run the emulator in headless mode so this is unusual.)
I can't open any new terminals on the CI machine once the issue occurs. A terminal window opens it doesn't get as far as issuing a command prompt. This issue doesn't reappear after restarting the machine.

Our setup/other misc info

The first step in all our pipelines is a pipeline upload step. (I don't know if this has any bearing on the job getting stuck.)
We run CI on a single mac mini, on which we run 3 build agents. One for Android CI, one for iOS CI, and one for simply building & distributing artifacts. The iOS and distribution agents appear to be unaffected by this issue.
Agents are launched as background processes via LaunchCtl .plist files.
Our Android agent builds our app & runs tests using a fairly standard Android Gradle setup.
Instrumentation tests are run on an Android Emulator 2.0 Beta which is started fresh for each build.

My best guess on this issue is that the cancellation of the previous job isn't working correctly, and some child processes are being left in an invalid/suspended state. It looks like you send a SIGTERM followed by a SIGKILL, but the SIGKILL wouldn't kill any child processes AFAIK.

@vaughandroid thanks for submitting the issue! The log you posted helps a lot.
I re-looked at the code that cancels the process, and you're right. We first send terminated then if the process doesn't die within 10 seconds, we send killed. I actually haven't figured out what happens after that yet.
I don't suppose you have a example android application (or can point to me) somewhere publicly on GitHub that I can clone and play with? That would make replicating this bug easier!

Unfortunately I don't have an example app I can point you to, and I'm not aware of any demo projects out there which fire up the emulator in order to run tests. If I can find time I'll see about putting one together, but it isn't going to be in the next day or two.
I did get more evidence that it's the emulator not being shut down correctly that's causing the issue: If I manually close the emulator and then cancel the job, the issue doesn't occur.
If #119 gets fixed, I might be able to hack something together to send a SIGTERM/SIGKILL directly to the emulator process. Of course, depending on how #119 gets fixed then this issue might disappear anyway. 😃

Fixed in https://github.com/buildkite/agent/pull/464

This is still happening to me on 3.0.0
Cancelling any gradle-job leads to the agent being stuck (already "selected" the next job, but not starting it) until I kill -9 [pid] end the gradle build process.


Outline waterbodies

This style currently gives bodies of water a relatively dark fill. On land, the water layer overpowers the land in areas with many lakes and streams, undercutting the illusion that the land is a layer atop the water (which is really just an illusion). At sea, the dark color contrasts too much with the boundaries of marine parks.

Print maps use a variety of blues for water. Maps aiming for a more rustic look tend to choose darker shades, but most choose lighter shades, probably to cut down on the cost of ink. A light fill almost always has a hairline stroke around the coastline or shoreline to give it more definition.

I think we should lighten the water fill and add a darker outline that matches the waterway line color. To keep seams in the water layer from appearing at the edges of harbors and along rivers, the line layer should be underneath the fill layer. I think a lighter color will make the marine parks look much less awkward and also dull the effect of faux knockout halos around place labels over sea (#606).

Can we get an estimate on how much we can expect to save on ink?
I can't remember why we made it so dark, but I suspect you'll find out shortly what the issue was :joy:


Add support router HEAD request

Adding router to support HTTP HEAD method request.

Codecov Report

Merging #616 into master will decrease coverage by 0.2%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #616      +/-   ##
=========================================
- Coverage   70.81%   70.6%   -0.21%
=========================================
  Files          49      49
  Lines        6982    6988       +6
=========================================
- Hits         4944    4934      -10
- Misses       2038    2054      +16

Impacted Files
Coverage Δ

include/pistache/router.h
100% <ø> (ø)
:arrow_up:

src/server/router.cc
63.36% <100%> (+0.74%)
:arrow_up:

src/client/client.cc
77.29% <0%> (-3.63%)
:arrow_down:

include/pistache/http.h
93.61% <0%> (+1.59%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update feaf5a4...6e94b3e. Read the comment docs.

Kupo!

Pushed to unstable PPA.

Thanks for merging


Docker development environment not rebuilding after local changes.

I currently have a container set up with FuseBox for development. I am able to hit localhost:4444 and load the page but when make changes on my local drive nothing rebuilds so even when I refresh the page manually nothing changes.
From past experience after pulling hair for a day or two when I was setting up a live development environment working with Docker + Webpack I eventually learned that the legacyWatch mode that invokes file polling in Webpack had to be turned on for file polling for the container in order to watch files and rebuild. I have a Docker image that works perfect for development using Webpack and it really was only that legactWatch mode if that helps.
The same goes with using nodemon with Docker. You have to create the nodemon config and set legacyWatch to true. It has to do with different file systems.
Also, I do not know how to change the port the WebSocket connects to. It seems to only like port 4444. I changed the port for the dev server and the socket continued to want 4444. No big deal but may arise in the future.
docker-compose.yml to start container and map volume to directory:
version: "3"
services:
  web:
    restart: always
    container_name: test-web
    build:
      context: .
      dockerfile: ./Dockerfile
    ports:
     - 4444:4444
    volumes:
     - .:/usr/app
     - /usr/app/node_modules

Working Dockerfile with node-sass (pain in the ass to figure out so it may help others) built in:
# Download base image.
FROM node:8.9.4-alpine

RUN apk update && \
    apk upgrade && \
    apk add git g++ gcc libgcc libstdc++ linux-headers make python

# install libsass
RUN git clone https://github.com/sass/sassc && cd sassc && \
    git clone https://github.com/sass/libsass && \
    SASS_LIBSASS_PATH=/sassc/libsass make && \
    mv bin/sassc /usr/bin/sassc && \
    cd ../ && rm -rf /sassc

# created node-sass binary
ENV SASS_BINARY_PATH=/usr/lib/node_modules/node-sass/build/Release/binding.node
RUN git clone --recursive https://github.com/sass/node-sass.git && \
    cd node-sass && \
    git submodule update --init --recursive && \
    npm install && \
    node scripts/build -f && \
    cd ../ && rm -rf node-sass

# add binary path of node-sass to .npmrc
RUN touch $HOME/.npmrc && echo "sass_binary_cache=${SASS_BINARY_PATH}" >> $HOME/.npmrc

ENV SKIP_SASS_BINARY_DOWNLOAD_FOR_CI true
ENV SKIP_NODE_SASS_TESTS true

# Create app directory.
RUN mkdir -p /usr/app

# Set initial command-line directory.
WORKDIR /usr/app

# Install app dependencies.
COPY package.json /usr/app/
RUN npm install

# Copy app source to container.
COPY . /usr/app

# Expose port.
EXPOSE 9000

VOLUME ["/usr/app"]

CMD ["npm", "run", "start"]

I still need help getting hmr to work from a docker container.
Please help me so I can use fuse-box and then I have a reason to contribute. Thanks!
fuse config:
'use strict';

import {
    FuseBox,
    WebIndexPlugin,
    QuantumPlugin,
    PostCSSPlugin,
    CSSPlugin,
    BabelPlugin
} from 'fuse-box';

import { task, context, watch } from 'fuse-box/sparky';
import * as postcssNested from 'postcss-nested';

const isProduction = process.env.NODE_ENV === 'production';

/*
CONFIG
*/

context(
    class Context {
        constructor() {
            this.config = FuseBox.init({
                target: 'browser@es6',
                cache: !isProduction,
                hash: isProduction,
                log: true,
                useTypescriptCompiler: true,
                homeDir: 'src',
                output: `public/$name.js`,
                tsConfig: 'tsconfig.json',
                modulesFolder: 'node_modules',
                sourceMaps: {
                    project: !isProduction,
                    vendor: false
                },
                plugins: [
                    [
                        PostCSSPlugin([postcssNested], {
                            sourceMaps: false
                        }),
                        CSSPlugin({
                            outFile: (file) => {
                                return `public/${file}`;
                            },
                            inject: (file) => {
                                return `${file}`;
                            },
                            minify: isProduction
                        })
                    ],

                    // JavaScript optimazations.
                    isProduction &&
                        QuantumPlugin({
                            bakeApiIntoBundle: false,
                            ensureES5: false, // Ensures that all code that is in es5
                            extendServerImport: false, // If you are using dynamic import statements to load remote javascript files. note: Install request library beforehand
                            manifest: true, // Generates manifest.json
                            processPolyfill: false, // Removes "use strict" from the code
                            removeExportsInterop: true, // Removes Object.defineProperty(exports, '__esModule', { value: true });
                            removeUseStrict: true,
                            replaceProcessEnv: true, // Replaces process.env.NODE_ENV with a string identifier "production"
                            replaceTypeOf: true, // Replaces typeof module, typeof exports, typeof window, typeof define, typeof require keywords to corresponding values at build time
                            target: 'browser@es6', // Default value: browser Possible values server, browser, universal, electron, npm
                            treeshake: true,
                            warnings: true,
                            uglify: {
                                es6: true
                            }, // Quantum supports both uglify-js and uglify-es. Which one to use is determined by es6 option.
                            css: {
                                clean: true
                            }
                        }),

                    // Generate index.html.
                    WebIndexPlugin({
                        template: `src/templates/index.html`,
                        appendBundles: true
                    })
                ]
            });
        }

        getConfig() {
            return this.config;
        }
    }
);

/*
TASKS
*/

/* Build */

task('build', async (ctx) => {
    const fuseConfig = ctx.getConfig();

    fuseConfig.bundle('vendor').instructions('~ client.tsx');

    fuseConfig.bundle('app').instructions('!> client.tsx');

    return await fuseConfig.run();
});

task('build:dev', async (ctx) => {
    const fuseConfig = ctx.getConfig();

    fuseConfig.bundle('app').instructions('> client.tsx');

    return await fuseConfig.run();
});

/* Run */

task('start:dev', async (ctx) => {
    const fuseConfig = ctx.getConfig();

    fuseConfig.bundle('app').instructions('> client.tsx');

    fuseConfig.dev({
        port: 9000,
        httpServer: true
    });

    watch('src/**/*.*', {}, (file) => {
        fuseConfig.sendPageHMR();
    });

    return await fuseConfig.run();
});

npm script:
"start:dev": "npm run clean && cross-env NODE_ENV=development nodemon fuse.js start:dev",

Dockerfile:
# Download base image.
FROM node:9.11.1-alpine

# Create app directory.
RUN mkdir -p /usr/app

# Set initial command-line directory.
WORKDIR /usr/app

# Install app dependencies.
COPY package.json /usr/app/
RUN npm install --quiet

# Copy app source to container.
COPY . /usr/app

# Expose port.
EXPOSE 9000

# Set volumes for live editing.
VOLUME ["/usr/app"]

CMD ["npm", "run", "start:dev"]

docker-compose.yml:
version: "3"
services:
  gridplus-takehome-web:
    restart: always
    container_name: gridplus-takehome
    build:
      context: .
      dockerfile: ./Dockerfile.dev
    ports:
     - 9000:9000
    volumes:
     - .:/usr/app

docker start command:
docker-compose -f docker-compose.dev.yml up --build

@chickendinosaur How about if you use chokidar directly to watch the files?  Or add some options to it
fuse.run({chokidar : {/*options here for sure that have something that might work*/} })

@nchanged So I got it working. Thank you! However, there is a caveat. The client only connects when using port 4444 for the dev server. Even if the docker container is mapped using a different port for : like 9000:4444 it still requires everything to be set to port 4444 (4444:4444).
Working task:
task('start:dev', async (ctx) => {
    const fuseConfig = ctx.getConfig();

    fuseConfig
        .bundle('app')
        .instructions('> client.tsx')
        .watch()
        .hmr();

    fuseConfig.dev({
        port: 4444,
        httpServer: true,
        root: 'public'
    });

    return await fuseConfig.run({
        chokidar: {
            usePolling: true
        }
    });
});

docker-compose.yml:
version: "3"
services:
  gridplus-takehome-web:
    restart: always
    container_name: gridplus-takehome
    build:
      context: .
      dockerfile: ./Dockerfile.dev
    ports:
     - 4444:4444
    volumes:
     - .:/usr/app

Awesome, if you don't mind, i'll copy that over to our docs


How to update firmware with wio-cli

As the title suggest, I'm wondering how to update firmware with this cli tool since I'm not able to use the app with the phone.

Because the APP is easier to configure, drag-and-drop operations are easy, and ports are filtered. But Android and IOS apps need to be updated all the time along with Android and IOS systems.
Perhaps configuration is an option in the cli command. This requires launching a community project. Because there's a lot of work to be done. @KillingJacky


chore(deps): remove adm-zip from dependencies

It's required through webdriver-manager now.

LGTM.


I can't believe you did it ！

Are you saying that you implemented a method in this project to save all the key points of dwpose, like json of openpose？

yea, you can easily access an array of keypoints
but it's a python dict, not in a json format, you would need to convert it to json yourself
Feel free to open an issue describing why do you need a .json, and i'll implement it

yea, you can easily access an array of keypoints but it's a python dict, not in a json format, you would need to convert it to json yourself Feel free to describe why do you need a .json, and i'll implement it

It doesn't matter if it's a dictionary or something, as long as the posture information can be stored. There has been a lot of work over the last five or six years based on openpose's json file, and it would be helpful for researchers to store this information.
This will make the repository even more popular, some models, when they read, they read json by default. Of course, a dictionary is fine, as long as you can output it to a file.