BUG: lvmvolume is inconsistent with the actual allocated lv size

What steps did you take and what happened:
Due to insufficient pvc resources, the pod keeps restarting. After expanding the pvc, it is found that the lv has not been successfully expanded. The remaining vg resources of the node are sufficient. Since the underlying lv has not been successfully expanded, the pod keeps restarting.
root@test-node-003:~# lvdisplay /dev/lvmvg/pvc-bcc852f8-7266-48c4-aedc-34adb523d224
  --- Logical volume ---
  LV Path                /dev/lvmvg/pvc-bcc852f8-7266-48c4-aedc-34adb523d224
  LV Name                pvc-bcc852f8-7266-48c4-aedc-34adb523d224
  VG Name                lvmvg
  LV UUID                vjfkb2-ls7c-YzO7-nZYf-Ds70-3CVP-7EA5jl
  LV Write Access        read/write
  LV Creation host, time openebs-lvm-node-d8krs, 2024-06-19 14:35:24 +0800
  LV Status              available
  # open                 1
  LV Size                1.00 GiB
  Current LE             256
  Segments               1
  Allocation             inherit
  Read ahead sectors     auto
  - currently set to     256
  Block device           253:151

root@test-node-003:~# kubectl get lvmvolume -n openebs pvc-bcc852f8-7266-48c4-aedc-34adb523d224 -o yaml
apiVersion: local.openebs.io/v1alpha1
kind: LVMVolume
metadata:
  creationTimestamp: "2024-06-19T06:35:24Z"
  finalizers:
  - lvm.openebs.io/finalizer
  generation: 4
  labels:
    kubernetes.io/nodename: test-node-003
  name: pvc-bcc852f8-7266-48c4-aedc-34adb523d224
  namespace: openebs
  resourceVersion: "241412658"
  uid: 00e27140-261e-449f-a048-af94b1b312f3
spec:
  capacity: "17179869184"
  ownerNodeID: test-node-003
  shared: "yes"
  thinProvision: "no"
  vgPattern: ^lvmvg$
  volGroup: lvmvg
status:
  state: Ready

lvSize: 1Gib , lvmvo: 16Gib
kubectl get pvc -n ns-gewclvtg data-test-ytxrw6b0n6-mongodb-2 -o yaml
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  annotations:
    pv.kubernetes.io/bind-completed: "yes"
    pv.kubernetes.io/bound-by-controller: "yes"
    volume.beta.kubernetes.io/storage-provisioner: local.csi.openebs.io
    volume.kubernetes.io/selected-node: test-node-003
    volume.kubernetes.io/storage-provisioner: local.csi.openebs.io
  creationTimestamp: "2024-06-19T06:35:23Z"
  finalizers:
  - kubernetes.io/pvc-protection
  labels:
    app.kubernetes.io/instance: test-ytxrw6b0n6
    app.kubernetes.io/managed-by: kubeblocks
    app.kubernetes.io/name: mongodb
    apps.kubeblocks.io/component-name: mongodb
    apps.kubeblocks.io/vct-name: data
    kubeblocks.io/volume-type: data
  name: data-test-ytxrw6b0n6-mongodb-2
  namespace: ns-gewclvtg
  ownerReferences:
  - apiVersion: apps.kubeblocks.io/v1alpha1
    blockOwnerDeletion: true
    controller: true
    kind: Component
    name: test-ytxrw6b0n6-mongodb
    uid: f131a510-755d-4ae2-a828-9d878b82e121
  resourceVersion: "241412684"
  uid: bcc852f8-7266-48c4-aedc-34adb523d224
spec:
  accessModes:
  - ReadWriteOnce
  resources:
    requests:
      storage: 16Gi
  storageClassName: openebs-backup
  volumeMode: Filesystem
  volumeName: pvc-bcc852f8-7266-48c4-aedc-34adb523d224
status:
  accessModes:
  - ReadWriteOnce
  capacity:
    storage: 16Gi
  phase: Bound

What did you expect to happen:
lv Size = LvmVolume cr size
The output of the following commands will help us better understand what's going on:
(Pasting long output into a GitHub gist or other Pastebin is fine.)

kubectl logs -f openebs-lvm-localpv-controller-7b6d6b4665-fk78q -n openebs -c openebs-lvm-plugin
| no error
kubectl logs -f openebs-lvm-localpv-node-[xxxx] -n openebs -c openebs-lvm-plugin

| I0620 02:51:50.488174       1 grpc.go:72] GRPC call: /csi.v1.Node/NodePublishVolume requests {"target_path":"/var/lib/kubelet/pods/77cf54bb-be60-44e4-8ae0-bb3744b2f10e/volumes/kuberne
tes.io~csi/pvc-bcc852f8-7266-48c4-aedc-34adb523d224/mount","volume_capability":{"AccessType":{"Mount":{"fs_type":"ext4"}},"access_mode":{"mode":1}},"volume_context":{"csi.storage.k8s.
io/ephemeral":"false","csi.storage.k8s.io/pod.name":"xxx-mongodb-2","csi.storage.k8s.io/pod.namespace":"ns-gewclvtg","csi.storage.k8s.io/pod.uid":"77cf54bb-be60-44e4-8ae
0-bb3744b2f10e","csi.storage.k8s.io/serviceAccount.name":"xxx","openebs.io/cas-type":"localpv-lvm","openebs.io/volgroup":"lvmvg","storage.kubernetes.io/cs
iProvisionerIdentity":"1718646815547-5148-local.csi.openebs.io"},"volume_id":"pvc-bcc852f8-7266-48c4-aedc-34adb523d224"}
I0620 02:51:50.534603       1 mount_linux.go:312] fsck error fsck from util-linux 2.38.1
/dev/mapper/lvmvg-pvc--bcc852f8--7266--48c4--aedc--34adb523d224 is mounted.
e2fsck: Cannot continue, aborting.

kubectl get pods -n openebs
| health

kubectl get lvmvol -A -o yaml

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
Environment:

LVM Driver version
Kubernetes version (use kubectl version):
Kubernetes installer & version:
Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release):

kubectl logs -n kube-system openebs-lvm-node-d8krs -c openebs-lvm-plugin
I0619 06:35:24.036535       1 volume.go:85] Got add event for Vol pvc-bcc852f8-7266-48c4-aedc-34adb523d224
I0619 06:35:24.036547       1 volume.go:86] lvmvolume object to be enqueued by Add handler: &{{LVMVolume local.openebs.io/v1alpha1} {pvc-bcc852f8-7266-48c4-aedc-34adb523d224  openebs  00e27140-261e-449f-a048-af94b1b312f3 241412558 1 2024-06-19 06:35:24 +0000 UTC <nil> <nil> map[] map[] [] [] [{lvm-driver Update local.openebs.io/v1alpha1 2024-06-19 06:35:24 +0000 UTC FieldsV1 {"f:spec":{".":{},"f:capacity":{},"f:ownerNodeID":{},"f:shared":{},"f:thinProvision":{},"f:vgPattern":{},"f:volGroup":{}},"f:status":{".":{},"f:state":{}}} }]} {test-node-003  ^lvmvg$<PHONE_NUMBER> yes no} {Pending <nil>}}
I0619 06:35:24.036609       1 volume.go:55] Getting lvmvol object name:pvc-bcc852f8-7266-48c4-aedc-34adb523d224, ns:openebs from cache
I0619 06:35:24.396811       1 lvm_util.go:308] lvm: created volume lvmvg/pvc-bcc852f8-7266-48c4-aedc-34adb523d224
I0619 06:35:24.406693       1 volume.go:367] Successfully synced 'openebs/pvc-bcc852f8-7266-48c4-aedc-34adb523d224'
I0619 06:35:26.217611       1 grpc.go:72] GRPC call: /csi.v1.Node/NodePublishVolume requests {"target_path":"/var/lib/kubelet/pods/e128a99f-28ea-4ed2-b098-900b886744bb/volumes/kubernetes.io~csi/pvc-bcc852f8-7266-48c4-aedc-34adb523d224/mount","volume_capability":{"AccessType":{"Mount":{"fs_type":"ext4"}},"access_mode":{"mode":1}},"volume_context":{"csi.storage.k8s.io/ephemeral":"false","csi.storage.k8s.io/pod.name":"test-ytxrw6b0n6-mongodb-2","csi.storage.k8s.io/pod.namespace":"ns-gewclvtg","csi.storage.k8s.io/pod.uid":"e128a99f-28ea-4ed2-b098-900b886744bb","csi.storage.k8s.io/serviceAccount.name":"test-mongodb-test-ytxrw6b0n6","openebs.io/cas-type":"localpv-lvm","openebs.io/volgroup":"lvmvg","storage.kubernetes.io/csiProvisionerIdentity":"1718646815547-5148-local.csi.openebs.io"},"volume_id":"pvc-bcc852f8-7266-48c4-aedc-34adb523d224"}
I0619 06:35:26.240614       1 mount_linux.go:367] Disk "/dev/lvmvg/pvc-bcc852f8-7266-48c4-aedc-34adb523d224" appears to be unformatted, attempting to format as type: "ext4" with options: [-F -m0 /dev/lvmvg/pvc-bcc852f8-7266-48c4-aedc-34adb523d224]
I0619 06:35:26.264351       1 mount_linux.go:377] Disk successfully formatted (mkfs): ext4 - /dev/lvmvg/pvc-bcc852f8-7266-48c4-aedc-34adb523d224 /var/lib/kubelet/pods/e128a99f-28ea-4ed2-b098-900b886744bb/volumes/kubernetes.io~csi/pvc-bcc852f8-7266-48c4-aedc-34adb523d224/mount
I0619 06:35:26.280532       1 mount.go:209] lvm: volume lvmvg/pvc-bcc852f8-7266-48c4-aedc-34adb523d224 mounted /var/lib/kubelet/pods/e128a99f-28ea-4ed2-b098-900b886744bb/volumes/kubernetes.io~csi/pvc-bcc852f8-7266-48c4-aedc-34adb523d224/mount fs ext4

I0620 02:51:50.488174       1 grpc.go:72] GRPC call: /csi.v1.Node/NodePublishVolume requests {"target_path":"/var/lib/kubelet/pods/77cf54bb-be60-44e4-8ae0-bb3744b2f10e/volumes/kubernetes.io~csi/pvc-bcc852f8-7266-48c4-aedc-34adb523d224/mount","volume_capability":{"AccessType":{"Mount":{"fs_type":"ext4"}},"access_mode":{"mode":1}},"volume_context":{"csi.storage.k8s.io/ephemeral":"false","csi.storage.k8s.io/pod.name":"test-ytxrw6b0n6-mongodb-2","csi.storage.k8s.io/pod.namespace":"ns-gewclvtg","csi.storage.k8s.io/pod.uid":"77cf54bb-be60-44e4-8ae0-bb3744b2f10e","csi.storage.k8s.io/serviceAccount.name":"test-mongodb-test-ytxrw6b0n6","openebs.io/cas-type":"localpv-lvm","openebs.io/volgroup":"lvmvg","storage.kubernetes.io/csiProvisionerIdentity":"1718646815547-5148-local.csi.openebs.io"},"volume_id":"pvc-bcc852f8-7266-48c4-aedc-34adb523d224"}
I0620 02:51:50.534603       1 mount_linux.go:312] `fsck` error fsck from util-linux 2.38.1
/dev/mapper/lvmvg-pvc--bcc852f8--7266--48c4--aedc--34adb523d224 is mounted.
e2fsck: Cannot continue, aborting.

I0620 02:51:50.535623       1 mount.go:209] lvm: volume lvmvg/pvc-bcc852f8-7266-48c4-aedc-34adb523d224 mounted /var/lib/kubelet/pods/77cf54bb-be60-44e4-8ae0-bb3744b2f10e/volumes/kubernetes.io~csi/pvc-bcc852f8-7266-48c4-aedc-34adb523d224/mount fs ext4
I0620 02:51:50.535640       1 grpc.go:81] GRPC response: {}
I0620 02:51:57.684960       1 lvmnode.go:306] Successfully synced 'openebs/test-node-003

@bxy4543  Could you share the storage class and pvc yaml files here, or in Github gist?

controller version:
        image: registry.k8s.io/sig-storage/csi-resizer:v1.8.0
        image: registry.k8s.io/sig-storage/csi-snapshotter:v6.2.2
        image: registry.k8s.io/sig-storage/snapshot-controller:v6.2.2
        image: registry.k8s.io/sig-storage/csi-provisioner:v3.5.0
registry.k8s.io/sig-storage/csi-node-driver-registrar:v2.8.0
openebs/lvm-driver:ci

and i found error:
{"log":"I0619 06:35:25.755602       1 event.go:298] Event(v1.ObjectReference{Kind:\"PersistentVolumeClaim\", Namespace:\"ns-gewclvtg\", Name:\"data-test-ytxrw6b0n6-mongodb-2\", UID:\"bcc852f8-7266-48c4-aedc-34adb523d224\", APIVersion:\"v1\", ResourceVersion:\"241412655\", FieldPath:\"\"}): type: 'Warning' reason: 'VolumeResizeFailed' Mark PVC \"ns-gewclvtg/data-test-ytxrw6b0n6-mongodb-2\" as file system resize required failed: can't patch status of  PVC ns-gewclvtg/data-test-ytxrw6b0n6-mongodb-2 with Operation cannot be fulfilled on persistentvolumeclaims \"data-test-ytxrw6b0n6-mongodb-2\": the object has been modified; please apply your changes to the latest version and try again","logtag":"F"} |
-- | --
  |   | {"log":"E0619 06:35:25.755515       1 controller.go:286] Error syncing PVC: Mark PVC \"ns-gewclvtg/data-test-ytxrw6b0n6-mongodb-2\" as file system resize required failed: can't patch status of  PVC ns-gewclvtg/data-test-ytxrw6b0n6-mongodb-2 with Operation cannot be fulfilled on persistentvolumeclaims \"data-test-ytxrw6b0n6-mongodb-2\": the object has been modified; please apply your changes to the latest version and try again","logtag":"F"}

allowVolumeExpansion: true
apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
  name: openebs-backup
parameters:
  shared: "yes"
  storage: lvm
  volgroup: lvmvg
provisioner: local.csi.openebs.io
reclaimPolicy: Delete
volumeBindingMode: WaitForFirstConsumer

apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  annotations:
    pv.kubernetes.io/bind-completed: "yes"
    pv.kubernetes.io/bound-by-controller: "yes"
    volume.beta.kubernetes.io/storage-provisioner: local.csi.openebs.io
    volume.kubernetes.io/selected-node: test-node-003
    volume.kubernetes.io/storage-provisioner: local.csi.openebs.io
  creationTimestamp: "2024-06-19T06:35:23Z"
  finalizers:
  - kubernetes.io/pvc-protection
  labels:
    app.kubernetes.io/instance: test-ytxrw6b0n6
    app.kubernetes.io/managed-by: kubeblocks
    app.kubernetes.io/name: mongodb
    apps.kubeblocks.io/component-name: mongodb
    apps.kubeblocks.io/vct-name: data
    kubeblocks.io/volume-type: data
  name: data-test-ytxrw6b0n6-mongodb-2
  namespace: ns-gewclvtg
  ownerReferences:
  - apiVersion: apps.kubeblocks.io/v1alpha1
    blockOwnerDeletion: true
    controller: true
    kind: Component
    name: test-ytxrw6b0n6-mongodb
    uid: f131a510-755d-4ae2-a828-9d878b82e121
  resourceVersion: "241412684"
  uid: bcc852f8-7266-48c4-aedc-34adb523d224
spec:
  accessModes:
  - ReadWriteOnce
  resources:
    requests:
      storage: 16Gi
  storageClassName: openebs-backup
  volumeMode: Filesystem
  volumeName: pvc-bcc852f8-7266-48c4-aedc-34adb523d224
status:
  accessModes:
  - ReadWriteOnce
  capacity:
    storage: 16Gi
  phase: Bound

The filesystem resize path seems to have run into error while doing fsck and that left it there. I'll check this for some more clues.

Thank you for your support. After the underlying lv is expanded, the file system expansion step is reached. However, it can be seen that the lv of the test-node-003 node has not been successfully expanded.

Thank you for your support. After the underlying lv is expanded, the file system expansion step is reached. However, it can be seen that the lv of the test-node-003 node has not been successfully expanded.

I see that the storage class mentions shared, are there actually two applications currently using the volume when this happened?

And I see fsck comes from mount_linux.formatAndMountSensitive which is referenced in NodePublishVolume.MountFilesystem, but my pod is still able to mount the pvc successfully

I see that the storage class mentions shared, are there actually two applications currently using the volume when this happened?

It was there for a while for backup, but it's gone now

@bxy4543 If possible please upload all log files here as zipped.

log.tar.gz
@dsharma-dc

The openebs-lvm-node-003 log is missing the logs from earlier timestamp for volume pvc-bcc852f8-7266-48c4-aedc-34adb523d224. I would also like to see output of kubectl describe pvc <pvcname>

kubectl describe pvc -n ns-gewclvtg data-test-ytxrw6b0n6-mongodb-2
Name:          data-test-ytxrw6b0n6-mongodb-2
Namespace:     ns-gewclvtg
StorageClass:  openebs-backup
Status:        Bound
Volume:        pvc-bcc852f8-7266-48c4-aedc-34adb523d224
Labels:        app.kubernetes.io/instance=test-ytxrw6b0n6
               app.kubernetes.io/managed-by=kubeblocks
               app.kubernetes.io/name=mongodb
               apps.kubeblocks.io/component-name=mongodb
               apps.kubeblocks.io/vct-name=data
               kubeblocks.io/volume-type=data
Annotations:   pv.kubernetes.io/bind-completed: yes
               pv.kubernetes.io/bound-by-controller: yes
               volume.beta.kubernetes.io/storage-provisioner: local.csi.openebs.io
               volume.kubernetes.io/selected-node: test-node-003
               volume.kubernetes.io/storage-provisioner: local.csi.openebs.io
Finalizers:    [kubernetes.io/pvc-protection]
Capacity:      16Gi
Access Modes:  RWO
VolumeMode:    Filesystem
Used By:       test-ytxrw6b0n6-mongodb-2
Events:        <none>

Two questions:

Can you share the describe of pv, lvmvolume and o/p of lvdisplay /dev/lvmvg/pvc-bcc852f8-7266-48c4-aedc-34adb523d224 again.
Where was this error seen? If you can provide that log:
controller.go:286] Error syncing PVC: Mark PVC \"ns-gewclvtg/data-test-ytxrw6b0n6-mongodb-2\" as file system resize required failed: can't patch status of  PVC

root@test-node-003:~# lvdisplay /dev/lvmvg/pvc-bcc852f8-7266-48c4-aedc-34adb523d224
  --- Logical volume ---
  LV Path                /dev/lvmvg/pvc-bcc852f8-7266-48c4-aedc-34adb523d224
  LV Name                pvc-bcc852f8-7266-48c4-aedc-34adb523d224
  VG Name                lvmvg
  LV UUID                vjfkb2-ls7c-YzO7-nZYf-Ds70-3CVP-7EA5jl
  LV Write Access        read/write
  LV Creation host, time openebs-lvm-node-d8krs, 2024-06-19 14:35:24 +0800
  LV Status              available
  # open                 1
  LV Size                1.00 GiB
  Current LE             256
  Segments               1
  Allocation             inherit
  Read ahead sectors     auto
  - currently set to     256
  Block device           253:151

kubectl describe pv pvc-bcc852f8-7266-48c4-aedc-34adb523d224
Name:              pvc-bcc852f8-7266-48c4-aedc-34adb523d224
Labels:            <none>
Annotations:       pv.kubernetes.io/provisioned-by: local.csi.openebs.io
                 volume.kubernetes.io/provisioner-deletion-secret-name:
                 volume.kubernetes.io/provisioner-deletion-secret-namespace:
Finalizers:        [kubernetes.io/pv-protection]
StorageClass:      openebs-backup
Status:            Bound
Claim:             ns-gewclvtg/data-test-ytxrw6b0n6-mongodb-2
Reclaim Policy:    Delete
Access Modes:      RWO
VolumeMode:        Filesystem
Capacity:          16Gi
Node Affinity:
Required Terms:
  Term 0:        openebs.io/nodename in [test-node-003]
Message:
Source:
  Type:              CSI (a Container Storage Interface (CSI) volume source)
  Driver:            local.csi.openebs.io
  FSType:            ext4
  VolumeHandle:      pvc-bcc852f8-7266-48c4-aedc-34adb523d224
  ReadOnly:          false
  VolumeAttributes:      openebs.io/cas-type=localpv-lvm
                         openebs.io/volgroup=lvmvg
                         storage.kubernetes.io/csiProvisionerIdentity=1718646815547-5148-local.csi.openebs.io
Events:                <none>

kubectl describe lvmvolume -n openebs pvc-bcc852f8-7266-48c4-aedc-34adb523d224
Name:         pvc-bcc852f8-7266-48c4-aedc-34adb523d224
Namespace:    openebs
Labels:       kubernetes.io/nodename=test-node-003
Annotations:  <none>
API Version:  local.openebs.io/v1alpha1
Kind:         LVMVolume
Metadata:
  Creation Timestamp:  2024-06-19T06:35:24Z
  Finalizers:
    lvm.openebs.io/finalizer
  Generation:        4
  Resource Version:  241412658
  UID:               00e27140-261e-449f-a048-af94b1b312f3
Spec:
  Capacity:<PHONE_NUMBER>4
  Owner Node ID:   test-node-003
  Shared:          yes
  Thin Provision:  no
  Vg Pattern:      ^lvmvg$
  Vol Group:       lvmvg
Status:
  State:  Ready
Events:   <none>

And the Error syncing PVC log comes from the controller csi-resizer module. The old log has been cleaned up, but I found a new similar log：
Common labels: {"app":"openebs-lvm-controller","container":"csi-resizer","instance":"openebs-lvm-controller-546768b57c-tlnbf","job":"fluent-bit","namespace":"kube-system","node":"test-node-001","stream":"stderr"}
Line limit: "1000 (45 returned)"
Total bytes processed: "228  kB"

2024-06-20T22:23:55+08:00	{"log":"I0620 14:23:55.005706       1 leaderelection.go:276] successfully renewed lease kube-system/external-resizer-local-csi-openebs-io","logtag":"F"}
2024-06-20T22:23:49+08:00	{"log":"I0620 14:23:49.999362       1 leaderelection.go:276] successfully renewed lease kube-system/external-resizer-local-csi-openebs-io","logtag":"F"}
2024-06-20T22:23:44+08:00	{"log":"I0620 14:23:44.994267       1 leaderelection.go:276] successfully renewed lease kube-system/external-resizer-local-csi-openebs-io","logtag":"F"}
2024-06-20T22:23:39+08:00	{"log":"I0620 14:23:39.989566       1 leaderelection.go:276] successfully renewed lease kube-system/external-resizer-local-csi-openebs-io","logtag":"F"}
2024-06-20T22:23:34+08:00	{"log":"I0620 14:23:34.984822       1 leaderelection.go:276] successfully renewed lease kube-system/external-resizer-local-csi-openebs-io","logtag":"F"}
2024-06-20T22:23:29+08:00	{"log":"I0620 14:23:29.979466       1 leaderelection.go:276] successfully renewed lease kube-system/external-resizer-local-csi-openebs-io","logtag":"F"}
2024-06-20T22:23:24+08:00	{"log":"I0620 14:23:24.975015       1 leaderelection.go:276] successfully renewed lease kube-system/external-resizer-local-csi-openebs-io","logtag":"F"}
2024-06-20T22:23:19+08:00	{"log":"I0620 14:23:19.969413       1 leaderelection.go:276] successfully renewed lease kube-system/external-resizer-local-csi-openebs-io","logtag":"F"}
2024-06-20T22:23:14+08:00	{"log":"I0620 14:23:14.963766       1 leaderelection.go:276] successfully renewed lease kube-system/external-resizer-local-csi-openebs-io","logtag":"F"}
2024-06-20T22:23:09+08:00	{"log":"I0620 14:23:09.957577       1 leaderelection.go:276] successfully renewed lease kube-system/external-resizer-local-csi-openebs-io","logtag":"F"}
2024-06-20T22:23:05+08:00	{"log":"I0620 14:23:05.200975       1 controller.go:343] No need to resize PVC \"ns-3m5m56ni/data-teable-uylicrfk-pg-postgresql-0\"","logtag":"F"}
2024-06-20T22:23:05+08:00	{"log":"I0620 14:23:05.200931       1 controller.go:295] Started PVC processing \"ns-3m5m56ni/data-teable-uylicrfk-pg-postgresql-0\"","logtag":"F"}
2024-06-20T22:23:04+08:00	{"log":"I0620 14:23:04.952653       1 leaderelection.go:276] successfully renewed lease kube-system/external-resizer-local-csi-openebs-io","logtag":"F"}
2024-06-20T22:23:04+08:00	{"log":"I0620 14:23:04.217272       1 event.go:298] Event(v1.ObjectReference{Kind:\"PersistentVolumeClaim\", Namespace:\"ns-3m5m56ni\", Name:\"data-teable-uylicrfk-pg-postgresql-0\", UID:\"b781dc96-49e1-4391-b09f-3da5974f2f52\", APIVersion:\"v1\", ResourceVersion:\"408970568\", FieldPath:\"\"}): type: 'Normal' reason: 'VolumeResizeSuccessful' Resize volume succeeded","logtag":"F"}
2024-06-20T22:23:04+08:00	{"log":"I0620 14:23:04.217271       1 controller.go:343] No need to resize PVC \"ns-3m5m56ni/data-teable-uylicrfk-pg-postgresql-0\"","logtag":"F"}
2024-06-20T22:23:04+08:00	{"log":"I0620 14:23:04.217262       1 controller.go:295] Started PVC processing \"ns-3m5m56ni/data-teable-uylicrfk-pg-postgresql-0\"","logtag":"F"}
2024-06-20T22:23:04+08:00	{"log":"I0620 14:23:04.217231       1 controller.go:546] Resize PVC \"ns-3m5m56ni/data-teable-uylicrfk-pg-postgresql-0\" finished","logtag":"F"}
2024-06-20T22:23:04+08:00	{"log":"I0620 14:23:04.211897       1 controller.go:489] Update capacity of PV \"pvc-b781dc96-49e1-4391-b09f-3da5974f2f52\" to 8Gi succeeded","logtag":"F"}
2024-06-20T22:23:04+08:00	{"log":"I0620 14:23:04.208677       1 controller.go:590] Resize volume succeeded for volume \"pvc-b781dc96-49e1-4391-b09f-3da5974f2f52\", start to update PV's capacity","logtag":"F"}
2024-06-20T22:23:04+08:00	{"log":"I0620 14:23:04.208671       1 controller.go:483] Resize volume succeeded for volume \"pvc-b781dc96-49e1-4391-b09f-3da5974f2f52\", start to update PV's capacity","logtag":"F"}
2024-06-20T22:23:04+08:00	{"log":"I0620 14:23:04.208665       1 connection.go:201] GRPC error: \u003cnil\u003e","logtag":"F"}
2024-06-20T22:23:04+08:00	{"log":"I0620 14:23:04.208658       1 connection.go:200] GRPC response: {\"capacity_bytes\":8589934592}","logtag":"F"}
2024-06-20T22:23:04+08:00	{"log":"I0620 14:23:04.203509       1 connection.go:194] GRPC request: {\"capacity_range\":{\"required_bytes\":8589934592},\"volume_capability\":{\"AccessType\":{\"Mount\":{\"fs_type\":\"ext4\"}},\"access_mode\":{\"mode\":1}},\"volume_id\":\"pvc-b781dc96-49e1-4391-b09f-3da5974f2f52\"}","logtag":"F"}
2024-06-20T22:23:04+08:00	{"log":"I0620 14:23:04.203507       1 connection.go:193] GRPC call: /csi.v1.Controller/ControllerExpandVolume","logtag":"F"}
2024-06-20T22:23:04+08:00	{"log":"I0620 14:23:04.203495       1 connection.go:201] GRPC error: \u003cnil\u003e","logtag":"F"}
2024-06-20T22:23:04+08:00	{"log":"I0620 14:23:04.203488       1 connection.go:200] GRPC response: {\"capabilities\":[{\"Type\":{\"Rpc\":{\"type\":1}}},{\"Type\":{\"Rpc\":{\"type\":9}}},{\"Type\":{\"Rpc\":{\"type\":5}}},{\"Type\":{\"Rpc\":{\"type\":4}}}]}","logtag":"F"}
2024-06-20T22:23:04+08:00	{"log":"I0620 14:23:04.203149       1 event.go:298] Event(v1.ObjectReference{Kind:\"PersistentVolumeClaim\", Namespace:\"ns-3m5m56ni\", Name:\"data-teable-uylicrfk-pg-postgresql-0\", UID:\"b781dc96-49e1-4391-b09f-3da5974f2f52\", APIVersion:\"v1\", ResourceVersion:\"408970568\", FieldPath:\"\"}): type: 'Normal' reason: 'Resizing' External resizer is resizing volume pvc-b781dc96-49e1-4391-b09f-3da5974f2f52","logtag":"F"}
2024-06-20T22:23:04+08:00	{"log":"I0620 14:23:04.203094       1 connection.go:194] GRPC request: {}","logtag":"F"}
2024-06-20T22:23:04+08:00	{"log":"I0620 14:23:04.203087       1 connection.go:193] GRPC call: /csi.v1.Controller/ControllerGetCapabilities","logtag":"F"}
2024-06-20T22:23:04+08:00	{"log":"I0620 14:23:04.200034       1 event.go:298] Event(v1.ObjectReference{Kind:\"PersistentVolumeClaim\", Namespace:\"ns-3m5m56ni\", Name:\"data-teable-uylicrfk-pg-postgresql-0\", UID:\"b781dc96-49e1-4391-b09f-3da5974f2f52\", APIVersion:\"v1\", ResourceVersion:\"408970566\", FieldPath:\"\"}): type: 'Warning' reason: 'VolumeResizeFailed' Mark PVC \"ns-3m5m56ni/data-teable-uylicrfk-pg-postgresql-0\" as file system resize required failed: can't patch status of  PVC ns-3m5m56ni/data-teable-uylicrfk-pg-postgresql-0 with Operation cannot be fulfilled on persistentvolumeclaims \"data-teable-uylicrfk-pg-postgresql-0\": the object has been modified; please apply your changes to the latest version and try again","logtag":"F"}
2024-06-20T22:23:04+08:00	{"log":"I0620 14:23:04.199989       1 controller.go:295] Started PVC processing \"ns-3m5m56ni/data-teable-uylicrfk-pg-postgresql-0\"","logtag":"F"}
2024-06-20T22:23:04+08:00	{"log":"E0620 14:23:04.199959       1 controller.go:286] Error syncing PVC: Mark PVC \"ns-3m5m56ni/data-teable-uylicrfk-pg-postgresql-0\" as file system resize required failed: can't patch status of  PVC ns-3m5m56ni/data-teable-uylicrfk-pg-postgresql-0 with Operation cannot be fulfilled on persistentvolumeclaims \"data-teable-uylicrfk-pg-postgresql-0\": the object has been modified; please apply your changes to the latest version and try again","logtag":"F"}
2024-06-20T22:23:04+08:00	{"log":"I0620 14:23:04.197199       1 controller.go:489] Update capacity of PV \"pvc-b781dc96-49e1-4391-b09f-3da5974f2f52\" to 8Gi succeeded","logtag":"F"}
2024-06-20T22:23:04+08:00	{"log":"I0620 14:23:04.192885       1 controller.go:590] Resize volume succeeded for volume \"pvc-b781dc96-49e1-4391-b09f-3da5974f2f52\", start to update PV's capacity","logtag":"F"}
2024-06-20T22:23:04+08:00	{"log":"I0620 14:23:04.192878       1 controller.go:483] Resize volume succeeded for volume \"pvc-b781dc96-49e1-4391-b09f-3da5974f2f52\", start to update PV's capacity","logtag":"F"}
2024-06-20T22:23:04+08:00	{"log":"I0620 14:23:04.192871       1 connection.go:201] GRPC error: \u003cnil\u003e","logtag":"F"}
2024-06-20T22:23:04+08:00	{"log":"I0620 14:23:04.192861       1 connection.go:200] GRPC response: {\"capacity_bytes\":8589934592,\"node_expansion_required\":true}","logtag":"F"}
2024-06-20T22:23:04+08:00	{"log":"I0620 14:23:04.178124       1 connection.go:194] GRPC request: {\"capacity_range\":{\"required_bytes\":8589934592},\"volume_capability\":{\"AccessType\":{\"Mount\":{\"fs_type\":\"ext4\"}},\"access_mode\":{\"mode\":1}},\"volume_id\":\"pvc-b781dc96-49e1-4391-b09f-3da5974f2f52\"}","logtag":"F"}
2024-06-20T22:23:04+08:00	{"log":"I0620 14:23:04.178121       1 connection.go:193] GRPC call: /csi.v1.Controller/ControllerExpandVolume","logtag":"F"}
2024-06-20T22:23:04+08:00	{"log":"I0620 14:23:04.178106       1 connection.go:201] GRPC error: \u003cnil\u003e","logtag":"F"}
2024-06-20T22:23:04+08:00	{"log":"I0620 14:23:04.178098       1 connection.go:200] GRPC response: {\"capabilities\":[{\"Type\":{\"Rpc\":{\"type\":1}}},{\"Type\":{\"Rpc\":{\"type\":9}}},{\"Type\":{\"Rpc\":{\"type\":5}}},{\"Type\":{\"Rpc\":{\"type\":4}}}]}","logtag":"F"}
2024-06-20T22:23:04+08:00	{"log":"I0620 14:23:04.177597       1 event.go:298] Event(v1.ObjectReference{Kind:\"PersistentVolumeClaim\", Namespace:\"ns-3m5m56ni\", Name:\"data-teable-uylicrfk-pg-postgresql-0\", UID:\"b781dc96-49e1-4391-b09f-3da5974f2f52\", APIVersion:\"v1\", ResourceVersion:\"408970566\", FieldPath:\"\"}): type: 'Normal' reason: 'Resizing' External resizer is resizing volume pvc-b781dc96-49e1-4391-b09f-3da5974f2f52","logtag":"F"}
2024-06-20T22:23:04+08:00	{"log":"I0620 14:23:04.177454       1 connection.go:194] GRPC request: {}","logtag":"F"}
2024-06-20T22:23:04+08:00	{"log":"I0620 14:23:04.177445       1 connection.go:193] GRPC call: /csi.v1.Controller/ControllerGetCapabilities","logtag":"F"}
2024-06-20T22:23:04+08:00	{"log":"I0620 14:23:04.165365       1 controller.go:295] Started PVC processing \"ns-3m5m56ni/data-teable-uylicrfk-pg-postgresql-0\"","logtag":"F"}

same problem：
root@test-node-004:~# kubectl describe pvc -n ns-3m5m56ni data-teable-uylicrfk-pg-postgresql-0
Name:          data-teable-uylicrfk-pg-postgresql-0
Namespace:     ns-3m5m56ni
StorageClass:  openebs-lvmpv
Status:        Bound
Volume:        pvc-b781dc96-49e1-4391-b09f-3da5974f2f52
Labels:        app.kubernetes.io/instance=teable-uylicrfk-pg
               app.kubernetes.io/managed-by=kubeblocks
               app.kubernetes.io/name=postgresql
               apps.kubeblocks.io/component-name=postgresql
               apps.kubeblocks.io/vct-name=data
               kubeblocks.io/volume-type=data
Annotations:   pv.kubernetes.io/bind-completed: yes
               pv.kubernetes.io/bound-by-controller: yes
               volume.beta.kubernetes.io/storage-provisioner: local.csi.openebs.io
               volume.kubernetes.io/selected-node: test-node-004
               volume.kubernetes.io/storage-provisioner: local.csi.openebs.io
Finalizers:    [kubernetes.io/pvc-protection]
Capacity:      8Gi
Access Modes:  RWO
VolumeMode:    Filesystem
Used By:       teable-uylicrfk-pg-postgresql-0
Events:        <none>
root@test-node-004:~#
root@test-node-004:~# kubectl describe lvmvolume -n openebs pvc-bcf9096f-b5d7-4a2d-8425-0b3ea2fce0a3
Name:         pvc-bcf9096f-b5d7-4a2d-8425-0b3ea2fce0a3
Namespace:    openebs
Labels:       kubernetes.io/nodename=test-node-004
Annotations:  <none>
API Version:  local.openebs.io/v1alpha1
Kind:         LVMVolume
Metadata:
  Creation Timestamp:  2024-06-18T06:38:28Z
  Finalizers:
    lvm.openebs.io/finalizer
  Generation:        3
  Resource Version:  398423326
  UID:               1540acdc-5c42-449a-82f7-dcc7831024e9
Spec:
  Capacity:<PHONE_NUMBER>
  Owner Node ID:   test-node-004
  Shared:          yes
  Thin Provision:  no
  Vg Pattern:      ^lvmvg$
  Vol Group:       lvmvg
Status:
  State:  Ready
Events:   <none>
root@test-node-004:~# lvdisplay /dev/lvmvg/pvc-bcf9096f-b5d7-4a2d-8425-0b3ea2fce0a3
  --- Logical volume ---
  LV Path                /dev/lvmvg/pvc-bcf9096f-b5d7-4a2d-8425-0b3ea2fce0a3
  LV Name                pvc-bcf9096f-b5d7-4a2d-8425-0b3ea2fce0a3
  VG Name                lvmvg
  LV UUID                MhTTYf-XHAw-RhGc-WXfF-Uyeu-rNMS-KmMqd6
  LV Write Access        read/write
  LV Creation host, time openebs-lvm-node-c66l4, 2024-06-18 14:38:29 +0800
  LV Status              available
  # open                 1
  LV Size                1.00 GiB
  Current LE             256
  Segments               1
  Allocation             inherit
  Read ahead sectors     auto
  - currently set to     8192
  Block device           253:352

There are few things that are observed here:

The LVM LV didn't get expanded because the csi node plugin didn't receive NodeExpandVolume call. The LV is expanded is expanded as part of this gRPC and filesystem is natively expanded by LVM(except btrfs which we do from the plugin). I'm assuming the application pod was running and attached to the pvc here.
The NodeExpandVolume call was not sent to csi-node plugin because csi-resizer failed to mark the pvc with node expansion required as seen from the error logs from csi-resizer.
Why csi-resizer failed to patch pvc status correctly is not clear.

It would be good if you can share the version of all the things involved i.e. kubernetes, openebs plugin, host OS details etc.
Also if it is reproducible easily every time, then request to repro and provide the csi-controller logs (openebs-lvm-plugin + csi-resizer containers), and csi-node logs(openebs-lvm-plugin  container) from that timestamp.
NOTE: In the last comment, the pvc and lvmvolume look unrelated, they are having different IDs.

Thanks, I'll share it later

It would also be interesting to know how the edits are being made to the PVC. Also, whether a retry worked successfully or not. The error doesn't indicate any issue with this provisioner till now. The failure happened in kubernetes API calls during resize due to PVC edit conflicting with some other conflicting operation on PVC.

Yes, but I wonder why the csi controller failed and the retry succeeded, but the LVMVolume was inconsistent with the physical LV

How to avoid this situation?  why does patching the error pvc not re-trigger grpc

How to avoid this situation? why does patching the error pvc not re-trigger grpc

I'd guess kubernetes expects us to retry manually as the message says please apply your changes to the latest version and try again. We can check with k8s folks w.r.t this behaviour.

please apply your changes to the latest version and try again does not mean that we need to create it manually. This is entirely due to the inconsistency of pvc resources. I can trigger it 100% and just need to keep adding pvc labels:
cat rechange-pvc.sh
#!/bin/bash

NAMESPACE="ns-hwhbg4vf"
PVC_NAME="data-dfsd-mongodb-0"
LABEL_KEY="test"

while true; do
  CURRENT_VALUE=$(kubectl get pvc $PVC_NAME -n $NAMESPACE -o jsonpath="{.metadata.labels.$LABEL_KEY}")

  if [[ -z "$CURRENT_VALUE" ]]; then
    NEXT_VALUE=1
  elif [[ "$CURRENT_VALUE" =~ ^[0-9]+$ ]]; then
    NEXT_VALUE=$((CURRENT_VALUE + 1))
  else
    echo "tag $LABEL_KEY Current value is not an integer: $CURRENT_VALUE"
    exit 1
  fi

  echo "Update Tags $LABEL_KEY 到 $NEXT_VALUE"
  kubectl label pvc $PVC_NAME -n $NAMESPACE $LABEL_KEY=$NEXT_VALUE --overwrite

  sleep 0.5
done

lvdisplay /dev/mapper/lvmvg-pvc--c745ae87--6b56--4684--9cfb--9e21ca9517e5
  --- Logical volume ---
  LV Path                /dev/lvmvg/pvc-c745ae87-6b56-4684-9cfb-9e21ca9517e5
  LV Name                pvc-c745ae87-6b56-4684-9cfb-9e21ca9517e5
  VG Name                lvmvg
  LV UUID                40ZI9j-4f2C-M1AW-CVrs-ZcSk-wR53-NwMUCF
  LV Write Access        read/write
  LV Creation host, time openebs-lvm-node-nddtz, 2024-06-27 02:49:15 +0000
  LV Status              available
  # open                 1
  LV Size                3.00 GiB
  Current LE             768
  Segments               1
  Allocation             inherit
  Read ahead sectors     auto
  - currently set to     256
  Block device           253:13

root@dev-56:~# kubectl get pvc -n ns-hwhbg4vf data-dfsd-mongodb-0 -o yaml
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  annotations:
    pv.kubernetes.io/bind-completed: "yes"
    pv.kubernetes.io/bound-by-controller: "yes"
    volume.beta.kubernetes.io/storage-provisioner: local.csi.openebs.io
    volume.kubernetes.io/selected-node: dev-56
    volume.kubernetes.io/storage-provisioner: local.csi.openebs.io
  creationTimestamp: "2024-06-27T10:10:31Z"
  finalizers:
  - kubernetes.io/pvc-protection
  labels:
    app.kubernetes.io/instance: dfsd
    app.kubernetes.io/managed-by: kubeblocks
    app.kubernetes.io/name: mongodb
    apps.kubeblocks.io/component-name: mongodb
    apps.kubeblocks.io/vct-name: data
    kubeblocks.io/volume-type: data
    test: "98"
  name: data-dfsd-mongodb-0
  namespace: ns-hwhbg4vf
  ownerReferences:
  - apiVersion: apps.kubeblocks.io/v1alpha1
    blockOwnerDeletion: true
    controller: true
    kind: Component
    name: dfsd-mongodb
    uid: 4cc9d636-2084-4f81-871b-0ee30567fa52
  resourceVersion: "99144306"
  uid: ce0a06d8-53e5-46a9-b529-a79f0fa101b5
spec:
  accessModes:
  - ReadWriteOnce
  resources:
    requests:
      storage: 4Gi
  storageClassName: openebs-lvmpv
  volumeMode: Filesystem
  volumeName: pvc-c745ae87-6b56-4684-9cfb-9e21ca9517e5
status:
  accessModes:
  - ReadWriteOnce
  capacity:
    storage: 4Gi
  phase: Bound

pvc-c745ae87-6b56-4684-9cfb-9e21ca9517e5:  4Gi
Physical size: 3Gi

I think ControllerExpandVolume needs to add a state to modify the LVMVolume resource. Otherwise, it is not advisable to just modify LVMVolume.spec.capacity to represent the success of ControllerExpandVolume execution. Otherwise, even if NodeExpandVolume execution fails, ControllerExpandVolume will not retry

The one key difference here in this LVM provisioner from other e.g openebs/Mayastor is that ControllerExpandVolume actually expands the volume there but not in case of LVM. This is because with LVM we can't split the volume expand operation into two step - 1. to exapnd underlying volume , 2. expand the filesystem.
LVM natively expands filesystem too.
That said, I see there could be some scope of improvement for LVM expansion workflow. Also investigate the ControllerExpandVolume return path as suggested above. Will keep it under track.
I haven't been able to reproduce the error yet using the script provided by you though.

created pvc
published application
ran label add script
do kubectl pvc edit to resize

Got it, looking forward to improving this problem. I can always reproduce it in my environment:
uname -a
Linux dev-55 5.15.0-113-generic #123-Ubuntu SMP Mon Jun 10 08:16:17 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
cat /etc/os-release
PRETTY_NAME="Ubuntu 22.04.3 LTS"
NAME="Ubuntu"
VERSION_ID="22.04"
VERSION="22.04.3 LTS (Jammy Jellyfish)"
VERSION_CODENAME=jammy
ID=ubuntu
ID_LIKE=debian
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
UBUNTU_CODENAME=jammy
kubectl get no -owide
NAME               STATUS   ROLES           AGE    VERSION    INTERNAL-IP    EXTERNAL-IP   OS-IMAGE             KERNEL-VERSION       CONTAINER-RUNTIME
dev-55             Ready    control-plane   152d   v1.27.13   <IP_ADDRESS>   <none>        Ubuntu 22.04.3 LTS   5.15.0-113-generic   containerd://1.6.23
dev-56             Ready    <none>          152d   v1.27.13   <IP_ADDRESS>   <none>        Ubuntu 22.04.3 LTS   5.15.0-113-generic   containerd://1.6.23
dev-58             Ready    <none>          152d   v1.27.13   <IP_ADDRESS>   <none>        Ubuntu 22.04.3 LTS   5.15.0-113-generic   containerd://1.6.23

use version:
registry.k8s.io/sig-storage/csi-resizer:v1.8.0
registry.k8s.io/sig-storage/csi-snapshotter:v6.2.2
registry.k8s.io/sig-storage/snapshot-controller:v6.2.2
registry.k8s.io/sig-storage/csi-provisioner:v3.5.0
registry.k8s.io/sig-storage/csi-node-driver-registrar:v2.8.0
openebs/lvm-driver:ci

@datacore-tilangovan can you help in reproducing this issue in your setup where you benchmarking for postgresql?

Does this PR https://github.com/openebs/lvm-localpv/pull/260 help to address this issue?


Prepare OdinStarter for template

It would be handy to keep a copy of OdinStarter in the processors project if it doesn't clutter things up too much.  If these files are only included in the starter template repo, they are obscured with one level of templating redirection.  All the resource files have to be escaped properly and there is not a good way to track changes required by updates to processors.  If the file is here, then I can note when it needs to change and propagate the changes to the template.
Liberties with the original file and they can definitely be undone.

It seems like a good idea to follow GitHub's lead and change from master to main.
As was noted in a comment, the parallel sequences of kbs and the case information was not obvious.  I changed the data structure to force pairs and hope it is easier to understand, but it may not be.
It didn't seem like the defs were necessary, so they were changed to vals.
The printing of the mentions was made a little prettier so that the output can be more easily interpreted.

For people new to Scala, it might be useful to show a Scala 3 version with the Python formatting.

I agree with all these points. Thanks @kwalcock !

The first test run failed at it should "collapse prepositions with verb objects" in org.clulab.processors.TestEnhancedSemanticRoles, even though nothing added here would have affected a test.  The second run passed without any changes having been made.  This may be the case of an "unreliable" test and is being filed as an issue.

The OdinStarter code here was added to the sbt-processors-small.g8 repo and used as a template for projects on Windows, Linux, and Mac computers which ran all the tests and sample programs on Scala 2.11, 2.12, 2.13, and 3.1 (excepting the one using the discontinued args).  On Linux it worked with Java 1.8 and 11 and on Mac it worked with Java 1.8 Intel, 1.8 M1, and 18 Intel.  Not that it has never crashed before...


Edit Style of Table Component

🗒 General

It would be amazing if someone could update the sortable table component  styles!
💻 Usage

The sortable table is a robust way to view a lot of categorized information at once. By giving users the power to modify their views of the inputs, they can comprehend the data in a much easier way.
Default state

Hover

Active

📐 Specs

Rules

Text input columns are always left aligned for easier read. The sort arrow icon will go to the right of the column header.  Caveat: this can be adjusted for different languages.
Numerical input columns are always right aligned for easier read. The sort arrow icon will go to the left of the column header.

Example

🔮 Future

Status
Additional types of input

I wonder if we should hold off on these changes in the existing SortableTable since we want to replace that one with a more feature-rich default table/grid component https://github.com/spotify/backstage/issues/161 -- @hooloovooo is looking into that issue.

@stefanalund ,I like to work on this issue !

@tharun208 thanks a lot for offering, but the plan is that this stylistic change will be included in this work https://github.com/spotify/backstage/pull/600
I think there will be additional issues created for improving that one as it lands. @hooloovooo can you please makes sure to ping @tharun208 on any such issue? Thanks


The fullTagEmptyElement options is not working

making the fullTagEmptyElement in the options either true or false does not matter the tag always come abbreviated.

@abdoolly Sorry for late reply.
Can you provide a brief example so I can reproduce the issue and fix it.

Closing this issue as no further feedback received. Will reopen if the issue still persists.


Summernote duplicating fields on edit form

Hello,
The summernote fields on my edit form aren't loading right. When I load the edit form (editing an existing object in the database), it populates all of the fields on the page with the actual database value from the first field. In my app, I have various fields...the first one is called description. The summernote fields are all populated with the value of the description field.
I verified that the database still holds the correct values of the fields. In fact, when I view the page source of the loaded edit form, the html shows that the values are all being properly loaded. The javascript seems to be overwriting them. It must be an issue with my meds.coffee script. Can you please help me fix this issue? How do I properly load multiple fields in the coffee script file?
My repo is here:
https://github.com/jtansley/explainmymedicine/
Thanks!
EDIT:
To clarify, I'm experiencing the issue on this edit form:
https://github.com/jtansley/explainmymedicine/blob/master/app/views/meds/edit.html.erb/

I have just cloned your repo and replaced the whole meds.coffee file as follows:
$ ->
  $('[data-provider="summernote"]').each ->
    $(this).summernote()

It also worked properly on editing an presisted record and so I could see the multiple text fields held each corresponding attribute value correctly.
Good luck!

In meds.coffee file of your repo, you called summernote editor twice for individual fields.
First call is as follows:
$ ->
  $('[data-provider="summernote"]').each ->
    $(this).summernote()

Second calls are:
$ ->
  # to call summernote editor
  summer_note.summernote
  summer_note2.summernote
  summer_note3.summernote
  summer_note4.summernote
  summer_note5.summernote
  summer_note6.summernote
  summer_note7.summernote
    # to set options
    height:300
    codemirror:
      lineNumbers: true
      tabSize: 2
      theme: "solarized light"

Therefore, you must remove code lines for second calls.
If you want to add some options to a certain summernote editor, you must not add as: :summernote option for corresponding field input in form view file and call summernote editor for it additionally in meds.coffee.
So, you may modify the form view file(edit.html.erb) as follows:

<fieldset>

Edit Medicine

  <%# if user_signed_in? && current_user.is_admin == true %>
  <%= simple_form_for @med, class: "form-horizontal" do |f| %>

    <%= f.input :brand_name, required: true %>

    <%= f.input :generic_name, required: true %>

    <%= f.input :description, as: :summernote, :id => 'description' %>

    <%= f.input :reactions, as: :summernote, :id => 'reactions' %>

    <%= f.input :interactions, as: :summernote, :id => 'interactions' %>

    <%= f.input :implementation, as: :summernote, :id => 'implementation' %>

    <%= f.input :availability, as: :summernote, :id => 'availability' %>

    <%= f.input :caution, as: :summernote, :id => 'caution' %>

    <%= f.input :warnings, :id => 'warnings' %>

    <%= f.button :submit, class: "btn btn-primary" %>

  <% end %>
  <%# end %>
</fieldset>

(In the above, you could find the absence of as: :summernote option for f.input :warnings, :id => 'warnings')
and also meds.coffee file as follows:
$ ->
  $('[data-provider="summernote"]').each ->
    $(this).summernote
      height:50

  summer_note7 = $('#med_warnings')
  summer_note7.summernote
    # to set options
    height:300
    codemirror:
      lineNumbers: true
      tabSize: 2
      theme: "solarized light"

(In the above, you could find the additional code line height:50.)
I wish it helps you. Good luck~

@luciuschoi +1:

@luciuschoi +1

@luciuschoi :+1:

Thank you so much for the thorough explanation! This worked perfectly!! I learned a great deal here.


How use %c in format string on redisCommand?

If i use %c in format string then command return NULL reply.
Example command (SET Test:1 a):
reply = redisCommand(conn,"SET Test:1 %s", "a");  // this work (Command OK)
reply = redisCommand(conn,"SET Test:1 a"); // this work (Command OK)
reply = redisCommand(conn,"SET Test:1 %c", 'a'); // this d'nt work (reply == NULL)
reply = redisCommand(conn,"SET T%cst:1 a", 'e'); // this d'nt work (reply == NULL)
This problem also exists in redisAppendCommand, redisvAppendCommand and etc

I found another problem (* - d'nt work with format string)
reply = redisCommand(conn,"SET Test:1 %*s", 2, "qwerty"); //this d'nt work (reply == NULL)

Hi, thanks for the report.
I'm honestly not sure if we want/need to add the * style format specifiers as Hiredis doesn't aim to replicate full printf functionally, but just a small subset that is typically useful for communicating with Redis.

Well, I needed to insert only part of the string (up to a certain character). Without this functionality, you will need to compose a new string


Ngpolymer and paper-card

I'm trying to using ng polymer with paper card elements. Could someone help me with that? Actually I'm using ng-repeat for paper-card but only the heading attributes works when I use {{}}  from angular I would like to use {{ }} in the inner tags card-content and card-actions but don't seems to work. Thanks

Trying to be more clear:

{{playlist.content}}

{{playlist.action}}

Its happen with most of the components. To overcome I have used no paper elements.But there is an issue here with ng-repeat

Are you getting the content duplicated like here If that's the case I think that's a issue from Polymer and not from ng-polymer-elements. You can follow an open issue at Some elements duplicate markup at template  when in an Angular ng-repeat

Yes, I'm getting the content duplicated. Thank you guys. I will take a look.

https://github.com/Polymer/polymer/blob/master/src/lib/experimental/patch-dom.html
Reference this in your html. It worked for me


Add Pkg.clone() to .travis.yml to clone all REQUIREd packages first

Closed; the Travis script does this automatically, so that wasn't the problem.

Pull Request Test Coverage Report for Build 109

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 57.485%

Totals

Change from base Build 102:
0.0%

Covered Lines:
96

Relevant Lines:
167

💛  - Coveralls


[4.1][FIX] Add get() to relationship select

REFS: #2780

A new inspection was created.

The inspection completed: No new issues


[New Feature]: Generate QR code from String

Feature Request

Create new screen which accept string as input and one button by clicking on that button new QR will be generated.

Maintain app theme Style, text style and after creation of screen add one menu mark presence in side drawer menu items list. That menu needs to open screen which you created.

Point down the features

Note : This is not an actual feature of our application but kind of  prototype that help us to evolve more in future. 🏗

Select program in which you are contributing
hacktoberfest
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Greetings @om1512🎀 ! , We are excited to have you dive into another issue with us!🚀
Your involvement in our project has been invaluable, and we're confident that your skills and insights will help us conquer this challenge😇. This issue represents an exciting opportunity for us to improve and enhance our project, and we are thrilled to have you on board.
We request you to follow CONTRIBUTING GUIDELINES.
Looking for your PR soon!
In case of any issues, you can contact us on Discord.❣

Hello @om1512,
Can i solve this issue..

Hey @om1512 ! I wanted to inform you that we have closed issue.Thank you for your understanding, and we look forward to your continued engagement with our repository🤗.
In case of any issues, you can contact us on Discord.
Thank you! ❣
Happy Coding! ✨
Will See you soon❣


Adding noise on Nvidia only darkens the window background and creates dotted diagonal lines

Hyprland Version
Hyprland, built from branch main at commit 751d2851cc270c3322ffe2eb83c156e4298a0c0e dirty (props: bump ver to 0.32.0).
Bug or Regression?
Bug
Description
noise = 0.0

noise = 1.0

How to reproduce
On an Nvidia GPU, set noise to a value higher than 0 and see the darkness increase as you increase the value. No noise is being generated. The dotted lines also become more visible.
Crash reports, logs, images, videos
No response

My card is a 1660ti. Applies on nvidia-dkmsfor both 535 and 545.

Another user reproduced the issue on a 3090

This is his result for a pacman -Qs nvidia:
local/cuda 12.3.0-1
    NVIDIA's GPU programming toolkit
local/egl-wayland 2:1.1.13-1
    EGLStream-based Wayland external platform
local/ffnvcodec-headers <IP_ADDRESS>-1
    FFmpeg version of headers required to interface with Nvidias codec APIs
local/lib32-nvidia-utils 535.113.01-1
    NVIDIA drivers utilities (32-bit)
local/libva-nvidia-driver-git 0.0.11.r1.gea6d862-1
    VA-API implementation that uses NVDEC as a backend (git version)
local/libvdpau 1.5-2
    Nvidia VDPAU library
local/libxnvctrl 545.29.02-1
    NVIDIA NV-CONTROL X extension
local/nvidia-open-dkms 535.113.01-8
    NVIDIA open kernel modules
local/nvidia-utils 535.113.01-2
    NVIDIA drivers utilities
local/opencl-nvidia 535.104.05-1
    OpenCL implemention for NVIDIA

This is mine:
local/egl-wayland 2:1.1.13-1
    EGLStream-based Wayland external platform
local/ffnvcodec-headers <IP_ADDRESS>-1
    FFmpeg version of headers required to interface with Nvidias codec APIs
local/hyprland-nvidia-git 0.32.0.r5.g8dd02eb5-1
    A dynamic tiling Wayland compositor based on wlroots that doesn't sacrifice on its looks. (NVIDIA patch)
local/lib32-libvdpau 1.5-2
    Nvidia VDPAU library
local/lib32-nvidia-utils 535.113.01-1
    NVIDIA drivers utilities (32-bit)
local/libva-nvidia-driver-git 0.0.11.r1.gea6d862-1
    VA-API implementation that uses NVDEC as a backend (git version)
local/libvdpau 1.5-2
    Nvidia VDPAU library
local/libxnvctrl 535.113.01-1
    NVIDIA NV-CONTROL X extension
local/nvidia-dkms 535.113.01-2
    NVIDIA drivers - module sources
local/nvidia-settings 535.113.01-1
    Tool for configuring the NVIDIA graphics driver
local/nvidia-utils 535.113.01-2
    NVIDIA drivers utilities
local/nvtop 3.0.2-1
    GPUs process monitoring for AMD, Intel and NVIDIA

The issue also occurs on a default Hyprland config on a separate profile.

Other users encounter the same issue. This is with an Nvidia GPU, where there is no noise but the dotted lines are visible:

This is the same user running on an iGPU, where the noise works:

The lines might be there too, but they could be harder to see if it's the case.

 Why should I be the one responsible for nvidia's shader compiler having a tantrum?
Feel free to experiment with the noise generator for yourself:
https://github.com/hyprwm/Hyprland/blob/b8a615ffb892aaa35a15dc732208bb7ad2a60209/src/render/shaders/Textures.hpp#L386-L413
Closing. If you find a fix, feel free to MR, but I won't be the one hunting for it.

Have a fix working for the lines on my machine (RTX 4090). Would appreciate a test on different hardware to confirm
0001.patch

feel free to make a MR, but will need some further testing for sure.


Cyberpunk2077 replay failed with unsupported VK_DESCRIPTOR_TYPE_MUTABLE_VALVE usage

Description
I've captured Cyberpunk2077 trace on Linux Ubuntu 20.04
The capture cannot be replayed with error:
$ ~/linbin/renderdoc_master/build/bin/renderdoccmd replay /tmp/RenderDoc/gfxrecon-replay_2022.09.14_10.59_frame66.rdc
Replaying '/tmp/RenderDoc/gfxrecon-replay_2022.09.14_10.59_frame66.rdc' locally..
Couldn't load and replay '/tmp/RenderDoc/gfxrecon-replay_2022.09.14_10.59_frame66.rdc': Replaying the capture failed at the API level:

I've debugged the issue and found that it fails on the next line:
RDCERR("Unexpected descriptor type %d", writes[bind].descriptorType);
renderdoc/driver/vulkan/vk_initstate.cpp
The writes[bind].descriptorType shows VK_DESCRIPTOR_TYPE_MUTABLE_VALVE descriptor type which is unsupported by renderdoc
Steps to reproduce
Download capture: https://drive.google.com/drive/folders/1QdrAt8Ks-LPnDOGxq6GLOsEuY1jVm0we
Try to replay it
See the error
Environment

RenderDoc version: v1.x - 8f14374b5
Operating System: Ubuntu 20.04.5 LTS
Graphics API: Vulkan
Mesa main branch with 6c0215eb09e commit
Intel® Core™ i5-10300H CPU @ 2.50GHz × 8
Mesa Intel® UHD Graphics (CML GT2)

Note: GFXReconstruct capture and replaying works fine with this MR: https://github.com/LunarG/gfxreconstruct/pull/803

RenderDoc is only intended for capturing your own programs. Capturing copyrighted programs that you do not have the rights to is not endorsed and I will provide absolutely no support for it.


✨ Feature Suggestion | Green hosting

Description
https://forum.privacytools.io/t/green-hosting-and-privacytools/4688/3

We do not have any interest of recommending environmentalist solutions, unless they are also privacy respecting.

In that sense actually greenhost.net does both!

I had a look at their Privacy Policy https://greenhost.net/legal/privacy-policy/
I liked that it was fairly clear. They also seem fairly active within Privacy activism https://greenhost.net/privacy/

Green hosting is only viable in Europe and the USA.
There are many areas in the world where forests are cut down and wetlands are destroyed to build solar power plants. It's a reversal of ends and means.
Encouraging green hosting means imposing European values on the rest of the world. It is imperialism.

Green hosting is only viable in Europe and the USA.

How do you mean? User's of other continent can't use the service?

There are many areas in the world where forests are cut down and wetlands are destroyed to build solar power plants. It's a reversal of ends and means.

Irrelevant to the privacy cause.

Encouraging green hosting means imposing European values on the rest of the world. It is imperialism.

Begging your pardon, but that's the stupidest excuse I've ever seen against imperialism. Nobody is screaming Americanism or Capitalism when the service is from US, so why why is there a problem if the service is from Europe? You're not forced to use their service. No one is imposing anything.

@Dyrimon Even though I don't completely agree with the other comment, because whatever, it is not like it makes a significant change against imperialism to use this or not.
But GreenHosting being based in Europe means it is imposing something. It is not coincidence you will see Europe first to enter the market of green energy, because they have been and still are living in the back of Latin American, African and Asian people. Imposing something does not always mean using force, why do you think English language or anglocentric culture is so ubiquitous nowadays? Because we all agree is the best language to use? Because theirs is the most interesting culture? Because they are imposing imperialism through market dominance, this is exactly how Google works, for example.
We are, at least, not entirely interested in finding the best provider when it comes to combat imperialism but which is the most private, plus, if we can find a provider that is green friendly. They fulfill two of those goals, and we will probably not see any provider giving the same services in any third world country any time soon and even if we do I don't see a reason to not list both of them, since you are not going to solve capitalism by buying the right product anyway.
I will not continue this conversation since I don't want to derail the importance of the topic, which is: is GreenHosting private?


upgrade test

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A
What is the new behavior?

Other information

Codecov Report
Patch coverage has no change and project coverage change: -0.36% :warning:

Comparison is base (d88af67) 66.57% compared to head (366bf4a) 66.21%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #822      +/-   ##
==========================================
- Coverage   66.57%   66.21%   -0.36%
==========================================
  Files         238      235       -3
  Lines       23251    23111     -140
==========================================
- Hits        15479    15303     -176
- Misses       6970     6996      +26
- Partials      802      812      +10

Flag
Coverage Δ

53.60% <ø> (-0.32%)
:arrow_down:

go-1.17.x
39.68% <ø> (-26.68%)
:arrow_down:

go-1.20.x
66.14% <ø> (-0.19%)
:arrow_down:

go-1.21.x
66.22% <ø> (-0.02%)
:arrow_down:

integration
53.60% <ø> (-0.32%)
:arrow_down:

macOS
39.80% <ø> (-0.02%)
:arrow_down:

ubuntu
39.78% <ø> (-0.03%)
:arrow_down:

unit
39.86% <ø> (-0.02%)
:arrow_down:

windows
39.75% <ø> (-0.06%)
:arrow_down:

ydb-22.5
53.50% <ø> (-0.13%)
:arrow_down:

ydb-23.1
53.34% <ø> (-0.46%)
:arrow_down:

ydb-23.2
53.34% <ø> (-0.32%)
:arrow_down:

ydb-23.2-slim
53.36% <ø> (-0.15%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.
see 18 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Library is not acceptable with API < 21(

In this moment I do not have any time to maintaince this library. You can edit lib as you desire :) Have a nice day...

Hello dear, I have updated the lib if you still interested.


Feature/error pages

This PR is related to the #61 . It handles any runtime errors and non-existent pages.

Hi! it seems like build is failed. Can you run build in local too and check it ?

There were typos. I fixed.

I added some comment on vercel can you fix these? @hsglc

I added some comment on vercel can you fix these? @hsglc

I fixed them.

I resolved comments on vercel I think you missed one @hsglc

this pr -> https://gurubu-k0psdm21m-trendyol-gurubu-team.vercel.app/create/room
production -> https://gurubu.vercel.app/create/room
You can compare the changes above.
Due to changing variables it affects all of the pages you should change all of the pages variable names or just add the new ones without changing current variables. This can break all the UI. My suggestion is only add new ones and do not change current variables or just do not use variable if it not exists it is up to you

this pr -> https://gurubu-k0psdm21m-trendyol-gurubu-team.vercel.app/create/room production -> https://gurubu.vercel.app/create/room
You can compare the changes above i think there is a problem with line-height too.
Due to changing variables it affects all of the pages you should change all of the pages variable names or just add the new ones without changing current variables. This can break all the UI. My suggestion is only add new ones and do not change current variables or just do not use variable if it not exists it is up to you.

yes you're right. I missed something when I was updating and also i fixed the line-height issue now, fyi.

LGTM @hsglc we can merge now 🚀

after fixing it, can you mark the problems as solved, this will be very healthy  @hsglc 🎉

Hey @hsglc ! Could you resolve the conflict ? After that I will merge it 🚀

Hey @hsglc ! Could you resolve the conflict ? After that I will merge it 🚀

fixed.


Service client should handle pending buffer overflow

Warning or return an exception....

So it should already be doing this, since this is exactly the situation that should cause requests to fail with ClientOverloadedException.  Is there an example that can reproduce the issue?

Closing for now until we have an example


Error on rbenv install 2.6.10

Hardware details: Macbook Pro 2019 i7 16gb ram
Operative system: macOS 13.1
Command executed:  rbenv install 2.6.10
I tried to install this old ruby version but I can't do it successfully.
I got this error:
LOG:
To follow progress, use 'tail -f /var/folders/6t/57sgjc6d2lzc82r607cp1b_00000gn/T/ruby-build.20230122122848.30025.log' or pass --verbose
Downloading openssl-1.1.1s.tar.gz...
-> https://dqw8nmjcqpjn7.cloudfront.net/c5ac01e760ee6ff0dab61d6b2bbd30146724d063eb322180c6f18a6f74e4b6aa
Installing openssl-1.1.1s...
Installed openssl-1.1.1s to /Users/mjsorribas/.rbenv/versions/2.6.10

Downloading ruby-2.6.10.tar.bz2...
-> https://cache.ruby-lang.org/pub/ruby/2.6/ruby-2.6.10.tar.bz2
Installing ruby-2.6.10...

WARNING: ruby-2.6.10 is past its end of life and is now unsupported.
It no longer receives bug fixes or critical security updates.

ruby-build: using readline from homebrew
ruby-build: using gmp from homebrew

**BUILD FAILED (macOS 13.1 using ruby-build 20221225)**

Inspect or clean up the working tree at /var/folders/6t/57sgjc6d2lzc82r607cp1b_00000gn/T/ruby-build.20230122122848.30025.lwlWGR
Results logged to /var/folders/6t/57sgjc6d2lzc82r607cp1b_00000gn/T/ruby-build.20230122122848.30025.log

Last 10 log lines:
transform_mjit_header: SKIPPED to transform __inline_isfinitef
transform_mjit_header: SKIPPED to transform __darwin_fd_clr
transform_mjit_header: SKIPPED to transform __darwin_fd_set
transform_mjit_header: SKIPPED to transform __darwin_fd_isset
transform_mjit_header: SKIPPED to transform __darwin_check_fd_set
transform_mjit_header: SKIPPED to transform __sputc
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [libruby.2.6.dylib] Error 1
make: *** Waiting for unfinished jobs....
ln -sf ../../../.ext/include/x86_64-darwin22/rb_mjit_min_header-2.6.10.h include/ruby-2.6.0/x86_64-darwin22/rb_mjit_min_header-2.6.10.h

Hi, macOS recently shipped some changes to its compiler tools (provided by Xcode) that makes compiling older Ruby versions very difficult or impossible in some cases.
No known solutions exist that I know of, and I would advise you to upgrade your app to at least Ruby 2.7.7 (or later).


GPU isn't detected in Docker WSL2 in Win11

What is the issue?
I followed the instruction on ollama dockerhub to set up my Nvidia-Toolkit
but the container still didn't recognize the GPU on my computer.
Here is the error log

I am sure that I have CUDA and NVCC installed on my WSL2
Here is my version

My environmental variable in ollama also seems to be normal

Btw, the windows version of Ollama works fine, only the WSL docker doesn't work.
I don't know why the Docker doesn't recognize my GPU.
Please advise.
OS
Windows, Docker, WSL2
GPU
Nvidia
CPU
Intel
Ollama version
latest

The error 500 is one I haven't seen before
     /**
     * This indicates that a named symbol was not found. Examples of symbols
     * are global/constant variable names, driver function names, texture names,
     * and surface names.
     */
    CUDA_ERROR_NOT_FOUND                      = 500,

My suspicion is the nvidia tools in WSL2 are not set up correctly or completely.   Double check the instructions from nvidia here https://docs.nvidia.com/cuda/wsl-user-guide/index.html#nvidia-compute-software-support-on-wsl-2 to see if there's anything you missed.

Also make sure to follow these instructions - https://docs.docker.com/desktop/gpu/
If their validation step works, but ollama still doesn't work, please run the ollama container with -e OLLAMA_DEBUG=1 and share the logs and I'll reopen the issue.


Fix TOO/TIO display errors for NTSR shipments

Description
The TOO/TIO screen to view the details of an order/move was failing when a move with an NTSR shipment was submitted. To fix this, we had to patch a nil dereference error when converting the mtoShipment.RequestedPickupDate field into the format needed in the response.
We also had to fix a small display error in the ShipmentDisplay component that was trying to format the non-existent pickup address. Now this page will display nothing for the Current Address for NTSR shipments.
Setup
To check this fix, you'll need to run your server and your client:
make server_run
make client_run

Next, either create a new move with an NTSR shipment by going through the customer interface or find an existing move with an NTSR shipment and navigate to this page in the office interface: http://officelocal:3000/moves/<orderID>/details as TOO or TIO user. You should be able to see the NTSR shipment with a blank Current Address.
Screenshots

Warnings

:warning:
This PR does not include changes to unit tests, even though it affects app code.

:warning:
Please add the JIRA issue key to the PR title (e.g. MB-123)

  Generated by :no_entry_sign: dangerJS against 8303ddb96a85d4ec11f0388d2248ac7401d77d86


docs: fix typo in understanding resource tutorial page

Hey @davidwandar thanks for the PR. Please make sure to follow commit convention and create your PR with approriate title next time.
https://refine.dev/docs/guides-concepts/contributing/#committing-your-work-and-preparing-a-pull-request


Add TeamCenter functionality

Hello,
I added team center functionality to housekeeper but consider this as a working draft. I had errors using the latest commits, so I ended up using the latest release version instead, so this is a bit outdated.
This draft is fully functional but lacks good structure of code (I ain't the best at this lol), I put all the functions used in the form and used settings.settings to store the cache path for TC. I made this pull request so I can get feedback on how I can improve this and make it worthy of merging.
I tried to add comments where possible but if you have any other questions feel free to ask.

SolidEdgeHousekeeper.zip

Hi @AalianKhan ,
I'm very excited you're making headway on this.  You're going to make a lot of people very happy!
We recently split the ListView functionality into separate Sources and Files objects.  I've been out of town for a few weeks, so didn't get those changes up on GitHub until today.  Unfortunately that is causing a merge conflict with your code.  Sorry about that.  Could you please refresh (if that's what it's called) from GitHub and see if you can adapt to those changes?  Please let me know how I can help.

Hi @AalianKhan
Sorry, I kinda dropped the ball on this.  I didn't merge your changes because of the conflicts, but I did look over your source code.  It looks good to me.  If you can resolve the conflicts, and there are just a couple, I'd be happy to get everything merged together.

Hi, I'll be helping merge Aalian's work here.  With onboarding to the new code and the upcoming holidays we will likely revisit this in January. We can open a new pull request when we are setup again, but we are very interested in keeping this work alive! Thanks.

Hi @yguarism
Nice to meet you!  Glad to hear this is still going.  Quite a few users will benefit from your and @AalianKhan 's efforts.
I'll close this one out.  Looking forward to working with you!


Godot 4 RC2 has built-in documentation alignment noticeably affected

Godot version
Godot 4 RC2
System information
MacOS Ventura 13.2
Issue description
Hi!
It's great the font size options for the built-in help docs in RC2 is finally working, however in the process the alignment and UI of the docs have been badly affected in comparison with RC1 (with same font settings across both releases).
In RC1 (how the documentation for Vector3 should look):

In RC2 (how the documentation for Vector3 now looks):

Other portions of the documentation have even worse alignment issues, such as below:

Steps to reproduce
Just open up the built-in help docs for various classes/methods and you'll see the alignment issues. It's as if the documentation has been "tabbed" a few times.
Minimal reproduction project
N/A

Interesting. If it is indeed related to the font size PR somehow, then there is some underlying issue with indent calculations. Perhaps just a typo, confusing X and Y? :)


Add support for stretch views.

For the case where:

align items attribute is set to stretch
OR
align self attribute for individual flex item is set to stretch

@yaraki could you have a look?

Thanks!


NPM 3 flat structure

With npm 3, all depenciea are in root directory of node_modules. So I had to figure out which dependencies are only for devto ignore. I think a nice feature to have is the packager only copy over the npm modules listed under dependencies and not devDependencies, recursively.

If/when this is implemented, it would need to be compatible with earlier versions of npm (i.e., the 2.x series).

You can try installing the latest npm. I did it accidentally by running npm update -g. Then you can try npm install with your package.json.

On Sep 29, 2015, at 11:20 PM, Mark Lee<EMAIL_ADDRESS>wrote:
If/when this is implemented, it would need to be compatible with earlier versions of npm (i.e., the 2.x series).
—
Reply to this email directly or view it on GitHub https://github.com/maxogden/electron-packager/issues/145#issuecomment-144109496.

Not sure what you're saying here. Are you advocating that we require users to install npm >= 3.0?

I don't know why you mention the "compatible with earlier versions of npm".
Everything still works fine with npm 3. The difference is that let's say you have 30 items in your dependencies and devDependencies in your package.json file. What you will find in your node_modules directory is not 30 npm modules, but rather about 530 modules. With NPM 3, they flat out the dependencies instead of leaving them nested like before. Check this article, and this one, and look for the keyword "flat".
With this flat structure, I would have to figure out the modules only used for development, which was not only those listed under devDependencies, to add them to the --ignore flag.
So I am saying that it would be nice if electron-packager can figure out all the packages under devDependencies recursively and ignore them. This would also help with using NPM 2, where I no longer have to use --ignore flag often (for webpack and loaders).
Lastly, I am not advocating the use of npm >= 3.0. I would not use it as of now because figuring out all the modules to put under --ignore is a nightmare. However, there are readings that say NPM 2 is still around  as LTS, and it will be depreciated.

I just wanted to make sure that if this is implemented, electron-packager still works with npm 2.x.

a simple workaround to avoid a complex solution is to put your app in a subfolder with its own package.json

For what it's worth the way the packaging of node modules currently works is quite problematic for larger apps.  I ended up with so many issues that I just ended up using webpack for everything but native extension, then ignore the entire mode_modules folder and copy over the few items that are native dependencies.
At present I can't even get my built dylibs into the final artifact when not manually copying it over (not sure why).
So what I want to propose is to make electron-packager aware of node a bit and understand how the modules work and the non-dev dependencies over.

I also had this problem and solved this problem with maxogden's way. I think that maxogden's idea is best approach to solve this problem.

This request the same as either #198 or #235, depending on how you look at it.


Loading a non existing operator should return nil or nil, error

At present Operators().Get("foo") returns a new operator when foo doesnt exist.  Makes it hard to handle user input errors etc.
Operators().Get() should probably reutrn (Operator, error)

hummm - ok looking at the code, for get - it literally will return nil, if the operator is not there - I think you had a store where a foo operator existed? - there's actually a test testing for this:
https://github.com/synadia-io/jwt-auth-builder.go/blob/9d1dffca78fb970bd634a23230c7001d80752426/tests/operator_test.go#L9
Also - I know why the Get() doesn't return an error - when the auth provider initializes, it read all the operators there. This is actually probably a concern (maybe?) as you could be loading 1000s of them - we should chat about this - currently the entire tree is loaded.

hmm, this morning indeed I cant seem to repro this, so weird, will investigate more what it is I saw, will close for now


ValueError: invalid literal for int() with base 10: '09:01:17' when trying to read EDF file

Describe the bug
I get the following error when I try to read an EDF file
ValueError: invalid literal for int() with base 10: '09:01:17'
Steps to reproduce
import mne
data = mne.io.read_raw_edf("ucddb009_lifecard.edf",preload = True )

This is the database https://physionet.org/content/ucddb/1.0.0/
Additional information
output of mne.sys_info().
Platform:         Linux-5.4.0-1083-azure-x86_64-with-glibc2.10
Python:           3.8.5 (default, Sep  4 2020, 07:30:14)  [GCC 7.3.0]
Executable:       /anaconda/envs/azureml_py38/bin/python
CPU:              x86_64: 6 cores
Memory:           54.9 GB
mne:              1.0.3
numpy:            1.19.0 {blas=openblas, lapack=openblas}
scipy:            1.5.2
matplotlib:       3.5.2 {backend=module://matplotlib_inline.backend_inline}
sklearn:          0.22.1
numba:            0.53.1
nibabel:          Not found
nilearn:          Not found
dipy:             Not found
cupy:             Not found
pandas:           1.1.5
pyvista:          Not found
pyvistaqt:        Not found
ipyvtklink:       Not found
vtk:              Not found
PyQt5:            5.15.7
ipympl:           Not found
pooch:            v1.6.0
mne_bids:         Not found
mne_nirs:         Not found
mne_features:     Not found
mne_qt_browser:   Not found
mne_connectivity: Not found

This is not a valid EDF file.  Quoting from the original standard:

8 ascii : starttime of recording (hh.mm.ss)

and the EDF+ standard, section 2.1.3:

The 'startdate' and 'starttime' fields in the header should contain only characters 0-9, and the period (.) as a separator [...]

These files appear to be using a colon separator for times.
You can hack it to work with these files by changing the . to : on this line:
https://github.com/mne-tools/mne-python/blob/e49525c470b01b04c7270dc054bbfa7600021262/mne/io/edf/edf.py#L656

I have to say thanks for your smart "idea" to solve this annoying problem!!!@drammock

Closing as I think no changes are needed at our end


Refactor ISPYB code for robot load: move common parts out and rename

Part of #1017
Robot load ispyb entries are very different to data collection ones. This code takes the common parts out and puts them in a utils class.
To test:

Confirm behavior is broadly unchanged
Confirm unit tests still pass

Made a mess of this branch, apologies. See https://github.com/DiamondLightSource/hyperion/pull/1053 instead


Supress MISRA single use warning for FreeRTOS_in6addr_loopback

Description
This PR suppresses the MISRA Rule 8.9 [An object should be defined at block scope if its identifier only appears in a single function] during the Coverity scan.
Test Steps
Coverity run
Checklist:

[x] I have tested my changes. No regression in existing tests.
[ ] I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Which variable is triggering the warning?
Is this a false positive? Why do we need to suppress it instead of fixing  it?

Which variable is triggering the warning?
Is this a false positive? Why do we need to suppress it instead of fixing it?

Hi @archigup,
The variable is FreeRTOS_in6addr_loopback, it can be used analogous to the in6addr_loopback of <netinet/in.h> (linux or similar) by applications\tools as well other than just by the stack, hence its defined with external linkage.


Moq - Quick glance at Moq - Expand on basic concepts

I think that the section Moq - Quick glance at Moq needs to be expanded to fit more junior developers. I think we should expand on the following points:

The purpose of mock and what problem it is solving. Maybe also add a link to the Dealing with dependency section.
Expand on the Setup method and what it does in the example
Expand on the Verify method and what it does in the example

Understanding the Setup and Verify methods are key to understanding the rest of the documentation, so spending more time here and explaining their usage is important for someone who is new to Moq.

ok? @agnerh


multilingual README.md

add note for System support

Thank you for your suggestion. We will add the system information.


Cpu usage very high and freeze my OS

Describe the bug
Meilisearch freeze my OS due to high CPU usage.
To Reproduce
Steps to reproduce the behavior:

Index big dataset, e.g. ~68 million rows csv.
After indexing  delete the index and recreate the index.
Reindex dataset.

Expected behavior
It will delete the dataset and reindex without freezing the OS(Vanilla OS, Ubuntu 22.10 based)
Screenshots
If applicable, add screenshots to help explain your problem.
Meilisearch version:
V1.1.0
Additional context
Indexing even runs on SSD ~550 mb/s read and write. However freezing and I had to reboot.

I posted extended details on similar issue. I ran box with 32 CPUs, but only 1 used.
https://github.com/meilisearch/meilisearch/discussions/3680

Closing this since we don't get any information from the original issue
The one from @liesislukas is another one, and is answered in the linked discussion: https://github.com/meilisearch/meilisearch/discussions/3680


data.image is undefined. Renamed to croppedImage

I have noticed that data.image now is data.croppedImage and it would be nice if you change this in README.md, because it can provoke a new issues ;)

Indeed, thanks !


dexctl: Deprecating dexctl's --db-url flag

dexctl should not connecting directly db instead it should use admin APIs.This is the updated pull request with the feedback received previously .
Fixes #298

Thanks for the update! Sorry for the delayed response, was having laptop issues.

Thanks for the review.Let me update the pull request according to the feedback

Update.
Added a flag to supply rootCA file and removed driver interface.

Thanks I'll try to review tomorrow. Please ping me on here if I don't get to it.

Any feedbacks on latest changes

Also please combine these commits and force push over the old one please.
http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html

Incorporated all the changes


testing: test output indentation looks inconsistent when tab width != 4

What did you do?
Run the following program:
https://play.golang.org/p/IAMobZmXMqw
What did you expect to see?
=== RUN   TestX
=== RUN   TestX/Y
=== RUN   TestX/Y/Z
--- FAIL: TestX (0.00s)
    main.go:6: 1
    --- FAIL: TestX/Y (0.00s)
        main.go:8: 2
        --- FAIL: TestX/Y/Z (0.00s)
            main.go:10: 3
    main.go:13: 4
FAIL

This is what you see if tabs are 4 spaces wide. Note that each subtest's output is indented with 4 leading spaces, and each log message has a tab after those.
What did you see instead?
=== RUN   TestX
=== RUN   TestX/Y
=== RUN   TestX/Y/Z
--- FAIL: TestX (0.00s)
        main.go:6: 1
    --- FAIL: TestX/Y (0.00s)
        main.go:8: 2
        --- FAIL: TestX/Y/Z (0.00s)
                main.go:10: 3
        main.go:13: 4
FAIL

This is what you see if tabs are 8 spaces wide; any tab width other than 4 will cause similar inconsistencies.
System details
go version go1.10.2 darwin/amd64
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/dpinela/Library/Caches/go-build"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/dpinela/dev/go"
GORACE=""
GOROOT="/usr/local/Cellar/go/1.10.2/libexec"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.10.2/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/41/2xpv_r1j5n5bnflwb7s1hv580000gp/T/go-build030076165=/tmp/go-build -gno-record-gcc-switches -fno-common"
GOROOT/bin/go version: go version go1.10.2 darwin/amd64
GOROOT/bin/go tool compile -V: compile version go1.10.2
uname -v: Darwin Kernel Version 17.5.0: Fri Apr 13 19:32:32 PDT 2018; root:xnu-4570.51.2~1/RELEASE_X86_64
ProductName:	Mac OS X
ProductVersion:	10.13.4
BuildVersion:	17E202
lldb --version: lldb-9<IP_ADDRESS>
  Swift-4.1

Indeed, there is a mix of tabs and 4 spaces indentations in testing package. I am not sure what was the purpose of tabs in indentation of every line since we have 4 spaces here: https://github.com/golang/go/blob/master/src/testing/testing.go#L429
A quick fix comes to mind:
diff --git a/src/testing/testing.go b/src/testing/testing.go
index 573ef05fdc..ee3bebb7ba 100644
--- a/src/testing/testing.go
+++ b/src/testing/testing.go
@@ -381,7 +381,7 @@ func (c *common) decorate(s string) string {
        }
        buf := new(strings.Builder)
        // Every line is indented at least one tab.
-       buf.WriteByte('\t')
+       buf.WriteString("    ")
        fmt.Fprintf(buf, "%s:%d: ", file, line)
        lines := strings.Split(s, "\n")
        if l := len(lines); l > 1 && lines[l-1] == "" {

But it implies fixing tests as well.

I wonder if this change can break others programs or if it's breaks some of Golang promises. ping @andybons @bradfitz

I think it’s fine. If someone is relying on the textual output of tests instead of the JSON output, then this will be a good reason for them to switch :)


chore(deps): update common-dev-assets digest to 5137d1d

This PR contains the following updates:

Package
Update
Change

common-dev-assets
digest
3ede48b -> 5137d1d

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 1.0.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


No way to paste yaml file contents to new pipeline

Seems like there is a step missing, you can't just copy yaml code in devops simply to a new file

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0a6a24a4-066b-caaf-551a-0d58097fea4b
Version Independent ID: d2cbc919-38f3-8aaf-b3d6-ab26c4a0d260
Content: Clone or import a pipeline - Azure Pipelines
Content Source: docs/pipelines/get-started/clone-import-pipeline.md
Product: devops
Technology: devops-cicd-get-started
GitHub Login: @juliakm
Microsoft Alias: jukullam

@cherietopham11 -- Cherie, thank you for your feedback.  I believe the intention of the existing instructions is to copy the YAML from the source project's editor window, and paste it in the new project's editor window.
Please consider these resources:

Azure DevOps Services
Azure DevOps on Stack Overflow

@juliakm for awareness
I am closing this issue now.  You are welcome to @ mention me for any followup.  We hope to hear from you again.


UDS+ Kit Update for v1.0.1 of IG

@arscan
UDS+ IG updated to version 1.0.1, and as part of the update, the IG was moved to a new website hosted by FHIR,
https://fhir.org/guides/hrsa/uds-plus/index.html.
Needed Changes:

Package update
Sample resource update
Version number update
README update
URL update for all resources

Deployed!  https://inferno.healthit.gov/suites/uds_plus

Thanks for getting on it so fast!


fix: multi languages win 32 typicalChromeExecutablePath

Reupload: Corrected conventions on naming conventions
A PR for the case where the user windows OS is in a different language and the 'Typical Chrome Executable Path' is on a 'non-English-standard' ProgramFiles folder.
In windows, it can be gotten by the environment variable ProgramFiles(x86).

Thanks for the suggestion, but let's first start with the problem you are trying to solve. Can you describe it more in detail? How can we test it ourselves?
The proposed change itself looks a bit funky, given the string you are using regexes on is static, I can't see any reason to actually do this via regexp.
You should be able to adjust the chrome path via APIFY_CHROME_EXECUTABLE_PATH env var, if it's something non-standard.

Can you describe it more in detail?

I was experimenting with this package as a prospect for a future project. I tried to add some non-existent feature to it but was blocked right away when the tests failed (ex: puppeteer_launcher.test - supports useChrome option ).

I can't see any reason to actually do this via regexp

Yes you are right. At the time i used this more general code to deal with any 'environment variable' on other places and didn't clean it latter. I can change it to something simpler like for example.
return `${process.env['ProgramFiles(x86)']}\\Google\\Chrome\\Application\\chrome.exe`

How can we test it ourselves?

There seem to be already some CI test with Windows OS in this repo. That may be the best path.
I see that they are failing. Some of the errors looks similar to a situation i had.
I am no sure how i managed to pass the tests. I was doing several things at the same time and windows doesn't help much...
But i think that installing Puppeteer (and/or Playwright?) globally did the trick.
Reason for my PR:
My PR would be helpful for people who might want to contribute to the package.
thanks for taking the time to give a quick feedback even on the week end 🙂
I will wait for your response before doing anything more.

AFAIK the path is dependent on the Chrome version. Maybe we should support a fallback to the old one.

There seem to be already some CI test with Windows OS in this repo. That may be the best path.

Tests in the CI are passing on windows too in master, they are just too flaky, so failing rather randomly because of some timeouts, definitely not because of this. I believe they also work locally on windows, right @vladfrangu?
Seeing the tests in your branch, they actually fail because chrome is not installed on that path you changed. In other words, you fixed your local environment, but in CI it is installed elsewhere and it breaks. We should check if there is something on the path and fallback to the currently defined one. I would also like to see a fallback in case the env var is not set.

Yes the ProgramFiles(x86) is not the correct variable to be used here.
So
return `${process.env['ProgramFiles']}\\Google\\Chrome\\Application\\chrome.exe`

would be the correct one?
Note that Chrome installing on path C:\Program Files (x86) even on 64bit windows machines, is an old issue that was only solved by mid 2020, i think. This path is still normal for people that have installed their chrome browser before that date (like me).

It helps with the CI tests, so as long as it works for you, I guess it's the right one :]
I would still like to see a fallback in case the env var is not present, so we preserve the old behaviour, other than that I am happy to merge.
Would appreciate if you could check this locally too @vladfrangu

I just saw my last commit and realized that it couldn't be correct. It was already very late, when i made it and a little tired.
Worse i ended up not running the tests :(
I changed the code with different languages in mind, as well as the Chrome issue and with the original default fallback.
The tests in my machine passed correctly this time.

Thanks!


Add onPreDev build plugin hook

Is your feature request related to a problem? Please describe.
Build plugins are now able to mutate the config at build time. However these changes are not persisted when running ntl dev.
Describe the solution you'd like
Add a new build plugin hook, e.g. onPreDev, which is called when running ntl dev and before spawning the site's develop command. This could be used to update the configuration, inject env vars etc.
Describe alternatives you've considered

Currently we write out a _redirects file if we need redirects to be available during dev, rather than using config mutation. This is fragile, prevents the use of redirects from the TOML file, and means that plugins must require users to run build bedore they can run dev.
Persist config changes made during build. However this wouldn't allow us to use different redirects for develop, and could give unexpected results if the user didn't run build beforehand. This also requires build to be run before dev

For Essential Next.js, some work has been done to support a watch mode.
The idea was for the CLI to detect the plugin, and run it in watch mode per https://github.com/netlify/next-on-netlify#preview-locally.
The onPreDev also works.

I think this might tie to a bigger problem: builds (production or local) and netlify dev are currently completely separate. For example, netlify dev does not call @netlify/build nor Build plugins at all.
Extending Build plugins to support netlify dev might not be straightforward because Build plugins currently assume they are spawned within @netlify/build. The process and environment in which they are currently spawned is very different from netlify dev. To take one of many examples, Build plugins are wrapped in code which orchestrate them, handle their errors, pass utilities, etc. which we don't have an equivalent for in netlify dev at the moment.
In my opinion, we should consider trying to bridge that gap and integrate @netlify/build and netlify dev more together. But until we do this, it seems to me we might need to explore other solutions that Build plugins to solve the underlying problem of this issue.

This was implemented!


[docs] update readme

@hausdorff PTAL, thanks!

What's here so far looks great.
I'd like to expand on it a little to think through what we want in this README before release. IMO It'd be nice to see the following "sections",

Core cases: More or less what's in the README currently for apply, diff, etc. on files supporting jsonnet.
Prototypes (definition & command examples)

emphasize on how we are able to quickly create k8s objects

Environments (definition & command examples):

emphasize on how we are able to manage multiple target servers

thanks @seh for the feedback--I've incorporated and squashed those changes.
@jessicayuen that's a fair point--I made this PR because @hausdorff wanted an updated blurb, and agree that the current README is not complete as is. That being said, I am in favor of punting any major README changes until we've figured out the plans for the docs website---unless we have active users of this repo that are not developing the tool.
^ @hausdorff is that the case?

@abiogenesis-now @jessicayuen Completely agree with Jess, but we should ship this change now so that people stop IM'ing me to complain that it's confusing.

Ok, that works for me -- just wanted to make sure we capture those cases
before release.
On Oct 24, 2017 5:47 PM, "Jessica Yao"<EMAIL_ADDRESS>wrote:
thanks @seh https://github.com/seh for the feedback--I've incorporated
and squashed those changes.
@jessicayuen https://github.com/jessicayuen that's a fair point--I made
this PR because @hausdorff https://github.com/hausdorff wanted an updated
blurb, and agree that the current README is not complete as is. That being
said, I am in favor of punting any major README changes until we've figured
out the plans for the docs website---unless we have active users of this
repo that are not developing the tool.
^ @hausdorff https://github.com/hausdorff is that the case?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ksonnet/ksonnet/pull/32#issuecomment-339179122, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADSGxtE0y-NbMtu5hn0tvP6yqm6ZxvV6ks5svoU5gaJpZM4QFRFS
.


Expose the WinApi and Libc from crossterm to the user.

I think it would be cool to expose the WinApi and libc API of cross term. Before this could be done those Api's should be a little reformated. By exposing it the user is able to directly act on the opeating system instead of doing it via crossterm.

I am now working on making the Winapi backend exposable.

I created an separate crate for some common winapi which could be found here: https://github.com/TimonPost/crossterm_winapi

Going to close this since the WinApi, cross-term is using is mostly moved into its own crate.  And I am not sure if libc exposure helps other users since there are only a few things cross-term does with it.