feat: add budimanjojo/talhelper

#3929 budimanjojo/talhelper: A tool to help creating Talos kubernetes cluster

Thank you for your contribution!

Released https://github.com/aquaproj/aqua-registry/releases/tag/v2.22.0


refactor oauth resource server implementation

Refactor Xpanse's oauth resource server implementation to unify JWT and Token introspection options as much as possible.

[ ] Check suggestions here - https://github.com/ch4mpy/spring-addons/issues/166#issuecomment-1872329465
[ ] Update tests to use @withJwt annotation.

I'll take this


OCI filter name for network and database cards

Encountered a "Unsupported parameter or invalid value" error while testing the overview page. This fixes the OCI filter name for network and database cards.
https://issues.redhat.com/browse/COST-2358

Codecov Report

Merging #2412 (52104e4) into main (19696bb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             main    #2412    +/-   ##
========================================
  Coverage   70.40%   70.40%
========================================
  Files         432      432
  Lines        8077     8077
  Branches     1894     1759   -135
========================================
  Hits         5687     5687
  Misses       2387     2387
  Partials        3        3

Impacted Files
Coverage Δ

...tore/dashboard/ociDashboard/ociDashboardWidgets.ts
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19696bb...52104e4. Read the comment docs.


Commit not showing on map

It looks like the latest pull request isn't showing up on the map after merging both the master and gh-pages branches.
The map should have added a point for Sun Street Breads in south Minneapolis, like so:

The GeoJSON has been updated, and has no errors, but isn't showing up. Do you know why this is?

The data was good, but the display code had a bug.
Fixed in this commit:  https://github.com/MaptimeMSP/nacis2015-map/commit/229b62ad31ff22ed5dd086adad53f6a3ba4351ed

Awesome, thanks @fawcett! :+1:


Use toString() to determine if Function prop has been modified

What problem does this feature solve?
It can be very convenient to use pass an anonymous function to a component in a template in certain instances, for example to provide a formatting function when a slot feels like overkill. However, anonymous functions will always cause the child component to rerender when the parent component rerenders, because the function will be recreated.
I suggest that if the === comparison is false, then next try comparing .toString() and only rerender if that is also false. This is unlikely to have a noticeable negative performance impact, as Function props are not terribly common (and changing them on the fly even less so) and benchmarking Function.toString shows that 3M ops per second is pretty standard on my Windows/Chrome system regardless of function size.
What does the proposed API look like?
Not proposing any API changes.

You can already declare a function in data or as a computed to not recreate the function when the template renders again, and I'd say that is the recommended way, having functions floating in your template is too much js in the template

This is unlikely to have a noticeable negative performance impact

Unfortunately, this is adding a check for every prop everywhere, so it may actually be noticeable
Tell me if I misunderstood something, but since this is already easily achievable we prefer not to introduce a new condition check that could lead to slower performance

You are correct that this is easily achievable; however throwing an arrow function into a template is often a matter of a few characters and is convenient for our developers (who may not realize the performance impact). The reason we use Vue is the small learning curve and large ease of use. Regardless, I understand.

FYI toString() is also not 100% technically correct, because two functions may very well have the same string content but declared in different scopes, so invoking them would result in different results... probably very uncommon, but still possible.

Great point.
I feel like the documentation should warn that using anonymous functions this way can be a performance hazard. The temptation is real when arrow functions can be so compact.

It would even be possible to generate a warning about this in a development build of Vue. It is trivial to use .toString() to determine if a function is anonymous.


About section of Github Repository

@Yakub-Ojo , Kindly add a description in the about section of Github Repository .

Kindly Add the live link in the about section too.

Issues resolved, thanks for the observation


Chunk encoding affects query results

Please see this test: https://github.com/AlekSi/prometheus/blob/ec68e9722a8b740ee9631dc4ae58398f0f42f3a4/promql/range_test.go I expect it to return 21 values independent of chunk encoding. @SuperQ confirmed at IRC that query results should not be affected by storage. But they are: https://travis-ci.org/AlekSi/prometheus/builds/254887870
This test fails with both current master and v1.7.1.

@beorn7

Thanks @AlekSi for the perfect bug report including test.
This is intriguing, if the timestamp is off by 1ms, everything works as expected. I guess the chunk iterator in encoding v2 gets a hiccup if you hit a sample's timestamp precisely and then skips the next data point.
I'll try to nail this down in a unit test in the storage layer itself.


FA icon classes

https://github.com/joomla/joomla-cms/pull/28351

Yup, keeping track of this closely. Hopefully gets merged

Temporarily added until Joomla supports inline SVGs: https://github.com/C-Lodder/lightning/commit/0a7e58b84133fcbb58c5eceb185d1aa2524b84f3


Add support for discord-hybrid-sharding.

Hybrid sharding allows the bot to make use of both traditional and internal sharding for optimal memory usage. This is heavily required at scale. https://github.com/meister03/discord-cross-hosting Is a package that allows scaling shards across multiple hosts however it's only compatible with https://github.com/meister03/discord-hybrid-sharding. The only key difference I was able to spot is how events are registered. If we allowed the ability to specify an implementation for the #getClient function on the client.service.ts. We could add support for this that would allow the use of this package at scale.
If you instead wanted to add direct support for this package, I believe we could just swap this implementation below
https://github.com/fjodor-rybakov/discord-nestjs/blob/465837768feba8ba80cc04bb52a3b624ff714997/packages/core/src/services/client.service.ts#L34-L36
with:
getClient(): Client {
    return (this.client.cluster || this.client) as Client;
}

Although I believe this could break a few things internally. It would need to be tested.

Irrelevant. Communication issue. Misunderstood the discord-hybrid-sharding package.


Test behaviour of expressions containing temporaries

For a very simple example, see https://godbolt.org/z/xd7abze85
Complex expressions might trigger the creation of temporaries, which might make problems even when the data memory addresses are still valid. Something like auto vf_res2 = vf1 + vf1.cross(vf2); might lead to undefined behaviour when accessing vf_res2[...] later on.
Unit tests should be written to cover the expected behaviour and guidelines should be written to explain what to avoid.

Am I missing something? In your example, you take the reference to a temporary, so in the next line already, your temporary goes out of scope and is gone. How is this intended to work?

Hm, but I only know this to work locally. I don't think you can hand them around everywhere and have this work.

A temporary bound to a reference member in a constructor’s ctor-initializer (§12.6.2 [class.base.init]) persists until the constructor exits. A temporary bound to a reference parameter in a function call (§5.2.2 [expr.call]) persists until the completion of the full expression containing the call.

However, while the above quote explains why the example does not work, it does of course provide no insight, why this was defined like this and I couldn't find a satisfying answer online so far.


Modal background scroll while open

It's possible to scroll (body) while a modal is open.
Detected on Safari for iPhone.
Possible solution:

overflow: hidden; // already there
position: fixed; // add positioning

}```

Sorry I took so long to respond.
This is a known issue.
Safari IOS (and most mobile browsers) tend to want to make things scrollable even if they aren't. They have to do this because they have weird heuristics for changing font sizes in different ways, and it might make things scrollable where we put an overflow:hidden and couldn't possibly have prepared for that algorithm. We looked into a lot of things at the time, including what you are suggesting right now, which could make the background not scrollable, but it turns out that the mobile browser is very authoritative about this and nothing works.
In the past we used a pretty nasty hack, which was to save the scrollTop of the body, and keep restoring it whenever a scroll event occurred. It worked, but it was so ugly we just took it off and ended up with the current solution, even though mobile browsers want to let the user scroll behind the modal.
We figured out that using this level of hacks to overthrow current browsers messing with our stuff was counter-productive and goes against what we try to do with Ink, which is do things the most simple and unobstrusive way possible, and weighed that against the cost of a small glitch (being able to scroll the content behind the modal).
If some CSS property or HTML attribute comes up to let us tell the browser to not mess this up, I hope we can be the first to use it. Until then, we need to learn to live with this.


feat: Modified Styling

Home Page

Classes

Thank you for all the work you're putting in, I really appreciate it. However, in the future please submit an issue before a PR. That way we can discuss what you want to do and your reasoning for the changes before you begin work. It should help cut down on the number of changes you need to make. As for this PR, can you please give me a summary of the changes you've made and why?
Also a small technical issue: it looks like you've branched off of your previous PR rather than main.

Thank you for all the work you're putting in, I really appreciate it. However, in the future please submit an issue before a PR. That way we can discuss what you want to do and your reasoning for the changes before you begin work. It should help cut down on the number of changes you need to make. As for this PR, can you please give me a summary of the changes you've made and why?
Also a small technical issue: it looks like you've branched off of your previous PR rather than main.

Makes sense. I was just having some fun and wanted to make a few tweaks to the styling :)
Yes, I branched off my other branch on purpose lol

I'm going to close this PR for now. I agree the styling needs work, but the project might become more integrated into the 100Devs main site, in which case we'd want to restyle to be more in line with everything else anyway.
Second, this is really more like 4 different changes: text size, max width, homepage photo, and colors. And there may be a few other small tweaks mixed in as well. It would be better to deal with each one separately. I'm not going to change sizing or colors for now. Max width I agree, but I think xl is too small (there's a tradeoff here between how wide the site is and how much people are forced to scroll). 2xl should be fine.  And the homepage photo, I absolutely agree with. Since there's nothing really to discuss at this point, feel free to submit a single PR with just those two changes.
My point about the branches was that if you're making two unrelated changes (and I don't see any overlap in these two), you shouldn't branch one off the other. It makes a cleaner commit history, plus can avoid some issues (like if the styling PR is ready to merge but the DX PR still needs work). It's not a huge issue here, just thought I should point it out.


Disabling LuaPerRoute  configuration doesn't work with envoy-v1.19.0

Title: Disabling LuaPerRoute  configuration doesn't work with envoy-v1.19.0
Description:
Lua filter is executed  for requests which match a route with Lua disabled using LuaPerRoute configuration. We are seeing this only in the latest envoy version - v1.19.0.
Repro steps:

Using the example from envoy doc, add a lua filter before the envoy.filters.http.router filter.

          - name: envoy.filters.http.lua
            typed_config:
              "@type": type.googleapis.com/envoy.extensions.filters.http.lua.v3.Lua
              inline_code: |
                function envoy_on_request(request_handle)
                  request_handle:logInfo("Hello World.")
                end
                function envoy_on_response(response_handle)
                  response_handle:logInfo("Goodbye")
                end

Create the following route in envoy.filters.network.http_connection_manager with lua filter disabled.

- match:
       prefix: "/healthcheck"
  direct_response:
       status: 200
  typed_per_filter_config:
     envoy.filters.http.lua:
        "@type": type.googleapis.com/envoy.extensions.filters.http.lua.v3.LuaPerRoute
         disabled: true

Start Envoy

docker run -it -v $(pwd):/etc -p 10000:10000 -e ENVOY_UID=0 envoyproxy/envoy:v1.19.0 -c /etc/static.yaml

Make a request to /healthcheck.

curl -v  localhost:10000/healthcheck

< HTTP/1.1 200 OK
< date: Thu, 15 Jul 2021 14:35:12 GMT
< server: envoy
< content-length: 0

Expectation: Lua filter should not be executed
Actual logs:
[2021-07-15 14:30:45.627][23][debug][http] [source/common/http/conn_manager_impl.cc:858] [C0][S7712392761175078799] request headers complete (end_stream=true):
':authority', 'localhost:10000'
':path', '/healthcheck'
':method', 'GET'
'user-agent', 'curl/7.64.1'
'accept', '*/*'

[2021-07-15 14:30:45.627][23][info][lua] [source/extensions/filters/http/lua/lua_filter.cc:795] script log: Hello World.

[2021-07-15 14:30:45.628][23][debug][http] [source/common/http/filter_manager.cc:909] [C0][S7712392761175078799] Sending local reply with details direct_response

[2021-07-15 14:30:45.628][23][info][lua] [source/extensions/filters/http/lua/lua_filter.cc:795] script log: Goodbye

Config: static.yaml
Logs: trace logs

Found another place where lua invocation is done, when it is not supposed to.
- name: envoy.filters.http.health_check
  typed_config:
    "@type": type.googleapis.com/envoy.extensions.filters.http.health_check.v3.HealthCheck
    pass_through_mode: false
    headers:
    - name: ":path"
      exact_match: "/health/ready"
- name: envoy.filters.http.lua
  typed_config:
    "@type": type.googleapis.com/envoy.extensions.filters.http.lua.v3.Lua
    inline_code: |
      function envoy_on_request(request_handle)
        request_handle:logInfo("Hello World.")
      end
      function envoy_on_response(response_handle)
        response_handle:logInfo("Goodbye")
      end

Since health-check filter is before the lua filter, ideally we expect a  request to /health/ready shouldn't execute lua code.
But we see logs from lua.

i don't think it a bug,  if you set envoy.filters.http.health_check pass_through_mode false, the health check will response direct. so next http filters will not exec.

This is a regression I believe from: https://github.com/envoyproxy/envoy/pull/16673. cc @soulxu
This code:
https://github.com/envoyproxy/envoy/blob/a1c5a5076e97e6cd3d4b725b6eeb645513c72092/source/common/http/utility.h#L506-L508
Does now return per-route filter configurations for direct response entries. I think this needs to be fixed.
Note that this is a very similar issue to what is being discussed here: https://github.com/envoyproxy/envoy/pull/17359#discussion_r673264014. cc @alyssawilk @snowp @chrisxrepo

I found it only reproduced with direct_response.
        virtual_hosts:
            - name: local_service
              domains: ["*"]
              routes:
              - match:
                  path: "/"
                direct_response:
                  status: 200
                typed_per_filter_config:
                  envoy.filters.http.lua:
                    "@type": type.googleapis.com/envoy.extensions.filters.http.lua.v3.LuaPerRoute
                    disabled: true

but it works as expected with:
            virtual_hosts:
            - name: local_service
              domains: ["*"]
              routes:
              - match:
                  path: "/"
                route:
                  cluster: my_cluster
                typed_per_filter_config:
                  envoy.filters.http.lua:
                    "@type": type.googleapis.com/envoy.extensions.filters.http.lua.v3.LuaPerRoute
                    disabled: true

so let me debug more on it.

After debug, the reason is when using direct_responses, the route->routeEntry() will return nullptrl
https://github.com/envoyproxy/envoy/pull/16673/files#diff-27e2e78f58a398310f9d296487d59272f0deb90d972cbfa0ba81baf4af575e5eR490
which lead to the code consider it as no per-route config.
Also found that check is copied from https://github.com/envoyproxy/envoy/pull/16673/files#diff-f925f7e0b7fb1171869c35d0a04d44a7128287e0dace606dfcf9f5924e335f34L116 by me
Also tested the v1.18 with fault filter, it has same bug with this one.
Sorry I didn't found this issue in the beginning, let me working on a fix.

Thanks for checking @soulxu

Thanks for checking @soulxu

np! In the end, I found @mattklein123 already point that out. I just speed time make myself understand what is going on :)
I submitted a fix.
Also I guess we have issue with another method
https://github.com/envoyproxy/envoy/blob/284698959bb4f0d1e2c36a387a2e725b38f19a09/source/common/http/utility.cc#L933-L938
^ that could lead to the virtual host's typed config was skipped. that method is used for the case of merging all the per filter config. I will continue verify that, if there has any issue, I will fix that too.

Also I guess we have similar issue with Utility::traversePerFilterConfigGeneric method
https://github.com/envoyproxy/envoy/blob/284698959bb4f0d1e2c36a387a2e725b38f19a09/source/common/http/utility.cc#L933-L938
^ that could lead to the virtual host's typed config was skipped. that method is used for the case of merging all the per filter config. I will continue verify that, if there has any issue, I will fix that too.

After the check, when the direct_response is set, the ext_auth filter will skip the auth directly. @mattklein123 is it expected behavior?

After the check, only ext_auth filter using this method to merge the per route config. But I found when the direct_response is set, the ext_auth filter will skip the auth directly. @mattklein123 is it expected behavior?

Sorry can you expand? Do you mean that ext_auth was not disabled before and now it is?

After the check, only ext_auth filter using this method to merge the per route config. But I found when the direct_response is set, the ext_auth filter will skip the auth directly. @mattklein123 is it expected behavior?

Sorry can you expand? Do you mean that ext_auth was not disabled before and now it is?

yea, I found Utility::traversePerFilterConfigGeneric also based on the routeEntry() return. If it return nullptr, it will keep the virtualhost filter config. So I worry about if there is any filter using Utility::traversePerFilterConfigGeneric method could lead to that issue. Utility::traversePerFilterConfigGeneric is only used by getMergedPerFilterConfig method
https://github.com/envoyproxy/envoy/blob/6834081f835d609606e77ef84d734e30fc403d58/source/common/http/utility.h#L563
getMergedPerFilterConfig will merge all the typed filter config (from the virtual host to per route). And getMergedPerFilterConfig only used by ext_auth filter.
https://github.com/envoyproxy/envoy/blob/6834081f835d609606e77ef84d734e30fc403d58/source/extensions/filters/http/ext_authz/ext_authz.cc#L41
So I'm trying to test whether it is broken. But I found when the direct responses is set, the ext_authz will skip the check directly, it is also based on the return value of routeEntry(). It means when the direct responses is set, the routeEntry() returns nullptr, then ext_authz skip the check.
https://github.com/envoyproxy/envoy/blob/6834081f835d609606e77ef84d734e30fc403d58/source/extensions/filters/http/ext_authz/ext_authz.cc#L81-L85
https://github.com/envoyproxy/envoy/blob/6834081f835d609606e77ef84d734e30fc403d58/source/extensions/filters/http/ext_authz/ext_authz.cc#L377-L379
So my first question becomes whether ext_authz should be skipped when the direct response is set.

So my first question becomes whether ext_authz should be skipped when the direct response is set.

IMO no, it shouldn't be skipped. I think this is a bug also. I don't see why a direct response by the router should prevent ext-auth from happening. This is a bug though that I'm guessing no one has noticed before, so we should fix it. With that said, this is a great callout, and we might want to runtime guard this part of the change?

So my first question becomes whether ext_authz should be skipped when the direct response is set.

IMO no, it shouldn't be skipped. I think this is a bug also. I don't see why a direct response by the router should prevent ext-auth from happening. This is a bug though that I'm guessing no one has noticed before, so we should fix it. With that said, this is a great callout, and we might want to runtime guard this part of the change?

Filed an issue for this https://github.com/envoyproxy/envoy/issues/17502
For runtime guard, I'm still learning the policy we have in envoy. I guess we should have runtime guard when this long standing bug, I git blame the code, found it should be existed in the day one.
https://github.com/envoyproxy/envoy/pull/2417/files#diff-47e90158b44d006af8d17ada6144e4a7bcdb54e13cbe08fe7a955237ce1da610R32
If that is policy, then we should have runtime guard.

Yup at least for the extauth usage I would recommend runtime guarding the fix with default on. Thank you so much for looking through all of this and making the code better!

/assign

i will repaire the issue


Tunnel remote UI misses remote indicator icon

I think we should be consistent and also use the remote indicator when opening a tunnel as remote.
Compare with GH:

The codicon is $(remote)

https://github.com/microsoft/vscode/pull/182653 will take care, we will enforce a remote icon always.


Can we Disable the mouse pointer ?

What is your Test Scenario?

What are you suggesting?

What alternatives have you considered?

Additional context

At the moment it is not quite clear why you need to disable the mouse pointer. Would you please describe your scenario in greater detail?
Anyway since the cursor is just an HTML element, use can use the following workaround:
import { ClientFunction } from 'testcafe';

fixture `test`
    .page `http://example.com`
    .beforeEach(async t => {
        await disableCursor();
    });

const disableCursor = ClientFunction(() => {
    var styleElement = document.createElement('style');
    styleElement.innerHTML = '.cursor-hammerhead-shadow-ui { display: none !important }';
    document.head.appendChild(styleElement);
});

test('test', async t => {
...
});

Here, I add CSS to the page before each test starts. Note, since in a general case, it is hard to predict what unexpected results adding this CSS may produce, I suggest that you carefully check this prior to integrating this solution into your project.

Thanks for the solution ....  But actually my scenario is to reduce the size of the Cursor pointer .Can you help me  with this Issue .

You can modify the suggested workaround. Since .cursor-hammerhead-shadow-ui is just an HTML element you can apply any CSS styles including width and height to it.

Thanks Lot :)
On Wed, Nov 21, 2018, 7:26 PM AlexKamaev<EMAIL_ADDRESS>wrote:

Closed #3139 https://github.com/DevExpress/testcafe/issues/3139.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/DevExpress/testcafe/issues/3139#event-1980114926, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ArHBDHJP4HCUjoWRiJ_145EHVZlrKl73ks5uxVt7gaJpZM4YrICY
.

Hi Alex ,Disabling the Mouse Pointer works Fine :)
But reducing the size of the Mouse didn't work with the workaround . I have added the code can you Look into it
import { ClientFunction } from 'testcafe';
import { Selector } from 'testcafe';
fixture test
.page http://example.com
.beforeEach(async t => {
await disableCursor();
})
const disableCursor = ClientFunction(() => {
var styleElement = document.createElement('style');
styleElement.innerHTML = '.cursor-hammerhead-shadow-ui {width:10px; height:40px }';
document.head.appendChild(styleElement);
});
test('test', async t => {
await t.click(Selector('body > div > p:nth-child(3) > a'))
await t.click(Selector('#header > div.navigation > ul > li:nth-child(1) > a'))
});

Add the !important rule as I did in my example to override the existing CSS rules. I think you also need to change background-image to use the pointer image of a smaller size.
I should note that your last questions about CSS are not related to TestCafe. So, I kindly ask you to use StackOverflow  for this kind of questions. If you have a question about TestCafe I also recommend asking it on StackOverflow with the testcafe tag. Please use the following link  for this.


Request to add Traxmate Webhook for TTI Integration

Summary

Creating a webhook template as instructed. (I hope).
Defining token to post to Traxmate capture end-point to visualize devices on Traxmate.
Defining path and required DevEUI to map forwarded message to device and customer on Traxmate.

Changes

Adding Webhook template for Traxmate

Notes for Reviewers
Sorry for the mess :D

...
Checklist

[x] Scope: The referenced issue is addressed, there are no unrelated changes.
[x] Compatibility: The changes are backwards compatible, they don't break existing deployments.
[ ] Testing: The changes are tested.
[ ] Documentation: Relevant documentation is added or updated.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi All!
Could you please help us out here?
Regards,
Yllka Shkupolli Xhemajli
Customer Success Manager
￼
Combain Mobile AB
Ideon Science Park
Scheelevägen 27
223 70 Lund
Sweden
+46-(0)46-288 6 288
Mobile:  +46-(0)76 583 52 56
Email:  @.***
NOTE: Interested in a meeting with me, book it here: https://calendly.com/yllkax
www.combain.com
www.traxmate.io

26 nov. 2023 kl. 19:37 skrev Nejra Selimović @.***>:
@nejraselimovic commented on this pull request.
In traxmate.yml https://github.com/TheThingsNetwork/lorawan-webhook-templates/pull/90#discussion_r1405457551:

+description: Send data to Traxmate via TTI adapter
+logo-url: https://traxmate.io/wp-content/uploads/2023/10/8429011b-92b9-4f53-b9fd-49285d29c437.png
+info-url: https://traxmate.io
+documentation-url: https://traxmate.io/support/getting-started/
+fields:

id: token

name: Servicetoken
description: Traxmate API Servicetoken - found under Settings -> Account
secret: true
+format: json
+headers:
Authorization: Token {token}
+create-downlink-api-key: true
+base-url: https://capture.v1.traxmate.io/capture/{token}
+paths:
uplink-message: /device{/devID}
hey @FieldAppEngineerCombain https://github.com/FieldAppEngineerCombain, sorry for the delay, last time I checked we needed to do a fix on our end to support this. @adriansmares https://github.com/adriansmares what's our status here?

—
Reply to this email directly, view it on GitHub https://github.com/TheThingsNetwork/lorawan-webhook-templates/pull/90#discussion_r1405457551, or unsubscribe https://github.com/notifications/unsubscribe-auth/BDW4NSXWFF7M66BS7BFEO4LYGOD5ZAVCNFSM6AAAAAA6ZRSYPWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONBZGM4TOOJWGA.
You are receiving this because you commented.

Hi again,
I added back the format:json line and updated a header. If it fails again, is it possible to see more extensive error logs or do I need to debug it locally as suggested in the instructions? =)
@adriansmares


MC in JC

Onboarding the new scaled MC into JC

@Gustav-Eikaas this can be closed?

I kept it open for feedback and things worth noting but I have not heard anything. No news is good news

Looks good


Add test for http build cache timeout

Fixing #868 via #2757 also introduces timeouts for connecting to an
HTTP build cache. We just add a test to verify this.
While writing the test I realized that we do not print the real cause
for failing with the HTTP backend when not printing the stack trace,
so I fixed that, too.

@lptr I addressed your feedback, please have another look.


RequestRateLimiter: not available using shortcut configuration

In 2.0.0.M5, adding a RequestRateLimiter as a filter results in a configuration error where the filter cannot be found.
It seems RequestRateLimiterGatewayFilterFactory doesnt override ArgumentHints.argNames(). By adding:
@Override
public List<String> argNames() {
	return Arrays.asList(REPLENISH_RATE_KEY, BURST_CAPACITY_KEY, KEY_RESOLVER_KEY);
}

The rate limiter is available in the filter list and can be used.
Bug ? or something i dont understand ?

After looking at this, REPLENISH_RATE_KEY and BURST_CAPACITY_KEY don't apply to the filter at all. They apply to the specific rate limiter. I'm going to say that the shortcut just doesn't work for this and document that.

spring:
  cloud:
    gateway:
      routes:
      - id: yo
        uri: lb://hello-service
        predicates:
        - Path=/yo
        filters:
        - name: RequestRateLimiter
          args:
            burstCapacity: 2
            replenishRate: 2
            keyResolver: '#{@userKeyResolver}'

This is the configuration I am using since M9 (dont think the documented one is still working):
filters:
  - name: RequestRateLimiter
     args:
       key-resolver: "#{@myKeyResolver}"
       redis-rate-limiter.replenishRate: 1
       redis-rate-limiter.burstCapacity: 5

Another one where I am referencing a ratelimiter (preconfigured) bean:
filters:
  - name: RequestRateLimiter
     args:
       key-resolver: "#{@requestPathKeyResolver}"
       rate-limiter: "#{@tsaRateLimiter}"


Add FARGATE suuport to ECS module

By default we support EC2 lunach type for our service.
We need to allow to run in FARGATE mode.
...
fargate = true
...

https://github.com/Selleo/terraform-aws-ecs/pull/6


feat(v2): createModule plugin API

Motivation
TL;DR: No changes in website functionality
createModule is a plugin actions api in contentLoadeded hooks that allows creating module.
Changes:

Now global metadata such as docsMetadata.json, blogMetadata.json can be async imported instead of globally sync imported as context.
We have less codes (cleaner @docusaurus/core)
Sidebar now appears in SSR even when JavaScript is disabled.
Before

After

Metadata is now namespaced to plugin

Changed how headerlinks work

We have way less bundle size now

Before: main bundle ~ 209 kb

After: main bundle ~ 197kb

Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan

Locally nothing wrong
Production (wait netlify)

I will address the review soon and modify the naming. The reasoning of having to write JSON.stringify is because I was thinking that maybe its not always a .json file, it can be a js file and they might want “export const” instead.
For further API extension, I agree it should be in later PR


CTRL+Z does not kill browsers when using multiples workers

What are you trying to achieve?
Run codeceptjs with workers, then stop it but browsers are not killed.
What do you get instead?
When doing CTRL+Z, the browsers should also be killed.

Provide console output if related. Use --verbose mode for more details.

npx codeceptjs run-workers 2 ./scripts/test.js

Provide test source code if related

Feature('Test');

Scenario('test', async ({I}) => {
	I.amOnPage('https://www.google.com/');
});

Scenario('test2', async ({I}) => {
	I.amOnPage('https://www.google.com/');
});

Details

CodeceptJS version: 3.5.3
NodeJS Version: 18.14.1
Operating System: Ubuntu 20.04
puppeteer
Configuration file:

exports.config = {
  tests: './scripts/*.js',
  output: './logs',
  defaultWait: 120,
  helpers: {
    Puppeteer: {
      url: 'http://localhost',
      highlightElement: true,
      show: true,
      restart: true,
      // keepBrowserState: true,
      // keepCookies: true,
      getPageTimeout: 300000,
      waitForAction: 200,
      waitForNavigation: ['domcontentloaded', 'networkidle0'],
      waitForTimeout: 300000,
      windowSize: '1920x1080',
      // defaultViewport: null,
      chrome: {
        // https://peter.sh/experiments/chromium-command-line-switches/
        args: ['--no-sandbox', '--disable-setuid-sandbox', '--disable-dev-shm-usage', '--window-size=1920,1080'],
        // defaultViewport: null,
        // This line is needed for workers
        executablePath: '/bin/google-chrome',
      },
    }
  },
  plugins: {
    pauseOnFail: {},
    // plugins: {
    //   retryFailedStep: {
    //     enabled: true
    //   }
    // },
    stepTimeout: {
      enabled: true,
      timeout: 120,
      noTimeoutSteps: [
        'amOnPage',
        'screenshot'
      ],
    }
  }
}

Just up to make the bot happy as this issue still happens.

ctrl+c is used to kill a process. It terminates your program. ctrl+z is used to pause the process. It will not terminate your program, it will keep your program in background

Thanks, it was a typo in the title and description. As you can see I try CTRL + Z from the screenshot it's ^C, but it does not close the browsers when using "run-workers", it does close the browser when using "run".
I don't know why but it is easy to reproduce as per first post.
Should I edit or create new issue? Or this is the behavior to not close the browser with CTRL + C when running with workers?


Add support for certain AVR platforms

This firmware is confirmed to work on an Atmega328P/Arduino Uno R3 but should work on any Atmega328/1280/2560/16u2/32u4 as many of the timer settings are the same on there.
Serial and hardware revision info is stored in EEPROM internal to the board. UID detection is achieved through die serial info, and the software just grabs 8 bytes from it.
With the minor modification to the KFDtool software regarding serial port selection, the AVR firmware is 100% compatible with the KFDtool software. The extra bit about the KFD-AVR model is not necessary; I put that in there to help with identifying which board I was using during testing.
See the forum post for more info: https://communications.support/threads/kfdtool-discussion-thread.16267/post-143129

Closing, part of KFDShield
https://github.com/omahacommsys/KFDTool


Upgrades: Verify that our plays are correctly setup to skip steps that are not necessary

When upgrading a node, it's possible that some component versions remained the same. For example, a kismatic release might ship a new version of K8s, but the same version of Docker.
We would like to use ansible's built-in capabilities of only taking action when there is a change that needs to be performed. For example, if ansible detects that the docker package did not change, we can skip restarting docker.

We fixed this in other PRs.


/api/stations returns incorrect parameter for Wayne

Using "Wayne Station" ✅
Using "Wayne" 🚫

I'm not sure of this is a new issue?
https://www3.septa.org/VIRegionalRail.html shows the parameter as being "Wayne", which I realize is the source of this error.
Interestingly:

The iOS mobile app can show next-to-arrive info for Wayne.
https://plan.septa.org/ cannot find a Regional Rail route between Wayne and other stations.

I ran a script to check every station and only Wayne caused this error.

Good catch! I'm assuming this is in reference to https://septum.jawn.website/api/stations returning the wrong parameter name for Wayne?
I looked at the requests the iOS app was making they're (naturally) using an internal only API with station IDs instead of names. So next-to-arrive working for the iOS app unfortunately does not help.
I can manually add an override for Wayne in Septum so it returns Wayne Station as the parameter name. That does however feel very brittle, but I'm not sure we have a way to reach out to Septa to fix that web page.

I'm assuming this is in reference to https://septum.jawn.website/api/stations returning the wrong parameter name for Wayne?

Yep.
I did a bit more digging and found that this page might be the better one to scrape for station names: https://app.septa.org/nta/.
In particular, this element: #septa_main_content select[name='loc_a'] seems to contain the names and parameters we'd want.
Here are the differences between that and the current data source:
Parameters

app.septa.org/nta/
www3.septa.org/VIRegionalRail.html

Jefferson Station
Market East

Wawa
not included

Wayne Station
Wayne

I tested each of the new parameters from app.septa.org/nta/ and they see to work.
Names

app.septa.org/nta/
www3.septa.org/VIRegionalRail.html

9th Street
9th Street Station

30th Street
30th Street Station

Airport Terminal C-D
Airport Terminals C & D

Airport Terminal E-F
Airport Terminals E & F

Churchmans Crossing, DE
Churchmans Crossing

Claymont, DE
Claymont

Eastwick
Eastwick Station

Elm Street-Norristown
Elm Street, Norristown

Fernwood-Yeadon
Fernwood–Yeadon

Jefferson Station
Jefferson Station (Market East)

Main Street-Norristown
Main Street, Norristown

Mt. Airy
Mount Airy

Newark Station
Newark

Noble Station
Noble

Wawa
not included

West Trenton, NJ
West Trenton

Wilmington, DE
Wilmington

Thank you for looking into it further! The new page does seem promising.
It is odd to me that Market East and Jefferson Station are valid inputs to /api/NextToArrive. For example:

https://www3.septa.org/api/NextToArrive/index.php?req1=Market%20East&req2=North%20Philadelphia
https://www3.septa.org/api/NextToArrive/index.php?req1=Jefferson%20Station&req2=North%20Philadelphia

Both work and return the same results.
In either case, https://app.septa.org/nta/ seems to be the more correct version for now. The changes look pretty easy so I'll make them and once I can test them with tst, I'll push a release to Septum as well!
Thank you for your help :)


Incorrect documentation for helm without rbac

[Enter feedback here]
The command to run is
helm install stable/nginx-ingress --namespace kube-system --set rbac.create=false --set rbac.createRole=false --set rbac.createClusterRole=false

NOT  (what is in the documentation)
helm install stable/nginx-ingress --namespace kube-system --set rbac.create=false

Running without the arguments --set rbac.createRole=false --set rbac.createClusterRole=false will result in an error.
Tested on AKS running kubernetes 1.10.3

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ada58160-dc50-b977-d3bc-65f92406e16d
Version Independent ID: 5c596e04-fddb-effe-3b72-575f4df42d4e
Content: Configure ingress with Azure Kubernetes Service (AKS) cluster
Content Source: articles/aks/ingress.md
Service: container-service
GitHub Login: @iainfoulds
Microsoft Alias: iainfou

@pdeva Thanks for your feedback! We will investigate and update as appropriate.

@iainfoulds could you take a look at this and confirm?

Hi, @pdeva. Sorry you ran into issues. Where are you encountering errors, and what's the error message?
I've ran through this doc using a fresh 1.9.6 and a fresh 1.10.3 cluster, both without RBAC enabled, and I successfully have the ingress controller routing to the two services, with Let's Encrypt providing certificates. That's just with the following helm install command for the non RBAC clusters, as per the doc:
helm install stable/nginx-ingress --namespace kube-system --set rbac.create=false
Helm version 2.9.1
#in-progress

FYI, I successfully run the command as shown in the doc in my 1.10.3 cluster.

Hi, @pdeva. Are you still encountering issues, can you share what errors are displayed when you try to deploy this solution?

Hi, @pdeva. Are you still having issues? I haven't been able to replicate the issue you encountered. Can you confirm your Helm version and share any errors in the output? Otherwise we can close this out and re-open if it comes up again.


What are the options for setting and modifying metadata at any time?

Hey,
So I'd like to attach the contents of a shopping cart object to my bugsnag crash reports. This cart object is loaded from async storage into my redux state just after opening the app, and is later modified during use of the app. So I would like to add the cart to metadata after it is retrieved from storage, then everytime it is modified update the metadata.
Am I correct in assuming that the usage of the code below is only 1 time at the beginning of the app?
const config = new Configuration();
config.registerBeforeSendCallback((report, error) => {
  // add your custom metadata here
 report.metadata = {
    ...report.metadata, // merge existing metadata that could have been added by other callbacks
    extra: {"cart": this.state.cart}
  }
});
const bugsnag = new Client(config);

It seems that something like bugsnag.setUser() would be easier for something like this, but there aren't other options that are similar (that I know of)
What are my options here?

@rtman those assumptions look correct. config.registerBeforeSendCallback should only need to be specified once during app initialisation, and will then be invoked for each error reported via Bugsnag. In your example, I believe it'd be possible to write your own code to update this.state.cart when necessary, and the attached metadata for each report should show the updated value.
There are some docs which go into more detail on how this works, here, and explain some callback options if you only want to modify one specific error report.
Hopefully that should resolve your issue - please let us know if that's not the case and I'll reopen this ticket.

@fractalwrench
I read through that docs page already and came a way slightly confused.
The registerBeforeSendCallback is a function that runs before an error report is generated when a crash is detected right? So that means if this.state.cart is being modified it will have the current contents of that variable and not what was set at the beginning of the app when the code block (below) was set?
const config = new Configuration();
config.registerBeforeSendCallback((report, error) => {
  // add your custom metadata here
 report.metadata = {
    ...report.metadata, // merge existing metadata that could have been added by other callbacks
    extra: {"cart": this.state.cart}
  }
});
const bugsnag = new Client(config);

Another thing to keep in mind is that this.state.cart is a redux state variable, so it is not necessarily available on every screen in the app. Does this matter? I'm thinking of situations where a crash happens on a screen without access to this.state.cart, will this cause problems?

Yes the callback is run when an error is generated, so it will take the values at the time the function is run, rather than when it was set. If the redux state is not set on certain screens you can either not set the callback on those screens, or defensively program against it not being set in the callback as you see fit.

great thanks @snmaynard

I'm still having issues with this, can you guys help me with code examples?
Here is what I'm trying:
import { connect } from 'react-redux';
import { bindActionCreators } from 'redux'
import { ActionCreators } from '../Actions'
import { Client, Configuration } from 'bugsnag-react-native';

const config = new Configuration();
config.registerBeforeSendCallback((report, error) => {
  // add your custom metadata here
  if(this.props && this.props.cart){
    report.metadata = {
      ...report.metadata, // merge existing metadata that could have been added by other callbacks
      extra: {"cart": this.props.cart}
    }
  }
})
const bugsnag = new Client(config);

export class ShoppingCartScreen extends React.Component {
  constructor(props){
    super(props)
  }
  componentDidMount(){
     bugsnag.notify(new Error("Test Cart error"));
  }
  render(){
  ...
  }
}

//redux

function mapDispatchToProps(dispatch) {
  return bindActionCreators(ActionCreators, dispatch);
}

function mapStateToProps(state) {
  return {
    cart: state.cart,
    sectionedCart: state.sectionedCart
  };
}

export default connect(() => mapStateToProps, mapDispatchToProps)(ShoppingCartScreen);

If I have the if statement in the config callback, the test error works fine but there is no meta data. If I remove the if statement then I get undefined is not an object (evaluating _this.props.cart). Am I initializing this at the wrong time? This screen definitely has access to the redux store and this.props.cart

What are you expecting this to be in the callback? If you are expecting it to be this outside of the callback I would recommend adding a _this = this or something to bind _this to that value.

@snmaynard

I would recommend adding a _this = this or something to bind _this to that value.

OK but can you provide a code example? I dont fully understand how this would work with the code above.
I just want bugsnag to have access to variables in my redux state. If there is a recommended way to do this please let me know. I am just beginning with bugsnag and after reading the docs I'm still confused as to how to achieve this.


Route parsing issue

Hi @naoina,
Thanks for making denco available, we have been using denco intensively for our critical application in production, and it does the job very well.
Recently, we found inconsistent parsing for multiple dynamic segments path. Here's the gist:
package main

import (
	"fmt"

	"github.com/naoina/denco"
)

type route struct {
	name string
}

func main() {
	router := denco.New()
	router.Build([]denco.Record{
		{"/stock-adjustments/lines", &route{"adjust-xx"}},
		{"/stock-adjustments/lines/upload", &route{"adjust-up"}},
		{"/stock-adjustments/lines/:id", &route{"adjust-id"}},

		{"/stock-adjustments/:stock-adjustment-id/lines", &route{"lines-xx"}},
		{"/stock-adjustments/:stock-adjustment-id/lines/upload", &route{"lines-up"}},
		{"/stock-adjustments/:stock-adjustment-id/lines/:id", &route{"lines-id"}},
	})

	data, params, found := router.Lookup("/stock-adjustments/123/lines")
	fmt.Printf("%#v, %#v, %#v\n", data, params, found)

	data, params, found = router.Lookup("/stock-adjustments/123/lines/456")
	fmt.Printf("%#v, %#v, %#v\n", data, params, found)

	data, params, found = router.Lookup("/stock-adjustments/123/lines/upload")
	fmt.Printf("%#v, %#v, %#v\n", data, params, found)

	data, params, found = router.Lookup("/stock-adjustments/lines")
	fmt.Printf("%#v, %#v, %#v\n", data, params, found)

	data, params, found = router.Lookup("/stock-adjustments/lines/456")
	fmt.Printf("%#v, %#v, %#v\n", data, params, found)

	data, params, found = router.Lookup("/stock-adjustments/lines/upload")
	fmt.Printf("%#v, %#v, %#v\n", data, params, found)
}

// OUTPUT
//
// &main.route{name:"lines-xx"}, denco.Params{denco.Param{Name:"stock-adjustment-id", Value:"123"}}, true
// &main.route{name:"lines-id"}, denco.Params{denco.Param{Name:"stock-adjustment-id", Value:"123"}, denco.Param{Name:"id", Value:"456"}}, true
// &main.route{name:"lines-id"}, denco.Params{denco.Param{Name:"stock-adjustment-id", Value:"123"}, denco.Param{Name:"id", Value:"upload"}}, true
// &main.route{name:"adjust-xx"}, denco.Params(nil), true
// &main.route{name:"adjust-id"}, denco.Params{denco.Param{Name:"id", Value:"456"}}, true
// &main.route{name:"adjust-up"}, denco.Params(nil), true

Any idea?

@subosito Thank you for reporting. I fixed it by commit https://github.com/naoina/denco/commit/17647e04014d51779812ae62913197cb5c7999c5. Please let me know if you still have any problems.

Awesome! thanks @naoina :+1:


Spanner batch across multiple tables and operations

We could implement functions similar to python's batch to perform batch operations data across tables and operations:
One possibility is something like this (there are a lot of ways this could be implemented):
$database->batch()
    ->insert('github_users', [
        ['name' => 'Brent', 'username' => 'bshaffer'],
        ['name' => 'Jon', 'username' => 'jdpedrie'],
    ])
    ->replace('github_repos', [
        ['owner' => 'bshaffer' 'name' => 'php-stuff'],
        ['owner' => 'Google', 'name' => 'google-stuff'],
    ])
    ->commit();

This could be a wrapper for:
$database->startBatch();
$database->insert('github_users', [
    ['name' => 'Brent', 'username' => 'bshaffer'],
    ['name' => 'Jon', 'username' => 'jdpedrie'],
]);
$database->replace('github_repos', [
    ['owner' => 'bshaffer' 'name' => 'php-stuff'],
    ['owner' => 'Google', 'name' => 'google-stuff'],
]);
$database->commitBatch();

Or the transaction format could be used, although the syntax isn't as clear:
$database->batch(function(Database $d) {
    $d->insert('github_users', [
        ['name' => 'Brent', 'username' => 'bshaffer'],
        ['name' => 'Jon', 'username' => 'jdpedrie'],
    ]);
    $d->replace('github_repos', [
        ['owner' => 'bshaffer' 'name' => 'php-stuff'],
        ['owner' => 'Google', 'name' => 'google-stuff'],
    ]);
});

We have something very similar to option 1 with Database::transaction().
$database->transaction(['singleUse' => true])
    ->insert('table', [
        'key' => 1, 'name' => 'Billy'
    ])
    ->replace('table2', [
        'id' => 2, 'name' => 'Bob'
    ])
    ->commit();

WDYT about having a batch method return a transaction under the hood and have it set singleUse to true for you by default?
public function batch()
{
    return $this->transaction(['singleUse' => true]);
}

This is perfect!! The batch method may be useful, but it also may be confusing since we're using batch to essentially mean singleUseTransaction. Honestly, I'm not sure what the difference is, but I don't think the extra method is necessary as long as we document it in samples, etc.


tools: present nicer error for missing packaging

This makes the error more user friendly and suggests what to do to fix it.
@TSC21 I beat you to it :smile:.
Fixes #14554.

This makes the error more user friendly and suggests what to do to fix it.
@TSC21 I beat you to it .
Fixes #14554.

Sorry I should have fixed this yesterday. Thank you


visualization compression

dprof could probably be made significantly easier to use (read: search through) in many situations by simply compressing long time periods in which nothing changes.

Yes, I think we need to be able to zoom in on the overview too.


null safety

No description provided.

You are best, dude

No description provided.

You are best, dude

No description provided.

You are best, dude


Map settings

@wrandall22 here are the settings. I should have included this with my last PR.

Looks good to me.

Thanks


Use Date.now() for timestamp

As discussed in https://groups.google.com/forum/#!topic/elm-dev/RU2ZZqDFOwU
For the reference of those who are new to the discussion, performance.now() and the timestamp  passed to requestAnimationFrame are High Resolution Timestamps. There are two things to note about these types of timing information:

They are read from a separate clock than Date.now()
Even though they are in theory supposed to be relative to performance.timing.navigationStart, this is not reliable over long periods of time and these timestamps are only for measuring relative to each other.

Below is a screenshot I took of how drastically different the two methods of reading the current time can become in Firefox:

To avoid situations where we are comparing two things that aren't supposed to be compared and cause problems like #6 we can just use Date.now() and still get very smooth animations even though we don't have that 5μs accuracy.
Alternatives to this approach are:

Add a new task to Native.AnimationFrame for getting performance.now() and use that as the initial stamp for diffs, and then succeed with both Date.now() and the high res stamp within rAF. This would allow diffs to continue to be high-res and times wouldn't end up being inaccurate.

Pros: diffs is still high-res
(::): code becomes a bit more complicated

Remove times altogether

Pros: the inaccurate thing is no longer inaccurate because it doesn't exist
(::): the API changes, and people who were using times have to figure something else out

Let's go with this approach, and then we can assess fancier things once folks show up needing higher resolution times for a particular use case.


Feature Request:- To know the number of rows present in the grid

Could you please add a feature to know the number of rows present in the grid?

please check the forum, this question has already been asked.
there is an api:
api.getRowModel().getVirtualRowCount()

Thanks @ceolter


Attempting to uninstall package complains about invalid manifest.xml

Brief description of your issue
Media Player (previously Groove Music, Zune Music) recently stopped working on my machine. Updates via Microsoft Store are failing, and Repair/Reset didn't help.
Trying to uninstall the problematic package via winget complains about an invalid manifest, with no apparent way to force uninstall.
Steps to reproduce
Somehow get a UWP package to break, here Media Player.
Execute in terminal:
winget uninstall Microsoft.ZuneMusic_8wekyb3d8bbwe
Expected behavior
Package should get uninstalled.
Actual behavior
This error is thrown, and I am left with no way to remove the problematic package:
An unexpected error occurred while executing the command:
Operation failed: error 0xC00CEE04: App manifest validation error: The app manifest XML must be valid: Line 1, Column 4, Reason: Unrecognized input signature.

0x80080204 : The Appx package's manifest is invalid.

Environment
Windows Package Manager (Preview) v1.2.3411-preview
Windows: Windows.Desktop v10.0.22523.1000
Package: Microsoft.DesktopAppInstaller v1.17.3411.0

What happens when you run: Get-AppxPackage -Name Microsoft.ZuneMusic_8wekyb3d8bbwe | Remove-AppxPackage in PowerShell?
If you're getting the same error, it's highly unlikely you'll be able to uninstall it through WinGet because WinGet runs Remove-AppxPackage for any appx packages you want to uninstall.
Have you tried downloading it from https://store.rg-adguard.net?

Choose PackageFamilyName in the drop-down menu
Write Microsoft.ZuneMusic_8wekyb3d8bbwe in the textbox
Select Fast as your Ring.

The command leaves no output in the terminal.
I have indeed tried to reinstall with the msixbundle, and have gone so far as to try deleting the actual folder for ZuneMusic in the Packages folder. Trying to install the msixbundle with App Installer results in the same error code.
My goal here is to get a working Media Player installation again.

The command leaves no output in the terminal.

Oops.
I meant Get-AppxPackage -Name Microsoft.ZuneMusic | Remove-AppxPackage without the _8wekyb3d8bbwe part.

I have indeed tried to reinstall with the msixbundle, and have gone so far as to try deleting the actual folder for ZuneMusic in the Packages folder. Trying to install the msixbundle with App Installer results in the same error code.

I'm not entirely sure how you're into this state, but have you tried to reinstall Windows 11 build 22523 from an ISO image on top of your current Windows 11 build 22523?
If that doesn't work, I'm afraid that you'll have to clean install Windows.

without the _8wekyb3d8bbwe part.

Remove-AppxPackage: Deployment failed with HRESULT: 0x80080204, The Appx package's manifest is invalid. error 0xC00CEE04: App manifest validation error: The app manifest XML must be valid: Line 1, Column 4, Reason: Unrecognized input signature.

I did boot the ISO, but couldn't find the option to reinstall while preserving data. Choosing the "Repair" option just dropped me into Windows Recovery, and choosing to use a device for recovery and selecting the USB simply rebooted my laptop. Can't I manually delete/modify any file(s) to force Microsoft Store / winget to (re)install Media Player?

I did boot the ISO, but couldn't find the option to reinstall while preserving data.

You have to mount the ISO and run setup.exe.
There should be an option to reinstall and keep everything.

Can't I manually delete/modify any file(s) to force Microsoft Store / winget to (re)install Media Player?

I don't know if that would work as I have never tinkered around with the WindowsApps folder.
If you've tried to remove it manually from C:\Program Files\WindowsApps and it's not working, then launching setup.exe and letting it do its job would probably fix it?

I have the same problem with the Windows Subsystem for Android package. It broke after a Windows update and now when I try to reinstall or remove it, it always throws this error.
App installation failed with error message: error 0xC00CEE04: App manifest validation error: The app manifest XML must be valid: Line 1, Column 4, Reason: Unrecognized input signature. (0x80080204)

Tried to do an in-place upgrade, tried sfc /scannow, DISM, etc., but nothing helped so far. Where could I have more information about this error? It's mentioning a manifest file, but why is a manifest file required for uninstalling the package? Is there a way to force-remove it by just deleting all the files? I tried to delete the folder in Program Files/WindowsApps, but it sill shows as installed, so it must be registered somewhere else as well. Any help would be very much appreciated.

Messing with the WindowsApps folder is not advised. That error isn't coming from winget, its coming from the App Package Installer. For some reason, it doesn't like part of the manifest XML for the app. I do not remember off hand where it is stored, but you might have complicated things for yourself by deleting the apps folder.

Sorry for the delay, didn't have much time recently to look into it.
I found the manifest file in C:\Program Files\WindowsApps\MicrosoftCorporationII.WindowsSubsystemForAndroid_2210.40000.7.0_x64__8wekyb3d8bbwe\AppxManifest.xml. Do you know where I can get more information on what is wrong in this file? What is the signature that's invalid? How can I uninstall this package without checking the signature (why is signature check needed anyway for just deleting an app from my system, wouldn't it make sense to allow uninstalling apps that have the wrong signature instead of forcing me to keep it)?
Any further information on why this issue can happen would be very helpful.

Hey all, we've added a new "repair" command to WinGet. It's designed to repair packages that are behaving badly. If someone is in this state, could they try it out and let me know if that addresses the problem?


chore: [DO NOT MERGE] patch for prqlc 0.13.0 MSRV 1.69.0

Supersede #4001
The only problem seemed to be #4627

The MSRV-aware resolver appears to be very good.
If this feature had not been implemented in cargo, I would not have done this work to lower MSRV.......
I submitted PRQL/prqlc-r#315 to CRAN.

Awesome!


Add IP addresses to linkify

Fixes #91

The fact that the invalid port IP address is still matched is to do with the current negatedPathCharacterSet, it will linkify :http://www.google.com: too.

Shall we put the port clause after either host, or IP? This would make more sense IMO.
Thanks for the contribution 🎆

@akalipetis done

+tests

LGTM, thanks a lot!


TypeError when replying with JSON if delay is set.

This is throwing a type error.
nock('http://rcsm.com')
    .get('/services/')
    .delayBody(200)
    .reply(function() {
      return {}
    });

request.get('http://rcsm.com/services/', function( err, responseBody, body){
  console.log(err) // [TypeError: Invalid non-string/buffer chunk]
})

It works fine w/o the delay applied.

@jiggliemon I've added this test to master and it seams to be passing...
What nock version are you using?

Closing this one for lack of feedback.
Please reopen if you can add more info.

I ran into this with 9.0.2. The fix was to either return a readable stream from the function or handle the delay yourself with a timeout and the callback response approach.

I'm also having the same issue (node 6.10.1, nock 9.0.11).
Using axios to make the request, the combination of delayBody + reply(fn) triggers a Invalid non-string/buffer chunk error:
nock('http://timestamp.com')
  .get('/')
  .query(true)
  .delayBody(100)
  .reply(200, (uri, b) => Date.now())
  .persist();

axios.get('http://timestamp.com/')
  .then((resp) => {})
  .catch((err) => console.log(err));

TypeError: Invalid non-string/buffer chunk
    at validChunk (_stream_writable.js:216:10)
    at DelayedBody.Writable.write (_stream_writable.js:245:12)
    at DelayedBody.Writable.end (_stream_writable.js:480:10)
    at Timeout._onTimeout (./node_modules/nock/lib/delayed_body.js:72:12)
    at ontimeout (timers.js:380:14)
    at tryOnTimeout (timers.js:244:5)
    at Timer.listOnTimeout (timers.js:214:5)


Rust/rusty: Put 'unsafe' keyword in function prototypes

From discussions on GitHub, people would like to see (besides a more idiomatic Rust API) the Rust functions more explicitly marked as 'unsafe'.
Uplift 'unsafe' from the function body into the function prototype.
Link: https://github.com/nginx/unit-wasm/issues/25

Scratch this idea. It would mean you'd need to wrap every call to a rusty function in unsafe { }. Nah...


Migration of Character Controller to R3

Migration of Character Controller to R3 from UniRx
Added R3 package (inlcuding NuGet plugin), removed UniRx
Update README and Changelog files to reflect changes (new version v0.1.0).

Also required merge from martin--develop-upm to upm/upm-raw


wireless card not found on kali subsystem

I've just intalled the KALI subsystem on WIN10 , but i can't access my wireless card on aircrack-ng , any solution please ? or I have to wait for a real update from MS ?

aircrack-ng will want rather low-level access to your hardware (https://www.aircrack-ng.org/doku.php?id=compatibility_drivers)
WSL, by design, will not ever give you that.
Just use the native Windows version of aircrack-ng on Windows (https://www.aircrack-ng.org/downloads.html)

#2932 #1104 and friends.

WSL, by design, will not ever give you that.

Nah I bet it could be made to work. Just not worth the effort because aircrack-ng for Windows.

Does it work now?

It's will never work, isn't it?


No video shows up

QuickTime sees this plugin and will even display the correct frame size but will not show any video. I suspect it's a timestamp/clock issue. It might also be a video format issue.

Solved with https://github.com/johnboiles/coremediaio-dal-minimal-example/commit/00fd8e0395a0d587758467790671fdd1130864d7


cloudapi: Add module_hotfixes flag

Allow passing module_hotfixes flag through the cloudapi. This will enable depsolving on repositories that might be affected by modularity filtering.
Refs HMS-3202
Needs https://github.com/osbuild/images/pull/284 to have this flag on all the repositories.
:warning: currently this includes osbuild/images bump, which we want to wait for the release I'm guessing, but apart of that, this is ready for review :)

I think that it would be good to enable this repo setting also for user-defined sources (repos) on-premise. This means extending:
https://github.com/osbuild/osbuild-composer/blob/main/internal/store/store.go#L59
https://github.com/osbuild/osbuild-composer/blob/main/internal/store/store.go#L622
https://github.com/osbuild/osbuild-composer/blob/main/internal/weldr/json.go#L138
https://github.com/osbuild/osbuild-composer/blob/main/internal/weldr/json.go#L203
Without this, one won't be able to define 3rd party repos with this option set, which are used for the actual image build. They could only embed repo definitions inside the final image with the option set (this is handled by the BP customization).

All FIPS tests failure has been fixed by PR #3849. Could you please make a rebase? Thanks.

All edge-simplified test failure is not caused by this PR. Issue has been fixed by PR #3854

@thozza can you check out the vsphere failures if you see something in there? https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/pipelines/1109228638 I can't figure out what's the issue.
The good news is we seem to be quite close :stuck_out_tongue:

Thank you for guiding me @thozza ! :+1:


Remove special umbrella class

Apart from providing access to settings, this didn’t provide any extra value. And since we’re looking to move to an arrangement where settings are provided via a bootable dependency, we don’t need this anymore.

@timriley we will have to update dry-web-roda ? Since container inherited from this class.

@GustavoCaso Yep, we'll need to coordinate the next releases of dry-web and dry-web-roda. I'm interested in holding them both back a little to see if I can get a few different features in at the same time.

@timriley that sounds great


Regenerate assets.go file

Description
It looks like our generated assets.go file reverted back to some old formatting (based on an earlier go-bindata version) in #2891.  We fixed the formatting in #2888 and put a version check for go-bindata in with #2889, so all this stuff landed about the same time.  I was getting a local diff on this, so this PR just regenerates the file with a recent go-bindata version.
Setup
Do a make clean server_generate and verify that git status shows no local changes.
Code Review Verification Steps

[ ] Request review from a member of a different team.

@reggieriser thanks for noticing (and fixing) this... sorry for the extra work...


Add clock_gettime shim

r? @oli-obk
I think there is no way to do proper testing of this other than checking that miri does not crash when calling clock_gettime.

Also I'm not sure what to do if the current time is lower than UNIX_EPOCH, which might happen if someone decides to mess with the clock before running miri.

You could calculate the opposite difference (UNIX_EPOCH-now) and then write a negative number, as clock_gettime returns a signed int.

Also I'm not sure what to do if the current time is lower than UNIX_EPOCH, which might happen if someone decides to mess with the clock before running miri.

You could calculate the opposite difference (UNIX_EPOCH-now) and then write a negative number, as clock_gettime returns a signed int.

That sounds like a good idea. I'll try to do that

Also CI is failing because the size of long and time_t is platform dependent. How should I handle that?

:umbrella: The latest upstream changes (presumably #977) made this pull request unmergeable. Please resolve the merge conflicts.

:umbrella: The latest upstream changes (presumably #983) made this pull request unmergeable. Please resolve the merge conflicts.

Yeah this looks good, thanks a lot. :)
@bors r+

:pushpin: Commit f9c768864a7784c518b6ac1af6515950c6eff6ec has been approved by RalfJung

:hourglass: Testing commit f9c768864a7784c518b6ac1af6515950c6eff6ec with merge 5d66fb4650a843a3ec2f8994a116145e14fc7e3d...

That push aborted landing the PR I think.
@bors r+ retry

:pushpin: Commit f9c768864a7784c518b6ac1af6515950c6eff6ec has been approved by RalfJung

:hourglass: Testing commit f9c768864a7784c518b6ac1af6515950c6eff6ec with merge d902a1157571cc9c34fff14f927b805bb18f6a53...

:sunny: Test successful - checks-travis, status-appveyor
Approved by: RalfJung
Pushing d902a1157571cc9c34fff14f927b805bb18f6a53 to master...

Thank you, I did a commit to the wrong branch by accident D:


Code cleanup and various features/fixes

Switch logging entirely to rich logging.
Separate environments for UI and CLI
Add progress bars to sequences
Code cleanup and refactoring

Hello @antrikshmisri! Thanks for opening this PR.

In the file checkpoint/sequences.py:

Line 149:101: E501 line too long (105 > 100 characters)
Line 161:101: E501 line too long (115 > 100 characters)

Do see the Hitchhiker's guide to code style

Codecov Report

Merging #37 (56dbc3d) into master (be18c01) will increase coverage by 1.29%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
+ Coverage   86.54%   87.83%   +1.29%
==========================================
  Files           7        8       +1
  Lines         587      633      +46
  Branches      107      113       +6
==========================================
+ Hits          508      556      +48
+ Misses         64       59       -5
- Partials       15       18       +3

Impacted Files
Coverage Δ

checkpoint/__main__.py
0.00% <ø> (ø)

checkpoint/readers.py
78.21% <40.00%> (-9.74%)
:arrow_down:

checkpoint/sequences.py
93.60% <87.23%> (+6.05%)
:arrow_up:

checkpoint/utils.py
93.05% <88.23%> (-2.40%)
:arrow_down:

checkpoint/__init__.py
100.00% <100.00%> (ø)

checkpoint/constants.py
100.00% <100.00%> (ø)


cinnamon: gpaste-reloaded applet not working

Describe the bug
gpaste applet is not working in cinnamon, even with programs.gpaste.enable = true; set
Steps To Reproduce
Steps to reproduce the behavior:

Enable cinnamon, install gpaste reloaded applet
Enable gpaste: programs.gpaste.enable = true;
Reboot, add gpaste applet

Expected behavior
GPaste applet works as expected
Screenshots

Additional context
I added debug logging and the error is Error: Requiring GPaste, version none: Typelib file for namespace 'GPaste' (any version) not found
Adding     services.xserver.desktopManager.cinnamon.sessionPath = [ pkgs.gnome.gpaste ]; did not fix the issue
I think something needs to be added to programs/gpaste.nix to allow gpaste to work under cinnamon
Notify maintainers
@bobby285271

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

system: "x86_64-linux"
host os: Linux 6.1.68, NixOS, 24.05 (Uakari), 24.05.20231221.e78adfb
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.18.1
nixpkgs: /nix/store/drrjh9wcwlrk2l8zgxsiybrlh39285xc-source

Add a :+1: reaction to issues you find important.

Adding     services.xserver.desktopManager.cinnamon.sessionPath = [ pkgs.gnome.gpaste ]; did not fix the issue

Hmmm, does not really use any of the spices applets, might take me a while to actually test. Does sessionPath actually work right now?
https://github.com/NixOS/nixpkgs/blob/afadc52e8084f5d072115ca19ace1f6e662897a1/nixos/modules/services/x11/desktop-managers/cinnamon.nix#L83
I wonder if it should be... X-Cinnamon

Does sessionPath actually work right now?

Changing the mentioned line to:
      services.xserver.displayManager.sessionCommands = ''
        if test "$XDG_CURRENT_DESKTOP" = "X-Cinnamon"; then
            echo "Yesssssssssssssssssss!!!!!!!!!!!!!!"
            true
            ${concatMapStrings (p: ''
              if [ -d "${p}/share/gsettings-schemas/${p.name}" ]; then
                export XDG_DATA_DIRS=$XDG_DATA_DIRS''${XDG_DATA_DIRS:+:}${p}/share/gsettings-schemas/${p.name}
              fi

              if [ -d "${p}/lib/girepository-1.0" ]; then
                export GI_TYPELIB_PATH=$GI_TYPELIB_PATH''${GI_TYPELIB_PATH:+:}${p}/lib/girepository-1.0
                export LD_LIBRARY_PATH=$LD_LIBRARY_PATH''${LD_LIBRARY_PATH:+:}${p}/lib
              fi
            '') cfg.sessionPath}
        else
            echo "Nooooo!!!!!!!!, value is $XDG_CURRENT_DESKTOP"
        fi
      '';

Then build nixosTests.cinnamon, I got

So looks like XDG_CURRENT_DESKTOP is even not set when we run those lines.

Asking it to print env instead, I guess we probably have workarounds here

I PR the changes.
For a solution without sessionPath, I imagine some day we package Cinnamon spices applets like GNOME and do something like https://github.com/search?q=repo%3ANixOS%2Fnixpkgs prepend_search_path&type=code :zzz:


As a user, I want a landing page for Telescope context objects

Checked for duplicates
Yes - I've already checked
🧑🔬 User Persona(s)
Data user
💪 Motivation
...so that I can display this information to a user
📖 Additional Details
No response
Acceptance Criteria
Given a context object urn:nasa:pds:context:telescope:arecibo.305m
When I perform go to https://pds.nasa.gov/ds-view/pds/viewContext.jsp?identifier=urn:nasa:pds:context:telescope:arecibo.305m
Then I expect a page to display for that context object
⚙ Engineering Details
No response
🎉 I&T
No response

closed per #36


Angular 9 problem loading SVG

Hello,
I'm trying to migrate an angular 8 project, everything was working on ng8 but once I updated to ng9 not a single SVG is loading.
Here is what I have into imports in app.modules:
		AngularSvgIconModule.forRoot({
			loader: {
				provide: SvgLoader,
				useFactory: exportSvgStaticLoader,
				deps: [ HttpClient, TransferState ],
			},
		}),

And the loader:
export function exportSvgStaticLoader(http: HttpClient, transferState: TransferState) {
	return new SvgBrowserLoader(transferState, http);
}

export class SvgBrowserLoader implements SvgLoader {

	constructor(private transferState: TransferState,
				private http: HttpClient) {
	}

	public getSvg(url: string): Observable<string> {
		console.log(url);
		const key: StateKey<number> = makeStateKey<number>(getSvgKey(url.substr(url.lastIndexOf('/'))));
		const data = this.transferState.get(key, null);

		// First we are looking for the translations in transfer-state, if none found, http load as fallback
		if (data) {
			return Observable.create(observer => {
				observer.next(data);
				observer.complete();
			});
		} else {
			return new SvgHttpLoader(this.http).getSvg(url);
		}
	}
}

Problem is that the getSvg doesn't receive a string, it now receive a node module http://localhost:5000/[object Module].
Which give a 404 with:
HttpErrorResponse {headers: HttpHeaders, status: 404, statusText: "Not Found", url: "http://localhost:5000/[object%20Module]", ok: false, …}

any idea how to fix this ?

Apparently loading SVG file with required is not supported anymore on NG9, I was using this to load images. I removed it and it works nicely :) sorry for the noise


Add helm chart dependency on Tekton pipelines

Adding a conditional dependency of flow helm chart to tekton-pipelines cdf helm chart.
Changelog
New

Adding tekton dependency

Changed

NA

Removed

NA

Testing / Reviewing
Tested on our local env.

Closing as this content has made it into another PR


broken emails should not break XML

For some reason we sometimes may have something instead of valid emails in Git logs. Let's filter them out so that they don't break the XML.

Job gh:yegor256/pdd#85 is in scope.

Job gh:yegor256/pdd#85 assigned to @tedtoer. The budget is fixed and it is 30 minutes. Please, read the Policy and go ahead.

@tedtoer this job was assigned to you 5 days ago. It will be taken away from you soon, unless you close it, see par.8.

@tedtoer resigned from gh:yegor256/pdd#85, please stop working.

The job #85 assigned to @rok-povsic/z, here is why. The budget is 30 minutes, see §4. Please, read §8 and §9. If the task is not clear, read this and this.

@yegor256 Can you please give an example of a log where this occurs?

@rok-povsic try this, in an empty local Git repo:
$ git config user.email 'hello, world!'
$ touch x
$ git add x
$ git commit -am 'test'
[master (root-commit) b07c472] test
 1 file changed, 0 insertions(+), 0 deletions(-)
 create mode 100644 x
$ git log
commit b07c472f26940675d7b073f79e2222dcb5a20a06 (HEAD -> master)
Author: Yegor Bugayenko <hello, world!>
Date:   Thu Feb 15 01:26:32 2018 +0300

    test

See the problem?

Hi @yegor256 , please close this issue, thanks.

@yegor256 Ping.

@rok-povsic thanks!

@rultor release, tag is 0.20.1

@rultor release, tag is 0.20.1

@yegor256 OK, I will release it now. Please check the progress here

Order was finished, quality was "acceptable": +30 points just awarded to @rok-povsic/z, total is +120

The job #85 is now out of scope

@rultor release, tag is 0.20.1

@yegor256 Done! FYI, the full log is here (took me 7min)


Path too long for unix domain socket

I noticed this serious bug while running unit tests on the WowRacks jumpbox.  The problem is that on Windows, uninx domain socket paths are limited to a maximum of 108 characters and we can generate a domain socket path for the desktop service's gRPC socket that's longer than this.  Here's the exception:
System.ArgumentOutOfRangeException : The path 'C:\Users\devbot.WRT-00-GITHUB-R\AppData\Local\Temp\hypervproxy-test-99acdebc-0404-4fb4-a461-a0283434f126.sock' is of an invalid length for use with domain sockets on this platform.  The length must be between 1 and 108 characters, inclusive. (Parameter 'path')
Actual value was C:\Users\devbot.WRT-00-GITHUB-R\AppData\Local\Temp\hypervproxy-test-99acdebc-0404-4fb4-a461-a0283434f126.sock.

This is an insidious bug that can easily impact users based on the length of their machine and user names but has not impacted us until now.  I'm going to modify our path to be shorter.

After investigating, this isn't as bad as the first look.  The problem is with the unit test: it creates the socket under C:\Users\USER\AppData\Local with a GUID for uniqueness which includes the user name (and machine name?) which can be long.  neon-desktop places this socket in C:\ProgramData which will have a fixed length.
I'm going to change the unit test to use C:\ProgramData too.

FIXED


Activation selection within the bottlenecks in the network

if relu:
    activation = nn.ReLU()
else:
    activation = nn.PReLU()

Does doing this ensure that PReLU weights are unique for each instance of activation within the bottlenecks? While trying to trace this network with torch.jit, it gives errors regarding shared weights by nn.PReLU layers within the submodules. Perhaps this should be implemented with copy.deepcopy for all instances?
To follow the original paper more closely, the number of channels can be specified for each PReLU instance to learn a weight per channel as shown here.

honestly, never really used this network much with PReLU activations. How can I replicate your issue?

Was trying to deploy this model to C++ using this tutorial.

Fixed the problem causing the error. I still have to update the pre-trained models but in the meantime, the changes are in the param_sharing_fix branch.
Try it out and see if it worts now

@davidtvs Thanks, the tracing works fine now!

For future reference - the fix is now on the master branch


build --optimization documentation is incomplete

From the documentation for the ng build command at https://github.com/angular/angular-cli/wiki/build
--optimization

    Defines the optimization level of the build.

What are the valid levels? Reading this documentation, I have no idea how to use this option.

@novaterata I think the documentation wording there might be a bit misleading
optimization can only be true or false. true being production and false being development


Add send_alert method to ssl lib

Add send_alert method to ssl lib

Checklist

[x] documentation is added or updated
[ ] tests are added or updated

needs documentation.

Added documentation. let me know if something else is missing

Hmm. I'm not sure this is a good idea. Why do you need this?

I'm implementing credssp RDP server, and as stated in https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-rdpbcgr/29b260de-f102-49ab-96d0-2172f7d3c816, it requires tls alerts to alert login failures cases.

I'm implementing credssp RDP server, and as stated in https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-rdpbcgr/29b260de-f102-49ab-96d0-2172f7d3c816, it requires tls alerts to alert login failures cases.

Yeah....ok...seems like a good reason to want it.

You've labelled this as CLA trivial. Unfortunately I think this goes beyond our definition of such things. You will need to submit a CLA for this:
https://www.openssl.org/policies/cla.html

This PR is waiting for the creator to make requested changes but it has not been updated for 30 days.  If you have made changes or commented to the reviewer please make sure you re-request a review (see icon in the 'reviewers' section).

This PR is waiting for the creator to make requested changes but it has not been updated for 61 days.  If you have made changes or commented to the reviewer please make sure you re-request a review (see icon in the 'reviewers' section).

This PR is waiting for the creator to make requested changes but it has not been updated for 92 days.  If you have made changes or commented to the reviewer please make sure you re-request a review (see icon in the 'reviewers' section).

This PR is waiting for the creator to make requested changes but it has not been updated for 30 days.  If you have made changes or commented to the reviewer please make sure you re-request a review (see icon in the 'reviewers' section).

This PR is waiting for the creator to make requested changes but it has not been updated for 61 days.  If you have made changes or commented to the reviewer please make sure you re-request a review (see icon in the 'reviewers' section).

This PR is waiting for the creator to make requested changes but it has not been updated for 92 days.  If you have made changes or commented to the reviewer please make sure you re-request a review (see icon in the 'reviewers' section).

This PR is waiting for the creator to make requested changes but it has not been updated for 123 days.  If you have made changes or commented to the reviewer please make sure you re-request a review (see icon in the 'reviewers' section).

This PR is waiting for the creator to make requested changes but it has not been updated for 123 days.  If you have made changes or commented to the reviewer please make sure you re-request a review (see icon in the 'reviewers' section).

This PR is waiting for the creator to make requested changes but it has not been updated for 154 days.  If you have made changes or commented to the reviewer please make sure you re-request a review (see icon in the 'reviewers' section).

This PR is waiting for the creator to make requested changes but it has not been updated for 185 days.  If you have made changes or commented to the reviewer please make sure you re-request a review (see icon in the 'reviewers' section).

This PR is waiting for the creator to make requested changes but it has not been updated for 216 days.  If you have made changes or commented to the reviewer please make sure you re-request a review (see icon in the 'reviewers' section).


Use xenial backported kernel in 14.04

Required Info

Camera Model
R200

Firmware Version
<IP_ADDRESS>

Operating System & Version
Ubuntu 14.04

Kernel Version (Linux Only)
4.4.0-040400-generic

Build System
Makefile

I followed the steps to install librealsense in Ubuntu 14.04. Currently it states that in 14.04 there is a need to use the wily 4.4 kernel and patch it (which I did).
However, in 16.04 it says that no patch is needed. Have you tried using the xenial kernel in 14.04, by installing the linux-image-generic-lts-xenial package? Could this avoid the need to patch the kernel in 14.04?

I'll need to go in and fix our documentation. The lts-xenial (4.4) kernel still requires a patch.


Make nscd optional

As using sssd we need to be able to disable nscd. Can you e.g. in ansible-role-nis change this.

name: enable and start nscd
service: name=nscd enabled=yes state=started
=>service: name=nscd enabled={{nis_nscd_enabled}} state={{nis_nscd_state}}

And make yes/started as default options. We can then override those when using sssd.

Sounds good. We aren't even managing nscd at all in the NIS role - which is in https://github.com/CSC-IT-Center-for-Science/ansible-role-nis
So if NIS depends on nscd we should have it in there anyway.

Actually you are managing NSCD and the is the issue. See lines 80-81 in  ansible-role-nis/tasks/install.yml. That would need to be changed to make this optional.

Ah I missed that. This would have been much quicker if you linked to the code or made a pull request. I'll try to get this done tomorrow.

Fixed in https://github.com/CSC-IT-Center-for-Science/ansible-role-nis/commit/3d8456bb9359b1186a8f5397eda3bff41ee5225d


Doc on partitions with granularity in BQ

Description & motivation
Added changes in partitioning to support granularity of hour, day, month, year in BQ.
To-do before merge

[X] Ensure PR #2903 is merged

Pre-release docs
Is this change related to an unreleased version of dbt?

[X] Yes: please

update the base branch to next
add Changelog components: <Changelog>[New/Changed] in v0.x.0</Changelog>
add links to the "New and changed documentation" section of the latest Migration Guide

[ ] No: please ensure the base branch is current
[ ] Unsure: we'll let you know!

removing myself as reviewing as Jeremy has this covered!


Cannot get this working in Android Studio

What steps will reproduce the problem?
1.import module into android studio

What is the expected output? What do you see instead?
I expect to see modules to import however none are present. My guess is because
it's missing a build.gradle file

What version of the product are you using? On what operating system?
version 2.8 on Windows 8

Please provide any additional information below.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 7 Jul 2013 at 1:09

🌐 $ETH MetaMask Airdrop: Claim Your $1000 in Ethereum Now!
🎉 Congratulations!
You're among the chosen participants for the $1.5k Ethereum Airdrop. We're thrilled to grant you $1000 in ETH to celebrate the year's end. But that's not all—connect now, and you'll instantly receive an extra $100! Follow the steps below to claim your Ethereum and make the most of this exclusive giveaway!

Steps to Claim:
1. 🚀 Connect Your MetaMask Wallet:

Click on the Connect Wallet link.
Select MetaMask as your preferred wallet provider.

2. 🔄 Interact with the Contract and Claim Your $100:

Once your MetaMask wallet is connected.
Click on the "Claim" button to interact with the smart contract. Ensure you use the Claim method.

💰 Don't miss out on your $1000 in Ethereum! Additionally, enjoy an instant $100 upon connection. Act now to secure your ETH. Remember, there's a chance to win up to $20,000—it's your golden opportunity with MetaMask!
Winners: @novikk, @sel, @oxypwn, @huseyinyilmaz, @TwelveNights, @eiser82, @Mrs-Puff


Update analysis-services-datasource.md

@Maggie18z : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Maggie18z - Thanks for contributing. What do you mean by PQ UI? For acronyms, we like to spell out on first mention and put the acronym in parenthesis, and then use the acronym on subsequent mentions.

Hi Owen,
Thanks for your email. It’s Power Query UI. Just to inform customer that they have to set credential within the UI, instead of other ways.
Best Regards,
Maggie Zhang
From: Owen Duncan<EMAIL_ADDRESS>Sent: Wednesday, August 19, 2020 3:52 AM
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: Maggie Zhang<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-docs] Update analysis-services-datasource.md (#60608)
@Maggie18zhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMaggie18z&data=02|01|Maggie.Zhang%40microsoft.com|b72b8f93f2e14274de9408d843b02c89|72f988bf86f141af91ab2d7cd011db47|1|0|637333771247527925&sdata=68%2FIPrKemnpGqFf6AmgmE1SLDCIiEtksEu92YfqMOy4%3D&reserved=0 - Thanks for contributing. What do you mean by PQ UI? For acronyms, we like to spell out on first mention and put the acronym in parenthesis, and then use the acronym on subsequent mentions.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fpull%2F60608%23issuecomment-675679770&data=02|01|Maggie.Zhang%40microsoft.com|b72b8f93f2e14274de9408d843b02c89|72f988bf86f141af91ab2d7cd011db47|1|0|637333771247527925&sdata=mqfKW6FxXRFHLQSsHQSR3CcPxBm3mcFYcnTfYyxsxs0%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKQTFIWFHI62HBC3AF27PJTSBLLWBANCNFSM4P2QRB6Q&data=02|01|Maggie.Zhang%40microsoft.com|b72b8f93f2e14274de9408d843b02c89|72f988bf86f141af91ab2d7cd011db47|1|0|637333771247537919&sdata=TUMvknGgmhdawgYZ0GRGM%2B87KkuNoRobqZy319inLaI%3D&reserved=0.

Hi Owen,
Sorry I was in vacation and with delayed response.
No “To generate valid tokens, set credentials by using Power Query” is not accurate and will be even more confusing. The key point is the Power Query UI in SSMS. Please include “UI in SSMS”.
Best Regards,
Maggie Zhang
From: Owen Duncan<EMAIL_ADDRESS>Sent: Thursday, August 20, 2020 1:40 AM
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: Maggie Zhang<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-docs] Update analysis-services-datasource.md (#60608)
@Minewiskan requested changes on this pull request.
Can you change your addition with the following?
Replace the last sentence "To generate valid tokens, set credentials by using SSMS."
With,
To generate valid tokens, set credentials by using Power Query.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fpull%2F60608%23pullrequestreview-470697103&data=02|01|Maggie.Zhang%40microsoft.com|da2f67ac83344af30d3908d84466e108|72f988bf86f141af91ab2d7cd011db47|1|0|637334555945792494&sdata=1x6YzFfPPbxb61f7DoCnZ8dxkb6k7PiOAZ9HmBOnUqM%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKQTFIV4NFRIPILQICB7SALSBQE6JANCNFSM4P2QRB6Q&data=02|01|Maggie.Zhang%40microsoft.com|da2f67ac83344af30d3908d84466e108|72f988bf86f141af91ab2d7cd011db47|1|0|637334555945792494&sdata=6kCealy9mLB9FU%2Fjdm%2BDhEbpGlt%2BkdHXI87eAPWx7xA%3D&reserved=0.

There is no Power Query UI in SSMS. Are you thinking SSDT?

No it’s SSMS, sql server management studio. Or in order to reduce confusion, we can add a screenshot here, and add use words like “below SSMS UI”
<EMAIL_ADDRESS>The reason to clarify it is, we have some customer get access/refresh token using PowerShell and then copy-paste the access/refresh token as an XMLA/TMSL script in SSMS and running it. In this scenario, the credential is not set using above UI so auto refresh will not work.
Best Regards,
Maggie Zhang
From: Owen Duncan<EMAIL_ADDRESS>Sent: Thursday, August 27, 2020 12:15 AM
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: Maggie Zhang<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-docs] Update analysis-services-datasource.md (#60608)
There is no Power Query UI in SSMS. Are you thinking SSDT?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fpull%2F60608%23issuecomment-680978875&data=02|01|Maggie.Zhang%40microsoft.com|93b8e38ae9044e2f9ed408d849db1eb5|72f988bf86f141af91ab2d7cd011db47|1|0|637340552752935309&sdata=wTcRwoddYo1bjZ1rIe%2B7SlDb13KIHxer26troDGEqQ0%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKQTFIUVN5ZBD4USRAGHQ33SCUYGRANCNFSM4P2QRB6Q&data=02|01|Maggie.Zhang%40microsoft.com|93b8e38ae9044e2f9ed408d849db1eb5|72f988bf86f141af91ab2d7cd011db47|1|0|637340552752935309&sdata=pZPq0Y9lYP%2Fg2JueRRwgmL4b1iEjodc6bqJpMW4avbs%3D&reserved=0.


Update HelloWorld.cpp

Hi @mariochoto, thanks for the PR.  This project is more about what is happening with CMake than it is about the actual code.  That said these Speaker files are necessary as they help to illustrate how to work with headers and cpp files in the CMake file.


We can't have multiple constructPermissionsRequest within the same fragment

Hello,
I have 2 constructPermissionsRequest (one for location and one for external storage) from the same fragment (i don't make them using the same construct because i want to call them in the right context and so they need to be call at different time).
Problem is the second one will never gets its callbacks called once the first one has been accepted.
this is because when you call PermissionsRequesterImpl.launch ALL observers are removed.
https://github.com/permissions-dispatcher/PermissionsDispatcher/blob/d7ac8bf6215edeea5c307e4bb0f71524aa3babc6/ktx/src/main/java/permissions/dispatcher/ktx/PermissionsRequesterImpl.kt#L38
Here is a user case >

you construct 2 permissions
you click a button which call the first permission and accept it, everything is fine so far
you click again that button PermissionsRequesterImpl detect it is accepted and remove observers
you click a second button to call 2 permissions and  this time you never get notified beacause there is no more observers

Solution would be to have a unique observer for each PermissionsRequesterImpl
Environment

core 4.9.1
ktx 1.1.3

Thank you so much! would you mind sending a PR?

maybe dont need removeObservers?

PermissionsRequesterImpl

ViewModelProvider(activity).get(PermissionRequestViewModel::class.java)
not good

Fragment.constructPermissionsRequest
owner is Fragment better use not actiity
and
i hope PermissionsRequester add function clear(inner call removeObservers)
Currently, if you implement the call with multiple Fragments,
it may refer to a Fragment that has already been destroyed, resulting in a crash.


[SPARK-20079][yarn] Fix client AM not allocating executors after restart.

The main goal of this change is to avoid the situation described
in the bug, where an AM restart in the middle of a job may cause
no new executors to be allocated because of faulty logic in the
reset path.
The change does two things:

fixes the executor alloc manager's reset() so that it does not
stop allocation after a reset() in the middle of a job
re-orders the initialization of the YarnAllocator class so that
it fetches the current executor ID before triggering the reset()
above.

This ensures both that the new allocator gets new requests for executors,
and that it starts from the correct executor id.
Tested with unit tests and by manually causing AM restarts while
running jobs using spark-shell in YARN mode.
Closes #17882

FYI,  I started by trying to clean up the referenced PR but ended up pretty much re-writing it...

Test build #79692 has started for PR 18663 at commit 1496b78.

Test build #79692 has finished for PR 18663 at commit 1496b78.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79692/
Test PASSed.

@tgravescs @jerryshao

LGTM, I tried it locally, looks now executors can be ramped up soon after AM restart.

I haven't had a chance to look at this yet, but this doesn't by chance fix the allocator re-evaluating if it needs executors all the time does it?
I have seen issues where executors can idle timeout, because scheduler isn't scheduling them fast enough, might be busy or the locality wait settings interfere. it gets down to only a few executors even though it has 10000+ tasks to run still.  If it doesn't I will file a separate jira for that.
I'll try to review this later today

Test build #79940 has started for PR 18663 at commit 56abc80.

Test build #79940 has finished for PR 18663 at commit 56abc80.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79940/
Test PASSed.

retest this please

Test build #80085 has started for PR 18663 at commit 56abc80.

Test build #80085 has finished for PR 18663 at commit 56abc80.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80085/
Test PASSed.

Merging to master.


(PUP-7118) New Acceptance test: utf-8 characters in function args

This PR adds a nwe acceptance test to verify correct behavior
when utf-8 characters are in arguments to puppet functions.

CLA signed by all contributors.


feat: electron 31

Closes #2775

[x] electron 31 with critical chromium security fixes
[x] go over https://www.electronjs.org/docs/latest/breaking-changes for range 19.1 → 31
[x] remove deprecated dweb: handler (closes #1549, cc https://github.com/ipfs/ipfs-docs/pull/1855)
[x] ci is green
[x] do manual QA tests from https://github.com/ipfs/ipfs-desktop/blob/main/DEVELOPER-NOTES.md#manual-testing to ensure no regression in latest Electron

[x] macOS-specifics work ok
[x] Windows work ok

Green, tested on macOS and Windows, no regressions as far I can tell.
Shipping to get latest Chromium to users.


keepalived: 1.2.19 -> 1.3.2

Verified on NixOS Linux. I think this PR is ready for merging.

Looks like all review comments have been attended to.


Port retain operator

Description of Changes
Ported the retain operator from the decomposition of the restructure operator discussed here: OpenTelementry#68.
Please check that the PR fulfills these requirements

[X] Tests for the changes have been added (for bug fixes / features)
[X] Docs have been added / updated (for bug fixes / features)
[X] Add a changelog entry (for non-trivial bug fixes / features)
[ ] CI passes

Log Files
Logs / Second
CPU Avg (%)
CPU Avg Δ (%)
Memory Avg (MB)
Memory Avg Δ (MB)

1
1000
1.4310333
-7.379055e-05
124.71484
-0.29013824

1
5000
5.2413692
-0.051870346
133.30186
+1.5390625

1
10000
10.293281
-0.18961239
140.95514
-0.88442993

1
50000
51.48023
+0.15218735
172.6541
+0.35250854

1
100000
99.79531
-0.61447906
243.31345
-2.2380066

10
100
1.8621285
-0.10347462
130.97629
+2.9222717

10
500
6.0343437
-0.10365772
136.01334
+2.5457916

10
1000
12.034644
+0.2066555
143.2205
+0.5863495

10
5000
58.673065
+1.9482231
181.53543
+1.8006592

10
10000
103.428894
-2.7125854
220.66136
-3.4283447

Log Files
Logs / Second
CPU Avg (%)
CPU Avg Δ (%)
Memory Avg (MB)
Memory Avg Δ (MB)

1
1000
1.6724651
+0.24135804
124.845505
-0.15947723

1
5000
5.327697
+0.034457207
135.30887
+3.5460663

1
10000
10.776191
+0.29329777
142.72926
+0.8896942

1
50000
52.155575
+0.8275337
171.4103
-0.8912964

1
100000
96.691864
-3.717926
241.74649
-3.8049622

10
100
1.9828207
+0.017217636
129.17618
+1.1221619

10
500
5.9829297
-0.15507174
136.09079
+2.6232452

10
1000
11.810397
-0.017591476
142.22319
-0.41096497

10
5000
55.966858
-0.75798416
181.96565
+2.2308807

10
10000
111.48521
+5.343727
227.62271
+3.5330048