Translating some netcdf files raise a JSON not serializable then if recovered segfault/double free

Translating some netcdf files with kerchunk raise TypeError: Object of type bytes is not JSON serializable. If the exception is caught the application then segfault or double free.
Made a small reproducible exemple using the failling netcdf file in this archive: viscal.zip
The netcdf doesn't seems to be corrupted as it can be read with ncdump (it's header is in annex).
Code exemple
import traceback
import fsspec
import kerchunk.hdf

def my_kerchunk_context(open_file, url):
    try:
        kerchunk_info = kerchunk.hdf.SingleHdf5ToZarr(open_file, url)
        print("SingleHdf5ToZarr done. Start translate.")
        zarr_compatible_data = kerchunk_info.translate()
        print("Success with", url)
    except Exception as err:
        print("Fail with exception", url)
        print(err)
        print(traceback.format_exc())

def my_fsspec_context(url):
    with fsspec.open(url, "rb") as open_file:
        my_kerchunk_context(open_file, url)

folder = "/home/gbeaucha/CSC-DPR/eopf-cpm/data/S3A_SL_1_RBT____20220603T234543_20220603T234843_20220605T083021_0179_086_087_3780_PS1_O_NT_004.SEN3/"
bad_file = "viscal.nc"

my_fsspec_context(folder+bad_file)
print("Exited all contexts")

Console output
SingleHdf5ToZarr done. Start translate.

/home/gbeaucha/.local/share/virtualenvs/eopf-cpm-gah88zwo/lib/python3.9/site-packages/zarr/storage.py:432: FutureWarning: missing object_codec for object array; this will raise a ValueError in version 3.0

  warnings.warn('missing object_codec for object array; this will raise a '

Fail with exception /home/gbeaucha/CSC-DPR/eopf-cpm/data/S3A_SL_1_RBT____20220603T234543_20220603T234843_20220605T083021_0179_086_087_3780_PS1_O_NT_004.SEN3/viscal.nc

Object of type bytes is not JSON serializable

Traceback (most recent call last):

  File "/home/gbeaucha/CSC-DPR/eopf-cpm/kerchunk_issue.py", line 12, in my_kerchunk_context

    zarr_compatible_data = kerchunk_info.translate()

  File "/home/gbeaucha/.local/share/virtualenvs/eopf-cpm-gah88zwo/lib/python3.9/site-packages/kerchunk/hdf.py", line 73, in translate

    self._h5f.visititems(self._translator)

  File "/home/gbeaucha/.local/share/virtualenvs/eopf-cpm-gah88zwo/lib/python3.9/site-packages/h5py/_hl/group.py", line 613, in visititems

    return h5o.visit(self.id, proxy)

  File "h5py/_objects.pyx", line 54, in h5py._objects.with_phil.wrapper

  File "h5py/_objects.pyx", line 55, in h5py._objects.with_phil.wrapper

  File "h5py/h5o.pyx", line 355, in h5py.h5o.visit

  File "h5py/h5o.pyx", line 302, in h5py.h5o.cb_obj_simple

  File "/home/gbeaucha/.local/share/virtualenvs/eopf-cpm-gah88zwo/lib/python3.9/site-packages/h5py/_hl/group.py", line 612, in proxy

    return func(name, self[name])

  File "/home/gbeaucha/.local/share/virtualenvs/eopf-cpm-gah88zwo/lib/python3.9/site-packages/kerchunk/hdf.py", line 190, in _translator

    za = self._zroot.create_dataset(h5obj.name, shape=h5obj.shape,

  File "/home/gbeaucha/.local/share/virtualenvs/eopf-cpm-gah88zwo/lib/python3.9/site-packages/zarr/hierarchy.py", line 821, in create_dataset

    return self._write_op(self._create_dataset_nosync, name, **kwargs)

  File "/home/gbeaucha/.local/share/virtualenvs/eopf-cpm-gah88zwo/lib/python3.9/site-packages/zarr/hierarchy.py", line 673, in _write_op

    return f(*args, **kwargs)

  File "/home/gbeaucha/.local/share/virtualenvs/eopf-cpm-gah88zwo/lib/python3.9/site-packages/zarr/hierarchy.py", line 834, in _create_dataset_nosync

    a = create(store=self._store, path=path, chunk_store=self._chunk_store,

  File "/home/gbeaucha/.local/share/virtualenvs/eopf-cpm-gah88zwo/lib/python3.9/site-packages/zarr/creation.py", line 149, in create

    init_array(store, shape=shape, chunks=chunks, dtype=dtype, compressor=compressor,

  File "/home/gbeaucha/.local/share/virtualenvs/eopf-cpm-gah88zwo/lib/python3.9/site-packages/zarr/storage.py", line 351, in init_array

    _init_array_metadata(store, shape=shape, chunks=chunks, dtype=dtype,

  File "/home/gbeaucha/.local/share/virtualenvs/eopf-cpm-gah88zwo/lib/python3.9/site-packages/zarr/storage.py", line 450, in _init_array_metadata

    store[key] = store._metadata_class.encode_array_metadata(meta)  # type: ignore

  File "/home/gbeaucha/.local/share/virtualenvs/eopf-cpm-gah88zwo/lib/python3.9/site-packages/zarr/meta.py", line 102, in encode_array_metadata

    return json_dumps(meta)

  File "/home/gbeaucha/.local/share/virtualenvs/eopf-cpm-gah88zwo/lib/python3.9/site-packages/zarr/util.py", line 38, in json_dumps

    return json.dumps(o, indent=4, sort_keys=True, ensure_ascii=True,

  File "/usr/lib/python3.9/json/__init__.py", line 234, in dumps

    return cls(

  File "/usr/lib/python3.9/json/encoder.py", line 201, in encode

    chunks = list(chunks)

  File "/usr/lib/python3.9/json/encoder.py", line 431, in _iterencode

    yield from _iterencode_dict(o, _current_indent_level)

  File "/usr/lib/python3.9/json/encoder.py", line 405, in _iterencode_dict

    yield from chunks

  File "/usr/lib/python3.9/json/encoder.py", line 438, in _iterencode

    o = _default(o)

  File "/usr/lib/python3.9/json/encoder.py", line 179, in default

    raise TypeError(f'Object of type {o.__class__.__name__} '

TypeError: Object of type bytes is not JSON serializable

Exited all contexts

double free or corruption (out)

Abandon

File header

spoiler : viscal file header
netcdf viscal {
dimensions:
	integrators = 2 ;
	one = 1 ;
	swir_detectors = 8 ;
	views = 2 ;
	visible_detectors = 4 ;
variables:
	string ANX_time(one) ;
		ANX_time:long_name = "Time of ascending node crossing in the UTC YYYY-MM-DDThh:mm:ss.ddddddZ CCSDS format" ;
		ANX_time:standard_name = "time" ;
	float S1_BB1_SD(visible_detectors, views, integrators) ;
		S1_BB1_SD:_FillValue = NaNf ;
		S1_BB1_SD:long_name = "555nm BB1 noise counts" ;
	float S1_BB1_means(visible_detectors, views, integrators) ;
		S1_BB1_means:_FillValue = NaNf ;
		S1_BB1_means:long_name = "555nm BB1 average counts" ;
	float S1_VISCAL_SD(visible_detectors, views, integrators) ;
		S1_VISCAL_SD:_FillValue = NaNf ;
		S1_VISCAL_SD:long_name = "555nm VISCAL noise counts" ;
	float S1_VISCAL_means(visible_detectors, views, integrators) ;
		S1_VISCAL_means:_FillValue = NaNf ;
		S1_VISCAL_means:long_name = "555nm VISCAL average counts" ;
	float S1_slopes(visible_detectors, views, integrators) ;
		S1_slopes:_FillValue = NaNf ;
		S1_slopes:long_name = "555nm slopes" ;
	float S1_solar_irradiances(visible_detectors, views) ;
		S1_solar_irradiances:_FillValue = NaNf ;
		S1_solar_irradiances:long_name = "555nm solar irradiances" ;
		S1_solar_irradiances:units = "mW m-2 nm-1" ;
	float S2_BB1_SD(visible_detectors, views, integrators) ;
		S2_BB1_SD:_FillValue = NaNf ;
		S2_BB1_SD:long_name = "659nm BB1 noise counts" ;
	float S2_BB1_means(visible_detectors, views, integrators) ;
		S2_BB1_means:_FillValue = NaNf ;
		S2_BB1_means:long_name = "659nm BB1 average counts" ;
	float S2_VISCAL_SD(visible_detectors, views, integrators) ;
		S2_VISCAL_SD:_FillValue = NaNf ;
		S2_VISCAL_SD:long_name = "659nm VISCAL noise counts" ;
	float S2_VISCAL_means(visible_detectors, views, integrators) ;
		S2_VISCAL_means:_FillValue = NaNf ;
		S2_VISCAL_means:long_name = "659nm VISCAL average counts" ;
	float S2_slopes(visible_detectors, views, integrators) ;
		S2_slopes:_FillValue = NaNf ;
		S2_slopes:long_name = "659nm slopes" ;
	float S2_solar_irradiances(visible_detectors, views) ;
		S2_solar_irradiances:_FillValue = NaNf ;
		S2_solar_irradiances:long_name = "659nm solar irradiances" ;
		S2_solar_irradiances:units = "mW m-2 nm-1" ;
	float S3_BB1_SD(visible_detectors, views, integrators) ;
		S3_BB1_SD:_FillValue = NaNf ;
		S3_BB1_SD:long_name = "865nm BB1 noise counts" ;
	float S3_BB1_means(visible_detectors, views, integrators) ;
		S3_BB1_means:_FillValue = NaNf ;
		S3_BB1_means:long_name = "865nm BB1 average counts" ;
	float S3_VISCAL_SD(visible_detectors, views, integrators) ;
		S3_VISCAL_SD:_FillValue = NaNf ;
		S3_VISCAL_SD:long_name = "865nm VISCAL noise counts" ;
	float S3_VISCAL_means(visible_detectors, views, integrators) ;
		S3_VISCAL_means:_FillValue = NaNf ;
		S3_VISCAL_means:long_name = "865nm VISCAL average counts" ;
	float S3_slopes(visible_detectors, views, integrators) ;
		S3_slopes:_FillValue = NaNf ;
		S3_slopes:long_name = "865nm slopes" ;
	float S3_solar_irradiances(visible_detectors, views) ;
		S3_solar_irradiances:_FillValue = NaNf ;
		S3_solar_irradiances:long_name = "865nm solar irradiances" ;
		S3_solar_irradiances:units = "mW m-2 nm-1" ;
	float S4_BB1_SD(swir_detectors, views, integrators) ;
		S4_BB1_SD:_FillValue = NaNf ;
		S4_BB1_SD:long_name = "1.375microm BB1 noise counts" ;
	float S4_BB1_means(swir_detectors, views, integrators) ;
		S4_BB1_means:_FillValue = NaNf ;
		S4_BB1_means:long_name = "1.375microm BB1 average counts" ;
	float S4_VISCAL_SD(swir_detectors, views, integrators) ;
		S4_VISCAL_SD:_FillValue = NaNf ;
		S4_VISCAL_SD:long_name = "1.375microm VISCAL noise counts" ;
	float S4_VISCAL_means(swir_detectors, views, integrators) ;
		S4_VISCAL_means:_FillValue = NaNf ;
		S4_VISCAL_means:long_name = "1.375microm VISCAL average counts" ;
	float S4_slopes(swir_detectors, views, integrators) ;
		S4_slopes:_FillValue = NaNf ;
		S4_slopes:long_name = "1.375microm slopes" ;
	float S4_solar_irradiances(swir_detectors, views) ;
		S4_solar_irradiances:_FillValue = NaNf ;
		S4_solar_irradiances:long_name = "1.375microm solar irradiances" ;
		S4_solar_irradiances:units = "mW m-2 nm-1" ;
	float S5_BB1_SD(swir_detectors, views, integrators) ;
		S5_BB1_SD:_FillValue = NaNf ;
		S5_BB1_SD:long_name = "1.61microm BB1 noise counts" ;
	float S5_BB1_means(swir_detectors, views, integrators) ;
		S5_BB1_means:_FillValue = NaNf ;
		S5_BB1_means:long_name = "1.61microm BB1 average counts" ;
	float S5_VISCAL_SD(swir_detectors, views, integrators) ;
		S5_VISCAL_SD:_FillValue = NaNf ;
		S5_VISCAL_SD:long_name = "1.61microm VISCAL noise counts" ;
	float S5_VISCAL_means(swir_detectors, views, integrators) ;
		S5_VISCAL_means:_FillValue = NaNf ;
		S5_VISCAL_means:long_name = "1.61microm VISCAL average counts" ;
	float S5_slopes(swir_detectors, views, integrators) ;
		S5_slopes:_FillValue = NaNf ;
		S5_slopes:long_name = "1.61microm slopes" ;
	float S5_solar_irradiances(swir_detectors, views) ;
		S5_solar_irradiances:_FillValue = NaNf ;
		S5_solar_irradiances:long_name = "1.61microm solar irradiances" ;
		S5_solar_irradiances:units = "mW m-2 nm-1" ;
	float S6_BB1_SD(swir_detectors, views, integrators) ;
		S6_BB1_SD:_FillValue = NaNf ;
		S6_BB1_SD:long_name = "2.25microm BB1 noise counts" ;
	float S6_BB1_means(swir_detectors, views, integrators) ;
		S6_BB1_means:_FillValue = NaNf ;
		S6_BB1_means:long_name = "2.25microm BB1 average counts" ;
	float S6_VISCAL_SD(swir_detectors, views, integrators) ;
		S6_VISCAL_SD:_FillValue = NaNf ;
		S6_VISCAL_SD:long_name = "2.25microm VISCAL noise counts" ;
	float S6_VISCAL_means(swir_detectors, views, integrators) ;
		S6_VISCAL_means:_FillValue = NaNf ;
		S6_VISCAL_means:long_name = "2.25microm VISCAL average counts" ;
	float S6_slopes(swir_detectors, views, integrators) ;
		S6_slopes:_FillValue = NaNf ;
		S6_slopes:long_name = "2.25microm slopes" ;
	float S6_solar_irradiances(swir_detectors, views) ;
		S6_solar_irradiances:_FillValue = NaNf ;
		S6_solar_irradiances:long_name = "2.25microm solar irradiances" ;
		S6_solar_irradiances:units = "mW m-2 nm-1" ;
	string calibration_time(one) ;
		calibration_time:long_name = "Time of calibration in the UTC YYYY-MM-DDThh:mm:ss.ddddddZ CCSDS format" ;
		calibration_time:standard_name = "time" ;
	float monitor_SD(one) ;
		monitor_SD:_FillValue = NaNf ;
		monitor_SD:long_name = "Monitor diode noise counts" ;
	float monitor_mean(one) ;
		monitor_mean:_FillValue = NaNf ;
		monitor_mean:long_name = "Monitor diode average counts" ;

// global attributes:
		:contact =<EMAIL_ADDRESS>;
		:creation_time = "20220605T083021Z" ;
		:history = "  2022-06-05T08:30:21Z: PUGCoreProcessor joborder.19812183.xml" ;
		:institution = "PS1" ;
		:netCDF_version = "4.2 of Mar 13 2018 10:14:33 $" ;
		:processing_baseline = "SL__L1_.004.04.00" ;
		:product_name = "S3A_SL_1_RBT____20220603T234543_20220603T234843_20220605T083021_0179_086_087_3780_PS1_O_NT_004.SEN3" ;
		:references = "" ;
		:source = "IPF-SL-1 06.19" ;
		:title = "S3 SLSTR L1 Radiance and Brightness Temperatures Product. (Measurements + Annotations)" ;
}

Versions used
kerchunk version: 0.0.6
fsspec version: 2022.3.0

I assume it either segfault when the fsspec file is closed or if we got "lucky" later double free when it get garbage collected.

We definitely need some work around object encoding in HDF5, this has come up a few times in issues and even partial PRs. At the very least, _translator should never be allowed to pass exceptions up the stack, since it seems HDF5 can't handle this cleanly: a warning should be raised.

With your branch both my exemple and full application no longer raise an exception, warning nor segfault.


Left join could use bitmap for left join instead of Vec

Which issue does this PR close?

Depends on: https://github.com/apache/arrow-rs/pull/693
Closes #240 .
This is a new version (arrow native) of: https://github.com/apache/arrow-datafusion/pull/342 (which is also me, from the company account)
Rationale for this change

Described in the issue.
What changes are included in this PR?

Described in the issue.
Are there any user-facing changes?

No

The build will fail due to the fact it relies on an new api to BooleanBufferBuilder which is under this PR: https://github.com/apache/arrow-rs/pull/693
Please let me know what If you need anything else on my side to make this happen. Thanks! (cc @alamb that corresponded with me on the previous PR)

FYI assuming we merge + backport https://github.com/apache/arrow-rs/pull/693 (which seems likely) it would be available in arrow-rs 5.3.0 (target release date in about 2 weeks time). Thank you very much for sticking with this @boazberman

Nice work @boazberman ! I wish there is automated benchmark report against master so we get to see the sweet performance gain number :) I vaguely remember ursalabs built a tool for this particular use-case for the main arrow repo.

Closing a seemingly stale PR -- please reopen if that was a mistake.


Adding Symbols support to jest

Summary
Jest didn't support mocking Symbols
trying to mock a Symbol fails with a Failed to get mock metadata:
This diff adds support to mocking Symbols
Test plan
I added a test that ensure Symbols get mocked correctly

Current coverage is 87.77% (diff: 100%)

Merging #1948 into master will not change coverage

@@             master      #1948   diff @@
==========================================
  Files            38         38
  Lines          1252       1252
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           1099       1099
  Misses          153        153
  Partials          0          0

Powered by Codecov. Last update a439d49...dd0543e

nice fix!


System Information not working for method calls that include powershell commands execution on a machine that has powershell disabled.

Describe the bug
If powershell is disabled by a system admin in an enterprise environment, the System Information npm is failing to output information about:
osinfo.hardware, or osinfo in general
networkinterfaces() returns error
cpu() returns empty errored data
diskLayout() returns empty array
To Reproduce
Steps to reproduce the behavior:

Please disable powershell in your windows machine using link
Search for "How to block PowerShell access using Security Policy" in the link mentioned in point 1.
Once disabled, all the methods that use powershell commands stop working

Current Output
Few methods like osinfo, cpu and diskLayout output error or empty data
Expected behavior
I am not sure if systeminformation is supported on powershell disabled windows machines. But It would be great for me I could read systeminformation on powershell disabled windows machines.
Environment (please complete the following information):

systeminformation package version: 5.10.5
Windows 10 with powershell disabled

Hello,
I reproduced the issue.
Package version 5.9.9 is the last one to work in this environment, try to use it.
5.9.10+ does not work anymore. getStaticData() promise does not error nor callback correctly, which made errors handling pretty difficult in this case.

Kind regards

@paragdulam, @CapitaineBidouille ... since wmic is unfortunately dropped in the most recent versions of windows, we had to make the transition to powerShell. See also #616 ... So what I do see as possible solutions:

first checking the error handling (not having powerShell) on my side to get at least no errors.
thinking of having then 2 possible ways of gathering windows system information (wmic as a fallback)

As this would result in a lot of code changes, I am not sure if and when I would be able to do this ...

@sebhildebrandt @CapitaineBidouille
Just putting forth an idea,
may be we can make a node-addon out of this
https://docs.microsoft.com/en-us/windows/win32/sysinfo/system-information
and use that in systeminformation
Problems can be

If it is using power shell internally it still won't work on power shell disabled windows machine. I personally think it is using some core internal api and not power shell
It would only work for windows.

What do you guys think?


Tests use "RAW" as algorithm for keys

Here:
https://github.com/jchambers/java-otp/blob/46670ad0cf991e2ccbe339ddd5e5cb9dabf00a17/src/test/java/com/eatthepath/otp/TimeBasedOneTimePasswordGeneratorTest.java#L47
the 2nd argument should be the algorithm, but RAW is passed instead.

Good catch! Thank you!
Also: good to hear from you—happy new year to you!

😀 I was looking for an aerogear otp replacement and was so pleasantly surprised to see who made this one 😀
Happy new year and thanks a lot for the great stuff you code and share!


Cache virtual environment to speed up build

Before

From this run: https://github.com/caktus/developer-documentation/actions/runs/1574240548
(In practice it looks like this varies a bit, but I think this is an average.)
After

From this run: https://github.com/caktus/developer-documentation/actions/runs/1574302502

Tobias. We tried this, and maybe implemented it incorrectly, but after we used it, no changes would happen, even if the deploy indicated success.

Tobias. We tried this, and maybe implemented it incorrectly, but after we used it, no changes would happen, even if the deploy indicated success.

Hm, it should work. If commit 584840cb6c9965610cc95f68e84292d4803cc725 removes the final version of the code in question, I think the issue may be that the mkdocs gh-deploy --force command may have needed to move one step down (to the "Deploy docs to GH Pages")...

Awesome. Merge away.
Jeremy GibsonDeveloper
@.*** @.***>
www.caktusgroup.com
http://www.google.com/url?q=http%3A%2F%2Fwww.caktusgroup.com%2F&sa=D&sntz=1&usg=AFQjCNG6RpHdHUA5QLae7099-vwv2NLrvg
On Tue, Dec 14, 2021 at 10:37 AM Tobias McNulty @.***>
wrote:

Tobias. We tried this, and maybe implemented it incorrectly, but after we
used it, no changes would happen, even if the deploy indicated success.
Hm, it should work. If commit 584840c
https://github.com/caktus/developer-documentation/commit/584840cb6c9965610cc95f68e84292d4803cc725
removes the final version of the code in question, I think the issue may be
that the mkdocs gh-deploy --force command may have needed to move one
step down (to the "Deploy docs to GH Pages")...
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/caktus/developer-documentation/pull/97#issuecomment-993666522,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAWUFYQDVFIYQODKIBQSTTTUQ5QCDANCNFSM5J62SHKA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


Using Reader View in Text Browser

Scenario: I use w3m as my $RTV_BROWSER and it works very well. However, I tried using the Reader Mode inside w3m in rtv and I'm getting a "Timeout waiting for browser to open" error.
Using the Reader Mode from here: https://github.com/jarun/googler/wiki/Terminal-Reading-Mode-or-Reader-View
Basically I set it up using the simple method of redirecting the browser requests through a bash script named reader which has only one line:
w3m "http://justread.mpgarate.com/read?url=$1"
I can open websites from my terminal in Reader Mode using the above script through a simple reader URL command.
I wanted to use this inside rtv, so I changed the $RTV_BROWSER variable from w3m to reader and did a reboot.
Now, when I open a link from rtv, it opens it first in the Reader Mode (and it loads fine) but then it gives me the error "Timeout waiting for browser open" and takes me back to the previous screen not allowing me to read the webpage that it had displayed. Moreover, when that happens rtv stops working properly and I cannot use my arrow keys anymore.
I'm looking for a way to fix this error.
I love rtv because it works so well and so does w3m inside rtv, but I would like to open all my links through Reader Mode to make my setup more pleasing.
Thank you.

With $BROWSER, RTV has different behavior depending on if you're going to open the browser in a new window (like firefox, chrome, etc.) or if it needs to yield control of the terminal to the application (like w3m, your script, etc.). I haven't found a foolproof way to determine this so for now it makes an educated guess based on your environment. In your case, RTV is getting confused and you end up with two applications fighting for control of the terminal. You might be able to work around your issue by setting DISPLAY= to force RTV into terminal browser mode.
I think that ideally you would also be able to define this with a mailcap entry like so
text/html; w3m http://justread.mpgarate.com/read?url=%s; needsterminal
It looks like RTV doesn't respect text/html mailcap entries though, and defers to $BROWSER so you would likely end up with the same problem.

Thank you so much for explaining the issue and the link to the relevant code. I changed the name of my script from reader to one of the console_browsers you named in the list (other than w3m which I'm actually using), elinks. It is working as expected now, except that each time I open a link it displays an error message before opening the link:
Error occured while reset 800b: errno=25
And there's a new line with the same error under the previous error growing by every click, it's displayed only for a second though.
Thanks

I'm glad that you were able to fix your problem. I haven't seen that error message before, but you could try piping stderr to /dev/null in your bash script and see if that gets rid of it.
I'm going to leave this open and mark it as a documentation issue, because DISPLAY should be explained in the environment variables section of the README.

So, I'm also trying to use reader as a viewer for web-pages within rtv. First, I've named the shell script in question as links (or lynx, it doesn't matter), changed its permissions to 755, put it in my $PATH, and I also put a symbolic link of it to /usr/local/bin just in case.
Now, I export RTV_BROWSER=/usr/local/bin/links (or just links, again, it doesn't matter) in a terminal. Then, I launch rtv. Go to a submission with a link, press o -- and it still tries to open the link in my Firefox.
> which links
/usr/local/bin/links
> echo $RTV_BROWSER
/usr/local/bin/links

How can I possibly fix this?


[WIP] Resync of services and policies with non-empty VPP

Coverage increased (+0.04%) to 77.585% when pulling 555a3d2c3eecb2d5d11ef9c07626bca55c727c90 on milanlenco:resync-acl-svc into 0fb46db3b4f272be010f125b54407cf3d7016c1a on contiv:master.


[Remote Store] _cat/recovery should provide progress of remote segment download during recovery

Is your feature request related to a problem? Please describe.

_cat/recovery API provide details of progress of recovery. This helps in getting insight especially when shards are bigger in size.
While restoring remote store backed index, entry is created but there is no data shown under _cat/recovery.
This feature request adds the support of tracking segment download progress.
Related issue of translog download progress: https://github.com/opensearch-project/OpenSearch/issues/6822

Hey @sachinpkale, This issue will be marked for next-release v2.8.0 on (Apr 17) as that is the code-freeze date for v2.7.0. Please let me know if otherwise.

Tagging it for next release: v2.8.0

Added as part of https://github.com/opensearch-project/OpenSearch/pull/6825


Could you upgrade to nunjucks 3.0.1?

Thanks

Just reinstall gulp-nunjucks, semver will take care of it.

Thanks


Add support for directories in cluster mol output

The definition of the output on the cluster mol object didn't support setting it to a particular path. This meant that the output file from the cluster mol object was always stored in the current working directory, rather than where the output file of the main mean-field mol object was set to. This pull request fixes it, so that all PySCF output files are now stored in the same user defined directory.

Looks good!

Thank you for fixing this


Project Category is hard coded in the VOCUtilities.properties strings

 Project Category should be specified in VOC Configuration


Fix invalid menu name in rumble testing

std::dynamic_pointer_cast<BenInputEditorWindow>(Ship::Context::GetInstance()->GetWindow()->GetGui()->GetGuiWindow("Input Editor"));

Input Editor -> LUS::InputEditorWindow
2S2H Input Editor -> BenInputEditorWindow

Build Artifacts

2ship-mac.zip
2ship-linux.zip
2ship-windows.zip

As a fix, I think this would be better rebased and pointed to the develop-Satoko branch.


Fix Incorrect Video Links in Documentation Files

I found similar issues in other documentation files that need corrections. This pull request fixes incorrect video links in the following files:
apps/base-learn/docs/deployment-to-testnet/deployment-to-base-sepolia-sbs.md
apps/base-docs/tutorials/docs/0_deploy-with-remix.md

🟡 Heimdall Review Status

Requirement
Status
More Info

Reviews

🟡
0/1

Denominator calculation

Show calculation

1 if user is bot
0

1 if user is external
0

From .codeflow.yml

1

Additional review requirements

Show calculation

Max
0

0

From CODEOWNERS

0

Global minimum
0

Max

1

1

1 if commit is unverified
0

Sum
1

@brendan-defi
I noticed similar issues in other documentation files. Let's review and update these as well to ensure all links are correct.

@Dahka2321 thanks, will review today

@Dahka2321 thanks again for catching these, approved and merged


Figure8(unreliable) test case not pass always.

The probability of passing Figure8(unreliable) is lager than 80%, Because of the unreliable network which make follower start election frequently and have little time to find correct prevIndex.

I think it is reasonable.

i have the same problem, super hard to debug.


Translations update from Mattermost Weblate

Translations update from Mattermost Weblate for Mattermost/mattermost-desktop.
Current translation status:

@devinbinnie, not urgent, but I'm not sure what the test failures are here. When you have a chance, can you take a look?


Check for valid file [phab:D1458]

Created by salguarnieri at 2017-03-28 17:41:31:
Before we call RangeForSingleTokenFromSourceLocation we should check to
make sure the source location is from a valid file.

zarko accepted this revision at 2017-03-28 17:43:08

salguarnieri closed via commit 9c6d10162174bcff1475fc54d7e6304a558deea0 at 2017-03-28 17:44:03


csswring 3.0.0 bug

Using a library called w2ui has a less style like so https://github.com/vitmalina/w2ui/blob/master/src/less/src/common.less#L84
    input:not([type=button]), select, textarea {
        padding: 4px;
        border: @input-border;
        border-radius: 3px;
        color: @input-color;
        background-color: @input-background-color;
        line-height: normal;
        &:focus {
            outline-color: @input-focus-outline-color;
        }
        &:disabled, &[readonly] {
            background-color: #f1f1f1;
            color: #777;
        }
    }

Straight through less in development mode it comes out as:
input:not([type=button]):disabled,
select:disabled,
textarea:disabled,
input:not([type=button])[readonly],
select[readonly],
textarea[readonly] {
  background-color: #f1f1f1;
  color: #777;
}

Through csswring, when the app is in production mode.
input:not([type=button]):disabled,select:disabled,textarea:disabled,input:not([type="button])[readonly"],select[readonly],textarea[readonly] {
    background-color: #f1f1f1;
    color: #777
}

This problem string in question
input:not([type="button])[readonly"]

csswring 3.0.5 can parse this correctly.
Updating my local connect-assets package.json to "csswring": "~3.0.5" fixed the issue.
Could the included csswring be updated to the latest patch release?

https://github.com/adunkman/connect-assets/pull/309


Type definitions outdated

This is a:

[x] Bug Report
[ ] Feature Request
[ ] General Query

My version of UI-Router is: 0.4.2
Bug Report
Current Behavior:
Using "@types/angular-ui-router": "1.1.38" and "typescript": "2.6.1", I can no longer build my project:
[tsl] ERROR in ...foobar.ts(7,12)
      TS4023: Exported variable 'foobar' has or is using name 'ui.IStateService' from external module angular but cannot be named.

tsconfig:
{
  "compilerOptions": {
    "module": "commonjs",
    "moduleResolution": "node",
    "target": "es5",
    "declaration": true,
}

Cause
In<EMAIL_ADDRESS>the 'export type ...' block exports from namespace that has not been defined yet.
Fix
When I move the 'export type ...' code block below the namespace declaration (to the end the file), instead of the start, the issue is fixed.
Expected Behavior:
The @types/angular-ui-router should not block typescript compilation.

This is an issue with the DefinitelyTyped type definitions (which are not maintained by the ui-router team).  Please file this issue here: https://github.com/DefinitelyTyped/DefinitelyTyped/issues


Adding support for inline chat

This adds in support for loading as inline chat, with the default set to false to not affect existing users.
Tests added to confirm the setting is passed through if it's set to true, but not if it's set to false.
This will require a new setting to be toggled by the account owner at segment.com for setting the chat to inline chat mode.

Recommend adding a new checkbox in the advanced options section for olark, to enable inline chat, defaulted to false.
More info on inline chat here: https://www.olark.com/help/inline-chatbox

@ndhoule wondering if someone there can check this over for a merge?

Sorry for the delay, I'll take a look this week and push it out this week.

Fantastic, thanks.

@duellsy deploying this now, if you could let me know the exact description you'd want to show up in our app, that would be awesome.
This is what I have now:
   "inline": {
      "default": false,
      "description": "Configures whether the chat box should be inlined or not",
      "label": "Use inline chat box",
      "type": "boolean"
    },

That looks perfect to me, thanks!


Failure after adding the Mail and Packages integration

After clicking on the "Mail and Packages" integration, I get a long loading screen and then it fails and throws me back to the integrations list.
Reproduce: after installing using HACS I go to the integrations page, search for Mail and Packages integration.

fetch-with-auth.ts:20 POST https://hassio-url.ui.nabu.casa/api/config/config_entries/flow net::ERR_EMPTY_RESPONSE

I see the error in my console.
After clicking to add the integration, I get a spinner for about a minute then it fails and I get the error.

This is with version 0.1.1?
Are you using HassIO/Docker?
On a Pi?

yes, version Installed: 0.1.1
Hassio on a RPI3

Should be fixed with 0.1.2.

@zarurc Did the latest version work for you?

Yes it did. thank you!
I had to uninstall and reinstall M&P integration but it is working now.
On Thu, Feb 27, 2020 at 4:09 PM Chris<EMAIL_ADDRESS>wrote:

@zarurc https://github.com/zarurc Did the latest version work for you?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/moralmunky/Home-Assistant-Mail-And-Packages/issues/46?email_source=notifications&email_token=ACNCAGMPYWYWZAIWTGILVQDRFATZHA5CNFSM4K3VH54KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENF6WFQ#issuecomment-592177942,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACNCAGJ7B4VAD72OAXEGH33RFATZHANCNFSM4K3VH54A
.


Temporary support

Hey,
Thanks for the awesome module and your help so far! Looks like there are few PRs awaiting merging - is anyone having a more up to date fork? I'd be interested in maintaining it
Cheers

Sorry about that If you submit a PR I'll get to it!

I have some bits made internally, can send it over when i am back from Amsterdam

Awesome thanks!


Any plans for adding feature of voting (e.g. like/dislike) for papers?

Again, would be nice to be able to rank/sort papers in a distributed fashion, e.g. among members of a research group. The more likes a paper collects the more likely it is to be discussed in the next reading group or the like.

I see, you're imagining a within-a-group system, so these would not be visible to general visitor of the site, only to people of some group.

I was indeed but this could be very nice also for a public system, extending towards a reviewing interface
maybe similar to http://theoj.org/

I was indeed but could also be interesting as a feature for a public site

@andreas-bulling I think that would only be interesting if you could see who was voting (e.g. by connecting to http://orcid.org/). A vote by random people from the internet is probably not worth so much whereas votes by Hinton, Bengio, LeCun in deep learning would be worth a lot more.
A similar idea would be to get reviews. Sites I have heard about (but not used so far) are:

https://publons.com/
https://pubpeer.com/

@MartinThoma You mean e.g. use the h-index from Google Scholar to use as the weight on the vote?

@pgericson I was rather thinking of just the possibility to get a list of who has voted (similar to facebook likes). However, I think not showing the number of people who have voted but a h-index weighted score would be much better.

Upvoting of papers is now implemented as people adding papers to their library. There will be no downvoting. Closing issue.


Move bottom controls to left

If atom-ide-ui installed, bottom controls are after errors/warnings
My user style to fix this
.platformio-ide-terminal.status-bar {
  float: left;
  i, .status-container {
    display: inline;
  }
}

Before

After

We can't merge it. Package internally decides the place for status bar icons.


RP2040 build instructions - pico_sdk 2.0 compatibility

It looks like the latest pico_sdk (2.0) omits stdlib.h so the current source won't make without installing the previous release.

I would be very surprised if stdlib was not supported in the pico sdk, anymore. Many projects would run into this.

It looks like it has moved here in the src folder but set_sys_clock_khz has been removed from the file, which prevents the build.

I just successfully built FPGA-Companion 1.0.0 with pico-sdk SDK 2.0.0.
Initially, I encountered some issues.
They were resolved after I deleted FPGA-Companion and started from scratch by cloning the repository again.
Note the line: You should delete/recreate all build directories when upgrading from previous versions of the Raspberry Pi Pico SDK 2.0.0 in the release notes.
Maybe this is the reason here.

I just successfully built FPGA-Companion 1.0.0 with pico-sdk SDK 2.0.0. Initially, I encountered some issues. They were resolved after I deleted FPGA-Companion and started from scratch by cloning the repository again.
Note the line: You should delete/recreate all build directories when upgrading from previous versions of the Raspberry Pi Pico SDK 2.0.0 in the release notes.
Maybe this is the reason here.

I just did the same. Wiped my directories and started completely from scratch and it worked this time using the 2.0 SDK.


How to add decorators to a class view single method?

I want to add a decorator to the class view single method how do I do that?
For example, I want to add a permission validation decorator to the delete method.

@junxi3166 I'm using a variant where I check for request method inside decorator produced by kinda "factory" (of course, you can refactor it):
from functools import wraps
from sanic.response import json

def authorized(methods=['PATCH', 'PUT', 'POST', 'DELETE']):
    def decorator(f):
        @wraps(f)
        async def decorated_function(request, *args, **kwargs):
            if request.method not in methods:
                response = await f(request, *args, **kwargs)
                return response
            if request.token:
                token = request.token
                user_id = await request.app.redis.get('TOKEN:{}'.format(token))
                if user_id:
                    response = await f(request, *args, **kwargs)
                    return response
            return json({}, 403)
        return decorated_function
    return decorator

...then adding it like this:
class BaseAPI(HTTPMethodView):
    decorators = [authorized(methods='DELETE')]

    async def get(self, request):  # <- No need permissions
        return json({'item': {'id': 25, 'name': 'Kate'}})

    async def delete(self, request):  # <- Will require token
        return json({'message': 'OK'})

Thank you very much. Your method is feasible.
This is one of the ways I think of, you can use a decorator on a single method, do you think it's possible for me to do that? I'm a novice programmer, and I wonder why sanic officials don't recommend using class views, just passing the class view.
def outter(func):
    @wraps(func)
    async def inner(cls, request, *args, **kwargs):
        if request.app.token:
            return await func(cls, request, *args, **kwargs)
        return response.text('failed')

    return inner

class Index(View):

    async def get(self, request):
        pass

    @outter
    async def post(self, request):
        pass


sql/internal/specutil: fix missing schema name for table

Please test this also in the sql/hcl integration test ?
https://github.com/ariga/atlas/blob/master/internal/integration/hclsqlspec/hclsqlspec_test.go

Nothing to test there, it doesn't go via the problematic flow.


JAVA-REGEX

Closing Issue/Referencing Issue
issue reference (#)
Changes Made In Pull Request

Fixed the Typo in Contributing.md
Added Myself in README.md
Added the Solution to a JAVA Code from Hackerrank.
Link to Problem :
https://www.hackerrank.com/challenges/java-regex/problem

Please add the topic hacktoberfest in this repo so that it counts in the segment... You can do it from the settings of the repo... from the topics section.


query about uploading a project

there is no way to upload a project in NS-Playground.

@aamirkhurshid, thanks for the feedback. Currently there's no way to upload existing projects because normally we would expect users with existing projects to be running them on their local machines - using the NativeScript CLI or Sidekick.
The Playground is designed for discovering NativeScript or quickly prototyping some new ideas. And if the prototype turns out to be useful, download it and continue developing it on your local environment.
However if there's strong interest for this we might consider enabling it in the future.

+1


Update KOReader to v2020.09

I went through and used the 'add suggestion' feature to augment matteo's comments with suggestions (which can be batch committed by eeems)
mea culpa here on a lot of the issues matteo surfaced (i put in wrong timestamp, wrong license, wrong desc, etc), so thanks for fixing and upgrading


[Bug]: hitting a panic when saving file changes while running with --watch enabled

System Info
System:
OS: macOS 14.7.1
CPU: (10) arm64 Apple M1 Max
Memory: 15.02 GB / 64.00 GB
Shell: 5.9 - /bin/zsh
Binaries:
Node: 16.20.1 - ~/.volta/tools/image/node/16.20.1/bin/node
npm: 8.19.4 - ~/.volta/tools/image/node/16.20.1/bin/npm
pnpm: 8.15.6 - ~/Library/pnpm/pnpm
Browsers:
Chrome: 130.0.6723.117
Edge: 130.0.2849.80
Safari: 18.1
npmPackages:
@rspack/cli: 1.1.0 => 1.1.0
@rspack/core: 1.1.0 => 1.1.0
Details
Hi, I started hitting a panic when saving file changes under normal development conditions while running with --watch enabled.
The issues started after updating @rspack/cli and @rspack/core from 1.0.14 -> 1.1.0.
Panic occurred at runtime. Please file an issue on GitHub with the backtrace below: https://github.com/web-infra-dev/rspack/issues
Message:  Chunk should be added before
Location: crates/rspack_core/src/chunk_graph/chunk_graph_chunk.rs:185

Run with COLORBT_SHOW_HIDDEN=1 environment variable to disable frame filtering.
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ BACKTRACE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 1: _napi_register_module_v1
    at <unknown source file>
 2: _napi_register_module_v1
    at <unknown source file>
 3: _napi_register_module_v1
    at <unknown source file>
 4: _napi_register_module_v1
    at <unknown source file>
 5: _wasmer_vm_f64_nearest
    at <unknown source file>
 6: _wasmer_vm_f64_nearest
    at <unknown source file>
 7: _napi_register_module_v1
    at <unknown source file>
 8: _napi_register_module_v1
    at <unknown source file>
 9: _napi_register_module_v1
    at <unknown source file>
10: _napi_register_module_v1
    at <unknown source file>
11: _napi_register_module_v1
    at <unknown source file>
12: _napi_register_module_v1
    at <unknown source file>
13: _napi_register_module_v1
    at <unknown source file>
14: _napi_register_module_v1
    at <unknown source file>
15: __pthread_joiner_wake
    at <unknown source file>
 ELIFECYCLE  Command failed with exit code 129.

Reproduce link
No response
Reproduce Steps

Run pnpm run rspack --watch.
Make a change to a file and hit save.

Unfortunately it doesn't always happen and there is no obvious pattern to when it does.
A colleague of mine could reproduce it on his x86 Linux system so it's not macOS specific.

Can you provide a produce repo?

I think I am seeing this in my 10ten-ja-reader project.
STR:

git clone https://github.com/birchill/10ten-ja-reader.git
cd 10ten-ja-reader
pnpm install
pnpm start:firefox
Wait for a few minutes for the dictionaries to download and something causing a file to be touched (I think)

I get the following output:

I've bisected this to this changeset that updates rspack from 1.0.14 to 1.1.0.
I'm actually not quite sure what triggers the panic so if there's extra logging I can try please let me know.


Flang 19 build does not export symbols

When building DLLs with flang 19 via meson, linking of executables against the DLL fails due to not visible symbols.
Example: pipeline (https://github.com/conda-forge/mctc-lib-feedstock/pull/17)
[75/77] Linking target app/mctc-convert.exe
FAILED: app/mctc-convert.exe app/mctc-convert.pdb
"flang-new"  -Wl,/OUT:app/mctc-convert.exe app/mctc-convert.exe.p/main.f90.obj "-I%PREFIX%\Library\include" "-Wl,/nologo" "-Wl,/DEBUG" "-Wl,/PDB:app\mctc-convert.pdb" "-Wl,-defaultlib:D:/bld/mctc-lib_1730787576340/_build_env/lib/clang/19/lib/windows/clang_rt.builtins-x86_64.lib" "-D_CRT_SECURE_NO_WARNINGS" "-fms-runtime-lib=dll" "-fuse-ld=lld" "mctc-lib.lib" "-Wl,/SUBSYSTEM:CONSOLE"
lld-link: error: undefined symbol: _QMmctc_io_readPread_structure_from_file
>>> referenced by %SRC_DIR%\app\main.f90:63
>>>               app/mctc-convert.exe.p/main.f90.obj:(_QQmain)
>>> referenced by %SRC_DIR%\app\main.f90:75
>>>               app/mctc-convert.exe.p/main.f90.obj:(_QQmain)

lld-link: error: undefined symbol: _QMmctc_io_readPread_structure_from_unit
>>> referenced by %SRC_DIR%\app\main.f90:73
>>>               app/mctc-convert.exe.p/main.f90.obj:(_QQmain)
>>> referenced by %SRC_DIR%\app\main.f90:61
>>>               app/mctc-convert.exe.p/main.f90.obj:(_QQmain)

...

flang-new: error: linker command failed with exit code 1 (use -v to see invocation)

Example: pipeline (https://github.com/conda-forge/toml-f-feedstock/pull/13)
[56/64] Linking target test/version/tftest-version.exe
FAILED: test/version/tftest-version.exe test/version/tftest-version.pdb
"flang-new"  -Wl,/OUT:test/version/tftest-version.exe test/version/tftest-version.exe.p/version.f90.obj "-I%PREFIX%\Library\include" "-Wl,/nologo" "-Wl,/DEBUG" "-Wl,/PDB:test\version\tftest-version.pdb" "-Wl,--allow-multiple-definition" "-Wl,-defaultlib:D:/bld/toml-f_1730763821033/_build_env/lib/clang/19/lib/windows/clang_rt.builtins-x86_64.lib" "-D_CRT_SECURE_NO_WARNINGS" "-fms-runtime-lib=dll" "-fuse-ld=lld" "toml-f.lib" "-Wl,/SUBSYSTEM:CONSOLE"
lld-link: warning: ignoring unknown argument '--allow-multiple-definition'

lld-link: error: undefined symbol: _QMtomlf_versionPget_tomlf_version

>>> referenced by %SRC_DIR%\test\version\version.f90:23

>>>               test/version/tftest-version.exe.p/version.f90.obj:(_QQmain)

flang-new: error: linker command failed with exit code 1 (use -v to see invocation)

Environment: conda info
     active environment : base
    active env location : D:\Miniforge
            shell level : 1
       user config file : C:\Users\VssAdministrator\.condarc
 populated config files : D:\Miniforge\.condarc
                          C:\Users\VssAdministrator\.condarc
          conda version : 24.9.2
    conda-build version : 24.9.0
         python version : 3.12.7.final.0
                 solver : libmamba (default)
       virtual packages : __archspec=1=x86_64_v4
                          __conda=24.9.2=0
                          __win=0=0
       base environment : D:\Miniforge  (writable)
      conda av data dir : D:\Miniforge\etc\conda
  conda av metadata url : None
           channel URLs : https://conda.anaconda.org/conda-forge/win-64
                          https://conda.anaconda.org/conda-forge/noarch
          package cache : D:\Miniforge\pkgs
                          C:\Users\VssAdministrator\.conda\pkgs
                          C:\Users\VssAdministrator\AppData\Local\conda\conda\pkgs
       envs directories : D:\Miniforge\envs
                          C:\Users\VssAdministrator\.conda\envs
                          C:\Users\VssAdministrator\AppData\Local\conda\conda\envs
               platform : win-64
             user-agent : conda/24.9.2 requests/2.32.3 CPython/3.12.7 Windows/2022Server Windows/10.0.20348 solver/libmamba conda-libmamba-solver/24.9.0 libmambapy/1.5.10
          administrator : True
             netrc file : None
           offline mode : False

Environment: conda list
    flang:              19.1.3-hbeecb71_0         conda-forge
    flang_impl_win-64:  19.1.3-h719f0c7_2         conda-forge
    flang_win-64:       19.1.3-h719f0c7_2         conda-forge

If those symbols are coming from the C/C++ side, they probably need to be annotated by __declspec(dllimport), because now that part is handled by MSVC, which doesn't export images by default (in contrast to gcc through m2w64_*)


Go Control structures

Need to finish draft for the following:
I) Key concepts:

if; if-else; if-elseif-else
Switch
2.1) Basics and default case
2.2) Multiple values in case condition
2.3) Boolean expressions in case conditions
2.4) fallthrough statement and how it works
2.5) short switch

Note:
All drafts should follow following template:
1) Key concepts
2) Potential interview questions (2-5) with answers and explanation
3) A few practice questions (5-10)

finished draft


multiple sources

I want to have the source be the file that I am displaying, plus 2 other files.  I tried:
"[[fulll/path/this file]] [[full/path/elsewhere/file]] [[full/path/yetanother/stuff]]"
and it dodt display events from the other files and actually lost events in the calendar from the base file.  Can you clarify the README:
A)  Will the base file always be included in the calendar display and overall display
B) What is syntax for multiple files in multiple locations in the vault
Thanks.

Hey there -- sorry, @pcause, but please open feature requests and questions in the "Discussions" tab.  Issues on this project are for bugs & planned projects.
Cheers!


Update uuid to version 3.0.0

Version 3.0.0 of uuid just got published.
Hi there,
This week a new version of the uuid module got released. The old module which was available by the name node-uuid got deprecated and will show error message upon every install of the module.
To get rid of those install errors I've created this automated pull request. I've run some checks against your code base to test whether you're using one of the deprecated apis, but this isn't the case.
Please test the changes against your code. I didn't run any tests and therefore can't guarantee that it isn't breaking. You can also just close this pr if you don't want to update your module.
In case there's already another pr open to upgrade uuid, I'm sorry for the effort I'm causing.

@AdamMagaluk Hot take for this one?

Closing, node-uuid will still work. But for all new stuff use uuid.


[BACKLOG-21649] Addding Scale.java; passing hardcoded strings to Cons…

…t.java; adding a few more tests on PanIT
@pentaho/rogueone please review

Build Completed
:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -Dsurefire.runOrder=alphabetical -B -fn -f 'pom.xml' -pl 'engine,core' -P '!assemblies' -amd clean install && mvn -B -f 'pom.xml' -pl 'engine,core' -P '!assemblies' -amd site

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'engine,core' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  core/src/main/java/org/pentaho/di/core/Const.java
  core/src/main/java/org/pentaho/di/core/KettleClientEnvironment.java
  engine/src/it/java/org/pentaho/di/pan/PanIT.java
  engine/src/main/java/org/pentaho/di/pan/Pan.java
  engine/src/main/java/org/pentaho/di/scale/Scale.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes: <0.1% (click to expand)
org.pentaho.di.job.entries.getpop.MailConnectionMeta

Branch Change: -1% :small_red_triangle_down:
Complexity Change: -1.5% :small_red_triangle_down:
Instruction Change: -0.3% :small_red_triangle_down:

org.pentaho.di.job.entries.sql.JobEntrySQL

Instruction Change: -3.3% :small_red_triangle_down:
Line Change: -3.9% :small_red_triangle_down:

:new: org.pentaho.di.scale.Scale

Coverage: 0% :exclamation:

org.pentaho.di.trans.steps.checksum.CheckSumMeta

Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.datagrid.DataGridMeta

Branch Change: -2% :small_red_triangle_down:
Complexity Change: -1.7% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.groupby.GroupByMeta

Branch Change: -3.1% :small_red_triangle_down:
Complexity Change: -3.1% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:
Line Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.insertupdate.InsertUpdateMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.rowgenerator.RowGeneratorMeta

Branch Change: -2.6% :small_red_triangle_down:
Complexity Change: -1.5% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.tableoutput.TableOutputMeta

Branch Change: -0.9% :small_red_triangle_down:
Complexity Change: -0.8% :small_red_triangle_down:

org.pentaho.di.www.TransformationMap

Branch Change: -13.7% :small_red_triangle_down:
Complexity Change: -9.3% :small_red_triangle_down:
Instruction Change: -15.5% :small_red_triangle_down:
Line Change: -14.6% :small_red_triangle_down:

org.pentaho.di.trans.steps.gpload.GPLoadMeta

Branch Change: -0.9% :small_red_triangle_down:
Complexity Change: -0.8% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

Checkstyle violations
The code submitted is not complying with one or more of our guidelines. To perform these checks locally, please use this tool.
/home/buildguy/project/engine/src/main/java/org/pentaho/di/scale/Scale.java

:heavy_exclamation_mark: File does not end with a newline. at Line: 0

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -Dsurefire.runOrder=alphabetical -B -fn -f 'pom.xml' -pl 'engine,core' -P '!assemblies' -amd clean install && mvn -B -f 'pom.xml' -pl 'engine,core' -P '!assemblies' -amd site

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'engine,core' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  core/src/main/java/org/pentaho/di/core/Const.java
  core/src/main/java/org/pentaho/di/core/KettleClientEnvironment.java
  engine/src/it/java/org/pentaho/di/pan/PanIT.java
  engine/src/main/java/org/pentaho/di/pan/Pan.java
  engine/src/main/java/org/pentaho/di/scale/Scale.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes: <0.1% (click to expand)
org.pentaho.di.job.entries.evaluatetablecontent.JobEntryEvalTableContent

Branch Change: -1% :small_red_triangle_down:
Complexity Change: -1% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.job.entries.ftpsget.JobEntryFTPSGet

Branch Change: -0.5% :small_red_triangle_down:
Complexity Change: -0.6% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

:new: org.pentaho.di.scale.Scale

Coverage: 0% :exclamation:

org.pentaho.di.trans.steps.insertupdate.InsertUpdateMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.setvalueconstant.SetValueConstantMeta

Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.singlethreader.SingleThreaderMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.uniquerows.UniqueRowsMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.www.TransformationMap

Branch Change: -1.2% :small_red_triangle_down:
Instruction Change: -4.7% :small_red_triangle_down:
Line Change: -3.8% :small_red_triangle_down:

org.pentaho.di.trans.steps.salesforceinsert.SalesforceInsertMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.salesforceupsert.SalesforceUpsertMeta

Instruction Change: -0.1% :small_red_triangle_down:

Ignoring coverage warning from wingman as the changes are in existing class and the new class just has a main method.


Command fixes for info and version command

:nut_and_bolt: Description: What code changed, and why?
For chef-automate version command, when used on bastion on chef-automate HA will show this message
"Server Build : For getting chef-automate version, Please login to chef-automate and use command chef-automate version " instead of an deployment error message like this FileAccessError: Unable to access the file or directory: Failed to read deployment-service TLS certificates: Could not read the service cert: open /hab/svc/deployment-service/data/deployment-service.crt: no such file or directory
For chef-automate info command, had alignment issues
Now will look this way

:chains: Related Resources
:+1: Definition of Done
:athletic_shoe: How to Build and Test the Change
build components/automate-cli
hab pkg install < automate-cli-package > -bf
build components/automate-cluster-ctl
hab pkg install  < automate-cluster-ctl package > -bf
:white_check_mark: Checklist
All PRs must tick these:

[ ] I have read the CONTRIBUTING document.
[ ] All commits signed-off for the Developer Certification of Origin.

With occasional exceptions, all PRs from Progress employees must tick these:

[ ] Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
[ ] Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
[ ] Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
[ ] Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
[ ] Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

[ ] Tests added/updated? (all new code needs new tests)
[ ] Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.
:camera: Screenshots, if applicable

bump the automate-baackend-deployment pkg as well. Add the screen shot.

Done


Code for SDC Net

Hi,
Can you share the code and pretrained models (if available) for SDC-Net? I saw SDC Net github.io page, but it doesn't have a link for the code.

Hi, the code for SDC layer is at:
https://github.com/NVIDIA/semantic-segmentation/tree/master/sdcnet/spatialdisplconv_package
And our pretrained SDCNet model on Cityscapes is at:
https://drive.google.com/file/d/1OxnJo2tFEQs3vuY01ibPFjn3cRCo2yWt/view?usp=sharing
However, the full pipeline and pretrained models in the original SDCNet paper are not available in this repository.

Thank you. Is there a separate repository for SDC net? If so, can you provide the link for that?

I'm sorry, but I don't think there is a separate repository for SDCNet at this moment.


removed redundant line of code

In building this functionality into the booklet-generator project I realized that because Javascript objects are assigned by reference that line 273 does update the value of result[I] so line 274 was thus redundant.
This is a super miniscule thing to change, but since I noticed it I figured I'd do a pull request.

hey @mathteacher this is a good catch. going forward, could you make your pull requests from branches for these features in this repository? i'd like to be able to make tweaks, in this case for example to make the same change to the search key a few lines down.

also please npm run prod when you commit, thanks

hi @joshreisner, that all makes sense
I didn't realize I had access to create branches and push to them in the meeting-guide/react repository but I just tested it and definitely do, so I will now do so going forward.
I will try not to forget the npm run prod again. I actually did remember, but then forgot I had to "git add" the new files for it.


Add missing files

@nicolasnoble This does not seem to cause a problem in our bazel build basic jenkins test. That seems like a problem.

@nicolasnoble this breakage was not caught by jenkins. any idea why?

Bazel Basic Build passed. merging.


[1pt] PR: stop the code if there is no conflated model

Summary
This PR will check the result of conflation step (step 2) and will stop the code if no conflated model exists.
This PR addresses issues #82 and #47
Background
Ras2fim needs at least one conflated model (one HEC-RAS model that its cross sections intersect with NWM reaches).  If none of the user provided HEC-RAS models conflates to NWM reaches in the given HUC8, then the code should inform the user and terminate.
The file "***_stream_qc.csv" in folder '02_shapes_from_conflation' is the best place to check for this situation. This file should contain at least one record (one conflated model). During Step 5, ras2fim reads this file to start making sub HEC-RAS models.
Changes

src/conflate_hecras_to_nwm.py
   called the "errors.check_conflated_models_count()" function to check the number of records in the  "***_stream_qc.csv" file.

src/errors.py
   Added the definition of "errors.check_conflated_models_count()" function.

Testing
Successfully (with an instructive error message) stopped the code if no conflated model exists.
Checklist
You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.

[x] Informative and human-readable title, using the format: [_pt] PR: <description>
[x] Links are provided if this PR resolves an issue, or depends on another other PR
[x] If submitting a PR to the dev branch (the default branch), you have a descriptive Feature Branch name using the format: dev-<description-of-change> (e.g.: dev-revise-levee-masking)
[x] Changes are limited to a single goal (no scope creep)
[x] The feature branch you're submitting as a PR is up to date (merged) with the latest dev branch
[x] Changes adhere to PEP-8 Style Guidelines
[x] Any change in functionality is tested
[x] New functions are documented (with a description, list of inputs, and expected output)
[x] Placeholder code is flagged / future todos are captured in comments
[x] Project documentation has been updated (CHANGELOG and/or README)
[x] Reviewers requested

Sorry that I was unable to get back to this earlier Ali.  Issue #82 talks about an error that gives us ValueError: Cannot write empty DataFrame to file.  There are at least one way to trigger it which is having invalid models in the original input models folder. It is easy mistake to make and when the error occurs, it is very unclear. At a minimum, we need to handle this error with a more descriptive error, but better yet.. the code should know "why" it failed, which could be more than one way.  We know of one way it can fail, but we need to research and add code to figure out other permutations of why it could fail and put up an appropriate error message.

Rob,
Regarding "the code should know "why" it failed", this PR's goal is NOT to answer this question. You can have another PR to answer that.
The goal of this PR is just to stop the code when there is ZERO conflated models for ras2fim to process, so the user won't see that random error you are referring to (ValueError: Cannot write empty DataFrame to file)
I do not see any needed change on the PR.

I think there is a conceptual misunderstanding of this PR. We will need to discuss this offline.

ok. Can you tell me how I can test for this PR? (without having to manually change or edit any files from the 01 to 05 directories?  I just put in non valid model files in the "models" folder, which was the fix I was hoping for.  But.. as you mentioned.. you interpret #82 as a different problem. No problem. maybe  tell me how to replicate the problem and test the fix and we can move forward :)

You can test your previous failed run as you were doing before, and let's see what happens.

As a summary, this PR does not fully address issue #82, so this PR will not close #82. The issue #82 requests handling all sorts of input errors (such as run arguments or provided models). This PR only addresses the cases of #82 in which all arguments and models are correct and consistent, but no HEC-RAS model is conflated into NWM reaches of the given HUC8.

@RobHanna-NOAA
Below is how I was testing the PR. My "modelsFolder" has a single HEc_RAS model called "5791800_CLEAR 177_g01_1678771301"
python ras2fim.py -w 12090301 -i modelsFolder -o NoConflateTestOutput -p EPSG:2277 -mc C:/Users/rdp-user/Desktop/runFolder/models/OWP_ras_models_catalog_12090301.csv -t C:\Users\rdp-user\Desktop\runFolder\12090301_dem_meters_0_2277.tif
Running above, get this error message:


Auto import inserts import into a comment

VSCode Version: Code - Insiders 1.19.0-insider (d294b25f2dd5c96d89bd23f82bd5fd2c0958a4bd, 2017-11-21T06:34:51.660Z)
OS Version: Windows_NT x64 10.0.16299
Extensions: Extensions are disabled

Steps to Reproduce:

Create a new folder
Open in Code
npm i @types/node
Create index.js
Type /// <reference types="node" />
Type setTimeout, select the auto import suggest.

Expected Result:
/// <reference types="node" />

import { setTimeout } from "timers";

setTimeout

Actual Result:
/// <reference types="node" />import { setTimeout } from "timers";

setTimeout

This issue was moved to Microsoft/TypeScript#20293


feat: add regions to GCP containers

Description
Add regions to GCP
Link to any related issue(s):
Type of change:

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Required Checklist:

[x] I have signed the MongoDB CLA
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added any necessary documentation (if appropriate)
[x] I have run make fmt and formatted my code

Further comments

I've created CLOUDP-83412, and we'll try to fit this in the coming weeks


Get random icon

Could you provide a way to get random icons?
Thank you :)

Hey there -- I don't know if that's really a common request and I don't think it quite makes sense in the core library. That said, you can definitely generate that type of code by modifying the code generator found in the tool folder!


Transformation of Number

Hi @thim81, we've seen that latest version, specifically this commit, is affecting numbers used in escaped values.
As an example, we use a vendor extension in our specs:
      x-typescript-params: |-
        {
          id: 'id_example',
          payment: {
            currency: 'USD',
            currency_rate: 0.69,
            total_amount: 49.99,
            reference: '123456',
            payment_method: 'Credit Card',
            payment_method_reference: '123456'
        }

Running 1.10.0 results is the following:
      x-typescript-params: |-
        {
          id: 'id_example',
          payment: {
            currency: 'USD',
            currency_rate: '0.69===',
            total_amount: '49.99===',
            reference: '123456',
            payment_method: 'Credit Card',
            payment_method_reference: '123456'
        }

Maybe an edge case, but thought you should know

@nicklloyd thanks for reporting. I m working on a bug fix release for some unwanted conversion. I ll include this bug since this is clearly not desired.


all: update copyright headers for 2019

Codecov Report

Merging #219 into master will decrease coverage by 1.11%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #219      +/-   ##
=========================================
- Coverage   68.31%   67.2%   -1.12%
=========================================
  Files          31      31
  Lines        2964    2964
=========================================
- Hits         2025    1992      -33
- Misses        744     785      +41
+ Partials      195     187       -8


Fix hardhat deploy script

Fixes #252
Approach :
Used the $@ in deploy script, This will pass all the command line args hardhat deploy.
Test :

Nice catch @technophile-04
thank you!!


Support 'strict typing mode' (mypy compatibility) for improved performance and correctness

I use mypy to ensure type safety and avoid runtime errors. Functions are annotated and typing is enforced. However, PLS hovers and completions are based on heuristics that aren't as strict as typing rules used by mypy ( / pyright / pyre / pytype).
Some of the differences:

PLS infers return types based on function body
PLS infers parameter types based on function calls
PLS parses untyped third party modules.

In short PLS is 'too smart' for me. This causes PLS to be quite slow when there are large third-party modules installed (scipy etc). Also, hovers and completions don't match the 'true' mypy types and I find myself needing reveal_type a lot.
This is a feature request to support a "mypy-compatible" strict typing mode, that will also be faster (as a side effect). Seems like pyright is on the right track for this with hovers / go to definition -- but it doesn't support code completion, find references, refactor etc -- and isn't clear whether it intends to do so.
In case you are interested in supporting this use case, I've made a POC for PLS where I've disabled some inferences and changed module resolution to only take stubs for third-party libs. Here's the diff (warning: messy poc code). The downside is that now documentation is missing (because Typeshed doesn't have docs) and navigation goes to stub files (not so bad).
Code examples for things that are 'too smart':

PLS infers return types based on function body:
def blah():
    return 'hi'
b = blah()
# reveal_type(b) => PLS: str, mypy: Any

PLS infers parameter types based on function calls:
def blah2(param):
    # reveal_type(param) => PLS: str, mypy: Any
    pass
c = blah2('hello')

PLS infers types from operators:
something = undefined_variable + 3
# reveal_type(something) => PLS: int, mypy: Any

This is an old issue, but you'd be interested in checking out Pylance, which uses Pyright for type checking. Announcement here: https://devblogs.microsoft.com/python/announcing-pylance-fast-feature-rich-language-support-for-python-in-visual-studio-code/


chore(build): add github workflow for LL e2e tests

Overview
This PR adds a github workflow for running LL end to end tests. Most of this was copied from the github action for pd e2e tests.
Changelog

Add github workflow for LL e2e tests

Risk assessment
Low

Not sure why this action isn't running...


Can i get some help Please Proxy Settings

hey does proxy work on Elementum i try putting my setting on the addon but it not working i have pia vpn proxy i know my proxy works on quasar how can i make it work on Elementum

It works fine if you fill it correctly.
You should have posted any information.


controller-gen use of line breaks varies minimally on operator system

So make generate-crds behaves differently with respect to line breaks
It works as desired on ubuntu, but not

fedora
macOS

There is an upstream issue https://github.com/kubernetes-sigs/controller-tools/issues/514 which has been closed but folks are still reporting seeing problems, including @imjasonh from our community
Currently, our github action verify job runs make generate-crds to verify consistency, and since that runs on ubuntu, you need to conform to the ubuntu behavior.
I've started working on a tailored ubuntu based image where if you mount your local branch into a subsequent container running that image, you can run make generate-crds from within the container but update your local branch properly.
We could either publish that image to a public shipwright communit repo on quay.io, and then add a make target to leverage that via a container with local mount, or even add a target that builds that image locally, and then runs a container with local mount.  My only hiccup there is the install of golang on ubuntu require more interaction besides what the "yes to install prompts" option covers, as it wants you to select geography, etc.  Figuring out how to pre-supply those choices so interaction is not involved would be required.
And ultimately, some updating of the contributor guide and maybe PR template to warn contributors of this seems warranted.

Groomed.

@gabemontero  planning to work on #586 which would include this as well

@gabemontero planning to work on #586 which would include this as well

awesome thanks @MayukhSobo

Accepting this into the general backlog.

https://github.com/shipwright-io/build/pull/873 should also helps working around this issue until kustomize and controller-gen bump their version of kyaml
The workaround while using the development tools image is to run:
CONTAINER_ENGINE=podman make container-make TARGET=generate-crds

@gabemontero @adambkaplan I think the issue was resolved in the meantime. On my local machine, I deleted the CRDs and ran make generate-crds in different containers to verify that the CRDs are regenerated the same way they were before. For me, it worked on my local macOS, Ubuntu, and RHEL (UBI).

thanks for the info @HeavyWombat , that said
In RH dev we actually run with "fedora" here instead of rhel (part of RH dev validating the upstream before it gets downstreamed to rhel).
It is on fedora that we are hitting issues.
We are exploring here locally some between @akram and myself when we have cycles
But given that, I want to keep this open until we reach a conclusion there.

@HeavyWombat I tried yesterday on macosx with<EMAIL_ADDRESS>and the issue still happens. I have no line wrap on macos, but on ubuntu there is line wrap at 80 chars.

/assign akram

The update to the v0.6.2 version of controller-gen imo harminized this (= always uses line breaks). @gabemontero can you confirm that you can run this with the right version of controller-gen these days also on your machine without causing changes to line breaks?

Confirmed!!
Added a new Foo string field to the BuildSpec and make generate only made the additions for my new field, and did not reformat existing fields.
Good catch - thanks @SaschaSchwarze0
closing this out


Plutus v2, PQ2.0 migration

Currently a draft PR because

[x] [ISSUE MADE] The nix flake is pointed at ~plutarch-quickcheck/plutus-v2-migration~ plutarch-quickcheck/seungheonoh/pq2. Once that PR is merged we can change this back to the plutarch-quickcheck/main
[x] [ISSUE MADE] With the update to PQ2.0 included in this PR, I've commented out all of the tests from the .cabal file. We'll want to rewrite them, but I haven't given a close enough look at PQ2.0 to do that myself yet.
[x] I need to update the change log with a major version bump and some API changes, including

Some updates to functions involving datums, now that inline datums have a different API
Some updates to module names. In particular, Plutarch.Api.V1.* modules have been renamed to Plutarch.Extra.*.

going to merge once CI passes


feat: u256 division

Feature Request
Describe the Feature Request
Support division between u256 values.
Describe Preferred Solution
Provide a Div<u256> trait implementation.
Describe Alternatives
This could be built out of existing data types and binary operations in Cairo but that seems inefficient.
Related Code

Additional Context
This would enable various mechanisms for share conversion, yield, interest that are essential to operate money markets, vaults and other key DeFi products.

Would love to work on this if its not currently being worked on!


Added new words in the glossary

Added the following words in the glossary :

Test Driven Development
Shift-Left
Shift-Right

and updated those words in the glossary.js file

@DhruviThakkar210 Lint check is failing https://github.com/keploy/docs/actions/runs/5561930660/job/15479753390?pr=186 please refer to this

@Sonichigo please merge if rest is fine, since Dhruvi is not continuing.


support for os lists

This will add by default the following lists of supported OS
  "os": "Linux",
   "os_list": [
       "ubuntu14.04",
       "ubuntu16.04",
       "ubuntu18.04",
       "rhel7"
   ],

Following up on today's discussion:

@mnunberg: Here's how Python handles building binaries that are multi-distro compliant. AFAICT it also works with C++: https://github.com/pypa/manylinux
We'll definitely need to define the arch in the package metadata, as @ushachar said.
If we'll keep using multiple builds, it might be nice to adopt the standard convention of using package names that include OS and arch, such as redisearch-1.5.4-ubuntu-18.04-x86_64.

So it seems the tl;dr is that if one compiles on a sufficiently old version of libstdc++, it should work universally. I didn’t know this.

On Mar 20, 2019, at 10:52 AM, Gavrie Philipson<EMAIL_ADDRESS>wrote:
Following up on today's discussion:
@mnunberg https://github.com/mnunberg: Here's how Python handles building binaries that are multi-distro compliant. AFAICT it also works with C++: https://github.com/pypa/manylinux https://github.com/pypa/manylinux
We'll definitely need to define the arch in the package metadata, as @ushachar https://github.com/ushachar said.
If we'll keep using multiple builds, it might be nice to adopt the standard convention of using package names that include OS and arch, such as redisearch-1.5.4-ubuntu-18.04-x86_64.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/RedisLabs/RAMP/pull/18#issuecomment-474866359, or mute the thread https://github.com/notifications/unsubscribe-auth/AAanUf8KUTEfgKUMx2x_NheuHdeNFVKxks5vYksZgaJpZM4agEwA.

Indeed, that’s what it looks like. I’ll admit I haven’t verified this in
person, though.
On Thu, 21 Mar 2019 at 13:10 Mark Nunberg<EMAIL_ADDRESS>wrote:

So it seems the tl;dr is that if one compiles on a sufficiently old
version of libstdc++, it should work universally. I didn’t know this.

On Mar 20, 2019, at 10:52 AM, Gavrie Philipson<EMAIL_ADDRESS>wrote:
Following up on today's discussion:
@mnunberg https://github.com/mnunberg: Here's how Python handles
building binaries that are multi-distro compliant. AFAICT it also works
with C++: https://github.com/pypa/manylinux <
https://github.com/pypa/manylinux>
We'll definitely need to define the arch in the package metadata, as
@ushachar https://github.com/ushachar said.
If we'll keep using multiple builds, it might be nice to adopt the
standard convention of using package names that include OS and arch, such
as redisearch-1.5.4-ubuntu-18.04-x86_64.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <
https://github.com/RedisLabs/RAMP/pull/18#issuecomment-474866359>, or
mute the thread <
https://github.com/notifications/unsubscribe-auth/AAanUf8KUTEfgKUMx2x_NheuHdeNFVKxks5vYksZgaJpZM4agEwA
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/RedisLabs/RAMP/pull/18#issuecomment-475189561, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AARnjE0LA4UVPhtCvY-nNuat4k4BaWi7ks5vY2iOgaJpZM4agEwA
.

--
Gavrie Philipson
Cluster Architect
Phone: +972-54-5918005
Twitter https://twitter.com/redislabs  LinkedIn
https://www.linkedin.com/company/redis-labs-inc  Facebook
https://www.facebook.com/RedisLabs
[image: Redis Labs] https://redislabs.com/


Which event should be used to start the code?

When I used window.addEventListener('load', () => app(...)) the subs didn't work correctly, as they never seemed to receive the event. How should we handle this without adding the <script> to the last line of the HTML?

Note: It should work with both <script async ...> and <script> if possible.

Subscriptions are functions that run once when the DOM is ready.
So, I guess by the time the subscription was called, the window.load event had already fired.
What you want to do is make your subscription the function you'd call inside that event listener, the ellipsis (...) in your example.
Yes
subscriptions: [
  myFunction
]

Not
subscriptions: [
  _ => window.addEventListener('load', myFunction)
]

@jbucaran My bad, I thought it's obvious that ... is the whole hyperapp stuff. Won't it crash when it can't find the DOM yet? React didn't like being called before the 'onload' event.

Which event should be used to start the code?

What mean "to start the code"? You don't need anything. App should be called before the dom-is-ready. If something in your app should happen when DOM-is-ready put it into subscriptions.

Won't it crash when it can't find the DOM yet?

No.

@tunnckoCore I just removed the event listener and it caused a crash, as usual.
Uncaught TypeError: Cannot read property 'appendChild' of null
    at 108.module.exports (some-script…:104)
    at Object.475 (some-script…:1184)
    at __webpack_require__ (some-script…:20)
    at some-script…:66
    at some-script…:69

@dodekeract Is the problem the

@jbucaran No, it also appears without async.
Actually, now that I tested that it always happens when no async is used.

@dodekeract Can you break down the problem into a smaller problem?
First, try with this HTML
<!doctype html>
<html>

<body>
    <script src="/bundle.js"></script>
</body>

</html>

@jbucaran Loads reliably without crashing.

@dodekeract So, the problem may be in your other HTML, right?

@jbucaran I don't think so. I actually only moved the script down, didn't change the src= part or anything else.

@dodekeract How should we handle this without adding the

I'll have to create a completely minimal repro then. Current code has some stuff I can't share that's not related to hyperapp.

@dodekeract I just wanted to see if the location where you are embedding the bundle.js that contains both hyperapp and your application.

Still can't understand what we are talking about.

I'll have to create a completely minimal repro then.

:+1:

@tunnckoCore Me neither, but I suspect @dodekeract is embedding the bundle.js in the head.

@jbucaran @tunnckoCore https://github.com/dodekeract/hyperapp-issue-61
npm run build && npm run start
index.html and onload.html work while broken.html doesn't work.

@dodekeract Thanks for creating the demo repo.
It seems you are embedding your bundle.js in the <head> tag, when you shouldn't, because when you run app(...) and HyperApp calls document.appendChild(vnode) or something, document is still undefined.

@jbucaran Which is why I'm asking which event I'm supposed to use, as load seems to break the subs. 😉

@dodekeract Yup, now I see that's what you were asking indeed.
Isn't the solution to not embed the bundle in the <head> tag?

@jbucaran not possible in my use-case and I think that's actually more of a workaround. Until now I always used window.onload with an async script.

First to mention that app() does not return anything, so
window.addEventListener('load', app({

in index.onload.js is wrong thing.
Second, set something in the body and try to add opts.root.

@tunnckoCore Whoops, that's a typo, pushed the fix to the repo. However it actually did solve the crash. Don't ask me why though.

@dodekeract Ah, what @tunnckoCore said. Good job on catching that!

@jbucaran @tunnckoCore broken.root.html is also broken.

@dodekeract Of course broken.root.html is broken. You are calling document.getElementById inside <head>.

@jbucaran I'm aware of that. I didn't expect it to work. As I said I can't expect the script to be at the end of the body in my use-case.

@dodekeract So the problem is simply you need subscriptions and you're loading HyperApp via the <head> tag?

@jbucaran That's one way to put it, yes.

Okay, gotcha. Let's track this in #62.
The fix involves adding a bit of code to app.js. We need to check whether the DOM has already loaded before adding the DOMContentLoaded listener to document.
@dodekeract Can you work on a PR?

@jbucaran Is there any reason why we can't just treat "render app()" as the first sub?

Locking as the entire discussion is entirely out-of-date.


bug

Microsoft PowerToys version
0.58.0
Running as admin

[X] Yes

Area(s) with issue?
General
Steps to reproduce
I press "Fn" button on my keyboard in the choose button window, and it show "undefined".
And if I set "Shift+Fn" and I just press shift ,it will do the thing which I press "shift+Fn" it will do.
And I can't open settings window when I click the power toys button on task bar.
✔ Expected Behavior
No response
❌ Actual Behavior
No response
Other Software
No response

This is a documented incompatibility: https://docs.microsoft.com/en-us/windows/powertoys/keyboard-manager


Custom tooltips show [object Object]

Since version 2.1.5, custom tooltips show [object Object] instead of some of the tooltip data.
Here is a sample which shows the issue: http://codepen.io/anon/pen/grZwmE
This code was taken from your custom tooltip example which is now broken.
https://github.com/chartjs/Chart.js/issues/2775 is a similar issue which exists since 2.1.5. It was fixed in 2.1.6, however this one is still present in 2.2.0 RC2.

Looks like there was a change in the tooltip.body format. Updated codepen: http://codepen.io/anon/pen/qNopaV

Great, thanks for the new codepen. I see you still have the bug open though - so do you just need to fix the custom tooltip docs/example? Or do you want to go back to the previous tooltip.body format?

@znebby I think the most ideal is to go back to the old format. There is a related bug #3014 that could be fixed together. This was originally added in #2661


WTD #31442 updated storage-introduction.md

updated to remove gendered language

@rachrobins : Thanks for your contribution! The author, @tamram, has been notified to review your proposed change.


ganache-cli deprecated makes yarn unnecessary use npm install ganache instead

Makes life easier especially in combination of venv, nodeenv and ganache.
I recently added an article to the discussion group about using node npm in conjunction with python venv. This change simplifies the setup because yarn is no longer needed.

@cromewar Can you please help me to resolve this conflict? I am unfamiliar with the whole concept of merging branches. I believe this conflict stems from the fact, that one pull request was accepted and merged and this one was right next to it. What am I supposed to do here?

@n4n0b1t3 if you have forked the repo you should do a pull from the repo, in order to have the latest version, just then try to create a new pull request when your repo is updated to the original one.
As Patrick is the one who accepts the PL here I'll close this one just for simplicity, try to follow the instructions above and try again.
Best regards, Cromewar.


onFailure not getting called - onFailure(...) was not overriden, but callback was receiced

onFailure not getting called in my code, I have tried all three methods..
W/JsonHttpRH﹕ onFailure(int, Header[], String, Throwable) was not overriden, but callback was received
    private void get() {
        //Request parameters
        RequestParams params = new RequestParams();
        params.put("key", API_KEY);

       MyRESTClient.get("/posts/", null, new JsonHttpResponseHandler() {
            @Override
            public void onSuccess(int statusCode, Header[] headers, JSONObject response) {
                //some code
            }

            @Override
            public void onProgress(long bytesWritten, long totalSize) {
                mLoaderProgress.setText((long) 100 * bytesWritten / totalSize + "Loading...");
            }

            @Override
            public void onFailure(int statusCode, Header[] headers, Throwable throwable, JSONObject errorResponse) {
                super.onFailure(statusCode, headers, throwable, errorResponse);
                Log.d("Error----> ", ""+statusCode+" ------ "+ errorResponse);
            }
        });

    }

u need overwritter the function :
/**
* Fired when a request fails to complete, override to handle in your own code
* @param error the underlying cause of the failure
* @param content the response body, if any
*/
public void onFailure(Throwable error, String content) {
// By default, call the deprecated onFailure(Throwable) for compatibility
onFailure(error);
}

I tried your above function but still I get below message, and no log is generated...
W/JsonHttpRH﹕ onFailure(int, Header[], String, Throwable) was not overriden, but callback was received

I think I am overriding wrong method,
Below is  correct one and worked..
            public void onFailure(int statusCode, Header[] headers, String responseString, Throwable throwable) {
                super.onFailure(statusCode, headers, responseString, throwable);
                Log.d("Failed: ", ""+statusCode);
                Log.d("Error : ", "" + throwable);
            }

Yes, watch the LogCat if you're using the *ResponseHandler class correctly, it shows important warnings and errors there.

Hi Bro,
I have a error.
D/Failed:: 500
07-04 08:49:22.544 10043-10043/com.nhiepphong.NameCard D/Error :: cz.msebera.android.httpclient.client.HttpResponseException: Internal Server Error
07-04 08:49:22.857 10043-10043/com.nhiepphong.NameCard W/art: Before Android 4.1, method android.graphics.PorterDuffColorFilter android.support.graphics.drawable.VectorDrawableCompat.updateTintFilter(android.graphics.PorterDuffColorFilter, android.content.res.ColorStateList, android.graphics.PorterDuff$Mode) would have incorrectly overridden the package-private method in android.graphics.drawable.Drawable
07-04 08:49:23.118 10043-10043/com.nhiepphong.NameCard I/Choreographer: Skipped 33 frames!  The application may be doing too much work on its main thread.
07-04 08:49:23.358 10043-10043/com.nhiepphong.NameCard I/Timeline: Timeline: Activity_idle id: android.os.BinderProxy@854cfc1 time:50872411
Can you help me ?


Difference to websocketd

Hi,
you mentioned, your project is inspired by websocketd. What was the reason you wrote your own solution? What's the difference, except being able to use the pipe operator and the obviously much smaller code base?
Just a thing that caught my eye: you can make GitHub ignore release.sh for it's language statistics ;) it is a go project first, after all. See here

What was the reason you wrote your own solution? What's the difference, except being able to use the pipe operator and the obviously much smaller code base?

A couple of reasons:

websocketd is bi-directionel which means you can pipe to it anything coming from the internet. This is opening the door to all kinds of attacks and is definitely a security hole (See this interesting hackernews thread about this point). Gossed is on the other side uni-directionel, it only pushes data to browsers.

When I first used websocketd, it was written in node js and the installation process was not as easy as grabbing a binray. That's why I decided to use golang for Gossed. But now websocketd has been re-written in golang too.

Does this make sense?

Just a thing that caught my eye: you can make GitHub ignore release.sh for it's language statistics ;) it is a go project first, after all. See here

Thanks for the hint!

Closing this as I believe I answered your questions.

Just a thing that caught my eye: you can make GitHub ignore release.sh for it's language statistics ;) it is a go project first, after all. See here

Done in 21df8e350e033f93d15e6bbe8192bd2ea637be4c. Thank you for the hint!


correctly populate index columns with values from string arrays

I had to branch es/upstream from d08c124a90 and apply the upstream patch on the branch named v2.4.2_1.0_cherry because master also used the v2.4.2_cherry branch which already contained a patch (c89eb16216 change the multicast deprecation message) which was not back ported.

@seut can you take a look please


API inconsistency (placeholderImage vs placeHolderImage)

It's pretty confusing that the same library uses different ways of writing the same word. The most correct way is placeholderImage as "place holder" is considered an alternative form, and is less commonly used.
Usage 1:
    public func af_setImage(
        withURL url: URL,
        placeholderImage: UIImage? = nil,
        filter: ImageFilter? = nil,
        progress: ImageDownloader.ProgressHandler? = nil,
        progressQueue: DispatchQueue = DispatchQueue.main,
        imageTransition: ImageTransition = .noTransition,
        runImageTransitionIfCached: Bool = false,
        completion: ((DataResponse<UIImage>) -> Void)? = nil)
    {

Usage 2:
    public func af_setImage(
        for state: UIControlState,
        url: URL,
        placeHolderImage: UIImage? = nil,
        progress: ImageDownloader.ProgressHandler? = nil,
        progressQueue: DispatchQueue = DispatchQueue.main,
        completion: ((DataResponse<UIImage>) -> Void)? = nil)
    {

Hi @blixt, thanks for bringing this to our attention. I've just pushed up 194870a6 which refactors the two incorrect spellings in UIButton with placeholder.
Thanks again! 🍻


[master] Upgrade to latest dependencies

Cron. -knative-prow-robot
/cc knative-sandbox/source-wg-leads
/assign knative-sandbox/source-wg-leads
Produced via:
./hack/update-deps.sh --upgrade --release v0.21
./hack/update-codegen.sh

Details:
bumping knative.dev/eventing a4a9f48...152e608:
  > 152e608 upgrade to latest dependencies (# 4841)
  > 8171448 Adding Logline for when a cloudevent has been successfully sent from APIServerSource to the sink (# 4723)
  > fd2688d Use SHOULD for TriggerSpec to keep compatibility (# 4838)
  > 1fa597e [# 4796] Bump golang lint timeout to 10m (# 4830)
bumping knative.dev/hack 8d623a0...8368e1f:
  > 8368e1f guard against set -o unset (# 49)
  > 2b4f6fc disable go's proxy and sumdb only for knative deps (# 47)
bumping knative.dev/pkg ca02ef7...8878069:
  > 8878069 upgrade to latest dependencies (# 2010)
  > c493a9e Update common github actions (# 2009)
  > 6045ed4 Allow setting DisableCompression in NewAutoTransport (# 2007)

/lgtm

/lgtm


Fix for #22951

Closes #22951

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
~[ ] Update CHANGES.md with noteworthy changes.~
~[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.~

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @lukecwik

fyi, most than likely it requires spotless, used github.dev for it

irrelevant test failure with "Java Tests / Java Wordcount Direct Runner (windows-latest) (pull_request)"

Run Java PreCommit

Run Java PreCommit

Run Java PreCommit

Run Java PreCommit

Run Java PreCommit

Note to self: the same happens with https://github.com/a0x8o/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/io/WriteFiles.java

@lukecwik Can I use the same PipelineOptions there as well? Does it use the same network layer?

@lukecwik Can I use the same PipelineOptions there (in WriteFiles) as well? Does it use the same network layer?

Sort of, the issue is that the person might be writing to a different file system that isn't GCS. If you had a way to check the filesystem then you could apply the GCS limit. On the other hand it might make sense to use it anyways.

It would be great if we could update GroupIntoBatches to honor the byte size limit for batches with more than one element and output batches of exactly one element if that one is too big.
This could be done by changing the logic within GroupIntoBatches to measure the size first and only add it to the batch if adding it would make it go over. Some pseudo code:
byteSize = measure(obj)
if (byteSize >= byteSizeLimit) {
  output obj as single element batch
  continue
}
if (byteSize + previousNumBytes > byteSizeLimit) {
  output all buffered elements as batch
} else {
  add obj to batch
}

We could update the javadoc contract to be stricter as well with this change.

@lukecwik Can I use the same PipelineOptions there (in WriteFiles) as well? Does it use the same network layer?

Sort of, the issue is that the person might be writing to a different file system that isn't GCS. If you had a way to check the filesystem then you could apply the GCS limit. On the other hand it might make sense to use it anyways.

The class wasn't even available as a dependency - for a good reason -, so I just hardcoded 64MB there.

Run Java_GCP_IO_Direct PreCommit

I'm not sure why org.apache.beam.sdk.transforms.GroupIntoBatchesTest.testInGlobalWindowBatchSizeByteSizeFn fails. It seems to pass locally.

 If the Dataflow tests there pass I intend to merge it and close this one.

https://github.com/apache/beam/pull/24463 containing this plus a fix was merged.