137

Needs to wait for http://review.motechproject.org/#/c/5398/ to be merged.
The changes tracking feature works only if the setter method is invoked on the instance that is attached to the PM. It may be the case only for updates. The object must be first retrieved from the data service and then modified via setters - all within a transaction.
Because of this limitation, changes tracking for updates made via MDS UI doesn't work at the moment.

Fixes #377
Fixes #137

ok to test

lgtm.  Waiting for build to complete.

@kamknitt It looks like this commit is breaking some of the unit tests.  So those will need to be fixed before we can merge it.

@larubbio I've fixed the unit tests. They should be ok now.


DOC: add Examples for the docstring scipy.interpolate.interpn.

Reference issue
#7168
What does this implement/fix?
add Examples for the docstring scipy.interpolate.interpn.

@AtsushiSakai Please link related issue to this PR in order to auto-close it.

@EverLookNeverSee Is it OK to link #7168? After merging this PR, the issue should not be closed I think, because this PR fix a just a part of it.

@AtsushiSakai my bad, I hadn't see a part of.

@EverLookNeverSee No problem : ).

@ilayn Could you help me to review this PR if you have time?

Thanks, merged.


[WiP] Switch to Network Beta

This shows the difference between the main branch (Network Alpha for NC)
and the sciencemesh branch (Network Beta for NC)

@michielbdejong is it good to merge?


Compile the library - Error

Hi, I downloaded recently Visual Studio. I followed the readMe  for windows only. I executed the cmake command, and I obtain this error :
`
CMake Warning:
No source or binary directory provided.  Both will be assumed to be the
same as the current working directory, but note that this warning will
become a fatal error in future CMake releases.
-- Selecting Windows SDK version 10.0.17763.0 to target Windows 10.0.19043.
-- The C compiler identification is MSVC 19.16.27045.0
-- The CXX compiler identification is MSVC 19.16.27045.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Community/VC/Tools/MSVC/14.16.27023/bin/Hostx86/x86/cl.exe - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Community/VC/Tools/MSVC/14.16.27023/bin/Hostx86/x86/cl.exe - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Looking for unistd.h
-- Looking for unistd.h - not found
-- Looking for crc32c_value in crc32c
-- Looking for crc32c_value in crc32c - not found
-- Looking for snappy_compress in snappy
-- Looking for snappy_compress in snappy - not found
-- Looking for malloc in tcmalloc
-- Looking for malloc in tcmalloc - not found
-- Looking for fdatasync
-- Looking for fdatasync - not found
-- Looking for F_FULLFSYNC
-- Looking for F_FULLFSYNC - not found
-- Looking for O_CLOEXEC
-- Looking for O_CLOEXEC - not found
-- Performing Test HAVE_CLANG_THREAD_SAFETY
-- Performing Test HAVE_CLANG_THREAD_SAFETY - Failed
-- Performing Test LEVELDB_HAVE_NO_MISSING_FIELD_INITIALIZERS
-- Performing Test LEVELDB_HAVE_NO_MISSING_FIELD_INITIALIZERS - Failed
-- Performing Test HAVE_CXX17_HAS_INCLUDE
-- Performing Test HAVE_CXX17_HAS_INCLUDE - Success
-- Looking for pthread.h
-- Looking for pthread.h - not found
-- Found Threads: TRUE
CMake Error at CMakeLists.txt:299 (add_subdirectory):
add_subdirectory given source "third_party/googletest" which is not an
existing directory.
CMake Error at CMakeLists.txt:407 (add_subdirectory):
add_subdirectory given source "third_party/benchmark" which is not an
existing directory.
-- Looking for sqlite3_open in sqlite3
-- Looking for sqlite3_open in sqlite3 - not found
-- Performing Test HAVE_KYOTOCABINET
-- Performing Test HAVE_KYOTOCABINET - Failed
-- Configuring incomplete, errors occurred!
See also "C:/Users/Pierre/Desktop/leveldb-main/CMakeFiles/CMakeOutput.log".
See also "C:/Users/Pierre/Desktop/leveldb-main/CMakeFiles/CMakeError.log".
`
Screen :

Helpful :

Cmake version 3.22.1, CMake suite maintained and supported by Kitware (kitware.com/cmake).
Visual Studio 15 (2017, v15.9)

I let you here to your disposition my CMakeOutput.log/CMakeError.log on pastbin for readable reasons.

https://pastebin.com/3EvTAFc7 (CMakeOutput.log)
https://pastebin.com/Ys1ma6jd (CMakeError.log)

I hope you'll be able to help me for that.
Cordially.

Hi, issue is closed.
I found the bug.

@PalinaSh try:
git submodule init
git submodule update


feat: add a11y linting

Changes
Just a for fun project.
Testing

Docs

Closing since this was just an experiment and we don't plan on shipping this at this time. Maybe I'll come back to it one day.


Update docs CI configuration

Learn Build status updates of commit 563a4e4:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: CannotMergeCommit] Cannot merge commit 563a4e4e409c926cdc10a075efd43af1f6fd9725 in branch update_service_readme of repository https://github.com/Azure/azure-docs-sdk-java into branch main (commit f2428bd7fba8e49eac102eb8b470fe56635273dc). Please follow this documentation: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ to use git.exe to resolve you content conflicts locally and then push to remote.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Practical information for using the library

Publishing information for library visitors and members to make the most of their research time in the library, including:

Membership information

Library services and facilities

Link to subfeature: https://wellcomecollection.productboard.com/feature-board/planning/features/4862646


[auto-sync] 2021-03-23 10:09 UTC

This PR is created via a script automation and CI.
It use the owner account to execute it, please ignore it.

Trumped by later PR


[Error] Awwesome container throws error - shows only standard nginx welcome page

Error Message:
transforming...

src/lib/fetch-github.ts (1:9) "GithubQueryResult" is not exported by "src/lib/types/types.ts", imported by "src/lib/fetch-github.ts".

src/lib/fetch-github.ts (1:28) "GithubRepo" is not exported by "src/lib/types/types.ts", imported by "src/lib/fetch-github.ts".

✓ 99 modules transformed.

rendering chunks...

creating entries function

node:internal/event_target:1054

  process.nextTick(() => { throw err; });

                           ^

TypeError [Error]: fetch failed

    at fetch (/usr/src/app/node_modules/undici/index.js:109:13)

    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

    at async combineSources (file:///usr/src/app/.svelte-kit/output/server/entries/pages/_...category_/_page.server.ts.js:188:22)

    at async getAllCategories (file:///usr/src/app/.svelte-kit/output/server/entries/pages/_...category_/_page.server.ts.js:205:20)

    at async entries (file:///usr/src/app/.svelte-kit/output/server/entries/pages/_...category_/_page.server.ts.js:258:27)

    at async analyse (file:///usr/src/app/node_modules/@sveltejs/kit/src/core/postbuild/analyse.js:148:17)

    at async MessagePort.<anonymous> (file:///usr/src/app/node_modules/@sveltejs/kit/src/utils/fork.js:22:16)

Emitted 'error' event on Worker instance at:

    at [kOnErrorMessage] (node:internal/worker:326:10)

    at [kOnMessage] (node:internal/worker:337:37)

    at MessagePort.<anonymous> (node:internal/worker:232:57)

    at [nodejs.internal.kHybridDispatch] (node:internal/event_target:778:20)

.env: TOKEN_GITHUB={{ token from github.com }}
docker-compose.yml
version: '3'
services:
  ofelia:
    image: mcuadros/ofelia:latest
    container_name: awwesome_ofelia
    depends_on:
      - source
    command: daemon --docker
    volumes:
      - /var/run/docker.sock:/var/run/docker.sock:ro
    labels:
      ofelia.job-run.awwesome.schedule: "@daily"
      ofelia.job-run.awwesome.container: "awwesome"

  source:
    image: mkitzmann/awwesome
    container_name: awwesome
    env_file:
      - .env
    working_dir: /usr/src/app
    command: sh -c "npm run build && rm -r html/* && cp -r dist/* html && exit"
    volumes:
      - shared_volume:/usr/src/app/html

  web:
    image: nginx
    container_name: awwesome_nginx
    ports:
      - 7880:80
    volumes:
      - shared_volume:/usr/share/nginx/html:ro

volumes:
  shared_volume:

portainer shows github token as a environment variable:

Tried to set up the containers with minor differences in docker.-compose file. For example in bdridge mode. didn't change anything

Not sure what the issue is here. It should work like this.
Did you use a  fine-grained personal access token? If you have used a classic personal access token it might not work.

yes

but it shows "never used" :( something in between is breaking the connection i guess

Thank @whenthelight !
I will look into creating a multi-arch image.

I built a multi-archi image supporting amd64 and arm64:
https://hub.docker.com/layers/mkitzmann/awwesome/0.7/images/sha256-c1b870e4db902f6ce41996a786368069dc0864e077584350b69c29f3ff4b6ddb?context=repo


Current release / git version is broken on Radxa Rock 4B Plus V1.73

Hello, I've been attempting to install tow-boot onto my Radxa Rock 4b Plus. (This is the same board as "Rock Pi 4B+", Radxa has changed their naming scheme and re-named this board.) I have attempted both the shared storage strategy on eMMC and SPI installation (flashed via flashrom, using a DIP SPI flash chip attached to GPIO) and have got a similar result both times, using both the current release version and a version built myself from git. This boot log is from the git version I built on eMMC storage, though the same error occurs regardless of what storage it is installed to, and whether I am using the release version or a self-built version:
jrg@tremere ~/os-img/radxa-RockPi4-2023.07-007$ picocom /dev/ttyUSB0 -b 115200

[...]

Tow-Boot TPL 2023.07
lpddr4_set_rate: change freq to 400MHz 0, 1
Channel 0: LPDDR4, 400MHz
BW=32 Col=10 Bk=8 CS0 Row=15 CS=1 Die BW=16 Size=1024MB
Channel 1: LPDDR4, 400MHz
BW=32 Col=10 Bk=8 CS0 Row=15 CS=1 Die BW=16 Size=1024MB
256B stride
lpddr4_set_rate: change freq to 800MHz 1, 0
Trying to boot from BOOTROM
Returning to boot ROM...

Tow-Boot SPL 2023.07
jedec_spi_nor flash@0: unrecognized JEDEC id bytes: ff, ff, ff
jedec_spi_nor flash@0: unrecognized JEDEC id bytes: ff, ff, ff
Trying to boot from MMC1
## Checking hash(es) for config config-1 ... OK
## Checking hash(es) for Image atf-1 ... sha256+ OK
## Checking hash(es) for Image u-boot ... sha256+ OK
## Checking hash(es) for Image fdt-1 ... sha256+ OK
## Checking hash(es) for Image atf-2 ... sha256+ OK
## Checking hash(es) for Image atf-3 ... sha256+ OK
## Checking hash(es) for Image atf-4 ... sha256+ OK
spl_load_fit_image: Skip load 'atf-5': image size is 0!
NOTICE:  BL31: v2.10.0	(release):
NOTICE:  BL31: Built : 00:00:00, Jan  1 1980
Device tree error at node '__symbols__'
Some drivers failed to bind
initcall sequence<PHONE_NUMBER>2a3c38 failed at call<PHONE_NUMBER>221728 (err=-11)
### ERROR ### Please RESET the board ###

At this point, the board hangs and never responds to input from any source at any point.
(The addresses given by 'initcall sequence' vary by storage device but are consistent across boots)
To narrow down the issue, I downloaded the release version of Tow-Boot where support for this board was added, which is 2021.10-004. This version of Tow-Boot was able to boot my board. These are Radxa Rock 4B+ v1.73 boards. They have soldered EMMC and do not have SPI flash populated.
I will continue to bisect this in the future and figure out exactly where this issue occurs, as I have a number of these boards, and I'm using this project as a springboard to learn more about boot firmware.

Just to provide an informational update: I have since built 'mainline u-boot' 24.10 using Nixpkgs' version (nix-build '<nixpkgs>' -A pkgsCross.aarch64-multiplatform.ubootRockPi4 provides you with a result symlink with idbloader.img and u-boot.itb, I followed u-boot's directions from here, installed to eMMC) and this issue does not occur. So, AFAICT, this is either an issue with u-boot on this board that occurred in 23.07 and was fixed sometime between then and the 24.10 release, or an issue with Tow-Boot's patches that presents itself on this particular board.
I will try to build unpatched u-boot 23.07 using the Tow-Boot tooling once I've figured it out (I'm not great at actually comprehending Nix as a build tool) as I've seen that this is an implemented feature. I'm interested in seeing this through, I've just got other things going on and this is what I'm doing for fun :)


Fix and re-enable fuchsia_extractor tests

Updating the C++ protobuf dependency broke the fuchsia extractor tests due to linker errors. These errors appear to be because protobuf restructured how their targets were laid out and however Rust is linking these targets is entirely too picky about multiple identical definitions.
I've disabled the targets:
//kythe/rust/fuchsia_extractor:fuchsia_extractor_lib_test       FAILED TO BUILD
//kythe/rust/fuchsia_extractor:fuchsia_extractor_test           FAILED TO BUILD

to unblock this.

Closing because the fuchsia extractor is no longer present


Get notified in the glanceAPI controller

This patch is a follow up of PR#181.
If the Glance top level CR changes (e.g. an extraMount is updated), we should watch it and `trigger the reconcile loop (which means we should be notified as long as this event occur).

@fmount Shall we close this one since we merged #191 ?

@fmount Shall we close this one since we merged #191 ?

Sure, thanks. Looks like #191 is the approach we're going to use in the other operators as well.


libwinpthread-1.dll is missing from your computer error message.

I get the message, libwinpthread-1.dll is missing from your computer when I press start in DNScrypt Proxy Client. I checked and this is downloaded. Please help! Thanks!

I guess that one has been fixed since.


Make events test more robust for apply_events calls.

We now make tests that call EventsRegisterTest.do_test()
explicitly specify whether calls to apply_events() would
change the state of initially fetched data.  Generally
these tests exist to test that logic (as well as verifying
schemas of events), so if they stop testing that logic, it
is usually a broken test.
Some tests are exempted from the check here, because I think
they don't really change state--such as updating messages or
notifications.  You can set state_change_expected to False
for those tests.
For all the tests that deal with flipping boolean flags, I
set their value to False before calling do_test twice now.
For the authentication backends, I mock the settings so that
more backends are "supported" and therefore part of the event
and the fetched state.
Finally, for the bot tests, I make sure to use a bot the user
can access.

Automated message from Dropbox CLA bot
@showell, it looks like you've already signed the Dropbox CLA. Thanks!

This looks great, modulo a few missing mypy updates.  I fixed those and will merge.


Feature request: reversible routes

This is something I ran into recently. I created a route by dropping markers on my way to a destination, hoping to be able to follow it back the other way. This would be a really useful feature!
Voice vista does already have the ability to reverse routes, but it works by either creating a new route with the order of markers reversed, or you can make what they call a circular route which appends the markers in reverse to the end of the original route.
I think it would be better if there was an option to follow any route in either direction, so in addition to start route, there would be "Start Route in reverse".

Discussed amongst various team members in the consortium yesterday and agreed to make this as a High Priority item. From a UX point of view, the goal will be to keep the interaction as simple as possible so that an existing route can be reversed either from the current list of routes, or, of a route is selected, the option to reverse it is added to the list of actions so that it will appear below the 'Share' feature.
Also, create a new name for the reversed route which can then be edited. By default, use the following format "Reverse of [current route name]"

This issue was brought up to me today by Prof. Turner, I will look into it and see what I can do.


Added support for state_timeout for openstack

bosh doesn't like it when openstack takes >5 minutes.
This allows a provider.state_timeout override in settings.yml
to propagate through and fine-tune the timeout.

:shipit:


Do we need two versions of the html documentation?

While trying to fix the two (#131 and 0ff25602410bdb3c564faaea3e83fb1a6ed6d212) errors in the manual of the last release I began to understand the actions that are or can be called from this repository.

call-deploy-ss3-docs.yml
call-ss3-manual-html-release.yml
call-ss3-manual-html.yml
call-ss3-manual-pdf-release.yml
call-ss3-manual-pdf.yml

The current steps for a release are to

push changes to the repository
tag the repository with the same number as the latest released version of Stock Synthesis
change the version number in the second and fourth GitHub action (the actions with file names that end with ``release'') stage this file
download the latest version of the .html file from a GitHub action and commit it in the docs folder with the _release name
change the version of SS3 and the path the location of the pdf in the index.md file
commit (3)--(5)
upload the .pdf to (2)

Anyway, the process seems very complicated now that we know more about GitHub actions. I propose the following

Remove call-ss3-manual-html-release.yml because I think that we should simplify things to just having the html be whatever is the most recent version of the repository and not worry about having two html versions, see the screen shot below

Make call-ss3-manual.html only deployable on demand so it is not run every single time we push to the repository because call-deploy-ss3-docs is doing that and more.
Incorporate call-ss3-manual-pdf-release.yml into a new action that does everything we need for a release that has a manual go button rather than on any push and thus remove call-ss3-manual-pdf-release because it would be included.
Remove the .html file from docs because we do not need to track the changes in the compiled html

Summary
Are developers fine with me removing the version of the html that matches the static pdf for a release?

All this makes sense to me. In the time since these actions were first set up I think we've learned more about what our needs are and how best to achieve them. I always use the current user manual in HTML because I think it's a better description of the most recent release, including typo fixes etc. as compared to the file that exactly matches the point in time where the release took place.
@k-doering-NOAA, I know you have lots of other responsibilities and are wisely no longer watching this repo, but if you have thoughts on the evolution of the github actions that compile SS3 documentation, please share them.

@kellijohnson-NOAA Thank you for doing a deep dive on the github-actions.  I had a similar thought about only showing the most up-to-date html version and think that is a good idea.  However, the one reason I did not do this is that I was worried about adding documentation to the manual for the current work-in-process executable (not yet released) and that potentially causing issues.  I suppose one way around that would be to add any documentation changes to a not yet released version in a specific branch rather than the main branch.  I am open to ideas here.

From my perspective, it seems fine to modify everything according to the team's needs!

@okenk (Kiva) just noted that the URL she had been using for the manual was not working:  https://nmfs-stock-synthesis.github.io/doc/SS330_User_Manual.html
This URL is working https://nmfs-stock-synthesis.github.io/doc/SS330_User_Manual_release.html and is the one that is linked from https://nmfs-stock-synthesis.github.io/doc/. However, the link text is "Current User Manual (html)" so should probably point to the version URL "release" in the name (which maybe would also require updating the filename created in the workflow).
Also, if we only have one version of the HTML manual online, perhaps we could set the other URL to point to the version that works rather than get a "404 File not found" error.

@iantaylor-NOAA the user manual html links have been fixed, see [here](Nav bar is updated. See here.

The experimental version of the html user manual was removed with #155 so now there is only the release version.

I added that in a branch and had the action deploy that branch to the github site but it still brings me to a 404 page when I try the old link (https://nmfs-stock-synthesis.github.io/doc/SS330_User_Manual.html)

Sorry, I should have clarified that the file need to be renamed from SS330_User_Manual.html.txt to SS330_User_Manual.html. Github won't allow attaching .html or .R files to issues, so I just added ".txt" temporarily to facilitate attaching.

I see, now it works!

Yes, works for me (e.g. this link works and forwards to the one with the manual https://nmfs-stock-synthesis.github.io/doc/SS330_User_Manual.html).
Thanks for making it happen @e-gugliotti-NOAA!


Jupyter notebook editor not showing (the correct version of) Intellisense

Bug: Notebook Editor, Interactive Window, Editor cells

Steps to cause the bug to occur

create a new Jupyter notebook
import pandas in the first cell
run this cell
create a new cell and try to use intellisense on the pandas module

Actual behavior
Intellisense shows only text completions and not all available methods in the pandas module

I have also seen that Intellisense shows all the available methods, but does not show different symbols for methods, modules and classes and no descriptions of the methods. However I was not able to reproduce this bug all the time. Sometimes only text completion shows up with words I already used and sometimes this weird version of Intellisense shows up.
I also tried using Intellisense in the same cell that also imports pandas but it made no difference.
Expected behavior
Intellisense with the method description shows up like in a normal Python file:

This screenshot was created right after the first one, so Intellisense works in a normal Python .py file.

 Thanks for reporting this to us. Currently I'm not reproing this myself, but that might just be a difference in setup. A couple of quick questions to help diagnose this.

In Python settings is Jedi Enabled turned on or off?
Is the bad intellisense only at the start of a session? So if you check back on the cell like a couple of minutes later the intellisense is still messed up?
Could you repro the issue with the bad intellisense and then provide the developer logs for that session? You can get these from the developer console if you go to Help->Toggle Developer Tools in VS Code.

I tried enabling and disabling Jedi. Both does not produce the right outcome.
I just tried it and opened the notebook, let it sit there for about 10 minutes doing nothing and still no Intellisense
I don't know how I got that weird version of Intellisense. I tried many combinations of Jedi enabled/disabled and waiting a few minutes, but I can not repro the issue.

Thanks for getting back to me on that.
We actually did just make a set of intellisense fixes recently here:
https://github.com/microsoft/vscode-python/pull/8940/
If you want to give our development build a try here, you can see if that helps resolve the issue as the fix above is only live in our dev build currently.
https://github.com/microsoft/vscode-python/blob/master/CONTRIBUTING.md#development-build
If that doesn't resolve the issue I think that the next thing that I would need to see would be the output of the developer console logs that I mentioned as #3 in my previous comment. Just get . after a variable when intellisense should pop up and then paste in the logs here.

Installing the preview version of the Python extension worked! Now I'm on 2019.12.54270-dev with VS Code 1.41.0. If I add a . behind a variable, Intellisense shows "Loading..." for a few secounds and then I get the expected result.
Thanks for helping me out!


unable to read metadata

Just trying to use Studio to test out some cartocss designs on some PostGIS layers. I can connect to the db, use a query to show me the available fields, but when i click on the marker icon (I think this would "zoom-to" the extent), I get this error:

I'm also getting this error when using PostGIS. The message in the console is:
Failed to load resource: the server responded with a status of 500 (Internal Server Error)
GET http://localhost:3000/metadata?file=undefined 500 (Internal Server Error)

It looks like it may be related to #393? zoomToLayer is only implemented for local data?
A work-around is to add some sort of base layer data, e.g. a country boundaries shapefile, so you can find your data on the map. Then once you've centered the map and saved it you can remove the base layer.

Tracking at https://github.com/mapbox/mapbox-studio-classic/issues/1487


After upload ico, MESSAGE: Cannot read property 'then' of undefined

Issue Summary
ERROR [2018-06-07 13:32:15] "GET /favicon.ico" 500 3ms
NAME: InternalServerError
MESSAGE: Cannot read property 'then' of undefined
level:normal
InternalServerError: Cannot read property 'then' of undefined
at new GhostError (/var/lib/ghost/versions/1.23.1/core/server/lib/common/errors.js:9:26)
at prepareError (/var/lib/ghost/versions/1.23.1/core/server/web/middleware/error-handler.js:39:19)
at Layer.handle_error (/var/lib/ghost/versions/1.23.1/node_modules/express/lib/router/layer.js:71:5)
at trim_prefix (/var/lib/ghost/versions/1.23.1/node_modules/express/lib/router/index.js:315:13)
at /var/lib/ghost/versions/1.23.1/node_modules/express/lib/router/index.js:284:7
at Function.process_params (/var/lib/ghost/versions/1.23.1/node_modules/express/lib/router/index.js:335:12)
at next (/var/lib/ghost/versions/1.23.1/node_modules/express/lib/router/index.js:275:10)
at Layer.handle_error (/var/lib/ghost/versions/1.23.1/node_modules/express/lib/router/layer.js:67:12)
at trim_prefix (/var/lib/ghost/versions/1.23.1/node_modules/express/lib/router/index.js:315:13)
at /var/lib/ghost/versions/1.23.1/node_modules/express/lib/router/index.js:284:7
at Function.process_params (/var/lib/ghost/versions/1.23.1/node_modules/express/lib/router/index.js:335:12)
at next (/var/lib/ghost/versions/1.23.1/node_modules/express/lib/router/index.js:275:10)
at Layer.handle_error (/var/lib/ghost/versions/1.23.1/node_modules/express/lib/router/layer.js:67:12)
at trim_prefix (/var/lib/ghost/versions/1.23.1/node_modules/express/lib/router/index.js:315:13)
at /var/lib/ghost/versions/1.23.1/node_modules/express/lib/router/index.js:284:7
at Function.process_params (/var/lib/ghost/versions/1.23.1/node_modules/express/lib/router/index.js:335:12)
at next (/var/lib/ghost/versions/1.23.1/node_modules/express/lib/router/index.js:275:10)
at Layer.handle_error (/var/lib/ghost/versions/1.23.1/node_modules/express/lib/router/layer.js:67:12)
at trim_prefix (/var/lib/ghost/versions/1.23.1/node_modules/express/lib/router/index.js:315:13)
at /var/lib/ghost/versions/1.23.1/node_modules/express/lib/router/index.js:284:7
at Function.process_params (/var/lib/ghost/versions/1.23.1/node_modules/express/lib/router/index.js:335:12)
at next (/var/lib/ghost/versions/1.23.1/node_modules/express/lib/router/index.js:275:10)
TypeError: Cannot read property 'then' of undefined
at serveFavicon (/var/lib/ghost/versions/1.23.1/core/server/web/middleware/serve-favicon.js:54:21)
at Layer.handle [as handle_request] (/var/lib/ghost/versions/1.23.1/node_modules/express/lib/router/layer.js:95:5)
at trim_prefix (/var/lib/ghost/versions/1.23.1/node_modules/express/lib/router/index.js:317:13)
at /var/lib/ghost/versions/1.23.1/node_modules/express/lib/router/index.js:284:7
at Function.process_params (/var/lib/ghost/versions/1.23.1/node_modules/express/lib/router/index.js:335:12)
at next (/var/lib/ghost/versions/1.23.1/node_modules/express/lib/router/index.js:275:10)
at urlRedirects (/var/lib/ghost/versions/1.23.1/core/server/web/middleware/url-redirects.js:111:5)
at Layer.handle [as handle_request] (/var/lib/ghost/versions/1.23.1/node_modules/express/lib/router/layer.js:95:5)
at trim_prefix (/var/lib/ghost/versions/1.23.1/node_modules/express/lib/router/index.js:317:13)
at /var/lib/ghost/versions/1.23.1/node_modules/express/lib/router/index.js:284:7
at Function.process_params (/var/lib/ghost/versions/1.23.1/node_modules/express/lib/router/index.js:335:12)
at next (/var/lib/ghost/versions/1.23.1/node_modules/express/lib/router/index.js:275:10)
at /var/lib/ghost/versions/1.23.1/node_modules/express/lib/router/index.js:635:15
at next (/var/lib/ghost/versions/1.23.1/node_modules/express/lib/router/index.js:260:14)
at Function.handle (/var/lib/ghost/versions/1.23.1/node_modules/express/lib/router/index.js:174:3)
at router (/var/lib/ghost/versions/1.23.1/node_modules/express/lib/router/index.js:47:12)
at Layer.handle [as handle_request] (/var/lib/ghost/versions/1.23.1/node_modules/express/lib/router/layer.js:95:5)
at trim_prefix (/var/lib/ghost/versions/1.23.1/node_modules/express/lib/router/index.js:317:13)
at /var/lib/ghost/versions/1.23.1/node_modules/express/lib/router/index.js:284:7
at Function.process_params (/var/lib/ghost/versions/1.23.1/node_modules/express/lib/router/index.js:335:12)
at Immediate.next (/var/lib/ghost/versions/1.23.1/node_modules/express/lib/router/index.js:275:10)
at Immediate. (/var/lib/ghost/versions/1.23.1/node_modules/express/lib/router/index.js:635:15)
To Reproduce
I just upload my ico， and  begain occer this error
Technical details:

Ghost Version: 1.23.1
Node Version: 6
Browser/OS: chrome/windows
Database: mysql

Hi @sqvds  👋
This is for sure caused because you are using a custom storage adapter.
Please use our forum for help. We use GitHub solely for bug-tracking and on-going feature development so we try to keep it noise free.


Add package for MailKit

Fixes #4563
I haven't had a chance to test that this does the right thing, waiting for the generated packages to check.
Also, I'd like to adjust how we're generating these to read the versions and update the manifest magically, but haven't gotten to that yet.

@bdukes I think the only other thing we need to do here is also exclude these files from the created install/upgrade packages correct?

@mitchelsellers they're excluded from the packages in Build/Tasks/packaging.json

Alright, I think this is ready for review. The manifest version and assembly versions are automatically set during packaging. I've done an install and an upgrade from 9.8.1 to 9.9.1 and verified that the MailKitMailProvider works on both sites.
One thing to note is that I did not get a MailKitMailProvider entry added to the web.config upon upgrade, I had to add it manually. I don't think that's related to these changes, but perhaps another issue we need to investigate.

[x] v9.9.1 Clean install: Emails work and mailkit is available but not set a default
[x] v9.9.0 pre-configures for MailKit, stays configured with MailKit and still works
[ ] v9.1.1 upgrade emails keep working but MailKit is not available in the web.config providers. What is the plan for this ? merge this PR and do another one for that ?
Other than that, it looks good to me.

I think #4582 will fix the web.config part of this, waiting for the build to confirm that...


Log: Make using invalid log level a normal error, not a syntax error

Currently using, for example, Log    message    invalid causes a syntax error that cannot be caught by TRY/EXCEPT (#4314). We should change the error to a normal error instead. Should also check how Set Log Level behaves (most likely the same way) and are there other similar error situations where the error should be a normal error, not a syntax error.

#4204 reported a similar issue with Set Test Variable. I considered that a bug and decided to fix it already in RF 5.0.1. Let's do that also with this issue.


Removing ERECO column, and reducing AEFF vs ERECO section

Following issue #63:

Reduced significantly "Effective Area vs reconstructed energy" section
Updated "create_example_file.py" script (also including HDUCLAS hierarchy)
Created example fits with "create_example_file.py"

@TarekHC - Thanks!
Looks good to me. Merging this now.
As mentioned in https://github.com/open-gamma-ray-astro/gamma-astro-data-formats/issues/63#issuecomment-296102281, no open-source tools were supporting the previous ERECO column name yet, so I think it's OK to put this in without discussion.
If you disagree with this change, please comment here.

@cdeil , this was never merged (although you did say to merge it now).
I would merge it myself, but I also added the example bkg_2d and 3d scripts/files. It is not very organized but shall we merge it directly with both additions?

Merging it now.
No, really, this time I mean it!
:-)
Thanks!


Minor grammar fix

"anyone who can access to your git repo"  --> "anyone who has access to your git repo"

@rcabr : Thanks for your contribution! The author(s) have been notified to review your proposed change. @liud

Looks good; thanks @rcabr


Turn on python tests

PR Type

[ ] Breaking change
[ ] Feature
[X] Patch

Brief Description
In this PR I just turned on python test. I changed the directory name tests/python/unit_tests/logging to tests/python/unit_tests/logging_new, otherwise importing errors occur.

Not In Scope

PR Checklist

[ ] Is documented
[ ] Is tested
[ ] Adheres to applicable organization standards

TODOs

[ ] Task 1
[ ] Task 2

In this PR I just turned on python test. I changed the directory name tests/python/unit_tests/logging to tests/python/unit_tests/logging_new, otherwise importing errors occur.

I assume the problem is that there are two logging modules (the actual module and the one which tests the module)? If that's the case I think it's more conventional to name the testing one test_logging rather than logging_new.

Looking at the testing logs, this doesn't look like it's running anything other than the serial C++ unit tests. I'm specifically looking at this log, the "build test release in a container" step, which shows only a single ctest test suite running.

Looking at the testing logs, this doesn't look like it's running anything other than the serial C++ unit tests. I'm specifically looking at this log, the "build test release in a container" step, which shows only a single ctest test suite running.

My first run failed because of missing the setting of NWX_MODULE_DIRECTORY, then I added set NWX_MODULE_DIRECTORY=./NWX_PyModules in the toolchain file, which works on my local machine, but now still no python tests run, strange. Let me check more.

🚀 [bumpr] Bumped! New version:v0.1.12 Changes:v0.1.11...v0.1.12

@ryanmrichard @keceli Something I'm still confused about is that although I have disabled integration testing (only a placeholder for now) in my workflow, it is still running. This was not the case before I turned the python tests on. Any idea?

Looks like it interprets it as a regular expression where * means zero or more of the preceding element. So, you would need "py.*". Or, if you just have py, it would run all tests that start with py.


Remove coupling of HUBViewController and HUBViewModelLoaderImpl

The HUBViewController was passed a concrete implementation of HUBViewModelLoader instead of the protocol which tightly couples it to the implementation.
This allows for a separate view model loader to be implemented (or passed in by the user of the framework).
I didn't want to expose the action performer on the HUBViewModel which is why the view controller checks for conformance to an internal subprotocol to HUBViewModelLoader.

@spotify/objc-dev

Codecov Report

Merging #301 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #301      +/-   ##
==========================================
+ Coverage   93.44%   93.46%   +0.02%
==========================================
  Files          73       73
  Lines        5107     5112       +5
==========================================
+ Hits         4772     4778       +6
+ Misses        335      334       -1

Impacted Files
Coverage Δ

sources/HUBViewController.m
89.87% <100%> (+0.01%)
:white_check_mark:

sources/HUBViewModelLoaderImplementation.m
99.53% <100%> (ø)
:white_check_mark:

sources/HUBUtilities.h
72.91% <0%> (+1.04%)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed94db9...b6fc43d. Read the comment docs.


 (It is replaced by SucceedCommandAction.state_update.)
This PR deletes the attribute and the remaining code that was using it.
Test Plan and Hands on Testing
Just CI.
Review requests
This is basically just a few global find+replace operations. I've gone through the diff to make sure there was no collateral damage, but maybe you want to skim it too to double-check me.
Risk assessment
Low.

Yeah I’ll rebase and merge into edge behind #16620.


Adding a new option 'none' in outputFormat.

So that the user can choose to not use -o in kubectl command
Fixes: 12852

I have already added test cases for the feature. Do you suggest to add test for empty string?

I have already added test cases for the feature. Do you suggest to add test for empty string?

I can see that development is ongoing here. Is there possibility to pass custom output like -o custom-columns=":metadata.name? Now this task forces me to use yaml/json which I don't like. I was trying to bypass it and passed empty string, i.e.:
- task: Kubernetes@1
    displayName: Get deployments
    inputs:
      connectionType: $(connType)
      kubernetesServiceEndpoint: $(serviceEndpoint)
      arguments: deployments --no-headers -o custom-columns=":metadata.name"
      command: get
      checkLatest: true
      outputFormat: ''

It "kind of" worked, but polluted the output with commandOutput and a coma.

@OliwiaStrzelec Working on custom output.


Upgrade VS versions and react to changes

Summary of the changes

Our version of Roslyn is quite old, and it appears that there were some breaking changes. Let's start peeling that onion.

Looks like the new Roslyn version changes the result of Handle_CSharp_ValidBreakpointMoved so that we break at Goo: instead of var x = Goo; @davidwengier you seem to  have edited that area recently, do you have any insight into why that might be?

Looks like the new Roslyn version changes the result of Handle_CSharp_ValidBreakpointMoved so that we break at Goo: instead of var x = Goo; @davidwengier you seem to have edited that area recently, do you have any insight into why that might be?

Sounds bad, but nothing I can think of that would cause it. Might have to pull this branch and run them locally.

Actually.. was the test failure shown in Azdo as a timeout? I'm getting a test failure in https://github.com/dotnet/razor-tooling/pull/7009 so maybe its unrelated to this PR?

So this PR:

Updates to a new Roslyn version
Fixes integration tests
Changes how generated snapshot sync works
Is set to auto-merge

Sound about right? 😛

:up::date:. Needed to take my changes from the ServiceHub fixing branch in order to get this working for VSMain builds.


allow dbmigrations lambda to invoke any alembic command

Feature or Bugfix

Feature

Detail
Currently if things get mixed up (in the db) due to migrations it's very hard to revert the situation (because db isn't exposed to the internet). We have 3 options

Do it manually via SQL Editor
Create an EC2 instance to use as a jump proxy
Create a VPN

With this change we can now run any alembic command directly from the lambda by providing args as event data.
Example usages
Manual downgrade
Let's assume that you are working on a feature and have a new alembic revision locally, let's say rev1.
Also you have already deployed that to your dev AWS account.
The upstream migrations history looks like rev0
The local migations history looks like this rev0->rev1.
A PR gets merged with an alembic migration rev2 and is now changing the head from rev0 to rev2.
Now the upstream migrations history looks like rev0 -> rev2.
In order to merge you must rebase main and as solve this conflict, so the migrations history should look like this rev0->rev2->rev1.
Upon deployment you dev deployment thinks that is already on rev1 and hence pipeline will not run any migrations and will skip the changes in rev2.
With this tool you can pass (before deployment of backend) as dbmigrations event payload the following which will downgrade the DB to rev0.
{
  "command": "downgrade",
  "args": {
    "revision": -1
  }
}

Then when normal upgade runs it will succesfully apply first rev2 and then rev1.
Check history and current revision
It allows you to quickly look at the alembic history  and indicate the current revision of the db by passing the following as event contest...
{
  "command": "history",
  "args": {
    "indicate_current": true
  }
}

Security
Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

Does this PR introduce or modify any input fields or queries - this includes
fetching data from storage outside the application (e.g. a database, an S3 bucket)?

Is the input sanitized?
What precautions are you taking before deserializing the data you consume?
Is injection prevented by parametrizing queries?
Have you ensured no eval or similar functions are used?

Does this PR introduce any functionality or component that requires authorization?

How have you ensured it respects the existing AuthN/AuthZ mechanisms?
Are you logging failed auth attempts?

Are you using or adding any cryptographic features?

Do you use a standard proven implementations?
Are the used keys controlled by the customer? Where are they stored?

Are you introducing any new policies/roles/users?

Have you used the least-privilege principle? How?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Minor comment: @petrkalos could you please add this description to our 'dev hacks' and readme for migrations?


Fix order by when aligned by device

Description
In version 0.13, when aligned by device, the records are sorted within device so the order is wrong.

It is fixed by update the implementation of AlignByDeviceDataSet.java

This PR has:

[x] been self-reviewed.

[x] concurrent read
[x] concurrent write
[x] concurrent read and write

[ ] added documentation for new or modified features or behaviors.
[ ] added Javadocs for most classes and all non-trivial methods.
[ ] added or updated version, license, or notice information
[ ] added comments explaining the "why" and the intent of the code wherever would not be obvious
for an unfamiliar reader.
[ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold
for code coverage.
[ ] added integration tests.
[ ] been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

AlignByDeviceDataSet.java
RawDataQueryPlan.java
ServerTimeGenerator.java

Hi, in align by device query, we see each device as one relational table with (device + timestamp) as the primary key. When querying multiple devices, the result is sorted by device order first, and then by timestamp order. Therefore, it's not a wrong order, but the current standard we defined.
However, this definition does not satisfy some users' cases indeed. But if modified simply as you did, maybe other users still want the result order before. So we will redefine the semantics in the next version and support these two order at the same time.

Hi, in align by device query, we see each device as one relational table with (device + timestamp) as the primary key. When querying multiple devices, the result is sorted by device order first, and then by timestamp order. Therefore, it's not a wrong order, but the current standard we defined.
However, this standard does not satisfy some users' cases indeed. But if modified simply as you did, maybe other users still want the result order before. So we have been tried to redefine the semantics in the next version and support these two order at the same time.
Thank you for the contribution anyway :D

Is there any document or web page that describes the new semantics? We want to use this feature in our system. If the semantics have been redefined, we can adopt to it first in our inner version to minimize the effort to upgrade later.

Hi, in align by device query, we see each device as one relational table with (device + timestamp) as the primary key. When querying multiple devices, the result is sorted by device order first, and then by timestamp order. Therefore, it's not a wrong order, but the current standard we defined.
However, this standard does not satisfy some users' cases indeed. But if modified simply as you did, maybe other users still want the result order before. So we have been tried to redefine the semantics in the next version and support these two order at the same time.
Thank you for the contribution anyway :D

Is there any document or web page that describes the new semantics? We want to use this feature in our system. If the semantics have been redefined, we can adopt to it first in our inner version to minimize the effort to upgrade later.

It seems that docs doesn't explain this semantics, we will add it soon.


Corrected the MicroSD capacity

Changed the MicroSD capacity to match the capacity available in the official product specification by Nokia (available on the product web page: https://www.nokia.com/en_int/phones/nokia-5-2017#details ).

Already fixed by @alexAOSP


Read host, user, database and password from config file if not on command line

Maybe a shared config file in /etc and/or a personal config file in a dotfile in $HOME.

I can create a ticket and do this. This seems straight forward.
Here is one way to implement it.
Start with a file ~/.postgresrc
dbname:name_of_database
user:username
password:your_password
host:your_host

Then write a simple read_config function:
def read_config(path):
    config = {}
    with open(path) as f:
        for l in f.readlines():
            if ":" in l:
                k, v = l.strip().split(":", 1)
                if k in ("dbname", "user", "password", "host"):
                    config[k] = v.strip()
    return config

Get the variables from the file
dotrc = os.environ.get("POSTGRES_RC", default=os.path.expanduser("~/.postgresrc"))

if os.path.exists(dotrc):
    config = read_config(dotrc)
    dbname = config.get("dbname")
    user = config.get("user")
    password = config.get("password")
    host = confit.get("host")

Now you can use the variable names dbname user password and host in the main function


hipErrorSharedObjectInitFailed during tuning in Pytorch

hipErrorSharedObjectInitFailed during tuning in Pytorch
Reported by http://ontrack-internal.amd.com/browse/SWDEV-240233
Similar failure (hipErrorSharedObjectSymbolNotFound) found with resnext101
Based on current logs, failure happens with tuning Asm kernels (both DirectConv and Winograd Asm kernels) on gfx908 in Pytorch. Cannot reproduce the failure with tuning individual config with MIOpenDriver

Similar error happens in our CI from time to time. Not reproducible too.


Android build fails after adding nativescript-geolocation plugin

Hi,
After adding nativescript-geolocation plugin to my project the build is failing for Android.
The issue happens in platforms\android\build.gradle at this line :
"def oldProductFlavorsText = content.substring(indexStart, indexEnd + 1);"
The error is String index out of range -1.
What am I doing wrong?
Thanks,
Ionut

Hi @johny8228,
Would you fill the new issues form as all information asked there would help us investigate further?
Additionally, I wonder whether you can reproduce the issue using plugin's demo apps or we have to use one provided by you.

Hello, i faced same issue. i opened node_modules->nativescript-geolocation->platforms->android->include.gradle. Then i changed include.gradle like this;
allprojects {
repositories {
jcenter()
maven {
url "https://maven.google.com"
}
}
}
android {
productFlavors {
"nativescript-geolocation" {
dimension "nativescript-geolocation"
}
}
}
dependencies {
def googlePlayServicesVersion = project.hasProperty('googlePlayServicesVersion') ? project.googlePlayServicesVersion : "11.4.0"
compile "com.google.android.gms:play-services-location:$googlePlayServicesVersion"
}
In original there is no productFlavors in android { }  and it goes to error. i hope it will help.

Hi, this is still an issue. If you install nativescript-geolocation v4.3.0 via npm it's include.gradle looks like this:
allprojects {
    repositories {
        jcenter()
        maven {
            url "https://maven.google.com"
        }
    }
}

android {

}

dependencies {
    def googlePlayServicesVersion = project.hasProperty('googlePlayServicesVersion') ? project.googlePlayServicesVersion : "11.4.0"
    compile "com.google.android.gms:play-services-location:$googlePlayServicesVersion"
}

And therefore the error occurs that @johny8228 mentions.
When I downgrade to 4.2.4 it works fine because productFlavors is declared:
...
android {
    productFlavors {
        "nativescript-geolocation" {
	    dimension "nativescript-geolocation"
	}
    }
}
...

My guess is that your .npmignore file has an error. It contains:
...
/platforms/android/**/*
!platforms/android/include.gradle
...

It looks like the guy who wrote this wanted to not ignore include.gradle but the /**/* didn't match that gradle file so the ! maybe resulted in the include.gradle file being ignored.


Complete science package documentation

How new collaborators can create or contribute to science package

https://github.com/terraref/documentation/blob/master/developing-science-packages.md


Misc tool fixes

Clean up DEVELOPER docs for linters
Move Dockefile tools to its own dir

Signed-off-by: Arko Dasgupta<EMAIL_ADDRESS>

/lgtm

@arkodg feel free to merge if no other maintainers /approve today.


Fix arm build.

I don't know what this list means, and probably it should be removed.
Ref #14

The list is the set of architectures for which this file is built, and it definitely shouldn't be removed—the file only works for certain architectures.
Are you sure that it works for arm? Did you run the tests? The file from which it was branched had to add particular support for arm.

Sorry, you're right, it doesn't work, go test hangs. With those 3 lines it still hangs.


DNS resolution in ITDE not working in docker-db

DNS resolution is not working on Github tests, see
https://github.com/exasol/ai-lab/actions/runs/11230524435/job/31613541033

issue cannot be reproduced in notebook-connector


Can you please write a mode for aviatorscript？

https://github.com/killme2008/aviator/blob/master/README-EN.md

No, sorry. I don't write modes on demand, and we only add new modes to the main distribution in exceptional circumstances. So you'd have to write and distribute this yourself.


Add examples for ranges

# ranges
for item in [0...10] # exclusive
	item * 2

for item in [0..10] # inclusive (0 - 10)
	item * 2

Reference: https://scrimba.com/p/pJkZsB/cNRrLUL

i will pick up this.

@Sakshisrivastava413 cool, you can add this to the guide/2-Language/loops.md file with an appropriate title. Take a look at the other examples and let me if you have any issues.
Thanks.


Update package.json engines.node key to "14.x"

btw why can't we merge this (for both dvc.org & cml.dev)?


8 tidy up

Remove redundent folder
Update readme
Add Westport catchments
Set the main catchments to be the big ones
Add Jinja for looping over westport and waikanae

Note @shionah we may want to make some additional changes so the scheduler loops over the CATCHMENT_IDS too, and also so the output information includes a tag to the catchment ID. Not sure how this will work with the single quotes surrounding the ids (i.w. '029').
Is currently running though for Waikanae so will land this now. We can fix it up further later.


could the "Rancher v2.x logs-collector "  collect these script?

ulimit -a
ulimit -Hn
cat /proc/sys/kernel/pid_max
sysctl fs.file-nr
sudo lsof -u root  2>/dev/null | wc -l

sorry， I have found these logs


same configuration in class diagram and hierarchy

At least in my test ontology both diagrams are the same. I guess the configuration file for the class diagram is not including properties.

@mariapoveda now fixed


How to enhance performance?

Hi,
I understand that the performance of html2canvas depends a lot on the size of the DOM tree that you need to parse. In the example below, 883 nodes took 8 seconds to process, while 2660 nodes took 66 seconds.
I was wondering if you had any suggestions on how to improve performances? I am currently using 0.5 beta4.
Thx!

The amount of text you have on the page is probably the biggest performance factor. If you enable letterRendering it will have a significant performance impact as well. The 60 second render does sound a bit too much though for the amount of content you are rendering.

@niklasvh thx for the quick reply. I'll give a try to letterRendering.


add suggestions to composer

Q
A

Bug fix?
no

New feature?
yes

Doc update?
no

BC breaks?
no

Deprecations?
no

Fixed tickets
no

License
MIT

If installed by composer, show required extensions for optional features.

Thanks for the PR. As announced some time ago, Swiftmailer is not maintained anymore.
Symfony Mailer is the next evolution of Swiftmailer.
It provides the same features with support for modern PHP code and support for third-party providers.


feat: use internal load balancer to access configuration page and webhook trigger

Why?
lambda function urls are publicly available to the internet and are restricted in our organization on aws organization level by intention to avoid abuse.
As this construct is meant for usage with github enterprise as well it would be great if we can have an additional option to use an internal loadbalancer to invoke the configuration page and webhook handler.
br,
Flo

hmm 🤔 #231  looks like the same stuff I would like to have ...

Yeah that's the idea with #231. @diegoaguilar would you like to chime in?


[WIP] Eliminate Builtin.UnknownObject as an AST type

New version of #12325 that doesn't attempt to change the runtime and reflection bits. Still needs better comments, more docs, etc.

apple/swift-lldb#2017
@swift-ci Please test

@swift-ci Please test source compatibility

Build failed
Swift Test OS X Platform
Git Sha - 696bb78ca978ecbdd39d21fded37ab5903a4b93a

Build failed
Swift Test Linux Platform
Git Sha - 696bb78ca978ecbdd39d21fded37ab5903a4b93a

apple/swift-lldb#2017
@swift-ci Please test

Build failed
Swift Test Linux Platform
Git Sha - 696bb78ca978ecbdd39d21fded37ab5903a4b93a

That honestly went better than expected, this should be ready now. I hope it doesn't muck up Instruments or anything though.
(Don't worry, watchers, it'll be tested additionally before it ships in an Xcode.)
apple/swift-lldb#2017
@swift-ci Please test

Build failed
Swift Test OS X Platform
Git Sha - 696bb78ca978ecbdd39d21fded37ab5903a4b93a

Credit to @varungandhi-apple for getting me to try this again by running into a problem with Builtin.UnknownObject (even if he's already unblocked himself).

@atrick or @aschwaighofer, can you check that the test changes I called out above are reasonable?

The test case cleanup all looks good.


[Power Toys-File Explorer>Image resizer]: No name is defined for the check boxes which is present on the image resizer dialogue.

Microsoft PowerToys version
v0.79.0
Installation method
PowerToys auto-update
Running as admin
None
Area(s) with issue?
Image Resizer
Steps to reproduce
Test environment:
OS Build: Windows 11 Enterprise insider preview 23H2 (22631.3296)
Power toys version: v0.79.0
Screen reader: Narrator
Repro Steps:

Open the Power Toys app in the desktop.
Now open the file explorer and now open menu of the image.
Now select the resize with image resizer.
Turn on the narrator using Win + Ctrl + Enter.
Now navigate to the check boxes present on the dialogue.
Observe the narrator's announcement.

User Experience:
Clear labels are essential for users who rely on screen readers or have visual impairments to understand the options presented.
Guideline Reference:
https://www.w3.org/WAI/WCAG22/Understanding/name-role-value
Attachments:
https://github.com/microsoft/PowerToys/assets/117908911/d9c6297a-1a80-4820-bad2-9977fe0bd3a0

✔ Expected Behavior
Each checkbox should have a clear and descriptive label indicating its purpose.
❌ Actual Behavior
The checkboxes on the image resizer dialogue are not clearly named or labeled, making it difficult for users to understand their function.
Other Software
No response

Fixed in the latest version! 🙂


Never completes

pub run test_coverage
|

The cursor keeps blinking at this location and there is only ever output if one or more tests fail.
If all tests succeed (checked with pub run test), pub run test_coverage just hangs there forever.
Dart SDK version: 2.11.0-213.1.beta (beta) (Unknown timestamp) on "linux_x64"

Seems not to be related to this package. It's just that the generated Dart file never completes.

What did you do? :D

dart test --coverage (or similar) is a thing now. No need for an additional package anymore.

@zoechi that only generates json files (*.vm.json) and most coverage software uses lcov.info file.
You need other libraries to generate the lcov file and those other libraries also hangs up on my computer idk. This is really frustrating. I also tried looking into this issue but didn't help: --coverage should generate a lcov.info file #1265

any update on this one?


Upgrade to google-client-api 0.28.4

Related #14696
We need to upgrade it because it fails with ruby 2.4.x

Don't be shy, ask for all changes needed. I've done it in a rush but that
is not excuse to have it cleaner or improved
El lun., 25 feb. 2019 19:18, Gonzalo Riestra<EMAIL_ADDRESS>escribió:

@gonzaloriestra approved this pull request.
Wow, more changes than I was expecting... Nice work! 💪
We should have more tests (coverage seems to be quite poor here) and code
could be cleaner also (smaller methods, more descriptive variable
names...), but I guess it would be to ask too much for an unexpected task
like this 😅
We'll have to test it very carefully.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/CartoDB/cartodb/pull/14683#pullrequestreview-207553331,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAtPeJOUHWnQm948DR8MTGVKWNWuzC4Xks5vRCjygaJpZM4bFsem
.

I've tested it in the dedicated instance you have created, but I couldn't import any file from 2 different Google accounts, while those files do work in production.
It says: Unknown (99999). Sorry, something went wrong and we're not sure what. Try uploading your file again, or contact us and we'll try to help you quickly.
https://rollbar.com/carto/CartoDB/items/8/

Acceptance:

[x] Drive, Box, Dropbox and ArcGIS connectors (connection, file listing, importing and revoke)
[x] CSV, XLS, SHP and Zip file types with Drive
[x] Listing of Drive account with more than 440 files (limited to that number)
[x] Shared files in Drive
[ ] Synchronizations
[ ] Repeat the tests using ruby 2.2 to check backward compatibility

@gonzaloriestra I didn't answer properly to the test part. We can't have tests because this is a third party library use so we should test the integration but for that, we need to have an oauth app + authentication...and that is going to be open in the repository so...

I've been testing this branch with Ruby 2.2 in a dedicated staging host.
Everything's fine, except we'll need to wait for an hour to see if the synchronization updates correctly.

[x] Drive, Box, Dropbox and ArcGIS connectors (connection, file listing, importing and revoke)
[x] CSV, XLS, SHP and Zip file types with Drive
[x] Listing of Drive account with more than 440 files (limited to that number)
[x] Shared files in Drive
[x] Single and multilayer imports
[ ] Synchronizations

Synchronizations update correctly


'isSubtle' and possibly other boolean cards properties are not handled properly

The 'isSubtle' property on a card TextBlock element, when set to True, is sent as a JSON sting value "True" which is not valid.  It must be a boolean value.

Thanks for raising this @acilate. Will have a look into it.

Where are you on a fix for this?  This is major bug, module not usable.

@edkuse I hope to have a fix in by the end of the week. Thanks for your patience.

I just pushed a change that should resolve this issue. A card like this:
from webexteamssdk.models.cards import AdaptiveCard
from webexteamssdk.models.cards.components import TextBlock
from webexteamssdk.models.cards.options import HorizontalAlignment
from webexteamssdk.models.cards.actions import Submit

t = TextBlock("Test text", isSubtle=True, horizontalAlignment=HorizontalAlignment.CENTER)

body = []
body.append(t)

s = Submit(title="Test", data={"hidden": "data"})
actions = [s]

c = AdaptiveCard(body=body, actions=actions)

print(str(c.to_json(indent=4)))

now prints as this (valid) json
{
    "version": "1.1",
    "type": "AdaptiveCard",
    "body": [
        {
            "type": "TextBlock",
            "text": "Test text",
            "horizontalAlignment": "center",
            "isSubtle": true
        }
    ],
    "actions": [
        {
            "data": {
                "hidden": "data"
            },
            "title": "Test",
            "type": "Action.Submit"
        }
    ],
    "$schema": "http://adaptivecards.io/schemas/adaptive-card.json"
}

You can try the code by installing my development branch (pip3 install git+https://github.com/sQu4rks/webexteamssdk@issue-107) or wait until the PR gets merged and a new release gets pushed.
Let me know if this resolves your issue.


groupBy messes up initial order

Example:
I´m using Google Contacts API. this API return contacts in a relevant order. So my most contacted are on top. Now I group them by the first charachter, so I can split them up and use them in some abc-navigation.
When using groupBy then the sort of the items completely gets destroyed.
My current workaround is to apply all downloaded contacts the initial index, group them, and sort every groups list be the index.

Mind including some example code demonstrating the problem you're encountering? I'm not sure "what a relevant order" means in terms of the Google Contacts API.

Sorry everything fine...
I sorted first by the first letter and then ordering it... :)


Code release

Congratulations on your paper being accepted by CVPR! May I inquire when the code for this article will be fully released?

Thank you for your appreciation on our work. We have completed the code release and will finish the data&weights releases soon.


Open-In-CartoDB formatting fail w/data.gov

please ref s/b 6161984 and 6050199
data.gov dataset is importing improperly with "Open In CartoDB" and downloaded csv. Columns are concatenated upon import:
https://team.cartodb.com/u/stephaniemongon/tables/nndss_table_ii_babesiosis_to_coccidioidomycosis
Looks like a formatting issue we're not in control of, but reporting because user says file imports properly to other platforms. If it's not something we can change on our end & really is due to formatting issue on source end I can close issue, let me know:
http://catalog.data.gov/dataset/nndss-table-ii-babesiosis-to-coccidioidomycosis
Thanks!

There has been no activity on this issue for more several months. We are closing it. If you think this still needs to be addressed please open a new issue.


Fix bug wc loading

There was a bug where when searching multiple times, it was not correctly updating the results (because of some internal lit caching issue).
Making sure it shows the load indicator is enforcing the items to be refreshed.

Yes please


MINOR: Fix TestDowngrade.test_upgrade_and_downgrade

The second validation does not verify the second bounce because the verified producer and the verified consumer are stopped in self.run_validation. This means that the second run_validation just spit out the same information as the first one. It seems to me that we should just run the validation at the end.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Got a successful run here: http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2022-04-11--001.system-test-kafka-branch-builder--1649665531--dajac--minor-fix-test-downgrade--6fd17dd0a/report.html

Successful run: http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2022-04-12--001.system-test-kafka-branch-builder--1649757559--dajac--minor-fix-test-downgrade--dd4df5245/report.html


More maintainer

Hi,
Just in case if you need more maintainer to manage this repository and all incoming pull request, I will be glad to help you ;)
Regards

Yeah, we've been talking about doing an open patch system - something like Rubinius.  For now, we're not but in the future, I'm considering forking and moving the project to my personal repo. @defunkt isn't really active anymore and I don't want to bother him - I'm sure he's busy enough running github!
Closing this one for now, but we should revisit soon.


Parse MOVE statement

Code analysis step is halted, it seems @MarkusAmshove

Can you push a new commit to this? Can't seem to get it running, it must not process it on their side

Adding MOVE (AD=), will push soon :)

Made changes to abstractParser(), please review @MarkusAmshove


Can we get request url or name in the debug logging?

It would be great to get some kind of name or URL in the request debug logging. I am trying to aggregate the metrics for each call we make to SalesForce and its a bit difficult when they are on separate log statements.
https://github.com/jsforce/jsforce/blob/888edd0ff29d9b4926b16ee5bdacb9b99e773fb8/lib/http-api.js#L82-L85
Also thought about just passing the timing information to the emit function and I could log appropriately there. However we are in lambda function and not sure how well waiting for async event would work out. It would probably be fine.
Just a thought. If I get some time I will try to PR.

jsforce v1 does log the request URL:
https://github.com/jsforce/jsforce/blob/888edd0ff29d9b4926b16ee5bdacb9b99e773fb8/lib/http-api.js#L79

I am trying to aggregate the metrics for each call we make to SalesForce and its a bit difficult when they are on separate log statements

not sure how exactly this is done but you could try filtering by logs starting with <request>.
Regarding events, you probably won't be able to listen to these events because methods don't expose the internal HttpApi instance.


Added smooth-scrolling

Added smooth scrolling to extension. Users can change the 'scrollType' in settings.js to either "smooth", "instant", or "auto"

I'm confused because this says that Safari doesn't support ScrollToOptions, but in the Safari Technology Preview Release 13, which came out 2+ years ago, it says that they added support for ScrollToOptions. I would assume that they've since migrated those features over into the main Safari app.

That is confusing, I agree. Now when I test I can't make it scroll smoothly..
Also looking at Apple's docs the scrollBy function doesn't even support options. Did you ever make it work in Safari? 🙂

I used the smoothscroll polyfill with the code like this:
window.scrollBy({ top: window.innerHeight / 2, behavior: 'smooth' });

I also reduced SCROLL_TIME in the polyfill to closer match the native page scroll.
Works okay.

@jacobchrismarsh are you planning on continuing this? I would love to see it be added!

@kcmannem I stopped working on it because Apple's documentation was confusing on whether or not Safari supported smooth scrolling. That being said, @anongit 's comment seems to suggest that it might be possible. I have plenty of time over the holidays, so I'll give it another look over.

I can see code relating to this in WebKit, but code like window.scrollBy({left: 0, top: 300, behavior: 'smooth'}); that smooth scrolls in Firefox and Chrome doesn't work in Safari :(

@jacobchrismarsh hey, curious to know what happened to this PR after all. Thanks!

@abnerf definitely abandoned as far as I'm concerned. @nbelzer implemented smooth scroll in #182, and it works great! It honestly allowed me to switch over from Chrome and Vimium to Safari and Vimari.


[WFLY-9405] Test removes EJB subsystem using the CLI command.

Test removes EJB subsystem using the CLI command.
Upstream JIRA issue: https://issues.jboss.org/browse/WFLY-9405

@bstansberry in theory, you can have POJO WS endpoints, with no EJBs. In practice, this should actually be verified/tested

@bstansberry  We can make it more simple and just remove the MAX_OUTBOUND_MESSAGES option. PR updated.

@dcihak Good thinking. :)

@bstansberry  Thanks for the review, PR updated.


Taken over authorship of xlsx package

@DanBurton fixed

I'll leave it to @juhp to merge since he's curating this week.

cc @smurphy8

Great! If there is anything you need help with let me know!
On Mon, Jul 27, 2015 at 10:17 PM, Jens Petersen<EMAIL_ADDRESS>wrote:

cc @smurphy8 https://github.com/smurphy8
—
Reply to this email directly or view it on GitHub
https://github.com/fpco/stackage/pull/712#issuecomment-125421280.

--
Scott Murphy
Design Engineer
<EMAIL_ADDRESS>

thanks @smurphy8


Add a Not Found page for IOU reports that we cannot load

@Julesssss @mollfpr please review
Details
As pointed out by @mollfpr here we were always showing a loading spinner if we didn't have an IOU report. Instead, we should be showing a report not found page and using the loading property in the IOU to show whether or not the report is loading.
Fixed Issues
$ https://github.com/Expensify/App/issues/14011
Tests

Login with any account A
Send an IOU from account A to another account B
Click the IOU and copy the URL to it
(Via incognito window) From another account C, paste in the URL - make sure you see a page indicating the payment cannot be found

4a. For iOS/Android/Desktop: From account C paste the link into a chat message. Then click on it. Make sure you see a page indicating the payment cannot be found

[x] Verify that no errors appear in the JS console

Offline tests

As account A/B from above, load the chat with the IOU report
Go offline
Click on the IOU report.
Make sure you can see the IOU report in the modal.

QA Steps

Perform the tests and offline tests sections above on all platforms.
[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Updated!

@mollfpr over to you for the checklist review

@Julesssss Are we okay with showing the loading when the fetching happens while the data is already in Onyx?

@Julesssss Are we okay with showing the loading when the fetching happens while the data is already in Onyx?

Yeah, I don't see why not. It should be a very short period and we can improve this later by matching the regular chats:

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

https://user-images.githubusercontent.com/25520267/211817967-497f3b5c-7889-4f46-accc-48fda126633f.mov
@yuwenmemon @Julesssss When I open the IOU detail offline, it keeps showing the loading spinner.

Oh, I didn't see that. When offline I still saw the same UI 😕

@Julesssss Wait, I’m confused 😳 Is this mean your end working fine offline?

Updated!

I think we should only show the back button only on the small screen.

I can't test open the localhost link on native 😕

Any suggestion? @yuwenmemon @Julesssss

I can't test open the localhost link on native 😕

Any suggestion? @yuwenmemon @Julesssss

I manually edited the link to something like staging.new.expensify.com/r/1223456/12345678

Test well on offline two 👍
Here's the checklist

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @Julesssss in version: 1.2.54-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @AndrewGable in version: 1.2.54-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Output original covariance matrix

Original covariance matrix is now included in results structure for easy reference with respect to final adapted version.  Note, the covariance matrix will include the values initialized for all parameters, not just the ones being sampled.

Minor change to adaptation display feature to give the user more flexibility with regard to verbosity.

Pull Request Test Coverage Report for Build 278

3 of 3 (100.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.002%) to 98.006%

Totals

Change from base Build 277:
0.002%

Covered Lines:
2212

Relevant Lines:
2257

💛  - Coveralls


few questions

Hi Marcin,
back again with few questions, as I am really feeling your work has been one of the very best put there for other DevOps to get their EKS work and running in a better manner.
I have three question, I would appreciate if you can give some clarification.
Question 1/
node-drainer.tf what is the file in node_drainer folder that we are zipping?
There are three folders inside node_drainer, each folder has few files in it? Can you kindly give some explanation there?
I want to use terraform to zip the file on the fly instead of having zip file in the repo (for security compliance purposes).
for example I want to zip the node_drainer as below:
data "archive_file" "node-draining_zip" {
type = "zip"
output_path = "${path.module}/node_drainer/???-${sha256(file("${path.module}/node_drainer/???.py"))}.zip"
source_file = "${path.module}/node_drainer/???.py"
}
then call it like this:
source_code_hash = data.archive_file.node-draining_zip.output_base64sha256
Question 2/
There is a security group you are creating but seems like this hasn’t been used anywhere?
https://github.com/marcincuber/eks/blob/master/terraform-aws/cluster.tf#L5
Or am I missing something?
Question 3/
for all configs provided in terraform_k8s inclusing configmap aws-auth and cluster_autoscaler, etc. is there any automated process you are using to configure these templates onto the deployed clusters and node_group?
Thank you very much.

Hi @nashvan,
I am glad my work is helping other people.
Q1. Lambda function/code provides a means to gracefully terminate nodes in EKS cluster when managed as part of an Amazon EC2 Auto Scaling Group.
The code provides an AWS Lambda function that integrates as an Amazon EC2 Auto Scaling Lifecycle Hook. When called, the Lambda function calls the Kubernetes API to cordon and evict all evictable pods from the node being terminated. It will then wait until all pods have been evicted before the Auto Scaling group continues to terminate the EC2 instance. The lambda may be killed by the function timeout before all evictions complete successfully, in which case the lifecycle hook may re-execute the lambda to try again. If the lifecycle heartbeat expires then termination of the EC2 instance will continue regardless of whether or not draining was successful. You may need to increase the function and heartbeat timeouts in template.yaml if you have very long grace periods.
Using this approach can minimise disruption to the services running in your cluster by allowing Kubernetes to reschedule the pod prior to the instance being terminated enters the TERMINATING state. It works by using Amazon EC2 Auto Scaling Lifecycle Hooks to trigger an AWS Lambda function that uses the Kubernetes API to cordon the node and evict the pods.
Q2. Just to be precise, it is a aws_security_group_rule. This one specifically allows EKS to make use of endpoints configured in https://github.com/marcincuber/eks/blob/master/terraform-aws/vpc.tf#L56. VPC endpoints allow for private connectivity with the VPC.
Q3. There are different ways to deploying yaml templates. Personally, I am making use of a tool called Flux (https://github.com/fluxcd/flux). Using flux, you are basically control templates in your git repository and flux will apply them in the cluster.

Hello @marcincuber
thank you very much for the detailed answer, though my first question seems not to have been answered yet, I understand the how this lambda works and why we are using it hear. my question is you have got few .py files inside node_drainer folder. which one is the correct python code been used?

@nashvan apologies. So the files that are zipped are in https://github.com/marcincuber/eks/tree/master/terraform-aws/node_drainer/drainer. I am zipping it into a single zip as it is not going to change anytime soon. So files handler.py and
k8s_utils.py are the crucial ones.

@marcincuber  for somereasons I am not able to use your zip file.
Error installing provider "template": Get https://releases.hashicorp.com/terraform-provider-template/2.1.2/terraform-provider-template_2.1.2_darwin_amd64.zip: net/http: TLS handshake timeout.
Error: unable to verify checksum
that is why I wanted to use
data "archive_file" "node-draining_zip" {
type = "zip"
output_path = "${path.module}/node_drainer/???-${sha256(file("${path.module}/node_drainer/???.py"))}.zip"
source_file = "${path.module}/node_drainer/???.py"
}

to zip the file. that means I only need handler.py and k8s_utils.py?

pip3 install -r ./node_drainer/drainer/requirements.txt --target ./lambda_build
cp ./node_drainer/drainer/__init__.py ./node_drainer/drainer/handler.py ./node_drainer/drainer/k8s_utils.py ./lambda_build
cd lambda_build && zip -r ../node_drainer.zip ./* && cd .. && rm -rf lambda_build

These are commands that I am using locally to build the zip.

Thank you very much @marcincuber, I used terraform data archive to zip the files, I just wanted to know which files are the ones needed to be included to the zip file.
I am curious to know if you have recently run this module
as per your source module:
https://github.com/umotif-public/terraform-aws-eks-node-group/blob/master/main.tf
enabled         = var.enable_managed_workers
https://github.com/marcincuber/eks/blob/master/terraform-aws/manage-node-group.tf#L5
doesnt seems to be accepted, because there is no such param declared in the source module.

@nashvan you are absolutely right. I upgraded the module to support terraform 0.13. This means terraform-aws-eks-node-group no longer needs enabled variable and therefore it was removed.
It should be changed to (enabled is removed and terraform 0.13 required):
module "eks-node-group" {
  source = "umotif-public/eks-node-group/aws"
  version = "~> 3.0.0"
  count = var.enable_managed_workers ? 1 : 0
  ...


Fix occasional timing issues in ASYNC workflow test

Coverage remained the same at 50.65% when pulling a92caf69e68c4b33373acfb3615a841bd3006e1f on maxhq:issue-517 into d4f326a2b1813f98e024b91fa90d11b93ea0c7a6 on openxpki:develop.


Deposit Reward Tokens (depositRewardTokens) area has a problem.

The contract has a problem. I can not deposit my ERC20 token in the contract. It always has a problem.
When I try with just amount area:
ERC20: insufficient allowance (but I have and I took this information in my client-side too)
When I try with Native Token Value area:
missing revert data in call exception; Transaction reverted without a reason string
if I write both of them:
missing revert data in call exception; Transaction reverted without a reason string

Also it is in BNB Testnet chain
(StakeERC721
Contract for staking ERC721 NFTs, for ERC20 tokens as rewards.
thirdweb.eth)

hey @berkeguleryuz
can you share your staking contract address / dashboard-link?

Hi @berkeguleryuz 👋🏽 were you able to resolve your issue?
I'm closing this issue for now, but please feel free to comment an update containing your staking contract address / dashboard-link. Thank!
Also, feel free to tag @thirdweb Support with your issue in the thirdweb discord.


Unit tests fail on PHP 8.1

Module version: 1.0.3
PHP version: 8.1.10
Magento version: 2.4.5-p1
webonyx/graphql-php version: 14.11.8 (via magento/framework, not required by this module)
Full output:
PHPUnit 9.5.27 by Sebastian Bergmann and contributors.

...EEE........                                                    14 / 14 (100%)

Time: 00:00.072, Memory: 10.00 MB

There were 3 errors:

1) Hyva\GraphqlViewModel\Model\GraphqlQueryEditorTest::testSetsGivenArgumentsOnQuery with data set "no prefix" ('', '')
TypeError: GraphQL\Language\Printer::GraphQL\Language\{closure}(): Return value must be of type string, int returned

/var/www/html/src/vendor/webonyx/graphql-php/src/Language/Printer.php:194
/var/www/html/src/vendor/webonyx/graphql-php/src/Language/Visitor.php:277
/var/www/html/src/vendor/webonyx/graphql-php/src/Language/Printer.php:463
/var/www/html/src/vendor/webonyx/graphql-php/src/Language/Printer.php:90
/var/www/html/src/vendor/hyva-themes/magento2-graphql-view-model/src/Model/GraphqlQueryEditor.php:98
/var/www/html/src/vendor/hyva-themes/magento2-graphql-view-model/tests/unit/Model/GraphqlQueryEditorTest.php:119

2) Hyva\GraphqlViewModel\Model\GraphqlQueryEditorTest::testSetsGivenArgumentsOnQuery with data set "only query" ('query ', '')
TypeError: GraphQL\Language\Printer::GraphQL\Language\{closure}(): Return value must be of type string, int returned

/var/www/html/src/vendor/webonyx/graphql-php/src/Language/Printer.php:194
/var/www/html/src/vendor/webonyx/graphql-php/src/Language/Visitor.php:277
/var/www/html/src/vendor/webonyx/graphql-php/src/Language/Printer.php:463
/var/www/html/src/vendor/webonyx/graphql-php/src/Language/Printer.php:90
/var/www/html/src/vendor/hyva-themes/magento2-graphql-view-model/src/Model/GraphqlQueryEditor.php:98
/var/www/html/src/vendor/hyva-themes/magento2-graphql-view-model/tests/unit/Model/GraphqlQueryEditorTest.php:119

3) Hyva\GraphqlViewModel\Model\GraphqlQueryEditorTest::testSetsGivenArgumentsOnQuery with data set "named query" ('query ExampleQuery ', 'query ExampleQuery ')
TypeError: GraphQL\Language\Printer::GraphQL\Language\{closure}(): Return value must be of type string, int returned

/var/www/html/src/vendor/webonyx/graphql-php/src/Language/Printer.php:194
/var/www/html/src/vendor/webonyx/graphql-php/src/Language/Visitor.php:277
/var/www/html/src/vendor/webonyx/graphql-php/src/Language/Printer.php:463
/var/www/html/src/vendor/webonyx/graphql-php/src/Language/Printer.php:90
/var/www/html/src/vendor/hyva-themes/magento2-graphql-view-model/src/Model/GraphqlQueryEditor.php:98
/var/www/html/src/vendor/hyva-themes/magento2-graphql-view-model/tests/unit/Model/GraphqlQueryEditorTest.php:119

ERRORS!
Tests: 14, Assertions: 11, Errors: 3.

It seems to actually be a bug in this version of webonyx/graphql-php: https://github.com/webonyx/graphql-php/blob/v14.11.8/src/Language/Printer.php#L193-L195 (integer nodes are not casted)

I tried to run the tests with the development version of the GraphQL package:
composer require webonyx/graphql-php "dev-master as 14.11.9-dev"

The error is gone, but unfortunately new ones come because a property has changed from array to object:
TypeError: Cannot assign array to property GraphQL\Language\AST\SelectionSetNode::$selections of type GraphQL\Language\AST\NodeList

@Vinai not much we can do about it now it seems, but the query editor won't work with Magento 2.4.5 as soon as integer values are involved (e.g. page size)
An update of the module will be necessary as soon as a new version of the graphql package is released, which fixes the issue. I suggest adding version constraints to composer.json now already to not allow installing the current version with a graphql-php version >= 14.12

@schmengler that's a good idea.I really loath the backward incompatible changes in PHP 8.1, but sadly, that's the world we live in.
Would you be willing to open a PR with the suggested change in the version?

of course: https://github.com/hyva-themes/magento2-graphql-view-model/pull/6

Thank you, @schmengler!
Merged and tagged as release 1.0.4


Add PglogicalSubscription model

This uses ActsAsArModel to wrap the underlying pglogical postgreSQL stored procedures in an ActiveRecord model way.
https://trello.com/c/bRx6yN0C
@Fryguy please review

Putting this here as a reference for discussion around parsing http://www.postgresql.org/docs/9.4/static/libpq-connect.html
Specifically the section "31.1.1. Connection Strings"

The parsing issues should be resolved as of https://github.com/ManageIQ/manageiq/pull/7250

:+1: This is really nice!


Better support for diverse network environments

Gradle needs to work in all sorts of corporate network environments, with a wide variety of proxies, mirrors, authentication schemes. In addition, repository servers can be flaky, misconfigured, or slow.
This Epic covers work to improve support for different networking environments, different server configuration, etc.

Often times users aren't even aware of the misconfiguration, just getting timeouts and thinking that something is wrong with Gradle, e.g. https://github.com/gradle/gradle/issues/7336

We don't use this to track work anymore.