Route push to same named route with different params will not execute beforeRoute guards

NOTE: I cannot create a fiddler right now. I will update the ticket later, when I can, with a fiddler. However, I did link to the source that was the problem. I verified this in my browsers debug tools (chrome).

Vue.js / vue-router versions
2.0.7 / 2.0.2
Steps to reproduce

Define a route that has a beforeEnter guard (See below for my use case)
Call router.push() from that route to the same route but with different parameters (i.e. /requests/1 to /requests/2)

What is Expected?
The route transition is executed AND the beforeEnter guard is executed.
What is actually happening?
Essentially I have a route that is defined as such:
{
    path: '/request/:id',
    name: 'showRequest',
    component: ShowRequest,
    beforeEnter: (to, from, next) => {
        store.dispatch('fetchRequest', to.params.id)
        next()
    }
}

Inside my Vue I have a method that performs the following:
api.clone(this.request, function(response) {
     router.push({ name: 'showRequest', params: { id: response.id } })
})

The API call is returning a cloned object but with a unique ID. I wish to transition to the showRequest route but with the different parameter. What happens is that the route (url in my browser) is set, but the beforeEnter guard is not executed. Therefore, the URL is updated but the fetchRequest Vuex action is never called.
I ended up attaching a debugger to understand what is going on. The first thing I verified was that the isSameRoute was returning false (see isSameRoute). Since the paths are not equal (different ID at the end), this function returns false.
The next thing to happen is that the router is attempting to resolveQueue. This is where things break down. The two parameters passed in, this.current.matched and route.matched are equal. Therefore the activated and deactivated arrays are empty. Therefore the beforeEnter guard I have is never executed.
The problem is the comparison being done between the two routes . Slicing an array at its final index will undoubtedly return an empty array. This is precisely what is happening. Some sort of different comparison or override is needed.

If I remove the resolveQueue call, and instead do:
const deactivated = this.route.matched
const activated = route.matched

My callbacks are executed. Why is resolveQueue necessary?

Alright, I took the time to create a fiddle that models what I am doing. Perhaps I am just doing things wrong, but essentially if you click on 'Bar' you will notice that the console logs here. If you then click on Not-Bar there will be no console log.

@predhme, workaround.
router.beforeEach((to, from, next) => {
    let isDelegated = false;

    for (let matched = (to.matched || []), i = matched.length; i--;) {
        let route = matched[i];

        if (route.beforeEnter) {
            isDelegated = true;
            route.beforeEnter(to, from, next);
        }
    }

    !isDelegated && next();
});

or
let router = new Router({
    routes: [
        path: '/request/:id',
        name: 'showRequest',
        component: ShowRequest,
        meta: {
            beforeEach: (to, from, next) => {
                store.dispatch('fetchRequest', to.params.id);
                next();
            }
        }
    ]
});

router.beforeEach((to, from, next) => {
    let isDelegated = false;

    for (let matched = (to.matched || []), i = matched.length; i--;) {
        let route = matched[i];

        if (route.meta.beforeEach) {
            isDelegated = true;
            route.meta.beforeEach(to, from, next);
        }
    }

    !isDelegated && next();
});

@predhme https://jsfiddle.net/jeamuy4k/3/

I closed my original pull request as it had a few errors. The second merge request is a squashed version of that.

@antdigo I appreciate the workaround. I will give that a shot.

@fnlctrl Hasn't we talked about this already. I couldn't find the issue but basically, the guard is not executed because it's the same route

Yeah.. and I couldn't find the issue too, though I managed to find Evan's reply in https://github.com/vuejs/vue-router/issues/646

It's the same route with different params. You can react to param changes by watching $route.

So basically, @predhme in your case you should not be using before hooks to react to param changes, instead, you can simply add a watcher on $route, as described in http://router.vuejs.org/en/advanced/data-fetching.html
But there is also a proposal/feature request for adding a hook that is triggered on param changes:
https://github.com/vuejs/vue-router/issues/938

@fnlctrl @posva Thanks for the update. For now, I will use the $watch on the route to detect changes in the params.

Closing as this will be addressed when #938 is implemented.

With this "hack" using router.beforeEach when navigate back await router.back() it's completed before await route.meta.beforeEnter(to, from, next)


Invalid incompatible types error when a type reference type referring to a numeric type is used as the contextually-expected type for a multiplicative expression

Description:
$title.
Steps to reproduce:
type Seconds decimal;

decimal _ = 3600 * 24; // OK
Seconds _ = 3600 * 24; // error: incompatible types: expected 'Seconds', found 'int'

Affected Versions:
slbeta6, stage-swan-lake

Fixed with https://github.com/ballerina-platform/ballerina-lang/pull/34616


Add example for configuring proxies on tinkerbell k8s nodes

Description of changes:
Adding an example for configuring HTTP_PROXY, HTTPS_PROXY and NO_PROXY for containerd on baremetal Kubernetes nodes
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm

/lgtm

/approve


Exclude script filter

Another proposed solution for #3. Uses filters in config to exclude scripts from rewrite.

Could you add a script like /node_modules/jquery to testcase?

Could you add a script like /node_modules/jquery to testcase?

Done!


Add docstring comments to functions

PR created: https://github.com/david4096/huggingface-rdf/pull/27

Closing as complete


hyperlinks in HTML 5

I was just fiddling around with EHTML and noticed that yaws refuses put the HTML element 'a' around a block, say a 'div'. As of HTML 5, making a block a hyperlink is perfectly valid. Could you add the 'a' tag to the block level elements?

Can you provide an example of what you're asking for?

Oh boy. I've found the reason for my issue, but it's not related to yaws. Sorry, for the inconvenience. Anyway, thanks for the quick reply!

OK, thanks for following up. Closing this issue.


Use prefix to extend member objects

And add regex matching properties to those with the prefix to avoid needing to search for them each time
Prefix should make it easy to strip them out later for export purposes; recommend using _ but make that easy to change in the code

Strip those off when a member object is edited since they may no longer be accurate


fix: use default catalog toolbar for offset catalog table

Hey, I just made a Pull Request!
mostly to get debounce working the same way with the entity text filter
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

seems this needs a rebase now, sorry i've completely overlooked this one for so long, my bad

seems this needs a rebase now, sorry i've completely overlooked this one for so long, my bad

Rebased and ready to go! I've added a suggestion to the changesets, as without this PR the table uses the native CatalogTable filtering which causes issues when searching groups via spec.profile.displayName.

Nice! I was wondering about this. Should we add it to the non-paginated version in CatalogTable.tsx as well? I can do that in https://github.com/backstage/backstage/pull/27632


peer-peer code review week3 day 4

Great job so far and everything looks good. I have nothing to say 👍

🤝🤝 Hi @Megagig, Great Job so far, your project looks good, and almost all requirements were completed.🤝🤝

Highlights ✔

✅ No linter error
✅ Webpack package configured well
✅ All todo-list features were done
✅ CSS and HTML best practices were applied.

👉  However it is better to add live link to your readme file that enable user to see live view of your project
Cheers 👊👊👊 Happy Coding !


[FLINK-19493] In CliFrontend, make flow of Configuration more obvious

What is the purpose of the change
Before, it was up to the CustomCommandLine implementation whether any Configuration was passed through from the flink-conf.yaml or wherever the base Configuration came from.
Now, we make the flow of the Configuration explicit in CliFrontend.getEffectiveConfiguration(). Instead of relying on the Configuration we get from the CustomCommandLine we ask the CustomCommandLine to materialize its settings and add them manually to an effective Configuration that the CliFrontend controls.
This removes the Configuration parameter from CustomCommandLines that don't need it anymore, such as DefaultCLI, which means we also have to touch tests. Also, the test for DefaultCLI is vastly simplified because the behaviour we were testing there is now in the new ITCase.
This adds a new integration test in CliFrontendITCase that verifies correct parameter passing and also verifies that command line arguments override base settings
I'm also addressing https://issues.apache.org/jira/browse/FLINK-19521 here because I noticed and filed that during implementation. It's a small change but should make the CLI more consistent.
Verifying this change

A new ITCase was added.
Added test for dynamic properties on DefaultCLI

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? yes, dynamic properties for the DefaultCLI
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Will have a look in a bit.

Ah, I forgot to mention this still has sth in it that I don't like: I change CliFrontend.parseAndRun() to bubble up an exception instead of swallowing it so that I can test it. Not sure if we want this, though.

@flinkbot run azure

Thanks! I merged this.


ChEBI: 27923 and ChEBI: 145393 - missing acid/base relationship?

CHEBI:27923 - 2-acyl-sn-glycero-3-phosphoglycerol is marked "preliminary" and is shown as an uncharged molecule, while CHEBI:145393 - 2-acyl-sn-glycero-3-phosphoglycerol(1−) is marked as a "third-party annotation". 145393 looks like it should be major microspecies of this entity at pH 7.3. Can the acid - conjugate base relationship between 27923 and 145393 be added to these annotations?

The conjugate acid/base relationships between the two entries have now been added.


💡[FEATURE]: Initialize Project for Analysis on Smartphones

Title: Initialize Project for Analysis on Smartphones
Description:
I will start a new project based on the Kaggle notebook Analysis on Smartphones by Abhijit Dahatonde. This project will include comprehensive data analysis and visualization of the smartphone market. The following steps will be taken to set up and complete the project:
Tasks:

Project Initialization:

[ ] Create a new repository on GitHub.
[ ] Set up the repository structure with directories for data, notebooks, scripts, and documentation.
[ ] Add a README file outlining the project objectives and structure.

Data Acquisition:

[ ] Download the dataset used in the Kaggle notebook.
[ ] Store the dataset in the appropriate directory within the repository.
[ ] Update the README with instructions on how to obtain and store the dataset.

Exploratory Data Analysis (EDA):

[ ] Reproduce the EDA steps from the Kaggle notebook.
[ ] Create a Jupyter notebook dedicated to EDA, including visualizations and insights.
[ ] Document any additional findings or observations.

Data Visualization:

[ ] Implement the visualizations as outlined in the Kaggle notebook.
[ ] Ensure the visualizations are clear and informative.
[ ] Create a Jupyter notebook dedicated to data visualization.

Results and Insights:

[ ] Document the key insights and observations from the analysis.
[ ] Create visualizations to illustrate the findings.
[ ] Compare the results with any relevant benchmarks or external data.

Documentation:

[ ] Write detailed documentation explaining each step of the project.
[ ] Include a section in the README on how to reproduce the results.
[ ] Add comments and explanations within the Jupyter notebooks.

Version Control:

[ ] Commit the initial version of the project to GitHub.
[ ] Ensure regular commits are made for each significant step.
[ ] Tag versions appropriately to reflect project milestones.

Additional Notes:

This project will follow best practices for code organization and documentation.
Collaboration and feedback are welcome to improve the project further.

Assignees:

Priyanshu Tiwari

It will not add any value to this financial repo

Like how much sale in this year


[REEF-991] Remove deprecated RangeTcpPortProvider.Default and DefaultRemoteManagerImplementation constructor

JIRA:
REEF-991
Pull request:
This closes #

I removed the deprecated DefaultRemoteManagerImplementation constructors, too.

I'll take a look at this.

@dafrista Can you take a look at this PR as well? Given that you filed REEF-547.

@dongjoon-hyun Overall this looks good to me, but I don't really like the liberal use of bindVolatileParameter; however, I'm not really sure if there are any better solutions at the moment.

Thank you for review, @afchung .
I update the code and rebased it.

@dafrista , could you review this?

Looks good to me. @dongjoon-hyun I'll test and merge after waiting for one more day. Thanks!

Sure, no problem. Thank you, @afchung .

Sorry, I'm late to the party.
I'm not sure about these changes. The basic pattern is to create an empty Tang injector, that creates a new instance. This gets us away from using public constructors, but it doesn't remove the underlying dependencies.
The code remains brittle. For example, let's say a constructor for the DefaultRemoteManagerImplementation is added that uses a new named parameter. If the Factory class wants to use this, an extra bindVolatileParameter has to be added anyway.
It also adds one more source of brittleness. The compiler can't check if the binded instances are enough to create an instance of DefaultRemoteManagerImplementation. Using public constructors at least allows the compiler to check if the passed in instances are the correct arguments for a constructor.
That being said, I don't have a great alternative. The best I can come up with is: make the RemoteManagerImplementation constructors package-private, and un-deprecate them. This removes exposure to clients without resorting to dynamic injection.
Thoughts?

Thank you for a thoughtful advice, @dafrista !
Is that guideline applicable for general Tang & Factory patterns?
I'm just curious because we also use bindVolatileParameter in CommunicationGroupDriverFactory.

@dongjoon-hyun from what I understand, the usage in group comm is a bit problematic as well. REEF-924 changed this to getting an injector injected instead. Maybe it makes sense to discuss these patterns more generally in dev@?

Oh, that would be great. Could you trigger that in @dev?
Actually, what I hope to know is the best practice for using Factory pattern with Tang.
By the way, isn't it Thanksgiving Day in USA? It might not be the best time to start discussion. Maybe, next week?
Thank you in any way, @dafrista . :)

You're right @dongjoon-hyun, thanksgiving is not ideal. Let's discuss more next week. Thanks!

Rebased.

@dafrista @dongjoon-hyun An alternative is to create a ConfigurationModule class for RemoteManager, but I'm not sure if the complexity of RemoteManager is enough to justify this.
Overall though, I'm +1 for un-deprecating the constructor.

A way we've dealt with this challenge in the past is the "Inject-a-Factory" pattern: That way, defaults for all the parameters of DefaultRemoteManager can be injected into the DefaultRemoteManagerFactory. And that factory can have methods to pass in additional parameters to overwrite those defaults.
That requires the class and its factory to be in the same package, though. And the class needs to have a package-private constructor used by the factory. And at some place, DefaultRemoteManagerFactory needs to be bound to the interface RemoteManagerFactory.
I thought RemoteManager was on the way to this design?

Hi, all.
Sorry for late update. To trigger another round of reviews, I rebased and updated the code according to the advices. It means  "Inject-a-Factory" pattern with a given Injector.
To implement RemoteManagerFactory,

DefaultRemoteManagerFactory has a package-private constructor having all default parameters for a package-private constructor of DefaultRemoteManagerImplementation in the same package.
DefaultRemoteManagerFactory receives Injector from Tang instead of creating by itself.
In various getInstance functions, DefaultRemoteManagerFactory calls forkInjector and binds volatile variables.

I didn't make ConfigurationModule because I think the current pattern is enough. If I missed something except this, please let me know.

Thanks! I've done a pass.

Thank you, @markusweimer . I changed the followings.

Make DefaultRemoteManagerFactory class as package private class.
Call getInstance(TcpPortProvider.class) instead of getInstance(RangeTcpPortProvider.class).
Make the private instance variable injector as a forked one in a constructor: this.injector = injector.forkInjector();

To use Configuration pattern, it seems to be necessary to use String.valueOf and getClass for all parameters of the following function in order to put them into conf instance and call injector.forkInjector(conf). It looks like a little bit detour for this case.
  public <T> RemoteManager getInstance(final String name,
                                       final String hostAddress,
                                       final int listeningPort,
                                       final Codec<T> codec,
                                       final EventHandler<Throwable> errorHandler,
                                       final boolean orderingGuarantee,
                                       final int numberOfTries,
                                       final int retryTimeout,
                                       final LocalAddressProvider localAddressProvider,
                                       final TcpPortProvider tcpPortProvider) {
    try {
      final Injector newInjector = injector.forkInjector();
      newInjector.bindVolatileParameter(RemoteConfiguration.ManagerName.class, name);
      newInjector.bindVolatileParameter(RemoteConfiguration.HostAddress.class, hostAddress);
      newInjector.bindVolatileParameter(RemoteConfiguration.Port.class, listeningPort);
      newInjector.bindVolatileParameter(RemoteConfiguration.MessageCodec.class, codec);
      newInjector.bindVolatileParameter(RemoteConfiguration.ErrorHandler.class, errorHandler);
      newInjector.bindVolatileParameter(RemoteConfiguration.OrderingGuarantee.class, orderingGuarantee);
      newInjector.bindVolatileParameter(RemoteConfiguration.NumberOfTries.class, numberOfTries);
      newInjector.bindVolatileParameter(RemoteConfiguration.RetryTimeout.class, retryTimeout);
      newInjector.bindVolatileInstance(LocalAddressProvider.class, localAddressProvider);
      newInjector.bindVolatileInstance(TransportFactory.class, this.transportFactory);
      newInjector.bindVolatileInstance(TcpPortProvider.class, tcpPortProvider);
      return newInjector.getInstance(RemoteManager.class);
    } catch (InjectionException e) {
      throw new RuntimeException(e);
    }
  }

Agreed, for the case where instances are provided, bindViolatile is the right approach. Having such a method that completely sidesteps Tang is concerning, but let's leave that to future work. I will test and merge this.

Thank you, @markusweimer !

It looks like @markusweimer provided an "Inject-a-Factory" pattern that works for these situations. Thanks @markusweimer and @dongjoon-hyun !


As a user, I want to be able to add transactions

This issued is resolved by #92, #93, #96 and #99


Ensure all modules within folders are available

There were instances where modules within folders were not picked after installing the client in certain environments.

@arthuroe - Do you happen to have some specific instances I could test with? Were there certain modules that weren't available, or was it happening randomly?

It was happening on our online dev environment. I was getting naas.modules cannot be imported
Below is a screenshot of the items available from the client when we tried to check the modules installed.

On my local, I was able access all modules.  Online the folder items were not picked up.
After I made this change and re-installed the client, all items are now available.

@arthuroe - gotcha. Seems like weird behavior with the inconsistency. Your example helped and I was able to test out locally. All looks good 👍


Replace some dynamic to Object? type

Replace some dynamic to Object? type

@Hixie hi, can this test-exempt?

test-exempt: code refactor without semantic change


ToC in README.md

Description
ToC in README.md
Fixes #280
Type of change

Documentation update

Testing steps
N/A
Checklist

[ ] make before_commit passes
[ ] updated documentation wherever necessary
[ ] added or modified tests if necessary
[ ] updated schemas and validators in insights-data-schemas in case of input/output change

Codecov Report

Merging #333 (d3ef7c3) into master (292c4f6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #333   +/-   ##
=======================================
  Coverage   72.58%   72.58%
=======================================
  Files          11       11
  Lines         580      580
=======================================
  Hits          421      421
  Misses        134      134
  Partials       25       25

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 292c4f6...d3ef7c3. Read the comment docs.


Incorrect parameter name given in code examples

The parameter list correctly lists the parameter as AzureStackLCMUserCredential
But the example code uses a wrong parameter AsHciDeploymentUserCredential
This should be updated

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: fd5a83a8-3d61-090c-68f9-002b03048ef9
Version Independent ID: 5eb2d3d1-d12e-9f7f-fa2f-4c2d54869388
Content: Prepare Active Directory for new Azure Stack HCI deployments (preview) - Azure Stack HCI
Content Source: azure-stack/hci/deploy/deployment-tool-active-directory.md
Service: azure-stack
Sub-service: azure-stack-hci
GitHub Login: @alkohli
Microsoft Alias: alkohli

@MrCNeale
Thanks for your feedback! We will investigate and update as appropriate.

@MrCNeale
Thanks for reporting this! We have created a PR for this issue and the changes should go live soon.
https://github.com/MicrosoftDocs/azure-stack-docs-pr/pull/13229


coefs

I'm a bit new to Stats. Please could share what coefs, the role it plays and how possible how it can be computed for a tabular data classification task?
Ref:
https://github.com/CVxTz/IntegratedGradientsPytorch/blob/760c88490e6b9df68f26de566dea9d06e49dd208/code/mlp_gradient.py#L97

This is just a toy example where I define the relationship between X and Y and then use integrated gradient to see if the method can discover this relationship on its own.

I understand that it is a toy example
I would like to repeat the process for a real data. I'm stuck at coef
I'm not sure of what to replace it with for a real data.


Add PLR: Pillar

[x] I understand that token listing is not required to use the Polygon Wallet with a token.

Token Name: Pillar
Token Symbol: PLR
Decimals: 18
Polygon Address: 0xa6b37fC85d870711C56FbcB8afe2f8dB049AE774
Ethereum Address: 0xe3818504c1B32bF1557b16C238B2E01Fd3149C17
Logo URI: https://etherscan.io/token/images/pillar_32.png
Project Name: Pillar
Project Summary: Pillar is a community-run smart wallet supporting Ethereum and EVM-compatible chains - Polygon, xDai & Binance Smart Chain and Avalanche - in a unified multichain experience. Powered by Etherspot and governed by the DAO through its own native token - PLR. Pillar aims to become a one stop DeFi experience.
Project Contact: https://twitter.com/pillarwallet
Project Website: https://www.pillar.fi/
Mainnet/Testnet: Mainnet

Included in AllTokens v1.2.0.


Skip flaky daemon tests

For https://github.com/microsoft/vscode-python/issues/12690

Codecov Report

Merging #12691 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12691      +/-   ##
==========================================
- Coverage   60.05%   59.98%   -0.08%
==========================================
  Files         664      664
  Lines       36067    36067
  Branches     5093     5093
==========================================
- Hits        21661    21634      -27
- Misses      13327    13352      +25
- Partials     1079     1081       +2

Impacted Files
Coverage Δ

src/client/common/process/pythonDaemonPool.ts
43.51% <0.00%> (-25.00%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 678e016...19de4d0. Read the comment docs.


Added My self

Related issue

What changes does this PR do?
Screenshots (If any)
Questions

closing due to inactivity feel free to reopen at any time


Create an ABAP Project in ABAP Development Tools (ADT)

Hi,
I'm following this tutorial https://developers.sap.com/tutorials/abap-create-project.html and needs logon data. I tried my logon data that I'm using to access developers.sap.com but the access still fail. Is this correct?
Logon to system NPL failed (partner '<IP_ADDRESS>:3300' not reached)
Other issue and I don't know if is related to the first is eclipse showing an error with this message:
Location 'C:\Users\User\AppData\Roaming\SAP\Common' does not point to a SAP GUI configuration file

Hi @julieplummer20. Following the Tutorial was not very explicit how to get the logon data. After some research I understand that I need to install miniSap and then use the default logon data generated for developer user. Now I'm ok with and this thread can be closed.
I can achieve this following the tutorial bellow created by you. Thanks twice.
https://blogs.sap.com/2017/09/04/newbies-guide-installing-abap-as-751-sp02-on-linux/

Glad to hear, @rafaelfigueiredo-l. Thanks for closing. Hope you enjoy!


How do i get same woking of lockPanToHorizon with landscape mode in device

First at all, thanks for your code.
As title, how can i got it.
Currenly my project is support landscape only, however when show PanoramaView on landscape, user can change portrait.

thanks for catching this, sorry I missed it. I hope to get a fix going in the next couple days

any update for this?
Hero man :)

Hi, sorry I disappeared,
Is it working for you now? Everything seems to be working on my end.
To be clear, you're doing "Device Orientation: Landscape Right" (or Left), and adding the line [panoramaView setLockPanToHorizon:YES]; ? This is working for me.


feat(client): adapt openAPI updateStorageConfig

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

6 of 6 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 83.358%

Totals

Change from base Build<PHONE_NUMBER>:
0.01%

Covered Lines:
5570

Relevant Lines:
6682

💛  - Coveralls


Update config.yml

Fix some documentation (added spaces after #.). Please test before merge as IDK if this will break it. Just trying to make this amazing product look more professional.

@Tecnio

Thank you :)

This is considered spam under the Hacktober please label this as spam.


EntityManager / JPA

I'm looking to use the general JPA APIs for persistence.  No need for any of the hibernate-specific functionality.  Is that something that already exists or is being contemplated?

Is there any interest in this?  I've put together an initial impl. and am happy to contribute it as a bundle so that it may be improved by others.

Given we have JDBI & Hibernate, I don't think we need it.
The process for your getting your repo in the DW org is discussed here:
https://groups.google.com/d/msg/dropwizard-dev/eiiTDVFqmTc/K2gyDI90x7kJ
Alternatively, you can keep it in under your user name and we can list it here:
http://modules.dropwizard.io/thirdparty/

@eepstein any progress on the jpa bundle?

I got it most of the way done. This was for DW 0.8.x however.
With 0.9.2 the main need - transactions outside the persistence layer - was addressed.
I can share what I have (if I can find it).

On Jun 15, 2016, at 11:44 AM, Carsten Klein<EMAIL_ADDRESS>wrote:
@eepstein any progress on the jpa bundle?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@eepstein how about making this a public project then :+1:

Will do. I'll see where I put it. Was on a different dev box at the time.

On Jun 15, 2016, at 2:10 PM, Carsten Klein<EMAIL_ADDRESS>wrote:
@eepstein how about making this a public project then 👍
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Hi Carsten,
I’m really sorry to say I don’t have access to the code anymore.  It was under contract at a company on their machines backed by their repo… they were OK with o/s contributions, but seems I never did that and since they’re not a current client I don’t have the code.  :-/
Ezra

On Jun 15, 2016, at 2:10 PM, Carsten Klein<EMAIL_ADDRESS>wrote:
@eepstein https://github.com/eepstein how about making this a public project then 👍
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/dropwizard/dropwizard/issues/920#issuecomment-226321109, or mute the thread https://github.com/notifications/unsubscribe/ADQ5Q1ukqbcZOwS9sw6iRnKFAgbWbhE9ks5qMGo8gaJpZM4DqKZx.

@eepstein oh well, no problem. will look into this then myself...

@silkentrance I'd put together JPA (for all persistence), Dropwizard using guice-persist (for DI and made writing transactional methods @Transactional annotation). The drawback is the @Transactional semantics don't work in Jersey 2 resources (as they're not loaded by Guice) for which I ended up having to use manual transaction management. An example implementation is presented here https://github.com/oregami/dropwizard-guice-jpa-seed .
Having said that, I don't recommend using guice with dropwizard at all, as it's painful to setup DI into Jersey resources and it can also break in the future due to incompatibilities.

Yes, it's a good advice. I think, If you are using JPA, it's just simplier to go with Spring, which has good integration with it. You can easily combine Spring and Dropwizard though.

I just created and published a JPA module for Dropwizard that I derived from Dropwizard Hibernate.  It provides a shareable, thread-safe EntityManager that works with the UnitOfWork annotation.  There's no persistence.xml needed; setup and configuration is nearly identical to Dropwizard Hibernate.
I hope other people find this useful.  So far I've published versions to work with Dropwizard 0.9.0 - 0.9.3.  I'm holding off on releasing a version compatible with Dropwizard 1.0.0 in hope I can get some feedback first.
Github: https://github.com/scottescue/dropwizard-entitymanager
User Guide: http://scottescue.com/dropwizard-entitymanager/

Hi scott, i would really like to give you some feedback to your JPA module, but due to the hibernate version upgrade in Dropwizard 1.0.0, i can't. I will stay tuned for a update compatible with Dropwizard 1.0.0 ;)


Feat : ✨ Add hour from which the day is displayed

Description
This feature adds a startHour parameter in WeekView + DayView that allows us to choose from which hour a day will be displayed. The parameter is an int that goes from 0 to 23.
Example with the startHour parameter set to 5 :

Checklist

[x] The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
[x] I have followed the Contributor Guide when preparing my PR.
[ ] I have updated/added tests for ALL new/updated/fixed functionality.
[x] I have updated/added relevant documentation in docs and added dartdoc comments with ///.
[x] I have updated/added relevant examples in examples or docs.

Breaking Change?

[ ] Yes, this PR is a breaking change.
[x] No, this PR is not a breaking change.

Related Issues

Based on the issue #240 but only resolves the 'min' hour.

Hello, @Mael-Kehl  Please resolve the conflicts in this PR.

solved conflicts on PR:
https://github.com/SimformSolutionsPvtLtd/flutter_calendar_view/pull/319

refer #319  for updates


Ability to customize output window

change background color
change text color
change floating position on screen

Do you mean giving library users ability to customize output window while initializing NumberOverlay? like passing arguments:
NumberOverlay.initialize(this, Color.BlACK, Color.RED) for example?

#3 Solves this.


Cannot run from custom root path

Trying to setup a Traccar instance on my Apache2 server - I can not use the root location for the application, and the application must run from either port 80 or 443 (HTTP or HTTPS).
I have read the instructions on how to setup with an HTTPS reverse proxy using Apache2, but this assumes using the default root path.
I'm trying to run the application from another root path, such as /traccar
Attempting to use /traccar in the ReverseProxy configuration results in numerous 404 errors. Digging through the source code, I could not find any configuration to set the root path as the application assumes it is running from /

https://www.eclipse.org/jetty/documentation/9.3.x/configuring-contexts.html
This might have more information on setting a contextpath

Traccar is not a web app. It's a system service. Can you run those?

Yes, I can get it all to run perfectly from the root path, just not a deeper contextpath

You might need to modify some paths. For example here:
https://github.com/tananaev/traccar/blob/master/web/app/store/AllDevices.js#L23
Alternatively you can keep /api at the top level. I think it should work that way.


feat: accept sanity file asset as an image type

If you add a pdf file to sanity, for example a brochure that could be downloaded on a click of a link, groqd currently throws a zod error of: 'result[0].brochure.asset._type': Invalid literal value, expected "sanity.imageAsset".
An example query would be:
brochure: sanityImage('brochure', {
  withAsset: ['base'],
}),

We should be able to add a pdf and use the sanity image schema to type the response.
I added a Zod Union of sanity.fileAsset & sanity.imageAsset which should now allow the type of the file to pass.
There is potentially a little more work to do here as the file type response is not identical to the Image type response, might need some guidance on how you would want to proceed here.
Open to any feedback and happy to make any requested changes.

pnpm run changeset

Done, should be there now @gksander 😃


Versioning improvements

Use autonlp.version as single source of truth
Add a --version argument to AutoNLP CLI

closes #40


FindMergeCommits fills up /tmp

/tmp is full again :(. The script crashed due to no storage space remaining. The script leaves many files in scheschb/ast-merge-eval-data/
[scheschb@tricycle tmp]$ find scheschb/ast-merge-eval-data/ -user scheschb | wc -l
281415

@mernst Could you maybe look into this? It's not an urgent problem but I think we should fix this.

This is handled in https://github.com/benedikt-schesch/AST-Merging-Evaluation/pull/179, whose make small-test is failing in Python for reasons I don't understand.

Well, partially handled.  It puts files in /scratch which has lots more space, but it does not yet delete them.

Ok, thank you

I'll mark it as fixed for now.


Server Settings Editor are not saving some specific configurations.

I am setting up one dedicated server using this manager (who I found so useful and practical) and settings like Description, RCON Password and Password himself (Server password) just don't save using the editor.
I'm not started changing Game Settings with the manager editor yet, if I found the same problems I will inform.

I think I've been able to reproduce this. Make sure that before you save, click another field or a few of them so that it properly saves the value of the current field. Might find a fix for this in the future.

Should be fixed with semi-MVVM implementation.


Fixed websocket reference cycle

Websockets aren't being deallocated

Note: 1 test is failing, but not because of my changes.

Nice! Could you add a test case so we can make sure this doesn't happen in the future?

Added a test @calebkleveter. I don't write many tests, but it appears to verify the fix. Let me know if you have any suggestions.

Hey @grahamburgsma, you just merged a pull request, have a coin!
You now have 2 coins.


Make it easier to find release dates and lifetimes of releases

Is your enhancement proposal related to a problem? Please describe.
The release dates of Zephyr is mainly only visible from https://github.com/zephyrproject-rtos/zephyr/releases, but the search feature is quite bad and it's hard (or at least harder) to find the release you are looking for a release date from.
Describe the solution you'd like
Something like the release table from https://www.python.org/downloads/ would be nice, where you have the release date and the end of life support. This could be expanded with information about LTS and if there are "subreleases" like 2.7.1 and 2.7.2.
This information should also be available on docs.zephyrproject.org/ and not Github.
Describe alternatives you've considered
N/A
Additional context
N/A

Perhaps we could add "(LTS)" to the LTS releases on https://docs.zephyrproject.org/latest/releases/index.html

Perhaps we could add "(LTS)" to the LTS releases on https://docs.zephyrproject.org/latest/releases/index.html and list their EOL in the respective release notes?

That would also be nice. The list of releases we have is nice, but adding EOL and date on those would make it very easy to get an overview

Another example for a release overview: https://wiki.yoctoproject.org/wiki/Releases

@kartben -  Is this something you could look into?  I'm not sure this warrants discussion by the Process WG.

IMO this is already done here https://docs.zephyrproject.org/latest/releases/index.html#supported-releases and it is not a process related issue


Spotify Widget N/A

Using latest rainmeter beta and sysDash.
The widget is broken.
I'm Spotify premium user.

Samers. I changed a line in Media (big).ini:
; Measure to set the correct media player mode
[MeasureSetMediaPlayer]
IfMatch=WebNowPlaying
WebNowPlaying works for Artist/Track information but the progress bar and album art don't work. Would love a fix for this. Really enjoying the plugin otherwise. :)

Thank you for the work-around!

Samers. I changed a line in Media (big).ini:
; Measure to set the correct media player mode
[MeasureSetMediaPlayer]
IfMatch=WebNowPlaying
WebNowPlaying works for Artist/Track information but the progress bar and album art don't work. Would love a fix for this. Really enjoying the plugin otherwise. :)

This is awesome! Thank you so much for this work-around ^_^

Hey, I've written a script for WebNowPlaying with full functionality. Since I have no idea on how to create a pull request, I opted to post the files here.
On a side-note: If you change the value of IfMatch to WebNowPlaying, the fallback script MeasureNowPlaying.inc is being used, because the value of PlayerName from variables.ini  won't match WebNowPlaying. The fallback script grabs windows playback information. That's why only artist and title is being displayed correctly.
Prerequistes:

Spicetify with WebNowPlaying enabled (How to install)
A working SysDash

Installation

Drag and drop the files from the appended zip archive into Documents/Rainmeter. Overwrite if asked.
Open<EMAIL_ADDRESS>and change PlayerName=Spotify to PlayerName=Web
Right-click your SysDash and press refresh.
FilesToReplace.zip

Hey, I've written a script for WebNowPlaying with full functionality. Since I have no idea on how to create a pull request, I opted to post the files here.
On a side-note: If you change the value of IfMatch to WebNowPlaying, the fallback script MeasureNowPlaying.inc is being used, because the value of PlayerName from variables.ini won't match WebNowPlaying. The fallback script grabs windows playback information. That's why only artist and title is being displayed correctly.
Prerequistes:
* Spicetify with WebNowPlaying enabled ([How to install](https://github.com/marcopixel/Monstercat-Visualizer/wiki/WebNowPlaying-Spotify#installation))

* A working SysDash

Installation
1. Drag and drop the files from the appended [zip archive](https://github.com/marcopixel/SysDash/files/4027488/FilesToReplace.zip) into `Documents/Rainmeter/Skins`. Overwrite if asked.

2. Open<EMAIL_ADDRESS>and change `PlayerName=Spotify` to `PlayerName=Web`

3. Right-click your SysDash and press refresh.

Hey! Don't know why, but on my rainmeter (4.3.1) after doing this everything just says "0.0." If you have any idea why this might be, help would be greatly appreciated.

Hey, I've written a script for WebNowPlaying with full functionality. Since I have no idea on how to create a pull request, I opted to post the files here.
On a side-note: If you change the value of IfMatch to WebNowPlaying, the fallback script MeasureNowPlaying.inc is being used, because the value of PlayerName from variables.ini won't match WebNowPlaying. The fallback script grabs windows playback information. That's why only artist and title is being displayed correctly.
Prerequistes:
* Spicetify with WebNowPlaying enabled ([How to install](https://github.com/marcopixel/Monstercat-Visualizer/wiki/WebNowPlaying-Spotify#installation))

* A working SysDash

Installation
1. Drag and drop the files from the appended [zip archive](https://github.com/marcopixel/SysDash/files/4027488/FilesToReplace.zip) into `Documents/Rainmeter/Skins`. Overwrite if asked.

2. Open<EMAIL_ADDRESS>and change `PlayerName=Spotify` to `PlayerName=Web`

3. Right-click your SysDash and press refresh.

Hey! Don't know why, but on my rainmeter (4.3.1) after doing this everything just says "0.0." If you have any idea why this might be, help would be greatly appreciated.

Hey, sorry for only getting back to you now. What exactly do you mean with everything says 0.0? (A screenshot would help!)

I'm experiencing the same issue @ninja9d1 described. Here's a screenshot:


[release-4.14] MIWI - Explicitly load the BoundSASigningKey asset and add it to the install graph

Manual cherry-pick of #174 to release-4.14 branch due to merge conflicts

/refresh

/retest


Load voltage thresholds adjusted and inhibit added

During tests, the deep discharge counter increased by several 100 counts per day under certain circumstances, most probably because of quite small battery making the voltage toggle between disconnect and reconnect voltage. This commit suggests several improvements.

Load reconnect voltage increased
Don't reconnect before waiting at least 1h (lvd_timestamp in load.cpp)
SOC filter calculation slightly changed to make sure 100% is reached fast enough.

Don't know if it's standard to wait some time. But if the battery is really at low SOC, it's not realistic that it's full enough after 15 minutes recharging already. And if the connected load stays the same as before, it would also switch off again after less than 15 minutes. So I thought it makes sense to wait at least an hour to get some new charge into the battery.
I did some research regarding the LVD (low voltage disconnect) and LVR (low voltage reconnect) thresholds of other manufacturers:

Steca PWM: LVD 11.6 V, LVR 12.4 V
Victron MPPT: LVD 11.1 V, LVR: 13.1 V or even 14.0 V depending on setting
Phocos PWM: LVD: 11.0 V, LVR: 12.8 V

EN 62093 suggests LVD of 10.8 to 11.4 V and LVR of 12.3 to 12.9 V, depending on current during switch-off. I took a value in the middle, as the lower end for LVR did already result in a toggling load.

Alright, I'm happy then - Merging

This is an automatic reply to your message

Sie haben eine E-Mail an die Adresse<EMAIL_ADDRESS>geschickt.
Leider bin ich bis einschließlich 23.07.2019 18:00  nicht im Labor.
In dringenden Fällen wenden Sie sich bitte an Herrn Gerhard unter
der Telefonnummer 0391/24468-246 bzw<EMAIL_ADDRESS>Vielen Dank für Ihr Verständnis.

File names:
JordanSilverman commented on this pull request.
So you've increased the load reconnect to 12.6V (for 12v systems)? Are we sure this is low enough? I'm worried that people will complain about having charge but no load available. Should we confirm with Gopi what the standard is?
Is it also standard to wait some time before reconnecting after low SoC? Does it need to be 1 hour or can we reduce it to say 15 mins?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/LibreSolar/charge-controller-firmware/pull/40#pullrequestreview-262907045

This is an automatic reply to your message

Sie haben eine E-Mail an die Adresse<EMAIL_ADDRESS>geschickt.
Leider bin ich bis einschließlich 23.07.2019 18:00  nicht im Labor.
In dringenden Fällen wenden Sie sich bitte an Herrn Gerhard unter
der Telefonnummer 0391/24468-246 bzw<EMAIL_ADDRESS>Vielen Dank für Ihr Verständnis.

File names:
Alright, I'm happy then - Merging
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/LibreSolar/charge-controller-firmware/pull/40#issuecomment-512259623

This is an automatic reply to your message

Sie haben eine E-Mail an die Adresse<EMAIL_ADDRESS>geschickt.
Leider bin ich bis einschließlich 23.07.2019 18:00  nicht im Labor.
In dringenden Fällen wenden Sie sich bitte an Herrn Gerhard unter
der Telefonnummer 0391/24468-246 bzw<EMAIL_ADDRESS>Vielen Dank für Ihr Verständnis.

File names:
Don't know if it's standard to wait some time. But if the battery is really at low SOC, it's not realistic that it's full enough after 15 minutes recharging already. And if the connected load stays the same as before, it would also switch off again after less than 15 minutes. So I thought it makes sense to wait at least an hour to get some new charge into the battery.
I did some research regarding the LVD (low voltage disconnect) and LVR (low voltage reconnect) thresholds of other manufacturers:

Steca PWM: LVD 11.6 V, LVR 12.4 V
Victron MPPT: LVD 11.1 V, LVR: 13.1 V or even 14.0 V depending on setting
Phocos PWM: LVD: 11.0 V, LVR: 12.8 V

EN 62093 suggests LVD of 10.8 to 11.4 V and LVR of 12.3 to 12.9 V, depending on current during switch-off. I took a value in the middle, as the lower end for LVR did already result in a toggling load.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/LibreSolar/charge-controller-firmware/pull/40#issuecomment-512185412

This is an automatic reply to your message

Sie haben eine E-Mail an die Adresse<EMAIL_ADDRESS>geschickt.
Leider bin ich bis einschließlich 23.07.2019 18:00  nicht im Labor.
In dringenden Fällen wenden Sie sich bitte an Herrn Gerhard unter
der Telefonnummer 0391/24468-246 bzw<EMAIL_ADDRESS>Vielen Dank für Ihr Verständnis.

File names:
Merged #40 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/LibreSolar/charge-controller-firmware/pull/40#event-2489470154


Remove more tokens from the tree

There are a couple of changes in this, split out over the various commits. The overarching effort is to replace tokens in the tree in favor of locations. In service of that, we have the following commits:

Drop token[] in favor of location[]. This is exclusively used in the context of block-local variables. There's no need to store the extra type byte for all of these. This is the last usage of token[] in the list, but unfortunately it means we need to introduce location[]. At least this one is smaller and doesn't require knowledge of tokens.
Use YP_EMPTY_NODE_LIST instead of yp_node_list_init. This uses a macro instead of a function call. It's effectively the same thing, and the creation nodes end up being a little cleaner.
InterpolatedSymbolNode#opening -> InterpolatedSymbolNode#opening_loc, replaces the optional token with an optional location.
SymbolNode#opening -> SymbolNode#opening_loc and SymbolNode#value -> SymbolNode#value_loc. These always have the same kinds, so it's duplicate information.
InterpolatedSymbolNode#closing -> InterpolatedSymbolNode#closing_loc, replaces the optional token with an optional location.
SymbolNode#closing -> SymbolNode#closing_loc, same.
CallNode#call_operator -> CallNode#operator_loc + CallNode#flags. call_operator was previously a token, and the type was necessary to delineate between . and &.. Instead we're now keeping around a location for the operator and adding an additional set of flags to the CallNode that represent whether or not &. was used. This closes #809.
CallNode#message -> CallNode#message_loc, since we already have the actual method name as a string, this was just unnecessary information.
CallNode#opening -> CallNode#opening_loc and CallNode#closing -> CallNode#closing_loc. These were parentheses or brackets, but it's really not necessary for the consumer to know, and if they want to know they can reference the source.

The three remaining tokens in the tree are:

GlobalVariableReadNode#name
GlobalVariableWriteNode#name
OperatorAssignmentNode#operator

These require a little more thought. I think GlobalVariableReadNode should actually be split up into a couple of nodes because it can contain different types. It can be a back reference, and nth reference, or a global variable. We should have individual nodes for these, especially because only global variable can be set, the others can only be read.
For the operator assignment, we should have an enum for the operator so that folks don't have to reference the source.

@jemmaissroff looking for your approval again since this completely changed since the last time you reviewed it 😅


Remove Production/Processing thresholds on JobSubmitter

Specific issue related to #8129
As discussed in previous discussions with @vlimant , we plan to get rid of the Production/Processing task thresholds and use instead the schedd limitation MAX_JOBS_PER_OWNER.
Initial developments were done https://github.com/dmwm/WMCore/pull/8228 and https://github.com/dmwm/WMCore/pull/8250
@ticoann didn't we have to change something somewhere else too?

Fixed by #8288 , though we followed a slightly different/better idea, which is keeping the thresholds but over-submitting jobs that have a higher priority than anything else in the agent (20% of the thresholds only though).