resourceGroup().tags does not always work

Seems that resourceGroup().tags does not work when you apply the tags this way:
https://docs.microsoft.com/en-us/azure/azure-resource-manager/management/tag-resources#apply-tags-to-resource-groups-or-subscriptions

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0551fca9-d710-15d1-9141-baf2121a4ab1
Version Independent ID: cc554f24-a13d-d3ab-a3c6-c610f4d0b461
Content: Template functions - resources - Azure Resource Manager
Content Source: articles/azure-resource-manager/templates/template-functions-resource.md
Service: azure-resource-manager
Sub-service: templates
GitHub Login: @mumian
Microsoft Alias: jgao

@slavizh Thanks for the question! We're investigating this and will get back to you shortly.

@slavizh - are you applying tags in a template and then also trying to retrieve those values with resourceGroup().tags in the same template?

@tfitzmac Yes. Basically trying to create/update the resource group without applying the tags directly on resource group resource. That way if someone has added a tag manually it will not be wiped out by the tags I am trying to apply. Then I am trying to get the tags via resourceGroup().tags, merge them with the tags I want to apply  so I can apply them via Microsoft.Resources/tags resource.

@slavizh - I ran a test and it worked as expected. I have a variable that combines the tags. I apply that variable to the tags for the resource group.
"variables": {
"combinedTags": "[union(resourceGroup().tags, parameters('tags'))]"
},
"resources": [
{
"type": "Microsoft.Resources/tags",
"name": "default",
"apiVersion": "2019-10-01",
"dependsOn": [],
"properties": {
"tags": "[variables('combinedTags')]"
}
}
]

@slavizh Hope the above responses helped. Do reach out in case of further questions.

@slavizh At this point, it appears that there are no edits or updates needed to the document in question. Hence closing this issue for now. If there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.

@tfitzmac @BhargaviAnnadevara-MSFT I am not sure how you have tested this but it does not work for me. For example:

if you are creating the resource group via Microsoft.Resources/resourceGroups type and you do not specify tags property (on Microsoft.Resources/resourceGroups ) at all when you try to call resourceGroup().tags you get error like "message": "Unable to process template language expressions for resource '/subscriptions//resourceGroups//providers/Microsoft.Resources/tags/default' at line '54' and column '9'. 'The language expression property 'tags' doesn't exist, available properties are 'id, name, type, location, properties'.'", In this case the function should return empty object "{}" instead of producing error.
if the resource group is created and you have added a tag via the portal. Then when you deploy the resource group via Microsoft.Resources/resourceGroups type  you do not specify tags property (on Microsoft.Resources/resourceGroups ) when you try to call resourceGroup().tags you get the same error like above.

For those two scenarios for sure resourceGroup().tags does not work consistently. I am trying to address these things to the product group as I think these are bugs but until then these should be documented.

After some more investigation the problem lies in two issues:

When you do not specify tags property on Microsoft.Resources/resourceGroups type the existing tags are wiped out.
resourceGroup().tags returns the above error instead of empty object ({}) when the resource group does not have tags.


What version is compatible with Angular 2

When I run my app (which is still Angular2) I get an error that @angular/core/index has no exported member 'Renderer2'.  From what I've read this is because Renderer2 didn't exist until Angular4.
So, what is the latest version of this library that still supported Angular2?  And, will the usage be mostly the same?

I'm using the following versions which seems to be working with Angular 2.0.0:
    "angular2-text-mask": "8.0.5",
    "text-mask-addons": "3.8.0",


[ENH] Expand contributing guidelines 🥳

Closes #171

Changes proposed in this pull request:

New sections:

"Identifying an issue to work on"
"Making a change"
"Have a question about contributing?"

Updated sections:

"Pull request guidelines"
"Pull request reviews"

pull_requests.md -> CONTRIBUTING.md

Checklist

[x] PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF]) (see https://neurobagel.org/contributing/pull_requests for more info)
[x] PR links to GitHub issue with mention Closes #XXXX
[x] Checks pass

Thanks for your feedback @rmanaem and @surchs! 🥳
Have another look at the changes and the remaining conversations to see if you agree with the points made.

Would it also make sense to link this prominently on our welcome page?

Sure - under the "Our team" section at the bottom perhaps?

I meant this doc: https://github.com/neurobagel/.github/blob/main/profile/README.md
not our website/documentation. i.e. the little text you see first when you go to https://github.com/neurobagel

@surchs I see! No problem. Let's address that as part of this issue:

https://github.com/neurobagel/.github/issues/9


Using the Query.fork() function with the 'OR' operator

I'm looking for a way to apply multiple criterions (from a List) to a single query, seperated by the 'OR' operator.
I tried this using the Query.fork() function and appending another criterion in a for-loop. But those criterions get seperated using the operator 'AND'.
Is there any simple way to achieve this, except compiling every query and appending them to plain SQL?

Does Criterion.or meet your needs?
Criterion orConcatenatedCriterion = Criterion.or(criterion1, criterion2, ..., criterionN);
query.where(orConcatenatedCriterion);

Yes! That was quick. Thanks for the fast answer!

Great! Glad that worked, I wasn't sure if the varargs would be a feasible approach for you or if it HAD to be a List :) If you had needed to iterate through the list, you can also do the following:
Criterion orCriterion = criterionList.get(0);
for (int i = 1; i < criterionList.size(); i++) {
    orCriterion = orCriterion.or(criterionList.get(i));
}
query.where(orCriterion);

I think creating a conjunction criterion like this from a List rather than the varargs array Criterion.or and Criterion.and is a valid use case, so we can introduce functions to make this easier in a future release. Glad that the varargs version works for you though!


Explore go-to-definition

Ideally, this would be able to correctly resolve contracts in node_modules regardless of the build tool.

An unsolicited comment on this: this really should be part of an LSP that then can be used through coc.nvim or something like that. The solidity team has an open issue about this, but it doesn't seem like it will be implemented soon.


Unable to build on MacOS Big Suryt

Installation log after running sudo make install
install -D -m0755 bin/echowo /usr/bin/echowo
install: illegal option -- D
usage: install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
               [-o owner] file1 file2
       install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
               [-o owner] file1 ... fileN directory
       install -d [-v] [-g group] [-m mode] [-o owner] directory ...
make: *** [install] Error 64

It looks macos install have no -D option like GNU install, so i made a fix using mkdir -p instead install -D.
maybe you need pass PREFIX=/usr/local for macos too.
 # make install PREFIX=/usr/local


Relative path for assets array in angular-cli.json file not working

Hi guys,
Using relative path for dealing with assets is not working. For example if I want to use images as my assets from a node module folder.
OS?
Mac OSX Sierra
Versions.
angular-cli: 1.0.0-beta.18
node: 6.8.1
os: darwin x64
Repro steps.
This is what my angular-cli.json file looks like:
{
  "project": {
    "version": "1.0.0-beta.18",
    "name": "project_name"
  },
  "apps": [
    {
      "root": "src",
      "outDir": "build",
      "assets": [
          "assets",
          "../node_modules/my_module/assets"
      ],
      "index": "index.html",
      "main": "main.ts",
      "test": "test.ts",
      "tsconfig": "tsconfig.json",
      "prefix": "app",
      "mobile": false,
      "styles": [
        "bootstrap.scss",
        "style.scss"
      ],
      "scripts": [
          "../node_modules/node-uuid/uuid.js"
      ],
      "environments": {
        "source": "environments/environment.ts",
        "dev": "environments/environment.ts",
        "prod": "environments/environment.prod.ts"
      }
    }
  ],
  "addons": [],
  "packages": [],
  "e2e": {
    "protractor": {
      "config": "./protractor.conf.js"
    }
  },
  "test": {
    "karma": {
      "config": "./karma.conf.js"
    }
  },
  "defaults": {
    "styleExt": "css",
    "prefixInterfaces": false
  }
}

The log given by the failure.
No error, just the assets files from the node_modules folder aren't copied to the dist, build for me, one.
Mention any other details that might be useful.
In the case of relative path I think it should copy the files from the specified folder without keeping the hierarchy. Just taking files and folder in it but without recreating the whole hierarchy of folder in the assets folder.
By the way images from the src/assets folder are correctly copied into dist.
So i don't know if it's known or not but I think it can be really useful, for me I'm creating packages for my app and some will have images in them.

Btw it's not working for both serveand buildcommand.

This isn't a scenario that we want to support currently. The main reason against it is the final path. The current solution means to always keep your dir structure so that you can reference things via predictable static paths. This just isn't possible if you're looking to have things pulled over from outside the project.
My best recommendation is to copy over those assets to inside the project. If you don't want to have them there in the repo, you can add it to the gitignore.

Followup feature request: https://github.com/angular/angular-cli/issues/3555

Sweet.
I ended up using a symlink to do that but if a built-in solution come it will be better.

Instead of just ignoring/doing nothing, could a warning/error be displayed, such as

Attempt to bring in asset outside the project tree


Performance benchmarking for test suite

Describe the problem

Benchmarking Taxi data and Census data on every commit and PR.

Duplicate of #1126


Flow analysis issue with switch statement on a record containing a bool and other fields

The following program emits an error on Dartpad using the stable, beta, and master channels:
void main() {
  final (String, bool) a = ('a', false);
  final int b;
  switch (a) {
    case (_, true): b = 1;
    case (_, false): b = 2;
  }
  print(b.isEven);
     // ^
     // The final variable 'b' can't be read because it's potentially unassigned at this point.
}

Changing to a (bool, ) or changing to a switch expression fixes the error:
void main() {
  final (bool, ) a = (false, );
  final int b;
  switch (a) {
    case (true, ): b = 1;
    case (false, ): b = 2;
  }
  print(b.isEven); // ok
}

void main() {
  final (String, bool) a = ('a', false);
  final int b = switch (a) {
    (_, true) => 1,
    (_, false) => 2,
  };
  print(b.isEven); // ok
}

Most likely an artifact of the flow analysis and the exhaustiveness analysis being separate analyses.
The flow analysis cannot see by itself that the switch statement is exhaustive, so it assumes that there is a path through without assigning to b.
Then the exhaustiveness analysis sees that the switch is actually exhaustive, but then it's too late to change the inferred types and definite assignment already set by the flow analysis.
The reason it works to change the record to (bool,) is that that type requires the switch to be exhaustive, so the flow analysis assumes that it is. The later exhaustiveness analysis confirms that, otherwise it would just be an error.

I have encountered a similar problem:
int switchStatement(String? s) {
 // ^ The body might complete normally, causing 'null' to be returned, but the return type, 'int', is a potentially non-nullable type.
  switch (s) {
    case _?:
      return 1;
    case null:
      return 0;
  }
}

// Works fine
int switchExpression(String? s) {
  return switch (s) {
    _? => 1,
    null => 0,
  };
}

Here, despite having the same cases, the switch expression recognizes that it is exhaustive, but the switch statement does not.
Does this maybe have the same cause, or should I file a separate issue?

This looks like one of these cases where it would be nice for the analyzer to detect that there is a problem if the switch is not exhaustive, and the propagate that back as a requirement that the switch must be exhaustive.
Instead of say "it's a problem that you can get past the switch, which doens't look like it should be exhaustive."
(Also, that paritcular switch should be easy to recognize as actually exhaustive, null and _? exhausts Object?.)


[docs] Basic tutorial: Vector stores and retrievers

As per discussion: #7132

Added new tutorial to langchainjs documentation for vector stores and retrievers (same as python)

@jacoblee93 How can I get access to Vercel deployment details? I can't fix it unless I can have a glance at the error


Show the real week nbr

The week number is now the actual week number instead of the static number 29.

For me it is showing the wrong week by +1.
Also found a way to do this in Python.
Something like this can be placed in a subfolder called utils ( will be needed later, check moore for inspiration)
import datetime
def current_week():
return datetime.datetime.now().strftime("%W")


[SQL] [Build] [Minor] Removes nonexistent sql.Dsl imports from sql/console and hive/console

The org.apache.spark.sql.Dsl object has been removed since branch-1.3, should also remove them from SBT hive/console and sql/console initial commands.

@liancheng see also https://github.com/apache/spark/pull/5011 just submitted. Is the new import vinod added needed?

Test build #28564 has started for   PR 5012 at commit d9e6104.

This patch merges cleanly.

Test build #28564 has finished for   PR 5012 at commit d9e6104.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28564/
Test PASSed.

@srowen Adding sql.functions is more convenient, I'd prefer #5011 over this PR. Thanks for pointing this out!


Errors in sensor values continue to occur with continuous monitoring off.

Errors in sensor values continue to occur with continuous monitoring off. Please indicate the last value or 0 value, not the off value.
Logger: homeassistant
Source: components/sensor/init.py:583
First occurred: 09:44:55 (41 occurrences)
Last logged: 09:52:55
Error doing job: Exception in callback Entity.async_write_ha_state()
Error doing job: Task exception was never retrieved
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/components/sensor/init.py", line 579, in state
numerical_value = int(value)
ValueError: invalid literal for int() with base 10: 'off'
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/usr/local/lib/python3.10/asyncio/events.py", line 80, in _run
self._context.run(self._callback, *self._args)
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 585, in async_write_ha_state
self._async_write_ha_state()
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 649, in _async_write_ha_state
state = self._stringify_state(available)
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 591, in _stringify_state
if (state := self.state) is None:
File "/usr/src/homeassistant/homeassistant/components/sensor/init.py", line 583, in state
raise ValueError(
ValueError: Sensor sensor.seonpunggi_temperature has device class temperature, state class measurement unit °C and suggested precision None thus indicating it has a numeric value; however, it has the non-numeric value: off (<class 'str'>)

Thanks for the report! This ties right into some work I'm already doing for #4 and can be worked on together.

v0.19.0 has been released. It includes one small change to libdyson which will hopefully address your issue.
Unfortunately, I wasn't able to replicate the exact behavior from your logs. Disabling continuous monitoring on my 527K didn't have the same result. So if you continue to see this issue after updating, could you also let me know what model you're using?

@dotvezz After 0.19.0 update, this issue is the same. The model number is Dyson Pure Cool TP04. The device number(?) is 438 on HA device information. The error doesn't occur only when I disable all sensors.

According to a comment by Baloob, the problem is that for normally numeric states, unknown and unavailable should not be used. Instead, the None should be assigned as the native value. This is very likely related to https://github.com/home-assistant/core/pull/87013.

After 0.19.1 update, this issue is the same. Please see the debug logs.
home-assistant_dyson_local_2023-05-08T01-10-01.504Z.log
Logger: homeassistant
Source: components/sensor/init.py:583
First occurred: 10:02:33 (187 occurrences)
Last logged: 10:11:33
Error doing job: Task exception was never retrieved
Error doing job: Exception in callback Entity.async_write_ha_state()
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/components/sensor/init.py", line 579, in state
numerical_value = int(value)
ValueError: invalid literal for int() with base 10: 'off'
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 204, in _handle_refresh_interval
await self._async_refresh(log_failures=True, scheduled=True)
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 349, in _async_refresh
self.async_update_listeners()
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 146, in async_update_listeners
update_callback()
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 406, in _handle_coordinator_update
self.async_write_ha_state()
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 585, in async_write_ha_state
self._async_write_ha_state()
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 649, in _async_write_ha_state
state = self._stringify_state(available)
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 591, in _stringify_state
if (state := self.state) is None:
File "/usr/src/homeassistant/homeassistant/components/sensor/init.py", line 583, in state
raise ValueError(
ValueError: Sensor sensor.seonpunggi_humidity has device class humidity, state class measurement unit % and suggested precision None thus indicating it has a numeric value; however, it has the non-numeric value: off (<class 'str'>)

I think the issues are similar, but not the same :-) The first one reported is the "state class measurement unit °C" and this one is "state class measurement unit %". Hope this helps?

v0.21.0 is released which should resolve this issue! Let me know if you have issues @limitless00net!


Make dialogs more accessible

Via aria attributes and trapping the tab key inside the dialogs
It introduces three options:
    - ariaMainContent e.g. '#main-content'
    - trapTabKey e.g. true
    - focusFirstInput e.g. true

Hi all,
We're using this code in one of our projects and I wanted to get some feedback here as well. Pls let me know if you think this is not a proper approach or if there's any other tweaks you'd like to address? We're looking forward to have this as a built in feature.
I left out the focus "toggle" before opening and after closing the dialogs. Mostly because I'm not sure yet we should do it. Currently it looks something like this:
// before open
focusedElementBeforeModal = jQuery(':focus')

// bind on vexClose with
focusedElementBeforeModal.focus()

Let me know if you think it's a good fit and I can add it here too. The implementation here is pretty much the same as the incredible accessible modal article which was based on some w3c pseudo code.
cheers

I like it! Having to specify the "main content" to hide from screen readers while the modal is open feels like a bit of a chore, though. Perhaps ariaMainContent should default to 'body > :not(.vex)'? That is, by default, everything in the document body outside of the .vex would be receive aria-hidden while the modal is open.

nice yeah I'll update the ariaMainContent default to that thanks!
Would you also accept a fourth config to keep track of the focus outside the vex dialog? Exactly like I mentioned above, before opening the dialog grab the current focused element then give it a focus() back when the dialog closes. I'd name it like giveBackFocus: true. It has been a requirement for us and it seems to be a requirement in general to make the dialog 100% accessible.

Sure, that seems like a sensible option. :+1:

:+1:

:+1: :100: thank you so much, @huoxito

thanks all I've updated the commit, pls give a try when you have a chance

Any plans to get this PR into master? I implemented the same on my own and it would be a lot easier if VEX would support accessibility stuff out of the box. AFAIK there are a couple of other smaller accessibility related PRs like '#134' that could be accumulated into this PR.
Also consider to default focus the 'NO' button on 'YESNO' dialogs and the 'YES' button on 'YES' dialogs.

With the release of vex 3, we've ditched CoffeeScript for vanilla JavaScript, but I love the accessibility upgrades that were made in this PR. @huoxito do you think you could adapt your code for the vanilla JS code in vex 3? We can plan for accessibility upgrades in, say, a future minor version release.
It sounds like there was some support from @adamschwartz in the past. I say we move forward with this, if possible.

@bbatliner yeah absolutely 👍 great to hear it moved to just javascript, I'll try to update this PR or submit a new one later this week


Slasher

In this pr

archive pattern constraints
stop coercing underscores to slashes in archive_path
drop archive_path argument from DataAPI.create

Addresses #168
Archive pattern constraints
List of regex patterns that must match archive_name before archive creation is allowed
Create an archive pattern using manager.set_required_archive_patterns. e.g. require only \w, ., or / characters:
>>> api = get_api()
>>> api.manager.set_required_archive_patterns([r'^[\w\/\.]+$'])

Now, archives that do not match this will not be supported:
>>> api.create('!!!.txt')
Traceback (most recent call last):
...
ValueError: archive name does not match pattern '^[\w\/\.]+$'

Coverage decreased (-0.02%) to 95.933% when pulling 6db5f776e4849b4fc07334761cf767265c1e3155 on slasher into db1e15e64cfa9c398fe9ba1f701435da7d6988af on staging.

Coverage increased (+0.1%) to 96.073% when pulling 9f37707e47de090d2994ce3e52ed953714bd1db1 on slasher into db1e15e64cfa9c398fe9ba1f701435da7d6988af on staging.

Coverage increased (+0.1%) to 96.073% when pulling 989e16aa3af2e4541df22369429da294a3da2629 on slasher into db1e15e64cfa9c398fe9ba1f701435da7d6988af on staging.

Coverage increased (+0.2%) to 96.116% when pulling 9af014d7266daa8fa0ddf5c6dfec46429c6d836b on slasher into db1e15e64cfa9c398fe9ba1f701435da7d6988af on staging.


Some pip packages are not properly detected during import and their attributes instances also

OS: Windows 10 Home
VsCode Stable Version: 1.56.2
Pylance Version : 2021.5.2
vscode Python extension Version : 2021.5.842923320
Python Version : 3.9.1

The first message is intended, it's saying that you aren't using pandas in the code below, so it's grayed out.
What version of numpy are you using? The latest version of numpy should have better type info.

It's version number 1.20.3

Thanks. This is likely covered by #150, then; the next version of numpy enriches its type information to not mark these as "Any" anymore, so we're waiting a bit for upstream there. Closing in favor of that tracking issue.


Can pasta return something else than localhost when it prints the URL?

Title says most. Here's some extra info:
Background/setup:

I run pastad as a service on a Linux VM.
That VM is connected to "the world" via a Cloudflare tunnel and a DNS entry at Cloudflare pointing to that tunnel. The tunnel forwards traffic to the VM.
The readers of pastes therefore reads by accessing the URL where hostname equals the DNS entry.

Whenever I use pasta to send something to the pastebin server, pasta prints an url using localhost as hostname. In order to share the url, I must change the hostname to its publicly known name.
Could this be changed somehow so that pasta prints the external name? Perhaps pastad.conf could have a new attribute, "official hostname" or something similar, and return that name to pasta?

Hey there.
Yes, it should - you can either pass the PASTA_BASEURL environment variable and set it to the hostname (e.g. PASTA_BASEURL=https://my-awesome.pasta) or you can configure this in the pastad.toml file checkout the provided example.
When running from a container (either docker or podman), see the https://github.com/grisu48/pasta#build-docker-image section - the pastad.toml file should be in the data directory.
I think this is what you are searching for?

Hi.
I noticed that PASTA_BASEURL existed and considered using it too. The thing is that the network setup we're using is a bit special. The pastebin server runs on a VM inside a massive "firewall" (Cloudflare/AppGate) with one name for the server. On the other side of the "firewall", the server has another name and all access to that server is controlled by the FW.
What I want to do, is to run the pasta command and have it return the server's external name. The tricky part is that the external name is not accessible from inside the FW. My idea was to use PASTA_BASEURL to name the server's internal name, and 'something else' for the external name. No worries though, I can probably fix this myself and perhaps provide a PR with the changes.
Thanks again for your quick replies, and best of luck with your project!

Hmm, we could introduce host variables, e.g. $hostname that are replaced at startup times. Then you could use something like PASTA_BASEURL = https://$hostname. I never though this is necessary but am not against introducing this logic. If needed I would see it as a nice addition, that goes also with the project philosophy.
Would that resolve your issue?

This issue is solved with https://github.com/grisu48/pasta/pull/52 and documented in https://github.com/grisu48/pasta#macros.
Closing issue but feel free to reopen it, if you consider it not yet done.


Unable to save shortcut on Windows 10

I'm using Windows 10 and during installation of 1.0.2 I got:
Unable to save shortcut "C:\Users\varosi\AppData\Roaming\Microsoft\Windows\Start Menu\Programs\LunaStudio.lnk".
At line:1 char:241
+ ... s\LunaStudio\1.0.2\bin\public\luna-studio\luna-studio.exe';$sc.Save()
+                                                                ~~~~~~~~~~
    + CategoryInfo          : OperationStopped: (:) [], DirectoryNotFoundException
    + FullyQualifiedErrorId : System.IO.DirectoryNotFoundException

Received ExitFailure 1 when running
Shell command: powershell "$s=New-Object -ComObject WScript.Shell; $sc=$s.createShortcut('C:\Users\varosi\AppData\Roaming\Microsoft\Windows\Start Menu\Programs\LunaStudio.lnk');$sc.TargetPath='C:\Program Files\LunaStudio\1.0.2\bin\public\luna-studio\luna-studio.exe';$sc.Save()"

I see that the error was "DirectoryNotFound", could you try to open the directory C:\Users\varosi\AppData\Roaming\Microsoft\Windows\Start Menu\Programs\ and tell which (if any) is missing?

My AppData is installed on the other place. Do you use %APPDATA% environment variable to access Roaming folder?

Thanks for the answer. It is indeed our fault, we are not using %APPDATA% for installing a shortcut.

No problem! Keep the good work!


Add CFP for cilium/cilium#27196

CFP for Performance & Scale Testing CI: cilium/cilium#27196

ping @dlapcevic @alan-kut

Any further comments? otherwise I think we can merge as is and update later if needed

That sounds good @xmulligan :+1:


Parse form data as python dict literal when appropriate

Hi
First of all thanks for your useful tool.
I had an issue by parsing the following curl command:
curl -X POST -d "grant_type=client_credentials" -u "foo:bar" http://localhost/api/oauth/token/

Your tool returns this:
data = 'grant_type=client_credentials'
requests.post('http://localhost/api/oauth/token/', data=data)

First, as mentioned in #24, -u option is not processed.
Second, the data field does not work in requests. To make it work, I had to change the first line for data = {'grant_type':'client_credentials'}.
In conclusion, your tool should have return this:
data = {'grant_type': 'client_credentials'}
user = ('foo', 'bar')
requests.post('http://localhost/api/oauth/token/', data=data, auth=user)

Regards,
Clément
Usefull links:

http://docs.python-requests.org/en/master/user/authentication/
http://docs.python-requests.org/en/master/user/quickstart/#more-complicated-post-requests

It looks like the only different between a string
data = 'grant_type=client_credentials'
and a dict literal
data = {'grant_type': 'client_credentials'}
is that the dict literal magically adds a content-type header.
Content-Type: application/x-www-form-urlencoded
I'm going to add support for dict literals when the input string looks like it's a series of url-style keys and values.

Fixed in 0.0.28 for python.


mgmt, changeanalysis, add live tests

relate to https://github.com/Azure/azure-sdk-for-java/issues/35316
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:

[ ] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

API change check
API changes are not detected in this pull request.

/azp run prepare-pipelines

/azp run java - changeanalysis - mgmt - tests

/azp run java - changeanalysis - mgmt - tests

/azp run java - changeanalysis - mgmt - tests


[TECH ED] Form Controls

Link to the coursework
https://github.com/CodeYourFuture/Module-HTML-CSS/tree/main/Form-Controls
Why are we doing this?
Aims

Interpret requirements
Write a valid form
Style form controls
Test with Devtools
Refactor using Devtools

For this project, you will need to make decisions yourself and explore your own code with Devtools. What blockers will you encounter? How will you get help to solve them? Come to class with questions.
Maximum time in hours
4
How to get help
Share your blockers in your class channel. Use the opportunity to refine your skill in Asking Questions like a developer.
How to submit
Remember from last week's coursework that you should switch to the main branch before creating a new branch.

Fork to your Github account.
Switch to the main branch
Make a branch for this project
Make regular small commits in this branch with clear messages.
When you are ready, open a PR to the CYF repo, following the instructions in the PR template.

There are several projects in this repo. Make a new branch for each project. This might feel challenging at first, so this is a good problem to bring to class to work on in groups with mentors.
How to review

Complete your PR template
Ask for review from a classmate or mentor
Make changes based on their feedback
Review and refactor again next week

Anything else?
There are a couple of useful ideas in this project that you can explore further:

Learning HTML properly. Many web developers skip straight to JavaScript and don't take the time to learn and properly understand HTML or CSS. This can lead them to writing elaborate and pointless JS code to recreate things that exist already in native HTML. These JS components usually don't have as many features as native HTML and often don't work well with other APIs. Many web developers don't really know that there are other APIs interacting with API, not just the DOM.

Properly understanding HTML and the DOM will make you a powerful and unusual web developer.

Refactoring your code every single time. Many developers just add more and more code, especially with CSS, until they have a giant, frightening code mountain that they do not understand and cannot change. But requirements can and do change all the time. So making sure every time you write something you check you need it, and you remove everything you don't need will make your code simple, powerful, precise, and clear.

Finding the simplest thing that can possibly work will make you a powerful and unusual web developer.

Kamino cloned this issue to RbAvci/My-Coursework-Planner


Auto generate documentation

Since ocdev is a very CLI centric tool, it'd be great if we could somehow generate entire CLI documentation and push it on every merge. This takes away the task of manually writing docs, all we will need to do is to put in good descriptions and usages in every command we have with cobra, and we can generate the docs using that.
Cobra lets us generate markdown, man pages, etc, so we could leverage that.
https://github.com/spf13/cobra#generating-documentation-for-your-command

I could not find a flat way to implement this such all the command and nested get printed.
Maybe if we need this, we might have to implement this ourself.
We can use something like -
package cmd

import (
	"github.com/pkg/errors"
	"github.com/spf13/cobra/doc"
)

func GenerateCLIDocs() error {
	if err := doc.GenYamlTree(rootCmd, "/tmp/"); err != nil {
		return errors.Wrap(err, "error generating man from cobra")
	}

	return nil
}

and from the YAML that we get, we can pretty print a flat structure.

This has been implemented to some extent in #27
Now we need to add a travis check that if some PR is modifying the CLI structure, then README.md needs to be updated with the newer structure.
We need to get the CLI Structure section from README.md and parse it in a script


width and height values should be unitless

At least when outputting to HTML, the width and height values should be unitless. HTML forbids units on the value of the width and height attributes of the <img> tag.
I can understand for PDF output wanting to add units. However, even then, the units are assumed to be pixels (just as the input is) and the converter will deal with them appropriately. So I don't we should add units at all.

I will investigate this once #11 is resolved.

I also noticed that you dropped the height attribute. Even though the converters don't use the height, I still think you should pass that information through as it could be useful to another extension or the converter.

OK. I will add them.


Release EIP on destroy

I noticed when I have the following configs enabled, the EIP for the nat gateway is not released upon destroying the vpc.
enable_nat_gateway = true
single_nat_gateway = true
one_nat_gateway_per_az = false

Am I overlooking a configuration? If not, this would be a nice feature to have.

EIP is managed by this module and will be released on the deletion of the NAT gateway.
The problem is probably in something else.

EIP is managed by this module and will be released on the deletion of the NAT gateway.
The problem is probably in something else.


Not tagging py3.x-cuda11.8 images as latest on push to docker hub

Can you add a more descriptive issue comment? Not tagged implies there’s a bug?


404 for the API Reference pages

eg. clic in the left bar on "API Reference / Document Store"
"404 - There's no doc for the page you requested."
Hum, strange, you get the page if you reload, or if you open https://haystack.deepset.ai/reference/document-store
No problems for the other stuff (components, tutorials, etc. Only API reference)
(mac 12.1, safari, chrome, firefox)

problem seems to be solved today


Add qce paper to gh page

Should we add it to the readme as well? Or refer to the papers page in the readme?

Should we add it to the readme as well? Or refer to the papers page in the readme?

I added a link to the "publications" site and also added the paper in the readme


Metadata field not recognized as list

What happened?
The list of values for a key does not appear in table view.
This is the relevant metadata for the file:

This is the row for the same file:

The entry for "Race" does not appear.
What did you expect to happen?
The metadata value in the table view is the same as the one listed in the note.
How can we reproduce it (as minimally and precisely as possible)?
Create a note with a metadata key that has multiple values formatted in a bulleted list.
Anything else we need to know?
Removing the quotes and brackets did not seem to help.
Dataview is able to render the value:

Thank you Marcus :heart:
Plugin version
1.0.1
Obsidian version
1.0.3
OS
Windows

This typically happens when multiple field types are detected for a given property. If so, it sounds like a duplicate of #71.

I think that you are right. Thanks for letting me know!


Fix popup display for wallet ICS on desktop

@keybase/react-hackers

Storyshots were stale, I'm gonna:

push an update to them
merge into master
cherry-pick onto the release branch
kick off desktop release candidate builds


Ensure configuration schema used to decode configuration.

Just because schemas are compatible doesn't mean that they're identical (e.g. up to field ordering).
This is important as schema generation in Java is not always determanistic, so even if the payload is encoded with the exact schema that was previously provided it might not agree when the request comes in.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Thanks. I wasn't able to reliably reproduce the original issue, but I've added a test that should verify it's always correct.

Run Java_Examples_Dataflow PreCommit


InvalidOperationException: The property 'xxx' is part of the object's key information and cannot be modified. On Navigation Property change with Composite Key

Looks like the following issue is not entirely resolved:
http://entityframework.codeplex.com/workitem/2628
When using Identity-Columns with a composite key, the newest version of EF does throw the exception:
The property 'TenantId' is part of the object's key information and cannot be modified.
Sample code that is expected to work:
 public class Customer
    {
        [Key]
        [DatabaseGenerated(DatabaseGeneratedOption.Identity)]
        [Column(Order = 0)]
        public int Id { get; set; }

        [Key]
        [Column(Order = 1)]
        public int TenantId { get; set; }

        public string Name { get; set; }

        public int? OrderId { get; set; }

        public Order Order { get; set; }
    }

 public class Order
    {
        [Key]
        [DatabaseGenerated(DatabaseGeneratedOption.Identity)]
        [Column(Order = 0)]
        public int Id { get; set; }

        [Key]
        [Column(Order = 1)]
        public int TenantId { get; set; }

        public string Name { get; set; }
    }

public class Tenant
    {
        [Key]
        [DatabaseGenerated(DatabaseGeneratedOption.Identity)]
        public int Id { get; set; }

        public string Name { get; set; }
    }

 public class TestContext : DbContext
    {
        public DbSet<Customer> Customers { get; set; }
        public DbSet<Order> Orders { get; set; }
        public DbSet<Tenant> Tenants { get; set; }

        public TestContext() : base("name=TestConnString")
        {

        }

        protected override void OnModelCreating(DbModelBuilder modelBuilder)
        {
            base.OnModelCreating(modelBuilder);

            modelBuilder.Entity<Customer>()
                .HasKey(c => new { c.TenantId, c.Id })
                .HasOptional(x => x.Order)
                .WithMany()
                .HasForeignKey(x => new { x.TenantId, x.OrderId });
        }
    }

 class Program
    {
        static void Main(string[] args)
        {
            using (var db = new TestContext())
            {
                SeedData(db);

                var customer = db.Customers.First();
                customer.Order = new Order { TenantId = 1 };

                // This line throws the exception
                db.ChangeTracker.DetectChanges();

                Console.WriteLine("When reaching this point, everythign worked fine!");
                Console.ReadLine();
            }
        }

        private static void SeedData(TestContext db)
        {
            var tenant = new Tenant {Name = "First Tenant"};
            db.Tenants.Add(tenant);

            db.Customers.Add(new Customer
            {
                Name = "First customer",
                TenantId = 1
            });

            db.SaveChanges();
        }
    }

Here is an updated repo to reproduce the issue:
https://github.com/sschoeb/ef_key_issue_repo

@sschoeb That issue is listed as fixed in 6.2, but we have not released 6.2 yet. We are planning to release a beta very soon now. Once the beta is out, it would be great if you could test with it and check that the issue you are seeing is fixed.

You are right. Does that mean, that the current nigthly (which is used in
the repo I provided) does not yet include the fix?
If it does, it is not fixed, as the repo clearly reproduces the issue.
Arthur Vickers<EMAIL_ADDRESS>schrieb am So., 7. Mai 2017,
22:34:

Closed #261 https://github.com/aspnet/EntityFramework6/issues/261.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/aspnet/EntityFramework6/issues/261#event-1071993770,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACYNAgYQP86ZpQ_6rS7lq82aQ9iquS-4ks5r3irigaJpZM4NON7a
.

@sschoeb We will look into it again. Didn't realize you were using a nightly build.

@sschoeb So the problem here is in the mapping of the FK. This code:
modelBuilder.Entity<Customer>()
                .HasOptional(x => x.Order)
                .WithMany()
                .HasForeignKey(x => new { x.TenantId, x.OrderId });

makes a composite FK with the properties in the order shown--that is TenantId, OrderId. However, the composite PK has these properties in the opposite order, because of the Column(Order = ) annotations. It should be possible to fix this by overriding the order of the PK in the fluent API:
modelBuilder.Entity<Order>()
    .HasKey(c => new { c.TenantId, c.Id });

but it seems that having the column order in the attribute and the order in the fluent API different causes EF to get confused. We will re-triage to decide what to do about this (note--see #110 and #113 as well.)
For now, either changing the order in the attributes:
public class Order
{
    [Key]
    [DatabaseGenerated(DatabaseGeneratedOption.Identity)]
    [Column(Order = 1)]
    public int Id { get; set; }

    [Key]
    [Column(Order = 0)]
    public int TenantId { get; set; }

    public string Name { get; set; }
}

or removing the attributes and using the fluent API:
public class Order
{
    [Key]
    [DatabaseGenerated(DatabaseGeneratedOption.Identity)]
    public int Id { get; set; }

    [Key]
    public int TenantId { get; set; }

    public string Name { get; set; }
}

modelBuilder.Entity<Order>()
    .HasKey(c => new { c.TenantId, c.Id });

should make this work.

EF Team Triage: This issue is not something that our team is planning to address in the EF6.x code base.  This does not mean that we would not consider a community contribution to address this issue.
Moving forwards, our team will be fixing bugs, implementing small improvements, and accepting community contributions to the EF6.x code base. Larger feature work and innovation will happen in the EF Core code base (https://github.com/aspnet/EntityFramework).
Closing an issue in the EF6.x project does not exclude us addressing it in EF Core. In fact, a number of popular feature requests for EF have already been implemented in EF Core (alternate keys, batching in SaveChanges, etc.).
BTW this is a canned response and may have info or details that do not directly apply to this particular issue. While we'd like to spend the time to uniquely address every incoming issue, we get a lot traffic on the EF projects and that is not practical. To ensure we maximize the time we have to work on fixing bugs, implementing new features, etc. we use canned responses for common triage decisions.


Firefix is Error

Hi,
I USE Firefix plug-in Is Error，Error message as shown,Why is that? please handle!!!

Duplicate of https://github.com/chao/RESTClient/issues/229

I don't see is how to solve?How to solve?Before use is good, now have a problem~

You can downgrade to Firefox 45

https://github.com/chao/RESTClient/issues/220#issuecomment-216058456
https://github.com/chao/RESTClient/issues/220#issuecomment-216249317
Wait till a new version of the addon is released
https://github.com/chao/RESTClient/issues/220#issuecomment-216922755
or apply the patch manually – if you know how to modify an firefox addon
https://github.com/chao/RESTClient/commit/cd1425479c84c7c4898ab76486a31bfb578dd1d7

Thank you very much, I know


Delimiter for --custom-labels need to change

changed the delimiter to ; instead of ,

@kyungwan-nam  What is the reason for doing this?

@zhijian-pro
https://github.com/juicedata/juicefs/issues/4611 is the reason why It should be fixed.
Thanks!


Inconsistent names of global bus error suppression bit (bit 2 of ERR_CFG)

Hi all,
I have read spec from the latest commits (https://github.com/riscv-non-isa/iopmp-spec/commit/3369da40e838a163c012c8775261d10a721c36d5 https://github.com/riscv-non-isa/iopmp-spec/commit/7a76c5d4c1c785c202ccbbd745910f01eea65055) and found inconsistent names about global bus error suppression bit (bit 2 of ERR_CFG).
The detail is on following descriptions:
Section 2.7 Error Reactions(chapter2.adoc):

The IOPMP will signal the bus to the presence of a violation but will suppress the bus error if ERR_CFG.re is implemented and set to 1 on a violation.

Regardless of the value on ERR_CFG.rre, IOPMP will indicate a "bus error suppression" when sere on an entry is set to 1.

Section 6.4 Error Capture Registers (chapter5.adoc):

Name of bit 2 in ERRCFG is rs.

Section 6.7 Entry Array Registers (chapter5.adoc):

Description of ENTRY_CFG(i).sere: 0x0: the response by ERR_CFG.rre.
Description of ENTRY_CFG(i).sewe: 0x0: the response by ERR_CFG.rwe.
Description of ENTRY_CFG(i).sexe: 0x0: the response by ERR_CFG.rxe.

Thanks and ack, will fix in next push.


[PDI-19562] 'Delete Files' step does not delete files from Windows mapped drive

@smmribeiro
@bcostahitachivantara
@renato-s

:white_check_mark: Build finished in 19m 15s
Build command:
mvn clean verify -B -e -Daudit -amd -pl engine

:exclamation: No tests found!
:information_source:  This is an automatic message


After Using UWPHook My Controller Not Recognized

Hi...I used UWPHook to import the Forza Horizon 4 game into Steam today and initially everything seemed ok and was working. However...a number of hours later, after shutting down and restarting my pc I tried booting up Forza again but this time my Xbox1 controller was no longer recognized by the game. It only recognizes my keyboard now. How can I reverse whatever UWP may have done?
I've already removed and reinstalled the controller several times and I even uninstalled the Forza game and reinstalled it but the game will not recognize the controller now no matter what I do. The controller works fine in all my other games. Only the game in which I used UWP is no longer recognizing the controller. Please keep in mind that for 2 years now I have never had any issue like this with Forza. The controller has always been recognized within the game.
*Edit - by the way, this issue persists even when starting the game using it's own default shortcut, and NOT the new Steam shortcut
Any ideas?

Although I don't see how UWPHook could have altered your controller functionality, here's how to undo what UWPHook has done:

Open Steam->Library
Right-click on the game in the list of games on the left and choose "Manage"
Left click on "Remove non-Steam game from your library"


Move test utils to separate module. Implements #80

I've just rebased this on master

yes, contenttestpal and contentpal-testing solve two different issues. contentpal-testing is for testing contentpal implementations whereas contentpal-testing is about testing content providers.


Admin interface displays ACL rules from different events

It seems like the new admin interface will sometimes show ACL rules from different events. This can easily lead to accidents where a user overwrites the ACL set with an incorrect set of rules.
https://github.com/opencast/opencast-admin-interface/assets/1008395/85b96839-29c6-4185-a899-fb15b2280df9

This bug still exists.


Minor useless cleanups

I'm just starting to read through the code (because I think this is pretty awesome) and doing some cleanups as I go, really just so I understand what's going on.  Feel free to reject this or take only some of it, but maybe as I get farther in I'll be able to add something actually useful at some point.
If there're specific parts you'd like someone to look at let me know.

Dylan, thanks for all of these suggestions; I really appreciate the review and your interest.
There are a few main places that I think need attention right now... one is reading and writing the database file, and the other is the network connection management.
Obviously database reading mostly works, but it could use a performance boost. My thought is probably to use attoparsec possibly in conjunction with pipes, but maybe you have a better idea.
The functions needed for database writing are there and actually work, but I was hung up for a long while on a GHC bug that caused a deadlock after forking the process. Although that seems to be fixed as of GHC 7.8.4, the main thing I need to figure out now is how to schedule database writes to happen on a recurring basis but also allow them to be triggered manually via the dump_database() MOO built-in and when the server shuts down.
As for network handling... I still need to write the implementation for open_network_connection(), and rework some (or a lot) of the dispatch code in order to support the hold-input connection option. There's also some interaction to fix between read() and out-of-band data, and missing support for $server_options.connect_timeout.
While there are also a few other things, I think these are the main things needed before a preliminary 1.0 release would seem feasible.
Thanks again for your interest!


Delete skip and xfail tests related to route removal

User Story - Business Need
Delete 'xfail' and 'skip' tests ONLY related to route removal.

[x] Ticket is understood, and QA has been contacted (if the ticket has a QA label).

User Story(ies)
As a    VA notify engineer,
I want  delete 'skip and 'xfail' tests related to route removal
So that that when I work on the code, I will not have to update tests for code that will eventually be removed.
Additional Info and Resources

Not every 'xfail' and 'skip' is related to route removal. See reason in 'skip' or 'xfail' tests.
Ask team: What should we do with 'xfail' and 'skip' NOT related to route removal? Example tests.app.v2.notifications.test_post_notifications line 1376 @pytest.mark.skip(reason='failing in pipeline for some reason') Do we create a ticket for this?
Reference to spreadsheet for route removal

some queries to search on, there may be others:

Engineering Checklist

[ ] All 'skip' tests related to route removal are deleted
[ ] All 'xfail' tests related to route removal are deleted
[ ]  Document a list of 'skip' or 'xfail' tests that are not clear if related to route removal

[ ]  Chat with team to determine best approach: e.g. group into 1 ticket, create multiple, etc.
[ ]  Create relevant new tickets

Acceptance Criteria

There are no 'skip' or 'xfail' tests related to route removal.

Out of Scope

Removing any 'skip' and 'xfail' tests are NOT related to route removal.
DO NOT refactor tests, only removal.

Comment from Dave: There are many skipped/xfailed tests.  It will be large as a number of lines deleted but not large in terms of time.  It is a straight-forward deletion.

Hey team! Please add your planning poker estimate with Zenhub @cris-oddball @EvanParish @k-macmillan @kalbfled @ldraney @mchlwellman @MackHalliday

@k-macmillan @mjones-oddball Here are a few skip or xfail reasons that seem like good candidates for deletion even though "removal" is not explicitly declared:

Failing after Flask upgrade.  Not fixed because not used.
Letter functionality is not used.  Decline to fix.
Not in use
Letter feature

The queries in the description include tests associated with #1631, but that ticket's engineering checklist includes deleting those tests.  I think we should do it for that ticket rather than this one.

Status of tests:

Parallel: 2848 passed, 26 skipped, 2 xfailed
Serial: 139 passed, 3 skipped, 2876 deselected, 13 xfailed

@mjones-oddball @npmartin-oddball Kyle discovered that some of the tests annotated as being for "route will be removed" in fact are not for routes that will be removed, or the tests also test other code.  Ergo, Mack and I are going to have to take a second pass through our deletions and audit every deleted test against the route removal spreadsheet in addition to reading through the test to understand exactly what code is tested.
I suggest this ticket should be repointed at least as a 5; maybe 8.

Could have been/should have been between 5 and 8, given complexity, team member involvement, etc.

Pending Kyle and David reviewing https://docs.google.com/spreadsheets/d/1qKlRb_nNfK1nsgvz-dJgbpspJUntVH5cxOs2J4luHAA/edit#gid=533952151
Asked David to review any tests labeled as unsure (53, 7 files). Kyle double checking.

Created ticket for test identified as mislabelled but failing
https://app.zenhub.com/workspaces/va-notify-620d21369d810a00146ed9c8/issues/gh/department-of-veterans-affairs/vanotify-team/1258


async extraction

I probably won't work on this in the near future. In the meantime, you easily wrap the extraction in async-std::task::spawn or tokio::spawn, which is what i would do in this crate anyways.


Don't include host in static file paths.

Closes https://github.com/facebookresearch/visdom/issues/411.
The line originally setting include_host = True was in the initial commit, so I have no idea what its purpose was.

Ah this decision predated me - @lvdmaaten do you know why include host was set?

Pulling in to test internally


Return codes are different when calling sfdx force:create:org using Windows sfdx cli and the npm installed sfdx cli

Summary
Return codes from the "sfdx force:org:create" command differ if performed using the Windows SFDX CLI (see instructions Install the CLI on Windows) versus the npm equivalent set up using the Install the CLI with npm instructions. The Windows SFDX CLI will return 1 once the command has completed and the NPM equivalent will return 0. Both will create the org as expected however the Windows SFDX CLI version causes our setup script to exit.
Steps To Reproduce:
For each of Windows SFDX CLI and NPM SFDX CLI perform the following ensuring that your path is picking up the correct version of sfdx each time:

Inside a known good project run: sfdx force:org:create --setalias test1 --definitionfile config/project-scratch-def.json --durationdays 1 --wait 10
The scratch org should have been created successfully
Once this has finished run: echo $?

Expected result
Both Windows SFDX CLI and NPM SFDX CLI should exit with a return code of 0
Actual result
Windows SFDX CLI exits with a return code of 1
System Information
sfdx version --verbose --json
{
"cliVersion": "sfdx-cli/7.155.1",
"architecture": "win32-x64",
"nodeVersion": "node-v16.15.1",
"pluginVersions": [
"@oclif/plugin-autocomplete 0.3.0 (core)",
"@oclif/plugin-commands 1.3.0 (core)",
"@oclif/plugin-help 3.3.1 (core)",
"@oclif/plugin-not-found 1.2.6 (core)",
"@oclif/plugin-plugins 1.10.11 (core)",
"@oclif/plugin-update 1.5.0 (core)",
"@oclif/plugin-warn-if-update-available 1.7.3 (core)",
"@oclif/plugin-which 1.0.4 (core)",
"@salesforce/sfdx-plugin-lwc-test 0.1.7 (core)",
"alias 2.0.1 (core)",
"apex 0.13.0 (core)",
"auth 2.1.0 (core)",
"community 2.0.0 (core)",
"config 1.4.12 (core)",
"custom-metadata 2.0.0 (core)",
"data 2.0.3 (core)",
"generator 2.0.1 (core)",
"info 2.0.1 (core)",
"limits 2.0.1 (core)",
"org 1.13.2 (core)",
"salesforce-alm 54.5.1 (core)",
"schema 2.1.1 (core)",
"sfdx-cli 7.155.1 (core)",
"signups 1.1.2 (core)",
"source 1.10.2 (core)",
"telemetry 2.0.0 (core)",
"templates 54.8.0 (core)",
"trust 2.0.0 (core)",
"user 2.0.2 (core)"
],
"osVersion": "Windows_NT 10.0.19044"
}

Hi @waterfif, which shell or terminal are you using?
The fact that you state to use echo $? makes me think you might be using git bash or WSL? If so, we don't support either of those, unfortunately.
I just tried and can't reproduce this on Powershell or cmd.exe.
npm version:

installer version:

Hi RodEsp,
Thanks for the response. You are correct, I'm using Git Bash locally. The script we use to setup scratch orgs on our Ubuntu CI environment is also used to setup our scratch orgs locally hence the use of Git Bash on Windows. I'll close the ticket as Git Bash is not supported.


Epic: missing things in the proxy's pg protocol implementation

Motivation
Proxy should support most (if not all) features of postgres' protocol (libpq).
DoD

[ ] Pass the test suite https://github.com/jackc/pgx

Tasks

[ ] https://github.com/neondatabase/neon/issues/1287
[ ] https://github.com/neondatabase/neon/issues/2752

This is nothing new, but the structure of this epic makes more sense.

Do we have the list of these features?

I'd say this epic is the list. For the time being we have 2 tasks (per bug reports) and a DoD. Should we notice another protocol-related complaint, it ought to end up here.


revised notebook for azp

@jGaboardi Could you please leave "merging commit" to me after approving the change next time? I recently checked the contributor board (https://github.com/pysal/spopt/graphs/contributors) and found I only had 11 commits and added 50 lines of code. I just realized that all of these credits will be account on the person who merges the commit. Thanks :)


[jsonschema]  Rethink how jsonschema deals with encoding internally

This issue is strongly linked to #35.
There are a couple of issues with the current implementation of the jsonschema package:

Encoding for different Validator types is all done by one big switch-case in one function. This has a extensability and readability problem.
The encoder function is "hard-coded" to add commas in the correct places, which has proven error prone, e.g. when using nil validators, as showed in #50. Sidenote: For the specific example, it still need to be discussed weather nil validators for a field is and/or should be accepted by the restlayer API or not, but as I pointed out in #50, there are real use-cases where it would be useful to accept it.
The interface for end-users to implement for their own custom Validator implementations proposed in #35, currently proposing to "mirror" the current internal behavior, require the end-user to serialize a partial JSON object (i.e. exluding the {, }), and correctly deal with commas and white-space.

I propose having a look at how to better implement a more easy-to-use interface for #35, and then use the same interface internally. I also propose to split the validator encoder function, so that there is one encoder type and/or function per supported validaor type. Each of these encoders will get a separate file, mirroring the layout of the schema package.
I am happy coming up with a proposal/PR as I get time to think deeper about it and try out some code..

I think this is worth attempting. I just took a look at https://golang.org/src/encoding/json/encode.go and it's pretty much switch statements and writing to buffers, but if you can make the code less error prone that's a worth goal. Writing serializers and deserializers tends to be a low level and messy business.

and it's pretty much switch statements and writing to buffers
Yeah, but they also have a separate type for each encoder (intEncoder, uintEncoder etc.). See  https://golang.org/src/encoding/json/encode.go#L391.

Writing serializers and deserializers tends to be a low level and messy business.
I have actually written a binary one, and yes I agree. The biggest question is which solution to go with... I have three (new) proposals that I have added to #35, as I am thinking about using the same interface externally (public) as we use internally.

Each have some advantages and disadvantages.

FYI, I now have a working plan on this, which involves 3 steps.
First of all, I will create some micro-benchmarks for the jsonschema package, and add this as a separate PR.
Secondly, I will clean up the code by splitting the encoder into separate files with one encoder per supported type, mirroring the layout of the schema package. The encoder logic itself will be more or less exactly the same as it is now, except the encoder-logic for each type will move into a separate function. This will be the second PR. Most likely, I will pass in an io.Writer rather than an errWriter to each encoder.
Thirdly, I really want to try out solution 2 from #35, which involves getting rid of all the JSON encoder logic altogether, and simply deal with map[string]interface{} internally, and only use the standard-library JSON encoder. This would be in line with how API payloads are serialized/deserialized. From the discussion in #35, this proposal does not necessarily have any buy-in yet, so this PR might be rejected. However, if writing serializers and deserializers are messy and low level, surely avoiding it altogether would make for a more robust, although worse performing, solution. Dealing with maps, also holds the door open for end-users to implement other encodings  (e.g. YAML) to be used for JSON Schema / Swagger, similar to how the rest package today allows for a custom ResponseSender.

One thought I have about the performance is that it would be fairly easy to memoize the output after a single run so we trade memory for speed and amortize the cost. Right now these things run fairly infrequently for me and are mostly informational so the performance isn't a huge concern.

Yes, I agree to that @yanfali. The performance of JSON Schema generation probably hardly matters to anyone.

I guess that really means that the micro benchmarks (step 1), aren't really going to be necessary. I will add some anyway, as I am quite interested in seeing the difference in performance / number of allocations between the two approaches on a general basis, even though encoding performance isn't critical here.

@smyrman I agree with the benchmarks though. I would like to know how much slower it is than a hand coded version.

OK, the code for a map[string]interface{} based encoding in JSONSchema is ready, and so are the benchmark results. I will wait with the PR unitl #70  is merged, but you may pre-inspect the code here.
I think the code is really much cleaner, but a bit slower, especially for tiny schemas. Compared to #70, here are the benchmark results from my machine:
benchmark                                                    old ns/op     new ns/op     delta
BenchmarkEncoder/Schema={Fields:{"b":Bool{}}}                1318          5405          +310.09%
BenchmarkEncoder/Schema={Fields:{"s":String{}}}              1249          5270          +321.94%
BenchmarkEncoder/Schema={Fields:{"s":String{MaxLen:42}}}     1550          6063          +291.16%
BenchmarkEncoder/Schema=Student                              9797          20723         +111.52%

benchmark                                                    old allocs     new allocs     delta
BenchmarkEncoder/Schema={Fields:{"b":Bool{}}}                14             40             +185.71%
BenchmarkEncoder/Schema={Fields:{"s":String{}}}              14             40             +185.71%
BenchmarkEncoder/Schema={Fields:{"s":String{MaxLen:42}}}     16             44             +175.00%
BenchmarkEncoder/Schema=Student                              59             136            +130.51%

benchmark                                                    old bytes     new bytes     delta
BenchmarkEncoder/Schema={Fields:{"b":Bool{}}}                496           2225          +348.59%
BenchmarkEncoder/Schema={Fields:{"s":String{}}}              480           2225          +363.54%
BenchmarkEncoder/Schema={Fields:{"s":String{MaxLen:42}}}     504           2344          +365.08%
BenchmarkEncoder/Schema=Student                              2528          7033          +178.20%

Machine details:

    Hardware Overview:

      Model Name: MacBook Pro
      Model Identifier: MacBookPro11,1
      Processor Name: Intel Core i5
      Processor Speed: 2.6 GHz
      Number of Processors: 1
      Total Number of Cores: 2
      L2 Cache (per Core): 256 KB
      L3 Cache: 3 MB
      Memory: 8 GB

Commands to reproduce:
``bash
$ git checkout ... # old code
$ go test -run=NONE -bench=. -benchmem -cpu 1 > 1.txt
$ git checkout ... # new code
$ go test -run=NONE -bench=. -benchmem -cpu 1 > 2.txt
$ benchcmp 1.txt 2.txt

Not near a good internet connection, but it would be good to see what the
impact is on a more substantial schema. small schemas encode and decode so
fast it's probably not a big deal. How about an array containing an object
containing an array containing a different object. Each object should have
at least 6 fields. Realistic ones are probably ints, strings and time
objects. When I get back to civilization I can come up with a better
example.  Thanks
On Fri, Dec 23, 2016 at 1:35 PM Sindre Røkenes Myren <
<EMAIL_ADDRESS>wrote:

OK, the code for a map[string]interface{} based encoding in JSONSchema is
ready, and so are the benchmark results. I will wait with the PR unitl #70
https://github.com/rs/rest-layer/pull/70 is merged, but you may
pre-inspect the code here
https://github.com/smyrman/rest-layer/tree/jsonschema-map-encode.
I think the code is really much cleaner, but a bit slower, especially for
tiny schemas. Compared to #70 https://github.com/rs/rest-layer/pull/70,
here are the benchmark results from my machine:
benchmark                                                    old ns/op     new ns/op     delta
BenchmarkEncoder/Schema={Fields:{"b":Bool{}}}                1318          5405          +310.09%
BenchmarkEncoder/Schema={Fields:{"s":String{}}}              1249          5270          +321.94%
BenchmarkEncoder/Schema={Fields:{"s":String{MaxLen:42}}}     1550          6063          +291.16%
BenchmarkEncoder/Schema=Student                              9797          20723         +111.52%
benchmark                                                    old allocs     new allocs     delta
BenchmarkEncoder/Schema={Fields:{"b":Bool{}}}                14             40             +185.71%
BenchmarkEncoder/Schema={Fields:{"s":String{}}}              14             40             +185.71%
BenchmarkEncoder/Schema={Fields:{"s":String{MaxLen:42}}}     16             44             +175.00%
BenchmarkEncoder/Schema=Student                              59             136            +130.51%
benchmark                                                    old bytes     new bytes     delta
BenchmarkEncoder/Schema={Fields:{"b":Bool{}}}                496           2225          +348.59%
BenchmarkEncoder/Schema={Fields:{"s":String{}}}              480           2225          +363.54%
BenchmarkEncoder/Schema={Fields:{"s":String{MaxLen:42}}}     504           2344          +365.08%
BenchmarkEncoder/Schema=Student                              2528          7033          +178.20%
Machine details:
Hardware Overview:

  Model Name: MacBook Pro
  Model Identifier: MacBookPro11,1
  Processor Name: Intel Core i5
  Processor Speed: 2.6 GHz
  Number of Processors: 1
  Total Number of Cores: 2
  L2 Cache (per Core): 256 KB
  L3 Cache: 3 MB
  Memory: 8 GB

Commands to reproduce:
``bash
$ git checkout ... # old code
$ go test -run=NONE -bench=. -benchmem -cpu 1 > 1.txt
$ git checkout ... # new code
$ go test -run=NONE -bench=. -benchmem -cpu 1 > 2.txt
$ benchcmp 1.txt 2.txt
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/rs/rest-layer/issues/51#issuecomment-269048079, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACK5U4mMSaSEmOs7f5Qzuep7s1kiHcGlks5rLD6FgaJpZM4LBSe2
.

The most representable one atm. is probably the "Schema=Student" test, which is a small schema, but not a tiny one. It is a bit more than twice as slow with ~20ms v.s. ~10ms before. The tiny examples are more than 4x slower. If I were to guess, I would say there is probably a 3ms added overhead with this solution and a ~2x slowdown.
I think for the case of API documentation, this is acceptable. But if it was for the main payload transferred by the API, it probably would not be.

How about an array containing an object containing an array containing a different object. Each object should have at least 6 fields.

Yeah, you can do so if you like. I don't know how much the nesting matters, as also fields get their own maps, so I am guessing it might perform similar to a flat schema with 10+ fields. Probably a bit slower since the map allocated for a Schema is larger than the one allocated for fields.

Can we close this issue now?

Yes


Allow to specify max tweets import from the UI

Fixes #2467

Frontend tests were OK :+1: (details)

Frontend tests were OK :+1: (details)

Frontend tests were OK :+1: (details)

Frontend tests were OK :+1: (details)

Frontend tests were OK :+1: (details)

Frontend tests were OK :+1: (details)

@rafatower CR please

:+1:


Reduce ignored rubocop offenses

Is your feature request related to a problem? Please describe.
Currently (as of #652), the .rubocop_todo.yml settings are ignoring/excluding 6875 rubocop cop offenses. While many of these may be relatively harmless code layout or style conformance issues, some of the offenses may be indicators of existing bugs within the code base.
Describe the solution you'd like
The ignored offenses should be resolved/fixed, and the .rubocop_todo.yml settings updated appropriately, to reduce the number of ignored offenses as much as is feasible.
Describe alternatives you've considered
You could continue to ignore the currently-ignored offenses.
Additional context
The rubocop scripts, dependencies, and settings were recently fixed (see #650, #651). Prior to those PRs, it seems that rubocop had not been used/maintained (for an undetermined period of time). Many of the currently-ignored offenses are likely the result of code changes made during and/or prior to this period when rubocop was unused/unusable (see #648).
Also, some of the current cop offenses are from optional and/or newer cops which were only recently enabled (see #650, #651) for this project. So those cops had never been applied to this code base until recently.
Rubocop stats
As of #652, there are:

920 Layout/LineLength offenses

187 files inspected, 920 offenses detected, 513 offenses auto-correctable

6875 total offenses

187 files inspected, 6875 offenses detected, 1992 offenses auto-correctable

% rubocop --regenerate-todo
Phase 1 of 2: run Layout/LineLength cop
Inspecting 187 files
.C...CCCC..C...CCC..CC.....CCC.C.C.CCCCCCCCCCCC.CCCCCCC.CC.C.CCCCCC....C.C.CCCC.CCCCCCCCCCC.CCCCCCCCCCCCC.CC.C.C..............C.CCC.CC.C...CC.CCC..C..CCC.CCCCC....CCCCCCC.CCCCCCCCCCCCCCCC

187 files inspected, 920 offenses detected, 513 offenses auto-correctable
Created .rubocop_todo.yml.
Phase 2 of 2: run all cops
Inspecting 187 files
CCC.CWCCWCCCCCCCCCCCCCCCCCCCCCCCCWCCCCWCWCWCCCW.CWCCCCCCCCCCCCCCCCCCCCCCCWCCWCWCCCCWCWCCWWWWCCCWCCCCWWWWWWWCCWCCCCCCCCCCCCCCWCCCWWWCWWCWCCCCCCWCCWCWCWWWWWWWCCCCCWCCCWWCCCCWCCWCCCCCWCCCCCC

187 files inspected, 6875 offenses detected, 1992 offenses auto-correctable
Created .rubocop_todo.yml.

FYI: I have fixes for some of these offenses ready to submit as soon as #651 gets merged.

This issue was marked as Stale because it has been open for 21 days without any activity. If no activity takes place in the coming 7 days it will automatically be close. To prevent this from happening remove the Stale label or comment below.

Not stale. The PR for this (#658) was previously blocked (on #651) until this morning.

PR has been merged.


CARTO Builder activated notification always shown in account/profile pages

That notification is always shown in account/profile pages (but not in the dashboard), even though it has been marked as read:
dashboardNotifications = Object { builder_activated: true }
The problem is that, in this case frontend is checking for dashboard_notifications. There is a mix of both styles in both frontend and backend, but it's not always right.
I'd encourage to standardize in a single style, because it's crazy otherwise.
cc @ramiroaznar

As @javitonino explained, the problem was misspelled variable names among front & back.
In both cases dashboardNotifications has to be renamed to dashboard_notifications (at /cartodb/app/views/admin/users/account.html.erb and /cartodb/app/views/admin/users/profile.html.erb)
We should have a look at other similar pages for consistency on variable naming and to avoid this kind of errors.

This seems to be the same issue as https://github.com/CartoDB/cartodb/issues/12091

In production! 🚀

It looks like this is still being displayed. @ramiroaznar just reported it:

@ramiroaznar perhaps someone from the RT can look into the code to see how this is currently working so that we can decide wether to keep in some cases or remote it forever and ever.

@rjimenezda any update on this issue? Should we take it out of the RT kanban?

I've just checked this and the notification is shown in Builder, Dataset, Account, Profile, and API Keys page.
The notification has the same conditions in every page to be shown. It is checked that:

CARTO is hosted in carto.com
Has builder enabled
show_builder_activated_message variable is true in user
There are no dashboard notifications

Here's the code snippet of one of the pages:
https://github.com/CartoDB/cartodb/blob/e0f947ed2ebc9e71417324f18bbff3607cc9817e/lib/assets/javascripts/dashboard/api-keys.js#L114-L128
Seems like the condition is the same for all pages. We can close this issue and open a new one if we want to remove that notification.

Let's 🔥🔥🔥 the notification!

Let's firefirefire the notification!

Please, if you do that, also remove the code from backend (the show_builder_activated_message part)

Fired, merged and deployed! 🔥

Great @jesusbotella!


Update frontend dependencies

This updates the frontend dependencies to the latest versions. It also allows building with node 19 instead of the increasingly archaic node 12-16.
Vue and Vuetify were not updated to their new respective major versions, as a Vue 3 migration is a rather large task. It would be worth it though, as Vue 3 introduced quite a few new concepts that would clean up parts of this codebase considerably.
The CI now takes twice as long though, as it builds a module and a legacy bundle. I guess we could disable one or we just live with it.

Thanks!

I guess we could disable one

Yes, I think we should do that if it's trivial. Is this the relevant stats https://caniuse.com/es6-module? I could live with that.

I switched the browserlist to the default settings (> 0.5%, last 2 versions, Firefox ESR, not dead). It seems to only target browsers using ES modules and therefore omits the legacy build.
That looks reasonable enough IMHO and they hopefully tweak those criteria when needed.

Nice! I didn't even know about that file... :)


Remove use of idivf

This exists only for historical reasons and adds significant cruft to implementations. (default_idivf="auto" is poorly defined and not evenly implemented in the toolkit, partially because it's confusing and partially because it doesn't add any useful behavior.) There's no obvious reason why implementations outside of Amber need to use this behavior - one can just use the force constant they mean to use.
With proper torsions, these are always explicitly set to 1 in our existing force fields, calling into question why idivf even exists.
With improper torsions, the use of trefoils nearly forces the value of 3, but this might as well be encoded as an implementation detail (how could it meaningfully be another value?)
In either case, if somebody wants to use an arbitrary float (imagine default_idivf="7.5") they could just modify the actual k values throughout. It is difficult to imagine, without historical influence of other software, what purpose this serves.

Upon some thought, I think the only value in keeping idivf around is for the possibility of using auto for ProperTorsions (assuming the interpretation of ProperTorsion's auto that means different OpenMM parameters could be applied for the same SMIRNOFF FF parameter depending on the number of unique 4-atom paths through the central bond)
So knowing that this might be a useful research direction in the future and that spec changes are a pain, I'm kinda in favor of leaving auto in the spec for ProperTorsions but clarifying its meaning, and leaving it unimplemented in the Toolkit until we actually see organizational value in pursuing that research.
I'm unable to think of a useful meaning of auto for ImproperTorsions. In our current definition, it seems like auto would always evaluate to 3.


feat: add new qc

Thanks! Can you remove "Precipitation" and "Precipitation 24hr prior to monitoring event amount"? Otherwise good to go!


ssss

Pre-requisites

[ ] Prior to submitting documentation, please apply to join the GitHub Technology Partner Program: partner.github.com/apply. Please feel free to proceed once your application is approved.

What information would you like to add to docs.github.com?

Tasks
Please be sure to complete each of the following:
Third-party product documentation:

[ ] MUST follow our general contributing guidelines for voice and markup format.
[ ] MUST emphasize how the third-party product works with GitHub.
[ ] MUST be written in Markdown format, using one of the templates provided
[ ] MUST include the name and URL of the GitHub technology partner responsible for maintenance of the documentation being contributed. This should be added via the contributor.name and contributor.URL properties in the template's YAML frontmatter.
[ ] MUST be proposed via a pull request to this repo following the GitHub Flow.
[ ] MUST be located in the root of the content folder. Your filename MUST match the GitHub technology partner name, and use the .md file extension.

The Pull Request:

[ ] MUST reference this issue, e.g. via closes #<this issue number>
[ ] MUST pass the automated CI checks
[ ] MUST include links to supporting material demonstrating the functionality being documented (this can be a link to a public GitHub repo, or a video / screencast walkthrough)

Once all tasks are completed, please mention @github/docs-content for next steps.
/cc @github/partner-engineering for :eyes:

Thanks
On Tue, 8 Jun 2021 at 12:17 PM Parisaa806 @.***> wrote:

Pre-requisites

Prior to submitting documentation, please apply to join the GitHub
Technology Partner Program: partner.github.com/apply
https://partner.github.com/apply?partnershipType=Technology+Partner.
Please feel free to proceed once your application is approved.

What information would you like to add to docs.github.com? Tasks
Please be sure to complete each of the following:
Third-party product documentation:

MUST follow our general contributing guidelines
http://CONTRIBUTING.md for voice and markup format.
MUST emphasize how the third-party product works with GitHub.
MUST be written in Markdown format, using one of the templates
provided http://contributing/github-partners/README.md#templates
MUST include the name and URL of the GitHub technology partner
responsible for maintenance of the documentation being contributed. This
should be added via the contributor.name and contributor.URL
properties in the template's YAML frontmatter.
MUST be proposed via a pull request to this repo following the
GitHub Flow https://guides.github.com/introduction/flow/.
MUST be located in the root of the content folder http://content.
Your filename MUST match the GitHub technology partner name, and use the
.md file extension.

The Pull Request:

MUST reference this issue, e.g. via closes #
MUST pass the automated CI checks
MUST include links to supporting material demonstrating the
functionality being documented (this can be a link to a public GitHub repo,
or a video / screencast walkthrough)

Once all tasks are completed, please mention @github/docs-content for
next steps.
/cc @github/partner-engineering for 👀
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/github/docs/issues/7172, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUEDMN3GJ5MZJ6RMSKDIAD3TRW72DANCNFSM46JHP4CA
.

--
Ihsan Kapahi


Range bar value not starts from tickStart

I have set tickStart = 0 and tickEnd = 100000 , When i try to set pin back to its starting position i.e 0 it does not set to 0

Please explain this with screenshot or gif

probably fixed in #137


Fix typo in TableView

@awildturtok Thanks for merging. When are the changes merged back into develop (+ who takes care?)


Fix pinot-common code styling

Description
Fix pinot-common code styling per https://github.com/apache/pinot/issues/7309
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)

[ ] Yes (Please label as backward-incompat, and complete the section below on Release Notes)

Does this PR fix a zero-downtime upgrade introduced earlier?

[ ] Yes (Please label this as backward-incompat, and complete the section below on Release Notes)

Does this PR otherwise need attention when creating release notes? Things to consider:

New configuration options
Deprecation of configurations
Signature changes to public methods/interfaces
New plugins added or old plugins removed

[ ] Yes (Please label this PR as release-notes and complete the section on Release Notes)

Release Notes

Documentation

Codecov Report

Merging #7311 (bd64818) into master (12e5bcd) will decrease coverage by 2.32%.
The diff coverage is 47.93%.

:exclamation: Current head bd64818 differs from pull request most recent head aa7575f. Consider uploading reports for the commit aa7575f to get more accurate results

@@             Coverage Diff              @@
##             master    #7311      +/-   ##
============================================
- Coverage     71.32%   69.00%   -2.33%
+ Complexity     3367     3191     -176
============================================
  Files          1503     1110     -393
  Lines         74030    52148   -21882
  Branches      10718     7793    -2925
============================================
- Hits          52803    35984   -16819
+ Misses        17622    13581    -4041
+ Partials       3605     2583    -1022

Flag
Coverage Δ

integration1
?

integration2
?

unittests1
69.00% <47.93%> (-0.02%)
:arrow_down:

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

.../pinot/common/function/DateTimePatternHandler.java
100.00% <ø> (+16.66%)
:arrow_up:

...rg/apache/pinot/common/function/DateTimeUtils.java
81.81% <0.00%> (+1.81%)
:arrow_up:

...ot/common/function/FunctionDefinitionRegistry.java
100.00% <ø> (+11.11%)
:arrow_up:

...inot/common/function/scalar/DateTimeFunctions.java
98.61% <ø> (ø)

...he/pinot/common/function/scalar/HashFunctions.java
100.00% <ø> (ø)

.../org/apache/pinot/common/lineage/LineageEntry.java
61.11% <0.00%> (-3.60%)
:arrow_down:

...not/common/lineage/SegmentLineageAccessHelper.java
0.00% <ø> (-46.67%)
:arrow_down:

...ot/common/messages/RoutingTableRebuildMessage.java
0.00% <ø> (ø)

...not/common/metadata/segment/SegmentZKMetadata.java
43.03% <0.00%> (-27.71%)
:arrow_down:

...g/apache/pinot/common/metrics/AbstractMetrics.java
38.50% <ø> (-44.73%)
:arrow_down:

... and 709 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12e5bcd...aa7575f. Read the comment docs.

Codecov Report

Merging #7311 (270391a) into master (12e5bcd) will decrease coverage by 2.32%.
The diff coverage is 47.93%.

:exclamation: Current head 270391a differs from pull request most recent head 9912df9. Consider uploading reports for the commit 9912df9 to get more accurate results

@@             Coverage Diff              @@
##             master    #7311      +/-   ##
============================================
- Coverage     71.32%   69.00%   -2.33%
+ Complexity     3367     3191     -176
============================================
  Files          1503     1110     -393
  Lines         74030    52162   -21868
  Branches      10718     7793    -2925
============================================
- Hits          52803    35992   -16811
+ Misses        17622    13590    -4032
+ Partials       3605     2580    -1025

Flag
Coverage Δ

integration1
?

integration2
?

unittests1
69.00% <47.93%> (-0.03%)
:arrow_down:

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

.../pinot/common/function/DateTimePatternHandler.java
100.00% <ø> (+16.66%)
:arrow_up:

...rg/apache/pinot/common/function/DateTimeUtils.java
81.81% <0.00%> (+1.81%)
:arrow_up:

...ot/common/function/FunctionDefinitionRegistry.java
100.00% <ø> (+11.11%)
:arrow_up:

...inot/common/function/scalar/DateTimeFunctions.java
98.61% <ø> (ø)

...he/pinot/common/function/scalar/HashFunctions.java
100.00% <ø> (ø)

.../org/apache/pinot/common/lineage/LineageEntry.java
61.11% <0.00%> (-3.60%)
:arrow_down:

...not/common/lineage/SegmentLineageAccessHelper.java
0.00% <ø> (-46.67%)
:arrow_down:

...ot/common/messages/RoutingTableRebuildMessage.java
0.00% <ø> (ø)

...not/common/metadata/segment/SegmentZKMetadata.java
43.03% <0.00%> (-27.71%)
:arrow_down:

...g/apache/pinot/common/metrics/AbstractMetrics.java
38.50% <ø> (-44.73%)
:arrow_down:

... and 709 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12e5bcd...9912df9. Read the comment docs.

We should also enable the check style in the pom file for pinot-common


Using webcam as source

Is it possible to use web cam as source? It is possible in deepstream-yolo by changing a config file for deepstream-app as V4L2 CAMERA.. but I didt find this posibility in this project.

do you solve this problem now?


Removed Deprecation of Qiskit Jupyter Tools

Summary
Removed deprecated qiskit jupyter notebook tools
Details and comments

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.09%) to 87.683%

Totals

Change from base Build<PHONE_NUMBER>:
0.09%

Covered Lines:
59672

Relevant Lines:
68054

💛  - Coveralls

Ah, I think this has been superseded by: https://github.com/Qiskit/qiskit/pull/11513 which removes all of qiskit.tools.jupyter.

For what it's worth, the removal was well done, Matthew was just a bit faster :) I'll close given that the changes were already included in https://github.com/Qiskit/qiskit/pull/11513.


Syntax highlighting not available until file is refreshed

Type: Feature Request
Description
When opening a C# project with Visual Studio Code and opening one of the source code files within a short amount of time, correct syntax highlighting will not be available.
Once the project/solution is done configuring, any refresh of the file (for examples scrolling or switching to another file and back) will result in highlighting to become available.
It would be nice if the user didn't have to do this.
Extension version: 2.15.30
VS Code version: Code 1.86.1 (31c37ee8f63491495ac49e43b8544550fbae4533, 2024-02-07T09:08:20.941Z)
OS version: Windows_NT x64 10.0.22631
Modes:

This is a known bug - we send semantic token refresh notifications to the VSCode client when we load the project, telling it that the semantic tokens are out of date.  However VSCode will not actually refresh the tokens until the user interacts with the document (e.g. scrolling, making an edit, etc).
The VSCode behavior of lazily refreshing in response to a refresh notification is generally fine - the majority of the time we need to refresh, only a few semantic tokens are out of date.  When we're loading the project though it would be nice if we could force the client to refresh because we know everything is incorrectly colorized until the project finishes loading.
I don't believe we can manually force a refresh today - likely need support on the VSCode side for that.  Assigned to me to do some more investigation, but for now once the project finishes loading you'll need to interact with the document to get the colors to load (scroll, edit, switch docs, etc).


Make server output of user operations consistent

Is your feature request related to a problem? Please describe.
Fair input from here: https://github.com/glasskube/glasskube/issues/836#issuecomment-2200397313
On the UI we use the non-blocking methods for creating, updating and deleting resources, and we use the stderr statuswriter – this is the same as doing these operations on the CLI with --no-wait. This is in order to not have long-running requests to the backend (which could potentially look on the UI like it's loading forever). However, we therefore lose track of when the operation has finished and cannot show the correct log message in the server log.
Describe the solution you'd like
Solution A:
Rewrite to use non-blocking blocking operations. For example, we would call InstallBlocking on the server, but wrap it in a goroutine such that it doesn't block the client. Unfortunately this makes error handling a bit less obvious, because if there is an error, it cannot be sent via the regular http response anymore, but has to be sent via an SSE message – which would be broadcast to all clients! So if the UI is opened in multiple tabs or browsers, either all of them would get the error message, or we implement another solution there to track which client exactly did the original request, and therefore only send it to this one client.
Solution B:
Do not log the start of the operation either (probably use noop statuswriter), which would also make it consistent at least.

We decided for solution B, let's simply not print that kind of stuff to the server log for now.


RangeSelector.Button error

The RangeSelector.Button component doesn't seem to be working properly.  You can actually see an example of the JS error in your demo:
https://whawker.github.io/react-jsx-highcharts/examples/Highstocks/index.html
If you include any kind of RangeSelector.Button in your code like this:
<RangeSelector>
    <RangeSelector.Button></RangeSelector.Button>
</<RangeSelector>

You'll end up with this error:
Uncaught TypeError: Cannot read property 'state' of undefined
    at https://code.highcharts.com/stock/highstock.js:484:470
    at Array.forEach (<anonymous>)
    at a.each (https://code.highcharts.com/stock/highstock.js:28:325)
    at E.updateButtonStates (https://code.highcharts.com/stock/highstock.js:484:70)
    at E.render (https://code.highcharts.com/stock/highstock.js:492:442)
    at a.Chart.<anonymous> (https://code.highcharts.com/stock/highstock.js:499:481)
    at a.Chart.a.(anonymous function) (https://code.highcharts.com/stock/highstock.js:19:186)
    at a.Chart.<anonymous> (https://code.highcharts.com/stock/highstock.js:517:137)
    at a.Chart.a.(anonymous function) [as update] (https://code.highcharts.com/stock/highstock.js:19:186)
    at https://unpkg.com/react-jsx-highstock@1.3.4/dist/react-jsx-highstock.min.js:1:11143

My "fix" for the time being is to just pass the buttons in like this:
<RangeSelector buttons={myArrayOfButtonsHere}></<RangeSelector>

I think the error on the demo page is because the example pulls in Highcharts 6.0 from the CDN (due to an oversight), which is a version I haven't officially supported yet.
There may still be a different issue with range selector buttons with Highstock 5.0.x though, I'll take a look.

First, I just wanted to say thank you for the amazingly fast response and AWESOME project you have created here. :)
I just did "npm install highcharts --save" not thinking about versions, and it looks like I got 6.0.1.  That would certainly explain the issue.

No worries, that's what it said in the readme after all! (I've corrected that now). Glad you like the project!

So does switching to Highcharts 5.x.x fix the issue? Can I close this?

I haven't had a chance to check yet, sorry. :(  Once I implemented my work around with the button array via a prop, I just moved on.  I will let you know as soon as I can.

@marcelobaez that issue with RangeSelector.Inputs should be fixed now, the fix was released in 2.0.2 (or 1.4.2, if you're using the previous version)

For me, this issue is still a problem.  We have a set of dates on our chart as seen in the link in the OP.  I can click on the field with a date and see my cursor in the field but I can't change anything and the calendar doesn't come up either.
Here is my entire RangeSelector code:
<RangeSelector
                inputDateParser={this.parseDate}
                inputStyle={{
                  background: "f5d000",
                  color: "#ccc",
                  fontWeight: "bold"
                }}
              >
                <RangeSelector.Button count={60} type="minute">
                  1h
                </RangeSelector.Button>
                <RangeSelector.Button count={1} type="day">
                  1d
                </RangeSelector.Button>
                <RangeSelector.Button count={1} type="week">
                  1w
                </RangeSelector.Button>
                <RangeSelector.Button count={1} type="month">
                  1m
                </RangeSelector.Button>
                <RangeSelector.Button type="all">All</RangeSelector.Button>
                <RangeSelector.Input boxBorderColor="f5d000" />
                selected={1}
              </RangeSelector>