necessary of adversarial duration predictor

"note - duration predictor is not adversarial yet. In my earlier experiments with VITS-1, I used deterministic duration predictor (no-sdp) and found that it is quite good. So, I am not sure if adversarial duration predictor is necessary. But, I will add it sooner or later if it is necessary. Also, I want to combine parallel tacotron-2 and naturalspeech-1's learnable upsampling layer to remove MAS completely for E2E differentiable model."
On this issue, I would like to give my feedback:

The experience of most of us training VITS is that the rhythm of VITS is relatively simple and the expressive is not enough. So, this problem, I think, is  probably from MAS and duration predictor.

So, for now, the adversarial duration predictor is an important improvement over VITS2.

3.deterministic duration predictor (no-sdp) : In the VITS-1 paper, there seems to be an ablation experiment that proves this is not good enough.

StyleTTS2 is better than VITS in rhythmic diversity and expressive force, which can also prove the shortcomings of VITS. https://styletts2.github.io/

So, I think the adversarial duration predictor is necessary. Look forward to you updating the code, and then experiment and discuss with you

https://arxiv.org/pdf/2206.12132.pdf
Section 2.5

It may be that each has its advantages and disadvantages, and the DDP in VITS is slightly worse and may be better trained。

（from vits paper）

Yes yes, we have the parts ready, I just have to put in train.py. Will do it by weekend. You can still train a nosdp model then transfer learn it into sdp. We can check the performance by our experiments. Also, with papers, the problem is they just give metrics for that particular dataset, sdp might not work good on other datasets; so it is quite variable.

Added adversarial duration predictor, try and let me know if any training errors.

@p0p4k hey I have one question about the "transfer learn it into sdp..." if you don't mind :smiley: do you mean just continue training with SDP using the checkpoints trained with DP?

Yes, also I think we can modify code a little to train both dp and sdp together and compare performance simultaneously to save time.

In my experiments, all instantance with DPD (Duration Predictor Discriminator) are failed to continue enough steps, they are stucked.  And their syntheiszed results with the stucked checkpoint are no better then that without DPD.
like in the vits2 paper, our training pipeline is:  keep training without DPD to about 700K or 800K steps, then continue training with DPD to about 30K steps [mostly stucked after thousands of steps].  we did not make special change to the learning rate when continue, that means, the DPD is trained with initial lr=0.0002,  while other parts are continue with schedular-decayed lr on that steps.

The dpd is very naive in my implementation and could use some more sophisticated model.

The dpd is very naive in my implementation and could use some more sophisticated model.

Do you have any suggestions for building a more sophisticated SDP? I'd love to make a PR(also would be curious to see the tts result)

The dpd is very naive in my implementation and could use some more sophisticated model.

"The dpd is very naive in my implementation" is that the reason why i training with DurationDiscriminator and got stuck at the first steps.  And should we use it.

The dpd is very naive in my implementation and could use some more sophisticated model.

"The dpd is very naive in my implementation" is that the reason why i training with DurationDiscriminator and got stuck at the first steps. And should we use it.

In my experience use_sdp didn’t stuck, maybe try lowering batch size? There also might be some other issues causing it

The dpd is very naive in my implementation and could use some more sophisticated model.

"The dpd is very naive in my implementation" is that the reason why i training with DurationDiscriminator and got stuck at the first steps. And should we use it.

In my experience use_sdp didn’t stuck, maybe try lowering batch size? There also might be some other issues causing it

Are you training from scratch? or fine-tune based on a pretrained?

The dpd is very naive in my implementation and could use some more sophisticated model.

"The dpd is very naive in my implementation" is that the reason why i training with DurationDiscriminator and got stuck at the first steps. And should we use it.

In my experience use_sdp didn’t stuck, maybe try lowering batch size? There also might be some other issues causing it

Are you training from scratch? or fine-tune based on a pretrained?

Yes. I'm training from scratch and got stuck. And should I apply training strategy as you mention above?

No, nothing difference.  The paper did not tell the detail about the DPD at all.  you can train without it.

The dpd is very naive in my implementation and could use some more sophisticated model.

"The dpd is very naive in my implementation" is that the reason why i training with DurationDiscriminator and got stuck at the first steps. And should we use it.

In my experience use_sdp didn’t stuck, maybe try lowering batch size? There also might be some other issues causing it

Are you training from scratch? or fine-tune based on a pretrained?

Yes. I'm training from scratch and got stuck. And should I apply training strategy as you mention above?

No, nothing difference.  The paper did not tell the detail about the DPD at all.  you can train without it.


New bio for Roscoe van Wyk also formatted according to AirBnB standards

Seeing as it was left in a dirty state, I've cleaned it up

Thank you for your submission. There seems to be a lot of discussion over this standard. You should encourage it in our project if you want to see it take hold


Add pre-commit hooks

To validate JSON schema

Update main branch to main
Update README

Have included manual instructions on how to run tests, as pre-commit would require python etc.


DG: bug fix

Codecov Report

Merging #308 (f02ba80) into master (23d7304) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #308   +/-   ##
=========================================
  Coverage     72.01%   72.01%
  Complexity      769      769
=========================================
  Files           117      117
  Lines          2448     2448
  Branches        303      303
=========================================
  Hits           1763     1763
  Misses          536      536
  Partials        149      149

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23d7304...ec7ebb1. Read the comment docs.


Remove version: CrystalDewWorld.CrystalDiskInfo.ShizukuEdition version 8.12.3

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://osdn.net/frs/redir.php?m=ipconnect&f=crystaldiskinfo%2F75470%2FCrystalDiskInfo8_12_3Shizuku.exe
Response Error: The underlying connection was closed: Could not establish trust relationship for the SSL/TLS secure channel.
(Automated message - build 923)


iOS 13 Safari Zoom Issue

Github doesnt allow video, so I have converted it to a GIF and as can be seen from the GIF, I'm testing my app on iOS 13 Safari. Upon double tapping the screen at one point, the app zooms in and after that I'm unable to zoom back out into the normal view. This only happens when I double tap on  elements.
I wonder if this is a bug or is it my code. The repo is:
https://github.com/assman/ticket-ionic

Thanks for the issue. Can you provide some steps to reproduce the issue? I am testing this on a device running iOS 13.4 and am unable to reproduce the issue.

Thanks for the issue. Can you provide some steps to reproduce the issue? I am testing this on a device running iOS 13.4 and am unable to reproduce the issue.

Once you go to tickets/bookings (which is the main home page), tap on the first card - 20890
Doing so will open up the detail view. Now in the detail view, the first thing you see will be an ion card with the date and some lorem ipsum. double tap on that card like how its done for zooming in into things in iOS

Thanks for the follow up. I was able to reproduce this on iOS 13.3, but not on iOS 13.4. This looks like a quirk in WebKit that has since been fixed.
In terms of a workaround for those using older versions of iOS, you may be able to use touch-action to only allow panning. We could add this to the framework, but that might have unintended side effects for developers who want zooming enabled in their apps.
I am going to close this as this does not appear to be a bug in Ionic Framework. Thanks!


Merge remote-tracking branch 'ramda/master'

ramda/master:
Add missing R variable in defaultTo method doc

Oops. I didn't update to see my PR is unnecessary.


No graphics displayed for both shumway and flash.

SWF: 5fe15afd7709cfbb47227543cc09b0ccfc5a73480a435353955a6225ae93cfcc (Direct Link)

Given that there's no difference between Flash's and Shumway's behavior, there's nothing for us to do here.


WIP Add support for MemoryIndex

Prototyping https://github.com/valencik/textmogrify/issues/34

API Design
Currently example usage looks something like:

object InMemoryApp extends IOApp.Simple {

  case class Doc(author: String, title: String)
  object Doc {
    implicit val indexableDoc: Indexable[Doc] = new Indexable[Doc] {
      def keyValues(a: Doc): List[(String, String)] =
        ("title", a.title) :: ("author", a.author) :: Nil
    }
  }

  val docStream = Stream[IO, Doc](
    Doc("Tales of James", "Readings about Salmons and other select Alaska fishing Manuals"),
    Doc("Tales of Andrew", "Readings about Salmons and other select Alaska fishing Manuals"),
    Doc("james stuff", "salmon are great fish, learn cook em' in this manual"),
  )

  val memory = InMemoryBuilder
    .default[IO, Doc](fieldName = "title")
    .withAnalyzer(AnalyzerBuilder.english.withLowerCasing.build)
    .build

  val query = "author:james AND salmon~"

  val searchPipe: Pipe[IO, Doc, (Doc, Float)] = (in: Stream[IO, Doc]) =>
    Stream.resource(memory).flatMap(mem => mem.filterWithScore(query)(in))

  val run = docStream
    .through(searchPipe)
    .evalMap(IO.println)
    .compile
    .drain
}

With the interesting parts being memory, query, and searchPipe.
And within searchPipe we have perhaps three interesting parameters:
                          v-----v------------------------------v---------------type
val searchPipe: Pipe[IO, Doc, (Doc, Float)] = (in: Stream[IO, Doc]) =>
      Stream.resource(memory).flatMap(mem => mem.filterWithScore(query)(in))
                                                                   ^-----------query
                                                       ^-----------------------operation

There's basically four parameters at play here: document type, query, operation, and the analyzer.
I think one of the important design aspects to get right is to enable a desirable partial application of all these parameters.
Currently the order in which we pin down these parameters is:

document type
analyzer
operation
query

The query makes sense to leave open until late as this might not be known at compile time. The document type is perhaps the thing to try and move until later, mostly to enable reuse of components that specify the analyzer and the operation.

While neat, this experiment started before the creation of https://github.com/cozydev-pink/protosearch/ which is where I would want to concentrate search efforts. Closing as out of scope.


[$1000] Chat - Escaped HTML characters are decoded in LHN

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Action perform:
Go to any chat
Send a new comment <script>alert('hi')</script>
Notice the LHN message is  which is not consistent with chat comment

Expected Result:
The LHN message shouldn't be decoded
Actual Result:
The LHN message is decoded
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/232515551-e69bea25-47e8-4fa3-aaf6-aa3fba9a50a2.mov

Expensify/Expensify Issue URL:
Issue reported by: @Erichan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1681610340562309
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01637062b8dc3dc5ad
Upwork Job ID:<PHONE_NUMBER>117670912
Last Price Increase: 2023-04-17

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Yeah I mean, the simplest form of this is just & and &

Is this linked to https://github.com/Expensify/App/issues/15131 in any way?

Job added to Upwork: https://www.upwork.com/jobs/~01637062b8dc3dc5ad

Current assignee @twisterdotcom is eligible for the External assigner, not assigning anyone new.

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

Triggered auto assignment to @puneetlath (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

I am unable to reproduce on current staging, v1.3.1-0.

This is a dupe of this https://github.com/Expensify/App/issues/15920 and should be fixed by https://github.com/Expensify/App/issues/15131. Maybe it's not deployed on prod yet.

I'm also not able to reproduce. Closing!


CIV-8430 Rename Adjourn or vacate a hearing

Before creating a pull request make sure that:

[x] commit messages are meaningful and follow good commit message guidelines
[x] README and other documentation has been updated / added (if needed)
[x] tests have been updated / new tests has been added (if needed)

Please remove this line and everything above and fill the following sections:
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/CIV-8430
Change description
Update "Adjourn or Vacate Hearing" to "Adjourn Hearing"
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[ ] No

Test PR


Update diffx-scalatest to 0.5.3

Updates com.softwaremill.diffx:diffx-scalatest from 0.3.30 to 0.5.3.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.softwaremill.diffx", artifactId = "diffx-scalatest" } ]

labels: test-library-update, semver-minor

Superseded by #110.


Various security fixes

Thanks @chan233.
I've made some changes and add test files that you created. The CI is green now : )
Would you please test it again? Thanks again for your contribution.

Thanks @chan233. I've made some changes and add test files that you created. The CI is green now : ) Would you please test it again? Thanks again for your contribution.

Of course, if I find any bugs, I'll continue to submit PR.

crash_avif_3.tar.gz

@xiaozhuai
crash_avif_3.tar.gz

Fixed.

new_crashs.tar.gz
Here are some new samples that cause the program to crash. I tried to fix the issue but was unsuccessful. This is the call stack leading to the crash, and it's still caused by the try_avif_heic() function.  Did you checkout this pr and rebuild imageinfo_cli?

@xiaozhuai
Using this CMakeLists file for compilation, you will see the crash logs
CMakeLists.txt

new_crashs.tar.gz
@xiaozhuai

@chan233 Fixed

You can run your batch command several times. Although it's occasional, it can still trigger a 'Segmentation fault.'
for file in $(ls ../../new_crashs); do echo $file ;./imageinfo $file; done
crash_1
AddressSanitizer:DEADLYSIGNAL
AddressSanitizer:DEADLYSIGNAL
AddressSanitizer:DEADLYSIGNAL
AddressSanitizer:DEADLYSIGNAL
AddressSanitizer:DEADLYSIGNAL
AddressSanitizer:DEADLYSIGNAL
AddressSanitizer:DEADLYSIGNAL
Segmentation fault
crash_10
File: crash_10
  - Error    : Unrecognized format
crash_11
File: crash_11
  - Error    : Unrecognized format
crash_12
File: crash_12
  - Error    : Unrecognized format
crash_13
File: crash_13
  - Error    : Unrecognized format
crash_14
File: crash_14
  - Error    : Unrecognized format
crash_15
File: crash_15
  - Error    : Unrecognized format
crash_16
File: crash_16
  - Error    : Unrecognized format
crash_17
File: crash_17
  - Error    : Unrecognized format
crash_18
File: crash_18
  - Error    : Unrecognized format
crash_19
File: crash_19
  - Error    : Unrecognized format
crash_2
File: crash_2
  - Error    : Unrecognized format
crash_20
File: crash_20
  - Error    : Unrecognized format
crash_21
File: crash_21
  - Error    : Unrecognized format
crash_22
File: crash_22
  - Error    : Unrecognized format
crash_23
AddressSanitizer:DEADLYSIGNAL
AddressSanitizer:DEADLYSIGNAL
AddressSanitizer:DEADLYSIGNAL
AddressSanitizer:DEADLYSIGNAL
AddressSanitizer:DEADLYSIGNAL
AddressSanitizer:DEADLYSIGNAL
AddressSanitizer:DEADLYSIGNAL
Segmentation fault
crash_24
File: crash_24
  - Error    : Unrecognized format
crash_25
File: crash_25
  - Error    : Unrecognized format
crash_3
File: crash_3
  - Error    : Unrecognized format
crash_4
AddressSanitizer:DEADLYSIGNAL
AddressSanitizer:DEADLYSIGNAL
AddressSanitizer:DEADLYSIGNAL
AddressSanitizer:DEADLYSIGNAL
AddressSanitizer:DEADLYSIGNAL
AddressSanitizer:DEADLYSIGNAL
AddressSanitizer:DEADLYSIGNAL
Segmentation fault
crash_5
File: crash_5
  - Error    : Unrecognized format
crash_6
File: crash_6
  - Error    : Unrecognized format
crash_7
AddressSanitizer:DEADLYSIGNAL
AddressSanitizer:DEADLYSIGNAL
AddressSanitizer:DEADLYSIGNAL
AddressSanitizer:DEADLYSIGNAL
AddressSanitizer:DEADLYSIGNAL
AddressSanitizer:DEADLYSIGNAL
AddressSanitizer:DEADLYSIGNAL
Segmentation fault
crash_8
File: crash_8
  - Error    : Unrecognized format
crash_9
File: crash_9
  - Error    : Unrecognized format

@chan233 Very odd, I can't repro it.

@xiaozhuai
Maybe it's an issue with my computer. Currently, the tests are not showing any problems, so I think we can merge the branches.

I think we can merge the branches.

Ok, thanks for the contribution. I will merge this pr soon.


Sagemaker support

Report
How to work with DVC on Sagemaker

It's not actionable yet. I think it should be an epic on the DVC side first?


Does not support $(error ) in between ifeq

See image:

Tooltip:

Make runs as expected when I run it from the terminal, producing Makefile:9: *** Go is not installed.  Stop. as output.

Sorry for the noise, hit the close button by mistake.

This is also true for ifneq, ifdef and ifndef.


Bug: Second item in sub menu is selected first when using arrow key navigationBug title

Describe the bug
for Windows Explorer: file > context button or right-click > Open with (has focus) > right-cursor > submenu is displayed but nothing has focus...
but to give keyboard focus to the 1st item in the list I now have to press cursor-down (2nd item is selected), cursor-up (1st item is selected)
in other words it takes 1 less key to select the 2nd item than the 1st
I haven't discovered any other way from the keyboard to more efficiently select the 1st item in the sub-menu
Steps to reproduce the bug

select file/ thumbnail
context button or right-click
Open with (has focus)
right-cursor
submenu is displayed but nothing has focus

Expected behavior
maybe give 1st item in the sub-menu focus when right-cursor is pressed?
Screenshots
No response
NuGet package version
None
Windows version
Windows 11 (21H2): Build 22000
Additional context
No response

Video recorded
https://github.com/files-community/Files/assets/62196528/f4ac0be4-f3fe-468f-b3c9-14e9ded5544f

The item is focused but it does not seem to be drawing the focus rect.

@ranjeshj I'm pretty sure it's not focused because in that case, pressing the enter key would trigger the item.


"WebSocket closed" when query is large

If I execute:
const query = 'A reasonable amount of gremlin (28,683 bytes)';
client.execute(query, (err, results) => {
...

then things work as expected.
For
const query = 'A large amount of gremlin (83,696 bytes)';
client.execute(query, (err, results) => {
...

I get a WebSocket closed error.
What's the limit to the size of the query and any options that can be used to increase that?

This needs to be configured in the gremlin-server.yml file as well :).

Is it the maxContentLength?

If that is the setting, is there a way to query the server (from the client using this module) to get back the contents of that file (or this value) to determine the max size of a query?

I just confirmed that upping maxContentLength will solve this problem so closing. (Thanks for response @jbmusso and apologies for asking this here.)
Would love to know if there's a way to get that info back per the previous comment if you know that answer.


gtfs validation additional features

Description of the Feature to be Added

[ ]  % / n services by mode on a given day of interest (Could)
[ ] Distribution of services by mode across all available dates (Wont)
[ ]  Compare day of interest service to GTFS distribution (Wont)
[ ]  HTML output (Wont)

Hi @r-leyshon. I'm currently working on 'HTML output (Wont)' but it won't be fully finished until atleast the week commencing 21st of August.
In regards to the other tasks, would you say  'Distribution of services by mode across all available dates (Wont)' and
'Compare day of interest service to GTFS distribution (Wont)' are complete under summarise_routes() and summarise_trips() or are we looking to more specifically target service_id in the GTFS data?

Closing since these are already features in the GTFS module and the html outputs additions.


Allow TextLog body to display as immutable TextEdit rather than Label

What
Convert TextLog body to display as immutable TextEdit rather than Label.
This allows selecting and copying text from the log body.
Used discussion in https://github.com/emilk/egui/discussions/353#discussioncomment-7020619 as inspiration.
selectable == false (default):

selectable == true:

Checklist

[x] I have read and agree to Contributor Guide and the Code of Conduct
[x] I've included a screenshot or gif (if applicable)
[x] I have tested the web demo (if applicable):

Using newly built examples: app.rerun.io
Using examples from latest main build: app.rerun.io
Using full set of examples from nightly build: app.rerun.io

[x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

PR Build Summary
Docs preview
Examples preview
Recent benchmark results
Wasm size tracking

Web testing to come...
Appreciate a first look at the text color setting logic since I'm clearly missing something to make it render same as RichText Label does.

Thanks for the PR!
We need to support easily copying text from the Rerun UI, but I'm not sure this is the best approach.
It can be very finicky to select the whole text of a label (easy to miss the first letter, or the last letters if it doesn’t fit on screen etc).
It also doesn’t work great on mobile.
A different approach is to use a 📋-button for copying the entire text, like we already do for code-blocks in markdown.
This takes up space, and should probably only show on hover.
For mobile we could have long-press to copy (or long-press to show a context menu, including “copy text”).
I'm gonna talk it through with our designer next week and get back to you!

Thanks @emilk!
I should have some time this weekend to take a second look at this and make selectable the default. There's some aspects I'm missing related to the difference between the RichText label and the immutable TextEdit (masquerading as a Label):

Colouring changes from grey "inactive" to white "active"
Column width reducing to fit on screen, rather than expand to as long as the longest body content "off-screen"

Any pointers you might have for where to look to understand the differences are appreciated, otherwise I'll see what I can put together based on the fn selectable_label(ui: &mut egui::Ui, text: egui::RichText) abstraction you're proposing.

Text selection of all labels will be coming in the next egui release (1-3 weeks away): https://github.com/emilk/egui/pull/3814


bootstrap locals declared inside foreach not propagating or being zero initialized

(foreach (1 2 3) (
   (local a)
   (set a 123)
   a #sometimes this is still Nil
))

working on bootstrap / production.


Update Chrome for Desktop 91 on SharedArrayBuffer

Chrome for Desktop 91 will require COOP/COEP on SharedArrayBuffer. This is the same restriction enforced to Chrome for Android (#5681.)
References

https://blog.chromium.org/2021/02/restriction-on-sharedarraybuffers.html

Thanks!


Weird behavior of the FileUpload in the TodoTemplate project

Here is the scenario in which I got the problem:
I logged in to the template and then navigated to the edit profile page.
Then, I tried to set an image for my avatar but I got an error!
After that, I tried to upload another image but the error message still was displaying and I couldn't either interact with the uploader using the cancel and pause buttons of the uploader...All of these occurred while the second upload request was still pending.

This issue is resolved, so I'm closing it.


I cannot add python3 to path, because my vim plugins will require python2 in the path...
Is there any way I can fix this?

Yes, there is. I'll send a fix very soon. Thank you for reporting this
issue.

I cannot add python3 to path, because my vim plugins will require python2
in the path...
Is there any way I can fix this?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/nvbn/thefuck/issues/486

Sorry for the delay.

Thanks hope this is pushed to pip as soon as possible.

@chantisnake: No problem :smiley: In the meantime you can update to master with pip install -U git+https://github.com/nvbn/thefuck.git.

@chantisnake already in pip =)

Thanks, I just got the fix, it is awesome, but there is still decoding error like
�[1mgit commit -am 'test'�[0m [�[32menter�[0m/�[34m↑�[0m/�[34m↓�[0m/�[31mctrl+c�[0m]

this... Is there a way to fix this?

I can hunt this one at some easy pace. Subshell execution for variable definition is probably messing color sequences.
In the meantime I've already setup a Windows build on AppVeyor and things are looking good.
BTW, @nvbn, what do you think of these fancy badges?

@scorphus it woild be nice to have them.

I have problem like this.


Add support for multiple servers

This adds support for multiple servers with a switch server command
server [servername]

As well as a new config file config.yaml, similar to what was proposed in #58
Servers:
  Srv1:
    Connection: local
    ServerRootPath: C:/Users/USER/Desktop/server
    PluginFolderPath: C:/Users/USER/Desktop/server/plugins
    SeperateDownloadPath: false

  Srv2:
    Connection: sftp
    ServerRootPath: /
    PluginFolderPath: /plugins
    SeperateDownloadPath: /plugins/updated

    Server: mc.example.com
    Username: joe
    Password: pass
    Port: 22

  Srv3:
    Connection: ftp
    ServerRootPath: /
    PluginFolderPath: /plugins
    SeperateDownloadPath: false

    Server: mc.example.com
    Username: joe
    Password: pass
    Port: 21

  AnotherServerName:
    Connection: local
    ServerRootPath: /srv/mc
    PluginFolderPath: /srv/mc/plugins
    SeperateDownloadPath: /srv/mc/plugins/downloaded

  # more can be added

Hey @Sowgro,
thank you so much for your PR. :)
This is a really good functionality and I think the config just looks so much better imho. 😃
I reviewed your PR and added comments. It is really good with just one bug with the "port" which needs to be changed and some smaller code cleanup.
Thanks again for your hard work and sorry for the late response.
Have a good day! 👋

I am glad you got a chance to look at this. I will look through your comments later this week. This was the first time I ever wrote code in python, so my apologies for any weird formatting.


KAFKA-6084: Propagate JSON parsing errors in ReassignPartitionsCommand

More detailed description of your change
I'm verifying reassigning partitions in KRaft mode, and I accidentally find that #4090 only propagate errors when parsing reassignment json, we'd better propagate errors when parsing other json.
Summary of testing strategy (including rationale)
unit test
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Hi @viktorsomogyi @ijuma , PTAL.


Add "yes I meet Education" checkbox to basic info

~The application (but not the profile) needs to include a reference to Education Justification type.~
The basic info page of the application needs a new checkbox that says "Yes, I meet the education requirements" without any explanation of how.
Wireframe

Closing this since it's included in #2857


Implicit base not picked up in FHIR Reference search

Implicit base not picked up in fhir-search... When executing the Search -> extractParameterValues with resolve(), the fhir-search module and persistence layer extracts only Patient/.
For example... consider "code" : "patient", the extractParameterValues processes a JSON:
"subject": {
        "reference": "Patient/1-2-3-4"
    },

and stores  the value Patient/1-2-3-4.
The specification says the following are valid search query parameters:
[parameter]=[id] the logical [id] of a resource using a local reference (i.e. a relative reference)
[parameter]=[type]/[id] the logical [id] of a resource of a specified type using a local reference (i.e. a relative reference), for when the reference can point to different types of resources (e.g. Observation.subject)
[parameter]=[url] where the [url] is an absolute URL - a reference to a resource by its absolute location, or by it's canonical URL

Upon executing the request to
https://<SERVER>:443/<ROOT>/api/v4/MedicationRequest?patient=1-2-3-4
The request should return the resource body, however, we only support the specification #2.
The first behavior must be implemented, and the third behavior must be confirmed.
Note, the request with subject:Patient resource type works:
GET https://:443//api/v4/MedicationRequest?subject:Patient=1-2-3-4
URL: https://hl7.org/fhir/R4/search.html
In some cases, search parameters are defined with an implicitly limited scope. For example, Observation has an element subject, which is a reference to one of a number of types. This has a matching search parameter subject, which refers to any of the possible types. In addition to this, there is another search parameter patient, which also refers to Observation.subject, but is limited to only include references of type Patient. When using the patient search parameter, there is no need to specify ":Patient" as a modifier, or "Patient/" in the search value, as this must always be true.

Be sure to uncomment corresponding tests in AbstractSearchReferenceTest
        // TODO does this work if you define the extension in a StructureDefinition
        // and declare the allowed types?
//        assertSearchReturnsSavedResource("Reference-id", "Patient/123");

We hit this again in the Connectathon 25. It'd be nice to nail this one.

Inferno tests are not returning expected resources:
{{base}}{{contextRoot}}AllergyIntolerance?patient=1748dd8e606-de9c1bdf-3ecc-4e2f-b496-f2232ea77e1d

We found the following text from https://www.hl7.org/fhir/search.html#reference

Some references may point to more than one type of resource; e.g. subject: Reference(Patient|Group|Device|..). In these cases, multiple resources may have the same logical identifier. Servers SHOULD reject a search where the logical id refers to more than one matching resource across different types.

This means that we should try to infer the resource type even in cases where the search parameter refers to multiple different types.  Based on this text, it seems that omitting the resource type while searching a reference is really only an error if the target identifier exists in one or more of the target resource types that is being searched.


Refactor proposal session provider

accidentally created; closing

Hey @erikdstock, thanks for this! A lot of great ideas here!
This is definitely a big change to the library and the API.
I'll need some time to go through this in-depth and process the requested changes.
To get some of these changes in sooner, could we break these changes into smaller; tangible PRs?
I really appreciate your work and insight to this project!

@epilande - absolutely. I tried to break up my changes by commit- https://github.com/epilande/gatsby-theme-auth0/pull/31/commits/9e9be928792be3de76b6df5d017aaba209d5e1da contains the biggest changes.
For all other pieces (for example the shape of the session object returned from useAuth() I would update to ensure no major breaking changes as part of cleanup- as a proof of concept I let myself be a little bit messy getting things together.
If you have ideas on how to break up the major changes around splitting auth service into a provider object, I'd be happy to do that part more incrementally as well.

Hello again @epilande - I have continued tinkering with this and come a little closer but i'm still not certain of things.

To meet the current useAuth() signature I tried adjusting the return value. I don't think it is good enough, though- I'm not being clear enough about the difference between a user and a session, which is a little more stark than your version. Maybe I can still rethink that.
useAuth's callback parameter assumes that each call to the hook is going to trigger a new auth0.checkSession() call, but I don't think this is necessary when the session is refreshed at the provider level once when the app loads. I'm not sure of the best way to address this, and without that feature it makes more sense to just use useContect(SessionContext).

If you think these problems are unresolveable I'm fine with just closing the PR. Thanks for your consideration!

Hi, thanks for your consideration but I'm going to close this.


GHC 7.10.1 Missing compiler flag.

Arch Linux 64-bit  Kernel 3.19.3-3-ARCH
The Glorious Glasgow Haskell Compilation System, version 7.10.1
[ 9 of 21] Compiling Unison.ABT       ( src/Unison/ABT.hs, dist/dist-sandbox-49d2760b/build/Unison/ABT.o )
src/Unison/ABT.hs:224:13:
    Non type-variable argument
      in the constraint: Integral (Data.Bytes.Signed.Unsigned n)
    (Use FlexibleContexts to permit this)
    When checking that ‘hashInt’ has the inferred type

Required adding the following before it would compile:
index 6b02f04..921c611 100644
--- a/node/unison.cabal
+++ b/node/unison.cabal
@@ -90,7 +90,7 @@ library
     transformers-compat       ,
     vector                    >= <IP_ADDRESS>

-  ghc-options: -Wall -fno-warn-name-shadowing -threaded -rtsopts -with-rtsopts=-N
+  ghc-options: -Wall -fno-warn-name-shadowing -threaded -rtsopts -with-rtsopts=-N -XFlexibleContexts

Aha. Could we just add a type annotation there - specializing to int there
is perfectly fine. I'd rather that than flexible contexts. Or rather, I
want to use flexible contexts intentionally, not because something is more
polymorphic than intended.
I'm going to upgrade to ghc 7.10 early next week so I can fix this stuff
first hand.
On Sat, May 9, 2015 at 3:11 AM Alec Posney<EMAIL_ADDRESS>wrote:

Arch Linux 64-bit Kernel 3.19.3-3-ARCH
The Glorious Glasgow Haskell Compilation System, version 7.10.1
[ 9 of 21] Compiling Unison.ABT       ( src/Unison/ABT.hs, dist/dist-sandbox-49d2760b/build/Unison/ABT.o )
src/Unison/ABT.hs:224:13:
Non type-variable argument
in the constraint: Integral (Data.Bytes.Signed.Unsigned n)
(Use FlexibleContexts to permit this)
When checking that ‘hashInt’ has the inferred type
Required adding the following before it would compile:
index 6b02f04..921c611 100644
--- a/node/unison.cabal
+++ b/node/unison.cabal
@@ -90,7 +90,7 @@ library
transformers-compat       ,
vector                    >= <IP_ADDRESS>

ghc-options: -Wall -fno-warn-name-shadowing -threaded -rtsopts -with-rtsopts=-N

ghc-options: -Wall -fno-warn-name-shadowing -threaded -rtsopts -with-rtsopts=-N -XFlexibleContexts

—
Reply to this email directly or view it on GitHub
https://github.com/unisonweb/platform/issues/6.


OSS license for Wire

Hi @rogeralsing ,
It seems you removed the Apache license from the project. Im inquiring because i would like to know what License you plan to change it to.
The legal department of the company i work for does not allow me to use an OSS project with no license (and some are prohibited outright). So please let me / the community know what your plans are regarding this topic, so I / we can plan accordingly.
Also I can imagine some users who are using Wire with Akka.Net and are using it for persistence would be very interested as well. If they find themselves in the position that they are no longer allowed to use Wire due to License issues, they would possibly have a rather nasty migration path ahead of them..
Also, why did you removed it in the first place ?

I noticed you updated the license to GNU v3.
Im not an expect but if im reading this correctly. It basically means that only other OSS libraries are allowed to use Wire right?
So any proprietary software is out ?

I'm curious about this as well. I was thinking about using it in one of my products but now I can't really anymore. If it was LGPL I could? I'm happy to contribute back fixes.

Heads-up for whomever can no longer use Wire in commercial closed-source applications due to the move to GPL:
Akka.net's  Hyperion has been forked from Wire prior to the license change and continues to be permissively  licensed under Apache 2.0.

After investigating actual .Net serializer availabilities, I found that Wire gets absolutely the best score for its performance/serialized size/product integration aspects. Many thanks to @rogeralsing for the great product. I really enjoyed walking though its code and reading a story blog.
... but GPLv3 makes it nearly impossible to use in non-OSS applications. It is a pity indeed, because Wire has a great potential to become a de-facto leader among .Net binary serializers as Newtonsoft.Json is now among JSON ones. But not with this type of license of course...
Just wondering if there is any chance to support dual licensing (e.g. MIT/GPL) as some other OSS libraries do?

Apache 2 license re-added.
We are likely adding Wire support in Proto.Actor soon and development will be resumed.


Reordoning UITableViewCell don't work on iOS8

When I tried to reordoning a UITableView, the cell is draggable on few pixels and return to it's original position.
I tried without MSDynamicsDrawerViewController and it's works.
It's reproductible with the MSEditableTableViewController in the demo folder (https://github.com/monospacecollective/MSDynamicsDrawerViewController/blob/master/Example/Example/MSEditableTableViewController.m)

@codelapse  @klauslanza
Wonder if you guys solved the problem yet, I've found a way to fix the problem on iOS8.
I've opened a pull request, maybe your guys can give it a try :)
https://github.com/erichoracek/MSDynamicsDrawerViewController/pull/153

Your fix did wonders @JohnnyTseng , thanks a lot!
I know this library is not updated much (I use it in some old projects with very few resources for refactoring time), but it would be great if the PR could be accepted by the maintainer.


Merge pull request #860 from OfficeDev/main

[admin] merge to live

Docs Build status updates of commit 24673d3:
:warning: Validation status: warnings
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Migrating the project

Even though I have permission to commit in this repository I don't have permission to publish it in pypi. We lost touch with the old developer @BradWhittington .
I will leave this issue open for a few days and if there is no objection we will create a new Pypi package and migrate the project there, that's the only way to go forward with the project.

@aericson I work with @BradWhittington and can get in contact with him. It'd be easier for users if we get you access to PyPI for the package, and potentially migrate the project to your GitHub repo.

@zoidbergwill That would be ideal if you can get him to do these two things. Let me know if you need anything from me.

I've given @aericson permission on pypi, assuming that's your username there...

Thanks!


⚠ Bofrost.de has degraded performance

In 2881e67, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1000 ms

Resolved: Bofrost.de performance has improved in 622ad3e.


Incorrect instructions on registry

On the registry page for this package, the following command line is given to get the template:
ligo init contract --template nft-factory-cameligo [PROJECT_NAME]

However this does not work, as the correct name for the template is NFT-factory-cameligo. I did not find where to change this.

It'll be fix the next release of registry


KE overwriting keyboard layout to previous machine after installing Time Machine backup on new computer with different layout

Hi,
I just went from a MBP with a US keyboard to a new one with a Japanese keyboard. I imported my backup from Time Machine, and now in the new on machine if KE is on, the keyboard layout is overridden with the old US layout, even if I reset it in the System Preferences.
How can I make KE use the new Japanese layout?
Cheers

Please set keyboard type while Karabiner-Elements is running.
https://pqrs.org/osx/karabiner/document.html#configuration-keyboard-type

Thanks!
On Mon, Apr 22, 2019 at 6:07 PM Takayama Fumihiko<EMAIL_ADDRESS>wrote:

Please set keyboard type while Karabiner-Elements is running.
https://pqrs.org/osx/karabiner/document.html#configuration-keyboard-type
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tekezo/Karabiner-Elements/issues/1818#issuecomment-485370881,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJ5PJXIHIOPWIUBIL3ASYDPRV56JANCNFSM4HHOGAIA
.


Angular Change Detection

Per my question on StackOverflow (https://stackoverflow.com/questions/65544921/angular-httpinterceptor-cache-not-triggering-change-detection)
When the chart is NOT using caching, it renders correctly. When it IS using caching, it does not re-render properly even though the cache is returning the correct data.
Any insight/direction would be appreciated.

@kevinsherman It seems that your question is already solved https://stackoverflow.com/a/65581481/3893439, is this issue still valid?

@kevinsherman It seems that your question is already solved https://stackoverflow.com/a/65581481/3893439, is this issue still valid?

Problem solved. Closing.... thanks @timocov.

Problem solved. Closing.... thanks @timocov.


Choose a organisation domain name for Amy

We need a own domain name for Amy and don't use the unistuttgart.de domain.
This domain we can then use as the organization identifier for maven.
Also the Java package names must be changed to the new domain name.
Current domain: amyassist.iaas.unistuttgart.de

We can use amyassist.github.io, it't free and hosted on GitHub.

New domain: amyassist.github.io


Cherry-pick Qrda 5 1 errata (#73) for data uniqueness

Follow QRDA Cat I R5.1 errata Guidance for Ensuring Data Uniqueness

Pull requests into cqm-parsers require the following. Submitter and reviewer should :white_check_mark: when done. For items that are not-applicable, note it's not-applicable ("N/A") and :white_check_mark:.
Submitter:

[ ] This pull request describes why these changes were made.
[ ] Internal ticket for this PR:
[ ] Internal ticket links to this PR
[ ] Code diff has been done and been reviewed
[ ] Tests are included and test edge cases
[ ] Tests have been run locally and pass

Reviewer 1:
Name:

[ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[ ] The tests appropriately test the new code, including edge cases
[ ] You have tried to break the code

Reviewer 2:
Name:

[ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[ ] The tests appropriately test the new code, including edge cases
[ ] You have tried to break the code

Codecov Report

Merging #81 into master will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
- Coverage   88.46%   88.41%   -0.06%
==========================================
  Files          70       68       -2
  Lines        1908     1899       -9
==========================================
- Hits         1688     1679       -9
  Misses        220      220

Impacted Files
Coverage Δ

lib/cqm-reports.rb
100.00% <ø> (ø)

lib/qrda-import/patient_importer.rb
90.47% <100.00%> (+1.11%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb05500...8d8d82f. Read the comment docs.


Rename to NewKuratorCommand

Does this PR introduce a user-facing change?:

NONE

range map randomness, in real config is ok, but will cause UT failed.

/retest

range map randomness, in real config is ok, but will cause UT fail.

How to fix this unit test? can just compare the two string lengths?

range map randomness, in real config is ok, but will cause UT fail.

How to fix this unit test? can just compare the two string lengths?

I will change the implement

UT fail fixed by https://github.com/kurator-dev/kurator/pull/9

/lgtm

/approve


fix export pdf notebook

Fixed the issue (https://github.com/mindee/doctr/issues/1596) with :

removed the now unnecessary argument from the show function
added a pip install for mplcursors as it was suggested from the error

Code improvement :

split the cell that download the file and run the model into two cells since you don't want to download again the file if you want to rerun the model

You can run on Colab the following url for the review :
https://colab.research.google.com/github/cthiounn/notebooks/blob/fix_export_pdf_notebook/doctr/export_as_pdfa.ipynb
vs the current Mindee prod
https://colab.research.google.com/github/mindee/notebooks/blob/main/doctr/export_as_pdfa.ipynb

I did the suggested edit, a little caveat is Colab now suggest to reboot the session and if you click it too quickly, it will reboot before the install of the following librairies (reportlab, pypdf). Should I keep as is or put the doctr pip install last ?


Add workflow to validate landscape.yml file

This PR adds a workflow that validates the landscape.yml on each pull request created.
NOTE: If your company logo needs changed, please submit an LF Support Request rather than changing here
Pre-submission checklist:
Please check each of these after submitting your pull request:

[ ] Are you including a repo_url? You need to pick the single best GitHub repository for your project, not a GitHub organization.
[ ] Is your project open source?
[ ] Is this project hosted by the Linux Foundation?
[ ] Have you picked the single best (existing) category for your project?
[ ] Does it follow the other guidelines from the new entries section?
[ ] Have you included a URL for your SVG or added it to hosted_logos and referenced it there?
[ ] Does your logo clearly state the name of the project/product and follow the other logo guidelines?
[ ] Does your project name match the text on the logo?
[ ] Have you verified that the Crunchbase data for your organization is correct (including headquarters and LinkedIn)?
[ ] ~5 minutes after opening the pull request, the CNCF-Bot will post the URL for your staging server. Have you confirmed that it looks good to you and then added a comment to the PR saying "LGTM"?

Hey @cynthia-sg - I saw you closed this, but just to let you know I have this handled in a composite action which does the landscape building from LFX data ( see https://github.com/jmertic/lfx-landscape-tools/blob/main/action.yml )

Ok, cool. I closed it to open it against the right branch 🙂
But feel free to discard it if it won't be of help.


Rule for DelayedInitSelect

Relevant Xlint code is at https://github.com/scala/scala/blob/2.11.x/src/compiler/scala/tools/nsc/typechecker/RefChecks.scala

LGTM


Vulnerability roundup 112: qt-4.8.7: 1 advisory [7.5]

search, files

[ ] CVE-2022-25634 CVSSv3=7.5 (nixos-21.11, nixos-unstable)

CVE details
CVE-2022-25634
Qt through 5.15.8 and 6.x through 6.2.3 can load system library files from an unintended working directory.

Scanned versions: nixos-21.11: efea022d6fe; nixos-unstable: 710fed5a248.
Cc @lovek323
Cc @orivej
Cc @phreedom
Cc @svanderburg

See also: #73679, #133971, #99842, #96822, #90952


Enhancement: Add support to PEP 540 -- Add a new UTF-8 Mode

Consider adding support to PEP 540 -- Add a new UTF-8 Mode.
https://www.python.org/dev/peps/pep-0540/

How do I pass the -X utf8 python flag to nuitka?
I know python's -O and -OO can be used in nuitka with --python-flag=-O or --python-flag=-OO but I tried --python-fag=-X utf8 and --python-flag=-Xutf8 and both don't work.

I'm testing with the command
python -m nuitka --run test.py

Use python -X utf8 -m nuitka --run test.py  or set PYTHONUTF8 environment variable.

ok, thanks.


Model room monitoring concepts

Implement the room-monitoring model following the DDD principles.

Complete and close #1 issue


Prepare framework to work with 1.16 and 1.17 versions due 1.15 deprecation:

https://endoflife.date/go

Go versions policy

https://go.dev/doc/devel/release#policy

On Golang 1.17 package ioutil is deprecated, thus we must move to os package instead:
For example:
ioutil.ReadFile(...)

would become
os.ReadFile(...)

or
ioutil.ReadAll(...)

would become
io.ReadAll(...)

Link references:

https://github.com/go-critic/go-critic/issues/1019

Next step:

Prepare build to go version matrix versions

Upgraded to 1.17 and tested with 1.18


How do we get Stuff from the Micro:Bit sensors?

This seems like a fairly difficult challenge as there is no direct way to sync up the micro: bit with a desktop because it uses "MicroPython."
However, the micro: bit has persistent files, so we have to create a file with our data, have the connected computer read it, and generate another file to say that the transfer is done so it doesn't get overwritten mid-check.
Profit.

Documentation for micro: bit : https://microbit-micropython.readthedocs.io/en/v1.0.1/filesystem.html

There is a python module called pyserial which we could use with the microbit sending serial data. I have to figure out how it works first though


"Fatal error" while make

Try to make on a fresh install Linux.
report that
dvorak.c:64:10: fatal error: stdlib.h: No such file or directory
    64  |  #include <stdlib.h>
compilation terminated
make: *** [Makefile:13: all] Error 1

Is the problem of my GCC version or the code itself?

Sorry for the late response, you need the dev libraries for libc. Something like this should help if you are using Ubuntu:
sudo apt-get install libc6-dev
Depending on your distro, the command may look different.

Alright, I will take a try.
I'm using Linux Mint. Since it's Debian-based, I think it should work.
Thanks for your reply.


Extending AbstractEvent

I created an event in my plugin: CurrentEditorScrolledEvent
I updated SpongeVanilla to test the plugin again and I see that the custom event that is fired needs to extend AbstractEvent because of this.
Is this intended? As you can see, I just extend from that event and everything seems to be ok.

According to @Aaron1011 it is intended, and won't be fixed.

I'll make it more clear in the javadocs and in SpongeDocs that custom events need to extend AbstractEvent.


Added AvaloniaUI logo as icon in Examples

There were no window icons in the Examples so I created an "icon.ico" from the AvaloniaUI logo and added it to each sample project. I tried to remain consistent but had some trouble with getting the assets picked up as AvaloniaResources, per se. So I'm importing it directly - which may be a bit naïve - or at least not a canonical example.

Awesome, thanks a lot for your contribution 😃 I'll try out later to check if there's any better option to import icons, but if not this should be okay!
If you don't mind waiting, can we delay merging this PR until #179 is merged? There's a lot of examples being added there that could use the icons once it's done as well.

@houstonhaynes thanks a lot for the patience! We just got #179 merged, so you'd probably get some merge conflicts on the .fsproj files of the samples (they were moved to two different folders). If you could update that and add the same icon to the new projects that were created in the Components folder it'd be great 😃

Sorry, didn't mean to close this...was trying to get it merged, but I am bad at git. 🙁


Discard Changes and Stage Changes buttons are pretty close together

The feature I'd like to suggest is a simple one. More of just an adjustment, rather than a feature. On the Source Control panel, the buttons for staging files and discarding changes are awfully close together. I haven't had any unfortunate coordination issues, thank goodness, but I had the thought that it might be helpful to move the discard button a bit further away. Floating it to the left next to the file name could be a solution. Just a suggestion. Great work on the editor.

The discard button always has a confirmation dialog, so you'd be fine even if you click it.


TNTLexer: Don't crash on unexpected EOL.

Closes #1568 which is blocking #1425

Force pushed to just the one commit (the others are already in the repo)

Could you please add a test case for this?

(Seen 4 hours ago, been writing tests for the whole lexer ever since)

That looks fairly comprehensive, thanks! I'll wait for the tests to finish, then merge -- thanks for your contribution.

/cc @Anteru just noting that tests have passed! I don't want to hold up the people in #1425 any longer than I have to. Thanks :)


Askalono: Upgrade to version 0.4.3

See https://github.com/jpeddicord/askalono/releases/tag/0.4.3.
Note that Askalono is now distributed in ZIP archives instead of plain
executables.
Signed-off-by: Sebastian Schuberth<EMAIL_ADDRESS>

/cc @jpeddicord

Merging without waiting for Travis which seems to got stuck.


Fix introduction link

oh thanks for this!

landed in https://github.com/npm/npm-like-im-5/commit/0543cf7f99d7dd75ce7ad5ca35cd39768b176670


Removed deprecated versioning helpers

These versioning helpers have been deprecated and should be removed after 2 releases. See #1381 and #1361. These should be removed in the March release.
Deprecations for January release

getRenamedFromVersion
getRenamedFromOldName
renamedAfter
getAddedOn
getRemovedOn
addedAfter
removedOnOrBefore

@markcowl these should be removed in March, which is... the February sprint?
est: 1
pri: 0

March == April Sprint

Why did we deprecate these? - this essentially forces the use of projections for versioning and deprecates the usage pattern that is used for canonical spec code generation in cadl-providerhub-controller (and conceptually, other emitters which would prefer a canonical rather than individualloy versioned specs)

These were deprecated because these decorators can be applied multiple times, so the fact that these can only return a single value is incorrect and should not be relied upon.

est: 1


Verify that "Rimetea" is listed in the drop-down menu

Description : When you will type "Rimetea" in the search bar you should see it in the dropdown menu correctly spelled and with locality information.
Precondition : The website is up and running

Step 1
Type "Rimetea" in the search bar.
Expected results:
The dropdown is listing "Rimetea" as the first location in the dropdown menu.

Step 2 : Observe "Rimetea" from the dropdown menu.
Expected result : "Rimetea" should be correctly spelled, it should have locality information and should be selectable from the dropdown menu.


Consider consolidating GoldenComparator and WebGoldenComparator

There are two interfaces with nearly identical roles in flutter_test:

GoldenFileComparator and the current implementation, goldenFileComparator.
WebGoldenComparator and the current implementation, webGoldenComparator.

The latter is only used in a web browser/web context, and the former is used otherwise.
For the workstream that will be making package:integration_test be able to take and compare screenshots, even on mobile devices (i.e. Android and iOS), we'll be bleeding the lines further - using GoldenFileComparator as a proxy, which coincidentally is almost exactly what WebGoldenComparator does.
Here is a draft PR where I do exactly that: https://github.com/flutter/flutter/pull/160131.
It would be nice for flutter_test to have a cleaner interface, and not have a web and non-web configuration. The interfaces are nearly identical. I've initially assigned this to team-framework as owners of flutter_test to give a reaction; feel free to reach out to me directly to discuss further.

/cc @eyebrowsoffire on the web team who I discussed this with already and got a +1.


Update rosenbrock4_controller.hpp

For ticekt 11077.

Using
using std::sqrt;
sees to me more general. Thank your reporting.


Jetty module activation

The various features of jetty are activated and configured by our module mechanism, which has so far been done within the docker file.   There is a discussion about using environment variables to control some of these features, so this issue is to discuss exactly how that can be done.
Firstly some background on the jetty module mechanism.  An example is to activate gcloud sessions we need to run a command (currently from a Dockerfile RUN command) like:
java -jar $JETTY_HOME/start.jar --add-to-start=session-store-gcloud,jcl

The --add-to-start command enables both the session-store-gcloud module and it's dependencies, which primarily is the sessions module. Note that we also add the jcl module to pick one of our available implementations of java commons logging, which is a dependency of the gcloud library used (if there was only one, we'd pick it automatically).
To add memcache, you would need to run the command (or add it to the previous command):
java -jar $JETTY_HOME/start.jar --add-to-start=session-store-cache

This is easy enough to do in custom Dockerfiles, but the suggestion is that such features need to be selectable at run time via env variables.    So we need to consider how best to do that, so let's see what our --add-to-start command does.
When adding a thirdparty module like gcloud session, the --add-to-start command downloads any dependencies not part of the normal jetty distribution, which for gcloud, this is quiet a few jars, so I don't think we'd want to be doing this for every instance we start up as it increases the chance of a failure.      The solution to this is that in our image Dockerfile for jetty-runtime we can enable all the modules that might be enabled by env variables, so the library downloads are done, and then disable them by removing the related start.d/*.ini files.
Next the default command line is modified to include activation of the module, which is simply adding something like: --module=session-store-gcloud to the command line.     This is what could be done by a start script that checks the env variables.
Finally, the --add-to-start command creates a start.d/session-store-gcloud.ini file with parameters that can be configured for the module.  e.g.:
[] cat start.d/session-store-gcloud.ini
# ---------------------------------------
# Module: session-store-gcloud
# Enables GCloudDatastore session management.
# ---------------------------------------
--module=session-store-gcloud

## GCloudDatastore Session config
#jetty.session.gcloud.maxRetries=5
#jetty.session.gcloud.backoffMs=1000

[] cat start.d/sessions.ini
# ---------------------------------------
# Module: sessions
# The session management. By enabling this module, it allows
# session management to be configured via the ini templates
# created or by enabling other session-cache or session-store
# modules.  Without this module enabled, the server may still
# use sessions, but their management cannot be configured.
# ---------------------------------------
--module=sessions

## The name to uniquely identify this server instance
#jetty.sessionIdManager.workerName=node1

## Period between runs of the session scavenger (in seconds)
#jetty.sessionScavengeInterval.seconds=60

[] cat start.d/session-store-cache.ini
# ---------------------------------------
# Module: session-store-cache
# Enables caching of SessionData in front of a SessionDataStore.
# ---------------------------------------
--module=session-store-cache

## Session Data Cache type: xmemcached
session-data-cache=xmemcached
#jetty.session.memcached.host=localhost
#jetty.session.memcached.port=11211
#jetty.session.memcached.expirySec=

As you can see, almost all the parameters are commented out, so the default settings are normally good.   This means that we can access the default module configuration simply by a start script that adds the appropriate --module= args to the command line based on the environment variables.
However, as soon as a user wants to configure any of these features, they are going to have to re-create the ini files and edit the parameters in them in their own custom Dockerfile.       This then creates a duality where a module might be enabled in either a start.d/*.ini file and/or enabled by the start script adding a command line argument based on an environment variable.
I don't think this duality is good and it will confuse many that the mechanism changes the moment they go from a default image to a custom image.
So another idea is that our Dockerfile can enable all the possible modules and then move their start.d/*.ini files to a gae.d/ directory.    The start script would then check the env variables and if a feature is turned on, it would move the ini file(s) from gae.d/ back to start.d/.     To configure these features they could then use a custom Dockerfile simply to replace/edit the gae.d/*.ini files that the start script would use.    Still not perfect but better.
Perhaps a better way would be for the start script to first check if a feature is already enabled, and if so ignore the env variables.  Note that jetty will throw an exception if you try to configure two contradictory modules (eg two non compatible session data stores), so if a user enables one session store and the env variable is indicating another, we need to either error or ignore the env variable?
To make more progress on deciding how to do this, we need to know more about what the environment variables will look like.     In #41 @janbartel will soon enumerated the various session configurations that we could deploy.  @meltsufin can you look at that issue and when you indicate which of those you want available on jetty-runtime can you also indicate how you imagine the environment variable will look like?  Will it be several booleans? an enumeration? will there be configuration env variables such as ports etc.?

I think your suggestion to preconfigure various modules in gae.d/ and then move them into start.d/ at runtime based on environment variables is a good compromise. I assume you intend this to be done only  for optional modules that we want to allow being enabled via environment variables. I would even just call the directory opt.d/ or something similar to make it clear that these modules are not enabled by default. Required modules, on the other hand, can go directly into start.d/.
I'll comment on #41 regarding the environment variable names.

Having an opt.d for some modules still leaves us with two configuration mechanisms - either adding environment variables in app.yaml for modules that are supported, or adding commands/files in a dockerfile for modules that are not.
The problem I see with the app.yaml approach is that whilst setting an env variable to enable a module might be simple enough, there will inevitably be demand for configuration of the module or sub-options in the module.  This will lead to an explosion of env variables and a reworking of significant container configuration.
Wouldn't it be easier to just steer users to Dockerfile commands for configuration of modules?  A Dockerfile is not much more complex than app.yaml?
If we are to support env variables configuration in app.yaml, then I think we need a clear policy of what kind of things are suitable for app.yaml vs what kinds of things will require a Dockerfile, otherwise overtime I fear a piecemeal approach as arbitrary features are supported in app.yaml

Just doubling down on my comments in a different form.    I thought the idea that a user wants to use Flex  rather than standard GAE is so that they have the ability to configure the container.   So the expectation is that most users will eventually want to configure the container in fairly arbitrary ways.  If we wish to allow that without a Dockerfile, I think we are going to end up replicating large proportions of a container configuration in env variable, which are pretty much unsuitable for the task (else containers would just use them).
Surely we want some reasonable defaults behaviour in an image that is deployed without a Dockerfile (and I would assume that includes clustered session) and then leave all further customization to the Dockerfile - which is pretty easy to do with the new plugin.

@gregw I'm with you on not exposing module configuration through environment variables. That should be done by overwriting our default module settings files with a custom Dockerfile. Environment variables would only be used to turn on GCP-specific features, like clustered session management. In fact, currently, clustered session management and possibly application log redirection to Cloud Logging are the only two optional modules I can think of. I don't think we need to make any non-GCP-specific modules optional via environment variables.

Might be nice if we could somehow leverage the new "--commands" mechanism ( #83 )  to allow users to provide properties that override the ones from the jetty base.

It indeed would be nice to be able to edit properties in ini files by command, but it would have to be a new feature as the --add-to-start mechanism on creates new ini files from a template.  We'd need something that visits all ini files... possible... thinking....

I've updated https://github.com/eclipse/jetty.project/issues/1139 to add a --update-ini option that allows properties to be set in existing ini files.  This will be in 9.4.0


Simulation script for assession impact of coronavirus on US Congress

Signed-off-by: Zach Musgrave<EMAIL_ADDRESS>

Need a quick read on this to see if there are any obvious errors in the simulation logic. It runs on CSV files that contain bio information for the house or the senate along with mortality rates for the age and sex. I plan on linking it from the blog article.


single A100 runs llama-7B with batch_size>=64 input_len(max)=1024 output_len(max)=512

torch.cuda.OutOfMemoryError: CUDA out of memory. Tried to allocate 514.00 MiB. GPU 0 has a total capacity of 79.14 GiB of which 21.25 MiB is free. Process 1091649 has 79.09 GiB memory in use. Of the allocated memory 78.44 GiB is allocated by PyTorch, and 140.44 MiB is reserved by PyTorch but unallocated. If reserved but unallocated memory is large try setting PYTORCH_CUDA_ALLOC_CONF=expandable_segments:True to avoid fragmentation.  See documentation for Memory Management  (https://pytorch.org/docs/stable/notes/cuda.html#environment-variables)

python3 convert_checkpoint.py --model_dir ./llama-7b
--output_dir ./tmp/tllm_checkpoint_1gpu_sq
--dtype float16
--smoothquant 0.5
--per_token
--per_channel
--int8_kv_cache
trtllm-build --checkpoint_dir ./tmp/tllm_checkpoint_1gpu_sq
--max_batch_size $batch_size
--max_input_len $max_input_len
--max_output_len $output_len
--output_dir ./tmp/llama/7B/trt_engines/sq/1-gpu/
--gemm_plugin float16
python3 ../summarize.py --engine_dir ./tmp/llama/7B/trt_engines/sq/1-gpu/
--batch_size $batch_size
--test_trt_llm
--hf_model_dir ./llama-7b
--max_input_len $max_input_len
--output_len $output_len
--data_type fp16
--tensorrt_llm_rouge1_threshold=14

@pathorn @Superjomn @aaronp24 @lopuhin

Hi @rhmaaa the title of this issue does not match the bug description. Could you please make this consistent?

I am using a single A100 GPU to perform w8a8 quantization on the llama 7b model. When running the following command with batch_size >= 64,
python3 convert_checkpoint.py --model_dir ./llama-7b
--output_dir ./tmp/tllm_checkpoint_1gpu_sq
--dtype float16
--smoothquant 0.5
--per_token
--per_channel
--int8_kv_cache
trtllm-build --checkpoint_dir ./tmp/tllm_checkpoint_1gpu_sq
--max_batch_size $batch_size
--max_input_len $max_input_len
--max_output_len $output_len
--output_dir ./tmp/llama/7B/trt_engines/sq/1-gpu/
--gemm_plugin float16
python3 ../summarize.py --engine_dir ./tmp/llama/7B/trt_engines/sq/1-gpu/
--batch_size $batch_size
--test_trt_llm
--hf_model_dir ./llama-7b
--max_input_len $max_input_len
--output_len $output_len
--data_type fp16
--tensorrt_llm_rouge1_threshold=14
an error occurs:
torch.cuda.OutOfMemoryError: CUDA out of memory. Tried to allocate 514.00 MiB. GPU 0 has a total capacity of 79.14 GiB of which 21.25 MiB is free. Process 1091649 has 79.09 GiB memory in use. Of the allocated memory 78.44 GiB is allocated by PyTorch, and 140.44 MiB is reserved by PyTorch but unallocated. If reserved but unallocated memory is large try setting PYTORCH_CUDA_ALLOC_CONF=expandable_segments:True to avoid fragmentation. See documentation for Memory Management (https://pytorch.org/docs/stable/notes/cuda.html#environment-variables)
I roughly calculated that the memory should be sufficient, but TensorRT shows that the memory is insufficient.

What's your tensorrtllm version?
I tried your configuration with batch_size=64/Input_len 1024/output len512 on H100 80GB, I managed to run your cmd mentioned above.
Would u please have a try with latest trt-llm?

I use tensorrt_llm==0.9.0.dev2024040900. Thanks, I will try it again.

Hi @rhmaaa , did you manage to run your case with latest code?
If so, could we close this ticket now?


many2many not work

Your Question
I have episode and user entity, the user has many episodes and episode has many episodes.
There are  three tables:
CREATE TABLE `episodes` (
  `id` bigint(20) unsigned NOT NULL AUTO_INCREMENT,
  `title` varchar(255) NOT NULL DEFAULT '',
);
CREATE TABLE `users` (
  `id` bigint(20) unsigned NOT NULL AUTO_INCREMENT,
  `nickname` varchar(255) NOT NULL DEFAULT '',
);

And I also create the relation table :
CREATE TABLE `episode_user_creative_relations` (
  `id` bigint(20) unsigned NOT NULL AUTO_INCREMENT,
  `user_id` bigint(20),
  `episode_id` bigint(20),
);

gen generator model just like :
// Episode mapped from table <episodes>
type Episode struct {
	ID                 int64        `gorm:"column:id;type:bigint(20) unsigned;primaryKey;autoIncrement:true" json:"id"`
	Title              string       `gorm:"column:title;type:varchar(255);not null;index:idx_title,priority:1" json:"title"`
	Authors            []*User       `gorm:"gorm:"many2many:episode_user_creative_relations"`
}
// User mapped from table <users>
type User struct {
	ID                int64      `gorm:"column:id;type:bigint(20);primaryKey;autoIncrement:true" json:"id"`
	Nickname          string     `gorm:"column:nickname;type:varchar(175);not null;uniqueIndex:uniq_idx_nickname,priority:1" json:"nickname"`
	Episodes          []*Episode `gorm:"gorm:"many2many:episode_user_creative_relations"`
}

But when run
q := Use(db).Episode
e, _ := q.WithContext(context.Background()).Where(q.ID.Eq(123)).Preload(q.Authors).Take()

I got error
[error] invalid field found for struct /project_name/data/model.User's field Episodes: define a valid foreign key for relations or implement the Valuer/Scanner interface
Expected answer
Why it not work?

🤔  seems like a issue about GORM tag,
did GEN generate tag with 2 gorm like gorm:"gorm:"many2many:episode_user_creative_relations" ??

🤔 seems like a issue about GORM tag, did GEN generate tag with 2 gorm like gorm:"gorm:"many2many:episode_user_creative_relations" ??

Yep

🤔 seems like a issue about GORM tag, did GEN generate tag with 2 gorm like gorm:"gorm:"many2many:episode_user_creative_relations" ??

Yep

try remove verbose gorm like: gorm:"many2many:episode_user_creative_relations"
And maybe you can show the generate code which config many to many relationships

show me your generate code?

Has the issue been solved?

After testing for many2many, i found no bug in both generation and query progress. So i will close this issue.
If has any question, you can feel free to reopen this issue.


for issue #145

Thanks Kasper! Before I can merge this in, I need you to sign a contributor agreement. It should only take a couple minutes.  Instructions here: https://github.com/nathanmarz/storm/wiki/Contributing-to-Storm

I will send you tomorrow :)
right now I am working on issue #111. I only need the cleanup of folders, then I am done.

added files for issue #111 as well


product: implement redirects to view by name and by metadata

Sometimes products are logically linked to products/applications/projectes/repositories in other system, i.e. gitlab. If the setup is such that their names are equal in both systems, it would be nice if a link to defect dojo could work by product name, i.e.
https://dojo/product/name/valentijn
In other situations people can use the custom fields in Defect Dojo to add a name+value to logically link the DD product to some other system, i.e. instance=valentijn. In that case it would be nice if a link to defect dojo could work by this custom field, i.e.:
https://dojo/product/meta/instance/valentijn
It's called meta because that's how DD stores the data.
This PR implements both. There may be more stuff coming around this as I am contemplating a badge system that could use similar urls.

fyi @christophe226


Can we not use any tile Layer?

Hi,
I wanted to not use tile Layers but when i try to just remove
tileLayer
property from the options a default tile layer is added I tried setting it to false and null but doesnt work.
Is there a way to do this?
Thanks
Anil

#1062 Please review this pull request for this issue.


Clone all objects passing in-to and out-of the in memory store

We've had some issues with stubbing journey tests via the memory handler, and they boil down to how the memory handler doesn't clone objects passing through it. This PR ensures all objects get cloned to allow us to mutate resources without effecting the data in the store.

Taking review ☝

Minor comment, otherwise it's looking good 👍

:+1: :shipit: I'm so happy you've implemented that MemoryStore._indexOf helper function. 🦄


Open pywinrm shell sessions with UTF-8 codepage

This PR implements a change to the shell initialisation process with pywinrm, utilizing the 65001 codepage, ensuring raw string responses are UTF-8 encoded.
Potential fix for #6034.

@nzlosh @cognifloyd re-based this PR and fixed the changelog conflicts and formatting standard to match recent entries, apologies for the delay!

Thank you for your help.


Feature Request: Dew Point in the History plot

The dew point is a really handy and descriptive measurement for the absolute humidity. I would like to see it as an option in the history tab as well.

We'll close these issues, as this repo is Deprecated and not maintained anymore.


Can't click or drag to select text when theme is using atom-text-editor

When theme is using atom-text-editor instead of the .editor class I can't click or drag to select any text. When I change back to the "soon to be depreciated" .editor class and reload Atom, I can select text again like normal.

I can't reproduce this issue on Atom v0.175.0-60970d6 on Mac OS X 10.10.1
I'm currently using the latest version of the atom-dark-ui theme. It uses the atom-text-editor selector and I have no problem selecting text. If you're talking about a syntax theme, I'm also using the updated selectors in my own advanced-railscasts-syntax theme (though you don't use atom-text-editor in a syntax theme) and everything is working fine.
Can you be more specific about exactly how you are using the atom-text-editor selector?

Hi lee-dohm,
If I change a theme from the old code, for example:
.editor {
  background-color: @syntax-background-color;
  color: @syntax-text-color;
}

to the new code version
atom-text-editor {
  background-color: @syntax-background-color;
  color: @syntax-text-color;
}

I can no longer highlight the text. I'm using Windows 8.1, so maybe it's an issue in windows or I'm getting the code wrong.

According to your comment here:
https://discuss.atom.io/t/use-the-atom-text-editor-tag-instead-of-the-editor-class/14286/7?u=leedohm
You are working on a syntax theme. The atom-text-editor selector is not appropriate for that use. See my post there for more information.

Hi lee-dohm, I replied back there, but I'll briefly explain here. I added :host to the following code example .editor, :host {... and that fixes one of the error messages, but I still get the "Use the atom-text-editor tag instead of the editor class." for the theme in Deprecation Cop.

Ok, since this issue is fixed, I'll close this here and we can continue working on the issue on Discuss.

Thanks! :-)


UI texture atlas support

Objective
This adds support for using texture atlas sprites in UI.  From discussions today in the ui-dev discord it seems this is a much wanted feature.
Solution
I created a new UI bundle that reuses the existing texture atlas infrastructure.  I wrap over the atlas sprite with a new type to prevent it from being drawn by the existing systems.
In extract I added new optional parameters on the query. If these components are present, the extracted ui nodes are given the texture atlas data, otherwise the original node is extracted.  I also added a new parameter to the extracted ui node to specify the uv value because there was no way around it.
In prepare if this uv parameter is set then it's used otherwise the same calculations are preformed.
This should have minimal performance impact because if texture atlas is not present then the exact same code path is followed and the new extracted field is just a Vec2.  Also there should be no unintended behavior changes because without the new components the systems write the extract same resulting data.
I also added an example showing the sprite working and a system to advance the animation on space bar presses.
Naming is hard and I would accept any feedback on the bundle name!  There might need to be some testing on how this works with ui systems like clipping but I don't foresee any problems.

Changelog

Added TextureAtlasImageBundle

New version now uses a standalone extract system and has a less confusing API by only using the parameters on UiTextureAtlasSprite that we actually use.

Also here is clipping working in the overflow example with flip x and y set and texture atlases being used in the scaling example.  This should satisfy the other concerns in the top level comment if I am understanding them correctly (blur is caused by linear sampling, it's intended and changed the same way pixel art is used elsewhere):

With Measure setting system added this should be ready to go.  I believe I have covered everything @ickshonpe requested and pointed out in their review.  From my testing, every feature I am aware of works and none of the existing examples are broken (and there shouldn't be a mechanism for this to affect them)

Thanks a lot for this!! I think this will make many users happy.
I have only left non blocking nits, feel free to ignore if you prefer.
Did you check if it works also when a normal UI node is a child of a node with an AtlasImageBundle?  Instead, use a regular NodeBundle with its BackgroundColor set to white and insert either the UiImage component or, to display atlas images with this PR, Handle<TextureAtlas> and UiTextureAtlasSprite`.
Maybe there needs to be a separate bundle for image nodes without a MeasureFunc as it's really unintuitive how the current API works.

Thanks a lot for this!! I think this will make many users happy.
I have only left non blocking nits, feel free to ignore if you prefer.
Did you check if it works also when a normal UI node is a child of a node with an AtlasImageBundle?  Instead, use a regular NodeBundle with its BackgroundColor set to white and insert either the UiImage component or, to display atlas images with this PR, Handle<TextureAtlas> and UiTextureAtlasSprite`.
Maybe there needs to be a separate bundle for image nodes without a MeasureFunc as it's really unintuitive how the current API works.

Ok I didn't know that. But if it's the same behaviour as ImageBundle then it's not relevant for this PR specifically. Maybe it's worth a separate issue then?

Thanks a lot for this!! I think this will make many users happy.
I have only left non blocking nits, feel free to ignore if you prefer.
Did you check if it works also when a normal UI node is a child of a node with an AtlasImageBundle?  Instead, use a regular NodeBundle with its BackgroundColor set to white and insert either the UiImage component or, to display atlas images with this PR, Handle<TextureAtlas> and UiTextureAtlasSprite. Maybe there needs to be a separate bundle for image nodes without a MeasureFunc` as it's really unintuitive how the current API works.

Ok I didn't know that. But if it's the same behaviour as ImageBundle then it's not relevant for this PR specifically. Maybe it's worth a separate issue then?

Oh yes definitely a separate issue, I didn't mean that as a suggestion for this PR

It looks good now. Just left some non-essential suggestions for the example you can apply if you like.

Considering #5103 may be merged soon, how does this compare to #5070 which is based on that Texture Atlas Rework PR? I personally find the API proposed in #5070 slightly more ergonomic.

Considering #5103 may be merged soon, how does this compare to #5070 which is based on that Texture Atlas Rework PR? I personally find the API proposed in #5070 slightly more ergonomic.

If #5103 is merged then I can rework this pr to use the new interface and then API will be identical, the only difference is they don't create a new bundle for texture atlas ui nodes which is debatable.
Looking at #5070 shows that it's current state is pretty similar to the first draft of this PR.  Since then there's been some work to ensure scaling, clipping and the measure systems all work with this PR and that is missing from #5070 (from a quick glance).  This makes me personally believe that after #5103 is merged this would be the correct PR to add for support in UI but I'm obviously biased toward my own work.
Also #5070 uses the existing extract system instead of creating a new one.  That was my original approach but we opted to change into a standalone system because of the complexity working with atlases added.  With the new API for atlases it might make sense to revert this back to the single system approach.

@mwbryant can you mention @ManevilleF in the initial post so we can remember to include their work in the release notes?


[3.10][BTS-1008]: Update react-autocomplete-input to create link to collection with single unique letter in its name

Scope & Purpose
3.10 Backport for #17279

[x] :hankey: Bugfix

Checklist

[x] Manually tested
[x] :book: CHANGELOG entry made

Related Information

[x] GitHub issue / Jira ticket: https://arangodb.atlassian.net/browse/BTS-1008

Is the package-lock.json change required? I don't see that file.. Does the build flow install packages and then run? If so, I think it's okay but can you please confirm this?


Conditional nested APIs based on features

Hi, I'm trying to set up utoipa with an api that could have varying sub-apis, depending on the features that are enabled.
For example (rust pseudo code),
#[derive(utoipa::OpenApi)]
#[openapi(
    nest(
        #[cfg(feature = "auth-api")]
        (path = "/auth", api = auth::api::Api),
        #[cfg(feature = "downloader-api")]
        (path = "/downloader", api = downloader::api::Api),
        #[cfg(feature = "library-api")]
        (path = "/library", api = library::api::Api),
    ),
)]
struct ApiDoc;

Is there any way to achieve this capability?
I attempted to reverse engineer the #openapi macro to get what I needed using OpenApiBuilder, but hit a wall with the NestedApiConfig part of it.
Thanks!

Macros cannot have nested macros. In order to nest conditionally based on feature flag you should have constant API to nest which is changed based on feature flag.
#[cfg(feature = "auth-api")]
#[derive(utoipa::OpenApi)]
#[openapi()]
struct NestedApi;

#[cfg(feature = "downloader-api")]
#[derive(utoipa::OpenApi)]
#[openapi()]
struct NestedApi;

#[derive(utoipa::OpenApi)]
#[openapi(
    nest(
        (path = "/api", api = NestedApi),
    ),
)]
struct ApiDoc;

Another way to do it is completely manually using the OpenApi::nest method.
Or perhaps you could try to have all the APIs nested but the feature flag defines whether empty one will be nested instead of the one with all the paths and schemas.
#[cfg(feature = "auth-api")]
#[derive(utoipa::OpenApi)]
#[openapi(
    components(....),
    paths(...),
)]
struct AuthApi;

#[cfg(not(feature = "auth-api"))]
#[derive(utoipa::OpenApi)]
#[openapi()]
struct AuthApi;

#[derive(utoipa::OpenApi)]
#[openapi(
    nest(
        (path = "/auth", api = AuthApi),
    ),
)]
struct ApiDoc;

The reason a constant API with flags to determine the nested API would not work very well for my use case is because I would have to define every permutation of the 12 APIs that would be able to be enabled (i.e. allow for enabling downloader-api, auth-api, player-api, but not the other 9).
The OpenApi::nest is exactly what I was looking for.
I was able to achieve the result I wanted like this:
let api = ApiDoc::openapi();

#[cfg(feature = "auth-api")]
let api = api.nest("/auth", auth::api::Api::openapi());
#[cfg(feature = "downloader-api")]
let api = api.nest("/downloader", downloader::api::Api::openapi());
#[cfg(feature = "player-api")]
let api = api.nest("/player", player::api::Api::openapi());

...

Thanks!


Support for x-displayName

What problem will this feature address?
Using human-readable tag names, instead of the coded ones.
Describe the solution you'd like
Tags can (with Redocly at least) be augmented with an x-displayName value, to give a human-readable value to the tags.
See https://redocly.com/docs/realm/author/reference/openapi-extensions/x-display-name
Describe alternatives you've considered
N/A
Additional context
No response

Will be supported on Fumadocs v14


Allow modification of Request fields after it is created

This is a fix for No contentLength sent in POST method #16 issue.
When we create StethoHttpClientRequest we set contentLength and other fields.
Unfortunately, HttpClientRequest is mutable and some fields are set later by the framework (for example contentLength).
Because of the underlying HttpClientRequest not being updated, we no longer send the updated contentLength to the server

Oh dang, that's no good! Thanks for the catch.


Python 3

Python 4 with typing hint
Needs to fix the tests

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Lucas Ventura seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

I signed it


Problem With very_low_preset.vpk

When I use it I can't see the chat, other people's health, other people's names and the killfeed. I reinstalled TF2, but the bug keeps coming up.

The very low preset intentionally does this to improve performance. If you don't want this, use the low preset.


[$1000] Web - Not Allowed sign when hovering through the reaction list

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:
Action Performed:

Go to chat with previous messages.
go to any message hover over the reaction list and notice that there is no 'Not Allowed' sign showing up.
Now click the message body and hover over the reaction list again. notice there is a 'Not Allowed' sign showing up.

Expected Result:
No 'Not Allowed' sign showing up.
Actual Result:
The 'Not Allowed' sign showing up.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: yes
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/8b161719-3799-4b19-81bf-705ea2dcb176
https://github.com/Expensify/App/assets/93399543/c684befc-ec75-4f6b-bbb2-17ca05a7d591
Expensify/Expensify Issue URL:
Issue reported by: @daveSeife
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687467815718419
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~018e36cd61ebc57ae7
Upwork Job ID:<PHONE_NUMBER>219315712
Last Price Increase: 2023-06-23

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Proposal
Please re-state the problem that we are trying to solve in this issue.
When a message in the chat is clicked, its reaction modal starts triggering the "not allowed" cursor when the space between reactions is hovered.
What is the root cause of that problem?
A recent change uncovered a bug in PressableWithFeedback.
onPress is not a required property, but it was treated like it was. If a PressableWithFeedback instance was pressed (clicked) but onPressed was undefined, an exception was thrown. Consequently, the logic to re-enable the component (meant for the case when props.onPressed returns a promise) wasn't fired and it was left in the disabled state.
A disabled pressable has the not-allowed cursor.
ReportActionItem isn't providing onPress to PressableWithSecondaryInteraction (which forwards it to PressableWithFeedback). ReportActionItem's PressableWithSecondaryInteraction is an ancestor to the reaction picker, so the space between the reaction entries inherits the cursor style.
What changes do you think we should make in order to solve the problem?
We should refactor the onPress callback passed to GenericPressable in PressableWithFeedback so it works correctly in all cases:

when props.onPress is not provided (it's undefined)
when props.onPress is provided and it's async (it returns a Promise)
when props.onPress is provided and it's not async (it returns something else, presumably undefined)

A simple implementation that satisfies these requirements could look like this:
onPress={(e) => {
    if (!props.onPress) return;

    const onPressResult = props.onPress(e);
    if (onPressResult instanceof Promise) {
        setDisabled(true);
        InteractionManager.runAfterInteractions(() => {
            onPressResult.finally(() => {
                setDisabled(props.disabled);
            });
        });
    }
}}

Removing deploy blocker label since I don't think we need to block deploy on such a minor issue. It seems you can still react to comments so it doesn't actual break any existing behavior.

I think this was already fixed in https://github.com/Expensify/App/pull/21341

@situchan
Oh, thanks for spotting that
I would argue that the bug I described in my root cause analysis is still there in some form. If props.onPress throws, the component would again lock itself in the disabled state. The implementation is also unnecessarily complex and bug-prone, firing runAfterInteractions for simple cases when onPress is not async.

Hmmm after retesting I agree that it was fixed in that other PR. This is a pretty minor flow that doesn't affect behavior so I'm gonna close it out. Thanks for your understanding @cubuspl42


python3Packages.pycfmodel: 0.16.0 -> 0.16.2

Motivation for this change
https://github.com/Skyscanner/pycfmodel/releases/tag/0.16.2
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 160771 run on x86_64-linux 1

2 packages built:

python310Packages.pycfmodel
python39Packages.pycfmodel


build: Raise freetype minimum to 2.10.0

freetype 2.10.0 dates from 2019, so we're still supporting 5 years back.
Previously, we enforced no minimum, so we're not sure how far back it would really work, but the earliest version we tested in CI was 2.8, which dated from 2018.
Add a build_Freetype.bash for easy setup for CI (and other users).
CI many cases need to build freetype, because the old CentOS 7 era freetype is now too old.
Remove some refrence output that was only needed for older freetype.

Amended this PR:

Rebased on top of the recently merged infrastructure that allows missing dependencies to build themselves locally.
Added such a builder for freetype.

Any objections?


Jv poc collector cluster config runtime control channel

Description
A detailed explanation of the changes in your PR.
Feel free to remove this section if it is overkill for your PR, and the title of your PR is sufficiently descriptive.
Checklist

[ ] Investigated and inspected CI test results
[ ] Updated documentation accordingly

Automated testing

[ ] Added unit tests
[ ] Added integration tests
[ ] Added regression tests

If any of these don't apply, please comment below.
Testing Performed
TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why you did not do so. (Valid reasons include "CI is sufficient" or "No testable changes")
In addition to reviewing your code, reviewers must also review your testing instructions, and make sure they are sufficient.
For more details, ref the Confluence page about this section.

Closing as we will use the existing channel for networkflows instead of creating a new one