[sysrst_ctrl] Potential Async FIFO issue

https://github.com/lowRISC/opentitan/blob/cdc9be6beb509fba7f41734b0d19a36e9b6a039e/hw/ip/sysrst_ctrl/rtl/sysrst_ctrl_combo.sv#L136-L146
https://github.com/lowRISC/opentitan/blob/cdc9be6beb509fba7f41734b0d19a36e9b6a039e/hw/ip/sysrst_ctrl/rtl/sysrst_ctrl_combo.sv#L164-L178
While reviewing the async code ( @cindychip  will report the issue for that part), I found a suspicious code inside sysrst_ctrl. If async fifo resets are connected to different reset signal, then the read pointer and write pointer can be diverted if only one reset is issued. It is generally recommended to have only one reset root for async (and use reset synchronizer to use in a different clock domain).
CC: @msfschaffner @tjaychen @cindychip

rst_ni is for the core clock, clk_i and rst_aon_ni is for the always-on clock, clk_aon_i. That's the convention as I understand it.
It's not clear to me why only one reset is recommended for the Async FIFO primitive.
-Eric

Async is some what special. Let's assume if only one clock domain asserts the reset signal if rptr/wptr are non-zero.
Then, rptr/wptr in that clock domain goes to zero. However, rptr/wptr in the other clock domain still remains same. Then right after out-of-reset, the two values are not same, which results that the logic assumes, it has non-empty entries inside.

On May 17, 2021, at 12:18 PM, esshiu @.***> wrote:
rst_ni is for the core clock, clk_i and rst_aon_ni is for the always-on clock, clk_aon_i. That's the convention as I understand it.
It's not clear to me why only one reset is recommended for the Async FIFO primitive.
-Eric
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/lowRISC/opentitan/issues/6573#issuecomment-842569735, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJDG3S3BR3GVT47GSSEBVTTOFTYPANCNFSM45BBAIEA.

In OpenTitan, is reset asynchronous or synchronous to each clock domain?
For an asynchronous reset scheme, are we supposed to see rst_aon_ni and
rst_ni asserted at the same time? For a synchronous reset scheme, I can
imagine a few cycle of delay between two clock domains. I don't see a real
problem at the assertion stage of the reset. Eventually, both clock domains
will be reset properly as the reset is a very long pulse. We usually need
to ensure the system comes out of reset synchronously.
Warm regards.
-Eric
On Mon, May 17, 2021 at 12:25 PM Eunchan Kim @.***>
wrote:

Async is some what special. Let's assume if only one clock domain asserts
the reset signal if rptr/wptr are non-zero.
Then, rptr/wptr in that clock domain goes to zero. However, rptr/wptr in
the other clock domain still remains same. Then right after out-of-reset,
the two values are not same, which results that the logic assumes, it has
non-empty entries inside.

On May 17, 2021, at 12:18 PM, esshiu @.***> wrote:
rst_ni is for the core clock, clk_i and rst_aon_ni is for the always-on
clock, clk_aon_i. That's the convention as I understand it.
It's not clear to me why only one reset is recommended for the Async
FIFO primitive.
-Eric
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <
https://github.com/lowRISC/opentitan/issues/6573#issuecomment-842569735>,
or unsubscribe <
https://github.com/notifications/unsubscribe-auth/AAJDG3S3BR3GVT47GSSEBVTTOFTYPANCNFSM45BBAIEA
.

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/lowRISC/opentitan/issues/6573#issuecomment-842573683,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANHFXI57LSPXATH55GJXKH3TOFURRANCNFSM45BBAIEA
.

On May 17, 2021, at 12:54 PM, esshiu @.***> wrote:
In OpenTitan, is reset asynchronous or synchronous to each clock domain?

It is asynchronous assertion, synchronous de-assertion

For an asynchronous reset scheme, are we supposed to see rst_aon_ni and
rst_ni asserted at the same time? For a synchronous reset scheme, I can
imagine a few cycle of delay between two clock domains. I don't see a real
problem at the assertion stage of the reset. Eventually, both clock domains
will be reset properly as the reset is a very long pulse. We usually need
to ensure the system comes out of reset synchronously.

Your assumption is the both resets assert. What I mentioned was to reset only one part. Let's assume AON alive and the peripheral clock domain is reset (maybe due to power down?). Then, the scenario I mentioned above can happen.

Warm regards.
-Eric
On Mon, May 17, 2021 at 12:25 PM Eunchan Kim @.***>
wrote:

Async is some what special. Let's assume if only one clock domain asserts
the reset signal if rptr/wptr are non-zero.
Then, rptr/wptr in that clock domain goes to zero. However, rptr/wptr in
the other clock domain still remains same. Then right after out-of-reset,
the two values are not same, which results that the logic assumes, it has
non-empty entries inside.

On May 17, 2021, at 12:18 PM, esshiu @.***> wrote:
rst_ni is for the core clock, clk_i and rst_aon_ni is for the always-on
clock, clk_aon_i. That's the convention as I understand it.
It's not clear to me why only one reset is recommended for the Async
FIFO primitive.
-Eric
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <
https://github.com/lowRISC/opentitan/issues/6573#issuecomment-842569735>,
or unsubscribe <
https://github.com/notifications/unsubscribe-auth/AAJDG3S3BR3GVT47GSSEBVTTOFTYPANCNFSM45BBAIEA
.

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/lowRISC/opentitan/issues/6573#issuecomment-842573683,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANHFXI57LSPXATH55GJXKH3TOFURRANCNFSM45BBAIEA
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/lowRISC/opentitan/issues/6573#issuecomment-842589243, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJDG3X3L6YX2NBWTK5T3B3TOFX7ZANCNFSM45BBAIEA.

Good question on the sleep state.
I talked to Andrey(Security FW lead) on the expected OpenTitan reset
behavior. We expect all the registers regardless of its clock domain to be
reset properly. We need to ensure that the reset signals for all the clock
domains are asserted when the system wants to reset OpenTitan. For example,
sysrst_ctrl's combo detection logic will send a wakeup signal to pwrmgr to
enable all the clocks so that rstmgr can propagate properly. Add Tim
explicitly.
Warm regards.
-Eric
On Mon, May 17, 2021 at 2:26 PM Eunchan Kim @.***>
wrote:

On May 17, 2021, at 12:54 PM, esshiu @.***> wrote:
In OpenTitan, is reset asynchronous or synchronous to each clock domain?

It is asynchronous assertion, synchronous de-assertion

For an asynchronous reset scheme, are we supposed to see rst_aon_ni and
rst_ni asserted at the same time? For a synchronous reset scheme, I can
imagine a few cycle of delay between two clock domains. I don't see a
real
problem at the assertion stage of the reset. Eventually, both clock
domains
will be reset properly as the reset is a very long pulse. We usually need
to ensure the system comes out of reset synchronously.

Your assumption is the both resets assert. What I mentioned was to reset
only one part. Let's assume AON alive and the peripheral clock domain is
reset (maybe due to power down?). Then, the scenario I mentioned above can
happen.

Warm regards.
-Eric
On Mon, May 17, 2021 at 12:25 PM Eunchan Kim @.***>
wrote:

Async is some what special. Let's assume if only one clock domain
asserts
the reset signal if rptr/wptr are non-zero.
Then, rptr/wptr in that clock domain goes to zero. However, rptr/wptr
in
the other clock domain still remains same. Then right after
out-of-reset,
the two values are not same, which results that the logic assumes, it
has
non-empty entries inside.

On May 17, 2021, at 12:18 PM, esshiu @.***> wrote:
rst_ni is for the core clock, clk_i and rst_aon_ni is for the
always-on
clock, clk_aon_i. That's the convention as I understand it.
It's not clear to me why only one reset is recommended for the Async
FIFO primitive.
-Eric
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <

https://github.com/lowRISC/opentitan/issues/6573#issuecomment-842569735>,

or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AAJDG3S3BR3GVT47GSSEBVTTOFTYPANCNFSM45BBAIEA

.

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<
https://github.com/lowRISC/opentitan/issues/6573#issuecomment-842573683>,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/ANHFXI57LSPXATH55GJXKH3TOFURRANCNFSM45BBAIEA

.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <
https://github.com/lowRISC/opentitan/issues/6573#issuecomment-842589243>,
or unsubscribe <
https://github.com/notifications/unsubscribe-auth/AAJDG3X3L6YX2NBWTK5T3B3TOFX7ZANCNFSM45BBAIEA
.

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/lowRISC/opentitan/issues/6573#issuecomment-842652287,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANHFXI47UGY254I2Z3UT55TTOGCZ3ANCNFSM45BBAIEA
.

I think you misunderstood my previous comment.
There shall be a case that AON alive and other part (peripheral clock domain) is powered down (+ in reset). That scenario introduces disparity between the pointers in IO_DIV4 domain and them in AON domain.
So, I suggest to use same reset line (but with the synchronizer of course) for the two resets inside the async FIFO.
Using separate resets for Async FIFO is only okay when both resets are asserted together. However, OpenTitan's deep sleep and wake up are not the case.

On May 18, 2021, at 2:07 PM, esshiu @.***> wrote:
Good question on the sleep state.
I talked to Andrey(Security FW lead) on the expected OpenTitan reset
behavior. We expect all the registers regardless of its clock domain to be
reset properly. We need to ensure that the reset signals for all the clock
domains are asserted when the system wants to reset OpenTitan. For example,
sysrst_ctrl's combo detection logic will send a wakeup signal to pwrmgr to
enable all the clocks so that rstmgr can propagate properly. Add Tim
explicitly.
Warm regards.
-Eric
On Mon, May 17, 2021 at 2:26 PM Eunchan Kim @.***>
wrote:

On May 17, 2021, at 12:54 PM, esshiu @.***> wrote:
In OpenTitan, is reset asynchronous or synchronous to each clock domain?

It is asynchronous assertion, synchronous de-assertion

For an asynchronous reset scheme, are we supposed to see rst_aon_ni and
rst_ni asserted at the same time? For a synchronous reset scheme, I can
imagine a few cycle of delay between two clock domains. I don't see a
real
problem at the assertion stage of the reset. Eventually, both clock
domains
will be reset properly as the reset is a very long pulse. We usually need
to ensure the system comes out of reset synchronously.

Your assumption is the both resets assert. What I mentioned was to reset
only one part. Let's assume AON alive and the peripheral clock domain is
reset (maybe due to power down?). Then, the scenario I mentioned above can
happen.

Warm regards.
-Eric
On Mon, May 17, 2021 at 12:25 PM Eunchan Kim @.***>
wrote:

Async is some what special. Let's assume if only one clock domain
asserts
the reset signal if rptr/wptr are non-zero.
Then, rptr/wptr in that clock domain goes to zero. However, rptr/wptr
in
the other clock domain still remains same. Then right after
out-of-reset,
the two values are not same, which results that the logic assumes, it
has
non-empty entries inside.

On May 17, 2021, at 12:18 PM, esshiu @.***> wrote:
rst_ni is for the core clock, clk_i and rst_aon_ni is for the
always-on
clock, clk_aon_i. That's the convention as I understand it.
It's not clear to me why only one reset is recommended for the Async
FIFO primitive.
-Eric
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <

https://github.com/lowRISC/opentitan/issues/6573#issuecomment-842569735>,

or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AAJDG3S3BR3GVT47GSSEBVTTOFTYPANCNFSM45BBAIEA

.

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<
https://github.com/lowRISC/opentitan/issues/6573#issuecomment-842573683>,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/ANHFXI57LSPXATH55GJXKH3TOFURRANCNFSM45BBAIEA

.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <
https://github.com/lowRISC/opentitan/issues/6573#issuecomment-842589243>,
or unsubscribe <
https://github.com/notifications/unsubscribe-auth/AAJDG3X3L6YX2NBWTK5T3B3TOFX7ZANCNFSM45BBAIEA
.

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/lowRISC/opentitan/issues/6573#issuecomment-842652287,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANHFXI47UGY254I2Z3UT55TTOGCZ3ANCNFSM45BBAIEA
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/lowRISC/opentitan/issues/6573#issuecomment-843564094, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJDG3QC6ASTJ2PJGP3RAWTTOLJKRANCNFSM45BBAIEA.

I'd recommend a GVC meeting between you, Tim, Andrey and me on the expected
reset behavior. It seems we have some disconnect between the system and
opentitan's state.
-Eric
On Tue, May 18, 2021 at 2:54 PM Eunchan Kim @.***>
wrote:

I think you misunderstood my previous comment.
There shall be a case that AON alive and other part (peripheral clock
domain) is powered down (+ in reset). That scenario introduces disparity
between the pointers in IO_DIV4 domain and them in AON domain.
So, I suggest to use same reset line (but with the synchronizer of course)
for the two resets inside the async FIFO.
Using separate resets for Async FIFO is only okay when both resets are
asserted together. However, OpenTitan's deep sleep and wake up are not the
case.

On May 18, 2021, at 2:07 PM, esshiu @.***> wrote:
Good question on the sleep state.
I talked to Andrey(Security FW lead) on the expected OpenTitan reset
behavior. We expect all the registers regardless of its clock domain to
be
reset properly. We need to ensure that the reset signals for all the
clock
domains are asserted when the system wants to reset OpenTitan. For
example,
sysrst_ctrl's combo detection logic will send a wakeup signal to pwrmgr
to
enable all the clocks so that rstmgr can propagate properly. Add Tim
explicitly.
Warm regards.
-Eric
On Mon, May 17, 2021 at 2:26 PM Eunchan Kim @.***>
wrote:

On May 17, 2021, at 12:54 PM, esshiu @.***> wrote:
In OpenTitan, is reset asynchronous or synchronous to each clock
domain?

It is asynchronous assertion, synchronous de-assertion

For an asynchronous reset scheme, are we supposed to see rst_aon_ni
and
rst_ni asserted at the same time? For a synchronous reset scheme, I
can
imagine a few cycle of delay between two clock domains. I don't see a
real
problem at the assertion stage of the reset. Eventually, both clock
domains
will be reset properly as the reset is a very long pulse. We usually
need
to ensure the system comes out of reset synchronously.

Your assumption is the both resets assert. What I mentioned was to
reset
only one part. Let's assume AON alive and the peripheral clock domain
is
reset (maybe due to power down?). Then, the scenario I mentioned above
can
happen.

Warm regards.
-Eric
On Mon, May 17, 2021 at 12:25 PM Eunchan Kim @.***>
wrote:

Async is some what special. Let's assume if only one clock domain
asserts
the reset signal if rptr/wptr are non-zero.
Then, rptr/wptr in that clock domain goes to zero. However,
rptr/wptr
in
the other clock domain still remains same. Then right after
out-of-reset,
the two values are not same, which results that the logic assumes,
it
has
non-empty entries inside.

On May 17, 2021, at 12:18 PM, esshiu @.***> wrote:
rst_ni is for the core clock, clk_i and rst_aon_ni is for the
always-on
clock, clk_aon_i. That's the convention as I understand it.
It's not clear to me why only one reset is recommended for the
Async
FIFO primitive.
-Eric
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <

https://github.com/lowRISC/opentitan/issues/6573#issuecomment-842569735>,

or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AAJDG3S3BR3GVT47GSSEBVTTOFTYPANCNFSM45BBAIEA

.

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<

https://github.com/lowRISC/opentitan/issues/6573#issuecomment-842573683>,

or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/ANHFXI57LSPXATH55GJXKH3TOFURRANCNFSM45BBAIEA

.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <

https://github.com/lowRISC/opentitan/issues/6573#issuecomment-842589243>,

or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AAJDG3X3L6YX2NBWTK5T3B3TOFX7ZANCNFSM45BBAIEA

.

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<
https://github.com/lowRISC/opentitan/issues/6573#issuecomment-842652287>,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/ANHFXI47UGY254I2Z3UT55TTOGCZ3ANCNFSM45BBAIEA

.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <
https://github.com/lowRISC/opentitan/issues/6573#issuecomment-843564094>,
or unsubscribe <
https://github.com/notifications/unsubscribe-auth/AAJDG3QC6ASTJ2PJGP3RAWTTOLJKRANCNFSM45BBAIEA
.

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/lowRISC/opentitan/issues/6573#issuecomment-843591307,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANHFXIYRQR7NK6KEUNDIEELTOLOYBANCNFSM45BBAIEA
.

sorry i should clarify one thing.
sysrst_ctrl is an always on module.  For some of the resets, there is both an always on and an non-always-on version for it.
See here.
So in theory what this means is that both resets are considered always on, so we shoudn't have the case in low power for example where one is reset but the other is not (if you guys see this is, this is definitely a bug that needs to be investigated).

All the async FIFOs are removed and replaced with the new (autogenerated) CSR CDCs in this PR: https://github.com/lowRISC/opentitan/pull/7704
Hence, i think @eunchan's concern should be addressed now for sysrst_ctrl.
Ok if I close this issue?

sgtm!
On Tue, Aug 17, 2021 at 4:21 PM Michael Schaffner @.***>
wrote:

All the async FIFOs are removed and replaced with the new (autogenerated)
CSR CDCs in this PR: #7704
https://github.com/lowRISC/opentitan/pull/7704
Hence, i think @eunchan https://github.com/eunchan's concern should be
addressed now for sysrst_ctrl.
Ok if I close this issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lowRISC/opentitan/issues/6573#issuecomment-900694982,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAH2RSV2UHQFEHMEUKYFT2DT5LVF7ANCNFSM45BBAIEA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.


Narrow file spacing after backup restore (win11)

I used the program to delete the groups and set them to "none" but I noticed that the spacing between files is narrow while in wimdows 11 it was not like that. I then restored it to the original state again via the program but the spacing remained narrow and I don't like it. Is it possible to have an original Windows 11 Pro INI file in order to restore everything to its original state?

The one in the photo is the large space between the Windows 11 files I had before using the program!

As per the Quick Start Guide, you're expected to check the items in the Options menu and ensure that they're set to your liking:
Step 5: Check and Set Your Desired Options
Windows 11 Compact View is enabled by default because that's what most power users seem to want, but you can just uncheck it like this:

Also note that the classic context menu is enabled by default. Again, just uncheck it if you want the Windows 11 context menu.
As for the Restore feature, it only restores the folder views. Options have to be set as you like in the Options menu.


modify "no support" note

Signed-off-by: Xvv-v<EMAIL_ADDRESS>
What type of PR is this?
/kind bug

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #214
Special notes for reviewers:

Does this PR introduced a user-facing change?

Additional documentation, usage docs, etc.:

Codecov Report

Merging #215 (d042dd8) into master (5db005f) will not change coverage.
The diff coverage is 0.00%.


NCIT ontology lookup uses OBO format ID with OWL term source

Describe the Bug
When using the samplesheet editor to add an NCIT ontology term, it looks up an obolibrary term ID. However, the samplesheet seems to use an OWL-type Term Source URL (https://bioportal.bioontology.org/ontologies/NCIT) to create the external links. This leads to broken links being created.
How to Reproduce

Edit samplesheet using the online editor.
Use ontology lookup to add term from NCIT ontology.
Finish editing.
Click resulting link.

Expected Behavior

Use OWL-type ontology ID for NCIT or
use OBO-type Term Source URL.

(Not entirely sure how ontologies work in SODAR tbh.)

Thanks for the report, This should be fixable by adding NCIT to SHEETS_ONTOLOGY_URL_SKIP. Also it's not a bug since this is simply a site configuration issue :)


Logical operations

Hello,
How does one perform logical operations, such as AND/OR/NOT? I'm assuming that two new components have to be introduced, one for NOT and another one for AND/OR/XOR. But perhaps I'm mistaken and there other ways of accomplishing the same thing without having new components.
In case it helps, in my task, I am writing a flow which starts out as two branches. The last actor of each branch produces either a "true" value or a "false" value. I need to merge the results of these two branches and use it as an input to the "select" port of std.Deselect().

Hey.
Apologies for the delay.
I'm unsure if it's possible to do it using the rather meager selection of actors currently available, so the easiest way is probably to write a couple of new ones.
Cheers,
// Ola
-----Original Message-----
From: Ali Razeen<EMAIL_ADDRESS>Received: måndag, 13 jul 2015, 19:59
To: EricssonResearch/calvin-base<EMAIL_ADDRESS>Subject: [calvin-base] Logical operations (#4)
Hello,
How does one perform logical operations, such as AND/OR/NOT? I'm assuming that two new components have to be introduced, one for NOT and another one for AND/OR/XOR. But perhaps I'm mistaken and there other ways of accomplishing the same thing without having new components.
In case it helps, in my task, I am writing a flow which starts out as two branches. The last actor of each branch produces either a "true" value or a "false" value. I need to merge the results of these two branches and use it as an input to the "select" port of std.Deselect().
—
Reply to this email directly or view it on GitHubhttps://github.com/EricssonResearch/calvin-base/issues/4.

With the introduction of the Compute and Evaulate actors in the most recent version (0.7), this should be quite straightforward to implement. Sorry for the delay.


Only shows one icon in the ribbon even if multiple journals have 'show in ribbon'

I have multiple journals, and I'm using daily notes for both of them. I have selected 'show in ribbon' for them both, but only 1 icon appears at a time.

looks like this happens if ribbon tooltip is not defined in both journals
try changing it in one of journal - this should work as workaround for now
I'll fix this as part of next release

The tooltip is defined on both journals

is it probably the same in both journals? because this could also lead to such problem

Nope, they have different icons

Field on screenshot is Ribbon icon
What more important in this case is - the next field Ribbon tooltip - it should be different for both icons to appear in ribbon

Awesome, that worked, thanks!!

One thing I noticed - changes don't happen right away. I have to restart obsidian each time.

This is limitation of obsidian itself unfortunately


New: Subdomain redirection

Description
Routing ability to redirect http://hourly.price-calc.com (or http://hourly.localhost:8080/http://hourly.localhost:5000) to http://price-calc.com/hourly, same goes for http://project... and http://value...
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Related Issue

Motivation and Context

I wanted to experiment with subdomains and had a Medium article "Managing wildcard subdomains with Vue router" to check off (which showed a much more restrictive and hardcoded way).
How Has This Been Tested?

Testing on localhost:8080.
Screenshots (if appropriate):
Checklist:

[ ] I have updated the documentation (if required).
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.
[ ] I added a picture of a cute animal cause it's fun

View rendered README.md

Let's see if Netlify doesn't fail when checking that on dev.


Fix NPE when configuring FileTree's builtBy by map

Thank you very much for your contribution. We highly appreciate the time
and effort you put into pull request. Before you submit the pull request,
please review the Contribution Guidelines.
Make sure you check the following boxes.
For all changes:

[x] Sign the Gradle CLA.

For all non-trivial changes that modify the behavior or public API:

[ ] Before submitting a pull request, you started a discussion on the
Gradle developer list
or can reference a JIRA issue.

[x] You considered writing a design document. A design document can be
brief but explains the use case or problem you are trying to solve,
touches on the planned implementation approach as well as the test cases
that verify the behavior. Optimally, design documents should be submitted
as a separate pull request. You can find samples
in the Gradle GitHub repository. Please let us know if you need help with
creating the design document. We are happy to help!

[x] The pull request contains an appropriate level of unit and integration
test coverage to verify the behavior. Before submitting the pull request
you ran a build on your local machine via the command ./gradlew quickCheck
and the tests for the modified module.

[x] The pull request updates the Gradle documentation like user guide,
DSL reference and Javadocs where applicable.

fileTree(dir: 'classes', builtBy: ['compile']) is valid, and should not break

FYI I have signed the CLA a long time ago, have already submitted a PR back in 2.8
As for this NPE, I have checked it to be present at least since 2.8, haven't checked further back.

Hi @jsotuyod, thanks for your contribution!
I can confirm the issue and that the provided fix works.
See also https://issues.gradle.org/browse/GRADLE-3444


[libsai] Make helper function for bulk object create and removal to simplify libsai generation.

All bulk create/removal objects SAI implementation is essentially the same. Hence making some helper functions for simplify the generated libsai.
With more changes coming, we should be able to make the libsai templates and generations more maintainable.

thanks Junhua!


Implement pacing

As discussed in the recovery document.

Of interest is the recently introduced Linux SO_TXTIME cmsg, which allows pacing to be offloaded to the kernel or even network hardware on a correctly configured system.

An efficient software implementation could work by packets in regular bursts of at most a certain size, rather than attempting to space individual packets out perfectly.

As of draft 24 this is now required:

Sending multiple packets into the network without any delay between them creates a packet burst that might cause short-term congestion and losses. Implementations MUST either use pacing or limit such bursts to the initial congestion window

The draft now further requires that bursts be limited specifically to the size of the initial congestion window, and suggests pacing by providing a burst budget that can reach at most the initial congestion window, refills continuously at the pacing rate, and starts full.


Checkpointing broken in master

This test is supposed to compare the checkpointed and non-checkpointed implementations to ensure they produce the same result. However, it is running in double precision and only checking up to 1e-5 (default rtol of np.allclose())
It is, obviously, meaningless to run in double precision and only ensure correctness up to 5 significant figures. The correctness of Checkpointing pretty much relies on this test passing, and if the test is broken, the feature is most likely broken too.
Detailed investigation ongoing.

Update. Dynamic scheduling seems to be the culprit here. I'll push an updated test shortly that disables dynamic scheduling for the test, and makes the numerical comparison tighter.

Another potential culprit: fast math

During #1412 we realised that the test only passes with tighter bounds with opt=('advanced', {'par-dynamic-work :1000}) does not work. Only works with opt=('noop', {'par-dynamic-work :1000}). Could be a bug in blocking or one of the other advanced passes. More investigation required.

The generated code for for the gradient where the save case generates the code:
        grad[x + 1][y + 1] += -(-2.0F*u[t0][x + 4][y + 4] + u[t1][x + 4][y + 4] + u[t2][x + 4][y + 4])*v[t0][x + 4][y + 4]/(dt*dt);

and the checkpointing code generates the code
        grad[x + 1][y + 1] += -(-2.0F*u[time][x + 4][y + 4] + u[time - 1][x + 4][y + 4] + u[time + 1][x + 4][y + 4])*v[t0][x + 4][y + 4]/(dt*dt);

The source of the roundoff error that causes the test to fail is that the terms u[t1][x + 4][y + 4] + u[t2][x + 4][y + 4] and u[time - 1][x + 4][y + 4] + u[time + 1][x + 4][y + 4] are actually swapped relative to each other; ie the additions are carried out in a different order in both cases. By flipping the order of these two terms in the second case (ie u[time + 1][x + 4][y + 4] + u[time - 1][x + 4][y + 4]) the two gradients become bitwise reproducible.

addressed by #1438


Version report

Which version are you using?
1.9.2
Which operating system are you using?
Linux arm64 standard
Describe how to replicate the issue
Trying to check version with
./mediamtx --version
and it responds with
[118 49 46 57 46 50]
expecting to see
1.9.2
Server logs
No response
Network dump
No response

Thanks for noticing, this is fixed by #3847


keybinding gets lost frequently

Keyboard shortcut gets lost easily after rebind. In my case, I remapped navigateForward/Back to cmd+]/cmd+[, but it get's lost frequently without knowing why, and when I open binding window, the binding is there, but not shown after menu item.

Please attach you keybindings.json. (F1 > Preferences: Open Keyboard Shortcuts (JSON))


Allow installing requirements from the root of a project, not just src

Having requirements getting mixed in with source code got quite confusing in the Flask app (https://github.com/wellcometrust/platform/pull/2657); this allows us to define requirements outside the src directory, which is slightly cleaner.

Replaced by #44.


Change PCS usage of ETCD to reduce size

Summary and Scope
PCS is slowing filling up ETCD when there are a large number of transactions. This newer PCS improves record retention and storage size of completed transactions.
Issues and Related PRs

Resolves CASMTRIAGE-6281

Testing
Tested on:

Local development environment

Test description:
Verified transactions were able to write and be retrieved from ETCD without error.

Were the install/upgrade-based validation checks/tests run (goss tests/install-validation doc)? N
Were continuous integration tests run? If not, why? Y
Was upgrade tested? If not, why? N - local simulation environment
Was downgrade tested? If not, why? N - local simulation environment
Were new tests (or test issues/Jiras) created for this change? N

Risks and Mitigations
Not executed on real hardware.
Reverting to an older PCS after this version is used will temporarily make the transaction table in ETCD un-retrievable. Only newer transactions would be available.
Pull Request Checklist

[X] Version number(s) incremented, if applicable
[X] Copyrights updated
[X] License file intact
[X] Target branch correct
[X] Testing is appropriate and complete, if applicable
[X] HPC Product Announcement prepared, if applicable

Superseded by https://github.com/Cray-HPE/csm/pull/3106


Feat: Replace decorators for skipping tests with AntaTestFilter

Today we are using decorators on tests that should be skipped. We should leverage AntaTestFilter class instead for more flexibility.
Ex:
class VerifyBGPIPv4UnicastCount(AntaTest):
    test_filters = [SkipBGPFilter(family="ipv4")]

class SkipBGPFilter(AntaTestFilter):
    def __init__(self, family: str) -> None:
        """
        Class initialization with the BGP address family to verify.
        """
        self.family = family

#230


Fix initializing PumpProbePulses with an instrument string

This was broken at some point during or after development when static properties got moved to helper functions, and got missed in the tests. This PR adds a test for it.
I also merged helper functions in extra.components._common into extra.components.utils... I suspect we added such modules in different PRs 🤷

LGTM

Thanks!


Return address, tx_hash from Account.deploy_contract

Fixes #307

looks good! addressing Andrew's comment should be enough

but deploy account did change its return value


USB JTAG on C3, timeout errors

I can't get the USB JTAG on the C3 to work on my ELF file. Likely because it is 50MB. I keep getting timeout errors.
jonsmirl@ares:~$ ls -l /home/jonsmirl/aosp/esp-matter/examples/jds/build/blemesh_bridge.elf
-rwxrwxr-x 1 jonsmirl jonsmirl 47235876 Jul 30 20:47 /home/jonsmirl/aosp/esp-matter/examples/jds/build/blemesh_bridge.elf
jonsmirl@ares:~$

So how do I get rid of all of the internal symbols from the CHIP library?
Any other ideas on how to get JTAG working?

If you build openocd from source, https://github.com/espressif/openocd-esp32, it will work.
The openocd in IDF 4.4.1 does not work on this large C3 file.

This needs to be added to the docs for this project.
You need to make up a version number for bootstrap before it will run....
I randomly picked 9.5, probably some script to do this, don't know what it is.
diff --git a/configure.ac b/configure.ac
index f0324a651..a146f1962 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1,7 +1,7 @@
SPDX-License-Identifier: GPL-2.0-or-later
AC_PREREQ(2.64)
-AC_INIT([openocd], [ ],
+AC_INIT([openocd], [9.5 ],
[OpenOCD Mailing List<EMAIL_ADDRESS>AC_CONFIG_SRCDIR([src/openocd.c])
AC_CONFIG_AUX_DIR([.])

Maybe you can push out an IDF 4.4.2 with this fixed openocd so other people don't need to spend a day debugging this.

@jonsmirl have just pushed 4.4.2 yesterday: https://github.com/espressif/esp-idf/tree/v4.4.2, it comes with the newer OpenOCD version (v0.11.0-esp32-20220411).

Thanks @igrr. We will officially move to v4.4.2 soon, for Matter.

Will close this issue as the original problem is resolved


plots with no data render as a black square

Plots look odd until data is plotted
var plt = new ScottPlot.Plot(400, 300);
plt.Title("empty plot");
plt.SaveFig("test.png");

This is jarring for user controls because as soon as you cick/drag, grid lines and tick labels appear.
Interestingly, just setting the axis solves this.
plt.AxisAuto();

Ahh! I think https://github.com/swharden/ScottPlot/commit/6972d32977abab05a468a769729c4d8b30f956dc may have been there for a reason. The demo doesn't auto-axis properly when it starts now:


Update the nightly scripts

This PR updates the nightly bash scripts running in turing and navajo to 5.00.0+domains and 5.00.0+multicore

The original PR message

5.00.0+domains and 5.00.0+multicore

seems incorrect.
There are no 5.00.0+domains and 5.00.0+multicore anymore. Only 5.0+trunk and 5.0+stable.
Also, in the OCaml developer meeting, it was decided that we would go with 5.0 instead of 5.00. Perhaps useful to replace strings that are 5.00 to 5.0 .

Closing this since these scripts would no longer be used.


Adding in a submit group page

Opening a PR to see the deployment

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Spin Config doesn't really explain allowed_http_hosts.

https://developer.fermyon.com/spin/configuration
The allowed_http_hosts key isn't really explained there. There's no mention of insecure, and no discussion of whether wildcard domains are supported. Nor does it give an example of the format (e.g. do I add the scheme or not? Do I need port for non-80 ports?).

ref https://github.com/fermyon/spin/issues/930

For reference when we come to write this: the behaviour is described in https://github.com/fermyon/spin/pull/727

See linear.app's Developer Docs team for more information.


Issue Number: # 308 Aligned the menu section

Aligned the items of the menu section in a beautiful manner.
before:

After:

@sunny0625  Kindly review the pr and mention the label

#308

solve conflicts.


[BEAM-11167] Updates dill package

#15172 looked stale, but would be a great change for Beam in codebases already using more modern dill.
I would like to revive it with the change requested by @aaltay and close this out if it's not too difficult to do so!

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run Python PreCommit

@chamikaramj @aaltay does this need additional changes to make it acceptable?

Thanks. LGTM.
We can merge if tests pass.

Run Python PostCommit

Run Python Dataflow ValidatesRunner

Run Python 3.8 PostCommit

@Huntrr have you had a chance to look at failing tests?

@Huntrr have you had a chance to look at failing tests?

No not yet :( I got stuck trying to set up the repo locally. Aiming to try again this week.

@Huntrr have you had a chance to look at failing tests?

No not yet :( I got stuck trying to set up the repo locally. Aiming to try again this week.
Do you want to close and I can reopen when I've got these tests working?

We can keep it open if you are still working on it.

Any update on this?

Any update on this? Should we close it?

Run Python 3.8 PostCommit

@ryanthompson591 - do you want me to re-open the PR for running tests?

I think we can leave this one closed as some of the changes have become outdated. I made a new PR for this.


Issue when starting sniper

When starting py sniper with py snipe.py and error occurs with
File "snipe.py", line 41
logging.info(f"{Fore.WHITE}[{Fore.BLUE}info{Fore.WHITE}] {Fore.RESET}{message}")
^
SyntaxError: invalid syntax

don't run it with python 2.

This is not a problem with the sniper, which is why I closed this issue.


Handle Multi-Channel Audio Files Better

A current problem I am dealing with is multi-channel audio files.  The current method for handling this with fastai_audio is to compress them all into one channel, but I think this could be much more valuable to keep separately especially when multiple people are having a conversation and are being recorded on different channels.  How should fastai handle this without compressing these down into one channel?
My thought is that each channel would be its own tensor so if there is a single channel, the shape would be (1,# of frames) when you added the second channel in, it would be (2,# of frames).  This would allow us to easily keep everything on the same timeline and make it generalizable to N channels.  How many places would this need to be handled?  I will start working through this if it is something that has interest.  My goal is to not have different code for 1-channel vs N-channel processors so I would want it to handle that the same way if possible.  Interested in getting feedback from other people that are familiar with the library.

I just looked to see how torchaudio handles 1-channel audio and they keep the channel so I think that would make a lot of sense for us to move towards.

This is the test that I looked at for this:
tst,sr = torchaudio.load("data/clips/data/.cache/sh-all_20-200/common_voice_en_18752090.mp3-7650a11c561d129f5a343da8dc89affb/0.wav")

print(tst.shape)

tst2 = AudioItem.open("data/clips/data/.cache/sh-all_20-200/common_voice_en_18752090.mp3-7650a11c561d129f5a343da8dc89affb/0.wav")

print(tst2.data.shape)

Output:
torch.Size([1, 124800])
torch.Size([124800])

Definitely worth working on, we compressed to 1 channel solely as a short-term fix with plans to make it work for multichannel in future, it was just never priority as most datasets are mono and compressing stereo to mono doesn't seem to cause much loss. The ideal is to handle multichannel as you said, in multiple channels, with a smooth user experience. That would ideally be same code for mono/non-mono datasets, and, as one of the goals of the library is making things as easy as possible for people who aren't experts, make it so even if the user doesn't know the difference between multi-channel/mono, it still functions well.
Please keep us posted on your progress, and I'll keep it in mind when looking through the codebase.

Now that PR #35 is added we should be able to add in multichannel functionality. Changes needed will be

replacing DownmixMono with a function taking the channel mean of the various channels.
Adding a mono boolean to the AudioConfig for downmixing to one channel for those that still want to do so
Fixing all the things that multiple channel audio will break in terms of displaying spectrograms, spectrogram augmentations like tfm_freq_mask, tfm_time_mask and tfm_sg_roll and so on.

Is this something you want to work on @kevinbird15? If so I'm happy to help provide support.

I think I'll shadow @kevinbird15 on this one to get my feet wet :)

Do we still need downmixMono?

I believe DownmixMono will still work for our task.  I think the function would be better replaced in the upgrade to torchaudio 0.3.0 PR since that is where it actually breaks.
The mono flag already exists and is called downmix.  We will make sure that it acts as expected.
The transforms is where a lot of the work will be for this.  Working through these changes now.


[AutoPR monitor/resource-manager] Add dynamic metric alert api

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/5677

This PR has been merged into https://github.com/Azure/azure-sdk-for-js/pull/2600


support Kanji

Hi,
would you consider basing the generator library on this instead?
https://github.com/kazuhikoarase/qrcode-generator
it support Kanji and various other modes and is otherwise identical

Hello, thank you for the suggestion. Unfortunately, I don't know Kanji. Can you please provide a test case? I tried my library and the one you suggested with this string 教育漢字 copied from wikipedia and both libraries showed me the same (wrong) text when I read the generated text with my iPhone default camera app.

hmm..., this is working fine for me
const typeNumber = 0;  // auto
const errorCorrectionLevel = 'L';
const qrValue = `敦煌天空的沙礫帶著我們的記憶`;
const qr = new qrcode(typeNumber, errorCorrectionLevel);
qr.addData(qrValue, 'Kanji');  // Kanji, important
qr.make()
svg = qr.createSVGTag();

did you also import the file "qrcode_SJIS.js" for the Kanji support?
there are some minor characters not supported though

I can't get it to work in a Node.js file. How dow you import the qrcode_SJIS.js file?
When I do
const qrcode = require("qrcode-generator")
require("qrcode-generator/qrcode_SJIS")
const qr = qrcode(0, "L");
qr.addData(`敦煌天空的沙礫帶著我們的記憶`, `Kanji`);
qr.make();
console.log(qr.createSvgTag());

it dies on an reference error in the qrcode_SJIS saying that qrcode is not defined 😕

perhaps this will be easier
i did a bit of rewrite based on that code for chaining syntax and using the ES6 export syntax
i also changed the default encoding to UTF-8, which is also provided but not set as default
qrcode.txt
import { QRCode } from '../../lib/mycode.js';
const qrValue = `敦煌天空的沙礫
	帶著我們的記憶`;
const typeNumber = 0;  // auto
const errorCorrectionLevel = 'L';  //
const { svg } = new QRCode(typeNumber, errorCorrectionLevel).addData(qrValue).addData('mixed').make().createSVGTag({ x: 0, y: 0, margin: 0 });

While this would probably work, I don't think we should copy code from the source project.
I opened an issue in the source repository on how to properly include the Kanji file.

The owner of the package you referenced shown me how to make the Kanji (UTF-8 in fact) support work. I'll look into making this work in my library during the holidays.

Hi, did you resolve this issue? It would also help for other native characters. I would love to have additional prop named stringToBytesMode: PropTypes.oneOf(['SJIS', 'UTF-8' ...]).

Hi, sorry, I didn't. If you need this feature I think qrcode.react might be a better alternative to this. They have added SVG support (that is superior) since this package was started.


New terms record should default numeric values to 0 when adding record

New terms record should default numeric values to 0 when adding record.   A warning is currenty generated to prevent adding non numeric values, however, default integer values (0) should be added to improve procedure UI experience.

added with patch release 6.7.28


incremental mkdir command not working in dockerfile

bash command mkdir incremental command not working in dockerfile.
Steps to reproduce the issue:

Create docker file with RUN mkdir -p /path/to/dir/dirname{1..8}
Run Dockerfile

Describe the results you received:
SSH inside container and check that the dirname1 - 8 is not generated but the directory "dirname{1..8}" is.
Describe the results you expected:
"dirname1" - "dirname8" will be created
Additional information you deem important (e.g. issue happens only occasionally):
running command mkdir -p /path/to/dir/dirname{1..8} inside container creates the directories as expected.
Output of docker version:
Client:
 Version:      17.04.0-ce
 API version:  1.28
 Go version:   go1.7.5
 Git commit:   4845c56
 Built:        Mon Apr  3 18:07:42 2017
 OS/Arch:      linux/amd64

Server:
 Version:      17.04.0-ce
 API version:  1.28 (minimum version 1.12)
 Go version:   go1.7.5
 Git commit:   4845c56
 Built:        Mon Apr  3 18:07:42 2017
 OS/Arch:      linux/amd64
 Experimental: false

Output of docker info:
Containers: 0
 Running: 0
 Paused: 0
 Stopped: 0
Images: 12
Server Version: 17.04.0-ce
Storage Driver: overlay2
 Backing Filesystem: extfs
 Supports d_type: true
 Native Overlay Diff: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: bridge host macvlan null overlay
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Init Binary:
containerd version: 422e31ce907fd9c3833a38d7b8fdd023e5a76e73
runc version: 9c2d8d184e5da67c95d601382adf14862e4f2228
init version: 949e6fa
Security Options:
 apparmor
 seccomp
  Profile: default
Kernel Version: 4.4.0-64-generic
Operating System: Ubuntu 16.04.2 LTS
OSType: linux
Architecture: x86_64
CPUs: 1
Total Memory: 990.6MiB
Name: ip-172-31-3-246
ID: CEKV:HRHQ:GDY4:J4FA:LHIM:AWB7:LXSM:QCLD:WAFB:IQYB:RHQ3:BJSA
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Username: jvmauricio
Registry: https://index.docker.io/v1/
Experimental: false
Insecure Registries:
 <IP_ADDRESS>/8
Live Restore Enabled: false

Additional environment details (AWS, VirtualBox, physical, etc.):
tested on running on EC2 freetier t2.micro instance with ubuntu-xenial-16.04-amd64-server-20170221 (ami-16efb076) OS.

I thought it depends on the image you used, what's image you used?

I thought it depends on the image you used, what's image you used?

I used ubuntu:trusty for my base image.

OK, I tried ubuntu:trusty image and get the same result with you, but when used the centos:latest image, the directory "dirname1" - "dirname8" was created successfully.

@qq690388648 thanks for testing. I haven't tried building it with other images.  will this be an issue on Docker or the image?

I find it's the difference between bash and sh, so you can write the Dockerfile as RUN /bin/bash -c "mkdir -p /path/to/dir/dirname{1..8}" to get the result you want.
Thanks @CodeJuan https://github.com/CodeJuan

closing, this is expected behavior


AutofillHints doesn't work everytime!

Autofill feature is working for following :
TextFormField(   autofillHints: [AutofillHints.name],   keyboardType: TextInputType.name, ),
TextFormField(   autofillHints: [AutofillHints.email],   keyboardType: TextInputType.emailAddress, ),
but It doesn't work for telephoneNumber:
TextFormField(
  autofillHints: [
   AutofillHints.telephoneNumberLocal,
   AutofillHints.telephoneNumber,
   AutofillHints.telephoneNumberNational,
   AutofillHints.telephoneNumberDevice,
   AutofillHints.telephoneNumberAreaCode,
   AutofillHints.telephoneNumberCountryCode,
   AutofillHints.telephoneNumberExtension,
   AutofillHints.telephoneNumberLocalPrefix,
   AutofillHints.telephoneNumberLocalSuffix,
  ],
  keyboardType: TextInputType.phone,
),

I have all the details saved in AutoFill service settings in my phone!
flutter -v doctor

[√] Flutter (Channel stable, 2.0.5, on Microsoft Windows [Version 10.0.18363.1556], locale en-US)
• Flutter version 2.0.5 at C:\src\flutter\flutter
• Framework revision adc687823a (5 weeks ago), 2021-04-16 09:40:20 -0700
• Engine revision b09f014e96
• Dart version 2.12.3
[√] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
• Android SDK at C:\Users\prita\AppData\Local\Android\Sdk
• Platform android-30, build-tools 29.0.2
• ANDROID_HOME = C:\Users\prita\AppData\Local\Android\Sdk
• Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)
• All Android licenses accepted.
[√] Chrome - develop for the web
• Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe
[√] Android Studio (version 3.6)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin version 49.0.1
• Dart plugin version 192.8052
• Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)
[√] VS Code (version 1.56.0)
• VS Code at C:\Users\prita\AppData\Local\Programs\Microsoft VS Code
• Flutter extension version 3.22.0
[√] Connected device (3 available)
• SM M305F (mobile) • <IP_ADDRESS>:5555 • android-arm64  • Android 10 (API 29)
• Chrome (web)      • chrome            • web-javascript • Google Chrome 90.0.4430.212
• Edge (web)        • edge              • web-javascript • Microsoft Edge 90.0.818.56
• No issues found!

Sorry for the late reply!

[√] Flutter (Channel stable, 2.2.0, on Microsoft Windows [Version 10.0.18363.1556], locale en-US)
• Flutter version 2.2.0 at C:\src\flutter\flutter
• Framework revision b22742018b (10 days ago), 2021-05-14 19:12:57 -0700
• Engine revision a9d88a4d18
• Dart version 2.13.0
[√] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
• Android SDK at C:\Users\prita\AppData\Local\Android\Sdk
• Platform android-30, build-tools 29.0.2
• ANDROID_HOME = C:\Users\prita\AppData\Local\Android\Sdk
• Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)
• All Android licenses accepted.
[√] Chrome - develop for the web
• Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe
[√] Android Studio (version 3.6)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin version 49.0.1
• Dart plugin version 192.8052
• Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)
[√] VS Code (version 1.56.0)
• VS Code at C:\Users\prita\AppData\Local\Programs\Microsoft VS Code
• Flutter extension version 3.22.0
[√] Connected device (3 available)
• SM M305F (mobile) • <IP_ADDRESS>:5555 • android-arm64  • Android 10 (API 29)
• Chrome (web)      • chrome            • web-javascript • Google Chrome 90.0.4430.212
• Edge (web)        • edge              • web-javascript • Microsoft Edge 90.0.818.56
• No issues found!

Device Details:
Samsung Galaxy M30
Model No : SM-M305f/DS
Android: 10
Right now I am using a package sms_autofill for time being, which is working. So I checked their repo, and I don't think I am doing anything different!

Hi @luffy1012
Please reproduce the issue without third-party package and provide a minimal reproducible code sample that does not use 3rd party plugins, your complete flutter run -v logs running the minimal code sample
Thank you

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs, and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.


[html5]TextField ignores mouseWheelEnabled=false

TextField ignores mouseWheelEnabled=false.
Code:
class Main extends Sprite {
	public function new() {
		super();
		var tf = new TextField();
		tf.background = true;
		tf.backgroundColor = 0x60c0c0;
		tf.wordWrap = true;
		tf.width = 200;
		tf.autoSize = TextFieldAutoSize.LEFT;
		tf.mouseWheelEnabled = false;
		tf.htmlText = "
Attention!\nPerforming daily tasks this month you can win a grand prize:
";
		addChild(tf);
	}
}

If you spin the mouse wheel, then this happens:

(In this case, it is impossible to return the scroll position to the first line, even if you turn the wheel in the opposite direction).
OpenFL version:
https://github.com/openfl/openfl/commit/be31d8825f35356f08910ff0d71b307c854b6bbd

Fixed here: https://github.com/openfl/openfl/commit/d2f99928436e012956e8f99574e8d8b1c5100afe
I had no idea this Boolean existed, thanks!


Fix iterator

This is actually built on top of #18, but #18 fails for some unknown reason.
It's possible that it's related to the undefined behavior pointed out in #15.
This also partly incorporates but greatly extends some of the work from #15 as well. However, the specific called out bug of the right shift from #15 still needs to be fixed.

LGTM!


Update JSONLD-Java dependency to 0.8.3

There have been a few bug fixes to JSONLD-Java between 0.7.0 and the 0.8.3 version that was released yesterday. Once the creation of the 1.0 branch is done may be a good time to upgrade. It is still Java-6 compatible so will work with both branches. At some stage in the future it will move to Java-8 but not sure of the timeline for that yet.

Note that this will require that we file a Contribution Questionnaire (CQ) in IPZilla.
As inspiration: the previous CQ, for JSONLD-Java  0.7.0, can be found here: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=10530 .

I can't see that bugzilla page as I am not a committer.

No worries, I can take care of the CQ when the time comes. Just so you're aware that this is necessary before updating a dependency version.

CQ filed: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=11532

Just to recap if Eclipse Legal look here, as mentioned on Issue #177 this is causing an actual software issue (Apache HttpClient dependencies) that would be helped by upgrading 0.7.0 and 0.8.3 so it is a higher priority than just pulling in the other minor bug fixes to JSONLD-Java during that period.

CQ is approved. We can include v 0.8.3.


swap working on new component

new swamp component with working swaps

There is a bug with this PR...
If i dont connect the app i can move freely through out the whole as expected, but once i connect the wallet it brakes, if im connected and go to the swap page it gets stuck in that page, trying to change pages go to mint or balances or any other view it doesnt do anything. on mobile version it doesnt let me move around the app, cant even open the side menu


3/4/2019 Publish

OPS Build status updates of commit 1241948:
:clock10: Preparing: average preparing time is 1 min(s) 37 sec(s)

OPS Build status updates of commit 1241948:
:clock10: Incremental building: average incremental building time is 34 min(s)

OPS Build status updates of commit 1241948:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

README.md
:white_check_mark:Succeeded

bread/toc.yml
:white_check_mark:Succeeded

docs-ref-conceptual/index.yml
:white_check_mark:Succeeded
View (azure-node-latest) View (azure-node-preview)

docs-ref-conceptual/node-sdk-azure-get-started.md
:white_check_mark:Succeeded
View (azure-node-latest) View (azure-node-preview)

docs-ref-conceptual/toc.yml
:white_check_mark:Succeeded
View (azure-node-latest) View (azure-node-preview)

docs-ref-mapping/reference.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Accuracy suffix/prefix options

This is feature request.
My case is simple: I perform search on prefixes of words in the index and so I would like to highlight only matches which are prefixes (not in the middle of word). Example:
query: "fix"
text: "fix fixes prefix"
result: "fix fixes prefix"
"fix" in "prefix" is not highlighted because it is not prefix of "prefix" ;)
Solution: it is enough to support new value of 'accuracy' configuration option (I called it 'prefix') and support it with addition of following code to 'createAccuracyRegExp(str)' function:
    case "prefix":
        return "(^|\\s" + lsJoin + ")(" + str + ")";

Hi @whury,
Thanks for submitting.
I can understand your concern, but I'm not sure if this is a common use case applicable for more users. But, as it would just mean a few additional lines we can probably offer this built-in. As there may be users complaining why there's a prefix but no suffix, this would also mean to implement a suffix option too.
There are currently more important issues to solve first, but let's keep that in the backlog.
In the meantime you can use .markRegExp() to use your custom regular expression.

Yes, I have noticed .markRegExp but in my case searches can be made on many words (prefixes) and so adding 'prefix' accuracy seemed much easier than playing with regexp (split input into tokens, prepare regexp etc.).
I understand your remark about not that common use case but let me note that, contrary to suffix query (which really seems uncommon to me), prefix query is not completely unusual. The best example I can come up with is auto-completion with highlight - in such a case prefix search is natural choice and highlighting something different than prefixes may be confusing for users.
Anyway, I made change mentioned by me and it fits my needs. If one day it becomes part of official mark.js I will switch to it.
Thank for great library!

@whury I've finally decided against such options. The reason is that – after some investigation – there are couple of problems that may occur.
Imagine the following situation:

Lorem ipsum dolor lorem sit amet

Lorem Lorem ipsum

new Mark(document.querySelector("#context")).mark("Lorem", {
    accuracy: "prefix"
});

This would mark all "Lorem" matches because they are internally separated into multiple text nodes. The RegExp you've mentioned above would apply for each text node separately. I guess this isn't what a user would expect.
The same applies to acrossElements: true where it wouldn't be possible to determine a start and end position.
TD;DR
A visual start and end point of an element may not be the internal start and end point of text nodes, especially not when using the acrossElements option. Therefore it's not possible to implement such a feature that works reliable with all scenarios.
In case it works with your specific HTML it's fine to use .markRegExp() or fork and adjust the component to your needs.

Oh man I would have liked a prefix option as well. My use case is that I am highlighting matches in documents filtered by a full-text database search. The problem is that the full-text search is configured so that only prefixes match. It's too bad this can't be reliably implemented in mark.js.
@whury May I know how you hacked the library to get your highlighting prefixes to work? I didn't understand the regex you wrote above.

@julmot What you describe is exactly my use case - I have full-text search results and I want to highlight all matching prefixes (and only prefixes) of all words in the text.
@patrickf3139 I have my changes in local repository. If you are interested, I will fork the project and apply my changes.

@patrickf3139 You can see appropriate changes in my fork.

Thanks whury! I really appreciate it :)

If I may, I'd like to upvote this request. My use case is a user-initiated search in a web view in a phone application. I'd like to match all the text nodes with the provided prefix. So, for my use case, it would be nice if whury's patch were incorporated upstream. Thanks!


dev_5_2 How to solve this problem?

#337

What are you settings of project in KEIL environment (C, C++)?

Check this: http://www.keil.com/forum/18454/cast-to-structure-not-working/
As the last but one comments says: "After adding --c99 in "Misc Controls" on "C/C++" Options, it compiles."

So if I add c99, it still doesn't work

thanks!
problem was solved .
After adding --gnu --c99 in "Misc Controls" on "C/C++" Options, it compiles

thanks!
problem was solved .
After adding --gnu  in "Misc Controls" on "C/C++" Options, it compiles


Refactor SQS and SNS

Update aws sdk (aws-sdk-go-v2)
Create SQS/SNS configuration
Handling contexts
Cancelling operations
All test pass

I don't quite know how to handle the error if a message cannot be deleted.

Hi @Mariscal6. Appreciate your work on this.
I have a request if that's okay. At the moment it seems we can't specify the MessageDeduplicationId or MessageGroupId fields in the sns.PublishInput struct as it is hidden away in the package. The MessageGroupId field is required for FIFO topics. Would it be possible to allow the client to specify that property, maybe by using the Watermill Message metadata?

Hi @Mariscal6. Appreciate your work on this - I'm really keen to use this package for an upcoming project.
I have a request if that's okay. At the moment it seems we can't specify the MessageDeduplicationId or MessageGroupId fields in the sns.PublishInput struct as it is hidden away in the package. The MessageGroupId field is required for FIFO topics. Would it be possible to allow the client to specify that property, maybe by using the Watermill Message metadata?
I have left a couple of small suggestions - I Hope you don't mind 😄

@georgedbarr Thanks for the feedback.
Yes, I think adding it is useful. I don't know if it's worth doing it in this version. I tried to isolate myself as much as possible from the FIFO Queues, because I had the feeling that they were going to give me quite a headache.
I'll add the changes that were suggested to me on discord and come back to this topic. Thank you!

@georgedbarr added

II think there is something wrong with the docker image or with my code but I cannot see the error.
You can easily reproduce the error running cmd/sns-sqs/main.go. And setting a break point in the SQS Marshaller, you will see you get different messages formats. The first iteration works fine (I have seen it work up to three messages in a row).
Then it changes the format, and there are no more attributes in the MessageAttributes field.
So the uuid cannot be extracted and the tests fail 👎

@m110 @roblaszczak  Any feedback? Sorry for pushing, I don't want it to be forgotten :)

The error I am encountering is due to the fact that the attributes when there is a subscription of sns, are shared in the body instead of the MessageAttributes
{"Type":"Notification","Token":"","MessageId":"900582b0-3695-4175-9343-153103b42816","TopicArn":"arn:aws:sns:us-east-1:100010001000:local-topic1","Subject":"","Message":"{\"some_json\": \"body4\"}","Timestamp":"2023-08-13T12:09:46Z","SignatureVersion":"1","Signature":"BV3D7uWZEmU2aSmVDZo9/gFtiTTS3o1c0v7ovCfUVlvybaOelxlqzAX8+ZnPYC24UN2gytKg4an+OziYL03TDn6fQI8Qb8gdxmwPDwXE7xlzFbbX0QO6kBsk9zwvKC6O3UpUFOQQ1mFFWG67CPN1nO+7/ZQzd9rqHmvOC7wcb/PIQ3LIJu3OQK0bFXrWHbep1RZ9hzFA2lloUa6gp+F4LMOeZw5a+NHlJDOhrVL8ibGbiWoG0iNqb0ugKi1iawnEstRPCI8Qo09JpaWcGndthZqUua4EJq4WK+3i+31gLcjxgmJO3Zbjy82z+4gM8bk+ufoDnbBnid+8hi/scE5bIA==","SigningCertURL":"http://goaws.com:4100/SimpleNotificationService/900582b0-3695-4175-9343-153103b42816.pem","UnsubscribeURL":"http://goaws.com:4100/?Action=Unsubscribe\u0026SubscriptionArn=arn:aws:sns:us-east-1:100010001000:local-topic1:6f8f948c-f3d2-424b-8637-9f557aa82772","SubscribeURL":"","MessageAttributes":{"UUID":{"Type":"StringValue","Value":"01H7QCTSZJ88S8W8RPZMK8KMJV"}}}

They say that using the RawMessageDelivery option should fix it but it is not the case, at least for the image we are using for testing. Honestly, I have tried using localstack but the performance is worst than pafortin/goaws, so I would not change it.
https://stackoverflow.com/questions/44238656/how-to-add-sqs-message-attributes-in-sns-subscription/49753291#49753291:~:text=From aws documentation%3A

I'll look into it this week, thank you for contributing!

What are the blockers for getting this merged? Is any help needed?

@m110 can we merge this?

Thank you everyone for contributing here!


[Sentry] Documentation mismatch

The sentry documentation here says use sentry: ">=4.0.0 <5.0.0" which is not available yet.
And on the pub.dev/sentry it says use sentry: ">=3.0.0 <4.0.0"
Please update the documentation or release the updated version.

The sentry documentation here says use sentry: ">=4.0.0 <5.0.0" which is not available yet.
And on the pub.dev/sentry it says use sentry: ">=3.0.0 <4.0.0"
Please update the documentation or release the updated version.

The versions are correctly mentioned in the pub.dev/sentry. This issue must be closed now.

I don't see the reference to use the sdk environment anywhere in https://pub.dev/packages/sentry/install or https://github.com/getsentry/sentry-dart#usage
Closing this as fixed. If anybody disagrees, write in comments and I'll reopen it.


Asynchronous virtual properties cause extra recomputes

In the following example, I create an async virtual foo property, and a bar property that depends on it. If you bind to bar, it computes once when foo is undefined, and then recomputes twice after foo is set (3 total times). It should only recompute/log one time after foo is set (2 total times).
var VM = can.Map.extend({
  define: {
    foo: {
      get(lastVal, setVal) {
        console.log('getting foo');
        setTimeout(() => {
          console.log('setting foo');
          setVal(5);
        }, 10);
      }
    },
    bar: {
      get() {
        var foo = this.attr('foo');
        if (foo) {
          console.log(`getting bar... foo = ${foo}`);
          return foo * 2;
        }
      }
    }
  }
});

Using stache binding:
http://jsbin.com/dagozulelu/edit?html,js,console,output
If it matters, in my use case, bar is also an asynchronous virtual property that makes a network request once foo is set.
As a workaround, I am setting foo in my component's inserted event for now.

Certainly a bug.
Seems like there are 2 problems.  First, when setVal is called, it's not dispatching in a batch.
But the more important problem is likely when this.attr('foo') is being called ... it's actually setting up a binding on two things:

the "foo" property, which is correct.
the internal compute of the "foo" property, which is incorrect.  This is happening here: https://github.com/bitovi/canjs/blob/minor/map/map.js#L259

The solution is probably to change:
https://github.com/bitovi/canjs/blob/minor/map/map.js#L259
To something like:
can.__notObserve(function(){
  computedAttr.compute();
})

But, I would avoid re-creating the function each time and have a helper like:
var readButDontObserveCompute = can.__notObserve(function(compute){
  return compute()
})

And then call:
return readButDontObserveCompute(computedAttr.compute);

I experience I think a like problems with computes, I tried solution above, it doesn't seem to work.

If you can submit a test, I'll get this in 2.3.8 asap.
Sent from my iPhone

On Dec 26, 2015, at 9:20 AM, Alex<EMAIL_ADDRESS>wrote:
I experience I think a like problems with computes, I tried solution above, it doesn't seem to work.
—
Reply to this email directly or view it on GitHub.


GORA-377 Implement gora-metamodel module

Updated patch as per my comments on the Jira issue.
https://issues.apache.org/jira/browse/GORA-377

Will rebase, rethink and resubmit one day


merged latest changes to master

I merged latest changes to master. I had converted binding adapters in kotlin sample to extension functions and a little addition to readme.

@OyaCanli can you please make another PR to master? Update the README by adding the link to the Medium post and and also some screenshot which will help render some images when link is shared on social media.

Ah sure, right, we should add link to articles on readme.


logging "Could not load Userflow.js" on failure of script loading

When the remove script of useflow fails to load, an error is logged using console.error in addition to the fact that the promise is rejected. This results in multiple errors being reported in different ways, which clutters the error reporting. Can you please demote the severity of the logging to console.warn? The promise rejection already ends up in console as an error, and can be caught by the caller of userflow.load and handled appropriately.

We've made the necessary adjustments to demote the severity of the logging to console.warn in our new version<EMAIL_ADDRESS>Thank you for your feedback!


Unable to download your pretrained models or anything that links to Google Drive

Hello. As explained, I am unable to download your pre-trained models from Google Drive. Please have a look and update as necessary.

Hi, which model have you tried to download?

Sorry, but now the problem is fixed. Thank you.


BLE SW controller PA/LNA pins configuration in device tree

It looks that currently there are two ways to define PA/LNA pins for radio drivers in Zephyr. One of them is device tree like here: https://github.com/zephyrproject-rtos/zephyr/blob/1b680c82345577cf81f9e3333ae6708c81df85c9/boards/arm/nrf21540dk_nrf52840/nrf21540dk_nrf52840.dts#L113 or https://github.com/nrfconnect/sdk-nrf/tree/master/dts/bindings/radio_fem . The other one is to use Kconfig like here: https://github.com/zephyrproject-rtos/zephyr/blob/1b680c82345577cf81f9e3333ae6708c81df85c9/subsys/bluetooth/controller/Kconfig.ll_sw_split#L549
I think it should be unified and the device tree seems like a better place to define pin numbers.
I would like Software BLE Controller to use pins description in the device tree and deprecate pins description in Kconfig.

This is a welcome request. If anyone with better knowledge to port Kconfig define used, to using the devicetree then its quicker to have this enhancement.

While developing FEM support for 802.15.4 we have gained enough knowledge to port Generic and Skyworks FEM bindings https://github.com/nrfconnect/sdk-nrf/tree/master/dts/bindings/radio_fem to Zephyr. However, we don't have enough knowledge about BLE Controller to help starting using DTS description in this module. I think a good starting point could be an example how MPSL is using DTS to configure FEMs:
https://github.com/nrfconnect/sdk-nrf/blob/master/subsys/mpsl/Kconfig.fem
https://github.com/nrfconnect/sdk-nrf/blob/master/subsys/mpsl/mpsl_fem.c

This is probably related to https://github.com/zephyrproject-rtos/zephyr/pull/31336, which I think @cvinayak would like to complete soon.

Happy to pick this up, but it looks like #31336 may already have an owner who will take this over. I'm going to leave this alone unless I hear otherwise and work on other DT related conversions in our IPs.

@hubertmis I have reviewed the existing materials and I have a proposal for how to proceed.
I think the request is for me to write a single DT binding that will apply to the Skyworks 66112 device and other similar devices, as well as the nRF21540 and potentially other Nordic FEMs. I think that has to be the case since we want to be able to use all of these devices as a FEM within the split controller code in a generic way as we do now.
In order to do this in an upstream-friendly way, this will require some changes to our downstream bindings, linked here for context:

https://github.com/nrfconnect/sdk-nrf/blob/master/dts/bindings/radio_fem/generic-fem-two-ctrl-pins.yaml
https://github.com/nrfconnect/sdk-nrf/blob/master/dts/bindings/radio_fem/skyworks%2Csky66112-11.yaml
https://github.com/nrfconnect/sdk-zephyr/blob/master/dts/bindings/net/wireless/nordic%2Cnrf21540-fem.yaml

The issue is that available documents use different terms:
Re: CONFIG_BT_CTLR_GPIO_PA_PIN:

generic-fem-two-ctrl-pins.yaml and skyworks,sky66112-11.yaml seem to   call this "ctx-gpios"
nordic,nrf21540-fem.yaml seems to call this "tx-en-gpios"
the docs for the MPSL library which consumes these refers to this as the "PA" pin, like the existing Zephyr Kconfig option

Re: CONFIG_BT_CTLR_GPIO_LNA_PIN:

generic-fem-two-ctrl-pins.yaml and skyworks,sky66112-11.yaml seem to call this "crx-gpios"
nordic,nrf21540-fem.yaml seems to call this "rx-en-gpios"
MPSL refer to this as the "LNA" pin, like the existing Zephyr Kconfig option

We need to standardize property names in the upstream binding. I suggest:
# generic-two-pin-fem.yaml
properties:
  pa-gpios:
        type: phandle-array
        required: true
        description: |
          Configuration for the power amplifier enable pin. For
          example, to use an active-high pin 3 on GPIO controller
          gpio1, write the following:

            pa-gpios = <&gpio1 3 GPIO_ACTIVE_HIGH>;

          This pin should be activated during transmission, and
          deactivated during reception.

  lna-gpios:
        type: phandle-array
        required: true
        description: |
          Configuration for the low noise amplifier enable pin. This
          should be written in the same way as pa-gpios.

          This pin should be activated during reception, and
          deactivated during transmission.

# nordic,nrf21540.yaml
compatible: "nordic,nrf21540.yaml"
include: generic-two-pin-fem.yaml
description: |
  The SoC GPIO controlling the TX_EN pin of the nRF21540 should
  be set via the pa-gpios property. Similarly, RX_EN should be
  set via lna-gpios.
properties:
  # device-specific properties, e.g. 'pdn-gpios', ...

# skyworks,sky66112-11.yaml
compatible: "skyworks,sky66112-11"
include: generic-two-pin-fem.yaml
description: |
  The SoC GPIO controlling the CTX pin of the SKY66112-11 should
  be set via the pa-gpios property. Similarly, CRX should be
  set via lna-gpios.
properties:
  # device-specific properties ...

That is, the binding would standardize on the terms "PA" and "LNA", like the Kconfig option does now.
Developers using the device-specific bindings would need to change terms from what their datasheets use to fit in this framework E.g. CTX becomes PA for Skyworks, and RX_EN becomes LNA for nRF21540.
Work for you?

@mbolivar-nordic Thanks for looking into this issue. Let me shortly explain the idea behind separated bindings downstream.
PA/LNA modules are managed with different interfaces. Some of them use simple GPIO signals (some of them as simple as one line to trigger PA and second one to trigger LNA), other use more complicated serial data interface like SPI. SKY66112 is one example of PA/LNA module with the simplest interface, while nRF21540 is much more complicated (it can use GPIO alongside SPI, it uses more lines to select TX power, reduce power consumption, select antenna).
generic-fem-two-ctrl-pins.yaml was introduced to easily create bindings for the simplest devices and reuse single software driver for all of them. It looks pin naming is copied here from SKY66112 datasheet that we used as an example. I'm fine to rename it to something more generic like pa-gpio.
nordic,nrf21540-fem.yaml describes much more complicated device. Pin naming in the binding comes from its datasheet. I think it would be better to keep it this way instead of renaming two of these pins to something generic. I think it should be ok to include these two pins in the binding from the generic one, as long as we can add name aliases that would allow device tree creator easily identify these pins in the design. But if the binding description language does not support aliases, I would prefer to keep nRF21540 binding as it is defined now and not include generic one. My intention is to maintain pin naming consistency between nrf21540 datasheet and its binding in Zephyr.

I think the request is for me to write a single DT binding that will apply to the Skyworks 66112 device and other similar devices, as well as the nRF21540 and potentially other Nordic FEMs.

I don't agree. I think we need single software driver for all simple devices like SKY, and a set of drivers for complicated devices like nRF21540. For nRF21540 we should at least manage PDN pin alongside TX and RX_EN. If drivers are separated, bindings should be separated as well. They can import common base if it would make things easier, but it is not the goal of this activity.

We need to standardize property names in the upstream binding.

Where does this need come from? I thought it is better to copy property names from datasheet. Because of other pins, nRF21540 requires a separated driver anyway.

I see now that BLE SW controller uses single severely ifdefed driver for all PA/LNA modules. I think that's the source of confusion. I'm in favor of refactoring this driver and split it into smaller parts without all these ifdefs. It should be easier to read and maintain, and would be aligned with bindings naming pins according to naming for given device.

Alternatively, if it is preferred to minimize changes to BLE SW Controller, I would recommend to create aliases in there like:
#if NRF21540_FEM_PRESENT
#define PA_PIN DT_GET_PROPERTY(tx-en-pin)
#elif GENERIC_FEM_PRESENT
#define PA_PIN DT_GET_PROPERTY(pa-gpios)
#endif

To reduce work, we keep the nRF21540 bindings as-is, use aliases as suggested here https://github.com/zephyrproject-rtos/zephyr/issues/30708#issuecomment-829903166 . We add the new generic and skyworks bindings inline with @mbolivar thoughts.

@mbolivar-nordic I think DTS structure and binding shall be designed to reflect hardware devices. We should not design DTS bindings to be similar to some software implementations. Because of this I don't want to discuss how PA/LNA management is implemented in BLE SW Controller, openisa, proprietary closed-source protocols (like downstream MPSL, SD Controller, 802.15.4 radio driver) yet. I want to focus on hardware devices first.
And about hardware devices:
There are PA/LNA chips that we can manage with a generic two-line GPIO interface (RFX2401C, SKY66112). It makes sense to include "generic" PA/LNA dts for bindings of these devices, because these are compatible and can share the same driver.
There are PA/LNA chips that have more complicated interface and we cannot manage them using the "generic" interface. One example is nRF21540. I agree two GPIO lines in this device have similar meaning to the "generic" GPIO interface, but it is not enough to use these lines to manage this chip. Because of this, nRF21540 is incompatible with the "generic" GPIO interface and we cannot share software drivers between "generic" GPIO PA/LNAs and nRF21540. And as a result, we should not include "generic" PA/LNA dts in nRF21540 binding. The current binding of nRF21540 device is correct. We can extend it with TX power control, but we shall not modify its basics.
After we decide how DTS bindings shall describe hardware devices, we shall start discussion how to align software implementations with the bindings.

Fixed in https://github.com/zephyrproject-rtos/zephyr/pull/39168


remove redundant clone

Good catch!
@bors r+

:pushpin: Commit cb21339386173b94f02bf47cedb5511de3c849a1 has been approved by RalfJung
It is now in the queue for this repository.

:hourglass: Testing commit cb21339386173b94f02bf47cedb5511de3c849a1 with merge 8c0da96b1b281e1ceebc9178cae9a4a64fdce483...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing 8c0da96b1b281e1ceebc9178cae9a4a64fdce483 to master...


SQL error when changing the title of a menu item

Laravel Version: 5.5.22
Voyager Version: 1.0.7
PHP Version: 7.1.2
Database Driver & Version: MySQL 5.7

Description:
After a fresh install of laravel and voyager, including running php artisan voyager:install --with-dummy, when going in the menu builder and trying to change the title of the menu item "Dashboard" (/admin/menus/1/builder) to anything the install throws this error :
Illuminate \ Database \ QueryException (42S22) SQLSTATE[42S22]: Column not found: 1054 Unknown column 'p' in 'field list' (SQL: update `menu_items` set `title` = Test, `color` = #000000, `updated_at` = 2017-11-29 23:05:32, `parameters` = null, `p` = /admin/menus/1/item where `id` = 1)
I attached a copy of the html making up the complete Whoops page.
VoyagerPTableError.zip

There seems to have been some holdover from another package I installed previously that made the migrations wonky. I started completly fresh and the issue now seems gone. I'd like to give more information about this but I have none. If anyone finds this through google the bets I can suggest is start completly from scratch with a clean DB and Laravel install and make voyager the first thing you install. That, worked for me.


External postgress connection string is created incorrectly

Issue description
Postgress connection string generation is incorrect
Details
Here is my helm values:
  db:
    enabled: true
    external: true
    source:
      connectionString: postgresql://user@<IP_ADDRESS>:5000/stackrox-db
      minConns: 10
      maxConns: 90
      statementTimeoutMs: 60000
    password:
      value: <path:dp-srv/prod/patroni/prod1#stackrox-prod>

Here is an error i`ve got:
globaldb: 2023/03/23 22:42:59.846963 postgres.go:84: Fatal: Could not parse postgres config: Could not parse postgres config: cannot parse `postgresql:xxxxxx@<IP_ADDRESS>:5000/stackrox-db-prod statement_timeout=60000 pool_min_conns=10 pool_max_conns=90 password=xxxxx`: failed to parse as URL (parse "postgresql://stackrox-prod@<IP_ADDRESS>:5000/stackrox-db-prod statement_timeout=60000 pool_min_conns=10 pool_max_conns=90 password=Non-Masked-Password\n": net/url: invalid control character in URL)

Looks like there are 2 erorrs, one in helm chart:
https://github.com/stackrox/helm-charts/blob/main/3.74.1/central-services/templates/01-central-08-external-db-configmap.yaml#L16
It should be
source: {{ ._rox.central.db.source.connectionString }}?statement_timeout={{ ._rox.central.db.source.statementTimeoutMs }}&pool_min_conns={{ ._rox.central.db.source.minConns }}&pool_max_conns={{ ._rox.central.db.source.maxConns }}

instead
And another one is here:
https://github.com/stackrox/stackrox/blob/d3911f6e206aa05093b3c9b6d878426231587723/pkg/postgres/pgconfig/config.go#L36
I`m not that good with golang, but looks like it should be:
source := fmt.Sprintf("%s&password=%s", centralConfig.CentralDB.Source, password)

But it would be even better to add password to the username separated with ":", because then it is added as an parameter it is not masked properly in logs.

Looks like it ignores dbname key
Here is my connection string:
source: "host=<IP_ADDRESS> port=5000 dbname=stackrox-db-prod user=stackrox-user statement_timeout=60000 pool_min_conns=10 pool_max_conns=90"
Also:
"NOTICE:  database "central_backup" does not exist, skipping"
looks like it`s not suited for shared PG servers.
It would be great if there would be a configurable list of needed databases, so you could create them in advance

FTR, there are plans to support a "bring your own DB" use case better.


New version: CmdStan v5.0.5

Registering package: CmdStan
Repository: https://github.com/StanJulia/CmdStan.jl
Created by: @goedman
Version: v5.0.5
Commit: f1d87f3ed16ce24f32940f3a1b713391512b5323
Reviewed by: @goedman
Reference: https://github.com/StanJulia/CmdStan.jl/issues/44

What happened to 5.0.4?

 I can re-register under 5.0.4.

#1231


chore(main): release 1.1.66

:robot: I have created a release beep boop
1.1.66 (2024-11-05)
Bug Fixes

deps: update dependency @ai-sdk/openai to ^0.0.67 (c1d3554)
deps: update dependency @ai-sdk/openai to ^0.0.68 (ae2cfcb)
deps: update dependency @ai-sdk/openai to ^0.0.70 (aecd2b6)
deps: update dependency @ai-sdk/openai to ^0.0.71 (8ef175f)
deps: update dependency @ai-sdk/openai to ^0.0.72 (19f26f7)
deps: update dependency @headlessui/react to v2.1.10 (98d2d36)
deps: update dependency @headlessui/react to v2.2.0 (036d3f9)
deps: update dependency ai to v3.4.10 (d33cf69)
deps: update dependency ai to v3.4.11 (ee776ef)
deps: update dependency ai to v3.4.12 (8bccb82)
deps: update dependency ai to v3.4.13 (d03cb92)
deps: update dependency ai to v3.4.16 (18f53d4)
deps: update dependency ai to v3.4.17 (7fbe69b)
deps: update dependency ai to v3.4.20 (4f9ef55)
deps: update dependency ai to v3.4.21 (be0de66)
deps: update dependency ai to v3.4.22 (0a5d69d)
deps: update dependency ai to v3.4.23 (4517e97)
deps: update dependency ai to v3.4.27 (3223617)
deps: update dependency ai to v3.4.29 (11bb577)
deps: update dependency ai to v3.4.30 (e1e05b7)
deps: update dependency ai to v3.4.31 (c67f420)
deps: update dependency ai to v3.4.32 (fc17f1f)
deps: update dependency ai to v3.4.33 (bb731d8)
deps: update dependency chart.js to v4.4.5 (55d1294)
deps: update dependency chart.js to v4.4.6 (d9e9a86)
deps: update dependency nanoid to v5.0.8 (f739b2d)
deps: update dependency tailwindcss to v3.4.14 (1b1a365)
deps: update dependency typescript to v5.6.3 (320f4db)
deps: update prisma monorepo to v5.21.0 (f649ac4)
deps: update prisma monorepo to v5.21.1 (5ff842e)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v1.1.66
:sunflower:


Deneb Upgrade

Task Tracking
Issue tracking for the Deneb Fork Upgrade for mev-boost.

[x] Upgrade type and logic paths for getHeader and getPayload https://github.com/flashbots/mev-boost/pull/553
[x] Verify proofs, commitments, blob_root of blinded payload matches the proofs, commitments and blob of the unblinded payload
[x] Consistency across conflicting package names (see here) https://github.com/flashbots/mev-boost/pull/560

Dependencies
mev-boost depends on the following changes and they are all still in branch form. go.mod will need to be updated after the PRs are merged to upstream and point to the latest dependency.
go-builder-client

Fixing the ssz encoding for blob bundles https://github.com/attestantio/go-builder-client/pull/18
Adding the builder bid structs to attestant https://github.com/attestantio/go-builder-client/pull/17
Adding Deneb to the versioned struct for the signed header bid https://github.com/attestantio/go-builder-client/pull/19

go-boost-utils

Util functions to calculate the block hash and conversions https://github.com/flashbots/go-boost-utils/pull/87

Will need to replace https://github.com/MariusVanDerWijden/go-ethereum/tree/4844-devnet-6 with latest geth release after the changes are merged

Known bugs and issues

https://github.com/flashbots/mev-boost/issues/579

merged


roboai package - No model / New models confusion

@martasls
bot model is not being packaged when deployed
https://drive.google.com/drive/folders/1yrkqLa51Etbs2rSexKjttxEOAXZ6iOZx?usp=sharing

New models are being generated without training.
Steps:

download voicebot-20210203T142509Z-001.zip && extract
run roboai package
A new model should appear inside the models folder

Original screenshot

As discussed, no new model is being generated. The problem with the deployment is because of the backslashes used in windows. Fix in progress.


GEODE-3151: Internal Region Registration in JMX as per config parameter

Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[X ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[X ] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[ X] Is your initial contribution a single, squashed commit?

[X ] Does gradlew build run cleanly?

[ X] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

If you are using IntelliJ as your IDE, please remember to update your style file to that located in geode/etc/intellij-java-modified-google-style.xml to be consistent with Geode's established style guide.  This file was updated June 13 with commit a561bd12 to be consistent with documented expectations.
After having done so, please optimize the imports to the correct order and to eliminate the use of the wildcard imports.

i have added  etc/eclipseFormatterProfile.xml in eclipse profile & did the code style set.

I think this sort of change should be proposed and discussed on the dev list. This is effectively adding new User APIs and that requires more discussion.

Hi Dinesh,
Sorry to be so slow in responding to your PR.  Since the changes you are proposing in GEODE-3151 involve changing a public-facing API (in DistributionConfig, I think it first needs to be discussed on<EMAIL_ADDRESS>before we could pull this in.  Would you mind sending an email to that list with your proposal and the use-case you have in mind?
Thank you,
Jared

no need.


Laser pointer (feature request)

This is a great interface.  Very useful!
A laser pointer option would be a great addition (and I imagine very easy to implement).    Right now, you can see a pointer if you hover an active stylus over the interface, but if you accidently touch you draw.  Being able to point without worrying about drawing (or selecting) would be great!
Jeff Schenker

Safety-wise, this sounds like the pan tool () but maybe with a different icon?

Yes that sounds about right. Pan tool would be the safest at present.  A "pan tool" that didn't do anything when you clicked would do this.

A tool that does nothing sounds a little weird. Maybe a laser pointer tool, when clicked, could make some "self-destructing ink" -- show a highlight that disappears after a few seconds.  No permanent effect but nicer for pointing at things.

Indeed.  That makes much more sense!

I very much love to use the laser pointer feature in PowerPoint. The mouse cursor just becomes a red laser-like image. It would be great if that could be implemented here too!

Making a tool that just shows a dot of a specified color would be easy; is this of sufficient interest by itself?
The self-destructing ink seems more useful but also harder to implement, as we'd need to resolve the following:

Do laser pointer strokes get added in the history? I think ideally yes. If no, they could be wedged into the presence information I guess.
Does the server implement the destruction? Or the client using the pointer? Or all clients, locally? The pointer client destructing is simplest, but also a little dangerous: if they disappear, they'll never clean up their stroke. But maybe that's OK, as long as it can be deleted? I could see actually wanting highlights to stick around until the next highlight gets done...
Does the laser pointer share all the properties (width and color) with the pen and other drawing tools, or does it have its own "current" settings? Related also to highlighter.


Add nodeeditor

now that qt is a package, we can provide libraries using it

https://github.com/miurahr/aqtinstall/issues/497


test on buildkite

when you have tests passing just merge without waiting for me

add a readme badge like the one on QuantumSavory


If You ever give me credit could you link my games site and youtube channel

https://sites.google.com/stu.hinsdale86.org/ginjagames/
https://www.youtube.com/@GinjaNinja5199

of course lol


chore(release): adding 1.6.1

Adds ListGroup from #53

Coverage remained the same at 100.0% when pulling be73228fdc72326bfc1892ff933652a749743b8f on release-1.6.1 into 3752f6e4e11562fb5af085408ecab1455a665ff8 on master.


Update 0238-product-of-array-except-self.js

File(s) Modified: 0001-two-sum.py, 0002-add-two-numbers.py, etc...
Language(s) Used: python, javascript, etc...
Submission URL: _https://leetcode.com/problems/[problem-name]/submissions/xxxxxxxxx/_

Important
Please make sure the file name is lowercase and a duplicate file does not already exist before merging.

@shubhamsinghbundela The Space Complexity is not O(1). It is O(n) since we are storing the results array


feat(asset): Added calibration forecast query builder

Pull Request
🤨 Rationale
User Story 2798210: [UI][Grafana] Add support for filters on the Grafana plugin
👩💻 Implementation

integrated the query builder component
moved constants and types that are used in multiple places in core
created and integrated callbacks for query builder expression templates in order to handle computed field queries (ex: Location.MinionId || Location.PhysicalLocation)
updated expression template callbacks to take option label/value into consideration so that the label is displayed and the value is sent

🧪 Testing
Added unit tests.
GIF  of the query builder sending the right requests.

✅ Checklist

[x ] This PR has a title that follows the commit message format.

Please add a description and a prepare a gif to highlight the functionality  in the description

@mure  Is there any possibility to get this reviewed? The PR is out for some time now and we are expecting

@mure can you please take a look again? The feedback has been addressed.

:tada: This PR is included in version 3.15.0 :tada:
The release is available on:

v3.15.0
GitHub release

Your semantic-release bot :package::rocket:


Add missing expiration time to dogpile caching

Updated dogpile configuration where expiration time was previously missing.

+1


Query planner using join

Motivation
Solve the N + 1 issue, data loader is currently being used
Proposed Solutions
Option to solve it with join, similar to this:
https://github.com/join-monster/join-monster
Additional Information
There are couple of other things if we can adapt from that library, which Im not sure if this seaography has implemented or not:

Only select necessary fields, not *
A way to specify or adding into the where condition
Multiple order by
Query through junction (or any relation)

@namnm Thanks for taking the time to discuss your concerns with us. Currently, we solve N+1 in most cases except in m-n relations. The project you suggested is amazing, but unfortunately, it follows a different approach. The scope of SeaQuery is to be combined with metadata provided by SeaORM. This limits our options, and sometimes, it is hard to move this information around. But I will keep your suggestion in mind and, in a future refactoring to change the background of how this project works.


API Key

it wants the API Key
and it is not working for me, i tried the ID thing i found on it description but still it does not work

yes it needs an openai api key you can put in the settings. which ID thing?


About the TNT dataset download link

Hi, thanks for your great work!
Would you please update the download link?

Hi, I just tested and the link work. Which one do you mean?


GX_end is static compile warning

Good day all.
just trying to update my libogc to the latest version but I am getting this warning when compiling my current project;
:/devkitPro/libogc/include/grrlib/GRRLIB_fbGX.h:45:5: warning: 'GX_End' is static but used in inline function 'GRRLIB_GXEngine' which is not static
GX_End();
^~~~~~
I get about 17 or so errors anywhere a GX function ( e.g.  GX_Color1u32(color[i]); GX_Position3f32(v[i].x, v[i].y, v[i].z); )  is used in GRRLIB.  my own code compiles and runs fine.  is there anything I can do about the warnings or just ignore them?

Hello @owensoft, are you using the code from the master branch or the 4.3.2 version released in 2015?

yes, I just downloaded the master this morning and ran clean make.  the make runs without error.  then I recompiled my code in prog notepad on windows7 and got a the warnings.

Try running make clean all install
Maybe you did not installed the library and you are using the old one.
If you look at this log from GRRMOD where GRRLIB version 4.3.2 is used you can see the same problem: https://travis-ci.org/GRRLIB/GRRMOD
But if you look at the GRRLIB where all the samples are built, there is no problem: https://travis-ci.org/GRRLIB/GRRLIB
I am pretty sure I fixed that problem in commit 3dbee76

thanx I will recompile and test it again when I get home in a 6 hours.   will update with my findings when done.  thanx again

Aw, issue resolved.  it was the classic case of not restarting after updating devkitpro.  worked fine after restarting and making GRRLIB again.  thanx