Netbird ACL doesn't work when accessing peer with Docker container

Describe the problem
When one peer inside Netbird network tries to reach another peer's container, it fails.
Destination peer has the container with published port, for example 80:8080 (external port should differ)
And in Netbird ACL i only allowed 80 and 443 ports, which should be enough

To Reproduce
Steps to reproduce the behavior:

Connect to the netbird as user peer
Connect host peer
Set up docker container with external port. External port should be 80 (could be any port). Internal should be any except 80. Container should return any response locally on port 80
Add single rule in the list: ALLOW TCP, All Source, All destination, ports 80, 443, bidirectional
curl  . Connection timed out
Add second rule in ACL. ALLOW TCP, All source, All destination, port - internal port of the container
curl . Getting response as expected

Expected behavior
It should be enough to add ACL rule, which allows external container port, because why i need to know all port forwardings? I dont want to specify all internal ports of all my containers, because i will expose only 80 port, not their system ports.
Are you using NetBird Cloud?
no
NetBird version
0.28.6

To be clear, netbird runs on the host and not inside the container, right?
Could you provide the nftables output please? nft list ruleset
Might need to install the nftables package first.

@lixmal
I have this setup, 3 different hosts:

Netbird controller running inside docker, with zitadel, caddy, postgres etc.
Peer 1 - my PC
Peer 2 - app with docker container

$ nft list ruleset
table ip nat {
        chain DOCKER {
                iifname "br-b64dc14d949f" counter packets 0 bytes 0 return
                iifname "docker0" counter packets 0 bytes 0 return
                iifname != "br-b64dc14d949f" meta l4proto tcp tcp dport 80 counter packets 89859 bytes 5378483 dnat to <IP_ADDRESS>:80
                iifname != "br-b64dc14d949f" meta l4proto tcp tcp dport 443 counter packets 4771 bytes 247506 dnat to <IP_ADDRESS>:443
                iifname != "br-b64dc14d949f" meta l4proto tcp tcp dport 8080 counter packets 567 bytes 24868 dnat to <IP_ADDRESS>:8080
        }

        chain POSTROUTING {
                type nat hook postrouting priority srcnat; policy accept;
                oifname != "br-b64dc14d949f" ip saddr <IP_ADDRESS>/16 counter packets 83 bytes 4980 masquerade
                oifname != "docker0" ip saddr <IP_ADDRESS>/16 counter packets 0 bytes 0 masquerade
                meta l4proto tcp ip saddr <IP_ADDRESS> ip daddr <IP_ADDRESS> tcp dport 80 counter packets 0 bytes 0 masquerade
                meta l4proto tcp ip saddr <IP_ADDRESS> ip daddr <IP_ADDRESS> tcp dport 443 counter packets 0 bytes 0 masquerade
                meta l4proto tcp ip saddr <IP_ADDRESS> ip daddr <IP_ADDRESS> tcp dport 8080 counter packets 0 bytes 0 masquerade
        }

        chain PREROUTING {
                type nat hook prerouting priority dstnat; policy accept;
                fib daddr type local counter packets 1015834 bytes 52066735 jump DOCKER
        }

        chain OUTPUT {
                type nat hook output priority -100; policy accept;
                ip daddr != <IP_ADDRESS>/8 fib daddr type local counter packets 286 bytes 40040 jump DOCKER
        }
}
table ip filter {
        chain DOCKER {
                iifname != "br-b64dc14d949f" oifname "br-b64dc14d949f" meta l4proto tcp ip daddr <IP_ADDRESS> tcp dport 80 counter packets 89859 bytes 5378483 accept
                iifname != "br-b64dc14d949f" oifname "br-b64dc14d949f" meta l4proto tcp ip daddr <IP_ADDRESS> tcp dport 443 counter packets 4773 bytes 247626 accept
                iifname != "br-b64dc14d949f" oifname "br-b64dc14d949f" meta l4proto tcp ip daddr <IP_ADDRESS> tcp dport 8080 counter packets 567 bytes 24868 accept
        }

        chain DOCKER-ISOLATION-STAGE-1 {
                iifname "br-b64dc14d949f" oifname != "br-b64dc14d949f" counter packets 899655 bytes 312809594 jump DOCKER-ISOLATION-STAGE-2
                iifname "docker0" oifname != "docker0" counter packets 0 bytes 0 jump DOCKER-ISOLATION-STAGE-2
                counter packets 41820128 bytes<PHONE_NUMBER> return
        }

        chain DOCKER-ISOLATION-STAGE-2 {
                oifname "br-b64dc14d949f" counter packets 0 bytes 0 drop
                oifname "docker0" counter packets 0 bytes 0 drop
                counter packets 908707 bytes 323436671 return
        }

        chain FORWARD {
                type filter hook forward priority filter; policy drop;
                counter packets 41706520 bytes<PHONE_NUMBER> jump DOCKER-USER
                counter packets 41706520 bytes<PHONE_NUMBER> jump DOCKER-ISOLATION-STAGE-1
                oifname "br-b64dc14d949f" ct state related,established counter packets 39171857 bytes<PHONE_NUMBER> accept
                oifname "br-b64dc14d949f" counter packets 1635008 bytes 98039517 jump DOCKER
                iifname "br-b64dc14d949f" oifname != "br-b64dc14d949f" counter packets 899655 bytes 312809594 accept
                iifname "br-b64dc14d949f" oifname "br-b64dc14d949f" counter packets 1539809 bytes 92388540 accept
                oifname "docker0" ct state related,established counter packets 0 bytes 0 accept
                oifname "docker0" counter packets 0 bytes 0 jump DOCKER
                iifname "docker0" oifname != "docker0" counter packets 0 bytes 0 accept
                iifname "docker0" oifname "docker0" counter packets 0 bytes 0 accept
        }

        chain DOCKER-USER {
                counter packets 41820128 bytes<PHONE_NUMBER> return
        }
}
table ip6 nat {
        chain DOCKER {
        }
}
table ip6 filter {
        chain DOCKER {
        }

        chain DOCKER-ISOLATION-STAGE-1 {
                iifname "br-b64dc14d949f" oifname != "br-b64dc14d949f" counter packets 0 bytes 0 jump DOCKER-ISOLATION-STAGE-2
                iifname "docker0" oifname != "docker0" counter packets 0 bytes 0 jump DOCKER-ISOLATION-STAGE-2
                counter packets 0 bytes 0 return
        }

        chain DOCKER-ISOLATION-STAGE-2 {
                oifname "br-b64dc14d949f" counter packets 0 bytes 0 drop
                oifname "docker0" counter packets 0 bytes 0 drop
                counter packets 0 bytes 0 return
        }

        chain FORWARD {
                type filter hook forward priority filter; policy drop;
                counter packets 0 bytes 0 jump DOCKER-USER
        }

        chain DOCKER-USER {
                counter packets 0 bytes 0 return
        }
}

Peer 2 - app with docker container

I don't see netbird rules in the nft output. So netbird runs in the container?
If that's the case then The VPN and access rules are set up within the container. Any forwardings set up by the container runtime on the host are not known to netbird nor would we like to mess with them.

I don't see netbird rules in the nft output. So netbird runs in the container?

Yes netbird runs in the container
Sorry didn't understood first which host nftables i need to show. Here's info about host with container. I think thats what you want to see
~# nft list ruleset
table ip nat {
        chain DOCKER {
                iifname "br-a8513a7899b9" counter packets 0 bytes 0 return
                iifname "docker0" counter packets 0 bytes 0 return
                iifname != "br-a8513a7899b9" meta l4proto tcp tcp dport 8250 counter packets 0 bytes 0 dnat to <IP_ADDRESS>:8250
                iifname != "br-a8513a7899b9" meta l4proto tcp tcp dport 80 counter packets 1954 bytes 111305 dnat to <IP_ADDRESS>:8200
                iifname != "docker0" meta l4proto udp udp dport 8600 counter packets 0 bytes 0 dnat to <IP_ADDRESS>:8600
                iifname != "docker0" meta l4proto tcp tcp dport 8500 counter packets 32 bytes 1664 dnat to <IP_ADDRESS>:8500
                iifname != "docker0" meta l4proto tcp tcp dport 9001 counter packets 0 bytes 0 dnat to <IP_ADDRESS>:9001
        }

        chain POSTROUTING {
                type nat hook postrouting priority srcnat; policy accept;
                oifname != "br-a8513a7899b9" ip saddr <IP_ADDRESS>/16 counter packets 520 bytes 31514 masquerade
                oifname != "docker0" ip saddr <IP_ADDRESS>/16 counter packets 84 bytes 6440 masquerade
                meta l4proto tcp ip saddr <IP_ADDRESS> ip daddr <IP_ADDRESS> tcp dport 8250 counter packets 0 bytes 0 masquerade
                meta l4proto tcp ip saddr <IP_ADDRESS> ip daddr <IP_ADDRESS> tcp dport 8200 counter packets 0 bytes 0 masquerade
                meta l4proto udp ip saddr <IP_ADDRESS> ip daddr <IP_ADDRESS> udp dport 8600 counter packets 0 bytes 0 masquerade
                meta l4proto tcp ip saddr <IP_ADDRESS> ip daddr <IP_ADDRESS> tcp dport 8500 counter packets 0 bytes 0 masquerade
                meta l4proto tcp ip saddr <IP_ADDRESS> ip daddr <IP_ADDRESS> tcp dport 9001 counter packets 0 bytes 0 masquerade
        }

        chain PREROUTING {
                type nat hook prerouting priority dstnat; policy accept;
                fib daddr type local counter packets 5049 bytes 315770 jump DOCKER
        }

        chain OUTPUT {
                type nat hook output priority -100; policy accept;
                ip daddr != <IP_ADDRESS>/8 fib daddr type local counter packets 0 bytes 0 jump DOCKER
        }
}
table ip filter {
        chain DOCKER {
                iifname != "br-a8513a7899b9" oifname "br-a8513a7899b9" meta l4proto tcp ip daddr <IP_ADDRESS> tcp dport 8250 counter packets 0 bytes 0 accept
                iifname != "br-a8513a7899b9" oifname "br-a8513a7899b9" meta l4proto tcp ip daddr <IP_ADDRESS> tcp dport 8200 counter packets 1665 bytes 96077 accept
                iifname != "docker0" oifname "docker0" meta l4proto udp ip daddr <IP_ADDRESS> udp dport 8600 counter packets 0 bytes 0 accept
                iifname != "docker0" oifname "docker0" meta l4proto tcp ip daddr <IP_ADDRESS> tcp dport 8500 counter packets 32 bytes 1664 accept
                iifname != "docker0" oifname "docker0" meta l4proto tcp ip daddr <IP_ADDRESS> tcp dport 9001 counter packets 0 bytes 0 accept
        }

        chain DOCKER-ISOLATION-STAGE-1 {
                iifname "br-a8513a7899b9" oifname != "br-a8513a7899b9" counter packets 95688 bytes 151849709 jump DOCKER-ISOLATION-STAGE-2
                iifname "docker0" oifname != "docker0" counter packets 6786 bytes 22253491 jump DOCKER-ISOLATION-STAGE-2
                counter packets 17944502 bytes<PHONE_NUMBER> return
        }

        chain DOCKER-ISOLATION-STAGE-2 {
                oifname "br-a8513a7899b9" counter packets 0 bytes 0 drop
                oifname "docker0" counter packets 0 bytes 0 drop
                counter packets 264567 bytes 387219540 return
        }

        chain FORWARD {
                type filter hook forward priority filter; policy drop;
                counter packets 4618318 bytes 801152504 jump DOCKER-USER
                counter packets 4618318 bytes 801152504 jump DOCKER-ISOLATION-STAGE-1
                oifname "br-a8513a7899b9" ct state related,established counter packets 95633 bytes 19926068 accept
                oifname "br-a8513a7899b9" counter packets 1692 bytes 97769 jump DOCKER
                iifname "br-a8513a7899b9" oifname != "br-a8513a7899b9" counter packets 95688 bytes 151849709 accept
                iifname "br-a8513a7899b9" oifname "br-a8513a7899b9" counter packets 21 bytes 1380 accept
                oifname "docker0" ct state related,established counter packets 4316755 bytes 584321436 accept
                oifname "docker0" counter packets 71701 bytes 4302425 jump DOCKER
                iifname "docker0" oifname != "docker0" counter packets 6786 bytes 22253491 accept
                iifname "docker0" oifname "docker0" counter packets 71669 bytes 4300761 accept
        }

        chain DOCKER-USER {
                counter packets 17944502 bytes<PHONE_NUMBER> return
        }
}
table ip6 filter {
}
table ip6 nat {
}
table ip netbird {
        set nb0000094 {
                type ipv4_addr
                flags dynamic
                elements = { <IP_ADDRESS> }
        }

        set nb0000095 {
                type ipv4_addr
                flags dynamic
                elements = { <IP_ADDRESS> }
        }

        set nb0000105 {
                type ipv4_addr
                flags dynamic
                elements = { <IP_ADDRESS>, <IP_ADDRESS>,
                             <IP_ADDRESS> }
        }

        set nb0000273 {
                type ipv4_addr
                flags dynamic
                elements = { <IP_ADDRESS> }
        }

        set nb0000278 {
                type ipv4_addr
                flags dynamic
                elements = { <IP_ADDRESS> }
        }

        set nb0000279 {
                type ipv4_addr
                flags dynamic
                elements = { <IP_ADDRESS> }
        }

        set nb0000280 {
                type ipv4_addr
                flags dynamic
                elements = { <IP_ADDRESS> }
        }

        set nb0000281 {
                type ipv4_addr
                flags dynamic
                elements = { <IP_ADDRESS> }
        }

        chain netbird-rt-fwd {
        }

        chain netbird-rt-nat {
                type nat hook postrouting priority srcnat - 1; policy accept;
                oifname "lo" return
        }

        chain netbird-acl-input-rules {
                iifname "wt0" tcp dport 443 accept
                iifname "wt0" tcp dport 80 accept
                iifname "wt0" tcp sport 443 accept
                iifname "wt0" tcp sport 80 accept
                iifname "wt0" tcp dport 8200 accept
                iifname "wt0" ip saddr @nb0000105 tcp dport 44338 accept
                iifname "wt0" ip protocol icmp accept
        }

        chain netbird-acl-output-rules {
                oifname "wt0" tcp sport 443 accept
                oifname "wt0" tcp sport 80 accept
                oifname "wt0" tcp dport 443 accept
                oifname "wt0" tcp dport 80 accept
                oifname "wt0" tcp sport 8200 accept
                oifname "wt0" ip daddr @nb0000105 tcp sport 44338 accept
                oifname "wt0" ip protocol icmp accept
        }

        chain netbird-acl-input-filter {
                type filter hook input priority filter; policy accept;
                iifname "wt0" ip saddr <IP_ADDRESS>/16 ip daddr != <IP_ADDRESS>/16 accept
                iifname "wt0" ip saddr != <IP_ADDRESS>/16 ip daddr <IP_ADDRESS>/16 accept
                iifname "wt0" ip saddr <IP_ADDRESS>/16 ip daddr <IP_ADDRESS>/16 jump netbird-acl-input-rules
                iifname "wt0" drop
        }

        chain netbird-acl-output-filter {
                type filter hook output priority filter; policy accept;
                oifname "wt0" ip saddr != <IP_ADDRESS>/16 ip daddr <IP_ADDRESS>/16 accept
                oifname "wt0" ip saddr <IP_ADDRESS>/16 ip daddr != <IP_ADDRESS>/16 accept
                oifname "wt0" ip saddr <IP_ADDRESS>/16 ip daddr <IP_ADDRESS>/16 jump netbird-acl-output-rules
                oifname "wt0" drop
        }

        chain netbird-acl-forward-filter {
                type filter hook forward priority filter; policy accept;
                iifname "wt0" jump netbird-rt-fwd
                oifname "wt0" jump netbird-rt-fwd
                iifname "wt0" meta mark 0x000007e4 accept
                oifname "wt0" meta mark 0x000007e4 accept
                iifname "wt0" jump netbird-acl-input-rules
                iifname "wt0" drop
        }

        chain netbird-acl-prerouting-filter {
                type filter hook prerouting priority mangle; policy accept;
                ip saddr @nb0000281 ip daddr <IP_ADDRESS> tcp dport 443 meta mark set 0x000007e4
                ip saddr @nb0000280 ip daddr <IP_ADDRESS> tcp dport 80 meta mark set 0x000007e4
                ip saddr @nb0000273 ip daddr <IP_ADDRESS> tcp dport 8200 meta mark set 0x000007e4
                ip saddr @nb0000105 ip daddr <IP_ADDRESS> tcp dport 44338 meta mark set 0x000007e4
                ip saddr @nb0000095 ip daddr <IP_ADDRESS> ip protocol icmp meta mark set 0x000007e4
                iifname "wt0" ip saddr != <IP_ADDRESS>/16 ip daddr <IP_ADDRESS> meta mark set 0x000007e4
        }
}

Big thanks for investigating, issue disappeared by itself. Closing


Minecraft "Server IP Address" field cannot be left blank, as per help text

Bug Report
System Information

Operating System - Ubuntu 20.04.5
AMP version and build date - <IP_ADDRESS> buit 21/12/2022 17:54
Which AMP release stream you're using - Mainline

I confirm:

[x] that I have searched for an existing bug report for this issue.
[x] that I am using the latest available version of AMP.
[x] that my operating system is up-to-date.

Symptoms

What are you trying to do?

Leave the "Server IP address" field blank, to indicate binding to all adaptors, + IPv4 & IPv6

What are you expecting to happen?

i can select "nothing"/empty value in the drop-down

What is actually happening? ('Nothing' is not an acceptable answer!)

I must select an IP mapping

Reproduction
Enter reproductions steps here.

create a new Java MC instance
go to configuration/server settings
in the server IP address field , note that the text shows "leave blank to use any", however i have to select something, see screenshot:
(note that none of the options will allow the MC instance to bind to both IPv4 & IPv6 interfaces, you have to choose one or the other)

if this were a standalone MC instance, i would be leaving the server.properties value of "server-ip=" blank, rather than having <IP_ADDRESS> or :: in it to allow it to bind to both ipv4 and ipv6 at the same time.

Select :: - java will accept both v4 and v6 traffic on the socket

sorry, but this is not correct:
amp config:

mc starting:

system netstat:

Did you try to connect via IPv4?

On Linux systems, unless explicitly disabled via a kernel flag - IPv6 sockets will accept IPv4 connections. This is functioning as intended.

Select :: - java will accept both v4 and v6 traffic on the socket

sorry, but this is not correct:

Except it is. xD
Showing screenshots of the v6 socket listening doesn't establish otherwise. As I said, that socket will accept both v4 and v6 traffic (unless that has been specifically disabled as Mike noted).


feat: add cache fallbacks, allow multiple prefixes

This PR allows to get the most specific cache available with fallback to all less specific ones. Also, it allows to use multiple prefixes.
For example a PR would first try the PR's branch cache, then the base branch cache, then the default branch cache.
For multiple prefixes only the first is used as output. The others allow for the import of caches from other build steps.
Imagine a "prepare" step in your build pipeline. This would export a "prepare" cache. The "next" step, which would need to run "prepare" itself a second time can then try to import "next", which would fail on the first run, then fallback to "prepare", which would then be available.

See #191.


[release-0.49] Upgrade k8s deps to 1.21.11

What this PR does / why we need it:
The backport of the update k8s deps to 1.23 was too ahead since it requires go 1.17
This PR reverts commits of https://github.com/kubevirt/kubevirt/pull/7330 and update k8s deps to 1.21.11
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

NONE

/cc @davidvossel @maya-r @rmohr @stu-gott

/retest

/retest

/lgtm
/approve


Adding feature to move a step back by pressing Backspace key

Users can move multiple steps back in their work by pressing backspace multiple times.

Users can move multiple steps back in their work by pressing backspace multiple times.

Can u please elaborate

Just like letters can be removed by backspace if we write something wrong, Users can remove a mark from canvas by pressing backspace.

For the erasing purpose we will create a utility box , which will have an eraser , also an undo feature and all clear button. So will work shortly on that . So u can try contributing there . Until then I don't think this issue has any point .
Thanks for showing interest .


enable internal kv bucket in llama

What does this PR do?

To enhance throughput in scenarios with long new tokens, break down the KV cache into multiples of the bucket width. Use this to compute attention rather than using the entire KV cache. Below are some results from LLaMA2 7B/70B on Gaudi2:

| TP | Input Length | Output Length | BS | Base Throughput | Throughput w/   internal kv bucket
-- | -- | -- | -- | -- | -- | --
LLaMA v2-7B | 1 | 128 | 2048 | 76 | 1402 | 2217   (bucket=128)
LLaMA v2-7B | 2 | 2048 | 2048 | 64 | 1417 | 1672 (bucket=128)
LLaMA  v2-70B | 4 | 128 | 2048 | 240 | 2834 | 3638 (bucket=256)

Add --bucket_size=128 --bucket_internal to the commands to enable the feature.

@ssarkar2  - Maybe we should remove the original bucketing logic in separate PR later for simplicity of the overall code once we are convinced that this PR bucketing logic is best for all cases.
Btw everyone - I will add an option of clear cache too in utils.py (just an API call to release HPU graph memory) in a separate PR to address some corner cases where memory may increase with the bucketing changes of this PR.

@puneeshkhanna , the original external bucketing is general for any model and does not need model file change. It might be useful for unknown/new/unoptimized models.
However for max perf, we have to modify model files for internal cache (like this one).
Let me know if its worth it to keep the general external one that might work for any model

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


k8s-conformance-test need to decrease default Security Context Constraint policies on OpenShift to run successfully

Description of problem:
When running the k8s-conformance-tests on OpenShift we need to decrease default SCC policies to make the tests schedule and run. When troubleshooting we can see a lot of pods with privileged secutirytContexts being scheduled on azure-arc namespace.
So to make the jobs run correctly we needed to run those modifications:

allow all services accounts to run as privileged SCC (it could be more specific for NS or SA, but we have no visibility of what SA is used by the jobs)

oc adm policy add-scc-to-group privileged system:authenticated system:serviceaccounts
oc adm policy add-scc-to-group anyuid system:authenticated system:serviceaccounts

Note: I tried to run allow only the serviceAccount sonobuoy-serviceaccount (defined here) but did not work.

We perceived that the pods scheduled on azure-arc namespace need two constraints to be enabled (which is already allowed on restricted policy:
allowHostDirVolumePlugin: true
allowPrivilegedContainer: true

Version-Release number of selected component (if applicable):

Kubernetes distribution:

- Upstream Kubernetes Version: v1.22.3+e790d7f
- K8s Distribution Version: OpenShift Container Platform 4.9.17

arc-k8s-platform/platform.yaml

arck8sconformance.azurecr.io/arck8sconformance/clusterconnect:0.1.5

aak8sSupportPolicy.txt

1.5.2
1.4.0
1.3.8

sonobuoy

$ sonobuoy version
Sonobuoy Version: v0.56.0
MinimumKubeVersion: 1.17.0
MaximumKubeVersion: 1.99.99
GitSHA: 0665cd322b11bb40c2774776de765c38d8104bed

How reproducible:
Always
Steps to Reproduce:

Run the k8s conformance test script: bash -x k8s-conformance-test-suite.sh
Observe the logs of plugin jobs/pods in sonobuoy namespace, and deployments in azure-arc namespace

Actual results:
When allowing serviceAccounts to run as privileged, the jobs will run successfully:
oc adm policy add-scc-to-group privileged system:authenticated system:serviceaccounts
oc adm policy add-scc-to-group anyuid system:authenticated system:serviceaccounts

Expected results:
No need to allow serviceAccounts to run as privileged context.
Additional info:
Researching about sonobuoy requirements for a custom plugin, I can see that it does not require by default plugins to run as privileged. So I am assuming that the elevated privileges are being added by custom plugins that is created and new resources created by its plugins.
Look at the example of a custom plugin I've tested:

Create the sample plugin

$ sonobuoy gen plugin \
  --name=hello-world \
  --image schnake/easy-sonobuoy-cmds:v0.1 \
  --arg="echo hello world" > hello-world.yaml

Check the pod spec without escalating privileges by default: $ cat hello-world.yaml

sonobuoy-config:
  driver: Job
  plugin-name: hello-world
  result-format: raw
spec:
  args:
  - echo hello world
  command:
  - ./run.sh
  image: schnake/easy-sonobuoy-cmds:v0.1
  name: plugin
  resources: {}
  volumeMounts:
  - mountPath: /tmp/sonobuoy/results
    name: results

Run it

$ sonobuoy run --plugin hello-world.yaml --dns-namespace="" --dns-pod-labels="" --wait
(...)

0:56:58         PLUGIN     NODE     STATUS   RESULT   PROGRESS
10:56:58    hello-world   global   complete   passed
10:56:58
10:56:58 Sonobuoy plugins have completed. Preparing results for download.
(...)
10:59:58 Sonobuoy has completed. Use `sonobuoy retrieve` to get results.

Get the results

$ res_file=$(sonobuoy retrieve) && \
  mkdir results && tar -xf $res_file -C results &&
  cat results/plugins/hello-world/sonobuoy_results.yaml

name: hello-world
status: passed
meta:
  type: summary
items:
- name: out0
  status: passed
  meta:
    file: results/global/out0

@mtulio This is not a trait of the conformance tests but the nature of Arc enabled K8s. We are dabbling with introducing a "least-privileged" mode for Arc K8s which will reduce the permissions our service accounts take to exactly what's needed. But this would come at the cost of ease of onboarding, upgrades and usage.


Revert the apiserver flag change in the apiserver-deployment.yaml template

This reverts the apiserver-deployment.yaml template for the helm chart. A recent commit rebased onto k8s 1.10. In this, there was a change to replace the old admission control flag with two new ones.
The old flag is deprecated but still works. In the current state, the chart does not work on older versions of k8s.
This is a tactical fix, to get things running now. I have a better fix that I can PR when we release 0.15.0 that actually has the 1.10 API server stuff in it.
Fixes #1962

We should just do a release so the apiserver has the new option.

not needed since we released 0.1.15.


entity_id issues

Some of the stuff in blacklist and other areas can repeat therefore they need to be an objected or an id generated together not just one solid thing.

This should be solved I think?


Gene names in pathway thumbnails

Check and update pathway thumbnails for updated gene symbols:
e.g.
Akt1 -> Akt (PVR, Insulin)
This is fine as Nick asked for change when making thumbnail
But need to check over others...

While checking, I saw the following:

For cGAS-STING we have "cGLR1" and "cGLR2", while the symbols in FB are "cGlr1" and "cGlr2". Also, Relish is represented as "rel", but the symbol in FB is "Rel"
For EGFR in the thumbnail there is "cbl", but the symbol is "Cbl"
In the Hedgehog thumbnail there is a minimal issue: "CkIα" is represented as "Ck1α", so using Arabic numbers instead of Roman. Then "slmb" is shown as "Slmb"
In Hippo "ft" is shown as "fat"; "shg" is in the thumbnail, but not in the group; "Zyx" is shown as "zyx"; there is a lonely "d", which I suppose should be "dachs"?
Imd: "Uev1A" is shown as "Uev1a"; Shouldn't "Tab1" in the thumbnail be "Tab2"?; "Rel" is again shown as "rel"; "Jra" in not in the pathway group
Insulin: this is minor, but "PI3K" could be "Pi3K"; "Tor" has now become "mTor"
JAK-STAT seems fine
Notch: "Dl" is now "Delta"; "gro" and "CtBP" are not in the group
Pvr: "Tor" in now "mTor"; "PI3K" could be "Pi3K"; "raptor" is not in the group
Sevenless: "sos" in thumbnail should be "Sos"
TNFalpha/Eiger: "Uev1A" is shown as "Uev1a"
Toll seems fine
Torso seems fine
Wnt-TCF: "Slmb" in thumbnail should be "slmb"

Hey @gantonazzo we have a budget for an annual subscription to Adobe Creative Cloud - do you want to get this and then we can edit when we like rather than having to go via Nick?

I guess we could do it, so we can edit the gene names ourselves. Previously these kind of licenses were bought by Steven with a PO. How does it work now?

I just renewed Nick's license.  You need to buy it via the Academia PunchOut on the CUFS system, and register it to a particular user. Can either get all products (creative cloud) or just specific products (e.g. illustrator), which is cheaper.  I can do it for you if u like.

Sounds good to me!


Error launching workspace locall: Can't resolve hostname to Coder workspace container

Summary
Coder Remote VSCode extension throws error while attempting to connect to remote development environment.
In the VSCode logs, you can see that Coder is attempting to connect to a hostname that doesn't actually exist.
Repro Steps

Run Coder v2 as Docker Container
Use Cloudflare Tunnels to forward a public hostname ie. editor.mydomain.com to Coder container
Connect to Coder web interface and create first user
Create a workspace template and workspace
Attempt to open the workspace in local VSCode
Observe error details below

NOTE: Connecting to the Coder workspace, using the web-based environment, works perfectly fine.
Server Environment

Ubuntu 22.04 LTS
Docker Engine version:latest
Coder container v0.19.2+7eb2c2f

Run your Coder server container with this command from the documentation.
export DOCKER_GROUP=$(getent group docker | cut -d: -f3)
docker run --detach --interactive --tty --env CODER_ACCESS_URL="https://editor.mydomain.com" --env CODER_HTTP_ADDRESS=<IP_ADDRESS>:3925 --volume /var/run/docker.sock:/var/run/docker.sock --net=host --group-add $DOCKER_GROUP ghcr.io/coder/coder:latest

Client Environment

MacOS Ventura
VSCode 1.76.1
Coder v0.1.13

Expected Results
VSCode successfully opens Coder workspace locally.
Actual Results

[20:21:41.980] Log Level: 2
[20:21:41.984] VS Code version: 1.76.1
[20:21:41.984] Remote-SSH version<EMAIL_ADDRESS>[20:21:41.984] darwin x64
[20:21:47.448] SSH Resolver called for "ssh-remote+coder-vscode--trevor--trevor01", attempt 1
[20:21:47.448] "remote.SSH.useLocalServer": true
[20:21:47.448] "remote.SSH.path": undefined
[20:21:47.449] "remote.SSH.configFile": ~/.ssh/vscode-config
[20:21:47.449] "remote.SSH.useFlock": true
[20:21:47.449] "remote.SSH.lockfilesInTmp": false
[20:21:47.449] "remote.SSH.localServerDownload": auto
[20:21:47.450] "remote.SSH.remoteServerListenOnSocket": false
[20:21:47.450] "remote.SSH.showLoginTerminal": false
[20:21:47.450] "remote.SSH.defaultExtensions": ["gitpod.gitpod-remote-ssh"]
[20:21:47.450] "remote.SSH.loglevel": 2
[20:21:47.450] "remote.SSH.enableDynamicForwarding": true
[20:21:47.451] "remote.SSH.enableRemoteCommand": false
[20:21:47.451] "remote.SSH.serverPickPortsFromRange": {}
[20:21:47.451] "remote.SSH.serverInstallPath": {}
[20:21:47.454] SSH Resolver called for host: coder-vscode--trevor--trevor01
[20:21:47.455] Setting up SSH remote "coder-vscode--trevor--trevor01"
[20:21:47.458] Acquiring local install lock: /var/folders/bw/yc3krqjs11bdctkqj_clqf4c0000gn/T/vscode-remote-ssh-5514b554-install.lock
[20:21:47.459] Looking for existing server data file at /Users/trevor/Library/Application Support/Code/User/globalStorage/ms-vscode-remote.remote-ssh/vscode-ssh-host-5514b554-5e805b79fcb6ba4c2d23712967df89a089da575b-0.98.0/data.json
[20:21:47.460] Using commit id "5e805b79fcb6ba4c2d23712967df89a089da575b" and quality "stable" for server
[20:21:47.465] Install and start server if needed
[20:21:47.469] PATH: /usr/local/microsoft/powershell/7:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/share/dotnet:~/.dotnet/tools:/Library/Apple/usr/bin
[20:21:47.469] Checking ssh with "ssh -V"
[20:21:47.475] > OpenSSH_9.0p1, LibreSSL 3.3.6

[20:21:47.477] Using SSH config file "/Users/trevor/.ssh/vscode-config"
[20:21:47.477] askpass server listening on /var/folders/bw/yc3krqjs11bdctkqj_clqf4c0000gn/T/vscode-ssh-askpass-8590af0b0811d93cba6cf619a91f4db8265d4eb3.sock
[20:21:47.478] Spawning local server with {"serverId":1,"ipcHandlePath":"/var/folders/bw/yc3krqjs11bdctkqj_clqf4c0000gn/T/vscode-ssh-askpass-ad9ca0ed08af24442e5d3863267cc3a984a1ebbd.sock","sshCommand":"ssh","sshArgs":["-v","-T","-D","52506","-o","ConnectTimeout=15","-F","/Users/trevor/.ssh/vscode-config","coder-vscode--trevor--trevor01","bash"],"serverDataFolderName":".vscode-server","dataFilePath":"/Users/trevor/Library/Application Support/Code/User/globalStorage/ms-vscode-remote.remote-ssh/vscode-ssh-host-5514b554-5e805b79fcb6ba4c2d23712967df89a089da575b-0.98.0/data.json"}
[20:21:47.478] Local server env: {"SSH_AUTH_SOCK":"/private/tmp/com.apple.launchd.9s5lZKgmdO/Listeners","SHELL":"/usr/local/bin/pwsh","DISPLAY":"1","ELECTRON_RUN_AS_NODE":"1","SSH_ASKPASS":"/Users/trevor/.vscode/extensions/ms-vscode-remote.remote-ssh-0.98.0/out/local-server/askpass.sh","VSCODE_SSH_ASKPASS_NODE":"/Applications/Visual Studio Code.app/Contents/Frameworks/Code Helper (Plugin).app/Contents/MacOS/Code Helper (Plugin)","VSCODE_SSH_ASKPASS_EXTRA_ARGS":"--ms-enable-electron-run-as-node","VSCODE_SSH_ASKPASS_MAIN":"/Users/trevor/.vscode/extensions/ms-vscode-remote.remote-ssh-0.98.0/out/askpass-main.js","VSCODE_SSH_ASKPASS_HANDLE":"/var/folders/bw/yc3krqjs11bdctkqj_clqf4c0000gn/T/vscode-ssh-askpass-8590af0b0811d93cba6cf619a91f4db8265d4eb3.sock"}
[20:21:47.479] Spawned 99503
[20:21:47.624] > local-server-1> Running ssh connection command: "-v -T -D 52506 -o ConnectTimeout=15 -F /Users/trevor/.ssh/vscode-config coder-vscode--trevor--trevor01 bash"
[20:21:47.626] > local-server-1> Spawned ssh, pid=99507
[20:21:47.631] stderr> OpenSSH_9.0p1, LibreSSL 3.3.6
[20:21:47.634] stderr> ssh: Could not resolve hostname coder-vscode--trevor--trevor01: nodename nor servname provided, or not known
[20:21:47.635] > local-server-1> ssh child died, shutting down
[20:21:47.639] Local server exit: 0
[20:21:47.639] Received install output: local-server-1> Running ssh connection command: "-v -T -D 52506 -o ConnectTimeout=15 -F /Users/trevor/.ssh/vscode-config coder-vscode--trevor--trevor01 bash"
local-server-1> Spawned ssh, pid=99507
OpenSSH_9.0p1, LibreSSL 3.3.6
ssh: Could not resolve hostname coder-vscode--trevor--trevor01: nodename nor servname provided, or not known
local-server-1> ssh child died, shutting down

[20:21:47.642] Resolver error: Error: Could not resolve hostname
	at m.Offline (/Users/trevor/.vscode/extensions/ms-vscode-remote.remote-ssh-0.98.0/out/extension.js:1:584439)
	at /Users/trevor/.vscode/extensions/ms-vscode-remote.remote-ssh-0.98.0/out/extension.js:1:581669
	at t.handleInstallOutput (/Users/trevor/.vscode/extensions/ms-vscode-remote.remote-ssh-0.98.0/out/extension.js:1:582037)
	at Object.e [as tryInstallWithLocalServer] (/Users/trevor/.vscode/extensions/ms-vscode-remote.remote-ssh-0.98.0/out/extension.js:1:623670)
	at process.processTicksAndRejections (node:internal/process/task_queues:96:5)
	at async /Users/trevor/.vscode/extensions/ms-vscode-remote.remote-ssh-0.98.0/out/extension.js:1:643639
	at async t.withShowDetailsEvent (/Users/trevor/.vscode/extensions/ms-vscode-remote.remote-ssh-0.98.0/out/extension.js:1:647359)
	at async /Users/trevor/.vscode/extensions/ms-vscode-remote.remote-ssh-0.98.0/out/extension.js:1:622142
	at async C (/Users/trevor/.vscode/extensions/ms-vscode-remote.remote-ssh-0.98.0/out/extension.js:1:618648)
	at async t.resolveWithLocalServer (/Users/trevor/.vscode/extensions/ms-vscode-remote.remote-ssh-0.98.0/out/extension.js:1:621757)
	at async t.resolve (/Users/trevor/.vscode/extensions/ms-vscode-remote.remote-ssh-0.98.0/out/extension.js:1:644967)
	at async /Users/trevor/.vscode/extensions/ms-vscode-remote.remote-ssh-0.98.0/out/extension.js:1:720839
[20:21:47.644] ------

Hey @pcgeek86 :wave: This is odd... can you bring up the output panel for Coder? I'm not sure why we'd be trying to mkdir in your home.

Hello @kylecarbs, here's the output I'm seeing for the Coder extension in VSCode. I replicated the same problem from my Windows 11 client workstation.
Using binName: coder-windows-amd64.exe
Using binPath: c:\Users\TrevorSullivan\scoop\apps\vscode\1.76.2\data\user-data\User\globalStorage\coder.coder-remote\bin\coder-windows-amd64.exe
Using ETag:
Response status code: 200
Downloaded binary: c:\Users\TrevorSullivan\scoop\apps\vscode\1.76.2\data\user-data\User\globalStorage\coder.coder-remote\bin\coder-windows-amd64.exe

Well let me write a test first before I fully confirm it ;p @pcgeek86

Well let me write a test first before I fully confirm it ;p @pcgeek86

Good plan! Will resolving the tilde correct the DNS error? It's trying to find a hostname with no DNS suffix on it, which is rather bizarre.

@pcgeek86 to confirm this will work on your computer, can you try specifying a manual path to the SSH config instead of using ~? I have a small fix, but would rather ensure it works on Windows before pushing.

Although I'm about 99% sure it'll fix it ;p

Confirmed working. Or at least, getting farther than before.

Thanks man, I appreciate it!!! Hope everyone else benefits from the fix as well.

New issue in logs:
2023/03/21 10:10:04 websocket Dial: failed to WebSocket dial: failed to send handshake request: Get "https://stun.l.google.com/derp": read tcp <IP_ADDRESS>:54517-><IP_ADDRESS>:443: wsarecv: An existing connection was forcibly closed by the remote host., <nil>2023/03/21 10:10:08 websocket Dial: failed to WebSocket dial: failed to send handshake request: Get "https://stun.l.google.com/derp": read tcp <IP_ADDRESS>:54519-><IP_ADDRESS>:443: wsarecv: An existing connection was forcibly closed by the remote host., <nil>2023/03/21 10:10:11 websocket Dial: failed to WebSocket dial: failed to send handshake request: Get "https://stun.l.google.com/derp": read tcp <IP_ADDRESS>:54522-><IP_ADDRESS>:443: wsarecv: An existing connection was forcibly closed by the remote host., <nil>2023/03/21 10:10:15 websocket Dial: failed to WebSocket dial: failed to send handshake request: Get "https://stun.l.google.com/derp": read tcp <IP_ADDRESS>:54545-><IP_ADDRESS>:443: wsarecv: An existing connection was forcibly closed by the remote host., <nil>

And what version are you running?

Humph, alright let me investigate this. We had a regression for some port-related DERP/STUN stuff in v0.19.0 but we patched it super quick, maybe something related to the STUN server slipped through.
I'll get an answer for you soon!

Added you on Discord


Update WindowsBuild.md

Update build rules to use ICU 64.2.  The CI is migrating to ICU 64.2 which is locally built to avoid spurious failures in the build due to download failures.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

CC: @milseman @millenomi @gwynne @gmittert @drodriguez @troughton

@swift-ci please smoke test

@compnerd do you want to change the CI to also use 64.2? It should be easy if no other changes are needed.

@drodriguez yeah, actually trying to do that with the VS2019 AMD64 build, and once that succeeds, I'll change the other one as well.  Would you mind doing the change for the community CI?  (I'm just pulling the build from Azure now)

Created #25134 for whenever you are ready.


Allow null & blank for PickleField.

The default behaviour of PickleField was changed in 2.0 from null=True to
null=False. This causes issues with fields such as an image_field which
will try storing a NULL when unset. This small change is backwards and
forwards version safe.

Thank you.


Add find and replace functionality to the resources editor

Note: Selenium test for this UI change is work in progress

What jira related to this commit? Is this the UI fix only?


bug(MatAutocomplete): "Required Field" asterisk is clipped In High Contrast Mode

Reproduction
Steps to reproduce:

Enable High Contrast Mode on Windows
Open Firefox
Go to demo at https://angular-dlazwc.stackblitz.io/
Click the input field but don't select anything, observe clipped label at top

Expected Behavior
Expected a bit more padding to the right of the asterisk to improve visibility and readability
Actual Behavior
The asterisk is slightly clipped when using Firefox + Windows HC (attached image is Chrome on left, Firefox on right)

Environment

Angular: Demo forked from example at https://material.angular.io/components/autocomplete
Browser(s): Firefox 90.0.2 (64-bit)
Operating System: Windows 10 Enterprise 10.0.19042

I've taken a stab at this a couple of times over the years, but I haven't been able to find a good way to hide the border on Firefox in high contrast mode. For IE and Chrome we use a hack with border-image: linear-gradient(transparent, transparent), but that doesn't work on Firefox for some reason. Ideally we wouldn't be using a border for the top spacing in the first place, but last time we tried replacing it, we couldn't quite get the baseline to align correctly.

Just commenting for reference (hopefully this helps), it looks like the MDC Web version of this component (https://github.com/material-components/material-components-web) uses a dashed border to resolve this issue.

Closing since we're now switched over to the MDC form field which doesn't seem to have this problem.


Add missing revised_prompt property to ImageDataResult model

based on this request: https://github.com/betalgo/openai/issues/430
according to the related API: https://platform.openai.com/docs/api-reference/images/object

hi, @belaszalontai could you update the target branch as dev branch, please?


Implemented commands for self-testing feature

Codecov Report

Merging #86 into master will increase coverage by 1.16%.
The diff coverage is 92.64%.

@@             Coverage Diff              @@
##             master      #86      +/-   ##
============================================
+ Coverage     71.20%   72.37%   +1.16%
- Complexity      373      391      +18
============================================
  Files            68       71       +3
  Lines          1160     1227      +67
  Branches        110      116       +6
============================================
+ Hits            826      888      +62
- Misses          304      308       +4
- Partials         30       31       +1

Impacted Files
Coverage Δ
Complexity Δ

.../seedu/address/logic/parser/AddressBookParser.java
80.00% <0.00%> (-20.00%)
12.00 <0.00> (ø)

src/main/java/seedu/address/model/Model.java
100.00% <ø> (ø)
1.00 <0.00> (ø)

.../main/java/seedu/address/ui/FlashCardCardView.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

.../java/seedu/address/model/flashcard/FlashCard.java
94.44% <80.00%> (-2.33%)
18.00 <2.00> (+2.00)
:arrow_down:

...a/seedu/address/logic/commands/EndQuizCommand.java
100.00% <100.00%> (ø)
3.00 <3.00> (?)

...java/seedu/address/logic/commands/NextCommand.java
100.00% <100.00%> (ø)
5.00 <5.00> (?)

...java/seedu/address/logic/commands/QuizCommand.java
100.00% <100.00%> (ø)
3.00 <3.00> (?)

...rc/main/java/seedu/address/model/ModelManager.java
100.00% <100.00%> (ø)
28.00 <6.00> (+5.00)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2f5c1c...b075d70. Read the comment docs.


HDDS-4801. Skip coverage check for PRs and in forks

What changes were proposed in this pull request?
Currently coverage CI check:

calculates combined test coverage
uploads it to Sonar only for Apache Ozone repo and only for builds on push/schedule
stores combined coverage in GitHub Actions artifact

Thus for PR in Apache Ozone and for all builds in forks, it only stores coverage in the artifact.  These expire in 30 days and I don't think anybody really checks them manually.
I propose to completely skip coverage check for PRs and in forks, instead of only skipping upload to Sonar.  This would save ~12 minutes for such builds.
https://issues.apache.org/jira/browse/HDDS-4801
How was this patch tested?
https://github.com/adoroszlai/hadoop-ozone/runs/1849668371

it would be easy to create a Github actions scripts to compare the coverage artifacts between PR and master and create a report.

That's also what Codecov was supposed to do, but it had been disabled earlier due to unreliability.

Thanks @elek for reviewing and committing it.


copying large tables subsequently causes query to fail

What happens?
Copying/caching large tables subsequently causes query to fail and random erros to pop up such as:

duckdb.duckdb.IOException: IO Error: Unable to read binary COPY data from Postgres: no COPY in progress
duckdb.duckdb.IOException: IO Error: Unable to read binary COPY data from Postgres: no COPY in progress message contents do not agree with length in message type "d"
duckdb.duckdb.IOException: IO Error: Postgres scanner - out of buffer in ReadString
duckdb.duckdb.IOException: IO Error: Unable to read binary COPY data from Postgres: lost synchronization with server: got message type "

For example, a table with  100k rows (<2k per row) followed by a table with another 100k or more. Seems to be related to threading. Setting threads to 1 fixes it.
Not particulaly bothered by it since we have a workaround. Just wanted the duckdb team to know since someone else might  run into it.
To Reproduce
        self.duckdb.execute(f"""
            ATTACH '{dbstr}' AS pgdb (TYPE postgres);
            CREATE TABLE table1 AS FROM pgdb.table1;
            CREATE TABLE table2 AS FROM pgdb.table2;
        """)

Work around:
               SET threads TO 1;

OS:
debian
PostgreSQL Version:
all
DuckDB Version:
0.9.2
DuckDB Client:
Python
Full Name:
Adnan Yunus
Affiliation:
OpusAI
Have you tried this on the latest main branch?

[X] I agree

Have you tried the steps to reproduce? Do they include all relevant data and configuration? Does the issue you report still appear there?

[X] I agree

Thanks for the report - this sounds like it might be related to #149. Could you try this on the latest nightly to check if this still reproduces:
force install postgres_scanner from 'http://nightly-extensions.duckdb.org';

@Mytherin that fixed intermittent no COPY in progress for me! 🙏🏻

I'm using python so I tried pip install duckdb==0.9.3.dev2258 and that seems to work. 0.9.2 is the version where I'm still getting this error

Likely fixed already - feel free to re-open if you encounter this error in a newer release


'str' object has no attribute 'gpt2_encoder_json' while loading bart checkpoint fine-tuned on CNN/DM

🐛 Bug

I followed this tutorial on fine-tuning a pre-trained BART model on the CNN/DM dataset. Fine-tuning on CNN/DM runs fine but I'm facing an issue during inference.
To Reproduce
Steps to reproduce the behavior

Fine-tuning command:

TOTAL_NUM_UPDATES=20000
WARMUP_UPDATES=500
LR=3e-05
MAX_TOKENS=2048
UPDATE_FREQ=32
BART_PATH=pre_trained/bart.large/model.pt
DATA_PATH=data/cnndm/bart_format/bin
SAVEDIR=cnndm_vanilla_ckpt

CUDA_VISIBLE_DEVICES=0 fairseq-train $DATA_PATH \
    --restore-file $BART_PATH \
    --save-dir $SAVEDIR \
    --max-tokens $MAX_TOKENS \
    --task translation \
    --source-lang source --target-lang target \
    --truncate-source \
    --layernorm-embedding \
    --share-all-embeddings \
    --share-decoder-input-output-embed \
    --reset-optimizer --reset-dataloader --reset-meters \
    --required-batch-size-multiple 1 \
    --arch bart_large \
    --criterion label_smoothed_cross_entropy \
    --label-smoothing 0.1 \
    --dropout 0.1 --attention-dropout 0.1 \
    --weight-decay 0.01 --optimizer adam --adam-betas "(0.9, 0.999)" --adam-eps 1e-08 \
    --clip-norm 0.1 \
    --lr-scheduler polynomial_decay --lr $LR --total-num-update $TOTAL_NUM_UPDATES --warmup-updates $WARMUP_UPDATES \
    --fp16 --update-freq $UPDATE_FREQ \
    --skip-invalid-size-inputs-valid-test \
    --log-interval 10 \
    --find-unused-parameters >> $SAVEDIR/train.log 2>&1

Inference code snippet:

import torch
from fairseq.models.bart import BARTModel

bart = BARTModel.from_pretrained(
    'cnndm_vanilla_ckpt',
    checkpoint_file='checkpoint_best.pt',
    data_name_or_path='data/cnndm/bart_format/bin'
)

The error I get is:

File "generate.py", line 8, in main
    bart = BARTModel.from_pretrained(
  File "/projects/tir4/users/mbhandar2/misc/fairseq/fairseq/models/bart/model.py", line 124, in from_pretrained
    return BARTHubInterface(x["args"], x["task"], x["models"][0])
  File "/projects/tir4/users/mbhandar2/misc/fairseq/fairseq/models/bart/hub_interface.py", line 30, in __init__
    super().__init__(cfg, task, [model])
  File "/projects/tir4/users/mbhandar2/misc/fairseq/fairseq/hub_utils.py", line 106, in __init__
    self.bpe = encoders.build_bpe(cfg.bpe)
  File "/projects/tir4/users/mbhandar2/misc/fairseq/fairseq/registry.py", line 50, in build_x
    return builder(cfg, *extra_args, **extra_kwargs)
  File "/projects/tir4/users/mbhandar2/misc/fairseq/fairseq/data/encoders/gpt2_bpe.py", line 32, in __init__
    encoder_json = file_utils.cached_path(cfg.gpt2_encoder_json)
AttributeError: 'str' object has no attribute 'gpt2_encoder_json'

Environment

fairseq Version: 1.0.0a0
PyTorch Version: 1.6.0
OS: Linux
How you installed fairseq: from source
Build command you used (if compiling from source): pip install --editable ./
Python version: 3.8.3
CUDA/cuDNN version: 10.1
GPU models and configuration: Tesla V100
Any other relevant information: Using conda

Additional context
Strangely, I'm able to load the pre-trained bart.large model provided by the authors here as well as their fine-tuned version provided here but not my own fine-tuned version. I'm guessing the error is creeping from my fine-tuning command but I can't figure it out.

I was able to resolve this, commenting here for future reference. The command for fine-tuning on CNN/Dailymail as given in this tutorial needs to include the flag --bpe gpt2 which allows fairseq to save bpe information in it's cfg when saving the model. This flag is set in the pre-trained and fin-tuned checkpoints shared by the authors (hence I was able to load the shared checkpoints but not those that I trained). I would suggest adding the flag to the tutorial to avoid similar issue in the future.


refactor: test case adjustment

Codecov Report
Patch coverage has no change and project coverage change: +0.34% :tada:

Comparison is base (9bcd23c) 78.16% compared to head (cef0ada) 78.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
+ Coverage   78.16%   78.50%   +0.34%
==========================================
  Files           5        5
  Lines         870      870
==========================================
+ Hits          680      683       +3
+ Misses        134      132       -2
+ Partials       56       55       -1

see 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[crypto] Make the fiat feature control whether we even load forks

We use formally verified crypto (https://crates.io/crates/fiat-crypto) in maintained forks of the dalek suite of libraries ({curve, ed, x}25519-dalek).
This usage is controlled by a feature in the dependent crates, which we always use, simply turning the feature on by default.
This construction provides meaningful safety improvements against a class of arithmetic bugs in Libra's upstream libraries, which we hope to merge in the future.
In some contexts (e.g. vendored dependencies), where it is difficult to load several versions of the same package, we would like to not even download those forked packages, and rather use the underlying vanilla projects from the dalek suite of libraries.
This PR offers this opportunity by putting a feature in control of the choice of dependency (fork vs. vanilla dependency), rather than whether the formally verified backend is activated.
The feature requirements are carefully designed to operate under feature additivity, and testing with --all-features (until @metajack revives https://github.com/libra/libra/pull/3134 ).
The behavior is not changed by this PR: the formally verified backend is still activated by default, and its vanilla variant is still tested in CI.

@bors-libra r=kchalkias

:pushpin: Commit 3e709ef has been approved by kchalkias

:hourglass: Testing commit 3e709efe8e00ebbbbc3f59108dbca20216fc6701 with merge 0d84475b02d278056acb67ed29ffee3cde28a9a0...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: kchalkias
Pushing 0d84475b02d278056acb67ed29ffee3cde28a9a0 to master...


10.0.22621.2861

Windows 11 Version 23H2 (OS Build 22631.3007) Enterprise Edition
after auto update
termsrv.zip

Duplicate of https://github.com/stascorp/rdpwrap/issues/2443


Fix Buck files after removing RecyclerViewBackedScrollView

Remove unused deps to fix broken CI: https://circleci.com/gh/facebook/react-native/15242
Missed this in https://github.com/facebook/react-native/commit/6ec5654e7a26b856dbe26b2ba74c15ec258f065e.
Test plan (required)
The buck fetch that's failing on CI worked locally.

@facebook-github-bot shipit-ninja


Small refactor to ScreenshotLab and possible fix for junit5 screenshoter issue

Proposed changes
Small refactoring for ScreenshotLab class for readability and possible fix for Junit5 issue.
Checklist

[x] Checkstyle and unit tests pass locally with my changes by running gradle check chrome htmlunit command
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

The aforementioned fix is actually a bad one, i would suggest injecting dependency of Selenide from Allure and check if Listeners pool contains object of instance of class AllureSelenide.


Trait 'Rinvex\Support\Traits\ConsoleTools' not found

Hello, after composer require,
In WidgetsServiceProvider.php line 16:
Trait 'Rinvex\Support\Traits\ConsoleTools' not found
and on  artisan make:widget RecentPosts
Symfony\Component\Debug\Exception\FatalThrowableError  : Call to undefined method Rinvex\Widgets\Providers\WidgetsServiceProvider::publishesViews()
Edit : require error on master, ok on develop

Thank you for reporting this, it's now fixed on both develop and master, check new release v3.0.1


[otbn,dv] Fix some warnings in the OTBN DV build

See commit messages for details.

Ah, I see. Your suggestion works because 1 << 31 is a valid unsigned 32-bit number. Of course, it won't work if we need a 33 bit number anywhere.
In my free time, I've spent literally hours staring at section 11 of IEEE-1800. It's really hard to follow! Especially all the stuff about self-determined vs. non-self-determined bit lengths.


(#16) code cleaning and fixing codacy issues

Type of request

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Refactoring
[ ] Documentation or documentation changes

Related Issue(s)

https://github.com/aposin/MergeProcessor/issues/16
Concept

Code clean up for better readability and codacy issues reduction.
Description of the change

Code clean up following the input from the codacy issues list.
Description of current state
Some code causes codacy issues.
Description of target state
Some codacy issues are fixed.
Estimated investment / approximate investment

30 min.
Initiator
name / company / position / created at
D. Ceraso
Technical information
Platform / target area

known side-effects
other
DB Changes (if so: incl. scripts with definitions and testdata)
How has this Tested?

Project was build in eclipse and tests were run.
Screenshots, Uploads, other documents (if appropriate):

Checklist:

[x] All the commits are signed.
[x] My code follows the code style of this project.
[x] I agree with die CLA.
[x] I have read the CONTRIBUTING docs.
[ ] I have added/updated necessary documentation (if appropriate).

Hi @davu-all,
thanks for code cleanup. These fixes must have taken some time and look good overall. 👍
At the moment the code coverage of the patch is too low. Maybe you can write additional JUnit-Test on GITMergeUnit testing hashCode() and equals(). Then the coverage should hopefully be enough.
Reg.


Add kahn's algorithm

Kahn's algorithm is used to perform a topological sort on a directed acyclic graph with time complexity of O ( V + E ) O(V + E) O(V+E) – where V is the number of vertices and E is the number of edges in the graph.
Add it to c++  graph repository.
@Kumar-laxmi
can you assign me this issue.

refer #710


labhub: Remove unused invited_users set

https://github.com/coala/corobo/blob/330faad06a8c5295c107ac46b26f1e10cef7402a/plugins/labhub.py#L64

@JustBeYou please get assigned to the issue first


Add settings icon @3x size

I just added Settings icon for iPhone 6s Plus and iPhone 6 Plus (@3x) - #1

@elegantcoder Thanks for your contribution! Unfortunately, there are not tests for your change, so I cannot merge. Would you mind adding a test for you change? Thanks in advance. -David

Ok, I added the test too. Thanks for your great project :)

@elegantcoder Thanks again. This was just released on github and npm.


feat: profile forms

NOTE: needs updating to use Mongo from PR https://github.com/EddieHubCommunity/LinkFree/pull/5765
Fixes Issue
closes #5575
To access forms visit /account/manage/profile
TODO

[ ] profile form
[ ] tags form
[ ] links form (+ social shortcut toggle)
[ ] testimonials form
[ ] events form
[ ] milestones form
[ ] main navbar to access profile form and statistics page

Changes proposed

Check List (Check all the applicable boxes)

[ ] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.
[ ] This PR does not contain plagiarized content.
[ ] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

@iamthecloverly please do not approve pull requests that is still in draft and have a list of tasks still to be completed in the pull request description - this causes confusion in the project and community, you have been warned about this already before

@iamthecloverly please do not approve pull requests that is still in draft and have a list of tasks still to be completed in the pull request description - this causes confusion in the project and community, you have been warned about this already before

Sorry for that!
Won't repeat again

Closing and raising a new PR https://github.com/EddieHubCommunity/LinkFree/pull/6998


Packages and stack

This degrades the initial UX because it looks like you have to manually set the stack size. Is there any reason to distinguish between stack and heap anyways since we have allocators in userspace?

This degrades the initial UX because it looks like you have to manually set the stack size. Is there any reason to distinguish between stack and heap anyways since we have allocators in userspace?

This actually increases long-term UX as you will now easily find stack overflows by triggering "SIGBUS" on most devices instead of silently corrupting the heap. Imho, this is an important security and safety feature

I understand the value but the defaults are wrong. If someone just uses the default, as soon as they use more than 1024 bytes of the stack they'll just have a runtime crash which will be especially difficult to debug if they are new.
Instead the default value for the stack size config should be null, so that people who know what they're doing can opt-in. Otherwise the full ram section is used for the stack.


Stop @recurse with internal filter

Hello! I'm trying to use trustfall to query my filesystem and find directories/files with certain properties (in this case, folders whose name is "target"). To do this right now I am defining an "input directory" that defines where the tool should begin to find these files, and then the query recurses until it finds the folder it wants. However, I'd like to stop the recursion when it finds that folder, e.g. output /target/ but not /target/target/. How can I do that? Here's my query as of right now:
{
    InputDirectory {
        ... on Directory {
            entries @recurse(depth:10) {
                ... on Directory {
                    name @filter(op: "=", value: ["$target"])
                    path @output
                }
            }
        }

    }
}

Thanks!

Unfortunately the query language currently doesn't have a way to do this. It's a feature I'd love to add in the future though!
In the meantime, you could work around this by defining a custom edge that implements the "recurse but stop on match" behavior:
{
    InputDirectory {
        ... on Directory {
            first_matching_directory(name: "target") {
                < rest of query here >
            }
        }
    }
}

Parameterized edges currently cannot use query variables like $target so as a workaround for that you'll need to pass a string literal for the name.
This "build it into the schema" trick is the standard workaround for all sorts of missing query functionality right now.


Introduce Chapter-3 Introduction Page

Closes #501

This PR introduces the Intro page and introduces the subsequent updates to progress to keep track of them.
This PR also temporarily introduces challenge-1 for Chapter-3, which is introduced to check the correct functioning of the "Continue" button. It will be removed before the final merge of PR.

@shaavan retargeted your branch to dev, please resolve conflicts when you have time, thanks

Updated from 70f79e9a115807b777557d1171dae4f55eca24ae to ff3d94c2f8f92c53f3f3618f47b94bcfd765c829 (pr516.01 -> pr516.02, diff)
Address @afterburn comment
Changes:

Rebased over dev
Resolved merge conflicts

Updated from ff3d94c2f8f92c53f3f3618f47b94bcfd765c829 to 5a1178b3952e7d024452fad6416a2a65c9fdba47 (pr516.02 -> pr516.03, diff)
Addressed @afterburn comment

Renamed you-vs-bit-1 -> solo-1
Renamed YVB1 -> SOL1


NIFI-2585 Add attributes to track s2s host and port

I left the three commits to show the history of how this evolved. We can squash my two commits when merging, but I wanted Randy to get credit for starting the work on this ticket.

@ijokarumawak since you have worked with a lot of the s2s code, would you be able to review this?

@bbende Sure, I will review this.

@bbende @randerzander
Thanks for proposing this feature, it'll be useful!
Started reviewing this, and noticed few things.

Difference between RAW and HTTP protocol for receiving data.
RAW resolves hostname from socket, while HTTP does so from HTTP request. Due to this difference, RAW uses hostname as s2s.host attribute like localhost, while HTTP set <IP_ADDRESS>. I think this may be difficult when users define routing rules in downstream flow. I wonder if it can produce the same value, hostname or ip address for both transport protocol.

Unknown hostname and port due to illegal URL
As discussed in the previous PR,  I got 'unknown' hostname and port with Docker containers. While this can be handled as a corner case since it's not allowed by the URL specification, I think it'd be better if we can be lenient here to support Docker environment. I confirmed provenance event also failed to resolve hostname and produced provenance details with null hostname.
I think this can be improved by changing Peer's constructor. It parses peerUrl then use its hostname and port, but the same information should be retrieved from PeerDescriptor without parsing the URL. Currently, SocketRemoteSiteListener uses server's hostname and port for PeerDescription, but it seems it's not correct, those should be client's.

Please let me dig deeper comments above. Will update soon.

Created another PR #1342, to describe my concerns and possible solutions.


Any plans vSphere/NSX-T provider?

https://github.com/terraform-providers/terraform-provider-nsxt
https://github.com/terraform-providers/terraform-provider-vsphere
Honestly, my personal use-case is weak and novel; I'd only use this for a homelab vSphere environment. Just curious if there were any plans to interface w/ these providers in the future?
Thanks, feel free to close this whenever.

Currently no, but you can add.


Add bucket to notification latency metric

Fixes https://github.com/prometheus/alertmanager/issues/3999

The test failure doesn't look related? I don't have permissions to rerun it.


channel.position often reflects creation order instead of sort order

Link
https://github.com/Rapptz/discord.py/issues/2392

would most likely need

docs improvement
__lt__ and the other 3 dunders maybe?
possibly a real position - property - that checks against all channels for the official position

going to change this to a documentation edit as this is too much effort for something that discord causes entirely


[do-not-merge] testing only

This change is

test-me-please

Coverage increased (+0.02%) to 42.027% when pulling 6fd6fe265a7f4344438e635117d7b63881f92cd5 on pr/test into 50ebcf33e94d16b83f22bedba7af0e61aa2b1086 on master.

test-me-please

test-me-please

test-me-please

test-me-please

passed, retry

test-me-please

passed, retry

test-me-please

passed, retry

test-me-please

passed, retry

test-me-please


Write to (and delete from) all assigned nodes for a key in distributed datastore

I spun up a 4 node cluster, inserted a key, then took the cluster secret to manually craft control port queries to get the protobuf-encoded /datastore/getv payload on each of them (since it doesn't yet have auto-forwarding when requesting a key not assigned to it) to see if I get the value or an error as a way to verify these changes:

@aguillenv I was confused at first, but I realized that we're accidentally including the global memory when we're protobuf-encoding the HandlerMemory records. We should not do that as it is guaranteed to be identical across all nodes and is making the payload a lot larger than expected, so that seems like another task to tackle.

@aguillenv I was confused at first, but I realized that we're accidentally including the global memory when we're protobuf-encoding the HandlerMemory records. We should not do that as it is guaranteed to be identical across all nodes and is making the payload a lot larger than expected, so that seems like another task to tackle.

https://github.com/alantech/meta/issues/192


Fix import from file code.

This implementation first resolves the module file relative to ReFrame. If it is inside ReFrame's top-level dir, it uses the standard Python mechanism (from importlib) to import the module. If not it loads it directly from the file assigning it a module name derived from the file's basename.

Codecov Report

Merging #324 into bugfix/load_module_python_file will decrease coverage by 0.04%.
The diff coverage is 93.75%.

@@                        Coverage Diff                         @@
##           bugfix/load_module_python_file     #324      +/-   ##
==================================================================
- Coverage                           91.47%   91.43%   -0.05%
==================================================================
  Files                                  66       66
  Lines                                7828     7811      -17
==================================================================
- Hits                                 7161     7142      -19
- Misses                                667      669       +2

Impacted Files
Coverage Δ

unittests/test_utility.py
98.74% <100%> (ø)
:arrow_up:

reframe/utility/__init__.py
92.56% <87.5%> (-4.14%)
:arrow_down:

reframe/core/modules.py
68.01% <0%> (-1.4%)
:arrow_down:

reframe/core/config.py
84.54% <0%> (+1.81%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a19e70...8a2aed8. Read the comment docs.


Script/test: 51 on Reinitialize, error PG::ObjectInUse: ERROR:  database "example_test_data" is being accessed by other users

Yes, I've allowed myself to get distracted by Rails 7.1 and sqlite support.
I'm getting small test failures due to 7.1 and have been fixing them in small commits. Now have gotten to [script/test: 51] and am failing here:
[script/test:51] $ bin/rake test_data:reinitialize
** Invoke test_data:reinitialize (first_time)
** Invoke test_data:verify_config (first_time)
** Execute test_data:verify_config
** Invoke environment (first_time)
** Execute environment
** Execute test_data:reinitialize
[test_data:warn] Your local test_data database 'example_test_data' is associated
with a SQL dump that was NEWER than the current dumps located in
'test/support/test_data':

  SQL Dump: 2024-02-22 16:38:47 -0800
  Database: 2024-02-22 16:38:54 -0800

If you're not intentionally resetting your local test_data database to an earlier
version, you may want to take a closer look before taking any destructive actions.

** Invoke test_data:drop_database (first_time)
** Invoke environment
** Execute test_data:drop_database
PG::ObjectInUse: ERROR:  database "example_test_data" is being accessed by other users
DETAIL:  There is 1 other session using the database.
Couldn't drop database 'example_test_data'
rake aborted!
ActiveRecord::StatementInvalid: PG::ObjectInUse: ERROR:  database "example_test_data" is being accessed by other users (ActiveRecord::StatementInvalid)
DETAIL:  There is 1 other session using the database.

It looks like folks running into similar problems on drop_database and do some PG/kill foolery. Should I do this? Or is there some other spot where we should fix this?

For example, we could monkey patch (sorry) something like this?
http://simon.rentzke.com/force-rails-to-db-drop-postgres-db-when-there-are-other-session-using-the-database/

Ugh. I've tried flushing/closing connections at a bunch of places and can't get past this problem.
I've moved to Postgres v16, and that only seems to have made things worse as script/test is now crashing. :shakes_fist:


system tray icon on macOS is scaled too large

The system tray icon on macOS is scaled too large.

Fixed by #1957


566 add image of code generation workflow

Merge Request - GuideLine Checklist
Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.
Checks by code author:
Always to be checked:

[ ] There is at least one issue associated with the pull request.
[ ] The branch follows the naming conventions as defined in the git workflow.
[ ] New code adheres with the coding guidelines
[ ] Make sure that the pre-commit linting/style checks pass.
[ ] No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

If functions were changed or functionality was added:

[ ] Tests for new functionality has been added
[ ] A local test was succesful

If new functionality was added:

[ ] There is appropriate documentation of your work. (use doxygen style comments)

If new third party software is used:

[ ] Did you pay attention to its license? Please remember to add it to the wiki after successful merging.

If new mathematical methods or epidemiological terms are used:

[ ] Are new methods referenced? Did you provide further documentation? Has the glossary been updated?

The following questions are addressed in the documentation if need be:

[ ] Developers (what did you do?, how can it be maintained?)

[ ] For users (how to use your work?)

[ ] For admins (how to install and configure your work?)

For documentation: Please write or update the Readme in the current working directory!

Checks by code reviewer(s):

[ ] Is the code clean of development artifacts e.g., unnecessary comments, prints, ...
[ ] The ticket goals for each associated issue are reached or problems are clearly addressed (i.e., a new issue was introduced).
[ ] There are appropriate unit tests and they pass.
[ ] The git history is clean and linearized for the merge request. All reviewers should squash commits and write a simple and meaningful commit message.
[ ] Coverage report for new code is acceptable.
[ ] No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

Closes #566

Codecov Report
Patch and project coverage have no change.

Comparison is base (e31c1ce) 92.24% compared to head (0f1c1d4) 92.24%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #580   +/-   ##
=======================================
  Coverage   92.24%   92.24%
=======================================
  Files          93       93
  Lines        7290     7290
=======================================
  Hits         6725     6725
  Misses        565      565

Impacted Files
Coverage Δ

cpp/models/abm/mask.h
100.00% <0.00%> (ø)

cpp/models/abm/time.h
100.00% <0.00%> (ø)

cpp/models/abm/person.h
100.00% <0.00%> (ø)

cpp/models/abm/location.h
95.34% <0.00%> (ø)

cpp/models/abm/household.h
89.28% <0.00%> (ø)

cpp/models/abm/trip_list.h
100.00% <0.00%> (ø)

cpp/models/abm/parameters.h
100.00% <0.00%> (ø)

cpp/models/abm/simulation.h
50.00% <0.00%> (ø)

cpp/models/abm/testing_strategy.h
100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


power platform automated functional test plan

🗣 Description
Created a test plan for power platform product.
closes #581
💭 Motivation and context
Automated test plans are needed to document testing, reduce human touch labor and errors.
🧪 Testing
Run Teams test plan as a user.
✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] All future TODOs are captured in issues, which are referenced
in code comments.
[x] All relevant type-of-change labels have been added.
[x] I have read the CONTRIBUTING document.
[x] These code changes follow cisagov code standards.
[x] All relevant repo and/or project documentation has been updated
to reflect the changes in this PR.
[x] Tests have been added and/or modified to cover the changes in this PR.
[x] All new and existing tests pass.

✅ Pre-merge checklist

[x] Revert dependencies to default branches.
[x] Finalize version.

✅ Post-merge checklist

[ ] Create a release.

@nanda-katikaneni this PR should be ready to be merged, think the issue is due to the problem with the current issue on emerald

@Dylan-MITRE - the other PR is merged into Emerald to fix the unit test issue. Can you please rebase/resolve the conflict on this branch to merge into emerald. thanks.

just did a rebase, should be okay now


Remove unnecessary keep_attrs

On resample keep_attrs has no effect and xarray shows a warning.

Pull Request Checklist:

[ ] This PR addresses an already opened issue (for bug fixes / features)

This PR fixes #xyz

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Documentation has been added / updated (for bug fixes / features)
[x] HISTORY.rst has been updated (with summary of main changes)

[x] Link to issue (:issue:number) and pull request (:pull:number) has been added.

[ ] bumpversion patch has been called on this branch
[ ] The relevant author information has been added to .zenodo.json

What kind of change does this PR introduce?
When calling xclim.generic.select_resample_op, Xarray raises the following warning:

UserWarning: Passing keep_attrs to resample has no effect and will raise an error in xarray 0.20. Pass keep_attrs directly to the applied function, e.g. resample(...).mean(keep_attrs=True).

This pr remove the keep_attrs on resample, it seems to be the only place in Xclim where this happens.
Does this PR introduce a breaking change?
No.

Changes Unknown when pulling ca5e247540c50e33f56d8f4b6ce35d6d2b579e56 on fic_xarray_warning into ** on master**.


Create Doors for Linking Maps

Description

using a door in one map leads the character to the entry door of another map

Not too sure which deliverable to label the issue with and whom to assign. Will need to follow up.

Note that there now in fact exists the Game class which contains the LoadMap method that right now only sends an event but can be used to implement the functionality outlined in this issue


[REQUEST] Add a Fullscreen switch to toolbar

A fullscreen button or a Working Alt+Enter.
Alt+Enter currently fullscreens but with black bars. (Screenshot from a MS store build)

It actually just fullscreens the current window resolution.

Will do.

added switch but still running into black bars issue, am investigating

sorted


External Libaries Outside Collection

I have checked the following:

[X] I've searched existing issues and found nothing related to my issue.

Describe the feature you want to add
It is possible to use external Libaries outside of Collections? We use not only one Collection and want to use "faker-js" in the Collection, but dont want to install it in every single Collection. It is possible that we can install it outside of a collection an use it in the collections?
Mockups or Images of the feature
Use Import or require in a Collection when the Libarie is installed outside of the collection.

Is it possible? Because we have more than one Collection and don't want to install node-modules in every Collection.


Keyboard hides bottom tabs on iOS

Ionic version:  (check one with "x")
[ ] 1.x (For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] 2.x
[x] 3.x
I'm submitting a ...  (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
The keyboard hides the tabs (located at the bottom) on iOS when the keyboard is opened (e.g. when you click on an input to enter text).
Expected behavior:
Tabs should be displayed/visible when the keyboard is opened on iOS (Similar to Android)
Steps to reproduce:
Create an app with Tabs located at the bottom.
Click on an input element to enter text
Keyboard opens automatically
Tabs gets hidden
Related code:
Other information:
global packages:
@ionic/cli-utils : 1.4.0
Cordova CLI      : 7.0.1
Ionic CLI        : 3.4.0

local packages:
@ionic/app-scripts              : 1.3.7
@ionic/cli-plugin-cordova       : 1.4.0
@ionic/cli-plugin-ionic-angular : 1.3.1
Cordova Platforms               : android 6.2.3 ios 4.4.0
Ionic Framework                 : ionic-angular 3.4.1

System:
Node       : v6.10.3
OS         : Windows 10
Xcode      : not installed
ios-deploy : not installed
ios-sim    : not installed
npm        : 3.10.10

If I go to the phone app on iOS, which is a tabbed application, and click on "search", the keyboard indeed hides the tabs, so the current behavior is to spec.

Hello all! As @AmitMY stated, this behaves this way because it follows the design spec. Thanks for using Ionic!

is this an iOS design spec?
Can you provide more information please?

While I do not find a link that shows keyboard on tabs in the iOS spec, if you open any app that comes with the device, like "phone", and you bring up the keyboard, for example by searching something, it hides the tabs


compiler errors under Visual Studio 2015

error : unknown type name 'IUnknown'
inorder to fix this issue you have to define WIN32_LEAN_AND_MEAN before including windows.h

@morffiy, I double check all build on vs 2015, win32/x64, debug/release, no such kind of issue.
which version of VS2015 you installed?

@shihuade Visual Studio 2015 Update 3 Platform toolset ( Clang with Microsoft CodeGen (v140_clang_c2) )

@morffiy  my VS version is 14.0.24720.00 Update 1.
OK, I will try it with your VS version later

@morffiy  suggest to use makefile to build openh264. you can refer to https://github.com/cisco/openh264#for-windows-builds.  if still have questions, please let us know. thanks!


Error in the number of channels

I used the ic light basic workflow.All my steps are fine, but error occurred when executing K sampler

Same problem, did you solve it?


Segfault in xf_Bitmap_SetSurface

xfreerdp segfaults for me on one Window 7 machine, when Paint application is opened. No special arguments are used when connecting. It is reproducible with master, but even with stable-1.0, so nothing new. Attaching full backtrace and debug log from one of the runs:
backtrace.txt
log.txt
Btw  -offscreen-cache can be used as workaround.
Can you give me some hint how may I debug it further?

(The attached patches just prevent segfaults, but it fails anyway...)

@ondrejholy Could you add your command line and freerdp version / build configuration?
From a first glance it looks like the requested offscreen surface is missing, maybe you could add some debug logging for offscreen_cache_get.put/delete and see if the index should be valid.

It can be reproduced without any special arguments, i.e. xfreerdp -u USER -p PASS SERVER, respective xfreerdp /u:USER /p:PASS /v:SERVER.
I don't think that version/configuration is interesting in this case, because I can reproduce e.g. with freerdp-2.0.0-33.20170724gitf8c9f43.fc27.x86_64 (Fedora Rawhide), freerdp-1.0.2-10.el7 (RHEL 7), but here is cmake output for my build:
cmake.txt
Yes, I am convinced that server is requesting surface which is missing, but I will check it...

Yes, it is invalid:
cache.txt

It is a bit more stable now, maybe thanks to the newly attached patches (the Paint app window has to be moved/resized/focused several times in order to trigger this), but still exits unexpectedly. It seems that the problems begin after Create Offscreen Bitmap Alternate Secondary Drawing Order, but I don't see any problems in update_read_create_offscreen_bitmap_order according to the spec...
Attaching some examples of unexpected exits:
examples.txt
Any ideas?

@ondrejholy Thought so :/ I've read the spec again, it says in <IP_ADDRESS>.3.1.2 Processing of Switch Surface that the client should drop the connection if the value is greater than offscreenCacheEntries but less than SCREEN_BITMAP_SURFACE (0xFFFF)

@ondrejholy You can try /gdi:sw to see if it works. The file you attached shows error messages with Unknown Secondary Drawing Order (0x09), Unknown Secondary Drawing Order (0x35) and Invalid Primary Drawing Order (0x000000D6) which may be due to the limited set of X11 accelerated GDI operations.

@akallabeth Same results also for /gdi:sw ... :-(

By the way, it sometimes fails also with X Error:
...
[16:50:37:355] [14344:14345] [DEBUG][com.freerdp.core.update] - Create Offscreen Bitmap Alternate Secondary Drawing Order (0x01)
[16:50:37:356] [14344:14345] [DEBUG][com.freerdp.core.update] - Switch Surface Alternate Secondary Drawing Order (0x00)
[16:50:37:356] [14344:14345] [ERROR][com.freerdp.cache.offscreen] - invalid offscreen bitmap at index: 0x00000200
[16:50:37:356] [14344:14345] [DEBUG][com.freerdp.core.update] - Switch Surface Alternate Secondary Drawing Order (0x00)
[16:50:37:356] [14344:14345] [ERROR][com.freerdp.cache.offscreen] - invalid offscreen bitmap index: 0x00000900
[16:50:37:356] [14344:14345] [DEBUG][com.freerdp.core.update] - Switch Surface Alternate Secondary Drawing Order (0x00)
[16:50:37:356] [14344:14345] [ERROR][com.freerdp.cache.offscreen] - invalid offscreen bitmap at index: 0x0000000C
[16:50:37:356] [14344:14345] [DEBUG][com.freerdp.core.update] - Create Offscreen Bitmap Alternate Secondary Drawing Order (0x01)
[16:50:37:356] [14344:14345] [DEBUG][com.freerdp.core.update] - Switch Surface Alternate Secondary Drawing Order (0x00)
[16:50:37:356] [14344:14345] [ERROR][com.freerdp.cache.offscreen] - invalid offscreen bitmap index: 0x0000D804
[16:50:37:356] [14344:14345] [DEBUG][com.freerdp.core.update] - Switch Surface Alternate Secondary Drawing Order (0x00)
[16:50:37:356] [14344:14345] [ERROR][com.freerdp.cache.offscreen] - invalid offscreen bitmap index: 0x00002D08
[16:50:37:356] [14344:14345] [DEBUG][com.freerdp.core.update] - Switch Surface Alternate Secondary Drawing Order (0x00)
[16:50:37:356] [14344:14345] [ERROR][com.freerdp.cache.offscreen] - invalid offscreen bitmap at index: 0x000004C4
[16:50:37:356] [14344:14345] [DEBUG][com.freerdp.core.update] - Create Offscreen Bitmap Alternate Secondary Drawing Order (0x01)
[16:50:37:356] [14344:14345] [DEBUG][com.freerdp.core.update] - Unknown Alternate Secondary Drawing Order: 0x39
[16:50:37:356] [14344:14345] [DEBUG][com.freerdp.core.update] - PatBlt Primary Drawing Order (0x00000001)
X Error of failed request:  BadAlloc (insufficient resources for operation)
  Major opcode of failed request:  53 (X_CreatePixmap)
  Serial number of failed request:  756
  Current serial number in output stream:  757

@ondrejholy Ok, that is indeed strange. Do you know how big the allocated images are?

@akallabeth Hmm, if I put the following print in update_read_patblt_order, I get  513 -31999 for the dimensions. The negative value is weird, but nWidth and nHeight in PATBLT_ORDER is defined as INT32, so the print should be "correct". The value is read as int16 and saved in int32, so it is probably transformed to<PHONE_NUMBER> later, which causes the error. It might mean rather 33537 instead (aka uint16), but still seems weird to me...
(I tested this just with the first patch which avoids the segfault to be sure it is not my mistake.)
 The patblt order is allowed to have values in the range of [-32768,32767] so that first part is correct. the transformation though...

@akallabeth Yes INT16 is expected as per spec, but width/height can't be probably negative...
Btw this happens also with stable-1.0 with the first patch preventing the segfaults...

Hmm, it seems that I am not able to reproduce it anymore :-/ The server was probably in some wrong state and it is no more...
I assume we can't do much here without the reproducer, so let's close it for now.


gitleaks: 8.21.2 -> 8.22.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for gitleaks is: Scan git repos (or files) for secrets
meta.homepage for gitleaks is: https://github.com/zricethezav/gitleaks
meta.changelog for gitleaks is: https://github.com/zricethezav/gitleaks/releases/tag/v8.22.0
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 8.22.0 with grep in /nix/store/y03j3rm8ba3dy0ibjpiz803f9g5fkhj4-gitleaks-8.22.0
found 8.22.0 in filename of file in /nix/store/y03j3rm8ba3dy0ibjpiz803f9g5fkhj4-gitleaks-8.22.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

gitleaks

Instructions to test this update (click to expand)

Either download from the cache:
nix-store -r /nix/store/y03j3rm8ba3dy0ibjpiz803f9g5fkhj4-gitleaks-8.22.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nixpkgs-update-cache.nix-community.org/' \
  --option trusted-public-keys '
  nixpkgs-update-cache.nix-community.org-1:U8d6wiQecHUPJFSqHN9GSSmNkmdiFW7GW7WNAnHW0SM=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The nixpkgs-update cache is only trusted for this store-path realization.)
For the cached download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A gitleaks https://github.com/r-ryantm/nixpkgs/archive/34fb736d75221c881897cac4d7c102189b8c1886.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/34fb736d75221c881897cac4d7c102189b8c1886#gitleaks

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/y03j3rm8ba3dy0ibjpiz803f9g5fkhj4-gitleaks-8.22.0
ls -la /nix/store/y03j3rm8ba3dy0ibjpiz803f9g5fkhj4-gitleaks-8.22.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 1 package built:

gitleaks

Maintainer pings
cc @fabaff for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 367066

x86_64-linux

:white_check_mark: 1 package built:

gitleaks


CodePen is blocking Open Weather Map API

Challenge Name

https://www.freecodecamp.com/challenges/show-the-local-weather
Issue Description

Show the local weather challenge recommends using Open Weather Map API. Which worked fine up until now. Now you will get an error saying "pen.js:22 Mixed Content: The page at [...] was loaded over HTTPS, but requested an insecure XMLHttpRequest endpoint 'http://api.openweathermap.org/data/2.5/weather?lat=30.281903699999997&lon=-97.73883819999999&appid=41bf32baf1dc0b1bb46d120a3cbdbc57'. This request has been blocked; the content must be served over HTTPS."
Browser Information

Browser Name, Version: Google Chrome, 49.0.2623.112
Operating System: Mac OS Yosemite
Mobile, Desktop, or Tablet: Desktop

Your Code
// If relevant, paste all of your challenge code in here

Screenshot

@anthkris this has been fixed with #8141 .
The changes should reach the main website in a couple of days.
As a would around please open the http version of the CodePen link as in:
http://codepen.io/FreeCodeCamp/full/bELRjV
and not the https link in the challenge.
The link will be updated as soon as the fixes reach main website.

Even when I open the http version of the link in Chrome and Firefox, the http call to OpenWeather API is getting blocked. I've already finished my Local Weather project, but I can't submit the project like this on Codepen. The URL works fine when viewing in Safari. I could only think of submitting this project hosted on my own server or find another free weather API that supports SSL.

@j7an refer discussion on #7853

still blocked

@rolandocz try forecast.io as mentioned by @149203 here: https://github.com/freeCodeCamp/freeCodeCamp/issues/7853#issuecomment-222315358
Or you can try solution here: https://forum.freecodecamp.com/t/local-weather-api-for-people-stuck-because-of-the-https-request/50274/17?u=j7an

Still blocked

Dang it still no luck.

@risingmoon77  Ya its working fine for me.
$.getJSON("https://cors-anywhere.herokuapp.com/http://api.openweathermap.org/data/2.5/weather?lat="+lat+"&lon="+lon+"&appid=1c48b076cbce09ca93cfff52b6c839c1",function(json){
   // other code goes here
}

You can't do an http request from an https website. And since you have to use https to use navigation.geolocation then the best thing to do is just use an https API like darksky.

@raisedadead I think this issue can be closed due to #15598


Add support for a shulkr config file

When shulkr is run for the first time, create a config file in the current directory to save the user's decompilation preferences for the new project:

Mappings to use
Decompiler to use
Target (client, server or both)

The idea is the user doesn't edit this file, they only specify the configuration in the first run. If they want to change it, they can re-create the repo. But we don't have to worry about checking if the file was modified now. Let's just focus on the following features:

Create config on first invocation of command
Use config when running on an existing repo

Decompiler and Target can be added later on


Implicitly scoped vars should be better hidden

Right now if you declare a match var within a case macro, everything will break. They should probably be better hidden, as match is a really common var name. Even just a double underscore or something.
Are there other vars besides match?

I'm mass closing issues due to the release of 1.0 obviating lots of bugs. If you feel this issue is something we still need to address feel free to reopen.


help...... how to show each value for bar chart？

hello, do you solve this problem?I also don't know how to do it?

Similarly, how to show each value for line chart?


Adding helm3 command

helm3 doesn't have name flag hence above command fails when user is using helm3(which is latest in its kind)

/assign @jimangel

/lgtm
/approve


update raindrops.md to not focus on prime factors

The raindrops Readme is a little misleading by talking about prime factors. Raindrop-speak cares if a number is divisible by certain numbers. While those numbers do happen to be prime, their primeness shouldn't matter to solve this exercise. In the ruby track I've seen several folks require the Prime class to solve the exercise.
TBH, I would probably not use the word 'factor' at all & instead use 'divisible by'. Was 'divisible by' avoided to not give away the idea of using modulo too easily?

I actually like the fact that it has a red herring, because it leads people to need to rethink their approach when they discover it. In the real world I do this so often. I think I need to solve something in one way, and then someone will say something and everything shifts and there is simplicity and clarity.
I'm definitely open to discussing (a) the wording and (b) whether or not the red herring is too distracting and should just be removed.
@exercism/track-maintainers if any of you have strong feelings about the trade-offs between specificity and discussion, here's your chance to chime in.

This happens very often, a name of a variable, even that we introduce, helping us to drive an implementation that is too restrictive for no good reason, and it surely happens from the customer, in their descriptions of the things that they want to have happen.  The red herring is good.
A similar thing happens in the Gigasecond exercise, where the tests specifically test for a time, in reality, the solution will take any thing that will work with the plus method as long as it will also work with the value of 1e9.  The Date or Time references are a red herring, even perhaps more directly.

To further the discussion when this does happen, I will mention that there is a kinder that asks "Hey, I want to play with 8 being "Plung", as I think that would be fun!".  And there is no reason not to let the little learner down.  And converting 0 is a quick test that ensure that the translations happen in order, since 0 is an universal factor.

👍 If intent is to be a red herring, I will close.

I see that this is a tension induced by #295 which changed "prime factor" to just "factor" earlier in the README - now someone may wonder why one section talks about factors and the other about prime factors. Previously, both section talked about prime factors, and if this PR were merged they would both talk about factors.
If you made me decide, I would support this PR. But I advise that my opinion be taken with a grain of salt since I haven't done this exercise in any language and therefore do not observe submitted solutions and whether they unnecessarily focus on prime factorisation.

It seems to be a fairly low occurrence that the prime factor aspect is enforced, but common that they name variables or functions with the "prime" part of the name, with no bite.
When it is enforced, it is often because (in Ruby, at least) they are using the "prime" library, rather than doing the simplest thing possible to solve the problem.
Perhaps a late test of 22 being "Plung" (as it seems to avoid the current tests) would be good to bring this out.  But bringing this out, then, removes any discussion of this, potentially.  This may be the problem of perfect specifications in a learning/lesson environment.

I've had a chance to sleep on it, and I really like this move to factors, without enforcing it in the tests. I think that there is still a possibility that people will overcomplicate. And some people might even go down the prime route simply because 3, 5, and 7 are primes.
I'm in favor of merging this.

Those are the numbers we're asking you to detect. I think that's clear from the context.

I think we are ready to have it come in.


Improve untool/react

Clean up and streamline internal APIs:

get rid of enhanceData altogether: its naming was stupid and so was the idea of running it client-side
introduce server-side-only getContext hook instead: using 'context' name here to distinguish template rendering context from generic, universal application data
refactor a bit to clarify the code and make it more idiomatic

I'd really love to avoid shadowing the term context, especially in the react package.
How about something ... afterRender

How about getTemplateData? Of course, this thing is being called after ReactDOM.renderToString, but before rendering the SSR template...

getTemplateData sounds really good to me :)


Add modeler 7.7.0 release notes

7.7.0 is scheduled to be released on September 28.

Please do not merge
7.7.0 will not be released. Will be 7.7.1


WIP: apollo client subcription docs

Adds documentation for apollo subscriptions

Hi Pascal  -- as mentioned on Slack.


Update package.json

Unfortunately you missed to update your package.json and change the version of react-native to 0.16 :-)

Thanks for the quick fix :+1:

My pleasure. Thanks for the spot!


docs: Update Zim installation instructions

Description
Starting with Zim 1.8.0, there's the option to disable git submodules. Since the git submodule is tests/shunit2, which is only used for development, it can be disabled for end users.
Screenshot

Thanks! Thought installation methods should be updated in 4.x as well.

:tada: This PR is included in version 4.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

Hi @denysdovhan. I cannot find the commit from this PR in the master branch anymore or under the v4.0.0 tag. No idea what happened. Can I open a new PR? Against which branch?

Cool. Just opened #1159.

Done! Merged!