Is there any ablity to use Xiaomi Hygrothermometer for AC temperature value?

Hey, great thanks for your hard work for a community.
Could you assist, please, with an ability to use Xiaomi Hygrothermometer as a temperature sensor for air-conditioner?
I'm using a certain plugin for that.
As I know -  homebridge modules don't know about each other at all, so I have to link it somehow...

Yes, you need to write (publish) temperature value using the "homebridge-mi-hygrothermograph" plugin (see mqtt section) in the MQTT Broker and then, in the "homebridge-broadlink-rm", inside of the air-conditioner accesory you can read (subscribe) the temperature value using the same Topics


Add Alexanderia University

Add Alexandria University in the list of schools eligible for JetBrains Free Educational Licenses.

@mo0hamed I am sorry, the domain alexu.edu.eg is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Pack at https://education.github.com/discount_requests/application. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


[Feature Request] Portable Windows build

If possible, it would be great to add this as an option to chrlauncher (https://github.com/henrypp/chrlauncher)

I believe this is an issue for chrlauncher to take care of. Plus, chrlauncher already supports forks of Chromium. See this.
I'm closing this for now unless I've been mistaken.


feat: list docs

Need to implement

[x] limit
[x] start - regex expression that provides a starting point for the list
[x] end - regex expression that provides and ending point for the list
[x] keys - an array that identifies keys to return

Since this is a local database that is not meant for millions of documents, these features are implemented using ramda to filter results in memory.


Add Late Exception for Gradescope Module

From nbgrader module, also implement a similar exception model for gradescope module.

In fact, grade scope handles late exception pretty well on the assignment basis. Therefore I don't think there is a need for this functionality in this package anymore.


Add card, icons and alert dialog to design system

This adds Card, Icons and AlertDialog to the design system.

For now we're using Material 2. Switching the entire app to Material 3 is a much larger effort than having to adjust the appearance of some components.
With the following updated functions the new dialogs look more similar to the existing dialogs:
@Composable
fun AlertDialog(
    title: String,
    text: String,
    confirmButtonText: String,
    onConfirmButtonClick: () -> Unit,
    onDismissRequest: () -> Unit,
    modifier: Modifier = Modifier,
    type: AlertDialogType = AlertDialogType.Info,
    hasTitleIcon: Boolean = false,
    dismissButtonText: String? = null,
    onDismissButtonClick: () -> Unit = {},
) {
    CompositionLocalProvider(
        LocalAbsoluteElevation provides 24.dp
    ) {
        MaterialAlertDialog(
            onDismissRequest = onDismissRequest,
            confirmButton = configureConfirmButton(confirmButtonText, onConfirmButtonClick),
            modifier = modifier,
            dismissButton = configureDismissButton(dismissButtonText, onDismissButtonClick),
            title = configureTitle(title, type, hasTitleIcon),
            text = configureText(text),
        )
    }
}

private fun configureTitle(title: String?, type: AlertDialogType, hasIcon: Boolean): @Composable (() -> Unit)? {
    return if (title != null) {
        {
            Row(
                modifier = Modifier.fillMaxWidth(),
                horizontalArrangement = Arrangement.Start,
            ) {
                ConfigureTitleIcon(hasIcon, type)
                Text(
                    text = title,
                    fontWeight = FontWeight.Medium,
                    fontSize = 20.sp,
                    letterSpacing = 0.25.sp,
                    color = MainTheme.colors.onSurface
                )
            }
        }
    } else {
        null
    }
}

private fun configureText(text: String?): @Composable (() -> Unit)? {
    return if (text != null) {
        {
            Column(
                modifier = Modifier.fillMaxWidth(),
            ) {
                Text(
                    text = text,
                    fontWeight = FontWeight.Normal,
                    fontSize = 16.sp,
                    letterSpacing = 0.sp,
                    color = MainTheme.colors.onSurface
                )
            }
        }
    } else {
        null
    }
}

Existing dialog
New Compose dialog

We need to discuss what is the source of truth for Material 2, as doing that changes introduces a lot of in place stylings. But the goal is to use common rules and styles troughout the app and stick to the text styles defined within Typography.

After further check the App currently uses AppCompat styles for Dialogs and not Material 2.

There are visual inconsistencies in how dialogs are themed throughout the app. The AlertDialogs are not mandatory for the new account setup flows and could be replaced by in screen views. So we postpone this changes and pick them up later when the app preferences are also Material 2 compatible.


docs: updates for 0.13 rewrite

Issue being fixed or feature implemented

Documentation were necessary following the rewrite in #140.
Note: targeting master because that's where docsify builds from
What was done?

[x] Update README (remove broken badge, minor readme-standard formatting)
[x] Add documentation for new getIdentity* methods
[x] Remove getGrpcUrl documentation

How Has This Been Tested?

Tested any changed code examples locally
Breaking Changes

N/A
Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added or updated relevant unit/integration/functional/e2e tests
[x] I have made corresponding changes to the documentation

For repository code-owners and collaborators only

[x] I have assigned this pull request to a milestone

@thephez There is some misscomuncation hapend :) Actually, we didn’t rewrite anything in 0.13. Changes from #140 (not reflected in this PR l) goes to 0.14.

@thephez There is some miscommunication happened :) Actually, we didn’t rewrite anything in 0.13. Changes from #140 (not reflected in this PR l) goes to 0.14.

Oops :see_no_evil: Updated the PR name. These updates are still needed for 0.13 anyway.


Automated backport of #2526: Retry reading local node details from k8s-api

Backport of #2526 on release-0.14.
#2526: Retry reading local node details from k8s-api
For details on the backport process, see the backport requests page.

E2E failed, re-running.


Merging Develop into Master 11.9.2018 - antispoofing release, iterative updates

Hello @ksigler7,Thanks again for the PR! We appreciate your contribution and look forward to                                              continued collaboration. Thanks!                                             Team SendGrid DX


Fixed msal constraint

The dependency update in #28 contained a typo, unfortunately. The upstream repo has a dependency on msal>=1.29, but in the recipe here it was changed to msal>=1.2.9 instead. The current package in conda-forge is quite broken if/when you end up with such an old version of msal, e.g. continuously re-prompting in device flow.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

Sorry about that! 😬


[tensorflow lite] add setUseNNAPI to the Interpreter class

add setUseNNAPI to the Interpreter class

Nagging Assignee: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

#16065, seems to do this and more.


Github action for image change

this opens a PR whenever any of the docker images change (go toolset ot ubi8-minimal)

/retest

this will actually be green tomorrow if this merges


"Debug cell" not working in Jupyter notebooks

Environment data

VS Code version: Visual Studio Code (1.76.0, undefined, desktop)
Jupyter Extension version (available under the Extensions sidebar): 2023.2.1200692131.
Python Extension version (available under the Extensions sidebar): 2023.4.1.
OS (Windows | Mac | Linux distro) and version: MacOS Monterey 12.5.1 (21G83)
Python and/or Anaconda version: 3.9.10
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): conda
Jupyter server running: Local

Expected behaviour
Debug cell and the debugger should be working properly on Jupyter notebooks
Actual behaviour
At first, the option is available, but when I click on it, the debugger fires up but does nothing and the debug cell button disappears.
before:

after clicking on debug cell:

and I get this error too when relaunching:

Steps to reproduce:
[NOTE: Self-contained, minimal reproducing code samples are extremely helpful and will expedite addressing your issue]

Just open any local Jupyter notebook and try to debug any cell

Logs
jupyter_console_output.log
jupyter_console_output_2.log

Any updates on the issue?
Many thanks!

I don't have exactly this issue. I can't debug as it constantly says "Ipykernel setup required for this feature" even though I'm sure that my ipykernels are installed.

(py39) C:\Users\username>jupyter kernelspec list
Available kernels:
python3    C:\Users\username.conda\envs\py39\share\jupyter\kernels\python3

as well as for base

(base) C:\Users\username>jupyter kernelspec list
Unable to load extension: pydevd_plugins.extensions.types.pydevd_plugin_pandas_types
Available kernels:
python3    C:\ProgramData\Miniconda3\share\jupyter\kernels\python3

I wonder if this is connected?

@fschiffers please could you file a seprate issue as it looks unrelated, that way we can look at both individually.
@garrofederico Sorry for not getting back, please could you try installing VS Code insiders and letting me know if this still exists in the latest pre-releaes version of jupyter extension and pre-release version of the Python extensoin

Please install latest VS Code Insiders
Open the extensions page, search for Jupyter and click the button Switch to Pre-Release Version
Similarly please install the latest Pre-Release version of the Python extension

@DonJayamanne , Thanks for your response.

I installed the latest VS Code Insiders

I installed the latest pre-release of the Python extension

However, I wasn't able to switch to the Pre-Release Version of the Jupyter extension, this option is not available to me in VS Code insiders nor Stable version:

Anyway, I tested debbuging on the Insiders version and it is still not working.

Hi @garrofederico, maybe it's just that you need to add the breakpoint before starting Debug Cell? I see it in the second screenshot but not the first, so it's not clear if it was there before you started.
If that doesn't help, can you set the setting "jupyter.logging.level": "verbose", try again, and grab the log again? Thanks

Hi @roblourens, thanks for helping out.
Here's a screen shot that shows everything at once:

I tested it again (with the breakpoints, of course) and it is not working.
Here's the log as you asked:
jupyter_console_output_3.log

Yeah, something is going on, it's getting stuck when we start the debugger but I'm not sure why. I can tell you that the restart button will not work currently and will give you that error message though.

Hi, is there any update on this matter?
Thanks!

An update: the debugger is working correctly on jupyter notebooks when I'm connected to a remote server.
Is there any update on your side?

I have the same issue. I realized when i import models from super_gradients.training, "Ipykernel setup required for this feature" occurs. otherwise the debug feature works well.

Having the same problem on my Windows Machine:

VS Code Version: 1.78.2
OS: Windows 11
Python Version: 3.10.8
Jupyter Extension Version: 2023.4.1011241018
Python Extension Version: 2023.8.0

I get this every time I want to debug some cell

And that's it, breakpoints aren't reached, debugger shows nothing, even the play button stops showing the little arrow at the side

@memeplex I am experiencing the exact same problem.

VS Code version: Version: 1.79.0 (Universal)
Commit: b380da4ef1ee00e224a15c1d4d9793e27c2b6302
Date: 2023-06-07T14:29:00.206Z (1 wk ago)
Electron: 22.5.5
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 22.4.0
Jupyter Extension version (available under the Extensions sidebar): v2023.5.1001582324
Python Extension version (available under the Extensions sidebar): v2023.10.1
OS (Windows | Mac | Linux distro) and version:
Local: Ventura Version 13.3.1 (a) (22E772610a)
Python and/or Anaconda version: 3.10.11 (Python version)
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): conda
Jupyter server running: Remote (sshing)

I am also having same issue on y system
Version: 1.79.2 (user setup)
Commit: 695af097c7bd098fbf017ce3ac85e09bbc5dda06
Date: 2023-06-14T08:57:04.379Z
Electron: 22.5.7
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22621
Jupyter
v2023.5.1101742258
Able to execute cell but I am unable to see Debug cell option in visual studio code

I was able to work around the issue by creating a new virtual environment.

I think I found the root cause for this error, at least for my case:
If you create a virtual environment using virtualenv and you rename or change ANY part of the path where the virtual environment is located, your interpreter will be broken. You won't see any error messages, except in some specific use-cases.
In my case I only found this error while trying to login using huggingface-cli and the command was not found although the  transformers package was installed correctly and working otherwise. Therefore, I executed the command directly via its installation location .venv/bin/huggingface-cli and got the following error:
zsh: .venv/bin/huggingface-cli: bad interpreter: /home/projects/.venv/bin/python: no such file or directory

That's where I saw the missing folder in the path.
As mentioned by @LHLaurini the solution would be to delete the environment and create a new one or change the paths back how they where while installing the environment.

I get the issue when I run a simple startup_script.ps1:
virtualenv venv -p python3.8
.\venv\Scripts\activate
pip install ipykernel
pip install -r requirements.txt

However, I found that I can work around the issue by executing the lines 1 by 1 in the terminal.

I've been able to reliably reproduce the bug in the following scenario:
setup virtual environment
test the debugger -> still works
install a package
test the debugger -> still works
restart the kernel
test the debugger -> now I get the error

Met with the same issue.

same issue for me

Suggestion
When debugging, warn users if typings module is installed

The debug cell in Edge disappeared, but it works normally in Chrome

Successfully fixed debugging in Jupyter notebook in VSCode
Summarizing the findings of all related threads in a single post to help the many others wasting time debugging this.

:x: Before: Error
✅ After: Working!

Diagnosing the Problem
First, look at the Jupyter extension logs:

Unfortunately, you may only receive this as the last log message:
16:56:43.944 [info] Starting debugging with mode 1

This is not helpful.
If so, then next step is change VSCode settings:
jupyter.logging.level": "verbose"

Then run VSCode command Developer: Reload Window.
Now you should receive the error message.
For example, in my case I had the same error message as https://github.com/microsoft/vscode-jupyter/issues/15562#issuecomment-2062746960 from typing and debugpy:
...
16:56:43.988 [debug] [Debug] to kernel, mapped: {"command":"initialize","arguments":{"clientID":"vscode","clientName":"Visual Studio Code","adapterID":"Python Kernel Debug Adapter","pathFormat":"path","linesStartAt1":true,"columnsStartAt1":true,"supportsVariableType":true,"supportsVariablePaging":true,"supportsRunInTerminalRequest":true,"locale":"en","supportsProgressReporting":true,"supportsInvalidatedEvent":true,"supportsMemoryReferences":true,"supportsArgsCanBeInterpretedByShell":true,"supportsMemoryEvent":true,"supportsStartDebuggingRequest":true},"type":"request","seq":1}
16:56:44.013 [debug] KernelProcess error 11981: Traceback (most recent call last):
  File "/opt/miniconda3/envs/pytorch/lib/python3.8/runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/opt/miniconda3/envs/pytorch/lib/python3.8/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/opt/miniconda3/envs/pytorch/lib/python3.8/site-packages/debugpy/adapter/__main__.py", line 215, in <module>
    __import__("debugpy")
  File "/opt/miniconda3/envs/pytorch/lib/python3.8/site-packages/debugpy/adapter/../../debugpy/__init__.py", line 35, in <module>
    from debugpy.public_api import *  # noqa
  File "/opt/miniconda3/envs/pytorch/lib/python3.8/site-packages/debugpy/adapter/../../debugpy/public_api.py", line 8, in <module>
    import typing
  File "/opt/miniconda3/envs/pytorch/lib/python3.8/site-packages/debugpy/adapter/../../typing.py", line 1359, in <module>
    class Callable(extra=collections_abc.Callable, metaclass=CallableMeta):
  File "/opt/miniconda3/envs/pytorch/lib/python3.8/site-packages/debugpy/adapter/../../typing.py", line 1007, in __new__
    self._abc_registry = extra._abc_registry
AttributeError: type object 'Callable' has no attribute '_abc_registry'

16:56:54.185 [debug] [Debug] response: {"command":"initialize","request_seq":1,"seq":3,"success":false,"type":"response"}
...

Solution
As stated above, the solution is to uninstall typing module/package:
pip uninstall typing

Explanation
I didn't fully understand why until found this explanation from https://stackoverflow.com/questions/55833509/attributeerror-type-object-callable-has-no-attribute-abc-registry#comment113222151_58067012

The typing package is only relevant on Python <= 3.5. Later versions include the typing module built-in, so you should uninstall it anyway. – WhyNotHugo

For Python versions:

<3.5: typing library, https://pypi.org/project/typing/
>=3.5: Built-in, https://docs.python.org/3/library/typing.html

Hope this helps anyone else quickly come to a resolution and understanding!

Proposed solution
If debugging fails and this package is installed, we can probably suggest uninstalling this package and trying again, and linking to a WIKI that contains information from this issue (with a link to this issue).

Given the problem is caused by external package and we haven't had any new related issues I'm closing this issue.
If we do find that users still run into this with the latest versions of the packages, then will reopen and probably consider warning/prompting users to uninstall the typings package.


[Converter] Add support for group_norm

Could we get support for aten::group_norm?
Original PyTorch API:
https://pytorch.org/docs/stable/generated/torch.nn.GroupNorm.html

@peri044 do we need a plugin for group norm?

Any updates on this issue? It would be helpful for my use case too.

Hi all, I have a first version for the the group_norm layer converter using the GN plugin in TensorRT.
I add a group_norm.cpp file that wrap the correct pytorch signature. I also add to ignore the batch size checking that lead to unsupported operator used for the check...
Now the compilation/conversion from a pytorch model is ok but when I run an inference of the model (typically by modifying the examples/network.py file) lead to a cudnn error :
.....
WARNING: [Torch-TensorRT] - Group norm layer is an experimental development features and used the group_norm plugin from TensorRT plugins library
WARNING: [Torch-TensorRT] - Create group norm plugin from TensorRT plugin registry...
WARNING: [Torch-TensorRT] - Get the creator for group norm
WARNING: [Torch-TensorRT] - Create plugin
WARNING: [Torch-TensorRT] - Add plugins to the context
Warm up ...
ERROR: [Torch-TensorRT] - 2: [pluginV2DynamicExtRunner.cpp::execute::115] Error Code 2: Internal Error (Assertion status == kSTATUS_SUCCESS failed. )
ERROR: [Torch-TensorRT] - 1: [context.cpp::setStream::121] Error Code 1: Cudnn (CUDNN_STATUS_MAPPING_ERROR)
ERROR: [Torch-TensorRT] - 1: [context.cpp::setStream::121] Error Code 1: Cudnn (CUDNN_STATUS_MAPPING_ERROR)
ERROR: [Torch-TensorRT] - 1: [context.cpp::setStream::121] Error Code 1: Cudnn (CUDNN_STATUS_MAPPING_ERROR)
...
Traceback (most recent call last):
File "network.py", line 108, in
main()
File "network.py", line 100, in main
benchmark(trt_ts_module, input_shape=(1, 3, 5, 5), dtype="fp32")
File "network.py", line 42, in benchmark
torch.cuda.synchronize()
File "/opt/conda/lib/python3.8/site-packages/torch/cuda/init.py", line 494, in synchronize
return torch._C._cuda_synchronize()
RuntimeError: CUDA error: an illegal memory access was encountered
ERROR: [Torch-TensorRT] - 1: [fusedConvActRunner.cpp::destroyFilterTexture::292] Error Code 1: Cuda Runtime (an illegal memory access was encountered)
ERROR: [Torch-TensorRT] - 1: [defaultAllocator.cpp::deallocate::35] Error Code 1: Cuda Runtime (an illegal memory access was encountered)
ERROR: [Torch-TensorRT] - 1: [cudaResources.cpp::~ScopedCudaStream::47] Error Code 1: Cuda Runtime (an illegal memory access was encountered)
ERROR: [Torch-TensorRT] - 1: [cudaResources.cpp::~ScopedCudaEvent::24] Error Code 1: Cuda Runtime (an illegal memory access was encountered)
ERROR: [Torch-TensorRT] - 1: [cudaResources.cpp::~ScopedCudaEvent::24] Error Code 1: Cuda Runtime (an illegal memory access was encountered)
ERROR: [Torch-TensorRT] - 1: [cudaResources.cpp::~ScopedCudaEvent::24] Error Code 1: Cuda Runtime (an illegal memory access was encountered)
ERROR: [Torch-TensorRT] - 1: [cudaResources.cpp::~ScopedCudaEvent::24] Error Code 1: Cuda Runtime (an illegal memory access was encountered)
Here is my new version of the network :
class ConvGelu(torch.nn.Module):
def init(self):
super(ConvGelu, self).init()
self.conv = nn.Conv2d(3, 32, 3, 1)
self.gelu = nn.GELU()
def forward(self, x):
    x = self.conv(x)
    x = F.group_norm(x,num_groups=32)
    x = self.gelu(x)
    return x

I'm not sure if there is a problem with cudnn call from the GroupNorm plugin layer with is mostly based around the cuDNN BatchNorm function.
Any feedback ?
Cheers,
David

Hi David,
I'm also tying to implement a converter, can you tell me how you manage to ignore the batch size check?

I have patch the group_norm from PyTorch without the check of the batch size, but it seems that with the ngc21.12 there is no need to do that

I see. I'll do that as well for now then. How do you manage to pass the weight and bias argument to the GroupNormPlugin? I can't find a way to convert the Tensors to ITensors.

The GroupNormPlugin provided by TensorRT doesn't support the fine-tuned weights and biases. I bypass this missing feature with the addScaleNd TensorRT layer that I plugged after the call of the GroupNormalizationPlugin

GroupNormalizationPlugin

Has the development of the plugin been completed? Can you pull request or share the code?Thanks！

Any updates on this? Would also be useful for my model.


[v1.1.7] No way to sign in case of HCS submit message transaction with submitKey set

Hi,
I am using ConsensusSubmitMessageTransaction but can't find method to sign required in case topic has submitKey set.
Also, it says ConsensusSubmitMessageTransaction is deprecated use ConsensusMessageSubmitTransaction instead but ConsensusMessageSubmitTransaction is not exposed.
version : 1.1.7

is it like by default is sign with caller account's private key?

The Transaction will sign by the operator private key which is generally required as the payer (or the operator) must always sign the transaction.
If you have an additional key, currently you must build and then continue signing the transaction.
const transactionId = await new ConsensusMessageSubmitTransaction()
  .setTopicId(topicId)
  .setMessage("Hello, World")
  .build(client) // finalizes the transaction so it may not be mutated
  .sign(submitKey) // additional signature
  .execute(client);

Thanks @mehcode


Update repositories.txt

Hello @InfiniteCoder01. Thanks for your interest in contributing to the Arduino Library Manager index!
I see the bot reported a problem with your submission that will block its acceptance:

:x: ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

If you have any questions or problems while following the instructions to resolve the problem, please let me know and I'll help out.
If you decide you no longer wish to submit the library, you can close this pull request.

Fixed

Hello @InfiniteCoder01. I see the repository still does not have any tags or releases:
https://github.com/InfiniteCoder01/BufferedOreonSSD1351/tags
Did you maybe forget to push the tag from your local clone of the repository to GitHub?

Fixed now

@ArduinoBot please check it again.


Continous Integration System

Hi,
Here are scripts for continous integration with appveyor.com and travis.com. These services are gratis for libre software projects. The CI is full featured and documented here ( http://wiki.torque3d.org/coder:continuous-integration ). You can see generated doxygen doc here ( https://andijh92.github.io/Torque3D/doc/dev/scriptReference/index.html ) and here ( https://andijh92.github.io/Torque3D/doc/dev/engineReference/index.html ). Compiling OSX doesn't work yet and I don't have osx to debug it. Maybe I'll fix it in the future.
Regards, Andy

Windows builds! Nice!

Vote to close


Fix root cause of infinite looping "bug" in PagedIterable.

Ignore this, will ask artichikin for more details. Current code works fine with my tests.


how to use indicator in RecyclerViewSnap

nice! I will provide a adapter class to use https://github.com/hackware1993/MagicIndicator in RecyclerViewSnap.

Ok, thanks!


fix(concurrency): test disable re-declaration of cairo0 contracts

This change is

crates/blockifier/src/transaction/transactions_test.rs line 1219 at r1 (raw file):
Previously, meship-starkware (Meshi Peled) wrote…
To avoid code duplication, it might be a better idea to do this as part of the decalre_tx test.

I agree.
All you need to do is add the last part of this test at the end of test_declare_tx:
    let account_tx2 = declare_tx(
        declare_tx_args! {
            max_fee: Fee(MAX_FEE),
            sender_address,
            version,
            resource_bounds: max_resource_bounds,
            class_hash,
            compiled_class_hash,
            nonce: nonce_manager.next(sender_address),
        },
        class_info.clone(),
    );
    let result = account_tx2.execute_raw(&mut transactional_state, block_context, execution_flags);
    assert_eq!(
        result.err().unwrap().to_string(),
        TransactionExecutionError::DeclareTransactionError { class_hash }.to_string()
    );

All the setup is already there.
Also, maybe use execute instead of execute_raw to be consistent with the first declaration of the test (or change it there from execute to execute_raw).

crates/blockifier/src/transaction/transactions_test.rs line 1219 at r1 (raw file):
Previously, avi-starkware wrote…
I agree.
All you need to do is add the last part of this test at the end of test_declare_tx:
    let account_tx2 = declare_tx(
        declare_tx_args! {
            max_fee: Fee(MAX_FEE),
            sender_address,
            version,
            resource_bounds: max_resource_bounds,
            class_hash,
            compiled_class_hash,
            nonce: nonce_manager.next(sender_address),
        },
        class_info.clone(),
    );
    let result = account_tx2.execute_raw(&mut transactional_state, block_context, execution_flags);
    assert_eq!(
        result.err().unwrap().to_string(),
        TransactionExecutionError::DeclareTransactionError { class_hash }.to_string()
    );

All the setup is already there.
Also, maybe use execute instead of execute_raw to be consistent with the first declaration of the test (or change it there from execute to execute_raw).

Add a comment explaining why you are declaring again before this new block of code.

crates/blockifier/src/transaction/transactions_test.rs line 1107 at r4 (raw file):
Previously, meship-starkware (Meshi Peled) wrote…
Because it means we will have to change the declare_tx test to support concurrency mode, I am not sure
that's what we want to do. Generally, we don't want to test the concurrent run outside the concurrency model.
account_tx_tests is an exception, actually for no reason. Regardless, I think that if we change the declare_tx test to support concurrency, we should change all the txs tests to support concurrency to stay consistent.

Oh okay
Declaring twice has nothing to do with concurrency
So I think this is fine


Wrong comment on element tags.

Hi,
The readme has a code snippet with the following comment:
<!-- notice there is no <my-element> tag -->, but there is one.
Thanks for RiotTS!

Good catch, thanks!
Previously the RiotTS syntax was without the surrounding element, but you had to specify the tag name separately. Later the syntax changed but I missed to update the README, so many thanks.


Best way to control Submit button enabled/disabled, based on form inputs

Out of curiosity, do you think this is the best approach to controlling the enable/disabled status of a Submit button for a user input form with multiple inputs?
combineLatest(firstNameTextField.bnd_text,
        lastNameTextField.bnd_text,
        emailAddressTextField.bnd_text,
        passwordTextField.bnd_text,
        sessionUpdateInProgress).map {
            (firstName: String?, lastName: String?, emailAddress: String?, password: String?, updateInProgress: Bool) -> Bool in
            if let aFirstName = firstName,
                    aLastName = lastName,
                    anEmailAddress = emailAddress,
                    aPassword = password {
                    return aFirstName.characters.count > 0 &&
                            aLastName.characters.count > 0 &&
                            Globals.isValidEmailAddress(anEmailAddress) &&
                            aPassword.characters.count > 0 &&
                            !updateInProgress
            }
            return false
        }.bindTo(signUpButton.bnd_enabled)

Also, while I haven't noticed any immediate performance problems, do you think this is a performant pattern to use at scale, with large numbers of combines?

Hi  @joshavant,
I would not worry about performance. Having hundreds or even thousands variables would probably not be noticeable.
On the other hand, you might improve readability by mapping all the inputs to a boolean value:
func isEntered(string: String?) -> Bool {
  if let string = string {
    return string.characters.count > 0
  } else {
    return false
  }
}

combineLatest(firstNameTextField.bnd_text.map(isEntered),
  lastNameTextField.bnd_text.map(isEntered),
  emailAddressTextField.bnd_text.map(Globals.isValidEmailAddress),
  passwordTextField.bnd_text.map(isEntered),
  sessionUpdateInProgress).map {
    (firstName, lastName, emailAddress, password, updateInProgress) -> Bool in
      return firstName && lastName && emailAddress && password && !updateInProgress
  }.bindTo(signUpButton.bnd_enabled)

Assuming isValidEmailAddress can accept optional string.

You could simplify it even more. Swift is so powerful. You can define extension on an array of boolean event producers that returns event producer that check whether all inputs are true...
public extension CollectionType where Generator.Element: EventProducerType, Generator.Element.EventType == Bool {

  public func allTrue() -> EventProducer<Bool> {
    return EventProducer(replayLength: 1) { sink in

      let compositeDisposable = CompositeDisposable()
      var truthMap = self.map { e in false }

      self.enumerate().forEach { (index, producer) in
        compositeDisposable += producer.observe { event in
          truthMap[index] = event
          sink(truthMap.reduce(true) { $0 && $1 })
        }
      }

      return compositeDisposable
    }
  }
}

Then you could do:
[
  firstNameTextField.bnd_text.map(isEntered),
  lastNameTextField.bnd_text.map(isEntered),
  emailAddressTextField.bnd_text.map(Globals.isValidEmailAddress),
  passwordTextField.bnd_text.map(isEntered),
  sessionUpdateInProgress.map { !$0 }
].allTrue().bindTo(signUpButton.bnd_enabled)

(I'm writing this in the browser, I didn't test this code)

Awesome suggestions, @srdanrasic! Thank you!
You're great with the browser... that all (mostly) worked. My only change was to declare the extension, like so:
extension CollectionType where Generator.Element: EventProducerType, Generator.Element.EventType == Bool {
(tl;dr - dropped the leading public)
Also, instead of passing a function in (because have to validate lots of forms around the app), I decided to do this:
firstNameTextField.bnd_text.map{ !($0?.isEmpty ?? true) }
It's the most pretty or readable, but it also means I don't have to add/maintain a small, one-off extension for String or CollectionType just to check count > 0.


rabbitmq producer retry

spring-cloud-stream-binder-rabbit: 1.2.0.M1
org.springframework.cloud.stream.binder.rabbit.RabbitMessageChannelBinder.createProducerMessageHandler

This method doesn't set any retry properties on RabbitTemplate
spring.rabbitmq.template.retry.*

How does the producer retry a failed publish (caused by for example a broker restart) ?
Thanx,

From an external discussion:

I’m noticing some unexpected behavior when trying to publish a message to RabbitMQ via Spring Cloud Stream. I’m using a TCP load balancer to balance connections between nodes in the RabbitMQ cluster. I’m testing the situation in which a node goes down but for a brief period the load balancer might still route requests to that node. In that case, the publisher, if routed to the down node fails to establish a connection and throws an exception. This is unexpected because I have spring.rabbitmq.template.retry.enabled: true set, which I expected would cause it to retry even if the connection attempt failed the first time. In fact, if I try using the auto-configured RabbitTemplate directly without Spring Cloud Stream, it is exhibiting the behavior I expect: a WARN log is published for the initial connection failure but it retries and the load balancer routes to the good node, a connection is established, and the message is successfully published.

IMO should be moved to the https://github.com/spring-cloud/spring-cloud-stream-binder-rabbit/issues
//CC @shakuzen

Thanx @artembilan. Yup i agree. Will you be moving this ?

Moved to https://github.com/spring-cloud/spring-cloud-stream-binder-rabbit/issues/69


arm: fix thread's FPU initialization

FPU's control and status register (FPCSR) for a thread is not initialized.
Random values are written to this register and this leads to failure on
fp_sharing test.
FPCSR register is set to 0 according to the value of FPDSCR.
Signed-off-by: “Andrei<EMAIL_ADDRESS>Fixes: #14606

Codecov Report

Merging #14830 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #14830      +/-   ##
==========================================
- Coverage   52.51%   52.51%   -0.01%
==========================================
  Files         309      309
  Lines       45048    45048
  Branches    10419    10419
==========================================
- Hits        23656    23655       -1
  Misses      16584    16584
- Partials     4808     4809       +1

Impacted Files
Coverage Δ

arch/posix/core/posix_core.c
90.9% <0%> (-1.02%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef9c7a4...556c4c1. Read the comment docs.


Notebook auto-save should be configurable

when multiple users open the same notebook, auto-save could lead to some very weird results, and outdated code.

cc @andypetrella

IMHO this thing is rather hot :hotsprings:

fixed in #501


Support configurable CRS in WCS services

Overview
This PR adds a supportedProjections attribute to the WcsConf case class, adds example configuration to the stac-example and ogc-example projects, and consumes those supported projections when rendering the GetCapabilities response.
Checklist

[x] Description of PR is in an appropriate section of the CHANGELOG and grouped with similar changes if possible

Demo
$ http :9000 service==wcs request==getcapabilities
HTTP/1.1 200 OK
Content-Length: 8925
Content-Type: application/xml
Date: Tue, 16 Feb 2021 16:46:01 GMT

...
<CoverageSummary>
  <ows:Title>US NED</ows:Title>
  <ows:WGS84BoundingBox>
    <ows:LowerCorner>-15.015761449275047 -171.00056648254395</ows:LowerCorner>
    <ows:UpperCorner>72.00056298703436<PHONE_NUMBER>0196636</ows:UpperCorner>
  </ows:WGS84BoundingBox>
  <SupportedCRS>urn:ogc:def:crs:OGC::imageCRS</SupportedCRS>
  <SupportedCRS>urn:ogc:def:crs:EPSG::3785</SupportedCRS>
  <SupportedCRS>urn:ogc:def:crs:EPSG::4326</SupportedCRS>
  <SupportedCRS>urn:ogc:def:crs:EPSG::3410</SupportedCRS>
  <SupportedCRS>urn:ogc:def:crs:EPSG::3978</SupportedCRS>
  <SupportedCRS>urn:ogc:def:crs:EPSG::4617</SupportedCRS>
  <SupportedCRS>urn:ogc:def:crs:EPSG::3979</SupportedCRS>
  <SupportedCRS>urn:ogc:def:crs:EPSG::3413</SupportedCRS>
  <SupportedCRS>urn:ogc:def:crs:EPSG::26916</SupportedCRS>
  <SupportedFormat>image/geotiff</SupportedFormat>
  <SupportedFormat>image/jpeg</SupportedFormat>
  <SupportedFormat>image/png</SupportedFormat>
  <Identifier>us-ned</Identifier>
</CoverageSummary>
...

Notes
Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.
Testing Instructions

make the demo request with the ogc-example project running
confirm you also see the CRSes that match the values from the application.conf
optional: change those values and verify the server respects your changes

Closes #305

d4e2829 does the DescribeCoverage change -- it wasn't clear to me that the bboxes needed to include all the CRSes as well, since the wms getCapabilities response doesn't include it and the methods for bbox reprojection don't seem to be called anywhere (bboxIn on the two OGCSources I mean). Let me know if that read is incorrect.

@jisantuc I think the main goal of the GetDescribeCoverage to make the service comaptible with tools like QGIS. I think QGIS is pretty happy without having all projections listed in the GetCoverage, but (accroding to specs) we still need to list all projections supported by the coverage.


Sync docs/Manual.md with docs/manual/Shakefile.hs

Thanks! cmd_ didn't exist when this was first written :)


add key board shortcuts

typically I only use a small handful of signs regularly and would like to be able to use keyboard shortcuts in order to send a sign. I am sure the rest of the team would find this useful

I'll do some investigation on this, as I currently have no idea how it works in browser

are we looking at pre-defined or user-defined shortcuts @pauldougan ?

no activity


secretscanner: init at 20210214-42a38f9

Motivation for this change
Find secrets and passwords in container images and file systems
https://github.com/deepfence/SecretScanner
Related to #81418
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 113145 at 060cb635 run on aarch64-linux 1

1 package marked as broken and skipped:

secretscanner

Result of nixpkgs-review pr 113145 run on x86_64-linux 1

1 package built:

secretscanner

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 113145 run on x86_64-linux 1

1 package built:

secretscanner

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:
secretscanner:

Unused argument: docker.
Near pkgs/tools/security/secretscanner/default.nix:3:3:
  |
3 | , docker
  |   ^

Result of nixpkgs-review pr 113145 run on x86_64-linux 1

1 package built:

secretscanner

Result of nixpkgs-review pr 113145 run on x86_64-linux 1

1 package built:

secretscanner


Add options to select a signature when converting from TensorFlow Hub.

This change is

 Thanks couple minor comments.

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

README.md, line 80 at r1 (raw file):

tf_hub_signature

README.md, line 80 at r1 (raw file):

|`--output_node_names`| The names of the output nodes, separated by commas.|
|`--saved_model_tags` | Only applicable to SavedModel conversion, Tags of the MetaGraphDef to load, in comma separated format. Defaults to `serve`.|
|`--tf_hub_signature` | Only applicable to TensorFlow Hub module conversion, signature to load. Defaults to `default`. See https://www.tensorflow.org/hub/common_signatures/.|

can we name this something more generic, I think it could be used for saved model as well.
maybe signature_name ?

python/tensorflowjs/converters/tf_saved_model_conversion.py, line 297 at r1 (raw file):

signature

should the signature have a default value?

Comments from Reviewable

Review status: 1 of 4 files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.

README.md, line 80 at r1 (raw file):
Previously, pyu10055 (Ping Yu) wrote…

tf_hub_signature

Done.

README.md, line 80 at r1 (raw file):
Previously, pyu10055 (Ping Yu) wrote…
can we name this something more generic, I think it could be used for saved model as well.
maybe signature_name ?

Done. I kept the original description, it can be changed when new functionality is added.

python/tensorflowjs/converters/tf_saved_model_conversion.py, line 297 at r1 (raw file):
Previously, pyu10055 (Ping Yu) wrote…

signature

should the signature have a default value?

Done.

Comments from Reviewable

Also fixed a flag typo (https://github.com/tensorflow/tfjs-converter/pull/112).

Thanks for fixing the bugs. I  think we should do a patch release (0.3.1) after the fixes gets in (together with https://github.com/tensorflow/tfjs-converter/pull/112)
@vbardiovskyg It would be great if we can add a test of the tf_hub conversion to test_pip_package.py, but given it downloads quite a lot of data from the internet, I'm not sure that test would be very reliable or efficient. Is there a smaller model on tf_hub that can be used for testing?

Review status: 1 of 4 files reviewed at latest revision, 3 unresolved discussions, all commit checks successful.

Comments from Reviewable

Hi, we are already testing with a module created on fly in: https://github.com/tensorflow/tfjs-converter/blob/master/python/tensorflowjs/converters/tf_saved_model_conversion_test.py#L248

Review status: 1 of 4 files reviewed at latest revision, 3 unresolved discussions, all commit checks successful.

Comments from Reviewable

I can add a test to test_pip_package but wondering whether we can avoid duplication of the create_hub_module function.

Review status: 1 of 4 files reviewed at latest revision, 3 unresolved discussions, all commit checks successful.

Comments from Reviewable

Yep, that test is good. But it doesn't cover the packaging of the functionality at the level of the pip binary. It didn't catch the typo, for example. Adding such a new test in test_pip_package.py would be valuable.

Review status: 1 of 4 files reviewed at latest revision, 3 unresolved discussions, all commit checks successful.

Comments from Reviewable

Review status: 1 of 5 files reviewed at latest revision, 3 unresolved discussions, all commit checks successful.

README.md, line 77 at r5 (raw file):

tf_hub

I know it's unrelated to this PR. But can you add 'keras for Keras HDF5' here?

python/tensorflowjs/converters/converter.py, line 156 at r5 (raw file):

'--signature_name'

Can you add a check for if --signature_name is specified and --input_format is not tf_hub, in which case an error should be thrown?

Comments from Reviewable

Reviewed 1 of 3 files at r2, 1 of 1 files at r4, 2 of 2 files at r5.
Review status: all files reviewed at latest revision, 5 unresolved discussions, some commit checks failed.

Comments from Reviewable

Review status: 1 of 5 files reviewed at latest revision, 5 unresolved discussions, all commit checks successful.

README.md, line 77 at r5 (raw file):
Previously, caisq (Shanqing Cai) wrote…

tf_hub

I know it's unrelated to this PR. But can you add 'keras for Keras HDF5' here?

Done.

python/tensorflowjs/converters/converter.py, line 157 at r5 (raw file):

  parser.add_argument(
      '--signature_name',
      type=str,

There is actually a default for this value so it will always be set. The advantage is a cleaner API. If you insist on the change, please advise how to to differentiate

Comments from Reviewable

Review status: 1 of 5 files reviewed at latest revision, 6 unresolved discussions, all commit checks successful.

python/tensorflowjs/converters/converter.py, line 157 at r5 (raw file):
Previously, vbardiovskyg wrote…
There is actually a default for this value so it will always be set. The advantage is a cleaner API. If you insist on the change, please advise how to to differentiate

Unfinished draft comment, anyway I went with no default value in the end.

Comments from Reviewable

Review status: 1 of 5 files reviewed at latest revision, 6 unresolved discussions, all commit checks successful.

python/tensorflowjs/converters/converter.py, line 208 at r7 (raw file):

(F

nit: no parentheses are required here as per Google Python style.

Comments from Reviewable

Review status: 1 of 5 files reviewed at latest revision, 7 unresolved discussions, some commit checks pending.

python/tensorflowjs/converters/converter.py, line 208 at r7 (raw file):
Previously, caisq (Shanqing Cai) wrote…

(F

nit: no parentheses are required here as per Google Python style.

Done.

Comments from Reviewable


I need help with the below error.

Transaction sent: {}
(node:36641) UnhandledPromiseRejectionWarning: Error: Error broadcasting: signature verification failed; please verify account number (53298) and chain-id (thorchain-mainnet-v1): unauthorized
thorchain-rune coin

Please make sure your phrase is correct, that is a cryptographic related error when intitializing the client.


Added a new university

Original name: საქართველოს საავიაციო უნივერსიტეტი
English name: Georgian Aviation University
Website: https://ssu.edu.ge/

@uchamb First stage of verification passed, official domain is ssu.edu.ge as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@uchamb Thank you for your patience while waiting for a review and processing your request. Pull request merged.


<EMAIL_ADDRESS><EMAIL_ADDRESS>Reflect.getMetadata("design:type", target, propertyKey) == undefined ?

class Point {
  x!: number;
  y!: number;
}

class Line {
    private _p0!: Point;
    private _p1!: Point;

    @validate
    set p0(value: Point) { this._p0 = value; }
    get p0() { return this._p0; }

    @validate
    set p1(value: Point) { this._p1 = value; }
    get p1() { return this._p1; }
}

function validate<T>(target: any, propertyKey: string, descriptor: TypedPropertyDescriptor<T>) {
    let set = descriptor.set;
    descriptor.set = function (value: T) {
      let type = Reflect.getMetadata("design:type", target, propertyKey);
      console.log(type) // undefined
      if (!(value instanceof type)) {
        throw new TypeError("Invalid type.");
      }
      // set.call(target, value);
    }
}

{
  "compilerOptions": {
    "target": "es5",
    "lib": [
      "dom",
      "dom.iterable",
      "esnext"
    ],
    "allowJs": true,
    "skipLibCheck": true,
    "esModuleInterop": true,
    "allowSyntheticDefaultImports": true,
    "strict": true,
    "forceConsistentCasingInFileNames": true,
    "module": "esnext",
    "moduleResolution": "node",
    "isolatedModules": true,
    "noEmit": true,
    "jsx": "preserve",
    "experimentalDecorators": true,
    "emitDecoratorMetadata": true,
    "resolveJsonModule": true
  },
  "include": [
    "src"
  ]
}

I'm having the same issue. It looks like it comes from here https://github.com/facebook/create-react-app/issues/6388 which leads to https://github.com/babel/babel/issues/9681.
Basically, Babel doesn't support emitDecoratorMetadata: https://babeljs.io/docs/en/babel-plugin-transform-typescript#typescript-compiler-options

Had the same bug. But when i put
import "reflect-metadata";

as the first ever line in index.tsx with the following options in tsconfig.json
    "experimentalDecorators": true,
    "emitDecoratorMetadata": true,

the issue was solved

我是这样处理的...
* 1. config-overrides.js 中开启.babelrc

const { useBabelRc } = require('customize-cra');

module.exports = override(
    useBabelRc()
);

* 1. .babelrc中添加配置

{
    "plugins": [
      "babel-plugin-transform-typescript-metadata",
      ["@babel/plugin-proposal-decorators", { "legacy": true }],
      ["@babel/plugin-proposal-class-properties", { "loose": true }]
    ],
    "presets": [
      "@babel/preset-typescript"
    ]
}

* 1. 把配置中需要的包下载一下

试了好多种方法 这种成功了 你试试看

also good for react native

我是这样处理的...
* 1. config-overrides.js 中开启.babelrc

const { useBabelRc } = require('customize-cra');

module.exports = override(
    useBabelRc()
);

* 1. .babelrc中添加配置

{
    "plugins": [
      "babel-plugin-transform-typescript-metadata",
      ["@babel/plugin-proposal-decorators", { "legacy": true }],
      ["@babel/plugin-proposal-class-properties", { "loose": true }]
    ],
    "presets": [
      "@babel/preset-typescript"
    ]
}

* 1. 把配置中需要的包下载一下

试了好多种方法 这种成功了 你试试看

also good for react native

I try it. it is working for me. Tips: you should import reflect metadata to every file top line
I use react-native framework.

Actually importing reflect-metadata in every file can cause this problem. If there are two different versions of reflect-metadata in your module tree then multiple versions of reflect-metadata may get loaded. If this happens, you may end up with a sort of "split brain" where some metadata is in one version and some is in the other.
Load reflect-metadata only once in the entrypoint file of the project. Do not import (or add a dependency to) reflect-metadata within a library.

Another thing that I had to do to make @liuxinya's answer work for an application running using Metro builder was to start the application using the command npx react-native start --reset-cache. Without it, unnecessary caching of babel steps was leading to the configuration changes not working. Also, the project's babel.config.js was configured as follows:
module.exports =  {
  "plugins": [
    'babel-plugin-transform-typescript-metadata',
    ["@babel/plugin-proposal-decorators", { "legacy": true }],
    ["@babel/plugin-proposal-class-properties", { "loose" : true }]
  ],
  "presets": ["module:metro-react-native-babel-preset"]
}

Closing this as External as it seems to be an issue with Babel's emit.

Actually importing reflect-metadata in every file can cause this problem. If there are two different versions of reflect-metadata in your module tree then multiple versions of reflect-metadata may get loaded. If this happens, you may end up with a sort of "split brain" where some metadata is in one version and some is in the other.
Use npm ls reflect-metadata to see if you have multiple versions of reflect-metadata in your project.
Load reflect-metadata only once in the entrypoint file of the project. Do not import (or add a dependency to) reflect-metadata within a library.

This should hopefully no longer be an issue as of<EMAIL_ADDRESS>or later as long as the minimum version of any copy of reflect-metadata in your dependencies is at least<EMAIL_ADDRESS>or higher. In 0.1.12, reflect-metadata would no longer overwrite another copy that was present. As of 0.2.1, there is now a shared registry attached to Reflect that multiple copies will register with so that metadata is still reachable.
Also, the API surface of reflect-metadata is unlikely to change, so it should be safe to manually deduplicate multiple instances of the package in your dependency tree. You can use npm ls reflect-metadata to see which different versions are present, and you can use the "overrides" key in package.json to repoint stale dependencies to the more recent version.


Reduce the maximum number of vertices of editable features

Fixes #10841.
The new limit is 1000 vertices. Take into account that a geometry with 1000 vertices will also render ~1000 extra markers between each vertex so that users can expand the geometry (and that is the reason why we're changing this).
@matallo 👍 ?
cc: @xavijam

🚀


Difficult to tell what version of Dart is used by Flutter Engine

I tried flutter --version and flutter doctor and neither printed the version of Dart that we're using.
Can we show:

version of Dart SDK that we download and use from our tools

In either flutter --version or flutter doctor ?
Thanks!

The versions are all pinned by the current Flutter repo version. Can you
elaborate on why the specific versions of Dart would be helpful? (I mean,
we could also give the versions of all the pub packages the flutter tool
uses and third-party packages that the engine was compiled with, but again,
those are all pinned by the framework repo version.)
On Thu, Jul 21, 2016 at 9:48 AM Seth Ladd<EMAIL_ADDRESS>wrote:

I tried flutter --version and flutter doctor and neither printed the
version of Dart that we're using.
Can we show:

version of Dart that we embed
version of Dart SDK that we download and use from our tools

(hopefully those two are identical :)
In either flutter --version or flutter doctor ?
Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/4986, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAhpHE0aPPzwcrGnCAmMM4U7JEfBSLKEks5qX6LdgaJpZM4JR_1T
.

I was trying to file a bug on the Dart SDK, and I wanted to give them the version of Dart that I was using (through Flutter).

Ah, yeah, that's fair enough.

Currently I see:
[~/src/flutter] (master) $ flutter --version
Flutter on channel master (from git@github.com:pq/flutter.git)
Framework revision 07ba37976c (33 hours ago); engine revision 9c6fc0fb1e

How about if we tack on the dart SDK version info from bin/cache/dart-sdk.version?  IOW, something like:
[~/src/flutter] (master) $ flutter --version
Flutter on channel master (from git@github.com:pq/flutter.git)
Framework revision 07ba37976c (33 hours ago); engine revision 9c6fc0fb1e; dart SDK 1.18.0-dev.4.4

?

@sethladd, @Hixie : how does the above proposal sit with you?
Something like:
[~/src/flutter] (master) $ flutter --version
Flutter on channel master (from git@github.com:pq/flutter.git)
Framework revision 07ba37976c (33 hours ago); engine revision 9c6fc0fb1e; dart SDK 1.18.0-dev.4.4

That would address the "version of Dart SDK that we download and use from our tools" part of @sethladd's original comment. I'd probably put the Dart SDK on a third line, but other than that, it SGTM.
It doesn't address the other part of Seth's original request though.

I'd move the Dart SDK version down to its own line.
Good start. Thank you!

As a matter of record, sample output now looks like:
[~/src/git/clones/flutter] (sdk_version) $ flutter --version
Flutter on channel sdk_version (from git@github.com:pq/flutter.git)
Framework revision e8223e25f0 (3 hours ago); engine revision 607d379c23
Dart version 1.19.0-dev.5.0 (Wed Aug 10 09:29:58 2016) on "macos_x64"

Hm, we have two "Darts" going on. The SDK we use to run utils on the command line, and we embed a Dart into our engine.
How can we make it clear that the Dart version you are showing here is for the SDK that drives our tools, and makes room for you to also add a line that tells the user which version of Dart is in their engine?

Good point.
I guess we could do something like:
Framework Dart version 1.19.0-dev.5.0; engine Dart version 1.18.1
Having said that, there's currently no easy way (that I know of) to get the embedded Dart version from within a flutter repo checkout.   Outside flutter, I guess we could work backwards from the engine revision and figure it out from the dart_revision specified in DEPS?  That's clumsy though...
cc @Hixie or @devoncarew

Taking a similar tack we can also derive the Dart version from the framework revision (this time looking at the corresponding bin/cache.dart-sdk.version in the flutter_tools git tree).
I guess it comes down to ergonomics...

Having said that, there's currently no easy way (that I know of) to get the embedded Dart version from within a flutter repo checkout.

We can ask for a metadata file to be added to the project, from the engine.
Meanwhile, I'd suggest:
Flutter tools using Dart version 1.19.0-dev.5.0; Flutter engine using Dart version 1.18.1

Cool.  Until we have the metadata file, I don't see a way to get theFlutter engine using Dart version 1.18.1 bit though.  Should we just leave it out for now?  Would you open an issue on the engine to add this file?

The best way to find out what version the engine uses is to run some Dart
code on the test shell and see what it finds. That way you know it's right.
:-)
On Thu, Aug 11, 2016 at 4:10 PM Phil Quitslund<EMAIL_ADDRESS>wrote:

Cool. Until we have the metadata file, I don't see a way to get theFlutter
engine using Dart version 1.18.1 bit though. Should we just leave it out
for now? Would you open an issue on the engine to add this file?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/4986#issuecomment-239320624,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAhpHBNCmBi82_MOBmteVgJSG7GWxZKuks5qe6vEgaJpZM4JR_1T
.

You can leave the second part out for now. Thanks!
On Thu, Aug 11, 2016 at 16:14 Ian Hickson<EMAIL_ADDRESS>wrote:

The best way to find out what version the engine uses is to run some Dart
code on the test shell and see what it finds. That way you know it's right.
:-)
On Thu, Aug 11, 2016 at 4:10 PM Phil Quitslund<EMAIL_ADDRESS>wrote:

Cool. Until we have the metadata file, I don't see a way to get
theFlutter
engine using Dart version 1.18.1 bit though. Should we just leave it out
for now? Would you open an issue on the engine to add this file?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/4986#issuecomment-239320624,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AAhpHBNCmBi82_MOBmteVgJSG7GWxZKuks5qe6vEgaJpZM4JR_1T
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/4986#issuecomment-239321338,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAVZ1GCWOJsQapOGGKkS8HYtfq8k3lqks5qe6y4gaJpZM4JR_1T
.

Sounds good.  Will you open an issue to track the engine metadata ask?

We've got the Dart version used by tools in as of 803fbec51b6560d1f54a14fa45134a1ba6270f05.  Once https://github.com/flutter/flutter/issues/5355 is implemented, I'll add the engine details.

Closing; the only remaining issue is in #5355.


ThrottlingException few times a day

Hello crowdsec team,
few times a day I get error:
Failed to update IPSets: Failed to commit ipset changes: ThrottlingException: Rate exceededntstatus code: 400, request id: xxxxxxxxxxxxx" acl=my_waf_acl region=eu-central-1 scope=REGIONAL

AWS support told me there is hard limit to do 1 API call per second. Is it possible this is creating more calls per second ?

Thanks a lot

Hello,
This can happen if you have multiple elements in your waf_config or maybe during the initial creation of the sets at startup if you have more than 10k decisions (although i've never ran into this limit).
https://github.com/crowdsecurity/cs-aws-waf-bouncer/pull/15 should help reduce the amount of calls made to the UpdateIPSet API when sharing the same RuleGroup for multiple WebACLs.
We'll be looking into implementing rate limiting when calling AWS APIs to make sure we don't go over the quotas.

Hi @blotus. I have only one web_acl in my config
waf_config:
  - web_acl_name: web-waf
    fallback_action: captcha
    rule_group_name: crowdsec-rule
    scope: REGIONAL
    region: ...
    ipset_prefix: crowdsec-ipset
    capacity: 50

Regarding decisions I have only 50-100 (+ community blacklist where is like 26k IP addresses).
I use workaround what you suggested where in web-waf2 Im using crowdsec RuleGroup created in web-waf (manually added). This can cause that bouncer is using more API calls ?


A few schema changes:

Add provider_id to covid_observations Primary Key
Remove covid_official and covid_usafacts tables. We only have covid_observations now and we can differentiate data from other sources via the provider_id column
Added an id column to the locations table. This is  a String that matches the locationId column from the CAN api
dropped location and location type from covid_observations in favor of new Location.id column
Removed pk attribute from DatasetBase -- this is now inferred by sqlalchemy for us
Changed from table_name: str to table: Type[Base] on DatasetBase

End result is that:

we only have one main covid observations table. The provider is part of the primary key so we will have potentially multiple observations for each (dt, location, variable, demographic), one for each provider. This should enable the features of querying/filtering based on a specific provider (e.g. all data from state dashboards, all data from cdc, etc.)
We now have the location_id column that lines up with what CAN uses.

cc @ghop02 @TomGoBravo @mikelehen

👍
To be clear, what's the relation between this new provider_id and the existing provider column we're getting in the parquet file we're consuming?

the id is the auto-incrementing integer we use internally.
The provider column is still what shows up in the parquet file


AG-769: fixed validate_resource_id behaviour.

:+1: Good catch

Actually this PR did introduce incorrect behavior and was not correct. See fix in https://github.com/scionrep/scioncc/commit/1e2419a4ee8bb951f9d3009dd37e205576497ad3
When an ID is provided, it must be correct and existing, even if optional=True.
The optional is wrt to the argument existing, not wrt the resource existing. Changing this would change the behavior of the entire framework.


update Dockerfile

fix the error source url for spark-2.1.0 (line 21)
The link appeared to be dead.

Thanks @hypotheses


Cache response

Even with #161 fix, rendering can take a few seconds. Feature request: cache the response in memory as it doesn't change until server restarts anyway.

:+1: it would be great. I have also some concerns about API security. It would be great to append some kind of before filters that could break rendering documentation for some endpoints. Then we should be careful with caching.

:+1:


Update gitignore for playcanvas build files

I confirm I have signed the Contributor License Agreement.

I think this was submitted 10 minutes ago.

Yep, too late. :wink:


Parallelize compute_chunks_operands

For a 64 core machine at a cycle count of ~16M, Jolt spends ~1.8% of its time in a segment called compute_chunks_opreands here.
This segment allocates and computes C different chunks for each instruction. For example for the EQ instruction we split the input operands X, Y into 4 8-bit chunks (WORD_SIZE / C). We then can compute EQ over each chunk individually.
Idea for acceleration: Split chunks_x and chunks_y into mutable slices. Iterate over each and compute the values in parallel writing the the slice indexes directly.
It may be helpful to review the tracing strategy for performance testing.

Looks like the else branch of the loop can be removed as well: https://github.com/a16z/jolt/blob/main/jolt-core/src/jolt/vm/mod.rs#L533

Can you assign me this issue?

Please! Feel free to ask questions here.

@githubsands any update on this?

I made some changes and tried profiling it with the command cargo run -p jolt-core --release -- trace --name sha2-chain --format chrome. But it fills the swap on my system and takes forever to profile. Am I doing something wrong?

Is this issue still open?

Hi @sragss, I'm having difficulty in reproducing the 1.8% (I'm only getting .09%). Right now I run
cargo run -p jolt-core --release -- trace --name sha2-chain --format chrome --pcs hyrax

and then getting stats in perfetto using SQL
select
name, dur, total_dur, (dur * 100. / total_dur) as dur_pct
from slices
cross join (
select dur as total_dur
from slices
where name='Example_E2E'
)
where name = 'compute_chunks_operands';

name | dur | total_dur | dur_pct
-- | -- | -- | --
compute_chunks_operands | 470260292 |<PHONE_NUMBER>17 | 0.09462063389942933

So this is only getting .09%. I'm running on an 8-core M1 with 242 cycle count. So I had a couple of questions:

What specific command did you use to generate your benchmarks?
Is there a better way to use perfetto for checking how much time is spent in each segment?

242 cycle count is too small to get an idea of relative asymptotic performance. Can you try a bigger example – maybe in the 128k-512k range?
Also thought sha2-chain was around 3M cycles, did you modify it to fit in a smaller amount of RAM?

Sorry, silly mistake. When I looked up how to find the cycle count, the thing it actually pointed me to was the battery cycle count 🤦 I didn't realize you were referring to trace length - 3,632,556 in my case. I ran it on the original sha2-chain.
But re: the questions above, what are the steps for reproducing your benchmarks? Or possibly do you have any ideas why I might be getting a much lower %?

Hi , can i take on this issue ?


:update: /projects consumes /api/projects

ChangeList

/projects consumes api/projects, db changes will be reflected on projects page
Adds progress loader for GET requests and redirects
Telegram icon doesn't show if teamTelegramHandle is null
Share project link and copy to clipboard
BUGFIX for project_id mappings

Further Work

Add more social links and website link

'../../components/' can be replaced with '@components/'. This also works for '@styles/'
You can add your own custom ones in tsconfig.json at the root dir.


equerry, catenas (logical-conflict)

This pull request was generated by the 'mq' tool

/trunk merge


Update react-app-rewired bin to allow node arguments

Updates the bin file to match latest react-scripts bin in CRA (v1.0.14). This allows users to pass node arguments to our process, eg the --inspect flag for debugging tests.

<EMAIL_ADDRESS>


sql analysis "filter" type node location is wrong

sql:
SELECT "oi"."ProductId", "o"."OrderId", "o"."CustomerId" FROM "order_items" AS "oi" JOIN "orders" AS "o" ON "oi"."OrderId" = "o"."OrderId" JOIN "customers" AS "c" ON "o"."CustomerId" = "c"."Id" WHERE "o"."PurchaseTimestamp" >= '2023-01-01' AND "o"."PurchaseTimestamp" < '2024-01-01'

json:
"filter": {
  "type": "AND",
  "left": {
    "type": "EXPR",
    "node": "(\"o\".\"PurchaseTimestamp\" >= '2023-01-01')",
    "nodeLocation": {
      "line": 1,
      "column": 225
    }
  },
  "right": {
    "type": "EXPR",
    "node": "(\"o\".\"PurchaseTimestamp\" < '2024-01-01')",
    "nodeLocation": {
      "line": 1,
      "column": 269
    }
  },
  "nodeLocation": {
    "line": 1,
    "column": 201
  }
}

nodeLocation of "(\"o\".\"PurchaseTimestamp\" >= '2023-01-01')" should be
"nodeLocation": {
  "line": 1,
  "column": 201
}

HI @cyyeh
I think this result is expected for our parser. Because (\"o\".\"PurchaseTimestamp\" >= '2023-01-01') is an GREAT_EQAUL_EXPRSSION which position is depended on where is the greater-eq char, I think it makes sense for me.
The location 201 is for "o"."PurchaseTimestamp". I think we have provided the list of expr sources in the latest version. You can find it in exprSources.

HI @cyyeh I think this result is expected for our parser. Because (\"o\".\"PurchaseTimestamp\" >= '2023-01-01') is an GREAT_EQAUL_EXPRSSION which position is depended on where is the greater-eq char, I think it makes sense for me. The location 201 is for "o"."PurchaseTimestamp". I think we have provided the list of expr sources in the latest version. You can find it in exprSources.

cc @andreashimin  @onlyjackfrost


patchesStrategicMerge deprecated in Flux 2

Hi,
I'm looking for a way to add customizations to my kustomize.yaml file generated by this Terraform provider.
Starting with v0.18 of Flux 2, the kustomize.toolkit.fluxcd.io/v1beta2 API was updated and in combination with that, the .spec.patchesStrategicMerge was deprecated in favour of .spec.patches.
How can we run this Terraform provider so that we can use the .spec.patches instead of .spec.patchesStrategicMerge?
Here is the link to the discussion about upgrade of Flux to the Kustomize v1beta2 API:
https://github.com/fluxcd/flux2/discussions/1916#discussion-3616377
I know there is another issue open (#231) that talks about a similar thing, but created a separate one due to the deprecation part.

As for my case, I'd like to drop some particular value (that makes Flux to fail in OpenShift) and to increase the memory settings of the containers.
Here is what I'd like to see as a result:
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:
  - gotk-components.yaml
  - gotk-sync.yaml
patches:
  - patch: |
      apiVersion: apps/v1
      kind: Deployment
      metadata:
        name: all
      spec:
        template:
          spec:
            containers:
              - name: manager
                securityContext:
                  runAsUser: 65534
                  seccompProfile:
                    $patch: delete
    target:
      kind: Deployment
      labelSelector: app.kubernetes.io/part-of=flux

  - target:
      kind: Deployment
      name: helm-controller
    patch: |
      apiVersion: apps/v1
      kind: Deployment
      metadata:
        name: ignored
      spec:
        template:
          spec:
            containers:
            - name: manager
              resources:
                limits:
                  memory: 3Gi
                requests:
                  memory: 1Gi

It is not possible to do any customisation at install time with Terrafrom, you'll have to use the CLI. cc @phillebaba

hi @stefanprodan and @phillebaba,
Today we are using both the flux_install datasource and flux_sync datasource to get Flux up and running.
In the flux_sync datasource, there is a possibility to customize the generated kustomize.yaml file, but the only supported option right now is the patchesStrategicMerge.
I get the patchesStrategicMerge in place after following the customize-flux guide.
What would have been nice maybe is to have another input that makes an append to the end of kustomize.yaml content possible. That way the users could append a patches for instance.
I don't know if that's the best way forward, but that would at least be a option that would work in my scenario and probably for the people asking for customizations in #231 as well :)
Kind regards,
Tobias

Tjena @tobiasehlert :) I am busy working on the next bootstrap resource that is going to replace the datasource right now, but I should have some time to have a look at this during the weekend and see if I can come up with a good alternative solution.

Tjena @tobiasehlert :) I am busy working on the next bootstrap resource that is going to replace the datasource right now, but I should have some time to have a look at this during the weekend and see if I can come up with a good alternative solution.

Wunderbar @phillebaba 😄
As an option (which I rather not want to go with) would be to use the terraform helm provider and set my memory values.. but I'd definitely rather see patches being added here.
Looking forward to your findings 👍

.spec.patchesStrategicMerge was deprecated in favour of .spec.patches.

This has nothing to do with Kustomize config files, there is no spec in there. The deprecation refers to Flux CRD.

Any thoughts about this one over the weekend @phillebaba? :)

In the flux_sync datasource, there is a possibility to customize the generated kustomize.yaml file, but the only supported option right now is the patchesStrategicMerge.
I get the patchesStrategicMerge in place after following the customize-flux guide.
What would have been nice maybe is to have another input that makes an append to the end of kustomize.yaml content possible. That way the users could append a patches for instance.

Will this suffice during the wait? https://github.com/fluxcd/terraform-provider-flux/issues/282#issuecomment-1290205138

I ran into this same issue while trying to configure flux to run on a particular node group.  Came up with a pretty simple and light weight solution that just appends my custom patches to the kustomization content.  It looks something like this.
data "flux_sync" "main" {
  target_path = var.target_path
  url         =<EMAIL_ADDRESS>  branch      = var.branch
}

locals {
  patched_kustomize_content = <<-EOT
    ${trimspace(data.flux_sync.main.kustomize_content)}
    patches:
    - patch: |-
        - op: add
          path: /spec/template/spec/nodeSelector/role
          value: system
      target:
        kind: Deployment
  EOT
}

resource "github_repository_file" "kustomize" {
  repository = github_repository.main.name
  file       = data.flux_sync.main.kustomize_path
  content    = local.patched_kustomize_content
  branch     = var.branch
}

The nice part is with this approach you can really add any kustomization config you need without breaking any of the provider functionality.
Hope this helps.

Similar to rparmer I use templating function to modify the customization yaml. The fact that Flux provided the yaml files makes it pretty flexible.


Consider RST versions of GOALS.md, etc.

We should decide whether or not to have RST-doc versions of GOALS.md, CONTRIBUTING.md, etc., so that people reading the docs can see them there. We could also just link out to the Markdown versions (which is what the docs currently do), though that's a bit less friendly.
NOTE: in any case, we should be very careful to separate developer docs from user docs.

markdown docs can be published now with https://github.com/envoyproxy/gateway/pull/571
keeping this issue open to figure out how to separate dev docs from user ones

Hi, can you explain the meaning of dev docs here? The docs under docs/dev? If so, why do we need to separate them, I think user or developer can read them too, need some context on this:)

@Xunzhuo the goal is to get the user to experience EG w/o bogging them down with inner details.
Right now navigation is flat for https://gateway.envoyproxy.io/ , we need to make it tiered (user/examples as well as dev/design) and maybe even default to user

Yep, I see. Thanks for the comments.

Now that .md support was added, we just need to link GOALS.md to the Sphinx docs generator.

https://github.com/envoyproxy/gateway/pull/932 adds GOALS.md and CODEOWNERS.md to the sphinx docs directory as symlinks

I also agree that there should be clearer separation between dev and user docs. If no one has claim it yet, I can work on a proposal on how to best structure the docs.

@haq204 thanks for PR #932.

If no one has claim it yet, I can work on a proposal on how to best structure the docs.
@haq204 feel free to create a separate issue and a PR to fix.


Configuration via environment variables not working?

# Verify environment variables
$ docker inspect psql-db-exporter | grep PG_
                "PG_EXPORTER_DISABLE_DEFAULT_METRICS=true",
                "PG_EXPORTER_DISABLE_SETTINGS_METRICS=true",
                "PG_EXPORTER_EXTEND_QUERY_PATH=/queries.yaml",

# Verify that queries.yaml is mounted correctly
$ docker inspect psql-db-exporter | grep -A 2 Binds
            "Binds": [
                "/mypath/queries.yaml:/queries.yaml:rw"
            ],

# Check queries.yaml
$ cat queries.yaml
<exact content of the sample file in this repository>

# Expect no "pg_settings", but get 582
$ docker run --rm --network="default" appropriate/curl -s http://psql-db-exporter:9187/metrics | grep pg_settings | wc -l
582

# Expect some "user_tables" results, but get 0
$ docker run --rm --network="default" appropriate/curl -s http://psql-db-exporter:9187/metrics | grep user_tables | wc -l
0

ok, there are no user_tables because maybe the query is invalid for PG 10?
there are, however, pg_database enties from the queries.yaml.
That leaves me wondering why I get pg_settings despite PG_EXPORTER_DISABLE_SETTINGS_METRICS.

What version of the exporter do you use?

v0.4.7

PG_EXPORTER_DISABLE_SETTINGS_METRICS was introduced after v0.4.7 release. You should use the master branch if you need to disable settings metrics.

Pretty much resolved.


cp: Player score for hardpoints

Amped Hardpoint doesn't have the player scores for hardpoints hooked up.
IIRC, it's something like this (I'm going to verify these soon, but it's been more than a month since I've played a game of AMP):

Action
Assault Score
Defense Score

Being on the point when captured (if it started from being uncaptured or was captured from the other team)
250
0

Being on the point when captured (if it started from uncaptured but still biased towards your team)
TODO
0

Amping a point (for the first time after capping if it started from being uncaptured or was captured from the other team) (if you have been on the point for at least TODO seconds [or percent?] while amping)
0
250

Amping a point (for the first time after capping if it started from being uncaptured or was captured from the other team) (if not the above case)
0
TODO

Kill opposing team while on captured point
0
50 (or was it 75?)

TODO seconds on a captured point
0
25

TODO seconds on a amped captured point
0
TODO

I'll probably try and implement this myself later.
https://github.com/R2Northstar/NorthstarMods/blob/0fa8c57650daa9351f4cc4a153f7642001c7ce05/Northstar.CustomServers/mod/scripts/vscripts/gamemodes/_gamemode_cp.nut
https://github.com/R2Northstar/NorthstarMods/blob/0fa8c57650daa9351f4cc4a153f7642001c7ce05/Northstar.CustomServers/mod/scripts/vscripts/mp/_score.nut
AMP is also missing the point status overlay while sitting on a point.

The only sources that I could find online were these:
https://www.reddit.com/r/titanfall/comments/6ewbjz/how_exactly_is_amped_hardpoint_scored/dido3rc/
https://titanfall.fandom.com/wiki/Hardpoint_Domination
The wiki one is from another mode from Titanfall 1 but the points may be similar

I dumped the score data table and I guess the missing point values are the Assist scores.
but I am not sure when exactly they are awarded.
https://gist.github.com/RoyalBlue1/8aa110131eba1471477d6dd1274dca1f#file-ampedhardpointscoreevents-csv

There should probable be Titanmeter and Coremeter colums in this table I got these values from the gameplay I found on youtube
https://gist.github.com/RoyalBlue1/0d101beea7174ae500716b725c3cab92

Since stryder's working again, I'd like to test a few things in a public match at some point this week.

https://gist.github.com/RoyalBlue1/0d101beea7174ae500716b725c3cab92


WIP: update docs and examples

Codecov Report

Merging #245 into master will decrease coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #245      +/-   ##
==========================================
- Coverage   93.86%   93.74%   -0.13%
==========================================
  Files          13       13
  Lines        1566     1566
==========================================
- Hits         1470     1468       -2
- Misses         96       98       +2

Impacted Files
Coverage Δ

streamz/sources.py
95.76% <ø> (ø)
:arrow_up:

streamz/compatibility.py
66.66% <0%> (-33.34%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6445fa9...f16b464. Read the comment docs.


Create new release based off master

Hey there,
Could you please create a new tag / release based off the latest version in master?  The version that is installed when using brew has issues in parseConfLinesIsStanza that have been resolved in the master branch.
Thanks!

Hmm... I switched to main awhile ago, but I may need to fix what Homebrew does.  Let me look into this and get back to you.

Oh yeah, looks like version 1.0 was way old!  I just created version 1.1 here and then I updated the Homebrew formula so that should address the issue.
Please give it a shot and let me know if that fixes things for you (it did for me).
-- Doug

works great now!  thanks!


Arrow ingestion run away memory

After a short time of running Parca with the --experimental-arrow settings on we see compaction on a run away train consuming all the memory. Current suspicion is something is incorrect with the size calculations of records during compaction and is causing it to continuously compact granules.

Part of a problem around this is we aren't calculating record sizes correctly. When we slice a record the size function will still calculate the total size of the unsliced record. This causes the table size to get negative.


Release notes on v2.0.3, v2.0.4 and v2.0.5

I'm not sure what's changed so I haven't updated from v2.0.2.

I agree with you. But I have not enough time now. I'm going to do about that a few days later. Thanks.

@briankracoff Done! Thak you notice it.


problem frame on ios 8.4

I tried to add this library to my table, It worked perfect on ios 7 but when I switch to run on 8.4 I got a problem that uitableview appear an small space on the top. Could anyone help me to solve this?

use this method.
[self.tableView addTopInsetInPortrait:64 TopInsetInLandscape:52];


CLI Samples to use supported --query

Could the samples be change so that it is generic. The samples show use of 'grep' so this would fail on Powershell AZ CLI.
Making the command generic would be to use the '--query' parameter like this:
az provider show -n Microsoft.VirtualMachineImages --query "registrationState" which would show the state the same way and now would be cross platform.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cd4c4f41-2050-234e-e35b-750158cfba54
Version Independent ID: 09c0145e-fa2b-210d-d1a0-4acb8c790bc3
Content: Create a Windows VM with Azure Image Builder (preview) - Azure Windows Virtual Machines
Content Source: articles/virtual-machines/windows/image-builder.md
Service: virtual-machines-windows
GitHub Login: @cynthn
Microsoft Alias: cynthn

Thanks for bringing this to our attention. We will now close this issue. If there are further questions regarding this matter, please tag me in a comment. I will reopen it and we will gladly continue the discussion.

@Karishma-Tiwari-MSFT FYI - this issue was about the use of 'grep' instead of --query in the CLI examples. I don't think that has been done yet, but I can add this in when we do an upcoming update to the Image Builder docs.


Get Login Error "Seamless single sign on failed for the user" for some users

Library

[X]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[X]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>
Description
Some users experiencing a problem with MFA when login. They get the error:
InteractionRequiredAuthError: Seamless single sign on failed for the user. This can happen if the user is unable to access on premises AD or intranet zone is not configured correctly
The app is Angular 8. Some users can login, some not. When the device has is part of the company tennant so that no MFA is done, it works always.
In Details for authentication in Azure is logged: Successful: false - MFA requirement satisfied by claim in the token.
Any Advice why some user have problems?
My configuration is:
auth: {
clientId: '45t45g4g-1ab3-4374-b63e-8139e1d42350',
authority: 'https://login.microsoftonline.com/dddddddd',
validateAuthority: true,
navigateToLoginRequestUrl: false,
},
cache: {
cacheLocation: 'localStorage',
storeAuthStateInCookie: false
},
},
{
popUp: false,
consentScopes: [
'user.read',
'xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx'
],
unprotectedResources: ['https://www.microsoft.com/en-us/'],
protectedResourceMap,
extraQueryParameters: {}
})

@Mr230268 Can you please clarify which APIs you are calling that results in this error? Generally speaking, applications should handle InteractionRequired errors by invoking acquireTokenPopup or acquireTokenRedirect. Is your application doing this?

I'm having the same problem with an React and React Native application.
I'm using react-adal which probably use msal for it's implementation.

@jo-arroyo
Maybe I'm doing something wrong. The app had before it's own user management but then we had to switch to AAD. We did it as simple as possible. It works now like this:
When the app starts the user press Login. A service then calls:
this.msal.loginRedirect();
The user enters the credentials and when it is a device outside our company a MFA is initiated. Everything runs well and the login is processed successfully and it is redirected to the app.
With this
if (this.msal.getAccount() !== null)
I check if an account is now availabale. When it is not null, I call a protected route. The server validates the token and takes the EMail adress and starts a session. From that point the session managmement is done by the app itself. We only need it to proof the Email-identity at session start.
But for me it seems that no code of my app is processed after the redirect. The crash happens before in MSAL.
The error occors only with MFA. It depends on the user. Some users work some not.
I published a version with no minimization and got this stack trace:
InteractionRequiredAuthError: Seamless single sign on failed for the user. This can happen if the user is unable to access on premises AD or intranet zone is not configured correctly Trace ID: ea91e67b-db04-4745-9ba0-55003c581901 Correlation ID: cae77e93-5661-445c-a123-aab5e4c7f170 Timestamp: 2020-07-17 10:22:04Z at InteractionRequiredAuthError.AuthError [as constructor] (https://asys-abs.azurewebsites.net/main-es2015.48235c97c73f8057d42b.js:120611:28) at InteractionRequiredAuthError.ServerError [as constructor] (https://asys-abs.azurewebsites.net/main-es2015.48235c97c73f8057d42b.js:121125:28) at new InteractionRequiredAuthError (https://asys-abs.azurewebsites.net/main-es2015.48235c97c73f8057d42b.js:121062:28) at MsalService.push../node_modules/msal/lib-es6/UserAgentApplication.js.UserAgentApplication.saveTokenFromHash (https://asys-abs.azurewebsites.net/main-es2015.48235c97c73f8057d42b.js:119044:25) at MsalService.push../node_modules/msal/lib-es6/UserAgentApplication.js.UserAgentApplication.processCallBack (https://www.replaced.com/main-es2015.48235c97c73f8057d42b.js:118599:29) at MsalService.push../node_modules/msal/lib-es6/UserAgentApplication.js.UserAgentApplication.handleAuthenticationResponse (https://asys-abs.azurewebsites.net/main-es2015.48235c97c73f8057d42b.js:118651:14) at MsalService.<anonymous> (https://asys-abs.azurewebsites.net/main-es2015.48235c97c73f8057d42b.js:118421:34) at step (https://asys-abs.azurewebsites.net/main-es2015.48235c97c73f8057d42b.js:178826:27) at Object.next (https://asys-abs.azurewebsites.net/main-es2015.48235c97c73f8057d42b.js:178775:53) at fulfilled (https://asys-abs.azurewebsites.net/main-es2015.48235c97c73f8057d42b.js:178756:28)
Thank for every help!

Hi,
I figured out what the problem is:
All users with this exception has 3rd party cookies disabled. There is a document about this problem:
https://docs.microsoft.com/de-de/azure/active-directory/develop/reference-third-party-cookies-spas
The error messages is maybe misleading or my understanding is not right. To prevent this, is one solution to add the authorization side from MS to the intranet-zone so it is not third-party?

I was using "in private" mode on chrome and by default chrome disable third-party cookies for in private mode. After enable third-party for in private mode, it started to work.

@Mr230268 It is expected that some operations in MSAL.js v.1 will not work properly with third-party cookies disabled.

I check if an account is now availabale. When it is not null, I call a protected route. The server validates the token and takes the EMail adress and starts a session. From that point the session managmement is done by the app itself. We only need it to proof the Email-identity at session start.
But for me it seems that no code of my app is processed after the redirect. The crash happens before in MSAL.

Please clarify what this protected route is. Are you navigating a user to a page that is protected by the MSAL guard, or are you initiating a HTTP request?
Please also provide logs from the MSAL Logger. This will help us understand what is happening.

Please clarify what this protected route is. Are you navigating a user to a page that is protected by the MSAL guard, or are you initiating a HTTP request?
Please also provide logs from the MSAL Logger. This will help us understand what is happening.

@jo-arroyo
I initiate a HTTP-Request. But it doesn't matter anymore.
For me it is closed because when I enable third party cookies everything works as expected again. I just leave it open to say that an error message with a hint to third party cookies would have saved me a lot of hours. This would be great.
I know now that we have to move to msal 2.X to solve this problem but the msal angular wrapper is right not ready for. So I hope this will happen soon. Til then I keep my fingers crossed that we can still enable third party cookies in the browsers.
Please think about this little hint in this case and then please close this issue. Thank you!

@Mr230268 Thank you for the feedback. We'll take this into consideration.


Revert "Fix manifest sorting in chart renderer"

What this PR does / why we need it:
This reverts commit 67abd81c3c5875232bde1432ab1ee1db49118227.
Basically #1952 splits the kube-state-metrics charts into separate manifests - so it should not regress #1939.
Which issue(s) this PR fixes:
Fixes #2008
Special notes for your reviewer:
Release note:

An issue preventing to get the file content of manifest using the FileContent func of RenderedChart in the `pkg/chartrenderer` package is now fixed.

/lgtm- @tim-ebert WDYT?

Thanks @ialidzhikov for catching this.
Where is the FileContent func used? I don't see any usage in g/g or g/grm. Is it used in the extensions?
If not, I would rather propose to remove the function instead of reverting the change.
If it is used somewhere, I would agree with you and go ahead with this PR.
I guess, then we would have to keep an eye on not putting multiple manifests into one tpl file, right? Otherwise, the manifest sorting will fail again.

Where is the FileContent func used? I don't see any usage in g/g or g/grm. Is it used in the extensions?

Yes, it is used in the extensions. Ref https://github.com/gardener/gardener-extension-provider-aws/blob/eef271f30c7e2abe03b5867b4e51111f1f9f9f86/pkg/controller/infrastructure/actuator_reconcile.go#L76-L78

I guess, then we would have to keep an eye on not putting multiple manifests into one tpl file, right?  Otherwise, the manifest sorting will fail again.

Yes, right. We should put 1 manifest per file.

Yes, it is used in the extensions.

Alright, got it, makes sense for terraformer.
Then let's go ahead and revert the change.


New Sample: Overview Map Sample

Sample
The overview map sample is a highly requested sample and was given moderate priority from Adrien.
The sample builds off the overview map created in for the AR Feature Layer sample currently under review. It uses two map components each with a different basemap. The Main ArcGIS Map has a 3D object scene layer where as the overview does not.
Checklist

[x] PR title follows convention - keyword: Short description of change
[x] PR targets the correct branch
[x] Self-review of changes
[x] There are no warnings related to changes
[ ] A build was made and tested on all relevant platforms
[x] No unrelated changes have been made to any other code or project files
[x] No unnecessary includes or namespaces added
[x] Code follows plugin coding style
[x] New code and changed code has proper formatting
[x] No unintentional formatting changes
[x] Commits have descriptive titles

ArcGIS Maps SDK Version
Maps SDK 1.7 W/ Unity 2022.3 LTS

Seeing a lighting issue

Switching between HDRP and URP doesn't work in the sample viewer

https://github.com/user-attachments/assets/e877785e-75bb-407a-8960-df61a726c166

I just tested it and its working, so it sounds like you might have missed the latest commit.

The two issues I pointed out previously have been resolved after the latest commits.

Could you have collider on the top arcgismap or make the second arcgismap invisible, so that when I fly through the map I don't see two maps?

https://github.com/user-attachments/assets/4eee6754-c73f-44e4-9298-89c3c2528719

In doc we have a review process which checks for grammar and punctuation so I took a cursory look here.

Could you have collider on the top arcgismap or make the second arcgismap invisible, so that when I fly through the map I don't see two maps?

Mesh colliders are enabled... Looks like a bug with mesh colliders because you can go through but once you through to the map it won't let you go any further.

I think the UI/UX looks good with the sample! I only have a few small things on the sample viewer menu during testing,

It looks like we are only capitalizing the first letter in unity sample list, so let's make those highlighted letter smaller case just to be consistent with other sample names.

For some reason, I noticed the entire sample list was shifted to the left, can you make a quick change on that?

The scroll view position should be x=375

Should look like this:

We've been using camel case so please change naming like the one below

Mesh colliders are enabled... Looks like a bug with mesh colliders because you can go through but once you through to the map it won't let you go any further.

Is this issue logged?

We've been using camel case so please change naming like the one below

We don't have a specific naming convention for sub-folders within a sample's folder. But looking at other samples, they follow Pascal Naming Convention, so this is appropriate and I will not be changing it. See attached weather query folder structure.

What I was referring to is to remove the space in "UI element" and change it to "UIElement" as space is prone to errors in compiling. Some call it camel case, some call it upper camel case, some call it pascal case

@ZackAllen are we going to start enforcing naming convention for sub folders? Or just Sample Parent Folders?


Treat timeout=0 as timeout disable

First version for review, test is not added yet since some problem in test environment setup. Will add it if this patch is fine.

@wilsonpage In this patch I check the timeout and ignore the setTimeout when timeout=0. It seems we can set silentTimeout for same result, but leaving the this.timeout to always null might be more clean. Anyway it's up to you :)

Hi @gmarty  Would you be able to review this small feature since @wilsonpage is away?

Amended the patch slightly replacing 0 with false.

Landed c926d989e4c10e557c0e76c6710ddfff0fea6d78


Re-add some missing content

@renesansz something weird happened and this content disappeared. Can you just confirm that this is what it's actually supposed to be?

Yep - that's peculiar. 👍

I didn't remember adding this content, not sure.. But I think it does missing the sample data.