create_render_pipeline() fails with layout=AutoLayoutMode.auto

The documentation for create_render_pipeline() claims that you can pass layout=AutoLayoutMode.auto.  This gives an eror if you try it.
The similar function create_compute_pipeline() contains code to deal with `layout=AutoLayoutMode.auto':
        if isinstance(layout, GPUPipelineLayout):
            layout_id = layout._internal
        elif layout == enums.AutoLayoutMode.auto:
            layout_id = ffi.NULL
        else:
            raise TypeError(
                "create_compute_pipeline() 'layout' arg must be a GPUPipelineLayout or 'auto'"
            )

and then uses layout_id to build the WGPUComputePipelineDescriptor *.
These lines are missing from create_render_pipeline().  It just directly takes layout._internal when building the WGPURenderPipelineDescriptor, and errors when the argument is auto.  There is no check that the layout argument is even a GPUPipelineLayout.
I have confirmed that if I modify create_render_pipeline() to handle layouts just like create_compute_pipeline(), it works correctly for the simple autolayout test casts that I've tried.
I'm still not comfortable enough with the build process to know if I'm supposed to make these changes directly to _api.py, or if this is autogenerated from higher-level code.
Python 3.12 running on MacOS
wgpu 0.15.2

Thanks for reporting! It looks like it's on oversight on my part, and create_render_pipeline() should indeed use similar logic to create_compute_pipeline(). Would you be interested to submit a pr for this?
You can change the _api.py - it's a mix of generated and manual code. You can run python codegen from the repo root to update/check the code. But I expect that that won't be necessary for this particular change. (You can just make this change and submit the pr; CI does a check too).

I will fix this.


Preview toolbar can't access previewSession cookie in latest chrome release

When rendering page server side we were getting the preview cookie to forward with requests to the API:
import { previewCookie } from "prismic-javascript";

export function getCookieRef(cookie = ""): string | undefined {
  const { [previewCookie]: ref } = parse(cookie);
  return ref;
}

It was working three weeks ago, now we don't receive any cookie from the preview redirection.
I think there may have been a regression with the preview redirection from the backend and/or sdk code available at "https://static.cdn.prismic.io/prismic.min.js".
I'm not sure this issue is best adressed here, thanks for your support to help me resolve this issue.

The issue is with chrome that recently updated Same Site cookie security, defaulting to "lax", which prevents the toolbar script to cross-site access the cookie.
The fix has to be implemented when setting the previewSession cookie on the backoffice side.

Hi @tcharlat.
We updated our backoffice and the toolbar before the update of google Chrome.
Could you give us more information please.
Do you actually receive some cookie when previewing and if yes, could you give it to us.
If you have any other informations that could be useful (name of the repo, ....) please give us as much as you can.

As there is no reply i'm closing this issue.


multiple language issue

closes #35
@dotslashbit @pamarthiabhinav  language input box is taking multiple input but it is only showing the result of language which is entered first
tell me how to fix this or what is the problem in this code

@sahitya-chandra Can you upload a screen recording on this
I think I know what to do next, just want to confirm by taking a look on the current behaviour

@sahitya-chandra you thought of one use case and that's good while you're starting. Let me give you broader scenarios of implementing multi-select with the text field.

Scenario 1: The user can think of giving space as the separator
Scenario 2: The user can think of giving a semi-colon(;) as a separator
Scenario 3: The user can think of giving a Comma(,) as a separator
And 100 more can be the case

How would you tackle all those, writing code for each is a never-ending process and frustrating too, what do you say @dotslashbit.

Here comes the multi-select where user can select only from the given options. We restrict the user to follow a format that we handle. Got it? Similar to dropdown but can select multiple options

Refer to the below resources for ideas:
https://www.npmjs.com/package/react-multi-select-component
https://primereact.org/multiselect/ --> I prefer this as this gave both visual and code views
https://coreui.io/react/docs/forms/multi-select/
https://medium.com/@triciahughes/how-to-integrate-multiselect-into-your-react-app-d1a9997dc1e1

@pamarthiabhinav yes this is exactly what I was talking about we need to implement a multi select form instead of comma separated values

@pamarthiabhinav take a look...


Tutorial Request: Accesing the forest canopy density using google earth engine

Description
Technical Level
beginner | intermediate | advanced
Length
short (< 250 words) | medium (250-500 words) | long (1000 words )

Am looking forward for a positive response

There is no tutorial description, if you'd like to continue with the proposal, please describe the tutorial in more detail. Closing for now.


Timestamp is parsed wrongly if set

We experienced some events created on Thursday Sep. 3'rd that they where timestamped as March 9'th.
The error is due to bad formatted datetime sent by BaseAction.cs
If Timestamp is set it will send the data as Timestamp.ToString() instead of .ToString("o") as when it has not been set.
if (options.Timestamp.HasValue)
				this.Timestamp = options.Timestamp.ToString ();
            else
                this.Timestamp = DateTime.Now.ToString("o");

https://github.com/segmentio/Analytics.NET/blob/master/Analytics/Model/BaseAction.cs#L39

Maybe the DateTime.Now.ToString("o"); actually should be DateTime.UtcNow.ToString("o"); as well.


BugFix: Update NumQueuedWorkOrders to fix scheduling

Quickstep scheduling is currently broken (since PR #14). The foreman only schedules work for one worker, leaving all other workers idle. This PR fixes that bug.
The foreman maintains the number of queued work orders for each worker in the WorkerDirectory. This state was not being incremented when WorkOrders are dispatched, and not being decremented when WorkOrders are completed. The search for LeastLoadedWorker would therefore always pick the first worker, resulting in serial execution of the entire query.
In this PR, I have incremented the number of queued work orders in the Foreman when it dispatches messages.
When a WorkOrderCompletion message arrives, this number must be decremented. However, the worker's thread ID is not available to the Foreman, since PR #14 moved the message deserialization into the PolicyEnforcer. So, in this PR, I've added a pointer to the WorkerDirectory in the PolicyEnforcer. The PolicyEnforcer decrements the number of queued work orders while processing WorkOrderCompletion messages.
The WorkerDirectory is not thread-safe, so the decrement should only be done in the Foreman thread. Since the PolicyEnforcer is part of the Foreman thread, this change should be fine.
Tested on CloudLab machine  (40 workers) with a few example queries.
[A big thanks to @rogersjeffreyl for helping me debug this!]

Thanks @navsan and @rogersjeffreyl for fixing this. This was an oversight on my part. I checked the correctness of queries for PR #14, but I should have also tested the performance, which would have revealed the bug.
This looks good to me. I can merge the PR once travis signals green.

Awesome, thanks!
On Tue, Jun 14, 2016, 22:16 Harshad Deshmukh<EMAIL_ADDRESS>wrote:

Thanks @navsan https://github.com/navsan and @rogersjeffreyl
https://github.com/rogersjeffreyl for fixing this. This was an
oversight on my part. I checked the correctness of queries for PR #14
https://github.com/apache/incubator-quickstep/pull/14, but I should
have also tested the performance, which would have revealed the bug.
This looks good to me. I can merge the PR once travis signals green.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-quickstep/pull/33#issuecomment-226077762,
or mute the thread
https://github.com/notifications/unsubscribe/ACZB67jcKiF6kMu6PC2qRWLyNTnnm_asks5qL26GgaJpZM4I19HS
.

@hbdeshmukh I think it's rather bug-prone to maintain queue state in the Foreman. Why not just look it up in the TMB itself? I noticed that you made the same comment above the WorkerDirectory class.

Travis failures were due to CMake validation. Build and tests succeeded. I've fixed the validation failure as well now.

LGTM, merging.

That's true. I don't think it is too bug-prone. We just need to just increment and decrement the count at a couple of places (which I missed, admittedly).
What TMB gives us is perhaps more accurate snapshot of the queue lengths of each worker compared to the queue lengths as viewed by Foreman. However the scheduling decisions themselves are much faster than a typical WorkOrder execution, so the lag (and corresponding difference in queue lengths) may not be too big an issue.
On the other hand, I am not sure of the performance implications of checking the queue lengths through TMB repeatedly, e.g. to find the least loaded worker before every work order execution.
We may not be able to get rid of WorkerDirectory completely either. Consider a case when you want to find out the least loaded worker on a specific NUMA socket. TMB doesn't recognize this case and I don't want to modify TMB code either. In such a case we need a level of indirection that gives us a list of workers on that NUMA socket.

@navsan Nice job!! Thanks @rogersjeffreyl for helping.
@hbdeshmukh Re. your question about checking the TMB, I think you only need to check the TMB periodically (i.e. for a new back of work orders). This may not be too bad even in the distributed case, but certainly checking for each queue length in the TMB for each work order dispatch is too heavy-weight. I see a nice opportunity for refactoring the code here, but we can do that in a future PR. Would be great to make a note of this refactoring task in JIRA.

This also points out that we should have a better CI in place for performance testing. We periodically run benchmark tests, but that is not in a CI pipeline. Travis is not ideal for this (no guarantees on the underlying VM that is created), but there are tools like blitz.io  and blazemeter that could work. Added a JIRA ticket to make a note of this.

@hbdeshmukh is right about WorkerDirectory, and enforcing NUMA-aware scheduling is the main reason to introduce this class.
In the distributed version, Foreman needs to query the load of Shiftboss.


add column-grey variant

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #17
Test URLs:

Before: https://main--elixirsolutions--hlxsites.hlx.live/
After: https://column-grey--elixirsolutions--hlxsites.hlx.live/plansponsors
After: https://column-grey--elixirsolutions--hlxsites.hlx.live/aboutus/our-leadership
After: https://column-grey--elixirsolutions--hlxsites.hlx.live/aboutus/commitment-to-quality
After: https://column-grey--elixirsolutions--hlxsites.hlx.live/plansponsors/pharmacy

@Ewocker
one suggestion. on the pages with 20/80 (and I assume all variants really) the images stretch on mobile to fill the width. I'd suggest changing the image to
.columns img {
  max-width: 100%;
  margin: 0 auto;
}

that should eliminate the stretching and make it center in it's columns space across all variants and breakpoints


compiler hangs on roc dev main.roc

app "cli-tutorial"
    packages { pf: "https://github.com/roc-lang/basic-cli/releases/download/0.7.0/bkGby8jb0tmZYsy2hg1E_B2QrCgcSTxdUlHtETwm5m4.tar.br" }
    imports [pf.Stdout, pf.Stdin, pf.Task]
    provides [main] to pf

main =
    Task.await Stdin.line \input ->
        when input is
            Input i -> Stdout.line i
            End -> Stdout.line "No input"

roc dev main.roc results in 100% CPU usage. roc build or roc run do not have this issue.
Originally reported on zulip

I think this was probably fixed by 6792

Still reproduces on Apple silicon:
app [main] { pf: platform "https://github.com/roc-lang/basic-cli/releases/download/0.15.0/SlwdbJ-3GR7uBWQo6zlmYWNYOxnvo8r6YABXD-45UOw.tar.br" }

import pf.Stdout
import pf.Stdin

main =
    input = Stdin.line!
    Stdout.line input


Multiprocessing with abbreviation_detector and n_process > 1 throws error

import spacy

from scispacy.abbreviation import AbbreviationDetector

nlp = spacy.load("en_core_sci_sm")

# Add the abbreviation pipe to the spacy pipeline.
nlp.add_pipe("abbreviation_detector")

test = ["Spinal and bulbar muscular atrophy (SBMA) is an inherited motor neuron disease caused by the expansion of a polyglutamine tract within the androgen receptor (AR). SBMA can be caused by this easily."]

print("Abbreviation", "\t", "Definition")
for doc in nlp.pipe(test, n_process=4):
    for abrv in doc._.abbreviations:
        print(f"{abrv} \t ({abrv.start}, {abrv.end}) {abrv._.long_form}")

Running that code leads to this. The error message doesn't make a lot of sense, It could be because there are more processes than entries. If you remove n_process the solves the problem.
Abbreviation     Definition
Abbreviation     Definition
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "C:\Python38\lib\multiprocessing\spawn.py", line 116, in spawn_main
    exitcode = _main(fd, parent_sentinel)
  File "C:\Python38\lib\multiprocessing\spawn.py", line 125, in _main
    prepare(preparation_data)
  File "C:\Python38\lib\multiprocessing\spawn.py", line 236, in prepare
    _fixup_main_from_path(data['init_main_from_path'])
  File "C:\Python38\lib\multiprocessing\spawn.py", line 287, in _fixup_main_from_path
    main_content = runpy.run_path(main_path,
  File "C:\Python38\lib\runpy.py", line 265, in run_path
    return _run_module_code(code, init_globals, run_name,
  File "C:\Python38\lib\runpy.py", line 97, in _run_module_code
    _run_code(code, mod_globals, init_globals,
  File "C:\Python38\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "C:\Users\alexd\Dropbox (UFL)\UFII_COVID19_RESEARCH_TOPICS\cord19\text_parsing_pipeline\test.py", line 13, in <module>
    for doc in nlp.pipe(test, n_process=4):
  File "C:\Python38\lib\site-packages\spacy\language.py", line 1475, in pipe
    for doc in docs:
  File "C:\Python38\lib\site-packages\spacy\language.py", line 1511, in _multiprocessing_pipe
    proc.start()
  File "C:\Python38\lib\multiprocessing\process.py", line 121, in start
    self._popen = self._Popen(self)
  File "C:\Python38\lib\multiprocessing\context.py", line 224, in _Popen
    return _default_context.get_context().Process._Popen(process_obj)
  File "C:\Python38\lib\multiprocessing\context.py", line 327, in _Popen
    return Popen(process_obj)
  File "C:\Python38\lib\multiprocessing\popen_spawn_win32.py", line 45, in __init__
    prep_data = spawn.get_preparation_data(process_obj._name)
  File "C:\Python38\lib\multiprocessing\spawn.py", line 154, in get_preparation_data
    _check_not_importing_main()
  File "C:\Python38\lib\multiprocessing\spawn.py", line 134, in _check_not_importing_main
    raise RuntimeError('''
RuntimeError:
        An attempt has been made to start a new process before the
        current process has finished its bootstrapping phase.

        This probably means that you are not using fork to start your
        child processes and you have forgotten to use the proper idiom
        in the main module:

            if __name__ == '__main__':
                freeze_support()
                ...

        The "freeze_support()" line can be omitted if the program
        is not going to be frozen to produce an executable.

This is the error message from my main piece of code with more data. It sort of makes more sense. I think it has to something to do with how the multiprocess pipe collects the results of the workers. The error pops up after a while so it's definitely running.
Process Process-1:
Traceback (most recent call last):
  File "C:\Python38\lib\multiprocessing\process.py", line 315, in _bootstrap
    self.run()
  File "C:\Python38\lib\multiprocessing\process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
  File "C:\Python38\lib\site-packages\spacy\language.py", line 1995, in _apply_pipes
    sender.send([doc.to_bytes() for doc in docs])
  File "C:\Python38\lib\site-packages\spacy\language.py", line 1995, in <listcomp>
    sender.send([doc.to_bytes() for doc in docs])
  File "spacy\tokens\doc.pyx", line 1237, in spacy.tokens.doc.Doc.to_bytes
  File "spacy\tokens\doc.pyx", line 1296, in spacy.tokens.doc.Doc.to_dict
  File "C:\Python38\lib\site-packages\spacy\util.py", line 1134, in to_dict
    serialized[key] = getter()
  File "spacy\tokens\doc.pyx", line 1293, in spacy.tokens.doc.Doc.to_dict.lambda18
  File "C:\Python38\lib\site-packages\srsly\_msgpack_api.py", line 14, in msgpack_dumps
    return msgpack.dumps(data, use_bin_type=True)
  File "C:\Python38\lib\site-packages\srsly\msgpack\__init__.py", line 55, in packb
    return Packer(**kwargs).pack(o)
  File "srsly\msgpack\_packer.pyx", line 285, in srsly.msgpack._packer.Packer.pack
  File "srsly\msgpack\_packer.pyx", line 291, in srsly.msgpack._packer.Packer.pack
  File "srsly\msgpack\_packer.pyx", line 288, in srsly.msgpack._packer.Packer.pack
  File "srsly\msgpack\_packer.pyx", line 264, in srsly.msgpack._packer.Packer._pack
  File "srsly\msgpack\_packer.pyx", line 282, in srsly.msgpack._packer.Packer._pack
TypeError: can not serialize 'spacy.tokens.span.Span' object

Running spacy 3.0, the latest version, and on Windows 10.

Well that is annoying. I'm pretty sure this is exactly what it says, the Span object is not serializable. The AbbreviationDetector stores the abbreviations as spans on the Doc, and then multiprocessing needs to be able to serialize the objects that get worked on. I think the easiest solution is to do something like here (https://github.com/allenai/scispacy/issues/205#issuecomment-597273144, converting the abbreviations to anything serializable should do, json, https://spacy.io/api/span#as_doc, etc) to make your docs serializable. I'm pretty sure this will work, although not 100%.
You might also be able to do the parallelization yourself and get around this, but the first solution is probably simpler assuming that it works.

Removing n_process definitely does work. I just popped off the argument and every just works. I only need text itself so I think I can remove the spans. I am not sure what's the way to do it because it seems like that would be deeply embedded into the implementation of the class. I am guessing I would have to fork the project and dig at the implementation of abbreviation detector to remove the span stuff.

The other github issue i linked to shows how you can convert the Span objects to serializable json (https://github.com/allenai/scispacy/issues/205#issuecomment-597273144). You would simply add this function as a final pipe in your scispacy pipeline. This would mean that your pipeline produces serializable documents, which should work fine with multiprocessing.

Damn, if that makes them non-serialisable we should probably figure out a better way, like storing span start/end indices. That's super annoying though and would be quite a breaking change...

wouldn't be too bad to make an argument for the pipe that says "make serializable", and store them in json if that is True.

I managed to get use the function that @danielkingai2 wrote in #205 by transforming it into a component and attaching it to the pipeline. Now multiprocessing works. Note that this introduces breaking changes to code and needs to be modified.
from spacy.language import Language
@Language.component("serialize_abbreviation")
def replace_abbrev_with_json(spacy_doc):
    # https://github.com/allenai/scispacy/issues/205#issuecomment-597273144
    # Code is modified to work as a component
    new_abbrevs = []
    for short in spacy_doc._.abbreviations:
        short_text = short.text
        short_start = short.start
        short_end = short.end
        long = short._.long_form
        long_text = long.text
        long_start = long.start
        long_end = long.end
        serializable_abbr = {"short_text": short_text, "short_start": short_start, "short_end": short_end,
                             "long_text": long_text, "long_start": long_start, "long_end": long_end}
        short._.long_form = None
        new_abbrevs.append(serializable_abbr)
    spacy_doc._.abbreviations = new_abbrevs
    return spacy_doc

To call the component do this:
nlp = spacy.load("en_core_sci_sm")
nlp.add_pipe("abbreviation_detector")
nlp.add_pipe("serialize_abbreviation", after="abbreviation_detector")

Changes need to be made;
You need to change abbrev._.long_text into abbrev["long_text"] and abbrev.test into abbrev["short_text"]. This is because the serialization works by making everything into a dict so you need to refer to that instead.
Now multiprocessing works perfectly. It's nice that Spacy makes it easy to extend behavior.

How far is this from being solved, and is there something I might do to help get this working? Would really like to use the abbreviation detector in my pipeline, but not being able to use it with multiprocessing is a deal breaker.

@ldorigo
I solved it already using the code I written above. It's basically just adding another component to serialize the output of abbr.
Maybe the code could be upstreamed into the library and then you add a flag to do this automatically.

As @f0lie said, you should be able to work around it in the manner described. If anyone would like to submit a PR adding a flag to the abbreviation detector component to control this, I would accept that PR.

See #368


[BACKLOG-19589] confirmation dialog appearance

Build Completed
:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -Dsurefire.runOrder=alphabetical -B -fn -f 'pom.xml' -pl 'plugins/pur/core' -P '!assemblies' -amd clean install && mvn -B -f 'pom.xml' -pl 'plugins/pur/core' -P '!assemblies' -amd site

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'plugins/pur/core' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  plugins/pur/core/src/main/java/org/pentaho/di/ui/repository/pur/repositoryexplorer/controller/TrashBrowseController.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes: <0.1% (click to expand)
org.pentaho.di.ui.repository.pur.repositoryexplorer.controller.TrashBrowseController

Instruction Change: -0.1% :small_red_triangle_down:

:new: org.pentaho.di.ui.repository.pur.repositoryexplorer.controller.TrashBrowseController.7.new XulDialogCallback() {...}

Coverage: 0% :exclamation:

Checkstyle violations
The code submitted is not complying with one or more of our guidelines. To perform these checks locally, please use this tool.
/home/buildguy/project/plugins/pur/core/src/main/java/org/pentaho/di/ui/repository/pur/repositoryexplorer/controller/TrashBrowseController.java

:heavy_exclamation_mark: 'method def modifier' has incorrect indentation level 10, expected level should be one of the following: 6, 8. at Line: 408

:heavy_exclamation_mark: 'method def' child has incorrect indentation level 12, expected level should be one of the following: 8, 10. at Line: 410

:heavy_exclamation_mark: 'method def rcurly' has incorrect indentation level 10, expected level should be one of the following: 6, 8. at Line: 411

:heavy_exclamation_mark: 'method def modifier' has incorrect indentation level 10, expected level should be one of the following: 6, 8. at Line: 413

:heavy_exclamation_mark: 'method def' child has incorrect indentation level 12, expected level should be one of the following: 8, 10. at Line: 415

:heavy_exclamation_mark: 'method def' child has incorrect indentation level 12, expected level should be one of the following: 8, 10. at Line: 416

:heavy_exclamation_mark: 'method def' child has incorrect indentation level 12, expected level should be one of the following: 8, 10. at Line: 417

:heavy_exclamation_mark: 'method def rcurly' has incorrect indentation level 10, expected level should be one of the following: 6, 8. at Line: 418

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -Dsurefire.runOrder=alphabetical -B -fn -f 'pom.xml' -pl 'plugins/pur/core' -P '!assemblies' -amd clean install && mvn -B -f 'pom.xml' -pl 'plugins/pur/core' -P '!assemblies' -amd site

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'plugins/pur/core' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  plugins/pur/core/src/main/java/org/pentaho/di/ui/repository/pur/repositoryexplorer/controller/TrashBrowseController.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes: <0.1% (click to expand)
org.pentaho.di.ui.repository.pur.repositoryexplorer.controller.TrashBrowseController

Instruction Change: -0.1% :small_red_triangle_down:

:new: org.pentaho.di.ui.repository.pur.repositoryexplorer.controller.TrashBrowseController.7.new XulDialogCallback() {...}

Coverage: 0% :exclamation:

@bmorrise please review

HTTP encode does not work，who can solve it


Increase whitespace and slightly relax the high contrast text

I'm new to 11ty and find reading the docs a little dizzying with the high contrast text, and the sidebar so close to the main content area. I lose my place a bit when reading.
This PR spaces things out a little more (especially sections between H2s) without changing the look too much. It also adds slight colour to sidebar links to visually separate them from the body content.

Can you revert the conflicts? (thank you!)

I think/hope I've done this now Zach. (Not quite sure of the process).
I synced my fork with the changes from 11ty/11ty-website that happened in the  meantime and merged back into my fork.
Does that resolve the conflicts?

Conflicts resolved! Looking

I don’t think those blues meet WCAG color contrast requirements?

Maybe we can reuse that super light blue on the link underlines? #00bcd4

I didn't realize there were dark mode styles! I added the blue you suggested to the dark mode selector so it should have plenty of contrast in both modes now.

How does this look? If it's suitable I'd love to merge before my fork is out of sync :)

Merged this one (with some slight mods too) thanks!


PBKDF2 PSA interface

Specify the PSA API for using PBKDF2

Private link for API discussion: https://github.com/ARMmbed/psa-crypto-api/issues/456, https://github.com/ARMmbed/psa-crypto-api/issues/457

Private link for API discussion: https://github.com/ARMmbed/psa-crypto-api/issues/456, https://github.com/ARMmbed/psa-crypto-api/issues/457

I completed a review of the literature in order to determine the "abstract API" (inputs and outputs) of current password hashing functions. The result is in the attached file.
Uploading password-hashing-abstract-api.md…

Thanks for the review! That's a nice analysis of commonly used schemes.
What about interfaces? Have you looked into how these schemes are used? E.g.

Typical amounts of derived material.
Whether it's common to use the output to seed a non-stretching KDF.
How people typically combine password verification and key stretching from the same password.

I haven't looked into how these schemes are commonly used, and I'm not entirely how I would go about this.
Regarding doing verification and key stretching on the same password, Catena has distinct modes for that, and Catena and Argon2 provide "additional data" that seems intended to provide domain separation, but I was a bit surprised that those are the only two that provide syntactic support for that kind of thing. PKCS#5 recommends using a structured salt with PBKDF2 to provide separation if necessary (including deriving keys for different uses).

How people typically pass pepper into the salt with algorithms that don't have a separate pepper input.


Question about style mixing

Hi, thanks to your great work.
But I wonder how can perform style mixing using this code. I didn't see any part of code related to this, should I modify the code myself to achieve this?

Hi, sorry for the late reply.
As you mentioned, the open-source code does not include style mixing.
You can implement style mixing by providing different prompt tokens for each layer
For example,
prompt = "A painting of a bridge in the style of {}"
prompt_style = [prompt.format(f"<17>-T{i}, <10>-T{i}, <22>-T{i}") for i in range(6)]
...
output = pipeline(
    prompt=prompt_style,
    num_inference_steps=25,
    cross_attention_kwargs=cross_attention_kwargs,
    generator=torch.Generator(device=accelerator.device).manual_seed(seed)
).images[0]


Error NaN, is this a bug?

What is wrong?
When I start training, the error NaN comes back. This happens in 50% of cases, and I do not understand why, I have an example where I convert the image into the same array, and everything works there.
In the example I managed to get the data at which an error occurs, maybe I am not transmitting the data correctly? Or is this a bug?
Where does it happen?
I'm testing in Google Chrome browser
How do we replicate the issue?
https://jsfiddle.net/4385yhxs/
How important is this (1-5)?
2
Expected behavior (i.e. solution)
Output states should not be NaN.

After several hours of attempts to start, i found out one feature.
Data must be the same length. Is this such a feature or a bug?)

Its the requirement: This makes sure that network is able to map all the inputs to output.


rocket verification

Hello,
I have a few questions regarding the verification of the rocket core as I am not able to run it successfully.
00f6ff50569e69d5c9c20b04c64995de9c5e8111 made a switch to a non public repo?
If using the alternate repo from freechipsproject, yosys must be compiled with verific support, which is not possible with only the evaluation license?
If I go back to dbb2d9b74d6f7038f8ae0ec997ea18e049400db4 the check csrw_mcycle_ch1 fails with Warmup failed!. I did not investigate further as it might not make sense to work on an old state.
Am I wrong to assume that with out a verific license and access to the sifive repo, it is not possible to run the verification for the rocket core?
Thanks!

Hi, yes this moved to a private repo. We will switch back to the public rocket repo as soon as the version we a verifying right now is publicly released. Right now we use Verific for rocket but I hope that we will ultimately be able to support both Verilog front-ends for verifying rocket.
If you need access to this for a (academic) research project then we may be able to get you access to the rocket repo. (access to yosys+verific is the easier bit, see https://www.symbioticeda.com/research-partner-license-program-serp/. contact me at clifford-at-symbioticeda-dot-com)


feat(notifications): add notifications destinations api calls

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Bump Mockito to 2.19.0

Closing because the project is using specs2-mock now, which provides a new Mockito version for us.


JSGrid + FontAwesome (SVG)

I have replace the icons with font-awesome (by override the function _createGridButton()) and it works like a charme:
     jsGrid.ControlField.prototype._createGridButton = function(cls, tooltip, clickHandler){
        var grid = this._grid;

        return $("<i>").addClass(this.buttonClass)
            .addClass("fa " + cls)
            .attr({
                title: tooltip,
            })
            .on("click", function(e) {
                clickHandler(grid, e);
            });
      };

The problem went when I upgraded fontawesome (for using their svg method), basically they replace the <i class="fa fa-icon"></i> with <svg> tag, and obviously, all events bound are lost.
How I can re-bind events after the icons replaced?

fix:
window.FontAwesomeConfig = {
    autoReplaceSvg: 'nest'
}


Investigate creating a "Modern Framework" of FLAnimatedImage

WWDC 2014, Session 416 ,Building Modern Frameworks

Done in merged PR https://github.com/Flipboard/FLAnimatedImage/pull/79 and will be included in 1.0.9.


Bool expression constrained to false not evaluated

erc20 verifier is stuck with:
#And
  #Not ( {
    true
  #Equals
    #lookup ( ?STORAGE , keccak ( #buf ( 32 , ?ACCT ) ++ b"0000000000000000000000000000000000000000000000000000000000000000" ) ) <Int ?SYMB_INT
  } )
...
      <k>
        JUMPI 1242 bool2Word ( #lookup ( ?STORAGE , keccak ( #buf ( 32 , ?ACCT ) ++ b"0000000000000000000000000000000000000000000000000000000000000000" ) ) <Int ?SYMB_INT ) ~> ...
      </k>

#lookup expression inside bool2Word should evaluate to false.
https://office.runtimeverification.com/jenkins/blue/organizations/jenkins/erc20-verification/detail/PR-151/22/pipeline
Can you propose a workaround until this is fixed?

#lookup expression inside bool2Word should evaluate to false.

Can you explain how we can know that? It isn't obvious to me.

#lookup expression inside bool2Word should evaluate to false.

Can you explain how we can know that? It isn't obvious to me.

From the side condition above. The expression inside bool2Word is the same.

From the side condition above. The expression inside bool2Word is the same.

By means of a counter-example: if the sub-term #lookup ( ?STORAGE , ... ) #Equals #Bottom, then the whole term is #Bottom, not false. This is possible because #buf is partial.

By means of a counter-example: if the sub-term #lookup ( ?STORAGE , ... ) #Equals #Bottom, then the whole term is #Bottom, not false. This is possible because #buf is partial.

There is also this side condition:
#And
  #Ceil ( #buf ( 32 , ?ACCT ) )

Edited fragment above to include it. All other functions in #lookup term are functional.

There is also this side condition:
#And
  #Ceil ( #buf ( 32 , ?ACCT ) )

Edited fragment above to include it. All other functions in #lookup term are functional.

What's your opinion after above update?

What's your opinion after above update?

The backend is not yet clever enough to extract the relevant #Ceil fact from the side condition, but there is work in this direction (#2351).
In any case, I recommend modifying the partial #buf abstraction in edsl.md to be total by separating the cases where it is defined and undefined. For example,
    syntax ByteArray ::= #bufExtended ( Int , Int ) [functional, smtlib(buf)]
    // Extends the domain of the original #buf by interpreting DATA modulo 2 ^Int (SIZE *Int 8).
    rule #bufExtended(SIZE, DATA) => #padToWidth(SIZE, #asByteStack(DATA %Int (2 ^Int (SIZE *Int 8))))
      [concrete]

    syntax ByteArray ::= #buf ( Int, Int ) [function]
    rule #buf(SIZE, DATA) => #bufExtended(SIZE, DATA)
      requires #range(0 <= DATA < (2 ^Int (SIZE *Int 8)))
    rule #buf(_, _) => #Bottom
      [owise]

    // The lemmas about #buf must also be changed to use #bufExtended.

There are other ways we could divide up the behavior, but the point is to separate early the cases when #buf is and is not defined so that we can reason separately about the case where it is defined. We will continue working to make the backend more clever, but I think separating defined and undefined cases like this will always make reasoning easier.

The backend is not yet clever enough to extract the relevant #Ceil fact from the side condition, but there is work in this direction (#2351).
In any case, I recommend modifying the partial #buf abstraction in edsl.md to be total by separating the cases where it is defined and undefined. For example,
    syntax ByteArray ::= #bufExtended ( Int , Int ) [functional, smtlib(buf)]
    // Extends the domain of the original #buf by interpreting DATA modulo 2 ^Int (SIZE *Int 8).
    rule #bufExtended(SIZE, DATA) => #padToWidth(SIZE, #asByteStack(DATA %Int (2 ^Int (SIZE *Int 8))))
      [concrete]

    syntax ByteArray ::= #buf ( Int, Int ) [function]
    rule #buf(SIZE, DATA) => #bufExtended(SIZE, DATA)
      requires #range(0 <= DATA < (2 ^Int (SIZE *Int 8)))
    rule #buf(_, _) => #Bottom
      [owise]

    // The lemmas about #buf must also be changed to use #bufExtended.

There are other ways we could divide up the behavior, but the point is to separate early the cases when #buf is and is not defined so that we can reason separately about the case where it is defined. We will continue working to make the backend more clever, but I think separating defined and undefined cases like this will always make reasoning easier.

That's a great suggestion, thanks! I guess this will also eliminate all #Ceil terms from side condition and make evaluation faster. Right now all #Ceil terms are caused by #buf.

That's a great suggestion, thanks! I guess this will also eliminate all #Ceil terms from side condition and make evaluation faster. Right now all #Ceil terms are caused by #buf.


django_admin_log

First of all, I want to say thank you guys for this fantastic django admin theme. It's so helpful to manage an app service without developing a back office.
I am a developer from South Korea and have been using unfold for some app services as a back office.
I have found an issue that django log only shows what field admin changed like the screenshot.

Sorry for Korean anyway.
However, my colleague wants to see the previous value and changed value on the log as well. So I am extending a Unfold Model Admin class and modifying the code by adding features through inheritance.

With my code in pull request, When users change the value via admin panel, the object change history log contains the previous value and the changed value as you can see on the screenshot above.
It would be an honor if my code contributes to this wonderful project. Thanks

isn't it better to use django-simple-history for advanced object history? Unfold supports this app:
https://unfoldadmin.com/docs/integrations/django-simple-history/

Yes, you could use simple-history for tracking object change history. But, you should make more tables for that. By using my code you don't have to do any migrations for tracking all model records in detail as you can see the screentshot.


Apply resource constraints to kcp instance

This includes:

kcp container
virtual-workspaces container
3 etcd pods

The initial goal here is to protect the infrastructure running KCP from a memory leak in KCP.  This should give us some decent head room for now.
We've actually seen node instability (i.e. memory thresholds hit on nodes) on the OSD cluster running the KCP shared service, so this is a step to try and prevent that from happening.
Signed-off-by: Kyle Lape<EMAIL_ADDRESS>

@ncdc I've updated the resource limits based on a closer look at the metrics dashboard in our cluster.

Thanks, let's keep an eye on the metrics after this change is deployed to make sure we aren't hitting any issues.


Fix nullable string with minLength == maxLength result to VARCHAR

This property
    "kernelId" : {
      "type" : [ "string", "null" ],
      "minLength" : 12,
      "maxLength" : 12
    }

should result in CHAR(12) like those with just string type.

Sounds good


Type inference

Codecov Report

Merging #137 (70ef4d8) into main (3a0b613) will decrease coverage by 8.18%.
The diff coverage is 34.81%.

@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
- Coverage   90.07%   81.88%   -8.19%
==========================================
  Files          43       49       +6
  Lines        4321     4704     +383
==========================================
- Hits         3892     3852      -40
- Misses        429      852     +423

Impacted Files
Coverage Δ

optpy-generator/src/typed.rs
0.00% <0.00%> (ø)

optpy-runtime/src/lib.rs
100.00% <ø> (ø)

optpy-runtime/src/number.rs
67.18% <0.00%> (-6.96%)
:arrow_down:

optpy-runtime/src/typed_builtin.rs
0.00% <0.00%> (ø)

optpy-runtime/src/typed_value/boolean.rs
0.00% <0.00%> (ø)

optpy-runtime/src/typed_value/list.rs
0.00% <0.00%> (ø)

optpy-runtime/src/typed_value/number.rs
0.00% <0.00%> (ø)

optpy-runtime/src/typed_value/string.rs
0.00% <0.00%> (ø)

optpy-runtime/src/typed_value/traits.rs
0.00% <0.00%> (ø)

src/lib.rs
5.26% <0.00%> (-4.74%)
:arrow_down:

... and 3 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

I wasn't as fast as I expected: https://atcoder.jp/contests/past202107-open/submissions/37101808
Let me close it.


Create webhook example

We should try to create a webhook example and chekc how it works with form integrations.

here is an example without webhook on how to reach files after upload.
https://www.jotform.com/answers/1041937-how-can-i-retrieve-uploaded-files-through-api-or-webhook

We should think about, how to set up the webhook itself. There are two issues currently in my mind. Jotform might just send notifications to a webhook. Then, the previous example could be helpful on reaching the uploaded files. I checked it and it does not require jotformpro for downloading.
The webhook could work like the following:

a submission comes in, and forwards the user to the listener page?
webhooks goes to the listener with data on: submission ID and filename
listener initiates the download
the downloaded file is checked for compatibility with our guidelines
the listener generates a response and posts it
the webhook page refreshes and shows the genereated response.

We can use webhook.site for testing the webhook processes.


exclude &signer in view_function_arguments (#77)_39

Motivation
As script function can support more flexible parameters, we plan to enable passing signer reference instead of signer in script and script function to reduce redundant code. Ex: developer has to write script function taking signer and a internal version of script function to take &signer so that they can test with internal version of function without worrying about the signer value being "moved". This leads to lot of code duplication and force developer to understand unnecessary language details.
The move viewer also has the same assumption that should be relaxed. When API reads the onchain TXN data and rendered the data for better visualization. It needs to convert the txn args back from BCS to it original string representation. When it does this converion, It has the assumption that txn args don't include signer. But once we allow users to use &signer in entry function. Signer reference should be excluded from the txn args as well.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
CI/CD tests are covered.

/canary

:sunny: Canary successful

/land


Seem issue at floating lable with Datepicker control?

Seem issue at floating label with Datepicker control?
please check it.
the floating label don't go up when date has been selected.

@abhishekbhalani thank you for pointing out. We confirm this is a bug and we will fix it in the next product update. In the meantime, you can add inside the date picker "change" function an action that will remove the "is-empty" class from the form. Hope this gives you an idea about how to fix it. Let us know if that was working fine for you.
Best,
Alex

Hello @abhishekbhalani,
Thank you for your interest in working with our products, this issue is solved in the latest version (v2.0.4).
All the best,
Stefan


Add SSL and HTTP2 into IPv6 on listen.conf

I can only serve contents with IPv6 because I'm sitting behind CGN on IPv4. When enabling HTTP2 it still not serve contents with HTTP2 as there are missing arguments in the listen. But it still does the SSL encryption.


(FACT-1392) Restore logging after logging is setup

Prior change for FACT-1392 mistakenly moved logging to before logging
can occur, because it hasn't been initialized. Restore it to occur
after.

Oh right. I think I may have suggested moving the line about logging to before logging was setup Doh!


Arcade physics - body prev value is always equal to body.x/y

Version

Phaser Version: 3.16.2

Description
The Phaser.Physics.Arcade.Body.prev is always excatly the same as Phaser.Physics.Arcade.Body.x/y even if the Body is moving.

I was able to reproduce this. Could it be that these lines have to be inserted here to solve the problem?
else {
  this._reset = false;
}

@photonstorm Let me know, if I should make a PR.

Thank you for submitting this issue. We have fixed this and the fix has been pushed to the master branch. It will be part of the next release. If you get time to build and test it for yourself we would appreciate that.


Support directive-based admonitions and alerts for mdx and md sources

What problem will this feature address?
Several widely-used markdown extensions such as those in

https://docusaurus.io/docs/3.3.2/markdown-features/admonitions
https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#alerts
https://vitepress.dev/guide/markdown#github-flavored-alerts

use directives or other syntax to support alerts, admonitions, etc.
examples of directive-based admonition/alert syntax that may be used in md(x) taken from the docusaurus docs

:::note

Some **content** with _Markdown_ `syntax`. Check [this `api`](#).

:::

:::tip

Some **content** with _Markdown_ `syntax`. Check [this `api`](#).

:::

:::info

Some **content** with _Markdown_ `syntax`. Check [this `api`](#).

:::

:::warning

Some **content** with _Markdown_ `syntax`. Check [this `api`](#).

:::

:::danger

Some **content** with _Markdown_ `syntax`. Check [this `api`](#).

:::

Describe the solution you'd like
It would be helpful to support github-flavored markdown or mdx files that contain this style of alert or directive-based admonition syntax.
Describe alternatives you've considered
This is already supported via components in mdx for example
import { Callout } from "fumadocs-ui/components/callout";

<Callout type="info">
  Information
</Callout>

<Callout type="warn">
  Warning
</Callout>

...

however, I am not sure if there is a built-in approach to translate the directive syntax like that utilized by docusaurus to Callout components using a custom MDX -> JSX transform function with a content-collection source for mdx.
It should also be possible to use remark plugins

https://github.com/remarkjs/remark-directive
https://github.com/incentro-dc/remark-github-admonitions-to-directives

together with appropriate styles to support this with markdown if there is not already a simpler approach I am not aware of. This could be facilitated by a complementary content-collection MD -> HTML transform function for markdown

If it helps to understand where this was identified, I encountered this in exploring approaches that might help to use content-collections to translate the quarto qmd to mdx, md, or html compatible with fumadocs.

I personally avoid these syntax as it is not the standard of CommonMark and MDX, but JSX is. I think we can offer a rehype plugin for people migrating from other docs frameworks as JSX (using the component directly) is more flexible and friendly.
In MDX, intellisense works for directly imported components which makes it significantly easier to use.

I agree. For my use case it's probably better to just write a pandoc lua filter like this one for docusaurus that specifically targets translation to fumadocs-compatible Callout components where the source markdown has directive syntax. I will close this as I think that will likely be a better solution and shouldn't require any change to fumadocs. Many thanks!


Fix duplicate Info.plist when installing from pod

We add a Info.plist to support Carthage, and cocoapods will generate it, so there is a conflict.


New package: GymSpaces v0.1.0

Registering package: GymSpaces
Repository: https://github.com/kraftpunk97/GymSpaces.jl
Created by: @kraftpunk97
Version: v0.1.0
Commit: 7df526092be91d422c18e211c63736a69092d4bf
Reviewed by: @kraftpunk97
Reference: https://github.com/kraftpunk97/GymSpaces.jl/commit/7df526092be91d422c18e211c63736a69092d4bf#commitcomment-34865109

This release has been tagged as v0.1.0, while the one in #2783 was tagged v1.0. I don't know if the difference means a lot, but I felt that v0.1.0 is a better tag description than v1.0, which is why I ask that if this be PR be considered for merging.

Everything's good on my end. Please proceed :)


Avoid keeping private key and password in the cluster secret

This is related to the open bug: https://github.com/sigstore/helm-charts/issues/24
As a workaround for secretKeyRef not resolving, one has to provide following parameters:
--set cosign.cosignKey=‘base64 encode’ --set cosign.cosignPassword='base64 encode' --set cosign.cosignPub='base64 encode'
Even if the secretkeyRef works, I do not want to keep my private key and password in the cluster.
So why in this chart cosignKey and cosignPassword are required. Currently this command complain if all 3 parameters are not provided.
$k get secrets cosigned-cosign-key -o yaml
 data:
  cosign.key: <>
  cosign.password: <>
  cosign.pub: <>

Ideally shouldn't the webhook only look for public key to validate the signed images?

@adubey8 I believe we missed this issue, but it has been solved. Even though you don't need to store the private key to validate a signed image.


fuzzgen: Statistics framework

👋 Hey,
This PR Introduces a statistics module for fuzzgen. This allows us to measure stuff and get some info about what is going on.
I don't want to commit this in its current format since it has some issues, see the comments below.
Here's the output after 50000 inputs:
== FuzzGen Statistics  ====================
Total Inputs: 50000
Valid Inputs: 29130 (58.3%)
Total Runs: 42358
Successful Runs: 17564 (41.5% of Total Runs)
Timed out Runs: 12445 (29.4% of Total Runs)
Traps:
        user code: heap_oob: 0 (0.0% of Total Runs)
        user code: icall_null: 0 (0.0% of Total Runs)
        user code: int_ovf: 0 (0.0% of Total Runs)
        user code: int_divz: 12349 (29.2% of Total Runs)
        user debug: 0 (0.0% of Total Runs)
        user code: heap_misaligned: 0 (0.0% of Total Runs)
        user code: bad_sig: 0 (0.0% of Total Runs)
        user code: bad_toint: 0 (0.0% of Total Runs)
        user code: interrupt: 0 (0.0% of Total Runs)
        user code: unreachable: 0 (0.0% of Total Runs)
        user code: table_oob: 0 (0.0% of Total Runs)
        resumable: 0 (0.0% of Total Runs)
        user code: stk_ovf: 0 (0.0% of Total Runs)

I've made some changes since this was introduced:

We now filter out traps that were never triggered, and we now sort based on the count of traps.
As mentioned above, we now print based on "Valid Inputs" instead of "Total Inputs". Its not ideal but hopefully a temporary solution.

Here's the example output:
#46795  NEW    cov: 31167 ft: 170205 corp: 5611/1461Kb lim: 1024 exec/s: 74 rss: 631Mb L: 804/1024 MS: 1 InsertRepeatedBytes-
== FuzzGen Statistics  ====================
Valid Inputs: 20000
Total Runs: 199404
Successful Runs: 197351 (99.0% of Total Runs)
Timed out Runs: 189 (0.1% of Total Runs)
Traps:
        user code: int_divz: 1864 (0.9% of Total Runs)
#46979  NEW    cov: 31167 ft: 170206 corp: 5612/1461Kb lim: 1024 exec/s: 74 rss: 631Mb L: 294/1024 MS: 4 ChangeBinInt-EraseBytes-CopyPart-PersAutoDict- DE: "\xff\xff\xff\xff\xff\xff\xff\xff"-


Add notifications parameter to EncodingSettings

The Zencoder API allows for notifications for the completion of the
entire job: https://app.zencoder.com/docs/api/encoding/notifications/notifications

As I no longer have access to this repository and this one is abandoned, I've created a fork here: https://github.com/go-zencoder/zencoder


[BUG] Namespace gets overwritten

I think the problem is related to this change https://github.com/kubevela/kubevela/pull/6228
We have a Velero backup component and set the namespace fixed in the cue template of the component.
#backupMetadata: {
		name:      "\(context.namespace)--\(context.name)"
		namespace: "velero"
	}

With kubevela 1.9.3 this still works, but after upgrade to 1.9.5, the namespace gets overwritten by the default namespace.

It's reverted in https://github.com/kubevela/kubevela/pull/6247 , does it work?

Thanks @wonderflow, in 1.9.6 it works again.


Inconsistent RegExp test results

Hi Svaarala,
I have this code to validate a guid enclosed with braces:
var reGuid = /^\{[0-9A-F]{8}\-[0-9A-F]{4}\-[0-9A-F]{4}\-[0-9A-F]{4}\-[0-9A-F]{12}\}$/g;

var m1 = reGuid.test("{A6BFBB23-4426-4CFB-8D2F-5A642566BF94}");
var m2 = reGuid.test("{A6BFBB23-4426-4CFB-8D2F-5A642566BF94}");
var m3 = reGuid.test("{A6BFBB23-4426-4CFB-8D2F-5A642566BF94}");
var m4 = reGuid.test("{A6BFBB23-4426-4CFB-8D2F-5A642566BF94}");

The expected result is true for all four variables but the output is:
m1=true
m2=false
m3=true
m4=false

Seems the regex state after a test is wrong and cannot restart but a test that fails, resets the internal state correctly.
Regards,
Mauro.

The same happens with Node.js:
> var reGuid = /^\{[0-9A-F]{8}\-[0-9A-F]{4}\-[0-9A-F]{4}\-[0-9A-F]{4}\-[0-9A-F]{12}\}$/g;
undefined
>
> var m1 = reGuid.test("{A6BFBB23-4426-4CFB-8D2F-5A642566BF94}");
undefined
> var m2 = reGuid.test("{A6BFBB23-4426-4CFB-8D2F-5A642566BF94}");
undefined
> var m3 = reGuid.test("{A6BFBB23-4426-4CFB-8D2F-5A642566BF94}");
undefined
> var m4 = reGuid.test("{A6BFBB23-4426-4CFB-8D2F-5A642566BF94}");
undefined
> m1
true
> m2
false
> m3
true
> m4
false

The cause is the global flag (/g) of the RegExp. It causes the RegExp to match once, then attempt the second match from end of input (which fails) at which point the RegExp resets back to start of input. For example:
var re = /./g;
var input = 'abc';

for (var i = 0; i < 8; i++) {
    console.log(i, re.lastIndex, re.test(input));
}

This will print the following with both Duktape and Node.js:
0 0 true
1 1 true
2 2 true
3 3 false
4 0 true
5 1 true
6 2 true
7 3 false

Hi,
Didn't know it was an expected behavior and good hint about Node.js. Next time I found something suspicious, I'll double check it.
Kind regards,
Mauro.

I find the RegExp API a bit weird to work with, but I think the idea with the global match is that you can do e.g.:
var re = /./g;

function dump(input) {
    var m;
    while (m = re.exec(input)) {
        console.log('match:', m[0]);
    }
    console.log('done');
}

dump('abc');
dump('foo');

This prints:
match: a
match: b
match: c
done
match: f
match: o
match: o
done

Without the final non-matching outcome it would be difficult to know when all the matches for a certain input had been matched.

I didn't realize that's what the global flag was for.  I thought it just meant to match all occurrences (rather than stopping after the first), didn't know it was also "resumable".

Just removed the global flag because not needed and works fine.

@fatcerberus Related, the .lastIndex property of the RegExp instance tracks the offset where to resume from. It has pretty weird semantics if you resume matching a different string though; you can also set it manually if you don't want to resume matching a string to completion.


Performance tuning

There can be performance issue using this AnimatedExpandableListView when the child view getting more complex. This branch gives a suggestion for how to using AnimatedExpandableListView efficiently. That is, using LRU cache to caching view created during animation, so that saving CPU times for creating child views. This can be done in their view adapter.
More analysis and data are in the READ.md

Does the LRU cache work? What update is needed?


Adjust sensor size and sensor name positions

The sensor symbols were too large and were plotted partly over the sensor names, so I decreased the symbol size and shifted the names slightly to the right (see images for before/after). It would be good if someone else tested this on a different platform.
Before:

After:

Quick question, is there a way to plot sensor positions from montages without having to load actual data? There is viz.plot_montage, but this is only 3D and not 2D...

LGTM. One way is to just create the info and then pass that to mne.viz.plot_sensors.

Thanks @jaeilepp, there is still considerable overplotting for montages with many channels (e.g. biosemi256). An option would be to plot the symbols with a certain level of transparency. Another option would be to only plot channel names instead of symbols.
Regarding plotting montages, should there be a more obvious way to do that, e.g. a function just to visualize all channels within a montage? Right now, this involves several steps and calling the private function mne.channels.montage._set_montage.

Codecov Report

Merging #4273 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4273      +/-   ##
==========================================
- Coverage    86.2%   86.14%   -0.07%
==========================================
  Files         346      346
  Lines       64643    64644       +1
  Branches     9907     9907
==========================================
- Hits        55728    55687      -41
- Misses       6198     6226      +28
- Partials     2717     2731      +14

LGTM if CIs are happy. I restarted the failed builds
we can make another PR for the montage plot.

Thanks @cbrnr


Fix a regression in webhook-based autoscaler

The regression resulted in the webhook-based autoscaler being unable to find visible runner groups and therefore unable to scale up and down the target RunnerDeployment/RunnerSet at all when the webhook-based autoscaler was provided GitHub API credentials to enable the runner groups support. This fixes that.
The regression was introduced via #1578 which is not released yet. Users of existing ARC releases are therefore not affected.

Thansk for your review!

Has this been released?

Thanks! It was a mistake on my end with the scaling settings, before (worked in prior version):
scaleUpTriggers:
    - githubEvent: {}

Changed to:
  scaleUpTriggers:
    - githubEvent:
        workflowJob: {}


Bad design in RTL direction

Need more fixing design on RTL direction

We have a ticket #78 for this.


Introduce topicwriter Writer.Flush() method

Introduce topicwriter Writer.Flush() method to wait till last written message get acknoledged.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?
Currently there is no way to make sure all currently written messages get acked (in async mode) when closing the Writer.
Issue Number: #851
What is the new behavior?
Add new Flush method to wait until last written message get acked.
Other information

@zveznicht
Hello, sorry for a lot of time before answer.
I have been see the PR and will check it in few days.

@zveznicht  Hello.
Thanks for the work!
A mock generater was updated few time ago.
Can you merge master into the branch and re-generate mock files with go.uber.org/mock/mockgen@892b665398ecece7c7a900d2a2f2fa3dac07e4c4 ?

Codecov Report
Attention: Patch coverage is 66.66667% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 41.05%. Comparing base (b7a9b51) to head (bdec180).
Report is 61 commits behind head on master.

Files
Patch %
Lines

internal/topic/topicwriterinternal/writer.go
0.00%
2 Missing :warning:

topic/topicwriter/topicwriter.go
0.00%
2 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #864      +/-   ##
==========================================
+ Coverage   40.80%   41.05%   +0.25%
==========================================
  Files         309      310       +1
  Lines       32747    32971     +224
==========================================
+ Hits        13361    13536     +175
- Misses      18959    18999      +40
- Partials      427      436       +9

Flag
Coverage Δ

go-1.21.x
?

go-1.22.x
41.05% <66.66%> (+0.25%)
:arrow_up:

macOS
?

ubuntu
?

unit
41.05% <66.66%> (+0.25%)
:arrow_up:

windows
41.05% <66.66%> (+0.25%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Release 2.8 Testing

Release 2.8 is about to go OUT 🚀 but.... it does require some testing!
Final checklist:

[ ]  make pre-release
[ ] Push update to sample streams from all connectors
[ ]  carry out testing WITH the pre-release

[ ]  multiple releases of host apps
[ ]  saving & restoring streams
[ ]  sending & receiving (interop)
[ ]  empty states (eg when there are no accounts or streams etc)
[ ]  features added recently

[ ]  green light for release
[ ]  merge 2.8 in main
[ ]  make stable release
[ ]  make nugets release
[ ]  party 🥳

Rhino + Grasshopper:
Win:

[ ] Installer works
[ ] Basic functionality

[ ] Connector can send/receive from itself
[ ] Connector can send/receive from other connectors
[ ] Any new settings/ui elements work as expected

[ ] Updated test streams
[ ] FILL IN WITH ANY OTHER REQUIRED CHECKS
[ ]
Mac:
[ ] Installer works
[ ] Basic functionality

[ ] Connector can send/receive from itself
[ ] Connector can send/receive from other connectors
[ ] Any new settings/ui elements work as expected

[ ] Updated test streams
[ ] FILL IN WITH ANY OTHER REQUIRED CHECKS

Revit @connorivy

[ ] Installer works
[ ] Basic functionality

[ ] Connector can send/receive from itself
[ ] Connector can send/receive from other connectors
[ ] Any new settings/ui elements work as expected

[ ] Updated test streams
[ ] FILL IN WITH ANY OTHER REQUIRED CHECKS

AutoCAD/Civil3D
@clairekuang

[ ] Installer works
[ ] Basic functionality

[ ] Connector can send/receive from itself
[ ] Connector can send/receive from other connectors
[ ] Any new settings/ui elements work as expected

[ ] Updated test streams
[ ] FILL IN WITH ANY OTHER REQUIRED CHECKS/ISSUES YOU ENCOUNTER

Tekla Structures
@Reynold-Chan

[ ] Installer works
[ ] Basic functionality

[ ] Connector can send/receive from itself
[ ] Connector can send/receive from other connectors
[ ] Any new settings/ui elements work as expected

[ ] Updated test streams
[ ] FILL IN WITH ANY OTHER REQUIRED CHECKS/ISSUES YOU ENCOUNTER

CSI, ETABS...
@Reynold-Chan

[ ] Installer works
[ ] Basic functionality

[ ] Connector can send/receive from itself
[ ] Connector can send/receive from other connectors
[ ] Any new settings/ui elements work as expected

[ ] Updated test streams
[ ] FILL IN WITH ANY OTHER REQUIRED CHECKS/ISSUES YOU ENCOUNTER

UNITY
@JR-Morgan

[ ] Installer works
[ ] Basic functionality

[ ] Connector can send/receive from itself
[ ] Connector can send/receive from other connectors
[ ] Any new settings/ui elements work as expected

[ ] Updated test streams
[ ] FILL IN WITH ANY OTHER REQUIRED CHECKS/ISSUES YOU ENCOUNTER


encoder_sample has segment fault on A100.

Close this bug because it is inactivated. Feel free to re-open this issue if you still have any problem.


A @note followed by a @see formats incorrectly

Example, in a class javadoc
    ...

    @note A timed stream object must not be moved or destroyed while there
    are oustanding asynchronous operations associated with it. Objects of this
    type meet the requirements of @b AsyncReadStream and @b AsyncWriteStream.

    @see http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p1322r0.html
*/

I added a test case for this, and it looks fine.


calico with k8s container start fail

I want to deploy calico in k8s, But containers of calico can not startup successfully with this err:
kubectl log calico-kube-controllers-85cf9c8b79-fb9jr -n kube-system
log is DEPRECATED and will be removed in a future version. Use logs instead.
2018-12-07 06:23:46.318 [INFO][1] main.go 75: Loaded configuration from environment config=&config.Config{LogLevel:"info", ReconcilerPeriod:"5m", CompactionPeriod:"10m", EnabledControllers:"policy,namespace,serviceaccount,workloadendpoint,node", WorkloadEndpointWorkers:1, ProfileWorkers:1, PolicyWorkers:1, NodeWorkers:1, Kubeconfig:"", HealthEnabled:true}
2018-12-07 06:23:46.318 [FATAL][1] main.go 87: Failed to start error=failed to build Calico client: could not initialize etcdv3 client: open /calico-secrets/etcd-cert/etcd.pem: no such file or directory
Operating steps
I start a TLS enabled etcd service with ca.pem\etcd.pem\etcd-key.pem which are generated by cassl and
start a k8s cluster successfully.
[root@k8s-m common-package]# netstat -plnt | grep etcd
tcp        0      0 <IP_ADDRESS>:2379        <IP_ADDRESS>:*               LISTEN      2979/etcd
tcp        0      0 <IP_ADDRESS>:2379          <IP_ADDRESS>:*               LISTEN      2979/etcd
tcp        0      0 <IP_ADDRESS>:2380        <IP_ADDRESS>:*               LISTEN      2979/etcd
then deploy Calico following this guide https://docs.projectcalico.org/v3.3/getting-started/kubernetes/installation/calico "Installing with the etcd datastore"

Get calico.yaml by run "curl
https://docs.projectcalico.org/v3.3/getting-started/kubernetes/installation/hosted/calico.yaml
-O"

2.Modify these configurations in calico.yaml
etcd_endpoints: "https://<IP_ADDRESS>:2379"
etcd_ca: "/calico-secrets/etcd-ca/ca.pem"
etcd_cert: "/calico-secrets/etcd-cert/etcd.pem"
etcd_key: "/calico-secrets/etcd-key/etcd-key.pem"
3.Create paths "/calico-secrets/etcd-ca/" "/calico-secrets/etcd-cert/" "/calico-secrets/etcd-key/" in both k8s master machine and node machine, and copy these ca.pem\etcd.pem\etcd-key.pem three files from etcd config file.
4.run "kubectl apply -f
https://docs.projectcalico.org/v3.3/getting-started/kubernetes/installation/rbac.yaml"
5.kubectl apply -f calico.yaml
Environment

Calico version 3.3
K8s version 1.12.2
Operating System and version:
centos7
Linux k8s-m 3.10.0-862.14.4.el7.x86_64 #1 SMP Wed Sep 26 15:12:11 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Also try modify these configuration as
etcd_ca: "/calico-secrets/etcd-ca"
etcd_cert: "/calico-secrets/etcd-cert"
etcd_key: "/calico-secrets/etcd-key"
but still the same issue.

3.Create paths "/calico-secrets/etcd-ca/" "/calico-secrets/etcd-cert/" "/calico-secrets/etcd-key/" in both k8s master machine and node machine, and copy these ca.pem\etcd.pem\etcd-key.pem three files from etcd config file.

I think this isn't quite right - the manifest expects those to be Kubernetes secrets, not copied onto the host machine.

How to resolve?


Disable inlay hints for tests (or allow conditional overrides)

Suggestion
Originally opened at https://github.com/microsoft/vscode/issues/132304 - they asked me to file upstream.
🔍 Search Terms
inlay hints
✅ Viability Checklist

My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion
I ❤ the new inlay hints feature. One area where it's a bit noisy is in tests, though. Even with the literals setting, it shows up for Jest (and similar) test blocks (describe, it, test). Please consider adding a way to override this for certain cases. Thank you!

📃 Motivating Example
As a developer, I want to maximize readability while minimizing noise.
💻 Use Cases

VSCode

https://github.com/microsoft/vscode/issues/128162
is a feature that allows you peek inlay hints after pressed some button.

/cc @DanielRosenwasser, was trying to find something to link this feedback to as we think about fine tuning the inlay hints experience, but couldn’t find a parent issue

Related: #45389

Would it make sense to override this in the function declaration on a per-parameter basis?
function describe(/* @ts-no-inlay */ name: string, /* @ts-no-inlay */ callback: () => (void | Promise<void>)) { ... }

@nmain Then it wouldn't be the users choice anymore (in case of libraries).


[FEATURE] Let's encrypt integration

Is your feature request related to a problem? Please describe.
It would be great if you could use letsencrypt directly with a flag goshs -s -sl <domain.name> for example to enroll a valid certificate.
Describe the solution you'd like
Instead of having to enroll with certbot it would be great to enroll from goshs directly.
Additional context
https://youtu.be/DngypsuOAXE?si=_qYtXjssPrC6T8M7&t=444

Commit c8e2a5cc627df1d6ecd2d3964c24f83a143d50c9 implements this. Will be merged into main when the other issue #59 is done.


[HOLD for payment 2024-12-11] [HOLD for payment 2024-12-07] [$250] Create SMS delivery failure sign in flow in homepage

We need to replicate the flow that will exist soon in expensify.com when trying to sign in with a blacklisted phone number (see steps in screenshots).
This is triggered when the user tries to sign in with a phone number (account must already be created with said number), but not validated.
When calling BeginSignIn, if the response includes hasSMSDeliveryFailure: true, then it should display the following message, and use the message from the response. In this case, the "got it" button just send the user back to the beginning of the sign in flow:

If hasSMSDeliveryFailure is set to false, just allow the user to continue the sign in flow (message is not included in this case):

Once this is done I'll do the integrated testing with the BE.
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021853994676042691894
Upwork Job ID:<PHONE_NUMBER>042691894
Last Price Increase: 2024-11-06
Automatic offers:

nyomanjyotisa | Contributor | 104794580

Issue OwnerCurrent Issue Owner: @MitchExpensify

Proposal
Please re-state the problem that we are trying to solve in this issue.
Create SMS delivery failure sign in flow in homepage
What is the root cause of that problem?
This is a new feature request
What changes do you think we should make in order to solve the problem?

We need to create an SMSDeliveryModal component like this design in the description of the OP. The initial is something like this. We can refactor the style in the PR phrase.

When we click the Validate button, we will call ResetPhoneNumberFailure API.

If success is false, we can change the content in SMSDeliveryModal to this case and the message is the message response in ResetPhoneNumberFailure API.

If success is true, change the content in SMSDeliveryModal to this case, and when we click on Send button we will call resendValidateCode API and close the SMSDeliveryModal modal

To control the content in SMSDeliveryModal, we can use the data that is returned from ResetPhoneNumberFailure and a state to know ResetPhoneNumberFailure is called or not.

Display the first screen if the ResetPhoneNumberFailure is not called.
Display the fail screen if success is false
Display the success screen if success is true

Add this modal to the SignInPage here. In the SignInPage, we should create a new state shouldShowSMSDelivery with the initial value true. Then, when we click on the Close button, we will set it to false.

<SMSDeliveryModal
    isVisible={shouldShowSMSDelivery && !!account?.hasSMSDeliveryFailure}
    onClose={() => {
        setShouldShowSMSDelivery(false);
    }}
    login={userLogin}
/>

https://github.com/Expensify/App/blob/7bd88ac86ef786ac6d8c200f26331a02e9143eb6/src/pages/signin/SignInPage.tsx#L309
What alternative solutions did you explore? (Optional)

I don't think we need to show a modal on NewDot, I think something more like @nyomanjyotisa is showing above makes the most sense.

Any updates @nyomanjyotisa ?

No, as I mentioned on the description, this needs to be tested internally with the BE once it's ready. The work here is to have it ready for testing, you can hardcode values to show that the logic works in a video.

@nyomanjyotisa question: how advanced are you with this PR? Because there's been a change of logic and displays that we've decided to implement recently. It should be less work actually, but I'm not sure how much you've done already.
@mallenexpensify how do we handle situations like this?

Great, I'll check out that branch and take it from here! Thank you!
@mallenexpensify @shawnborton Not sure how to handle this situation, I think Nyoman's job here is done, but I'll need to continue making PR changes based on some new decisions we made in for the BE. Can we consider this complete?

@mountiny @mallenexpensify @luacmartins need some advice here... We need to make some changes to the original issue's description, but Nyoman already completed the PR (for the original description).
Should this be considered done and we should merge and I work on a new PR (since I have to do the QA internally)?
Should Nyoman work on the new changes instead, and we should increase payment?
Should I work on top of Nyoman's PR somehow?

I agree with @parasharrajat. Let's see what the changes are first. I'd say if they are small, we should just update the current PR to reflect the changes. If they are larger (and the current PR won't introduce unwanted behavior), we can address them as a follow up in a new PR.

Sounds good. Need to get confirmation from one more potential change and I'll report back here with the final decision! Thanks guys!

Yeah, lets just see the scope of the change but we can always just ask them to implement it and we can consider increasing the reward

Ok @nyomanjyotisa, I updated the description with the changes. To clarify, we are now making the flow shorter, by removing the previous Send screen if hasSMSDeliveryFailure returns false, and just showing the SMS failure time message if it's true. Let me know if you have any questions!
Please add a video simulating the error screen, and one completing the sign in flow into the app. I'll be back to review on Tuesday if it's ready, thank you!

@luacmartins @mountiny I think it's a pretty small change, but I'll defer to your judgement on how we should treat this change in the task.

It seems like these are small changes, so I'd just incorporate them in the existing PR.

Not overdue, Melvin. Actively being worked on

Sounds good @luacmartins, are you good to proceed @nyomanjyotisa ?

@carlosmiceli yes, lets just ask @nyomanjyotisa to incorporate this change especially if its small

@nyomanjyotisa any updates on this? To clarify, this needs to have daily progress/updates, but your last message was a week ago.

Almost! This is the copy:
We've been unable to deliver SMS messages to ${login}, so we've suspended it for 24 hours. {message}

No, it has to be internally tested once this is merged. I'll take over that part, don't worry :)

I think this issue is going to need another PR...
Testing with expensify.com, this is what should be displayed if SMS status is failure:

But same response structure in ND doesn't work and it actually resends the validation code. So we also need to fix it so we don't call Auth twice:

cc @nyomanjyotisa @parasharrajat can we put up a PR fix? Thanks!

Ah, that's a good catch! Yeah, let's do it lowercase instead, and can you send a video example of it working (hardcoding the api response)? Thank you!

Why does it show the validate code screen for a few moments instead of a loading animation?

Got it, that's great then! Thanks for the explanation :)

@nyomanjyotisa working almost great! can we get up a PR to fix this unnecessary ResendValidateCode auth call? It shouldn't be sent if it didn't pass the SMS check.

Ohhhh, I see now... Thanks, I'll take care of it!

Not overdue Melv.

Payment summary:

$250 @parasharrajat requires payment through NewDot Manual Requests
$250  @nyomanjyotisa requires payment automatic offer (Contributor)

BugZero Checklist:

[ ] [Contributor] Classify the bug:

Bug classification

Source of bug:

[ ] 1a. Result of the original design (eg. a case wasn't considered)
[ ] 1b. Mistake during implementation
[ ] 1c. Backend bug
[ ] 1z. Other:

Where bug was reported:

[ ] 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
[ ] 2b. Reported on staging (eg. found during regression or PR testing)
[ ] 2d. Reported on a PR
[ ] 2z. Other:

Who reported the bug:

[ ] 3a. Expensify user
[ ] 3b. Expensify employee
[ ] 3c. Contributor
[ ] 3d. QA
[ ] 3z. Other:

[ ] [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:

[ ] [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:

[ ] [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

[ ] [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:

Regression Test Proposal
Precondition:

Test:

Do we agree 👍 or 👎

Please complete the BZ steps above @parasharrajat , thanks

Ah yes. Ok all that is waiting is @parasharrajat's payment via NewDot, closing


[NBug] Could not load file or assembly Microsoft.VisualStudio.Threading

Current behaviour
When I click "Plugin \ AzureDevOps" This error appears.
Also same happens every time I click "Commit" button, but the message there could be ignored and after that I can see commit dialog.
Expected behaviour
no error message box
Steps to reproduce
Plugin \ AzureDevOps
Error Details
System.IO.FileNotFoundException: Could not load file or assembly 'Microsoft.VisualStudio.Threading, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The system cannot find the file specified.
File name: 'Microsoft.VisualStudio.Threading, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'
   at GitExtensions.AzureDevOpsCommitMessage.Plugin.Execute(GitUIEventArgs args)
   at GitUI.CommandsDialogs.FormBrowse.<>c__DisplayClass63_0.<RegisterPlugins>b__2(Object <p0>, EventArgs <p1>)
   at System.Windows.Forms.ToolStripItem.RaiseEvent(Object key, EventArgs e)
   at System.Windows.Forms.ToolStripMenuItem.OnClick(EventArgs e)
   at System.Windows.Forms.ToolStripItem.HandleClick(EventArgs e)
   at System.Windows.Forms.ToolStripItem.HandleMouseUp(MouseEventArgs e)
   at System.Windows.Forms.ToolStripItem.FireEventInteractive(EventArgs e, ToolStripItemEventType met)
   at System.Windows.Forms.ToolStripItem.FireEvent(EventArgs e, ToolStripItemEventType met)
   at System.Windows.Forms.ToolStrip.OnMouseUp(MouseEventArgs mea)
   at System.Windows.Forms.ToolStripDropDown.OnMouseUp(MouseEventArgs mea)
   at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.ScrollableControl.WndProc(Message& m)
   at System.Windows.Forms.ToolStrip.WndProc(Message& m)
   at System.Windows.Forms.ToolStripDropDown.WndProc(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

WRN: Assembly binding logging is turned OFF.
To enable assembly bind failure logging, set the registry value [HKLM\Software\Microsoft\Fusion!EnableLog] (DWORD) to 1.
Note: There is some performance penalty associated with assembly bind failure logging.
To turn this feature off, remove the registry value [HKLM\Software\Microsoft\Fusion!EnableLog].

Additional information
this always happens when trying to commit, also when open plugin -> AzureDevOps
Environment

Git Extensions <IP_ADDRESS>99
Build d4b0f48bbf3e39a71f5d7ff5231be5678d4aa0f1
Git 2.27.0.windows.1
Microsoft Windows NT 10.0.19041.0
.NET Framework 4.8.4220.0
DPI 96dpi (no scaling)

@pmiossec looks like the plugin is using an older version of Microsoft.VisualStudio.Threading, than is used in the app.
I think this can be solved via a binding redirect to the current version in the plugin's config file.

@pmiossec looks like the plugin is using an older version of Microsoft.VisualStudio.Threading, than is used in the app.

No, I think that @gusarov needs to update the plugin to version 1.1.0
I'm using it every days so it is working well...
And I also just checked and v1.1.0 is trying to load version 16.5.132.

I think this can be solved via a binding redirect to the current version in the plugin's config file.

No. If I remember well, that doesn't work. The binding redirect need to be in the config file of the application.
I already warned about this problem: https://github.com/gitextensions/gitextensions/issues/8003
That's why I was asking as a solution to add the binding redirect for all the assemblies of GitExtensions to reduce failing of assembly loading to only really breaking changes and not just version number changes!
Perhaps I need to answer to your last answer because I don't think it works like you described...

 IIRC there is something in the .NET runtime backlog that would help in situations like 8003 describes.

Closing because it seems that the user are not using the last version of the plugin as it seems....


Add PS App icon

I did the changes. Is this enough?

I’m afraid the icon continues to be incompliant with the guidelines, as it is not composed of lines 12 pixels in width. Generally, the icons in Lawnicons can be represented as outlined paths with no fills:


Github Workflow : Notify Contributors When Pull Requests Are Merged

Notify Contributors When Pull Requests Are Merged
Issue Description
Background:
Currently, when a pull request (PR) is merged, contributors are not notified about the status of their contributions. It’s important to acknowledge their efforts and keep them informed to foster a positive and collaborative environment.
Benefits:

Enhances contributor engagement.
Acknowledges their work, which can encourage future contributions.
Improves communication within the project.

Hey @TejasNasre   Please assign me this issue with "level3"

Hey @TejasNasre Please assign me this issue with "level3"

That's not possible to assign you this issue with level 3

Okay then assign this with level2

I will assign you but at level 1 and you have to solve both issues at single PR and explain more about auto labels

If you want me to close both issue in single or assign me level3

It's not possible it's very easy issue

Atleast assign level2 ?


Too many arguments for function: strcharpart

Nothing in my config was changed. Just stopped working with this error this morning when using keybinding for leap and flit
E5108: Error executing lua: Vim:E118: Too many arguments for function: strcharpart
stack traceback:
        [C]: in function 'strcharpart'
        .../.local/share/nvim/lazy/leap.nvim/lua/leap/highlight.lua:66: in function 'highlight-cursor'
        ...ichel/.local/share/nvim/lazy/leap.nvim/lua/leap/main.lua:730: in function 'get_first_pattern_input'
        ...ichel/.local/share/nvim/lazy/leap.nvim/lua/leap/main.lua:987: in function 'leap'
        ...mmichel/.local/share/nvim/lazy/leap.nvim/plugin/init.lua:25: in function <...mmichel/.local/share/nvim/lazy/leap.nvim/plugin/init.lua:24>

plugin works fine when I revert to the commit before 66f055ab20b4678a2b9d13c4de791355917ccbd3

Update Neovim if you're on nightly. #171, #172.


[FEAT]: add eslint and prettier config

What was done?

added eslint
configured eslint for ts
add prettier
configured prettier

Boa

Corrigir conflitos.


Viewer

Added a Dockerized Theia viewer and instructions for building and running it through docker-compose.

closing PR in favor of refactored viewer implementation


remove positional args from Batch.add

OpenAI endpoint methods don't accept positional args, this can be safely removed to avoid confusion

lgtm


Workspace support

BREAKING CHANGE:
This changes the default behavior of sync-monorepo-packages to first inspect the workspaces field of package.json to find target packages.

Lerna / lerna.json is no longer required for automatic discovery of packages
Any packages found in the packages field of lerna.json will be merged with the result from the workspaces field of package.json.

If you are currently using Lerna v5+ (or whatever version supports useWorkspaces), you may move the packages field from lerna.json to package.json and append "useWorkspaces": true to lerna.json.
Closes #119

Current dependencies on/for this PR:

main

PR #133   👈

This comment was auto-generated by Graphite.


Auth sidecar proxy for head node

What is the expected behavior?
In order to provide authentication mechanism to work with ray cluster we need to figure out a way to proxy ray head node with keycloak auth.
Minimal requirement at this moment is protect 8265 port which is ray dashboard (ray cluster dashboard and job scheduler api).
KubeRay helm deployment of ray clusters allows addition of sidecar containers to head nodes.
https://github.com/ray-project/kuberay-helm/blob/main/helm-chart/ray-cluster/values.yaml#L87
Idea is deploy sidecar container on the same pod with ray head which will be acting as authentication proxy to KeyCloak deployment.
Requirements:

proxy docker image to authenticate via KeyCloak
auth should be happening though headers (JWT, Bearer...)
(Optional) deployment should support initial user creation
(Optional) add keycloak and sidecar to docker-compose

Epic https://github.com/Qiskit-Extensions/quantum-serverless/issues/105

I'm looking at if this can be used as the base https://github.com/openshift/oauth-proxy/blob/master/contrib/sidecar.yaml

kuberay/raycluster-cliuster helm chart has
          {{- if .Values.head.sidecarContainers }}
          {{- toYaml .Values.head.sidecarContainers | nindent 10 }}
          {{- end }}

I try to utilize it to inject the proxy container into the head node.

The configuration of the Oauth-proxy is different for each environment.  I'll focus on the local install with the ingress enable first.

I'm setting up this oath-proxy
Here is an example of Oath-proxy with the node ported ray service.
        - args:
          - --email-domain=*
          - --cookie-secret=SECRET0123456789
          - --provider=keycloak-oidc
          - --client-id=rayclient
          - --client-secret=5vJ9W9uLMmoU8v13ZrrZMdjSOTKbeZXV
          - --redirect-url=http://localhost:32031/
          - --oidc-issuer-url=http://quantumserverless-keycloak/realms/testtest
          image: quay.io/oauth2-proxy/oauth2-proxy:v7.3.0
          imagePullPolicy: IfNotPresent
          name: oauth-proxy


8888

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:
OS Version:

Steps to Reproduce:

This issue is effectively empty - please close as "not reproducible" (or add actual content).


Fix 0-bootstrap iam_by_principals not taking into account all principals

When I provide iam_by_principals to bootstrap stage, not all entries are taken into account, as only principals listed local.iam_principals were used. For example, if using this to grant permissions to non-FAST defined groups, this would not work.

Checklist

I applicable, I acknowledge that I have:

[x] Read the contributing guide
[x] Ran terraform fmt on all modified files
[ ] Regenerated the relevant README.md files using tools/tfdoc.py
[ ] Made sure all relevant tests pass

Can you provide repro, and of course this should only consider normal apply once a bootstrap SA has been created.

local.iam_principals contains principals defined in var.groups as keys. Hence the code is it is now, works only for those groups, i.e.:
groups = {
  gcp-billing-admins      =<EMAIL_ADDRESS>  gcp-devops              =<EMAIL_ADDRESS>  gcp-network-admins      =<EMAIL_ADDRESS>  gcp-organization-admins =<EMAIL_ADDRESS>  gcp-security-admins     =<EMAIL_ADDRESS>  gcp-support             =<EMAIL_ADDRESS>}
iam_by_principals = {
<EMAIL_ADDRESS>= [ "roles/owner" ]
}

Works, but this won't work:
groups = {
  gcp-billing-admins      =<EMAIL_ADDRESS>  gcp-devops              =<EMAIL_ADDRESS>  gcp-network-admins      =<EMAIL_ADDRESS>  gcp-organization-admins =<EMAIL_ADDRESS>  gcp-security-admins     =<EMAIL_ADDRESS>  gcp-support             =<EMAIL_ADDRESS>}
iam_by_principals = {
<EMAIL_ADDRESS>= [ "roles/owner" ]
}

We need to either document this limitation of iam_by_principals or fix this.

local.iam_principals contains principals defined in var.groups as keys. Hence the code is it is now, works only for those principals, i.e.:
groups = {
  gcp-billing-admins      =<EMAIL_ADDRESS>  gcp-devops              =<EMAIL_ADDRESS>  gcp-network-admins      =<EMAIL_ADDRESS>  gcp-organization-admins =<EMAIL_ADDRESS>  gcp-security-admins     =<EMAIL_ADDRESS>  gcp-support             =<EMAIL_ADDRESS>}
iam_by_principals = {
<EMAIL_ADDRESS>= [ "roles/owner" ]
}

Works, but this won't work:
groups = {
  gcp-billing-admins      =<EMAIL_ADDRESS>  gcp-devops              =<EMAIL_ADDRESS>  gcp-network-admins      =<EMAIL_ADDRESS>  gcp-organization-admins =<EMAIL_ADDRESS>  gcp-security-admins     =<EMAIL_ADDRESS>  gcp-support             =<EMAIL_ADDRESS>}
iam_by_principals = {
<EMAIL_ADDRESS>= [ "roles/owner" ]
}

We need to either document this limitation of iam_by_principals or fix this.

Makes sense, good catch.


BenHollis.PNGGauntlet version 3.1.2

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Github appears to be having issues right now, but I've pushed a commit to correct the version

Closing this for #54664 instead


Create local postgres database on docker-complse build

The server/API documentation does not mention that we have to create the database manually. This PR will create that database in the postgres container automatically during the docker-compose. Contributors can then simply build and get to work. Prior to this PR, an uninitiated database would result in errors such as:
 $ docker-compose up --build
[...]
db_1       | 2020-08-01 16:46:16.528 UTC [35] FATAL:  database "wise-old-man" does not exist
db_1       | 2020-08-01 16:46:16.800 UTC [36] FATAL:  database "wise-old-man" does not exist
db_1       | 2020-08-01 16:46:17.267 UTC [37] FATAL:  database "wise-old-man" does not exist
db_1       | 2020-08-01 16:46:18.124 UTC [38] FATAL:  database "wise-old-man" does not exist
db_1       | 2020-08-01 16:46:19.796 UTC [39] FATAL:  database "wise-old-man" does not exist
db_1       | 2020-08-01 16:46:23.299 UTC [40] FATAL:  database "wise-old-man" does not exist
db_1       | 2020-08-01 16:46:31.210 UTC [41] FATAL:  database "wise-old-man" does not exist
db_1       | 2020-08-01 16:46:50.606 UTC [42] FATAL:  database "wise-old-man" does not exist
server_1   |
server_1   | ERROR: database "wise-old-man" does not exist
server_1   |
server_1   | npm ERR! code ELIFECYCLE
server_1   | npm ERR! errno 1
server_1   | npm ERR<EMAIL_ADDRESS>predev: `npm run build && sequelize db:migrate`
server_1   | npm ERR! Exit status 1
server_1   | npm ERR!
server_1   | npm ERR! Failed at the<EMAIL_ADDRESS>predev script.

I feel this should be moved into the server code itself and check upon starting the service to see if the DB exists. This way the creation is agnostic of whatever the person uses as the medium for development. This is also more future proofing if docker is removed later on in the lifecycle of the project (which I don't but still).


Update mini-dashboard to v0.2.2

Pull Request
What does this PR do?
Fixes #2716
PR checklist
Please check if your PR fulfills the following requirements:

[x] Does this PR fix an existing issue?
[x] Have you read the contributing guidelines?
[x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

bors merge

bors merge


fix env loading

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5208b44) 100.00% compared to head (7dfbf82) 100.00%.
Report is 1 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff            @@
##              main       #65   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            5         5
  Lines          409       409
  Branches        89        89
=========================================
  Hits           409       409

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[question]: macro to disable floating point support

We are interested in using JSON in our Bareflank Hypervisor for both comms and configuration files, and would love to use this implementation. Kernel / Hypervisor code however should not use double / float as these data types can generate exceptions that cannot be handled well inside the kernel.
It appears that you already support signed / unsigned integers. Would you be interested in a patch that disables (likely via a macro of some sort) double / float completely to support people interested in using this library in non-userspace code?

Hi @rianquinn, this sounds interesting!
Did you see this paragraph in the README which could be relevant?

As the exact type of a number is not defined in the JSON specification, this library tries to choose the best fitting C++ number type automatically. As a result, the type double may be used to store numbers which may yield floating-point exceptions in certain rare situations if floating-point exceptions have been unmasked in the calling code. These exceptions are not caused by the library and need to be fixed in the calling code, such as by re-masking the exceptions prior to calling library functions.

How would you deactivate floating-point support? Did you try setting number_float_t to a different type? If possible, I would like to avoid getting to the #ifdef-hell...

The perfect solution would prevent float / double types / instructions from being compiled into the code. The reality is, so long as the code is not executed, it's fine. I did not try setting number_float_t to a different type, but my guess is it would collide with your existing unsigned / signed ints. The question is, When a JSON string is read, and it sees a "42" and not a "42.0" does it use ints and not floats from start to finish? So long as floats and doubles are never used, it should be fine.

You're right - setting number_float_t to an integer type yields collisions. So far, I do not see a simple solution to exclude any floating-point numbers from the class.

Any idea how to proceed on this?

I think the best thing to do is probably close the ticket. A couple of days ago I grabbed the source and gutted anything with "float" or "double". It only took about 5 mins, and the resulting code worked great. Based on those results, this implementation is perfect for what we need it for, but the only way I know to implement this more generically is to use #defines which I would agree would clutter what you have for a very small use case. For now, my plan is to maintain a fork with the modifications in our repo. I'm watching this repo, so anytime you roll a release, I'll make the mods, and push to our repo, and let you know if anything you guys change breaks what we are doing. But yeah, I wrote the (QMJson)[https://github.com/QtMark/qmjson] code, and I really like what you have done with this C++ only implementation so we will use it for sure.

This is fine with me. Thanks for the quick response, and maybe we find way to cope with your usecase in a general way!


Handing runtime errors in a production application

Rather than an issue this is more understanding the best way to incorporate Sentry into a real world production Go application. I feel that the documents for this section could be improved.
From reading this section of the documents I see that If I have code that potentially could cause a panic: runtime error,  I should initially call defer sentry.Recover() to handle the potential panic. E.g
func() {
	defer sentry.Recover()

        numbers := []int{1, 2, 3}
        fmt.Println(numbers[3])
}()

This will cause a panic: runtime error: index out of range [3] with length 3 error that Sentry will pick up.
However in a real world application with many lines of code I'm not sure what the best practice is. Do I have to identify every piece of code that potentially causes an unblended panic and prepend it with the sentry recover? Is there a way I can implement my project so I can pick up every panic in a general case?

In general, you need to handle panics whenever you spawn a new goroutine. For your usual http server, you have a middleware that handles panics per request, and then every subsequent function that spawns a new goroutine needs a panic handler.
I'm not sure if there is a way around that.

On my HTTP server I have a global Middleware to capture Panics, and then I need to manually capture panics for new goroutines created within Controllers and EndPoints