Chart appears, but no candles.

Question
Hello and happy new year!
I am trying to replicate the first example of the README file with my own dataframe. My df is formatted exactly as the ohlcv.csv, but while I am seeing correct prices, correct dates and crosshairs, no candles are drawn. Yet it works fine with the provided ohlcv.csv on my machine.
Here is a visual guide to what I am seeing. The only thing I am changing to the boilerplate code is reading ohlcv2.csv instead of ohlcv.csv.
My df:

The chart with debugging enabled:

I am getting the same behaviour running the code both from jupyter and .py.
Thank you for your time :)
Code example
No response

Thank you for the reply.
Unfortunately, still no candles. Even if I remove the Unnamed column you see there.

The df column types are also the exact same as the original ohlcv.csv. Quite a riddle.

Have you tried it without the unnamed column, or moving unnamed to after volume?
I'm quite sure if it uses fixed column positions for ohlcv data.
My dataframes have ts_index,o,h,l,c,v followed by a whole host of indicator columns and it plots fine.

Hey @konstantinosftw,
Your data is in reverse (needs to be chronological).
Louis

@arotabi @louisnw01 Thank you both, it was a sorting problem indeed. I concatenated the two requests of the ohlcv data inversely.
pyplot and pyplotly libraries drew the dataframe correctly despite the confused dates, so I would never notice that in row 1000 the dates went backwards. Good catch.
Throwing a relevant error when dates are unsorted could be a helpful addition since in larger dataframes this can be hard to notice.
Take care and great job on the library!


Outline of pipeline documentation

Captures work for Issues #170 and #174
Mostly working in
https://github.com/eclipse-pass/main/blob/174-pipeline-documentation/docs/pipeline.md
And
https://github.com/eclipse-pass/main/blob/174-pipeline-documentation/docs/architecture.md

@aforward
I added some information for pass-deposit-services and pass-authz. It does not include any information about publishing artifacts, for example pushing to a maven repository. Is this the right level of detail?
I'm not clear on what the deploy column means. Do we want to describe how a component is deployed in pass-docker? Or is this about cloud deployment?

Joint effort with @markpatton finalizing this work, I am :+1: to have this merged as a baseline.


Doesn't seem to convert in parallel

It doesn't seem the extension converts drawio files one at a time, even when Sphinx is run in parallel mode. I thought adding "parallel_write_safe": True might help, but that doesn't seem to have an effect. Any ideas on how to convert drawio files in a parallel manner? On Sphinx projects with a large count of drawio diagrams this can become quite the performance bottleneck.

The more I look into this, the more I realize I don't know how to test for success. We are running Sphinx in parallel, but I can't say for sure if the drawio portion is or not, so I'd take this as a grain of salt for now. The cache is great, but it only works on incremental builds (since the cache has to be built the first time around), but I have thought about having the option to host the cached files somewhere and pull those down (not sure the feasibility yet though).
I'll keep digging and look into the editable PNGs or SVGs as well and post any relevant updates, for clarity's sake. Thanks!

You will have to run sphinx with https://www.sphinx-doc.org/en/master/man/sphinx-build.html#cmdoption-sphinx-build-j.

This defaults to 1.

This speedups doc generation a lot but drawios are still generated one by one (which is slow).

I've been exploring a couple alternatives recently and one is using the drawio batch (folder) convert feature which saves a couple minutes (~25% time savings) with 150+ drawio files to convert. It seems like batch conversion itself could have better performance, but that is a drawio-desktop issue. You can use this bash script to convert files in a source directory one by one versus converting the source directory in batch:
#!/bin/bash

# Directory containing the files
DIRECTORY="./source"

# Loop through each file in the directory
for FILE in "$DIRECTORY"/*
do
  # Call the drawio executable with the current file
  /opt/drawio/drawio --export --crop --page-index 0 --scale 1.0 --transparent --format png --output ./build "$FILE" --enable-logging --no-sandbox
done

I've also been trying to experiment with basically adding all the drawio command calls to a list and running those in parallel at the end of the build step and seeing if that out performs the batch conversion, but that implementation is a little more tricky.


Render Targets for multi-camera scene

When using multiple cameras (like in VR) render target textures didn't work correctly.
This solves the issue - there is now an option to render the texture either on the scene level (shadows for example), or camera level (mirror, or water for example).

Hey
sorry about the stupid question
But I guess if we change this:
https://github.com/BabylonJS/Babylon.js/blob/master/materialsLibrary/src/water/babylon.waterMaterial.ts#L476
and remove the line 476 and 477
and instead return the two textures with a getRenderTargetTextures()
I think it should fix the bug
like here in the stdmat:
https://github.com/BabylonJS/Babylon.js/blob/master/src/Materials/babylon.standardMaterial.ts#L445


Last commit date?

It would be nice for the versions dict to have a timestamp with the date associated with the last commit. I haven't gotten enough of a hang of the source to make a PR, but as far as I know a simple (and parsable with datetime if need be) date is achievable with git show -s --format=%ci HEAD:
$ git show -s --format=%ci HEAD
2016-04-14 19:28:55 -0700

I managed to get local commit time to save: https://github.com/thurask/python-versioneer/commit/91fe30aef60d67438486d063f4e65a63606bf71a
Here it is running in one of my repos, through Termux:

Should be fixed in #120, once that gets pulled in.


:fire: Remove support for Python 3.5

Initial PR about the removal of Python 3.5
Some cleanup are required.

Codecov Report

Merging #192 (b4e8f5b) into master (4846792) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #192      +/-   ##
==========================================
- Coverage   89.86%   89.85%   -0.02%
==========================================
  Files          11       11
  Lines        1214     1212       -2
==========================================
- Hits         1091     1089       -2
  Misses        123      123

Impacted Files
Coverage Δ

charset_normalizer/api.py
86.76% <100.00%> (-0.07%)
:arrow_down:

charset_normalizer/assets/__init__.py
100.00% <100.00%> (ø)

charset_normalizer/cd.py
96.34% <100.00%> (ø)

charset_normalizer/constant.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4846792...b4e8f5b. Read the comment docs.

Python 3.6 is also EOL; will we drop that soon?

I do not know for sure at the moment.
To be considered; some of our primary integrators like aiohttp still support it. And as far as I am aware, there is nothing in the code of this tiny library dedicated to python 3.6.
If we drop it, it would be as simple as patching the version requirement.
I am more inclined to keep the support while it does not create specific code or patchwork to make it work.
The probable outcome of this would be seen in the next major.
Hope that answers the question.

Got it, thanks! When you do I'd like to open a PR switching to PEP 621 project metadata 🙂


[Suggestion] support imported .yaml with mixed CRD and normal resource definitions

Is your feature request related to a problem? Please describe.
When importing resources, we generally expect them to be either CRDs or k8s. We should support a file that has both CRDs and standard resource definitions in them.
For example, take https://operatorhub.io/operator/composable-operator (can also be found here: https://operatorhub.io/api/operator?packageName=composable-operator)
This contains Service (from k8s), a CRD named Composable, and a KafkaSource  (from api version sources.eventing.knative.dev/v1alpha1).
Describe the solution you'd like
A clear and concise description of what you want to happen.
They should be able to import this file, and have 3 imports/:
service.ts (they shouldn't need all of k8s imported)
composable.ts  (on of the CRDs)
kafkasource.ts (a standard resource from another api version)
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
This should unblock some work on https://github.com/awslabs/cdk8s/issues/72
This issue might be similar to https://github.com/awslabs/cdk8s/issues/71 but I think is distinct enough to have its own issue.

Interesting idea. What do you expect service.ts to include?

I'd expect it to have the minimum subset of k8s that you would need for it to work. So maybe:

export interface ServiceOptions {
  readonly metadata?: ObjectMeta;
  readonly spec?: ServiceSpec;
}

export class Service extends ApiObject {
  public constructor(scope: Construct, name: string, options: ServiceOptions = {}) {
    super(scope, name, {
      ...options,
      kind: 'Service',
      apiVersion: 'v1',
    });
  }
}

export interface ServiceSpec {
..
.
.

etc.
That being said, I am now thinking we may want to simplify and just detect and auto-import the whole k8s API for them (or in the case of the example, the serving.knative.dev/v1 API).

@campionfellin I still don't fully understand this workflow. The referenced YAML does not declare the "Service" type, it just uses a resource of that type. cdk8s import is designed to generate types...

Re-reading this, it seems I was confused about the functionality of cdk8s import at the time. Closing.


Change boot order of LaravelModuleServiceProvider

Hey,
the LaravelModuleServiceProvider is automatically loaded. Is there a possibility to add it manually so it's booted after a certain ServiceProvider? I tried to publish the Provider and set it in the app.config, but that didn't help.
I want to change this, so my modules will overwrite Routes if they already exists.

Hello,
This is laravel related.
Laravel has a dont-discover key in composer.json file, to disable autodiscovery of packages. You should be able to add the package here, and register it manually pre-5.5.

More about how here: https://medium.com/@taylorotwell/package-auto-discovery-in-laravel-5-5-ea9e3ab20518

Thanks for the quick answer. I will have a look and it. Right now I found a workaround.


ebiten: read-only Image

Images from AppendGlyphs should not be modified since they are from a cache and might be reused.
To avoid problems, should we have a read-only property for an Ebiten image?

As you yourself pointed out, many other variables in Golang are mutable, like color.White. While many of us would like to be able to annotate some variables as read-only (myself first), the reality is that Golang's type system does not provide such guarantees for public types. I think trying to work around this isn't the way to go. No pun intended.
Perhaps more importantly, we have to consider the following practical concerns:

Even if we had such a field, what would we do if the read-only property was violated? Neither panicking nor failing silently sound like we are making the situation any better. It's a different failure, but it's still bad.
If you allow read-only images, then you need to allow users to mark Ebiten images as read-only too. For example: they implement their own text renderer and have their own caches (...guilty). I don't think the scope of the current problem justifies the extra complexity or the addition of such a new method.

That being said, besides the recently fixed spec, what we could actually do is consider changing the name of the Image field in the Glyph struct to CachedMask, ReadOnlyMask, ReadOnlyImage or something like that that makes it more obvious that the image should not be modified. This would also make the code more self-documenting and would greatly reduce the chance of anything going wrong even if the spec is missed or forgotten.

I don't think the scope of the current problem justifies the extra complexity or the addition of such a new method.

I agree.

changing the name of the Image field in the Glyph struct to CachedMask, ReadOnlyMask, ReadOnlyImage or something like that

Hm, I'm not sure it is a good idea that a field that is named with ReadOnly but is actually writable... 🤔

While this is a terrible idea right now, just for the sake of completeness I'll say that it would be possible to use generics to separate images into SourceImage and DestinationImage, and have functions like ReplacePixels and DrawImage exist only on DestinationImage, but allow SourceImage to be used as a parameter to DrawImage. Then, the AppendGlyphs callback function would receive a SourceImage that naturally can't be modified because it doesn't have the methods for it.
Of course, this is a mess from a complexity perspective, mostly because for users it's hard to understand and pollutes the documentation (and it would massively break the API), but technically it's easy to implement and would solve the problem "cleanly". In case it inspires other solutions.

but allow SourceImage to also be used as a parameter to DrawImage

How would we pass a DestinationImage to DrawImage?

That's the generics part, where you would have to define a type Image interface { DestinationImage | SourceImage } type or something like that. It's unclear that generics are mature enough in Golang, and this has many many problems as already stated.


Update contributing.md file

Added a proper guide with illustrations on contributing.md file

Hi @JenilGajjar20 done with this. Kindly review and merge.


Error by using Lanelet2 python API

Hi,
i have a question, when i use Lanelet2 API to parse my own lanelet map, it shows the following errors:
        ......
        - Error parsing primitive -177: Failed to get id -72 from map
        - Error parsing primitive -177: Failed to get id -73 from map
        - Error parsing primitive -177: Failed to get id -74 from map
        - Error parsing primitive -177: Failed to get id -75 from map
        - Error parsing primitive -177: Failed to get id -76 from map
        - Error parsing primitive -177: Failed to get id -77 from map
        - Error parsing primitive -177: Failed to get id -78 from map
        - Error parsing primitive -177: Failed to get id -79 from map
        - Error parsing primitive -177: Failed to get id -80 from map
        - Error parsing primitive -177: Failed to get id -81 from map
        - Error parsing primitive -177: Failed to get id -82 from map
        - Error parsing primitive -177: Failed to get id -83 from map
        - Error parsing primitive -177: Failed to get id -84 from map
        - Error parsing primitive -177: Failed to get id -85 from map
        - Error parsing primitive -177: Failed to get id -86 from map
        - Error parsing primitive -177: Failed to get id -87 from map
        - Error parsing primitive -177: Failed to get id -88 from map
        ......

that was just a part of error message. It looks like my map data cannot be parsed.
here is a part of my lanelet map:
<?xml version='1.0' encoding='UTF-8'?>
<osm version="0.6" upload="true" generator="opendrive2lanelet">
  <node id="-1" action="modify" visible="true" lat="-5.4756988830976835e-06" lon="-0.00014362429049846425"/>
  <node id="-2" action="modify" visible="true" lat="-5.597261369222144e-06" lon="-0.00014816588925729593"/>
  <node id="-3" action="modify" visible="true" lat="-5.716030075616491e-06" lon="-0.00015270756095107276"/>
  <node id="-4" action="modify" visible="true" lat="-5.8320374445127515e-06" lon="-0.00015724930306549792"/>
  <node id="-5" action="modify" visible="true" lat="-5.945315920661456e-06" lon="-0.00016179111314472056"/>
  <node id="-6" action="modify" visible="true" lat="-6.055897951243835e-06" lon="-0.0001663329887906462"/>
  <node id="-7" action="modify" visible="true" lat="-6.1638159857860525e-06" lon="-0.0001708749276622418"/>
  <node id="-8" action="modify" visible="true" lat="-6.269102476075502e-06" lon="-0.00017541692747484718"/>
  <node id="-9" action="modify" visible="true" lat="-6.371789876079103e-06" lon="-0.00017995898599952644"/>
  <node id="-10" action="modify" visible="true" lat="-6.471910641863605e-06" lon="-0.00018450110106232965"/>
  <node id="-11" action="modify" visible="true" lat="-6.569497231517834e-06" lon="-0.000189043270543625"/>
  <node id="-12" action="modify" visible="true" lat="-6.664582105076906e-06" lon="-0.00019358549237744228"/>
  <node id="-13" action="modify" visible="true" lat="-6.757197724448344e-06" lon="-0.000198127764550745"/>
  <node id="-14" action="modify" visible="true" lat="-6.847376553340083e-06" lon="-0.0002026700851027638"/>
  <node id="-15" action="modify" visible="true" lat="-6.9351510571903655e-06" lon="-0.00020721245212432352"/>
  <node id="-16" action="modify" visible="true" lat="-7.02055370309945e-06" lon="-0.00021175486375711122"/>
  <node id="-17" action="modify" visible="true" lat="-7.1036169597631736e-06" lon="-0.00021629731819305405"/>

......
  <way id="-177" action="modify" visible="true">
    <nd ref="-1"/>
    <nd ref="-2"/>
    <nd ref="-3"/>
    <nd ref="-4"/>
    <nd ref="-5"/>
    <nd ref="-6"/>
    <nd ref="-7"/>
    <nd ref="-8"/>
    <nd ref="-9"/>
    <nd ref="-10"/>
    <nd ref="-11"/>
    <nd ref="-12"/>
    <nd ref="-13"/>
    <nd ref="-14"/>
    <nd ref="-15"/>
    <nd ref="-16"/>
    <nd ref="-17"/>

......
  <relation id="-179" action="modify" visible="true">
    <member type="way" ref="-178" role="right"/>
    <member type="way" ref="-177" role="left"/>
    <tag k="type" v="lanelet"/>
  </relation>
  <relation id="-269" action="modify" visible="true">
    <member type="way" ref="-268" role="right"/>
    <member type="way" ref="-177" role="left"/>
    <tag k="type" v="lanelet"/>
  </relation>

......
Hoping to get your answers.
Best Regards
Zhenlin

Are there nodes with ids -72 to -88 in the map?

yes, there are node with id -72 and -88:
  <node id="-72" action="modify" visible="true" lat="-9.019895314726357e-06" lon="-0.0004661631850085393"/>
<node id="-88" action="modify" visible="true" lat="-9.042079952220792e-06" lon="-0.0005388544387659826"/>

   - Error parsing primitive -177: Failed to get id -72 from map

Is this really the first error that you are seeing? Usually lanelet2 tries to continue loading the file if it cannot parse a primitive - at the cost that other elements from the map that rely on this primitive raise an error as well.
Since your lat/lon coordinates are suspiciously close to zero, I would suggest checking that your Projector uses a correct origin (i.e. also close to zero).


Named Entity Recognition (NER) Corpus

ML-Crate Repository (Proposing new issue)
:red_circle: Project Title : Named Entity Recognition (NER) Corpus
:red_circle: Aim : Task of categorizing the entities in a text into categories like names of persons, locations, organizations, etc.
:red_circle: Dataset : https://www.kaggle.com/naseralqaydeh/named-entity-recognition-ner-corpus
:red_circle: Approach : Try to use 3-4 algorithms to implement the models and compare all the algorithms to find out the best fitted algorithm for the model by checking the accuracy scores. Also do not forget to do a exploratory data analysis before creating any model.
Hello, ML-Crate contributors, this issue is only for the contribution purposes and allocated only to the participants of SWOC 2.0 Open Source Program and JWOC '22 Open Source Program.

📍 Follow the Guidelines to Contribute in the Project :

You need to create a separate folder named as the Project Title.
Inside that folder, there will be four main components.

Images - To store the required images.
Dataset - To store the dataset or, information/source about the dataset.
Model - To store the machine learning model you've created using the dataset.
requirements.txt - This file will contain the required packages/libraries to run the project in other machines.

Inside the Model folder, the README.md file must be filled up properly, with proper visualizations and conclusions.

:red_circle::yellow_circle: Points to Note :

The issues will be assigned on a first come first serve basis, 1 Issue == 1 PR.
"Issue Title" and "PR Title should be the same. Include issue number along with it.
Follow Contributing Guidelines & Code of Conduct before start Contributing.
This issue is only for 'SWOC' and 'JWOC' contributors of 'ML-Crate' project.

:white_check_mark: To be Mentioned while taking the issue :

Full name :
GitHub Profile Link :
Participant ID :
Approach for this Project :
What is your participant role?

[ ] SWOC 2.0 Participant.
[ ] JWOC 2022 Participant.
[ ] Contributor

Happy Contributing 🚀
All the best. Enjoy your open source journey ahead. 😎

Issue assigned to you @VishnuBhaarath


Parsing errors off by +1 line

Example:
odule Test
endmodule

@cos thinks that this comes because @dwightguth added requires "domains.k" by prepending it to the text.
I think it should be added programmatically. The original text should not be changed before sending it to the parser.

You are correct, that seems to be the cause of this, because it does not affect anything other than the very entry-level file. Unfortunately, that means it doesn't really affect me in any way. I will only be able to get to this after I no longer have higher priority tasks to accomplish, which may be some time (my guess is on the order of weeks). You may want to fix this yourself.

Can you at least pinpoint the place where you are doing this?

https://github.com/kframework/k/blob/master/kernel/src/main/java/org/kframework/kompile/Kompile.java#L252

@radumereuta was it fixed via #2019?

It should be, yes.


MolDraw2DCairo does not do atom/bond annotations on Windows

Configuration:

RDKit Version: 2020.03 and master
Operating system: Windows

Description:
Due to "cross-platform font fun" we disabled these annotations in PNGs on Windows. So this is a bug, but it's an intentional one (for the moment at least).
We should address this at some point in the future, but it will be tricky without adding our own font-handling code.

The font-handling is coming!


Update README.md with Carthage installation

If you clone the repo today, you cannot just run make bootstrap after clone, because it runs bin/carthage.sh which assumes you already have carthage installed:
// Makefile
carthage-bootstrap:
	bin/carthage.sh bootstrap --platform iOS || exit 1

// bin/carthage.sh
carthage bootstrap --platform iOS

which results in:
❯ make bootstrap
bin/carthage.sh bootstrap --platform iOS || exit 1
bin/carthage.sh: line 25: carthage: command not found
make: *** [carthage-bootstrap] Error 1

Obviously the bootstrap should install carthage, but I didn't want to do all that so I'm just updating the README to note this requirement.
Installing carthage is its own can of worms (how should it install, should it use homebrew, should it use a local pkg, should the pkg be bundled with the repo, what version of carthage, etc).

📲 What
A description of the change.
🤔 Why
Some background context on why the change is needed.
🛠 How
More in-depth discussion of the change or implementation.
👀 See
Trello, screenshots, external resources?

Before 🐛
After 🦋

♿ Accessibility

[ ] Tap targets use minimum of 44x44 pts dimensions
[ ] Works with VoiceOver
[ ] Supports Dynamic Type

🏎 Performance

[ ] Optimized Blended Layers (screenshots)

✅ Acceptance criteria

[ ] Steps to test this feature
[ ] Environment to test on
[ ] Issues to look out for

⏰ TODO

[ ] Got planned refactors to come
[ ] Will add more tests
[ ] Need feedback on a design

Hey @alanzeino! Just FYI. The iOS team is actually working on migrating all Carthage dependencies over to Swift Package Manager. We're almost done in fact and will likely be removing bin/carthage.sh and the need to install Carthage altogether.


[usbdev] Link reset must clear packet reception state.

In the event that a link reset occurs at the end of receiving an OUT packet of 62 or more bytes, the same fault as observed with the OUT STALL behavior would occur, causing reception failure of the first packet post-reset.
Related to issue #23806 and the RTL change in #23807, but this additional change is from inspection/reasoning rather than (yet) being demonstrated in DV.

Merging due to time criticality


Implement text update on button component

Call setText function on update on button component to change the text.

would be nice if this were accepted. Is this project dead?

Looks like there are some nice improvements being worked on, like rounded panels and use of a text component.

Looks like there are some nice improvements being worked on, like rounded panels and use of a text component.


Add Nong Song:

Song Name
Plug in Baby
Artist Name
Muse
Source
Youtube
Youtube Link
https://www.youtube.com/watch?v=Kler5kYbRqM&t=0s&ab_channel=Muse-Topic
Direct File Link
No response
Song ID
306640
Start Offset [ms]
No response
Extra
nothing, it's just a song that I would like them to add to the level

accept


Update documentation to use current_line_blame_opts

You need to edit the teal files and generate the lua files. See CONTRIBUTING.md for details.

Done in 7a4c93f


[newrelic-pixie] Add proxy configuration for Pixie integration.

Is this a new chart
No
What this PR does / why we need it:
It adds a proxy configuration field to the Pixie integration Helm chart.
Checklist

[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [mychartname])

Fixed the linter issue.


Review & improve accessibility

Resolved in fbab7a10329ca45b9ad3dc300a58c39a0e4d727f (I think). Asking for volunteers to help test it.


Remove Outermost Parantheses in C++

Have you read the Contributing Guidelines on Pull Requests?
Yes
Description
Issue No : #955
Remove Outermost Parantheses
Checklist

[x] I've read the contribution guidelines.
[x]  I've checked the issue list before deciding what to submit.
[x]  I've edited the README.md and link to my code.

Related Issues or Pull Requests
(Write your answer here.)

kindly review this PR @Kajol-Kumari @SKAUL05 @siddharth25pandey @iamrajiv @HarshCasper

Done @iamrajiv
Kindly review this PR.


throw error trying to change type of a field

iirc, don't currently support that and can lead to to mismatch with generated types vs db types
may be a mistake or gives false sense of what's supported

we do support some and it's not clear what's supported vs what will fail
the logic is in auto_schema bowels. we should know in go and either deny all or allow selectively and be clear

when a type is "changed" incorrectly, schema.sql and schema.py are changed but the underlying db isn't updated which leads to sadness later on when trying to write to it


Run error after install on OSX

On OSX  10.11.1
when run ./qira it shows me :
readlink: illegal option -- f
usage: readlink [-n] [file ...]
usage: dirname path

whatever args I give it.
How to fix it?

QIRA isn't officially supported on OS X but it has some experimental support. Since there seems to be a demand/interest in this, I'll take a look at this today and try to get things smoothed out.
That definitely does seem to be an issue with readlink on OS X being inconsistent with the one on Linux.

I've cleaned up some issues with installation and the readlink on OS X, but when I ran it with a 64-bit Mach-O binary the pintool died. QIRA was unresponsive. @percontation: do you want to take a look at this? I just did ./pin_build.sh. You probably know the most about this.

@nedwill Sure, I can take a look. In case it matters, can you make a note of your OS X version and clang --version?

Target: x86_64-apple-darwin15.0.0
Thread model: posix```

and OS X 10.11.2... Beta. Oh dear, I hope that's not an issue. I think I'm somehow in the Beta program. Either way, basically El Capitan.

Thanks!

@nedwill Wait, two more things. Can you link your guess_the_number source, and can you check to make sure make -C ./tracers/pin runls succeeds?

makefile:33: warning: overriding commands for target `clean'
pin-latest/source/tools/Config/makefile.default.rules:95: warning: ignoring old commands for target `clean'
cp -f /bin/ls /tmp/ls
codesign -fs- /tmp/ls
/tmp/ls: replacing existing signature
pin-latest/pin -t obj-intel64/qirapin.dylib -- /tmp/ls -l
qira: filtering to image /private/tmp/ls
total 80
-rw-r--r--   1 ned  staff   1214 Nov  1 12:30 makefile
drwxr-xr-x   4 ned  staff    136 Nov  1 23:47 obj-ia32
drwxr-xr-x   4 ned  staff    136 Nov  1 23:47 obj-intel64
drwxr-xr-x  12 ned  staff    408 Jan 20  2015 pin-2.14-71313-clang.5.1-mac
lrwxr-xr-x   1 ned  staff     28 Nov  1 23:47 pin-latest -> pin-2.14-71313-clang.5.1-mac
-rw-r--r--   1 ned  staff  29931 Nov  1 12:30 qirapin.cpp
drwxr-xr-x   8 ned  staff    272 Nov  1 12:30 strace

runls seems to work.
guess_the_number.c:
#include <stdio.h>

int main() {
	int x = 32;
	int y = x * 3;
	int user_number;
	printf("Please enter a number:\n");
	scanf("%d", &user_number);
	if (user_number == y)
		printf("You got it!\n");
	else
		printf("Sorry, try again.\n");
	return 0;
}

How did you manage to get make runls to work?
The following is my error message encountered:
makefile:33: warning: overriding commands for target `clean'
pin-latest/source/tools/Config/makefile.default.rules:95: warning: ignoring old commands for target `clean'
cp -f /bin/ls /tmp/ls
codesign -fs- /tmp/ls
/tmp/ls: replacing existing signature
pin-latest/pin -t obj-intel64/qirapin.dylib -- /tmp/ls -l
qira: filtering to image /private/tmp/ls
E: Unexpected memory deallocation request of aligned memory 0x10e84cf50
make: *** [runls] Error 255

The build output log for obj-intel64/qirapin.{o,dylib}:
g++ -DBIGARRAY_MULTIPLIER=1 -Wall -Werror -Wno-unknown-pragmas -fno-stack-protector -DTARGET_IA32E -DHOST_IA32E -fPIC -DTARGET_MAC   -Ipin-latest/source/include/pin -Ipin-latest/source/include/pin/gen -Ipin-latest/extras/components/include -Ipin-latest/extras/xed-intel64/include -Ipin-latest/source/tools/InstLib -O3 -fomit-frame-pointer -fno-strict-aliasing  -Wno-error  -c -o obj-intel64/qirapin.o qirapin.cpp
g++ -shared -w -Wl,-exported_symbols_list -Wl,pin-latest/source/include/pin/pintool.exp     -o obj-intel64/qirapin.dylib obj-intel64/qirapin.o  -Lpin-latest/intel64/lib -Lpin-latest/intel64/lib-ext -Lpin-latest/intel64/runtime/glibc -Lpin-latest/extras/xed-intel64/lib -lpin -lxed -lpindwarf

I'm on OSX 10.10.5;  clang/clang++ @ /opt/local/bin, due to a MacPorts install, ver info:
clang version 3.8.0 (trunk 257459)
Target: x86_64-apple-darwin14.5.0
Thread model: posix
InstalledDir: /opt/local/libexec/llvm-3.8/bin

Similarly, ver info for g++:
g++ (MacPorts gcc49 4.9.2_1+universal) 4.9.2
Copyright (C) 2014 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.


ng error

Please provide us with the following information:

OS?

Linux (Ubuntu 16.04 - 64bits)

Versions.

ng -v
Mg++ version:
Mg++ 1.5beta1 (formerly MicroGnuEmacs Adv.)
node --version
v4.2.6

Repro steps.

ng new my_project

The log given by the failure.

It's opening a mg editor

Mention any other details that might be useful.

Thanks! We'll be in touch soon.

Hey @perylemke, It looks like you have the ng-common package installed on your system, which also provides the ng executable:
http://packages.ubuntu.com/xenial/all/ng-common/filelist
It appears to be the Nihongo Micro Gnu Emacs editor. If you don't use it, or don't know it, it's probably safe to uninstall it.

Not CLI related.

as  @beeman told...
If you are not using ng-common then remove it using sudo apt remove ng-common
then remove node cache
and give a path to in .bashrc or .profile
alias='path/to/node_modules/angular-cli/bin/ng'
boom its working...!!

whenever i type ng -v then it display Mg++ 1.5beta1 (formerly MicroGnuEmacs Adv.)
i want to create new project with the help of ng command but is dosent work..
help me...
in my system npm -v4.2.0 anf node -v7.10.0 is available
but i cant work with angular-cli..what i need to do???

@kruvimak please read the comment of @sidjoshi001 he provided a solution for this problem - and it is working for me having the same issue. Also I think this should be added to the Wiki if possible, google this error is not easily linking to this issue.

If you are not using ng-common then remove it using sudo apt remove ng-common
then remove node cache
and give a path to in .bashrc or .profile: alias='path/to/node_modules/angular-cli/bin/ng'

I think this issue can be closed as solved?

@chriszo111  i have tried your method but it is not working.. kindly tell me is there any other solution

I am not able to install angular cli on my ubuntu.
ERROR:
sudo npm install -g @angular/cli
npm ERR! addLocal Could not install angular/cli
npm ERR! Error: ENOENT, stat 'angular/cli'
npm ERR! If you need help, you may report this log at:
npm ERR!     http://github.com/isaacs/npm/issues
npm ERR! or email it to:
npm ERR<EMAIL_ADDRESS>npm ERR! System Linux 4.4.0-98-generic
npm ERR! command "/usr/bin/nodejs" "/usr/bin/npm" "install" "-g" "@angular/cli"
npm ERR! cwd /home/asm
npm ERR! node -v v0.10.25
npm ERR! npm -v 1.3.10
npm ERR! path angular/cli
npm ERR! code ENOENT
npm ERR! errno 34
npm ERR!
npm ERR! Additional logging details can be found in:
npm ERR!     /home/asm/npm-debug.log
npm ERR! not ok code 0

Please help me out.

@perylemke I also face the same issue. Un-install ng-common.

Tive o mesmo problema, meu sistema Ubuntu 18.04.1 LTS.
Solucionei com os seguintes passos:
sudo apt remove ng-common
sudo npm uninstall -g @angular/cli
sudo rm /usr/local/bin/ng
sudo npm install -g @angular/cli
Note que no 3º passo tive remover o link simbólico (ng -> ../lib/node_modules/angular-cli/bin/ng) porque se não vai ocorrer um error na instalação do Angular.


Completion is auto selected when omni source is used

Sorry about my bad description. More about this issue, please have a look at the screen recording. When I type a character, then a completion is selected immediately, and also there are two popup.
https://user-images.githubusercontent.com/40141251/203274346-2b7c094e-09ec-4632-82e2-4c5a5a8fd38b.mov
Minimal init.lua to Reproduce this issue:
require("packer").startup({
  {
    "wbthomason/packer.nvim",
    "hrsh7th/nvim-cmp",
    "hrsh7th/cmp-nvim-lsp",
    "hrsh7th/cmp-omni",
    "neovim/nvim-lspconfig",
  },
})

local cmp = require("cmp")
local cmp_lsp = require("cmp_nvim_lsp")
local lspconfig = require("lspconfig")
lspconfig.sumneko_lua.setup {
  cmd = { "lua-language-server" },
  settings = {
    Lua = {
      telemetry = { enable = false },
    },
  },
  capabilities = cmp_lsp.default_capabilities(),
}
cmp.setup {
  sources = cmp.config.sources({
    { name = "nvim_lsp" },
  }, {
    { name = "omni" },
  })
}

I have the issue

It looks like it is using the lsp omnifunc (and hence if you select LSP snippets they are weird) ? If you set omnifunc= after the server has attached it fixes the issue

I worked around this by doing set vim.bo.omnifunc = "" in my lsp on_attach

It's conflict with nvim_lsp, temporary solution.
local on_attach = function(client, bufnr)
  -- https://github.com/neovim/neovim/pull/19677
  -- https://github.com/hrsh7th/cmp-omni/commit/01f0f66e7dc227606bb8d8ffad688b9c393a052c
  vim.api.nvim_buf_set_option(bufnr, "omnifunc", "any non-empty character")
end

@bstaint  It happens in python's omnifunc and I don't have lsp configured for python

@hrsh7th Any idea what is causing this issue (and if it indeed due to nvim_lsp conflicts whether some note should be made about this in the README itself?)
I believe you worked with @lervag over at the vimtex when they were implementing support for nvim-cmp via omni? (I see some commits on this repo were made due to issues discussed over at vimtex). Is this a new issue, or did it happen before?

I think the autoselection can be avoided with the vim setting vim.opt.completeopt:append('noselect') but the multiple popups are still unresolved

It's conflict with nvim_lsp, temporary solution.
local on_attach = function(client, bufnr)
  -- https://github.com/neovim/neovim/pull/19677
  -- https://github.com/hrsh7th/cmp-omni/commit/01f0f66e7dc227606bb8d8ffad688b9c393a052c
  vim.api.nvim_buf_set_option(bufnr, "omnifunc", "any non-empty character")
end

@bstaint Since this is already open for a while, what have you done with on_attach?


Issue encoding uint32 field

I'm worried that this is some sort of oversight on my part, so I apologize in advance if this is me being silly.  I have a pretty simple proto for some sensor data:
syntax = "proto3";

message SensorData {
    double x_axis = 1;
    double y_axis = 2;
    double z_axis = 3;
    uint32 sensor_type = 4;
    uint32 seq = 5;
    uint32 stamp = 6;
    uint32 device = 7;
    uint32 batch = 8;
}

Whenever I encode data with nanopb with this code
/* Pack it into a protobuf */
SensorData data_pb = SensorData_init_zero;
uint8_t pb_buffer[SensorData_size];
pb_ostream_t pb_stream = pb_ostream_from_buffer(pb_buffer, sizeof(pb_buffer));

data_pb.x_axis = get_data.imu_data.xl_data.x_axis;
data_pb.y_axis = get_data.imu_data.xl_data.y_axis;
data_pb.z_axis = get_data.imu_data.xl_data.z_axis;
data_pb.sensor_type = (uint32_t)get_data.sensor_type;
data_pb.seq = (uint32_t)get_data.seq;
data_pb.stamp = (uint32_t)get_data.stamp;
data_pb.device = (uint32_t)get_data.device;
data_pb.batch = (uint32_t)get_data.batch;

bool status = pb_encode(&pb_stream, SensorData_fields, &data_pb);
if (!status)
{
	LOG_ERR("Could not encode protobuf!");
}

I get something that looks like this:
09 54 1a 31 b3 cf a3 11 40 11 8d 7d c9 c6 83 2d cc 3f 19 ed d4 5c 6e 30 cc 20 c0 28 d6 0a 30 f2 68 38 b4 a4 b4 de 0a 40 a7 e9 b6 c5 0b 00 00 00 dd fe 02 00 89 2a 03 00 bc

If you take a look at this using either protobufjs or protobuf-decoder, which can be used here, I can never recover field 4.  Attempting to decode this using protoc simply fails with Failed to parse input.:
$ protoc --decode_raw < proto_data_1.raw
Failed to parse input.

$ protoc --decode SensorData proto_def.proto < proto_data_1.raw
Failed to parse input.

I tried changing the uint32 fields to fixed32 thinking that maybe it was something in packing variable integer data, but it only gets worse.  If I encode the same data with, for instance, protobufjs, I get this:
09 54 1a 31 b3 cf a3 11 40 11 8d 7d c9 c6 83 2d cc 3f 19 ed d4 5c 6e 30 cc 20 c0 20 00 28 d6 0a 30 f2 68 38 b4 a4 b4 de 0a 40 a7 e9 b6 c5 0b

which, besides being 10 bytes smaller (yay!), I can now decode successfully with protobufjs and with protoc:
$ protoc --decode_raw < proto_data_2.raw
1: 0x4011a3cfb3311a54
2: 0x3fcc2d83c6c97d8d
3: 0xc020cc306e5cd4ed
4: 0
5: 1366
6: 13426
7:<PHONE_NUMBER>
8:<PHONE_NUMBER>

$ protoc --decode SensorData proto_def.proto < proto_data_2.raw
x_axis: 4.409972
y_axis: 0.220139
z_axis: -8.398807
seq: 1366
stamp: 13426
device:<PHONE_NUMBER>
batch:<PHONE_NUMBER>

The reason I think this might be a me-problem is that you can see that even protoc doesn't seem to be in love with field 4, leading me to think that there is something inherently wrong with my proto to begin with, although I cannot for the life of me see it.

In typical fashion I spoke too soon. Clearly I used SensorData_size when I sent the data instead of pb_stream.bytes_written and was seeing extra characters.  The sensor_type field is a red herring - it just isn't showing up because it looks like it has length zero (since it only contains 0x00).  Move along, nothing to see here.

Nice to hear you got it solved :)


Fixes an issue around line style

Fixes an issue around line style (Graphing Mode)
Problem: Line Style doesn't show up in the combo box
Description of the changes:

Addes built-in line styles.
Changes DoubleCollection.Append() into DoubleCollection.Add()

How changes were validated:

Tested manually

Hi folks, could you help review this PR? thanks.


[WIP] Add parallel processing of packages

A lot of time is spent on I/O (git clone, NPM registry etc.), so sequential processing isn't very effective.

Not tested (thoroughly)

Once we don't rely on git as much anymore a concurrent bot will be easier. Instead of optimizing now we should work on removing git

Can I help in any way?
On 7. juli 2020 11.53.19 Sven Sauleau<EMAIL_ADDRESS>wrote:

Once we don't rely on git as much anymore a concurrent bot will be easier.
Instead of optimizing now we should work on removing git
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


colors won't change no matter what i do

Hi,
My app doesn't have a black background, so was trying to do a simple thing like change the background color to white and font color to black. I can apply styles using the method in the styles.js example, such as adding padding, and it works. But adding backgroundColor or color has no effect. Also tried directly modifying default.js to no effect. Seems like either of these approaches should have worked.
Please help, I really want to use this component, not sure what is going on. I cleared browser cache, so caching isn't the issue.
Thanks.

@adamscottv did you manage to fix this?

Any solution ?? @adamscottv

https://github.com/storybooks/react-treebeard/pull/171


Missing argument for parameter #1 in call

The following line of code in PullToRefreshConst.swift file is causing compile time error when Swift 4.1 is being used as per Build Settings:
self.refreshCompletion?()

Missing argument for parameter #1 in call

Insert '<#Void#>'

Replace ((Void) -> Void)? with (() -> (Void))? = nil
After replacement-
Line 29:
fileprivate var refreshCompletion: (() -> (Void))? = nil
Line 81:
public init(options: PullToRefreshOption, frame: CGRect, refreshCompletion :(() -> (Void))? = nil, down:Bool=true) {


1.9 avs-device-sdk: Error in building SampleApp alone

Hello AVS Team,
I need to build my SampleApp alone. Can you please share the cmake file changes for the for the new release 1.9.
I am able to build SampleApp seperately in version 1.8.
There is Authorization folder added in the new release 1.9. Can you please share the CMake file changes for the Authorization folder so that SampleApp can be build seperately.
Version - 1.9
OS - Ubuntu Linux
Thanks and Regards,
Sumit

Hi @sumit3817,
Please post here the cmake and make commands you're running alongside the output from those commands.
Also, are you following the Ubuntu-Linux-Quick-Start-Guide?
Thanks,
Benny

Hi @sumit3817, Could you check in SampleApp/src/CMakeLists.txt if you have add CBLAuthDelegate in target_link_libraries?
e.g.
target_link_libraries(SampleApp  ...     CBLAuthDelegate ... )

Yes, it was added.

Now, I am facing the issue with portaudio.
The logs of cmake are:-
-- The CXX compiler identification is GNU 4.8.4
-- Check for working CXX compiler: /usr/bin/arm-linux-gnueabihf-g++
-- Check for working CXX compiler: /usr/bin/arm-linux-gnueabihf-g++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found PkgConfig: /usr/bin/pkg-config (found version "0.26")
-- checking for module 'AlexaClientSDK'
--   found AlexaClientSDK, version 1.9.0
-- checking for module 'portaudio-2.0'
--   package 'portaudio-2.0' not found
CMake Error at /usr/share/cmake-3.2/Modules/FindPkgConfig.cmake:340 (message):
A required package was not found
Call Stack (most recent call first):
/usr/share/cmake-3.2/Modules/FindPkgConfig.cmake:502 (_pkg_check_modules_internal)
src/CMakeLists.txt:3 (pkg_check_modules)
-- Configuring incomplete, errors occurred!

Hi @sumit3817, for the portaudio error, is this something made yourself in cmake?  By default, the SDK uses some CMAKE options to set the libraries and include path for portaudio:
i.e. PORTAUDIO_LIB_PATH and PORTAUDIO_INCLUDE_DIR

Hi,
I have move forward and now facing the issue with Application Media Player:-
Here are the logs:-
[ 92%] Building CXX object src/CMakeFiles/Simplifi_Alexa.dir/SampleApplication.cpp.o
In file included from /home/harman/1.9_Alexa/sdk-source/Simplifi_Alexa/src/SampleApplication.cpp:18:0:
/home/harman/1.9_Alexa/sdk-source/Simplifi_Alexa/include/SampleApp/SampleApplication.h:117:55: error: ‘ApplicationMediaPlayer’ was not declared in this scope
using MediaPlayerCreateFunction = std::shared_ptr ()(
^
/home/harman/1.9_Alexa/sdk-source/Simplifi_Alexa/include/SampleApp/SampleApplication.h:117:77: error: template argument 1 is invalid
using MediaPlayerCreateFunction = std::shared_ptr ()(

Hello AVS Team,
Thanks for your support.
Now I am able to build Sample app alone.
You can close this issue.

@sumit3817 can you please share your build files? I'm facing the same issue.

Okay I was able to fix this, see https://github.com/alexa/avs-device-sdk/issues/368


Automated Prometheus version update 0.63.0-45.19.0

Automated changes by the cron-prometheus-update GitHub action
Adds [Prometheus add-on](https://kurl.sh/docs/add-ons/prometheus) version 0.63.0-45.19.0.

Just 1 failure (flake). It seems good to fly:


heading 2 bottom border is missing

Environment

Obsidian Version : 1.3.5
Things Version : 2.1.9

Screenshot

Problem
It seems that the bottom border is missing
Solution
I notice that u use h2 when styling the heading theme.css#LL296C1-L296C61
m not sure what happened but it seems the latest version of Obsidian doesn't use h2 for the heading it uses div instead

maybe change theme.css#LL296C1-L296C61 to :
body .HyperMD-header.HyperMD-header-2.cm-line {
  border-bottom: 2px solid var(--background-modifier-border);
  width: 100%;
  padding-bottom: 2px;
}

it fixes the issue for me
I really like your theme man, thanks for sharing @colineckert 😄👍
Also how about setting up sass?
I think it'll help with the development of this theme

hey @agung2001  sry for the delay! are you sure you don't have any other styling on the h2? i have the same theme and Obisdian versions and this is not an issue on my end.

also, are you using the style settings plugin? check you don't have the h2 underline toggle disabled

yep, thought about sass! good idea, just haven't had the time to explore futher

omg, thanks. the style settings plugin help. now it works like a charm 😄👍
well for the sass, actually I can help you with that.
I can create a fork for this repo and integrate sass
do u want me to do it?

awesome, glad that fixed it! i'll close this issue. and sure, go for it. fork and create a PR and i will review it :)


Add documentation for Vuetify SASS variable overriding

Description
Overriding SASS variables was difficult to figure out when using this module.  Provide some sample documentation for getting it to work.
Linked Issues
N/A
Additional Context
Out of the box the documentation on the Vuetify site does not provide a way to get a working example up and running for overriding SASS variables that is compatible with the Vuetify Nuxt Module.  Additionally there is no existing documentation on this module's page for getting it to work.
This extra md file provides step-by-step instructions for configuring SASS variable overrides that work with this Nuxt module.

[!TIP]
The author of this PR can publish a preview release by commenting /publish below.

Move the entry using h2 (##) to https://nuxt.vuetifyjs.com/guide/sass-modern-compiler.html, add also a reference somewhere here https://nuxt.vuetifyjs.com/guide/server-side-rendering.html#vuetify-sass-variables to the new h2.
Myabe we can change the menu title here https://nuxt.vuetifyjs.com/guide/sass-modern-compiler.html to SASS Modern Compiler and SASS Variables

/cc @TechAkayy

@userquin thanks for the speedy review!  Happy to make more changes as you or @TechAkayy see fit.

Change VP config file entry here (set text to SASS Modern Compiler and SASS Variables): https://github.com/vuetifyjs/nuxt-module/blob/main/docs/.vitepress/config.ts#L194

Thanks @anonmos. Let's wait for @userquin's final review & closure.


LXC Paperles-ng stuck on creation

Please verify that you have read and understood the guidelines.
yes
A clear and concise description of the issue.
Stuck on Installing OCR dependencies
What settings are you currently utilizing?

[ ] Default Settings
[X] Advanced Settings

Which Linux distribution are you employing?
Debian 12
If relevant, including screenshots or a code block can be helpful in clarifying the issue.
No response
Please provide detailed steps to reproduce the issue.

How Long? Need 20min

Yeap delay like 51 but finish , sorry


Map Solicitor name and company to CCD

Description
DerivedSolicitorDetails made up of Solicitor Name, Solicitor Company and Solicitor Address is being mapped and saved to CCD.
With the removal of Derived fields upcoming, the three parts needs to be mapped to CCD as well. Currently Solicitor Address is already being mapped, but Solicitor Company and Solicitor Name was not. This PR maps these two from session as well.
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Modified existing unit test cases to work for the new mapping additions.
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Rebased against latest master.

This has been tested and passed.
Solicitors details has been mapped to the relevant SolicitorName and SolicitorCompany fields  in CCD.
Ready to be merged

Merging on behalf of Michael.


How to mock internal fetch from end-to-end (e2e) test?

Hi, there! I am trying to write an end-to-end (e2e) test for my application, which involves making a request to an external API using the fetch function. However, I want to mock the internal fetch call in order to control the response and ensure predictable testing. Currently, when I run the test, the response does not match the expected values. I would appreciate any assistance in understanding how to mock the internal fetch call correctly in my e2e test.
Repository with the complete example code cfw-mock (just install the packages and run npm run test).

Here is the code snippet for the application:
import { Hono } from "hono";

const app = new Hono();

app.get("/users/:id", async (c) => {
  const userId = c.req.param("id");

  const response = await fetch(`https://jsonplaceholder.typicode.com/users/${userId}`);
  const user = await response.json();

  return c.json(user);
});

export default app;

And here is the code snippet for the e2e test:
import { join } from "path";
import { UnstableDevWorker, unstable_dev } from "wrangler";

const relativePath = (path: string) => join(__dirname, ...path.split("/"));
let worker: UnstableDevWorker;
let apiUrl: string;

beforeAll(async () => {
  worker = await unstable_dev(relativePath("../src/worker.ts"), { experimental: { disableExperimentalWarning: true } });
  apiUrl = `http://localhost:${worker.port}`;
});

afterAll(async () => {
  await worker.stop();
});

describe("GET /users/:id", () => {
  it("should return a specific user", async () => {
    const expectedUser = { id: 1, name: "John Doe" };

    // mocking internal fetch call
    const fetchMock = getMiniflareFetchMock();
    const origin = fetchMock.get("https://jsonplaceholder.typicode.com");
    origin.intercept({ method: "GET", path: "/users/1" }).reply(200, expectedUser);

    const response = await fetch(`${apiUrl}/users/1`);
    const user = await response.json();

    expect(user).toHaveProperty("name", expectedUser.name); // asserting response fails :(
    // AssertionError: expected { id: 1, name: 'Leanne Graham', …(6) } to have property "name" with value 'John Doe'
  });
});

In my e2e test, I have a specific scenario where I need to mock the internal fetch call to control the response and validate the behavior of my application. I have attempted to use the getMiniflareFetchMock() function to create a mock, and I intercept the GET request to /users/1 and respond with the expected user object. However, when I run the test, the response does not match the expected values, and the assertion fails.
I would appreciate any guidance or suggestions on how to properly mock the internal fetch call in my e2e test, so I can ensure predictable testing and validate the response data.

I'm having the same issue with getMiniflareFetchMock() call (with disableNetConnect() and various interceptors set up) in my vitest beforeAll seemingly having no effect on the separate miniflare 2.14.0 instance that is hosting my worker, as the worker's fetch calls to external resources still hit those external resources instead of the MockAgent.
I'm going to try removing the environment: miniflare setting in vitest and instead go with the Miniflare API:
import { Miniflare } from "miniflare";

const mf = new Miniflare({...});

afterAll(() => {
	mf.dispose();
});

to see if having miniflare in the same process as vitest (and the getMiniflareFetchMock() call) fixes it.

I achieve this goal with the "miniflare" and "@miniflare/core" package in version 2.14.0. I suggest doing something similar to this:
import { createFetchMock } from "@miniflare/core";
import getPort from "get-port";

// use join path
const MAIN_ENTRYPOINT_PATH = "./dist/index.js";
const WRANGLER_CONFIG_PATH = "./wrangler.toml";

const createWorker = async (fetchMock) => {
  const options = {
    host: "localhost",
    port: await getPort(),
    scriptPath: MAIN_ENTRYPOINT_PATH,
    wranglerConfigPath: WRANGLER_CONFIG_PATH,
    modules: true,
    d1Persist: true,
    d1Databases: ["__D1_BETA__DB"],
    fetchMock,
  };
  const url = `http://${options.host}:${options.port}`;
  const worker = new Miniflare(options);
  await worker.startServer();

  return {
    url,
    worker,
    stop: async () => await worker.stop(),
    fetch: async (url: string, init?: RequestInit) =>
      await worker.fetch(url, init),
  };
};

let fetchMock: ReturnType<typeof createFetchMock>;
let server: any; // type according to your server

beforeAll(async () => {
  fetchMock = createFetchMock();
  server = await createWorker(fetchMock);
});

afterAll(async () => {
  await server.stop();
});

test("worker", async () => {
  const expectedUser = { id: 1, name: "John Doe" };
  const origin = fetchMock.get("https://jsonplaceholder.typicode.com");
  origin
    .intercept({ method: "GET", path: "/users/1" })
    .reply(200, expectedUser);

  const response = await fetch(`${server.url}/users/1`);
  const user = await response.json();

  expect(user).toHaveProperty("name", expectedUser.name);
});

@sofimiazzi solution doesn't work anymore with miniflare 3 (no export for createFetchMock), can we reopen @mrbbot ? The docs are missing for Testing under miniflare and the fetchMock section on the Workers cloudflare:test module guide seems to indicate that you can only mock the worker under test which seems pretty.. pointless? Unless I'm misunderstanding the example here:
import { fetchMock } from "cloudflare:test";
import { beforeAll, afterEach, it, expect } from "vitest";

beforeAll(() => {
  // Enable outbound request mocking...
  fetchMock.activate();
  // ...and throw errors if an outbound request isn't mocked
  fetchMock.disableNetConnect();
});
// Ensure we matched every mock we defined
afterEach(() => fetchMock.assertNoPendingInterceptors());

it("mocks requests", async () => {
  // Mock the first request to `https://example.com`
  fetchMock
    .get("https://example.com")
    .intercept({ path: "/" })
    .reply(200, "body");

  const response = await fetch("https://example.com/");
  expect(await response.text()).toBe("body");
});

Assuming example.com is the worker under test, why would you mock the worker you're trying to test?


wip: allow set status

@ringerc, in order:

afaik there is no sensible way to add interface{}

To avoid even more registration boilerplate, I would add this as required for the plugin to implement, but I have no strong opinion.

I would enforce JSON to be sure that if in the future we need to act on those fields, we know how they are encoded

I was thinking of something like the following, but I think it's even worse.
14:35 $ git diff
diff --git a/proto/operator.proto b/proto/operator.proto
index c609e87..88918be 100644
--- a/proto/operator.proto
+++ b/proto/operator.proto
@@ -123,7 +123,7 @@ message SetClusterStatusRequest {
 }

 message SetClusterStatusResponse {
-  // This field is OPTIONAL. No value means no-op, otherwise the passed json is set inside the
-  // .status.plugins[pluginName] key
-  bytes json_status = 1;
-}
\ No newline at end of file
+  // This field is OPTIONAL. No value means no-op, otherwise the passed
+  // entries are set in the .status.plugins[*].data
+  map<string, string> data = 1;
+}

So yeah, while the JSON is not perfect, it definitely works!

Thankyou


External source for the synonyms collection [0.24.0]

In 0.23.1 it is not applicable, because we have a set of fixed sources, where grouping is based on the predefined entity parsers.
We can follow the way it works in ARElight
https://github.com/nicolay-r/ARElight/blob/c3d388cc7bcc5cea5be1ed1f0c19419c6157d309/examples/serialize_bert.py#L68-L69
Then it is followed by grouping method for entities:
https://github.com/nicolay-r/ARElight/blob/c3d388cc7bcc5cea5be1ed1f0c19419c6157d309/examples/serialize_bert.py#L76-L82

Won't be considered at the moment


[$500] [Android] Requested for location after creating scan receipt expense

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.43-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
Issue reported by: Me
The solution code should be the same for both iOS and Android. There is a bug that is causing the permission prompt to occur after the scan request is made.
Action Performed:

Camera permission should be set to 'Ask every time' when the app requests it
Location permission should be disabled
Create a Scan receipt expense
Request it

Expected Result:

Request submitted without issue

Actual Result:

Request submitted, and I am prompted for location permission

Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
https://github.com/Expensify/App/assets/10736861/b90ca63e-52a2-4ea2-a45c-21536f684e77
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
See Above

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~017b08f79b2ec6f294
Upwork Job ID:<PHONE_NUMBER>543987200
Last Price Increase: 2024-02-23

@Julesssss does this need to be External?

Hi,
if location is not mandatory then, add below check in react native code. It will not ask for permission but you can check if permission is granted is true then request device location.
import { PermissionsAndroid } from 'react-native';
const granted = await PermissionsAndroid.check(
PermissionsAndroid.PERMISSIONS.ACCESS_FINE_LOCATION
);

@ghure Thank you for your comment. Can you follow this template https://github.com/Expensify/App/blob/main/contributingGuides/PROPOSAL_TEMPLATE.md to make a proposal for your solution?

Proposal
Please re-state the problem that we are trying to solve in this issue.
Location permission is being asked when trying to request money after scanning a receipt.
What is the root cause of that problem?
GPS coordinates are being fetched and used while using the smart scan feature. If the location permission is not available, then it asks for the permission to fetch the current user position.
What changes do you think we should make in order to solve the problem?
We can add a check to see if the location permission is available. If it's there, use the latitude and longitude, else proceed with requesting money.
The below code fetches the position which leads to permission dialog showing up.
https://github.com/Expensify/App/blob/e9fb49d9f41972a04bf07905b228314a3fdce8d4/src/pages/iou/request/step/IOURequestStepConfirmation.js#L318-L337

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~01fac45b9079c75a93

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~01c05f9c2c9a9ac7bb

This is happening on iOS as well, I have checked it.

This is happening on iOS as well, I have checked it.

@ShridharGoel I can't reproduce this on iOS. Did you follow reproduction step - Location permission should be disabled before scanning a receipt?
Still looking for proposals.

That was a miss.
Here is the update: This is behaving in a different way on iOS because iOS handles permission differently. Once a permission is denied on iOS, the app can't ask for it again, it can only tell the user to go to settings and manually enable the permission. While in Android, the permission can be asked again (though after a few tries the user will get an option to choose "Don't ask again".

Proposal
Updated

After the location permission dialog is shown to the user for the first time and the user denied the permission, we can store this info using Onyx with key isLocationPermissionAvailable as false. We can put a check which will ensure that we will use location only if this key doesn't exist.

@ShridharGoel is that a new Onyx key? Also I don't see why we even need to request permission in this flow. I never opened the distance expense tab and this location prompt seems very invasive IMO

@Julesssss Yes, it would be a new key.
Initially, I also thought about completely removing the permissions flow
from here and only using the data is the permission is already available.
If that sounds good, I can update my proposal with this approach since this
would be a better UX.
On Mon, Feb 26, 2024, 3:28 PM Jules @.***> wrote:

After the location permission dialog is shown to the user for the first
time and the user denied the permission, we can store this info using Onyx
with key isLocationPermissionAvailable as false. We can put a check which
will ensure that we will use location only if this key doesn't exist.
@ShridharGoel https://github.com/ShridharGoel is that a new Onyx key?
Also I don't see why we even need to request permission in this flow. I
never opened the distance expense tab and this location prompt seems very
invasive IMO
—
Reply to this email directly, view it on GitHub
https://github.com/Expensify/App/issues/36882#issuecomment-1963728792,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIPLJHAODKE2GKN25WVFPR3YVRME7AVCNFSM6AAAAABDRGXJJOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRTG4ZDQNZZGI
.
You are receiving this because you were mentioned.Message ID:
@.***>

I also thought about completely removing the permissions flow from here

Just for the Scan/Manual request flow, right? I think ideally we only show that prompt for distance, and only before the request is made, never after.

Yes, only for the scan flow.
On Mon, Feb 26, 2024, 3:33 PM Jules @.***> wrote:

I also thought about completely removing the permissions flow from here
Just for the Scan/Manual request flow, right? I think ideally we only show
that prompt for distance, and only before the request is made, never after.
—
Reply to this email directly, view it on GitHub
https://github.com/Expensify/App/issues/36882#issuecomment-1963739764,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIPLJHHWCW253WGMDQHJGOLYVRMYPAVCNFSM6AAAAABDRGXJJOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRTG4ZTSNZWGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

@ShridharGoel Thanks for the update! Your proposal is promising.

This is behaving in a different way on iOS because iOS handles permission differently. Once a permission is denied on iOS, the app can't ask for it again, it can only tell the user to go to settings and manually enable the permission. While in Android, the permission can be asked again until the user selects "Don't ask again" option (after a few tries the user will get this option).

I think it'll be better if your RCA can addresses the main inconsistent issue as described first instead of jumping directly into discussing the general differences between the two platforms.
Can you elaborate on, when Location permission should be disabled on both Android and iOS, why does Android still prompt for location permission while iOS doesn't?
Hope we can start understanding this issue by a narrow use case, App with location permission disabled/denied as the
precondition, and then lead to a more general case if possible.

Can you elaborate on, when Location permission should be disabled on both Android and iOS, why does Android still prompt for location permission while iOS doesn’t?
Basically Android seems optimistic that the user would change their opinion and grant the permission. So, even if it is disabled, Android still goes ahead and asks for the permission when getCurrentPosition is called. This can lead to a bad UX for the user. This prompt would show every time unless the user either grants the permission or selects “Don’t show again” option.
In iOS, if the permission is disabled, it will not be asked again. (edited)

Is it possible to eliminate the inconsistency of Android in method getCurrentPosition?
For Android, we can use the shouldShowRequestPermissionRationale method. This will return true when the permission has been disabled, and in such a scenario we can skip the location info, so no dialog would be shown to the user.

Can you elaborate on, when Location permission should be disabled on both Android and iOS, why does Android still prompt for location permission while iOS doesn’t?

Basically Android seems optimistic that the user would change their opinion and grant the permission. So, even if it is disabled, Android still goes ahead and asks for the permission when getCurrentPosition is called. This can lead to a bad UX for the user. This prompt would show every time unless the user either grants the permission or selects “Don’t show again” option.
In iOS, if the permission is disabled, it will not be asked again. (edited)

Is it possible to eliminate the inconsistency of Android in method getCurrentPosition?

For Android, we can use the shouldShowRequestPermissionRationale method. This will return true when the permission has been disabled, and in such a scenario we can skip the location info, so no dialog would be shown to the user.

Can you elaborate on, when Location permission should be disabled on both Android and iOS, why does Android still prompt for location permission while iOS doesn’t?

Basically Android seems optimistic that the user would change their opinion and grant the permission. So, even if it is disabled, Android still goes ahead and asks for the permission when getCurrentPosition is called. This can lead to a bad UX for the user. This prompt would show every time unless the user either grants the permission or selects “Don’t show again” option. In iOS, if the permission is disabled, it will not be asked again.

Is it possible to eliminate the inconsistency of Android in method getCurrentPosition?

For Android, we can use the shouldShowRequestPermissionRationale method. This will return true when the permission has been disabled, and in such a scenario we can skip the location info, so no dialog would be shown to the user.

@ShridharGoel Thanks for quick update. It looks good. Can you update them to your proposal? It'll be helpful if you can also share a test branch and demo videos.
Note: Usually we don't need code diff and demo videos to evaluate proposal but this platform specific issue could be special and not that straightforward.

Note: Usually we don't need code diff and demo videos to evaluate proposal but this platform-specific issue could be special and not that straightforward.

I think it's okay to not do this to be honest. Its a bit unfair to ask someone to spend time on this and then not ending up using their solution.

In iOS, if the permission is disabled, it will not be asked again.

Android also blocks us from asking for permission after a few attampts... We need to avoid this at all costs on both platforms.
The solution code should be the same for both iOS and Android. There is a bug that is causing the permission prompt to occur after the scan request is made.

@Julesssss Yes, Android also stops asking for the permission after a few tries. But I think here we want to completely stop asking after it is denied once.
So we have two options:

Don't ask after it is denied once. (Needs custom code for Android)
Remove permission completely from here for both Android and iOS. That would mean the position would be used only if location permission is already available (granted previously).

The reason I raised this bug is that it makes no sense to prompt for the permission after the request has been made. We don't want to touch the existing permission prompt code unless it is necessary.

Remove permission completely from here for both Android and iOS. That would mean the position would be used only if location permission is already available (granted previously).

My question is why do we even prompt at this point in the code? I understand needing to be careful with the prompt where it it used, but there is no use for it in my test case.

There's no prompt code. Android system generates the prompt on its own when position is fetched.

@Julesssss Do you mean the request proceeded even before you dismissed the location dialog? That didn't happen with me - the request was sent after I selected "Don't allow" and then got this in the logs as expected:
[info] [IOURequestStepConfirmation] getCurrentPosition failed - {"TIMEOUT":3,"POSITION_UNAVAILABLE":2,"PERMISSION_DENIED":1,"message":"Location permission was not granted.","ACTIVITY_NULL":4,"code":1}

Do you mean the request proceeded even before you dismissed the location dialog?

Yes, I realize now my video doesn't show this but this happens every day when I submit an expense.

Location OFF -> App shows 'To continue, turn on device location' modal
Location ON -> App prompts for location permission

The reason I raised this bug is that it makes no sense to prompt for the permission after the request has been made. We don't want to touch the existing permission prompt code unless it is necessary.

@Julesssss Thanks for your explanation. So the primary issue we want to fix here is to avoid triggering location prompt after pressing the Request button and the expected flow will be

User select or take a photo to the Scan page
Popup location related dialog according to device setting (Optional)
User reacts to dialog to make location data (or null) is ready for this transaction (Optional)
User can click the 'Request' button without encountering subsequent location-related prompts.

Please correct me if I'm wrong.

*location feature, NOT location permission

I just tried this, and the experience is a bit weird. I think first we should pick this task: Just proceed with the request if location "feature" is turned off. There's no need to even check for permission related stuff if location itself is disabled.

@Julesssss @eh2077 Do you agree that we should skip location data if location feature is off?

User reacts to dialog to make location data (or null) ready for this transaction (Optional)

@eh2077 yeah you're correct, but one small change here:
At this point we only prompt for camera permission for the scan receipt flow, not location.

Do you agree that we should skip location data if location feature is off?

I agree, but that location dialog is native, and it is only occuring because of our code that is requesting location permission. When we remove the code that is triggering the location permissio, this dialog will also stop showing.

When we remove the code that is triggering the location permission, this dialog will also stop showing.

We can add a check - if location feature is off, we'll not use getCurrentLocation - hence no dialog will be shown.

When we remove the code that is triggering the location permission, this dialog will also stop showing.

We can add a check - if location feature is off, we'll not use getCurrentLocation - hence no dialog will be shown.

We shouldn't be calling getCurrentPosition at all. We have no need to do this. Removing this code is the solution to this bug.

@Julesssss We can pick the location from Onyx and use it with the help of userLocation key and remove getCurrentPosition() function call.

Taking this internal for a moment.

@Julesssss @eh2077 Kindly let me know once a decision a made. It would be great if I can get the chance to work on this.

I think we'll want to implement pre-permission prompt logic, something reusable that can be reused for our camera and location permissions. When I have a chance I'll create a new issue or update this one and comment here.

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Next week I'll re-work this bug into a feature request

No time today, potentially tomorrow.

Closing this as we need a full internal discussion and design review.
This bug will be fixed with the implementation of this feature


RN72 Support

deps:
"dependencies": {
    "@hookform/resolvers": "^3.1.0",
    "@react-native-async-storage/async-storage": "^1.19.2",
    "@react-native-clipboard/clipboard": "^1.11.1",
    "@react-navigation/native": "^6.1.1",
    "@react-navigation/native-stack": "^6.9.7",
    "@sourcetoad/vision-camera-plugin-barcode-scanner": "^1.0.1",
    "axios": "^1.4.0",
    "date-fns": "^2.30.0",
    "ethers": "5.7.2",
    "react": "18.2.0",
    "react-hook-form": "^7.44.3",
    "react-native": "0.72.1",
    "react-native-config": "^1.5.1",
    "react-native-get-random-values": "^1.9.0",
    "react-native-paper": "^5.8.0",
    "react-native-reanimated": "^3.4.2",
    "react-native-safe-area-context": "^4.4.1",
    "react-native-screens": "^3.18.2",
    "react-native-select-dropdown": "^3.3.4",
    "react-native-simple-dialogs": "^2.0.1",
    "react-native-vision-camera": "2.15.4",
    "text-encoding": "^0.7.0",
    "yup": "^1.2.0"
  },

followed example and it fails with

ERROR  frame-processor/unavailable: Frame Processors are not enabled. See https://mrousavy.github.io/react-native-vision-camera/docs/guides/troubleshooting, js engine: hermes

plz help!
thanks

it's https://github.com/mrousavy/react-native-vision-camera/pull/1533 probably

Hmm. I'm guessing this is a tough situation.
reanimated V2 doesn't support RN72
vision camera V2 needs reanimated
vision camera V3 is still in development
Our RN72 upgrade is blocked and I imagine it's because of this.

sheeesh

Yep confirmed and adjusted title. We cannot support RN72 yet until Vision camera does.

Vision Camera v2 looks pretty EOL at the moment as author focuses on v3.
However, a donation given with request of "releasing a v2 patch" did work, so perhaps that can be used to entice a RN72 fix, but I doubt it because....

Vision v2 needs Reanimated 2 to support RN72
Reanimated 2 is EOL for Reanimated v3
Vision v2 doesn't support Reanimated v3
Vision v3 doesn't use Reanimated

Okay we are unblocked on this now.

v3 support on v2 - https://github.com/mrousavy/react-native-vision-camera/releases/tag/v2.16.1
v3 is out - https://github.com/mrousavy/react-native-vision-camera/releases/tag/v3.2.0


Windows vagrant

Instructions on how to setup runner in VMs using Vagrant, using a Windows host. For a large part, the instructions where copied from the Ubuntu counterpart.

For review, I assigned Stefan as a suggestion.


Dev

fixed O&M calculation for 'renewables'
transferring version updates to environment.yml
tox settings rationalized and back in their own file

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 93.414%

Totals

Change from base Build<PHONE_NUMBER>:
0.03%

Covered Lines:
539

Relevant Lines:
577

💛  - Coveralls


ContractFactory.deploy() method refactoring

Description:
This PR modifies ContractFactory.deploy() method in order to support deployment of smart contracts in the hedera network.
Related issue(s):
Fixes #82
Notes for reviewer:

Checklist

[ ] Documented (Code comments, README, etc.)
[x] Tested (unit, integration, etc.)

lgtm


Regular boxes are now destructible

#16187
Syndie boxes are indestructible.
Added a base type.

tweak: Regular boxes are now destructible

mapping changes are sussy

mapping changes are sussy

Had to change it since BaseBigBox is now abstract and BigBox is the new BaseBigBox but as children


Can markers support html display just like hoverProvider do ?

Now I use setModelMarkers just like this :
const markers = [];
markers.push({
        severity,
        startColumn,
        startLineNumber,
        endColumn,
        endLineNumber,
        message,
        source,
        code,
});
this.monaco.editor.setModelMarkers(
      this.editor.getModel(),
      'eslint',
      markers
);

I want to show eslint errors the way just like in vscode (highlight the prat var console: Console)

My questions are :

How can i do this (display html in markers) with setModelMarkers ?
By the way, what does the property code use for ?

You can't use directly HTML, but you can use markdown in the message for a marker.
AFAICT code isn't used anywhere. @jrieken what is the purpose of IMarker.code ?

code (as error_code) is used to feed information back to code action provider. that's how they often link errors to fixes


Change @JsonCodec to generate ObjectEncoder instances

The semi-automatic derivation mechanism returns ObjectEncoder instances, but @JsonCodec was forgetting this by statically typing its instances as Encoder.

Current coverage is 79.85%

Merging #253 into master will not affect coverage as of 9ec18ab

Powered by Codecov. Updated on successful CI builds.


[1_geom_series]_small_modify

Good morning @jstac , this PR makes the following modification in the remark of section Key Formula within lecture geom_series:

The above formula works for -->> The above formulas work for

I suggest this change because you mentioned two key formulae for two cases: infinite and finite geometric series; also be consistent with the section title.

Is the statement true for both formulas?

Dear @jstac , thanks for your kind reminder.
I see. The statement does not work for both formulas and this is why you use the singular form rather than plural.
I will check more carefully before I submitted PRs then. I will also close this PR.


Bundle Load Error

Bundle has failed to load. If this is due to symbols not found, this may be due to symbols being hidden from dynamic libraries.
Expected in: flat namespace
in /Users/mstail/Desktop/fanwei/hospital/iOSInjectionProject/build/Debug-iphonesimulator/InjectionBundle2.bundle/InjectionBundle
Please help to solve the above problems. Thanks~

The must be some undefined symbols loading. Check your Xcode console for details.


test new method not deprecated one

removes:
DEPRECATION WARNING: validate_credentials_task is deprecated and will be removed from ManageIQ K-release (use verify_credentials_task instead) (called from block (4 levels) in <top (required)> at /home/travis/build/ManageIQ/manageiq/spec/models/mixins/authentication_mixin_spec.rb:302)

NameError:
       undefined local variable or method `params_for_create' for #<Class:0x000000000a73d840>
     # ./app/models/mixins/verify_credentials_mixin.rb:69:in `encrypt_verify_credential_params!'
     # ./app/models/mixins/verify_credentials_mixin.rb:44:in `verify_credentials_task'
     # ./spec/models/mixins/authentication_mixin_spec.rb:302:in `block (4 levels) in <top (required)>'

This is not ready for cutover yet...The deprecation is used to ensure that the core is created... See https://github.com/ManageIQ/manageiq/issues/18818


Add OtherNames feature flag to docs

I noticed a few places where the OtherNames feature flag config option was missing.

https://release-next--cert-manager-website.netlify.app/docs/cli/webhook/
https://release-next--cert-manager-website.netlify.app/docs/cli/controller/
https://release-next--cert-manager-website.netlify.app/docs/installation/configuring-components/

/assign @hawksight


[BUG] MQTTNoMemory on MQTT_Agent when reconnect to WIFI ( 2nd execute on prvConnectAndCreateDemoTasks()) on ESP32

Describe the bug
while ( 1 )
{
ulTaskNumber++;
prvConnectAndCreateDemoTasks( NULL );
}
in prvConnectAndCreateDemoTasks function, two tasks (prvMQTTAgentTask, prvSimpleSubscribePublishTask) will be created,
when error happen the two tasks will be deleted ( vTaskDelete(NULL)),  and prvConnectAndCreateDemoTasks will be executed again.
when I reboot(restart) wifi device, error happened and prvConnectAndCreateDemoTasks function re executed on expected, but in the 2nd execution, ERROR happens at :
prvSubscribeToTopic()
xCommandAdded = MQTTAgent_Subscribe( &xGlobalMqttAgentContext,   -->>>>>>>>>ERROR happened here!!!!!
&xSubscribeArgs,
&xCommandParams );
if( xCommandAdded == MQTTSuccess )
{
/* Wait for acks to the subscribe message - this is optional but done here
* so the code below can check the notification sent by the callback matches
* the ulNextSubscribeMessageID value set in the context above. */
xCommandAcknowledged = prvWaitForCommandAcknowledgment( &ulNotifiedValue );
}
else
{
LogError( ( "Failed to enqueue subscribe command. %s", MQTT_Status_strerror( xCommandAdded ) ) );
}
THE ERROR SHOWS:
No command structure available.
Failed to enqueue subscribe command. MQTTNoMemory
====================PARAMS tries for:================
#ifndef MQTT_AGENT_NETWORK_BUFFER_SIZE
#define MQTT_AGENT_NETWORK_BUFFER_SIZE    ( 10000 ).   ====> defaults is 5000
#endif
democonfigSIMPLE_SUB_PUB_TASK_STACK_SIZE      SETTING to :::   configMINIMAL_STACK_SIZE * 6
WHAT THE MATTER?  anybody can help me? THX.
System information

Hardware board: [ ESP32S2 ]
IDE used: [ VSCode ]
Operating System: [ MacOS ]
Code version: (202107.00-48-g30f4b7257)
Project/Demo: [ coreMQTT_Agent demo ]
If your project is a custom application, please add the relevant code snippet(s) in the section titled "Code to reproduce bug".

Expected behavior
esp32 reconnect to wifi in 2nd execution , MQTTNoMemory ERROR happens
Screenshots or console output
Steps to reproduce bug
Code to reproduce bug

Additional context

Hi @eelaix ,
Thank you for reaching out. Can you point me to which code base your project is based on? Is it https://github.com/FreeRTOS/coreMQTT-Agent-Demos/tree/main/source?

@tianmc1  yes, just this code.
but I have made some changes based on it.
prvMQTTAgentTask used to subscribe(receive) message from IoT server and
vStartSimpleSubscribePublishTask (prvSimpleSubscribePublishTask) used to publish device shadow (send) to server.
I think I have resolved this problem in some ways about:

when prvMQTTAgentTask fails ("Could not reconnect to MQTT broker") exit  prvSimpleSubscribePublishTask right now
make ulTaskNumber global to make different task name of prvSimpleSubscribePublishTask
change the task PRIORITY carefully, for example:
     /* Create an instance of the MQTT agent task. Give it higher priority than the       * subscribe-publish tasks so that the agent's command queue will not become full,       * as those tasks need to send commands to the queue. */
change the task stack size carefully

Here's my analysis of where the MQTTNoMemory error comes from. MQTTAgent_Subscribe calls a createAndAddCommand helper function. This function tries to get a command struct from the pool. It returns a MQTTNoMemory error when it cannot get a new struct from the pool. I'm guessing between deleting and recreating the prvMQTTAgentTask, some initializations are not done properly, which causes the issues. Notably, some context variables are static. They are automatically initialized to 0 on start up, but when the task is deleted and recreated, they may not be 0.
Is there a reason you prefer to delete the task when network is disconnected, instead of letting the task handle reconnect?

@tianmc1 yes, you are right, I had check the static variables and try to make them global.
I think another important thing is keep the two tasks synchronized, when network is not ready, do not send message to server again is the best way.

@tianmc1 I had read and test the code in
demos/ota/ota_demo_core_mqtt/ota_demo_core_mqtt.c
when "Could not reconnect to MQTT broker" appear, the hardware rebooted by configASSERT


ILO_SDK::Rest can't properly handle IPv6 addresses

Scenario/Intent
This is natural behaviour or URI library. See following example:
URI("https://[FE80::C800:EFF:FE74:8]").host # => "[FE80::C800:EFF:FE74:8]"
URI("https://[FE80::C800:EFF:FE74:8]").hostname # => "FE80::C800:EFF:FE74:8"

First example does not return valid IPv6 address so it OneviewSDK::Rest can't work properly.
https://github.com/HewlettPackard/ilo-sdk-ruby/blob/master/lib/ilo-sdk/rest.rb#L36
Steps to Reproduce
See Scenario/Intent
Fix?
Replace .host with .hostname (at the moment I can see only one occurrence):
https://github.com/HewlettPackard/ilo-sdk-ruby/blob/master/lib/ilo-sdk/rest.rb#L36
Potential impact
None. FQDNs and IPv4 URIs should be handled same way:
URI("https://oneview.local").hostname # => "oneview.local"
URI("https://oneview.local").host # => "oneview.local"
URI("https://<IP_ADDRESS>").hostname # => "<IP_ADDRESS>"
URI("https://<IP_ADDRESS>").host # => "<IP_ADDRESS>"

👍


Fixed some small typos in README

I saw some english typos while reading, so here are a PR to correct them.

Wow, not small typos after all :) Thnx a lot, I'll need to refresh my english grammar "knowledge".

Well English is not my native language either so I hope I didn't miscorrect stuff here ;)

I usually worry about deadlocks more thAn about grammar :)


Declarations of function pointers have their return type as their type specifier

In the code
typedef int foo;
foo (*bar)();

The declaratory for bar incorrectly has foo as the type specifier in its specifier list.  This causes TypedefName() and IsTypedef() on bar's type specifier to return foo and true respectively when they should return "" and false.
I suspect the core of the problem is that TypeSpecifier assumes that the type is fully specified before the identifier and doesn't understand the function pointer case.

Thanks for the report. Please feel free to make a PR if you want to give it a try ;-)
BTW, #99 is waiting for you merging it.


#13: Make package callable on command line.

Fixes #13

Codecov Report

Merging #14 (fb49194) into main (a06b642) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #14   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines           97        97
=========================================
  Hits            97        97

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a06b642...fb49194. Read the comment docs.


Deployment to Heroku or Google cloud fails

Hi, I am new to Node.js and I am trying to learn and deploy this code. I was successfully able to deploy it locally on Windows 10 and Ubuntu and it worked fine (node v8.1.2, npm 5.0.3). After that, I tried deploying it on Heroku and also Google Could AppEngine and I got the error "Cannot find module ./dist/vue-ssr-server-bundle.json" with both. Details below:
Updating service [default]...failed.
ERROR: (gcloud.app.deploy) Error Response: [9]
Application startup error:
yarn start v0.27.5
$ cross-env NODE_ENV=production node server
module.js:487
    throw err;
    ^

Error: Cannot find module './dist/vue-ssr-server-bundle.json'
    at Function.Module._resolveFilename (module.js:485:15)
    at Function.Module._load (module.js:437:25)
    at Module.require (module.js:513:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/app/server.js:41:18)
    at Module._compile (module.js:569:30)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:503:32)
    at tryModuleLoad (module.js:466:12)
    at Function.Module._load (module.js:458:3)
error Command failed with exit code 1.

While trying to debug this issue, I changed the package.json (line 8) from:
    "start": "cross-env NODE_ENV=production node server",
to:
    "start": "cross-env NODE_ENV=development node server",
and that also works fine locally. But on Heroku or Google cloud, I got the different error:
Updating service [default]...failed.
ERROR: (gcloud.app.deploy) Error Response: [9]
Application startup error:
yarn start v0.27.5
$ cross-env NODE_ENV=development node server
module.js:487
    throw err;
    ^

Error: Cannot find module 'glob'
    at Function.Module._resolveFilename (module.js:485:15)
    at Function.Module._load (module.js:437:25)
    at Module.require (module.js:513:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/app/build/webpack.client.config.js:1:76)
    at Module._compile (module.js:569:30)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:503:32)
    at tryModuleLoad (module.js:466:12)
    at Function.Module._load (module.js:458:3)
error Command failed with exit code 1.

Is this an issue with the code or am I missing something in my environment to deploy this to the cloud?
Thanks

If you want to deploy on Heroku, you need to modify a little the app. The simplest way to do this is to remove the ignore the in the .gitignore of the dist folder, and then create the build locally on your machine.
After doing that you commit your code and push it to heroku.
You might need to modify the start code too
"start": "NODE_ENV=production node server" or add a Procfile in the root of your folder with the code
web: node --harmony-async-await --optimize_for_size --max_old_space_size=460 --gc_interval=100 server.js

I will give this a shot. Thanks.

Thanks, this helped. I can successfully deploy this code.

@valentinvieriu can you clarify what needs to be deleted? The .gitignor file in the dist folder? For some reason, I don't have that file in my dist folder.
@rajeevag Can you please explain exactly what part of @valentinvieriu answer you used to get this working?


Add selected ITK remote modules

I have a package (convert3d) which requires one of the ITK remote modules (MorphologicalContourInterpolation).
Could we provide it through this recipe or should it be maintained in its own?
What do you reckon?

It turns out convert3d could be built without the remote module and upstream updated the build system to make it an optional dependency.

You are welcome to make a PR to enable a remote module. Some remote modules are of mixed quality, while others page behind the ITK releases,  so enabling them all is not easily done.


Init commit

Description
cc @athityakumar
This PR adds the basic Graph class and the following relevant methods:

Initialize

add_edge

remove_edge

add_node

add_nodes_from

Relevant Issues : #1 #8 #9

Relevant PRs :

Type of change :

[x] New feature
[ ] Bug fix for existing feature
[ ] Code quality improvement
[ ] Addition or Improvement of tests
[ ] Addition or Improvement of documentation

Sorry for this conflicting PR. I'll close this and open a new one.

@npochhi - You didn't have to close this PR. You can resolve the merge conflicts and force-push the changes to this branch, and the PR would have been automatically updated.


#1305: Do not show dialog when content is not changed + ...

Description
Currently on any state change there would be a trigger that would make the popup show on page refresh or navigation.
This change is a bit more specific about what changes to look for.
By doing this, we also now know when content is actually changed, and we can use this to display a "content changed" message.
We could also use this for autosaving content if we add this in the future.
Related Issues
Fixes #1305
Todo
If the approach is ok, I still need to make sure the original state is updated when the form is actually submitted.

@ifox  I removed the visual indicator to another pr so this can move forward #1378


Josepot submission

Hi @staltz, I've made a few improvements to my original submission, so if you don't mind I would like to update it. Thanks and sorry for the inconvenience!

:+1:


Allow Unstructured callback from Validating Webhook

Issue #1140
Proposed Changes
Allow Validating webhook to register generic Unstructured callbacks so that implementers can create generic, stateful validation outside of the APIs package.
This will later be used in Serving to implement DryRun validation of PodSpec for issue #3425

/assign @mattmoor @dprotaso

/lgtm
/approve

/assign @mattmoor for apis package


fix: handle source node

Overview

Checklist

[ ] I have run this code and it appears to resolve the stated issue
[ ] README.md updated and added information about my change

Lineage is not working with sources


fix: ensure all data provided

Description
Ensures all analytics for push_messages always have analytics
Resolves #163
How Has This Been Tested?
Locally with debugger
Due Diligence

[ ] Breaking change
[ ] Requires a documentation update
[ ] Requires a e2e/integration test update

Are there some tests missing?
In the Relay the functional tests confirm that metrics work

There are no tests atm for Echo analytics, I'll make an issue to investigate how the relay does it and get them here!


feat(utils): replace react-docgen with typescript

RFC
This PR aims to replace react-docgen with alternative that will generate the info files for the components using the typescript interfaces. The PR introduces the react-docgen-typescript library, that out of the interfaces for the props of the component, generates json in the same format as the react-docgen library. I added one interface for the UIComponentProps with some common props that can be extended in the other component's props.
Example
For example, here is how the Button component prop section looks now, in comparison with the previous:
NOW

PREV

You can see that the types of the props are much descriptive with the new approach, but there are still some things that needs to be taken into account.
There is some bug I guess, because the types of the @params used inside the JSDoc are not picked up. I created issue for this on their github repo. In addition, the default value of the props are taken just if the value is some primitive type. However for the second, there is an alternative way of defining, by adding @default in the comment of the property.
Please share your feedback, so that we can make progress with this on the other components as well. @alinais @Bugaa92 @levithomason @kuzhelov @miroslavstastny @layershifter

It seems that we can drop recast from dependencies, too.

We will also need to correct some types "before" | "after". However, it looks promising, nice job 👍

I also noticed that some Component are missing some common properties:
AccordionContent

styles, variables

AccordionTitle

styles, variables

Attachment

className

Popup (maybe these shouldn't even be added, but just in case...)

as
styles
variables

Portal (maybe these shouldn't even be added, but just in case...)

as
className
styles
variabels

Segment

children (it's not added in props, but it is actually used)

Slot

children (it's not added in props, but it is actually used)

Text

children (it's not added in props, but it is actually used)

Using some common interface for these would help us avoiding some of these mistake, plus we would have consistent description for the common properties without having to copy paste the same thing, or change it everywhere if we decide for better description.

Future work:

Had to add the accessibility defaultProps everywhere with a @default - we have to find alternative to this
Avatar – getInitials default value is not shown
ItemLayout render*** (some bugs even on prod) - default value not shown
Label accessibility was just added without description and default (didn't change anything there)
Portal context default is not shown
Popup content type has to be checked again
Variables type is any - there is interface for this but is not shown.


Update existing documentation after removal of prometheus pod annotations

Is there an existing issue for this?

[X] I have searched the existing issues

Problem Statement
KIC 2.0 removes prometheus.io/* annotations from the KIC/proxy pod, in favor of a PodMonitor.
There are some bits of documentation (most notably the Grafana guide) impacted by this.
Also, ensure that the KIC metrics (not only the proxy metrics) are referenced.
Proposed Solution
Audit our monitoring documentation (docs.konghq.com, chart repo) for dependency on those annotations, and fix these to work with the changes introduced in 2.0.
Additional information
No response
Acceptance Criteria

[ ] Each bit of documentation (in particular, the Grafana guide) that requires Prometheus works with the changes to KIC pod annotations introduced in KIC 2.0
[ ] Monitoring documentation that predates KIC 2.0 and only showcased proxy metrics now exposes the ingress controller metrics as well.

https://github.com/Kong/docs.konghq.com/pull/3288 (specifically https://github.com/Kong/docs.konghq.com/pull/3288/commits/7e8628c4360eeb98718f5c365215d76d5a367561) revises the docs guide to use the Prometheus Operator. That guide was already using a ServiceMonitor from the chart and just updates it slightly to match the new Prometheus' selection criteria.
On the chart end, we probably want to sub in the PodMonitor with a renamed values.yaml setting (deprecating the old key/using it as an alias for now).

Nevermind: the chart can just keep using a ServiceMonitor since the magic of the Prometheus Operator is such that it's just looking for the associated Deployment and doesn't care that the port isn't actually part of that Service (which makes sense--the actual metrics port doesn't have to be exposed via a Service). The changes we already made to the chart work; controller metrics do show up in Prometheus with the docs as-is.