Getting hold of a BrainVision dataset

@TomEmotion Could you post here an example from your BrainVision dataset? If it cannot be made public, can you send it to Yorguin by email?
And so we will also have a BrainVision dataset with a different experimental design, which of our collaborators may have such datasets? Do you know who works with BrainVision?

@yjmantilla You can also check these links for public datasets: https://github.com/openlists/ElectrophysiologyData#eeg-data
Maybe one of them is BrainVision

Hi @civier and @TomEmotion
I actually for this first test used the LEMON database which is on that list. I only downloaded 3 subjects for the test.
I have never found an open .cnt dataset . Have you guys ever seen one?

Closing this for now since seems like it is solved. Problem with the lemon dataset is that some fixes and decompressing need to be done before actually using them although this is cumbersomely fixed through the lemon scripts.


tflint support for cloud block in terraform

Describe the solution you'd like
Need support for the cloud stanza in the terraform block.  See https://www.terraform.io/cli/cloud/settings Currently it errors out saying cloud is an "Unsupported block type" so we have to disable tflint
Describe alternatives you've considered
There are no alternatives, other than disabling tflint
Additional context
This is relatively new syntax from HashiCorp, but it does need to be addressed.

This is actually supported with the latest version of tflint.  I suppose my question is if there is a way to have pre-commit or this repo automatically update, or update if told to do so, the hooks included.  We can specify the rev for this repo, but what about the hook ids?  I'm just not aware of how to do this if that is even possible, or whether the individual tools like tflint need to be manually updated.  Will close this issue, as I don't think it is an issue with this repo, but if anyone knows I'd be interested.


Unique POM File Name

I own a project where a single BUILD file will define two java_library targets. At the moment, build-tools always use hard-coded POM file named pom.xml. So if I'm running both targets, the first pom.xml will get overwrited by the second. I created a fork that names the pom file based on the target name (my_target_pom.xml for example).
This solve the issue but create another one - deploy_maven is correctly coupled into assemble-maven - it will look for that statically named pom file named pom.xml. deploy_maven support passing the assemble-maven target as optional argument which solve this issue, but it means this argument must be a must and not optional (which makes sense to me - as there is already sort of a coupling between the two with the static pom file name).
Let me know if that works for you, and if so - I'll send a pull-request.
Thanks!

#216

Fixed by #217


Puzzle constraints

Description
In general, constraints are what give good puzzles only one solution. In Latgrid, there are many types of constraints that are available to the setter to restrict what the solver will do. Some are implicit, like the size and shape of the grid or what objects can be drawn with the given controls, others are explicitly programmed by the setter, like no repeating digits allowed in a row, column, or box of a sudoku. All of these constraints will do (at least) two things. 1) They inform the solver what puzzle the setter had in mind and allow solvers to catch simple mistakes early (if they enable error highlighting). 2) It could enable automatic solvers to guide the setter in what's possible and try out puzzle designs without having to manually work out all the logic him-/her-self.
Because of this dual-goal mindset, I eventually want to structure explicit constraints to have a form that caters well to both. Aka, you add code for error highlighting and get auto-solver logic for free. But I have to start somewhere, so I'm just going to get some simple error highlighting going.
Basic plan going forward
Let me think of the easiest form to implement so I can get some code going.

First, only work with one grid type at a time, i.e. constraints must be rewritten for each grid type. That's the most common case and multiple grid types can be handled with multiple constraints for now.
do not implement user aliases or program presets at first. Only use extremely basic components. If the core is bad, the whole thing will be bad.
Try to think of a way to implement multiple constraints systems at once so I can test the difference between them. I might even support multiple versions indefinitely, adding more and deprecating some as I go.
For now, I think having a text input that evals JavaScript to encode constraints is the simplest way to do it; don't waste time designing a UI around the wrong API. It might even be just imperative JavaScript at first. That would allow me to change the API much more easily.
Only mark errors for now. Worry about automated solving and any compatibility with them later.

Don't worry about the continuity of this "discussion." This is more of just a dumping ground for ideas. :smile:


Create optional lock file for use of the data-store by external process

I would like the option to create a lock file when the data-store is being synchronized. I understand this can cause slow-down so it would be off by default.

I am willing to provide a patch but wanted to know if you would be open to accepting it and if adding lockfile from https://github.com/npm/lockfile would be acceptable to implement.

You can use lockfiles in your own libraries to lock the version of data-store to whatever you want. However, for reasons that will take more time to explain than I have right now, we don't use lockfiles in our libraries. Lockfiles prevent semver from doing it's job, and our experience has been that - between semver and lockfiles - semver is the lesser of two evils.

@jonschlinkert I don't think @cblauvelt was talking about a package lock file, but a lockfile to only allow a single process to access the file at a time.

@doowb I was a little confused bye the response and I was trying to figure out how semver would prevent another process from accessing the file while it was being written. @jonschlinkert I am trying to prevent an external process from reading the data-store while the file is being written and I am not trying to implement a package lock file such as that used by npm or yarn.

Oh like a mutex?
Sent from my iPhone

On Sep 13, 2019, at 3:59 PM, Brian Woodward<EMAIL_ADDRESS>wrote:
@jonschlinkert I don't think @cblauvelt was talking about a package lock file, but a lockfile to only allow a single process to access the file at a time.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Got it. Yeah I think you’re looking for atomic writes. Or we can use a mutex, or a combination of those.
Sent from my iPhone

On Sep 13, 2019, at 4:04 PM, cblauvelt<EMAIL_ADDRESS>wrote:
@doowb I was a little confused bye the response and I was trying to figure out how semver would prevent another process from accessing the file while it was being written. @jonschlinkert I am trying to prevent an external process from reading the data-store while the file is being written and I am not trying to implement a package lock file such as that used by npm or yarn.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Exactly like a mutex.


Update to Lattice Diamond 3.11

Lattice Diamond 3.11 has been released.

I've pushed the necessary changes and the master branch now uses 3.11 :tada: :slightly_smiling_face:


Restarting ST3 does not toggle HighlightWhitespaces

After installing HighlightWhitespaces and restarting ST3, I cannot toggle HighlightWhitespaces with Ctrl+Alt+W

@disq  / @popsikle what version of the package / ST3 should I use for a working version of this plugin ?

@disq has not been around this repo for a while.  Im currently asking the package control people to point the package control link to my repo instead via this pr https://github.com/wbond/package_control_channel/pull/4487 but you can clone my fork and test it out via https://github.com/popsikle/HighlightWhitespaces

Well, you could've sent a pull request ;)

I've tested that @popsikle 's version works in ST3. So, if this change does not regress any feature in ST2, it better if this were a PR in @disq's repo because the current repo already has 11K installs and it might just be confusing if suddenly there was a difference in the source of the package.
@popsikle - can you raise a PR here ?
and can you close  wbond/package_control_channel#4487  without any changes ?

Hey @disq you are alive! Ill open a PR =)

I just love it when people meet after a long time on open source.

Merged :)

Any update needed on sublime.Wbond.net?

No, I tagged a new release, wbond should get updated soon.


[4.11/Future] CLOUDSTACK-9776: extra DHCP options support for Nuage VSP

Co-Authored-By: Frank Maximus<EMAIL_ADDRESS>Co-Authored-By: Prashanth Manthena<EMAIL_ADDRESS>Co-Authored-By: Raf Smeets<EMAIL_ADDRESS>Bug: https://issues.apache.org/jira/browse/CLOUDSTACK-9776
Design-Doc: https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+extra+DHCP+option+support

Validation:
Added Marvin test code PEP8 and PyFlakes compliance:
CloudStack$
CloudStack$ pyflakes test/integration/plugins/nuagevsp/.py
CloudStack$
CloudStack$ pep8 test/integration/plugins/nuagevsp/.py
CloudStack$
Added Marvin test results:
CloudStack$ nosetests --with-marvin --marvin-config=nuage.cfg test/integration/plugins/nuagevsp/test_nuage_extra_dhcp.py
smoke_test (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: smoke_test | Status : SUCCESS ===
ok
test_01_nuage_extra_dhcp_single_nic_in_isolated_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_01_nuage_extra_dhcp_single_nic_in_isolated_network | Status : SUCCESS ===
ok
test_02_nuage_extra_dhcp_single_nic_in_vpc (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_02_nuage_extra_dhcp_single_nic_in_vpc | Status : EXCEPTION ===
ERROR
test_03_nuage_extra_dhcp_single_nic_in_shared_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_03_nuage_extra_dhcp_single_nic_in_shared_network | Status : SUCCESS ===
ok
test_04_nuage_extra_dhcp_update_vm_in_isoltated_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_04_nuage_extra_dhcp_update_vm_in_isoltated_network | Status : SUCCESS ===
ok
test_05_nuage_extra_dhcp_update_vm_in_vpc (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_05_nuage_extra_dhcp_update_vm_in_vpc | Status : SUCCESS ===
ok
test_06_nuage_extra_dhcp_update_vm_in_shared_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_06_nuage_extra_dhcp_update_vm_in_shared_network | Status : SUCCESS ===
ok
test_07_nuage_extra_dhcp_add_nic_in_isolated_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_07_nuage_extra_dhcp_add_nic_in_isolated_network | Status : SUCCESS ===
ok
test_08_nuage_extra_dhcp_add_nic_in_vpc (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_08_nuage_extra_dhcp_add_nic_in_vpc | Status : SUCCESS ===
ok
test_09_nuage_extra_dhcp_add_nic_in_shared_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_09_nuage_extra_dhcp_add_nic_in_shared_network | Status : SUCCESS ===
ok
test_10_nuage_extra_dhcp_deploy_multi_nic_vm_in_isolated_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_10_nuage_extra_dhcp_deploy_multi_nic_vm_in_isolated_network | Status : SUCCESS ===
ok
test_11_nuage_extra_dhcp_deploy_multi_nic_vm_in_vpc (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_11_nuage_extra_dhcp_deploy_multi_nic_vm_in_vpc | Status : SUCCESS ===
ok
test_12_nuage_extra_dhcp_deploy_multi_nic_vm_in_shared_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_12_nuage_extra_dhcp_deploy_multi_nic_vm_in_shared_network | Status : SUCCESS ===
ok
test_13_nuage_extra_dhcp_update_multi_nic_in_isolated_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_13_nuage_extra_dhcp_update_multi_nic_in_isolated_network | Status : SUCCESS ===
ok
test_14_nuage_extra_dhcp_update_multi_nic_in_vpc (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_14_nuage_extra_dhcp_update_multi_nic_in_vpc | Status : SUCCESS ===
ok
test_15_nuage_extra_dhcp_update_multi_nic_in_shared_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_15_nuage_extra_dhcp_update_multi_nic_in_shared_network | Status : SUCCESS ===
ok
test_16_nuage_extra_dhcp_remove_nic_in_isolated_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_16_nuage_extra_dhcp_remove_nic_in_isolated_network | Status : SUCCESS ===
ok
test_17_nuage_extra_dhcp_remove_nic_in_vpc (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_17_nuage_extra_dhcp_remove_nic_in_vpc | Status : SUCCESS ===
ok
test_18_nuage_extra_dhcp_remove_nic_in_shared_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_18_nuage_extra_dhcp_remove_nic_in_shared_network | Status : SUCCESS ===
ok
test_19_nuage_extra_dhcp_vm_actions_in_isolated_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_19_nuage_extra_dhcp_vm_actions_in_isolated_network | Status : SUCCESS ===
ok
test_20_nuage_nuage_extra_dhcp_vm_actions_in_vpc (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_20_nuage_nuage_extra_dhcp_vm_actions_in_vpc | Status : SUCCESS ===
ok
test_21_nuage_extra_dhcp_vm_actions_in_shared_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_21_nuage_extra_dhcp_vm_actions_in_shared_network | Status : SUCCESS ===
ok
test_22_nuage_extra_dhcp_network_actions_in_isolated_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_22_nuage_extra_dhcp_network_actions_in_isolated_network | Status : SUCCESS ===
ok
test_23_nuage_nuage_extra_dhcp_network_actions_in_vpc (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_23_nuage_nuage_extra_dhcp_network_actions_in_vpc | Status : SUCCESS ===
ok
test_24_nuage_extra_dhcp_network_actions_in_shared_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_24_nuage_extra_dhcp_network_actions_in_shared_network | Status : SUCCESS ===
ok
test_25_nuage_extra_dhcp_nic_after_migrate_in_isolated_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_25_nuage_extra_dhcp_nic_after_migrate_in_isolated_network | Status : SUCCESS ===
ok
test_26_nuage_nuage_extra_dhcp_nic_after_migrate_in_vpc (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_26_nuage_nuage_extra_dhcp_nic_after_migrate_in_vpc | Status : SUCCESS ===
ok
test_27_nuage_extra_dhcp_nic_after_migrate_in_shared_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_27_nuage_extra_dhcp_nic_after_migrate_in_shared_network | Status : SUCCESS ===
ok
test_28_nuage_extra_dhcp_deploy_multiple_vms (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_28_nuage_extra_dhcp_deploy_multiple_vms | Status : SUCCESS ===
ok
test_29_nuage_extra_dhcp_allocated_isolated_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_29_nuage_extra_dhcp_allocated_isolated_network | Status : SUCCESS ===
ok
test_30_nuage_extra_dhcp_allocated_vpc (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_30_nuage_extra_dhcp_allocated_vpc | Status : SUCCESS ===
ok
test_31_nuage_extra_dhcp_allocated_shared_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_31_nuage_extra_dhcp_allocated_shared_network | Status : SUCCESS ===
ok
.
.
.
Ran 32 tests in 36921.991s
FAILED (errors=1)
failed_plus_exceptions.txt
results.txt
runinfo.txt
Note: Marvin test failure "test_02_nuage_extra_dhcp_single_nic_in_vpc" is a known issue, and we are investigating it.

@borisstoyanov @DaanHoogland  Is it possible to run CI against this PR?

sure @sgoeminn, please keep in mind that runs the tests in smoke dir.
@blueorangutan package

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1277

@blueorangutan test

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-1669)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30824 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2049-t1669-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_host_annotations.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Test completed. 60 look OK, 3 have error(s)

Test
Result
Time (s)
Test File

test_01_vpc_remote_access_vpn
Failure
66.25
test_vpc_vpn.py

test_04_rvpc_privategw_static_routes
Failure
390.00
test_privategw_acl.py

test_03_vpc_privategw_restart_vpc_cleanup
Failure
213.80
test_privategw_acl.py

test_02_vpc_privategw_static_routes
Failure
194.10
test_privategw_acl.py

test_01_vpc_privategw_acl
Failure
71.97
test_privategw_acl.py

test_05_add_annotation_for_invalid_entityType
Error
0.07
test_host_annotations.py

test_change_service_offering_for_vm_with_snapshots
Skipped
0.00
test_vm_snapshots.py

test_09_copy_delete_template
Skipped
0.02
test_templates.py

test_06_copy_template
Skipped
0.00
test_templates.py

test_static_role_account_acls
Skipped
0.02
test_staticroles.py

test_11_ss_nfs_version_on_ssvm
Skipped
0.02
test_ssvm.py

test_01_scale_vm
Skipped
0.00
test_scale_vm.py

test_01_primary_storage_iscsi
Skipped
0.09
test_primary_storage.py

test_vm_nic_adapter_vmxnet3
Skipped
0.00
test_nic_adapter_type.py

test_03_nic_multiple_vmware
Skipped
1.10
test_nic.py

test_nested_virtualization_vmware
Skipped
0.00
test_nested_virtualization.py

test_06_copy_iso
Skipped
0.00
test_iso.py

test_list_ha_for_host_valid
Skipped
0.02
test_hostha_simulator.py

test_list_ha_for_host_invalid
Skipped
0.02
test_hostha_simulator.py

test_list_ha_for_host
Skipped
0.03
test_hostha_simulator.py

test_hostha_enable_feature_without_setting_provider
Skipped
0.03
test_hostha_simulator.py

test_hostha_enable_feature_valid
Skipped
0.02
test_hostha_simulator.py

test_hostha_disable_feature_valid
Skipped
0.03
test_hostha_simulator.py

test_hostha_configure_invalid_provider
Skipped
0.03
test_hostha_simulator.py

test_hostha_configure_default_driver
Skipped
0.03
test_hostha_simulator.py

test_ha_verify_fsm_recovering
Skipped
0.03
test_hostha_simulator.py

test_ha_verify_fsm_fenced
Skipped
0.06
test_hostha_simulator.py

test_ha_verify_fsm_degraded
Skipped
0.03
test_hostha_simulator.py

test_ha_verify_fsm_available
Skipped
0.02
test_hostha_simulator.py

test_ha_multiple_mgmt_server_ownership
Skipped
0.03
test_hostha_simulator.py

test_ha_list_providers
Skipped
0.02
test_hostha_simulator.py

test_ha_enable_feature_invalid
Skipped
0.02
test_hostha_simulator.py

test_ha_disable_feature_invalid
Skipped
0.02
test_hostha_simulator.py

test_ha_configure_enabledisable_across_clusterzones
Skipped
0.02
test_hostha_simulator.py

test_configure_ha_provider_valid
Skipped
0.02
test_hostha_simulator.py

test_configure_ha_provider_invalid
Skipped
0.03
test_hostha_simulator.py

test_deploy_vgpu_enabled_vm
Skipped
0.04
test_deploy_vgpu_enabled_vm.py

test_3d_gpu_support
Skipped
0.04
test_deploy_vgpu_enabled_vm.py

Even better results then when executed same for https://github.com/apache/cloudstack/pull/1981 , so all errors are known issues. LGTM.


Migration should perhaps enforce non-null for factory overrides

abstract class C<T> {
  T get foo;
  factory C() = D<T>;
}

class D<T> extends C<T> {
  @override
  T get foo => null;
}

Currently we migrate this to
abstract class C<T> {
  T get foo;
  factory C() = D<T>;
}

class D<T> extends C<T?> {
  @override
  T? get foo => null;
}

but we should migrate it to
abstract class C<T> {
  T? get foo;
  factory C() = D<T>;
}

class D<T> extends C<T> {
  @override
  T? get foo => null;
}

This occurs in package:collection.
This is essentially the same as
C<int/*!*/> c = D<int>();

Which implicitly should indicate that D<T> extends C<T> without any nullabilities. That doesn't do that either.

Interestingly, this is crashing when I test this
  NoSuchMethodError: The getter 'declaration' was called on null.
  Receiver: null
  Tried calling: declaration
  dart:core-patch/object_patch.dart 53:5                              Object.noSuchMethod
  package:nnbd_migration/src/edge_builder.dart 211:35                 EdgeBuilder.getOrComputeElementType
  package:nnbd_migration/src/edge_builder.dart 585:26                 EdgeBuilder.visitConstructorFieldInitializer
  package:analyzer/src/dart/ast/ast.dart 2647:15                      ConstructorFieldInitializerImpl.accept
  package:analyzer/src/dart/ast/ast.dart 7518:20                      NodeListImpl.accept
  package:nnbd_migration/src/edge_builder.dart 1925:21                EdgeBuilder._handleExecutableDeclaration
  package:nnbd_migration/src/edge_builder.dart 567:5                  EdgeBuilder.visitConstructorDeclaration
  package:analyzer/src/dart/ast/ast.dart 2562:15                      ConstructorDeclarationImpl.accept
  package:analyzer/src/dart/ast/ast.dart 7518:20                      NodeListImpl.accept
  package:nnbd_migration/src/edge_builder.dart 500:15                 EdgeBuilder.visitClassOrMixinOrExtensionDeclaration
  package:nnbd_migration/src/edge_builder.dart 474:7                  EdgeBuilder.visitClassDeclaration
  package:analyzer/src/dart/ast/ast.dart 1519:49                      ClassDeclarationImpl.accept
  package:analyzer/src/dart/ast/ast.dart 7518:20                      NodeListImpl.accept
  package:analyzer/src/dart/ast/ast.dart 2102:21                      CompilationUnitImpl.visitChildren
  package:analyzer/dart/ast/visitor.dart 442:10                       GeneralizingAstVisitor.visitNode
  package:nnbd_migration/src/utilities/permissive_mode.dart 45:20     PermissiveModeVisitor.visitNode
  package:analyzer/dart/ast/visitor.dart 199:51                       GeneralizingAstVisitor.visitCompilationUnit
  package:nnbd_migration/src/utilities/annotation_tracker.dart 37:24  AnnotationTracker.visitCompilationUnit.<fn>
  package:nnbd_migration/src/utilities/permissive_mode.dart 31:15     PermissiveModeVisitor.reportExceptionsIfPermissive
  package:nnbd_migration/src/utilities/annotation_tracker.dart 29:5   AnnotationTracker.visitCompilationUnit
  package:analyzer/src/dart/ast/ast.dart 2095:49                      CompilationUnitImpl.accept
  package:nnbd_migration/src/nullability_migration_impl.dart 140:10   NullabilityMigrationImpl.processInput

As of 1c7fe7196dd7a542f7f91cd6ea2ac81e1a13146c, the null safety migration tool has been removed from active development and retired. No further work on the tool is planned.
If you still need help, or you believe this issue has been closed in error, please feel free to reopen.


Add Border and CornerRadius components to bevy_ui

Objective

Add a simple set of components to change the visual appearance of UI nodes borders, while introducing as few changes to the actual state of bevy_ui as possible.

I know that bevy_ui will be changed to reflect requirements for the bevy editor, so I tried to make this in a way that it may still be useful if the implementation of UI layout and rendering were to change.
My personal objective with this PR was to make a simple change while getting to know more about some bevy internals.
Solution
Two new components were added. These can be added to any ui node to enable the features on them. No existing component was changed.
New components
BorderRadius
Similarly to CSS's border-radius property, this component describes a set of 4 radii, in pixels, one for each corner. This allows making a lot of different basic widget shapes without relying on textures.
Border
Similarly to CSS's border property, this component describes a width (thickness) and a color to be given to this component's border.
I was not successful at implementing border radius with a variable border width for each side of the rect. If that was supported, then it may be smarter use the Style.border field instead for the width and to replace this with a simple BorderColor component.
UI Renderer changes
Changes were made to the bevy_ui renderer to support this, including changes to ui.wgsl where the magic happens.
At the moment of starting this as a draft, all of the data used to render the borders is sent via the vertex buffer. This is not optimal at all since it triples the amount of data sent for each vertex.
If there's interest, I'd like to look into storing this information into a uniform buffer instead. This would greatly reduce the amount of data stored and uploaded to the GPU, but will add a little more complexity to the rendering code, especially since it would need to support batching.
Examples changes
UI Example
Changes were made to the "ui" example to show that you don't need an extra node to render borders anymore since you can use the Border component. Here's a close-up comparison of before and after on that example (they're the same result).

Button Example
Changes were made to the "button" example to showcase both Border and BorderRadius components.

@oceantume can you resolve the comments that you've addressed on this PR so it's easier for reviewers to follow what still needs to be done? :)

@oceantume I would create a BorderSide struct which contains a width and a color and then I would use pub border_side: Option<[BorderSide; 4]> just above the corner_radius. This way is much more customizable.

I clicked the close button by accident😬
@cometflaretech I haven't been able to successfully implement 4 different borders in the shader code, so this wouldn't be possible at the moment. If you have some suggestions on that side I would love to have them. I tried a few things but I couldn't get the maths to actually make sense. This would be something that could be added after, when I or someone else figure it out.

I just pushed a commit that adds uniform buffer support. Here are a few notes on what I think could be the next steps done in follow-up PR's:
I think the extraction UI node extraction system could use a small refactor to be more similar to the sprite extraction, at least in how the loop and batching works. There's also a last_z value in the current loop that isn't used for anything after extraction.
At the moment, the ui.wgsl shader is also used for the text nodes but they don't need borders or rounded corners, so we could look into removing that overhead for text, maybe by using the shader preprocessor. However, I don't think this is a blocker because the code is pretty simple and the overhead is likely small.
Finally, border width and color for individual borders is not supported at the moment and could be very useful. I failed at getting the maths right for this (especially because it needs to work with border radius), but I'm down to look into it again soon.

If radius is 0, we can skip calculating the distance.

If radius is 0, we can skip calculating the distance.

Distance is also used for border color, but your point still stands if we check for both. The tradeoff is that we'll be adding branching to the fragment shader. I'll look into adding this.

Hey @oceantume I'm just a random user that want's to see this merged. It looks like this is pretty out of date with main. Would you be able to update this so it has a better chance of being merged?
Looks to me to be the only thing holding this up, lmk if there is something else. I'd be willing to take a stab at updating it if you aren't able to.

I have a feeling this wasn't merged because it made a lot of changes to the pipeline and shaders.
I don't have time to update it at this moment (I'm moving in 5 days), but I'd be willing to look into it. However, I wouldn't be surprised if Cart didn't want to merge it before seeing if there's a better way to implement the pipeline changes for this.

Sounds good, thanks for the update. I'll probably leave it alone then, pipeline decisions are going to be bit over my head still. If someone can confirm we don't need changes to the approach lmk and I might be able to get what you already had working.

By adding a new Border component outside of the existing Style component, this border width won't be used for the layout and will overlap neighbour nodes

My preferred fix would be to strip the border field from Style, and then populate taffy's version internally during the interface. This information is distinct, and belongs in its own component (so then we can do things like reuse the component for sprites).

the border from style is a lot more reach than a f32 from this PR, and that would mean handling all those cases for rounded corners

By adding a new Border component outside of the existing Style component, this border width won't be used for the layout and will overlap neighbour nodes

I think we should hold off on this until we have figured out #5511, then we should look into whether it makes sense to populate the new border component with field required for border rendering (or if they should be entirely separate)

Just wanted to note that work on #5511 is now on hold and as such this PR is not blocked. Regarding the API, I think the existing border property in Style should be renamed to border_width and either:

border_color and border_radius properties added directly to Style
or
border_width should be moved to the new Border component alongside the border_color and border_radius properties.

I do think ideally this would support setting different widths for each side. It should also support corner clips that extend beyond the border and into the main content region if that is not already supported.
Finally, it should also be noted that there is an implemention for borders without radii in #7795 which could potentially be combined with this work.
@oceantume Do you have time to update this and drive it towards being merged?

Just wanted to note that work on #5511 is now on hold and as such this PR is not blocked. Regarding the API, I think the existing border property in Style should be renamed to border_width and either:
* `border_color` and `border_radius` properties added directly to `Style`
  or

* `border_width` should be moved to the new `Border` component alongside the `border_color` and `border_radius` properties.

I do think ideally this would support setting different widths for each side. It should also support corner clips that extend beyond the border and into the main content region if that is not already supported.
Finally, it should also be noted that there is an implemention for borders without radii in #7795 which could potentially be combined with this work.
@oceantume Do you have time to update this and drive it towards being merged?

I have ported the PR code to 0.11.0, over at my Bevy fork here
https://github.com/project-flara/bevy/tree/ui-renderer-0.11.0

Hi, I would check with Bevy members before putting too much work into this. If I remember correctly this was blocked for a long time and semi-declined because of the amount of renderer code required to make it work.
There's also a good question of whether this is really how it should be done, especially the "fake anti aliasing" done in the shader.

Border radius was added in #12500.


test_eligible_kegs_for_cleanup fails on Ubuntu 15 (wily)

❯❯❯ brew tests TEST=test_formula
  1) Failure:
FormulaTests#test_formula [/home/ubuntu/.linuxbrew/Library/Homebrew/test/test_formula.rb:365]:
--- expected
+++ actual
@@ -1,2 +1,2 @@
 [#<Keg:/tmp/homebrew_tests20160307-2788-v2f8tf/cellar/testball/0.2>,
- #<Keg:/tmp/homebrew_tests20160307-2788-v2f8tf/cellar/testball/0.3>]
+ #<Keg:/tmp/homebrew_tests20160307-2788-v2f8tf/cellar/testball/0.1>]
❯❯❯ ruby --version
ruby 2.1.5p273 (2014-11-13) [x86_64-linux-gnu]
❯❯❯ brew config
HOMEBREW_VERSION: 0.9.5
ORIGIN: https://github.com/Homebrew/linuxbrew
HEAD: a9d5ee6ec13ff99f1f4a7b73a0417274ea374107
Last commit: 13 hours ago
HOMEBREW_PREFIX: /home/ubuntu/.linuxbrew
HOMEBREW_REPOSITORY: /home/ubuntu/.linuxbrew
HOMEBREW_CELLAR: /home/ubuntu/.linuxbrew/Cellar
HOMEBREW_BOTTLE_DOMAIN: https://linuxbrew.bintray.com
CPU: dual-core 64-bit haswell
Kernel: Linux 4.2.0-30-generic x86_64 GNU/Linux
OS: Ubuntu 15.10
Codename: wily
OS glibc: 2.21
OS gcc: 5.2.1
Linuxbrew glibc: N/A
Linuxbrew gcc: 5.3.0
Clang: N/A
X11: 2.7.8 => /usr
System Ruby: 2.1.5 => /usr/bin/ruby2.1
Perl: /usr/bin/perl
Python: /usr/bin/python => /usr/bin/python2.7
Ruby: /usr/bin/ruby => /usr/bin/ruby2.1
Java: N/A

@DoomHammer I've seen this test failure now too on Ubuntu 15.10 with Ruby 2.1.5p273. Where did you see this error?

sjackman/linuxbrew Docker image with System Ruby: 2.3.0 => /home/linuxbrew/.linuxbrew/Cellar/ruby/2.3.0/bin/ruby

https://github.com/Linuxbrew/linuxbrew/blob/master/Library/Homebrew/test/test_formula.rb#L365
p f3.installed_kegs, f3.eligible_kegs_for_cleanup
assert_equal f3.installed_kegs[0..1], f3.eligible_kegs_for_cleanup

[#<Keg:/tmp/homebrew_tests20160307-25418-1w2960h/cellar/testball/0.2>, #<Keg:/tmp/homebrew_tests20160307-25418-1w2960h/cellar/testball/0.3>, #<Keg:/tmp/homebrew_tests20160307-25418-1w2960h/cellar/testball/0.1>]

[#<Keg:/tmp/homebrew_tests20160307-25418-1w2960h/cellar/testball/0.2>, #<Keg:/tmp/homebrew_tests20160307-25418-1w2960h/cellar/testball/0.1>]

Failure:
FormulaTests#test_eligible_kegs_for_cleanup [/home/ubuntu/.linuxbrew/Library/Homebrew/test/test_formula.rb:366]:
--- expected
+++ actual
@@ -1,2 +1,2 @@
 [#<Keg:/tmp/homebrew_tests20160307-25418-1w2960h/cellar/testball/0.2>,
- #<Keg:/tmp/homebrew_tests20160307-25418-1w2960h/cellar/testball/0.3>]
+ #<Keg:/tmp/homebrew_tests20160307-25418-1w2960h/cellar/testball/0.1>]

The question seems to be, in what order are the elements returned by installed_kegs supposed to be?

The directories returned by installed_kegs are in the ordered returned by Pathname::children, which is arbitrary and determined by the operating system and file system.

Here are two possible fixes, one using sort and the other using Set.
diff --git a/Library/Homebrew/test/test_formula.rb b/Library/Homebrew/test/test_formula.rb
index e571f56..0940ef4 100644
--- a/Library/Homebrew/test/test_formula.rb
+++ b/Library/Homebrew/test/test_formula.rb
@@ -362,7 +362,10 @@ class FormulaTests < Homebrew::TestCase
     assert_predicate f2, :installed?
     assert_predicate f3, :installed?

-    assert_equal f3.installed_kegs[0..1], f3.eligible_kegs_for_cleanup
+    assert_equal [Keg.new(f1.prefix), Keg.new(f2.prefix)],
+      f3.eligible_kegs_for_cleanup.sort {|a,b| a.version <=> b.version}
+    assert_equal Set.new([Keg.new(f1.prefix), Keg.new(f2.prefix)]),
+      Set.new(f3.eligible_kegs_for_cleanup)
   ensure
     [f1, f2, f3].each(&:clear_cache)
     f3.rack.rmtree

Fixed!

Confirmed!


multiple range versions don't resolve correctly

[x] I've read the CONTRIBUTING guidelines

steps

Create new project: sbt new scala/scala-seed.g8
Add following dependency: libraryDependencies += "org.webjars.npm" % "loose-envify" % "1.4.0"
Compile the project: sbt compile

problem
The library is not resolved:
[info] Updating ...
[warn]  module not found: org.webjars.npm#js-tokens;[3.0.0,4),[4.0.0,5)
[warn] ==== local: tried
[warn]   C:\Users\razvan.rotaru\.ivy2\local\org.webjars.npm\js-tokens\[3.0.0,4),[4.0.0,5)\ivys\ivy.xml
[warn] ==== public: tried
[warn]   https://repo1.maven.org/maven2/org/webjars/npm/js-tokens/[3.0.0,4),[4.0.0,5)/js-tokens-[3.0.0,4),[4.0.0,5).pom
[warn] ==== local-preloaded-ivy: tried
[warn]   C:\Users\razvan.rotaru\.sbt\preloaded\org.webjars.npm\js-tokens\[3.0.0,4),[4.0.0,5)\ivys\ivy.xml
[warn] ==== local-preloaded: tried
[warn]   file:/C:/Users/razvan.rotaru/.sbt/preloaded/org/webjars/npm/js-tokens/[3.0.0,4),[4.0.0,5)/js-tokens-[3.0.0,4),[4.0.0,5).pom
[info] downloading https://repo1.maven.org/maven2/org/scalatest/scalatest_2.12/3.0.5/scalatest_2.12-3.0.5.jar ...
[info] downloading https://repo1.maven.org/maven2/org/scalactic/scalactic_2.12/3.0.5/scalactic_2.12-3.0.5.jar ...
[info]  [SUCCESSFUL ] org.scalactic#scalactic_2.12;3.0.5!scalactic_2.12.jar(bundle) (1309ms)
[info]  [SUCCESSFUL ] org.scalatest#scalatest_2.12;3.0.5!scalatest_2.12.jar(bundle) (3490ms)
[warn]  ::::::::::::::::::::::::::::::::::::::::::::::
[warn]  ::          UNRESOLVED DEPENDENCIES         ::
[warn]  ::::::::::::::::::::::::::::::::::::::::::::::
[warn]  :: org.webjars.npm#js-tokens;[3.0.0,4),[4.0.0,5): not found
[warn]  ::::::::::::::::::::::::::::::::::::::::::::::
[warn]
[warn]  Note: Unresolved dependencies path:
[warn]          org.webjars.npm:js-tokens:[3.0.0,4),[4.0.0,5)
[warn]            +- org.webjars.npm:loose-envify:1.4.0 (D:\imis\sbttest\sbttest\build.sbt#L13)
[warn]            +- com.example:sbttest_2.12:0.1.0-SNAPSHOT

The problem seems to be the presence of two version ranges in the dependency list of loose-envify:
	<dependencies>
		<dependency org="org.webjars.npm" name="js-tokens" rev="[3.0.0,4),[4.0.0,5)" force="true" conf="compile->compile(*),master(compile);runtime->runtime(*)"/>
	</dependencies>

expectation
The project is compiled and a version of js-tokens is downloaded.
https://repo1.maven.org/maven2/org/webjars/npm/js-tokens/3.0.2/js-tokens-3.0.2.pom
notes
sbt version: 1.1.6

Thanks for the report with repo steps!

It was reported before: https://github.com/sbt/sbt/issues/2647

@tarsa Thanks for that list. I am going through a bunch of issues, and this is helpful.

This works using sbt 1.3.0-RC3, which uses Coursier internally.


Atom will blink at startup when enable console-panel.

When enable console-panel package, atom will blink every time at start up.
Atom version: 1.12.6.
System version: macos Sierra 10.12.2 (16C67).
console-panel: 0.2.0

After updated to console-panel: 0.2.1, this issue never shows.


Remove bad practices from ReadMe

From https://github.com/debug-js/debug/issues/786#issuecomment-1059397551
Requested by @jimmywarting and @Qix-
This removes difficult to use ES5 conventions and prepares us for v5. As someone who started using Node after ES6 with ESM as much as possible, the code and the readme was hard to read.
ps your issue template is 5 years old and not particularly relevant today.

there is quite many more chains of require calls in the readme

there is quite many more chains of require calls in the readme

do you have merge access?

there is quite many more chains of require calls in the readme

do you have merge access?

no

ps your issue template is 5 years old and not particularly relevant today.

You're right, I'll remove it. Thanks for the reminder :) The issue template about trash comments is also no longer relevant now that Github removed its "how to Github" courses that referred to this repository for some reason, encouraging people to post nonsense comments and issues.

As for the changes, it's all good, but you're missing the http import now. If you add it I'll merge this, though fair warning it won't show up on npm's site, just the repository for now, as it requires a release to do so, which is more of a religious ritual than it is a simple process given the fallout whenever a release for debug is cut.

Sorted. Sorry, I made the original PR in a rush to check for a pulse when destructuring Debug was causing unexpected results.
Anyways I added a note or two about ESM. I tested it using esmoduleinterop on and off.
https://stackblitz.com/edit/pr-debug-pseudo-esm?file=tsconfig.node.json,vite.config.ts&terminal=dev
I could have used the far more minimal vite.new/vanilla-ts but old habits die hard.


Feature request: Option to only stream back complete results as one message

I use folke/noice.nvim which will display messages as pop-ups as they come in, and only opt for a split based on rules about the size of the message received (e.g. If a message is longer than 20 lines, open in a split buffer etc). I think this presents problems with the way bang commands to mods return messages, as they stream back in chunks it looks like to me? Would love to have a --no-stream boolean flag or something along those lines to wait and only return the message as a single chunk, optionally, when all the tokens have been collected.

In the meantime, if anybody else has issues with this, you can pipe your vim command to glow and it will return as a single message.


Made the navbar collapsible

And updated the nav items centered on small viewports as they looked ugly.
This fixes #5

@RakshithNM Please include a screenshot of the changes if possible!

Good Work @RakshithNM , looks fine to me, We will wait for review from @pvgupta24 and then merge!
Thanks for Contributing!


Add solution to Exact Change

Adds solution to the updated Exact Change.
Tested Locally.

Tested. LGTM


[Class modifiers] Implement feature in the CFE

Quick update for the CFE work:
All the work here is done except It is a compile-time error if a subtype of a declaration marked base or final is not marked base, final, or sealed which is the last loophole I need to close. Otherwise, everything functions as the spec expects.

The one last loophole landed as of today. Done all necessary work in CFE.

Thanks @kallentu


Variable not defined in parse_etc_password

Multiple references to undefined variable rhel8cis_passwd_tasks

Thanks for pointing that out, the fix will be in the next release.


Implement Floordiv for SQL

Ensure that Math functions operate as expected in SQL
Also implement floor division using a combination of floor and division.  This enables truncation operations in SQL.

@mrocklin can you rehash and push when you get a chance? i think we can get this in


Recommend a LLM bot building repo: Embedchain

Found your compilation list very useful.
Recently have been using this helpful OpenSource repo to build ChatGPT like bots; it requires very less coding and could help people.
Embedchain:
https://github.com/embedchain/embedchain

Have tried to address this via this PR: "update: LLM Ops with embedchain #89"
Happy to help contribute to this repo.

Thanks for your contribution! :tada: :+1:
I merged the PR, am closing this issue.


Cleanup Http2Stream

This PR includes commit for #3091. I'm going to rebase this PR when #3091 is merged.
Please review b9b2961 for this PR.

Rebased on latest master branch.

Hmmm, slightly confused now, does this go to master, or 7.1.x, or both ?

Both. For 7.1.x, I'll add this to #3096 (back port request of #3091)

This has 3 changes. Description is added.

Remove return value of Http2Stream::update_write_request(). Because return value is not used in most cases. And Http2Stream::do_io_write() can always return &write_vio where only the return value is used.
Http2Stream::update_write_request() returns immediately if there're no data to proceed
Make Http2Stream::send_response_body() private


sidebar - submenu may be cropped due to small height (fix)

@fichtner ready for testing and by the way....
i need a pro (like you or fabian) or someone else who can optimize the jquery code because it´s memory usage.
Perhaps @fabianfrz can help?
i did my best and I like to learn!

@fichtner Submenus now open upwards if the space down is not sufficient.

@fichtner i found a main bug and will repost this again in the next days....sorry :-(


[$250] Android - Chat - App crashes when selecting the :cat: emoji from the suggestions

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.27-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4910664
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause Internal Team
Action Performed:

Go to any 1-1 chat and type a few lines of text
On a new line type :ca
From the suggestions selected the :cat: emoji type a bit more (in case of not reproduction repeat with another of the cat emoji seems that it's always the same that causes it)

Expected Result:
The emoji is added without issues
Actual Result:
The app crashes
Workaround:
Unknown
Platforms:

[x] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/8681c035-a61a-4667-8ca6-ee610622f6e3
3108.txt

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021831333721421385965
Upwork Job ID:<PHONE_NUMBER>421385965
Last Price Increase: 2024-09-04

Issue OwnerCurrent Issue Owner: @allroundexperts

@JmillsExpensify  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Opened this up to the community to see what they think.

I want to give it a try. May I?

I am sorry, I thought it is a Kotlin Android App.

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: link
Proposal
Please re-state the problem that we are trying to solve in this issue.
Fix a bug where app crashes after entering a cat emoji in the chat.
What is the root cause of that problem?
I suspect there is a String parsing problem (unsupported chars for example) somewhere in the process of posting the message to the API endpoint. This causes the exception that is not handled which crashes the app.
What changes do you think we should make in order to solve the problem?
Implement proper support for all characters.

@allroundexperts what do you think about the proposals so far? If none are satisfactory, I could also see us just closing this issue as low priority.

@allroundexperts what do you think about the proposals so far? If none are satisfactory, I could also see us just closing this issue as low priority.

None of them look good enough to me.

not reproducible for me

Going to close for focus.


feat: NNS1-2346: Added propose_sns.sh.

Closes NNS1-2346.

I've reviewed your MR and left some comments.

Woops. Accidentally closed. I don't use Github very much -> I got confused.

LGTM, but please consider the comments regarding participate_sns_swap.sh before you merge.


If you have global settings, you loose all friendly names

If you define:
sensor.system_fritzbox:
   friendly_name: "FRITZ!Box Router"
   icon: mdi:router-wireless

And
powercalc:
  scan_interval: 00:01:00

sensor:
  - platform: powercalc
    entity_id: sensor.system_fritzbox
    fixed:
      power: 9.8

Device name to pick in energy dashboard:
FRITZ!Box Router energy

becomes:
sensor.system_fritzbox_energy

see #108. please try my suggestion and see if this helps. I think this lines can be safely removed, but I need to do some further testing.

Unfortunately I am unable to reproduce this issue.
I have setup a input boolean, and customized the friendly name:
sensor:
  - platform: powercalc
    entity_id: input_boolean.friendlyname_test
    fixed:
      power: 50

input_boolean:
  friendlyname_test:
    name: friendlyname test

homeassistant:
  customize:
    input_boolean.friendlyname_test:
      friendly_name: "My friendly name"

Created entities look correct to me:

See the powercalc energy entity in this screenshot on the bottom:

@bramstroker this is exactly what I mean.
With this config you would expect that "friendlyname test energy" is called "My friendly name energy"
This is the case if you don't have a global  "powercalc:" section in the config, with it you get this behavior.
At least that's what I see here, I maybe have overlooked something obvious though.
Btw it would also be nice if the global naming template "Verbruik {}" would work on friendly name instead of raw device name.

See #116 for the work in progress. Not sure if this changes has unwanted side effects. So need extensive testing before releasing to the public.

Just did a lot of cleanups and refactoring and issued first beta. v0.5.0-beta.1.
Are you able to test with this version and let me know your findings?

Yes will do and let you know, thanks!

I don't think it fixes this problem.
It worked one time, but not consistent, no idea what is going on yet.
So with a global section powercalc: with only refresh rate you look friendly names of all sensors
Also entity_naming "{} verbruik" works
But "Verbruik {}" is not allowed (invalid config)

@cyberjunky
I need some more information to get a grip of what's going on.
Which exact version of powercalc are you testing now?
There should be no difference when you have global section powercalc enabled or not.
Could you please enable debug logging?
Than share you configuration, the logs after starting home assistant and maybe a screenshot of the entities created by Powercalc.
It will also make things easier when you comment out all powercalc sensors except one.

yeah I know, and will do, I write components myself and know how frustrating it is hen people don't give info, this was just a heads up that something strange is going on.
But I can 100% reproduce the powercalc: issue if you only specify the scan_interval.

I'm running 0.5.0-beta2
Unpacked the zip inside custom_components/powercalc/
Scenario #1
This config:
homeassistant:
  customize:
    sensor.system_fritzrepeater:
      friendly_name: "FRITZ!Repeater"
      icon: mdi:router-wireless

sensor:
  - platform: powercalc
    entity_id: sensor.system_fritzrepeater
    fixed:
      power: 5.5

Developer view sensor.system_fritzrepeater attributes:
state_class: measurement
last_reset: '2021-08-23T08:36:50.587227+00:00'
source: sensor.fritz_repeater_power
source_entity: sensor.system_fritzrepeater
source_domain: sensor
unit_of_measurement: kWh
friendly_name: FRITZ!Repeater energy
icon: mdi:lightning-bolt
device_class: energy

Log:
2021-08-28 14:17:15 DEBUG (MainThread) [custom_components.powercalc.sensor] Setting up power sensor. entity_id:sensor.system_fritzrepeater sensor_name:FRITZ!Repeater power strategy=FixedStrategy manufacturer= model= standby_usage=None
2021-08-28 14:17:15 DEBUG (MainThread) [custom_components.powercalc.sensor] Creating energy sensor: FRITZ!Repeater energy
...
2021-08-28 14:17:24 DEBUG (MainThread) [custom_components.powercalc.sensor] State changed to "Online" for entity "sensor.system_fritzrepeater". Power:5.5

So friendly_name is fine! All good.
Scenario #2:
This config (i want a scan_interval of 1min) rest same as above:
homeassistant:
  customize:
    sensor.system_fritzrepeater:
      friendly_name: "FRITZ!Repeater"
      icon: mdi:router-wireless

powercalc:
  scan_interval: 00:01:00

sensor:
  - platform: powercalc
    entity_id: sensor.system_fritzrepeater
    fixed:
      power: 5.5

Developer view sensor.system_fritzrepeater attributes:
state_class: measurement
last_reset: '2021-08-23T09:32:38.588985+00:00'
source: sensor.system_fritzrepeater_power
source_entity: sensor.system_fritzrepeater
source_domain: sensor
unit_of_measurement: kWh
friendly_name: system fritzrepeater energy
icon: mdi:lightning-bolt
device_class: energy

Log:
2021-08-28 14:26:12 DEBUG (MainThread) [custom_components.powercalc.sensor] Setting up power sensor. entity_id:sensor.system_fritzrepeater sensor_name:system fritzrepeater power strategy=FixedStrategy manufacturer= model= standby_usage=None
2021-08-28 14:26:12 DEBUG (MainThread) [custom_components.powercalc.sensor] Creating energy sensor: system fritzrepeater energy
..
2021-08-28 14:26:16 DEBUG (MainThread) [custom_components.powercalc.sensor] State changed to "Online" for entity "sensor.system_fritzrepeater". Power:5.5

So you see it now creates the energy sensor without the friendly name.
You have to be able to reproduce this with this info.
I will address the energy_nameing config issue in a separate issue.

@cyberjunky you are sure you are using the beta version 0.5.0-beta.1 of 0.5.0-beta.2?
Fixes are not in master yet.

in custom_components
i did wget https://github.com/bramstroker/homeassistant-powercalc/releases/download/v0.5.0-beta.2/powercalc.zip
mkdir powercalc
cd powercalc
unzip ../powercalc.zip
and rebooted

Thanks for the useful information. Pretty sure I will be able to reproduce this now.
Not sure when I can have another look. Maybe I can find some time tomorrow. Will keep you updated.

Unfortunately I am unable to reproduce yet.
The friendly name of the source entity sensor.system_fritzrepeated is retrieved from the state machine of Home Assistant. In your case the state of the entity was not available and powercalc will fall back to extract the name from the entity_id.
When the integration which created sensor.system_fritzrepeated was not loaded before powercalc plartform, the state can not be retrieved, so that would potentially be the problem.
Which integration did create sensor.system_fritzrepeated?

Wait, this could be the cause, those are template sensors from device_trackers to translate home/away to on/off or online/offline.
sensor:
  - platform: template
    sensors:
      system_laptopwerk:
        value_template: "{{ 'on' if is_state('device_tracker.laptopwerk', 'home') else 'off' }}"
      system_printerlj3600:
        value_template: "{{ 'on' if is_state('device_tracker.printerlj3600', 'home') else 'off' }}"
      system_fritzbox:
        value_template: "{{ 'Online' if is_state('device_tracker.fritzbox', 'home') else 'Offline' }}"
      system_fritzrepeater:
        value_template: "{{ 'Online' if is_state('device_tracker.fritzrepeater', 'home') else 'Offline' }}"

I read that you support device_trackers directly now I think correct?

Yes device trackers are directly supported. Only in beta version yet.
For the template sensor to work could you please try adding template to manifest.json dependencies?

Yes this fixed the issue, great!

Yeah! I will incoorporate the fix in the next beta.

Just released v0.5.0-beta.3. Could you do a final check if everything works for you in this version? Than we can close this issue.

I downloaded the 0.5.0-beta3 zip
It doesn't work, it seems you forgot to insert the dependency for template?

Made a mistake. Did create the beta releases from wrong branch master. Removed the releases and created new one from beta now v0.5.0-beta.3, which also includes the fix for #145

Yes working like a charm, the regex and template issue solved, thanks alot, you save me code something like this!

cool! Closing this issue now. all these changes will be available in v0.5.0


webpack.test.conf.js is not needed in jest and e2e

As titled.

That's correct, good catch, thanks.


Creating tmpenv without spec

Presumably creating a tmpenv without spec is not supposed to be allowed. It fails if you try:
$ conda tmpenv create
Traceback (most recent call last):
  File "/miniconda3/bin/conda-tmpenv", line 11, in <module>
    load_entry_point('conda-execute==0.7.0', 'console_scripts', 'conda-tmpenv')()
  File "/miniconda3/lib/python3.5/site-packages/conda_execute/tmpenv.py", line 249, in main
    exit(args.subcommand_func(args))
  File "/miniconda3/lib/python3.5/site-packages/conda_execute/tmpenv.py", line 184, in subcommand_create
    r = create_env(specs, force_recreation=args.force)
  File "/miniconda3/lib/python3.5/site-packages/conda_execute/tmpenv.py", line 96, in create_env
    with open(os.path.join(env_locn, 'conda-meta', 'execution.log'), 'a'):
FileNotFoundError: [Errno 2] No such file or directory: '/miniconda3/tmp_envs/e3b0c44298fc1c149afb/conda-meta/execution.log'

Relates to #28

I'm not sure the Travis test failures are due to my change, the test passes for me locally.

Any thoughts on this @pelson?

Doesn't look like something you have done to Travis. This is an issue I saw the other day too - suspect there has been a change to the lock mechanism within conda that changes the contract and that we must now pre-create the directory that the lock lives within...
If you are interested in taking a look at that in another PR, just let me know. Otherwise, I'll try to fix it before I cut a release with these changes in.
P.S. Sorry for the delay - I've been a bit swamped lately, so you definitely did the right thing pinging me.
👍

Thanks for pulling that in!

This landed in v0.8. Thanks for your contribution! 👍


ztress: Use XOSHIRO rng generator when entropy device is present

Test environment does not require true RNG and true RNG may have limitations (e.g., sys_rand32_get() cannot be called from an interrupt context).
Updating ztress to force XOSHIRO when possible. It required update in random subsystem configuration to allow forcing default generator.

Codecov Report

Merging #49718 (8c1efa8) into main (e6d7118) will increase coverage by 0.20%.
The diff coverage is 50.27%.

:exclamation: Current head 8c1efa8 differs from pull request most recent head 5b04bb7. Consider uploading reports for the commit 5b04bb7 to get more accurate results

@@            Coverage Diff             @@
##             main   #49718      +/-   ##
==========================================
+ Coverage   47.56%   47.77%   +0.20%
==========================================
  Files         514      517       +3
  Lines       73157    74033     +876
  Branches    17563    17783     +220
==========================================
+ Hits        34798    35366     +568
- Misses      32429    32583     +154
- Partials     5930     6084     +154

Impacted Files
Coverage Δ

include/zephyr/net/ethernet.h
51.28% <ø> (ø)

kernel/timer.c
95.83% <ø> (ø)

drivers/can/can_shell.c
49.47% <50.13%> (ø)

include/zephyr/sys/cbprintf.h
95.83% <100.00%> (ø)

subsys/net/ip/connection.c
60.50% <0.00%> (-3.42%)
:arrow_down:

kernel/device.c
90.38% <0.00%> (-1.93%)
:arrow_down:

subsys/net/ip/net_stats.h
43.66% <0.00%> (-1.41%)
:arrow_down:

subsys/net/ip/net_core.c
62.50% <0.00%> (-0.47%)
:arrow_down:

subsys/bluetooth/controller/ll_sw/isoal.c
51.10% <0.00%> (-0.19%)
:arrow_down:

subsys/net/lib/lwm2m/lwm2m_registry.c
21.27% <0.00%> (-0.17%)
:arrow_down:

... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6d7118...5b04bb7. Read the comment docs.


feat(sortable): module

This PR contains implementation of d&d sortable list, at the moment it supports:

ngModel
drag&drop between different instances of the component
styles for container, items, active item
items list could be either string[] or object[] (fieldName should be provided in that case)
animation of item insertion/removing

Unfortunately I haven't found any information about contribution rules, if it is necessary to create some demo etc. please notify me

Current coverage is 83.81% (diff: 100%)

Merging #1295 into development will not change coverage

@@           development      #1295   diff @@
=============================================
  Files               53         53
  Lines             1656       1656
  Methods              7          7
  Messages             0          0
  Branches           227        227
=============================================
  Hits              1388       1388
  Misses             189        189
  Partials            79         79

Powered by Codecov. Last update 92e3ba5...75b634f

Awesome!
Can you please rename to simply sortable?

@valorkin I have added docs and tests
but there is a problem with build and I don't think that it is because of my commit, could you take a look?

@valorkin I fixed tests with pagination module (set _page = 1 by default, it was undefined by default in tests and noPrevious() method returned false because of it), so now it seems there is no blocker from CI side

This is huge!!! Let me get to this
@SergeyKuryatnick check this out

@valorkin ping, just to remind :)

hey, I remember it! ;)
check new structure of src folder and how it is now published
<EMAIL_ADDRESS>almost ready to more not core bootstrap modules

actually docs left...
and publish new small version https://github.com/valor-software/ng2-bootstrap/pull/1328

This is huge!

I am actually ready to merge...
;)
drop me a note in https://ngx-slack.herokuapp.com/
and we will go through it


Parsing quirks with fsdoc

I'm using F* version <IP_ADDRESS> with Z3 4.5.1 (from FStarLang/binaries/z3-tested/).
fstar --doc Test.fst crashes on a simple (see below) program with the following error message:
Unexpected error; please file a bug report, ideally with a minimized version of the source program that triggered the error.
FStar_Ulexing.Error

This is the Test module:
module Test

type test =
  | (** Some test *) Test

According to the wiki, a comment at that position should be fine - and in any case, FStar shouldn't crash but output a syntax error.
Edit:
However, it does not crash on this module (note the newline after the fsdoc comment):
module Test

type test =
  | (** Some test *)
  Test

Pasting some (redacted) discussion from Slack for posterity
nik [1 day ago]
- @adl will revise the marker for --fsdoc so that it is less easy to trigger inadvertently.

adl [23 hours ago]
https://github.com/FStarLang/FStar/compare/adl_fsdoc_update

nik [16 hours ago]
@adl @protz: the change to use /** as the fsdoc delimiter looks reasonable to me, although during the meeting, Jonathan pointed out that /* is a potential infix operator (and so /** too?)

protz  [16 hours ago]
probably we won't be able to use /** as an operator

protz  [16 hours ago]
but that's ok, we can always use /***

adl [16 hours ago]
I checked that no module is using the /** operator yet
￼￼￼￼
protz  [16 hours ago]
I'm almost disappointed that no one had the creativity to use it :exploding_head:

guido [16 hours ago]
I'm fine with the change, but we should keep in mind we are not the only ones using F*

nik [15 hours ago]
this change also requires a change to fstar-mode.el, the linguist syntax etc. to recognize /** */ as a comment delimitter (edited)

nik [15 hours ago]
so, maybe something more compatible with the existing comment notation is less disruptive  (*:doc ?

guido [15 hours ago]
I would prefer that. And we could conceivably ignore them as comments unless --doc is given, so users do not get unexpected errors?

See also #1562

We've removed fsdoc in favor of fstardoc #1939.


Passing abfs as fs parameter to UPath fails.

Hi fsspec / universal_pathlib team,
I am trying to implement elegant way of storage switching between local and the azure blob.
I would love to have a unified path of the type UPath that simply knows where the object "lives" and acts accordingly.
I am running into the following issue:
When I pass abfs: AzureBlobFileSystem that is already set up with account_name and can correctly list write files.
I pass the abfs to the UPath as follows:
abfs =  AzureBlobFileSystem(...)
abfs.ls('/') # This succeeds

path = UPath('abfs://{foldername}', fs=abfs)

path
AzurePath('abfs://{foldername}/')

path.glob('*') # This fails

I get
ValueError: unable to connect to account for Must provide either a connection_string or account_name with credentials!!
Q: Why is this happening ? My abfs is already "logged in" and authenticated.
I would think that UPath should have no issue simply using such abfs.

Hi @mat-ej
The UPath constructor currently supports storage options as keyword arguments, and there is no direct way of passing instantiated filesystem classes.
So you have two options to achieve what you want:
# you can provide the same options you use for AzureBlobFileSystem to UPath

pth = UPath('abfs://{foldername}', account_name=..., tenant_id=..., client_id=..., client_secret=..., ...)

# you can pass in the storage_options from the already instantiated fs

abfs =  AzureBlobFileSystem(...)
pth = UPath('abfs://{foldername}', **abfs.storage_options)

Let me know if that helps!
Also, if you don't mind me asking: Was there some text in the documentation, that made you assume you can pass fs=filesystem_instance to UPath as a keyword argument? And/or can you suggest some text for the documentation, that would have made this more intuitive?
Cheers,
Andreas

Just to add I came here about ask the same question, but the suggestion of passing the **abfs.storage_options to the constructor worked perfectly in my S3FileSystem case. In terms of documentation, I think adding a note around this would be very helpful


fix: Rename the MultipleDialog.schema to MultipleDialog.schema.sample

Description

This is to avoid MultipleDialog.schema to be discovered when is custom action is not enabled.
fixes #5122
Task Item

Screenshots

Coverage remained the same at 55.319% when pulling 5acc82e3821851f736318483d95eb1065ad4f96d on luhan/updateJSCustomSchema into 99142b6f52e8f67a3a49d63c5fd3a94925bf336b on main.


Upload failed due to an invalid BotId in your manifest

Copied bug from: https://github.com/OfficeDev/TeamsFx/issues/9132
Details from original post:
Describe the bug
I was trying to create a notification bot using teamstoolkit v5.0.1 extension, on clicking on f5 it starts local debugging and when clicking add button in teams it gives me a pop up saying Upload failed due to an invalid BotId in your manifest.
I'm using developer account for sideloading.
I also tried https://github.com/OfficeDev/TeamsFx/issues/7608#issuecomment-1432603062
but this was already enabled for me you can see in one of the screenshots.
Screenshots

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: b743e43d-95cc-3d1e-b142-31a16369f97e
Version Independent ID: b743e43d-95cc-3d1e-b142-31a16369f97e
Content: Teams Toolkit Overview - Teams
Content Source: msteams-platform/toolkit/teams-toolkit-fundamentals.md
Service: msteams
GitHub Login: @zyxiaoyuer
Microsoft Alias: zhany

An ICM has been raised for this issue, we will keep you posted on the updates.

Closing this issue as per the latest update at https://github.com/OfficeDev/TeamsFx/issues/9132. This issue has been fixed.


Pasting breaks the CLI output

Describe the bug
Pasting causes the CLI output to behave funny.
In the following example I copy cmd+C the word "table" and paste it cmd+V in the Name input.

Confirmed it's still an issue with v0.11.19

Alright, let's keep open. Maybe a good one for the next bug squashing rave 🎉

It's quite difficult to fix this. We would need to re-implement the schema edit command. I've been looking into the enquirer library and even if they allow to subscribe to events, paste is not a recognized event. It seems the behaviour is attempting to restore the CLI output but we show weird state in the process.


highlight: use $CXX instead of c++ to build

Motivation for this change
set $CXX and $AR so cross compilation works
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg build highlight

@illegalprime could you ask for ofborg access? https://github.com/NixOS/ofborg/pull/331

@Mic92 thanks, will do!


Add more granular control over shell command output

Checklist

[x] I've run bundle exec rspec from the root directory
[x] I've followed the fastlane code style and run bundle exec rubocop -a
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.

Motivation and Context
Currently, both CommandExecutor.execute and Actions.sh re-print the script output in red when it exits with a non-zero status. While this is acceptable with short output (well... is it?), it ruins readability of the build log with long ones. Especially with gym and scan which, in large projects, generate hundreds (or even thousands when using CocoaPods) of the same lines twice.
This pull request solves that issue by allowing more granular control over what's printed and re-printed in various places, while maintaining backwards-compatibility and existing behavior (mostly).
Description
I'll divide the description of changes introduced in this pull request by the place they were introduced.
Note: When I mention "printing error output", I mean the re-printing output of the whole command if it exits with a non-zero status.
Actions.sh
This pull request changes the interpretation of log argument, allowing users to specify what exactly they want to be printed.
This change is backwards-compatible and it doesn't change default behavior.

print...
if...

command
log == true|| log.include?(:command)

real-time output
log == true|| log.include?(:output)

error output
log == true|| log.include?(:error)

As a bonus, this enables new possibilities, e.g. to only print command and error output if it exits with a non-zero status (by using [:comand, :error]). Currently, it's not possible without providing the error callback and manually raising the error.
📣 Discussion: Do you think the existing behavior should be changed so that it's [:command, :output] by default? It would mean that the command and its output is still printed but only once. It would also affect all steps using Actions.sh.
CommandExecutor.execute
A new argument has been added: suppress_error_output, allowing users to specify they want to suppress it exclusively.
This change is backwards-compatible and it doesn't change default behavior.

print...
if...

command
print_command == true

loading text
print_all == true

real-time output
print_all == true&& suppress_output == false

error output
suppress_output == false&& suppress_error_output == false

📣 Discussion: Do you think the existing behavior should be changed so that it's suppressing only error output? It would mean that the command and its output is still printed but only once. It would also affect all steps using CommandExecutor.execute.
scan
A new config item has been added to scan: enabled_xcode_output which is an array of values :command, :output and :error.
This change is backwards compatible but it changes the behavior. It no longer prints error output if the tests fail, unless :error is included in enabled_xcode_output.

print...
if...

command
enabled_xcode_output.include?(:command)

real-time output
suppress_xcode_output == false&& enabled_xcode_output.include?(:output)

error output
suppress_xcode_output == false&& enabled_xcode_output.include?(:error)

📣 Discussion: Do I need to re-generate Swift API for scan as well?
gym
A new config item has been added to gym: enabled_xcode_output which is an array of values :command, :output and :error.
This change is backwards compatible but it changes the behavior. It no longer prints error output if the tests fail, unless :error is included in enabled_xcode_output.

print...
if...

command
silent == false&& enabled_xcode_output.include?(:command)

real-time output
silent == false&& suppress_xcode_output == false&& enabled_xcode_output.include?(:output)

error output
silent == false&& suppress_xcode_output == false&& enabled_xcode_output.include?(:error)

📣 Discussion: Do I need to re-generate Swift API for gym as well?
Discussion
In the above description I mentioned a couple of discussion items, marked with 📣. I'd like to trigger a conversation on those topics before proceeding with this pull request.
What do you think? Does the user really need to see the raw error output if they see it above? Was it done mostly for the ability to copy without the [hh:mm:ss] > prefix?

P.S. Gosh, that's a long description for +88 -22. 😅

@googlebot I signed it!

Thanks for tackling this, indeed an area where things can be optimized and improved. But also a lot to process 📚 💥

@akashivskyy This is an amazing change 🙌 I do love the granularity and cleanup that you did here ❤

📣 Discussion: Do you think the existing behavior should be changed so that it's [:command, :output] by default? It would mean that the command and its output is still printed but only once. It would also affect all steps using Actions.sh.

I think the existing behavior here for Actions.sh should be [:command, :output, :error]? 🤔 Anybody using Actions.sh in their Fastfile would definitely need to see both the command being executed along with results and any error output that occurs.

📣 Discussion: Do you think the existing behavior should be changed so that it's suppressing only error output? It would mean that the command and its output is still printed but only once. It would also affect all steps using CommandExecutor.execute.

I think its always good to show error output? In my experience, sometimes not showing error output can lead to more confusion to users. Do you think there are some good reasons to suppress error output?

📣 Discussion: Do I need to re-generate Swift API for scan as well?

You do not 😊 These generate in our build/release process so it will be done automatically next release

📣 Discussion: Do I need to re-generate Swift API for gym as well?

You do not 😊 These generate in our build/release process so it will be done automatically next release

@joshdholtz To answer your 2 answers regarding the error output, I feel we must use the same glossary here. I wrote in the description of this PR that:

Note: When I mention "printing error output", I mean the re-printing output of the whole command if it exits with a non-zero status.

Let's redefine that:

all output — Any messages printed by a command to stdout or stderr.
error output — Any error messages printed by a command (subset of above).
re-printing output — The behavior of Fastlane re-printing all output when a command fails.

With the above definitions, :output controls all output and :error controls re-printing output. So, in other words, if Actions.sh is given :output, the error messages are still printed as part of real-time output.
I prepared a table to visualise what's happening:

The current default behavior of Actions.sh and CommandExecutor.execute is the bottom one, which means users will see the same output twice if a command fails. That's why I'm suggesting changing that to the top one so that they only see it once.

@joshdholtz Hi! Sorry for the late reply. I completely understand your rationale that changing the default behavior now would bring more confusion than benefits. I felt that as well and you reassured me.
In addition, I refined the way gym executes commands — now, it always uses CommandExecutor instead of Helper.backticks. I think this justifies a re-request for review. 😊

I lost interest in pursuing this — closing for now so it doesn't create clutter. Maybe I'll reopen this some day. 😉


Switch .svx files to markdown files.

Currently we use mdsvex's default extension for naming blog post and documentation entries, but we don't use many mdsvex-specific features. I think that it would be safe to configure mdsvex to read *.md files, then just use those so that GitHub picks up on the filetype.

@Tropix126 are there any mdsvex features that we could take advantage of?

There are Svelte components in markdown, frontmatter metadata (which we use), layouts (we're using SvelteKit's layouts instead), and Remark plugins, which we also use.
Svelte components in markdown aren't really needed unless we need very custom content, and even then - MDSvex can be configured for any file extension.
This will also allow GitHub to render the pages.

@Tropix126 are there any mdsvex features that we can take advantage of?

I might clarify that these files will still be ran through mdsvex, they'll just have an extension that Github recognizes and can preview. At the moment we use some remark plugins and frontmatter (for blogpost metadata). Other than that, we don't really do any serious custom syntax.


Refactor headers code based on PR feedback

Pull Request Checklist

[x] New code has 100% test coverage
[ ] (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
[ ] (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR

Description
This PR is for implementing feedback given in #1917. I had a look through the codebase for the usage of FieldDefinition, but didn't seem to see a similar case of casting from a string to the defined type in the FieldDefinition. I'm also not sure about the fact that I'm importing from litestar.dto.factory.utils to use resolve_model_type. I'd appreciate some feedback on this.

hi @Tsdevendra1 - im not sure this is required anymore. I already did an update to the file on main.

From what I can see in the current headers file on main it still uses my old implementation of _get_type_annotations, your feedback mentioned that I should switch it to use FieldDefinition, is that not needed anymore?

From what I can see in the current headers file on main it still uses my old implementation of _get_type_annotations, your feedback mentioned that I should switch it to use FieldDefinition, is that not needed anymore?

that would still be nice, pls continue

I've tried to improve the code using FieldDefinition in this PR, would you mind telling me if it's the right way? Or if there is a better approach?

I've tried to improve the code using FieldDefinition in this PR, would you mind telling me if it's the right way? Or if there is a better approach?

basically FieldDefinition does the parsing of the type for you - look inside the logic in that class. You can use a FieldDefinition instance to get a parsed annotation and a representation of any metadata it might include, see under field_definition.kwarg_definition. It also has a bunch of properties you can use, such as is_optional etc. so you do not need to do this stuff manually.

Is the current implementation not already relying on the correct methods?
    @classmethod
    def _get_field_definitions(cls) -> Dict[str, FieldDefinition]:
        if cls._field_definitions is None:
            cls._field_definitions = {}
            for key, value in get_type_hints(cls).items():
                definition = FieldDefinition.from_kwarg(annotation=value, name=key)
                # resolve_model_type so thatfield_definition.raw has the real raw type e.g. <class 'bool'>
                cls._field_definitions[key] = resolve_model_type(definition)
        return cls._field_definitions

This seems to be close to what get_model_type_hints is doing which is used quite a bit through the codebase

Is the current implementation not already relying on the correct methods?
    @classmethod
    def _get_field_definitions(cls) -> Dict[str, FieldDefinition]:
        if cls._field_definitions is None:
            cls._field_definitions = {}
            for key, value in get_type_hints(cls).items():
                definition = FieldDefinition.from_kwarg(annotation=value, name=key)
                # resolve_model_type so that field_definition.raw has the real raw type e.g. <class 'bool'>
                cls._field_definitions[key] = resolve_model_type(definition)
        return cls._field_definitions

This seems to be close to what get_model_type_hints is doing which is used quite a bit through the codebase

this is good, but get_type_hints should be used with include_extras=True and be imported from typing_extensions

I've implemented your feedback, should be good to review again now


download stuck ? maybe this trick can help you, maybe

my download always stopped at 4%, then I try this trick. at least this trick works for me. it seems the subtitle cause this issue.
after push the download button you will choose the subtitle right ? then scroll down, choose the last one in drop down list/the least number. usually English[Auto] like this https://i.stack.imgur.com/hKQgE.jpg ( English[Auto] 26 lectures), choose it and start downloading.
sometime it doesn't work, I don't know, just give it a try

close udeler, go to download folder, look for any incomplete download file. delete the file, then restart udeler, and continue your download

thank you it worked

thx , you are a life saver


Intermittent AttributeError when Invoking Shortcuts

A few times in the past week, my code that invokes Shortcuts starts failing.  Unclear what is triggering the issue, but once it occurs, the only way to resolve (that I've uncovered so far) is to reboot.
Example code
shortcuts_app = PyXA.Application("Shortcuts")
add_url = shortcuts_app.shortcuts().by_name("Add iTunes Store URL to Playlist")

results in
Exception has occurred: AttributeError
'SBApplication' object has no attribute 'shortcuts'

This seems to be because Shortcuts doesn't respond to Apple Events unless it is actively opened, but you should be able to use PyXA.Application("Shortcuts Events") to get around the problem. I might add a specific error message for this case, or at least adjust the documentation.

I was able to reproduce the problem and made a few more observations...

When the error occurs, I can still see Shortcuts as an active process in the Activity Monitor, even though the app appears closed.  If I Force Quit from there, PyXA calls to Shortcuts start working again (no restart needed).

After a force quit, I can still run Shortcuts successfully without launching the app first.  The API will open the app if it is not already open.

Based on this, I'm guessing this is more likely a Shortcuts bug.  But I did want to share my observations as they are a different than what you mentioned above.  Documentation changes may not be needed?

Do you see the problem at all when using Shortcuts Events instead? Just thinking that it might be worth mentioning in the documentation to avoid this and potentially other errors

Not so far, but the issue is intermittent.  Can't hurt to acknowledge alternative either way.

Still unable to reproduce using System Events - maybe this is the best way.


Explain feature for DB2 z/OS

It never did. DB2 z/OS extension supports limited set of functions (it is based on Generic DBeaver driver)


Create plugin for defilama

https://docs.llama.fi/list-your-project/submit-a-project
TVL
Reading their docs I think our TVL calculation should currently be:
mainnet:

cUSDC balance of our aave staking contract (V2)
cDAI staked in our compound staking contract (v1+v2)
cDAI balance of reserve

fuse:

G$ balance of our governance staking contract
fuse staked in fuse's consensus contract by our FuseStaking contract

Hey @sepu85 can you please review and close/approve it?
The listing: https://defillama.com/protocol/gooddollar
Methodology was:
TVL:
Mainnet:
cUSDC balance of our aave staking contract (V2)
cDAI staked in our compound staking contract v1 + v2
cDAI balance of reserve
Fuse:
NOT COUNTED BECAUSE THEY DONT COUNT PoS UNTIL TOKENIZED- (fuse staked in fuse's consensus contract by our FuseStaking contract)
Staking:
Fuse:
G$ balance of our governance staking contract
Treasury:
Fuse:
G$ balance of our community safe
G$ balance of our FuseStaking contract
G$ were converted to USD based on current price at the reserve(through conversion to DAI) because they usually pull the price from CoinGecko

he @Shloyem I'm re-opening this issue as we need to update the new contracts after we deployed the fix.
DeFiLlama is not showing the right metrics.

Hey @sepu85 thanks for bringing it up on the weekly PPP.
Just sent them this PR fix according to item 233 Adjust Defi-Llama plugin for new contracts.


Privacy policy

This redirector seems to be quite popular (almost 3 million links generated) so I think there should be some link on the page with the privacy policy, or right here at github.

Will leave this open, so when I have some free time, I can probably write something up.
Note that a good portion (about 50% from my recent calculation) that are shortened are spam bots using it to shorten phishing links. Have to work on mitigation solutions, and Google SafeBrowsing (https://github.com/lrstanley/links/issues/16), which will hopefully cut down on the number of these potentially malicious expanded links.

The TL:DR though, is that (as of today) for links.wtf:

The only data that is stored in the DB is the same data you see in this repository. None of the intermediary web servers/load balancers/etc store data for longer than 30d (ip, route/path,  GET parameters, useragent).
None of the data is currently moved outside of the server in which it is hosted on.
None of the data for links.wtf is shared with anyone other than I.
Requests for removal of data isn't easily possible today due to lack of account information to map shortened links to. Will only remove data if requested by hosting provider, legal request, or links which I deem potentially dangerous to end users, at this time.

Have been thinking about API key system/oauth system to map back to identities, to allow managing their own links/delete their data, but not implemented today.

Hasn't ran the actual links.wtf site in some time, mostly due to not having the time to keep up with resolving phishing reports (due to bots getting through spam protection), with my current hosting provider (@ OVH, all reports are automated unless you're an enterprise, so they essentially won't listen when I tell them the links.wtf site wasn't hosting anything, it's simply a redirection service). Was really annoying, because I also had Cloudflare in front of the service, which didn't stop the bots, and Cloudflare still forward those types of reports through to the hosting provider.


Grey code with no reasons

All of a sudden, I have my code greyed out in Python notebook cells.

after line 28 the code is grey, but it is clearly reachable (actually, run).
Why?
Using VSC:
Version: 1.86.2
Commit: 903b1e9d8990623e3d7da1df3d33db3e42d80eda
Date: 2024-02-13T19:42:12.210Z
Electron: 27.2.3
ElectronBuildId: 26908389
Chromium: 118.0.5993.159
Node.js: 18.17.1
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 23.4.0

on MacOS Sonoma 14.4.
The interpreter is Python 3.8.18 in a conda environment.

Ok, understood.
See these examples:
This is fine:

This is also fine. Line 7 generates an error and line 8 is never executed.

This is not fine at all:

I think I need to move this bug report somewhere else.

I also have similar problem where the entire second half of a python file has dimmed text for no reason.
Using MacOS Sonoma 14.3.1
Version: 1.87.2
Commit: 863d2581ecda6849923a2118d93a088b0745d9d6
Date: 2024-03-08T15:20:57.520Z
Electron: 27.3.2
ElectronBuildId: 26836302
Chromium: 118.0.5993.159
Node.js: 18.17.1
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 23.3.0

@rebornix, could you please help triage this issue? Thanks!

I can confirm that this is also happening on normal .py files, not just in notebook cells.
Error is coming from Pylance, message is "Code is unreachable"

Pylance version v2024.3.1
Version: 1.87.2 (user setup)
Commit: 863d2581ecda6849923a2118d93a088b0745d9d6
Date: 2024-03-08T15:20:17.278Z
Electron: 27.3.2
ElectronBuildId: 26836302
Chromium: 118.0.5993.159
Node.js: 18.17.1
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19045

After some searching I found this:
https://github.com/microsoft/pylance-release/issues/5630
Downgrading pylance fixed the issue in my case.

Yep this is a regression in the Pylance extension.


Sscs 10919 fix duplicate tabs - revisited

JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/SSCS-10919
Change description
Recreated Pr for testing
This can be tested locally:
From WSL run in sscs-tribunals-api ./gradlew bootWithCCD
Create some local cases using the sscs-tribunals-api e2e sya tests (under Windows in intellij).
Log in locally to the site as super-user, select a valid case and once in the case select the drop down action "Update to case data". At the very bottom of the case select Did PO attend to "yes", then click continue. Then submit. When you return to the case there is one outcome tab.
But you will need to also check with the Action "Update Listing Requirements" as that has also been affected by my changes.
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[x] No

I am closing this PR as the fix in SSCS-10933 does this properly

This is closed as SSCS-10933 does this better.


Double forward slash in url when opening issue in browser via ENTER

Describe the bug
In 0.3 there is an additional slash (/) after the jira hostname when opening an issue in the browser via ENTER from the issue list view. Example: https://jira.company.com//browse/KEY-1234
Please provide following details

JiraCLI Version: 0.3.0(Version="v0.3.0", GitCommit="", CommitDate="", GoVersion="go1.17.5", Compiler="gc", Platform="darwin/amd64")

Are you using Jira cloud or on-premise jira server? Also mention the version for on-premise installation.on-premise Jira v8.20.1

What operating system are you using? Also mention version.macOS Monterey 12.2

What terminal are you using? Also mention version.iTerm2 3.4.15, zsh v5.8

To Reproduce
Steps to reproduce the behavior:

Open a jira issue list via jira issue list -q <query>
Navigate to an issue and press ENTER
Issue opens in browser with double slash after fqdn

Expected behavior
The host name is not appended with two slashes which results in a bad request to the server
Screenshots
Cannot provide
Additional context
N/A

Hi @jbaskeen, I think you are using server url with a trailing slash. You can update your config manually to remove the trailing slash as an immediate fix.
I updated the config generator in #295 to strip trailing slashes when generating the config. So, newly generated config will auto strip trailing slashes to avoid the issue.


Example of usage

Hello,
I'm glad to see some implementation of tor in Rust. But there will be some chance to add examples of how to use this lib?

I am sorry for quite long response time.
I've added some improvements on dev branch. I'll do some more testing and release a new version soon. At the moment you can fetch specific rev(1ef9b0d) from git using cargo.
There are also examples on dev, however they use new simplifying apis.
You may also take a look at tests for authenticated conn especially at the ones which use tor (ctrl+f for testtor)
Also one more note:
Right now torut does not handle connecting to tor's socks port. I will create some socks crate or reuse some existing one.


Workspace - Members list is empty in manage members page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Launch the app and login
Go to settings and select a workspace
Tap Manage members

Expected Result:
In the manage members screen I should see all the members
Actual Result:
None of the members are displayed
Workaround:
Unknown
Platform:

Where is this issue occurring?

iOS
Android
Desktop App

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: No
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:
View all open jobs on GitHub

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Triggered auto assignment to @tgolen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Closing as this is a duplicate of https://github.com/Expensify/App/issues/6528


WaitForLeader times out before an election takes place

On a new cluster, If i do the following,
start up one node, wait more then 5 seconds, start up a second node
then the first server will hit the timeout here:
https://github.com/influxdb/influxdb/blob/master/meta/store.go#L402
and will wait endlessly here:
https://github.com/influxdb/influxdb/blob/master/cmd/influxd/run/server.go#L298
The first server is stuck trying to elect a leader.  Once the other nodes come online then a leader is elected and the nodes are created properly, but the first node never completes the initialization and needs to be restarted
It seems to me as though there shouldn't be a timeout there.  if the node doesn't exist and we need to meta.CreateLocalNode, then we shouldn't timeout prematurely

@jwilder I think this can be done in conjunction with the work on cluster joining #2966. Since @benbjohnson is going to be working on compression in the 0.9.2 release cycle, can you take a look at both this and the joining issue for 0.9.2?

Possibly related: https://groups.google.com/d/msgid/influxdb/df98f329-8274-45b0-ae9c-744375171ae9%40googlegroups.com, https://groups.google.com/d/msgid/influxdb/a8941fa8-054a-4fd4-9c64-573d1c30bcae%40googlegroups.com

Believe fixed by https://github.com/influxdb/influxdb/pull/3256

Cherry-picked to 0.9.2.


Update how-to-deploy-online-endpoints.md

Added an additional explanation to the RBAC pre-req.

@dem108 FYI :)

IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


How to add cost

Can you give me the correct indention for paid kits of the example kit "archer"? I can't seem to add the cost since it always says "archer $0".

Archer:
active-in: #Remove this setting for all worlds
- 'MAPNAME'
cost: 1000
It should work

Thanks for the reply! Let me try it...


Unsupported Error Codes

It looks like there may be some new error codes that aren't supported in Going.Plaid.
I'm not sure when Plaid added it, but here is the one that's causing me issues: invalid_webhook_verification_key_id

Thanks for the update. Unfortunately, these are not tracked in the openapi spec, so I don't have any automated awareness of changes. I'll work on this today.

v5.0.0 is released; the properties are changed to string, so that matching an enum is no longer a problem. This is per discussion with the Plaid team.


[#5448] edit name length to validate value

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Where is the full API?

There are only a few methods in the readme file.

Most of the code is in this file:
https://github.com/socketio/socket.io-p2p/blob/master/index.js


member of multiple groups indicates a malformed project or loss of compilerFlags

We are looking to move away from pods. As part of the process, we care converting the pods to yml so we can generate Xcode project files. This is a precautionary step in case we ever want to be able to debug a pod.
I'm working on FBSDKCoreKit, which has one file which doesn't use ARC. However, I am having a difficult time getting it to work right.
It's either my syntax/ordering or perhaps a bug.
If I use this to define the sources
    sources:
      - path: ../Pods/FBSDKCoreKit/FBSDKCoreKit/FBSDKCoreKit/Internal_NoARC/FBSDKDynamicFrameworkLoader.m
        compilerFlags: "-fno-objc-arc"
      - path: ../Pods/FBSDKCoreKit/FBSDKCoreKit/FBSDKCoreKit
        includes: "**/*.[hm]"
        excludes: Internal_NoARC/FBSDKDynamicFrameworkLoader.m

I receive a warning like the following. The build will work, however.

2020-02-13 14:03:55.266 xcodebuild[4804:1782108] warning:  The file reference for "../Pods/FBSDKCoreKit/FBSDKCoreKit/FBSDKCoreKit/Internal_NoARC" is a member of multiple groups ("FBSDKCoreKit" and ""); this indicates a malformed project.  Only the membership in one of the groups will be preserved (but membership in targets will be unaffected).  If you want a reference to the same file in more than one group, please add another reference to the same path.

Note that I've gotten rid of the excludes and the same error message will result.
I tried to re-order, but ordering does seem to matter, since if I re-order like the following
    sources:
      - path: ../Pods/FBSDKCoreKit/FBSDKCoreKit/FBSDKCoreKit
        includes: "**/*.[hm]"
        excludes: Internal_NoARC/FBSDKDynamicFrameworkLoader.m
      - path: ../Pods/FBSDKCoreKit/FBSDKCoreKit/FBSDKCoreKit/Internal_NoARC/FBSDKDynamicFrameworkLoader.m
        compilerFlags: "-fno-objc-arc"

-fno-objc-arc will not be set.

Is my syntax incorrect? Or is this a case where xcodegen cannot properly handle it? Or do I just accept the warning and ignore it?

This warning can also happen if you have a 2 paths that are the same, but use different groups.

Just in case, I've just faced the following warning when invoking xcodebuild for our project:

The file reference for "UnitTests/Resources" is a member of multiple groups ("UnitTests" and "");

and was able to get rid of it by adding createIntermediateGroups: true option to the options: section of .yml.

I can also confirm, adding createIntermediateGroups: true fixed it for me as well.


D3D11: fix vertex texture sample

vertex texture sampling currently doesn't work in D3D11 shaders.

Fixed.


feat: drop IP address

Changes

Introduces a setting to Drop IP address. If enabled, the IP address information is completely discarded after doing the Geo-IP lookup.

Was requested in the past too.
Checklist

[ ] Tests for new code

Thanks!!

🎊🎊, we just need to deploy it now to PostHog Cloud

Hmm, unfortunately we can't, because this is a stateless plugin – i.e. a single instance of it handles events for all projects:
@yakkomajuri What do you suggest are the right steps here?

Reverted this PR for now (#15) to make the plugin installable until we figure this out.

My suggestion is that users set up https://github.com/witty-works/posthog-property-filter-plugin as the last plugin in the order. I'd definitely like to keep this plugin stateless if possible

That plugin does seem super applicable.

+1, I do think it's really helpful to have this as an option directly on the plugin, plus highlight it more prominently as a feature. I think it's worth encouraging end user privacy preservation as much as possible.


Add scene.apply service

Home Assistant release with the issue: 0.99
Component/platform: Scene
Description of problem:
Home Assistant has a powerful scene engine, but it's very static. Right now you can change scenes, but only in YAML after which you need to reload. We can do better.
This issue is about creating a new scene.apply service that will take the definition of a scene as the service parameters and applies it.
Example service data (just like the scene config):
light.kitchen: on
light.ceiling:
  state: on

On a side note, this service will be a lot more useful if we implement #25681