Cell Click Event on Pinned Row

Hi @TonyGermaneri ,  I'm using the cell click event on a pinned row. But sometimes it detects that I'm clicking the normal row that is underlaying of the pinned row. So the behavior will go wrong for this case. Any suggestion for fix this issue?

I think you should be able to use e.stopPropagation() to stop it from bubbling up.  You might have to change the event phase (bubble vs. capture).
I'm thinking you're talking about one of the "drill in" hierarchical rows, if that's not what you're let me know.

No bubbling up at all. I write console.log for this event, and only 1 cell is clicked, and it's underlaying cell. No hierarchical rows, just normal array. Just I have a function, turn 1 normal row to be pinned row, and when I click in the cell of the pinned row, it will turn back to normal row.   Do you mean selected row?

ah sorry. Pinned Row is Frozen Row

@TonyGermaneri I think the reason is getCellAt function is getting the cell underlay the frozen row rather than the cell on the frozen row. Any suggestion to fix it?

Hmmmm, it's been a while since I wrote the function.  getCellAt iterates over a stack of cell objects in an array for a given instance of the grid.  Unlike other child grids, the overlay is part of the same grid as the grid beneath it, so it's not a nightmare to fix.  I think the calculation that determines the bottom of the overlay edge is off, but that's just a guess based on using it just now, it appears it only happens to the row at the bottom edge.  Try turning on the debug overlay, that might help.


Added 90th Percentiles

I noticed 90th percentiles weren't currently being tracked via statsite. They are my go to metric, but I also use 95 and 99.
Let me know if there is a reason why 90th's weren't included by default and I'll look into making it a config option.

Closing, but I would merge a PR that made this configurable.


Expose site size and requested size to UI

Coverage increased (+0.1%) to 88.232% when pulling cdac7a2c953a5665d6b00ae48549d70ad5d0951f on site-size into d995719f9de94bedbff5ce63fef899c77d14359a on master.


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-source-version-target/pull/158 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-archive-test-source-version-target.git

Docs Build status updates of commit 84170c5:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

versioningArchiveSourceFolder/TOC.yml
:white_check_mark:Succeeded
View (sql-server-2014 || azuresqldb-current || azuresqldb-mi-current || azure-sqldw-latest || >= aps-pdw-2016 || >= sql-server-2016 || >= sql-server-linux-2017 || sql-server-previousversions || sqlallproducts-allversions)

versioningArchiveSourceFolder/docfx.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


add Mean and sum open dp

all tests passed for mean.py and sum.py

@Dhruv127 , I have tried testing it and it is failing in some test cases.
Please work out on the input_domain and metric for noise generator you are using to avoid the error.


Incorrect documentation for Go to Type functionality

The view described does not match the current Visual Studio release which displays the large slow and useless UI instead of the small GoToType Window

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 2b5f9224-0fef-e5c9-f0ad-789ed940d79d
Version Independent ID: 494a3e3a-074f-b4ab-132b-adc4c1482044
Content: Go to file, go to symbol, go to line - Visual Studio (Windows)
Content Source: docs/ide/go-to.md
Product: visual-studio-windows
Technology: vs-ide-general
GitHub Login: @ghogen
Microsoft Alias: ghogen

@lloydw-sportsbet
You might be interested in the following.
To enable or disable this feature, go to Tools > Options > Environment > Preview Features > New Visual Studio Search experience.


MINOR: fix streams tutorial

Fix inconsistency in store name in streams tutorial

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@ocadaruma , could you also file a PR to kafka-site repo to fit the current doc? Thanks.

Sure, let me.

@showuon Done: https://github.com/apache/kafka-site/pull/414


JUnit 4 to JUnit 5 migration

Migrate test suite to JUnit 5
Sources

https://blog.jetbrains.com/idea/2020/08/migrating-from-junit-4-to-junit-5/
https://www.arhohuttunen.com/junit-5-migration/
https://junit.org/junit5/docs/current/user-guide/#migrating-from-junit4

Some interesting findings:

Parts of the exception handling code has not been properly executed before with Junit4
Testcontainers still pulls in junit4, but that can't be changed and it's not of concern.

👍

👍


Roll Flutter Engine from 11777dcabe69 to a8054928cf3b (1 revision)

https://github.com/flutter/engine/compare/11777dcabe69...a8054928cf3b
2024-11-24<EMAIL_ADDRESS>Replaces Resource's shared_ptr with unique_ptr (flutter/engine#56778)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Unable to write frame to file in branch engines/gromacs/engine.py on branch gromacs_engine

When trying to sample my system I get the following error:
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
/media/Home/Documents/openpathsampling/openpathsampling/engines/gromacs/engine.py in write_frame_to_file(self, filename, snapshot, mode)
    337             step = np.asarray([0], dtype=np.int32)
--> 338             box = np.asarray([snapshot.box_vectors], dtype=np.float32)
    339             lambd = np.asarray([0.0], dtype=np.float32)

/opt/miniconda3/envs/opsgmx/lib/python3.7/site-packages/numpy/core/_asarray.py in asarray(a, dtype, order)
     84     """
---> 85     return array(a, dtype, copy=False, order=order)
     86

ValueError: setting an array element with a sequence.

Then: During handling of the above exception, another exception occurred:, and finally:
/media/Home/Documents/openpathsampling/openpathsampling/engines/gromacs/engine.py in write_frame_to_file(self, filename, snapshot, mode)
    342             trr._write(xyz, time, step, box, lambd, vel)
    343         finally:
--> 344             trr.close()
    345             close_file_descriptors(filename)
    346

UnboundLocalError: local variable 'trr' referenced before assignment

When taking a look at the first error by adding the lines:
            print(type(snapshot.box_vectors))
            print(snapshot.box_vectors)
            print([snapshot.box_vectors])

it is quickly clear what goes wrong. The simple alanine dipeptide example prints:
<class 'numpy.ndarray'>
[[2.8038313 0.        0.       ]
 [0.        2.8038313 0.       ]
 [0.        0.        2.8038313]]
[array([[2.8038313, 0.       , 0.       ],
       [0.       , 2.8038313, 0.       ],
       [0.       , 0.       , 2.8038313]], dtype=float32)]

whereas my system prints:
<class 'simtk.unit.quantity.Quantity'>
[[6.97692 0.      0.     ]
 [0.      6.69292 0.     ]
 [0.      0.      6.35193]] nm
[Quantity(value=array([[6.97692, 0.     , 0.     ],
       [0.     , 6.69292, 0.     ],
       [0.     , 0.     , 6.35193]], dtype=float32), unit=nanometer)]

So it seems sometimes the type of this variable is different from what is expected.
Introducing this simple hacky fix:
            if type(snapshot.box_vectors).__name__ == "Quantity":
                snapshot.box_vectors = snapshot.box_vectors._value

We then get the following error:
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
/media/Home/Documents/openpathsampling/openpathsampling/engines/gromacs/engine.py in write_frame_to_file(self, filename, snapshot, mode)
    342             lambd = np.asarray([0.0], dtype=np.float32)
--> 343             vel = np.asarray([snapshot.velocities], dtype=np.float32)
    344             trr = TRRTrajectoryFile(filename, mode)

/opt/miniconda3/envs/opsgmx/lib/python3.7/site-packages/numpy/core/_asarray.py in asarray(a, dtype, order)
     84     """
---> 85     return array(a, dtype, copy=False, order=order)
     86

ValueError: setting an array element with a sequence.

Which is caused by the same issue.  Applying the same fix for the velocities, everything seems to work fine (the sampler is still running as of now).
If you want to reproduce this error: The .gro, .top and .trr files that are used for sampling are made with GROMACS 2018.3. Perhaps more importantly, the initial trajectory is obtained with trajectory = openpathsampling.engines.openmm.tools.ops_load_trajectory('ca5.trr', top='ca5.gro')
I can imagine it would be better to check the unit of this quantity class, and to convert the values to those corresponding to ops' internal units. Thus, I will leave this issue open for now.
Finally: During error catching an UnboundLocalError is thrown for trr.close(), as the variable trr is never assigned. Though I think this should never happen anyway, you could catch it with a nested try:
        finally:
            try:
                trr.close()
            except UnboundLocalError as e:
                logger.error(e)
            close_file_descriptors(filename)

It might be preferred to just not catch the error though.

As you observed, the basic problem here is in mixing snapshots from different engines. That's not expected to always be trivial: Snapshot types are specific to their engines; the OpenMM engine returns one type, and the Gromacs engine returns another. Interoperability isn't guaranteed, and wouldn't even make sense between some engines (how would the toy engine run alanine dipeptide?)
I would recommend going through the file system. I think what you need are two functions, paths.engine.gromacs.load_trr (which I'll add to the gromacs_engine branch) and a function that writes a TRR from a trajectory based on OpenMM snapshots. That one I won't add to the core unless this becomes a more frequent problem (in general, we recommend writing to file by way of MDTraj; unfortunately, the public API of MDTraj doesn't write velocities, and I assume you'll want that in this case.)
This may take some time for me to implement cleanly (as in, I probably won't get to it today, and maybe not tomorrow). You might be able to hack together something that works based on snapshot_from_gro (for loading) and by using the GromacsEngine.write_frame_to_file as the basis for writing the trajectory. You can compare types, etc., with the MDTraj tests for writing TRR files with velocities: https://github.com/mdtraj/mdtraj/blob/11f33d99ce037239ecd5dca8a9bed2154b1b0854/tests/test_trr.py#L275-L298

Finally: During error catching an UnboundLocalError is thrown for trr.close(), as the variable trr is never assigned. Though I think this should never happen anyway, you could catch it with a nested try:

You solution is a good one, but I've updated the branch with what I think is an even better solution. The try/finally block is to ensure that the file gets closed, even if an error occurs in the try part (the error will get passed back to calling code to handle it.) None of the stuff about converting to the right kind of array matters for that, so I moved it to before the try block. (Now the error you're seeing should get raised without ever opening the TRR file.)
General guideline in software development: try blocks should be as short as possible, aiming to only catch specific errors. The reason for that is exactly what you observed here. I'm glad it didn't cause too much confusion!

Thank you for the detailed answer! it is nice to read up on coding guidelines, and I'm happy that my error got a try block to be a little smaller.
I'm still left with differing snapshots, but for now allowing two snapshots in the storage and typecasting their contents works fine. I'm looking forward to seeing a new paths.engine.gromacs.load_trr function to properly load in my data, though. But there is no hurry ;)

... and a function that writes a TRR from a trajectory based on OpenMM snapshots.
I'm not sure whether I need this function myself. The TRR that i'm using right now has been generated by GROMACS, and I haven't used OpenMM as of yet. If you're not planning on adding it to the core, it might be unnecessary to write the function.


v1.1

Actions and tests are happening next sprint

Did the release, you can merge since there's no updates on this repo that I need to do post-release


Basic RSA Challenge

Brute-force simple RSA to get the flag.

Changed to having one exposed prime factor


Cluster add empty state should be default if nothing exists previously

If this is the first time a user has logged in and there are no clusters aside from the host cluster, the add cluster empty state should be displayed by default.
Spawned from #97

There will always be at least the host cluster registered.


Add figure and figcaption support

Add support to Bootstrap for HTML5 figure/figcaption styles for text and images.

Supported in the sense that the markup is respective, but we currently have no specific styles for this.


Added a new Testamonial

Description
Adding a new "Testimonial section" on the homepage
Related Issues*

Fixes #187

Screenshots!
After changes:

Checklist
Replace "[ ]" with "[x]" to mark them as completed.

[x] I have forked the repo and pushed the changes according to contribution guidelines.
[x] I have tested these changes locally.
[x] I have tried to maintain the consistency of the code.
[x] I have tested these changes locally.
[x] I have updated the documentation accordingly.

Contribution guidelines were not followed properly
You do not have to push changes in main branch you just have to opt a branch.
Kindly refer the contribution.md file


[BUG] CSV exports dont work for non-admin users (and other report functions).

Describe the bug
CSV exports dont work for non-admin users (and other report functions).
We are using opensearch with security applied to indexes for different business groups etc - only a few people are OpenSeach (OS) admins. The non-admin users can't generate a CSV export.
I believe this is a permissions issue and I have corrected and progressed the error (ie. now a different error) but it's still not working.
One issue I found is the roles reports_full_access, reports_read_access & reports_instances_read_access all reference 'opendistro' permissions. ie. cluster:admin/opendistro/reports/definition/get [^1]
I noticed this due to the permission error message:
[2021-11-09T12:28:13,098][INFO ][o.o.s.p.PrivilegesEvaluator] [server2] No cluster-level perm match for User [name=camtest, backend_roles=[], requestedTenant=NetSupport] Resolved [aliases=[*], allIndices=[*], types=[*], originalRequested=[*], remoteIndices=[]] [Action [cluster:admin/opensearch/reports/definition/list]] [RolesChecked [acme_ldap_elastic_netsupp, reports_full_access, kibana_user]]. No permissions for [cluster:admin/opensearch/reports/definition/list]

I ended up creating new action groups (AG) like the reporting AGs but replacing opendistro with opensearch - That helped a bit.
The next error was:
[2021-11-09T12:06:38,112][INFO ][o.o.s.p.PrivilegesEvaluator] [server2] No index-level perm match for User [name=camtest, backend_roles=[], requestedTenant=NetSupport] Resolved [aliases=[syslog], allIndices=[.ds-syslog-import-2021-000004, .ds-syslog-import-2020-000001, .ds-syslog-import-2021-000002, .ds-syslog-import-2021-000003, .ds-syslog-import-2021-000001, .ds-syslog-2021-10-000001, .ds-syslog-2021-000001], types=[*], originalRequested=[syslog], remoteIndices=[]] [Action [indices:monitor/settings/get]] [RolesChecked [os_reports_instances_read_access, acme_ldap_elastic_netsupp, kibana_user]]

But adding indices:monitor/settings/get level permissions doesn't help as the error message continues even after logging out and purging security caches etc.
I susseqentily added a bunch of AGs in a troubleshooting attempt [^2] which didnt help, I think the error has gone after the additional AGs and the current error  message is:
[2021-11-09T13:11:21,568][DEPRECATION][o.o.d.c.m.IndexNameExpressionResolver] [server2] this request accesses system indices: [.opendistro_security, .tasks], but in a future major version, direct access to system indices will be prevented by defaut
I believe it's caused by the reporting plugin but can't be 100% certain as it spams the error log every 1 minutes + a few seconds drift
To Reproduce
Steps to reproduce the behavior:

Create data series indexes
Create non-admin users with limited permissions.
Save a search in GUI.
Attempt to export search to CSV file.
Fail with error: Error generating report. Insufficient permissions. Reach out to your OpenSearch Dashboards administrator.

Expected behavior
A clear and concise description of what you expected to happen.
Plugins
Default from 1.1.0 docker build
Screenshots
n/a
Host/Environment (please complete the following information):
Server: docker v1.1.0 build
Client: Windows 10 x64 - Firefox v94.01
Additional context

This build was running opensearch v1.0.0 then upgraded to 1.1.0  when it came out - possibly a migration step was over looked?
Not sure if it worked for non-admin users on v.<IP_ADDRESS>
We also only use dataseries index types. These seem to not have as much testing performed against them during the plugin development cycle(?).

[^1:] Role permissions
#reports_full_access
cluster:admin/opendistro/reports/definition/create
cluster:admin/opendistro/reports/definition/update
cluster:admin/opendistro/reports/definition/on_demand
cluster:admin/opendistro/reports/definition/delete
cluster:admin/opendistro/reports/definition/get
cluster:admin/opendistro/reports/definition/list
cluster:admin/opendistro/reports/instance/list
cluster:admin/opendistro/reports/instance/get
cluster:admin/opendistro/reports/menu/download

#reports_read_access & reports_instances_read_access
cluster:admin/opendistro/reports/instance/list
cluster:admin/opendistro/reports/instance/get
cluster:admin/opendistro/reports/menu/download

#reports_read_access
cluster:admin/opendistro/reports/definition/get
cluster:admin/opendistro/reports/definition/list
cluster:admin/opendistro/reports/instance/list
cluster:admin/opendistro/reports/instance/get
cluster:admin/opendistro/reports/menu/download

[^2:] Additonal Action Groups attempted in addition to the above group[^1]
indices_monitor
manage_data_streams
data_access
search
get
read

Hi, this issue has been fixed in #218, and it will be avaialble in 1.2 release. It was a naming mistake during migration, the permissions should be prefixed in opendistro, but it was changed to use opensearch. There's a workaround if you create some permissions/roles by admin user, using opensearch. Otherwise, wait for the 1.2 release and update
@camAtGitHub

@zhongnansu - any pointers to the current work around permissions would be appreciated.


Web.de

Issue Title
Be as descriptive as you can with your title.
General
Provide details on the problem you are experiencing including the .NET Core version, operating system version and anything else that is relevant.
Please provide a code sample for your issue if it is relevant, either inline, link to a gist (or similar) or add it as a zipped attachment.
For some issues, you will get a quicker and better response if you file it at a more specific .NET repo. For example, if the problem is with ASP.NET Core, you are encouraged to use the aspnet/home repo.

Your bug report is empty. What is the problem you're encountering?

No response - closing issue.


Add support for Aqara Ceiling Light T1M (acn032)

Proposed change
This quirk adds support for power on behavior configuration to Aqara Light T1M (ceiling light with RGB ring).
This device identifies itself as lumi.light.acn032.
Additional information
Resolves #3066
Checklist

[X] The changes are tested and work correctly
[X] pre-commit checks pass / the code has been formatted using Black
[X] Tests have been added to verify that the new code works

Also I think it would be nice to expose this option as a configuration entity in UI preferably in as a drop-down. Can anyone point me into an relevant example?

https://github.com/zigpy/zigpy/blob/3d1b60c9181fb40638eaf3e70c5815967b07300c/tests/test_quirks_v2.py#L230
Convert the quirk to v2 like this

@corvis might be outside the scope of this PR, but it would be awesome if the ring light effects could also be exposed.
I saw some indications this may be already be available in Zigbee2MQTT

I do not have capacity to reverse engineer the protocol but if there is already a working solution in Zigbee2MQTT or any other project i can back port it in ZHA. @jrseliga can you point me into the code\PR\whatever else indications you've mentioned?

@corvis the Make It Work Youtube channel reviewed the Aqara T1M. There was a brief mention of using this device with Zigbee2MQTT. He mentioned it was not reliable, but you will notice the effects dropdown at the the bottom.
That link is right at the timestamp where he discusses Zigbee2MQTT with the Aqara T1M.
I had a look through Zigbee2MQTT repository but couldn't pinpoint what may be exposing that specific feature.

Any chance of this getting merged any time soon? I would love to be able to set my ceiling lights to PreserveState on power restoration.

Any chance of this getting merged any time soon? I would love to be able to set my ceiling lights to PreserveState on power restoration.

I would love to know this too.  My support request to Aqara told me to buy a hub to get this feature.
This may be off-topic, but forgive my lack of knowledge: when this is merged into zigpy:dev, how long does it take to make into the mainline prod? I.e. will it take a couple of months before it’s in the regular updates, or would it be quicker for me to learn how to make a custom quirk? (I don’t want to buy more equipment unless I have to)
Thanks, all!

Would love to know if this is planned to be merged in the near future as well as I have the same issue with the lights coming on now and then.


Received status code 401 from server: Unauthorized

Environment:
OS: Windows 10
Nativescript CLI: v8.0.1
Android Runtime: v8.0.0
Ios Runtime: v8.0.0
Issue
I installed the following plugins in my project to give it a go @nativescript/canvas,
@nativescript/canvas-polyfill, @nativescript/canvas-three  however when I run ns run I get the following error.
Build file 'C:\Users\joshm\Documents\Modii\Projects\hiit-workout-app\hiitman\projects\hiitman-nativescript\platforms\android\app\build.gradle' line: 633
A problem occurred configuring project ':app'.
Could not GET 'https://jitpack.io/com/github/triniwiz/canvas/0.9.11/canvas-0.9.11.pom'. Received status code 401 from server:
Unauthorized

For some reason there's an http request going to a private repo. (https://jitpack.io/com/github/triniwiz/canvas/0.9.11/canvas-0.9.11.pom) It's preventing my app from building.
I also tried removing @nativescript/canvas-three and got the same error

Can you try @nativescript/canvas@latest You should get .12 which fixes this

@latest gave me v0.9.13 but that seems to be working thanks!
I noticed that this package expects xmldom to be installed but it's not listed as a peer dependency. I'll open another issue for it though.

xmldom is a dep for @nativescript/canvas-polyfill


XML isn't validated

PHPMD version: 2.7.0
PHP Version: 7.3
Installation type: composer
Operating System / Distribution & Version: mac os

Current Behavior
If i have the following rule in my xml
<rule ref="rulesets/codesize.xml/NPathComplexity">
        <properties>
            <property name="reportLevel" value="0" />
        </properties>
    </rule>

I never get an error for NPathComplexity. That is because reportLevel is the property for CC, not NPath.
Expected Behavior
I would have expected PHPMD to report an invalid property on my rule.
Steps To Reproduce:
Add the previous snippet to your phpmd.xml file and run it.

Thanks, yes, XML validation errors would be great! I add this to 2.9 todo list. PRs are welcome.


Feat: http2 support for server

closes #186

Codecov Report

Merging #969 (0c54df1) into main (c2ed52e) will decrease coverage by 3.54%.
The diff coverage is 18.57%.

@@            Coverage Diff             @@
##             main     #969      +/-   ##
==========================================
- Coverage   55.73%   52.18%   -3.55%
==========================================
  Files          71       79       +8
  Lines        2232     2581     +349
  Branches       56       94      +38
==========================================
+ Hits         1244     1347     +103
- Misses        988     1234     +246

Impacted Files
Coverage Δ

zio-http/src/main/scala/zhttp/http/Headers.scala
76.92% <0.00%> (-9.45%)
:arrow_down:

.../src/main/scala/zhttp/service/DecodeJRequest.scala
0.00% <0.00%> (ø)

...e/server/ClearTextHttp2FallbackServerHandler.scala
0.00% <0.00%> (ø)

.../zhttp/service/server/EncryptedMessageFilter.scala
0.00% <0.00%> (ø)

...http/service/server/Http2OrHttpServerHandler.scala
0.00% <0.00%> (ø)

...cala/zhttp/service/server/HttpOnHttpsHandler.scala
0.00% <ø> (ø)

...http/service/server/OptionalServerSSLHandler.scala
0.00% <0.00%> (ø)

.../content/handlers/Http2ServerResponseHandler.scala
0.00% <0.00%> (ø)

...ttp/service/server/Http2ServerRequestHandler.scala
3.17% <3.17%> (ø)

.../scala/zhttp/service/server/ServerSSLBuilder.scala
12.50% <12.50%> (ø)

... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2ed52e...0c54df1. Read the comment docs.

on hold for now


Adding functionality to the company logo and enhancing the UI

Wanted to add the home page link to the company logo present in the navbar and in the footer.
Add enlarge on hovering effects to the "Categories" section.
Fixing the minor cursor bugs.

It already redirects to home.
As category cards are not interactive, these changes are not required.


Export model interfaces as default

🚀 Feature request
This is a very MINOR thing.
Current Behavior
Here's an example from the website:
import { pipe } from 'fp-ts/function'
import * as T from 'fp-ts/Task'

declare const encryptValue: (val: string) => T.Task<string>

pipe(
  T.Do,
  T.apS('x', encryptValue("hello")),
  T.apS('y', encryptValue("world")),
  T.map(({ x, y }) => { /* ... */ })
)

Notice how we have to write T.Task for the actual Task type.
Desired Behavior
It would be slightly nicer if we could write:
import { pipe } from 'fp-ts/function'
import Task, * as T from 'fp-ts/Task'

declare const encryptValue: (val: string) => Task<string>

pipe(
  T.Do,
  T.apS('x', encryptValue("hello")),
  T.apS('y', encryptValue("world")),
  T.map(({ x, y }) => { /* ... */ })
)

It doesn't seem like much for this example, obviously, but I have several modules that are full of functions that return Eithers. And having E.Either as the return type for a whole bunch of functions and consts is a little ugly. For those cases, I've taken to using two imports:
import * as E from 'fp-ts/Either'
import { Either } from 'fp-ts/Either'

Suggested Solution
If, e.g., Task were defined with export default interface Task<A> {...}, then we could write import Task, * as T from 'fp-ts/Task' and refer to Task without the T prefix.
Who does this impact? Who is this for?
It impacts anyone who shares exactly my aesthetic opinions. :)
Describe alternatives you've considered
Two import lines instead of one.
 They make importing, enforcing naming conventions and refactorings harder.

@mlegenhausen Should a library be enforcing naming conventions upon the consumers of the library?

Default exports are usually an anti-pattern. I think in a language where you can't import everything directly into the local environment, the case can be made that this would be a big ergonomic win over the status quo of either prefixed types or repeated import statements.


Populate the exception handler feature

Populate the IExceptionHandlerFeature when swallowing exceptions in the DeveloperExceptionPageMiddleware, following the same pattern as ExceptionHandlerMiddleware.
This is useful for building error reporting middleware that needs to send exceptions from development.
Outstanding questions:

I have only populated IExceptionHandlerFeature and not populated IExceptionHandlerPathFeature, should we also populate this feature as per ExceptionHandlerMiddleware?
Is it common practice to implement the feature interfaces in individual classes or should this share the ExceptionHandlerFeature class that ExceptionHandlerMiddleware uses?
I could not find any tests that check for features being populated, do you need me to write some?

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: martin308 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

I don't think this change is correct. The only reason that the Exception Handler middleware sets the feature is that it then goes and runs the middleware pipeline again so it needs to make the error details available to them.
The developer exception page, on the other hand, fully handles the error, so nothing else should see the error.
@Tratcher - did I get that right?

@Eilon's right. Only middleware in front of this one in the pipeline would be able to see this feature, and not until the exception page had already been written.

Is that not the same case with ExceptionHandlerMiddleware?
@Tratcher this is exactly the scenario that I want to cover. I am writing error reporting middleware which runs first in the stack using an IStartupFilter to notify of any exceptions that occur in the stack. I can check the IExceptionHandlerFeature feature and still report the exceptions when ExceptionHandlerMiddleware is being used but not DeveloperExceptionPageMiddleware

ExceptionHandlerMiddleware calls into a full request pipeline to render the error page and uses the feature to pass the exception up the stack, not down the stack to components before it.
Have you considered using DiagnosticSource or Logging to discover exceptions from the application? All of the exception handlers should write to these.
The other consideration is if your component is intended for use during development or production. ExceptionHandlerMiddleware is designed for production, where DeveloperExceptionPageMiddleware is strictly for development scenarios.

Is having the outermost middleware detect features from inner middleware break the design pattern you have here?
I had considered DiagnosticSource and Logging but at that point you have lost all of the http context information that makes error reporting in web applications quite useful. Unless I am missing something here?
I want the component to support as many user configurations as possible while making it as easy as possible to see exceptions out of the box (falling into the pit of success).
I want users to be able to add the code below and have things work without having to explain why having certain middleware in certain orders will mean that exceptions will not be detected.
public void ConfigureServices(IServiceCollection services)
{
  services.AddBugsnag(options => {
    options.ApiKey = "123456";
  });
}

Ah I do see the diagnostics source populates the http context! I will dig more into that if you think this will break the pattern that you have established

The diagnostics source will give you more reliable results than this change, and it's already available in the released packages. I'm going to close this PR for now. Let us know if you want to revisit this.


[AIFlow] Supports the workflow development on the Jupyter Notebook

Fix #140

Codecov Report

Merging #141 (40e231a) into master (b3f8c33) will decrease coverage by 0.15%.
The diff coverage is 21.15%.

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
- Coverage   58.95%   58.79%   -0.16%
==========================================
  Files         162      162
  Lines       12697    12745      +48
  Branches     1637     1648      +11
==========================================
+ Hits         7486     7494       +8
- Misses       4798     4837      +39
- Partials      413      414       +1

Impacted Files
Coverage Δ

ai_flow/workflow/workflow_config.py
62.31% <13.63%> (-23.10%)
:arrow_down:

ai_flow/api/ai_flow_context.py
47.82% <21.42%> (-16.46%)
:arrow_down:

ai_flow/__init__.py
100.00% <100.00%> (ø)

ai_flow/common/configuration.py
100.00% <100.00%> (ø)

...tification_service/notification_service/service.py
82.60% <0.00%> (-0.80%)
:arrow_down:

...otification_service/notification_service/client.py
77.11% <0.00%> (-0.29%)
:arrow_down:

..._service/notification_service/high_availability.py
86.80% <0.00%> (+1.38%)
:arrow_up:

...plugins/blob_manager_plugins/blob_manager_utils.py
88.88% <0.00%> (+3.70%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3f8c33...40e231a. Read the comment docs.


⚠ ClamAV has degraded performance

In 3e57985, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 440 ms

Resolved: ClamAV performance has improved in b22da8e.


Installation space

Hi everyone, does anyone know the space needed for the local installation of the Parcels code?

@erikvansebille, I talked with Sophie about this. My py3_parcels environment takes up about 3.3 GB. Should we keep track of this and maybe put in on the oceanparcels website?

Yes, anaconda is not small unfortunately. Using miniconda instead might reduce the size of the whole package a bit?
Note that parcels code itself is mere megabytes and all the example data is ~400MB. So the rest of the environment is taken up by the dependencies
@willirath and/or @CKehl, can you weigh in on how/whether we can/should reduce the space requirements for conda/parcels?

With Python and all the required sub-packages (i.e. dependencies) for numerical computation and notebook-interpretation (e.g. NumPy, SciPy, matplotlib, IronPython, Jupyter, etc.), 3.3 GB is actually quite small. My anaconda environment alone is 2.1 GB on Linux. If you run it all on Windows or Mac, the space requirement may be bigger because conda needs to pull and install packages that on Linux are part of the operating system by default.
I personally don't know about the different between Anaconda and Miniconda in installation size - nothing that really ever surfaced as a problem to me. Also, usually the space requirements for the fields of the simulation outweigh the conda space requirements by a substantial margin. I assume as long as the CI on github does not raise an error on space quotas for the installation, the installation size shouldn't be an issue to track continuously. That's just my personal opinion.


Custom image not showing up in Termite.

Hi! I'm having problems trying to display a custom image using the image="wallpaper" option, which is set in my config.
The image does not show up in Termite at all, not blinking, no image at all. This is with neofetch 2.0.2. It works fine in rxvt-unicode.
Screenshot:

Log:
neofetchlog.txt
EDIT 1: Updated with right log.txt.
EDIT 2: I can see that the thumbnails are correctly generated in ~/.cache/thumbnails/neofetch/pic.jpg
Previewing using feh works.

The log file tells me that Neofetch is working correctly.

Do you have a compositor running?

Do images work if you turn it off?

Do images work if you run Termite without its config file?

I need to be able to reproduce the issue to fix it and Termite + w3m-img work fine on my system. :P

That's interesting.

Do you have a compositor running?
Yes, Compton.
1.1 Do images work if you turn it off?
Exact same result as before.
Do images work if you run Termite without its config file?
Exact same result as before.

Yeah, of course, I understand. It's really weird.
Here is my neofetch config, if that would be for any help:
neofetchconfig.txt

The image I am using is a 4K image. Would that have any effect?

Nope.
Does this command work?

neofetch --config off --image wallpaper or neofetch --config off --image /path/to/img.jpg

One more thing: Do images work in ranger or w3m?

Ping @iyyel

I apologize for being absent. School just started up again, so I have had no time unfortunately. I'll edit this within an hour or so with the necessary information.

All good!

Does not work in ranger or w3m. I suppose that means its not neofetch specific then.

Yup, that confirms that it's an issue with your setup and w3m-img.
There's a patched termite in the aur that includes a w3m-img fix. I haven't tried it since default termite works on my system but it's worth a shot.
https://aur.archlinux.org/packages/termite-ranger-fix-git/

The issue only happen when using termite + bspwm it isn't a neofetch issue but a w3m + bspwm issue


Error when i access the doc in portuguese

I'm trying access doc of jest in portuguese, but is returned a error
http://facebook.github.io/jest/pt-BR/

Thanks for reporting!
http://facebook.github.io/jest/pt-BR/ seems to work for me, what do you mean by "error" is the page not loading a all?

Well, yesterday not was working.
The error was about "title" in someone file...Sorry, I forget to put the error in description.
But i happy that you give me a nice news, I will close the issue.
See ya!


Return empty list if archival memory search over empty local index

Please describe the purpose of this pull request.
Check to ensure that before a retriever is created (via LlamaIndex for local storage), the index is not empty.
Related issues or PRs
#401
Is your PR over 500 lines of code?
no

hmm, why are tests failing though

hmm, why are tests failing though

I think there's still some issue with tests on forks


typo: Double word "table"

@nschonni : Thanks for your contribution! The author, @allenwux, has been notified to review your proposed change.


Getting http error code 503 on any request

My Android app which had integrated Trakt for a few years now is getting 503 errors on any request that uses a proper and fresh access token.
Here's a log, invoking /users/settings just after getting a refreshed access_token that I verified is properly passed to "Bearer":
I   39:59.023  --> GET https://api.trakt.tv/users/settings h2
                        I   39:59.023  Host: api.trakt.tv
                        I   39:59.023  Connection: Keep-Alive
                        I   39:59.023  User-Agent: okhttp/4.10.0
                        I   39:59.023  Content-Type: application/json
                        I   39:59.024  Accept-Encoding: identity
                        I   39:59.024  trakt-api-key: <REDACTED>
                        I   39:59.024  trakt-api-version: 2
                        I   39:59.024  Authorization: Bearer <REDACTED>
                        I   39:59.024  --> END GET
                        I   39:59.143  <-- 503 https://api.trakt.tv/users/settings (119ms)

Same thing happens if I execute the same request via the web API test interface.
I do not know when exactly this happened,  and it could have been quite a while since Trakt is a very optional feature of my app and rarely used and a user just informed me about it.

Apparently the server is down or something, for all the requests I make it returns 503

https://github.com/trakt/api-help/discussions/385#discussioncomment-4443842

Indeed. I will close that issue.


[MB-14368] Fix typo to allow client to call endpoint

Jira ticket for this change
Summary
In one of the last commits in the previous PR for this work, introduced a typo in the code that finds the correct swagger definition for getting weight tickets
Setup to Run Your Code

💻 You will need to use three separate terminals to test this locally.
Terminal 1
Start the Storybook locally.
make storybook

Terminal 2
Start the UI locally.
make client_run

Terminal 3
Start the Go server locally.
make server_run

Verification Steps for Reviewers

Clicking into the Review Documents page should not show a console error

NOTE if you are not using S3 for storage the files will not load and that's expected. If you want to see the files loaded, follow the S3 instructions

Warnings

:warning:
This PR does not include changes to unit tests, even though it affects app code.

Messages

:book:
:link: MB-14368

  Generated by :no_entry_sign: dangerJS against 2ed6ab097c50fddd2a7c64e1f0d0e47c55a49642


Concurrent token refreshes can lead to unintentional signing out of users when multiple tabs are open

Bug report
Describe the bug
gotrue-js uses localStorage to store the refresh token. When the user has multiple tabs open, multiple instances of the GoTrueClient will be instantiated, with each reading from localStorage the same identical access and refresh tokens. There can be cases where both tabs will attempt to refresh using the same token at the same time, which leads to the first request succeeding, but the second request failing due to token reuse detection (https://github.com/supabase/gotrue/pull/226).
To Reproduce

Reduce the JWT expiry from the default 1 hour to 1 minute or lesser.
Login into an app using Supabase in a single tab.
Open the app in a second tab.
Open the network inspector and observe refresh token requests. Eventually both tabs will have failing requests due to reuse of the same refresh token.

Expected behavior
There is some kind of locking mechanism which avoids concurrent refreshes using the same refresh token. https://github.com/supabase/gotrue-js/pull/203 attempts to do this, but it doesn't account for the multi-tab use case.
System information
This is likely reproducible on other browsers, but here's the one I tested with:

OS: Windows
Browser (if applies): Firefox
Version of supabase-js: 1.28.6

Additional context
I will be testing out some changes to gotrue-js and will send a PR if it successfully fixes this issue.

@bnjmnt4n @inian I think this issue is not frontend related issue, I went deep into the gotrue server implementation, everytime you request a new refresh token, gotrue revokes the old one. As you are in different tabs with shared refresh tokens, the tab which does the refresh first revokes the refresh token for the other tabs, so the other tabs cant get a new access token. Overcoming this issue means that only one tab can make the refresh and it needs to share the access and refresh tokens with the others. Maybe the broadcast chanell api? The second option is to not revoke the refresh token, but that would blow the security.
From the GoTrue server source code, clearly visible that it revokes the old token.
// GrantRefreshTokenSwap swaps a refresh token for a new one, revoking the provided token.
func GrantRefreshTokenSwap(tx *storage.Connection, user *User, token *RefreshToken) (*RefreshToken, error) {
	var newToken *RefreshToken
	err := tx.Transaction(func(rtx *storage.Connection) error {
		var terr error
		if terr = NewAuditLogEntry(tx, user.InstanceID, user, TokenRevokedAction, nil); terr != nil {
			return errors.Wrap(terr, "error creating audit log entry")
		}

		token.Revoked = true
		if terr = tx.UpdateOnly(token, "revoked"); terr != nil {
			return terr
		}
		newToken, terr = createRefreshToken(rtx, user)
		return terr
	})
	return newToken, err
}

But if I missread somehow the go source code, please let me know.

@TheOnlyBeardedBeast The gotrue behaviour is correct; this is more of an issue with the gotrue-js implementation.

As you are in different tabs with shared refresh tokens, the tab which does the refresh first revokes the refresh token for the other tabs, so the other tabs cant get a new access token. Overcoming this issue means that only one tab can make the refresh and it needs to share the access and refresh tokens with the others.

This is exactly the gist of the problem. Both tabs do not notify each other that they are attempting a refresh, so it is possible for 2 parallel refresh attempts to occur at nearly the same time. One of them will likely succeed first, returning a new refresh token. However, the other refresh attempt will cause the new refresh token to be revoked due to the use of the same original refresh token.
I think there are possibly 2 paths to take:

If the same refresh token is used multiple times within a given period, do not revoke any descendant refresh tokens. This solution is brittle since network latency differs across users and regions, and potentially replay attacks could be used to generate/obtain new refresh tokens.
Implement a locking solution on the client-side to ensure that refreshes across multiple tabs will never use the same refresh token. I have some naive code which attempts to do locking via localStorage, but it is a bit of a mess, and I'll try to clean it up before potentially making a PR. (I need to double-check the integration with supabase-js as well.) BroadcastChannel or the web locking API isn't supported in Safari, so I didn't look into that. Perhaps the Web locking APIs could be used in the future as well.

@bnjmnt4n thanks for the reply, I am working on client myself handling the same issue (not gotrue-js, but the api was based on gotrue and behaves the same), currently what I am doing is listening to storage events and updating the clients refresh token memory representation in different tabs. It works well but I think in the future I can  encounter similar issues as you when a new tab is opened on the edge of the refresh interval of the current tab so a refresh starts while a different refresh is in progress. Perhaps a simple onetime retry after the first failed refresh happens could also help, that failed refresh would mean that a new refresh token should already exist in the storage. But your idea with a locking mechanism sounds good. You could wrap a storage change event into a promise, checking for a specific key, before the refresh request you can await that given promise which resolves when the given key does not exist in the storage, or its value means that a refresh is not pending in a different tab.
I will definitely try something out, thanks for the brainstorming.

IMO this race condition can be resolved with leader election. That is, we select a single tab, using a leader election algorithm, to perform the token refresh when it is time to perform a refresh. There's a tab-election package that we can take reference from.
Alternatively, a temporary cheap solution would be to randomize the time at which the token refreshes. Though an incomplete solution, this would significantly reduce the likelihood of a clash.

This is now being worked on server-side in gotrue: https://github.com/supabase/gotrue/pull/466

@chipilov I'm not able to reproduce this anymore. Can you provide some screenshots of your network tabs? For me it is now correctly working and replaying the request (see screenshots). Do note that the default reuse interval is 10s. So if the requests are further apart than that the tokens will be revoked.

Hi @thorwebdev,
I am attaching a screenshot of the issue:

Some additional info:

supabase-js is at 1.22.15;
GoTrue server for the project as reported by the /health API is at v2.6.30
I am using a pretty frequent refresh interval (30seconds) just to make it easier to repro
you can probably see from the timestamps of the requests but they are almost simultaneous so they definitely fall within the 10s interval

Finally, I am not sure what you mean by "replaying the requests". My impression was that the fix was entirely on the server side so that if 2 token refresh requests for the same token arrive at the server within 10s from each other both of them will receive 200 responses with the new token. Is that not the case (i.e. is there an additional retry handling in the client)?
Let me know if you need more info.

Hey @chipilov,

I am not sure what you mean by "replaying the requests"
Yes, if the reuse interval is set to 10s, then the client has a leeway time of 10 seconds to make the refresh using the same token. Gotrue will simply return the latest valid child token instead of generated a new one.

For example:
token | parent
foo       -
bar       foo

First request to refresh using token foo returns token bar. Reuse interval starts here.
As long as foo is still within the reuse interval, you can make as many requests to refresh as you like and gotrue will always return bar.
A token can be reused as long as it satisfies both of these conditions:

a. Token is used within reuse interval
b. Token must be the last revoked token
For example:
token | parent | revoked
foo       -        t
bar       foo      t
baz       bar      f

If a refresh request is made using bar to get baz, then trying to use foo to refresh again will trigger the automatic reuse detection and invalidate all it's descending tokens. This is because foo is now the second-last revoked token.

Just to close the loop on my particular issue: @kangmingtay identified the problem (a newly introduced env var was not loaded in my project for some reason) and fixed it - thanks!
So the server-side fix seems to work as long as the new env vars are properly loaded into a project.

I can still reproduce this bug with local supabase instance. Supabase-cli: 1.11.4, supabase-js: 2.0.4.  It looks like gotrue server (2.15.3) wasn't configured with GOTRUE_SECURITY_REFRESH_TOKEN_REUSE_INTERVAL variable. If I call two simultaneous refresh tokens requests, one of them always fails due to invalid refresh token.

@cinan how are you running the local supabase instance? is it with the docker-compose found here? if you are, then yeah we didn't add the necessary env vars to allow for that yet

I run supabase startwhich probably uses the docker-compose file you referenced. In docker inspect I can see there's no GOTRUE_SECURITY_REFRESH_TOKEN_REUSE_INTERVAL variable.


Roll engine 36b5b1936765..dfd281bcaefe (3 commits)

git@github.com:flutter/engine.git/compare/36b5b1936765...dfd281bcaefe
git log 36b5b1936765..dfd281bcaefe --no-merges --oneline
2019-08-23<EMAIL_ADDRESS>Roll src/third_party/skia 0f15d7373bf1..e8a2c8053daa (8 commits) (flutter/engine#11418)
2019-08-23<EMAIL_ADDRESS>Shrink cirrus docker image: reduce RUN count, apt-get clean (flutter/engine#11416)
2019-08-23<EMAIL_ADDRESS>Avoid root surface acquisition during custom composition with software renderer. (flutter/engine#11394)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (liyuqian@google.com), and stop
the roller if necessary.

Auto-roller completed checks. About to merge.


Intro to querying

Note: checklist below only relevant if committing to the develop branch:
Proposed changes
This is a placeholder notebook for the new Beginners_guide
Checklist (replace [ ] with [x] to check off)

[x] Notebook created using the DEA-notebooks template
[x] Remove any unused Python packages from Load packages
[x] Remove any unused/empty code cells
[x] Remove any guidance cells (e.g. General advice)
[x] Ensure that all code cells follow the PEP8 standard for code. The jupyterlab_code_formatter tool can be used to format code cells to a consistent style: select each code cell, then click Edit and then one of the Apply X Formatter options (YAPF or Black are recommended).
[x] Include relevant tags in the final notebook cell (refer to the DEA Tags Index, and re-use tags if possible)
[x] Clear all outputs, run notebook from start to finish, and save the notebook in the state where all cells have been sequentially evaluated
[x] Test notebook on both the NCI and DEA Sandbox (flag if not working as part of PR and ask for help to solve if needed)
[x] If applicable, update the Notebook currently compatible with the NCI|DEA Sandbox environment only line below the notebook title to reflect the environments the notebook is compatible with

Feel free to add to it but if not, I will continue working on it once back from leave next week.

@erialC-P I just did a quick tidy of the branch to remove all new notebooks except the one that's specific to the pull request (this will reduce the likelihood of merge conflicts in the future).
Before you do any more work, please run git pull to get the latest version of the branch!

Having viewed available products and measurements, users are introduced to querying in this notebook. dc.load, customisation options for dc.load and how to read your xarray are discussed.
To see where this notebook is designed to sit within the Beginners Guide folder, please see:
https://github.com/GeoscienceAustralia/dea-notebooks/wiki/DEA-notebooks-refresh:-notebook-allocations

I think the code formatting was an artefact of a copy/paste that I performed from an earlier notebook. I'm happy to fix this up and incorporate the suggested changes

@caitlinadams @erialC-P The code formatting was me - I somewhat deliberately changed the formatting from strict Black to line up some of the function calls to avoid the trailing [ and ']that Black likes to do... I just felt that thedc.loadcalls were a bit easier to read for beginner users if all of the arguments are nicely lined up. The stray'` and misaligned args should definitely be fixed up though!
Since I have the notebook already open, I'll quickly fix up those changes

My suggestions:
Comments:

be a little more explicit in the link between the Xarray DataArrays and Dataset
really briefly describe how keyword dictionary unpacking works (specifically the role of the **)

is it too unconventional to add a screenshot of what the progress bar looks like during data loading?


Properties with no type or format

Currently when a property inside components -> schemas -> {name} -> properties have not type or format it will display:

But it will also display this when for example a description is given.
I would like to see my description instead of No schema details found in the spec Example:

If that is my description.
( I can not set the type because the type changes depending on the users input. )

can you provide me with a minimal spec and complete spec for me to recreate this issue. I will see how best i can address this

Here is the minimal spec:
{
  "openapi": "3.0.0",
  "info": {
    "title": "",
    "description": "",
    "version": "0.1.0"
  },
  "servers": [
    {
      "url": "/api"
    }
  ],
  "paths": {
    "/count": {
      "get": {
        "description": "",
        "operationId": "get_count",
        "parameters": [],
        "responses": {
          "200": {
            "description": "",
            "content": {
              "application/json": {
                "schema": {
                  "$ref": "#/components/schemas/ApiItemCount"
                }
              }
            }
          }
        }
      }
    }
  },
  "components": {
    "schemas": {
      "ApiItemCount": {
        "description": "",
        "type": "object",
        "required": [
          "value"
        ],
        "properties": {
          "value": {
            "description": "This is my real description"
          }
        }
      }
    }
  }
}


Update azure-stack-updates.md

@justinincarnato : Thanks for your contribution! The author, @mattbriggs, has been notified to review your proposed change.

#sign-off


fix: do not create 0-sized KeepChunk

#616
#615
#614  👈 (View in Graphite)
master

This stack of pull requests is managed by Graphite. Learn more about stacking.


World Settlement Footprint Dataset

Proposed changes
Notebook created to load all WSF datasets.
Checklist (replace [ ] with [x] to check off)

[x ] Remove any unused Python packages from Load packages
[x ] Remove any unused/empty code cells
[x ] Remove any guidance cells (e.g. General advice)
[x ] Ensure that all code cells follow the PEP8 standard for code. The jupyterlab_code_formatter tool can be used to format code cells to a consistent style: select each code cell, then click Edit and then one of the Apply X Formatter options (YAPF or Black are recommended)
[x ] Include relevant tags in the first notebook cell and re-use tags if possible
[x ] Ensure appropriate colour schemes  have been used to maximise accessibility for vision impairment. Test your images or learn more with Coblis or TPGI
[x] Clear all outputs, run notebook from start to finish, and save the notebook in the state where all cells have been sequentially evaluated

Closes issues (optional)

Closes Issue #000

Evolution Dataset removed from the notebook


WMCore-05-2015-issues

Some candidate issues
https://github.com/dmwm/WMCore/milestones/WMAgent1503
(This list still need to be updated)
High Priority:
#5468 New workflow type for DQM aggregation (S) (deployed debugging)
#5848 Improve PSet configuration for multiRun harvesting jobs
#5849 DQMHarvest spec creates merge job instead of harvesting
#5854 remove unnecessary views from wmagent wmstats view
#5798 LumiList not added in the workload for TaskChain
#5793 SubscriptionInformation not in workload cache
#5711  add ability to change white site list after request is assigned
#5171 Improve request warning page in wmstats
#4671 create wmstats WMCore.REST server
#4837 rewrite CondorPlugIn for Condor 8 or upper version
#5647 Handle too many pending jobs
#5411 separate workflow completion from cleaning (work in progress)
#5339 #5340 #5341 #5342 #5344 #5347 #5343
#5345 #5346 #5264 #5360 Remove SE from WMAgent (Ax) (Testing)
ReqMgr2 api / GUI work - need to work on gradually (S, V)
Bug fixes:
#5847 Output dataset broken for TaskChains
#5832 Agent may not create phedex subscriptions eventually
#5825 move aborted workflow to aborted-archived when agent is not yet pulled the workflow
#5809 WQ trying to abort workflows in aborted-archived
#5171 need update output dataset whenever version is changed
#5086 Stageout code error handling fix for multiple files stageout
Medium Priority:
#5845 use pycurl for WMAgent and ReqMgr, etc
#5213 Oracle dead lock problem (Y) (on going)
#4331 Job creator having too many links (Ax) - (need to test)
#5146 WMStats stuck workflow warning
#5042 testing, validation, scripts (J, A, S) (there are 3 parts, json file update, injection script, and validation script) - first 2 parts are done
#5047 Adapt WMCore OS/Arch requirements to Glidein proposed version (done - need to be tested)

#4878 job splitting bug (A) - patch is created need to be tested (done?)

Fixed by #5860
Also adding this one to High Priority:
https://github.com/dmwm/WMCore/issues/5848 Improve PSet configuration for multiRun harvesting jobs (A)

Sorry, another High Priority
#5832 Agent may not create phedex subscriptions eventually

Thanks, Alan, I updated the issue. Please review

These look reasonable to me.

On May 7, 2015, at 20:06, ticoann<EMAIL_ADDRESS>wrote:
Some candidate issues
https://github.com/dmwm/WMCore/milestones/WMAgent1503 https://github.com/dmwm/WMCore/milestones/WMAgent1503
(This list still need to be updated)
High Priority:
#5468 https://github.com/dmwm/WMCore/issues/5468 New workflow type for DQM aggregation (S) (deployed debugging)
#5849 https://github.com/dmwm/WMCore/issues/5849 DQMHarvest spec creates merge job instead of harvesting
#5798 https://github.com/dmwm/WMCore/issues/5798 LumiList not added in the workload for TaskChain
#5793 https://github.com/dmwm/WMCore/issues/5793 SubscriptionInformation not in workload cache
#5711 https://github.com/dmwm/WMCore/issues/5711 add ability to change white site list after request is assigned
#5647 https://github.com/dmwm/WMCore/issues/5647 Handle too many pending jobs
#5411 https://github.com/dmwm/WMCore/issues/5411 separate workflow completion from cleaning (work in progress)
#5339 https://github.com/dmwm/WMCore/issues/5339 #5340 https://github.com/dmwm/WMCore/issues/5340 #5341 https://github.com/dmwm/WMCore/issues/5341 #5342 https://github.com/dmwm/WMCore/issues/5342 #5344 https://github.com/dmwm/WMCore/issues/5344 #5347 https://github.com/dmwm/WMCore/issues/5347 #5343 https://github.com/dmwm/WMCore/issues/5343
#5345 https://github.com/dmwm/WMCore/issues/5345 #5346 https://github.com/dmwm/WMCore/issues/5346 #5264 https://github.com/dmwm/WMCore/issues/5264 #5360 https://github.com/dmwm/WMCore/issues/5360 Remove SE from WMAgent (Ax) (Testing)
ReqMgr2 api / GUI work - need to work on gradually (S, V)
Medium Priority:
#5213 https://github.com/dmwm/WMCore/issues/5213 Oracle dead lock problem (Y) (on going)
#4331 https://github.com/dmwm/WMCore/issues/4331 Job creator having too many links (Ax) - (need to test)
#5146 https://github.com/dmwm/WMCore/issues/5146 WMStats stuck workflow warning
#5042 https://github.com/dmwm/WMCore/issues/5042 testing, validation, scripts (J, A, S) (there are 3 parts, json file update, injection script, and validation script) - first 2 parts are done
#5047 https://github.com/dmwm/WMCore/issues/5047 Adapt WMCore OS/Arch requirements to Glidein proposed version (done - need to be tested)
#4878 https://github.com/dmwm/WMCore/issues/4878 job splitting bug (A) - patch is created need to be tested (done?)
Bug fixes:
#5847 https://github.com/dmwm/WMCore/issues/5847 Output dataset broken for TaskChains
#5825 https://github.com/dmwm/WMCore/issues/5825 move aborted workflow to aborted-archived when agent is not yet pulled the workflow
#5809 https://github.com/dmwm/WMCore/issues/5809 WQ trying to abort workflows in aborted-archived
#5086 https://github.com/dmwm/WMCore/issues/5086 Stageout code error handling fix for multiple files stageout
—
Reply to this email directly or view it on GitHub https://github.com/dmwm/WMCore/issues/5867.

Eric W. Vaandering
Computing Physics Developer
CMS Computing Development Lead
Scientific Computing Division
Fermi National Accelerator Laboratory
630 962 7260 office
www.fnal.gov http://www.fnal.gov/


Preload dependencies during idle time?

Hey, cool to see you have abstracted away the lazy loading handling for large React tree.
I found the approach much better than what react-router is suggesting to do!
I'm wondering, do you have any plan preloading dependencies on the client side during the idle time?
I have been implemented a naive solution, I'm pretty sure we could improve that. It's preloading everything.
If we were collecting some data. For instance, the order of lazing loading, we could even build a prediction model. I have heard that Facebook is using a machine learning algorithm to smartly load dependencies ahead of time.

Hey @oliviertassinari!  Thanks!
Yeah, totally a great idea and I think @bradennapier has some alternative ideas around this problem.
It would be great to come up with a simple and flexible solution for this.  I'll review your solution when I get a chance and keep this in the back of my mind.  Happy to collaborate with you to get something awesome together.

Olivier, I may be misunderstanding your intent - but the fact the async loading is done using import which already returns promises, we shouldn't need to use setTimeout to accomplish nested asynchronous loading.
I have setup a method of handling routes asynchronously as well as their dependencies.
export default [
  {
    id: 'Home',
    exactly: true,
    props: {
      title: 'Home'
    },
    pattern: '/',
    component: () => import('./screens/Home')
  },
  {
    id: 'Welcome',
    props: {
      title: 'Welcome'
    },
    pattern: '/login/1',
    component: () => import('./screens/Welcome/Welcome')
  },
  {
    id: 'SecurityCenter',
    props: {
      title: 'Security Center'
    },
    pattern: '/security-center',
    secure: true,
    component: () => import('./screens/SecurityCenter')
  },
  {
    id: 'UserProjects',
    props: {
      title: 'Project Select'
    },
    pattern: '/project',
    component: () => import('./screens/UserProjects')
  },
  {
    id: 'LoginPage',
    props: {
      title: 'Login'
    },
    pattern: '/login',
    component: () => import('./screens/Login')
  }
]

Then when we move deeper into the routes we simply pass new routes that will be also imported asynchronously
import React from 'react'
import Resolver from 'app/resolver'

const routes = [
  {
    id: 'ProjectSelect',
    pattern: '/',
    exactly: true,
    component: () => import('./screens/ProjectSelect')
  },
  {
    id: 'ProjectDashboard',
    pattern: '/dashboard/:projectSlug',
    component: () => import('./screens/ProjectDashboard')
  }
]

export default props => (<Resolver {...props} routes={routes} />)

Then we have this as a Resolver:
const RoutedResolver = ({ routes, ...props }) => (

    {
      routes.map( route => {
        if ( ! route.id ) { throw new Error('Route Does not have an ID: ', route) }
        const matchProps = {
          ...route,
          key: route.id,
          exactly: route.exactly == true,
          pattern: route.pattern === '/'
            ? props.pathname
            : props.pathname + route.pattern
        }
        return <Match {...matchProps} render={ renderProps => {
            const appProps = {
              ...matchProps,
              ...renderProps,
            }
            return <Resolver {...props} {...appProps} />
          }}
        />
      })
    }

)

const Loading = () => (
LOADING
)

const Resolver = ({
  component, routes,
  isAuthenticated = false,
  defer  = false,
  secure = false,
  ...props
}, { store }) => {
  if ( secure && ! isAuthenticated ) {
    const { location, ...rest } = props
    store.dispatch({
      type: 'ROUTER_SECURE_REQUESTED',
      location: props.location,
      props:    rest
    })
    return null
  }
  const Component = routes
    ? RoutedResolver
    : component
      ? BuildAsyncComponent(component, secure || defer)
      : Loading
  if ( routes ) { props.routes = routes }
  //console.log('Resolver: ', props.id, props)
  return <Component {...props} />
}

Resolver.contextTypes = {
  store: PropTypes.object.isRequired
}

export const BuildAsyncComponent = (component, defer) =>
  createAsyncComponent({
    resolve: component,
    defer
  })

export default Resolver

Related: https://github.com/ctrlplusb/react-universally/issues/406


[UI v2 phase 3] Asset List Enhancement

Requirements:

Collate vintages into a single route for easier navigation (e.g., /VCS-182-2019 ➔ /VCS-182).
Update the Asset List UI to improve user experience.
Ensure the Asset List is sortable by price, date created, vintage & available tonnes.

User Story Reference: cmv2-p3-2 - As a user viewing the Project Detail page, I want to see a list of all available Assets for that project so that I can avoid having to compare across tabs.
Labels:
asset-list, ui-improvement

Duplicate


Update the mint module's docs

I also don't really get why we use annual provisions internally

@ValarDragon I removed the annual provisions #84


Liquidbase problem

i have this problem in the file wrapper.log
INFO|1584/0|Service traccar|17-02-15 22:12:38|INFO 2/15/17 10:12 PM: liquibase: Clearing database change log checksums
INFO|1584/0|Service traccar|17-02-15 22:12:38|INFO 2/15/17 10:12 PM: liquibase: Successfully acquired change log lock
INFO|1584/0|Service traccar|17-02-15 22:12:38|INFO 2/15/17 10:12 PM: liquibase: Successfully released change log lock
INFO|1584/0|Service traccar|17-02-15 22:12:38|INFO 2/15/17 10:12 PM: liquibase: Successfully acquired change log lock
INFO|1584/0|Service traccar|17-02-15 22:12:39|INFO 2/15/17 10:12 PM: liquibase: Reading from public.databasechangelog
INFO|1584/0|Service traccar|17-02-15 22:12:39|INFO 2/15/17 10:12 PM: liquibase: Reading from public.databasechangelog
INFO|1584/0|Service traccar|17-02-15 22:12:39|INFO 2/15/17 10:12 PM: liquibase: ./schema/changelog-master.xml: changelog-3.8::changelog-3.8-dropuniquetoken::author: Change set changelog-3.8::changelog-3.8-dropuniquetoken::author failed, but failOnError was false.  Error: ERRORE: il vincolo "uk_user_token" della relazione "users" non esiste [Failed SQL: ALTER TABLE public.users DROP CONSTRAINT uk_user_token]
INFO|1584/0|Service traccar|17-02-15 22:12:39|INFO 2/15/17 10:12 PM: liquibase: Successfully released change log lock

Please do a search before raising any new issues. Duplicate of #2851.


Display order lists not showing in product collection pages

https://support.bettercommerce.io/a/tickets/2234 - Display order lists not showing in product collection pages - Under product collection page its not showing the Display order. Same is happening in DEV as well. Currently Allow facet is ON for the collection where issue is report but if you turn ON and OFF the facets and then go to Display order they are appearing but then again if you refresh the page they are disappearing.
Loading...

Link to feature: https://bettercommerce.productboard.com/feature-board/planning/features/16365609


Handle signals with different cdims in dsp.convolve

Which issue(s) are closed by this pull request?
Closes #382
Changes proposed in this pull request:

add cdim handling to dsp.convolve
add testing thereof
add cdim to audio concept documentation because cdim is now mentioned in the docstring of dsp.convolve

I think everything is fine in deconvolve. Since we manually do that by matrix-multiplication the signals broadcast right away.


[Outlook] (preview) Add OWA support and instructions

Docs Build status updates of commit a4c427a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference/objectmodel/preview-requirement-set/outlook-requirement-set-preview.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Possible Bug: runtime error: invalid memory address or nil pointer dereference

Bug Report
Highlight: panic: runtime error: invalid memory address or nil pointer dereference. created by github.com/prometheus/prometheus/vendor/github.com/prometheus/tsdb.Open /home/prometheus/gocode/src/github.com/prometheus/prometheus/vendor/github.com/prometheus/tsdb/db.go:272 +0x468
What did you do?
Used https://github.com/prometheus/prometheus#building-from-source
to build Prometheus on Rasbperry Pi 3+, started node_exporter, and started Prometheus.
What did you expect to see?
Prometheus to keep running.
What did you see instead? Under which circumstances?
prometheus crashes about 1 minute after start
Environment

System information:
Linux 4.14.62-v7+ armv7l

Prometheus version:

 prometheus --version
prometheus, version  (branch: , revision: )
  build user:
  build date:
  go version:       go1.10.3

It was built from f033f48f74d84a65774b8acec4fe2225d0d588d5

Prometheus configuration file:

scrape_configs:
- job_name: 'node'
  static_configs:
  - targets: ['localhost:9100']

Logs:

prometheus@lnpi3:~/gocode/src/github.com/prometheus/prometheus $ prometheus --config.file=$HOME/.prometheus/prometheus.yml --storage.tsdb.path=$HOME/.promet
heus/data
level=info ts=2018-10-05T06:48:22.102210902Z caller=main.go:244 msg="Starting Prometheus" version="(version=, branch=, revision=)"
level=info ts=2018-10-05T06:48:22.102744076Z caller=main.go:245 build_context="(go=go1.10.3, user=, date=)"
level=info ts=2018-10-05T06:48:22.103079021Z caller=main.go:246 host_details="(Linux 4.14.62-v7+ #1134 SMP Tue Aug 14 17:10:10 BST 2018 armv7l lnpi3 (none))"
level=info ts=2018-10-05T06:48:22.103520789Z caller=main.go:247 fd_limits="(soft=1024, hard=1048576)"
level=info ts=2018-10-05T06:48:22.10383136Z caller=main.go:248 vm_limits="(soft=unlimited, hard=unlimited)"
level=info ts=2018-10-05T06:48:22.117884807Z caller=web.go:399 component=web msg="Start listening for connections" address=<IP_ADDRESS>:9090                     level=info ts=2018-10-05T06:48:22.117893244Z caller=main.go:562 msg="Starting TSDB ..."
level=info ts=2018-10-05T06:48:22.447124822Z caller=main.go:572 msg="TSDB started"                                                                          level=info ts=2018-10-05T06:48:22.447780911Z caller=main.go:632 msg="Loading configuration file" filename=/home/prometheus/.prometheus/prometheus.yml       level=info ts=2018-10-05T06:48:22.451325783Z caller=main.go:658 msg="Completed loading of configuration file" filename=/home/prometheus/.prometheus/prometheus.yml                                                                                level=info ts=2018-10-05T06:48:22.451899009Z caller=main.go:531 msg="Server is ready to receive web requests."

panic: runtime error: invalid memory address or nil pointer dereference
        panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x4 pc=0x12388]

goroutine 135 [running]:                                                                                sync/atomic.addUint64(0x13eae75c, 0x2, 0x0, 0x458ec442, 0x3fc82921)
        /home/prometheus/lightning_src/go/src/sync/atomic/64bit_arm.go:31 +0x4c
github.com/prometheus/prometheus/vendor/github.com/prometheus/client_golang/prometheus.(*histogram).Observe(0x13eae700, 0x458ec442, 0x3fc82921)
        /home/prometheus/gocode/src/github.com/prometheus/prometheus/vendor/github.com/prometheus/client_golang/prometheus/histogram.go:272 +0x60
github.com/prometheus/prometheus/vendor/github.com/prometheus/tsdb.(*LeveledCompactor).write.func1(0x13e65ddc, 0x13fad200, 0x13e94840, 0x40, 0x60273cb1, 0xbee5e03b, 0x20da4c7, 0xd, 0x1f0dca0)
        /home/prometheus/gocode/src/github.com/prometheus/prometheus/vendor/github.com/prometheus/tsdb/compact.go:436 +0x124
panic(0x10fdd98, 0x1f00f48)
        /home/prometheus/lightning_src/go/src/runtime/panic.go:502 +0x204
sync/atomic.addUint64(0x13eae7cc, 0x2, 0x0, 0x0, 0x40510000)
        /home/prometheus/lightning_src/go/src/sync/atomic/64bit_arm.go:31 +0x4c
github.com/prometheus/prometheus/vendor/github.com/prometheus/client_golang/prometheus.(*histogram).Observe(0x13eae770, 0x0, 0x40510000)
        /home/prometheus/gocode/src/github.com/prometheus/prometheus/vendor/github.com/prometheus/client_golang/prometheus/histogram.go:272 +0x60
github.com/prometheus/prometheus/vendor/github.com/prometheus/tsdb.(*instrumentedChunkWriter).WriteChunks(0x149a30c0, 0x14950320, 0x1, 0x1, 0x14950320, 0x1)
        /home/prometheus/gocode/src/github.com/prometheus/prometheus/vendor/github.com/prometheus/tsdb/compact.go:414 +0x74
github.com/prometheus/prometheus/vendor/github.com/prometheus/tsdb.(*LeveledCompactor).populateBlock(0x13fad200, 0x13e65e28, 0x1, 0x1, 0x148702a0, 0x14d17d0, 0x13f64000, 0x14c2e28, 0x149a30c0, 0x0, ...)
        /home/prometheus/gocode/src/github.com/prometheus/prometheus/vendor/github.com/prometheus/tsdb/compact.go:620 +0xc70
github.com/prometheus/prometheus/vendor/github.com/prometheus/tsdb.(*LeveledCompactor).write(0x13fad200, 0x7edd97c8, 0x21, 0x148702a0, 0x13e65e28, 0x1, 0x1, 0x0, 0x0)
        /home/prometheus/gocode/src/github.com/prometheus/prometheus/vendor/github.com/prometheus/tsdb/compact.go:472 +0x2f0
github.com/prometheus/prometheus/vendor/github.com/prometheus/tsdb.(*LeveledCompactor).Write(0x13fad200, 0x7edd97c8, 0x21, 0x14c7218, 0x149a2fc0, 0x3fcea800, 0x166, 0x403c8500, 0x166, 0x0, ...)
        /home/prometheus/gocode/src/github.com/prometheus/prometheus/vendor/github.com/prometheus/tsdb/compact.go:393 +0x294
github.com/prometheus/prometheus/vendor/github.com/prometheus/tsdb.(*DB).compact(0x13eae540, 0x0, 0x0, 0x0)
        /home/prometheus/gocode/src/github.com/prometheus/prometheus/vendor/github.com/prometheus/tsdb/db.go:404 +0x2ac
github.com/prometheus/prometheus/vendor/github.com/prometheus/tsdb.(*DB).run(0x13eae540)
        /home/prometheus/gocode/src/github.com/prometheus/prometheus/vendor/github.com/prometheus/tsdb/db.go:303 +0x218
created by github.com/prometheus/prometheus/vendor/github.com/prometheus/tsdb.Open
        /home/prometheus/gocode/src/github.com/prometheus/prometheus/vendor/github.com/prometheus/tsdb/db.go:272 +0x468

I'll take this. We simply have to update the vendoring for client_golang to include https://github.com/prometheus/client_golang/commit/7973e4709d98873b5b5bb9776a13156277c30dc5 .
Note: This is not in the release-2.4 brunch, but only in master.


match doesn't handle classes

Test case
import t from 'tcomb'

class A {}

console.log(t.match(new A(),
  A, () => 'A',
  t.Any, () => 'any'
))

throws [tcomb] Invalid type in clause #1

@volkanunsal I tried some alternative implementations but given the particular API of match:

type a tcomb type
guard an optional predicate (x: any) => any
block a function (x: any) => any called when the match succeeded

I'm afraid there no reliable way do detect a class instead of a guard or a block (they are all functions).

Thanks for looking into this. I guess we need to come up with out own guard function to get around it. Seems a little hacky, but still better than nothing.


add support for local embeddings with hf transformers

https://huggingface.co/jinaai/jina-embeddings-v2-base-en
https://huggingface.co/nomic-ai/nomic-embed-text-v1

here's a gist I made covering usage of the nomic-text-v1 model with ONNX - might help later.
there are likely further optimizations within onnx (or even openvino) to be made but I can get 2ish docs/sec at 8192 ctx on CPU, could be worse


[MB-14394] approveShipment refactor

Jira ticket for this change
Summary
No big changes, just broke up the testing a bit and the details value now includes ID
Setup to Run Your Code

💻 You will need to use three separate terminals to test this locally.
Terminal 1
Start the UI locally.
make client_run

Terminal 2
Start the Go server locally.
make server_run

Additional steps

Approve a shipment
Should pop up in the move history with shipment ID included

Verification Steps for Author
These are to be checked by the author.

[x] Have the Jira acceptance criteria been met for this change?

Verification Steps for Reviewers
These are to be checked by a reviewer.

Frontend

[ ] User facing changes have been reviewed by design.
[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
[ ] There are no new console errors in the browser devtools
[ ] There are no new console errors in the test output
[ ] If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.

Screenshots
Before:

After:

Messages

:book:
:link: MB-14394

  Generated by :no_entry_sign: dangerJS against eb0cdfaf23ad1464c38ebcda338faa60e1518ee1


Allow system-wide installation of innosetup installer

Some would want to have MicaForEveryone installed system-wide:

I tried this first but it breaks /S parameter support that's needed to install silently with winget.

I tried this first but it breaks /S parameter support that's needed to install silently with winget.

You need to pass /ALLUSERS or /CURRENTUSER for it to work. See Setup Command Line Parameters:

/ALLUSERS
Instructs Setup to install in administrative install mode. Only has an effect when the [Setup] section directive PrivilegesRequiredOverridesAllowed allows the commandline override.

/CURRENTUSER
Instructs Setup to install in non administrative install mode. Only has an effect when the [Setup] section directive PrivilegesRequiredOverridesAllowed allows the commandline override.

You need to pass /ALLUSERS or /CURRENTUSER for it to work.

Ok, thanks. Did you do it in your #102?

No. The action only uses YamlCreate.ps1 to update the installer links to the new versions. A PR must be created to fix it (use the one that will be created from the action when you make a new release).

We need to be able add custom fields to manifest to make it work, but it is not possible using winget-releaser.

We need to be able add custom fields to manifest to make it work, but it is not possible using winget-releaser.

Winget releaser just updates the links, you can directly PR to winget-pkgs.

Winget releaser just updates the links, you can directly PR to winget-pkgs for that.

Cool, then I'll do it soon.

Winget releaser just updates the links, you can directly PR to winget-pkgs for that.

Cool, then I'll do it soon.

You can include the change in the PR that winget releaser will generate in the next release.

@xmine64 Just a note, I'm currently adding additional information on the current MicaForEveryone package (https://github.com/microsoft/winget-pkgs/pull/67360). In my experience, YAMLCreate.ps1 is better than wingetcreate in creating packages, which is what this action is also using.

@xmine64 Just a note, I'm currently adding additional information on the current MicaForEveryone package (microsoft/winget-pkgs#67360). In my experience, YAMLCreate.ps1 is better than wingetcreate in creating packages, which is what the winget releaser action is also using.

Done. Can you merge this now?


feat: kusion watch supports batch/v1 resources

related: https://github.com/KusionStack/kusion/issues/23#issuecomment-1272888285

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 72.449%

Totals

Change from base Build<PHONE_NUMBER>:
0.3%

Covered Lines:
4573

Relevant Lines:
6312

💛  - Coveralls


plugin.google.maps.external.launchNavigation - problems with %20

Hello there.
I use an example from docs:
plugin.google.maps.external.launchNavigation({
"from": "Tokyo, Japan",
"to": "Kyoto, Japan"
});
And it calls Google Maps or Apple Maps with next strings:
Tokeyo,%20Japan
Kyoto,%20Japan
Nav map says that it's incorrect address.
I tried to comment next lines in External.m:
from = [from stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding];
to = [to stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding];
And after that everything works okay, without %20.
What's wrong? Mistake in plugin or I do something wrong?
Thanks.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/10149493-plugin-google-maps-external-launchnavigation-problems-with-20?utm_campaign=plugin&utm_content=tracker%2F637500&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F637500&utm_medium=issues&utm_source=github).

Please send me a pull request.

What do you mean?
I changed only two line just for test.

Please find the bug, then send me the patch. The all source code is open.

The bug is fixed. Use the master branch.
$> cordova plugin rm plugin.google.maps
$> cordova plugin add https://github.com/wf9a5m75/phonegap-googlemaps-plugin --variable ...


add a release deployment event when reconciling a release

At the moment, you are not sure if the release has started and you have to wait for events showing its success or failure, or watch the status of k8s resources.
This adds an event notifying us that a release has started, we have found this to be especially useful for our slack messages in our deployment channels.

@hiddeco yep, can do! Is that ok? I thought i would stick to similar wording as the success event being Helm upgrade succeeded.

@william-salt-cko I think that in e.g. notification messages it is helpful to be notified of the precise action, because seeing an installation while you were expecting an upgrade may help you detect an e.g. miss-configuration faster.


[Backport to 2.0] Fix 'openserach' typo in constants.tsx (#953)

Signed-off-by: Cam McKenzie<EMAIL_ADDRESS>Description
Backport PR #953 to 2.0
Category
bug fix
Why these changes are required?
What is the old behavior before changes and new behavior after changes?
Issues Resolved
[List any issues this PR will resolve (Is this a backport? If so, please add backport PR # and/or commits #)]
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List

[ ] New functionality includes testing
[ ] New functionality has been documented
[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #961 (3ca38c0) into 2.0 (7420eb2) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 3ca38c0 differs from pull request most recent head 8368742. Consider uploading reports for the commit 8368742 to get more accurate results

@@           Coverage Diff           @@
##              2.0     #961   +/-   ##
=======================================
  Coverage   72.14%   72.14%
=======================================
  Files          87       87
  Lines        1906     1906
  Branches      242      242
=======================================
  Hits         1375     1375
  Misses        477      477
  Partials       54       54

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7420eb2...8368742. Read the comment docs.

@ylwu-amzn This PR needs to be included in the release notes if this will be merged to 2.0. The release notes change also needs to be made in main, 2.x and 2.0 branches.

Thanks @peternied for adding this. We should merge this PR after 2.0-rc1 release.

I have no permission to merge PR. Security team please help merge.


Web Map "Monterey Airport (Compound Map)" references URLs external to NSEC server/portal site

Item id 46193871c5c247d2b60b22be0b3e8947   references the following URLs that are external to NSEC server/portal site:
https://services.arcgisonline.com/ArcGIS/rest/services/World_Imagery/MapServer
All operational layers reference services on the NSEC server/portal so I would expect that the basemap service should also reference the applicable basemap service on NSEC.

This Web Map has had the basemap pointed to: https://nsec.esri.com/ags/rest/services/Basemaps/Imagery/MapServer

I changed the basemap to point to the NSEC Imagery Basemap.