support wider range of clang versions

On Fri, Jul 13, 2018 at 06:31:29AM -0700, ftynse wrote:

ftynse approved this pull request.

@@ -391,6 +391,25 @@ bool generator::first_arg_is_isl_ctx(FunctionDecl *fd)
return is_isl_ctx(param->getOriginalType());
}

+namespace {
+
+struct ClangAPI {
This can be a (non-anonymous) namespace instead

Hmm... I was just trying to mimic the ClangAPI in extract_interface.cc.
I'm not sure why a struct was used there.  I didn't write that part and
I didn't question it when it was introduced.
Maybe a namespace is cleaner...
skimo

On Fri, Jul 13, 2018 at 03:40:18PM +0200, Sven Verdoolaege wrote:

On Fri, Jul 13, 2018 at 06:31:29AM -0700, ftynse wrote:

ftynse approved this pull request.

@@ -391,6 +391,25 @@ bool generator::first_arg_is_isl_ctx(FunctionDecl *fd)
return is_isl_ctx(param->getOriginalType());
}

+namespace {
+
+struct ClangAPI {
This can be a (non-anonymous) namespace instead

Hmm... I was just trying to mimic the ClangAPI in extract_interface.cc.
I'm not sure why a struct was used there.  I didn't write that part and
I didn't question it when it was introduced.
Maybe a namespace is cleaner...

Actually, trying it out now, I remember I tried it out before.
Using struct avoid the generation of an unused function warning.
skimo

Ok, although it's inconsistent for a compiler to warn about unused functions but not about unused member functions when the class is wrapped in an anonymous namespace.


Update to dbus-next 0.5.1

The connection member of the bus has been made private. Errors are
forwarded to the bus itself. Use the new disconnect() method to
diconnect from the bus during testing.

I think we should release after this. Everything is more stable now.

Thanks!


[BUG] User lacks permission to update ChatMessage

Describe the bug
Whenever a chat message is produced, the other players (but not the GM) get shown an error message.
Possibly an interaction with the module ChatPortrait. Didn't happen before Simple Calendar 2.4.8.
User lacks permission to update ChatMessage [E05uWeGYTTzuIZS1] foundry.js:68326:78
    fetch foundry.js:68326
    notify foundry.js:68223
    error foundry.js:68260
    _handleError foundry.js:3468
    dispatch foundry.js:3450
    value socket.js:532
    value socket.js:459
    emit index.mjs:136
    value manager.js:207
Foundry VTT | Created ChatMessage with id [E05uWeGYTTzuIZS1]

Error: User lacks permission to update ChatMessage [E05uWeGYTTzuIZS1]
index.js:1:69208
    addGameTimeToMessage modules/foundryvtt-simple-calendar/index.js:1

TypeError: Error thrown in hooked function '' for hook 'preCreateChatMessage'. speakerInfo.author is undefined
[Detected 1 package: chat-portrait]
    userByAlias ChatPortrait.js:1125
    find commons.js:4167
    loadImagePathForChatMessage ChatPortrait.js:1124
    setupHooks main.js:131
    #call foundry.js:730
    call foundry.js:712
    #preCreateDocumentArray foundry.js:13542

"Source" is this:
class Ye {
          static addGameTimeToMessage(e) {
            const s = R.getActiveCalendar(),
            a = {
              id: s.id,
              timestamp: s.toSeconds()
            };
            e.setFlag(t, 'sc-timestamps', a).catch((e => {
              console.error(e)
            }))
          }

To Reproduce

Log in as a user
Have a second user roll or write a chat message
First user sees the error message

Foundry Information

Foundry Version: 11.315
Game System: pf1e 9.6
Simple Calendar Version: 2.4.8

Browser (please complete the following information):

Browser: Firefox 123.0 (64-bit)

Additional context
This module is installed as well: https://github.com/p4535992/foundryvtt-chat-portrait

Okay, I can confirm that this issue is fixed for me in 2.4.9. Thanks! :)


[Docs] Add Google Colab support to .ipynb tutorials

Add "Open in Google Colab" button to .ipynb tutorials
On Tensorflow's doc sites, each interactive tutorial has a one-click open to open it on Google Colab - Google's interactive web editor for Python notebooks. See this example for post training integer quantization (screenshot below).

I'm currently messing around with some microTVM tutorials, so I'll see if I can get a demo of this running there. "Open in Colab" is one of my favorite things about the Tensorflow and Keras docs, and I'd love to integrate the feature here too.
Additions/Changes Requested
While the buttons look fancy, each is just a URL underneath. The "view source on Github" link is just a hardcoded URL to the Github repo - nothing fancy. For the open in Colab button, we just take that same hardcoded URL, but prepend "colab.research.google.com" and Colab takes care of the rest. Here's the link that powers the button above:

https://colab.research.google.com/github/tensorflow/tensorflow/blob/master/tensorflow/lite/g3doc/performance/post_training_integer_quant.ipynb

For this to be effective, perhaps it would be good to have a pre-build Colab binary of TVM than can be wget'd into the notebook's VM?
Otherwise the notebook would always need to begin with the user downloading and building TVM from scratch.

As of December this year, we had a pip installable version, and I was able to get TVM building in Google Colab notebooks - I used it for my TVMCon talk.

That's great, I must have missed that talk.  Do you have a link for it?
Is this the TLCPack mentioned in the current docs, or some other system?

Yep, it's TLCPack - you just have to run:
pip install tlcpack-nightly -f https://tlcpack.ai/wheels

You can see the talk here - I use a Python notebook to compile a model for Arduino. I'm currently working on adapting a version of that notebook to be included with the docs (working on and off - I'm in school right now) but that's my motivation for this feature/

@guberti we are in the process of adding TVM pip release. So we should be able to use pip install apache-tvm sometimes in near future.

Over the last two weeks, I've spent some cycles trying to understand how this would work. On the surface, it is simple enough - just add a link to the TVM site repo. For example, clicking on this URL will open the micro_tflite tutorial in Colab, which can be done without modifying the code at all:
https://colab.research.google.com/github/apache/tvm-site/blob/asf-site/docs/_downloads/5b279d8a8718816263fa65b0eef1a5c0/micro_tflite.ipynb
However, if you try messing around with that .ipynb notebook, you will find it does not work. This is for two reasons - (a), the Bash blocks (which install dependencies) are not runnable, and (b) code often needs slight tweaks to run as a Python notebook. These issues are not unique to Google Colab at all - very few of the .ipynb files you can download from the documentation website actually work.
At some point, we ought to have a discussion about whether sphinx-gallery is the right tool for our documentation, as it is not all that mature a project. However, that's a separate issue, so I did some work and made two pull requests to sphinx-gallery to fix the two issues mentioned above:

https://github.com/sphinx-gallery/sphinx-gallery/pull/940
https://github.com/sphinx-gallery/sphinx-gallery/pull/941

Once these pull requests get merged, then if we choose to update our sphinx-gallery version, we will be able to generate .ipynb files that actually work as intended. This will also allow us to have a "open in Google Colab" button.

I have a prototype of this working! See #10921, though it still requires those changes to Sphinx Gallery mentioned above. You can also check out the HTML tutorial at:
https://guberti.github.io/tvm-docs-proof-of-concept/

This feature is now working on production! See https://tvm.apache.org/docs/how_to/work_with_microtvm/micro_train.html. Hopefully having a working example makes it easier for other tutorial writers to also add Colab support.


swaggerTS generates types but not the functions

What version of kubb is running?
2.12.1
What platform is your computer?
MacOS
What version of external packages are you using(@tanstack-query, MSW, React, Vue, ...)
No response
What steps can reproduce the bug?
use the following kubb.config.ts
import { defineConfig } from '@kubb/core'
import { definePlugin as createSwagger } from '@kubb/swagger'
import { definePlugin as createSwaggerTS } from '@kubb/swagger-ts'

export default defineConfig({
  root: '.',
  input: {
    path: 'https://docs.machines.dev/spec/openapi3.json',
  },
  output: {
    path: './src/gen',
    clean: true,
  },
  plugins: [
    createSwagger({ validate: false }),
    createSwaggerTS({
      output: {
        path: 'fly-api.ts',
      },
    }),
  ],
})

run kubb generate
How often does this bug happen?
Every time
What is the expected behavior?
generates the types and the function
Swagger/OpenAPI file?
No response
Additional information
No response

What do you mean with functions? The API client(axios.get, axios.put)?

@fredericrous Aah okaay. @kubb/swagger/ts will only generate types and enums. To call an API endpoint you also need https://docs.kubb.dev/plugins/swagger-client/. That one will use @kubb/swagger/ts to generate some get/post/put helpers.
Example: https://docs.kubb.dev/examples/client
(I'm working on an update for the docs with an example of using the clients)


how can i install it??

can someone help me to install this instabot

Please read the documentation.


Embedding API: How to store private data in a class instance?

Introduction
I read that the embedding is not fleshed out yet. But I am anxious to try this.
While browsing through wren's source, I could not find a way to do this but maybe I am missing something.
Naive solution
What I want to do is something like this:
wren 'user' source code
// untested wren (pseudo) code
webserver = new Webserver( "localhost", 8888, 60 )
webserver.addDocumentRoot( "/static/(?<path>.*)", "../var/www/static" )

Looking at a wren.h, the following comes to mind:
c embedding source code
// untested c (pseudo ) code
static void Wn_Webserver_Constructor( WrenVm * runtime ) {
    ObjClass * thisObj  = wrenGetArgumentObject( runtime, 0 );
    const char * hostName = wrenGetArgumentString( runtime, 1 );
    uint16_t portNr = (uint16_t)  wrenGetArgumentDouble( runtime, 2 );
    int timeout = (int)  wrenGetArgumentDouble( runtime, 3 );
    struct webserver_t ws = Webserver_New( hostName, portNr, timeout );
    if ( ws != NULL ) {
        wrenSetPrivate( thisObj, (void*) ws );
        wrenReturnBool( runtime, true );
        return;
    }
    wrenReturnBool( runtime, false );
}

static void Wn_Webserver_AddDocumentRoot( WrenVm * runtime ) {
    ObjClass * thisObj  = wrenGetArgumentObject( runtime, 0 );
    struct webserver_t * ws = ( struct webserver_t *) wrenGetPrivate( thisObj );
    if ( ws != NULL ) {
        const char * pattern = wrenGetArgumentString( runtime, 1 );
        const char * folder = wrenGetArgumentString( runtime, 2 );
        Webserver_AddDocumentRoot( ws, pattern, folder );
        wrenReturnBool( runtime, true );
        return;
    }
    wrenReturnBool( runtime, false );
}

static void Wn_Webserver_Destructor( WrenVm * runtime ) {
    ObjClass * thisObj  = wrenGetArgumentObject( runtime, 0 );
    struct webserver_t * ws = ( struct webserver_t *) wrenGetPrivate( thisObj );
    if ( ws != NULL ) {
        Webserver_Delete( ws );
        wrenReturnBool( runtime, true );
        return;
    }
    wrenReturnBool( runtime, false );
}

void Wren_Run_MyStuff( WrenVM * runtime ) {
    wrenDefineStaticMethod( runtime, "webserver", "new", 2, Wn_Webserver_Constructor );
    wrenDefineMethod( runtime, "webserver", "addDocumentRoot", 2, Wn_Webserver_AddDocumentRoot);
    wrenDefineMethod( runtime, "webserver", "delete", 0, Wn_Webserver_Destructor );
    //.. compile the wren 'user' source code and process it.
}

Discussion
Now assume that Webserver_New Webserver_AddDocumentRoot  and Webserver_Delete are in a seperate h and c file and later on linked to the executable.
Changes needed
That would mean that by adding the following 3 functions to wren would get us a long way.
ObjClass *     wrenGetArgumentObject    ( runtime, int index );
void          wrenGetPrivate        ( ObjClass * object );
void          wrenSetPrivate        ( ObjClass * object, void * data );
Unfortunately
* When the wrenGetPrivate function is called, should it stay on this instance, or visit it's parents?
* Will the wrenDefineStaticMethod 'new' and/or 'delete' function names be 'reserved'; Will it be assured that these are only called by the wren runtime and not in a user script?

Options
Set private with constructor
Instead of:
void          wrenSetPrivate        ( ObjClass * object, void * data );

it could be:
void          wrenSetPrivate        ( ObjClass * object, void * data, WrenForeignMethodFn *  method );
and upon GC, the method is called.

Defineclass
The Api could be extended with another 2 functions like:
void wrenDefineClass(  WrenVM * runtime, const char * className, WrenForeignMethodFn constructor, int arityConstructor, WrenForeignMethodFn destructor );  //  assuming that the destructor will have arity = 0 as it is only called by the GC
void wrenDefineDestructor(WrenVM* vm, const char* className, WrenForeignMethodFn method, int arityConstructor );  //  to allow also different constructors

TL;DR
How should I use wren's API to store arbitrary data in a class's instance?
I have no clue, but might be able to produce something if I know what direction to take.
Epiloge
This issue was first posted on the mailing list. As Bob pointed out, it is a missing feature. Right now, Wren has no concept of "user data". Probably something roughly similar to what Lua does: http://www.lua.org/pil/28.1.html would be fine
Peter Reijnders

My thoughts will probably be disorganized here because I haven't put too much mental effort into this yet, but I figured as should at least put down what I have.
I'm hoping to avoid exposing very many types in Wren's public API. So things like ObjClass and such that are used internally in the VM are not visible to embedders. All they see is a functional API that just takes and returns vanilla C values.
That's in conflict with some of what you propose, but I don't think it's the end of the world. If I understand you correctly, the idea is that each instance has a single private void* pointer that the embedder can get and set.
That works, but I think we'll want to be more flexible. It would be more powerful if the embedder can have userdata objects that have arbitrarily-sized blobs of memory. Here's what I'm thinking. We add this function to the API:
wrenDefineInstantiator(WrenVM* vm, const char* className,
                       WrenInstantiateFn instantiator);

("Instantiator" is lame. We'll have to come up with a better name.) If you call this and pass in some class name, it takes that's class's normal allocation behavior and replaces it with some code that calls your C function. Your function's signature is:
size_t WrenInstantiateFn(WrenVM* vm)

Your just is to just return how many bytes of data you want your object to have.
Note that you don't have access to the constructor parameters. Construction in Wren goes in two steps: instantiation then initialization. Normally the instantiation step just creates an object of the proper size. Then the initialization step is where the contructor bodies run.
This C function is replacing the instantiation step. The separation here is necessary because of how constructors can call superclass constructors. You have to have a fully usable this before any constructor bodies start running, which means you have to allocate first.
So, if you call wrenDefineInstantiator(), you replace the normal class instantion process with your own. This means the class probably can't have any regular instance fields. All of the memory the class is owned by you, the embedder now.
To do something with that data, you'll define foreign methods as usual. In those, you'll call a new function:
void* wrenGetArgumentData(WrenVM* vm, int index);

Again, the name is terrible. But this will look up the argument at index and, assuming its an instance of a class that you previously called wrenDefineInstantiator() for, this will give you back a pointer to the number of bytes you requested.
That's well and good, but you never actually got to initialize this memory, right? Well, for that, I think you should just be able to define new itself as a foreign method. In other words, make your class's constructor a foreign method. I think that will just work. If not, you could always define the constructor in Wren and have it invoke some other foreign "initialize" method you define.
The remaining piece is how it interacts with the GC. We'll likely need another function where you can define a finalizer for a class. That will get called before memory for the object is freed.
What do you think?

Single private void *
Yes, I am looking for a way to eventually start a single private void* pointer to store in each instance.
It does not need to change after the 'construction' any more, but it must be free-ed when the class is destructed by the function that the embedder assigns it to.
As you are strictly exposing only c-things, this is a good idea indeed.
Further questions
[ ] Will the 'new' static method be called automatically when the object is intsantiated?

webserver = new Webserver( "localhost", 8888, 60 )

or should it be

webserver = Webserver.new( "localhost", 8888, 60 )

[ ] What will happen if the 'new' is called again?
or should in be a reserved method name, that may not be called by the usercode?

w1 = new Webserver( "localhost", 8888, 60 )
w1 = w1.new( "<IP_ADDRESS>", 80, 60)

[ ] A finalizer is for the void pointer in the instance is needed.
Bbut this probably won't change at runtime. I think the embedder could know how to clean up while he is writing the WrenInstantiateFn. It could even be:

typedef void (WrenDestructFn)(WrenVM vm, void * privateData );
wrenDefineInstantiator(WrenVM* vm, const char* className, WrenInstantiateFn instantiator, WrenDestructFn destructor);

That would eliminate the need for a 'delete'.
Naming
Naming is one of those dificult things indeed. What about WrenDefineClass

[ ] Will the 'new' static method be called automatically when the object is intsantiated?

Yes. It's technically an instance method (this it has access to this in its body), but in either case, when you do new Foo(1, 2, 3), Wren compiles it to something approximately like:
var foo = Foo.instantiate
foo.new(1, 2, 3)`

I say approximately because if you hand-write this code, it won't work. The actual names of the "instantiate" and "new" methods aren't normal identifiers (they're  instantiate with a leading space and new, a reserved word).
The instantiate method creates a new, empty uninitialized object. Then the new method runs the constructor body on it.
With wrenDefineInstantiator(), I'm proposing that you would essentially provide a foreign function definition of instantiate.

[ ] What will happen if the 'new' is called again?

Since new is a reserved word, you can't actually manually invoke a constructor on an existing object. foo.new is a parse error.

[ ] A finalizer is for the void pointer in the instance is needed.

For foreign objects whose private data has a pointer, yeah, you'll almost always need a finalizer too. However, there are lots of possible foreign objects that wouldn't. You could, for example, define your own matrix or vector type. You might want to define them in C for performance. Since wrenDefineInstantiator() would let you allocate an object with enough memory for the matrix or vector elements right inline with the object, there'd be no need for a pointer. Since they're just numbers, there's nothing to free when the object is GCed.

What about WrenDefineClass

I don't think that conveys the right idea. It's not that you're creating a class, it's that you're creating (or modifying an existing one) such that its state is foreign.

This is bug is very apparent when trying to create Wren wrappers for C libraries. I tried to hack around on a SQLite interface in Wren the other day but there's no way to connect the SQLite data in C with an instance of a Wren class.

Yeah, I totally agree. This is a high priority.
I need to get a unit testing story in place for the embedding API. I started hacking on it a bit but I haven't gotten it fully working. Once that's going, it will be easier to add stuff like this. Right now, I'm hesitant to add things that aren't tested, so this is sort of gated on that.

This seems a chicken-and-egg-situation.
What would be the best way to proceed?

Shall I create a fresh branch for this and add a test (XP-style)
Can I create a test situation based on the things that you allready created?

If you'd like to start working on this in parallel, that's fine. In the meantime, I'll try to make some more progress on the unit testing support I started hacking on locally. Once that's in place, you'll be able to come back around and use that to write tests for this.
How does that sound?

Sounds cool. I am really curious to your work.
In the mean time I started with what I understood so far.

I finally carved out some time to think about this and wrote up a little proposal. I think it's fairly similar to what you have here, modulo the changes in constructors and the embedding API that have happened since you wrote this. What do you think?

OK, now that foreign classes and finalizers are working, I'm calling this complete. I think they should cover your use cases here but let me know if you need anything else.


Revert RAS Category and Fabric API commits (#35, #83)

This reverts commits:

7de96547c9b3bc190606eb0a3327e465e6c52459
5ced682e98bf10002d2c3e519373a312f883dadd

...due to a binary incompatibility regression.

Removing these functions and enums is also a backwards-compatibility break.   How can we be certain we aren't breaking a different user/application by removing this?


[Snyk] Upgrade org.apache.jena:jena-text from 4.9.0-SNAPSHOT to 4.10.0

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade org.apache.jena:jena-text from 4.9.0-SNAPSHOT to 4.10.0.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 41 versions ahead of your current version.
The recommended version was released 6 months ago, on 2023-10-24.

The recommended version fixes:

Severity
Issue
PriorityScore (*)
Exploit Maturity

Improper Neutralization of Special Elements used in an Expression Language Statement ('Expression Language Injection') SNYK-JAVA-ORGAPACHEJENA-6043134
116/1000  Why? Confidentiality impact: Low, Integrity impact: Low, Availability impact: Low, Scope: Unchanged, Exploit Maturity: No data, User Interaction (UI): None, Privileges Required (PR): None, Attack Complexity: Low, Attack Vector: Network, EPSS: 0.00156, Social Trends: No, Days since published: 299, Reachable: No, Transitive dependency: Yes, Is Malicious: No, Business Criticality: High, Provider Urgency: High, Package Popularity Score: 99, Impact: 5.62, Likelihood: 2.06, Score Version: V5
No Known Exploit

(*) Note that the real score may have changed since the PR was raised.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Checkmarx One – Scan Summary & Details – f7f57c5e-380d-42ec-ba7a-cbe9dc1cd3ce
New Issues

Severity
Issue
Source File / Package
Checkmarx Insight

CVE-2022-46337
Maven-org.apache.derby:derby-<IP_ADDRESS>
Vulnerable Package

CVE-2023-36478
Maven-org.eclipse.jetty:jetty-http-10.0.15
Vulnerable Package

CVE-2023-43646
Npm-get-func-name-2.0.0
Vulnerable Package

CVE-2023-45133
<EMAIL_ADDRESS>Vulnerable Package

CVE-2024-23331
Npm-vite-4.0.4
Vulnerable Package

CVE-2024-4067
Npm-micromatch-4.0.5
Vulnerable Package

CVE-2024-4068
Npm-braces-3.0.2
Vulnerable Package

CVE-2022-29622
Npm-formidable-1.2.6
Vulnerable Package

CVE-2023-26159
Npm-follow-redirects-1.15.2
Vulnerable Package

CVE-2023-28155
<EMAIL_ADDRESS>Vulnerable Package

CVE-2023-36479
Maven-org.eclipse.jetty:jetty-servlets-10.0.15
Vulnerable Package

CVE-2023-40167
Maven-org.eclipse.jetty:jetty-http-10.0.15
Vulnerable Package

CVE-2023-42503
Maven-org.apache.commons:commons-compress-1.23.0
Vulnerable Package

CVE-2023-44270
Npm-postcss-8.4.21
Vulnerable Package

CVE-2023-45857
Npm-axios-0.27.2
Vulnerable Package

CVE-2023-46749
Maven-org.apache.shiro:shiro-web-1.11.0
Vulnerable Package

CVE-2023-46750
Maven-org.apache.shiro:shiro-web-1.11.0
Vulnerable Package

CVE-2024-25710
Maven-org.apache.commons:commons-compress-1.23.0
Vulnerable Package

CVE-2024-26308
Maven-org.apache.commons:commons-compress-1.23.0
Vulnerable Package

CVE-2024-28849
Npm-follow-redirects-1.15.2
Vulnerable Package

CVE-2024-29041
Npm-express-4.18.2
Vulnerable Package

CVE-2024-31207
Npm-vite-4.0.4
Vulnerable Package

Improper_Restriction_of_Stored_XXE_Ref
/jena-iri/src/test/java/org/apache/jena/iri/TestMoreExamples.java: 239
Attack Vector

Improper_Restriction_of_Stored_XXE_Ref
/jena-iri/src/test/java/org/apache/jena/iri/TestCreator.java: 81
Attack Vector

Use_of_Cryptographically_Weak_PRNG
/jena-arq/src/main/java/org/apache/jena/sparql/expr/E_Random.java: 34
Attack Vector

Fixed Issues

Severity
Issue
Source File / Package

CVE-2022-38900
Npm-decode-uri-component-0.2.2

Host Namespace is Shared
/docker-compose.yaml: 20

Networks Not Set
/docker-compose.yaml: 20


Dynamis PRC dataset submission

Hi Marco, everything is looking pretty good.
There is one small issue, the big yellow cones in the data set are not labeled as seen in the attached image .
Could you please add labels for the images with big yellow cones and add the class to the classes index text file?

Yes sure, i'll do that this afternoon and commit the changes. Thank you
Il mar 26 nov 2019, 14:07 David Dodel<EMAIL_ADDRESS>ha scritto:

Hi Marco, everything is looking pretty good.
There is one small issue, the big yellow cones in the data set are not
labeled as seen in the attached image [image: image 448]
https://user-images.githubusercontent.com/18621443/69636055-0c6e2b80-1056-11ea-8e47-89546898c025.jpg
.
Could you please add labels for the images with big yellow cones and add
the class to the classes index text file?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ddavid/fsoco/pull/35?email_source=notifications&email_token=AKRQKLS6AWH4YLUW26LU6WLQVUNR5A5CNFSM4JMCJVZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFF53KI#issuecomment-558620073,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKRQKLVH5HHS72E6LNP2R5LQVUNR5ANCNFSM4JMCJVZQ
.

Hi, i added the class and the cones as requested and also added some missing cones of the other class. I also updated the number of cones in the documentation.
Tell me if there is something else to fix of it's ok now. Thank you

Hi Marco, sorry for the late reply, only came around to take a look at the changes today.
Thank you for making the corrections!
There's just one last thing, are the cones seen in this picture consistently labeled as orange-cones throughout the data set?
I ask because in the context of the FSD competitions in Europe, one would assume them to be the big-orange-cones that are in your classes file.

Yes, we labelled them all as orange-cones but I can change it if you want them consistent to the other datasets
Just tell me if you prefer and I'll change all the orange-cone class to big-orange-cone

Yes, please do change them, as this could lead to some very weirdly performing models and it's hard to document.
Will go through the changes tomorrow morning.

Do you prefer that i change it just in the class file or all the numbers that refer to the class into the txts?

Ok I did it, it should be ok now

Looks good to go.
Thank you for your contribution!


Connect SAP Continuous Integration and Delivery with Your Corporate Git

Tutorials: https://developers.sap.com/tutorials/cicd-corporate-git.html
Hi Team,
For my scenario  I have used our corporate GitHub but I am facing below issue in my build log
ERROR: Error cloning remote repo 'origin'
[2021-05-12T12:45:03.167Z] hudson.plugins.git.GitException: Command "git fetch --tags --force --progress -- https://github.xxx.xxx.xxxx/I000000/SAPCICD.git +refs/heads/:refs/remotes/origin/" returned status code 128:
[2021-05-12T12:45:03.181Z] stdout:
[2021-05-12T12:45:03.196Z] stderr: fatal: unable to access 'https://github.xxx.xxx.xxxx/I000000/SAPCICD.git/': Received HTTP code 405 from proxy after CONNECT
[2021-05-12T12:45:03.304Z]
[2021-05-12T12:45:03.317Z]     at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2450)
[2021-05-12T12:45:03.467Z]     at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:2051)
Please help here ?
Regards ,
Vanita

@vanita57 Never ever post personal information in a public space!

Hi @vanita57,
based on the log snippet it seems that you do not have properly set up you SAP Cloud Connector.
In order to follow the tutorial to use corporate Github repositories with the SAP CICD Service, you must have a SAP Cloud Connector installed, which resides within your network and can reach your corporate Github.
Please make sure that these requirements are given to properly continue setting up a connection between the Cloud Connector and your BTP Subaccount, as described in Step 2 of the tutorial, and set up a system mapping to your cooperate Github repository, as described in Step 3 of the tutorial.
Best regards
Roman

Hi Roman,
Thank you for your input ,I am able to resolve the issue.
and Even though it is a public repo I used GitHub token credential then it started cloning my repo .
screenshot attached

Regards,
Vanita

Hi @vanita57

Thank you for your input ,I am able to resolve the issue.

Sure. You're welcome. I assume that we can close this GH issue then, right?

and Even though it is a public repo I used GitHub token credential then it started cloning my repo .
screenshot attached

Hmm, yes. That one is a bit tricky. You're corporate Github provider most-likely disallowed anonymous cloning. In that case credentials are needed although your repository is public. I will propose a change in the tutorial accordingly.
Best regards
Roman

Thank you for your feedback. We haven't heard from you in a while, so we are closing the issue.
If you still have questions, feel free to reopen the issue.


Add Robo Diffusion v2 (base) model

From https://huggingface.co/nousr/robo-diffusion-2-base.
14fe5bd71, nousr robot, robo-diffusion-v2-base.ckpt

added. (filename omitted because there is no hash collison)
14fe5bd7, nousr robot


Is there pvl instruction executor implementation

Hi,
I would like to be able to perform Proof Verifications in custom JS client. I went through the pvl wondering if there is a reference implementation I could use, or if my best bet is to write one from scratch.
Thanks

cc @mlsteele

@Gozala There's the implementation in client. It's in Go and the only implementation right now. It's got tests that might come in handy.
Also depending on what you're up to, shelling out to a local keybase client to verify proofs could be an easier way to check proofs. keybase id npmregistry+npmjs.org@dns+npmjs@twitter


POST data not recorded

In our tests we have noticed that the POST data is not sent along for reproducing bugs.
Is there a way to gather more data and send it along by default, or is it a matter of extending the bundle classes and rolling out your own?

@rdohms we should be capturing POST data automatically:
https://github.com/getsentry/sentry-php/blob/master/lib/Raven/Client.php#L553
Granted if its not form data we probably aren't catching it.


sqrRev([1+eps,inf],[-1,1+eps]) is not the tigtest

The tightest result in infsup_b64 is
sqrRev([0x1.0000000000001p0,inf],[-1,0x1.0000000000001p0])=[1,0x1.0000000000001p0]
The library returns
sqrRev([0x1.0000000000001p0,inf],[-1,0x1.0000000000001p0])=[-1,0x1.0000000000001p0]
I know that currently libieeep1788 doesn't claim to always return tightest results.
However, sqrRev(c,x)=pownRev(c,x,2) is easier to make tightest than pownRev(c,p,x) for negative p.

The original test passes now.
Here is another test.
The tightest result in infsup_b64 is
sqrRev([0x1.0000000000001p0,inf],[1,1])=[empty]
The library returns
sqrRev([0x1.0000000000001p0,inf],[1,1])=[1,1]


[BUG] Broken on Firefox

Website doesn't load correctly when using Firefox Client.

Can you please confirm if the issue still persists?
Have you tried accessing the website using a different web browser? If so, did the issue occur in the alternate browser as well?
What is the version of the web browser you are currently using? This information can help in understanding any potential compatibility issues.
Have you cleared your browser's cache and cookies? Clearing cache and cookies can sometimes resolve issues related to stored data. If you haven't tried it yet, I recommend clearing your browser's cache and cookies and then reloading the website.

Hello! Sorry for doing such a bad issue report. Lol
On Firefox the dropdown does not display. Strange thing that I test now is that it does work using librewolf, which that could mean it's an add-on what may be causing the issue.
After disabling and enabling add-on's one by one I found out that LocalCDN is the thing that breaks it.

I am not familiar with the "workers" that @iamcal uses in their code, but if it's the same service workers that LocalCDN is talking about on their (Test Utilities page) they recommend you turn off LocalCDN for that website.
"Service Workers essentially act as proxy servers between the website and you. It's possible that a Service Worker may deny replacements by LocalCDN. In this case, you can disable LocalCDN for this website or globally disable all ServiceWorkers:
https://www.ghacks.net/2016/03/02/manage-service-workers-in-firefox-and-chrome/"


Update cpl aim+ocn

What changes does this PR introduce?

Update coupled atmosphere (using pkg/aim_v23) ocean realistic config to allow to use same set of executable to test with seaice-dynamics.
add a second test than includes seaice dynamics (pkg/seaice) and seaice advection (pkg/thsice) inside ocean component while seaice thermo (pkg/thsice) remains inside atmspheric component.
move script "run_cpl_test" to "tools/" and update it for multiple set-up with same set of executable.

What is the current behaviour?
Changes to allow to use seaice dynamics in coupled set-up were made long time ago (late 2015) but without example to show how to do it.
What is the new behaviour
The second test illustrates how to use seaice dynamics in coupled set-up. Only requires few additional parameter files.
Does this PR introduce a breaking change?
No and results of coupled primary test remain unchanged.
Other information:
README file was added (replacing out-of-date "itrda_notes.txt" file)
Suggested addition to tag-index
o verification/cpl_aim+ocn:

add secondary test set-up using seaice dynamics (pkg/seaice) as part of
ocean component and update script to handle option to run multiple test.

I adjusted the script "run_cpl_test" that makes it easier to compile & run & check results for coupled set-up. Now this updated version can also be used for the 2 other coupled experiments in verification_other (i.e., cpl_gray+ocn and cpl_aqua_cs24 from PR 49 there: https://github.com/MITgcm/verification_other/pull/49 ).
We could decide to move this script to MITgcm/tools so that we don't have to maintain several versions (in 2 git repos).

@jm-c I spent some time looking at this.

I agree with suggestions that it makes sense to put run_cpl_test in tools directory-- as a generic script use to build, setup/clean, run, or check results in the coupled setups (for testreport). ie this tool could be used for multiple verification experiments. And adding option to allow suffix for input variation is very useful.
The script is not really documented (other than perusing/looking at the echo lines) -- but seems the purpose here is primarily testing, not really intended to document how to do coupled setups nor something of more general use for new setups/development? (unless one wanted to dig in and modify the script as needed). So I'm fine with the script.
I do think a README should be added that states the sequence that is called with testreport in using the run_cpl_test script (given it is a bit complicated).  This would be useful for someone who just wants to run/test on their system, or someone who might want to add a new verification expt etc.
Any manual documentation on how a coupled setup is achieved remains completely lacking. This is not really the fault of this verification experiment :) but it might be worthwhile to state some simple basics in a README here, similar to what is in many existing READMEs about how to build/run, perhaps w/a bit of basic info text. With that knowledge, a person might have fighting chance of then deducing further by then looking at the run_cpl_test script :)
I see you have run the new advection-ice coupled setup w/new STDOUT. As part of this review should I put the revised run_cpl_test script through some tests? (not sure this is necessary if you have done the testreport suite)
The new coupled setup w/SI advection: I presume you had this existing setup from 2015, when we worked on it. I too have one from ATM2D; as part of review should I go through this new setup, or are you pretty confident the setup/parms are all good? (I guess this is a question how careful we were in 2015...)

Thanks for the comprehensive assessment @jrscott I totally agree, the script should be moved to tools if it is general enough to be used for more than just one specific experiment.
As for documentation, I also agree that a minimal instructions set would be great. Would something like verification/cpl_aim+ocn/itrda_notes.txt be a start?

@jrscott and @mjlosch thanks for the useful comments. I will move the script "run_cpl_test" to tools and make a README.rst file that update/recycle/replace itrda_notes.txt. And from there it will be easier to see what we want to add or change.

@jrscott I am dome with my multiple edits of the new README file. If you have time to try the instructions there and run these 2 set-up it would be great.

thanks @jm-c I'll give it a go

@jrscott I think it would help to have this PR merged in to assess some of the changes in PR #599, because this later PR does add pkg/thsice to a new executable built. So if you could find some time to review this one it would help moving forward.

@jm-c added a sentence about step 2 vs. step 3 (to avoid any possible confusion) in the README.
Not sure what to do about the bottom section: I'm not sure step 4 is runnable even with the cvs archive given (might use additional stuff in your path, I didn't test past recovering comp_res and then failing on having a needed fortran exe). It also doesn't mention why one would not just use standard testreport. But, the majority of people will not need to run step 4, so we could just leave as is.
I did test the icemen setup, ran fine.
Basically, good to merge then ?

@jrscott Thanks for the review and the improvement to README file. Also good that you tried to run both set-up.
I just revert 1 line change (since  I prefer to have the emphasis on the 3 input dir) and remove some trailing blanks (that I introduced ealier). Will merge this PR later today (unless someone disagree).


[Migration tooling] Blocks

Summary
A block admonition is converted to MyST admonition block directive. If the admonition has a title, then the {admonition} directive is used. The type of the admonition is passed as the class attribute.
admonition_type: NOTE | TIP | IMPORTANT | CAUTION | WARNING
Other classes can also be added to the class attribute. For example, if [%collapsible] option is specified for the admonition block, then “dropdown” will also be added to the class attribute
````{admonition} <title>
:class: <admonition_type> <other_classes>
<admonition_content>
````

If the admonition doesn’t have a title, then the following syntax will be used
````{<admonition_type>}
:class: <classes>
<admonition_content>
````

In both cases above, note that we are using 4 backquotes instead of 3. That’s because an admonition can have other directives nested in it. So it needs to have more than 3 backquotes. The minimum required number depends on the levels of nesting. Dynamically assigning the backquotes depending on their nested directives, is currently out of the scope of this project.
To do
Determine if we will support [%collapsible].
Related
https://github.com/elastic/docs-builder/issues/106

Reiterating from #106 but it bares repeating IMO 😸

We explicitly don't/won't support MYST syntax which directly influences HTML.
So we never use :class: to set the admonition type or influence any other directive for that matter.

So we'll never want to expose new features by adding a 'class' as per:

Other classes can also be added to the class attribute. For example, if [%collapsible] option is specified for the admonition block, then “dropdown” will also be added to the class attribute

In the case of [%collapsible] docs-builder supports two options today:
Adding the :open: <bool> option to an admonition.
```{note}
:open:

Longer content can be collapsed to take less space.

```

Or we support a more general dropdown region with the {dropdown} directive
```{dropdown} Dropdown Title
:open:
Dropdown content
```

```{dropdown} Dropdown Title
Dropdown content
```

In both cases above, note that we are using 4 backquotes instead of 3. That’s because an admonition can have other directives nested in it. So it needs to have more than 3 backquotes. The minimum required number depends on the levels of nesting. Dynamically assigning the backquotes depending on their nested directives, is currently out of the scope of this project.

I would caution against this. Make 3 backticks the default only use 4 or more when you start needing to include nested directives which should be rare from a UX perspective in my opinion.
If this comes up a lot I suspect it might be hiding a new directives use case.


Added color for test response

Little extra color to the output. Looks good on light and dark terminal color schemes!

Two nits, but otherwise this looks good. Thanks for adding it!

Thanks for the constructive feedback! I've added the recommended changes in the latest commit.

Thank you! I'll merge this tonight.

Merged, thanks again!


NOISSUE - Auth typo

Signed-off-by: Manuel Imperiale<EMAIL_ADDRESS>

Codecov Report

Merging #1319 (75e396c) into master (3eca692) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1319      +/-   ##
==========================================
+ Coverage   59.79%   59.81%   +0.02%
==========================================
  Files         113      113
  Lines        8797     8797
==========================================
+ Hits         5260     5262       +2
+ Misses       3080     3078       -2
  Partials      457      457

Impacted Files
Coverage Δ

auth/api/grpc/server.go
56.62% <ø> (ø)

auth/service.go
43.96% <ø> (ø)

things/service.go
54.54% <0.00%> (+1.13%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3eca692...75e396c. Read the comment docs.

Codecov Report

Merging #1319 (75e396c) into master (3eca692) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1319      +/-   ##
==========================================
+ Coverage   59.79%   59.81%   +0.02%
==========================================
  Files         113      113
  Lines        8797     8797
==========================================
+ Hits         5260     5262       +2
+ Misses       3080     3078       -2
  Partials      457      457

Impacted Files
Coverage Δ

auth/api/grpc/server.go
56.62% <ø> (ø)

auth/service.go
43.96% <ø> (ø)

things/service.go
54.54% <0.00%> (+1.13%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3eca692...75e396c. Read the comment docs.


Adds proof harnesses for s2n_hash functions

Resolved issues:
N/A.
Description of changes:
Adds proof harnesses for the following s2n_hash functions:

s2n_hash_const_time_get_currently_in_hash_block;
s2n_hash_get_currently_in_hash_total;
s2n_hash_is_ready_for_input;
s2n_hash_init;
s2n_hash_free;

It also upgrades the libcrypto verification model version.
Call-outs:
N/A.
Testing:
N/A.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #2428 (5e6b6a7) into main (cdc98fb) will decrease coverage by 0.06%.
The diff coverage is 45.16%.

@@            Coverage Diff             @@
##             main    #2428      +/-   ##
==========================================
- Coverage   82.00%   81.94%   -0.07%
==========================================
  Files         271      271
  Lines       18625    18662      +37
==========================================
+ Hits        15273    15292      +19
- Misses       3352     3370      +18


packages.hello: add ports-mgmt/pkg_tree

Across https://github.com/helloSystem/, many discussions lack an essential understanding of dependencies.
pkg_tree https://www.freshports.org/ports-mgmt/pkg_tree/  gives you an ascii-graphical-tree overview of dependencies of a port. Make this integral to helloSystem, then promote use of things such as this.

Thank @grahamperrin


[2.3] Front Ports API schema incorrectly labels rear_port_position field as not required

Environment

Nautobot version (Docker tag too if applicable): 2.3.0
Python version: 3.11.9
Database platform, version:
Middleware(s):

Steps to Reproduce

Create a Rear Port on a Device
Try and create a Front Port on that Device via API with only required fields name, type and rear_port.

Expected Behavior
It seems like in Nautobot <2.3 it would select the first position each time by default if not provided.

Observed Behavior
API error:
{
  "rear_port_position": [
    "This field is required."
  ]
}

Note: setting the API version to 2.2 does not seem to revert to previous functionality.
In the end I assume this was sort of a "fixed the glitch" kind of bug where the field was always supposed to be required, because in 2.2 if you try and set 2x front ports using only the required information the first one would work but the second one would fail with the following error:
{
  "non_field_errors": [
    "The fields rear_port, rear_port_position must make a unique set."
  ]
}

Front Port Templates are also affected.

Likely an unintended side effect of the change from unique_together to models.UniqueConstraint on the (rear_port, rear_port_position) tuple as a part of #5657.

Possibly related: https://github.com/encode/django-rest-framework/issues/9358.


Empty Table does not generate

When using extension within Chrome with WYSIWYG editors in ZenDesk Help Center or Gmail with a table.
If the very bottom right cell of a table is empty, the cell will not be displayed in the html table.
Example below.
| Severity |             Resolution Time             |                                    Note                                     |
|:--------:| --------------------------------------- | --------------------------------------------------------------------------- |
|    1     | By end of next half day                 | Resolution available 24 hours a day, 7 days a week.                         |
|    2     | By end of next business day or Saturday | Resolution available on business days and Saturday, 06:00 UTC to 23:00 UTC. |
|    3     | By end of next two business days        | Resolution available on business days, 06:00 UTC to 23:00 UTC.              |
|    4     | Not applicable                          |                                                                             |

I don't have a suggestion. The MD example you gave works fine in Gmail, so I'm tempted to say that it's not MDH's problem.
I don't have access to ZenDesk to test with. Maybe you can grab the HTML to see if it's looks wrong. Like so: https://github.com/adam-p/markdown-here/wiki/Troubleshooting#copying-html
Is it okay to work around it by putting a non-visible character in the cell? Like  .
I'm closing this, but you can re-open if there's something we can reasonably do to fix it.


Automatic test failures

pMEC1138.ipynb
pMEC1139.ipynb
pYPK0_PGI1_HIS3_TDH3.ipynb
pYPK0_TEF1_PsXYL1_N272D_TDH3.ipynb
pYPK5.ipynb   <--- assembly problem

fixed!


Uploading NER notebook

Looks really good.
Some minor comments, and you're missing something about describing the responsiveness of the UI being enabled by the inference speed of the IPU. This makes the IPU fast enough to be used by APIs that need to be used in real time by users.

Hi, I've made the changes you suggested @payoto , including rewriting the conclusion with what you mentioned in your above comment, hopefully this is okay now? Will send to Jamie for review too.

Hi I've made the suggested changes, and I have also tested against sdk 3.1 so this should be ready to go.

I added this notebook to the Paperspace test suite and it hit the following error: NameError: name 'ner_pipeline_medical' is not defined it seems to be a typo according to @rahult-graphcore

Hi, thanks for all the suggestions @payoto  and @JamesRandom.
I've made changes and rewritten some parts, hopefully this is okay now, struggled a bit with the conclusion and happy to edit further if it needs it.
Also fixed the typo ^


AutoMLSearchException: All pipelines in the current AutoML batch produced a score of np.nan on the primary objective

Hello all,
After installing EVALML in colab, I have only followed the example of the breast cancer.
import evalml
X, y = evalml.demos.load_breast_cancer()
X_train, X_test, y_train, y_test = evalml.preprocessing.split_data(X, y, problem_type='binary')
from evalml.automl import AutoMLSearch
automl = AutoMLSearch(X_train=X_train, y_train=y_train, problem_type='binary')
automl.search()
But unfortunately, it gives the below error:
AutoMLSearchException: All pipelines in the current AutoML batch produced a score of np.nan on the primary objective

Hi @AhmedEwis ! Thank you for filing. Can you please post AutoMLSearch's console output ? That way we'll have more information to diagnose what happened. You can also run AutoMLSearch with verbose=True so that more information is displayed.

Hi @AhmedEwis ! Thank you for filing. Can you please post AutoMLSearch's console output ? That way we'll have more information to diagnose what happened. You can also run AutoMLSearch with verbose=True so that more information is displayed.

Hi @freddyaboulton Thanks for your reply!
I got this warning from the console output:
/usr/local/lib/python3.7/dist-packages/traitlets/traitlets.py:2205: FutureWarning: Supporting extra quotes around strings is deprecated in traitlets 5.0. You can use '<IP_ADDRESS>' instead of '"<IP_ADDRESS>"' if you require traitlets >=5.

Hi @AhmedEwis ! Thank you for filing. Can you please post AutoMLSearch's console output ? That way we'll have more information to diagnose what happened. You can also run AutoMLSearch with verbose=True so that more information is displayed.

I also set the verbose = True. I only found that the below output:

Hi @AhmedEwis ! Can you post a screenshot? I don't think it shows up correctly in your previous comment.

@AhmedEwis , going to close this one. If you still need help, feel free to reopen and post the requested screenshot!


Time-dependent source term in heat equation

Hello,
I am interested in solving the following equation:
pd(u)/pdt + a.grad(u) - div (nu*grad(u)) = f,
where f is a given function of space and time.
Following example 9, I was able to implement a time-independent source term on the rhs. I create a ParLinearForm (from a function defining f), which is assembled into a HypreParVector, which is used to create the FE_Evolution object adv.
It seems that the source term cannot be time-dependent as the solver is. Is there a way to modify the solver so that it would be possible? Or should my approach be different?
If there is an example / miniapp that solves a similar problem, that would be great.

I think ex15 will point you in the right direction. You probably already use the FunctionCoefficient object, which can be constructed with either a time-dependent or time-independent function. The function rhs_func in ex15 is used to construct the coefficient rhs which is used in the LinearForm b, analagous to your f in the equation above.
Does this make sense?

It does and I think I got that part. My FunctionCoefficient object f is constructed from a time-dependent function. f is used for the ParLinearForm object which is then assembled into a HypreParVector object, etc.
The thing is that the code behaves as if the source term was time-independent. The solution is the same as if the source term took its value at t = 0 all along.
I guess I am missing something. The rhs should be updated at every time step somehow.
I see that example 15 does not use an ODESolver object as exemple 9. I was looking for an example that does (and with a time-dependent source term) if there is.

You are right, this is a bit more complicated than I originally thought, and I don't think we have an example for this case.
I think what you want to do is change the FE_Evolution constructor so its third argument is ParLinearForm instead of Vector, and then you will construct this object with b instead of B. Then in both FE_Evolution::Mult() and FE_Evolution::ImplicitSolve() replace the line z += b; with a few lines that call eg. rhs.SetTime() and b->ParallelAssemble() to get the correct (time-dependent) vector you want to add to z.
One of the things that will make this tricky is being careful with memory so you don't create a new vector at each timestep, but I think the outline I've given above will get you started. Let us know if you have questions.

Ok thanks', I got it.
In addition to replacing B by b in the FE_Evolution constructor, I added the FunctionCoefficient f so that I can use f.SetTime inside FE_Evolution::Mult() and FE_Evolution::ImplicitSolve().
I create (and delete once used) a new HypreParVector at each time step.
It might not be optimal but it works.


Auton changes for Robo Replay

Organized all autons into uniform naming
Updated 2 Bump, 2 Dock to score mid cone first

Ran all autos in sim and worked


Google Maps geolocation

Have the google map be centered when the user's current location is retrieved.

Added geolocation to map!


Haruna sending spam like messages when user votes

I was restarting the Haruna and when it got ready it instantly received a vote and it sended the message 4 times instead of 1, and at normal times it's working fine
Images: https://cdn.discordapp.com/attachments/593768276732149780/860096288867614750/unknown.png

If there is a stack trace, or debug logs on how this happens, please do include it so I can track it

I think it was a issue on my side.


Add command to list messages in a list

/nb list <messageList> [page]
novusbroadcast.list
Should print a paginated list of all messages in the list to the player. Five messages per page.

Implemented in f8cdb8b


chore: replace goblin with convey

Codecov Report

Merging #5 into master will not impact coverage.

@@           Coverage Diff           @@
##           master       #5   +/-   ##
=======================================
  Coverage   73.58%   73.58%
=======================================
  Files           1        1
  Lines         106      106
=======================================
  Hits           78       78
  Misses         27       27
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0744f10...001eb3a. Read the comment docs.


Improve ctags invocation in Makefile

Description
Adding .function was necessary, as otherwise ctags would have no idea what to do with those files.
Adding .h may not be necessary, as by default ctags considers them C++ which is probably good enough, but since we're tuning the mapping anyway...
Status
READY
Requires Backporting
Yes - developer comfort should be available in all branches :)

[x] 2.16 - #3157
[x] 2.7 - #3158

Thanks for your review! I updated the backports.


Magic/value type

It'd be great if you could do something like:
vstruct([
  { type: vstruct.value(0xdeadbeef) },
  { name: 'data', type: vstruct.Buffer(32) }
])

You'd need to encode the type though I suppose,  so maybe:
vstruct([
  { type: vstruct.UInt32, value: 0xdeadbeef },
  { name: 'data', type: vstruct.Buffer(32) }
])

You should link to https://github.com/dominictarr/varstruct-match in the README... I decided to use this instead :+1:

Yes, maybe we do, but this package mentioned in https://github.com/mafintosh/abstract-encoding

Actually, this would still be useful to have.

Also,  @fanatid what would be the best way to do a checksum... using Bound?

Alternative proposed syntax:
vstruct.value(vstruct.UInt32LE, 0xdeadbeef)

Closing in favour of https://github.com/dominictarr/varstruct/pull/16

Re checksum: yes, I think Bound is the best here


1.1.0 does not work 0.0.8 does

I can get emojify to work if I use the 0.0.8 version but not 1.1.0. If I lift the code from http://hassankhan.me/emojify.js and deploy it locally it works just fine. Not true for 1.1.0. I noticed this is abandoned so I am just putting this here for others.

Also can someone please provide a working example of the usage of the replacer behaviour with a fully written callback function? I can't for the life of me understand what he means.

I noticed that if I get the 1.1.0 from the cdnjs link in the README.md file it works just fine.


Fix bug

Should hopefully fix https://github.com/terkelg/tiny-glob/issues/28.

Guess the benchmark needs update too :)

Thanks for the PR. I think we have to look into why the line is there in the first place. I'm pretty sure it's to avoid crawling unnecessary directories. We have to do some detective work here ;-)

Discussion continues in #28.


<IP_ADDRESS> how to remove Omni (#1) from wallet?

I am pleased with the Omni Core <IP_ADDRESS> (WIN 64 bit) wallet - thank you guys :) - looking forward to <IP_ADDRESS>
When opening the wallet first time - before I import my various SPT #'s I see that the wallet opened with a default (?) SPT already there:
Omni (#1) - with a 0 balance.
How can I remove that one from the wallet?
I have googled but not able to find anywhere a description/tutorial on how to do this.
edit later:
It's mainly an aestethic issue - I like things to be clean and minimalistic - so I feel it a bit annoying to have an "account" displayed, that I don't use.
If it has to be integrated with the wallet in order for it to work - could it then be hidden from the Overview somehow?

Hi @CaptainSkywave,
I actually haven't thought about this, but you are right. Currently there is no way to hide the primary tokens, even if there is no balance, but we should consider this for the next version.
Thanks for pointing out!

Thanks dexX7.
And also thx for <IP_ADDRESS> - awesome work!
Running on WIN server 2012 R2 STD 64 bit here - smooth sailing :)

@dexX7 I'm curious as to why you removed this from Next release, which is now <IP_ADDRESS> ?
I still find it a nuisance to have it (Omni (#1)) featured in the overview for no use (AFAIK?).

Hi @CaptainSkywave,
initially there was some discussion about removing the Qt interface and focus on providing a rock solid daemon/server only version, so I removed the milestone.
However, we're keeping the GUI and @zathras-crypto picked up your idea in #471. :)

Resolved via #471.


Manage Users missing

IN the following text, the "manage users" instruction is no longer valid.  The option is not present.
An icon showing the Microsoft Teams logo Using the Microsoft Teams admin center
Go to Meetings > Live events policies.
Select the policy by clicking to the left of the policy name.
Select Manage users.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b9aa4676-855a-fddb-bb0b-96b7095c695e
Version Independent ID: 7c39f08c-0d56-6d29-1356-879d9d6ff51c
Content: Set up for live events in Microsoft Teams - Microsoft Teams
Content Source: Teams/teams-live-events/set-up-for-teams-live-events.md
Service: msteams
GitHub Login: @LanaChin
Microsoft Alias: v-lanac

@bozford Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

FYI the option to Manage Users is still available to me when I go to Meetings > Live Events Policies.  The option is grayed out until you select a Policy to manage.

@bozford Thank you for reaching out. Please confirm if @klishb has answered your question.

@klishb @bozford We appreciate any feedback that improves the content in the Microsoft docs but we haven't had any response from you so we are going to close this issue.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.


Unable to anchor a file pattern in filter.List().

I have a daily "-x / /boot" backup from my rp3, it contains (among other files) /bin/uncompress and /bin/gunzip which are hardlinked to eachother. To test if this works I wanted to restore them, so I ran:
$ mkdir z
$ restic -r ... restore --include bin/uncompress --include bin/gunzip -t z
And to my surprise I ended up with
z/bin/gunzip
z/bin/uncompress
z/usr/lib/klibc/bin/gunzip
Prefixing the include with a / wont work as the repo does not seem to contain the root prefix when calling the selectFilter(), so it won't match anything. filter.List also does not seem to have any anchoring characters. Seeing it defines ** to match multiple directories, I would guess the intent was to have Match anchor the pattern at the beginning of the string. E.g. it showing behavior of me having typed --include **/bin/gunzip
Output of restic version
restic 0.4.0 (v0.4.0-76-g4f5e9e9-dirty)
compiled with go1.8 on linux/amd64
Expected behavior
Two files:
z/bin/gunzip
z/bin/uncompress
Actual behavior
Three files appear:
z/bin/gunzip
z/bin/uncompress
z/usr/lib/klibc/bin/gunzip
Steps to reproduce the behavior
have a repository, backed up from / with both say
/bin/fileA
/usr/bin/fileA
$ restic -r ... restore --include bin/fileA -t z
you end up with both files under z/

Interesting, thanks for opening this issue. It may indeed be a bug.

Ha, this is actually an old bug that I haven't gotten around to fixing (#374), thanks for reminding me!


What's the best way to get the POCO model ignored properties configured by Fluent API?

I want EFCore to auto record the change history so that I can undo and redo from the change history.
The repo is Love.Net.EF.AutoHistory
So I add some extension methods to DbContext like DbContextAutoHistoryExtensions, but if the POCO model have some properties had been configured ignored using Fluent API like this,  the following code will throw exception
private static object Original(this EntityEntry entry) {
            var type = entry.Entity.GetType();
            var entity = Activator.CreateInstance(type, true);

            var properties = type.GetTypeInfo().GetProperties();
            foreach (var property in properties) {
                var nav = entry.Metadata.FindNavigation(property);
                if(nav != null) {
                    continue;
                }

                var original = entry.Property(property.Name).OriginalValue;
                property.SetValue(entity, original);
            }
            return entity;
        }

so I change the  code like following (add try...catch)
private static object Original(this EntityEntry entry) {
            var type = entry.Entity.GetType();
            var entity = Activator.CreateInstance(type, true);

            var properties = type.GetTypeInfo().GetProperties();
            foreach (var property in properties) {
                var nav = entry.Metadata.FindNavigation(property);
                if(nav != null) {
                    continue;
                }

                try {
                    // following code will throw exception if the property had been ignored.
                    var original = entry.Property(property.Name).OriginalValue;
                    property.SetValue(entity, original);
                }
                catch {
                    // what's the best way to get the ignored properties?
                    continue;
                }
            }

            return entity;
        }

My question is what's the best way to get the POCO mode ignored properties

@xyting I'm not sure exactly what you are trying to do, but if you want to get just the mapped properties for the entity type then it is probably best to use the EF metadata to do this. For example:
var properties = entry.Metadata.GetProperties();
foreach (var property in properties)
{
    var propertyEntry = entry.Property(property.Name);
    var original = propertyEntry.OriginalValue;
    propertyEntry.CurrentValue = original;
}

This will not include navigations, so you won't need to skip them, and will include shadow properties, which your code would not do.
Note that in version 1.1, not released yet, but available in nightly builds, you can more easily get property entries directly. For example:
foreach (var propertyEntry in entry.Properties)
{
    var original = propertyEntry.OriginalValue;
    propertyEntry.CurrentValue = original;
}

@ajcvickers Thanks your valuable answer!


[APPS-2897] Autoload product

:bear:
/cc @zendesk/wombat
Description
Autoload Product
References

JIRA: https://zendesk.atlassian.net/browse/APPS-2897

Risks

None

:+1:

:+1:


The first letter of type/field name is always uppercase in generated pb.go codes.

The first letter of type/field name is always uppercase in generated pb.go codes, making it no way to create non-exported struct/field with protobuf in Go. Is this by design?

Yes, that's by design. You wouldn't be able to use those structs otherwise.

Doesn't the following package structure make sense?
package abc:
logic.go
data.pb.go
The structs in data.pb.go are only supposed to be used by logic.go, and not outside package abc.

Nope. Generated protos are supposed to be in their own package. You aren't meant to add your own code alongside it.

But what if I need to define methods on the pb generated struct? Aliasing them will cause tons of conversions between the original pb structs and the aliases. Any cleverness applicable at here?

You don't. You define your own types as you need.

My approach is to use script to rename the generated struct


IE 10 fails on very specific images - example attached

This very well may be a bug or extra security restriction in IE 10 but I have found two images that refuse to work with your demo.
I noticed the problem when developing functionality almost identical to yours for my app.
IE would always fail to read this specific image.  I came across your plugin when searching for a solution and low and behold, your plugin has the same issue.
From what I can ascertain the blob URL is created correctly with createObjectURL as the returned URL appears as any other correctly loading image.
However the image.onload event never fires for it and it is never actually loaded into the browser.  I cannot for the life of me figure out why and what is different about this image to the other 99% of images out there.
It CAN be read by the filereader interface, so a possible solution would be to set an error timeout which will run if the image.onload event has not fired after say 5-6 seconds and restarts the read using the filereader API to create a base64 image instead of a blob URL reference.
It's ugly and hacky would be a temporary fix until we can work out just whats going on.
I have attached one of the images in question.

Revisiting this in 2020, I cannot reproduce the issue in IE11 on Windows 10.
I don't have IE10 to test anymore, but given that IE11 is the last remaining supported version of Internet Explorer, I feel it's acceptable to close this issue.


"Panic occurred  Can't create Snapshots directory" when deploying from Helm Chart

Current Behavior
When deploying qdrant into an OpenShift 4.12 cluster with the latest docker image  the qdrant pod crashes. The Log shows the message:
[2023-07-10T14:52:55.195Z ERROR qdrant::startup] Panic backtrace:
0: qdrant::startup::setup_panic_hook::{{closure}}
1: <alloc::boxed::Box<F,A> as core::ops::function::Fn<Args>>::call
at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/alloc/src/boxed.rs:1987:9
2: std::panicking::rust_panic_with_hook
at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/std/src/panicking.rs:695:13
3: std::panicking::begin_panic_handler::{{closure}}
at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/std/src/panicking.rs:582:13
4: std::sys_common::backtrace::__rust_end_short_backtrace
at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/std/src/sys_common/backtrace.rs:150:18
5: rust_begin_unwind
at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/std/src/panicking.rs:578:5
6: core::panicking::panic_fmt
at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/core/src/panicking.rs:67:14
7: core::result::unwrap_failed
at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/core/src/result.rs:1687:5
8: storage::content_manager::toc::TableOfContent::new
9: qdrant::main
10: std::sys_common::backtrace::__rust_begin_short_backtrace
11: main
12: <unknown>
13: __libc_start_main
14: _start
[2023-07-10T14:52:55.195Z ERROR qdrant::startup] Panic occurred in file lib/storage/src/content_manager/toc.rs at line 107: Can't create Snapshots directory: Os { code: 13, kind: PermissionDenied, message: "Permission denied" }

Steps to Reproduce

Clone qdrant-helm repo
Run helm install -f values.yaml qdrant .

No modification were made to values.yaml or other configs.

Expected Behavior
qudrant pod starts successfully.

Meanwhile we could determine the cause of the issue. When deploying on Openshift the container is being run under a random uid. Several directories are modifiable only by a fixed uid and not by others. There is an unmerged pull request which addresses the same issue.

Thanks for the update! I hope there will be no problems with using Qdrant in Openshift


Plan with Checklists

Master plan to go here sometime...

Item Detail Page

[ ] Heading
[ ] Shop Image - Square
[ ] Shop Name - Under - Heart button Favorite Shop
[ ] Right side images that navigate to other products of that shop
[ ] total shop items (listings)
[ ] Body
[ ] Column 1
[ ] Favorite for the listing
[ ] Explanation for favorites
[ ] Image
[ ] Arrows - grey

[ ] On image
[ ] Left side hover - blue arrow
[ ] right side hover - blue arrow

[ ] Box with thumbnails of all images - first image is active all other greyed out
* [ ] Zoom
[ ] Shop Image
* [ ] Link to request a custom order
[ ] Three Tabs
* [ ] Tab One - Item Details

[ ] contains item details

* [ ] Tab Two - Star rating
 * [ ] with stars
 * [ ] number of reviews
 * [ ] all reviews
* [ ] Tab Three - Shipping and Policies for shop

[ ] Column 2
* [ ] Box 1

[ ] Item name
[ ] Price w/ currency
[ ] Ask a Question button
[ ] Option Possibilities    (based on product)
[ ] Quantity -or- single item -or- # available
[ ] Color
[ ] Size
[ ] Overview - bulleted list, feedback link, favorited by                 link
[ ] Does the shop accept gift cards?
[ ] Big green add to cart button

* [ ] Box 2
 * [ ] Favorite button for the item
 * [ ] hamburger menu - add to list
 * [ ] social media
* [ ] Box 3
 * [ ] Shop Image
 * [ ] Shop Name
 * [ ] Shop Location
 * [ ] 2 columns of products
  * [ ] Image, name, price


Experience problems with collisions between namespaces

Consider this:
using A;
using B;

namespace A {
  model M {} // error here
}

namespace B {
  model M {} // and here
}

model Foo {
  m: M;
}

C:\t\main.cadl:5:3 - error duplicate-symbol: Duplicate name: "M"
C:\t\main.cadl:9:3 - error duplicate-symbol: Duplicate name: "M"

This is misleading because M is not "duplicated" until you use both namespaces. It also means you can't have using A and using B together even when you never reference the colliding names or always fully qualify them.
Now look at morally equivalent C#, where I would argue the experience is much better. I think we should make things work this way.
using A;
using B;

namespace A {
  class M { }
}

namespace B {
  class M { }
}

class Foo {
  M m; // error here
}

1>C:\t\Program.cs(13,3,13,4): error CS0104: 'M' is an ambiguous reference between 'A.M' and 'B.M'

Should probably just try to resolve the reference just in time, looking up at the current usings vs flattening everything


[SPARK-30919][SQL] Make interval multiply and divide's overflow behavior consistent with other operations

What changes were proposed in this pull request?

The current behavior of interval multiply and divide follows the ANSI SQL standard when overflow, it is compatible with other operations when spark.sql.ansi.enabled is true, but not compatible when spark.sql.ansi.enabled is false.
When spark.sql.ansi.enabled is false, as the factor is a double value, so it should use java's rounding or truncation behavior for casting double to integrals. when divided by zero, it returns null.  we also follow the natural rules for intervals as defined in the Gregorian calendar, so we do not add the month fraction to days but add days fraction to microseconds.
Why are the changes needed?

Make interval multiply and divide's overflow behavior consistent with other interval operations
Does this PR introduce any user-facing change?

no, these are new features in 3.0
How was this patch tested?

add uts

Test build #118803 has started for PR 27672 at commit ae9869c.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23553/
Test PASSed.

Test build #118803 has finished for PR 27672 at commit ae9869c.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
abstract class IntervalNumOperation(interval: Expression, num: Expression)

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118803/
Test PASSed.

Test build #118814 has started for PR 27672 at commit a05af57.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23564/
Test PASSed.

Test build #118814 has finished for PR 27672 at commit a05af57.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118814/
Test PASSed.

cc @cloud-fan @gatorsmile, thanks for reviewing.

Test build #118860 has started for PR 27672 at commit 0c82efe.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23609/
Test PASSed.

LGTM except one comment

Test build #118865 has started for PR 27672 at commit 2bf07a3.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23614/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23620/
Test PASSed.

Test build #118871 has started for PR 27672 at commit ebb0011.

Test build #118860 has finished for PR 27672 at commit 0c82efe.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118860/
Test FAILed.

Test build #118865 has finished for PR 27672 at commit 2bf07a3.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118865/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23626/
Test PASSed.

Test build #118878 has started for PR 27672 at commit e96135f.

Test build #118871 has finished for PR 27672 at commit ebb0011.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class MultiplyInterval(
case class DivideInterval(

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118871/
Test PASSed.

Test build #118878 has finished for PR 27672 at commit e96135f.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
abstract class IntervalNumOperation(

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118878/
Test PASSed.

Test build #118898 has started for PR 27672 at commit 7ece786.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23647/
Test PASSed.

Test build #118906 has started for PR 27672 at commit 1a67228.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23655/
Test PASSed.

Test build #118898 has finished for PR 27672 at commit 7ece786.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #118906 has finished for PR 27672 at commit 1a67228.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118906/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118898/
Test FAILed.

Test build #118910 has started for PR 27672 at commit 9db1f37.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23659/
Test PASSed.

Test build #118910 has finished for PR 27672 at commit 9db1f37.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118910/
Test PASSed.

thanks, merging to master/3.0!

feel free to address https://github.com/apache/spark/pull/27672#discussion_r383719562 in your next PR :)


resultPointCallback not getting called

I may be misunderstanding the code, but it appears that the calling code can request to be notified of result points (i.e. corner markers) found in the image. This is in ZXDecodeHints.h:
/**
 * The caller needs to be notified via callback when a possible ZXResultPoint
 * is found.
 */
@property (nonatomic, strong) id <ZXResultPointCallback> resultPointCallback;

I have set my object as the receiver of these messages like this:
ZXDecodeHints *hints = [ZXDecodeHints hints];
hints.resultPointCallback = self;
ZXMultiFormatReader *reader = [ZXMultiFormatReader reader];
ZXResult *result = [reader decode:bitmap
                            hints:hints
                            error:&error];

And in my .h file, declared that I implement the ZXResultPointCallback protocol:
@interface QrViewController : ViewController<ZXResultPointCallback>

This all compiles fine, but my foundPossibleResultPoint:(ZXResultPoint *)point method is never called.
In ZXQRCodeAlignmentPatternFinder.m at function handlePossibleCenter: it appears that this function should be getting called, but I can't determine why not:
- (ZXQRCodeAlignmentPattern *)handlePossibleCenter:(int *)stateCount i:(int)i j:(int)j {
  int stateCountTotal = stateCount[0] + stateCount[1] + stateCount[2];
  float centerJ = [self centerFromEnd:stateCount end:j];
  float centerI = [self crossCheckVertical:i centerJ:(int)centerJ maxCount:2 * stateCount[1] originalStateCountTotal:stateCountTotal];
  if (!isnan(centerI)) {
    float estimatedModuleSize = (float)(stateCount[0] + stateCount[1] + stateCount[2]) / 3.0f;
    int max = (int)self.possibleCenters.count;

    for (int index = 0; index < max; index++) {
      ZXQRCodeAlignmentPattern *center = self.possibleCenters[index];
      // Look for about the same center and module size:
      if ([center aboutEquals:estimatedModuleSize i:centerI j:centerJ]) {
        return [center combineEstimateI:centerI j:centerJ newModuleSize:estimatedModuleSize];
      }
    }
    // Hadn't found this before; save it
    ZXResultPoint *point = [[ZXQRCodeAlignmentPattern alloc] initWithPosX:centerJ posY:centerI estimatedModuleSize:estimatedModuleSize];
    [self.possibleCenters addObject:point];
    if (self.resultPointCallback != nil) {
      [self.resultPointCallback foundPossibleResultPoint:point]; // *********** Here is the call
    }
  }
  return nil;
}

Sorry, user error. Age-old problem of editing the wrong file. Works wonderfully ,and I even discovered in the comments suggestions for speeding up continuous-detection.


Create a source generator for shaders' cbuffer parameters generated files

Is your feature request related to a problem? Please describe.
Creating shaders without the visual studio extension makes it a bit tedious to do shaders for a beginner.
Describe the solution you'd like
A source generator that would parse the shaders for cbuff parameters and generate the appropriate file.
Additional context
This would help newcomers start without issues when using shaders in the first place + would remove those files from the source code (before generation)

Isn't that was the plugin does? What would be the difference to the visual studio plugin? What kind of workflow do you have in mind?

It's what the plugin does, but you don't get the plugin on vscode or if you develop from any text editor.
I imagine folks using Monogame/Godot and wanting to switch to Stride would want to create games from a lightweight text editor.


merge with biologicalrecordscentre

Codecov Report

Merging #3 into master will increase coverage by 0.67%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master       #3      +/-   ##
==========================================
+ Coverage   59.12%   59.79%   +0.67%
==========================================
  Files          81       82       +1
  Lines        2811     2858      +47
==========================================
+ Hits         1662     1709      +47
  Misses       1149     1149

Impacted Files
Coverage Δ

R/detection_phenology.R
83.33% <ø> (ø)
:arrow_up:

R/dataGaps.r
100% <100%> (ø)

R/occDetFunc.r
86.71% <100%> (+2.16%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a03b1d0...4f927cd. Read the comment docs.


Cybersecurity: <IP_ADDRESS> Linux File System

Description
Explain what is Linux File System is and the types of Linux File systems.
Note:

If interested, mention in which format you want to contribute: Documentation or Video
Please avoid copy/paste, BE YOURSELF
Try to explain with Diagrams
Changes should be made inside the Cyber_Security/ directory & Cyber_Security branch.
Task will be assigned on first come first serve
Check it out Contribution Guidelines

I would like to contribute to it in the form of Documentation

I would like to contribute to it in the form of Documentation

Go with it!

Hi @Anant1711, Can I contribute to this too?

Hi @Anant1711, Can I contribute to this too?

Can you submit in Video format?
Because documentation already taken?

@Anant1711 Please review the PR


Fluid autocrafting not working with energized glowstone

Issue description:
RS cannot find my bucket of energized glowstone eventhough it's in the system and the system knows how to craft it, while crafting some lumium blend.

What you expected to happen:
Lumium blend to be autocrafted
Steps to reproduce:

Create all the required patterns for the energized glowstone and lumium blend
Hit craft
???
Get told it's not there.

Version (make sure you are on the latest version before reporting):

Minecraft: 1.12.2
Forge: <IP_ADDRESS>39
Refined Storage: 1.6.4
RebornCore: <IP_ADDRESS>2
RebornStorage: <IP_ADDRESS>

Does this issue occur on a server? yes

Update: I can manually ask for the glowstone bucket to be crafted. Just when i use it in the lumium blend, it won't detect it

Is the lumium blend recipe an oredict one?

Then I think this is a duplicate of #1954.


packer: VM should have netaddr and sshpass installed

https://github.com/camrossi/akb/commit/263f68a295c627f549fb08258db31136c1a3efd7


Cannot minetweak crop mutations with GardenTrees:candelilla_seeds

Minetweaker script:
val seedCactus = <AgriCraft:seedCactus>;
val seedPumpkin = <minecraft:pumpkin_seeds>;
val seedCandelilla = <GardenTrees:candelilla_seeds>;

SeedMutation.add(seedCandelilla, seedCactus, seedPumpkin);

Error reported by MT:
ERROR: Adding mutation with result 'Candelilla Seeds' failed. All 3 have to be of type ItemSeeds.

Candelilla Seeds seems to inherit from ItemSeeds, but it is your own ItemSeeds class instead of net.minecraft.item.ItemSeeds.
This also seems to make it impossible to grow candelilla seeds on crop sticks.

Update AgriCraft

1.4.6
-ADDED:  Support for Garden Stuff's candelilla crop

Will do!

@InfinityRaider would it be best practice to change my inheritance?  I'm not sure what the majority of mods do here.  I never thought to check.

No, ages ago, I used the ItemSeeds class to get all information I need, but because 80% of the modders are not using that class and instead creating their own one, I stepped away from that and created my own interface. That instanceof ItemSeeds check is a leftover from that time, which I cleaned up now.


Vagrantfile no longer works with virtualbox

Update to date clone, the vagrant file cannot find the virtualbox box to download
>vagrant up
Bringing machine 'default' up with 'virtualbox' provider...
==> default: Box 'chocolatey/test-environment' could not be found. Attempting to find and install...
    default: Box Provider: virtualbox
    default: Box Version: >= 0
==> default: Loading metadata for box 'chocolatey/test-environment'
    default: URL: https://vagrantcloud.com/chocolatey/test-environment
The box you're attempting to add doesn't support the provider
you requested. Please find an alternate box or use an alternate
provider. Double-check your requested provider to verify you didn't
simply misspell it.

If you're adding a box from HashiCorp's Vagrant Cloud, make sure the box is
released.

Name: chocolatey/test-environment
Address: https://vagrantcloud.com/chocolatey/test-environment
Requested provider: [:virtualbox]

It looks like only the hyper-v version has been released.

@TheCakeIsNaOH we recently pushed out a new VirtualBox image, so that the base image here matches what is used on the package-verifier instance. We updated the repo here to use that image, however, we then found a problem with the image. I think what you are seeing here is as a result of @pauby re-uploading the image to vagrant cloud.  I would suggest checking back in a little while and hopefully it will be there.

@TheCakeIsNaOH @gep13 A new Vagrant box for Virtualbox has been uploaded just now. Would appreciate any feedback.

@pauby It is working perfectly for me now.
Thank you (and whoever else helped) for getting the box updated with the KBs. I am really glad that I won't have to sit through kb2919355 installing over and over while testing packages.

I have just taken this for a spin as well, (@TheCakeIsNaOH must have a better internet connection than I do 😄 ) and I can confirm that the issues that I saw with the last version have been addressed, and it is now working as expected.


Added pagination options

Add pagination options
Issue

Thank you for contributing, but I'm apologise, I've been already working on it. If you interesting in contributing please ask first about picking an issue, it could save time and avoid miscommunication

Is there any issue I can pick?

Is there any task I can pick?

@libinthomas33 At this time no


feat(prod/jenkins,staging/jenkins): add pvc data fresh pod yaml

Why
current we nned update bazel base data manually with updating build images
What
make it automatic, when new image comed, we update the job with new name and new image. when go upgraded, create a new job to setup base data for new go version.
/cc @purelind

/hold should be merge in CI idle time

/approve


Store created updated and deleted records

Store created updated and deleted records. This information can be than used in post refresh to e.g. queue up more jobs for created items. Or by another graph node for post processing to e.g. assign/delete records from folders.

@miq-bot assign @agrare
@miq-bot add_label enhancement
cc @cben this can be used to post refresh for image events and tagging. (for old refresh, we will probably need to do it a different way)


Updated country map to the latest country-currency mapping

I was having some issues with getting a price for Lithuania and Latvia (throwing exceptions) , and then I realized they actually had a different currency than the one in the iso country map.
So I updated this list to the latest definition. Here's the gist of the script made to generate the yaml file.
https://gist.github.com/ridem/80697bed0580589ea424
The problem was to get the right official currency when a country has several ISO 4217 currencies. The gist is displaying the countries that need to be double-checked

Hi there!
Thanks for the work, I'd love to be able to merge this, however the tests are failing with the given change. Please let me know when you get them passing so I can have another look.

Yeah sorry, I forgot to add the new def in your specs. This one is passing the tests ;)

Thanks!


Un-zooming from third person incorrectly displays overlays in third person.

Un-zooming from third person incorrectly displays overlays in third person.

This has been fixed as of commit 0bde36b. The fixes are included with version 1.2.0.


Delete iree_tests/sharktank/.

These tests are redundant with newer test suites here:

https://github.com/iree-org/iree/tree/main/experimental/regression_suite/shark-test-suite-models (sd3 and sdxl)

Note that these tests use files from https://huggingface.co/amd-shark/sdxl-quant-models, while the tests there use Azure (sharkpublic)

https://github.com/iree-org/iree-test-suites/tree/main/sharktank_models (llama)

Note that llama 3 tested there is different from the openlm-research/open_llama_3b_v2 model tested here, but we should move tests to iree-test-suites anyways: https://github.com/iree-org/iree-test-suites/issues/49

Cool, this makes sense. Are you going to be doing the follow up PR to remove this testing in iree also?

Cool, this makes sense. Are you going to be doing the follow up PR to remove this testing/updating pin in iree also? I actually don't think we even run any other SHARK-TestSuite tests in iree, so we can probably fully remove shark test suite from iree testing

Yeah these run in IREE: https://github.com/iree-org/iree/blob/fb4d09470dc4be674de810dbfbf2d3764e2970ba/.github/workflows/pkgci_regression_test.yml#L83-L117. That test_models matrix.
          pytest \
            SHARK-TestSuite/iree_tests/pytorch/models \
            SHARK-TestSuite/iree_tests/sharktank \

I don't mind dropping the two pytorch/models/ tests at the same time. The coverage provided there is small at the moment, and I'm reasonably close to having a replacement ready in https://github.com/iree-org/iree-test-suites/issues/63.

Makes sense, sgtm


Persistence

Now the barometer trend plugin starts with an empty data set if Signal K is restarted. It would be great to persist the values so that you'd be able to get meaningful forecasts even when you restarted the system in the last 24h.
Some ideas:

Flat file (it is just couple of values after all)
Optional: if SK history API is available (for instance with InfluxDB), get the data from there on start-up

Great suggestions @bergie and I think it would be a great addition. I'll add it to the backlog 👍

Solved in newest release https://github.com/oyve/signalk-barometer-trend/releases/tag/v2.3.1


[FLINK-27944][runtime] Move input metrics out of the inputGate loop, …

What is the purpose of the change
to avoid counter register twice
Brief change log
Move input metrics out of the inputGate loop, to avoid redundant count registration
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): ( no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no )
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

@flinkbot run azure

@flinkbot run azure

@flinkbot run azure

@flinkbot run azure

@zhougit86 , could you rebase the PR on the latest master?

Superseded via #21437


Segfault in minidump_writer::linux::thread_list_stream::write when opt-level > 1

I recently released sentry-node-minidump which uses napi-rs to expose some of the code I wrote in minidumper-child to node.js to send minidumps to Sentry for node.js crashes. minidumper-child takes the code from the minidumper diskwrite example and packages it with a simpler API.
It wasn't until I actually added e2e tests in CI that I noticed that it didn't work on Linux!
After much debugging I found that the server was segfaulting when trying to write the dump file. It would write 236 bytes (presumably the header) before segfaulting in minidump_writer::linux::thread_list_stream::write. I noticed that this wasn't the case in debug mode, so I've managed to work around this by overriding opt-level = 1 for the Linux release build. opt-level = 2 results in the crash. This isn't actually a huge issue for sentry-node-minidump since I build and distribute the binaries.
It was at this point I realised that the CI tests for minidumper-child are only testing the debug profile. I opened a PR to test the release profile and it's failing, presumably for the same reason. This suggests the issue has nothing to do with node.js or napi-rs since that code is all Rust:
https://github.com/timfish/minidumper-child/pull/2
Should I have opened this issue in minidump-writer?
Have you seen anything like this before?

 This is a regression from 1.77.0 (so it's never happened before), and is due to the changes in u128 layout described here. I'm doing a fix now, thank you for reporting!

This was released in 0.8.9 of minidump-writer.

Ah perfect, thanks for the quick fix.
I didn't even think of trying previous Rust versions!