Remove implicit conversion from DeclBaseName to Identifier

The implicit conversion from DeclBaseName to Identifier just existed to aid migration from Identifier to DeclBaseName and is no longer needed. It will technically not even be correct once special names are introduced.
This includes the changes from #9975, #9976, #9977

Please test with following pull request:
apple/swift-lldb#206
@swift-ci Please test

Rebased onto an updated diagnostics branch.
@swift-ci Please test

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - cefe4cd672000d89c2e82a2eb21de3da188276d5
Test requested by - @ahoppen

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - cefe4cd672000d89c2e82a2eb21de3da188276d5
Test requested by - @ahoppen

By the way, I'm thinking we should hold off on landing this one (and the actual introduction of special names) until after the final rebranching of swift-4.0-branch (which should happen today or tomorrow). That way it won't have a chance of destabilizing the 4.0 release, but we'll still be able to cherry-pick things without having to fix them up on the other side.

@swift-ci Please test and merge


Request: Please provide builds

Please can you provide compiled binaries of the templates :pray:

Here's the one I'm using (release mode).

Thanks @Shin-NiL!

Here for Godot 3.0.6 Stable: here

Please check out this repository for templates using this module.


documentation update: envoy compressor filter

Title: documentation update: envoy compressor filter
Description:
Documentation here:
https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_filters/compressor_filter
states:
      typed_config:
        "@type": type.googleapis.com/envoy.extensions.compression.gzip.compressor.v3.Gzip
        memory_level: 3
        window_bits: 10
        compression_level: best_compression
        compression_strategy: default_strategy

While Gzip compressor extension: https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/compression/gzip/compressor/v3/gzip.proto
stays that it should be "BEST_COMPRESSION" and "DEFAULT_STRATEGY"
Not the end of the world, but took me a bit of time finding why I was getting this error:
admission webhook "validation.istio.io" denied the request: configuration is invalid: Envoy filter: can't unmarshal Any nested proto type.googleapis.com/envoy.extensions.filters.http.compressor.v3.Compressor: can't unmarshal Any nested proto type.googleapis.com/envoy.extensions.compression.gzip.compressor.v3.Gzip: unknown value "\"default_strategy\"" for enum envoy.extensions.compression.gzip.compressor.v3.Gzip.CompressionStrategy

Thank you for reporting!
Interesting. I always do tests with configs all in lower case without any problem. This looks like a peculiarity of the Go marshaller .
I'll update the docs.

somewhat relatedly - we have 2 types of validation for config - one is more of validating parser, and the config load tests that starts a server with the config
the latter enforces CAPS (for enums iirc) whereas the server can start with either (i believe)


Time

Fixes https://github.com/CartoDB/renderer-prototype/pull/264

Could we add the minimum documentation for this feature? 🙏

I improved the docs, pls, CR it


DllNotFoundException when running

Exact message.

An unhandled exception of type 'System.DllNotFoundException' occurred in sfmlnet-graphics-2.dll
Additional information: Unable to load DLL 'csfml-graphics-2': The specified module could not be found. (Exception from HRESULT: 0x8007007E)

The issue happens when it attempts to add the 'base_font', in the LoadBaseResources method, in the ResourceManagerZip class.
_fonts.Add("base_font", new Font( _stream));
Everything builds fine but this doesn't work. I don't know where to post this since the website and irc seems to be down...

http://www.spacestation14.com/wiki/Developer_Bootcamp#Windows
make sure the csfml libs are being copied to the output directory (http://imgur.com/a/nlR9y)


Rework algorithm to handle deferred events

Updated algorithm:

creates composite deferral list from active state configuration
checks for deferral of the current event, if yes checks wether high priority states can consume the event


flow: report afpacket stats as for pcap

It seems the stats goroutine is not stopped properly so the stats are updated after the capture has been removed.
In addition, the metadata still has a "Capture" dict so the WebUI still displays the red button.
I think the bugs were already there with pcap but we do not use the "pcap" capture type very often, as AFPacket is the default


Addressing issue #235

https://github.com/jshjohnson/Choices/issues/235: Rendering of selects with mixed options and optgroups in root level returns only groups - fixed.
Also corrected some typos.

You have some conflicts 👍

Any updates on this?


[BEAM-7041] Let the user control if he wants to wrap the provided DataSource as a poolable one or not

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[X] Choose reviewer(s) and mention them in a comment (R: @username).
[X] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[X] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang
SDK
Apex
Dataflow
Flink
Gearpump
Samza
Spark

Go

---
---
---
---
---
---

Java

Python

---

---
---
---

Pre-Commit Tests Status (on master branch)

---
Java
Python
Go
Website

Non-portable

Portable
---

---
---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

retest this please

Probably it is a better idea to redo this PR with a new method withDatasourceSupplierFn(SerializableFunction<Void, Datasource> supplierFn) to build the Datasource in a delayed 'Supplier-like' way and rewrite our current create(...) method to cover it.
This way we don't need this specific hacks and if required we can provide an external class that provides the pooled version but without affecting the IO API in the future.

@iemejia do you mind if I do the fn in a separate PR ? I don't want to mix the change in the same commits/PR.

I agree that I am probably adding an extra feature worth of a different JIRA, my goal was not to add new stuff to the current API. I will create a JIRA for the new feature, and just ask you to remove one little thing.

No, actually forget about it, I don't have in mind a better alternative (I would like to avoid the extra create) because it is public API and we are not sure of it is evolution (given the other feautre). So never mind for the moment about this, we will think about that after the other JIRA.

Run Java PreCommit

Run Java PreCommit


#2480: Autocomplete dropdown is sometimes not tall enough in the Edit View

Doesn't happen deterministically (or I just couldn't find the triggering condition) but after a few edits both in the Description and Project field, the dropdown can show being able to display only one entry (instead of about 6 it shows regularly).
Part of #2480

Again, I'm convinced this issue was fixed, or became much harder to reproduce. Does this still happen to you, @IndrekV ?

I'll test it out and close it if I can't reproduce.

Unable to reproduce.

seems to be happening with description field in edit view. If you filter the items the filter is not reset and after clearing the field you do not see all the items.

The last comment formulate into new issue -  #2625

out of date


Analog Clock

Thanks for the great work! I added Bulgarian language and tried to implement MainClockAnalog. It works, but when I try to open Settings on my watch it crashes. I've commented "Settings section" in the code and it works without using any widgets. Please take a look I'd be really happy to see it working
MainClockAnalog.txt
.

Awesome!

I've done it, but it's quite buggy on STRATOSfied <IP_ADDRESS>
Uploading preview.png…
GreatFit-3.7Test.zip

Danireo, thank you very much for your code, it was very helpful!
Commit 1709ad5067021b4c531eab2075d874e9cccdd20a


Vikylin YC2367C-ISU-28 2-Way audio backchannel

I'm trying to get the backchannel working on this 2-way audio camera from vikylin.
In order to get the stream with video and audio I had to disable the backchannel otherwise go2rtc will complain and show an i/o timeout error in the logs.
They advertise this camera as compatible with Hikvision and Dahua NVRs so the camera also responds to the following rtsp url streams from both manufacturer:
rtsp://camera_ip:port/cam/realmonitor?channel=0&subtype=0&unicast=true&proto=Onvif#backchannel=0
rtsp://camera_ip:port/Streaming/Channels/101/transportmode=unicast&profile&Profile_1#backchannel=0
although their official documentation points at the rtsp url below as the official one.
rtsp://user:pwd@camera_ip:port/stream0#backchannel=1
currently the configuration.yml looks like this
streams:
  cam_1:
    - rtsp://user:pwd@camera_ip:port/stream0#backchannel=1

The above confir works fine for video and audio but no audio can be sent to the camera as the backchannel is disabled.
The 2-way audio feature work just fine when when using their app "videolink"
Below is the trace log when enabling the backchannel:

15:58:40.311 TRC [rtsp] client response:
RTSP/1.0 401 Unauthorized
Cseq: 1
Www-Authenticate: Basic realm="/"

15:58:40.311 TRC [rtsp] client request:
DESCRIBE rtsp://<IP_ADDRESS>:554/stream0 RTSP/1.0
Accept: application/sdp
Require: www.onvif.org/ver20/backchannel
User-Agent: go2rtc/1.8.4
CSeq: 2
Authorization: Basic YWRtaW46MTIzNDU2

15:58:40.326 TRC [rtsp] client response:
RTSP/1.0 200 OK
Content-Type: application/sdp
Content-Length: 830
Content-Base: rtsp://rtsp://<IP_ADDRESS>:554/stream0/
Cseq: 2

v=0
o=-<PHONE_NUMBER>219182<PHONE_NUMBER>219192 IN IP4 x.y.z.w
s=RTSP/RTP stream from icamra ipc
e=NONE
c=IN IP4 <IP_ADDRESS>
a=tool:LIVE555 Streaming Media v2011.05.25<EMAIL_ADDRESS>t=0 0
a=range:npt=0-
a=control:*
m=video 0 RTP/AVP 96
a=rtpmap:96 H264/90000
a=control:trackID=1
a=fmtp:96 profile-level-id=640028;packetization-mode=0;sprop-parameter-sets=Z2QAKKzSAeAIn5YQAAA+kAAMOCBA,aOqPLA==;config=0000000167640028acd201e0089f961000003e90000c3820400000000168ea8f2c
a=x-dimensions: 1920, 1080
a=x-framerate: 25
m=audio 0 RTP/AVP 0
a=rtpmap:0 PCMU/8000
a=control:trackID=2
a=Media_header:MEDIAINFO=494D4B48010100000400010010710110401F000000FA000000000000000000000000000000000000;
a=appversion:1.0
m=audio 0 RTP/AVP 0
a=control:rtsp://rtsp://<IP_ADDRESS>:554/stream0/backchannel
a=rtpmap:0 PCMU/8000
a=sendonly

15:58:40.326 TRC [rtsp] client request:
SETUP rtsp://<IP_ADDRESS>:554/stream0/trackID=1 RTSP/1.0
Authorization: Basic YWRtaW46MTIzNDU2
Transport: RTP/AVP/TCP;unicast;interleaved=0-1
CSeq: 3

15:58:40.328 TRC [rtsp] client response:
RTSP/1.0 200 OK
Cseq: 3
Session: 565075292d
Transport: RTP/AVP/TCP;unicast;interleaved=6-7

15:58:40.328 TRC [rtsp] client request:
SETUP rtsp://<IP_ADDRESS>:554/stream0/trackID=2 RTSP/1.0
Transport: RTP/AVP/TCP;unicast;interleaved=2-3
CSeq: 4
Authorization: Basic YWRtaW46MTIzNDU2
Session: 565075292d

15:58:40.331 TRC [rtsp] client response:
RTSP/1.0 200 OK
Cseq: 4
Session: 565075292d
Transport: RTP/AVP/TCP;unicast;interleaved=6-7

15:58:40.331 TRC [rtsp] client request:
PLAY rtsp://<IP_ADDRESS>:554/stream0/ RTSP/1.0
CSeq: 5
Authorization: Basic YWRtaW46MTIzNDU2
Session: 565075292d

15:58:40.332 TRC [rtsp] client response:
RTSP/1.0 200 OK
Cseq: 5
Session: 565075292d
Range: npt=0.000-
Rtp-Info:

15:58:43.233 DBG [streams] stop producer url=rtsp://user:pwd@<IP_ADDRESS>:554/stream0#backchannel=1
15:58:43.233 TRC [rtsp] client request:
TEARDOWN rtsp://<IP_ADDRESS>:554/stream0/ RTSP/1.0
Authorization: Basic YWRtaW46MTIzNDU2
Session: 565075292d
CSeq: 6

15:58:43.233 TRC [streams] stop reconnect url=rtsp://user:pwd@<IP_ADDRESS>:554/stream0#backchannel=1

So I'm wondering if something can be done in order to get backchannel working?

Are you sure you have HTTPS and access to microphone in your browser?
I can see two way audio support in your logs.

I'm trying to access the stream using the HA go2rtc addon. HA is fully running over https/ssl with a valid certificate. I'm or was under the impression that when enabling the backchannel the stream would remain accesible over http just without microphone access.  But by your comments I'm fully in doubt...
Is it require no matter how the stream is being access (through HA under ssl) to have TLS enabled (including the tls certificate) on the go2rtc config?
tls_listen: ":443" # default "", enable HTTPS server
tls_cert: |        # default "", PEM-encoded fullchain certificate for HTTPS
-----BEGIN CERTIFICATE-----
...
-----END CERTIFICATE-----
tls_key: |         # default "", PEM-encoded private key for HTTPS
-----BEGIN PRIVATE KEY-----
...
-----END PRIVATE KEY-----

I just enable ssl on go2rtc and now the config looks like this:
api:
  listen: ":1984"
  tls_listen: ":8444"
  tls_cert: /ssl/fullchain.pem
  tls_key: /ssl/privkey.pem

webrtc:
  candidates:
    - xx.xx.xx.xx:8555  # if you have dynamic public IP-address

streams:
  cam_01:
    - rtsp://admin:123456@<IP_ADDRESS>:554/stream0#backchannel=1
  #cam_02:
  #      - rtsp://admin:123456@<IP_ADDRESS>:554/stream0#backchannel=0
log:
  format: ""
  level: "trace"

But I get the same results (Black page) when trying to access the webrtc stream using:
https://go2rtc_ip:8444/stream.html?src=cam_01&mode=webrtc
The logs shows:
14:51:54.564 DBG [streams] retry=0 to url=rtsp://admin:123456@<IP_ADDRESS>:554/stream0#backchannel=1
14:51:54.565 TRC [rtsp] client request:
DESCRIBE rtsp://<IP_ADDRESS>:554/stream0 RTSP/1.0
User-Agent: go2rtc/1.8.4
CSeq: 1
Accept: application/sdp
Require: www.onvif.org/ver20/backchannel

14:51:54.624 TRC [rtsp] client response:
RTSP/1.0 401 Unauthorized
Cseq: 1
Www-Authenticate: Basic realm="/"

14:51:54.624 TRC [rtsp] client request:
DESCRIBE rtsp://<IP_ADDRESS>:554/stream0 RTSP/1.0
User-Agent: go2rtc/1.8.4
CSeq: 2
Authorization: Basic YWRtaW46MTIzNDU2
Accept: application/sdp
Require: www.onvif.org/ver20/backchannel

14:51:54.628 TRC [rtsp] client response:
RTSP/1.0 200 OK
Content-Length: 827
Content-Base: rtsp://rtsp://<IP_ADDRESS>:554/stream0/
Cseq: 2
Content-Type: application/sdp

v=0
o=-<PHONE_NUMBER>219182<PHONE_NUMBER>219192 IN IP4 x.y.z.w
s=RTSP/RTP stream from icamra ipc
e=NONE
c=IN IP4 <IP_ADDRESS>
a=tool:LIVE555 Streaming Media v2011.05.25<EMAIL_ADDRESS>t=0 0
a=range:npt=0-
a=control:*
m=video 0 RTP/AVP 96
a=rtpmap:96 H264/90000
a=control:trackID=1
a=fmtp:96 profile-level-id=4D0032;packetization-mode=0;sprop-parameter-sets=Z00AMukAeAET8sIAAAfSAAE40Ag=,aOqPIA==;config=00000001674d0032e900780113f2c2000007d2000138d0080000000168ea8f20
a=x-dimensions: 3840, 1080
a=x-framerate: 20
m=audio 0 RTP/AVP 0
a=rtpmap:0 PCMU/8000
a=control:trackID=2
a=Media_header:MEDIAINFO=494D4B48010100000400010010710110401F000000FA000000000000000000000000000000000000;
a=appversion:1.0
m=audio 0 RTP/AVP 0
a=control:rtsp://rtsp://<IP_ADDRESS>:554/stream0/backchannel
a=rtpmap:0 PCMU/8000
a=sendonly

14:51:54.628 TRC [rtsp] client request:
SETUP rtsp://<IP_ADDRESS>:554/stream0/trackID=1 RTSP/1.0
Transport: RTP/AVP/TCP;unicast;interleaved=0-1
CSeq: 3
Authorization: Basic YWRtaW46MTIzNDU2

14:51:54.668 TRC [rtsp] client response:
RTSP/1.0 200 OK
Cseq: 3
Session:<PHONE_NUMBER>d
Transport: RTP/AVP/TCP;unicast;interleaved=6-7

14:51:54.668 TRC [rtsp] client request:
SETUP rtsp://<IP_ADDRESS>:554/stream0/trackID=2 RTSP/1.0
Transport: RTP/AVP/TCP;unicast;interleaved=2-3
CSeq: 4
Authorization: Basic YWRtaW46MTIzNDU2
Session:<PHONE_NUMBER>d

14:51:54.669 TRC [rtsp] client response:
RTSP/1.0 200 OK
Cseq: 4
Session:<PHONE_NUMBER>d
Transport: RTP/AVP/TCP;unicast;interleaved=6-7

14:51:54.670 TRC [rtsp] client request:
PLAY rtsp://<IP_ADDRESS>:554/stream0/ RTSP/1.0
CSeq: 5
Authorization: Basic YWRtaW46MTIzNDU2
Session:<PHONE_NUMBER>d

14:51:54.671 TRC [rtsp] client response:
RTSP/1.0 200 OK
Cseq: 5
Session:<PHONE_NUMBER>d
Range: npt=0.000-
Rtp-Info:

Has this link never worked for you rtsp://user:pwd@camera_ip:port/stream0 ?
Have you tried it in the VLC?
Have you tried it with backchannel=0 ?

Yes,  this works fine:
rtsp://user:pwd@camera_ip:port/stream0backchannel=0 (Video and incoming audio) (no 2-way audio)
Although I'm trying to get 2-way audio working with:
rtsp://user:pwd@camera_ip:port/stream0
or
rtsp://user:pwd@camera_ip:port/stream0backchannel=1
But none of them work. I tried enabled ssl and gave permission to the microphone... but the stream does not load... not even the video, just a black page spinning.
I've updated my previous comments showing the latest trace logs (after enabling ssl and mic)

You have very strange stream info in the previous message. It not related to your config.

This is what the go2rtc logs are showing when trying to access the stream but returns a black page
Config:
api:
  listen: ":1984"    # default ":1984", HTTP API port ("" - disabled)
  tls_listen: ":8444" # default "", enable HTTPS server
  tls_cert: /ssl/fullchain.pem
  tls_key: /ssl/privkey.pem

streams:
  cam_01:
    - rtsp://admin:pass@<IP_ADDRESS>:554/stream0
log:
  format: ""
  level: "trace"

Info:
{
  "producers": [
    {
      "type": "RTSP active producer",
      "url": "rtsp://<IP_ADDRESS>:554/stream0/",
      "remote_addr": "<IP_ADDRESS>:554",
      "user_agent": "go2rtc/1.8.4",
      "sdp": "v=0\r\no=-<PHONE_NUMBER>219182<PHONE_NUMBER>219192 IN IP4 x.y.z.w\r\ns=RTSP/RTP stream from icamra ipc\r\ne=NONE\r\nc=IN IP4 <IP_ADDRESS>\r\na=tool:LIVE555 Streaming Media v2011.05.25<EMAIL_ADDRESS>0\r\na=range:npt=0-\r\na=control:*\r\nm=video 0 RTP/AVP 96\r\na=rtpmap:96 H264/90000\r\na=control:trackID=1\r\na=fmtp:96 profile-level-id=4D0032;packetization-mode=0;sprop-parameter-sets=Z00AMukAeAET8sIAAAfSAAE40Ag=,aOqPIA==;config=00000001674d0032e900780113f2c2000007d2000138d0080000000168ea8f20\r\na=x-dimensions: 3840, 1080\r\na=x-framerate: 20\r\nm=audio 0 RTP/AVP 0\r\na=rtpmap:0 PCMU/8000\r\na=control:trackID=2\r\na=Media_header:MEDIAINFO=494D4B48010100000400010010710110401F000000FA000000000000000000000000000000000000;\r\na=appversion:1.0\r\nm=audio 0 RTP/AVP 0\r\na=control:rtsp://rtsp://<IP_ADDRESS>:554/stream0/backchannel\r\na=rtpmap:0 PCMU/8000\r\na=sendonly\r\n",
      "medias": [
        "video, recvonly, H.264 Main 5.0",
        "audio, recvonly, PCMU/8000",
        "audio, sendonly, PCMU/8000"
      ],
      "receivers": [
        "96 H264, bytes=0, senders=1",
        "0 PCMU/8000, bytes=0, senders=1"
      ],
      "senders": [
        "0 PCMU/8000, bytes=10880, receivers=1"
      ],
      "send": 11792
    }
  ],
  "consumers": [
    {
      "type": "WebRTC/WebSocket async passive consumer",
      "remote_addr": "udp6 host [2600:1700:4198:bf:e979:484a:4ba1:311a]:64313",
      "user_agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36",
      "medias": [
        "video, sendonly, VP8, RTX, VP9, H264, AV1, RED, ULPFEC, FLEXFEC-03",
        "audio, recvonly, OPUS/48000/2, RED/48000/2, G722/8000, PCMU/8000, PCMA/8000, CN/8000, TELEPHONE-EVENT/48000, TELEPHONE-EVENT/8000",
        "audio, sendonly, OPUS/48000/2, RED/48000/2, G722/8000, PCMU/8000, PCMA/8000, CN/8000, TELEPHONE-EVENT/48000, TELEPHONE-EVENT/8000, L16, PCML"
      ],
      "receivers": [
        "0 PCMU/8000, bytes=10880, senders=1"
      ],
      "senders": [
        "102 H264, bytes=0, receivers=1",
        "0 PCMU/8000, bytes=0, receivers=1"
      ],
      "recv": 12240
    }
  ]
}

trace logs (This repeats over and over while the browser tries to access the stream using:
https://go2rtc_ip:8444/webrtc.html?src=cam_01&media=video+audio+microphone
09:13:29.864 TRC [rtsp] client request:
DESCRIBE rtsp://<IP_ADDRESS>:554/stream0 RTSP/1.0
Authorization: Basic YWRtaW46MTIzNDU2
Accept: application/sdp
Require: www.onvif.org/ver20/backchannel
User-Agent: go2rtc/1.8.4
CSeq: 2

09:13:29.915 TRC [rtsp] client response:
RTSP/1.0 200 OK
Cseq: 2
Content-Type: application/sdp
Content-Length: 827
Content-Base: rtsp://rtsp://<IP_ADDRESS>:554/stream0/

v=0
o=-<PHONE_NUMBER>219182<PHONE_NUMBER>219192 IN IP4 x.y.z.w
s=RTSP/RTP stream from icamra ipc
e=NONE
c=IN IP4 <IP_ADDRESS>
a=tool:LIVE555 Streaming Media v2011.05.25<EMAIL_ADDRESS>t=0 0
a=range:npt=0-
a=control:*
m=video 0 RTP/AVP 96
a=rtpmap:96 H264/90000
a=control:trackID=1
a=fmtp:96 profile-level-id=4D0032;packetization-mode=0;sprop-parameter-sets=Z00AMukAeAET8sIAAAfSAAE40Ag=,aOqPIA==;config=00000001674d0032e900780113f2c2000007d2000138d0080000000168ea8f20
a=x-dimensions: 3840, 1080
a=x-framerate: 20
m=audio 0 RTP/AVP 0
a=rtpmap:0 PCMU/8000
a=control:trackID=2
a=Media_header:MEDIAINFO=494D4B48010100000400010010710110401F000000FA000000000000000000000000000000000000;
a=appversion:1.0
m=audio 0 RTP/AVP 0
a=control:rtsp://rtsp://<IP_ADDRESS>:554/stream0/backchannel
a=rtpmap:0 PCMU/8000
a=sendonly

09:13:29.915 TRC [rtsp] client request:
SETUP rtsp://<IP_ADDRESS>:554/stream0/trackID=1 RTSP/1.0
Transport: RTP/AVP/TCP;unicast;interleaved=0-1
CSeq: 3
Authorization: Basic YWRtaW46MTIzNDU2

09:13:29.960 TRC [rtsp] client response:
RTSP/1.0 200 OK
Cseq: 3
Session:<PHONE_NUMBER>d
Transport: RTP/AVP/TCP;unicast;interleaved=6-7

09:13:29.960 TRC [rtsp] client request:
SETUP rtsp://<IP_ADDRESS>:554/stream0/trackID=2 RTSP/1.0
CSeq: 4
Authorization: Basic YWRtaW46MTIzNDU2
Session:<PHONE_NUMBER>d
Transport: RTP/AVP/TCP;unicast;interleaved=2-3

09:13:30.016 TRC [rtsp] client response:
RTSP/1.0 200 OK
Cseq: 4
Session:<PHONE_NUMBER>d
Transport: RTP/AVP/TCP;unicast;interleaved=6-7

09:13:30.016 TRC [rtsp] client request:
SETUP rtsp://<IP_ADDRESS>:554/stream0/backchannel RTSP/1.0
CSeq: 5
Authorization: Basic YWRtaW46MTIzNDU2
Session:<PHONE_NUMBER>d
Transport: RTP/AVP/TCP;unicast;interleaved=4-5

09:13:30.065 TRC [rtsp] client response:
RTSP/1.0 200 OK
Cseq: 5
Session:<PHONE_NUMBER>d
Transport: RTP/AVP/TCP;unicast;interleaved=6-7

09:13:30.065 TRC [rtsp] client request:
PLAY rtsp://<IP_ADDRESS>:554/stream0/ RTSP/1.0
Session:<PHONE_NUMBER>d
CSeq: 6
Authorization: Basic YWRtaW46MTIzNDU2

09:13:30.112 TRC [rtsp] client response:
RTSP/1.0 200 OK
Range: npt=0.000-
Rtp-Info:
Cseq: 6
Session:<PHONE_NUMBER>d

No edit on this post... Hopefully this could share more info...

Well. I can see two way connection in your logs. But camera didn't send any data. I think it's problem with camera firmware. Some unknown brand...
Original app may use some proprietary two way proto.

I have a question,
09:31:32.579 TRC [rtsp] client response:
RTSP/1.0 200 OK
Cseq: 2
Content-Type: application/sdp
Content-Length: 827
Content-Base: rtsp://rtsp://<IP_ADDRESS>:554/stream0/

Could it be that double rtsp:// prefix that does not allow the proper connection?

Who knows. Your camera sends this data. I can try to fix this moment. No any hope that this helps.

worth a shot... right? 😄 Seems like a good camera at a very good price... If it works I could test the other models they have and share it as a supported 2-way audio camera.

Just a quick follow up to revive this and see if there was a chance to tweak the double rtsp trailing ?

Check latest dev version
https://github.com/AlexxIT/go2rtc?tab=readme-ov-file#go2rtc-dev-version

Just tried it but no luck....Not sure if the latest build condition to capture the double rtsp is not met thus keeping the double rtsp in there?
regardless... thanks a lot for giving it a shot!
2024-01-19 11:12:11.013847483  size=N/A time=00:11:43.01 bitrate=N/A speed=   1x
size=N/A time=00:05:32.97 bitrate=N/A speed=   1x
size=N/A time=00:11:43.53 bitrate=N/A speed=   1x
size=N/A time=00:05:33.49 bitrate=N/A speed=   1x
size=N/A time=00:11:44.07 bitrate=N/A speed=   1x
size=N/A time=00:05:33.97 bitrate=N/A speed=   1x
size=N/A time=00:11:44.57 bitrate=N/A speed=   1x
size=N/A time=00:05:34.49 bitrate=N/A speed=   1x
size=N/A time=00:11:45.07 bitrate=N/A speed=   1x
size=N/A time=00:05:35.05 bitrate=N/A speed=   1x
size=N/A time=00:11:45.57 bitrate=N/A speed=   1x
size=N/A time=00:05:35.53 bitrate=N/A speed=   1x
size=N/A time=00:11:46.09 bitrate=N/A speed=   1x
11:12:11.013 TRC [rtsp] server request:
2024-01-19 11:12:11.013856994  TEARDOWN rtsp://<IP_ADDRESS>:8554/Front_South_Corner_to_North_10_1_8_83 RTSP/1.0
2024-01-19 11:12:11.013858797  Cseq: 5
2024-01-19 11:12:11.013860635  User-Agent: FFmpeg Frigate/0.13.0-49814b3
2024-01-19 11:12:11.013862200  Session: 71550882
2024-01-19 11:12:11.013863615
2024-01-19 11:12:11.013865010
2024-01-19 11:12:11.013903796  11:12:11.013 DBG [rtsp] handle=EOF
2024-01-19 11:12:11.013988750  11:12:11.013 DBG [rtsp] disconnect stream=Front_South_Corner_to_North_10_1_8_83
2024-01-19 11:12:11.166939274  size=N/A time=00:05:36.05 bitrate=N/A speed=   1x
[libopus @ 0x55ec5fe06fc0] Queue input is backward in time
2024-01-19 11:12:11.806144775  size=N/A time=00:11:46.61 bitrate=N/A speed=   1x
size=N/A time=00:05:36.53 bitrate=N/A speed=   1x
[libopus @ 0x55ec5fe06fc0] Queue input is backward in time
2024-01-19 11:12:12.441774785  size=N/A time=00:11:47.11 bitrate=N/A speed=   1x
size=N/A time=00:05:37.05 bitrate=N/A speed=   1x
[libopus @ 0x55ec5fe06fc0] Queue input is backward in time
2024-01-19 11:12:12.736078726  size=N/A time=00:11:47.61 bitrate=N/A speed=   1x
size=N/A time=00:05:37.69 bitrate=N/A speed=   1x
11:12:12.735 WRN github.com/AlexxIT/go2rtc/internal/streams/producer.go:171 > error="read tcp <IP_ADDRESS>:34228-><IP_ADDRESS>:554: i/o timeout" url=rtsp://admin:123456@<IP_ADDRESS>:554/stream0#backchannel=1#video=h264#width=1920#audio=copy#audio=aac#audio=opus
2024-01-19 11:12:12.736102496  11:12:12.736 DBG [streams] retry=0 to url=rtsp://admin:123456@<IP_ADDRESS>:554/stream0#backchannel=1#video=h264#width=1920#audio=copy#audio=aac#audio=opus
2024-01-19 11:12:12.741512441  11:12:12.741 TRC [rtsp] client request:
2024-01-19 11:12:12.741516468  DESCRIBE rtsp://<IP_ADDRESS>:554/stream0 RTSP/1.0
2024-01-19 11:12:12.741518561  Accept: application/sdp
2024-01-19 11:12:12.741520608  Require: www.onvif.org/ver20/backchannel
2024-01-19 11:12:12.741522340  User-Agent: go2rtc/1.8.5
2024-01-19 11:12:12.741523947  CSeq: 1
2024-01-19 11:12:12.741525514
2024-01-19 11:12:12.741526990
2024-01-19 11:12:12.800505857  11:12:12.800 TRC [rtsp] client response:
2024-01-19 11:12:12.800511303  RTSP/1.0 401 Unauthorized
2024-01-19 11:12:12.800513125  Cseq: 1
2024-01-19 11:12:12.800515092  Www-Authenticate: Basic realm="/"
2024-01-19 11:12:12.800516809
2024-01-19 11:12:12.800518424
2024-01-19 11:12:12.800539167  11:12:12.800 TRC [rtsp] client request:
2024-01-19 11:12:12.800541202  DESCRIBE rtsp://<IP_ADDRESS>:554/stream0 RTSP/1.0
2024-01-19 11:12:12.800543078  Require: www.onvif.org/ver20/backchannel
2024-01-19 11:12:12.800544797  User-Agent: go2rtc/1.8.5
2024-01-19 11:12:12.800546454  CSeq: 2
2024-01-19 11:12:12.800548270  Authorization: Basic YWRtaW46MTIzNDU2
2024-01-19 11:12:12.800549980  Accept: application/sdp
2024-01-19 11:12:12.800551500
2024-01-19 11:12:12.800552997
2024-01-19 11:12:12.848995199  11:12:12.848 TRC [rtsp] client response:
2024-01-19 11:12:12.849000661  RTSP/1.0 200 OK
2024-01-19 11:12:12.849002497  Cseq: 2
2024-01-19 11:12:12.849004317  Content-Type: application/sdp
2024-01-19 11:12:12.849006049  Content-Length: 827
2024-01-19 11:12:12.849008041  Content-Base: rtsp://rtsp://<IP_ADDRESS>:554/stream0/
2024-01-19 11:12:12.849009705
2024-01-19 11:12:12.849011246  v=0
2024-01-19 11:12:12.849013083  o=-<PHONE_NUMBER>219182<PHONE_NUMBER>219192 IN IP4 x.y.z.w
2024-01-19 11:12:12.849014836  s=RTSP/RTP stream from icamra ipc
2024-01-19 11:12:12.849016399  e=NONE
2024-01-19 11:12:12.849018032  c=IN IP4 <IP_ADDRESS>
2024-01-19 11:12:12.849019932  a=tool:LIVE555 Streaming Media v2011.05.25<EMAIL_ADDRESS>2024-01-19 11:12:12.849021481  t=0 0
2024-01-19 11:12:12.849023043  a=range:npt=0-
2024-01-19 11:12:12.849024618  a=control:*
2024-01-19 11:12:12.849026323  m=video 0 RTP/AVP 96
2024-01-19 11:12:12.849027980  a=rtpmap:96 H264/90000
2024-01-19 11:12:12.849029554  a=control:trackID=1
2024-01-19 11:12:12.849032161  a=fmtp:96 profile-level-id=4D0032;packetization-mode=0;sprop-parameter-sets=Z00AMukAeAET8sIAAAfSAAE40Ag=,aOqPIA==;config=00000001674d0032e900780113f2c2000007d2000138d0080000000168ea8f20
2024-01-19 11:12:12.849033829  a=x-dimensions: 3840, 1080
2024-01-19 11:12:12.849035453  a=x-framerate: 20
2024-01-19 11:12:12.849037021  m=audio 0 RTP/AVP 0
2024-01-19 11:12:12.849038947  a=rtpmap:0 PCMU/8000
2024-01-19 11:12:12.849041398  a=control:trackID=2
2024-01-19 11:12:12.849045060  a=Media_header:MEDIAINFO=494D4B48010100000400010010710110401F000000FA000000000000000000000000000000000000;
2024-01-19 11:12:12.849047603  a=appversion:1.0
2024-01-19 11:12:12.849050089  m=audio 0 RTP/AVP 0
2024-01-19 11:12:12.849053000  a=control:rtsp://rtsp://<IP_ADDRESS>:554/stream0/backchannel
2024-01-19 11:12:12.849054873  a=rtpmap:0 PCMU/8000
2024-01-19 11:12:12.849056418  a=sendonly
2024-01-19 11:12:12.849057867
2024-01-19 11:12:12.849135074  11:12:12.849 TRC [rtsp] client request:
2024-01-19 11:12:12.849137312  SETUP rtsp://<IP_ADDRESS>:554/stream0/trackID=1 RTSP/1.0
2024-01-19 11:12:12.849139059  Transport: RTP/AVP/TCP;unicast;interleaved=0-1
2024-01-19 11:12:12.849140559  CSeq: 3
2024-01-19 11:12:12.849142316  Authorization: Basic YWRtaW46MTIzNDU2
2024-01-19 11:12:12.849143765
2024-01-19 11:12:12.849145199
2024-01-19 11:12:12.850306484  11:12:12.850 TRC [rtsp] client response:
2024-01-19 11:12:12.850308788  RTSP/1.0 200 OK
2024-01-19 11:12:12.850310226  Cseq: 3
2024-01-19 11:12:12.850311782  Session:<PHONE_NUMBER>d
2024-01-19 11:12:12.850313520  Transport: RTP/AVP/TCP;unicast;interleaved=6-7
2024-01-19 11:12:12.850315004
2024-01-19 11:12:12.850316415
2024-01-19 11:12:12.850334815  11:12:12.850 TRC [rtsp] client request:
2024-01-19 11:12:12.850336757  SETUP rtsp://<IP_ADDRESS>:554/stream0/trackID=2 RTSP/1.0
2024-01-19 11:12:12.850339112  Transport: RTP/AVP/TCP;unicast;interleaved=2-3
2024-01-19 11:12:12.850341462  CSeq: 4
2024-01-19 11:12:12.850344055  Authorization: Basic YWRtaW46MTIzNDU2
2024-01-19 11:12:12.850346495  Session:<PHONE_NUMBER>d
2024-01-19 11:12:12.850348597
2024-01-19 11:12:12.850350837
2024-01-19 11:12:12.851336834  11:12:12.851 TRC [rtsp] client response:
2024-01-19 11:12:12.851339925  RTSP/1.0 200 OK
2024-01-19 11:12:12.851341817  Cseq: 4
2024-01-19 11:12:12.851343747  Session:<PHONE_NUMBER>d
2024-01-19 11:12:12.851345874  Transport: RTP/AVP/TCP;unicast;interleaved=6-7
2024-01-19 11:12:12.851347643
2024-01-19 11:12:12.851349332
2024-01-19 11:12:12.851405798  11:12:12.851 TRC [rtsp] client request:
2024-01-19 11:12:12.851409824  PLAY rtsp://<IP_ADDRESS>:554/stream0/ RTSP/1.0
2024-01-19 11:12:12.851411750  CSeq: 5
2024-01-19 11:12:12.851413657  Authorization: Basic YWRtaW46MTIzNDU2
2024-01-19 11:12:12.851415386  Session:<PHONE_NUMBER>d
2024-01-19 11:12:12.851416958
2024-01-19 11:12:12.851418484
2024-01-19 11:12:12.852150443  11:12:12.852 TRC [rtsp] client response:
2024-01-19 11:12:12.852154345  RTSP/1.0 200 OK
2024-01-19 11:12:12.852156239  Rtp-Info:
2024-01-19 11:12:12.852158027  Cseq: 5
2024-01-19 11:12:12.852160081  Session:<PHONE_NUMBER>d
2024-01-19 11:12:12.852162067  Range: npt=0.000-
2024-01-19 11:12:12.852163825
2024-01-19 11:12:12.852165558

Your camera has really bad realisation. It response with same interleaved for different tracks.

also planning to purchase a Vikylin, i wonder if you have tried flashing it with hikvision firmware? i might try that if it does not work, even though i got a other model.

https://github.com/AlexxIT/go2rtc/releases/tag/v1.9.0

https://github.com/AlexxIT/go2rtc/releases/tag/v1.9.0

Just tried it enabling the backchannel but didn't work.

I don't think, that your camera can be fixed.
v1.9.0 fixes only double rtsp, but not two way.

It was worth a shot... :)


fix image size (aspect ratio) of speaker icon on TimetableGridITem

I converted to "Draft" because of unexpected snapshot
Issue

no issue

Overview (Required)

when loading speaker icon, width of icon will be expanded to max width of Row.
by setting Modifier.aspectRatio(...), fix the size of icon as square.

Links

https://developer.android.com/jetpack/compose/graphics/images/customize#custom-aspect-ratio

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before
After

Movie (Optional)

Before
After

I'm not sure what is happening 🤔

Hmm. Mee too 🤔
And I don't change about TimetableListItem...

@takahirom
It was my guilty :bow:


Error C2039: "value" is not a member of "boost::proto"

I installed boost and cpp-netlib using vcpkg,but when I'm using it by #include “boost/network/uri.hpp" ,I got error C2039.The error is reported at "F:\vcpkg\installed\x64-windows\include\boost\proto\generate.hpp",in line239 and line 248.
IDE: Viaual Studio Professional 2019
System: Windows 10 x64

uri module doesn't require boost anymore


Pen(cil) icons for editing profile items not working

Clicking on the pen icons in profile doesn't do anything.

The profile page is not active yet.

This is an old profile page and that functionality was not implemented, just hard coded.
As of today, the latest profile page is available in prod. Note that the pen icons have been removed as they are not used in the latest mockups.


Allow modification of menu keybindings

My keyboard layout has different keys on 'j' & 'k'. This allows changing the defaults.

Reasonable. Will add the changes later today.

Incorporated your suggestions. Although, I didn't update the j/k text, since by default you'd still use j and k for navigation. The variables are documented in NERDTree.txt.

That text needs to change. The default is j/k, but if you override them, that needs to be reflected in the text.
    echo "NERDTree Menu. Use " . g:NERDTreeMenuDown . "/" . g:NERDTreeMenuUp . "/enter and the shortcuts indicated"

Ahh, I didn't think of that. Makes sense.

Fixed.

Excellent! Thanks for the contribution, @Leandros.

Thank you for NERDTree!


Add helm-chart for redis-cluster

Is this a BUG REPORT or FEATURE REQUEST? (choose one):
FEATURE REQUEST:

Add a chart for installing redis as a redis-cluster

What is a redis-cluster?
Redis Cluster is a set of Redis instances working together to make your data storage scale across nodes while also making it a bit more resilient. Data is automatically split across nodes and it supports a master/slave setup for increased availability in case of a failure. It is basically a data sharding strategy, with the ability to reshard keys from one node to another while the cluster is running, together with a failover procedure that makes sure the system is able to survive certain kinds of failures.
For Reference: https://redislabs.com/redis-features/redis-cluster

will be taking this up.

I'd say that Redis-HA chart configures this already. See https://github.com/helm/charts/tree/master/stable/redis-ha

redis-cluster is slightly different from redis-ha. A redis-cluster has multiple masters and multiple slaves and the keys can distribute themselves among the master redis instances, basically a redis-cluster provides a redis database that is sharded across multiple nodes.
From what I saw in the redis-ha chart, it can only provide a simple one master, multiple slave model and provide high availability.
Please let me know if I missed something.

related issue: https://github.com/helm/charts/issues/11817

I think that redis-cluster chart should be added as an incubator chart because Redis Cluster is different from Redis Sentinel (redis-ha chart).
I have already implemented my own redis-cluster chart (without enough documents). If @vidhig hasn't start to work for this yet, I'll add documents to my chart and create PR.

@neglect-yp I have started working on this and planned on adding it to the incubator repo. I have the chart ready but working on writing the appropriate README.md and NOTES.txt.
Will be creating the PR by the end of next week.

@vidhig Thank you for your reply. I'm looking forward to your PR :smile: .

Link to the PR: https://github.com/helm/charts/pull/13029
This PR is working but can be improved. Any inputs would be very helpful.
Thank you


State of buttons

Hello
This is really cool, how do i get if a button is pressed or not?

You need action sets for that. hello_xr can be used as example https://github.com/cmbruns/pyopenxr_examples/blob/main/xr_examples/hello_xr/openxr_program.py#L411


Upgrade dependencies and switch to GitHub Actions

Remove yarn.lock
Add package-lock.json
Switch to GitHub Actions
Update license year (2017-now)
Build against Node LTS (14) and Node current (15)

I'll go ahead and merge this since there is no reason not to.


[Beta 1.2] Storage Drives Really Dark/Shadowed

Issue description:
The storage drives appear extremely shadowed, nearly black.
What happens:
When placing a storage drive next to a block in a Refined Storage system network, it appears really, really dark, but only if it is placed next to a block connected to the network.
What you expected to happen:
It should not be black.
Version (Make sure you are on the latest version before reporting):

Minecraft: 1.10.2
Forge: <IP_ADDRESS>5
Refined Storage:

Does this issue occur on a server? Yes, but it seems client side.
Here's an image:

Are you using optifine?

Yes, I am, is that the issue?
On Sun, Oct 23, 2016 at 1:58 PM, Raoul<EMAIL_ADDRESS>wrote:

Are you using optifine?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/raoulvdberge/refinedstorage/issues/503#issuecomment-255603359,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AI0624d71ez_wwFv5oosbt968fP6flICks5q26BegaJpZM4KeMh1
.

Yes

Please report this to them, and link them this class (it's responsible for the disk rendering):
https://github.com/raoulvdberge/refinedstorage/blob/mc1.10/src/main/java/com/raoulvdberge/refinedstorage/render/BakedModelDiskDrive.java

This may be related to https://github.com/sp614x/optifine/issues/298 and https://github.com/AppliedEnergistics/Applied-Energistics-2/issues/2489

@sp614x would moving this stuff to a FastTESR fix it?


Update Apple Pay Button to use PKPaymentButton

We were usin a custom button for Apple Pay but the branding has slightly changed and Apple offers a drop-in button with the updated styles.

this spacing:

Oops yeah!

@theginbin Fixed, thanks! The screens attached represent 10.2, but I'll look into getting another PR going with 10.3 screens.


server: make release() idempotent

It's going to make my reconnecting state machine (#42) easier if clients can issue a release() message without knowing for sure that the server hasn't seen one already. Should be a simple change.

Hm, internally, release_nameplate() is idempotent. It's just the websocket frontend API that is not, because in that API the client doesn't supply the nameplate id: it is implicit, established by a previous claim({nameplate:}) message.
So really I need to rethink the state machine.


fix(viz dist_bar): Preserve Column Order in Bar chart

SUMMARY
Reindex pivot table by using metric columns
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN
Create metrics with different name and re-order them, the column in bar chart should reflect those orders
ADDITIONAL INFORMATION

[x] Has associated issue: #12416
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

@adam-stasiak please help testing this one as well
@duynguyenhoang thanks for the PR!!

@adam-stasiak please help testing this one as well
@duynguyenhoang thanks for the PR!!

Codecov Report

Merging #12417 (ca1393a) into master (4cf3f99) will decrease coverage by 3.48%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master   #12417      +/-   ##
==========================================
- Coverage   66.79%   63.30%   -3.49%
==========================================
  Files        1014      485     -529
  Lines       49524    29886   -19638
  Branches     5077        0    -5077
==========================================
- Hits        33079    18920   -14159
+ Misses      16314    10966    -5348
+ Partials      131        0     -131

Flag
Coverage Δ

cypress
?

javascript
?

python
63.30% <50.00%> (-0.77%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/viz_sip38.py
0.00% <0.00%> (ø)

superset/viz.py
60.00% <100.00%> (+0.02%)
:arrow_up:

superset/sql_validators/postgres.py
50.00% <0.00%> (-50.00%)
:arrow_down:

superset/views/database/views.py
62.69% <0.00%> (-24.88%)
:arrow_down:

superset/db_engine_specs/mysql.py
79.59% <0.00%> (-12.25%)
:arrow_down:

superset/db_engine_specs/sqlite.py
65.62% <0.00%> (-9.38%)
:arrow_down:

superset/db_engine_specs/presto.py
73.37% <0.00%> (-8.66%)
:arrow_down:

superset/databases/commands/create.py
83.67% <0.00%> (-8.17%)
:arrow_down:

superset/databases/commands/update.py
85.71% <0.00%> (-8.17%)
:arrow_down:

superset/sql_validators/base.py
93.33% <0.00%> (-6.67%)
:arrow_down:

... and 550 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cf3f99...ca1393a. Read the comment docs.

Codecov Report

Merging #12417 (ca1393a) into master (4cf3f99) will decrease coverage by 3.48%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master   #12417      +/-   ##
==========================================
- Coverage   66.79%   63.30%   -3.49%
==========================================
  Files        1014      485     -529
  Lines       49524    29886   -19638
  Branches     5077        0    -5077
==========================================
- Hits        33079    18920   -14159
+ Misses      16314    10966    -5348
+ Partials      131        0     -131

Flag
Coverage Δ

cypress
?

javascript
?

python
63.30% <50.00%> (-0.77%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/viz_sip38.py
0.00% <0.00%> (ø)

superset/viz.py
60.00% <100.00%> (+0.02%)
:arrow_up:

superset/sql_validators/postgres.py
50.00% <0.00%> (-50.00%)
:arrow_down:

superset/views/database/views.py
62.69% <0.00%> (-24.88%)
:arrow_down:

superset/db_engine_specs/mysql.py
79.59% <0.00%> (-12.25%)
:arrow_down:

superset/db_engine_specs/sqlite.py
65.62% <0.00%> (-9.38%)
:arrow_down:

superset/db_engine_specs/presto.py
73.37% <0.00%> (-8.66%)
:arrow_down:

superset/databases/commands/create.py
83.67% <0.00%> (-8.17%)
:arrow_down:

superset/databases/commands/update.py
85.71% <0.00%> (-8.17%)
:arrow_down:

superset/sql_validators/base.py
93.33% <0.00%> (-6.67%)
:arrow_down:

... and 550 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cf3f99...ca1393a. Read the comment docs.

@villebro Update to f-strings and formated viz_test using black.

@villebro Update to f-strings and formated viz_test using black.

@junlincc @duynguyenhoang  it seems that this order is not respected in the time series bar chart. Is this expected behaviour?


Fix markdown hyperlink

@austinlparker I think this is g2g

Could you fix the merge conflict and then I can merge this? Thanks


feat(ui): prefill parameters for workflow submit form. Fixes #12124

Fixes #12124
Motivation
This PR  adds support for developers to prefil submit workflow form by passing in the values through query parameters.
To prefil a submit workflow developers can pass in the following query parameters
sidePanel=submit-new-workflow
template=<template that the workflow should follow>
parameters[key]=value // Here the key would be the parameter for the job and value would be the value of the parameter.
You should provide the keys that are supported by the specified template

Modifications

Updated workflow-list component
Updated submit-workflow-panel.tsx component to default entry point if provided.
Updated workflow-creator.tsx to read default values from query parameters.
The workflow will be prefilled with the parameters that the template supports
Added new shared helper function to parse query parameter of the format ?parameters[key]=value.

Verification

Good start! A couple initial comments:

This project uses the history library, so the useEffect() hooks need to incorporate it as a dependency. That means passing through the history object to the affected components. Ideally, we'd use useQueryParams() too, but when I tried that, the history.listen() callback wouldn't fire. I think that's due to the interdependency with the workflowTemplates/workflowParameters props.
It'd be simpler to push the logic for handling workflow parameters to ui/src/app/workflows/components/submit-workflow-panel.tsx

Here's a commit that does both things: https://github.com/MasonM/argo-workflows/commit/d2c11c87503c5054c9ce86d5a19918ed79f8cc24

@sairam91 Sorry for the delay. You mentioned you were going to fill out the "Verification" section of the PR, so I was waiting for that. If you're unsure of what to put there, I think this would work (you can copy-and-paste this):
Verification

Run make start UI=true
Visit http://<IP_ADDRESS>:8080/workflow-templates?namespace=argo and create a new WorkflowTemplate named with the default example

Visit http://<IP_ADDRESS>:8080/workflows?namespace=argo&sidePanel=submit-new-workflow&template=test&parameters[message]=test123 and verify fields are populated correctly

Also, it looks like there's conflicts. If you can add me as a collaborator at https://github.com/sairam91/argo-workflows/settings, I can resolve them for you, if you want.

Closed in favor of https://github.com/argoproj/argo-workflows/pull/13922


Improve article 2209.02976

Exact location of issue
Tables are scaled in a way that clashes with content, e.g.
https://ar5iv.labs.arxiv.org/html/2209.02976#S3.T16
Problem details
I believe another case where latexml preserves a transform suggested in the TeX source that doesn't really translate meaningfully to HTML.
It is interesting to wade into a larger discussion about what can be done better for such cases, but there is also an easy short-term CSS fix that simply ignores the transform - as has been done in some other issues, e.g. #37

Resolved in the latest CSS update.


feat: Elixir Bindings for PRQL

Bring PRQL to Elixir world ⚗

Added Elixir NIF bindings for PRQL 🔥
Added unit tests 🧪
Added doctests 📜
Docs are WIP 🚧

TODO:

[ ] Rustler precompiled
[ ] Automated Testing
[ ] Build Script
[ ] Hex.pm publication

@max-sixty I've written some tests in elixir, i will add them to the Taskfile.yml

@max-sixty I've written some tests in elixir, i will add them to the Taskfile.yml

As you say above, let's add some tests. We can model that on https://github.com/prql/prql/blob/main/.github/workflows/test-taskfile.yaml (there's no need to make a separate Action like in the other bindings, those are going away soon anyway ref https://github.com/PRQL/prql/issues/1424)

I think maybe my message was a bit unclear. I meant to make a file at .github/workflows/test-elixir.yaml, starting from the test-taskfile.yaml as an example.
Though we can consider adding those to the actual Taskfile.yml too; but the GitHub action will be the one that runs in CI.

@max-sixty I've written some tests in elixir, i will add them to the Taskfile.yml

As you say above, let's add some tests. We can model that on https://github.com/prql/prql/blob/main/.github/workflows/test-taskfile.yaml (there's no need to make a separate Action like in the other bindings, those are going away soon anyway ref #1424)

I think maybe my message was a bit unclear. I meant to make a file at .github/workflows/test-elixir.yaml, starting from the test-taskfile.yaml as an example.
Though we can consider adding those to the actual Taskfile.yml too; but the GitHub action will be the one that runs in CI.

Aha, got it. I will proceed with a new workflow

@max-sixty for releasing the package you may need to create an account here

Everything looks great! I added one small comment re the functions.
Can we add a summary of the current state to the Readme? i.e. that it currently requiring cloning this repo and following the instructions in the Rustler docs, including having a rust compiler, but we're planning to add precompilation etc?
Then we can hit the green button!

Everything looks great! I added one small comment re the functions.
Can we add a summary of the current state to the Readme? i.e. that it currently requiring cloning this repo and following the instructions in the Rustler docs, including having a rust compiler, but we're planning to add precompilation etc?
Then we can hit the green button!

Sure, i will add all the required information

@pre-commit autofix

pre-commit.ci autofix

@max-sixty can you give a final review :)

I made a couple of edits to the Readme — check them out
I'll merge and we can continue with the other items in future PRs!

We can also and an entry to the Changelog in a follow-up PR

Sure, lets add a changelog entry in a follow up pr

Done! Congratulations on getting this in @kasvith . I'm looking forward to seeing this develop!

Thanks for the support @max-sixty
This was my first NIF ⚗
Looking forward to working with you.


test_autograd.py freezing on shipped version of mxnet

Description
I decided to run the python tests against the statically linked version of mxnet, which is the one you get when you pip install mxnet. I found that the test tests/python/train/test_autograd.py is freezing.
Environment info (Required)
----------Python Info----------
Version      : 3.5.2
Compiler     : GCC 5.4.0 20160609
Build        : ('default', 'Nov 12 2018 13:43:14')
Arch         : ('64bit', 'ELF')
------------Pip Info-----------
Version      : 8.1.1
Directory    : /usr/lib/python3/dist-packages/pip
----------MXNet Info-----------
Version      : 1.3.1
Directory    : /usr/local/lib/python3.5/dist-packages/mxnet
Commit Hash   : 19c501680183237d52a862e6ae1dc4ddc296305b
----------System Info----------
Platform     : Linux-4.9.125-linuxkit-x86_64-with-Ubuntu-16.04-xenial
system       : Linux
node         : b0c78ebea9fe
release      : 4.9.125-linuxkit
version      : #1 SMP Fri Sep 7 08:20:28 UTC 2018
----------Hardware Info----------
machine      : x86_64
processor    : x86_64
Architecture:          x86_64
CPU op-mode(s):        32-bit, 64-bit
Byte Order:            Little Endian
CPU(s):                4
On-line CPU(s) list:   0-3
Thread(s) per core:    1
Core(s) per socket:    1
Socket(s):             4
Vendor ID:             GenuineIntel
CPU family:            6
Model:                 142
Model name:            Intel(R) Core(TM) i7-7660U CPU @ 2.50GHz
Stepping:              9
CPU MHz:               2500.000
BogoMIPS:              4874.08
Hypervisor vendor:     vertical
Virtualization type:   full
L1d cache:             32K
L1i cache:             32K
L2 cache:              256K
L3 cache:              4096K
Flags:                 fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht pbe syscall nx pdpe1gb lm constant_tsc rep_good nopl xtopology nonstop_tsc pni pclmulqdq dtes64 ds_cpl ssse3 sdbg fma cx16 xtpr pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch kaiser fsgsbase bmi1 hle avx2 bmi2 erms rtm xsaveopt arat
----------Network Test----------
Setting timeout: 10
Timing for Gluon Tutorial(cn): https://zh.gluon.ai, DNS: 0.0043 sec, LOAD: 0.7718 sec.
Timing for FashionMNIST: https://apache-mxnet.s3-accelerate.dualstack.amazonaws.com/gluon/dataset/fashion-mnist/train-labels-idx1-ubyte.gz, DNS: 0.0016 sec, LOAD: 2.1487 sec.
Timing for Gluon Tutorial(en): http://gluon.mxnet.io, DNS: 0.0026 sec, LOAD: 0.8662 sec.
Timing for PYPI: https://pypi.python.org/pypi/pip, DNS: 0.0605 sec, LOAD: 0.7541 sec.
Timing for MXNet: https://github.com/apache/incubator-mxnet, DNS: 0.0475 sec, LOAD: 0.5463 sec.
Timing for Conda: https://repo.continuum.io/pkgs/free/, DNS: 0.0018 sec, LOAD: 0.1092 sec.

Package used (Python/R/Scala/Julia):
pip3 install mxnet==1.5.0b20190212
Error Message:
No error message. Just freezes.
Minimum reproducible example
I've isolated the test in a docker container in which only python3, curl and the latest nightly mxnet cpu package from PyPI:
FROM ubuntu:16.04

RUN apt update && apt install -y curl python3-pip && pip3 install mxnet==1.5.0b20190212
RUN mkdir -p /mxnet && curl -L -o /mxnet/test_autograd.py https://raw.githubusercontent.com/apache/incubator-mxnet/master/tests/python/train/test_autograd.py

WORKDIR /mxnet

Steps to reproduce

copy the Dockefile above into a Dockerfile
docker build -t test .
docker run test python3 /mxnet/test_autograd.py

What have you tried to solve it?
Nothing. This is a little out of my wheelhouse. I will try to find the issue as time allows. But wanted to posted here in case someone with more experience in the code would also like to take a look. I'll update the issue if I find anything.

@perdasilva I couldn't reproduce:
python test_autograd.py
DEBUG:urllib3.connectionpool:Starting new HTTP connection (1): data.mxnet.io
DEBUG:urllib3.connectionpool:http://data.mxnet.io:80 "GET /mxnet/data/mnist.zip HTTP/1.1"<PHONE_NUMBER>0
INFO:root:downloaded http://data.mxnet.io/mxnet/data/mnist.zip into data/mnist.zip successfully
[21:09:37] src/io/iter_mnist.cc:110: MNISTIter: load 60000 images, shuffle=1, shape=(100,784)
[21:09:37] src/io/iter_mnist.cc:110: MNISTIter: load 10000 images, shuffle=1, shape=(100,784)
training acc at epoch 0: accuracy=0.901417
training acc at epoch 1: accuracy=0.964967
training acc at epoch 2: accuracy=0.976367
training acc at epoch 3: accuracy=0.982900
training acc at epoch 4: accuracy=0.987100

Note that this test downloads a file, is it possible that your environment prevents downloads?

Wow. That's very strange. Seems to be working for me now. Same machine, same internet connection, same docker image. But interestingly, it didn't fail on downloading the data. It would hang on the name, acc = metric.get() line, from memory.

Well - good to know it's not happing anymore.  I will close it.


How does this package resolve possible editing conflicts?

Hi, I am new to Atom and package development.
As I inspected the atom-pair's code, I found the core implementation is recording changes in Atom's callback function and then push change-event into queue. When some other clients receive the event, they just extract the data and apply using Atom's buffer.
I did not find the conflict resolving logic inside this package, is it possible that Atom resolve conflicts by itself?
Thanks.

Problem solved after I tested this package. Well, it seems this pakcage does not resolve editing conflicts produced by multiple uses, i.e. users who are editing the same file may get different file contents.

Well, I developed a package which uses ShareDB to support OT, it is now available as coeditor in atom.io, hope it can help someone who needs a collaborative editing package:)


Compiler: Auto-generate inspect methods for bitfields

Closes #373
Example:

Pull Request Test Coverage Report for Build 802716857

52 of 52 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 69.264%

Totals

Change from base Build 802383025:
0.03%

Covered Lines:
34246

Relevant Lines:
49443

💛  - Coveralls

Thanks!


Consolidate ServiceException & RemoteException

Provide ability to send safe parameters
Provide ability to safe-log parameters
First-class support for error name/type

API implementation: https://github.com/palantir/http-remoting-api/pull/9

fixed by https://github.com/palantir/http-remoting/pull/469


Bug: Eloquent Update affecting more than one row.

    $custid="C0001"
    $empid="E0001"
    $cemp = new EloquentModel1;
    $emp=$cemp->where('Cust_ID','=',$custid)
            ->where('Employee_ID','=',$empid)->first();

    $emp->fill(Input::all());
    $emp->update();

This update statement getting updated in two rows.
Table Data.
CustID Employee_ID        Address
C0001  E0001                   2
C0002  E0001                   1

What Laravel version?

What do you have set as the primary key?

Version : 5.0.14
protected $primaryKey='Employee_ID';
protected $foreignKey='Cust_ID';

Only Laravel 5.1 is supported.

Please upgrade to 5.1 and report if the bug is still present.


[feature] Category/tag template settings

Version and OS
For example, <IP_ADDRESS> on Debina11/docker
Is your feature request related to a problem? Please describe.
For example, in the Request Headers section, I need to monitor a lot of links on a particular website, all of which of course require cookies.
However now I need to go through the added links one by one, which is a pain.
Is it possible to set up a template for a specific category so that I don't have to go through all this trouble?
Describe the solution you'd like
Template function, for each category
Describe the use-case and give concrete real-world examples
https://files.catbox.moe/wm0or3.png
Additional context
Add any other context or screenshots about the feature request here.

it's possible if you provide a PR

This is something I'd make use of too. I use changedetection.io to monitor a postage tracking website, and I have to manually copy the CSS selectors from an existing rule every time I add another one. My first thought would be to add default filtering rules based on the hostname in the URL, but tags would work too. Especially if tags could be automatically added based on URL hostname at a later point.
I'm happy to have a look at implementing this. At a glance it would involve adding a dict to ChangeDetectionStore (tag_definitions? tag_definition_templates?), keyed with a tag name, with a dict value with many of the values in ChangeDetectionStore.generic_definition. When a tag is applied to a site, apply the corresponding fields if a matching entry is found in the dict.

related https://github.com/dgtlmoon/changedetection.io/pull/505

https://github.com/dgtlmoon/changedetection.io/pull/590

#641

resolved in https://github.com/dgtlmoon/changedetection.io/pull/1610


Pooling trasposed forward solvers and transposed solver core

This implements a universal transpose kernel as a stub. It is naive, straightforward, and slow, but theoretically transposes any valid stride configuration to any other. The universal transposing solver allows developers to override it or use different transpose kernels for different layout configurations.
The implementation makes several assumptions:

For OpenCL subbuffer alignment is assumed to be (0x400 / 8) * 2 bytes for safety margin when handle is unavailable (GWSS). AFAIK GPUs report 0x400 bits. I have decided to double that for a possible future rise of the value. The assumption is necessary due to API flaw described here: https://github.com/ROCmSoftwarePlatform/MIOpen/issues/1362#issuecomment-1002013287.
The same API flaw leads to an assumption that x and y have same layouts in GWSS. This may lead to insufficient workspace size for the transpose.

@DrizztDoUrden could you select a few labels so that reviewers can know its urgency level? The CI is close to pass, I had to restart a few times. Thanks!

Igemm got formatted by accident. I am not sure, why have my format script touched it, I thought, I have configured it to only touch files changed from baseline. I guess that is due to merges. I could revert that if you would rather see it in a separate PR.

I will revert unrelated formatting tomorrow.

wait, what did just happen in that last merge :/

Awsum, my local copy got messed up :/
Unlink of file '.git/objects/pack/pack-00921996ba0659457a17dd2a91054a5c8f0b7524.idx' failed
I guess, I'll have to fix it again.

Done


"Cannot set read-only computed value" exception if a computed property returns undefined

If a computed value returns undefined, ractive tries to update the computed value. To reproduce, see this fiddle:
https://jsfiddle.net/w3yk7j93/1/

Hello! Please add the necessary information in this issue (code, steps to reproduce, etc.), not just the jsfiddle. Should jsfiddle go down, this thread won't be. 😄

Missing information added

This was an issue with the mapping init logic not checking for a readonly source model. It has been fixed in edge and v0.8-dev and will go out with 0.8.12 when it is cut. Thanks for the report!


Add support to quiet ASCII table output

we are looking to use this in CI build, but would rather not have ascii tables extending the length of output when json will do perfectly

LGMT


Is this a grayscale map only? What do you have to do with a color map?

Hi,how to do get a color map?


Don't delete all of the bundler things

Context
Gems aren't available when we SSH onto a running instance.
Changes proposed in this pull request

Don't be quite so aggressive with the tidying up in the image

Guidance to review

Link to Trello card

Checklist

[ ] Attach to Trello card
[ ] Rebased main
[ ] Cleaned commit history
[ ] Tested by running locally

Closing as we have an alternative solution.


How to integrate with Vue

I want to integrate PlayCanvas into my own Vue project. How can I use it, and are there any relevant examples? The goal is to load and edit Gaussian models.

Does this help?
https://forum.playcanvas.com/t/playcanvas-and-vue-js/15560

Sorry @action9981 we're not Vue specialists.
It might be worth asking on their community.
If we can help with anything on Supersplat, please let us know!


[OpenStreetMap] OSM app always plots the currently select GPS Recorder track

Affected hardware version
Bangle 2
Your firmware version
2v12
The bug
This commit related to this issue introduced the feature for the OpenStreetMap app to plot the currently active GPS track on loading the OSM app.
The intention for this seems to have been so that while recording a track, you could see it update in real time on the OSM app, which I agree is a nice feature though perhaps it could be controlled in either the OSM app or GPS Recorder settings.
However, it also draws the currently selected track even when not recording, which means if a long track is selected, the app is unresponsive until the track finishes drawing.
With a track that has only 53 records, this isn't really an issue as the draw completes nearly instantly (aside from the track appearing when I don't specifically want it to), but on a longer track (77 mins, 927 records) this takes ~8 seconds, and the app is completely unresponsive until the draw completes, and it redraws on every move of the map.
I think the OpenStreetMap app either needs to just detect that the GPS recorder app is recording (currently it just checks WIDGETS["gpsrec"] && WIDGETS["gpsrec"].plotTrack, and the widget is always there with a plotTrack function even when not recording)

I guess the newer recorder app does not have this problem.

That is a point. It probably shouldn't be checking for gpsrec now anyway. I think this is probably functionality that users would appreciate (albeit for recorder), but yes, I guess it should be switchable

Candidate for being closed - leave a comment if you object!
Rationale:
Done with https://github.com/espruino/BangleApps/commit/eba77c8a9915180d1b822b04c292b7f68a4952fd.

Thanks!


Remove version: Jackett.Jackett version 0.20.3593

404 - release deleted
Microsoft Reviewers: Open in CodeFlow

URL: https://github.com/Jackett/Jackett/releases/download/v0.20.3593/Jackett.Installer.Windows.exe
Response Error: The remote server returned an error: (404) Not Found.
(Automated message - build 918)

URL: https://github.com/Jackett/Jackett/releases/download/v0.20.3593/Jackett.Installer.Windows.exe
Response Error: The remote server returned an error: (404) Not Found.
(Automated message - build 918)


[T6A3][T13-C1] Low Bao Ling Vivian

@sunset1215
Some comments added. Please ack & close the PR after reading comments.
you have a very good attempt at OCP! please keep up the good work :-)


initial take at opencensus opentracing implementation

Implementation allows users to provide external Logger implementation.  Tags and baggage will be published to logger, but will not interact with opencensus trace.

Yeah, I hadn't considered the API question very deeply when I filed #502.
I think having this bridge would be super useful to have as many libraries are already instrumented with OpenTracing.
Whether it lives here or in a the opentracing-contrib repo I don't really have a strong opinion. I guess we are already getting flak for the number of dependencies this repo is pulling in so that's another argument against adding contrib here.

I am suggesting to merge this to https://github.com/opentracing-contrib given we don't have a contrib organization at the moment.

@savaki if you have some time, would you mind moving this to a separate repo that we can then pull into the newly created census-ecosystem org?


Both prepend and append text as well as "middle" text

Renaming input-prepend and input-append to just input-text (or similar) and then changing add-on to three seperate classes.

add-prepend
add-append
add-middle.

add-prepend working in the same way as input-prepend + add-on would work, same for app-append. But also making add-middle work, without any rounded border.
The use case for me was that I wanted one prepend text then the input field followed by two append texts. One small "timer" text and one "handle" used to rearange my inputs.

I see this as less of a use case, but I'll keep it in mind if we ever revisit that component. (Alternatively, if you submit a pull request that preserves the current classes as well, we can see about pulling that in.)


Allow importing a new song while exploring tracks from a different song

Perhaps provide a list of recently loaded tracks?

Fixed in v1.1.0.


Sample for sending MULAW encoding base64 encoded audio stream

Hello Team,
I am trying to send base64 encoded audio stream (MULAW) to Azure Speech To Text Service and couldn't find any samples or references for doing the same in C# either using REST or SDK. Hope this should be doable in SDK as I saw the latest release note has support for MULAW encoded audio format. Trying to implement what mentioned here (nodejs) in C# , https://www.twilio.com/blog/live-transcribing-phone-calls-using-twilio-media-streams-and-google-speech-text
Context: I am trying stream twilio stream from phone. Seems Twilio supports and integrated with Google Speech To Text and Amazon lexa. Trying to implement a prototype for the same with Azure.
Twilio documentation : https://www.twilio.com/docs/voice/twiml/stream
"mediaFormat": {
"encoding": "audio/x-mulaw",
"sampleRate": 8000,
"channels": 1
}
You can find more details around their integration and details with AWS and Google here , https://www.twilio.com/blog/media-streams-public-beta
Thanks for your help!

@sowsan We have support for MULAW in wav container. Please look at the https://docs.microsoft.com/en-us/azure/cognitive-services/speech-service/how-to-use-codec-compressed-audio-input-streams for more information. Do let us know if this answers your question.

Thank you so much, @amitkumarshukla. Haven't seen that :)
It says we need the gstreamer to work with the encoding. I am going to integrate the SDK code with asp.net core api app. Currently its in my local machine running on windows 10. The documentation talks about installation using sudo, so want to double check does it work with windows? https://gstreamer.freedesktop.org/download/ ,  also is it possible to install it in a docker container ?
Another question, does Speech To Text SDK support GRPC or WebSocket connections from client to azure Speech To Text Service? If so, do I need to enable anything specific as configuration settings?

@sowsan The sample is shown with pull audio stream but it will work with push audio stream exactly the same way as it works for all the other scenario. please look at this sample https://github.com/Azure-Samples/cognitive-services-speech-sdk/tree/master/samples/cpp/linux/compressed-audio-input
Currently the compressed stream support is available only on Ubuntu, Android and iOS. We have not yet supported it on windows.
You can install gstreamer and recognize compressed stream on ubuntu docker container.
Speech to text sdk supports Websocket  connections (currently no GRPC). You need to follow the prerequisite from https://docs.microsoft.com/en-us/azure/cognitive-services/speech-service/quickstarts/setup-platform?pivots=programming-language-csharp&tabs=dotnet%2Clinux%2Cjre.
Do let me know if this answers your questions

Thanks again for the clarifications and answers, @amitkumarshukla . That helps.
I just want to clarify few more items, what is the diff between pullaudiostream vs pushaudiostream? I theink I am missing some basic concepts around that.
Thanks, I will set it up in docker. I have followed the prerequisites but didn't find any specific setting for WebSocket and I believe it's not needed and it works behind the scene, right?
Thanks again!

@sowsan Please look at the https://docs.microsoft.com/en-us/dotnet/api/microsoft.cognitiveservices.speech.audio.pullaudioinputstream?view=azure-dotnet and https://docs.microsoft.com/en-us/dotnet/api/microsoft.cognitiveservices.speech.audio.pushaudioinputstream?view=azure-dotnet
Please follow the following sample to see its usage.
https://github.com/Azure-Samples/cognitive-services-speech-sdk/blob/master/samples/csharp/sharedcontent/console/Program.cs for understand the different between the pullstream and push stream.
Please focus on the following
case ConsoleKey.D5:
SpeechRecognitionSamples.RecognitionWithPullAudioStreamAsync().Wait();
break;
case ConsoleKey.D6:
SpeechRecognitionSamples.RecognitionWithPushAudioStreamAsync().Wait();
Do let me know if this answers your question.

Closing the issue because no update since November, please re-open if still valid.

@sowsan We have support for MULAW in wav container. Please look at the https://docs.microsoft.com/en-us/azure/cognitive-services/speech-service/how-to-use-codec-compressed-audio-input-streams for more information. Do let us know if this answers your question.

Hi, is this not supported for python yet? If no, is there any work around?


Nested folders

I'm not sure if this is supported or not but I'd really love to have my nested folders show as nested.

Hmm ... we haven't planned this feature. I'll just keep this here as a reminder, so if there is interest, we'll gather it here.

this is good idea


Revive firrtl generation pass

@rdaly525

Notebook: https://gist.github.com/edwardcwang/d21f4be167f2c186c27426c7dd5b43fd

@leonardt @rdaly525 One important observation (which might be actually be a bug in Magma) - in the magmathon jupyter notebook, m.compile('build/add', main, output="firrtl") doesn't seem to work (generates the old invalid firrtl).
I have to set output to "coreir" and manually run coreir -i build/add.json -o build/add.fir to get the kind of valid firrtl that this PR generates.
I also tried restarting the Jupyter notebook to no avail.

Resolved: apparently the magma firrtl emitter is different from the coreir firrtl emitter.


Add default example environment file

This PR adds an example environment file which is copied to .env file on Composer project installation.
This is especially useful when you want to start with a  dockerized local development environment.
It avoid calling the php artisan winter:env command after a fresh installation which adds unnecessary double quotes and make Laravel Sail installation incompatible.
See: https://github.com/laravel/sail/blob/1.x/src/Console/Concerns/InteractsWithDockerComposeServices.php#L118
I'm currently working on a serverless function that generates a bash script to install WinterCMS with Laravel Sail (like Laravel does : https://laravel.com/docs/10.x/installation#laravel-and-docker).
The aim is to set up a standardized dockerized environment quickly and without dependencies (except for Docker).

Arguably a PR could be made to Sail to use our Config Writer package to edit those .env files in a safer and more robust way 😉

Arguably a PR could be made to Sail to use our Config Writer package to edit those .env files in a safer and more robust way 😉

That's an exellent idea ! I will made the PR this weekend 😉


support new ASSERTMSG opcode

Summary or solution description
Added the ASSERTMSG Opcode on Neo3-boa.
How to Reproduce & Tests
It's not possible to run or test the Opcode yet, because the Neo version with this Opcode was not released yet.
Platform:

OS: Windows 10 x64
Python version: Python 3.7

Task linked: CU-8678fumvy support new ASSERTMSG opcode

coverage: 91.799% (-0.1%) from 91.918% when pulling f8589adb57731078a20a241ea1be8f8d844f22b7 on CU-8678fumvy into c4612d41c3e76f5c8f56c1309fa4c1fb8f24568a on development.

coverage: 91.799% (-0.1%) from 91.918% when pulling f8589adb57731078a20a241ea1be8f8d844f22b7 on CU-8678fumvy into c4612d41c3e76f5c8f56c1309fa4c1fb8f24568a on development.


Differentiate between sub-flow and connector nodes

When connectors are registered as known, they are rendered same as sub-flow.
Here is an example of rendering object store component -

One alternative is, to use component style to render registered connectors. For example -

Possibly, the path registered can also be displayed, like on the sources.

I like the compent-style rendering as it set's it apart more from the other container types.  Not sure if the path would be necessary but just calling it out would be helpful.


Name, params and query as props

It would be awesome if instead of writing this:
<router-link :to="{ name: 'foo' }">bar</router-link>

... we could write something like that:
<router-link name="foo">bar</router-link>

The same rule would apply for the params object:
<router-link name="foo" :params="{ bar: 123 }">bar</router-link>

It's cleaner, shorter and more understandable. What do you think? If you want to reject this idea, could you provide an easy way to extend the router-link so these changes could be made?

I feel this is somewhat subjective - personally I like the object format to because it is consistent with the argument format for router.push(). The props format introduces a different way of doing things but imo not significant value.
As requested, this is how you can extend router-link to achieve what you want:
Vue.use(VueRouter)

// retrive router-link
const Link = Vue.component('router-link')

// overwrite it with your wrapper component
Vue.component('router-link', {
  props: Object.assign({}, Link.props, {
    // your extra props
    path: String,
    name: String,
    params: Object,
    query: Object,
    hash: String
  }),
  render (h) {
    const to = this.to || {
      path: this.path,
      name: this.name,
      params: this.params,
      query: this.query,
      hash: this.hash
    }

    return h(Link, {
      props: Object.assign({}, this.$options.propsData, { to })
    }, this.$slots.default)
  }
})


There are some Inf values in depth_dis/xxx.npy

How to process Inf values in depth_dis/xxx.npy?

Sorry for the late reply. You can set the inf area to be inpainted. In addition, this version of our model uses disparity as input. We have trained a better model that uses metric depth as input to avoid the 'inf' problem. It is expected to be released in about a month.


github-contribs is broken

github-contribs's tests turned red yesterday, because the unofficial interface to discover pull-requests seems to have changed.
So the last time we know for sure that the interface hadn't changed yet is October 10th 9:38AM UTC.
We need to:

fix github-contribs and pin the latest version here in ghuser,
re-crawl the recent days of all users,
re-crawl completely all users created since October 10th 9:38AM UTC.

We don't know how to properly set the header to be able to get these bigger HTML parts. Plus the structure of these bigger HTML parts are very likely to change.
So we will use the graphql api to get the list of all pull requests.

I got the big HTML parsing working. Not the best solution but this unblocks us for the short-term. Updated todo-list:

[x] fix github-contribs,
[ ] pin the latest version here in ghuser,
[ ] re-crawl the recent days of all users,
[ ] re-crawl completely all users created since October 10th 9:38AM UTC.


WIP: IANA Character Set Names.

This is a draft PR for an upcoming Foundation Evolution proposal.
Context: https://forums.swift.org/t/swift-foundation-now-available/73530/26

@swift-ci Please test

Did you mean to propose these additions as an API? If so, the first step would be posting a pitch on the forum according to the evolution process

This is the pitch right? https://forums.swift.org/t/pitch-foundation-iana-character-set-names/74623

This is the pitch right? https://forums.swift.org/t/pitch-foundation-iana-character-set-names/74623

Yes, that' it.
I'm sorry for forgetting to add the link.


[WIP] feat: add autofocus logic to the engine

This PR adds to the MDAEngine the logic to control any Micromanager Autofocus device (e.g. Nikon PFS).
Linked to https://github.com/pymmcore-plus/useq-schema/pull/91.
(test will fail until useq-schema PR is merged)

closing because I think #204 is preferred now?


continuous-delivery job failed

Hello I am having this issue while deploying this theme on github pages

It will be helpful if you are willing to post your _config.yml file

I am facing this new error

Here is the config
config.txt

See #418


Problem with handling implied packing in Proto3

Version of protoc (protoc --version)
3.0
Version of ProtocolBuffers.framework
3.0.0
.proto file to reproduce
syntax = "proto3";
package Test;

enum Instructions
{
    InstructionA = 0;
    InstructionB  = 1;
    InstructionC  = 2;
}

message Value
{
	bool   b = 1;
}

message Expression
{
    repeated Instructions code	= 1;
	repeated Value data			= 2 [packed=false];
}

Description
My understanding is that in Protobuf v3, packing is turned on by default. However, the Protobuf docs also add this bit of complication:

Protocol buffer parsers must be able to parse repeated fields that were compiled as packed as if they were not packed, and vice versa.

So, the above sample protobuf file is derived from a client project I'm working on. The Expression message contains a repeated Instructions enum, and a repeated Value message. The Value message is not relevant to this problem except to point out that in my client's protobuf definition they leave "packed=true" off the Instructions part because packing is implied in Protobuf v3, and therefore they explicitly say "packed=false" on the value part because for some reason they don't want the repeated values to be packed.
When I compiled this .proto file to Swift, it generates code which apparently assumes a "packed=false" behaviour for the repeated Instructions enum. This is a problem because the client's server is packing the repeated Instructions enum.
When I compile this .proto to Go and run the sample program, I can see that Go packs the Instructions by default.
package main

import "log"
import proto "github.com/golang/protobuf/proto"
import pb "Test"

func main() {
	expr := &pb.Expression{Code: []pb.Instructions{pb.Instructions_InstructionA, pb.Instructions_InstructionB}}
	data, _ := proto.Marshal(expr)
	log.Printf("Go: %x\n", data)
}

It produces the following output:
Go: 0a020001
So, the leading byte is 10, indicating the beginning of the packing.
When I look at the Swift code generated, I see this section:
      override public func mergeFrom(codedInputStream: CodedInputStream, extensionRegistry:ExtensionRegistry) throws -> Test.Expression.Builder {
        let unknownFieldsBuilder:UnknownFieldSet.Builder = try UnknownFieldSet.builderWithUnknownFields(copyFrom:self.unknownFields)
        while (true) {
          let protobufTag = try codedInputStream.readTag()
          switch protobufTag {
          case 0:
            self.unknownFields = try unknownFieldsBuilder.build()
            return self

          case 8:
            let valueIntcode = try codedInputStream.readEnum()
            if let enumscode = Test.Instructions(rawValue:valueIntcode) {
                 builderResult.code.append(enumscode)
            } else {
                 _ = try unknownFieldsBuilder.mergeVarintField(fieldNumber: 1, value:Int64(valueIntcode))
            }

Note the case 8: instead of the expected case 10.
If I modify the .proto file to force packing on for the repeated Instructions enum...
syntax = "proto3";
package Test;

enum Instructions
{
    InstructionA = 0;
    InstructionB  = 1;
    InstructionC  = 2;
}

message Value
{
	bool   b = 1;
}

message Expression
{
    repeated Instructions code	= 1 [packed=true];
	repeated Value data			= 2 [packed=false];
}

... then the code is generated properly with a case 10: in the switch statement and code to handle the packing:
      override public func mergeFrom(codedInputStream: CodedInputStream, extensionRegistry:ExtensionRegistry) throws -> Test.Expression.Builder {
        let unknownFieldsBuilder:UnknownFieldSet.Builder = try UnknownFieldSet.builderWithUnknownFields(copyFrom:self.unknownFields)
        while (true) {
          let protobufTag = try codedInputStream.readTag()
          switch protobufTag {
          case 0:
            self.unknownFields = try unknownFieldsBuilder.build()
            return self

          case 10:
            let length = Int(try codedInputStream.readRawVarint32())
            let oldLimit = try codedInputStream.pushLimit(byteLimit: length)
            while codedInputStream.bytesUntilLimit() > 0 {
            let valueIntcode = try codedInputStream.readEnum()
            if let enumscode = Test.Instructions(rawValue:valueIntcode) {
                 builderResult.code.append(enumscode)
            } else {
                 _ = try unknownFieldsBuilder.mergeVarintField(fieldNumber: 1, value:Int64(valueIntcode))
            }
            }
            codedInputStream.popLimit(oldLimit: oldLimit)

So, my problem is that my client's server is treating the Protobuf v3 files as if packing is implied on eligible (primitive type) repeating items, but protobuf-swift is treating it as if packing is implied off and generating code that breaks when it encounters the packed data, interpreting it as unrecognized bytes.
IMHO the bug here is that protobuf-swift needs to assume packed=true when processing repeated primitive types in Protobuf v3 files.
Coming back to Google's statement...

Protocol buffer parsers must be able to parse repeated fields that were compiled as packed as if they were not packed, and vice versa.

... it would seem that having to respect this statement in the docs this would seriously complicate the code generator, as it would have to detect and handle both scenarios regardless of whether packing is explicitly declared as on or off. I'd be happy if protobuf-swift simply assumed packed=true where applicable when processing Protobuf v3 files.

Thank you for responding to this so quickly.
Does this need to be merged back to the ProtoBuf3.0-Swift3.0 branch?

No, you can use master branch.


heap-buffer-overflow when using nlohmann/json, ASAN, and gtest

What is the issue you have?

I'll preface this by saying that I've also created an issue on the googletest repo. I'm not sure what the root cause of the issue is and so I figured I'd also create an issue here, in case you can shed some light.
I have a project uses CMake to build a library, FooBug, and a tests executable, which uses of googletest.
There appears to be an issue with an interaction between:

making use of nlohmann/json, specifically creating a nlohmann::json object
and then trying to extract the value using the get<std::vector<int>>()
syntax, for example:
json ints = json{1, 2, 3};
std::vector<int> ints_vec = ints.get<std::vector<int>>();

compiling the tests executable, which links gtest_main with the following
ASAN-related flag: -fsanitize=address

defining at least 5 tests

At the linking stage I get a heap-buffer-overflow reported by ASAN.

Path: '/Users/ham/Desktop/cpp/build/tests'
Result: Child aborted
Output:

make[2]: *** [tests] Error 1
make[2]: *** Deleting file `tests'
make[1]: *** [CMakeFiles/tests.dir/all] Error 2
make: *** [all] Error 2

Please describe the steps to reproduce the issue. Can you provide a small but working code example?

I've created a repo that reproduces the issue.
The relevant code is in FooTest.cpp:
#include "gtest/gtest.h"
#include <nlohmann/json.hpp>
#include "../include/foobar.hpp"
#include <vector>

using nlohmann::json;

class FooTests : public ::testing::Test {};

TEST_F(FooTests, Foo1) {
  ASSERT_EQ(foobar::add(1, 2), 3);

  // Everything is fine if you use a vector of doubles.
  json doubles_json = {1.1, 2.2, 3.3};
  std::vector<double> fetched_doubles = doubles_json.get<std::vector<double>>();

  // But you get the heap buffer overflow when using a vector of ints
  json ints_json = {1, 2, 3};

  // If you uncomment the line below then the buffer overflow won't occur
  std::vector<int> fetched_ints = ints_json.get<std::vector<int>>();
}

TEST_F(FooTests, Foo2) {}
TEST_F(FooTests, Foo3) {}
TEST_F(FooTests, Foo4) {}

// If you uncomment the line below then the buffer overflow won't occur
TEST_F(FooTests, Foo5) {}

What is the expected behavior?

I can compile and link the executable and run it successfully without a heap-buffer-overflow.

And what is the actual behavior instead?

A heap-buffer-overflow reported by ASAN.

Which compiler and operating system are you using? Is it a supported compiler?

AppleClang <IP_ADDRESS>30032
macOS 10.15.4 (19E287)

Did you use a released version of the library or the version from the develop branch?

The version with tag v3.7.3 from the fetchcontent fork/mirror repo
The same issue occurs with the latest commit on develop though.

If you experience a compilation error: can you compile and run the unit tests?

N/A

Hm. This seems unrelated to the library. At least the stack trace does not contain library code.

I think you're correct. I find it strange that it seems to be (at least in part) specifically tied to the get<std::vector<int>>() call from this library. The trace points to this line in the googletest repo:
https://github.com/google/googletest/blob/48bf552cbf014daf9149f8ee38b49e171ba4208f/googletest/src/gtest.cc#L2992
And you can see the definition of test_indices_ here: https://github.com/google/googletest/blob/48bf552cbf014daf9149f8ee38b49e171ba4208f/googletest/include/gtest/gtest.h#L1025-L1028
If I'm being honest that's all I really have to go on in terms of anything related to the issue pointing to this library.
Thanks for taking a look anyway, and feel free to close this if you feel confident that it's not something in this library that could be the root cause.

I'm not using Google Test myself, so I am not that familiar in setting up everything. Would be interesting to step through the code.

Just in case you are interested in stepping through the code then the repo I created that reproduces the issue is self-contained. You can get it up and running and reproduce with the following:
git clone https://github.com/hamchapman/googletest-json-asan-issue.git && cd googletest-json-asan-issue && mkdir -p build && cd build && cmake .. && make -j8 && ./tests

I think I've isolated this down to the line that's causing the issue for me.
If I comment out this line in the single include json.hpp file then I no longer get a buffer overflow:
https://github.com/nlohmann/json/blob/bcf4f3ce9a4ab1f31829bfa9446cbeaaeb644e42/single_include/nlohmann/json.hpp#L3404
I really don't understand why that's problematic, especially seeing as if I comment out that line and instead print out j.size() then it prints out 3, as I'd expect.
If you've got any ideas as to what might be going on that would be great!

I now believe this to be an ASAN bug and have therefore created an issue there: https://github.com/google/sanitizers/issues/1251
Feel free to close this if you're happy with that theory!

Update: It was a known false positive that can occur if not compiling everything (in my case gtest wasn't) with the -fsanitize=address flag.
https://github.com/google/sanitizers/issues/1251
Sorry for the noise and thanks for the library 😊

Thanks for checking back! And deep down in my memory, I think I also had that problem once, but totally forgot about it. Good that this could be closed!


Add bem selector-class-pattern stylelint rule

@juantxokupul Sweet, can we add a test for something like:
```.block__elementSomething````
Which I've seen in many places. See what happens, or what do we think should happen.
Thank you

Following contribution guidelines, please fill an issue and link to this PR. This way we can track and discuss this change.

In my opinion, we shouldn't force a naming convention. This project is open source and hence potentially it can be used by anyone and not only by Netcentric. And as much as at Netcentric we love BEM, we cannot force it to any developer that wants to use this stylelint configuration.

@raohmaru developers can always overwrite this rule in their stylelint.config (which they'll need anyway to add the extend rule with our package)
Considering this should be one of the standard packages we use for all our new projects, having to copy and paste this long regex every time to follow the NC Code Style seems overkill. Seems more optimal to have it here in the package and remove it in the few cases where it's not wanted.

I liked it when it was a 1 liner in the config.
I'm not a fan of adding a new dependency, which can not be taken out via config when someone includes this package.

Issue created by @prototowb, thank you!
@raohmaru  This PR was created since kebab-case was the default class naming convention, and we thought that bem would be better.
I think this repository is intended to establish some default configs. As @quicoto says, you can always override.
@quicoto yes, I also don't like to add a dependency, but you need a css post-processor to support scss nested selectors.

I'm retracting my enthusiasm with this change. I don't think we should go forward with it.

NOTE: you can take out this config setting the rule to null
"plugin/selector-bem-pattern": null

PR updated
I realised that stylelint is already a post processor and the only thing needed was to set resolveNestedSelectors option to true
The only advantage I see with the plugin, is that you can apply bem naming convention only in certain css files/sections

@juantxokupul Sweet, can we add a test for something like:
.block__elementSomething

Which I've seen in many places. See what happens, or what do we think should happen.
Thank you

this is allowed and I think it should
I searched in NC wiki and found this https://projects.netcentric.biz/wiki/pages/viewpage.action?spaceKey=~natalia.venditto&title=Code+Style+-+CSS+Guidelines#CodeStyleCSSGuidelines-Namingrules
The page it's under 'Archive OLD' itself but seems like a good reference to me

@quicoto thank you!
Fortunately, it seems the 6. Classes (.name) section is a copy/paste from the old :)


Improve evaluation of expectation value for PauliSumOp (PauliSumOp 3/3)

Summary
This Pull Request is a 3rd part of the issue:
https://github.com/Qiskit/qiskit-aqua/issues/1427
The option grouping_type in PauliSumOp is only "TPB" now. I will add the grouping by entangled basis in the future (grouping by entangled measurement PR).
Resolves #5625

It seems, if I understand correctly, that the GroupedPauliSumOp is a set of Paulis, from as original PauliSumOp, that can be measure d as a set at once. The original PauliSumOp being converted to a List (SummedOp) of GroupPauliSumOps. The grouping_type that was added by that subtype seems to be used nowhere. The grouping itself being done externally in the abelian grouper. I have to wonder what this subclass is bringing. Is the only difference from a PauliSumOp the understanding that all the paulis in the GroupedPauliSumOp can be measured at once as group (versus individually) - if so could we not simply have a flag in the PauliSumOp to that effect? Even if you want to gave the same thing, i.e grouping type which could be None by default and set to some value if all Paulis can be measured in one go. The TPB etc could still be used though at present that information does not seem to be used from the class,

It seems, if I understand correctly, that the GroupedPauliSumOp is a set of Paulis, from as original PauliSumOp, that can be measure d as a set at once. The original PauliSumOp being converted to a List (SummedOp) of GroupPauliSumOps. The grouping_type that was added by that subtype seems to be used nowhere. The grouping itself being done externally in the abelian grouper. I have to wonder what this subclass is bringing. Is the only difference from a PauliSumOp the understanding that all the paulis in the GroupedPauliSumOp can be measured at once as group (versus individually) - if so could we not simply have a flag in the PauliSumOp to that effect? Even if you want to gave the same thing, i.e grouping type which could be None by default and set to some value if all Paulis can be measured in one go. The TPB etc could still be used though at present that information does not seem to be used from the class,

@woodsp-ibm Thank you. You are right. I was wondering which would be better when implementing this. If using flag, we need to override __new__ due to the hack of PrimitiveOp. https://github.com/Qiskit/qiskit-terra/pull/5623/commits/de2f0a9a23ef34738a550598b8978082482034f1#diff-7451487da776f4e8e4738bc39d578bc69c52b7314e40364df2532428c2e95ce6R36-R39.

@woodsp-ibm Thank you. You are right. I was wondering which would be better when implementing this. If using flag, we need to override __new__ due to the hack of PrimitiveOp. https://github.com/Qiskit/qiskit-terra/pull/5623/commits/de2f0a9a23ef34738a550598b8978082482034f1#diff-7451487da776f4e8e4738bc39d578bc69c52b7314e40364df2532428c2e95ce6R36-R39.

I have finished the implementation of this PR.
Could you review my code please, @t-imamichi.
Since this PR is included in Add PauliSumOp, I don't think a release note is necessary for this PR. Is this correct?

I have finished the implementation of this PR.
Could you review my code please, @t-imamichi.
Since this PR is included in Add PauliSumOp, I don't think a release note is necessary for this PR. Is this correct?