HLS Live video not working

Tried with HLS Live video feed: got, I guess I-Frame as still image & audio playback on background.
Any plans to have HLS support for this?

The way it can display videos is by seeking frame by frame, but that doesn't work on streaming videos. When you have time to post a demo I'll see if there's any alternative way to have the (video> update.

Update: the video I tested with had broken seeking capabilities which caused obviously playback issues.
Now, with seek supported video, it simply has low FPS, few frames per second.
Hopefully I will be able to provide demo videos soon.

I should probably outline that the fps of the video is limited by the fps of the page. That means that if you're running expensive calculations or other animations, the framerate could drop below 60fps or even the 25/30fps necessary for the video. This applies to all situations. I can only update the video as often as the browser calls requestAnimationFrame

Hi, I have tested your player with this HLS live stream:
http://vevoplaylist-live.hls.adaptive.level3.net/vevo/ch1/appleman.m3u8
Have same issues as @wieshka. Audio stream is playing perfect, but video has very bad fps (about 1/2fps).
requestAnimationFrame calls ~60 times per second.
I also tried to limit it to 25fps by rewriting requestAnimationFrame method but it didn't help.
window.requestAnimationFrame = (function(){
	return function( callback ){
		window.setTimeout(callback, 1000 / 25);
	};
})();

I also noticed that player continues updating frames for few seconds after I press pause button.

I haven't had time to test this and something tells me that there isn't much I can do.
About your last your last line, can you try the latest version? If that doesn't fix it, would you mind opening a new issue with more details and perhaps a link to the page with the issue?

Anyone make any progress on this? I need it to get http://www.sprawly.co working properly methinks.

in IOS 10 you can just add playsinline parameter to  tag and it will not switch to full-screen anymore

Sure, but for everything else?
On Thu, Aug 25, 2016, 1:41 PM Oleg<EMAIL_ADDRESS>wrote:

in IOS 10 you can just add playsinline parameter to tag and it will not
switch to full-screen anymore
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/bfred-it/iphone-inline-video/issues/4#issuecomment-242532766,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA1dO2Bu8SPMz8CwY1dEj1hKSR6GkAqdks5qjf4FgaJpZM4H9-yi
.

No progress, unfortunately. Live video doesn't quite lend itself to this workaround


VIP 631

Adds XML and CSV spec files and related resources.
I've sort of punted on the question of whether to clone everything into separate 6.0 folders: I've made a new 6-0 folder for the CSV test resources that are referenced by the CSV spec (v6_0.clj). The folder only contains the new/modified types, because presumably we won't need to duplicate all the tests.

Closing this - we'll revisit this another way in future


undefined method `strip' for nil (NoMethodError)

lib/judges/options.rb:54:in `block in method_missing': undefined method `strip' for nil (NoMethodError)

        k = p[0].strip
                ^^^^^^
	from /usr/local/bundle/gems/judges-0.0.14/lib/judges/options.rb:52:in `to_h'
	from /usr/local/bundle/gems/judges-0.0.14/lib/judges/options.rb:52:in `method_missing'
	from /usr/local/bundle/gems/judges-0.0.14/lib/judges/options.rb:38:in `to_s'
	from /usr/local/bundle/gems/judges-0.0.14/lib/judges/commands/update.rb:53:in `run'
	from /usr/local/bundle/gems/judges-0.0.14/bin/judges:60:in `block (2 levels) in <top (required)>'
	from /usr/local/bundle/gems/gli-2.21.1/lib/gli/command_support.rb:131:in `execute'
	from /usr/local/bundle/gems/gli-2.21.1/lib/gli/app_support.rb:298:in `block in call_command'
	from /usr/local/bundle/gems/gli-2.21.1/lib/gli/app_support.rb:311:in `call_command'
	from /usr/local/bundle/gems/gli-2.21.1/lib/gli/app_support.rb:85:in `run'
	from /usr/local/bundle/gems/judges-0.0.14/bin/judges:91:in `<top (required)>'
	from /usr/local/bundle/bin/judges:25:in `load'
	from /usr/local/bundle/bin/judges:25:in `<main>'

@rultor release, tag is 0.0.15

@rultor release, tag is 0.0.15

@yegor256 OK, I will release it now. Please check the progress here

@rultor release, tag is 0.0.15

@yegor256 Done! FYI, the full log is here (took me 8min)


assert.false is not a function

Getting this error while running tests:
not ok 106 Chrome 90.0 - [10868 ms] - ember-cli-memory-leak-detector: detect memory leaks
    ---
        actual: >
            null
        stack: >
            TypeError: assert.false is not a function
                at Object.QUnit.test.Object.assign.validTest (http://localhost:7357/353903426377/tests/index.html?hidepassed:242:27)
        message: >
            Promise rejected during "detect memory leaks": assert.false is not a function
        negative: >
            false

Later on I see that it did seem to correctly identify which of my classes were still on the heap.
Link to CI run and PR:
https://github.com/datafruits/datafruits/pull/687/checks?check_run_id=2717081647

Can you confirm which version of qunit you are using? Qunit's assert.false was added in Qunit version 12.11


Auto-delete text

When the user taps on the top and bottom textfields, the text in there should auto-delete

Taking this, along with #9


Removed check to assert position of abbreviated timezone (e.g. EDT) at the end of the string.

I ran into this scenario while working with dates on usnews.com.
Previously,
In [1]: from dateparser import parse
pars
In [2]: parse('Wed Aug 05 12:00:00 EDT 2015')

In [3]: parse('Wed Aug 05 12:00:00 2015 EDT')
Out[3]: datetime.datetime(2015, 8, 5, 21, 0)

After the changes,
In [1]: from dateparser import parse

In [2]: parse('Wed Aug 05 12:00:00 2015 EDT')
Out[2]: datetime.datetime(2015, 8, 5, 21, 0)

In [3]: parse('Wed Aug 05 12:00:00 EDT 2015')
Out[3]: datetime.datetime(2015, 8, 5, 21, 0)

First, you should also add tests to test_timezone_parser.py as you are making changes in timezones.
Second: Wed Aug 05 12:00:00 EDTERR 2015.

Thank you @Allactaga! Please review changes again.

@Allactaga any comments?

@waqasshabbir on what in particular?

@Allactaga on using a function to strip braces off the date string.

I don't have any counter-examples in my head in the moment. So we can use it and open an issue if this would intervene with some languages or date form. One thing is I'd put call to it in DateParser.parse itself and not pop_tz_offset_from_string because AFAIU it's dateutil itself not working very good with brackets and not our timezone module.


Remove equivalence to a union class from Artifact definition and possibly revise entire definition

When a class is defined as the union of a set of other classes, it is not possible to define additional subclasses. Is this by intention? It makes extension difficult.
For example:
	<owl:Class rdf:about="&gist;Artifact">
		<rdfs:label rdf:datatype="&xs;string">Artifact</rdfs:label>
		<rdfs:comment rdf:datatype="&xs;string">An intentional person made thing, could be physical or content</rdfs:comment>
		<owl:intersectionOf rdf:parseType="Collection">
			<owl:Class>
				<owl:unionOf rdf:parseType="Collection">
					<rdf:Description rdf:about="&gist;Content">
					</rdf:Description>
					<rdf:Description rdf:about="&gist;IntellectualProperty">
					</rdf:Description>
					<rdf:Description rdf:about="&gist;Equipment">
					</rdf:Description>
					<rdf:Description rdf:about="&gist;Building">
					</rdf:Description>
					<rdf:Description rdf:about="&gist;PhysicalSubstance">
					</rdf:Description>
				</owl:unionOf>
			</owl:Class>
			<owl:Restriction>
				<owl:onProperty rdf:resource="&gist;goal"/>
				<owl:someValuesFrom rdf:resource="&gist;Function"/>
			</owl:Restriction>
		</owl:intersectionOf>
	</owl:Class>

Because this is a closed list, an ontology importing gist cannot define another direct subclass of Artifact.
In fact, we see already this problem within gist itself. System is a subclass of Artifact, but it is not asserted to subclass any of the unioned classes. Do we really want to say that System is a direct subclass of one of these, but we don't know which? Seems odd. And none of the unioned classes seem like appropriate superclasses of System.

For most practical purposes you are right. But technically, this pattern does not prevent further sub-classing. Its fine, so long as any further subclasses are fully a subset of the union. This pattern arises in a number of places in gist. It mainly results from the author’s preference for equivalence definitions over being certain that what is being stated is necessarily true.  The idea is, if it turns out to be false, the definition can change at that time. I am not a fan of this approach.
From: Rebecca Younes<EMAIL_ADDRESS>Sent: Friday, 20 September, 2019 07:25
To: semanticarts/gist<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: [semanticarts/gist] gist union constrains prevent further subclassing (#110)
When a class is defined as the union of a set of other classes, it is not possible to define additional subclasses. Is this by intention? It makes extension difficult.
For example:
    <owl:Class rdf:about="&gist;Artifact">

           <rdfs:label rdf:datatype="&xs;string">Artifact</rdfs:label>

           <rdfs:comment rdf:datatype="&xs;string">An intentional person made thing, could be physical or content</rdfs:comment>

           <owl:intersectionOf rdf:parseType="Collection">

                   <owl:Class>

                           <owl:unionOf rdf:parseType="Collection">

                                   <rdf:Description rdf:about="&gist;Content">

                                   </rdf:Description>

                                   <rdf:Description rdf:about="&gist;IntellectualProperty">

                                   </rdf:Description>

                                   <rdf:Description rdf:about="&gist;Equipment">

                                   </rdf:Description>

                                   <rdf:Description rdf:about="&gist;Building">

                                   </rdf:Description>

                                   <rdf:Description rdf:about="&gist;PhysicalSubstance">

                                   </rdf:Description>

                           </owl:unionOf>

                   </owl:Class>

                   <owl:Restriction>

                           <owl:onProperty rdf:resource="&gist;goal"/>

                           <owl:someValuesFrom rdf:resource="&gist;Function"/>

                   </owl:Restriction>

           </owl:intersectionOf>

    </owl:Class>

Because this is a closed list, an ontology importing gist cannot define another direct subclass of Artifact.
In fact, we see this problem within gist itself. System is a subclass of Artifact, but it is not asserted to subclass any of the unioned classes. Do we really want to rely on the open world assumption within the ontology, and say that System is a direct subclass of one of these, but we don't know which? Seems odd.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/semanticarts/gist/issues/110?email_source=notifications&email_token=ACSHHSI3OOUZUJU2Y5EBW3LQKTML7A5CNFSM4IYXW2Z2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HMWGI7Q, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ACSHHSJFXFENYJM6DU6WCE3QKTML7ANCNFSM4IYXW2ZQ.

I should have been more explicit: you cannot do this without creating bad inferences unless the new subclass is properly contained in the union; that is, if I want to define a new top-level subclass of Artifact that is disjoint from the others.
Because the ontology is publicly available, it doesn't help to say that we'll change the definition later if we find another subclass. A user may want to add a subclass and does not have the freedom to modify gist itself.

I agree
From: Rebecca Younes<EMAIL_ADDRESS>Sent: Saturday, 21 September, 2019 05:22
To: semanticarts/gist<EMAIL_ADDRESS>Cc: Michael Uschold<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [semanticarts/gist] gist union constraints prevent further subclassing (#110)
I should have been more explicit: you cannot do this without creating bad inferences unless the new subclass is properly contained in the union; that is, if I want to define a new top-level subclass of Artifact that is disjoint from the others.
Because the ontology is publicly available, it doesn't help to say that we'll change the definition later if we find another subclass. A user may want to add a subclass and does not have the freedom to modify gist itself.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/semanticarts/gist/issues/110?email_source=notifications&email_token=ACSHHSNSREQGYNTVB6E4V5DQKYGWXA5CNFSM4IYXW2Z2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7IQYNQ#issuecomment-533793846, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ACSHHSO4VRX2Y2Z2Q26CO7LQKYGWXANCNFSM4IYXW2ZQ.

Scott suggests using subclassing.
PhysicalSubstance is not necessarily person-made - we definitely want to remove this.
It's not a natural grouping.
Is Artifact the right label?
What is the purpose of having Artifact as a class? What was the rationale for adding it? It's an abstraction, like SocialBeing, which was eliminated for that reason. I.e., you would never instantiate it instead of one of its subclasses.
Artifact is an example of a larger problem. There is a design style issue. We'd have to examine all other union classes and decide on a case-by-case. Or we could rule out this pattern of equivalentClass to a union altogether.
Scott will take this on and bring back a proposal for a definition of Artifact.
Make new issue for the general design question.

I've just noted the following from my original description of the problem:
"'In fact, we see already this problem within gist itself. System is a subclass of Artifact, but it is not asserted to subclass any of the unioned classes. Do we really want to say that System is a direct subclass of one of these, but we don't know which? Seems odd. And none of the unioned classes seem like appropriate superclasses of System."
The definition of System is:
	<owl:Class rdf:about="&gist;System">
		<rdfs:label rdf:datatype="&xsd;string">System</rdfs:label>
		<rdfs:comment rdf:datatype="&xsd;string">A system is an artifact with component parts where the parts contribute to the goal of the system</rdfs:comment>
		<owl:equivalentClass>
			<owl:Class>
				<owl:intersectionOf rdf:parseType="Collection">
					<rdf:Description rdf:about="&gist;Artifact">
					</rdf:Description>
					<owl:Restriction>
						<owl:onProperty rdf:resource="&gist;hasDirectPart"/>
						<owl:someValuesFrom rdf:resource="&gist;Component"/>
					</owl:Restriction>
				</owl:intersectionOf>
			</owl:Class>
		</owl:equivalentClass>
	</owl:Class>

We're saying System is an Artifact but we don't know which particular subtype it belongs to. This is poor design, IMO.

Limit scope to removing union.

Remove intersection and union and replace with direct subclass assertions to each member of union.


Adding administration functions for users.

This commit adds functions for the user administration portion of the Github API, provided only in the Enterprise version.

thanks for the pull request! sorry for the delay :disappointed: I've made some minor changes (figured it was just easier to go ahead and make them myself) and merged as 9b08b7fd981314a7097e2cc2174ecc913c743ec6
main changes:

rename file to user_adminsitration.go to match github docs
rename methods: Promote => PromoteSiteAdmin, Demote => DemoteSiteAdmin to make it clear what these do
update method docs to clarify that these are for GitHub Enterprise
update test methods to return 204 responses

Thank you!
On Monday, January 12, 2015, Will Norris<EMAIL_ADDRESS>wrote:

thanks for the pull request! sorry for the delay [image: :disappointed:]
I've made some minor changes (figured it was just easier to go ahead and
make them myself) and merged as 9b08b7f
https://github.com/google/go-github/commit/9b08b7fd981314a7097e2cc2174ecc913c743ec6
main changes:

rename file to user_adminsitration.go to match github docs
rename methods: Promote => PromoteSiteAdmin, Demote =>
DemoteSiteAdmin to make it clear what these do
update method docs to clarify that these are for GitHub Enterprise
update test methods to return 204 responses

—
Reply to this email directly or view it on GitHub
https://github.com/google/go-github/pull/155#issuecomment-69651672.


Add support for compressed syscall

What current issue(s) does this address, or what feature is it adding?
audit of testnet block 2105805 showed a deviation in VM state due to no support for compressed syscalls. neo-python would throw an exception on compressed syscall operands
How did you solve this problem?
add support for compressed format
How did you make sure your solution works?
audit of the block now passes
Are there any special changes in the code that we should be aware of?
no
Please check the following, if applicable:

[ ] Did you add any tests?
[X] Did you run make lint?
[X] Did you run make test?
[X] Are you making a PR to a feature branch or development rather than master?
[X] Did you add an entry to CHANGELOG.rst? (if not, please do)

Coverage decreased (-0.008%) to 85.264% when pulling 44793fd2f6a50ebe6263a321d8934c8f094b73f4 on ixje:support-compressed-syscalls into caca8d8e0b2e6bdb24c66add669643adb4a2777f on CityOfZion:development.


[TECH-DEPT] Investigate lightweight tokens pattern

See where we inject optional directives or use directives in queries see if we can improve bundle size by utilizing this pattern:
https://angular.io/guide/lightweight-injection-tokens#use-the-lightweight-injection-token-for-api-definition

is it relevant?

In theory yes, but I'm not sure we have resources for this. I'll close it for now.


[Feature]multi limit selection to n dates

i would like to be able to select n dates, and no more. if i select n+1, then the first date selected is deselected.
use case: i want to request a work schedule. i work 4 days per week. i want to work mon, wed, fri, sat., next week

forgive me, i'm a dart/flutter n00b. if i'm reading the code, correctly, i can't really do this if i use the dialog, right? i don't see how i would access the selected dates (to see how many dates were selected) if i use the dialog.


[Bug]: Custom logo throws 500 error

Preflight Checklist

[X] I could not find a solution in the documentation, the existing issues or discussions
[ ] I have joined the ZITADEL chat

Version
No response
Describe the problem caused by this bug
Error: Invalid src prop (https://b2b-demo-rbxajm.zitadel.cloud/assets/v1/170084137439330561/policy/label/logo-dark-189254589529194753) on next/image, hostname "b2b-demo-rbxajm.zitadel.cloud" is not configured under images in your next.config.js
See more info: https://nextjs.org/docs/messages/next-image-unconfigured-host
To reproduce
I have a custom logo configured. This error appears when calling up http://localhost:3000 in dev mode.
Screenshots
No response
Expected behavior
No response
Relevant Configuration
No response
Additional Context
No response

Hey, gonna fix it, can you assign it to me

@mu-irfan thanks for taking this over, I assigned you to the issue.
@mffap quick question, did you set the trusted domain on your instance?
I didn't have a look on my test setup what the exact error was, but at the beginning I also couldn't load the logo, I tested with the deploy to vercel, and either the problem was that my env var wasn't set correctly or the trusted domain.
https://zitadel.com/docs/apis/resources/admin/admin-service-add-instance-trusted-domain

@mu-irfan thanks for taking this over, I assigned you to the issue.
@mffap quick question, did you set the trusted domain on your instance? I didn't have a look on my test setup what the exact error was, but at the beginning I also couldn't load the logo, I tested with the deploy to vercel, and either the problem was that my env var wasn't set correctly or the trusted domain. https://zitadel.com/docs/apis/resources/admin/admin-service-add-instance-trusted-domain

What's the value for the trusted domain? Is that supposed to be http://localhost:3000/ ?
I followed the steps Run Login UI, I don't think it states something about Trusted Domains.

You are right in the readme thats not stated, only in the ZITADEL docs: https://zitadel.com/docs/guides/integrate/login-ui/typescript-repo#deploy-to-vercel
The domain of the login needs to be added, so it can be used as public host from ZITADEL.


As an Analyst I want my data profile to reflect basic independent trends in my temporal fields

Tasks

[ ] Compute temporal min/max
[ ] Compute null prevalence
[ ] Implement a semantic classifier to recognise dates
-- TemporalAnalyser:
-- Takes in DataFrame and field
-- Extract field type
-- Overload for numeric & string
-- Parse to fitting DF type
-- Return new DF
-- (in future consider retaining type to maintain schema of original data)
[ ] Spike: string format validation on Spark Columns

The profile should contain:

name
timestamp type (insert, update, future)
lower/upper temporal bounds
distribution of timestamps across range (e.g. equally spaced, bunched)
noise in distribution
null prevalence

(crossed out items reflect previous requirements - no longer part of MVP)

As at 19/12/2018:

Priority: Medium-High - Temporal fields are likely to be prevalent within data sources used by people considering the use of the profiler when at MVP stage.
Complexity: Unknown - What has been achieved already and what is left to develop for analysis over temporal fields. Conceptually there will be a complex element around different date/time formats that can be emitted, i.e. dd/MM/yyyy vs. MM/dd/yyyy where all dd <= 12.


JunkRat: Frag Launcher Projectile Size

Created by: DpsDoomMain
• Currently Junkrat's Frag Launcher shot an explosive with a projectile size of 0.25
• Previously Junkrat's Frag Launcher shot an explosive with a projectile size of 0.20

moved from ow1_emulator_backup#498


Webpack Rationalisation

[ ] Eliminate MaptilerSDK import
[x] Implement chunking

Incorporate:

[x] JQuery
[ ] Datatables

https://datatables.net/forums/discussion/72179/using-jquery-datatables-with-webpack-error-on-new-imports-loader-version
https://datatables.net/forums/discussion/74959/example-of-datatables-net-with-bootstrap-5-buttons-in-webpack

[x] Bootstrap
[ ] Fontawesomefree
[ ] MapboxGL draw

Also perhaps:

[x] aliases.js (imported to base.bundle.js)
[x] parents.js  (imported to search.bundle.js)

Eliminate dependency on remote libraries:

[x] Google fonts

Apply base_webpack.html across codebase

[ ] accession.html
[ ] area_create.html
[ ] ds_addtask.html
[ ] ds_browse.html / http://localhost:8001/datasets/6/browse
[ ] ds_collection_browse.html
[x] ds_gallery.html
[ ] ds_places.html
[x] home_v30a.html
[ ] place_collection_browse.html
[ ] place_detail.html
[ ] place_portal.html
[ ] review.html
[ ] search.html

Strategy

Use CDNs where practical (JQuery, Bootstrap, and MapLibre-GL too - beneficial for WHG's globally-distributed users), but loaded with JavaScript to enable WHG fallback;
Load Google font with CSS from WHG copy (I've removed the large and unnecessary fontawesome JavaScript includes - those fonts are also loaded through CSS);
Chunk and bundle everything else, including NPM modules drawn from their native folders rather than extracted copies elsewhere in the codebase. This will facilitate minification for production. It should be possible to implement deferred-loading for some of the bundles.

Back away from Maptilersdk completely because it's not available from any CDN, it contains a great deal of code useless to WHG, and has proven to be rather inflexible with regard to customisation. Some of its classes might be remodelled as custom extensions to MapLibre. The terms of use for Maptiler maps without a paid subscription require the display of their obtrusive logo, and the SDK will be even less useful if we can get our own WHG tilesets built and served.

Webpack is now configured to copy CDN fallback files from node_modules to a root CDNfallbacks folder, and /urls.py is configured to serve those files when necessary, but only if the user's host is whgazetteer.org or localhost. This should make the system more robust.


[distributions] use dogsketch

TODO

[x] write a release note so CI passes
[x] write a Marshal method
[ ] release agent-payload

What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?

@hush-hush - I think I accidentally dismissed your review


Set swagger-parser version to 2.0.1-SNAPSHOT

The next swagger-parser version will be published soon. See https://github.com/swagger-api/swagger-parser/issues/717
I would like to update the swagger-snapshot branch to make some tests.

@quen2404: can you also merge master into swagger-snapshot with a merge commit, in order to pick up all the changes made on master since april?

@jmini i haven't access to my IDE currently, so if you want a fast merge, please make a PR. Else I will do it tomorrow.

discussed merge master into swagger-snapshot => #46


how to make sure it babyagi-ui is updated

hi there, excuse my question, completely new to this but love what you did with babyagi-ui!!! thank you very much, even with minimal starting knowledge I was able to get it to run.
my question is probably very mundane but could you advise on how to make sure one is running the most current version of baby-agi-ui?

Thank you for taking on the challenge!
Since we don't display whether it's the latest version on the screen, you'll need to check it using the git command in the terminal.

After moving to the project root, you can check it with the following command:
git pull origin main
With this command, the differences will be updated, or if it's already up-to-date, you'll see a message like the following, indicating that it's the latest version.
From github.com:miurla/babyagi-ui
 * branch            main       -> FETCH_HEAD
Already up to date.


No LICENSE file

Could you please add an explicit LICENSE file to the repository?
I'm working on a project for Cisco, and their internal tool that is used for describing assets used in projects requires that you add a text of the license for open-source components.

@croshchupkin sure thing, sorry this took a while to get around to. Do you need me to cut a new release into PyPI, or is github master having a LICENSE sufficient?
The license is 2-clause BSD, by the way.

I think I'll just go with the License file from the master. I already created a component with the current version in the Cisco's tool, so I don't really want to create a new one.
Thanks.


go/types, types2: missing error for conflicting method types due to incremental unification

The following code type-checks, but probably shouldn't.
package p

import "fmt"

type C[T any] interface {
	m(T)
	n(T)
}

type Interface interface {
	m(int)
	n(string)
}

func F[T any](t C[T]) {
	switch t.(type) {
	case Interface:
		fmt.Println("here")
	}
}

func main() {
	F[int](nil)
}

(note that there is no instantiation of C that has different argument types for m and n).  The reason for this is that the MissingMethod API (used internally for interface assertions) unifies individual methods separately, not the entire method set.
Discovered while looking into #50658.
CC @griesemer

Actually, my initial diagnosis may have been wrong. It appears we are far more permissive than I assumed, and the unification logic in missingMethod exists only for method type parameters (which are currently disallowed anyway).
So this is probably fine as-is, though we could be more precise.


Find Nuget dependency vulnerabilities

What's changed?
Add recipe to find Nuget dependency vulnerabilities
What's your motivation?
Parity with Maven & Nodejs; bring to light vulnerable versions in use.
Anything in particular you'd like reviewers to focus on?
Bumping dependency versions with the current trait based approach might need some work still, although this iteration can already detect vulnerable dependencies.
Any additional context

Continues on from https://github.com/openrewrite/rewrite-java-dependencies/pull/118

Merging as I'd indicated I'd deploy this to the platform ahead of demo; we can always revise after seeing the results.


Exception: Unknown webview handle when closing custom editor

Repro:

Open a custom webview editor
Do some stuff (not sure what triggers exactly)
Close it

This seems like it's expected so should be silent?

The error indicates that the webview is trying to post a message to a webview that has been destroyed.
I'm assuming this is your custom editor so can you look at your extension code to avoid doing that?

Thanks, figured it wasn't me since the trace only shows workbench code. I guess I need to catch and swallow the errors or track which webviews should be gone.


Provide a code lens for execution for if __name__ == "__main__"

It's like the Run code lens in the Java extension on their main() method. Might be slightly tricky if the file happens to be inside of a package and we don't simply use the file path version -m.

Dependent on the outcome


Versions.js failed to update automatically

See https://github.com/puppeteer/puppeteer/blob/main/versions.js#L20
105.0.5173.0 was already released and NEXT had to be replaced with the actual Puppeteer version

Fixed in https://github.com/puppeteer/puppeteer/pull/8794


NUnit Multi-Assembly Support

Move NUnit from running multiple assemblies separately to running the all in on Run. This keeps result files from overriding each other, as well as reducing console output clutter.

Wanted to push out a note that this fix is alive and well. I just got back into town and will be updating/repushing my fixes.

No hurry, the PR is waiting for you until you have time :smile:


LoongArch64: Rename targets

The existing targets naming convention for LoongArch64 is not appropriate(lack of microarchitecture-specific thoughts).
Now I use LA464, LA264 to replace the original targets.

I suggest provide some loongson build bots to http://ci.openblas.net/

Thank you for your advice. Since I am not familiar with build bots, do you want me to provide compile options for LoongArch64?


Also execute callback if there has been an error

We had a problem whereby grunt watch would stop because the ava stream was not closed if a test failed.
I think this was due to the callback not being called. This has been corrected in this PR.
I'm not super-sure this is the right thing to do so I welcome a discussion.

I checked what gulp-babel does and it calls cb() even in the error case. Maybe this is what gulp-ava should be doing as well.

Yup. Thanks :)


"Translucent" instead of "Transparent"

This TranslucencyMode enumeration value does not match in the documentation and implementation.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8a52cd5e-2cc8-0398-dcb3-db2607f11c1b
Version Independent ID: c2586399-6b8c-78c6-e0da-fa3e35adb00a
Content: TabbedPage translucent tab bar on iOS - Xamarin
Content Source: docs/xamarin-forms/platform/ios/tabbedpage-translucent-tabbar.md
Product: xamarin
Technology: xamarin-forms
GitHub Login: @davidbritch
Microsoft Alias: dabritch

Hi @radoeska-v
Thanks for reporting this. I'll get it updated in the next few days.

I've fixed this in a PR that will go live either today or tomorrow.

Hi David,
Thanks for the update :)
On Thu, Mar 19, 2020, 15:53 David Britch<EMAIL_ADDRESS>wrote:

I've fixed this in a PR that will go live either today or tomorrow.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/xamarin-docs/issues/2636#issuecomment-601224192,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEJ7EEOGTPRPFRCYGWMZZSDRIIWYDANCNFSM4LPEZGHA
.


Android Beta Epic

The Issue
Epic to track cross repo / lbry-android items needed to move into Android Beta launch. This includes internal api changes as well as rewards.
System Configuration

Device:
Android version:

Anything Else

Screenshots

@akinwale Why did you close the current epic? Did you start a new one?

@alyssaoc My assumption this was meant for issues required to transition from closed alpha to open beta.


Consultation on TEA results

Hello, could I consult you how to see the formula for each value in the Itemized costs and Cash flow worksheets in the excel file obtained from code sys.save_report, since only the final value is in the result, which is not conducive to checking and verifying the result.
Thanks for your help. Wish you a good day.

@zasddsgg, we follow the exact same cash flow analysis procedure used by Humbird's 2011 NREL report. You can find all the formulas there (or look at the TEA code). For itemized cost of each unit operation, you can check the code for each unit operation or look at the supplementary information to some of our publications. For the most part, they come from Warren Seider's Product and process design principles.
Thanks,


Latest tag is added only for master branch by default, not for main

Behaviour
per readme, For conditionally tagging with latest for a specific branch name, e.g. if your default branch name is not *master*, use type=raw with a boolean expression: this seems to ignore merges to current github standard of main
Steps to reproduce this issue

setup metada-action with latest tag handling left as default
merge a PR to main (default branch)

Expected behaviour
latest tag should be added for main merges not just old master
Actual behaviour
image was tagged as main not as latest
Configuration

Repository URL (if public):
https://github.com/AdysTech/mi_atc_reader

Build URL (if public):
https://github.com/AdysTech/mi_atc_reader/runs/5440343790?check_suite_focus=true#step:5:44

env:
  #REGISTRY: ghcr.io
  IMAGE_NAME: ${{ github.repository }}
     - name: Retrieve author data
        run: |
          echo AUTHOR=$(curl -sSL ${{ github.event.repository.owner.url }} | jq -r '.name') >> $GITHUB_ENV
      #https://github.com/docker/metadata-action
      - name: Docker meta
        id: meta
        uses: docker/metadata-action@v3
        with:
          # list of Docker images to use as base name for tags
          images: ${{ env.IMAGE_NAME }}
          labels: |
            org.opencontainers.image.authors=${{ env.AUTHOR }}
          # generate Docker tags based on the following events/attributes
          tags: |
            type=schedule
            type=ref,event=branch
            type=ref,event=pr
            type=semver,pattern={{version}}
            type=semver,pattern={{major}}.{{minor}}
            type=semver,pattern={{major}}
            type=sha

I don't see any type=raw,value=latest,... in your repro to be able to generate the latest tag.

I don't see any type=raw,value=latest,... in your repro to be able to generate the latest tag.

@crazy-max I think my point is I expected the latest tag added to main branch with default settings and not just limited to master since GitHub no longer uses master (ref: https://github.com/github/renaming) Why this repo is treating master as special and adds latest only for that branch? and expects uses to add  type=raw,value=latest for main which is the default branch if you have created the repo in last 2 years.

not just limited to master

we don't set latest on branch event. Only for:

type=ref,event=tag
type=semver,pattern=...
type=match,pattern=...

See https://github.com/docker/metadata-action#latest-tag

If your default branch is main, then our example will work:
type=raw,value=latest,enable=${{ github.ref == format('refs/heads/{0}', github.event.repository.default_branch) }}

sorry to ask this again, if I create a new repo today in github (which will have default branch as main) do I need to have this  github.event.repository.default_branch tagging and assume flavor: latest=auto will not work in this case?

flavor: latest=auto will only create the latest for the events specified in the README https://github.com/docker/metadata-action#latest-tag:

type=ref,event=tag
type=semver,pattern=...
type=match,pattern=...

The following entry:
type=raw,value=latest,enable=${{ github.ref == format('refs/heads/{0}', github.event.repository.default_branch) }}

will create the latest tag for the condition specified in enable which will be in this case a push event on the default branch.

Added latest to the default branch should really be the default behaviour rather than basing on the branch name being only master.
Its not great to have to add this long (relatively) complex config to add something that should be intuitive.

Agreed with latest commenter. I am almost tempted to rename my main branch master again.


We should not hard code leveldown-mobile in pouchDBGenerator

Right now pouchDBGenerator has a default to leveldown-mobile which it then tries to require if no other default is set. This is bad because depending on the platform we are running on there may or may not be leveldown-mobile available.
So what we need to do is remove the default setting all together.
Then we need to edit the jsdoc (please make it into a jsdoc by changing /* into /**) to specify that if the person is running on mobile then they must pass in {defaultAdapter: require('leveldown-mobile')}

Also, please add js-extend as a dependency in thali/package.json


Complete the 4.0 update

[ ] Fix up the Go example at https://www.pulumi.com/registry/packages/linode/ to use v4
[ ] Update linode-go template in pulumi new to use v4

this is done.


Migration guide for KeptnAppContext

Goal
As a user, I want to have clear instructions on how to migrate from my old manually set up KeptnApp to the new KeptnAppContext.
This will enable to me to use Keptn with minimal to no downtime while migrating.
Details
The process should roughly be as follows:

For each manually created KeptnApp, create a KeptnAppContext with the same name
Move the Pre/Post deployment tasks and evaluations from the KeptnApp to the KeptnAppContext.
The version matrix does not need to be moved as this will be created automatically going forward. Tell users to make sure that their annotations/labels are set up correctly (or link to the labels/annotations section that already exists).
Investigate and decide if it's better to keep the KeptnApp resources (in this case, most likely the app.kubernetes.io/managed-by: keptn annotation
needs to be added), or if it's better to delete any KeptnApp resources after the pre/post deployment tasks have been moved to the KeptnAppContext.

Steps

create a migration guide under docs/docs/migrate that covers how users should migrate towards using the KeptnAppContext
manually test the migration guide to make sure that it works

Notes to the 3. point of the issue
Removing of the manually create KeptnApp will result in an inconsistent state of the system, since a new auto-discovered KeptnApp won't be created until the application pods won't be restarted. The reason is that KeptnAppCreationequest, which is a pre-requisite for automatic creation for KeptnApp, is created only by Mutating webhook during creation/update of the application pod.
Better solution is to manually add app.kubernetes.io/managed-by: keptn annotation to the manually created and already existing KeptnApp


Keeps redownloading the model after each restart

The model loader is redownloading the Florence 2 model from Huggingface every time I have restarted Comfy...
(Latest version of Comfy all extensions updated.)

I'm unable to reproduce this, it does redownload if the model is not in the new location in models/LLM, but only once, then it loads from cache correctly. By any chance do you have kijai's florence2 nodes installed also? He's using a slightly different method to download the models and I'm wondering if it conflicts.

Well I'm not having this issue anymore. I think the better model management patch might have fixed it. I probably didn't have that when I opened this issue.


added new singleImage prop to component and App demo

Works great, thanks!

Will push a new version to NPM soon.


esp32s3/pwm: Fix pwm output

Summary

Fix pwm output always low problem.
Add multi channel support in defconfig

Impact
Solve the problem of LEDC output low and close #11476
Testing
Hardware: esp32s3-wroom-1 (M0N4R2)

@w2016561536 nice work! Please fix the coding style issues reported in your commit


convenient way to handle parameters during reaction building

It would be nice to have a get_parameters() (or similar) function that accepts a list of parameter strings (with the same part_id, and mechanism) and returns a dictionary of parameters.
p =  component.get_parameters(['ktl','kb','ku','length'], part_id = part_id, mechanism = self)

#RNAP DNA Binding
r1 = Reaction.from_massaction([transcript, self.ribosome], [bound_complex], k_forward = p.kb, k_reverse = p.ku)
#Transcription
r2 = Reaction.from_massaction(self.fuels + [bound_complex], self.fuels + [transcript, self.ribosome, protein],
    k_forward = parameter_to_value(p.ktl.value)/parameter_to_value(p.length))
#Fuel consumption
r3 = Reaction.from_massaction(self.fuels + [bound_complex], [bound_complex]+self.wastes, k_forward = p.ktl)

Orignal code
ktl =  component.get_parameter("ktl", part_id = part_id, mechanism = self)
kb = component.get_parameter("kb", part_id = part_id, mechanism = self)
ku = component.get_parameter("ku", part_id = part_id, mechanism = self)
L = component.get_parameter("length", part_id = part_id, mechanism = self)

#RNAP DNA Binding
r1 = Reaction.from_massaction([transcript, self.ribosome], [bound_complex], k_forward = kb, k_reverse = ku)
#Transcription
r2 = Reaction.from_massaction(self.fuels + [bound_complex], self.fuels + [transcript, self.ribosome, protein],
    k_forward = parameter_to_value(ktl.value)/parameter_to_value(L))
#Fuel consumption
r3 = Reaction.from_massaction(self.fuels + [bound_complex], [bound_complex]+self.wastes, k_forward = ktl)

yeah that is a nice feature. Will definitely add it to a future update!


Apply PR#1247 from upstream

See xianyi/OpenBLAS#1247

Tests pass and this PR is ready for review now.
@conda-forge-admin, please lint.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

So am a bit torn between patching openblas like this or just pulling all of the openblas 0.2.20 builds as they are basically broken. Thoughts?

Thanks @isuruf! This will be in handy for the next scipy version.


Homebrew deprecated command

On the documentation where it says to run the command brew cask install docker, it's actually brew install --cask docker if you have the most updated version of Homebrew... based on this thread:
https://github.com/Homebrew/discussions/discussions/340#discussioncomment-232364

brew cask <command> was deprecated in favor of brew <command> --cask in Homebrew 2.6.0. Now that 2.7.0 has been released, they have been disabled.

So depending on the version of your Homebrew, this command might fail as it happened to me.

This is a great suggestion @nandotess! Can you please open a pull request to address this? Should we also add a note saying that brew cask install is necessary if using Homebrew before version 2.6.0 or can we just assume that people would be running the latest versions of the suggested software?

@kasparsd maybe it's better to give both options, depending on the Homebrew version. I will create the PR, thank you!

Fixed in #121.


 When searching the repository I see it created in index.js at line 78 and set on the db at line 27 but no other references to it in the repository. I'm thinking it's just not wired up to anything.

@mochacoder
Could you post the code you're trying to schedule? There are some quirks with when your tasks run so it'd be helpful to have the code.

Yeah whenever I run one of the examples from the site it does work so must be something specific in my code. I'll figure it out, thanks for the quick comment and that autorun link does help.

@mochacoder
No worries. Feel free to continue asking questions.


fixed UT

Description of changes:
Description of testing:
Please make sure the following changes have been made before creating a pull request.
Update Description

[x] Change tested on actual device
[ ] Changes tested for simulator
[ ] Existing device functionality is working fine
[ ] Unit Tests Written for Code Changes, and Verified that Coverage is 100% for Modified Files(with the exception of ATM devices)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.arnab seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


index error if station frequency is above (audio_sampling_rate / 2)

The index error should be avoided by a plausibility check of the stations frequency compared to audio_sampling_rate in config.py

ready for merge with #54

Test: the frequency of STATION_2 is set to 24001 for audio_sampling_rate = 48000
A warning is present, but the station number is off by one.
is:
ubuntu@ubuntu:~/fenrog/supersid/supersid$ ./config.py
Error: [STATION_**1**] frequency=24001: audio_sampling_rate=48000 must be >= 48002.

should:
ubuntu@ubuntu:~/fenrog/supersid/supersid$ ./config.py
Error: [STATION_**2**] frequency=24001: audio_sampling_rate=48000 must be >= 48002.

The same error occurs for the report if the channel number is too high.

ready for merge with https://github.com/sberl/supersid/pull/79


Add development dependency sync

It seems that rebar3 doesn't need sync.
http://blog.erlware.org/rebar3-auto-comile-and-load-plugin/
We just have to add the following code to rebar.config:
{plugins, [rebar3_auto]}.


Updating graphics with Awesomic designs

Coverage: 94.033%. Remained the same when pulling cb215f6aa9b023699341a2900dbfb8027a288588 on rahul-update-graphics into 9095be86344e720a194624ab37f0fc5a8892181f on main.


Textarea display problem in super hi-dpi

While I was using postwoman in chrome, I found a problem: all of textareas (with linenumber) undisplayed.
(only happened in chrome/new edge, no ff/old edge)
You will easily reappear the problem:
make your screen dpi in a super high mode, such as 1920x1080 with 150% scales. And switch to POST method in the postwoman. Then check raw input. you will see that textarea of raw request body has been undisplayed.
Magically, when I changed browser display scale (ctrl + as you know). In any way, the textarea redisplayed.

@RickoNoNo3 I tried to reproduce the issue at my end but I couldn't. Can you tell a little more about you device. which operating system? Chrome version? etc..

@liyasthomas I use Chrome 83.0.4103.116 (latest) on Windows 10 2004. Screen: 1920x1080 (150% as 1280x720)
I tried more about how to make it reappeared and noticed:

In 100% default scaling of my Chrome, document.body.clientWidth shows 1020, with issue
In 90% scaling(1134), with issue
In l/e 80%(1275), no issue
In g/e 110%(927), no issue
In media keyword triggered, no issue
When textareas are undisplayed, adjusting the zoom to safe scale on the same page will make them show.
Once textareas are displayed, no operations can make it restored to undisplay.

These conclusions are established, unless you reload a textarea(maybe turn off raw input and check it again). reloading a textarea has the same behavior with reloading the page.
So in my mind, this issue appears in a kind of environment with specific width. And it is a problem that occurs when generating textarea elements (not related to css).
btw body.clientWidth in default scaling of firefox is 1280 while in Chrome is 1020. The true width of 150% of 1920x1080 is indeed 1280. So my Chrome has an unexpected over zooming (bigger text as well). Edge too.

nonono, not just page client width, I cannot get it appeared by resizing my browser window to the "problem width". Instead, it still make issue in 90% and 100% scaling no matter how big the window is.
Maybe It is directly related to the total width of the screen? or the dpi?

Noted. Looking into it.

I guess we can ignore this UI issue since it's only reproducible in such an edge case of super-high dpi. Let me know if you it is reproducible in normal situations.

You are right. It works well to set a different zoom ratio as default of Chrome.


Nested module's 'modules:done' doesn't work like expected

Environment

Operating System: Linux
Node Version:     v18.18.0
Nuxt Version:     2.17.1
CLI Version:      3.9.1
Nitro Version:    2.7.1
Package Manager<EMAIL_ADDRESS>Builder:          webpack
User Config:      modules, serverHandlers, devServerHandlers, devServer, typescript, nitro, bridge, buildModules
Runtime Modules:  ~/modules/nested
Build Modules<EMAIL_ADDRESS>

Reproduction
Nuxt 2b:
Direct module install (working as expected):
https://stackblitz.com/edit/github-dwx287-kpyejp?file=nuxt.config.ts
Sync installModule (broken):
https://stackblitz.com/edit/github-dwx287-eqecsd?file=nuxt.config.ts
Async installModule (working as a little bit unexpected):
https://stackblitz.com/edit/github-dwx287-7mgh1y?file=nuxt.config.ts
Nuxt 3:
Sync installModule (working as expected):
https://stackblitz.com/edit/github-dwx287-ogyhr8?file=nuxt.config.ts
Describe the bug
Current behaviour is not fully aligned with nuxt 3. According to this: https://github.com/vuejs/pinia/blob/1151e67f5eb2f5221273f9a8566e3e5ba9154a1e/packages/nuxt/src/module.ts#L78-L84
Pinia module relies on 'modules:done' hook, which is fired after all modules were installed. @pinia/nuxt's setup() is also synchronous.
I expect pinia to add needed plugins when calling sync installModule function, as it works in nuxt 3 or in direct usage. I got pinia undefined, because module didn't receive 'modules:done' hook
Additional context
No response
Logs
No response

Using async await seems to be working as expected!
https://stackblitz.com/edit/github-dwx287-8jrhpi
import { defineNuxtModule, installModule } from '@nuxt/kit';

export default defineNuxtModule({
  meta: {
    name: 'pinia-installer',
    compatibility: {
      nuxt: '^2.17.0 || ^3.0.0',
      bridge: true,
    },
  },
  // add async
  async setup() {
    // add await
    await installModule('@pinia/nuxt');
  },
});

It's not clear, because nested module setup in sync. This is why I provided 4 different setups above: similar code without async/await works in Nuxt 3 and should work in Nuxt 2b too, I suppose.
I've created another example where nested module have only one hook: https://stackblitz.com/edit/github-dwx287-swerdg?file=nuxt.config.ts,modules%2Fsecondary%2Findex.ts,modules%2Fprimary%2Findex.ts
I still think we should align the behaviour with nuxt 3 (To compare: https://stackblitz.com/edit/github-dwx287-vi8c7r?file=nuxt.config.ts,modules%2Fsecondary%2Findex.ts,modules%2Fprimary%2Findex.ts)

Oh, sorry. I didn't realize there was already a reproduction 🙏
It may be difficult to adapt the processing of modules to Nuxt 3, as it would require modifications to Nuxt 2 itself.

It's ok) I didn't go deep inside Nuxt internals to realise the causes for this behaviour. I can suggest to label this issue with workaround available until future investigations

I made a small research and I can declare this is not fully fixable.
Nuxt 3 utilises kit's installModule hook for each module which makes possible to use any nested installModule possible: https://github.com/nuxt/nuxt/blob/7cce0ef6e6e0733b5bdee368e8015d955623df19/packages/nuxt/src/core/nuxt.ts#L385
However, Nuxt 2 relies on its own addModule implementation. so even with https://github.com/nuxt/nuxt/blob/5eb1b32f62a0ad92bfa6f37641489c35caa4b791/packages/core/src/module.js#L22 so even if we push nested module in nuxt.options._modules inside kit, next nested module will lost modules:done hook again


lambdas are faster than eval strings in :def functions

As the title suggests, lambdas are faster than eval strings inside a :def function.  I think that's because they're compiled, while eval strings are not.

As a simple test, we can use this command to test how faster lambdas are compared to eval strings once they're compiled inside a :def function:
vim -es -Nu NONE -i NONE -U NONE -S <(cat <<'EOF'
    vim9script
    def Lambda()
        var time = reltime()
        range(999999)->map({_, v-> v + 1})
        setline(1, reltime(time)->reltimestr()->matchstr('.*\..\{,3}') .. ' seconds to run lambdas')
    enddef
    Lambda()
    def EvalString()
        var time = reltime()
        range(999999)->map('v:val + 1')
        setline(2, reltime(time)->reltimestr()->matchstr('.*\..\{,3}') .. ' seconds to run eval strings')
    enddef
    EvalString()
    :%p
    qa!
EOF
)


[ENG-3761] LeftNav links and page styling

Ticket: ENG-3761
Feature flag: n/a

Purpose
Add the provider links to the leftnav and style the outer portions of the page
Summary of Changes

Add hero banner
Add provider links to leftnav
Fix broken translation

Screenshot(s)

Side Effects
Nah
QA Notes
It should only show providers that are linked to the current project, and you should be able to navigate to each of the providers.

Looks great! Do we want to add provider logos to different providers?

Nobody mentioned anything like that when I demoed it yesterday, so probably no?

Nobody mentioned anything like that when I demoed it yesterday, so probably no?

I actually wanted to mention but forgot. Anyway it looks good as is. We can add them after Futa's PR for his move modal work is in, since the provider logos will be added to assets in that PR.


proposal: go/types: add Object.Origin

I propose to add the following methods to types.Var and types.Func:
// Origin returns the canonical object for its receiver, i.e. the object
// recorded in Info.Defs.
//
// For instantiated variables Origin returns the type-parameterized object from
// which the receiver was created. For all other variables Origin returns the
// receiver.
func (obj *Var) Origin() *Var

// Origin returns the canonical object for its receiver, i.e. the object
// recorded in Info.Defs.
//
// For instantiated functions Origin returns the type-parameterized object from
// which the receiver was created. For all other functions, Origin returns
// receiver.
func (obj *Func) Origin() *Func

While instantiating types, we necessarily have to create instantiated copies of their methods/fields/parameters/etc. However, as we work on updating tools for generics, an emerging theme is that is useful to be able to answer the following two questions:

Is this object canonical?
What is the canonical object corresponding to this object?

Right now, these are not easy questions to answer.  For methods, these can be answered by a lookup on the receiver base origin type. For fields / parameters / etc., it is more difficult and may require finding the relevant *ast.Ident and looking in Info.Defs.
Adding an Origin method to these types answers both of these questions trivially, at the cost of a pointer per object. If the added memory is a concern, there are several internal fields on types.object used during type-checking that may be externalized to free memory.
CC @griesemer @dominikh @timothy-king @mdempsky

Does it make sense to have Origin on each Object? Isn't it sufficient to have it for TypeNames and Funcs?

Isn't it sufficient to have it for TypeNames and Funcs?

We'd need it for Vars as well (and technically we don't need it for TypeNames: we don't expose any non-canonical TypeNames).

Do we want more experience with the existing alternatives available before making a decision?

Do we want more experience with the existing alternatives available before making a decision?

It's fine to wait if we think we'll get more signal, but I do think we should add something for 1.19. This feels like a philosophical oversight: the canonical nature of Objects was broken without an API to easily 'canonicalize'.

This proposal has been added to the active column of the proposals project
and will now be reviewed at the weekly proposal review meetings.
— rsc for the proposal review group

We'd need it for Vars as well (and technically we don't need it for TypeNames: we don't expose any non-canonical TypeNames). When we instantiate structs / signatures, we instantiate vars.

I think it would be fine to simply add Origin to the objects that could possibly be instantiated: Var and Func, I think. That is more conservative, and we can always add it to the Object interface later.

@findleyr The more conservative approach seems fine. Can you please send out a CL soon so we can see the implications in detail?

I'm leaning towards returning Object. Even without the API being added to Object, users can define their own interface and get the origin object with a single type assertion/call. (*Named).Origin returning *Named doesn't seem problematic, since Named isn't an Object and thus isn't technically part of the same API.

Moving back to active to resolve the discussion about the result type.

Discussed this with @griesemer, and it seems like the arguments for concrete result types are compelling:

Fewer type assertions at the call site.
Less likely to introduce a typed nil.

On the other hand, we wouldn't be able to pass around interface{ Origin() Object } as @dominikh suggests, but it would of course be easy to write a helper func originObject(Object) Object.
By way of analogy, we document that Type() of a *Func is always *Signature, yet I have seen many places in x/tools where we use a commaok type assertion and handle the case that the Type() of a *Func is not a *Signature. I would guess that returning Object will lead to similar misuse.

@findleyr, thanks for updating the top comment with the proposed API. Does anyone object to this change?

Based on the discussion above, this proposal seems like a likely accept.
— rsc for the proposal review group

CC @adonovan :)

No change in consensus, so accepted. 🎉
This issue now tracks the work of implementing the proposal.
— rsc for the proposal review group

CC @golang/release
This issue was filed early in the dev cycle, but due to ongoing discussion and the abbreviated cycle, was not accepted until a few days before the freeze. With other priorities in go/types (particularly the urgent https://go.dev/issue/52715), I didn't get to the implementation of this feature before the freeze.
I'd like to request a freeze exception to land this proposal for 1.19, as it allows us to redefine a 'canonical' invariant that was broken with generics. Certain types of static analysis (such as https://github.com/dominikh/go-tools/issues/1215 or some Google-internal analyses) would be facilitated by these new APIs.
Please let me know if you'd like me to file a new issue for the freeze exception request, or if you need any other information to help make a determination.

This freeze exemption has been approved. Nothing else is required for the exemption request.

Thanks all!


Question: zigbee-bridge on Zigbee Gateway v1.2 (CON-725)

Describe the question/query that you have
I have a esp-thread-border/zigbee-gateway board, and I have flashed the zigbee-gateway example (and the RCP on the h2).
I was able to commission it with Google Home instead of the chip-tool, however now I don't know how to actually discover and add Zigbee devices.
I have 2 questions:

The documentation is unclear (the README only mentions how to flash the RCP). If using this board, is there any additional configuration required? For example, on the thread-border-router example, I can run idf.py menuconfig and alter some settings beforehand.
How do I discover and add Zigbee devices to the bridge if I am not using the chip-tool?

Additional context
I used esp-matter at commit https://github.com/espressif/esp-matter/commit/39914437dfbe6f16c77f19df580b28ef90750c5c, esp-idf at the recommended ea5e0ff298.
I see from the docs that there's matter commands in the device console (https://docs.espressif.com/projects/esp-matter/en/latest/esp32/developing.html#device-console), however running idf.py monitor does not bring up the console.

@wqx6 Please check
@nevi-me Meanwhile, can you confirm if you have flashed another ESP32-H2 with the Zigbee light_bulb example as mentioned here ? Once done, it should be added as a Matter accessory through the bridge.
The chip-tool commands provided just validate that the bridge is added. They shouldn't be required if you are using any ecosystem app.

can you confirm if you have flashed another ESP32-H2 with the Zigbee light_bulb example as mentioned here ?

I've just flashed the example (though it's called HA_on_off_light), and I'm getting the below error after the light bulb starts up:
I (3061) ESP_ZB_ON_OFF_LIGHT: Network steering was not successful (status: -1)
I (6731) ESP_ZB_ON_OFF_LIGHT: Network steering was not successful (status: -1)
I (10401) ESP_ZB_ON_OFF_LIGHT: Network steering was not successful (status: -1)
I (14071) ESP_ZB_ON_OFF_LIGHT: Network steering was not successful (status: -1)

The documentation is unclear (the README only mentions how to flash the RCP). If using this board, is there any additional configuration required? For example, on the thread-border-router example, I can run idf.py menuconfig and alter some settings beforehand.

You don't need to do any additional configuration in menuconfig. If the RCP is connected well to the zigbee bridge, the bridge will form a ZigBee network and print log like this:
I (1280) esp_zboss: Start network formation
I (3060) esp_zboss: Formed network successfully (ieee extended address: f9:54:2d:01:a0:03:f7:84, PAN ID: 0x8651)

And if the HA_on_off_light is in the same channel of the bridge, it will join the network after it starts. Then the dynamic endpoint will be added to the bridge.

How do I discover and add Zigbee devices to the bridge if I am not using the chip-tool?

Apple Home will detect the adding of dynamic endpoint and shows a new bridged device in their UI. But I'm uncertain about whether Google Home follows the same approach.

and I'm getting the below error after the light bulb starts up

Could you please check whether the bridge has formed a Zigbee network? Look like the HA_on_off_light doesn't join the Zigbee network.

You don't need to do any additional configuration in menuconfig. If the RCP is connected well to the zigbee bridge, the bridge will form a ZigBee network and print log like this:

I've cleared the flash, rebuilt the application and recommissioned. Interestingly, there are no logs at all from esp_zboss, zboss or anything to indicate that zigbee is running or if the entrypoint launch_app_zboss() had an issue.
I'm not yet good at reading schematic diagrams, I'm trying to figure out if the below default UART settings map to what's expected on the border router.
#define ESP_ZB_DEFAULT_RADIO_CONFIG()                      \
    {                                                      \
        .radio_mode = RADIO_MODE_UART_RCP,                 \
        .radio_uart_config = {                             \
            .port = 1,                                     \
            .uart_config =                                 \
                {                                          \
                    .baud_rate = 115200,                   \
                    .data_bits = UART_DATA_8_BITS,         \
                    .parity = UART_PARITY_DISABLE,         \
                    .stop_bits = UART_STOP_BITS_1,         \
                    .flow_ctrl = UART_HW_FLOWCTRL_DISABLE, \
                    .rx_flow_ctrl_thresh = 0,              \
                    .source_clk = UART_SCLK_APB,           \
                },                                         \
            .rx_pin = 4,                                   \
            .tx_pin = 5,                                   \
        },                                                 \
    }

What I think the ESP32-S3 is mapped with
ESP32 pin           | ESP32-H2 pin
--------------------|-------------
  GND               |     G
  GPIO17 (UART RX)  |     TX
  GPIO18 (UART TX)  |     RX
  GPIO7             |     RST
  GPIO8  (SPI INTR) |     GPIO9 (BOOT)
  GPIO10 (SPI CS)   |     GPIO2
  GPIO11 (SPI MOSI) |     GPIO3
  GPIO12 (SPI CLK)  |     GPIO0
  GPIO13 (SPI MISO) |     GPIO1

The Zigbee bridge example is designed for two devkits connected to each other(not a single board), with UART pins in the radio configuration being 4 and 5. However, for the Zigbee Gateway v1.2, the configuration differs. In this case, the rx_pin in the radio configuration should be set to 17, while the tx_pin should be set to 18.
Since the USB/JTAG instead of the UART is used as the default console for Zigbee Gateway v1.2 board, I would suggest that you change the default console channel in menuconfig.

@nevi-me Please close the issue if this helps

Sorry, I forgot to get back here. I changed the pins to 17 and 18, and the logs indicated that the RCP connection was working, however the Zigbee network was still not being formed. I didn't investigate further after that, so I can close this issue.
Thanks for all your assistance :)


Certificates consistency fixes

[ ] certificatePolicy parameter -> policy in beginCreateCertificate
[ ] version parameter in updateCertificateProperties should be optional
[ ] It appears you have a Contact, Contacts, CertificateContact, and CertificateContacts class. There should only be a CertificateContact class and every operation that deals with contacts should take in (if required) and output a CertificateContact[]. This class should only have properties email, name, and phone.

[ ] Change Contact class to CertificateContact
[ ] setContacts should take in CertificateContact[]
[ ] Change return type of deleteContacts to a Promise<CertificateContact[]>
(Not sure if these are all of the places needed to change)

[ ] importCertificate should not take in a string base64EncodedCertificate, should take bytes certificateBytes instead. Should then convert the passed in certificateBytes to a base64 encoded certificate and pass that to the generated code
[ ] Should enforce that CertificatePolicy gets issuerName and one or both of subject and subjectAlternativeNames
[ ] Shouldn't have oct as an enum in JsonWebKeyType
[ ] JsonWebKeyType enum name -> CertificateKeyType
[ ] id, name, createdOn, and updatedOn should be readonly for CertificateIssuer. Go over others to make sure what should be readonly is readonly
[ ] issuerProperties property -> properties in CertificateIssuer
[ ] Remove credentials property from CertificateIssuer
[ ] (not 100% sure) Most likely fix pem enum in CertificateContentType to "application/x-pem-file"
[ ] What should you do about potentially not having get permissions in a poller? (will discuss as a team)

Some notes:

It appears you have a Contact, Contacts, CertificateContact, and CertificateContacts class. There should only be a CertificateContact class and every operation that deals with contacts should take in (if required) and output a CertificateContact[]. This class should only have properties email, name, and phone.

We don't have "Contact" nor "Contacts". That's for sure coming from outdated code.

All types in Keys like KeyType should have Certificate as a prefix, so CertificateKeyType. Your MIME type in the review showed "application/pem", which is why that comment was brought up. If it is now "application/x-pem-file" that is correct.

...and, yes, that code to handle 403 looks correct.

Confirmed with @heaths that 403 is not relevant for the access control errors. The default behavior (throw because of a request error) is still valid. No changes needed, as far as I can tell.


Changing the variable names in the simple example

To make it even more readable I propose that the files and scripts dev1* have more concrete names like : init.nc, output.nc, example.cfg etc ...

We can't modify a tag version of the code so to what branch should I commit to ? main or develop ? It looks like main hasn't changed much since the tag ...


auswertung beliebtester user

output in the todo.txt file at the end of the todos a simple one liner:
EXAMPLE RESULT: "Winner of the Event with most votes (people that wrote down his or her number) is: Max Mustermann with 35 Votes"

or maybe even a ranking like so:
Alexander - 34 Points
Jenny - 14 Points
Tina - 11 Points
Max - 5 Points

Just to give my 2c here, I don't like the idea of rankings.
I'd consider it a win of I made a friend, not being on the top of a popularity contest


Bug: inconsistent date parsing by to_datetime

Hi everybody,
lets take the following dates:
dates = ['04/07/2013 21:40','22/06/2013 02:40']
if I call pd.to_datetime on these two date strings, it produces incorrect results. For the first date '7' is interpreted as day-value while for the second date '22' is interpreted as the day-value.
Please get me right I have no problem with the wrong parsed date value in the first string, but with the missing propagation of the corrent interpretation scheme after reading the second string.
Thanks

See #12585


Develop

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 71.171%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
395

Relevant Lines:
555

💛  - Coveralls


Making an http request from within vtl pipeline resolver

Amplify CLI Version
10.4.1
Question
I have a "createUser" graphql endpoint and I want to add a vtl pipeline resolver function that calls a Gateway API endpoint which in turn calls a 3rd party service to create an associated account.  The 3rd party service returns an account ID associated with the associated account and I need to set that account ID as a property on my user object.
Can I do this as described? If so what would that look like? Is there a better approach to doing this?
I saw this document which lead me to believe this might be possible.

Hey @gxxcastillo :wave: thanks for raising this! It should be possible to slot in a resolver that has an HTTP datasource pointing at your API Gateway endpoint for this createUser operation, although I do not have an example for this on hand. While I look into this a bit further I also think this is a great question to ask in our community Discord server!

Thanks @josefaidt, I've posted the question in the graphql-help channel.

Finally figured out a way to do this.

I created a custom data source that references my lambda function following these instructions: https://github.com/aws-amplify/amplify-category-api/issues/687#issuecomment-1190668317 :

    const dependencies: AmplifyDependentResourcesAttributes = AmplifyHelpers.addResourceDependency(
      this,
      amplifyResourceProps.category,
      amplifyResourceProps.resourceName,
      [
        {
          category: 'api',
          resourceName: 'myApi'
        },
        {
          category: 'function',
          resourceName: 'myLambdaFunction'
        }
      ]
    );

    const apiID = Fn.ref(dependencies.api.c8graphql.GraphQLAPIIdOutput);
    const lambdaArn = Fn.ref(dependencies.function.myLambdaFunction.Arn);

    const myLambdaFunction = Function.fromFunctionAttributes(this, 'lambda-dev', {
      functionArn: lambdaArn
    });

    const myApi = GraphqlApi.fromGraphqlApiAttributes(this, 'appsync-dev', {
      graphqlApiId: apiID
    });

    new LambdaDataSource(this, 'MyNewDataSource', {
      api: myApi,
      lambdaFunction: myLambdaFunction
    });

I created a custom resolver function with the following:

#set($requestArgs = { <object containing arguments for the lambda function> })
$util.toJson({
    "version": "2018-05-29",
    "operation": "Invoke",
    "payload": $util.toJson($requestArgs)
  })

I'm still not sure how to assign the data source to the resolver via the cli tooling but for now I've pushed my custom resolver up and then manually added the data source to the resolver using the amplify console.

@josefaidt or @ykethan, do you know how I could go about 3 above using the cli tooling?

@gxxcastillo did you end up being able to do this? i cannot do it without first creating the datasource, which requires to push twice. not ideal.


v0.20/ci/packages.yaml: use system perl

The Spack config for gadi already uses system perl. See v0.20/gadi/packages.yaml. We should do the same in the Spack config for CI.

Although I'm happy to approve this because syntactically it looks good, I don't really understand what any of the flags mean - @aidanheerdegen might be better placed to understand the semantics of it. Although, if you want to teach me one time, that'd be great too! 😁

Although I'm happy to approve this because syntactically it looks good, I don't really understand what any of the flags mean

I guess you're referring to the variant specifiers ~cpanm+shared+threads in the spec?
    - spec<EMAIL_ADDRESS>
I assume they are what is auto-detected with a spack find perl from the standard installed Perl. Is that correct @harshula?

Hi @aidanheerdegen, Do you remember why you defined the spec that way? I think it's copied directly from your old packages.yaml. i.e. From the following commit:
commit 8b156bf85bdf96398eff98589cd510d8e64e6930
Author: Aidan Heerdegen<EMAIL_ADDRESS>Date:   Mon Oct 31 15:40:33 2022 +1100

    Initial commit of packages.yaml config file

I found that Spack defaults to:
0.19.x<EMAIL_ADDRESS>0.20.3<EMAIL_ADDRESS>0.21.1<EMAIL_ADDRESS>


Use timeouts when making requests to the CDMS auth servers

This adds timeouts when making requests to Core.
If there's a connection error, and there is no cached password hash for the user, unfortunately it returns a 500 (getting a different status code out doesn't look simple to me).

Codecov Report

Merging #583 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #583   +/-   ##
========================================
  Coverage    96.43%   96.43%
========================================
  Files          123      123
  Lines         3707     3707
  Branches       326      326
========================================
  Hits          3575     3575
  Misses          94       94
  Partials        38       38

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbe83db...e239553. Read the comment docs.


Remove temp dir for PDF OCR, process pages in order.

Currently it's filling up my hard disk and the pages are processed in random order.

Awesome; thanks for the patch @pudo. I'll merge this in shortly and issue another release (which is long overdue) so that others don't share you're disk-filling fate. Don't sweat the "failed" tests. That's related to #78 and I've got a work in progress on that from a month or two ago that I'll hopefully get merged in for this release, too.

Thanks so much for accepting this patch even with the failing tests. I have a fresh Ubuntu machine now, maybe I should try and generate a new gold standard there (although #78 seems like a really good idea!).

I'm working on #78 right now. Almost got it. My makefile-fu is a little rusty but its coming together


PDF images don't convert in GitHub Actions

Need to investigate further on this one!

:+1:

For reference, this is the error I get:
2023-07-31T13:42:43.9808172Z Could not convert from PDF to PNG: _build/site/public/width_sweep-8bca976875a10bf293f360c1ef6fe9c8.pdf - Error: Command failed: convert -density 600 -colorspace RGB _build/site/public/width_sweep-8bca976875a10bf293f360c1ef6fe9c8.pdf _build/site/public/width_sweep-8bca976875a10bf293f360c1ef6fe9c8.png
2023-07-31T13:42:43.9809205Z convert-im6.q16: attempt to perform an operation not allowed by the security policy `PDF' @ error/constitute.c/IsCoderAuthorized/421.

Seems to be an issue with imagemagick being very cautious with pdf conversion due to a ghostscript vulnerability: https://stackoverflow.com/questions/52998331/imagemagick-security-policy-pdf-blocking-conversion

- run: sudo apt-get update
- run: sudo apt-get -y install ghostscript
- run: sudo sed -i '/domain="coder" rights="none"/d' /etc/ImageMagick-6/policy.xml

This cirvumvents the bug. We should probably also mmake sure to install Ghostscript ≥9.24 to avoid the vulnurability

Love this, thank you! I think that if we start to make our own action #453, then we could start to incorporate these there for everyone. Right now the myst init --gh-pages puts you off on your own to add these (which can be good, but doesn't allow centralized updates!). There is an action we could start to copy here:
https://github.com/curvenote/action-myst-publish
Ideally a myst build github action that is configurable with PDF etc. (download latex, install packages, don't do it if you don't need to) would be super helpful, and be part of the pages deployment action as well.


FATAL/NON_FATAL wrt the error codes

FW_ERROR_FATAL/NON_FATAL registers are entered with error code values by F/W for different errors can you point out which of the listed error codes in below link are Fatal and which are Non-Fatal?
https://github.com/chipsalliance/caliptra-sw/blob/main/error/src/lib.rs

There's not really a strong mapping between error codes and whether they're fatal or non-fatal. In some cases it's context-dependent. For example, an image validation error encountered during cold-boot would be fatal, but a validation error encountered during hitless update would be non-fatal.


Add Valgrind

Add Valgrind for C and C++ targets to find memory leaks ASAP. JS just uses --run.
This can be reverted if the Valgrind does not work or is not needed in the future.

Requisites

Needs https://github.com/nim-lang/Nim/pull/22346 to be merged first!.

Why?

https://github.com/nim-lang/Nim/issues/22255#issuecomment-1646974743

@ringabout Feel free to revert if you see any problems.

No merge.
https://discord.com/channels/371759389889003530/768367394547957761/1135079123375640716


Very slow

Running the gradle plugin on an empty project (the default from the tutorial) is very slow compared to the official make file.
Can this be improved?

I tried hard to improve the startup time of Sphinx but most attempts ended up with failure. The main bottleneck is Jython and it takes quite a bit of time for loading various modules.

We may want to switch to the official Python interpreter using https://github.com/pantsbuild/pex or something similar, but never tried yet.

Just released sphinx-gradle-plugin-2.0.0 which should reduce the build time significantly. Could you let me know if the new release helps you as well?

Just released 2.0.2 with some fixes.

According to my test, a project that took 50 seconds to generate now takes only 12 seconds. Please open a new issue if you still have performance issues after upgrading.

I wanted to quickly check the speed improvement but I got this error:
AttributeError: module 'sphinx_bootstrap_theme' has no attribute 'get_html_theme_path'
It might be my mistake though. I'm in a rush right now.

That's interesting. Are you using sphinx_bootstrap_theme in your project? If so, could you try with the default theme? If not, could you share your project?

I guess it will just work if you remove the following line from your conf.py:
html_theme_path = sphinx_bootstrap_theme.get_html_theme_path()

Sphinx will find the theme just fine without that statement.

Actually, it seems not to be the case for sphinx_bootstrap_theme. I didn't notice this issue because I was using sphinx_rtd_theme, which works just fine without html_theme_path. Until I fix this issue properly, could you try using sphinx_rtd_theme to see if the problem goes away?

Just released sphinx-gradle-plugin 2.2.0 which should fix this problem. Could you please give it a try?

Windows 10, Intel i7-7500U, 16GB RAM, Samsung SSD

Cool. I was somewhat worried about Windows performance because Windows tends to be slower than *nix OSes in terms of temporary file creation.


Make CommonCrypto dependency work for both Swift <4.2 and Swift 4.2 (CommonCrypto is public)

In Swift 4.2 and Xcode 10.0 the CommonCrypto framework became publicly available in iOS. For this reason, we had to remove the modulemap. For doing this, while keeping backward compatibility with later versions, we used an elegant method from @radianttap, who used a Build phase to check for CommonCrypto existence.
p.s.: Thanks @radianttap. I hope you are fine that I used your elegant handler.

Oh nice catch @mattrubin, I tried to see if the patch works in another 3rd party lib and it worked nicely in Xcode 9, so I thought of just copy it here without testing it below Xcode10. Nice lesson for me, to not trust any code, likely Travis catch it.

I was never quite able to get this new approach working when building with CocoaPods, and now I've just updated the whole project to build with Xcode 10, removing the need for the modulemap shims. Thank you to @ziogaschr for the PR!

I am glad there is a better way of doing this @mattrubin. Thx for maintaining this lib.


feat: add getStatusPurpose method

What this PR changes/adds
This PR adds a method getStatusPurpose to the RevocationListService that returns either the active status ("suspension", "revocation") or null if no status is active.
Why it does that
In IdentityHub we need to update the internal status of a VerifiableCredentialResource depending on this status.
Further notes
Linked Issue(s)

added  Result#successNullable(@Nullable T content), because results can be successful and still carry no data.

Relates https://github.com/eclipse-edc/IdentityHub/issues/340
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

Codecov Report
Attention: Patch coverage is 0% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 19.02%. Comparing base (7f20ba5) to head (5ef6f06).
 Consider uploading reports for the commit cd42a65 to get more accurate results

Files
Patch %
Lines

...lecredentials/StatusList2021RevocationService.java
0.00%
21 Missing :warning:

...c/main/java/org/eclipse/edc/spi/result/Result.java
0.00%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4172       +/-   ##
===========================================
- Coverage   71.74%   19.02%   -52.72%
===========================================
  Files         919     1007       +88
  Lines       18457    20472     +2015
  Branches     1037     1153      +116
===========================================
- Hits        13242     3895     -9347
- Misses       4756    16464    +11708
+ Partials      459      113      -346

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


2.0.1 dataclasses have a incorrect types that don't match carnality

Based on the OCPP spec (page 379),  IdTokenType should have an optional list for additional_info attribute (see the cardinality of additionalInfo in the spec : 0..*).

Current version (0..1) :

@dataclass
class IdTokenType:
    """
    Contains a case insensitive identifier to use for the authorization and the
    type of authorization to support multiple forms of identifiers.
    IdTokenType is used by: AuthorizationData, Common:IdTokenInfoType,
    RequestStartTransactionRequest, AuthorizeRequest, TransactionEventRequest,
    ReserveNowRequest, CustomerInformationRequest
    """

    id_token: str
    type: enums.IdTokenType
    additional_info: Optional[AdditionalInfoType] = None

Correct version (0..*) ? :

@dataclass
class IdTokenType:
    """
    Contains a case insensitive identifier to use for the authorization and the
    type of authorization to support multiple forms of identifiers.
    IdTokenType is used by: AuthorizationData, Common:IdTokenInfoType,
    RequestStartTransactionRequest, AuthorizeRequest, TransactionEventRequest,
    ReserveNowRequest, CustomerInformationRequest
    """

    id_token: str
    type: enums.IdTokenType
    additional_info: Optional[List[AdditionalInfoType]] = None

Thank-you for raising this; so from the schema snippet below IdTokenType is defined as being an array, however, there appears to be inconsistency with type declarations - I'll change this to a bug.
	"IdTokenType": { 	  "description": "Contains a case insensitive identifier to use for the authorization and the type of authorization to support multiple forms of identifiers.\r\n", 	  "javaType": "IdToken", 	  "type": "object", 	  "additionalProperties": false, 	  "properties": { 		"customData": { 		  "$ref": "#/definitions/CustomDataType" 		}, 		"additionalInfo": { 		  "type": "array", 		  "additionalItems": false, 		  "items": { 			"$ref": "#/definitions/AdditionalInfoType" 		  }, 		  "minItems": 1 		}, 		"idToken": { 		  "description": "IdToken is case insensitive. Might hold the hidden id of an RFID tag, but can for example also contain a UUID.\r\n", 		  "type": "string", 		  "maxLength": 36 		}, 		"type": { 		  "$ref": "#/definitions/IdTokenEnumType" 		} 	  }, 	  "required": [ 		"idToken", 		"type" 	  ] 	},

PR approved in https://github.com/mobilityhouse/ocpp/pull/529 will be included in v1.0.0


SPACESHIP_2FA_SMS_DEFAULT_PHONE_NUMBER not recognising my phone number

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description
It seems the matcher for SPACESHIP_2FA_SMS_DEFAULT_PHONE_NUMBER is not able to recognise my phone number.
Command executed
I am trying to set SPACESHIP_2FA_SMS_DEFAULT_PHONE_NUMBER environmental variable to a number with the following format:
+91 xxxxxxxxxx
Complete output when running fastlane, including the stack trace and command used

Environment variable `SPACESHIP_2FA_SMS_DEFAULT_PHONE_NUMBER` is set, automatically requesting 2FA token via SMS to that number
SPACESHIP_2FA_SMS_DEFAULT_PHONE_NUMBER = *************

...

Could not find a matching phone number to ************* in [{"numberWithDialCode"=>"+91 •••••• •••60", "pushMode"=>"sms", "obfuscatedNumber"=>"•••••• •••60", "id"=>1}].
Make sure your environment variable is set to the correct phone number.
If it is, please open an issue at https://github.com/fastlane/fastlane/issues/new and include this output so we can fix our matcher. Thanks.

Did you try setting the env variable without the space?
Can you please create a list of the exact value you set the ENV var to, and what exactly it output? Might very well be that Apple handles your phone number in another special way that we might have to add there.

I also tried it without the space:
+91xxxxxxxxxx
Here is my output:
Could not find a matching phone number to ************* in [{"numberWithDialCode"=>"+91 •••••• •••60", "pushMode"=>"sms", "obfuscatedNumber"=>"•••••• •••60", "id"=>1}].
Thanks!

So the things you mentioned:
+91xxxxxxxxxx
+91 •••••• •••60
•••••• •••60
Which can be reformatted as:
+91 xxxxxx xxxx
+91 •••••• •••60
    •••••• •••60

This shows that your real number has 1 number less than what Apple sends back. Is that correct?

Yes I verified my number is correct and it seems it's one number less.

Hm, I wanted to start working on this and added your number to the test: https://github.com/fastlane/fastlane/pull/15743 Surprisingly it did find the phone number from the Apple response correctly and everything worked. So it seems I might be missing something :/
Does the +91 xxxxxxxxxx you are using as EVN var include a leading 0 for the actual number or something like that?
Can you maybe take a screenshot of your Apple ID web interface thing where it has the phone number under "TRUSTED PHONE NUMBERS"? (Of course feel free to replace one or two numbers with a black block to hide it.)
If you feel comfortable about that, send me an email to<EMAIL_ADDRESS>with the actual number with no x and screenshot with no black bars.

@wintermoon9 Did you have time to look at my response? I would like to reproduce and fix this for you.


[BUG] proto codec is not able to write errors

Describe the bug

What are you trying to do?

I am trying to return an error from my RPC service with a protobuf protocol (codec proto)

What did you expect to happen?

Error is encoded and written properly

What happens instead?

A hidden (see #1900) log message is written (i.e. nothing happens)
How to reproduce the bug:
Using v2.9.1, just return an error in from the protobuf handler

func MyHandler(ctx context.Context, req *proto.Request, rsp *proto.Response) error {
	return errors.New("this is an error")
}

I debug the code a little:
The hidden error:
https://github.com/micro/go-micro/blob/94bd1025a64eaaba1d89189891ef49f3ab5eee7f/server/rpc_server.go#L437
It is cause because
https://github.com/micro/go-micro/blob/94bd1025a64eaaba1d89189891ef49f3ab5eee7f/server/rpc_server.go#L425
fills in nil for b (second function parameter)
This ends up (via rpc_codec.go) in (so b = nil):
https://github.com/micro/go-micro/blob/94bd1025a64eaaba1d89189891ef49f3ab5eee7f/codec/proto/proto.go#L36
Which returns the (hidden) error.
When looking at JSON codec
https://github.com/micro/go-micro/blob/94bd1025a64eaaba1d89189891ef49f3ab5eee7f/codec/json/json.go#L34
it just returns (nil) in this case, preventing the error from occurring.

Can we also have this fixed on the 2.9 branch?

The 2.9 branch was just for the release

Ok makes sense.
Can we instead have a v2.9.2 release with this fix and maybe some other interesting fixes (assuming there are)?
It is an issue for basically everyone using one of these codecs, and I suppose people will keep on using v2 for a while for their (existing) projects

Any update?
The fix was v3, but the go-plugins still use v2.9.1.

With the recent announcement and change of ownership/project intentions, I doubt it will be released in a v2.9.x release... :cry:


Wildmenu option for vim not displaying

Wildmenu option for vim does not display the options. It does, however, remove the airline information (as it would in the terminal) but the text simply isn't there.

I believe it may be a bug where the reverse option isn't correctly handled in all cases in the (msgpack_rpc)[https://neovim.io/doc/user/msgpack_rpc.html] API.
Are you using a custom colorscheme?

I'm using solarized dark truecolor, as you suggested (or maybe it was the vimR guys?) to use for gui. Other than that, I don't have any of my own customisations to the color

The issue went away when I changed to wombat, I'll screw around with some settings and see if I can make it work.

I tried Molokai with no tweaks, airline disabled, and it has issues. I can't actually take a good screenshot on mac because the meta key seems like it isn't handled

Update: In a similar vein (pertaining to the colorschemes) certain errors ( use ! to force ) don't display or are highlighted improperly in the statusline.  I think for solarized it might just be that the colors end up hiding the text, as molokai and wombat display them in wrong colors

I was just taking a quick look at this... I believe I can reproduce it reliably like this:

:colorscheme monokai
:color
Press

The highlight for the second colorscheme is messed up - the background color is okay (it's yellow as it should be), but the foreground color is white instead of gray.
In Screen.ts there is some code for handling this:
                let foregroundColor = this._currentHighlight.foregroundColor ? this._currentHighlight.foregroundColor : this._foregroundColor
                let backgroundColor = this._currentHighlight.backgroundColor ? this._currentHighlight.backgroundColor : this._backgroundColor

                if (this._currentHighlight.reverse) {
                    const temp = foregroundColor
                    foregroundColor = backgroundColor
                    backgroundColor = temp
                }

But reverse isn't being set to true, and I don't see it being set.
There's also some interesting stuff happening in NeovimInstance.ts where we directly process the message:
            } else if (command === "highlight_set") {

                const count = a.length

                const highlightInfo = a[count - 1][0]

                this.emit("action", Actions.setHighlight(
                    !!highlightInfo.bold,
                    !!highlightInfo.italic,
                    !!highlightInfo.reverse,
                    !!highlightInfo.underline,
                    !!highlightInfo.undercurl,
                    highlightInfo.foreground,
                    highlightInfo.background,
                ))

Particularly the a[count - 1] - there were some cases we were getting multiple highlight calls, and only the last one seemed to be valid. This isn't hitting that case though.
It would be interesting to see how this behaves in other Neovim front-ends - there's a possibility that it is a Neovim bug.

This is old and no longer relevant with either solarized or default


ci: fix report-on-vuln image ref

Current situation

Proposal

Pull Request Test Coverage Report for Build<PHONE_NUMBER>6
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 67.829%

Totals

Change from base Build<PHONE_NUMBER>9:
0.0%

Covered Lines:
175

Relevant Lines:
258

💛  - Coveralls


feat(atomic): added atomic-result-multi-text

https://coveord.atlassian.net/browse/KIT-885
This component displays multiple field values.
Potentially, it could replace atomic-result-text, but that would require adding highlighting to it and may look weird to accessibility tools. Otherwise, it could be renamed. I originally named this component atomic-result-set in the design doc.
This component supports a slot for individual fields. E.g.:
<atomic-result-multi-text field="language">
  🇯🇵 Japanese
</atomic-result-multi-text>

As for the name.... Maybe atomic-truncable-result-text ?
To highlight the fact that the main use is to truncate long values.
— @olamothe

I didn't think of its main use as truncating values, but rather as being able to display a multi-value field and have some control over both the amount of them shown and their individual appearance. For this reason, I still feel like multi-text or something like it is preferable, whichever term is the closest match with the index's nomenclature.


Use fs module to perform rm -rf and cp commands in cross-platform way

Adds utils/cp.js and utils/rm.js which use the fs module from the standard library to perform rm -rf and cp commands in a cross-platform way.

I opted not to use fancy CLI parsing libraries for the two utility scripts, we have such simple specific use cases that it feels like over-engineering to me.

Removes rimraf dependency; don't need all that baggage just to rm -rf a folder.
Adds .vscode to .gitignore; recommendations are good but other things like local user config shouldn't be committed to the repository.

Looks great, thanks so much for the fix! Merging into 22-multiple-apps and then merging from there into main.


Use new ProgressBar component from Resources in ServiceInventory table

Hey team! Please add your planning poker estimate with ZenHub @andraskvr @Stijnkool


idea: rename package to tailwindcss-wp-global-styles

The application of this library is any WP theme (headless or otherwise) that wants to use the generated global stylesheet with TailwindCSS, and uses nothing intrinsic to FaustJS.
Changing the name will get more eyes/users on this lib.

tailwindcss-wp-theme?

I think that implies that this package is a theme, and not a bridge between a global stylesheet and tw classes, but honestly however you drop faust is good.

Do you have a suggestion?

not beyond  tailwindcss-wp-global-styles

Done


Adding suggested changes

Checklist:

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[x] Have you successfully ran tests with your changes locally?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?

Issues Solved
Fixes #65

@rossoskull Can you test this on Linux?

Yes, I am using RHEL (Unix based system) and it's working fine on my system


[WIP] Thread safety and Coupling between Workflow/Plugin

Changes [WIP]
1. Thread Safety
SLU Service/API generally has a single Workflow object in memory that is responsible for execution of plugins across all requests and maintaining their respective state (input/output) variables. While that in itself is not problematic, Workflow is writing to shared state variables. Since it also has to accommodate requests from concurrent threads, it is doing so with the help of a synchronisation primitive lock order to prevent a race condition. Thread safety in this context is a solution to a problem we invented.
Additionally, Workflow implements reset and flush auxiliary functions for maintaining state variables.
This MR removes the original problem i.e. writing to shared state variables and strips all the bloat needed for synchronisation.
2. Coupling between Workflow/Plugin
There is tight control and data coupling between Workflow and Plugin. This is most evident in set function implemented by Workflow that syncs the output of a plugin with the internal state variables thereby compensating for the input/output asymmetry of a plugin utility function. However, set is called from a plugin base method __call__. Since change 1 moves internal state variables out of Workflow, Plugin no longer has to depend on it to maintain symmetry.
This MR moves the set function to Plugin and reduces it's coupling with Workflow.

Closing this. Making a new cleaner MR for v1


Kick mines (real)

A content addition from PJB? Rare.

Please give it a hit box smaller than a tile as otherwise it’s in essence 3X3 tiles because it’s nearly impossible to perfectly travel through exactly one tile

Please give it a hit box smaller than a tile as otherwise it’s in essence 3X3 tiles because it’s nearly impossible to perfectly travel through exactly one tile

It already has a hitbox smaller than a tile...

there is no more public api for creating a popup at screencoordinates, pls fix. other than that, lgtm

fug I forgor, I'll do it later