drivers: i2c: remove usage of bitfield access for cfg

Cleanup I2C drivers to not use bitfield access for config information
and instead use accessor macros that use shifts & masks.  This is
cleanup towards removing the bitfield access in the future.
Signed-off-by: Kumar Gala<EMAIL_ADDRESS>

So I think we should remove usage of union dev_config.  We can than work on cleaning up the I2C APIs to address actual issues, and mark i2c_configure as deprecated and look to replace it with something that makes more sense.

Will mark the union deprecated after cleanup patch to have users stop using it as well.

While at it, I'd like to review the way we configure I2C devices.  The configuration bitmask is quite arcane; a few separate configuration options in Kconfig would be much better IMHO.  Those options can be encoded in a number and these macros can be used -- but let's at least make things slightly easier for the user.

If there are no further comments could we merge this PR?

I only now had a look in more detail and this, and while this patch looks good, here's some comments:

There's nothing wrong to use bitfields per se, for internal application structures.
But, the information in them should be accessed only by the bitfields defined (no aliasing via masks for example).
It's not OK to access external data structures (hardware registers, wire protocols, etc/) using bitfields, because the C standard doesn't define an order in which bitfields are allocated.

My understanding that union dev_config is Zephyr internal structure, so it could stay as a bitfield, per criterion 1 above. But, it must be accessed only as bitfields, not via things like I2C_SPEED_SHIFT, which violates criterion 2.
Well, that works too, the issue is that this patch started with fixing on the biggest problem with bitfields in the codebase. Also, while this patch fixes it, we have new patches coming which repeat the same problem: https://github.com/zephyrproject-rtos/zephyr/pull/1374/files#diff-143ef7e2f9cab80902967611a47af88eR12

@mnkp : I hope you agree with the above formulation. The question: who'll crusade to have it fixed elsewhere, or at least so that new cases aren't introduced, while folks trying to get old fixed? ;-)

@pfalcon Points 1 to 3 are a good summary of the issue.

That's true we were free to choose one or the other. C style bit-fields are valid and useful language feature. However me and @galak argued in favor of using masks/defines while @andyross in favor of C style bit-fields. The (short) discussion can be looked up on the Jira issue ZEP-2579 page.
The usage of bit fields in #1374 is indeed incorrect, well spotted. Are you going to add your comment to this PR?

@mnkp:

The usage of bit fields in #1374 is indeed incorrect, well spotted. Are you going to add your comment to this PR?

I added, yep (with a disclaimer that I don't want to block merging because of it.)


Add ObjectLight data for Dorgesh-Kaan

this should close #3 👍🏻

Looks really good, fantastic work 117!


Missing non-anon mode and deletion link

The tool is useful, but it would be even better if you could opt into uploading an image in non-anonymous mode, so it would be linked to your account, and you'd have a way of deleting it.
In anonymous mode, the tool should print out the deletion link.

@salty-horse Thanks for the issue! I enjoyed writing this little tool, but I don't intend to maintain it.
It's MIT Licensed though, so feel free to fork it and do whatever you see fit!


[CLI] bal push command has invalid instruction

Steps to reproduce.

Delete the target dir from your project.
run bal push

D:\test\alpha3\factorial>bal push
ballerina: cannot find bala file for the package: factorial. Run 'bal build' to compile and generate the bala.

It says to run bal build But it should be bal build -c

D:\test\alpha3\factorial>bal build

Compiling source
        hasitha/factorial:0.1.5

Generating executable
        target\bin\factorial.jar

Run bal push again. You get the same error message.

D:\test\alpha3\factorial>bal push
ballerina: cannot find bala file for the package: factorial. Run 'bal build' to compile and generate the bala.

Duplicate of #29347


getElements method is not returning any elements when class options are used

Version 0.1.8

BackofficeRolesManagment

file.txt

@nedelcurzvn The issue seems to be fixed, please upgrade to the latest version and let me know if it works :)

@nedelcurzvn The issue seems to be fixed, please upgrade to the latest version and let me know if it works :)

Will do, it's some work beside upgrading, will take a look as soon as possible

const privilageList = html.getElements('tr'); -  works well now
const privilageList = html.getElements('tr', [{
name: 'class',
value: 'element'
}]); - still returns empty list


Copyright looks changed

This PR https://github.com/cakephp/phinx/pull/1119 changes Copyright. I believe this may have been missed.

@robmorgan , @lorenzo thoughts ?

I think you do not replace the name but add it. Like here: https://github.com/cakephp/chronos/blob/master/LICENSE

@Iandenh Thank you for the suggestion. I don't have any problem with that.
I was looking at https://github.com/cakephp/phinx/pull/1119/files#diff-85987f48f1258d9ee486e3191495582dR44 and the author @robmorgan himself changed there. I can consider changing as suggested. Let us give some time and hear what others say about the same.
Thank you.

Sorry I deliberately haven't changed the license yet, because I'm checking with @phpnut about the actual legality. I will properly have to sign some transfer paperwork first.

Thank you for making it clear @robmorgan .

May be we close this PR ?

@phpnut any ideas? should we add CakePHP alongside my name?

Closing for now.


add basic unit tests for current available files

In "IFC.js" discord channel we discussed using "jest" as a testing framework.

the PR #27


Installation Instructions?

Hi, wanted to use it. Can't find it in Pycharm plugins or repositories. Could you please add installation? I also downloaded the repo and trying to import setting mypy-plugin.jar, It didn't work. Please let me know if I am doing something wrong.
Thanks :)

Yes, sorry, I will add installation steps. It should be quite simple:

Download mypy-plugin/mypy-plugin.jar
In PyCharm go to Preferences -> Plugins -> Install plugins from disc -> Select this file -> Restart PyCharm when prompted.
After restart you should find the plugin in View -> Tool windows -> Mypy terminal

Does this work for you?

Just a note: The plugin requires mypy to be already installed.

@ilevkivskyi Thanks for your response.

Alright, I am able to install it but not able to make it work properly. Getting /bin/bash: dmypy: command not found
Which is strange since I have mypy installed.

Sorry for bothering with these small issues. Just excited to get it to work.

This means you need to configure the PATH prefix. Right click on mypy terminal -> Configure plugin. There you need to enter the place where you installed mypy. It looks like you are using virtualenv, this means mypy is installed there, so you need to enter ~/.virtualenvs/celery/bin (like in your Python version on the screenshot above, but without Python at the end). Does this work now?

Indeed. That was the issue. Thanks for your help. Really appreciate it. 👍


First change nwe branch

I assume this was opened by accident.

Yes, it was an accident. Sorry

NP :smiley: (We get lots of these.)


How to cooperate with withAnimation(...) when switching PopupOpen

Instead of opening an issue, start a discussion here: https://github.com/LeoNatan/LNPopupUI/discussions/new

I don’t think this is possible given the SwiftUI-UIKit bridging API. Sorry


Agency 4 Pilot: Teams 2.7 possible bug

feature is noted by Agency 4 to not be available in GCC but was marked as a "PASS". Agency 5 was noted to fail this policy so further investigation into the check and policy is requested.

Reviewed 12/14
@ahuynhMITRE @adhilto Please review and close if this is OBE.
If it is still valid, please assign a size label.
Also, I'd like to see more details in the description, including how to re-create the problem.

OBE by https://github.com/cisagov/ScubaGear/pull/333.


Fatal error: Uncaught InvalidArgumentException

(Please search existing issues before creating a new one.)
Sample:
Expected Behavior

Fowarded to website to approve access to gapi

Actual Behavior
Terminal throws an error:
Fatal error: Uncaught InvalidArgumentException: missing the required redirect URI in /Users/e32398/Sites/composer_test/vendor/google/auth/src/OAuth2.php:650
Stack trace:
#0 /Users/e32398/Sites/composer_test/vendor/google/apiclient/src/Google/Client.php(339): Google\Auth\OAuth2->buildFullAuthorizationUri(Array)
#1 /Users/e32398/Sites/composer_test/quickstart.php(26): Google_Client->createAuthUrl()
#2 /Users/e32398/Sites/composer_test/quickstart.php(58): getClient()
#3 {main}
thrown in /Users/e32398/Sites/composer_test/vendor/google/auth/src/OAuth2.php on line 650
Steps to Reproduce the Problem

Installed composer and composer packages
created credentials in API console selecting server side access. Created user for credentials as project owner
Copy php to quickstart.php and ran php quickstart.php

Specifications

PHP version (php -v): 7.1.7
OS (Mac/Linux/Windows): 10.13.1

Which quickstart is this from?

Hello! So you will need to set the redirect URI in your Google_Client instance before calling createAuthUrl. For example:
$client = new Google_Client();
$client->setRedirectUri('https://mywebsite.com/auth/callback');
$client->setAuthConfig('/path/to/service_account.json');
$url = $client->createAuthUrl();

@asrivas  PHP Quickstart for the google sheets api v4

I had download an incorrectly configured crednetials.json file as i must have selected the wront prefrences. As suchh im closing this issue, thanks for your input @asrivas  and @bshaffer


Improve readability of examples in verlet.cpp

make functions return time
assign value to vars at declaration
use next_pos var name instead of tmp_pos (delete comment)

BUMP


the first video frame is not decoded

Log
16:25:31.414  I  mdk.INFO: 16:25:31.414: video stream#0 1st<EMAIL_ADDRESS>to be decoded has no key frame, skip!!!!!!!!!!!!!!!!!!!

iff lowLatency > 0


Enhancement of logging for typos in dependencies block

Expected Behavior
Proper warning that points to line number or at least some hint about the error. Definitely not "java.util.ConcurrentModificationException (no error message)"
Current Behavior
Gradle fails with a weird error (no error message):
A problem occurred configuring project ':issue'.
> Could not determine the dependencies of null.
   > Could not resolve all dependencies for configuration ':issue:classpath'.
      > java.util.ConcurrentModificationException (no error message)

Context (optional)
If you will occasionally miss a line where you wanted to copy-paste an implementation, you will get a significant problem with debugging of your gradle scripts.
Steps to Reproduce
Errorneous copy-paste costs a huge amount of time to investigate such issues:
dependencies {
    implementation(libs.kotlin.gradle.plugin) {
    implementation(libs.kotlin.gradle.plugin)
}
}

Gradle version
8.1.1

This is related: https://github.com/gradle/gradle/issues/23005

Thank you for providing a valid reproducer.
The issue is in the backlog of the relevant team, but this area of Gradle is currently not a focus one, so it might take a while before a fix is made.


[Feature] We need a unified log system + unified exception handling + push service

What would you like to be added:
We need a unified log system + unified exception handling + push service
Why is this needed:

Unified log system
At present, hypertrons only outputs a few logs, and the log format is not uniform. When a bug occurs in the system, these logs cannot provide sufficient information for troubleshooting. Therefore, we need to collect more fine-grained logs, and the logs have a uniform format.

Unified exception handling + push service
When an exception occurs, we should handle it uniformly, and push it out when needed.

I think these three things are different, maybe split to three issues?

I think these three things are different, maybe split to three issues?

Good idea


ConsentToTrack flag throws error.

ConsentToTrack is a settable attribute when adding to a subscription. https://www.campaignmonitor.com/api/subscribers/#adding-a-subscriber
However adding "ConsentToTrack": "Yes" to user details on either subscribers.addSubscriber() or subscribers.updateSubscriber() returns "SyntaxError: Unexpected string".

Experiencing this as well sendClassicEmail


fix: update bytecode matching for coverage

Motivation
ref https://github.com/foundry-rs/foundry/issues/6875#issueacomment-2180523566
Solution
Update find_by_{deployed,creation}_code to not exit after first diff_score < 0.1, but instead try matching until the minimal diff score is found.
cc @grandizzy this fixes the issue for https://github.com/grandizzy/forge-coverage-bug/tree/master though not sure about other repos

confirming it fixes sparklend issue too :tada:


Infinite loop

https://github.com/stompgem/stomp/commit/864ab4e5b847132c8882945efee59a58ea0aa0de produces the following error:
Your bundle requires gems that depend on each other, creating an infinite loop. Please remove gem 'stomp' and try again.

Yes I am aware of this.
See:
https://github.com/stompgem/stomp/pull/133
But that PR does not fix everything.
I will get a fix out later today ..... when I know what the fix should be.

Thanks

OK, so try install of 1.4.3 please.
See https://github.com/stompgem/stomp/pull/133 for updated thoughts.
The Gemfile was totally removed, so if you use 'bundle' YMMV.

I confirm it works. Thank you :+1:

Closing per confirmation.


Old branches

Someone should review all the old branches in this repository and remove the unused ones.

There's only 10 branches, so this isn't a pressing issue


method_with_annotation test

Add e2e test for sources and sinks marked using method_with_annotation.

Hi Pascal, please let me know if you have any issue with signing the CLA.

Hi Pascal, please let me know if you have any issue with signing the CLA.

Hi Jules, thank you for your message! My manager, Peter O'Hearn, sent an email to<EMAIL_ADDRESS>and asked them to add me to the CLA he submitted before for Lacework to contribute to Meta projects. I messaged<EMAIL_ADDRESS>again last week to ask about the status of that, but did not receive a response.
Can you confirm that I have been added to the CLA on behalf of Lacework, and it is now just a matter of me also signing the CLA personally?

Thanks for flagging @pkesseli, I'm following this up internally. We need to add you to the existing CLA, nothing to do on your end.

Similar to https://github.com/facebook/infer/pull/1723 I'll be happy to merge it when CLA is ready


Support source file blacklist

A customization variable for source file blacklist. For those paths, do not call cmake-ide--locate-cmakelists automatically.
;;;###autoload
(defun cmake-ide-maybe-run-cmake ()
  "Run CMake if the compilation database JSON file is not found."
  (interactive)
  (cmake-ide-maybe-start-rdm)
  (if (cmake-ide--need-to-run-cmake)
      (cmake-ide-run-cmake)
    (progn
      (cmake-ide--add-file-to-buffer-list)
      (cmake-ide--on-cmake-finished))))

What's the use case?

For a large project (say llvm), doing a cmake every time is painful. It should be controlled by the user, not done in the background.

I guess you mean it's slow when you visit a new file?
CMake isn't run every time, but stat calls might indeed be issued.
I don't think a source file blacklist would be the way forward for this use case, but maybe a variable that turns off running cmake automatically. Would that be ok?

maybe a variable that turns off running cmake automatically

That will be useful!

I was looking at the source today to add the variable, but @MaskRay: are you sure the problem is cmake running? After running the first time, cmake should only run if you add a file to the project.

that's would be very useful.
sometimes when I visit a file occasionally,  i just want to have a peak of the source code in another project
having a way to control what folder or files run cmake-ide would be very very nice!!!
i am having the problem of having so many cmake tmp files in my /tmp cucrrently as I am navigating many projecs which  also makes the RC and RDM slow.


Fix missing headE implementation

In latest reflex the headE is moved to MonadHold class, that causes runtime errors:
src/Reflex/Host/App/Internal.hs:209:10-48: No instance nor default method for class operation headE

Thanks!


Increasing the dispatcher rate limit

The dispatcher server receives an argument called --rate-limit. How to set this up using this docker image?

This haven't been on my radar till now. It should be fairly easy to extend, you just need to add necessary code to read environment variable here: bin/dispatcher_start.sh.
Would you be willing to create pull request for that?

Closed by 8596920 and 6cb5465.


fix: #2579 (no writer found): Weaver rollback to september 19, 2020

WIP
works on 2020 LTS
no more 'no writer found' errors because the magic doesn't exist anymore.
MERGE, DONT SQUASH.
first commit is simply the rollback and tests made working again.
next commits will be cherry picking the last 6 months of weaver changes.
works in ummorpg: https://gyazo.com/232931bfd4debf03006f4002774b2a7d

BTW people probably need to delete their library folder once

original bug was probably fixed now.
leaving this PR open for consideration.


Prevent that test cases start two inmanta server

Description
This PR applies the following changes:

Ensure that test cases don't accidentally start two Inmanta server side-by-side by using the client fixture
Ensure that the close_connection_poo() method catches the CancelledError as well in case the task was cancelled by the server fixture
Fix typing problems related to the _connection_pool attribute

closes #3802
Self Check:

[x] Attached issue to pull request
[x] Changelog entry
[x] Type annotations are present
[x] Code is clear and sufficiently documented
[x] No (preventable) type errors (check using make mypy or make mypy-diff)
[x] Sufficient test cases (reproduces the bug/tests the requested feature)
[x] Correct, in line with design
[ ] End user documentation is included or an issue is created for end-user documentation

Reviewer Checklist:

[ ] Sufficient test cases (reproduces the bug/tests the requested feature)
[ ] Code is clear and sufficiently documented
[ ] Correct, in line with design

Processing this pull request

Merged into branches master, iso5 in 915f77b21334a29369932ff1c1e882f4be369989

Processing #3811.


Threshold and cells

Dear @AlbertPun  and @dfriedma ,
These are more questions than issues, I hope it fits here.
-I was wondering how does the network behave in the presence of neuronal bodies present in the images, is it able to remove them? Or should we clean them up before inference?
-The threshold variable is set at a default of 0.01...what does it represent? As far as I understand, if the chunk to be processed in the network has a maximum value higher than threshold then it will be added to the queue. Fine. But what does this value represent? Whatever shade that is not pitch black, right? Is it in float32 or int16?
Thanks!
A

(1) It doesn't recognize cell bodies, just fibers. In some cases, when the cell bodies are very bright, it can impact the ability to identify the most local fibers nearby, but I suspect this could be adjusted with a little extra training. Future versions will hopefully have multi-class output for cells and fibers from the same channel.
(2) You're on the right track. The threshold is to exclude chunks that are outside the brain to speed up inference. Since the sample values are normalized between 0-1, a threshold of 0.01 excludes cubes with a max value < 656 (assuming 16-bit raw data).

Thanks for the replies. Very instructive and clear.
I have been testing it on my own dataset and facing some issues which might be related to the acquisition:
-I am looking at the barrel cortex axons coming from the thalamus. Thats a very dense projection of axons where the network is having trouble (to be honest it would be impossible also for me to tell individual axons apart). Do you have any type of solution or future ideas to deal with densely packed fibers? The obvious solution, of course, is to image at higher resolution (2.5X instead of 0.8X for example) but that involves much bigger datasets...
-What function are you using for skeletonization in 3D? Skimage skeletonization_3d? I havent found a perfect solution here. This one works well but...I have the impression I see too many disconnected small segments.

If you prefer I can open a new issue for this but since I mentioned using my dataset, I just came across a weird pattern in the segmented output of the network:

In both test images, the raw data (inverted LUT) on the left, segmented corresponding plane on the right...what is that squared pattern that you can see in the segmented frames? It appears as if the network fails to...properly align back the batches (each "square" is 36by36 pixels)? I can see the checker-board pattern in every single image of the segmented stack. No idea what is going on.

-I am looking at the barrel cortex axons coming from the thalamus. Thats a very dense projection of axons where the network is having trouble (to be honest it would be impossible also for me to tell individual axons apart). Do you have any type of solution or future ideas to deal with densely packed fibers? The obvious solution, of course, is to image at higher resolution (2.5X instead of 0.8X for example) but that involves much bigger datasets...

Looking at your examples and hearing your description, I would agree that it’s too dense for the current model. The barrel cortex projections we show in Fig. 4 were imaged at higher optical zoom. As with the layer I cortical axons in Fig. 4, if a “fiber type” is not covered in the training set, it won’t be segmented. While we have good coverage of brain regions and background textures, different cell types will inevitably have different appearances in their terminals, necessitating some transfer learning.
As we expand our user base, we hope to be able to update our model as it improves with new training data.

-What function are you using for skeletonization in 3D? Skimage skeletonization_3d? I havent found a perfect solution here. This one works well but...I have the impression I see too many disconnected small segments.

Yes, that’s the skeletonization function we use. It’s up to you if you want to use our weighted design or not. Small disconnected objects can be identified and later categorized and removed with something like MATLAB’s bwconncomp and regionprops3.

In both test images, the raw data (inverted LUT) on the left, segmented corresponding plane on the right...what is that squared pattern that you can see in the segmented frames? It appears as if the network fails to...properly align back the batches (each "square" is 36by36 pixels)? I can see the checker-board pattern in every single image of the segmented stack. No idea what is going on.

That checkerboard pattern can appear when and object or texture dominates a single cube to the point that the network “gives up” on finding axons in the region. In your examples, the very dense barrels are not being identified as axons and are dominating nearby voxels. Some transfer learning with denser labeling or higher mag imaging might help.

Thanks for your reply @dfriedma
I will play with bwconncomp and regionprops3 to clean up disconnected components.
Hopefully I will not have such dense projections in my experimental data (this was a test brain) but if I find it, I will try to train the network on them. Regarding the training, is the current network available here trained only in datasets with 4.0625 um/px resolution? Or does it include some data also at higher resolution? Does it matter at all actually?

It all is at 4.0625 um/vx, but in practice, augmentation allows for axons of different apparent size. It's likely that there just has to be a little separation between the fibers in order to identify them as fibers and not splotches in background. Your clearing quality looks nice! It'll work out. I'm working on getting a new model for higher density regions now as well, but haven't finalized things yet.

Sounds good, looking forward!

Reopening this, because I came up with another question:
How do you deal with the variability in fluorescence intensity of axons and background among different brains? I am thinking at 2 levels:
-For the network, I guess it will take into account the difference between background and signal to determine whether a row of pixels is an axon or not, right? I mean that it might be difficult for the network to identify axons if the brain has a high level of background compared to another with the same axonal intensity but lower background.
-For quantification purposes comparing several brains, I saw that in Figure 7E from "Serotonin Neurons in the Dorsal and Medial Raphe Nuclei: from Single-Cell Transcriptomes to Whole-Brain Projections" for example, according to the figure legend I gather you take the cleaned up skeleton and normalize each region to the region volume and to "total axon content per brain"...what is exactly this measure and how do you calculate it?

-What function are you using for skeletonization in 3D? Skimage skeletonization_3d? I havent found a perfect solution here. This one works well but...I have the impression I see too many disconnected small segments.

Yes, that’s the skeletonization function we use.

We use this function, too, but are currently looking for an alternative due to this bug: https://github.com/scikit-image/scikit-image/issues/3757 So I would be careful with the results.

Reopening this, because I came up with another question:
How do you deal with the variability in fluorescence intensity of axons and background among different brains? I am thinking at 2 levels:
-For the network, I guess it will take into account the difference between background and signal to determine whether a row of pixels is an axon or not, right? I mean that it might be difficult for the network to identify axons if the brain has a high level of background compared to another with the same axonal intensity but lower background.
-For quantification purposes comparing several brains, I saw that in Figure 7E from "Serotonin Neurons in the Dorsal and Medial Raphe Nuclei: from Single-Cell Transcriptomes to Whole-Brain Projections" for example, according to the figure legend I gather you take the cleaned up skeleton and normalize each region to the region volume and to "total axon content per brain"...what is exactly this measure and how do you calculate it?

Very sorry for such a late reply, I only saw you reopened this now, but I thought it's worth answering if anyone has the same question! We did not normalize the volumes because we lost too much information (raw intensity is important for axon identification). For example, a noisy image of very low intensity would begin to look like axons if you normalized it.
Instead, we took our training set and augmented with random scaling and constants additions. This created a training set that was diverse enough in axon intensity to perform well on our validation set.
For quantification, if you see the skeletonization_3d is leading to disconnected components, you can lower the confidence from 0.5 to say 0.3. If you are still unhappy with the results, you can also use some classical post-processing filters such as removing small components or filtering out shapes.
Let me know if you have anymore questions!

Hi Albert, thanks for the reply!
Only if you could reply to the second question, that would be great:

-For quantification purposes comparing several brains, I saw that in Figure 7E from "Serotonin Neurons in the Dorsal and Medial Raphe Nuclei: from Single-Cell Transcriptomes to Whole-Brain Projections" for example, according to the figure legend I gather you take the cleaned up skeleton and normalize each region to the region volume and to "total axon content per brain"...what is exactly this measure and how do you calculate it?

Thanks!

I can speak to the quantification strategy--
We have two separate normalizations in the analysis. Step (1) is to the volume of the annotated region. e.g. the CP is huge compared to the SCN and we want to start with a "density" metric rather than a "total axon length" metric. Step (2) is to the total sum of cleaned-up skeleton. In practice this levels out variability across animals due to injection volume for example. It does introduce a bias in the interpretation of the results (which we viewed as favorable, but depending on your data it may be better to leave this step out). Namely, a projection pattern with very specific projections only to very small nuclei will have inflated numbers. This reduces the ability to compare "densities" across animals, but emphasizes instead a value related to the "importance" of that target region in this specific set of projections. Hope that helps!


Docker upgrades

This PR includes:

[x] Publish images to Github Container registry in addition to Dockerhub
[x] Rework Github workflow using Docker metatdata action:

More flexibility when creating image tags
Set OCI standard image labels, see https://github.com/opencontainers/image-spec/blob/main/annotations.md
Additional images for each maior and minor release version, e.g.

: 16-3.4-4 references latest minor version of v4 -> 16-3.4-4.4.0
: 16-3.4-4.2 references latest minor version of v4 -> 16-3.4-4.2.9

[x] Sunset image versions, that have reached end of life:

https://www.postgresql.org/support/versioning/: <= PostgreSQL v10

[x] If possible, find a better way to set latest tag
[ ] Update documentation

Hi @BWibo, what's the status of this PR? Are you working on it?

@clausnagel
Hey, it's ready. Only thing missing is updating the docs.

@clausnagel @yaozhihang @thomashkolbe
Do you agree with sunsetting the EOL Postgres versions? I assume nobody will miss them.

@clausnagel @yaozhihang @thomashkolbe Do you agree with sunsetting the EOL Postgres versions? I assume nobody will miss them.

Absolutely. We should not offer Docker images which might have vulnerabilities. And end-of-life versions do not receive security updates anymore.
For the same reason, we changed the system requirements in the online documentation. It now says that PostgreSQL 11 or higher is required.

I think we can leave out Postges 11 too. It's EOL is 9th of November 2023.

Yes, agree.

I think we can leave out Postges 11 too. It's EOL is 9th of November 2023.

Yes, agree.

@clausnagel @yaozhihang @muratkendir One more thing we should discuss. Do we have use for images build for every commit to a PR? For instance:

Push commit abc1234 to the v5-devel branch, which feeds the PR with event number #8 .
Following images are built and published on ghcr.io:

ghcr.io/3dcitydb/3dcitydb-pg:pr-8 --> This image is build from the latest commit of the PR.
ghcr.io/3dcitydb/3dcitydb-pg:pr-8-abc1234 --> This image is build for a sepcific commit.

If we want to keep the registry of the release versions clean of dev images, we could introduce e.g.  ghcr.io/3dcitydb/3dcitydb-pg-dev.
Every now and then, we should delete the PR images. E.g. when a PR is merged/closed.

Personally, I don't see the need for having dev images that are built from PRs and even commits inside a PR.

I agree.

Prof. Dr. Thomas H. Kolbe  -  Chair of Geoinformatics
Dept. of Aerospace and Geodesy
TUM School of Engineering and Design
Technische Universität München
Arcisstr. 21, 80333 München, Germany
Tel.: +49 89 28923888  WWW: https://www.asg.ed.tum.de/gis/
Am 04.11.2023 um 12:10 schrieb Claus Nagel @.***>:

Personally, I don't see the need for having dev images that are built from PRs and even commits inside a PR.
—
Reply to this email directly, view it on GitHubhttps://github.com/3dcitydb/3dcitydb/pull/207#issuecomment-1793414219, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABUILVSAQUZREJ46BYRP7ODYCYPCPAVCNFSM6AAAAAA6OMTTB2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJTGQYTIMRRHE.
You are receiving this because you were mentioned.Message ID: @.***>


Swift Package Manager

Hi,
Is there any plan to add Swift Package Manager to the PM options in addition to Pods and Carthage? I don't imagine it would be any trouble / cause any issues, it would only take a tiny amount of code and I would really appreciate it.
Thanks
Peter

I actually looked into this, but because of the massive amounts of non-Swift code in AudioKit (lots of C++ and Objective-C), it doesn't seem like we would be able to do this with the Swift package manager at the moment. Maybe if they ever expand their build options...
These days the easiest way to use AudioKit would be via CocoaPods.

FWI Apple's documentation now says:

Swift packages are reusable components of Swift, Objective-C, Objective-C++, C, or C++ code that developers can use in their projects.
Seems SwiftPM is a lot more production ready after WWDC19. Maybe it would be worth it to look into it again? Would love to be be able to ditch CocoaPods. 🙌

I can take another look but last I checked after WWDC19 it still didn't seem to be a good fit... Even the infrastructure to put out xcframeworks breaks with AudioKit and the current version of Xcode.

You're the expert. The whole reason I would like support for SwiftPM is that I am not. Adding CocoaPods is a bit of an overhead in my world, whereas using SwiftPM is not.
Thank's for the answer either way. You can look into it if you want, but if you say that it is not a good fit, I Believe you. 👍

Looks like starting with Xcode 12 it should be possible to distribute AudioKit.xcframework as a Swift package: https://developer.apple.com/videos/play/wwdc2020/10147

Yeah, lets see if @megastep and I can make this happen.

Funny you mention that now, I was looking into it yesterday and was gonna start working on it today but got sidetracked... Anyway, yeah now that we can ship binary xcframeworks it's very much back on the roadmap.
The way they do it is a bit awkward so we may have to do it through a separate repo, but it should be doable.

I have tentatively integrated this with the AudioKit 5.0 beta, and Xcode 12 / Swift 5.3 SPM.
More info on this repo: https://github.com/AudioKit/AudioKitSPM

I'm going to call this "addressed" in that we have a lot of issue piling up and Stephane is on this.


Please release a version with support for Apache Spark 2.2.x

Please release a version with support for Apache Spark 2.2.x

Hi, I would be great if you could push the released version into Maven

Does this library support Spark 2.3.0? Trying to setup spark joins between 2 different rabbitmq streams

Guys have you tested it against 2.2.x or 2.3.x?
Almost every application I've developed worked out-of-the box with any Spark 2.x version :)
So are you experiencing any error? Or never have even tested it?


Repository Admin: please remove allowance to merge

@jow-
Please remove myself from the list of git-users allowed to merge pulls inside this repository.
Many thanks
Christian

@chris5560 - done. And thanks for all your work in the past.


Expose delimiter parameter for file object for S3/GCS pattern matching

Please describe the feature you'd like to see
Currently, we are not exposing the delimiter parameter for pattern resolution for S3 and GCS file locations. Which significantly limits the use of external files.
Describe the solution you'd like
Expose a delimiter which then is passed to the upstream API calls.
Additional context
Add any other context about the feature request here.
Acceptance Criteria

[ ] All checks and tests in the CI should pass
[ ] Add an example in docs with the usage

Can we use / repurpose the "filetype" arg we have for that? thoughts?

This is not required anymore as discussed with the team. Hence closing for now.


Revert "Update autoroller builder to pass a flutter owned gcs bucket."

Reverts flutter/infra#109
Builder groups are not showing up in console

TBR


Update auth, dynamodb, s3, sqs to 2.17.107

Updates

software.amazon.awssdk:auth
software.amazon.awssdk:dynamodb
software.amazon.awssdk:s3
software.amazon.awssdk:sqs

from 2.17.66 to 2.17.107.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "software.amazon.awssdk" } ]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #801.


Update page content yaml files to be consistent

The filenames for the yaml files for pages are all over the place. Take some time to rename them to be consistent across the board. I don't have specific guidance. We can go over it if you need help, but otherwise setup a PR and I'll help revise names as needed.

Updated YAML file names according to the routes.


generating cluster fsid failed if ansible_python_interpreter is set

If the user has set the ansible_python_interpreter, ansible will not try to discover python, so discovered_python_interpreter will not be set.
Solution: Use ansible_python_interpreter as fallback, if discovered_python_interpreter is unset.

another option could be to set discovered_python_interpreter early in the playbook when ansible_python_interpreter is defined?
otherwise falling back is fine but there are a couple of other places where it needs to be done:
roles/ceph-facts/tasks/facts.yml:109:    command: "{{ discovered_interpreter_python }} -c 'import uuid; print(str(uuid.uuid4()))'"
roles/ceph-handler/templates/restart_mon_daemon.sh.j2:22:  $DOCKER_EXEC ceph --cluster {{ cluster }} -s --format json | "{{ discovered_interpreter_python }}" -c 'import sys, json; exit(0) if "{{ monitor_name }}" in json.load(sys.stdin)["quorum_names"] else exit(1)' && exit 0
roles/ceph-handler/templates/restart_osd_daemon.sh.j2:7:  num_pgs=$($container_exec ceph $CEPH_CLI -s -f json | "{{ discovered_interpreter_python }}" -c 'import sys, json; print(json.load(sys.stdin)["pgmap"]["num_pgs"])')
roles/ceph-handler/templates/restart_osd_daemon.sh.j2:12:    test "$($container_exec ceph $CEPH_CLI -s -f json | "{{ discovered_interpreter_python }}" -c 'import sys, json; print(json.load(sys.stdin)["pgmap"]["num_pgs"])')" -eq "$($container_exec ceph $CEPH_CLI -s -f json | "{{ discovered_interpreter_python }}" -c 'import sys, json; print(sum ( [ i["count"] for i in json.load(sys.stdin)["pgmap"]["pgs_by_state"] if "active+clean" in i["state_name"]]))')"
roles/ceph-mon/tasks/deploy_monitors.yml:14:    {{ discovered_interpreter_python }} -c "import os ; import struct ;

another option could be to set discovered_python_interpreter early in the playbook when ansible_python_interpreter is defined?

Sure, sounds like this needs to be fixed properly.
In which place should I put this? I'll try to do this tonight...

I think early in ceph-facts role is the right place

Please have a look if this seems like a valid solution.

I guess this should be backported to stable-4.0?


Brand icons missing

icon missing

Originally posted by @wifi75 in https://github.com/petrleocompel/hikaxpro_hacs/issues/2#issuecomment-1438440005

We need to add icon to https://github.com/home-assistant/brands to have it available.

How to install it?

We need to wait fro the pull request in home-assistant/brands closed. No need for installation. Then it will automatically display the icon from HA server.

https://github.com/home-assistant/brands/pull/4144 is closed we can close issue. Should be online in day

v.0.5.0
perfect!
thank you

@wifi75 upgrade to v0.5.1 there was a bug with status of sensors


helm/deployment: Add topologySpreadConstraints.

This PR adds support for topologySpreadConstraints.
Tests on workload clusters (not always required)
For changes in the chart, chart templates, and ingress controller container images, I executed the following tests
to verify them working in live enviromnents:

Test / Provider
AWS
Azure
KVM

Upgrade from previous version

Existing Ingress resources are reconciled correctly

Fresh install

Fresh Ingress resources are reconciled correctly

Testing was done using hello-world-app.
Hint for KVM:
kubectl port-forward -n kube-system svc/nginx-ingress-controller-app 8080:80
ingress_domain=host.configured.in.ingress; curl --connect-to "$ingress_domain:80:<IP_ADDRESS>:8080" "http://$ingress_domain" -v

Related issue: https://github.com/giantswarm/giantswarm/issues/21426


Webview scroll jumps erratically when scrolled fast enough

Bug description:

Scrolling inside webview is not behaving properly, when you scroll fast enough, it jumps erratically. This doesn't happen when you scroll slowly though.
To Reproduce:

Freshly created project using react-native-webview 5.12.1.
<WebView source={{uri: "https://mnurrahman.com"}} />

Expected behavior:

Scroll normally without jumps when you scroll fast.
Screenshots/Videos:

https://youtu.be/W_44lhPTJ6k
Environment:

OS: Android
OS version: Android 9.0
react-native version: 0.59.5
react-native-webview version: 5.12.1

I can't upgrade the webview to the newest version because of AndroidX. I would like to use react-native-webview version if possible < 6.0. Any help would be appreciated. Thanks!

Experiencing the same issue with version 5.12.0

Is there a way to use the props bounces and decelerationRate in Android? perhaps that could fix this problem.

Any joy on this one? I'm also seeing this behaviour on 10.8.2

I had the same issue on the latest React Native and react-native-webview on Android. The solution was to add this attribute to the <WebView> element:
androidHardwareAccelerationDisabled={false}

Any updates on this?
androidHardwareAccelerationDisabled={false} didn't solve the problem for me, actually it make it worse...

react-native-webview version: 11.6.2

Tested on physical devices (Android 10 and Android 11, both Samsung) and the problem didnt happen


geniekind

Cannot be added via toybox, auto-cancel

This is working fine for me, can you expand upon what the issue is? You should only be able to have one applied at a time if you have polymorph stacking disabled.


css not working on dynamic form with webpack

Hello,
I found somethink that looks like an issue: css is not applyed to form fields in dynamic form when using webpack:

it works well using tns run android
no css with npm run start-android-bundle

I have created a simple projet to reproduce the issue: https://github.com/Serge-SDL/nativescript-webpack-issue
result without webpack (tns run android):

result with webpack (npm run start-android-bundle):

Thansks!

This issue was moved to NativeScript/nativescript-dev-webpack#359

Hi @Serge-SDL,
Thank you for reporting this issue,
I reviewed it and confirm that this is a real problem, I also found that this problem is already reported here. As a workaround, you could use ngClass instead of class, which will also allow applying the styling dynamically. For example:
<StackLayout [formGroup]="form">
            <StackLayout *ngFor="let prop of objectProps">

                <TextField [formControlName]="prop.key" [id]="prop.key" [ngClass]="prop.cssClass"></TextField>
            </StackLayout>

        </StackLayout>

Ok thanks for informations and workaround! works well 👍


Can not drag out sidebar when activity bar and sidebar hidden

Issue Type: Bug
zend mode is a good function. I can sliding to the right and it show side bar in vscode 1.40.

but it can not do it in vscode 1.43

VS Code version: Code 1.43.0 (78a4c91400152c0f27ba4d363eb56d2835f9903a, 2020-03-09T19:47:57.235Z)
OS version: Windows_NT x64 10.0.18363

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-6500U CPU @ 2.50GHz (4 x 2592)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.89GB (11.89GB free)

Process Argv
D:\Program Files\AutoHotkey\Script

Screen Reader
no

VM
0%

Extensions (1)

Extension
Author (truncated)
Version

git-project-manager
fel
1.7.1

I would reword it as "Cannot display the side bar by dragging from the left side of the screen while in zen mode"

Thanks for the suggestion, I have renamed this issue.
I blieve this is an issue with the new layout, thus forwarding to @sbatten

@sbatten This is a consequence of our decision here: https://github.com/microsoft/vscode/issues/84315#issuecomment-554126812

Should fullscreen veto that?

I think so. The ideal user scenario allows them to do this when it is unambiguous.

can anybody  fix the bug? It's been six months.

I'm sorry but the changes in this PR make no sense. It feels you just started deleting code and stopped when your issue got fixed.
Please follow the discussion in: #92709 (comment) The fix should be related to full screen mode being enabled.

Hello, @joaomoreno  I hope you can compile the source yourself to experience whether the problem is solved. I debugged it on the master branch and solved it.
The bug has nothing to do with full screen，The problem will also occur when the window is normal size(master source). it can not drag out sidebar when activity bar and sidebar hidden. when the activity bar or the sidebar hidden, there is a problem with the absolute size of vscode windows
I try to find the line that caused the bug. There is a problem with the calculation of the two variables in the code, and this judgment is meaningless, so I deleted it and the problem was solved.
absoluteSize

	if (this._endSnappingEnabled === endSnappingEnabled) {
			return;
		}


Parallel forked and joined deployments could do with an example

What would the release pipeline definition look like?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d9e313c5-9120-9172-bc27-c21d10fcd5ae
Version Independent ID: 1a837182-591f-3cbc-1632-7b50d857b13c
Content: Release triggers for stages, branches, and pipelines - Azure Pipelines
Content Source: docs/pipelines/release/triggers.md
Product: devops
Technology: devops-cicd
GitHub Login: @RoopeshNair
Microsoft Alias: ronai

I believe it is captured in this section: "Parallel forked and joined deployments". Let us know if you are looking for something else here. Thank you

@RoopeshNair if it was, I wouldn't have asked.

@StingyJack  - here is the screenshot from the doc link shared earlier. The image has the release pipeline stage settings for running it in parallel (forking) and joining the stage workflows. Let me know if I'm missing something

@RoopeshNair - that is a logical depiction. I'm asking for an actual example, because as far as I can tell, two stages cannot join back into one.

@StingyJack - if you look at Production in the figure, the setting says "After stage" - and the stages selected are "QA" and "Pre-prod". Meaning "Production" stage deployment will not start until both "QA" and "Pre-prod" are completed.

@RoopeshNair  - I think what I am ultimately struggling with is that all these say "After Stage". which means that they will be executed as soon as the deployment to the prior stage is completed. This is kind of ridiculous and means that using this model will move code from dev to QA/Pre-prod to Prod without testing being completed in any of those environments.  Adding a approval gate can help with this, but the definition of the promotion path gets lost when choosing manual.
For example, with those selections, I do get the rejoining lines, and a very specific promotion path

however by selecting Manual triggering, I lose any kind of enforcement on the promotion path

And we can deploy right to prod and bypass any other environments.

they will be executed as soon as the deployment to the prior stage is completed. This is kind of ridiculous and means that using this model will move code from dev to QA/Pre-prod to Prod without testing being completed in any of those environments.

I'm not sure I got this. Isn't QA/Pre-prod supposed to include testing too? Are you referring to Manual testing? If yes, I would recommend checking out "Manual Intervention" (MI) step.  With MI step in QA/Pre-prod stage, tester can sign-off and push the button to promote the release. Your pipeline structure remains intact and will the stage dependencies. Let me know if it helps

Isn't QA/Pre-prod supposed to include testing too? Are you referring to Manual testing?

Yes, the QA/Pre-Prod environments include testing, and that is the point I am trying to make. When you have these automated deployment triggers as are configured in the parallel and forked deployments example, there is nothing prevent a release from being instantly promoted to  the next environment at the moment the prior stage deployment is complete.
The MI step is for a deployment in progress. It would have to be used in its own stage in between the conventional stages in order to be effective, but that seems to be "bloaty".
Is there no way to preserve/enforce a promotion path with these tools that does not also require automatic deployments or crazy tasks or configuration?

Not really, deployment to production that is dependent on QA and Pre-Prod will not start until both QA and Pre-prod stages complete. Maybe we can have quick call?

A stage being complete means that all activity for that stage is completed, not just the deployment steps in a release pipeline for that stage.
Consider this schedule...
11:00  - build produces artifact
11:01 - release is created from artifact
11:02 - release deployment begins to DEV
11:05 - release deployment completed to DEV

11:06 - release deployment begins to QA
11:06 - release deployment begins to Pre-Prod
11:09 - release deployment completed to QA
11:09 - release deployment completed to Pre-Prod
11:10 - release deployment begins to Prod
11:10 - release deployment completed to Prod
There isnt any "STOP and wait for testing".  By making them manual triggers, users can bypass stages entirely.

This helps, as described earlier, you define MI step in QA / Pre-prod and assign this to testers so that they can sign-off once done. MI is meant for steps that can't be automated including manual tests


Training from scratch on RTX 3090 doable?

Hi, I was wondering if this is a small model that is suitable for personal training, or is this release more intended for academics with huge funding? If the latter, then I assume fine-tuning at least will be doable?
Cheers!

When the models release, Zach has mentioned that they intend on fine tuning being possible on consumer GPUs. A 3090 should be more than enough for this.

Nice, hopefully that's that coming soon. LoRAs and ControlNets let's hope too!

3090 will be fine for autoencoder training, we will see what the requirements are for further models once they're released


Add a .NET Standard version of TestAdapter

Description
If the test adapter was targeting .NET Standard instead of/in addition to netportable, we could reuse the test discovery and execution on Xamarin.
The asserts. attributes etc are already net standard compatible, so it's really just this missing piece, and we can reuse it across all platforms.
(Of course on Xamarin you'd have to write your own UI to show the tests and execute them / log the results, but that's still less code than what we have to do today where we also have to write discovery and execution ourselves)
AB#1575822

Alternatively, place the portable version of TestAdapter in the \lib\ folder of the nuget package, so it gets deployed to android and ios, and we can call into it from the host app.

This is most likely going to be fixed by #1095

Fixed by #1194


Failing CoreIR Clock Wiring Pass On Nested Map Call

https://github.com/phanrahan/magma/issues/238 enabled the wire-clocks pass to handle modules with an input that is an array of CLK inputs. However, the pass still fails for modules with an input that is an array of arrays of CLK inputs. Running https://github.com/David-Durst/aetherling/blob/2b04d346dcd82dee3691c4e503b9859d1dbef010/tests/test_native_line_buffer.py#L58-L80 fails with the following output:
Testing started at 11:34 PM ...
/Users/durst/anaconda/envs/aetherling/bin/python "/Users/durst/Library/Application Support/JetBrains/Toolbox/apps/PyCharm-P/ch-0/182.3684.100/PyCharm.app/Contents/helpers/pydev/pydevd.py" --multiproc --qt-support=auto --client <IP_ADDRESS> --port 64759 --file "/Users/durst/Library/Application Support/JetBrains/Toolbox/apps/PyCharm-P/ch-0/182.3684.100/PyCharm.app/Contents/helpers/pycharm/_jb_pytest_runner.py" --target test_native_line_buffer.py::test_double_nested_sipo -- -s
Connected to pydev debugger (build 182.3684.100)
pydev debugger: process 36570 is connecting

Launching pytest with arguments -s test_native_line_buffer.py::test_double_nested_sipo in /Users/durst/dev/W17-8/aetherling/tests

============================= test session starts ==============================
platform darwin -- Python 3.6.4, pytest-3.4.2, py-1.5.2, pluggy-0.6.0
rootdir: /Users/durst/dev/W17-8/aetherling, inifile:
collected 1 item
test_native_line_buffer.py In Run Generators
Done running generators
In Run Generators
Done running generators

Assertion failed: (0), function die, file context.cpp, line 112.
Running pass rungenerators
In Run Generators
Done running generators
Running pass wireclocks-coreir
ERROR: mapParallel: Cannot wire together
  self.CLK : coreir.clk[1][1]
  op_0.CLK[0] : coreir.clkIn

I AM DYING!

Process finished with exit code 134 (interrupted by signal 6: SIGABRT)

I don't know if we can automatically wire up an array of clock inputs.
For example, if we have
self.CLK : coreir.clk[2]

and we have two instances
inst0.CLK
inst1.CLK

which index of self.CLK should be wired up to inst0 or inst1?

If it's a 1 element array we could do it, but that seems like a funky special case

I think in this case, it might be best of the generator creating the instances and clock inputs handles the wiring itself? Because in the case of map I'm guessing there's a one to one mapping (clk[i] wires up to inst{i}.clk). Don't know if we can generalize this notion.

So you're asking for wireclocks to handle just a single source clock as an array of 1 element, possibly nested?

You're original issue asked for support for an array of of CLK inputs, which implies more than one clock input

Oh I see, you're just asking for a nested array of arrays of clock inputs to an instance, not in the interface, the wording is confusing.

I think there is still an ordering issue, see this module definition
Module: mapParallel(numInputs:1, operator:aetherlinglib.mapParallel)
  Type: {'O':Bit[4][1][1], 'CE':BitIn[1][1], 'CLK':coreir.clkIn[1][1], 'I':BitIn[1][1]}
  Def? Yes
  Def:
    Instances:
      op_0 : mapParallel(numInputs:1, operator:global.SIPO4CE)
    Connections:
      op_0.CE <=> self.CE[0]
      op_0.CLK <=> self.CLK[0][0]
      op_0.I <=> self.I[0]
      op_0.O <=> self.O[0]

In this case, we could automatically do the wiring op_0.CLK <=> self.CLK[0][0], which I think is what you want, but that only works if self.CLK is a nested array of just 1 element. So this would be special casing wiring a single source clock that just happens to be described as a nested array. If we have a general nested array of arbitrary length, we can't wire that up automatically.
We can add this as a special case to the wire clocks pass

@David-Durst the test now passes for me with d9429b4abddd1acbd64b7739b277ef69417bc795, can you try it out? Changed the logic to detect if a clock is connected to be quite a bit simpler.

@leonardt it works for me now in the doubly nested case. Thanks!


Variable still null after forEach reassignement

Bug Report
🕗 Version & Regression Information
All versions in the playground do have this "bug" (3.3.3 - 4.6.0-dev.20220115)
⏯ Playground Link
Playground link with relevant code
💻 Code
let variable: string | null = null;

[''].forEach(() => {
    variable = 'some string';
});

console.log(variable)

🙁 Actual behavior
variable has the type null
🙂 Expected behavior
variable should have the type string | null (preferably for this usecase only string, but maybe even harder to tackle). I assume this happens as the variable is assigned inside the callback function. I would totally understand this decision when using non-blocking functions such as setTimeout or any async functions. But doesn't this implementation differ from what is possible in the actual runtime? I reported this as a bug because In this specific case variable is always a string and can never be null, instead of the given opposite.

#9998

And another one! Duplicate of #9998

From TS point of view there’s no difference between your forEach call and a setTimeout call.  Both take a function, and TS doesn’t know when that function will be called.  See also https://github.com/microsoft/TypeScript/issues/11498.

Closing this in favor of duplicates. Sorry for the duplicate, but thanks for pointing this out!


Move MSBuild out of the GAC / Registry

See Visual Studio “15”: Installing Just What You Need for context since this relates to the new install experience.
We're in the process of experimenting with shipping MSBuild 1) built directly from the GitHub sources (no internal mirror!) and 2) outside of the registry / GAC. This means we would ship under the Visual Studio installation folder and not install to C:\Program Files (x86)\MSBuild. This isn't set in stone at this point, but I wanted to create this Issue to track progress and get feedback.

Should we close this?

Yup, this is done as of VS2017 Preview 5 (with the new VS installer).

The WiX toolset has a tool called heat that uses MSBuild API's to "harvest" the outputs of a project into the installer. It requires that MSBuild is installed on the target machine, and loads the appropriate version of Microsoft.Build.dll and friends from the GAC based on the ToolsVersion. How are standalone executables supposed to find MSBuild 15 now that it's not installed in the registry or the GAC? Keep in mind that WiX may be installed on a build machine with only the build tools and not VS 2017.  https://github.com/wixtoolset/issues/issues/5490

@rseanhall For VS2017 (including the Build Tools flavor), the right way to locate MSBuild is by using Visual Studio Setup Configuration. There are examples for C++, C#, and VB and a newer PowerShell wrapper that can help guide you. Note that a new wrinkle that you wouldn't have had to consider before is that there can be multiple Visual Studio and MSBuild installations side-by-side. Identifying the correct one can be difficult (maybe a user installed the C++ workload with their Professional edition install, but also has a Community install that doesn't have C++. It's hard to know from the outside that the project you're building needs the C++ install and query for it).

This may not be the appropriate place to ask this, but if MSBuild's assemblies are no longer GAC'd, how can we ensure that custom MSBuild task assemblies pull in the latest versions of these assemblies present on the system?

@SwooshyCueb When loaded as part of a build, the task will use the MSBuild assemblies that match the build's entry point--the entry point's binding redirects should ensure that that is the loaded version. Is that what you're asking?

@rainersigwald I think so, thanks!


Multi-tenancy APIs are not available in the openapi file.

The openapi file has not been updated to include the details for multi-tenancy APIs

Maybe I'm misunderstanding you here, but I have started my aca-py instance(s) with the flags --multitenant --multitenant-admin --jwt-secret ... and I can see the multi-tenancy API in the swagger interface. (I believe the --multitenant-admin flag is the important flag here).

Hey @docmanni, maybe I didn't make it clear in my ticket. What I mean is if I check the "openapi.json" in the path: aries-cloudagent-python/open-api/openapi.json, I can't see multi-tenancy-related API info defined inside it.

@yunxi-zhang This PR should fix your issue: https://github.com/hyperledger/aries-cloudagent-python/pull/1150


fix(ci): solve issues with docker

What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
Same as https://github.com/falcosecurity/plugins/pull/315.
Which issue(s) this PR fixes:
Special notes for your reviewer:

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jasondellaluce
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jasondellaluce, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [jasondellaluce,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: a623639813e90a97ea13c612040331b766db528e


Update datacenters to e5d0d7ac59e1343ef7fce0a5a0056cab8f9cb56e

Thanks! Looks like there are some new updates upstream. Will pull in those & release a new gem shortly.


Fix some styles

This PR fixes some coding and documentation styles.

LGTM, but it's better to add these undocumented rules to contribution guide.
Neither PEP8 nor OpenStack Style Guideline does not define rules of double-quotes and "third person singular form" use.


[Component] Textview

On design we did an Exploration about Textview/area and these are the conclusions:

No external or internal system has a leading & trailing icon in Textview/area.
As open source system we have to provide the best solutions.
From Design we don't know now when it was decided to have leading & trailing icon in Spark.
Not native on iOS and may break the component if we customize it.
We have to remove the leading & trailing icon in Design, Web and Android.

testbranch: component/textview

@aycil-alican I found an a11y issue : in the "traits" key I think we should precise that it's an input.
For now voiceover just read the value or the placeholder, but cannot know that it's an input.

@elisa-hery There is no trait like input for textview. I used native behaviour.


Trigger options when initialization

Hi,
I am sending my currently selected items along with my request throught the server. The problem here is that after refresh the page, the current selected option are not loaded unless I start to write in the search boxes.
It is any way to initializate the loading of the options when the page is loaded and not when the search event start? So build the list of options even when there is no search.
Now the event to bind on the search input element to fire a request is keyup, but I want to bind on the search input element when the page is loaded.
I have tried with the option: bindEvent: "change click keyup". But it is still not working
Thank you

I have tried loading the data with the preprocessData option with selected and preserved as true but then it is always showed as selected even when clicking in the option in order to deselect.

Hi,
Did you find any solution? I'm trying to solve same problem.
Thank you

Hi,
Did you find any solution? I'm trying to solve same problem.
Thank you


Should handle empty/null user-agent

If the request is made by a HttpClient object, the "User-Agent" header is missing. Since there is no empty/null checking in BrowserDetector.GetBrowser method i get this error
System.IndexOutOfRangeException: Index was outside the bounds of the array.
at Microsoft.Extensions.Primitives.StringValues.get_Item(Int32 index)
at Shyjus.BrowserDetection.BrowserDetector.GetBrowser()
Can you please fix this?

Apologies for the delayed response. This issue has been fixed in version 2.0.0. Could you use that please ?
https://www.nuget.org/packages/Shyjus.BrowserDetector/2.0.0


Add skeletal PPP

Add a skeletal PPP for leeyiheng12

Codecov Report

Merging #26 (aad495e) into master (f42999a) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #26   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f42999a...aad495e. Read the comment docs.


Windows nodepool is not supported error with azure-cli version 2.4.0

az feedback auto-generates most of the information requested below, as of CLI version 2.0.62

Describe the bug
In the latest cli version (azure cloudshell azure-cli    2.4.0 *) getting error while adding windows node pool to aks cluster the Error is Windows nodepool is not supported
To Reproduce
Here is the tutorial link
Below are commands to reproduce the issue:
az aks create --resource-group rgname --name AKSCluster --node-count 2 --enable-addons monitoring --kubernetes-version 1.16.7 --generate-ssh-keys --network-plugin azure

az aks nodepool add --resource-group rgname --cluster-name AKSCluster --os-type Windows --name npwin --node-count 1 --kubernetes-version 1.16.7

Error screenshot with --debug option:

Expected behavior
The Add a Windows Server node pool is working as expected in older cli version which I have on my local machine.

Environment summary

Additional context

aks

hi @VikasPullagura-MSFT have you tried install aks-preview extension?

Thanks tried installing the preview and issue is resolved.


docker: npm errors (linux)

This is a regression from v0.136.1.

error log
npm error code EACCES
npm error syscall mkdir
npm error path /var/hugo/.npm
npm error errno -13
npm error
npm error Your cache folder contains root-owned files, due to a bug in
npm error previous versions of npm which has since been addressed.
npm error
npm error To permanently fix this problem, please run:
npm error   sudo chown -R 1000:1000 "/var/hugo/.npm"
npm error Log files were not written due to an error writing to the directory: /var/hugo/.npm/_logs
npm error You can rerun the command with `--loglevel=verbose` to see the logs in your terminal
Watching for changes in /project/{archetypes,assets,content,layouts,package.json,postcss.config.js,static}
Watching for config changes in /project/config/_default, /project/go.mod
Start building sites …
hugo v0.136.2+extended linux/amd64 BuildDate=unknown VendorInfo=docker

ERROR render of "page" failed: "/project/layouts/_default/tailwindcss.html:16:23": execute of template failed: template: _default/tailwindcss.html:16:23: executing "main" at <.Content>: error calling Content: TAILWINDCSS: failed to transform "/temp/css" (application/octet-stream): npm error code EACCES
npm error syscall mkdir
npm error path /var/hugo/.npm
npm error errno EACCES
npm error
npm error Your cache folder contains root-owned files, due to a bug in
npm error previous versions of npm which has since been addressed.
npm error
npm error To permanently fix this problem, please run:
npm error   sudo chown -R 1000:1000 "/var/hugo/.npm"
npm error Log files were not written due to an error writing to the directory: /var/hugo/.npm/_logs
npm error You can rerun the command with `--loglevel=verbose` to see the logs in your terminal
ERROR POSTCSS: failed to transform "/temp/css" (application/octet-stream): npm error code EACCES
npm error syscall mkdir
npm error path /var/hugo/.npm
npm error errno EACCES
npm error
npm error Your cache folder contains root-owned files, due to a bug in
npm error previous versions of npm which has since been addressed.
npm error
npm error To permanently fix this problem, please run:
npm error   sudo chown -R 1000:1000 "/var/hugo/.npm"
npm error Log files were not written due to an error writing to the directory: /var/hugo/.npm/_logs
npm error You can rerun the command with `--loglevel=verbose` to see the logs in your terminal
ERROR TAILWINDCSS: failed to transform "/temp/css" (application/octet-stream): npm error code EACCES
npm error syscall mkdir
npm error path /var/hugo/.npm
npm error errno EACCES
npm error
npm error Your cache folder contains root-owned files, due to a bug in
npm error previous versions of npm which has since been addressed.
npm error
npm error To permanently fix this problem, please run:
npm error   sudo chown -R 1000:1000 "/var/hugo/.npm"
npm error Log files were not written due to an error writing to the directory: /var/hugo/.npm/_logs
npm error You can rerun the command with `--loglevel=verbose` to see the logs in your terminal
Built in 580 ms
Error: error building site: render: failed to render pages: render of "page" failed: "/project/layouts/_default/postcss.html:20:23": execute of template failed: template: _default/postcss.html:20:23: executing "main" at <.Content>: error calling Content: POSTCSS: failed to transform "/temp/css" (application/octet-stream): npm error code EACCES
npm error syscall mkdir
npm error path /var/hugo/.npm
npm error errno EACCES
npm error
npm error Your cache folder contains root-owned files, due to a bug in
npm error previous versions of npm which has since been addressed.
npm error
npm error To permanently fix this problem, please run:
npm error   sudo chown -R 1000:1000 "/var/hugo/.npm"
npm error Log files were not written due to an error writing to the directory: /var/hugo/.npm/_logs
npm error You can rerun the command with `--loglevel=verbose` to see the logs in your terminal

To test:
mkdir -p $HOME/.cache/hugo_cache
git clone https://github.com/jmooring/hugo-docker-test
cd hugo-docker-test
docker run --rm -v .:/project -v $HOME/.cache/hugo_cache:/cache -p 1313:1313 ghcr.io/gohugoio/hugo:v0.136.2 server --bind="<IP_ADDRESS>"

cc: @dvdksn

Maybe the expedient way to fix this issus and #12971 is to remove the npm install stuff from the image. Users would have to run npm ci themselves before running the docker run ... command. An added benefit is that they are running npm ci instead of npm install.

Users would have to run npm ci themselves before running the docker run ... command.

That doesn't (always) work if the host OS is different from container OS, which is fairly common ...


Get rid of integer allocation

@eddyb mentioned that there are plans to get rid of the integer allocation (NEVER_ALLOC_ID). This is an attempt to summarize briefly what the plan is, and to document that such a plan exists. (I suppose the "refactor" label would make sense here?)
The idea is to change the "meaning" of the type Pointer to "pointers that actually point somewhere in memory". Every operation that also works on pointers obtained from integers should use a different type. They could either use PrimVal (but then these methods all have to handle undef...), or a new type that factors the Pointer and Bytes cases out of PrimVal, but cannot be Undef.
ptr-to-int-cast and their inverse literally become a noop on the data side. There is no longer any need to perform "normalization" in binary_op because all data now has a canonical representation. (The memory already does something like this, somewhat, by not adding any relocations when a pointer from the integer allocation is written to memory.)
Open questions:

What about zero-sized types? We could either keep the ZST allocation, or make allocation return an integer when a ZST is allocated.
Which name should the type that's either Pointer or just bytes have? PrimDefVal? I'm not good with names...

We can't remove the ZST allocation. If we did, we might have accidential conversions from integers to.zst pointers. I don't think it's much of an issue: zst pointers aren't handled specially as muh as integer pointers.
Wrt the naming: I think we should turn primval into two nested enums, the PrimVal type which is either Bytes or Pointer and a PrimDef type or sth which is either Undef or Def(PrimVal). This will make pattern matching as easy as it is now, and allow taking out the defined part without any additional effort.

You may rename PrimDef to anything you want ;) MaybeVal?

With Option it'll get messy since I think we do have some Option<PrimVal> in the code somewhere I think

If we were doing this from scratch, I'd probably call the current PrimDef Value, and call the current Value Variable or VariableValue or VariableVal or so.

We don't use "variable" in MIR terminology for all locals. MIR trans would call it LocalRef.
I think LocalVal or LocalValue would work fine.

We don't use "variable" in MIR terminology for all locals.

I see.
Another option may be LocalState, because it describes the current state of a local. Unfortunately, that type sounds like it is talking about "local state" in general. I'd suggest Local if that was not already used for the thing identifying a local...

Local can be renamed to LocalId

There's a reason MIR trans uses the FooRef convention, heh.

Where FooRef is the thing identifying a foo, or saying what state it currently has?

The former, if I'm reading you right. It looks like it was borrowed from LLVM but it doesn't make much sense because there it's used in the C API for the types that are pointers to the C++ classes.

By "the thing identifying a local", I mean the integer which is an index into the list of locals. From the name, that's also what I expect a Ref to be. So then things would be called LocalRef/LocalId (newtype around integer) and Local (that's the by-ref/by-val/by-val-pair thing).
That is, assuming it is even worth renaming this stuff. That's why I said "if we started from scratch" above. ;)

Oh, no, FooRef contains the rustc_trans/LLVM "instance" of mir::Foo.
So LocalRef contains the actual value, either an SSA immediate or an alloca.

Oh. That's odd naming to me... it's not a reference to a local then. I suppose they mean that it's the referent of a local.

No it literally is cargo-culting the LLVM C API, because a SSA value is ValueRef.

I don't think we need the *Ref naming scheme in miri. Let's just stay with SomeThingId and SomeThing

Also I think renaming everything in a more sensible manner is fine. We do have RLS so any renaming should be trivial to do.

(it's not like most renaming isn't just a multi-file regex replacement - I do those in my editor often)
That scheme doesn't work for things like mir::Lvalue, though, does it?

What do you mean? There's no need to rename rustc types. Also lvalue is not an ID. mir::Lvalue is the unresolved lvalue similar to a path, miri::Lvalue is the resolved lvalue containing pointers and such.

If you already have miri::Foo for mir::Foo, why would you need FooId or anything of the sort?
I wonder if people would object to doing the former in rustc_trans.

Uhm we don't. I got it confused with Lvalue::Local. So no mass renaming necessary.

ah, right, mir::Local is in librustc. I forgot about that. Wouldn't it be somewhat confusing to then call the "state of a local" also Local, just in a different module? (This is regarding the proposal to rename the current PrimDef to Local.)
Given these circumstances, I guess I'll go with @eddyb here and prefer LocalVal.

We can't separate Undef from PrimVal, because a PrimVal for a ZST is Undef. Creating a new Zst variant makes no sense, because that has no additional purpose (we discussed that back when ZSTs were moved from always being ByRef to also making them ByVal).

because a PrimVal for a ZST is Undef

What's wrong with Bytes(0) or anything else?

You might be able to do shenigans that end up reading it. But I can't think of any off the top of my head.

(we discussed that back when ZSTs were moved from always being ByRef to also making them ByVal).

Is that discussion available anywhere? I am asking because that would have been my suggestion: Make ZSTs always ByRef, after all, that doesn't even require an allocation. Just a pointer to the ZST allocation.

That was on IRC in rust-internals. search the log for eddyb saying undef I think

Do you remember a rough date? I have no idea whether I am looking for something that happened a month ago or a year ago. A brief search of the git history didn't turn up anything.

I have no clue. I can look in my local logs. But it was something about how zsts should never be read from anyway, so undef as zst makes more sense than a special zst value. But moving to byref to the zst alloc sounds good.

Yeah the point is that the representation doesn't matter not that we should pick a specific one.

It matters insofar as we better be sure that any attempt to observe it throws an error. ;)

But moving to byref to the zst alloc sounds good.

Now you got me confused. Didn't you say above that this is how things used to be, and then they were changed, probably for a reason?

Yea it was changed. But I think that was part of other changes that were easier with that change happening, too

So some other things will get harder if we go back to "ZSTs are always ByRef"?

Yes. We'll have problems with follow_by_ref_value, but I just checked, we don't use it everywhere anymore. I guess we refactored all other uses out. Looks easily doable now, but it'll mean a zst can't be a primval anymore, not sure if we rely on that anywhere else.

I've done some work in this direction: https://github.com/oli-obk/miri/commit/e59ff2305449de92de76b0f76a68045fac158ee8 still has some problems, since the pointers in lvalue need to be able to store integers, too.

the pointers in lvalue need to be able to store integers, too.

When does that arrive? Sounds like an invalid lvalue to me, couldn't that error out instantaneously?

So you didn't end up even using a type that's just "Bytes or Ptr". Is handling the additional Undef case a problem anywhere?

Not yet. It might even be better to include it in some situations, because dereferencing and immediately referencing a pointer with undef value should  fine

You mean like so?
fn main() {
    let x : *const i32 = unsafe { mem::uninitialized() };
    let y = unsafe { &*x };
}

So you are saying, Undef lvalues are fine? I suppose that's an option. That would also explain when "integer pointer" lvalues can arise.

Yes

Sounds reasonable. So the Lvalue::Ptr will change to take a PrimVal? And then I suppose the return lvalue can cease again to be an Option; Undef is covering that case just fine. Nice.


HTML

HTML
User Story
As a bootcamp student
I want the prework notes to be structured webpage
so that I can easily find and read information
Acceptance Criteria
GIVEN a Prework Study Guide website
WHEN I visit the website in my browser
THEN I see four boxes titled HTML, CSS, Git, and JavaScript with associated notes listed

Added four boxes


Add fflush call to print_file_matches

When piping the output of ag into another program results are not seen by the other program until the output buffer is full.
This PR adds a fflush call to print_file_matches so that results are seen as they are generated.

Thanks!


Make Travis run unit tests with apache_test make target

I'm waiting till build succeeds and then will manually check logs to ensure that memcached and redis tests were not skipped.

LGTM, let's wait for travis to finish, then merge.

Oops, we do not have that target in that repository. Looks like I have to run scripts manually from .travis.yml, will do that after refactor which make it easier to run with both memcached and redis.


Example app animation didn't run on Android version 4.2.2 (API 17)

Hi
Example app (https://github.com/airbnb/lottie-react-native/tree/master/example) didn't run on Android version 4.2.2 (API 17) (shows blank screen) but works for Lollipop (Andriod version 5), no error or warning observed in logcat.
On the other hand, Lottie app (see below link) works on Android version 4.2.2 (API 17), maybe it has used lottie-android instead of lottie-react-native (not sure).
https://play.google.com/store/apps/details?id=com.airbnb.lottie
I haven't found any place mentioning the minimum android supported version, does anyone knows what is minSdkVersion for lottie-react-native ?
Thanks

In lottie-react-native/blob/v2.2.7/lib/android/build.gradle , minSdkVersion is set to 16, but it seems animation didn't played even in API 17.

I am facing the same issue in Android 4.2.2 animations are not being showed. With lottie-react-native version < 2.2.7 animations worked in Android 4.2.2, is there any aditional step that I must configure to show the animations?

Downgrading to 2.2.0 did the trick


feat(org): add user group member support

About this change—what it does
Adding organization user group member support.
I cannot add acceptance tests for this feature because the user_id of the newly invited member will be known only after an invitation is accepted. And we cannot simulate this during the test. Moreover, if we invite already existing Aiven users to a different organization, user_id is still unavailable, and we have to accept an invitation.

@ngilles-aiven and @Serpentiel sorry for not been active on this branch, it was blocked by the tests inactive for the organization package but now I'm going to revive this branch.


Autocomplete algorithm

The code that searches for matches for autocompletion at https://github.com/dthree/vorpal/blob/9a8cee1295415f5c3185add7acde6f047571b9f3/lib/session.js#L314-L364 works well for most cases, but it doesn't support, for example, typing the middle of the name of the command. It could perhaps be replaced by one of these libraries somehow.
Would that be a change worth considering? Perhaps we should use extensions for this (and repack the current autocomplete function as an extension)? Perhaps just accepting an option for an autocomplete function during vorpal instantiation?

Not completely related but I used the autocomplete stuff just yesterday for creating tab completition to command arguments (values coming from a known list). I had some difficulties with it but eventually I got it working. I used the callback, commandInstance.match() function and a hacky reference to this.parent.ui.input(). I hope this would not break with the change :)
In case someone is interested the change is in this commit: https://github.com/ristomatti/lifxsh/commit/d342748e992807cd9fbc3c5b1310b73592624849

@fiatjaf got it. Would this suggested functionality mirror a bash CLI? My only requirement is that the autocompletion's functionality is an exact mirror of regular shell functionality. It's not clear when that proposal is. Could you give an exact example for me?

@ristomatti If we changed anything breaking, we would obviously apply semver and bump minor / major versions appropriately.
However, for that very reason you mentioned, I have been thinking of making an alternative, simplified manual autocompletion function, as I agree it currently kind of sucks. Perhaps we could discuss this?

@dthree great ideas! The syntax looks simple enough, especially for the simple list example. But if you consider a list of words:
var words = ['red', 'green', 'blue];

and a command:
vorpal.command('print <words...>', 'Print words');

Would the second example cover a use case where Vorpal would autocomplete the words so that only the ones not already listed would be used as dynamic values?
> print red <tab>
green  blue

Not sure if this would be a very common use case? I was just thinking yesterday how I could extend my current custom autocompletion to work like that...
@fiatjaf sorry for hijacking your issue!

It would do the default Unix-style handling, which in this case would not print anything if red was entered. But if rojo was another color and you entered r, it would print:
> print r
red rojo

I'll have think about that if I get it figured out. :) Not sure what you mean with the default Unix-style handling though. At least on my system (Linux Mint / bash) autocompletion for files works for multiple arguments also but I have to admit I don't remember if it has always been like that.
Anyhow, I don't want to sidetrack the conversation from the original issue more than this. The improvements you suggested would probably help others trying to figure out how the custom autocomplete is supposed to work. Keep up the good work!

Thanks! :+1:
BTW want a sneak peak at my next Vorpal pjt? :smiley:

It looks a lot like an attempt to solve some problems I've always had when using Windows (I've used Cygwin a lot in the past). Really impressive stuff based on just the description and screenshots. I'll definately keep that in mind for those special Windows moments. Thanks for sharing! I'll probably be in contact at some point later on. Namely when I get proper documentation and NPM package done for the current project I'm working on currently (lifxsh), in case you maybe want to consider adding it to

Cool and thanks! Yeah, I'd love to see it.

@fiatjaf @ristomatti ping
I'm mid refactoring the autocompletion as gone over in this thread.
As this is a major refactor and the current design sucks, it's going to include breaking changes. Due to this, I'm going to deprecate command.autocompletion(), and introduce a new command, command.tab().
I wanted to check with you guys (and anyone else who cares) on the name .tab - it's shorter, which is something I like, and makes sense to me as this is tabbed autocompletion. It also matches similar Vorpal semantics, such as command.cancel - it implies the action is being done.
This sound.... sound?

My vote is command.autocomplete, stripping out the existing implementation and doing a major version bump.
I don't think command.tab tells me what it does if I'm just reading code. I might be a little confused.
Your call.

Thanks and I can see that. I just don't like the idea of hitting 2.0 over this little point. I can do autocomplete, but I do want to deprecate the other, and perhaps strip it when I have good enough reason to hit 2.0 (more changes).

I have to say I partly agree with @scotthovestadt on the naming. command.tab does not really tell anything it does. command.autocomplete would in my opinion be semantically similar to command.cancel as it's stating the action to be done instead of what the user does.
I don't see though why stripping the old implementation would be necessary. It can just be marked deprecated and remove it when the major version bump feels more just.

I like command.tab. it is short and means tabbed autocompletion, instead of another kind of bizarre autocompletion that someone could think of.
But since this issue was originally about the builtin autocompletion for command names, not user-provided autocompletion, I must ask: are you doing something about it?

I can't quickly imagine what other autocompletion a user of a CLI module could expect to see, but how about command.tabcomplete? That'd be more descriptive while still being grammatically in the imperative mood.

I like @ristomatti's idea of command.tabcomplete. In terms of command autocompletion, I just submitted a PR to output the list of matching commands (if more than 1), tidy up the longestMatch algorithm and invoke custom autocompletion only when the current command is 'cmd[space]'.  Shouldn't impact the changes we're talking about here by the sounds of it. https://github.com/dthree/vorpal/pull/83

Also, my feeling is that autocompletion would be most awesome per-option. Eg I'd specify .option('--myOpt, 'description', ['val1', 'val2', 'val3'], and when the user enters `cmd --myOpt[space][tab] vorpal would autocomplete/print out the list of valid values.  Python prompt-toolkit does this really nicely - see https://github.com/awslabs/aws-shell

Haha okay thanks for all your guys input! On the votes, we have:
autocomplete +2
tab +1
tabcomplete +2
Next vote will tip it over (and someone can change their mind).

@fiatjaf yes I am! I'm mid a full re-write on autocompletion, not just command autocompletion. However, I need a little more data from you. My last question to you:

Would this suggested functionality mirror a bash CLI? My only requirement is that the autocompletion's functionality is an exact mirror of regular shell functionality. It's not clear when that proposal is. Could you give an exact example for me?

@jeff-1amstudios got it. See #83 for additional discussion on that.

Ok, I'm sorry. I thought about the response to that, so I was kind of thinking that I had already sent it.
The answer is that it depends. What I wanted was actually not to mirror bash. I wanted autocompletion that looked inside the words of the commands, not one that only did prefix match. There's an example on the link I gave: http://fiatjaf.alhur.es/js-search-engines-comparison/ (start typing vor, for example, on the box at the top).
For these three libraries, I would like to use sifter, but since my comment was just an open suggestion and I realize not everyone would like my library, I think my real feature request here is: can somehow customize the autocompletion behavior? Vorpal could provide a smart default, but also a simple endpoint for customization, so I could, when needed, skip Vorpal's default autocompletion algorithm and use sifter.

Thanks. Yeah - I'm going to expose a totally raw method where you can do whatever you want.

Your link isn't pulling up anything for me... Just a Github ribbon. Tried it on Firefox and Chrome... could you possibly just give a quick example of what typing vor would do?

Wait a little, it's heavy javascript! It will load. Or don't. Well, it is just a demo of three autocompletion/fuzzy-search libraries with the same stock of words, which results each library yields. It doesn't matter. Let's forget about this. I'm happy with your refactor, it will solve all problems everywhere.

Haha k. But your idea sounds cool, just trying to understand it.... I'm behind a proxy, so that might explain why the page isn't loading btw...

See https://github.com/dthree/vorpal/pull/83


Added support for Iron MQ v3

use IronMQ API v3
added rate_limit option (new queue option in v3)
added queue info method

A new inspection was created.

The inspection completed: 1 new issues, 1 updated code elements

:+1: :)

Anyone had some time to take a look at this ?

ping @kmfk

A new inspection was created.

The inspection completed: 1 new issues, 1 updated code elements

A new inspection was created.

The inspection completed: 1 new issues, 1 updated code elements

A new inspection was created.

The inspection completed: 1 new issues, 1 updated code elements

A new inspection was created.

The inspection completed: Array

A new inspection was created.

The inspection completed: 29 Issues, 1 Patches

@kmfk can you tag a new version please ?

@tristanbes - v2.2.0 is up


Use Deepl to ad hoc translate app text

Idea needs a Server Component, not possible for android standalone. wont do


BUG:Navbar Icons dont redirect to intended Pages

Is there an existing issue for this?

[X] I have searched the existing issues

What went down?
Description:
The Navbar Icons - Discord and LinkedIn dont Redirect to the intended URL
Expected Behaviour-

Discord Redirects to -https://discord.com/invite/UWTrRhqywt
LinkedIn to - https://www.linkedin.com/company/helpops-hub/

Actual Behaviour-

Discord Redirects to- Discord.com
Linkedin - LinkedIn.com

Video:
https://github.com/mdazfar2/HelpOps-Hub/assets/72603662/1923ffa5-be2e-49b7-a965-3afd64ab1b80
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@shreyash3087 You are assigned ✔


fix: botocore sessions across samcli

fix: botocore sessions across samcli
Why is this change necessary?

This change is necessary to address MFA usecases when caching of credentials is essential.

How does it address the issue?

Use botocore's native json file cache manager.

What side effects does this change have?

Sessions are managed at the cli context level and not anywhere else.

TODO?

Need to check entire codebase for session management.

Depends on:

https://github.com/awslabs/aws-sam-cli/pull/1681

will rebase once https://github.com/awslabs/aws-sam-cli/pull/1681 is merged.


Increase Antenna Range

I am trying to increase the range of my reader using the library feature PCD_SetAntennaGain
I have followed this comment but can't get any improvement https://github.com/miguelbalboa/rfid/pull/47#issuecomment-285860139
Has somebody else managed to see an improvement in range adding an arduino Sketch change? Could you please share your examples?
Many thanks

The improvement by increasing the antenna gain is not huge. More like 0.5 to 1 cm, which is only useful if the reader is covered by a case. For more range you need a different module (eg. wiegand).


Incorrect MutableRefObject typings with --strictNullChecks option enabled

Hi! Thx for the awesome library. I've recently faced an issue with TS typings and prepared a fix (#232)
Here is the issue
Consider this code from the docs that is written in typescript
import { useRef } from 'react';
import { useViewportSpy } from 'beautiful-react-hooks';

const ViewportSpyComponent = () => {
    const ref = useRef<HtmlElement>();
    const isVisible = useViewportSpy(ref);

    return (

                Observed element

                is the observed element in viewport? {isVisible ? 'yes': 'no'}

    );
};

with --strictNullChecks option enabled it gives me the following errors:

TS2345: Argument of type 'MutableRefObject<HTMLElement | undefined>' is not assignable to parameter of type 'MutableRefObject'.   Type 'HTMLElement | undefined' is not assignable to type 'HTMLElement'.     Type 'undefined' is not assignable to type 'HTMLElement'.
TS2322: Type 'MutableRefObject<HTMLElement | undefined>' is not assignable to type 'LegacyRef | undefined'.   Type 'MutableRefObject<HTMLElement | undefined>' is not assignable to type 'RefObject'.     Types of property 'current' are incompatible.       Type 'HTMLElement | undefined' is not assignable to type 'HTMLDivElement | null'.         Type 'undefined' is not assignable to type 'HTMLDivElement | null'.

This issue is valid for all hooks that use MutableRefObject as argument
What can we do to fix this?

Change typings from

export declare const useViewportSpy: (elementRef: MutableRefObject<HTMLElement>, options?: IntersectionObserverInit) => boolean;

to
export declare const useViewportSpy: (elementRef: MutableRefObject<HTMLElement | null | undefined>, options?: IntersectionObserverInit) => boolean;

change the docs to favor useRef(null) over userRef()

Thx!

Hi @joxerTMD
thank you very much, I'm going to check your PR right now


Please mark 0.10.0-M2 pre-release

I am a maintainer of nixpkgs which packages mill, and we have automated update scripts that detect the latest version of this package and try to update to that. Currently, 0.10.0-M2 is marked as the "latest release" in GitHub, so it is trying to use that even though it is probably a pre-release.
Could you please change 0.10.0-M2 to be marked as a pre-release?

Sure. This release ins meant to be a milestone release. It is a proper release though. Users can use it. So downstream packaging still makes sense.


Add a waker() future

Resolves #8. I'm not particularly attached to the name.

Eh, thinking about this, since we can do it with the current library through poll_fn, and it's a pretty niche feature at that, it shouldn't be in this library.


💡 [FEATURE] - <Add-Wagmi  library in web 3>

Idea Contribution

[X] I have read all the feature request issues.
[X] I'm interested in working on this issue
[X] I'm part of GSSOC organization

Explain feature request
Add-Wagmi  library in web 3
Explain your solution
Wagmi is a React Hooks library for Ethereum  Wagmi has a CLI to manage ABIs as well as a robust ecosystem of third-party libraries, RainbowKit, and many more, so you can get started quickly without needing to build everything from scratch.
Any alternative approaches/features
No response
Additional Context
No response

@jfmartinz  plz review this https://github.com/jfmartinz/ResourceHub/pull/808
hope its helpfull