Is it Work with spark 3?

Hello,
Thank you for this great connector.
Is it work with spark 3?
This connector is only supported by this repository? I found in apache bahir repository too.

This should work with Spark 3 because DataSourceV1 works with Spark 3. I haven't tried it myself though.

Hello @abhishekd0907  ,
I am running this connector on EMR 6.1.0 which has Spark 3.0. While running the stream I am getting the below error.
java.util.ServiceConfigurationError: org.apache.spark.sql.sources.DataSourceRegister: Provider org.apache.spark.sql.streaming.sqs.SqsSourceProvider could not be instantiated
at java.util.ServiceLoader.fail(ServiceLoader.java:232)
at java.util.ServiceLoader.access$100(ServiceLoader.java:185)
at java.util.ServiceLoader$LazyIterator.nextService(ServiceLoader.java:384)
at java.util.ServiceLoader$LazyIterator.next(ServiceLoader.java:404)
at java.util.ServiceLoader$1.next(ServiceLoader.java:480)
at scala.collection.convert.Wrappers$JIteratorWrapper.next(Wrappers.scala:44)
at scala.collection.Iterator.foreach(Iterator.scala:941)
at scala.collection.Iterator.foreach$(Iterator.scala:941)
at scala.collection.AbstractIterator.foreach(Iterator.scala:1429)
at scala.collection.IterableLike.foreach(IterableLike.scala:74)
at scala.collection.IterableLike.foreach$(IterableLike.scala:73)
at scala.collection.AbstractIterable.foreach(Iterable.scala:56)
at scala.collection.TraversableLike.filterImpl(TraversableLike.scala:255)
at scala.collection.TraversableLike.filterImpl$(TraversableLike.scala:249)
at scala.collection.AbstractTraversable.filterImpl(Traversable.scala:108)
at scala.collection.TraversableLike.filter(TraversableLike.scala:347)
at scala.collection.TraversableLike.filter$(TraversableLike.scala:347)
at scala.collection.AbstractTraversable.filter(Traversable.scala:108)
at org.apache.spark.sql.execution.datasources.DataSource$.lookupDataSource(DataSource.scala:644)
at org.apache.spark.sql.streaming.DataStreamReader.load(DataStreamReader.scala:194)
... 56 elided
Caused by: java.lang.NoClassDefFoundError: org/apache/spark/internal/Logging$class
at org.apache.spark.sql.streaming.sqs.SqsSourceProvider.(SqsSourceProvider.scala:26)
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
at java.lang.Class.newInstance(Class.java:442)
at java.util.ServiceLoader$LazyIterator.nextService(ServiceLoader.java:380)
... 73 more
Caused by: java.lang.ClassNotFoundException: org.apache.spark.internal.Logging$class
at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
at java.lang.ClassLoader.loadClass(ClassLoader.java:351)
... 80 `more```
Seems like the connector is not compatible with Spark 3.0 on EMR. Also, Spark 3.0 is based on scala 2.12 and the connector is build on scala 2.11.
Can you provide any highlights on this?
Thanks and regards,
Dipesh Vora

Hey,
I did some troubleshooting and found that the class org/apache/spark/internal/Logging$class is not the part of aws's version of spark-core and hence the error.
I have downgarded to spark 2.4 and awaiting the fix on EMR
Thanks,
Dipesh

@abhishekd0907  this seems like a great tool. I  want to use this tool,  are you planning to release this tools with Scala 1.12.  Asking this because I want to use Spark Streaming Web UI with this tool.  Web UI is only available with Scala 1.12.
Thanks

Hey,
I did some troubleshooting and found that the class org/apache/spark/internal/Logging$class is not the part of aws's version of spark-core and hence the error.
I have downgarded to spark 2.4 and awaiting the fix on EMR
Thanks,
Dipesh

@DipeshV  have you been able to get your EMR issue resolved?

@DipeshV
Thanks for the update. It will help in saving time for other folks

@DipeshV
Do you know if there is an open ticket about this issue?
I can't find anything regarding the internal logging class.


Fix datetime decoding when time units are 'days since 0000-01-01 00:00:00'

This fixes #521 using the workaround described in Unidata/netcdf4-python#442.

I have a few general comments,

Can you point me to where in the CF Conventions or UDUNITS the valid time coordinate units defined?
We should think about whether or not this fix belongs in xray or netCDF4.  I am of the opinion that if the CF Conventions do in fact support the units in question, we should apply this fix in the netCDF package. If they don't, I don't think we wan to support it here either.
@shoyer is out for a bit but he will almost certainly want to weigh in on this.

If we end up going this route, you'll want to add some unit tests in test_conventions.py.

Can you point me to where in the CF Conventions or UDUNITS the valid time coordinate units defined?

This edge case is defined here: http://cfconventions.org/Data/cf-conventions/cf-conventions-1.6/build/cf-conventions.html#climatological-statistics
NB: People that follow the COARDS conventions will also need this.  Any Udunits wrapper can deal with that for you:
import cf_units
u = cf_units.Unit('days since 0000-01-01 00:00:00', calendar=cf_units.CALENDAR_NO_LEAP)
ut = u.utime()
ut.num2date(0)  # Returns a fake datetime object (http://scitools.org.uk/iris/docs/latest/iris/iris/unit.html#iris.unit.Unit.num2date)
0-01-01 00:00:00
ut.date2num(datetime(1, 1, 1))  # Note that datetime cannot take year = 0
365.0

We should think about whether or not this fix belongs in xray or netCDF4. I am of the opinion that if the CF Conventions do in fact support the units in question, we should apply this fix in the netCDF package. If they don't, I don't think we wan to support it here either.

I strongly disagree with that.  netCDF is not one CDM and should not follow the CF-conventions!  I know that iris does follow CF very closely (annoyingly in fact) and xray "kind of" follow (which is great BTW).  However, if such conventions were adopted in the netCDF package, how will we load non-CF files?

Note that I am not question the validity of those dates neither its use.  But they are out there and people need to deal with that.  If xray decides to support this it has to be implemented very carefully and with some warnings...

@ocefpaf NCAR is one of the lead institutions in terms of the CF conventions. Yet the CESM POP model, also developed at NCAR, has this "year 0" issue! To me this suggests that any practical, real-world application will need to deal with special cases like this one.

@ocefpaf NCAR is one of the lead institutions in terms of the CF conventions. Yet the CESM POP model, also developed at NCAR, has this "year 0" issue! To me this suggests that any practical, real-world application will need to deal with special cases like this one.

I know :wink: that is why I use cf_units!
PS: do you have an OPenDAP endpoint for you data?  I would like to make a few tests here.

@ocefpaf Unfortunately no OPenDAP endpoint, but I put a sample file on our ftp server
ftp://ftp.ldeo.columbia.edu/pub/rpa/pop_sample/b40.1850.track1.2deg.wcm.007.pop.h.0100-01.nc

@rabernat here is an example on how to read those dates using cf_units (big download for a small example :wink:):
http://nbviewer.ipython.org/gist/ocefpaf/d14bd8ad24f4e1a47b19
My point with this is example is:  netCDF4-python should not do that for you!  And, of xray wants to go down that road, it must be done with some warnings and good documentation!
By accepting these rules (by rules I mean how UDUNITS interpret the dates and that this is part of the CF-convention CDM) you are leaving the world of "read my data" and entering a world of "interpret my data."
cf_units interprets your data as CF-compliant and does what you expect from that CDM.

Here is another example of a dataset with a similar time encoding issue. This is a valid OpenDAP URL:
http://data.nodc.noaa.gov/thredds/dodsC/woa/WOA13/DATAv2/temperature/netcdf/decav/1.00/woa13_decav_t16_01v2.nc
The time units are 'months since 0000-01-01 00:00:00'. This is the very popular World Ocean Atlas. Since it is a monthly climatology, the dates are referenced to year 0.

I would also strongly prefer to get this fix in netCDF4 upstream rather than in xray, if possible.

I would also strongly prefer to get this fix in netCDF4 upstream rather than in xray, if possible.

I disagree.  Maybe not even xray should "fix" this.  There are two issues here:

Interpreting year 0 as 1;
Non-standard calendars.

Maybe (2) should be in np.datetime64 (and pandas), but even that is hard to became a reality.  However, (1) is an UDUNITS aberration interpretation that made into some Conventions (CF and COARDS).  Does xray wants to became a CF CDM?  I sure hope not!  I have iris for that but for everything else I use xray.
And if people really want to get the dates into xray they can just read the raw time data and parse it using  one of the several UDUNITS wrapper or convention checker/compliance out there. Here is another one that should do the right thing here: https://pypi.python.org/pypi/coards/1.0.5

Just so you see how messy this can be.  The year 0000, because it does not exist, is used to store climatology in COARDS and CF.  The coards package issued a warning, but did the wrong thing:
from coards import parse
units = 'days since 0000-01-01 00:00:00'
parse(0, units)
coards/__init__.py:60: UserWarning: Shifted data 366 days to the future, since year zero does not exist.
  UserWarning)
datetime.datetime(1, 1, 1, 0, 0)

If someone accidentally saves that date back with this object it will no longer be year 0 and other CDMs might choke by not recognizing it as climatology.  cf_units does the right thing:
import cf_units
u = cf_units.Unit('days since 0000-01-01 00:00:00', calendar=cf_units.CALENDAR_NO_LEAP)
ut = u.utime()
ut.num2date(0)
0-01-01 00:00:00

But that object is pretty much useless for pandas and xray because of the non-standard calendar.  The object is useful to annotate plots or to save the data metadata back the same way it was before.

@ocefpaf To be clear, by "strongly prefer to get this fix upstream" I mostly meant that I am reluctant to include this in xray.
I would like it to be straightforward for others to extend our reading capabilities for netcdfs by adding custom logic like this for their own equivalent of xray.open_dataset that builds on what we have in xray.

@ocefpaf To be clear, by "strongly prefer to get this fix upstream" I mostly meant that I am reluctant to include this in xray.

Great.  We don't need another interpretation of the CF-standards out there!
See the WOA13 dataset above as an example of the problems this brings. The data has no calendar and use units months since.  CF discourage the use of months for obvious reasons and no calendar translates to:

gregorian or standard Mixed Gregorian/Julian calendar as defined by Udunits.

Which one!  Year zero is invalid in one and (kind of) accepted in the other!!
Long story short: the dataset is valid CF but it is unclear how to interpret the dates.  No one cares because people using that dataset know that t16 means Autumn (Oh no wait!! I am in the South Hemisphere, so that means Spring :stuck_out_tongue_winking_eye:)
PS: Note that there is a none calendar too in the CF conventions that is more adequate for datasets like that.

Ok, thanks for the thoughtful discussion. I understand why you both feel this shouldn't be implemented in xray. My one objection to the discussion is that I don't think that climatological time is such a "niche" issue--processing climate model output (much of which has no specific calendar date associated with it but still has seasonal cycles, etc.) seems like one of the most useful applications for xray.
I come at this from a very practical point of view. I need to use certain datasets (e.g. WOA13, POP model output) for my research and teaching. I want to teach xray in my fall physical oceanography class---it is perfect for teaching because it "just works" and allows students to quickly load data and do basic analysis easily. This PR request would allow me to do that. I understand the counter-arguments, but I don't know exactly how I should proceed if this can't be part of xray. The options seem to be:

Don't use the datasets
Don't use xray
Use xray without time support

Is there something else I'm missing?

I want to teach xray in my fall physical oceanography class

@rabernat I hear you!  I suffer from the same problem.  But I think we should teach students how to defend themselves from bad practices and tools limitations.  (We have both in there!  Talking about non-standard calendar and accepted but non-recommended standards.)

Use xray without time support

Not ideal but that is probably the way to go.  My guess is that you can load the data in xray, but you cannot get those dates into the pandas indexing machinery, right? That is not too bad since there are not many "dates operations" that you can do anyway.  Most of the time we only need to translate the time information into a label for the figures. If that is the case you are OK with the tools we have now.

Regarding the non-standard calendar support, is it worth opening issues in numpy / pandas?

Regarding the non-standard calendar support, is it worth opening issues in numpy / pandas?

Worth? Yes.  Any hope to actually get it in there?  No...

Worth? Yes. Any hope to actually get it in there? No...

I think I disagree.  There is almost no chance anyone outside of the climate community is going to spend time on this but, if calendar support was added in a responsible way to numpy and pandas, I don't see why they wouldn't be interested.  So it will need to come from the climate users community, which IMHO, is under represented in the dev community.
If you don't want open the issue, I will.

@jhamman sorry for making this thread longer than it should.  But I don't think you disagree!   We need a champion from the climate community.  And if either of you open the issue I will be the second man on the hill.

Calendar support is numpy is conceivable, but it will pretty much require fixing numpy dtypes first so that they can be parametrized and extended by third parties in Python (this is on the roadmap). Right now the datetime64 type itself is pretty buggy, in large part because it's written in C code that nobody is maintaining.
.
For pandas, I think the bigger issue is that pandas only does datetime64 with ns resolution. Simply adding us support would go a long ways toward solving this. See here for some discussion on the pandas side: https://github.com/pydata/pandas/issues/7307
On Fri, Aug 14, 2015 at 9:17 AM, Joe Hamman<EMAIL_ADDRESS>wrote:

Worth? Yes. Any hope to actually get it in there? No...
I think I disagree.  There is almost no chance anyone outside of the climate community is going to spend time on this but, if calendar support was added in a responsible way to numpy and pandas, I don't see why they wouldn't be interested.  So it will need to come from the climate users community, which IMHO, is under represented in the dev community.
If you don't want open the issue, I will.

Reply to this email directly or view it on GitHub:
https://github.com/xray/xray/pull/523#issuecomment-131166492

I am the least knowledgeable person here regarding numpy and pandas development. The issues should probably be opened by someone else.

I submitted an feature request over at numpy.  I'm going to close this now.
@rabernat - thanks for the PR and keep them coming.


Update 05.md

I think that exec-start should call the script and not the file which should be created.

Thanks for your contribution, @tammar96!
Looks good :+1:


%op and %pow are not saved correctly

When commands are added they are simplified to an array containing the command (with %op or %pow removed) and the permission level (as a constant) to run at. However, this causes an issue when the block is saved, only the simplified command is available and not the original one.

This is fixed in e9dc9fd58b45409159de5279ec5ecb04131ebc66


In Android, ReactExoplayerView instance doesn't eliminate after JS component unmount.

Bug
Platform

Android

Environment info

Library version: 6.0.0-beta.4
Device: Android
Steps To Reproduce

add below Log within onHostPause method

Log.d(TAG, "onHostPause: " + this.hashCode());

mount <Video /> component
move to background
check log print properly (via Logcat)

ReactExoplayerView      <package name>      D  onHostPause: <instance hash code A>

move to foreground
unmount <Video /> component you created in step 2
mount new <Video /> component
move to background
you can check stacked log

ReactExoplayerView      <package name>      D  onHostPause: <instance hash code A>
ReactExoplayerView      <package name>      D  onHostPause: <instance hash code B>

repeat steps 5~9, you can see the logs overlap by the number of iterations.

Expected behaviour

memory leak
calling unnecessary lifecycle callback

FYI
This is not an issue in v5.2.1., something seems to have gone wrong with the update process so far

PR #3380 missed unmount case
so I made PR #3489

Thanks for PR!, will be included in 6.0.0-beta.5

Hey @VMBindraban, I am planing to make release this week (so max 5 days 😅)


Misleading error message when validate_composer fails due to missing HOME/COMPOSER_HOME

Description
If neither HOME nor COMPOSER_HOME env vars are set, validate_composer will exit with non-zero but the error message is redirected to /dev/null.
I had to fork the repo, remove the output redirection to see the issue:
Error: The HOME or COMPOSER_HOME environment variable must be set for composer to run correctly

My suggestion would be to either add a check for HOME/COMPOSER_HOME being set and adding a targeted error message if not or to show the output of composer validate in case it fails.
The latter would also help with future issues composer validate might have.
Steps to reproduce

Ensure composer.json is valid by running composer validate locally.
Run composer-install in an env where HOME/COMPOSER_HOME are not set (e.g. in a self-hosted runner or maybe by unsetting them via env: [HOME: '', COMPOSER_HOME: ''])
See the action fail.

Expected behavior
composer-install finishes successfully.
Output
Run ${GITHUB_ACTION_PATH}/bin/composer_paths.sh \
Error: The composer.json file at './composer.json' does not validate; run 'composer validate' to check for errors
Error: Process completed with exit code 1.

Environment details

version of this package: 2.2.0
PHP version: 8.0, 8.1, 8.2
OS: Self-hosted runner with Linux x64 (Ubuntu 22.04 LTS)

Additional context
Complete tests.yaml
name: tests

on:
  push:
    branches: [ master ]
  pull_request:
    branches: [ master ]

jobs:
  tests:
    strategy:
      matrix:
        php-versions: ['8.0', '8.1', '8.2']
        dependency-versions: ['lowest', 'highest']

    runs-on: [ self-hosted ]

    steps:
    - name: Checkout
      uses: actions/checkout@v4

    - name: Setup PHP
      uses: shivammathur/setup-php@v2
      with:
        php-version: ${{ matrix.php-versions }}

    - name: Cache Composer packages
      id: composer-cache
      uses: actions/cache@v3
      with:
        path: vendor
        key: ${{ runner.os }}-php-${{ hashFiles('**/composer.lock') }}
        restore-keys: |
          ${{ runner.os }}-php-

    - name: Install dependencies
      uses: researchgate/composer-install@v2
      with:
        dependency-versions: ${{ matrix.dependency-versions }}

    - name: Run test suite
      run: vendor/bin/phpunit

Thank you for the very good description on how to reproduce. I'll look into this.


feat(metrics): remove metrics labels after being collected

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Previously we remove the label immediately when the metrics is dropped. In this PR, we change to only adding the labels to a buffer, and remove the labels after the metrics is collected.
Checklist

[ ] I have written necessary rustdoc comments
[x] I have added necessary unit tests and integration tests
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[x] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

LGTM. BTW and off this PR, is there any labelled metric that's frequently created and dropped? If so, we may have to take care of the performance for accessing the global map.

Batch metrics.

LGTM. BTW and off this PR, is there any labelled metric that's frequently created and dropped? If so, we may have to take care of the performance for accessing the global map.

LocalStoreMetrics


feat: fix a number of datafusion tests

I think there's a memory issue causing the timeout but I haven't spent the time to figure out exactly why.


Outdated StorSimple reference

This page still refers to StorSimple, which is out of service. Should this be replaced with Azure File Sync?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 5500b1c4-f652-9424-ef6c-90bc5db04a90
Version Independent ID: 83ed8709-d912-ede8-d115-82a49a274ac1
Content: Compare AWS and Azure storage services - Azure Architecture Center
Content Source: docs/aws-professional/storage.md
Service: architecture-center
Sub-service: cloud-fundamentals
GitHub Login: @martinekuan
Microsoft Alias: architectures

@nedlowe
Thank you for bringing this to our attention.
I've delegated this to content author @martinekuan, who will review it and offer their insightful opinions.

Thanks for pointing this out.  An update will be live in one or two business days for this.


[BUG] Fixing typos and shorthand declaration in README

New bug checklist

[x] I have updated smtpmock to the latest version
[x] I have read the Contribution Guidelines
[x] I have read the documentation
[x] I have searched for existing GitHub issues

Bug description

Incorrect shorthand declaration operator in the code present in README.md file in the following line:
 hostAddress, portNumber =: "<IP_ADDRESS>", server.PortNumber
Fixed spelling for two other words as well.

Thank you so much, @srishti-nema ;)


dockerd.json not updated

Just did the full update process and found that my containers wouldn't start due to the "db" log driver not being found.
After a little digging, I noticed that the:
/var/packages/Docker/etc/dockerd.json
Still contains:
{
   "data-root" : "/var/packages/Docker/target/docker",
   "log-driver" : "db",
   "registry-mirrors" : [],
   "storage-driver" : "aufs"
}

The last time this file was changed was a month ago... guess that is when I installed a DSM update.

Thanks for catching this issue, it confirms my suspicion for issue #1. The log driver should be "json-file" instead of "db", as the db driver is specific to Synology's Docker package. It looks like "execute_update_log()" in the script does not work as expected, I'll look into it.

Line 394:
if [ ! -f "$SYNO_DOCKER_JSON" ] || grep "json-file" "$SYNO_DOCKER_JSON" -q ; then

Is the second half right?  If it found a match, it would return 0, which is true.

You're right, the second half is incorrect. I updated the function as follows:
# Configure log driver
execute_update_log() {
    print_status "Configuring log driver"
    if [ "$STAGE" == 'false' ] ; then
        LOG_DRIVER=$(grep "json-file" "$SYNO_DOCKER_JSON")
        if [ ! -f "$SYNO_DOCKER_JSON" ] || [ -z "$LOG_DRIVER" ] ; then
            mkdir -p "$SYNO_DOCKER_JSON_PATH"
            printf "$SYNO_DOCKER_JSON_CONFIG" > "$SYNO_DOCKER_JSON"
        fi
    else
        echo "Skipping configuration in STAGE mode"
    fi
}

A new branch 'logdriver' is available, care to try it?

Sure :)
I'm just restoring everything and then will attempt the update again :)

Hmm... I have two backup files... one from when I ran the BACKUP on its own and the other from when I did the INSTALL.  There is ~17MB difference between the two though, and attempting to restore either one gives me:
ERROR: Docker compose binary could not be extracted from archive

OK, I did a rerun on my NAS too, and it looks like $SYNO_DOCKER_JSON_CONFIG is not parsed correctly yet... I'll update the variable and will push it to the branch

So, I couldn't restore the backup... I got this:
root@DiskStation:/volume1/docker/synology-docker# sudo ./syno_docker_update.sh -b /volume1/docker/synology-docker/docker_backup_200611115000.tgz restore
Update Docker Engine and Docker Compose on Synology to target version

Current DSM version: 6.2.3
Current Docker version: 19.03.11
Current Docker Compose version: 1.26.0
Step 1 from 5: Stopping Docker service
pkgctl-Docker stoped.
Step 2 from 5: Extracting Docker backup (/volume1/docker/synology-docker//volume1/docker/synology-docker/docker_backup_200611115000.tgz)
bin/
bin/containerd
bin/auplink
bin/runc
bin/containerd-shim
bin/ctr
bin/dockerd
bin/docker-init
bin/docker
bin/docker-compose
bin/docker-proxy
dockerd.json
ERROR: Docker compose binary could not be extracted from archive

So I extracted it myself and restored the files manually.
Just noticed the "Step 2 from 5" path... guessing the two variables shouldn't be put together?

OK, I did a rerun on my NAS too, and it looks like $SYNO_DOCKER_JSON_CONFIG is not parsed correctly yet... I'll update the variable and will push it to the branch

Ahh yes, I just noticed that :)
At least it is a step in the right direction :)

ok, $SYNO_DOCKER_JSON_CONFIG is working on my NAS now. I had to manually delete /var/packages/Docker/etc/dockerd.json first, because the script detected the json-file driver, whilst the file itself had an incorrect syntax. :-/

/volume1/docker/synology-docker//volume1/docker/synology-docker/docker_backup_200611115000.tgz looks like another bug indeed, the -b flag should in theory override the working directory.

Weird... the restore process worked perfectly this time round.  I ran the same command as the one I mentioned here:
https://github.com/markdumay/synology-docker/issues/3#issuecomment-642626168

That's weird indeed. I checked the code and noticed an issue here:
execute_extract_backup() {
    print_status "Extracting Docker backup ($WORKING_DIR/$DOCKER_BACKUP_FILENAME)"
    BASEPATH=$(dirname "$DOCKER_BACKUP_FILENAME")
    FILENAME=$(basename "$DOCKER_BACKUP_FILENAME")
    cd "$BASEPATH"
    tar -zxvf "$FILENAME"

    [ ... ]
}

Print_status incorrectly prepends $WORKING_DIR/ as this is already present in $DOCKER_BACKUP_FILENAME. However, that should not have impact on the tar command as it uses $FILENAME instead.

Hey guys,
i still get the error on my influxdb docker file when i try to start it after the update:
Create container InfluxDB failed: {"message":"logger: no log driver named 'db' is registered"}.

Hi Max,
To better understand potential causes, can you share the following?

Your Dockerfile and/or Docker command for running influxdb
The syno_docker_update.sh command and console output
Your Docker path (should be /var/packages/Docker)

Thanks,
Mark.

On 24 Aug 2020, at 12:35, Max Beckenbauer<EMAIL_ADDRESS>wrote:

Hey guys,
i still get the error on my influxdb docker file when i try to start it after the update:
Create container InfluxDB failed: {"message":"logger: no log driver named 'db' is registered"}.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.

Hi @markdumay ,

Dockerfile command:
$ docker run -p 8086:8086 \     -v $PWD:/var/lib/influxdb \     influxdb
Syno_docker_update command:
 sudo ./syno_docker_update.sh update (Console output was uneventful)
Docker is in /var/packages/Docker

Ok, so the syno_docker_update command didn’t show any messages at all? Are you sure the script output is directed to your terminal then?

On 25 Aug 2020, at 08:36, Max Beckenbauer<EMAIL_ADDRESS>wrote:

Hi @markdumay ,
Dockerfile command:
$ docker run -p 8086:8086 \ -v $PWD:/var/lib/influxdb \ influxdb
Syno_docker_update command:
sudo ./syno_docker_update.sh update (Console output was uneventful)
Docker is in /var/packages/Docker
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

There were a lot of messages. But no fail messages. And i didn't save them, sorry :/

Ok, then it’s going to be difficult to understand to what point the script actually ran... if you’re up for it, would you mind rerunning the script and sharing the exact console output?

On 27 Aug 2020, at 17:39, Max Beckenbauer<EMAIL_ADDRESS>wrote:

There were a lot of messages. But no fail messages. And i didn't save them, sorry :/
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Hey there
I'm having the same issue.
Output :
`Update Docker Engine and Docker Compose on Synology to target version
Current DSM version: 6.2.3
Current Docker version: 18.09.8
Current Docker Compose version: 1.24.0
Target Docker version: 19.03.13
Target Docker Compose version: 1.27.4
WARNING! This will replace:

Docker Engine
Docker Compose
Docker daemon log driver

Are you sure you want to continue? [y/N] y
Step 1 from 9: Downloading target Docker binary (https://download.docker.com/linux/static/stable/x86_64/docker-19.03.13.tgz)
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
100 59.3M  100 59.3M    0     0  1014k      0  0:00:59  0:00:59 --:--:-- 1066k
Step 2 from 9: Downloading target Docker Compose binary (https://github.com/docker/compose/releases/download/1.27.4/docker-compose-Linux-x86_64)
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
100   651  100   651    0     0   2883      0 --:--:-- --:--:-- --:--:--  2906
100 11.6M  100 11.6M    0     0   916k      0  0:00:13  0:00:13 --:--:-- 1019k
Step 3 from 9: Stopping Docker service
pkgctl-Docker stoped.
Step 4 from 9: Backing up current Docker binaries (/volume1/homes/Rui/synology-docker/docker_backup_20201114_205835.tgz)
bin/
bin/containerd-shim
bin/ctr
bin/runc
bin/docker-compose
bin/docker-init
bin/docker-proxy
bin/auplink
bin/containerd
bin/dockerd
bin/docker
dockerd.json
Step 5 from 9: Extracting target Docker binary (/tmp/docker_update/docker-19.03.13.tgz)
docker/
docker/ctr
docker/runc
docker/containerd-shim
docker/docker-init
docker/docker-proxy
docker/docker
docker/dockerd
docker/containerd
Step 6 from 9: Installing binaries
Step 7 from 9: Configuring log driver
Step 8 from 9: Starting Docker service
pkgctl-Docker started.
Step 9 from 9: Cleaning the temp folder
Done.`
then I try to run my portainer container with:
docker start portainer
and I get:
Error response from daemon: failed to initialize logging driver: failed to get logging factory: logger: no log driver named 'db' is registered: error looking up logging plugin db: plugin "db" not found Error: failed to start containers: portainer
Anything else I should look for ?
Rui

and maybe this helps as well:
{
    "data-root" : "/var/packages/Docker/target/docker",
    "log-driver" : "json-file",
    "registry-mirrors" : [],
    "group": "administrators"
}```

As a note, after clearing my issue in #48, I also ran into this problem.  Here's my post-update dockerd.json.
{
    "data-root" : "/var/packages/Docker/target/docker",
    "log-driver" : "json-file",
    "registry-mirrors" : [],
    "group": "administrators"
}

As a note, after clearing my issue in #48, I also ran into this problem.  Here's my post-update dockerd.json.
{
    "data-root" : "/var/packages/Docker/target/docker",
    "log-driver" : "json-file",
    "registry-mirrors" : [],
    "group": "administrators"
}

Hello,
same problem as @rui-nar, i have ths error message:

Create container eclipse-mosquitto1 failed: {"message":"error looking up logging plugin db: plugin "db" not found"}.

i have this dockerd.json file:
{ "registry-mirrors": [], "data-root": "/var/packages/Docker/target/docker",\ "log-driver": "json-file",\ "group" : "administrator"\ }

What's wrong with db driver? What are the properties of it?
Why do we then prefer json-file and not local?

It seems db is a proprietary driver from Synology. It is not available with a default Docker installation. I have not tried local instead of json-file myself - care to try it and share your experience?

I'll probably be trying it now. Allegedly it's the same thing (with log rotation support and stuff) as json-file but with less overhead than a json encoding.
The reason I am thinking of deviating from db is it seems to completely give up after a certain amount of spam. A running docker logs -f just stops yielding lines, the UI keeps only displaying logs up until that moment, and new docker --log-level=debug logs <container> just sit there, regardless of any --since or -f, not yielding any preexisting or new lines.
(My spammy container is eclipse/mosquitto with log_type all, but I do need those logs. Maybe I'll move its logs to tmpfs idk. Ideally, I need to process those logs and not store them.)


References inside a prefixed table cannot reference an unprefixed table

Elixir version
Elixir 1.15.7
Database and Version
PostgreSQL 14.1
Ecto Versions
Ecto 3.11.1
Database Adapter and Versions (postgrex, myxql, etc)
postgrex 0.17.4
Current behavior
Ecto
Mix.install([
  {:ecto, "~> 3.10"},
  {:ecto_sql, "~> 3.10"},
  {:postgrex, "~> 0.17.3"},
  {:kino, "~> 0.11.0"}
])

Repo
defmodule Repo do
  use Ecto.Repo, otp_app: :my_app, adapter: Ecto.Adapters.Postgres
end

Kino.start_child({Repo, url: "postgres://postgres:postgres@localhost/postgres"})

Ecto migration
defmodule Migration do
  use Ecto.Migration

  def up do
    execute("CREATE SCHEMA schema1")
    execute("CREATE SCHEMA schema2")

    create table("prefixed_group", prefix: "schema2") do
    end

    create table("group") do
    end

    create table("user", prefix: "schema1") do
      add(:prefixed_group_id, references("prefixed_group", prefix: "schema2"))
      # add(:group_id, references("group", prefix: nil))
    end
  end

  def down do
    drop(table("user", prefix: "schema1"))
    drop(table("group"))
    drop(table("prefixed_group", prefix: "schema2"))
    execute("DROP SCHEMA schema1")
    execute("DROP SCHEMA schema2")
  end
end

Ecto.Migrator.up(Repo, 1, Migration)
|> dbg()

Ecto.Migrator.down(Repo, 1, Migration)

The above Livebook (0.12.1) runs perfectly fine, until you uncomment the attempt to reference the "group" table that has no prefix.  I could find no way to point a reference at an unprefixed table from one with a prefix.
Expected behavior
I expect some way to overwrite the prefix in a reference, or in a table, such that it can unset the default prefix (implied by table or application config) back to "no prefix at all"

Nah, prefix() may return nil too. In order to fix this, we would need to change the .prefix field in index, table, reference and other structs to be {:ok, prefix} | :error or something of sorts.

nothing super elegant, but ..

one backwards compatible option would be to have a no_prefix: true (remove_prefix, clear_prefix, etc) option that raised if you tried to set it and :prefix in the same opts.
another would be to allow prefix: to take something more complex than an atom/string, like {:clear, :prefix}
similar to previous idea, maybe it's okay to special case the false atom as clearing the prefix (you could still use "false" string if that was a desired prefix)

The default schema on postgres databases is "public". So you should be able to write add(:group_id, references("group", prefix: "public")) in this case.

The default schema on postgres databases is "public". So you should be able to write add(:group_id, references("group", prefix: "public")) in this case.

This is good advice. Maybe we should just document something like this as the solution. As far as I know you should always be able to write unqualified table names as qualified table names. In Postgres every table is inside of a schema. In MySQL every table is inside of a database.
It sounds better to me than introducing a new conflicting option or a backwards incompatible change.

Yeah, it is just the behaviour is inconsistent with the other uses of prefixes, but there isn't much we can do I think.

Is there any precedent to create a new function that is basically the old one but with the correct fix? And then deprecate the old one.

Oh I think I see what you mean. The issue is here right:

quote_table(ref.prefix || table.prefix, ref.table)

So if ref.prefix is :error then we use table.prefix but if it is {:ok, nil} then we use the unprefixed quote_table function?
That looks good to me. I wasn't sure what the policy was about changing the behaviour of existing migrations or other adapters like SQLite, Clickhouse, etc. But if it's normal procedure then +1 from me.

Typically we add new callbacks on major versions, which often breaks the adapter anyway, but it is very unoften that we change behaviour. That's why adding a new field to the struct, as mentioned by @jdewar, may be the best option? We can call it options, keep it as a keyword list, and shove :prefix there? So the code above becomes:
quote_table(Keyword.get(ref.options, :prefix, table.prefix), ref.table)

And we deprecate .prefix?

That sounds like the best option to me. And the docs are pretty clear about he behaviour:

:prefix - The prefix for the reference. Defaults to the prefix defined by the block's table/2 struct (the "products" table in the example above), or nil.

So if someone was using prefix: nil to be the table's prefix then they were using it in error anyway.

We were able to side step the problem by creating a new prefix, and using "public" would've been our solve (wouldn't've created this issue even, had I known).  Thanks much for this change!  It's nice to set prefix to 'nil' in a way that matches my mental model.

:prefix - The prefix for the reference. Defaults to the prefix defined by the block's table/2 struct (the "products" table in the example above), or nil.

So if someone was using prefix: nil to be the table's prefix then they were using it in error anyway.

@greg-rychlewski I did want to comment on this part; one might have the Application config define a :migration_default_prefix, and then a table's prefix: nil could make sense, eg:
config :myapp, Repo, migration_default_prefix: "my_prefix"

...

create table("user", prefix: nil) do
  add(:prefixed_group_id, references("prefixed_group", prefix: "my_prefix"))
end

Yes sorry. I meant it's ok for us to "break" users who are relying on our mistake to have the migrations behave in an undocumented way.


warehouse: Require a verified email for 2FA modifications

Prevents users from modifying their 2FA methods without a primary, verified email. Already enabled 2FA methods will continue to work, even if the user's email lapses into an unverified state.
Inverts the two_factor_allowed column into two_factor_prohibited, with a new property on User testing two_factor_prohibited plus whether the user has both a primary email and whether that email is verified.
Closes #5866.

Its not clear to me under what condition we would ever flag an account as being prohibited from using 2FA, but I suppose it's nice to have the option.

Yeah, that state/option is vestigial from the TOTP rollout; I can take it out in this PR or a future one, if desired 🙂

My only concern is that we send blind 403s without explanation. I suppose we could flash a notification to help people understand why they're getting a 403?

Yeah, I can add this. I'm also about to push some changes that ensure that we only reject 2FA provisioning requests and not authentication (to prevent the de-verified email scenario discussed out-of-band).

Alright, warning flashes added.

@brainwane when this merges TOTP goes live, do we need to coordinate launch?

To be clear: I'd like active approval by @di before we can merge this PR and thus launch TOTP as a feature for all PyPI.org and test.pypi.org users, but I'm ok with going forward without @dstufft's +1. If Dustin, Ernest, or Donald objects and thinks Donald's +1 is a necessary prerequisite, please override me. :-)
Re: launch coordination (also, followup to #5661): I will write up a blog post for the PSF blog to be published within the next few days, and I think we should link to it on https://status.python.org/ . Therefore, my request is that we merge after Wednesday May 29th 2pm Eastern Time, to give me time to draft it.

@di is reviewing this now!
@ewdurbin https://pad.sfconservancy.org/p/2fa-pypi-launch-post is what I think could be posted at https://pyfound.blogspot.com/ , https://blog.python.org/ , and status.python.org. Take a look, and please feel free to edit. Also, I need to step away from my laptop for the afternoon and evening, so please feel free to go ahead and publish that post once we have merged this PR.

@brainwane It'd be best to also link to the pypi-announce mailing list at the end, when mentioning it: https://mail.python.org/mailman3/lists/pypi-announce.python.org/


Roll engine 7dfdfc6faeb6..d0698f275e5a (1 commits)

git@github.com:flutter/engine.git/compare/7dfdfc6faeb6...d0698f275e5a
git log 7dfdfc6faeb6..d0698f275e5a --no-merges --oneline
2019-08-13<EMAIL_ADDRESS>Roll src/third_party/skia f99631100372..6ef31815a694 (3 commits) (flutter/engine#10976)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (stuartmorgan@google.com), and stop
the roller if necessary.

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/6184329883942912 , https://cirrus-ci.com/task/6465804860653568 , https://cirrus-ci.com/task/5339904953810944

Commit queue failed; closing this roll.


Add EntityResBuilder

This allows building of entities within a system so long as the necessary Component storages are also available.

This change is

bors delegate=Rhuagh

Reviewed 3 of 3 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

Comments from Reviewable

@WaDelma I'm following the pattern of the other builders in specs.  At minimum the entity needs to be pub(crate) to make the marker implementation work.  Also since the builder eats your borrow of EntitiesRes I figured it'd be appropriate to expose it so the user doesn't arbitrarily lose capabilities during the build.  What would you have happen during the build?

I think it should stay public. If you want to make things go wrong, we can't prevent people from that. Code that changes the entity during the building definitely smells, so.. I don't think we should restrict this. As for the entities resource, I don't see how it "eats your borrow". It's immutable.

The borrow is shared so it's Copy and will not be moved. So there shouldn't be any loss of capabilities.
Okay. It's just that it feels weird that you would even be able to swap it.

bors r=@Rhuagh


How do you get the selection range?

I want to insert some text in the code editor. Markdown example: Select some text, press Cmd-B for Bold, and have two asterisks inserted before and after the selection. But to do this, I need to get the code editor's selection range. How do I get the selection range?

The CodeEditor View doesn't currently support this feature, but it could. The backing text object would just need to track the selection of the backing host view and report that in a binding. It would be a neat addition!


stop syncing majors for Bothell and Foster

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

14 of 14 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.0%) to 84.977%

Totals

Change from base Build<PHONE_NUMBER>:
1.0%

Covered Lines:
181

Relevant Lines:
213

💛  - Coveralls


casting ptr to int

transmute(int) ^foo;

C:\odin\bin/opt: E:\Workspace\odin-stuffs\test.ll:17986:17: error: invalid cast opcode for cast from '%..string*' to 'i64'
%122 = bitcast %..string* %121 to i64

I will fix this tonight but casting between an int/uint and a pointer should be no problem using cast rather than transmute.


Missing crictl in cri-containerd-cni release tar

Description
In the cri 1.5.0 release, there is no crictl binary and needs to be built.
This needs to be checked and verified that all binaries were properly built before releases should be made. Looking back, at the release, it looks like this change was happening once it hit the rc change, all beta releases seem to have the binary in the tar.

https://github.com/kubernetes-sigs/cri-tools/commit/44fd67ced394c1e7b158d75900e20d1eb6e24e37#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R89-R90


Update sbt-typelevel-ci-release to 0.4.9

Updates org.typelevel:sbt-typelevel-ci-release from 0.4.5 to 0.4.9.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.typelevel", artifactId = "sbt-typelevel-ci-release" } ]

labels: sbt-plugin-update, early-semver-minor, semver-spec-patch, commit-count:n:2

Superseded by #677.

Superseded by #682.


Updating build to use latest GA'd version of 6.0.1xx and 7.0.1xx

The builds have been failing for some time.  It doesn't appear the rollForward within global.json is working as 7.0.100 is installed by this script despite 7.0.112 being available.  This likely indicates security updates aren't getting incorporated into the build.
This also installs sdk v6.0.1xx which isn't installed on the appveyor build agents (any longer?), but is required by the unit tests.

I am not a contributor but I reviewed the changes and I think it looks good. 🚀

Thanks for your contribution - this was resolved by #2775.


[Task] Replace zookeeper client to Curator and save data in zk without magic header

Description
Replace current zk client with Curator, and save data in zk without magic header. The second feature will be incompatible with earlier version, including register and syncing in zookeeper. More details can refer to #3360 .
Task List

replace zk client with Curator.
test different zk server version.
save data in zk without magic header.

Please assign it to me, thanks!


conky: 1.12.1 -> 1.12.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/brndnmtthws/conky/releases.
meta.description for conky is: "Advanced, highly configurable system monitor based on torsmo"
meta.homepage for conky is: "http://conky.sourceforge.net/"
meta.changelog for conky is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

/nix/store/3i78hyxkl3sg7kr9p56rdp94aq787804-conky-1.12.2/bin/conky passed the binary check.

1 of 1 passed binary check by having a zero exit code.

1 of 1 passed binary check by having the new version present in output.

found 1.12.2 with grep in /nix/store/3i78hyxkl3sg7kr9p56rdp94aq787804-conky-1.12.2

found 1.12.2 in filename of file in /nix/store/3i78hyxkl3sg7kr9p56rdp94aq787804-conky-1.12.2

directory tree listing: https://gist.github.com/020b637435a1db4d074de34d990f27a2

du listing: https://gist.github.com/0c6338bfdf9f79561031d8a7ce9cc8fd

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
conky

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/3i78hyxkl3sg7kr9p56rdp94aq787804-conky-1.12.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A conky https://github.com/r-ryantm/nixpkgs/archive/df6b666353d33cbedf3960c2465d306a718a997b.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/3i78hyxkl3sg7kr9p56rdp94aq787804-conky-1.12.2
ls -la /nix/store/3i78hyxkl3sg7kr9p56rdp94aq787804-conky-1.12.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

conky

Maintainer pings
cc @dguibert for testing.

Result of nixpkgs-review pr 120647 at df6b6663 run on x86_64-linux 1

1 package built successfully:

conky

4 suggestions:

warning: build-tools-in-build-inputs
man is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/os-specific/linux/conky/default.nix:93:3:
   |
93 |   buildInputs = [ glib libXinerama ]
   |   ^

warning: build-tools-in-build-inputs
docbook_xml_dtd_44 is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/os-specific/linux/conky/default.nix:93:3:
   |
93 |   buildInputs = [ glib libXinerama ]
   |   ^

warning: build-tools-in-build-inputs
docbook2x is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/os-specific/linux/conky/default.nix:93:3:
   |
93 |   buildInputs = [ glib libXinerama ]
   |   ^

warning: build-tools-in-build-inputs
docbook-xsl-nons is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/os-specific/linux/conky/default.nix:93:3:
   |
93 |   buildInputs = [ glib libXinerama ]
   |   ^


Dropwizard testing module for JUnit 5 [WIP]

This PR is proposition of Dropwizard testing module with use of JUnit 5 (Issue #1944). Contains following:

code of original test rules was changed to support executing them from JUnit 5 extension,
JUnit 5 extension class that executes classes from point above,
code of original tests modified to use JUnit 5.

Example of use:

@ExtendWith(DropwizardExtensionsSupport.class)
public class EpisodesResourceTest {

    public final ResourceExtension resources = ResourceExtension.builder()
            .addResource(new UsersResource(usersService))
            .build();

I know that there is a lot of copied code from testing module that could be extracted to common testing library. What's your opinion?

Hey @AnDyXX, thanks for kicking this off! Much appreciated.

I know that there is a lot of copied code from testing module that could be extracted to common testing library.

Is it possible to achieve backwards compatibility for the current junit4 users with a common core module? If not, we'd have to wait for something like a major version bump to introduce this change.
I'm guessing it's not possible to create the dropwizard-testing-junit5 as a tacked on module to dropwizard-testing (eg. users poms would look like)
        <dependency>
            <groupId>io.dropwizard</groupId>
            <artifactId>dropwizard-testing</artifactId>
            <scope>test</scope>
        </dependency>
        <dependency>
            <groupId>io.dropwizard</groupId>
            <artifactId>dropwizard-testing-junit5</artifactId>
            <scope>test</scope>
        </dependency>

As that might be the most preferable 🤔

Is it possible to achieve backwards compatibility for the current junit4 users with a common core module?

Let me try if this works.

Coverage decreased (-3.3%) to 82.114% when pulling 314a9a5162d267b568dc131371b1bd7b77244ed6 on AnDyXX:junit5 into e8f7f6c8c2008ed3ee2b7fb2d40b8f2bcf1874a0 on dropwizard:master.

I changed code so JUnit4 and JUnit5 code is in the dropwizard-testing module.
Changed junit 4 dependency from junit to junit-vintage-engine.
Common code extracted.

Coverage decreased (-1.7%) to 83.739% when pulling 5b34ad16993c67a3c0923682652fd8d0d0bf3b99 on AnDyXX:junit5 into e8f7f6c8c2008ed3ee2b7fb2d40b8f2bcf1874a0 on dropwizard:master.

Changed junit 4 dependency from junit to junit-vintage-engine.

Unfortunately that makes it incompatible with JUnit and would always pull in JUnit 5 and its vintage engine.
How about making the dependencies for JUnit 4 and 5 optional?
https://maven.apache.org/guides/introduction/introduction-to-optional-and-excludes-dependencies.html

Coverage decreased (-2.3%) to 83.124% when pulling 0e318ca3a721cb51684f477b603bc091386d5230 on AnDyXX:junit5 into e8f7f6c8c2008ed3ee2b7fb2d40b8f2bcf1874a0 on dropwizard:master.

Coverage decreased (-1.2%) to 84.237% when pulling 06f4d97a0566bf011469d3d6f0c7b1591cddb11e on AnDyXX:junit5 into e8f7f6c8c2008ed3ee2b7fb2d40b8f2bcf1874a0 on dropwizard:master.

Ok I made JUnit 5 optional and updated restored comments.

Coverage decreased (-1.2%) to 84.237% when pulling 3fbf4d5a4bf1dedc4f544708181572dd2ba7ce0a on AnDyXX:junit5 into e8f7f6c8c2008ed3ee2b7fb2d40b8f2bcf1874a0 on dropwizard:master.

@AnDyXX Could you please rebase this PR on current master?

Coverage decreased (-0.3%) to 86.908% when pulling 158e5d997c93443b571152aa4df3ade3c8bdffb1 on AnDyXX:junit5 into 4a82069a924c4168fa89f6ad1e106236b5ca1d34 on dropwizard:master.

codeclimate — 42 issues to fix are mostly because of test for JUnit5 copied from junit. Any hints on this ones?

I've manually marked warnings in Codeclimate as false positives.

PR code rebased.

Thank you for the contribution!

@AnDyXX / @arteam
Do you have updated version of testing resources documentation?
https://www.dropwizard.io/1.3.9/docs/manual/testing.html#testing-resources
Currently it is still using JUnit4 and ClassRule
Thank you :)


google maps problem on iOS

Summary
there is no problem when you use PROVIDER_DEFAULT as provider or when you do not specify a provider. Apple Maps opens by default on iOS, and Google Maps opens on Android devices.
but if we want to use PROVIDER_GOOGLE as provider on iOS, we get an error like this;

Reproducible sample code
import React from 'react';
import { SafeAreaView, StyleSheet, View } from 'react-native';
import MapView, { MapViewProps, PROVIDER_GOOGLE } from 'react-native-maps';

export default function HomeScreen() {
  return (
    <View style={styles.container}>
      <SafeAreaView>
        <MapView style={styles.map as MapViewProps['style']}
        provider={PROVIDER_GOOGLE} />
      </SafeAreaView>
    </View>
  );
}

const styles = StyleSheet.create({
  container: {
    flex: 1,
  },
  map: {
    width: '100%',
    height: '100%',
  },
});

Steps to reproduce
import MapView, { PROVIDER_GOOGLE } from 'react-native-maps';
we got error when we add provider={PROVIDER_GOOGLE} line on iOS
Expected result
works with google maps
Actual result
(NOBRIDGE) ERROR  Warning: TypeError: Cannot read property 'bubblingEventTypes' of null
This error is located at:
in AIRGoogleMap (created by MapView)
in MapView (created by HomeScreen)
in RCTSafeAreaView (created by HomeScreen)
in RCTView (created by View)
in View (created by HomeScreen)
in HomeScreen
in Unknown (created by Route(index))
in Suspense (created by Route(index))
in Route (created by Route(index))
in Route(index) (created by SceneView)
in StaticContainer
in EnsureSingleNavigator (created by SceneView)
in SceneView (created by BottomTabNavigator)
in RCTView (created by View)
in View (created by Screen)
in RCTView (created by View)
in View (created by Animated(View))
in Animated(View) (created by Background)
in Background (created by Screen)
in Screen (created by BottomTabView)
in RNSScreen (created by Animated(Anonymous))
in Animated(Anonymous)
in Suspender (created by Freeze)
in Suspense (created by Freeze)
in Freeze (created by DelayedFreeze)
in DelayedFreeze
in InnerScreen (created by Screen)
in Screen (created by MaybeScreen)
in MaybeScreen (created by BottomTabView)
in RNSScreenNavigationContainer (created by ScreenContainer)
in ScreenContainer (created by MaybeScreenContainer)
in MaybeScreenContainer (created by BottomTabView)
in RCTView (created by View)
in View (created by SafeAreaProviderCompat)
in SafeAreaProviderCompat (created by BottomTabView)
in BottomTabView (created by BottomTabNavigator)
in PreventRemoveProvider (created by NavigationContent)
in NavigationContent
in Unknown (created by BottomTabNavigator)
in BottomTabNavigator
in Unknown (created by TabLayout)
in TabLayout
in Unknown (created by Route((tabs)))
in Suspense (created by Route((tabs)))
in Route (created by Route((tabs)))
in Route((tabs)) (created by SceneView)
in StaticContainer
in EnsureSingleNavigator (created by SceneView)
in SceneView (created by NativeStackNavigator)
in RNSScreenContentWrapper (created by ScreenContentWrapper)
in ScreenContentWrapper (created by DebugContainer)
in DebugContainer
in RNSScreen (created by Animated(Anonymous))
in Animated(Anonymous)
in Suspender (created by Freeze)
in Suspense (created by Freeze)
in Freeze (created by DelayedFreeze)
in DelayedFreeze
in InnerScreen (created by Screen)
in Screen
in ScreenStackItem (created by SceneView)
in SceneView (created by NativeStackView)
in Suspender (created by Freeze)
in Suspense (created by Freeze)
in Freeze (created by DelayedFreeze)
in DelayedFreeze (created by ScreenStack)
in RNSScreenStack (created by ScreenStack)
in Unknown (created by ScreenStack)
in ScreenStack (created by NativeStackView)
in RCTView (created by View)
in View (created by SafeAreaProviderCompat)
in SafeAreaProviderCompat (created by NativeStackView)
in NativeStackView (created by NativeStackNavigator)
in PreventRemoveProvider (created by NavigationContent)
in NavigationContent
in Unknown (created by NativeStackNavigator)
in NativeStackNavigator
in Unknown (created by RootLayout)
in ThemeProvider (created by RootLayout)
in RootLayout
in Unknown (created by Route())
in Suspense (created by Route())
in Route (created by Route())
in Route() (created by ContextNavigator)
in RNCSafeAreaProvider (created by SafeAreaProvider)
in SafeAreaProvider (created by wrapper)
in wrapper (created by ContextNavigator)
in ThemeProvider
in EnsureSingleNavigator
in BaseNavigationContainer
in NavigationContainerInner (created by ContextNavigator)
in ContextNavigator (created by ExpoRoot)
in ExpoRoot (created by App)
in App (created by ErrorOverlay)
in ErrorToastContainer (created by ErrorOverlay)
in ErrorOverlay (created by withDevTools(ErrorOverlay))
in withDevTools(ErrorOverlay)
in RCTView (created by View)
in View (created by AppContainer)
in RCTView (created by View)
in View (created by AppContainer)
in AppContainer
in main(RootComponent)
React Native Maps Version
1.18.0
What platforms are you seeing the problem on?
iOS (Google Maps)
React Native Version
0.76.5
What version of Expo are you using?
SDK 52
Device(s)
iPhone SE Simulator
Additional information
No response

Had the same issue when using Expo Go which does not support Google Maps any more.
What I did (could help you if you are using ExpoGo):

created an project in Google Api Console and enabled the Google Maps iOS SDK for this project
created an API key (in Google Api Console > Credentials) restricted to use with my app
placed the API key in my app.json under: ios.config.googleMapsApiKey as described here
created and expo developement build to test and work on the app using the iOS Simulator
This worked in my case. Good luck

https://docs.expo.dev/versions/latest/sdk/map-view/

@Ahmeth4n this is a a side effect of you trying to use the current lib which doesn't support new arch with react-native new arch.
see https://github.com/react-native-maps/react-native-maps/issues/5206
we will need to solve this among other issues to be able to support new arch fully, (currently in progress)


Empty list of plugins while there are plugins already created

The list of plugins is empty, unless I click on the filter button (next to "+ Create plugin") causing all of the plugins to appear.

The filter will show plugins that you "own", determined by your namespace. This can be updated via Settings > Misc > Builder. Make sure there is a value stored in here and that the value matches the namespace of the plugins you own and thus are displayed when the filter is applied.

@daftspunk You are right. After fixing the namespace name via Settings > Misc > Builder, everything worked as expected. Thank you :)


pylama: requires '--force' if the file does not end in .py

Ref: https://github.com/klen/pylama/pull/35

This is not enough: option --force seems to have appeared in pylama version 4.0.

Oh.. this would require a version detection in Syntastic?
Then I'd wait for the outcome of https://github.com/klen/pylama/pull/35, and not add --force with Syntastic, if it would be fixed with a recent pylama.

Oh.. this would require a version detection in Syntastic?

Yup.

There doesn't seem to be much interest in fixing this upstream, so I went ahead and did it anyway in 0470fff.

Thanks!


Azure/bmarkovic/extend checker for aad auth

Nit: Another thing I'd add is that new files are missing the empty line at the end, please add it


Getting first previous row with prefix/Conditional iterators

Is your feature request related to a problem? Please describe.
Currently I'm working with a table that this form
Station Number : 101010         ,Year: 2015,,,,,,,,,,,, Station Name : BARO nr.Masha,,,,,,,,,,,,, Time-Series Type : Flow (cumecs),,,,,,,,,,,,, ,,,,,,,,,,,,, Latitude : 7:52: 0 N ,Longitude : 35:29: 0 E ,Area : 1653.0 sq km,,,,,,,,,,, ,,,,,,,,,,,,, ,,Jan  ,Feb  ,Mar  ,Apr  ,May  ,Jun  ,Jul  ,Aug  ,Sep  ,Oct  ,Nov  ,Dec   ,,,,,,,,,,,,, 1,,25.315,12.689,5.464,19.926,27.204,53.082,70.608,93.996,95.439,91.131,68.004,69.302 2,,25.315,12.689,5.464,21.675,28.165,53.082,70.608,93.996,95.439,91.131,68.004,68.004 3,,25.315,12.689,5.464,21.675,28.165,53.082,71.922,93.996,95.439,91.131,65.433,66.715 ,,,,,,,,,,,,, ,,,,,,,,,,,,, ,,,,,,,,,,,,, ,,,,,,,,,,,,, Station Number : 101010         ,Year: 2016,,,,,,,,,,,, Station Name : BARO nr.Masha,,,,,,,,,,,,, Time-Series Type : Flow (cumecs),,,,,,,,,,,,, ,,,,,,,,,,,,, Latitude : 7:52: 0 N ,Longitude : 35:29: 0 E ,Area : 1653.0 sq km,,,,,,,,,,, ,,,,,,,,,,,,, ,,Jan  ,Feb  ,Mar  ,Apr  ,May  ,Jun  ,Jul  ,Aug  ,Sep  ,Oct  ,Nov  ,Dec   ,,,,,,,,,,,,, 1,,55.484,19.926,8.502,19.926,18.226,148.608,135.41,151.97,146.936,160.484,128.965,19.07 2,,54.279,19.926,8.502,19.926,18.226,151.97,133.789,150.286,146.936,160.484,127.37,17.395 3,,54.279,19.07,7.86,19.07,18.226,151.97,132.174,148.608,148.608,160.484,122.624,17.395 4,,53.082,18.226,7.86,18.226,18.226,151.97,132.174,146.936,150.286,158.769,119.494,16.577
I am iterating through all the cells containing data and would like to be able to get the "Latittude:", "Station Name:", etc. cells that immediately precede the row I'm currently at. As I understand it, the iterator $n variable is able to extract the "Longitude" because it stops at the last non-empty cell, but for everything else I will need to be able to specify the prefix due to various non-empty cells in between the current row and the row I need.
Describe the solution you'd like
I would like to be able to specify a regex matching condition in the iterator that overrides the default behavior of "first non-empty cell", something like $n["Area : .*"], and probably using the default behavior is nothing is matched(?).
Describe alternatives you've considered
Currently what I'm doing is creating somewhat roundabout formulas using integer divisions and the fact my actual table repeats every 43 rows.  In the example above, the table repeats every 15 rows and the first data rows start at row 8, so to access the "Latitude:" cell I use value[A, 5 + 15 * (($row - 8)//15)]. However this solution does not work if my table structure does not repeat at regular intervals.

could you please upload a screenshot of the spreadsheet in question?

it sounds like boolean expressions/arrow expressions would help you, (see here)
so here for example you could do value: =starts_with(value[A, $row-$n], "Latitude") -> regex(value[A, $row-$n], <selection-regex>)  (I am not certain what regex would capture the values you're looking for in the latitude cell, but the function regex is also documented in the grammar documentation)


Styling issue with loading animation on no argument upvote

When you upvote a no argument, the loading button is shown, but the arrow isn't hidden while loading. The same doesn't happen with the yes button:

@Kamleshpaul wanna take a look?

I'll take a look, I'm waiting until this PR will be merged, there are many changes, I would rather not create any conflicts

@brendt  sure let me check this

Couldn't reproduce it either.

Maybe it's with specific arguments?
This one on https://rfc.stitcher.io/rfc/short-closures-20 has the problem

it is working fine in my side

Let's assume it's an issue on my side then :) We'll close it for now


Add python 3.10 support

Short description:
Update the code to match changes done in python 3.10
More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
Bug:

/approve

/verified


method Suspendable.combine(Suspendable... suspendables) is missed

Such useful method was present in the Guardian interface :)

Suspendable could be changed to extend Guardian. However, you can easily achieve the same effect like this:
Guardian.combine(
        suspendable1::suspend,
        suspendable2::suspend,
        suspendable3::suspend
)

Alternatively, there could be another helper method for the above, instead of Suspendable extending Guardian:
interface Guardian {
    static Guardian combineSuspendables(Suspendable... suspendables);
}

The main reason why Suspendable does not extend Guardian is that they are basically the same things, so we may want to get rid of one of them.
Also, Guard is very much like Subscription, the main difference is the context in which they are usually used.

That said, if Guardian is removed, then yes, Suspendable.combine(Suspendable...) would have to be added.

Suspendable.combine(Suspendable...) is present in the latest snapshot. Guardian is deprecated and so is Indicator, the only other implementation of Guardian.


[Bug]: How to get the UI deployed

Contact Details
<EMAIL_ADDRESS>What happened?
We are currently using memgraph in a project.  Locally teh developers utilize the memgraph-platform image, and we really want to be able to demo out the UI in this project.
Is it as simple as overriding the default image to be memgraph-platform, and configure the service to expose a UI port, and creating an ingress?
Is it possible to deploy the UI separate from the DB itself?
Chart type
Standalone
Chart version
0.1.0
Environment
Amazon Web Services
Relevant log output
No response

Hi @jseiser, so the Memgraph Lab is currently closed-source.
Why do you need a Memgraph lab inside the Kubernetes cluster?
Memgraph lab was designed to be used as a standalone application where you can connect to different Memgraph instances: Memgraph LAB
But to answer your question:
Is it possible to deploy the UI separately from the DB itself?
No, since it is closed-source at the moment, but this will probably change in the future. There is a hacky way to achieve this by fiddling with Docker images but it is not straightforward action.
Is it as simple as overriding the default image to be memgraph-platform, and configure the service to expose a UI port, and creating an ingress?
Almost, the issue arises due to Memgraph Console running in the terminal by default (and failing due to not being able to connect to tty), this crashes the container in Kubernetes.  We are in the process of changing this in the upcoming weeks. Once that is cleared, deploying MemgraphDB and the Memgraph platform should be almost identical,
Deploying Memgraph Platform and Memgraph Mage in Kubernetes are two next improvements we are planning for this repo.

Ante,
The real desire is being able to demonstrate all the "cool things" that our
developers are doing with memgraph to the various shareholders of this RFC
we are working on.
Being able to port-forward and then remotely connect the UI will work as
well
On Tue, Aug 22, 2023, 5:43 PM Ante Javor @.***> wrote:

Hi @jseiser https://github.com/jseiser, so the Memgraph Lab is
currently closed-source.
Why do you need a Memgraph lab inside the Kubernetes cluster?
Memgraph lab was designed to be used as a standalone application where you
can connect to different Memgraph instances: Memgraph LAB
https://memgraph.com/lab
But to answer your question:
Is it possible to deploy the UI separately from the DB itself?
No, since it is closed-source at the moment, but this will probably change
in the future. There is a hacky way to achieve this by fiddling with Docker
images but it is not straightforward action.
Is it as simple as overriding the default image to be memgraph-platform,
and configure the service to expose a UI port, and creating an ingress?
Almost, the issue arises due to Memgraph Console running in the terminal
by default (and failing due to not being able to connect to tty), this
crashes the container in Kubernetes. We are in the process of changing this
in the upcoming weeks. Once that is cleared, deploying MemgraphDB and the
Memgraph platform should be almost identical,
Deploying Memgraph Platform and Memgraph Mage in Kubernetes are two next
improvements we are planning for this repo.
—
Reply to this email directly, view it on GitHub
https://github.com/memgraph/helm-charts/issues/9#issuecomment-1688970535,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABFBNZ3G44ML4O4GLXNWMQLXWURXBANCNFSM6AAAAAA3RI56DI
.
You are receiving this because you were mentioned.Message ID:
@.***>

Cool than just installing Memgraph LAB locally and connecting to a remote instance, that is the way to go.


There should be HTML hints for aria-* attributes

In the code:
https://github.com/adobe/brackets/blob/master/src/extensions/default/HTMLCodeHints/HtmlAttributes.json
The aria-* attributes are missing, which are states and properties for Accessible Rich Internet Applications, defined in https://www.w3.org/TR/wai-aria/states_and_properties

I'll try to fix this one

The code is ready and is waiting the merge to master. It works well!

Fix in PR #12471

@twang2218 I solved this issue and it has been pull requested.

As #12471 has been merged and will be released as part of 1.8, I'm closing this issue.

Hello. I'm using Brackets 1.9 (just updated from 1.6 today). How do I trigger aria hints? I've tried just typing aria- and waiting, but nothing happens.

@gparsloe Thanks for the information. I am glad you found a solution. :) I would suggest reporting this as an issue.


Cell selector isn't working properly

Cell selector isn't displaying after the table was loaded
While the table has been scrolled the selector isn't work well

fixed


Fix USB detection

The "enable logging" toggle button is only enabled when a USB device is detected. However, this button seems to get desynced quite regularly, and either doesn't reflect the state of the logging service or whether a USB device is plugged in or not.

I'm beginning to think plugging in a USB device should launch a separate activity where you can enable/disable logging...


translate all examples in DOM to Chinese

Addresses #[646]
Changes:
translated all examples in DOM to Chinese

@MuyingLi are you still interested in working on this pull request?

@MuyingLi are you still interested in working on this pull request?

@MuyingLi are you still interested in working on this pull request?

@MuyingLi are you still interested in working on this pull request?

@limzykenneth would you suggest we close this PR?

This is a bit stale now and would require some work to get it ready for merge. It is a bit of a shame to close as is because most of the translations here are good. I can put it on my list of things to do when I get some free time but it's a long list. I guess we can close it for now and maybe revisit with commits in this PR as a starting point.

Well no harm to leave it open for now I think. If anyone wants to come finish it up we can merge. We also have translation projects on our list for GSOC so if anyone proposed to continue work on this translation, we can ask them to take a look at this as well.


Error on build –prod

Hi!!!
i received throw this error, when a use ionic build --prod, after npm audit fix after the message of high vulnerability
Browser application bundle generation complete.
Error: ./src/main.ts
Module build failed (from ./node_modules/@ngtools/webpack/src/ivy/index.js):
it occurred because de @angular-devkit/build-angular was update for version 0.1102...after npm audit fix, so a chance for ^0.1002.2", remove de node_modules and execute de npm i again, so the message "high vulnerability" is gone
I suggest upgrade in package.json @angular-devkit/build-angular
Thank you

Will do, thanks for the feedback.


Add InfiniteLoader HOC

Resolves #38

gave it a quick look over, ran the demo, and i think this will certainly work for my use case.
Quick question, not 100% sure if this was addressed, but what would you suggest doing to prevent lots of redundant API calls? In the example, while rows are loading, scrolling past them is calling loadMoreRows on every render -- but i would think it's safe to assume that once you've called loadMoreRows for a range, you shouldn't need to call it for that range again.
Would that be the responsibility of the user? Does doing it this way open up behaviors that I'm not considering, or is it just going to be overhead for most projects?

y'know i'm looking at it more closely and it may already be doing the efficient behavior -- if i'm wrong let me know :)

It will track and only call load for ranges that have not been loaded
previously. (It should never try to load the same row twice.) How
aggressively you prefetch can be controlled via the threshold attribute.
Depending on your situation you could prefetch in chunks- (so if the loader
told you to load rows 50..60 there's no reason you couldn't load 50..100
instead).
On Sunday, January 10, 2016, Mitch Robb<EMAIL_ADDRESS>wrote:

y'know i'm looking at it more closely and it may already be doing the
efficient behavior -- if i'm wrong let me know :)
—
Reply to this email directly or view it on GitHub
https://github.com/bvaughn/react-virtualized/pull/51#issuecomment-170422290
.


Fix markdown formatting

The route subsection was missing a leading empty line which messed up the markdown formatting. Adding the empty line fixes this.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


ModbusBlockGap issue with Coils

One of our devs found the below issue while working on a customer project and it appears to be in the modbus pod which we don't have access to. The screenshots are from FIN, but this was also reproduced in the Skyspark UI v3.0.29.
How to reproduce

Create a new proj
Enable modbus ext
Create new registerMap called “test” like:

name,addr,data,rw,scale,dis,unit,tags
ping,00001,bit,r,,Ping,,
bit01,00001,bit,r,,,,
bit02,00002,bit,r,,,,
bit03,00003,bit,r,,,,
bit_empty,00004,bit,r,,,,
bit05,00005,bit,r,,,,
bit06,00006,bit,r,,,,
bit07,00007,bit,r,,,,

Create new connector with (IMPORTANT: add modbusBlockGap:3 to the default tags):

conn
modbusBlockGap:3
modbusConn
modbusRegMapUri:data/modbus/test.csv
modbusSlave:1
uri:modbus-tcp://[<IP_ADDRESS>/](http://<IP_ADDRESS>/)

Run a modbus slave simulator, like modsim, configured like into the attached screen, so with:

bit1 = 0
bit2 = 0
bit3 = 0
bit4 = 1 //<---- Important: set this to 1
bit5 = 0
bit6 = 0
bit7 = 0

Create an equip with those points referencing the registers (IMPORTANT: skip bit 4):
View the point live values for each
bit1 (OK: curVal should be == 0 and is == 0)
bit2 (OK: curVal should be == 0 and is == 0)
bit3 (OK: curVal should be == 0 and is == 0)
bit5 (ERROR: curVal should be == 0 and is == 1, it’s reading bit4)
bit6 (ERROR: it’s reading bit5)
bit7 (ERROR: it’s reading bit6)

Expected behavior:
You should see all the points with curVal == 0
Error
There is a shift of the value from bit 4 that is equals to 1 to bit 5 that should be equals to 0 but now it’s 1.
NOTES:
Removing modbusBlockGap:3 there is no error
Doing the same with numbers works fine, also with modbusBlockGap:3 (see pictures related to number tests)

@rickyv1 thanks for reporting this bug. I was able to reproduce and have pushed a fix. note - this fix is only for SkySpark versions that support the Haxall connector framework, so it will not work in FINStack or SkySpark 3.0.29

Thank you, Matthew! I understand it is for the newer SkySpark versions.

From: Matthew Giannini @.>
Sent: Tuesday, January 3, 2023 5:33 AM
To: haxall/haxall @.>
Cc: Ricky Villa Valle @.>; Mention @.>
Subject: Re: [haxall/haxall] ModbusBlockGap issue with Coils (Issue #12)
@rickyv1https://github.com/rickyv1 thanks for reporting this bug. I was able to reproduce and have pushed a fix. note - this fix is only for SkySpark versions that support the Haxall connector framework, so it will not work in FINStack or SkySpark 3.0.29
—
Reply to this email directly, view it on GitHubhttps://github.com/haxall/haxall/issues/12#issuecomment-1369775933, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A3C7MNLYHSXXP6JNJL2A4ATWQQTBRANCNFSM6AAAAAAQNYCZNE.
You are receiving this because you were mentioned.Message ID: @.***>


Add missing EP class for UDTT columns

An extended property on a user defined table type column does not have a class of 1 like normal columns, it is 8.

@LowlyDBA : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Thanks @LowlyDBA for contacting Microsoft with feedback about our product documentation. Depending on the complexity, it could take from a few business days to a few weeks to look further into your question, issue, or suggestion. We'll contact you if we need further information, and you'll receive an email message each time we "@mention" you in a comment.
Allow a day or more for the article's author to review and approve your change or offer an alternative solution.
By opening a pull request, you're helping the author add your approved change directly to the documentation. After the updated article is published, GitHub lists you as an article contributor.
Thanks again for submitting your feedback. Your suggestions help improve our documentation.

Thanks again @LowlyDBA for submitting your feedback. Your suggestions help improve our documentation. This article update is in flight. After the updated article is published, GitHub will list you as an article contributor.


CoreOs cluster restarted all containers due to fleet or etcd errors

Hello
We just saw a pretty server issue on our production CoreOs setup. Details are:

3 CoreOs nodes running in AWS EC2 Us East1
m3.2xlarge instance types
CoreOS nodes - 2 are DISTRIB_RELEASE=1068.2.0 and 1 is at DISTRIB_RELEASE=1081.5.0
etcd version 0.4.9
we have auto update disabled on CoreOs
Around 21:56 UTC on Jan 17 we saw all our containers go down and the logs seemed to suggest an issue with etcd

Jan 17 21:56:22 ip-10-26-31-100.ec2.internal fleetd[999]: ERROR server.go:189: Server monitor triggered: Monitor timed out before successful heartbeat
Jan 17 21:56:22 ip-10-26-31-100.ec2.internal fleetd[999]: INFO server.go:157: Establishing etcd connectivity
Jan 17 21:56:22 ip-10-26-31-100.ec2.internal fleetd[999]: ERROR engine.go:179: Engine leadership acquisition failed: context deadline exceeded
Jan 17 21:59:41 ip-10-26-31-100.ec2.internal fleetd[999]: INFO server.go:168: Starting server components
Jan 17 21:59:42 ip-10-26-31-100.ec2.internal fleetd[999]: INFO engine.go:185: Engine leadership acquired
Jan 17 21:59:43 ip-10-26-31-100.ec2.internal fleetd[999]: ERROR engine.go:254: Failed unscheduling Unit(kafka-broker-1.service) from Machine(6ca65ead2f164b2682c0d941c8a75d9b): context deadline exceeded
Jan 17 21:59:43 ip-10-26-31-100.ec2.internal fleetd[999]: ERROR reconciler.go:62: Failed resolving task: task={Type: UnscheduleUnit, JobName: kafka-broker-1.service, MachineID: 6ca65ead2f164b2682c0d941c
Jan 17 21:59:44 ip-10-26-31-100.ec2.internal fleetd[999]: ERROR engine.go:254: Failed unscheduling Unit(newNewApps.service) from Machine(6ca65ead2f164b2682c0d941c8a75d9b): context deadline exceeded

We checked the CPU and disk IO for all 3 instances, there is NO indication of any CPU spike per AWS Cloudwatch
ETCD config is as below
core@ip-10-26-33-251 ~ $ sudo systemctl cat etcd

/usr/lib64/systemd/system/etcd.service
[Unit]
Description=etcd
Conflicts=etcd2.service
[Service]
User=etcd
PermissionsStartOnly=true
Environment=ETCD_DATA_DIR=/var/lib/etcd
Environment=ETCD_NAME=%m
ExecStart=/usr/bin/etcd
Restart=always
RestartSec=10s
LimitNOFILE=40000
/run/systemd/system/etcd.service.d/10-oem.conf
[Service]
Environment=ETCD_PEER_ELECTION_TIMEOUT=1200
/run/systemd/system/etcd.service.d/20-cloudinit.conf
[Service]
Environment="ETCD_ADDR=<IP_ADDRESS>:4001"
Environment="ETCD_CERT_FILE=/home/etcd/certs/cert.crt"
Environment="ETCD_DISCOVERY=https://discovery.etcd.io/"
Environment="ETCD_KEY_FILE=/home/etcd/certs/key.pem"
Environment="ETCD_PEER_ADDR=<IP_ADDRESS>:7001"

Attached the fleet & etcd logs from all nodes

etcd-10-26-31-100.txt
etcd-10-26-32-94.txt
etcd-10-26-33-251.txt
fleet-10-26-31-100.txt
fleet-10-26-32-94.txt
fleet-10-26-33-251.txt

AWS status dashboard does not show any errors or issues on their end

Appreciate if someone can take a look at the above and give us any pointers on what to look at and what we can do to mitigate this.
I opened a fleet ticket - https://github.com/coreos/etcd/issues/7177 and was redirected to here
Thx
Maulik
etcd-10-26-31-100.txt
etcd-10-26-32-94.txt
etcd-10-26-33-251.txt
fleet-10-26-31-100.txt
fleet-10-26-32-94.txt
fleet-10-26-33-251.txt

Following up - we have done the below:

Restarted fleet on all 3 nodes - still not getting to a stable state
Restarted etcd on 1 node - <IP_ADDRESS> - still did not help
When we try to bring up containers, randomly see the containers being stopped or failing because of below errors:

Jan 18 01:39:04 ip-10-26-31-100.ec2.internal fleetd[20619]: ERROR units.go:231: Failed creating Unit(discoveryAppdiscoveryApps.service) in Registry: context deadline exceeded
Jan 18 01:39:05 ip-10-26-31-100.ec2.internal fleetd[20619]: ERROR units.go:231: Failed creating Unit(discoveryAppdiscoveryApps_syslog.service) in Registry: context deadline exceeded
Jan 18 01:39:09 ip-10-26-31-100.ec2.internal fleetd[20619]: ERROR server.go:189: Server monitor triggered: Monitor timed out before successful heartbeat
Jan 18 01:39:09 ip-10-26-31-100.ec2.internal fleetd[20619]: INFO server.go:157: Establishing etcd connectivity
Jan 18 01:39:09 ip-10-26-31-100.ec2.internal fleetd[20619]: INFO server.go:168: Starting server components
Jan 18 01:39:49 ip-10-26-31-100.ec2.internal fleetd[20619]: ERROR units.go:231: Failed creating Unit(discoveryAppdiscoveryApps.service) in Registry: context deadline exceeded
Jan 18 01:39:50 ip-10-26-31-100.ec2.internal fleetd[20619]: ERROR units.go:231: Failed creating Unit(discoveryAppdiscoveryApps_syslog.service) in Registry: context deadline exceeded
Jan 18 01:40:05 ip-10-26-31-100.ec2.internal fleetd[20619]: ERROR server.go:189: Server monitor triggered: Monitor timed out before successful heartbeat
Jan 18 01:40:05 ip-10-26-31-100.ec2.internal fleetd[20619]: INFO server.go:157: Establishing etcd connectivity
Jan 18 01:40:18 ip-10-26-31-100.ec2.internal fleetd[20619]: INFO server.go:168: Starting server components
Jan 18 01:40:20 ip-10-26-31-100.ec2.internal fleetd[20619]: INFO engine.go:79: Engine leader is 6ca65ead2f164b2682c0d941c8a75d9b
Jan 18 01:40:34 ip-10-26-31-100.ec2.internal fleetd[20619]: ERROR units.go:231: Failed creating Unit(discoveryAppdiscoveryApps_syslog.service) in Registry: client: response is invalid json. The endpoint is probably not valid etcd cluster endpoint

This entire cluster has been working fine for last 3 months, no changes or updates and all of sudden we are seeing these errors. We have not upgraded the nodes or containers in last week or so. Appreciate any insight


Fix timer trigger csharp template

add name for timer binding to match the code
change schedule to once a minute

:shipit:

I dont have permissions to merge on this repo yet :)

You do now!


compatibility issues with Logi Options+

Microsoft PowerToys version
0.76.2
Installation method
GitHub, Microsoft Store
Running as admin
Yes
Area(s) with issue?
General
Steps to reproduce
The software has compatibility issues with the logical logic driver; when I use PowerToys to modify key mappings and default shortcut key combinations, the gesture settings in the logic driver become ineffective. Disabling the software resolves the issue.
In more precise technical terms:
This software encounters compatibility issues with the logical input driver; upon utilizing PowerToys to alter keyboard mappings and predefined shortcut key sequences, the gesture functionalities associated with the logic driver cease to function properly. The problem is rectified upon closing the application.
✔ Expected Behavior
The software has compatibility issues with the logical logic driver; when I use PowerToys to modify key mappings and default shortcut key combinations, the gesture settings in the logic driver become ineffective. Disabling the software resolves the issue.
In more precise technical terms:
This software encounters compatibility issues with the logical input driver; upon utilizing PowerToys to alter keyboard mappings and predefined shortcut key sequences, the gesture functionalities associated with the logic driver cease to function properly. The problem is rectified upon closing the application.
❌ Actual Behavior
The software has compatibility issues with the logical logic driver; when I use PowerToys to modify key mappings and default shortcut key combinations, the gesture settings in the logic driver become ineffective. Disabling the software resolves the issue.
In more precise technical terms:
This software encounters compatibility issues with the logical input driver; upon utilizing PowerToys to alter keyboard mappings and predefined shortcut key sequences, the gesture functionalities associated with the logic driver cease to function properly. The problem is rectified upon closing the application.
Other Software
The software has compatibility issues with the logical logic driver; when I use PowerToys to modify key mappings and default shortcut key combinations, the gesture settings in the logic driver become ineffective. Disabling the software resolves the issue.
In more precise technical terms:
This software encounters compatibility issues with the logical input driver; upon utilizing PowerToys to alter keyboard mappings and predefined shortcut key sequences, the gesture functionalities associated with the logic driver cease to function properly. The problem is rectified upon closing the application.

What is the logical logic driver? Can you link some documentation/product page?
/needinfo

Install Logi Options+ Software | Logitech
this is the info
I have modified my shortcut key mappings using PowerToys

甘
@.***

------------------ 原始邮件 ------------------
发件人: "Aaron @.>;
发送时间: 2024年2月3日(星期六) 晚上6:53
收件人: @.>;
抄送: @.>; @.>;
主题: Re: [microsoft/PowerToys] compatibility issues (Issue #31267)
What is the logical logic driver? Can you link some documentation/product page?
/needinfo
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

I have a Logitech mouse
can you provide a more detailed repo set of steps. You are seeing something I’m not and it could be the logi has a config setting I’m not using.
Example: does your logi software remap any keys for when you click a mouse button?  Do you also have a KBM setting set?
/reportbug

甘
@.***

------------------ 原始邮件 ------------------
发件人:                                                                                "microsoft/PowerToys"                                                                                @.>;
发送时间: 2024年2月4日(星期天) 凌晨0:01
@.>;
<EMAIL_ADDRESS>主题: Re: [microsoft/PowerToys] compatibility issues with Logi Options+ (Issue #31267)
Hi there!
We need a bit more information to really debug this issue. Can you add a "Report Bug" zip file here?    Then drag the zipfile from your desktop onto the GitHub comment box in this issue.  Thanks!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

this is  my powertoy setting, when  i try to setting gesture  about  move virtual desktop in the  logi  options+，the gesture  does not work, but  other setting  in  the logi options+ is  work

甘
@.***

------------------ 原始邮件 ------------------
发件人: "Clint @.>;
发送时间: 2024年2月4日(星期天) 凌晨0:01
收件人: @.>;
抄送: @.>; @.>;
主题: Re: [microsoft/PowerToys] compatibility issues with Logi Options+ (Issue #31267)
I have a Logitech mouse
can you provide a more detailed repo set of steps. You are seeing something I’m not and it could be the logi has a config setting I’m not using.
Example: does your logi software remap any keys for when you click a mouse button?  Do you also have a KBM setting set?
/reportbug
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>


[vcpkg-cmake] Fix docs and usage of option MAYBE_UNUSED_VARIABLES

In the current document, our description of MAYBE_UNUSED_VARIABLES caused the user to misunderstand the parameter and incorporate the wrong changes.
Fix the option description and add sample code to the docs.

cc @wrobelda

Need to check the related warning message after pipeline test.

Question: should we also add the following requirement in https://github.com/microsoft/vcpkg/blob/master/docs/maintainers/maintainer-guide.md#build-techniques?


Is it worth adding a host-relative join?

The join function is incredibly convenient.
let endpoint = WebURL("https://api.example.com/")!
let user_root = endpoint.join("/users/karl/")! // https://api.example.com/users/karl/

getJSON(url: user_root.join("profile_data")) // https://api.example.com/users/karl/profile_data
getJSON(url: user_root.join("subscription_info")) // https://api.example.com/users/karl/subscription_info

However, it accepts quite a wide variety of input formats - far too many to really expect users to remember, meaning that it is quite easy to construct surprising URLs if the joined strings are constructed from unsanitized input. Moreover, sanitizing inputs to the parser is very, very hard. For one thing, the parser will trim ASCII control characters and spaces, and filter newline and tab characters. So the input \n     \n\t/some/path is parsed exactly the same as /some/path, even though the first character technically isn't "/". How many users have if string.first == "/" or string.hasPrefix("/") checks that don't take filtering in to account?
In particular, I think that joined strings which have the potential to change the scheme and/or host are important to guard against. A change of scheme/host means a change of origin, and while web browsers have the notion of a 'current origin' (of the 'current page'), applications don't have any notion of what their 'current origin' is, and thus no protections against cross-origin communication. Even if an incorrectly-sanitized string ends up with a slightly odd-looking URL, I think that's a much more reasonable consequence than sending the request to an entirely different server (possibly under the user's control, with the possibility to feed the application fake data and exploit holes in the app's logic).
There are 2 formats that can change the host:

Absolute URLs
The join function actually accepts an entirely different URL string - so if a user can control the start of the input string, they effectively have complete control to override where the request will go. This can be an unexpected result
when joining a relative path whose initial component contains a ":", such as a Windows drive letter:
let base = WebURL("file:///C:/Windows/")!
base.join("D:/Media") // { "d:/Media", scheme = "D", path = "/Media" }
base.join(hostRelative: "D:/Media") // { "file:///D:/Media", scheme = "file", path = "D:/Media" }

It may also occur if the joined string begins with unsantized input:
let endpoint = WebURL("https://api.example.com/")!
// Using 'join':
func getImportantDataURL(user: String) -> WebURL {
  endpoint.join("\(user)/files/importantData")!
}
getImportantDataURL(user: "frank") // "https://api.example.com/frank/files/importantData"
getImportantDataURL(user: "http://fake.com")  // "http://fake.com/files/importantData"

// Using 'join(hostRelative:)':
func getImportantDataURL(user: String) -> WebURL {
  endpoint.join(hostRelative: "\(user)/files/importantData")!
}
getImportantDataURL(user: "frank") // "https://api.example.com/frank/files/importantData"
getImportantDataURL(user: "http://fake.com")  // "http://api.example.com/http://fake.com/files/importantData"

Protocol-relative URLs.
Strings with a leading "//" are known as protocol-relative URLs. They were useful for web pages that needed
to support both HTTP and HTTPS, but tend to be discouraged these days. Nonetheless, support for these URLs
means that certain code which attempts to make a path absolute by prepending a "/" can inadvertently change
the host:
let container = WebURL("foo://somehost/")!
// Using 'join':
func getURLForPath(path: String) -> WebURL {
  // Did the caller add a leading '/'? Probably not - let's add one!
  container.join("/\(path)")!
}
// Will the function add a leading '/'? Probably not - let's add one!
getURLForPath(path: "/users/john/profile") // foo://users/john/profile

// Using 'join(hostRelative:)':
func getURLForPath(path: String) -> WebURL {
  // Did the caller add a leading '/'? Probably not - let's add one!
  container.join(hostRelative: "/\(path)")!
}
// Will the function add a leading '/'? Probably not - let's add one!
getURLForPath(path: "/users/john/profile") // foo://somehost//users/john/profile

How much of a problem is this in the real world? I don't know, but we've all written code to check if a string starts with a "/" to try and predict how the parser will interpret it. Admittedly, the examples above are a bit contrived.

Prototype is now on branch relatively-joined:
https://github.com/karwa/swift-url/tree/relatively-joined


Improve exceptions we throw when something cannot be translated to the server query

We would like to add some helpful wording (TBD) and a fwlink (https://go.microsoft.com/fwlink/?linkid=2097910) when our new LINQ implementation throws because it cannot translate something to the server. This can help customers moving from 2.x to 3.0 given the client eval breaking change but it can be generally useful based on the experience with previous LINQ implementation that had restricted client eval.

Related #16133


HAML language support

Implement optimized styles for  HAML entities for the milestone backlog community :package: package  language-haml by ezekg

Prologs and their punctuation definition characters should be colored correctly
Objects should be colored correctly
Tag punctuations should be colored correctly
Instance variables should be colored correctly and have italic font

Implemented in the referenced commit. Merged in 0651543f7a2d17f362079d630656469f382db4c8.


trinket: erase chip on upload

After few tests I spotted that chip should be erased for Trinket. Still I'm getting
avrdude: verifying ...
avrdude: verification error, first mismatch at byte 0x0000
         0x00 != 0x0e
avrdude: verification error; content mismatch

avrdude: safemode: Fuses OK (E:00, H:00, L:00)

avrdude done.  Thank you.

Blink example is uploaded with success - tested for few version. @Rahix can you please review? Maybe after first load bootloader was corrupted.

Nice, thanks a lot.  To clarify, when you say

Still I'm getting [...]

Is this with do_chip_erase: true or without?

with do_chip_erase: true. will try to fix bootloader today and review

I also found an Adafruit document about programming the trinket a while ago, maybe check what they recommend as well.