Unexpected behavior of panInside

[x] I've looked at the documentation to make sure the behavior is documented and expected
[x] I'm sure this is a Leaflet code issue, not an issue with my own code nor with the framework I'm using (Cordova, Ionic, Angular, React…)
[x] I've searched through the issues to make sure it's not yet reported

Steps to reproduce
Please see the unexpected behavior of panInside the CodeSandbox below. The bottom padding passed to panInside in map2 is only 1px greater than the bottom padding passed to panInside in map1 but map2 pans the marker all the way to the top while map1 does not pan at all.
Expected behavior
map2 should only pan up one pixel, as this is the minimum amount to make marker2 visible within the padding.
Current behavior
map2 pans so that marker2 is at the top of the map.
Environment

Leaflet version: ^1.7.1
Browser (with version): Chrome 88.0.4324.96
OS/Platform (with version): macOS High Sierra 10.13.6

Additional context

Minimal example reproducing the issue

Please see this screen recording:
https://user-images.githubusercontent.com/63527968/106411334-e8e10680-63f9-11eb-8671-7a7ddd3fb899.mov

[x] this example is as simple as possible
[x] this example does not rely on any third party code

@daverayment Is this a bug?

@user073 Thanks for reporting this and for the clear example. This is definitely not intended behaviour. The map should pan the smallest amount so the marker is within the padded bounds.
I have a lot on at the moment, but I'll try to track down the root cause soon.

The calculations currently depend on the padding taking up less than half the bounds, otherwise the movement offset created is reversed, i.e. a Y scroll of 1 pixel down from the top of the bounds instead of 1 pixel up from the bottom. I'll attempt to correct this soon.

@daverayment You’re welcome. OK. Please consider converting paddedBounds to a LatLngBounds object and passing the LatLngBounds object to panInsideBounds. The Point objects in paddedBounds may be able to be converted to LatLng objects with layerPointToLatLng.

@user073 This should be fixed in a future release by PR #7469. Thanks again for the report.

@daverayment OK. You're welcome.

Looks like this was fixed in https://github.com/Leaflet/Leaflet/pull/7469.


Passing in new java source code snippets to get predictions

How can we pass in a single snippet of java code as string into the model and get a comment generated from the model, for example, what are the preprocessing steps involved?

Hi!
First of all, you need to extract paths from the code snippet. This should be done by the tool you used for model training.
After that, you should write a little wrapper to pass your datapoint into the model. Look into an example from readme for correct model loading. Pass your example into the model according to forward method signature.

Hi @SpirinEgor, thanks for responding !
To train the model I downloaded the dataset and ran the train script provided in the readme. I am a bit unclear,  what do you mean by the "tool" used for model training?

What dataset did you download?
The tool I was speaking about is a tool for extracting paths from AST of code. There are some different ways to do it:

JavaExtractor from original code2seq repo by Alon
astminer
PSIMiner

All these tools use different parsers therefore they build different ASTs and extract different paths.

hello, i'm doing same thing with my own python ast miner
can you confirm whether i'm doing correctly?
https://gist.github.com/hehehwang/d058c6fca986a5b479afe10245f63a3e
(i think something went wrong since it's keep printing out  and  token..)
thank you!

It seems that there are correct steps. Could you provide more information:

The mined paths from the code snippet
The input tensors shapes (they should be something like [5; n_paths])

Also, the model was trained with masked method names, so you should replace them too in your example. As far as I remember, mask token in <MN>. But you can check it. It should be in the top of the label_to_id counter. The correct code snippet is
def <MN>(n):
    if n == 0:
        return 1
    else:
        return n * <MN>(n-1)

Output shape is [7; 1; vocab size], so correct decoding is:
# [7]
predictions = output.squeeze(1).argmax(-1)
labels = [id_to_label(i.item()) for i in predictions]

seems that i've made a silly mistake on decoding.. thank you for your help!
now it works just fine and clear (without mask token though)
thanks again!

Awesome!
If you have other questions, feel free to open an issue!


Doesn't format Finnish phone numbers

On demo example, when selecting FI, no formatting applied. Same with at least several other countries (GP, IR).

Hey @Kotpes could you try the number in the original google libphonenumber demo:
https://rawgit.com/googlei18n/libphonenumber/master/javascript/i18n/phonenumbers/demo-compiled.html
Let us know how it is going, also it will be great if you can provide a Finnish test phone number.
Cheers.

****AsYouTypeFormatter Results**** Char entered: 4 Output: 4 Char entered: 0 Output: 40 Char entered: 1 Output: 401 Char entered: 8 Output: 4018 Char entered: 7 Output: 40187 Char entered: 1 Output: 401871 Char entered: 8 Output: 4018718 Char entered: 0 Output: 40187180 Char entered: 2 Output: 401871802
Apparently, it also doesn't do the formatting.
How number should look like: +358 XXX XXX XXX, where +358 is an international country code that one can replace with 0 while calling within the country, but most people just dial XXX XXX XXX ), whilst calling from outside one has to dial +358 (not 0) XXX XXX XX). I hope it clears it up a bit.

Okay, then looks like google phone lib would need the leading 0 to format Finnish national numbers.
In your case, either +3584571234567 or<PHONE_NUMBER>7 got formatted correctly.
For me it makes sense, cause here in Australia, to dial a number within the country, the leading 0 is a must thing.
But as you said, most people in your country just dial XXX XXX XXX, I guess that will be considered as a non-standard input by the google phone lib.
I would suggest you either put a tip or just leave it (since user can still enter the non-standard number).
Will close this issue. We will keep following google lib to see if there is any update. Cheers.

Fair enough. Thanks!


[Improvement][UI] Adjust the args of router to allow the edge to be connected with node at its different positions

Purpose of the pull request
This PR will close #12758 .

Brief change log
Verify this pull request
This change added tests and can be verified as follows:

Manually verified the change by testing locally.

The test result is as follows:

Codecov Report

Merging #12759 (c6bf119) into dev (c4fb555) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev   #12759      +/-   ##
============================================
- Coverage     39.20%   39.16%   -0.04%
+ Complexity     4213     4210       -3
============================================
  Files          1045     1045
  Lines         39719    39687      -32
  Branches       4575     4557      -18
============================================
- Hits          15570    15542      -28
  Misses        22377    22377
+ Partials       1772     1768       -4

Impacted Files
Coverage Δ

...erver/master/processor/queue/TaskEventService.java
69.64% <0.00%> (-10.72%)
:arrow_down:

...r/plugin/registry/zookeeper/ZookeeperRegistry.java
43.54% <0.00%> (-6.46%)
:arrow_down:

...er/master/dispatch/host/assign/RandomSelector.java
77.77% <0.00%> (-5.56%)
:arrow_down:

...hinscheduler/plugin/alert/script/ScriptSender.java
70.58% <0.00%> (-1.64%)
:arrow_down:

...r/plugin/task/sqoop/parameter/SqoopParameters.java
51.19% <0.00%> (-1.20%)
:arrow_down:

...cheduler/plugin/alert/dingtalk/DingTalkSender.java
34.13% <0.00%> (-0.78%)
:arrow_down:

...rver/master/runner/task/BlockingTaskProcessor.java
75.86% <0.00%> (-0.55%)
:arrow_down:

...inscheduler/plugin/registry/etcd/EtcdRegistry.java
50.69% <0.00%> (-0.35%)
:arrow_down:

.../dolphinscheduler/plugin/task/datax/DataxTask.java
36.62% <0.00%> (-0.26%)
:arrow_down:

.../dolphinscheduler/plugin/task/spark/SparkTask.java
72.56% <0.00%> (-0.25%)
:arrow_down:

... and 18 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


hls可以携带token请求么

中文用户请注意：请尽量用英文描述你的 issue，这样能够让尽可能多的人帮到你。
If you want to report a bug, please provide the following information:

The steps to reproduce.
A minimal demo of the problem via https://jsfiddle.net or http://codepen.io/pen if possible.
Which versions of DPlayer, and which browser / OS are affected by this issue?

可以携带token么

同问


Fix crash during NSURLSession's resume

Summary
When using FLEX, my App may crash on a frequency of about one time per 1~2 days(I think it depends on how many network request we send).

I assume the crash is caused by part of the code of HTTPParser is not thread-safe, and invoke it asynchronously may cause double-free crash. So I manually ask for HTTPBody synchronously, make the HTTPParser parse the request and cache them in advance, before any possible asynchronous invoking.
Test Plan

Run our App with FLEX integrated
Make sure NSURLSession is hooked
It may take days to reproduce the crash

Thanks!


Simplify operator shutdown

main function waits for shutdown signal to be closed instead of
doing so in a loop
@tgraf was the timeout in a loop necessary? We can add a 1 second wait after the shutdown channel is closed, but I didn't find any reason to do it.

This change is

test-me-please

Coverage decreased (-0.01%) to 41.893% when pulling 79962aeedaa575ad92c09765768a0676098bb1d8 on nebril:simplify-operator-shutdown into fbbbd5dded3ab4ee4b0775ff5fdb013602e63ea9 on cilium:master.

test-me-please


Typo "Resorce" in sidebar

There is a typo in sidebar. Correct word is "Resource"

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b2e3dfa7-e7ba-d8b9-9c8b-7a716016b7c0
Version Independent ID: 249776f7-0d81-361b-822e-b87c2ca7fb23
Content: az storage cors
Content Source: src/command_modules/azure-cli-storage/azure/cli/command_modules/storage/_help.py
Service: storage
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

@daxianji007 where are the sidebar names defined? It does not seem to come from our CLI.
Can you take a look?

@dend

Fixed with https://github.com/Azure/azure-docs-cli-python/pull/1071


Add interactive docs for all current components

I've created a standard way to display the components with an interactive table. This should be used for all created components docs page.

[x] Button
[x] Alert
[x] Collapse
[x] Table
[x] Tooltip
[x] Checkbox
[x] Select
[x] Text Input
[x] Toggle
[x] Drawer
[x] Menu
[x] Navbar
[x] Tab

:tada: This issue has been resolved in version 0.14.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Targeted output generation

After training the model, if I have to generate some other characters and numbers from other language, I have to include these letters in file words_list.txt but will I have to train all the model for these characters again or should I just run some specific part of the code?

After training the model, if I have to generate some other characters and numbers from other language, I have to include these letters in file words_list.txt but will I have to train all the model for these characters again or should I just run some specific part of the code?

Did you find a solution for this?

Hello @DeccanKing1 @loafenzy,
to extend the “language model” to additional characters, you need to:

update char_vec and n_classes in scrabble_gan.gin as required; an example on how words are subsequently encoded is given in load_random_word_list().
provide additional training data.
retrain whole model.


Merge sidetree v0.12 into dev

@jmandel Is the plan to merge this into dev so that we can test against dev.c19.cards or directly to master? My understanding is that the flow is feature-branch -> dev -> master, is that correct? LMK if there's anything I can help with!

@jmandel Is the plan to merge this into dev so that we can test against dev.c19.cards or directly to master? My understanding is that the flow is feature-branch -> dev -> master, is that correct? LMK if there's anything I can help with!

I am planning to merge this into dev once there's a 1.0 tag at https://github.com/decentralized-identity/sidetree (which I think should happen today). Just want to avoid any churn here.
Thanks for the offer to help!

I am planning to merge this into dev once there's a 1.0 tag at https://github.com/decentralized-identity/sidetree (which I think should happen today). Just want to avoid any churn here.
Thanks for the offer to help!

Obviated by #37

Obviated by #37


add cat restapi transaction & fix email windows outlook bug

Coverage decreased (-0.3%) to 45.741% when pulling 53dffbcb3f94a3854b066f90f76dbadc27e568ae on lepdou:1221 into 66c2002584fe160cd09eec3b4f452c7e69f32442 on ctripcorp:master.

Current coverage is 42.70% (diff: 0.76%)

Merging #496 into master will decrease coverage by 0.29%

@@             master       #496   diff @@
==========================================
  Files           307        308     +1
  Lines          7860       7912    +52
  Methods           0          0
  Messages          0          0
  Branches        906        915     +9
==========================================
- Hits           3380       3379     -1
- Misses         4239       4294    +55
+ Partials        241        239     -2

Powered by Codecov. Last update 66c2002...53dffbc

Coverage decreased (-0.2%) to 45.851% when pulling 1679ae98e3840666b538422ee6c802c757107f6b on lepdou:1221 into 66c2002584fe160cd09eec3b4f452c7e69f32442 on ctripcorp:master.

Coverage decreased (-0.2%) to 45.913% when pulling 561ad08827dd2935b024767dcc3010027b72b59d on lepdou:1221 into 66c2002584fe160cd09eec3b4f452c7e69f32442 on ctripcorp:master.


Multiple Issues

Please read in reference to https://github.com/Grover-c13/MultiAdmin/issues/111
Here is my config file: https://pastebin.com/JqNjY8ne

@blizzard2023 Are you still having this issue with the new releases of ServerMod?


Adapt repo code to work with OpenShift

why do these need to be build args?

Because I wanna have it generic so that you can configure the docker build using the git server you want

why do these need to be build args?

Because I wanna have it generic so that you can configure the docker build using the git server you want

Hmm but it's nothing the build itself needs. So why not simply overwrite this in the cron job as env variable

why do these need to be build args?

Because I wanna have it generic so that you can configure the docker build using the git server you want

Hmm but it's nothing the build itself needs. So why not simply overwrite this in the cron job as env variable

It actually does need it. If you don't do that, it will try to add the key for the git server when cloning the repo and fail since interaction is required

why do these need to be build args?

Because I wanna have it generic so that you can configure the docker build using the git server you want

Hmm but it's nothing the build itself needs. So why not simply overwrite this in the cron job as env variable

It actually does need it. If you don't do that, it will try to add the key for the git server when cloning the repo and fail since interaction is required

Ah the keyscan thing needs it. missed that


No paths work when reading files (Deno)

In Deno, vips.Image.newFromBuffer(buffer) works well! But opening local files directly for example vips.Image.newFromFile('sample.jpg') always complains:
error: vips::Error: unable to load from file sample.jpg
VipsForeignLoad: file "sample.jpg" does not exist

I thought it would be an issue of relative paths, but I tried all kinds of absolute and relative paths (relative to Deno.cwd(), or import.meta.url, or the directory where vips-es6.js is stored), with and without file:// prefix, with no luck.
Furthermore I tried a simple filename without path, and put a sample.jpg in every directory I could think of where it might try to load it. No luck.
Am I missing something, or is this is a bug with wasm-vips on deno?
Deno 1.38.5, wasm-vips version is i guess 0.0.7 (or whatever it is that jsdelivr is giving - I manually downloaded vips-es6.js and all the other JS and WASM file from jsdelivr in order to install and import locally since it seems using jsdelivr the wasm files are loaded again over the net every run? - could we perhaps somehow have these zipped on new releases?)
PS:
I'm running on VPS's with limited RAM, so while ArrayBuffers work, I'm hoping passing file paths directly would negate the need for allocating big in and out buffers, and perhaps allow vips to process data in a more streaming manner (if it does that, or does it need to load the full file data in memory?).
Ideally for Deno, it would be great if we were able to work with ReadableStream in and WritableStream out, but that does not appear possible at the moment. That's why I'm looking into passing file paths instead of ArrayBuffer

Sorry, this dropped off my radar. Currently, wasm-vips doesn't support native file system access in environments other than Node.js, mainly because these environments typically reuses the web ES6 module. Emscripten issue https://github.com/emscripten-core/emscripten/issues/12203 might be relevant here.
On the web, the whole filesystem is virtualized (see MEMFS). So, you need to preload the file first, for example on Deno:
import Vips from 'https://cdn.jsdelivr.net/npm/wasm-vips/lib/vips-es6.js';

const vips = await Vips({
  // Optimize startup time by disabling the dynamic modules
  dynamicLibraries: [],
  preRun: async (module) => {
    // Preload banana.webp
    module.FS.createDataFile('/', 'banana.webp', await Deno.readFile('playground/src/images/banana.webp'), true, false);
  }
});

// Load an image from a preloaded file
const im = vips.Image.newFromFile('banana.webp[n=-1]', {
  access: vips.Access.sequential // 'sequential'
});

// Write the result to a GIF file
const outBuffer = im.writeToBuffer('.gif');
await Deno.writeFile('banana.gif', outBuffer);

// Memory management
im.delete();

// Exit the Deno runtime (i.e. a more "commandline" experience)
Deno.exit();

$ deno run --allow-net --allow-read --allow-write test.js

it seems using jsdelivr the wasm files are loaded again over the net every run?

IIUC, Deno reuses a module from its cache without having to fetch it again on subsequent runs, but I'm not sure how Deno manages Wasm files internally.

could we perhaps somehow have these zipped on new releases?

wasm-vips will only be distributed via npmjs.com; there are currently no plans to distribute it through other channels.

allow vips to process data in a more streaming manner

I think the source/target API of libvips would be suitable for this.
https://www.libvips.org/2019/11/29/True-streaming-for-libvips.html
https://github.com/kleisauke/wasm-vips/blob/65f364dc49053b3bf0c7ef39d0a0af1beb8c7506/test/unit/test_connection.js#L81-L100

it would be great if we were able to work with ReadableStream in and WritableStream out

Indeed, this would be a great addition. It can probably be implemented using a new pair of Image.newFromStream() / image.writeToStream() functions.


Update az.coffee

azerbaijani translation - chunk 1

Coverage decreased (-0.01%) to 61.918% when pulling fcc44c8dc95a9529f447c4b23fccdfae4d4de368 on nuriyevn:patch-2 into<PHONE_NUMBER>01ca749c37c8314aef605230cc85ae on codecombat:master.

Could you sign our CLA so we could accept your PR?

Done

Thanks!


CWA should control communication with backend

Avoid duplicates

[+ ] This enhancement request has not already been raised before
[+] Enhancement request is specific for Android only, for general issues / questions that apply to iOS and Android please raise them in CWA-Wishlist
[ -] If you are proposing a new feature, please do so in CWA-Wishlist

Current Implementation

The communication with the backend is controlled by the Exposure Notifications Framework.
Suggested Enhancement

CWA should be the master calling functions of EN or directly communicating with the backend.
Expected Benefits

Fix of the problems loading keys.

Hi @gitbrueck
Can you please specify what you mean with "communication with the backend is controlled by the Exposure Notifications Framework" and where do you see this happening (that the EN framework is taking responsibility of calling our backend)?
Thanks,
Philipp

Hi Philipp,
sorry, it was just an idea.
If I would be whitelisted, I would step through the callback-function "onReceive" and check if there is something more then just storing data and setting a semaphore. There must be no calling of the framework and no communication with the backend.
Best Regards,
gitbrueck

If I would be whitelisted

As you are not whitelisted, you might want to resort to this: https://github.com/kbobrowski/en-i13n


Bootstrap Sass as submodule

I just would like to suggest to use Bootstrap as a git submodule, to have its source fully in the project. Or is there a reason this is not done currently like that?
I'm considering using this material library, but why makes me shy away from it is the fact it is only "based on" Bootstrap as opposed to using it directly.
All modifications and enhancements for material can, in my opinion, be made on the Sass level by importing what is needed, swapping out the variables, etc.

eek, i just noticed this

I believe that's @sesemaya intent; he's on holiday, so i'll leave it to him to confirm when he returns.

Can we get an update on this please? Thanks! :simple_smile:


Access to generic MQTT servers

Hi,
first of all thanks for fixing the mqtt dependency :-)
I just realized that this project seems to be focused on MQTT servers related to "INFINIMESH"*. Is this correct?
Anyhow, I'm wondering if I can use this gateway also for other MQTT servers like Mosquitto?
If so, I'd like to get started with using their (public) test server here: https://mqtt.eclipse.org/
The default.json seems to support only encrypted connections with Client side SSL authentication. (8884 : MQTT, encrypted, client certificate required). Is this correct?
Any chance to use alternative connection methods like the ones being offered by the test server above:

1883 : MQTT over unencrypted TCP
8883 : MQTT over encrypted TCP

Many thanks!

And if all of my wishes above cannot be fulfilled, how could I get access to a trial account of Infinimesh?

Hi,
the gateway is open to any RFC compliant MQTT broker, as noted in the Readme:
"By default the gateway is configured to use infinimesh.cloud platform, but it can be used with any MQTT broker."
In fact we know from some dozen using this with Azure or AWS IoT. Just edit the config, that's all. An trial account for infimesh.cloud can be obtained by contact our sales directly<EMAIL_ADDRESS>or click on the popup in console.infinimesh.cloud (contact also sales via a form).
We don't support alternative methods, we also encourage to only use MQTTS as protocol. But feel free to add alternatives, it's open source ;) Just to a PR and we check if the code works.

If you have more questions, we are happy to help :)


Display bytea columns hex encoded

Currently (on 0.9.4) the content of bytea columns is shown as a UTF-8 string in the table view.
It would be nice if these columns could be shown using hex encoding instead.
The encoding can be done in postgres using:
SELECT encode(my_checksum, 'hex') FROM my_table;

But this kind of behavior would require the server to keep tabs on types of fields used in each table. I understand that it will be a much nicer user experience, but i dont really have the time to work on something like this. If you have any suggestions / code snippets i would definitely help getting the feature added, but otherwise i'll leave this issue open.

I'm not familiar with go, but would it be easier to do the hex encoding in go?
If it's possible to reflect on the result's column type to see if it's a Bytea, it should be possible to encode it using something like hex.EncodeToString().


Modify processor to async

Codecov Report

Merging #236 into dev will decrease coverage by 0.03%.
The diff coverage is 18.57%.


Should the cipher-object be created with an IV?

I'll start by saying I'm not a crypto expert by any means.
However, it was pointed out on HN that the encrypt function doesn't use an IV when initializing the cipher object, and the node documention explicitly says

"In line with OpenSSL's recommendation to use pbkdf2 instead of EVP_BytesToKey it is recommended that developers derive a key and IV on their own using crypto.pbkdf2() and to use crypto.createCipheriv() to create the Cipher object."

Since the official docs appears to recommend against crypto.createCipher() I figured it was worth bringing up.

To be clear: if two ciphertexts use the same IV across ciphertexts with CTR, you basically have no encryption, as C1^C2=P1^P2, where Cs are the ciphertexts and Ps are the plaintexts.

IV doesn't have to be secure, but it has to be securely random on every re-encryption.

@sgdread Technically for CTR mode, it only needs to be unique and not necessarily random or unpredictable — it's a nonce, not an IV.

This is an important implementation issue! I'm currently traveling and will try to push a fix out asap.

Thanks for your input. The issue is fixed with ef8bc9aed55dba3b320d9ec441946091f273723b.
We also changed the block cipher mode of operation to GCM. The encryption (and decryption code) are moved to utils.js line 19.


Initial commit of contact-sync

Migrate contact-sync to images repo

@edquist say hello to the one-stop-shop opensciencegrid/images repo where we're trying to collect all container images that use standard OSG container builds. You can see how this all works through the GHA workflow here: https://github.com/opensciencegrid/images/blob/main/.github/workflows/build-containers.yml.
Please review this PR. Note that it doesn't have to be too thorough: Ops needs these containers pushed and we can always fix them up if they notice any issues

I'm sort of in the middle here, trying to get the existing code into a place where it'll get baked into an image. Those all look like great suggestions.
Opinions/comments, @hzhu16 ?

Thanks for the suggestions, and I'll update the code as soon as possible. The topology_utils.py script was a copy from https://github.com/opensciencegrid/topology/blob/master/src/topology_utils.py.

@hzhu16 if the changes seem reasonable to you, we can just have @jthiltges batch and apply the suggestions and get this merged so we get a new container ASAP! If you'd like more time to look these changes over, then we can merge this (the suggested changes don't appear to address anything critical) and you can submit a subsequent PR with changes

The topology_utils.py script was a copy from https://github.com/opensciencegrid/topology/blob/master/src/topology_utils.py.

Ah, I didn't realize this was a copy of a functioning script.  If that's the case, probably i'd say don't bother making changes to it; it could get annoying if they get out of sync due to nitpicks.

OK. @jthiltges please make suggested changes. I'll watch how it runs in tiger. Thanks.

ADD https://raw.githubusercontent.com/opensciencegrid/topology/v1.17.1/src/topology_utils.py ./

Oh neato!
I didn't realize that was possible.  But yeah that seems like a good idea. Seems to me that fixes should go to upstream topology anyhow, and yeah by version-locking you can explicitly update as appropriate.

@brianhlin, just fyi john and i are not authorized to merge this PR

@edquist I can push the merge button, if that's what you want.

I can push the merge button, if that's what you want.

That'd be great, thanks @timtheisen !


Add tests

The code from #1 does not include any test.
Maybe we can use something like https://github.com/buger/goreplay.
Related issue: [private] https://github.com/src-d/infrastructure/issues/1130

Tasks:

[ ] Online tests
[ ] Offline tests (without errors)
[ ] Offline tests (with errors)


[hotfix] Add prefix to interfaces.

Codecov Report

Merging #40 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #40   +/-   ##
=======================================
  Coverage   90.75%   90.75%
=======================================
  Files           6        6
  Lines         346      346
  Branches       55       55
=======================================
  Hits          314      314
  Misses         32       32

Impacted Files
Coverage Δ

src/datastore/ephemeral.ts
84.78% <ø> (ø)

src/datastore/postgres.ts
92.30% <ø> (ø)

src/types.ts
100.00% <ø> (ø)

src/listeners.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9e741a...ad6add5. Read the comment docs.


Can I change the "_" in the hostname of container ?

Rancher Version:
1.1.0
Docker Version:
1.19.0
Hello,
I like rancher very much and Im trying to migrate most of my apps and make them running on rancher, but I met a problem this day.
I like to use the managed network of rancher and set the io.rancher.container.hostname_override	to container_name to use the internal DNS. but the hostname of container set to stackname_serivcename_createindex. but in many applications such as websphere and hadoop.. the "" in the hostname is illeagle... can I change the "" to "-" ? Many thanks

Currently. there is no way to change the_ to some other character in the container name. I've made this an enhancement request.

This is going to need to change fairly soon anyway with the current remote API for docker 1.12 not allowing underscore anymore..

https://github.com/rancher/rancher/issues/3589


evaluating 'imagePickerManager.showImagePicker'

undefined' is not an object (evaluating 'imagePickerManager.showImagePicker')
how can i handle this ?

This means you did not properly link the native library. I'd recommend following the README through again in detail.


[9.1.x] ISPN-8603 Missing Rest codec in the CLI

https://issues.jboss.org/browse/ISPN-8603

Merged, thanks


fix: Ensure minimal .bashrc_user exists

Resolves #4
* Create restore .bak files of the system default .bash dotfiles
* In migrate_home.sh ensure that the minimal required .bashrc_user and make one for the user if it doesn't
* Inject the required `# pyenv setup` comment for pyenv_setup.sh and note this in instructions

@msneubauer This should be fixed for @mihirkatare and others now.


RATIS-1319. Fix vagrant for TLP

What changes were proposed in this pull request?
Fix vagrant for TLP
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-1319
How was this patch tested?
Review

Failed Tests are unrelated, and they pass locally.
File a jira RATIS-1321 to track it.
@szetszwo Could you please take a look? Thanks.

@szetszwo Thanks for review!


simple tf-idf for thai document (after tokenize)?

มีใครทำไปรึยังครับ พอดีผมลองใช้ของ scikit-learn แล้วออกมามั่วมาก

I think the best solution is to use the tokenizer from pyThaiNLP, then use many available solutions such as nltk, spacy, gensim, etc. (for python) or tm and quanteda (for R) for document frequency matrices.

Thanks for the suggestion! Get it to work with gensim.
From my quick try in python (for future reference)

nltk doesn't support tf-idf
sklearn TfidfVectorizer gives weird result for Thai
`from sklearn.feature_extraction.text import TfidfVectorizer
documents = ['เดี๋ยว', 'ไป', 'ส่ง', 'นะ']
tfidf_vectorizer = TfidfVectorizer()
tfidf = tfidf_vectorizer.fit_transform(documents)
tfidf_vectorizer.get_feature_names()

this output ['นะ', 'ยว', 'เด', 'ไป']
`


Problem running web components todo in Stencil

Hi Julien, I just try web components todo in Stencil via local and install dependencies. When I run npm run dev the folder www overwrite by Stencil like picture below

and in my terminal shows error as attached.

AFAIK, the folder www is ignore by Stencil so when we run npm run dev or npm run start it will generate a folder www with it’s assets. Can I know the reason why you don't ignore this folder? Could you please advice what should I do to solve the problem? Thanks a lot.

The www was served on github before being on firebase https://wc-todo.firebaseapp.com/stencil/www/index.html wanted to move fast, did not want any CI build step involved. That's the reason it is commited and not ignored. Now it is on firebase, I could ignore them again. Will do next time I update this repo (maybe 2day)
As fo your compiler problem, it could be a version problem, there is no stable version yet, things are moving fast.

Hi Julien, thanks a lot for your response. Yep, you're right Stencil is not stable yet. I got information from Stencil Slack channel (sorry no SS) that sass will remove and replace with css for performance. I check in their Github, they already do that.

So, I'm curious and will try to move your previous stencil code to current version. I hope I can do that ASAP.

Cool, this afternoon I will probably finish the Vue version and if I have more time I will add SkateJS version as well

Noted. I hope I can promote this repository in my community, I will try to
share about web components and promote this as good sample.
Salam,
Satya Kresna
https://github.com/satyakresna
www.linkedin.com/in/satyakresna
On 11 February 2018 at 20:31, Julien Renaux<EMAIL_ADDRESS>wrote:

Cool, this afternoon I will probably finish the Vue version and if I have
more time I will add SkateJS version as well
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/shprink/web-components-todo/issues/5#issuecomment-364748154,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKlcMu8Os2CCggDyCmeZFuiEKQlenQIbks5tTt2hgaJpZM4SA0_q
.

Hi Julien, thanks a lot the problem of running in stencil is done. 🎉🙏

haha you are welcome my friend :)


Detect unnecessary synthetic accessor

It would be cool if there was a rule that could detect all the synthetic methods created to access private fields.
https://dev.to/ditn/synthetic-accessors-in-kotlin
Such rules already exist for Java and for the moment it seems JetBrain have no willing to include that soon.

Good point


Ad Impressions support on Mobile

One of the examples in the javascript tracker ads.html shows the use of ad impressions.
window.adTracker('trackAdImpression:' + rnd,
  '67965967893',            // impressionId
  'cpa',                    // costModel - 'cpa', 'cpc', or 'cpm'
  10,                       // cost - requires costModel
  'http://www.example.com', // targetUrl
  '23',                     // bannerId
  '7',                      // zoneId
  '201',                    // advertiserId
  '12'                      // campaignId
);

I have tried to search through the Android repository to see if this is supported yet. If you could please let me know if it is / where it is in the roadmap? It looks like the Collect and Storage phases have some code written for this based on this search

Hi @jpotts18 - ah, good timing - we are working on a new Android Tracker release now. trackAdImpression is a very thin wrapper around the underlying self-describing JSON:
https://github.com/snowplow/snowplow-javascript-tracker/blob/4e52a258dba248d824c360941caadd338f9e4490/core/lib/core.js#L449
So it should be an easy add for the Android Tracker if you want to open a PR!


Removed keras and tensorflow requirement and updated to tf.keras

Requiring tensorflow as a dependency force installs the CPU only version of the package when users have tensorflow-gpu or nightly builds installed. Per https://github.com/tensorflow/tensorflow/issues/7166 we should avoid explicit tensorflow dependencies. Keras is also included with tensorflow now and need not be installed explicitly.

@kzimmer-bah thanks a lot for your PR. If you can just fix the indentation and remove the tensorflow import, CI will go green :)
./keract/__init__.py:2:4: E111 indentation is not a multiple of four
./keract/__init__.py:2:4: F401 'tensorflow' imported but unused
./keract/__init__.py:4:4: E111 indentation is not a multiple of four
2     E111 indentation is not a multiple of four
1     F401 'tensorflow' imported but unused

To change the unused import to an import check you can do: https://stackoverflow.com/questions/14050281/how-to-check-if-a-python-module-exists-without-importing-it

Done. Is it best practice to use importlib to do an import check? I nearly went that route originally but it seemed more pythonic and explicit to do a try/except around the import.

We're all good now. I missed running the examples before and didn't catch the layer name issue in the get_activations test. Since no training ops were run, the dummy model defaults to an identity op I guess.
I also added in a GPU check to the examples and enabled memory growth. For some reason tensorflow still (been an issue since I started messing with it in 2017) allocates as much memory as possible when loading data sets and models onto the GPU. I basically have that snippet as boilerplate in most of my model scripts.

@kzimmer-bah flake8 was complaining about and I think it follows PEP8 by default so in this case I guess it was better to use the importlib module.
Anyway awesome thank you so much. Looks perfect to me!

Released in 3.1.0

Glad I could help!


--chunk_strategy not recognised (but -cs works)

msm_os: error: unrecognized arguments: --chunk_strategy {"time_counter": 1, "x": 720, "y": 360}
but changing --chunk_strategy to -cs is accepted.
Mis-match between documentation and code in msm-os/src/msm_os/cli/argument_parser.py:
 parser.add_argument(
       "-cs",
       "--chunk-strategy",
       dest="chunk_strategy",

Documentation says --chunk_strategy, code accepts --chunk-strategy

Actually, the issues are deeper than just a documentation error. Even when accepted, the supplied chunking information is not applied. chunk_strategy is set but I can't see where it gets used and the test on rechunk is never true.
chunk_strategy needs to be added to the send arguments in main_cli.py:
index 0688fd8..c4aebf3 100644
--- a/src/msm_os/cli/main_cli.py
+++ b/src/msm_os/cli/main_cli.py
@@ -59,6 +59,7 @@ def process_action(args):
             append_dim=args.append_dim,
             send_vars_indep=not send_vars_indep,
             object_prefix=args.object_prefix,
+            rechunk=args.chunk_strategy,
             to_zarr_kwargs=None,
         )

This would suggest that some recent changes have not being thoroughly tested. :(

That change helps but doesn't give complete control over chunking. Running this, for example,:
msm_os send --file "./eORCA12_1d_grid_T_197602-197602.nc" --bucket "npd12-j001-test" --append-dim "time_counter" --credentials "mycreds" -v "tos_con" -cs '{"time_counter": 1, "x": 720, "y": 360}'
correctly chunks the requested variable but not the associated coordinate fields (it is very unclear when these get added)
/home/users/acc/newTOOLS/nczarr/newjas/bin/ncdump -h -s https://noc-msm-o.s3-ext.jc.rl.ac.uk/npd12-j001-test/T1d#mode=nczarr,s3
netcdf T1d {
dimensions:
	y = 3605 ;
	x = 4320 ;
	time_counter = 29 ;

// global attributes:
		:_SuperblockVersion = 0 ;
		:_IsNetcdf4 = 1 ;
		:_Format = "netCDF-4" ;

group: tos_con.zarr {
  variables:
  	float nav_lat(y, x) ;
  		nav_lat:bounds = "bounds_nav_lat" ;
  		nav_lat:long_name = "Latitude" ;
  		nav_lat:standard_name = "latitude" ;
  		nav_lat:units = "degrees_north" ;
  		nav_lat:_Storage = "chunked" ;
  		nav_lat:_ChunkSizes = 451, 540 ;
  		nav_lat:_Filter = "32001,0,0,0,0,5,1,1" ;
  		nav_lat:_Codecs = "[{\"blocksize\": 0, \"clevel\": 5, \"cname\": \"lz4\", \"id\": \"blosc\", \"shuffle\": 1}]" ;
  		nav_lat:_Endianness = "little" ;
  	float nav_lon(y, x) ;
  		nav_lon:bounds = "bounds_nav_lon" ;
  		nav_lon:long_name = "Longitude" ;
  		nav_lon:standard_name = "longitude" ;
  		nav_lon:units = "degrees_east" ;
  		nav_lon:_Storage = "chunked" ;
  		nav_lon:_ChunkSizes = 451, 540 ;
  		nav_lon:_Filter = "32001,0,0,0,0,5,1,1" ;
  		nav_lon:_Codecs = "[{\"blocksize\": 0, \"clevel\": 5, \"cname\": \"lz4\", \"id\": \"blosc\", \"shuffle\": 1}]" ;
  		nav_lon:_Endianness = "little" ;
  	double time_centered(time_counter) ;
  		time_centered:bounds = "time_centered_bounds" ;
  		time_centered:calendar = "gregorian" ;
  		time_centered:long_name = "Time axis" ;
  		time_centered:standard_name = "time" ;
  		time_centered:time_origin = "1900-01-01 00:00:00" ;
  		time_centered:units = "seconds since 1900-01-01" ;
  		time_centered:_Storage = "chunked" ;
  		time_centered:_ChunkSizes = 29 ;
  		time_centered:_Filter = "32001,0,0,0,0,5,1,1" ;
  		time_centered:_Codecs = "[{\"blocksize\": 0, \"clevel\": 5, \"cname\": \"lz4\", \"id\": \"blosc\", \"shuffle\": 1}]" ;
  		time_centered:_Endianness = "little" ;
  	double time_counter(time_counter) ;
  		time_counter:axis = "T" ;
  		time_counter:bounds = "time_counter_bounds" ;
  		time_counter:calendar = "gregorian" ;
  		time_counter:expected_size = 29 ;
  		time_counter:long_name = "Time axis" ;
  		time_counter:standard_name = "time" ;
  		time_counter:time_origin = "1900-01-01 00:00:00" ;
  		time_counter:units = "seconds since 1900-01-01" ;
  		time_counter:_Storage = "chunked" ;
  		time_counter:_ChunkSizes = 29 ;
  		time_counter:_Filter = "32001,0,0,0,0,5,1,1" ;
  		time_counter:_Codecs = "[{\"blocksize\": 0, \"clevel\": 5, \"cname\": \"lz4\", \"id\": \"blosc\", \"shuffle\": 1}]" ;
  		time_counter:_Endianness = "little" ;
  	float tos_con(time_counter, y, x) ;
  		tos_con:cell_methods = "time: mean (interval: 300 s)" ;
  		tos_con:coordinates = "nav_lat nav_lon time_centered" ;
  		tos_con:interval_operation = "300 s" ;
  		tos_con:interval_write = "1 d" ;
  		tos_con:long_name = "sea_surface_conservative_temperature" ;
  		tos_con:online_operation = "average" ;
  		tos_con:standard_name = "null" ;
  		tos_con:units = "null" ;
  		tos_con:_Storage = "chunked" ;
  		tos_con:_ChunkSizes = 1, 360, 720 ;
  		tos_con:_Filter = "32001,0,0,0,0,5,1,1" ;
  		tos_con:_Codecs = "[{\"blocksize\": 0, \"clevel\": 5, \"cname\": \"lz4\", \"id\": \"blosc\", \"shuffle\": 1}]" ;
  		tos_con:_Endianness = "little" ;

  // group attributes:
  		:expected_checksum_1976-02-01T12\:00\:00.000000000 =<PHONE_NUMBER>32063542LL ;
  		:expected_coords = "[\"none\"]" ;
  		:expected_variables = "[\"tos_con\"]" ;
  } // group tos_con.zarr
}

@accowa, I created a pull request to fix this error.
I tested this rechunk strategy only in the NEMO cylc package, but not in the command line code :(
My initial idea was to just regroup the data (not the coordinates). But now I update _rechunk_ds to include the coordinates too.
I'm running some tests and will merge after everything is working well.

I tested this rechunk strategy only in the NEMO cylc package, but not in the command line code :(

Not convinced that should make a difference since the scripts in NEMO_cylc end up calling the same command-line code

In the NEMO_cylc, it calls the function directly in python https://github.com/NOC-OI/NEMO_cylc/blob/0cdcdef8c0855948436d3c8ffbfdd629cfdfab99/bin/transfer_to_os.py#L62 , not in the command line. In any case, I already corrected it. I will perform some tests tomorrow and I will merge the branch

In the NEMO_cylc, it calls the function directly in python https://github.com/NOC-OI/NEMO_cylc/blob/0cdcdef8c0855948436d3c8ffbfdd629cfdfab99/bin/transfer_to_os.py#L62 , not in the command line.

Ah I see. Having struggled with dask, I've been working with a modified version of: transfer_to_os.sh.serial as a template. That one does use the command-line form.

@accowa , I apologize for the delay. I've been involved in several projects over the past two months and haven't had time to look at the issues.
I tested and fixed the problem related to data chunking. It is not possible to rechunk data that was in the object store. So the chunking strategy you choose for the first file must be the same for all subsequent files. If it is not the same, the code will return a warning with this information and will continue the code without changing the chunk size. I merged the changes into the dev branch.


Verify "test_install_p_all_opts" unittest on real device

Unit test fails with [INSTALL_FAILED_CONTAINER_ERROR].
It has to be checked on real device.
PS: test_install_p_sdcard has the same issue
PPS: can be realated to http://stackoverflow.com/questions/5744298/what-does-this-mean-failure-install-failed-container-error

Not actual


Does this have lamdera evergreen?

Or something like it for persisting data?

lamdera evergreen

my understanding of "evergreen" refers to the "msg migration" feature that allows deploying of new versions of the app and have the safety that a stale SPA instance on client browsers would still be able to auto upgrade itself and thus not lose a msg between client/server communications
elm-webapp does not come with "msg migration" feature. however as of 3.0.0, the generated MsgFromServer comes with ClientServerVersionMismatch
which can be leveraged to know that the client/server is out of sync and present a "Please reload this browser page" message to the end user

persisting data

elm-webapp does not persist the "model" of the server (aka serverState), unlike Lamdera.
While you can still code to update the model of Server note that the values are only held in memory and is lost when the Server process exits. Doing so is still worthwhile during development though, enabling quick iteration of the app without messing with db & schema
For reference, in my own production apps, serverState is only ever used to hold immutable server config. My server code

makes HTTP requests to query and mutate persisted data on DynamoDB
makes regular GraphQL HTTP requests to Hasura to query and mutate persisted data in a PostgreSQL database

Thanks for the write up.
The elm-webapp solution for the frontend is great and I wish more frameworks adopted it by default.
I was curious how much of lamdera was borrowed by elm-webapp and agree persistence solutions are outside the scope of the project. Thanks for the examples on what is the correct way to get persistence in elm-webapp.

Good idea @Massolari ! I've written it down in README 🙇


You forget to reference your GitHub address in the package.json file

This means that you will miss the opportunity for npm to help drive traffic to your repository. Just reminding you in case you haven't noticed.

Thanks for reporting!


Update deployment_using_gemix.md

use -s to commit please, as the following
> git commit -s -m "fix: xxx"

OR
> git commit -s -m "chore: xxx"

It can be closed now

It can be closed now

ok


Flexible Regex whitelist for PluralizeResourceNamesRule

Updated to use a whitelist of Regex patterns rather than just prefixes. Each matching regex is replaced with a / before the path is split into components and checked. So you can use:

/api/ to whitelist that term anywhere in the path
^/status/$ to whitelist a fixed standard singular path
^/legacy/.* to whitelist any path starting with a prefix
lots of other possibilities using regexes

Also refactored to use Context #714

Closes #780

Looks like I have some integration test expectations to fix... commit coming soon.

Codecov Report

Merging #785 into master will increase coverage by 0.12%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #785      +/-   ##
============================================
+ Coverage     85.52%   85.64%   +0.12%
+ Complexity     1022     1021       -1
============================================
  Files           170      170
  Lines          2721     2724       +3
  Branches        395      394       -1
============================================
+ Hits           2327     2333       +6
  Misses          196      196
+ Partials        198      195       -3

Impacted Files
Coverage Δ
Complexity Δ

...o/zally/rule/zalando/PluralizeResourceNamesRule.kt
100% <100%> (+21.42%)
14 <12> (-1)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e36908...36d8217. Read the comment docs.

@roxspring can you resolve the conflict, so and merge the master? Than we are ready to merge :).

:+1:

:+1:


If the point is exactly on the line, it gets snapped at a vertex of this line

If a point is exactly on the line, both the intersection tests will fail, because we try to find the intersection between a line starting on another one twice.
Therefore, intersectPt will be undefined and the point will be snapped to either start or stop.
I made a single intersection call instead of 2, intersecting the line with a segment composed of the result of the two destination calls (destination(pt, 1000 , direction + 90, units) and destination(pt, 1000 , direction - 90, units)).

I tested a bit more this solution and it had some problems, related to the issue #1.
I'm working on it to create a better version of the algorithm, without the use of the "project a point a thousand miles away".


refactor: make MDX export a flat TOC list instead of tree

Breaking change

The props received by TOCItems have changed. You may need to re-swizzle TOCItems. Good news is, TOC, TOCCollapsible, etc. don't need to be changed.
The documented behavior of splicing TOC headings through toc={[toc[2], toc[4]]} has been removed. If you previously used TOCInline but treated toc as an opaque data structure (only passing it as toc={toc}, you are safe; but if you relied on its tree structure properties, you may need to implement your own helper function to select all the wanted headings.

@slorber Do you think we should provide this helper function ourselves? Something like useTOCNodes([2, 4]). We may even allow a prop callback: filterTOC={(tocTree) => [toc[2], toc[4]]} which gets called after the TOC has been treeified. It would not be hard to build, just unsure of the value.
Motivation
This is a necessary step to work on #3915. See also #6201.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Made more tests

Thanks, LGTM 👍
Couldn't see any issue even on weird page like this one:
https://deploy-preview-6729--docusaurus-2.netlify.app/tests/docs/toc/toc-test-bad/
https://docusaurus.io/tests/docs/toc/toc-test-bad/

Let's wait for users to complain before implementing anything extra that maybe nobody needs


v1.1.0

Avoid RIF Data Vault dependency (#105)
Show message if there are no providers (#107)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.0%

Totals

Change from base Build 980052493:
0.0%

Covered Lines:
0

Relevant Lines:
39

💛  - Coveralls


Use balanced accuracy with adult census dataset

Inspired by this question in the forum, this PR uses balanced accuracy instead of accuracy to score a logistic regression pipeline with an interaction feature engineering step.
It feels more natural to me to use balanced accuracy as scoring metric, as it has already been used for the adult census dataset in previous notebooks.
I also took the opportunity to tweak the general wording.

I would not recommend to use the balanced accuracy because it is an arbitrary metric. I would not advise it anymore in scikit-learn as well.
Here, I don't think that the balanced ratio is that catastrophic: we could therefore compare the accuracy of a DummyClassifier predicting the majority class and mention that we need any predictive model to perform above this accuracy level to ensure that the model capture any signal.


type aliases in RegisterBlock

Depends on #644

r? @Emilgardis
(rust-highfive has picked a reviewer for you, use r? to override)

After this PR I'm planning to make release. So need more tests.
cc @newAM  @duskmoon314 @luojia65
Still not sure about #636

LGFM at the first glance
I noticed that in the generated code, the code order of many of the register fields changed. Is this intentional? (Though this doesn't infect anything. I'm just curious.)

Looks good on my projects, it would make register block definition clear, so LGTM.

I noticed that in the generated code, the code order of many of the register fields changed. Is this intentional? (Though this doesn't infect anything. I'm just curious.)

The cause should be that fields now sorted by bit offset

bors r=@Emilgardis


RenderMan 24.1 & Houdini 18.5

Hi, did you plan to update your tool for RenderMan 24 ? Cheers and thanks again for your tool.

nevermind. Thanks


feat: Updated config format for bottom >= 0.10.0

Updated .tera file to new bottom >= 0.10.0 configuration format and generated .toml files with whiskers.
Resolves #6

@sgoudham - Could you please review?


clicking Tail -f in Supervisor often just leads to an empty page that loads forever.

Vague guess: maybe the logs have moved since supervisor was configured?

It seems to be an upstream bug: https://github.com/Supervisor/supervisor/pull/471

Might just need to update supervisor -- let's see what happens. Can you reproduce this?

I can but this issue is still open, so not sure an update will help.

Seems like they have PR ready for merge?

Yeah. But no one wants to merge it. Please ping them again in this PR

I hope this is now gone with the new version.


Print real error messages even if it looks like an invalid app

This patch adds the actual error message to the user-friendly™ dialog, so developers can find out broken node modules in their own apps without being confused.

Committed at c026863, thanks!.


Some clarification on your process

Hi, just some minor clarification on your docs for Dropulation donor assignment:
When you run AssignCellsToSamples, you emit a VCF file:
--VCF_OUTPUT $DROPULATION_OUTDIR/assignment.vcf
You should use that as input in doublet detection:
DetectDoublets
 --VCF $DROPULATION_OUTDIR/assignment.vcf

The VCF emitted by AssignCellsToSamples contains only the sites with coverage in your BAM, so doublet detection will run much faster and use less memory.
You can do the same sort of trick by specifying an output BAM during AssignCellsToSamples:
BAM_OUTPUT $DROPULATION_OUTDIR/assignment.bam

then
DetectDoublets
--INPUT_BAM $DROPULATION_OUTDIR/assignment.bam

Thanks for documenting and making this code available - someone dropped by our github to report a problem then had with a temp directory not being set on their system and linked to your resource.

Thanks @jamesnemesh! I'll make those updates to the documentation. Leaving this open until I've updated

One other small clarification - I prefer to not set SAMPLE_FILE in the first step - in my opinion it's nicer to let the algo try hundreds or thousands of donors, and see that it finds the right subset of samples.  If you restrict your data set to the samples you expect, then the approach will of course assign each cell to one of those samples, though the sample may be assigned at low confidence.  It's easier to pick up unexpected donors at this step by testing a wider range of possibilities, which is something we've learned the hard way.

Thanks @jamesnemesh, I'll include a note about that as well. I think it will depend on user experimental designs but completely agree that it's very helpful for finding sample swaps.
I also just want to flag that I tagged you in another issue (#30)  that a user just brought up about low individual annotation using dropulation. I'm not sure if the way that I tagged you would notify you.

updated the docs in v3.0.0


Logger navigation for integrations doesn't entirely open

When I visit https://docs.appsignal.com/logging/platforms/integrations/ruby.html
In the navigation sidebar, the logger section opens, but not entirely:

It should look like this:

The same is true for the Elixir and Node.js integrations, as seen in the preview of PR https://github.com/appsignal/appsignal-docs/pull/859

Assigning this one to Anton to look into further


feat: toaster on node failure

The error messages are not on TDS for us to pull but at least this lets the user know that the simulation failed

You are going to hate me, but we have a logging system that shows toast already and save the logs in the back end as well.
https://github.com/DARPA-ASKEM/terarium/blob/main/packages/client/hmi-client/src/utils/logger.ts
You can see an example of it here, specially the toast title is useful: https://github.com/DARPA-ASKEM/terarium/blob/main/packages/client/hmi-client/src/services/knowledge.ts#L26-L29

That is handy!
Do you want me to move these over to logger as well?


How to print the value of CLTensor

I want to check whether the cl_sgemm is properly working.
So, I tried dst.print(std::cout) but it prints some error message 'ERROR in print src/core/ITensor.cpp:77: this->buffer() == nullptr No such file or directory'.
I didn't edit original code but just add one instruction to print the value in CLTensor.
How can i print it?
Thank you in advance.

Hi,
This means you're trying to print a tensor that hasn't been allocated or isn't mapped.
As you're using OpenCL, I assume it's the latter: you need to call CLTensor::map() before you print the content of the tensor.
Hope this helps

Hi, i used map & unmap as you advised and print function works!
Thank you!

Hi,
This means you're trying to print a tensor that hasn't been allocated or isn't mapped.
As you're using OpenCL, I assume it's the latter: you need to call CLTensor::map() before you print the content of the tensor.
Hope this helps


⚠ Fortnite has degraded performance

In d33f863, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1583 ms

Resolved: Fortnite performance has improved in 4260d64.


Migration of datatree/ops.py -> datatree_ops.py

I considered wedging this into core/ops.py, but it didn't look like it fit there.
This is a basic lift and shift from datatree_/ops.py to core/datatree_ops.py
I did fix the document addendum injection and added a couple of tests.

[x]  Contributes to migration step for miscellaneous modules in Track merging datatree into xarray #8572
[x] Tests added
[x] User visible changes (including notable bug fixes) are documented in whats-new.rst

Here's a sample of a doc page generated with these updates.  I will point to the RTD when that finishes.

Ok. The test build for docs is available to examine here https://xray--8977.org.readthedocs.build/en/8977/generated/xarray.DataTree.expand_dims.html#xarray.DataTree.expand_dims

This looks great, thank you @flamingbear ! Happy to merge?

Happy to merge?

I am.  I might take on docs next.


feat: Store API keys in secrets

Stores API Keys in secrets
Reads api keys from a file instead of an environment variable

Useful to combine with external secret managers as GCP External Secrets or Hashicorp Vault.
Does not introduce breaking changes with previous versions of the values.yaml file.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I'll take a look at this over the weekend. Sorry it's taken awhile

@davidzhao any update? We're also interested in this feature.


CTS step is taking unusually long time - 2550 secondns

Describe the bug
I have 2 similar system . On one system CTS is taking around 625 seconds while on the other system  it is taking 2550 seconds. These results are consistent.
On both system cpufreq governor is set to performance.
System 1 log: (625 seconds)
Repair setup and hold violations...
TNS end percent 100
Skipping gate cloning during optimization
[INFO RSZ-0094] Found 3457 endpoints with setup violations.
[INFO RSZ-0045] Inserted 200 buffers, 1 to split loads.
[INFO RSZ-0041] Resized 195 instances.
[INFO RSZ-0043] Swapped pins on 80 instances.
[WARNING RSZ-0062] Unable to repair all setup violations.
[INFO RSZ-0033] No hold violations found.

TNS end percent 100
Skipping gate cloning during optimization
[INFO RSZ-0094] Found 3459 endpoints with setup violations.
[INFO RSZ-0045] Inserted 539 buffers, 1 to split loads.
[INFO RSZ-0041] Resized 2955 instances.
[INFO RSZ-0043] Swapped pins on 118 instances.
[WARNING RSZ-0062] Unable to repair all setup violations.
[INFO RSZ-0033] No hold violations found.
Placement Analysis
total displacement       6384.6 u
average displacement        0.0 u
max displacement           19.6 u
original HPWL         5567471.6 u
legalized HPWL        5572355.7 u
delta HPWL                    0 %
The difference i see here with respect to total displacement.
Please do let me know how to fix this.
Expected Behavior
CTS should take  around 625 seconds in both systems. As that is nearer to golden value.
Environment
kernel: Linux 5.15.0-86-generic
os: Ubuntu 22.04.3 LTS (Jammy Jellyfish)
cmake version 3.24.2
-- The CXX compiler identification is Clang 16.0.3
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /home/amd/compiler/aocc4.1/aocc-compiler-rel-4.1.0-4451-270/bin/clang++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- OpenROAD version: v2.0-10770-g6719c92e6
-- System name: Linux
-- Compiler: Clang 16.0.3
-- Build type: RELEASE
-- Install prefix: /usr/local
-- C++ Standard: 17
-- C++ Standard Required: ON
-- C++ Extensions: OFF
-- The C compiler identification is Clang 16.0.3
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /home/amd/compiler/aocc4.1/aocc-compiler-rel-4.1.0-4451-270/bin/clang - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Found Python: /usr/bin/python3.10 (found version "3.10.12") found components: Interpreter
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Performing Test C_COMPILER_SUPPORTS__-O3
-- Performing Test C_COMPILER_SUPPORTS__-O3 - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-O3
-- Performing Test CXX_COMPILER_SUPPORTS__-O3 - Success
-- Performing Test C_COMPILER_SUPPORTS__-march=native
-- Performing Test C_COMPILER_SUPPORTS__-march=native - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-march=native
-- Performing Test CXX_COMPILER_SUPPORTS__-march=native - Success
-- Performing Test C_COMPILER_SUPPORTS__-flto
-- Performing Test C_COMPILER_SUPPORTS__-flto - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-flto
-- Performing Test CXX_COMPILER_SUPPORTS__-flto - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wall
-- Performing Test C_COMPILER_SUPPORTS__-Wall - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wall
-- Performing Test CXX_COMPILER_SUPPORTS__-Wall - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-array-bounds
-- Performing Test C_COMPILER_SUPPORTS__-Wno-array-bounds - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-array-bounds
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-array-bounds - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-nonnull
-- Performing Test C_COMPILER_SUPPORTS__-Wno-nonnull - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-nonnull
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-nonnull - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-maybe-uninitialized
-- Performing Test C_COMPILER_SUPPORTS__-Wno-maybe-uninitialized - Failed
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-maybe-uninitialized
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-maybe-uninitialized - Failed
-- Performing Test C_COMPILER_SUPPORTS__-Wno-format-overflow
-- Performing Test C_COMPILER_SUPPORTS__-Wno-format-overflow - Failed
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-format-overflow
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-format-overflow - Failed
-- Performing Test C_COMPILER_SUPPORTS__-Wno-unused-variable
-- Performing Test C_COMPILER_SUPPORTS__-Wno-unused-variable - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-unused-variable
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-unused-variable - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-unused-function
-- Performing Test C_COMPILER_SUPPORTS__-Wno-unused-function - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-unused-function
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-unused-function - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-write-strings
-- Performing Test C_COMPILER_SUPPORTS__-Wno-write-strings - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-write-strings
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-write-strings - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-sign-compare
-- Performing Test C_COMPILER_SUPPORTS__-Wno-sign-compare - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-sign-compare
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-sign-compare - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-deprecated
-- Performing Test C_COMPILER_SUPPORTS__-Wno-deprecated - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-deprecated
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-deprecated - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-c++11-narrowing
-- Performing Test C_COMPILER_SUPPORTS__-Wno-c++11-narrowing - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-c++11-narrowing
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-c++11-narrowing - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-register
-- Performing Test C_COMPILER_SUPPORTS__-Wno-register - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-register
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-register - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-format
-- Performing Test C_COMPILER_SUPPORTS__-Wno-format - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-format
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-format - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-reserved-user-defined-literal
-- Performing Test C_COMPILER_SUPPORTS__-Wno-reserved-user-defined-literal - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-reserved-user-defined-literal
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-reserved-user-defined-literal - Success
-- Performing Test C_COMPILER_SUPPORTS__-fpermissive
-- Performing Test C_COMPILER_SUPPORTS__-fpermissive - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-fpermissive
-- Performing Test CXX_COMPILER_SUPPORTS__-fpermissive - Success
-- Performing Test C_COMPILER_SUPPORTS__-x
-- Performing Test C_COMPILER_SUPPORTS__-x - Failed
-- Performing Test CXX_COMPILER_SUPPORTS__-x
-- Performing Test CXX_COMPILER_SUPPORTS__-x - Failed
-- Performing Test C_COMPILER_SUPPORTS__c++
-- Performing Test C_COMPILER_SUPPORTS__c++ - Failed
-- Performing Test CXX_COMPILER_SUPPORTS__c++
-- Performing Test CXX_COMPILER_SUPPORTS__c++ - Failed
-- Performing Test C_COMPILER_SUPPORTS__-Wno-unused-but-set-variable
-- Performing Test C_COMPILER_SUPPORTS__-Wno-unused-but-set-variable - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-unused-but-set-variable
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-unused-but-set-variable - Success
-- TCL library: /usr/lib/x86_64-linux-gnu/libtcl.so
-- TCL header: /usr/include/tcl/tcl.h
-- TCL readline library: /usr/lib/x86_64-linux-gnu/libtclreadline.so
-- TCL readline header: /usr/include/x86_64-linux-gnu
-- Found SWIG: /usr/bin/swig4.0 (found suitable version "4.0.2", minimum required is "3.0")
-- Found Boost: /usr/local/lib/cmake/Boost-1.83.0/BoostConfig.cmake (found version "1.83.0")
-- boost: 1.83.0
-- Found Python3: /usr/include/python3.10 (found version "3.10.12") found components: Development Development.Module Development.Embed
-- Found ZLIB: /usr/lib/x86_64-linux-gnu/libz.so (found version "1.2.11")
-- spdlog: 1.9.2
-- Found BISON: /usr/bin/bison (found version "3.8.2")
-- Found Doxygen: /usr/bin/doxygen (found version "1.9.1") found components: doxygen dot
-- STA version: 2.4.0
-- STA git sha: 1fed0491bb9e84c9622b7e984821e0711502a14e
-- System name: Linux
-- Compiler: Clang 16.0.3
-- Build type: RELEASE
-- Build CXX_FLAGS: -O3 -DNDEBUG
-- Install prefix: /usr/local
-- Found FLEX: /usr/bin/flex (found version "2.6.4")
-- TCL library: /usr/lib/x86_64-linux-gnu/libtcl.so
-- TCL header: /usr/include/tcl/tcl.h
-- SSTA: 0
-- STA executable: /home/amd/sandeep/benchmarking/ORFS/AOCC/OpenROAD-flow-scripts/tools/OpenROAD/src/sta/app/sta
-- Found re2: /opt/or-tools/lib/cmake/re2/re2Config.cmake (found version "9.0.0")
-- Found Clp: /opt/or-tools/lib/cmake/Clp/ClpConfig.cmake (found version "1.17.7")
-- Found Cbc: /opt/or-tools/lib/cmake/Cbc/CbcConfig.cmake (found version "2.10.7")
-- Found SCIP: /opt/or-tools/lib/cmake/scip/scip-config.cmake (found version "8.0.1")
-- Found OpenMP_CXX: -fopenmp=libomp (found version "5.0")
-- Found OpenMP: TRUE (found version "5.0")
-- GPU is not enabled
-- TCL library: /usr/lib/x86_64-linux-gnu/libtcl.so
-- TCL header: /usr/include/tcl/tcl.h
-- Found Eigen3: /usr/local/share/eigen3/cmake/Eigen3Config.cmake (found version "3.4.0")
-- GUI is enabled
-- Charts widget is enabled
-- Found Boost: /usr/local/lib/cmake/Boost-1.83.0/BoostConfig.cmake (found version "1.83.0") found components: serialization
-- Could NOT find VTune (missing: VTune_LIBRARIES VTune_INCLUDE_DIRS)
-- Found Boost: /usr/local/lib/cmake/Boost-1.83.0/BoostConfig.cmake (found suitable version "1.83.0", minimum required is "1.78")
-- TCL library: /usr/lib/x86_64-linux-gnu/libtcl.so
-- TCL header: /usr/include/tcl/tcl.h
-- Found Boost: /usr/local/lib/cmake/Boost-1.83.0/BoostConfig.cmake (found version "1.83.0") found components: serialization system thread
-- TCL readline enabled
-- Tcl Extended disabled
-- Python3 enabled
-- Configuring done
-- Generating done
-- Build files have been written to: /tmp/tmp.8IHetRMv7r

To Reproduce
This issue is specific to one of  the server i am working on.
Relevant log output
No response
Screenshots
No response
Additional Context
No response

Are the binaries on both systems byte for byte identical? Also do you have a test case that you can share with us?

What are the two systems?  You are getting different answers so something is varying beyond runtime.

The binaries are not byte to byte identical. But both are built with same compiler(AOCC). Binary size is almost similar i.e OpenRoad is 79 MB on both systems.  Both are AMD servers with similar configuration .

Why not use the same binary to eliminate a source of difference?  Also is the input data identical?

@sandeep-amd if you send an email to<EMAIL_ADDRESS>we can get connected and figure out how to solve this. -Tom

Yes the input data is identical as it is being run using Open Road Flow Scripts.
Also, if yoy see the log, major difference seems to be in this step.
[INFO RSZ-0045] Inserted 200 buffers, 1 to split loads.
[INFO RSZ-0041] Resized 195 instances.
[INFO RSZ-0043] Swapped pins on 80 instances.
#################################################################
[INFO RSZ-0045] Inserted 539 buffers, 1 to split loads.
[INFO RSZ-0041] Resized 2955 instances.
[INFO RSZ-0043] Swapped pins on 118 instances.
#################################################################
Why it has inserted more buffers(200 vs 539) and resized more instances (195 vs 2955) ? What does these steps do ?

@sandeep-amd if you send an email to<EMAIL_ADDRESS>we can get connected and figure out how to solve this. -Tom

i will send an email

It is performing timing optimization.  You need to use the same build of OR to have comparable results.  The simplest way to ensure that would be to use the same binaries on both machines.

Were you able to connect with @tspyrou ?

@sandeep-amd I don't think that we connected yet.


Please do not remove the slickGoTo prop!

I've managed to get Slick's asNavFor functionality working between two react-slick sliders. However, this functionality relies on the slickGoTo prop (I pass the index of the nav slider to the main slider's slickGoTo prop, which creates the nav functionality).
However, in the console, I see the following warning:
react-slick deprecation warning: slickGoTo prop is deprecated and it will be removed in next release. Use slickGoTo method instead
Unfortunately, the slickGoTo method does not work for coordinating the indexes of two separate sliders that are rendered in different render() methods. (In my case, the two sliders are each separate great-grandchildren of the parent component, so this.refs.main-slider-grandparent.slickGoTo() doesn't work).
Please do not deprecate the slickGoTo property. It works well for simulating asNavFor.

asNavFor feature will be implemented

asNavFor has been implemented and will be released soon.


A pre-commit hook for exporting models to json schemas

Checks

[x] I added a descriptive title to this issue
[x] I have searched (google, github) for similar issues and couldn't find anything
[x] I have read and followed the docs and couldn't find an answer
[x] After submitting this, I commit to one of:

Look through open issues and helped at least one other person
Hit the "watch" button on this repo to receive notifications and I commit to help at least 2 people that ask questions in the future
Implement a Pull Request for a confirmed bug

Question
Recently wrote a very simply pre-commit hook that takes models from input directory and dumps json schemas to output directory. Feel like users in this community might find this useful -> https://github.com/aorumbayev/pydantic-to-schema.
Was wondering if there is a third party integrations section in docs or something similar to that where I can list this pre-commit hook ?

@samuelcolvin any opinion on this?

@samuelcolvin any opinion on this?

Thanks for using pydantic. 🙏
As part of a migration to using discussions and cleanup old issues, I'm closing all open issues with the "question" label. 💭 🆘 🚁
I hope you've now found an answer to your question. If you haven't, feel free to start a :point_right: question discussion.


Add test case to use starlette DatabaseMiddleware

Locally I run docker run --name fastapi-postgres -e POSTGRES_PASSWORD=bar -e POSTGRES_USER=foo -e POSTGRES_DB=fastapi -p 5432:5432 -d postgres to get the db up, mimics in travis with the postgresql service
There are 2 test classes, TestStarletteStyle and TestFastAPIStyle:

TestStarletteStyle is in fact a way to get the very same tests performed in starlette with either a FastApi object or a Starlette one. The name StarletteStyle just refers to the fact it uses the app.route decorator provided by starlette

TestFastAPIStyle is just an attempt at using the get / post decorators provided by FastAPI with the very same tests

Hope it gives some clues at using the DatabaseMiddleware
Fixes my questions on #14 :rofl:

Thanks a lot for your work @euri10 !
And thanks @pflorek for helping to check it :)
It's great to see you guys getting involved here :clap: :taco:
I'll review it soon, I want to make sure to see how standard SQLAlchemy, https://github.com/encode/databases, and Starlette's database utils play together.

fair enough, seems like they want to push out DatabaseMiddleware in favor of https://github.com/encode/databases in which case this will soon become the old way of doing things

closing, as per @tiangolo remark it's easier, simpler and nicer to use databases

Thanks for coming back and closing it!


Missing support for Web Analytics

Current Terraform and Cloudflare provider version
Terraform v1.2.8
on darwin_arm64

Description
I have not found a way to configure Cloudflare web analytics with Terraform
Use cases
Our use case is that we need to disable the web analytics "automatic setup" (the way they setup their JS tracking script) and we want to have this setting synced by Terraform rather than manually in the UI
Potential Terraform configuration
Not experienced enough with Terraform to suggest good example
References
No response

@jacobbednarz hey, can you double check that the #1887 fixes this issue, it seems to be unrelated.

you're right, looks like the issue number was off by one.

This issue has been closed as we are now tracking this internally with service teams directly. If you would like an update or to be notified when/if the product ships with this change, please reach out to Cloudflare Support or your account team who can watch the internal feature request for you.


Add minitest adapter [wip]

Requested feature https://github.com/ArturT/knapsack/issues/14
TODO

[x] bind to before and after hooks
[ ] MinitestAdapter.test_path should return test file path for executing test.
[ ] rake taks knapsack:minitest should run selected tests in single command lib/tasks/knapsack_minitest.rake
[ ] add spec for adapter
[ ] create a new repo with example project and minitest test suite using knapsack

I found AbstractReporter, it might be useful https://github.com/seattlerb/minitest/blob/master/lib/minitest.rb#L403-640

This might be helpful to define rake task with specified list of test files for each CI node.
http://www.rubyinside.com/a-minitestspec-tutorial-elegant-spec-style-testing-that-comes-with-ruby-5354.html
require 'rake/testtask'

Rake::TestTask.new do |t|
  t.libs.push "lib"
  t.test_files = FileList['test/*_test.rb']
  t.verbose = true
end


Mouse over a variable + ctrl key pressed output panel pops up

VSCode Version: 1.49.3 (system setup)
OS Version:  Windows_NT x64 10.0.19041

Steps to Reproduce:
I've recorded my screen to explain this bug. Please view it at:  https://youtu.be/irbWUR09_2Y
and here's the code to help you reproduce this bug.
const questions = [
  {
    question: "What is 10 + 10?",
    options: ["8", "20", "28", "30"],
    answer: "20"
  },
  {
    question: "What is Athena's favoirt animal?",
    options: ["jellyfish", "penguins", "otters"],
    answer: "otters"
  },
]

let question_number = 0;
let correct = 0;

document.addEventListener( 'DOMContentLoaded', () => {
  load_question();
} );

function load_question () {
  document.querySelector( '#question' ).innerHTML = questions[question_number].question;
  const options = document.querySelector( '#options' );
  options.innerHTML = '';
  for ( const option of questions[question_number].options ) {
    options.innerHTML += `<button class="option">${ option }</button>`;
  }

  let answer = questions[question_number].answer;
  let counter = document.querySelector( '#correct' );
  let questionCount = questions.length

  document.querySelectorAll( '.option' ).forEach( option => {
    option.onclick = () => {
      if ( option.textContent === answer || question_number < questionCount) {
        question_number++;
        correct++;
        counter.innerHTML = `${correct} of ${question_number}`;
        load_question();

      } else if (option.textContent !== answer || questionCount < question_number) {
				question_number++;
				counter.innerHTML = `${correct} of ${question_number}`;
				load_question();
			} else {
				console.log('done');
			}
    }
  });
}

Please let me know if you need more information. Thanks.

Does this issue occur when all extensions are disabled?: Yes/No

The reason why this is happening is that your Output panel is on CSS peek. According to the CSS peek creator:

'This extension extends HTML and ejs code editing with Go To Definition and Go To Symbol in Workspace support for css/scss/less (classes and IDs) found in strings within the source code'

So basically it not designed to work inside a Javascript file. You can create an issue in the Css Peek Repo and make a feature request so that it automatically ignores js files.

@mocktarissa Super! I've tested by disabling CSS peek and you're correct. Thank you!

/causedByExtension - thanks @mocktarissa


Copied reports module from niworkflows

Fixed tests to run successfully and made minor modifications to match the new package.
@oesteban / @effigies there's still a lot of work on this, but I was thinking perhaps we could merge it and work incrementally to remove dependencies, add whatever's missing, etc. What do you think?

Codecov Report

Merging #22 (bc7113b) into main (5a6f556) will decrease coverage by 72.86%.
The diff coverage is 10.33%.

@@             Coverage Diff             @@
##             main      #22       +/-   ##
===========================================
- Coverage   87.50%   14.63%   -72.87%
===========================================
  Files           2        5        +3
  Lines          16      287      +271
===========================================
+ Hits           14       42       +28
- Misses          2      245      +243

Impacted Files
Coverage Δ

nireports/core.py
3.65% <3.65%> (ø)

nireports/tests/test_core.py
6.59% <6.59%> (ø)

nireports/conftest.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a6f556...bc7113b. Read the comment docs.

Here is a list of the code that needs to be ported from niworkflows:

niworkflows.reports
niworkflows.viz

notebooks -> assembler
plots -> reportlets

niworkflows.interfaces.plotting -> reportlets
niworkflows.test.test_viz


Prometheus source now supports logging/metrics/tracing CMs

Signed-off-by: Francesco Guardiani<EMAIL_ADDRESS>Fixes #1196
Proposed Changes

PrometheusSource controller now uses source.WatchConfigurations to watch logging/metrics/tracing CMs

/retest

/retest


Logging injection support

this one probably can come after https://github.com/E-xyza/ex_term/issues/6


Fine-tuning across 2 servers

The fine-tuning process of the GOT OCR model across two separate machines eventually results in a timeout
Command machine1:
CUDA_VISIBLE_DEVICES=0,1 NNODES=2 NODE_RANK=0 MASTER_ADDR=<IP_ADDRESS> MASTER_PORT=23456 NPROC_PER_NODE=2 swift sft --model_type got-ocr2 --model_id_or_path stepfun-ai/GOT-OCR2_0 --sft_type lora --dataset /home/epop/DATASET/ds_1mil_rec/ds_1mil_rec/train_structured_data.jsonl --output_dir output --deepspeed default-zero2

Command machine2:
CUDA_VISIBLE_DEVICES=0,1 NNODES=2 NODE_RANK=1 MASTER_ADDR=<IP_ADDRESS> MASTER_PORT=23456 NPROC_PER_NODE=2 swift sft --model_type got-ocr2 --model_id_or_path stepfun-ai/GOT-OCR2_0 --sft_type lora --dataset /home/epop/DATASET/ds_1mil_rec/ds_1mil_rec/train_structured_data.jsonl --output_dir output --deepspeed default-zero2

Once i start the scripts, i see no activity on the GPUs, the ports are open but nothing runs.
Error message:
nohup: ignoring input
run sh: `/home/epop/anaconda3/envs/msswift_transformers4.45/bin/python -m torch.distributed.run --nproc_per_node 2 --master_port 23456 --nnodes 2 --node_rank 0 --master_addr <IP_ADDRESS> /home/epop/ms-swift/swift/cli/sft.py --model_type got-ocr2 --model_id_or_path stepfun-ai/GOT-OCR2_0 --sft_type lora --dataset /home/epop/DATASET/ds_paddle_1mil_rec/ds_paddle_1mil_rec/train_structured_data.jsonl --output_dir output --deepspeed default-zero3 --save_on_each_node true`
WARNING:__main__:
*****************************************
Setting OMP_NUM_THREADS environment variable for each process to be 1 in default, to avoid your system being overloaded, please further tune the variable for optimal performance in your application as needed.
*****************************************
[W1115 08:25:14.545635588 socket.cpp:462] [c10d] waitForInput: poll for socket SocketImpl(fd=11, addr=[circle]:42438, remote=[circle]:23456) returned 0, likely a timeout
[W1115 08:25:14.548684749 socket.cpp:487] [c10d] waitForInput: socket SocketImpl(fd=11, addr=[circle]:42438, remote=[circle]:23456) timed out after 900000ms
Traceback (most recent call last):
  File "/home/epop/anaconda3/envs/msswift_transformers4.45/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/home/epop/anaconda3/envs/msswift_transformers4.45/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/home/epop/anaconda3/envs/msswift_transformers4.45/lib/python3.10/site-packages/torch/distributed/run.py", line 923, in <module>
    main()
  File "/home/epop/anaconda3/envs/msswift_transformers4.45/lib/python3.10/site-packages/torch/distributed/elastic/multiprocessing/errors/__init__.py", line 355, in wrapper
    return f(*args, **kwargs)
  File "/home/epop/anaconda3/envs/msswift_transformers4.45/lib/python3.10/site-packages/torch/distributed/run.py", line 919, in main
    run(args)
  File "/home/epop/anaconda3/envs/msswift_transformers4.45/lib/python3.10/site-packages/torch/distributed/run.py", line 910, in run
    elastic_launch(
  File "/home/epop/anaconda3/envs/msswift_transformers4.45/lib/python3.10/site-packages/torch/distributed/launcher/api.py", line 138, in __call__
    return launch_agent(self._config, self._entrypoint, list(args))
  File "/home/epop/anaconda3/envs/msswift_transformers4.45/lib/python3.10/site-packages/torch/distributed/launcher/api.py", line 260, in launch_agent
    result = agent.run()
  File "/home/epop/anaconda3/envs/msswift_transformers4.45/lib/python3.10/site-packages/torch/distributed/elastic/metrics/api.py", line 137, in wrapper
    result = f(*args, **kwargs)
  File "/home/epop/anaconda3/envs/msswift_transformers4.45/lib/python3.10/site-packages/torch/distributed/elastic/agent/server/api.py", line 696, in run
    result = self._invoke_run(role)
  File "/home/epop/anaconda3/envs/msswift_transformers4.45/lib/python3.10/site-packages/torch/distributed/elastic/agent/server/api.py", line 849, in _invoke_run
    self._initialize_workers(self._worker_group)
  File "/home/epop/anaconda3/envs/msswift_transformers4.45/lib/python3.10/site-packages/torch/distributed/elastic/metrics/api.py", line 137, in wrapper
    result = f(*args, **kwargs)
  File "/home/epop/anaconda3/envs/msswift_transformers4.45/lib/python3.10/site-packages/torch/distributed/elastic/agent/server/api.py", line 668, in _initialize_workers
    self._rendezvous(worker_group)
  File "/home/epop/anaconda3/envs/msswift_transformers4.45/lib/python3.10/site-packages/torch/distributed/elastic/metrics/api.py", line 137, in wrapper
    result = f(*args, **kwargs)
  File "/home/epop/anaconda3/envs/msswift_transformers4.45/lib/python3.10/site-packages/torch/distributed/elastic/agent/server/api.py", line 513, in _rendezvous
    workers = self._assign_worker_ranks(
  File "/home/epop/anaconda3/envs/msswift_transformers4.45/lib/python3.10/site-packages/torch/distributed/elastic/metrics/api.py", line 137, in wrapper
    result = f(*args, **kwargs)
  File "/home/epop/anaconda3/envs/msswift_transformers4.45/lib/python3.10/site-packages/torch/distributed/elastic/agent/server/api.py", line 590, in _assign_worker_ranks
    role_infos_bytes = store.multi_get(
torch.distributed.DistStoreError: wait timeout after 900000ms, keys: /none/torchelastic/role_info/0, /none/torchelastic/role_info/1

The issue was different cuda versions on the two machines, once all that was fixed, the fine tuning resumed properly


fix(sort): no focus indication for active header

Currently we rely on the arrow being toggled as focus indication in the sort header, but if the header is active, the arrow will always be visible so the user won't have a way of telling where focus is. These changes add an outline around the text for keyboard and programmatic focus.
Fixes #17716.
For reference:

I've switched it to a border-bottom @jelbourn.


blame text is covered by indentlines

Describe the bug
I use https://github.com/lukas-reineke/indent-blankline.nvim
It draws indentation lines and does this by drawing virtual text in empty lines.
gitsigns puts the blame lines left-aligned, so is expects to use the same position as the other plug-in. They overlap and the other win gets rendered.
Is there any way I can make these draw aligned with respect to existing virtual text?
Or should indentlines be doing something different?
To Reproduce
  use {
    'lukas-reineke/indent-blankline.nvim',
    branch='lua',
  }

  use {
    'lewis6991/gitsigns.nvim',
    requires = { 'nvim-lua/plenary.nvim' },
    config = [[require('gitsigns').setup{ current_line_blame = true]]
  }

Steps to reproduce the behavior:

Use the following sample text:

 add = {hl='GitSignsAdd', text = '▋'},
 change = {hl = 'GitSignsChange',text= '▋'},
 delete = {hl= 'GitSignsDelete', text = '▁ '},
 topdelete = {hl ='GitSignsDelete',text = '▔'},
 changedelete = {hl = 'GitSignsChange', text = '▎'},

},
current_line_blame = true
}```

Go to line 8.

Observed output

You'll see:
   |ot Committed Yet

Screenshots

Additional context
System: Mac, Linux (including dist), Linux
Neovim version: 0.4.0.r3650.g75992f2ad-1 (HEAD)

indent-blankline.nvim uses nvim_buf_set_virtual_text whereas gitsigns uses nvim_buf_set_extmark to set virtual text.
nvim_buf_set_virtual_text has not priority option so we can't control whether it will display over other virtual texts or not. However nvim_buf_set_extmark does have a priority option although gitsigns currently does not use it.
To resolve this issue both plugins need to use nvim_buf_set_extmark with a given priority (gitsigns > indentline).

Thanks for looking into it!
So indent-blankline.nvim would need to use nvim_buf_set_extmark, likely with a priority of 0, since it always wants to be on the far left.
gitsigns would need to use a higher priority, since it always wants to be on the far right. If that's already the case, then I guess there's nothing to be done here.
I'll cross-post the issue to indent-blankline.nvim though. Or maybe figure out if it's simple enough and I can address it.

Looks like theres activity in core and indent-blankline on this. Going to close this but will reopen on request.


Synthesis failed for Translate

Hello! Autosynth couldn't regenerate Translate. :broken_heart:
Here's the output from running synth.py:
Cloning into 'working_repo'...
fatal: write error: No space left on device
OSError: [Errno 28] No space left on device

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/kbuilder/.pyenv/versions/3.6.1/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/kbuilder/.pyenv/versions/3.6.1/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmpfs/src/git/autosynth/autosynth/synth.py", line 223, in <module>
    main()
  File "/tmpfs/src/git/autosynth/autosynth/synth.py", line 174, in main
    configure_git(args.github_user, args.github_email)
  File "/tmpfs/src/git/autosynth/autosynth/synth.py", line 58, in configure_git
    fh.write(GLOBAL_GITIGNORE)
OSError: [Errno 28] No space left on device

Google internal developers can see the full log here.

@yoshi-automation @yoshi-kokoro Is there a way I can debug and try to fix this bug? I would love to contribute

@sandeshsoni Thanks for the offer! In this case, I think we just had a disk failure in the internal automated job we use to update the client code when the IDL changes. We'll just rerun those jobs. But if you have particular things you're interested in working on, or issues you'd like to fix, feel free to open or comment on one of the other issues.


Yd/adds streaming app

Everything is good, but I don't see initErrorTracking(), logPublicEnvs() and initAnalytics() calls from index.tsx?

Fixed


Upgrade the license-gradle-plugin to version 0.14.0

This fixes the
Could not get unknown property 'source'

error.
Also consistently use Gradle 2.1 syntax to load plugins and align the
formatting a bit.

Interesting that this fails on CI. Can it be that you're running an old Gradle version < 3.0 in there? If so, could we please upgrade that?

@sschuberth It's definitely time we updated Gradle. We'll get on that.

Gradle version upgraded in PR #364

@kdykeman I've rebased this onto upstream master to resolve conflicts.


Add option --stats-out to emit webpack statistics output

Add options to output Webpack statistics JSON to enable further analysis.

Thank you! Will this be released soon?

Released in https://github.com/zeit/ncc/releases/tag/0.22.0


custom css removes highlights

for whatever reason the highlightStyles property is an empty string when calling refreshHomePage.
creating them again and telling myself to find a better fix later, to never get around to do that sounds reasonable...


Win tabs not showing all opened files when opening multiple files quickly

I am writing a little bit of Vim script where there is a function that takes a list of file names, and I want it to open all of those files as buffers in the current tab. (The purpose of the script is to be able to select multiple filenames with fzf and open them all at once in new buffers)
To simulate such behaviour, we can run something like this.
vi
:for name in ['tsconfig.json', 'tslint.json']
  execute 'e ' . fnameescape(name)
endfor

Ideally this should open up two buffers, and show both in the tab line. The above script only appears to leave the last of the two files in the tab line.

This is caused by a technical limit of how wintabs detect new buffer. I'll find a solution soon (manually notifying wintabs of new buffers).

I was thinking about the feasibility of a function called something like wintabs_open_file(path). It doesn't seem like a hacky solution. What do you think?

@dylan-chong sorry for the long delay, the issue is more involving than it seemed.
I fixed the WintabsRefresh command so it should refresh the buffer list correctly. You'll need to call this command inside chain edits:
for name in ['tsconfig.json', 'tslint.json']
  execute 'e ' . fnameescape(name)
  WintabsRefresh
endfor


Still encountering "stagingRepositoryId is not provided"

Hello!
I'm trying to put together a simple testing project in an effort to give developers at the NYPL something they can use to run through the process of deploying to Maven Central (without needing to do a real deployment of a real app). The structure of the project matches that of the larger projects at the NYPL, but only contains a single module and very little code. Here's the project:
https://github.com/NYPL-Simplified/Maven-Central-Testing
I'm trying to bulletproof it, and part of that involves using the nexus-publish-plugin so that we know staging repository IDs explicitly instead of having the gradle-nexus-staging-plugin try to guess them. We have multiple developers pushing different projects to the same staging profile, and without having explicit staging repository IDs, the gradle-nexus-staging-plugin essentially breaks immediately (due to the documented and expected Wrong number of received repositories problem).
As far as I can make out, I've configured everything correctly in the project's build.gradle setup, and I'm applying both plugins so that, if the nexus-publish-plugin documentation can be believed, I should be using explicit staging repository IDs when I ./gradlew clean assemble publish closeAndReleaseRepository. Unfortunately, it appears that I'm not. I still see "DEPRECATION WARNING. The staging repository ID is not provided. The fallback mode may impact release reliability and is deprecated. Please consult the project FAQ how it can be fixed.".
What am I doing wrong? I've attached a log of a build that deployed and released on Central successfully, but I suspect that it would not have been successful had someone else been pushing something to the staging profile at the same time.
log.txt

Hello! I took a look at your build configuration and logs and it seems that nexus-publish-plugin (NPP) doesn't wrap your publish tasks with publishing to the implicitly created staging repository (and in fact doesn't create it at all). In that situation gradle-nexus-staging-plugin (GNSP) can only guess which repository should be closed (which seems to work as fallback).
@marcphilipp is it possible that Android uses some other kind of publishing (or it is configured in different way) which could not be detected by NPP?

'Ello.
This has actually become a bigger problem for us: The plugin appears to now be effectively unreliable enough in this configuration that we can almost never deploy to Central using it. I think this is probably interacting with the staging latency problems Central has been having lately.

I do have the same warning message:
> Task :closeRepository
DEPRECATION WARNING. The staging repository ID is not provided. The fallback mode may impact release reliability and is deprecated. Please consult the project FAQ how it can be fixed.

@RoRoche Have you consulted the project FAQ?

@RoRoche Have you consulted the project FAQ?

Yes, but I didn't find anything about this deprecation.

Please try this one. You might propose a PR with changes adding the 3rd point in FAQ with that exact warning message.

I followed steps described in your blog post: https://solidsoft.wordpress.com/2019/02/22/reliable-releasing-to-maven-central-from-travis-using-gradle-2019-edition/
My configuration is here: https://github.com/RoRoche/elegant-android/blob/master/build.gradle
And here: https://github.com/RoRoche/elegant-android/blob/master/publish/publish_kotlin_library.gradle
But I'm still having:
DEPRECATION WARNING. The staging repository ID is not provided. The fallback mode may impact release reliability and is deprecated. Please consult the project FAQ how it can be fixed.
Requested operation was executed successfully in attempt 8 (maximum allowed 21)

Any idea of what I'm doing wrong?

Hmm,. I wonder if you don't need to apply plugin: "de.marcphilipp.nexus-publish" in the (sub)project you releasing. As opossed to my GNSP plugin which should be applied in the root project, NPP plays with the publications.
Btw, do you have a link to the CI server where the build takes place?

TL;TD. That problem should not exist in unified gradle-nexus-publish-plugin.
A longer version. To make releasing to Maven Central even easier, I and Marc Phillip (the author of nexus-publish-plugin) combined forces to create a next generation, unified, 2-in-1 plugin - gradle-nexus-publish-plugin. It is a recommended solution, as our development effort will be put in that new plugin. See my blog post and the official migration guide.


Config: remove me as a maintainer

I'm not using exercism myself anymore and even though this repo is pretty
low-traffic, I don't have enough time to spend on it and keeping up with all the
changes in the exercism org.
Thanks!

Thanks for your work, @mhinz, and good luck with whatever you're doing with your time instead 💙


Delete all Cargo configuration

r? @brson
(rust_highfive has picked a reviewer for you, use r? to override)