[SPARK-36644][SQL][FOLLOWUP] Push down boolean column filter for Data Srouce V2

What changes were proposed in this pull request?
This PR proposes to improve DataSourceV2Strategy to be able to push down boolean column filters. Currently boolean column filters do not get pushed down and may cause unnecessary IO.
This is a follow up PR of the same change for (V1) DataSourceStrategy.
Why are the changes needed?
The following query does not push down the filter in the current implementation
SELECT * FROM t WHERE boolean_field

although the following query pushes down the filter as expected.
SELECT * FROM t WHERE boolean_field = true

This is because the Physical Planner (DataSourceV2Strategy) currently only pushes down limited expression patterns likeEqualTo.
It is fair for Spark SQL users to expect boolean_field performs the same as boolean_field = true.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added unit tests

cc @sunchao @viirya @huaxingao @HyukjinKwon @cloud-fan

@kazuyukitanimura Thanks for working on this! Overall the PR looks good to me. I am just thinking the newly added test DataSourceV2StrategySuite is sufficient for the change. It seems to me that we only need to test if the boolean column filter can be translated correctly, but we don't have to add a new test in DataSourceV2Suite to check if the boolean column filter can be pushed down. If a filter can be translated correctly, it should be pushed down for sure. That path has been very well tested, so I guess we can keep the test simple :)

+1 to @huaxingao 's suggestion

Thank you @huaxingao @cloud-fan, removed the changes in DataSourceV2Suite. Please have another look.

Thank you @sunchao @viirya
Since what we are testing is within DataSourceV2Strategy, I think DataSourceV2StrategySuite name makes sense.
In addition, We have a counter part of V1 for this, DataSourceStrategy and DataSourceStrategySuite, so it is consistent.
I can plan to add more tests in DataSourceV2StrategySuite for other expressions (e.g. GreaterThan...) in the future.
Thoughts?

Merged to master, thanks @kazuyukitanimura!


Lists cannot be put into dictionaries

When I try to create a dictionary containing a list, the list gets replaced by a key. I will give additional information if you need it.

ah wait list get filtered as a key
you cannot have list/dictionaries as keys (should probally make it a mishap)
wait is the list being the key or the value?
because the set function is here
so I dont see how it should be mixing it up

can you share your hex because The problem isn't jumping out at me looking at the functions for setting iota values


jekyll-3.0.0.pre.beta8 conflicts

Tried to fire up the latest Jekyll beta to test and get the following error on jekyll build.
Configuration file: /_config.yml
/.rvm/rubies/ruby-2.1.0/lib/ruby/site_ruby/2.1.0/rubygems/specification.rb:2064:in `raise_if_conflicts': Unable to activate jekyll-archives-2.0.0, because jekyll-3.0.0.pre.beta8 conflicts with jekyll (~> 2.4) (Gem::LoadError)

Isn’t this just a problem with the jekyll-archives gem’s dependancy?

Why post twice? This is the same as #45

I assumed they were different types of errors... one was from installing the gem the other when running jekyll build or jekyll serve. They likely have the same route cause but I wasn't sure so I submitted 2 issues.

I'm considering perhaps rewriting the plugin a bit, since 3.0 adds a hooks feature which may become quite useful. Thanks for the heads-up!

Works now with the 3.0 compatibility fix. Thanks!


[Doc] Explicitly state that PP isn't compatible with speculative decoding yet

PP isn't compatible with speculative decoding, so let's throw an error explicitly.
To make PP compatible with speculative decoding:

Make sampler available in the model regardless of PP (done in this PR)
Resolve https://buildkite.com/vllm/ci/builds/10343#0193a03c-9df2-4587-824a-93ddc33ef66b/198-3687

ValueError: No supported config format found in ngram

the test has errors.

Hmm... have we ever tested PP with spec decode? Seems that sampling params is not available to the model runner.

I don't think we did. I had an impression that I once tried but got some errors, but I didn't have bandwidth to dive in by that time...

Hmm... so PP isn't officially supported with spec decode yet?

Hmm... so PP isn't officially supported with spec decode yet? Let's instead update the docs in this PR then.

I'm not sure. I supposed PP should support spec decode as there's no fundamental bottleneck, but not sure if there's any issue in the implementation.

I have added an error message to better communicate that they aren't compatible yet. We can fix the code in another rPR.

I have added an error message to better communicate that they aren't compatible yet. We can fix the code in another PR.

@DarkLight1337 is there another PR open for the code fix for spec decode? If not, let me know and I'll open one.

No, feel free to open one!


First draft of message version 1

Hi @grunch ,
emerging from fiat job, nothing bad in the direction of the PR, i like the idea of using enum container for message like:
pub enum Message {
    Order(MessageKind),
    Dispute(MessageKind),
}

We can go in this direction imo, what i'd like to work on is:

Avoid too many modifications in mostro using getter function in mostro-core, for example in this snippet avoid the Some in matching actions

if let Ok(m) = message {
                       let message = Message::from_json(&m);
                       if let Ok(msg) = message {
                           if msg.verify() {
                               match msg.get_action() {
                                   Some(Action::NewOrder) => {
                                       order_action(msg, &event, &my_keys, &client, &pool).await?;
                                   }

Another thing looking back is to try to reduce all kind of message regarding orders to use the same struct, avoiding smallorder, will look if it's too much breakin on mostro side.

Just free thoughts...
For merge I think that's better to move on dev branch on mostro and mostro-core to have a compilable version in the end.

* Avoid too many modifications in mostro using getter function in mostro-core, for example in this snippet avoid the Some in matching actions

if let Ok(m) = message {
                       let message = Message::from_json(&m);
                       if let Ok(msg) = message {
                           if msg.verify() {
                               match msg.get_action() {
                                   Some(Action::NewOrder) => {
                                       order_action(msg, &event, &my_keys, &client, &pool).await?;
                                   }

sure, can you give a code example?

* Another thing looking back is to try to reduce all kind of message regarding orders to use the same struct, avoiding smallorder, will look if it's too much breakin on mostro side.

If we can remove one of the order struct and unify it in only one would be great

Just free thoughts...
For merge I think that's better to move on dev branch on mostro and mostro-core to have a compilable version in the end.

I think this is a good idea, can you do it?

* Avoid too many modifications in mostro using getter function in mostro-core, for example in this snippet avoid the Some in matching actions

if let Ok(m) = message {
                       let message = Message::from_json(&m);
                       if let Ok(msg) = message {
                           if msg.verify() {
                               match msg.get_action() {
                                   Some(Action::NewOrder) => {
                                       order_action(msg, &event, &my_keys, &client, &pool).await?;
                                   }

sure, can you give a code example?

* Another thing looking back is to try to reduce all kind of message regarding orders to use the same struct, avoiding smallorder, will look if it's too much breakin on mostro side.

If we can remove one of the order struct and unify it in only one would be great

I will try to see if it's a big effort or not, could be a nice and cleaner improvement.

Just free thoughts...
For merge I think that's better to move on dev branch on mostro and mostro-core to have a compilable version in the end.

I think this is a good idea, can you do it?

Yep we can have branch dev-protocol-version-1 on both mostro and mostro-core? What do you say? We will eventually merge some milestones which are compiling.

I was thinking you were talking about having a dev branch, if you want to have just a branch for message version 1 why we just don't work on this branch? it's easier

I was thinking you were talking about having a dev branch, if you want to have just a branch for message version 1 why we just don't work on this branch? it's easier

Yep! That's exactly what I meant...let's go on with this here. I was only saying dev as generic name for another branch message-version-1 is ok!

Hi @grunch ,
Removed version from Messagekind, I think it better to have in lib.rs two const globally used:
pub const PROTOCOL_MAJOR_VER: u8 = 1;
pub const PROTOCOL_MINOR_VER: u8 = 0;
So simply every new message is created like that:
    pub fn new(
        id: Option<Uuid>,
        pubkey: Option<String>,
        action: Action,
        content: Option<Content>,
    ) -> Self {
        Self {
            version_major: PROTOCOL_MAJOR_VER,
            version_minor: PROTOCOL_MINOR_VER,
            id,
            pubkey,
            action,
            content,
        }
    }

We can remove all version parameter from Mostro too, cleaner code imo.
Added also CantDo message as we said yesterday, in Mostro we use a lot, so a quick creator is nice for me.
Will clean Mostro from version parameter meanwhile.

Removed


[extractor] Add magentamusik.de

IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
The old extractor for magenta-musik-360.de did not work anymore, because the page changed to magentamusik.de and its using HLS stuff now. So I created a new extractor.
Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8 and ran relevant tests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Fix or improvement to an extractor (Make sure to add/update tests)
[x] New extractor (Piracy websites will not be accepted)
[ ] Core bug fix/improvement
[ ] New feature (It is strongly recommended to open an issue first)

Copilot Summary

🤖 Generated by Copilot at 6e6dbeb
Summary
🎵🕸🇩🇪

Added a new extractor for MagentaMusik and renamed the existing extractor for MagentaMusik 360. This allows downloading videos from both platforms.

magentamusik.py
New extractor for music
Autumn of downloads

Walkthrough

Add a new extractor for MagentaMusik website (link)
Rename magentamusik360.py to magentamusik.py to avoid confusion with different platform (link, link)

Do not change file or extractor class name. You can add an IE_NAME if desired. Also, the old URLs still seem to work on browser and so support should be kept. Don't remove the tests either. Just fix them and add new ones.

Do not change file or extractor class name. You can add an IE_NAME if desired. Also, the old URLs still seem to work on browser and so support should be kept. Don't remove the tests either. Just fix them and add new ones.

I created a new one, because the old page is offline. The URLs in the old file do not work anymore. They just redirect to a 404 page. magentamusik.de is a completely new page and replaces the old magenta-musik-360.de page. I don't see how it makes sense to keep the old extractor. I could replace the internals of the old one, and keep the name, if you want, tho.

I could replace the internals of the old one, and keep the name, if you want, tho.

Yeah do it this way

I created a new one, because the old page is offline.

Sorry, idk why I thought the URLs are still working. Maybe I accidentally tried with new URL instead? Or maybe it was when I made the comment and no longer is? Either way, ignore previous review


Update API documentation links

We now point to docs.rs for the documentation of the latest release
instead of docs.diesel.rs which contains documentation rendered for the
master branch.
The readme now contains both links you might be reading it in context of
Diesel's Github repo page or on crates.io. I also changed the
diesel_codegen documentation entry to point to the guides listing page,
as there are multiple guides (some just drafts right now) that talk
about the derives.

Thank you, @driftluo for pointing this out in #1294!


Upgrade dependencies to prevent vulnerabilities

This PR fixes vulnerabilities with:

lodash.template - CVE-2019-10744
fstream - CVE-2019-13173
webpack-dev-server - CVE-2018-14732
merge - CVE-2018-16469
cryptiles - CVE-2018-1000620
lodash - CVE-2019-10744
mem - WS-2018-0236

@artlowel : Strangely, this PR works fine in Travis CI with Node 8, but fails immediately (in the yarn install step) on Node 9: https://travis-ci.org/DSpace/dspace-angular/jobs/567965694

@tdonohue The reason was that get-caller-file, a transitive dependency, removed node 9 support because it's end-of-life (odd node versions aren't LTS). I didn't see a way to fix WS-2018-0236, without, as a side effect, also upgrading to a get-caller-file version without node 9 support.
Since it's EOL anyway, I removed node 9 from our supported versions, and replaced it with node 10.

Note I was still getting timeouts on the e2e tests. Perhaps travis recently started throttling their network speeds (more than before)? Because I can never reproduce the issue locally. I increased the timeouts to 10 minutes now. That seems to work.
But the underlying problem we have to address is that we're relying on a connection with an external server to run these e2e tests. Since we only have a handful of e2e tests, and the last new test was written in October of 2017, I think we should consider dropping e2e from the travis task.

@artlowel : I agree, we should log a ticket (if there isn't one already) to remove e2e tests, perhaps replacing them with tests that do not require the REST demo site.


Newly added column is not shown in Azure Storage Explorer for an Azure Table

I added a new column to an Azure Table Storage. However the new column is not visible in the results grid nor is it available in the Column Options dialog. Refresh doesn't help, Detaching/Re-Attaching doesn't help, Closing/Reopening Storage Explorer doesn't help.
Storage Explorer Version: 1.2.0
Platform: Windows 10
Repro Steps

Add new Property to Table
Verify Property Exists
Query (outside of Storage Explorer) to confirm property exists with data

Expected Result
Any Storage Explorer query for records that include the property should cause the column to be available in the Results grid, column chooser, etc.
Actual Result

Attached to Table in Storage Explorer
New Property/Column never displays in Results Grid nor any Column chooser (Advanced, etc.)

Please provide the following information as per our issue template:

Storage Explorer version
Platform/OS and Version
Regression From (last version of Storage Explorer this was working for you)
Repro Steps (be as specific as possible)
Expected Result
Actual Result

Storage Explorer version

1.2.0

Platform/OS and Version

Windows 10

Regression From (last version of Storage Explorer this was working for
you)

unknown/never attempted prior

Repro Steps (be as specific as possible)

Added new Property to Table
Verified Property Exists
Queried (outside of Storage Explorer) to confirm property exists
with data

Expected Result
Any Storage Explorer query for records that include the property
should cause the column to be available in the Results grid, column
chooser, etc.

Actual Result

Attached to Table in Storage Explorer
New Property/Column never displays in Results Grid nor any Column
chooser (Advanced, etc.)

On Tue, Jun 26, 2018 at 1:47 PM Craig<EMAIL_ADDRESS>wrote:

Please provide the following information as per our issue template:

Storage Explorer version
Platform/OS and Version
Regression From (last version of Storage Explorer this was working
for you)
Repro Steps (be as specific as possible)
Expected Result
Actual Result

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/AzureStorageExplorer/issues/356#issuecomment-400403974,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AmuRUDzChIfzDXMB4hOnG20btotqTT27ks5uAnOcgaJpZM4U4DBO
.

What happens if you refresh the table? How about if you close the editor then reopen?

I tried all of the above, but no luck.  Oddly enough, I can copy the query
from the text editor and give it to another user (using the same version)
and they can see the column (though not initially, only after closing and
reopening).
On Wed, Jun 27, 2018 at 11:42 AM Craig<EMAIL_ADDRESS>wrote:

What happens if you refresh the table? How about if you close the editor
then reopen?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/AzureStorageExplorer/issues/356#issuecomment-400723422,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AmuRUDKmQdOXULuEP36iH9C8NzPZLkliks5uA6fOgaJpZM4U4DBO
.

How exactly are you adding this new property? Storage Explorer works by listing entities from the table and aggregating the properties from each entity. It's highly likely that, if an entity with a unique property isn't within the first 1000 entities, it's property column won't appear right away. Azure tables aren't like SQL tables, which have discrete schemas.

yeah, we definitely have legacy data that doesn't have the property, so
when the table is first accessed in Storage Explorer and it retrieves data
automatically, it would not be a property in those first 1000 entities.
However, my assumption would be that once I query for a specific range of
entities that does have the Property, Storage Explorer would adapt
dynamically since the property is available in the query result set and
update it's result grid.
On Wed, Jun 27, 2018 at 4:23 PM Craig<EMAIL_ADDRESS>wrote:

How exactly are you adding this new property? Storage Explorer works by
listing entities from the table and aggregating the properties from each
entity. It's highly likely that, if an entity with a unique property isn't
within the first 1000 entities, it's property column won't appear right
away. Azure tables aren't like SQL tables, which have discrete schemas.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/AzureStorageExplorer/issues/356#issuecomment-400816438,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AmuRUJrBRi4lolgWAAJ08z2h-rhU1VNlks5uA-mkgaJpZM4U4DBO
.

Are you selecting a subset of columns? Is the query using the new property at all? Does the query still return the expected set of entities, even if the column isn't shown?
One way you can tell if you're getting the right data from the server is:

Hit F12 to open the dev tools.
Open the Sources tab. Hit Ctrl+P, type TableEntityListViewModel.ts, and press Enter.
Find the line result = _a.sent(); (somewhere around line 371) and drop a breakpoint.
Rerun your query that includes the entity with the expected property (might want to match partition and row keys for simplicity). The breakpoint should pause execution.
Examine the value of result. The target entity should have the new property you're expecting.

If this goes as expected, it's likely a bug on our end and we'll need to look into it further. Is this issue blocking you in any way?

Ok,
so I've confirmed that the issue is due to how Storage Explorer locks in
the columns based on the first 1000 entities.  Understood that Storage
Explorer needs some mechanism to determine what properties are available
given the schema-less nature of Azure Tables. However, since Storage
Explorer auto-queries and returns the oldest records first when a Table is
opened and before I can specify any custom query, my column choices are
limited to whatever properties are available on the oldest 1000 records.
Any of my subsequent queries in Storage Explorer are limited to those
original properties as columns, as those properties get baked in as the
only possible properties to select.  It would be nice if after opening a
Table, and then upon a subsequent custom query the "Available" Columns for
Selection are updated.
I confirmed this behavior by going back and updating the first 1000 records
in the Table to have the new property, now the new property is available as
a column choice in Storage Explorer.
 Is the query using the new property
at all? Does the query still return the expected set of entities, even if
the column isn't shown?
One way you can tell if you're getting the right data from the server is:

Hit F12 to open the dev tools.
Open the Sources tab. Hit Ctrl+P, type TableEntityListViewModel.ts,
and press Enter.
Find the line result = _a.sent(); (somewhere around line 371) and
drop a breakpoint.
Rerun your query that includes the entity with the expected
property (might want to match partition and row keys for simplicity). The
breakpoint should pause execution.
Examine the value of result. The target entity should have the new
property you're expecting.

If this goes as expected, it's likely a bug on our end and we'll need to
look into it further. Is this issue blocking you in any way?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/AzureStorageExplorer/issues/356#issuecomment-400831046,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AmuRUD7tcl15LQxu7bmX34a0rRGihokWks5uA_WKgaJpZM4U4DBO
.

Table editors should already by checking for new columns when it retrieves new items. Is the only issue here that the query builder isn't detecting the new columns?

Yes, no editing is being attempted here.
On Thu, Jun 28, 2018 at 1:40 PM Craig<EMAIL_ADDRESS>wrote:

Table editors should already by checking for new columns when it retrieves
new items. Is the only issue here that the query builder isn't detecting
the new columns?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/AzureStorageExplorer/issues/356#issuecomment-401116141,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AmuRUPPwoy0wut6W1km3Z_n4Gl93hL7Jks5uBRUagaJpZM4U4DBO
.

Let me clarify. If you leave the query builder alone and add a new entity with a new property, does the new column appear? If not, does loading it into the cache (clicking Load More until you find it) work? Does refreshing work?
Now do the same for when the query builder is open and run. Same questions; what happens?

I'll need to get setup in another DEV environment.  To date, we've never
used StorageExplorer for editing, only viewing. At any rate, it's not a
scenario I could repeat on Production data.
On Thu, Jun 28, 2018 at 4:18 PM Craig<EMAIL_ADDRESS>wrote:

Let me clarify. If you leave the query builder alone and add a new entity
with a new property, does the new column appear? If not, does loading it
into the cache (clicking Load More until you find it) work? Does refreshing
work?
Now do the same for when the query builder is open and run. Same
questions; what happens?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/AzureStorageExplorer/issues/356#issuecomment-401160355,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AmuRUHfze10_EdMNePYqvDhvopg64T0zks5uBTongaJpZM4U4DBO
.

@shannonlharris, please open a new issue if you're still having problems. Thanks.


Integration Test - Release - 2019/04/25 01:59:03

Auto create for integration test. AnotherAuthorUpdatedArticleFlow

@PRMergerTest3 : Thanks for your contribution! The author, @v-caxian, has been notified to review your proposed change.


Fix and enhance troubleshooting

Fixed the trouble shooting document. Because the way it describes how to install custom delegate certificate was out of date
Add the option to turn on SSL debug log. This is super helpful when customer doesn't have any tool available to use

Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the CODEOWNERS.
What Type of PR is This?

[ ] Issue
[ ] Feature
[ ] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

Issue(s)

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[ ] Tested Locally
[ ] Optional Screen Shoot.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6568e33ec8c2351ac16e7a85--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6568e3def0191e166c70c5fc--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6568e402c0ce271ac6ee76d8--harness-developer.netlify.app


24fee calculation based on existing data

allow frontend. to. keep a list of when we change fee
use the correct fee percentage based on the event timestamp.
calculate the fee from every conversion event and sum the fee together to show 24h fees.

Some back story,
Currently the implemented solution just loops over network conversion events and considers the current fee % set on pools as truth, however, in cases where the pool has changed fees in the past 24 hours these fees are considered in accurate.
In #502 we implemented a bandaid solution where pool fees can be hardcoded with a blocknumber which gets us out of trouble for now.
Our goal in this issue is to create a more long term solution where fees are calculated accurately.
@H34D My current understanding is that we've decided to launch these requests immediately once pools are loaded in order to not increase wait times nor do we expect these requests to make any difference very often as they'll only introduce any change in cases where the pool fee has been set in the past 24 hours.
Further discussion is continued in PR #526

seems this is not working on production.
we need to understand why.

While further work can be done to prioritise pools based on their liquidity depth I don't think that would still deliver a good experience as we'd like.
From what I see the existing system works, just takes way too long to discover the pools we want given the concurrency limitation.
Lets proceed with hard coding the fees till we can lean on the API.

Added sorting by a handful of hardcoded pools.


Courseware inline discussions

Jira: https://openedx.atlassian.net/browse/MA-2245
Loading PostViewController with topicID
Jira: https://openedx.atlassian.net/browse/MA-2321

@mikekatz  Please review.

[Current coverage][cc-pull] is 49.49%

Merging [#736][cc-pull] into [master][cc-base-branch] will decrease coverage by 0.14%

@@             master       #736   diff @@
==========================================
  Files           452        454     +2
  Lines         29266      29352    +86
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits          14526      14527     +1
- Misses        14740      14825    +85
  Partials          0          0

Powered by Codecov. Last updated by [9aec06f...37be13b][cc-compare]
[cc-base-branch]: https://codecov.io/gh/edx/edx-app-ios/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/edx/edx-app-ios/compare/9aec06fb158a5ec909b26193f50fc19473120a88...37be13bf2679e3fc9ea76d46c524ee401456687e
[cc-pull]: https://codecov.io/gh/edx/edx-app-ios/pull/736?src=pr

@mikekatz Please review.

.14% is a big drop in coverage. Can we add a screenshot test to cover the discussion case, especially if we can load a mock topic

@mikekatz adding screenshot test for discussions need to rewrite PostsViewController server requests because whole discussion section directly calling taskForRequest so mocking is not possible with current logic.

any ideas on how to increase the coverage? We really shouldn't be adding new code without tests, even if the goal is to rewrite it later.

@mikekatz Screenshot test case added for PostsViewController. Please review

@mikekatz test cases are failing with below error
PostsViewControllerTests
✗ testContent, failed - Snapshot comparison failed (ios8_380x568): Unable to load reference image.
these are new images then why its finding reference images.

@saeedbashir we test ios 8 & 9 both ltr and rtl, so there needs be 4 reference images. If you add the iOS 8 ones and the checks pass, then this PR is 👍


fix link problems

@huan In readmd file, link address is correct, but, (link-address) will make the link be link-address). This is found by a student who appling summer-of-code project.

Thanks for the fix!


[FR]: Including/Exclude certain categories from being updating when running cat-update

Is your feature request related to a problem? Please elaborate.
In Radarr I set up a category (movies) and post-import category (movies.seeding) , so any torrents that get imported will be moved into the movies.seeding category.  I also set up cross-seed to enable duplicateCategories so everytime it finds a torrent it will append '.cross-seed' to the category , i.e "movies.cross-seed" . Sometimes it will find matches for torrents that are in the "movies.seeding" category, so the category becomes "movies.seeding.cross-seed". I would like to move these torrents to the "movies.cross-seed" category. The problem is when I run the cat-update command it will change all the torrents (even with the ones with existing categories) to "movies".
Describe the solution you'd like
I would like to be able to only include/exclude certain categories from being updated.
Does your solution involve any of the following?

[X] New config option
[X] New command option

Describe alternatives you've considered
I tried setting cat_update_all to false , but it just updates the torrents that don't have a category. That wouldn't work for me since the torrents I have already have an existing category.
Who will this benefit?
Cross-seed & Radarr users using post-import category
Additional Information
Config:
commands:
  dry_run: true
  cross_seed: false
  recheck: true
  cat_update: true
  tag_update: true
  rem_unregistered: true
  tag_tracker_error: true
  rem_orphaned: true
  tag_nohardlinks: true
  share_limits: true
  skip_cleanup: false
  skip_qb_version_check: false

qbt:
  # qBittorrent parameters
  host: http://<IP_ADDRESS>:8090
  user: ***
  pass: ***

settings:

  force_auto_tmm: false
  force_auto_tmm_ignore_tags:
  - cross-seed
  - Upload
  tracker_error_tag: issue
  nohardlinks_tag: noHL
  share_limits_tag: ~share_limit
  share_limits_min_seeding_time_tag: MinSeedTimeNotReached
  share_limits_min_num_seeds_tag: MinSeedsNotMet
  share_limits_last_active_tag: LastActiveLimitNotReached
  cross_seed_tag: cross-seed
  cat_filter_completed: true
  share_limits_filter_completed: true
  tag_nohardlinks_filter_completed: true
  cat_update_all: true
  disable_qbt_default_share_limits: true

directory:
  root_dir: /data/torrents/
  torrents_dir: /qbittorrent/data/BT_backup
  orphaned_dir: /data/torrents/orphaned_data
  remote_dir: /data/torrents/
  cross_seed: /data/torrents/cross-seed
  recycle_bin: /data/torrents/.RecycleBin
cat:
  movies: /data/torrents/movies
  tv: /data/torrents/tv
  music: /data/torrents/music
  porn: /data/torrents/porn
  games: /data/torrents/games
  other: /data/torrents/other
  cross-seed-linked: /data/torrents/cross-seed-linked/

cat_change:
  movies.seeding.cross-seed: movies.cross-seed

tracker:
  alpharatio.cc:
    tag: AlphaRatio
    notifiarr: AlphaRatio
  tracker.anthelion.me:
    tag: Anthelion
    notifiarr: Anthelion
  eiga.moi:
    tag: AsianCinema
    notifiarr: asiancinema
  asiandvdclub:
    tag: AsianDVDClub
    notifiarr: asiandvdclub
  avistaz:
    tag: AvistaZ
    notifiarr: avistaz
  cinemaz:
    tag: CinemaZ
    notifiarr: cinemaz
  inferno.demonoid.is:
    tag: Demonoid
    notifiarr: demonoid
  exoticaz:
    tag: ExoticaZ
    notifiarr: exoticaz
  fearnopeer:
    tag: FearNoPeer
    notifiarr: feernopeer
  fappaizuri:
    tag: Fappaizuri
    notifiarr: Fappaizuri
  happyfappy:
    tag: HappyFappy
    notifiarr: happyfappy
  hdts-announce:
    tag: HD-Torrents
    notifiarr: hd-torrents
  itatorrents:
    tag: ItaTorrents
    notifiarr: ItaTorrents
  myanonamouse:
    cat: other
    tag: MaM
  nebulance.io:
    tag: Nebulance
  opsfet:
    tag: Orpheus
    cat: music
  oldtoons:
    tag: OldToons
    notifiarr: OldToons
  flacsfor.me:
    tag: Redacted
    cat: music
  tracker.gazellegames.net:
    tag: GazelleGames
    notifiarr: GazelleGames
  plab:
    tag: PornoLab
  privatehd:
    tag: PrivateHD
    notifiarr: PrivateHD
  thegeeks:
    tag: TheGeeks
    cat: other
  t-ru:
    tag: RuTracker
  secret-cinema:
    tag: SecretCinema
    notifiarr: SecretCinema
  torrentleech|tleechreload:
    tag: TorrentLeech
    notifiarr: torrentleech
  upload.cx:
    tag: Upload.cx
    notifiarr: Upload.cx
  uhdbits.org:
    tag: UHDBits
    notifiarr: UHDBits
  other:
    tag: other-tracker

nohardlinks:
- tv:
    exclude_tags:
    - todelete
    - cross-seed
- porn:
    exclude_tags:
    - todelete
    - cross-seed
- movies:
    exclude_tags:
    - todelete
    - cross-seed
- movies.seeding: #expirimenting - post import category set by radarr
    exclude_tags:
    - todelete
- tv.seeding: #expirimenting  - post import category et by sonarr
    exclude_tags:
    - todelete

share_limits:
  publicTracker:
    priority: 999
    include_all_tags:
    - other-tracker
    categories:
    - movies.seeding
    limit_upload_speed: 100
    max_seeding_time: 1d
    cleanup: true #since radarr doesn't delete completed torrents from post-import category, this deletes it instead

recyclebin:
  empty_after_x_days: 60
  save_torrents: true
  split_by_category: true

orphaned:
  exclude_patterns:
  - '**/.DS_Store'
  - '**/Thumbs.db'
  - '**/@eaDir'
  - '**/*.!qB'
  - '**/*_unpackerred'
  - /data/torrents/cross-seed/**

Configuration issue. Please use Discord for support. Appears you've failed to properly configure all categories as is REQUIRED
CrossSeed v6 is in RC and no longer supports nor uses the duplicate category functionality thus there's little need for this going forward anyway.


Add extended scan

Hi,
I'm the developer of the ble_monitor integration for home assistant. We make use of your excellent aioblescan package to get the raw ble data.
In the past, we received issues from users with an Intel NUC (RTL8822CE also), who received errors like: LE Set Scan Enable -> Command disallowed, see e.g. this topic. https://github.com/custom-components/ble_monitor/issues/61
At that time, there was a pull request by @vicamo for the aioblescan repository that had a solution for this issue. https://github.com/frawau/aioblescan/pull/30
He decided to close the PR in the end, so it never got into aioblescan unfortunately. @Magalex2x14 decided to make a local copy of aioblescan in the ble_monitor repository about a year ago in which he applied more or less the fix from #30, which we use since.
I think it would be good that this solution is implemented in aioblescan itself, so we can remove our local forked version and use yours. It's tested by many people during last year :-)
I didn't check main.py, you might need to add a parameter to send_scan_request(self, isactivescan=False) (isactivescan is added as parameter)

OK I will merge this and test If things are A-OK I will release. But I do not have a NUC to test your specific issue

I don’t have a intel NUC either, let’s first test that the old functionality keep working like before. If all works ok, I’ll move BLE monitor back to your aioblescan and I’ll ask the NUC users.

I've updated thinks please do check if things are fine on your side and let  me know. I will also ask people who submitted plugins to check. Unless I get a problem report, I will push the new version to PyPi on Wed May 19 around !2:00 GMT

Ok, will do.

Any idea when you will make the 2.8 release?


Comments are lost when when page refreshes with no warning

Please complete the following fields as applicable:
What version of the DMPRoadmap code are you running? (e.g. v2.2.0)
Version: v3.4.3
Expected behaviour:
Expect a warning about unsaved comments or caching in some way so that accidentally navigating away from a section does not delete the contents of the unsaved comment.
Actual behaviour:
Refreshing a page or navigating forward or backward causes unsaved comments to be lost.
Steps to reproduce:
Comment on the response to a question in a DMP, then refresh the page.

This is true for every field on the site. If we were to implement a warning message here, it should be done everywhere.
This is related to an issue in the DMPRoadmap repository that discusses confusion between the auto-save behaviour we have implemented on the 'Write Plan' tab for answers and manual 'Save' buttons everywhere else


add feature

Targets #2185
Desription :-  [added search by category functionality]
when book are not present there system show { x Clear current search and filters} this message

Please resolve the merge conflict.


Image to Base64 format

can you help me to convert images to base64 formate using this package?

This package already converts the uploaded images to base64, here is the relevant code

On drop function return two values first file details and second base64 url
Example here
const onDrop = (pictureFiles, pictureDataURLs) => {
}


Updated cloud-provider spec file to support vSphere

[#145450681]
Signed-off-by: Brendan Nolan<EMAIL_ADDRESS>

I was just playing with Kubo and persistence, which led me to add my own cloud-config to this bosh release and notice this PR. Whats interesting here is the bosh paradigm vs Kubernetes.
With the usual bosh workflow, bosh is the only one who is able to play with disks. With Kubernetes we are now allowing the developer access to vsphere disks directly. Good and bad?
Anyhow the whole point I am trying to get to is that we can really simplify the configuration options that have to end up in the manifest by using credhub to store vsphere secrets and have both Kubernetes and BOSH be able to access them on the fly. Thoughts?

@Oskoss Thanks for the comments. Currently we are using the same vSphere user for the deployment and the access/creation of storage. We are looking at some stories to separate these two roles. Where we have a separate user for storage it would make sense to access these values from Credhub


Don't use alpha clients as oc client for CentOS images

Currently the parent image for CentOS Dockerfile used is
FROM openshift/origin
Which is built with latest alpha version of oc client. We can't rely on that, but instead client built into this image should follow origin releases. Current stable version is 3.7.
Version of oc client with latest Jenkins image:
$ oc version
oc v3.9.0-alpha.0+1c24d18-233
kubernetes v1.8.1+0d5291c
features: Basic-Auth GSSAPI Kerberos SPNEGO

Server https://<IP_ADDRESS>:443
openshift v3.7.9
kubernetes v1.7.6+a08f5eeb62

latest images are not guaranteed to be stable.  use the tagged images if you want something stable.
https://hub.docker.com/r/openshift/jenkins-2-centos7/tags/

Hmm OK well that's a problem since v3.7 image is not refreshed with the latest Jenkins. Obviously I want that so that always have latest Jenkins in my v3.7 Openshift.
Maybe I'll just use the latest image then and remove the alpha client & put v3.7 client there.

you're certainly welcome to layer whatever oc client you want on top of the image, we fully support extending our images for specific needs.
I am going to update the v3.7 release stream to use the v3.7 base image here:
https://github.com/openshift/jenkins/pull/454
(but as you say, that will not help you if you want a newer jenkins version).


Create verify.yml for GitHub pipeline

Add github pipeline

Only the chromium browser will not start.. almost there..

Cool :)

@apiman/maintainers After a couple of commits we have now a pipeline which verifies all builds, do the browser tests and publishes the tests via github bot in the corresponding PR. What do you think about it?

Looks also good to me 👍

Just for discussion:
It would be nice to also push a docker image for the main branch to docker hub. Maybe "apiman/devportal:latest?

Yes, I think this is something for a release pipeline. This pipeline here verifies only the build of some PRs.

The release workflow is done in the pipeline of the main apiman project.
We should include it there as well. But for I think it is okay if you already merge this 😊
From: Benjamin Kihm<EMAIL_ADDRESS>Sent: Tuesday, 20 October 2020 08:26
To: apiman/apiman-developer-portal<EMAIL_ADDRESS>Cc: Florian Volk<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [apiman/apiman-developer-portal] Create verify.yml for GitHub pipeline (#4)
Yes, I think this is something for a release pipeline. This pipeline here verifies only the build of some PRs.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/apiman/apiman-developer-portal/pull/4#issuecomment-712623871, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADFW7H34G6TI6UQDHP6TUITSLUUNXANCNFSM4SUKMAEQ.

Yeah we could pretty easily push latest docker image builds from a GH Actions workflow if you think that would be useful.  I think traditionally I've only pushed docker images for releases, but I'm happy for us to expand that.

@volkflo You can open another issue for pushing docker images if required.

@EricWittmann Yes, I looked it up, only for the releases. But I think latest with the current main/master branch is pretty helpful to try-out new features or merged fixes :)

Please see: https://github.com/apiman/apiman-developer-portal/pull/7


Gamepad part

Hello,
First of all, thanks for your work, this extension is very very nice.
Did you already think about porting the gamepad part of SDL? Is it hard?
I don't really know the logic that you're using, to port, but I'll be glad to help with that.
Thank for your time.
Best,

Basic joystick support has been added to the extension on version 2.3.0. Thanks,


Cannot install PS module from .net application using Microsoft.PowerShell.SDK

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce
I need to install a PowerShell module from my .NET application. I have added Microsoft.PowerShell.SDK nuget package to the project and use PowerShell class to execute Install-Module cmdlet but it fails because of CommandNotFoundException.
Code:
PowerShell ps = PowerShell.Create();
ps.AddCommand("Install-Module").AddParameter("Name", "ExchangeOnlineManagement").AddParameter("Force");
ps.Invoke();

Expected behavior
The PS module should be installed.

Actual behavior
CommandNotFoundException is thrown.

Error details
No response
Environment data
.NET version: 8.0
Microsoft.PowerShell.SDK version: 7.4.5
OS: Windows 10

Visuals
No response

Install-Module is not part of the SDK, it is installed as part of the PowerShell application.
It is installed as a module
PS> (get-command Install-Module)

CommandType     Name                                               Version    Source
-----------     ----                                               -------    ------
Function        Install-Module                                     2.2.5      PowerShellGet

PS> (Get-Command Install-Module).Module.ModuleBase
C:\program files\powershell\7\Modules\PowerShellGet

But Import-Module is part of Microsoft.PowerShell.Core
PS> (Get-Command Import-Module)

CommandType     Name                                               Version    Source
-----------     ----                                               -------    ------
Cmdlet          Import-Module                                      <IP_ADDRESS>0 Microsoft.PowerShell.Core

Install-Module is not part of the SDK, it is installed as part of the PowerShell application.
It is installed as a module
PS> (get-command Install-Module)

CommandType     Name                                               Version    Source
-----------     ----                                               -------    ------
Function        Install-Module                                     2.2.5      PowerShellGet

PS> (Get-Command Install-Module).Module.ModuleBase
C:\program files\powershell\7\Modules\PowerShellGet

But Import-Module is part of Microsoft.PowerShell.Core
PS> (Get-Command Import-Module)

CommandType     Name                                               Version    Source
-----------     ----                                               -------    ------
Cmdlet          Import-Module                                      <IP_ADDRESS>0 Microsoft.PowerShell.Core

Does it mean that there is no way to install a PowerShell module from a .NET application without installing the PowerShell application?

Should your application be updating or affecting the machine's normal PowerShell installation?
No, my application should work without PowerShell being installed. I need to install only ExchangeOnlineManagement module and then use cmdlets from it.

You could have a modules directory tree within your application package that contains all the modules you need that are not part of the SDK.

Thanks

This StackOverflow answer is a summary of the problem, with links to other answers with concrete solution.
Notably, here is a solution that uses build tooling to bundle a given module with your project.

Thanks


[BUG] System.Reflection.AmbiguousMatchException: Ambiguous match found

Version
5.0.16
Describe the bug
Using this version and 5.0.15 leads to System.Reflection.AmbiguousMatchException: Ambiguous match found
after some time of usage
Code to Reproduce
its simple - just make a simple multithread code to generate and insert/update typed objects inside of a collection
we use the following class:
public class Cookie
    {
        public long Id { get; set; }
        public string Guid { get; set; }
        public long Long { get; set; }
        public CookieCollection cookieCollection { get; set; }
    }

Expected behavior
should not be any issue
Screenshots/Stacktrace
at System.RuntimeType.GetMethodImplCommon(String name, Int32 genericParameterCount, BindingFlags bindingAttr, Binder binder, CallingConventions callConv, Type[] types, ParameterModifier[] modifiers)
at System.Type.GetMethod(String name, BindingFlags bindingAttr)
at LiteDB.BsonMapper.DeserializeList(Type type, BsonArray value)
at LiteDB.BsonMapper.Deserialize(Type type, BsonValue value)
at LiteDB.BsonMapper.DeserializeObject(EntityMapper entity, Object obj, BsonDocument value)
at LiteDB.BsonMapper.Deserialize(Type type, BsonValue value)
at LiteDB.LiteQueryable1.<ToEnumerable>b__27_2(BsonDocument x)    at System.Linq.Enumerable.SelectEnumerableIterator2.MoveNext()
at System.Linq.Enumerable.TryGetFirst[TSource](IEnumerable1 source, Boolean& found)    at System.Linq.Enumerable.FirstOrDefault[TSource](IEnumerable1 source)
at LiteDB.LiteCollection`1.FindById(BsonValue id)
Additional context

removing public CookieCollection cookieCollection { get; set; } property seems solving the issue
but then there is another issue - can not add same _id value

Hi, I found same issue when deserializing collection.
The bug is in line 260 of file BsonMapper.Deserialize.cs.
The affected line is the following:
var addMethod = type.GetMethod("Add");
Which could cause problem when type contains more than one Add method but deserialize need only the one having
as argument itemType.
So if you do the following:
var addMethod = type.GetMethod("Add", new Type[] { itemType });
it solves the issue.
Please let me know if a bug fix can be released soon.
Thanks in advance.
Regards
Luigi

Thanks for your PR @Luigi6821!! I will review to add some tests about this.


Login/signup using Google

I am working on this

bro  i already opened it #68 , this is that issue.


Release v2.1.0

Purpose of this PR

Cherry pick the following commits and release v2.1.0:

Allow setting automountServiceAccountToken (#2298)
Fix: executor container security context does not work (#2306)
Fix: should not add emptyDir sizeLimit conf if it is nil (#2305)
Allow the Controller and Webhook Containers to run with the securityContext: readOnlyRootfilesystem: true (#2282)
Fix: should not add emptyDir sizeLimit conf on executor pods if it is nil (#2316)
Bump volcano.sh/apis to 1.10.0 (#2320)
Truncate UI service name if over 63 characters (#2311)
Bump aquasecurity/trivy-action from 0.28.0 to 0.29.0 (#2332)
Bump github.com/onsi/ginkgo/v2 from 2.20.2 to 2.22.0 (#2335)
The webhook-key-name command-line param isn't taking effect (#2344)
Robustness to driver pod taking time to create (#2315)
Use NSS_WRAPPER_PASSWD instead of /etc/passwd as in spark-operator image entrypoint.sh (#2312)
Move sparkctl to cmd directory (#2347)

/assign @jacobsalway

/approve


FieldItemListInterface should not be generic

Bug report
Found in https://www.drupal.org/project/drupal/issues/3496417
Drupal core PHPStan run now reports a number of
$ignoreErrors[] = [ 	'message' => '#^Method Drupal\\\\Core\\\\Entity\\\\ContentEntityBase\\:\\:getTranslatedField\\(\\) return type with generic interface Drupal\\\\Core\\\\Field\\\\FieldItemListInterface does not specify its types\\: T$#', 	'identifier' => 'missingType.generics', 	'count' => 1, 	'path' => __DIR__ . '/lib/Drupal/Core/Entity/ContentEntityBase.php', ];
errors. This happens because of the stub in here defining the interface as a @template, which is not necessary IMHO - a FieldItemList will always be a list of FieldItems.

OK, I checked the code here and now I see the reason to make FieldItemListInterface generic; will fix downstream instead then. Sorry for the noise.


fix(deployment): increase memory request and limits

:tada: This PR is included in version 0.18.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Upstream this work?

I wonder whether this could at some point replace the upstream Table?
I know the signature is slightly different (namely the return type), but isn't it actually better?

You can try making an RFC here https://github.com/nim-lang/RFCs/issues
I am tired of contributions getting rejected upstream anyway...

Closing because is not really a bug in the code.

Yep, I totally understand (I feel this problem for over many years already).
Anyway, thanks for making this package, it's useful!


Add global search across all accessible logbooks

Currently the global search only searches in the current logbook. It should be possible to extend the search across all logbooks, which the user has access to.

we can remove the global flag for now in the logbook detail page


SCD30 on QT Py giving memory allocation failed

I tried to connect the SCD30 to a QT py through I2C in MU 1.0.3 I got the following error:
Traceback (most recent call last):
File "main.py", line 7, in
MemoryError: memory allocation failed, allocating 232 bytes
Press any key to enter the REPL. Use CTRL-D to reload.
The code used for main.py is the scd30_simpletest.py

are you using the mpy for the library file?

Oh my.. I'm really sorry, I used the .py version which my first link pointed to.
I now took the .mpy version for CircuitPython 6.x and now the communication started with the QT py!
Thank you!

all good, thanx for testing :)


[feature request] Mimic "scp -r"

It's good to see that this module can copy files (multiple if using dynamic "..." { }) over the wire, but it's not that simple to implement the "walk-directory" functionality using the built-in fileset TF function. So, since you already have the functionality to copy put a file onto a disk, maybe there should also be a way to "deep copy" the whole directory by providing a path to it?

It seems like easyssh can do an scp-like copying: https://github.com/hypersleep/easyssh/blob/70879c819ea11f5f4967d0fa7080dfb051884e2f/easyssh.go#L183
So, that will eventually will simplify the existing code from:
			if f.Source != "" {
				src, srcErr := os.Open(f.Source)
				if srcErr != nil {
					_, _ = config.Debug("Failed to open source file %s: %v\n", f.Source, srcErr)
					return srcErr
				}
				srcStat, statErr := src.Stat()
				if statErr != nil {
					_, _ = config.Debug("Failed to stat source file %s: %v\n", f.Source, statErr)
					_ = src.Close()
					return statErr
				}
				_ = ssh.WriteFile(src, srcStat.Size(), f.Destination)
				_, _ = config.Debug("Copied %s to remote file %s:%s: %d bytes\n", f.Source, ssh.Server, f.Destination, srcStat.Size())
				_ = src.Close()
			}

it could be like this:
if f.Source != "" {
    err := ssh.Scp(f.Source, f.Destination)
    if err != nil {
        config.Debug("Failed to copy file(s) %s: %v\n", f.Source, err)
        return err
    }
}

Hi @denismakogon , we have a similar use cases but have been using archive_file up till now. It does require unzip on the server though. Contrived example:
data "archive_file" "data" {
  type        = "zip"
  source_dir  = "/tmp/data"
  output_path = "/tmp/data.zip"
}

resource "ssh_resource" "test" {
  host         = "vorlon.terrakube.com"
  user         = "andy"
  agent        = true
  port = "22"

  pre_commands = [
    "mkdir -p /tmp/test"
  ]

  file {
    source     = "/tmp/data.zip" // Local
    destination = "/tmp/data.zip" // Remote
    permissions = "0700"
  }

  commands = [
    "unzip -o /tmp/data.zip -d /tmp/data"
  ]
}

Will definitely have a look at the scp option though, thanks! There might have been a reason why this was not used, but I've forgotten by now, haha. I'll have a look after the holidays, in the meantime the archive_file option might be a temporary workaround for you.


adding dashboard

Relevant information
Adding dashboard following new public dashboard API format
Checklist

[x] I've read the guidelines and understand the acceptance criteria.
[x] The value of the attribute marked as identifier will be unique and valid.
[x] I've confirmed that my entity type wasn't already defined. If it is I'm providing an
explanation above.

These dashboard PRs look good to me but as I mentioned we're currently working on supporting this dashboard format, so we'll merge this as soon as that's ready. Thank you!

You should see this today or tomorrow on prod! thanks for the patience.


Compiling NodeJS bindings for AWS Lambda and extending tests

:tada: This PR is included in version 2.8.9 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


How to use it in IE11? It is possible?

@alles In theory, it can be possible by adding external polyfills and running voyager code through Babel.
But we have very limited resources to non-evergreen browsers so sadly it's not something we can provide out of the box.

Thanks for your answer.


blender: fix on Darwin

Motivation for this change
This commit set adds some hacks to get Blender to compile on Darwin.
NOTE: still waiting for Blender to finish compiling but hopeful it will work. Wait to merge until then.

I really don't want 405-line cmake files in the Nixpkgs source tree. This will make maintaining Blender in Nixpkgs a huge pain. Why is it needed anyway?

The main issue is how the platform_apple.cmake was originally done. It doesn't use any of the find_package stuff you usually see in cmake files and instead just hardcodes all of the paths. Apparently not many people build Blender on MacOS from source so it's very hacky.
https://github.com/dfelinto/blender/blob/master/build_files/cmake/platform/platform_apple.cmake
I'll see if we can force Blender to use "platform_unix.cmake" which is written much better (but might be incompatible with MacOS).

Okay, so I've reworked this to utilize patches instead. The platform_apple.cmake patch is still about 400 lines but that's a little bit better than having a .cmake file. Either way this is about as good as we can get it to work properly on Darwin.
Does this look okay to merge? It certainly adds more complexity, but worst case we can just get rid of the bad patch files on update and redo the Darwin patches later on.

Could the patches be upstreamed?

The isfinite patch could be but the others are build system related. I’d like to convince blender to change their bizaare Mac build process but I don’t think it would be easy because it probably just works for them.

I do not see why would they mind, if it made the build process more portable. I already changed the build process of several programs and the maintainers accepted it, sometimes even asking me to change their other programs. Although none of the changes were as extensive as this.

No attempt on aarch64-linux (full log)
The following builds were skipped because they don't evaluate on aarch64-linux: blender
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Failure on x86_64-darwin (full log)
Attempted: blender
Partial log (click to expand)
Call Stack (most recent call first):
  CMakeLists.txt:3 (project)

-- Configuring incomplete, errors occurred!
See also "/tmp/nix-build-openimageio-1.8.8.drv-0/source/build/CMakeFiles/CMakeOutput.log".
See also "/tmp/nix-build-openimageio-1.8.8.drv-0/source/build/CMakeFiles/CMakeError.log".
builder for '/nix/store/afcvpahd0hcdv9n9n4sf5215ljxdbyh6-openimageio-1.8.8.drv' failed with exit code 1
cannot build derivation '/nix/store/gynk8l0mrg93ah7r053cjcgfhnshxcsf-blender-2.79a.drv': 1 dependencies couldn't be built
error: build of '/nix/store/gynk8l0mrg93ah7r053cjcgfhnshxcsf-blender-2.79a.drv' failed

Failure on x86_64-linux (full log)
Attempted: blender
Partial log (click to expand)
[ 50%] Building C object source/blender/blenkernel/CMakeFiles/bf_blenkernel.dir/intern/object_deform.c.o
[ 50%] Building C object source/blender/blenkernel/CMakeFiles/bf_blenkernel.dir/intern/object_dupli.c.o
[ 50%] Building C object source/blender/blenkernel/CMakeFiles/bf_blenkernel.dir/intern/object_update.c.o
[ 50%] Building C object source/blender/blenkernel/CMakeFiles/bf_blenkernel.dir/intern/ocean.c.o
[ 50%] Building C object source/blender/blenkernel/CMakeFiles/bf_blenkernel.dir/intern/outliner_treehash.c.o
[ 50%] Building C object source/blender/blenkernel/CMakeFiles/bf_blenkernel.dir/intern/packedFile.c.o
[ 50%] Building C object source/blender/blenkernel/CMakeFiles/bf_blenkernel.dir/intern/paint.c.o
[ 50%] Building C object source/blender/blenkernel/CMakeFiles/bf_blenkernel.dir/intern/particle.c.o
building of '/nix/store/9al2p1bk2mql1ncjnl781idv3yx2lsy8-blender-2.79a.drv' timed out after 3600 seconds
error: build of '/nix/store/9al2p1bk2mql1ncjnl781idv3yx2lsy8-blender-2.79a.drv' failed


Feature first login src

Description

Storing first source of login for users for analytics

Related Issues

Solution and Design

Test Plan

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Docs update

Checklist

[ ] My pull request is atomic and focuses on a single change.
[ ] I have read the contributing guide and my code conforms to the guidelines.
[ ] I have documented my changes clearly and comprehensively.
[ ] I have added the required tests.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.9 out of 10 committers have signed the CLA.:white_check_mark: luciferlinx101:white_check_mark: TransformerOptimus:white_check_mark: Tarraann:white_check_mark: boundless-asura:white_check_mark: Maverick-F35:white_check_mark: Fluder-Paradyne:white_check_mark: jedan2506:white_check_mark: rounak610:white_check_mark: sayan1101:x: Akki-jainYou have signed the CLA already but the status is still pending? Let us recheck it.


fix(curriculum): rework Project Euler 77

Reworks challenge to use argument in function call.
Adds <br> in the formatted block to position it evenly between adjoin paragraphs.
Adds more tests.
Adds solution.
Related to #40896.
Tested on local fork.

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the main branch of freeCodeCamp.
[x] All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

I added this solution to the forum guide article


Update sbt-microsites to 1.3.1

Updates com.47deg:sbt-microsites from 1.2.1 to 1.3.1.
GitHub Release Notes - Changelog - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.47deg", artifactId = "sbt-microsites" } ]

labels: sbt-plugin-update, semver-minor

Superseded by #153.


error message when trying to import data via logstash

NotImplementedError: stat.st_dev unsupported or native support failed to load; see http://wiki.jruby.org/Native-Libraries
                    inode at /usr/share/logstash/vendor/bundle/jruby/2.3.0/gems/filewatch-0.9.0/lib/filewatch/watch.rb:106
           block in watch at /usr/share/logstash/vendor/bundle/jruby/2.3.0/gems/filewatch-0.9.0/lib/filewatch/watch.rb:97
  block in _discover_file at /usr/share/logstash/vendor/bundle/jruby/2.3.0/gems/filewatch-0.9.0/lib/filewatch/watch.rb:313
                     each at org/jruby/RubyArray.java:1734
                     each at org/jruby/RubyEnumerator.java:323
                     each at org/jruby/RubyEnumerator.java:329
           _discover-bash: NotImplementedError:: command not found
_file at /usr/share/logstash/vendor/bundle/jruby/2.3.0/gems/filewatch-0.9.0/lib/filewatch/watch.rb:304
           block in watch at /usr/share/logstash/vendor/bundle/jruby/2.3.0/gems/filewatch-0.9.0/lib/filewatch/watch.rb:95
    block in synchronized at /usr/share/logstash/vendor/bundle/jruby/2.3.0/gems/filewatch-0.9.0/lib/filewatch/watch.rb:357
              synchronize at org/jruby/ext/thread/Mutex.java:148
             synchronized at /usr/share/logstash/vendor/bundle/jruby/2.3.0/gems/filewatch-0.9.0/lib/filewatch/watch.rb:357
                    watch at /usr/share/logstash/vendor/bundle/jruby/2.3.0/gems/filewatch-0.9.0/lib/filewatch/watch.rb:92
                     tail at /usr/share/logstash/vendor/bundle/jruby/2.3.0/gems/filewatch-0.9.0/lib/filewatch/tail_base.rb:73
                     tail at /usr/share/logstash/vendor/jruby/lib/ruby/stdlib/forwardable.rb:189
   block in begin_tailing at /usr/share/logstash/vendor/bundle/jruby/2.3.0/gems/logstash-input-file-4.0.3/lib/logstash/inputs/file.rb:299
                     each at org/jruby/RubyArray.java:1734
            begin_tailing at /usr/share/logstash/vendor/bundle/jruby/2.3.0/gems/logstash-input-file-4.0.3/lib/logstash/inputs/file.rb:299
                      run at /usr/share/logstash/vendor/bundle/jruby/2.3.0/gems/logstash-input-file-4.0.3/lib/logstash/inputs/file.rb:303
              inputworker at /usr/share/logstash/logstash-core/lib/logstash/pipeline.rb:574
     block in start_input at /usr/share/logstash/logstash-core/lib/logstash/pipeline.rb:567

It is related to this
https://github.com/docker-library/logstash/commit/49503dca512f4e08861a79708cd533d62f1cda76
This fixed the problem (tested with 5.6 and latest)
apk update && apk add libc6-compat

BTW: Thank you for sharing this container with us!

Thank you for letting me know! 👍

I pulled the latest version and I had the same issue. After I ran apk update && apk add libc6-compat it worked again.

That is VERY annoying... I removed wget and ca-certificates so maybe libc-compat is a dep of a dep of one of those two??


Fix the stretching views calculation when the calculation happens from the  middle of the items.

When the calculation of stretching views happen from the middle of the items, the  flex line being processed needs to be the corresponding one depending on the index of the view.
This PR correctly handles the flex line.
E.g. A new item is added on the condition that RecyclerView is scrolled to the
bottom and align items is set to stretch

@yaraki could you have a look?


byebug not installable under ruby 2.7.0

Problem description
When installing the gem I get the following error:
gem_make.out.txt
These unrecognized commands (like -Wno-self-assign) seem to be specific to clang and not gcc.
But the Makefile specifies gcc as the compiler.
Am I missing something?
Expected behavior
gem installed
Actual behavior
compiler error
Steps to reproduce the problem
bundle install

How are you installing byebug? The log shows a very old version, which I don't really expect to work on ruby 2.7. Also I suspect the version of rvm you're using is very old as well.

Ok, thanks.
I will check it next week.
David Rodríguez<EMAIL_ADDRESS>schrieb am Fr., 14. Feb. 2020,
18:04:

How are you installing byebug? The log shows a very old version, which I
don't really expect to work on ruby 2.7. Also I suspect the version of rvm
you're using is very old as well.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/deivid-rodriguez/byebug/issues/651?email_source=notifications&email_token=ABRKNDARGUMBFLE3HDV4Y5DRC3FJZA5CNFSM4KVLSWA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELZWXLY#issuecomment-586378159,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABRKNDBN435LRJ2IWPFN4WTRC3FJZANCNFSM4KVLSWAQ
.

Hi again,
I don't know why I had such an old version in my gemspec file.
Now installation worked, thanks!


Remove useless and dangerous sort folder setting

Should fix issue #1743 : Vienna abruptly auto-sorts folders in the alphabetical order on the left panel

Might also help with issue #1742

Should also help with #1732 and #1734

In this new attempt, I implemented a less crude way to recover when ‑loadTree:rootNode: returns NO.
Not sure how to test though, I didn't find a way to recreate the problem.


Bump into API v2alpha1

Jump into V2:

Delete deprecated Canary
Revise some label names to make them more consistent
Delete label filter mesh.megaease.com/mesh-service of mutating webhook (see https://github.com/megaease/easestack/pull/147)

Codecov Report

Merging #135 (1932487) into main (08208c7) will decrease coverage by 0.36%.
The diff coverage is 87.34%.

@@            Coverage Diff             @@
##             main     #135      +/-   ##
==========================================
- Coverage   75.97%   75.60%   -0.37%
==========================================
  Files          77       76       -1
  Lines        6289     6207      -82
==========================================
- Hits         4778     4693      -85
- Misses       1257     1259       +2
- Partials      254      255       +1

Impacted Files
Coverage Δ

...mmand/meshinstall/operator/mutatingwebhook_spec.go
98.76% <ø> (-0.06%)
:arrow_down:

...ommand/meshinstall/shadowservice/customresource.go
33.33% <0.00%> (ø)

emctl/cmd/client/resource/httproutegroup.go
0.00% <0.00%> (ø)

emctl/cmd/client/resource/mock.go
0.00% <0.00%> (ø)

emctl/cmd/client/resource/resource.go
79.31% <ø> (-1.02%)
:arrow_down:

emctl/cmd/client/resource/servicecanary.go
0.00% <0.00%> (ø)

emctl/cmd/client/resource/traffictarget.go
0.00% <0.00%> (ø)

emctl/cmd/client/util/visitor.go
68.81% <ø> (-0.31%)
:arrow_down:

emctl/cmd/transformer/generator/generator.go
46.37% <ø> (ø)

emctl/cmd/client/command/apply/applier.go
93.45% <93.47%> (-0.41%)
:arrow_down:

... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6b3ca7...1932487. Read the comment docs.


Silent Error Handling in Fluxus::Safe::Caller Reduces Error Visibility

The Fluxus::Safe::Caller class handles errors by silencing them, which can lead to a lack of visibility into underlying issues. This behavior can make debugging difficult as errors are not logged or raised, potentially leading to unexpected behavior without a clear indication of the cause.
Proposed Solution:

Introduce optional logging or error reporting when exceptions are caught in Fluxus::Safe::Caller.
Add configuration options to control error handling (e.g., re-raise, log, or silence).

Impact:
Improving error visibility will help developers identify and fix issues more efficiently, leading to more robust and maintainable code.

Fluxus::Safe::Caller is designed to bring safety to the runtime. All errors are self-contained in the Fluxus::Results::Result, and take the common aspect of a Failure.
The Fluxus::Safe is also optant of #on_exception specific chainable method. This method makes the code more explicit about what to do after an expected error.
For example, during a payment flow, you can have a specific error type for gateway failures.
PayWithCreditCard.
  call(credit_card: my_cc_object, payment_gateway_wrapper: my_wrapper)
  on_success { |result| invoke_checkout_success(result) }.
  on_exception(MyGateway::InsuficientFunds) { |result| invoke_checkout_failure(result) }
  on_exception(MyGateway::FraudulentOperation) { |result| invoke_operational_fraud_and_report(result) }.
  on_failure { |result| invoke_unexpected_failure(results) }

Not-mapped errors will always invoke failures, and guarantee the Ruby runtime continuity by taking wrapping the error in a "sandboxed" object. If you do not properly handle the Safe object, silent failures will likely happen in your code.
If need to use the "let it crash" approach I strongly recommend you use the common Fluxus::Caller.

Thank you for the detailed explanation. I understand the design philosophy behind Fluxus::Safe::Caller and its focus on safety by encapsulating errors within a Failure result. However, my concern is with the visibility of these errors during runtime. While the exceptions don’t need to interrupt the flow, having at least an optional log would greatly aid in debugging and monitoring. This log could help identify underlying issues without compromising the flow control that Safe::Caller provides.
A suggestion would be to add a configurable logger in Safe::Caller. Something like this:
module Fluxus
  module Safe
    class Caller < Runner
      class << self
        attr_writer :logger

        def logger
          @logger ||= Logger.new($stdout)
        end
      end
      def self.call!(...)
        instance = new
        __call__(instance, ...)
      rescue StandardError => e
        raise e if e.is_a?(ResultTypeNotDefinedError)

        logger&.error("Exception caught in #{name}: #{e.message}")
        instance.Failure(type: :exception, result: { exception: e })
      end
    end
  end
end

this add the possibility to configure a logger in Rails for example:
# config/initializers/fluxus_logger.rb

Fluxus::Safe::Caller.logger = Rails.logger

@ViniMoraes I see your concerns, and I'm open to evaluating a pull request implementing the proposed idea!
I have a few suggestions before you, or anyone else start implementing it.

Safe navigators are great programming resources, and Ruby makes it even easier to implement, but we are talking about a library that is responsible for controlling a sort of other code workflows. Avoid creating those dubious implementations. The logger object must need to exist and be valid before calling it!
Do not force other devs to use a tool that they do not ask for. If they do not want to use any logging mechanism in Fluxus we must not make an instance of an object that is not needed. This change also solves the safe navigator suggestion.
With the logger addition we just need to create a "singleton" configuration. This will save resources, the Fluxus major instance will always serve the logger object without needing to have a Fluxus instance always memory loaded or constantly creating a logger change.
The logger should be an entity in Fluxus, create an idiomatic implementation about it. e.g.: Fluxus::Accessories::Logger.

Following those suggestions we are good to have it.

Another proposal based on Sidekiq implementation of death_handlers, is receive a lambda on the Fluxus configuration that will be called every time an exception happens. The logic of what is going to be done when a exception happens will be kept outside of Fluxus, as the use user can do more than just logging the message.
# config/initializers/fluxus_logger.rb

Fluxus::Safe::Caller.exception_handler = ->(exception) { ... }

module Fluxus
  module Safe
    class Caller < Runner
      class << self
        attr_writer :logger

        def logger
          @logger ||= Logger.new($stdout)
        end
      end
      def self.call!(...)
        instance = new
        __call__(instance, ...)
      rescue StandardError => e
        raise e if e.is_a?(ResultTypeNotDefinedError)

        exception_handler.call(e) unless exception_handler.nil?
        instance.Failure(type: :exception, result: { exception: e })
      end
    end
  end
end


Feature Request: color rows associated to a regex

Hi, thank you for this extension!
I would like to propose a new feature: color the rows associated to a specific regex.
Basically, in the Options tab > New Regex it is possible to configure a new regex with the fields

Regex
Description

and in this section a color picker field would be included  like the one already present in Proxy / HTTP History.

Then in the Logger tab, the rows matching the regex would be colored with the chosen color.
Example:

Hi @elbae, thank you for the suggestion.
At the moment, we are finishing the latest addition before releasing v4.0.0, which will bring many improvements overall.
I'll give this a try after this release. In the meantime, do you already have in mind a specific workflow that would benefit from this addition? I usually sort the list by regex to accomplish something similar.

Hi @beryxz , thank you for your feedback.

I'll give this a try after this release. In the meantime, do you already have in mind a specific workflow that would benefit from this addition? I usually sort the list by regex to accomplish something similar.

Not really, in my case I wanted to quickly highlight some regex rows.
Are you also planning to include a filtering option for Logger, based on Regex name? Let's say I want to see only output for this specific regex without clearing the logs.

Not really, in my case I wanted to quickly highlight some regex rows.

Hypothetically, if a regex's color were to be changed after a scan, the items already present in the Logger list would not be updated. This is because, as of now, the items in the list don't directly reference the regex in the regexes list.
Highlighting would then be helpful only for new custom regexes. Otherwise, a filtering option would be more appropriate if you were seeking to highlight some specific regexes without clearing the list.

We decided to add a search bar to filter the logger results. I created a separate issue, #57, to keep track of it.


[VS Code] Joining collaboration session: The host has blocked you from joining the collaboration session.

Error:
Joining collaboration session: The host has blocked you from joining the collaboration session.
Steps to Reproduce:

Version Data

extensionName
VSLS

extensionVersion
0.3.1151

protocolVersion
2.2

applicationName
VSCode

applicationVersion
1.30.2

platformName
MacOS

platformVersion
17.7.0

@smentzer, host can block you from joining the collaboration session. Can you confirm if host has performed any operation like this?

Closing due to inactivity. Please re-Open if you’re still encountering this issue. Thanks!


Update meeting-policies-in-teams.md

@kenwith @LolaJacobsen @sonu-arora
CC @revaldiv who worked with me on this.
Changes made to simplify, clarify and correct meeting join experience based on meeting policy settings and meeting options as well as to add information about the fact that dial in users will land in the lobby if unauthenticated users cannot start meetings and they are the 1st to join the meeting. This is true even when Dial In users are set to bypass lobby. This requires a user from the organization to join with a Teams client to admit them as there is currently no way to do this via dial in meeting controls. The only dial in meeting control today is mute.
The document as written mixed the teams client controls with dial in controls. They are separate and mutually exclusive.

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@tonysmit PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


[5.0] Model : let fromDateTime use asDateTime

As asDateTimedoes exactly the same job

Do we even need that method? How about this gets merged, then the code changed to directly call that stuff in 5.1, and the method gets ditched?

The method don't look identical to me.


How to instantiate report to show no results unless at least one filter is selected from dropdown?

Hi, dealing with a very large dataset (over 40 million rows) and want to be able to instantiate the web page of any of the SlickReportViews to show an empty table until I select a filter from at least one of the dropdowns (corresponding to foreign keys in my table) so as to only do calculations like time series on a filtered queryset.

Hello ! That would be a nice Option to set on the package.
For now , you can override the get on your view and do something like this
def get(self, request, *args, **kwargs):
    if not request.GET:
        return self.render_to_response(self.get_context_data())
    return super().get(request, *args, **kwargs)

Thanks! However, i keep getting the "AttributeError: '(my Slickreport view name)' object has no attribute 'form' callback when trying this.

Most likely raised by get_form_crispy_helper on the SlickReportView class .
Override this to check on the existance of the form first because calling the get_crispy_helper

Hello @JoRSchmidt1995
Starting from release https://github.com/ra-systems/django-slick-reporting/releases/tag/v1.1.0
You can auto_load = False to your ReportView and it wont be computed/calculated until the user send an explicit get request.
Hope you find this helpful


Alternative MST-Parsing

Ben wrote:
Suppose we train an RNN Probability Estimator on our corpus, such as described in
https://web.stanford.edu/class/cs224n/reports/2761006.pdf
This is a RNN that estimates
P( W(n+1) = w | W(1), …, W(n) )
where W(n) is the n’th word in the corpus and w is some particular word…
If we want to assign a weight to the dependency link going left-to-right between word v and word w … we could look at
A = average of P( W(n+1) = w | W(1), …, W(n) ) over all cases where W(n+1)=w is actually true
B = average of P( W(n+1) = w | W(1), …, W(n) ) over all cases where W(n+1)=w is actually true, and v occurs before w in the same sentence
Then, d = B - A is one measure of how much extra information about occurrence of w is given via the knowledge that v occurs in the sentence
(One can make a similar measure going backwards in the sentence, by making an RNN that analyzes the corpus backwards, and then estimating the same quantity that way.)
This is an alternative to looking at the mutual information between v and w, which may be better in the sense that it incorporates a lot of higher-order dependencies based on context…
My suggestion is that the cost of the link between v and w in a candidate MST parse could be assigned based on this d value rather than based on mutual information…
There is likely some nicer way to work the math, but I hope the idea is clear…
Also — If one already has parses of the sentences in the corpus, the links in these parses can be included as extra features input to the RNN that  makes the predictions.
This also suggests that compression could be useful as a metric of a grammar learned by ULL.   If creating a probability model using parses as additional features, results in a more accurate probability model, then for a large corpus this will yield greater compression than one would get by not using the parses as additional features.   The amount of compression obtained is a measure of the quality of the grammar learned.

This makes sense. I think once @alexei-gl finishes integration of OpenCog MST-Parser in pipeline it maybe the first thing to try to get alternative MST-Parses. We have different ways to assess real quality of MST parses now - parse accuracy and overall learned grammar PQ/F1

One simple possibility to have it done is just load pre-parsed (per #188) cleaned corpus file as well as *.fmi file exported by MI-Observer and output *.ull file with all links with FMI exceeding the configured threshold. For *.ull file produced by DNN-MI-Milking, no special parsing is required at all, the *.ull file may be used as is and pulled into grammar learning.

@akolonin A variation of the idea in this issue is what Sergey and Alexey Potapov are doing now, using their BERTRAM models. I would close this issue as it's description is outdated.

Agreed

I still think Ben's idea worth trying - we don't have reasonable alternatives better than "sequential parser" thus far.

@akolonin , Ben's idea was refined by himself (after Potopov corrected Ben's idea that you copied in this issue), and that's what Potopov and Sergey are trying in their experiments GuChMI-v5, 6, 7.


Use apache httpcomponents httpclient v4.5.13

This bypasses a dependabot alert on using a bad httpclient version, https://github.com/treeverse/lakeFS/security/dependabot/clients/hadoopfs/pom.xml/org.apache.httpcomponents:httpclient/open
Before merging:

[x] Verify client works on DataBricks

Verified on DataBricks, so ready for review.  @talSofer , could you please review (& merge if no comments)?

Thanks!  Pulling...


fix: solidjs flavor button not working

SolidJS flavor button didn't have appUrl so example button was not working on website.
Added appUrl

Thanks!


Bluetooth: gatt: Fix DB corruption when adding/removing service

Fix an issue in the gatt_register routine where removing a service and
adding it again would cause the database to have non-ascending
orderdered handles numbers and lead to an incomplete service discovery.
Fix: Go through the database and look for a place where to insert
the new service.
Fixes: #17294
Backporting of:
#16593

@joerchan AFAIk the static services don't exist in 1.14 so #17265 should not be needed (in fact it'll likely cause build failure). @Vudentz can you confirm?

@joerchan AFAIk the static services don't exist in 1.14 so #17265 should not be needed (in fact it'll likely cause build failure). @Vudentz can you confirm?

Yep, this should not be needed on 1.14, only the fix to not always append services which cause the corruption in the database.

@jhedberg Yes, that seems correct. Will revert that.

FYI: The merge conflicts was simply because the 'U' suffix had been added.

@Vudentz Does it look correct now?

Close because this backport is included in #18122


As a System Admin I want to add technology Admin to a Technology

Review what? there are no commits referenced, no funcionalities, nothing. :)

It was an error :), its not done

The admin can access to Technologies page. Is possible to create or edit a Technology and as you can see in the photo, some users may be assigned as a technology admin;


rosmetasys export -i crashes

~/ros2/ros2_ws/src$ rosmetasys export -i
Traceback (most recent call last):
File "/home/jm/.local/bin/rosmetasys", line 5, in
from rosmetasys.cli import cli
File "/home/jm/.local/lib/python3.10/site-packages/rosmetasys/cli.py", line 4, in
from click_aliases import ClickAliasedGroup
ModuleNotFoundError: No module named 'click_aliases'
Tried it with iron on ubuntu 22.04.

Added missing dependencies in new Version 1.0.1 ( https://github.com/vschroeter/rosmetasys/commit/6caaec649e942332d99301b735699d615aea9d48).

that fixed the issue.