Fixed #30015 -- Keep-alive connection not clearing previous request data.

Django 2.1.4 affected.
Commit that enabled keep-alive connections https://github.com/django/django/commit/934acf1126995f6e6ccba5947ec8f7561633c27f
Bug: if you make two requests in one keep-alive connection and first request posted data that wasn't read in the view
then on second request that data will be read alongside with first line of the new request.
As a result request.method will contain "..data from previous request...POST"
$ ./runtests.py
======================================================================
FAIL: test_keep_alive_connection_clears_previous_request_data (servers.tests.LiveServerViews)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/wtf/github/django/tests/servers/tests.py", line 127, in test_keep_alive_connection_clears_previous_request_data
    self.assertEqual(response.read(), b'POST')
AssertionError: b'{}POST' != b'POST'

/cc @apollo13

Werkzeug uses exhaust: https://github.com/pallets/werkzeug/blob/d129d17066768238139b8f8a5d667d9a4f4d68db/werkzeug/formparser.py#L105 -- they also always exhaust the stream, might be a good idea to do something similar

do you think you could incorporate the following list?

Hi @apollo13, thanks for review, I agree it's quite naive, just pushed first working solution to start discussion and make sure that the right way to go, I'll improve it in the following days.

Is the check for read_started actually correct? Shouldn't we even read the stream to end if reading was not started?

Yes, that's incorrect.

It is definitely heading towards the correct direction, thanks!

Does it make sense to always exhaust the stream? In that case we could move it into a close() of WSGIRequest and do not need special casing here.

What do flask and others do?

Werkzeug uses exhaust: https://github.com/pallets/werkzeug/blob/d129d17066768238139b8f8a5d667d9a4f4d68db/werkzeug/formparser.py#L105 -- they also always exhaust the stream, might be a good idea to do something similar

I've looked into werkzeug and it doesn't support http/1.1 protocol so they always close connection.
The exhaust logic in finally block is useful only in case of exception otherwise the stream is already empty. And in case like we are trying to fix here, their exhaust logic won't be executed at all because we don't access request form data in view.
I've also looked at the gunicorn, it uses http 1.0 for sync workers because nginx like proxies communicate with the upstream via 1.0 protocol and for async workers it implements cleanup of unread body https://github.com/benoitc/gunicorn/blob/6db35f66a321942690224e8fd11d1fac176e5c89/gunicorn/http/parser.py#L33.
Having that in mind I think that if we move stream exhaust inside request close function then we introduce extra overhead for http 1.0 so better to discard unread body inside our server.

Having that in mind I think that if we move stream exhaust inside request close function then we introduce extra overhead for http 1.0 so better to discard unread body inside our server.

Imo we have to exhaust inside the request close function, otherwise 1.1 http servers will see this behavior, the current fix fixes it only in runserver, no?

otherwise http/1.1 proxies will see this behavior, the current fix fixes it only in runserver, no?

yes but we introduced keep-alive support only to runserver and django was working with other servers without such problem.

otherwise http/1.1 proxies will see this behavior

based on my research (gunicorn only though) I assume that servers with http/1.1 have to discard previous request data on their own in case of keep-alive connection and proxies like nginx don't uses keep-alive to upstream, check that comment in gunicorn sync worker https://github.com/benoitc/gunicorn/blob/6db35f66a321942690224e8fd11d1fac176e5c89/gunicorn/workers/sync.py#L162.

Fair enough, the code still looks somewhat ugly due to all the hasattr magic. Is there any way we could wrap environ[wsgi.input] instead in runserver and have some cleanup/flush logic there?

the code still looks somewhat ugly due to all the hasattr magic.
agree, I'll try to refactor it when I have time

@kalekseev I hope you are okay with me pushing into your branch, I've added my changes as extra commit (we can squash them when merging). What do you think of this approach?
@krabtal Can you please verify that this patch fixes your issue?

works properly now

@carltongibson This patch seems good to go; could you give it a final review (there is nothing specific to look out for, should be a rather straight forward patch).

Awesome. Thanks for the work all. I will have a look tomorrow.

I've pushed requested changes, @apollo13 please review

@carltongibson @apollo13 thanks guys!

...we might wanna add a try/finally either way...

I'd not expect an error here. Sure maybe one comes up, but I'd like to see that before we add handling for it.

Ei, yes. That's my oversight. I will pick those up in the morning. Thanks Tim!


Not installable on Fedora

Versions

Python: 3.6
OS: Fedora 26 (KDE)
Kivy: 1.9.0 thru 1.10.0
Kivy installation method: pip3

Description
Appears to be non-installable on Fedora. Consistently raises errors on compile time.
Code and Logs
su -c 'pip3 installl kivy==1.10'

Several possible solutions to this:

Add a many_linux wheel, so that compilation can be skipped
Update the download section to have an up-to-date rpm file
Add a Docker image with the dependencies and whatnot to build things in
Find the relevant errors and fix them

Fixed in https://github.com/kivy/kivy/pull/5459.


Removing Trailing Whitespace from Docs, Fixing Wording

Hi there,
Love django-authority! Been using it extensively in my work projects.
Anyhow--this pull contains removal of all trailing whitespace from the doc files, as well as a small wording fix (the original reason for the pull request).

Thanks!


Proper Entity Flags

This PR

fixes the functionality of the allow-entity-place and deny-entity-place flags.
adds additional flags:

allow-entity-damage allows players to damage the listed entities
deny-entity-damage prevents players from damaging the listed entities
allow-entity-destroy allows players to destroy the listed entities
deny-entity-destroy prevents players from destroying the listed entities

This addresses issue #75


Null Value Stops Execution - wackydb_all_items

This null value stops the execution, and I cannot save any of the items after this one null value.

List of Mods

Steps to Reproduce

Install these mods via r2Modman
launch the game
start a new character/ hammerworld
open F5 console
run the command wackydb_all_items
Observe that the null value stops the execution and you don't get to save the remaining items

Expected
All of the items will be saved
Actual
Items up to a null value will be saved and the execution stops.

Fixed in 2.2.1


Container component to dynamically replace an async loaded Drawable

Will be used in osu! for things like user avatar and cover background.
Related to https://github.com/ppy/osu/issues/2445
Note there is currently an edge case where spamming updates can occasionally leave DelayedLoadWrappers that do not expire.  I welcome comments and/or solutions.
Fixed.

isn't this wrong? seems to be missing asserts. also you probably want to add a test for other features like the delayed load.

Hmm that test used to work, might be a regression when I reimplemented updateDrawable.  I'll look into it.

I've added a CreateDelayedLoadWrapper method that can be overridden by subclasses to provide a custom DelayedLoadWrapper, but that means I can no longer expose LoadTriggered from a private subclass.
I'm not sure whether LoadTriggered would actually be useful for ModelBackedDrawable, but regardless I need a way to verify in the visual test that LoadDelay is doing what it's supposed to.
Any suggestions?

Note that changing this to a CompositeDrawable means that UpdateableAvatar etc. in osu! will now need to be wrapped in a Container to apply the masking and edge effects.

I don't think this should happen.

A common scenario of use would be to always fade the new element above the previous one (and expire the previous one after the fade completes) rather than calling FadeOut on the old one. This avoids a period where both opacities are below 1.0 which produces a bad visual effect.
I'd go as far as saying thing should probably be default behaviour.
That said, it doesn't work correctly at the moment when a placeholder is being used, as the depth of the placeholder is always below every other added drawable. So we probably need depth management (incremented each time a drawable or placeholder is displayed).

HideDrawable accepting a null is intentional, since it doesn't check whether the placeholder exists when calling it.  I could do a check first instead?

It should definitely not be fired with a null drawable unless it is documented and has a reason to occur. I'd say just stop it from happening.

Once this one is merged I can push through another PR to resolve https://github.com/ppy/osu/issues/2445

I think this looks good to go. May evolve as we use it, but I'm happy with the code for now 👍


Add list of posters/landmarks to warp to

Closed https://github.com/conix-center/ARENA-core/pull/105


Implement switch to new output format.

DataFrame with columns for measure, partition_level, partition_label, type_level, type_label, q and diversity. the type_* columns will be omitted for now.

#13 Now merged and fixes this.


Create diagrams for web flow

A basic user flow should be established to keep in mind when making Mockups.
A diagram detailing the interactions that can be done by the user would help a lot in this regard.

Would mean unnecessary time loss, there are too little screens in total to justify this.


Address various Checkstyle suggestions

This PR should be fairly self-explanatory.
Please review it commit-by-commit, in order to make it easier to see what changes were done.
If you have any questions why a particular change was done, don't hesitate to ask.

Can one of the admins please verify this patch?

Sorry this has gotten so messy now after the rebase. I was fighting some problems with my IDE. I'd really advise squashing all the commits when merging this.
Also, I changed the String comparison for now to use Object.equals.

Closing this for now as it keeps conflicting without being merged.
If someone is willing to get this done, feel free to reopen.

I'm happy to merge this now if you can rebase it before any major PR comes rolling in

Hooray Jenkins reported success with all tests good!

Scratch that - I've done it :) thanks for your patience
And I'm sorry, but I must have done something wrong since this hasn't closed itself, yet the commits are there in develop

Thanks!


[Flaky Test] tests/python/frontend/paddlepaddle/test_forward.py::test_forward_gather

Test(s)

tests/python/frontend/paddlepaddle/test_forward.py::test_forward_gather

Jenkins Links

https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-10534/3/

In PR #10534 I did not touch anything beyond relay lowering and re-triggering CI could pass the test.

we haven't seen this failure lately and the test is not skipped so closing this issue


How to write to separate log files based on some condition?

I spent a lot of time looking at the source to see how this can be plugged in but I'm wondering if anyone has already done this before. Basically I need to write to different logs for API and web-application requests. The differentiation can be done based on the path of the request. Is there any built-in functionality that can do this as of now?

This is currently not part of lograge. Lograge just takes care about the formatting and not where the logs go. For this you could create your own customized instance of a logger that dispatches the messages to different loggers based on your criteria.


Restructre the apprtc repo

Now GAE must be pushed from out/app_engine, created from 'grunt build'.

Move third_party under /src, as in Chrome
Also, adapter.js seems out of sync with the latest in webrtc/adapter. Long term, we should make apprtc pull adapter as a dependency, but we can do that in a followup.

Done. PTAL.

lgtm. Please move over any remaining apprtc issues from the issue tracker and PSA this to discuss-webrtc.


Make header about 25% larger

This way the logo will be bigger, which it needs to be...

I think the header is good on laptop now, but it needs to be made smaller for mobile.

I might tweak it just slightly smaller on non-mobile at this point, actually. Not much, just a little bit too big right now.


python311Packages.awkward-cpp: 30 -> 31

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python311Packages.awkward-cpp is: CPU kernels and compiled extensions for Awkward Array
meta.homepage for python311Packages.awkward-cpp is: https://github.com/scikit-hep/awkward
meta.changelog for python311Packages.awkward-cpp is: https://github.com/scikit-hep/awkward/releases/tag/v31
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 31 with grep in /nix/store/95qd07by1n9ipcasr0988kf875yc0a4g-python3.11-awkward-cpp-31
found 31 in filename of file in /nix/store/95qd07by1n9ipcasr0988kf875yc0a4g-python3.11-awkward-cpp-31

Rebuild report (if merged into master) (click to expand)

13 total rebuild path(s)

13 package rebuild(s)

First fifty rebuilds by attrpath
python311Packages.awkward
python311Packages.awkward-cpp
python311Packages.coffea
python311Packages.correctionlib
python311Packages.dask-awkward
python311Packages.mplhep
python311Packages.uproot
python311Packages.vector
python312Packages.awkward
python312Packages.awkward-cpp
python312Packages.correctionlib
python312Packages.uproot
python312Packages.vector

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/95qd07by1n9ipcasr0988kf875yc0a4g-python3.11-awkward-cpp-31 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python311Packages.awkward-cpp https://github.com/r-ryantm/nixpkgs/archive/b8ba8ef586f3fc64175db43bf3879910d36547ce.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/b8ba8ef586f3fc64175db43bf3879910d36547ce#python311Packages.awkward-cpp

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/95qd07by1n9ipcasr0988kf875yc0a4g-python3.11-awkward-cpp-31
ls -la /nix/store/95qd07by1n9ipcasr0988kf875yc0a4g-python3.11-awkward-cpp-31/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

22 packages failed to build:

python311Packages.awkward
python311Packages.awkward.dist
python311Packages.coffea
python311Packages.coffea.dist
python311Packages.correctionlib
python311Packages.correctionlib.dist
python311Packages.dask-awkward
python311Packages.dask-awkward.dist
python311Packages.mplhep
python311Packages.mplhep.dist
python311Packages.uproot
python311Packages.uproot.dist
python311Packages.vector
python311Packages.vector.dist
python312Packages.awkward
python312Packages.awkward.dist
python312Packages.correctionlib
python312Packages.correctionlib.dist
python312Packages.uproot
python312Packages.uproot.dist
python312Packages.vector
python312Packages.vector.dist

4 packages built:

python311Packages.awkward-cpp
python311Packages.awkward-cpp.dist
python312Packages.awkward-cpp
python312Packages.awkward-cpp.dist

Maintainer pings
cc @veprbl for testing.

Done in #300810.


fix a bug that activeLink does not work

This is because React's style prop does not support an array.

FYI: I have deployed a react-treebeard fork with this patch (https://github.com/bitjourney/react-treebeard/tree/bitjourney ), and it works well on both client-side and server-side rendering.


Applied fixes from StyleCI

This pull request applies code style fixes from an analysis carried out by StyleCI.

For more information, click here.

Coverage decreased (-5.3%) to 89.855% when pulling ac153a126d026394c48f982c5bd4fd8e4012dfe2 on analysis-8wjAJe into eb4c885e462e1534c6c91528a9b0e15c2f7399c3 on master.


Add GitHub actions

Codecov Report

Merging #22 (e1d3999) into main (a6700df) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
- Coverage   74.15%   74.11%   -0.05%
==========================================
  Files          90       90
  Lines        4817     4817
==========================================
- Hits         3572     3570       -2
- Misses       1245     1247       +2

Impacted Files
Coverage Δ

golem/core/dag/linked_graph.py
98.47% <0.00%> (-1.53%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Sunrise/sunset Times Not Accurate

I'm getting inaccurate sunrise and sunset times.  The odd bit is that the calculation for 12 and 18 degree twilights is spot on.  Here's an example where I calculate tonight's times for Keck (in local times):
from astropy import units as u
from astropy.time import Time, TimezoneInfo
from astroplan import Observer

obs = Observer.at_site('Keck')
HST = TimezoneInfo(utc_offset=-10*u.hour, tzname='HST')
date = '2016-08-22'
time = Time('{} 23:00:00'.format(date))

sunset = obs.sun_set_time(time, which='next', horizon=0*u.deg)
print('Sunset:          {}'.format(sunset.to_datetime(timezone=HST)))
sunset = obs.sun_set_time(time, which='next', horizon=-12*u.deg)
print('12 deg Twilight: {}'.format(sunset.to_datetime(timezone=HST)))
sunset = obs.sun_set_time(time, which='next', horizon=-18*u.deg)
print('18 deg Twilight: {}'.format(sunset.to_datetime(timezone=HST)))
sunrise = obs.sun_rise_time(time, which='next', horizon=-18*u.deg)
print('18 deg Twilight: {}'.format(sunrise.to_datetime(timezone=HST)))
sunrise = obs.sun_rise_time(time, which='next', horizon=-12*u.deg)
print('12 deg Twilight: {}'.format(sunrise.to_datetime(timezone=HST)))
sunrise = obs.sun_rise_time(time, which='next', horizon=0*u.deg)
print('Sunrise:         {}'.format(sunrise.to_datetime(timezone=HST)))

The output is:
Sunset:          2016-08-22 18:41:00.637777-10:00
12 deg Twilight: 2016-08-22 19:33:40.070690-10:00
18 deg Twilight: 2016-08-22 20:00:30.753806-10:00
18 deg Twilight: 2016-08-23 04:48:34.130495-10:00
12 deg Twilight: 2016-08-23 05:15:24.788828-10:00
Sunrise:         2016-08-23 06:08:04.168392-10:00

When I compare against Brian Casey's Online Calculator and against the Mauna Kea Weather Center  (scroll to bottom of page to see the times), my astroplan calculations for sunset and sunrise are off by 13 minutes, but the twilight times are within 1 minute.

This is due to atmospheric refraction. Astropy accounts for atmospheric refraction for targets altitude >= 0, but refraction can't be computed for altitude < 0, which would explain why your tests agree below the horizon, and disagree above the horizon.
Here's an example that demonstrates the difference. Let's compute the position of the sun at the time of sunset computed by astroplan:
from astroplan import Observer

import astropy.units as u
from astropy.time import Time
from astropy.coordinates import get_sun, AltAz, EarthLocation

location = EarthLocation.of_site('keck')
keck = Observer.at_site('keck')
sunset = keck.sun_set_time(Time('2016-08-23'), which='next')
sun = get_sun(sunset)

# Set up an alt/az reference frame _with_ an atmosphere:
aa_frame_1bar = AltAz(location= keck.location, obstime=sunset, pressure=1*u.bar)

# Set up an alt/az reference frame _without_ an atmosphere
aa_frame_no_atm = AltAz(location= keck.location, obstime=sunset, pressure=0*u.bar)

# Compute the altitude of the sun in each reference frame:
altitude_no_atm = sun.transform_to(aa_frame_no_atm).alt
altitude_1bar_atm = sun.transform_to(aa_frame_1bar).alt

# Compute the difference in altitudes in each reference frame, in arcminutes:
altitude_difference = (altitude_no_atm - altitude_1bar_atm).to(u.arcmin)
print(altitude_difference)

This returns -11.569arcmin, which roughly accounts for the 13+/-1 minute discrepancy you're seeing.
So in fact astroplan is not inaccurate, it is computing a different quantity than your point of comparison.

@bmorris3 Thanks for the info.  I have a couple of questions.  First, I would think that -11.569 arcmin should only delay sunset by of order a minute (at ~15 arcminutes per minute sidereal rate), not 13 minutes.
Second, how would I calculate the time of apparent sunset?
thanks!
Josh

@joshwalawender That sounds reasonable. It's difficult to compare against a black box and understand all of the differences, but the fact that we agree closely below the horizon suggests that astropy treats targets above the horizon differently than the calculator you're comparing against.
Perhaps @eteq can comment on what other second-order corrections are applied to the AltAz coordinate calculations, which will differ from simpler calculators?

Second, how would I calculate the time of apparent sunset?

Observer.sun_set_time returns the time when the center of the solar disk is on the horizon, given the refraction, aberration, and other corrections applied -- is this what you mean by apparent sunset? Note that in practice, air pressure, temperature, humidity and other quantities can change the observed time of apparent sunset.

Thanks @bmorris!  I think I understand now.  The last bit of my confusion was accounting for the "true horizon" due to the curvature of the Earth.  That was where my discrepancy came from.  When I add in the factor of the true horizon, my astroplan calculations match the time of perceived sunset (checked on web cams tonight) to within less than a minute.
The time difference with no atmosphere vs. a 620mbar atmosphere (at elevation of Mauna Kea) is about 30 seconds.
I'm going to close this now, but in case anyone is interested:
from astropy import units as u
from astropy.time import Time, TimezoneInfo
from astroplan import Observer
from astropy.coordinates import get_sun, AltAz, EarthLocation
import numpy as np

## Calculate Elevation of True Horizon
## Formulas from https://en.wikipedia.org/wiki/Horizon
h = 4.2*u.km
R = (1.0*u.earthRad).to(u.km)
d = np.sqrt(h*(2*R+h))
phi = (np.arccos((d/R).value)*u.radian).to(u.deg)
hzel = phi - 90*u.deg
print('Mauna Kea Sunset is at elevation of {}'.format(hzel))

keck = Observer.at_site('Keck')
HST = TimezoneInfo(utc_offset=-10*u.hour, tzname='HST')
date = '2016-08-25'
time = Time('{} 23:00:00'.format(date))

sunset = keck.sun_set_time(time, which='next', horizon=0*u.deg)
print('Sunset:            {}'.format(sunset.to_datetime(timezone=HST)))
sunset = keck.sun_set_time(time, which='next', horizon=hzel)
print('Mauna Kea Sunset:  {}'.format(sunset.to_datetime(timezone=HST)))

# By default, this sun will be initialized in GCRS coordinates
sun = get_sun(sunset)
# Set up an alt/az reference frame _with_ an atmosphere:
aa_frame_atm = AltAz(location=keck.location, obstime=sunset, pressure=0.620*u.bar)
# Set up an alt/az reference frame _without_ an atmosphere
aa_frame_no_atm = AltAz(location=keck.location, obstime=sunset, pressure=0*u.bar)
# Compute the altitude of the sun in each reference frame:
altitude_no_atm = sun.transform_to(aa_frame_no_atm).alt
altitude_atm = sun.transform_to(aa_frame_atm).alt
print(altitude_no_atm)
print(altitude_atm)

sunset = keck.sun_set_time(time, which='next', horizon=-12*u.deg)
print('12 deg Twilight:   {}'.format(sunset.to_datetime(timezone=HST)))
sunset = keck.sun_set_time(time, which='next', horizon=-18*u.deg)
print('18 deg Twilight:   {}'.format(sunset.to_datetime(timezone=HST)))
sunrise = keck.sun_rise_time(time, which='next', horizon=-18*u.deg)
print('18 deg Twilight:   {}'.format(sunrise.to_datetime(timezone=HST)))
sunrise = keck.sun_rise_time(time, which='next', horizon=-12*u.deg)
print('12 deg Twilight:   {}'.format(sunrise.to_datetime(timezone=HST)))
sunrise = keck.sun_rise_time(time, which='next', horizon=hzel)
print('Mauna Kea Sunrise: {}'.format(sunrise.to_datetime(timezone=HST)))
sunrise = keck.sun_rise_time(time, which='next', horizon=0*u.deg)
print('Sunrise:           {}'.format(sunrise.to_datetime(timezone=HST)))

Results in:
Mauna Kea Sunset is at elevation of -2.0800907212114623 deg
Sunset:            2016-08-25 18:38:38.241043-10:00
Mauna Kea Sunset:  2016-08-25 18:47:39.116887-10:00
-2d04m48.9216s
-1d57m59.4462s
12 deg Twilight:   2016-08-25 19:31:02.668566-10:00
18 deg Twilight:   2016-08-25 19:57:42.667814-10:00
18 deg Twilight:   2016-08-26 04:49:42.686269-10:00
12 deg Twilight:   2016-08-26 05:16:23.109695-10:00
Mauna Kea Sunrise: 2016-08-26 05:59:46.406136-10:00
Sunrise:           2016-08-26 06:08:47.378015-10:00

Excellent! That observational test is the best test I've heard of yet.


Virtual Machine UI issues

[x] 1. On the Virtual Machine list page, the machine created time tooltip displays out of the page - validated

[x] 2. On the Virtual Machine create page, to add a new SSH key, every time click the save button without filling anything, a new error message will be added on the popup window. Moreover, close the window and open it again, the error messages are still there - Validated failed, I'd put it in a separate issue to track

[x] 3. On the VM edit page, the SSH keys are not selected as they were when the VM was created - Validated failed, I'd put it in a separate issue to track

[x] 4. Label/Annotation/Description will reflect the changes even though they haven't been saved - validated

[x] 5. CPU and Memory can be negative - validated

[x] 6. The hostname cannot be customized - validated

Validation passed except case 2 and 3, will track them in #180 and #181


[DRC-945] [Bug] Unable to execute Profile diff

Current Behavior
Currently, whenever I select Profile, I run into the issue below. I am not aware what is going wrong.

Expected Behavior
I would expect the behaviour described here: https://datarecce.io/docs/features/lineage/#profile-diff
Steps To Reproduce
I am not sure if it is a data issue.
I did probably all the required steps.

Installed required dbt packages
Build the production state.
Build the dev state.
Tried to explore Profile.

Relevant log output
No response
Environment

recce: 0.41.0
OS: Mac
Python: 3.9
Data Warehouse: Databricks
dbt: 1.8.7

Additional Context
No response
DRC-945

Hi @alexeyegorov
Thanks for opening this issue. We're taking a look at this and will get back to you soon.
Dave

The Row object is from Agate. We should check if there is breaking change for latest Agate.

Put in cycle51

Hi @alexeyegorov
Thanks for your bug report.
The fix will be included in v0.45.0. It should be ready before Thursday (UTC+8).
Andy

@wcchang1115 thanks. I will test it as far as it is there and report back. :)


Mismatch between npm package licence and licens on github

https://www.npmjs.com/package/@liberation-data/drivine?activeTab=readme shows LGPL-3.0 or later while GitHub shows Apache 2.0 license.

This is a bug in NPM. Github is correct.


Added my Hangman Game in C language

Contributing
If you want to add a project to this list, please make sure that:

[x] You read the contributing guide
[x] The repository has hacktoberfest as topic and counts for hacktoberfest event
[x] The project can't be just an "add your name" or simply + 1 contribution to hacktoberfest
[x] Place them in alphabetical order
[x] One repository per PR/contribution - avoid conflicts and simplify review
[x] Your pull request is not spammy just adding an empty line, otherwise it will be marked as invalid and not count to hacktoberfest.

If they meet the requirements above, feel free to create a PR. Happy Hacking! :sparkles:

Sorry but this is spam, you completed the checkbox with untruth info, please read the contributing guide


fix logging of coalesced packets

Coalesced packets that just have a single part shouldn't be logged as coalesced packets.

Codecov Report

Merging #2366 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #2366      +/-   ##
==========================================
- Coverage   86.14%   86.14%   -0.01%
==========================================
  Files         119      119
  Lines        8847     8850       +3
==========================================
+ Hits         7621     7623       +2
- Misses        919      921       +2
+ Partials      307      306       -1

Impacted Files
Coverage Δ

session.go
73.12% <0%> (-0.24%)
:arrow_down:

server.go
84.74% <0%> (+0.65%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5d88d3...c1cb3e6. Read the comment docs.


new feature

Describe the bug
When I click on any application in dock-hyprland, my cursor moves to the centre of the window.
To Reproduce
Steps to reproduce the behavior:

Click on any application

Expected behavior
A configuration that allows, whether you want it or not
Screenshots

None

Desktop (please complete the following information):

Linux distribution: :nixos
go version -
gtk-layer-shell version -

Additional context

None

This is a Hyprland setting. Set no_cursor_warps = true to disable.


Rethink how to withdraw crews

Example as Mays Mens 1976 results, Corpus Christi 5 withdraws from the penultimate division.  6ecb6e1f080b6b68e0c73b230798d1bda9d43717 adds the file, with two potential codings.  The first (commented out) uses x to withdraw the crew, the second uses v0 codes to indicate the crew didn't race.

Using x means all the results below this need to change to all gain a place, so u becomes e2r, etc.  This is timeconsuming and could be done automatically - when you receive an x you go down and change the outcomes of all the crews below.  Changing this would mean changing results files for all occurrences with crews withdrawing (65 files), but probably more logical (most of these results have crews withdrawing near the bottom anyway).
The statistics will be affected with either coding method.  Using x means on that day all crews below will report going up an extra place (in 1976 Mays giving Emmanuel 6 blades, as they rowed over that day but bumped on the others).  Using v0 coding means all crews 'jumping over' that gap in the start order will go up or down an extra place.  If we automatically adjust the crews below the one that dropped out we could mark those additional places gained as virtual and not real
Should check what the statistics say for that college and year - is that crew with withdraws judged to have raced?  Do they have partial results credited?
The first way means the bumps chart looks a bit odd for that day for more crews, the second way makes the bumps chart look a bit odd for that position on the rest of the days.
Instead of either coding method, we could change x so that it withdraws the crew, but leaves a vertical hole in the start order for the rest of the set.  A crew bumping up across this gap would be entered as u and credited with one place, but shown on the bumps chart as going up two to skip the gap.

Separate the data model from the view.
Data model - shouldn't need to enter results before a withdrawing crew that moves them up one. Shouldn't need to enter results from crews jumping over a gap that are different from us the gap wasn't there. Statistics use the data model for results.
View model - can either show all crews below the withdrawing going up one additional place, or leave a gap where the withdrawn crew was. Or pick one or other method depending of some heuristic.

Per crew position maintain the boolean of whether the crew in that position has withdraw.  As you iterate to the next crew (up 1, or up 3, etc) you would need to check each crew record and skip over withdrawn crews.
Even the v/e exact moves would also want to be relative to the actual start order, so adjusted in the same way.  That means we need to correctly be able to iterate down as well as up past the withdrawn crew.
The move array may need to be duplicated - one being the number of actual places gained/lost that day, the other being the change in the crew order that day (so a +1 in the first may result in a +2 in the second, if we're skipping over a withdrawn crew).  You need to account for this per day, rather than just overall, so that the stats of places gained on a single day is correct.
The back array would be maintained as is, since it's a map into the crew array.

However example of 1827 mays (March 17), where a crew overbumps past a withdrawing crew.  When processing the results for that day you will get to the o3 command before the x, so processing the x would need changing the definition of the crew that overbumped.
One option could change the withdraw command to be required at the start of the day, with a x(num) to withdraw a given crew number in that day, after which you give the results for all the rest of the crews still racing.  Or could keep the syntax as it is, but after withdrawing a crew you'll need to spot crews that jumped over this now vacant slot and redo their commands.

One question on the accuracy of our stats, it's unclear for the 'v0' type results whether in reality the gap was left and so do crews bumping over this crew go up one or two places?  I suspect the division raced without that crew and crews below shuffled up, so an e2 result would only get up 1 on the statistics.  Maybe need to review the charts with v entries to try and guess what the best way to handle this is.

With the current results formatting for withdrawing crews and having virtual crews (with the assumption that racing crews are shuffled up to fill the gaps left by crews skipping that day with virtual results), change 0d253edab56e884434bb6cb8d70e53e8ed0260db fixes the blades colouring and statistics to account for the extra places gained/lost each day.  This means this issue now just tracks whether I want to re-code the bumps results processing to cope with gaps in the start order caused by withdrawn crews.


Release 6.1.5

Guys please push a new release ... this should take minutes. Or revert to 6.1.2.
The current "stable" release breaks all projects that auto-update to it. This generates a lot of pain for everyone using jeet.

This does not just take minutes.
It would work way faster if people would cooperate with us to help that issues are fixed, because we do not want to push another broken release.
You could go ahead and try the current master branch of the repository with your workflow and look if everything is working fine again. I just want to get sure that the old behaviour is restored, but we have the new changes in so we can progress again and add more features/fixes onward.

It would take minutes if you were using a develop branch. And only merge stuff into master once they are properly tested. (Like using GitFlow approach: https://www.atlassian.com/git/tutorials/comparing-workflows/gitflow-workflow)
I'm pretty sure we can switch to another branching model with absolutely no issues. (PR's would just need to be re-done (we only have 5).
It doesn't make sense to keep a broken release for 3 months and wait until everything is fixed to make a new release (things are never 100% done). You should be able to release hotfixes and patches as soon as they are available.
I'm grateful for your hard work guys, but we should find a solution to this issue. It only damages Jeet's reputation and creates a lot of headaches where it shouldn't.

The problem is, which kind of started this all, was over a year worth of unreleased changes that basically changed the entire API, and they, slipped into one fix-release, which then followed up another one (6.1.4), which also isn't really working (but better than 6.1.3, which is abysmal).
The current master reflects fixes that should work, and I've gotten some feedback on it, which is great, but the provided feedback is simply not enough for me to just push out another release.
And of course, the branching model etc. pp. can be switched, and I'm pretty sure we will, but the first step to that is fixing the current master and bringing out a working release. After that, for Jeet 7 and following, I'll even try to look into properly testing the outputs, so we can get sure that it's working fine at any time possible.
It's not really waiting to be fixed, I'm waiting for it to be tested in somewhat stable workflows, mostly in Stylus, as the Stylus users have most issues with it right now (and I have virtually no experience with it, I'm more on the SCSS-side of things). I can test single functions with made up files really quickly, but that does not guarantee that it will work in a huge project, where ever that might be.

Understood. Will be testing the master in the coming month to see if there are issues.

@pixeldesu What is more simple to downgrade master branch to 6.1.2 or whatever is working now and move HEAD from it to DEVELOP branch?

@zenopopovici @alex-shamshurin
I opened #504 as a discussion for a revert and bringing back features from 6.1.2, leave a reaction or comment for feedback!
Will be closing this issue in the meantime.


[Helm 3] improper RBAC setup causes release to be stuck in pending-install status despite installing fine

I tried deploying a simple Go application with a Helm chart using Helm 3, running on Kubernetes. You can find the helm chart here. The application installs fine, without error and even reports a status of deployed.
sh-4.2# helm install gotemplate .
NAME: gotemplate
LAST DEPLOYED: Tue Dec  3 21:36:02 2019
NAMESPACE: che
STATUS: deployed
REVISION: 1
TEST SUITE: None

However, it does not show up in the list of releases when I run helm list. If I run helm list --all it shows up with a status of pending-install, despite the install completing fine.
sh-4.2# helm list
NAME    NAMESPACE       REVISION        UPDATED STATUS  CHART   APP VERSION
sh-4.2# helm list --all
NAME            NAMESPACE       REVISION        UPDATED                                 STATUS          CHART                   APP VERSION
gotemplate      che             1               2019-12-03 21:36:02.653465978 +0000 UTC pending-install gotemplate-0.1.0        1.0

The same Helm chart deploys fine on Helm 2.x.

Output of helm version:
sh-4.2# helm version
version.BuildInfo{Version:"v3.0.0", GitCommit:"e29ce2a54e96cd02ccfce88bee4f58bb6e2a28b6", GitTreeState:"clean", GoVersion:"go1.13.4"}

Output of kubectl version:
sh-4.2# kubectl version
Client Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.3", GitCommit:"b3cbbae08ec52a7fc73d334838e18d17e8512749", GitTreeState:"clean", BuildDate:"2019-11-13T11:23:11Z", GoVersion:"go1.12.12", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"14+", GitVersion:"v1.14.6+2e5ed54", GitCommit:"2e5ed54", GitTreeState:"clean", BuildDate:"2019-10-10T22:04:13Z", GoVersion:"go1.12.8", Compiler:"gc", Platform:"linux/amd64"}

Cloud Provider/Platform (AKS, GKE, Minikube etc.):
OpenShift

The debug logs also didn't indicate anything wrong:
sh-4.2# helm install gotemplate . --debug
install.go:148: [debug] Original chart version: ""
install.go:165: [debug] CHART PATH: /tmp/gogotet/gotemplate

client.go:87: [debug] creating 2 resource(s)
NAME: gotemplate
LAST DEPLOYED: Tue Dec  3 21:50:54 2019
NAMESPACE: che
STATUS: deployed
REVISION: 1
TEST SUITE: None
USER-SUPPLIED VALUES:
{}

COMPUTED VALUES:
image:
  pullPolicy: Always
  repository: sample
  tag: v0.1.0
replicaCount: 1
resources:
  cpu: 100m
  memory: 128Mi
  requests:
    cpu: 100m
    memory: 128Mi
service:
  name: Node
  servicePort: 8000
  type: NodePort

HOOKS:
MANIFEST:
---
# Source: gotemplate/templates/service.yaml
apiVersion: v1
kind: Service
metadata:
  name: cw-gogotet-dccf38f0-160f-11ea-ab26
  labels:
    chart: gotemplate-0.1.0
    projectID: dccf38f0-160f-11ea-ab26-791dd12c33b3
    release: cw-gogotet-dccf38f0-160f-11ea-ab26
  ownerReferences:
  - apiVersion: apps/v1
    blockOwnerDeletion: true
    controller: true
    kind: ReplicaSet
    name: codewind-workspace798zbeq2cf3esdnq-6f76c8dbbc
    uid: dce9dd7b-160d-11ea-92b4-00000a1012bc
spec:
  type: NodePort
  ports:
  - name: http
    port: 8000
  selector:
    app: gotemplate-selector
    release: cw-gogotet-dccf38f0-160f-11ea-ab26
---
# Source: gotemplate/templates/deployment.yaml
apiVersion: extensions/v1beta1
kind: Deployment
metadata:
  name: cw-gogotet-dccf38f0-160f-11ea-ab26
  labels:
    chart: gotemplate-0.1.0
    release: cw-gogotet-dccf38f0-160f-11ea-ab26
    projectID: dccf38f0-160f-11ea-ab26-791dd12c33b3
  ownerReferences:
  - apiVersion: apps/v1
    blockOwnerDeletion: true
    controller: true
    kind: ReplicaSet
    name: codewind-workspace798zbeq2cf3esdnq-6f76c8dbbc
    uid: dce9dd7b-160d-11ea-92b4-00000a1012bc
spec:
  replicas: 1
  template:
    metadata:
      labels:
        app: gotemplate-selector
        version: current
        release: cw-gogotet-dccf38f0-160f-11ea-ab26
        projectID: dccf38f0-160f-11ea-ab26-791dd12c33b3
    spec:
      containers:
      - name: gotemplate
        image: docker.io/johncollier/cw-gogotet-dccf38f0-160f-11ea-ab26:latest
        imagePullPolicy: Always
        ports:
        - containerPort: 8000
        livenessProbe:
          httpGet:
            path: /
            port: 8000
        readinessProbe:
          httpGet:
            path: /
            port: 8000
        resources: null
        env:
        - name: PORT
          value: "8000"
      serviceAccountName: che-workspace

Could this be an issue running on Kubernetes? If I deploy the application with Helm 3 on my laptop it's fine, but not if I deploy from within Kubernetes.

Hi @johnmcollier. Would you be willing to volunteer your time to improve the error reporting? We'd happily accept PRs to improve this experience for others.

@johnmcollier @bacongobbler , We are facing exact similar issue while trying to deploy Pega platform on PKS via. Helm. Will try again by adding update verb on secrets resource in Role file.
But wanted to understand why does Helm v3 needs that to display the release status properly ?

Helm stores information about an install/upgrade into a secret. See more: https://helm.sh/docs/topics/architecture/

@bacongobbler  My bad. I read that piece when started working on Helm v3 a few weeks ago.. Thanks for the prompt response..

@bacongobbler , we added the "update" verb to Secrets resource in Role file and applied that to our account as well but still helm release shows pending-install status..

Facing the same issue. Cluster installed with kubeadm 1.18.2 and using helm 3.2.0
$ helm list -a
NAME	NAMESPACE	REVISION	UPDATED                                	STATUS         	CHART     	APP VERSION
test	default  	1       	2020-05-04 20:40:09.827303259 +0000 UTC	pending-install	kong-1.1.0	2.0.4

Same Issue even after using --wait and timeout flags on helm3
The timeout never happens
--wait --timeout 2h
# helm3 version --short v3.2.1+gfe51cd1
Chart goes into pending-install no timeouts happening
`
date
Thu May 21 19:33:38 UTC 2020
helm3 history my-chart -n my_namespace
REVISION        UPDATED                         STATUS          CHART                                           APP VERSION     DESCRIPTION
1               Thu May 21 10:47:19 2020        pending-install my-chart                                        1.0             Initial install underway
date
Thu May 21 19:33:56 UTC 2020
`
The chart has a Post-Install Hook which never got started.
    "helm.sh/hook": post-install,post-upgrade     "helm.sh/hook-weight": "-5"     "helm.sh/hook-delete-policy": before-hook-creation
Any ideas where to look for any error logs for hook start issues ?

Im facing this issue with nginx-ingress chart. All other charts seem to deploy fine. The pods are launched and showin as healthy.
❯ kubectl version
Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.0", GitCommit:"9e991415386e4cf155a24b1da15becaa390438d8", GitTreeState:"clean", BuildDate:"2020-03-26T06:17:09Z", GoVersion:"go1.14", Compiler:"gc", Platform:"darwin/amd64"}

Server Version: version.Info{Major:"1", Minor:"16+", GitVersion:"v1.16.8-eks-e16311", GitCommit:"e163110a04dcb2f39c3325af96d019b4925419eb", GitTreeState:"clean", BuildDate:"2020-03-27T22:37:12Z", GoVersion:"go1.13.8", Compiler:"gc", Platform:"linux/amd64"}

❯ helm version
version.BuildInfo{Version:"v3.2.4", GitCommit:"0ad800ef43d3b826f31a5ad8dfbb4fe05d143688", GitTreeState:"dirty", GoVersion:"go1.14.3"}

For me, a release ended up with pending-install status because an installation through Terraform had an error and aborted.
What I did to fix it (but be sure what you're doing!) was to manually edit the secret sh.helm.release... from status: pending-install to status: deployed. Then I did a re-install/upgrade to try and get it into a known good state.

We are experiencing this issue with Helm 3 as well. Each time we install, all the pods start successfully and the post-install hook (Job) succeeds but once in a while Helm does not complete the install command with log: helm.go:84: [debug] failed post-install: timed out waiting for the condition.
Either Helm is not receiving the status of the completed Job from the Kubernetes API or something is wrong in that area.

@bacongobbler, sorry for mentioning you on an old issue. We have been experiencing this problem a lot lately and I was trying to come up with a way Helm can identify it and fix itself. I was thinking about something along the lines:

Check if the last release is in a pending-install state
If it is, get the resource list from that release and check whether the resources were created (something similar with the waitForResources (https://github.com/helm/helm/blob/master/pkg/kube/wait.go)
If everything was created successfully, then mark the release as `deployed; meaningful error otherwise

Would a PR with such solution be welcome?

We faced and issue with a release getting stuck in pending-rollback while all resources were finally stable. This happened since the client was not running any more on our CD system.
Here is how I fixed it without uninstalling the release: https://gist.github.com/siavashs/7e3715879c0e946167749fa9a358380a

we're also faces the issue we deployed rook and we got pending-install.
we can't delete the rook and re deploy it, because it means destroying all the kubernetes  cluster

I faced a similar issue with nginx-ingress following the Installation with Helm guide. It creates a service of LoadBalancer type with default values that, in case there is no cloud provider support, will hang in pending state, causing the Helm release to be stuck:
NAME                          TYPE           CLUSTER-IP      EXTERNAL-IP   PORT(S)                      AGE
nginx-ingress-nginx-ingress   LoadBalancer   <IP_ADDRESS>   <pending>     80:31907/TCP,443:30199/TCP   6m17s

The fix is to pass controller.service.create=false value during the chart installation.
Hope this helps someone.

@artazar , Did you install nginx-ingress on k8s cluster that was running locally? And how did you create the cluster - using kubeadm or some other tool ? Reason I ask, because if someone wants to create the k8s cluster from scratch using kubeadm utility On-premise and expose the ingress externally, then what needs to be done ?

@sunnygoel8 this is slightly unrelated to the thread. I have the answer for you, normally it is MetalLB https://metallb.universe.tf that helps to do that. But let's please avoid abusing the github issue and discontinue this topic.

I faced this issue, lack of update verb on secrets, so I ended with a bunch of installed helm charts that are working but that cannot be upgraded with Helm. I tried to manually update the label to "deployed", but helm still believes they are in "pending-install",  I guess there is some other bookkeeping necessary in order for helm to "understand" they are in deployed status. Does anybody know what steps to take so that I can fix these deployments? (deleting them and re-installing them is not really and option for me...).

I have been banging my head on this issue until I realized that my SA does not have the Update verb.

I faced this issue, lack of update verb on secrets, so I ended with a bunch of installed helm charts that are working but that cannot be upgraded with Helm. I tried to manually update the label to "deployed", but helm still believes they are in "pending-install", I guess there is some other bookkeeping necessary in order for helm to "understand" they are in deployed status. Does anybody know what steps to take so that I can fix these deployments? (deleting them and re-installing them is not really and option for me...).

You could try helm rollback <release-name> <revision> which the revision is the latest revision (in my case is 1). I fixed this issue with that,

I faced this issue, lack of update verb on secrets, so I ended with a bunch of installed helm charts that are working but that cannot be upgraded with Helm. I tried to manually update the label to "deployed", but helm still believes they are in "pending-install", I guess there is some other bookkeeping necessary in order for helm to "understand" they are in deployed status. Does anybody know what steps to take so that I can fix these deployments? (deleting them and re-installing them is not really and option for me...).

You could try helm rollback <release-name> <revision> which the revision is the latest revision (in my case is 1). I fixed this issue with that,

That worked for me. Putting the currently installed version in the helm rollback only updated the status to "deployed", nothing else.

I can confirm that adding "update" to "secrets" rbac solved it for me

I am still running into this issue, adding the update to secrets RBAC has not fixed it for me. I have the ClusterAdmin role so my assumption is its something else...

it seems that patch is also required

Checking in on the status here... Has anyone looked into the work that was done in https://github.com/helm/helm/pull/9180, and the feedback that was provided there? A few community members including myself have chimed in that issue, but that does appear to be the start of a fix.

Updated the title to differentiate the discussion between this ticket and #4558.

Is this fixed, I am still getting this issue

had a similar issues with helm stuck in pending-install
in my case it was because of 2 cron jobs ...
cron jobs were planed for late night and 2 pvc claims were pending because of it
however claims where executed until pvc claims happened...
very anoying ...


Allow PHP 8 to be installed

Allowing PHP 8 on master branch could allow people on dev channel to report issues on it.
What do you think about this ?
Actual problem accoding to alcaeus is that mongo-php-driver isn't ready yet. https://github.com/mongodb/mongo-php-driver/issues/1161

Correct. Once we have the driver supporting PHP 8, we'll also allow installing this library on PHP 8, which also allows Doctrine MongoDB ODM to test PHP 8 support.

any update on this issue?

"php": "^7.0 || ^8.0" is the actual value in https://github.com/mongodb/mongo-php-library/commit/78e3606207a749a72c30b1f61552486cbde06443#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34
so this is fine. https://github.com/mongodb/mongo-php-library/pull/793

@itisjoby the 1.8.0 release of this library, along with the corresponding 1.9.0 release of ext-mongodb introduced compatibility with PHP 8 and was released in November. I apologise for not posting an update in every ticket that mentioned PHP 8 support.


[SocketIO] MaxListenersExceededWarning

Hi,
I have more than 10 @SocketService('/') instances, so it produces a warning:

(node:1) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 disconnect listeners added. Use emitter.setMaxListeners() to increase limit

Maybe the better approach is to group events listeners per namespace and only register them after all  are loaded.
What do you think @Romakita ?
Of course I can increase a lImit ;)

... I never thought about the possibility that a single namespace could be used by several classes. This is why I've designed my code about one class = one distinct namespace.
I must rethink the architecture :\
XD

The next release should solve your problem ;)

Nice to see that:)
I will check it after weekend.
In my opinion it is a great feature that allows to create modular application with services and other files that are stored in a separate folders.

I saw that I had a performance problem when SocketService create the connect and disconnect listener.


thinkorswim: (un)installation automated

This depends on #10291

Java is apparently bundled with the installation package.

@vitorgalvao For the future, if a cask depends on a particular cask codebase version, it's better to release the cask core change first, wait a few weeks and then release the actual cask change - this way we can make sure people won't see errors trying to uninstall thinkorswim using older cask core codebase.

Ah, apologies, I just missed (skipped) your “[t]his depends on” comment. I looked at it and thought “why isn’t this merged yet? Oh, right, @radeksimko has voiced in the past that he doesn’t like to merge his own PRs”, so I thought you were just waiting for someone to do it.
When a PR depends on another, I usually prepend something like [HOLD until #0000] to the title, so I don’t keep checking it.

I thought you were just waiting for someone to do it.

Well I was, but when I've seen you merging this PR, the best thing I could do at that point was to merge the dependency, to reduce the potential harm for users. More importantly I've seen the "LGTM" from @phinze so I didn't feel bad when merging it.
It's not about not merging my own PRs, it's more about merging these without any feedback. I don't mind merging my own PRs if I know that someone else have seen that and was OK with that.

When a PR depends on another, I usually prepend something like [HOLD until #0000] to the title, so I don’t keep checking it.

OK, good to know, I will try to remember and use that convention. Maybe we could use a label for this instead?

it's more about merging these without any feedback.

Yeah, I guess sometimes we (I know I do it) see a small PR where everything looks fine, and don’t actually reply because we don’t realise it’s waiting for feedback, when it isn’t tagged, so it just stands there, when in actuality it could’ve already been merged.

Maybe we could use a label for this instead?

Agreed. Done.


Use pointer cursor instead of hand cursor when hovering over button

- What it looks now
normal cursor

Hand Cursor when hovering over the button

Although we know that these buttons are essentially hyperlinks, we still want to erase this distinction.It should use a normal pointer cursor in the button like apps developed with other frameworks.
Including
Sidebar Item

Menu Item

Tabs
Explorer
Statusbar Item

- What it should be
When hovering over the button, it should be a normal cursor, like in other apps.
For example, setting the left navigation item of the app

Most of the itmes have Highlight , so the hand pointer is uesless
All the apps built by WinForms,WPF,UWP or WinUI3,Qt or other frames did not have this bug(may you think that it is a feature)

I think the hand cursor is intended as a hint that you can drag the activity bar icons, for example to reorder them or move them to the side panel.

I think the hand cursor is intended as a hint that you can drag the activity bar icons, for example to reorder them or move them to the side panel.

What is the reason of hand cursor on Menu Highlight Item？

I somewhat agree with this but let's keep this issue open as a feature request to gather more feedback
fyi @sandy081

By changing the pointer it's more obvious when the pointer is over an actionable menu item. When over a disabled one the pointer remains an arrow. This is consistent with what happens when pointing at action buttons in the UI.

By changing the pointer it's more obvious when the pointer is over an actionable menu item. When over a disabled one the pointer remains an arrow. This is consistent with what happens when pointing at action buttons in the UI.

Most of the itmes have Highlight Status , so the hand pointer is uesless

VS Code's behaviour in this area is consistent with how the GitHub web UI behaves for me.

Agreed with @gjsjohnmurray. Its consistent now across VS Code to use hand cursor for all items those are clickable.
CC @misolori

@misolori
I don't think all the clickable items should use hand cursor.
It's inconsistent with Windows' default behavior, buttons are not hyperlinks, this is an app not a website.

this is an app not a website

https://code.visualstudio.com/blogs/2021/10/20/vscode-dev

this is an app not a website

https://code.visualstudio.com/blogs/2021/10/20/vscode-dev

Yes I know. But Outlook is a website, too. And the Office Online.

In the past, we've discussed whether we should drop the hand cursor and the team consensus was that it's still needed for the web but on desktop, we need to ensure we still have hover feedback as an alternate. I can bring this up again in our UX Sync.

Maybe we should change it only for context menus and the top menu? The pointer elsewhere in the UI is a good thing imo and a big change.

Maybe we should change it only for context menus and the top menu? The pointer elsewhere in the UI is a good thing imo and a big change.

the explorer has highlight，so it does not need hand cursor

I think it is better to do something else like add GUI for launch.json instead of arguing on this trivial issue.

I think it is better to do something else like add GUI for launch.json instead of arguing on this trivial issue.

It is based on Web so you can change the appearance by editing *.css

I think it is better to do something else like add GUI for launch.json instead of arguing on this trivial issue.

I am agree with “GUI for launch.json”, but I think the cursor is important,too.

I agree with you

Brought this up in our ux sync today and the consensus was:

We should explore this in the next iteration, early on
Revisit areas that don't provide hover feedback
Show underlines for blue links (since the pointer was the main feedback)
Read the OS guidelines for mac/win/linux to see if there are guidance
Possibly keep things consistent across platforms

So we'll start exploring this in our next iteration.

今天在我们的用户体验同步中提出了这一点，共识是：

我们应该在下一次迭代中尽早探索这个
重新访问不提供悬停反馈的区域
显示蓝色链接的下划线（因为指针是主要反馈）
阅读 mac/win/linux 的操作系统指南，看看是否有指南
可能保持跨平台的一致性

因此，我们将在下一次迭代中开始探索这一点。这是一个在misolori/promising-mammal-pointer中工作的演示
CleanShot.2022-08-10.at.08.48.45.mp4

This is a great start!
But in this earliest version I need to point out (though I know this is just an early demo of yours):
In macOS, the search box does not have a hover highlight effect.
On Windows and macOS, there is no hover change for normal buttons (there used to be a Reveal effect during the Windows 10 Creators Update)

Assigning this back to the backlog since we will not have time in September to think about this.
Also unassigning myself so design ca drive this. I personally think both options are fine.

Assigning this back to the backlog since we will not have time in September to think about this. Also unassigning myself so design ca drive this. I personally think both options are fine.

I think the design study is over based on @miguelsolorio 's feedback, the conclusion is clear, we should use the default cursor instead of the hand cursor in the hover effect on the desktop

Brought this up in our ux sync today and the consensus was:

We should explore this in the next iteration, early on
Revisit areas that don't provide hover feedback
Show underlines for blue links (since the pointer was the main feedback)
Read the OS guidelines for mac/win/linux to see if there are guidance
Possibly keep things consistent across platforms

So we'll start exploring this in our next iteration. Here's a demo of it working in misolori/promising-mammal-pointer
CleanShot.2022-08-10.at.08.48.45.mp4

I don't know why the assignment was removed, I think the conclusion of the design study is clear that this is a change that must be made.

I don't know why the assignment was removed

@Shomnipotence it has been reassigned to @daviddossett because @miguelsolorio has left the team.

I don't know why the assignment was removed

@Shomnipotence it has been reassigned to @daviddossett because @miguelsolorio has left the team.

I don't think it's necessary, the design research is over, the conclusions have been made, and it's time for the developers to perform.

After paying attention to this topic for a long time, what was the final conclusion regarding this topic? When will the cursor transition from the hand cursor back to the normal pointer cursor  when hovering over tab pages, the left toolbar, and the menu bar?

When the mouse hovers over the menu bar, left toolbar, and tab pages, the cursor displayed as a hand shape makes me very uncomfortable and unfamiliar.

The issue I have with the hand cursor is it blocks the tooltip and I have trouble reading it.

If I understand correctly, there is a simple rule for the web. If it’s a link with an href, it’s a hand cursor. If it’s an interactive element, the cursor is a pointer, a drag hand, resize arrows etc. Most on-page elements have a hover state which communicates their interactivity.
Can I ctrl+click it to open the result in a new tab? Can I right click and copy the URL?

yes → Hand
no → Something else (default pointer, drag hand, resize arrows, question mark, etc)

Most elements in VS Code cannot be opened in a new tab, so the cursor should not change to a hand.

This is of course just my opinion, but I think that as VS Code is a desktop app, it should behave like a desktop app. Meaning that it does not matter how web sites normally works.
The standard in desktop apps for all the big operating systems is that there is only a hand cursor when hovering something that is intended to be understood as a link, and that means that it is almost always something that does not look like a button, but is just text that might have a different color and/or be underlined to indicate that it's a link, and it is something that is expected to most likely open a web page, or at least lead to "somewhere else", possibly opening a different app, or in some cases open a folder in the file browser of the OS for example.
I don't know why this should be any different in VS Code. The behaviour that everything clickable is treated as if it was a link is just confusing and feels out of place, and doesn't help the user to understand the behaviour of the application either, as it's different from almost all other applications they will be using.
Someone could of course say that everyone is very used to how the web works, and that this might make sense because of that. But even while browsing the web you will not in any web browser I have seen get a hand cursor while hovering the tabs or the buttons in the toolbar, or menu items. The web browser itself distinguishes between what is a desktop app and what is a web site. So it still doesn't make any sense from the perspective of being familiar to the user.
You can of course run it as a web app too these days, and I guess that there might be more arguments for it to behave like a web site then, but it's still primarily a desktop app and a desktop app should behave like a desktop app to avoid creating unnecessary friction for the user.


⚠ Bofrost.be has degraded performance

In 20bf486, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1807 ms

Resolved: Bofrost.be performance has improved in 87bf7aa after 21 minutes.


Improve EnabledWithoutIVR details

Add additional details about what EnabledWithoutIVR value of SpamFilteringEnabledType variable actually means.

Docs Build status updates of commit 2740789:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Set-CsTeamsCallingPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Hi @get-itips! Since @JohanFreelancer9 and @tseward approved the PR, may you please merge it? Thanks!

Hi folks! Can I have this PR merged into master, please? Thanks!

Hi @tiburd, could you kindly help here? Thanks!
@dinabogdan could you kindly verify the mapping between GitHub and Microsoft aliases? The blue "Microsoft submitter" label still doesn't appear here. Thanks!

It looks like it is connected but not showing in this PR:

Docs Build status updates of commit 3d76fd8:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Set-CsTeamsCallingPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Comment form under the comments

Hi,
Is there an easy way to put the comment form under the comments ? I overrided the template and tried to put the form under the comments, but ajax is still adding comments under my form...
Thanks!

At this time it is a limitation of the new javascript. @asm89 is looking into it in issue #138

Right, thanks for that quick answer. Is there a way to disable ajax and refresh the page instead, then ?


Include kbld for arm64 with darwin and linux

Refs #16

I'm not sure how but this looks like it was done separately in https://github.com/vmware-tanzu/homebrew-carvel/commit/0bd8c3f2b654d6325dfded9218647e5f9c92d619


Click on tab causes a full page paint

Description
A clear and concise description of what the bug is.
Steps to Reproduce

Go to a market page
Click on trades tab
Note that the page sometimes fully paints

Expected behavior
No page blink
Screenshots
If applicable, add screenshots to help explain your problem.
Device details
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Old and dead


Heterogeneous cluster nodes support for GKE cluster profiles

[x] Create GKE Profile
[x] Update GKE Profile
[x] Get GKE Profile

closed by #396


M58

The M58 branch was cut: https://groups.google.com/forum/#!topic/discuss-webrtc/13BE3fbHcLU
~This PR adds support for it. (iOS only for now).~
~There seems to be a build issue, so if you try to make your own build using the provided script you may run into https://groups.google.com/forum/#!topic/discuss-webrtc/rB-ntaaGXDA~
TODO

~iOS: test RTCMTLVideoView, which is based on Metal~ (not all necessary commits are in M58)
[x] Android: make an actual build

Both iOS and Android builds are up for testing now.

I switched our SurfaceViewRenderer to the builtin one, which got refactored and now handles many things we used to do manually. That means we get to delete ~1000 likes of code!
I'm still testing everything works as before, but so far so good!

@saghul, I merged https://github.com/oney/react-native-webrtc/pull/249/commits/86ed1abb963114269f523778b9be34b0211a372c (i.e. the first four commits of this PR) into jitsi/react-native-webrtc's master so that we can start testing 58 at least internally and see how it works. Technically, I did a rebase of this PR on top of oney/react-native-webrtc's master today so that hashes aren't the same but I didn't modify the commit's patches in any way.

@lyubomir Thanks for taking a look! I'm not sure what happened there, I did test the code but I now wonder if somehow managed to make some of the changes after :-S

@lyubomir I'm not sure what the hell I did with the last commit, onLayout was also missing 😮 At any rate, I tested it now and fixed those issues, PTAL.

On the subject of merging 58 into master, should we be mindful of the crashes that 58 introduced on both desktop and mobile?

@lyubomir The patch for those is already available apparently so I'm making new builds including that one. For reference: https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!topic/discuss-webrtc/pfwS9eeS23c

Updated the iOS and Android builds including the fix for issue 679306, currently under embargo.

I've merged the first 3 commits in jitsi/react-native-webrtc which bring WebRTC 58 w/o the second 3 which remove source code on Android so that we can prepare internal builds for testing and gather more experience with how the latest WebRTC 58 builds perform.

@lyubomir Sounds good. Let's battle test 58 alone, I'll then focus on getting the Android renderer back in shape.

have not test m58 yet.  and then  m59 comes.

I removed the last 3 commits. I'll make a follow up PR after this one lands (after addressing your feedback).

Both Android and iOS are crashing just like desktop. From my perspective, it's not worth it for jitsi/jitsi-meet to continue with WebRTC 58 until either jitsi/jitsi-videobridge manages to completely prevent the crashes or, most likely, Google fixes the causes of the crashes. People utilizing react-native-webrtc for audio and video (without video simulcast and video stream rewriting) may want to test this PR if it gives them a kick forward such as not experiencing crashes caused by videos with odd resolutions and have it merged in master if it is stable for them.

@lyubomir Updated the commit logs with the exact commit info that I made the builds from.
So, I given we are not very happy with the quality in M58, so I'd propose the following:

land this PR on master
DON'T make a release
those who want to test master are free to do so, in the meantime I'll make M59 builds and follow the bugtracker, looks like all crashes are gone in Canary (now 60), so maybe they'll backport some of the fixes

This way it's easier to iterate on WebRTC builds since the deltas will be smaller.

@saghul
how about release a 1.57.1 and publish to npm on current master,
then land this to master and pre-release a 1.58.0 without publish to npm?

@zxcpoiu That sounds good to me. Can you make the 1.57.1 release? I'll discuss with @lyubomir merging this afterwards.


HDDS-4615. Update bouncycastle to 1.67

What changes were proposed in this pull request?
The latest bouncy castle contains important fixes. Ozone is not affected by the bcrypt issue, but it seems to be safer updating to the latest version.
(Thanks to @anuengineer  how reported this issue)
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4615
How was this patch tested?
CI + checked if we have the right version:
cd hadoop-ozone/dist/target/ozone-1.1.0-SNAPSHOT/share/ozone/lib
ls bc*

just for knowledge, why maven-shade plugin also needs to be upgraded for bouncycastle

just for knowledge, why maven-shade plugin also needs to be upgraded for bouncycastle

To fix:
Error:  Failed to execute goal org.apache.maven.plugins:maven-shade-plugin:3.2.0:shade (default) on project hadoop-ozone-filesystem-shaded: Error creating shaded jar: Problem shading JAR /home/runner/.m2/repository/org/bouncycastle/bcprov-jdk15on/1.67/bcprov-jdk15on-1.67.jar entry META-INF/versions/11/org/bouncycastle/jcajce/provider/asymmetric/edec/KeyAgreementSpi$X448.class: org.apache.maven.plugin.MojoExecutionException: Error in ASM processing class META-INF/versions/11/org/bouncycastle/jcajce/provider/asymmetric/edec/KeyAgreementSpi$X448.class: UnsupportedOperationException -> [Help 1]

Similar to HADOOP-15937.


implements $CDPATH

cd will search all directories listed in CDPATH and jump to the first directory it finds in the order listed. The default setting is CDPATH=. which results in cd only searching the current working directory.
Added $HOME path to enhance cd enabling the ability to jump directly to any directory below the current directory, as well as the home directory.

Setting CDPATH is one of the most useful things in my entire dot files setup. 👍 for raising the visibility of this env var!

That did not really explain it for me compared to Bash's manpage. And you have a syntax error on that line with the single quote at the end.


Create Redux store for pages: Animal list and Favourites

Pages Animal list and Favourites are connected. In both pages user can toggle favourite property of Animal Card.
If this has been done for certain animals successive things must happen:

Animal needs an updated prop of favourite on the Animal list page.
Animal stays or is removed from the list of Favourite animals page.
(in the future) Animal is or is not viewed in the recent Favourites widget on the Home page.

Graphql does not allow easily maintain and update dependent queries in the application. The list contents in Favourites and the deep property of each animal.
Animal list (type Animals[]) and Favourites (Animals[]) should be stored and manipulated through a Redux store.
Any favourite toggle should immediately change store for all the App. And the relevant mutations should be made to the backend from the Redux. Redux must keep in sync with the backend.
Be aware of the Animal list filtering and pagination features that will need to work with Redux.
Other App data is not in this task scope.
After this task is implemented other cache context solutions should be removed.

When implementing this dynamic App state management solution via Redux, maybe we should not merge favourite property into Animal structure, instead just use it from the Favourites list. So AnimalCard (or one that has favourite toggle) would directly use data from Redux Favourites scope and would not be dependent on the current Animal data itself.

one additional suggestion use websockets for updating asyncs update.


Release 2.9.0 experiences file locking of pending chocolatey file

Not sure what's changed in release 2.9.0 but my builds are now broken. First of all I wasn't getting Boxstarter.common. I expect that was due to Chocolatey not having yet received the package. Now all packages from Boxstarter are installing but the packages I'm installing after are failing. I've attached the package.ps1 I'm using.
The package (called install.txt) has;
$Boxstarter.RebootOk=$true # Allow reboots
$Boxstarter.AutoLogin=$true # Save my password securely and auto-login after a reboot
Write-BoxstarterMessage "Installing Windows Updates"
Install-WindowsUpdate -AcceptEula
choco feature enable -n=allowGlobalConfirmation
cinst googlechrome
cinst backinfo -s A:
cinst notepadplusplus
cinst 7zip
choco feature disable -n=allowGlobalConfirmation
if(Test-PendingReboot){ Invoke-Reboot }
package.ps1.txt

2.9.0 just released a couple hours ago. The main change is the embedded chocolatey which was extremely old has been updated to the latest 0.10.4 beta. Can you be more specific about what has broken and include the boxstarter log file located at $env:LocalAppData\boxstarter\boxstarter.log?

It seems what breaks is the boxstarter_temp package build. This results in none of the packages above being installed, nor the Install-WindowsUpdate working. The log says chocolatey is having some sort of file locking or file access issue?
boxstarter.log.txt

I'm also not able to use boxstarter, but I'm experiencing this through ClickOnce (WebLaunch).
Can this issues be related? I'm trying to find some logs of the ClickOnce deployment, but I wasn't successful so far.

do you mind opening up a separate issue @flaviocdc specific to your error and include what browser you are using? I'll rename this issue to make it clearer.
Also note that I just released 2.9.2 to address #238

Any progress on figuring out what's happening here?

not yet. There were a couple other lower hanging bugs I needed to identify first. Hoping to get to this one tonight.

ok I see what is happening here. Before installing a package, Chocolatey attempts to clean any files from "pending" package instralls (it did not do this in the version of chocolatey boxstarter used to embed). Because you have nested boxstarter packages - a package invoked with boxstarter that in turn invokes boxstarter again. Because both invocations generate a package from a script, they both create a package with the same name temp_boxstarterpackage. The second (inner) invocation fails because chocolatey has a lock on the package currently running.
I am fixing this by creating the on the fly packages with a random package name so that the nested invocations will generate different directories and eliminate contention.
I will release the fix along with a new beta version of chocolatey soon to be released that fixes another bug.
In the meantime, you can work around this by not calling Install-BoxstarterPackage inside the first boxstarter script and instead just directly execute that script.

just released this fix in 2.9.5


Automated cherry pick of #6462: region: fix server create params not include specified resource

Cherry pick of #6462 on release/2.13.
#6462: region: fix server create params not include specified resource

Codecov Report

Merging #6467 into release/2.13 will increase coverage by 0.00%.
The diff coverage is 1.75%.

@@             Coverage Diff              @@
##           release/2.13   #6467   +/-   ##
============================================
  Coverage          6.85%   6.85%
============================================
  Files               536     536
  Lines             90596   90622   +26
============================================
+ Hits               6213    6215    +2
- Misses            83874   83899   +25
+ Partials            509     508    -1

Flag
Coverage Δ

#aFlag
6.85% <1.75%> (+<0.01%)
:arrow_up:

Impacted Files
Coverage Δ

pkg/cloudcommon/db/tenantcache.go
1.31% <0.00%> (ø)

pkg/compute/models/cloudaccounts.go
0.80% <0.00%> (ø)

pkg/compute/models/guest_actions.go
0.00% <0.00%> (ø)

pkg/compute/models/guests.go
0.56% <0.00%> (-0.01%)
:arrow_down:

pkg/compute/models/hosts.go
0.33% <0.00%> (-0.01%)
:arrow_down:

pkg/hostman/guestfs/sshpart/sshpart.go
0.00% <0.00%> (ø)

pkg/keystone/tokens/verify.go
0.00% <0.00%> (ø)

pkg/multicloud/esxi/monitor.go
0.00% <0.00%> (ø)

pkg/util/gin/middleware/keystone_auth.go
0.00% <0.00%> (ø)

pkg/util/rbacutils/rbac.go
52.18% <33.33%> (-0.29%)
:arrow_down:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df4a901...d055f85. Read the comment docs.


Add --print-path option and README updates

Thank you for this great software, I was looking for a tool like this one since some weeks ago.
I used it today and I missed some details to understand how it works. So I updated README and added a command line option to print signatures folder.
Hope this looks okay to you. Tell me !
Thanks again !

@brunetton I came up with a different solution that requires no extra options. Essentially, the help text and error messages are customized to explain the situation on your particular system. Check my branch dev and let me know wha you think.

@brunetton PR rejected since the solution I mentioned above is now merged. Feel free to open an issue if you are not satisfied.


Refactor core to use a plugin architecture

Split readme-md-generator into multiple packages ang manage them with yarn workspaces. Each question would be a plugin that you can easily register.

+1. It would be great if users could select which plugins/questions to include, or could easily create their own plugins (questions), and use them.
 I use my own template, which is just the default template including the badges. Most of the badges need just username and repo name, so those are fine as those variables are already available in to the template.
But e.g. CodeClimate has a custom ID to fetch the correct badge. So I'd like to add a question that asks for the CodeClimate badge ID, so I could use that variable in the template.
For badges especially, the plugin architecture would be very useful as the number of different badges and their providers can change relatively fast, so it would be better if it could be managed by the community rather than the core package.

I'd also like to link to a CHANGELOG.md from README. So I'd also like to add a question that asks me about the URL to the CHANGELOG, so I could, again, sue that link in the template.


storage: add missing return for unsafeAddWatching

/cc @gyuho @jonboulle @eyakubovich

Ah I totally missed this part. LGTM. Thanks for fixing.

@gyuho No problem

@gyuho It would be great if you can write a test to cover this case.

@xiang90 Sure, I will write test cases that could have been missed without this fix (in a separate PR).


replace Collection protocol with Symbol.iterator based Iterable protocol

We've drastically expanded the features of coil, while shrinking the runtime & complexity.

💅


Zoom out with mouse issue

Hello.
In my app i try to zoom in and out as in your demo, but i could only encrease my image: decrease i could not. I use angularJS, but this didn't mind: i'v created plunker without angularJS logic.
http://plnkr.co/edit/aeKdQZ8fmAh4UwsQtdRU?p=preview (use wheel, also you could try to use links)
<script>   $(document).ready(function() {     $('.myimg').cropper();   }); </script>
could you please take a look? why i could not get my image smaller, only bigger with mouse scroll?
thank you

hello.... please reply...

@kotmatpockuh Keep in my this is an open-source project and peope do this for free. I don’t understand your issue. What do you mean by you can’t make the image smaller, only bigger? This library is for cropping images - that means cutting out a part of an image. It provides zooming in on the image. It doesn’t include zooming out (which doesn’t make much sense) if that is what you mean.

If you just mean zooming out:
you’re using an older version of cropper: http://plnkr.co/edit/ea4r9mNfW18wiEF81Hle?p=preview
Please close the issue or explain in more detail what your issue is.

great, thank you

@hacfi one last question: could i somehow set background color of zoomed out image not to transparent, but let's say to #cecece ?

@kotmatpockuh http://plnkr.co/edit/ea4r9mNfW18wiEF81Hle?p=preview You should learn how to use the Chrome Developer Toolbar or Firebug if you use Firefox.
.cropper-modal {
  background: #cecece;
}

but your styles have to be AFTER cropper.css

@hacfi before i tried that, but result cropped image was with cropper default background... will think deeper....

Are you sure that zoom out works in 0.9.1 version?

Just disable the strict mode.

@fengyuanchen it is not a solution...


Controlstyle = .none doesn't work

I have used this code to play a video but I don't want to show player control so I must set controlStyle to none. Unlucky it still does't work. I don't know why it appear.
Note*. I tested it with iOS 10
self.videoPlayer = XCDYouTubeVideoPlayerViewController.init(videoIdentifier: "Video_Id")
self.videoPlayer.moviePlayer.allowsAirPlay = false
self.videoPlayer.moviePlayer.controlStyle = .none
self.videoPlayer.moviePlayer.scalingMode = .aspectFill
self.videoPlayer.moviePlayer.shouldAutoplay = true
self.videoPlayer.moviePlayer.prepareToPlay()
self.videoPlayer.present(in: self.playerView)

Try to subclass the XCDYouTubeVideoPlayerViewController, and then override viewWillAppear method and put your code in it.


[Loading] - loading Class Won't Work with Input tag

Loading Class is not working inside input tags.

Hi, please provide a test case as per our contributing guidelines; you can fork this JSFiddle.

Closing the issue until there’s a test case.

Affirming this issue.  Test case here.  Requesting this issue be reopened.

@DanAtShenTech Thank you.
The .loading uses ::before to show the animation, and input elements themselves can’t contain pseudo-elements. Perhaps the input component can be extended to include the case:

  <input type="submit" value="Save">

To at least support

    <input type="submit" value="Save"/>

you should add
.ui.button > input {
  background:none;
  border:none;
  padding:0;
  margin:0;
}
.ui.loading.button > input {
  visibility: hidden;
}

https://jsfiddle.net/co8jrpao/20/
Infact much more would be needed to fully support every kind of ui.button using input tags nested in divs (especially colors), so i highly suggest to prevent this hack and simply use <button> for buttons in general as designed by the framework and everything works out of the box


Does the tool support per-cpu array / maps?

looking at this it seems like reading and processing values from per-cpu arrays/maps are not supported. Can you please confirm if this is correct?
if they are indeed not supported, was it a design decision to not consider per-cpu maps?

Thanks @bobrik
collected data from functions like netif_receive_skb requires that we use per cpu counters so that we dont run into race conditions. I wish we could export this as per-cpu metric... Also, the intention is to track "microburst"s so another problem I'm running into is tracking max per "x" millisecond values over a scrape interval.
Please let me know if you have a solution in mind.

It seems like there are two use-cases:

Collect a metric per cpu and export it per cpu.
Collect a metric per cpu, but  export it as a combined counter.

It sounds like you want the former. I can see some people wanting the latter, so we should probably support both.

Also, the intention is to track "microburst"s so another problem I'm running into is tracking max per "x" millisecond values over a scrape interval.
Please let me know if you have a solution in mind.

This sounds like an interesting non-trivial example we might want to have in the repo. I don't have a solution for this off the top of my head, but please file a separate issue for this. If you already have a non-ebpf_exporter based solution, it would be good to attach it there for a reference.

Thanks for the response @bobrik , will get back

Please take a look at #226 for per cpu map support.

thanks @bobrik ! will check


Receive error when trying to use GAM

The issue tracker is for reporting product deficiencies. "How do I?" questions should be posted to the discussion forum at https://groups.google.com/group/google-apps-manager. When in doubt, start at the discussion forum and return here only when instructed to do so.
Please confirm the following:
[x] I have upgraded to the latest GAM release from https://git.io/gamreleases and I still have this issue.
[x] I am typing the command as described in the GAM Wiki at https://github.com/jay0lee/gam/wiki
Full steps to reproduce the issue:

Install GAM
Go through oauth creation process
Receive error code

Expected outcome (what are you trying to do?):
To output results of
gam info domain
Actual outcome (what errors or bad behavior do you see instead?):
>gam info domain
C:\Users\user\AppData\Local\Temp\_MEI78~1\oauth2client\_helpers.py:255: UserWarning: Cannot access C:\Program Files\GAM\oauth2.txt: No such file or directory

What is your G Suite admin email address? Traceback (most recent call last):
  File "gam.py", line 12144, in <module>
  File "gam.py", line 11538, in ProcessGAMCommand
  File "gam.py", line 1557, in doGetDomainInfo
  File "gam.py", line 1579, in doGetCustomerInfo
  File "gam.py", line 848, in buildGAPIObject
  File "gam.py", line 11147, in doRequestOAuth
  File "gam.py", line 6825, in getValidateLoginHint
EOFError
Failed to execute script gam

Output of dir on C:\Program Files\GAM\
2017-09-19  22:57               553 client_secrets.json
2016-11-04  12:04             2 405 gam-setup.bat
2017-08-13  20:37         7 221 523 gam.exe
2017-08-13  20:31            45 867 gamcommands.txt
2017-09-19  22:37                10 lastupdatecheck.txt
2016-09-17  14:49            26 399 LICENSE
2017-09-19  22:55             2 377 oauth2service.json
2017-08-13  20:31            37 444 whatsnew.txt

When it prompts with:
What is your G Suite admin email address?
are you typing anything?

Yes, typing my email, and creating the project within Google Cloud Console.

You need to do this: gam oauth create

yes... as mentioned I did that. yet that is not completing the process correctly. it isnt saving the file that is erroring. there for, i cant actually run any commands. i am not a firat time user of GAM. but this is rending me to a point where i am unable to use it with any troubleshootingsteps  .
sorry for mispellings. typed on a phone without auto correct

What happens when you do gam oauth create?
How much of the process completes, what messages do you get?

i can complete the entire process of the gam oauth create, go through the full process and all instructions through Google Apps/cloud console, Ot says that the authentication flow has completed and i go throgh the the steps witg cmd hitting enter after delegating to the entire domain.
after completong the oauth2 workflow and typijg gam info domain it then prompts me to go through the whole process againthe folder is writeable by my user as well.
sorry misppellings are worse. still om phonr without auto correct amd getting tossed around by a train.

Correct. The folder is writeable and i can create a file. i am also running cmd witth elevated privs when this occurs. so permissions shouldnt be an issue.

Did you ever figure this out, because I'm having the same issue?

Claude,
Please describe your situation more completely?
What platform are you on?
In this a new installation or an upgrade?
What steps have you performed?
What step is failing?
Ross
On Tue, Sep 26, 2017 at 11:05 AM, claudemorings<EMAIL_ADDRESS>wrote:

Did you ever figure this out, because I'm having the same issue?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/jay0lee/GAM/issues/596#issuecomment-332284784, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AIU8LynBM_uOz0LH2OmeQF-d30of_Lvwks5smTzGgaJpZM4PeD6W
.

--
Ross Scroggs
<EMAIL_ADDRESS>

Hi,
gam info domain
The above GAM command is displaying 4 days old information.
Is there any way that we can pull the details with current date.
We need to schedule a daily report with the total number of licenses and consumed licenses from Gsuite business.


Change package name, fix bug when text input are empty

this fixes #42

I can see, how about register?

oops, I just fixed too.

Thanks  👍

Hey @MaherSoua  I think look at this line ,
remote: Counting objects: 31, done.
remote: Compressing objects: 100% (16/16), done.
remote: Total 31 (delta 11), reused 27 (delta 10), pack-reused 0
Unpacking objects: 100% (31/31), done.
From https://github.com/Madonahs/GrowWithGoogleTeamProject
   7645533..af9a755  develop             -> origin/develop
 * [new branch]      firebase-connection -> origin/firebase-connection
Updating 2cf2c16..af9a755
Fast-forward
 app/google-services.json                           | 55 ----------------------
 .../{database => login}/AppLoginManager.java       |  3 +-
 .../ui/LoginActivity.java                          |  2 +-
 .../ui/fragment/LoginFragment.java                 | 13 ++---

The removal of json will surely make anyone not access the branch 👍  we can try gitignore, we can have a nice session on gitignore 👍 .


new issue

Description
What steps will reproduce the problem?

What is the expected output? What do you see instead?
Please provide any additional information below
File "C:\Users\vercheng\AppData\Local\Continuum\Anaconda3\lib\site-packages\spyder\utils\introspection\manager.py", line 220, in get_completions
info = self._get_code_info('completions', automatic=automatic)
File "C:\Users\vercheng\AppData\Local\Continuum\Anaconda3\lib\site-packages\spyder\utils\introspection\manager.py", line 216, in _get_code_info
**kwargs)
File "C:\Users\vercheng\AppData\Local\Continuum\Anaconda3\lib\site-packages\spyder\utils\introspection\utils.py", line 75, in init
self._get_info()
File "C:\Users\vercheng\AppData\Local\Continuum\Anaconda3\lib\site-packages\spyder\utils\introspection\utils.py", line 87, in get_info
lexer = find_lexer_for_filename(self.filename)
File "C:\Users\vercheng\AppData\Local\Continuum\Anaconda3\lib\site-packages\spyder\utils\introspection\utils.py", line 180, in find_lexer_for_filename
lexer = get_lexer_for_filename(filename)
File "C:\Users\vercheng\AppData\Local\Continuum\Anaconda3\lib\site-packages\pygments\lexers_init.py", line 203, in get_lexer_for_filename
res = find_lexer_class_for_filename(fn, code)
File "C:\Users\vercheng\AppData\Local\Continuum\Anaconda3\lib\site-packages\pygments\lexers_init.py", line 168, in find_lexer_class_for_filename

Your error is incomplete. Please copy the entire error from the error dialog and paste it again.

Closing because of lack of response.


Dropdown menu - visible

I am using Bootstrap 4, with a full width drop down menu. I would like the drop down menu to be visible when you are on a page so for example if you are on the about us page the drop down for about us is visible but the drop down for the other menu items still work and change when you hover over them. Please help.

Add the .show class to the dropdown-menu.
<div class="dropdown-menu show">

Please use Stack Overflow for asking questions regarding implementation:
https://stackoverflow.com/questions/tagged/bootstrap-4

So simple, thank you.
Kind Regards
Larraine

http://www.mercerdesign.co.uk/
Larraine Lawrence-Greenwood<EMAIL_ADDRESS>•  Senior Designer
Mercer Design, The Cow Byre, Woodlands End, Mells, Somerset BA11 3PE
T: +44 (0)1373 812589
  • www.mercerdesign.co.uk http://www.mercerdesign.co.uk/

On 15 Mar 2018, at 17:40, razh<EMAIL_ADDRESS>wrote:
Add the .show class to the dropdown-menu.

Please use Stack Overflow for asking questions regarding implementation:
https://stackoverflow.com/questions/tagged/bootstrap-4 https://stackoverflow.com/questions/tagged/bootstrap-4
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/twbs/bootstrap/issues/25863#issuecomment-373461814, or mute the thread https://github.com/notifications/unsubscribe-auth/AQ9hIXTJx0LktohhKccH-Jr4803nyJD8ks5teqeUgaJpZM4SskPY.

Sorry, but we cannot help with how-to or general troubleshooting issues here; only bug reports and feature requests. You'll want to ask around in the official Slack team or Stack Overflow. See our readme for more details.