Expose ERSPAN_III flags in testutils functions

At this moment, functions ipv4_erspan_pkt and ipv4_erspan_platform_pkt in testutils do not expose flag fields of ERSPAN_III: p, ft, hw, d, gra and o.
This PR adds to these functions arguments for these flags, keeping backward compatibility with sgt_other field.

Ok, I thought that in PTF sgt_other was treated like in former scapy-vxlan repository, not like in present Scapy. If that is not the case, then just ignore that part about backward compatibility.

@antoninbas are we ready to merge it?

@sborkows any chance you can get an additional review from someone @ Intel?

@sborkows your change corrects a badly implemented ERSPAN package from scapy-vxlan?
Difference between scapies:
Scapy 2.4.5: https://github.com/secdev/scapy/blob/f43c697ebeb287cbcc04abf8de416938ca507687/scapy/layers/l2.py#L441
Scapy-vxlan: https://github.com/p4lang/scapy-vxlan/blob/2ee0a8b89222b407d446c332a64812f2ca1a1c22/scapy/contrib/erspan.py

@NexSabre it seems so, like a side-effect. The most important is that it will enable setting these flags after sgt_other field in PTF.

@saynb @slicking would you mind looking at this PR?


LCC examples for Studio Classic space

Issue #, if available:
Internal summary present
Description of changes:

using pip3 to install python packages
Using mamba to install conda packages using conda forge

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Hello Team any updates on merging the pull requests!

Hi @aswathsr101 Can you update the readme too accordingly? LGTM otherwise, will merge once you've updated it.

@durgasury  changed the Readme also accordingly


ZFS pool creation and Addition Breaking on Alpine Linux

Required information

Distribution: Alpine Linux
Distribution version: edge
The output of "lxc info" or if that fails:

Kernel version: Linux builder 4.9.58-0-hardened
LXC version: 2.1.0
LXD version: 2.19
Storage backend in use: zfs 0.7.3

Issue description
When I run lxd init I'm getting the error
error: cannot open '-H': dataset does not exist

Seems like lxd is issuing command in the wrong order, if I issue the command in the shell manually everything works but when i try the command from here:
https://github.com/lxc/lxd/blob/693df2ceddd3287ff1d5bcefea848259899f8151/lxd/storage_zfs_utils.go
Steps to reproduce

Setup LXD and ZFS on alpine
run lxd init
Go through the interactive shell

@zacksiri, what is the exact command?

When I run lxd init it ask me for the name of the pool I type the name of the pool and at the end of the init I get the above error

What's the name of the pool you're giving? And what did you mean by

f I issue the command in the shell manually everything works but when i try the command from here

If I do
zpool create -f -o ashift=12 lxd /dev/vdb

Zfs pool created, with the name lxd, I then pass this pool called lxd into the init process and I get the error.
If I let lxd create the pool by passing the block device (ie I don’t create the pool I just pass /dev/vdb) i also get an error.

Can you try zpool create lxd /dev/vdb  -f -o ashift=12

@brauner anything I can do to help resolving this one?

I'll take this one.

Looks like only the zpool command is imported, so the fix is pretty simple.
I got a clean test run on a system that I manually upgraded to the latest zfs.


Add setup of application using docker

In order to make it easy to setup the application for development, this
commit adds the necessary files. Since docker-compose can make use of an
.env file when creating a container, this commit adds an env.example
file that can be used to create the .env file. A script/bootstrap file
was added to script the process of setting up the application.
This commit updates the README.md file to better understand how to get
started.

I believe the etiquette is to comment on a PR in flight if you have design differences rather than attempting to supersede it. A lot of work is reproduced here while tightly coupling this app to docker-compose.

@philipmckenna I had no ill intent with my pull request, I didn't see your pull request until after I already submitted mine. For that I apologize as everything was still cached on my machine and didn't get refreshed until I submitted my pull request.

Ah fair enough, with that explained then I do not see need for you to close your PR. The actual meat of each of our PR's offer slightly different solutions to the db seed. The owner may find that your solution suits his needs better. Also I have very little php experience but I would love to see someone suggest a way to pass these db configurations around rather than constantly repeating the declaration, while also allowing the owner to run it in the way he was previously, deprecation of his functionality should be up to him or whoever decides to take on the issue separately from this.


Go through TODOs

Originally submitted to Google Code by @pekkaklarck on 13 Nov 2010

I've added some TODOs to the code base recently for places that might need cleanup. This is a reminder to go through all of them(and FIXMEs etc. if they are used).

Originally submitted to Google Code by @yanne on 15 Nov 2010

There are no more TODOs in the code.


ARROW-4684: [Python] Debug Cython test failure

The reason why the test failed is -fno-plt option is not supported by gcc version 5.
Upgrading gcc can resolve this issue.

I wonder why -fno-plt is getting introduced suddenly. We can resolve the issue by using the gcc_linux-64 and gxx_linux-64 compiler toolchain packages. But then we aren't using gcc 5.4

@msarahan

@pitrou is there a reason why you pinged me here?  I don't see the ping anymore - just in my email.  Is there a reason why you're sticking with gcc 5.4?  That seems like a strange middle-ground between manylinux standard practice and completely modern.  Is there something about newer gcc that doesn't work as well for you?

@pitrou I'm fixing this in my CMake refactor. There I plan to have a pure toolchain build and a pure Ubuntu (read: no conda) build.

@msarahan That was about the -fno-plt issue but then I got an answer from the conda-forge gitter channel.
@xhochy Nice but I'd rather silence the errors in the meantime. CI failures are a nuisance.

Hmm, silencing the test_cython error wasn't enough. Then it fails installing pickle5:
https://travis-ci.org/apache/arrow/jobs/499285776#L4033
In any case, it seems it's going to be fixed in conda-forge:
https://gitter.im/conda-forge/conda-forge.github.io?at=5c769889608c6f373631487f

Jonathan J. Helmus
@jjhelmus
15:02
@pitrou The Python packages in defaults uses generic flags unless an environment variable is set by the compiler activation script. I'll look at porting that patch over to conda-forge.

@pitrou then I'd mark the build in the matrix as possible failure?

@fsaintjacques Right.

The underlying issue was solved in https://github.com/conda-forge/python-feedstock/pull/249, closing.


How to concat mxnet::cpp::NDArray?

What is the best way to concat mxnet::cpp::NDArray?
I have a std::vectormxnet::cpp::NDArray and context is gpu.
How can I merge them and get new NDArray?

Concat() in op.h

This issue is closed due to lack of activity in the last 90 days. Feel free to reopen if this is still an active issue. Thanks!


discover tab in different languages

I know there is very few to translate in the tools of this section, but it's still important to do I think, is there anything to do to help on this? I couldn't find it in the fr or es.yml file

Part of the difficulty of translating the user & leaderboard pages is that they aren't made in jekyll as the main site is, so the translation code would have to be written differently.
They're both built with React, so adding the translation would require a decent lift in reformatting their structure to account for the language variables and adjusted url.

@DylanMoriarty sorry for my very late answer on this... what if we give the translation to developpers who include it directly? (instead of changing the whole code)... Not an hurry ...


Pasting images doesn't work

Hi,
Stumbled upon this app, looked good so I gave it a try.
So far it all works really nicely aside from one caveat: I can't paste images in chat. Usually I can copy and paste any image (Or ctrl+cmd+shift+4 to screenshot and copy) into the chat, using the official messenger.com, but this doesn't seem to work with the app.
Hope this isn't too much of a hassle to fix !
Cheers,
Mark

Duplicate of #109. I am waiting for this fix as well!

dupe see #109


validate:required is not validating for default value

Package version eg. v8, v9:
v9
Issue, Question or Enhancement:
validate:required is not validating for default value. i.e. in below example Name in employee struct in set to "" (Default Value).
Here I am expecting the result as validation error for Name field
Code sample, to showcase or reproduce:
package main

import (
	"fmt"
	"gopkg.in/go-playground/validator.v9"
	"time"
)

type Employee struct {
	Name string `validate:required`
	Age int32	`validate:required`
	DOB	time.Time	`validate:required`
	Address struct{}
}

var validate *validator.Validate

func main()  {

	var emp Employee
	validate = validator.New()

	err := validate.Struct(emp)
	if err != nil {
		fmt.Println("Error Occured", err)
	} else {
		fmt.Println("Validation Successful")
	}

}

Hey @payuprashantg it looks like your tag syntax is incorrect and missing the double quotes eg.
`validate:"required"` vs `validate:required`

please let me know if that solves it :)

Thanks @joeybloggs ,
Its working fine now.


Error in mounted hook: "TypeError: Failed to execute 'appendChild' on 'Node': parameter 1 is not of type 'Node'.

Hi dears
First of all sorry for my bad English. I trying to set options. But when I try to set options, it gives me below error.
Error in mounted hook: "TypeError: Failed to execute 'appendChild' on 'Node': parameter 1 is not of type 'Node'.

@bilguun87
Please explain the issue clearly according to our issue template.
There's nothing that can be solved with your information now.

Hi,
Just for additional info, I have the exact same problem after upgrading from https://www.npmjs.com/package/@toast-ui/vue-editor from 3.1.1 to 2.5.4 (yes, according to npm it's an upgrade...).
If I comment out the toolbarItems, it works correctly, so I'm guessing the problem comes from there.
It doesn't matter what I have set in the option, as long as I have a toolbarItems property it crashes.
        toolbarItems: [
          ['heading', 'bold', 'italic', 'strike'],
          ['hr', 'quote'],
          ['ul', 'ol', 'task'],
          ['table', 'image', 'link'],
          ['code', 'codeblock'],
        ],

The example seems to be outdated. Typings for toolbar items suggest that it's an array of strings, not an array of arrays. For example, this works:
    toolbarItems: [
        'heading',
        'bold',
        'italic',
        'strike',
        'divider',
        'hr',
        'quote'
    ]


Improve debug logs

Currently we're outputting too much logs. We should only mark successful scrapes as a whole (doctors, clinical officers, etc) instead of pages.
Other logs would be failed scrapes which should be returned as errors instead of normal print.

FIXED.

@DavidLemayian this issue should be closed? yes? no?


Provide instructions or link for instructions to obtaining Client ID and Key.

Provide instructions or link for instructions to obtaining Client ID and Key.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e9757ffa-ccdb-e9f3-3f74-6f147dd04066
Version Independent ID: 15b5e687-f04d-d893-81fe-8fc86b63fe2d
Content: Packaging MSIX apps - MSIX
Content Source: msix-src/package/packaging-uwp-apps.md
Product: msix
GitHub Login: @dianmsft
Microsoft Alias: diahar

Hi @enqui we have instructions to obtain Client ID and Key here: https://docs.microsoft.com/en-us/windows/msix/package/packaging-uwp-apps#automate-store-submissions
Instructions are as follows:
Go to the Partner Center dashboard and sign in with your Azure AD credentials.
On the Partner Center dashboard, select the gear icon (near the upper right corner of the dashboard) and then select Developer settings.
In the Settings menu in the left pane, click Users.
Click the name of your Azure AD application to go to the application's settings. On this page, copy the Tenant ID and Client ID values.
In the Keys section, click Add new key. On the next screen, copy the Key value, which corresponds to the client secret. You will not be able to access this info again after you leave this page, so make sure to not lose it. For more information, see Manage keys for an Azure AD application.
let us know if this is not enough and additional information is needed


[Editor] Can edit multiple selected entities

New property system is required to support this feature.

Implemented in v0.3.0


Addressing 1:1 Dependency Between MCO and Butane

This issue intends to investigate and discuss the 1:1 dependency between MCO and Butane. The objective is to understand this dependency and explore the possibility of untangling it to ensure a smoother release process.
However, if there is no immediate solution, we will take a few actions to prevent unplanned releases:

Incorporate GA release dates into coreos-packages Google agenda.
Set reminders in Slack as the GA release dates approach.

There is a 1:1 match between the openshift variants and openshift releases to let users us a spec version matching their openshift release at all times, without having them thinking about compatibility. A config written with the 4.15.0 spec should work on a 4.15.0 cluster, etc.


'al/createPackage' failed with error: 'Part URI cannot contain a Fragment component.'

Describe the bug
Package creation fails with the message Part Uri cannot contain a Fragment component.
To Reproduce
It happens when i try to create my TestApp (with 248) files and is dependent on a couple of other apps.
The package is created, but upon Publish i get again the same error.
Expected behavior
A package should be created without problems
Screenshots
[Error - 11:19:58] Please report this issue to https://github.com/microsoft/al/issues including information on how to reproduce it, if possible.
Processing of message 'al/createPackage' failed with error: 'Part URI cannot contain a Fragment component.'
Details:
System.ArgumentException: Part URI cannot contain a Fragment component.
at System.IO.Packaging.PackUriHelper.CreatePartUri(Uri partUri)
at Microsoft.Dynamics.Nav.CodeAnalysis.Packaging.PackageWriter.GetOrCreatePackagePart(String packagedPath) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Packaging\PackageWriter.cs:line 122
at Microsoft.Dynamics.Nav.CodeAnalysis.Packaging.PackageWriter.WriteBytes(Byte[] content, String path) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Packaging\PackageWriter.cs:line 73
at Microsoft.Dynamics.Nav.CodeAnalysis.Packaging.PackageModuleOutputterBase.AddVariousValidFilesStatic(IFileSystem fileSystem, DiagnosticBag diagnostics, HashSet1 writtenFiles, IPackageWriter writer, NavAppManifest manifest) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Packaging\PackageModuleOutputterBase.cs:line 262    at Microsoft.Dynamics.Nav.CodeAnalysis.Packaging.PackageModuleOutputterBase.AddVariousValidFiles(IFileSystem fileSystem, DiagnosticBag diagnostics, HashSet1 writtenFilesToPackage, IPackageWriter writer) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Packaging\PackageModuleOutputterBase.cs:line 358
at Microsoft.Dynamics.Nav.CodeAnalysis.Packaging.PackageModuleOutputterBase.FinalizeModule() in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Packaging\PackageModuleOutputterBase.cs:line 136
at Microsoft.Dynamics.Nav.CodeAnalysis.Packaging.PackageModuleOutputter.FinalizeModule() in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Packaging\PackageModuleOutputter.cs:line 30
at Microsoft.Dynamics.Nav.CodeAnalysis.Compilation.WriteToOutput(ModuleOutputter outputter, ModuleBuilder moduleBuilder, ModuleSymbol compiledModuleSymbol, DiagnosticBag diagnostics) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Compilation\Compilation.cs:line 893
at Microsoft.Dynamics.Nav.CodeAnalysis.CommandLine.CommonCompiler.PackageTheModule(Compilation compilation, CompilerTextWriter consoleOutput, CancellationToken cancellationToken, ErrorLogger errorLogger, AnalyzerDriver analyzerDriver, Predicate1 filterOpt, Predicate1 radCompilationFilter) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\CommandLine\CommonCompiler.cs:line 728
at Microsoft.Dynamics.Nav.CodeAnalysis.CommandLine.CommonCompiler.RunCoreImpl(CompilerTextWriter consoleOutput, ErrorLogger errorLogger, Compilation compilation, AnalyzerDriver analyzerDriver, IEnumerable1 analyzerExceptionDiagnostics, IEnumerable1 additionalTextFiles, CancellationToken cancellationToken) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\CommandLine\CommonCompiler.cs:line 529
at Microsoft.Dynamics.Nav.CodeAnalysis.CommandLine.CommonCompiler.RunCore(CompilerTextWriter consoleOutput, ErrorLogger errorLogger, CancellationToken cancellationToken) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\CommandLine\CommonCompiler.cs:line 476
at Microsoft.Dynamics.Nav.CodeAnalysis.CommandLine.CommonCompiler.Run(CompilerTextWriter consoleOutput, CancellationToken cancellationToken) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\CommandLine\CommonCompiler.cs:line 332
at Microsoft.Dynamics.Nav.EditorServices.Protocol.LanguageServer.Extensions.CreatePackageRequestHandler.Build(Project builtProject, StreamingTextWriter outputWriter, Boolean isRad, IList1 args, CancellationToken cancellationToken, Boolean forceBuild, PooledList1 outputFiles) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\LanguageServer\Extensions\CreatePackageRequestHandler.cs:line 173
at Microsoft.Dynamics.Nav.EditorServices.Protocol.LanguageServer.Extensions.CreatePackageRequestHandler.HandleAsync(CreatePackageRequest request, Int32 requestId, CancellationToken cancellationToken) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\LanguageServer\Extensions\CreatePackageRequestHandler.cs:line 102
at Microsoft.Dynamics.Nav.EditorServices.Protocol.MessageProtocol.RequestHandlerBase`1.HandleAsync(JToken requestContents, Int32 requestId, CancellationToken cancellationToken) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\MessageProtocol\RequestHandlerBase.cs:line 54
at Microsoft.Dynamics.Nav.EditorServices.Protocol.RequestRegistry.Process(Message message) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\Endpoints\RequestRegistry.cs:line 80
5. Versions:

AL Language: 5.0.288712

Business Central: NL Business Central 16.2 (platform 16.0.14073.14195 + toepassing 14.8.38650.0)

Can you provide us with a project that would reproduce the issue?

Yes, i can, but how? It is quite a project.

Can you try to remove some files from the projects to have a smaller one that still reproduces the issue?
From the stack trace, it does not seem related to the AL files, but it looks more like an issue when writing one of the followings: Reports layout, Table data, Migration file, Translations, Entitlements,  Web Services, or Permissions.
Can you try taking these out of your project and see whether creating the package succeeds? That would give us some better indication of where the issue is happening

Hello-World.zip
Hi i reproduced it with the attached project. It seems it is caused by the XML file with a # in the filename.

Thank you for the repro! I've marked this as a bug.


Externalize deprecated hints

This change is

Current dependencies on/for this PR:

main

PR #3016   👈

This comment was auto-generated by Graphite.


[Geo Sites] Mega Menu UI issue

Under the products section in the mega menu, the content of the last bullet point is extending beyond the section.

https://dede-hlxsites-moleculardevices.onelink-translations.com/
https://frfr-hlxsites-moleculardevices.onelink-translations.com/
https://eses-hlxsites-moleculardevices.onelink-translations.com/

@jose-correia The two cards should be of equal length, one card is longer than the other. Please fix

https://dede-hlxsites-moleculardevices.onelink-translations.com/
https://frfr-hlxsites-moleculardevices.onelink-translations.com/
https://eses-hlxsites-moleculardevices.onelink-translations.com/


Update documentation to describe all public functions / improve API doc

We should investigate if there is a way to generate an API doc automatically based on our doc strings.

We can use https://www.sphinx-doc.org/en/master/ and host the documentation on gh page.

I have explain here :  how to control many  Tahoma accesssories if it can help. Thank you again ! :-)


Logs Versioning not show all change when update by API

cc @chirag-madlani
Slack: https://openmetadata.slack.com/archives/C02B6955S4S/p1690968880274419
Affected module
Version control backend
Describe the bug
Sending update information through API for multiple columns (like update description) but after updated, new version only mark changed for the first column on the list.
To Reproduce
Screenshots or steps to reproduce
1/ send update request

2/ View the new version created

Expected behavior
Mark all change!
Version:

OS: [e.g. iOS]
Python version:
OpenMetadata version:  1.1
OpenMetadata Ingestion package version: [e.g. openmetadata-ingestion[docker]==XYZ]

Additional context
Add any other context about the problem here.

For tables, adding or updating a column with children does not display its children as added columns as well. Similar case for adding columns in containers and  schemaFields for topics
In the video below, column customer with children is deleted and customerUpdated with children is added to the table.
https://github.com/open-metadata/OpenMetadata/assets/51777795/819fec32-2953-40d3-8ec6-a0f5026f4a86


Update helpModal website link

The purpose of this task is to update the helpModal website link from EdgeSecure.co to Edge.App
Asana Task: https://app.asana.com/0/361770107085503/716460273877814/f

@swansontec Can I get a forced merge?


Less lines

Don't think this hurts readability all that much.
From 1000 sloc, we are now down to 981.

Nice!


Miri keeps on execution after literal out of range parser error

pub fn main() {
    println!("{}", 128_i8);
    println!("here");
}

andy@student-net-cx-3808 miri % ./miri run repro.rs
    Finished dev [optimized + debuginfo] target(s) in 0.08s
    Finished dev [optimized + debuginfo] target(s) in 0.04s
     Running `target/debug/cargo-miri miri setup --print-sysroot`
    Finished dev [optimized + debuginfo] target(s) in 0.02s
     Running `target/debug/miri repro.rs`
error: literal out of range for `i8`
 --> repro.rs:2:20
  |
2 |     println!("{}", 128_i8);
  |                    ^^^^^^
  |
  = note: the literal `128_i8` does not fit into the type `i8` whose range is `-128..=127`
  = help: consider using the type `u8` instead
  = note: `#[deny(overflowing_literals)]` on by default

-128
here

Don't think this is supposed to happen, also no UB is thrown.
Reproduced on the latest commit https://github.com/rust-lang/miri/commit/1dca4f56c3fc15856b33d07642a85951477eabc7

I guess we could look at whether there were any errors emitted before starting miri. Not pretty, but it would probably cover most cases.

I think this is the same issues as https://github.com/rust-lang/miri/issues/2608.

yea


Update to PyTrack V0.2

This PR introduces some major changes to PyTrack. The main goal is, to make it more userfriendly and useable in a pythonic manner. Therefore PyTrack was restructured to be applied as a decorator to your classes.
Important changes:

class inheritance was changed to a class decorator
self.parameters and self.results were removed in favor of custom Parameter() and Result() attributes
all pre or post method calls were removed
self.files was removed. From now on self.dvc should always point to the correct file.
Improvement of the documentation

The following code snippet shows an example of the new syntax
from pytrack import pytrack, Parameter, Result, DVCParams

@pytrack
class Stage:
    def __init__(self):
        """Class constructor

        Definition of parameters and results
        """
        self.dvc = DVCParams(outs=['calculation.txt'])

        self.n_1 = Parameter()
        self.n_2 = Parameter()

        self.sum = Result()
        self.dif = Result()

    def __call__(self, n_1, n_2):
        """User input

        Parameters
        ----------
        n_1: First number
        n_2: Second number
        """
        self.n_1 = n_1
        self.n_2 = n_2

    def run(self):
        """Actual computation"""
        self.sum = self.n_1 + self.n_2
        self.dif = self.n_1 - self.n_2

        self.dvc.outs[0].write_text(f"{self.n_1} + {self.n_2} = {self.sum}")

Notes
Because PyTrack now acts in form of a decorator, there are a lot of hidden class attributes, properties and functions.
To avoid any issues, they all follow the same naming convention as
  self._pytrack_<placeholder> # is considered a normal attribute
  self._pytrack__<placeholder> # is considered a hidden attribute

They will only be visible at runtime. Autocompletion in e.g., PyCharm is not available for these values and it should be avoided to access them in the child class. If you need them you are probably doing something wrong!
DevNotes
PyTrack development is still similar to writing a parent class and therefore is primarly written in pytrack.core.py_track
This should make it easy to maintain but comes with the drawback, that some common python regulations might be passed over. Suggestions are very welcome.

The tests work locally, there is an issue with git commit in the GitHub actions.
It could be fixed by adding subprocess.check_call(['git', 'config', '--global', 'user.name', 'pytest']) but that would mess up local setups, so I am thinking about an alternative.


checklist icon seems to be missing

I tried to use the checklist icon (listed on website here: https://material.io/resources/icons/?search=checklist&style=baseline), but I got an error instead. I checked for image data in the repo but I couldn't find it anywhere.

Sorry for slow response.
Update script automatically pulls latest icons from Google's website, but it is not ran too often, so sometimes there is a delay between new icons appearing on material.io and this repo. That icon has been added in one of updates this spring.


Add old update-config-docs.yml to deletedfiles policies

A docs sync action was triggered from 4-lts and is unwanted. This policy change adds update-config-docs.yml action to the deletedfiles definition.
It looks like SYSE-292 was commited but not applied for 4-LTS (yet?). I opened a PR removing the actions on 4-LTS and decided to update the policies if there are other target branches to clean up.
Via: https://github.com/TykTechnologies/tyk/pull/5931

Thanks for this. @ermirizio is still working on taming the -lts branches so it might be a while before this makes it there though.


Searching accessibility.voice.keywordActivation setting shows something else

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.86.0
OS Version:  Windows 10

Steps to Reproduce:

Search accessibility.voice.keywordActivation in settings
This is shown:

@Destroy666x do you have the vscode-speech extension installed?

I see, I didn't have Copilot.
Anyways, nottoo sure why the other settings shows up in results instead.


CFF file with special characters in yaml may cause trouble on Windows

For example, this error here https://github.com/citation-file-format/citation-file-format/actions/runs/842415993 was "fixed" by changing the key-complete CITATION.cff file used for testing in this commit: https://github.com/citation-file-format/citation-file-format/pull/136/commits/b9453f359aa470fe5eda748e6feb9d561e8a6a69

Hm, is this a "bug" in cffconvert perhaps, and could it be fixed by reading with UTF-8 as supplied char encoding?

Sounds plausible, thanks for making the issue

Should be fixed in https://github.com/citation-file-format/cff-converter-python/pull/154.

Closing as this is being tracked in https://github.com/citation-file-format/cff-converter-python/pull/154.
Please re-open if the above doesn't fix this.


Question: Restarting houndd with existing data without invoking Searchers?

I noticed that when I restart houndd is invokes all searchers first, and only when they finish, it starts to listen on port 6080.
Is it possible to have it start serving from the existing data folder,
and have the `Searchers' only update it later?
I am asking this because I want to configure hundreds of repos, and the Searchers may take a long time.

https://github.com/hound-search/hound/issues/214


[Bug Report]: NetworkPluginMode for AKS module is not a valid property.

Describe the bug
When deploying with "networkPluginMode" I get the following error:
`{"code":"InvalidTemplate","message":"Unable to process template language expressions for resource '/subscriptions/<SUB_ID>/resourceGroups/adminGroupObjectIDs'providers/Microsoft.ContainerService/managedClusters/aks-cluster' at line '1' and column '2539'. 'The language expression property 'networkPluginMode' doesn't exist, available properties are 'clusterName, identity, kubernetesVersion, networkPlugin, networkPolicy, serviceCidr, dnsServiceIP, outboundType, loadBalancerSku, sku_tier, enableRBAC, aadProfileManaged, adminGroupObjectIDs'.' (Code: InvalidTemplate)
To reproduce
The AKS module in my bicep looks as follows:

param aksClusterName string
param subnetId string
param adminUsername string = 'azureuser'

param aksSettings object = {
  kubernetesVersion: null
  identity: 'SystemAssigned'
  networkPlugin: 'azure'
  networkPluginMode: 'overlay'
  networkPolicy: 'calico'
  serviceCidr: '<IP_ADDRESS>/22' // Must be cidr not in use any where else across the Network (Azure or Peered/On-Prem).  Can safely be used in multiple clusters - presuming this range is not broadcast/advertised in route tables.
  dnsServiceIP: '<IP_ADDRESS>' // Ip Address for K8s DNS
  outboundType: 'UDR'
  loadBalancerSku: 'standard'
  sku_tier: 'Standard'
  enableRBAC: true
  aadProfileManaged: true
  adminGroupObjectIDs: []
  ManagedClusterCostAnalysis: true
}

param defaultNodePool object = {
  name: 'systempool01'
  count: 3
  vmSize: 'Standard_D2s_v3'
  osDiskSizeGB: 50
  osDiskType: 'Ephemeral'
  vnetSubnetID: subnetId
  osType: 'Linux'
  maxCount: 6
  minCount: 2
  enableAutoScaling: true
  type: 'VirtualMachineScaleSets'
  mode: 'System'
  orchestratorVersion: null
}

resource aksAzureMonitor 'Microsoft.OperationalInsights/workspaces@2020-03-01-preview' = {
  name: '${aksClusterName}-logA'
  tags: {}
  location: resourceGroup().location
  properties: {
    sku: {
      name: 'PerNode'
    }
    retentionInDays: 30
    workspaceCapping: {
      dailyQuotaGb: 30
    }
  }
}

// https://docs.microsoft.com/en-us/azure/templates/microsoft.containerservice/managedclusters?tabs=json#ManagedClusterAgentPoolProfile
resource aks 'Microsoft.ContainerService/managedClusters@2023-07-02-preview' = {
  name: aksClusterName
  location: resourceGroup().location
  identity: {
    type: aksSettings.identity
  }
  sku: {
    name: 'Base'
    tier: aksSettings.sku_tier
  }
  properties: {
    kubernetesVersion: aksSettings.kubernetesVersion
    dnsPrefix: aksSettings.clusterName

    addonProfiles: {
      omsagent: {
        enabled: true
        config: {
          logAnalyticsWorkspaceResourceID: aksAzureMonitor.id
        }
      }
    }

    enableRBAC: aksSettings.enableRBAC

    enablePodSecurityPolicy: false // setting to false since PSPs will be deprecated in favour of Gatekeeper/OPA

    networkProfile: {
      networkPlugin: aksSettings.networkPlugin
      networkPolicy: aksSettings.networkPolicy
      networkPluginMode: aksSettings.networkPluginMode // Azure CNI Overlay mode
      serviceCidr: aksSettings.serviceCidr  // Must be cidr not in use any where else across the Network (Azure or Peered/On-Prem).  Can safely be used in multiple clusters - presuming this range is not broadcast/advertised in route tables.
      dnsServiceIP: aksSettings.dnsServiceIP // Ip Address for K8s DNS
      outboundType: aksSettings.outboundType
      loadBalancerSku: aksSettings.loadBalancerSku
    }

    aadProfile: {
      managed: aksSettings.aadProfileManaged
      // enableAzureRBAC: true // Cross-Tenant Azure RBAC doesn't work - must be same tenant as the cluster subscription
      adminGroupObjectIDs: aksSettings.adminGroupObjectIDs
    }

    autoUpgradeProfile: {}

    apiServerAccessProfile: {
      enablePrivateCluster: true
      privateDNSZone: 'none'
      enablePrivateClusterPublicFQDN: true

    }

    agentPoolProfiles: [
      defaultNodePool
    ]
  }
}

output identity string = aks.identity.principalId

Code snippet
No response
Relevant log output
No response

Hey @owainow, while this doesn't seem to be related to any module in this library, let me try to help you regardless.
From the sound of the error message my best guess is that the provided value for the aksSettings parameter is missing the networkPluginMode property, which is mandatory the way you implemented it.
If a property is missing on an object, but you try to access it regardless you get exactly the error you describred. Bicep tells you it cannot find the property and gives you a list of all that are actually available.

Hi @AlexanderSehr, thanks for the comment. I can see why you might think that however it is set as shown in the bicep file above. I have attempted to manually set overlay with the param too however still I see the same error.

Hi @AlexanderSehr, thanks for the comment. I can see why you might think that however it is set as shown in the bicep file above. I have attempted to manually set overlay with the param too however still I see the same error.

Hey @owainow thanks for the response and for elaborating. I'll try to reproduce it on my end as soon as I have some time and give an update :)

Hey @owainow,
I just successfully deployed your example with 2 very small changes as pointed out by the <========================

Snippet
param aksClusterName string
param subnetId string
param adminUsername string = 'azureuser'

param aksSettings object = {
  kubernetesVersion: null
  identity: 'SystemAssigned'
  networkPlugin: 'azure'
  networkPluginMode: 'overlay'
  networkPolicy: 'calico'
  serviceCidr: '<IP_ADDRESS>/22' // Must be cidr not in use any where else across the Network (Azure or Peered/On-Prem).  Can safely be used in multiple clusters - presuming this range is not broadcast/advertised in route tables.
  dnsServiceIP: '<IP_ADDRESS>' // Ip Address for K8s DNS

  outboundType: 'LoadBalancer' // Original: 'UDR' <========================

  loadBalancerSku: 'standard'
  sku_tier: 'Standard'
  enableRBAC: true
  aadProfileManaged: true
  adminGroupObjectIDs: []
  ManagedClusterCostAnalysis: true
}

param defaultNodePool object = {
  name: 'systempool01'
  count: 3
  vmSize: 'Standard_D2s_v3'
  osDiskSizeGB: 50
  osDiskType: 'Ephemeral'
  vnetSubnetID: subnetId
  osType: 'Linux'
  maxCount: 6
  minCount: 2
  enableAutoScaling: true
  type: 'VirtualMachineScaleSets'
  mode: 'System'
  orchestratorVersion: null
}

resource aksAzureMonitor 'Microsoft.OperationalInsights/workspaces@2020-03-01-preview' = {
  name: '${aksClusterName}-logA'
  tags: {}
  location: resourceGroup().location
  properties: {
    sku: {
      name: 'PerNode'
    }
    retentionInDays: 30
    workspaceCapping: {
      dailyQuotaGb: 30
    }
  }
}

// https://docs.microsoft.com/en-us/azure/templates/microsoft.containerservice/managedclusters?tabs=json#ManagedClusterAgentPoolProfile
resource aks 'Microsoft.ContainerService/managedClusters@2023-07-02-preview' = {
  name: aksClusterName
  location: resourceGroup().location
  identity: {
    type: aksSettings.identity
  }
  sku: {
    name: 'Base'
    tier: aksSettings.sku_tier
  }
  properties: {
    kubernetesVersion: aksSettings.kubernetesVersion

    dnsPrefix: aksClusterName // Original: aksSettings.clusterName <========================

    addonProfiles: {
      omsagent: {
        enabled: true
        config: {
          logAnalyticsWorkspaceResourceID: aksAzureMonitor.id
        }
      }
    }

    enableRBAC: aksSettings.enableRBAC

    enablePodSecurityPolicy: false // setting to false since PSPs will be deprecated in favour of Gatekeeper/OPA

    networkProfile: {
      networkPlugin: aksSettings.networkPlugin
      networkPolicy: aksSettings.networkPolicy
      networkPluginMode: aksSettings.networkPluginMode // Azure CNI Overlay mode
      serviceCidr: aksSettings.serviceCidr // Must be cidr not in use any where else across the Network (Azure or Peered/On-Prem).  Can safely be used in multiple clusters - presuming this range is not broadcast/advertised in route tables.
      dnsServiceIP: aksSettings.dnsServiceIP // Ip Address for K8s DNS
      outboundType: aksSettings.outboundType
      loadBalancerSku: aksSettings.loadBalancerSku
    }

    aadProfile: {
      managed: aksSettings.aadProfileManaged
      // enableAzureRBAC: true // Cross-Tenant Azure RBAC doesn't work - must be same tenant as the cluster subscription
      adminGroupObjectIDs: aksSettings.adminGroupObjectIDs
    }

    autoUpgradeProfile: {}

    apiServerAccessProfile: {
      enablePrivateCluster: true
      privateDNSZone: 'none'
      enablePrivateClusterPublicFQDN: true

    }

    agentPoolProfiles: [
      defaultNodePool
    ]
  }
}

output identity string = aks.identity.principalId

Invocation & Output (Terminal)
PS C:\dev\ip\Azure-ResourceModules\ResourceModules> New-AzResourceGroupDeployment -TemplateFile 'C:\Users\alsehr\OneDrive - Microsoft\Docs\Code\temp\aksIssueTest.bicep' -ResourceGroupName 'alsehrTestRg' -Verbose -subnetId '/subscriptions/<mySub>/resourcegroups/alsehrTestRg/providers/Microsoft.Network/virtualNetworks/my-vnet-2/subnets/default' -aksClusterName 'mycluster'
VERBOSE: Using Bicep v0.23.1
WARNING: C:\Users\alsehr\OneDrive - Microsoft\Docs\Code\temp\aksIssueTest.bicep(3,7) : Warning no-unused-params: Parameter "adminUsername" is declared but never used. [https://aka.ms/bicep/linter/no-unused-params]
C:\Users\alsehr\OneDrive - Microsoft\Docs\Code\temp\aksIssueTest.bicep(42,13) : Warning no-loc-expr-outside-params: Use a parameter here instead of 'resourceGroup().location'. 'resourceGroup().location' and 'deployment().location' should only be used as a default value for parameters. [https://aka.ms/bicep/linter/no-loc-expr-outside-params]
C:\Users\alsehr\OneDrive - Microsoft\Docs\Code\temp\aksIssueTest.bicep(57,13) : Warning no-loc-expr-outside-params: Use a parameter here instead of 'resourceGroup().location'. 'resourceGroup().location' and 'deployment().location' should only be used as a default value for parameters. [https://aka.ms/bicep/linter/no-loc-expr-outside-params]
VERBOSE: Performing the operation "Creating Deployment" on target "alsehrTestRg".
VERBOSE: 14:31:18 - Template is valid.
VERBOSE: 14:31:27 - Create template deployment 'aksIssueTest'
VERBOSE: 14:31:27 - Checking deployment status in 5 seconds
VERBOSE: 14:31:32 - Resource Microsoft.OperationalInsights/workspaces 'mycluster-logA' provisioning status is succeeded
VERBOSE: 14:31:32 - Checking deployment status in 5 seconds
VERBOSE: 14:31:37 - Resource Microsoft.ContainerService/managedClusters 'mycluster' provisioning status is running
VERBOSE: 14:31:37 - Checking deployment status in 14 seconds
VERBOSE: 14:31:52 - Checking deployment status in 16 seconds
(...)
VERBOSE: 14:39:47 - Checking deployment status in 15 seconds
VERBOSE: 14:40:02 - Resource Microsoft.ContainerService/managedClusters 'mycluster' provisioning status is succeeded
VERBOSE: 14:40:03 - Checking deployment status in 5 seconds
VERBOSE: 14:40:08 - Resource Microsoft.ContainerService/managedClusters 'mycluster' provisioning status is succeeded

DeploymentName          : aksIssueTest
ResourceGroupName       : alsehrTestRg
ProvisioningState       : Succeeded
Timestamp               : 11/12/2023 13:40:03
Mode                    : Incremental
TemplateLink            :
Parameters              :
                          Name               Type                       Value
                          =================  =========================  ==========
                          aksClusterName     String                     "mycluster"
                          subnetId           String                     "/subscriptions/<mySub>/resourcegroups/alsehrTestRg/providers/Microsoft.Network/virtualNetworks/my-vnet-2/subnets/default"
                          adminUsername      String                     "azureuser"
                          aksSettings        Object                     {"kubernetesVersion":null,"identity":"SystemAssigned","networkPlugin":"azure","networkPluginMode":"overlay","networkPolicy":"calico","serviceCidr":"<IP_ADDRESS>/2
                          2","dnsServiceIP":"<IP_ADDRESS>","outboundType":"LoadBalancer","loadBalancerSku":"standard","sku_tier":"Standard","enableRBAC":true,"aadProfileManaged":true,"adminGroupObjectIDs":[],"ManagedClusterCostAnalys
                          is":true}
                          defaultNodePool    Object                     {"name":"systempool01","count":3,"vmSize":"Standard_D2s_v3","osDiskSizeGB":50,"osDiskType":"Ephemeral","vnetSubnetID":"/subscriptions/<mySub>/resourcegroups/alsehrTestRg/providers/Microsoft.Network/virtualNetworks/my-vnet-2/subnets/default","osType":"Linux","maxCount":6,"minCount":2,"enableAutoScaling":true,"type":"VirtualMachineScaleS
                          ets","mode":"System","orchestratorVersion":null}

Outputs                 :
                          Name             Type                       Value
                          ===============  =========================  ==========
                          identity         String                     "3b360cc9-6545-4938-8a48-6344e09c9088"

DeploymentDebugLogLevel :

Result in Azure

I was not able to reproduce your issue and the 2 changed lines also don't have anything to do with the issue you described. Which means I'm still very much convinced your aksSettings object is not the same as specified in the parameters ;)

Thanks for deploying! Interesting this is my first time writing bicep modules and calling it from a central script. You were right (Shouldn't have doubted it ;) ) but it's not obvious to me why it was not being set. The main.bicep file did not have the param NetworkPluginMode: parameter as it now does (See below). I wouldn't expect it not being passed into the call in main to mean that it doesn't use the value declared within the aks_cluster.bicep file...

targetScope='subscription'

// resource group parameters
param rgName string = 'rg'
param location string = 'northeurope'
param deployRand string

// vnet parameters
param vnetName string = 'aks-vnet'
param vnetPrefix string = '<IP_ADDRESS>/16'
param aksSubnetPrefix string = '<IP_ADDRESS>/24'
param ilbSubnetPrefix string = '<IP_ADDRESS>/24'
param fwSubnetPrefix string = '<IP_ADDRESS>/24'
param mgmtSubnetPrefix string = '<IP_ADDRESS>/24'

// aks parameters
param aksClusterName string = 'aks-cluster'
param k8sVersion string = '1.27'
param SPN string

//param adminUsername string = 'azureuser'
param adminGroupObjectIDs array = []
@allowed([
  'Free'
  'Standard'
])
param aksSkuTier string = 'Standard'
param aksVmSize string = 'Standard_D2s_v3'
param aksNodes int = 1

@allowed([
  'azure'
  'calico'
])
param aksNetworkPolicy string = 'calico'

// fw parameters
param fwName string = 'aks-fw'
var applicationRuleCollections = [
  {
    name: 'aksFirewallRules'
    properties: {
      priority: 100
      action: {
        type: 'allow'
      }
      rules: [
        {
          name: 'aksFirewallRules'
          description: 'Rules needed for AKS to operate'
          sourceAddresses: [
            aksSubnetPrefix
          ]
          protocols: [
            {
              protocolType: 'Https'
              port: 443
            }
            {
              protocolType: 'Http'
              port: 80
            }
          ]
          targetFqdns: [
            //'*.hcp.${rg.location}.azmk8s.io'
            '*.hcp.westeurope.azmk8s.io'
            'mcr.microsoft.com'
            '*.cdn.mcr.io'
            '*.data.mcr.microsoft.com'
            'management.azure.com'
            'login.microsoftonline.com'
            'dc.services.visualstudio.com'
            '*.ods.opinsights.azure.com'
            '*.oms.opinsights.azure.com'
            '*.monitoring.azure.com'
            'packages.microsoft.com'
            'acs-mirror.azureedge.net'
            'azure.archive.ubuntu.com'
            'security.ubuntu.com'
            'changelogs.ubuntu.com'
            'launchpad.net'
            'ppa.launchpad.net'
            'keyserver.ubuntu.com'
          ]
        }
      ]
    }
  }
]
var networkRuleCollections = [
  {
    name: 'ntpRule'
    properties: {
      priority: 100
      action: {
        type: 'allow'
      }
      rules: [
        {
          name: 'ntpRule'
          description: 'Allow Ubuntu NTP for AKS'
          protocols: [
            'UDP'
          ]
          sourceAddresses: [
            aksSubnetPrefix
          ]
          destinationAddresses: [
            '*'
          ]
          destinationPorts: [
            '123'
          ]
        }
      ]
    }
  }
]

// acr parameters
@allowed([
  'Basic'
  'Standard'
  'Premium'
])
param acrSku string = 'Premium'
param acrName string = 'aksacr'
param acrAdminUserEnabled bool = true
param acrRole string

resource rg 'Microsoft.Resources/resourceGroups@2021-01-01' existing = {
  name: rgName
}

module vnet 'modules/aks_vnet.bicep' = {
  name: vnetName
  scope: rg
  params: {
    vnetName: vnetName
    vnetPrefix: vnetPrefix
    aksSubnetPrefix: aksSubnetPrefix
    ilbSubnetPrefix: ilbSubnetPrefix
    fwSubnetPrefix: fwSubnetPrefix
    mgmtSubnetPrefix: mgmtSubnetPrefix
  }
}

module fw 'modules/azfw.bicep' = {
  dependsOn: [
    vnet
  ]
  name: fwName
  scope: rg
  params: {
    fwName: fwName
    fwSubnetId: vnet.outputs.fwSubnetId
    applicationRuleCollections: applicationRuleCollections
    networkRuleCollections: networkRuleCollections
  }
}

module aks 'modules/aks_cluster.bicep' = {
  name: aksClusterName
  dependsOn: [
    fw
  ]
  scope: rg
  params: {
    aksClusterName: aksClusterName
    subnetId: vnet.outputs.aksSubnetId
    SPN: SPN
    aksSettings: {
      clusterName: aksClusterName
      identity: 'SystemAssigned'
      kubernetesVersion: k8sVersion
      networkPlugin: 'azure'
      networkPluginMode: 'overlay'
      networkPolicy: aksNetworkPolicy
      serviceCidr: '<IP_ADDRESS>/22' // can be reused in multiple clusters; no overlap with other IP ranges
      dnsServiceIP: '<IP_ADDRESS>'
      outboundType: 'loadBalancer'
      loadBalancerSku: 'standard'
      sku_tier: aksSkuTier
      enableRBAC: true
      aadProfileManaged: true
      adminGroupObjectIDs: adminGroupObjectIDs

    }

    defaultNodePool: {
      name: 'pool01'
      count: aksNodes
      vmSize: aksVmSize
      osDiskSizeGB: 50
      osDiskType: 'Ephemeral'
      vnetSubnetID: vnet.outputs.aksSubnetId
      osType: 'Linux'
      type: 'VirtualMachineScaleSets'
      mode: 'System'
    }
  }
}

module acr 'modules/acr.bicep' = {
  dependsOn: [
    aks
  ]
  name: acrName
  scope: rg
  params:{
    acrName: acrName
    acrSku: acrSku
    acrAdminUserEnabled: acrAdminUserEnabled
    acrRole: acrRole
    principalId: aks.outputs.identity
    acrSubnet: vnet.outputs.mgmtSubnetId
    vnetId: vnet.outputs.Id
    deployRand: deployRand
  }
}

Hey @owainow, happy to help.
What you're describing is not wrong per se. The reason this became a problem in your case is not that you didn't provide it, but that you accessed the value like you did here: networkPluginMode: aksSettings.networkPluginMode.
To declare it as an optional property of your aksSettings input object you'd need to write it in one of the following ways:

networkPluginMode: aksSettings.?networkPluginMode (which would default to null if the property doesn't exist in aksSettings) or
networkPluginMode: contains(aksSettings, 'networkPluginMode') ? aksSettings.networkPluginMode : null (which is the same thing but a bit more 'on the nose)

In words: If the object aksSettings has a property networkPluginMode then use it, otherwise use null.
Small sidenote, if you actually then want to have a default you can go a step further and use the coalese functionality like this: networkPluginMode: aksSettings.?networkPluginMode ?? 'LoadBalancer' - which essentially means the same as the above with the 'else' case being 'LoadBalancer'. The ?? in a expression like abc ?? def ?? ghi ... just returns the first non-null value in the sequence.
If you deem your questions answered, feel free to close the issue ;)

Ty! @AlexanderSehr


Plugin system

For example, fs-router could be implemented as a plugin:
module.exports = {
  plugins: [ fsRouter() ]
}

function fsRouter() {
  return (config) => {
    const tmpRouter = os.tmpdir() + '/fs-router-' + Date.now() + '.js'
    config.resolve.alias.add('@fs-router', tmpRouter)
    // then watch `./pages` folder and generate router to `tmpRouter`
  }
}

Implemented in v0.9 https://egoistian.com/unvue/#/plugin


rename back fromEd25519SK into fromSeed

We a looking for a way to implement more key types in the future, so simple fromSeed would be confusing. fromEd25519SK correctly describes what the method is actually doing. Is there any specific reason why you want this to be renamed back?

"seed" is a confusing word, overloaded with meanings. Also, it's not used in public-key cryptography, ed25519 algorithm, or other papers, AFAIK.
"seed" usually refers to PRNG's seed. But some cryptography libraries use it incorrectly to mean "private key". This just adds to the confusion, and we want to avoid that.

the string passed unto subject method is not ed25.. key, from that string i can produce any key. so that is randonmess, so that is seed.

but i can create key not from 32 bytea, but less or more. so i type 100 byte string and get 33 byte key.

I understand where you coming from. I've been confused by this a lot, too.
The thing is, any byte sequence of length 32 is a valid Ed25519 key. I find that VERY surprising and amusing, but that's what it is.
And that's the reason why we've renamed the method to fromEd25519SK. fromSeed was incorrect: it's not a seed (whatever that word should mean), it's a private key.

Thus, closing the issue


Trouble Shooting

Triton Kernel Fix:
If you see No such file or directory: '/root/.triton/cache/e3457c918521f16104a655b081235e5a.....
(issue caused by pytorch dependency of triton==2.3.0)

You can fix it by hacking the file compiler.py

vim /usr/local/lib/python3.10/dist-packages/triton/compiler/compiler.py

L230

self.asm = {
  file.suffix[1:]: file.read_bytes() if file.suffix[1:] == driver.binary_ext else None

Or you can uninstall triton and reinstall the triton nightly

pip uninstall -y triton triton-nightly
pip install -U --index-url https://aiinfra.pkgs.visualstudio.com/PublicPackages/_packaging/Triton-Nightly/pypi/simple/ triton-nightly

It is related to https://github.com/triton-lang/triton/issues/2688.


ui: fix ETA widget text spacing in map

          @deanlee alex noticed that this PR changes the spacing between the elements, can we revert that?

Before:

After:

Originally posted by @sshane in https://github.com/commaai/openpilot/issues/28780#issuecomment-1644485385

@jnewb1 thanks for the fix.


Build Linux version with Travis CI.

This could be useful for those who don't have a Linux box at hand.
I tried to keep the file as simple as I could, but perhaps in the future it could be expanded to specify more environments.

This is a good thing to add, even though we just went through an exercise to clean out the top-level directory in the repo.  And I would like to look into hooking this repo up to Travis-ci.  The KhronosGroup/Vulkan-Samples repo does this.  But I might experiment with a fork first, though.
@petmac Were you able to actually try this to verify that it works as provided?

This could be useful for those who don't have a Linux box at hand.

Just so I understand the use case, I imagine that a developer might be working on Windows with a fork of this repo and prepares a pull request.  Before submitting the PR, they would hook up their fork to Travis and have Travis compile for Linux to make sure it builds.  Is that right?

Hi @karl-lunarg
Yes, I ran this on a fork and built the Linux version OK. I'm not a Travis CI expert by any means, so it's likely that the script can be improved.
Your use case is exactly right. For what it's worth, I was experimenting with OS X, and wanted to ensure that I didn't break the Linux version along the way.

Thanks!   I went ahead and pulled in the file as-is.  We can enhance the file later to add more build environments.   And at some point, we can hook up Travis CI to this repo so that people can see the build status.   We do run a bunch of our own CI machines, so this would be pretty redundant.  But there's some value in seeing the status on the GitHub page, like https://github.com/KhronosGroup/Vulkan-Samples.


updated ismi sample data for development branch

update ISMI sample data for development branch.

I took out the notebook. Do you want to review @rlskoeser or should I just merge?


Make it work with engines

Hi,
I am trying out engines, and found out that this addon doesn't work in that scenario. First of all, it can't even be installed due to https://github.com/tim-evans/ember-page-title/issues/31.
So I tried to circumvent this by basically disabling the {{title}} lookup in my engine with:
if (typeof this.app !== 'undefined' && typeof this.app.registry !== 'undefined') {
  this.app.registry.add('htmlbars-ast-plugin', {
    name: 'translate-title-helper-to-page-title-helper',
    plugin: TranslateHelperName
  });
}

So I could just use {{page-title}} in the engine. But it still didn't work, because of the way ember-cli-head works.
So I got it to work with a few workarounds - which might also be interesting for anyone else trying this.
1.) Define the header-data and page-title-list services as dependencies.
2.) In the engine, create a component head-content with the following content:
import Ember from 'ember';
import layout from 'my-host-app-name/templates/head';

const {
  inject,
  Component
} = Ember;

export default Component.extend({
  tagName: '',
  model: inject.service('head-data'),
  layout
});

3.) Now use {{page-title}} instead of {{title}} in your engine, and everything works!
Maybe this can somehow be simplified, or at least added to the readme. However, it depends on https://github.com/tim-evans/ember-page-title/issues/31 being fixed first, otherwise the app can't even load.

Merged! Anything else to do to make this work?

I use it in my app and it works fine so far - the docs should maybe be updated with the information to make this work in engines?

I've changed which hook the ast-plugin gets used. Could anyone check this out?

I tried it, I can use {{title}} now in my engine! Great! :)

Thanks for the confirmation 🎉  Sooo happy to have figured this out.

Just adding this here, if someone else runs in to this:
ember-cli-head broke my acceptance tests when using engines.
So I added
if (environment === 'test') {
  ENV['ember-cli-head'] = {
      suppressBrowserRender: true
  };
}

to my environment.js, which made it work again.


v-memo  v-for with inline array iteration error "can't access property "el", oldVNode is undefined"

Version
3.2.0-beta.7
Reproduction link
sfc playground
this is inline example that does not work an raise the error
// [1,2,3] inline array
v-for="v,k in [1,2,3]"

the following will work as expected ( when arr = [1,2,3] )
v-for="v,k in arr"

Steps to reproduce
open sfc

click inc button 3 times, when v-memo trigger a change the error will show.

What is expected?
no error
What is actually happening?
Uncaught (in promise): can't access property "el", oldVNode is undefined

I noticed another bug in your example. If you declare an array using const instead of let/var

I noticed another bug in your example. If you declare an array using const instead of let/var then this error following error occurs
Uncaught (in promise): Cannot read property 'emitsOptions' of null

I noticed another bug in your example. If you declare an array using const instead of let/var then following error occurs
Uncaught (in promise): Cannot read property 'emitsOptions' of null

are you sure its not the error you get on the 4th click?

ahh yes, it shows up on 4th click, nevermind then

the root cause is:
return (_ctx, _cache) => {
  return (_openBlock(), _createElementBlock(_Fragment, null, [
    _createElementVNode("button", {
      onClick: _cache[0] || (_cache[0] = $event => (count.value++))
    }, " inc " + _toDisplayString(count.value), 1 /* TEXT */),
    (_openBlock(), _createElementBlock(_Fragment, null, _renderList([1,2,3], (id, index, ___, _cached) => {
      const _memo = ([count.value < 3 ? true : count.value])

+ 	  we will lose the `dynamicChidren` (the `currentBlock` is empty) because return the cached vnode here.
      if (_cached && _cached.key === id && _isMemoSame(_cached.memo, _memo)) return _cached
      const _item = _createVNode(__import_1__.default, {
        count: count.value,
        index: index,
        key: id
      }, null, 8 /* PROPS */, ["count", "index"])
      _item.memo = _memo
      return _item
    }, _cache, 1), 64 /* STABLE_FRAGMENT */))
  ], 64 /* STABLE_FRAGMENT */))
}

it will be interesting to see if this also related  to this root cause https://github.com/vuejs/vue-next/issues/4262

@lidlanca
withMemo works fine because it catches the block tree.
see :
export function withMemo(
  memo: any[],
  render: () => VNode<any, any>,
  cache: any[],
  index: number
) {
  const cached = cache[index] as VNode | undefined
  if (cached && isMemoSame(cached.memo!, memo)) {
    // make sure to let parent block track it when returning cached
    if (isBlockTreeEnabled > 0 && currentBlock) {
      currentBlock.push(cached)
    }
    return cached
  }
  const ret = render()
  ret.memo = memo
  return (cache[index] = ret)
}


feat: Optimize Docker image, build for amd64+arm64

The image size is reduced by 13% using the following measures:

Extended .dockerignore to remove further metadata and tests. This also ensures better layer caching for repeat builds.
Cleaning npm cache for the final stage.

Inline source maps are enabled to improve error reporting. Stack traces will now refer to the TypeScript source locations instead of transpiled JS.
Multiplatform build for arm64 in addition to amd64 is enabled to improve performance on ARM devices due to not needing emulation.
Finally, the docker run example in README.md is amended to include security best practices.

Additional Context

N/A
Checklist

[X] The pull request title meets the Conventional Commits specification and optionally includes the scope, for example: feat: Add social login

The PR build is unfortunately much slower now (around 8 minutes). This could be resolved by hosting the multistage build on an Arm64 runner (due to efficient x86_64 emulation, vs. the other way around), but these are not yet available for the GitHub free tier, unfortunately.
Source: https://github.blog/changelog/2024-09-03-github-actions-arm64-linux-and-windows-runners-are-now-generally-available/


Fix production build

Hi, three parts here:

recursive crawl: Add the code of used smelte components to the purgeCss extractor. If the build performance is bad, there might be ways to improve it, since there are a bit too many recursions. I left a note in the code.
add hardcoded whitelist. I tried several things, eg. updating the @fullhuman/postcss-purgecss to newer version 2.3.0, but nothing seemed to make whitelisting work. So, I've put the classes in the extractor. It is workaround, rather than  a fix.
update button hover variants. The hover:... classes were purged away, so I've explicitly added them for button. I did not check other components, they may have the same problem.

Should fix: #115, #110, #97, #91
Could fix: #155

Great job! Thank you!


KAFKA-12835: Topic IDs can mismatch on brokers (after interbroker protocol version update)

Upon upgrading to IBP 2.8, topic ID can end up getting reassigned which can cause errors in LeaderAndIsr handling when the partition metadata files from the previous ID are still on the broker.
Topic IDs are stored in the TopicZNode. The behavior of the code before this fix is as follows:
Consider we had a controller with IBP 2.8+. Each topic will be assigned topic IDs and LeaderAndIsr requests will write partition.metadata files to the brokers. If we re-elect the controller and end up with a controller with an older IBP version and we reassign partitions, the TopicZNode is overwritten and we lose the topic ID. Upon electing a 2.8 IBP controller, we will see the TopicZNode is missing a topic ID and will generate a new one. If the broker still has the old partition metadata file, we will see an ID mismatch that causes the error.
This PR changes controller logic so that we maintain the topic ID in the controller and the ZNode even when IBP < 2.8. This means that in the scenario above, reassigning partitions will not result in losing the topic ID and reassignment.
Topic IDs may be lost when downgrading the code below version 2.8, but upon re-upgrading to code version 2.8, before bumping the IBP, all partition metadata files will be deleted to prevent any errors.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Hmm looks like KafkaMetadataLogTest.testTopicId is failing because we set keepPartitionMetadataFile to be false. When I ensure that we only assign topicId when keepPartitionMetadataFile we do not assign topic ID to the log. Since we rely on assignment in memory + in the file to be consistent, one option is to write a partition.metadata file for the metadata topic. This won't be used like the other partition.metadata files, but it might be easier to keep all logs consistent.

I thought I cherry-picked this to 2.8, but I guess I didn't. I will need to do that as well.

Failed tests are not related:
Build / JDK 11 and Scala 2.13 / org.apache.kafka.common.network.SslTransportLayerTest.[1] tlsProtocol=TLSv1.2, useInlinePem=false
Build / JDK 11 and Scala 2.13 / org.apache.kafka.common.network.SslTransportLayerTest.[2] tlsProtocol=TLSv1.2, useInlinePem=true
Build / JDK 11 and Scala 2.13 / org.apache.kafka.common.network.SslTransportLayerTest.[3] tlsProtocol=TLSv1.3, useInlinePem=false
Build / JDK 11 and Scala 2.13 / org.apache.kafka.common.network.SslTransportLayerTest.[1] tlsProtocol=TLSv1.2, useInlinePem=false
Build / JDK 11 and Scala 2.13 / org.apache.kafka.common.network.SslTransportLayerTest.[2] tlsProtocol=TLSv1.2, useInlinePem=true
Build / JDK 11 and Scala 2.13 / org.apache.kafka.common.network.SslTransportLayerTest.[3] tlsProtocol=TLSv1.3, useInlinePem=false
Build / JDK 8 and Scala 2.12 / kafka.server.RaftClusterTest.testCreateClusterAndCreateAndManyTopics()
Build / JDK 16 and Scala 2.13 / kafka.network.ConnectionQuotasTest.testNonDefaultConnectionCountLimitAndRateLimit()
Build / JDK 16 and Scala 2.13 / kafka.server.RaftClusterTest.testCreateClusterAndCreateAndManyTopicsWithManyPartitions()

@jolshan I can't cherry-pick the commit to 2.8 due to conflicts. Could you open a PR for it?


add JDK11 startup in readme.md

./makejdk-any-platform.sh <jdk8u|jdk9u|jdk10u>

needs to add an item jdk11
and there's no jdk11u because https://github.com/AdoptOpenJDK/openjdk-jdk11u is an empty repository.

I'll add this once we get the 11.0.1 release out


Ability to set custom attributes & tags when cloning VM from template

Hello,
Did not find this capability in the documentation. Is this possible somehow?
I think it's very useful feature, to be able to classify the VM with either tags or custom attributes, either as part of the cloning process, and a separate get/set command for existing VM's.
Thanks.

Hi, I'd love to see tags. Unfortunately it's not available in the SOAP API. VMWare does have an API but so far has not made the ruby gem available on rubygems, which means we can't distribute it, and haven't tried to do the code.
Which custom attributes are you talking about? There's an --annotate option when you clone, but no separate command. There's also get/set properties but they've been here longer than I have, and I've never used them.

Noted regarding tags.
The annotate option will just add free text to the VM "Notes" field.
vCenter allows your to define key/values as custom attributes, which can be assigned to different vsphere objects, VM's included.
One example of a tool that leverages this is the vagrant-vsphere plugin, which also uses rbvmomi. When provisioning a VM with it, you can define which values to assign to one or more custom attribute keys.

Aha, so this is setting extraConfig on the VM. We'd be able to do that with knife vsphere vm config if it could handle data structures as the value rather than only strings.

Maybe this one?
https://vdc-repo.vmware.com/vmwb-repository/dcr-public/723e7f8b-4f21-448b-a830-5f22fd931b01/5a8257bd-7f41-4423-9a73-03307535bd42/doc/vim.ExtensibleManagedObject.html
in vagrant-vsphere, they call setCustomValue on the object returned by template.CloneVM_Task.
https://github.com/nsidc/vagrant-vsphere/search?utf8=✓&q=setCustomValue&type=

We could definitely add that kind of stuff (or take PRs doing it ;) ), how were you thinking it would get used?

Hint noted :)
I see these use cases:

Assign values to 1+ custom attributes keys as an option to vm clone command
Generically, get all values currently assigned to the target object (VM, datastore, etc)
Generically, assign values to the target object

In all cases, any custom attribute key would need to already exist in vCenter, and be assigned to the object type (VM, datastore, etc)
It should be possible to set the option value as a list of k/v pairs (or maybe call the option multiple times in the same command). I don't know how this is usually done in knife-vsphere.

Typically we pass JSON, such as --bootstrap-vault-json or --json-attributes, though if it's not nested there's also precedent of comma delimited, such as --myopt k1:v1,k2:v2.
Since I don't use those features (yet? It sounds helpful) I'll have a look around the UI to see how and where I'd use them.

I was taking a second look to the VMware link for ExtensibleManagedObject, and as the only method is setCustomValue, it limits this functionality to a (over)write operation, which is unfortunate. No idea if that information can be extracted with a different method.

Would it be customValue on the VM object? (not at work today otherwise I'd give it a try).
I also see in the docs there's a AddCustomFieldDef method, so presumably we could make these keys from the command line, or even creating them if they don't exist.

I digged a little bit further, and this is actually doable in a r/w fashion using the customFieldsManager interface. Came up with this snippet of code as proof of concept.
This code finds the VM, gets all custom fields from vcenter and creates a simple hash map of field id > field name. Then iterates over the VM customValue property and outputs field Name and the Value assigned in that particular VM. Then actually changes the value of field with id 41.
Seems to work fine, just tested against one vCenter 6.5.
`
vim = VIM.connect opts
dc = vim.serviceInstance.find_datacenter(opts[:datacenter]) or abort "datacenter not found"
vm = dc.find_vm(vm_name) or abort "VM not found"
fields = vim.serviceInstance.content.customFieldsManager.field
fpairs = Hash.new
fields.each do |f|
fpairs[f.key] = f.name
end
vm.customValue.each do |x|
puts "#{fpairs[x.key]} (#{x.key}): #{x.value}"
end
vim.serviceInstance.content.customFieldsManager.SetField(entity: vm, key: "41", value: "whatever")
`


Add GitHub/PSGallery download badges to README

💡 Summary
Add GitHub/PSGallery badges to the readme with respective links.
Motivation and context
This would be useful because it helps redirect users to GitHub releases and ScubaGear module on PSGallery.
Implementation notes
See badges here: https://github.com/cisagov/ScubaGear/tree/1166-add-download-badges
Acceptance criteria
How do we know when this work is done?

[ ] Badges are displayed correctly in README and github pages documentation is consistent

Love the idea!


Load existing policy and train from checkpoint.

Pull request information

Status: Ready to merge
Kind of changes:  New Feature
Related PR or issue: ? N/A

Use the --checkpoint_path argument to pass the location of a checkpoint from which to resume training.

Pull Request Test Coverage Report for Build 5292

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.009%) to 89.892%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

examples/train.py
0
1
0.0%

Totals

Change from base Build 5270:
-0.009%

Covered Lines:
9000

Relevant Lines:
10012

💛  - Coveralls


isValid method not working

Laravel Version: 5.3.15
PHP Version: 5.6.19
Database Driver & Version: MySQL Ver 15.1 Distrib 10.1.10-MariaDB

Description:
$request->file('photo')->isValid() which is suppose to determine if there were no problems uploading the file as describe in the documentation is not working.
Steps To Reproduce:

Created a route to receive the post request and a controller, generated via php artisan make:controller GuestController, to handle the request and accepted the request object as a parameter

// Routes\web.php
Route::post('/signup', 'GuestController@signup');

// GuestController
namespace App\Http\Controllers;

use Illuminate\Http\Request;

use App\Http\Requests;

use Auth;
use Session;
use Validator;

class GuestController extends Controller {
  public function post_handle_signup (Request $request) {
    // ....
  }
}

Grabbed all the inputs via $inputs = $request->all()

// GuestController
public function post_handle_signup (Request $request) {
  // all inputs
  $inputs = $request->all();
}

Created an associative array of rules and messages for the validator and validated the input

// GuestController
public function post_handle_signup (Request $request) {
  // all inputs
  $inputs = $request->all();
  // rules for the validator
  $rules = [
    // some rules....
  ];
  // validation messages
  $messages = [
    // some mesages
  ];
  // validate inputs
  $validator = Validator::make($inputs, $rules, $messages);
}

I needed to validate the uploaded image file so I did a validator->after(closure)

$validator->after(function () use ($validator, $request) {
  if ($request->hasFile('uploaded_file')) {
    if (count($request->file('uploaded_file')) > 1) {
      $validator->errors()->add('uploaded_file', 'Expected only 1 file.');
    } else if (!$request->file('uploaded_file')->isValid()) {
      $validator->errors()->add('uploaded_file', An error encountered while uploading the file.');
    }
  } else {
    $validator->errors()->add('uploaded_file', 'select a file to upload');
  }
}

however, at this point the an error will be thrown saying Call to a member function isValid() on array when this is exactly how the documentation told me to do it:
if ($request->file('photo')->isValid()) {
    //
}

how could you solve it?
I have the same problem


E2E: Add worker uuids

Add worker uuids
Also refactor map names to be more readable
Basics

[x] I added a line to /doc/CHANGELOG.md
[x] The PR is rebased with current master.

[x] References to issues, e.g. close #X, are in the commit messages.
[ ] The buildserver is happy.

Checklist

[ ] I have installed and I am using pre-commit hooks
[ ] I fully described what my PR does in the documentation
(not in the PR description)
[ ] I fixed all affected documentation
[ ] I fixed the introduction tour
[ ] I wrote migrations in a way that they are compatible with already present data
[ ] I fixed all affected decisions
[ ] I added unit tests for my code
[ ] I added code comments, logging, and assertions as appropriate
[ ] I translated all strings visible to the user
[ ] I mentioned every code or binary not directly written or done by me in reuse syntax
[ ] I created left-over issues for things that are still to be done
[ ] Code is conforming to our Architecture
[ ] Code is conforming to our Guidelines
(exceptions are documented)
[ ] Code is consistent to our Design Decisions

Review

[ ] I've tested the code
[ ] I've read through the whole code
[ ] Examples are well chosen and understandable

There is still this inconsistency with the map creation tests not utilizing the worker id in their names (SUT-PrivateMap, SUT-SameMap, SUT-PublicMap, ...).
That is because it would require a bit more code to save the modified mapnames inbetween the different python functions, so they are only using the names from the feature file.

Great to have this fixed! :heart:


compile error with GHC 7.8

The .cabal file claims compatibility with base >= <IP_ADDRESS> && < 5
However, with base-4.7 there's a compile-failure:
[1 of 3] Compiling Rainbow.Types    ( lib/Rainbow/Types.hs, dist/dist-sandbox-8ea63412/build/Rainbow/Types.o )

lib/Rainbow/Types.hs:34:10:
    Not in scope: type constructor or class ‘Monoid’
    Perhaps you meant ‘Monad’ (imported from Prelude)
xcabal: Error: some packages failed to install:
rainbow-<IP_ADDRESS> failed during the building phase. The exception was:
ExitFailure 1

I have edited rainbox-<IP_ADDRESS> on Hackage to fix this (and while at it I also fixed the unnecessarily restricting cabal-version declaration): https://hackage.haskell.org/package/rainbow-<IP_ADDRESS>/revisions/

Fixed in version <IP_ADDRESS>, thanks very much for the report.


Which git respository is active, and how to ugprade to v0.8?

Hi there,
First, thanks for making this great projects!
Other than github I also found git.libreboard.com, I would like to know which respository is active and more up to date?
I tried to find 0.8 but I couldn't see it in either respository. I have been using v0.71 for few weeks and would like to try the new avatar support in v0.8, where can I get it and how could I do an inplace ugprade without re-importing all cards manually?
Thanks!
Tony

The git.libreboard.com repo seems to have the tags that are missing here. It think this was due to the DMCA takedown, as it seems a lot of old commits containing infringing files were removed here, for obvious reasons.

Yes the original author did include some Trello copyrighted files since the very beginning. So I had to restart the repository from scratch to remove them from the git history.
The active repository is here, on GitHub. The self-hosted gitlab instance was a temporary solution to keep the development in the open while I was removing the latest Trello files. The Gitlab instance will be disabled by the end of June.


The QC report is now a standalone html file.

Every time the script sct_qc is executed, the content of the json file is
copied in the html file. The outputed report folder no longer needs a html
server to serve the report.
Fixes #1555

why does the user still have to run sct_qc in order to generate the report? Why not simply updating the html after running each command (e.g. sct_propseg)?

If it is useless then we get rid of it. The easier for the user the better it is :-)

As I'm doing some code churn on QC call sites and QC, I can do that part.


Import current instance into terraform on startup

Adds support for the following optional CLI params:
--bootstrap-group-spec: Group spec to use for the imported instance
--bootstrap-instance-id: Current instance ID
If these 2 options are set then (on plugin startup):

Parse the group spec
Decode the instance definition from the group spec
Import the current VM into terraform
Parse the output of terraform show to get the current attributes of the current VM
Create a .tf.json file using the properties in the instance spec with the real attributes of the current VM; ensuring that the correct group tags (infrakit.group=<grp-id> and infrakit.config_sha=bootstrap) are set
terraform apply

Note that this only occurs of the current VM is not already in the terraform state file.
The plugin startup process is blocked until this has completed and will fail to start if there is an error.
Closes #533

An example of the group spec that is passed is:
{
  "ID": "managers",
  "Properties": {
    "Allocation": {
      "LogicalIDs": [
        {{ range $i, $_ := loop (int (var "/cluster/swarm/manager/size")) }}
        {{ if ne $i 0 }},{{end}}{{ quote (cat "mgr" (add1 $i) | nospace) }}
        {{ end }}
      ]
    },
    "Instance": {
      {
        "Plugin": "instance-terraform",
        "Properties": {
          "resource": {
            "ibm_compute_vm_instance": {
              "host": {
                ...
              }
            }
          }
       }
    },
    "Flavor": {
      "Plugin": "flavor-swarm/manager",
        "Properties": {
        "InitScriptTemplateURL": "{{ $managerInit }}",
        "DockerRestartCommand": "service docker restart",
        "SwarmJoinIP": "{{ var "/cluster/swarm/join/ip" }}",
        "Docker" : {
          "Host" : "unix:///var/run/docker.sock"
        }
      }
    }
  }
}


Develop

Add some styling for locale picker
Use dynamic method instead of dynamic property

Add Locations_model to the mix.
Menu option values translated attributes are not getting stored.. (prolly related to the TRLRepeater widget)
CSS issue when editing static menus (prolly something to do with loading the modal)

I appreciate your patience and appreciate your time and efforts! Thank you!


Python API pause bag for debugging

Hi! I can not find a good example / documentation on how to pause and resume a bag file in python.
I am using vscode debugger, and I would like to check frame by frame what is happening (I am using keypoint detection DL over the stream) . For now, my pipeline is based on the 'load bag' example:
https://github.com/IntelRealSense/librealsense/blob/master/wrappers/python/examples/read_bag_example.py
I have only seen this topic in c++, which differs significantly from my pipeline: https://github.com/IntelRealSense/librealsense/blob/master/examples/record-playback/rs-record-playback.cpp

Required Info

Camera Model
D435i

Firmware Version
2.49.0

Operating System & Version
Ubuntu 18.04 (L4T Jetson Xavier)

Kernel Version (Linux Only)
(e.g. 4.14.13)

Platform
Jetson Xavier

Language
python

Segment
Robot

Hi @DiXcipuli  In https://github.com/IntelRealSense/librealsense/issues/4660#issue-482102697 there is an example of a Python script that uses playback.pause() and playback.resume() to pause and resume bag playback.

Thanks @MartyG-RealSense , indeed it is a good start! However, as I may pause the stream for a while, while debugging, I have the runtime error: RuntimeError: Frame didn't arrive within 5000 . Does it mean I cant excess this duration?
I set: playback = profil.get_device().as_playback()  and  playback.set_real_time(False)


DPL - 716,719 - Ability to select v12 revio and v12 well defaults

Closes #1104 #1105
Changes proposed in this pull request:

Reworked pacbio run well default edit to load fields dynamically

Code looks file but I have tried running it locally. Options change as expected but movie time options don't appear. Also there is no option to select Revio as a Systyem name which might be an idea to add for this story.

Movie times should be there. I had a typo which meant it showed up as Move time which may be where the confusion is. Also system name is pulled from the service so it may be you dont have 12_revio locally or that you dont have it set as active?

Code looks file but I have tried running it locally. Options change as expected but movie time options don't appear. Also there is no option to select Revio as a Systyem name which might be an idea to add for this story.

@stevieing Movie times should be there. I had a typo which meant it showed up as Move time which may be where the confusion is. Also system name is pulled from the service so it may be you dont have 12_revio locally or that you dont have it set as active?

I was thinking about system name not SMRT Link Version. We have added it to the back end but not the ui.

Ah my mistake. I have added it.


Add support to Windows

The install script take in account to be in a Debian/Ubuntu  and copy anadi.sh in $HOME/.local/bin/.
Add support to Windows too.

@Brijeshthummar02 please add a comment here in order to let me to assign this issue to you


mat: make EigenSym satisfy Matrix

Please take a look.

Codecov Report
Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (b272217) 73.95% compared to head (bf13d0a) 73.78%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1915      +/-   ##
==========================================
- Coverage   73.95%   73.78%   -0.17%
==========================================
  Files         528      510      -18
  Lines       63381    62756     -625
==========================================
- Hits        46874    46306     -568
+ Misses      13913    13877      -36
+ Partials     2594     2573      -21

Files
Coverage Δ

mat/eigen.go
63.22% <42.85%> (-2.03%)
:arrow_down:

... and 22 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@kortschak Can you please approve again? I pushed changes by mistake.


Added new black listed namespace to configs. Fix issue where rolebind…

Added a blacklisted namespace to the configs as requested by Stefanie. Added checks for rolebinding_controller to check for namespaces that are deleted or in the process of being delted.

/lgtm

/approve


Add UKHSA ONS theme

What is the context of this PR?
This PR adds the UKHSA ONS theme.
Validator PR  for allowing the theme
How to review

Use test_theme_ukhsa_ons.json and check that the logos at the top show correctly.
Check that implementation is similar to that of other themes.
Check that the logos stack vertically when the screen size is reduced

Checklist

[ ] New static content marked up for translation
[ ] Newly defined schema content included in eq-translations repo

 New theme for UKHSA Branding (WCIS) (1 SP)

The logos dont quite line up. I think we should either make the ONS one a bit bigger or add the ons-u-mb-xs class to it

Other than that looks good

Thanks Rich - have tried adding the margin class you suggested, let me know what you think?

The logos dont quite line up. I think we should either make the ONS one a bit bigger or add the ons-u-mb-xs class to it

Other than that looks good

Thanks Rich - have tried adding the margin class you suggested, let me know what you think?

Looks much better 👍

The logos dont quite line up. I think we should either make the ONS one a bit bigger or add the ons-u-mb-xs class to it

Other than that looks good

Thanks Rich - have tried adding the margin class you suggested, let me know what you think?

Looks much better 👍

The logo sizing is currently inconsistent. Is the header sizing dependent on the max width of the logos @rmccar. There doesn't seem to be a min height?.
This compared to desnz_ni is smaller but matches the header size of dbt_dsit_ni. The headers should all be the same height ideally.
Should they be aligned vertically?. This is what I can see at the moment. But this isn't centered among themselves.

The logos dont quite line up. I think we should either make the ONS one a bit bigger or add the ons-u-mb-xs class to it

Other than that looks good

Thanks Rich - have tried adding the margin class you suggested, let me know what you think?

Looks much better 👍

The logo sizing is currently inconsistent. Is the header sizing dependent on the max width of the logos @rmccar. There doesn't seem to be a min height?.
This compared to desnz_ni is smaller but matches the header size of dbt_dsit_ni. The headers should all be the same height ideally.
Should they be aligned vertically?. This is what I can see at the moment. But this isn't centred among themselves.

When you say header size do you mean the height of the white part of the header? Because yes thats based on the hight of the logos. There is a minimum though.
With so many different logos created in different ways its fiddly to get them all the right size. Some have really different designs too so need to be a certain size to be readable. Plus we have stacked and non stacked versions of some logos like the ONS one. There seems to be no standardisation when creating them and when Ive done these in the past Ive had to tidy up and get the logos looking a similar size myself by hand and I don't have any software to do it. I helped Katie out with this yesterday because the logo attached to the card doesn't work at all.
I think really we need a designer to go over all the logos to standardise and optimise them.
On those logos being aligned that was the best way of doing it with the DS utility classes we have. Another option would be to potentially edit the ONS logo to make the whitespace around it a bit bigger in order to pad it out. I can have a look at that if you wanted?

When you say header size do you mean the height of the white part of the header? Because yes thats based on the hight of the logos. There is a minimum though.

How is that currently calculated?. Is it the largest logo etc?. At the moment, it doesn't seem consistent.
For now, we can get it in as is. Can you raise a card to review these from a design perspective. Is there any change needed in DS?.

When you say header size do you mean the height of the white part of the header? Because yes thats based on the hight of the logos. There is a minimum though.

How is that currently calculated?. Is it the largest logo etc?. At the moment, it doesn't seem consistent.
For now, we can get it in as is. Can you raise a card to review these from a design perspective. Is there any change needed in DS?.

Yeah itll be the largest one that its based on.
Yeah Ill raise a card and add it to the backlog. No changes in the DS needed as all the logos we use are in runner


Feature/Patch Inference

add ApplyPatches operators (ApplyPatchesBase, ApplyPatchesWeightedAvg, ApplyPatchesVoting)
add weight attribution functions (gaussian and radial)
add model loaders (BaseLoader and TorchLoader) enabling distributed inference in a transparent way
add Jupyter Notebook with usage instructions for ApplyPatches operator

@SerodioJ could you include some tests too? I'm gonna merge and in another opportunity you include tests cases for this operator. Tks!


Remove examples from main repo and move to another repo

Comments?

reasons?

The examples database is growing, but I still would like to add more complex examples, as well as examples that compile long files to do benchmarks for instance. If I add an exceptionally large file to try benchmark fly-less vs fly-sass (just an example), GitHub will end up interpreting Fly as a CSS project :smile: (actually this happened once in the history of the project).

You are right :smile:
Examples are definitely staying. It would suck to download Fly and try to access the examples and then find out that you need to follow another step for this.

Maybe add a separate repo for larger examples.

Maybe add a separate repo for larger examples.

This


Failed to lookup sumbol 'poseidon_hash2':dlsym

Release mode issue on iOS
Action: Trying to do an init call
Error: Invalid argument(s): Failed to lookup sumbol 'poseidon_hash2':dlsym(RTLD_DEFAULT, poseidon_hash2):symbol not found
This error also causes a white screen in iOS..

Set minimum deployment target to 14.0. Just cloned the repository from develop branch, followed the readme instructions and successfully run the example app in debug mode on ios simulator and in release mode on real device. Closing issue.


Model search is painfully slow in dropdowns

When searching for buildings in dropdowns (for example when creating a LOS or editing a node), the results are painfully slow to load (often 10+ seconds)
These should be at least as fast as our Building search (around 3-4 seconds)

This appears to be not limited to just buildings. Searching member objects when creating installs is also super slow


Removed MTC-related functionality from common restore plugin.

This will be re-introduced in a new plugin on the oadp-1.0 branch.
Once merged, this should be cherry-picked to oadp-1.0.

Cherry-pick to oadp-1.0 won't be necessary since I've cherry-picked this commit into https://github.com/openshift/openshift-velero-plugin/pull/169
That PR removes MTC-related code from common restore plugin but also adds it back in to a new restore plugin that runs on every resource (only for oadp-1.0)


py import HF ignoring version for URI

Describe the bug
allegedly version is not used correctly in URI resolution in 2 places.
To Reproduce
Steps to reproduce the behavior:
from model_registry import ModelRegistry

registry = ModelRegistry(server_address=...

hf_model = registry.register_hf_model(
    "tarilabs/mnist",  # HF repo
    "mnist.onnx",
    version="v1.nb20231206162408",
    model_name="mnist-hf-tarilabs-1",
    description="using this for demo purposes",
    model_format_name="onnx",
    model_format_version="1",
)

result in ModelArtifact with URI:
    "uri": "https://huggingface.co/tarilabs/mnist/resolve/main/mnist.onnx"

result in ModelVersion with property:
      "source_uri": {
        "string_value": "https://huggingface.co/tarilabs/mnist/resolve/main/mnist.onnx"
      }

Expected behavior
URI was expected to be including the version.
Possibly something like:
https://huggingface.co/tarilabs/mnist/resolve/v1.nb20231206162408/mnist.onnx

maybe?
Additional context
n/a
cc/ @isinyaaa wdyt?

@tarilabs have you tried using git_ref? version is meant IMO as the import version, i.e. how the user wants to label the imported version.

Might be I've indeed forgot about it. Thank you for the reminder !

This worked as expected
from model_registry import ModelRegistry

registry = ModelRegistry(server_address="...

hf_model = registry.register_hf_model(
    "tarilabs/mnist",  # HF repo
    "mnist.onnx",
    version="v1.import",
    model_name="zzztest-1",
    description="using this for demo purposes",
    model_format_name="onnx",
    model_format_version="1",
    git_ref="v1.nb20231206162408", # <-- change
)

resulting in
demo20231121 % curl --silent -X 'GET' \
  "$MR_HOSTNAME/api/model_registry/v1alpha1/registered_models?pageSize=100&orderBy=ID&sortOrder=DESC&nextPageToken=" \
  -H 'accept: application/json' | jq .items
[
  {
    "createTimeSinceEpoch": "1707148271417",
    "customProperties": {},
    "id": "5",
    "lastUpdateTimeSinceEpoch": "1707148271417",
    "name": "zzztest-1",
    "state": "LIVE"
  },
...
]
demo20231121 % curl --silent -X 'GET' \
  "$MR_HOSTNAME/api/model_registry/v1alpha1/registered_models/5/versions?pageSize=100&orderBy=ID&sortOrder=DESC&nextPageToken=" \
  -H 'accept: application/json' | jq .items
[
  {
    "author": "tarilabs",
    "createTimeSinceEpoch": "1707148271814",
    "customProperties": {
      "license": {
        "string_value": "apache-2.0"
      },
      "model_author": {
        "string_value": "tarilabs"
      },
      "model_origin": {
        "string_value": "huggingface_hub"
      },
      "repo": {
        "string_value": "tarilabs/mnist"
      },
      "source_uri": {
        "string_value": "https://huggingface.co/tarilabs/mnist/resolve/v1.nb20231206162408/mnist.onnx"
      }
    },
    "description": "using this for demo purposes",
    "id": "6",
    "lastUpdateTimeSinceEpoch": "1707148271814",
    "name": "v1.import",
    "state": "LIVE"
  }
]
demo20231121 % curl --silent -X 'GET' \
  "$MR_HOSTNAME/api/model_registry/v1alpha1/model_versions/6/artifacts" \
  -H 'accept: application/json' | jq .items
[
  {
    "artifactType": "model-artifact",
    "createTimeSinceEpoch": "1707148272315",
    "customProperties": {},
    "id": "3",
    "lastUpdateTimeSinceEpoch": "1707148272315",
    "modelFormatName": "onnx",
    "modelFormatVersion": "1",
    "name": "zzztest-1",
    "state": "UNKNOWN",
    "storagePath": "mnist.onnx",
    "uri": "https://huggingface.co/tarilabs/mnist/resolve/v1.nb20231206162408/mnist.onnx"
  }
]

sorry for the noise; I only wished online jupyter did context assist, it would have helped me notice my mistake earlier


Device Request - [_TZE200_vvmbj46n] - [Tuya] / [TS0601]

Prerequisites:

Before requesting a device addition, please ensure there is not already a request for the device among the open issues.
Make sure your Homey is upgraded to firmware v5 or higher.
You need a physical example of the device.

Device Information

Device Name: _TZE200_vvmbj46n
Device Model: TS0601
Device Description: Temperature & Humidity Sensor
Link to device image: https://fr.aliexpress.com/item/1005005923865974.html?gatewayAdapt=glo2fra

Device Interview
{
"id":67,"type":"EndDevice","ieeeAddr":"0xa4c138a978038dbe","nwkAddr":21189,"manufId":4417,"manufName":"_TZE200_vvmbj46n","powerSource":"Battery","modelId":"TS0601","epList":[1],"endpoints":{"1":{"profId":260,"epId":1,"devId":81,"inClusterList":[4,5,61184,0],"outClusterList":[25,10],"clusters":{"genBasic":{"attributes":{"65503":"l ,\u0011","65506":56,"65508":0,"65534":0,"modelId":"TS0601","manufacturerName":"_TZE200_vvmbj46n","powerSource":3,"zclVersion":3,"appVersion":72,"stackVersion":0,"hwVersion":1,"dateCode":""}}},"binds":[],"configuredReportings":[],"meta":{}}},"appVersion":72,"stackVersion":0,"hwVersion":1,"dateCode":"","zclVersion":3,"interviewCompleted":true,"meta":{"configured":-1440156621},"lastSeen":1700109974399,"defaultSendRequestWhen":"immediate"
}
I´ve tryed everthing to inerview the device ... but found the device in a other forum.
This information was found on this link:
https://github.com/Koenkk/zigbee2mqtt/issues/19731
Additional Comments:

Note: Provide any other relevant information or requests related to the device. Link to where you bought the device can be of help

How to interview a device

Add the device as a generic Zigbee device in Homey
Navigate to https://developer.athom.com/tools/zigbee.
Interview the device, the button for this is to the right of the device in the list of Zigbee units.
Click the copy button/icon to capture the device information.
Paste the copied information above.

Note: To be able to add more devices to the Tuya Zigbee app, we rely on community members like you to provide interviews of the devices you want to be added. Thank you for your contribution!

Hi @JCHRA007, this device is already supported by the test version of the app: https://homey.app/en-us/app/com.tuya.zigbee/Tuya-Zigbee/test/


Fix: Snapshot upload form validation

Checklist

[ ] make tests passes (is also automatically run by Github Actions)
[x] documentation is changed or added

Affected components

vue/src/components/SnapshotEdit.vue

Description of change

Adds

Validation rule for municipality input

Fixes

Validation rule for file input

@apttx please have a look at the merge conflicts


fixed missing .Elem() in Decoder.Decode()

Bump @holykol, I believe this solves issue https://github.com/near/borsh-go/issues/20


Upgrade to CSL v11.0.0-beta.1

Closes https://github.com/Plutonomicon/cardano-transaction-lib/issues/565
Changes:

Rewrote Plutus.Conversion.Address code using CSL functionality.
Some conversion functions now return the result without the Maybe context:

fromPlutusAddress :: Csl.NetworkId -> Plutus.Address -> Csl.Address
fromPlutusAddressWithNetworkTag :: Plutus.AddressWithNetworkTag -> Csl.Address
fromPlutusTxOutput :: NetworkId -> Plutus.TransactionOutput -> Cardano.TransactionOutput
fromPlutusTxUnspentOutput :: NetworkId -> Plutus.TransactionUnspentOutput -> Cardano.TransactionUnspentOutput
fromPlutusUtxoM :: NetworkId -> Plutus.UtxoM -> Cardano.UtxoM

Changed the underlying type of Slot, TransactionIndex and CertificateIndex to BigNum and utilized new CSL functions that work with SlotBigNum instead of the deprecated Slot32 (u32).

Removed protocol param update setters for the "decentralisation constant" (set_d) and the "extra entropy" (set_extra_entropy), since these two parameters are removed in the Babbage HF.

Pre-review checklist

[x] All code has been formatted using our config (make format for Purescript, nixpkgs-fmt for Nix)
[x] All Purescript imports are explicit, including constructors
[ ] All existing examples have been run locally against a fully-synced testnet node
[ ] The integration and unit tests have been run (npm run test) locally
[ ] The changelog has been updated under the ## Unreleased header, using the appropriate sub-headings (### Added, ### Removed, ### Fixed)

@errfrom You should open this PR against the vasil branch

I'd prefer not to hold this up on the AbsSlot question -- can we open another issue for that instead @vvtran @errfrom?

I think that's reasonable, I'll open an issue @ngua

@errfrom  do let me know when it's ready for the review again as this is a priority, importantly, we should  check the examples still work for Alonzo testnet.

@vvtran All examples except AlwaysSucceeds work, on which I get a feeToSmall error, investigating it now