Improve peer review feature quality

Summary:
After #2602 is merged #2253 is completed. Now some quality issues from hackathon still needs to be fixed.

[ ] Code style issues
[ ] It scrolls, I would prefer static
[ ] Images moves on swipe, just questions should move instead
[ ] A beta alert should be added somewhere
[ ] Make image clickable - Open media details activity when clicked.
[ ] Not showing the categories peer review screen for the images having zero categories.
[ ] Or let the user categorize the image.
[ ] Adding a question mark next to "skip this image" button and Peer Review title which will display an explanation about their usage.
[ ] Refactor asynctasks to Rxjava implementation
[ ] Write unit tests with kotlin
[ ] Optimize randomizer

I am willing to work on some of them. But we can share, anyone wants to work on them please comment down.

Hey @neslihanturan I would like to work on this Issue

Hi @vanshikaarora , thanks for your interest. Do you have other tasks on you? If so I would recommend finish them first. Otherwise, would you like to write unit tests for this task?

@neslihanturan I have some PR's up for review until then I can work on this.

Sure, then I assign "Write unit tests with kotlin" to you? Does it sound good?

Yes I will. It would be good if you can tell me specifically about some of the tests that we need to check :)

Following this conversation can be helpful -> #2253 . We have whole workflow there, can help you to understand what we expect from the peer review activity.

Currently I see three test cases:

Answering the questions(clicking on the bottom button) should take us to next view pager
On answering the last question view pager should come to first and load the next image
3.On pressing next reload image and return to the first element of viewpager

@neslihanturan Can you add more to the list :)

All of the requests and their answers from server.
Test for  the randomizer query

I just recognized, actually tests can be complex for this feature. Even though  with your previous contributions you have proven that you can handle it, still you can always pick another thing from the list, I can pick the tests too. What about

Images moves on swipe, just questions should move instead
or
Refactor asynctasks to Rxjava implementation?

They are fairly complex too, but at leats easier to define the scope. I was planning to claim them but we can exchange (tests to me, other 2 to you), what do you say @vanshikaarora ?

They are fairly complex too, but at leats easier to define the scope. I was planning to claim them but we can exchange (tests to me, other 2 to you), what do you say @vanshikaarora ?

@neslihanturan since I think that's fair enough. Since for writing test cases it will take me time to be familiar with the changes in the code.
I'll start with the other two tasks :+1:

Great:) Do you need more explanation with your 2 tasks?

@neslihanturan To add to the list, the recent changes API can be moved to JSON. As of now, we are fetching an XML response. I would like to pick this up.

Also, theres a lot of commented out code in various places. Am removing it.

Thanks @maskaravivek ! I am assigning you for code style in general and moving to JSON.

Do you need more explanation with your 2 tasks?

@neslihanturan As part of one of my work I am supposed to replace the classes SendThankTask.java and CheckCategoryTask.java to their corresponding RxJava implementation. Right?

Refactor asynctasks to Rxjava implementation
Images moves on swipe, just questions should move instead

@neslihanturan I have solved the above two issues in #2707 and #2709. Kindly review and share your feedbacks :)

Hey @neslihanturan can you assign me more tasks from this list?

Make image clickable - Open media details activity when clicked.
Not showing the categories peer review screen for the images having zero categories.

Hey @neslihanturan Shall I pickup these two?

Make image clickable - Open media details activity when clicked.
Not showing the categories peer review screen for the images having zero categories.

Hey @neslihanturan I can pick these two task.

Hey @domdomegg I was working on some other Issue's enlisted here. If those issues still need to be fixed can you please reopen this Issue :)

Not showing the categories peer review screen for the images having zero categories.

Hey @neslihanturan I have solved the above Issue here. Kindly review :)

Adding a question mark next to "skip this image" button and Peer Review title which will display an explanation about their usage.
Hello, @neslihanturan
Can I take issue ?
I was woking on this and had almost completed this task. Can I make PR for this ?
Thank you!

Sure @silkypriya , thanks:)

Currently on clicking the image it does nothing. IMO we should show the user the media details on clicking the image same as we do for explore and contributions fragment.
Please continue this suggestion from here @sp2710 :)

Hello @domdomegg @neslihanturan ,
I have used  ic_help_black_24dp with tint attribute. Shall I change that to info icon ?
Made PR #2783.
Kindly review
Thank you!

I have used ic_help_black_24dp with tint attribute. Shall I change that to info icon ?

I think it might be better to use the info icon given we use it in the rest of the app for the same purpose - we should be consistent.

@neslihanturan I am picking #2763

Hello @neslihanturan
Peer Review activity layout does not support different screen sizes.
Can we add this in the above listed issues ?

Currently
Expected

I am adding, thanks @silkypriya

Hello @neslihanturan,
Fixed the issue mentioned in last comment in #2811
Kindly Review.
Thank you!

Optimize randomizer

@neslihanturan Why do we have such a complex logic for randomizer? Can't we randomly pick one revision from the list?

@maskaravivek can you explain more what do you indicate by complex? At the end of the day our purpose is selecting from recently uploaded mobile uploads.

@maskaravivek can you explain more what do you indicate by complex? At the end of the day our purpose is selecting from recently uploaded mobile uploads.

Oh sorry, I didn't realize that we are trying to select an image uploaded from mobile. But now I am confused that how are we actually filtering mobile uploads. Can you briefly explain the process?

I marked many of the issues as fixed, and the rest have been made not so relevant anymore, due to related changes.
Thus I think this can be closed.
Thanks everyone for your hard work! :-)


add deploy_doc workflow

In this PR, @MatteoRobbiati and I have added the workflow to deploy the github pages of Qibolab
Checklist:

[ ] Reviewers confirm new code works as expected.
[ ] Tests are passing.
[ ] Coverage does not decrease.
[ ] Documentation is updated.

Same as qibocal: if superseded, close this @Edoardo-Pedicillo


shutdown command is delayed

In latest OS releases (2.44.0+rev1) the shutdown command takes a while to complete.

I had the same observation.
I talked to a Balena supporter who pointed me to this, so I will repeat my observations:
Rebooting my devices has started to take looooong time. Around 2 minutes from the reboot command until the device is seen again. It seems to be the shutdown phase that is the bottleneck.
The problem is observer when I press "Reboot" in the Balena dashboard. It is NOT observed when just pressing "Restart". It is also observed when commanding a shutdown through the supoervisor API.
Here is a Balena log snippet showing the 2 minute delay:
07.11.19 12:10:41 (+0100) Killing service 'main sha256:309970af6fc68d72532a9d10a7a6647530430b9f8217b714d4c5ce44f9ab1f34'
07.11.19 12:10:47 (+0100) Killed service 'main sha256:309970af6fc68d72532a9d10a7a6647530430b9f8217b714d4c5ce44f9ab1f34'
07.11.19 12:10:47 (+0100) Rebooting
07.11.19 12:10:47 (+0100) Service exited 'main sha256:309970af6fc68d72532a9d10a7a6647530430b9f8217b714d4c5ce44f9ab1f34'
07.11.19 12:12:53 (+0100) Supervisor starting

@krixkrix traced it to a systemd service upstream. More detail here
https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/meta/recipes-support/rng-tools?h=warrior&id=95632e679df13fd5a45725e3752c49986ed2fe73
internal ref
https://www.flowdock.com/app/rulemotion/resin-devices/threads/rI2F9FgFxfjjfv2IK7wuTfUfvyI
bash one-liner via hostOS
exercise caution
mount -o remount,rw / && \
sed -i 's/Before=sysinit.target/Before=sysinit.target shutdown.target\nConflicts=shutdown.target/g' /lib/systemd/system/rngd.service /lib/systemd/system/rngd.service.new && \
mv /lib/systemd/system/rngd.service.new /lib/systemd/system/rngd.service && \
systemctl daemon-reload && \
mount -o remount,ro /

Fixed by https://github.com/balena-os/balena-intel/pull/261


Update metafile

@ZwwWayne

Note for future: if the change is not ready and subject to change, mark it as WIP to prevent accidental merge


Enable Checkstyle rules for @author, tabs and license header

Fixed related issues for new rules checks to pass

@nmirasch :)

+1

We should do the same in all the other repos as well. Any volunteers? :)


NIFI-6715: Fixing user table identifier

NIFI-6751:

Fixing the identifier on the user table. In a previous task, this was changed to utilize the URI but that does not work with other code interacting with this table.

reviewing...

Accidentally transposed the numbers the JIRA. This effort is for NIFI-6751.

This has been merged, thanks @mcgilman


Add file cache restore logic

Description

Add support to restore the file cache on node bootstrap

Issues Resolved

Resolves #5980

Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff
[x] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #6538 (0ac19cc) into main (8c0e5d0) will decrease coverage by 0.04%.
The diff coverage is 60.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##               main    #6538      +/-   ##
============================================
- Coverage     70.77%   70.74%   -0.04%
- Complexity    59125    59126       +1
============================================
  Files          4804     4804
  Lines        283098   283128      +30
  Branches      40813    40813
============================================
- Hits         200372   200306      -66
- Misses        66269    66387     +118
+ Partials      16457    16435      -22

Impacted Files
Coverage Δ

...x/store/remote/filecache/FileCachedIndexInput.java
50.00% <33.33%> (-5.56%)
:arrow_down:

...search/index/store/remote/filecache/FileCache.java
84.61% <75.00%> (-6.69%)
:arrow_down:

.../main/java/org/opensearch/env/NodeEnvironment.java
75.60% <100.00%> (-0.96%)
:arrow_down:

...ava/org/opensearch/action/NoSuchNodeException.java
0.00% <0.00%> (-50.00%)
:arrow_down:

...a/org/opensearch/tasks/TaskCancelledException.java
50.00% <0.00%> (-50.00%)
:arrow_down:

.../opensearch/client/indices/CloseIndexResponse.java
42.50% <0.00%> (-48.75%)
:arrow_down:

...opensearch/persistent/PersistentTasksExecutor.java
22.22% <0.00%> (-44.45%)
:arrow_down:

...adcast/BroadcastShardOperationFailedException.java
55.55% <0.00%> (-44.45%)
:arrow_down:

...cluster/coordination/PublishClusterStateStats.java
33.33% <0.00%> (-37.51%)
:arrow_down:

...n/admin/indices/readonly/AddIndexBlockRequest.java
35.71% <0.00%> (-35.72%)
:arrow_down:

... and 456 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Token response should enforce DPoP token_type

https://github.com/mary-ext/atcute/blob/trunk/packages%2Foauth%2Fbrowser-client%2Flib%2Fagents%2Fserver-agent.ts#L114
Atproto spec requires use of DPoP tokens. Anything else should be rejected.

You're right, I need to enforce that


Bringing attrs to Native as well

I realised when doing #518 that attrs hadn't been added to StyledNativeComponent. So this is a first pass, but needs someone to pick up who actually uses ReactNative to make sure I haven't misunderstood anything.

@geelen Shall we merge this? I can update the native implementation of StyledComponent to match the web one afterwards

As discussed I'll redo this on #714


Add "Edit" button to public profile - if user is looking at their own profile

If user is looking at their own profile, add an edit button that redirects to /profile.

this page is used to preview a user's profile.  (It is also used to look at somebody else's profile if that profile is public.)  This enhancement would be for the first situation.


Different aws bucket for watermark and interpolator support

Hello, I want to use a watermark image that is located in a different private AWS bucket. Is it feasible.
Also, is there an option to specify an interpolator to use while downsizing

You can specify different credentials for both S3 Loader and S3 Storage.  You may configure S3 Storage for normal images, then a different S3 Loader with the private AWS bucket.

That worked!. Thanks for the tip

You can specify different credentials for both S3 Loader and S3 Storage. You may configure S3 Storage for normal images, then a different S3 Loader with the private AWS bucket.
https://github.com/cshum/imagor#different-aws-credentials-for-s3-loader-storage-and-result-storage


Correctly handle pod deletion

When pilot receives pod deletion event, the pod ip has been already reclaimed.
In this case , below can never called.
		case model.EventDelete:
			// delete only if this pod was in the cache
			if pc.keys[ip] == key {
				delete(pc.keys, ip)
				if pc.c != nil && pc.c.XDSUpdater != nil {
					pc.c.XDSUpdater.WorkloadUpdate(ip, nil, nil)
				}
			}
		}

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hzxuzhonghu
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS [hzxuzhonghu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hzxuzhonghu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
ca2c8c433d7c70d3c1655750242e194eabe76211
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn please take a look

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
1539b1a145313509412724193ba4baad1b99209f
link
/test istio-integ-k8s-tests

prow/integ-pilot-k8s-presubmit-tests.sh
17600ab644810b497c7febc0feff7effab5aa73c
link
/test integ-pilot-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
1539b1a145313509412724193ba4baad1b99209f
link
/test istio-integ-k8s-tests

prow/integ-pilot-k8s-presubmit-tests.sh
17600ab644810b497c7febc0feff7effab5aa73c
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
17600ab644810b497c7febc0feff7effab5aa73c
link
/test integ-security-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-pilot-k8s-presubmit-tests.sh
17600ab644810b497c7febc0feff7effab5aa73c
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
17600ab644810b497c7febc0feff7effab5aa73c
link
/test integ-security-k8s-presubmit-tests-master

prow/istio-integ-k8s-tests.sh
17600ab644810b497c7febc0feff7effab5aa73c
link
/test istio-integ-k8s-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/assign @rshriram

this cause mem leak

This may not cause xds push, when a new pod comes up in case the new pod ip is same as a deleted one.

can you clarify what you mean by "This may not cause xds push, when a new pod comes up in case the new pod ip is same as a deleted one."? We recently found that a pod crash looping (going from 0 to 1 endpoints repeatedly) will trigger a full push excessively. Will this fix that issue?

If a new pod with same labels and same ip occurs, we expect it to trigger full xds push. But now it will nor.

We recently found that a pod crash looping (going from 0 to 1 endpoints repeatedly) will trigger a full push excessively. Will this fix that issue?

I am not sure what's your case, but maybe you can try with this.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hzxuzhonghu, rshriram
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS [hzxuzhonghu,rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-pilot-k8s-presubmit-tests.sh
17600ab644810b497c7febc0feff7effab5aa73c
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
17600ab644810b497c7febc0feff7effab5aa73c
link
/test integ-security-k8s-presubmit-tests-master

prow/istio-integ-k8s-tests.sh
17600ab644810b497c7febc0feff7effab5aa73c
link
/test istio-integ-k8s-tests-master

prow/e2e-simpleTests.sh
8ae573027160d8db2cb27e68fa5ca674156e7ae6
link
/test e2e-simpleTests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-simpleTests-master


fix(cache): add check for redis empty results in deleteMatching

Description
The deleteMatching implementation for the RedisHandler is not deleting all matching cache items as intended.
This PR is meant to fix that bug and fix the tests that were supposed to fail.
Also, the deleteMatching method now returns the number of deleted items as it is offers better feedback than true/false (mainly for testing purposes).
Thanks to @benjaminbellamy for the heads up!
Checklist:

[x] Securely signed commits
[x] Component(s) with PHPdocs
[ ] Unit testing, with >80% coverage
[x] User guide updated
[x] Conforms to style guide

Thank you, @yassinedoghri


The steps on the PowerBI page have changed slightly

Needed a clarification here as the PowerBI page does not say the exact words in this article, but there are two similarly worded links. One downloads PowerBI Desktop and so that is not the correct link to click. Updated wording to make this clear.

@JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks.

@pebaum - PR has been copy edited and is ready for final review.
Thank you.
cc: @kenwith


Update ordered-imports rule: add default grouping

PR checklist

[ ] Addresses an existing issue: #0000
[X] New feature, bugfix, or enhancement

[X] Includes tests

[X] Documentation update

Overview of change:
Added an extra options to ordered-imports to enforce grouping by libraries, parent directories & the current directory.
Is there anything you'd like reviewers to focus on?
Should the grouping fix clear the sorting fixes?

CHANGELOG.md entry:

[new-rule-option] "grouped-imports" for ordered-imports rule

@adidahiya @ajafff what's the status on this?

Love it, thanks.


Shape and Slice independent Storage and Persistence

Is it possible to add persisted data structures where persistence is independent of  shape and slicing. Also being able to persist and load data fast. In case of streaming data ensure that on crash data beyond a certain point is not lost.
Basically you can have some data structures which act like DBs.

This should be in a dedicated package related to persisted data, not in xtensor. Then an adaptor to xtensor expression system can be made (again in a package dedicated to persisted data, not here).


Docker events command do not work after 15 minutes

Description of problem:
I'm using "docker events" command to monitor docker events in real time. After about 15 minutes, I don't see any docker events even though I am running commands like docker run etc. Note that I am using docker over TCP port.
I wrote a Java code which uses Apache HTTP Client found that even apache client doesn't see any data from the docker TCP server. I then ran Wireshark and can confirm that there are no packets are getting sent by docker TCP server for the HTTP connection docker event command creates.
docker version:
Client version: 1.7.1
Client API version: 1.19
Go version (client): go1.4.2
Git commit (client): 786b29d
OS/Arch (client): windows/amd64
Server version: 1.8.1
Server API version: 1.20
Go version (server): go1.4.2
Git commit (server): d12ea79
OS/Arch (server): linux/amd64
docker info:
Containers: 163
Images: 128
Storage Driver: aufs
Root Dir: /var/lib/docker/aufs
Backing Filesystem: extfs
Dirs: 454
Dirperm1 Supported: true
Execution Driver: native-0.2
Logging Driver: json-file
Kernel Version: 3.16.0-4-amd64
Operating System: Debian GNU/Linux 8 (jessie)
CPUs: 1
Total Memory: 1000 MiB
Name: XXX
ID: XXX
WARNING: No memory limit support
WARNING: No swap limit support
uname -a:
1 SMP Debian 3.16.7-ckt11-1 (2015-05-24) x86_64 GNU/Linux
Environment details (AWS, VirtualBox, physical, etc.):
Server- Digital Ocean
How reproducible:
Always
Steps to Reproduce:

Run docker events command
Perform some docker events e.g. run, delete etc
Wait for 15 minutes

Actual Results:
docker event command no longer shows new events after 15 minutes
Expected Results:
Docker events command should always show docker events
Additional info:

@redlockio Could you try to connect another client to docker events when this occured? Also could you try unix socket? Thanks!

@LK4D4  yes, I've two clients connected- one using apache HTTP client and another client is standard docker client. I will try with unix sockets too. thanks

I'll try to reproduce tomorrow too.

Thanks. I just verified that if events keep flowing in, docker events command work just fine. I wrote following script to generate events every 1 second-
#!/bin/bash
while :
do
echo "Press [CTRL+C] to stop.."
./docker -H tcp://ip:port run some-image
sleep 1
done
docker client running on windows was able to show events for more than three hours. So I stopped the script and didn't generate any event for 20 minutes. When I started the script again, docker events command didn't work.
So to summarize, the issue occurs when no event has been generated for 15-20 minutes.

@redlockio I'm trying right now.

It worked for me. I wonder if it's something with tcp timeouts. So servers side socket is just silently closed.

thanks for trying out, I am monitoring state of the socket via netstat command right now and will update this thread with my findings.

I can confirm that TCP socket is still in established state after 20 minutes. I am monitoring data through wireshark but don't see any packets coming in from the socket attached to the tcp connection created by docker events command.
This could perhaps be an environment issue. I am running Docker daemon on digital ocean. Let me try and see what happens with EC2 and Google compute.

I've seen this sort of thing with other long-lived sockets when going through a masquerading NAT.  You mention Windows on the client side, and DigitalOcean.  What's the layout?  Have you tried running docker events on the DigitalOcean side?  This SO comment describes pretty well what I've seen: http://stackoverflow.com/questions/1480236/does-a-tcp-socket-connection-have-a-keep-alive/1480267#1480267

@bprodoehl you may be onto something thing. I am running docker client on Windows at my home machine and the server is far away in digitial ocean. Let me see what happens when everything is within a same network so that there are no routers involved.

@redlockio can you keep us posted when you had the time to test this locally? Thanks!

Any news?

Sorry about the delay in responding. I can confirm that when there is no
router/gateway etc in between docker daemon and client listening on events,
everything works fine.
On Fri, Oct 2, 2015 at 11:36 AM, Brian Goff<EMAIL_ADDRESS>wrote:

Any news?
—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/issues/15874#issuecomment-145117913.

Thanks, @redlockio! I'll close this issue then, because I think this is not a docker issue, but feel free to comment if you think I closed by mistake


Upgrade http gem to ~> 2.0 (drops Ruby 1.9 support)

Not sure if you're ready to drop Ruby 1.9 support or not, but I thought I'd get the ball rolling on this...

Yup, happy to drop Ruby 1.9 support in master. Thanks Tony!


Create image header component for product grid

Create a component to display the featured image of a tag or category.
Note: currently we do not have an operator UI for adding an image to a tag.

Add image url to tag schema
Add image url to graphql query schema
display image in grid as shown in designs if it exists
Use cover

@spencern @rymorgan
Is this header only going to be available on a tag page, or is it available on the default product grid as well?
And if available on the default grid, where should we store the image url in the schema?

Yes, the header will be only available to tagged pages. It should be fixed height that matches the height of product image containers and should be centered as it flexes responsively.

@kieckhafer
Agreed with Ryan.
The thought is that the default product grid is unlikely to be used once we've got merchandise-able pages that can handle both products and content. If we need to, prior to that point, we could leverage a "convention based" tag for the index so that it can display a image.


Setup test environment with gulp + mocha + chai

Add unit tests for issue #2

@KennethanCeyer Thank you for providing this useful package! It saved us a lot of work! So we want to contribute back. In this PR we added basic test setup.

Thank you @vlewin for contribution
And sorry i'm late to check it.
This PR will be picked to review right now.

Okay
this pr seem no problem to merge, review have been passed
thank you


ord: 0.20.0 -> 0.20.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/ordinals/ord/releases.
meta.description for ord is: Index, block explorer, and command-line wallet for Ordinals
meta.homepage for ord is: https://github.com/ordinals/ord
meta.changelog for ord is: https://github.com/ordinals/ord/blob/0.20.1/CHANGELOG.md
Updates performed

Rust version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.20.1 with grep in /nix/store/yqmczbf77k7hqgyzw86jixk6wc4j7kkg-ord-0.20.1
found 0.20.1 in filename of file in /nix/store/yqmczbf77k7hqgyzw86jixk6wc4j7kkg-ord-0.20.1

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

ord

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/yqmczbf77k7hqgyzw86jixk6wc4j7kkg-ord-0.20.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A ord https://github.com/r-ryantm/nixpkgs/archive/f625fac9c160af9c182908cab6bd24d3f3cfe7da.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/f625fac9c160af9c182908cab6bd24d3f3cfe7da#ord

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/yqmczbf77k7hqgyzw86jixk6wc4j7kkg-ord-0.20.1
ls -la /nix/store/yqmczbf77k7hqgyzw86jixk6wc4j7kkg-ord-0.20.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

ord

Maintainer pings
cc @xrelkd for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

@ofborg eval

@NixOS/nixpkgs-merge-bot merge


Add clarification on interactive root component remark

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
In the documentation discussing disabling pre-rendering it says:

Making a root component interactive, such as the App component, isn't supported. Therefore, prerendering can't be disabled directly by the App component.

It then goes on to say:

For apps based on the Blazor Web App project template, a render mode assigned to the entire app is specified where the Routes component is used in the App component (Components/App.razor). The following example sets the app's render mode to Interactive Server with prerendering disabled:

So it says you can't set this in App.razor. Then tells you to turn it off globally, set it to false in App.razor. This needs to say one or the other as both cannot be correct at the same time.
Expected Behavior
It should state that either prerendering can not be set in App.razor and it then shows an example of how to then set it in every top level component.
Or it should state that it can be set in App.razor and then keep the existing example.
Steps To Reproduce
Read the documentation
Exceptions (if any)
No response
.NET Version
8
Anything else?
No response

@javiercn That makes sense.
@guardrex I think adding javiercn's sentence to the documentation would resolve this issue.
thanks - dave

It's already resolved, and the update will probably go live by EOD. Thanks for the feedback on that point.


fix(): Useless assignment to local variable

Signed-off-by: Thomas SOËTE<EMAIL_ADDRESS>

CDS Report test#1039.0 ✘

tests and lint

golangci-lint ✘
unit-test and integration-tests ✔


Change to use interface instead of declare

Interface can extend class? Interesting.

lgtm

The docs are a bit thin but it makes sense. A class implicitly creates an interface.


Source Control UI gets cramped when there are lots of project folders

Here's my source control pane right now...  I'd rather it would just show a single project at once (with a dropdown at the top to switch between them, that syncs to the project containing the file in the active text editor)
Compounding the problem is the fact that removing a project folder from the workspace doesn't remove it from this list.  I only actually have 10 project folders in the workspace right now but there are over 20 source control providers in this accordion. (I think I've seen a separate issue for this)

Can you expand the Source Control Providers view and simply click on the repository you want to have visible?

oh thanks, nevermind, ever since collapsing it awhile ago I completely forgot about it


⚠ PrivateHD has degraded performance

In e1d31b4, PrivateHD ($PHD) experienced degraded performance:

HTTP code: 200
Response time: 2553 ms

Resolved: PrivateHD performance has improved in b42aac0.


Icons

Since, I don't have time to modify/complete the other branch https://github.com/blopker/superduper/pull/25 and I am kinda banned from taking the bike upstairs to continue development.
I have temporary created a separate branch to include Icons update to the widget.dart
Just to make it look nicer.

Cool, thanks!


running NewTerraform: rpc error: code = Unknown desc = no kind "Terraform"

Hi,
I've recently upgraded my environment and I started see this error trace in all my Terraform objects
running NewTerraform: rpc error: code = Unknown desc = no kind "Terraform" is registered for version "infra.contrib.fluxcd.io/v1alpha2" in scheme "pkg/runtime/scheme.go:100"
Let me share the version of my environment:
Kubernetes: v1.24.11-gke.1000 Flux: v2.0.0-rc.1 Weave GitOps: v0.23.0 image: ghcr.io/weaveworks/tf-controller:v0.15.0-rc.1 tf-controller chart helm in revision 	0.12.0
I also tried with Flux v2.0.0-rc.3 with same behaviour...

Could you try the image from the main branch?

Hi,
It seems it doesn't work fine, I only changed container image in tf-controller. Pod has started well and it's Running.  I also detected the old TLS secrets was removed but the Terrraform object doesn't work. Let me share some traces
{"level":"error","ts":"2023-05-21T15:11:42.105Z","msg":"Reconciliation failed after 15.10627237s, next try in 30s","controller":"terraform","controllerGroup":"infra.contrib.fluxcd.io","controllerKind":"Terraform","Terraform":{"name":"acc ount-liligo","namespace":"fluxcd-cloudflare"},"namespace":"fluxcd-cloudflare","name":"account-liligo","reconcileID":"9fe17a63-7949-4775-9bb8-aa01ded85a86","reconciliation-loop-id":"33ce6706-907b-4d0c-9ddf-37e51b0831a2","start-time":"2023 -05-21T15:11:26.999Z","revision":"main@sha256:59a9a96fa0f21bd713646873d89e2560dd0adbe4999d3c84c14a21dae3c206fd","error":"error running NewTerraform: rpc error: code = Unknown desc = no kind \"Terraform\" is registered for version \"infra .contrib.fluxcd.io/v1alpha2\" in scheme \"pkg/runtime/scheme.go:100\""}                                                                                {"level":"info","ts":"2023-05-21T15:11:47.345Z","logger":"cert-rotation","msg":"gc: scanning old TLS artifacts","namespaces":["fluxcd-cloudflare","flux-system"]}                                                                             {"level":"info","ts":"2023-05-21T15:11:47.345Z","logger":"cert-rotation","msg":"gc: found TLS artifacts","count":10}                                                                                {"level":"info","ts":"2023-05-21T15:11:47.352Z","logger":"cert-rotation","msg":"gc: successfully deleted old TLS Secret","namespace":"fluxcd-cloudflare","secret":"terraform-runner.tls-1684273966"}                                          {"level":"info","ts":"2023-05-21T15:11:47.360Z","logger":"cert-rotation","msg":"gc: successfully deleted old TLS Secret","namespace":"fluxcd-cloudflare","secret":"terraform-runner.tls-1684311606"}                                          {"level":"info","ts":"2023-05-21T15:11:47.368Z","logger":"cert-rotation","msg":"gc: successfully deleted old TLS Secret","namespace":"fluxcd-cloudflare","secret":"terraform-runner.tls-1684443115"}                                          {"level":"info","ts":"2023-05-21T15:11:47.375Z","logger":"cert-rotation","msg":"gc: successfully deleted old TLS Secret","namespace":"fluxcd-cloudflare","secret":"terraform-runner.tls-1684485163"}                                          {"level":"info","ts":"2023-05-21T15:11:47.384Z","logger":"cert-rotation","msg":"gc: successfully deleted old TLS Secret","namespace":"fluxcd-cloudflare","secret":"terraform-runner.tls-1683927461"}                                          {"level":"info","ts":"2023-05-21T15:11:47.394Z","logger":"cert-rotation","msg":"gc: successfully deleted old TLS Secret","namespace":"fluxcd-cloudflare","secret":"terraform-runner.tls-1684274206"}                                          {"level":"info","ts":"2023-05-21T15:11:47.401Z","logger":"cert-rotation","msg":"gc: successfully deleted old TLS Secret","namespace":"fluxcd-cloudflare","secret":"terraform-runner.tls-1684356064"}                                          {"level":"info","ts":"2023-05-21T15:11:47.408Z","logger":"cert-rotation","msg":"gc: successfully deleted old TLS Secret","namespace":"fluxcd-cloudflare","secret":"terraform-runner.tls-1684556881"}                                          {"level":"info","ts":"2023-05-21T15:11:47.417Z","logger":"cert-rotation","msg":"gc: successfully deleted old TLS Secret","namespace":"fluxcd-cloudflare","secret":"terraform-runner.tls-1684557943"}                                          {"level":"info","ts":"2023-05-21T15:11:47.425Z","logger":"cert-rotation","msg":"gc: successfully deleted old TLS Secret","namespace":"fluxcd-cloudflare","secret":"terraform-runner.tls-1684644643"}                                          {"level":"info","ts":"2023-05-21T15:11:47.425Z","logger":"cert-rotation","msg":"gc: finished deleting old TLS artifacts","count":10}

That's strange.
Do you have this value?
$ kubectl get crd/terraforms.infra.contrib.fluxcd.io -ojson | jq -r '.spec.versions[].name'
v1alpha1
v1alpha2

hi! I'm sorry... but yes....let me share...
$kubectl get pods -n flux-system tf-controller-6c6c7567f-fhv9s -o yaml | grep image
    image: ghcr.io/weaveworks/tf-controller:main-43830881
    imagePullPolicy: IfNotPresent
    image: ghcr.io/weaveworks/tf-controller:main-43830881
    imageID: ghcr.io/weaveworks/tf-controller@sha256:e2f22e18a195414d4e95f5d80e230d16d63dfb6d303d3c36341425c00dbb4a3f
$kubectl get crd/terraforms.infra.contrib.fluxcd.io -ojson | jq -r '.spec.versions[].name'
v1alpha1
v1alpha2
$tfctl -n flux-system get; tfctl -n fluxcd-cloudflare get
NAMESPACE       NAME                    READY   MESSAGE                                                                                PLAN PENDING    AGE
flux-system     init-fluxcd-cloudflare  False   error running NewTerraform: rpc error: code = Unknown desc = no kind "Terraform" is registered for version "infra.contrib.fluxcd.io/v1alpha2" in scheme "pkg/runtime/scheme.go:100"     false           3 days
NAMESPACE               NAME                                            READY   MESSAGE                                                                                PLAN PENDING    AGE
fluxcd-cloudflare       account-liligo                                  False   error running NewTerraform: rpc error: code = Unknown desc = no kind "Terraform" is registered for version "infra.contrib.fluxcd.io/v1alpha2" in scheme "pkg/runtime/scheme.go:100"     false           19 hours
fluxcd-cloudflare       secret-fluxcd-cloudflare-cloudflareapitoken     False   error running NewTerraform: rpc error: code = Unknown desc = no kind "Terraform" is registered for version "infra.contrib.fluxcd.io/v1alpha2" in scheme "pkg/runtime/scheme.go:100"     false           3 days
fluxcd-cloudflare       secret-fluxcd-cloudflare-datadogapikey          False   error running NewTerraform: rpc error: code = Unknown desc = no kind "Terraform" is registered for version "infra.contrib.fluxcd.io/v1alpha2" in scheme "pkg/runtime/scheme.go:100"     false           3 days
fluxcd-cloudflare       workspace-fluxcd-cloudflare                     False   error running NewTerraform: rpc error: code = Unknown desc = no kind "Terraform" is registered for version "infra.contrib.fluxcd.io/v1alpha2" in scheme "pkg/runtime/scheme.go:100"     false           3 days

finally the issue was in the runner image, i found an issue in my CI workflow, let me close the ticket and apologies for the time wasted

Hi @mcortinas ,whats root issue?I met the same issue with yours.


feat(chime): make the Chime notifier look up the failing action

More information == more better

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


PopulateObject: populating anonymous type instance

i just stumbled upon a use case where i want to fill a anonymous object with values coming from json:
var o = new { foo = "123", bar = "456" };
JsonConvert.PopulateObject(@"{'foo': 'abc'}", o);
Console.WriteLine(o.foo); // outputs "123" instead of "abc"

but it does not work as long as o is of anonymous type.

Anonymous objects don't have setters.

didn't know too much about anonymous types. there would be a way by modifying their backing fields but i guess you wouldn't want that it in the lib.

in any case, here's my workaround: https://dotnetfiddle.net/S4GPil


Workflow not loading

I'm trying to load the provided workflow but nothing loaded. Is this not a node tree for DZ-FaceDetailer?

I upload a new workflow in the last update, check if it working for you now, on my local repo is working.


Update design-tokens-example.json

I assume this was a mistake? If not please reopen with details.


Allow JWT/RBAC write access with payload filters, link to access table

The JWT/RBAC access settings dialog currently greys out the 'Payload Filters' section if write operations are checked.
Payload filters are supported when write access is enabled, and so it should not be greyed out when write access is selected.

To help clarify this, we might want to add a [Access table] link in the dialog.

The problem is this: if you disable write operations, you can edit the payload filters. If you then enable writes again, these filters stay. It feels hacky and makes it only more confusing.
I think we should choose one of:

allow payload filters with write operations
if enabling write operations, clear and grey out the payload filters


Updating a projection package version requires 2 rebuilds

App uses CsWinRT 1.2.5
App references a projection nuget version=0.1.0-prerelease. Make the nuget package reference an older CsWinRT like 1.0.0, this only matters so that we get a warning about mismatched versions (picking 1.2.5), and the warning prints out the version of the nupkg it picked.
Build the app
Generate a new projection nupkg, version=0.1.1-prerelease
Change the app to point to the 0.1.1-prerelease package
Build the app -> notice that it picks up the 0.1.0-prerelease according to the mismatch warning
Build the app again, now it picks up 0.1.1-prerelease

This sounds more like a nuget restore issue.  Are you planning to distribute your projection nuget separately from the app?  If not, you can simplify by just having the app generate and compile cswinrt projection sources directly.

yeah I think we will want to distribute the projection separately at some point, it's just a bit cumbersome to test things out

This doesn't seem like a CsWinRT issue - looks like a VS issue with nuget restore or not using the NuGet package manager UI to upgrade the version

Things to try @asklar

after changing to 0.1.1; right click the solution in Solution Explorer and select "Restore Nuget Packages For Solution
instead of manually editing the package reference, right click the project in Solution Explorer and select "Manage nuget packages" to update to 0.1.1 using the UI

Using the manage packages UI seems to work, though that's a bunch more clicks

@asklar if you can still repro this, do you mind filing an issue with more detailed repro steps, and possibly a repository that can reproduce this, over at https://github.com/nuget/home/issues/new?

Closing as this is not a CsWinRT issue


[FLINK-22573][datastream] Fix AsyncIO calls timeout on completed element.

What is the purpose of the change
As long as the mailbox is blocked, timers are not cancelled, such that a completed element might still get a timeout.
Brief change log
The fix is to check the completed flag when the timer triggers.
Verifying this change
Added AsyncWaitOperatorTest#testTimeoutAfterComplete.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

LGTM - assuming test failure is unrelated.
One last question, have you tried looping this test locally for a couple of hundred/thousands times, just to be sure?

I looped it 1k times successfully.


[image]: border knob doesn't add border

Description
No border shown in Image component

Component(s) impacted
Image
Browser
Chrome
Carbon for IBM.com version
1.31.0-rc.1
Severity
Severity 3 = The problem is visible or noticeable to users but does not impede the usability or functionality. Affects minor functionality, has a workaround.
Application/website
carbon for ibm.com
Package
@carbon/ibmdotcom-react
CodeSandbox example
https://carbon-design-system.github.io/carbon-for-ibm-dotcom/next/react/?path=/story/components-image--default
Steps to reproduce the issue (if applicable)

go to storybook:https://carbon-design-system.github.io/carbon-for-ibm-dotcom/next/react/?path=/story/components-image--default
check border knob

Release date (if applicable)
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I checked the current issues for duplicate issues

retest in other theme

works fine!


Initial Release - CF Restage All

Thank you for contributing to the CF CLI Plugin Repository!
This repo contains both the plugin repo server and the metadata for CLI
community plugins.
Some of the requirements for PRs will apply to only one of these parts.
We're not allowed to accept any PRs without a signed CLA, no matter how small.
If your contribution falls under a company CLA but your membership is not public, expect delays while we confirm.
Submitting Plugins
If you haven't yet, please review our contributing guidelines:
https://github.com/cloudfoundry/cli-plugin-repo#submitting-plugins
In particular ensure the following requirements are being met:

[ ] The plugin's name field in repo-index.yml matches the Name field in the plugin's plugin.PluginMetadata section
[ ] The plugin's url field in repo-index.yml contains the same version from the version field

Submitting PRs to CLIPR (the CLI Plugin Repo server)
All new code requires tests to protect against regressions.
Description of the Change
This is the initial launch of the restage all plugin. This allows for all applications (with filters) to be restaged within a particular space within a foundation. This was created out of a need from General Motors and wanted to share back with the general community.
Why Is This PR Valuable?
This allows for mass restaging within a PCF space. This is able to loop through all applications based on state and age of last droplet creation. This is important for buildpack refresh. Instead of running a restage command we are able to assign the droplet first and do a restart to help minimize downtime. We are currently using this within General Motors.
Applicable Issues
None
How Urgent Is The Change?
None
Other Relevant Parties
None

On behalf of the CF CLI team, I'd like to thank you for your open source contribution!
I have a question about implementation: I've noticed that on multiple occasions you're shelling out the curl command; for example here
	packageJSON, curlErr := cliConnection.CliCommandWithoutTerminalOutput("curl", "-X", "GET", packageCurlURL)

I'd like to better understand why you choose this approach and how that would affect portability?

On behalf of the CF CLI team, I'd like to thank you for your open source contribution!
I have a question about implementation: I've noticed that on multiple occasions you're shelling out the curl command; for example here
	packageJSON, curlErr := cliConnection.CliCommandWithoutTerminalOutput("curl", "-X", "GET", packageCurlURL)

I'd like to better understand why you choose this approach and how that would affect portability?

On behalf of the CF CLI team, I'd like to thank you for your open source contribution!
I have a question about implementation: I've noticed that on multiple occasions you're shelling out the curl command; for example here
	packageJSON, curlErr := cliConnection.CliCommandWithoutTerminalOutput("curl", "-X", "GET", packageCurlURL)

I'd like to better understand why you choose this approach and how that would affect portability?

@a-b
That approach was taken to leverage the cli curl commands. This allowed us to get additional information and data not available on the cli commands itself.

On behalf of the CF CLI team, I'd like to thank you for your open source contribution!
I have a question about implementation: I've noticed that on multiple occasions you're shelling out the curl command; for example here
	packageJSON, curlErr := cliConnection.CliCommandWithoutTerminalOutput("curl", "-X", "GET", packageCurlURL)

I'd like to better understand why you choose this approach and how that would affect portability?

@a-b
That approach was taken to leverage the cli curl commands. This allowed us to get additional information and data not available on the cli commands itself.

Oh, I see you're using /V3 CAPI. Thanks for clarifying.

Oh, I see you're using /V3 CAPI. Thanks for clarifying.


Use with private enterprise repository

Is there a way this  client library can be used for private enterprise repository ? e.g. GitHub.ent.com ?

yes, see github.NewEnterpriseClient.

thanks @willnorris


Issue #151 - Added CustomerCollection and refactored related endpoints

IBM Cloud toolchain: Delivery Pipeline deployed customers to dev, including commit 7789648e6b661fda9397801302a4192713f28113


configuration support

does @chrislusf  offer production configuration support for seaweedfs?

Maybe later.

Could I have an email address for you? my company would like to use
seaweedfs in a full production deployment
On Tue, Oct 25, 2016 at 11:45 AM, Chris Lu<EMAIL_ADDRESS>wrote:

Closed #379 https://github.com/chrislusf/seaweedfs/issues/379.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/chrislusf/seaweedfs/issues/379#event-835771111, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AH3qSM0mkTQSUNIemUvNGg37Yyx_Qx7_ks5q3jITgaJpZM4KgJcs
.

chris.lu at gmail dot com
On Tue, 25 Oct 2016 at 11:26 AM CheyenneForbes<EMAIL_ADDRESS>wrote:

Could I have an email address for you? my company would like to use
seaweedfs in a full production deployment
On Tue, Oct 25, 2016 at 11:45 AM, Chris Lu<EMAIL_ADDRESS>wrote:

Closed #379 https://github.com/chrislusf/seaweedfs/issues/379.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/chrislusf/seaweedfs/issues/379#event-835771111, or
mute
the thread
<
https://github.com/notifications/unsubscribe-auth/AH3qSM0mkTQSUNIemUvNGg37Yyx_Qx7_ks5q3jITgaJpZM4KgJcs
.

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/chrislusf/seaweedfs/issues/379#issuecomment-256125670,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABeL72Lx7O2-5en_pNwUL8RWO9QyUBajks5q3kmpgaJpZM4KgJcs
.

Did you get the email?

Did you get the email?


C# sylvan_native.dll

Hi, I'm a student.And I study BDD.  Your project is very good, this demo is nice.  When I  downLoad  demo, and frist start in my local computer. This  doesn't run. It's message that ### not found sylvan_native.dll.
Could you please share sylvan_native.dll ?   Thank you.

Looking forward your reply

From the look of it you need to build the C code in the native/ submodule
Sorry, I have not looked at this code for years. Hope you will be able to figure it out!


Make Forgot password as a linked text

I would expect to see something like this: https://stackoverflow.com/a/69549929/4256193
using ClickableText and buildAnnotatedString

I would expect to see something like this: https://stackoverflow.com/a/69549929/4256193 using ClickableText and buildAnnotatedString

What is the difference between what did I and this example? I mean in UI and functionality?

What is the difference between what did I and this example? I mean in UI and functionality?
As I understand, in your implementation text will change color after clicking on it, and change color back after the second click. But it shouldn't change color, it should just to show that text was clicked, like selector, when user clicks\focuses on the text we change the color.

I would expect to see something like this: https://stackoverflow.com/a/69549929/4256193 using ClickableText and buildAnnotatedString

done


Plot Tachogram Error

When I try to plot tachogram I get this error, please help.
tools.tachogram(signal, interval=[0, 15])

TypeError                                 Traceback (most recent call last)
 in
1 # Plot the Tachogram of the ECG signal (interval: 0s to 15s)
----> 2 tools.tachogram(signal, interval=[0, 15])
/opt/miniconda3/lib/python3.7/site-packages/pyhrv/tools.py in tachogram(nni, signal, rpeaks, sampling_rate, hr, interval, title, figsize, show)
373                 interval = [0, t[-1]]
374         else:
--> 375                 interval = pyhrv.utils.check_interval(interval, limits=[0, t[-1]], default=[0, 10])
376
377         # Prepare figure
/opt/miniconda3/lib/python3.7/site-packages/pyhrv/utils.py in check_interval(interval, limits, default)
228                 limits = default
229         elif limits is not None:
--> 230                 limits = _check_limits(limits, 'limits')
231
232         # Check interval limits
/opt/miniconda3/lib/python3.7/site-packages/pyhrv/utils.py in _check_limits(interval, name)
283                 interval[0], interval[1] = interval[1], interval[0]
284                 vals = (name, name, interval[0], interval[1])
--> 285                 warnings.warn("Corrected invalid '%s' limits (lower limit > upper limit).'%s' set to: %s" % vals)
286         if interval[0] == interval[1]:
287                 raise ValueError("'%f': Invalid interval limits as they are equal." % name)
TypeError: not all arguments converted during string formatting

Hi @cogitoxin,
thanks for using pyHRV!
I have caught the issue which was causing an error in the warning and error descriptions which this functions generates, which eventually (and ironically) was triggering this error.
This will be fixed with the next update, but if you want to go ahead and copy paste the corrected version of this function, feel free to use this one:
def _check_limits(interval, name):
	"""Checks if interval limits are not overlapping or equal.

	Parameters
	----------
	interval : array, 2-element
		Interval boundaries [min, max].
	name : str
		Variable name to be used on exceptions and warnings.

	Returns
	-------
	interval : array, 2-element
		Valid and corrected interval limits (if correction is necessary).

	Raises
	------
	ValueError
		If interval limits are equal.

	Warnings
	--------
	..	If limits are overlapping (e.g. lower limit > upper limit) and had to be fixed.

	"""
	# upper limit < 0 or upper limit > max interval -> set upper limit to max
	if interval[0] > interval[1]:
		interval[0], interval[1] = interval[1], interval[0]
		warnings.warn("The provided lower limit of the parameter '%s' is greater than the upper limit. Limits have been switched." % name)
	if interval[0] == interval[1]:
		raise ValueError("The provided lower and upper limits of the parameter '%s' are invalid as they are identical." % name)
	return interval


OCM-4535,OCM-4537 | feat: additional compute SGs day1/2

Related issues:

OCM-4535
OCM-4537

What
Provides option to supply additional compute security groups for the default worker machine pool (day1) as well as for future worker machine pools (day2)

/retest

/lgtm
@nirarg please review it as well

@nirarg

Also in the cluster resource you didn't use the else part

I didn't had any issues on the cluster side, but for the machine pool I kept getting errors if I didn't add this. I noticed other attributes in the cluster do not have the else either so I expect it would be somewhat standard. But I can check this to make sure

I didn't had any issues on the cluster side, but for the machine pool I kept getting errors if I didn't add this. I noticed other attributes in the cluster do not have the else either so I expect it would be somewhat standard. But I can check this to make sure

@gdbranco
I tested it locally:
I removed this else block and didn't assign any value to this variable in my manifest. I didn't get the error.
Can you please elaborate how you got the error?
We can have a call for this, if needed


Changes in org-plus-contrib

What's wrong
As indicated by a message to the org mailing list the contrib packages for org have been split off. Using org-plus-contrib as the package name with straight now pulls in the main org files but not the contrib ones. See also reddit discussion
The recommended sources for the install are now:

https://code.orgmode.org/bzg/org-mode.git files lisp/.el etc/styles/

https://git.sr.ht/~bzg/org-contrib files lisp/*.el

So the recipe returned by straight-recipes-org-elpa-retrieve must get code from two repos or org-plus-contrib must be split into two separate packages org and org-contrib
Directions to reproduce

Fresh emacs
Use (use-package org :straight org-plus-contrib ...)
The main org files are in straight/build but not the contrib files

Version information

Emacs version:
Operating system:

Please include the output of straight-version at a minimum when reporting bugs.
I posted the reddit thread you've linked.
The org-elpa recipe repo has been updated on the develop branch:
https://github.com/raxod502/straight.el/commit/9eb2e058665ad1144c66d2b1b816f9effa37907e
You'll need to update your config to make use of the "org-contrib" recipe. If you are not on the develop branch you can use the recipe from above manually (the change has not been backported to the master branch yet).


"Common Tasks" mentioned in TODO

This isn't an issue, per se, so much as an inquiry.  What tasks would be considered common/useful enough to provide such wrappers for?  I'd be happy to implement this child class, but I need to know what I'd be writing to do it.  Listed in the TODO already are:

Create VM
Create container
Change container settings

I can assume that I should also add (as it's implied)

Change VM settings

But what else should be supported?

Cool :)


new feature request: batch subfolder remover

Description of the new feature / enhancement
when I unzip files sometimes, the program will create a subfolder, then another subfolder of the same name, then another subfolder, then the files of interest.
I am interested in an easy way to simply get rid of superfluous subfolders that do absolutely nothing except extend directory paths.
I want a way of moving all the files from the last subfolder all the way up to the first subfolder and remove all the empty superflous subfolders in the middle.
Scenario when this would be used?
This happens a lot when a person uploads a zipped file then another person rezipps the zipped file then the other guy rezips the file. and it just becomes an unzipping fiasco with a bunch of extra subfolders that nobody wants.
For example if you go to a website like "thingiverse" and let's say you just binge-download a buncha 3d print files you  plan to get to print at some point, but then this idiotic website will not just give you the STLs directly into the root folder of a zip file, instead it will give you a zip file that has a subfolder called files, which then may or may not contain another subfolder that has the stls and or their variants.
What if you can just batch download a bunch of thingiverse zips into one Default downlads folder, then batch unzip them into their respective subdirectories, but then have PowerToys remove all these empty subdirectories, e.g. "Files", which is autogenerated by thingiverse, and just "clean up" or simplify your file exploring by reducing the number of clicks you have to make through a bunch of empty folders to get to the files of interest.
Like I said, this happens when people share files but then these files undergo multiple cycles of zipping/unzipping through modification cyles etc. Thingiverse is a perfect example.
Supporting information
No response

Long story short, "a file directory path shortener" that can do this as a batch operation.

If any subfolder name might contain useful information that may be lost by shortening the path (by moving the files from the last folder up to the first folder) then what can be done is take all the subfolder names and concatenate the subfoldernames into a single foldername and then apply this concatenated foldername into the first folder.

Pretty much #9269, am I right?

Yes, same thing but I would add the note that sometimes the subfolder names can be important. And maybe there should be the option to preserve that filename information as a file ID3 Tag/comment or as a concatenated filenename.

/dup https://github.com/microsoft/PowerToys/issues/9269


Allow to change the port for HTTPS for containers

Is your feature request related to a problem? Please describe.
Using the default HTTPS port, 443, might collide with other services running on localhost using the same port.
Describe the solution you'd like
I would like to be able to change the port for HTTPS for containers. So I can, for example, go to https://orb.local:1234 instead of https://orb.local:443
Describe alternatives you've considered
Change ports for local development outside of Orbstack, but sometimes, it makes things a little harder.
Additional context
None.

OrbStack domains don't occupy the localhost port space, so this isn't an issue.
Also, containers that already have a port 443 server will continue to work.

This was a problem for me in a beta version, but port 80 and with lower importance, 22, have the same problem, they are not listening on the virtual network.

Not sure what you mean. OrbStack doesn't take any ports on localhost (except for 32222 to expose SSH for machines). Containers have their own network namespaces with their own port spaces.
If a web service is detected in your container, then port 80 on that container's domain will be redirected to the web server's port.
If your container has a server on port 80 or 443, it will always take precedence over OrbStack's automatic logic. You can also disable HTTPS entirely in Settings > Network.
Machines won't listen on port 22 unless you install and run an SSH server. Containers have no special logic for port 22.

I meant adding options to configure common ports used by OrbStack, specifically if they are listening in all interfaces:
$ sudo lsof -i -nP +c 40 | grep -i orbstack
OrbStack\x20Helper                      50834         mariano   18u  IPv4 0xf6166f452215651d      0t0   ICMP *:*
OrbStack\x20Helper                      50834         mariano   19u  IPv6 0xf6166f451dde211d      0t0 ICMPV6 *:*
OrbStack\x20Helper                      50834         mariano   35u  IPv4 0xf6166f45250259cd      0t0    TCP <IP_ADDRESS>:32222 (LISTEN)
OrbStack\x20Helper                      50834         mariano   36u  IPv6 0xf6166f3b99b8885d      0t0    TCP [::1]:32222 (LISTEN)
OrbStack\x20Helper                      50834         mariano   37u  IPv4 0xf6166f4525054e6d      0t0    TCP <IP_ADDRESS>:54634 (LISTEN)
OrbStack\x20Helper                      50834         mariano   38u  IPv4 0xf6166f451e79754d      0t0    TCP *:80 (LISTEN)
OrbStack\x20Helper                      50834         mariano   40u  IPv4 0xf6166f452504b2fd      0t0    TCP *:443 (LISTEN)
OrbStack\x20Helper                      50834         mariano   42u  IPv4 0xf6166f451e7b1e5d      0t0    TCP <IP_ADDRESS>:54634-><IP_ADDRESS>:54635 (ESTABLISHED)
OrbStack\x20Helper                      50834         mariano   45u  IPv6 0xf6166f3b99b9305d      0t0    TCP *:80 (LISTEN)
OrbStack\x20Helper                      50834         mariano   47u  IPv6 0xf6166f3b99bab05d      0t0    TCP *:443 (LISTEN)
$ nc -l 443
nc: Address already in use
$ nc -l 80
nc: Address already in use

PS: I ❤ OrbStack

@maraino These listeners are there because you're running one of:

A container with port 80 or 443 forwarded
Kubernetes ingress on port 80 or 443
Port 80 or 443 server in a machine

OrbStack\x20Helper                      50834         mariano   38u  IPv4 0xf6166f451e79754d      0t0    TCP *:80 (LISTEN)
OrbStack\x20Helper                      50834         mariano   40u  IPv4 0xf6166f452504b2fd      0t0    TCP *:443 (LISTEN)
OrbStack\x20Helper                      50834         mariano   45u  IPv6 0xf6166f3b99b9305d      0t0    TCP *:80 (LISTEN)
OrbStack\x20Helper                      50834         mariano   47u  IPv6 0xf6166f3b99bab05d      0t0    TCP *:443 (LISTEN)

This is randomly assigned to a free port for internal use so it won't conflict:
OrbStack\x20Helper                      50834         mariano   37u  IPv4 0xf6166f4525054e6d      0t0    TCP <IP_ADDRESS>:54634 (LISTEN)

This is the only hard-coded port but it needs to be for compatibility and documentation purposes, and was chosen to minimize conflicts:
OrbStack\x20Helper                      50834         mariano   35u  IPv4 0xf6166f45250259cd      0t0    TCP <IP_ADDRESS>:32222 (LISTEN)
OrbStack\x20Helper                      50834         mariano   36u  IPv6 0xf6166f3b99b8885d      0t0    TCP [::1]:32222 (LISTEN)


Buff / Debuff Display on Raidframes

Hey,
since you added the option to track atonement (which I love!) the party & raidframes seem to be kinda buggy. That is extremly annoying on Tichondrius. The whole atonement display seems to vanish from time to time and debuffs wont be shown properly - so it is really hard to dispel peeps.
I feel like it has something to do with longer debuffs on party / raid members but I am not sure...
Cheers

bump? 💯

There's no buff/debuff options for raid/group frames and that's really frustrating. I stopped using this part of GUI as it wasn't fit for healing.


New user trial. -- per discussion with atapas

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist:

[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Hello @james-david-marks,  can you get yourself logged in at https://rgkjmwftqtbpayoyolwh.nhost.run/v1/auth/signin/provider/github. This will make sure that you are onboarded with reactplay and then the play that you added can be inserted into the list.

Hello @james-david-marks, can you get yourself logged in at https://rgkjmwftqtbpayoyolwh.nhost.run/v1/auth/signin/provider/github. This will make sure that you are onboarded with reactplay and then the play that you added can be inserted into the list.

To continue your development, I have temporarily added your play under my account so that it starts appearing in your playlist

. Let me know once your login/registration process is over, I will transfer it to your account.

Koustov,
Thank you. I went to the link and authorized my github account. I think everything is in order. Do I understand correctly that I will not see my play until I do a PR? Anyway, I see it now. As you have already advised, it says you are the author now. As you have also advised, you will change it now that I have onboarded. Thank you for addressing this.
Jim
From: Koustov
Sent: Sunday, July 17, 2022 12:17 AM
To: reactplay/react-play @.>
Cc: james-david-marks @.>; Mention @.***>
Subject: Re: [reactplay/react-play] New user trial. -- per discussion with atapas (PR #378)
Hello @james-david-marks https://github.com/james-david-marks , can you get yourself logged in at https://rgkjmwftqtbpayoyolwh.nhost.run/v1/auth/signin/provider/github. This will make sure that you are onboarded with reactplay and then the play that you added can be inserted into the list.
To continue your development, I have temporarily added your play under my account so that it starts appearing in your playlist
https://user-images.githubusercontent.com/7145967/179384942-ba47a8f4-458b-4ff3-a64c-cca51707b6a9.png
. Let me know once your login/registration process is over, I will transfer it to your account.
—
Reply to this email directly, view it on GitHub https://github.com/reactplay/react-play/pull/378#issuecomment-1186404961 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAY2BKWJ67XE3PE6APAZMDVUOJL5ANCNFSM53YJ7VSQ .
You are receiving this because you were mentioned.  https://github.com/notifications/beacon/ABAY2BIFBBVE4KJMWMP52NTVUOJL5A5CNFSM53YJ7VS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOI23RUYI.gif Message ID: @.*** @.***> >

Koustov, Thank you. I went to the link and authorized my github account. I think everything is in order. Do I understand correctly that I will not see my play until I do a PR? Anyway, I see it now. As you have already advised, it says you are the author now. As you have also advised, you will change it now that I have onboarded. Thank you for addressing this. Jim From: Koustov Sent: Sunday, July 17, 2022 12:17 AM To: reactplay/react-play @.> Cc: james-david-marks @.>; Mention @.> Subject: Re: [reactplay/react-play] New user trial. -- per discussion with atapas (PR #378) Hello @james-david-marks https://github.com/james-david-marks , can you get yourself logged in at https://rgkjmwftqtbpayoyolwh.nhost.run/v1/auth/signin/provider/github. This will make sure that you are onboarded with reactplay and then the play that you added can be inserted into the list. To continue your development, I have temporarily added your play under my account so that it starts appearing in your playlist https://user-images.githubusercontent.com/7145967/179384942-ba47a8f4-458b-4ff3-a64c-cca51707b6a9.png . Let me know once your login/registration process is over, I will transfer it to your account. — Reply to this email directly, view it on GitHub <#378 (comment)> , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAY2BKWJ67XE3PE6APAZMDVUOJL5ANCNFSM53YJ7VSQ . You are receiving this because you were mentioned. https://github.com/notifications/beacon/ABAY2BIFBBVE4KJMWMP52NTVUOJL5A5CNFSM53YJ7VS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOI23RUYI.gif Message ID: @. @.***> >

Firstly, you are welcome

Do I understand correctly that I will not see my play until I do a PR?: Not really, we can do this stem early also, anyway its a temporary step. We are making it automated and the beta testing is going on
As you have already advised, it says you are the author now. As you have also advised, you will change it now that I have onboarded: Yes, it has been transferred to your account now

Many thanks again. I like what you guys are doing. I have already learned a fair amount of react just noodling around in the existing plays. :)
Sent from my iPhone

On Jul 17, 2022, at 9:39 PM, Koustov @.***> wrote:

Koustov, Thank you. I went to the link and authorized my github account. I think everything is in order. Do I understand correctly that I will not see my play until I do a PR? Anyway, I see it now. As you have already advised, it says you are the author now. As you have also advised, you will change it now that I have onboarded. Thank you for addressing this. Jim From: Koustov Sent: Sunday, July 17, 2022 12:17 AM To: reactplay/react-play @.> Cc: james-david-marks @.>; Mention @.> Subject: Re: [reactplay/react-play] New user trial. -- per discussion with atapas (PR #378) Hello @james-david-marks https://github.com/james-david-marks , can you get yourself logged in at https://rgkjmwftqtbpayoyolwh.nhost.run/v1/auth/signin/provider/github. This will make sure that you are onboarded with reactplay and then the play that you added can be inserted into the list. To continue your development, I have temporarily added your play under my account so that it starts appearing in your playlist https://user-images.githubusercontent.com/7145967/179384942-ba47a8f4-458b-4ff3-a64c-cca51707b6a9.png . Let me know once your login/registration process is over, I will transfer it to your account. — Reply to this email directly, view it on GitHub <#378 (comment)> , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAY2BKWJ67XE3PE6APAZMDVUOJL5ANCNFSM53YJ7VSQ . You are receiving this because you were mentioned. https://github.com/notifications/beacon/ABAY2BIFBBVE4KJMWMP52NTVUOJL5A5CNFSM53YJ7VS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOI23RUYI.gif Message ID: @. @.***> >
Firstly, you are welcome
Do I understand correctly that I will not see my play until I do a PR?: Not really, we can do this stem early also, anyway its a temporary step. We are making it automated and the beta testing is going on
As you have already advised, it says you are the author now. As you have also advised, you will change it now that I have onboarded: Yes, it has been transferred to your account now
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.

Many thanks again. I like what you guys are doing. I have already learned a fair amount of react just noodling around in the existing plays. :)
…

Great 👍
Looking forward to your play.

Hey @james-david-marks We have the new create flow up and running. You can give that a try too.

Hello @james-david-marks
A reminder to get back on this play. This PR may be closed due to a lack of activities soon. Please let us know if you need any help.
Looking forward to getting the play in!

Closing as NO RESPONE.


FEAT: add My Open-Source Contribution on GitHub button (#34)

Added button to go to https://my-open-source-contributions.vercel.app/username when the username is known
https://github.com/user-attachments/assets/8da544b1-97d6-4dc2-8a30-bbc89b1f399b

I will fix the display in the Mobile in seperate PR @depapp


fix: images not showing

On last update:-
relative path of images did not locate the assets folder.
Before my changes:-

After my changes:-

Thanks for bringing this to my notice. But I will have to close this PR as it requires few additional changes likes:

changes should not be done in dist/lectures.html and notes/lectures.md. HTML and PDF are generated using the npm run build command.
Also in all the notes files, locally absolute path doesn't work. So all the image paths need to be updated with relative paths. Example is attached below.

Using Absolute path in local

Using Relative path in local

@brijesh-rohilla I have pushed the changes, could you please re-verify and highlight if I have missed anything..

I just missed my chance to become a contributor to my favorite GitHub repository😢
@alok722 bhai please don't make changes from your side directly.
Its hearts💔

I just missed my chance to become a contributor to my favorite GitHub repository😢
@alok722 bhai please don't make changes from your side directly.
It hurts💔


[CodeCamp #84] Support SwinIR model

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Support SwinIR of single image super-resolution
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Please briefly describe what modification is made in this PR.
Who can help? @ them here!
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist
Before PR:

[ ] I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
[ ] Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
[ ] Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
[ ] New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
[ ] The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

[ ] If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
[ ] CLA has been signed and all committers have signed the CLA in this PR.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Add .NET NuGet action to list of cacheable package managers

Why:
I noticed this was missing in the docs. Other package managers were listed but not .NET's NuGet despite it having similar references. So, I figured I'd do a quick drive-by PR to add it.
Closes: #32538

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

[ ] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

[ ] For content changes, I have completed the self-review checklist.

@SeanKilleen Thanks so much for opening a PR! I'll get this triaged for review ✨

@SeanKilleen Thanks so much for opening a PR with this fix! I'll update the branch and get this merged once tests are passing 🍏


Little variation in Commit messages

When using the generate commit messages feature I am sometimes met with the same exact messages, that sometimes don't remotely line up with the code.
Here are some examples from clicking it a few times for a commit that is a simple spelling change in a readme.md file for a repo with no login/user functionality whatsoever:

Fix bug in login functionality
Update user profile form validation
Update user authentication logic
Implement new feature XYZ (that exact message)
Fix bug causing null reference exception
Implement new feature to improve user login experience

Since the issue has been filed we have switched to a better model, improved the context and in the latest Copilot Chat release added support for custom instructions through the github.copilot.chat.commitMessageGeneration.instructions setting. All this should result in better commit messages so I am optimistically closing this issue.


expression inside "v-if" block turning false with transition

Chrome 47, Vue v1.0.13 In this fiddle.
To click the button will meet error (see it in console). But it is OK without transition.
I wonder about if the expression should be evaluated when transition leaves since "v-if" become a false value?

It work perfectly with the new commit (I built it on bedab9d personally).
But it still fails in embedded "v-if" block. Is it a same issue?

@yyx990803 :+1:

:+1: thx


RuntimeError: CUDA out of memory. Tried to allocate 20.00 MiB

On Colab restarting training again results in following error:
File "/usr/local/lib/python3.7/dist-packages/torch/nn/modules/module.py", line 889, in call_impl
result = self.forward(*input, **kwargs)
File "/content/BasicSR/codes/models/modules/architectures/block.py", line 428, in forward
sampled_noise = self.noise.repeat(*x.size()).normal() * scale
RuntimeError: CUDA out of memory. Tried to allocate 20.00 MiB (GPU 0; 15.78 GiB total capacity; 14.32 GiB already allocated; 20.75 MiB free; 14.46 GiB reserved in total by PyTorch)
The only way to restart training was to reduce batch all the way from 64 to 3
I've tried running following commands to no avail:
gc.collect()
torch.cuda.empty_cache()
There seems to a resolution here:
https://discuss.pytorch.org/t/how-can-we-release-gpu-memory-cache/14530/27

Hello! I haven't seen that behavior, but will try to replicate it. What are your CUDA, Python and Pytorch versions?

On Colab
Cuda:V11.0.221
Torch: 1.8.1+cu101
Python 3.7.10.
Anyways, i did change the scale from 4x to 1x, but didn't see why this would lead to such a drastic reduction in batch size.
Once the training began, it was only using around 9 GB of 16 GB total VRAM.

Changing the scale from 4x to 1x means that the input size will be the same as the output.
By default the output size is 128x128, meaning the input size is 32x32 with 4x scale. If using 1x scale, the input is 4 times larger in both dimensions, which you also multiply by the batch size and then pass this batch through the entirety of the model, consuming a lot more memory than the 4x case.


Update on training program PF

@AnthonyAsembo
Kindly address the conflict to allow closing this PR

@brianraila Addressed


Option to tell protoc to remove omitempty field from json tags when generating .go files

Problem
When I generate .pb.go files using protoc, its generating structs with json tags where there are omitempty option in each of the fields:
Proto3:
message MyMessage{
    string id = 1;
    MyType type = 2;
    bool isFoo = 3;
}

Generated go struct:
type MyMessage struct {
    ...
    Id       string   `protobuf:"bytes,1,opt,name=id,proto3" json:"id,omitempty"`
    Type     MyType   `protobuf:"varint,2,opt,name=type,proto3,enum=some_service.MyType" json:"type,omitempty"`
    IsFoo    bool     `protobuf:"varint,3,opt,name=onboarded,proto3" json:"onboarded,omitempty"`
}

Solutions
Option to tell protoc compiler to not generate structs with omitempty json tags (For example some arg like protoc --json-emitall)

Protobuf to support json-tag related options:
For example, on the top of the .proto file:
option json-emitall="true";

Or, support for some per message option like:
message Foo {
    string id = 1;

    option json-tags = "";
}

Desired Result
So that I can get:
type MyMessage struct {
    ...
    Id       string   `protobuf:"bytes,1,opt,name=id,proto3" json:"id"`
    Type     MyType   `protobuf:"varint,2,opt,name=type,proto3,enum=some_service.MyType" json:"type"`
    IsFoo    bool     `protobuf:"varint,3,opt,name=onboarded,proto3" json:"onboarded"`
}

The JSON tags are considered a deprecated feature of protobuf generation, as one should be using the protojson package, instead of the standard library’s encoding/json which has several caveats to its usage that mean that the official proto3 JSON mapping could not be implemented properly with it.

The JSON tags are considered a deprecated feature of protobuf generation, as one should be using the protojson package, instead of the standard library’s encoding/json which has several caveats to its usage that mean that the official proto3 JSON mapping could not be implemented properly with it.

What caveats is there? protojson has a lot unexpected behaviour i prefer avoid using it replacing with JSONBuiltin. The only trouble i faced - hardcoded omitempty by the compiler.

What caveats is there?

The caveats that it cannot correctly implement the proto3 JSON mapping standard.


Elevation gain

Hi @michael-hatz, you mentioned elevation gain in another issue. I understand this wish very well, but I think that it is not possible with the elevation data from GPS devices. I've attached a longer notebook to illustrate the problem.
Elevation-Gain.pdf

This looks like a hard problem and might be out of scope for this project

There are devices with a barometric altimeter available and they provide good results. I have one and can tell you that those elevation statistics are great. But of course I have not tracked every ride with that device - it is a wild mix of two different bike computers, the strava mobile app and other sources. And in the future there might be old data coming from Strava, but also data tracked with an barometric bike computer without Strava or GPX files created just with a mobile phone in other apps. So no real, unified data source
Here is the Strava FAQ on elevation gain: They are doing stuff we can't to here, like creating a global elevation base model based on other strava activities with barometric altimeters where your route is getting pinned to: https://support.strava.com/hc/en-us/articles/216919447-Elevation
I did compare BRouters output to my barometric data. Took one track with an barometric elevation gain and loaded it in BRouter. Barometric data was 830HM, Brouter was estimating 903HM. Another track was changed from 353HM to 263HM. So using the Brouter engine (which should be the best open source engine available and is based on OSM data) is not great.
Just using the Strava data via API would create a unwanted dependency

I wonder whether your tracks with barometric data also contain a cumulative elevation gain field that we could use. If that's the case, I could extract that. Could you perhaps share a track file here or via<EMAIL_ADDRESS>


[Bug] Personal profile - Certificates tab

There are numerous problems with the certificates tab - "Download" button not working, the amount is shown in stotinki and not BGN, date filters are not working.
Since we have a donations tab where these issues are fixed and user can download certificate for each donation, let's hide the certificats tab.

@Juicebgs I tried fixing the certificate table instead of hiding it. Please check linked PR!


Remove per-arch go files

Currently we have 1 .go file per architecture, due to the celo-blockchain toolchain being rigid for compiling with various CGO flags.
It'd be nice if we could get rid of these files, fix celo-blockchain and specify explicit instructions on how to cross-compile / link this library in various architectures.
An approach for this can be seen in https://github.com/celo-org/bls-zexe/pull/122 (which we partially reverted due to geth's inflexibility)

@kobigurk Do you think it'd be worth exploring this, given that we are considering using a compiled library file in geth?

Still don't know how we can get around that

Moving this to https://github.com/celo-org/celo-bls-go/issues/2


Running prisma delete -f on non-existing service should return without error

Is your feature request related to a problem? Please describe.
We use prisma delete -f in several of our developer scripts (to reset a developer database, to clean up a state before an integration test, etc).
In all these situations we simply want to ensure the service is gone after running the command, irrespective whether it was there or not.
As a user, I expect the 'force' mode to do exactly that. Very similar to how rm -f my-file.txt always returns, even the file was not there.
The fact that prisma delete -f throws in when run on a non-existing service is frustrating, since we have to specifically handle a situation in our scripts that we don't care about.
Related to #2076, where something similar was advocated on the side.
Describe the solution you'd like
Providing -f has two effects:

non interactive mode (i.e. the current behavior); and
returns with exit code 0, even if the service to delete does not exist

The current behavior (non-interactive only) is still possible, but there is a new option -y (for 'yes') that triggers this behavior.
Describe alternatives you've considered
All are hacky workarounds:

Perform an 'exists test' before running prisma delete -f. But this is not failproof of course. You also don't check whether a file exists and then assume that nothing can go wrong when opening it. You open it and handle errors if they occur.
Capture the prisma delete -f exit code. But right now the exit code is always 1. We would need a specific exit code for a non-critical failure like trying to delete something that isn't there.
Catch and parse the stderr of the command. But of course this is pretty ugly.

This is available in the latest beta - 1.27.0-beta.12, please install it via npm install -g prisma@beta.

Great news. Thanks a lot!

This is available in the latest stable - 1.28.0, please install it via npm install -g prisma. I am closing this issue, please open a new issue, if necessary.


Fix issue reporting in scheduled upstream testing

It looks like something was going wrong in the conditionals of the upstream testing workflow that caused test failures to not trigger an issue; I've copied over some of the code from dask-ml's working upstream testing workflow so that this hopefully isn't an issue moving forward.

Codecov Report

Merging #355 (9c02387) into main (5f606d3) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #355      +/-   ##
==========================================
- Coverage   95.56%   95.56%   -0.01%
==========================================
  Files          67       67
  Lines        2933     2931       -2
  Branches      547      547
==========================================
- Hits         2803     2801       -2
  Misses         79       79
  Partials       51       51

Impacted Files
Coverage Δ

dask_sql/physical/rel/custom/predict.py
95.34% <0.00%> (-0.11%)
:arrow_down:

dask_sql/utils.py
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f606d3...9c02387. Read the comment docs.

rerun tests


The performance of the app could be enhanced.

Compared to Paletro, Finbar's loading speed is noticeably slower. Each time I open it, I'm met with a loading animation. Improving this aspect would definitely enhance the overall user experience.

Thanks for the feedback. I’m working on improving this experience as we speak.

This enhancement has been added in the update released today. I think you’ll be satisfied. Thanks!


Small package update

Summary
Just a quick package update - fixes a vulnerability highlighted by NPM
NONE

Only the lock file needs to get updated? No changes in the package.json file?


Invalid URI error when installing some plugins.

I'm trying to install vim-coffee-script, but get this error:
vim-coffee-script:
  Invalid URI<EMAIL_ADDRESS>
  Expected:    https://github.com/kchmck/vim-coffee-script.git
  PlugClean required.

Sorry, I know it is in the FAQ, but even with this instructions I didn't get it to work.
I tried it with:
Plug 'kchmck/vim-coffee-script'

Tried it as well with the full git url, and the let g:plug_url_format = 'git@github.com:%s.git' trick from the FAQ
Is there an error with this particular plugin ?
Is something wrong with VimPlug ?
Or is the problem sitting in front of the machine ?

NVIM 0.1.4
Build type: RelWithDebInfo
Compilation: /usr/local/Library/ENV/4.3/clang -Wconversion -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -DDISABLE_LOG -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wvla -fstack-protector-strong -fdiagnostics-color=auto -DINCLUDE_GENERATED_DECLARATIONS -DHAVE_CONFIG_H -I/tmp/neovim-20160527-55178-1qmn0z0/neovim-0.1.4/build/config -I/tmp/neovim-20160527-55178-1qmn0z0/neovim-0.1.4/src -I/tmp/neovim-20160527-55178-1qmn0z0/neovim-0.1.4/deps-build/usr/include -I/tmp/neovim-20160527-55178-1qmn0z0/neovim-0.1.4/deps-build/usr/include -I/tmp/neovim-20160527-55178-1qmn0z0/neovim-0.1.4/deps-build/usr/include/luajit-2.0 -I/tmp/neovim-20160527-55178-1qmn0z0/neovim-0.1.4/deps-build/usr/include -I/tmp/neovim-20160527-55178-1qmn0z0/neovim-0.1.4/deps-build/usr/include -I/tmp/neovim-20160527-55178-1qmn0z0/neovim-0.1.4/deps-build/usr/include -I/tmp/neovim-20160527-55178-1qmn0z0/neovim-0.1.4/deps-build/usr/include -I/usr/local/opt/gettext/include -I/usr/include -I/usr/include -I/tmp/neovim-20160527-55178-1qmn0z0/neovim-0.1.4/build/src/nvim/auto -I/tmp/neovim-20160527-55178-1qmn0z0/neovim-0.1.4/build/include
Compiled by xxx@xxx

Optional features included (+) or not (-): +acl   +iconv    +jemalloc
For differences from Vim, see :help vim-differences

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/usr/local/Cellar/neovim/0.1.4/share/nvim"

Type:

[x] Question

OS:

[x] OS X

Vim:

[x] Neovim

Like the error message suggests, first run :PlugClean to clean up the directory then do :PlugInstall again.

Thank You
Works like a charm


did-key-secp256k1: Error: Cannot find module 'tslib'

If the only dependency installed is "@transmute/did-key-secp256k1": "^0.2.1-unstable.35", this code:
'use strict'

const { Secp256k1KeyPair } = require('@transmute/did-key-secp256k1')

— fails with the error:
➜  test node ./index.js
node:internal/modules/cjs/loader:928
  throw err;
  ^

Error: Cannot find module 'tslib'
Require stack:
-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>- /Users/ak/Development/kravc/test/index.js

This seems to happen with "^0.3.0-unstable.5", fixed with npm install tslib.

This seems to happen with "^0.3.0-unstable.5", fixed with npm install tslib.


Error when using catkin_make MTC tutorial

I want to try running the MoveIt Task Constructor tutorial.Here are my steps：
1.cd ~/ws_moveit/src
2.git clone https://github.com/moveit/moveit_task_constructor.git
3.rosdep install --from-paths . --ignore-src --rosdistro noetic
4.cd ..
5.catkin_make**
When I run 5.catkin_make in the terminal, an error message appears. I will capture the error message below:
My system environment：Ubuntu 20.04 + ROS Noetic

Unfortunately, I re-downloaded the MTC feature package according to your suggestion (git clone --recursive https://github.com/moveit/moveit_task_constructor.git), and catkin_make, but the same error still occurs.
The instructions I'm getting these errors are from https://moveit.github.io/moveit_tutorials/doc/moveit_task_constructor/moveit_task_constructor_tutorial.html
Error：

Looks like MTC cannot be build with catkin_make. Try catkin tools instead: catkin build

Looks like MTC cannot be build with catkin_make. Try catkin tools instead: catkin build

Thank you very much for your advice, the MTC tutorial ran successfully!But I am confused about the difference between catkin_make and catkin build. Why does catkin_make fail?

I am confused about the difference between catkin_make and catkin build.

These are simply different build tools. catkin_make is very much outdated.

Why does catkin_make fail?

I don't yet know.


PIXI 8 Tilemap doesn't apply roundPixels renderer settings

In application with renderer settings antialias: false, roundPixels: true, Tilemap still renders fractal pixel positions as 'smeared'.
See video:
https://github.com/pixijs/tilemap/assets/1055278/6e37f5f0-2c07-4fd3-a69d-2b13e37facf0
Expected result:
https://github.com/pixijs/tilemap/assets/1055278/01bf6320-8f6f-4ea5-b8ef-0dbed84fe687

Noted, will be fixed this week i hope )


Crash when stopping stream (KVO)

I've seen a few of these crashes:
Cannot remove an observer <ORGMEngine 0x170283430> for the key path "endOfInput" from <ORGMInputUnit 0x1700927f0> because it is not registered as an observer.```

The crash points to [this line](https://github.com/ap4y/OrigamiEngine/blob/master/OrigamiEngine/ORGMEngine.m#L139).

This is similar to issue #58, but it is important to note that it is a separate crash.

+1


I have updated it, but there is no news about Coinham and Ton-Coinham

I have updated it, but there is no news about Coinham and Ton-Coinham
Originally posted by @Rohan1363m in https://github.com/ton-blockchain/TEPs/pull/123#issuecomment-2229997391


Investigate Threejs cleanup

@tdungate noticed a memory leak on Windows when using the plug-in in chrome.  This got worse the more he toggled the Threejs canvas on and off.  I think, garbage collection isn't disposing of contexts properly, so I think we should handle it in the plug-in and clean up better.

Primary fix in place.  Needs performance testing.


Encrypt SNS

Probably a good idea to encrypt the sns using kms_master_key_id = "alias/aws/sns" or the KMS key used for CloudTrail.

@willfarrell Good suggestion! #103 adds an encryption with the AWS managed key by default and also a variable to override this to any custom CMK :+1: