[BUG]: SimpleAmqpClient triggers deprecation warnings with newer versions of boost

Version
23.11
Which installation method(s) does this occur on?
Source
Describe the bug.
This library is used by the RabbitMQ Source stage example.
Upstream issue alanxz/SimpleAmqpClient#331
Warnings are:
[267/379] Building CXX object _deps/simpleamqpclient-build/CMakeFiles/SimpleAmqpClient.dir/src/ChannelImpl.cpp.o
In file included from /home/dagardner/work/conda/envs/morpheus/include/boost/function/detail/requires_cxx11.hpp:9,
                 from /home/dagardner/work/conda/envs/morpheus/include/boost/function/detail/prologue.hpp:12,
                 from /home/dagardner/work/conda/envs/morpheus/include/boost/function.hpp:30,
                 from /home/dagardner/work/conda/envs/morpheus/include/boost/algorithm/string/detail/find_iterator.hpp:18,
                 from /home/dagardner/work/conda/envs/morpheus/include/boost/algorithm/string/find_iterator.hpp:24,
                 from /home/dagardner/work/conda/envs/morpheus/include/boost/algorithm/string/iter_find.hpp:27,
                 from /home/dagardner/work/conda/envs/morpheus/include/boost/algorithm/string/split.hpp:16,
                 from ../.cache/cpm/simpleamqpclient/d01bafbbe9026c56fd2e01360fa0293660ae1064/src/ChannelImpl.cpp:41:
/home/dagardner/work/conda/envs/morpheus/include/boost/function/detail/requires_cxx11.hpp:18:1: note: '#pragma message: C++03 support is deprecated in Boost.Function 1.82 and will be removed in Boost.Function 1.84.'
   18 | BOOST_PRAGMA_MESSAGE("C++03 support is deprecated in Boost.Function 1.82 and will be removed in Boost.Function 1.84.")
      | ^~~~~~~~~~~~~~~~~~~~
/home/dagardner/work/conda/envs/morpheus/include/boost/bind/detail/requires_cxx11.hpp:18:1: note: '#pragma message: C++03 support is deprecated in Boost.Bind 1.82 and will be removed in Boost.Bind 1.84.'
   18 | BOOST_PRAGMA_MESSAGE("C++03 support is deprecated in Boost.Bind 1.82 and will be removed in Boost.Bind 1.84.")
      | ^~~~~~~~~~~~~~~~~~~~
/home/dagardner/work/conda/envs/morpheus/include/boost/smart_ptr/detail/requires_cxx11.hpp:19:1: note: '#pragma message: C++03 support is deprecated in Boost.SmartPtr 1.82 and will be removed in Boost.SmartPtr 1.84.'
   19 | BOOST_PRAGMA_MESSAGE("C++03 support is deprecated in Boost.SmartPtr 1.82 and will be removed in Boost.SmartPtr 1.84.")
      | ^~~~~~~~~~~~~~~~~~~~
/home/dagardner/work/conda/envs/morpheus/include/boost/chrono/detail/requires_cxx11.hpp:19:1: note: '#pragma message: C++03 support is deprecated in Boost.Chrono 1.82 and will be removed in Boost.Chrono 1.84.'
   19 | BOOST_PRAGMA_MESSAGE("C++03 support is deprecated in Boost.Chrono 1.82 and will be removed in Boost.Chrono 1.84.")
      | ^~~~~~~~~~~~~~~~~~~~
/home/dagardner/work/conda/envs/morpheus/include/boost/ratio/detail/requires_cxx11.hpp:18:1: note: '#pragma message: C++03 support is deprecated in Boost.Ratio 1.82 and will be removed in Boost.Ratio 1.84.'
   18 | BOOST_PRAGMA_MESSAGE("C++03 support is deprecated in Boost.Ratio 1.82 and will be removed in Boost.Ratio 1.84.")
      | ^~~~~~~~~~~~~~~~~~~~
/home/dagardner/work/conda/envs/morpheus/include/boost/system/detail/requires_cxx11.hpp:17:1: note: '#pragma message: C++03 support is deprecated in Boost.System 1.82 and will be removed in Boost.System 1.84.'
   17 | BOOST_PRAGMA_MESSAGE("C++03 support is deprecated in Boost.System 1.82 and will be removed in Boost.System 1.84.")
      | ^~~~~~~~~~~~~~~~~~~~
/home/dagardner/work/conda/envs/morpheus/include/boost/container_hash/detail/requires_cxx11.hpp:18:1: note: '#pragma message: C++03 support is deprecated in Boost.ContainerHash 1.82 and will be removed in Boost.ContainerHash 1.84.'
   18 | BOOST_PRAGMA_MESSAGE("C++03 support is deprecated in Boost.ContainerHash 1.82 and will be removed in Boost.ContainerHash 1.84.")

Minimum reproducible example
No response
Relevant log output
No response
Full env printout
No response
Other/Misc.
No response
Code of Conduct

[X] I agree to follow MRC's Code of Conduct
[X] I have searched the open bugs and have found no duplicates for this bug report

Woops, wrong repo


Push to GitLab on multi file not working (enterprise)

Describe the bug
Pushing to GitLab with multi file setup not working for GitLab enterprise
To Reproduce
Steps to reproduce the behavior:

Connect to GitLab enterprise
Make changes in the plugin
Push changes
Push not working

Expected behavior
Push to gitlab should work as expected.
Screenshots or Screencasts

@esthercheran is this fixed by https://github.com/six7/figma-tokens/pull/1043 ?

Yes, this is fixed by https://github.com/six7/figma-tokens/pull/1043


Accounts: ability to filter accounts without profiles

https://una.io/page/cmts-view?sys=bx_forum&id=1780&cmt_id=31550

exclude "robot" from the list of accounts without profile.

exclude "robot" from the list of accounts without profile.


Replace(url) method with DataUrl

Hi,
Is it technically possible to manage dataurl in the replace(url) method ?
The interest would be to directly crop local file (ex: opened with FileReader) before upload.
Actually it failed on XMLHttpRequest.open().
The question also applies for initial src on IMG.

Make sure you are using a valid Data URL.


dio log every line have '<…>'

Hi all, new user with talker and have a question, I'm using TalkerDioLogger like this:

The log looks like this:

every single line has a '<…>', is that a problem or I'm missing some settings of talker? Thank you.

Hello @huahua8893 !
Sorry for a long waiting.
Which platform are you working with ?
And check this point in documentation
https://github.com/Frezyx/talker/tree/master#-log-messages-integrity

And check this issue
https://github.com/Frezyx/talker/issues/104


Replace old dependencies for reverse-geocoder

Currently, it uses rustc-serialize which has been deprecated in favor of serde (https://crates.io/crates/rustc-serialize) and quick-csv, which depends on rustc-serialize and has not been updated in 5 years.

Thanks @jqnatividad I will replace those crate usages and update this project.

Thanks!!!! Works perfectly!


MarkdownString Broken After Or In HTML

Issue Type: Bug
Steps to Reproduce:

Create a multiline Markdown string with a
 in the middle.
Set to a MarkdownString in the constructor or value property.
Any Markdown below or in an HTML tag does not render.

Example
const hoverUI = `
# One
## Two
### Three

#### Four
##### Five
###### Six
`;
const md = new MarkdownString(ui, true);
md.isTrusted = true;
md.supportHtml = true;
statusBar.tooltip = md;

VS Code version: Code 1.63.0 (7db1a2b88f7557e0a43fec75b6ba7e50b3e9f77e, 2021-12-07T05:18:59.299Z)
OS version: Linux arm64 5.15.7-1-MANJARO-ARM
Restricted Mode: No

System Info

Item
Value

CPUs
unknown (6 x 1416)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onrasterization: disabled_softwareskia_renderer: enabled_onvideo_decode: disabled_softwarevulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
1, 2, 2

Memory (System)
3.77GB (0.09GB free)

Process Argv
. --crash-reporter-id 2a85f066-a8e2-4971-b1ff-37959f57a0f0

Screen Reader
no

VM
0%

DESKTOP_SESSION
plasma

XDG_CURRENT_DESKTOP
KDE

XDG_SESSION_DESKTOP
KDE

XDG_SESSION_TYPE
x11

Extensions (4)

Extension
Author (truncated)
Version

vscode-eslint
dba
2.2.2

gitlens
eam
11.7.0

vscode-drawio
hed
1.6.4

vsliveshare
ms-
1.0.5242

I don't think that that markdown will do what you want. It seems like
 causes everything after it to be treated as part of an html tag:
https://spec.commonmark.org/dingus/?text=%23 One
%23%23 Two
%23%23%23 Three

%23%23%23%23 Four
%23%23%23%23%23 Five
%23%23%23%23%23%23 Six
In our case, I think we then strip this out but I don't think this is worth looking into since even if we fixed our rendering, it still would not render as expected

Thanks for the link, it gives more insight into AST output. It seems it has to do with a newline character. To be clear, it is any HTML tag; if there isn't a newline after it, it will not render Markdown correctly. Meaning this:
# 1

## 2

Renders differently than the first example. In AST the two different outputs:
  <heading level="1">
    <text>One</text>
  </heading>
  <html_block><hr/></html_block>
  <heading level="2">
    <text>Two</text>
  </heading>

vs
  <heading level="1">
    <text>One</text>
  </heading>
  <html_block><hr/>
## Two</html_block>


Add DNS names used by DTR

Proposed changes
added list of DNS names that DTR calls to page ee/dtr/admin/configure/use-a-web-proxy. These DNS names should be whitelisted if proxy only works with whitelisted domains.

Deploy preview for docsdocker ready!
Built with commit 03cddc5cb853bd048061f95235814102d789900c
https://deploy-preview-9045--docsdocker.netlify.com

Hey @ivansharamok, I think you've got a few too many commits on this PR. Looks like you are bringing some Kubernetes config with you :D

Will clean up and resubmit. closing this PR.


Random results when save model in Python 3.5 and load in Python 2.7

Hi there,
I'm using Keras 2.1.5 with Tensorflow-gpu 1.7.0 as backend on ubuntu 16.04 (Kernel 4.4).
I've got a model trained in Python 3.5 saved with model.save("path"). Evaluating this model on Python 3.5 results in an accuracy of 99%. Futhermore, loading the model with Python 3.5 on another machine works perfectly fine.
But I've got to load it on Python 2.7. Doing so (model=load_model("path") -> model.evaluate(...)), the evaluation results in 33% accuracy.
I've tried to save it in json and YAML as well as building the architecture and loading the weights on it...nothing works.
I haven't found any thread with this problem so far...
Hope that someone has an idea of what's going on!
Thanks in advance!

[x ] Check that you are up-to-date with the master branch of Keras. You can update with:
pip install git+git://github.com/keras-team/keras.git --upgrade --no-deps

[x ] If running on TensorFlow, check that you are up-to-date with the latest version. The installation instructions can be found here.

[ ] If running on Theano, check that you are up-to-date with the master branch of Theano. You can update with:
pip install git+git://github.com/Theano/Theano.git --upgrade --no-deps

[x ] Provide a link to a GitHub Gist of a Python script that can reproduce your issue (or just copy the script here if it is short).

I have the same issue. My solution is training the model in Python 2.7 as well, but I'm not happy with that.
Is there a possibility in saving the model in another file-format or saving the tensorflow-checkpoints separately?


What are the filterable properties for Get-UnifiedGroup

Get-cUnifiedGroup -ResultSize unlimited -filter "ProvisioningOption -eq 'ExchangeProvisioningFlags:481' -and  AccessType -eq 'Public'"

Cannot bind parameter 'Filter' to the target. Exception setting "Filter": ""ProvisioningOption" is not a recognized filterable property. For a complete list of filterable properties see the command help.
"ProvisioningOption -eq 'ExchangeProvisioningFlags:481' -and  AccessType -eq 'Public'" at position 1."

& an examle would be helpful

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d063d71b-c1d5-e995-9e0d-a3daf646c712
Version Independent ID: 7cff679f-a994-e371-a227-b8c5635f1aa2
Content: Get-UnifiedGroup (exchange)
Content Source: exchange/exchange-ps/exchange/users-and-groups/Get-UnifiedGroup.md
Service: exchange-powershell
GitHub Login: @chrisda
Microsoft Alias: chrisda

@chrisda  Thanks for answer. The syntax is correct. It would be helpful to mention this in the parameter help of the command

ManagedBy is a filterable attribute; eg
Get-UnifiedGroup -Filter {ManagedBy -eq $null}
Get-UnifiedGroup -Filter {ManagedBy -ne $null}
However, I don't know how to filter by a name.  This would be immensely helpful!

filtering as a string doesn't work; ie
Get-UnifiedGroup -Filter {ManagedBy -eq "SNadella"}
However, if I use something like...
$managers = get-unifiedgroup -filter {DisplayName -eq "Accounts"} | select -expandproperty managedBy
...then $managers will be a string object.
In other words, it returns a string, but won't take a string. Aargh!

ManagedByDetails is not a filterable property.

The theme I noticed when creating that topic is: most filterable attributes require the distinguished name (DN) value of the object So, if you know the identity (name, alias, email address, etc.) of the Mananger, run the command:
Get-Mailbox -Identity <ManagerIdentity> | Format-List DistinguishedName

and then use the distinguished name value in the filter:
Get-UnifiedGroup -Filter {ManagedBy -eq '<DistinguishedNameOfManager>'}

Thanks Chris.
That works!
In case anyone is reading, here's an example;
Get-UnifiedGroup -Filter {ManagedBy -eq "CN=FredFlintstone,OU=bedrock.onmicrosoft.com,OU=Microsoft Exchange Hosted Organizations,DC=EURPR03A002,DC=prod,DC=outlook,DC=com"}
This method certainly isn't obvious, given that the "managedby" shows only the CN part (eg FredFlintstone), which would suggest that you would use that to filter, too.
Please can...
https://docs.microsoft.com/powershell/exchange/exchange-server/recipient-filters/filter-properties
...be updated to show that get-unifiedgroup can use the "-Filter" too, and include this example?

You really need to provide examples, for -filter, not just the syntax


Copy string before returning it

This PR fixes issue #1209.
Signed-off-by: Ettore Tiotto<EMAIL_ADDRESS>

@gongsu832 @AlexandreEichenberger can you pls take a look again ?

I respectfully disagree with removing the mutex. It's not to give a false sense of usability. Any time when you have multiple threads writing to shared data, serialization is the very basic requirement for not corrupting the shared data. The issue that one thread's changing the option will be seen by all other threads is a completely different issue and mutex is not even designed to protect against that.

So I am requesting that

the mutex is removed for now because they are marginally useful and giving a false sense of usability.
we label the function in the interface as to be called only in a single thread mode

I have removed the mutex because is not essential to the main goal of this patch.  There is disagreement on what to do w.r.t. thread safety as per discussion above.  I do think that having a mutex does not make things worse, however in order to make progress I think we can agree on having the strdup and leave the discussion on thread safety to another time :-)

Jenkins Linux ppc64le Build #3470 [push] Copy string before retur... started at 16:46

Jenkins Linux amd64 Build #4342 [push] Copy string before retur... started at 15:44

Jenkins Linux s390x Build #4354 [push] Copy string before retur... passed after 50 min

Jenkins Linux ppc64le Build #3470 [push] Copy string before retur... passed after 58 min

Jenkins Linux amd64 Build #4342 [push] Copy string before retur... passed after 1 hr 5 min


TypeError during model build

I tried to build a couple of different models, but each build fails with the same error:
Exporting model: models/stabilityai/stable-diffusion-2-1/onnx/unet.onnx
Downloading (…)_pytorch_model.bin";: 100%|██████████| 3.46G/3.46G [09:25<00:00, 6.13MB/s]
Downloading (…)ain/unet/config.json: 100%|██████████| 939/939 [00:00<00:00, 950kB/s]
The config attributes {'dual_cross_attention': False, 'num_class_embeds': None, 'only_cross_attention': False, 'use_linear_projection': True, 'upcast_attention': True} were passed to UNet2DConditionModel, but are not expected and will be ignored. Please verify your config.json configuration file.
ERROR:    Exception in ASGI application
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/dist-packages/uvicorn/protocols/http/h11_impl.py", line 407, in run_asgi
    result = await app(  # type: ignore[func-returns-value]
  File "/usr/local/lib/python3.10/dist-packages/uvicorn/middleware/proxy_headers.py", line 78, in __call__
    return await self.app(scope, receive, send)
  File "/usr/local/lib/python3.10/dist-packages/fastapi/applications.py", line 270, in __call__
    await super().__call__(scope, receive, send)
  File "/usr/local/lib/python3.10/dist-packages/starlette/applications.py", line 124, in __call__
    await self.middleware_stack(scope, receive, send)
  File "/usr/local/lib/python3.10/dist-packages/starlette/middleware/errors.py", line 184, in __call__
    raise exc
  File "/usr/local/lib/python3.10/dist-packages/starlette/middleware/errors.py", line 162, in __call__
    await self.app(scope, receive, _send)
  File "/usr/local/lib/python3.10/dist-packages/starlette/middleware/cors.py", line 92, in __call__
    await self.simple_response(scope, receive, send, request_headers=headers)
  File "/usr/local/lib/python3.10/dist-packages/starlette/middleware/cors.py", line 147, in simple_response
    await self.app(scope, receive, send)
  File "/usr/local/lib/python3.10/dist-packages/starlette/middleware/exceptions.py", line 79, in __call__
    raise exc
  File "/usr/local/lib/python3.10/dist-packages/starlette/middleware/exceptions.py", line 68, in __call__
    await self.app(scope, receive, sender)
  File "/usr/local/lib/python3.10/dist-packages/fastapi/middleware/asyncexitstack.py", line 21, in __call__
    raise e
  File "/usr/local/lib/python3.10/dist-packages/fastapi/middleware/asyncexitstack.py", line 18, in __call__
    await self.app(scope, receive, send)
  File "/usr/local/lib/python3.10/dist-packages/starlette/routing.py", line 706, in __call__
    await route.handle(scope, receive, send)
  File "/usr/local/lib/python3.10/dist-packages/starlette/routing.py", line 276, in handle
    await self.app(scope, receive, send)
  File "/usr/local/lib/python3.10/dist-packages/starlette/routing.py", line 69, in app
    await response(scope, receive, send)
  File "/usr/local/lib/python3.10/dist-packages/starlette/responses.py", line 266, in __call__
    async with anyio.create_task_group() as task_group:
  File "/usr/local/lib/python3.10/dist-packages/anyio/_backends/_asyncio.py", line 662, in __aexit__
    raise exceptions[0]
  File "/usr/local/lib/python3.10/dist-packages/starlette/responses.py", line 269, in wrap
    await func()
  File "/usr/local/lib/python3.10/dist-packages/starlette/responses.py", line 258, in stream_response
    async for chunk in self.body_iterator:
  File "/usr/local/lib/python3.10/dist-packages/starlette/concurrency.py", line 63, in iterate_in_threadpool
    yield await anyio.to_thread.run_sync(_next, iterator)
  File "/usr/local/lib/python3.10/dist-packages/anyio/to_thread.py", line 31, in run_sync
    return await get_asynclib().run_sync_in_worker_thread(
  File "/usr/local/lib/python3.10/dist-packages/anyio/_backends/_asyncio.py", line 937, in run_sync_in_worker_thread
    return await future
  File "/usr/local/lib/python3.10/dist-packages/anyio/_backends/_asyncio.py", line 867, in run
    result = context.run(func, *args)
  File "/usr/local/lib/python3.10/dist-packages/starlette/concurrency.py", line 53, in _next
    return next(iterator)
  File "/app/./modules/diffusion/tensorrt/engine.py", line 154, in build
    engine = build_engine(
  File "/app/./modules/diffusion/tensorrt/engine.py", line 41, in build_engine
    model = model_data.get_model()
  File "/app/./modules/diffusion/tensorrt/models.py", line 53, in get_model
    return UNet2DConditionModel.from_pretrained(
  File "/app/./submodules/diffusers_0_7_2/src/diffusers/modeling_utils.py", line 485, in from_pretrained
    model, unused_kwargs = cls.from_config(
  File "/app/./submodules/diffusers_0_7_2/src/diffusers/configuration_utils.py", line 174, in from_config
    model = cls(**init_dict)
  File "/app/./submodules/diffusers_0_7_2/src/diffusers/configuration_utils.py", line 444, in inner_init
    init(self, *args, **init_kwargs)
  File "/app/./submodules/diffusers_0_7_2/src/diffusers/models/unet_2d_condition.py", line 135, in __init__
    down_block = get_down_block(
  File "/app/./submodules/diffusers_0_7_2/src/diffusers/models/unet_2d_blocks.py", line 65, in get_down_block
    return CrossAttnDownBlock2D(
  File "/app/./submodules/diffusers_0_7_2/src/diffusers/models/unet_2d_blocks.py", line 535, in __init__
    out_channels // attn_num_head_channels,
TypeError: unsupported operand type(s) for //: 'int' and 'list'

The models I tried, specifically, were stabilityai/stable-diffusion-2-1 and hakurei/waifu-diffusion.
I set up Lsmith using Docker on Windows 11 with a freshly installed Windows Subsystem for Linux 2 running Ubuntu 22.04.1 LTS.

diffusers 0.7.2 is old and was released before stable diffusiion 2.0 - 2.1 models

Ah, that did it. The submodule needed to be updated with --remote.


Text in About box

Could you double check the text in the about box? Especially the last sentence. Reads a bit awkward to me.

@tomstafford


Raising an error if input model has multiple valid parameters?

Description
This is similar to the question https://github.com/tiangolo/fastapi/issues/724#issue-526375835 but instead of extra parameters, how do I raise an error if multiple of the same valid parameters are provided.
Example:
from fastapi import FastAPI
from pydantic import BaseModel

app = FastAPI()

class UpdateModel(BaseModel):
    name: str
    class Config:
        extra = "forbid"

@app.post("/items/")
async def update(item: UpdateModel):
    # do smth with item.name

If I send {"name": "FOO", "name": "BAR"} the second "name" is used for item (i.e. item.name = "BAR")
How can I raise an error with my pydantic model so this is rejected?  The extra = "forbid" does not work for duplicates.
Thanks
Operating System
Windows
Operating System Details
No response
FastAPI Version
0.66.0
Python Version
3.9.1
Additional Context
No response

Sorry, how can you send json data with two same key?
If you want to get name  and item name in json body.  You can do these ways:

direct send{"name": "FOO", "item_name": "BAR"}

extra model send:{"name": "FOO", "item": {"name": "BAR"}}

Maybe unlikely, but if client app has an error and sends a json body with {"name": "FOO1", "name": "FOO2"} I would want pydantic to raise an error.  This would make the API more robust.

I tried implementing the below code so the Config class uses a custom decoder, but it doesn't appear to be called.  What's interesting is when I add a custom encoder for "json_dumps" this does get called, but the dictionary coming into this function already has the duplicated parameter filtered out.
def raise_error_if_dup_key(pairs):
    result = {}
    for key, value in pairs:
        if key in result:
            raise ValueError(f"Duplicate key found:{key}")
        result[key] = value
    return result

def custom_loads(s):
    return json.loads(s,object_pairs_hook = raise_error_if_dup_key)

class UpdateModel(BaseModel):
    name: str
    class Config:
        extra = "forbid"
        json_loads = custom_loads


Merge Editor: Invoking "Accept All Changes from ..." multiple times scrolls the documents

Testing #158819

Clone https://github.com/hediet/diff-merge-dataset
Use the Load Merge Editor State From Folder command and select the merges/demo1 folder
Select result in the quick pick
Scroll "Input 1" on the left-hand side
Invoke "Accept All from Left" command multiple times one after the other and notice how the documents scroll up one line at a time every time the command gets invoked

This does not happen for me :(

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Add append file methods

Add append file methods

THANK YOU! I was just about to make this change myself.

I am new to GIT and I need this functions. What does it take to have it in the official nuget package?

i sumit this pull request 1 year ago and no one approve or say anything about it. It seem the owner has abandon this repository.

PCL Storage is the only solution that Xamarin recommends, right? I manage to accomplish this with pure PCL code using IFile.OpenAsync and Stream.WriteAsync.

this is the only solution which work on PCL i can find. You can download the code and make modification to fit your need.

Looks like Daniel is back at work. Maybe he can pull this one into main branch too.


Improve robustness of manpage build

Don't try the build if xsltproc is missing.
Don't abort the build if the stylesheet file is missing.

This addresses issue #2225.


Fix error handling and several lint issues on Citadel Agent.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: myidpt
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

security/OWNERS [myidpt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: lei-tang, myidpt
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

security/OWNERS [myidpt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: lei-tang, myidpt
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

security/OWNERS [myidpt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: lei-tang, myidpt, quanjielin
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

security/OWNERS [myidpt,quanjielin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@myidpt: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
a06150cbd6851acb7c43017e434abdd58032dc04
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


add contributors

@all-contributors
please add @liuq901 for LiveCodeBench
please add @cattaria for CommonOJ

@all-contributors
please add @liuq901 for LiveCodeBench
please add @cattaria for CommonOJ

@all-contributors
please add @ssine  for the overall architecture of sandbox
please add @liuq901 for implementation of live code bench dataset
please add @cattaria for features of competitive programming problems
please add @lseven-rs for the frontend of playground page
please add @BytedSS0 for implementation of humaneval dataset
please add @aoyanli for implementation of mbpp dataset
please add @magic3007 for implementation of verilog related datasets

@all-contributors
please add @ssine for the overall architecture of sandbox.
please add @cattaria for features of competitive programming problems.
please add @lseven-rs for the frontend of playground page.
please add @BytedSS0 for implementation of humaneval dataset.
please add @aoyanli for implementation of mbpp dataset.
please add @magic3007 for implementation of verilog related datasets.

https://github.com/all-contributors
please add @ssine for the overall architecture of sandbox.

@all-contributors
please add @ssine for the the design of overall architecture of sandbox.

@all-contributors
please add @cattaria for features of competitive programming problems.

https://github.com/all-contributors
please add @cattaria for implementation of features of competitive programming problems.

@all-contributors
please add @cattaria for implementation of features of competitive programming problems.

https://github.com/all-contributors
please add @cattaria for code and data.

@all-contributors
please add @cattaria for code and data.

@all-contributors
please add @lseven-rs for design.
please add @BytedSS0 for code and data.
please add @aoyanli for code and data.
please add @magic3007 for code and data.

@all-contributors
please add @lseven-rs for design.
please add @aoyanli for code and data.
please add @magic3007 for code and data.

@all-contributors
please add @aoyanli for code and data.
please add @magic3007 for code and data.

@all-contributors
please add @aoyanli for code and data.

@all-contributors
please add @magic3007 for code and data.

https://github.com/all-contributors
please add @magic3007 for code and data.


SubjectSerializer includes seen_all_live_data for each subject

SubjectSerializer includes seen_all_live_data for each subject. Relevant line is
!!(user_seen && (user_seen.workflow.subject_ids.uniq.sort == user_seen.subject_ids.uniq.sort))
If a user has seen all the subjects in the workflow, it'll be true and be included with each sample. If not, then the value will be false for all subjects (including those which have been seen).
Review checklist

[ ] First, the most important one: is this PR small enough that you can actually review it? Feel free to just reject a branch if the changes are hard to review due to the length of the diff.
[ ] If there are any migrations, will they the previous version of the app work correctly after they've been run (e.g. the don't remove columns still known about by ActiveRecord).
[ ] If anything changed with regards to the public API, are those changes also documented in the apiary.apib file?
[ ] Are all the changes covered by tests? Think about any possible edge cases that might be left untested.

Will this run a query for each subject being serialized in the response, or will that get cached somewhere so that it runs just one?

Ah - good point @marten.
Maybe we could just inject it into the selection context like we do here and then just reference that in the above (maybe change the serialized attribute to finished_worfklow)?

Would it solve both to just change that line to
@finished_workflow ||= !!(user_seen && (user_seen.user.has_finished?(user_seen.workflow)
? If the class instance is the same for each subject it should only need to ask once, and it seems like User#finished? is doing the same thing I was trying for, anyway.

you would have to do it for the context that is passed to the page method on the serializer. Otherwise it'd do that method for each subject and ignore the cached instance var (as it's a different subject being serialized)

Change the serializer attribute back to optional and this looks good to me. Nice work @zwolf!


order GET response for resource

I'm trying to order my GET response for '/users' by last name. I was able to do it by overwriting the default fetchAll() on the User resource. But when I do that I lose all of the built-in pagination and relationship management functionality. Is there are a better way to do this? Maybe through Events?

This repository was created just for external order by and filtering:
https://github.com/API-Skeletons/zf-doctrine-querybuilder


Store especially large unsigned integers as numeric

Columns that have values larger than<PHONE_NUMBER>854775808 could be stored directly as numeric(20,0) rather than bigint.  This would eliminate the need for the unit64() function.  Columns that have no values that would be negative as a signed integer could remain bigint.  The storage is 16 bytes versus 8 bytes.

Potential gotcha: how would numeric(20,0) translate into ADQL?


Replace link to neodev.nvim with link to lazydev.nvim

neodev.nvim is now end of life and users are encouraged to migrate to lazydev.nvim.
Fixes https://github.com/nvim-neotest/neotest/issues/417

Thank you!


Counting divisible Substrings

Description
|| 8th Mar 2022 || HackWithInfy || Infosys ||

You are given a string Str of length N. Each character of the string is a base 10 digit.

Your task is to find the total number of substrings of Str such that the number denoted by the string Str[i...j] is divisible by 6. Since that result can be a very large return it is modulo 10^9+7.

Notes:
* It is given that a number denoted by Str[i..j] can have leading Zeroes.

Input Format
The first line contains an integer, N, denoting the length of the given string.
The next line contains a string, Str, denoting the given string.

Constrains
1 <= N <= 10^5
1 <= len(Str) <= 10^5

        Sample Input
        Sample Output
        Explanation

        3328
        0
        No substring is divisible by 6

        3318
        2
        "18","318" divisible by 6

        46151
        1
        "6" divisible by 6

Domain
Competitive Programming
Type of Contribution
Addition
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of LearnCPP.

/assign

I have created another issue that has not been merged yet

/assign


Initial implementation

Everything is new
Added

.coveragerc file
.flake8 file
.gitignore file bases on latest
Python gitignore template
Default workflows
Script to create report directories
unittest.cfg file
requirements.txt file to interact with the uPy board
requirements-test.txt file to install packages for unittests
requirements-deploy.txt file to install packages to deploy
Initial be_upy_blink package
Basic unittests for package source code
Initial root README
setup.py and sdist_upip.py file

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@522bd46). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             main        #1   +/-   ##
========================================
  Coverage        ?   100.00%
========================================
  Files           ?         3
  Lines           ?        14
  Branches        ?         1
========================================
  Hits            ?        14
  Misses          ?         0
  Partials        ?         0

Flag
Coverage Δ

unittests
100.00% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

LGTMyself, let's automatically deploy to PyPi

a great success, checkout micropython-package-template on PyPi


go get error:gcc_darwin_amd64.c:62:15: error: unknown token in expression

my go version is
go version go1.15.15 darwin/amd64

when i use
go get github.com/etcd-io/zetcd/cmd/zetcd

and it's shows below
(gs) bifenglin@bifenglindeMacBook-Pro GraphScope % go get github.com/etcd-io/zetcd/cmd/zetcd
# runtime/cgo
gcc_darwin_amd64.c:62:15: error: unknown token in expression
<inline asm>:1:12: note: instantiated into assembly here
gcc_darwin_amd64.c:62:15: error: invalid operand
<inline asm>:1:12: note: instantiated into assembly here

It's M1 mac system.

fixed by update the go version


access to path is denied on mac OSX

Hi,
I'm running on OSX with dotnet core 2.2 installed, i can generate the coverage when i do sudo, when i don't, i'm getting:
/Users/me/.nuget/packages/coverlet.msbuild/2.6.3/build/coverlet.msbuild.targets(41,5): error :

Access to the path '/Users/me/Desktop/repo/BuildReports/Coverage/coverage.cobertura.xml' is denied.

[/Users/me/Desktop/repo/test.csproj]

This is the script i'm executing
#!/bin/bash

dotnet test --logger 'trx;LogFileName=TestResults.trx' \
                 --logger 'xunit;LogFileName=TestResults.xml' \
                 --results-directory "./BuildReports/UnitTests" \
                 /p:CollectCoverage=true \
                 /p:CoverletOutput="./BuildReports/Coverage/" \
                 /p:CoverletOutputFormat=cobertura \
                 /p:Exclude='[xunit.*]*'

dotnet reportgenerator -reports:"BuildReports/Coverage/coverage.cobertura.xml" -targetdir:BuildReports/Coverage -reporttypes:"HTML;HTMLSummary"

Is sudo required?

Sorry to waste anyone's time, but i've ran the script with sudo the first time round and caused the file to be only accessible by root. After cleaning the files and reran without sudo, it works perfectly fine.


REGISTER_INDEX

Hi, REGISTER_INDEX is used as parameter in the instantiation of the module rggen_default_register but the parameter REGISTER_INDEX is not defined in the module rggen_default_register.

This creates an issue while running the synthesis.

I think RgGen which you're using is the previous version.
Can you update RgGen and then generate RTL again?

@haridevang ,
Is your problem resolved?


Update theme to use o2r color scheme

It would be nice to switch primary and secondary colors for something "more o2r-ish". This might help: https://material-ui.com/customization/theming/
Buttons, links, clicked links

Buttons, status colors

Color suggestions

@NJaku01 Can you check that? I think the ULB grey would fit

Of course I can take care of it, the buttons should then be in ifgi-blue or? What exactly should the ulb grey be used for?

We can try out both for the buttons o2r-blue and ulb-grey. Just post two screenshots and then we vote

ifgi-blue

ulb-grey

@NJaku01 Don't forget the toasters:

seems done


docs: Add EIP1193 extension documentation

Problem solved
Short description of the bug fixed or feature added

PR-Codex overview
This PR adds documentation annotations for EIP1193 extensions in two adapter files and updates the entry points in the typedoc.mjs script to include the new EIP1193 adapter.
Detailed summary

Added @extension EIP1193 annotation in fromProvider function in from-eip1193.ts.
Added @extension EIP1193 annotation in toProvider function in to-eip1193.ts.
Updated entry points in typedoc.mjs to include src/adapters/eip1193/index.ts.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

#5600  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


foregroundappchecker-SDK

hello,
thanks for the class. look very simple to use.
I just want to ask, i cannot use sdk 26 - max 25, there is any way to use this class in older sdk then 26?
thanks.
roey

I am facing the same issue. Did you figure a way out?


--no-modules for wasm-pack

💡 Feature description
--no-modules comes with wasm-bindgen-cli and it's needed for some bundlers.

i agree that wasm-pack should support all the options that wasm-bindgen has! i am curious which bundlers need to use --no-modules (just for my own edification!). thanks for filing this :)

The default wasm loader of Parcel doesn’t support an export object. So I need to replace the wash loader with the no ES module js file generated by wasmbindgen.
Friday, September 21, 2018, 00:45 +0800 from<EMAIL_ADDRESS><EMAIL_ADDRESS>
i agree that wasm-pack should support all the options that wasm-bindgen has! i am curious which bundlers need to use --no-modules (just for my own edification!). thanks for filing this :)
—
You are receiving this because you authored the thread.
Reply to this email directly,  view it on GitHub , or  mute the thread .

oh! interesting. we've been working with the Parcel team, and i am aware that the current way they handle wasm is slightly different from the webpack use case. thanks for the information.
tagging in @jamiebuilds - is supporting for an export object in the wasm loader on the roadmap? would like to hear your general thoughts on this (and anyone else on the team that might be working on this!) thanks :D

@catsigma i'm gonna work on getting this in for 0.5.0 case (regardless of how the follow up with the Parcel folks shakes out) thanks again so much for the info! it's very helpful :)

Thanks so much. 👍
Friday, September 21, 2018, 23:03 +0800 from<EMAIL_ADDRESS><EMAIL_ADDRESS>
@catsigma i'm gonna work on getting this in for 0.5.0 case (regardless of how the follow up with the Parcel folks shakes out) thanks again so much for the info! it's very helpful :)
—
You are receiving this because you were mentioned.
Reply to this email directly,  view it on GitHub , or  mute the thread .

oh! as a followup- @catsigma what package.json keys would you want? any? perhaps browser?

Hey @catsigma, could you share what you're doing in https://github.com/catsigma/parcel-plugin-wasmbindgen ? Just trying to figure out what Parcel is missing

@jamiebuilds What I've done is pretty simple.

Hook my custom .rs asset in Parcel.
Compile the imported .rs file in .js file by using wasm-pack or cargo & wasm-bindgen-cli.
Get the generated no-modules JS adaptor and modify it to be a Parcel wasm loader.
Hook the modified wasm loader.
Disguise the .rs file as a .js file coding with importing the wasm file and exporting exports functions of it.
Parcel does the bundle job.

The problem in Parcel is that the default wasm loader doesn't contain an __exports argument.
So we can only use these i32 i64 f32 f64 types.

@ashleygwilliams sorry, but I don't know what is the key in package.json for?

@ashleygwilliams @jamiebuilds
I've figured out a way to overcome this issue by modifying es-modules version to no-modules version.
github: https://github.com/catsigma/parcel-plugin-wasm.rs
npm: https://www.npmjs.com/package/parcel-plugin-wasm.rs
And it supports both wasm-pack and wasm-bindgen-cli now.
Thank you both.


[FEATURE REQUEST]: Innovation backlog app not responsive yet

Describe the bug
Hi, the new DLP editor app in the new version of the CoE is very nice. Certainly because it is responsive.
For the innovation backlog app, there is a lot on a single "tablet" screen that is small.
Is it possible to make the "Innvotation backlog" app responsive for the next CoE version?

Hello! When we started working on the Innovation Backlog, responsive layouts were not yet available. As there is no easy way to upgrade to responsive layouts, we would have to re-do the Innovation Backlog screen by screen to make it responsive. Whilst we are certainly looking to make all apps responsive, it will likely take some more time to achieve that.


Challenge validation

Part of https://github.com/spacemeshos/go-spacemesh/issues/3458.
Closes #146
Added validation of submitted poet challenge according to the rules described in https://github.com/spacemeshos/go-spacemesh/issues/3458.
The new Submit API is still halfway. Missing functionality is mentioned in TODOs. It will come in subsequent PRs.

Superseded by #159


Connection Lost Issue

Issue Description:
Updating my server to version 190 and the server starts up fine but when I try and join,
the server crashes

Affected Versions (Do not use "latest"):

EnderIO: 1.10.2-3.1.190
EnderCore: 1.10.2-<IP_ADDRESS>
Minecraft: 1.10.2
Forge: 1.10.2-<IP_ADDRESS>7-universal

Your most recent log file where the issue was present:
[pastebin/gist/etc link here]
Crash Report
https://pastebin.com/ic1PsMDk

I have confirmed that the newest version crashes my server when a Farming Station is placed in the world

That's not Ender IO, that is this code:
at net.minecraft.world.World.handler$onConstructed$zjp000(World.java:4784)

which is patched in by some other software and does funky thinks before the World object is fully constructed. Calling methods on a non-final object from the constructor is not supported by Java.

PS: Please report this to Sponge and add this information:
This crash cannot be fixed by Ender IO. Java does not support calling non-final methods from the constructor. It isn't actively stopping you doing it, and under certain circumstances it works fine---e.g. if the method does not access this. Here, however, doing so is completely unnecessary; the World class has a init() method that is called directly after the object is constructed:
net.minecraft.server.MinecraftServer.loadAllWorlds(...) {
...
WorldServer world = new WorldServer(...).init();

Fixed with a workaround as you suggested to use the init() method instead, however I would like to point something out:
While the issue is in fact a problem of initialization ordering, there's something that your PickupWorld is overcomplicating: Using the wrapper object without utilizing the already existing fields of the wrapped world for the call to the super constructor.
Here, you're calling the super constructor with null WorldInfo objects, instead of utilizing the wrapper.getWorldInfo(), which would recycle the use of the now wrapped WorldInfo object. If you were to recycle that usage and call instead:
  public PickupWorld(World wrapped, FakePlayerEIO player) {
    super(wrapped.getSaveHandler(), wrapped.getWorldInfo(), wrapped.provider, null, false);
    this.wrapped = wrapped;
    this.player = player;
  }

You would not have to override a few methods, including getWorldInfo(), getSaveHandler(), and a few other ones that involve those two objects.
That being said, it is the fault of Sponge for expecting something to not be overridden or initialized, but just passing around some potentially beneficial knowledge.
This issue should be closed now since SpongeForge builds with the fix are now published and deployed.

I already added those modifications, I just didn't check them in because some people ignore their issues if the other side has a workaround. In this case it was a value I could do this for by chance, but I'd rather have this fixed for all cases.
BTW, I originally left those out because I wanted to avoid side effects from other mods adding their hooks into them.  ;)


bevdet4d && occ-bev occupancy prediction result

bevdet4d && occ-bev occupancy prediction result is based-on swin-tiny or r-101 dcn backbone?

swin-tiny

swin-tiny


[wip] dashboard builder v2 (#4528)

[dashboard builder] Add dir structure for dashboard/v2, simplified Header, split pane, Draggable side panel

[grid] add , , and initial grid components.
[grid] gridComponents/ directory, add fixtures/ directory and test layout, add
[grid] working grid with gutters
[grid] design tweaks and polish, add
[header] add gradient header logo and favicon
[dnd] begin adding dnd functionality
[dnd] add util/isValidChild.js
[react-beautiful-dnd] iterate on dnd until blocked
[dnd] refactor to use react-dnd
[react-dnd] refactor to use composable  structure
[dnd] factor out DashboardComponent, let components render dropInidcator and set draggableRef, add draggable tabs
[dnd] refactor to use redux, add DashboardComponent and DashboardGrid containers
[dragdroppable] rename horizontal/vertical => row/column
[builder] refactor into HoverMenu, add WithPopoverMenu
[builder] add editable header and disableDragDrop prop for Dragdroppable's
[builder] make tabs editable
[builder] add generic popover dropdown and header row style editability
[builder] add hover rowStyle dropdown, make row styles editable
[builder] add some new component icons, add popover with delete to charts
[builder] add preview icons, add popover menu to rows.
[builder] add IconButton and RowStyleDropdown
[resizable] use ResizableContainer instead of DimensionProvider, fix resize and delete bugs
[builder] fix bug with spacer
[builder] clean up, header.size => header.headerSize
[builder] support more drag/drop combinations by wrapping some components in rows upon drop. fix within list drop index. refactor some utils.
[builder][tabs] fix broken add tab button
[dashboard builder] don't pass dashboard layout to all dashboard components, improve drop indicator logic, fix delete component pure component bug
[dnd] refactor drop position logic

fix rebase error, clean up css organization and use @less vars

[dashboard-builder] add top-level tabs + undo-redo (#4626)

[top-level-tabs] initial working version of top-level tabs

[top-level-tabs] simplify redux and disable ability to displace top-level tabs with other tabs

[top-level-tabs] improve tab drag and drop css

[undo-redo] add redux undo redo

[dnd] clean up dropResult shape, add new component source id + type, use css for drop indicator instead of styles and fix tab indicators.

[top-level-tabs] add 'Collapse tab content' to delete tabs button

[dnd] add depth validation to drag and drop logic

[dashboard-builder] add resize action, enforce minimum width of columns, column children inherit column size when necessary, meta.rowStyle => meta.background, add background to columns

[dashboard-builder] make sure getChildWidth returns a number

[dashboard builder] static layout + toasts (#4763)

[dashboard-builder] remove spacer component

[dashboard-builder] better transparent indicator, better grid gutter logic, no dragging top-level tabs, headers are multiples of grid unit, fix row height granularity, update redux state key dashboard => dashboardLayout

[dashboard-builder] don't blast column child dimensions on resize

[dashboard-builder] ResizableContainer min size can't be smaller than size, fix row style, role=none on WithPopoverMenu container

[edit mode] add edit mode to redux and propogate to all s

[toasts] add Toast component, ToastPresenter container and component, and toast redux actions + reducers

[dashboard-builder] add info toast when dropResult overflows parent

[dashboard builder] git mv to src/ post-rebase

Dashboard builder rebased + linted (#4849)

define dashboard redux state

update dashboard state reducer

dashboard layout converter + grid render

builder pane + slice adder

Dashboard header + slice header controls

fix linting

2nd code review comments

[dashboard builder] improve perf (#4855)

address major perf + css issues

[dashboard builder] fix dashboard filters and some css
[dashboard builder] use VIZ_TYPES, move stricter .eslintrc to dashboard/, more css fixes
[builder] delete GridCell and GridLayout, remove some unused css. fix broken tabs.

[builder] fix errors post-rebase

[builder] add support for custom DragDroppable drag layer and add AddSliceDragPreview

[AddSliceDragPreview] fix type check

[dashboard builder] add prettier and update all files

[dashboard builder] merge v2/ directory int dashboard/

[dashboard builder] move component/Container => containers/

add sticky tabs + sidepane, better tabs perf, better container hierarchy, better chart header (#4893)

dashboard header, slice header UI improvement

add slider and sticky

dashboard header, slice header UI improvement

make builder pane floating

[dashboard builder] add sticky top-level tabs, refactor for performant tabs

[dashboard builder] visually distinct containers, icons for undo-redo, fix some isValidChild bugs

[dashboard builder] better undo redo <> save changes state, notify upon reaching undo limit

[dashboard builder] hook up edit + create component actions to saved-state pop.

[dashboard builder] visual refinement, refactor Dashboard header content and updates into layout for undo-redo, refactor save dashboard modal to use toasts instead of notify.

[dashboard builder] refactor chart name update logic to use layout for undo redo, save slice name changes on dashboard save

add slider and sticky

[dashboard builder] fix layout converter slice_id + chartId type casting, don't change grid size upon edit (perf)

[dashboard builder] don't set version key in getInitialState

[dashboard builder] make top level tabs addition/removal undoable, fix double sticky tabs + side panel.

[dashboard builder] fix sticky tabs offset bug

[dashboard builder] fix drag preview width, css polish, fix rebase issue

[dashboard builder] fix side pane labels and hove z-index

Markdown for dashboard (#4962)

fix dashboard server-side unit tests (#5009)

Dashboard save button (#4979)

save button

fix slices list height

save custom css

merge save-dash changes from dashboard v1
https://github.com/apache/incubator-superset/pull/4900
https://github.com/apache/incubator-superset/pull/5051

[dashboard v2] check for default_filters before json_loads-ing them (#5064)

[dashboard v2] check for default_filters before json-loads-ing them

[dashboard v2] fix bugs from rebase

[dashboard v2] tests! (#5066)

[dashboard v2][tests] add tests for newComponentFactory, isValidChild, dropOverflowsParent, and dnd-reorder

[dashboard v2][tests] add tests for componentIsResizable, findParentId, getChartIdsFromLayout, newEntitiesFromDrop, and getDropPosition

[dashboard v2][tests] add mockStore, mockState, and tests for DragDroppable, DashboardBuilder, DashboardGrid, ToastPresenter, and Toast

[dashboard builder][tests] separate files for state tree fixtures, add ChartHolder, Chart, Divider, Header, Row tests and WithDragDropContext helper

[dashboard v2][tests] fix dragdrop context with util/getDragDropManager, add test for menu/* and resizable/*, and new components

[dashboard v2][tests] fix and re-write Dashboard tests, add getFormDataWithExtraFilters_spec

[dashboard v2][tests] add reducer tests, fix lint error

[dashboard-v2][tests] add actions/dashboardLayout_spec

[dashboard v2] fix some prop bugs, open side pane on edit, fix slice name bug

[dashboard v2] fix slice name save bug

[dashboard v2] fix lint errors

[dashboard v2] fix filters bug and add test

[dashboard v2] fix getFormDataWithExtraFilters_spec

[dashboard v2] logging updates (#5087)

[dashboard v2] initial logging refactor

[dashboard v2] clean up logger

[logger] update explore with new log events, add refresh dashboard + refresh dashboard chart actions

[logging] add logger_spec.js, fix reducers/dashboardState_spec + gridComponents/Chart_spec

[dashboard v2][logging] refactor for bulk logging in python

[logging] tweak python, fix and remove dup start_offset entries

[dashboard v2][logging] add dashboard_first_load event

[dashboard v2][logging] add slice_ids to dashboard pane load event

[tests] fix npm test script

Fix: update slices list when add/remove multiple slices (#5138)

[dashboard v2] add v1 switch (#5126)

[dashboard] copy all dashboard v1 into working v1 switch

[dashboard] add functional v1 <> v2 switch with messaging

[dashboard] add v2 logging to v1 dashboard, add read-v2-changes link, add client logging to track v1 <> v2 switches

[dashboard] Remove default values for feedback url + v2 auto convert date

[dashboard v2] fix misc UI/UX issues

[dashboard v2] fix Markdown persistance issues and css, fix copy dash title, don't enforce shallow hovering with drop indicator

[dashboard v2] improve non-shallow drop target UX, fix Markdown drop indicator, clarify slice adder filter/sort

[dashboard v2] delete empty rows on drag or delete events that leave them without children, add test

[dashboard v2] improve v1<>v2 switch modals, add convert to v2 badge in v1, fix unsaved changes issue in preview mode, don't auto convert column child widths for now

[dashboard v2][dnd] add drop position cache to fix non-shallow drops

[dashboard] fix test script with glob instead of recurse, fix tests, add temp fix for tab nesting, ignore v1 lint errors

[dashboard] v2 badge style tweaks, add back v1 _set_dash_metadata for v1 editing

[dashboard] fix python linting and tests

[dashboard] lint tests

add slice from explore view (#5141)

Fix dashboard position row data (#5131)

add slice_name to markdown

(cherry picked from commit 14b01f1)

set min grid width be 1 column

remove empty column

check total columns count <= 12

scan position data and fix rows

fix dashboard url with default_filters

[dashboard v2]  better grid drop ux, fix tab bugs 🐛 (#5151)

[dashboard v2] add empty droptarget to dashboard grid for better ux and update test

[dashboard] reset tab index upon top-level tab deletion, fix findparentid bug

[dashboard] update v1<>v2 modal link for tracking

Fix: Should pass slice_can_edit flag down (#5159)

[dash builder fix] combine markdown and slice name, slice picker height (#5165)

combine markdown code and markdown slice name

allow dynamic height for slice picker cell

add word break for long datasource name

[fix] new dashboard state (#5213)

[dashboard v2] ui + ux fixes (#5208)

[dashboard v2] use  throughout, small loading gif, improve row/column visual hierarchy, add cached data pop

[dashboard v2] lots of polish

[dashboard v2] remove markdown padding on edit, more opaque slice drag preview, unsavedChanges=true upon moving a component, fix initial load logging.

[dashboard v2] gray loading.gif, sticky header, undo/redo keyboard shortcuts, fix move component saved changes update, v0 double scrollbar fix

[dashboard v2] move UndoRedoKeylisteners into Header, render only in edit mode, show visual feedback for keyboard shortcut, hide hover menu in top-level tabs

[dashboard v2] fix grid + sidepane height issues

[dashboard v2] add auto-resize functionality, update tests. cache findParentId results.

[dashboard v2][tests] add getDetailedComponentWidth_spec.js

[dashboard v2] fix lint

[fix] layout converter fix (#5218)

[fix] layout converter fix

add changed_on into initial sliceEntity data

add unit tests for SliceAdder component

remove old fixtures file

[dashboard v2] remove webpack-cli, fresh yarn.lock post-rebase

[dashboard v2] lint javascript

[dashboard v2] fix python tests

[Fix] import/export dash in V2 (#5273)

[dashboard v2] add markdown tests (#5275)

[dashboard v2] add Markdown tests

[dashboard v2][mocks] fix markdown mock

(cherry picked from commit c065319)
@williaster @john-bodley @michellethomas @timifasubaa

Codecov Report

Merging #59 into airbnb-master will decrease coverage by 1.99%.
The diff coverage is 52.01%.

@@               Coverage Diff                @@
##           airbnb-master      #59     +/-   ##
================================================
- Coverage          63.48%   61.49%     -2%
================================================
  Files                261      370    +109
  Lines              19794    23546   +3752
  Branches            1992     2737    +745
================================================
+ Hits               12566    14479   +1913
- Misses              7219     9055   +1836
- Partials               9       12      +3

Impacted Files
Coverage Δ

...perset/assets/src/explore/components/SaveModal.jsx
93.82% <ø> (ø)
:arrow_up:

.../dashboard/util/logging/findNonTabChildChartIds.js
0% <ø> (ø)

...t/assets/src/dashboard/util/newComponentFactory.js
100% <ø> (ø)

superset/assets/src/visualizations/nvd3_vis.js
8.57% <ø> (-0.02%)
:arrow_down:

...ts/src/dashboard/util/getDetailedComponentWidth.js
100% <ø> (ø)

superset/connectors/sqla/models.py
78.13% <ø> (+0.04%)
:arrow_up:

superset/assets/src/dashboard/util/findParentId.js
100% <ø> (ø)

...et/assets/src/dashboard/util/getDragDropManager.js
100% <ø> (ø)

.../assets/src/dashboard/util/shouldWrapChildInRow.js
100% <ø> (ø)

...sets/src/explore/components/ExploreChartHeader.jsx
71.42% <ø> (ø)
:arrow_up:

... and 282 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67db310...ddd69a5. Read the comment docs.

LGTM


Doesn't work with GE62

I got such response

Is your keyboard per key rgb?

From the pictures it looks like your laptop keyboard has region-based (not per-key) RGB lighting. In that case msi-perkeyrgb won't work, you need something like MSIKLM instead.


Unexpected queue declare-ok received

Hello,
While testing we encountered the following error which lead to issues with our application. While we need to improve the error handling on our side we also want to investigate what caused this possible protocol violation.
Nov 11 11:48:10.338 ERROR lapin::channel: unexepcted queue declare-ok received on channel 1
Nov 11 11:48:10.338 ERROR lapin::channels: Connection error: protocol error: AMQP hard error: UNEXPECTED-FRAME: unexepcted queue declare-ok received on channel 1

We use rabbitmq v 3.8 and lapin v1.8.
This happened the first time so we are not sure yet how to reproduce this. Do you have any idea how to debug this further or even an idea what caused this?

So you have any other logs around this?

Without looking at the code and without debug logs, the most likely problem would be some kind of race condition where we would get the declare-ok before having our internal state up to date. This obviously shouldn't happen, will try and brute force the problem to see if I can reproduce.
What parameters did you pass queue_declare? Did the queue already exist?

Our lapin log level was set to WARN so we only have these log lines from lapin.
We might have created up to 10 tasks, each creating a rabbitmq queue and multiple bindings at the same time. So a race condition sounds possible.
The origin seems to be this call
        let queue_options = QueueDeclareOptions {
            auto_delete: true,
            ..Default::default()
        };

        let queue = self
            .rabbitmq_channel
            .queue_declare(
                &format!("{}.{}", room_exchange, self_routing_key),
                queue_options,
                Default::default(),
            )
            .await?;

I added more information in that failure log in 1.8.1

Have the same issue with 1.8.1 version. Switched back into 1.7.1 and issue gone.

Hmm. To be honest we found out, that our crashed build was actually using 1.7.1. So the issue seems to be present in 1.7 and 1.8.
Did you get some context information from the added log @nicoth-in ?

Okay, I am getting same error in 1.7.1 version, you right @valkum

It seems you get that error more often then we are. Are you able to create a small repro case?

I think, the reason is that the que is being deleted too fast after creation.

If you can reproduce with 1.8.1, what is the error message (which is the
thing I modified in 1.8.1)
On Mon 22 Nov 2021 at 11:36, Duck @.***> wrote:

I think, the reason is that the que is being deleted too fast after
creation.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/CleverCloud/lapin/issues/353#issuecomment-975384504,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABWNXRXMFSE2BBUV5I45HLUNIMMFANCNFSM5H2IDLMQ
.

Also, if you manage to reproduce with trace logs that could help a lot too
On Mon 22 Nov 2021 at 11:53, Marc-Antoine Perennou <
@.***> wrote:

If you can reproduce with 1.8.1, what is the error message (which is the
thing I modified in 1.8.1)
On Mon 22 Nov 2021 at 11:36, Duck @.***> wrote:

I think, the reason is that the que is being deleted too fast after
creation.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/CleverCloud/lapin/issues/353#issuecomment-975384504,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABWNXRXMFSE2BBUV5I45HLUNIMMFANCNFSM5H2IDLMQ
.

We also got a unexpected queue bind-ok right now with 1.8.1
(Added some newlines)
AMQP hard error: UNEXPECTED-FRAME: unexpected queue bind-ok received on channel 1, was awaiting for
Some(
    BasicConsumeOk(
        Pinky,
        Some(
            ChannelCloser {
                id: 1,
                status: ChannelStatus {
                    state: Connected,
                    receiver_state: ChannelReceiverStates([]),
                    confirm: false,
                    send_flow: true
                }
            }
        ),
        ShortString("myqueue"),
        BasicConsumeOptions {
            no_local: false,
            no_ack: false,
            exclusive: false,
            nowait: false
        },
        FieldTable({}),
        None
    )
)

So, I managed to reproduce with a quite simple example:
           let queue = format!("hello{}", i);
            let _ = channel
                .queue_declare(
                    &queue,
                    QueueDeclareOptions {
                        auto_delete: true,
                        ..QueueDeclareOptions::default()
                    },
                    FieldTable::default(),
                );
            let _ = channel
                .basic_consume(
                    &queue,
                    format!("consumer{}", i).as_str(),
                    BasicConsumeOptions::default(),
                    FieldTable::default(),
                );
        }

basically, creating queues and consuming in a loop without awaiting the result
With this in place, there are three relevant extracts of the logs:
The management of expected replies looks like this:
[2021-11-23T12:21:35Z TRACE lapin::frames] channel 1 state is now waiting for ExpectedReply(QueueDeclareOk(Pinky, QueueDeclareOptions { passive: false, durable: false, exclusive: false, auto_delete: true, nowait: false }, FieldTable({})))
[2021-11-23T12:21:35Z TRACE lapin::frames] channel 1 state is now waiting for ExpectedReply(BasicConsumeOk(Pinky, Some(ChannelCloser { id: 1, status: ChannelStatus { state: Connected, receiver_state: ChannelReceiverStates([]), confirm: false, send_flow: true } }), ShortString("hello1"), BasicConsumeOptions { no_local: false, no_ack: false, exclusive: false, nowait: false }, FieldTable({}), None))
[2021-11-23T12:21:35Z TRACE lapin::frames] channel 1 state is now waiting for ExpectedReply(QueueDeclareOk(Pinky, QueueDeclareOptions { passive: false, durable: false, exclusive: false, auto_delete: true, nowait: false }, FieldTable({})))
[2021-11-23T12:21:35Z TRACE lapin::frames] channel 1 state is now waiting for ExpectedReply(BasicConsumeOk(Pinky, Some(ChannelCloser { id: 1, status: ChannelStatus { state: Connected, receiver_state: ChannelReceiverStates([]), confirm: false, send_flow: true } }), ShortString("hello2"), BasicConsumeOptions { no_local: false, no_ack: false, exclusive: false, nowait: false }, FieldTable({}), None))

Each one of these logs adds an expected reply to a queue, which thus contains declare-ok, consume-ok, declare-ok, consume-ok as expected. At first when reading this bug, I thought the only possible cause would be for this queue to be inconsistent, and I didn't find any way how it could be... and it indeed isn't, it is perfectly consistent.

The actual sending of the AMQP Frames looks like this:
[2021-11-23T12:21:35Z TRACE lapin::io_loop] will write to buffer: AMQPFrame::Method(Queue(Declare(Declare { queue: ShortString("hello1"), passive: false, durable: false, exclusive: false, auto_delete: true, nowait: false, arguments: FieldTable({}) })))
[2021-11-23T12:21:35Z TRACE lapin::io_loop] will write to buffer: AMQPFrame::Method(Basic(Consume(Consume { queue: ShortString("hello1"), consumer_tag: ShortString("consumer1"), no_local: false, no_ack: false, exclusive: false, nowait: false, arguments: FieldTable({}) })))
[2021-11-23T12:21:35Z TRACE lapin::io_loop] will write to buffer: AMQPFrame::Method(Queue(Declare(Declare { queue: ShortString("hello2"), passive: false, durable: false, exclusive: false, auto_delete: true, nowait: false, arguments: FieldTable({}) })))
[2021-11-23T12:21:35Z TRACE lapin::io_loop] will write to buffer: AMQPFrame::Method(Basic(Consume(Consume { queue: ShortString("hello2"), consumer_tag: ShortString("consumer2"), no_local: false, no_ack: false, exclusive: false, nowait: false, arguments: FieldTable({}) })))

One possible area would have been if, for some reason, we failed at sending frames and didn't retry in the proper order. For this, I couldn't figure out one way for it to be possible... and indeed, the frames are sent in the correct order

Now, for the interesting part, the replies from the server:
[2021-11-23T12:21:35Z TRACE lapin::channels] will handle frame: Method(1, Queue(DeclareOk(DeclareOk { queue: ShortString("hello1"), message_count: 0, consumer_count: 0 })))
[2021-11-23T12:21:35Z TRACE lapin::channels] will handle frame: Method(1, Queue(DeclareOk(DeclareOk { queue: ShortString("hello2"), message_count: 0, consumer_count: 0 })))
[2021-11-23T12:21:35Z ERROR lapin::channel] unexpected queue declare-ok received on channel 1, was awaiting for Some(BasicConsumeOk(Pinky, Some(ChannelCloser { id: 1, status: ChannelStatus { state: Connected, receiver_state: ChannelReceiverStates([]), confirm: false, send_flow: true } }), ShortString("hello1"), BasicConsumeOptions { no_local: false, no_ack: false, exclusive: false, nowait: false }, FieldTable({}), None))

Wait, so... we receive two declare-ok in a row, when we asked for a consume inbetween? From what I gathered from the specifications and from what I observed until now, I was pretty sure the asnwers were always in the same order as the requests. This either is a bug in rabbitmq or in my perception of AMQP.
For now, let's assume it's the latter and I'll issue a fix shortly this week, I'll investigate further later on to see if it can be the former.

While we're at it: I'm mostly maintaining this in my spare personal time nowadays, so if your company uses lapin for professional use, they may consider sponsoring me if they're happy with my work :) https://github.com/sponsors/Keruspe

Discussion opened upstream: https://groups.google.com/g/rabbitmq-users/c/t95tmva8leM

1.9.0 should be ok! Please tell me if the problem is gone for you too :)

Btw, it seems upstream agrees the replies should be in order and the official python and Java clients may have the same bug!


ocamlPackages.printbox: 0.5 → 0.6; ocamlPackages.printbox-text: init at 0.6

Motivation for this change
Compatibility with mdx ≥ 2.0
cc maintainer @romildo.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 157577 run on x86_64-linux 1

3 packages built:

ocamlPackages.phylogenetics
ocamlPackages.printbox
ocamlPackages.printbox-text


[Bug] audio manager middleware

Purpose

Migrate AudioManager device switch from a coroutine to middleware for stability.

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type
What kind of change does this Pull Request introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[X] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Test the code

Connect an audio device (e.g. bluetooth)
Disconnect, toggle audio device selection
Rotate phone and repeat.
If it tracks the proper selection, doesn't get stuck, and the checkmark doesn't disappear, this is working.

## What to Check
Verify that the following are valid
* Audio Selection is consistent after rotation.

## Other Information
<!-- Add any other helpful information that may be needed here. -->

Closing because I have an alternate fix


ruby: remove tests that try to assert a certain behavior after forking incorrectly

This is a probable fix for b/242771103
Some tests were added a while back to assert a certain behavior (a certain exception) after forking incorrectly - i.e. after forking when grpc was already initialized in the parent process.
Such forking behavior is essentially undefined, though, and may be prone to bugs with locks being in a bad state, etc. So let's remove these tests.

cc @ctiller please merge when you have a chance


New OAuth Provider: Sign-in with Singpass

Feature request

Sign-in with Singpass
https://api.singpass.gov.sg/library/identiface/developers/backend-oauth2-jws

@kangmingtay was on the supabase hangout with @thorwebdev and @awalias and I think we might want to hold off since the Gov might move to use SGID

Hey all,
We plan on tracking all OAuth provider requests on https://github.com/supabase/gotrue/issues/451 so we'll be closing this issue in favor of the thread instead. Please feel free to follow along there instead.
Thanks!


VideoPlayer wrong color space when played back on a texture and viewed in 3D

Godot version: 3.0.2
Windows 10.0.16299.371
nvidia 1070 running 391.35 drivers
Using VideoPlayer to play webm or ogv does so in the incorrect color space.

On the left side the correct color space is used and reproduced in all players tested, to the right the video how it is played in Godot. Tested with both webm and ogv files that play correctly on other external players.

It would be awesome if the seek function worked too :)
https://github.com/godotengine/godot/issues/14430

Can anyone still reproduce this bug in Godot 3.2.3 or any later release?
If yes, please ensure that an up-to-date Minimal Reproduction Project (MRP) is included in this report (a MRP is a zipped Godot project with the minimal elements necessary to reliably trigger the bug). You can upload ZIP files in an issue comment with a drag and drop.

I'm a newbie at Godot, so idk if I'm doing something wrong but I'm having this problem in 3.3.4
I am using a ogv file for this. the 2d version works but the colors are flushed out in 3D one, using viewport.
Here's the project that this is happening with.
color_bug.zip

@Ruthoranium Can you reproduce this after switching to the GLES2 renderer?

I tested this on Godot 3.5.rc5. This is not a bug; it's due to incorrect configuration. You need to force sRGB on the material displaying the ViewportTexture, similar to what's done in the GUI in 3D demo.
I recommend using a MeshInstance with a QuadMesh and a ViewportTexture assigned, but if you want to keep using Sprite3D, you can assign a material override with the Unshaded and Albedo Tex Force Srgb flags enabled. Enable Local To Scene on the SpatialMaterial's Resource section, then set the ViewportTexture within the Albedo property. (You need to keep the Texture property set on the Sprite3D for its size to remain correct.)

color_bug_2.zip


What about testing or CI?

Maybe we'll want to write tests for the essential UI and backend processes. Like testing all the eab buttons work, adding clauses, menu traversal, json export/import, pdf export and other things to come. The things concerning browser file interaction may not be easy to test (and probably not necessary). Most of these are probably best done in the form of unit tests that also use some kind of small test DOM (if necessary) to work with. Once tests are in place a CI could be deployed to enforce them.

Activated Hound CI for style checking: https://houndci.com/repos on JS code.

Testing with https://github.com/domenic/chai-as-promised and https://mochajs.org and http://www.chaijs.com/api/bdd


[Usage]: Is there any difference between max_tokens and max_model_len?

Your current environment
vllm=0.5.4

llm = LLM(
model=MODEL_NAME,
trust_remote_code=True,
gpu_memory_utilization=0.5,
max_model_len=2048,
tensor_parallel_size=2
),
sampling_params = SamplingParams(
stop_token_ids=stop_token_ids,
use_beam_search=True,
temperature=0,
best_of=3,
max_tokens=1024
),
Is there any difference between max_tokens and max_model_len?

@youkaichao Could you help answer this question?

please use the chatbot at https://docs.vllm.ai/en/latest/

please use the chatbot at https://docs.vllm.ai/en/latest/

@youkaichao thank you, I just want to know, is there any relationship between the two? For example, I set max_model_len=1024, max_tokens=2048. The final text length generated, is < 1024 or < 2048?

max_tokens is the max tokens to generate, max_model_len is the max length model can process (including prompt and generated tokens).

max_tokens is the max tokens to generate, max_model_len is the max length model can process (including prompt and generated tokens).

when I set the max_model_len as 4096, it cause ``


useQuery().promise is not restored when staleTime is set

Describe the bug
I was trying out the new useQuery().promise implementation with the React.use() hook, and noticed two issues with it.
For the reproduction I have a very simple setup similar to the docs. There is an input that updates the q state onChange, and the following query:
useQuery({
  queryKey: [q],
  queryFn: () => getData(q),
  staleTime: 60000,
});

There's also a Data component wrapped in a Suspense, which take the promise of the query above as a prop and calls use on it. The query function takes the q, delays 1s and returns the same:
const getData = async (q) => {
  await new Promise((resolve) => setTimeout(resolve, 1000));
  return { q };
};

The first issue occurs when staleTime is set, and it still has fresh data. In this case it seems that the promise in not being restored, and incorrect data is shown. Here's a screen recording:
https://github.com/user-attachments/assets/101dd91e-fdb4-433e-85a8-4e897172821f
When typing extra characters, it correctly updated the data. However, when I remove characters (in which case it already had fresh data cached) it doesn't seem to restore the correct promise.
The devtools is showing the correct query as active, and the Data component is re-rendering. but from the console logs it seems to be receiving an incorrect promise.
<Search> requested query: "1234".  received promise results:  {q: '12345'}
<Search> requested query: "123".  received promise results:  {q: '12345'}
<Search> requested query: "12".  received promise results:  {q: '12345'}
<Search> requested query: "1".  received promise results:  {q: '12345'}

This issue does not occur when the queryFn is ran, e.g. when providing a query that is not cached or when staleTime: 0.

And the second one, the suspense is only triggering once, and not when the query changes. In the screen recording you can notice as I type "12345", it no longer triggers the suspense (which has "suspending..." as fallback), but it provides a stale promise, until it's done fetching the data for the new query.
I was expecting the suspense to trigger when the query key changes and it's about to fetch data. I thought the current behavior (i.e. show stale data until the new render is done) would have to be achieved through useDeferredValue instead.
I am not sure if this is the intended behavior, so I am did not create a new issue for it, but please let me know if I should do that.
Your minimal, reproducible example
https://codesandbox.io/p/sandbox/awesome-williamson-k2269m
Steps to reproduce
On the first issue, simply type anything in the input and notice the data under it updating. Now remove characters and notice that incorrect data is shown.
On the second issue, notice the suspense triggering when reloading the page, but not when changing the query (in which case query.isFetching is indeed true).
Expected behavior
Already explained above.
How often does this bug happen?
Every time
Screenshots or Videos
No response
Platform

OS: Windows 11
Browser: Chrome
Version: 129.0

Tanstack Query adapter
react-query
TanStack Query version
5.59.0
TypeScript version
N/A
Additional context
No response

Thanks for reporting 🙏
The first one with staleTime is definitely wrong, we need to look into this.
As for the second one, that’s also an issue 😂 . When we go to a new Query with a key that has no data, we need to suspend again. You’re absolutely right that you would need deferred values, transitions or our placeholderData: keepPreviousData feature to keep “old data” from a different key on the screen.
@KATT FYI.

here is a failing test case for the first one:
it('should show correct data when switching between cache entries without re-fetches', async () => {
      const key = queryKey()

      function MyComponent(props: { promise: Promise<string> }) {
        const data = React.use(props.promise)

        return <>{data}</>
      }

      function Loading() {
        return <>loading..</>
      }
      function Page() {
        const [count, setCount] = React.useState(0)
        const query = useQuery({
          queryKey: [key, count],
          queryFn: async () => {
            await sleep(10)
            return 'test' + count
          },
          staleTime: Infinity,
        })

        return (

            <React.Suspense fallback={<Loading />}>
              <MyComponent promise={query.promise} />
            </React.Suspense>
            <button onClick={() => setCount(count + 1)}>inc</button>
            <button onClick={() => setCount(count - 1)}>dec</button>

        )
      }

      const rendered = renderWithClient(queryClient, <Page />)
      await waitFor(() => rendered.getByText('loading..'))
      await waitFor(() => rendered.getByText('test0'))

      fireEvent.click(rendered.getByText('inc'))

      await waitFor(() => rendered.getByText('test1'))

      fireEvent.click(rendered.getByText('dec'))

      await waitFor(() => rendered.getByText('test0'))
    })

It’s also interesting / wrong that we don’t suspend in between queries. When going from test0 to test1, it’s a new cache entry, so we should see the suspense boundary again. That is, unless we would use placeholderData or useTransition.
But as it stands, if I add this as an assertion, it will also fail:
  fireEvent.click(rendered.getByText('inc'))
+ await waitFor(() => rendered.getByText('loading..'))
  await waitFor(() => rendered.getByText('test1'))

I think #8169 should fix both reported cases - please give it a try @ali-idrizi. I’ve also added two test cases for your two reported findings

Hey @TkDodo, thanks for the update. I just checked this out and it's working much better! However, I still noticed an issue with incorrect data being shown. Here's a screen recording:
https://github.com/user-attachments/assets/13a25d79-1039-4e06-8e1c-31a6016f6712
I have pushed that example in a repo: https://github.com/ali-idrizi/rq-stale-invalid-promise-reproduction.
This seems to occur only when typing faster in the input, and multiple promises are pending. I not super familiar with the inner workings of everything here, but to me it looks like this is an issue with React itself? Looking at the logs:
<Search> requested query: "1".  received promise:  pending undefined
<Search> requested query: "12".  received promise:  pending undefined
<Search> requested query: "123".  received promise:  pending undefined
<Search> requested query: "1234".  received promise:  pending undefined
<Search> requested query: "12345".  received promise:  pending undefined
<Search> requested query: "123456".  received promise:  pending undefined
<Search> requested query: "123456".  received promise:  fulfilled {q: '123456'}

The correct promise was received for every single query. However, in the recording the <Data> component was rendered multiple times for an incorrect q, even though the parent <Search> component received a fulfilled promise only once.
I tested further by instead having the <Data> component get the promise directly from useQuery instead of the props (like it's shown in the docs), and in that case it works perfectly fine. So in the repo:
-  // const response = use(useData(q).promise);
-  const response = use(query.promise);
+  const response = use(useData(q).promise);
+  // const response = use(query.promise);

@ali-idrizi thanks for trying out this feature and reporting the feedback - I really appreciate it ❤
I think I have a fix for what you are reporting here:

https://github.com/TanStack/query/pull/8171

Basically, we were resolving with data from a previous query once it resolves, which explains the intermediate data flashes. I think this was introduced with my latest refactoring, because createResult is called way more often than updateResult.
I still need to write a test for it, but maybe you can try out the preview build from that PR in the meantime and let me know if that fixes it? All other tests are still passing so I hope there is no regression (at least of paths that we are aware about):
pnpm add https://pkg.pr.new/@tanstack/react-query@8171

@TkDodo You're welcome! I'm glad to help out. I tested the new change, and it works much better when typing now.
The only potential regression that I noticed, is that it's now suspending briefly when it has cached data. I suppose in this case a fulfilled promise should be provided instead of a pending one which resolves later (that was the case previously)?
Here's a screen recording where you can see that as I remove characters from the input:
https://github.com/user-attachments/assets/599aa904-0d52-4fae-8ea6-997dbba765ad

yeah I’ll look into that too

ok, got it; this was introduced by my latest attempts to improve things 😂
I pushed another commit and more tests. can you try again?

latest commit is: https://pkg.pr.new/@tanstack/react-query@a4a2cf7

Perfect 🚀. I'll try it out on a larger repo next week, and report if I find any other issues.

alright, shipped it so that you don’t have to use preview builds for that :) enjoy 🍻

@TkDodo I looked a bit more into this, and perhaps there's one more issue. I am not sure whether what I am doing is the intended usage, so this is more of a question.
The docs show the query is being passed as a prop to the child component, and then the promise is extracted from it. That still works well! But, in a larger repo, the data might be needed quite deep in the tree or by many components, so calling the useQuery again to get the promise would be favored.
What I did in the <Search> component is simply call useData(q), so it can start prefetching (not doing anything with the results, so nothing being passed to <Data>). In the <Data> component, I am calling the same useQuery again, and getting the promise from there:
Search.js
function Search() {
  const [q, setQ] = useState("");

  useData(q); // `useData` simply calls `useQuery` and returns everything

  return (
    <>
      <input value={q} onChange={(e) => setQ(e.target.value)} />
      <Suspense fallback={
suspending...
}>
        <Data q={q} />
      </Suspense>
    </>
  );
}

Data.js
function Data({ q }) {
  const query = useData(q);
  const data = use(query.promise);

  return ...;
}

However, that works well only for the first ever fetch, if I change the q it gets stuck suspending:
https://github.com/user-attachments/assets/a1db0d69-14d4-4336-a8cb-b8ffefbca1b7
If you look at the devtools you can notice that [""] for some reason still has one observer, and ["5"] also has one instead of two. I have no idea what's happening there.
If this could work it would make getting the promise much easier, but I understand if this is not be the intended usage. Just let me know either way :)

I'll look into this as well, probably on Monday.

took a bit longer but I found it:

https://github.com/TanStack/query/pull/8211

Thanks for the update. I tried out the latest release and that is working great now!
I came across another case that suspends indefinitely. It happens consistently when the promise and the suspense are colocated, but the promise fails. I modified one of the existing test, it currently fails waiting for the error boundary. I have filed a new issue for better tracking: https://github.com/TanStack/query/issues/8219.


DocsArchive-1.0.20041.7Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/jesong/docs-archive-test-source-archive/pull/1 is merged into live branch.
Auto archive content to https://github.com/jesong/docs-archive-test-source-archive.git

Docs Build status updates of commit bc9cf69:
:clock10: Pending: waiting for processors (8 builds ahead of you)
:warning: Docs Build is busy, currently there are 8 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit bc9cf69:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error] Run script failed with no detailed information. Please retry building your content again. If the issue still happens, open a ticket in https://SiteHelp and include the error report for our team to troubleshoot

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


pythran needs -I/usr/include/openblas to use openblas

On fedora, I have openblas-devel, which provides cblas.h in /usr/include/openblas.
You could have /usr/include/cblas.h installed if you also installed atlas-devel, but I believe the correct
solution here is to include /usr/include/openblah.

That's probably a numpy issue, what's the output of
.. code-block:: console
> python -c "import numpy.distutils.system_info as numpy_sys; print(numpy_sys.get_info('openblas', 1))"

no include_dir mentionned?

python -c "import numpy.distutils.system_info as numpy_sys;
print(numpy_sys.get_info('openblas', 1))"
{'libraries': ['openblas', 'openblas'], 'library_dirs': ['/usr/lib64'],
'language': 'c', 'define_macros': [('HAVE_CBLAS', None)]}
On Thu, Jul 23, 2020 at 9:45 AM serge-sans-paille<EMAIL_ADDRESS>wrote:

That's probably a numpy issue, what's the output of
.. code-block:: console

python -c "import numpy.distutils.system_info as numpy_sys; print(numpy_sys.get_info('openblas', 1))"

no include_dir mentionned?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/serge-sans-paille/pythran/issues/1584#issuecomment-663016151,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAA4VUFHBHQB5TJDXMQAFI3R5A5JNANCNFSM4O267Q3Q
.

--
Those who don't understand recursion are doomed to repeat it

The solution could be to:

update .pythranrc with include_dirs=/usr/include/openblas
report the issue at numpy
have a workaround in Python code and add the above path for openblas, deriving it from library_dirs

What do you think?

I didn't know about include_dirs, that's just what I need.
Thanks!
On Fri, Jul 24, 2020 at 9:21 AM serge-sans-paille<EMAIL_ADDRESS>wrote:

The solution could be to:

update .pythranrc with include_dirs=/usr/include/openblas
report the issue at numpy
have a workaround in Python code and add the above path for
openblas, deriving it from library_dirs

What do you think?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/serge-sans-paille/pythran/issues/1584#issuecomment-663535232,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAA4VUADIYSOV6A3JACHTKTR5GDFHANCNFSM4O267Q3Q
.

--
Those who don't understand recursion are doomed to repeat it

Great, closing the issue then :-)


fix: fall detection debug info

Hello @ivelin! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file src/ambianic/pipeline/ai/pose_engine.py:

Line 162:80: E501 line too long (80 > 79 characters)
Line 163:21: E265 block comment should start with '# '
Line 165:34: E231 missing whitespace after ','
Line 173:80: E501 line too long (84 > 79 characters)
Line 176:80: E501 line too long (143 > 79 characters)
Line 177:80: E501 line too long (95 > 79 characters)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: ivelin:x: semantic-release-botYou have signed the CLA already but the status is still pending? Let us recheck it.