Elegoo 2.8 TFT Shield config issues

Hello all,
I apologize for being a newbie here, but have been fascinated by the capabilities of GUIslice and am trying to implement it into future projects,
I have a few questions, regarding setup and could use your help..
The objective: Uno R3 with Elegoo 2.8 TFT Shield
[]https://class.ece.uw.edu/474/peckol/doc/TFT-Display/2.8inch touch screen user manual（Arduino-EN）V1.00.2017.03.22.pdf
Following the walkthrough, it is recommended to use the ard-shld-elegoo_28_res.h config paired with the MCUFriend_kbv and Adafruit_TouchScreen libraries. I've also installed the Elegoo libraries.
Running the graphictest_kbv runs perfect.
Running the Elegoo graphics test goes to completion, but the screen remains white the entire time.
I've set the Elegoo_TFTLCD.h to #define USE_Elegoo_SHIELD_PINOUT 1
set the GUIslice_config.h to #include "../configs/ard-shld-elegoo_28_res.h"
and when I go to run the GUIslice example ex01_ard_basic, I get hit with and error that the Sketch is too big.
Any advice on what I have done wrong? Thanks all for the help.

I have resolved this issue. Here is the current configuration to make this work for my use:

In GUIslice_config.h, I have #include "../configs/ard-shld-elegoo_28_res.h"


new button hover changes

Hovering on the 'New' button now shows a dropdown.
Clicking the new button takes you to the '/editor' page.

just need to fix the formatting and the link. Run bun format

Done with the changes.

@PALLAVIKHEDLE 🫡


New page type/functionality for saving a page and form entries as Word document

Hi all
just adding some thoughts/comments etc re the new functionality @JohnSmith-LT has been working on.

@JohnSmith-LT You asked the following in an email: "I was thinking of making the structure more like that of the Hotspot page where you could have Page -> Item and also Page -> Section -> Item where the additional Section wasn't required..."

I'm not sure if this is what you mean but I think it would be useful to have everything on one page including the download button (even if that introduces scrollbars) but also perhaps the ability to split into multiple pages/sections where appropriate. e.g. Form tools like Google forms and the Feedback module in Moodle have an optional page break option so the author can choose whether it's a long scrolling page or broken into separate pages with navigation. What we have right now is close to that e.g. Section > item > item >item >item except there doesn't seem to be a way to avoid having the first page and the download option as separate pages? e.g. the following screenshot without the navigation

I can see why you added the borders and we can obvious re-style via custom css but I wonder if the borders should be an optional property along with the usual panel size options like Small, Medium, Large, Full so that there could be variable width of the form display similar to quiz and other page types.
I think you already said that the input field size and required field options don't do anything at the moment but obviously author control over field width and height is desirable as is input type e.g. single line entry, paragraph entry and ultimately other form elements would be useful too e.g. checkboxes, radio buttons, select lists.
I wonder whether by default the resulting document styles should be all black and perhaps Arial too but with an optional property to attach a custom stylesheet or customs styles text box to control the output styles.
We've already discussed an optional property to control the name of the downloaded Word doc

I'm sure there is lot's more we could add/change but just a few thoughts to start with.
Cheers
Ron

Thanks Ron, that's great and gives me something to work from. Just making notes in response to your points above, not really needing an answer to them.

(well the first one since Github appears to want to show 1. twice) - I think this is really two separate things

a) You are right in that I could easy have an "item" which was just some text with no input fields and then if you want an "Introduction" first page then you add it...
b) the thing with the page ->section-> item and page->item is that perhaps having a section within a page only really makes sense (or more so is only required) if you have multiple items needing grouped or that are related. e.g
Personal Info

Name
Age
etc

If you only have a single item with no related items then you just add that as an item without adding a section for it to go inside. Similar to how you can have a single hotspot or a group of hotspots - i'll add it to show what I mean and it can always be reverted.

(the second one) - I really only added them so I could visualise the structure. I don't like how they look so intended to remove but they could be optional as they may be desirable in some instances.

Yes this is the plan, text boxes are easy to make work :)

Yes i'm happy with that - perhaps the styling for this is something Julian's friends son may be interested in working on - it's not my strong point!!

Yes, already done will upload soon.

Cheers John
I'll keep an eye out for updates and I have some real world uses for this so will explore the possibilities including styling etc and add further notes here in due course.

@JohnSmith-LT I noticed in a further bit of testing that if an LO was set to responsive text the page, section and item titles weren't being displayed as responsive. I think this is because responsivetext.css doesn't have any reference to #pages This is resolved by adding #pages h2 {     font-size: 3.0vmin; }  to responsivetext.css but would have to be done for each theme and I wonder if there is an existing class that could be used instead e.g. #mainText? I also vaguely recall a previous comment by Fay that heading in page content should start from h3 rather than using h1 or h2 but I could be wrong about that.
In the current responsivetext.css files we have the following controlling headings but nothing else relevant: `h3 {
font-size: 3.0vmin;
}
.panelPage h3 {
font-size: 3.0vmin;
}
#mainTxt h3 {
font-size: 3.0vmin;
}
#x_headerBlock h2 {
font-size:5.0vmin;
font-weight:bold;
}
#x_headerBlock h1 {
font-size:2.5vmin;
}`
I guess it's not too big a deal to add #pages h2 {     font-size: 3.0vmin; } to each of the responsivetext.css files but I wonder if there's a way to avoid that?
I know @FayCross has done some tidying up of the responsivetext functionality recently and I thing @torinfo too so they may have further comments at some point.

Hi all,
I've uploaded some more changes to this. Download doesn't work as expected just now but some extra functionality added to the page model.
NEW

Add 6 different elements to either the page or a section (Textbox, Textarea, Checkbox, Media (pics only just now), Description (text with no input element) and Horizontal Rule
Sizes work on some elements now
Optional property to set filename

TO DO

Add Radio button and Select list options
Fix download.php to accept all new elements
Wire up the Required option (just now it just adds an indicator)
Look into styling (Ron's stuff above and new elements)

All comments welcome!
John

HI John this is great thanks.
I've been testing with a 'real world' example and added some custom css in the LO and you can view the LO here: http://training.mitchellmedia.co.uk/xot/play.php?template_id=208
A few comments:

Ideally I'd like to be able to have form elements on the very first page a user sees e.g. to hide the document title and text, rather than having to add a page and then the user has to click next before seeing any text elements.
Might also be useful to have an option to set that Document title and text as 'sticky' so that it appears throughout the navigation. You'll see in my example that I've added similar text to the top of each page to try to achieve this but then obviously this is repeated in the downloaded document too.
Seems like font formats etc applied in the editor are carried across to the word document so perhaps download.php doesn't needs the font styles/colours enforced? I think better just black by default.
You'll see I manually added a page count to the bottom of each page. Might be better if that was automatically part of the navigation e.g. rather than just page number between the buttons 1/2, 2/2 etc
Would be good to be able to configure the final page e.g. where the download button appears to add instructions/notes etc
I tested on iPad and via Safari the download doesn't work but does via Puffin Browser. I wonder if there's the potential for a view option in than scenario rather than download. Or of course whether there's a solution to get it to work via Safari on iPad. Then again other tools with similar download functionality don't work on iPad either.
It seemed like the width option isn't currently controlling text entry items so I've controlled the width in this example with custom css.
Did you see my previous note that to get download to work on my server and also xampp I had to change the link in documentation.html to remove the forward slash at the beginning.
Cheers
Ron

@JohnSmith-LT thanks for the update re Page x of y and download.php link.
I've added that to the install I'm using for the real world example so that previous link I shared shows the change. I've enabled download of that LO too in case useful
I'm not sure about the "No answer given." being displayed by default in the downloaded Word document given that the end user is doing this and will know whether they answered or not anyway. However I guess ultimately this could/should be part of the language string options anyway and so the author could change or empty that field including the ability to change the label on the download button etc.
It also occurred to me that it might be useful to have some way for the author to mark/tag something like an instruction that is part of what is shown on the LO page itself but isn't part of the download document e.g. isn't posted to download.php or in some way hidden.
HTH
Ron

Hi @ronm123
I've checked off most of the things above with a few exceptions:

Not sure I can ever enable this although I'll continue to look around and have a think about alternative ways to do the same. I've changed headers to the format that is most compatible and should work with Android 2+

Still have to patch download.php to take into consideration all the changes and add the stuff on the TODO list above but i'm done for tonight!!
Thanks for all your feedback, it's been very helpful and we now almost have a very useable page...
John

@JohnSmith-LT indeed fantastic stuff and very useful and flexible new page type!
I updated my install and example to test the changes and have also shut down for tonight but will add further notes/comments tomorrow.
Cheers
Ron

Hi @JohnSmith-LT I've been testing a bit further and wondered about the following changes:
Change the page counter to remove the word page and just have x / y? e.g.
$('#pagenumber').html(page + " / " + $('#pages').children().length) You can see this in my test LO linked previously.
Change the navigation buttons to use FA icons? e.g.

I guess any text used will need to be internationalised at some point?
I wondered about setting the navigation to float top right as in my example?
In my test project I've added margin-bottom:10px; to #navigation and also made #navigation font-size responsive so the buttons resize along with the text as long as display width is 768 or greater. This links to my earlier question about whether there's a way to minimise the need to update each responsivetext.css?
I'm wondering what further changes you were planning re checkboxes both in terms of display but also result in the downloaded doc? e.g. displaying the text box left or right of the line of text rather than below?
In the resulting document showing symbols to represent checked or unchecked e.g. ☑ and □
Just some thoughts...
HTH
Ron

Thanks Ron,
I've now incorporated your changes above and put some code in to take care of 'required' flag and incorporated some of the changes above. Still to do are (feel free to add to the list as I might have missed something):

[ ] Fix download.php to accept all new elements
[ ] Look at styling (both in LO and download) and maintaining responsive sizing
[ ] Add Radio/Checkbox/Select lists
[ ] Rip out all English strings to the language area
[ ] Look into alternative to download for iPad use

John

Cheers @JohnSmith-LT I'll download and explore the latest changes as soon as I can and add anything that's missing etc.
With regard to iPad use I wondered whether hooking into the installations mail processing (if configured) might be an option. e.g. as well as a download button an optional property email button where the user enters their own email address (or a teacher I guess) and the results send via email? Optional property so that the author can decide whether to enable vs the risk of spam etc ;-)

Thanks Ron
The email thing sounds like a possibility - would the content of the normally downloaded file just be sent in the body of the email?
Also, have been thinking about the Checked/unchecked text and the use of symbols and also the No answer given text. What do you think of having the checked / unchecked as optional properties that you could put whatever you like into, similarly with the No answer given (which could also be set blank). If those were optional properties of each textbox/textarea and checkbox would it also perhaps be desirable to have a global No answer given field...
John

Hi John
quick response for now...
yes was thinking the content would just be the body of the email rather than an attachment.
Optional properties sound like a good idea and yes a global no answer option too. Perhaps the default for that should be "Not answered" Rather than"No answer given" I have a couple of other real world examples where checkboxes are required that I'll work on and share at some point tomorrow.
Added 1 item to your previous list about some way of excluding content from the download.
Cheers
Ron

Hi @ronm123
Sorry it's taken a while to get some time to get back to this... i've added radio/checkbox support and also an exclude option but i'm pretty sure i've broken or not completely wired up some of the functionality.
Hopefully i'll have more time this week to work on the other items.
John

Hi @JohnSmith-LT my apologies too I had to park this to get on with less interesting VLE stuff but will pull down your changes and explore asap.
Cheers
Ron

@JohnSmith-LT just testing the Radio Button listed functionality with the beginnings of a real example and on preview/play I'm seeing  a line of text saying 'Enter text for the list here' but I'm not seeing a text entry box in the editor to change or clear that? screenshot of preview attached:

Also I assume that the option for horizontal or vertical display is not yet functional? e.g. nothing seems to change at the moment.
I think it would also be better if the 'Option Name' fields weren't bold by default and perhaps like the document title fields where the author has basic control over formatting.
The text for the options themselves should probably be default size too but again perhaps with the minimal style controls? Currently the options appear much smaller than paragraph text.
More comments tomorrow...
Cheers
Ron

Hi Ron, thanks for catching that. I have put back the text box and renamed them and also fixed the issue regarding the lack of wysiwyg editor and forced bold on titles.
I have still to implement the horizontal/vertical option you are right and I have no styles on the option text so it must be inheriting from the base stylesheet so if you were able to figure out from where then that should be easily changed or overridden - I'm surprised though that it doesn't manifest itself in other LOs...
I'll work on the horiz/vert next...
John

@JohnSmith-LT sorry since my last test I've had to park this to complete some Moodle developments but should have time to explore further tomorrow and will investigate where the styling is coming from then.
Cheers
Ron

Hi John & Ron, I'm a bit late to this but I've got a bit of time I could spend on helping out with this page if it's needed - it looks great so far. I think I've read all the emails & comments about this but apologies if any of this has already been covered, here are my initial thoughts:

Does this page type need to have multiple sub-pages or would it be more useful to be able to add multiple documentation pages to a project (at any point, e.g. pages 1, 4 & 10) and then be able to do the download on the last one? This would allow for notes to be taken throughout the project and just one file to be made rather than multiple ones. If this were the case then it would be great if you could add 'documentation' form fields to any page type through a button in the text area's wysiwyg editor - i.e. you could take note inside a text and graphics page that would be stored as part of the document too. Then at the end of the project the data entered everywhere could all be pulled together and downloaded to a document. I realise this last bit would be quite a change from what we have so far and require a lot more work though!

Some of the optional properties (e.g. not answered text) should really be language properties

In the media lesson page there is something similar to 'horizontal rule' but it's called 'divider' instead. Rather than being an item you add to the page it's an optional property on each type of content you can add and when added it inserts a hr between it and the content above it. I'd prefer this to be consistent across the pages as it does the same thing.

Some of the wording of things might not make sense to non-technical users (e.g. width of text areas is columns rather than width)

An option to have default text in text areas/fields could be useful (the grey text that prompts you what info to type in but disappears when you start typing)

Page layout - option to layout in grid with title next to form field rather than in long list:

Q1text field hereQ2text field hereQ3text field here

I'm not sure what I think of the sections. I understand why they are useful but I think it's a little confusing that they appear in the same '+ New...' list as the rest of the content and then when you add one you see the same list of '+ New...' content items twice. I might be overthinking this though. There's something similar in the stand alone decision tree template but I made it so that questions had to be added within a section but you choose whether to show the section info or not. Maybe that's more confusing though!

Is the checkbox item needed when you can create one using the list item?

John, are you happy for me to make some small changes here and there (e.g. 2,4,5 above) or is that going to get in the way of the work you're still doing? I can look into the responsive text stuff mentioned above too.

Hi Fay

  Re multiple sub pages – I think it’s very useful to be able to do what we can now with multiple sub pages so wouldn’t want to lose that but yes like the model answer and model answer results combination the ability to add not just text boxes but other form elements throughout with collated results at the end would also be useful. I think probably the best idea would be to treat the two things separately but use the common functionality where possible.

  Re language properties – do you mean instead of optional properties like some of them are now? Problem is users often miss the language options even more than the optional properties.

  Sounds like a good idea to make consistent but debatable whether divider or horizontal rule is a better description.

  I did wonder about that but figured John had a reason for calling it columns

  Yes as an option somehow agree

  Yes this would be useful especially with radio buttons and checkboxes but also short answer fields too

  Perhaps this ties in with your question about help icons alongside optional properties but also perhaps anywhere a bit like Moodle help icons that provide contextualised guidance

  I guess there could be reasons for separate options rather than combined but not thinking clearly about that at the moment. :(

HTH
Ron
From: FayCross<EMAIL_ADDRESS>Sent: 12 October 2016 17:13
To: thexerteproject/xerteonlinetoolkits<EMAIL_ADDRESS>Cc: Ron Mitchell<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [thexerteproject/xerteonlinetoolkits] New page type/functionality for saving a page and form entries as Word document (#547)
Hi John & Ron, I'm a bit late to this but I've got a bit of time I could spend on helping out with this page if it's needed - it looks great so far. I think I've read all the emails & comments about this but apologies if any of this has already been covered, here are my initial thoughts:

 Does this page type need to have multiple sub-pages or would it be more useful to be able to add multiple documentation pages to a project (at any point, e.g. pages 1, 4 & 10) and then be able to do the download on the last one? This would allow for notes to be taken throughout the project and just one file to be made rather than multiple ones. If this were the case then it would be great if you could add 'documentation' form fields to any page type through a button in the text area's wysiwyg editor - i.e. you could take note inside a text and graphics page that would be stored as part of the document too. Then at the end of the project the data entered everywhere could all be pulled together and downloaded to a document. I realise this last bit would be quite a change from what we have so far and require a lot more work though!

 Some of the optional properties (e.g. not answered text) should really be language properties

 In the media lesson page there is something similar to 'horizontal rule' but it's called 'divider' instead. Rather than being an item you add to the page it's an optional property on each type of content you can add and when added it inserts a hr between it and the content above it. I'd prefer this to be consistent across the pages as it does the same thing.

 Some of the wording of things might not make sense to non-technical users (e.g. width of text areas is columns rather than width)

 An option to have default text in text areas/fields could be useful (the grey text that prompts you what info to type in but disappears when you start typing)

 Page layout - option to layout in grid with title next to form field rather than in long list:

Q1
text field here
Q2
text field here
Q3
text field here

 I'm not sure what I think of the sections. I understand why they are useful but I think it's a little confusing that they appear in the same '+ New...' list as the rest of the content and then when you add one you see the same list of '+ New...' content items twice. I might be overthinking this though. There's something similar in the stand alone decision tree template but I made it so that questions had to be added within a section but you choose whether to show the section info or not. Maybe that's more confusing though!

 Is the checkbox item needed when you can create one using the list item?

John, are you happy for me to make some small changes here and there (e.g. 2,4,5 above) or is that going to get in the way of the work you're still doing? I can look into the responsive text stuff mentioned above too.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/thexerteproject/xerteonlinetoolkits/issues/547#issuecomment-253260343 , or mute the thread https://github.com/notifications/unsubscribe-auth/AE7YKglWmbIhg8ua-PBvHzzx1fsk9OQyks5qzQcMgaJpZM4KFAJo .  https://github.com/notifications/beacon/AE7YKsWFPvUIAyZwGS9mJiEim4Kkeo0nks5qzQcMgaJpZM4KFAJo.gif

Hi Ron

Yes language property rather than optional property. I know that most people don't know they're there but I'd still prefer them to be in there for consistency. Otherwise we might as well just get rid of language section all together

I don't mind whether it's this page or media lesson page that's changed to make it consistent. I just wanted to make a note of this so I could sort it later.

I don't want to tread on John's toes with any of this so I'll probably just do a bit of work on layout / css / responsiveness for now.

Hi Fay,
Your suggestions look great and there is no problem with stepping on my toes, feel free to change anything you wish to make it more consistent with the look and feel of the other pages. I probably won't have any time to work on this over the next few weeks as I have to go with my wife to Leeds as she's having an op so there will be no code conflicts to worry about and if you have the time then it would be good to see what you can come up with. Just a few notes to add to what you and Ron have already added:

I think being able to add to the documentation throughout the LO as well as having a page like we have now is great... perhaps another item on the documentation page which simply has an option to reference the text entered on another page, or some kind of templating system as that would allow you to add a Name: box on page 1 and then have a "Thank you {{name}}" on the documentation page... I agree with Ron though that I can see a use for both...

Yes, agree but i'm just not always 100% sure when it goes in there and when not...

I don't have an opinion either way about this; if divider is the more consistent terminology then i'm happy for it to be that. On't caveat is that the reason it's not an option but an item is because you have the exclude option which can determine whether it shows on the LO, the documentation or both. It also makes it easier I feel to know where it is in the grand scheme of the layout and also easier to move around...

Again, i'm all for consistency but I think the confusing thing for me is that textboxes it's pixel width but textareas it's columns so width: 50 isn't the same in both cases... or am I wrong?

I like this idea too.

Sure I can see it being used and the more flexible the layout the better.

Happy for them to be removed I just liked the way you could group things so you could have defined sections like you might in an application form...

The checkbox was the original but I felt that i didn't want seperate checkbox, radio and select lists (not implemented yet) as occasionally I have seen cases where you think you only want the user to select one thing but then it becomes more than one, like how did you get here - they may have driven to the station, got the train and cycled from the station to work...  As for a separate checkbox, like you I don't think there is any need but i've been taking Ron's lead on most of this and he may have a specific use case...

I still really need to work on the download section and email functionality (for ipads) so if I have time then I will work on that which won't interfere with anything you decide to do on the page model.
John

Great, I'll do some bits and pieces but won't make any major changes to the way it's structured or works. I hope the next few weeks go ok for you

Cheers Fay, i'm sure all will be fine.
If you are doing anything with the model code then you might notice that the event handling looks a bit weird with self executing functions all over the place, like this
(function (p, s, i, d) {
	$input.on('change', function () {
		documentation.updateData(p, s, i, $(this).val());
	})
})(page, section, item, display);

This is because the page, section, item etc values are needed in each of the event handlers but obviously change in the loop. Rather than have 4 secondary var declarations for each i've used a closure to store the passed in values until they are used.

Hi, I see that the html is using download2.php to download the filled in form, but I don't have a download2.php in my (up to date) develop in stallation. What am I missing?

Sorry, should just be download.php... download2.php was being used for testing out the email functionality which i've not been able to get working yet.

I've made quite a few changes to this page in the last few days. I think it's nearly in an ok state to release (although not sure what else John has planned to add)
From my initial comments I haven't haven't done anything to allow multiple documentation pages to be combined in 1 downloaded file or added a grid layout option but I'd like to do these at some point.
A few things I wondered about:

Required field isn't on list - should it be? I guess this would mean it would count as unanswered if set to checkbox and no boxes where checked
Do you think the format of the sub page buttons & 1/5 text look confusing as it's a similar format to main page buttons?
Is 'List' & 'Description' the best wording for these sections? Would 'Multiple Choice Question' & 'Text' be better?
Is there any need for Media to be a separate section? Could we just put a media optional property in Description instead? (Same with checkbox being separate to list too)
In downloaded document should we include:

list of options that weren't selected in radio / check box questions
horizontal rules
images (not sure if possible)
line breaks are lost from text entered in text area fields

I've just realised too that the exclude from properties seem to be breaking the page when added - this is probably something I've done so I'll fix this asap. Oh, and I haven't checked the required stuff so I'll test that now too

I'm trying to put this page on the UoN installation but am having a problem with the downloaded file - it's always completely blank. The documentation.html & download.php files are identical to those on my xampp install where it's working perfectly so I'm confused about what's going wrong.
It seems to be a problem with the data received by download.php. I can see that what's posted to it from documentation.html is exactly the same on UoN & xampp but then if I echo $_POST['data'] on the UoN install in download.php it's all like this with escaped quotes:
{\"filename\":\"documentation\",\"pages\":[{\"pageName\":\"Nested Page\",\"pageText\":\"...
in xampp it looks like this:
{"filename":"documentation","pages":[{"pageName":"Nested Page","pageText":"...
Any ideas why this would be different on the 2 installs when the files are identical?

Hi Fay,
Do you have magic_quotes enabled on the server? You may have to look at doing something mentioned here ( http://php.net/manual/en/security.magicquotes.disabling.php ) to take care of installations that have magic_quotes on.
John

@FayCross @JohnSmith-LT
just checked my server where I have this working and magic_quotes is off.
Checked php info on another server with a later php and magic_quotes isn't even listed. Was it deprecated from a particular version onwards?
Hope all is well with you John.

Thanks @ronm123 & @JohnSmith-LT - I've turned magic quotes off by this to the .htaccess file (suggested by John's link):
php_flag magic_quotes_gpc Off
and it works now. I take it there's nothing that relies on magic quotes being on that I should be worried about not working properly now? If not then you can start your work on moving your documentation projects onto the UoN install Ron.

Have all aspects of this now been completed @ronm123?

@JohnSmith-LT I think so apart from the emailing option.

Closing as documentation page was completed some time ago


Move sample messages to Rust test

Closing this merge request:

There original request of have clean commits is represented in many other merge request
What this MR would add, is better provided in #82, #83 and #84
Getting this MR merged would require other merge requests slash commits to get it clean up


Update MD file on new branch 2017-19-14_14-11-40

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


PR26501 - Category IOU - The recently selected categories do not appear under Recent section

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Go to + > Request money.
Enter an amount > Next.
Select any category.
Click Category.
Select different category multiple times.

Expected Result:
The recenly selected categories will appear under Recent section.
Actual Result:
The recently selected categories do not appear under Recent section.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: 1.3.69-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/115492554/014ab5b9-6c54-4fec-b6f8-1e5df11f9fc9
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @
View all open jobs on GitHub

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

I believe categories are under a beta so I don't think we should block the deploy on those, however @rezkiy37 @yuwenmemon @puneetlath - Could you look into this as it seems related to #26501 and Wave 8? Thank you!

Actually, it is not a bug, it is a feature. A category is being set to recently array only after a money request has been submitted. So, please verify this 🙂

Correct. We can close this!


RPM and Linux 64 bit pre-compiled builds for 1.0

https://dl.jaydendev.repl.co/ninetails
binaries, zips, and packages are available

Thanks, I'll add the .rpm file to the releases.

Done. Enjoy!


Deploy To Heroku

I get this error when I try to deploy to heroku, "Application error
An error occurred in the application and your page could not be served. If you are the application owner, check your logs for details. You can do this from the Heroku CLI with the command"
Tried everything but its not working. Please help resolve

Did you try adding a Procfile or a package.json?
I am guessing heroku doesn't know how to start the app. Try putting this(or similar) in your Procfile:
web: vapid start

I could not find a Procfile but I was able to find a package.json file. So I added the information into that but its still the same. Here is the link to the url http://crunchcorruption.herokuapp.com/
git push heroku
Enumerating objects: 11, done.
Counting objects: 100% (11/11), done.
Delta compression using up to 8 threads.
Compressing objects: 100% (7/7), done.

Total 8 (delta 0), reused 0 (delta 0)
remote: Compressing source files... done.
remote: Building source:
remote:
remote: -----> Node.js app detected
remote:
remote: -----> Creating runtime environment
remote:
remote:        NPM_CONFIG_LOGLEVEL=error
remote:        NODE_ENV=production
remote:        NODE_MODULES_CACHE=true
remote:        NODE_VERBOSE=false
remote:
remote: -----> Installing binaries
remote:        engines.node (package.json):  unspecified
remote:        engines.npm (package.json):   unspecified (use default)
remote:
remote:        Resolving node version 8.x...
remote:        Downloading and installing node 8.12.0...
remote:        Using default npm version: 6.4.1
remote:
remote: -----> Restoring cache
remote:        Cached directories were not restored because of a change in versions of node, npm, or yarn
remote:        Module installation may take longer for this build
remote:
remote: -----> Building dependencies
remote:        Installing node modules (package.json)
remote:
remote:        ><EMAIL_ADDRESS>install /tmp/build_45115fe6c4e3df9d7e37699f975b812d/node_modules/bcrypt
remote:        > node-pre-gyp install --fallback-to-build
remote:
remote:        [bcrypt] Success: "/tmp/build_45115fe6c4e3df9d7e37699f975b812d/node_modules/bcrypt/lib/binding/bcrypt_lib.node" is installed via remote
remote:
remote:        ><EMAIL_ADDRESS>install /tmp/build_45115fe6c4e3df9d7e37699f975b812d/node_modules/sqlite3
remote:        > node-pre-gyp install --fallback-to-build
remote:
remote:        [sqlite3] Success: "/tmp/build_45115fe6c4e3df9d7e37699f975b812d/node_modules/sqlite3/lib/binding/node-v57-linux-x64/node_sqlite3.node" is installed via remote
remote:
remote:        ><EMAIL_ADDRESS>install /tmp/build_45115fe6c4e3df9d7e37699f975b812d/node_modules/node-sass
remote:        > node scripts/install.js
remote:
remote:        Downloading binary from https://github.com/sass/node-sass/releases/download/v4.9.3/linux-x64-57_binding.node
remote:        Download complete
remote:        Binary saved to /tmp/build_45115fe6c4e3df9d7e37699f975b812d/node_modules/node-sass/vendor/linux-x64-57/binding.node
remote:        Caching binary to /tmp/npmcache.eByOy/node-sass/4.9.3/linux-x64-57_binding.node
remote:
remote:        ><EMAIL_ADDRESS>postinstall /tmp/build_45115fe6c4e3df9d7e37699f975b812d/node_modules/node-sas
remote:        > node scripts/build.js
remote:
remote:        Binary found at /tmp/build_45115fe6c4e3df9d7e37699f975b812d/node_modules/node-sass/vendor/linux-x64-57/binding.node
remote:        Testing binary
remote:        Binary is fine
remote:        added 1191 packages from 799 contributors and audited 7492 packages in 41.914s
remote:        found 1 low severity vulnerability
remote:        run npm audit fix to fix them, or npm audit for detail
remote:
remote: -----> Caching build
remote:        - node_modules
remote:
remote: -----> Pruning devDependencies
remote:        audited 7492 packages in 10.132s
remote:        found 1 low severity vulnerability
remote:        run npm audit fix to fix them, or npm audit for detail
remote:
remote: -----> Build succeeded!
remote: -----> Discovering process types
remote:        Procfile declares types     -> (none)
remote:        Default types for buildpack -> web
remote:
remote: -----> Compressing...
remote:        Done: 58.2M
remote: -----> Launching...
remote:        Released v7
remote:        https://crunchcorruption.herokuapp.com/ deployed to Heroku
remote:
remote: Verifying deploy... done.
To https://git.heroku.com/crunchcorruption.git
27e8f0d..d5a8488  master -> master

And on heroku dashboard I noticed that instead of having web: vapid start it has web: npm start. But I was unable to edit this information.

Tried using both but still not working.
Can you please create a working demo on github, add heroku deploy button, then let's see.
Maybe a system configuration on my part is the problem.
Thanks

hm apologies. Indeed, it doesn't seem as straight-forward as hoped for. Don't really have the time to check all this right this second unfortunately.

And I have put in a lot of work to start all over. Please consider.

I will let an admin answer, but you are using beta software, and should be wary of not relying too critically on it.
One thing you might want to try, if you can't figure heroku out, is to Dockerize it, perhaps that will work. I'm not sure of the internals of heroku.
Other options include self-hosting, of course.

Interesting. I gave it a go and Heroku logs say that the crash was caused by an SQLite error: unable to open database file. @seekersapp2013 perhaps you could look through your heroku logs to check for what crashed your instance. If its the same we can put more weight behind this issue 😄
A snippet of my log file posted below:
2018-09-25T16:47:58.000000+00:00 app[api]: Build succeeded
2018-09-25T16:48:06.303328+00:00 heroku[web.1]: Starting process with command `vapid start .`
2018-09-25T16:48:25.584807+00:00 heroku[web.1]: State changed from starting to crashed
2018-09-25T16:48:25.549530+00:00 heroku[web.1]: Process exited with status 1
2018-09-25T16:48:25.320617+00:00 app[web.1]: ==> Starting the production server...
2018-09-25T16:48:25.465708+00:00 app[web.1]: ERROR: SQLITE_CANTOPEN: unable to open database file
2018-09-25T16:48:25.896247+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/" host=stark-inlet-33938.herokuapp.com request_id=d2a3d0fb-0b7f-40d9-b5ba-ba19ca878e96 fwd="<IP_ADDRESS>" dyno= connect= service= status=503 bytes= protocol=https
2018-09-25T16:48:26.774056+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/" host=stark-inlet-33938.herokuapp.com request_id=9a6137f6-ee15-42ee-9f21-6cca757c4850 fwd="<IP_ADDRESS>" dyno= connect= service= status=503 bytes= protocol=https
2018-09-25T16:48:27.574620+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/" host=stark-inlet-33938.herokuapp.com request_id=0c9cffc3-89c2-4455-8355-5a915819c6f7 fwd="<IP_ADDRESS>" dyno= connect= service= status=503 bytes= protocol=https

@seekersapp2013 I just added a Wiki doc yesterday that might be helpful:
https://github.com/vapid/vapid/wiki/Self‐hosting
Did you add the SECRET_KEY env variable to Heroku?
heroku config:set SECRET_KEY= supersecret

@seekersapp2013 Were you able to successfully deploy on Heroku?
In any case, I'd like to move conversations about deployment issues over to the Vapid forums. Please feel free to chime in over there, and update me on the progress of deploying to Heroku, or provide tips to others facing the same issue. Thanks.


fix(lightsail): Remove second call to is_resource_filtered

Context
Closes #5043
Description
Corrected the conditional statement to call is_resource_filtered only once.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Approving this PR and we will add the missing tests when we add testing for is_resource_filtered  function in all checks.


how to solve : Compress.getThumbnail error: type 'Future<String?>' is not a subtype of type 'FutureOr' in type cast

Compress.getThumbnail error: type 'Future<String?>' is not a subtype of type 'FutureOr' in type cast
i try to use
video_compress:
git:
url: https://github.com/jonataslaw/VideoCompress.git
but it doesn't work,and other errors appeared

Use the latest version for a fix, until @jonataslaw provides a new release:
video_compress:
  git:
    url: https://github.com/jonataslaw/VideoCompress
    ref: "583e700"


Lessen restriciton on file/directory naming

Resolves #192

Testing with https://pds.nasa.gov/data/pds4/1900/dph_examples_v1900.zip. Renamed bundle label and data directory to provide _ is no longer taken into account:
Before (validate doesn't find the bundle XML):
Summary:

  0 error(s)
  4 warning(s)

  Product Validation Summary:
    14         product(s) passed
    0          product(s) failed
    0          product(s) skipped

  Referential Integrity Check Summary:
    14         check(s) passed
    0          check(s) failed
    0          check(s) skipped

  Message Types:
    4            warning.integrity.unreferenced_member

End of Report

After:
Summary:

  0 error(s)
  1 warning(s)

  Product Validation Summary:
    14         product(s) passed
    0          product(s) failed
    0          product(s) skipped

  Referential Integrity Check Summary:
    14         check(s) passed
    0          check(s) failed
    0          check(s) skipped

  Message Types:
    1            warning.integrity.member_not_found

End of Report


[SIMPLIFY] _predict as the only @abstract method of _Predictor

How to map this
@abstractmethod
def _predict(self, *args, dataset, **predict_kwargs):
    ...

[ ] Discuss exact model of connecting parameters of model.object with _predict
[ ] Implementation

@dc.dataclass
class InputNode:
    name: str

class Inputs:
    def __init__(self, fn):
        self.params = inspect.signature(fn).parameters

    def __getattr__(self, item):
        assert item in self.params
        return InputNode(item)

What does the signature of .predict look like. Currently .predict(X).

What about outputs object?

class Outputs:
    def __getitem__(self, item: int):
        assert isinstance(item, int)
        return OutputNode(item)

Then in GraphModel we can have:
G.add_edge(model.outputs[0], other.inputs.x)

Also we should do some nice pretty-printing of Model information so that developers "know"
what parameters we have for a model.

Subtasks:

[ ] Refactor ._predict as _predict(self, X, dataset, ...)
[ ] Add input and output nodes to _Predictor
[ ] Connect input and output nodes with Listener and predict(X, db=db)


vscode rust-analyser failed to load workspace after upgrading to osx 10.15

Here's the error I got:
rust-analyzer failed to load workspace: "cargo" "--version" failed, exit code: 1
stderr:
error: no override and no default toolchain set

It works before upgrading(osx 10.13).

What do you get for rustup toolchain list and cargo metadata in your project? What happens if you run rustup default stable (or nightly if you were using that)?

What do you get for rustup toolchain list and cargo metadata in your project? What happens if you run rustup default stable (or nightly if you were using that)?

$ rustup toolchain list
stable-x86_64-apple-darwin
nightly-2019-12-20-x86_64-apple-darwin
nightly-2020-06-04-x86_64-apple-darwin
nightly-2020-10-05-x86_64-apple-darwin
nightly-x86_64-apple-darwin (default)

$ rustup default nightly
info: using existing install for 'nightly-x86_64-apple-darwin'
info: default toolchain set to 'nightly-x86_64-apple-darwin'

  nightly-x86_64-apple-darwin unchanged - rustc 1.50.0-nightly (1c389ffef 2020-11-24)

As for the output of cargo metadata, it's extremely long.
here's part of that:
..."dep_kinds":[{"kind":null,"target":null}]},{"name":"libc","pkg":"libc 0.2.80 (registry+https://github.com/rust-lang/crates.io-index)","dep_kinds":[{"kind":null,"target":"cfg(all(unix, not(target_arch = \"wasm32\")))"}]},{"name":"memory_units","pkg":"memory_units 0.4.0 (registry+https://github.com/rust-lang/crates.io-index)","dep_kinds":[{"kind":null,"target":null}]},{"name":"winapi","pkg":"winapi 0.3.9 (registry+https://github.com/rust-lang/crates.io-index)","dep_kinds":[{"kind":null,"target":"cfg(target_os = \"windows\")"}]}],"features":["default","size_classes"]},{"id":"winapi 0.3.9 (registry+https://github.com/rust-lang/crates.io-index)","dependencies":["winapi-i686-pc-windows-gnu 0.4.0 (registry+https://github.com/rust-lang/crates.io-index)","winapi-x86_64-pc-windows-gnu 0.4.0 (registry+https://github.com/rust-lang/crates.io-index)"],"deps":[{"name":"winapi_i686_pc_windows_gnu","pkg":"winapi-i686-pc-windows-gnu 0.4.0 (registry+https://github.com/rust-lang/crates.io-index)","dep_kinds":[{"kind":null,"target":"i686-pc-windows-gnu"}]},{"name":"winapi_x86_64_pc_windows_gnu","pkg":"winapi-x86_64-pc-windows-gnu 0.4.0 (registry+https://github.com/rust-lang/crates.io-index)","dep_kinds":[{"kind":null,"target":"x86_64-pc-windows-gnu"}]}],"features":["memoryapi","synchapi","winbase"]},{"id":"winapi-i686-pc-windows-gnu 0.4.0 (registry+https://github.com/rust-lang/crates.io-index)","dependencies":[],"deps":[],"features":[]},{"id":"winapi-x86_64-pc-windows-gnu 0.4.0 (registry+https://github.com/rust-lang/crates.io-index)","dependencies":[],"deps":[],"features":[]}],"root":null},"target_directory":"/Users/xuzhiqiang/Desktop/workspace/opensource/rust_exp/dex/target","version":1,"workspace_root":"/Users/xuzhiqiang/Desktop/workspace/opensource/rust_exp/dex","metadata":null}

Another suspicious point is that after upgrading the shell switched to zsh:
The default interactive shell is now zsh.
To update your account to use zsh, please run `chsh -s /bin/zsh`.
For more details, please visit https://support.apple.com/kb/HT208050.

I also tried various cargo command in the console, all works, it appears only rust-analyser somehow can't run cargo commands:

$ rustup toolchain list
stable-x86_64-apple-darwin
nightly-2019-12-20-x86_64-apple-darwin
nightly-2020-06-04-x86_64-apple-darwin
nightly-2020-10-05-x86_64-apple-darwin
nightly-x86_64-apple-darwin (default)

$ rustup default nightly
info: using existing install for 'nightly-x86_64-apple-darwin'
info: default toolchain set to 'nightly-x86_64-apple-darwin'

  nightly-x86_64-apple-darwin unchanged - rustc 1.50.0-nightly (1c389ffef 2020-11-24)

As for the output of cargo metadata, it's extremely long.
here's part of that:
..."dep_kinds":[{"kind":null,"target":null}]},{"name":"libc","pkg":"libc 0.2.80 (registry+https://github.com/rust-lang/crates.io-index)","dep_kinds":[{"kind":null,"target":"cfg(all(unix, not(target_arch = \"wasm32\")))"}]},{"name":"memory_units","pkg":"memory_units 0.4.0 (registry+https://github.com/rust-lang/crates.io-index)","dep_kinds":[{"kind":null,"target":null}]},{"name":"winapi","pkg":"winapi 0.3.9 (registry+https://github.com/rust-lang/crates.io-index)","dep_kinds":[{"kind":null,"target":"cfg(target_os = \"windows\")"}]}],"features":["default","size_classes"]},{"id":"winapi 0.3.9 (registry+https://github.com/rust-lang/crates.io-index)","dependencies":["winapi-i686-pc-windows-gnu 0.4.0 (registry+https://github.com/rust-lang/crates.io-index)","winapi-x86_64-pc-windows-gnu 0.4.0 (registry+https://github.com/rust-lang/crates.io-index)"],"deps":[{"name":"winapi_i686_pc_windows_gnu","pkg":"winapi-i686-pc-windows-gnu 0.4.0 (registry+https://github.com/rust-lang/crates.io-index)","dep_kinds":[{"kind":null,"target":"i686-pc-windows-gnu"}]},{"name":"winapi_x86_64_pc_windows_gnu","pkg":"winapi-x86_64-pc-windows-gnu 0.4.0 (registry+https://github.com/rust-lang/crates.io-index)","dep_kinds":[{"kind":null,"target":"x86_64-pc-windows-gnu"}]}],"features":["memoryapi","synchapi","winbase"]},{"id":"winapi-i686-pc-windows-gnu 0.4.0 (registry+https://github.com/rust-lang/crates.io-index)","dependencies":[],"deps":[],"features":[]},{"id":"winapi-x86_64-pc-windows-gnu 0.4.0 (registry+https://github.com/rust-lang/crates.io-index)","dependencies":[],"deps":[],"features":[]}],"root":null},"target_directory":"/Users/xuzhiqiang/Desktop/workspace/opensource/rust_exp/dex/target","version":1,"workspace_root":"/Users/xuzhiqiang/Desktop/workspace/opensource/rust_exp/dex","metadata":null}

Another suspicious point is that after upgrading the shell switched to zsh:
The default interactive shell is now zsh.
To update your account to use zsh, please run `chsh -s /bin/zsh`.
For more details, please visit https://support.apple.com/kb/HT208050.

I also tried various cargo command in the console, all works, it appears only rust-analyser somehow can't run cargo commands:

And it's still not working? Strange. What if you start Code from the terminal?
(your screenshot doesn't seem to load for me)

And it's still not working? Strange. What if you start Code from the terminal?
(your screenshot doesn't seem to load for me)

Still not working.
And got the same error if start Code from the terminal.

Still not working.
And got the same error if start Code from the terminal.

all of a sudden, it works now...

all of a sudden, it works now...


Issue with variadic parameter contains generics

After upgrade from 1.7 to 1.12, my code broke even though I didn't make any changes. I was using ramsey/collection for my DTO. UnresolvableType was thrown, but there was no specific error message provided. After further debugging, I believe this is the cause of the error.

This is the docblock of merge method which I'm not use anyway.
/**
 * @param CollectionInterface<T> ...$collections The collections to merge.
 *
 * @return CollectionInterface<T>
 *
 * @throws CollectionMismatchException if unable to merge any of the given
 *     collections or items within the given collections due to type
 *     mismatch errors.
 */
public function merge(CollectionInterface ...$collections): CollectionInterface

Hi @jenky thanks for the report.
Could you post a more detailed example of how you use ramsey/collection in your code?

This is a striped down version of it
final class MyDTO
{
    public function __construct(
        public readonly UuidInterface $uuid,
        public readonly SettingsCollection $settings,
    ) {
    }
}

final class SettingsCollection extends AbstractSet
{
    public function getType(): string
    {
        return Settings::class;
    }
}

final class Settings
{
    /**
     * @param  array<string, mixed> $settings
     */
    public function __construct(
        public readonly SettingEnum $name,
        public readonly array $settings = []
    ) {
    }
}

return (new MapperBuilder())
    ->allowPermissiveTypes()
    ->allowSuperfluousKeys()
    ->registerConstructor(
        Uuid::fromString(...),
    )
    ->mapper()
    ->map(MyDTO::class, $data);

I also try to transform the data['settings'] to Settings[] before passing to map method but it seems doesn't work also

Thanks, that helped identifying the issue!
#534 should fix it. 😉


Update tephra calculations

This updates the calculations to be a rewrite of the Python program provided by Robert Constantinescu. This model integrates over many phi classes (particle sizes) and over many cells of a simulated large eruption disk.
The main update is a direct re-write of the code, and is confirmed using test that use expected values from the Python program's output.
The program was then changed slightly as follows:

Number of simulated phi classes is settable, and the default lowered to 7 classes
Size of eruption cells to sample from is settable, and the default size increased to 3000

These changes were to balance speed and accuracy, an a comparison can be seen at
https://docs.google.com/spreadsheets/d/12EEJpJAnqk5pMMoa4cdtDSqUv7uiRPIPAGEIev1SJfQ/edit?usp=sharing
An additional change was added

At eruptions of VEI < 4, a small eruption disk is modeled

This is from a comment from Robert over email that the mushroom cloud simulation is only applicable at VEI >= 4. The comparison between the two models can also be seen at the above link.

@knowuh I'm going to go ahead and bring this in. If anyone needs to compare to the previous version, the last non-master branch that had the old code was restore-force-render, so the old tephra calc can be permanently seen at http://geocode-app.concord.org/branch/restore-force-render/index.html


The plugin upi_pay uses a deprecated version of the Android embedding.

Describe the bug
The plugin upi_pay uses a deprecated version of the Android embedding.
To avoid unexpected runtime failures, or future build failures, try to see if this plugin supports the Android V2
embedding. Otherwise, consider removing it since a future release of Flutter will remove these deprecated APIs.
If you are plugin author, take a look at the docs for migrating the plugin to the V2 embedding:
https://flutter.dev/go/android-plugin-migration.

@drenther  Could you please advice work around or fix for this issue

Duplicate of #44


envelope() makes incorrect geometry type assumption, resulting in crash

This is happening on develop (has not been released to cocoapods yet). We should definitely fix it before the next release.
import XCTest
@testable import GEOSwift
import geos

final class SpatialAnalysisTests: XCTestCase {
    func test() {
        guard let envelope = Waypoint(latitude: 1, longitude: 1)!.envelope() else {
            XCTFail("Failed to create envelope")
            return
        }

        // envelope is type Envelope, which is a subclass of Polygon

        // Actual geometry type is GEOS_POINT (0)
        print(GEOSGeomTypeId_r(GEOS_HANDLE, envelope.storage.GEOSGeom))

        // Crashes because the input to GEOSGetExteriorRing_r must be of type GEOS_POLYGON:
        _ = envelope.exteriorRing
    }
}

To fix this, we should revert the change to the return type of envelope() (was Geometry, is now Envelope). We may also want to eliminate the Envelope subclass of Polygon. Is there any reason its methods can't just be added to Polygon directly?

@samritchie can you weigh in on this?

Yes, I’ve also noticed points & some other geometries don’t return a polygon from envelope. I’d suggest either manufacturing one with appropriate coords or return an optional. I can have a look at this, but not today, I’m flat out at the moment.


Sugar RPi OS v1

1.5GB
RPi Lite OS + Sugar shell
Activities: default ones + tower-of-hanoi, number-guessing, flappy, turtleart-activity, and rpi_control_center
Temporary fix for the browse-activity issue (remove v207 that comes from apt, install v208, install dependencies)

@chimosky here!

Looks good, I'm curious though, why the deletion of so many files?

@chimosky

I'm curious though, why the deletion of so many files?

They are the files of stage3 to stage5, which are required to build a full version of RPi (full desktop environment, additional packages, and apps that we don't need)
We are building till stage2 which makes the lite version of RPi which is more than sufficient for our use case. Then we edit the stage3 to install Sugar. It cuts the OS size to half.
Thanks

I know what they are, why delete them when you could just create SKIP_IMAGE files?

Yeah, I know what they are. I was wondering why you deleted them when SKIP_IMAGE files would've been just fine.

Right but they would've just been redundant files. We'll never need them and additionally might create confusion for future contributors so it was best to get rid of them.

Thanks for this!


Overload get/setproperty in place of get/setindex

Ref #16.

I think you might not have seen my comment that flag should not be public. (Might have gone out of date before you saw.) flag is an internal flag about the state of the wcsprm struct having to do with whether memory has been initialized or something. Users should not need to know about it.
Regarding my comment in #16 about the surprising nature of assignment of mutable objects creating copies instead of references: I realized that the situation actually isn't altered by this PR; it was already the case! For example, wcs[:cd] = [1., 0.; 0., 1.] was copying the array on the RHS, even though in typical usage of setindex!, no copy is made. wcs.cd = [1., 0.; 0., 1.] does the same thing now, so it shouldn't be too much more surprising.

Oops, yeah, I must have lost that comment at some point.  Fixed, thanks!


Incorrect timer in pinout

The pinout for the CH32V003F4P6 in the readme has T1 and T2 switched for PD3/Pin20. According to the datasheet the channels on this pin are T2CH2 and T1CH4_.

The image generation had a bug, should be fixed now.
If you find any more problems feel free to bring them up over at: https://github.com/Tengo10/pinout-overview where the overviews are generated.


Could not find method... errors in Android

Steps to reproduce

render a Camera component

        <Camera
          style={styles.container}
          ref="camera"
          type={this.state.cameraType}
          captureAudio={false}
        >

see complete code for the CameraContainer.js file here: https://gist.github.com/dudeinthemirror/e1751f0b52241690533e236f75b22a9e
2. run in Genymotion or tethered device
3.
Expected behaviour
Capture button (cameraButton) and flip view button (flipButton) should render on top of the camera view

Actual behaviour
Capture and flip buttons do not show (The exact same code works fine in iOS - see above s/shot)

and these errors show up in the logcat:
https://gist.github.com/dudeinthemirror/3cba9433bcc6e274b878d04c5cf4a50a
Environment

Node.js version:

5.4.0

React Native version:

react-native-cli: 1.0.0
react-native: 0.26.3

React Native platform + platform version: iOS 9.0, Android 5.0, etc

Android 4.4.4
react-native-camera
Version: npm version or "master"
"react-native-camera": "git+https://github.com/lwansbrough/react-native-camera.git",

Fixed it with something that doesn't quite make sense, but it now works on both iOS and Android:
Took the TouchableHighlight's (cameraButton and flipButton) out from under <Camera> and put them at the same level with <Camera> within a container <View>
      return (
        <View style={styles.container}>

         <Camera style={styles.camera}
            ref="camera"
            type={this.state.cameraType}
            captureAudio={false}
          >
          </Camera>

         <TouchableHighlight
             style={styles.cameraButton}
             onPress={this._takePicture}>
             <View style={styles.cameraButtonInner} />
          </TouchableHighlight>

          <TouchableHighlight
             style={styles.flipButton}
             onPress={this._flipCamera}>
             <Icon allowFontScaling={false}
             name='cycle'
             size={24}
             color={'#FFFFFF'}
          />
          </TouchableHighlight>

      </View>

Not sure if this will fix your errors in logcat, but there is currently a PR dealing with the Z-index for android.
Fix Z-Index That fixes Issue #286

thanks @error-bruno, will verify once the PR is in.


localhost:8000/txs/admin/login redirects to same login window after successful login

Hi there!
I just tried to launch the local docker-compose version with pretty-much default settings.
After successful user creation via
docker exec -ti safe-infrastructure_txs-web_1 python manage.py createsuperuser --username root

I can't log in with localhost:8000/txs/admin URL, with configured username/password, it just redirects me back to the same login window, without any error in docker logs, or on frontend, or in frontend-console.
BTW, localhost:8000/cfg/admin is working as expected.
Versions are:
CFG_VERSION=v2.23.0
CGW_VERSION=v3.26.0
TXS_VERSION=v4.4.2
Any ideas?
Thanks

Hi @yod527 reviewing the documentation I think that your command is wrong because the container safe-infrastructure_txs-web_1 doesn't exist in the compose file.
Try this command to use interactive mode:
docker exec -it safe-infrastructure-txs-web-1 python manage.py createsuperuser  --username root

@moisses89 it's just the way docker-compose names the containers in my case.. If I will refer to command in documentation, I will get "no such container" error. The user is created by the script without any issues. If I try to login without user creation or with wrong login credentials I will get Please enter the correct username and password for a staff account. Note that both fields may be case-sensitive. error. My settings are default, I've only specified some RPC_NODE_URL as it is written in documentation. I feel like issue is not in docker, or docker-compose, or me unable to launch a user-creation script. It's probably in some wrong configuration of the services or safe-transaction service itself. I will be happy to blame MacOS and Docker-desktop which I'm using, but on production ubuntu stand (where configuration are far away from default) I'm facing exactly the same issue, unfortunately.

Hi @yod527 I cannot reproduce, just deleted everything with docker compose down and made sure everything is at the last version:
cp .env.sample .env
docker compose pull
docker compose up

I'm using Docker 20.10.17 and Docker Compose 2.6.1

@Uxio0 thanks for checking that for me, can I kindly ask to provide some test RPC_NODE_URL which you're using? Without setting of this var, the safe-infrastructure-txs-web-1 does not boot up. Maybe, the reason is in my roc node which I'm using..

==> 12:29:09 ==> Collecting statics...
==> 12:29:09 ==> Send via Slack info about service version and network
==> 12:29:09 ==> Running Gunicorn...
[2022-07-20 12:29:10 +0000] [1] [INFO] Starting gunicorn 20.1.0
[2022-07-20 12:29:10 +0000] [1] [INFO] Listening at: unix:/nginx/gunicorn.socket,http://<IP_ADDRESS>:8888 (1)
[2022-07-20 12:29:10 +0000] [1] [INFO] Using worker: gevent
[2022-07-20 12:29:10 +0000] [14] [INFO] Booting worker with pid: 14
[2022-07-20 12:29:10 +0000] [14] [INFO] Making Psycopg2 Green
[2022-07-20 12:29:10 +0000] [14] [INFO] Made Psycopg2 Green
Starting Safe Transaction Service version 4.4.2 on Matic
Slack not configured, ignoring
2022-07-20 12:29:16,976 [INFO] [MainProcess] DbTxDecoder: Loading contract ABIs for decoding
[2022-07-20 12:29:17 +0000] [14] [ERROR] Exception in worker process
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/django/db/backends/base/base.py", line 219, in ensure_connection
    self.connect()
  File "/usr/local/lib/python3.10/site-packages/django/utils/asyncio.py", line 33, in inner
    return func(*args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/django/db/backends/base/base.py", line 200, in connect
    self.connection = self.get_new_connection(conn_params)
  File "/usr/local/lib/python3.10/site-packages/django_db_geventpool/backends/postgresql_psycopg2/base.py", line 49, in get_new_connection
    self.connection = self.pool.get()
  File "/usr/local/lib/python3.10/site-packages/django_db_geventpool/backends/postgresql_psycopg2/psycopg2_pool.py", line 76, in get
    conn = self.create_connection()
  File "/usr/local/lib/python3.10/site-packages/django_db_geventpool/backends/postgresql_psycopg2/psycopg2_pool.py", line 119, in create_connection
    conn = self.connect(*self.args, **self.kwargs)
  File "/usr/local/lib/python3.10/site-packages/psycopg2/__init__.py", line 122, in connect
    conn = _connect(dsn, connection_factory=connection_factory, **kwasync)
  File "/usr/local/lib/python3.10/site-packages/psycogreen/gevent.py", line 32, in gevent_wait_callback
    state = conn.poll()
psycopg2.OperationalError: could not connect to server: Connection refused
        Is the server running on host "txs-db" (<IP_ADDRESS>) and accepting
        TCP/IP connections on port 5432?

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/gunicorn/arbiter.py", line 589, in spawn_worker
    worker.init_process()
  File "/usr/local/lib/python3.10/site-packages/gunicorn/workers/ggevent.py", line 146, in init_process
    super().init_process()
  File "/usr/local/lib/python3.10/site-packages/gunicorn/workers/base.py", line 134, in init_process
    self.load_wsgi()
  File "/usr/local/lib/python3.10/site-packages/gunicorn/workers/base.py", line 146, in load_wsgi
    self.wsgi = self.app.wsgi()
  File "/usr/local/lib/python3.10/site-packages/gunicorn/app/base.py", line 67, in wsgi
    self.callable = self.load()
  File "/usr/local/lib/python3.10/site-packages/gunicorn/app/wsgiapp.py", line 58, in load
    return self.load_wsgiapp()
  File "/usr/local/lib/python3.10/site-packages/gunicorn/app/wsgiapp.py", line 48, in load_wsgiapp
    return util.import_app(self.app_uri)
  File "/usr/local/lib/python3.10/site-packages/gunicorn/util.py", line 359, in import_app
    mod = importlib.import_module(module)
  File "/usr/local/lib/python3.10/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/app/config/wsgi.py", line 38, in <module>
    application = get_wsgi_application()
  File "/usr/local/lib/python3.10/site-packages/django/core/wsgi.py", line 12, in get_wsgi_application
    django.setup(set_prefix=False)
  File "/usr/local/lib/python3.10/site-packages/django/__init__.py", line 24, in setup
    apps.populate(settings.INSTALLED_APPS)
  File "/usr/local/lib/python3.10/site-packages/django/apps/registry.py", line 122, in populate
    app_config.ready()
  File "/app/safe_transaction_service/history/apps.py", line 21, in ready
    get_db_tx_decoder()  # Build tx decoder cache
  File "/app/safe_transaction_service/contracts/tx_decoder.py", line 129, in get_db_tx_decoder
    return _get_db_tx_decoder()
  File "/app/safe_transaction_service/contracts/tx_decoder.py", line 122, in _get_db_tx_decoder
    return DbTxDecoder()
  File "/app/safe_transaction_service/contracts/tx_decoder.py", line 159, in __init__
    ] = self._generate_selectors_with_abis_from_abis(self.get_supported_abis())
  File "/app/safe_transaction_service/contracts/tx_decoder.py", line 232, in _generate_selectors_with_abis_from_abis
    return {
  File "/app/safe_transaction_service/contracts/tx_decoder.py", line 232, in <dictcomp>
    return {
  File "/usr/local/lib/python3.10/site-packages/django/db/models/query.py", line 353, in _iterator
    yield from self._iterable_class(self, chunked_fetch=use_chunked_fetch, chunk_size=chunk_size)
  File "/usr/local/lib/python3.10/site-packages/django/db/models/query.py", line 171, in __iter__
    for row in compiler.results_iter(chunked_fetch=self.chunked_fetch, chunk_size=self.chunk_size):
  File "/usr/local/lib/python3.10/site-packages/django/db/models/sql/compiler.py", line 1130, in results_iter
    results = self.execute_sql(MULTI, chunked_fetch=chunked_fetch, chunk_size=chunk_size)
  File "/usr/local/lib/python3.10/site-packages/django/db/models/sql/compiler.py", line 1171, in execute_sql
    cursor = self.connection.chunked_cursor()
  File "/usr/local/lib/python3.10/site-packages/django/utils/asyncio.py", line 33, in inner
    return func(*args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/django/db/backends/postgresql/base.py", line 266, in chunked_cursor
    return self._cursor(
  File "/usr/local/lib/python3.10/site-packages/django/db/backends/base/base.py", line 235, in _cursor
    self.ensure_connection()
  File "/usr/local/lib/python3.10/site-packages/django/utils/asyncio.py", line 33, in inner
    return func(*args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/django/db/backends/base/base.py", line 218, in ensure_connection
    with self.wrap_database_errors:
  File "/usr/local/lib/python3.10/site-packages/django/db/utils.py", line 90, in __exit__
    raise dj_exc_value.with_traceback(traceback) from exc_value
  File "/usr/local/lib/python3.10/site-packages/django/db/backends/base/base.py", line 219, in ensure_connection
    self.connect()
  File "/usr/local/lib/python3.10/site-packages/django/utils/asyncio.py", line 33, in inner
    return func(*args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/django/db/backends/base/base.py", line 200, in connect
    self.connection = self.get_new_connection(conn_params)
  File "/usr/local/lib/python3.10/site-packages/django_db_geventpool/backends/postgresql_psycopg2/base.py", line 49, in get_new_connection
    self.connection = self.pool.get()
  File "/usr/local/lib/python3.10/site-packages/django_db_geventpool/backends/postgresql_psycopg2/psycopg2_pool.py", line 76, in get
    conn = self.create_connection()
  File "/usr/local/lib/python3.10/site-packages/django_db_geventpool/backends/postgresql_psycopg2/psycopg2_pool.py", line 119, in create_connection
    conn = self.connect(*self.args, **self.kwargs)
  File "/usr/local/lib/python3.10/site-packages/psycopg2/__init__.py", line 122, in connect
    conn = _connect(dsn, connection_factory=connection_factory, **kwasync)
  File "/usr/local/lib/python3.10/site-packages/psycogreen/gevent.py", line 32, in gevent_wait_callback
    state = conn.poll()
django.db.utils.OperationalError: could not connect to server: Connection refused
        Is the server running on host "txs-db" (<IP_ADDRESS>) and accepting
        TCP/IP connections on port 5432?

[2022-07-20 12:29:17 +0000] [14] [INFO] Worker exiting (pid: 14)
[2022-07-20 12:29:17 +0000] [1] [INFO] Shutting down: Master
[2022-07-20 12:29:17 +0000] [1] [INFO] Reason: Worker failed to boot.
==> 12:29:58 ==> Collecting statics...
==> 12:29:58 ==> Send via Slack info about service version and network
==> 12:29:58 ==> Running Gunicorn...
[2022-07-20 12:29:58 +0000] [1] [INFO] Starting gunicorn 20.1.0
[2022-07-20 12:29:58 +0000] [1] [INFO] Listening at: unix:/nginx/gunicorn.socket,http://<IP_ADDRESS>:8888 (1)
[2022-07-20 12:29:58 +0000] [1] [INFO] Using worker: gevent
[2022-07-20 12:29:58 +0000] [15] [INFO] Booting worker with pid: 15
[2022-07-20 12:29:58 +0000] [15] [INFO] Making Psycopg2 Green
[2022-07-20 12:29:58 +0000] [15] [INFO] Made Psycopg2 Green
2022-07-20 12:30:03,316 [INFO] [MainProcess] DbTxDecoder: Loading contract ABIs for decoding
[2022-07-20 12:30:03 +0000] [15] [ERROR] Exception in worker process
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/django/db/backends/utils.py", line 84, in _execute
    return self.cursor.execute(sql, params)
psycopg2.errors.UndefinedTable: relation "contracts_contractabi" does not exist
LINE 1: ...OLD FOR SELECT "contracts_contractabi"."abi" FROM "contracts...
                                                             ^

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/django/db/models/sql/compiler.py", line 1175, in execute_sql
    cursor.execute(sql, params)
  File "/usr/local/lib/python3.10/site-packages/django/db/backends/utils.py", line 66, in execute
    return self._execute_with_wrappers(sql, params, many=False, executor=self._execute)
  File "/usr/local/lib/python3.10/site-packages/django/db/backends/utils.py", line 75, in _execute_with_wrappers
    return executor(sql, params, many, context)
  File "/usr/local/lib/python3.10/site-packages/django/db/backends/utils.py", line 79, in _execute
    with self.db.wrap_database_errors:
  File "/usr/local/lib/python3.10/site-packages/django/db/utils.py", line 90, in __exit__
    raise dj_exc_value.with_traceback(traceback) from exc_value
  File "/usr/local/lib/python3.10/site-packages/django/db/backends/utils.py", line 84, in _execute
    return self.cursor.execute(sql, params)
django.db.utils.ProgrammingError: relation "contracts_contractabi" does not exist
LINE 1: ...OLD FOR SELECT "contracts_contractabi"."abi" FROM "contracts...
                                                             ^

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/gunicorn/arbiter.py", line 589, in spawn_worker
    worker.init_process()
  File "/usr/local/lib/python3.10/site-packages/gunicorn/workers/ggevent.py", line 146, in init_process
    super().init_process()
  File "/usr/local/lib/python3.10/site-packages/gunicorn/workers/base.py", line 134, in init_process
    self.load_wsgi()
  File "/usr/local/lib/python3.10/site-packages/gunicorn/workers/base.py", line 146, in load_wsgi
    self.wsgi = self.app.wsgi()
  File "/usr/local/lib/python3.10/site-packages/gunicorn/app/base.py", line 67, in wsgi
    self.callable = self.load()
  File "/usr/local/lib/python3.10/site-packages/gunicorn/app/wsgiapp.py", line 58, in load
    return self.load_wsgiapp()
  File "/usr/local/lib/python3.10/site-packages/gunicorn/app/wsgiapp.py", line 48, in load_wsgiapp
    return util.import_app(self.app_uri)
  File "/usr/local/lib/python3.10/site-packages/gunicorn/util.py", line 359, in import_app
    mod = importlib.import_module(module)
  File "/usr/local/lib/python3.10/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/app/config/wsgi.py", line 38, in <module>
    application = get_wsgi_application()
  File "/usr/local/lib/python3.10/site-packages/django/core/wsgi.py", line 12, in get_wsgi_application
    django.setup(set_prefix=False)
  File "/usr/local/lib/python3.10/site-packages/django/__init__.py", line 24, in setup
    apps.populate(settings.INSTALLED_APPS)
  File "/usr/local/lib/python3.10/site-packages/django/apps/registry.py", line 122, in populate
    app_config.ready()
  File "/app/safe_transaction_service/history/apps.py", line 21, in ready
    get_db_tx_decoder()  # Build tx decoder cache
  File "/app/safe_transaction_service/contracts/tx_decoder.py", line 129, in get_db_tx_decoder
    return _get_db_tx_decoder()
  File "/app/safe_transaction_service/contracts/tx_decoder.py", line 122, in _get_db_tx_decoder
    return DbTxDecoder()
  File "/app/safe_transaction_service/contracts/tx_decoder.py", line 159, in __init__
    ] = self._generate_selectors_with_abis_from_abis(self.get_supported_abis())
  File "/app/safe_transaction_service/contracts/tx_decoder.py", line 232, in _generate_selectors_with_abis_from_abis
    return {
  File "/app/safe_transaction_service/contracts/tx_decoder.py", line 232, in <dictcomp>
    return {
  File "/usr/local/lib/python3.10/site-packages/django/db/models/query.py", line 353, in _iterator
    yield from self._iterable_class(self, chunked_fetch=use_chunked_fetch, chunk_size=chunk_size)
  File "/usr/local/lib/python3.10/site-packages/django/db/models/query.py", line 171, in __iter__
    for row in compiler.results_iter(chunked_fetch=self.chunked_fetch, chunk_size=self.chunk_size):
  File "/usr/local/lib/python3.10/site-packages/django/db/models/sql/compiler.py", line 1130, in results_iter
    results = self.execute_sql(MULTI, chunked_fetch=chunked_fetch, chunk_size=chunk_size)
  File "/usr/local/lib/python3.10/site-packages/django/db/models/sql/compiler.py", line 1178, in execute_sql
    cursor.close()
psycopg2.errors.InvalidCursorName: cursor "_django_curs_140598052287792_sync_1" does not exist

[2022-07-20 12:30:03 +0000] [15] [INFO] Worker exiting (pid: 15)
Starting Safe Transaction Service version 4.4.2 on Matic
Slack not configured, ignoring
[2022-07-20 12:30:04 +0000] [1] [INFO] Shutting down: Master
[2022-07-20 12:30:04 +0000] [1] [INFO] Reason: Worker failed to boot.
==> 12:30:22 ==> Collecting statics...
==> 12:30:22 ==> Send via Slack info about service version and network
==> 12:30:22 ==> Running Gunicorn...
[2022-07-20 12:30:23 +0000] [1] [INFO] Starting gunicorn 20.1.0
[2022-07-20 12:30:23 +0000] [1] [INFO] Listening at: unix:/nginx/gunicorn.socket,http://<IP_ADDRESS>:8888 (1)
[2022-07-20 12:30:23 +0000] [1] [INFO] Using worker: gevent
[2022-07-20 12:30:23 +0000] [13] [INFO] Booting worker with pid: 13
[2022-07-20 12:30:23 +0000] [13] [INFO] Making Psycopg2 Green
[2022-07-20 12:30:23 +0000] [13] [INFO] Made Psycopg2 Green
2022-07-20 12:30:29,393 [INFO] [MainProcess] DbTxDecoder: Loading contract ABIs for decoding
2022-07-20 12:30:29,541 [INFO] [MainProcess] DbTxDecoder: Contract ABIs for decoding were loaded
Starting Safe Transaction Service version 4.4.2 on Matic
Slack not configured, ignoring
2022-07-20 12:32:06,842 MT::GET::admin/login/::1258::200::/txs/admin/login/
2022-07-20 12:32:08,918 MT::GET::admin/login/::16::200::/txs/admin/login/
2022-07-20 12:32:14,714 MT::POST::admin/login/::460::302::/txs/admin/login/
2022-07-20 12:32:14,740 MT::GET::admin/::2::302::/txs/admin/
2022-07-20 12:32:14,767 MT::GET::admin/login/::8::200::/txs/admin/login/
2022-07-20 12:32:23,711 MT::POST::admin/login/::259::302::/txs/admin/login/
2022-07-20 12:32:23,729 MT::GET::admin/::1::302::/txs/admin/
2022-07-20 12:32:23,751 MT::GET::admin/login/::7::200::/txs/admin/login/

@Uxio0 Unfortunately, same result for me with your .env file...
Here is the full log of  safe-infrastructure-txs-web-1 service, since the very beginning, in my case.
1st restart is due to postgresql container is created, but Postgres itself not booted yet. That's ok
2nd restart - I'm doing that manually, because of some migration errors (Potential issue?)
I've checked the database, after running the user creation script, root user with my email is present under auth_user table in Postgres database, so I assume create user script is running fine...

Could you remove data folder?

The user is created by the script without any issues. If I try to login without user creation or with wrong login credentials I will get Please enter the correct username and password for a staff account. Note that both fields may be case-sensitive. error.

Which browser are you using out of curiosity? I think this issue happened with one browser.
If you have another one could you try using that one? Just to check if this is the case.

@fmrsabino that's the catch.
Chrome 103.0.5060.114 logs in without any issues.
Safari 15.5 (176<IP_ADDRESS>.8) - behaves like that.
My bad I haven't tried another browser, thank you guys for help!

We are closing the issue as with Firefox and Chrome is working, and we don't intend to fix Safari. Though if someone provides a PR fixing it we will merge it


Make sure config options are implemented

Right now, I think moduleSuffix, ignoredModules and noModuleSuffix do nothing.
Something from to https://github.com/lwm/tasty-discover/issues/75 will make tests for these.

Arrived with #80.


Functioning initial Tectonic Subgraph

@BenReilly19 let us know if this is ready

@this-username-is-taken This pull is ready to be merged. Working on Rewards now will send another PR after that is added, or you can cancel this and I will PR again once rewards are functioning. Up to you.

oh i see. Feel free to continue off this PR then


feat: add vulnerability report verifier to helm chart

Description
What this PR does / why we need it:

Adds vuln report verifier template to verifier.yaml
Adds values associated to values.yaml
Updates helm chart doc with new values

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
[x] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

[ ] Test A
[ ] Test B

Checklist:

[ ] Does the affected code have corresponding tests?
[ ] Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
[ ] Does this introduce breaking changes that would require an announcement or bumping the major version?
[ ] Do all new files have appropriate license header?

Post Merge Requirements

[ ] MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

wonder if we should add a sample CR under config directory? And what about the CLI case?

wonder if we should add a sample CR under config directory? And what about the CLI case?

I added a couple CR samples under config directory here: https://github.com/deislabs/ratify/blob/main/config/samples/config_v1beta1_verifier_vulnerabilityreport.yaml. They are used by e2e tests. For CLI there's also one used by bats test like the other verifiers here: https://github.com/deislabs/ratify/blob/main/test/bats/tests/config/vulnerabilityreport_config.json.
I can update the config.json file to add the vulnerability report verifier though.