allow pilot to run by itself

using cmd:
helm install install/kubernetes/helm/istio --name istio --namespace istio-system --set security.enabled=false
--set ingress.enabled=false
--set gateways.istio-ingressgateway.enabled=false
--set gateways.istio-egressgateway.enabled=false
--set galley.enabled=false
--set sidecarInjectorWebhook.enabled=false
--set mixer.enabled=false
--set prometheus.enabled=false
--set global.proxy.envoyStatsd.enabled=false
--set pilot.sidecar=false

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun
If they are not already assigned, you can assign the PR to them by writing /assign @linsun in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Please doc this and may be make this whole thing super prominent as a "Incremental Istio Install" section instead of tucking it away in some helm install page, as its now.

Also please send same Pr to master

Just curious: what use is pilot standalone? Should it be at least
injector + gateway?
On Wed, Aug 15, 2018 at 2:14 PM Lin Sun<EMAIL_ADDRESS>wrote:

using cmd:
helm install install/kubernetes/helm/istio --name istio --namespace
istio-system --set security.enabled=false
--set ingress.enabled=false
--set gateways.istio-ingressgateway.enabled=false
--set gateways.istio-egressgateway.enabled=false
--set galley.enabled=false
--set sidecarInjectorWebhook.enabled=false
--set mixer.enabled=false
--set prometheus.enabled=false
--set global.proxy.envoyStatsd.enabled=false
--set pilot.sidecar=false
You can view, comment on, or merge this pull request online at:
https://github.com/istio/istio/pull/7951
Commit Summary

WIP adding istio ingress gateway chart
WIP - to be tested but seems able to generate the gateway yamls
put the condition in comments to allow kubectl apply
additional tweaks
Merge branch 'release-1.0' of https://github.com/istio/istio into
release-1.0
Address comments from 7408 #7469
Merge branch 'release-1.0' of https://github.com/istio/istio into
release-1.0
allow users to configure cp namespace
rename cpNamespace to istioNamespace
adding istioNamespace to values.yaml
address shriram comment
delete accidentally added file
simplify custom gateway yaml
address costin's comment
address shriram's comment
resolve conflict
Merge branch 'release-1.0' of https://github.com/istio/istio into
release-1.0
Merge branch 'release-1.0' of https://github.com/istio/istio into
release-1.0
address costin comment
Merge branch 'release-1.0' of https://github.com/istio/istio into
release-1.0
Allow users to run pilot by itself
Merge branch 'release-1.0' of https://github.com/istio/istio into
release-1.0
delete not needed file
revert accidentally changed file
remove uneeded change

File Changes

M
install/kubernetes/helm/istio/charts/pilot/templates/deployment.yaml
https://github.com/istio/istio/pull/7951/files#diff-0 (1)

Patch Links:

https://github.com/istio/istio/pull/7951.patch
https://github.com/istio/istio/pull/7951.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/7951, or mute the thread
https://github.com/notifications/unsubscribe-auth/AJGIxit_KL5mcnxt3p4aYX27845S2U07ks5uRI9LgaJpZM4V-0tb
.

@rshriram will do!
@kyessenov it is useful when folks start with nginx and then move to istio ingress gateway.
@ymesika I found out sidecar injector pod/deployment isn't really needed for this pilot only mode... only the injector config.  FYI.


Debt CRD

if user in arrears, should limit his use.
Complete the following functions

The commit title needs to be more detailed. title needs to be able to be put in the change log.


Convert Stored Procedure to Repository Method

Hi @volkanceylan,
I have following Stored procedure to get Item in stock how this can be achieved using repository. this will help me to get rid of stored procedure.
     SELECT Max(si.StockId) as StockId
      ,Max(si.PartyId) as PartyId
      ,Max(si.ItemTypeId) as ItemTypeId
      ,Max(ca.ItemType) as ItemType
      ,Max(si.ProductId) as ProductId
      ,Max(pr.ProductCode) as ProductCode
      ,Max(pr.ProductName) as ProductName
      ,Max(ca.BaseItemName) as BaseItemName
      ,Max(ca.TypeName) as TypeName
      ,Max(ca.SubTypeName) as SubTypeName
      ,Sum(si.Pieces) as Pieces
      ,Sum(si.Weight) as Weight
      ,Max(si.NetWeight) as NetWeight

      FROM StockPosting si
      inner join CommonAttributes ca on si.AttributeId=ca.AttributeId
      inner join ProductMaster pr on si.ProductId=pr.ProductId
      Group By SKU,si.ProductId
      having SUM(si.Pieces)>0 and Sum(si.Weight)>0

Since this procedure doesn't appear to be taking in any parameters, why not convert it to a view instead? A view will behave exactly the same as a regular table does, except for the inserts/updates/deletes.

Checkout how this is done in dapper - I think Serenity uses dapper in its underlying data access..
Joins here ..Search there and I think you will have the complete answer ..
https://dapper-tutorial.net/knowledge-base/43973685/dapper-map-multiple-joins-sql-query

@reach2rv I believe you can also just create the Query ..new SqlQuery()  like this below (or you can create the query using your query as a  string value.
        public static GetNextNumberResponse GetNextNumber(IDbConnection connection, GetNextNumberRequest request,
            Field field)
        {
            var prefix = request.Prefix ?? "";

            var max = connection.Query<string>(new SqlQuery()
                .From(field.Fields)
                .Select(Sql.Max(field.Expression))
                .Where(
                    field.StartsWith(prefix) &&
                    field >= prefix.PadRight(request.Length, '0') &&
                    field <= prefix.PadRight(request.Length, '9')))
                .FirstOrDefault();

            var response = new GetNextNumberResponse();

            long l;
            response.Number = max == null ||
                !long.TryParse(max.Substring(prefix.Length), out l) ? 1 : l + 1;

            response.Serial = prefix + response.Number.ToString()
                .PadLeft(request.Length - prefix.Length, '0');

            return response;
        }


chore(common): remove unused path

What/Why?
Leftover from cli prep work, no longer needed.

Didn't notice it was a draft :sorry:


feat: compute base_fee on L1

Implement the same computaiton for the base_fee as done in the python notebook.
I believe creating a small library can be useful for it. Testing can be made very convenient since we already have a base implementation in python which was found acceptable and we can simple take the the input/output combinations from it and ensure that the same is computed here.

Until #9716 is in, we can "cheat" slightly, by adding it to the header but just have the value be 0. That way, we can run e2e and other tests as they are now, but showcase with L1 that the thing will work when the value is propagated throughout.


Bump sidekiq from 6.5.5 to 6.5.12

Resolves https://github.com/alphagov/asset-manager/security/dependabot/34.
This also downgrades redis, since support for Redis 5.x was removed from sidekiq in https://github.com/sidekiq/sidekiq/commit/d566154107e6543ccb42e0d2e7eddfb529f0933e.
This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.
⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠
Follow these steps if you are doing a Rails upgrade.

This has been done in https://github.com/alphagov/transition/pull/1447.


Halloween fixes

Fixed player controls not working when you are not the admin
Fixed seek sync (the seek event didn't include play state)

Merge without waiting for requirements to be met (bypass branch protections)


AWS Authentication

Cleanup old RI code, streamline authentication.

Merging so I can pick up the changes to my branch.


[6.x] Allow to create fake file with content

This allows to create a fake file with specifying the content.
My personal use case is the following; in my system people can upload a file but i need to do some action when the file content changes. To do that i'm comparing the files md5 to detect if the file changed.
In tests when using File::create() laravel is creating an empty file each time, so there is no difference
between the two md5, this is why i need to be able to have a different content each time so the md5 can be different during the test.

You can already do:
Storage::fake()
Storage::put('foo/bar', 'content');

Or am I missing something?

@taylorotwell This is for working with fake file uploads not files on the storage.
$file = UploadedFile::fake()->createWithContent('file.txt', "My content");

$response = $this->post('/upload-some-file', [
    'file' => $file,
]);


Added solidity cheatsheet

Added Solidity Cheatsheet.
Hacktoberfest 2022.

Hello @jalajsc
Thanks for your contribution.
Let's connect ->
GitHub -> @Suryansh1720001 (Follow)
LinkedIn -> https://www.linkedin.com/in/suryanshprajapati17
Also, star the repo ⭐


Convert a C++ program

I created the Convert a C++ program page based on Dorothy's updates to the Cilk Plus programmer's guide. It could use a review. TB skimmed it and saw: "a couple formatting issues and one technical error.  In addition, there are steps in the overview that are not reflected in the rest of the document."

How would you like to receive feedback? And would you like feedback on structure/organization? For example, here are a few options I can think of: annotated pdf printout of the page, editing the page and creating a pull request, providing individual corrections here.
I can see a few structural changes that might be beneficial to make --- e.g., explain the contents of the page concisely at the start of overview, and create a "Workflow for parallelizing an existing program" section containing the contents of the itemized list currently in overview.

Hi @timkaler, are you still able to review this article? We are aiming to release version 1.0 of our website, and your feedback here could help set the stage for other pieces of documentation that we'll be editing.
I just added a new editorial workflow for the website (#40 . It's intended to let people less familiar with Git contribute and edit drafts with a WordPress-dashboard-like interface, and I am curious if you find it useful. Because of this new workflow, the "Convert a C++ program" is no longer visible as it was before. It is held in a branch that is managed by Netlify CMS as part of a queue of articles that are "in review."

You can edit the article by going to https://www.opencilk.org/admin/#/workflow. If you want to share feedback and discuss (as opposed to editing the article) then right here is a great place to add your comments.
Please let me know if this process seems useful or clumsy. Thank you. I appreciate your contributions to OpenCilk.


--kubelet-extra-args may not be applied correctly due to flapping kubelet

What happened:
We have a cloud-init file, that calls bootstrap.sh and adds node labels and initial taints
/etc/eks/bootstrap.sh --kubelet-extra-args '--register-with-taints dedicated=system:NoSchedule --node-labels dedicated=system,node-role.kubernetes.io/system=' ${ClusterName}

When we start up nodes we saw that sometimes those labels/taints were not applied. After researching into it we found that sometimes kubelet was starting just after the correct kubeconfig/kubelet config was present, and just before applying the extra args. It was not considered an "initial registration" by the kubelet at that point and the settings, that are only applied upon first registration, were not applied at all.
What you expected to happen:
We expected kubelet to only start at the end of the bootstrap script, where systemctl start kubelet is called. This ensures all bootstrapping is done before kubelet attempts to start and does not result in such flaky behaviors.
How to reproduce it (as minimally and precisely as possible):

create an EKS cluster
Join nodes using bootstrap.sh with kubelet extra args (only the ones that are applied once will show this behavior):/etc/eks/bootstrap.sh --kubelet-extra-args '--register-with-taints dedicated=system:NoSchedule --node-labels dedicated=system,node-role.kubernetes.io/system=' ${ClusterName}

Anything else we need to know?:
We did fix this, by stopping the kubelet manually before running bootstrap.sh by using systemctl stop kubelet. This resulted in consistent behavior across all nodes (tested with > 100 nodes).
Environment:

AWS Region: eu-west-1
Instance Type(s): m5.2xlarge
EKS Platform version (use aws eks describe-cluster --name <name> --query cluster.platformVersion): eks.2
Kubernetes version (use aws eks describe-cluster --name <name> --query cluster.version): 1.12
AMI Version: (ami-091fc251b67b776c3)
Kernel (e.g. uname -a): Linux xxx 4.14.123-111.109.amzn2.x86_64 #1 SMP Mon Jun 10 19:37:57 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Release information (run cat /etc/eks/release on a node):

BASE_AMI_ID="ami-03f4c9c1a6e99a8ca"
BUILD_TIME="Sat Jun 15 03:31:01 UTC 2019"
BUILD_KERNEL="4.14.123-111.109.amzn2.x86_64"
ARCH="x86_64"

With the v1.13.11-eks-5876d6 AMIs I've gotten this launch script to set the k8s labels on newly created nodes, using the workaround @nirnanaaa described:
#!/bin/bash
set -o xtrace
systemctl stop kubelet
/etc/eks/bootstrap.sh \
  ...
  --kubelet-extra-args '"--allowed-unsafe-sysctls=net.core.somaxconn" "--node-labels=kevin-experiment-1=ok,kevin-experiment-2=ok"' \
  ...

As I understand it

when Packer makes the EKS AMI, install-worker.sh sets up the /etc/systemd/system/kubelet.service file which calls kublet with $KUBELET_EXTRA_ARGS,
whenever the AMI's bootstrap.sh is called, it sets up the /etc/systemd/system/kubelet.service.d/30-kubelet-extra-args.conf file which sets that KUBELET_EXTRA_ARGS envvar (like so), and
when our worker autoscaling group uses its launch configuration it calls that bootstrap.sh.

So (re: https://github.com/awslabs/amazon-eks-ami/issues/29) it's important that where we call bootstrap.sh, we have all the quoting just right (it's sensitive).  And (re: this and https://github.com/awslabs/amazon-eks-ami/issues/184) if anything invokes kublet.service before 30-kublet-extra-args.conf (before it exists, or before it's invoked), none of these extra arguments will be included.
Does that make sense?

It sounds like your cloud-init is racing CloudFormation's cfn-init which already calls bootstrap.sh without the args you want. https://github.com/awslabs/amazon-eks-ami/blob/8c61db5239205b27c4afa687eb4f05738f0b7312/amazon-eks-nodegroup.yaml#L498
Does setting these args in BootstrapArguments of the cloudformation template work?

I, at least, have been using Terraform..

OK, then I think the fix that would work for everyone is for bootstrap.sh to always call systemctl stop kubelet, or replace start with restart.
It seems like for those that do use the CFN template the BootstrapArguments parameter is not super obvious. And whether one uses CFN or not, there is a (totally reasonable) expectation that executing bootstrap.sh with the kubelet-extra-args arg always actually does something.


Ability for operators to end conversations

Give operators ability to use the /end_conversation command

Lol, I'm not sure if it will be resolved before the release


Add prebuilt bindings for GDAL 3.6 and document how to do it

Fixes #351

[x] I agree to follow the project's code of conduct.
[x] I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

Looks like GitHub didn't run my newly added CI check. I don't know how to trigger that.

Oops, sorry, I've already filed #353.

Oops, sorry, I've already filed #353. There's a bit more to change that the fs::write call.


travis: allow firefox beta to fail

since Firefox 52 became beta our travis builds have been failing.
This allows failure there.

Last good travis runs in FF beta:
https://travis-ci.org/webrtc/adapter/jobs/194167230#L727
https://travis-ci.org/webrtc/adapter/jobs/192888091#L741

its working fine locally. cc @jan-ivar

LGTM. We should take another look at enabling it again later.


Inplace sum

Hello,
I am working on reducing the memory used at the inference by mkldnn, and I noticed that there is no version of the sum inplace. Did I miss it ? Or would it be possible to add this possibility?
Thank you,
Adèle.

Hi @adeleCou,
Alas, in general case the in-place sum is not possible. Mainly, due to the different memory formats that inputs and output might have.
Intel MKL-DNN supports in-place sum under the following conditions:

Output buffer is the same as the buffer of the first input, i.e. dst.handle == src[0].handle
Output has the same physical memory format and data type as the first input, i.e. dst.memory_desc = src[0].memory_desc

If these conditions met, you can safely execute in-place sum.
Out of curiosity, you said you are working on reducing the memory footprint of Intel MKL-DNN. I am not sure if out-of-place sum significantly contributes to the memory consumption. Could you please share your analysis on memory consumption? For instance, some primitives might require extra internal buffers (called scratchpad) to perform some reductions or other work. It might happen that such kind of buffers might consume more than one extra buffer caused by out-of-place sum.

Thank you @emfomenk for your quick answer, I will try it out.
As for the analysis part, I had a very naive approach. I have regularly additive connections inside my network and I just wondered if I could do it inplace, (and in my mind, in terms of memory used it would be like not having these connections anymore, as it could be inplace elementwise operations). I will do some experiments and let you know if it improved significantly my footprint!
I was also planning on working on the reuse of the memory allocated for previous operations but not used anymore.
As for the internal buffers, as I am not really an expert I will leave it for now!

Hi @emfomenk , just so you know, I had an important gain doing that!
I came down from 10Go to 3Go. You might be surprised by sizes this big, but it is because I am working in 3D (~200200200 inputs), so for my case it was very interesting to do inplace computations.
Thank you for your support!

Hi @adeleCou,
Glad to hear you get such good improvement!
Just in case, please note that Eltwise (ReLU and others) and Batch Normalization also support in-place computations.

Yes, that was already used, I think I will stop here for the memory optimization part.
Thank you!


Map Loopback Addresses other than <IP_ADDRESS> between Windows and WSL VM

Is your feature request related to a problem? Please describe.
I am developing a local Kubernetes environment using minikube that exposes a variety of ports to simulate our production Kubernetes environment. I want to be able to bind to an address other than <IP_ADDRESS> for minikube tunnel so that ports like 80 and 443 are not bound on the primary loopback address and still be able to access the loopback address from within WSL.
Describe the solution you'd like
Loopback addresses other than <IP_ADDRESS> such as <IP_ADDRESS> or <IP_ADDRESS> are mapped between Windows and WSL. This is the same request as #4349 which was closed but not resolved.
Describe alternatives you've considered
Not using WSL.
Additional context
n/a

/feature


kie-issues#552: Add a parseable file on the repo directory of KIE Tools containing the exact versions of tools necessary to build it

Closes https://github.com/kiegroup/kie-issues/issues/552
@tiagobento @gitgabrio @jomarko
As agreed, I added a json file that contains all the tool's versions at this time.
Let me know if the format is ok. Hope this is the first step to simplify the CI/CD management of kie-tools.
After merging that, I'll backport this file in 9.0.x with the older version (eg. pnpm 7.26.0), so the CI/CD can rely on this file in both main and 9.0.x branches.

Great @yesamer many thanks!


prebuilt entity - personName on emails false positive

In case of emails - if we have personName prebuilt entity, it always returns as personName for emails too. For example if<EMAIL_ADDRESS>is input, jhon@domain is returned as personName which shouldn't be the case.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 36f8336b-e401-01cd-86d6-5c1a2014c238
Version Independent ID: bbb7f18f-6a31-52cb-bba6-c669187da7b6
Content: PersonName prebuilt entity - Azure Cognitive Services
Content Source: articles/cognitive-services/LUIS/luis-reference-prebuilt-person.md
Service: cognitive-services
Sub-service: language-understanding
GitHub Login: @diberry
Microsoft Alias: diberry

@abhigyank Thanks for the feedback. We are investigating the issue and will update you shortly.

@cahann @hazemelh This is a service issue. Can you please look at it?

@ram-msft Please assign to @tellarin.

@tellarin - any update?

@abhigyank Please post this on the https://github.com/Microsoft/Recognizers-Text github repository. #please-close

@diberry, @abhigyank, this is outside the scope for Recognizers-Text, so that repo is not the right place for it. Unfortunately there's no update on this yet, still in the roadmap for discussion.


switching a p2 body from static or kinematic to dynamic doesn't account for infinite mass

Helping a dude on the forums, I came across this behaviour: static and kinematic bodies automatically get infinite mass. but switching the body to dynamic later doesn't update the mass properties before the next physics update apparently, so if there's gravity on it (for example), the infinite mass leads to infinite force, and that leads to suffering (ie NaN position values).

It would update the mass and set it to 1, but only if the mass was zero. Anything else would ignore it. It now automatically sets the mass to 1 every time, no matter what value it was before.


Index link

@john-deng PL fix Conflicting files

I'd like to close this PR due to https://github.com/developer-learning/night-reading-go/pull/80#issuecomment-443684755


Added error-checking against null process name in sanitize().

Added error-reaction in WriteCoreDumpInternal() according to null process name.

@josalem But for example in sanitize(), if we save the check for NULL by feeding it "(null)", sanitize() will still parse thru "(null)" redundantly, though it will be just 6 loops each time ProcDump dumps the file.

But for example in sanitize(), if we save the check for NULL by feeding it "(null)", sanitize() will still parse thru "(null)" redundantly, though it will be just 6 loops each time ProcDump dumps the file.

For good code quality sanitize should still check for a null input, but it should be a catastrophic error case.  I'm not concerned with sanitize "double checking" the input as its job is to sanitize input and not check that it is valid.  This does make me think of something though.  I'm not sure there is a limit to the length of cmdline, so we may want to put a cap in the number of characters read from /proc/<PID>/cmdline, but that can be a different PR.

@josalem we already limit the max number of characters read from /proc/<PID>/cmdline. See Line 402 where MAX_CMDLINE_LEN is passed to fread.

Speaking about the cmdline file, it was my first doubt as well, but it is pretty standard under the /proc filesystem. Also I had experimented by manually removing it after my redis-server is launched, and it was automatically populated within a split second. So now I do tend to think that there might be some steps in the issue creator's launching his redis-server that somehow messed up the cmdline file that is out of my imagination.

@nikkitan the reason why you don't see it in VSCode is that it is interpreting the indentation and formatting the code for you. Please fix the configuration of your editor to resolve this issue.


Bugfix #921 cannot import name 'get_distribution'

Replace pkg_resources with importlib solution to fix
https://github.com/jazzband/django-axes/issues/921
Because importlib.metadata is new in Python 3.8, fallback to old setuptools solution.

Hi, it would be great if this could get in, we are trying to cleanup our codebase from setuptools and axes is a dependency. Can I help out somehow?


Fixing the Autoplay section and typo.

Fixing the Autoplay section, which was too much "personal", now it's more official. And correcting a typo.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

@Qondor I am closing this because the English was not correct and someone has submitted a PR in the meantime that has created conflicts. If your changes are still valid, please open a new PR and pay careful attention to the English spelling and grammar. Thanks.


yennadhu dha idhu

just pinging since i saw you in a discussion about azure verification id and saw you're from anna university.are you planning on building an app

Sorry that I am too late to reply back, seems the GitHub mail threads never popped this up to my inbox. I would suggest you to give https://play.google.com/store/apps/details?id=cryptic.stashit a try too.


Added a scheduled task to prune old unused ips

I guess I didn't ask before starting, but is simply removing old entries in this table all this needs to do?
I don't know that much about postgres transactions and consistency. Are there any locking concerns that I should be aware of? (with other things that might be trying to get stuff from this table. No right? We are using a real db here).
I didn't test this on any live infra (only SELECT to validate the query), as it is destructive. Would you like me to do more with regards to testing?

@sargun Ok I think I got the sql the way you want. I still made it select by vpc because the tasks are split out per-vpc anyway. It makes the sql more complex, but it makes it easier to reason about what each task is operating over?
Or maybe we don't need to fan out the tasks per vpc at all?

This has some updates from last night and now doesn't do per-vpc. Ready for second round of review.


fix: remove virtual destructors reducing binary size

Implementing static analysis recommendations of adding virtual to destructors grew binary sizes of upstream projects.

I think we should disable the SonarCloud warning about virtual functions without a virtual destructor


_requestRaw does not close stream

Android StrictMode reports:
A resource was acquired at attached stack trace but never released. See java.io.Closeable for information on avoiding resource leaks.
java.lang.Throwable: Explicit termination method 'end' not called
    at dalvik.system.CloseGuard.open(CloseGuard.java:180)
    at java.util.zip.Inflater.<init>(Inflater.java:82)
    at com.android.okhttp.okio.GzipSource.<init>(GzipSource.java:62)
    at com.android.okhttp.internal.http.HttpEngine.unzip(HttpEngine.java:645)
    at com.android.okhttp.internal.http.HttpEngine.readResponse(HttpEngine.java:827)
    at com.android.okhttp.internal.huc.HttpURLConnectionImpl.execute(HttpURLConnectionImpl.java:439)
    at com.android.okhttp.internal.huc.HttpURLConnectionImpl.getResponse(HttpURLConnectionImpl.java:384)
    at com.android.okhttp.internal.huc.HttpURLConnectionImpl.getResponseCode(HttpURLConnectionImpl.java:497)
    at com.android.okhttp.internal.huc.DelegatingHttpsURLConnection.getResponseCode(DelegatingHttpsURLConnection.java:105)
    at com.android.okhttp.internal.huc.HttpsURLConnectionImpl.getResponseCode(HttpsURLConnectionImpl.java)
    at com.algolia.search.saas.Client._requestRaw(Client.java:697)
    at com.algolia.search.saas.Client.postRequestRaw(Client.java:545)
    at com.algolia.search.saas.Index.searchRaw(Index.java:870)
    at com.algolia.search.saas.Index.search(Index.java:847)
    at com.algolia.search.saas.Index.searchSync(Index.java:135)

It is because the stream is not closed on Client.java.

Hi @yukuku, thank you for your report!
We improved the handling of open resources in #94 and will ship this change with the next minor release.

Version 3.2.2 has been released with the aforementioned fix.


Include POP action type as a public action type

This is a small PR which adds the POP (ROUTER_POP) action type to the public exports in src/index.js. Of all the types defined in src/types.js, this is the only one that was not included in the list of "public action types".
From what I can tell, it's quite useful since it's the only action which fires for both router induced back behavior (e.g., goBack()) and for browser induced back button (e.g., the browser's back button).

I found our team needed this too


Locally installed packages shown for feed

Sometimes the locally installed packages are shown for a feed.
To reproduce:

Start ChocolateyGUI
While package for local maschine are still loading switch to feed
Afterwards it shows the packages installed on the local machine, but in the left sidebar the feed is selected

Event refreshing the view doesn't help and still shows the locally installed packages instead of the packages from the feed

This was actually duplicated by the creation of this issue: https://github.com/chocolatey/ChocolateyGUI/issues/807 and was addressed as part of the Chocolatey GUI 0.17.3 release.
As such, I am going to close out this issue.


FrozenCLIPEmbedder::text_encoder_forward is implemented differently from CLIPTextTransformer::forward

I understand that FrozenCLIPEmbedder::text_encoder_forward is to replace CLIPTextTransformer::forward (more specifically, FrozenCLIPEmbedder.transformer.text_model.forward), by introducing an extra argument embedding_manager, and keeping other code logic unchanged. However, it seems the text_encoder_forward() is implemented quite differently from CLIPTextTransformer::forward().
Specifically, in Line 281,
last_hidden_state = self.encoder(
          ....
)

last_hidden_state = self.final_layer_norm(last_hidden_state)

But in huggingface transformers, we see https://github.com/huggingface/transformers/blob/main/src/transformers/models/clip/modeling_clip.py#L730
encoder_outputs = self.encoder(
       ....
)

last_hidden_state = encoder_outputs[0]
last_hidden_state = self.final_layer_norm(last_hidden_state)

They don't seem to be equivalent? Is this a potential bug? Thanks.

Sorry I realized CLIPEncoder::forward() is also overloaded. It returns hidden_states only, instead of a tuple (hidden_states, encoder_states, all_attentions). Therefore, the equivalence remains.


[ISSUE #8265] feat: speedup the stop for PopReviveService

Change-Id: I25885f0547a535c0a08afcee645c9fb430b7989a
Which Issue(s) This PR Fixes
Fixes #8246
Brief Description
How Did You Test This Change?

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 42.89%. Comparing base (949991e) to head (e860253).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8247      +/-   ##
=============================================
- Coverage      42.91%   42.89%   -0.02%
+ Complexity     10380    10372       -8
=============================================
  Files           1271     1271
  Lines          88783    88784       +1
  Branches       11408    11409       +1
=============================================
- Hits           38102    38087      -15
- Misses         45982    45988       +6
- Partials        4699     4709      +10

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Adding github "ashleymills/Reachability.swift" to Cartfile installs Swift 2.3 version

Adding github "ashleymills/Reachability.swift" to Cartfile installs Swift 2.3 version, not Swift 3 as you might expect.

https://github.com/ashleymills/Reachability.swift/blob/master/README.md#important

There's no example what to do with Carthage if you need Swift 3 version.
I've proposed update for README.md #185  to make this clear.


Prepare 1.7.3 release

Codecov Report

Merging #2569 into master will increase coverage by 1.69%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #2569      +/-   ##
============================================
+ Coverage     25.11%   26.80%   +1.69%
+ Complexity      392      390       -2
============================================
  Files           378      378
  Lines          7391     6696     -695
  Branches       1221     1220       -1
============================================
- Hits           1856     1795      -61
+ Misses         5404     4770     -634
  Partials        131      131

Impacted Files
Coverage Δ
Complexity Δ

...itlab/arturbosch/detekt/api/internal/Validation.kt
33.33% <0.00%> (-16.67%)
0.00% <0.00%> (ø%)

.../gitlab/arturbosch/detekt/cli/console/Colorizer.kt
61.53% <0.00%> (-9.90%)
0.00% <0.00%> (ø%)

...h/detekt/api/internal/DisabledAutoCorrectConfig.kt
55.55% <0.00%> (-8.09%)
4.00% <0.00%> (ø%)

...otlin/io/gitlab/arturbosch/detekt/core/TaskPool.kt
33.33% <0.00%> (-6.67%)
3.00% <0.00%> (ø%)

...in/io/gitlab/arturbosch/detekt/api/SingleAssign.kt
60.00% <0.00%> (-6.67%)
3.00% <0.00%> (ø%)

...in/kotlin/io/gitlab/arturbosch/detekt/api/Issue.kt
50.00% <0.00%> (-5.56%)
2.00% <0.00%> (ø%)

...n/io/gitlab/arturbosch/detekt/api/ConsoleReport.kt
75.00% <0.00%> (-5.00%)
4.00% <0.00%> (ø%)

...tlab/arturbosch/detekt/api/internal/EmptyConfig.kt
66.66% <0.00%> (-4.77%)
4.00% <0.00%> (ø%)

...in/io/gitlab/arturbosch/detekt/cli/OutputFacade.kt
77.77% <0.00%> (-4.05%)
5.00% <0.00%> (ø%)

...b/arturbosch/detekt/api/internal/DetektPomModel.kt
41.17% <0.00%> (-3.83%)
1.00% <0.00%> (ø%)

... and 258 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adff475...f5f6076. Read the comment docs.


Add example how to launch a job

Add an example that launches a job template using extra-vars and limit params

/assign @zgalor


VS Code looks not accept encode editor url

I use following code to open rb file in VS Code:
if defined? BetterErrors
    # Force all developers on this project to use VS Code, even if they prefer something else.
    BetterErrors.editor = 'vscode://file%<file>s:%<line>s'
end

But VS Code need url like "vscode://file/foo/bar.rb:1", not "vscode://file%2Ffoo%2Fbar.rb:1"

Read the source code, I just know I can setup editor using proc.
Now I can open the file by VS Code with following code:
In config/environments/development.rb, just add:
if defined? BetterErrors
  BetterErrors.editor = proc { |file, line| "vscode://file#{file}:#{line}" }
end

Thanks, I've updated the wiki. But I highly recommend using the EDITOR variable, rather than hard-coding it.
If you come across this in a search, please use the instructions on the wiki, which will be up-to-date, instead of the snippet above.


The parser/ and protocol.cpp leak memory

For example, this is never cleaned up.
Also some parser tokens which are newed are never deleted.

Resolved with PR #251


0.1.1 Setup Wiki

How to contribute to local-data-platform 0.1.2 release

https://readthedocs.org/projects/local-data-platform/builds/25858650/?

[x] added tutorial files
[ ] to do rebuild and understand what more changes are required

https://github.com/tusharchou/local-data-platform/wiki

@tusharchou here is the example PRD for the MVP. Please create an issue to align and close the PRD.
Product Requirements Document
Objective
This outlines the requirements for Local Data Platform, a web-based solution aimed at helping businesses make data-driven decisions.
The platform will allow users to:

Search for User insights
Predict User Behaviour wrt Business
Upload Business data for analysis
Download User Insights as CSV files

Problem Statement
Businesses often struggle to make informed decisions due to a lack of actionable insights. Access to predictive analytics tailored to their specific datasets remains limited, expensive, or overly complex.
Who are we solving for?

Small to Medium-Sized Enterprises (SMEs): Businesses with limited access to dedicated data science teams or tools.
Decision-Makers: Business owners, managers, or analysts seeking clear, actionable insights from their data.

Reasons it may not work?

Users might hesitate to upload sensitive business data
Insights might be too complex or irrelevant for the target audience
Issues with data ingestion, prediction accuracy, or CSV export functionality
Low adoption due to insufficient marketing

Phases
MVP Mission

Allow users to Log in/Sign up
Users should have business insights dashboard
They can search insights
They can manage insights i.e add and delete
Allows users to upload data to LDP
Enables downloading of actionable insights in CSV format.

Success Metrics
Adoption Metrics

Number of registered businesses [Aim: 10]
Percentage of users actively uploading data [Aim: 75%]
Cost to conversion [Aim: 2$]

Engagement Metrics

Time spent on the platform [Aim: 2 hr]
Number of insights searched per user per hour [Aim: 5+]
Number of insights downloaded per user per hour [Aim: 5+]

Customer Satisfaction

User retention rates [Aim: 50%]
User Churn rates [Aim: 20%]
NPS Feedback [70]

Phase
Task
Timeline
Owner
Deliverables

Planning
Finalize PRD
24 Nov 24
Tushar
Approved Doc

Design
Create the handoff ready website design
15 Dec 24
Arpita
High-fidelity designs

Frontend Dev
Build website on Framer
20 Dec 24
Arpita
Local Website

Backend Dev
API and package integration
20 Dec 24
Tushar
APIs and backend services

Integration
Combine frontend and backend
22 Dec 24
Tushar
Fully functional Staging Website

Testing
QA and bug fixing
23 Dec 24
Tushar
Bug-free release-ready product

Marketing
Social posts to engage till Launch
23 Dec 24
Arpita
Social Posts

Deployment
Launch MVP
01 Jan 25
Tushar
Live platform

Specifications
Product Design

Key Actions

Authentication & Onboarding
Upload local data/ Ingest data
Search for insights
Download button for CSV exports.
Landing page with USP
Dashboard page

showcasing insights
data upload/download options
pinned data insights

Frontend: Framer
Responsive Design

Backend Requirements

Framework: Python
Key Actions:

Data ingestion APIs for parsing and validating uploaded files.
Prediction model powered by LDP
RESTful APIs for frontend-backend communication.
Export functionality to create CSV files for download.

Database:

Testing

Unit Testing: Validate frontend components and backend APIs.
Integration Testing: Ensure seamless interaction between frontend and backend.
User Acceptance Testing (UAT): Validate product functionality with beta users.


Validation to be able to modify the schema that contains an array

issues
https://github.com/ruby-json-schema/json-schema/issues/265
PR
https://github.com/ruby-json-schema/json-schema/pull/217
We made a PR of the above-mentioned issue.
Some have made a PR so far, but none gave a work taken over in order to have ended in unfinished.
I'm happy if you are able to review
@iainbeeston

#265 should work now, as I've merged #217 (which also solves this issue)


Return a non-zero exit status if build fails

When running test scripts and the build fails, the tests are running anyway.  This obscures the build error in case an old executable is still present.

Return a non-zero exit status if one or more builds fail.
Exit test with a non-zero exit status if build fails, i.e. fail test.

Nice :+1:


Laravel 10.24.0 Shift

This pull request includes updates for the recent minor version release of Laravel as well as updates to your package dependencies. Feel free to commit any additional changes to the shift-ci-v10.24.0 branch.
Before merging, you need to:

Checkout the shift-ci-v10.24.0 branch
Review all pull request comments for additional changes
Run composer update
Thoroughly test your application (no tests?, no CI?)

:x: Shift was unable to run composer update. Please be sure to run composer update before merging to ensure your dependency changes are fully compatible and reflected in your composer.lock file.


Tasks to be added to monthly release plan

Ensure unnecessary files do not get included into extension
Review performance (basic extension load, etc)
Prepare general test plan to be executed prior to every release (linting, formatting, etc)

Review existing unit tests (update where necessary, minimize manual tests)

@brettcannon cc

Done!


Upgrade Highlight.js to Remove Deprecation Warnings

Overview of the problem
https://highlightjs.readthedocs.io/en/latest/upgrade-11.html?highlight=HighLight Block#api-changes
OS/Browser: Windows 10/Chrome
Description
Console logs about depreciation of a feature being used in an older version of highlight.js

Steps to reproduce

Navigate to https://deploy-preview-3962--buefy-org.netlify.app/ (for some reason I could only reproduce this on this PR's build)
Open your browser dev tools
In your browser's dev tools select Console
You should see the following logs

### Expected behavior
No console log messages regarding highlight.js and deprecated features.

highlightElement(element) has already been implemented on dev.


build: use PythonCall instead of PyCall

Migrate to using PythonCall instead of PyCall.

Made the other changes I wanted to make. I debated if I should just take out the Xtals.jl dependency, but decided to keep it, rationalizing that this is already sort of a "glue" package anyway so it doesn't seem worth splitting it to its own package just to remove that one dep, and reducing its functionality and/or putting it on those devs to support the functions we need seemed excessive. So anyway, it's there for now, but will only be used if the user explicitly passes in a Crystal object, and otherwise we're AtomsBase all the way down! 🎉
The tests are giving a bunch of these warnings now:
┌ Warning: `ustrip(A::AbstractArray{T}) where T <: Number` is deprecated, use `ustrip.(A)` instead.
│   caller = macro expansion at broadcast.jl:140 [inlined]
└ @ Core ~/.julia/packages/StaticArrays/jA1zK/src/broadcast.jl:140
┌ Warning: `ustrip(A::AbstractArray{T}) where T <: Number` is deprecated, use `ustrip.(A)` instead.
│   caller = _broadcast_getindex_evalf at broadcast.jl:670 [inlined]
└ @ Core ./broadcast.jl:670

which I assume we can ignore; I'm guessing they're coming from inside of some AtomsIO thing that we probably don't need to worry about.
Anyway, @thazhemadam LMK if you see any issues with this, otherwise we can merge. I'd like to have our little showcase depend on this version so that the AtomsBase stuff is there...

(I jankily merged Dhairya's old PR and then rebased this so that I can depend on this branch to work on the showcase and hopefully have things work in Pluto)

(lol, the old PR is failing tests now, but this rebased one passes, so I'm not gonna worry about it; we'll just merge and tag this and all should be good)

This looks good to be merged! Merging now.


Add support for IRC tags (Needed for Twitch)

Hi,
I've been using OrangeIRC for my app and I love it! There is one problem, however. I need to access the tags from the messages and I'm not sure how to do so using OrangeIRC or if it's even possible. Could you help me figure it out? Here's a link to the API that describes the tags:
https://dev.twitch.tv/docs/v5/guides/irc/ (See 'Bits message', 'Normal Message' listed under "PRIVMSG". There's several of them but only one shows the Normal/Bits Message information.)

I'm glad you are interested in OrangeIRC.
The page you linked mentions IRCv3, which is a newer version of the IRC protocol that OrangeIRC does not currently support.
Apparently, the data that you need is in a special format, which comes before the PRIVMSG command. I am not sure what standard they are from, maybe IRCv3, maybe custom to Twitch. They appear to be attributes, and parsing them also looks to be straightforward. It just starts with an @ symbol and is in key=value;otherkey=value format, so adding support to the message parser should be easy.
Here they are, at the front of PRIVMSG commands:
@badges=global_mod/1,turbo/1;color=#0D4200;display-name=TWITCH_UserNaME;emotes=25:0-4,12-16/1902:6-10;mod=0;room-id=1337;subscriber=0;turbo=1;user-id=1337;user-type=global_mod
I would add support for this now, but I am visiting family for the holidays and won't have the resources needed to program for about a week. In the meantime, feel free to submit a pull request adding this feature if you want.
You may run into other issues using OrangeIRCCore with Twitch's IRC servers, as they appear to use IRCv3 and other custom stuff. OrangeIRC currently aims to fully support RFC 1459, RFC 2812, and IRCv3, in that order. This isn't set in stone, and Twitch stuff could be added. Let me know if there are any specific commands Twitch needs.

Support added in b0b52e5.
The best I could do to verify that this works is make a unit test for it, but it may be different in the wild. Every instance of Message should now have a tags property, which is an array of Tag values.
Tag is defined as:
typealias Tag = (key: String, value: String?, vendor: String?)
The tags array can have zero of more Tags.
value is an optional because according to the specification and the Twitch examples it can be empty. I didn't notice vendor being mentioned in the Twitch examples, but I added support for it anyway because the IRCv3 documentation mentions it.
Let me know if this helps.


feat(pallet): follow psp22 standard for decrease_allowance and burn

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 51.52%. Comparing base (5021c2f) to head (65355ab).
Report is 2 commits behind head on chungquantin/main-psp22_pallet.

@@                        Coverage Diff                         @@
##           chungquantin/main-psp22_pallet     #310      +/-   ##
==================================================================
+ Coverage                           51.47%   51.52%   +0.05%
==================================================================
  Files                                  48       48
  Lines                                4894     4902       +8
  Branches                             4894     4902       +8
==================================================================
+ Hits                                 2519     2526       +7
- Misses                               2326     2327       +1
  Partials                               49       49

Files with missing lines
Coverage Δ

pallets/api/src/fungibles/mod.rs
92.51% <100.00%> (-0.39%)
:arrow_down:

pallets/api/src/fungibles/tests.rs
99.69% <100.00%> (+<0.01%)
:arrow_up:


Medians

Ah, medians.
Behold: https://steamcommunity.com/sharedfiles/filedetails/?id=1563428928

Title: "Fuckery" (2019)
There are a plethora of median-related issues, I'll be using this thread to categorise them all.

Routing across medians
As discovered in #39, bus routes sometimes cross medians. While it's likely the road above is a broken asset, this does merit further investigations.
Also, in #85, it was discovered that trucks can drive across medians on large roads.
And in #86, lagging vehicle repathing caused vehicles to drive over medians when a recently bulldozed road segment was replaced by an new road segment.

NetInfo.m_CanCrossLane
This property of roads, as far as I can tell, is supposed to determine whether vehicles can cross on-coming traffic.
I think it's something that needs further investigation in relation to medians, especially in relation to non-vehicle lanes, as LazarusMan (NeXT2/MOM dev) discusses here: https://github.com/VictorPhilipp/Cities-Skylines-Traffic-Manager-President-Edition/issues/196
Also, some road assets have implemented solid medians at junctions but the pathfinder (even in vanilla game) ignores them and cars driver over them.

Hey guys just to let you know things are running kinda slow but they are still running.  As I had mentioned on the Discord channel, I am working on a MOM update which will be updated soon (soon hopefully means less than a month).  After I get it out, I will be able to work on the NExt update which will finally port over the New Roads for Network Extensions mod that was abandoned and has/is causing a lot of issues for people right now.  After I get done with that, I am going to pick up another project I had put on the shelf for a year, outlined HERE.  I know that since then a lot of people have come up with roads that do this but this addon will allow for the medians to span between networks as well for most two way roads that are in the mod now.  I held off because I did not want to add these if the traffic would not honor the medians.  Now that the workshop is saturated with these median through node roads, I will have to find some way to incorporate their techniques. All that to say, I'm still on the case.

Something else I have been playing with is the idea of an interactive way of determining how a median is drawn through an intersection.  This may be an addon feature that would require NExt and TM:PE as that is all that would use it for now...But just as you have the multi-colored draggable lane routing paths through nodes, with the supporting NExt roads, you could have a draggable median mapper.  It would function similarly to the lane routing mapper, except it would only have one circle in the middle of the network at the beginning of its node.  All supporting roads would have a circle.  Once you drag the line, the median will form in the junction and the pathfinding will change to reflect this.  If you click on the endpoint of the line, you can either reroute to a different road in the junction or cancel (which would remove the median).  Obviously this is a 1 to 1 dragging thing and perhaps the roads would need to be over a certain angle from one another for it to be possible.  Upgrading one of the median roads to another supported road would maintain the junction. Just some initial brainstorming.

Ah, medians.
Behold:

Title: "Fuckery" (2019)
There are a plethora of median-related issues, I'll be using this thread to categorise them all.

Can you give me the name of that road?  It looks like a good one to test on.

The best way I've seen to toggle medians is have them based on traffic lights at the junction. For example, median is there by default but if traffic lights are added it gets removed.
IMO we should go to CO and ask that base game be updated to handle junction-crossing medians better. Requiring users to use TMPE just to control lane changes on roads that use junction-crossing medians is somewhat overkill for many users.

I'm no longer able to reproduce the issue in OP (although my city is LHT and the image in OP was done on a RHT city).

From left to right (on image above):

Pedestrian (lane 0)
Parking (lane 2)
Vehicle (lane 6)
Vehicle (lane 4)
Transport (lane 12 - opposite dir to lanes 6 & 4)
None (lane 8 - median - spans 9 & 10)
Pedestrian (lane 9 - left side of median)
Pedestrian (lane 10 - right side of median)
Transport (lane 12 - opposite dir to lanes 5 & 7)
Vehicle (lane 5)
Vehicle (lane 7)
Pedestrian (lane 1)

@aubergine10 I am trying to wrap my mind around the lane configuration that would make the original screenshot in this issue possible. Is it like this? F=forward, B=backward
BBFF BBFF
If so, then the displaced lanes project will resolve it with the newly added requirements on routing.

@Elesbaan70 see text under image in https://github.com/CitiesSkylinesMods/TMPE/issues/89#issuecomment-989562534
the asset is here: https://steamcommunity.com/sharedfiles/filedetails/?id=1563428928
I'd suggest using Network Detective to get more specific details. Also note the None lane spanning 2 pedestrian lanes in the middle. And yes, your displaced lanes project will almost certainly resolve that issue.
It might be worth collating related issue ids in your main issue so we can reference them in PR and subsequently the release notes / changelogs.

BTW, here's a list of some obscure roads that might be useful for testing: https://github.com/CitiesSkylinesMods/TMPE/wiki/Roads-to-Test

the asset is here: https://steamcommunity.com/sharedfiles/filedetails/?id=1563428928

Whoa. That led me to look up Avenida 9 de Julio, and it turns out that is the ultimate test of #1392 and #1528, together. 🤯


Implement capturing URLs during parsing

ParserContext just keeps a list of every file imported.
New method TopLevelParser.parseRootWithURLs
Abstract out ExtensibleTopLevelParser
Eliminate code redundancy in TopLevelParser

Pull Request Test Coverage Report for Build<PHONE_NUMBER>4
Details

17 of 26 (65.38%)  changed or added relevant lines in 3 files are covered.
61 unchanged lines in 22 files lost coverage.
Overall coverage increased (+0.2%) to 73.358%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

language/shared/src/main/scala/com/ossuminc/riddl/language/parsing/TopLevelParser.scala
4
8
50.0%

language/shared/src/main/scala/com/ossuminc/riddl/language/parsing/ExtensibleTopLevelParser.scala
10
15
66.67%

Files with Coverage Reduction
New Missed Lines
%

language/shared/src/main/scala/com/ossuminc/riddl/language/parsing/StreamingParser.scala
1
88.33%

language/shared/src/main/scala/com/ossuminc/riddl/language/parsing/VitalDefinitionParser.scala
1
50.0%

language/shared/src/main/scala/com/ossuminc/riddl/language/parsing/RepositoryParser.scala
1
67.5%

language/shared/src/main/scala/com/ossuminc/riddl/language/parsing/Keywords.scala
1
69.74%

language/shared/src/main/scala/com/ossuminc/riddl/language/parsing/EntityParser.scala
1
89.47%

language/shared/src/main/scala/com/ossuminc/riddl/language/parsing/AdaptorParser.scala
1
90.0%

language/shared/src/main/scala/com/ossuminc/riddl/language/parsing/FunctionParser.scala
2
82.35%

language/shared/src/main/scala/com/ossuminc/riddl/language/parsing/ProjectorParser.scala
2
88.89%

language/shared/src/main/scala/com/ossuminc/riddl/language/Messages.scala
2
85.64%

language/shared/src/main/scala/com/ossuminc/riddl/language/parsing/ProcessorParser.scala
2
66.67%

Totals

Change from base Build<PHONE_NUMBER>8:
0.2%

Covered Lines:
4846

Relevant Lines:
6606

💛  - Coveralls


Fix justification handler not to wait 500 ms

Description
Based on top of https://github.com/Cardinal-Cryptography/aleph-node/pull/1101.
Now justification handler does not wait 500ms on each start, which caused catch_up in party not to work correctly. Also might fix some other bugs when we waited for verifier unnecessarily long.
Type of change

Bug fix

It seems this has been obsoleted by removing literally all the code that it changed, so closing.


Allows you to set a UIView's userInteractionEnabled property.

Yeah, i wanted to put a UIImage over top of a MKMapView and not let the user interact with the image so that when they pan around the map, the image stays put and doesn't interfere with the touches on the map, so
def my_image(st)
  st.user_interaction_enabled = false
end

made sense to me.

:+1:  good call

:+1:


Add the OpenSSF Scorecard Github Action

Is your feature request related to a problem? Please describe.
Hello, I'm Joyce Brum, this issue is not related to any specific problem, but to overall security of the project.
I am working on behalf of Google and the OpenSSF to help essential open-source projects improve their supply-chain security. The OpenSSF is a non-profit foundation dedicated to improving the security of the open-source community. It counts GitHub as a founding member.
The Scorecard system combines dozens of automated checks to let maintainers better understand their project's supply-chain security posture. It is developed by the OpenSSF, with direct support from GitHub.
Considering te CVXPY relevance within python community, the OpenSSF has included it in its list of the 100 most critical open-source projects.
However, the OpenSSF has also developed the Scorecard GitHub Action, which adds the results of its checks to the project's security dashboard, as well as suggestions on how to solve any issues (see examples below). This Action has been adopted by 1600+ projects already.

Describe the solution you'd like
Would you be interested in a PR which adds this Action? Optionally, it can also publish your results to the OpenSSF REST API, which allows a badge with the project's score to be added to its README.

Thanks for reaching out Joyce! This sounds very helpful, and I appreciate the PR! I will discuss with the other maintainers and get back to you.


some shell builtins have non-identical stand alone corollaries

such as /bin/pwd, /bin/echo and I'm sure there are more.  Some otherwise perfectly portable and standard shell scripts may rely on these so they should be linked into /bin just like /bin/sh is.

Please open an issue at https://github.com/NixOS/nixpkgs/issues if problem persists (this repository is obsolete).


Add orientation options for tabs

Bootstrap 2.2.x introduced orientation options for tabs (see "Tabbable in any direction" under http://twitter.github.com/bootstrap/components.html#navs).
Left and right orientations should be trivial to implement. Bottom will require a switch in a template (or a separate template).

Hi, I've created a gist for what we need : https://gist.github.com/hugsbrugs/c85a6b1c10d03e8cb0da
is there any chance for angular ui team to have a look at it to get the idea incorporated in next releases because I can't figure out the interest of vertical tabs without content on it's right ?

@hugsbrugs Can you try with 0.13.0 and open a new issue if required.

hi @karianna @hugsbrugs
I try all of the above and still get the panels BELOW the tabs when they need to be to the right of the panels.      Any advice?
thanks

hi @karianna @hugsbrugs
I try all of the above and still get the panels BELOW the tabs when they need to be to the right of the panels.  Any advice?
thanks


add latest tag to new image in quay

Added a worklfow step to add the latest tag a newly created chart verifier release image in quay.
The image will not have been created when the step starts so the step checks up to 60 times, every 15 seconds for the image to appear. This is a total of 15 minutes. If this fails the image will have to be tagged manually, instructions in the README. The wait time may need adjusting based in it success rate.
Also note to add the tag an OAUTH token is required and is set as a github repository secret "QUAY_AUTH_TOKEN"

@dperaza4dustbit - responses added to all comments


py: fix paging when missing token

Fixes: #348

Description

How Has This Been Tested?

Merge criteria:

All the commits have been signed-off  (To pass the DCO check)

[ ] The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has manually tested the changes and verified that the changes work.
[ ] Code changes follow the kubeflow contribution guidelines.

If you have UI changes

[ ] The developer has added tests or explained why testing cannot be added.
[ ] Included any necessary screenshots or gifs if it was a UI change.
[ ] Verify that UI/UX changes conform the UX guidelines for Kubeflow.

cc: @tarilabs


interopDefault breaks when combining a default string export with named exports

Environment
node 18
Reproduction
require('mlly').interopDefault({ default: 'test', x: 123 })

Describe the bug
I would expect in this case that the original module would be returned rather the just the default export test
Additional context
Checking if newModule is an object after it is assigned here: https://github.com/unjs/mlly/blob/main/src/cjs.ts#L38C3-L38C3 and returning the sourceModule instead if its not an object or function should work
Logs
No response

By default interopDefault returns a proxified object that allows mixed syntax usage. We might support interopDefault({ default: 'test', x: 123 }, { strict: true }) to always return default key.

preferNamespace added as an opt-in (and non behavior changing) feature see https://github.com/unjs/mlly/commit/5d23c98a46fefd6e812fe837cbd849164eec6b50 and https://github.com/unjs/mlly/commit/14eb72d0f571e06dcd127c0d5fec7b4fa49609f9
I hope it can help in your case but if you have some usecases that belive this behavior being default could be beneficial please mention.


fix: handle invalid GH link in edit

Thanks for the PR!
Any successful deployments (not always required) will be available below.
Frontend available
Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

resolves #74


Organisation owner should be able to access everything

At least in read-only mode, probably in read-write mode like a "superadmin".

Should not be required, the permissions system allow to delegate permissions to others.


Out of memory on Jsoup.connect(UrlPath).get()

Hi,
I have added Jsoup 1.8.1 as a module in my Android application.
I created a sync class that use multiple HTTP connection to syncronize a sqlite database, used from the application. The syncronization is made using a Jsoup connection to a WS RestFull.
The Out Of Memory Exception is verified (not always) when I try to get WS result of a table that contains about 60 thousands records.
My connection to WS is something like this:
Document WS_Document = Jsoup.connect(UrlPath).maxBodySize(0).timeout(10 * 100000).get();
I used the .maxBodySize(0) to manage large XML results and .timeout(10 * 100000) to prevent the elaborations of WS that I am calling from application.
But even though I set on my manifest.xml the attribute android:largeHeap="true", and the aplication use 256 MB of memory, I get the Out Of Memory Exception (Only with very big table).
I try to see what the application do when I launch the sync method. Looking the Memory Monitor of Android Studio and whatching the log in LogCats, It's clearly visible that when the application start to execute the command:
Document WS_Document = Jsoup.connect(UrlPath).maxBodySize(0).timeout(10 * 100000).get();
the instruction start to allocate memory until it exceeds the memory limit of this famous 256 MB.
I've also tried to call the Garbage Collector (System.gc();) before and after the instuction to free all memory that I can but nothing change and the application crash with Out Of Memory Exception error.
Please help me to solve this problem.
Best Regards

What is "WS"?
What Android version and what device are you on?
What's the URL, so we can replicate? Can you give a full code snippet and the actual stack trace?
Can you attach a MAT memory dump? That would help understand what's chewing up the memory. Is it the file, what else is going on in the app, etc, are other strings being retained, etc?
What is "very big" in bytes and table rows?
It would be worth trying using 1.8.2, because there's a tweak to memory consumption there (if a node has no attributes, it no longer contains a small empty array list, but just an empty pointer).
Setting maxBodySize(0) would only make memory consumption worse, not better. It limits how much content is read from the URL. Timeout is also not relevant to memory consumption.
At some point, if you can't make enough memory available to parse the content, you may need to partition the content read.

I thing that "WS" is "WebService"

Sorry for the delay.
Hi,

What is "WS"?

WS means Web Service RestFul

What Android version and what device are you on?

I'm using a Samsung Galaxy Tab 2.0 and it has Android 4.1.2

What's the URL, so we can replicate? Can you give a full code snippet and the actual stack trace?

The problem is not on URL, neither on result of the Web Service calling. Besides, i cant give you an URL because the WebService is local and not Public.

Can you attach a MAT memory dump? That would help understand what's chewing up the memory. Is it the file, what else is going on in the app, etc, are other strings being retained, etc?

How can I do that? I trying to use Android Device Monitor but when I try to "dump JAVA Heap" nothing happen.

What is "very big" in bytes and table rows?

The "very big" in bytes and table rows is the table field's itself. This is an example of a table returned from Web Service
<addr>

It would be worth trying using 1.8.2, because there's a tweak to memory consumption there (if a node has no attributes, it no longer contains a small empty array list, but just an empty pointer).

I can upgrade my library, but I think the really problem is the allocation and creation of the object Jsop Document in case with VERY BIG DATA returned.

Setting maxBodySize(0) would only make memory consumption worse, not better. It limits how much content is read from the URL. Timeout is also not relevant to memory consumption.

I noted if i remove maxBodySize(0) the Document created by JSOUP is smaller than it should be. For example without maxBodySize(0) i see about 5k nodes instead about 60K I should have.

This is a example code that show what I mean.
Sample code
public class MainActivity extends ActionBarActivity {
private static Handler mHandler = new Handler();
private static Context context;
static TextView textView;

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);

    textView = (TextView) findViewById(R.id.textView);

    textView.setText("5 seconds to start task");

    context = this.getApplicationContext();

    mHandler.postDelayed(new Runnable() {
        public void run() {
            new syncDataWS(context).execute();
        }
    }, 5000);

}

@Override
public boolean onCreateOptionsMenu(Menu menu) {
    getMenuInflater().inflate(R.menu.menu_main, menu);
    return true;
}

@Override
public boolean onOptionsItemSelected(MenuItem item) {
    int id = item.getItemId();

    if (id == R.id.action_settings) {
        return true;
    }

    return super.onOptionsItemSelected(item);
}

private static class syncDataWS extends AsyncTask<Void, String, Void> {

    Context mContext;

    public syncDataWS(Context context) {
        this.mContext = context;
    }

    @Override
    public void onPreExecute() {
        super.onPreExecute();
        textView.append("\nStart task");
    }

    @Override
    protected Void doInBackground(Void... params) {

        try {
            publishProgress("Start call XML page");
            Document WS_Document = Jsoup.connect("URL_XML_EXAMPLE").maxBodySize(0).timeout(10 * 100000).get();
            publishProgress("End call XML page");

            publishProgress("Get rows of document");
            Elements XML_RESULT_WS = WS_Document.select("row");
            publishProgress("Record number : " + Integer.toString(XML_RESULT_WS.size()));

        } catch (IOException e) {
            e.printStackTrace();
        }

        return null;
    }

    @Override
    protected void onProgressUpdate(String... values) {
        super.onProgressUpdate(values);
        if (values != null && values.length > 0) {
            textView.append("\n" + values[0]);
        }
    }

    @Override
    protected void onPostExecute(Void result) {
        textView.append("\nEnd task");
    }
}

}
And this is a XML EXAMPLE. Put it a host and copy the URL in jsoup.connect
<XMLDataResponse xmlns="www.example.net"><XMLDataResult><root xmlns=""><row ID="1" ID2="2" ID3="3" ID4="4" F1="0.000000000000000e+000" F2="0.000000000000000e+000" F3="0.000000000000000e+000" F4="" F5="0.000000000000000e+000" F6="0.000000000000000e+000"/></root></XMLDataResult></XMLDataResponse>
take the tag row and copy + paste in XML EXAMPLE until you have 60 thousand records.
You can watch with your eyes what happend in memory monitor.
I really need a solution, everything can be helpfull.

@jhy Did you mean Eclipse MAT? https://www.eclipse.org/mat/

This is likely the same root cause as #339 and so will be fixed with #904


Check for existence of ROOT_URL in the same way as MONGO_URL

When deploying it would be better if it uses the ROOT_URL from the environment if available it is good for when there is multiple urls and for Blue/Green deployments

:+1:


Added the ability to do circular left shifts

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hey, this change assumes the bit length of the number provided, which won't always be what's required!  Before I'd want to merge this I think an option should be added to define the bit length.  This isn't required for the other parts of this operation, which might mean that this would be it's own operator?  I'm unsure.

Hey, this PR has remained without updates for four weeks now.  I'll close it now, but feel free to re-open if you find time to contribute! 😄


[<IP_ADDRESS>.3] Write Test Cases

Issue Details
Description
This Task is to write Test Cases for the Black-box Testing.
Goals
Ensure that the Test Cases in the report is being tested too.
Success or Completion Criteria
To have a section in the M3 Report with the complete Black-box testing.
Allocated Time
4 Days
Start Date: 14/11/23, 0900
End Date: 17/11/23, 2359

Issue Comments
Description
Created a Test Case Table with the inputs and error message screenshots in it.
Changes to success or completion criteria? y/n (if y, describe)
No Changes, Criteria Completed!
Start Date: 14/11/23, 0900
End Date: 17/11/23, 2359


Add LIBSSH2_SYS_USE_PKG_CONFIG env var

The latest actual release of libssh2 is old and broken. This uses the submodule instead unless you set LIBSSH2_SYS_USE_PKG_CONFIG. The mechanism is copied from libgit2.
I haven't tested this, because I don't know how to get cargo to build everything with these changes. :-/

I think this is for https://github.com/alexcrichton/ssh2-rs/issues/87, right? If so, can you also add a comment or a note here as to why the latest release is broken? I forget at this point :(

It was this issue. The latest release (1.8.0) isn't actually as old as I thought, though their releases do seem to be fairly infrequent so we might be waiting a while for another release.
Even when they do do another release with that fix, I think it is good to have an option to use the vendored code, otherwise it's hard to make dependency-free binaries. Also if you randomly compile against system libraries it is very difficult to get hermetic / reproducible builds.

Hm is it know why the system library failed there? For example where the segfault was coming from?

No idea. Here is where it fails for me:
frame #1: 0x000000010045435c libssh2.1.dylib`kex_method_diffie_hellman_group_exchange_sha256_key_exchange + 3367
libssh2.1.dylib`kex_method_diffie_hellman_group_exchange_sha256_key_exchange:
    0x10045435c <+3367>: leaq   0x14fac(%rip), %rsi       ; "SSH-2.0-libssh2_1.8.0"
    0x100454363 <+3374>: movl   $0x15, %edx
    0x100454368 <+3379>: movq   %rbx, %rdi
    0x10045436b <+3382>: callq  0x100467b56               ; symbol stub for: EVP_DigestUpdate

Which seems to be this code, but I have no idea why that would fail and it hasn't been changed recently.

Can you tell at runtime if there's perhaps two OpenSSL libraries loaded? Otherwise do you know what the faulting instruction is and can it perhaps be gleaned why it's the faulting instruction?

Ah yeah that could be it:
(lldb) image list
...
[  6] 93344C6C-82DA-3753-BFC4-E9937C66F123 0x000000010044c000 /usr/local/opt/libssh2/lib/libssh2.1.dylib
[  7] 9F02EB03-7801-350F-B8EF-6FE3C63262D5 0x0000000100473000<EMAIL_ADDRESS>[  8] 5DA76CDA-D74C-3C5A-9CAC-D37986F93269 0x00000001004d4000<EMAIL_ADDRESS>...
[146]

Hm ok that'd definitely cause problems! Mind leaving that in a comment (and maybe a link to this PR?)? After that should be good to merge!

Thanks!

In general can we please avoid these random magic environment variables? If the version is broken can you just detect it automatically? These random magic environment variables make things awkward for packagers, since it makes things not work out-of-the-box and we have to figure out which envvars to set to get things working again.

If the version is broken can you just detect it automatically?

I mean, by detecting the actual thing that is broken, rather than a version number, because we can and do patch things in Debian to fix broken versions.

For context: in Debian we are forced to patch out this PR, because it is easier than trying to set the environment variable in all crates that depend on this crate. Debian packaging for Rust crates are automatically generated, so there is no easy way to detect whether a dependency requires some magic environment variable in order to "just work" with system libs. So we cannot really set this environment variable in all the cases where it's needed, it's easier to just patch this out.

Fair point. I wonder if cargo needs a general option to tell packages whether or not to use system dependencies where possible.
I can see that in Debian you basically always want to depend on other packages, but if you're building a binary that you are distributing outside of a package manager you basically never want to use system libraries.
Perhaps another solution for Debian would be to create a central script that all Rust packages run, then you can just add this environment variable to that script if you really do want it for all packages the use this create.
The ability to make easy to distribute binaries without having to worry about system dependencies is one of the things people absolutely love about Go and I don't think Rust should give it up lightly.


loraserver  still can receive data frame after the gateway has been deleted

Is this a bug or a feature request?
Seems it is a bug.
What did you expect?
Unregistered/unauthorized gateways' data should be dropped directly.
What happened?
loraserver and lora-app-server still handle node data send/forwarded from an unauthorized/unregistered/deleted gateway.
Steps:

Add a new gateway into the DB and can works normal.Data can be received through this gateway.
Later, deleted it from the DB by lora-app-web interface.
The data can be received still from this gateway. It can be seen at the node/raw frame log page.

What version are your using?
The latest version from GitHub.
How can your issue be reproduced?
It is very easy, setup a gateway and delete it later when the data path  works
Could you share your log output?
INFO[0816] backend/gateway: rx packet received
INFO[0816] packet(s) collected                           dev_eui=0000000100000000 gw_count=1 gw_macs=0000b827eba2e377 mtype=ConfirmedDataUp
INFO[0816] rx info sent to network-controller            dev_eui=0000000100000000
-> WARN[0816] get gateways for macs error: expected 1 gateways, got 0  macs=[0000b827eba2e377]
INFO[0816] node-session saved                            dev_addr=06975145 dev_eui=0000000100000000
-> INFO[0816] backend/gateway: publishing tx packet         topic="gateway/0000b827eba2e377/tx"
INFO[0816] node-session saved                            dev_addr=06975145 dev_eui=0000000100000000
INFO[0830] backend/gateway: rx packet received
INFO[0831] packet(s) collected                           dev_eui=0000000100000000 gw_count=1 gw_macs=0000b827eba2e377 mtype=ConfirmedDataUp
INFO[0831] rx info sent to network-controller            dev_eui=0000000100000000
WARN[0831] get gateways for macs error: expected 1 gateways, got 0  macs=[0000b827eba2e377]
INFO[0831] node-session saved                            dev_addr=06975145 dev_eui=0000000100000000
INFO[0831] backend/gateway: publishing tx packet         topic="gateway/0000b827eba2e377/tx"
INFO[0831] node-session saved                            dev_addr=06975145 dev_eui=0000000100000000
INFO[0843] backend/gateway: gateway stats packet received  mac=0000b827eba2e377
ERRO[0843] handle stats packet error: get gateway error: gateway does not exist
INFO[0844] backend/gateway: rx packet received
INFO[0844] packet(s) collected                           dev_eui=0000000100000000 gw_count=1 gw_macs=0000b827eba2e377 mtype=ConfirmedDataUp
INFO[0844] rx info sent to network-controller            dev_eui=0000000100000000
WARN[0844] get gateways for macs error: expected 1 gateways, got 0  macs=[0000b827eba2e377]
INFO[0844] node-session saved                            dev_addr=06975145 dev_eui=0000000100000000
INFO[0844] backend/gateway: publishing tx packet         topic="gateway/0000b827eba2e377/tx"
INFO[0844] node-session saved                            dev_addr=06975145 dev_eui=0000000100000000

I also have this problem. And in the case I never registered gateway, the gateway UDP points to the server will automatically register.

This is not a bug. LoRa Server will process any gateway data that it receives from the MQTT broker. For the sake of performance, I don't think it is a good idea to check on each message if the gateway is part of the network or not. Also, this would be really easy to spoof.
Better is to implement a MQTT authentication / authorization meganism. E.g. for Mosquitto, you could use https://github.com/jpmens/mosquitto-auth-plug.
In case you have further questions how this could be implemented, lets continue the discussion at https://forum.loraserver.io.


How to get smpl parameters annotation in Human3.6M processing?

Thank you for your work! But how to get the smpl annotation commented here in the preprocessing of human3.6M dataset

@Wuchuq
I uploaded the file with smpl param. So you can just uncomment the lines.
If you want the smpl param data before parsing, you can obtain them from the neural annot homepage.

Thank you so much!

I find that the smpl annotation is incomplete for all the frames. For act_01_subact_01, there are only 277 annotations available. But in the preprocessed human3.6M data you provided, the smpl parameters are available for all the frames. So is there any problems with the smpl_param file?

Hi,
I couldn't understand the question. Do you mean the smpl annotation from the NeuralAnnot homepage is incomplete?

Got it. Normally image-based 3DHPSE methods use subsampled data, since the images are not much different in near frames. Human3.6M images are in 50Hz. So we released subsampled annotation for them in the NeuralAnnot homepage.

Got it. Normally image-based 3DHPSE methods use subsampled data, since the images are not much different in near frames. Human3.6M images are in 50Hz. So we released subsampled annotation for them in the NeuralAnnot homepage.

Got it! Thanks.


More efficient representation for Punctuated

Punctuated sequences of type T with punctuation type P are currently stored as Vec<(T, Option<P>)> where every punctuation is Some except for possibly the last one can be None.
It may be interesting to experiment with using some unsafe code to store this as Vec<(T, P)> where the final P is possibly uninitialized.

The representation was improved in #403.


ng-cordova-oauth.min.js has no line breaks or white space

The entirety of ng-cordova-oauth.min.js is on two lines, save for the first two lines which state the name and authorship. This makes it pretty much impossible to read.
Is this intentional?
Thanks,
Nick

@nicksam112 That's a minified version, it's intended to be like that. Please refer to ng-cordova-oauth.js (without the .min in the filename).

Thanks @marcussaad


How to connect a BLE server with bonding password

Hi,
I am trying to use ESP32 as a client and my server device has a bonding password. I couldnt find any example for how to connect a device which has bonding password. Is there any example ? Thank you.

https://github.com/nkolban/esp32-snippets/tree/master/cpp_utils/tests/BLETests/Arduino/security

No! If there is a password for bonding a device, these examples can not connect to that device. BLE Security callbacks never calls. Logs stops at connected to server.

I am sure something is wrong. Think like this there is a server which has a pairing passkey. How can i connect to that server with esp32. It is not an other esp32 it is a nrf52832


NIFI-7987: Support ignore operations in the PutKudu processor

Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Enables X functionality; fixes bug NIFI-YYYY.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[ ] Has your PR been rebased against the latest commit within the target branch (typically main)?

[ ] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[ ] Have you verified that the full build is successful on JDK 8?
[ ] Have you verified that the full build is successful on JDK 11?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

Thanks @granthenke all looks good to me! +1 will merge to main.


Github Actions For Release

Seems like we can use Github Actions to release the Windows Form App.
See docs https://github.com/microsoft/github-actions-for-desktop-apps
also (this is a guide, might be helpful) https://devblogs.microsoft.com/dotnet/continuous-integration-workflow-template-for-net-core-desktop-apps-with-github-actions/
Here is our current very basic config: https://github.com/jonasluehrig/MooveTeq-Booking/blob/develop/.github/workflows/dotnet-desktop.yml
If there are any questions, just comment below this issue :)

@McCharry any updates on this?


table-row-class-name attribute not working!

HTML:
        <mdt-table paginated-rows="{isEnabled: true, rowsPerPageValues: [5,10,20,100]}"                    mdt-row="{ data: filteredItems,                    'table-row-class-name': rowClassNameCallback,                    'column-keys': ['name', 'calories', 'fat', 'carbs', 'protein', 'sodium', 'calcium', 'iron']                    }">
JS:
        $scope.rowClassNameCallback = function(row){             console.log(row);             return 'red'         };
CSS:
.red {     color: red; }
it does not change the row to red. I tried to put a breakpoint in rowClassNameCallback function, but it does not get caught. So the function never get called. I am using Angular 1.6.3.
Thanks

I'm also facing this issue
Tried using clientScope but without further success
Thx

any update for this issue? I'm also facing this issue...please help

Ran into the same issue. The reason is the table cell styling overrides the background color of the row styling. The workaround in my case was to use the row class name function and using css to override the cell styling. In my case I wanted to disable a row based on a snooze rule in a business process in a support team looking at the same data. My row function is : (row) => (row.isBeingHandledAlready : 'snoozedRow': 'openRow'). In my css I had the following rules :
.openRow td {
background-color: #fff !important;
}
.snoozedRow td {
background-color: #d7d7c1 !important;
}
A bit of a hack but gets one moving again

FYI: I fixed this issue in https://github.com/IndoorAtlas/mdDataTable/pull/1. Not sure if it's the correct way to do it but it suited our use case.

I'm also facing this issue
Tried using clientScope but without further success
Thx

i have this problem now,
t try to drop "scoped"  from

tableRowClassName(row, rowIndex) {
console.log("init row class name");
console.log("row",row);
console.log(rowIndex)
if (row.rowIndex %2 == 0) {
console.log("result");
return 'warning-row';
} else {
return 'success-row';
}
return 'warning-row';
}

now, i show my  code , you can drop "scoped" from
    <el-table :data="tableData" style="width: 100%" border=true :row-class-name="tableRowClassName">

tableRowClassName(row, rowIndex) {
console.log("init row class name");
console.log("row",row);
console.log(rowIndex)
if (row.rowIndex %2 == 0) {
console.log("result");
return 'warning-row';
} else {
return 'success-row';
}
return 'warning-row';
}


Add 2 methods + finer checks on invalid input for alarms

I needed to be able to use NaiveTime object for setting alarms. Also, it looks like the input checks for setting alarms were a bit too strict for some matching values.

Coverage decreased (-1.01%) to 95.858% when pulling 79a0dc5485ebedee8f3de8e9383ce8e728b858e3 on dkm:master into 8c5bb160304fd3b44f9a0996e7fd304eb0b5a8d4 on eldruin:master.

I'll see how to add tests for corresponding changes

Sounds good. Thank you for the improvements. As stated before, tests for the new functions would be need to be added as well.

I am trying to see how to add tests, but I have trouble with the mock interface used. I guess I have to add expected values for i2c/spi transactions, but I don't see where. Could you guide me a bit on what I should do to add test ? I've tried this to test the change in bad input filtering :
diff --git a/tests/alarms.rs b/tests/alarms.rs
index 6ebc786..acff9b3 100644
--- a/tests/alarms.rs
+++ b/tests/alarms.rs
@@ -80,6 +80,17 @@ mod alarm1 {
         },
         A1M::AllMatch
     );
+    set_invalid_alarm_test!(
+        day_invalid_min_1,
+        set_alarm1_day,
+        DayAlarm1 {
+            day: 1,
+            hour: Hours::H24(1),
+            minute: 60,
+            second: 1
+        },
+        A1M::SecondsMatch
+    );
     set_invalid_alarm_test!(
         day_invalid_h,
         set_alarm1_day,

But then I get
...
---- alarm1::day_invalid_min_1::cannot_set_invalid_ds3234 stdout ----
thread 'alarm1::day_invalid_min_1::cannot_set_invalid_ds3234' panicked at 'no expectation for spi::write call
...

I see. The tests use macros heavily due to the amount of duplicated code otherwise, but their structure can seem complicated.
The reason for that error is that with your changes when the alarm is configured with SecondsMatch the invalid minute: 60 is ignored and thus the provided values are valid. In this case, it proceeds with setting the values in the device, and thus needs an expectation for the bus transactions.
An example invalid input test would be:
set_invalid_alarm_test!(
        day_invalid_second,
        set_alarm1_day,
        DayAlarm1 {
            day: 1,
            hour: Hours::H24(1),
            minute: 59,
            second: 60
        },
        A1M::SecondsMatch
    );

A valid input test case would be something like this:
set_alarm_test!(
        match_s,
        set_alarm1_day,
        DayAlarm1 {
            day: 1,
            hour: Hours::H24(2),
            minute: 60,
            second: 4
        },
        A1M::SecondsMatch,
        ALARM1_SECONDS,
        [4, AM | 0, AM | 2, AM | 1]
    );

I just noticed that code that corrects previously invalid input values needs to be added. Otherwise necessary bits may be overwritten with wrong values.
I would say a sensible approach would be to set the values to the minimum valid (only) when an invalid value is received.
For the test example above the minute value (60) would need to be corrected to 0.
This needs to be documented in all the methods as well.
I think the code will get a bit messy with all these corrections depending on the input matching strategies. If you do not really need this and just became aware of it when writing day: 0 in the new methods, maybe it is easier to just write day: 1 there.

I've tried to see if I could come up with something that fixes your previous remarks (modifying invalid but ignored value to correct values) and have some tests. Please tell me if you find it too messy. If that's the case, then I'll do what you mentioned (remove the finer filtering).
As for the tests of the new functions, that's still not good enough.
The macros are expecting 2 arguments functions, but the new ones only take 1, so I've duplicated the macro code as a first step, and it nearly works (I still get an error when testing the Alarm2 _hm function). I'll iterate again later.

The correction code seems fine. The tests look good so far, although I would rename them to try to make them a bit more descriptive (e.g. I did not understand what the _bis suffix is, probably not meant as latin for second, which is what first came to mind).
On other driver crates I have defined more general macros that accept a variable number of arguments but it will be some work to adapt all tests to the new signature since the parameters must go at the end.

Yes, sorry, should have made the name better, I'm mostly learning here, so there's a lot of trial and error. I could see how to adapt the macros also if you think it's a good idea and if you don't mind having to give your feedback regularly.

Sure, no problem. Glad to help onboarding rustaceans :)

Ok, it was easier than I expected, thanks for the pointer. I still have to change some names and add some tests for valid inputs

Sounds good. You can also mark this PR as a draft while it is not ready.

Sounds good. You can also mark this PR as a draft while it is not ready.

I think only reviewers can change this state, but you're right, it should be made draft :)

True, thanks. I marked it as a draft now.

While trying to have all ifs covered by tests, I've realized that there's an asymmetry in inputs, as hours are not handled like the others fields. But having the same logic of «incorrect but ignored input is set to sensible value» is not straightforward for hour. Is it a problem ? Apart from that, I think it should be ok... Hope so, at least.

Hope to have all remarks handled. Feel free to request for more changes if needed !

Everything is great. Thank you for your work! I will comment here when I release this.

For the record, I have published this in version 0.3.1.

Thanks for taking the time to review my changes, and great news for the new release !


.env.dist does not contain SENTRY_ENV

With v4.3.2 installed, I'm getting the following warning:
PHP message: PHP Warning:  constant(): Couldn't find constant Mollie\Config\Config::SENTRY_ENV in /var/www/html/modules/mollie/src/Config/Env.php on line 32

.env.dist indeed only contains GITHUB='MARKETPLACE', which I assume was accidentally typed instead of SENTRY_ENV='MARKETPLACE'.

Hello @WBNet-Wout thank you for your insight, sorry for a delay,
Strange, it might be the mistype problem. I have to check with dev team and get back to you.
Best Regards
Invertus Support Team

Hello @WBNet-Wout
We asume that it should be SENTRY_ENV='GITHUB' if module is from github. And SENTRY_ENV='MARKETPLACE' if module is from marketplace.
Upladed the updated Mollie.zip here, please try it out, and give us feedback: https://drive.google.com/file/d/1vyNZ2wfIr4-B7mL5Fi4dBnDdyYPeTA_E/view?usp=sharing
Best Regards
Invertus Support Team

That updated mollie.zip indeed does not have the warning.


Don't update games data file if nothing changed

Currently it seems that the plugin updates data file even if the data is not different data than before, I think it could be better if it only did that when the new data is different since it causing a lot of writes that I think are unnecessary

Original file:

New file (Has same data):

I have done some tests and have not been able to reproduce this problem.


Allow for missing emblemBackgroundPath

Long story short
When attempting to call client.fetch_profile, I'd receive a KeyError: 'emblemBackgroundPath' exception. It looks like one of my characters just doesn't have an emblem background set, or something.
Checks

[ ] I have run nox tests and all pipelines have passed. See below.
[x] I have wriiten tests according to the code i added, modified or deleted.

Nox seems to be returning test failures that aren't relevant and making various changes unrelated to the issue. The same changes and failures happen on master without modifications.
Abbreviated test output was this:
nox > Session pytest was successful.
nox > Ran multiple sessions:
nox > * client_test: failed
nox > * format: success
nox > * spell: success
nox > * lint: success
nox > * gen_stubs: success
nox > * type_check: failed
nox > * pdoc: success
nox > * pytest: success

Let me know if this is sufficient or I should be digging in more. I set up the dev environment with poetry install.
Closes: https://github.com/nxtlo/aiobungie/issues/302
Related issues
n/a

Also just to mention, most of what this PR fixes is being pushed into #300, But #300 will take sometime to merge into master. As a temporary solution check what i suggested so we can merge it into master and then i'll rebase with #300

Sounds great @nxtlo , I should be able to update tomorrow morning. Thank you!
Also some more info, it looks like the emblem issue is because the Bungie API "isn't returning any information" about the currently set emblem, presumably because it's one of the new ones from this season? DIM, for example, is showing this:

Maybe that doesn't change the approach, but mentioning it in case it does.

Actually will wait to update until after the season roll-over maintenance.

@nxtlo Fixed the type annotation, too, thanks. Let me know how it looks now.

@spacez320 You can just commit the changes i made directly from here :)

Sorry @nxtlo , but I don't get what you mean. I rebased with upstream master, if that's what you meant, but let me know what I'm missing.

@spacez320 My bad i didn't submit the reviews before, You should be able to see it now.

This all makes sense, changes applied. Thanks for the guidance @nxtlo . Do we also need to do something with emblem_hash? If not, I think it's g2g.

This is the emblem details:
emblem=Image(url=https://www.bungie.net//common/destiny2_content/icons/c96a0a1285594660d72265b502940e87.jpg)

emblem_icon=Image(url=https://www.bungie.net//common/destiny2_content/icons/292c3b0fe3ce6a4e8d25a7af11d53abc.jpg)

emblem_hash=54004494

Unfortunately, it looks like our test case disappeared because the API is now returning all this information correctly. Tried switching to a newer emblem that came out with the season and it's fine too, so not sure we have another instance to test against. :(
I will say that once I applied the initial change to allow the None-able emblem field, fetch_profile and fetch_character worked fine afterwards, although I'm sorry I don't remember what it was returning for emblem_icon or emblem_hash in those tests.
Possible that this was just a super rare bug in the API?

Thanks for letting me contribute!


Make bucket field mandatory in new data connection for deploy model

Feature description
A requirement in model serving is that every data connection needs to have a bucket name.
We need to make that field mandatory when creating a new data connection in the Deploy model modal.
Mockups
(Is using the old field convention)
https://www.sketch.com/s/113593f8-5970-49d6-a352-709b07639127/a/P1oq14j#Comment

Removing this from this sprint, we might want to include it in one of the PRs but so far it can wait

I already implemented it this morning, going to push up a PR now.

Perfect, I'm gonna add it into the Sprint, we can get this asap.


I want to dark mode toggle button .

I want to add dark mode toggle button by clicking it we can switch the theme of webpage.

Please assign it to me
@Arun9739

@Aarav238 Go ahead
Star the repo 🌟 to showcase your support.

I want to work on this feature. Please assign it to me.

@Aarav238 Plz finish your task early.

ok thank you

@Arun9739 can i work on this feature ?

@Shreyas-R-7925 Thank you for your interest.
Plz look for other issues or create new issue.

@Aarav238 Due to inactivity this issue will be unassigned
Anyone can take up.

@Shreyas-R-7925 Do you want to work on this?

@Shreyas-R-7925 Do you want to work on this?

I'd like to work on this issue #205, so if you could possibly assign me this issue.

@Shreyas-R-7925 Go ahead
Star the repo 🌟 to show your support

@Shreyas-R-7925 PLz finish your task early