#896 Android only changes for thaliMobileNativeWrapper

Closes #896

This change is

PR is added to the queue for testing as 2. task. (41cde1a)

Hi @chapko, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

Test (Success) 87133026 build is completed (41cde1a)
See https://github.com/ThaliTester/TestResults/tree/8713302641cde1a__896_Android_only_changes_for_thaliMobileNativeWrapper_chapko/ for the logs

Test<PHONE_NUMBER>cde1a(41cde1a) has failed
See https://github.com/ThaliTester/TestResults/tree/8713302641cde1a__896_Android_only_changes_for_thaliMobileNativeWrapper_chapko/ for the fail logs

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Please switch this to the iOS branch, fix any merge conflicts, make sure it is passing reasonably locally and then submit.

PR is added to the queue for testing as 2. task. (9e2872c)

Test (Fail) 87133026 build is completed (9e2872c)
See https://github.com/ThaliTester/TestResults/tree/871330269e2872c__896_Android_only_changes_for_thaliMobileNativeWrapper_chapko/ for the logs

PR is added to the queue for testing as 1. task. (3ce6b97)

Test (Fail) 87133026 build is completed (3ce6b97)
See https://github.com/ThaliTester/TestResults/tree/871330263ce6b97__896_Android_only_changes_for_thaliMobileNativeWrapper_chapko/ for the logs


allow optional name for deployment

Important Note:
It is recommended NOT to merge pull requests on weekends.

Can one of the admins verify this patch?


Replacing background music (lofi1.mp3) results in error

It would be better if it picked random music from the sounds folder instead of choosing just lofi1.mp3 every time
Deleted it and tried to replace it with other music, then waited like 30 minutes for my video to finish, only to have it crash at the very end.

For now, it will always try to open resources/sounds/lofi1.mp3, so it should work if you correctly name your new music file lofi1.mp3 and if it is longer than the video. I agree it would be better to pick a random file from resources/sounds/. I'll keep this issue open as well until I fix it.
Also, I know I'm not handling errors very well right now and Redditube can crash pretty easily, which is pretty annoying after waiting for minutes/hours.


Investigate free variant of Notion

Promising:
Answer_1.txt
Answer.txt

clickup.com seems to be the only good option. Some reasons why:

Pricing. Free tier seems enough.
Discord integration
Github Integration


Fix treatment of block tail for streaming inference

Codecov Report

Merging #304 (cd42477) into master (61ba30c) will increase coverage by 0.01%.
The diff coverage is 68.75%.

:exclamation: Current head cd42477 differs from pull request most recent head f1f6ecb. Consider uploading reports for the commit f1f6ecb to get more accurate results

@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
+ Coverage   68.24%   68.26%   +0.01%
==========================================
  Files          96       96
  Lines       10757    10748       -9
==========================================
- Hits         7341     7337       -4
+ Misses       3416     3411       -5

Impacted Files
Coverage Δ

neural_sp/models/seq2seq/speech2text.py
71.64% <61.53%> (+0.09%)
:arrow_up:

neural_sp/models/seq2seq/frontends/streaming.py
61.01% <100.00%> (+1.01%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61ba30c...f1f6ecb. Read the comment docs.


D1Database' object has no attribute 'rowcount'

Hi,
Thank you so much to create this. I have an issue. I just create new django project to test this library. as usual i did python manage.py migrate and then python manage.py createsuperuser .  Everything is okay but little bit slow. However, when I am going to login admin dashboard I am getting this error,
AttributeError: 'D1Database' object has no attribute 'rowcount' [25/May/2024 00:30:50] "POST /admin/login/?next=/admin/ HTTP/1.1" 500 191037

Hey @aliahadmd this issue is fixed in version 0.0.6, can you try updating to see if it solved?
Yeah everything is quite slow, i'm still looking into ways to speed up the queries, but since every query is executed in individual http requests, a lot of time is lost in handshakes and connecting to the server


Performance fixes

This PR is the sister PR of https://github.com/ruby-rdf/json-ld/pull/41 , where I tried to optimize the object allocation and runtime performance of the JSON::LD::API#frame method using stackprof.
Each commit should be easy to understand and should not break the bundle exec rake spec from this project.
I am interested in your code review @gkellogg before any merge.

Coverage increased (+0.01%) to 91.501% when pulling 2cd52f76e07a376572a8ee3bf98b32e570b41203 on PerfectMemory:performance-fixes into cf27f0cdadf9b2692c61e5d23b07e739fba8cb56 on ruby-rdf:develop.

Coverage increased (+0.01%) to 91.501% when pulling 2cd52f76e07a376572a8ee3bf98b32e570b41203 on PerfectMemory:performance-fixes into cf27f0cdadf9b2692c61e5d23b07e739fba8cb56 on ruby-rdf:develop.

Good sleuthing! If you have not already done so, please send a public domain dedication covering all libraries you may contribute to. Also, consider adding yourself to the CONTRIBUTORS.

@gkellogg I just sent the public domain dedication to the public-rdf-ruby mailing-list.

@jperville didn't show up yet, but I presume it will. Thanks!

Hello @gkellogg , could you cut a new release of rdf gem? Thank you very much.

Released as 2.2.10.


Problem of  running results

Hello, thank you for your work，This project looks very good. I installed the total project on ubuntu . run classifier_fcnn.py with your model file . The results did not meet expectations.What's wrong？ Can you help me ? Looking forward to your reply .thanx .The following are the images .the first is input image .The last run with --enableCRF

)

Hi can you try running them with through the docker image ?


THRIFT-5208: fix OCaml codegen and add unit tests

My previous PR #2652 actually inadvertently broke the OCaml code generation of class names. This is a follow-up to fix both that as well as the actual issue of the exception constructor names, as well as adding actual unit tests for the OCaml codegen.

E.g. a failing test output looks like this:
$ rm -rf gen-ocaml; cmake --build . && ctest --output-on-failure
[ 27%] Built target parse
[ 77%] Built target thrift_compiler
[ 83%] Building CXX object CMakeFiles/thrift_compiler_tests.dir/ocaml/snapshot_typedefs.cc.o
[ 88%] Building CXX object CMakeFiles/thrift_compiler_tests.dir/ocaml/t_ocaml_generator_tests.cc.o
[ 94%] Linking CXX executable bin/thrift_compiler_tests
[100%] Built target thrift_compiler_tests
Test project /Users/yawar/src/github.com/yawaramin/thrift/compiler/cpp/tests
    Start 1: ThriftTests
1/1 Test #1: ThriftTests ......................***Failed    0.18 sec

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
thrift_compiler_tests is a Catch v1.9.4 host application.
Run with -? for options

-------------------------------------------------------------------------------
t_ocaml_generator - typedefs
-------------------------------------------------------------------------------
/Users/yawar/src/github.com/yawaramin/thrift/compiler/cpp/tests/ocaml/t_ocaml_generator_tests.cc:63
...............................................................................

/Users/yawar/src/github.com/yawaramin/thrift/compiler/cpp/tests/ocaml/t_ocaml_generator_tests.cc:75: FAILED:
  REQUIRE( snapshot == gen.types() )
with expansion:
  "
  open Thrift
  type decimal = int

  "
  ==
  "
  open Thrift
  type decimal = string

  "

===============================================================================
test cases: 2 | 1 passed | 1 failed
assertions: 3 | 2 passed | 1 failed

0% tests passed, 1 tests failed out of 1

Total Test time (real) =   0.19 sec

The following tests FAILED:
	  1 - ThriftTests (Failed)
Errors while running CTest

Every time I look into this the code changes grow by 500%, What is all that "compiler/tests" stuff about? Why do we need that?

merged in b17672a

Thanks for merging. After asking for advice on how to go about writing tests in the original PR, I did not receive a response so decided to try to come up with something myself.
Most of the line count you're seeing here is from capturing snapshots of the generated OCaml  code under various scenarios. I tried to keep the scenarios as simple as possible however the outputs of the service client implementations are verbose by their very nature.
These snapshots will in the future help to prevent regressions if someone makes a mistaken change in the OCaml generator as I had done previously.


access_token vs id_token: 401 received on ressource server with access_token value

Hello,
I use angular-oauth2-oidc (v10.0.3) and angular-oauth2-oidc-jwks (v9.0.0) in implicit flow.
I added OAuthModule.forRoot({ resourceServer: {     allowedUrls: ['myAPI_URI'],     sendAccessToken: true }
In debug, I confirm that the DefaultOAuthInterceptor adds a token in the "Authorization" attribute of the request header.
However, my ressource API (SpringBoot2 & SpringSecurity) response is 401.
I realized that the token (variable name in the code) which is added in the header is the access_token value and not the id_token value (if I look at what's in the storage). Is it normal?
My ressource API needs the full information with roles, etc for SpringSecurity checks. Consequently, it needs the value of what is called "id_token" but what is sent by angular-oauth2-oidc is the "access_token" value.
Other information:
When I call my ressource API with the id_token value (angular-oauth2-oidc storage point of view) in a REST client, the request works.
Also: when I request a token with the REST client to the auth server, the response says "access_token" (at least that's the name of the attribute) but it contains some user info (roles, etc) if I decode it. (Should not be called id_token?)
What do you feel is wrong?
Thanks,
Silslt

I don't think anything is wrong. Normally your resource APIs are secured and should require an access_token. The resourceServer config allows you to automatically add sending of access tokens, as you found.
An id_token would be useful for authenticating a user, and if you want to pass it along from the SPA client to an API for some reason, I recommend doing so yourself by grabbing it from the library's service instance and putting it into a request to your server.
As far as I know, you typically do not send an id_token with every request to a resource server. Can you configure your backend to be different about this? If not, you need to skip using resourceServer, and make your own HttpInterceptor that adds the id_token to requests. Such a feature is not built into this library at the moment.

Thanks for your quick answer.
After sending my message, I also thought my solution is to write a HttpInterceptor.
Thanks.

Cheers! Good luck, and let us know if you need further support.

It works perfectly with a custom HttpInterceptor.
Thanks


Can't build on mingw

I'm getting this error when building on Windows (mingw):
... depend build/spiffs_check.d
... depend build/spiffs_cache.d
... depend build/spiffs_hydrogen.d
... depend build/spiffs_gc.d
... depend build/spiffs_nucleus.d
... depend build/main.d
... compile build/main.o
In file included from src/main.c:1:0:
./src/spiffs.h:183:9: error: field '_errno' declared as a function
   s32_t errno;
         ^

I created these patches - they fixed the problem
https://gist.github.com/kireevco/0183f3ca9df19ce7f9d7
There is an issue with errno.

this can also be fixed in spiffy:master by merging #8 (+size as inpuit param)


Use a builder object to inquire, validate, and register a custom toolchain

Previously, inquiring and validating a custom toolchain was coupled to registration, which made it difficult to simply look at the custom toolchain independent of registering it.
This change implements ToolchainBuilder, a builder object that finds, validates, and registers a custom toolchain. Each step can be performed independently, with the caveat that registration depends on validation which depends on finding the custom toolchain.
Use cases include:

Finding a custom toolchain,
Finding and validating a custom toolchain,
Finding, validating, and registering a custom toolchain

This change also cleans up some of the platform-specific symlink code by implementing a trait, SymlinkOrFallback, which different platforms can adopt.
This change does not add or remove any existing functionality (except for maybe introducing opportunities for non-Unix-like or Windows platforms to register a custom toolchain).
Discussion at #607

@mitsuhiko any movement here?

Will try to get to it next week.


S3 bucket is not reused with slim_handler: True

When Zappa is using the slim_handler, it does not reuse the temporary S3 bucket that it creates --- Even when zappa update command is used. This results  in the creation of many, many, many temporary buckets, until the quota is reached.
Context
This is similar to #1643, except that user is encountering problems with temporary buckets are not needed for the Zappa operation.
Expected Behavior
The created bucket should be reused. Right now, the name is not resused.
Actual Behavior
New buckets keep getting created.
Possible Fix
After a bucket is created, update that zappa_settings.json file to note the bucket name.
Your Environment

Zappa version used: 0.58.0
Operating System and Python version: MacOS

Hi @simsong, the new and official Zappa repo is Here
I think you're already on our Slack channel.

Yup. Can you migrate this issue?

Migrated to https://github.com/zappa/Zappa/issues/1333

Hi @simsong , you wanted to use ARM images for lambda deployments. I have made ARM docker images for lambdas, ping me on our official Zappa slack channel.

Thanks! I'm burried in something else right now.
The big thing I want, I think, is to figure out how to use 'layers'. I have gigabytes of data in models that don't need to be uploaded to S3 each time...


Added a test for factorial(0) to be equal to 1.

With regards to the following error:

@marksurnin as I know @QuincyLarson changes all expect()'s in challenges to assert()'s. Anyway this is an improvement of the challenge. Verified and merged!


Flickering when there are no suggestions or history present - searchview:4.0

Hi,
Kindly check this issue.
As you can see in the GIF image above when there are no suggestions or any history present animation of list is not happening smoothly or when I type any query and clear it I can see flickering/blinks.
Im currently on com.lapism:searchview:4.0 version and have implemented as given in samples, how can I fix this?

Probably you will have to change to last version here in README. And you will see :+1:

But latest version requires minSdkVersion version to be 21 while I need 16 in my project, is there any way to fix it in the version I am using ?
Thank you


Add 'dma-noncoherent' property as a standard property

Similar to the 'dma-coherent' property, some architectures may be coherent
by default with some devices being non-coherent. Add a property for this
case tool.
Signed-off-by: Heiko Stuebner<EMAIL_ADDRESS>

The dt-schema pull-request was merged some days ago, so I converted my mailing-list patch for the specification to a pull request as well, in the hope of it making things easier :-)


New version: ImageMagick.ImageMagick.Q8 version <IP_ADDRESS>

Created by 🥟 Dumplings in workflow run #7596.

Log
Updated: <IP_ADDRESS> → <IP_ADDRESS>
Submitting WinGet manifests
Creating manifests
Uploading manifests and making commits
The manifests for the last version <IP_ADDRESS> will be removed. Reason: This task is configured to remove the last version
Creating a pull request

Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

Executable C:\Program Files\ImageMagick-7.1.1-Q8\magick.exe returned exit code: 1

(Automated response - build 888.)


Feature Section Problem

In the feature section, hover effect on the nav bar results in a color hiding the nav-items' color.

navbar is different on all pages. this issue is already assigned?


Method to visualize tree of GO scripts that get executed

Reported by ansley b manke on 28 Feb 2013 22:32 UTC
Add a piece of automatic output from Ferret whenever it enters into or exits from a script.  Then the output from Ferret could easily be post-processed to see the scripts that are executed and who calls who.
Currently we can do this:

Turn on SET MODE VERIFY:always
Run the script, capturing all the output in a log file
Search for instances of "GO scriptname"

It'd be handy to see where each script returns to the calling script, and to clarify which GO commands are actually executed, e.g. the log output may contain these lines:
   IF ($ferret_annotations"0|*>1") THEN GO set_full_margins
    !-> IF 0 THEN GO set_full_margins

A simple search for "GO xxx" would return these two lines but Ferret did not execute the script "full_margins.jnl".
Entering scripts:

xeq_go.F at the point where the script file has been opened and the command stack is pointing to the script for input.

Exiting scripts:

xeq_exit.F if the script executes an exit or quit command (but not if it's exit/loop, or exit/cycle)

get_fer_command.F if the script simply ends

Note that the symbol LAST_GO_FILE, implemented in Ferret 6.2, is set each time a go script is initialized, so this can be queried to get the name of the script we're exiting.

Migrated-From: http://dunkel.pmel.noaa.gov/trac/ferret/ticket/2044

Comment by ansley.b.manke on 5 Mar 2014 18:47 UTC
Ferret now writes this when exiting a script,
! Exit from GO
to std_output, if MODE VERIFY is on, when exiting a script.
Then we'll put together something on the order of an awk script which will find these lines, plus the "go " lines and print them out with indent levels so that the nesting of calls is readily visible.

Comment by ansley.b.manke on 28 Oct 2014 16:11 UTC
this was done in v6.9


docs: adjust yaml example url

Coverage remained the same at 76.348% when pulling 54dd71844de6c0e4f5da2100cf5bec289e7d53e3 on yang-yinbo:main into 6c7423551c5e78e72d8b0533f0c7bac018b3b71f on emqx:main.


Fix #1558: allow insertion of JSON null values via REST API

What this PR does:
Allows use of null values with JSON payload when inserting rows using REST API.
Also improves testing, including null inserting case (for UUIDs): no tests covered this case; and in general JSON-payload taking inserts were (and are) under tests compared to "stringified" payload.
Which issue(s) this PR fixes:
Fixes #1558
Checklist

[ ] Changes manually tested
[x] Automated Tests added/updated
[ ] Documentation added/updated

@ivansenic Aside from comments for changes which make sense, are there specific places where changes do not make sense? This test class is way too big and existing code confusing in place.
Some changes to tests are not strictly minimal: I think existing tests leave out validation of state so I sometimes add more explicit verification.

@ivansenic Aside from comments for changes which make sense, are there specific places where changes do not make sense? This test class is way too big and existing code confusing in place.
Some changes to tests are not strictly minimal: I think existing tests leave out validation of state so I sometimes add more explicit verification.

@tatu-at-datastax Yea I meant existing code, not your updates..

Ah ok :)
Just asked since I don't feel my changes were super clear either. But they need to work with existing code so trying to limit changes.


Fix combiner and add tests

Fixes this unpleasantness:
julia> using ITensors

julia> i = Index(2, "i"); j = Index(3, "j"); k = Index(4, "k"); a = Index(5, "a");

julia> A = randomITensor(i, j, k, a);

julia> cmb, ci = combiner(i, j, k, tags="CMB");

julia> Ac = A*cmb;

julia> cmb*Ac == Ac*cmb
false

and adds tests to keep it from happening again. The combiner tests pass, other tests are broken on master, at least on rusty...

It looks like some of the tests are using the function isActive, but it was renamed to isactive.

Also isFermionic -> isfermionic and makeTagType("MySite") -> TagType"MySite". Not sure how those passed before.

test_phys_site_types.jl: Error During Test at /mnt/home/khyatt/.julia/dev/ITensors/test/runtests.jl:4
  Got exception outside of a @test
  LoadError: LoadError: UndefVarError: @TagType_str not defined
  Stacktrace:
   [1] top-level scope
   [2] include at ./boot.jl:328 [inlined]
   [3] include_relative(::Module, ::String) at ./loading.jl:1105
   [4] include(::Module, ::String) at ./Base.jl:31
   [5] include(::String) at ./client.jl:432
   [6] top-level scope at /mnt/home/khyatt/.julia/dev/ITensors/test/runtests.jl:28
   [7] top-level scope at /mnt/home/khyatt/software/julia/usr/share/julia/stdlib/v1.3/Test/src/Test.jl:1180
   [8] top-level scope at /mnt/home/khyatt/.julia/dev/ITensors/test/runtests.jl:4
   [9] top-level scope at /mnt/home/khyatt/software/julia/usr/share/julia/stdlib/v1.3/Test/src/Test.jl:1107
   [10] top-level scope at /mnt/home/khyatt/.julia/dev/ITensors/test/runtests.jl:4
   [11] include at ./boot.jl:328 [inlined]
   [12] include_relative(::Module, ::String) at ./loading.jl:1105
   [13] include(::Module, ::String) at ./Base.jl:31
   [14] include(::String) at ./client.jl:432
   [15] top-level scope at none:6
   [16] eval(::Module, ::Any) at ./boot.jl:330
   [17] exec_options(::Base.JLOptions) at ./client.jl:271
   [18] _start() at ./client.jl:468
  in expression starting at /mnt/home/khyatt/.julia/dev/ITensors/test/test_phys_site_types.jl:160
  in expression starting at /mnt/home/khyatt/.julia/dev/ITensors/test/test_phys_site_types.jl:160

Hmm, TagType_str is defined here: https://github.com/ITensor/ITensors.jl/blob/25175fd808611282c68dad040207adf2fcf93545/src/physics/tag_types.jl#L20

It's not exported, that was the problem. I added some more tests for this failing SVD issue which is grinding my gears 😡

OK, tests pass, including SVD, but this is probably not what @mtfishman wants this code to look like in the end... Feel free to push better versions to this branch, as long as tests pass

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@aa15127). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #137   +/-   ##
=========================================
  Coverage          ?   87.52%
=========================================
  Files             ?       31
  Lines             ?     2935
  Branches          ?        0
=========================================
  Hits              ?     2569
  Misses            ?      366
  Partials          ?        0

Impacted Files
Coverage Δ

src/tensor/combiner.jl
91.66% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa15127...c0c8dfe. Read the comment docs.

Looks good Katie - thanks for these fixes.
Interesting about using combiners for index replacement, but actually I would argue that creating a combiner with just one index should be an error (raise an exception). This is because it's out of the scope of what combiners are for and also one can use delta tensors to replace indices.

Actually for quantum numbers, the single index combiner is quite non-trivial and very useful. In the C++ version, a single index combiner makes a new index with the blocks merged, which Peter has used to speed up his VUMPS code (since the prescribed way of increasing the bond dimension in VUMPS can introduce many small QN blocks). Perhaps this should be a different functionality, but apparently it was already working once the general combiner function was working.

Are we ok to merge? Feel free to squash this also

I am fine with it. I haven't looked at it very closely and will probably go over it later, but I think we just want this code working right now. The only thing is that I would prefer if the IndexSet(::Vector) constructor was removed (since I don't think we want to encourage using that, since it is not type stable). Beyond that, go ahead and merge when you think it is ready.

Great I'll remove that and then leave it be. I was just trying to use tuples all the way through, but unfortunately we're still missing some tools to make that clean (without essentially writing those tools into the combiner code itself). But I know you are planning to work on that very thing down the line so this code will get nicer over time.

Thanks to you both for the improvements on this!


AutomationTool exiting with ExitCode=6

Hi, I'm having an issue with packaging unreal engine 5 project any solutions please ?
UATHelper: Packaging (Windows): Running: C:\Program Files\Epic Games\UE_5.3\Engine\Binaries\ThirdParty\DotNet\6.0.302\windows\dotnet.exe "C:\Program Files\Epic Games\UE_5.3\Engine\Binaries\DotNET\UnrealBuildTool\UnrealBuildTool.dll" HorrorProject Win64 Development -Project="C:\Users\ahmad\Documents\Unreal Projects\HorrorProject\HorrorProject.uproject" -Manifest="C:\Users\ahmad\Documents\Unreal Projects\HorrorProject\Intermediate\Build\Manifest.xml"  -remoteini="C:\Users\ahmad\Documents\Unreal Projects\HorrorProject"  -skipdeploy  -log="C:\Users\ahmad\AppData\Roaming\Unreal Engine\AutomationToo
l\Logs\C+Program+Files+Epic+Games+UE_5.3\UBT-HorrorProject-Win64-Development.txt"
UATHelper: Packaging (Windows): Log file: C:\Users\ahmad\AppData\Roaming\Unreal Engine\AutomationTool\Logs\C+Program+Files+Epic+Games+UE_5.3\UBT-HorrorProject-Win64-Development.txt
UATHelper: Packaging (Windows): Creating makefile for HorrorProject (no existing makefile)
UATHelper: Packaging (Windows): Total execution time: 0.87 seconds
UATHelper: Packaging (Windows): Microsoft platform targets must be compiled with Visual Studio 2022 17.4 (MSVC 14.34.x) or later for the installed engine. Please update Visual Studio 2022 and ensure no configuration is forcing WindowsTargetRules.Compiler to VisualStudio2019. The current compiler version was detected as: 14.29.30154
UATHelper: Packaging (Windows): Took 1.23s to run dotnet.exe, ExitCode=6
UATHelper: Packaging (Windows): UnrealBuildTool failed. See log for more details. (C:\Users\pc\AppData\Roaming\Unreal Engine\AutomationTool\Logs\C+Program+Files+Epic+Games+UE_5.3\UBT-HorrorProject-Win64-Development.txt)
UATHelper: Packaging (Windows): AutomationTool executed for 0h 0m 5s
UATHelper: Packaging (Windows): AutomationTool exiting with ExitCode=6 (6)
UATHelper: Packaging (Windows): BUILD FAILED
PackagingResults: Error: Unknown Error

Microsoft platform targets must be compiled with Visual Studio 2022 17.4 (MSVC 14.34.x) or later for the installed engine. Please update Visual Studio 2022 and ensure no configuration is forcing WindowsTargetRules.Compiler to VisualStudio2019. The current compiler version was detected as: 14.29.30154 points to you needing VS2022 compile


Throw Java exception instead of crash when std:bad_malloc is thrown in native code

We observed this crash in our app:
signal 6 (SIGABRT), code -6 (SI_TKILL), fault addr --------
Abort message: '/usr/local/google/buildbot/src/android/ndk-release-r20/external/libcxx/../../external/libcxxabi/src/abort_message.cpp:73: abort_message: assertion "terminating with uncaught exception of type std::bad_alloc: std::bad_alloc" failed'
    r0  00000000  r1  0000204b  r2  00000006  r3  00000008
    r4  0000204b  r5  0000204b  r6  beaab25c  r7  0000010c
    r8  82000d65  r9  0000013e  r10 b06ead8c  r11 beaab824
    ip  00000041  sp  beaab248  lr  b066704d  pc  b065ed76
backtrace:
    #00 pc 0001cd76  /system/lib/libc.so (abort+58)
    #01 pc 0001cfdf  /system/lib/libc.so (__assert2+22)
    #02 pc 00032f99  /data/app/package-name/lib/arm/libapng-drawable.so
    #03 pc 00033099  /data/app/package-name/lib/arm/libapng-drawable.so
    #04 pc 00031639  /data/app/package-name/lib/arm/libapng-drawable.so
    #05 pc 00030fe7  /data/app/package-name/lib/arm/libapng-drawable.so
    #06 pc 00030faf  /data/app/package-name/lib/arm/libapng-drawable.so (__cxa_throw+74)
    #07 pc 0002f175  /data/app/package-name/lib/arm/libapng-drawable.so (operator new(unsigned int)+56)
    #08 pc 0001984d  /data/app/package-name/lib/arm/libapng-drawable.so
    #09 pc 000197fd  /data/app/package-name/lib/arm/libapng-drawable.so (apng_drawable::ApngFrame::ApngFrame(unsigned int, unsigned int)+32)
    #10 pc 0001802d  /data/app/package-name/lib/arm/libapng-drawable.so (apng_drawable::ApngDecoder::decode(std::__ndk1::unique_ptr<apng_drawable::StreamSource, std::__ndk1::default_delete<apng_drawable::StreamSource>>, int&)+824)
    #11 pc 00018735  /data/app/package-name/lib/arm/libapng-drawable.so (Java_com_linecorp_apng_decoder_ApngDecoderJni_decode+64)
    #12 pc 0008479b  /data/app/package-name/oat/arm/base.odex (offset 0x84000) (com.linecorp.apng.decoder.ApngDecoderJni.decode+130)
    ...

As it is thrown from native code we can't do anything to prevent it from crashing our app. It is nice to throw a Java exception such as OutOfMemoryException to enable the user to handle it (java.lang.OutOfMemoryError is not appropriate as no more memory could be made available by the garbage collector is not necessarily true).
Edit: There is a ErrorCode.ERR_OUT_OF_MEMORY which seems appropriate but is not thrown in this case.

It should be fixed with #91. Please re-open this issue if you still meet the same error.


add managed cert API in 2022-11-01-preview

ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo.  If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[x] Other, please clarify: Adding a new sub resource type

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month. Answer: November 2022
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month. Answer: November 2022
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[ ] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

[x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.

Suppressing the model validation errors, which need to be fixed in the future


quick and dirty prototype to allow users to define charset for strings

Coverage decreased (-0.07%) to 92.936% when pulling<PHONE_NUMBER>c21e927b0bd6c7b57c1d7f5fb0add6 on PascalSchumacher:choose_charset into 41ba8f4cfb2e07b53f0038f0a12e8bdf3ec2131f on benas:master.

Coverage decreased (-0.05%) to 92.949% when pulling 62bf4e4f6953d1b0235c4e17e58370d4291f16a4 on PascalSchumacher:choose_charset into 41ba8f4cfb2e07b53f0038f0a12e8bdf3ec2131f on benas:master.

Coverage decreased (-0.05%) to 92.949% when pulling 62bf4e4f6953d1b0235c4e17e58370d4291f16a4 on PascalSchumacher:choose_charset into 41ba8f4cfb2e07b53f0038f0a12e8bdf3ec2131f on benas:master.

I always begin with the simplest solution that could possibly work :wink:
Your changes are fine, but they impact only arrays. String and Character fields will not use the specified charset. What if we add the charset as parameter in the constructor of StringRandomizer and CharacterRandomizer ?

Sure, but I'm not actually sure this is the best way to do it. Let's release 3.0 first and maybe add this feature later on, what do you think?

Yes, the problem is that the ArrayPopulator does not reuse existing randomizers. It should delegate value generation to registered randomizers by type. This way, if the user registers a CharacterRandomizer with a charset (and probably a seed) at construction time, both char arrays and char fields use the same randomizer. do you see the point?
I think if we:

make the ArrayPopulator delegate value generation to existing randomizers
and add Charset param to CharacterRandomizer and StringRandomizer

it would be fine for 3.0. This does not change the builder API, just a refactoring and new param in constructors.

Hi,
I've made the aforementioned refactoring. Now, the array populator uses registered randomizers (it gets them through the RandomizerProvider).
the only remaining thing is to replace my quick and dirty solution (with alphabet) with your elegant solution using a charset. The StringRandomizer should also be updated.
The user will be able to register a CharacterRandomizer with a charset at construction time and char arrays and fields will be randomized with characters from the specified charset.
Cheers
Mahmoud

Hi Benas,
thanks!
I reduced the pull request to a CharacterUtils class.

Coverage decreased (-0.8%) to 92.445% when pulling 52a8f99b8ddbcf01fa95bffd3f9ea8e43873c71f on PascalSchumacher:choose_charset into 90e081fbdb34babd0298afc99be6aa66984ab309 on benas:master.

I can also do the integration, but that will have to wait a few days.
So if you like to do it, feel free.
Cheers,
Pascal

Hi,
Thanks for the update! You've already done 80% of the work 😄.
No worries, I'll do the integration.
Cheers
Mahmoud


Make antrea-controller not tolerate Node unreachable

When a Node becomes unreachable, currently it takes 5m45s+ for Kubernetes to move antrea-controller Pod to another Node. The time spent in the process includes:

40s (default value of NodeMonitorGracePeriod) to mark a Node's Ready condition to Unknown
5s to taint the Node with node.kubernetes.io/unreachable:NoExecute
5m (default value of defaultUnreachableTolerationSeconds) to tolerate the taint

The 1st duration is kind of inevitable. The 2nd duration seems a bug in kube-controller-manager, which I have opened an issue kubernetes/kubernetes#120815 and may be fixed in a future release. The 3rd duration is because Kubernetes automatically adds a default toleration for node.kubernetes.io/unreachable:NoExecute with tolerationSeconds of 300s if the Pod doesn't have one.
This commit adds a toleration with tolerationSeconds of 0s for node.kubernetes.io/unreachable:NoExecute explicitly, which reduces the failover time by 5m.

/test-all

Fixed helm README

/test-all


optimize.bisect does not acheive desired tolerance

The function optimize.bisect has a parameter for absolute tolerance xtol and a parameter for relative tolerance rtol. I would expect the computed root res and the exact root r to satisfy abs(res - r) <= xtol + rtol*res, but this is not the case:
from scipy.optimize import bisect
from numpy import finfo

root = 0.1
def f(x):
    return x - root

xtol = 1e-12
rtol = 2*finfo(float).eps
res = bisect(f, -1e8, 1e8, xtol=xtol, rtol=rtol)
tol = xtol + rtol*res

print abs(res - root) <= tol

returns False. If in the above bisect is replaced by brentq, brenth, or ridder we get True. The issue is that the tolerance is set to be tol = xtol + rtol*(fabs(xa) + fabs(xb)) for xa, xb the endpoints of the initial interval and then never changed throughout the routine, where it should be updated at each step with the current interval (as is done in the other methods). This means that if the endpoints of the initial interval are much larger than the root we lose accuracy.
Will submit a pull request soon with a proposed fix.

Why closing this?

I think the origin of the tolerance currently used in bisect is Press's "Numerical Recipies". The tolerance I was proposing is the tolerance used by Brent in his original paper on Brent's method (and more in the style of functions like numpy.allclose). It's worth noting that "Numerical Recipies" sticks with Brent's original method of defining the tolerance in their algorithm.
The point of all that was that it seems both methods of defining the tolerance are used. (Maybe worth noting that all of the functions brentq, brenth, bisect, and ridder could equally well be coded to use either one.) So it's not really fair to call this an issue, though admittedly I have a preference for Brent's version. It would probably be nice to document within brentq, brenth, bisect, and ridder what method is being used to compute the tolerance (IIRC they currently all say the same thing currently), but that's a different issue from what I was mentioning here.

And here I was hoping for a fix ;) I think difference may have come about because bisect was already a python routine before the others were added. It was maybe fourteen years ago, so my memory is a bit dim. Anyway, reopening this.

Ah, then I should probably reopen my pull request.


build is broken on Fedora rawhide (gcc-8.1)

[ 49%] Building CXX object dbms/CMakeFiles/clickhouse_common_io.dir/src/IO/ReadBufferAIO.cpp.o
In file included from /usr/include/asm/signal.h:7,
                 from /usr/include/linux/signal.h:5,
                 from /usr/include/linux/aio_abi.h:32,
                 from /home/ilia/clickhouse/dbms/src/Common/AIO.h:15,
                 from /home/ilia/clickhouse/dbms/src/IO/ReadBufferAIO.h:9,
                 from /home/ilia/clickhouse/dbms/src/IO/ReadBufferAIO.cpp:3:
/usr/include/linux/time.h:10:8: error: redefinition of ‘struct timespec’
 struct timespec {
        ^~~~~~~~
In file included from /usr/include/sched.h:32,
                 from /usr/include/pthread.h:23,
                 from /usr/include/c++/8/x86_64-redhat-linux/bits/gthr-default.h:35,
                 from /usr/include/c++/8/x86_64-redhat-linux/bits/gthr.h:148,
                 from /usr/include/c++/8/ext/atomicity.h:35,
                 from /usr/include/c++/8/bits/basic_string.h:39,
                 from /usr/include/c++/8/string:52,
                 from /home/ilia/clickhouse/dbms/src/IO/ReadBufferFromFileBase.h:3,
                 from /home/ilia/clickhouse/dbms/src/IO/ReadBufferAIO.h:5,
                 from /home/ilia/clickhouse/dbms/src/IO/ReadBufferAIO.cpp:3:
/usr/include/bits/types/struct_timespec.h:8:8: note: previous definition of ‘struct timespec’
 struct timespec
        ^~~~~~~~
In file included from /usr/include/asm/signal.h:7,
                 from /usr/include/linux/signal.h:5,
                 from /usr/include/linux/aio_abi.h:32,
                 from /home/ilia/clickhouse/dbms/src/Common/AIO.h:15,
                 from /home/ilia/clickhouse/dbms/src/IO/ReadBufferAIO.h:9,
                 from /home/ilia/clickhouse/dbms/src/IO/ReadBufferAIO.cpp:3:
/usr/include/linux/time.h:16:8: error: redefinition of ‘struct timeval’
 struct timeval {
        ^~~~~~~
In file included from /usr/include/bits/timex.h:22,
                 from /usr/include/bits/time.h:73,
                 from /usr/include/time.h:33,
                 from /usr/include/pthread.h:24,
                 from /usr/include/c++/8/x86_64-redhat-linux/bits/gthr-default.h:35,
                 from /usr/include/c++/8/x86_64-redhat-linux/bits/gthr.h:148,
                 from /usr/include/c++/8/ext/atomicity.h:35,
                 from /usr/include/c++/8/bits/basic_string.h:39,
                 from /usr/include/c++/8/string:52,
                 from /home/ilia/clickhouse/dbms/src/IO/ReadBufferFromFileBase.h:3,
                 from /home/ilia/clickhouse/dbms/src/IO/ReadBufferAIO.h:5,
                 from /home/ilia/clickhouse/dbms/src/IO/ReadBufferAIO.cpp:3:
/usr/include/bits/types/struct_timeval.h:8:8: note: previous definition of ‘struct timeval’
 struct timeval
        ^~~~~~~
In file included from /usr/include/asm/signal.h:7,
                 from /usr/include/linux/signal.h:5,
                 from /usr/include/linux/aio_abi.h:32,
                 from /home/ilia/clickhouse/dbms/src/Common/AIO.h:15,
                 from /home/ilia/clickhouse/dbms/src/IO/ReadBufferAIO.h:9,
                 from /home/ilia/clickhouse/dbms/src/IO/ReadBufferAIO.cpp:3:
/usr/include/linux/time.h:35:8: error: redefinition of ‘struct itimerspec’
 struct itimerspec {
        ^~~~~~~~~~
In file included from /usr/include/time.h:48,
                 from /usr/include/pthread.h:24,
                 from /usr/include/c++/8/x86_64-redhat-linux/bits/gthr-default.h:35,
                 from /usr/include/c++/8/x86_64-redhat-linux/bits/gthr.h:148,
                 from /usr/include/c++/8/ext/atomicity.h:35,
                 from /usr/include/c++/8/bits/basic_string.h:39,
                 from /usr/include/c++/8/string:52,
                 from /home/ilia/clickhouse/dbms/src/IO/ReadBufferFromFileBase.h:3,
                 from /home/ilia/clickhouse/dbms/src/IO/ReadBufferAIO.h:5,
                 from /home/ilia/clickhouse/dbms/src/IO/ReadBufferAIO.cpp:3:
/usr/include/bits/types/struct_itimerspec.h:8:8: note: previous definition of ‘struct itimerspec’
 struct itimerspec
        ^~~~~~~~~~
In file included from /usr/include/linux/signal.h:5,
                 from /usr/include/linux/aio_abi.h:32,
                 from /home/ilia/clickhouse/dbms/src/Common/AIO.h:15,
                 from /home/ilia/clickhouse/dbms/src/IO/ReadBufferAIO.h:9,
                 from /home/ilia/clickhouse/dbms/src/IO/ReadBufferAIO.cpp:3:
/usr/include/asm/signal.h:16:23: error: conflicting declaration ‘typedef long unsigned int sigset_t’
 typedef unsigned long sigset_t;
                       ^~~~~~~~
In file included from /usr/include/sys/select.h:33,
                 from /usr/include/sys/types.h:196,
                 from /usr/include/stdlib.h:394,
                 from /usr/include/c++/8/cstdlib:75,
                 from /usr/include/c++/8/ext/string_conversions.h:41,
                 from /usr/include/c++/8/bits/basic_string.h:6361,
                 from /usr/include/c++/8/string:52,
                 from /home/ilia/clickhouse/dbms/src/IO/ReadBufferFromFileBase.h:3,
                 from /home/ilia/clickhouse/dbms/src/IO/ReadBufferAIO.h:5,
                 from /home/ilia/clickhouse/dbms/src/IO/ReadBufferAIO.cpp:3:
/usr/include/bits/types/sigset_t.h:7:20: note: previous declaration as ‘typedef struct __sigset_t sigset_t’
 typedef __sigset_t sigset_t;
                    ^~~~~~~~
make[2]: *** [dbms/CMakeFiles/clickhouse_common_io.dir/build.make:687: dbms/CMakeFiles/clickhouse_common_io.dir/src/IO/ReadBufferAIO.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:5953: dbms/CMakeFiles/clickhouse_common_io.dir/all] Error 2
make: *** [Makefile:163: all] Error 2

Relevant details: https://stackoverflow.com/questions/20759750/resolving-redefinition-of-timespec-in-time-h

Successfully built in Docker.

Install packages:
git
cmake
ninja-build
gcc gcc-c++ libstdc++-static
openssl-devel
libicu-devel
readline-devel
unixODBC-devel libtool-ltdl-devel

cmake -D ENABLE_MYSQL=0 ..

it died with OOM on linking :)


Adding the shell of a UI change

Nothing much to see here yet...

Implemented in #11, closing unmerged.


Chinese Support

When I try to export my timeline written in Chinese, it does not show Chinese characters.

I found another way to solve this problem, we can print the page and set the page size to be large enough.

According to documentation, I found another way to solve this problem, rendering the page locally. We can print the page: print to PDF, set orientation to portrait, scale to the right size, no margins, include background image and the result is near perfect.


Fix bug poco found

When a DifficultyList had more than LINES_INITIAL_ALLOCATION lines we crashed
See the comment in the added line, I tested this on scwh with the "BUTTERFLY" simfile poco shared on discord and it didn't crash (It crashed before the change).
cc @poco0317

replaced by #1080