AttributeError: can't set attribute   ax._hold = self._tmp_hold

Bug report
Bug summary

Basemap cannot work when I update the matplotlib to the new version 3.0.1.
Code for reproduction

import matplotlib.pyplot as plt
import numpy as np
from mpl_toolkits.basemap import Basemap

outfile = r'E:\wrong.tif'

# read in data on lat/lon grid.
# data from https://github.com/matplotlib/basemap/tree/master/examples
hgt = np.loadtxt(r'E:\tmp\basemap\500hgtdata.gz')
lons = np.loadtxt(r'E:\tmp\basemap\500hgtlons.gz')
lats = np.loadtxt(r'E:\tmp\basemap\500hgtlats.gz')
lons, lats = np.meshgrid(lons, lats)

mnh = Basemap(lon_0=-105, boundinglat=20.,
              resolution='c', area_thresh=10000., projection='nplaea')
xnh, ynh = mnh(lons, lats)
CS = mnh.contour(xnh, ynh, hgt, 15, linewidths=0.5, colors='k')
CS = mnh.contourf(xnh, ynh, hgt, 15, cmap=plt.cm.Spectral)

mnh.drawcoastlines(linewidth=0.5)
delat = 30.
circles = np.arange(0., 90., delat).tolist() + \
          np.arange(-delat, -90, -delat).tolist()
mnh.drawparallels(circles, labels=[1, 0, 0, 0])
delon = 45.
meridians = np.arange(0, 360, delon)
mnh.drawmeridians(meridians, labels=[1, 0, 0, 1])
plt.title('NH 500 hPa Height (cm.Spectral)')

# colorbar on bottom.
mnh.colorbar(pad='5%')
plt.savefig(outfile, dpi=300, bbox_inches='tight')
plt.show()

Actual outcome

# If applicable, paste the console output here

Traceback (most recent call last):
  File "E:/MyWork/code/python/psta/tmp.py", line 20, in <module>
    CS = mnh.contour(xnh, ynh, hgt, 15, linewidths=0.5, colors='k')
  File "D:\Python36\lib\site-packages\mpl_toolkits\basemap\__init__.py", line 542, in with_transform
    return plotfunc(self,x,y,data,*args,**kwargs)
  File "D:\Python36\lib\site-packages\mpl_toolkits\basemap\__init__.py", line 3566, in contour
    self._restore_hold(ax)
  File "D:\Python36\lib\site-packages\mpl_toolkits\basemap\__init__.py", line 3229, in _restore_hold
    ax._hold = self._tmp_hold
AttributeError: can't set attribute

Expected outcome

Matplotlib version

Operating system: Windows 10 x64
Matplotlib version:  3.0.1
Matplotlib backend (print(matplotlib.get_backend())): module://backend_interagg
Python version: 3.6.6
Jupyter version (if applicable): None
basemap version: 1.2.0
PyCharm version: 2018.2.4

I install matplotlib and basemap from https://www.lfd.uci.edu/~gohlke/pythonlibs.

in mpl3.0.0 we removed the entire 'hold' mechanism, that broke cartopy because they were reading _hold, so for 3.0.1 we put in as a read-only attribute which breaks basemap who is trying to set it!  Does basemap work with 3.0.0 (as the variable name suggests the hold value is being stashed.

Basemap works for 3.0.0 and was prepared for the removal of the hold
mechanism by checking for the existence of the attribute
On Fri, Oct 26, 2018 at 9:06 AM Thomas A Caswell<EMAIL_ADDRESS>wrote:

in mpl3.0.0 we removed the entire 'hold' mechanism, that broke cartopy
because they were reading _hold, so for 3.0.1 we put in as a read-only
attribute which breaks basemap who is trying to set it! Does basemap work
with 3.0.0 (as the variable name suggests the hold value is being stashed.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/matplotlib/basemap/issues/435#issuecomment-433400925,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AARy-AKF-QX6cFjlctQstmLfwCy-Ki5Fks5uowjegaJpZM4X7mew
.

Note, this is why I pointed devs to basemap's PRs for this compatibility
shim in the hope that cartopy would adopt that approach. Instead, it was
deemed more important to change matplotlib rather than update cartopy in a
manner than is backwards compatible.
On Fri, Oct 26, 2018 at 9:48 AM Benjamin Root<EMAIL_ADDRESS>wrote:

Basemap works for 3.0.0 and was prepared for the removal of the hold
mechanism by checking for the existence of the attribute
On Fri, Oct 26, 2018 at 9:06 AM Thomas A Caswell<EMAIL_ADDRESS>wrote:

in mpl3.0.0 we removed the entire 'hold' mechanism, that broke cartopy
because they were reading _hold, so for 3.0.1 we put in as a read-only
attribute which breaks basemap who is trying to set it! Does basemap work
with 3.0.0 (as the variable name suggests the hold value is being stashed.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/matplotlib/basemap/issues/435#issuecomment-433400925,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AARy-AKF-QX6cFjlctQstmLfwCy-Ki5Fks5uowjegaJpZM4X7mew
.

I'm confused @WeatherGod : Does this mean we can only use Basemap with MPL 3.0.0 ?
This is breaking our unit testing.. We are in the middle of moving to Cartopy.

It means that matplotlib v3.0.1 is incompatible with basemap v1.1.x. You can either use a different version of matplotlib, or an earlier version of basemap.
basemap v1.1.x introduced a backwards-compatible shim to prepare for the upcoming changes in matplotlib v3.0.0, which worked, but cartopy wasn't ready for it. So, matplotlib v3.0.1 tried to fix things for cartopy, but ended up breaking things for basemap. matplotlib v3.0.2 will fix things for everybody while cartopy prepares to put out a new release that should work for all versions of matplotlib.

How do I do that?

I have 3.0.1 and basemap 1.1.0, the problem is still there

I have to say that python has a bad reputation with these ill-managed packages - that is probably the shortcomings of anaconda - R studio never had these issues.  I hope python will gradually die and give in to R

This is a issue tracker not for chat please stop posting here
Sent from my iPad

On Nov 25, 2018, at 8:32 PM, jamessong<EMAIL_ADDRESS>wrote:
I have to say that python has a bad reputation with these ill-managed packages - that is probably the shortcomings of anaconda - R studio never had these issues. I hope python will gradually die and give in to R
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

@jamessong, as I have noted, this issue is specifically the combination of matplotlib v3.0.1 and basemap v1.1.x. This is not a packaging issue. Matplotlib partly introduced a compatibility shim after a feature was removed in v3.0.0 that broke cartopy. That compatibility shim broke basemap. The matplotlib v3.0.2 fixes everything, which is why this issue is now closed.

Still same problem here, even after updating matplotlib to 3.0.2 or even when downgrading it to 3.0.0. Any ideas?
Basemap: 1.2.0

@jamessong: I have to say that python has a bad reputation with these ill-managed packages - that is probably the shortcomings of anaconda - R studio never had these issues. I hope python will gradually die and give in to R

@WeatherGod I am so very jealous of your unfathomable patience and composure. Even simply considering to answer to something like this is rather heroic.
@jamessong I would not wish being responsible for giving customer support to you on whatever matter on my worst enemies.
I am so very, very glad I don't understand your mindset.
Please just stop using Python if you think it's a bad thing and stop molesting people that make Python great, won't you?

Same here and after I updated matplotlib 3.0.1 to 3.0.2, the problem was solved.

this really fixed my problem!

@QuLogic just FYI this affects fedora 31, see skipped tests in http://tests.obspy.org/108832/


Variable interpolation

cfn-lint version: (0.29.2)
Description of issue.
Hi.  I'm trying to write a custom rule that will evaluate IAM policies.  I'm at a point where I'm trying to evaluate an IAM policy statement.  Something like:
{
    "Effect": "Allow",
    "Action": [
        "cloudformation:DescribeStacks"
    ],
    "Resource": [
        {
            "Fn::Sub": "${AWS::StackId}"
        }
    ]
}

The variables could be either CF template pseudo-variables, like ${AWS::Region},  intrinsic functions like {"Fn::Sub": "..."} { "Fn::GetAtt": "..."}, {"Fn::ImportValue": "..."}, {"Ref": "..."}, etc...
Is there anything in the cfn-lint library that will interpolate values like this and provide the result?

There's really no way for the Linter to evaluate resolved values for some of these without credentials and networking, but there are at least helpers to recognize that they are present:
https://github.com/aws-cloudformation/cfn-python-lint/blob/53a0983bf66970f8888569cdf0fbd1120727c665/src/cfnlint/helpers.py#L121-L130
https://github.com/aws-cloudformation/cfn-python-lint/blob/53a0983bf66970f8888569cdf0fbd1120727c665/src/cfnlint/helpers.py#L74-L76

Fair statement.  Thanks!


Display the peers on a worldmap

@veaceslavdoina Currently I am using https://country.is which is providing a free api.
But if we want something more reliable I could build a quick api based on https://ipinfo.io/products/free-ip-database and deploy it somewhere to make it accessible from the UI.

https://ipinfo.io/products/free-ip-database  would also provide a more granulated data so instead of having big dot per country we may have multiple dots per country.

Awesome. I work for IPinfo. Thank you for exploring IPinfo's free database. Ping me if you have any questions. Thanks!


Move all Karavi Observability dashboards to karavi-observability repository

Description
Move all Karavi Observability dashboards to karavi-observability repository.
Issues
List the issues impacted by this PR:

Issue ID

#1

Checklist:

[x] I have performed a self-review of my own changes.

@alikdell: Thank you for submitting your pull request!
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.

We want your feedback! If you have any questions or suggestions regarding our contributing process/workflow, please reach out to us at<EMAIL_ADDRESS>

@alikdell: Thank you for submitting your pull request!
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.

We want your feedback! If you have any questions or suggestions regarding our contributing process/workflow, please reach out to us at<EMAIL_ADDRESS>

We need to align the documentation here with the fact that we are creating feature branches and merging those directly to main. Also need to capture that we are creating a release branch when it's time to release "karavi observability". The branching strategy essentially aligns with the observability service repositories.

Fixed!

We need to align the documentation here with the fact that we are creating feature branches and merging those directly to main. Also need to capture that we are creating a release branch when it's time to release "karavi observability". The branching strategy essentially aligns with the observability service repositories.

Fixed!


Read fuzzy hash db on init

Instead of reading the fuzzy db on every invocation, read and store
the db contents during initialization and store the contents in memory.
The only significant behavior change here is that a change in db contents
now (obviously) requires a daemon restart, as no API is provided to
flush the list of ssdeep chunks.

This also obviates #1332, so we can nix that one if this is worthwhile.

(re-did this to insert elements to the tail of the list upon initialization, so that the file contents are processed top-down during execution, matching the existing behavior).

@p0pr0ck5 Hello.
I also encountered memory leaks when using fuzzy hash.
Issue #1288
Interested. You think your changes really can help to get rid of the leaks?

No, this PR is not about a memory leak. This just removes the need to re-read the fuzzy hash db from disk on every invocation. Your noted issue is unrelated to this PR.

Pull request is currently under our buildbots - http://www.modsecurity.org/developers/buildbot/waterfall

Thanks @p0pr0ck5  -- merged ;)


Added a wandb notebook

I added a notebook showing how to use wandb in IceVision. The examples uses the EfficientDet model

closes #493


Version v40.0.0 doesn't build

Hello,
I'm using the subscriptions and graphrbac packages. It appears that version v40.0.0 broke something such that these no longer build properly. I tried every version of the subscriptions package in case some were deprecated, but all failed with the same error. This looks like a problem with go-autorest, perhaps the packages depend on different versions?
# github.com/Azure/azure-sdk-for-go/services/resources/mgmt/2019-06-01/subscriptions
../vendor/github.com/Azure/azure-sdk-for-go/services/resources/mgmt/2019-06-01/subscriptions/operations.go:98:2: not enough arguments to return
../vendor/github.com/Azure/azure-sdk-for-go/services/resources/mgmt/2019-06-01/subscriptions/operations.go:98:15: client.Send undefined (type OperationsClient has no field or method Send)
../vendor/github.com/Azure/azure-sdk-for-go/services/resources/mgmt/2019-06-01/subscriptions/subscriptions.go:103:2: not enough arguments to return
../vendor/github.com/Azure/azure-sdk-for-go/services/resources/mgmt/2019-06-01/subscriptions/subscriptions.go:103:15: client.Send undefined (type Client has no field or method Send)
../vendor/github.com/Azure/azure-sdk-for-go/services/resources/mgmt/2019-06-01/subscriptions/subscriptions.go:171:2: not enough arguments to return
../vendor/github.com/Azure/azure-sdk-for-go/services/resources/mgmt/2019-06-01/subscriptions/subscriptions.go:171:15: client.Send undefined (type Client has no field or method Send)
../vendor/github.com/Azure/azure-sdk-for-go/services/resources/mgmt/2019-06-01/subscriptions/subscriptions.go:282:2: not enough arguments to return
../vendor/github.com/Azure/azure-sdk-for-go/services/resources/mgmt/2019-06-01/subscriptions/subscriptions.go:282:15: client.Send undefined (type Client has no field or method Send)
../vendor/github.com/Azure/azure-sdk-for-go/services/resources/mgmt/2019-06-01/subscriptions/tenants.go:98:2: not enough arguments to return
../vendor/github.com/Azure/azure-sdk-for-go/services/resources/mgmt/2019-06-01/subscriptions/tenants.go:98:15: client.Send undefined (type TenantsClient has no field or method Send)
../vendor/github.com/Azure/azure-sdk-for-go/services/resources/mgmt/2019-06-01/subscriptions/tenants.go:98:2: too many errors
# github.com/Azure/azure-sdk-for-go/services/graphrbac/1.6/graphrbac
../vendor/github.com/Azure/azure-sdk-for-go/services/graphrbac/1.6/graphrbac/applications.go:114:2: not enough arguments to return
../vendor/github.com/Azure/azure-sdk-for-go/services/graphrbac/1.6/graphrbac/applications.go:114:15: client.Send undefined (type ApplicationsClient has no field or method Send)
../vendor/github.com/Azure/azure-sdk-for-go/services/graphrbac/1.6/graphrbac/applications.go:194:2: not enough arguments to return
../vendor/github.com/Azure/azure-sdk-for-go/services/graphrbac/1.6/graphrbac/applications.go:194:15: client.Send undefined (type ApplicationsClient has no field or method Send)
../vendor/github.com/Azure/azure-sdk-for-go/services/graphrbac/1.6/graphrbac/applications.go:268:2: not enough arguments to return
../vendor/github.com/Azure/azure-sdk-for-go/services/graphrbac/1.6/graphrbac/applications.go:268:15: client.Send undefined (type ApplicationsClient has no field or method Send)
../vendor/github.com/Azure/azure-sdk-for-go/services/graphrbac/1.6/graphrbac/applications.go:341:2: not enough arguments to return
../vendor/github.com/Azure/azure-sdk-for-go/services/graphrbac/1.6/graphrbac/applications.go:341:15: client.Send undefined (type ApplicationsClient has no field or method Send)
../vendor/github.com/Azure/azure-sdk-for-go/services/graphrbac/1.6/graphrbac/applications.go:415:2: not enough arguments to return
../vendor/github.com/Azure/azure-sdk-for-go/services/graphrbac/1.6/graphrbac/applications.go:415:15: client.Send undefined (type ApplicationsClient has no field or method Send)
../vendor/github.com/Azure/azure-sdk-for-go/services/graphrbac/1.6/graphrbac/applications.go:415:2: too many errors

I downgraded my repo back to v30.0.0 and this works fine. It's only a problem with v40.0.0

Hi @nvelat thanks for this issue.
The reported function is introduced in go-autorest v13.4.0, and comes into go SDK since v39.3.0.
Are you also vendoring go-autorest v13.4.0?
@jhendrixMSFT could you please give some advices about the versioning of go-autorest?

@nvelat when upgrading the SDK you must also upgrade your go-autorest dependency to the minimum version specified in Gopkg.toml.  Can you please confirm this resolves your issue?

@ArcturusZhang can you update the README so it's clear that when upgrading the SDK you must also upgrade to the minimum version of go-autorest defined in Gopkg.toml?

@ArcturusZhang can you update the README so it's clear that when upgrading the SDK you must also upgrade to the minimum version of go-autorest defined in Gopkg.toml?

Sure, i will take care of this.

I'm seeing the same issue here. How can I get around it?

@tnguyen14 you need to update your version of go-autorest to at minimum v13.4.0.

@jhendrixMSFT Thanks for the quick response. How could I do that? (I'm very new to Go). I just have a reference to this package in my test code, and the go.mod file.

@tnguyen14 can you please provide the content of your go.mod file?

Sure thing:
:; cat go.mod
module github.com/myorg/azure-instance

go 1.14

require (
        github.com/Azure/azure-sdk-for-go v40.3.0+incompatible
        github.com/gruntwork-io/terratest v0.26.0
        github.com/stretchr/testify v1.5.1
)

Hmm there's no version of go-autorest mentioned.  You will need it at some point for authentication (maybe you haven't got that far yet).  If you use at minimum autorest/v0.9.6 then it will work.

I see. I was following the example here https://github.com/gruntwork-io/terratest/blob/master/test/terraform_azure_example_test.go when I got the error mentioned at the top of this issue.
Will look into autorest then.

I added the autorest package to the import statement, but running go test still gives me these errors
# github.com/Azure/azure-sdk-for-go/services/resources/mgmt/2019-06-01/subscriptions
../../../go/pkg/mod/github.com/!azure/azure-sdk-for-go@v40.3.0+incompatible/services/resources/mgmt/2019-06-01/subscriptions/operations.go:98:2: not enough arguments to return
../../../go/pkg/mod/github.com/!azure/azure-sdk-for-go@v40.3.0+incompatible/services/resources/mgmt/2019-06-01/subscriptions/operations.go:98:15: client.Send undefined (type OperationsClient has
 no field or method Send)
../../../go/pkg/mod/github.com/!azure/azure-sdk-for-go@v40.3.0+incompatible/services/resources/mgmt/2019-06-01/subscriptions/subscriptions.go:103:2: not enough arguments to return
../../../go/pkg/mod/github.com/!azure/azure-sdk-for-go@v40.3.0+incompatible/services/resources/mgmt/2019-06-01/subscriptions/subscriptions.go:103:15: client.Send undefined (type Client has no fi
eld or method Send)
../../../go/pkg/mod/github.com/!azure/azure-sdk-for-go@v40.3.0+incompatible/services/resources/mgmt/2019-06-01/subscriptions/subscriptions.go:171:2: not enough arguments to return
../../../go/pkg/mod/github.com/!azure/azure-sdk-for-go@v40.3.0+incompatible/services/resources/mgmt/2019-06-01/subscriptions/subscriptions.go:171:15: client.Send undefined (type Client has no fi
eld or method Send)
../../../go/pkg/mod/github.com/!azure/azure-sdk-for-go@v40.3.0+incompatible/services/resources/mgmt/2019-06-01/subscriptions/subscriptions.go:282:2: not enough arguments to return
../../../go/pkg/mod/github.com/!azure/azure-sdk-for-go@v40.3.0+incompatible/services/resources/mgmt/2019-06-01/subscriptions/subscriptions.go:282:15: client.Send undefined (type Client has no fi
eld or method Send)
../../../go/pkg/mod/github.com/!azure/azure-sdk-for-go@v40.3.0+incompatible/services/resources/mgmt/2019-06-01/subscriptions/tenants.go:98:2: not enough arguments to return
../../../go/pkg/mod/github.com/!azure/azure-sdk-for-go@v40.3.0+incompatible/services/resources/mgmt/2019-06-01/subscriptions/tenants.go:98:15: client.Send undefined (type TenantsClient has no fi
eld or method Send)
...

Can you share the version of go-autorest that's being imported?  It's likely too old.

I don't think go-autorest was imported, even when I put it in the import block.

@jhendrixMSFT do you have any suggestion for how to get around this issue without using go-autorest?

The reason I'm asking is because I get a different error instead when importing go-autorest v0.9.6:
imported and not used: "github.com/Azure/go-aoturest/autorest"

@tnguyen14 you have to use go-autorest as the SDK has a direct dependency on it.  The fact that it doesn't get automatically pulled in is because we haven't yet released SDK packages as modules.  The compile errors you see are because an older version of go-autorest is being included (unclear why).
The dependencies are already properly defined in the terratest go.mod file.  If you need to use v40.x of the SDK please update this go.mod file with the desired versions.

In case anyone is looking for a quick fix -
go get -u github.com/Azure/go-autorest/autorest
worked for me.


Argument "QUAL" isn't numeric in numeric ge (>=) at simuG.pl line 815, <$fh> line 6.

Hi,
This may be a simple fix but i am trying to create some synthetic data with pre-defined SNPs using a .vcf file. I assume my .VCF file is the problem so i have included what it looks like below (as a .txt file as i can't upload a .vcf). Please let me know if there is a specific format i need the vcf in.
Many Thanks,
Matt
myfile.txt

Hi Matt,
Thanks for providing the input vcf file that you used, which is very helpful.
The error was triggered due to the lack of a leading '#' character in the vcf header line "CHROM   POS     ID      REF     ALT     QUAL    FILTER  INFO" (note that you have two such lines in your file but one of them does not start with '#').
Best,
Jia-Xing

Thanks Jia-Xing! I now have a simulated output!

Great!  :-)
I will close this thread then.
Best,
Jia-Xing


Deadlock detected in bank module

Bug description

The deadlock is detected in bank modules since it applies upsert SQL statement, it might be better make sure it works synchronously.

It is solved by #46


Add instructions for bitbucket pipelines support

As proposed by @mxstbr in #696 : add instructions to support of bitbucket pipelines in the FAQ rather than directly in the repo

Coverage remained the same at 98.234% when pulling 068b189f3aaf3d082fa4ff19f78e0ad6e6b3ba24 on belgac:patch-1 into 236fb3f36c17563c265e69159a9d05d00871f98e on mxstbr:master.

This is perfect, thanks @belgac!

@mxstbr what are the next steps before we merge this pr ?

You need to merge react-boilerplate/Master into your development branch, at a minimum.

No, this is fine since it's just docs – thanks so much @belgac, just wanted to merge the i18n support in first. This looks brilliant! 🎉


Update profiles

Update profiles:

Gebalanceerd -> Recreatief
Snelst -> Commute

Changed the profile descriptions in NL and EN. Please test them here:
https://staging.anyways.eu/projects/bikeforbrussels/
I'll ask @jbelien very nicely and I'm sure he will have look at the FR once we have validate the NL and EN texts.
Can you check @Driesvanransbeeck and @pietervdvn

Just noticed that the "Van ... Naar ..." always stays in Dutch when you change to English or French.


Rename README.md to R2

There are no substantive changes requested here that merit an approval or keeping this PR open.


exploitdb: 2023-04-28 -> 2023-04-29

Diff: https://gitlab.com/exploit-database/exploitdb/-/compare/refs/tags/2023-04-28...2023-04-29
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 228887 run on x86_64-linux 1

1 package built:

exploitdb


Candidate Name

When we send an invitation it asks for the candidate name. It is a mandatory field. Sometimes we do not have the name of the candidate. Can we remove it from the mandatory field?

Also, to update the bug: Ask name from the candidate at the beginning of the quiz, and use that name everywhere, including in reports.

Fixed, we ask it from the candidate now before he can start the quiz.


[efr32] radio: fix otPlatRadioGetTransmitPower

From PR #5701 onwards, the efr32 platform shows the following behavior:
> txpower -10
Done
>
> txpower
-113 dBm
Done

The bug is caused by the C promotion rules during the division of int16_t by unsigned in otPlatRadioGetTransmitPower. This PR fixes the issue.

@dismirlian - thanks for finding and fixing this.  I've asked @lmnotran to also review as he was the one that made the change.


replacement transaction underpriced for claimFunds

It happened to me a few minutes ago that claiming funds failed with an replacement transaction underpriced error. The next run of claimFunds was successful.
  INFO-dx-service:tasks:claimFunds Claiming funds for pre +0ms
Secp256k1 bindings are not compiled. Pure JS implementation will be used.
  INFO-dx-service:tasks:claimFunds Claiming for address 0xc32cac63823b556e6ebf61bb74149f08bf1aab34 affected bots: Main buyer bot, Main seller bot +3s
  INFO-dx-service:services:DxTradeService I have to claim from 1 auctions as seller +0ms
  INFO-dx-service:services:DxTradeService Claiming as seller MKR-DAI for auctions: [ BigNumber { s: 1, e: 0, c: [ 3 ] } ] +1ms
Error: replacement transaction underpriced
    at /usr/src/app/node_modules/web3-provider-engine/subproviders/provider.js:19:36
    at XMLHttpRequest.request.onreadystatechange (/usr/src/app/node_modules/web3/lib/web3/httpprovider.js:118:13)
    at XMLHttpRequestEventTarget.dispatchEvent (/usr/src/app/node_modules/xhr2/lib/xhr2.js:64:18)
    at XMLHttpRequest._setReadyState (/usr/src/app/node_modules/xhr2/lib/xhr2.js:354:12)
    at XMLHttpRequest._onHttpResponseEnd (/usr/src/app/node_modules/xhr2/lib/xhr2.js:509:12)
    at IncomingMessage.<anonymous> (/usr/src/app/node_modules/xhr2/lib/xhr2.js:469:24)
    at emitNone (events.js:111:20)
    at IncomingMessage.emit (events.js:208:7)
    at endReadableNT (_stream_readable.js:1064:12)
    at _combinedTickCallback (internal/process/next_tick.js:138:11)
    at process._tickDomainCallback (internal/process/next_tick.js:218:9)
Error: replacement transaction underpriced
    at /usr/src/app/node_modules/web3-provider-engine/subproviders/provider.js:19:36
    at XMLHttpRequest.request.onreadystatechange (/usr/src/app/node_modules/web3/lib/web3/httpprovider.js:118:13)
    at XMLHttpRequestEventTarget.dispatchEvent (/usr/src/app/node_modules/xhr2/lib/xhr2.js:64:18)
    at XMLHttpRequest._setReadyState (/usr/src/app/node_modules/xhr2/lib/xhr2.js:354:12)
    at XMLHttpRequest._onHttpResponseEnd (/usr/src/app/node_modules/xhr2/lib/xhr2.js:509:12)
    at IncomingMessage.<anonymous> (/usr/src/app/node_modules/xhr2/lib/xhr2.js:469:24)
    at emitNone (events.js:111:20)
    at IncomingMessage.emit (events.js:208:7)
    at endReadableNT (_stream_readable.js:1064:12)
    at _combinedTickCallback (internal/process/next_tick.js:138:11)
    at process._tickDomainCallback (internal/process/next_tick.js:218:9)

Any idea what may cause it...? Is it because the sell/buy bots are running simultaneously using the same address - some nonce conflict maybe...?

It's just that. It sends two transactions too close. The "default" nonce used by the TruffleHDWallet is "pending", meaning that if it's in the pool, it'll get the correct nonce.
We experience this, from time to time, and I think is because infura has a load balancer, and we send the transactions to close.
We could try to space them a bit in time, since time is not so critical for this operations. I guess with some seconds we give time to the nodes to catch up.
@dasanra , can you take a look into this?

Are you raising gas price if transaction hasn't confirmed for some time? Or is it about two different transactions? Maybe if it's really about replacement transaction, Infura requires some minimum increment (I think Parity requires the new gas price to be at least +10% compared to the old one)?

@reverendus I have some doubts regarding this issue. We were currently working on a new feature of automatic retry if gas price was too low but we had some issues with it and we had to disable it in one of the latest versions. So could you confirm that you are using the latest staging version of the bots?
To check this the bots have and endpoint that gives you info about the running instance.
You can check it in http://hostnameorip:8081/api/about

It hasn't happened to me again since I originally reported it, I am sure I'm running claimFunds from the 0.6.8 docker image at the moment, not completely sure what version was it previously when this problem happened.
I will wait a few more days, if it doesn't happen again I'll close the issue.

Happened again:
2018-09-11T10:26:47.035Z INFO-dx-service:services:LiquidityService-MKR-WETH The auction has 51.41 % of the buy volume bought. So we are good
2018-09-11T10:27:46.998Z INFO-dx-service:services:LiquidityService-MKR-WETH We need to ensure that 50 % of the buy volume is bought. Market Price: 1.765, Price: 1.6945646228686018, Relation: 96 %
2018-09-11T10:27:46.999Z INFO-dx-service:services:LiquidityService-MKR-WETH The auction has 51.5 % of the buy volume bought. So we are good
2018-09-11T10:28:46.979Z INFO-dx-service:services:LiquidityService-MKR-WETH We need to ensure that 100 % of the buy volume is bought. Market Price: 1.765, Price: 1.6914294424050123, Relation: 95.83 %
2018-09-11T10:28:46.979Z INFO-dx-service:services:LiquidityService-MKR-WETH The auction has 51.6 % of the buy volume bought. So we need to buy an extra 48.4 %
2018-09-11T10:28:47.259Z INFO-dx-service:services:LiquidityService-MKR-WETH Posting a buy order for 0.9733045276985203 WETH ($486.6522638492601)
2018-09-11T10:28:59.109Z INFO-dx-service:services:LiquidityService-MKR-WETH Posted a buy order. Transaction: 0x62b6dbb31b3a34ee81e1f0e5731b4f52333b9a30aaad724828297fbb2c69341b
2018-09-11T10:28:59.110Z INFO-dx-service:bots:BuyLiquidityBot-MKR-WETH I've bought 0.97330452769852028744 WETH<PHONE_NUMBER>492601 USD) in auction 49 to ensure BUY liquidity
2018-09-11T10:29:00.803Z WARN-dx-service:bots:AuctionEventWatcher-0x2d9585690a724bfa29a212295a9e8c714ca694aa-0xc778417e063141139fce010982780140aa0cd5ab One auction cleared, but it was for a known pair: 0x2d9585690a724bfa29a212295a9e8c714ca694aa-0xc778417e063141139fce010982780140aa0cd5ab
2018-09-11T10:29:33.557Z INFO-dx-service:services:LiquidityService-MKR-WETH Not enough liquidity for auction 50: MKR=$0, WETH=$0
2018-09-11T10:29:34.192Z INFO-dx-service:services:LiquidityService-MKR-WETH Selling 1.1889297586859569 MKR ($1005.03)
2018-09-11T10:29:35.545Z ERROR-dx-service:repositories:AuctionRepoImpl Error on transaction "postSellOrder", from "0xc32cac63823b556e6ebf61bb74149f08bf1aab34". Params: [0x2D9585690A724BfA29a212295a9E8C714ca694aA,0xc778417e063141139fce010982780140aa0cd5ab,50,1188929758685956740]. Gas: 300436, GasPrice:<PHONE_NUMBER>. Error: Error: replacement transaction underpriced
Error: replacement transaction underpriced
    at /usr/src/app/node_modules/web3-provider-engine/subproviders/provider.js:19:36
    at XMLHttpRequest.request.onreadystatechange (/usr/src/app/node_modules/web3/lib/web3/httpprovider.js:118:13)
    at XMLHttpRequestEventTarget.dispatchEvent (/usr/src/app/node_modules/xhr2/lib/xhr2.js:64:18)
    at XMLHttpRequest._setReadyState (/usr/src/app/node_modules/xhr2/lib/xhr2.js:354:12)
    at XMLHttpRequest._onHttpResponseEnd (/usr/src/app/node_modules/xhr2/lib/xhr2.js:509:12)
    at IncomingMessage.<anonymous> (/usr/src/app/node_modules/xhr2/lib/xhr2.js:469:24)
    at emitNone (events.js:111:20)
    at IncomingMessage.emit (events.js:208:7)
    at endReadableNT (_stream_readable.js:1064:12)
    at _combinedTickCallback (internal/process/next_tick.js:138:11)
    at process._tickDomainCallback (internal/process/next_tick.js:218:9)
2018-09-11T10:29:35.546Z ERROR-dx-service:bots:SellLiquidityBot-MKR-WETH There was an error ensuring sell liquidity with the account 0xc32cac63823b556e6ebf61bb74149f08bf1aab34: Error: replacement transaction underpriced
Error: replacement transaction underpriced
    at /usr/src/app/node_modules/web3-provider-engine/subproviders/provider.js:19:36
    at XMLHttpRequest.request.onreadystatechange (/usr/src/app/node_modules/web3/lib/web3/httpprovider.js:118:13)
    at XMLHttpRequestEventTarget.dispatchEvent (/usr/src/app/node_modules/xhr2/lib/xhr2.js:64:18)
    at XMLHttpRequest._setReadyState (/usr/src/app/node_modules/xhr2/lib/xhr2.js:354:12)
    at XMLHttpRequest._onHttpResponseEnd (/usr/src/app/node_modules/xhr2/lib/xhr2.js:509:12)
    at IncomingMessage.<anonymous> (/usr/src/app/node_modules/xhr2/lib/xhr2.js:469:24)
    at emitNone (events.js:111:20)
    at IncomingMessage.emit (events.js:208:7)
    at endReadableNT (_stream_readable.js:1064:12)
    at _combinedTickCallback (internal/process/next_tick.js:138:11)
    at process._tickDomainCallback (internal/process/next_tick.js:218:9)
2018-09-11T10:29:35.547Z ERROR-dx-service:error Uncought promise rejection: Error: replacement transaction underpriced
Error: replacement transaction underpriced
    at /usr/src/app/node_modules/web3-provider-engine/subproviders/provider.js:19:36
    at XMLHttpRequest.request.onreadystatechange (/usr/src/app/node_modules/web3/lib/web3/httpprovider.js:118:13)
    at XMLHttpRequestEventTarget.dispatchEvent (/usr/src/app/node_modules/xhr2/lib/xhr2.js:64:18)
    at XMLHttpRequest._setReadyState (/usr/src/app/node_modules/xhr2/lib/xhr2.js:354:12)
    at XMLHttpRequest._onHttpResponseEnd (/usr/src/app/node_modules/xhr2/lib/xhr2.js:509:12)
    at IncomingMessage.<anonymous> (/usr/src/app/node_modules/xhr2/lib/xhr2.js:469:24)
    at emitNone (events.js:111:20)
    at IncomingMessage.emit (events.js:208:7)
    at endReadableNT (_stream_readable.js:1064:12)
    at _combinedTickCallback (internal/process/next_tick.js:138:11)
    at process._tickDomainCallback (internal/process/next_tick.js:218:9)

@reverendus thank you for the feedback.
We found an scenario that should be causing this error. It's not critical, as is shown when trying to buy twice. We check liquidity too fast and the information with the previous buy may not be in the queried ethereum node (so it tries to buy again when is not necessary).
We are looking how to deal with this and a patch will be released in a future version. This issue will remain open and we wil notify here when the patch is delivered.

@reverendus I also read that this happened with claimFunds, is a similar case, we execute two transactions very close and so one is rejected because the information in the ethereum node is not updated yet.

thanks for the update. it's not critical to us by any means, I just felt obliged to report it.


Switch componentWillReceiveProps to getDerivedStateFromProps to avoid…

Switch componentWillReceiveProps to getDerivedStateFromProps to avoid a React warning. Fixes #47.

This has some bug because getDerivedStateFromProps will be called on every render.


Add Experience Section

Add section with details about work experience
Purpose
Add Experience Section. Fixes #538
Screenshots

Documentation
If this is an enhancement, add a link here to the corresponding pull request on https://github.com/sourcethemes/academic-www or describe the documentation changes necessary.
I've added the files using the name "work".  I've also changed the config.toml file to include the date format for the courses (under param.work).

This requires numerous changes. For example, the PR contains changes unrelated to the Work Experience feature and also parts of the code have just been copied and pasted from other files without the necessary refactoring.

@gcushen Sorry about that. I'll fix the issues and upload the correct version.

@gu-stat can you explain the use case for Experience an how the existing code in the template/widget for projects can't be used or deliver the same result? the Projects widget was designed to be copied and modified so that other content can live in a similar relationship... I am wondering if "experience" would fit this case.

Hi @HughP . It's a personal choice of how to organize information, and I couldn't make it the way I wanted it to be using the Projects widget. If there's a way to do it, please let me know.
This is what I have when I use the Experience widget:
Desktop view:

Mobile view:

And this is using the Projects widget:
Desktop view:

Mobile view:

The mobile views are very similar, but for the desktop view I'd rather have the "two lines, two column" layout.
Also, I opened a new pull request with a corrected version of this code here #598   (I didn't know how to update this one =/)

@gu-stat Since you have opened another PR, consider closing this.

ok @prateekkumarweb , thanks.


Fix rendering order for movable text

I recently had to render transparent textures for a map visualization
plugin. Traditional wisdom says that solid objects are rendered first,
and everything transparent afterwards. However, choosing a later Ogre
rendering queue overwrites all movable text elements, since they disable
depth writing for some reason.
This PR therefore moves the movable text to the latest possible
rendering queue. For always-on-top rendering, the depth check is
disabled. I decided to leave depth buffer writing always on, although it
won't make much of a difference either way.
Edit: I forgot about overlapping text elements, so I re-disabled depth buffer writing.

thanks for the PR @roehling . Is there a reproducible example you could provide to help with testing?

I forgot about overlapping text elements, so I re-disabled depth buffer writing.

Could you please explain, why you always disabled depth buffer writing, while before it was depending on the mOnTop variable?
I guess moving it to the latest queue, renders text always on top now?

There are two distinct mechanisms at work here: the depth buffer check will prevent the text from rendering if something else is occluding the text. If the text is to be rendered always-on-top, the depth buffer must be ignored, and if not, the depth buffer must be checked.
The depth buffer writing would update the depth buffer with the depth of the quad that displays the text. If some other text further in the background is rendered later (which can und will happen, since there is no explicit Z-ordering of the text labels). The transparent parts of the first label (technically just a solid quad) will occlude the second, which looks weird.
Actually, this PR only solves halve of my problem, since I get a similar rendering error with transparent map tiles in my plugin, so the "true" solution would be proper Z-ordering of all transparent elements, which are then rendered together in a queue after all solids.

Thanks for the clarification.

the "true" solution would be proper Z-ordering of all transparent elements

I agree that this would be nice, but I think we also agree that this is out of scope for rviz as a generic, real-time rendering tool. Z-ordering should consider pixel level actually because parts of two rendered items might have different depths. Consider for example two text items which are crossing each other.

Dear @roehling, I tried to reproduce the issue, but I couldn't. Actually, I couldn't see any rendering difference between the released version and your PR version. Could you, please, provide a code snipped, e.g. a MarkerArray yaml to reproduce the issue, as well as an image illustrating the problem?
Using marker_test from rviz' test folder, I get the following renderings, which look good to me:
released version:

new version:

@roehling Could you please comment on https://github.com/ros-visualization/rviz/pull/1292#issuecomment-471154972?

As I said in the original post, it's a very specific setting (i.e. using a non-standard rendering queue to add objects with transparent textures after the bulk of rviz rendering took place) where this patch would improve rendering. Ideally, there should not be a single instance where rendering changes for any of the default plugins.
I can probably come up with minimal example where this patch helps eventually, but I'm a bit starved for time right now.
Arguably, this whole PR is more of a wishlist bug than an actual pressing matter. I think it would be cleaner to move overlay texts to the overlay queue, but since no one besides me seems to be affected, maybe it's not worth the effort after all.


Typo on #24

What does this PR do? Please provide some context
Fixed a typo
Where should the reviewer start?
on #24
How can this be manually tested? (brief repro steps and corpnet-URL with change)
Just review the typo found. Then, approve
What are the relevant TFS items? (list id numbers)
Definition of done:

[x ] Title of the pull request is clear and informative
[ ] Add pull request hyperlink to relevant TFS items
[ ] For large or complex change: schedule an in-person review session
[ ] This change has appropriate test coverage
[ ] Get at least two approvals

Reminders DURING merge

If you're merging from a short-term (feature) branch into a long-term branch (like dev, release, or master) then "Squash and merge" to keep our history clean.
If merging from two longterm branches (like cherry picks from upstream, dev to release, etc) then "Create merge commit" to preserve individual commits.

good catch! thanks


Bar in some instances spans the whole terminal and in others only half

I'm having an issue where in one instance the bar will always cover the whole terminal (desired), but in another it will only take up half the terminal. In both cases they are instantiated with:
progress_bar = ProgressBar.new(array.length, :bar,:elapsed,:counter)

Though I was seeing the same behaviour when only passing in a total items value and using the full set of bar and metrics.
Progress_bar taking up the whole screen:

Progress_bar only taking up half the screen:

I wondered if it was determined by the with of lines above, so tried Putting a line of text the width of the whole terminal before the bar that is only taking up half the terminal, but it didn't have any effect.
This is replicable every time, with having made no changes to the terminal dimensions, Ubuntu 16.04, Gnome 3.18.3.

Proper use of Mutex-ing also made this issue disappear, as per https://github.com/paul/progress_bar/issues/40


Build failure after removal of inaugural-openfyde repo

Hi,
When trying to do the setup_board step with a clean fetched repo, the following error occur, probably due to the removal of the inaugural-openfyde repo in commit https://github.com/openFyde/manifest/commit/7612a71c9727e81918ebe0afde5281ded4a35172
(cr) (release-R108-15183.B/(4f43ce0...)) spotvin@Obelix ~/chromiumos/src/scripts $ setup_board --board=rock5b-openfyde
15:11:05.217: INFO: Updating chroot.
15:11:05.217: INFO: run: /mnt/host/source/src/scripts/update_chroot --toolchain_boards rock5b-openfyde '--backtrack=10' --usepkg
15:11:05.321 INFO    : Updating chroot
15:11:05.325 INFO    : Clearing shadow utils lockfiles under /
15:11:05.327 INFO    : Updating cross-compilers
15:11:05.328 INFO    : Running: sudo -E /mnt/host/source/chromite/bin/cros_setup_toolchains --include-boards=rock5b-openfyde
cros_setup_toolchains: Unhandled exception:
Traceback (most recent call last):
  File "/mnt/host/source/chromite/bin/cros_setup_toolchains", line 217, in <module>
    DoMain()
  File "/mnt/host/source/chromite/bin/cros_setup_toolchains", line 213, in DoMain
    commandline.ScriptWrapperMain(FindTarget)
  File "/mnt/host/source/chromite/lib/commandline.py", line 1235, in ScriptWrapperMain
    ret = target(argv[1:])
  File "/mnt/host/source/chromite/scripts/cros_setup_toolchains.py", line 1551, in main
    root=root,
  File "/mnt/host/source/chromite/scripts/cros_setup_toolchains.py", line 773, in UpdateToolchains
    targets.update(toolchain.GetToolchainsForBoard(board))
  File "/mnt/host/source/chromite/lib/toolchain.py", line 95, in GetToolchainsForBoard
    buildroot=buildroot,
  File "/mnt/host/source/chromite/lib/portage_util.py", line 259, in FindOverlays
    overlays = _ListOverlays(board=board, buildroot=buildroot)
  File "/mnt/host/source/chromite/lib/portage_util.py", line 236, in _ListOverlays
    found_pub = _AddRepo(board, optional=True)
  File "/mnt/host/source/chromite/lib/portage_util.py", line 220, in _AddRepo
    _AddRepo(master)
  File "/mnt/host/source/chromite/lib/portage_util.py", line 220, in _AddRepo
    _AddRepo(master)
  File "/mnt/host/source/chromite/lib/portage_util.py", line 215, in _AddRepo
    raise MissingOverlayError("%s was not found" % repo)
chromite.lib.portage_util.MissingOverlayError: inaugural-openfyde was not found
15:11:05.692: ERROR: Error occurred while updating the chroot. See the logs for more information.

Sorry for the late reply. The missing overlays have been fixed just now. You can pull r108-dev
https://github.com/openFyde/manifest again then call repo sync then inaugural-openfyde  should appear.

Thanks for fixing the missing inaugural-openfyde overlay. After updating to the latest manifest and doing a repo sync, I get another missing repository, archero this time:
(cr) (release-R108-15183.B/(4f43ce0...)) spotvin@Obelix ~/chromiumos/src/scripts $ setup_board --board=rock5b-openfyde
16:36:52.637: INFO: Updating chroot.
16:36:52.637: INFO: run: /mnt/host/source/src/scripts/update_chroot --toolchain_boards rock5b-openfyde '--backtrack=10' --usepkg
16:36:52.745 INFO    : Updating chroot
16:36:52.749 INFO    : Clearing shadow utils lockfiles under /
16:36:52.751 INFO    : Updating cross-compilers
16:36:52.752 INFO    : Running: sudo -E /mnt/host/source/chromite/bin/cros_setup_toolchains --include-boards=rock5b-openfyde
cros_setup_toolchains: Unhandled exception:
Traceback (most recent call last):
  File "/mnt/host/source/chromite/bin/cros_setup_toolchains", line 217, in <module>
    DoMain()
  File "/mnt/host/source/chromite/bin/cros_setup_toolchains", line 213, in DoMain
    commandline.ScriptWrapperMain(FindTarget)
  File "/mnt/host/source/chromite/lib/commandline.py", line 1235, in ScriptWrapperMain
    ret = target(argv[1:])
  File "/mnt/host/source/chromite/scripts/cros_setup_toolchains.py", line 1551, in main
    root=root,
  File "/mnt/host/source/chromite/scripts/cros_setup_toolchains.py", line 773, in UpdateToolchains
    targets.update(toolchain.GetToolchainsForBoard(board))
  File "/mnt/host/source/chromite/lib/toolchain.py", line 95, in GetToolchainsForBoard
    buildroot=buildroot,
  File "/mnt/host/source/chromite/lib/portage_util.py", line 259, in FindOverlays
    overlays = _ListOverlays(board=board, buildroot=buildroot)
  File "/mnt/host/source/chromite/lib/portage_util.py", line 236, in _ListOverlays
    found_pub = _AddRepo(board, optional=True)
  File "/mnt/host/source/chromite/lib/portage_util.py", line 220, in _AddRepo
    _AddRepo(master)
  File "/mnt/host/source/chromite/lib/portage_util.py", line 215, in _AddRepo
    raise MissingOverlayError("%s was not found" % repo)
chromite.lib.portage_util.MissingOverlayError: archero was not found
16:36:53.112: ERROR: Error occurred while updating the chroot. See the logs for more information.

I see. Since ArcHero is still in develop status and unstable so the repo is only visible for our internal build.
You can find the overlay-rock5b-openfyde and apply the following:
diff --git a/metadata/layout.conf b/metadata/layout.conf
index 8170e7fbd248..49078249b06d 100644
--- a/metadata/layout.conf
+++ b/metadata/layout.conf
@@ -1,4 +1,4 @@
-masters = portage-stable chromiumos eclass-overlay rock5b-openfyde-base fyde-eclass archero
+masters = portage-stable chromiumos eclass-overlay rock5b-openfyde-base fyde-eclass
 profile-formats = portage-2 profile-default-eapi
 profile_eapi_when_unspecified = 5-progress
 repo-name = rock5b-openfyde
(END)


Feature/#1810 replays checkbox

cherry picked code for the checkbox and added unittesting

com.faforever.client.vault.search.SearchControllerTest > testBuildQueryWithCheckboxAndQuery FAILED
    java.lang.AssertionError at SearchControllerTest.java:129

com.faforever.client.vault.search.SearchControllerTest > testBuildQueryWithCheckbox FAILED
    java.lang.AssertionError at SearchControllerTest.java:112

Unit tests still failing


bug fix 2368

The reason of bug was due to unhandled condition of non 101 during
websocket response readNetworkResponse() method  in http Engine. Also response body was being closed in createWebSocketCall when response code was non 101. I ran ws related testcases after making my changes.
This fix solves problem for issue #2368 and possibly #2264 as well.

Hi guys, is this getting merged anywhere soon?

I think this one looks ok. Was there anything else? Maybe just needs a test case?

@JakeWharton can you merge this?

Resolved with #2583. Thanks!


refactor: migrate from observable-object to signals

copilot:all

Current dependencies on/for this PR:

main

PR #3602

PR #3646   👈

This comment was auto-generated by Graphite.


Use of Medical Terms Dictionary Violates GPLv3.0

The medical terms extension cites a GPLv3.0 project as the source of its dictionary yet relicenses it MIT. See this just fixed issue for further details.

Fixed by #91


Permanent local participant to fix NPEs when not connected

Cool, so now localParticipant is a LocalParticipant instead of a LocalParticipant? .

Yeah.


For directions directive the route is not getting printed once map id is specified

Hello,
In case if map id attribute is specified the route is not printed since NgMap.getMap()  could not find the instance of map and therefore updateRoute is not invoked.
The below example demonstrates how to print a route no matter whether map id is specified or not:
if('id' in mapController.mapOptions) {
       NgMap.getMap({ id: mapController.mapOptions.id }).then(function() {
                updateRoute(renderer, options);
       });
}
else {
      NgMap.getMap().then(function() {
          updateRoute(renderer, options);
      });
 }

I think you need to get map instance, and assign it to your variable
NgMap.getMap({ id: mapController.mapOptions.id }).then(function(map) {
vm.map = map; // like this
updateRoute(renderer, options);
});

closing for inactivity. Please recreate an issue if wants to continue on this topic.


Excuse me, I'd like to ask you a question

When I use scripts to run the pre-training phase, there is always an error that cannot be solved.The error is"ValueError: Some specified arguments are not used by the HfArgumentParser: ['\', '\', '\', '\', '\', '\', '\', '\', '\', '\', '\', '\', '\', '\', '\']".
I take the liberty of writing to you. I would appreciate it if I could receive your reply as soon as possible.

Excuse me, I am now reproducing your code, but there is no experimental data required in the paper, would you please provide complete data and data processing flow? I would appreciate it if I could receive your reply as soon as possible.


Plugin request for Buf Schema Registry: mypy-protobuf

Mandatory
Where is the source code for the plugin?
https://github.com/nipunn1313/mypy-protobuf/tree/main/mypy_protobuf
Optional
Does the plugin have a valid semver version?
Yes, currently 3.4.0, from https://github.com/nipunn1313/mypy-protobuf/blob/main/CHANGELOG.md.
Does this plugin have runtime dependencies?
I think so, under "Requirements to run mypy-protobuf".
Does the plugin have a dependency on another plugin?
Nope - it's commonly used with python-protobuf, but isn't dependent on it.
Do you think this plugin will be compatible with the BSR go module proxy or npm registry?
N/A, but perhaps a Python registry? 😃

Reopening as we'd like to review this a bit more before release.

What is the status of this? I think this ticket is also requesting a mypy-protobuf plugin:
https://github.com/bufbuild/plugins/issues/452


in alpine how to use sdkman?

this is alpine linux home site https://www.alpinelinux.org/,
i want to use sdkman in alpine but , i don't know how to use.
install follow step by step but failed

Please follow the contributor guidelines as stipulated.


ZER-19 Create CalculatorResolver

dev
JIRA

Main JIRA ticket

Code reviewers

[ ] @github_username

Second Level Review

[ ] @github_username

Summary of issue
ToDo
Summary of change
ToDo
Testing approach
ToDo
CHECK LIST

[ ]  СI passed
[ ]  Сode coverage >=95%
[ ]  PR is reviewed manually again (to make sure you have 100% ready code)
[ ]  All reviewers agreed to merge the PR
[ ]  I've checked new feature as logged in and logged out user if needed
[ ]  PR meets all conventions

Also, get_dependencies and get_fields are used only within class, so should be private


ceylon doc does not correctly handle variadic parameters

Look at the signature rendered for noop() in ceylon.language.

Fixed.


Allow skip of sail checks

When setting the SKIP_SAIL_CHECKS env variable the docker exec will speed up a bit

Why?

Hi @driesvints
when I looked into this, the primary reason for speed differences (Intel Mac) between docker-compose tasks and sail tasks was the time taken by docker to respond to the docker-compose ps and docker info commands.
If there was a way to reduce these, then sail could become quicker.
I wondered about instead of pre-emptively checking whether docker is running on each command, we could instead try to interpret the failure mode of the command to determine the problem, or move these to a sail check command to speed it up.

If there was a way to reduce these, then sail could become quicker.

that only explains half the PR though

@powellblyth what would be the other half?

@cdarken  Ooops my bad, I think I had a second similar PR on my screen. I'll edit that out. Thanks .

Why?

About 2x speedup on my machine.
Not something to scowl at, I'd say.

@driesvints you can check again the https://github.com/laravel/sail/issues/191 issue that you were rush to close to see why.
There you and even Taylor himself propose us to create PRs. So this is a PR to address that issue.
That's why there is a reason to keep an issue open, so people to be able to discuss about potential solutions and everybody agree to a solution so when a PR comes-in we won't ask "why" because there was a conversation regarding the problem and people related to the project have come to agree to a solution.
This is a good start to make Sail ~4 seconds faster by disabling docker-compose initial checks that do delay every single sail command on each run.

@clytras no issue was linked so I had no idea what this was about.

That's why there is a reason to keep an issue open, so people to be able to discuss about potential solutions and everybody agree to a solution so when a PR comes-in we won't ask "why" because there was a conversation regarding the problem and people related to the project have come to agree to a solution.

I appreciate it that you want to provide suggestions here but that's not how we work. Anyone can always send in a PR. Like @cdarken has done here. A closed issue isn't locked either and anyone can still continue to discuss there if they like.

Renamed to SAIL_SKIP_CHECKS so all the Sail related environment variables start with SAIL_.

@driesvints Yes of course. Please don't be offended by my comments; I get blunt sometimes and I wish I've had the time to make a PR but I couldn't even have time to think of an efficient way to address this issue.
I do appreciate from the bottom of my heart all the work that you and Taylor and everyone else that are contributing to this amazing project are doing here and I do want to contribute as well in the future.
Thank you for all the valuable work you're doing for all the community 💪

@clytras no offence taken. We also appreciate you trying to help out with improving the packages :)


PmenuMatch and PmenuMatchSel highlight groups to combine with underlying highlighting

Instructions: Replace the template text and remove irrelevant text (including this line)
Is your feature request about something that is currently impossible or hard to do? Please describe the problem.
PmenuMatch and PMenuMatchSel currently don't combine Pmenu and PmenuSel respectively. This makes it more difficult for users to adjust those for any color scheme (to the point of not really be worth it). Here is an example with vim --clean, :set completeopt+=fuzzy, :hi PmenuMatch cterm=bold, :hi PmenuMatchSel cterm=bold:

Describe the solution you'd like
Both PmenuMatch and PMenuMatchSel combine highlight attributes with Pmenu and PmenuSel. So that in previous example matched text is bold with the same background and foreground as non-matched text.
Describe alternatives you've considered
Dynamically computing foreground/background attributes of non-matched text and using those to set all attributes explicitly. Which seems to be unnecessarily tricky for the task at hand.
Additional context
None.

As an independent highlight group, background color must be declared instead of setting a separate property.  should be consistent with the working method of other Pmenu hl

As an independent highlight group, background color must be declared instead of setting a separate property. should be consistent with the working method of other Pmenu hl

Maybe then there is a merit of adjusting all Pmenu* and Pmenu*Sel to combine with Pmenu and PmenuSel? As they can be created independently, but operate on same (documented) objects: "normal item" and "selected item" respectively.
That is:

PmenuMatch and PmenuKind should combine with underlying Pmenu.
PmenuMatchSel and PmenuKindSel should combine with underlying PmenuSel.

I didn't suggest that initially because I personally don't see much use in having essentially fixed "kind" highlight groups. But I guess it would also make sense if anyone wants them, for example, always to be bold (in any color scheme).

hl_group as a field of complete function working differently ..


Battery sensor for Tesla component failing

Make sure you are running the latest version of Home Assistant before reporting an issue.
You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum:
Home Assistant release (hass --version):
0.64.3 - hass.io: 0.96
Python release (python3 --version):
3.6.3
Component/platform:
Tesla
Description of problem:
After 0.63 update the Battery sensor went away, and the device update fails. The fix #12225 seems to have removed two lines of code in homeassistant/components/sensor/tesla.py that updated the Battery level sensor.
Traceback (if applicable):
2018-03-07 20:12:35 ERROR (MainThread) [homeassistant.components.sensor] tesla: Error on device update!
Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/homeassistant/helpers/entity_platform.py", line 197, in _async_add_entity
    yield from entity.async_device_update(warning=False)
  File "/usr/lib/python3.6/site-packages/homeassistant/helpers/entity.py", line 327, in async_device_update
    yield from self.hass.async_add_job(self.update)
  File "/usr/lib/python3.6/asyncio/futures.py", line 332, in __iter__
    yield self  # This tells Task to wait for completion.
  File "/usr/lib/python3.6/asyncio/tasks.py", line 250, in _wakeup
    future.result()
  File "/usr/lib/python3.6/asyncio/futures.py", line 245, in result
    raise self._exception
  File "/usr/lib/python3.6/concurrent/futures/thread.py", line 56, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/lib/python3.6/site-packages/homeassistant/components/sensor/tesla.py", line 82, in update
    self.current_value = self.tesla_device.get_value()
AttributeError: 'Battery' object has no attribute 'get_value'

Thanks, I'll check it out

Error was fixed by updating teslajson dependency to right version.


ISO 14496

I noticed that you referenced ISO 14496 part 12 and 15 in bmff.py. I'm working on a similar project to this one right now. Would you have any recommendations for ways to get these standards, drafts, detailed descriptions, or reference/other implementations? I've only been able to get ISO 14496-12:2003 so far, which is quite outdated judging by page count, and the 2020 edition for 67 € at evs.ee.

That comment comes from the berrymse
There are implementations in the ffmpeg and gstreamer too.

ok, thanks!


random.key_implwrong return type annotation

Description
The code
import jax.random as jr

k = jr.key(1)
impl = jr.key_impl(k)
data = jr.key_data(k)

k2 = jr.wrap_key_data(data, impl=impl)

when checked with mypy raises the following error
python-3.11.2 ❯ mypy pp.py
pp.py:7: error: Argument "impl" to "wrap_key_data" has incompatible type "Hashable"; expected "str | PRNGSpec | PRNGImpl | None"  [arg-type]
Found 1 error in 1 file (checked 1 source file)

I believe that key_impl should return a PRNGSpec  instead of an Hashable ?
System info (python version, jaxlib version, accelerator, etc.)
0.4.31

Thanks @PhilipVinc, this does seem like a typo/outdated annotation. Fix incoming!


Need update on tutorial doc

I tried running through the deployment tutorial. The example is outdated to the current CRD.
# kubectl apply -f aw-01.yaml
error: error validating "aw-01.yaml": error validating data: ValidationError(AppWrapper.spec): unknown field "schedSpec" in com.ibm.mcad.v1beta1.AppWrapper.spec; if you choose to ignore these errors, turn validation off with --validate=false

Also, as I'm running on M1 laptop, the current echo-server image failed to the following error.
<time> [error] 1#1: failed to initialize Lua VM in /etc/nginx/nginx.conf:54
nginx: [error] failed to initialize Lua VM in /etc/nginx/nginx.conf:54

To make it work, I made the change as in this commit. Will push the PR soon.

Tutorial docs have been updated with a focus on single cluster deployment, closing this issue for now. please feel free to reopen.


Up 4880 unit test layoutpackage

Checklist

[ X] the individual contributor license agreement is signed
[ X] commit message follows commit guidelines
[ X] tests are included
[ ] documentation is changed or added
[ ] message properties have been updated with new phrases
[ ] view conforms with WCAG 2.0 AA

Description of change

Added unit test cases for  org.apereo.portal.rest.layout package

:notebook: Some commits overlap with #935
Commits including and after ba19f40 are unique to this PR.

Linux build is running into unrelated out of memory exception.
3ccbe5b4c89b2365614ebfd26e255166aceccf30 from #937 will resolve.

Changes merged as part of https://github.com/Jasig/uPortal/pull/940


Can't remove space between editor pallete and explorer

VSCode Version: 1.26.1
OS Version: Archlinux (kernel 4.17) + AwesomeWM tilling window manager

Steps to Reproduce:

Open VsCode
Enter "Zen mode" (Ctrl+k Z)
Maximize width of editor palete (see picture)

Does this issue occur when all extensions are disabled?: Yes

Put this in your settings
"zenMode.centerLayout": false

And also F1 > toggle centered layout


[bug] tauri V2 updater InvalidSignature

Describe the bug
When I use the updater function, it has triggered the check. Then I use update.downloadAndInstall and the download completes, but the error Uncaught (in promise) InvalidSignature is returned.
I first used the release address of github, and then I used a separate https domain name to test, but the same error was reported.

Reproduction
No response
Expected behavior
No response
Full tauri info output
[✔] Environment
    - OS: Windows 10.0.22631 X64
    ✔ WebView2: 123.0.2420.97
    ✔ MSVC: Visual Studio Enterprise 2022
    ✔ rustc: 1.76.0 (07dca489a 2024-02-04)
    ✔ cargo: 1.76.0 (c84b36747 2024-01-18)
    ✔ rustup: 1.27.0 (bbb9276d2 2024-03-08)
    ✔ Rust toolchain: stable-x86_64-pc-windows-msvc (default)
    - node: 20.9.0
    - pnpm: 8.15.4
    - yarn: 1.22.22
    - npm: 10.1.0

[-] Packages
    - tauri [RUST]: 2.0.0-beta.16
    - tauri-build [RUST]: 2.0.0-beta.13
    - wry [RUST]: 0.39.2
    - tao [RUST]: 0.27.1
    - @tauri-apps/api [NPM]: 2.0.0-beta.6
    - @tauri-apps/cli [NPM]: 2.0.0-beta.10

[-] App
    - build-type: bundle
    - CSP: default-src 'self' customprotocol: asset:; style-src 'unsafe-inline' 'self' 'nonce-10500982406343687894' 'nonce-9786197052427597798'; connect-src ipc: http://ipc.localhost ws:; script-src 'self' 'unsafe-eval' 'sha256-f2aYrerT20WDJlPe3kdN3JfQlyKoRxP33xkWfDbeO9I=' 'sha256-GFebPxKzs1UkFRCbyMaykyYD7rGVWnt1zk1m6r+ZTWQ=' 'sha256-iUqSk0LHeoYfdwsQNbveDMYkU7Tq/OmyauSlE3snBuc='; font-src https://fonts.gstatic.com http://tauri.localhost; img-src 'self' blob: data: http: https: asset: http://asset.localhost
    - frontendDist: ../dist
    - devUrl: http://localhost:1420/
    - framework: Vue.js
    - bundler: Vite

Stack trace
No response
Additional context
No response

Can you double check whether the private key you used to sign the updater bundle (that generated the .sig file) belongs to the pubkey defined in tauri.conf.json? And also check whether the "signature" field in the server json is the full content of the .sig file that belongs to the updater bundle your server hosts (the .sig file changes every time you re-build your app!)

I found this problem, I configured it in tauri.config.json
        "wix": {
          "language": [
            "zh-CN",
            "en-US"
          ]
        }

Then the signature of the generated latest.json is zh-CN, but the updated package is en-US. And there is only one language update package in latest.json, and signature does not correspond to it. How should I deal with this?

I am following below steps

run : npm run tauri signer generate

Got public and private keys

Put public key in tauri.config.json (pubkey) node

Put private key in system environment variable using cmd: set TAURI_PRIVATE_KEY=<private_key>

cmd : npm run tauri build

Got updated build (myapp_1.0.2_x64_en-US.msi.zip) and .mis.zip.sig files

Upload .mis.zip on server and update signature value in server json which is inside (.mis.zip.sig)

Because I have my old version build i.e. 1.0.1 run this app and got that error (Verify signature error: UnexpectedKeyId)
Now please suggest where I had done mistake in the process..


Move tests to independent repository

It makes stuff too difficult and a little backwards. Conflicts with main in package.json

Done, batr-example.


.Net: All dotnet/src/Functions/Functions.OpenApi/Model/RestApiXXX.cs should be internal

Describe the bug
All dotnet/src/Functions/Functions.OpenApi/Model/RestApiXXX.cs should be internal because they are only used by internal implementations

@markwallace-microsoft Can I create a pull request for this?

It's not relevant anymore because we are going to expose RestApiOperation class and all its dependencies via KernelFunction metadata.


[HUDI-4442] add in field sanitization and use of aliases

Change Logs
Describe context and summary for this change. Highlight if any code was copied.
Impact
Describe any public API or user-facing feature change or any performance impact.
Risk level (write none, low medium or high below)
If medium or high, explain what verification was done to mitigate the risks.
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change

The config description must be updated if new configs are added or the default value of the configs are changed
Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the instruction to make
changes to the website.

Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

@the-other-tim-brown : is this this valid or already merged as part of a diff PR. if yes, can you close this one out.

@the-other-tim-brown : is this this valid or already merged as part of a diff PR. if yes, can you close this one out.

@nsivabalan I need to clean this up so as to not add default values when translating from json to avro but I think the functionality would be a good addition


Feature request: improve password hygeine / security

Search before asking

[X] I had searched in the issues and found no similar issues.

Motivation
Improve handling of cleartext passwords, keeping them out of version control in particular, and to follow industry recommended practices.
Solution
Please add an option to configure kvrocks with a sha256 hash of the actual password, rather than using cleartext. Though similar to the Redis #<hashedpassword> ACL option, it could be implemented separately from any ACL functionality, as an alternative to using the requirepass directive, perhaps with a kvrocks.conf requirepass_sha256 directive, and/or by setting an environment variable, eg: KVROCKS_SECRET_SHA256=e3b0c442...etc... When a client connects and provides its pass, kvrocks would compare the sha256 of that value if enabled, rather than use the cleartext.
Related, it would helpful for kvrocks to support the file-based convention recommended for secrets used in containers. It's often hard to keep regular environment variables out of version control, and they can leak during runtime too. Instead, one environment variable (eg, KVROCKS_PASSWORD_FILE) holds a path to a file in .ini format (key=value pairs just like env vars) which the app loads and uses for its config.
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

I'm not sure if I understand your words correctly.
You can currently specify the master password in kvrocks.conf. And the configuration file should only be accessible to trusted individuals.

Placing the master password in kvrocks.conf means you can't check that file into git, and that it won't work with secret managers / vaults in a containerized environment.
Rather than place the password in that file, someone could use the --requirepass switch on start, but in a containerized environment using a secrets manager, this requires overriding the project's original dockerfile entrypoint and dealing with environment variable expansion headaches.
What would be much better is telling kvrocks where to find the secret. For example, masterpass_env KVROCKS_MASTER_PASS tells the app to use the value of that environment variable as its password. Better yet, adding masterpass_file /var/run/secrets/kvrocks.ini tells kvrocks to find that value within a file, making it even easier to lock it down using a secrets manager/vault, and is more likely to keep the cleartext secret out logs/history/environment, places that might leak.
The other suggestion is an option to use sha256 verification of the master password. Where kvrocks is only provided with the hashed password so even if it leaked, it's not in a usable form.

IMHO from my side it doesn't seem to be the logic that needs to be implemented inside Kvrocks.
e.g. if you are using helm charts, you can refer to some helm packages like https://artifacthub.io/packages/helm/bitnami/redis which support configmap construction and secret management for Redis via several ways, as Kvrocks configuration mechanism is similiar to Redis.
For stronger security, you can refer to TLS connection support in Kvrocks and provide your own client-side certificates.

Not TLS, I'm talking about password management: how to properly provide the secret to kvrocks and to clients without it leaking into git, logs, etc.
With Redis, I can use an ACL file. With postgres, I can use POSTGRES_PASSWORD_FILE. Systems that don't offer that simple mechanism add a burden... modifying config files during deployment with sed, or reconfiguring helm/other, or maintaining a custom entrypoint, etc.
I'm personally overriding the entrypoint and am fine, but am suggesting modest ways you could make it easier for people to secure kvrocks with their current tooling.

Yes, perhaps we can support this in Dockerfile like PostgreSQL: https://github.com/docker-library/postgres/blob/cefde5ff6f102fcd381a03210c7734816c59aa3e/docker-entrypoint.sh#L9.

Good idea to review theirs! Looks like their file_env() would work without modification, and is MIT license. I personally try to minimize time with bash, so nice to borrow from experts.
Off the top of my head, a new kvrocks-entrypoint.sh might look like:
#!/usr/bin/env bash

# copy of file_env() function here

file_env 'KVROCKS_PASSWORD'

exec kvrocks "$@"

If using the above entrypoint, --requirepass could be set using a positional [COMMAND] argument on start, but would require escaping var expansion. I think it would look something like: docker run --env KVROCKS_PASSWORD_FILE=/var/run/secrets/kvrocks.ini apache/kvrocks --requirepass '$${KVROCKS_PASSWORD}'
It would be possible for the entrypoint itself to conditionally include --requirepass when $KVROCKS_PASSWORD is present... should someone with more bash ambition come along. :) Prob involves $([conditional -Z] printf) stuff.

Is there anyone else working on solving this problem? If not, I would like to give it a try. If I encounter problems or cannot solve them, I will actively communicate with the community in a timely manner.


Add talk titles in schedule

Add image of speakers along with titles of their talks and affiliations.
Make the talks details to be open by default.

It looks to me like the css is off for the images?

Thanks @lheagy for reporting it. I found that issue happening only in Chrome-based browsers, I haven't see it in Firefox.
I just pushed a fix for that.


cookie header should be stripped from response

For security reasons it's be bad to expose the cookie in the proxied response to the user.

Nevermind -- it looks like the response headers aren't passed through.


feat: JSON Form widget

Description
This widget generates forms with input fields automatically from any JSON data source. Generated form field's properties can be modified to cater to the form's functionality.
It supports arrays and objects with n-level depth but the property pane can show properties of nested fields up to 5 levels of depth only, beyond that the configuration object has to be edited manually.
Nomenclature

Field - A field is an input entity on the form. It can be a multi-select, radio input, text input, etc.
Schema - This is a representation of the form that is generated from the JSON. It holds every configuration for every field and it can be considered as the source of truth for the form.
SchemaItem - Each individual field's state in the schema is a schema item.
Source data - It is the JSON input that is provided by the Appsmith user from which the form fields are generated.

Sample source data and corresponding schema structure:
{
  "name": "John",
  "age": 10
}

Schema
{
  __root_schema__: {
    isDisabled: false,
    isRequired: false,
    label: "",
    isVisible: true,
    children: {
      name: {
        isDisabled: false,
        isRequired: false,
        label: "Name",
        isVisible: true,
        isSpellCheck: false,
        children: {},
        dataType: DataType.STRING,
        defaultValue:
          "{{((sourceData, formData, fieldState) => (sourceData.name))(JSONForm1.sourceData, JSONForm1.formData, JSONForm1.fieldState)}}",
        fieldType: FieldType.TEXT,
        sourceData: "Test name",
        isCustomField: false,
        name: "name",
        accessor: "name",
        identifier: "name",
        originalIdentifier: "name",
        position: 0,
      },
      age: {
        isDisabled: false,
        isRequired: false,
        label: "Age",
        isVisible: true,
        isSpellCheck: false,
        children: {},
        dataType: DataType.NUMBER,
        defaultValue:
          "{{((sourceData, formData, fieldState) => (sourceData.age))(JSONForm1.sourceData, JSONForm1.formData, JSONForm1.fieldState)}}",
        fieldType: FieldType.NUMBER,
        sourceData: 20,
        isCustomField: false,
        name: "age",
        accessor: "age",
        identifier: "age",
        originalIdentifier: "age",
        position: 1,
      },
    isCustomField: false,
    name: "",
    accessor: "",
    identifier: "",
    originalIdentifier: "",
    position: -1,
  },
}

Fixes #2504
https://miro.com/app/board/uXjVOXio8tY=/
Type of change

New feature (non-breaking change which adds functionality)
This change requires a documentation update

How Has This Been Tested?

Cypress Tests
Jest Tests
Manual testing

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:red_circle: Total coverage has decreased
// Code coverage diff between base branch:release and head branch: feature/form-builder-widget

Status
File
% Stmts
% Branch
% Funcs
% Lines

:red_circle:
total
55.48 (-0.29)
37.08 (-0.05)
35.76 (-0.06)
55.84 (-0.29)

:green_circle:
app/client/src/components/ads/DraggableListComponent.tsx
41.03 (0)
18.18 (0)
33.33 (0)
44.12 (1.7)

:sparkles: :new:
app/client/src/components/editorComponents/Tooltip.tsx
100
100
100
100

:green_circle:
app/client/src/components/propertyControls/DropDownControl.tsx
89.29 (0.4)
64.71 (1.07)
71.43 (0)
88 (0.5)

:sparkles: :new:
app/client/src/components/propertyControls/FieldConfigurationControl.tsx
18.18
8.7
10
21.1

:sparkles: :new:
app/client/src/components/propertyControls/JSONFormComputeControl.tsx
25.32
11.43
13.33
26.39

:red_circle:
app/client/src/components/propertyControls/PrimaryColumnsControl.tsx
36 (0)
11.94 (-0.37)
19.23 (0)
34.97 (0)

:green_circle:
app/client/src/components/propertyControls/index.ts
86.11 (0.82)
100 (0)
0 (0)
85.71 (0.86)

:green_circle:
app/client/src/entities/Widget/utils.ts
93 (0.14)
89.13 (0)
100 (0)
92.86 (0.15)

:green_circle:
app/client/src/pages/Editor/PropertyPane/PropertySection.tsx
90.32 (0.66)
56.25 (-0.89)
83.33 (0)
89.29 (0.4)

:red_circle:
app/client/src/sagas/SnipingModeSagas.ts
19.44 (-0.56)
3.03 (-0.1)
40 (0)
20.19 (-0.6)

:green_circle:
app/client/src/utils/WidgetFactory.tsx
74.47 (0.56)
72.22 (1.63)
64.71 (0)
74.47 (0.56)

:red_circle:
app/client/src/utils/autocomplete/EntityDefinitions.ts
26.32 (-0.71)
0 (0)
12.5 (-1.79)
25.71 (-0.76)

:red_circle:
app/client/src/utils/autocomplete/TernServer.ts
52.71 (-0.23)
40.83 (-0.84)
36.21 (0)
56.74 (-0.25)

:sparkles: :new:
app/client/src/utils/hooks/useDeepEffect.ts
100
100
100
100

:green_circle:
app/client/src/widgets/WidgetUtils.ts
86 (6.63)
66.67 (16.67)
62.5 (8.65)
82.93 (8.42)

:red_circle:
app/client/src/widgets/BaseInputWidget/component/index.tsx
62.6 (-0.97)
44.85 (-1.11)
60 (-1.36)
61.6 (-1)

:red_circle:
app/client/src/widgets/CheckboxWidget/component/index.tsx
95 (-1.97)
65.71 (-2.03)
92.31 (1.4)
93.75 (-2.4)

:sparkles: :new:
app/client/src/widgets/JSONFormWidget/FormContext.tsx
100
100
100
100

:sparkles: :new:
app/client/src/widgets/JSONFormWidget/constants.ts
100
100
100
100

:sparkles: :new:
app/client/src/widgets/JSONFormWidget/helper.ts
96.1
88.24
100
96.97

:sparkles: :new:
app/client/src/widgets/JSONFormWidget/index.ts
100
100
100
100

:sparkles: :new:
app/client/src/widgets/JSONFormWidget/schemaParser.ts
98.14
88.61
100
98.73

:sparkles: :new:
app/client/src/widgets/JSONFormWidget/schemaTestData.ts
100
100
100
100

:sparkles: :new:
app/client/src/widgets/JSONFormWidget/component/Accordion.tsx
33.33
30
0
41.38

:sparkles: :new:
app/client/src/widgets/JSONFormWidget/component/Field.tsx
28.13
16.67
0
30

:sparkles: :new:
app/client/src/widgets/JSONFormWidget/component/FieldLabel.tsx
35.19
20.69
0
44.19

:sparkles: :new:
app/client/src/widgets/JSONFormWidget/component/Form.tsx
31.4
25
0
32.93

:sparkles: :new:
app/client/src/widgets/JSONFormWidget/component/NestedFormWrapper.tsx
55.56
33.33
0
55.56

:sparkles: :new:
app/client/src/widgets/JSONFormWidget/component/index.tsx
33.33
37.5
0
34.15

:sparkles: :new:
app/client/src/widgets/JSONFormWidget/component/styleConstants.ts
100
100
100
100

:sparkles: :new:
app/client/src/widgets/JSONFormWidget/fields/ArrayField.tsx
26.92
30.77
0
29.79

:sparkles: :new:
app/client/src/widgets/JSONFormWidget/fields/BaseInputField.tsx
17.71
0
0
18.82

:sparkles: :new:
app/client/src/widgets/JSONFormWidget/fields/CheckboxField.tsx
35.9
14.29
0
38.89

:sparkles: :new:
app/client/src/widgets/JSONFormWidget/fields/CurrencyInputField.tsx
23.33
0
0
25

:sparkles: :new:
app/client/src/widgets/JSONFormWidget/fields/DateField.tsx
50.63
14.63
40
50.68

:sparkles: :new:
app/client/src/widgets/JSONFormWidget/fields/FieldRenderer.tsx
18.75
0
0
21.43

:sparkles: :new:
app/client/src/widgets/JSONFormWidget/fields/InputField.tsx
15.79
10.53
20
15.79

:sparkles: :new:
app/client/src/widgets/JSONFormWidget/fields/MultiSelectField.tsx
24.44
5.71
0
30.99

:sparkles: :new:
app/client/src/widgets/JSONFormWidget/fields/ObjectField.tsx
30.43
14.29
0
33.33

:sparkles: :new:
app/client/src/widgets/JSONFormWidget/fields/PhoneInputField.tsx
22.73
0
0
25

:sparkles: :new:
app/client/src/widgets/JSONFormWidget/fields/RadioGroupField.tsx
40.74
0
0
42.31

:sparkles: :new:
app/client/src/widgets/JSONFormWidget/fields/SelectField.tsx
25.4
4.08
0
28.57

:sparkles: :new:
app/client/src/widgets/JSONFormWidget/fields/SwitchField.tsx
35.29
0
0
37.5

:sparkles: :new:
app/client/src/widgets/JSONFormWidget/fields/index.ts
100
100
100
100

:sparkles: :new:
app/client/src/widgets/JSONFormWidget/fields/useBlurAndFocusEvents.ts
12.5
0
0
12.5

:sparkles: :new:
app/client/src/widgets/JSONFormWidget/fields/useRegisterFieldInvalid.ts
95.24
100
100
94.74

:sparkles: :new:
app/client/src/widgets/JSONFormWidget/fields/useUpdateInternalMetaState.ts
30.77
0
0
30.77

:sparkles: :new:
app/client/src/widgets/JSONFormWidget/widget/helper.ts
98.28
87.5
100
98.15

:sparkles: :new:
app/client/src/widgets/JSONFormWidget/widget/index.tsx
35.87
0
24
36.78

:sparkles: :new:
app/client/src/widgets/JSONFormWidget/widget/propertyConfig.ts
53.85
0
25
50

:sparkles: :new:
app/client/src/widgets/JSONFormWidget/widget/propertyConfig/generatePanelPropertyConfig.ts
42.11
15.38
16.67
38.89

:sparkles: :new:
app/client/src/widgets/JSONFormWidget/widget/propertyConfig/helper.ts
86.79
66.67
90.91
85.11

:sparkles: :new:
app/client/src/widgets/JSONFormWidget/widget/propertyConfig/properties/array.ts
55.56
100
0
55.56

:sparkles: :new:
app/client/src/widgets/JSONFormWidget/widget/propertyConfig/properties/checkbox.ts
45.45
100
0
45.45

:sparkles: :new:
app/client/src/widgets/JSONFormWidget/widget/propertyConfig/properties/common.ts
20.83
0
11.11
21.74

:sparkles: :new:
app/client/src/widgets/JSONFormWidget/widget/propertyConfig/properties/date.ts
30.77
100
0
30.77

:sparkles: :new:
app/client/src/widgets/JSONFormWidget/widget/propertyConfig/properties/index.ts
100
100
100
100

:sparkles: :new:
app/client/src/widgets/JSONFormWidget/widget/propertyConfig/properties/input.ts
10.42
0
0
10.42

:sparkles: :new:
app/client/src/widgets/JSONFormWidget/widget/propertyConfig/properties/multiSelect.ts
71.19
90
46.67
69.81

:sparkles: :new:
app/client/src/widgets/JSONFormWidget/widget/propertyConfig/properties/radioGroup.ts
55.56
100
0
55.56

:sparkles: :new:
app/client/src/widgets/JSONFormWidget/widget/propertyConfig/properties/select.ts
59.46
85.71
22.22
61.11

:sparkles: :new:
app/client/src/widgets/JSONFormWidget/widget/propertyConfig/properties/switch.ts
45.45
100
0
45.45

:red_circle:
app/client/src/widgets/MultiSelectWidget/component/index.tsx
18.84 (-0.56)
0 (0)
0 (0)
20 (-0.63)

:red_circle:
app/client/src/widgets/MultiSelectWidgetV2/component/index.tsx
12.5 (-0.27)
0 (0)
0 (0)
14.12 (-0.34)

:green_circle:
app/client/src/widgets/SwitchWidget/component/index.tsx
94.12 (0.37)
62.5 (0)
50 (0)
94.12 (0.37)

:green_circle:
app/client/src/workers/evaluationUtils.ts
61.96 (3.59)
58.73 (1.59)
66.13 (1.61)
59.94 (2.24)

:green_circle:
app/client/src/workers/validations.ts
81.95 (0)
72.33 (1.1)
76.67 (0)
83.39 (0)

/ok-to-test sha=95d6518

/ok-to-test sha=5768cd5

/ok-to-test sha=f378e2e

/ok-to-test sha=3ebbedf

/ok-to-test sha=dc3b903

/ok-to-test sha=191be47

/ok-to-test sha=7bcf124

/ok-to-test sha=641dca2

/ok-to-test sha=dc50cc1

/ok-to-test sha=efe0836

/ok-to-test sha=7d37f1f

@ashit-rath Please look into few observations, I am still testing the feature.

Connect data message is displayed on widget for a sec before loading the default data
Removing sample data do not make the widget blank
https://www.loom.com/share/3e8e343aec264f33af079963960b9885
Writing source code for multi-select widget still shows default data in drop-down https://www.loom.com/share/83c03bae8ce6473bb9d8618d02dd73b1
After I make any change in the form like delete or add and then refresh the page the source code data is updated https://www.loom.com/share/47dcd16b8e5344c48d5b901d3c5c6ac4
Sequence of form changes when we make any change in source data https://www.loom.com/share/2ef1480fb3d54a66b013fc6caea50093
Changing widget type to Text input displays object by default in field https://www.loom.com/share/9deb7d0a66d04cc5b24a108fb162fa8e

@vivekverma2312

1 Connect data message is displayed on widget for a sec before loading the default data

I'll fix this

Removing sample data do not make the widget blank

It's a safety mechanism, there would be cases where the source data might get undefiend or empty object from an API that is still fetching the data. If we try to process undefined or empty data then the user might lose field configuration.

Writing source code for multi-select widget still shows default data in drop-down

The multi-select field gets default options, that have to be modified by the user. We do not process the default value as options as that might be destructive as the default value might change and we would have to update the options which can get messy.

After I make any change in the form like delete or add and then refresh the page the source code data is updated

Whatever you enter in the form is metadata i.e it is only persisted until you are active on the page. It's similar to the input widget having some default data and upon refresh that is again set.
Similarly array field as some default value i.e 2 entries curefit and appsmith.
So on refresh, the same default value of the array is applied.

5 Sequence of form changes when we make any change in source data

Yeah, it is considered as a new entry (as the property name changes) and get's added at the end. You can reposition is in the property pane Field Configuration

6 Changing widget type to Text input displays object by default in field

This seems to be a bug

@ashit-rath
7. After clicking on add new and deploy the new fields are not displayed. similar behaviour for delete. it deploys the source code data.
https://www.loom.com/share/17ca6ef8f58e4f03920d6e900c764b53
8. Date widget is getting highlighted in blue colour but all other fields ate highlighted in green colour.

/ok-to-test sha=d11fa49

After clicking on add new and deploy the new fields are not displayed. similar behaviour for delete. it deploys the source code data.
For arrays using the Add New button won't  define how many entries you would have in the deploy mode. It is similar to how entering some text in an input field won't define what the value of that input field would be in the deploy mode.

For changing how many entires show up, you would have to change the default value of the array field in the property pane.

Date widget is getting highlighted in blue colour but all other fields ate highlighted in green colour.
This has to be fixed in the individual widgets itself.

/ok-to-test sha=b90a57d

@ashit-rath
9. Fixed footer in view mode is not proper. It is showing outside the form and at bottom of the page. In case of multiple forms also only one button is displayed.

Valid property is throwing error

@ashit-rath I am also testing this PR and have few observations to share

Phone Number Input is accepting Characters
https://www.loom.com/share/8d41c59a86c248da9fa37c3320fcce67

There is no scroll in dropdown of Field type and Date format dropdown(Select field type as date and see option of Date format)
https://www.loom.com/share/f5aed183405e46e1ae3a750ee64a711f

Convert to ISO isn't working for Date Picker field type
https://www.loom.com/share/9dbce6206c9c485dac5eb35059e50154

While adding Date picker inside Array displays "Invalid date" by default
https://www.loom.com/share/fb982b15a35d46a49249e1c2cfa12ffe

Delete Button doesn't work when Array item of an Array is invisible
https://www.loom.com/share/5c1b9c9d1d094ac08da8759e7738a52b

@ashit-rath 9. Fixed footer in view mode is not proper. It is showing outside the form and at bottom of the page. In case of multiple forms also only one button is displayed.

Valid property is throwing error

For 10. There is a () after name
Should the binding look like this?
{{formData.name.FirstName.length > 5}}

@chandannkumar

Phone Number Input is accepting Characters

I'll look into this

There is no scroll in dropdown of Field type and Date format dropdown(Select field type as date and see option of Date format)

This is an issue with every dropdown field in the property pane and I think the UI builders pod are looking into it.

Convert to ISO isn't working for Date Picker field type

The convert to ISO does not change the value that you see in the input to ISO but changes the value of that particular field in the formData property. Try binding JSONForm1.formData to a text widget and toggle this.
Do you think we should update the hint of this property in some way to help user understand this better.

4 While adding Date picker inside Array displays "Invalid date" by default

I will check this

5 Delete Button doesn't work when Array item of an Array is invisible

Nice catch! I'll look into this as well

/ok-to-test sha=060283b

/ok-to-test sha=384e28f

/ok-to-test sha=8bafdd4

/ok-to-test sha=17f43c3

@ashit-rath Please look into these observations also:

App crash right after adding Json form widget onto canvas
https://www.loom.com/share/10950135f2444eb6a49fe42b84d5cf43

App crash when using array at starting of the source code in view and edit mode
https://www.loom.com/share/bb7b5420861744d48a28d7e88ee46349

App crash after changing the existing Input type field to Array field
https://www.loom.com/share/2f203737cf9f4bf29fe6162a313ca10f

Behavior on adding multiple objects in an array. In video it shows: when we add objects with same name, its creates 1 Array items and only 1 field configuration, but when i tried to add new object with same name but in lower case, a new field got added inside the array item
https://www.loom.com/share/449d0f20c1b24d26a9607283afc99371

Unable to view icon dropdown after click on icon field of submit and reset button

/ok-to-test sha=c8ec98d

@chandannkumar

Behavior on adding multiple objects in an array. In video it shows: when we add objects with same name, its creates 1 Array items and only 1 field configuration, but when i tried to add new object with same name but in lower case, a new field got added inside the array item

Yes the keys are case sensitive so the behaviour you are seeing is valid.

Unable to view icon dropdown after click on icon field of submit and reset button

This is being fixed in another PR #11736

/ok-to-test sha=ba1aad4

/ok-to-test sha=a359612

/ok-to-test sha=162ccae

/ok-to-test sha=230dba0

/ok-to-test sha=230dba0

/ok-to-test sha=bad7ecf

@ashit-rath
This feature PR has been Tested and working as expected.
Also all the reported bugs are fixed and verified.

/ok-to-test sha=59ab73e

/ok-to-test sha=59ab73e

/ok-to-test sha=6b0bb00


#130 - HMDA upload

I think/hope I was able to roll the marble end-to-end and add 250MB of Home Mortgage Disclosure Act records to the project, per issue #130.
I followed all steps in the how-to guide to get the records cleaned and added to the Postgres db, as well as push a copy of the raw records to the S3 bucket.   I did not attempt to join the new table to any other tables in the db, although I did add a function to my cleaner class to make sure that the value we can use for that join (census_tract_number) is consistent with what's already in the db.  I will play around with the joins next.
This is the first pull request I've submitted on this project, and I'm very much an amateur at Python, so please don't hesitate to let me know if I messed something up.

@emkap01 I was able to get this to run on my machine and successfully imported the data - good stuff! Just a couple minor edits and this will be good to go.

@emkap01 it doesn't look like any new commits have been added - have you pushed your upates yet?

Apparently I screwed something up - it looks like I overwrote the files in my pull request when I was trying to remove the docker-compose.yml file, because the versions I included in the pull request no longer exist in my local or remote repos.  If you have the ability to resolve the issue from your end, go ahead, otherwise we can just fix it on Tuesday night.

@emkap01 I can use the copy I pulled to fix it - will do that before Tuesday's session and we can make sure it's all squared away then.

I've got the docker-compose.yml file on my repository and local drive.  Let me know if you need it.

As discussed I'm just going to close the pull request, delete the branch, then create a new branch with the correct files and submit a new pull request based on that.


Some features for notemaking

Feature/enhancement Description:

This is an impressive note-making app. So I would like to thank all the contributors for their efforts in building this application.
I would like to point out a missing feature that will be helpful for most users who use this software for note-making.

Currently there is no option to scroll across the infinite canvas at a fixed zoom level. To move downwards one has to first zoom in at some bottom point and then zoom out at some top point. I request the contributors to add this feature so that one can move across the canvas easily.

Unlike drawing, note-making does not need a canvas that is infinitely sized horizontally. One direction is often sufficient. Maybe we can have a note-making mode when the canvas extends to infinity only in the vertical direction.

It would be helpful if we have more than one canvas in a file for easy organization of topics.

Not sure if i understand you correctly. You can pan across the canvas using the middle mouse button.
No, i don't want to add a vertical only mode. If you don't need the horizontal space just don't use it ;)
I get what you mean, but that kinda goes against the keep it simple philosophy of this app. It's also why i don't want to add layers. Just use multiple files.


JAMES-3986 AttachmentFileNameIs should be decently tested

This changeset contributes a decent test suite with a coverage of 82% (remains logging and error handling).
It decodes file names if needed.
As such remove experimental marking.
(Needed by one of my customer)

@jeantil maybe?
(VN coworkers are off for the Tet)

Thanks Jean!


Update multihead_attention.py

just updated a minute error dropout was set to int instead of float.
it was defined as dropout : int = 0.0
changed to dropout : float = 0.0
<!-- Thank you for contributing to Zeta!

Replace this comment with:
  - Description: I just updated a minute error dropout was set to int instead of float.
  - Dependencies: no dependencies required for this change,
  - Tag maintainer<EMAIL_ADDRESS>  - Twitter handle: This minor change isn't worth it

@viai957 thanks for the catch!


Feature/groupby2

Groupby features introduced: delta mean, delta median, min, max, std, cat mode. Config files updated, the features are not used by default.

@VaBun

You need to add demo14 to https://github.com/sb-ai-lab/LightAutoML/tree/master/examples/README.md
Add short description for PR
May be add this functionality to some tutorial? Existing or new
demo14.py doesn't work, have you tried to run it?
My comment about "verbose" from previous PR was ignored

All these GroupBy... classes don't need fit stage, so I'd like to simplify all classes from lightautoml/transformer/utils.py file


refactor(Application/ApplicationServiceRegistration): Added the BaseBusinessRules and AddSubClassesOfType method

Added the BaseBusinessRules to the core.Application.Rules and inherited all BusinessRule classes from it. Now we can register all BusinessRule classes by calling the new AddSubClassesOfType method.
Future feature: Since we will not have to add the BusinessRules to the registration, the BusinessRule classes can be separated now regarding the Commands and Queries, like CreateBrandBusinessRules, UpdateBrandBusinessRules etc.

In addition, it would be great if you could resolve conflicting files.

Conflicts are resolved.

Fixed the extra merge commit. There is a single commit now.

Looks good to me. Thanks for your contribution.


make filter docs less confusing

Edits looks good,
but the fact this is necessary makes me think we have not named the props correctly


contributing template in spanish

This template helped a lot the organization I work with and also my own side open source projects I think It might help a lot of people that doesn't speak english and also maintains foss projects.
I would like to completely translate this guide so you can have it able also in spanish.
What you think? Can I help with that?

Hi @valerybriz, absolutely! 😊 Feel free to translate on a new repo and submit a PR to link from this one when ready. Can follow a format like this one: https://github.com/nayafia/lemonade-stand for listing out translations.

Awesome! I'll be working on it :)

Hey! I just submited a pull request with the traslation on #15

Closing here to continue discussion on #15