add sharing codes functionality

Summary
Test Plan

Please consider the impact of your changes on the other developers.

#32  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Silver-Sword and the rest of your teammates on  Graphite


Add tracing for incoming requests

This PR adds support for tracing incoming HTTP requests for the two webhooks.
It produces traces like the following, with nested spans for each of the HTTP calls:

I've used OpenTracing here over OpenTelemetry in the interests of consistency with Mimir.
I don't love how invasive these changes were - the default OpenTracing instrumentation for net/http requires calling nethttp.TraceRequest() for each outgoing HTTP call, but any other option would require either creating our own OpenTracing instrumentation for net/http, or using OpenTelemetry, which would break with the existing pattern of Mimir. I'm very open to other ideas or suggestions.
I don't believe we can't add tracing for Kubernetes API calls made by the informers used in the reconciliation loop, as these run outside the context of a parent span, so I haven't added tracing to the reconciliation loop beyond a single span.

Apologies @charleskorn, I merged too early. I reverted the commit and restored the branch so you could respond to the above in a reopened PR.

No worries, I'll continue in #114.


Configurable number of lines below cursor-line

As you navigate downwards in a file Atom always keeps two lines below the current cursor-line. In the screenshot pressing ctrl-n or ⬇ once will bring line 55 into view.

Could this number of lines be made configurable?

I think you might be looking for TextEditor::setVerticalScrollMargin. As far as I know, there isn't a configuration parameter for it, but you can put the following in your init script:
atom.workspace.observeTextEditors (e) -> e.setVerticalScrollMargin(n)

So that, when you go up or down with the cursor, you always have n rows as your margin.


Personal library

Related Issue

#280

Closes: #[issue number that will be closed through this PR]
Describe the changes you've made
This is simple personal library which keeps track of our books. It displays the status of book ie, if read or not. We can also remove books from library if needed.
Describe if there is any unusual behaviour of your code(Write NA if there isn't)
NA
Checklist:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] New and existing unit tests pass locally with my changes.

Screenshots
Put any screenshot(s) of the project here.

Add the project to script.js.

There are lot of files unncessary have been changed due to merging.
What you could do to fix it
1.You could revert back.
2. Create a new branch add the code to it and make a new PR. (easy)
Sync the main branch -> create a new branch -> add your code -> PR this will be easy option.
Just copy the files from this branch keep it somewhere
Make sure you sync the main branch by pulling from upstream
create a new branch add code there and also add add lines in script.js and make new PR.

@ireneelizabethsabu The library project has been added named Library-app, what you should do is replace that one with yours,
try to fix the above so many commits if you want to work on this PR, If not able to fix you can make a new PR,
sync the main branch -> create a new branch ->  add the code -> push and new PR this is easy option.


Swift error

swift run tools which is part of the ╰─ bundle exec fastlane update_font version:6.2.1 command
warning: 'fontawesome.swift': 'tools' was identified as an executable target given the presence of a 'main.swift' file. Starting with tools version 5.4.0 executable targets should be declared as 'executableTarget()'
Building for debugging...
Build complete! (0.12s)
Swift/ErrorType.swift:200: Fatal error: Error raised at top level: Swift.DecodingError.typeMismatch(Swift.String, Swift.DecodingError.Context(codingPath: [_JSONKey(stringValue: "expeditedssl", intValue: nil), CodingKeys(stringValue: "svg", intValue: nil), _JSONKey(stringValue: "brands", intValue: nil), CodingKeys(stringValue: "viewBox", intValue: nil), _JSONKey(stringValue: "Index 0", intValue: 0)], debugDescription: "Expected to decode String but found a number instead.", underlyingError: nil))
[1]    87389 trace trap  swift run tools

if you look at icons.json, viewBox is now an int instead of a string. so you need to update main.swift to reflect that
struct SVG: Codable {
    let last_modified: UInt
    let raw: String
    let viewBox: [UInt]
    let width: UInt
    let height: UInt
    let path: Path
}


Add mapping dialog warning

closes #483
prerequisites:

[x] branch is up-to-date with the branch to be merged with, i.e. develop
[x] build is successful
[x] code is cleaned up and formatted

Summary
add a static warning:

Thanks for implementing this warning. Is it possible to show this warning only if the input domain has been changed? This would cause less confusion to users.

Thanks for implementing this warning. Is it possible to show this warning only if the input domain has been changed? This would cause less confusion to users.

done


curl_error must be called before curl_close

curl_error can't fetch error info from closed curl session.
First comment https://www.php.net/manual/en/function.curl-error.php
https://stackoverflow.com/questions/19442999/getting-curl-error-2-is-not-a-valid-curl-handle-resource-while-fetching-all-u

...
 $curl_error = curl_error($curl);
        $info = curl_getinfo($curl);
        $this->curlInfo = $info;

        curl_close($curl);

        if (!$response) {
            $httpCode = curl_getinfo($curl, CURLINFO_HTTP_CODE);

            // Debugging output
            $debugMessage = "cURL error: " . $curl_error . PHP_EOL .
                "HTTP code: " . $httpCode . PHP_EOL .
                "Request URL: " . $url . PHP_EOL .
                "cURL info: " . print_r($info, true);

            throw new Exception($debugMessage);
        }

--- @MAIKS1900


added missing app

added missing app

Refer to this link for build results (access rights to CI server needed):
https://fabric8-ci.fusesource.com/job/fabric8-quickstarts-master-pullreq/335/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
https://fabric8-ci.fusesource.com/job/fabric8-quickstarts-master-pullreq/336/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://fabric8-ci.fusesource.com/job/fabric8-quickstarts-master-pullreq/337/
Test PASSed.


Add lint-staged config

It will run the linter on commit and the unit test on push
Let me know if you're okay with run the linter with the fix flag.

Hi! @DannyFeliz
I saw that the changes of this PR were:

Configuration of Lint-Staged
Configuration of Husky (it's a dependency of Lint-Staged).

But currently, the project has a configuration for both lint-staged and husky but they are dedicated files called: .lintstagedrc and .huskyrc.
This PR raise me a question and its the following: ¿Is it more common in js projects to add lint-staged and husky configuration in the package.json file of the project?
If the answer is yes, then I'll suggest that you remove both .huskyrc and .lintstagedrc since they will be useless.
If the answer is no, then I'll suggest closing the PR since we already have files that configure .huskyrc and .lintstagedrc. But we should add the pre-push hook to the configuration.


#1010

Signed-off-by: wanghongyan<EMAIL_ADDRESS>
What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note:

fix  #1010


Fix router-outlet destroy issue

References

Fixes #1544

Description
This PR fixes problems reported in the issues by avoiding the router-outlet in the root.component is destroyed every time the full page loader is displayed (more detail here https://github.com/DSpace/dspace-angular/issues/1544#issuecomment-1056843963)
Instructions for Reviewers
Follow steps described in the issue #1544 and check the problems no longer occur
List of changes in this PR:

use display none instead ngif to hide outer-wrapper
full screen loader is used only for theme changing and authentication loading

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

[x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
[x] My PR passes TSLint validation using yarn run lint
[x] My PR doesn't introduce circular dependencies
[x] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
[x] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
[x] If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

@tdonohue
problem with sidebar menu should be fixed now, could you review it again?

@atarix83 : This PR now appears to have merge conflicts. Could you get them resolved please?  It appears they came about when you pushed your last commit... so maybe your branch just isn't updated to the latest main?


Fix typo in zsh installation instructions

Refs #1127 and just fixes a small typo to make the installation instructions actually work.

Codecov Report

Merging #1158 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1158   +/-   ##
=======================================
  Coverage   62.55%   62.55%
=======================================
  Files         184      184
  Lines       10268    10268
=======================================
  Hits         6423     6423
  Misses       3044     3044
  Partials      801      801

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49d5637...8f89e79. Read the comment docs.


IDs in Attributes

IDs are still present in attributes when looking at a product.
eg. category/product#/13-color-orange
Is there any way to remove the ID from attributes also?

Nowadays it is not supported .. Will look deeper for a future implementation

@pixelremix I think this is an issue with your theme ..
AFAICS this URL is correct https://zizuu.com/calamite-da-collezione/#/Prezzo-5.24-11 .. isn't it?
Waiting for your feedback, thanks

@ZiZuu-store I'm using the default theme.
That URL is correct, but that item doesn't have extra attributes.
For example, this item from your store
https://zizuu.com/stampi-in-silicone-per-muffin-e-cupcake/stampi-mignon-micro-bundt-cake-nordic-style-in-silicone-3pz#/11-colore-fucsia
You can see that ID 11 is added to the color fuscia, and any other color variant there is an ID.

@pixelremix OK got tour point
Will go deeper ..
Thanks

I would like to say that those are not real PHP "rewritten url", those are hashes used only by javascript to select the correct image, highlight the variations and such minor aestetic differences, but the page is not reloaded, the javascript doing that is product.js and I think this has nothing to do with this module and it's out of it's scope.
an hash is not part of the url and can be anything the page will still work, example:
https://zizuu.com/stampi-in-silicone-per-muffin-e-cupcake/stampi-mignon-micro-bundt-cake-nordic-style-in-silicone-3pz#/11-look-at-this-hash-with-some-random-text-it-still-highlight-the-FUCSIA-because-there-is-eleven-MAGIC!!
https://zizuu.com/stampi-in-silicone-per-muffin-e-cupcake/stampi-mignon-micro-bundt-cake-nordic-style-in-silicone-3pz#OH-MY-GOD-LOOK-AT-THIS FUNNY-URL!!!!!!-here-there-is-no-fucsia-selected
More than this using a different theme could change that behaviour. since it is at theme level
I think this module should keep doing and improving what is doing best.
Just my 2 cents :)

@misthero thank you for your explanation and I'm of your opinion too.
I think tomorrow will close this issue if neither the night nor anybody else will rise any opposition :)

@misthero thank you for your explanation and I'm of your opinion too.
I think tomorrow will close this issue if neither the night nor anybody else will rise any opposition :)

As this is a JS issue and this module can't handle it, even willing I close this issue.
I think js ids do not affect SEO, at least when not in the form #! that is used for AJAX
Thank you everybody


oras: 0.15.1 -> 0.16.0

Description of changes
https://github.com/oras-project/oras/releases/tag/v0.16.0
and enable completions

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 204678 run on x86_64-linux 1

1 package built:

oras


DEP: remove scipy.misc

Whilst the scipy.misc module documentation states that scipy.misc is slated for removal in 2.0.0, every piece of functionality has been deprecated since 1.10, with a view to their removal in 1.12. We're now preparing v1.15.0.
This PR removes scipy.misc.

Related: https://github.com/scipy/scipy/issues/19072

That issue suggested four releases instead of the two. It's already had four, so we should be good?

We didn't really announce a change of plan, but in principle I'd be okay with pulling this forward. 🤷♂

From our experience with imsize and other removals happened around version 1.0, it took like 6 versions to get the impact disappear.
But on the other hand if we don't remove nobody takes action because many codebases silence warnings which is very annoying.
So indeed we are choosing the lesser evil here.

A bunch of the 2.0-level removal discussion centered on leaving the module itself in place, even if it's empty.  just tried
>>> from scipy import misc    # pity that neither of these warns...
>>> from scipy.misc import *  # ... which I guess is partly the reason for the 2.0 distinction
>>> misc.ascent()
<stdin>:1: DeprecationWarning: scipy.misc.ascent has been deprecated in SciPy v1.10.0; and will be completely removed in SciPy v1.12.0. Dataset methods have moved into the scipy.datasets module. Use scipy.datasets.ascent instead.
# same for misc.face() / misc.electrocardiogram()

IOW, all the content of scipy.misc has been promised to be removed in 1.12 (and we missed following through), c.f. #15901.
https://github.com/scipy/scipy/blob/5f637978f12b110531231dafb24aa33b6421e577/scipy/misc/__init__.py#L36
So the only question here is IMO whether we want to leave an empty (but importable) shell of scipy.misc. The content can be deleted though without undue risk AFAICT.

Thanks @andyfaff. It seems safe to remove all the content, since we've followed our normal deprecation policy for that. But there have been notices that the namespaces scipy.misc, scipy.misc.common, and scipy.misc.doccer` would not be removed until 2.0, so we should probably leave the shells. Maybe emit warnings when these are imported?
Also, it looks like test_doccer and test_config are no longer related to scipy.misc, but might still be useful. Maybe move test_doccer to _lib/tests? Perhaps test_config can go there, too, if it's still needed.

Last commit replaces the scipy.misc, scipy.misc.common, scipy.misc.doccer namespaces. Otherwise all the functionality is removed.

Great! If there are no new objections, it sounds like we can merge this before branch.
Did you have thoughts about the second part of the comment?

Also, it looks like test_doccer and test_config are no longer related to scipy.misc, but might still be useful. Maybe move test_doccer to _lib/tests? Perhaps test_config can go there, too, if it's still needed.

Have re-added the tests because I think they're actually testing functionality that we still use.

I think the remaining test fails are due to #21988

@h-vetinari you noticed that the imports don't warn - how do the new warnings upon import look to you?

Can't test this right now (travelling) - could you post the result of importing scipy.misc in a repl (either from this PR or main)?

From PR:
>>> import scipy.misc
<python-input-0>:1: DeprecationWarning: scipy.misc is deprecated and will be removed in 2.0.0
  import scipy.misc

>>> from scipy import misc
<python-input-0>:1: DeprecationWarning: scipy.misc is deprecated and will be removed in 2.0.0
  from scipy import misc

From main:
>>> import scipy.misc
>>> from scipy import misc

Thanks, that sounds great to me!

Thanks @andyfaff @h-vetinari! Follow-up discussion at https://github.com/scipy/scipy/issues/15765#issuecomment-2519263147.


Add libasound dependency

Probably needed for some websites with sound.
Will need to rebuild the base image

Looking at https://www.codeweavers.com/support/wiki/Diag/MissingLibAsound


possible to package hackpad inside astilectron

Hey @onebyonetwo, can you elaborate a bit? Is the ask for a native app?

Closing, since we haven't heard back. Leave a comment if you'd like to reopen with details!


Use of fstrings (Python)

What happened:
In Python 3.6 the fstrings feature was added, when using it in the PostgreSQL connection, the HorusecEngine tool identifies an information leak but this is incorrect because password is a variable:
Language: Leaks
Severity: CRITICAL
Line: xx
Column: xx
SecurityTool: HorusecEngine
Confidence: MEDIUM
File: /path/to/file.py
Code: return f"postgresql://{user}:{password}@{host}/{database}"
Details: Password found in a hardcoded URL
A password was found in a hardcoded URL, this can lead to not only the leak of this password but also a failure point to some more sophisticated CSRF and SSRF attacks. Check CWE-352 (https://cwe.mitre.org/data/definitions/352.html) and CWE-918 (https://cwe.mitre.org/data/definitions/918.html) for more details.
Type: Vulnerability
ReferenceHash: xxxxxxxxxxxxx

What you expected to happen:
The HorusecEngine tool can identify variables in an fstring in Python code.
How to reproduce it (as minimally and precisely as possible):

Create a file with this content:

def get_postgres_uri(host: str, password: str, user: str, database: str)-> str:
    return f"postgresql://{user}:{password}@{host}/{database}"

Run horusec start -p="./" -e="true".

Environment:

Horusec version: v2.5.0 / dist normal
Operating System: Ubuntu 20.04

Unfortunately this is something we can't fix, as a SAST tools there is some vulnerabilities we still can't ensure wether is as hardcoded password or not. We're working on semantic analyisis as you can check on or roadmap (english version in WIP) to fix this problem and many others.
Thanks for the feedback and feel free to ask as many questions as you want.


Support generating shell completions

closes #232

Quick question, who's expected to run these shell completions and where should they be saved to? Obviously through pacman will set them up automatically I presume but what about installing directly through cargo?

Quick question, who's expected to run these shell completions and where should they be saved to? Obviously through pacman will set them up automatically I presume but what about installing directly through cargo?

This is mainly for distro packages, for example, you can install shell completions for Atuin on Arch Linux like this:
install -Dm 644 "completions/atuin.bash" "/usr/share/bash-completion/completions/atuin"
install -Dm 644 "completions/atuin.fish" -t "/usr/share/fish/vendor_completions.d"
install -Dm 644 "completions/_atuin" -t "/usr/share/zsh/site-functions"

More info: https://wiki.archlinux.org/title/Shell_package_guidelines#Shell_completions
Since they have to be placed into an appropriate location based on the current platform, I don't think they can be installed directly through cargo install.

I'm happy with this. Considering whether we should move to running in a build script but overall I have no real preference either way.
Thanks for your contributions, I'll wait for @ellie to take a look

How can I output the completion to stdout?

How can I output the completion to stdout?

You could generate them into a local or a temp dir, then cat the contents


Debug panel show one query (fetch cursor id = 0)

Still shows the fetch cursor id = 0 in the debug panel.
https://github.com/yiisoft/yii2-mongodb/issues/126

Q
A

Yii version
2.0.11 dev

Yii MongoDB version
2.1.2

MongoDB server version
3.2.7

PHP version
7.0.1

Operating system
Windows 10

This is expected.
There are always 2 log entires per each mongo query: one for the find command the second - for the cursor fetching.

I can see no issue here.


RFC: "Untrusted" Layer Addition

RFC for @lordnynex @asciifaceman @smaslennikov @catherinetcai @taup1n
Proposal
I propose adding another layer to the layers that we have for third party services which are trusted less. I am not set on the name, but "untrusted" is a candidate, I hope we can come up with something better.
Titan has the following layers presently:

DMZ (WAN-facing resources)
Routing (Internal layer 5 and 7 routing)
Services (Internal backend services and asynchronous workers)
Data (Internal data stores)
Admin (Internal administrative services)

I recently witnessed a contractor creating an entirely separate VPC for a Nominatim cluster, which is a third party location database. I am not entirely sure of the usefulness, hence the RFC. Running a service like this in an "untrusted" layer would allow tighter security rules for this area of the network in NACLs and security groups.
Pros

Network confinement for third-party untrusted services.

Cons

Is it really needed?
Does it really benefit and add to Titan?

I'm not sure this is needed, as all daemon software we run is potentially untrusted and may or may not communicate with outside services. If I understand correctly, Nominatim is no different.
Another question is, how would this layer be different technically?

@lordnynex yes this makes sense to me too. Everything is going to be confined by security groups anyway.
The only thing I see would be ading NACL rules to disallow all SSH access coming out of this new layer.
I will probably close and reject this, but I'll also wait for @taup1n @catherinetcai and @asciifaceman.

Okay, done waiting. Closing this because there is no good justification for it.
If you feel that you have a use case for this, simply tightly couple security groups and possibly add TLS if your security use case needs internal TLS.

For example, consider an ELK stack composed of static EC2 Elasticsearch instances, an Elasticsearch ELB, a Kibana instance, a Logstash auto-scaling group, and a Logstash ELB.
Here's a first go at a Kibana security group using CIDR-based loose coupling:
kibana/r.security_groups.tf
resource "aws_security_group" "kibana" {
  name = "..."
  description = "..."
  vpc_id = "${data.terraform_remote_state.network.vpc_id}"
  ingress {
    protocol = "tcp"
    from_port = 80
    to_port = 80
    cidr_blocks = ["${data.terraform_remote_state.network.routing_cidr_blocks"]
    ipv6_cidr_blocks = ["${data.terraform_remote_state.network.routing_ipv6_cidr_blocks"]
  }
}

This will allow all traffic from the routing layer to Kibana. The design of the routing layer is to provide layer 5 and 7 routing, so it makes sense that it will need to route into Kibana to be able to serve the UI over WAN if desired. (Put it behind authentication, you've been warned.)
Here's an example of tight coupling:
kibana/r.security_groups.tf
resource "aws_security_group" "kibana" {
  name = "..."
  description = "..."
  vpc_id = "${data.terraform_remote_state.network.vpc_id}"
  ingress {
    protocol = "tcp"
    from_port = 80
    to_port = 80
    self = true
    security_groups = ["${data.terraform_remote_state.routing.instance_security_group_id}"]
  }
}

With this tightly-coupled security group, we can only permit traffic directly from routing instances to the Kibana instance. No other traffic will be allowed. Via self = true, Kibana will be able to remotely access itself without the loopback interface.
This same example can be generalized to all of the ELK services. Tightly coupled security groups would look like this:

Elasticsearch Instances: Only allow TCP:9200 and TCP:9300 from the Elasticsearch load balancer and from Elasticsearch instances themselves. This means that all traffic to Elasticsearch must go through the load balancer except for inter-node communication.
Elasticsearch Load Balancer: Only allow TCP:9200 and TCP:9300 from Kibana and Logstash instances. This prevents an adversary in the network from accessing Elasticsearch from non-Kibana and non-Logstash nodes.
Logstash Instances: Only allow TCP:5140 from the Logstash load balancer.
Logstash Load Balancer: Allow syslog incoming traffic over TCP:514 (forward to instances on TCP:5140) from anywhere in the network, or in the case of a hub-spoke, any of the child networks via a list of IPv4 and IPv6 CIDR blocks. This is probably what you want if you're forwarding syslog to Logstash.
Kibana: Only allow TCP:80 from the routing layer CIDR blocks or specifically from your routing service's security group.

The above would have the following implications:

Nobody can access Kibana except for your routing service(s).
Nobody can access Logstash nodes except via the ELB.
Nobody can access Elasticsearch except via the ELB.
Nobody can access the Elasticsearch ELB except Logstash and Kibana instances.
The entire network can forward syslog traffic to the Logstash ELB.

The only way to make this more secure IMHO is to add TLS at all the hops, but that complicates the design tremendously and would mean TLS deployment for most internal services.

Phew. I'm closing this.


Support for GPT4-8k

Now, GPT4 is available for all developers but BetterChatGPT does not support it.
Check here for the new update: https://openai.com/blog/gpt-4-api-general-availability

Actually, it is only open up to existing API developers with a history of successful payments.

Is possible add the support for GPT4-8k for azure api, it is default enabled

Even Azure OpenAI needs additional application for GPT-4 models.


Feature request: deterministic randomization

Would be great if we could get deterministic randomization using a seed

This might just not be documented. Possibly options.rng?

@simlu As documented in the API,  options.rng can be used to do that.
You can see an example here, since shuffle-obj-arrays has the same API as shuffle-array.


Revert "[CI] MeshKit Error Util: duplicate errors causing failures"

Reverts meshery/meshery#8402
@suhail34 this change is causing failures in a number of the PRs that are attempting to be merged. Will you approach this change again in a new PR and ensure that we have coverage in other files for things like:
# github.com/layer5io/meshery/server/helpers
../helpers/error.go:141:20: undefined: ErrDeployingAdapterInK8sEnvCode
../helpers/error.go:145:20: undefined: ErrUnDeployingAdapterInK8sEnvCode
../helpers/error.go:149:20: undefined: ErrDeployingAdapterInDockerEnvCode
../helpers/error.go:153:20: undefined: ErrUnDeployingAdapterInDockerEnvCode
../helpers/error.go:157:20: undefined: ErrDeployingAdapterCode
../helpers/error.go:161:20: undefined: ErrUnDeployingAdapterCode

I have to solve it again now the whole set of duplicacy occurred again 🥲


Section referenced, does not exist

COMException description says "see the Error Codes section below" but there is no Error Codes section anywhere on the page.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0645ed9f-c0d8-a8a2-5d1d-8fc16fea0690
Version Independent ID: 071bbfc6-4522-38e8-4074-4c94471060cb
Content: UploadOperation.StartAsync Method (Windows.Networking.BackgroundTransfer) - Windows UWP applications
Content Source: winrt-api-build/xml/Windows.Networking.BackgroundTransfer/UploadOperation.xml
Product: uwp
Technology: winrt-reference
GitHub Login: @stevewhims
Microsoft Alias: stwhi

Hi, @avakhrushev, and thanks for filing this issue. This problem was present in three topics, and I have fixes for them going through the publishing pipeline now. I have a TODO in my notes to check periodically to make sure that the changes go live, so I'll go ahead and close the issue now.
Thanks again!
Steve


Update losses.py - TV loss returns shape [BxC] instead of [B,]

Hello,
in the tv_loss function, kornia.losses.total_variation(x) returns a tensor of shape [Batch x Channels] instead of [Batch]. I think this behaviour is in line with the documentation of kornia, but conflicts with the purpose and docstring of the tv_loss function.
This unexpected behaviour prevents benchmark training for batch sizes > 1.
Taking a mean over the channels of each image should be an appropriate fix, right?

Hi @simon-donike
Apologies for the lack of answer! Just saw your PR now, I don't know how I missed it for 11 months, apologies! Good to merge, if you're still interested :/

No worries, recreated this at issue #16 with the same changes. Couldnt edit it here since I deleted my fork.

Thanks a lot @simon-donike ! Sorry for the hassle, and the delay!


BIG-29774: Use PHPUnit\Framework\TestCase rather than non-namespaced version

What?
Use PHPUnit\Framework\TestCase rather than non-namespaced version.

At the same time we can drop the php5.6 option from composer require

ping @precariouspanther: can you review when you have a bit of time?
I agree we'll also need to release new major version once merged.

@petrkotek 👍 LGTM! Thanks very much!


Meslo powerline font renders incorrectly on Hyper 1.3.3

When using "Meslo LG L DZ for Powerline" Hyper is unable to correctly render the powerline font, which works totally fine in iTerm2.
Screenshot shows issues rendering when rendering Powerline icons.

Screenshot shows issue where powerline icon is cut off at the top of the window.

Hyper 1.3.3
Electron 1.4.16
darwin x64 16.5.0
.hyper.js
// Future versions of Hyper may add additional config options,
// which will not automatically be merged into this file.
// See https://hyper.is#cfg for all currently supported options.

module.exports = {
  config: {
    // default font size in pixels for all tabs
    fontSize: 14,

    // font family with optional fallbacks
    fontFamily: '"Meslo LG L DZ for Powerline", Menlo, "DejaVu Sans Mono", Consolas, "Lucida Console", monospace',

    // terminal cursor background color and opacity (hex, rgb, hsl, hsv, hwb or cmyk)
    cursorColor: 'rgba(248,28,229,0.8)',

    // `BEAM` for |, `UNDERLINE` for _, `BLOCK` for █
    cursorShape: 'BLOCK',

    // set to true for blinking cursor
    cursorBlink: false,

    // color of the text
    foregroundColor: '#fff',

    // terminal background color
    backgroundColor: '#000',

    // border color (window, tabs)
    borderColor: '#333',

    // size of window by pixels (width, height)
     windowSize: [1200, 600],

    // custom css to embed in the main window
    css: '',

    // custom css to embed in the terminal window
    termCSS: '',

    // set to `true` (without backticks) if you're using a Linux setup that doesn't show native menus
    // default: `false` on Linux, `true` on Windows (ignored on macOS)
    showHamburgerMenu: '',

    // set to `false` if you want to hide the minimize, maximize and close buttons
    // additionally, set to `'left'` if you want them on the left, like in Ubuntu
    // default: `true` on windows and Linux (ignored on macOS)
    showWindowControls: '',

    // custom padding (css format, i.e.: `top right bottom left`)
    padding: '12px 14px',

    // the full list. if you're going to provide the full color palette,
    // including the 6 x 6 color cubes and the grayscale map, just provide
    // an array here instead of a color map object
    colors: {
      black: '#000000',
      red: '#ff0000',
      green: '#33ff00',
      yellow: '#ffff00',
      blue: '#0066ff',
      magenta: '#cc00ff',
      cyan: '#00ffff',
      white: '#d0d0d0',
      lightBlack: '#808080',
      lightRed: '#ff0000',
      lightGreen: '#33ff00',
      lightYellow: '#ffff00',
      lightBlue: '#0066ff',
      lightMagenta: '#cc00ff',
      lightCyan: '#00ffff',
      lightWhite: '#ffffff'
    },

    // the shell to run when spawning a new session (i.e. /usr/local/bin/fish)
    // if left empty, your system's login shell will be used by default
    // make sure to use a full path if the binary name doesn't work
    // (e.g `C:\\Windows\\System32\\bash.exe` instead of just `bash.exe`)
    // if you're using powershell, make sure to remove the `--login` below
    shell: '',

    // for setting shell arguments (i.e. for using interactive shellArgs: ['-i'])
    // by default ['--login'] will be used
    shellArgs: ['--login'],

    // for environment variables
    env: {},

    // set to false for no bell
    bell: 'SOUND',

    // if true, selected text will automatically be copied to the clipboard
    copyOnSelect: false

    // if true, on right click selected text will be copied or pasted if no
    // selection is present (true by default on Windows)
    // quickEdit: true

    // URL to custom bell
    // bellSoundURL: 'http://example.com/bell.mp3',

    // for advanced config flags please refer to https://hyper.is/#cfg
  },

  // a list of plugins to fetch and install from npm
  // format: [@org/]project[#version]
  // examples:
  //   `hyperpower`
  //   `@company/project`
  //   `project#1.0.1`
  plugins: [
    'hyperline',
    'hyper-blink',
    'hyper-solarized-dark',
    'hyperlinks',
    'hyper-tab-icons'
  ],

  // in development, you can create a directory under
  // `~/.hyper_plugins/local/` and include it here
  // to load it and avoid it being `npm install`ed
  localPlugins: []
};

I believe https://github.com/zeit/hyper/pull/1536 will fix it

is there a fix for that? i have similar problem with Meslo LG M for Powerline and Source Code Pro for Powerline

Add Roboto Mono for Powerline to start of fontFamily before Menlo. Works good, looks good.

I resolved this by adding the following to my .hyper:
// custom css to embed in the terminal window
termCSS:'x-row > span { line-height: 1.2em; }',
before:

After:

used the same solution as @AddAndy but with a 1.4em over LG S.
Perfect!


Support specifying jreleaser.yaml location

It would be nice if we could specify a URL for the jreleaser.yaml. My use case is that I need to verify if a project is ready to be deployed to central in projects that do not use JReleaser, so I'd like to run jreleaser deploy --dry-run when a PR is opened using a jreleaser.yml (or another file name) defined in a separate repository (OWNER/.github for example)

Have you tried passing an explicit --config-file flag as argument?

Ah, that works, thank you!


Does TensoreFlowOnSpark support dynamic resource allocation?

I am asking because I am thinking about using it in streaming application, with dynamic resource allocation ( adjusting number of executors). Thanks

Currently, distributed TensorFlow does not support dynamic cluster sizing.  For that reason, TFoS also does not support dynamic allocation of executors.  That said, if you are only inferencing, and the model fits in the memory of a single executor, we do have an example of “parallel” inferencing (in mnist/keras) where each executor inferences independently.  You MIGHT be able to use that with dynamic allocation and streaming... but I haven’t tried that myself (so no guarantees).

On Apr 22, 2019, at 5:48 AM, Victor Chen<EMAIL_ADDRESS>wrote:
I am asking because I am thinking about using it in streaming application, with dynamic resource allocation ( adjusting number of executors). Thanks
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Buffer issue

Possible buffer issue, think of way to test for this. Do #3 first, if that works fine then buffer size is prob not it. This issue also is for the general slow speed of TS to react.

Got some data regarding the buffer, looks like it may be a problem with the robot.

I have confirmed with Mateus that the robot in a certain version did buffering, I asked for a version that doesn't and will test it out in the lab.

Confirmed in lab


IOException thrown when calling AdjustWindowSize

Calling ConsoleManager.AdjustWindowSize() in a tight loop while resizing the window with the mouse can cause a System.IO.IOException to be thrown.
Exception Details
System.IO.IOException: The parameter is incorrect.
   at System.ConsolePal.SetCursorPosition(Int32 left, Int32 top)
   at ConsoleGUI.Api.StandardConsole.set_Size(Size value)
   at ConsoleGUI.ConsoleManager.Resize(Size& size)
   at ConsoleGUI.ConsoleManager.AdjustWindowSize()

Might want to add a SafeConsole.SetCursorPosition method.

I wasn't able to reproduce it on my side.
What OS/terminal are you using?
But nevertheless, adding a SafeConsole.SetCursorPosition seems like a good idea regardless. Those console APIs are bit wonky.

Should be fixed in v1.2.1 by 1863c5c6cd51304aa604d3a021686d945d566b37
Please let me know if you can reproduce this issue with the new version of the package.

I am using the "Command Prompt" (cmd.exe) terminal on Windows 10 version 1903 (Build 18362.1139).
Below is an example of code that will reproduce the issue.
    // while running, resize the window to be really small
    class Program
    {
        static void Main(string[] args)
        {
            ConsoleManager.Setup();
            ConsoleManager.Content = new TextBlock
            {
                Text = "Text Block"
            };

            while (true)
            {
                ConsoleManager.AdjustWindowSize();
                System.Threading.Thread.Yield();
            }
        }
    }

The stack trace
   at System.ConsolePal.SetCursorPosition(Int32 left, Int32 top)
   at ConsoleGUI.Api.SimplifiedConsole.Write(Position position, Character& character) in C:\Users\...\C-sharp-console-gui-framework\ConsoleGUI\Api\SimplifiedConsole.cs:line 24
   at ConsoleGUI.ConsoleManager.Update(Rect rect) in C:\Users\...\C-sharp-console-gui-framework\ConsoleGUI   at System.ConsolePal.SetCursorPosition(Int32 left, Int32 top)
   at ConsoleGUI.Api.SimplifiedConsole.Write(Position position, Character& character) in C:\Users\...\C-sharp-console-gui-framework\ConsoleGUI\Api\SimplifiedConsole.cs:line 24
   at ConsoleGUI.ConsoleManager.Update(Rect rect) in C:\Users\...\C-sharp-console-gui-framework\ConsoleGUI\ConsoleManager.cs:line 148
   at ConsoleGUI.ConsoleManager.Redraw() in C:\Users\...\C-sharp-console-gui-framework\ConsoleGUI\ConsoleManager.cs:line 126
   at ConsoleGUI.ConsoleManager.Initialize() in C:\Users\...\C-sharp-console-gui-framework\ConsoleGUI\ConsoleManager.cs:line 121
   at ConsoleGUI.ConsoleManager.Resize(Size& size) in C:\Users\...\C-sharp-console-gui-framework\ConsoleGUI\ConsoleManager.cs:line 168
   at ConsoleGUI.ConsoleManager.AdjustWindowSize() in C:\Users\...\C-sharp-console-gui-framework\ConsoleGUI\ConsoleManager.cs:line 180
   at Repro.Program.Main(String[] args) in C:\Users\...\Repro\Program.cs:line 25

I think I was able to reproduce it on my end as well.
Can you please confirm that it only happens when the window is resized to a point where it's completely collapsed?

Or does it happen also where there is some drawind space visible?

Should be fixed in v1.2.2 by 42fd2f84a4ea86912c34f2813593a41fde9461c7

Interesting, on my side it was only happening when the window was 0px tall.
But v1.2.2 should take care of that and all other edge cases.
I'm closing the ticket.
Thanks for reporting and the help in investigating :)


⚠ Bofrost.be has degraded performance

In 310867b, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1559 ms

Resolved: Bofrost.be performance has improved in 2c76ab3 after 43 minutes.


README for box plots not up to date with program

Support for boxen, swarm and strip plots was added.
Also, output names of files has changed to match the plot type.
Also the group argument is no longer mandatory

Done


Can't download video with latest version of Protect on UDM-Pro

Using both download and sync, the program errors out and only downloads a few minutes of footage:
mattperry@docker-temp:~/unifi-protect-video-downloader$ sudo docker run --network=unifi-protect-video-downloader_default --volume /mnt/saturnv/moxie:/downloads unifitoolbox/protect-archiver sync --cameras="xxxxxxx" --address="unifi-udm-api-proxy" --username xxxxxxx --password xxxxxxxx --ignore-failed-downloads /downloads
Downloading footage for camera 'Back Living Room' (xxxxxxxxxx) Downloading video for time range 2020-04-09 17:00:00 - 2020-04-09 17:59:58 to /downloads/2020/04/09/Back Living Room (03ee)/Back Living Room (03ee) - 2020-04-09 - 17.00.00.mp4 Download successful after 19s (187.89 mb, 9.67 mbps) Downloading footage for camera 'Back Living Room' (xxxxxxxxxx) Downloading video for time range 2020-04-09 18:00:00 - 2020-04-09 18:59:58 to /downloads/2020/04/09/Back Living Room (03ee)/Back Living Room (03ee) - 2020-04-09 - 18.00.00.mp4 Failed to sync camera Back Living Room - continuing to next device Traceback (most recent call last):   File "/usr/local/lib/python3.8/site-packages/protect_archiver/sync.py", line 55, in run     self.client.download_footage(interval_start, interval_end, camera)   File "/usr/local/lib/python3.8/site-packages/protect_archiver/client.py", line 390, in download_footage     self.download_file(address, filename)   File "/usr/local/lib/python3.8/site-packages/protect_archiver/client.py", line 175, in download_file     data.get("error") or data or "(no information available)" AttributeError: 'NoneType' object has no attribute 'get' Getting camera list 1 files downloaded (187.89 mb), 0 files skipped, 1 files total
Using download instead of sync, we get the following:
"Non-monotonic timestamp provided."

Hi there!
Thanks for reporting this issue, I'll look into it as soon as I find some time to do so.
For me this error looks like it might be caused by a non-existent video segment on the UDM, which in turn results in the downloader module failing while trying to locate/download it.
Please keep in mind that using the software in combination with the UDM proxy might not work for some system setups and scenarios. However, if I manage to replicate the issue with my test setup over here and find a solution, I'll let you know!

Hey @danielfernau , thanks for the reply back.  I am happy to assist in troubleshooting or testing if needed.
I did try to download the segment in question from the web UI and it downloaded ok.

I think the issue is that you have hardcoded the port, remove that and it works.

@ntableman As far I remember there's no hard-coded port, neither in v1.x nor in v2.x -- there's only a default port (7443) that is being used if the --port parameter is not provided set via command line. We're currently working on replacing and improving the authentication/session part anyways, so all that should be resolved in one of the next versions 🙂

Hi @TokugawaHeavyIndustries
A new release – v2.0.1 – is now available. Please have a look if the problem you've reported here still occurs.


0x691b692d9b181df61aba69f22f4721512012bd8a

Related Safe Addresses
0x5b953dfd01bf281974b296191fcbaa25ed6dd05f
0x7a901acf18a34ca90e329e7d9ac3141bbea45c9d
0xf7204998ae70da0d2df7cb41d490393e03c5133d
0x850f657376fd78e8fb581e9f1d4ac560f4094603
0xbefb0078f5e8ec9685de4ffa14f3605ef44d2e6b
0x805298584b55292215ac90391550641125a75d65
0x4e424f9a20c18cfe090f01262a2f239f32485728
0x6024e9b974f6643a8a9595b521e9d14feab77f0f
0x7cbc951103a0d880079deb94e98721d79e168757
0xea8206e4372bb589395502c8504ee0d39e313a2d
Reasoning
These safe accounts are all created by 0x691b692d9b181df61aba69f22f4721512012bd8a
All 10 accounts carry out similar transactions, and all transactions only involve USDT and USDC, which are recharged at about the same time, and all token transfers are completed in about the same time by multiple transactions, and the balance is all 0. Withdrawals to the same address were found in multiple different accounts ，like ilovebourbon.eth
https://etherscan.io/tx/0x0a7ddb7701b9e00f537344675cf13db9f214569abbc2805734f137b981b709f9
https://etherscan.io/tx/0xbbedf32fbcc352c1ea7ce4f99b60e23b0ccd65681532f3ff4b9dac34c80b5ae4
https://etherscan.io/tx/0xc7234de17e198de1611ebb42dd425fdcd68d4540eece0006f14a487130e82e3e
Methodology
Luabase was used for preliminary data removal, and then all TX were checked one by one by EtherScan
My Safe Address
0xf4ed1EF1f7A52DC7Dd10a9B5d43f23748A1E8992

These safe accounts are all created by 0x691b692d9b181df61aba69f22f4721512012bd8a
All 10 accounts carry out similar transactions, and all transactions only involve USDT and USDC, which are recharged at about the same time, and all token transfers are completed in about the same time by multiple transactions, and the balance is all 0. Withdrawals to the same address were found in multiple different accounts ，like ilovebourbon.eth

This report doesn't meet the quality requirement. It's hard to following. Please elaborate and provide structure to your reasoning, incl. clarifying the following:

All 10 accounts carry out similar transactions,

what txs?

which are recharged at about the same time

what means "recharging" and why is this airdrop farming?

Withdrawals to the same address were found in multiple different accounts ，like ilovebourbon.eth

Pls provide the complete picture and why this is airdrop farming.

We haven't received any further information on this ticket and therefore deemed this submission invalid.
Unfortunately just the pure fact that Safes...

were created by the same address
have the same owner
conducted the same transactions
received assets from the same address

... is not enough reasoning for a valid submission, as there are legit user behaviour leading to such as well (relayer, scripts, power users, exchanges)
This submission didn't provide sufficient indicators to convince the team that there is some targeted airdrop farming behind the provided addresses. As per the rules, when in doubt we will default in favor of the airdrop recipients in order to not risk any false positives when sorting out airdrop hunters.


[DOCUMENTATION] Add information about cake.build used on the pipeline

Context
Please add on the documentation information that the tool is used and to why it it used.

Cake was removed, so this is no longer needed
The reason was that the only thing it was doing was collecting the coverage, so it was replaced with dotnet-coverage.


Upgrade to newer version of RxNetty and RxJava

Looks like we are using an older version of RxNetty in Ribbon Transport. A new version of RxNetty was released which uses Netty 4.0.25.Final, and fixes some GC related issues[1].
On the RxJava side, there has been several releases since 1.0.0 which includes performance improvements, we could upgrade RxJava too, since there has been no breaking API changes.
[1] https://github.com/netty/netty/issues/2693

@elandau Sent a PR your way which fixes this.


Queued imports

It will be a great feature, do you agree? @simonhamp

Would be a great feature, import breaks in our case with 30k records to import


[New game]: Flames Game

🎮 Game Request
Game logic and basic description
The Flames Game is a popular and fun game that reveals the relationship between two individuals. The game uses the acronym "FLAMES" to determine the connection or compatibility between two people based on their names.
Here's how the game works:

Input: The players are required to enter their names (Name 1 and Name 2) into the provided input fields.

Name Preparation: The entered names are converted to lowercase and any spaces are removed. This ensures consistency during the comparison process.

Letter Comparison: The game compares each letter in Name 1 with the letters in Name 2. Common letters between the two names are eliminated until only distinct letters remain.

Count Calculation: The total count of the remaining letters (after elimination) is calculated.

Relationship Determination: The relationship between the two individuals is determined using the "FLAMES" acronym:
. F (Friendship): If the count is divisible by 6, it means there is a friendship connection between the individuals.
. L (Love): If the count is divisible by 5, it means there is a romantic or love connection.
. A (Affection): If the count is divisible by 4, it signifies an affectionate bond.
. M (Marriage): If the count is divisible by 3, it indicates a potential for marriage or a lifelong commitment.
. E (Enemies): If the count is divisible by 2, it signifies a relationship of enmity or incompatibility.
. S (Sibling): If none of the above conditions apply, it means the individuals share a sibling or familial bond.

Result Display: The game displays the determined relationship between the two individuals based on the outcome of the FLAMES calculation.

Point down the features
Game points

Input Names: Players can enter their names in the input fields provided. This allows for customization and personalization of the game experience.

Dynamic Name Processing: The game processes the entered names by converting them to lowercase and removing any spaces or special characters. This ensures consistency and accuracy during the comparison process.

Letter Comparison: The game compares each letter in Name 1 with the letters in Name 2. This comparison identifies the common letters between the two names.

Letter Elimination: The game eliminates the common letters from both names, leaving only the distinct letters. This step helps in calculating the remaining count.

Relationship Calculation: The game calculates the total count of the remaining letters and uses it to determine the relationship between the two individuals using the "FLAMES" acronym.

Result Display: The game displays the determined relationship between the two individuals based on the outcome of the FLAMES calculation. The result is shown to the players, providing them with an entertaining and often surprising revelation.

Select program in which you are contributing
GSSoC23
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @Uglycrown !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

/assign

Hey @singhapeksha ! , This issue is already assigned to @Uglycrown. 💗
You can work on other issues 🚀
If there is anything wrong you can contact us on Discord🕹👀

Hello @Uglycrown, Time's Uppp!⏰
Sorry for closing your issue!
But it's more than a week since we haven't received anything from your side 😢 .
Come up with new ideas, create a new issue and make sure you finish it within a week! 🔥
All the best! 🚀
Happy Hacking! 💗

Hey @Uglycrown ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


Docker location missing in the list

Currently, the library looking for a docker executable in few places, but the latest docker installation has it in docker\resources\docker.exe
C:\Program Files\Docker\Docker\resources\docker.exe
but it looking for a file in the 'bin' folder
C:\Program Files\Docker\Docker\resources*bin*\docker.exe
List of possible locations have to be updated
cloud.localstack.docker.exception.LocalstackDockerException: Could not start the localstack docker container. 	at cloud.localstack.Localstack.startup(Localstack.java:90) 	at cloud.localstack.LocalstackTestRunner.run(LocalstackTestRunner.java:41) 	at org.junit.runner.JUnitCore.run(JUnitCore.java:137) 	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69) 	at com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:33) 	at com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:220) 	at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:53) Caused by: java.lang.IllegalStateException: Cannot find docker executable. 	at cloud.localstack.docker.DockerExe.lambda$getDockerExeLocation$1(DockerExe.java:43) 	at java.base/java.util.Optional.orElseThrow(Optional.java:408) 	at cloud.localstack.docker.DockerExe.getDockerExeLocation(DockerExe.java:43) 	at cloud.localstack.docker.DockerExe.<init>(DockerExe.java:35) 	at cloud.localstack.docker.command.Command.<init>(Command.java:11)

Thanks for reporting @nazymko . Do you think you could create a small pull request with this change? That would be much appreciated - many thanks for your help.

This location was added recently to 0.2.7 (I was using 0.2.5)


Reduce number of (re)allocations

There are several allocations / reallocations across the decoder that could probably be alleviated with some refactoring.
To be tackled after #6 probably...

@Nashtare Can you elaborate a bit on what kind of allocation strategy you would like to see here, or point to examples in the code where you'd like to see refactorings? As it stands the description is a bit vague.

There are a few TODOs / collect that could be modified, though I mostly put it as a tracking ticket, following an offline discussion with @BGluth

Yeah just to add, there are a handful of unnecessary heap allocations (IIRC mostly to deal with some lifetime issues), but I would expect only extremely negligible performance improvement after dealing with all of them. It might be more to just make the codebase cleaner, since we spend almost all of our time inside plonky2 generating proofs.

Yeah I also think it's nice to reduce these AMAP, even though they aren't performance critical compared to the prover. I also have a WIP branch for this purpose on the plonky2 side.

AMAP? You mean ASAP?

As much as possible :) But it could also be ASAAMAP combining both :D

TIL!


DOC: update 1.2.1 release notes

Update the maintenance branch release notes for 1.2.1. As usual, some manual curation beyond the automated scripts was in order, so please do check over.

I do want the CI to run through here despite doc-only change given that I'd like to do this release soon, so lack of ci skip intentional. Also, it wouldn't cover all the services anyway.

Looks good, thanks for taking care of this!

Windows Python 3.6 / 32 bit failed on Azure again, with details below the fold

2019-02-06T02:56:54.9325259Z ================================== FAILURES ===================================
2019-02-06T02:56:54.9326605Z ___________________________ TestLGMRES.test_arnoldi ___________________________
2019-02-06T02:56:54.9327561Z [gw0] win32 -- Python 3.6.4 C:\hostedtoolcache\windows\Python\3.6.4\x86\python.exe
2019-02-06T02:56:54.9327732Z
2019-02-06T02:56:54.9328996Z self = <scipy.sparse.linalg.isolve.tests.test_lgmres.TestLGMRES object at 0x0F4D0590>
2019-02-06T02:56:54.9329116Z
2019-02-06T02:56:54.9329281Z     @pytest.mark.skipif(python_implementation() == 'PyPy',
2019-02-06T02:56:54.9330526Z                         reason="Fails on PyPy CI runs.
We've clearly seen that test fail on PyPy before because of the skip mark, but not sure we've seen it this often on Windows 32-bit. The OpenBLAS version used in development CI could be updated both on this branch & in master to match the wheel builds, though I'm not sure that would help. I should do that tomorrow maybe.

Good point, I already had the first one, but I apparently forgot to backport the newer one, so I've cherry-picked gh-9617 into this PR now.

All green -- merging update to 1.2.1 release notes and the one missing backport.


[stable/datadog] Add fullnameOverride and nameOverride in README and values file

What this PR does / why we need it:

Add fullnameOverride and nameOverride in README and values file
Correct section name Updating to Upgrading in README
Removes blank spaces at EOL in a few places.

Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #11902

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

cc @hkaj @irabinovitch @xvello @charlyf

Currently testing, will approve if everything works as expected.

Good call @CharlyF , thanks for spotting this.
I made some changes that should address this issue, please have a look when you get a chance.
I was wondering how do you all feel about using recommended labels e.g. https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/
I don't mind addressing this in this PR if it's something you would like for the datadog chart.

Hi @CharlyF @hkaj  sorry for the huge commit, but this was the only way I saw how to fix the mess I started with the initial PR.
FWIW the chart is now much more standard and using recommended labels
which includes app.kubernetes.io/component . Short term pain for long term gain IMO.
upgrading with --force (to recreate everything) seemed to work for me, so i added this in the Upgrading section of readme.
Overriding fullName also works as expected.
Thoughts?

Hey @naseemkullah - Thank you very much for your contribution.
As it is unfortunately, I can't accept it as it embeds too many changes on top of a fix.
Please, let's get back to https://github.com/helm/charts/commit/e8e3405a850ea2294f73d8557c4329409fed4280, and include the changes I suggested after in https://github.com/helm/charts/pull/11903#pullrequestreview-211797663.
As per my previous comment:

I think labels could be a nice addition, but it will for sure be part of another PR.
For now, let make sure all users of our chart have a seamless experience upgrading, in a later PR we can review adding standards and use recommended labels.

For now, let's scope this change to fix the initial issue.
Thanks again!
.C

Oops, sorry. Added it back @CharlyF !

/ok-to-test

/approve

/lgtm


feat(sdk): OpenID4CI authorization code flow support

Codecov Report
Patch coverage: 51.95% and project coverage change: -5.26 :warning:

Comparison is base (a2edec6) 90.06% compared to head (7b7a65e) 84.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #413      +/-   ##
==========================================
- Coverage   90.06%   84.80%   -5.26%
==========================================
  Files          76       80       +4
  Lines        2748     2942     +194
==========================================
+ Hits         2475     2495      +20
- Misses        189      356     +167
- Partials       84       91       +7

Impacted Files
Coverage Δ

cmd/wallet-sdk-gomobile/openid4ci/grants.go
0.00% <0.00%> (ø)

...allet-sdk-gomobile/openid4ci/issuercapabilities.go
0.00% <0.00%> (ø)

pkg/openid4ci/models.go
100.00% <ø> (ø)

pkg/openid4ci/grants.go
42.30% <42.30%> (ø)

pkg/openid4ci/openid4ci.go
66.66% <53.18%> (-25.53%)
:arrow_down:

pkg/openid4ci/issuercapabilities.go
54.83% <54.83%> (ø)

cmd/wallet-sdk-gomobile/openid4ci/interaction.go
79.59% <57.69%> (-0.87%)
:arrow_down:

pkg/openid4ci/clientconfig.go
79.48% <60.00%> (-3.85%)
:arrow_down:

pkg/openid4ci/httpclient.go
73.33% <73.33%> (ø)

... and 4 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

I recommend reading usage.md first to see how the authorization code flow works from the viewpoint of the consumer. Then dig into the details of how the code works internally.


Feat selectors update

Welcome to Codecov :tada:
Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


Empty string as negative confirm should show only one affirmative button

Is your feature request related to a problem? Please describe.
Previously we use gum confirm with empty string --negative="" . It showed only one button. But now gum use huh and this undo https://github.com/charmbracelet/gum/pull/175.
Describe the solution you'd like
Please redo https://github.com/charmbracelet/gum/pull/175 for huh.
Describe alternatives you've considered
N/A
Additional context
N/A

Thanks so much for this issue! I'll make the appr

Hey @ragazenta this was added to huh by the way!
https://github.com/charmbracelet/huh/commit/1a310fe0c5604cb09e0d7f82b22f73c22971a56f

Great thanks. Looking forward for the next version of gum including this change.


Update pie chart window

Update pie chart window to reopen if user inputs summarise command again.
This change is to prevent multiple pie chart windows from opening. Also, if a pie chart window is opened, it will reopen a new pie chart window instead of refocusing to it if the user inputs summarise command again because there might be some interim commands in between that might alter the contacts in Tracey.
This PR is ready to merge.
This PR is part of a greater set of changes for the summarise command and is not dependent on any concurrent PR.

Codecov Report

Merging #85 (5d1eca1) into master (e680598) will decrease coverage by 0.31%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master      #85      +/-   ##
============================================
- Coverage     71.76%   71.44%   -0.32%
  Complexity      487      487
============================================
  Files            79       79
  Lines          1576     1583       +7
  Branches        167      166       -1
============================================
  Hits           1131     1131
- Misses          399      406       +7
  Partials         46       46

Impacted Files
Coverage Δ

src/main/java/seedu/address/ui/MainWindow.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/ui/PieChartWindow.java
0.00% <0.00%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


adding filtering and compute documentation

New
Add documentation for filtering and computing molecular properties for potential quantum dots ligands.
Remove
Unused files and badges from the README

@juliette1996  and @BvB93, I am done with the PR. Let me know if you agree with the changes :)


Lokalise: Translations update

This pull request was initiated by Lokalise (user Agnieszka Galeza) at 2020-11-18 22:35:09

Translation for PR #1856


Misc. enhancements

Various enhancements and bugs that I've come across, feel free to comment below (or create a new issue) for suggestions or bugs.

[ ] Bug: Exclude skips files with similar names (e.g. excluding .git results in .gitignore not being listed).
[ ] Add unit tests (test files are empty right now).
[x] Add support for regex in string comparisons (e.g. ... ENDSWITH jsx?).
[x] Handle errors more gracefully (instead of just panicking everything).
[x] Add support for OR / AND  / () (for precedence) in condition statements (lexing is already done for these, just need to add the parsers).
[x] Add support for times/dates (to query file creation/modification time).
[x] Introduce new attributes to select from (creation/modification time, file mode, basically whatever else os.FileInfo supports).
[x] Bug: Space-separated queries. Currently something like "... WHERE time > May 1 ..." is broken since we're splitting conditionals by space. Fix by allowing single quotes and backticks in query strings, so something like "... WHERE time > 'May 1' ..." works and evaluates the conditional to have value of "May 1".
[x] Add NOT operator for negating conditionals.
[x] Add support for querying and selecting using other size units (only supports bytes right now, add functionality for KB, MB, and GB as well).
[x] Bug: Selecting from a directory and it's subdirectory results in duplicates and malformed output.

Moved from the README to this issue as of b78a987.

Closing in favour of individual issues. See #5.


Remove locations with 2 Fault domains from configuration

This commit removes those locations that have only 2 Fault domains
from configuration. 2 Fault domains is the default.
Closes #234

LGTM 👍
We have a fallback in place here https://github.com/elastic/azure-marketplace/blob/4932ac7ce8c0c3d6809ff6acd1c0f5d3489eca77/src/partials/node-resources.json#L210


x/lockup: Ensure events are emitted and tests added

Background
Currently, our tests are missing assertions about events. Moreover, it seems that some of our events are missing based on #1939
The lockup module emits the following events:
There are 4 types of events that exist in lockup module:
* `types.TypeEvtLockTokens` - "lock_tokens"
* `types.TypeEvtAddTokensToLock` - "add_tokens_to_lock"
* `types.TypeEvtBeginUnlockAll` - "begin_unlock_all"
* `types.TypeEvtBeginUnlock` - "begin_unlock"

### `types.TypeEvtLockTokens`

* `types.AttributePeriodLockID`
* `types.AttributePeriodLockOwner`
* `types.AttributePeriodLockAmount`
* `types.AttributePeriodLockDuration`
* `types.AttributePeriodLockUnlockTime`

### `types.TypeEvtAddTokensToLock`

* `types.AttributePeriodLockID`
* `types.AttributePeriodLockOwner`
* `types.AttributePeriodLockAmount`

### `types.TypeEvtBeginUnlockAll`

* `types.AttributePeriodLockOwner`
* `types.AttributeUnlockedCoins`

### `types.TypeEvtBeginUnlock`

* `types.AttributePeriodLockID`
* `types.AttributePeriodLockOwner`
* `types.AttributePeriodLockDuration`
* `types.AttributePeriodLockUnlockTime`

Therefore, this issue is twofold:

Investigate if / which events are missing and restore them

Add assertions in tests that events are being emitted in the correct places

Suggested Design
Very similar to what @p0mvn suggested for superfluid events! #2194
Acceptance Criteria

lockup events are emitted correctly in the right locations
tests added for attributes
tests added for verifying that events are emitted in the correct locations
every event is documented in lockup README

what the events is for / when it is emitted
what attributes it contains

final design is consistent with x/gamm and x/superfluid events

Epic #2195

See PR discussion


Update dependencies, improve code style

This PR:

Bumps the Spine dependency to 1.0.0-pre1
Improves the naming and structure of the Blog example.
Improves the naming and structure of the Hello World.
Removes outdated server-examples module.

@armiol, PTAL.

@annikulin, FYI.


how to get v2.0

I tried to clone the project, but it's v1.0 only. How can I get the v2.0?

trunk/master is v2.0, so a straight clone will get you v2.0.

What is the timing on when you expect to cut an official v2.0 release?


getbootstrap.com/docs/3.4/ version options in the top right nav are outdated

On https://getbootstrap.com/docs/3.4/, there is a drop-down menu on the right side of the top nav bar to select which version of the docs you want.
Right now, the only listed options are:

Latest (4.x)
v4 Alpha 6
v3.4.1
v3.3.7
v2.3.2

This is confusing for users who might have arrived at the page from a search engine or other external link, because it makes it look like there is no official release of Bootstrap v4. It would probably be worth it to bring it in sync with the drop-down that appears on https://getbootstrap.com/ to make it clear that v4 has had multiple point releases.

Latest (4.x), plus the blue banner at the top of every page, should be pretty clear there's a new major version. It doesn't need every version listed.


slidesPerGroupAuto: true is ignored in pagination (still present in Swiper 9)

Check that this is really a bug

[X] I confirm

Reproduction link
https://codesandbox.io/p/sandbox/swiper-slides-per-view-auto-forked-ydyjoy
Bug description
When using slidesPerGroupAuto: true, the number of bullets in the pagination doesn't change the same way it does when using slidesPerGroup with a fixed amount of slides (even if that fixed amount is the same as the dynamic amount that ends up getting used with slidesPerGroupAuto).
Originally posted here, but that issue was closed & locked even though the problem still occurs with Swiper 9.
Expected Behavior
In the example provided, there should be 3 bullets in the pagination, since there are 3 groups of 3 slides.
Actual Behavior
In the example provided, there are currently 7 bullets in the pagination.
Swiper version
9.0.0
Platform/Target and Browser Versions
All modern macOS browsers (Safari, Chrome, Firefox, Edge)
Validations

[X] Follow our Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
[X] Make sure this is a Swiper issue and not a framework-specific issue

Would you like to open a PR for this bug?

[X] I'm willing to open a PR

I see @nolimits4web. That is unfortunate; I would love an actual slidesPerGroup: 'auto' that works the same as slidesPerGroup: 3 except it updates the amount dynamically depending on how many slides fit in the view.


Ensure that all providers with CSI support have CSI Snapshot CRDs and components

Ensure that all providers with CSI support have CSI Snapshot CRDs.

CSI snapshotter is now deployed for all providers that have a CSI driver. This however doesn't mean that the provider supports it, e.g. Hetzner doesn't at the moment. We might eventually want to avoid deploying it for such providers, but that's out of the scope for this ticket. Reference: https://github.com/kubermatic/kubeone/blob/494d081d10c4e8f1a6fa1eddd524ea7216d944e4/pkg/addons/ensure.go#L427-L431
/close


feat: Experimental getFirebaseDownloadUrl API

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[x] Make sure to open an issue as a bug/issue before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
[ ] Ensure the tests and linter pass
[ ] Code coverage does not decrease (if any source code was changed)

Fixes #244 (using this old issue temporarily to kickoff the discussion) 🦕
Background
Currently this library only supports generating signed URLs. Signed URLs have an expiry time, and are attached to a private key. They become invalid when the expiry time is up or when the private key gets cycled out. Firebase Storage (which operates on top of GCS) supports a notion of permanent download URLs. These URLs remain valid until the developer explicitly revokes them, and therefore are better for saving into a database or some other permanent record keeping system.
Problem
There's currently a feature gap in the GCS SDK due to it only supporting signed URLs. Server-side Firebase developers have no easy way for generating Firebase download URLs using this library (or the Firebase Admin SDK that re-exports this library). This has resulted in several reported issues and questions on SO.
The temporary nature of signed URLs often causes problems in environments like GCF where developers use application default credentials. The underlying service account automatically gets cycled out within a week or so, leaving all the signed URLs invalid. Firebase download URLs are a better fit for such use cases.
For more context:

https://stackoverflow.com/questions/42956250/get-download-url-from-file-uploaded-with-cloud-functions-for-firebase
#244
https://github.com/googleapis/nodejs-storage/issues/697
https://github.com/firebase/extensions/issues/140#issuecomment-595195942

Solution
Adding a new getFirebaseDownloadUrl() method to the File class that generates Firebase Storage download URLs (token based access control).
Just wanted to know what the community thinks about this approach, and possible ways we can improve it.

@crwilcox I think offline discussions left off on not moving forward with specific Firebase features in the Storage library. Do you know if that has changed?

Hiranya, could you explain what the intended usecase for this api is and what problem it is intended to fix?

@tonyjhuang I've added more background info and context links to the issue description.

Is there a reason this code cannot be added to the Firebase Admin SDK instead of the GCS Library?

Server-side Firebase developers have no easy way for generating Firebase download URLs using this library (or the Firebase Admin SDK that re-exports this library). This has resulted in several reported issues and questions on SO.

It seems that this is used by that subset of users. While I haven't looked up stats, but feel this might be 'bloat' in the GCS library, since we have many customers who wouldn't be using this added functionality.
Is there a technical reason to favor this approach?

We (well, at least I) slightly prefer this option because Firebase Admin SDKs don't really have any GCS code. They are just a facade to initialize and use the official GCS clients like @google-cloud/storage. Given that there are issues like #697 reported on this repo, it seems like a good fit here.

The code seems to (at a high level) construct a URI to firebasestorage.googleapis.com.  Will this URI work for all library users, or only ones who have used firebase with the project associated with the storage bucket?

I think at the least the Firebase API should be enabled in the project. @avolkovi @tonyjhuang can you confirm?

@crwilcox the firebasestorage.googleapis.com URI that getFirebaseDownloadUrl() will only work if the bucket has previously initialized Cloud Storage for Firebase in their Firebase project. Otherwise I would expect the server to return an error.

So, to summarize:

this feature only works for firebase users
we instruct firebase users to use the admin sdk.
the admin sdk includes this library, @google-cloud/storage

I truly don't meant to be obtuse, but I can't figure out why we wouldn't favor adding this to the Admin SDK, as we are certain users are using firebase, and we already include a dependency on @google-cloud/storage, so it wouldn't cause additional dependencies there.

The simplest reason is that this is what would result in the best developer experience for the user. Following looks and feels quite natural:
const bucket = admin.storage().bucket();
const file = bucket.file('test.txt');
console.log(file.getFirebaseDownloadUrl());

And also like I mentioned earlier, we don't have any actual GCS API in the Admin SDK to add anything to. It's literally just an initialization shim that returns a Bucket object from this package. This means we have 2 options at the Admin SDK end (in the order of my personal preference):

Provide some sort of a util API: admin.storage().getDownloadUrl(file), which looks rather awkward to use.
Monkeypatch this library to dynamically add the new method to File class, which won't work across all languages.

So from a dev experience point of view, we only have suboptimal solutions at our end. Hence the suggested API in this PR.

Seems to me that the burden of adding this Firebase-specific feature to GCS is greater than making space for it on the Firebase Admin SDK, where it (IMO) belongs.

Hi @hiranya911 @frankyn @tonyjhuang, has there been any update on this issue? I really appreciate the suggested feature and would like to see it merged.


Lenses Connect protocol property missing

https://github.com/Landoop/kafka-helm-charts/blob/3a5e7472ff5791e6c5eed3574301fbf598b70877/charts/lenses/templates/_helper.tpl#L207
I notice that protocol must be defined for connectors as well. This isn't listed in the lenses helm documentation here for connectors, but it is listed for schema registry. Is there a way for community to contribute to docs to add this?

Will ask on the slack channel closing this for now

@spirosoik @andrewstevenson can you please update this part of the docs?

@struthj we updated the docs. Thanks for mentioning it. I am closing the ticket


Bug in Titan: sends an empty request on startup

On occasion (after crashing?), if the current tab is set to a Titan URI, on startup it may send an empty request to that Titan URI, with no token and no body, which causes the receiving server to delete or empty the file it was previously looking at.

The correct behavior here would be that tabs with a Titan URI are never restored (reloaded) at launch, because they are upload operation.
A similar issue can occur when navigating back and forward in history.


Add encodeResponse method

The service now has an encodeResponse method which replaces
the direct calls to JSON.stringify() in sendResponse / sendError.
The encodeResponse method can be overriden by the user and takes the
req/res objects so that headers can be inspected and the correct
encoding can be used.

Pull Request Test Coverage Report for Build 458

4 of 4 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.006%) to 92.846%

Totals

Change from base Build 457:
0.006%

Covered Lines:
666

Relevant Lines:
688

💛  - Coveralls

Pull Request Test Coverage Report for Build 458

4 of 4 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.006%) to 92.846%

Totals

Change from base Build 457:
0.006%

Covered Lines:
666

Relevant Lines:
688

💛  - Coveralls


New Feature: pause maintenance

Users sometimes want all background maintenance to stop.

They may be on a metered internet connection and do not want background fetch to use their bandwidth.
They may be doing performance testing and don't want other things taking resources.

Perhaps modifying the service verb with scalar service pause [<timespan>] would be good (with a default timespan of 12 hours? If users truly want to shut down maintenance forever they can scalar repos remove to stop tracking.

Is this solved with the merge of 303?

We are still missing this bit:

Should this stop maintenance that is happening right now? (This is a maybe, only because of the difficulty)

We do not make an effort to cancel a currently-running maintenance process and instead let it complete. The pause command prevents new maintenance from starting for 24 hours.
Perhaps we will close this issue without that capability, as it may cause more problems than it solves.

We are still missing this bit:

Should this stop maintenance that is happening right now? (This is a maybe, only because of the difficulty)

We do not make an effort to cancel a currently-running maintenance process and instead let it complete. The pause command prevents new maintenance from starting for 12 hours.
Perhaps we will close this issue without that capability, as it may cause more problems than it solves.

Let's close this for now. We can come back to that last bit if it is important enough.


Documentation for passing prefect token for terraform

From my comment in Slack:

from what I can tell, the PREFECT_TOKEN stopped getting passed to the terraform command line in GitHub Actions when the update was made to base the actions on qhub deploy rather than directly using terraform apply .  That change happened in PR#567.  Previously, the apply command was being called with these args: '-var="prefect_token=${{ secrets.PREFECT_TOKEN }}"' , so I think this will need to somehow be passed through to the terraform command line in qhub deploy , or at least something similar.

For reference, here is the option being passed in qhub v0.3.11.
Here is the apply command that would result in prefect being deployed in the latest version, which calls this function.
cc @iameskild, @kcpevey, @aktech

per @aktech This will work if an environment is set TF_VAR_PREFECT_TOKEN=<prefect_token>. See https://www.terraform.io/docs/language/values/variables.html#environment-variables for more info.
We're re-classifying this as a documentation issue, since secrets ideally shouldn't be in plain text in qhub-config.yaml

Thanks, I did not know about TF_VAR_, that's very helpful and great to know.
Reading another section of the linked document about tfvars files, that might be another simple and easy to manage way to manage passing secrets, at least for the initial deployment, although they shouldn't be needed afterwards since deployment is handled by CICD which will manage secrets separately.
However, I noticed that we currently don't exclude those in the .gitignore, but based on other examples here and here it looks like we probably should.  Here is a comment from the first link:
# Exclude all .tfvars files, which are likely to contain sentitive data, such as
# password, private keys, and other secrets. These should not be part of version
# control as they are data points which are potentially sensitive and subject
# to change depending on the environment.

So I think maybe that should be changed, probably whenever the documentation is updated to reflect ways of passing variables into terraform.
As always, thanks for the guidance and support!

Fixed here: #641

@brl0 Just saw your comments regarding adding *.tfvars. It seems I missed it earlier. I'll add that in a follow up PR


git lfs doesn't use client selected server host name but instead return to client url with hardcoded host name

Gitea Version
1.15.0
Git Version
2.27.0
Operating System
centos 7
How are you running Gitea?
Bash terminal:
[user@ip-34-223-14-199 hooks]$ git lfs --version
git-lfs/3.0.2 (GitHub; linux amd64; go 1.17)
[user@ip-34-223-14-199 hooks]$ git --version
git version <IP_ADDRESS>
Database
No response
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
.
Description
When configuring gitea we have the option of selecting the host name for http, and a different hostname for https. That hostname will shows up in the clone URL in the UI for the user that want to know the URL to clone from their client.
We left our gitea configuration to use 'localhost'. We didn't care because from the terminal we just use the right hostname like: git clone myGitea/myrepo.git
However, it seems to fail when using lfs. When we clone a repo with git lfs, and run in debug mode like:
GIT_CURL_VERBOSE=1 GIT_TRACE=1 git clone myGitea/myrepo.git
We will see strange error message using 'localhost'.... like:
Error downloading object: xxx/images/nifi/gccs-nifi-controllers-api-nar-0.1.nar (db73af5): Smudge error: Error downloading xxx/images/nifi/gccs-nifi-controllers-api-nar-0.1.nar (db73af502651ccd630cc9fd084b6127e18864501d30f88f62cb69f20af12b567): LFS: Get "http://localhost/myrepo.git/info/lfs/objects/db73af502651ccd630cc9fd084b6127e18864501d30f88f62cb69f20af12b567": dial tcp [::1]:3000: connect: connection refused
Screenshots
.

Your ROOT_URL in app.ini is wrong. Feel free to re-open.


Redis Adapter

Super sneaky Redis adapter.

Why not just set/get redis keys?

Updated to get/set keys instead of piggybacking.

+1

Cool, thanks for making the update.  Travis-CI gives it a clean bill of health.

:thumbsup:


TikTok - YouTube-dl does not handle redirect correctly

Checklist

[x] I'm reporting a broken site support issue
[x] I've verified that I'm running youtube-dl version 2019.10.22
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar bug reports including closed ones
[x] I've read bugs section in FAQ

Verbose log
>youtube-dl -v -f best http://vm.tiktok.com/apBv1J/
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', '-f', 'best', 'http://vm.tiktok.com/apBv1J/']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2019.10.22
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.18362
[debug] exe versions: ffmpeg 4.1.3, ffprobe 4.1.3
[debug] Proxy map: {}
[generic] apBv1J: Requesting header
[redirect] Following redirect to https://www.tiktok.com/@samisillito/video/6751018132669877510?u_code=d1bea6gjb0307c&preview_pb=0&language=en&timestamp=1572037828&utm_source=copy&utm_campaign=client_share&utm_medium=android&share_app_name=musically&share_iid=6751462508722636550&enter_from=h5_m
[generic]<PHONE_NUMBER>669877510?u_code=d1bea6gjb0307c&preview_pb=0&language=en&timestamp=1572037828&utm_source=copy&utm_campaign=client_share&utm_medium=android&share_app_name=musically&share_iid=6751462508722636550&enter_from=h5_m: Requesting header
WARNING: Falling back on generic information extractor.
[generic]<PHONE_NUMBER>669877510?u_code=d1bea6gjb0307c&preview_pb=0&language=en&timestamp=1572037828&utm_source=copy&utm_campaign=client_share&utm_medium=android&share_app_name=musically&share_iid=6751462508722636550&enter_from=h5_m: Downloading webpage
[generic]<PHONE_NUMBER>669877510?u_code=d1bea6gjb0307c&preview_pb=0&language=en&timestamp=1572037828&utm_source=copy&utm_campaign=client_share&utm_medium=android&share_app_name=musically&share_iid=6751462508722636550&enter_from=h5_m: Extracting information
[debug] Invoking downloader on 'https://v19.muscdn.com/c182e2711373dba2f281187851675986/5db3c2a8/video/tos/maliva/tos-maliva-v-0068/01cb115b29234cde9c2f1c51342ecf9e/?a=1233&br=1876&cr=0&cs=0&dr=0&ds=3&er=&l=201910252150500101151311840A3E7807&lr=tiktok_m&qs=0&rc=M3VxOjV2Zzo5cDMzZjczM0ApODM8Njg6ZWQ6N2Y6OzQ2NmczNnNfYmRrcmxfLS0zMTZzczQ2NS4uLzRfNWA0NmEuMDU6Yw=='
ERROR: unable to open for writing: [Errno 2] No such file or directory: 'Samisillito (@samisillito) on TikTok - PRAY FOR ME-6751018132669877510u_code=d1bea6gjb0307c&preview_pb=0&language=en&timestamp=1572037828&utm_source=copy&utm_campaign=client_share&utm_medium=android&share_app_name=musically&share_iid=6751462508722636550&enter_from=h5_m.unknown_video.part'
Traceback (most recent call last):
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpifszpy0p\build\youtube_dl\downloader\http.py", line 250, in download
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpifszpy0p\build\youtube_dl\utils.py", line 2042, in sanitize_open
FileNotFoundError: [Errno 2] No such file or directory: 'Samisillito (@samisillito) on TikTok - PRAY FOR ME-6751018132669877510u_code=d1bea6gjb0307c&preview_pb=0&language=en&timestamp=1572037828&utm_source=copy&utm_campaign=client_share&utm_medium=android&share_app_name=musically&share_iid=6751462508722636550&enter_from=h5_m.unknown_video.part'

Description

Try to download a link like http://vm.tiktok.com/apBv1J/, but it doesn't work.  You have to use the redirected link https://www.tiktok.com/@samisillito/video/6751018132669877510

PR #22838 will fix this issue.


Update README.md

Description

Fixes #
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

[ ] The title of the PR states what changed and the related issues number (used for the release note).
[ ] Does this PR requires documentation updates?
[ ] I've updated documentation as required by this PR.
[ ] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have tested it for all user roles.
[ ] I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

Hey Cubic, we've changed how we list Devtron users. We've made a separate file USERS.md listing all Devtron users. Please update your branch, and add your organization there.
Also, please open an issue for the same, and link it in your PR.


Add Coverity.com badges

Example use of coverity.com

https://github.com/libgit2/libgit2
https://scan.coverity.com/projects/639

:+1:

:+1:


Remove Protege-generated artifacts

Protege generates stub definitions for, e.g., skos annotations, if that ontology is not imported. onto_tool could define an action to remove any definition consisting only of a type assertion. Perhaps there would be an option to specify in the config file which namespaces it applies to; if no specification, it would apply to all namespaces.

Also remove the owl:NamedIndividual and owl:Thing assertions that Protege adds to instances.

Is there really a need to create a specific action for this? A SPARQL transform action in a bundle script will do this just fine. I would be happy to assist on the query, and you could create an alias that would pass the input and output locations as variables. Can actually do this as a pre-checkin hook for git, a richer version of the current formatting hook.

Sure, I'm happy to use whatever implementation seems best to you. When you say "bundle.script" do you mean bundle.yaml? I do want this to run on commit, not just on bundle.

It turns out Protege adds the stub definitions for good reason: in order to keep the ontology DL compliant. We are actually going to add these back into gist. So this issue can be closed.


remove reference on not existing spring-cloud-starter-bus-redis

I am little confused about the fact that suddenly a widely used artifact "spring-cloud-starter-bus-redis" disappeared without announce. At least there shall be a migration doc and it must be completly removed from doc, e.g http://cloud.spring.io/spring-cloud-stream/ . There is no occurrence in https://repo.spring.io any more.

i also can't find spring-cloud-starter-stream-redis 1.0.0.RC1 in repo  https://repo.spring.io

The BOM also still has a reference to spring-cloud-starter-stream-local (which hasn't existed for a while I think).

Hi @cforce,
This is a mistake in our POMs and web page and we will have this corrected for GA. Sorry for the inconvenience.
Generally speaking, we do not recommend using Redis as a binder transport for anything else but development and limited testing. However, its presence in the main project and the Getting Started guides has encouraged its usage beyond the original intent, which is why we have decided to make it a separate project and artifact.
The 1.0.0.RC1 documentation to be found at http://docs.spring.io/spring-cloud-stream/docs/1.0.0.RC1/reference/htmlsingle/index.html is not referencing Redis anymore.
We have corrected the entry page to recommend one of the binders provided with the project instead (i.e. Kafka). We have also corrected the dependencies POM to remove the erroneous references to redis and local.
To ease the transition, we have planned on releasing a 1.0.0.RC1 and a 1.0.0.RELEASE version of the Redis binder, which has trailed for a few days. We will do this shortly.
Thanks for pointing this out.

As an additional update, spring-cloud-stream-binder-redis version 1.0.0.RC1 has been release in the milestone repository as well.

That only kafka any more is a valid production binder is no lucky announcement. Furthermore i only see kafka currently, or is there any other not released binding technology supported?
Can you also point out from the main page of spring-cloud-stream and spring-cloud-bus, what are the differences of these both projetcs and when to choose what . Especially the current and future usage of supporting features in spring cloud (like microservice2microservice communication and spring cloud configuration pushing).

Kafka and Rabbit are both fully represented in the repos and in documentation, so I don't really understand your comment.

Hi @cforce,
We are still pre-GA, so bear with us while we update the documentation and links.  We document and support both Rabbit and Kafka into production (see reference docs), and we'll include links to other know binder implementations (including Redis, which we do not recommend for production) on the main page, e.g. Redis or Gemfire.
Thanks for the suggestions. I guess we can close this specific issue for now or is it anything that we want to address?

Looking foward for your progress. Tx for support.

@mbogoevici
Could you quickly explain why Redis implementation is not supported/recommended for production?

@chrisport, Redis can't honour any of the "normal" quality of service requirements for messaging when it is operated with more than one node (in any configuration we've seen). It's fine in development (or production if you can tolerate outages) with a single server.


[Backport release-23.11] tailscale: 1.58.2 -> 1.66.4

Description of changes

Resolves: #313678
Backport tailscale updates to resolve security issue.
Also needed to backport go 1.22.
I skipped some cosmetic commits like maintainers being removed, those will be caught up in 24.05
LMK if I've done anything wrong.
Not ran a full build myself yet.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg eval

I might need to drop the powerpc stuff

Maybe, maybe not; the current eval failure is unrelated to your PR's contents:
       error: cannot connect to socket at '/nix/var/nix/gc-socket/socket': No such file or directory

We also need to backport https://github.com/NixOS/nixpkgs/pull/311176 to fix tailscale ssh or just don't backport the combined binary commit.
Also please review and merge the linked PR.

approved, can't merge :)

I've dropped the combine commit for the backport

@ofborg build tailscale

This is quite a significant bump for stable. Is there no alternative?

Technically tailscale is when used together with tailscale.com a software which is tied to an online service like Discord or yt-dlp and those get backported usually.

I'm failing to find the comment on an old update PR but tailscale have a commitment to backwards compatibility and said it should be fine to backport everything unless specified.
I do tend to put backport labels on the PR but the dependency on go 1.22 is a bit of a pain.
I've not seen a standalone patch for this issue. I strongly suspect that with a large update history the patch wouldn't cleanly apply.
It might be possible to modify tailscale to build on 1.21 depending on the features they're using. If 23.11 was going to be alive longer and we couldn't backport 1.22 then I'd potentially consider that.
But with just backporting a security patch to an old release it becomes tricky because you need to fully understand the fix, port that to the older release. It is possible that alone might not be a sufficient fix for the older release, so there's extra validation that you'd ideally want to do. And then there's the matter of identifying that release as fixed which I don't think would happen on the tailscale.com dashboard.
So yeah in this case I think the policy of backporting all updates fits best.

Seems like aarch64-darwin go build is busted "no space left on device" could be intermittent?

Regarding upstream claiming everything they release is backwards compatible and backporting security fixes taking extra effort around understanding and testing the fix, you've just described 90% of packages in nixpkgs.
Remember - any changes you make to the stable branch will be "surprise upgrades" for most stable branch users, who will likely have little opportunity for testing before rolling straight into production.
I do wish there were a way for end users to get a better idea what kind of stability to expect from different packages on this front. Something like a meta.stableIsUnstable flag for packages which follow this policy.

There are some upstreams I believe more than others for backwards compatibility promises but I do get your point.
A way to express some more granular policy around maintenance would be good.

Result of nixpkgs-review pr 313691 run on x86_64-linux 1

3 packages built:

go_1_22
tailscale
trayscale

tested locally

I'll trust the two meta.maintainers that it's OK.  (and ofBorg confirmed it builds on 4 platforms)


CQL: Deterministically generate tokens from the node's address

Fixes: https://github.com/stargate/stargate/issues/373

@tomekl007 The goal was to make stargates stateless. The proxies in front of stargate round-robin connections to any stargate node so there isn't a stable mapping between partition key and stargate nodes.