Add updateHash method (for ajax apps)

Hello.
We start using Selenide to test GWT apps, and it is very pleasant !
Here is a proposition of a method to ease navigation in ajax applications like GWT, since
open( "#GwtPlace1:");
open( "#GwtPlace2:"); => makes a full page reload
Inspired by a solution proposed here : https://code.google.com/p/selenium/issues/detail?id=5165
updateHash("GwtPlace2:"); would just navigate to the new Place, without reloading the whole page from the server.

@fabienbancharel
Cool idea! Let's do it. But, what about implementing this logic in method open("#GwtPlace2")? Then we don't need to introduce new method.

what about implementing this logic in method open("#GwtPlace2")
I was more comfortable to add a new method than to modify an existing one, but yes, it is a good idea.
Do you close this pull request ?
Do you want me to make another one, or do you prefer to implement it ?

In fact, there could be a problem if it is implemented in open() :
At the beginning of a test, open("#HomePlace:") is expected to make a first request to the server with the start url + "#HomePlace:".
If open("#HomePlace:") just updates the location.hash, it misses the first server call needed for Single Page Applications.
You would have to do :
open(""); open("#HomePlace:");
which is not exactly the same as open(startUrl + "#HomePlace:");
Maybe a specific method is preferable ?
(updateHash, openHash ...)
What do you think ?

It's up to you.
Probably the easiest way would be to create new pull request.
Andrei Solntsev
2015-12-16 18:27 GMT+02:00 fabienbancharel<EMAIL_ADDRESS>
"what about implementing this logic in method open("#GwtPlace2") ?"
I was more comfortable to add a new method than to modify an existing one,
but yes, it is a good idea.
Do you close this pull request ?
Do you want me to make another one, or do you prefer to implement it ?
—
Reply to this email directly or view it on GitHub
https://github.com/codeborne/selenide/pull/254#issuecomment-165164500.

Well, good point.
Ok, let's use the method updateHash
Andrei Solntsev
2015-12-16 20:18 GMT+02:00 fabienbancharel<EMAIL_ADDRESS>
In fact, there could be a problem if it is implemented in open() :
At the beginning of a test, open("#HomePlace:") is expected to make a
first request to the server with the start url + "#HomePlace:".
If open("#HomePlace:") just updates the location.hash, it misses the first
server call needed for Single Page Applications.
You would have to do :
open(""); open("#HomePlace:");
which is not exactly the same as open(startUrl + "#HomePlace:");
Maybe a specific method is preferable ?
(updateHash, openHash, gotoHash ...)
What do you think ?
—
Reply to this email directly or view it on GitHub
https://github.com/codeborne/selenide/pull/254#issuecomment-165196793.

Just for your information, I have also added tests for the new method updateHash(). See https://github.com/codeborne/selenide/commit/b4c75a1b8da980c73e36b89f940062b982836edc
It will be released soon in Selenide 3.0


Multiple installations of google tag manager detected

When I analyse my site using Google Tag Assistant browser extension I get a warning saying
multiple installations of google tag manager detected

I am wondering if anything else has seen this issue?
I am not sure if it is a problem with vue-gtm or with Google Tag Assistant

We are running into this issue as well. hasScript in utils.js always returns false. document.getElementsByName('script') needs to be changed to document.getElementsByTagName('script')

I am running into this issue, too


Sift does not compile in Xcode 14.3

Sift 2.1.1 does not compile when attempting to run in Xcode 14.3. There's 23 issues such as:

.../App/Pods/Target Support Files/Sift/Sift-umbrella.h:13:9 double-quoted include "SiftCompatibility.h" in framework header, expected angle-bracketed instead
.../App/Pods/Sift/Sift/Sift.h:8:9 double-quoted include "SiftEvent.h" in framework header, expected angle-bracketed instead
.../App/Pods/Sift/Sift/SiftEvent.h:5:1 use of '@import' in framework header is discouraged, including this header requires -fmodules

Hi @jordanhbuiltbyhq , thanks for bringing this one, we are working on the fixes

Hi @jordanhbuiltbyhq, could you please provide more information about this issue?
What version of Xcode was used?
What is the iOS deployment target?


Atom 1.3.1 Hangs when opening files of the same name in similar folder names

crashTest.zip
Directions to reproduce:

Unzip file.
Open the root folder of the zip as a project
Open all of the index.js files
Upon opening the third index.js file, Atom will hang.

Same issue is happening for me with Atom 1.3.2 on Mac 10.11.2, even in Atom safe mode.
atom --safe crashTest
use the file tree to parent1/subfolder1/index.js, then parent2/subfolder1/index.js, then parent2/subfolder2/index.js
It looks like it's probably related to the tab renaming code.

I have the same issue

This has already been fixed in the 1.4.0 betas.


On LAION 400MB found 450K corrupted images

Did anyone experience this issue? Download and resize steps finished fine (to size 224x224)
This is the command I used:
img2dataset --url_list older --input_format "parquet"\
         --url_col "URL" --caption_col "TEXT" --output_format webdataset\
           --output_folder your_output_folder5 --processes_count 64 --thread_count 32 --image_size 224\
             --enable_wandb False

Resulting image sizes are between 1000 - 3000 bytes with 1411 very frequent.

Can you check if it's a problem of the source (that would be more or less normal) or a problem of the tool ?
For example try to find one such url.

I would love to test that, but I am not sure how do I link between the metadata from the parquet, and the numbering of the image and tar names. Since it seems the numbering is consecutive and some images failed during download so their images are skipped Any documentation on that?

HI @rom1504 thanks for your guidance I was able to find the urls and confirm that the original images where fine, here are some examples of original images that got messed up:
2184,pois_rouge_fond_orange,http://s3.amazonaws.com/spoonflower/public/design_thumbnails/0052/7847/rrpois_rouge_fond_orange_shop_preview.png,398762169,success,,224.0,224.0,470.0,403.0,{},372694e5ab0eee9ea7a16491745c061f
2293,The Big Lebowski,http://images5.fanpop.com/image/photos/30900000/The-Big-Lebowski-the-big-lebowski-30926827-357-500.png,398762299,success,,224.0,224.0,357.0,500.0,{},e3cd92ef2df679f424e1b87428db4d02
2614,FEBRUARY_SPRING_SERIES_SPOONFLOWER,http://s3.amazonaws.com/spoonflower/public/design_thumbnails/0183/4917/rFEBRUARY_SPRING_SERIES_SPOONFLOWER_shop_preview.png,398762616,success,,224.0,224.0,470.0,403.0,{},79efbe531ab6c9315d6a27a6eeeb7360
3061,Catelyn Tully Stark - catelyn-tully-stark fan art,http://images6.fanpop.com/image/photos/33700000/Catelyn-Tully-Stark-catelyn-tully-stark-33727457-89-120.png,398763067,success,,224.0,224.0,89.0,120.0,{},54dc4776033bde2ddd6a17c87ca6fdf2
6570,The Austrian Ocean Race Project,https://i0.wp.com/ocean-racing.at/wp-content/uploads/2020/06/Logo_OceanRacing_CLAIM-NEU_NEG.png?fit=827%2C463&ssl=1,398766525,success,,224.0,224.0,827.0,463.0,{},4a801705ba1722142d3e0385749a880b
6589,"Logo Sabine Reitmayer-Wawer Business Coaching, Sparring und Facilitation",https://www.wawer.at/wp-content/uploads/2020/07/Sabine-Reitmayer-Wawer-LOGO-Wei%C3%9F-auf-transparent-Coaching-Sparring-Facilitation-600x200.png,398766578,success,,224.0,224.0,600.0,200.0,{},fc8d4126d4c50a552bdafcf35f68d391
7328,"Pro Safety & Rescue, Inc.",https://cdn.shopify.com/s/files/1/0739/7233/t/23/assets/logo.png?1988037197299676201,398767307,success,,224.0,224.0,560.0,170.0,{},6024c603493e923a5f6fcea199bc2db8
7396,Graphing Impact and Urgency of tasks,https://mattheweppelsheimer.com/wp-content/uploads/2014/12/Value-Quadrants-Diagram-2-Impact-and-Urgency-1024x768.png,398767411,success,,224.0,224.0,1024.0,768.0,{},01afe84329fd0a6a8c9f19a6bb2f197f
7657,rainbow green fabric by fabricfaeries on Spoonflower - custom fabric,http://s3.amazonaws.com/spoonflower/public/design_thumbnails/0129/3756/rrrainbow_shop_preview.png,398767664,success,,224.0,224.0,470.0,403.0,{},2e70acd73e829b5ece85e751a9c1cb62```

For example link is http://studybibleforwomen.com/wp-content/themes/studybibleforwomen/images/study-bible-for-women.png, key is 398761167, tar is 39876 image is http://studybibleforwomen.com/wp-content/themes/studybibleforwomen/images/study-bible-for-women.png,398761167.jpg

![398761167](https://user-images.githubusercontent.com/4495523/203595546-a0182c1d-1346-4f29-8529-fbc59c94e136.jpg)
![study-bible-for-women](https://user-images.githubusercontent.com/4495523/203595928-e8095a43-e157-48f7-aa1e-d2bff0e30c99.png)

Image is only 2189 bytes.

Hi @rom1504 I have run the unit test by changing the following code.
I put the attached image into the resized image test folder and remove everything else form there.
There is no error returned but there is a messed up image resulting.
I suspect it is related to RGBA channel or image size or both.
@@ -67,16 +67,18 @@ def test_resizer_filter():
     test_folder = current_folder + "/" + "resize_test_image"
     image_paths = glob.glob(test_folder + "/*")
     resizer = Resizer(
-        image_size=256, resize_mode="no", resize_only_if_bigger=True, min_image_size=200, max_aspect_ratio=1.5
+        image_size=224, resize_mode="keep_ratio", resize_only_if_bigger=False, min_image_size=2, max_aspect_ratio=200, encode_format='jpg'
     )
     errors = []
     for image_path in image_paths:
         with open(image_path, "rb") as f:
             img = f.read()
             image_original_stream = io.BytesIO(img)
-        _, _, _, _, _, err = resizer(image_original_stream)
+        img, _, _, _, _, err = resizer(image_original_stream)
+        with open("stam.jpg", "wb") as f:
+            f.write(img)
         errors.append(err)
-    expected_errors = [(None, 2), ("image too small", 2), ("aspect ratio too large", 3)]
+    expected_errors = [(None, 1)]
     for expected_error, count in expected_errors:
         assert count == errors.count(expected_error)

Here is the image that is not resized properly.

interested by a fix


Cannot add account (2.2.5)

Installed fine. Went to /symphony/extension/twitternotifier/accounts/new/ clicked Sign in with Twitter button, popup opened with a Symphony error:
Unknown column 'Failed to validate oauth signature and token' in 'field list'
An error occurred while attempting to execute the following query
INSERT INTO `sym_authors_twitter_accounts` (`Failed to validate oauth signature and token`) VALUES (NULL)

Wait wait, I didn't add my shit into the config file first.

You wouldn't believe how many people miss that.
I need to get some decent error catching here somewhere, but don't really know how to...

I think this would be as simple as in the connect popup, check the key values from the config file and if they are empty, display a message to the user. Could be as basic as die('You have not yet set your application keys in System Preferences.');

Good idea Mr Dunn.


[HASS] Show warning when renaming device to name containing 'æ', 'ø' or 'å'

Is your feature request related to a problem? Please describe.
When ZwaveJS2MQTT publishes a disovery topic for home assistant that contains any of the Norwegian/Scandinavian characters Æ, Ø or Å, home assistant fails to discover the device. I've created a issue for it in the home assistant repo here
Describe the solution you'd like
It would be nice if ZJ2M showed a warning, or refused to update the name of a device if it contained any of the above characters (and possible others). Something like the error at the bottom of this page.
Describe alternatives you've considered
Either a warning should show, or it should refuse to change the name.
Additional context
Something like this is what I had in mind:

I might be able to implement this myself if you think this is a good idea. I just have to finish all my exams first 😛

@AlfHou I had users asking me to add some more allowed chars like Norwegian/Scandinavian ones, I think this should be handled by the user, those chars are allowed on MQTT side

Perfect! I'll take a look at adding some sort of warning if home-assistant discovery is turned on then.

Is used about four hours on this issue before i noticed that it was only devices that contained 'æøå', was not discovered by hass. So a simple warning that hass is not able to discover it would be nice.

@slippern Are you using z2m with mqtt discovery or zwavejs integration?

@slippern Are you using z2m with mqtt discovery or zwavejs integration?

Im using z2m with mqtt discovery.


Add option to add classes to list elements

I would like to add bootstrap classes to style the <ul>, <ol>, and <li> elements, and it would be nice if there was some sort of option so you could call the toc() function with a classes parameter for <ul> or <ol> elements, accordint to listType parameter, something like:
$('#toc').toc({
    listType: 'ul', // values: [ol|ul]
    classes: 'nav, nav-stacked',
});

So the <ul> element has the appearence of nav-stacked elements according to bootstrap

Could I tempt you to submit a pull request?

I just hardcoded them into my project, I'm not proficient in JavaScript so that's why I made the suggestion

I think that this issue can be closed now.


Quantizers are not DDP/AMP compliant

Hi Lucidrains,
Thanks for the amazing work you do by implementing all those papers!
Is there a plan to make the Quantizer be compliant with:

DDP - They need an all gather before calculating anything so the updates are exactly the same across all ranks
AMP - In my experience, if AMP touches upon the quantizers it screws up the gradient magnitudes making it NaN/Overflow

If you want I can have a go at it.

@danieltudosiu Hi Daniel! No that would be great! Always welcoming contributors :)

@danieltudosiu do you want to see if https://github.com/lucidrains/vector-quantize-pytorch/releases/tag/0.4.8 fixes the AMP issue?

as for DDP, i'm guessing just need an allreduce at these two lines? https://github.com/lucidrains/vector-quantize-pytorch/blob/master/vector_quantize_pytorch/vector_quantize_pytorch.py#L153-L155

as for DDP, i'm guessing just need an allreduce at these two lines? https://github.com/lucidrains/vector-quantize-pytorch/blob/master/vector_quantize_pytorch/vector_quantize_pytorch.py#L153-L155

One reduction should happen here but only for the summation of the one hot encoddings (embed_onehot.sum(0)).
And one here for the summation of the embeddings (embed_sum).

@danieltudosiu do you want to see if https://github.com/lucidrains/vector-quantize-pytorch/releases/tag/0.4.8 fixes the AMP issue?

Regarding the AMP part, I am not actively using this codebase since we are close to finishing the project and we have a more barebone implementation ourselves, I was just signalling the issues so after the project I can move to this library ;) .

@danieltudosiu got it! thanks for your input :)

@lucidrains  just to be clear the all reduce should be something like this:
    import torch.distributed.distributed_c10d as dist

    if dist.is_initialized():
        dist.all_reduce(tensor=encodings_sum, op=dist.ReduceOp.SUM)
        dist.all_reduce(tensor=dw, op=dist.ReduceOp.SUM)

Where encodings_sum is your embed_onehot.sum(0) and dw is your embed_sum.

@danieltudosiu hey yup! i think sum is by default anyways :)
https://github.com/lucidrains/vector-quantize-pytorch#ddp


Add gtest to jvsio for testing

I may want to have unit tests now as there will be cases I can not reproduce it with my local environment, but got detailed report to fix an issue.

added


Create 1732. Find the Highest Altitude.java

merge conflict error
Kindly sync your fork once and file the PR again


Added recently played endpoint

Added method to get recently played tracks for the logged user

thanks for the PR


how to know is grid editing (without callbacks)

I am updating a grid periodically by setTimeout (by entire rerender).
But I don't want to, if user is editing fields.
How to get current grid/cell state in such a moment?
I don't want to plug callbacks, because of global variables, multipurpose of same grid, and general mess in code. Is there another "method" to reach cell state?
thanks

this is implementation detail so it might change without notice in later versions  you should use documented APIs ,but here you go:
if $(temp1).data('JSGrid')._editingRow  is not null then we are currently editing that row.


TAB Navigation Highlight

When selecting a button with TAB, items in the sidebar and at the bottom of the page to not get highlightes, while objects in the center of the page do correctly get highlighted

In the attachment, I have marked all areas that do not correctly get highlighted in red, while areas that do correctly highlighted are green

Moonlight does not support tab controls

for not specifically implementing it, it works actually pretty well


Require at least one filename

Description
Currently running without any arguments does nothing, with no output:
$ django-upgrade

Kinda useless.
The filename arg should be updated to require at least one filename.

@ddaan

Fixed in #242.


Fixing problem with not passing end_str for historical_klines

I was testing out historical klines and it seemed like end_str was never being respected in regards to the request. Ended up taking a look at the code and saw that end_str was always set to None and so was never used. Would appreciate this getting merged and released with the next version as the workaround is rather messy. Thanks!

You didn't notice the limit param is also not being used :)

You didn't notice the limit param is also not being used :)

Good eye! Hah I was focused on end_str since that was what caused my headaches but thanks again! :)

thanks @RyanLiu6, this is being included in the v1.0.0 release shortly


api to add ssh key for spec user

as the title

Please follow on https://github.com/gogits/gogs/issues/976


flynn run bash returns 404 on unpushed

When running flynn run bash prints an uninformative 404 error on a project that has been created but no push has been done.

@holtgrewe when I create an app and then run flynn run bash, I get a slightly more informative message:
$ flynn create test
Created test

$ flynn -a test run bash
No app release, specify a release with -release

This is expected because the app has no release (i.e. I haven't pushed any code to create a release).
Can you perhaps include the commands you ran and the exact output that you saw?

I think I also set some environment variables
$ flynn create flynnpoison
Created flynnpoison
$ flynn env set foo=bar
Created release dd891c37-bbed-425f-830c-17e8a3494750.
$ flynn run bash
POST https://controller.cubipaas.bihealth.org/apps/flynnpoison/jobs: httpclient: unexpected status 404

@holtgrewe ok I see the issue, and it is in fact more of a bug on the nightly release (it causes flynn-host to panic). Fix proposed in #2805.


Instructions missing

Instructions only say to 'pip install mbdata' then adjust mbslave.conf.default.  However this file does not appear to exist unless cloning the repository (according to my find query and general poking around).

Fixed in https://github.com/lalinsky/mbdata/commit/bdb9d31ce268afc690c3ce479cd1bb64fcc63d82

My apologies if it is my stupidity, but other than via cloning https://github.com/lalinsky/mbdata.git I don't know how to find this newly included mbslave file.  After running the pip install -U mbdata it doesn't seem to be anywhere.  When looking at the list of files that are uninstalled via pip uninstall mbdata, it is not listed.  Does the python package manager need time to receive the changes?

I've just seen this part - thanks.
curl https://raw.githubusercontent.com/lalinsky/mbdata/master/mbslave.conf.default -o mbslave.conf
vim mbslave.conf


[WFCORE-5285] Utilize o.w.common.Assert for Null-Checks (protocol)

Fixing https://issues.redhat.com/browse/WFCORE-5285
Original PR was too big to verify. It has been splitted up, here: protocol

@boris-unckel thanks for all the PRs, I've merged them all now that they were approved.

@jmesnil thanks for review, support and your patience :-)


[SPARTA-618]Create .jenkins.yml file

:shipit:

Comment accepted. Will treat it ASAP

Comment accepted. Will treat it ASAP


#5 refactoring of location search

The server side function locationByDistance  must be refactored. see #5

is ready. The DB still needs to be updated


Added ARIA: TableAria #18 and CellAria #14

What Changed
Readme File with TableAria Content
Readme File with CellAria Content
Added Table Role
Added Cell Role
Why
This PR is in reference to #14 and #18 which required adding Table and Cell accessibility feature.

@kendallgassner  mam please review this if it is fine or not.


list devices

Parsing service name for Chromecast does not work (version HD)
´TypeError: Cannot read property 'name' of undefined
at nodecast/lib/devices/chromecast.js:50:25´
I used the list-devices.js file provided.

Issue is: https://github.com/contra/nodecast/blob/master/lib/devices/chromecast.js#L50
Can you leave a console.log(parsed) on line 48 and see what it says?

Sorry, I did it and forget to tell about.
It's empty dictionnary : {}


netherite harvest level reported as Metite

"cimtb.harvest_level.level.4": "§dMetite",
should be
"cimtb.harvest_level.level.4": "§dNetherite",
or
"cimtb.harvest_level.level.4": "§8Netherite",

no, it indicates what kind of material can be mined on that level, netherite can be mined with a level 3 pick, metite can be mined with a level 4 pick


Tasks for Milestone 3

Scripts

Add docstrings, tests, and code comments to all scripts -- Alistair, Alex, and Aakanksha (low priority is adding test to analysis script)
Check all scripts work for all team members
Write Makefile (don't forget Rmd render, change directory to remove quotes -- Alistair

README -- Alex

Add overview of project structure with links? (e.g. The final report can be found here.)
Add correct dependencies (e.g. xgboost, lgtm, and R)
Re-write Usage section

Report -- Aakanksha

Update section 'Limitations' and 'Future improvements'
Add rationale for why we chose the 3 models we chose (mention in 'Future Improvements')

FINAL SUBMISSION

Create a release (submit a link to the tag!!!)

Point 1 - Docstrings for Analysis script functions updated
Point 3 Report: Suggestions addressed

Add tests to wrangling scripts
Add links to final report and scripts in the README
Add correct dependencies (e.g. xgboost, lgtm, and R)
Updated the Usage section

By the way, I think the README/proposal and the final report matches perfectly. There is nothing much to update in the README to reflect the result of the final report. (I just updated the motivation part a bit.)


positivity constraint on season not respected

I am running a model with the following options
prophet_vars = c("trend", "season", "holiday"),
prophet_signs = c("positive", "positive", "positive"),

but when I examine pareto_alldecomp_matrix.csv (and just focus on a particular model of interest) then I see both positive and negative values. The positivity constraint does not seem to be applied.
I'd be grateful if you could confirm that this is a bug. If it is, I'd be even more grateful if it could be fixed.
Environment & Robyn version
R version 4.0.4
Robyn version 3.6.1 (installed by remotes::install_github('facebookexperimental/Robyn/R'))

Checking the code, I don't see any obvious error or bug. I'll further run a hypothetical check without your data to reproduce this scenario first before I get back to you.. thanks for reporting it.

Hey @drbenvincent
We've internally discussed this specific case you mention and actually find it quite relevant. We think this is probably one of those very rare cases where it should probably be something only advanced users do and we generally try to discourage, given that forcing a sign for season/holiday logically may not make much sense in most scenarios.
I'd also like to share with you this ticket where prophet's team discusses this matter with great detail and some illustrated examples.
CC: @Leonelsentana @kyletgoldberg

Thanks for that link @laresbernardo. I'll work through that - it looks to touch on issues I've been thinking about.
Just a bit more on the motivation... I'm trying to produce a contribution plot, as in a stacked area plot over time which decomposes the total predicted outcome variable over time into its various component parts. You could argue that (regardless of the implementation details) it would be appealing (and should be possible) to plot the contributions over time from each channel, intercept, trend, seasonality, etc.
So I'm a little uncertain at the moment if there is a working positivity constraint or not?
But given that the seasonality component is producing positive and negative numbers that it's additive (not multiplicative). If so, I guess you might get positive only contributions from intercept+seasonality.
Either way, it should be possible to find the maths of the seasonality implementation (presumably in Prophet) that would allow generation of a contribution plot over time from the fitted parameters from Robyn.

I observe the same issue.
Training the model with the "positive" constrains to all prophet variables results in negative effects at the decomposition waterfall. Some models have negative season effect, some models have negative effect of holidays and weekday.
Robyn 3.6.3

Please reopen if this issue reoccurs.


Fix stats collection for JDBC based connector

please

change createJdbcClientWithStats return type to StatisticsAwareJdbcClient
change commit message to something like Expose JdbcClient invocation statistics in JMX

as this remains fragile still, can we have a test for this?

@findepi Thanks for your feedback and for the commit message.

change createJdbcClientWithStats return type to StatisticsAwareJdbcClient

This might break DI there by JdbcClient might not be injected in CachingJdbcClient

This might break DI

you're right

@kokosing Thanks for your feedback. Have applied your comments


Add support for release notes from bundles

Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.

Motivation and Context
For projects that use AAB instead of APK, the release notes functionality of fastlane wasn't working. This is because the upload_changelogs functionality specifically looks for APK version codes - which obviously don't include AABs.
Another approach would be to change the apk_version_codes client library call to also include bundles. This felt like it would be more disruptive for other use cases.
Description
This PR is quite simple - it extends the client class to be able to list bundle versions in addition to APK versions. It then uses this in uploader to upload changelogs for bundles as well.
This was tested locally by using the "dry run" functionality to verify upload of metadata succeeded on a project with bundles. No errors were reported from Play using the new uploads.

Thanks for the rapid review, @joshdholtz! Added the method to the client_spec test - good catch!


Arrangement and execution of the meeting for basic usage of dynamic systems from DynPy library (issue #1027 related)

The goal is to arrange and execute the meeting for basic usage of dynamic systems from DynPy library. The following things should be prepared:

[x] scope and schedule of meeting (in one week);

[x] conducting team (in two weeks);

[x] guide or instructions with examples (one week before meeting);

[x] announcement (in Slack and Teams channel) with basic information (conducting persons, date,scope,schedule) (one week before meeting);

[x] exemplary code in Jupyter (link) (one week before meeting).

Meeting has been executed.


ReferenceError: reactive is not defined

When I call useHttp(), I got this error.

Ive pushed an update


ValueError: Only one class present in y_true. ROC AUC score is not defined in that case.

Dear Roman,
I split my data by I1f method,   which makes the test set size=0.1
datasail --f-type P --f-data All_sequences.fasta --f-sim cdhit --output split_SCIP_I1f --techniques I1f --splits 0.8 0.2  --names train  test  --solver SCIP  --f-args "-M 10000" --to-sec 1000

I got this error during the plotting AUC curve
File "/scratch/SCRATCH_SAS/vahid/ESP/notebooks_and_code/TGBM_EM1bts_ECFP.py",
line 121, in <module>   roc_auc = roc_auc_score(np.array(test_y), bst.predict(dtest))  File "/home/vat23/miniconda3/envs/ESP/lib/python3.9/site-packages/sklearn/metrics/_ranking.py",
line 572, in roc_auc_score   return _average_binary_score(  File "/home/vat23/miniconda3/envs/ESP/lib/python3.9/site-packages/sklearn/metrics/_base.py", line 75, in _average_binary_score   return binary_metric(y_true, y_score, sample_weight=sample_weight)  File"/home/vat23/miniconda3/envs/ESP/lib/python3.9/site-packages/sklearn/metrics/_ranking.py",
line 339, in _binary_roc_auc_score   raise ValueError( ValueError: Only one class present in y_true. ROC AUC score is not defined in that case.

when I set the --epsilon 0.0 the   test set size =0.2 and, I didnt get this error during plotting ROC AUC curve.

Hey @EasternCaveMan,
DataSAIL assigns data points within the epsilon error margin to the split. That is a hard constraint. In the solution space within these hard constraints, DataSAIL optimizes splits based on the weighting of data points and similarities between data points.
Depending on the dataset it may happen that the test set only contains datapoints with one label.
For now, you can use the --runs option to create multiple splits and check for one where samples from both classes are present in the test set. From version 1.0.0 on you can specify stratification to balance classes in each split.If you install DataSAIL from source (branch dev_1.0) you can already use a beta-version of it (it's not fully tested and documented yet).
Best, Roman


OTP SEND but not received.

Hi, I'm using some e-mail from go-daddy and successfully changed the SMTP server.
The problem is whenever I click send It will return true value on flutter means that the process is successful.
I don't know why I can't receive an OTP.
here's the heroku logs.

This is fixed. just some tweeks at mailer.py

@PickappJhay
Hi, did you mean you use godaddy instead of heroku??
if so, could you share how to do that??


docs: describe the problem of using <RouterView> rather than <NuxtPage>

🔗 Linked issue

https://github.com/nuxt/nuxt/issues/25089
❓ Type of change

[x] 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Describe the problem mentioned in https://github.com/nuxt/nuxt/issues/25089.
📝 Checklist

[x] I have linked an issue or discussion.
[x] I have added tests (if possible).
[x] I have updated the documentation accordingly.

cc @manniL

I would like to point out that the live preview generated by nuxt-studio bot seems to not reflect the changes in the PR.


Upgrade to rails 6

I pulled from this branch but it's not working for me (I'm using Rails <IP_ADDRESS>).
Whenever I try to query something on a table, this is the error I get
ODBC::Error: 5 (606) N


refactor(utility): remove inherit class "ReprMixin" in "URL"

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.133%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
7530

Relevant Lines:
8642

💛  - Coveralls


Bullet point list bug

Hi @JiHong88,
I have identified a bug with the bullet list.  To reproduce:

Inset some normal text at the top of the editor
Start a bullet point list (bullets or numbers)
Fill in the list to contain say "Item1, Item 2, Item 3, Item 4" as bullet points
Place the cursor at the start of Item 4 (between the bullet and the letter 'I') and press backspace

Expected behaviour: List item 4 removes the bullet point, and continues to backspace normally until it joins the end of list item 3 and the rest of the bullet list remains in place (refer say the same behaviour in an email editor)
Actual behaviour: List item 4 is added to the end of whatever line of text preceeds the bullet list and the bullet items 1 through 3 are now presented in reverse order as paragraphs without bullet points

setup to reproduce:

result:

Hi @DeZZar
Thanks for the detailed explanation.
Fixed in v2.15.0.
Thank you :)

@JiHong88 thank you for the support.  Tested in v2.15.0 and working as expected!

There was a critical bug in version 2.15.0.
Fixed in v2.15.1.
Thank you.

HI @DeZZar ,
Fixed again v2.15.2


Link to libraries when disabling use_std

This crate currently relies on libraries being linked to come from libstd, but
if use_std is disabled that's not true! In that case we need to pull in the
libraries ourselves.


Internal SPIFF logger optimization

if state != cruising && state != stopped
end
if acceleration == 'stagnant or stoppped'
state = 'cruising'
end
if currentSpeed < 1 kmh
state = 'stopped'
end

will not log into spiffs, too little memory size


Thread was being aborted.

So during our custom deployment in our grunt build task from time to time the deployment fails with
[...]
Running "cdnify:dist" (cdnify) task
Going through dist/client/index.html to update script refs
(node:6672) fs: re-evaluating native module sources is not supported. If you are using the graceful-fs module, please update it to a more recent version.
✔ bower_components/angular/angular.js changed to //ajax.googleapis.com/ajax/libs/angularjs/1.5.0-beta.1/angular.min.js
✔ bower_components/angular-animate/angular-animate.js changed to //ajax.googleapis.com/ajax/libs/angularjs/1.4.7/angular-animate.min.js
✔ bower_components/angular-cookies/angular-cookies.js changed to //ajax.googleapis.com/ajax/libs/angularjs/1.5.0-beta.1/angular-cookies.min.js
✔ bower_components/angular-resource/angular-resource.js changed to //ajax.googleapis.com/ajax/libs/angularjs/1.5.0-beta.1/angular-resource.min.js
✔ bower_components/angular-sanitize/angular-sanitize.js changed to //ajax.googleapis.com/ajax/libs/angularjs/1.5.0-beta.1/angular-sanitize.min.js

Running "cssmin:generated" (cssmin) task
>> 2 files created. 864.96 kB → 236.81 kB

Running "uglify:generated" (uglify) task
Thread was being aborted.
Thread was being aborted.

I can ensure that the build scripts are working fine locally and even on other cloud hosters like Amazon or Heroku. Even on Azure it works from time to time and thats the frustrating part because we can't reliable reproduce the error. Maybe it is an performance problem (I noticed Azure is horrible slow on nodejs deployments) and a timeout kicks in because the thread is not responding or taking to much time? This is only speculating hope you guys have a better idea.

Can you share your web app name, either directly or indirectly, and the time of one such fail deployment? Maybe we can see what's going on.

Yeah of course: http://ydm.azurewebsites.net/. I guess the error is occuring when I try to deploy a fresh app without bower and grunt dependencies cached by azure. I don't have a specific time because for now I only get the error described in #2088.

I tried deploying the repo in a Free site and it failed. I then tried in a Standard site and it worked (other than hitting #2088 in the next deploy, but that's separate).

Thank you for your effort. Have to admit this is hard to debug and to track down as a non Azure spezialist. I am a student and trying to use Azure infrastructure for my bachelor thesis (MSSQL Database, PHP-Webservices and AngularJS Client). Is there any chance to get my Free site upgraded to Standard for a limited amount of time without having to pay €63/month (thats far too expensive for research)? Anyway I appreciate your efforts in advance.

I cannot easily do this, but note that you only get billed for the time you use (see https://azure.microsoft.com/en-us/pricing/details/app-service/). So if you want to test with a B1 (Basic) instance for a few hours, it wouldn't cost much (€0.0632/hr).

So I tested it on a basic and standard plan and the error still occurs. The last deployment I made shows this thread aborted error. However the error does not always occur, looks like it is rather random.
[...]
Running "concat:generated" (concat) task

Running "ngAnnotate:dist" (ngAnnotate) task
>> 2 files successfully annotated.

Running "copy:dist" (copy) task
Thread was being aborted.
Thread was being aborted.

One of the reason might cause by SCM_COMMAND_IDLE_TIMEOUT environment variable in your Application settings. By default if you don't specify the value is 60 (seconds). This means that when there's no output from console up to 60 seconds, the thread will aborted and build is failing. I normally set this value to 300 (5 minutes) or more if necessary.


Add Kits

A "Kit" is a collection of stuff that goes with a Session.  Lab equipment, teaching tools, etc.  One or more kits can be associated with a Session.  A kit should have a unique name and a description.  Lastly, we must prevent double-booking.
You'll need to create a new Kit model with name, description, and M2M relationship to Session.  Then we need a bit of validation to make sure it never gets associated with two Sessions that overlap in time.
Finally, we'll need a RPC method on the KitManager that will tell us what kits are available during a given time span.  So it will take a start time and end time, and return a list of kits with their name and description.  Probably it will be best to find the list of available kit PKs, then return the results of a call to get_filtered().  Something like this:
   def find_available_kits(self, auth_token, start, end):
        pks = #do stuff here to find available kits
        return self.get_filtered(auth_token, {'member' : {'id' : pks}}, ['name', 'description'])

OK, now that I've reviewed the docs and the related Session, Event, and Resource types, I have a few questions:
1. Can a Kit be a requirement for a Session (like required Resources)?
see SessionTemplate, SessionTemplateResourceTypeRequirement
2. Is a Kit ...

a subtype of Resource?
an unordered collection of Resources?
a collection of some other objects?
just a name and string description?

3) Should a Kit be uniquely named (at least among Kits) to avoid confusion?
4) Is each Kit an actual collection of stuff, or are Kits intended to by typical (a la KitType)?
So far I'm assuming each Kit is a unique, indivisible thing, since we can't use a Kit in
more than one Session at a time. But I see no such restriction on Resources, which seems odd.
5) Is a Resource a unique, concrete object or a generic description?
EXAMPLE:  'digital projector' vs. 'Favi E3-LED-PICO (No. 3, West Building)'
EXAMPLE:  'small conference room' vs. 'Meeting Rm 204 (Smith Hall, Main Campus)'
6) Is a Kit (like an Event) a lightweight container that gathers meatier Resouces within, for purposes of validation and other business logic?
7) Should we check against a Kit (ie, its contents) to verify/satisfy req'd Resources for its Sessions?

These are my best guesses so far, based on the information provided:

A Kit is a named, unordered collection of unique, concrete Resources
Checks for required Resources will be made by testing all related Kits' contents
Each Kit should have a unique name, to avoid confusion
Attempting to schedule a Kit should also check its Resources for "prior commitments" during this time
"Double-booking" a Resource (as standalone and as part of a Kit) on a single Session should be detected, and the standalone Resource should be removed (the Kit remains). We probably need to explain this to the user when it happens.

If I'm correct, this is a more complicated situation than it appears at a glance. I'll start coding the obvious (basic tests and classes), but hopefully you can shed some light on the questions above before I go much further.

1 & 2) Good catch!  I don't think we ever used the Resource model in a live system, and I'd forgotten about it.  I think the Resource model IS a Kit.  Let's just add the description field to both Resource and ResourceType, and then add the validation and method I described.

yes

a Kit (Resource) is a concrete thing with a unique name.  We can optionally use the ResourceType model to categorize them, but that shouldn't be a requirement.

unique, concrete object.  A Resource Type would be "projector", and a Resource would be "Favi E3-LED-PICO"

nope, Resource is Kit

I don't think we have a need in this project to do this, but we can add it later if needed.  If we did something like this, it would be this: A SessionTemplate would have a M2M relationship to ResourceType (might already exist?), and then a Session based on that SessionTemplate would need to have Resources that satisfy the specified ResourceTypes.  But again, I don't think we need that yet.

Hopefully that clears things up, but send more questions if it doesn't!

OK, so it sounds like I should not add the Kit model, but instead improve the existing (but unused) Resource model to get the desired behavior. Will do.
Note that the existing definitions of Session and Resource should already support required Resources--see Session.session_resource_type_requirement
I see that Resource (and ResourceType) already have a notes field (M2M with Notes). I'll assume the description field is different and add it. I'll also add the validation and method as requested. OK for me to stick with Resource (instead of Kit) as the name?
Re: #7, yes, this M2M relationship between SessionTemplate and ResourceType already exists, at least I think it's sketched in. I'll walk the code and try to finish up whatever's missing, and write some tests to confirm.

Let's stick with the name "Resource".
"Notes" are another thing that I don't think we've ever used in a production system.  None the less, I do think that notes about something are a different idea than a formal description of it.  Thus, I do think we should add the description fields.


Deal with slugify's stripping o with macron (ō)

Until this gets merged we should manually add ō mappings to our slugify use.

Already done in src/events/scraper/run-scraper/scraper-helpers/get-iso2-from-name.js.
Since its a singleton it'll get used within that lambda (only place that needs it as far as I know?)
Shall we close this or theres something else to do?

This is merged upstream now. We can remove in the util in this repo.


Abacus rebase

I've looked at a couple files like FhirStu3.Java and FhirR4.Java, and I've tested this successfully with FHIR Patient Generator, but since this is too much to really review all of it, are there any other specific diffs you think could affect our stuff, or are there any other places you had to resolve conflicts?

I think those two files are the big touchpoints into Synthea that we've had to change. There were also some merge conflicts I had to resolve in synthea.properties, so that's also worth taking a look at. Other than that, if you don't see any major issues, and the rebased version works for you, I think that's probably a decent review?


ERROR running force:source:deploy:  this.isRestDeploy is not a function

Summary
I've just updated CLI to the latest version, upgraded all my DX extensions, and tried a simple deploy. I've done this previously many times with no issue.
After I've done the validation step, trying to deploy the JobID produces the error
ERROR running force:source:deploy:  this.isRestDeploy is not a function
Steps To Reproduce:

use sfdx force:source:deploy --checkonly --sourcepath force-app --targetusername mysandboxorg --testlevel RunLocalTests
After that runs successfully use force:source:deploy --targetusername mysandboxorg --validateddeployrequestid 0Af5D00000ONSJhSAP
The error occurs immediately

Expected result
The deployment should have completed.
Actual result
Error received
ERROR running force:source:deploy:  this.isRestDeploy is not a function
Additional information
SFDX CLI Version(to find the version of the CLI engine run sfdx --version):
sfdx-cli/7.28.7-7bceba6f24 win32-x64 node-v10.15.3
SFDX plugin Version(to find the version of the CLI plugin run sfdx plugins --core)
@oclif/plugin-commands 1.2.3 (core)
@oclif/plugin-help 2.2.1 (core)
@oclif/plugin-not-found 1.2.3 (core)
@oclif/plugin-plugins 1.7.8 (core)
@oclif/plugin-update 1.3.9 (core)
@oclif/plugin-warn-if-update-available 1.7.0 (core)
@oclif/plugin-which 1.0.3 (core)
@salesforce/sfdx-trust 3.0.5 (core)
analytics 1.2.1 (core)
etcopydata 0.4.4
generator 1.1.1 (core)
salesforcedx 47.1.5 (core)
├─ force-language-services 47.5.0 (core)
└─ salesforce-alm 47.4.0 (core)
sfdx-cli 7.28.7 (core)
sfdx-migration-automatic 1.5.0
shane-sfdx-plugins 4.8.2
OS and version:
Windows 10 Pro
10.0.18362
I have a work-around to Quick Deploy the job in the Org, but it would be great for this to continue working.

Hi @JodieM, we have an internal work item (W-6803187) that is currently being worked on. I am closing this issue here and the fix should go out next week

@clairebianchi is there currently a work around for this?
I am setting up a CI environment for our deployments and this is currently a blocker for us. I have set it up the same as described but instead of using force:source:deploy I am using force:mdapi:deploy and getting the same error.

@SaoBiz you should be able to do a regular deploy instead of a validated deploy. Otherwise, you can go to the UI and select the quick deploy option in the deployment UI page if you would rather do a Validate and then deploy.
This fix is going into this Thursday's CLI release.


Add properties. Add new functionalists.

Add properties. Add new functionalists. Set system time, define operation mode, reset counters, filter raw_data_input

Superseded by #3


Add required define to enable st driver

Description
When adding the port for the STM32F7 driver, you need to define that the module is enabled.  The define might be automatically set when using the CUBE IDE but it is not if you're using the SDK directly, like from https://github.com/STMicroelectronics/STM32CubeF7
Test Steps
Try to add port, and you will get zero symbols out of the driver, in which case NetworkInterface.o cannot find required HAL symbols.
Related Issue
None
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rpcme wrote:

Can we leave the PR open and I work on reworking it to explain this file should be included prior to the HAL includes?

To @AniruddhaKanhere, @paulbartell:
That means that this PR was on hold until the text is ready. I know it is only about a README file, but the text is not in style with ST's custom of configuring a project.
Can a merge be undone? Or shall I propose a new text? What do you think, @rpcme?
Hein

I just wrote a new proposal for the readme.txt, see PR #372.


save as

"Save as" option - when testing or wanting to highlight certain aspects the ability to save a snapshot of the file process state would be quite useful.

Involves copying the scanned image, which might several hundred MB in size. Better handled as an undo #146


fixed Medium HTML Task

Created an HTML form with name , email and message field

Created an HTML form with name , email and message field

Well done!


BUG: Hover effect and Box shadow not found in your website

Is there an existing issue for this?

[X] I have searched the existing issues

What went down?
I want to add hover and box shadow effect in your website that makes your website impressive and provide a better experience of UI.

@mdazfar2 Assign this issue to me. I want to work on it.

Record

[X] I agree to follow this project's Code of Conduct
[ ] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@raviranjan0 Great issue raised, Go ahead


Hash avoid

@Garenbbbb To make this easier, How about get the lastest date from CSV file, then we just process any email after that date.

@Windsooon What if user only download mails from  Feb. to March to analyze, and next time he want to add mails in Jan. Lastest date from CSV file could be a option, but it cannot cover edge cases


change debug env var to MACHINE_DEBUG

This changes the debug environment variable detection to use MACHINE_DEBUG instead of DEBUG.  DEBUG is a bit vague and can be used in other things.

/cc @SvenDowideit

Does this need documentation changes somewhere? (LGTM otherwise, and fwiw) :)

much LGTM - unless someone wants to mention full on namespacing and make it DOCKER_MACHINE_DEBUG :speak_no_evil:

Oh god yes please, DEBUG is our web server, makes Machine so noisy!

LGTM


remove workflows that require repo dispatch

Remove docker_hub workflow as it's no longer needed

merged in https://github.com/ockam-network/ockam/pull/2368


The Android hardware back button does not minimise the app when pressed on the LHN/home screen

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Click on an a chat from the LHN
Once you're in the chat, press the back button to navigate back to the LHN/home screen
From the LHN/home screen, press the back button again

Expected Result:

When pressing the back button on the LHN/home screen, the app should be minimised (exited).

Actual Result:

When pressing the back button on the LHN/home screen, we navigate back to the previous chat that users was in.

Workaround:

None

Platform:
Where is this issue occurring?

[ ] Web
[ ] iOS
[x] Android
[ ] Desktop App
[ ] Mobile Web

Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Upwork URL: https://www.upwork.com/jobs/~017e60e720f6f9aca8
View all open jobs on Upwork

Triggered auto assignment to @mallenexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

I don't have Android, trying to find someone on the CM team to triage

Assigning to @laurenreidexpensify for review since she has Android and I don't.

To me this is reproducible.

@kp17211 @parasharrajat I'm trying to reproduce this and a bit confused.

Am on my Chats page
tap into a chat
within chat, tap top left hand < icon
taken back to chat page
swipe left as the generic Android "back" action
am taken to the chat I was just in

Am I missing something? Isn't this the expected behaviour?

am taken to the chat I was just in

This is an issue.
the flow should be

You click on any chat from LHN.
It takes you to the chat.
You click back button on android phone.
It takes you back to chat list / LHN.
You press the hardward back button again.
App should minimize.
But it will take you back to the recent open chat.

Ah got it - okay yes I can confirm this is the behaviour then. Will send this to our engineering team for next review.

Triggered auto assignment to @flodnv (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

I could've sworn this was a feature and not a bug (granted, that I found strange as well). What's the behavior on iOS?

What's the behavior on iOS?
I don't believe iOS has a "back" hardware button (at least most of their devices don't) so I think this only applies in Android.

I agree this should be fixed eventually, it's how most (if not all) Android apps work, so I'll take this over and making it External

Triggered auto assignment to @trjExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

The title of this issue is a bit generic and the steps in the OP are a little confusing, so it would be good to spruce this up before posting to Upwork. Before I make the updates, am I right in thinking the issue here is isolated to: The Android hardware back button does not minimise the app when pressed on the LHN/home screen?
Then the Action Performed reproduction steps are:

Click on an a chat from the LHN
Once you're in the chat, press the back button to navigate back to the LHN/home screen
From the LHN/home screen, press the back button again

Expected Results

When pressing the back button on the LHN/home screen, the app should be minimised (exited).

Actual Results

When pressing the back button on the LHN/home screen, we navigate back to the previous chat that users was in.

Let me know if that's correct and I'll update the issue. 👍 Also, not sure if it's helpful to reference for the implementation approach, but we had some wider inconsistencies with the Android back button a little while back here.

We should first look into React-navigation. It was previously fixed but after the upgrade of react-navigation to v6 broke that fix.

Nice @trjExpensify that looks like a great summary! 👍

Cool, updated. Upwork job is here. @kp17211 are you interested in applying seeing as though you raised this issue?

Hello @trjExpensify
yes I want to work on this issue

@kp17211 I think what @trjExpensify was asking if you want to submit a proposal for the fix :D

Not overdue, just waiting for proposals

Changing priority to weekly as we wait for proposals

@Beamanator I'm interested to work on the job. Submitted proposal at Upwork.

Thanks for your interested @Aamer-Rasheed ! Please make sure to follow these steps too: https://github.com/Expensify/App/blob/main/CONTRIBUTING.md#propose-a-solution-for-the-job

I've accepted @kp17211 proposal in Upwork, as he created the issue. Over to you! 👍

@kp17211 before you submit your PR could you please post your proposal here so I can review? 👍

Okay, @kp17211 has reached out to me on Upwork to say he has accepted another offer so won't have time for this. Unassigning! @kp17211 in the future, could you just drop us a note here please? We're far more active and on top of comms in the GH repo than we are the Upwork messaging tool. Thanks!

@Aamer-Rasheed are you still interested in this job? Please let us know how you plan to approach the solution and then we can proceed to hire and moving to the PR.

@trjExpensify Thanks for the query. Got another project with a deadline of 03 weeks so would be unavailable during this time.

Doubled price to $500 in Upwork

After debugging I found out this.

Drawer is handling the hardware back button when the Drawer is open. It triggers DrawerAction.CloseDrawer() action which opens it. I am not sure how that is supposed to work but it is the main cause of the issue.
And from some digging, App close behaviour is not handled for the Drawer Router. So we have to customise the hardware back button action with Backhandler.
But there is a problem that when the drawer is open hardwareBackPress event is consumed by the Drawer BankHandler which block our attempt to override it.
@marcaaron opened a PR days back to disable this behind a flag. https://github.com/react-navigation/react-navigation/issues/9511 but it was closed.

To fix this issue we have to do the following but I am not how to run this piece of code when the drawer is open as Backhandler'hardwareBackPress'never fires.
Run it on Backhandler'hardwareBackPress'
if(drawerisOpen) {
 navigation.dispatch(StackAction.pop());
 }

@trjExpensify  I'm interested to work on the job. Is this still available?

I got an invite from Upwork regarding this task. Is it still available? @trjExpensify @parasharrajat

Yes @Dev-Manny

@parasharrajat thanks for linking the previous issue opened by Marc! It looks like it was closed b/c we didn't respond back. In the issue, someone linked https://reactnavigation.org/docs/preventing-going-back/ - have you tried this code?

reactnavigation.org/docs/preventing-going-back . This does not work for drawers.

we have a Stack screen that holds the drawer and now even will fire when we are navigating away from that screen but this never happens as the drawer captures the back button and toggle its status instead of going back.
We want to go back.
Best is what I explained above but I have not found a good way to do it.

But what I found so far is this.
useFocusEffect(
        React.useCallback(() => {
            let backSub = {remove: () => {}};
            const handler = _.throttle((e) => {
                const state = getActiveState(e.data.state);
                const history = _.last(state.history);
                console.debug(e.data.state);
                if (!history) {
                    return;
                }
                console.debug(state.type, history);
                if (state.type === 'drawer' && history.type === 'drawer' && history.status === 'open') {
                    console.debug('open');
                    backSub.remove();
                    backSub = BackHandler.addEventListener('hardwareBackPress', () => {
                        if (navigation.canGoBack()) {
                            Navigation.dismissModal();
                        } else {
                            BackHandler.exitApp();
                        }
                        backSub.remove();
                        return true;
                    });
                } else {
                    console.debug('not open');
                    backSub.remove();
                }
            });
            const sub = navigation.addListener('state', handler);
            return () => {
                sub();
                backSub.remove();
            };
        }, [navigation]),
    );
    ```

It works great and handles both of our drawers but it does not for the first time when you navigate to the drawer screen as the drawer is opened by default which does not create a history entry.

If we can disable the drawer back handler from the Marc issue , things will become easier.

Apologies if I am repeating something that is no longer true, but @Maftalion suggested the following solution a while ago, which sounds like a better 'fix' in my opinion:
@Maftalion

the complexity stems from the way the current navigation is set up, technically the reportview is the active page and the list of chats is a open drawer on top of that page

if that gets restructured as two separate pages, then the issue with the reportview would go away

He's referring to the point that the reportView page used to be the top-level page in the app, with the NavDrawer|LHN being a simple view that overlayed the page. When we made the NavDrawer|LHN the top-level page we did not modify the RN page hierarchy to represent the true navigational hierachy.

It looks like it was closed b/c we didn't respond back

Oh hmm the react-navigation issue was closed (maybe we can reopen it with a reproduction?). That suggestion was not from a maintainer which is why I didn't respond (it also doesn't work).

the reportView page used to be the top-level page in the app, with the NavDrawer|LHN being a view that overlayed the content, instead of being its own separate page

It sounds like we are suggesting to make the LHN another screen in the main stack navigator but I'm not too sure. We can achieve the drawer navigator "overlay" style with drawerType: 'front' if that's a design we want to go with and it fixes the back handler issue.

we did not modify the RN page hierarchy to represent the true navigational hierarchy

What makes something a true navigational hierarchy?

Does everyone agree the proper fix should be in react-navigation?

I agree that there should be an option to disable the back handler controlling the drawer.

It sounds like we are suggesting to make the LHN another screen in the main stack navigator but I'm not too sure.

Yeah, that's the suggestion here. We are only facing this issue because we are trying to force a NavigationDrawer to behave like a Page for our convenience. I believe this is also the reason why the component does not support App close behaviour -- it is not supposed to handle app close, because that should always be the responsibility of the page it sits on top of.
Scenario A: Older version of our app

User opens app to chat page
User opens drawer to see LHN
User presses back [Drawer closes]
User presses back [App closes]

A NavDrawer should open on top of the current page and is a part of that page.

A few months ago, we decided to switch to the WhatsApp UX. The important distinction is that the LHN is now it's own Page, rather than an overlay NavDrawer. We now (correctly) animate between the chat page and LHN as if they are parent and child pages, instead of the LHN simply being an overlay.
Scenario B: Our current app

User opens app to see LHN
User selects list item to open chat page
User presses back [Chat page closes]
User presses back [App closes]

https://material.io/archive/guidelines/assets/0B6Okdz75tqQsWjgyVU9kMWN0V2s/patterns-navigational-transitions-parent-to-child-list-02-xhdpi-019.webm

I agree that we definitely could continue to use the NavigationDrawer component for the LHN page and it will look mostly look fine, but I fear we'll run into lots of minor bugs/odd behaviors if we continue with this. One thing that jumps out to me is that we have to maintain two different ways of animating pages: 1) react-navigation handles page to page animation for us, 2) we use the NavigationDrawer component options to choose from 4 animation types (this is the only page handled in this way).
The reason I care (probably too much) about this, is because I would like us to have a truly mobile-first user experience and I fear that we'll end up with mostly correct, but buggy-looking UX.

What makes something a true navigational hierarchy?

I mean, if we can make the NavigationDrawer behave in the right way then there is no problem. But why not make LHN a page?
Sorry for the wall of text 😬

The reason I care (probably too much) about this, is because I would like us to have a truly mobile-first user experience and I fear that we'll end up with mostly correct, but buggy-looking UX.

Thanks for the thoughts @Julesssss! It might be worth creating a separate issue to discuss all this and we can loop some more folks in. It sounds like even if we fix this back button behavior there will remain an issue that the UX is still not ideal. And in that case, I would definitely encourage you to do the research and build a case for it if you feel strongly about it.

why not make LHN a page?

Might need to do some digging to produce a more thorough answer, but the reasons I can think of are...

No one has proposed a fully fleshed out alternative (like a proof of concept or something) and how it would work on the web side
IIRC we wanted a swipe left on the LHN to reveal chat and a swipe right on the chat to reveal the LHN. I'm unsure whether stack navigation alone can do this. Having the sidebar float above would either require us to use drawer navigator with drawerType: front or do a custom implementation where we have the drawer sit above everything in a fixed way and not include it in the react-navigation stack. The latter sounds complicated to me, but might worth doing.
It's unclear how we could create the wide screen UI (fixed sidebar mostly used on web) with stack navigator alone. Figuring out how this layout will work might be a challenge if we want to abandon the drawer navigator entirely.

I'm not against ditching the drawer navigator. It might actually be better for performance since we can render the LHN without incurring a big cost to render the react-navigation tree. But it does feel like a big undertaking if our main concern is that the drawer navigator doesn't let us close the app on Android.

Yeah, if I remember correctly the biggest issue was getting the desired UI/UX across all platforms (mobile, web, etc) which led to the drawer implementation.
As you mentioned @Julesssss a lot of the issues stem from trying to use the drawer as a screen instead of a drawer but at the same time want some functionality of the drawer (as Marc mentioned above with the gesture swiping).
Has there been any thought on keeping it as a drawer but not making the LHN the "initial screen"? Basically if you implemented something similar to Slack's UI where the chat is the home screen and the LHN is treated purely as a drawer? I believe that would fix the back button since back will just close the drawer and back from the chat would close the app.

I am awaiting @marcaaron 's decision on approaching the issue.

Either we should reopen the issue https://github.com/react-navigation/react-navigation/issues/9511 and add code to hide the drawer.
Jules has a good suggestion https://github.com/Expensify/App/issues/4211#issuecomment-902155340 but I am not sure if that is possible. It requires rethinking the app architecture for few major parts. I don't think it's a good idea at this stage of the APP.
Last option is we hack our way through it and apply the fix in the code.

What if we go with this plan:

Implement Rajat's code above (assuming we test and don't find any issues)
Rajat tries to follow up with React Navigation to get the change approved (maybe also submit a PR to them so they can test it on their end?)
If React Navigation merges the change, Rajat refactors the code above with the simpler fix

Implement Rajat's code above (assuming we test and don't find any issues)

The code looks a bit complicated to me personally - which makes me concerned it will be difficult to maintain if we end up not doing 2. I think we should first try to re-open the issue, provide a reproduction, and attempt a fix in react-navigation.
I can't think of any reason why this issue needs to be fixed urgently - there are other ways to exit the app.

Just to follow up on my post above, I created a separate issue. It's probably not a high priority, but I think this improvement is worth implementing if we can figure out how to handle web.
Thanks for your comments!

Ok so let's go with this:

Try to re-open the React-Navigation issue: https://github.com/react-navigation/react-navigation/issues/9511

Post in the issue why https://reactnavigation.org/docs/preventing-going-back/ doesn't work for our case
Maybe submit a PR with our recommended change, as this could speed things along

If the above issue gets merged into their main repo, use the change to allow the Android app to close when clicking the back button

I think this would count as 2 jobs, so the reward would be $500
These are both relatively small changes, so @parasharrajat are you willing to work on those while we consider replacing the LHN with a Page? (@Julesssss 's suggestion)

I am on vacation. back on 8.

Enjoy! Take your time responding :)

Bump @parasharrajat :D

Ok. I am not yet sure what are we trying to fix in the R-navigation repo. @Beamanator. The issue I linked was only trying to disable the functionality to control the open-closed state of the drawer behind a flag.
So before we move, a few questions:

What is the problem, we are trying to fix on R-navigation repo?

Do we need to reopen the linked issue? If So, it only disables the back hardware key functionality for the drawer and we will still need to add the navigation in our app but the code would be much simpler than what I proposed.

Or do we want to add the back hardware button functionality to navigate back or close the app with drawer Navigator in r-navigation lib? If so, I didn't find any piece of code that does that in the codebase for r-navigation. I think is managed by react-native-screens.

Or, I think if we disable the back hardware key functionality for the drawer, we may not need the custom logic to handle it as It will be handled via Stack Navigator and thus should work fine.

@parasharrajat

You're right, we're technically not asking for a "fix", it's an enhancement, exactly what Mark reported in the issue
I thought it would be easier to just continue from where Marc left off, but it's possible only maintainers can re-open issues, so you may have to start from scratch - whatever you think is easier / most effective.

As for where to make the changes, I would go with the smallest change in React-Navigation (as this is probably the easiest to get approved), then the rest in our app. So 2 or 4 - but honestly I can't really tell the difference between those proposals

Ok, I think we start by creating a clone of the issue and then put a PR for the same and wait for things to move.
I think this would be enough for this issue as the Stack navigator will handle the rest.

@parasharrajat that sounds great, thanks! I assigned you this issue, I think we can move forward with this even though this is on hold since it's external to our repo

No activity on the issue: https://github.com/react-navigation/react-navigation/issues/9936.
Feature request: https://react-navigation.canny.io/feature-requests/p/allow-disabling-backhandler-subscription-in-drawerview

Update: I don't think the maintainer will ever respond to https://github.com/react-navigation/react-navigation/issues/9936. It just seems like a waste of effort.

I think we're not in a huge rush with this one, so we could just bump it every so often (maybe taking turns posting in the issue) to see if we can grab attention

They accept sponsors, let's offer a few months sponsorship in return for reviewing our request and PR?

That's an awesome idea, Jules!
On Thu, Sep 30, 2021 at 3:05 PM Jules Rosser @.***>
wrote:

They accept sponsors, let's offer a few month's sponsorship in return for
reviewing our request and PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Expensify/App/issues/4211#issuecomment-931354718, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AD3246NBBT7CSIPDEFPQF5LUERVD7ANCNFSM5A5M5AVQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--
*Tom Rhys Jones *
Expensify

How can I write this without it sounding like a bribe? 😄
And which tier should we offer? We have seen a huge amount of value from React Navigation, so I would suggest a one-off donation of $4-6000, or a continuous donation of the $199 tier.

Hi Brent,
We love the work you and the team have done with React Navigation. Coming from Native development myself it was a relief to find a well-written native-like navigation for ReactNative. We're also building to web/desktop with few issues and couldn't be happier.
Our only current issue is a small feature we believe is missing from the DrawerView component (issue, and PR). If it was possible to get this issue reviewed we would love to provide a one-off or continuous donation at one of the higher levels.
Thanks, the team at Expensify.

Reminder, this is a public issue.

FYI, I'm removing the above comment for internal discussion. But I will report back and reach out tomorrow.

Thanks @Julesssss ! Agreed it's an awesome idea 👍

Its a great Idea. I am sure they would be happy to discuss best possible solution at least.

Please refer to this post for updated information on the n6 hold, we've raised the bonus to $250 for all issues where a PR is created before the N6 hold is lifted.

@Beamanator Hurray, the issue is fixed upstream and now I can create a PR to configure the app correctly and
it will also fix https://github.com/Expensify/App/issues/5027.

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.1.12-3 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/5745

If no regressions arise, payment will be issued on 2021-11-09. :confetti_ball:

Hmm looks like this PR got reverted here: https://github.com/Expensify/App/pull/6161 - @parasharrajat is looking into how to fix the issues that came from this PR

@parasharrajat is actively working on a fix in ^ PR

Not overdue - fix is in staging, waiting to get to production

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.1.16-10 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/6295

If no regressions arise, payment will be issued on 2021-12-06. :confetti_ball:

Ping for

@trjExpensify
Information for your reference.
https://github.com/Expensify/App/pull/5745#issuecomment-948027934 has the breakdown for payment. Please skip the milestone for 5027.
Apart from it, there were two PR created for this issue. the first one https://github.com/Expensify/App/pull/5745 went through N6-Hold and the second https://github.com/Expensify/App/pull/6295 through Company Offsite Hold.

Woof, this was a long one ey! So I presume from @mallenexpensify comment, this is the correct Upwork job, right? https://www.upwork.com/jobs/~017e60e720f6f9aca8
It's closed though and I couldn't see your proposal nor being hired Rajat, so we'll need to sort that out once confirmed this didn't move elsewhere. Then maybe @Beamanator can help confirm the total payable for this job at this point, skipping #5027. Am I reading it correctly that it should be $1,500?

@Beamanator Could you please help us out here?

I just looked through and I also believe payment should be $1,500. Breakdown:

$1000 for fixing this issue (this price was set here)
$250 for https://github.com/react-navigation/react-navigation/issues/9936 (We agreed here) that this is a separate job
$250 because this PR was submitted before the n6-hold ended so should get the $250 bonus

@parasharrajat you thought your PR would also fix https://github.com/Expensify/App/issues/5971, but we ended up closing it b/c it couldn't be reproduced, so no reward there.

there were two PR created for this issue. the first one #5745 went through N6-Hold and the second #6295 through Company Offsite Hold.

@Beamanator I am not sure about this but do you think the two bonuses apply here n6-hold and company offsite hold? Could you please confirm that as well? Thanks.

Hmm here's my thinking:

#6295 was officially "ready for review" on November 17 (see this comment)
We ended the Company Offsite Hold on the 16th (see this slack message)

So I don't think that PR is eligible for the Company Offsite Hold bonus, let me know if you disagree though (also @trjExpensify)

Correct. I overlooked it. Thanks.

No prob at all

Awesome. Offer sent 👍

All sorted, closing.


Support [] and {} on top of ()

Having [] and {} on top of () can be quite useful to indicate sequences and maps as data types, instead of the more structural (). In Scheme all of these delimiters are treated the same, so which one to use is just a matter of convention there. In contrast, Clojure distinguishes between (), [] and {} and therefore can express vectors as [a b c] and maps as {:a 0 :b 1 :c 2}. This makes Clojure vectors and maps considerably more convenient to use.
Since this is a low level library for parsing and pretty printing, rather than a data type format such as edn, we do not need to ascribe additional semantics to [] and {} a priori but defer this to whatever data type implements Parse and/or Print.
Additionally, having [] for sequences instead of reusing the () type allows us to pick a pleasing indentation convention in the pretty printer:
; two spaces for ()
(call
  arg-0
  arg-1)

; one space for [] since the items are typically homogeneous and therefore should be aligned the same
[0
 1
 2]

Closed by b9ae219


Bot is not connecting to teamspeak3 server

Hi. I'm using the latest version of teamspeak server and the latest version of sinusbot. Both teamspeak server and sinusbot are running in docker. The sinusbot cannot connect to the teamspeak server. This is weird because a while ago I set the sinusbot up just the way I did now and it worked fine. Now the bot can't connect anymore. I did some research and found that the only possible reason is that the teamspeak client used in ur docker image is to old? Would it be possible to update your docker image to use the latest teamspeak client?

This is impossible because the installer will always use the latest version available: https://github.com/SinusBot/docker/blob/a85f12991538d2e95daea1f2aab06de3d43b91bf/discord/install.sh#L66.

Sorry my bad. Used the wrong server address to which the bot should connect. Closed.


cmd: Add "bpf ct flush" command

This command goes through the maps and flushes all conntrack entries
that are due to expire within the next 10 minutes. This is intended to
assist debugging the datapath.
Signed-off-by: Joe Stringer<EMAIL_ADDRESS>

@ianvernon I have addressed your regular feedback and pushed a new version here, but I haven't merged in the runtime test for this since I've implemented that part on top of ginkgo. We can either push this through first and I'll follow up separately with the Ginkgo CLI tests, or we can just leave this PR sitting here until Ginkgo starts to settle down.

We can merge this now. Can you create an issue to track the addition of a test for this with Ginkgo?

Done - #1855. I'll rebase this.


chore(backend): update route paths to match spec

Changes proposed in this pull request

update Open Payments route paths to match spec
depends on #364

Context

fixes #362

Checklist

[x] Related issues linked using fixes #number
[x] Tests added/updated
[ ] Documentation added
[ ] Make sure that all checks pass

I still have an ilp-pay issue to figure out.


SPEC: promote Pods to top-level concept

Following some of the discussion in #207, this is an attempt to restructure
the spec by promoting the Pod to a top-level concept (along with ACIs, image
discovery, and ACE). Decoupling them from the executor section makes it
clearer that producing/manipulating pods can be completely independent of
execution.

@cdaylward first cut, could do with some more tweaking but should be a little easier to review than the previous.

lgtm

Looks good as it is.


[Bug]: There is no space between Text size and pixel for Text size property on property pane

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior

Steps To Reproduce

Drag and drop a Table widget
On property pane go to Text size property
Select Heading3 Option from drop-dopwn which is 16px
After selection it looks Heading316px

Environment
Release
Version
Cloud

Closing this since I'm unable to reproduce this.


[USelectMenu] async search combined with loading removes focus from input field

Environment

Operating System: Windows_NT
Node Version:     v19.8.1
Nuxt Version:     3.8.1
CLI Version:      3.10.0
Nitro Version:    2.8.1
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      ssr, typescript, devtools, vue, runtimeConfig, ui, modules, extends, app
Runtime Modules<EMAIL_ADDRESS><EMAIL_ADDRESS>Build Modules:    -

Version
2.11.1
Reproduction
https://stackblitz.com/edit/nuxt-ui-nqrf9b?file=app.vue
Description
When using an async searchable USelectMenu that sets a loading state while fetching results removes focus from the input field when the loading state changes.
Additional context
No response
Logs
No response

Indeed, you should not use the loading prop for this behaviour as it will disable the button. This should be used when submitting a form for example.
You're trying to show the loading state when searching right? Would this https://github.com/nuxt/ui/pull/520 fix your issue?

Exactly - and yes, #520 would fix it (although it'd be nice to be able to customize it with a slot). I'll await the PR. Thanks!

@rigtigeEmil I've changed my mind, you can now use the loading prop and it will no longer disable the SelectMenu!

@benjamincanac Fantastic! Thanks again. Looks great 👍


Add ES healthchecks to /healthcheck/ endpoint

Fixes

Fixes #14 by @obulat
Description

Adds Elasticsearch status checks to the /healthcheck/ endpoint when check_es is in the query params.
Note: I chose not to implement a serializer for the query params to avoid over-complicating the implementation of what is an otherwise very straightforward request to process. If this does happen to get more complex in the future, like if we add different check_* params, a serializer might then become appropriate.
I'm leaving this as a draft to allow discussion in the issue to decide whether this approach actually makes sense for our usage of the healthcheck endpoint.
Testing Instructions

Check out the unit tests and confirm they make sense. There's not really a good way to test this practically as far as I can tell unless you do something to brick your local ES cluster. I'm not sure how to do that so I don't have any advice for this.
Checklist

[x] My pull request has a descriptive title (not a vague title like
Update index.md).
[x] My pull request targets the default branch of the repository (main) or
a parent feature branch.
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[x] I added or updated tests for the changes I made (if applicable).
[x] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no visible
errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Somehow I completely forgot to try running the es_check locally :facepalm: Fixed in the latest commit and I'll undraft the PR now that we've got agreement on the approach. Thanks for the early review, @AetherUnbound

@AetherUnbound Did you get that right after recreate or maybe up from a down state? At least it means the endpoint is working :slightly_smiling_face:

@dhruvkb I get green on my local machine, though :thinking:

How strange! 😮 I spun the stack up almost 10 minutes ago and it's still showing yellow locally 🤔 I'll try to leave it on for a while longer to see 🤷🏼♀

Earlier I was thinking it might be an issue with Docker Desktop on macOS vs Docker on Linux. But with @AetherUnbound experiencing the same behaviour on Linux, I can't think of any logical explanation for this discrepancy.

Can you clarify @dhruvkb if this is a blocker for getting a second approval on this PR? From my perspective just because the local environment doesn't return "green" doesn't mean that the changes in this PR aren't working. The code only relays exactly what the ES instance reports back, nothing more.
If you think "yellow" status does not constitute an error state, we can change it to return 200 with a specific message in that case. Please let me know if there are changes you are expecting in this PR as it stands now.

I've manually verified that the labels exist and are correct, so I'm going to merge this using the admin workaround instead of trying to sort out why GitHub won't let me re-run the actions. They've been stalled indefinitely, it seems.

I've manually verified that the labels exist and are correct, so I'm going to merge this using the admin workaround instead of trying to sort out why GitHub won't let me re-run the actions. They've been stalled indefinitely, it seems.

I've been seeing this with PRs that were opened before we added that as a required check. It seems that just adding and removing a label is sufficient enough to trigger the jobs and pass the checks, FWIW!

Oops, swapped digits with #1074 from the CLI 😅


Add flag to log all output to a file

This is helpful for running cosign within a container when you do not have access to a shell to redirect output to a file. For example, using the cosign container within CI systems e.g. as a task in Tekton, makes redirecting all output to a file very useful for easier post-processing to analyze the results.

Big +1 to this overall, one question on stderr

@dlorenc One more review needed - pushed an update to the flag usage.


Rename library to "lazy-static"

This would be more idiomatic I believe? Remember extern crate lazy_static; will still work.

Hm, it would break cargo dependencies and URL though right? I agree that the naming is maybe not that consistent, but fixing it at this point might be to huge a unneeded breaking change.

Since this is in the nursery isn't it potentially destined to become quite official?
I've never pushed to crates.io, but if you can add custom deprecation messages, the transition wouldn't be so bad. Also keep in mind that while the ecosystem adjusts there's no problem having a transitive dependency on this under both names.

You can't upload a crate that differs from an existing one by a hyphen or underscore. See RFC 940.
(As an aside: according to the Ruby convention, hyphens are for extensions to other frameworks, not standalone crates. So taking them as a reference, lazy_static is okay.)

@Ifairly conversely that means just like ninja editing crates.io to make it existing packages use the hyphen shouldn't break anything.
Based on the crates.io packages I've seen, I'm don't think that's followed.

Hi, I'm sincerely sorry for taking so long to respond.
As far as I know renaming the lib still poses the same issues as before. Changes to how crates.io allows name changes would certainly help, but is out of scope for this lib itself.
However, this crate will probably experience a push sometimes in the next months in an effort to bring it up to a stable 1.0 release, which will also revisit this naming issue.
There is also interest from the libs team in general to just merge this lib into std, in which case a renaming would also be unnecessary churn.

@Kimundi I wouldn't sweat it at all :). People's time availability / life priorities change all the time, and a big point of moving things to the nursery is to distribute the maintenance burden.

There is also interest from the libs team in general to just merge this lib into std, in which case a renaming would also be unnecessary churn.

Well, I don't think spin is ready, yet a big usecase of this library is no_std, so I'd at least want this preserved as a crate behind the facade. That means the naming issue won't go away.

Perhaps there could be a way of integrating spin into libcore?

@clarcharr It's not mature enough (I say as a primary developer of spin). Moreover, we really should think twice about why we want things in std, and what that says about the usability of fine-grained dependency graphs. IMO, nirvana for library code should be ending up in separate repos under the rust-lang organization, not the standard library.

@Ericson2314: Good point about spin, hadn't really considered that until now.
And yeah, in either case this crate would remain as a legacy fallback so a decision about the name is still relevant then. :)

Honestly, I much prefer crates to have exact same package name as the crate name.  Less confusion overall and one fewer "do I write - or _ in Cargo.toml?" to remember.

Closing in favor of https://github.com/rust-lang/cargo/issues/2775. Cargo is going to accept lazy-static = "1.0" as equivalent to lazy_static = "1.0".


How is feature map calculated?

Your work is very interesting, but how do you get feature maps? Could you give some solutions。

@zhlstone did you get any answers?


Do not strip commas from RGB

Hi. When I edit an RGB color in an XML file, the comma separators are bing stripped - i.e. rgb(11, 22, 33)  becomes rgb(11 22 33) with this extension installed.
Is there a switch to control this or could this be provided to retain commas?

Just uploaded a new version including this setting in the README file https://github.com/jeronimoek/color-picker-universal/pull/105
You should change the "color-picker-universal.preferLegacy" setting to true

Perfect! Thank you very much.


React Demo link broken

Under "React Version" heading:
A demo could be reached at: View Demo
The link is:
http://paypal.github.io/accessible-html5-video-player/index.react.html

let me fix this

@hozefaj React link is fixed, thanks. Looks like the captions are broken in this version though; the src value appears incorrect.

Captions are broken, it's getting 404.

@weboverhauls Check out the PR.


NOT ENABLE INT keys at Mac OS Sonoma

Helllo
I set adv360_left_defconfig
CONFIG_ZMK_HID_KEYBOARD_EXTENDED_REPORT=y
but I can't enable INT keys(INT1..5)
so I check BT logs at my Mac, I found that only after I enable this config , it causes L2CAP errors.

OS: Mac Sonoma 14.3.1
Hardware: Mac Studio 2022(M1 Ultra)

After changing that setting you need to unpair and re pair the keyboard to the computer

@ReFil
I unpair the keyboard ( Mod + Winkey) and delete profile from Mac and reboot it.
But it still show same error.

Is N key rollover enabled?

adv360_left_defconfig
CONFIG_ZMK_HID_REPORT_TYPE_NKRO =y
CONFIG_ZMK_HID_KEYBOARD_EXTENDED_REPORT=y

After I set NKRO=n , build if failed.

I think parameter will changed CONFIG_ZMK_HID_KEYBOARD_EXTENDED_REPORT to CONFIG_ZMK_HID_KEYBOARD_NKRO_EXTENDED_REPORT.
I will change this parameter.
https://zmk.dev/docs/config/system

Hi, Did changing that updated parameter work for you?

hello, just following up on this, is it working?

Hello, just following up again, if i dont hear from you in the next 24 hours i will close this issue as solved, thank you


no reason when colocate false

Steps to reproduce the behavior (Required)
CREATE TABLE t1 (
id int(11) NULL COMMENT "",
num int(11) NULL COMMENT "",
time date NULL COMMENT "",
value varchar(20) NULL COMMENT ""
) ENGINE=OLAP
DUPLICATE KEY(id)
COMMENT "OLAP"
DISTRIBUTED BY HASH(id, num, time) BUCKETS 3
PROPERTIES (
"replication_num" = "1",
"colocate_with" = "group1",
"in_memory" = "false",
"storage_format" = "V2"
);
CREATE TABLE t2 (
id int(11) NULL COMMENT "",
num int(11) NULL COMMENT "",
time date NULL COMMENT "",
value varchar(20) NULL COMMENT ""
) ENGINE=OLAP
DUPLICATE KEY(id)
COMMENT "OLAP"
DISTRIBUTED BY HASH(id, num, time) BUCKETS 3
PROPERTIES (
"replication_num" = "1",
"colocate_with" = "group1",
"in_memory" = "false",
"storage_format" = "V2"
);
insert into t1 values (1,1,'2020-1022','hello');
insert into t2 values (1,1,'2020-1022','hello');
explain select * from t1 left join t2 on t1.id=t2.id;
Expected behavior (Required)
4:HASH JOIN
|   |  join op: LEFT OUTER JOIN (PARTITIONED)
|   |  hash predicates:
|   |  colocate: false, reason:     xxxxxxxxxxxxxxxxxx
|   |  equal join conjunct: 1: id = 5: id
|   |  use vectorized: true
Real behavior (Required)
4:HASH JOIN
|   |  join op: LEFT OUTER JOIN (PARTITIONED)
|   |  hash predicates:
|   |  colocate: false, reason:
|   |  equal join conjunct: 1: id = 5: id
|   |  use vectorized: true
StarRocks version (Required)
You can get the StarRocks version by executing SQL select current_version()
527e5ae

In your case, the reason about close colocate join is the join's on-predicate columns can't staisfy DISTRIBUTED KEY of colocate table.
And in the new optimizer,  it's difficult to show the reason, I think this is a low priority improvement.


Refresh should also hide the read feed

After reading feeds, they remain in ‘All Unread’ for as long as you stay there. The only option is to leave the section and go back in again.
Suggestion to update ‘All Unread’ when the feeds are refreshed or to create a separate shortcut for easier operation

On iOS there’s a setting for this. On Mac there isn’t, but you can use View > Clean Up Articles for this.

Thanks for the tip - I find the shortcut a bit cumbersome, but maybe that's just my opinion.
However, the last read entry is always retained

It doesn’t remove the currently-selected article on the grounds that you may still be reading it.

On iOS there’s a setting for this. On Mac there isn’t, but you can use View > Clean Up Articles for this.

On iOS I saw “Refresh to Clear Read Articles,” and this needed manually refresh to clear read articles.


Add BasePreprocessor

Codecov Report
Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (d67721b) 99.84% compared to head (37d5779) 96.65%.

Files
Patch %
Lines

src/flamme/preprocessor/base.py
0.00%
19 Missing :warning:

src/flamme/preprocessor/__init__.py
0.00%
3 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
- Coverage   99.84%   96.65%   -3.20%
==========================================
  Files          30       32       +2
  Lines         666      688      +22
  Branches       69       71       +2
==========================================
  Hits          665      665
- Misses          0       22      +22
  Partials        1        1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


How to eager-load related edges/vertices?

By running simple queries with Model::find() or Model::where() I'm obtaining a collection with entities only, without the related objects/vertices.
"@type" => "d"
"@rid" => "#25:1"
"@version" => 3
"@class" => "Resources"
"uuid" => "116118d0-63d3-11e7-9fdd-4d775a1245c6"
"updated_at" => "2017-07-08 11:46:23"
"created_at" => "2017-07-08 11:46:23"
"out_has_classification_types" => array:1 [
  0 => "#42:0"
]
"out_has_notes" => array:1 [
  0 => "#39:0"
]
"@fieldTypes" => "updated_at=t,created_at=t,out_has_classification_types=g,out_has_notes=g"

How can I run a query that can pull a specific "branch", for eg., Resource > HasClassificationType > ClassificationType and Resource > HasNote > Description, all together?

If I setup a relation like
public function hasClassificationType()
{
    return $this->hasOne(ResourceClassificationType::class, HasClassificationType::class);
}

then I get the following error
Type error: Argument 1 passed to Sgpatil\Orientdb\Query\Builder::modelAsNode() must be of the type array or null, string given, called in /vendor/sgpatil/oriquent/src/Sgpatil/Orientdb/Eloquent/Relations/HasOne.php on line 69

The problem seems to be here:
// in Sgpatil/Orientdb/Eloquent/Relations/HasOne.php
$parentNode = $this->query->getQuery()->modelAsNode($this->parent->getTable());

while Query::modelAsNode() method says it only accepts arrays as seen here
 * @param  array $labels
 * @return string
 */
public function modelAsNode(array $labels = null) {


Image Preprocessing

Description:
Implement image preprocessing to enhance the quality and ensure consistent input for the CNN model. This includes resizing, thresholding, and potentially augmenting the images to increase the dataset size.
Tasks:

Implement resizing to ensure consistent image dimensions.
Apply thresholding to enhance text visibility.
Explore image augmentation techniques to expand the dataset.
Document the preprocessing steps and any external libraries used in the repository.

Hey, I am interested in doing this issue:)

@Ayushlion8 Glad to have you with us.

Hey, I've some doubts regarding resolving this issue-:
Do I have to create one separate file and download a image dataset for doing all kinds of preprocessing?

Do I have to create one separate file and download a image dataset for doing all kinds of preprocessing?

Hey @Ayushlion8 , You will first have to find a dataset for 16 segment display and after that, yes you can either create a new file or this python file Correction.py

@Dv04 could you please guide me regarding the dataset for I am still not cleared
At max. I am able to find these images:


Setup evmos-bostrom relayer

Set hermes on bostrom-api
necessary to test it with evmos keys

Done.


Error with your latest commit :  1e19006

Hi everyone,
I think there might be an issue with your latest commit : 1e19006
I git clone this repository to build and virtualenv on my pipeline and it seems that when I do :

pip install --upgrade --force-reinstall -r requirements.txt --extra-index-url file:///tmp/vsphere-automation-sdk-python/lib

There is an error directly linked to this commit :

Processing ./lib/vmc-draas-client-bindings/vmc_draas_client_bindings-1.4.0-py2.py3-none-any.whl

--

15:24:25 |   | ERROR: Could not install packages due to an EnvironmentError: [Errno 2] No such file or directory: '/tmp/vsphere-automation-sdk-python/lib/vmc-draas-client-bindings/vmc_draas_client_bindings-1.4.0-py2.py3-none-any.whl'

In fact there is nothing more than index.html in https://github.com/vmware/vsphere-automation-sdk-python/tree/master/lib/vmc-draas-client-bindings
It seems that this is an error but it can come from me somehow.
Regards,

This error made me improve our job and we are now cloning from tag instead of latest available version in git.

The faulty commit has been reverted. Closing this issue.
Thanks.


[FIX] Typo in VersionCheckView.kt

@RocketChat/android
Changes:
Corrected sentence.
Screenshots or GIF for the change:

@NBAMIR I think sending separate PRs for typo fix in each file is not good when you can do all of the fixes in one PR. Hope you understand.

Hi, I don't have previous experience with open source contribution so I'm trying to get the hang of it. Any suggestions or advice is welcome. I didn't know I could commit fixes in different files in one PR. Thanks for the heads up.

@NBAMIR  This will help https://stackoverflow.com/questions/19576116/how-to-add-multiple-files-to-git-at-the-same-time.  You can also look at official documentation of git to learn more about it here

Thank you for the suggestion. I'll check it out.