[Doc Improvememt][Update test and debug your app]

added link to test Teams Tab in see also section

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/build-and-test/debug.md
91
10
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit fbd019a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/build-and-test/debug.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/build-and-test/debug.md
91
10
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 480598d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/build-and-test/debug.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Removing "enable" requirement for SMB - use preferences only

Per discussion in https://github.com/openaps/oref0/issues/737, moving forward with the community-voted option of removing the requirement to "enable" SMB, and only have to turn it on via preferences, to prevent edge case and unnecessary confusion. This needs testing before it merges.

To test: cd ~/src/oref0 && git fetch && git checkout smb-in-preferences-only && git pull && npm run global-install and then re-run oref0-setup.

Any volunteers to test this so we can merge it?

I'm testing it now. I switched to this branch, ran global install, took microbolus out of oref0-runagain.sh and re-ran setup. It is looping now with  Starting oref0-pump-loop at Thu Nov  2 10:51:02 EDT
However, I need to wait for lunch time to test SMB's. My current preferences are as follows:
{         "max_iob": 9,         "max_daily_safety_multiplier": 13,         "current_basal_safety_multiplier": 14,         "autosens_max": 1.5,         "autosens_min": 0.5,         "rewind_resets_autosens": true,         "adv_target_adjustments": false,         "exercise_mode": false,         "unsuspend_if_no_temp": true,         "enableSMB_with_COB": true,         "enableSMB_with_temptarget": true,         "enableUAM": true,         "curve": "rapid-acting" }

SMB isn't working for me. I think the problem may be unrelated to this branch's changes. My NS site is up and running and getting treatments, but openaps isn't able to communicate with it for some reason. I can't figure out why yet.

OK - I got my unrelated npm install issues all sorted out and fixed. Testing this branch and it works great for me. 👍
SMB's are working and I didn't use enable microbolus when I re-ran oref0-runagain.sh.

Thanks.  Based on @efidoman's testing I think we're good to merge this if nobody else wants to test anything specific before it goes to dev.


Send failure-reason header on all client errors

This will give users some more information about why they are getting a certain 4xx errors.

Codecov Report

Merging #878 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #878      +/-   ##
============================================
- Coverage     66.82%   66.78%   -0.04%
+ Complexity     4214     4209       -5
============================================
  Files           356      356
  Lines         27705    27705
  Branches       3513     3513
============================================
- Hits          18513    18504       -9
- Misses         8228     8233       +5
- Partials        964      968       +4

Impacted Files
Coverage Δ
Complexity Δ

...va/com.github.ambry.rest/NettyResponseChannel.java
91.29% <100%> (ø)
87 <0> (ø)
:arrow_down:

.../src/main/java/com.github.ambry.store/Journal.java
89.65% <0%> (-1.73%)
19% <0%> (-1%)

...ava/com.github.ambry.store/BlobStoreCompactor.java
92.42% <0%> (-1.12%)
119% <0%> (-3%)

...github.ambry.rest/AsyncRequestResponseHandler.java
87.62% <0%> (-0.98%)
23% <0%> (ø)

...b.ambry.network/BlockingChannelConnectionPool.java
62.6% <0%> (-0.87%)
7% <0%> (-1%)

...in/java/com.github.ambry.network/SocketServer.java
82.78% <0%> (-0.41%)
13% <0%> (ø)

.../main/java/com.github.ambry.store/HardDeleter.java
81.61% <0%> (-0.33%)
41% <0%> (-1%)

...in/java/com.github.ambry.store/BlobStoreStats.java
69.85% <0%> (-0.24%)
80% <0%> (ø)

...ain/java/com.github.ambry.router/PutOperation.java
89.91% <0%> (-0.21%)
81% <0%> (-1%)

...java/com.github.ambry.router/GetBlobOperation.java
91.26% <0%> (+0.2%)
35% <0%> (+1%)
:arrow_up:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9b8482...e2928c9. Read the comment docs.


[Request-For-External] COD2677 "Gen. Journal Alloc. Acc. Mgt." - Procedure VerifySelectedAllocationAccountNo()

Describe the request
Hello, we need the following currently Internal procedure to be set as Global. Can you please check this? Thank you!
[Request-For-External] codeunit 2677 "Gen. Journal Alloc. Acc. Mgt." - Procedure from Internal to Global

procedure VerifySelectedAllocationAccountNo(var GenJournalLine: Record "Gen. Journal Line")

Additional context
Duplicated the actions from General Journal to a own Journal.
Internal work item: AB#555532

Availability update: We will publish a fix for this issue in the next update for release 25.
Build ID to track: 26242.


Publish CASTLE Searching to Eclipse Marketplace

Waiting for more feedback from beta testers
What issues / enhancements should be made before it is published to the Eclipse Marketplace?
Would this make a good milestone?

Made a project instead of a milestone

CASTLE Searching is now live on Eclipse marketplace
https://marketplace.eclipse.org/content/castle-searching


Error after canceling drawing marker without moving mouse

[X] I'm reporting a bug, not asking for help
[X] I've looked at the documentation to make sure the behaviour is documented and expected
[X] I'm sure this is a Leaflet Draw code issue, not an issue with my own code nor with the framework I'm using (Cordova, Ionic, Angular, React…)
[X] I've searched through the issues to make sure it's not yet reported

In the source for L.Draw.Marker, the marker only gets created on mouse move (https://github.com/Leaflet/Leaflet.draw/blob/master/src/draw/handler/Draw.Marker.js#L86).
In an app I'm developing, we're adding custom controls outside of the map to enable an disable drawing, and unlike the default controls they're not directly over the map. Therefore, if you click to enable and then click again to disable without moving the mouse over the map, you end up with this error:
Uncaught TypeError: Cannot read property 'updatePosition' of null     at NewClass._onMouseMove (Draw.Marker.js:83)     at NewClass._onTouch (Draw.Marker.js:118)     at NewClass.fire (Events.js:186)     at NewClass._fireDOMEvent (Map.js:1051)     at NewClass._handleDOMEvent (Map.js:1010)     at HTMLDivElement.handler (DomEvent.js:72)
Repro steps: http://leaflet.github.io/Leaflet.draw/docs/examples/full.html

Click the draw marker button, and do not move the mouse at all
Hit Escape to cancel drawing
click anywhere on the map and you should see the error above

I think the reason this hasn't come up before is that using the default controls and ux pattern, in order to stop drawing the marker you have to move the mouse from the marker button to the cancel button, which triggers _onMouseMove. However, given that you can cancel by hitting Escape, this seems like it should be fixed here and not just in my app.

https://github.com/Leaflet/Leaflet.draw/pull/806
PR up!

PR merged, closing this ticket


Update index.html

#1220

@AKSHITHA-CHILUKA, what are you doing again and again? I have noticed for the past 10 minutes that you keep creating issues and PRs repeatedly, which doesn't make any sense. I don't know what are your intension to create Pr and issue again and again. Thank you!


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_61f19834-6f35-4876-b369-fc71a697d388/pull/1 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-archive-test-target_61f19834-6f35-4876-b369-fc71a697d388.git

Docs Build status updates of commit 9c34f5f:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-RuningBuildFailed] Some unexpected errors happened when running build, please open a ticket in https://aka.ms/SiteHelp and include the error report for our team to troubleshoot

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Enable test coverage checks for storage libraries

https://github.com/Azure/azure-sdk-for-cpp/blob/4614b80d2214f28e3613f20c9ff3a3c79225c43f/sdk/storage/ci.yml#L40
For example look at others:
https://github.com/Azure/azure-sdk-for-cpp/blob/4614b80d2214f28e3613f20c9ff3a3c79225c43f/sdk/identity/ci.yml#L36-L37
Related testing issue:
https://github.com/Azure/azure-sdk-for-cpp/issues/3051
Follow-up from https://github.com/Azure/azure-sdk-for-cpp/pull/2992
cc @Jinming-Hu, @danieljurek

Issue has been addressed


Bug: the st window won't close on Wayland

compositor: river (master)
OS: alpine linux
I am investigating this issue and will attempt to fix it.
Initially I thought it could've been an issue with my compositor, but the "close" action is done directly by wlroots/XWayland. And standard st doesn't have this issue. This doesn't discard the possibility that wlroots might be at fault though.
I noticed that this happens after a call to sigchld, which makes sense since I just signalled for the process to close the window. But after going through sigchld, the program gets stuck at exit, with some calls related to a pthread mutex? Not sure yet what it is.
If I figure out and fix it, I will do a PR

This seems to have something to do with the signalling. I disabled the SIGCHLD when the X window gets deleted, and the terminal no longer fails to close.
I won't do a PR yet because I want to figure out why it doesn't die() gracefully with the regular SIGCHLD (and perhaps find another solution)

st is supposed to work well  in xorg


Reducing the minified alloy library by aproximately 5k.

Description
Disclaimer
First pull request...so very open to feedback and even rejection. ;)
Saving Bytes
I'm trying to reduce the minified js library by doing some minification tricks.  I am not intending to change any functionality at all.  Only trying to reduce the size of the final minified dist/alloy.min.js file.
Log

size in bytes
changes to get there

71,512
Started at 71,512

68,468
Rewrote /src/components/Personalization/dom-actions/scripts.js to not include @adobe/reactor-load-script.  This removes the @adobe/reactor-promise dependency which is bulky.

67,659
Rewrote /src/utils/querystring.js to not include @adobe/reactor-query-string dependency which is bulky. (added to /test/unit/specs/utils/querystring.spec.js tests)

67,512
Removed output.intro from rollup.config.js since it should be in documentation anyway

67,127
Rewrote /src/utils/assign.js to not include @adobe/reactor-object-assign dependency which is slightly outdated and bulky

67,034
created /src/utils/window.js, replaced all window references

66,949
created /src/utils/document.js, replaced all document references

66,715
created /src/utils/Object.keys.js, replaced all Object.keys references

66,643
created /src/utils/JSON.stringify.js, replaced all JSON.stringify references

Related Issue
I have not created an issue yet. :(
Motivation and Context
Even the minified alloy library is relatively large.  Reducing the alloy library benefits everyone.  It can help with performance for our end users and also helps our team justify deploying the alloy library.
Screenshots (if appropriate):
(none)
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Improvement (non-breaking change which does not add functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA or I'm an Adobe employee.
[x] I have made any necessary test changes and all tests pass.
[x] I have run the Sandbox successfully.

Oooh, yeah, that's an interesting idea that's worth investigating.

@bbythewa, Thanks for your work here, but there are two things that we need to figure out:

The replacements for window, document, etc. can be done less obtrusively using a rollup/babel configuration. Doing it this way will make the code more readable.
We'd want to use the dependencies in the Tags extension, but swap them out for your smaller implementations.


make cgo can't work

Dear go-with-intel-sgx developer,
official sample can work correctly on my machine, but make cgo  doesn't work since cannot find some .h files, here is the results I got:
LD_LIBRARY_PATH=$LD_LIBRARY_PATH:. go run cgo.go
# command-line-arguments
In file included from ./cgo.go:4:0:
./App/App.h:40:48: fatal error: sgx_error.h: No such file or directory
compilation terminated.
Makefile:273: recipe for target 'cgo' failed
make: *** [cgo] Error 2

I would be grateful if you can tell me what's going on. :wink:

Dear go-with-intel-sgx developer,
I am sorry for create this issue rashly, I figured out the problem now.
I noticed the cgo.go file in Cxx11SGXDemo is different with other examples, and solved this error by make them same (change #cgo CFLAGS: -I./App -I$SGX_SDK/include to #cgo CFLAGS: -I./App -I$SGX_SDK/include in cgo.go)


Now I didn't actually have time yet to read your commit, just merging and am review it as I test it out. :smile: (my other open source project is taking all my time, but I don't want to ignore this, just cutting corners).

@Templarian no worries. I tried to make as small a change as possible but still implementing the required features. Shouldn't be too difficult to test it out.
Have you considered adding other people with write access to this repo to help you out?

@josetaira Good idea! You're a contributor now (probably should have done this sooner, but these github emails get buried in by all the activity of my main project). Open an issue when you think it's ready for a version bump and I'll increment and release. We just need to make sure we don't break the current user's stuff and that the docs are updated.


Safari text workaround

Issue to track, reported in https://github.com/phetsims/qa/issues/1039#issuecomment-1949196606, fixed in https://github.com/phetsims/scenery/commit/f8f218e4a1adbf23fccbc7e175ac2abdd469e0b5.

FYI: for https://github.com/phetsims/qa/issues/1052, only one case of artifacts so far:
Oriya in Gravity and Orbits PhET-iO standalone version 1.5 (not in 1.6)

@kathy-phet, ok to skip looking deeply at a graphical artifact in an older phet-io version here?


Django REST token authentication

Hi,
I'm trying to implement authentication using tokens generated by django-rest-framework.
Using this gist: https://gist.github.com/leonardoo/9574251b3c7eefccd84fc38905110ce4
I've managed to do this:
Consumer
class APIDemultiplexer(RestTokenConsumerMixin, WebsocketDemultiplexer):
    rest_user = True

    def connect(self, message, **kwargs):
        Group('users').add(message.reply_channel)

        # user here is correct instance of User from given token
        print(message.user)
        Group('users').send({
            'text': json.dumps({
                "accepted": "True",
            })
        })
    consumers = {
        'campaigns': CampaignBinding.consumer
    }

Resource binding
class CampaignBinding(ResourceBinding):

    model = Campaign
    stream = "campaigns"
    serializer_class = CampaignSerializer
    queryset = Campaign.objects.all()
    permission_classes = (AllowAny,)

    def get_serializer_context(self):
        # user here is Anonymous
        print(self.user)
        # I need user instance inside self.message
        return {'request': self.message}

My request
ws://localhost:8000/?token=ef0ef25fcfc75c0db91bbbccc062f0ab5786dc34
The thing is that I can access User instance only inside Consumer and User instance is not propagated to ResourceBinding. Is there some obvious way to access ser from token inside ResourceBinding?
Any help would be appreciated.

Hi There @rbuzu @linuxlewis I was wondering if you had this figured out.
Stuck with the same issue
Thanks a lot!

Hi @rbuzu
Problem with channel_session_user attribute of channels.binding.base.Binding class, by default it True, need False.
When channel_session_user = True, binding handler wraps by channels.auth.channel_session_user decorator, and it resets the your token user ;(

Hey @gromsterus
I'm struggling with the same problem.
Can we have more details about your solution please ?
Thanks a lot

Would be adorable of you indeed @gromsterus
In need for this feature.


FIPS Compliant Envoy Build for centos 7  & ubuntu

Is your feature request related to a problem? Please describe.
FIPS Compliant Envoy Build for centos 7
Describe the solution you'd like
We would like to get a build with FIPS following the build instructions mentioned
https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/security/ssl#fips-140-2
Describe alternatives you've considered
Trying to build ourself does causes a lot of frustrations
Additional context
Envoy FIPS compliant build for ubuntu & centos 7

cc @lizan

Yes this is in my scope but didn't have bandwidth to setup CI yet.

@lizan I saw a couple of commits related to fips. are fips packages going to be available soon?

we won't be producing system packages long term. please follow https://github.com/envoyproxy/envoy/issues/16867 for "official" ones


accessoryRight of Input prop not working on expo andriod

🐛 Bug Report

When I tried to render an icon with accessoRight it gives an error on my expo go app that "Attempt to invoke virtual method 'int.java.lang.Integer.intValue()' on a null object reference"
It does not give the error on ios
To Reproduce
`
export const PasswordInput: FC = ({ placeholder, value, onChangeText, status }) => {
const [secureTextEntry, setSecureTextEntry] = useState(true);
const theme = useTheme();
const toggleSecureEntry = () => {
setSecureTextEntry(!secureTextEntry);
};
const renderIcon = (properties: IconProps) => (
    <TouchableWithoutFeedback onPress={toggleSecureEntry}>
        <Icon {...properties} name={secureTextEntry ? "eye-off" : "eye"} />
    </TouchableWithoutFeedback>
);

return (
    <Input
        placeholder={placeholder}
        accessoryRight={renderIcon}
        style={[
            InputStyles.password,
            {
                borderColor: theme["color-primary-border"],
                backgroundColor: theme["color-basic-transparent-100"],
            },
        ]}
        value={value}
        onChangeText={onChangeText}
        status={status}
        secureTextEntry={secureTextEntry}
    />
);

};
`
Expected behavior

You should get the error if you run it on expo andriod

I believe this is related to this issue. https://github.com/akveo/react-native-ui-kitten/issues/1675, I think it should have not been closed because the workaround is just a dirty patch.
TL;DR; Add color="" attribute in your Icon component.

Yes, you are correct.


May wrong state config

Describe the bug
The log gives me times this message:
State value to set for "homeconnect.0.BOSCH-WAWH8640-XXXXXXXX.programs.active.options.BSH_Common_Option_RemainingProgramTime" has to be stringified but received type "number"
(replaced the Serialnumber with XXXXX)
To Reproduce
Steps to reproduce the behavior:

Start the washing machine?
Wait

Expected behavior
no info log?
Versions:

Adapter version: 1.0.2
JS-Controller version:  4.0.23
Node version: v14.19.0
Operating system: linux

Objekt löschen und Adapter neustarten

If this problem still exists with current version, please reopen


Cilium: encrypt-node fixes for invalid route and missing rp_filter zero

When encrypt-node is enabled a route is added in the default routing table that routes the IP assigned to the encrypt-interface to cilium_host. However, this is problematic because it results in a routing loop when trying to send traffic (tested with ping) to the node.
After some amount of debugging and staring at the code it appears this happens when a route.Route is specified with a Nexthop but without a Local IPNet. As shown here,
   route.Route{
           Nexthop: nexthop,
           Device:  dev,
           Prefix:  *ip,
           Table:   tbl,
    }

Then the Nexthop address is used as the route destination for the routing table entry and the Prefix ip is ignored(?!). I verified this by putting a log statement just above the route add to ensure it was in-fact using the correct IPs. Further, I found the line that was adding this route by commenting it out and verifying the rule is in fact not added. The offending route is from reateNodeExternalIPSecOutRoute() in the dflt=true case.
There are a few workarounds for this problem. Simply not specifying a Nexthop is the easiest and is the approach we take in this PR because the Nexthop is not needed for encrypt-node and can be removed. An alternative fix is to add a Local IP field.
At this point I don't have a root-cause for the above. The above route.Route is pre-processed by ./pkg/datapath/linux/route/route_linux.go and then translated into a netlink route by the netlink/route_linux.go code in the vendor API. After this it is pushed into the kernel. Presumably, somewhere here either the translation is broken (I'm not seeing how though) or the kernel is buggy. These tests were run on GKEs ubuntu 4.15 kernel. We can root-cause later the above fix resolves this in the meantime. Further its a nice optimization even if there was no issue with the initial route.Route spec.
Lastly, this PR automatically disables rp_filter on the network facing interface. Otherwise if this defaults to '1' node to node traffic will fail.

This change is

test-me-please

test-me-please

Coverage decreased (-0.02%) to 42.109% when pulling<PHONE_NUMBER>8654640759b902ff99e093855ab0fc on encrypt-node-fixes into 6204b7b8420034689a22bae36698f29bef8d57bf on master.


Update Responsive Design

Update icons in nav-bar
Add about page
fix links & buttons
update j-query

update README


New actions interactive learning

Proposed changes:

fixes #1184

Status (please check what you already did):

[x] made PR ready for code review
[x] added some tests for the functionality
[ ] updated the documentation
[ ] updated the changelog

@tmbo please take another look


Make Playwright Tests have Cross-Browser Compatibility

Ryan's Playwright tests that finally worked and revealed that our text metrics do not match across browsers. While slight, the differences in their widths/heights may cause very bad issues when downloading on one browser and uploading to another. (If an atom is too close to a cut it may end up overlapping, for instance.) They also are not consistent when comparing uitestHeadless running in a local terminal and the Playwright test workflow.
We need some fix, real hopefully, temporary if necessary, ASAP.

#343 removes playwright, we will reopen if it is still an issue when we re-add it after 2.0


Rename CollisionFreeMap

CollisionFreeMap is a terrible name.  I think something like ContinuousCombiner would be much better.  I am thinking it would be nice to deprecate  CollisionFreeMap and replace it because the name is so bad.
Any idea for new names would be appreciated.

This was done as part of #130


Add some small improvements to make the list load a bitfaster

Add small improvement on perceived speed of loading:

Use batches of 2 (bigger batches start making the UI block on my machine)
Use 60 ms between batches
Allow for searching of plugins not yet on list, and add them
throttle filter keystrokes so a filter starts only after 200ms
add (X/N) to both list when filtering so it is clear that X plugins are filtered out of a total of N

<15 s to fully populate on my machine vs 45 on main!

Thanks a lot @psobolewskiPhD for the review. You raised valid points and indeed the 200 can be lowered.
https://arxiv.org/pdf/1208.6109 so english average word is 5.1 letters, assuming a typing speed 60 word per minute (https://typing-speed.net/keystrokes-per-minute I tried this one and got 361 letters in 60 seconds, I am not a very fast typer hahah), so we can do some quick math and get:
5.1*60 + 60 = 366 letters in 60 seconds (the extra 60 is to account for spaces), so:
60 seconds / 366 letters =~ 0.163 seconds, which is pretty similar to what I got trying the other service.
So I think I have read somewhere that 150ms was a good number for interstroke time, I just bumped it a bit, but maybe 150 works after all :)

Ah, thanks for the explanation. So you're sort of debouncing.
What I notice is a delay between the first character and 2nd -- when the list is still loading.
Open the manager and try typing lung into the filter, all one word, naturally.
L will appear and then a delay and the rest.

Hi @psobolewskiPhD, yes, indeed debouncing basically, to avoid triggering the filter for just one letter, we could make sure to always have at least 2 letters or 3 before actually doing any filtering, that would also work.
Will take a look at superqt, I thought about it but did not test it.
Will check the first letter issue that you mention!
Thanks again for the comments and the review :)

Will check the first letter issue that you mention!

I've dealt with this kind of issue in the past and resorted to the following strategy:

If len(query) == 1, then we only show results starting with that letter. I doubt folks want all packages containing a 🤷
Else, we show results containing it.

Depending on the volume of results for 1 (and 2?), maybe you can adjust the startsWith / contains threshold differently.
If this is too weird, then I suggest disabling search for queries of length == 1.

It was fairly simple to implement your suggestion @jaimergp , so I think we are good now with this PR :)

If len(query) == 1, then we only show results starting with that letter. I doubt folks want all packages containing a 🤷

It should also show packages starting from napari-a in our case.

It should also show packages starting from napari-a in our case.

Done @Czaki !

Definitely feels better, but I still see a delay when typing a word like lung naturally, after the first letter.
Shouldn't the 120 ms timer would prevent anything after just the first letter (debouncing), until I finish? It feels like it need to trigger -- off the first letter -- and the debounces the rest of them.

Definitely feels better, but I still see a delay when typing a word like lung naturally, after the first letter.
Shouldn't the 120 ms timer would prevent anything after just the first letter (debouncing), until I finish? It feels like it need to trigger -- off the first letter -- and the debounces the rest of them.

Will check again, as I am not seeing that on my side 🤔

Feels really solid now!
I do get a traceback when closing napari though:
Exception ignored in: <function CameraMonitor.__del__ at 0x1437a4180>
Traceback (most recent call last):
  File "/Users/piotrsobolewski/Dev/napari/napari/_qt/qt_viewer.py", line 1387, in __del__
    self._reset_camera_moving.cancel()
    ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/piotrsobolewski/Dev/miniforge3/envs/napari-dev/lib/python3.12/site-packages/superqt/utils/_throttler.py", line 291, in __get__
    parent = self.parent()
             ^^^^^^^^^^^^^
RuntimeError: wrapped C/C++ object of type ThrottledCallable has been deleted

(open the manager, search for something, close the manager, quit napari)
Also, I was surprised to see the search persist through closing the widget, but I guess that's the caching from the other PR.
Honestly, not sure what the "right" behavior is, so not a blocker at all. Resolving the RunetimeError though would be good.

Hi @psobolewskiPhD thanks a lot for all the feedback. Hmmm weird, that traceback feels unrelated. But I will try to reproduce and see if soemthing i did messd it up!

Also, I was surprised to see the search persist through closing the widget, but I guess that's the caching from the other PR. Honestly, not sure what the "right" behavior is, so not a blocker at all. Resolving the RunetimeError though would be good.

Indeed! I can reset the search on reopen, that would probably feel more natural. Also working on a separate PR to add notifications when things ended or finished if for example you started installing something and closed the dialog. That way the user knows when something finished installing or if an error occured ✌🏼

Shoot hang on, I could have had a branch checked out in napari repo. When I had this checked out. 😬

@psobolewskiPhD now the filter gets cleared on hide/close to match your expectations, also added a small fix and now is good to go. Will merge after tests pass so I can focus https://github.com/napari/napari-plugin-manager/pull/45 which is the final piece of work !

The failing test does not seem reproducible. Tested locally, will merge an iterate on the last PR


Re-injecting the dead-letter files through Stats.ImportAzureCdnStatistics could lead to duplicate data.

@cristinamanum commented on Fri Jan 13 2017
The stats imports have the following method that inserts data:
public async Task ProcessLogFileAsync(
  ILeasedLogFile logFile,
  PackageStatisticsParser packageStatisticsParser,
  bool aggregatesOnly = false)
{
  //...
  try
  {
    var logFileName = logFile.Blob.Name;
    var cdnStatistics = await ParseLogEntries(logFile, packageStatisticsParser, logFileName);
    var hasPackageStatistics = cdnStatistics.PackageStatistics.Any();
    var hasToolStatistics = cdnStatistics.ToolStatistics.Any();

    // replicate data to the statistics database
    if (hasPackageStatistics)
    {
      // some code
      **await _warehouse.InsertDownloadFactsAsync(downloadFacts, logFileName**);
      //more code
    }

    if (hasToolStatistics)
    {
      // some code
      **await _warehouse.InsertDownloadFactsAsync(downloadFacts, logFileName);**
      //more code
    }

If the first Insert download succeed and the second fails the file is added to the dead letter.
If the file is moved in raw storage at reprocessing the first insert will insert same data again .

@skofman1 commented on Thu Jan 19 2017
@xavierdecoster ?

@xavierdecoster commented on Fri Jan 20 2017
Looks like we may need a UNIQUE INDEX on this table?
(which will slow down inserts, and increase storage requirements)

@xavierdecoster commented on Fri Jan 20 2017
Also: the above piece of code is targeting two different tables.
First one is targeting the Fact_Download table, the other one is targeting the Fact_Dist_Download table. They do not insert in the same tables.
See:

https://github.com/NuGet/NuGet.Jobs/blob/81fa007ca528a64d1a684878e9915f760a26c3c5/src/Stats.ImportAzureCdnStatistics/LogFileProcessor.cs#L79
https://github.com/NuGet/NuGet.Jobs/blob/81fa007ca528a64d1a684878e9915f760a26c3c5/src/Stats.ImportAzureCdnStatistics/LogFileProcessor.cs#L122

@skofman1 commented on Fri Jan 20 2017
@xavierdecoster , @cristinamanum , can we close this?

@cristinamanum commented on Fri Jan 20 2017
I think that an issue still exists. From my understanding - Let's assume that

the first ingest is fine ( Fact_Download and Fact_Download_.. _ProjectType are updated )

The  insert for  Fact_Dist_Download  fails (throws)
Result => file is in dead letter.

The file form dead letter is moved back to the raw storage.

It will be processed again and the data from (Fact_Download and Fact_Download_.. _ProjectType ) will be re-ingested.

Maybe we can have the data ingested in one transaction?

@xavierdecoster commented on Fri Jan 20 2017
You are right @cristinamanum !
We should update that method to accept a transaction and have both invocations within the same transaction.

Another idea that was discussed regarding how to approach this is to use the file LogFileName in the FactDownload and Dist_FactDownload. If the file that is currently processing has already entries in these tables a new insert will not be attempted.
This assumes that: 1. No partial inserts will be done. 2. The data from these tables is not altered by other process/job. (for example a file inserted does not have the LogFileName altered later).

The job handles two pipelines really: one for package download stats, another for tool downloads from dist.nuget.org.
I believe we should be able to gracefully handle errors in either one of these processing pipelines independently. In other words, partial inserts should be possible, albeit within that pipeline's transaction.
So I'm leaning towards not sharing the transaction, and checking the Fact_Download (resp. Fact_Dist_Download) table for records linked to the currently processed LogFileName.
Thoughts on this approach @cristinamanum ?

Reading more the CollectCDNLogs job, my understanding is that two files with the same name to be processed is a supported scenario from the CollectCDNLogsJob point of view. For example in line : 176 in Job.cs  - var isReprocessing = await azureClient.CheckIfBlobExistsAsync(cloudBlobContainer, rawLogFile.FileName);
and also my understanding after a file is renamed a file with same name can still be created on the ftp server.
If this is correct it will mean that ImportStats job cannot rely on the assumption that all the files that will come to be processed will have distinct names. It also will mean that the jobs consuming the stats data cannot assume that the file names are different.

... my understanding after a file is renamed a file with same name can still be created on the ftp server.

@cristinamanum That should never happen. EdgeCast is dropping the files onto our FTP, and will handles the file names and numerical increments there-in. When a file is dropped onto the FTP that is corrupt, or fails to be delivered to our FTP, they don't retry, they send us an email notification about the failure.
When a file failed to deliver to the FTP server, and we recover it ourselves and copy it to the FTP server, it's still going to be the first successful delivery to the FTP server.
Our own procedure to reprocess a file in the case of failure does not involve the FTP server at all. We copy our deadlettered blobs to the to-be-processed container in blob storage instead.


Splitting up alertmamager config

Is it possible to split up the alermanager config / route rules?
We arr currently havind a whole bunch of alerting and routing rules, in a more perfect situation you should be able to split this up.
Just like there's done for the alerting rules of premotheus.
Can this be done by the templating function (which isn't well documented, causing the confusion).
I would like to hear from you guys,
By the way... if this isnt impemented yet, coyld you guys create something like that? I assume the most of theje code could borrowed from the prometheus alerting code :-)

The file cannot be split up at this time. You could use a configuration management system to merge the two files together at deploy time, though.
I would suggest using config management instead of implementing this in a pull request. I'll leave the issue open in case this is something more people would like to see.

Thanks for the reply. I did some research and wasn't even aware of the option you proposed. That's working for me. Thanks.
The feature would be nice, for people without an config management system.
@stuartnelson3 thanks!


Package spec redefining macros we use

I wonder how often this happens - https://git.centos.org/rpms/abrt/blob/c8s/f/SPECS/abrt.spec#_708
Known affected packages:

c8s abrt, gnome-abrt, libreport
c8: , abrt, abrt-java-connector, libreport, satyr

we should send them patches to do %autosetup -S git_am instead

Requires patching of the spec file


"profile" argument, default value should probably be "Any" instead of "None"

The "profile" argument of New-NetFirewallRule is stated in this page as having a default value of "None", but the text a few lines above says the default is "Any" which I guess makes more sense, since you "None" is not an accepted firewall profile.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a81ceb77-8de5-8c07-c0c4-fa3d616d859f
Version Independent ID: 736dd392-788a-c102-dfcb-29a08c2c9f9d
Content: New-NetFirewallRule (netsecurity)
Content Source: docset/windows/netsecurity/new-netfirewallrule.md
Product: w10
Technology: powershell-windows
GitHub Login: @coreyp-at-msft
Microsoft Alias: coreyp

@officedocsbot assign @e0i

@pgorod
Upon your feedback, We have updated the content with relevant changes accordingly. Thanks.

@officedocsbot close


Node Protections

We need a way to protect groups of nodes from modifications, such as the spawn area of the server.  Nothing too complicated, but this would be good to have..

@squidicuzz Possible fix - https://notabug.org/TenPlus1/protector/src/master/README.md

@squidicuzz Possible fix - https://notabug.org/TenPlus1/protector/src/master/README.md

this is the same one I was looing at

We're testing out protector. It doesn't seem like it fully protects, so we will need to look into which mods do not respect the protection.

Seems good to me!  Added.


Setup GitHub actions to implement regression testing of loading METdatadb Issue 67

Pull Request Testing

[ ] Describe testing already performed for these changes:
Activated GIthub Actions

[ ] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

[ ] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]

[ ] Do these changes include sufficient testing updates? [Yes or No]

[ ] Will this PR result in changes to the test suite? [Yes or No]
If yes, describe the new output and/or changes to the existing output:

[ ] Please complete this pull request review by [Fill in date].

Pull Request Checklist
See the METplus Workflow for details.

[ ] Complete the PR definition above.
[ ] Ensure the PR title matches the feature or bugfix branch name.
[ ] Define the PR metadata, as permissions allow.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes
[ ] After submitting the PR, select Linked issues with the original issue number.
[ ] After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
[ ] Close the linked issue and delete your feature or bugfix branch from GitHub.

@venitahagerty I discussed this with @georgemccabe and asked him to review this PR and advise.


Support AWS S3 virtual-host style URLs in addition to the existing path style scheme

Rebased the earlier PR to merge cleanly. Fixes #55 and adds tests.

Applied as b53cddabd5612de11b3439f5e19aadf4eb768998, thanks.
Please note the formatting changes that I made to your commit description: the first line stands alone and is less than 68 characters long, and the rest of the description is flowed so that each line is less than 76 characters long. This makes the commit descriptions readable in a standard-size Unix terminal. Thanks!

Thanks Bryan. Appreciate it!


[otp_ctrl] otp check timeout but checks are still running in the background

Hey Michael,
I found from simulation that even though otp check timeout (when I set timeout register to very small number like 5 cycles), the background is still doing checks by each partitions. (Please refer to the screenshot below)
I think the main reason is the integ_chk_req_q or cnsty_chk_req_q were not cleared in ErrorSt.
If not too much trouble, do you think it would be worth to add logic to immediately exit the background check if timeout reached?

Thanks,
Cindy

Hey Cindy,
Yeah that is correct.
Note that even if we clear the requests bits inside the timer, most partitions will already have switched into the checking mode in their FSMs, hence it is unfortunately not so straightforward to abort all checks once the timeout is reached.
Is it a problem if the checks are ongoing?
Best,
Michael

I see, thanks for confirming Michael. Yeah I just think it is a little bit unusual.. When I access some DAI interface after the check timeout, the timing is longer than expected. But in theory, if a check timeout happened, user should not try to access any OTP memories.
I can align on the DV side.

Yeah exactly, this is a case that should never occur, and if it does, we are anyways in a failure condition.

close via PR #5661


checkbox ripple doesn't overflow anymore under v.6.2.1

Bug, feature request, or proposal:
Bug
What is the expected behavior?

What is the current behavior?

As you can see above, the ripple is cut off by the following line in the table and this is WITH the fix that was suggested for ripple :
https://github.com/angular/material2/issues/8600#issuecomment-358895611
mat-cell.mat-cell, mat-header-cell.mat-header-cell { overflow: visible; }
which used to fix it but doesn't in  v.6.2.1
not only that but this "fix", this will now also break horizontal alignment of the texts in each row of the table (so I don't use it) :

UPDATE : I've worked out that this doesn't occur with the new <td> tags I mentioned in this issue : https://github.com/angular/material2/issues/12753
but that's a real problem for me, I need help switching from one to the other as so far every attempt I've made has failed.
What are the steps to reproduce?
StackBlitz : https://stackblitz.com/edit/angular-material2-issue-6jyqu4
you'll notice this stackblitz contains the checkbox offset bug mentioned in the first thread I linked but I don't personally have this. my checkboxes don't move they just fail to overflow their ripple onto the line below.
What is the use-case or motivation for changing an existing behavior?
the ripple effect of the checkbox is pretty and is an important part of material's visual identity
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
material v.6.2.1
Is there anything else we should know?

Have you found any workarounds for this issue?

I upgraded versions.

The last comment sounds like the issue was resolved. Closing.


Debugging

Type: Question

Packages
Version

fela
12.x.x

Description
Debugging fela is extremely difficult and time consuming. Unfortunately we've built a not so small project on fluentui which internally uses fela. All class names are: a, b, c, etc.... which make it very difficult and troublesome to debug in development WHERE classes are coming from. I can't find anything within the documentation to make it a little bit easier to debug.
Has this issue been solved already? are there plugins to get around this? In my desperation I looked around and started to "cook" a solution which includes a compile time transfomer to transform styles and inject the _className property that i noticed in extractCustomClassName. This solution is only half of a solution as the resulting class names don't include styles, and are just there for reference.
To clarify, I want to not break up properties into their own classes to help us at least track down where a certain style is coming from. From my understanding, this is the very least we can achieve with how fela is set up and works.

Steps to reproduce

N/A
Expected Behavior
N/A
Actual Behavior
N/A

Proposal
N/A

Hmm, what's your use case? You usually do not debug the generated CSS as it exactly reflects the written code.
With atomic CSS classes do not come from a certain component, but are reused all over the app in a one-to-many relation.
You can always pass custom HTML attributes including className, if you want to pin down a component, otherwise I'd rather debug the style object(s) that you pass to components directly, to see which styles are applied.

Closing this. Feel free to open a discussion if you want to further discuss the topic!


Fix Quotation structure casting to json

Using ruby 3.2.2
Posting create_order request. Struct invalidates request.
https://github.com/blackchestnut/invest_tinkoff/blob/master/lib/invest_tinkoff/client_base.rb#L31
=> body.to_json

"{ ..., \"price\":\"#<struct InvestTinkoff::V2::Quotation units=200, nano=0>\", ...}"

Added custom json type cast to Quotation

@light-flight many thanks for your hotfix. I hope it worked for you... merged without testing


React function components and hooks

FEATUREREQUEST
Description:

The "modern" way of writing react applications is using function components and hooks, instead of component classes. We should think about whether we want to switch to these concepts or not.
This issue should work as a forum for discussion.
Some pros and cons:
pro:

more reusable code between components
clearer structure within components (as logically related things will be put together, instead of splitting by lifecycle methods)
more concise component exports (e.g. currently, we export components with i18n differently from their non-i18n versions)
better/simpler use of context (used for i18n and compositions)

con:

refactoring all our components
possibly worse/confusing project structure (due to components sharing logic)

@dnlkoch @KaiVolland @chrismayer @marcjansen @hwbllmnn what do you think?

As https://github.com/geostyler/geostyler/pull/1395 shows we'll need to change the way we are testing.
Maybe a switch to https://testing-library.com/docs/react-testing-library/intro/ will be usefull to make writing tests easier.

It would be nice, if you could write a few (example) tests using that library, to see if this actually makes things easier for us.

That's ok for me. We could also use this issue as an overview of the components that still need to be replaced. You decide.


Not compatible with 4.X.X

The latest version is not compatible with the newest version of Microsoft.Bot.Connector which is 4.0.7 (just released). Are there any plans to update this library too?
If not, and you're interested, I can submit a PR.

Would you accept a PR for this?

A PR at this moment is not required. v4 is a breaking change and hence our changes will be breaking as well (one of the reason current nuget is blocked from installing on v4). The new design requires some discussions internally. Rest assured we are working on it :)

It's true, with the new design of Bot Framework SDK v4 it's not clear how to return a response for messaging extension invoke request.

Hey folks... just wondering if there has been any progress made on this one?  Looking forward to a v4.x.x compatible version. :-)

Actively working on it with the Bot Framework team on how to best model our extensions.

We still do not have a timeline.


GSRL training code

Hi,
Thank you for your work. As there have been 5 months since the README file was last updated, could you please share the training script for the GSRL module? Thanks in advance!

Hi, thanks for your work. I would like to ask when will the code for GSRL module training be released?


WT doesn't support U+2068 and U+2069 characters

Windows Terminal version
1.20.10161.0
Windows build number
10.0.26020.1000
Other Software
AOSC OS on WSL
Steps to reproduce

Install AOSC OS on WSL from Microsoft Store
Finish the OOBE
Run sudo oma refresh

Expected Behavior
The output is fully human readable.
Actual Behavior
Several unreadable characters appear, specifically U+2068 and U+2069.
These characters are for Explicit Directional Isolates. Microsoft's doc also mentions these characters. It seems that Windows Terminal doesn't support them, and just print the characters out.

@lhecker you're more familiar with unicode than I - this is basically a dup of #538, yea?

Just added the screenshot, I think it's partially a duplicate, but what I care the most is to improve readability, not to actually support that Unicode feature.

I believe we can consider this part of #538 even if automatic directionality has not been mentioned yet there. The reason this occurs is because we don't yet analyze the input text for directional markers at all. I'll leave this issue open though, because I want to suppress rendering these glyphs in a hotfix first. Afterwards we can continue tracking the overall issue in #538.
BTW: I see that the numeric parameter for OMA's packages-can-be-upgrade message is also wrapped in a FSI/PDI pair. It probably shouldn't do that, since the number is part of the sentence and many rendering algorithms look a bit weird if you change the directionality of text more than once per paragraph.


natel-plotly-panel & other custom Plugins have been removed

natel-plotly-panel & other custom Plugins have been removed in the latest Teslamate grafana version (replaced via xy chart & geomap - natively available in latest grafana releases).
https://github.com/teslamate-org/teslamate/commit/1796294442566a8f504f0eda052603ef4228a9f7
Would be great to See custom Dashboards updated so they continue working Just fine!

Thanks for the notice, I'll check it out as soon as possible.

Hi again
I just updated the dashboards so that they are fully compatible with the new version of Teslamate.
Thanks again for letting me know

Thanks reacting so fast!


Fixed, issue#983: There is no footer in job listings page

Pull Request Template

Please provide all of the details below. Pull requests missing any of the information below will be closed!
Providing the issue number/url helps us identify the problem being solved and keep the issues tab clean and tidy

What issue does this fix?.
Summarize what this PR fixes:-
< Detail what your PR changes/fixes >
What ISSUE NUMBER does this fix?
#983
Fixes #
Checklist
(Add an x between the brackets to check the items)

[x] I have summarize what this PR fixes above
[x] I have provided the issue ID/URL above
[x] I have not added Bootstrap or jQuery and used correct styling guide.
[x] This PR fixes only the issue mentioned above (create separate PRs for separate issues)
[x] I was the first one to claim the issue or I created the issue - I created the issue

Issue: #983


bin/compile: set GOCACHE inside cache directory for build caching

Set GOCACHE to Go 1.10+

Thoughts on using semver compare 1.10 $(go version | sed -e 's/.*go\([0-9]\.[0-9]\{1,2\}\(\.[0-9]\{1,2\}\)*\).*/\1/') from https://github.com/fsaintjacques/semver-tool and listing one of the releases in files.json instead of having to vendor semver bash?

@danp @freeformz PTAL again. I should have addressed all concerns.

Doh, getting the error when comparing a string to an integer: ASSERT:Expected STD_ERR to be empty; was </buildpack/bin/compile: line 305: [: devel-15f7a66: integer expression expected> expected:<> but was:</buildpack/bin/compile: line 305: [: devel-15f7a66: integer expression expected>. Not sure what's the cleanest way to fix it.

Maybe different approach: what if we base setting GOCACHE on whether it shows up in go env? That should work with devel versions too.

LGTM! Maybe the troels/heroku:18-build image has gone away.

Could maybe use a changelog entry as well?

Could maybe use a changelog entry as well?

Done

@freeformz @danp After bumping the fixture to 1.10.2 then the testGoCacheGoVersionGreaterThanOrEqualTo110 passed on Travis. Super strange...but anyways. this is ready to be merged I think.

Hmm, wonder if it will break again once, say, 1.10.3 comes out.
@freeformz want to redo your review?

@freeformz Would you mind looking at this?

To answer my own question above the default is GOCACHE="/app/.cache/go-build", which is :-(

@jingweno Suggestion: set the cache to ${cache}/go-build-cache and it will be cleared during any go version change. This makes the test(s) stable as well.

Thanks!

Released as v89

Thanks so much for sticking with this, @jingweno!


No influx export since v0.16

No more influxdb exports since migration to 0.16.
Maybe forgotten to change table structure of influx exporter?

#1164 should fix that. Rolled out in v0.16.3


How to use in different versions

how to use in
0100D09016C6A000(FBBC0547B10349D6)

Not sure what you're asking, but you need to use Edizon/Breeze to use the cheats.


Prototype/Design Update - Call for Records Ministry

Description:
First draft of design for Call for Records Processes for Ministry Users. Based off of the user flow created as a product of the UX Research Sessions with Ministries.
DOD
CFR Form/Ministry Tracking

[ ] View of Call for Records form from IAO
[ ] Ministries track assigned divisions/program areas
[ ] Ministries ability to track which stage each division/program ares is at (ie, records gathering, fee estimate, harms assessment)

Activity Log

[ ] Add Activity Log to Left Nav
[ ] Display heading and have content expandable or have it as a single line shows and can expand down
[ ] Activity log you should be able to edit your own additions, but not edit anyone else's
[ ] See 'subject' 'Date written/added' 'IDIR/Username' of who it was created by
[ ] Ability to add comments to activity log

@JHarrietha-AOT Can you please add in notes for DOD for this. FYI ticket #135 was the last prototype card we created if you wish to refer back

Based on Scope Decrease of the MVP so we can release to the pilot Ministries sooner the:

activity log
in app correspondence
online web form version of the CFR Doc

will not be included in the designs at this time.


If I want to train the 3D image data using MTL by MGDA do I have to change the code min_norm_solver.py?

I have already change my model to suit the training file but don`t know what I have to change the min_norm_solver.py file


Removed "outdated" from version agnostic "Getting started" docs

The entrance for users when they click Getting started on Kubeflow.org is the Installing Kubeflow page, which appears outdated:

At a first glance, this is more of a gateway, which seems version agnostic. And we're telling ALL users that our main docs page is outdated. It surely has space to improve, but at the current pace, I argue that we should remove the outdated banner and later on create a coordinated effort to update it.
Same for Getting Started > Kubeflow Overview.
@8bitmp3 @jlewi @jbottum what are your thoughts on this?

@8bitmp3 since I started the PR, you have to be the one to approve :) Given that this is under our responsibility.

/assign @8bitmp3

@joeliedtke @Bobgy Can you please take a quick look - I think this is a good idea by @RFMVasconcelos

Thanks!
Preview:
https://deploy-preview-2261--competent-brattain-de2d6d.netlify.app/docs/started/getting-started/
High level comment: I think the main purpose of this page should be to redirect to one of the sections with detailed instructions and clear owners.
Along those lines should we delete the section "Configuration Quick Reference"
https://github.com/kubeflow/website/pull/2261/files#diff-1705b3cb96d57a841492edf36721efc6R87

This is duplicating information that should be in the detailed sections.
Not all installation options are using this config files. Removing those distributions from the table could be misleading

i.e. users think a given distribution isn't supported when in fact it is it just uses a different deployment option.

Likewise should we remove the section "Installing Command Line Tools"

The command line tools needed will depend on the installation option you are choosing.

For the section "existing Kubernetes Cluster"
https://deploy-preview-2261--competent-brattain-de2d6d.netlify.app/docs/started/getting-started/#installing-kubeflow-on-an-existing-kubernetes-cluster
Can we change the title to something like "conformant Kubernetes Cluster" ? and likewise add an explanation along the lines of if none of the platform/cloud specific use directions work for you, you can try these instructions for a generic cluster.
On the overview page should we delete the section "kubeflow-command-line-interface-cli"
https://deploy-preview-2261--competent-brattain-de2d6d.netlify.app/docs/started/kubeflow-overview/#kubeflow-command-line-interface-cli
kfctl is specific to certain ways of deploying Kubeflow so its not always used.

Hey @jlewi,
Thank you for your always sharp commentary! Replying inline:
Getting Started Page

High level comment: I think the main purpose of this page should be to redirect to one of the sections with detailed instructions and clear owners.

Very much agreed! This should overarching index page that maps content to needs, not a version-specific content page.

Along those lines should we delete the section "Configuration Quick Reference"
https://github.com/kubeflow/website/pull/2261/files#diff-1705b3cb96d57a841492edf36721efc6R87
This is duplicating information that should be in the detailed sections.
Not all installation options are using this config files. Removing those distributions from the table could be misleading
i.e. users think a given distribution isn't supported when in fact it is it just uses a different deployment option.

It seems that this table is still serving the purpose of mapping deployment platforms to their docs. Removing it without a replacement strategy for mapping docs might be risky IMO.

Likewise should we remove the section "Installing Command Line Tools"
The command line tools needed will depend on the installation option you are choosing.

As you mention, these appear to be deployment-specific. I'll add a commit to remove.

For the section "existing Kubernetes Cluster"
https://deploy-preview-2261--competent-brattain-de2d6d.netlify.app/docs/started/getting-started/#installing-kubeflow-on-an-existing-kubernetes-cluster
Can we change the title to something like "conformant Kubernetes Cluster" ? and likewise add an explanation along the lines of if none of the platform/cloud specific use directions work for you, you can try these instructions for a generic cluster.

I can do this. I'm starting to question the reason for it to be 1 full section with 1 sentence. Let me work on a proposal to summarize/compress these methods and remove cognitive overhead.
Overall comment:
Looking at these comments it seems that we want to have this page be a map, and at the moment it is a confusing one:

The diagram is mapping to anchors in the page
"Install Kubeflow" and "Configuration quick reference" sections seem to be somehow redundant in mapping to specific docs.

Actions:

Delete the section "Installing Command Line Tools"
Find best way to display what is not in "Install Kubeflow" and "Configuration quick reference" section
Improve or remove section "existing Kubernetes Cluster" based on 2.

Overview Page

On the overview page should we delete the section "kubeflow-command-line-interface-cli"
https://deploy-preview-2261--competent-brattain-de2d6d.netlify.app/docs/started/kubeflow-overview/#kubeflow-command-line-interface-cli
kfctl is specific to certain ways of deploying Kubeflow so its not always used.

Agreed. I can also commit this removal.
LMKWYT!

Ideally, IMO, we should merge this subset of changes, to remove the outdated banner ASAP, and then work to agree on the best strategy in a new PR.
DONE:

Remove  section from getting started
Remove <Kubeflow command line interface (CLI)> section from overview

NEW PR:

Find best way to display what is not in "Install Kubeflow" and "Configuration quick reference" section
Improve or remove section "existing Kubernetes Cluster" based on 2.

@8bitmp3 @jlewi WDYT?

Thanks
The configuration quick reference is duplicating information in the sections above. The doc even says so

The matrix is therefore an alternative way of accessing the information in the installation section above.

The problem is the column "manifest". Not all of the deployment options use KFDef manifests anymore.  The row for GCP is problematic because its pointing at the outdated manifest.
Here are a couple options

Delete the manifest column
Delete the table all together
Put Not Applicable in the GCP column

I much prefer deleting the manifest column altogether. This should lower the burden of maintaining this page over time.
I might also suggest changing the title "Configuration Quick .. " to "Deployment Quick ..."

Sounds good!
I'll remove the manifest column and switch "Configuration" to "Deployment".

Thank you both @RFMVasconcelos @jlewi!
/lgtm
/approve
This looks good to me!
I'm not seeing unanswered comments, so I'll just let it merge. Feel free to add further comments and start new PRs.


Upgrade to Stack LTS 4.0

We can upgrade to the latest Stack LTS version.
/cc @CristhianMotoche, feel free to take this one if you want. :)

I think we could mark this as solved, since #10.

Sure, I'll close this. However, feel free to upgrade to 4.1 - I think that's the latest now?

Yeah, actually they will release LTS 5 this Sunday, so I'll upgrade it this Sunday.


gha: enable IPv6 in clustermesh upgrade/downgrade workflow

Now that known issues causing connection disruption (which appeared to mostly affect dual stack clusters) have been fixed, let's enable IPv6 again in the clustermesh upgrade/downgrade workflow.
Link to three successful runs: https://github.com/cilium/cilium/actions/runs/7117112225

Reviews are in, clustermesh CI is green. Marking ready to merge


Missing in-place option for generate

I don't see any option how to update existing passwords, which seams really inconvenient.
In pass there is option -i or --in-place for generate which allows replacing only first line. In gopass generate help there is help text:

Optionally replace only the first line of an existing file with a new password.

But there is no info how to do that.
Btw. this is one of things I found extremely inconvenient even in original pass. I think gopass can go one step further and if there is existing entry, it can simply ask user if he wants overwrite whole entry or only update password. IMHO it would be best to change default behavior to inplace without asking but we probably don't want to behave differently then pass?

Gopass generate will only modify the first line, i.e. it already matches your suggested behavior. We need to explain this in the docs.

thanks, amazing :) It probably didn't work in previous version (I tried today in 1.2.0 and it overwritten whole entry) and after upgrade I checked only doc and not behavior.
Should this remain open until doc is fixed?

Yes, please keep it open. This must be documented in the Readme and the help output.


Linux CI build does not fail when Pester Tag is missing

Steps to reproduce
Omit the Tag for a Pester describe block and trigger the Linux CI build process.
Describe "Sample test" {
}

See Draft PR #9192 for example.
Expected behavior
Build process should fail for Windows, macOS and Linux.
ci.psm calls Get-PesterTag from build.psm1 to check if all test blocks have a valid Tag.
Actual behavior
Linux CI build succeeds and tests are executed without any error.
See Draft PR #9192 for reference.
Environment data

cc @TravisEz13 and @RDIL

I’ll take a look later.

Issue no longer exists after PR #9209, which is merged now.
Draft PR #9192 now successfully fails on Linux too.
Thank you @TravisEz13 and @RDIL!

Technically it's still an issue, if you add the [feature] tag to the start of the last commit

@TravisEz13 Draft PR #9192 fails on all platforms with added [feature] tag for commit message. This is the expected behavior. Therefore I'm not able to reproduce it for PR CI runs.
Since the merged code base for tests all include tags for Pester, only PRs would be able to introduce this problem.
If you have time, maybe you could have a quick look, if I missed something.

Your failure occurs in the build, which will fail as expected.  The issue occurs when a pester test fails.

Added the fix for this to #9212

@TravisEz13 Thank you for clarification, but for the issue I described above the problem is fixed. The fix in #9212 describes a scenario which is post-build. This was a separate issue, but not the one I intended to describe with my issue.


Control highlights broken in neovim nightly

After the following change, https://github.com/neovim/neovim/pull/26334 the debugger controls look like this:

In the meantime, I've added the following to my config:
highlight! link StatusLineNC Normal

Bump on this. I am seeing the same thing on v0.10.0. It seems to change depending on if the controls element is active or not.

Inactive

Active

I'm facing the same issue, Neovim v0.10.1


Dynamic params and query params, url not updated?

Hi there, I'm using version 1.0.0-alpha.4 because I have the following use case:
I have to implement a search, and the parameters are passed via query params like this: /search?city=Boston&start=2016-01-01&end=2016-01-10
The state is defined like this:
$stateProvider.state('search', {
    url: '/search?city&startDate&endDate',
    templateUrl: 'some/url/template.html',
    params: {
        city: {
             value: 'Boston'
	     dynamic: true
	},
	startDate: {
	     value: '2016-01-01',
		dynamic: true
	},
	endDate: {
	    value: '2016-01-10',
		dynamic: true
	}
}

Everything is working well, and when the user updates the parameters, I'm calling $state.go($state.current.name, newStateParams);, and the callback function uiOnParamsChanged is also called correctly.
Only the parameters in the url are not updated. So when the user wants to search in Chicago, the url is still search?city=Boston... after the state-change. Is this the correct behavior? Do I have to update the url manually?

No you shouldn't  need to manually update the URL. This sounds like a bug.

Hi,
I have a similar issue.
My define:
$stateProvider.state('zone', {
    url: '/zone-:zoneId',
    templateUrl: '/zone-detail.html',
    controller: 'zoneController'
});

When I click on link on view (use ui-sref) or use $state.go, it redirect success. But when I change the zoneId on address bar -> state not change.
The back button not work, too.
Test on Chrome.
Is this a bug?

@christopherthielen wonder this is related to https://github.com/angular-ui/ui-router/issues/2723

@Ben305 Here is a working plunker: http://plnkr.co/edit/0ww2TBT2WNPkZauuvEjT?p=preview
Can you provide additional information? The URL should be updating.
@dracula92107 I think you have a different problem, but you haven't provided enough information to give an answer.
Can you open a new issue, and provide a plunker that reproduces the error?  Start here: http://bit.ly/UIR-Plunk

moving to alpha.6 milestone while waiting for info from @Ben305

Closing due to no activity


[SMALLFIX] Improve mini benchmark

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/14798/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/14801/
Test PASSed.


v10.1.0 improve cell model

Current coverage is 92.20%

Merging #179 into master will increase coverage by +0.81% as of 7e41543

@@            master   #179   diff @@
=====================================
  Files           26     26
  Stmts          372    372
  Branches         0      0
  Methods         83     83
=====================================
+ Hit            340    343     +3
  Partial          0      0
+ Missed          32     29     -3

Review entire Coverage Diff as of 7e41543

Powered by Codecov. Updated on successful CI builds.


Read a provider outside widgets

I'm trying to read a provider from outside a widget. The documentation says to use ProviderContainer but when using it I get and instance of my StateNotifierProvider with the default state (maybe a new instance).
I'm using it as the documentation:
ProviderContainer().read(myStateNotifierProvider.state)
Is it possible that the documentation is missing something? For example I see in the API reference that ProviderContainer accept parent as a parameter but I can't find where it is explained or why it is used for. I don't know if this is the problem but I couldn't find more information about how to read properly providers outside widgets apart from official docs using it on tests, and this way I get always a new instance of the StateNotifierProvider.
Thank you for your time.

You can't just create a ProviderContainer and read the state.
Two different containers have a completely independent state from each other
I need to know more about your use-case to answer correctly.

Well, in my case I have dart-only files holding stateNotifiers and dart-only files holding providers. I was trying to access a provider inside the stateNotifier. If ProviderContainer doesn't hold the global providers state maybe would be a better idea to pass this data to the function living inside the stateNotifier class instead of trying to access this data in the function itself.

Could you share some code of what you're trying to do?

I have a signInFormProvider that holds the singIn form data in a stateNotifier class. I want to access this provider state inside the signIn function of this new stateNotifierProvider:
class SignInNotifier extends StateNotifier<AsyncValue<Unit>> {
  SignInNotifier() : super(null);

  Future<void> signIn() async {
    state = const AsyncValue.loading();
    final signInForm =
        ProviderContainer().read(signInFormNotifierProvider.state);
    final email = signInForm['identifier']; // Always ""
    final password = signInForm['password']; // Always ""
    state = await AsyncValue.guard(() => ProviderContainer()
        .read(authRepositoryProvider)
        .signInWithEmailAndPassword(email: email, password: password));
  }
}

You can do:
final myProvider = StateNotifierProvider((ref) => MyNotifier(ref))

The use that "ref" object to read other objects

Yes! That is the best way, thank you so much. Hopefully it helps to others too.


Bad String

Will use 'try and except' in python to pop up an alert message if the entered string could not be converted into an integer, hence avoiding an error.

/assign


spack garbage collect when building github cache

#18 #

@idigs This shouldn't be closed until #18 is merged.


Install LFortran at the CI

The easiest would be to just install LFortran using conda on all platforms.
But I don't know if we can live with the "lag" that we fix some bug / add a new feature and we have to make a release, update conda (so at least several hours iteration). But if we can, the advantage would be that we test the actual conda package that it just works, so we don't have to test it separately, and the CI would test it just like users would install it.

@Pranavchiku currently one must install LFortran with the WITH_LSP=ON cmake flag. Is there any reason not to make this flag on by default (and enable at conda)? Is is slowing something down for regular compilation?

@Pranavchiku currently one must install LFortran with the WITH_LSP=ON cmake flag

I don't see any drop in performance. We can do that but it needs refactoring at the following lines. I'll do that.
    if (show_asr || compiler_options.lookup_name) {
#ifdef HAVE_LFORTRAN_RAPIDJSON
        std::cout<<"arg_file: "<<arg_file<<std::endl;
        return get_definitions(arg_file, compiler_options);
#else
        return emit_asr(arg_file, lfortran_pass_manager,
                compiler_options);
#endif
    }

Enabled by default at https://github.com/lfortran/lfortran/pull/5438

Here is how we can create a conda package of the latest lfortran: https://github.com/lfortran/lfortran/issues/5451.

This was added as part of https://github.com/lfortran/lfortran-lsp/pull/16, but I will leave the issue open until we can replace the cloned repository with a conda dependency.


Add 5.x unsupported info

See https://github.com/Microsoft/tslint-microsoft-contrib/issues/354 for support progress

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

thanks


Loop Time randomly gets set to disabled.

Version: (Alembic Importer 1.0f1)
Unity: 20173.0p1
Every time a project is opened or reloaded the "Loop Time" on the clip gets set to disabled(0) even though it had been set to enabled(1).

https://github.com/unity3d-jp/AlembicImporter/releases/tag/20180205


New tuning values for Lexus CTH

Looks better than before

Please make the PR against 077-clean. Otherwise it looks good


Responsive imagery

Ideas-Not-Requirements

Animated background replaced by low-quality image placeholder (LQIP)
"Blur-up" technique replaces LQIP with hi-res image
img element with sensible srcset values
sizes values should use the GDS's standard breakpoints (in Elements)
Images should lazy load by default (via hooks?). Lazy loading should lean on native APIs like IntersectionObserver.
Allow load-on-demand option for huge/slow-loading images? Thinking specifically of how many users we have that may be on metered or inconsistent connections.

react-ideal-image does some of this out of the box—may serve as good inspiration. Maybe our component just wraps ideal-image's.

#51 more fully fleshes out these requirements.


Next release on maven repository

When will occur the next release to maven repositories? We are expecting to use 'additionalFields' feature to log static fields.

It's already there: http://search.maven.org/#artifactdetails|org.graylog2.log4j2|log4j2-gelf|1.0.2|jar


Update Alicloud SDK to v1.62.138

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

We have a breaking changes for the table alicloud_cas_certificate if we are updating the SDK version to v1.62.138
Raised a support request on SDK side https://github.com/aliyun/alibaba-cloud-sdk-go/issues/583


Fix appraisal in CI

Progression from #1230 - wasn't confident rebasing main so I've made a new branch.
Will be aiming to make sure gem dependencies are cached and that appraisal runs locally.
The caches for each gem bundle are now saved, as hashFiles can target the gemfile.lock filenames. This previously wasn't working because we didn't realize the format expression is necessary to template the Rails version and hash into the string.

Looking good, thanks for wrapping this up! :tada:
While re-reading #1230, I noticed there was one last thing to decide. Do we want to:

merge this as it is (with the dependency on excid3/appraisal fork (see this for background)
wait for https://github.com/thoughtbot/appraisal/pull/174 to be merged
refactor this PR to not use appraisal directly in CI, but setting BUNDLE_GEMFILE via matrix, as suggested here

Happy to hear what you think @joelhawksley @boardfish @BlakeWilliams

I'm leaning towards that first option. I think we should prioritize ensuring that running the tests works the same way in dev as it does in CI. It may be a good idea in the long run to mirror @excid3's fork to @github so we can ensure that version of the code remains publicly available until @excid3's PR is merged.

@joelhawksley would you mind giving us your feedback on this? (See my latest comment above). I think we should try to merge this soon.

FWIW, I've just gone through the fun process of trying to get Lookbook CI working with Appraisal - I took a slightly different approach (and with a smaller matrix of ruby/rails versions for now) but I finally got it working. Just in case it's useful to have an example which uses the matrix approach but doesn't require the Appraisal fork: https://github.com/allmarkedup/lookbook/blob/main/.github/workflows/ci.yml

There is a new PR on Appraisal that could fix the issue and allow us to move forward with this approach.
If it does not, I'll take some time to mirror @allmarkedup's method.

Appraisal maintainer here! 👋
I've just merged that PR mentioned above (https://github.com/thoughtbot/appraisal/pull/202), which I'm hoping can help you out here. In a few days I'll cut a new release.
We'd been a bit stuck with a good solution to that problem, but let us know over there if you're having problems.

Awesome @nickcharlton! I'll try it out next week. Thanks for the heads up!

Awesome @nickcharlton! I'll try it out next week. Thanks for the heads up!

I thought it was time to get this in shape for v3.0.0 :)
Do not forget this after merging: https://github.com/ViewComponent/view_component/pull/1308#discussion_r834585238
Thanks a lot @boardfish for your help on this!

@Spone I'd prefer we wait for the Appraisal release instead of depending on a branch.

@boardfish thoughts on testing this against https://github.com/thoughtbot/appraisal/issues/204#issuecomment-1635841844? Perhaps we don't need to wait for 3.0?

Yeah, that sounds good!

@boardfish cool, would you be up for bringing this PR up to date?

Sure! I can have a crack at that sometime in the next week.

Alright, I think we're just about there. Personal TODO list of stuff I've recognized that's still left to do on this one:

[ ] Check that the CC patch is still actually applied
[ ] Figure out why simplecov's suggesting that test_helpers.rb isn't covered
[ ] followup: see if we can use built-in bundler caching for other test runs instead of manually calling actions/cache to remove that layer of complexity from these workflows

Ugh sorry @boardfish, could you fix these merge conflicts? I'm not sure how to resolve the difference in the Gemfile 😓

@joelhawksley Looks like we do still get coverage-related failures without those nocov comments. Not sure why, though – maybe there's a discrepancy in the running environment between the runs on main vs. on this branch.

@boardfish I'm happy to merge and revisit given the complexity of this PR.

Awesome. I'll get rid of those merge conflicts and merge this in myself later, then 👍


C++/WinRt does not give a useful error message when I try to implement an exclusive interface not defined by my component

I'm porting some code that implements ::ABI::Windows::ApplicationModel::Core::ICoreApplicationView:
#include "pch.h"

#include <winrt/Windows.ApplicationModel.Core.h>
#include <winrt/Windows.UI.Core.h>

using namespace winrt;
using namespace winrt::Windows::ApplicationModel::Activation;
using namespace winrt::Windows::ApplicationModel::Core;
using namespace winrt::Windows::Foundation;
using namespace winrt::Windows::UI::Core;

struct NullApplicationView
    : implements<NullApplicationView, ICoreApplicationView>
{
    event<EventHandler<IActivatedEventArgs>> m_activatedEvent;

    event_token Activated(EventHandler<IActivatedEventArgs> const& handler)
    {
        return m_activatedEvent.add(handler);
    }

    void Activated(event_token const& token)
    {
        m_activatedEvent.remove(token);
    }

    CoreWindow CoreWindow()
    {
        return nullptr;
    }

    int32_t IsMain()
    {
        return false;
    }

    int32_t IsHosted()
    {
        return false;
    }
};

Attempting to do this in C++/WinRT on a brand new 'Windows Runtime Component (C++/WinRT)” project failed with a cryptic error:
error C2079: 'winrt::impl::producer<D,winrt::Windows::ApplicationModel::Core::ICoreApplicationView,void>::vtable' uses undefined struct 'winrt::impl::produce<D,I>'
        with
        [
            D=NullApplicationView
        ]

Turns out the issue here is that ICoreApplicationView is an exclusive interface. According to its definition, it may only be implemented by the CoreApplicationView class and hence I'm getting this error.
This is partly because, the default C++/WinRT project template has WINRT_LEAN_AND_MEAN  defined (in the vcxproj), which removes the ability to implement interfaces that are exclusive to a class not from the library.
I had to remove this this WINRT_LEAN_AND_MEAN to get it compiling, but it sure would have been great if the original error message was telling me more explicitly that implementing an exclusive interface was the issue.

Unfortunately, convincing the C++ compiler to produce useful error messages is a hard problem. We have actually spent a lot of engineering time on this. Believe it or not, it's a lot better than it used to be. 😊
In earlier versions, many of these errors were linker errors that often didn't even mention the undefined type or the originating line of application code that attempted to instantiate said type. Short of improvements to the C++ language, there isn't much we can do about this right now.

Implementing exclusive interfaces is important when creating test mocks. So WINRT_LEAN_AND_MEAN must not be used in this case. Ideally this would be in the official docs but in the mean time this issue serves that purpose.


How can i use this library to make a call and run an audio file on it

Hello, I would like to play an audio file on a initialized call via java. I haven't found an example for this.
Is this possible?

I sent this to the users mailing list


DOM Tree inside  if URL ends with ".txt"

Prerequisites

[X] Can you reproduce the problem in a MWE?
[X] Are you running the latest version of AngleSharp?
[X] Did you check the FAQs to see if that helps you?
[X] Are you reporting to the correct repository? (there are multiple AngleSharp libraries, e.g., AngleSharp.Css for CSS support)
[X] Did you perform a search in the issues?

Description
When parsing a string of HTML using a virtual request, AngleSharp returns a DOM tree where the HTML is HTML encoded and placed inside a
 if the URL used in the Address() method ends with a ".txt". It's like a pretty print special mode for a text file.
Despite the URL ending in ".txt" the supplied HTML string really is HTML. Perhaps "special output for .txt files" is a specific feature. However:

It's not obvious that this is what will happen. I can't find any mention in the docs about this behavior, searching for "txt" or "text file"
Plenty of URLs exist in the wild where what .NET URI class thinks of as a filename or file extension is ".txt" when the content is not a .txt
I cannot figure out how to disable this if it is a purposeful feature.

Steps to Reproduce
The run the snippet of code below. The URL ends with .html and the output is correct.
var context = BrowsingContext.New(Configuration.Default);
var parser = context.GetService<IHtmlParser>();

string url = "https://www.example.com/foo.html";
string html = "
this is a test
";

IDocument document = context.OpenAsync(req => req.Address(url).Content(html)).Result;
Console.WriteLine(document.DocumentElement.OuterHtml);

Prints:

this is a test

Where as this URL has a .txt ending, and the output of AngleSharp is some kind of pretty-print formatting for a text file.
url = "https://www.example.com/foo.html.txt";
document = context.OpenAsync(req => req.Address(url).Content(html)).Result;
Console.WriteLine(document.DocumentElement.OuterHtml);

Prints

<h1>this is a test</h1>

Expected Behavior
If I pass in an HTML string, AngleSharp should parse that into a DOM tree, regardless of the file name/ extension of the URL for that HTML string.
More specifically, output from both Console.WriteLine() calls should be "this is a test"
Actual Behavior
Output for URLs ending in .txt is an odd, incorrect DOM representation of HTML string:

<h1>this is a test</h1>

Possible Solution / Known Workarounds
I could possibly not use the Address() method in the virtual request. However that means I could not use anchor.HyperReference(anchor.Href) to get absolute URLs for resources as I'm walking the DOM

It is a purposeful feature - and actually it is not determined by the extension, but rather what the webserver says the content is.
	var context = BrowsingContext.New();
	var url = "https://www.example.com/foo.html.txt";
	var html = "
Hello!
";
	var document = context.OpenAsync(req => req.Address(url).Content(html)).Result;
	Console.WriteLine(document.DocumentElement.OuterHtml);

This results in:

<p>Hello!</p>

Let's add the appropriate Content-Type header, which determines the content type:
var context = BrowsingContext.New();
var url = "https://www.example.com/foo.html.txt";
var html = "
Hello!
";
var document = context.OpenAsync(req => req.Address(url).Header("Content-Type", "text/html").Content(html)).Result;
Console.WriteLine(document.DocumentElement.OuterHtml);

The result is:

Hello!

The behavior matches the one found in browsers, which also look up the mime type from the extension if no explicit content-type is given from the webserver.
Hope that helps!


[metricbeat] kube-state-metrics incompatible with k8s v1.22

Chart version:
7.16.3
Kubernetes version:
1.22
Kubernetes provider: E.g. GKE (Google Kubernetes Engine)
K3s on Hetzner Cloud
Describe the bug:
The dependency kube-state-metrics isn't compatible with k8s v1.22 because it is using depricated and now removed apis = rbac.authorization.k8s.io/v1beta1 ClusterRole
Steps to reproduce:

Install a k8s cluster with v1.22
Try to install this helm chart

Expected behavior:
Deploys without any issues
Any additional context:
the repository https://charts.helm.sh/stable that you are using for kube-state-metrics is depricated and has been moved for this particular helm chart to https://github.com/prometheus-community/helm-charts/tree/main/charts/kube-state-metrics
See issue https://github.com/kubernetes/kube-state-metrics/issues/1153 and https://github.com/helm/charts#deprecation-timeline for more information.

There already a PR #1524


popup windows sizing

I am trying to set the windows size for some videos that I am showing but for some reason the popupwidth or popup height doesn't seem to be doing anything.  Also I am was trying to remove the white space where the caption is but the popupcaptionheight doesn't seem to be doing anything either.  Is there another place or something that I need to set the size of this window?

Not sure if this is still an issue, but if it is please reopen it!


[WIP] Add profiling data state and ability to force re-execute graph

@mjkkirschner This is ready for review, whenever you have a chance. I've removed the node execution event columns for now. If we want to, we can add these back later with the ability to turn them on and off.

@scottmitchell it looks good, except some of the testing setup would be good to be automated ... I know that core runtime is not on nuget currently, but you can even pull it from s3 with a prebuild task:
https://docs.microsoft.com/en-us/visualstudio/msbuild/downloadfile-task?view=vs-2019

I've filed this:
https://github.com/DynamoDS/TuneUp/issues/18
if you'd rather handle it separately.

@scottmitchell just two small changes please.

@scottmitchell LGTM


Resolution of training image

@taconite My doubt was that I was training on a custom dataset with similar setting as ZJU-MOCAP. However I observed that the images were cropped and in the top left corner and then passed for training as shown here. Is there any reason for such a design decision

when it should be something like this:

Not sure how you modified the dataloader, at least on ZJU-MoCap I have tried both original resolution (1024x1024) and half resolution (512x512) and it does not produce what you described here.
I updated the dataloader so that the preprocessing logic is much simpler, maybe you can try building your custom dataset on top of the new dataloader and see if the problem persists?


Translation is working but RPG-Maker-Translator keeps crashing when repackaging

With @Tranquwil 's solution here, I managed to fully translate the game scripts.
The JSON files inside the folder DataExtracted are translated.

However the RPG-Maker-Translator app keeps crashing after the translation finished. The game is still fully on Japanese, since the translation still only on the json files. Any idea why?

The GUI keeps crashing, but translating from command line is works great. Closing the issue.


Promote integration-service from staging to production

Included PRs:

https://github.com/redhat-appstudio/integration-service/pull/648
https://github.com/redhat-appstudio/integration-service/pull/643
https://github.com/redhat-appstudio/integration-service/pull/640
https://github.com/redhat-appstudio/integration-service/pull/629
https://github.com/redhat-appstudio/integration-service/pull/645
https://github.com/redhat-appstudio/integration-service/pull/647
https://github.com/redhat-appstudio/integration-service/pull/646
https://github.com/redhat-appstudio/integration-service/pull/644

/lgtm
/approve


improving lua script usage

evalsha wasn't formatted correctly so this is fixed.
also set it up so any missing scripts are loaded into redis then run with evalsha again rather than just executed with the raw script, so there's a slight first time cost to any new script.

Thanks!


Why are the HTML elements abstract classes in v0.10.0?

I was using the pre v0.10.0 system to create a basic server-side implementation of the DOM api, which worked great for my usecase.
But now that all the actual elements (HTMLElement, HTMLAnchorElement, ...) are abstract classes, what was a pretty straightforward implementation now requires me to duplicate a ton of code because I have to extend each element class individually.

The reason for this transition is that initially JSO did not give any difference between interfaces and (abstract) classes. Since 0.10.0 JSO treats classes as concrete classes, can check them with instanceof and even instantiate them. I thought it may be useful in some cases to have the ability to make instanceof against elements without the need to write additional  @JSBody methods.

what was a pretty straightforward implementation now requires me to duplicate a ton of code because I have to extend each element class individually.

JSO interfaces for DOM were never supposed to be implemented by user code, so you shouldn't have used them that way. I strongly suggest to stop doing this and write your own abstractions (which are implemented over some DOM parser on server side and over JSO DOM wrappers on client side). Anyway, if you don't want to do it, you can use Javassist ProxyFactory to create proxies for abstract classes.

@konsoletyper
Hmm, writing another implementation wrapper over the JSO DOM & whatever server-side DOM doesn't seem appealing to me. It's one thing to do this on the server, but I for sure don't want to include a lot of this boilerplate code in the compiled JavaScript file. That seems like a huge step back to how I've currently got it working.
Is it never allowed to interact with/extend the JSO DOM classes then?
Because that is kind of a requirement to making custom elements work: Custom elements extend HTMLElement in JavaScript too. This actually already works perfectly well with TeaVM.
I will take a look at the ProxyFactory idea though.


Group window tabs (like Groupy 2)

Description of the new feature / enhancement
Option to group all types window like Groupy 2 app
Scenario when this would be used?
every time
Supporting information
No response

/dup #10


Syntax Highlight compilation errors

Code frame of babel compilation errors includes ansi colors, so we'd like to add syntax highlight instead of just stripping it.
We can use https://www.npmjs.com/package/ansi-html

Should be fairly simple. I can take a swing at it.

As #195 was reverted, I think, this issue should be reopened.


style: Make continue button easier to click

This PR makes the clickable area for the continue button a little larger and fixes the mis-positioned "target" element due to the missing position: relative; on the parent.
Before, only the triangle of the play button was clickable.
Now, a square area with ~5px paddings around the button is clickable.
This doesn't interfere with the tags or billable icons that appear nearby.

Is there anything I should do to get this reviewed?


Upgrade to CRS v4.4.0

Hello,
With the recent release of CRS v 4.4.0, I'm considering upgrading.
As a newcomer to Coraza, I have a couple of questions:

Build Process: When using load_owasp_crs in the Caddyfile, is it necessary to rebuild Caddy each time?

Version Update: Should the Coraza version be updated simultaneously in the go.mod file? Currently, it's set to:

https://github.com/corazawaf/coraza-caddy/blob/58105a779bc45b80228b2466b6f24c12625e00a2/go.mod#L7

Any guidance on these matters would be greatly appreciated. Thank you for your time and assistance.

Seems like the developer never gonna update to latest available version, now or in the future!

Hey @vcarus!

Build Process: When using load_owasp_crs in the Caddyfile, is it necessary to rebuild Caddy each time?

load_owasp_crs will load the CRS version based on what you have in your go.mod file. So I would say that the rebuild is needed to embed the updated rules. That being said, load_owasp_crs is just a handy way for straightforward setups, nothing stops you from using the Include directive to load rules from your filesystem (E.g. you directly download the rules from https://github.com/coreruleset/coreruleset and you point them). If you wish to stick with the load_owasp_crs way, I just opened the PR to ship CRS v4.4: https://github.com/corazawaf/coraza-coreruleset/pull/24

Version Update: Should the Coraza version be updated simultaneously in the go.mod file? Currently, it's set to:

The link is pointing to coraza-coreruleset, which is this repository. It is correct, as mentioned above, to update to a specific version of the CRS relying on this library you have to update this dependency.
Coraza version is the engine version and is the line below (E.g. github.com/corazawaf/coraza/v3 v3.1.0). We are currently at v3.2.1, it has been updated in master` last week via https://github.com/corazawaf/coraza-caddy/pull/159.
Cheers

Thanks for opening this, I see this coming more often so probably we need a way to let users pass their own CRS. In the meantime you can load them from your FS.

FYI both CRS v4.4.0 and v4.5.0 versions have been tagged and released.


[extractor/GoogleDrive] Add more supported types

[extractor/GoogleDrive] Add more supported types
We import those from the Youtube extractor, and also add:
'50':'mp3',

for mp3 files scrapping.
Fixes #8281
Template
Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8 and ran relevant tests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

[ ] I am the original author of this code and I am willing to release it under Unlicense
[x] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[x] Fix or improvement to an extractor (Make sure to add/update tests)
[ ] New extractor (Piracy websites will not be accepted)
[ ] Core bug fix/improvement
[ ] New feature (It is strongly recommended to open an issue first)

also in the future please do not force push, all commits will be squashed upon merge

also in the future please do not force push, all commits will be squashed upon merge

Had to force some, wrong identity as I am not on my laptop.

Ok I have trouble matching the md5sum:
-f 50         e94c9cbb9cf9c9724f71ce53141d5a2f
-f source fc6291214bab683b9e6126c5933d91bf == md5 of original file.
However:
test/test_download.py:252: in test_template
    self.assertEqual(tc['md5'], md5_for_file)
E   AssertionError: 'e94c9cbb9cf9c9724f71ce53141d5a2f' != '322db8d63dd19788c04050a4bba67073'
E   - e94c9cbb9cf9c9724f71ce53141d5a2f
E   + 322db8d63dd19788c04050a4bba67073

use the value that the test script gives you. It is only hashing the first 10B of the file

Ok we're clear, the test passes.

please stop force pushing, you vaporized my changes
also, when I download format 50 and ffprobe it, it says it is m4a/aac

Hmmm indeed:
Input #0, mov,mp4,m4a,3gp,3g2,mj2, from 'My Buddy - Henry Burr - Gus Kahn - Walter Donaldson.mp3 [1IP0o8dHcQrIHGgVyp0Ofvx2cGfLzyO1x].mp3':
  Metadata:
    major_brand     : M4A
    minor_version   : 0
    compatible_brands: isommp42
    encoder         : Google
  Duration: 00:03:04.69, start: 0.000000, bitrate: 129 kb/s
  Stream #0:0[0x1](und): Audio: aac (LC) (mp4a / 0x6134706D), 44100 Hz, stereo, fltp, 127 kb/s (default)
    Metadata:
      handler_name    : ISO Media file produced by Google Inc.
      vendor_id       : [0][0][0][0]

So the source file is mp3, Google converts it in m4a, well sorry about that. Curious that some files work an others don't though.

I don't think google/youtube encodes anything in mp3


Improve RegistrationInformation

Update field retrieved
Generate TTL and expiration
Implement auto removal of expired TDs

TTL has been moved from mandatory features, thus this issue is closed