Core: Fix BitMap RDP algorithm

RDP algorithm has been fixed.
Perpendicular distance now returns the distance from the line segment.
Self intersection case has been handled.
Fixes #69725

I'll take a look as soon as I'm able, really excited to see a potential fix to this!

Will do some testing with the MRP I made for a previous bug involving this, very useful for these purposes, uploading here for new use:
BitPR2.zip

It seems the assumption that the intersecting segment must always be at the end is not valid, it fails with cases like this one:

Thanks for pointing that out. I am going to continue working on implementing the star RDP algorithm then.

Having worked on trying to make it work myself I know it's a challenging task, might be worth it to split this into two PRs, one doing the basic fixes to the behavior and one to try and fix the self-intersections

I agree. I also believe the ending self-intersection check should be kept as it covers the edge cases from #69752. I'll do another pull request when the star RDP is done.

Do you mean #69725?

yeah

I finally finished the star RDP and am including it in this pull request. AFAIK it handles all self-intersection cases.

While investigative why the check failed I stumbled upon a bug within the algorithm implementation. While I fixed it, I still need to do more testing.

This is something to do extensive testing on indeed, and a big question is how to approach performance, and we need to measure the performance here and weigh the benefits and drawbacks
Not familiar with this specific algorithm and haven't studied the code but it should be at least O(N log N) compared with the standard RDP of O(N), but it should at least avoid the more expensive brute force check cost of O(N^2)
But that'd be a matter of performance testing on complex cases like large images to confirm that it is indeed not very slow

Sorry for the slow update, I haven't had much time to work on this last week. The bug has been fixed, but I am unsure about how to go about making the star RDP optional. If I add a bool, it will force me to always add the default epsilon value every time I call the function and want to use the flag.
EX(From Resource importer): bit_map->clip_opaque_to_polygons(Rect2(Vector2(), image->get_size()), 2.0, true);
If this is fine I will go ahead and update the code with it.
Also for use in the sprite2d editor, should it just be a toggle button to enable it?

What is the harm of leaving star RDP on for all cases?

The cost, but that would depend on performance measurements as mentioned above

Rebased and the GD extension compatibility function.

Will take a deeper look at this during the week if I'm able

Didn't get the time to look at this this week, will try in the next few days

Been busy but will try to get a look at this in the next few days

Can confirm that this handles at least a lot of cases the non-star algorithm handles, however it does scale much worse, as expected, didn't do rigorous benchmarking but with even relatively trivial input this takes at least twice as long, and for even relatively small input it can take as much as 5 times as long
A new test project to use:

Escape clears
Space performs the generation
Q toggles between star and non-star (defaults to non-star)
BitPR3.zip

And see console output for the time in microseconds per run, and notice how it scales
Will go over the code more in detail but as far as I can tell this does solve the problem, but the question is how it scales, but it being optional is IMO pretty necessary given the performance concerns
Would be good to test with large and complex texture import like in:

https://github.com/godotengine/godot/issues/68350

By copying one of the images and using it for the polygon editor for example, but haven't benchmarked that at the moment

I just profiled my code and I found that my get_star_region function is actually n^2 and is the biggest factor in calculation time. I should be able to quickly implement the triangle visibility polygon algorithm from https://arxiv.org/pdf/1403.3905  to fix this( It's performance will be dependent off of Godot's triangulation algorithm, so around n log n ).
Other than that, I will make it optional for the Atlas Texture generation too. I hope to finish the fix by Sunday.

Did you implement the new algorithm yet? Tested out the current code but it still seems orders of magnitude slower than the non-star algorithm

Sorry, I was out of commission due to a hurricane. I was able to finish implementing the new algorithm, but the performance is heavily dependent on the amount of star-regions needed( basically a lot of spikes is the worst case O(mn)).

Will test the new changes when I can! Stay safe!

Will try to test this today or tomorrow

The performance drop remains but I will go over the code and see if there are any areas of improvements, and will do some general code review as well
But as this appears to generally work, and the cost is performance loss, I think it's worth it, but I will try and identify possible areas where it can still be improved, will try to go over this this week if I can

Guys! Wonder why you started looking for star RDP solution, the fix with miss indexing solves the issue pretty much for me, haven't found any case where it has intersections, am I missing something?

According to wiki, it states that middle element should be added to both parts and them removed:

As hard as I tried to test it, it fixes all intersections I had

Are you sure that's correct with 0 indexing? The example code uses 1 indexing
I will investigate some thought

When the point list is seperated into $r1$ and $r2$, the middle point( $p_m$ ) is placed in both list: $r1 = [p_0,...,p_m]$ and $r2 = [p_m,...,p_k]$. When the two list are reattached the middle point is is kept, with the extra middle point removed: $resultList = r1 \cup r2 = [p_0,...,p_m,...,p_k]$.
Self intersection errors start becoming a problem when you have a complex  shape and a high optimization value.

Can you give any examples for correct algorithm, where it could happen, because for me most cases are solved by fix above

Looking at it yes the current algorithm has a bug in that it misses that part of the simplification, but this is not what is causing the self-intersections, the RDP algorithm does not prevent self-intersections regardless how it is implemented, but fixing that would be good as well


Rename drone build to drone pipeline ?

The drone build command previously made sense because we had a build section in the yaml. The project has evolved and we have removed the build section and replaced with the pipeline section. Individuals with historical knowledge of the project understand what build means, but newer users are sometimes confused.
I would therefore propose changing from drone build <command> to drone pipeline <command>

No, build is fine. Pipeline is too generic.
It gives the easy understanding difference between build and deploy.
If you let me run drone pipeline and drone deploy, I will be very confused.

I think keeping terminology consistent is more important here, so if the build in the cli is changed to something, then the UI should be updated as well.
To refer to each run of the pipeline, I prefer drone job > drone pipeline > drone build.

Not all runs are builds.
pipeline is more of a "configuration" terminology; each run of the pipeline isn't a "pipe", it's a job or task in the pipeline, and since task is already used to refer to the steps in one run, job seems appropriate.

I like what @tonglil is saying. pipeline is an improvement over build, but that could be more awkward than just calling these higher level units of work jobs, matching terminology for many other CI systems.

I think pipeline may describe the nature of our current build/job.
In the future, maybe we have additional types that aren't pipey but are more fan-outy or who knows what.
If we're serious about supporting other CI systems declarative manifests, we may want to go with the more widely used term.

So maybe sideways thumb on the issue above?


Bugfix: fix few typos in houdini's and Maya's Ayon settings

Changelog Description
Fixing few typos

[x] Maya unreal static mesh
[x] Houdini static mesh
[x] Houdini collect asset handles

Testing notes:

create and publish a maya static mesh
create and publish a houdini static mesh
publish in houdini with and without asset handles

I like how you're fixing typos and the branch names contains aayon hehe.


Removing audio feedback loop from speech synthesis.

Does the Azure Speech SDK have any builtin way to remove speech synthesis from text-to-speech being fed back in and producing speech-to-text results in a use case where both are running at the same time?

Hi @aaronn - thanks for using the SDK.
Echo cancellation is supported using the Microsoft Audio Stack (MAS), you can read more about it here and on this usage article.

Closing as answered, please reach out again with any further issues.


Spike: How to display Digital Reveal Cookie management message in Modal video

Get the correct requirements for ticket #310 and find the correct approach.
We want to know if there is a possibility to display a youtube livestream without having to accept any cookies.

Blocks #310


Add STOPSIGNAL to Dockerfile

This documents that pgcat expects SIGINT for graceful shutdown. Kubernetes in particular sends a SIGTERM by default but will respect this flag and send a SIGINT if requested.

Thank you @levkk. Would it be possible to publish a new image? The last one seems to be several months old.

No worries. The CI for the image right now is broken, I think we just need to upgrade the Rust compiler version. A PR is welcome.


[theming] customize file icons in settings

VSCode Version: all
OS Version: all

Can't there be a quick way to customize file extension icon instead of having to create a whole extension for a custom theme as explained here https://github.com/Microsoft/vscode/issues/10804?
It's really daunting to have to learn the whole system of extension just for this tiny need.

Does this issue occur when all extensions are disabled?: Yes/No

Can you tell more your use case? Do you don't like some of the icons, or you have some missing icons? That would be https://github.com/Microsoft/vscode/issues/14662

I'll put my use case here. I really like the seti-ui file icon theme, but I want folders to have just the plain folder icon. Right now they have no icon. I most definitely don't want to get into the business of maintaining an extension just for file-icon theme because I don't want to spend the time and resources required to stay up to date with the upstream theme and vscode api changes. I am willing to see my personal settings break because the workaround is remove my custom settings. I am not willing to have to go through the process of publishing a new version then downloading the new version of the plugin just to add folder icons to a theme that does not have folder icons.

This would help for an internal system we have which uses YAML files with specified names.
We would like to be able to set the icon to use for the .thing.yml files we use (like the fileNames part of an iconTheme vscode extension, not just by file type).

Being able to upload a certain icon (of your design or something found) and assign it to a certain file extension would be nice as well. Use case here is, for some projects I am on I use the confluence extension on the market. Would be nice to set my own custom icon for files with those extensions so they aren't just the default 'txt' icon.

I just want my Procfile.dev file to have the same icon as Procfile. Is this currently possible?

@Hubro I believe you can do this in your user settings with the files.associations, something like this:

@ksmithut I have actually associated "Procfile*" with YAML, which affects the syntax highlighting of both Procfile and Procfile.dev, but only the latter gets the YAML icon:

Procfile still has the Heroku icon.

I completely agree with @Hubro and @eponymz for this feature. For example, there is a .leex extension introduced few months ago for Phoenix web framework. I'd like to set for it the same icon that my theme uses for .eex extension, until it gets officially supported by theme(s). Imo it would be so nice to have this configurable in the settings.json.

I use the Tailwind CSS IntelliSense extension and when I enable the "Tailwind CSS" mode for css files some themes don't show the css icon for those files. This feature would allow me to force it back to the regular css icon.

Our use case is being able to map a file extension we are using for TypeScript test files to the orange TS icon within Seti. We're using .e2e-spec.ts as the file extension. It would be nice to be able to extend the existing theme via settings. For now though I think we will just rename the files.


How to create annotations for a SSD classifier

Hi,
I am pretty new with DIGITS. In fact just started using it after the GTC2018 last week.
I am trying to train my own DetectNet to find text in a scene (more specific letters and numbers).
I went through the lab "Object Detection with Digits", however I have no clue on how to create the "annotations" for the data set. Could anyone kindly point me in the right direction?
Thank you very much.

You need a manual image annotation/labeling tool. See below for an example;
https://alpslabel.wordpress.com/
More tools can be found in here;
https://en.m.wikipedia.org/wiki/List_of_Manual_Image_Annotation_Tools


performance factors

I wonder what are the factors that plays role in performance
In terms of  no of frames, resolution, bit rate and latency .
why does FHD resolution has more latency than 800? is it the cpu on mobile or desktop or its limited due to adb speed?

It takes a bit more time to encode/decode a big video than a small one. And the bandwidth is also not the same (more data to transmit, to parse, etc).
So in practice, when mirroring in 1920×1080, the latency is about twice as high as when mirroring in 800×448: #646.

Why does it take 2x more time to transmit FHD frame compared to 800?
Is it the CPU , GPU or code?

I think the main latency increase is the encoder (on the device) and the hardware decoder (on the computer).

How can we improve the encoder and decoder performance?

Your encoder and decoder are probably hardware components (independent of CPU) dedicated to H.264 encoding/decoding.
The only possible ways to decrease latency is to decrease encoding complexity, by changing encoding parameters.
The most obvious are width and height, but you could play with others, especially profile/level. You could custom these options using scrcpy --codec-options .... See Advanced codec options in v1.14 highlights.

If it's independent of CPU and GPU the scrcpy struggles to maintain 60fps when there is a 3d application running on the device.
Also why does scrcpy is capped at 60fps? Why can't it go beyond 60 FPS?
Does usb 3.1  port on mobile improve performance compared to usb 2.0?

the scrcpy struggles to maintain 60fps when there is a 3d application running on the device.

The encoding is done on the device side. One frame is sent every time the surface changes, no more. So if you run an app that renders at 60 fps, you'll get 60 fps. If you play a 25 fps video, you'll get 25 fps.
If you don't get more than 60 fps, the device does not render more than 60 frames per second (many devices displays are limited to 60Hz).
https://github.com/Genymobile/scrcpy/issues/1524#issuecomment-646494736

Does usb 3.1 port on mobile improve performance compared to usb 2.0?

No, the bandwidth of USB 2.0 is enough to transmit the video stream, it should not change anything.

Thank you once again.
One final question , what can I do if I wanna achieve low latency without reducing resolution. Does high end chipset like sd865 helps?

Does high end chipset like sd865 helps?

High end chipsets are probably better (but they are "more" better on low definition).

what can I do if I wanna achieve low latency without reducing resolution?

Did you try changing the profile/level? https://github.com/Genymobile/scrcpy/issues/1537#issuecomment-647964867

@rom1v @flyingduck234
i think is a cpu performance no enough, not the usb2.0 cable bandwidth problem,. see my issue
https://github.com/Genymobile/scrcpy/issues/1553

under right circumstances scrcpy can achieve very low latency.
A high end chipset
A good computer
Try lowering resolution
You should be seeing low latecy


dpebot dependency updates + test fixes.

Also add "sponge_log" to end of failsafe error reports so they show up in fusion.

Updating the apache beam version causes this error in the spanner tests:
Tests run: 4, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 19.525 sec <<< FAILURE! - in com.example.dataflow.SpannerReadIT
readDbEndToEnd(com.example.dataflow.SpannerReadIT)  Time elapsed: 5.692 sec  <<< ERROR!
org.apache.beam.sdk.Pipeline$PipelineExecutionException: com.google.cloud.spanner.SpannerException: INVALID_ARGUMENT: io.grpc.StatusRuntimeException: INVALID_ARGUMENT: Query is not root partitionable since it does not have a DistributedUnion at the root. Please run EXPLAIN for query plan details.
	at com.example.dataflow.SpannerReadIT.readDbEndToEnd(SpannerReadIT.java:140)
Caused by: com.google.cloud.spanner.SpannerException: INVALID_ARGUMENT: io.grpc.StatusRuntimeException: INVALID_ARGUMENT: Query is not root partitionable since it does not have a DistributedUnion at the root. Please run EXPLAIN for query plan details.
Caused by: java.util.concurrent.ExecutionException: io.grpc.StatusRuntimeException: INVALID_ARGUMENT: Query is not root partitionable since it does not have a DistributedUnion at the root. Please run EXPLAIN for query plan details.
Caused by: io.grpc.StatusRuntimeException: INVALID_ARGUMENT: Query is not root partitionable since it does not have a DistributedUnion at the root. Please run EXPLAIN for query plan details.

I can't find much information about how to ensure the code in [SpannerReadAll.java](dataflow/spanner-io/src/main/java/com/example/dataflow/SpannerReadAll.java) has a Distributed union at the root. When I try to mimic the Sql version of that in the console, it passes just fine. Is this a bug I should file with the spanner team, or should I revert the apache beam version?

You might wish to make sure that beam is using <provided> for the spanner library, rather than including it themselves.  You might need to put in a <excludes> and the earlier version of the spanner client.  This doesn't mean that it's a drop in replacement, as our client library team has been know to change stuff.

I have still not gotten spanner tests to pass, but since Vision is working I would like to submit that part so that test starts passing, and then continue to work on the spanner part.


Switching locale doesn't update field UI based on certain access

Link to reproduction
https://github.com/chrisvanmook/payload/commit/c0be6a12eb7bc17b906f88832253e9d28c0a1fe6
Payload Version
3.0.0-beta.60
Node Version
v20.11.1
Next.js Version
15.0.0-canary.58
Describe the Bug
When switching locale, and you have an access method (update) that should disable the field based on a language, it doesn't update the UI. Only after a full refresh the expected result is visible (see video).
https://github.com/user-attachments/assets/ed029167-fc44-4016-933e-e93af0486475
Reproduction Steps

Add code in reproduction url
Switch from english to NL
Note that the field is not disabled
Refresh
Note that the field is now disabled as it should

Adapters and Plugins
db-postgres

This will be fixed in the next beta release!


LinkedIn Learning 3 months free NOT ACTIVATING!!!

I am trying to activate my LinkedIn Learning three months free trial but link isn’t working and it says ‘We are out of codes, Please try later'

@evanwindom FYI

@davenisarg Thanks for reaching out.  We're aware of the issue and are working on a resolution.  Please do not make additional attempts to retrieve the code as this may cause further errors.  I will post here once the issue is resolved.
Thank you for your patience.

@evanwindom Sorry I closed it by mistake. May I know whether it is solved or not?

Hello @evanwindom and @TerryGLee,
I am still getting this error,
"Oops! We've temporarily run out. Please try again later."

LinkedIn is no longer offering the 3-month Premium benefit through Visual Studio Dev Essentials.  A one-month free trial is available at https://www.linkedin.com/learning/me.

@evanwindom Thanks for providing us with the status of the LinkedIn Learning benefit. We are closing this issue now.


cargo install does not respect .cargo/config.toml

Problem
When I run cargo install ripgrep in a directory with a .cargo/config.toml overriding the install root (like below), it installs to $HOME/.cargo/bin instead.
The interesting thing is that cargo uninstall reads the configured root correctly, so if I immediately run cargo uninstall ripgrep in the same directory, it complains that package ID specification ripgrep did not match any packages.
Contents of .cargo/config.toml:
[install]
root = "./apps"

Steps

Create a config file like the one above.
Make an apps directory
Run cargo install ripgrep (or anything)

Possible Solution(s)
No response
Notes
Also tried nightly just now with the same result.
Obviously I can just cargo install --root apps ..., but I was trying to experiment with patching dependencies and building with different compile options and it seems cargo install is completely ignoring the configuration file.
Version
cargo 1.67.0 (8ecd4f20a 2023-01-10)
release: 1.67.0
commit-hash: 8ecd4f20a9efb626975ac18a016d480dc7183d9b
commit-date: 2023-01-10
host: x86_64-pc-windows-msvc
libgit2: 1.5.0 (sys:0.16.0 vendored)
libcurl: 7.86.0-DEV (sys:0.4.59+curl-7.86.0 vendored ssl:Schannel)
os: Windows 10.0.22621 (Windows 10 Pro) [64-bit]

Thanks for the report! It is intentional behavior that cargo install <registry-package> does not honor the configuration in the current working directory. I think there are two issues here:

That does not seem to be documented in the cargo install page.
cargo uninstall should probably have similar behavior to avoid the asymmetry.

For the installation root precedence, the rule is not documented at all. It starts searching configurations upward from the given --path, or CARGO_HOME if no --path provided. This should probably be documented as well.
https://github.com/rust-lang/cargo/blob/efd37336e94e2f98260ad28d89e509e02fe4a556/src/bin/cargo/commands/install.rs#L89-L95
I wonder if we could reconsider calling set_search_stop_path(home), though it is definitely a breaking change, so 🤷🏾♂.

That does not seem to be documented in the cargo install page.

Any reason why cargo install ignores the configuration in the current directory? It would probably be a good idea to add the reason behind this decision to the documentation.
@rustbot claim

@jofas
See https://github.com/rust-lang/cargo/pull/6026. The basic idea here is cargo install is a system or user level command instead of project-local. For --path https://github.com/rust-lang/cargo/pull/6804 tells that it makes sense --path respecting project local configurations.

Thanks for the explanation!

I think in order to document the fact that  cargo install (and in the future cargo uninstall) only consider the global configuration file in $CARGO_HOME/config.toml, I'd like to add a small note here:
https://github.com/rust-lang/cargo/blob/426263643a17692504ad3dc7d627556850c7f1ce/src/doc/man/includes/description-install-root.md?plain=1#L5
Something along the lines of

Note: only the global configuration file $CARGO_HOME/config.toml is considered

As the snippet is only used for the man pages of install and uninstall (and both will have the same behaviour), I think this should be okay?
Somwhere here on the cargo install man page :
https://github.com/rust-lang/cargo/blob/426263643a17692504ad3dc7d627556850c7f1ce/src/doc/man/cargo-install.md?plain=1#L48-L50
I'd add a note saying that using --path will change the default behaviour of cargo install to only consider the configuration in $CARGO_HOME/config.toml to the configuration at the given path.
Any thoughts anyone? @weihanglo?

I am fine with your suggestion, though it's a bit complicated. Not only install.root is ignored but the entire configuration discovery starts from $CARGO_HOME/config.toml instead of current working directory. I am not sure if it is worth putting so much concepts here. The suggested fix of --path looks good but falls into the same situation as well.
In terms of the display on manpage, I only found one quote usage in man in cargo bench. It looks good to me btw via cargo help bench (the bad part is due to link rendering). If you don't feel satisfied with the way it displays, we can also fall back to starting with plain Note that….

I am not sure if it is worth putting so much concepts here.

That was my reservation, too. I just couldn't figure out a good spot where I could add the relevant information in the text on first glance. I'll figure something out and create a PR where we can discuss further details.


ImageMath subtract question, background

version 2.6.5 dev
Use case: trying to see "the pure hydrogen epsilon", without the "blue-metal-continuum" that dominates the region (and culminates in the two calcium lines, among others, and gives us the active regions). In JSol'Ex, using custom lines generation and image editing software, and ImageMath. Experimenting in an image editor (expected result) and in ImageMath (surprising result)
Expecting: a fairly dark image. As obtained from disk_25 - disk_18, then curved, in image editing software (negative values are clipped to zero).

Observing: an unexpectedly grey image, much like the helium output.
Questions:

overflow? Autostretch?
If A-B would result in a negative value, then positive-offsetting A until no negative number results?
Why is the Helium image, which is almost by definition brighter than the synthetic continuum around it, get a bright background?

Thank you.

That's correct, JSol'Ex performs normalization so that all values are >= 0 by offsetting.


Allow builders to be used inside slices

fixes https://github.com/MaikKlein/ash/issues/223
Quick and dirty implementation for builders inside slices
We replaces all slices with &'a [Foo] => &'a [impl Cast<Foo>], and we implement unsafe impl crate::Cast<Foo> for FooBuilder<'_> {}.
This allows us to have a slice for both Foo and FooBuilder.
This is only a preliminary implementation, so that we can talk about it.
Alternatively we might just only use builders for builders without any generics.

Interestingly this does not only apply to slices
impl<'a> ImageSubresourceLayersBuilder<'a> {
    pub fn aspect_mask(
        mut self,
        aspect_mask: ImageAspectFlags,
    ) -> ImageSubresourceLayersBuilder<'a> {
        self.inner.aspect_mask = aspect_mask;
        self
    }

So we might also want to address that.

This does not only apply to slices

What doesn't?

pub fn image_subresource(
    self,
    image_subresource: ImageSubresourceLayers
) -> BufferImageCopyBuilder<'a>

https://docs.rs/ash/0.29.0/ash/vk/struct.BufferImageCopyBuilder.html#method.image_subresource
Takes it by value, so the user has to call build on ImageSubresourceLayers::builder().build(), in this case it is fine, as it doesn't contain any pointers.
So we could also do something like
pub fn image_subresource(
    self,
    image_subresource: impl Into<ImageSubresourceLayers>
) -> BufferImageCopyBuilder<'a>

Given the very marginal benefit (you lose almost nothing by calling build explicitly, not even safety if you're doing it in the same statement that passes the aggregate value to the implementation) I'd like to know how much this impacts the already somewhat dire build time cost ash imposes on downstream crates.

Given the very marginal benefit (you lose almost nothing by calling build explicitly, not even safety if you're doing it in the same statement that passes the aggregate value to the implementation) I'd like to know how much this impacts the already somewhat dire build time cost ash imposes on downstream crates.

I know at least of a couple of people that run into some issues like that. And it can be easily avoided by just using builders.
I highly doubt that if will affect build times in any meaningful way, they are essentially setter functions. And we can also monomorphize inside ash, so no added build times for downstream crates.
The only con that I can see is the added complexity, and I am not sure if there is a better way to do it.

they are essentially setter functions

It's not the complexity of the functions that I'm concerned about, but rather the additional monomorphization load placed on downstream compiles.

And we can also monomorphize inside ash

I don't think Rust has this feature.

I am not sure if there is a better way to do it.

I believe this and the status quo are the only options.

I don't think Rust has this feature.

I have been doing it manually for quite a while. with Into etc.
pub fn do_generic(i: impl Into<Foo>) {
    fn inner(i: Foo) {
    }
    inner(i.into());
}

Where usually inner would do the heavy lifting, which is compiled in the lib. But for ash it is literally just a few assignments, so it doesn't matter much.
I often do this for serde stuff ^.

I have also showed this PR to a bunch of people, and no one was really convinced that it was necessary. So we might just close it.

Where usually inner would do the heavy lifting, which is compiled in the lib. But for ash it is literally just a few assignments, so it doesn't matter much.

Ah, I know that as "manual outlining"; the code is still polymorphic, but the burden is indeed reduced in the case of a complex definition.


Yosys fails to parse base-2 constant followed by ?

Parsing this trivial Verilog module
module inverter(input a, output y);

   assign y = (a == 1'b0? 1'b1 : 1'b0);

endmodule // inverter

yosys gives the error
Parsing Verilog input from `/tmp/inverter.v' to AST representation.
/tmp/inverter.v:3: ERROR: Digit larger than 1 used in in base-2 constant.

If a space is inserted before the ?, then the parse is successful.
Reproducable in current git master.

This is not a bug — ? is a valid binary digit in Verilog in some contexts, and it's supposed to be parsed as part of the same lexeme.  At most, this is a misleading error message.
The ? digit can be used eg. in cases:
module top(input [1:0] a, output b);

always @*
        case (a)
                2'b1?: b <= 1;
                2'b?1: b <= 1;
                default: b <= 0;
        endcase

endmodule

In those circumstances I think ? is interpreted as z, so 1'b0? is 1'b0z, which is a) longer than you specified, and b) probably an unintended bug.
So I'd agree that Yosys is correct to reject this code, but the warning could be improved.

@mwkmwkmwk I don't think this is one of those contexts, and if I do put a z or x there I do not get the error.

This doesn't matter — lexemes are the same everywhere, so the ? has to be parsed as part of the constant.  Also, you do get the same error for x and z:
module inverter(input a, output y);

   assign y = (a == 1'b0x 1'b1 : 1'b0);

endmodule // inverter

fails with the same error.

Fascinating.  So if you remove the ? between 1'b0x and 1'b1, then yosys finds a "digit larger than 1" which it did not find when there is a ? there.  Is it actually the (second) b that it complains about?  But then must scan past whitespace, so then how does having a space before the ? help in the original example?  Something very odd is going on here.

I don't know the Verilog grammar, but I would imagine here it's interpreted
as <value> <whitespace>+ ? <whitespace>+ <value> <whitespace>+ : <whitespace>+ <value>
Without at least one whitespace character, it would be parsed as part of
the value, and since ? is a valid character in values, you get an error
that the constant is too big while parsing the value. This would also be
why 1'0x encounters the same error.
On Sat, 7 Mar 2020, 17:52 Marcus Comstedt<EMAIL_ADDRESS>wrote:

Fascinating. So if you remove the ? between 1'b0x and 1'b1, then yosys
finds a "digit larger than 1" which it did not find when there is a ?
there. Is it actually the (second) b that it complains about? But then
must scan past whitespace, so then how does having a space before the ?
help in the original example? Something very odd is going on here.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/YosysHQ/yosys/issues/1745?email_source=notifications&email_token=AALPDW7DF62E5QWJC5WYCNLRGKCVDA5CNFSM4LDOZX5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOEBH5Y#issuecomment-596120567,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AALPDW6F5FTIWXAMVMT7OCLRGKCVDANCNFSM4LDOZX5A
.

Well, using 1'0x in itself does not cause the error (which by the way says that the digit is too large, not that there are too many of them), as mwkmwkmwk noted you need to also make a syntax error to get the error.  Consider the following table:

Expression
Result

a == 1'b0 ? 1'b1 : 1'b0
ok

a == 1'b0xxx ? 1'b1 : 1'b0
ok

a == 1'b0?xx ? 1'b1 : 1'b0
ok

a == 1'b0? 1'b1 : 1'b0
"Digit larger than 1 ..."

a == 1'b0xxx? 1'b1 : 1'b0
"Digit larger than 1 ..."

a == 1'b0?xx? 1'b1 : 1'b0
"Digit larger than 1 ..."

a == 1'b0 1'b1 : 1'b0
"Digit larger than 1 ..."

a == 1'b0xxx 1'b1 : 1'b0
"Digit larger than 1 ..."

a == 1'b0?xx 1'b1 : 1'b0
"Digit larger than 1 ..."

So it seems that it is not  the presence of superfluous digits (be they x or ?) that causes the error, but rather the absence of a ? for the ternary operator.  Which makes the choice of message even weirder.

I did some poking around in the code and saw that with the original expression of a == 1'b0? 1'b1 : 1'b0, what gets passed to my_strtobin (which generates the error) is "0?1'b1".  So it is actually, as I surmised earlier, the (second) b that is considered "larger than 1".  But why has the whitespace been removed?  And why isn't it removed when the input is a == 1'b0 ? 1'b1 : 1'b0?  This seems bonkers.

I did some poking around in the code and saw that with the original expression of a == 1'b0? 1'b1 : 1'b0, what gets passed to my_strtobin (which generates the error) is "0?1'b1". So it is actually, as I surmised earlier, the (second) b that is considered "larger than 1". But why has the whitespace been removed? And why isn't it removed when the input is a == 1'b0 ? 1'b1 : 1'b0? This seems bonkers.

Okay, there's lots of funny business here.
https://github.com/YosysHQ/yosys/blob/f2550d45ff53c5d430d3be172e6266240db22e6d/frontends/verilog/verilog_lexer.l#L276-L279
specifies the tokenisation rule for constant values. In this case, 1'b0? is treated as a 2-bit wide constant, as opposed to a 1-bit wide constant followed by the ternary operator.
Then, the following grammar rule: https://github.com/YosysHQ/yosys/blob/f2550d45ff53c5d430d3be172e6266240db22e6d/frontends/verilog/verilog_parser.y#L2528-L2534
will simply cram any two such constants together, including their bitwidths, resulting in the rather bizarre 1'b0?1'b1.
Apparently, git blame tells me this rule was added to handle constants that could be broken up by the existence of comments: https://github.com/YosysHQ/yosys/commit/ee8ad72fd950e1ee204e5c97155a50b8b1445dec
It is also not obvious what a fix for 1'b0? vs 1'b0 ? would be... but at least we have an explanation for now...

Ok.  So are constants allowed to be broken up by comments?  In that case I guess the parser will need some way to differentiate between comments replaced by whitespace and actual spaces.  But it seems like a rather odd thing to allow.

And anyway it seems weird to concatenate two TOK_CONSTVAL together since they each need to contain a ', so the result will always be bogus.  Can someone please present an example of code that this is supposed to work with?

And anyway it seems weird to concatenate two TOK_CONSTVAL together since they each need to contain a ', so the result will always be bogus. Can someone please present an example of code that this is supposed to work with?

See https://github.com/YosysHQ/yosys/commit/ee8ad72fd950e1ee204e5c97155a50b8b1445dec for a testcase, which uses an unsized constant and which doesn't need a '.

The commit message says "a constant with comment between size and value", but neither 4/*foo*/'b0000 or 4'/*foo*/b0000 would match this rule since only one half contains a ' and so the other won't match TOK_CONSTVAL...

See ee8ad72 for a testcase, which uses an unsized constant and which doesn't need a '.

Sorry, I don't see it.  Which are the two TOK_CONSTVAL that would get pasted together in that testcase?

The commit message says "a constant with comment between size and value", but neither 4/*foo*/'b0000 or 4'/*foo*/b0000 would match this rule since only one half contains a ' and so the other won't match TOK_CONSTVAL...

If you were to look beyond the commit message, you would see that commit contains a rather unique testcase which I shall explicitly link here: https://github.com/YosysHQ/yosys/blob/ee8ad72fd950e1ee204e5c97155a50b8b1445dec/tests/simple/macros.v#L239-L244

Yes, I saw the testcase, but I don't see the two TOK_CONSTVALs that get pasted together.  In fact the code does not seem to contain any TOK_CONSTVALs at all.  Also that commit deals with TOK_CONST, not TOK_CONSTVAL...

Well, ok, `SIZE'ha will match TOK_CONSTVAL after macro expansion, but there is no other TOK_CONSTVAL next to it to be concatenated with.

Yes, I saw the testcase, but I don't see the two TOK_CONSTVALs that get pasted together. In fact the code does not seem to contain any TOK_CONSTVALs at all.

Also that commit deals with TOK_CONST, not TOK_CONSTVAL...

  That explains it.  But then the information that it's two TOK_CONSTVAL is too little information to determine if contcatenating them yields something valid.
The best solution here would probably be not to treat the whole constant as a single lexeme, but rather have separate tokens for the parts which can be separated by whitespace / comments.  Then the grammar can make sure no parts are duplicated.

Interestingly, Vivado also errors out on:
module top(input a, output o);
assign o = a == 1'b0? 1'b1 : 1'b0;
endmodule

with ERROR: [Synth 8-2715] syntax error near 1, but works when there's a space before the ?:
module top(input a, output o);
assign o = a == 1'b0 ? 1'b1 : 1'b0;
endmodule

Yeah, Quartus as well (even though I could have sworn I saw it work there).  That's probably fine, with ? being considered a valid digit.  The error message "syntax error" is, while not super informative, at least not misleading like the yosys message.
The problem with yosys is that the rule to handle comments in constants is overreaching (which leads to the weird error message in this case, and potentially also to it accepting invalid code), while it also seems to not handle all cases you'd expect it to:
It accepts 8/*foo*/'haa, but not 8'h/*foo*/aa, even though the rule for TOK_CONSTVAL accepts spaces (and even newlines) in the latter position as well.
I think I have understood the problem that the code tries to solve now, so I'll see if I can come up with a more sane solution.


Microsoft CSS Extensions

Hello @microsoft, Please Create a CSS Extension for :-

Formatting
Intellisense for Class's & ID's (Present in .html)
Some Most used Snippets like

*{
  margin: 0;
  padding: 0;
  box-sizing: border-box
}
etc.

Latest CSS Features Guide on Hover

On iteration plan #144519, no tracking issue
Duplicate of #47331
Everyone needs different snippets, you can add your own
Can't understand

Always use one issue for each feature request.

CSS Formatter: https://github.com/microsoft/vscode/issues/19166


Adoption of octavia service

Octavia adoption documentation
JIRAs: OSPRH-10750 OSPNET-1078

recheck
mariadb issues are unrelated


Migrate to Emotion from Styled-Components

Much easier testing, faster, smaller, more flexible API.

[Core] is migrated.
[Dev] Has it removed from externals (so it will add to any tab's package size if they use Styled-Components.
[Dev] has will leave all existing support in tooling.
[Common] moving forward won't include @emotion packages either in vendors so users can use either library.
Both will remain in [Common] package.json dependencies.


Add JSX and React support.

- Summary

I was looking to use some simple React components in my Hugo app, and thought it might be of use to others. :)
- Test plan

- Description for the changelog

Added JSX transforms for Babel, along with React and React-DOM.
- A picture of a cute animal (not mandatory but encouraged)

Source: http://www.staplepost.com/2923/cute-cat-pictures

This won't be necessary for many Hugo sites, but feel free to fork this and make a Hugo/React starter!


Ordered parameters

ADO.NET assumes that providers support either named parameters or ordered parameters, but SQLite supports both.
Things start to fall apart when you try to mix ordered and named parameters. For example:
SELECT ? AS Ordered, @Named AS Named

What should happen when you specify the parameters like this?
command.Parameters.AddWithValue("@Named", 42);
command.Parameters.AddWithValue("@Other", "unknown");

Internally, the ? will have an index of 1 and @Named will have an index of 2. How does this index map to the index in the Parameters property?
One option would be that if a parameter name doesn't map to a SQLite index, use the Parameters index. If that index happens to map to a parameter with a name (like it does above), we could throw. That way, everything would work if you specify the parameters in this order:
command.Parameters.AddWithValue("@Other", "unknown");
command.Parameters.AddWithValue("@Named", 42);

We could also just try to detect a mix of named and ordered parameters and throw to prevent this situation. Unfortunately, we won't be able to distinguish between a misspelled parameter and a parameter that's supposed to be ordered.
It gets even more confusing when you do something like this.
SELECT @One, @Two, ?2

In this case, ?2 will always refer to @Two even if it's added to the Parameters collection before @One.

Notes for triage: I think we can close this as won't fix. Nobody using our provider seems to need ordered parameters.


[Feature]: Change the cards layout

Describe the feature
In small devices, the user can only view single card at a time, which decreases the user experience by not comparing with the other products at the same time
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

/assign-me

please assign me this issue, I want to work on this.


Create a testing tool

People all have their own way of integration-testing Javalin apps. Maybe we should create an official package with a http-client and a set of useful methods?
The main goal is enabling people (and the Javalin project itself), to setup simple tests like this:
@Test
fun `error-mapper works for 500`() = TestUtil.test { app, http ->
    app.get("/exception") { throw RuntimeException() }
    app.error(500) { ctx -> ctx.result("Custom 500 page") }
    assertThat(http.getBody("/exception")).isEqualTo("Custom 500 page")
}

I'm too lazy.

I would find this useful, your test use internal classes of javalin, so are hard to replicate.

I can take this :)

My maven knowledge isn't super robust, but I believe the project structure would have to change in order to have separate javalin and javalin-test modules.
javalin/
  src/
  pom.xml
  ...
javalin-test/
  src/
  pom.xml
  ...
pom.xml
...

Are you ok inuring the massive delta to support this?  Or would you prefer a different repo?  Or is there a better way I don't know of.  Apache HttpClient has the structure I'm speaking of.

@tipsy, how would you like to proceed regarding my previous comment?

@oharaandrew314 Sorry, I missed your comment somehow. I'm not really sure what @alexey-wg2 has in mind. If the tool includes a HTTP client, I think it should live in a separate repo and be published independently of Javalin.

@tipsy I've created a javalin-test repo, with artifacts provided by jitpack.  It's almost identical to the internal test client.
If you'd like to take ownership of it, I can move it from Gitlab to Github, and change the CI from Gitlab to travis.  Alternatively, I'm happy to maintain it myself, and can add a link to it in the javalin Readme.

@oharaandrew314 It would be great if you could maintain it, but if it's going to be used in Javalin itself, then maybe it should live under the Javalin org? (https://github.com/javalin). Would also be nice if it could be published to Maven Central 🤔
Here's a not so fun fact: The tests in Javalin also use OkHttp (gzip tests) and java_websocket (...WebSocket tst). Should this tool aim to eliminate either OkHttp or Unirest (Unirest is abandoned) and only use 1 HTTP client, and should it add an abstraction layer for easier WebSocket testing?

@tipsy, I'm totally fine with cutting out unirest in favor of okhttp.  It
looks like it has a socket API too, but my experience with them is limited,
so I wouldn't know what kind of abstraction layer would be helpful.  It may
be best to omit socket support from the client until it can be done in a
"good" way.  People can attach their own clients in the meantime.
You can go ahead and make the repo under the org.  If you give me write
access, I'll move everything over.
On Sun., Jun. 30, 2019, 5:12 p.m. David<EMAIL_ADDRESS>wrote:

@oharaandrew314 https://github.com/oharaandrew314 It would be great if
you could maintain it, but if it's going to be used in Javalin itself, then
maybe it should live under the Javalin org? (https://github.com/javalin).
Would also be nice if it could be published to Maven Central 🤔
Here's a not so fun fact: The tests in Javalin also use OkHttp (gzip
tests) and java_websocket (...WebSocket tst). Should this tool aim to
eliminate either OkHttp or Unirest (Unirest is abandoned) and only use 1
HTTP client, and should it add an abstraction layer for easier WebSocket
testing?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tipsy/javalin/issues/556?email_source=notifications&email_token=AAG2JSECFMQ6BAQNVPKVHGDP5EOSZA5CNFSM4HGWZS62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY4T3VA#issuecomment-507067860,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAG2JSGYUJGFUNU7TTSURDTP5EOSZANCNFSM4HGWZS6Q
.

@oharaandrew314 I've created a repo and invited you. The abstraction layer for WebSocket is written into the WebSocket test in the repo, it's mainly wait-functions. Would be nice if the methods could be made blocking. I don't think it's required to use OkHttp for WebSockets, java_websocket should be fine.

Unirest is back in active development: https://github.com/OpenUnirest/unirest-java, https://github.com/Kong/unirest-java

They also have created their own testing tool now: https://github.com/Kong/unirest-java/issues/265

@tipsy, do you strongly prefer using Unirest instead of okhttp in javalin-test?
As for the proposed unirest testing lib you mentioned, how do you imagine it would be helpful?

@tipsy, do you strongly prefer using Unirest instead of okhttp in javalin-test?

Not at all. While it looks like Unirest has been saved from abandonment now, okhttp is still a much stronger choice. I'm not a big fan of how clunky their API is, but for the purpose of this tool, that could be abstracted away.

As for the proposed unirest testing lib you mentioned, how do you imagine it would be helpful?

I'm not sure, I just included it for inspiration. They had a neat assert method on the response, we could do something similar.

Please have a look to a proposed changes to the Maven structure https://github.com/tipsy/javalin/pull/749

@oharaandrew314 have you had a chance to check out the PR ?

@tipsy I agree it's probably best to include it as a submodule.  I had some work in progress to incorporate Rest Assured into the test project, but I think it would be pretty simple to add it to the JUnit Rule if we desire.


Storage option

What about adding a configuration option to choose between localStorage & sessionStorage?

try this following:
setStorageType(widnow.localStorage)

@bluebill1049  setStorageType? I am using React not React Native...

Yeah, it works.
Thanks, @bluebill1049 ... I really appreciate it

No worries 😉
Cheers
Bill

On 16 Oct 2020, at 9:10 am, Muhammad<EMAIL_ADDRESS>wrote:
Yeah, it works.
Thanks, @bluebill1049 ... I really appreciate it
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Sorry to open this again, but can I change to storage to indexeddb or similar? I need to storage some images and localStorage and sessionStorage has smaller storage to doing this.

Sorry to open this again, but can I change to storage to indexeddb or similar? I need to storage some images and localStorage and sessionStorage has smaller storage to doing this.

not supporting indexdb at the momoment.

not supporting indexdb at the momoment.

but, well, I think an indexeddb adapter should be easy to create:
/** This Web Storage API interface provides access to a particular domain's session or local storage. It allows, for example, the addition, modification, or deletion of stored data items. */
interface Storage {
    /**
     * Returns the number of key/value pairs currently present in the list associated with the object.
     */
    readonly length: number;
    /**
     * Empties the list associated with the object of all key/value pairs, if there are any.
     */
    clear(): void;
    /**
     * Returns the current value associated with the given key, or null if the given key does not exist in the list associated with the object.
     */
    getItem(key: string): string | null;
    /**
     * Returns the name of the nth key in the list, or null if n is greater than or equal to the number of key/value pairs in the object.
     */
    key(index: number): string | null;
    /**
     * Removes the key/value pair with the given key from the list associated with the object, if a key/value pair with the given key exists.
     */
    removeItem(key: string): void;
    /**
     * Sets the value of the pair identified by key to value, creating a new key/value pair if none existed for key previously.
     *
     * Throws a "QuotaExceededError" DOMException exception if the new value couldn't be set. (Setting could fail if, e.g., the user has disabled storage for the site, or if the quota has been exceeded.)
     */
    setItem(key: string, value: string): void;
    [name: string]: any;
}


[BEAM-7437] Raise RuntimeError for PY2 in BigqueryFullResultStreamingMatcher

TimeoutError is not a built-in exception in Python 2.
Raise RuntimeError in Python 2.
The tests passed in the original PR[1], but the PreCommit started failing today because of this.
[1] https://github.com/apache/beam/pull/8934

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Run Portable_Python PreCommit

Run Portable_Python PreCommit

Run Python PreCommit

Tests pass. :heavy_check_mark:
@udim PTAL :)

Thanks @udim!


Complete test coverage for Rubocop RSpec

This removes an unused method and adds a final spec to cover an intentionally unimplemented method.

Before submitting the PR make sure the following are checked:

[ ] Feature branch is up-to-date with master (if not - rebase it).
[ ] Squashed related commits together.
[ ] Added tests.
[ ] Updated documentation.
[ ] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
[ ] The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

If you have created a new cop:

[ ] Added the new cop to config/default.yml.
[ ] The cop is configured as Enabled: pending in config/default.yml.
[ ] The cop is configured as Enabled: true in .rubocop.yml.
[ ] The cop documents examples of good and bad code.
[ ] The tests assert both that bad code is reported and that good code is not reported.
[ ] Set VersionAdded: "<<next>>" in default/config.yml.

If you have modified an existing cop's configuration options:

[ ] Set VersionChanged: "<<next>>" in config/default.yml.

Closed in favor of:

https://github.com/rubocop/rubocop-rspec/pull/1970


readability and comprehension testing for data visualizations

Testing completed. See report at: https://github.com/gctools-outilsgc/design-system/blob/master/ux testing/Report_typography and data viz testing.pdf


Add events to tell windows to resize / reposition

Unless I'm mistaken, you can move and resize windows by their controls, but I don't think you can ask the window manager to resize / reposition windows using events.
~You may be able to do it by updating the window manager directly though, need to test it.~ Nope.

You can tell a window to do this already with a WindowEvent.


Build time test failure

Hi,
there is a bug report filed against the Debian packaged version about a test failure of the build time test suite:
...
unknown file: Failure
C++ exception with description "map::at" thrown in the test body.
[  FAILED  ] OsgMaterialTests.SetAndClearShaderTest (1 ms)
...
unknown file: Failure
C++ exception with description "map::at" thrown in the test body.
[  FAILED  ] OsgProgramTests.StateSetTest (0 ms)
...
 2 FAILED TESTS

14/15 Test #10: SurgSimFrameworkTest .............   Passed   45.31 sec
15/15 Test #15: SurgSimPhysicsTest ...............   Passed   91.85 sec

93% tests passed, 1 tests failed out of 15

Total Test time (real) =  91.91 sec

The following tests FAILED:
  11 - SurgSimGraphicsTest (Failed)
Errors while running CTest

Any idea how to fix this?
Kind regards, Andreas.

Hi Andreas thanks for forwarding this to us I’d have to have a look at it. We are currently not doing any active development on OSS. This
Might take a bit... also the person who spearheaded the Debian package is not with us anymore ...
Harry

On Dec 21, 2018, at 09:54, Andreas Tille<EMAIL_ADDRESS>wrote:
Hi,
there is a bug report filed against the Debian packaged version about a test failure of the build time test suite:
...
unknown file: Failure
C++ exception with description "map::at" thrown in the test body.
[  FAILED  ] OsgMaterialTests.SetAndClearShaderTest (1 ms)
...
unknown file: Failure
C++ exception with description "map::at" thrown in the test body.
[  FAILED  ] OsgProgramTests.StateSetTest (0 ms)
...
2 FAILED TESTS
14/15 Test #10: SurgSimFrameworkTest .............   Passed   45.31 sec
15/15 Test #15: SurgSimPhysicsTest ...............   Passed   91.85 sec
93% tests passed, 1 tests failed out of 15
Total Test time (real) =  91.91 sec
The following tests FAILED:
11 - SurgSimGraphicsTest (Failed)
Errors while running CTest
Any idea how to fix this?
Kind regards, Andreas.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Hi, thanks for the information.  I'm pretty sure this will not influence your schedule but just a data point for you:  If you want opensurgsim distributed with the next stable Debian release this issue should be fixed by end of January since then starts the freeze period.  Kind regards, Andreas.


[TACHYON-648] Add unit test of EvictorFactory

[TACHYON-648] Add unit test of EvictorFactory
Change the code to meet comments in
https://github.com/amplab/tachyon/pull/1119

+1 LGTM.
PS, any particular reason to open new PR and move new commits here rather than appending commits to #1119 ?

sorry, I will append commits to the old PR next time .

No worry.  Thanks for the patch!

Thanks for the patch @luoli523 ! I left some minor comments and questions.

This PR stands for too long. Merged it and create  TACHYON-723 - Fix wrong testcase name in EvictorFactoryTest.java to fix this unit tests


tf.function only supports singleton tf.Variables created on the first call. Make sure the tf.Variable is only created once or created outside tf.function.

I compiled as required, and the following problems occurred：tf.function only supports singleton tf.Variables created on the first call. Make sure the tf.Variable is only created once or created outside tf.function.
What do I need to modify?

Hi,
Make sure that you installed the proper versions of tensorflow and keras.
The best way is to install via the command: pip install -r requirements.txt
Good luck.


chore: fix attribute changes to Show My Location link in openstreetmap

attribute data-original-title has changed to data-bs-original-title in the openstreetmap.org website

need a rebuild for the failed job, also please review and approve the PR 😃. I started looking into the code and this test was failing so I wanted to fix it as my first contribution to this project 🎉

need a rebuild for the failed job, also please review and approve the PR 😃. I started looking into the code and this test was failing so I wanted to fix it as my first contribution to this project 🎉

Thanks! Example tests are green on ci, so merging in.


[Bug]: i keep getting erros and banned and i cant seem to find or open the error log

Version of the software
most recent
Operating system
win 10
Browser / Native
Native
What happened?
i was running a config and i just kept getting errors and banneds i try then to open my error log to see the issue but cant seem to find it

and i think this is where the logs are supposed to be at but theres nothing in that folder

i am new to openbullet
Relevant LoliCode if needed
No response

Hello, this is not a bug. Please read this https://discourse.openbullet.dev/t/how-to-debug-ban-error-issues-in-a-job/3055


I have an updated STMCubeIde example, should I upload it

I just got back to looking at Daisy, and updated an old example I have of using the STM32CubeIde for development, which I still think is the best option. It's based on the pod/SimpleOscillator example.
Should I upload it? File a PR? And since it is based on the SimpleOscillator example, would it make sense to put the project file there?

Hi @jandyman
What does the file structure of the project look like.
I think an up-to-date example for STM32CubeIDE would be a welcome sight in the community, but I'm not sure if it would fit in this repo.
Let me know, and we can discuss where it might best fit in the ecosystem!

You know something? You got me thinking about how to use the existing makefiles within Eclipse (i.e. STM32CubeIde). Usually the problem with makefiles is that you have to update them manually, but in this case this is done by the daisy team anyway.
It turns it out it's so simple that all I really need to convey is how to do it, there is no need to create an example project, and it can be done for any of the examples. So the revised question would be "where should I put the instructions"?
I've also got instructions for building a native Eclipse project, which is sometimes easier to maintain as one moves away from the existing examples.
@stephenhensley

Hi @jandyman that's an excellent thought, and would be a welcome addition to our resources!
We're currently planning out a long term plan for how to maintain documentation across the Daisy platform (as there is currently fairly sparse documentation in a lot of different places).
For the time being, the most portable way to add some documentation would be to add it to the libDaisy guides.
I'm not sure what making a PR on the DaisyWiki's wiki would look like, but that's another option. (We had to disable public editing of the wiki because links were getting edited by bots)
These guides are currently located in libDaisy/doc/md. Working with them as markdown makes it easy to preview locally, and load into something that can be included in the web documentation or moved to other mediums with relative ease.
You can add your instructions as a new MD file there, and include a link to it in the reference_home.md file and include those changes in a PR on libDaisy.
Alternatively, you could make a new thread on the forum and include save yourself the PR part 😄
Either way, let me know if you have any questions!


rector doctrine for odm mongodb

hello is there some rules for doctrine odm mongodb ?

Hi, not in the core package.
You can check existing sets here: https://github.com/rectorphp/rector-doctrine/tree/main/config/sets


[Feature] Consolidate forms in account/edit

Right now, the account/edit page has a separate Form for each field. This makes it a little unclear which field you're trying to update (is it the one above, or below?). Some suggestions:

Have a single Form + single "Update" button
Somehow make the UI more clear. CSS styling?

validated! and an issue in core


Updated github lib v34 -> v35

Signed-off-by: Spazzy<EMAIL_ADDRESS>Changelog
Add a list of items that this pull request changes

Updates Github Lib from v34 -> v35

Issues
fix: https://github.com/Spazzy757/paul/issues/88

/approve

/giphy party

/merge


Language option

The main change of these changes is that they provide an option to change language for the weather forecast.
Additionally the following changes were made along the way:

help message subcommand was moved to a separate subcommand method and its formatting was improved so it would look nicer;
default_location now can be left empty, thus utilizing location detection from IP address by wttr.in;
WeatherBot was refactored to separate logical code blocks in helper methods.

This looks good.  Thank you!


Implement plan read only mode

To test, set planReadOnly to true in plan.ts store. This writable store can/will be used when entering plan snapshot preview mode which depends on #913
Closes #879

@duranb resolved tooltip issue and set planReadOnly back to false.


StorageCluster: fix the logic for the minimum number of nodes

We always want to rely on the internal defaults for minimum number of
nodes. They are 4 for arbiter cluster and 3 for non-arbiter cluster.
In cases where the storage device set has a value greater than the
default we make the assumption that the user wants that many nodes.
Co-authored-by: Michael Adam<EMAIL_ADDRESS>Signed-off-by: Raghavendra Talur<EMAIL_ADDRESS>

@jarrpa @obnoxxx Please take a look.

/test ocs-operator-ci

/cherrypick release-4.7


Merge pull request #3 from pablo0261/NewFront

Merge pull request #2 from pablo0261/main

verificar merge de branch


Use LAMBDEX_ENTRY_POINT env var for entry point if available

We have a use case where we'd like to use a single PEX file to support multiple Lambdas. Rather than building multiple PEX files with different LAMBDEX-INFO files, we'd prefer to specify the entry point at runtime via an environment variable. PEX supports something similar with the PEX_MODULE and PEX_SCRIPT env vars.
This PR updates lambdex_handler.py to use the LAMBDEX_ENTRY_POINT environment variable (when present) as the entry point instead of the entry point specified in LAMBDEX-INFO.

@jsirois I'm hoping this is a small enough change to get your blessing :) I'm open to other names for the env var; LAMBDEX_MODULE would more closely match PEX 🤷🏻♂

This sgtm & lgtm @luislew. Thanks.
It would be good to have a test added though to the existing IT commands:
https://github.com/pantsbuild/lambdex/blob/416e6c37a3eacc1425828a2bb2b685533140f29a/tox.ini#L17-L24
I'd guess using lambdex test ... with the new env variable picking out a handler that can identify itself via stderr output or an exit code?

This sgtm & lgtm @luislew. Thanks.
It would be good to have a test added though to the existing IT commands:
https://github.com/pantsbuild/lambdex/blob/416e6c37a3eacc1425828a2bb2b685533140f29a/tox.ini#L17-L24
I'd guess using lambdex test ... with the new env variable picking out a handler that can identify itself via stderr output or an exit code?

Aha, I missed that there were any tests 😆 I'll definitely add one in...

OK. Beware thought that lambdex test directly reads entrypoint metadata and not your new env var. So this will probablu force factoring out a helper to read from env or metadata.
Thanks again @luislew.

@jsirois Ok, I made some updates:

lambdex test now respects the LAMBDEX_ENTRY_POINT env var. I couldn't see a clean way to refactor this into a helper, because lambdex_handler can't import a helper from anywhere else, unless you have a better idea?
I added a basic test of LAMBDEX_ENTRY_POINT, using lambdex test --empty; this test will fail if it tries to use handler instead of other_handler

@jsirois I'd love another look whenever you get a chance, thanks again!

Hi @luislew , just to update that we haven't forgotten about this, @jsirois is out on vacation and will review once he's back in a few days. :)

I couldn't see a clean way to refactor this into a helper, because lambdex_handler can't import a helper from anywhere else, unless you have a better idea?

I think the duplication is fine for the foreseeable future.

Thanks for your reliable and helpful attention!


PlainClone not fully populating tree on Windows

I acknowledge that it's entirely possible (highly likely even) that I'm doing something wrong, but it's not immediately obvious to me what it is.  I'm trying to use PlainClone and I'm getting the initial .git files for the repository but not the actual source.  I'm either getting a 'repository already exists' or a 'reference not found' error. I'd appreciate any feedback on what I'm doing wrong.
I'm using go-git.V4 on Go 1.8
_, err := git.PlainClone("d:/localsrc", false, &git.CloneOptions{
		URL: "https://ourstash.scm.ourlibrary.git",
		RemoteName: "develop",  //tried commenting this out to no avial
		Depth : 9999999,
		SingleBranch: true,  //setting this to true results in 'repository already exists' error, setting this to false results in 'reference not found' error
		RecurseSubmodules: 9999999,
})

@SlowPokeInTexas Does your repository contain symlinks or submodules? There are some known problems with file handling on Windows, see https://github.com/src-d/go-git/labels/windows
We'll look into this.

@SlowPokeInTexas any updated about this? Can you try with the last version?

If still happens please reopen the issue.


LV3 Spec Sheet

We should totally collate specification sheets for the flight hardware of LV3. Example data we would want to include:

Component level

Mass
CoM
Failure load for various modes
Maximum working temperature
Fastener sizes
Failure acceleration (obviously not meaningful for parts that support other parts)

System level (include expected/flown data)

Acceleration
Altitude
Air speed / Mach number
Times flown
Mass / weight

This is sort of a thing here.


[version 2.7.0]remove the StaticContext class and refactor the code related to Async

What is the purpose of the change
The class StaticContext is a Map which place anything to it and it will leave design risks if StaticContext is used easily and everywhere.
Verifying this change

remove the class StaticContext
fix the testcases
refactor the part of using StaticContext which is mainly about Async

Codecov Report

Merging #2688 into master will decrease coverage by 0.11%.
The diff coverage is 77.41%.

@@            Coverage Diff             @@
##           master    #2688      +/-   ##
==========================================
- Coverage   63.24%   63.13%   -0.12%
==========================================
  Files         573      572       -1
  Lines       25763    25791      +28
  Branches     4533     4540       +7
==========================================
- Hits        16294    16282      -12
- Misses       7320     7353      +33
- Partials     2149     2156       +7

Impacted Files
Coverage Δ

...a/org/apache/dubbo/rpc/model/ApplicationModel.java
92.85% <ø> (+7.14%)
:arrow_up:

...c/main/java/org/apache/dubbo/common/Constants.java
88.88% <ø> (ø)
:arrow_up:

...java/org/apache/dubbo/rpc/model/ProviderModel.java
52.94% <ø> (ø)
:arrow_up:

...java/org/apache/dubbo/rpc/model/ConsumerModel.java
64.28% <100%> (+5.95%)
:arrow_up:

...rg/apache/dubbo/rpc/model/ConsumerMethodModel.java
81.39% <100%> (+21.39%)
:arrow_up:

...n/java/org/apache/dubbo/config/AbstractConfig.java
73.68% <73.68%> (-3.11%)
:arrow_down:

.../java/org/apache/dubbo/config/ReferenceConfig.java
56.27% <87.5%> (+0.79%)
:arrow_up:

.../dubbo/rpc/protocol/dubbo/filter/FutureFilter.java
64.42% <95.65%> (+5.33%)
:arrow_up:

...a/org/apache/dubbo/rpc/filter/AccessLogFilter.java
52.22% <0%> (-18.89%)
:arrow_down:

...ache/dubbo/remoting/transport/AbstractChannel.java
75% <0%> (-12.5%)
:arrow_down:

... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7286e23...5a69aa0. Read the comment docs.

I just commits the changes according to @beiwei30  @kimmking advices.
1） revert the Constants value changes. I used to use the values of async contants to map the properties of AsyncMethodInfo which is not allowed to the xxx.xxx and it was OK formerly when it is used as the key of StaticContext's map. So I changes those  values. But the finally refactor is no more need those references.

fix the types and format {}


Don't render slots until their v-if is true

What problem does this feature solve?
Say there's a layout component with a navbar at the top and a main content area (the primary slot <slot/>). This component has the prop loading which, when true, shows a loading spinner in the main content area instead of the elements. I've included a basic example below.
At the moment, even when loading is true and the v-if for the <slot/> is false, the nodes are still being rendered. Ideally, loading here should only become false when all data has been loaded and it is safe to render the <slot/> elements.
Yes, I'm aware that I could just v-if="!!var" everything, but this can get very tedious and shouldn't be necessary (in my opinion).
I can imagine this would probably require quite a bit of stuff to be changed but I believe this is the ideal and desired functionality in this case. Sorry about the terminology, not quite sure what to call everything.
What does the proposed API look like?
Layout.vue
<template>

    <Navbar :nav-items="..." />

    <Spinner v-if="loading"/>
    <slot v-else/>

</template>

Implementation.vue
<template>
  <Layout :loading="...">

{{ rendered.once.loaded }}

  </Layout>
</template>

Duplicate of #9756


C4 gt milestones dt abdm ]

Project
Name of the project
Changes
What was updated (new pages, weekly update, etc.)
Notes
If there are any further notes.

@AmanGadadare What is this PR for?


Add S3 upload arguments

Description

This allows the use of upload arguments to be passed through to the S3
client.
This will enable server-side encryption on S3 buckets.
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/customizations/s3.html#boto3.s3.transfer.S3Transfer.ALLOWED_UPLOAD_ARGS
For https://github.com/Miserlou/Zappa/issues/1792
GitHub Issues

#1792

Coverage decreased (-16.6%) to 56.409% when pulling e3e7f88982ae6a75673dbe071b01253e12b3e22d on StevePorter92:s3-upload-args into 80a6881f0ec0be525a8fd7835b5a1157f9e66100 on Miserlou:master.

That would be a much appreciated feature! If it could pass the CI...

Fixed the CI build
/cc @flingure

Many thanks StevePorter92!
Hope it gets merged pretty soon!

Is there any chance this could be available for the next release @jneves?


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-k8s-28-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 4253

Questions ?
Please refer to the Backport tool documentation


Add .mts and .cts as allowable extensions to graphql-request

Description
The .ts requirement seems like it's purely there to protect users. However, I'd like the file to be .mts so that it gets compiled into a .mjs file.
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as
expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Applied similar patch via patch-package
Checklist:

[ ] I have followed the
CONTRIBUTING doc and the
style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Is there a chance to merge it and release it sometime soon? It's currently blocking my work. Thanks!

@zofiag Try this via patch-package: https://github.com/benjie/.dev/blob/012e85a3ded79995c07a0956736160571f3edc2e/patches/%40graphql-codegen%2Btypescript-graphql-request%2B6.0.1.patch

released<EMAIL_ADDRESS>


Set a print listener as soon as possible in the autoprint integration test

This test intermittently fails, likely because the auto-print is triggered fast enough that we don't manage to get it.
So this patch aims to try to set a listener very early in order to be sure that we'll be aware that a print has been triggered.

/botio integrationtest

/botio integrationtest

Overall this seems like a much more reliable approach; thank you for doing this!


SetUP() and TearDown() not called in C++

I'm creating my first DUnitX test using C++ builder (Tokyo 10.2.3) on Windows 10.
I create a simple test project using the IDE DUnitX project wizard.
It compiles and runs, but SetUp and TearDown() are never called.
The tests are called as expected.
What can possible be wrong?
#include <DUnitX.TestFramework.hpp>
#include <stdio.h>

#pragma option --xrtti

class __declspec(delphirtti) TMyTestClass : public TObject {

    int testInt;

public:
    virtual void __fastcall SetUp();
    virtual void __fastcall TearDown();

__published:
    void __fastcall Test1();
    void __fastcall Test2();
};

void __fastcall TMyTestClass::SetUp() {
    testInt = 17;
}

void __fastcall TMyTestClass::TearDown() {
}

void __fastcall TMyTestClass::Test1() {
    Dunitx::Testframework::Assert::AreEqual(testInt, 17);
}

void __fastcall TMyTestClass::Test2() {
    Dunitx::Testframework::Assert::AreEqual(testInt, 71);
    // This fails for illustrative purposes
}

static void registerTests() {
    TDUnitX::RegisterTestFixture(__classid(TMyTestClass));
}
#pragma startup registerTests 33

I'm afraid I have no idea, I've not used DUnitX with C++Builder before. The C++ support was added by embarcadero, might be worth asking on their forums.

Ok, thanks.


Support for Expiration Date

I'm wondering if it is possible to provide an expiration date for the InAppPurchaseItem. I'm trying to create offline features for my Xamarin.Forms app, however the fact that I must call GetPurchases() every time the user launches my App means they must be online. If I could somehow store the expiration date then I could store this value and check against this on launch instead.
Is this possible?
Thanks Sach

You would just store the expiration data that you calculate from the time of purchase. These are not returned by any of the APIs.


New exercise: Tower of Hanoi.

See https://github.com/exercism/go/issues/1270

Would one way to simplify this exercise slightly be to assume that the rods are always called "A", "B", and "C"? Then the solution program no longer needs those inputs, and the only input would be the number of disks.

Yes, I see now, this is a pretty standard thing with Towers of Hanoi solvers. How about calling them from, to, and via, then?

It doesn't seem very Go-like to use strings for the rod names. How about defining constants:
const (
	From = iota
	To
	Via
)

Pushed a change replacing rods names with numeric IDs.

I'm not sure the numeric IDs are really an improvement over A, B, and C. Given that the key insight in solving this puzzle is swapping around the From, To, and Via rods in recursive calls to Solve, shouldn't we name them From, To, and Via as suggested? If you can come up with better names, by all means do!

Well, the func parameters were named 'from', 'to', 'via' already, but their type was string. I thought the point of defining numeric constants was to change their type from string id to numeric id.
So I think I am misunderstanding something.
Can you show the interface you have in mind for the function?

Yes, absolutely: the signature is fine, but I'm suggesting we use the named constants instead of 10, 20, 30, etc. Actually, now that I understand the problem a bit more, I think the names A, B, and C make sense:
Your implementation will accept the amount of disks on rod A, then issue a list of moves for solving the puzzle.

Example:

Input:
- number of disks: 2

Output: list of three moves: {A,C}, {A,B}, {C,B}

Oh, now I see what you mean: names used in the exercise description.
I am trying to figure how to use the constants in the problem description while not suggesting to the student that those constants would actually help in the implementation, since the recursive solution itself would not benefit from them.
Please see a sketch below.
What do you think?
Your implementation will accept the amount of disks on rod A, then issue a list of moves for solving the puzzle.

// Consider the constants below naming the rods, for the sake of the problem description.
// Your implementation is free to define similar constants, but this is not a requirement.
const (
	A = iota
	B
	C
)

Example:

Input:
- number of disks: 2

Output: list of three moves: {A,C}, {A,B}, {C,B}

Yes, for the sake of generating readable output, it's maybe better to define, for example:
const A = 'A'
...

What do you think?

I added pretty printing to tests.
Now we can keep rods names like A,B,C in the generic description, and tests would report similar names.
go test passing:
    hanoi_test.go:80: disks=7 move=[A B] before: {[1] [7 6 5 4 3 2] []}
    hanoi_test.go:140: disks=7 move=[A B] after: {[] [7 6 5 4 3 2 1] []}
    hanoi_test.go:31: PASS totalDisks=7

go test failing:
    hanoi_test.go:80: disks=7 move=[A B] before: {[7 6 5 4 3 2 1] [] []}
    hanoi_test.go:140: disks=7 move=[A B] after: {[7 6 5 4 3 2] [1] []}
    hanoi_test.go:28: FAIL totalDisks=7 rod TO=B has 1 disks, should have 7: [1]

In Go we state:
// Example
// Solve(1, 'A', 'B', 'C') could return a list with a single move:
//  [][2]int{{'A', 'B'}} // move disk from rod 'A' to rod 'B'

I am unsure about how much information we should put in the stub file 'hanoi.go'.
Can you guys please have a look at how it looks?

How come you closed this, @udhos?

Sorry, I guess I closed it by accident.

how much information we should put in the stub file 'hanoi.go'

It looks ok I think.  @bitfield ?

This looks like a very interesting exercise and as a learner I would love to see it on the website. But it seems that it has been ignored since the last modification . Is this abandoned? @leenipper @bitfield @udhos

Is this abandoned?

So it seems!

I am closing all PRs that are over a year old. Please reopen if you are still working on this.


WIP: Support PHP8

Q
A

Bug fix?
no

New feature?
no

BC breaks?
yes, currently drops php7.2, will check other phpunit version

Deprecations?
no

License
MIT

What's in this PR?
This PR provides the possibility to use PHP8 in projects which uses this library as a dependency.
Required dev-dependency changes:

upgrade php-http/client-integration-tests 2.0 -> 3.0
upgrade phpunit 7.4 -> 9.4 (+ migrated phpunit.xml with "--migrate-configuration")

Checklist

[ ] Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix
[ ] Documentation pull request created (if not simply a bugfix)

To Do

[ ] If the PR is not complete but you want to discuss the approach, list what remains to be done here

thanks for looking into this!

thanks a lot!

https://github.com/php-http/guzzle7-adapter/releases/tag/0.1.1


Migrate to Material 3

On-hold due to no pullrefresh support in M3
https://issuetracker.google.com/issues/261760718


change field updates to new syntax

Sorry for the slow response. This should be resolved in the latest stuff!


feat(nexus): share over nvmf with controller ID range

Add a nexus_share JSON RPC that allows a nexus bdev to be shared over
nvmf with a specified controller ID range. This allows the same nexus
on different Mayastor instances to use non-overlapping controller ID
ranges thereby allowing the initiator to connect to same nexus over
multiple paths.
Add a mocha test to test_nexus to verify that the specified controller
ID range is used when sharing the nexus over nvmf.

Could you explain how it is supposed to be used by control plane? I would assume that the control plane would create multiple nexus instances with non-overlapping controller id ranges.

Yes, exactly that. The control plane will be responsible for assigning the non-overlapping ranges.

Can controllers of unrelated volumes still have the same controller id?

Yes, the controller ID only needs to be unique within the same NVMe subsystem.

bors merge


Erro With Complex Variables

If I define a variables as a complex number, like var=8i, when I try to use this variable the result always show NaN.

Please try this.
Uninstall
Remove .zip and install
app-release.apk.zip

Should work now. Please try.
Uninstall
Remove .zip and install
app-release.apk.zip


Update Posts “live-photo-editing-and-publishing-workflow”

Automatically generated by Netlify CMS

👷 Deploy Preview for benevolent-muffin-215770 processing.

Name
Link

🔨 Latest commit
fd7b74448ce1dc80ef01274cacd5d85e3c2e2eaa

🔍 Latest deploy log
https://app.netlify.com/sites/benevolent-muffin-215770/deploys/628490bb06d65a0008276477


Adding yml for Linux builds

PR Summary
As part of improving the build process, the UI build pipeline for Linux Builds was converted to a yml-based pipeline.
PR Checklist

[X] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[X] Summarized changes
[X] Change is not breaking
[X] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[X] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

User-facing changes

[X] Not Applicable
OR
[ ] User-facing Documentation needed

[ ] Issue filed - Issue link:

Testing - New and feature

[X] Not Applicable or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

[ ] Add [feature] if the change is significant or affects feature tests

maybe move the file to a subfolder (in the same location as the file) called azureDevOps


Fix URL uploads to use name in URL when forwarding to util server

Summary

We were getting 500s calling UDIS with an URL due to our attempt to use the file field's name which will not be set in the request when only a URL is specified.
Note that we need the file name, because in the case where we receive an URL, we send the contents of the request via a multi-part form to the utility server.

Other Notes

I'm considering creating a card to just do the download in the utility server, no reason to pass all of this data I think if ti's only needed in the util server?

Testing
Ran locally using docker-compose and successfully ran using publicly available URL

Looks great! Does it work? :)

I tried testing the gene-list test file I have as both a URL and a file, so at least that file works.
I'm realizing that https doesn't work which is probably an issue...I'll look into that.


Finding the pet Game - MVP

This PR represents an MVP of the game. The features are a history mode that contains the seed of a much larger game (which can be expanded with much more time) and a free mode that the player can play just to have as many points as possible.

All the phases have different enemies, platforms, and backgrounds.
The API works for either showing the score (the top 14) or posting it.
It has a bonus of extra jumps that is managed by a logic. If you are playing in the free mode, you always get three. Otherwise, it depends on the story.
You can toggle the sound, on and off.
The score increases for 5 points every 2 seconds.
There is a timer, in which you need to survive to get to the next phase.
The score persists until you go to the main menu or the free phase.

In my initial objectives, I had a much larger story in mind, with more phases, more bonuses. However, during the time constraint, I could not archive most of those details. The goals of the gameplay were all fulfilled, as of the ones related to the main logic. What I build was a firm blueprint that can easily be expanded.
This project was quite hard, especially that I needed to figure out by myself a whole library (that is easily close to react in terms of depth and size). I lost tons of time figuring out basic functionalities, especially on the third day. Had I have some exposure to phaser prior to that, I would be able to archive a much more solid product.
I am still happy with the result since it is quite a fun game to play.
Looking forward to suggestions for improving the project
ps - if it freezes on the preload screen, just refresh it.

Fixed the following errors:

There are no more get errors (they came from an old import that I forgot to remove).
The tests now work (I was missing some dependency).

Looking forward for the next review.


ID property for all RDF objects

The new spec introduced an ID for every WADM node, some kind of representing the URI. The ID can be extended with already known fragments, like "#xywh=2,2,2,2".
I think this is nice, we can differentiate and use our own thing for the IDs, and not "care" about the node URI itself.

I think the ID property is only used for the JSON-LD serialisation. It matches the use of our Resource for every ResourceObject.


Bundle of patches for WMAgent 1.4.7.patch1

1.4.7_wmagent branch version of:

Changes in Slice 17 are causing #10381 #10443
Force cmsweb-prod in DBS3Reader #10444
Temporarily stop staging out log tarball to CASTOR - wmagent 1.4.5 branch #10255

@todor-ivanov FYI

Thanks  for tagging me @amaltaro !

 Fix #10449 - Bundle of patches for WMAgent 1.4.7.patch1


Implement Codey models

Resolves #175

Implement Codey API models
Fix chat-bison issue -> chat-bison uses ChatModel not TextGenerationModel
integration tests: updated google auth workload identity provider and service account

@dinuja9 add context to the start_chat() functions

Is this error something to do with the google project ID, or application credential key?

Yes, you probably have outdated credentials. I sent you the updated ones

Is this error something to do with the google project ID, or application credential key?

Yes, you probably have outdated credentials. I sent you the updated ones

yup, it works now, thanks!


mongodb-4_2: 4.2.19 -> 4.2.24

Description of changes
MongoDB 4.2 is still used by the unifi applications and had security patches.
I've tried bumping 4.4 as well, but the boost 1.79 patch does not apply, so that'll take more work.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

This error existed before though. You can probably remove the Darwin patch and make meta.broken = stdenv.isDarwin;

It seems this only happens because there is no relevant config generated - I believe it only affects aarch64-darwin.
Then again, in mongodb.nix:188, platforms = subtractLists systems.doubles.i686 systems.doubles.unix; makes it seem like it only supports i686..

According to the supported platforms list only 6.0 and up works on M1 machines.

Result of nixpkgs-review pr 222045 run on x86_64-linux 1

1 package built:

mongodb-4_2

I added a small fix to let it compile for aarch64, otherwise I can't get my unifi controller updated.
When I tackle the later mongodb versions, I'll add the same patch, didn't wanna do it here.


SAK-45734 Rewrite the 'Account Validator Tool' from RSF to Thymeleaf.

· Set Thymeleaf as template engine.
· Improve UI.
More info and Testing Doc on: Jira SAK-45735

What's the state of this PR? Is it ready for review?
It presents conflicts right now.

What's the state of this PR? Is it ready for review?
It presents conflicts right now.

Conflict solved. It is ready for review.

I tested locally and doesn't work for me, when I'm trying to verify my account throws a JS error:


devicelab_benchmark pool benchmarks are broken and not reporting results

A few months ago, several benchmarks were moved from prod to a new pool here:
https://ci.chromium.org/p/flutter/g/devicelab_benchmark/console#
This was with the understanding that the benchmarks would continue to report their results to SkiaPerf, and that the Engine sheriff would be notified when the benchmarks are failing. It looks like neither of those is happening.
We need to either keep these benchmarks working with proper notifications on failure, or move them back to prod.

These haven't been reporting results to SkiaPerf since late October: https://flutter-flutter-perf.skia.org/e/?begin=1634679481&end=1635992134&queries=test%3DLinux_android_flutter_gallery__transition_perf&requestType=0

This is strange. Checking why they stopped reporting benchmarks.

Tests have been running successfully: https://ci.chromium.org/p/flutter/g/devicelab_benchmark/console?limit=200, but they just skipped uploading metrics to skia perf.
From properties, we do see "upload_metrics": true,: https://ci.chromium.org/ui/p/flutter/builders/staging/Linux_android flutter_gallery__transition_perf_e2e/852/overview

https://flutter-review.googlesource.com/c/recipes/+/19561 updated the recipes to use property git_branch, which is not enabled in staging configs. This caused the benchmarks to skip upload.

https://flutter-review.googlesource.com/c/infra/+/24360 to add the git_branch property.
BTW: we are planning to separate all benchmarks from other tree blocker tests in Q1, this way, all benchmarks are expected to run in prod pool.

Benchmarks that are not consistently above the flaky threshold should still block the tree when they fail.

Benchmarks that are not consistently above the flaky threshold should still block the tree when they fail.

Yeah, a smart logic should be enforced here. For example, if a benchmark consistently fails like 2 or 3 times, it will close the tree.

Metrics are being picked up: https://flutter-flutter-perf.skia.org/e/?queries=test%3Dflutter_gallery__transition_perf_hybrid
Mac/ios breakage is being tracked in https://github.com/flutter/flutter/issues/95272

Mac/ios bots are back, and are running tests with success.
Results are being reported to Skia perf.
https://ci.chromium.org/p/flutter/g/devicelab_benchmark/console#
The final action to move them back to prod will be planned in Q1.
The remaining action here is add notification alert when these tests fail while still running in staging.
Adjusting the priority to P3.

Alert was implemented in https://flutter-review.googlesource.com/c/infra/+/24740, and is working as expected. Closing here.


Add testing via playwright on successful build to ensure no frontend issues

When the site builds there is always the potential that some link or other problem arises. If we add playwright tests we can ensure that our links are valid and that changes in the future behave as expected.
To create
Create a github action that installs playwright and runs the playwright tests.
For python you can install and run playwright
python -m pip install playwright pytest-playwright
python -m playwright install --with-deps
python -m pytest

See #17

Further Steps
Frontend testing should be enabled to test that links in the header are consistent when the language is set.


Fix release notes formatting

As per https://github.com/pydata/xarray/pull/4440

I'm not sure why tests seem stuck. Going to merge given the minimal changes

each CI takes up 30 minutes to complete, and since we only have 10 workers available they take quite a while to complete in case there are lots of CI runs. Most of the time is spent on the tests (we might be able to reduce the time spent there – in test_units, maybe?), but conda seems to also take up between 1 to 10 minutes.

We could use pytest-xdist but it breaks on test_sparse.py


[SPARK-37616][SQL] Support pushing down a dynamic partition pruning from one join to other joins.

What changes were proposed in this pull request?
Introduce a rule to handle pushing down a dynamic partition pruning from a child join to its parent join, when the following conditions are met:
(1) the pruning side of the parent join is partition table
(2) the table to prune is filterable by the JOIN key
(3) the parent join operation is one of the following types: INNER, LEFT SEMI,
LEFT OUTER (partitioned on right), or RIGHT OUTER (partitioned on left)
A query example:
SELECT f.store_id, k.units_sold
FROM fact_stats f
JOIN dim_stats d
    ON f.store_id = d.store_id
        AND d.country = 'NL'
LEFT JOIN fact_sk k
    ON f.store_id = k.store_id

Before the PR:

After the PR:

Why are the changes needed?
Push down a dynamic partition pruning from one join to other joins to prune the table of other joins  to improve performance.
Does this PR introduce any user-facing change?

No.
How was this patch tested?
Added unittests.

Can one of the admins verify this patch?

cc @maryannxue @cloud-fan kindly review, thanks.


Disallow marking shards as available before cutover, Disallow reverting after cutover

Moved MarkShardAvailable to algo interface
Check current time before marking shards as available
@xichen2020 @prateek @jeromefroe

Coverage increased (+0.2%) to 84.324% when pulling 215adf40eaeae5261923f509c66111e78d474722 on chao-not-revert-after-cutover into 5a29979ec2d26c8c7c7d3274d3c5ffdc1e9fcb40 on master.

Coverage increased (+0.1%) to 84.245% when pulling 215adf40eaeae5261923f509c66111e78d474722 on chao-not-revert-after-cutover into 5a29979ec2d26c8c7c7d3274d3c5ffdc1e9fcb40 on master.

Coverage increased (+0.1%) to 84.233% when pulling deae3acca0dc75282a9a89972850d181729d83a4 on chao-not-revert-after-cutover into 5a29979ec2d26c8c7c7d3274d3c5ffdc1e9fcb40 on master.

Coverage increased (+0.09%) to 84.201% when pulling fcbc3c24c2a90b3378ae945939ff047503011da0 on chao-not-revert-after-cutover into 5a29979ec2d26c8c7c7d3274d3c5ffdc1e9fcb40 on master.

Coverage increased (+0.2%) to 84.275% when pulling 0269c82cb5e4bb422bd8472ccb0c0814eda8fb44 on chao-not-revert-after-cutover into 5a29979ec2d26c8c7c7d3274d3c5ffdc1e9fcb40 on master.

Also seems TestWatchAndAtomicUpdateBool is timing out?

Coverage increased (+0.3%) to 84.314% when pulling 88f78fbb6043165adac3b758eeaf8e4596e26982 on chao-not-revert-after-cutover into c21b6888de7d981983aa8b82a9ffe1d96e84367f on master.

Coverage increased (+0.2%) to 84.205% when pulling ef3207710c81005dd2297a1d70045063206daf1b on chao-not-revert-after-cutover into c21b6888de7d981983aa8b82a9ffe1d96e84367f on master.

Seems like a previous fix on TestWatchAndAtomicUpdateBool got reverted, fixed it again

Coverage increased (+0.1%) to 84.192% when pulling b0f994d0ae51cd137c67f6adbf17353799cccaab on chao-not-revert-after-cutover into c21b6888de7d981983aa8b82a9ffe1d96e84367f on master.

Coverage increased (+0.1%) to 84.192% when pulling 72deb46e773fda4d60e7caebde3698e198bca431 on chao-not-revert-after-cutover into c21b6888de7d981983aa8b82a9ffe1d96e84367f on master.


Allow lens input/output types to be unsized

They're only handled by reference, so this seems like a free genericity win.

Cool, I can definitely imagine cases where we would want this.

I'm assuming you found a use for this?

I was experimenting with implementing a lens combinator for indexable containers and found I had to specify <T as Index>::Target: Sized to get anywhere, which mainly just seemed unnecessary, though it's possible to imagine cases where it would have been a real obstacle.


The relevance sorting does not work

@baimingze The relevance sorting does not work

"{"diagnostics":{"message":"The sort field id 'relevance' does not exist."}}"
Ebeye search comes for the field named "relevance", it is not same as we thought before.

I 'd removed the "relevance" sorting option from browse page. After we get this through from EBeye search, I think we can add it back.


Support custom start-command/start-options on GHA container runner and openssl1.1.1 on AL2 docker images

Description
Support custom start-command/start-options on GHA container runner and openssl1.1.1 on AL2 docker images
Issues Resolved
https://github.com/opensearch-project/opensearch-build/issues/5178
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

https://build.ci.opensearch.org/job/docker-build/6031/console


How to use it?

Could you give a sample for test?
I really don't know how to use it!

+1 Does this only work with Fomtastic?


Most of the visitors are showing up as Unknown in the countries

I deployed Umami a few hours ago and is using in production for one of the sites. The countries are not populating as expected, most of them are showing up as Unknown.

See #814. You have need to use a custom header value.