Search SDK: [SerializePropertyNamesAsCamelCase] not converting property names to camel case while indexing documents.

Hi,
While indexing an upload batch using the SearchIndexClient, I am getting the following exception:
The request is invalid. Details: parameters : The property '**Keywords**' does not exist on type 'search.documentFields'. Make sure to only use property names that are defined by the type.
The problem is that its looking for "Keywords" when it should be looking for "keywords".
Note:

The class that was used to define the index (using FieldBuilder) is being used to create the documents. This class has the [SerializePropertyNamesAsCamelCase] attribute.
I was able to create the index successfully. The index fields are in camel case (Checked it on the Azure portal).
I was able to index the documents by manually changing the class properties names of the class to  camel case and running the code again after the index was created.
I'm using version "3.0.5" of the Microsoft.Azure.Search nuget.

Is this a known bug or am I missing something?
Thanks.

@abishekreddy Thanks for reporting this; we'll investigate. In the meantime, would it be possible for you to share a minimal repro of the issue?

@abishekreddy It might also be relevant to know what version of Newtonsoft.Json your application is using.

@abishekreddy I'm unable to reproduce this issue. Can you please let me know what version of Newtonsoft.Json you're using, or even better, provide a minimal amount of code to demonstrate the issue?

@abishekreddy Since I can't reproduce this and I haven't heard from you in over a week, I'm closing this issue.

Code Snippet:
public abstract class AzureSearchDocument
{
	[Key]
        [IsFilterable]
        public string Id { get; set; }
}

[SerializePropertyNamesAsCamelCase]
public class Article: AzureSearchDocument
{
        [IsSearchable, IsFilterable]
        public string[] Keywords { get; set; }
}

var definition = new Index()
{
	Name = indexName,
        Fields = FieldBuilder.BuildForType<Article>()
};
var serviceClient = new SearchServiceClient(serviceName, new SearchCredentials(adminApiKey));
await serviceClient.Indexes.CreateAsync(definition).ConfigureAwait(false);

var documents = new List<Article>();
foreach(var article in articles){
	var document = new Article();
	document.Id = article.Id;
	document.Keywords = article.Keyworkds;
	documents.Add(document);
}
var batch = IndexBatch.Upload(documents);
var indexClient = new SearchIndexClient(serviceName, indexName, new SearchCredentials(queryApiKey));
indexClient.Documents.Index(batch);

Newtonsoft nuget version: 10.0.3

Thanks @abishekreddy. Re-opening the issue.

The issue was that the [SerializePropertyNamesAsCamelCase] attribute wasn't on the AzureSearchDocument class whereas the method that had the batch index and upload calls was expecting an IEnumerable.

@abishekreddy Ah, that makes sense. Thanks for following up. Closing this issue.


Revert "removing Board.ends()"

Reverts abw333/domino#16

reverting to undo the replacement of add_left and add_right with add


Make aliases available to be used by providers

This is a feature request to make aliases information available to be used by providers.
The use case is Marverl's Agents of S.H.I.E.L.D in LegendasTv provider.
Legendas.TV website data is not consistent. Some Marvel's series doesn't have Marvel's in their name, others do. Some of them use Marvels, others use Marvel's.
MAoS can only be searched using its alias: Agents of S.H.I.E.L.D
http://legendas.tv/legenda/sugestao/agents of s.h.i.e.l.d
Using its official name Marvel's Agents of S.H.I.E.L.D returns no result
http://legendas.tv/legenda/sugestao/marvel's agents of s.h.i.e.l.d
But Marvel's Jessica Jones can be search using the official name:
http://legendas.tv/legenda/sugestao/marvel's jessica jones
My suggestion is to enrich the video object with aliases information when running tvdb refiner, so any provider can make use of them when needed (e.g.: when no series search result is found)

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/33973777-make-aliases-available-to-be-used-by-providers?utm_campaign=plugin&utm_content=tracker%2F321252&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F321252&utm_medium=issues&utm_source=github).

this will be good at Medusa/SickRage because we store scene exceptions for each show

A similar use case would be aliases for release groups.
Certain subtitles of 1 release group will always be in sync with another release group (example: LOL and DIMENSION)
If aliases could be defined on release group level, it would also improve the matching.
This is certainly useful where subliminal is used in library mode and certain criteria must match before a subtitle is downloaded. If for example a subtitle is available under 'LOL' but the not under 'DIMENSION', it would be nice that 'DIMENSION' is also matched for 'LOL'.
So making it possible to provide 'aliases' for certain video fields would be a good idea.
@ratoaq2 If you think it's not related to your case, I'll create a separate issue for it :wink:

Yes please create a separate issue for release groups. This should be done in scoring I think with some exception logic. Alias is overkill here and cannot cover all the possibilities.
As for making the aliases available, that's a good idea indeed. Some properties like alternative_titles for Movie and alternative_series for Episode would do I think.

Are aliases unique? I don't want to flood the servers with 5+ aliases searches that will sometimes end up returning no result.
I'm not sure subliminal needs fixing here, the provider does. At least a search should return the correct series.

The providers will unlikely be changed (e.g.: legendastv website).
I didn't check tvdb to see how often series have aliases.
Subliminal providers could make use of aliases only when no series/tv show information is found using the main/official title. That way it will not flood the servers and it will handle these exceptional cases.

the aliases are also for scene releases. We call that scene_exception in sickbeard/Medusa
like: TURN: Washington's Spies and TURN


[NoQA] fix: e2e results not being posted

Details
The original problem was introduced in this commit: https://github.com/Expensify/App/commit/9ab0ea3d31d145d46b7e7be19566a9921a1f395c and discussed in https://expensify.slack.com/archives/C06JLFDLLUX/p1719331814757719
We were following early return principle - in this case when we have both baseline + current we would calculate diff and finish execution of the test. But in the commit above that rule was broken, and if both properties are present, then we would go to the all if statements and overwrite the output in each if-statement (and this is actually incorrect, because in this case we don't attach 🔴 and CI pipeline never detects 🔴 and will never post test results).
To be sure such problem is not getting introduced again I added new unit test.
Fixed Issues

$ N/A
PROPOSAL: N/A
Tests

[ ] Run e2e pipeline and be sure comment gets published indicating that performance changes were detected;

Offline tests

N/A
QA Steps

N/A
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@hannojg may I ask you to review these changes? 👀

Almost perfection 😄 the jest tests seem to be broken now 🙇

@mountiny may I ask you to have a look on this PR too? 👀

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.0.6-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
failure ❌

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.0.6-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.0.6-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
failure ❌

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.0.6-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.7-8 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Alter bean don't return my exception

I have a exception for register database not found ResourceNotFoundException and I use spring @ControllerAdivice to intercept this exception, but using FF4J the throw exception is InvocationTargetException, I think is necessary a propertie to callAlterBeanMethod return the InvocationTargetException or return invocationTargetException.getCause(). It's make sense? thanks.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/32103933-alter-bean-don-t-return-my-exception?utm_campaign=plugin&utm_content=tracker%2F1038413&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F1038413&utm_medium=issues&utm_source=github).

I think that FF4J try to invoke the alterBeanMethod by introspection. As the alterbean is Proxified with an advice i have some issue to invoke it. Could you give some materials to help me reproduce this (and correct).

@clun I show you my case:
public Order getOrderByFilter(final Long id) {
....
if(isNull(order)) {
throw new ResourceNotFoundException(emptyList());
}
...
}
The throws exception is InvocationTargetException not my exception ResourceNotFoundException.
I can solve this problem and submit a Pull Request?

Sure ! you are more than welcome to make some Pull requests. Even is not 100% backward compatible I will write something into the release note but i understood that the signature is not changed.
I you create a PR i woull integrate quickly to 1.4.1.


Creating Fate Core sheets for Brazilian Portuguese

New Character Sheet for Fate Core in Brazilian Portuguese

I'll merge this in but the image you have is the english picture. You might consider swapping that.

Any tip on how to create new images?


Microsecond timeout support

Hello Michal,
I added support for microseconds timeout to allow for more precise configuration. I added some tests to make sure everything works.
I also took the liberty to add development autloading for tests as it doesn't work nicely with IDE's otherwise.
Looking forward to your feedback and seeing it integrated into the library.
Kind regards,
Ghlen

Thank you for the feedback! I made the necessary changes now. Hope everything is all right now :crossed_fingers:


Is this paper getting accepted?

Hi, thank you for your great work. I am just wondering if this paper has been accepted by a conference or journal?

Hi, thanks! it is under review now.

Thanks, I hope your work get accepted!


Added feature mentioned in issue #1695

Description
vec and flatten both gain the option order as an optional argument, allowing a change of ordering from Fortran to C, if desired.
Issue link: https://github.com/cvxpy/cvxpy/issues/1695
Type of change

[x] New feature (backwards compatible)
[ ] New feature (breaking API changes)
[ ] Bug fix
[ ] Other (Documentation, CI, ...)

Contribution checklist

[x] Add our license to new files.
[x] Check that your code adheres to our coding style.
[x] Write unittests.
[x] Run the unittests and check that they’re passing.
[x] Run the benchmarks to make sure your change doesn’t introduce a regression.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

This is good! You should add tests as well, maybe in test_atoms.py.

ping @Brown2345

@rileyjmurray I added tests and doc-strings.

Thanks, merging in!


OpenGL 3.30 not supported by craft

I have tried everything
but when I attempt to use opengl 3.3 I get:
glCompileShader failed:
0:1(10): error: GLSL 3.30 is not supported. Supported versions are: 1.10, 1.20, 1.30, 1.00 ES, 3.00 ES, 3.10 ES, and 3.20 ES

It's not OpenGL 3.3 not supported by craft, actually, the build does not support GSLS 330, and if you built it yourself, it means your computer does not support OpenGL 3.3

Do you mean OpenGL 3.30 is supported by Craft?

@crazyBaboon FYI, static shadows where already implemented in the shadow branch, probaly following the tutorial you linked or something similar.
I think you're probably missing to define GLFW_INCLUDE_GLCOREARB:
#define GLFW_INCLUDE_GLCOREARB
#include <GLFW/glfw3.h>

like Fogleman did in his branch shadow/main.c#L1
Also, if you are a MacOS user you still may have to explicity use in you code:
glfwWindowHint(GLFW_CONTEXT_VERSION_MAJOR, 3);
glfwWindowHint(GLFW_CONTEXT_VERSION_MINOR, 3);
glfwWindowHint(GLFW_OPENGL_FORWARD_COMPAT, GL_TRUE);

If after all of this you still get the error it might be you have an old OpenGL version.
I think I got the same error as yours when trying to run a GLSL 3.30 shader with OpenGL 3.0 (which supports up to GLSL 1.30):
GL version                     GLSL version
2.0                            1.10
2.1                            1.20
3.0                            1.30
3.1                            1.40
3.2                            1.50
3.3                            3.30
4.0                            4.00
4.1                            4.10
4.2                            4.20
4.3                            4.30
4.4                            4.40
4.5                            4.50

If you're interested here's a sample from the shadow branch:

@mpaoloni
Wow! I did not know that! Thanks!
How do I change the following:
git clone https://github.com/fogleman/Craft.git
cmake .
make
./craft

in order to compile the shadows branch?

For the sake of simplicity I would suggest cloning that single branch only (not the whole repository), like this:
git clone --single-branch -b shadow https://github.com/fogleman/Craft.git

then proceed like usual:
cd Craft
cmake .
make
./craft

IIRC on Linux i had some errors when compiling that branch. If you have any post here the output I can try to help.

Thanks @mpaoloni ! However, when I do make I get the following error:
[  3%] Building C object glfw/src/CMakeFiles/glfw.dir/clipboard.c.o
In file included from /home/p/Documents/Craft/glfw/src/x11_platform.h:52:0,
                 from /home/p/Documents/Craft/glfw/src/internal.h:69,
                 from /home/p/Documents/Craft/glfw/src/clipboard.c:27:
/home/p/Documents/Craft/glfw/src/glx_platform.h:95:5: error: unknown type name ‘pthread_key_t’
     pthread_key_t   current;
     ^~~~~~~~~~~~~

Do you know how to fix this?

That error in particular I solved it updating the GLFW library. However at the time I also had to do other things (i.e. adding GLEW statically). I don't remember every single thing I did because I also updated the dependencies and reorganized the project structure.
I found the working copy I had, and pushed it to my cloned repo: https://github.com/mpaoloni/Craft
The changes mentioned are in the shadow branch.
To clone it, as always:
git clone --single-branch -b shadow https://github.com/mpaoloni/Craft.git

then:
cd Craft
cmake .
make
./craft

I also noticed you, like me, are running OpenGL version string: 3.0 Mesa 18.0.5. Which means once compiled and run, you'll get the error:
glCompileShader failed:
... GLSL 3.30 is not supported. Supported versions are: 1.10, 1.20, 1.30, 1.00 ES, 3.00 ES, 3.10 ES, and 3.20 ES

Not sure how to resolve it (maybe switching to other drivers? not Mesa?). But since I have Windows with OpenGL 4.4 I cross-compiled it on Linux for Windows at the time.
To do this I added an option for Windows64 with cmake (inside CMakeLists.txt):
cmake -DWINDOWS=ON .

Note that to do this you'll need MinGW installed on Linux. If you have 32 bit you can change the paths inside CMakeLists.txt accordingly:
set(CMAKE_C_COMPILER "/usr/bin/x86_64-w64-mingw32-gcc-win32")
set(CMAKE_CXX_COMPILER "/usr/bin/x86_64-w64-mingw32-g++-win32")
set(CMAKE_RANLIB "/usr/bin/x86_64-w64-mingw32-ranlib")

@mpaoloni Yep, it compiles fine on Xubuntu 18.04 using gcc 7.3.0. But when I try to run it:
glCompileShader failed:
0:1(10): error: GLSL 3.30 is not supported. Supported versions are: 1.10, 1.20, 1.30, 1.00 ES, and 3.00 ES

glCompileShader failed:
0:1(10): error: GLSL 3.30 is not supported. Supported versions are: 1.10, 1.20, 1.30, 1.00 ES, and 3.00 ES

glLinkProgram failed: error: linking with uncompiled/unspecialized shadererror: linking with uncompiled/unspecialized shader
glCompileShader failed:
0:1(10): error: GLSL 3.30 is not supported. Supported versions are: 1.10, 1.20, 1.30, 1.00 ES, and 3.00 ES

glCompileShader failed:
0:1(10): error: GLSL 3.30 is not supported. Supported versions are: 1.10, 1.20, 1.30, 1.00 ES, and 3.00 ES

glLinkProgram failed: error: linking with uncompiled/unspecialized shadererror: linking with uncompiled/unspecialized shader
glCompileShader failed:
0:1(10): error: GLSL 3.30 is not supported. Supported versions are: 1.10, 1.20, 1.30, 1.00 ES, and 3.00 ES

glCompileShader failed:
0:1(10): error: GLSL 3.30 is not supported. Supported versions are: 1.10, 1.20, 1.30, 1.00 ES, and 3.00 ES

glLinkProgram failed: error: linking with uncompiled/unspecialized shadererror: linking with uncompiled/unspecialized shader
Segmentation fault (core dumped)

The output to glxinfo | grep OpenGL in my Xubuntu box is:
OpenGL vendor string: Intel Open Source Technology Center
OpenGL renderer string: Mesa DRI Intel(R) Sandybridge Desktop
OpenGL core profile version string: 3.3 (Core Profile) Mesa 18.0.5
OpenGL core profile shading language version string: 3.30
OpenGL core profile context flags: (none)
OpenGL core profile profile mask: core profile
OpenGL core profile extensions:
OpenGL version string: 3.0 Mesa 18.0.5
OpenGL shading language version string: 1.30
OpenGL context flags: (none)
OpenGL extensions:
OpenGL ES profile version string: OpenGL ES 3.0 Mesa 18.0.5
OpenGL ES profile shading language version string: OpenGL ES GLSL ES 3.00
OpenGL ES profile extensions:

Whoops. So I found the issue...
On Linux it still requires setting up the OpenGL context (commit b1d16cd):
#if defined(__APPLE__) || defined(__linux)
    glfwWindowHint(GLFW_CONTEXT_VERSION_MAJOR, 3);
    glfwWindowHint(GLFW_CONTEXT_VERSION_MINOR, 2);
    glfwWindowHint(GLFW_OPENGL_FORWARD_COMPAT, GL_TRUE);
    glfwWindowHint(GLFW_OPENGL_PROFILE, GLFW_OPENGL_CORE_PROFILE);
#endif

Doing so, however, it would make the program crash on my Linux machine.
Until I realized I didn't update GLEW to the latest version (2.1.0), despite updating GLFW.
Now it works without any issue ^^; I pushed the changes to my shadow branch.

Thank you so much! It works amazing on GNU+Linux now!
Hopefuly @fogleman  will merge this!


'flat' name better than 'deshape'??

it's written: "It looks like ♭ because it flattens the array.", how about actually naming it that way?
As i think "flattening" is a fairly common concept which comes in other prog langs, and also in digital tasks involving layers (image editing etc).
https://www.uiua.org/docs/deshape
https://github.com/uiua-lang/uiua/blob/56c151fb6058b4669adf8a55eb3151988194d35d/src/primitive/defs.rs#L512-L515

I'm for keeping it as "deshape" in the name of consistency; only needing to type "desh" or "resh" for deshape/reshape is easy to get used to because it's just a one letter difference on two functions that I'd venture to guess are pretty commonly used. Making some sort of alias for it where typing flat still turns it into ♭ might be worth implementing if there's not a common consensus on this (if you really want to go all out, reshape could be represented as a sharp ♯; the resemblance between the symbol and what the function does is there, I suppose).


Async format file

Currently this plugin sync format file, so if we have it auto do the job on save, it will hold interface a bit to do the job. We need to do it async to avoid block the UI.

It can be done, but it requires a complete rewrite of the code. As such, it doesn't fall within the scope of this project. If someone wants to go through the hassle of implementing it, it should be a separate project.


add support for c5d.12x/c5d.24x/c5d.metal

Issue #, if available:
Description of changes:
Adds support for new c5d instance types
https://aws.amazon.com/blogs/aws/now-available-new-c5d-instance-sizes-and-bare-metal-instances/
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

It looks like the CNI PR was merged. Is there anything still required to get this merged?

@normanjoyner Nothing is blocking this PR, but please note that there is not yet a CNI released that has the added instance types. You would have to check out and build one yourself to use these instance types. They will definitely be in the next release though.


Support configurable, non-uniform, visually aligned tab stops

I would like to raise the issue of configurable tab stops.
A proposal has been floating around the web for a few years, called Elastic tabstops, that promises to usher in the "next generation" of source code alignment.
It aims to make it easy to align code blocks and side comments, both for traditional coders using monospaced fonts, and for those of us who prefer proportional fonts.
It would also make it easy to edit tabular data, be it TSV (tab-separated values) or a table in Markdown or other markup languages.
I would gladly write an extension myself to realize elastic tabstops, but unfortunately it's one of those things that require a very specific feature in the editor component: the ability to specify non-uniform tab stops, as a list of visual positions (eg. pixel or em, not characters) that may be different for each line.
Right now the tab support in Atom is just a trick (a span with a certain number of blank characters), it's not even a true tab stop, as is painfully evident when using a proportional font:

Seeing as work is currently underway to write the newer React-based editor component, I just wanted to throw this feature request out there to the clever people writing such code.
I'm fully aware that it is not a simple task, because it transcends the character-counting nature of the current code. Doing it without triggering a reflow for each tab stop (to query the current width of the line being composed) is even harder. It would require pre-caching the em-width of every character for the current font, or something along those lines.
But it's one of those features that would set Atom apart from any other editor.
Again, the tricky part is just the configurable tab stops. That would allow extension writers to align code, tables, and other data with various algorithms, including Elastic tabstops.

+1

@hax did you get anything working out of that?

I just release an an experimental implementation: https://atom.io/packages/elastic-tabstops
NOTE: Elastic tabstops is not easy to implement as a plugin, because it need
touch the core features of the editors. That's why it have little support in mainstream
IDE/editors. I'm still investigating the inner mechanism of Atom. Any kind of suggestions or help are welcome!

wow, great! i didn’t expect anything to happen anymore, and put this on my “eventually do” list.
you’re great, thank you! :fireworks:

pre-caching the em-width of every character for the current font, or something along those lines.

For the record, this is trickier than stated, because of kerning, ligatures, contextual substitutes and other OpenType features some of us actively use.

yeah, sounds hard for non-monospace fonts.
maybe a fast-path for monospace fonts would help? although one of the advantages of elastic tabstops is that you won’t need monospace fonts anymore.

It seems Atom core already have pre-cached measurements (with the help of document.createRange().getBoundingClientRect()), I just need to find a way to hack it to fix current cursor bug of my implementation.

this is still wanted

can you pin this?

no

I don't know enough about the internals of the editor to know if what I am proposing would work, but I hope it might help.
Maybe, to improve the support for hard tabs and non-uniform tabstops, tabs could be aligned using css. What I am proposing is that the editor should put the text and the tab following it inside a span (so, for example: tabtext tab), and then give a class to the span, of which the width woud be specified in the css (or simply including the width in the span directly, depending on which is simpler and cleaner), depending on the tabstop that should be used (the width being the first tabstop following the end of the text, minus the tabstop of the previous text+tab span). This would, I think, fix the problem present with tabs when used with proportionally-spaced fonts, and would make it much easier to implement non-uniform tabstops afterwards.


Error 110 - attempting to use BasicVideoCallScene

Unity Version: 2021.3.13f1
Agora Video SDK for Unity Version: <IP_ADDRESS>
Hello - I'm simply attempting to run the BasicVideoCallScene but am getting this error.
OnError err: 110, msg:
UnityEngine.Debug:Log (object)
Agora.Util.Logger:UpdateLog (string) (at Assets/API-Example-Unity/Assets/API-Example/Tools/Logger.cs:17)
Agora_RTC_Plugin.API_Example.Examples.Basic.JoinChannelVideo.UserEventHandler:OnError (int,string) (at Assets/API-Example-Unity/Assets/API-Example/Examples/Basic/JoinChannelVideo/JoinChannelVideo.cs:227)
Agora.Rtc.RtcEngineEventHandlerNative/<>c__DisplayClass2_0:<OnEvent>b__0 () (at Assets/Agora-RTC-Plugin/Agora-Unity-RTC-SDK/Code/Impl/Private/Observer/RtcEngineEventHandlerNative.cs:37)
Agora.Rtc.AgoraCallbackQueue:Update () (at Assets/Agora-RTC-Plugin/Agora-Unity-RTC-SDK/Code/Tools/AgoraCallbackQueue.cs:53)

I'm not sure if this is related to the Token field in AppIDInput? I'm not really sure what that is about.

OK I think I figured it out. It seems like the token is required for video, in addition to the AppID. The token can be found in the dashboard at Project, Features Section, 'Generate Temp RTC Token'. Not sure why this crucial bit of information is excluded from the readme.


Feature Request: Ability to pick source IP address

I have a use case where I need to specify an outgoing IP address. Currently etcd does not support ability to pick outgoing IP address.
On a system with multiple IP addresses, I would like to be able to specify the exact IP address for outgoing client connectivity.

I think this is out of etcd scope. Peer traffic can be controlled though through host-whitelist flag https://github.com/coreos/etcd/blob/master/CHANGELOG-3.4.md#security-authentication. You can still limit access with auth + TLS. And there are many other lower level linux tools to achieve outbound traffic. Please create a separate issue if you have other valid use cases. Thanks.


WereDev.Wu10Man version <IP_ADDRESS>

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@ItzLevvie, now that you approved it, what additional review/approval is it waiting for?


OIDC login and parallel job matrix

Hi!
I have a buildmatrix defined and in every one of the resulting jobs, az cli OIDC auth is used for the same principal using the azure/login@v1 action.
From the looks of it, this is an unsupported scenario. Only the job that started last will have a valid token and the rest is invalidated.
My repro is simply using az acr login. I get CONNECTIVITY_REFRESH_TOKEN_ERROR when running in parallel. And works fine when max parallel is set to 1.
Any way to work around this?

Turns out the problem actually lies with ACR updates running in parallel, blocking token exchange.. Sorry for posting this wrongfully


Feature suggestion: Migrations

What do you think about migrations-support?

Hi Michael
Of course migrations support would be great.
I have not much Experience with entity framework, but as fare as I know the EF Migrations mechanismus consists of two parts.

MigrationSqlGenerator
This class must be implemented. It will generate the SQL statements based on the commands. Which means this class needs to know how to tread a CreateTable() which is used in a migration.

MigrateDatabaseToLatestVersion<TContext, TMigrationsConfiguration> Class
Normally you would use this initializer to use migrations. But as the code first stuff is done in a own initializer, this class could not be used. That means a) a own migrations class needs to be written or b) we find out what exactly the MigrateDatabaseToLatestVersionclass does and then just implement the necessary stuff (like create the History Table) so that the functionality of the MigrateDatabaseToLatestVersionclass could be reused.

It seams very complicated to me and may there is another way to do this.

I agree - it would be great, but it does not seem to be an easy task. It may be planned for a future release...

Migrations would be ideal, as that seems to be how EF is typically presented with Code First.
Is there some documentation on how to use EF with Code First but not with migrations?  Everything I find seems to discuss migrations (which requires the above-mentioned sql generator class). When I try running "update-database", it asks for the sql generator.  I'm sorry if this isn't the right forum for this question, but how do I use this project and SQLite without migrations?
I have this working as code-first (with migration) in SQL Server, but wanted to try SQLite, as the db is small and SQL Server is overkill.

Hi Gary

You can use EF without migrations. Have a look at the Code in this Repo, there is a sample Application.
You can not run "update-database" because there is no implementation for the SQL Generator.
See 1. Just delete your migrations may be an option, because the Model (Code) should be up to date.

I once tried to dive into EF and find out how the migrations are implemented.
But I was not able to create a own sql generator.
In the (Issue 16)[https://github.com/msallin/SQLiteCodeFirst/issues/16] HareIM posted a link with an implementation for such an sql generator. May you can try to use this: https://drive.google.com/file/d/0B-NCqWnMQpBrQjkxMkxnVlRzb00/view?pli=1

Thanks for the fast response, Marc!   I think I can probably live without the migrations with my small project, but the Sql Generator sounds intriguing.  I'll have a look at that and the sample code you  mention as time permits.
Working on this last night, I kept getting a zero-byte SQLite database generated, so I must be doing something wrong; it did not re-build a freshly seeded db as I would have expected.  Since I have been using SQL Server, it seems to hang on to that information somewhere.  When I run, it creates a zero byte SQLite db, but then runs off of the SQL Server db!  (I've commented-out the connection strings in the web.config for SQL Server, so not sure how it does that!)  I like how EF automates things, but I guess it also hides what it's doing. (In other work, I use DB-first, and I think that's best for larger projects.  I've had success working with that, so I've been tempted to go that route.)  If I continue to be stuck, I'll just start over with a "fresh" project and copy files over, to ensure that it only uses SQLite.
Thanks for clarifying things.

+1

I've got a working prototype for migrations. It was originally based on the prototype put together by Julio C. Borges in 2013, although significant further work was required. Several migration operations are currently not implemented, notably those ALTER TABLE operations which are not natively supported by SQLite (see https://www.sqlite.org/lang_altertable.html).
The code is not as clean or well-formatted as I'd like for issuing a pull request, so for the time being you can get it here:
https://github.com/zanyants/SQLiteCodeFirst/tree/feature/migrations
To use:
To your migrations Configuration class ctor, add:
SetSqlGenerator( "System.Data.SQLite", new SQLite.CodeFirst.SqliteMigrationSqlGenerator() );
And in your context's OnModelCreating add:
Database.SetInitializer( new System.Data.Entity.MigrateDatabaseToLatestVersion<MyContext, Migrations.Configuration>( true ) );

Hello Tom
Thanks for your work!
Currently I'm very busy and have not the chance to look through it in detail.
The formatting should not be the problem, R# will to the hard work ;)
It needs some refactoring but I'm glad to work together with you on this code.
I created a branch https://github.com/msallin/SQLiteCodeFirst/tree/Issue-4 you can create a PR to push your changes in this branch and then we can work on it.
Greetings Marc

Hi Marc,
I'm also rather busy - I should have time to do as you ask early next week.
Tom

If it is any consolation, EF7 hasn't gotten very far with this ... https://github.com/aspnet/EntityFramework/blob/dev/src/Microsoft.EntityFrameworkCore.Sqlite/Migrations/SqliteMigrationsSqlGenerator.cs#L149
http://ef.readthedocs.org/en/latest/providers/sqlite/limitations.html#migrations-limitations

@CADbloke thanks for the hint!
@tg73 What do you think, could we benefit from that?

More (actually, less progress but more discussion) from the EF team not getting far with SQLite migrations. This issue has links to a lot of other related issues in the EF7 project. It seems to be the main issue they are tracking on the matter.
https://github.com/aspnet/EntityFramework/issues/329

Any updates on this? I think it's almost the only open issue left... :-)

I was wondering how the fact that SQLite is supported using .Net Core and EF.Core would affect this issue. see here: https://docs.microsoft.com/en-us/ef/core/get-started/netcore/new-db-sqlite

I while ago I looked through the code (as its OSS :)) but I noticed thats not just "take and use".
There is still the started work from @tg73 (https://github.com/zanyants/SQLiteCodeFirst/tree/feature/migrations).
I think this is a lot of work to do and I'm currently not planning to work on it by my self.
I'm looking forward to invest some more time in spare time projects after I graduated as BSc. Still one year to go and I need my free time for the projects there.

I'm using @tg73 work and is working fine, with some adjusts on index names.

Apologies for my slow reply. The migrations work I did was done as part of
my employed work. It was a limited project and I've since moved on to
completely unrelated work, and unfortunately have no time allocated for
further SQLite/migrations work. I was keen to get my original work
contributed back to the community in case it was of use, and I hope it can
be taken further. I seem to remember getting to a point where the
limitations of SQLite required quite complex workarounds, possibly
requiring a lexer/parser of SQLite flavour SQL to properly support some
part of the migrations workflow.
On 1 March 2017 at 11:37, digocesar<EMAIL_ADDRESS>wrote:

I'm using @tg73 https://github.com/tg73 work and is working fine, with
some adjusts on index names.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/msallin/SQLiteCodeFirst/issues/4#issuecomment-283318146,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABDPfRb5Brn_1t7d3cKM9r22Bv0KvIzNks5rhViSgaJpZM4D1sY-
.

Maybe worth to have a look:
https://github.com/ericschultz/SQLiteParser

Hi @msallin
Excellent work on this Library! Love it!! I just tried to do an Add-Migration ... and realized that Migrations is not supported by this Library.
What's the point of using this for Code-First, if migrations is not supported. In any practical real-life project, the database is not just created 1 time and forgotten. It will undergo many changes during it's lifetime.
Any chance anyone else will be able to take this on?
Thank you!
-Shiva

The ASP.NET team are still onto this: https://github.com/aspnet/EntityFramework/issues/7969 as well as the previously mentioned https://github.com/aspnet/EntityFramework/issues/329
I have been thoroughly distracted by client work, those pesky rascals, so have been unable to dive into this. Yet. :(

I wrote "SqliteDropCreateAndMigrateDatabaseWhenModelChanges" class derived from "SqliteDropCreateDatabaseWhenModelChanges" (the class i attached).
With this class you can write something like this:
public class TLocalDatabase : DbContext
{

	...

	protected override void OnModelCreating(DbModelBuilder modelBuilder)
	{
		TLocalDatabaseInitializer strategy = new TLocalDatabaseInitializer(modelBuilder);
		Database.SetInitializer<TLocalDatabase>(strategy);
	}

	....

}

 public class TLocalDatabaseInitializer: SqliteDropCreateAndMigrateDatabaseWhenModelChanges<TLocalDatabase>
    {
        public TLocalDatabaseInitializer(DbModelBuilder modelBuilder) : base(modelBuilder) {
            TablesMigrationValidation += TLocalDatabaseInitializer_TablesMigrationValidation;
            FieldsMigrationValidation += TLocalDatabaseInitializer_FieldsMigrationValidation;
            BeforeTableMigration += TLocalDatabaseInitializer_BeforeTableMigration;
        }

        private void TLocalDatabaseInitializer_TablesMigrationValidation(object sender, TablesMigrationValidationEventArgs e)
        {
            // Here you can verify which tables are added and/or removed since the previous version, see: "e.added_tables" and "e.dropped_tables"

            // If you want to abort migration simply:
            e.Cancel = true;
        }

        private void TLocalDatabaseInitializer_FieldsMigrationValidation(object sender, FieldsMigrationValidationEventArgs e)
        {
            // Here you can verify which fields in the specified table are added and/or removed since the previous version, see: "e.table_name", "e.added_fields" and "e.dropped_fields"

            // If you want to abort migration simply:
            e.Cancel = true;
        }

        private void TLocalDatabaseInitializer_BeforeTableMigration(object sender, BeforeTableMigrationEventArgs e)
        {
            // Here you can personalize the migration of datas for each tables.
            // For example:
            // in the model I want to check some problems that should affect the table "DemoTable":
            if (e.tbl_name == "DemoTable")
            {
                // if a text field named "NewTextField" has been added (suppose it is "NOT NULL") for allowing the migration I need to initialize it to the fixed value "unknown":
                if (!e.from_list.Contains("[NewTextField]") && e.to_list.Contains("[NewTextField]"))
                {
                    e.from_list.Add("'unknown'");
                    e.to_list.Add("[NewTextField]");
                }
                // if an integer field named "NewIntField" has been added (suppose it is "NOT NULL") for allowing the migration I need to initialize it copying the existing field "ExistingIntField" incremented by 1:
                if (!e.from_list.Contains("[NewIntField]") && e.to_list.Contains("[NewIntField]"))
                {
                    e.from_list.Add("[ExistingIntField]+1");
                    e.to_list.Add("[NewIntField]");
                }
            }
        }

        protected override void SeedAfterCreation(TLocalDatabase context)
        {
            base.SeedAfterCreation(context);

            // Called if the database is created for the first time (there is no previous version from which import datas).
            // Here you can populate the database with the initial datas
        }

        protected override void SeedAfterMigration(TLocalDatabase context)
        {
            base.SeedAfterMigration(context);

            // Called if the database was recreated because the model has changed (datas from previous version are yet imported).
            // Here you can modify datas after the migration.
        }
    }

PS:
I wrote it very quickly so sorry, it is uncommented and not well formed!
The best solution is to fork SQLiteCodeFirst and add this class in it (some optimization are possible in this case!)

I haven't checked this out thoroughly yet but it looks interesting ... https://www.codeproject.com/Articles/32977/Upgrade-framework-for-SQLite-databases

Hello @digocesar
I use following codes but methods never called in SqliteMigrationSqlGenerator !

To use:
To your migrations Configuration class ctor, add:
SetSqlGenerator( "System.Data.SQLite", new SQLite.CodeFirst.SqliteMigrationSqlGenerator() );
And in your context's OnModelCreating add:
Database.SetInitializer( new System.Data.Entity.MigrateDatabaseToLatestVersion<MyContext, Migrations.Configuration>( true ) );

But i apply your changes to code and can not solve double quotation problem!
...
.Index(t => t.LastModifierUserId, name: ""IX_Appliance_LastModifierUserId"")
...

After replace "" with "
PM> add-migration "Ref_Db_Migration_v1.1"
Unable to generate an explicit migration because the following explicit migrations are pending: [201710152025217_Ref_Db_Migration_v1.0]. Apply the pending explicit migrations before attempting to generate a new explicit migration.
PM> update-database
Specify the '-Verbose' flag to view the SQL statements being applied to the target database.
System.Data.Entity.Core.ProviderIncompatibleException: CreateDatabase is not supported by the provider.
   at System.Data.Entity.Core.Common.DbProviderServices.DbCreateDatabase(DbConnection connection, Nullable`1 commandTimeout, StoreItemCollection storeItemCollection)
   at System.Data.Entity.Core.Common.DbProviderServices.CreateDatabase(DbConnection connection, Nullable`1 commandTimeout, StoreItemCollection storeItemCollection)
   at System.Data.Entity.Core.Objects.ObjectContext.CreateDatabase()
   at System.Data.Entity.Migrations.Utilities.DatabaseCreator.Create(DbConnection connection)
   at System.Data.Entity.Migrations.DbMigrator.EnsureDatabaseExists(Action mustSucceedToKeepDatabase)
   at System.Data.Entity.Migrations.Infrastructure.MigratorBase.EnsureDatabaseExists(Action mustSucceedToKeepDatabase)
   at System.Data.Entity.Migrations.DbMigrator.Update(String targetMigration)
   at System.Data.Entity.Migrations.Infrastructure.MigratorBase.Update(String targetMigration)
   at System.Data.Entity.Migrations.Design.ToolingFacade.UpdateRunner.Run()
   at System.AppDomain.DoCallBack(CrossAppDomainDelegate callBackDelegate)
   at System.AppDomain.DoCallBack(CrossAppDomainDelegate callBackDelegate)
   at System.Data.Entity.Migrations.Design.ToolingFacade.Run(BaseRunner runner)
   at System.Data.Entity.Migrations.Design.ToolingFacade.Update(String targetMigration, Boolean force)
   at System.Data.Entity.Migrations.UpdateDatabaseCommand.<>c__DisplayClass2.<.ctor>b__0()
   at System.Data.Entity.Migrations.MigrationsDomainCommand.Execute(Action command)
CreateDatabase is not supported by the provider.

Hi @Rgl88.
I suggest to try:
Database.SetInitializer( new System.Data.Entity.MigrateDatabaseToLatestVersion<MyContext, Migrations.Configuration>( true ) );
MyContext.Database.Initialize(true);

My problem with Index was when I need to drop it. Not creating. And I'm not using double quotation in it!

Hello @digocesar
Double quotation generated via ef in migration file (Up method), when i add migration.
I try your code but it not work:
protected override void OnModelCreating(DbModelBuilder modelBuilder)
{
            Database.SetInitializer(new System.Data.Entity.MigrateDatabaseToLatestVersion<DataContext, Migrations.Configuration>(true));
            Database.Initialize(true);

            //var sqliteDbInitializer = new SqliteDatabaseInitializer(modelBuilder);
            //Database.SetInitializer(sqliteDbInitializer);
}

Exception:
PM> update-database
Specify the '-Verbose' flag to view the SQL statements being applied to the target database.
System.InvalidOperationException: The context cannot be used while the model is being created. This exception may be thrown if the context is used inside the OnModelCreating method or if the same context instance is accessed by multiple threads concurrently. Note that instance members of DbContext and related classes are not guaranteed to be thread safe.
   at System.Data.Entity.Internal.LazyInternalContext.InitializeContext()
   at System.Data.Entity.Internal.LazyInternalContext.MarkDatabaseInitialized()
   at System.Data.Entity.Database.Initialize(Boolean force)
   at RefrigeratorTester.Data.DataContext.OnModelCreating(DbModelBuilder modelBuilder) in G:\Projects\My Projects\RefrigeratorTester\RefrigeratorTester\RefrigeratorTester\Data\DataContext.cs:line 71
   at System.Data.Entity.Internal.LazyInternalContext.CreateModelBuilder()
   at System.Data.Entity.Internal.LazyInternalContext.CreateModel(LazyInternalContext internalContext)
   at System.Data.Entity.Internal.RetryLazy`2.GetValue(TInput input)
   at System.Data.Entity.Internal.LazyInternalContext.InitializeContext()
   at System.Data.Entity.Internal.LazyInternalContext.get_ModelBeingInitialized()
   at System.Data.Entity.Infrastructure.EdmxWriter.WriteEdmx(DbContext context, XmlWriter writer)
   at System.Data.Entity.Utilities.DbContextExtensions.<>c__DisplayClass1.<GetModel>b__0(XmlWriter w)
   at System.Data.Entity.Utilities.DbContextExtensions.GetModel(Action`1 writeXml)
   at System.Data.Entity.Utilities.DbContextExtensions.GetModel(DbContext context)
   at System.Data.Entity.Migrations.DbMigrator..ctor(DbMigrationsConfiguration configuration, DbContext usersContext, DatabaseExistenceState existenceState, Boolean calledByCreateDatabase)
   at System.Data.Entity.Migrations.DbMigrator..ctor(DbMigrationsConfiguration configuration)
   at System.Data.Entity.Migrations.Design.ToolingFacade.BaseRunner.GetMigrator()
   at System.Data.Entity.Migrations.Design.ToolingFacade.UpdateRunner.Run()
   at System.AppDomain.DoCallBack(CrossAppDomainDelegate callBackDelegate)
   at System.AppDomain.DoCallBack(CrossAppDomainDelegate callBackDelegate)
   at System.Data.Entity.Migrations.Design.ToolingFacade.Run(BaseRunner runner)
   at System.Data.Entity.Migrations.Design.ToolingFacade.Update(String targetMigration, Boolean force)
   at System.Data.Entity.Migrations.UpdateDatabaseCommand.<>c__DisplayClass2.<.ctor>b__0()
   at System.Data.Entity.Migrations.MigrationsDomainCommand.Execute(Action command)
The context cannot be used while the model is being created. This exception may be thrown if the context is used inside the OnModelCreating method or if the same context instance is accessed by multiple threads concurrently. Note that instance members of DbContext and related classes are not guaranteed to be thread safe.

Hi @Rgl88 ,
I have same problem, which way to resolve that ?
Thanks

Hi @AndreaMarchetto ,
I tried and have a problem about loss data:
I have a Db, include table Test (Id, Name, Desc) and records

Change model Test (ex : add field Status), run first app migration success (include field Status and table have record),
Close app and run again : include field Status but old data loss (table empty)
I think problem at class SqliteDropCreateAndMigrateDatabaseWhenModelChanges ==> InitializeDatabase (method) ==>  base.InitializeDatabase(context), after migration success and at second run, it still dropdatabase.
Somehow to resolve this??
Thanks

Hello @tuanth89
Unfortunately I could not find a solution!
It seems like you have been able to solve the problem 👍

Hello @tuanth89
You are right...
Sorry, I founded this bug some time ago but I forgot to update my post!

Just leaving this here so I don't lose it - looks useful ...
https://github.com/praeclarum/sqlite-net/wiki/AutomaticMigrations
https://github.com/praeclarum/sqlite-net/blob/master/src/SQLite.cs#L489 <== code that maps an existing table to a new table during CreateTable

SetSqlGenerator( "System.Data.SQLite", new SQLite.CodeFirst.SqliteMigrationSqlGenerator() );
This line doesn't work anymore in EF 6.2.0, the Generate method on the CodeFirst.SqliteMigrationSqlGenerator doesn't get called.
Anyone have this issue?

Hi @JobaDiniz .
Did you changed the Database Initializer?
See if this information can help you.

Yes, I've changed. It works for EF 6.1.x but not for 6.2.x
On qui, 10 de mai de 2018 at 15:14 digocesar<EMAIL_ADDRESS>wrote:

Hi @JobaDiniz https://github.com/JobaDiniz .
Did you changed the Database Initializer?
See if this
https://github.com/digocesar/SQLiteCodeFirst#sqlitemigrationsqlgenerator-sample
information can help you.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/msallin/SQLiteCodeFirst/issues/4#issuecomment-388138467,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAKFqpAKgZEXvvMURWshusr4QDQHjl7eks5txIOUgaJpZM4D1sY-
.

https://github.com/msallin/SQLiteCodeFirst/tree/%234

https://github.com/msallin/SQLiteCodeFirst/tree/%234

@msallin is this link correct? it goes to the home page of this repository...

Points to the branch #4, into which I merged your PR. I'll need some time to look through the code and I'll merge it into the master as soon as EF 6.3 with the fix was released and I integrated it into SQLite.CodeFirst.

I integrated your library using nuget package manager, have two questions :
1- did you merge the branch in latest nuget package?
2- suppose i have the dbcontext, and the configuration with some seed, now, what should i do to make sure the db is created? I used create if not exists, would only call for the db in a winform just generate the db now for me? and with the package form nuget.... question 1.....?

Points to the branch #4, into which I merged your PR. I'll need some time to look through the code and I'll merge it into the master as soon as EF 6.3 with the fix was released and I integrated it into SQLite.CodeFirst.

I integrated your library using nuget package manager, have two questions :
1- did you merge the branch in latest nuget package?
2- suppose i have the dbcontext, and the configuration with some seed, now, what should i do to make sure the db is created? I used create if not exists, would only call for the db in a winform just generate the db now for me? and with the package form nuget.... question 1.....?

EF 6.3 with the necessary fix isn't yet released.

Points to the branch #4, into which I merged your PR. I'll need some time to look through the code and I'll merge it into the master as soon as EF 6.3 with the fix was released and I integrated it into SQLite.CodeFirst.

I integrated your library using nuget package manager, have two questions :
1- did you merge the branch in latest nuget package?
2- suppose i have the dbcontext, and the configuration with some seed, now, what should i do to make sure the db is created? I used create if not exists, would only call for the db in a winform just generate the db now for me? and with the package form nuget.... question 1.....?

Ok, I'm sure missing few things :
1- [Key] annotation, there is no [Key] annotation under your package's name space?
2- take a look at these snippets :
`public class BHDBContext : DbContext
{
public string ConnectionString { get; set; }
public DbSet GlobalSettings { get; set; }
    public BHDBContext () : base("SettingsConnectionString")
    { }

    protected override void OnModelCreating (DbModelBuilder modelBuilder)
    {
        var sqlite = new SqliteCreateDatabaseIfNotExists<BHDBContext>(modelBuilder);
        Database.SetInitializer(sqlite);
    }
}

internal sealed class Configuration : DbMigrationsConfiguration<BHDBContext>
{
    public Configuration ()
    {
        AutomaticMigrationsEnabled = true;
    }
    protected override void Seed (BHDBContext context)
    {
        var s = context.Set<GlobalSettings>().Add(new GlobalSettings());
        s.OverloadRetry = true;
        s.RetryAttempWaitTime = 500;
        s.OverloadRetryAttempts = 1;
        s.Network = "Test";
        s.MainDomain = @"Blah";
        s.TestDomain = @"Blah2";
        s.FirstApplicationRun = true;
        s.Leverage = 10;
        s.Password = "admin".EncryptDouble(true);
    }`

and
public SettingsForm () { InitializeComponent(); Utils.SetWindowTitle (this, "Settings"); Utils.SetConnectionString (); DB = new BHDBContext (); }
so, as much as i thought, it should create the data base if it does not exist when ever i am calling the dbcontext for an instantiation?
guess what, nothing is happening, no data base at all !

Please create a new issue for this and upload the code somewhere (only what's necessary to reproduce), then I'll have a look at it.
Thank you.

I haven't followed this up but apparently SQLite v 3.25.0 introduced renaming columns and fixed some table renaming problems: https://stackoverflow.com/questions/805363/how-do-i-rename-a-column-in-a-sqlite-database-table/52346199#52346199

System.Data.SQLite.EF6.Migrations comes out.

Did anybody use System.Data.SQLite.EF6.Migrations? If yes, does it completely replace this library or is there anything you can't do? I'm not very emotional to deprecate, if there is a better option.

I found System.Data.SQLite.EF6.Migrations at https://github.com/bubibubi/sqliteef6migrations. It doesn't seem to replace your library, I didn't look at it closely. I need to continue to use .NET framework for most of my projects so even if you deprecate this I will stay with it.
I use a manual SQL / Reflection thing based on ..  https://github.com/semashkinvg/SQLiteCodeFirst/blob/master/SQLite.CodeFirst.Console/FootballDbInitializer.cs ... well, sort of. Wow, I can't figure out where all that came from and it was only 9 months ago.
It makes a lot o use of EdmType. It also has provision for schema-number based manual SQL migraions.  It is all in the InitializeDatabase([NotNull] DbContext dbContext) method. It ain't pretty but it has been reliable so far.  Let me know if you want to see it.

I rebased and squashed the branch containing the migrations code from @digocesar and dropped net4.0 support. I didn't test it but if anybody wants to continue, feel free.
Artifacts for testing are here: https://ci.appveyor.com/project/msallin/sqlitecodefirst/build/job/gy8s20q6fak8804r/artifacts
Branch: https://github.com/msallin/SQLiteCodeFirst/tree/%234

I rebased and squashed the branch containing the migrations code from @digocesar and dropped net4.0 support. I didn't test it but if anybody wants to continue, feel free.
Artifacts for testing are here: https://ci.appveyor.com/project/msallin/sqlitecodefirst/build/job/gy8s20q6fak8804r/artifacts
Branch: https://github.com/msallin/SQLiteCodeFirst/tree/%234

I had to add this code to SQLite.CodeFirst.MigrationConsole.csproj so that I could resolve MissingManifestfastResourceException
  <!-- Bug with the SDK for .NET Framework projects. The resx migrations are not included
  See: https://github.com/dotnet/ef6/issues/1258#issuecomment-531355034 -->
  <PropertyGroup>
    <EmbeddedResourceUseDependentUponConvention>true</EmbeddedResourceUseDependentUponConvention>
  </PropertyGroup>

exception:
System.Resources.MissingManifestResourceException: '지정한 문화권 또는 중립 문화권에 적합한 리소스를 찾을 수 없습니다.
컴파일 타임에 "SQLite.CodeFirst.MigrationConsole.Migrations.InitialCreate.resources"이(가)
 "SQLite.CodeFirst.MigrationConsole" 어셈블리에 제대로 포함 또는 링크되어 있는지 확인하고,
필요한 위성 어셈블리가 로드 가능한지와 완전히 서명되어 있는지 확인하십시오.'


Update maintainer-list.nix

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I think it would be better if you made this change as its own commit in #325495

I think it would be better if you made this change as its own commit in #325495

you mean i can add myself in maintainers and add package?


Credentials in the settings and account number from paybill

Hello I believe this is really helpful but I have some issues that is, the credentials you listed in the settings are so many yet in the developer I think I got almost 7 and with reaaly different names. I wanted to ask if you can give commented code of what in the developer site  each of those variables really points to, That will be really helpful.
again how do I get the account number for a C2B trasaction from the json data. thankyou

Hey @kimutaiRop  the Account number is labeled as BillRefNumber. As for the settings, they include setting also for B2C if you only interested with Paybill( C2B) just update those. All the same, I will add comments and group them

thanks @lemaiyan they really helped. my app is now up and running using this... only one issue though. which task should I use to update custom database models.


Call API outside of console

Are API calls supported within my javascript files, or only within the console?
For example, I have a sticky sidebar with interactive elements. It has drawers that open and close, causing varied heights throughout the user experience. I added Stickyfill.rebuild() within one of my functions, and nothing happens. However, if I type the same thing into the console, it fixes the layout.
Is there another way to call rebuild(), or do I need to do something else to initialize Stickyfill?
*note, no javascript errors display. It simply doesn't work.

You're doing something wrong. Let me see the code.


Fix checkstyle errors in the main code

Overview
Fixes checkstyle errors in master.
Issues fixed
Closes #203

LGTM lol


Setting credentials: 'include' within useFetch cookies are not forwarded on SSR

Environment
Operating System: Darwin
Node Version: v21.6.1
Nuxt Version: 3.12.3
CLI Version: 3.12.0
Nitro Version: 2.9.6
Package Manager<EMAIL_ADDRESS>Builder: -
User Config: future, extends, modules, runtimeConfig, routeRules, i18n
Runtime Modules<EMAIL_ADDRESS>Build Modules: -

Reproduction
https://github.com/MickL/nuxt-bug-usefetch-credentials

Run bun dev to start Nuxt app on port 3000 and Nitro app on port 3001
Press button "set cookie"
Reload page 1: Cookie arrives in Nuxt SSR app (middleware) but cookie is not set in the third party backend
Navigate to page 2: Cookie is set

Describe the bug
Using credentials: true the cookie arrives at Nuxt Nitro SSR app, but not in the third party backend
Nuxt:
const {data, error} = useFetch('http://localhost:3001/check-cookie', {
  credentials: 'include',
});

Nuxt Server Middleware:
export default defineEventHandler(async (event) => {
    const cookie = getCookie(event, 'my-cookie');
    console.log(cookie); // Cookie is set :)
});

Third party backend (Nitro / H3):
export default defineEventHandler(event => {
    const cookie = getCookie(event, 'my-cookie');
    console.log(cookie); // Cookie is NOT set  :(
})

It works when navigating pages and the request is sent by the browser
Additional context
No response
Logs
No response

I am currently facing the exact same issue. However I don't think that { credentials: 'include' } affect it in any way, I am not passing it to the server and from CSR it's perfectly visible all the time, but from SSR not.

I made a reproduction repo that showcases the bug.
Maybe your issue is more like #27996 ?

I made a reproduction repo that showcases the bug.
Maybe your issue is more like #27996 ?

Yes, you are right! Thank you so much for help!


Changelogs erased for deleted entities

Hello team,
I have noticed that all the changelogs for a parent entity are erased on entity delete:

However, we have usecase where we are interested in whole entity lifecycle tracking (including the delete action) and keeping these logs. Is there any way to achieve this?
Thank you,
Hana

Hello @JocelynGu135 can you confirm this?

Hi Hana,
Yes, this approach is used to pursue a simple & autonomous data retention strategy.
Can you explain more details of your use case:

Is it sufficient to know the creation / deletion events of the root entity?
or it has to keep all events of the root entity and its subordinate entities?
What's your data retention policy regarding these logs?
Who is going to do the cleaning up?
Best  regards,
Wei

Hi Wei,

My use case being simple booking tool (hence the need to log deletion of the root entity - Reservation ), it is sufficient for me track changes just for the parent.

 But again, it is not necessary to my use case.

This has not been decided yet, but I assume we should keep the logs for at least a year.

There should be a periodical cleanup job scheduled to delete the old entries.

Best regards,
Hana

Hi Hana,
Thanks for providing the details! we'll have some internal discussion of your case and decide how to deal with it?
Best regards,
Wei

By the way, one more question regarding the following statement:
"My use case being simple booking tool (hence the need to log deletion of the root entity - Reservation ), it is sufficient for me track changes just for the parent."
Currently the change logs are showed within the root entity, how will view its change log if it's deleted? are you going to develop a dedicated app to view the change logs centrally given they are kept in the table?

Hi Wei,
yes, we would like to expose the logs independently on respective entity. The idea is to expose ChangeView (or perhaps ChangeLog with associated Changes for better readability) as read-only entity in separate tab of the app, visible to admin users only.
Best regards,
Hana

Hello team,
is there any new info regarding this issue?
Thank you,
Hana

Hello @Hanka0
the new release now has the requested functionality.
Can you give it a go and provide some feedback?
Thanks and best,
Nick

Hi Nick,
great, I will give it a try.
Thank you,
Hana

Hi Nick,
at first glance, the changelog now works as desired for our use case.
Thank you once again for implementing the change.
Best regards,
Hana


Implement Subpopulation in Python

SubPopulation is currently implemented in C++ because of performance reasons (see #120, #44). An earlier attempt at implementing this in Python (https://github.com/PyVRP/PyVRP/pull/88) was discontinued because it contained some bugs that we couldn't solve and we were time pressured for the submission deadline. However, the PR showed that we can create a fast implementation of SubPopulation in Python using vectorization. I'll have attempt at this in early August.

I think some of the tests here already implement a reasonably efficient vectorised biased fitness computation.

I think all of the complexity in my previous solution was to incrementally maintain the biased fitness... I think I did not try just computing it lazily when needed using the vectorized solution in the tests... which may or may not be acceptible.
I was also thinking that we could maybe just implement it differently/approximately without hurting performance, for example:

just compute the diversity and/or ranks only when inserting the individual rather than updating them continuously
or maybe update them only every x iterations / only when purging (which removes the need to track statistics incrementally for performance)

Thinking about this a little more there are two places where biased fitness is used:

In the binary tournament parent selection. Here I would expect little difference if we use slightly different/outdated/approximated fitness values.
In the purge. Since this is only every x iterations, it would be acceptible to recompute biased fitness here. However, the purge currently removes individuals 1 by 1 and recomputes the biased fitness for each. Maybe here we can remove more than 1 (or even all) individuals at once without hurting performance.


Update onju-voice.yaml

Hi,
First of all I just want to say a big thanks for the work,
I noticed that I got the same reboot issue loop as in this reported issue in the normal config (not the micro_wake_word).
I am running esphome version 2024.3.1, when I added the following to the config the device worked like a charm so i'm creating a PR for this as I am probably not the only one that will run into the same issue with this version.
board_build.flash_mode: dio

Hello and thank you for your contribution! Also, sorry for the late reply.
This is a port of #8 to the non-MWW config, right?

Yes, exactly!


My !important styles will not override cleanslate's

It doesn't seem like my styles are properly overriding the cleanslate rules even though I add !important to everything myself as well. This is within a React/Webpack built script where my styles are in LESS files and !important is added programmatically. I do not believe this is relevant to why this is happening as the outputted CSS looks to be correct.
My widget looks like this:

....

....

The styles under myWidgetClass are all set with !important but cleanslate is still overriding them.
Is this the correct way to use this?

Could you include an example of a rule in the final CSS that gets overridden? If you are including Cleanslate first, and your rules after, then something like .mywidgetClass p { color: red !important } should work.

Is it the order the style sheet loads or the order of the classes? Because I have no idea what order webpack includes stuff (I can look into forcing it, maybe its alphabetically?) If its the order of the classes though it should work.
This is what it looks like in Chrome Dev tools:
http://imgur.com/a/pp7Cc

The Cleanslate stylesheet specifies two types of selector: .cleanslate and .cleanslate TAG (e.g. .cleanslate li. In order to override them, you will need to use !important and either use more specific selectors - e.g. classname + tag + something else (another classname, another tag, anything), or you can provide rules of the same specificity and include those rules AFTER the Cleanslate rules. This is how the CSS cascade works.
If it helps, you could have your rules include the prefix .cleanslate in addition to .someclass or .mywidgetClass.


Added doc for two workarounds.

@doneill Added doc discussing two workaround for version 100.

@zinfin I added some minor edits, otherwise looks good to merge once you resolve the conflicts.


[akash] should probably use pruned snapshot by default? to save 8410% (400G => 4.7G) and speed up the deployment

Akash should probably use the pruned snapshot by default, to save 8410% (400G => 4.7G) as well as to speed up the deployment.
Change is simple =>
from:
  SNAPSHOT_JSON=https://cosmos-snapshots.s3.filebase.com/akash/snapshot.json

to:
  SNAPSHOT_JSON=https://cosmos-snapshots.s3.filebase.com/akash/pruned/snapshot.json

Ref.

https://discord.com/channels/747885925232672829/751246770885099533/970252135637848074
https://discord.com/channels/747885925232672829/751246770885099533/970322047110610944

This was done a few hours ago strangely!


Problems with new ID format of sacred 0.7b2

Hi,
I've changed the _id field in the new version of sacred form ObjectId to int. Unfortunately that breaks your current webapp:
Traceback (most recent call last):
  File "/home/greff/venv/sacredboard/lib/python3.4/site-packages/flask/app.py", line 1982, in wsgi_app
    response = self.full_dispatch_request()
  File "/home/greff/venv/sacredboard/lib/python3.4/site-packages/flask/app.py", line 1614, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/home/greff/venv/sacredboard/lib/python3.4/site-packages/flask/app.py", line 1517, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/home/greff/venv/sacredboard/lib/python3.4/site-packages/flask/_compat.py", line 33, in reraise
    raise value
  File "/home/greff/venv/sacredboard/lib/python3.4/site-packages/flask/app.py", line 1612, in full_dispatch_request
    rv = self.dispatch_request()
  File "/home/greff/venv/sacredboard/lib/python3.4/site-packages/flask/app.py", line 1598, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/home/greff/Programming/sacredboard/sacredboard/app/config/routes.py", line 53, in api_run
    runs = data.get_run(run_id)
  File "/home/greff/Programming/sacredboard/sacredboard/app/data/mongodb.py", line 26, in get_run
    cursor = self._db.runs.find({"_id": bson.ObjectId(run_id)})
  File "/home/greff/venv/sacredboard/lib/python3.4/site-packages/bson/objectid.py", line 110, in __init__
    self.__validate(oid)
  File "/home/greff/venv/sacredboard/lib/python3.4/site-packages/bson/objectid.py", line 206, in __validate
    _raise_invalid_id(oid)
  File "/home/greff/venv/sacredboard/lib/python3.4/site-packages/bson/objectid.py", line 52, in _raise_invalid_id
    " or a 24-character hex string" % oid)
bson.errors.InvalidId: '1' is not a valid ObjectId, it must be a 12-byte input or a 24-character hex string

Check it now, please. I noticed the problem when I wanted to run sacred0.7 beta with my existing database from sacred 0.6, it didn't work. Anyway I have already fixed it in sacredboard. It should work with both now.
Please reopen the issue if not.


Support dates like XXYY(01.02.16).pdf

Won't fix; not possible to disambiguate between day and month.


[adultswim] ValueError: unknown url type

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like that [x])
Use Preview tab to see how your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2016.08.07. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2016.08.07

Before submitting an issue make sure you have:

[x] At least skimmed through README and most notably FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add -v flag to your command line you run youtube-dl with, copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
youtube-dl.py -f best --write-sub --convert-subtitles srt -v http://www.adultswim.com/videos/million-dollar-extreme-presents-world-peace/your-vibe-attracts-your-tribe/
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-f', u'best', u'--write-sub', u'--convert-subtitle
s', u'srt', u'-v', u'http://www.adultswim.com/videos/million-dollar-extreme-pres
ents-world-peace/your-vibe-attracts-your-tribe/']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2016.08.07
[debug] Python version 2.7.11 - Windows-7-6.1.7601-SP1
[debug] exe versions: ffmpeg N-80953-gd4c8e93, ffprobe N-80953-gd4c8e93
[debug] Proxy map: {}
[AdultSwim] your-vibe-attracts-your-tribe: Downloading webpage
[AdultSwim] Million Dollar Extreme Presents: World Peace - Your Vibe Attracts Yo
ur Tribe: Downloading segment information
[AdultSwim] Million Dollar Extreme Presents: World Peace - Your Vibe Attracts Yo
ur Tribe: Downloading m3u8 information
Traceback (most recent call last):
  File "C:\Python27\lib\runpy.py", line 162, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "C:\Python27\lib\runpy.py", line 72, in _run_code
    exec code in run_globals
  File "C:\you\youtube-dl.py\__main__.py", line 19, in <module>
  File "C:\you\youtube-dl.py\youtube_dl\__init__.py", line 422, in main
  File "C:\you\youtube-dl.py\youtube_dl\__init__.py", line 412, in _real_main
  File "C:\you\youtube-dl.py\youtube_dl\YoutubeDL.py", line 1775, in download
  File "C:\you\youtube-dl.py\youtube_dl\YoutubeDL.py", line 682, in extract_info

  File "C:\you\youtube-dl.py\youtube_dl\extractor\common.py", line 347, in extra
ct
  File "C:\you\youtube-dl.py\youtube_dl\extractor\adultswim.py", line 211, in _r
eal_extract
  File "C:\you\youtube-dl.py\youtube_dl\extractor\common.py", line 1164, in _ext
ract_m3u8_formats
  File "C:\you\youtube-dl.py\youtube_dl\extractor\common.py", line 414, in _down
load_webpage_handle
  File "C:\you\youtube-dl.py\youtube_dl\extractor\common.py", line 394, in _requ
est_webpage
  File "C:\you\youtube-dl.py\youtube_dl\YoutubeDL.py", line 1985, in urlopen
  File "C:\Python27\lib\urllib2.py", line 423, in open
    protocol = req.get_type()
  File "C:\Python27\lib\urllib2.py", line 285, in get_type
    raise ValueError, "unknown url type: %s" % self.__original
ValueError: unknown url type: /secure/tve/2016-08/ASOE1008021600067583_HLS/ASOE1
008021600067583_iphone_vod.m3u8

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):

Single video: http://www.adultswim.com/videos/million-dollar-extreme-presents-world-peace/your-vibe-attracts-your-tribe/

Description of your issue, suggested solution and other information
As above, unable to even try to start the download. A simple -F causes the issue too. Also doesn't work with Python version 3.5.2.

Working fine now. Unsure if due to a change by AS or due to updating to 2016.08.10, Closing issue.


feat(vue-app): redirect support vue.router's replace

redirect support vue.router's replace
Types of changes

[ ] Bug fix (a non-breaking change which fixes an issue)
[x ] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description
redirect support vue.router's replace
middleware's redirect always use router.push, but in my case , I want to use replace that vue-router has support
Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly. (PR: #)
[ ] I have added tests to cover my changes (if not applicable, please state why)
[ x] All new and existing tests are passing.

Closing because of a lack of activity and clear usage. @rupertqin please ping if you needed this PR to be reopened.


Using function overloads with an invalid type for the methods on the second param correctly infers the generic type as being nullable, but results in an error in which the same generic type is non nullable

🔎 Search Terms
function overloads - inferred type - error expected type - mismatch discrepancy - non nullable - nested function method - properties param
🕗 Version & Regression Information

This is the behavior in every version I tried, and I reviewed the FAQ for entries about overloads

⏯ Playground Link
https://www.typescriptlang.org/play?ts=5.2.2#code/C4TwDgpgBAwgRgHgKoD4oF4oAoCUG1IDcAUMaJFAPJwBWEAxsAOoCWwAFgGIB2AzggDU0mAN7EoEqADMWAJ17AAXNjABDWaoC2AFUqyAcgFcANseUCoAHyjcTxvOjQA3APYsAJiUlReDF93dlLDUNTQAGZVVuEAc0W004CFkSAF8SYilDbkYWf2kXFwRtFCx6OGV4IpQAGigXZWo6RlYOHn5inEjojKycvKkCqtLy2ERi2vqqWgZmNi4+Ks6oKJAe7OBc7nzC4uGKsZq6hunmubbFrpAoERTSdwZjdWh6fwUoTRB4INifYFkWbgAcysNjspAGLiwH3gtTE3hk8iU2HUgN0BjsPxu1XEkl8LwCQRRYUxOO8ElkEGAhlkWxuy14UCyAGtuC4AO7cUlQW4pHBAA
💻 Code
type Cb<U> = () => U;

type ObjectWithFns<V> = {
    first: (paramTOrNull: V | null) => void;
    second: (param0: any) => number;
};

function foo<T>(cb: Cb<T>, o: ObjectWithFns<T>): any
function foo<T>(cb: Cb<T>, o: ObjectWithFns<T>): any
function foo<T>(cb: Cb<T>, o: ObjectWithFns<T>): any {}

declare const myCb: () => string | null

foo(myCb, {
    first: (argTOrNull) => {},
    second: (arg0) => {
        return {} as unknown
    }
})

🙁 Actual behavior
Hovering over foo, it inferred T = string | null. Indeed, if the signature of foo is changed (in all overloads) to return T, and the result stored in a variable, the resulting type of the var (as emitted in the .d.ts) is string | null.
However the usage gives a compiler error for myCb that it does not match any of the 2 overloads for foo with T = string (string | null not assignable to string).
Clearly, the type for T in the error for myCb does not match both:

the inferred type for T in foo itself
the types at any of the inference sites for T

The first constitutes a direct contradiction within the type system; T is simultaneously inferred as two different types within the same program.
The second (taken on its own) suggests faulty inference, since the generic param does infer its type from the first (by the parameter order) and only inference site with type information available (since the argument argTOrNull has type unknown), but the with null union member is stripped out for some reason.
🙂 Expected behavior
Since the supplied callback for the second property does not satisfy the expected type of string | null (in this case returning unknown instead of number), and since the supplied myCb for the first param satisfies the expected type(matching 2 of 2 of the function overloads), we would expect the compilation error to be for the second parameter instead of myCb, namely the error:
No overload matches this call.
  Overload 1 of 2, '(cb: Cb<string | null>, o: ObjectWithFns<string | null>): string | null', gave the following error.
    Type '(arg0: any) => unknown' is not assignable to type '(arg0: any) => number'.
      Type 'unknown' is not assignable to type 'number'.
  Overload 2 of 2, '(cb: Cb<string | null>, o: ObjectWithFns<string | null>): string | null', gave the following error.
    Type '(arg0: any) => unknown' is not assignable to type '(arg0: any) => number'.(2769)

Additional information about the issue
Some additional observations:

asserting the supplied callback for the second property to return as any still results in the same error (only asserting to return as number removes the compilation error)

Some tweaks that fix the bug, making the compilation error be for the second parameter instead of myCb (as expected):

explicitly setting the generic type to string | null
removing one or both of the function overloads
making the second property on ObjectWithFns<...> a primitive type (e.g. number directly, instead of function returning number), and supplying a value that does not conform to the primitive type
removing param0 to make the signature for second property on ObjectWithFns<...> be a function without an argument (e.g. () => number)
making the return type of myCb be non-nullable
making the argument type for paramTOrNull be non-nullable

I don't see a defect here. The equation 4 + 2 = 7 is wrong, and we can say that the 4 should be 3, or the 7 should be 6, etc, but no error has a claim to be the one correct error.

Even ignoring which error is chosen, the bug report is mainly about consistency with the types as inferred in the program. Is it not a defect for the program to choose one type, and the error message choose the other? My understanding is that compiler errors operate based on the existing inferred types as pre-conditions, otherwise I don't see how it is feasible to reason about such issues if the valid and error outputs of the compiler reflect distinct decisions for the program types?
Regarding which error is the "correct" one. In your example the satisfiability of 4 in the equation is tied to that of 2, which explains how either error could be "correct". In the OP example however, it is not clear how there is any relation between the subject of the error and the actual source of the error. Namely, the value given for the first cb param is valid on its own, and there is no value given for the property second that would cause cb to no longer be valid. That the compiler handles a type error by flagging a completely unrelated and otherwise valid part of the program seems to me like a clear defect, no different from a more extreme case like:
function bar<T>(a: T, b: string) {}

bar('abc', 123)
//  ^ hypothetical type error here

Is it not a defect for the program to choose one type, and the error message choose the other?

Not really. These are separable concerns; they can (and do) have different answers. There are definitely cases where it'd be better to unify these, but also cases where it wouldn't be. It's generally best to try to "contain" errors as much as we can so that a single problem doesn't result in a large chain of downstream errors. For example, let's say you had
declare function foo<T extends string>(x: T): T;
const m: string = foo(42);

This program has at least one error: the inferred type of T will not meet the constraint. Under a "the types must be the same" regime, this program now has two errors - the constraint violation T: number, and the illegal assignment of number to m: string. But the second error isn't one that you should action until you fix the first error (at which point the second error has gone away).


Add more info Readme.md

The main Readme is very simple, has only the title of system.
my suggestion is to amplify the readme by adding information about what the system does to make it clearer to the user. Infos like what the system does, how to use, etc.

@Mikael-R  I think the readme needs more information too, at the moment it doesn’t bring any relevant information, how it works, how to use it, because the idea is really cool :)

Thanks guys, I'm working hard on the project and new features are coming soon 😊
The template I'm basing on is this: https://github.com/Mikael-R/readme-template
He will have everything he has in this template and more

Create a stable version 💯


Unable to detect entities while using multi-choice prompt

I'm using a multi-choice prompt with list-style as List and enabled include numbers

I have trained few list entities which are displaying in a choice prompt

I'm displaying choices as a list to the user and if the user enters an option number instead of entering the option value the Luis is unable to detect the entities but the prompt is able to fulfill

Is there any way to detect trained entities even if We enter the option number?

Yes, @tonyanziano. And @KoradaRajesh this is kind of by design, the order of processing is the dialog's recognizer(in this case LuisRecoginzer) then the prompt's own recognition (where includeNumber takes effects).
So when user type "1", luis will return nothing helpful, and the prompt will pick the right value up to property.
Do you mean you want the entity also been set for later usage? Generally, the memory path (property) should be used as data store for information exchange, so as long as the property path is filled, it should be good to move forward, does that make sense?

Closing this due to inactivity. Feel free to reopen if needed


Haxe

I tried to install haxeflixel and this comes up

I tried to look up the solution it wasn't there and checked the issues and there was no answers
I would love to know how to fix that.

Not sure how you ended up in that situation. Maybe you installed haxe with another user or with administrator rights? Not used to windows at all..
Try to create D:\HaxeToolkit\haxe\lib folder yourself and make sure it doesn't have access right restrictions so that your current user can read/write there without restrictions.

Not sure how you ended up in that situation. Maybe you installed haxe with another user or with administrator rights? Not used to windows at all..
Try to create D:\HaxeToolkit\haxe\lib folder yourself and make sure it doesn't have access right restrictions so that your current user can read/write there without restrictions.

by creating the folder you mean by just creating the folder and change the path to there?


[WFRP4e System] Game Wouldn't Load

My game wouldn't load yesterday. Foundry loaded, but I only got the background screen, no scenes or menus or anything other than the Warhammer Fantasy Roleplay logo. This same thing happened to one of my players a few weeks ago. What causes this and what can we do to prevent this from happening? From: Empusae #4776foundry: 10.291wfrp4e: 6.4.0Active Modules:

Choosing


Let's write documentation!

There is two kind of documentation: reference manual and api doc (scaladoc).
Here is a non-exhaustive list where we need reference documentation:

[ ] semanticdb plugin options
[ ] semanticdb
[ ] metap
[ ] metac
[ ] classifiers
[ ] dialects
[ ] parsers
[ ] prettyprinters
[ ] quasiquotes
[ ] io
[ ] inputs
[ ] tokenizers
[ ] tokens
[ ] transversers
[ ] trees

What puzzled me in the beginning:

equality for trees
how to get information out of the semanticdb. (If you don't have the exact position, you don't get the symbol)

For the api doc, I can't find where the unidoc is published.

Related: https://github.com/scalameta/scalameta/issues/816

In what for would you like documentation, just a better version of http://scalameta.org/tutorial/#AWhirlwindTourofScalameta ???

@DavidDudson indeed, when I wrote this ticket I forgot about that tutorial. It does cover the wtf with equality. I guess a good start would be to make this more discoverable.
There are still missing pieces:

where is the api doc?
expand this section: http://scalameta.org/tutorial/#SemanticAPI

Here are some long overdue process documents:

https://github.com/scalameta/scalameta/pull/1268
https://github.com/scalameta/scalameta/pull/1269

Great idea @MasseGuillaume
I added metap and metac to the list, they can be used to quickly produce and print semanticdb files from the command line.

Superseded by #816


Including = symbol in JSON post body causes body to become truncated

Currently, including the = symbol inside any JSON body posted to the API via twurl causes the body content to be truncated at the = symbol, and the request will subsequently fail. This occurs even with the Content-Type set to application/json.

I'm seeing that this works if the = is encoded as %3d.

I caught this issue today as well. For those who are curious, the problem is coming from this logic:
https://github.com/twitter/twurl/blob/7eb9a1364cbc9e8ee30a81cf36db384eb363e0af/lib/twurl/cli.rb#L234
It looks like twurl is doing this by default and there's no way to skip this which is very confusing and doesn't make sense to me having this logic for all POST data.

This occurs even with the Content-Type set to application/json.

Exactly... curl doesn't do anything like this.
https://ec.haxx.se/http-post.html
Probably, it's difficult to just remove this logic as it will potentially require a bunch of documentation fix (on developer.twitter.com) and other critical stuff, but we should have a logic to check if a Content-Type is set by option (-H) and if it contains application/json in its value, so that we could skip this unnessesary parse for json POST body at least.
I also noticed there's a -r, --raw-data [data] Sends the specified data as it is in a POST request to the HTTP server. option:
https://github.com/twitter/twurl/blob/7eb9a1364cbc9e8ee30a81cf36db384eb363e0af/lib/twurl/cli.rb#L240-L246
but as you can guess it doesn't work because of the parse, again...
Well, there's a logic that supposed to pass a "raw" body data (was introduced in https://github.com/twitter/twurl/pull/60):
https://github.com/twitter/twurl/blob/bac93af79c5afb771d10de375a754f67626a8c31/lib/twurl/oauth_client.rb#L111-L112
but it only gets a "key" even though rest of the text after = parsed by above logics is in its value.

FYI, I looked at the code further (I'm Ruby beginner though..) and noticed that this fix isn't that easy as I thought initially. Since twurl is using OptionParser in order to parse command-line args, it reads args one by one with an actual input order. That means, if a user set options like this oder:
twurl -d '{"data": "foo=bar"}' -A 'Content-Type: application/json' '/path/to/endpoint'
data function doesn't know if there's a Content-Type header in options.headers or not at this stage.
https://github.com/twitter/twurl/blob/7eb9a1364cbc9e8ee30a81cf36db384eb363e0af/lib/twurl/cli.rb#L231-L238
Maybe we can do pattern matching using ARGV or something, but not sure if it's a reasonable way. So the easiet wasy I tested is to modify this block:
https://github.com/twitter/twurl/blob/bac93af79c5afb771d10de375a754f67626a8c31/lib/twurl/oauth_client.rb#L111-L112
to something like this:
elsif request.content_type && options.data
  data = ''

  if options.data.length == 1 && options.data.values.first == nil
    data += options.data.keys.first
  else
    options.data.each_with_index do |(key, value), i|
      data += (i == 0 ? '' : '&') + key.to_s + (value == nil ? '' : '=' + value.to_s)
    end
  end

  request.body = data

The fix is merged into master.

https://github.com/twitter/twurl/releases/tag/v0.9.4
Closing.


Fix typo in PostingsReaderBase docstring

The docstring for PostingsReaderBase seems to have an extra {@link PostingsEnum}. Minor change to fix it.

It looks to me as if the writer may intended ImpactsEnum there? Maybe check git blame to see when that edit was made...

It looks to me as if the writer may intended ImpactsEnum there? Maybe check git blame to see when that edit was made...

Good idea. I checked git history and found this commit, where
/**
 *  of this class to manage creation of {@link DocsEnum} and
 *  {@link DocsAndPositionsEnum} instances.
 * /

was replaced by

/**
 *  of this class to manage creation of {@link org.apache.lucene.index.PostingsEnum} and
 *  {@link org.apache.lucene.index.PostingsEnum} instances.
 * /

I guess earlier we had separate DocsEnum and DocsAndPositionsEnum, but now both can be handled within the PostingsEnum?
The class, however, does provide for creating ImpactsEnum (added later here), and we can mention that in the doc string. I'll update the PR.

The "force push" was a rebase on main.

Rebased on main..

@vigyasharma did you forget about this one ;)


Event listener leak in onDidChangeEnablement

4cf] potential listener LEAK detected, having 175 listeners already. MOST frequent listener (1):
event.ts:658 Error
    at i.create (event.ts:671:25)
    at l.l [as onDidChangeEnablement] (event.ts:795:25)
    at event.ts:155:97
    at Array.map (<anonymous>)
    at event.ts:155:84
    at new Pc (extensionsActions.ts:433:88)
    at l.j (instantiationService.ts:119:18)
    at l.createInstance (instantiationService.ts:85:18)
    at new ge (extensionsActions.ts:530:26)
    at l.j (instantiationService.ts:119:18)
    at l.createInstance (instantiationService.ts:85:18)
    at n.renderTemplate (extensionsList.ts:124:11)
    at E.renderTemplate (listPaging.ts:36:23)
    at listWidget.ts:1114:28
    at Array.map (<anonymous>)
    at Y.renderTemplate (listWidget.ts:1114:17)
    at L.alloc (rowCache.ts:40:34)
    at f.W (listView.ts:794:29)
    at f.Q (listView.ts:576:10)
    at f.splice (listView.ts:478:16)
    at splice.ts:17:25
    at Array.forEach (<anonymous>)
    at t.splice (splice.ts:17:10)
    at listWidget.ts:1442:36
    at v.bufferEvents (event.ts:1197:13)
    at q.splice (listWidget.ts:1442:10)
    at set model [as model] (listPaging.ts:204:10)
    at ae.Wc (extensionsViews.ts:992:11)
    at extensionsViews.ts:267:10

This event is no longer being used.