replace "trough" with "through"

[x] I understand that contributing to this repository will require me to agree with the CLA

Description
This PR replaces the incorrect English word with the correct English word.
What type of PR is this? (check all applicable)

[ ] 🍕 Feature
[ ] 🐛 Bug Fix
[x] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI

Related Tickets & Documents
https://github.com/anyproto/docs/issues/34
Mobile & Desktop Screenshots/Recordings
Added tests?

[ ] 👍 yes
[x] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Added to documentation?

[x] 📜 README.md
[ ] 📓 tech-docs
[ ] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?
No

@d1eselboy

Bad form on my part. I am now seeing this has been raised here https://github.com/anyproto/docs/issues/34
I have not contributed to an OS project before. I apologize for any other mis-steps I have made and would welcome criticism.

Resolves #34

@QuinnHerden thank you!


Liveness Check returning "eyes not closed" error when they are closed

Problem:
Even when a user's eyes are closed on step #3 of the liveness check, the messaged returned is "eyes not closed".
Desired Outcome:
Liveness check should return true if the user's eyes are closed and all the other checks pass.

Closing as this has been deprecated due to the move to Rekognition liveness checks


Can we get a LICENSE.md?

I have some ideas here, but I've gotten... singed, before, by projects without licenses. Mind grabbing something handy (MIT, Apache, GPL, etc?) and tossing it in?

Hi @QuinnyPig License is added. I will close this issue. Feel free to sharing you feedback idea


How long does it take to train?

It's a very interesting job. I noticed that the resources required for training are not mentioned in the paper. How long will it take to train?🥳

It depends on the dataset complexity. For unconditional generation (UCF-101) it took 8 days with 8 x A100 gpus.


Update TFM to netstandard2.0

cc @pranavkm @pakrym

I think the mvc updates have been merged, this is unblocked.

@JunTaoLuo @pranavkm Updated


Troubleshoot Jenkins build Errors - 2018-05-31.

Our internal Jenkins builds are failing due to permission errors.  Need to figure out what to do.

@sduskis can you take a look?  It seems the default service accounts do not have the right permissions, and I cannot change those.

This was a known issue that I can't comment about here.  The issue was fixed.


Recover in makeSlice?

Looking at the benchmark times, I noticed roughly 0.7% was spent in a defer in makeSlice. What is the reason for this defer. I am not sure if catching a panic, and sending a new one solves much?
// makeSlice allocates a slice of size n. If the allocation fails, it panics
// with ErrTooLarge.
func makeSlice(n int) []byte {
	// If the make fails, give a known error.
	defer func() {
		if recover() != nil {
			panic(ErrTooLarge)
		}
	}()
	return make([]byte, n)
}

Yes, makeSlice is from the upstream bytes.Buffer code.  I've thought about removing the defer/panic catching, but there were easier ways to get performance elsewhere.  As long as we are OK with... lets just say multi-gigabyte ffjson runs failing with a harder to debug error... then yes, we can remove it.


[Minor] scripts/demo/credentials and scripts/demo/vLEI direcotories don't seem to run anymore or match the README.md in the demo directory

Description
Scripts in the scripts/demo/credentials and scripts/demo/vLEI directories don't seem to run anymore or match up to running with the info of what is in the README.md (many of these scripts seem to rely on credentials I can't quite find in the repository and on the vLEI server serving data oobis).  They don't run in github actions.
Issue
Probably the README should be cleaned up and these scripts either deleted or adapted to run in the integration tests to help new users differentiate between user error and potential issues that may arise from the kli commands.
This relates to #653 in that its another gotcha for users attempting to use the demos in the scripts directory when learning kli commands.

I have a fix for this on the way.

Fixed with #675


[Node.js] Intellisense Not Working in Other Files

Does this issue occur when all extensions are disabled?: Yes/No
Yes

VS Code Version: Latest Insiders
OS Version: Win 10 21H2

Steps to Reproduce:

Init package.json
Install any package
Create a file, and create a variable that uses one of the functions from the node package
Create another file, and try to call that same variable.

I have tried a re-install of VSCode, and the latest insiders build. Still having the same issues. I have even tried many of the fixes that recommend adding the following to jsconfig.json
{
    "compilerOptions": {
        "target": "es6",
        "module": "commonjs",

    },
    "exclude": [
        "node_modules"
    ]
}

Any help would be greatly appreciated. Thanks in advance!

Please share an example project that demonstrates the issue

Yes, sure thing: https://github.com/WhitigolProd/SnailyCAD-Manager

Thanks. This is expected. pre is a module because it uses require. That means that globals declared in it aren't accessible in other files
Instead you need to use proper imports/exports

Thank you, I understand that. But my issue is; the code works perfectly fine, and I want to avoid using import/export in all the files that I create. I've never had this issue before, and what I'm trying to do has worked perfectly fine without issues in the past. Is there a workaround for this issue?


NoCredentialProviders: no valid providers in chain

"Failed creating cluster: NoCredentialProviders: no valid providers in chain" - keep getting this error.  Noticed that there was a similar issue registered in the AWS GO SDK.

@rclayton-the-terrible are you still seeing this issue?

@aaronlevy Honestly, I've stop trying.  The closest I got to a full Kubernetes deployment on AWS was mirroring Kelsey's Terraform scripts.  Since then, I've gotten really busy in development and haven't put any effort into it.

@rclayton-the-terrible if you get some time to come back to this, and you're still having issues, please let us know. I'm gonna close this for now, but feel free to re-open.
Also, just as a note, a quick way to get started deploying a cluster to AWS should be using the defaults in our quickstart guide: https://coreos.com/kubernetes/docs/latest/kubernetes-on-aws.html#kube-aws-quickstart

It might be related to: https://github.com/aws/aws-sdk-go/issues/345

@rclayton-the-terrible Just saw this was linked to the SDK. It looks like coreos-kubernetes is using a fairly old version of the SDK (0.9.5)  But I've verified that this version of the SDK should be returning the configured role credential.
You can run the following curl commands on the EC2 host to see what error the SDK is running into.
# Get the role name
curl http://<IP_ADDRESS>//latest/meta-data/iam/security-credentials/

# Use role name to get credentials
curl http://<IP_ADDRESS>//latest/meta-data/iam/security-credentials/<my-ec2-iam-role-name>

The AWS SDK for Go does have aws/aws-sdk-go#413 to improve this error message.

I ran into this issue yesterday. Using the latest version of kube-aws and my credential file is set up correctly.

+1 having this issue as well. Anything we can do to help debug?

I also experienced the error.
Initialized TLS infrastructure
Wrote kubeconfig to ...
Waiting for cluster creation...
Failed creating cluster: NoCredentialProviders: no valid providers in chain

I was using export AWS_DEFAULT_PROFILE=foo
Fixed the issue by making sure that a [default] profile was set in ~/.aws/credentials, but it still remains confusing to me why I was getting an error.

/cc @colhom

@aymanosman if you have multiple aws credentials in your ~/.aws/credentials, how is the aws client supposed to know which one to use if you don't explicitly specify a default?
The "more direct" way is to just export AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY etc environment variables, rather than deal with the credentials chain.

@colhom I was under the (presumably false) impression that export AWS_DEFAULT_PROFILE=foo would do the trick. It is one way the awscli determines which profile to use and I expected kube-aws to also respect that.
http://docs.aws.amazon.com/cli/latest/userguide/cli-chap-getting-started.html.
I have no idea how much work it is to support multiple profiles in this way. It's not a major issue.

The docs for the go sdk (https://github.com/aws/aws-sdk-go) seams to make no mention of AWS_DEFAULT_PROFILE which suggests that is isn't supported. So it is not an issue with this repo.

The AWS SDK for Go only supports the AWS_PROFILE environment variable. AWS_DEFAULT_PROFILE is a value only supported by the AWS CLI, not the SDKS to add it would be a potentially breaking change to SDK users. We have issue aws/aws-sdk-go#384 which discusses this topic.
If you set env AWS_PROFILE to your desired profile the SDK should respond to that.

I'm also getting the issue. I followed instructions mentioned in https://coreos.com/kubernetes/docs/latest/kubernetes-on-aws.html. I tried v0.4.1, 0.4.0 but no luck.

Ref: https://github.com/coreos/coreos-kubernetes/pull/303

@DImuthuUpe This error means the aws sdk isn't picking up your credentials correctly.  The docs have been updated with instructions for how to configure them.
I'm going to consider this fixed by the documentation update, but we'll enable verbose credential errors as well: https://github.com/coreos/coreos-kubernetes/issues/368.
Feel free to reopen if there's any more trouble.


Redshift-jdbc file write RCE

Redshift-jdbc file write RCE
In Amazon AWS Redshift JDBC Driver (aka amazon-redshift-jdbc-driver or redshift-jdbc42) with the newest version, the loggerFile properties does not check the file suffix,which a knowledgeable attacker with control over the JDBC URL can use to create a jsp webshell and achieve remote code execution.
Impact
version <= <IP_ADDRESS>
Detial
see: https://github.com/p1n93r/redshift-jdbc-RCE

@p1n93r
Per the project's security policy, please send this report to<EMAIL_ADDRESS>Do not open GitHub issues to report potential security problems within AWS-owned open source repositories.

OK


[Feature]: Duration picker

Describe the feature
I think that a Duration picker component would be valuable for some people
already develop something using dayjs and our current Input component

i can activate the hours also and everything is returned in seconds as base unit so you can transfer it to whatever format you want
What do you think?
Additional information

[X] I intend to submit a PR for this feature.
[ ] I have already implemented and/or tested this feature.

With the new radix-vue DateField it could be handled more easily


Emit button_up signal after setting pressed to false.

Hey there, I noticed that button.pressed is still true when the button_up signal is emitted. This means that for listeners of button_up, they must wait a frame to understand the true state of the button, or they must propagate some state to represent that "this is a button up event" to ignore button.pressed.
I think this is a mistake in the API. State should be made consistent before signals are emitted such that listeners have a valid scene tree.
A work around for this is to yield a single frame in button_up listeners such that the value of pressed is false as you would expect.
I've created pull requests for both master and 3.x to emit the button_up signal after the state is fully applied. I think this is more correct, more robust behaviour as it allows listeners to check button.pressed and actually have the correct state.
Here is some example code:
extends Button

func _ready():
	self.connect("button_down", self.refresh_button)
	self.connect("button_up", self.refresh_button)
	refresh_button()

func refresh_button():
	self.text = "pressed is: " + str(self.pressed)

Before this PR, button.pressed will never be false inside of button_up nor button_down. This is clearly a flaw in the API.
https://user-images.githubusercontent.com/78934401/119916935-b6b46100-bf22-11eb-8346-9bf61721256c.mp4
After this PR, button.pressed is false in button_up, as you would expect.
https://user-images.githubusercontent.com/78934401/119916950-c0d65f80-bf22-11eb-9848-81a4902aef7f.mp4

Thanks!

Cherry-picked for 3.4.


IssueReporterService should be lowercase (fix #183105)

This is what I get for having the typescript extension create the file for me


adding windows 2025 I think

Description
This PR adds the Windows 2025 images now available in GCP to project.yaml.
Related issue
b/384012234
How has this been tested?
GitHub Actions :smiley:
Checklist:

Unit tests

[ ] Unit tests do not apply.
[ ] Unit tests have been added/modified and passed for this PR.

Integration tests

[ ] Integration tests do not apply.
[ ] Integration tests have been added/modified and passed for this PR.

Documentation

[ ] This PR introduces no user visible changes.
[ ] This PR introduces user visible changes and the corresponding documentation change has been made.

Minor version bump

[ ] This PR introduces no new features.
[ ] This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
[ ] This PR bumps the version.

Pretty sure the Windows failure in the latest commit is a flake, because for the same image in the commit right before all the tests passed.


full logic for add and remove in console.py- console version

gui_trial.py simulates how many reads/ writes are happening when a block is added/removed from an exiting file at the specified position (beginning, middle, end).
console.py has the console equivalent of gui_trial.py. Some test cases with expected outputs are added in the comments.
Note: Please consider testing


prevent current stream from showing up

notes from stream:

i think the biggest thing was just that it's kinda useless, editing-wise
ugly cause the thumbnail won't render?

It should probably look better, but it shouldn't be removed.

https://clips.twitch.tv/DullSlickAmazonSuperVinlin-MpordrMLMAZWmfJy

meh yeah it sounded like a 'pls remove'
i'm no streamer but it makes little sense to have an ongoing stream in the editor? like, you only edit a video after it ends, really. otherwise you grab a specific clip from within the twitch app

https://api.twitch.tv/helix/streams?&user_id=<<SOME_USER_ID>> endpoint should allow you to get the id of the currently live stream if there is one, which can be used to filter it out of the VODs list
API Docs: https://dev.twitch.tv/docs/api/reference/#get-streams


Update Header and navigation bars to make them mobile ready

The current HTML layout of the navigation bars is incorrect and prevents the default Bootstrap hamburger icon from appearing when viewed on mobile devices.
You can simulate the mobile view by zooming in on your browser.
Refer to the Bootstrap documentation for the correct HTML layout to use. Take note of the order in which the classes are used (e.g. row, navbar, etc.): https://getbootstrap.com/docs/3.3/components/#navbar

Made some additional modifications based on feedback from @rhu001.
The site should be more responsive now ... as far as the header and footer are concerned (there are still some mobile display issues with the main content areas. Changing this would either require extensive customizations or changes to the core DMPRoadmap codebase).
All of the menus (fixed sign/signout, language, learn, create plan, dashboard, admin and Org specific links and email) are folded into the main hamburger menu when viewed from a mobile device. The Org name or the DMPTool logo appears to the left of the hamburger menu depending on whether the user is logged in and they are affiliated with an Org.
@stephaniesimms and @rhu001 if you could give it another review on dmptool-stg (especially from a tablet device) I would appreciate it. Please leave any suggestions for changes on this ticket.

i did some testing through resizing desktop browser windows and on mobile and noticed one minor thing:

vertical spacing for the Learn menu items on prod fills the dropdown area evenly (screenshot 1); it needs adjustment on stage (screenshot 2)

dmptool prod

dmptool stage

Tested in portrait view and landscape views on tablet. Landscape view showed normal desktop drop down menus; but, the portrait view did not show hamburger menu in right top corner. See attached screenshot below.

Also, tested on Chrome browser on tablet and when trying to login via homepage the portrait view also failed to show hamburger menu in right corner and the text banner on homepage lost its background. See attached.

There was also a spacing issue that I noticed on the homepage in both desktop as well as tablet landscape view. Extra spacing in between DMPTool by the Numbers and Top 5 Templates.

@stephaniesimms the link menu spacing should be better now.
@rhu001 I met with Joel and got some advice for my media queries and testing. Please take a look when you have a chanced let me know if things are ok on your iPad now.

link menu spacing is still off. most of the other things in this issue have been addressed so i'll close it and create a new issue with itemized fixes for spacing, etc.


JsonSerializer.Deserialize errors when encountering Long datatype

Code to reproduce issue:
var reqString = $"{{\"id\": {long.MaxValue} }}";
var test = JsonSerializer.Deserialize(reqString);

The issue can be found in LiteDB\Serializer\Json\JsonReader.cs - ReadValue(JsonToken token).  The switch statement chooses JsonTokenType.Number, and because of the lack of ".", tries to convert the value to an Int32.  Because the value is too big, it throws and overflow exception.

By default, JSON specs supports only int. To use long number you need "JSON long representation". {"id":{"$numberLong":"123456789"}}
https://github.com/mbdavid/LiteDB/blob/master/LiteDB/Serializer/Json/JsonWriter.cs

Unfortunately, this solution is not very convenient in practice. In particular, now I have a need to save in DB json which I receive from the server as a string. And now, unexpectedly, I began to get a System.OverflowException.
It would be much better if the already built-in JsonSerializer could automatically use int64 if the value does not fit in int32. And double if the value does not fit in int64. And do not throw an exception.
But since this is not the case, I will have to write "my" JsonSerializer which can do this.


Bunch of helper methods to listen Messages ☘

Added 32 new methods on Televerse class to make it easier to listen to various message updates.
Here are the methods that are added:

onAudio
onDocument
onPhoto
onSticker
onVideo
onVideoNote
onVoice
onContact
onDice
onGame
onPollMessage
onVenue
onLocation
onLiveLocation
onNewChatTitle
onNewChatPhoto
onDeleteChatPhoto
onPinnedMessage
onUsrShared
onChatShared
whenVideoChatScheduled
whenVideoChatStarted
whenVideoChatEnded
onVideoChatParticipantsInvited
onForumTopicCreated
onForumTopicEdited
onForumTopicClosed
onForumTopicReopened
onWebAppData
onAnimation
onText
onCaption

Also, added a new example file to demonstrate the simplest usage.


Better testing of strings

tests/strings.toml should have more cases added:

Non ASCII characters
Trying harder to break multiline basic strings
Making sure escaped characters work correctly

Basically it should test everything the TOML standard says they're for

Here are some specific issues I've noticed by working with the code and reading the spec. Even if people are aware of them, I think it's worth listing them here. (It might be worth making some new issue posts about them, but I decided to put them here because they have important information for making the new tests.)

Escaped characters are currently unimplemented. There's a TODO comment in Parser::parse_string about that.

Literal strings currently accept any and all UTF-8 content. That's almost correct, but I just noticed this sentence in the spec:

Control characters other than tab are not permitted in a literal string.

With that in mind, we should be checking for control characters and returning an error if one is encountered--as long as it's not '\t' or, for a multiline literal string, '\r' or '\n'. The extra test cases should, of course, cover those possibilities. According to https://en.wikipedia.org/wiki/Unicode_control_characters, the complete set of control characters is U+0000 to U+001F and U+007F to U+009F.

I'm pretty sure there's no handling yet for ending lines in basic strings with backslashes. As noted in the spec, if the last thing before a line's trailing whitespace is a backslash, the whole segment from the backslash to the newline is trimmed and the string continues. The spec doesn't say this implicitly, but I think it's only supposed to apply to a lone backslash--so the escaped form, \\, shouldn't cause that behavior. Otherwise, we might see this:
string = "foo\\
tbar" # Evaluates as "foo\tbar"

On the other hand, Github's markdown seems okay with it. Also, I don't think it applies to literal strings, since it's a form of escaping, but that might be wrong too. Maybe some of the pre-made test suites referenced in #19 can help us decide these two points.


API at velox level

@winningsix please take a look.

@XinDongIntel FYI.

Let's add this to VeloxPlugin.  It's not API for Velox.

@winningsix Please take a look further. And PR is submitted for VeloxPlugin repo.

Thanks @yma11 let's discuss it in your new PR.


<EMAIL_ADDRESS>has unmet peer dependency "expo@*"

Report
Plugin Version
6.9.4
On what Platform are you having the issue?
iOS + Android
What did you do?
Do anything with yarn (even unrelated to AppsFlyer) e.g. "yarn add some-other-package"
What did you expect to happen?
No warnings.
What happened instead?
Got a warning with line<EMAIL_ADDRESS>has unmet peer dependency "expo@*"
Please provide any other relevant information.
I'm not using Expo (so it's not in my project, hence the warning), and the peer dependency warning, even though harmless (things do work regardless of the error), is creating a clutter. Anyone who doesn't use Expo shouldn't see this warning.

Fixed in 6.10.1


Importing Workflows

Exporting SharePoint designer workflows seems to be working. Importing workflows however gives me:
Apply-SPOProvisioningTemplate : Value cannot be null.
Parameter name: input
Is this a known issue or am I doing something wrong?

Hi Pieter, Can you please recreate this issue in the PnP Core repository at https://github.com/officedev/pnp-sites-core, as this is provisioning engine related. The cmdlets are just a thin wrapper around that engine, and the engine is located in the core library.
Thanks!


K-L metric or loss

it makes sense to explore K-L distance as a loss function or metric, see:
https://github.com/dbuscombe-usgs/segmentation_zoo/issues/32#issuecomment-966740690

plotcomp_n_getiou now computes and reports K-L divergence for each validation and train pair tested in train_model.py

smaller values of KLD are better (smaller divergence)

Hatteras stats now:
Evaluating model on entire validation set ...
15/15 [==============================] - 2s 164ms/step - loss: 0.0222 - mean_iou: 0.9839 - dice_coef: 0.9778
loss=0.0222, Mean IOU=0.9839, Mean Dice=0.9778
Mean of mean IoUs (validation subset)=0.983
Mean of mean Dice scores (validation subset)=0.977
Mean of mean KLD scores (train subset)=0.142
Mean of mean IoUs (train subset)=0.988
Mean of mean Dice scores (train subset)=0.982
Mean of mean KLD scores (train subset)=0.100

also added KLD as a model training option
elif LOSS.startswith('k'):
    model.compile(optimizer = 'adam', loss =tf.keras.losses.KLDivergence(), metrics = [mean_iou, dice_coef])

needs:

[ ] test model training with KL-divergence
[ ] docs

trained resunet model with Kullback–Leibler on the Klamath L8 C/T imagery with 80% validation split and 0.2 dropout
As I suspected, the unet does converge easily and quickly

outputs are good, comparable to dice loss
perhaps  it is a good loss function for a Unet when you want to preserve the overall frequency distribution of classes in model predictions?

tested, docs updated. closing


New vendor: Magnum CI.

This scrapes the HTTP response when fetching the Magnum CI status badge.
Fixes #523.

Rebased against master.

Ping @espadrine.  Is there anything that needs fixing here?

Thanks a lot for the contribution!

@espadrine Fixed according to your comments.

Thanks a lot! As usual, this is live, and the website will be updated in 24h.


Any way to avoid duplicating API code across all Lambda functions?

Hello!
I've been playing around with this model and one of the things I'm noticing if that if you define your entire API in one file, the whole API is duplicated across every Lambda function that gets created (such as in the api_backend example), which seems cumbersome if there are many endpoints. Is there a way to have the convenience of implementing the API in one file while simultaneously distributing it across all Lambda functions without duplication? Or are there other best practices in place that I'm unaware of?
Any help would be much appreciated!

@jccrowley you can define the API on it's own as a Resource then Ref the resource. There is an example of this on api_swagger_cors here.

My apologies, I misspoke in the description of my question. I actually meant "I'm noticing if that if you implement your entire API in one file, the whole API is duplicated across every Lambda function that gets created." So, suppose you have a .js file with many API endpoints implemented. Is it possible to create many Lambda functions which execute these endpoints, without each Lambda function containing the entire .js file?

@jccrowley I don't quite understand your question. If you want each API to use a separate .js file, then you should do the split yourself. SAM can't do anything here.
Reopen if I misunderstood your question.


Provide some useful outputs; labels, policy

labels
List of labels that were set based on the provided policy. The output is a stringified JSON array.
policy
Policy that was used to set labels on issue. Value is a stringified JSON object.

Codecov Report
Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 45.18%. Comparing base (884efe5) to head (e798f22).
Report is 13 commits behind head on main.

Files
Patch %
Lines

src/action.ts
0.00%
2 Missing and 1 partial :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #336       +/-   ##
===========================================
- Coverage   64.04%   45.18%   -18.87%
===========================================
  Files           4        8        +4
  Lines         242      343      +101
  Branches       26       31        +5
===========================================
  Hits          155      155
- Misses         87      184       +97
- Partials        0        4        +4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Tested manually in the Demo repository:

https://github.com/jamacku/issue-forms-automation

Outputs works as expected


attr.ibs that will be _name-mangled should be attrs-init-mangled to  not ClassName

all attrs does is remove the leading "_" which is a bit unfortunate
import attr

@attr.s
class Breakfast:
    __spam = attr.ib()
    __eggs = attr.ib()

    @classmethod
    def create(cls):
        return cls(Breakfast__spam=1, Breakfast__eggs=2)

    def with_ham(self, ham):
       return attr.evolve(self, Breakfast__spam=process(ham))

I think it might be nicer as:
import attr

@attr.s
class Breakfast:
    __spam = attr.ib()
    __eggs = attr.ib()

    @classmethod
    def create(cls):
        return cls(**{cls.__spam: 1, cls.__eggs: 2})

    def with_ham(self, ham):
       return attr.evolve(self, **{type(self).__spam: process(ham)})

I currently work around it with
import re

import attr

class _Mangle:
    def __getattr__(self, name):
        return re.sub(pattern=r"\A_", repl="", string=name)

M = _Mangle()

@attr.s
class Breakfast:
    __spam = attr.ib()
    __eggs = attr.ib()

    @classmethod
    def create(cls):
        return cls(**{M.__spam: 1, M.__eggs: 2})

    def with_ham(self, ham):
       return attr.evolve(self, **{M.__spam: process(ham)})

I suspect (and just quickly half-confirmed) the fact that this does anything at all is just "by accident", and that the code just checks the first character of the attribute name.
Personally I'm on the "don't use mangled attributes" team, but I guess if you're going to use them, then yeah the logical thing to do is strip the class name too. Worth noting that the same "issue" happens if you want double-underscore names, i.e.
@attr.s
class Foo(object):
    ___foo__ = 12

has to be initialized via Foo(foo__=12) which is yeah...

OK, y'all win: @attr.s(strip_underscores=True) – go! ;)

@hynek well I don't that will help

OK, y'all win: @attr.s(strip_underscores=True) – go! ;)

@hynek could I read this as... you'd be open to a PR on https://github.com/python-attrs/attrs/issues/945?

So I believe the worst brunt of this bug is fixed by #950 and I wonder if it's possible to fix this (i.e. __spam field becoming a spam argument) without breaking the whole ecosystem?


VHF2 unusable with Fenix2GSX open

I like to use VHF1 and VHF2 while flying on VATSIM, but whenever Fenix2GSX is open, my VHF2 becomes unusable. I have the audio panel setup correctly, but I can't hear anything. Once I completely close F2GSX, my audio comes back.

Uhm okay, can't imagine how that should happen.
So vPilot is configured as VHF1 App and you can control the Audio-Volume with the VHF1 Knob (ACP1)?
Please provide the exact Steps and Settings so that I can reproduce that.

To be completely honest I haven't used the VHF1 Audio Volume feature within F2GSX. I will try to fly next flight with/without it to see if that somehow changes the behavior, as well as get some steps for you. I didn't do anything special, but this is only my second flight with the app.

What do you mean by "haven't used the VHF1 Audio Volume feature" ?
The Thing is, vPilot is set by default:
So that either means you changed that in the GUI to nothing, in which Case it should not control the vPilot Volume any longer (as last step before stopping the Control it sets the App-Volume to 100% and to unmuted, if the App is running).
Or it means you have not changed that Setting in the GUI and it did control vPilot Audio. But I could not see any Effect in a quick Test (without connection) when I selected VHF2 for transmit or receive. Please note that when you deselect VHF1 for receive, vPilot will be completely muted. The Volume Control of Fenix2GSX works on the OS-Level - the whole Audio-Session of the respective Application is controlled. And with that all the "virtual Channels" an App may provide.

https://streamable.com/o97zrx
Here's a video showing the behavior. You can see the settings and everything, once I completely close F2GSX my audio is restored.

That is exactly what I have described.

Missed that, my mistake. Is there any way to not have that happen?

Depends.
You can of course disable that Feature of Fenix2GSX - just remove vPilot in the GUI (so the Textbox in the GUI is empty).
But when that Feature is enabled, the VHF1 Knob is the Volume-Control-Knob for the whole vPilot App.
If the Knob is pulled was specifically chosen for mute / unmute - so that muting/unmuting leaves the Volume Level intact (and being quicker than turning it 0). So that will not Change.
I think I'll add another CheckBox for the VHF1 Volume-Control for it to be enabled/disabled that Way. Should be more intuitive and would allow to change that Setting more quickly if it is just for enabling/disabling.
But I need to think about it, if add any other Check or so. Sure, I could monitor the VHF2-Rec-Latch also and prevent the Mute if it is pulled ... but then the Volume-Level of vPilot would still be controlled by the VHF1-Knob. That could also interfer with Use-Cases where a User specifically wants to have the VHF1-App muted even when VHF2 is pulled. So I would need other Check-Boxes for the if & how and that all adds more complexity and thus likelyhood for Bugs ... but at the Moment I want to get it in a State to share it with a wider Audience (through flightsim.to) 🤔

After I've looked up how it is working on the FSL, I'd go for this Compromise: The Mute/Unmute by Push/Pull of the Record Latch is now a configurable Option which defaults to false:

What do you think? :)

Sounds good to me, thanks again for looking into this


Update Robolectric 4.3 -> 4.4.1

I update Robolectric version because we are having https://github.com/robolectric/robolectric/issues/5456 this issue. Robolectric can't download its own artifacts during running tests.
Release notes:
https://github.com/robolectric/robolectric/releases/tag/robolectric-4.4

Lots of fixes and improvements.
Support for Java 11

Robolectric 4.4.1 version somehow stuck the build. Tests are running for 4 hours and I had to force stop the build.
If I bump to the later version of Robolectric, then I get this issue https://github.com/robolectric/robolectric/issues/6521
So I think the easiest and future-proof fix would be to disable Jetifier


add back replaces line for squash taxbrain migrations

Further fix for #211

Sorry, initial submission was from my fork, resubmitted as a direct branch off this repo.

@MattHJensen @talumbau closing as stale

Thanks @brendancol, per the conversation in #211 and the lack of users with older local repos experiencing the problems this fixes, this PR is unnecessary.


Fixed Halloween every month issue

Hello. This was fixed in a previous PR (https://github.com/scrabill/how-many-days-until-halloween/pull/8) but feel free to make other adjustments if you have any.


Look into possibly enabling IF's sign rendering optimization

No longer available as an option in the config


Fix missing env kwarg.

Codecov Report
Base: 29.39% // Head: 29.39% // No change to project coverage :thumbsup:

Coverage data is based on head (5bc2977) compared to base (8fba3ff).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           stable     #976   +/-   ##
=======================================
  Coverage   29.39%   29.39%
=======================================
  Files          72       72
  Lines        5872     5872
  Branches      314      314
=======================================
  Hits         1726     1726
  Misses       4070     4070
  Partials       76       76

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Tutorial Proposal for ISBI (deadline: 09/25)

@josephmje how are we doing on this front?

Thanks for the poke @oesteban . My apologies, I should have shared my notes earlier. Here's a link to the Google Doc. I thought of some potential topics to cover under the "Brainstorming Topics" heading. If you have any more, please add them there. I can then expand on the rest of the required information.

Paging @garikoitz.
@josephmje - it seems we can't edit or comment.

Just updated the permissions. Can you please check if it works now?

It works now - thanks!

Does anyone feel in favour or opposed to any of the topics I proposed? Would anyone also like to teach one of them?

Okay, I made a quick draft for the whole thing. I thought it was limited to one page and then I found out that it is 4, with 4000 characters limit for the outline.
I guess given the time we have (i.e., we need to send it out today), we can just send it as it is and see what happens.
LMKWYT
Esp. interested in feedback from @arokem and @dPys, as I placed their work at the core of the proposal. Also @edickie as I wrote her name as a presenter with mine, and @josephmje if he wants to be the presenter in my place.

Thanks for the push on this @oesteban. I just made a few tiny changes and added a prerequisites section. I'd be happy to have you as presenter on this. I would be interested in contributing to the tutorial content.

For the rest of the folks, the link to Michael's draft is here - https://docs.google.com/document/d/1pl1X6IxVmjhcv0svXCTPJJPn5L3e_yT-IHsykk0wHYc/edit?usp=sharing

Ugh, I now realize that the reference was indeed for the tutorial - sorry for not including. For some reason I thought this was actually a suggestion for dMRIPrep in general.
The proposal is now sent. Fingers crossed! Thank you all :)

👏 🎉

Hey everyone, this looks awesome! Nice work putting this together.


Not able to use qdt-components with qlik sense enterprise

By reading the docs and trying out the samples, I am really excited to use the qdt-components in a Single Page application that I am working on which needs to display visualizations from qlik sense enterprise server.
What  I am not able to get working is the authentication after trying out quite a many things. The single page application is React 16 application. I could embed visualizations from 'sense-demo.qlik.com' however when I change the sense host in the config to our sense enterprise server, it refuses to connect.
Below is the config object that I am passing to qdtEnigma.
const config = {
host: 'host name of the sense enterprise server',
secure: true,
port: 443,
prefix: '',
appId: 'appId of one of the sense app'
}
const engineApiAppPromise = qdtEnigma(config);
I also, tried creating a virtual proxy in qmc and generate a JWT token and use that token in the config object. But it doesn't seem to help. I keep getting the error "Your connection to the Qlik Sense server is lost due to inactivity, refresh to continue working."
const config = {
host: 'host name of the sense enterprise server',
secure: true,
port: 443,
prefix: 'jwt',
appId: 'appId of one of the sense app',
token: 'jwt token here'
}

@vilaspd Did you check https://github.com/qlik-demo-team/qdt-components/issues/213? That seems similar. For me it helped setting the prefix in the config object to the value of the virtual proxy.


Verify configs to be in line with upstream

https://github.com/helium/sx1302_hal/tree/helium/hotspot/packet_forwarder
Acceptance Criteria:

SX1301 backwards compatibility

List of available regions generated by the helium miner are https://github.com/helium/miner/blob/master/priv/countries_reg_domains.csv.


3.2 Assumptions Covert Channels

The wording of Assumption for Covert Channels is awkward. Recommend something like: "There is sufficient assurance, relative to the value of the VM’s IT assets, to address the risk of covert storage and timing channels to the VMs executing on the TOE."

I changed the assumption to use those very words.  But I have some reservations about keeping this as an assumption. Maybe it should become a threat that is addressed by the update requirement. Maybe the assumption should be limited to the platform (i.e. processor covert/side channels).

I changed the assumption to use those very words.  But I have some reservations about keeping this as an assumption. Maybe it should become a threat that is addressed by the update requirement. Maybe the assumption should be limited to the platform (i.e. processor covert/side channels).

Nah. Leaving it alone.


[AutoPR cognitiveservices/data-plane/ContentModerator] Update contentmoderator Node.js package version to 3.0.0

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/3546

(message created by the CI based on PR content)

NodeJS PR


Difficulty using sqlc.narg in a WHERE clause

Version
Other
What happened?
I am so excited for nullable params!!
I was trying to test out the new sqlc.narg() functionality on main, and I am having trouble with it.  I was hoping to use this support more flexible WHERE clauses.  What I am seeing is that the parameter that I am using is being dropped and the compiler is emitting an error, but, confusingly the whole thing runs to completion.
I am running sqlc compiled from edb956047a10f8f928cdb8a131d18133c95ce809
CC @skabbes
Relevant log output
I get, from the compiler:

$ sqlc generate
unsupported reference type: <nil>$ echo $?
0

Here is the generated code.  You can see that it ran to completion, but dropped the parameter, thereby creating nonsense code:

const listAuthors = `-- name: ListAuthors :many
SELECT id, name, bio FROM authors
WHERE $1 IS NULL OR $1 = name
ORDER BY name
`

func (q *Queries) ListAuthors(ctx context.Context) ([]Author, error) {
        rows, err := q.db.Query(ctx, listAuthors)
        if err != nil {
                return nil, err
        }
        defer rows.Close()
        var items []Author
        for rows.Next() {
                var i Author
                if err := rows.Scan(&i.ID, &i.Name, &i.Bio); err != nil {
                        return nil, err
                }
                items = append(items, i)
        }
        if err := rows.Err(); err != nil {
                return nil, err
        }
        return items, nil
}

Database schema
-- Example queries for sqlc
CREATE TABLE authors (
  id   BIGSERIAL PRIMARY KEY,
  name text      NOT NULL,
  bio  text
);

SQL queries
-- name: ListAuthors :many
SELECT * FROM authors
WHERE sqlc.narg('name') IS NULL OR sqlc.narg('name') = name
ORDER BY name;

Configuration
version: "1"
project:
    id: ""
packages:
  - name: "test"
    path: "test/"
    sql_package: "pgx/v4"
    engine: "postgresql"
    emit_interface: true
    # Filenames are organized to support make rule
    schema: "test/test.sql"
    queries: "test/test.sql"
    output_db_file_name: "test-db.go"
    output_models_file_name: "test-gen-models.go"
    output_querier_file_name: "test-gen-querier.go"

Playground URL
No response
What operating system are you using?
Linux
What database engines are you using?
PostgreSQL
What type of code are you generating?
Go

Thanks for the great report, I'll take a look after my $DAYJOB is done.

@danielbprice this was a bug that predated sqlc.narg, is has to do with sqlc's handling of IS NULL and IS NOT NULL expressions.  I can't help fix the immediate bug, but I can offer a workaround.  If you cast the sqlc.narg call to the same type as the column, the code generation will succeed.  Hope that unblocks you from using sqlc.narg more broadly!
-- name: ListAuthors :many
SELECT * FROM authors
WHERE sqlc.narg('name')::text IS NULL OR sqlc.narg('name') = name
ORDER BY name;

@kyleconroy this bug is that *ast.NullTest is not handled in compiler/resolve.  Though even if if were implemented, it looks like there needs to be a typechecking pass which can make sense of the all the uses of a named argument.

That's an awesome workaround, thanks!


Separate node test cases into small functions

Fixed issue: https://github.com/rancher/longhorn/issues/141

@yasker Fixed


feat: set proxy

Overview

Checklist

[ ] New and updated code has appropriate documentation
[ ] New and updated code has new and/or updated testing
[ ] Required CI checks are passing
[ ] Visual proof for any user facing features like CLI or documentation updates
[ ] Linked issues closed with keywords

not needed anymore


12.16 Upgrade

Feature: Added a new transaction type: Transaction Reversal

Todo possible files still waiting for upgrade:

[ ] BatchRequest.php
[ ] BatchRequestFunctionalTest.php
[ ] TransactionReversalFunctionalTest.php
[ ] CnpRequestFunctionalTest.php
[ ] TransactionReversalReversalUnitTest.php
[ ] Transactions.php


chore: Add changelog for new 3.20.10 release

New version 3.20.10 has been released
📝 You can modify the changelog template online here
Jira issues
See all Jira issues for 3.20.10 version

Closed as I put these changes in the PR for 3.21.x https://github.com/gravitee-io/gravitee-access-management/pull/2788


Can't restart unicorn

When running deploy, see weird output from the unicorn task
INFO[5c90314d] Running /usr/bin/env sudo /etc/init.d/nginx reload on x.x.x.x
DEBUG[5c90314d] Command: /usr/bin/env sudo /etc/init.d/nginx reload
DEBUG[5c90314d] 	 * Reloading nginx configuration nginx
DEBUG[5c90314d] 	[80G
DEBUG[5c90314d]
DEBUG[5c90314d]
DEBUG[5c90314d] 	[74G
DEBUG[5c90314d] 	[ OK ]
DEBUG[5c90314d]
INFO[5c90314d] Finished in 0.134 seconds with exit status 0 (successful).
INFO[93cdc175] Running /usr/bin/env service  restart on x.x.x.x
DEBUG[93cdc175] Command: /usr/bin/env service  restart
DEBUG[93cdc175] 	restart: unrecognized service
DEBUG[93cdc175]
cap aborted!

For what its worth I ran into this too and the 'no such service' wasn't what was actually wrong...it was just the last thing in the logs before something else broke (found in app/shared/log/unicorn.stderr.log)


[BUG] VMs fall into a cycle of Running -> Paused

Describe the bug
After a time, certain VMs fall into a perpetual cycle of Running->Paused. Sometimes they show an IOError sometimes not. The most common IOError when shown is a volume that is mounted does not have enough space but upon inspection of Longhorn shows none of the volumes are near the storage limit and all show healthy with multiple replicas.
To Reproduce
Steps to reproduce the behavior:
I have no idea. It seems randomly consistent
Expected behavior
VMs don't pause for seemingly no reason
Support bundle
I've shared the bundle on slack but if it is needed by someone else let me know
Environment

Harvester ISO version: v1.1.2
Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630):
Baremetal on Supermicro 1U (can't remember the model)

Hi @sam-ulrich1, it would be nice if you could attach the SB file here. Any chance you got screenshots when the issue happened?
Thank you!

https://drive.google.com/file/d/10wPWAXqq7f91BBzVWPvEOFDKkpWzMvx0/view?usp=sharing
It's too big to upload here

@starbops

Additional Info:
The issue happens seemingly randomly on nodes that host a volume provisioned by the internal harvester longhorn but supplied to an RKE2 cluster running on top of the harvester vms. The RKE2 cluster uses harvester as the cloud provider in this situation. Nodes that do not host volumes for the RKE2 cluster never have this issue.
Unfortunately, I did not know I needed to expand the scope of the support bundle so that the support bundle will not show the namespace that contains the failing VMs. I will update the ticket with a new support bundle when it happens again. It normally happens every 2-4 days so shouldn't be long
Rancher Version: 2.7.4
RKE2 Version: v1.25.10 +rke2r1

please define the extra namespaces in the support-bundle-namespaces setting

Updated with the gigo-production namespace where the failure is happening
https://drive.google.com/file/d/1ZYzws_aUhBlqTfjcrBd2JiigMAwPHLg6/view?usp=sharing
@ibrokethecloud

the VM paused is running on hm9.
The kernel seems to indicate a few messages about link status changing..
Aug 16 17:10:26 hm9 kernel: IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
Aug 16 17:26:41 hm9 kernel: IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
Aug 16 17:35:54 hm9 kernel: IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
Aug 16 17:48:29 hm9 kernel: IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready

This seems to correlate with some iscsi logout/login messages for a pvc in use by vm:
Aug 03 03:36:32 hm9 iscsid[25737]: iscsid: Connection280:0 to [target: iqn.2019-10.io.longhorn:pvc-13a285e4-4d6a-4deb-99bf-e1f35e9a1e20, portal: <IP_ADDRESS>,3260] through [iface: default] is operational now
Aug 16 17:35:43 hm9 iscsid[25737]: iscsid: Connection280:0 to [target: iqn.2019-10.io.longhorn:pvc-13a285e4-4d6a-4deb-99bf-e1f35e9a1e20, portal: <IP_ADDRESS>,3260] through [iface: default] is shutdown.
Aug 16 17:35:51 hm9 iscsid[25737]: iscsid: Connection294:0 to [target: iqn.2019-10.io.longhorn:pvc-13a285e4-4d6a-4deb-99bf-e1f35e9a1e20, portal: <IP_ADDRESS>,3260] through [iface: default] is operational now

I suspect the network may not be stable which may be causing the volumes to be unreachable followed by the IO error in launcher pod, which results VM being paused.

We will review the HW this weekend to better understand what might be causing it. The net HW is slightly more complicated than most since it's running a qsfp+ card so it could be a bad card, driver malfunction or some other funky config

Closing since this seems to be resolved with HW repairs. Thanks so much for the help in both this case and helping me understand the support bundle


treewide get rid of go 1.12

Motivation for this change
Getting rid of go1.12 dependencies so we can drop go1.12. Also this accidentally got dropped out of #81159
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@worldofpeace Sorry - these got dropped out of #81159

And I got excited, so this PR now completely removes go 1.12 (and almost go1.13)

@kalbasit @worldofpeace  Any chance you could review + merge?

@c00w Yeah a rebase is needed. (and resolve conflicts). Merge seems good to me.

Rebased - everything still passes with
nix-build -A lnd -A perkeep -A openshift -A packr -A consul -A scaleway-cli -A prometheus-varnish-exporter -A curlie -A grpcui -A ipfs -A nomad -A gobetween -A cockroachdb -A gotestsum -A magnetico -A tendermint -A cri-o default.nix

@kalbasit @worldofpeace  Should be good for another round of review :)

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/147

@GrahamcOfBorg eval

Thanks :) AFAIK I don't have permission to merge, or talk to the bot, so someone needs to fix it.
The eval failure is actually a interesting bug in grahamcofborg, where if you delete a file, it fails. And since by design I'm deleting to go1.12 files, it gets hit.

The eval error is
while evaluating the attribute 'deps' of the derivation 'bazel-watcher-0.10.3' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/hetzner-sb65-1083082-hel1-dc2/pkgs/build-support/build-bazel-package/default.nix:42:10:
while evaluating the attribute 'nativeBuildInputs' of the derivation 'bazel-watcher-0.10.3-deps' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/hetzner-sb65-1083082-hel1-dc2/pkgs/build-support/build-bazel-package/default.nix:45:5:
while evaluating 'getOutput' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/hetzner-sb65-1083082-hel1-dc2/lib/attrsets.nix:464:23, called from undefined position:
while evaluating anonymous function at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/hetzner-sb65-1083082-hel1-dc2/pkgs/stdenv/generic/make-derivation.nix:133:17, called from undefined position:
while evaluating 'callPackageWith' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/hetzner-sb65-1083082-hel1-dc2/lib/customisation.nix:117:35, called from /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/hetzner-sb65-1083082-hel1-dc2/pkgs/top-level/all-packages.nix:8562:13:
while evaluating 'makeOverridable' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/hetzner-sb65-1083082-hel1-dc2/lib/customisation.nix:67:24, called from /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/hetzner-sb65-1083082-hel1-dc2/lib/customisation.nix:121:8:
getting status of '/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/hetzner-sb65-1083082-hel1-dc2/pkgs/development/compilers/go/1.12.nix': No such file or directory

Using rg I find
pkgs/top-level/all-packages.nix
8515:  go_1_12 = callPackage ../development/compilers/go/1.12.nix ({

we need to actually remove go_1_12 in all-packagesnixand add an alias inalias.nixtothrow`.

Good catch - deleted missing reference in go_1_12. I don't see go_1_11 in aliases.nix, so it seems like it's unlikely to be needed?

Rebase on top of the PR removing go1.13

I don't see go_1_11 in aliases.nix, so it seems like it's unlikely to be needed?

There isn't really a likelihood of something needing an alias or a throw, it's pretty definite if something is renamed or either removed. For the end-user, having something like
buildGo112Package = throw "buildGo112Package has been removed from nixpkgs.";

is slightly more helpful than an attribute just not existing.

Seeing this hasn't been done regularly we could ignore that for this particular PR, but I know these help people.

@worldofpeace Added.

Updated PR with latest master due to a conflict.

Rebased on master.

Thank you for your patience @c00w and your contribution :sparkles:


[WIP] IPC GUI Update #2

Basic ToDo List
Advanced ToDo List
Note to myself: git pull https://github.com/JustArchi/ArchiSteamFarm master

You can also do git remote add upstream https://github.com/JustArchi/ArchiSteamFarm and afterwards just git pull upstream master 🙂

Random idea: it'd probably make sense to change changelog link to https://github.com/JustArchi/ArchiSteamFarm/releases/tag/{version}, since user can then navigate between ASF versions, and it's far more readable than my commits mess. Up to you though.

You can also do git remote add upstream https://github.com/JustArchi/ArchiSteamFarm and afterwards just git pull upstream master slightly_smiling_face. Likewise when you push you can do git push origin master.

Thank you for trying to help me but I think its hopeless. I am too noob 2 github. For now I have figured out a way thats working (the way you showed me). And you know the saying: never touch a running system :joy:

Random idea: it'd probably make sense to change changelog link to https://github.com/JustArchi/ArchiSteamFarm/releases/tag/{version}, since user can then navigate between ASF versions, and it's far more readable than my commits mess. Up to you though.

Good idea, I added it.

Font choice for the command window would be nice - Times New Roman is horrid :)

Let's hardcode comic sans 😆

The font for the console and log should be lucida console 😕

I wonder if we could hook game banners on detailed bot view somehow, so user could see what exactly is idled. Since there is a gurantee that only up to 32 games there will be, I think it could fit somehow. Just a random suggestion though, you're designing GUI here.

so user could see what exactly is idled.

They can already see which games are being idled.
But I get what you mean. I also think it would look better with an image instead of plain text.
I could scrape the image on the shop site for each game and display it. Thats not the problem.
I think the challange will be to make it look good.
Do you have any ideas or suggestions?
Another problem right now is that I have no games to farm currently, so testing will have to wait until I get some new games.

 Perhaps something similar to Steam grid?

Even better if instead of hardcoding we could make size of images dynamic so it fits into given div.

Thats a default thing thanks to bootstrap.

For example smaller images when idling multiple, and a bigger banner when idling solo.

Thats a great idea! I will see what I can come up with once I got some new games to test with.

@JustArchi
I added a basic version of what you suggested. I could only test it with one game farming.
Do you have any games that needs to be farmed and could test the new design?

Maybe later I add more, since right now I'm out of games as well, not to mention my account uses simple algorithm in the first place.
I'm sure somebody can test it for you, just push your updates (I see that you did already) and maybe somebody will grab latest AppVeyor build and test the thing - https://ci.appveyor.com/project/JustArchi/archisteamfarm/build/4961-master-bbrossai/artifacts

With multiple games farming it looks like this
https://fs.ilold.de/images/2018-02-05_08-57-18.png
But in order to display this account(main) I needed to remove my other 2 bot accounts, a bit strange.

@jarlave
Thank you for testing it!

But in order to display this account(main) I needed to remove my other 2 bot accounts, a bit strange.

Why is that?
@JustArchi
I got the following situation and I wonder what you think about it:
Lets say we have a bot thats started by ASF and got some games to farm. When I now use that bot to play a game on my pc, ASF will stop farming until the bot is not being used anymore. If I run !status it will return Bot is currently being used.
How would you determine this state of the bot by using /Api/Bot/?
One quick idea would be to check the following:
CardsFarmer.Paused === false
CardsFarmer.GamesToFarm.length > 0
CardsFarmer.CurrentGamesFarming.length === 0
Another idea would be to expose PlayingBlocked in /Api/Bot/.
Something similar to CardsFarmer.Paused like CardsFarmer.Blocked maybe?
What do you think about that?

@MrBurrBurr I made a bit troubleshooting today and foudn out, it's because of the bot name from my control bot (c&c) after I renamed this bot to cnc all bots are shown. So & is a problem, but cnc is ok too :)
not it looks like this https://fs.ilold.de/images/2018-02-05_21-54-27.png

@jarlave

So & is a problem, but cnc is ok too

Its because at the moment there is no input sanitation. This will be fixed in a future update.

@MrBurrBurr I added ASF's IsPlayingPossible property to API.

I think we could improve time display in general, 00:00:30 to indicate farming time doesn't seem much user friendly IMO, I think moment.js can be a nice add. The fact that they have support for localization is also nice.

since you're on version 4.7.0, maybe it's worth upgrading.

I will update as soon as its available on cdnjs.com.

Seems like somewhat of a breaking change.

It definitely is, but I figured that since the UI is still in development, this could be a great time to upgrade. But it's definitely not trivial to upgrade right now.

@jarlave
Could you test the new carousel with multiple games farming? https://ci.appveyor.com/project/JustArchi/archisteamfarm/build/4965-master-jggectuw/artifacts
@felipe19930
I added slick-carousel to the bots detailed overview. Its still the old design because I was lazy and first wanted the logic part to work. I think I am doing something wrong since the carousel wont display the first item. You have to wait for it to autoscroll (or click on the buttons if they were active). Can you help out?

the carousel wont display the first item.

Not only that, but there's a huge delay when you expand the bot box. What is happening is that slick is still running in all bot boxes (in background), even when the box is collapsed. To see that just inspect the page and search for the slick-initialized class. Here's a way of fixing it:
Replace this block of code (from line 292 to 306) with this one:
$('#bot-box-' + BotName).boxWidget({
        animationSpeed: 500,
        collapseTrigger: '#collapse-trigger',
        collapseIcon: 'fa-minus',
        expandIcon: 'fa-plus',
    })
    // This will be triggered if a user expands the BOT menu.
    .on('expanded.boxwidget', function(BotName) {
        var botCarousel = $('.games-carousel-' + BotName);

        // Checks if Slick was already initialized...
        if ($(botCarousel).hasClass('slick-initialized')) {
            // Slick is set up, so just resume the animation.
            $(botCarousel).slick('slickPlay');
        } else {
            // Sets up Slick for the first time.
            $(botCarousel).slick({
                slidesToShow: 1,
                draggable: true,
                autoplay: true,
                autoplaySpeed: 2000,
                arrows: false, //move arrows inside of .game-box
                infinite: true
            });
        }
    }.bind(null, BotName))
    // This will be triggered if a user collapses the BOT menu.
    .on('collapsed.boxwidget', function(BotName) {
        // Just pause Slick's animation and collapse the menu.
        $('.games-carousel-' + BotName).slick('slickPause');
    }.bind(null, BotName)
);

This approach is better because it doesn't let slick animate stuff in background when the box is collapsed.
I know you still haven't finished the layout yet, however, the fix above introduces another visual issue when you expand the bot box: you can still see the two game banners for a short period of time:

You most likely already know how to fix it, but anyway, here's how: add each <img> banner inside of a <div> and then set the max-height of that div to 215px (which is the height of 1 banner only).
About that last issue you mentioned, perhaps @JustArchi could implement it? It'd be great.

Thank you for your fix @felipe19930! I added it.

About that last issue you mentioned, perhaps @JustArchi could implement it? It'd be great.

Archis answer on discord: It doesn't make sense because of algorithm's complexity and non-predictable time of a single queue

No problem! :+1:

To elaborate more on this - ASF farming X games in CurrentGamesFarming does not specify how much time would be needed for a single game. For example, we could have 10 games with 3 cards each, and maximum amount of hours played in all would be 1. Now, should that game have time remaining of 90 minutes (for 3 cards), 120 minutes (for 3 cards + mandatory bumping), 300 minutes (for 3 cards + mandatory bumping, then 6 cards more from other games before this game starts being idled) or who knows how much, because in 15 minutes from now a game you already idled for 2 hours will get cards added and ASF will switch to that one instead?
Like I said, non-predictable. TimeRemaining of GamesToFarm is predictable because ASF doesn't have to take in account all nifty details like games order, priority queue, things getting changed dynamically or other things. We can say how much we expect for the entire queue to take (based on sum of all remaining cards, amount of hours from all games and HoursToBump bot config property), but we can't precisely say when given game finishes farming without taking in account not only all of the above, but priority queue, FarmingOrder, then priority based on hours of those games and so on. It'd be totally inefficient to do all of that.

It does make sense, thanks for the insight.

https://github.com/MrBurrBurr/ArchiSteamFarm/blob/a4f6b6e6eb6f1991621979dd0b861d9e761afe2e/ArchiSteamFarm/www/pages/log.html#L173-L174
You need to put the IPCPassword inside of encodeURIComponent(), otherwise people who have characters like & or # won't be able to login. Also, unfortunately there's no way of adding custom headers in WebSocket requests as of today standards.

Unfortunately there's no way of adding custom headers in WebSocket requests as of today standards.

I don't see how you couldn't add header the moment you do first initial request asking server to upgrade your request to websocket in the first place. It's silly javascript limitation at best, because RFC doesn't forbid in any way usage of custom HTTP headers on initial request.

Most definitely is a Javascript limitation. It's also really weird, because XMLHttpRequest is obviously widely used and always had support for custom headers, so it doesn't even make sense why they decided to not include support for that in WebSockets. But oh well, we are just mere mortals compared to the guys from WHATWG, they must have a strong reason for not adding that... I hope.

It's alright, ASF also supports authentication in query string and we don't need to work around an issue that doesn't exist. It'd be cool if we could use auth headers everywhere, but if we use it everywhere but in websockets only because they can't support it properly then it's alright trade-off for not spending hours re-inventing the wheel only because somebody missed a crucial for us feature. It's OK as it is.

@felipe19930

You need to put IPCPassword inside of encodeURIComponent(), otherwise people who have characters like & or # in their password won't be able to login. The same is necessary for requests that need the bot's name.

I added it, thanks!

@MrBurrBurr looks good on my side https://fs.ilold.de/files/2018-02-06_15-13-13.mp4

I added the latest version of font-awesome.
If you see any icons that look out of place or if you know an icon that would fit better, please let me know.

IPC GUI log worked fine for me on firefox and edge, doesn't work on chrome for some reason

For me it works on latest chrome. Are you using any adblocker?

I see you removed WIP tag, so I guess it's ready to be merged.


Update CPACS Schema to 3.3

Description
Fixes #883.
This PR updates the CPACS schema file to 3.3. New geometric definitions coming with CPACS 3.3 (e.g. superellipses for fuselage profiles) will be part of seperate issues.

How Has This Been Tested?

Screenshots, that help to understand the changes(if applicable):
Checklist:

[ ] A test for the new functionality was added.
[ ] All tests run without failure.
[x] The new code complies with the TiGL style guide.
[x] New classes have been added to the Python interface.
[ ] API changes were documented properly in tigl.h.

Codecov Report

Merging #907 (828ad47) into master (6b764bd) will decrease coverage by 0.04%.
The diff coverage is 44.23%.

@@            Coverage Diff             @@
##           master     #907      +/-   ##
==========================================
- Coverage   69.56%   69.52%   -0.05%
==========================================
  Files         298      298
  Lines       24947    24974      +27
==========================================
+ Hits        17355    17363       +8
- Misses       7592     7611      +19

Impacted Files
Coverage Δ

src/CCPACSEtaIsoLine.cpp
59.45% <0.00%> (-5.25%)
:arrow_down:

src/CCPACSStringVector.cpp
86.53% <0.00%> (-5.30%)
:arrow_down:

src/CCPACSXsiIsoLine.cpp
15.78% <0.00%> (-2.97%)
:arrow_down:

src/cpacs_other/CCPACSMaterialDefinition.cpp
54.54% <ø> (-4.72%)
:arrow_down:

...c/fuselage/CCPACSFuselageStringerFramePosition.cpp
4.72% <16.66%> (+0.65%)
:arrow_up:

src/CCPACSCurveParamPointMap.cpp
54.28% <33.33%> (ø)

src/CCPACSPointAbsRel.cpp
70.31% <62.50%> (-2.42%)
:arrow_down:

src/CCPACSPoint.cpp
62.90% <80.00%> (+1.49%)
:arrow_up:

src/CCPACSCurvePointListXYZ.cpp
86.66% <100.00%> (ø)

src/geometry/CCPACSTransformation.cpp
76.97% <0.00%> (-1.55%)
:arrow_down:

... and 1 more

@AntonReiswich, this PR is - again - ready for review.

@joergbrech Great, thanks!


Run Experimental SDK in cluster

requirements

experimental sdk is running in production cluster
if experimental sdk errors or is unresponsive, this does not affect performance for live users
sdk team can run a command to deploy new versions of sdk without involving andrey

non-requirements (for now)

understandable log messages. sdk team will deal with messages it does not understand
fast deploy/restart time.
stable sdk. it may error or freeze. it may also be killed at any time by lbrytv or k8s or andrey if they detect that it poses a threat to performance for live users
too much of andrey's attention. if he has to spend a lot of time on outages or debugging, experimental sdk will be shut down until issues are addressed

punchlist

[ ] figure out how to deploy nvme nodes, as required by sdk hardware requirements
[ ] decrease timeout on lbrytv-api requests to experimental sdk so they don't pile up if sdk is unresponsive. this can be very conservative to start.
[ ] give sdk team the process for how to deploy and monitor experimental sdk
[ ] sdk team cleans up logging at least enough for andrey to know what's going on as he's managing the cluster

talked to @andybeletsky. new plan:

sdk team runs and manages full nodes on their own, outside cluster. set up several servers like the one we have, for redundancy
andrey needs

instructions on how to run and configure light clients
where wallets are stored (filesystem?)
whats the wallet loading procedure? this is hardcoded in lbrytv rn and may be the biggest chunk of work for andrey. would be good to know this so he can estimate his time


Conforming to PEP8

@wileyyugioh Should I reformat the code conforming to PEP8?

By all means go ahead. Make a pull request and I'll likely merge it.

https://github.com/wileyyugioh/kissanime_dl/commit/1030f164b772f43d04ec7ffe99e6778b87ebbc8b fixes this enhancement


should DeepSpeedEngine.save_checkpoint be only under main_process

Describe the bug
If DeepSpeedEngine.save_checkpoint should be run only under main_process(rank=0) ？
I have seen the save the model only for the main process when using the distributed training mode in pytorch inside https://pytorch.org/tutorials/intermediate/ddp_tutorial.html, but it seems that there is no need to be under main_process when using save_checkpoint. Does any know why ?
If the save_checkpoint is under main_process in huggingface diffusers, the save stage will hands on.
System info (please complete the following information):
Ubuntu 20.04
Nvidia GTX 3090
CUDA Version: 11.7
Torch: 1.13.1
Diffusers: 0.15.0.dev0
deepspeed: 0.8.1
xformers: 0.0.17.dev466
accelerate: 0.16.0

@better629, for DP training the ranks have exactly the same model state so it would be wasteful for all the ranks to write out the same checkpoint state. Alos, using rank=0 is just convention.

@tjruwase Yes, I do think so.
But as the issue mentioned, if i judge rank==0 before save checkpoint, the process will hang on under DeepSpeed. It's a little confusing.
application related issues are https://github.com/huggingface/accelerate/issues/1171 and https://github.com/huggingface/diffusers/issues/2606

@better629, sorry I think I misunderstood. The documented expectation that all ranks should call DeepSpeedEngine.save_checkpoint(), even if in reality only DP rank 0 will actually create a checkpoint file. Otherwise, you will observe the hang as there is a barrier in that call. Can you please try that to see if it fixes the issue?

@tjruwase I was confused with why all ranks should call save_checkpoint which is different with pytorch ddp. Since there is a api description, I will try to find it out from code.

@better629, optimizations such as the following are possible because all data parallel ranks call save_checkpoint: https://github.com/microsoft/DeepSpeed/pull/1419.

yes, all ranks call save_checkpoint method, but seems only rank=0 save model params. which mentioned in
# deepspeed/runtime/engine.py
        # All procs then call module_state_dict(), but only procs of data
        # parallel rank 0 save the general model params.

and also the inner code has a rank=0 judgement.

@tjruwase
yes, all ranks call save_checkpoint method, but seems only rank=0 save model params. which mentioned in

This is true for the DeepSpeedEngine, PipelineEngine uses all ranks to save model params, as in the PR. Does that help clarify things?

@tjruwase yes. The code is the truth.


Fix the ignored test cases brings by

The issue #290 and PR #296 is related with continuous offset for kop. In the PR, the test cases are ignored. We need to fix and turn them on.

@aloyszhang FYI.

@aloyszhang FYI.


Sign Satellite Assemblies and add them to the VSIX from the Final out…

…put path rather than the intermediate path
Previously, the VSIX project was using the target SatelliteDllsProjectOutputGroup to include the satellite assemblies to the VSIX. But the assemblies in the intermediate path are not signed and hence the VSIX gets constructed with unsigned assemblies.
With this change we pick the assemblies from the final output path where the satellites assemblies are signed.
Customer scenario
All the satellite assemblies wont be signed
Bugs this fixes:
VSO link
Workarounds, if any
There are no workarounds
Risk
Low risk. This only affects the resources dll
Performance impact
None
Is this a regression from a previous update?
The resources dlls are new for the project system.
How was the bug found?
VS Sign Verification process
@srivatsn @nguerrera @dotnet/project-system for review

@basoundr please review the Ask mode tab in VSO for correctness

@natidea I have reviewed it and it looks good. I updated the Validation section as well

Tagging @MattGertz for RC3.

Shiproom Approved to Merge


Review home screen of the installer

I'm creating this issue to track the activity to be done to the home screen of the installer. The design is being finalized and will be linked to this issue, but the main idea is to have:

Main options (Create / Add / Load) immediately visible at the landing page
Network selection as a (secondary) option of this landing page. Bitcoin Network (mainnet) by default. TBD which network to load by default, if the last network I used with at least a wallet in it or always mainnet (I would go with the latter at least at first)
Share Xpub option still present
List of possible existing wallets to load for the specific network given the following limitations:

Still maximum one wallet for the ones that use their "own" BE (local bitcoind, local liana managed bitcoind, electrum)
Limit to be defined but more than one is possible for the ones with Liana Connect as BE

The different wallets will be distinguished by some labels (e.g. "Liana Connect" vs "Bitcoin Core" vs "Electrum" or something like this) and will have more info if required (e.g. email address for "Liana Connect" wallets)

Below an example of the current draft design:

Part of this work was already done in v7 in #1245.
For the remaining part (basically showing the different wallets available on the home screen while also allowing to create / add a new one), contrary to what we were saying, I think we necessarily need to either implement multiple wallet support also for local wallets or modify the installer flow. The reason is that if a user already has a wallet with his own node, if we allow him to go through the creation/addition of a new wallet, as per the current flow he could still select the "own node" option and override the existing wallet. The options that come to my mind are:

Implementing multiple support for "local" wallets and then proceeding with this change
Checking if a "local" wallet is already present when the user creates a new wallet and selects the "own node" option:

If no "local" wallet is present on the specific network -> go on normally
If a "local" wallet is present -> show a strong warning that says that the previous wallet is going to be overwritten

The first option is obviously preferable for the long-term view of having multiple wallets anyway, but the technical effort required is still unclear. The second would be a short term, faster solution to allow the user see all the wallets he has considering both local and Liana Connect.


[4.0] SILGen: The foreign-to-native thunk for an @objc protocol member should use a native convention.

Explanation: Referencing an ObjC protocol member as a function value would cause a miscompile due to mishandling of the thunk mapping the method to the Swift function value convention.
Scope: Anyone trying to use ObjC protocol members as function values would experience compiler crashes.
Issue: rdar://problem/31922123
Risk: Low.
Testing: Swift CI, test cases from Radar

@swift-ci Please test

@slavapestov This look OK for the 4.0 branch?

@swift-ci Please test

@swift-ci Please test

LGTM!

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - e5cd262c15f3985336cb68901c5a8781c7ac4e6e
Test requested by - @jckarter

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - e5cd262c15f3985336cb68901c5a8781c7ac4e6e
Test requested by - @jckarter


[D&D_Moldvay] Font Inconsistency

On my end in the browser (testing with Firefox and Chrome) the sheet uses a font that looks like comic sans (https://i.imgur.com/8m9WiiI.png), however on mobile it appears as a different font (https://i.imgur.com/t3U6kWi.png), not sure what that cause of that might be. Ideally the browser version would use a font better than comic sans.

The reason that fonts don't show correctly is because of [Bug] imgsrv.roll20.net proxy delivering content insecurely #265 .
Within chrome, you can allow the fonts to be used - I'm not sure if it will keep those settings or not.

This issue has been resolved as of the most recent update.


Docker support?

Hi guys,
I'm kind of new to use delve for debugging, so excuse em if I'm asking smth that doesn't make sense.
So I have a container that has a go application running... Is there a way to run the debugger in the container and see it in the editor?
Thank you so much for the help.

I did some experiments and got go-debug to talk to delve running in a container. Here is what is needed to do:

Run container with --privileged. Default docker filters trace syscalls used by delve
Run container with -v "$GOPATH:$GOPATH" to have same paths on host and container, otherwise go-debug seems to get confused
Run container with -p 2345:2345 so that go-debug can talk to delve
Create a wrapper dlv script on the host that is in $PATH (move away original binary is needed). It forwards $GOPATH and starts delve listening on any interface so that the port forward works

#!/bin/sh
exec docker exec -i <CONTAINER-ID-HERE> sh -c "cd $PWD && GOPATH=$GOPATH dlv debug --headless=true --listen=:2345 --log"

Run container (in my case golang:1.7-onbuild) with some dummy command to make it stay alive, use some shell, sleep etc and make sure delve is installed (go get github.com/derekparker/delve/cmd/dlv). Now start debugging in atom.
I noticed that delve does not exit when stop debugging in atom. But i guess the hard question is how to make something like this easy to use. Maybe support for custom dlv path is enough?

Thanks for experimenting @wader! This is a nice workaround for now!
I'm currently in the middle of a rewrite and this contains configurations that also support things like connecting to a remotely running dlv (similar to what the go plugin of vscode already supports).

It is possible to define configurations with the latest version (v1.0.0).
These configurations also include a mode to connect to a headless delve running somewhere else. Also add host and port to specify the (delve) endpoint.


'host' field format is ip_address:port (instead of hostname ?)

Hi,
_Edited, see comment at bottom._
Using Logstash 1.5.4 with Log4j input plugin 1.0.0, generated log entries host field is e.g. "host": "10.XXX.XXX.XXX:62364" instead of "host": "myhostname".
This isn't consistent with Logstash default, and I believe it should be fixed to hostname, at least through some configuration.
Related:

StackOverflow: "log4j tcp appender and logstash source host"
Logstash's (discontinued?) JIRA: "log4j input uses host:port value as host field"

Thanks in advance!
Edit: nevermind, if Log4j input works as a server socket, there is no easy way to consolidate multiple remote IPs with hostnames.
For local Log4j log analysis, what is your best performance / configuration compromise? Use file input with log file or keep log4j server socket bound to localhost only and use some filter to override host field?

This plugin is deprecated for security reasons. More details, including a recommended alternative, available here: https://www.elastic.co/guide/en/logstash/current/plugins-inputs-log4j.html#_deprecation_notice


Login/sign up page ui improvements and code formatting

I will improve the login/sign-up pages with CSS improvements
i will also increase the code formatting by deleting extra comments and spaces and by adding new spaces and comments where needed.
Your project is awe-inspiring.
Although i can work on your project as a whole,  for now, I will work on the login/sign-up page and code formatting only.
you can also tell me where you want improvements, I'm open to it

I will improve the design consistency which will make it look more good.
I will add hover effects , improve input boxes , overall layout , add margins , padding etc whatever needed

alright ! I'm assigning you!

Thanks!
I'll start the work tomorrow
And please add hacktoberfest label also!


go1.11beta3 test fails when using a different module for testing

What version of Go are you using (go version)?
go version go1.11beta3 darwin/amd64
Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/sbark/Library/Caches/go-build"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/sbark/go"
GORACE=""
GOROOT="/usr/local/Cellar/go/1.10.3/libexec"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.10.3/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/g3/75bj1c295mj9qykv045hzxqnwcwnf4/T/go-build557749133=/tmp/go-build -gno-record-gcc-switches -fno-common"
What did you do?
Create following files in a directory:

go.mod

module example.com/gomod

modlib.go

package gomod

func Useful() string {
	return "useful"
}

modlib_test.go

package gomod_test

import (
	"testing"

	"example.com/gomod"
)

func TestUseful(t *testing.T) {
	want := "useful"
	if got := gomod.Useful(); got != want {
		t.Errorf("Useful() = %v, want %v", got, want)
	}
}

Execute tests using go test -v

What did you expect to see?
$ go1.11beta2 test -v
=== RUN   TestUseful
--- PASS: TestUseful (0.00s)
PASS
ok  	example.com/gomod	0.005s

What did you see instead?
$ go1.11beta3 test -v
build example.com/gomod_test: cannot find module for path example.com/gomod_test

Similar setup to the issues reported in #26722 and #26279, so closing as a likely duplicate of those.
Please let us know if this isn't fixed at head.


Data sync issue

I've following network setup

1. If i update model A & E at same time than only changes of model A are propagated in network
check following image

2. If u update model E after few seconds than the changes are propagated in network; check following image.

is this normal behaviour or a bug?

yes this is correct behaviour

oh sorry, you are connecting these streams wrong!
you cannot pipe as to bs AND pipe cs to bs. you should use each stream only once!
bs should actually be bs1 bs2 bs3
as = a.createStream()
bs1 = b.createStream()
bs2 = b.createStream()
cs = c.createStream()
as.pipe(bs1).pipe(as)
cs.pipe(bs2).pipe(cs)
//etc...

@dominictarr, Ahh ok.
thank you for the answer and a awesome module.


Uncontrolled select wrong value

Bug report
Current Behavior
When you set defaultValue in Select component, hidden html select has first option as value instead of defaultValue. So, when you submit uncontrolled form with defaultValue form sends first option of the select as value.
This happens too when you select currently selected option, It sets first option as value.
Expected behavior
Hidden html select should have defaultValue as value if you do not change the selected option, and if you select the currently selected option, it should not change value.
Reproducible example
CodeSandbox Template

Hey @frgarciames, I can confirm the issue on my side.


Token acquisition API should respond which Account authenticated

Problem
When you try to get an access token with Open ID Connect (e.g. Google) authentication API, the request parameter does not contain Account name.
Therefore, a client application cannot take information which Account authenticated.

Solution
X-Personium-Authenticated-Account response header would be added to Token acquisition API.

case:
grant_type = password => The same value of request parameter "username=XXX"
grant_type = oidc:google =>Gmail address in decoded ID token value.

The aim of this issue will be achieved through the following issue fix;
https://github.com/personium/personium-core/issues/281
So I am closing this issue.


JSO error when

I applied the fadeIn;{duration:1000,easing:ease-out} attribute from your example but received a JSOL parsing error. Other than that, it appears to be working for me on Chrome - haven't tested it on anything else yet.
I'll update this with the actual error when I get the chance - code is broken right now.

Apologies - got back to this and couldn't replicate - closing issue


Symetric tables

For the heatmap outputs: solve this problem of symetry

For the heatmap outputs: vertical axis for Y


Fix/2323 tab styling button groups

Description

Checklist

[x] For UI or styling changes, I have added a screenshot or gif showing before & after
[x] I have added a changeset
[x] I have added to the docs where applicable
I have added to the VS Code extension where applicable

@archiewood Should <ButtonGroup {display="tabs"> have a inherit default value, similar to the tabs component?
Tabs Component (default value):

ButtonGroup styled as Tabs (No Default Value):

fix #2323

@archiewood I think this is something we can do in the future, I'll add a issue for this to be resolved in another PR.

Default Value Issue:
https://github.com/evidence-dev/evidence/discussions/2468

This appears to have broken tabs across evidence
See docs.evidence.dev


Navbar

The navbar can be turned on by the user with administrator privileges.

https://github.com/trngl8/symfony-skeleton-demo/commit/52b480aed43b34c33ef8f0ce6b28e31a9e1020da


QV experiment

Summary
QV experiment class and QV analysis class
Details and comments
to do:

need to add tests

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Does this plot can also be useful for the QV experiment?
https://github.com/Qiskit/qiskit-ignis/pull/489

Remember to put capital letters at the beginning of sentences, in comments and in the tutorial

One thing I immediately noticed is that the QV-analysis flags success for trials <100. Per original QV definition in the paper, the number of trials has to be at least 100. This prob should be hardcoded.

@PetarJurcevic thank you for noticing this error!
there was a mistake with the sigma calculation - instead of calculating:
(mean_hop * ((1.0 - mean_hop) / trials)) ** 0.5, we were calculating:
mean_hop * ((1.0 - mean_hop) / trials) ** 0.5 (the mean_hop was not inside the sqrt)
in the example in the tutorial, it made a difference of about 0.014 in the treshold - which made the test just pass.
the error was fixed and the example was updated

@dekelmeirom - I'm trying to run the notebook from your PR and get a failure.
it's due to the following line in the code:
analysis_results, figures = self._run_analysis(experiment_data, **analysis_options)
it assumes that analysis_results should get a list of objects, but you provide it only a single object

If the code is good, perhaps we can merge and open a seperate PR for the tests? (like in RB)

In my opinion every merged code must have at least some basic tests


Not disconnecting device in UART

First time it shows all BLE devices. when I connected with one device and sending data works perfectly. But when I will disconnect and try to reconnect it didn't show in scanning peripheral list even other devices not able to find that ble device.

How about killing the nRF Toolbox app? Or restarting the phone/Bluetooth?
Seems like the device is still connected after you click disconnect, for some reason.

Yeah after restarting bluetooth it works fine. But after reconnect issue remains the same.

Looks like the app, or some other app, is still using this connection after uart disconnected. Calling cancelConnection() method disconnects only the virtual connection, but if some other is still open, the iOS will keep the physical Bluetooth link open. To be sure that the device disconnects you should implement disconnect feature on your peripheral side, e.g. after sending some op code.

I have disconnected it but still its not working

I think Apple not disconnected main Ble connection and stores in Cache. Don't know its Apple bug or something else

I'm closing the issue as it was related to older version of the app.


Support for SQL generation

Hi there! I'm really interested in using this tool, however as a user of SQLc, I require the schema to be available as SQL. Is there any plan to support outputting the DDL as SQL?

Thanks for opening the issue 👋
Do you mean that pgroll should be able to export the database schema as SQL CREATE TABLE statements so that SQLc can generate code for them?
If so, that's a little outside of our intended direction for pgroll right now, but we'll keep the issue open as it would be a useful option to have.

https://github.com/xataio/pgroll/issues/269#issuecomment-2081295279


Properly wait for namespace creation to stabilize in tests

Currently in our integration tests, we are just doing a delay to give the controller enough time to create the token for the default service account. However, we should do this more smartly. Ideally, we should do a watch (on exactly what will be part of this issue, probably something like the status of the ServiceAccount or the tokens in the namespace) to wait for the token to be created

@thomastaylor312 I would love to help out with this albeit with some hand holding since I have just started with Rust over the past few weeks. Please let me know if this is something that might be suited for a beginner to take on (I have experience writing controllers for Kubernetes in Go, so am aware of how the kube client is supposed to work)

Yeah, if you have that deep of background in Kubernetes, this task should be just fine for a beginner. Given that k8s 1.21+ uses the projected volume to inject tokens, this is now less of a problem, but will still effect 1.20.
Please let me know if you have any issues, as running the e2e tests can be difficult at times


code

excuse me,when will you show your code,sorry to disturb you

Hi, thanks for your attention. These days I have been clearing up the code and preparing the camera-ready version. The code of VC R-CNN will be updated in a few days :)

Hi, Our code is published. Just have a try and welcome discussion~


Add page to preferences for general settings

This PR adds a page for general settings to the preferences window.
This PR is not responsible for adding the actual functionality. Those will be added with different PRs.
What is missing:

[x] localizaion
[ ] update localization on language change (comboboxes)
[x] functionality of all settings

[x] add zoom to point (PR #220)
[x] light gray grid lines (issue #211 | PR #)
[x] add option to hide influence on selction (issue #205 | this PR)

UpdateBorderLineColorVisibility and UpdateGridLineColorVisibility seem to use the same pattern of logic - is there a way to simplify the logic into a single method?

I  created separate methods, because there could be the case where the entries of the comboboxes are different.
So one has only 2 entries and the other has all entries or so.


Flutter UI Components plugin or module

it hard to me for switching from native and react native to flutter without native code support .
example i have applicate need to use it with jwplayer ,but it support only native code.

You can make native features available to Flutter by developing a plugin https://flutter.io/developing-packages/#plugin

i see it ,but i don't know how implement UI native code with flutter .
can you give example ?
On Sun, Aug 26, 2018 at 11:35 PM Günter Zöchbauer<EMAIL_ADDRESS>wrote:

You can make native features available to Flutter by developing a plugin
https://flutter.io/developing-packages/#plugin
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/18529#issuecomment-416051461,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AXLz57SH5cJvw-MWxrNVI_1_0x9S3btXks5uUs5pgaJpZM4UqfMo
.

https://github.com/flutter/flutter/tree/master/examples/flutter_view

Seems this is work in progress
https://github.com/flutter/flutter/issues/73#issuecomment-405667657
This one should be similar to what you need
https://github.com/flutter/plugins/blob/master/packages/video_player/lib/video_player.dart

See also https://github.com/flutter/flutter/issues/19030#issuecomment-416393456

Did the links help?

thank you for that  . but still looking for example source code

yes , but still looking for example.

look like i found it https://github.com/flutter/flutter/tree/master/examples/flutter_view
but i am not sure it is or not. thank you very much

@seakleng2016 great!
If this is what you were looking for, can this issue be closed then?


core: Windows support via psexec, Powershell Remoting and similar

Probably depends on #10

Definitely looks like #10 is needed.
It looks like, just as in Ansible, the only officially sanctioned and supported method for this is using WinRM, however stdio over WinRM involving HTTP polling SOAP calls(!), so the ultimate design for this will probably involve:

Some secure design for #10, which might entail requiring pyOpenSSL or similar to be installed on the target Windows machine alongside the Python interpreter
Some method, like somewhat like fakessh, to bootstrap the context without having direct stdio connectivity to it, except this time, the bootstrap cannot simply inherit some fds, it must make a real network connection back towards the parent machine.

If it's helpful context, I've been able to use ansible 2.8.0 and later to provision Windows Server 2016 hosts via win32-openssh <IP_ADDRESS>.
Having bled all over WinRM, off and on, for the last few years, I was delighted. It's comparable in terms of speed with WinRM. If you'd like details of how, https://github.com/ansible/ansible/issues/57815 has them.

Oh, while I'm here - in terms of improving ansible performance, a colleague was about to achieve a 10x speed increase for some up front JIT compilation - on the nodes we used, around 30-60s worth for just the powershell parts, or 200-300s for everything possible to do. This is the difference between Windows pegging the CPU for ten minutes on boot vs 2 minutes, which is interesting but irrelevant to ansible I think.
Full details of why this is a thing can be found at https://docs.microsoft.com/en-us/dotnet/framework/tools/ngen-exe-native-image-generator#native-image-service, and if you'd like to see the on-boot script that achieves it, we're hoping GCP will accept it upstream https://github.com/GoogleCloudPlatform/compute-image-windows/pull/174.
Since on Windows, ansible is done with a combination of powershell and inline C# compilation, this affects every ansible task, lowering the overhead (for us) from around 6s per task to small hundreds of milliseconds.

Sorry, just found this buried in my inbox :)  There have been movements in Ansible around persistent Windows, see e.g. https://github.com/ansible/ansible/issues/47707 . At some point trondhindenes posted a POC on Twitter, but I have no idea where to find that any more.
Regarding Windows support, it is still desirable, but for Ansible I'm not sure there is much point since everything is Powershell on Windows. My interest remains focused on iterating fundamentals to ensure the UNIX story is perfect, both for Mitogen and the Ansible extension -- and there is a huge amount work left to get there. For example even with Mitogen's improvements the file distribution story in Ansible is still a joke, there is no reason why a controller's network interface should melt while uploading 500mb images to machines over a WAN, when they all share a top of rack switch, etc. Would love to work on unique features like this, but features must be balanced against bug/maintenance load, and guess which one is winning recently ;)


Python crash in 1.4.4 when use also pywin32

I've tried on clean machine. Install pip install pywin32==224 and pip install pyglet==1.4.4
Then start python in PowerShell and run:
import win32ui
from pyglet.gl import gl_info

print "OpenGL Version:",gl_info.get_version()

Then press CTRL+C to exit Python ... Python crash.

Please make sure you have Windows Error Reporting ON. You can enable it via registry editor, as described here.
More details in another run:
Error in atexit._run_exitfuncs:
Traceback (most recent call last):
  File "C:\Python27\lib\atexit.py", line 24, in _run_exitfuncs
    func(*targs, **kargs)
  File "C:\Python27\lib\logging\__init__.py", line 1684, in shutdown
    h.release()
  File "C:\Python27\lib\logging\__init__.py", line 722, in release
    self.lock.release()
  File "C:\Python27\lib\threading.py", line 204, in release
    raise RuntimeError("cannot release un-acquired lock")
RuntimeError: cannot release un-acquired lock

Hello, I have replicated this, but I cannot find any pyglet specific errors.
It also seems to only affect Python 2.7.  Is it possible to switch to Python 3 for your project?

many pyglet function can't work in thread...but work in main thread...... ...

@benmoran56 thank you for looking into it. We will probably switch to Python 3 in few months.
Looks like pywin32 has similar issue with other modules, not only with pyglet.

No problem! Sorry I couldn't really help, but upgrading to Python 3 is a good idea in any case. I'll close this for now, but please feel free to reopen it if you want to add anything.
One last thing - in case you haven't tried it,  how about the pywin32-ctypes module?  It does not contain all of the functionality of pywin32, but in my experience it works well.  Maybe there is a chance it does not trigger the same issue.


fix: fix Convertbot build using venv

:tada: This PR is included in version 3.26.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


feat: react 17 support

The React developers have released v17 since October 2020. With these changes, we would be able to support the latest React version.
Resolves #398
Description

Widened the supported range of react & react-dom peerDependencies.
Bumped devDependencies to support React v17.
Tweaked Enzyme jest tests to support React v17.

Screenshots (if appropriate):

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have used ESLint & Prettier to follow the code style of this project.
[ ] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Any chance this could be merged? We are currently waiting on it. Thanks @andrewsantarin for doing the PR!

Well done on this @andrewsantarin. Any luck with the merge @patw0929 ? Cheers

@patw0929