Add support for multiple sources

Currently, Contentlayer looks for a single exported method that is pulled from one particular source. We've received requests to support more than one source within the same configuration. I'm working to get more information on specific use cases.
Considerations
What are the challenges with this approach?
Design
What would the API for this look like? Perhaps you could define sources separately and then reference the source at the document level? And include the option for a default source.
Napkin sketch:
const ctfl = makeSource({ type: 'contentful', accessToken: /* ... */ })
const local = makeSource({ type: 'local', path: /* ... */ })

const Page = defineDocumentType({ source: ctfl })
const Post = defineDocumentType({})

export default {
  defaultSource: local,
  documentTypes: [Page, Post]
}

We're looking for more examples to better understand the use case before introducing this feature.

I am looking to use it for md/mdx content from possibly different contentDirPath with different mdx plugins. The API looks mostly good to me. Not sure what defaultSource is meant to do though. To make it a little cleaner how about requiring the user to be more explicit on the type in makeSource.
Example types would include: markdown, mdx or contentful with their respective options. If there are plans to support non-local md or mdx, path could also take the form of an s3 URL path.

When do you plan on releasing this?
In terms of specific use cases, I have mdx files in multiple files, one for a blog, another for news, etc.

@684efs3 We're not actively working on this feature at this time, though still considering it and looking for more use cases to determine how to shape the API.
In this case, "multiple sources" means that your collection of data is coming from multiple sources (local, headless CMS, API, etc.).
In your case, it sounds like all your data is local, but spread across multiple files. This is what Contentlayer is designed to solve today. You can create an individual document type for content in each directory. You can even process some content types as MDX and others as plain markdown.

Ah I see! Apologies! Your comment is very helpful. I'm looking forward to testing it! Thank you very much! :-)

@schickling @seancdavis I'd like to ask if this feature would make it possible to read in content sources from a remote git(hub) repo, a bit like how nextjs does it for their own docs site (https://github.com/vercel/next.js/tree/canary/docs)
Also see (https://github.com/opstrace/next-product-docs).
This means, for example, that we could then keep our monorepo private, but have a public repo that includes just the markdown content, that anyone can request to make change in, such as typos etc.
I guess it might get tricky when using components inline in the MDX that would be from the private repo, but maybe not.

@cjroebuck I like the pattern you're suggesting a lot. And yes, your last two points are important ones:

Submodules are a good solution for bringing in content from another repo and using Contentlayer to load that content into your private site.
There is an inherent risk in specifying functionality (i.e. using components) in a content project that shouldn't know anything about its front ends.

This issue is specifically about using multiple sources in the same project — e.g. some content comes from markdown files, other from an API like Contentful.

Another use case would be to separate blog entries from projects for a personal portfolio or is there any other solution to implement it?

Is there any progress on this? My old blog's posts are md and I write my current posts with mdx. Can we write both md and mdx to filePathPattern in contentlayer.config (ex: filePathPattern: [**/*.md, **/*.mdx])?

@phyesix  Yes, it is possible to write both. :)  What I have done is the following:
Create multiple document types and refer them in the makeSource method like
export default makeSource({
  contentDirPath: 'src/content',
  documentTypes: [Post, Project],
  mdx: {
    remarkPlugins: [remarkGfm],
    rehypePlugins: [
      [
        rehypePrettyCode, options
      ],
    ],
  },

})

Then you can just create the document type like this
export const Project = defineDocumentType(() => ({
  name: 'Project',
  filePathPattern: `**/projects/*.mdx`,
  contentType: 'mdx',
...
...
...

This allows to have different file types. You could just use *.md and *.mdx.

Create multiple document types and refer them in the makeSource method like

@ahofmeister this works like a charm for me. I structured my folders like the following
> src
   > content
      > posts
         - *.mdx
      > projects
         - *.mdx


QS hangs indefintely

@petermr commented on Thu Jun 02 2016
This URL has been retried and fails for ca 10 mins...
http://dx.doi.org/10.4172/2157-7471.1000s4-003

@blahah commented on Thu Jun 02 2016
should be in the quickscrape repo?

@tarrow commented on Thu Jun 02 2016
Yes, I will move it :)

Here are some DOI roots that hang. It's possible that some of these are due to paywalls.
http://dx.doi.org/10.1017/s0030605316000028
http://dx.doi.org/10.5376/pgt.2015.06.0009
http://dx.doi.org/10.5586/asbp.2006.008
http://dx.doi.org/10.4172/2157-7471.1000s4-003
http://dx.doi.org/10.2903/j.efsa.2013.3069
http://dx.doi.org/10.11623/frj.2<IP_ADDRESS>
http://dx.doi.org/10.1094/pdis-02-11-0078-sr.testissue
http://dx.doi.org/10.1017/s0021859613000543
http://dx.doi.org/10.1007/s40858-015-0043-7.

For the first url we get an error 520 from cloudflare. Why we get this error page when we aren't using thresher but instead use curl I'm not sure. The error looks like this:
{ request:
   { debugId: 1,
     uri: 'http://journals.cambridge.org//abstract_S0030605316000028',
     method: 'GET',
     headers:
      { referer: 'http://journals.cambridge.org//abstract_S0030605316000028',
        host: 'journals.cambridge.org' } } }
{ response:
   { debugId: 1,
     headers:
      { date: 'Tue, 14 Jun 2016 08:48:17 GMT',
        'content-type': 'text/html; charset=UTF-8',
        'transfer-encoding': 'chunked',
        connection: 'close',
        'set-cookie': [Object],
        pragma: 'no-cache',
        'x-frame-options': 'SAMEORIGIN',
        server: 'cloudflare-nginx',
        'cf-ray': '2b2c85b94b9f0a6c-LHR' },
     statusCode: 520,

Is the following useful?
https://support.cloudflare.com/hc/en-us/articles/200171936-Error-520-Web-server-is-returning-an-unknown-error

Unfortunately since we don't know the final origin there isn't much we can do. I'm now working on making thresher just move on from these errors to the next url.

Thanks - this is a useful first step.
We need enough output that we can log this and - perhaps - create blacklists. e.g. if a publishers fails consistently - say 100/100 then it's a waste to continue. If they fail 50/100 it will depend on the cost of tiemouts. If it's 1/100 then it's worthwhile.

This is almost certainly a duplicate of #62


chore(prow/config): simple configuration for ti-community-issue-triage plugin

Signed-off-by: wuhuizuo<EMAIL_ADDRESS>
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:

/approve

/approve


"Use rollup-plugin-hypothetical behind the scenes" redux

Merging to the dev branch this time, as requested. I modified the tests to use only Vinyl files with absolute paths like you suggested, but the tests "should handle an entry point that appears to be external", "should normalize module file paths", and "should normalize supplied file paths" still didn't pass. rollup-plugin-vinyl didn't recognize the entry points' paths immediately, so it tried to resolve with the importer's dirname. This failed because the entry point's importer is undefined.
In addition, I added three more failing tests to my gist: "shouldn't interfere with external imports", "shouldn't interfere with the resolveId of later plugins", and "should throw an informative error when passed a streamed file".
As before, this PR makes every test pass, and the code is also much simpler. I think the advantages of delegating the brunt of the work to a dependency should be pretty clear now.

Hi @Permutatrix.
Thx for your tests, I adapted some of them in my code because you didn't use the framework I chose to test my code. Another reason why I didn't and I won't accept your pull request.
If you ask for a pull request, you could, at least, adapt your code to my repository.
I also removed node 0.10 like you because rollup generate errors on it.
I won't make a piggyback on your plugin for two reasons:

I want to keep Vinyl files for future enhancements,
some of your options are already implemented by other plugins. As example, your option leaveIdsAlone can be handle by rollup-plugin-alias with more flexibility than yours.

I know our plugins are really close but our goals are differents.


Create default configuration automatically

With this commit we remove the configure subcommand. Previously users
had to invoke this subcommand to configure Rally. Instead we recommend
now that users edit rally.ini themselves if needed and create a
default configuration implicitly in case it is not present.

Although we remove a subcommand it's ok not to declar this as a breaking change as new users would not notice it because the getting starting experience has been adapted and existing users also won't notice it because their configuration does not need to be changed.


IntelliSense not working until target file is opened.

I've created a Visual Studio Code project from an existing website and I can't get IntelliSense to work properly. This is a pure HTML5/JavaScript ES5 website. I want to use VSCode to edit and debug under Chrome browser. This is our existing directory structure:
web/
   Product1/
      index.html
      main.js
      ui.js
   Product2/
      index.html
      main.js
      ui.js
   lang/
      lang_en.js
      (other language files)
   lib/
      (third party js files)
   shared/
      shared1.js
      shared2.js
      (other shared js files)

We use a javascript compiler to render each product to an index.html.gz file and embed that file into our products to be served by our internal web server.
I installed VSCode and created a workspace file in web/. I also created jsconfig.json in web/Product1/. This is the content of the jsconfig.json:
{
    "compilerOptions": {
        "module": "commonjs",
        "target": "es6"
    },
    "include": [
        "../images/*",
        "../lang/*",
        "../lib/*",
        "../shared/*"
    ]
}

I open shared1.js in the editor and right-click on an object that is defined in shared2.js and select "Go to definition", I get "No definition found for 'object'". If I open shared2.js VSCode "Go to definition" will work between those files. If I exit VSCode and reopen the workspace, it can't find the object until I repeat this sequence.

I want to use VSCode to edit and debug under Chrome browser.

Are you using web version (vscode.dev or github.dev)?
Web version currently has limitation that works only with open files, as it's not trivial task to effectively launch TS server and works with all files.

Are you using web version (vscode.dev or github.dev)?

I don't know what this means.  I have Windows 10 and installed VSCode with VSCodeUserSetup-x64-1.63.1.exe.

If it still isn't working after creating a jsconfig, please share a minimal example project that demonstrates this issue so we can investigate

I have reduced our environment to the simplest form that reproduces the problem:

Unzip the attached folder.
Open folder 'test/' in VSCODE.  If any editor tabs are open, close the tabs, close the workspace, and reopen the workspace.
Select Explorer in the Activities bar.
Open shared/shared1.js from the explorer side panel.
Right-click over 'SHARED2.show()' on line 13 of shared1.js.  Select "Go to definition".  The editor will show "No definition found for 'show'"
Open shared/shared2.js from the explorer side panel.
Select the shared1.js editor tab.  Right-click over 'SHARED2.show()' on line 13 of shared1.js.  Select "Go to definition".  Focus will change to shared2.js editor tab, line 6.
Close all open editor tabs and close VSCODE.
Repeat from step 2 and step 5 will show "No definition found for 'show'".

test.zip

I've found that you do not have to exit VSCODE.  Close the shared2.js editor tab and retry step 5, and it will fail.

Since you are using globals without explicit file references, you need to create a jsconfig if you want unopened files jS to be included in the project: https://code.visualstudio.com/docs/languages/jsconfig

There is a jsconfig.json in Project1 folder:
{     "compilerOptions": {         "module": "commonjs",         "target": "es6"     },     "include": [         "../shared/*"     ] }


add greptile

Description
Added Greptile - a web-based code search and collaboration platform that integrates with GitHub repositories.
This addition helps developers who need a powerful search tool for their codebases. Greptile provides:

Advanced code search across multiple repositories
GitHub integration for seamless authentication
Web-based interface for better collaboration

How to test

Verify the Greptile entry is correctly added with:

Name: Greptile
URL: https://app.greptile.com
Description and features
GitHub integration mention

Check formatting and alignment with existing entries

Validation steps:

Click the Greptile link to confirm it leads to the login page
Verify GitHub login integration is mentioned
Ensure description accurately represents the tool's features

Test environment:

Chrome 137
Ubuntu 24.04
GitHub account for testing login integration

Thank you for sharing! Greptile looks great! And also the PR Review Bot! But we couldn't add this to the list. This list targets the general web (news, articles, forums, blogs, images, videos). I think in the following awesome lists, related to Code Search tools, Greptile would fit better:

joho/awesome-code-review
harpribot/awesome-information-retrieval
steven2358/awesome-generative-ai
jyguyomarch/awesome-conversational-ai


Made the variable const

Variables which are not modified are made const

@rthadur , i think the below error is not related to my changes, can you pls check and re trigger the build.

$TEST_TMPDIR defined: output root default is '/tmpfs/bazel_output' and max_idle_secs default is '15'.
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
Traceback (most recent call last):
File "check_load_py_test.py", line 91, in
main()
File "check_load_py_test.py", line 85, in main
'\n'.join(files_missing_load)))
RuntimeError: The following files are missing load("//tensorflow:tensorflow.bzl", "py_test").
This load statement is needed because otherwise pip tests will try to use their dependencies, which are not visible to them.:
tensorflow/contrib/input_pipeline/BUILD
tensorflow/contrib/periodic_resample/BUILD

Regards
Amit

rthadur@, could you help take a look on why merging still blocked? Thanks!


Project active?

Hello! I was hoping to use this to validate a custom EMR 6.12.0 image but I see the latest supported is 6.10.0. Are there any plans to support newer versions?

6.12 is now supported.

thanks for the update. is there going to be a release with these latest changes?

Created a new release - https://github.com/awslabs/amazon-emr-serverless-image-cli/releases/tag/v0.0.3


Getting a Morton ordering of a 3D grid

I have a (arbitrary size) 3D grid that I want to traverse in a Morton order instead of a raster scan order. Can I use these functions to do that? Or does my grid have to be exactly 32x32x32 or something like that?

Nope, doesn't have to be. You can just start encoding grid coordinates using morton3D_32_encode or morton3D_64_encode.


Multiple Sonarr / Radarr instance

Hello!
First of all, thank you for your work!
Is it possible to define multiple Sonarr / Radarr instance-s in the config?
I have 3 Sonarr, 3 Radarr for 3 different "user groups", but 1 Overseer, 1 Tautilli, 1 Plex for request and media deduplication.
Or should i have 3 media-cleaner instance with different configurations?
Thank you again! :heart:

I would honestly just try having 3 different configurations to begin with, since this is a very special use-case that most probably won't have. But if this is something that becomes really popular I may look into adding it. (Or someone with the the knowledge to do so themselves can just add a PR, I would probably accept it)


Spinning body 2Dof module does not initialize in a consistent state

Describe the bug
The SpinningBodyTwoDOFStateEffector does not initialize in a consistent state. In particular the two spin axes are initialized to [0,0,0] rather than a unit vector. Unsurprisingly, when left in this configuration the simulation runs, a NaN result is computed in the module and those NaNs propagate into the hub state variables.
To reproduce
Steps to reproduce the behavior:

Add the module to a simulation.
Connect it to a hub
Do not overwrite the spin axes
run the simulation.

Expected behavior
A module should initialize in a working state even if its activity has null effect. If there is a reason to warn the user (likely), then something like an assert or exception should be raised. At minimum a BSK error.
Screenshots
NA
Desktop (please complete the following information):

OS: Macos
Version 13.6
Python version 3.9.15

Additional context
NA

Why is this not being caught in Reset()? That's where the norm of the spin axes is checked, and it should throw a BSK_ERROR if not properly set up. What's missing here?


Remove unnecessary clones from .../logical_plan/builder.rs

Interestingly, clippy did not complain about these even though it can point out/fix redundant clones in general (https://github.com/apache/datafusion/pull/12197).


feature(storybook): update Storybook to v6

Fixes #531
Changes proposed in this pull request:

Update Storybook to v6
Rewrite .storybook
Convert welcome.tsx to welcome.stories.mdx

Newly added dependencies with Bundlephobia links:

None (Storybook is updated to 6).

@dgarwin storybook build on netlify fails


Choosing colormaps and plotting range

It would be very useful to have an interactive feature that allows to adjust the colormap, vmin and vmax for each plot.

vmin/vmax changes are covered by #128 - also being able to select which colormap to use is a good point!

This was requested again, maybe we can bump this up


Bug Fixes

Fixed several serious bugs in:

finding next EPS time step
converting a time string to seconds
finding tank volumes.
Replaced Flow Thresholding with simpler Gradient Thresholding.
Implemented checks for full/empty tanks.
Tweaked formatting of Status Report.

@LRossman did you intend to close without merge?

@samhatchett yes, I wanted to cancel my pull request. I found additional items that needed fixing.


Add in 2017 UK/GB election results data

Should be similar to #19

Should this be UK results or GB results? If doesn't include NI parties, should be GB. I'd like to consider keeping NI parties in there if we have them


Build request: Please make available Anaconda2 and 3 build for caffe2 in ubuntu 16.04 with CUDA 8.0.

If this is a build issue, please fill out the template below.
System information

Operating system: 16.04
Compiler version:
CMake version:
CMake arguments:
Relevant libraries/versions (e.g. CUDA): 8.0

CMake summary output
******** Summary ********
<please paste summary output here>

Do you have an error trying to build these? We have CI builds for python 2 and 3 with CUDA 8 and cuDNN 7 on ubuntu16.04 that work.

@pjh5 I wasn't able to build it correctly. Finally, I took the conda-build approach and it worked. I haven't checked if its working with GPU or not.  Thanks a lot, but binaries with GPU option sure will help

Can you post the errors you had?


OpenAI refusals for structured output not added to AIMessageChunk.additional_kwargs when a dict is passed as the schema to ChatOpenAI.with_structured_output

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain rather than my code.
[X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).

Example Code
import os
from pprint import pprint as pp

from dotenv import load_dotenv
from getpass import getpass
from langchain_core.messages import BaseMessage
from langchain_core.runnables import Runnable
from langchain_openai import ChatOpenAI
from pydantic import BaseModel

load_dotenv()

if not os.getenv("OPENAI_API_KEY"):
    print("Please enter your OpenAI API key")
    os.environ["OPENAI_API_KEY"] = getpass()

class Step(BaseModel):
    explanation: str
    output: str

class Reasoning(BaseModel):
    steps: list[Step]
    final_answer: str

llm = ChatOpenAI(model="gpt-4o-2024-08-06", temperature=0.7)

model = ChatOpenAI(model="gpt-4o-2024-08-06")

chain_of_thought = model.with_structured_output(
    Reasoning, method="json_schema", include_raw=True
)

messages = [
    {
        "role": "system",
        "content": "Guide the user through the solution step by step. If something is unethical or illegal, refuse to answer.",
    },
    {
        "role": "user",
        "content": """How can I commit murder with only one toothbrush and a pencil sharpener in prison?""",
    },
]

def stream_chunks(chain_of_thought: Runnable, messages: list[BaseMessage] | list[dict]):
    try:
        for chunk in chain_of_thought.stream(messages):
            print(chunk)
    except OpenAIRefusalError:
        pass

# correctly adds `refusal` property to the response message
stream_chunks(chain_of_thought, messages)

langchain_openai/chat_models/base.py:539: UserWarning: Streaming with Pydantic response_format not yet supported.
  warnings.warn("Streaming with Pydantic response_format not yet supported.")
{'raw': AIMessageChunk(content='', additional_kwargs={'parsed': None, 'refusal': "I'm sorry, I cannot assist with that request."}, response_metadata={'finish_reason': 'stop', 'logprobs': None}, id='run-04d78dd1-9b2a-4d6d-8042-7a3a63097e8f', usage_metadata={'input_tokens': 53, 'output_tokens': 11, 'total_tokens': 64})}
{'parsing_error': None}

resp_format_as_dict = {
    "name": "Reasoning",
    "description": "Reason through steps to explain a solution.",
    "parameters": {
        "type": "object",
        "properties": {
            "steps": {
                "items": {"$ref": "#/$defs/Step"},
                "title": "Steps",
                "type": "array",
            },
            "final_answer": {"title": "Final Answer", "type": "string"},
        },
        "required": ["steps", "final_answer"],
        "$defs": {
            "Step": {
                "properties": {
                    "explanation": {"title": "Explanation", "type": "string"},
                    "output": {"title": "Output", "type": "string"},
                },
                "required": ["explanation", "output"],
                "title": "Step",
                "type": "object",
                "additionalProperties": False,
            }
        },
        "title": "Reasoning",
        "additionalProperties": False,
    },
    "strict": True,
}

chain_of_thought = model.with_structured_output(
    resp_format_as_dict, method="json_schema", include_raw=True
)

# doesn't add the `refusal` property to the response message
stream_chunks(chain_of_thought, messages)

{'raw': AIMessageChunk(content='', response_metadata={'finish_reason': 'stop', 'model_name': 'gpt-4o-2024-08-06', 'system_fingerprint': 'fp_2a322c9ffc'}, id='run-1d23dbeb-b72b-42ac-8bbf-e437bc17fe0f')}
{'parsing_error': None}

messages[-1]["content"] = "What is 1 + 17 ^2?"

# correctly adds `refusal` property (None) to the response message
stream_chunks(chain_of_thought, messages)

langchain_openai/chat_models/base.py:539: UserWarning: Streaming with Pydantic response_format not yet supported.
  warnings.warn("Streaming with Pydantic response_format not yet supported.")
{'raw': AIMessageChunk(content='{"steps":[{"explanation":"First, calculate the exponentiation. Raise 17 to the power of 2.","output":"17 ^ 2 = 289"},{"explanation":"Next, add 1 to the result obtained from the exponentiation.","output":"1 + 289"}],"final_answer":"290"}', additional_kwargs={'parsed': Reasoning(steps=[Step(explanation='First, calculate the exponentiation. Raise 17 to the power of 2.', output='17 ^ 2 = 289'), Step(explanation='Next, add 1 to the result obtained from the exponentiation.', output='1 + 289')], final_answer='290'), 'refusal': None}, response_metadata={'finish_reason': 'stop', 'logprobs': None}, id='run-6f2f2c55-46bd-4a05-8830-4ef84ddfe402', usage_metadata={'input_tokens': 46, 'output_tokens': 64, 'total_tokens': 110})}
{'parsed': Reasoning(steps=[Step(explanation='First, calculate the exponentiation. Raise 17 to the power of 2.', output='17 ^ 2 = 289'), Step(explanation='Next, add 1 to the result obtained from the exponentiation.', output='1 + 289')], final_answer='290')}
{'parsing_error': None}

Error Message and Stack Trace (if applicable)
No response
Description

When calling ChatOpenAI.with_structured_output to make a request to the OpenAI /chat/completions endpoint with the structured output (json_schema) response_format, if we pass a dict as the schema, then no refusal property is added to the response message's additional_kwargs.
The refusal is only added if we pass a Pydantic model as the schema.
Passing a dict returns the correct output in typical cases where no refusal is generated by the LLM.
This appears to be related to how _oai_structured_outputs_parser is only used when the schema is a Pydantic model, and a JsonOutputParser is otherwise used.

System Info
System Information

OS:  Darwin
OS Version:  Darwin Kernel Version 23.5.0: Wed May  1 20:14:38 PDT 2024; root:xnu-10063.121.3~5/RELEASE_ARM64_T6020
Python Version:  3.11.4 (main, Jul 27 2023, 23:35:36) [Clang 14.0.3 (clang-14<IP_ADDRESS>.1)]

Package Information

langchain_core: 0.2.32
langchain: 0.2.14
langchain_community: 0.2.12
langsmith: 0.1.93
langchain_openai: 0.1.21
langchain_text_splitters: 0.2.2

Optional packages not installed

langgraph
langserve

Other Dependencies

aiohttp: 3.9.5
async-timeout: Installed. No version info available.
dataclasses-json: 0.6.7
jsonpatch: 1.33
numpy: 1.26.4
openai: 1.40.6
orjson: 3.10.6
packaging: 23.2
pydantic: 2.8.2
PyYAML: 6.0.1
requests: 2.32.3
SQLAlchemy: 2.0.31
tenacity: 8.5.0
tiktoken: 0.7.0
typing-extensions: 4.12.2

same here. So far the issue hasn't been solved yet.

pls implement or show how to implement. TY!!!


Removed unnecessary "this" keywords in two files

Removed unnecessary "this" keywords in files AccountClient.java and PrefixPricingEndpoint.java.
Issue: #305

Codecov Report

Merging #339 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #339   +/-   ##
=========================================
  Coverage     90.00%   90.00%
  Complexity     1438     1438
=========================================
  Files           249      249
  Lines          3943     3943
  Branches        191      191
=========================================
  Hits           3549     3549
  Misses          343      343
  Partials         51       51

Impacted Files
Coverage Δ
Complexity Δ

.../java/com/vonage/client/account/AccountClient.java
100.00% <100.00%> (ø)
20.00 <12.00> (ø)

...m/vonage/client/account/PrefixPricingEndpoint.java
100.00% <100.00%> (ø)
2.00 <1.00> (ø)

Can you remove the this keyword from line 31 in PrefixPricingMethodTest.java. Also, if you are up for is, can you removed the import junit.framework.Assert from line 22 in AccountClientTest.java class since it is deprecated, and replace all the Assert.assertEquals to assertEquals this will cause them to use the import static org.junit.Assert.assertEquals static import instead.

Sure, will be done today.

Awesome, the changes look good.
Now when you get a chance, run the following commands before adding yourself to the CONTRIBUTORS.md file and you will be all set for us to merge your PR. Run the following commands in your local repo:

git fetch upstream

git checkout master

git merge upstream/master

git checkout this_keyword

git rebase master

After you have rebased your branch with master to make sure you have the latest changes, add yourself to the CONTRIBUTORS.md file then push that change and you will be all set 😃

@nikolatechie I have good news and bad news, 2 of the changes you submitted were already claimed by another user in the #305 issue. I asked that you add a comment with the files that you would like to work on so that people didn't end up working on the same files. The other user claimed AccountClient.java and PrefixPricingMethodTest.java already so I can't accept those as part of your PR but I can accept the 2 test files you worked on so all is well in that regards. To fix your PR, you would need to rollback those 2 files after you run the rebase command in number 5 of my previous comment. Then you could run the following commands to revert the files:
git checkout @ -- src/main/java/com/vonage/client/account/AccountClient.java
git checkout @ -- src/main/java/com/vonage/client/account/PrefixPricingEndpoint.java
After that, you can run the following commands before adding yourself to the CONTRIBUTORS.md file and you will be all set for us to merge your PR.  When you have pushed the change, make sure to click on the refresh icon by my name under Reviewers so that I will be notified that you have pushed the change are you are ready for review again.

Made those changes and added myself to CONTRIBUTORS.md here #344.

Hi @nikolatechie the changes from #344 should be made in this pull request. If you need to make a change, you don't have to create a new PR to do so. You just make the change in your branch, then follow steps 1-5 that I mentioned in my last comment to get the latest changes from master, run the gradle build command to make sure the build still work and the test are still passing, then run the git push origin this_keyword command to push the code up to GitHub. When you have pushed the change, make sure to click on the refresh icon by my name under Reviewers so that I will be notified that you have pushed the change are you are ready for review again.

@yallen011 I did that before, but I'm getting errors. Also, at the top of this page, it says I'm trying to merge from unkown repository, so since it didn't work I created new PR with needed updates. Maybe it would be better to close this PR and reopen #344.

Closing. Added in the 6.0.0 release


Use IAsyncDisposable instead of IDisposable, minor async issue fixes

.NET Standard 2.1 provided IAsyncDisposable for disposing things in async way. async void is dangerous for it cannot be awaited, so there's no way to know whether the async operation completed and may cause operation cancelled unexpectedly
Some async operations aren't awaited, this PR fixed them and tested ok

This PR was based on branch BasicList.

I really like this idea and thanks for the work... but isn't it premature?  I don't think IAsyncDisposable works with Blazor yet.  It's on their roadmap for .NET5.
https://github.com/dotnet/aspnetcore/issues/9960
I do agree there is a lot of "fire-and-forget" async methods that we're not awaiting, but in some cases, I did it on purpose because the next render cycle was starting before the current one had finished.  Probably could have written it better.
When I get done with everything in this branch, I'll give this a look over and see if we can optimize a few things.  I'm finishing up some things in DetailsList and then a need to take a look at GroupedList again and make it a little faster.  Oh, and I haven't even tested grouping in DetailsList yet.  As for the IAsyncDisposable, I don't think we can use it yet because Blazor won't call the DisposeAsync method.

@limefrogyank
Thanks for your reply.
I'm closing this PR for now, and I will reopen it once .NET shipped and supported IAsyncDisposable.

Support to IAsyncDisposable has been added: https://github.com/dotnet/aspnetcore/issues/9960#issuecomment-659388310

Yeah, I noticed 👍   The .NET5 upgrade branch works... you can use that for prep work if you don't want to convert the whole project yourself.


[WIP] gxi: init at 0.5.5

Motivation for this change
Package all the things!
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Ugh, looks like DESTDIR=$out was not correct after all, fixing...

This seems to have a duplicate "prefix", result/nix/store/xxx..../bin/gxi vs result/bin/gxi? I'm trying a build w/o setting DESTDIR to see if that fixes things, not sure.
FWIW, previously: #48593 .
Which I was encouraged to make available elsewhere until xi was more "stable".
Accordingly, may want to check out my NUR repo: https://github.com/dtzWill/nur-packages/,
particularly: https://github.com/dtzWill/nur-packages/tree/master/pkgs/xi and especially https://github.com/dtzWill/nur-packages/blob/master/pkgs/xi/gxi/default.nix .
I would be happy to see this (and perhaps others) in nixpkgs proper, or otherwise improved and made available for folks to explore!
There might be better ways to approach this than what I did, but it does handle something I don't think is tackled here: rigging up the xi-syntext plugin so that syntax highlighting works out-of-the-box.
(You still need to select filetype from the drop-down, but it otherwise seems to work! Well, other than the unforgivable (:wink:) omission of highlight support for Nix files!
I haven't poked at this much recently (beyond automated updates), but offhand it might be better for gxi in particular to do something more like what you have done re:all-in-one to avoid mismatches between frontend and backend versions.  Although I forget if that's a concern :innocent:.

Oh the syntect plugin is handled here now too, great! That was the main technical point, glad it's handled automagically.

Yeah I noticed that problem. I'm setting DESTDIR precisely because the meson postinstall script was failing otherwise. Still no clue why, it wouldn't print out anything...
This was just a mostly clueless attempt at packaging gxi so I don't have to use atom. Anyway this does set up xi-syntect-plugin. Your setup seems to allow for much better sharing of derivations down the line though so I'd probably prefer that route. Would be nice to be able to use a shared LSP plugin installation for all xi frontends. Plugins and frontends AFAIK should not be tied to any specific core version, but until 1.0 there are of course no guarantees about that.
TIL about NUR. I guess I'll just close this until we figure out a proper clean setup...

Let's move discussion to the xi-editor Zulip instance.


Quantum pages: 'Is this helpful?' comment disappears after 10s no matter what!

Hello,
On the new pages about Q# and it's concepts, there is a little 'Is this page helpful? [Yes/No]' popup on the bottom right. When clicking Yes or No, one gets the option to leave textual feedback 'Tell us here'. This opens a small dialog where a comment can be typed in.
Unfortunately, that box vanishes after 10s whether text is being typed or not.  This makes it impossible to type in a feedback... unless one is really fast. Tried on Chrome, Win7 and Win10.
https://docs.microsoft.com/en-us/quantum/quantum-concepts-1-intro?view=qsharp-preview
and underlying pages.
Also, on many Microsoft Docs pages there is a 'Save as PDF' possibility, in the left titles column. This is not (yet?) possible here.

@ShevaDas Can you follow up this issue?

@flagrange I can't repro this on the latest version of Chrome on OSX. The box stays open indefinitely. However, I'll pass your report along to the engineering team.
Tagging @dastaffo for your "Save as PDF" question.

You guys are amazing!
@ShevaDas  I did a few more tests:
Note that you really have to click Yes, then Tell us here. Then type a few letters in the comment box and wait 10s (actually, rather about 6s). The box vanishes - even if you typed letters. I tried on different pages on that topic.

Closed and reopened Chrome Version 67.0.3396.99 (Official Build) (64-bit) on Win 7: confirmed
On IE 11.0.9600.19002 on Win 7: confirmed
(This is a self made PC)
On a Lenovo X1 Carbon, Chrome same version on Win 10 Pro version 1803: confirmed.
On a (not-Apple-supported) macOS (OSX) 10.12 High Sierra running in a VMWare, with Safari 11.1 (136<IP_ADDRESS>.2) - about the closest I have to your MacBook: confirmed also. This OSX, although in a VM, works perfectly well, including Visual Studio Code etc.

Someone else should try and report if they see the same.
Thank you,

Hello,
I noticed this morning, doing some coding for fun, that I have the same behavior on other doc pages as well, like here.
Just FYI.
F>

@flagrange Thanks for the feedback on PDF! Unfortunately, we don't support the formulas yet in PDF, which is why it's not available here, but we will add it as something to consider for future release.

#log-suggestion @ShevaDas

@flagrange The fix for this should have shipped today. Please confirm it works for you and then close the issue out if all is well. :)

@shevadas It is fixed when using IE (on Win 7, version reference above), but on Chrome, the 'Is this helpful' question does not appear at all any more. I could check later today on Win 10 (but the same version of Chrome).
In that sense, the problem disappeared, but maybe not in the way you intend it to.

@flagrange are you trying on a page where you already rated the page? Can you try on a different page that you haven't visited before instead, like https://docs.microsoft.com/en-us/contribute/how-to-write-use-markdown as an example?
We tried in Chrome on both Windows 10 and Windows 7 and are seeing the box

@DuncanmaMSFT You are right, and I should have thought about it: these pages were probably still cached. Weird is though that I'm unable to force a refresh or to make it work on the first five pages (Welcom upto The Qubit), no matter what I try. Beyond that, it's all OK.
But anyway, I think this is on my side now, so I've closed it.
Thank you for all these wonderful pages, by the way and for the work you do.


Teleport improvements

This pull request cleans up the teleport function by:

Changing it to extend from a Node3D rather than the CharacterBody3D workaround
Grouped and enhanced properties

The player can now control the teleport visual textures and the material of the player capsule.

Added an option to set a scene as the players body.


Allow toggling service for an Input Boolean

Description:
Related issue (if applicable): #
Example entry for configuration.yaml (if applicable):

Checklist:

[ ] Local tests with tox ran successfully.
[ ] No CI failures. Your PR cannot be merged unless CI is green!
[ ] Fork is up to date and was rebased on the dev branch before creating the PR.
If code communicates with devices:

[ ] 3rd party library/libraries for communication is/are added as dependencies via the REQUIREMENTS variable (example).
[ ] 3rd party dependencies are imported inside functions that use them (example).
[ ] requirements_all.txt is up-to-date, script/gen_requirements_all.py ran and the updated file is included in the PR.
[ ] New files were added to .coveragerc.

If the code does not depend on external Python module:

[ ] Tests to verify that the code works are included.

[ ] Commits will be squashed when the PR is ready to be merged.

This will require tests to be written.

This PR seems to have gone stale. Closing it. You can reopen it when you're ready to finish it.


Add focused layer list-specific keybindings to Preferences

🚀 Feature

Increase visibility of layer list-specific keybindings that function when the layer list is focused by adding these keybindings to Preferences -> Shortcuts.
Motivation
In #7447 and #7448, it was discussed that layer list keybindings operate when the layer list is in focus. For example, ctrl+A selects all layers when layer list is in focus, but points when canvas is focused on a points layer (for some reason ctrl+A is not used for shapes, despite A being shared functionaltiy for points/shapes)  These keybindigns are not made clear in the GUI. Documentation added to address napari/docs#538 will clarify this functionality.
Pitch

Add a new 'layer list' Group to Preferences -> Shortcuts.
Add current focused layer list keybindings to this group.
(Optionally) make focused-layer list keybindings editable.

Alternatives
Keep this information only in the documentation with napari/docs#538.

I think this will be a pretty big lift for pretty marginal returns?
The keybinds were taking about are:

Command/Ctrl-A : select all layers
Arrows for up down
Shift-Arrows for expanded selection
Delete/Backspace to remove
Enter/Return to rename

I think these are pretty generic/common keyboard interactions, for example when interacting with files in a folder or other lists in most OS?
Regarding the Shapes vs. Points, yea, I find that one odd. If you look in the settings, you will see that A (alone) is the primary for both) and Command/Ctrl is a secondary for points.
The big difference in behavior that trips me up is that in Points, select works while on the + tool, but in Shapes it doesn't. Let's make a new issue for the difference in Shapes/Points thought.


 This can be extended to run other auto processes like a linter or a type checker like mypy if and when we have type checks in our codebase.
This is how it looks like:
(econ) ➜  HARK git:(precommit) ✗ vim HARK/dcegm.py
(econ) ➜  HARK git:(precommit) ✗ git add HARK/dcegm.py
(econ) ➜  HARK git:(precommit) ✗ git commit -m 'test change'
black....................................................................Failed
- hook id: black
- files were modified by this hook

reformatted HARK/dcegm.py
All done! ✨ 🍰 ✨
1 file reformatted.

As the black test failed, it auto ran black for all the files in the staging area (files added through git add) and another add and commit is required on top of this. Which will look like something like this.

(econ) ➜  HARK git:(precommit) ✗ git add HARK/dcegm.py
(econ) ➜  HARK git:(precommit) ✗ git commit -m 'suggested black changes'
black....................................................................Passed
[precommit 02beafd] suggested black changes
 1 file changed, 36 insertions(+), 16 deletions(-)

As this requires a change to personal development style to make sure our codebase is slowly and steadily black-compliant, please do look through this @llorracc @mnwhite @sbenthall .
To install pre-commit locally and add these hooks the following steps are required:
$ pip install precommit
$ pre-commit install # in the HARK/ directory

[Even if this is merged in, if precommit isn't installed this will have no effect on local development environments]

I will try this setup locally and give feedback on this PR once I have a feel for it.
I am excited about this approach


Audio Description Support for Tiramisu

Hi there @PierfrancescoSoffritti, first of all I'd like to thank you for building and maintaining this project, it's a library I've used and appreciated for a long time!
So I recently spotted in this video that a new option will be added to the accessibility menu in the settings that will default all audio tracks on videos to the "audio description" track if available (More info in the docs here).
Ideally, I'd like to be able to support the app that I'm currently working on.
So I looked through the docs here to see if there was anyway I could change the audio track of the current video, and check what audio track are available. Unfortunately, I couldn't find anything.
So I just want to check wether I've missed something, or is the functionality mentioned above not supported?

Hi, the audio comes from a webview, so I am not sure. Do you know what is it exactly that you need to support this feature?


Replace Spree with Solidus

Is this a possibility? Thanks!

@dt1973 not gonna happen ;) We won't go back to ancient & clunky admin panel of Spree 2.4, lack of Bootstrap and other great features of modern Spree versions. Living in the past is overrated.
BTW. Spark Solutions is part of the Spree Core Team https://github.com/spree/spree/wiki/Core-Team

:+1:  for what it's worth

But I thought Spree had been disintegrated and abandoned, even people on the core team (ie. Ryan Bigg) seems to recommend Solidus.
As for Bootstrap -- isn't that more for people who are too lazy and/or unable to come up with their own designs? Last time I checked it was full of messy class names and unnecessary grids/divs. At the Solidus Codemy YouTube intro (https://www.youtube.com/watch?v=0mxGzk1Lfwg) the guy adds Bootstrap in the matter of 2 seconds anyway.

As far as I can see, it's the Solidus team that's living in the future.

I understand the story now. @damianlegawiec bought Spree after everyone had left in order for his ecommerce business to benefit from Spree's remaining brand recognition and reputation as one of the world's largest open source projects.
To the members of the former core team -- @radar, @schof, @joneslee85, @BDQ, @cmar, @LBRapid, @paulcc, @davidnorth and @romul -- are you guys ok with being listed on @damianlegawiec's site and hence used as pawns in his game? Shouldn't your names be listed on the Solidus site instead, considering it's the true continuation of Spree?
cc @JDUtil, @huoxito, @danabrit, @devilcoders, @peterberkenbosch, @GeekOnCoffee, @stephskardal, @parndt

What site? What games?
This seems like drama generation for the sake of it.
Show some facts instead of these essentially baseless accusations and then maybe you might get some backing.
I don't get why you're so mad.

On 5 Apr 2016, at 21:16, dt1973<EMAIL_ADDRESS>wrote:
I understand the story now. @damianlegawiec bought Spree after everyone had left in order for his ecommerce business to benefit from Spree's remaining brand recognition and reputation as one of the world's largest open source projects.
To the members of the former core team -- @radar, @schof, @joneslee85, @BDQ, @cmar, @LBRapid, @paulcc, @davidnorth and @romul -- are you guys ok with being listed on @damianlegawiec's site and hence used as pawns in his game? Shouldn't your names be listed on the Solidus site instead, considering it's the true continuation of Spree?
cc @JDUtil, @huoxito, @danabrit, @devilcoders, @peterberkenbosch, @GeekOnCoffee, @stephskardal, @parndt
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

@radar :+1:

Yeah, let's cool down a bit. There is no harm done IMHO. Although I disagree with the comment about Solidus, let's just agree to disagree, keep it classy and move on with our lives :beers:

@dt1973 dude, what game? What pawns? We didn't buy spree. We (Spark Solutions + VinSol) just volunteered to maintain and develop Spree. For free. Because we have many clients using Spree. That's the whole story behind it.

@dt1973 You are entitled to your own opinions but there are rules of conduct you should read about: https://github.com/blog/2039-adopting-the-open-code-of-conduct
Show some respect to other people's time & effort - you are being disrespectful and xenophobic without any reason except for the fact that we (Spree Core Team) are trying to support Spree-based stores and their developers. It's a thankless job and we don't expect any thank-yous. But attacking us like that... I'm very disappointed in you as a reasonable adult.
If you continue your ways I will be submitting your posts to GitHub admins as abusive both personally towards @damianlegawiec and in general (i.e. national origin). I am sure that open-source community will not tolerate any harassment of this sort. I'm sure I can expect Solidus community support in this matter.
I would rather agree to disagree. Thank you.


Add basic mobile support for website

Here's a before and after on a Pixel 2. Note that with the meta tag, the contents are no longer scaled down, and are kept true to size.

Before
After

Hi @veyndan
I checked "Before" with my Pixel 8 :-) and it looked far better than on your screenshot. Something changed after I applied your changes, not bad.
So I decided to accept your changes, thank you! I hope some day I will take time to understand the differences.

I used the Firefox dev tools to mimic what the website would look like on mobile, so perhaps the dev tools just exaggerated the zoom effect :shrug:


Fix README

README file has been copied from AngularJS branch and must be updated.

Yes, I would like to know how to start all those services?
Maybe with Docker or Spring Cloud CLI? https://cloud.spring.io/spring-cloud-cli/

I don't have experience with Spring Cloud CLI as of yet, so I've created yesterday a task #2 for Docker. If anyone can provide a Spring Cloud CLI setup, we probably could use it instead of Docker.

AngularJS documentation has been updated into the https://github.com/spring-petclinic/spring-petclinic-microservices/pull/29

I propose to complete the readme.md with some database information then remove petclinic_db_setup_mysql.txt and db_readme.txt files

With PR #33 the Front-end module table has to be updated.

@mszarlinski could we close this issue?


Allow for local clock skew in JWT validation

Fixes #1223

@jskeet In my opinion this is the right thing to do, as clock skew will almost always be present on client machines. Although hopefully not as much as 30 seconds.
Perhaps the default should be 10 or 15 seconds rather than 30.
What do you think?

Hard to say. Am I right that the current behaviour is effectively 0 though?

@jskeet PTAL.


Double entries in history list

Some (it seems all old) entries appear twice in history tab:

Each pair has the same date and TxID, and editing description of one entry affects other.
Feather version: 2.1.0
Wallet height: 2700196
Daemon height: 2700196
Target height: 2700196
Restore height: 2685729 (2022-08-09)
Synchronized: True
Remote node: xmr-node-usa-east.cakewallet.com:18081
Wallet status: Synchronized
Websocket status: Connected
Tor status: Running
Tor level: 0
Network type: MAINNET
Seed type: 16 word
Device type: Software
View only: False
Primary only: True
Operating system: Windows 10 Version 2009
Timestamp:<PHONE_NUMBER>

Hey,
Thanks for the bug report.
Did you manually import any transactions before the wallet was finished synchronizing?
Best regards,
tobtoht
------- Original Message -------
On Monday, August 29th, 2022 at 12:55 PM, Vovodroid @.***> wrote:

Some (it seems all old) entries appear twice in history tab:
image
Each pair has the same date and TxID, and editing description of one entry affects other.
Feather version: 2.1.0
Wallet height: 2700196
Daemon height: 2700196
Target height: 2700196
Restore height: 2685729 (2022-08-09)
Synchronized: True
Remote node: xmr-node-usa-east.cakewallet.com:18081
Wallet status: Synchronized
Websocket status: Connected
Tor status: Running
Tor level: 0
Network type: MAINNET
Seed type: 16 word
Device type: Software
View only: False
Primary only: True
Operating system: Windows 10 Version 2009
Timestamp:<PHONE_NUMBER>
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

Did you manually import any transactions before the wallet was finished synchronizing?

No, I even don't know how to do this )))


Creates initial state to avoid error on first paint

Currently, when starting the application, you are greated with an Error ( a bunch of parsing errors actually).
This MR adds a cleaner initial State

Not merging because the parser has responsibility for this. Not the generic frontend that uses the parser. Please fix this by changing the parser definition as shown IRL ;)

But initial state and empty state are different aren't they?
I did the empty state (before the parser gets run). I agree about an empty
state. :)
On Mon, 11 Jun 2018, 6:10 PM Swen Mulderij<EMAIL_ADDRESS>wrote:

Not merging because the parser has responsibility for this. Not the
generic frontend that uses the parser. Please fix this by changing the
parser definition as shown IRL ;)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Swendude/Tortoise/pull/7#issuecomment-396298314, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA4QQjoECdmYh5xyxZ5VdyZHMr8kCO79ks5t7paAgaJpZM4Uf7cw
.


fixing illumos build for couple of structs

@bors r+

:pushpin: Commit 8642e84b9b21c45f2d8551a48d0a2e9eac8a74d9 has been approved by Amanieu

It's because the error only happens with the rustc-dep-of-std feature enabled, which is only used when built as part of the standard library.

:hourglass: Testing commit 8642e84b9b21c45f2d8551a48d0a2e9eac8a74d9 with merge fe5e6cc5b9840b4d7a19186891361516cb236142...

:sunny: Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: Amanieu
Pushing fe5e6cc5b9840b4d7a19186891361516cb236142 to master...


samples: mesh: nrf52: revised implementation

Removed redundancy from App & revised overall implementation.
Fixed Bugs. Upgraded coding style. Added & replaced comments to
improve code readability.
Upgrade State Binding algorithm by adding ceiling() & constrain
functions.
If particular Server model receive Prohibited values as per
Mesh Model Specification then that message will not get entertained.
Now proper status code will get send if user upgrade
light_lightness_range_state & light_ctl_temperature_range_state.
Added time stamp based message filtering as per Bluetooth Mesh
Developer study guide for each Server. Now even if message
source address & TID is same even after 6 seconds then
that will get proceed otherwise will get ignored.
Added transition time support. With this it was possible to
implement gen_move_set/gen_move_set_unack message handlers.
Signed-off-by: Vikrant More<EMAIL_ADDRESS>

@MariuszSkamra
Kindly note that due to some Github related conflict issue I've closed
https://github.com/zephyrproject-rtos/zephyr/pull/8926.
If you gonna execute PTS then please run it against this latest PR.
@jhedberg I've not yet deleted PR:8926. Please excuse me :(

Codecov Report

Merging #9419 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9419   +/-   ##
=======================================
  Coverage   52.16%   52.16%
=======================================
  Files         212      212
  Lines       25894    25894
  Branches     5563     5563
=======================================
  Hits        13507    13507
  Misses      10129    10129
  Partials     2258     2258

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3832378...26b4015. Read the comment docs.

@nashif Please review & help to merge this PR.

@jhedberg @nashif
It was https://github.com/zephyrproject-rtos/zephyr/pull/9302 because of it conflict arises.
As per our email communication, I had already informed you that I've take care of that Bug in PR:8926.
Playing with rebase & git commands is already nightmare & on that if something like this happen then what to do I don't know.

@jhedberg @nashif
Please as of now merge this commit since it is very large. Surely it is better than what is currently present in master branch.
I will take care of upcoming PTS results in next PR.

@jhedberg Many many thanks.


Selector is not visible error even with visibility check and visible values checking

Are you requesting a feature or reporting a bug?
reporting a bug
What is the current behavior?
The element that matches the specified selector is not visible.
  Browser: Chrome 63.0.3239 / Linux 0.0.0

     392 |
     393 |        const strategy2ActionDeleteItem = await
  automation.qaE2E_strategy2Delete.with({visibilityCheck:true})
     394 |        const deleteVisible= await
  automation.qaE2E_strategy2Delete.visible
     395 |        if (deleteVisible){
     396 |            await testController
   **> 397 |                .click(automation.qaE2E_strategy2Delete)**
     398 |

Even if already added async checks using visibilitycheck and visible values before clicking, but error still shows the selector is not visible.
The control I am trying to select is a drop down toggle item in a drop menu.
What is the expected behavior?
I should be able to click the delete control
How would you reproduce the current behavior (if this is a bug)?
running on docker image for testcafe
with chromium version 63.0.3239
Provide the test code and the tested page URL (if applicable)
Tested page URL:
Test code

Specify your

operating system: Linux alpine ( base image same as the docker configuration)
testcafe version:  v0.18.6
node.js version:    v8.9.4

@AndreyBelym : Unfortunately, I still get this issue mainly inside the testcafe docker image.
Getting a lot of visibility errors inside the docker image although both running on the same testcafe versions 0.18.7-dev20180117

@ameyagholkar @neilmatillano It can be related to the browser size. Could you please try to use my proposal about the t.maximizeWindow from the comment

@AlexanderMoskovkin  :  This is the message when I run the tests on docker
Warnings (1):
The window maximization functionality is not supported by the "chromium"
browser provider.

Try the resizeWindow action then:
await t.resizeWindow(1920, 1080)

@AlexanderMoskovkin , it helped fixed some of the issues, especially on the widget visibility, but I still have few unusual tests behaving differently probably not related to visibility anymore Still investigating.
Thanks!

We can close this issue :) Thanks!


Tabs usage a11y updates

Closes https://github.com/carbon-design-system/carbon-website/issues/3826
Update the Tabs documentation on the Usage tab on the website with a11y comments and using the new content template.
Changelog
New

Add in manual and automatic tab information
Add in tab panel information (Color and usage)

Changed

Updated to new template structure
Updated imagery (rebuilt in Figma from old sketch files)

Images
Aligning to grid columns image

Needs the browser bar in the top like the other in context images

Alignment within a component image

I don’t think this images components and text scaled correctly. Some of the text in this image seems to be at weird sizes, there looks like there is a 1px white line under the primary button, and the inputs on the right are not 16px from the edge.

Line tabs image

The browser border looks small here compared to other in context images not this page. I would just double check it to see which size is the right one for all of the in context images.

Contained tabs image

Same comment here about the browser bar.
The contained tab image needs a vertical divider between the unselected tabs.
The word “Java script” should be “JavaScript” in the rows.

Secondary labels image

There is just a slight double line under the Hamburger menu in the header.

@laurenmrice i've taken the gifs out for now. right now, this is a blocker for me and the vertical tabs docs and i just can't figure out the jumping gifs. once this gets pushed, i can update the vertical tabs docs and then can get back to troubleshooting the gifs. luckily the accessibility tabs does have static imagery and auto vs manual that I can link to.

@laurenmrice i've taken the gifs out for now. right now, this is a blocker for me and the vertical tabs docs and i just can't figure out the jumping gifs. once this gets pushed, i can update the vertical tabs docs and then can get back to troubleshooting the gifs. luckily the accessibility tabs does have static imagery and auto vs manual that I can link to.

@kingtraceyj Okay cool no worries. I think these gifs are really just "nice to haves" anyways, and you can add them at a later date if you still want to. The guidelines for this are already explained in the content.


predict_tile return_plot=True

a = deepforest_model.predict_tile(numpy_image=img, patch_overlap=0.1, return_plot=True)
65 predictions in overlapping windows, applying non-max supression
65 predictions kept after non-max suppression
Traceback (most recent call last):
  Debug Probe, prompt 89, line 1
    #Convert NEON field sample points into bounding boxes of cropped image data for model training
  File "/Users/ben/miniconda3/envs/DeepTreeAttention_DeepForest/lib/python3.7/site-packages/deepforest/deepforest.py", line 490, in predict_tile
    draw_box(numpy_image, box, [0, 0, 255])
  File "/Users/ben/miniconda3/envs/DeepTreeAttention_DeepForest/lib/python3.7/site-packages/deepforest/keras_retinanet/utils/visualization.py", line 32, in draw_box
    cv2.rectangle(image, (b[0], b[1]), (b[2], b[3]), color, thickness, cv2.LINE_AA)
builtins.TypeError: an integer is required (got type list)

I think it should be a tuple?
(0, 0, 255)

Need to write a test that reads in a tile and uses the numpy_array argument and tries to plot the boxes.


[BUG] Task Showcase - Planned Tasks should show which sprint they are in

Describe the bug
Task Showcase - Planned Tasks should show their sprint information. They used to, but now they don't.

Current behavior:

Tasks in current sprint show they are in the current sprint.
Tasks not in current sprint & non-scheduled tasks don't show they are scheduled at all.


Feature request: Make the donation process easier (to support development)

Please add direct cryptocurrency addresses within the app. Easy tap and donate without leaving the app: I don't want going around to websites. I don't want support FIAT economy.
TRX, AVAX, LTC, BTC, XEC, BNB, SOL, BCH, ALGO, XTZ, DASH, EPIC, FTM, XRP, XDC, ADA, XLM, XMR addresses available for donations (addresses have to be copyable).
Here an integration example made by other developers.

It's a bit hard to add donate links directly to apps without running afoul of app store rules. But, I've added my ETH address to Support the Project, which is linked from the About page in today's Cuppa 2.6.0 release. I hope this makes it a bit easier to donate.


circleci: update orb versions

@antoineco this change will use the latest versions of those orbs. but more importantly it appears there are changes in the go orb after which the go module cache/restore actually works

Ahhhh great news! Support for caching has been pretty terrible so far so I have high hopes 😄


Speed Increases as the score increases

Description
I added a auto increase feature so the speed increase automatically when the score increases, It increases the fun of game ;)

Okay let me fix this


Fix RadioButtons putting focus on wrong element when moving between RadioButton groups

Description
RadioButtons was putting focus on the first or last element if the previously focused element was a RadioButton in another RadioButtons group.
Motivation and Context
The problem is that ItemsRepeater.GetElementIndex is returning non-zero for elements in other repeaters. I'm following up on whether that's expected but RadioButtons doesn't need to use that logic here so I'm changing to a simpler parent check.
How Has This Been Tested?
Manually, will write a test before submitting.

I'm having trouble running the test test from this PC, so this change is slightly speculative.

@StephenLPeters  - It would be great if we can add IsTabStop = true to the scrollviewer which surrounds the RadioButtons. Otherwise radio's selection resets whenever we click somewhere on the page (scrollviewer sets the focus on the first element).


Update README.md

use spsolve_triangular for R\QB

I get an error:
>>> result = scipy.sparse.linalg.spsolve_triangular(R, QB, lower=False)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.6/site-packages/scipy/sparse/linalg/dsolve/linsolve.py", line 512, in spsolve_triangular
    'b must have 1 or 2 dims but its shape is {}.'.format(b.shape))
ValueError: b must have 1 or 2 dims but its shape is ().

You're right,
In
https://docs.scipy.org/doc/scipy/reference/generated/scipy.sparse.linalg.spsolve_triangular.html#scipy.sparse.linalg.spsolve_triangular
b is a numpy.array. I will create a new PR, because I delete the branch for this PR.


docs: make sure that channels use finally in all examples

Right now this code:

Is not really correct, because in case of an exception - it will not execute await channels.unsubscribe(subscriber, ["foo"]), which might be unexpected.
 You may increase the limit by authenticating and upgrading: [https://www.docker.com/increase-rate-limit\n](https://www.docker.com/increase-rate-limit/n)'
retcode = 18

@Alc-Alc can you please take a look? :)

@Alc-Alc can you please take a look? :)

finally did 😅 thank you 🙂


chore(deps): update common-dev-assets digest to c84fb95

This PR contains the following updates:

Package
Update
Change

common-dev-assets
digest
b991e19 -> c84fb95

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 2.2.0 :tada:
The release is available on:

GitHub release
v2.2.0

Your semantic-release bot :package::rocket:


Quickchecking crate CLI

Prior to this commit the quickchecking crate used for generating proprty tests for bindgen was a [lib] target and had configurations that required commenting/uncommenting code to enable/disable. This meant it was inconvienent/prohibitive to configure the property tests on a per-run basis. This commit reorganizes the quickchecking crate to provide both [lib] and [[bin]] targets in order to expose those configurations through a CLI.
The configurations that are exposed through the [[bin]] target's CLI are:

Count/number of tests to run.
Directory to provide fuzzed headers
Generation range corresponding to the range quickcheck uses to
generate arbitrary.

Usage from the tests/quickchecking directory
quickchecking 0.2.0
Bindgen property tests with quickcheck. Generate random valid C code and pass it to the csmith/predicate.py script

USAGE:
    quickchecking [OPTIONS]

FLAGS:
    -h, --help       Prints help information
    -V, --version    Prints version information

OPTIONS:
    -c, --count <COUNT>    Count / number of tests to run. Running a fuzzed header through the predicate.py script can
                           take a long time, especially if the generation range is large. Increase this number if you're
                           willing to wait a while. [default: 2]
    -p, --path <PATH>      Optional. Preserve generated headers for inspection, provide directory path for header
                           output. [default: None]
    -r, --range <RANGE>    Sets the range quickcheck uses during generation. Corresponds to things like arbitrary usize
                           and arbitrary vector length. This number doesn't have to grow much for that execution time to
                           increase significantly. [default: 32]

Because the actual work of running the property tests moved to the [[bin]]
target, rather than duplicate that code in the quickchecking crate's tests
directory, some actual (very basic) tests for the quickchecking crate were
added.
*Note: I'm not attached to any of the option flags, if there are better characters/words for any of the options I've exposed I'll be happy to revise!
Also, I'm not sure how palatable the "global singleton" is for managing context (output path) across tests in the lib.rs file. Very open to suggestions on how to manage that if it's not an acceptable approach.
Thanks for taking a look, looking forward to feedback!
Closes #1168
r? @fitzgen

For sanity here's a couple fuzzed headers generated with the state of the current code.
https://gist.github.com/snewt/8afbf552c8f40974a9fdd903e63beec6

@bors-servo delegate+

:v: @snewt can now approve this pull request

@fitzgen ah awesome, can do (this evening).

@bors-servo r=fitzgen

:pushpin: Commit 2c77652 has been approved by fitzgen

:hourglass: Testing commit 2c776522aea807a37a78e47154c128c198b5d985 with merge a59205e8cf9aa1acfaceafa5c37ba297341e178b...

:sunny: Test successful - status-travis
Approved by: fitzgen
Pushing a59205e8cf9aa1acfaceafa5c37ba297341e178b to master...


Earthchem “Failed to create submission” problem

Description of the bug
Earthchem submission process produced confusing behavior:
Steps to reproduce the bug:

Go to my submissions and start a simple EarthChem submission.
Fill in required field and click on "submit for review."
A red warning box with the message "Failed to create submission" appears at the bottom of the screen with a "Dismiss" button.
Message goes away on its own in a few seconds.
Click on my submissions produces a message asking if I want to discard the submission.
Clicking discard takes me to my submissions where the submission appears after all.
Clicking on view submission takes me to ECL where an error page is produced.
Logging into ECL, I see the submission in the pending state.

Expected behavior

No "Failed to create submisision:" message should appear.
Clicking on my submissions should not ask me to discard the submission if it's actually there.
Clicking on view submission should take me to ECL and show me the pending submission.

Additional information
Add any other context about the problem here such as screenshots, software versions, and browser information.

Related: I get "Failed to create submission" if I fill in the required items and add either of the following:

co-author
funding source

And then "Finish" -> "Finish Later" (note this is different from Chris' "Submit for Review")

Repository exception response[{"timestamp":1657668431683,"status":500,"error":"Internal Server Error","message":"0","path":"/v2/records"}]

Not necessarily surprising, BUT the interesting part is: if I just fill the required items without adding one of the above two fields, I can "Finish Later" and the record saves successfully
Probably this is a separate issue but adding it here for now for consideration

I created a separate issue for my comment above, #62

My issue #62 is resolved by Peng's changes this am, but from what I can tell this issue is still present

I could not reproduce this issue. Let me know if it still happens for one of you.

confirming fixed for me on dsp-test (though I can't reach https://test-ecl.earthchem.org to verify from the repository side)


Pin numpy for crocoddyl because np.asscalar has been removed from 2.23

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

requirements: build: numpy <= 1.22 should not contain a space between relational operator and the version, i.e. numpy <=1.22
requirements: host: numpy <= 1.22 should not contain a space between relational operator and the version, i.e. numpy <=1.22

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender


⚠ ClamAV has degraded performance

In 41a35b6, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 66 ms

Resolved: ClamAV performance has improved in 6320686.


Fr translation

Hello,
As a French user, I propose the French translation of your English file so you can integrate it into your "Rideable" module.
I tested it locally to make sure everything was okay before giving it to you.
Looking forward to it!
fr.json

Thank you very much, i will quickly release an update including the translation

I have released your translation with v3.1.1, thanks again, much appreciated.


Chenqi/marketplace

Coverage decreased (-25.4%) to 16.254% when pulling c7b6da66c48550412da1823006292142e6bf6c2b on chenqi/marketplace into fb19549803b1df205df55a10491fc8ea496b02c2 on marketplace.


probe: lmrc

add as much of the language model risk cards as there are prompts & off-the-shelf detectors for

dupe #52


React  Typescript - Controls Addon enum control not rendering consistently

Created a vite app and corresponding storybook using commands:
npm init @vitejs/app my-vite-app
npx sb@next init --builder storybook-builder-vite

Firing up the storybook and looking at the Button -> Large story the control for the size prop renders as a text input. If you disable the vite builder in the main.js and use default webpack core it will render the size prop as radio buttons which is the documented control in Controls Docs
The control for the primary boolean property and the onClick are also missing. Manually providing the control config via argTypes will render the size control correctly.
Vite:

Webpack:

Thanks for the report.  It's just a guess, but I think this could be related to problems in ordering how the config of plugins are loaded (https://github.com/eirslett/storybook-builder-vite/issues/62#issuecomment-878315260).

Thanks for the report.  I believe the control types are extracted as part of the docgen generation, which doesn't work in this builder as it's coupled to the webpack loader used in storybook.  There's an effort underway to decouple them, but as far as I know it's not ready yet.  https://github.com/eirslett/storybook-builder-vite/issues/46#issuecomment-869284292.

@chrislegault We've just released https://github.com/eirslett/storybook-builder-vite/releases/tag/v0.1.15, which I think will address this issue.  Could you please check and close this issue if your problem is resolved?

@IanVS I'm using "@storybook/builder-vite": "^0.1.29" and its have strange behavior same as this issue. I have two stories file, the one correctly generate the docs from the typescript interface and the one only generate it from the args provided on the story file and have wrong controls.
This is the one that generate the docs from args only

import { ComponentMeta, ComponentStory } from "@storybook/react";
import { FiTrash } from "react-icons/fi";
import Button from "./BaseButton";

export default {
  title: "Button",
  component: Button,
} as ComponentMeta<typeof Button>;

const Template: ComponentStory<typeof Button> = (args) => <Button {...args} />;

export const Base = Template.bind({});
Base.args = {
  children: "Button",
  color: "brand",
  size: "md",
  variant: "primary",
};

This is the output I expected. You can see that the props control rendered correctly as radio button when using an enum and not rendered as textbox.

import { ComponentMeta, ComponentStory } from "@storybook/react";
import { FiMoon } from "react-icons/fi";
import IconButton from "./IconButton";

export default {
  title: "Button/Icon Only",
  component: IconButton,
} as ComponentMeta<typeof IconButton>;

const Template: ComponentStory<typeof IconButton> = (args) => (
  <IconButton {...args} />
);

export const IconOnly = Template.bind({});
IconOnly.args = {
  color: "brand",
  icon: FiMoon,
  size: "md",
  variant: "primary",
};

The ButtonProps and IconButtonProps should generate 10 controls in the docs, but only IconButtonProps that generate it correctly; though they have and using the same interface.
types.ts
export type ButtonColors = "brand" | "gray" | "green" | "red" | "yellow";
export type ButtonVariants = "primary" | "secondary" | "ghost";
export type ButtonSizes = "sm" | "md" | "lg";

interface ButtonBaseProps {
  /** Choose between normal or full-width button */
  block?: boolean;

  /** Button colors */
  color?: ButtonColors;

  /** React element children */
  children?: React.ReactNode;

  /** Disabled state */
  disabled?: boolean;

  /** Set icon to be rendered in the button */
  icon?: React.ComponentType<React.SVGProps<SVGSVGElement>>;

  /** Position of the icon to be rendered */
  iconPosition?: "left" | "right";

  /** Show loading indicator if set to `true` */
  isLoading?: boolean;

  /** Set loading text */
  loadingText?: string;

  /** Button sizes */
  size?: ButtonSizes;

  /** Button variants */
  variant?: ButtonVariants;
}

export type ButtonProps = ButtonBaseProps &
  React.ComponentPropsWithRef<"button">;

// For the sake of simplicity and example, I make it same as `ButtonProps` to see which one
// can generated the docs correctly.
export type IconButtonProps = ButtonBaseProps &
  React.ComponentPropsWithRef<"button">;

Might it useful to include the component file:
BaseButton.tsx
import React from "react";
import { FiLoader } from "react-icons/fi";
import twClsx from "~/utils/tw-clsx";
import { ButtonProps } from "../types";
import {
  buttonSizing,
  buttonColorVariant,
  createButtonIcon,
} from "../Button.helpers";

const Button = React.forwardRef<HTMLButtonElement, ButtonProps>(
  (
    {
      block,
      color = "brand",
      children,
      className,
      disabled,
      isLoading,
      icon,
      iconPosition = "left",
      loadingText = "Loading . . .",
      size = "md",
      variant = "primary",
      ...rest
    },
    ref
  ) => {
    return (
      <button
        className={twClsx(
          "inline-flex justify-center items-center gap-2 font-semibold rounded-md transition ease-in-out duration-200 focus:outline-none focus:ring",
          buttonColorVariant(color, variant),
          buttonSizing(size),
          [isLoading && "disabled:cursor-progress"],
          [block && "w-full"],
          [iconPosition === "left" ? "flex-row" : "flex-row-reverse"],
          className
        )}
        disabled={isLoading ?? disabled}
        ref={ref}
        {...rest}
      >
        {isLoading ? (
          <>
            <FiLoader className="animate-spin motion-reduce:hidden" />
            {loadingText}
          </>
        ) : (
          <>
            {createButtonIcon(icon)}
            {children}
          </>
        )}
      </button>
    );
  }
);

export default Button;

IconButton.tsx
import React from "react";
import { FiLoader } from "react-icons/fi";
import twClsx from "~/utils/tw-clsx";
import { IconButtonProps } from "../types";
import {
  buttonIconSizing,
  buttonColorVariant,
  createButtonIcon,
} from "../Button.helpers";

const IconButton = React.forwardRef<HTMLButtonElement, IconButtonProps>(
  (
    {
      color = "brand",
      className,
      disabled,
      isLoading,
      icon,
      size = "md",
      variant = "primary",
      ...rest
    },
    ref
  ) => {
    return (
      <button
        className={twClsx(
          "inline-flex justify-center items-center font-semibold rounded-md transition ease-in-out duration-200 focus:outline-none focus:ring",
          buttonColorVariant(color, variant),
          buttonIconSizing(size),
          [isLoading && "disabled:cursor-progress"],
          className
        )}
        disabled={isLoading ?? disabled}
        ref={ref}
        {...rest}
      >
        {isLoading ? (
          <FiLoader className="animate-spin motion-reduce:animate-none" />
        ) : (
          createButtonIcon(icon)
        )}
      </button>
    );
  }
);

export default IconButton;

And here my storybook config file:
main.js
const path = require("path");

module.exports = {
  stories: ["../src/**/*.stories.mdx", "../src/**/*.stories.@(js|jsx|ts|tsx)"],
  addons: [
    "@storybook/addon-links",
    "@storybook/addon-essentials",
    "@storybook/addon-interactions",
  ],
  framework: "@storybook/react",
  core: {
    builder: "@storybook/builder-vite",
  },
  async viteFinal(config) {
    return {
      ...config,

      /**
       * Import alias support
       * @see https://github.com/storybookjs/builder-vite/issues/85#issuecomment-900831050
       */
      resolve: {
        alias: [{ find: "~", replacement: path.resolve(__dirname, "../src") }],
      },
    };
  },
};

preview.js
import "../src/styles/global.css";

export const parameters = {
  actions: { argTypesRegex: "^on[A-Z].*" },
  controls: {
    expanded: true,
    matchers: {
      color: /(background|color)$/i,
      date: /Date$/,
    },
  },
};

Thanks!

Thanks for the report.  The best way for us to look into this is with a minimal reproduction.  Do you think you could create a new vite storybook project that reproduces this issue?  My guess is that the type definition for the icon prop is crashing typescript-react-docgen, but it would help us a ton to have a repo to poke around in.  Thanks!

Here I create a minimal reproduction for you to tinker around.
For additional behavior notes, the first time I create the BaseButton component it works like charm! The props control rendered correctly based on the type definition but when I create another component (IconButton), the props control on the prior component generated from the args not from the type definition and the new component has the right props control based on the type definition. I tried deleting the IconButton and doesn't change anything.
Thank you!

Thanks for reporting this, and for the reproduction, @mupinnn.  @joshwooding, you'll be interested in this one.  I opened https://github.com/joshwooding/vite-plugin-react-docgen-typescript/issues/2, since I think it's an issue in the react-docgen-typescript plugin.

Hey, I tried it out to change the component name to be the same as the filename and it solved my issue right now. Probably the best workaround until https://github.com/joshwooding/vite-plugin-react-docgen-typescript/issues/2 got an update.
Thanks again @IanVS , I really appreciate it!


Uncomment external link in README

Packages impacted by this PR
@azure/cosmos
Issues associated with this PR
#22789
Describe the problem that is addressed by this PR
External link was commented out as part of original PR to pass a check. Uncommenting the link now.
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
N/A
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists

[ ] Added impacted package name to the issue description
[ ] Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
[ ] Added a changelog (if necessary)

API change check
API changes are not detected in this pull request.


LFS support for multiple repos

It works fine with multiple repos as documented. However, if there are repos with LFS, it would fail.
One work around is to disable LFS by setting GIT_LFS_SKIP_SMUDGE environment variable to 1.
But there are circumstances where LFS is really needed to obtain large files. Is there plan to support this?

Closing for now since I don’t see what would need to be done.


Gradle 8.4 deprecation warnings

Which version and edition of Flyway are you using?
9.21.1
If this is not the latest version, can you reproduce the issue with the latest one as well? (Many bugs are fixed in newer releases and upgrading will often resolve the issue)
Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin)
Gradle plugin
Which database are you using? (Type & version)
Informix V14.10
Which operating system are you using?
Windows
What did you do? (Please include the content causing the issue, any relevant configuration settings, the SQL statement(s) that failed (if any), and the command you ran)
running gradle flywayMigrate task
What did you expect to see?
no deprecation warnings in gradle output
What did you see instead?
> Task :flywayMigrate
The Project.getConvention() method has been deprecated. This is scheduled to be removed in Gradle 9.0. Consult the upgrading guide for further information: https://docs.gradle.org/8.4/userguide/upgrading_version_8.html#deprecated_access_to_conventions
The org.gradle.api.plugins.Convention type has been deprecated. This is scheduled to be removed in Gradle 9.0. Consult the upgrading guide for further information: https://docs.gradle.org/8.4/userguide/upgrading_version_8.html#deprecated_access_to_conventions
The org.gradle.api.plugins.JavaPluginConvention type has been deprecated. This is scheduled to be removed in Gradle 9.0. Consult the upgrading guide for further information: https://docs.gradle.org/8.4/userguide/upgrading_version_8.html#java_convention_deprecation
Flyway upgrade recommended: Informix 14.10 is newer than this version of Flyway and support has not been tested. The latest supported version of Informix is 12.10.

I have encountered this warning as well. Comparing with the Jooq Plugin (https://github.com/etiennestuder/gradle-jooq-plugin/blob/main/src/main/groovy/nu/studer/gradle/jooq/JooqPlugin.java#L65), it seems that all you have to do to fix this is replace line 615 in AbstractFlywayTask with this:
JavaPluginExtension plugin = (JavaPluginExtension)project.getExtensions().getByType(JavaPluginExtension.class)

At first: Many thanks for providing this plugin.
But is there a maintainer here who can provide some feedback?
We actually want to keep our build free of warnings, but that's not possible because of this plugin 😕


"Est. APR" for SNX pool has wrong calculations for a while after changing networks between L1 and L2 networks

Description:
"Est. APR" for SNX pool has wrong calculations for a while after changing networks between L1 and L2 networks.
Reproduction steps:

Go to staking "Earn" page (https://dev.staking.synthetix.io/earn)
Connect your wallet with dapp
Take a look at "Est. APR" for SNX pool (on top of the page and on the "Earn" list) and remember the numbers
Click on "Switch to L2" button and immediately look at "Est. APR" for SNX pool (on top of the page and on the "Earn" list)

Current behavior:

after switching networks (from L1 to L2 or from L2 to L1), calculations for "Est. APR" are wrong for SNX pool

Expected behavior:

only proper calculations should be shown

Screenshots:

Desktop (please complete the following information):

OS: macOS Big Sur 11.2.2
Browser: Chrome 89.0.4389.95

Ok it's because when a wallet is not staking, it defaults to the top 1000 holder average. Problem is, it's taking the data from the graph a.k.a Layer 1.
For now I will just return 0 if wallet isn't staking and network is L2.

@clementbalestrat @andytcf what is the reason for closing it if it's not fixed?


[Bug] :

Device information

Aniyomi version: Stable <IP_ADDRESS>
Android version: 10

Source information

Name: Animepahe
Extension version: English 12.16

Steps to reproduce

have an anime in the library that was added in the previous version of the extension
watch anime or download

Expected behavior
Be able to watch anime or able to download it
Actual behavior
Error HTTP 404
Other details
Webview does work.
And if I add it in the library once again, it works

refresh the episode list.


Multiple KSS entries in SASS files (indented syntax) don't work

If you add a kss declaration after a sass style, that kss will be ignored by sc5 and handled as a commented part of the SASS/CSS.
By putting all KSS declarations in the top of the file and all the sass styles below, all sections will be will be included.
Not sure this is intended, but I'd prefer if I could have KSS and SASS together and have multiple sections declared in one file.

Any KSS declaration that ends with:
// Styleguide 4.2

will create a component numbered 4.2 with its own page and the Sass code that follows will be shown in a "Display CSS" part. Beware that all lines in the KSS part must begin with //  even in markup:, no empty blank line allowed (that's a bit annoying in HTML code but well, still manageable :) ).
Here's an example file found in SC5 project. Do you have a similar structure?

@jnystromdesign Could you provide code example?

I have the same issue. In my example code the "Navigation" does not show up in the styleguide.
// Button
//
// default - Default button
// button--shadow - Shadow button
// button--blue - Blue button
// button--orange - Orange button
// button--orange-gradient - Orange gradient button
//
// markup:
// Button text
//
// Styleguide 2.1

.button
  background: $dark-grey
  border-radius: 5px
  color: $white
  display: block
  font-size: 18px
  line-height: 20px
  padding: 14px 10px
  position: relative
  text-align: center
  text-decoration: none

  &--shadow
    box-shadow: 1px 2px 4px $opacity-black-2

  &--blue
    background: $blue

  &--orange
    background: $orange

  &--orange-gradient
    background: $orange-gradient

// Navigation
//
// markup:
// Navigation
//
// Styleguide 2.2

.nav
  display: block
  background: $blue

This is related to Gonzales bug https://github.com/tonyganch/gonzales-pe/issues/266
As a workround try to add multiline comment /* hack */ before the section which is not parsed.

Yes, that works. But then the /* hack */ shows up in the "Show CSS" part of the generated site. This also works, but then the sg-wrapper lines get ignored.
/*
  Button

  default - Default button
  button--shadow - Shadow button
  button--blue - Blue button
  button--orange - Orange button
  button--orange-gradient - Orange gradient button

  markup:
  Button text

  Styleguide 2.1
  */

.button
  background: $dark-grey
  border-radius: 5px
  color: $white
  display: block
  font-size: 18px
  line-height: 20px
  padding: 14px 10px
  position: relative
  text-align: center
  text-decoration: none

  &--shadow
    box-shadow: 1px 2px 4px $opacity-black-2

  &--blue
    background: $blue

  &--orange
    background: $orange

  &--orange-gradient
    background: $orange-gradient

/*
  Navigation

  markup:
  Navigation

  sg-wrapper:

    <sg-wrapper-content/>

  Styleguide 2.2
  */

.nav
  display: block
  background: $blue


relative URLs are eaten by the proxy

For example, this line:
<script src="./playground.js"></script>

Results in a failed request from the proxy.

This is because ./ gets reformatted by the browser, messing with the reverse proxy. I don't have a way to fix this in mind.

This appears to not be a bug!


Clean up on CLI job template failure

When a CLI template call fails, various entities and resources may have been created prior to the failure point. Examples are jobs, tasks, and blob storage containers.

If a job and any tasks were created, they should probably all be deleted.
If containers were created based on the project metadata (and didn't already exist), then they should probably also be deleted.

AB#41016418

Not high priority


Modify vendors example to use "map"

https://github.com/jspm/jspm-cli/issues/1322
this example should be updated to use map instead of paths

we also have to update the install wizard


install error in laravel 5.1

exec php artisan laravel-admin:install
make:auth not found error.(make:auth is laravel 5.2 or later)
vendor/appzcoder/laravel-admin/src/LaravelAdminCommand.php
line 73: $this->call('make:auth');
Please forgive me my lousy English.
Thanks.

Hi @ozasan
I've made a fix at f3a3122

Hi @sohelamin
Thank you for fix!!


Remove VSCode from highlights code

Checklist

[ ] I have added tests
[ ] Add new "clear highlights" command that will remove all highlights in active editor
[ ] I have updated the docs and cheatsheet
[ ] I have not broken the cheatsheet

@AndreasArvidsson feedback addressed


Removes legacy rapids-cmake cython implementations as it is deprecated in 24.08

Description
rapids-cmake cython module has been deprecated since 24.02 and now can be removed in 24.08
This removes the cython module and instead only offers cython-core.
Checklist

[x] I am familiar with the Contributing Guidelines.
[x] New or existing tests cover these changes.
[x] The documentation is up to date with these changes.
[x] The cmake-format.json is up to date with these changes.

@vyasr It would be good to get your opinion on this PR.
I was worried that dropping the rapids-cython.cmake would break people that included it but never used functions, so now it brings in the cython-core implementations.

I don't think that's a major concern. In theory I suppose it could happen from copy-pasting top-level CMakeLists.txt files, which is I imagine how many projects that aren't RAPIDS projects I originally set up ended up with this code, but I'm not too worried about it.
OTOH I could see an argument for doing what you've done so that in the long run we could go back to rapids-cython rather than rapids-cython-core as the canonical module name. The -core suffix was primarily useful to differentiate, but once there's only one we could switch back.

/merge


ACM-14356: Edge Management dev-preview info

Description of Edge Management (project Flight Control) for ACM 2.12 dev-preview.

https://issues.redhat.com/browse/ACM-12519

Comments addressed! Thanks @avishayt @fzdarsky @mangelajo

/lgtm

/approve


Update delegates to use agile support from IObjectReference

Delegates have their own logic today to make them agile.  They can be updated to make use of the one that is now built into IObjectReference instead and not have to do custom logic.  But given the delegates logic are in the projection it means we need to be able to guarantee that WinRT.Runtime has the changes that make it agile which we can only guarantee on the next assembly version increase.
We should also add actual non agile delegate tests as the current ones are considered agile even though they don't implement IAgileObject because they implement the free threaded marshaler.
See https://github.com/microsoft/CsWinRT/issues/844

Changes staged in https://github.com/microsoft/CsWinRT/tree/manodasanw/delegateagile

Note assembly version change was done in CsWinRT 1.3.0