Snackbar

implementation of a Snackbar according to the specs on https://www.google.com/design/spec/components/snackbars-toasts.html

OK, initial impressions:
Looks nice, animations are nice, but I think we need to ditch the SnackbarHost.
I know we have those for Drawers and Dialogs but they serve the special purpose of fading and disabling the underlying content.  Also, the dialog host API is very specific to the challenge of dialogs withing WPF, so I think we need to make this more of a "classic" control API which works in code-behind and via binding/MVVM.  As it stands I think the API is a little too prescriptive.
I think the next steps should be something like:

Drop the 'Host.  We can just style it to appear vertical bottom horizontal center, then a user can put it in any grid.
It should from ContentControl (I appreciate the guidelines say text only, but we should also follow WPF standards for implementation)
We need some kind of mode: Open,Closed, Automatic

Automatic should auto show and hide every time the content updates
This API will make it more "standard", less prescriptive and reduce the extra Host logical and visual tree element
I guess this would combine the behaviour of of .State and .Show()
We could still keep Show Hide, to cycle through above behaviour...Although I'm tempted to consider moving this to some sort of optional controller...lets look at this afterwards when we see the refreshed API and simplified logical tree.

To expose the button behaviour we should add Command, CommandParameter, CommandTarget dep props, which are pretty much standard.  The we can also expose a ButtonClick, so again we have a standard API for both code behind and binding.

This would be in place of ActionHandler

In OnApplyTemplate, make sure you unsubscribe from previous elements, if client code changes templates, we have a memory leak.  Checkout Chip for an example.

My idea behind the host component was simplicity for the implementation:

Snackbar itself was considered for a single use and to throw it away afterwards. Memory leaks cannot occur as there will not be any reference to the Snackbar anymore and the garbage collector will do the rest.
The code in the Show() method is a little less complex if a new Snackbar should replace an already visible one. The state management will be more simple.

I know that the API is restrictive at the moment. It is just my exact understanding of the specs. And if you know that the user can do something wrong, you can also prevent him from doing that ;-)
The idea of a mode is interesting. I was thinking of adding some overloads to add a custom timeout for showing a Snackbar. Something like the manual mode is not mentioned in the specs so I did not consider it in the implementation. On the other hand I like APIs with different overloads. I just had to implement a common use case at work because the API of a third party library did not provide it.
Will you do the changes or should I implement them?

Is there any estimate on when this will be added?
I agree, it should inherit from contentcontrol, implement commands, implement command parameters, and have an enum for state. I think fading transitions should be included too.

I've scheduled it for 2.1.
Still got a lot of tidying up for 2.0, and I want to incubate the API and have a think about it a bit before it hits master.

@spiegelp if you could do the following then I'll accept the PR into this branch:

Inherit from ContentControl
Delete the 'Host
Have a basic bool IsOpen which triggers your animations
Remove the .Show() and timer stuff
Add the Command, CommandParameter, CommandTarget depProps for the button.

Then we can reassess,  particularly around the Show()/timer stuff when we start looking at 2.1.

I already started with the refactoring yesterday evening. The triggers already work by changing the Content property. However the code is getting much more complex than the initial implementation with the host. I will see what comes out in the next days.

We should be making it simpler...Not more complex...if the Show method and timer and host is removed, So we just go back to the basic control there should be much less code. Then we can figure out and build up the rest later

Throwing the visual states did the trick. They blew up the code with complexity to getting the states work.
The current implementation state is:

the action raises a well-tried event and additionally calls the optional command from ActionCommand property
the action button is available by providing content for the ActionLabel property
the IsOpen property controls the visibility of the Snackbar
Mode == SnackbarMode.HalfAutomatic enables the automatic show and hide behaviour defined in the Material Design specs by setting the Content property (I'm too lazy for the bad practice of reimplementing the timer in each and every application)

Check it out!

Four months are enough time to read the API docs and to incubate new ideas. I moved the animations from the XAML into the code. This allows more control on the animations and setting a Completed event handler which will close the Snackbar in HalfAutomatic mode.
And the best of all: No more need of the timer!

I've got issues over a year old I still haven't tackled, so no, four months isn't enough.
I preferred the animations in XAML.  I think the control needs to be as vanilla and as simple as possible.  You have to consider a busy system where people might start throwing batches of notifications at it, and thus we have to consider threading and queueing and batching.  Which is always risky code.  I'd rather pull this stuff out into some sort of VM/Controller which people can optionally use (if we even supply that as part of the lib at all). In which case I can't see much justification in having the animations in code.  Going back on my previous remarks, I think we simplify things further - at least for now - with just an IsOpen flag. A simple control can make master branch before a more complex and risky controller.  It's my job to safe guard the API (which is just as -if not more- important as the aesthetics), so until I have some clear time and some inspiration to work on this we may have to wait a bit longer.  I'm currently working on something else, which I intend to use the snackbar in, so at this point I will assess the control/timing issue thoroughly.  But at the moment this control is part way down a very long work list of tasks I am working through.

The four months refer to my experimental phase. I had serveral ideas based on other stuff that I wrote or saw but each one had a drawback, strange side effects or even did fail (exceptions by freezed resources, never ending loops in triggers, broken bindings after one call, many code...). Implementing each detail of the specification pushes WPF to its limits for pretty code. The current Snackbar has probably the smallest drawback.
I would strongly prefer the animations in the XAML as they are very UI specific. However combining them with the behaviour of the specification caused side effects. The current Snackbar contains some UI logic in the code (I usually refuse to write such code) but it gets the job done. The specified behaviour requires this "ugly" code in any solution. Some async code done by storyboards, own threads or something else will be always needed. Using a view model or a controller might move such code to another place. It is a kind of personal preference in which class such code should go to. Moving to a controller might be an overhead and (drawback's greetings) probably causes that the Snackbar will not be fully configurable and controllable in XAML.
The intention of also implementing the behaviour is that it will be implemented once instead of each time a Snackbar should be shown in an application. Moreover these small details enhance the user experience. They are the joy of use. It is the user centered thinking of mine. A user does not care about "ugly" code. He/she needs an appealing UI that gets the job done, although it is a tough task for a programmer in some cases.
The Snackbar is not suitable for batches of notifications by specification. A Snackbar following the specifications just throws old notifications in favour of the newest one. This use case requires another concept or intended control. Maybe some kind of container which creates a new Snackbar for each notification and stacks them. That is an argument for introducing a controller for the basic behaviour and a special one for this use case.
I will move the animations back to XAML. The behaviour stuff will get a new concept on a different branch for future reference.

Sorry, sorry, sorry, I thought you were being impatient! 😳
OK, get the XAML animations put back in and I'll take another look.  I will will a copy into another of my applications and have a play around with methods of calling it etc.
👍

It would be desirable to fire and forget messages without worrying about queuing or timing, so I agree that the control should handle those aspects.

@EdonGashi yes, the final API will support that

Hello, I took @spiegelp 's implementation and tweaked it a bit and added queueing support in automatic mode.
Check it out and see if you can salvage anything out of it.
It's in one take so it might have bugs.
Thanks!

Please be aware that the snackbar branch is active and is currently being worked on...

Should I send a PR there with separate classes for experimentation?
I needed to use a quick implementation in a project, that's why I put it inside a new library.

You might want to wait a little cos I'm hacking around with it currently.

Good that I had much work in the garden last weekend. So I did not start a third implementation full of merge conflicts.
My ideas so far: I was thinking of changing the Snackbar to a control with less logic. Just IsOpen and a trigger for the animations. For timing, queuing or stacking I would introduce a view model and a controller which handle the neccessary logic with bindings and events. As the logic for these features blows up the Snackbar API, new specific controls might be a solution. They will have the specific API for their feature and can use the "stupid" Snackbar internally.
I hope that these ideas help you a little bit for your hacking.

Ha @spiegelp , I  am the same...gotta get the garden ready for winter :)

#404 Snackbar Not Found.
I agree that some of this functionality should be in a ViewModel or Controller.

Locking this conversation as it's a merged and closed PR.  For further updates on snackbar see https://github.com/ButchersBoy/MaterialDesignInXamlToolkit/issues/390


Error compiling for windows debug

Ive followed everything thoroughly but it refuses to compile.
Here's the log:
PS D:\CodingStuff\PowerRoomGodot> scons platform=windows target=release
scons: Reading SConscript files ...
scons: done reading SConscript files.
scons: Building targets ...
haxe build.hxml -D HXCPP_GC_GENERATIONAL -D HXCPP_CPP11 -D static_link -cpp bin/ -cp bindings -D HXCPP_M64
C:\HaxeToolkit\haxe\lib\hxgodot\git\src\import.hx:3: characters 8-26 : Type not found : godot.core.GDUtils
scons: *** [bin\libHxGodot.lib] Error 1
scons: building terminated because of errors.

Apparently you didn't generate the bindings correctly. You should have a bindings folder in your project as shown below:


DBZ-8069 Add docs on override data change topic prefix config

Adding docs for the config here https://github.com/debezium/debezium-connector-vitess/pull/203

Thanks for the review @roldanbob, applied.


Allow rpc hostname and port to be specified at run time

It appears that application code using gerbil-ethereum has no way to specify an arbitrary endpoint for the rpc service because the host and port are hard-wired here: https://github.com/fare/gerbil-ethereum/blob/master/network-config.ss#L229
There are scenarios under which the endpoint is not known until run time and at present it isn't possible to use gerbil-ethereum in those scenarios.
Providing the endpoint at run time is usually possible with Ethereum clients e.g. like here: https://book.getfoundry.sh/reference/cast/cast-chain?highlight=--rpc-url#options
or here: https://web3js.readthedocs.io/en/v1.8.2/web3-eth.html#example-local-geth-node
Specifically this issue arose when attempting to run the integration tests for a gerbil-ethereum application against a test Ethereum node listening on a non-standard port.

Good enough dirty workaround in #62, but let's keep this issue open until a real solution is implemented.

Clean non-draft PR: https://github.com/fare/gerbil-ethereum/pull/63


Add bluetooth and default speaker options

iPhone now defaults to loudspeaker instead of ear speaker.
High quality bluetooth enabled.

Works


This helps fix an issue with trigger that relies on widget load

This helps fix an issue with trigger that relies on condition: "When a visitor has loaded the chat widget". It appears that Zopim is not aware of the widget subsequent loading if you already have a session. The scenario is that you want to have an automated greeting without a prechat form. You could set a trigger to listen on widget load. But if you have already a session and there is no event change. Even if you click "end chat" button, Zompim is unable to run this trigger shown below. Once this line is added, problem solved :) I think it's probably a good idea to track the event anyway and maybe let user define the events in the future.

Hello, thanks for the PR, would it not be better to having a bridge method that allows to trackEvent ? so you can trigger that however you want?

Yeah, that is what I was thinking as I stated in the last sentence. Just things been really busy otherwise I am sure we will map everything through the bridge :) @jrichardlai

Will do another new pull request once I got time to finish both iOS and Android


Hotfix/steam db enrichment

Update enrich_db_users log messages to be more clear
Exit if a steam API key is not set as it's mandatory
Reduce chunk size (number of profiles fetched per steam API request) from 100 to 25 to try to reduce the chance of steam rate limiting
Don't fetch windows store ID players from the database for enrichment
Add some tests to make sure the steam API decorators are filtering windows store IDs properly

Working on a more robust steam API change in another branch.
Plus I misunderstood the chunk size we want to pull as many steam ID results from a single API request as we can


[SQL]Hive Metastore Table provider for SQL

Example implementation of an external table provider for schema lookup.

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.
 R: @apilloud @amaliujia @kennknowles

Can org.apache.hive.hcatalog:hive-hcatalog-core be made as an optional dependency in a similar manner it was done for PubSubJsonTableProvider?

Can org.apache.hive.hcatalog:hive-hcatalog-core be made as an optional dependency in a similar manner it was done for PubSubJsonTableProvider?
It isn't obvious from the build file that there is a dependency, but when I have built this PR to try it out and attached it to example project, it pulled Hive, HCatalog, etc.

I agree, this should be optional, will try to make it work

run sql postcommit

run java postcommit

run sql postcommit

run sql postcommit

@kanterov do you think provided is optional enough? Or are you thinking compileOnly or something else? I changed it to provided, seems to be working locally, jenkins is slow to pick up though to verify

run java precommit

As I understand our dependency guidelines [1], we should do the following:

declare dependency versions in top-level of build.gradle, like it was done for other dependencies
shadow org.apache.hive and org.apache.hadoop dependencies, and relocate them into repackaged/beam_sdks_java_extensions_sql, otherwise, we have a potential diamond dependency problems with user's dependencies
declare beam-sdks-java-io-hcatalog as provided dependency, like it was done in case of PubSubJsonTableProvider

(2) might make little sense: why would we include Hive, if it's optional. As for me, it seems there is no other way because provided dependencies lead to the diamond problem. Unless we a new module, or move extra logic to beam-sdks-java-io-hcatalog.
As I see, our shadow configuration works differently from what I expected. My expectation was that it would do relocation by default. I'm not completely sure what would be the way to configure it, need to dig deeper.
[1] https://beam.apache.org/contribute/dependencies/

io-hcatalog is a provided dependency. The extra logic that requires the hive/hadoop dependencies is not in io-hcatalog though, that's why I need extra dependencies. If we shadow and relocate those hive/hadoop dependencies, then we will include them in every distribution of Beam SQL while io-hcatalog is provided, which makes it confusing. As you suggested, moving the new hive/hadoop-related logic to io-hcatalog would probably be the best. I think ultimately everything related to reading rows and schema lookups should belong to IOs and should be transparent to SQL. SQL should accept a PCollection of any element type which can transparently be converted to rows. From dependencies perspective everything related to the IO will have the same dependencies and IO package can shadow and relocated everything it needs.
E.g. in case of this PR I think I will need to create an adapter for IHiveMestastoreClient in io-hcatalog that will be used for schema-lookups only and won't expose any hive/hadoop classes. Does this make sense?
Not sure what to do with test utilities though, will probably need to move them from test to main for now so that I can depend on them here without creating a separate test module.

@akedin completely agree, sounds great!

run sql postcommit

run sql postcommit

run java postcommit

@kanterov please take a look. Moved the Hive logic to io-hcatalog, exposed some dependencies, seems to work this way. I don't like how it's integrated with HCatalogIO but don't want to refactor the IO at the moment

Awesome start to integrate external metadata store. I would prefer a more broad discussion on that, and hopefully I'm not too late in this thread.
Back to #4041 which introduced the concept MetaStore and TableProvider, I think it's time to decouple the two on code/interface level, that BeamCalciteSchema --call--> MetaStore --call--> TableProvider. The role for each is:

MetaStore is a route only to invoke each TableProvider, and different implementation may decide how to persistent for session-restore;
TableProvider decides how to CRUD a table for particular storage;

In this way, there's one HCatalogProvider to interact with HCatalog similarly. Some questions would come, surely they may be out-of-scope, like

do we really want to load all table in HCatalog at the beginning? If not, how to load it during runtime;
table name duplication is very likely now;
when CREATE/DELETE a table, does it really happens in HCatalog, or only in MetaStore;
...

@XuMingmin  table name duplication is solved by the design in #7491: multiple schema support.
So we support multiple schema in BeamSQL, each schema maps to an instance of table provider. Within a table provider, duplication of table names is not allowed. Duplicates of names are allowed cross schema. You can think one schema is an instance of a metastore. Usually, an instance of metastore does not allow duplicate entry names (like Hive metastore).

@XuMingmin I agree, we should split the interfaces. Until this point there wasn't a concrete example in Beam codebase to reason about it though. I want to get something working in first to make sure all details work end-to-end so that we don't have to do a lot of functional changes for the next refactoring.

all tables are not loaded upfront anymore, I disabled schema caching in #7553. Now the table providers are queried only when the table is parsed. Caching and greedy schema loading doesn't seem to make sense in Beam context;

in this PR tables are looked up in the metastore, there should be no way to hit table name conflicts;

I didn't add support for CREATE/UPDATE in this PR, I think that it will be straightforward to hook them up however we like after look ups are done. My understanding is that HCatalog is built on top of Metastore, and is often conflated and considered the same thing. And creating a table in one would create a table in another. I may have misunderstood something though

run java precommit

run java precommit

Thanks to mention these important features, I lost track on the PRs. If my understand is right, this may be one option to go with:

still implement external metadata store as TableProvider;
MetaStore as a dispatcher only, not subclass of TableProvider;
register multiple schema on-demand for different external metadata stores;

This PR LGTM, let's have these ideas in a later one.

@kanterov I am planning to merge this today or tomorrow. Please take a look if you have a chance. Otherwise I can address further concerns in follow-up PRs

@akedin overall, the code looks good, and we can iterate from there. Agree with @XuMingmin, regarding paying extra attention to how we integrate with CalciteSchema. Something I want to bring up on dev@ is supporting VIEWs in Beam SQL. While Calcite itself supports views, we don't expose any APIs today, and I believe it would be a useful feature to have.
One side note, I'm not completely sure that Beam and Hive use the same types for different kinds of columns. For instance, in Hive nested structs are represented as List<Object>, while in Beam it's Row type. We can get extra confidence if there would be tests for complex schemas.

Yes, views would probably be a nice thing to have. Not sure what semantics would be though, definitely worth a discussion (on a slightly related note, the original Dataflow model and Flink SQL offer materialized view semantics for query results (as alternative to lateness-focused partial results calculation), with help of retractions which we don't have in Beam yet).
Row does validation of data types internally, and will break if the representation doesn't match. As of this PR there's no support for non-primitive types here yet

run sql postcommit

run sql postcommit

Merging this. Ping me if follow up is needed

It will definitely worth an announce in dev@ and user@ for this big progress :-)

@amaliujia , good point, will do


An error occurred while calling OpenAI ChatCompletion.

I got everything up and running but am running into this error. I've uninstalled and reinstalled openai and updated python but that didn't seem to help. I don't believe I'm rated limited because I can still use chatgpt.

Hey! I've updated the error message to be more descriptive. Could you pull the latest changes from the main branch and try this again? We should get more information this time.

Same error.

Same error here:
Python311\site-packages\whisper\timing.py:57: NumbaDeprecationWarning: The 'nopython' keyword argument was not supplied to the 'numba.jit' decorator. The implicit default value for this argument is currently False, but it will be changed to True in Numba 0.59.0. See https://numba.readthedocs.io/en/stable/reference/deprecation.html#deprecation-of-object-mode-fall-back-behaviour-when-using-jit for details.
@numba.jit

The "Python311\site-packages\whisper\timing.py:57: NumbaDeprecationWarning" message is just a warning and doesn't cause any issues here. With the updated error message I would like to see a screenshot of the error if anyone is still getting them.

@kirillleogky you did not follow the instructions. You need to grab your ChatGPT API key and then create a keys.py file with the line OPENAI_API_KEY = "INSERT HERE"

@mf my structure

keys.py
OPENAI_API_KEY = "sk-O3QSxAxQ6wn0000Y9ulvAT3Blbk0000000000000"

@kirillleogky Try to save the keys.py file in UTF-8. This you can do, for example, with Notepad++

Thank you It's worked!!

I can't save the file through notepad

You are saving the file in the wrong location. It should be saved inside
the project folder and it can not be in windows folder
On Fri, May 26, 2023, 8:51 a.m. nithinkrishnac @.***>
wrote:

[image: IMG-20230526-WA0044.jpg]
https://user-images.githubusercontent.com/111739864/241224104-154bc437-eda2-4059-8933-60c94461b2be.jpg
I can't save the file through notepad
—
Reply to this email directly, view it on GitHub
https://github.com/SevaSk/ecoute/issues/14#issuecomment-1564347746, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAOCOUBVYCMDN5HOCDIWTLXICRN7ANCNFSM6AAAAAAYKZNSVI
.
You are receiving this because you were mentioned.Message ID:
@.***>

How do I solve this problem?
On Fri, 26 May, 2023, 6:23 pm Michael Firsikov, @.***>
wrote:

You are saving the file in the wrong location. It should be saved inside
the project folder and it can not be in windows folder
On Fri, May 26, 2023, 8:51 a.m. nithinkrishnac @.***>
wrote:

[image: IMG-20230526-WA0044.jpg]
<
https://user-images.githubusercontent.com/111739864/241224104-154bc437-eda2-4059-8933-60c94461b2be.jpg
I can't save the file through notepad
—
Reply to this email directly, view it on GitHub
https://github.com/SevaSk/ecoute/issues/14#issuecomment-1564347746, or
unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AAAOCOUBVYCMDN5HOCDIWTLXICRN7ANCNFSM6AAAAAAYKZNSVI
.
You are receiving this because you were mentioned.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
https://github.com/SevaSk/ecoute/issues/14#issuecomment-1564349970, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/A2UQHWAQJVT52MMPXYXK7W3XICRUXANCNFSM6AAAAAAYKZNSVI
.
You are receiving this because you commented.Message ID:
@.***>

How to solve this issue

can not see any windows after run the main.py. with log below: D:\huanglei\ecoute\ecoute>python main.py C:\Users\Administrator\AppData\Local\Programs\Python\Python310\lib\site-packages\whisper\timing.py:58: NumbaDeprecationWarning: The 'nopython' keyword argument was not supplied to the 'numba.jit' decorator. The implicit default value for this argument is currently False, but it will be changed to True in Numba 0.59.0. See https://numba.readthedocs.io/en/stable/reference/deprecation.html#deprecation-of-object-mode-fall-back-behaviour-when-using-jit for details. def backtrace(trace: np.ndarray): [INFO] Adjusting for ambient noise from Default Mic. Please make some noise from the Default Mic... [INFO] Completed ambient noise adjustment for Default Mic. [INFO] Adjusting for ambient noise from Default Speaker. Please make or play some noise from the Default Speaker...

Where you playing some noise from the default speaker? It should continue to initialize after it hears some noise. If you where check what is set as the default speaker and make sure it makes to what you are listening too.

can not see any windows after run the main.py. with log below: D:\huanglei\ecoute\ecoute>python main.py C:\Users\Administrator\AppData\Local\Programs\Python\Python310\lib\site-packages\whisper\timing.py:58: NumbaDeprecationWarning: The 'nopython' keyword argument was not supplied to the 'numba.jit' decorator. The implicit default value for this argument is currently False, but it will be changed to True in Numba 0.59.0. See https://numba.readthedocs.io/en/stable/reference/deprecation.html#deprecation-of-object-mode-fall-back-behaviour-when-using-jit for details. def backtrace(trace: np.ndarray): [INFO] Adjusting for ambient noise from Default Mic. Please make some noise from the Default Mic... [INFO] Completed ambient noise adjustment for Default Mic. [INFO] Adjusting for ambient noise from Default Speaker. Please make or play some noise from the Default Speaker...

Where you playing some noise from the default speaker? It should continue to initialize after it hears some noise. If you where check what is set as the default speaker and make sure it makes to what you are listening too.

No, I can not hear any noise. it just stop without any log.

When I run main.py，there comes a error named “Error communicating with OpenAI: HTTPSConnectionPool(host='api.openai.com', port=443): Max retries exceeded with url: /v1/audio/transcriptions (Caused by ProxyError('Unable to connect to proxy', SSLError(SSLEOFError(8, 'EOF occurred in violation of protocol (_ssl.c:1125)'))))”，would mind helping me？

When I run main.py，there comes a error named “Error communicating with OpenAI: HTTPSConnectionPool(host='api.openai.com', port=443): Max retries exceeded with url: /v1/audio/transcriptions (Caused by ProxyError('Unable to connect to proxy', SSLError(SSLEOFError(8, 'EOF occurred in violation of protocol (_ssl.c:1125)'))))”，would mind helping me？

"Hello, I have encountered the same problem. Have you solved it?"

@1379584933 check


[Serializable] Classes

In Lucene.Net 3.0.3 several classes were marked with the [Serializable] attribute. The same has been done to several of the classes in the Lucene.Net (core), but most of the classes in the sub-projects are still not serializable.
Some of the legacy tests that were carried over required certain classes to be serializable (LUCENENET-170 and LUCENENET-338), which is how this issue was first discovered.
At the very least, all Queries, Filters, and Analyzers should be marked [Serializable], but it is unclear what criteria version 3.0.3 used to determine which other classes should be serializable. We need a clear strategy for this as well as the task to be done.
JIRA link - [LUCENENET-574] created by nightowl888

This was posted on the Lucene dev list today:
Serializatio/Deserialization of Lucene objects like queries, sort fields etc
This seems to back up my previous statement about removing serialization from Lucene.NET classes, since that is the direction that Lucene has gone, as well.


Request thousands of KUBECONFIG at same time

According to the description here, dynamical KUBECONFIG could be generated via
expiration := 10 * time.Minute
expirationSeconds := int64(expiration.Seconds())
adminKubeconfigRequest := &authenticationv1alpha1.AdminKubeconfigRequest{
  Spec: authenticationv1alpha1.AdminKubeconfigRequestSpec{
    ExpirationSeconds: &expirationSeconds,
  },
}
err := client.SubResource("adminkubeconfig").Create(ctx, shoot, adminKubeconfigRequest)
if err != nil {
  return err
}
config = adminKubeconfigRequest.Status.Kubeconfig

My question is that is there any rate limit here ? Assume that we have thousands of clusters need to rotate kubeconfig at a same time, is gardener able to suffer that workload in a short time ? We don't expect any error caused by having so many creating request. Just confirm if gardener could suffer the workload.
Thanks in advance.

I don't think we can provide a reasonable answer since this depends on many aspects related to the respective Gardener installation, for example configuration of API priority and fairness, the number of gardener-apiserver replicas, their resource requirements, the configured auto-scaling, etc.
Generally, the generation of an admin kubeconfig is somewhat CPU-intensive since it generates a client certificate, so doing this a lot of times in parallel will definitely increase the CPU consumption of the API server pods. However, with the "right tuning" of the Gardener system, all this should certainly be possible.
I'm closing this issue since I don't think there is anything concrete to follow-up with. Feel free to join our Slack channel as well for further questions :)
/close


this engine made me become a fa##ot

Describe your bug here.
help when i played universe engine i became a fa##ot and i cant stop!!!!!!!!!!
Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build?


Enhance Configuration, Documentation, and Script Functionality

[ ] Add a single file for configuring all requirements.
[ ] Update documentation.rst to be more comprehensive.
[ ] Resolve issue in zephyr_build_run_sim.sh
[ ] Add a contributing guide

The issues in zephyr_build_run_sim.sh could be related to setting up the zeth network interface via net-setup. If the setup worked you should see the zeth if with ip a
17: zeth: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc fq_codel state DOWN group default qlen 1000
    link/ether 00:00:5e:00:53:ff brd ff:ff:ff:ff:ff:ff
    inet <IP_ADDRESS>/24 scope global zeth
       valid_lft forever preferred_lft forever
    inet6 2001:db8::2/128 scope global nodad
       valid_lft forever preferred_lft forever
    inet6 fe80::200:5eff:fe00:53ff/64 scope link proto kernel_ll
       valid_lft forever preferred_lft forever

Closed #22 and #23. Will create a single PR with all the changes, which when merged will automatically accomplish what the individual PRs were doing 👍


Closed window with open folder/project keeps getting brought back over untitled empty window

Check for existing issues

[X] Completed

Describe the bug / provide steps to reproduce it

Open a folder in current window
Close current window
Open a new empty window
Quit & re-launch Zed

Expectation: Zed will restore the lastly opened window, aka the empty window
Actual: Zed brings back the closed window with open folder/project
Also, just for your information, I changed the "default_dock_anchor" setting to "bottom" during this, but the re-opened window with folder/project still preserves the old setting showing the dock on the right. If I open a new empty window it's the correct setting, but due to the behavior described above, quitting and re-launching gives me the old window stuck with old settings again.
Environment
Zed: v0.75.2 (stable)
OS: macOS 13.2.1
Memory: 16 GiB
Architecture: aarch64
If applicable, add mockups / screenshots to help explain present your vision of the feature
No response
If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.
If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.
No response

Yeah, I was also trying to find out how to remove the project and restore the empty window on startup and couldn't figure out how


Composer service in docker-compose.yml causing problems.

Hi,
I just want to inform, that placing composer service is not a good idea if you recommend to run the project via docker-compose up. It'll make both containers run, and files in vendor will be duplicated and we'll have warnings like this:
Warning: Ambiguous class resolution, "PharIo\Manifest\BundlesElement" was found in both "/opt/php/vendor/phar-io/manifest/src/xml/BundlesElement.php" and "/opt/php/vendor/phar-io/manifest/src/src/xml/BundlesElement.php", the first will be used.
It'll only happen when running it 1st time.
I'm not making a PR, because I'm not sure what the solution should be.
Easiest approaches:

In documentation just recommend to run project via docker-compose up php
Just remove composer service, and recommend to run it via docker run --rm. This might be good idea, since sometimes tty/interactive might be needed. Also current composer implementation in docker-compose.yml is not passing ssh-agent into container (https://hub.docker.com/_/composer/)

There is a hack also:
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- docker-compose.yml	(revision e68d7b213ee1b88ffbca05420cd52eaf6df9b8b9)
+++ docker-compose.yml	(date<PHONE_NUMBER>000)
@@ -12,5 +12,4 @@
     working_dir: /app
     volumes:
        - .:/app
-    command:
-      - install
+    command: 'true'

This will make composer service to return 0 immediately, so it'll not make duplicates in vendor.
But still - I'm not sure, if docker-compose should contain services which does nothing on docker-compose up
Other way is to have separate docker-compose.yml files for those services, but then it will be harder to execute them eg: docker-compose -f docker-compose.composer.yml run composer install
Unfortunately docker-compose doesn't provide a way to wait until other container finish. There is potential hack - remove composer part from test_runner.sh and then add composer service in depends_on, and in test_runner.sh ping composer service until it's down and then proceed.

I can confirm that I ran into this same issue when I tried running docker-compose up

9910fdf1118216d7cdb9bf15611c337f2900ce43 should solve this issue. There is only one service in docker-compose.yml that runs Composer, cs and test via make now, so everything can be run using make (Sphinx build for readthedocs documentation is build using make, too).


Error when read JWST x1dints

I got the error when trying to read STSci JWST x1dints file
---------------------------------------------------------------------------
IndexError                                Traceback (most recent call last)
Cell In[2], line 1
----> 1 ltt1445_st1_x1dints = read_rainbow('/Users/pawa3371/Work/LTT1445_miri/data/visit1/x1dints/*.fits',format='x1dints')

File ~/Work/chromatic/chromatic/rainbows/__init__.py:29, in read_rainbow(filepath, **kw)
      8 def read_rainbow(filepath, **kw):
      9     """
     10     A friendly wrapper to load time-series spectra and/or
     11     multiwavelength light curves into a `chromatic` Rainbow
   (...)
     27         The loaded data!
     28     """
---> 29     r = Rainbow(filepath, **kw)
     30     if "model" in r.fluxlike:
     31         return RainbowWithModel(**r._get_core_dictionaries())

File ~/Work/chromatic/chromatic/rainbows/rainbow.py:227, in Rainbow.__init__(self, filepath, format, wavelength, time, flux, uncertainty, wavelike, timelike, fluxlike, metadata, name, **kw)
    225 # then try to initialize from a file
    226 elif isinstance(filepath, str) or isinstance(filepath, list):
--> 227     self._initialize_from_file(filepath=filepath, format=format, **kw)
    229 # finally, tidy up by guessing the scales
    230 self._guess_wscale()

File ~/Work/chromatic/chromatic/rainbows/rainbow.py:463, in Rainbow._initialize_from_file(self, filepath, format, **kw)
    461 # pick the appropriate reader
    462 reader = guess_reader(filepath=filepath, format=format)
--> 463 reader(self, filepath, **kw)
    465 # validate that something reasonable got populated
    466 self._validate_core_dictionaries()

File ~/Work/chromatic/chromatic/rainbows/readers/x1dints.py:353, in from_x1dints(rainbow, filepath, order, **kw)
    350         current_time_index = hdu[e].header["int_num"] - 1
    352     # store in the appropriate column of fluxlike array
--> 353     rainbow.fluxlike[c][:, current_time_index] = (
    354         hdu[e].data[c] * column_units[c] * 1
    355     )
    357 # increment the running integration total
    358 integration_counter += 1

File ~/miniforge3/envs/chromatic_fitting_new/lib/python3.10/site-packages/astropy/units/quantity.py:1323, in Quantity.__setitem__(self, i, value)
   1321 if not self.isscalar and "info" in self.__dict__:
   1322     self.info.adjust_indices(i, value, len(self))
-> 1323 self.view(np.ndarray).__setitem__(i, self._to_own_unit(value))

IndexError: index 20235 is out of bounds for axis 1 with size 20235

This is a link to my files here
I'm using
python version 3.10.8
chromatic version 0.4.11

On it this weekend!

OK, I see the same error as you! It looks like the problem is that we're missing one of the segments in the middle, with no *seg006* appearing in the list below.
jw02708001001_04103_00001-seg001_mirimage_x1dints.fits
jw02708001001_04103_00001-seg002_mirimage_x1dints.fits
jw02708001001_04103_00001-seg003_mirimage_x1dints.fits
jw02708001001_04103_00001-seg004_mirimage_x1dints.fits
jw02708001001_04103_00001-seg005_mirimage_x1dints.fits
jw02708001001_04103_00001-seg007_mirimage_x1dints.fits
jw02708001001_04103_00001-seg008_mirimage_x1dints.fits
jw02708001001_04103_00001-seg009_mirimage_x1dints.fits

Plotting the integration indices being populated while reading, there's a big jump, presumably right at that segment, where the integration number we're inferring for each individual integration is suddenly higher than the index of the arrays being populated:

I'll try it again using the complete set of files, but I'll also fix this so it at least throws a more informative error, to make this less baffling.

OK, yes, it works fine with all 9 files actually there. I downloaded them all fresh and loaded them with:
from astroquery.mast import Observations

for i in np.arange(1, 10):
    x = Observations.download_file(f"mast:JWST/product/jw02708001001_04103_00001-seg00{i}_mirimage_x1dints.fits");

r = read_rainbow("*x1dints.fits")

But, I also updated it so that it should do an OK job loading in the segments that are available, even if there are gaps. For example, now if I give read_rainbow segments 1 and 3, it looks like this:

(The fix to make it be able to load only some of the segments was to now more carefully use the integration_number populated in the int_times extension to be able to match up integrations to arrays, even if the array is smaller than the true number of integrations in the exposure, because some data aren't being loaded.)

OK, @Pat-Wachiraphan , I think this is done. It should warn us now if we're not loading all the segment files that we should. I'll send you a link what I loaded too, just for simplicity.


Remove assumed unused image

Docs Build status updates of commit ffc3026:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/images/module3chapter1step12im.PNG
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Ingest parquet: Change behavior when ingesting columns of invalid type

TL;DR: There is an inconsistency in Pinot when a table defines a column as a string but it is populated reading a parquet file whose column type is binary without the string annotation.
Introduction:
I'm trying to improve the current Pinot implementation of ClickHouse/ClickBench. In that benchmark the input data can be read from csvs, tsvs, json or parquet files. As usual, Pinot requires to split the data before ingesting. The current implementation imports data from a tsv, but it seems easier and faster to import from parquet. Even better, ClickHouse already provides the data split in 100 parquet files. But the metadata on the parquet file is not correct (link to the issue). String columns are marked as binaries without String annotation.
The problem:
When Pinot tries to populate a String column from a parquet file, it reads the values from the parquet files, applies some conversions that return an Object and applies a stringify conversion to that Object (ie calling Object.toString). But the value that is read from parquet depends on the metadata associated with the parquet column. In parquet String columns are Binary columns with an annotation that marks them as a String. Other annotations can be applied to mark the binary column as an enum or UUID.
Pinot uses these annotations to decide how to read the value, without knowing the type of the Pinot column where the data will be stored. The code that does that is here. In case the binary column is not annotated with the String annotation, it is read as a binary (there some other variants but they are not important in this discussion). When the value is read as a String, the Java type will be String. When the value is read as a binary, the Java type will be byte[].
Once the value is extracted, Pinot stringifies the value before storing it. If the value was String, this conversion is a noop. But if the value wasn't marked as String in parquet, the extracted value is a byte[] and therefore the conversion returns a description of the bytes. I didn't find where the conversion is applied, but the result is that Pinot stores a String that is not the bytes read as UTF-8.
This is problematic because there is no clear indicator that the import is going to change the data and there is no failure. The user may think that everything is ok and after ingesting terabytes of data he/she may discover that the data stored is not the same that the one he/she wanted to store.
The same problem may also be applied to other input formats and other column types, but I didn't try it.
Proposed solutions:

Add some checks to the import process that verifies that the extracted Java types matches with the expected column type. In this case this would produce a fail fast error that should be clear to the user, which can take proper adjustments (like adding the corresponding annotation to parquet).
Add a property to org.apache.pinot.plugin.inputformat.parquet.ParquetRecordReaderConfig that let the user to customize how columns should be read.

IMO the error should be mandatory and the ability to cast the columns should be optional.

Currently we convert BYTES to hex-encoded string if the storage type is string. This is done in PinotDataType.BYTES.toString().
We may consider adding a flag to only allow number conversion (IMO conversion between different number types should be allowed)


My profile is found but incorrect

Hi,
My profile is found and I'm located in the United States (???) while my profile says I'm in Paris. So I have no data on it.

Hi, i added an update button in the profil page, can you try to refresh ?

Thanks, it's working now ! Only one problem remains: it doesn't find my city (which is filled as Paris on github). Otherwise, everything's fine !

Google geocoding may take a few second to run (more if your refresh is in queue behind others)
When i go to your profile you're listed in Paris, i think it's ok.

Perfect then ! Thanks again for fixing it.


refactor rust code

marking as draft until #674 is merged

@sestinj any blockers to getting this merged?

Thank you again for doing this! My Rust was...rusty


Slim project build without Bitters and Neat

I used Proteus for the first time on the Tropos iOS landing page. I find Bitters + Neat really heavy for most cases. It would be great to create a new project with Proteus and get deploy, live reload, sass, haml, etc But leave out Bitters and Neat.
I would be open to helping out in this. I havent taken a look at the source yet.

We may eventually want a new command that can support options like this, but for now I included a page in the new wiki: https://github.com/thoughtbot/proteus-middleman/wiki/Removing-the-Bourbon-Suite
The other Proteus projects have a lot more included, but Middleman basically comes with your setup by default (just need to add Live Reload), which is one reason I like it so much.
Closing this issue, but I'm adding a new one to determine how best to do install options.


fix typo and positioning

Updated Figure 1 as discussed.  I am currently running through the make.sra on axiom at the moment and it should be done by the end of the day.  I'll let you know when I have an SRA accession number.
Marc

Hey Pat
The data from the Schubert study is now available on the SRA.  The accession number is SRP078489.  You are the assigned owner of the data.

thanks


header inconsistencies

minio-go sends Accept-Encoding: gzip
is the correct behavior?
minio-go does not print response headers for PUT DELETE

minio-go sends Accept-Encoding: gzip

        // DisableCompression, if true, prevents the Transport from
        // requesting compression with an "Accept-Encoding: gzip"
        // request header when the Request contains no existing
        // Accept-Encoding value. If the Transport requests gzip on
        // its own and gets a gzipped response, it's transparently
        // decoded in the Response.Body. However, if the user
        // explicitly requested gzip it is not automatically
        // uncompressed.
        DisableCompression bool

https://github.com/golang/go/issues/13942 , https://go-review.googlesource.com/#/c/18624/ - here is the fix for other issues.


Push contracts lazily on create and upgrade

The idea would be to only push those contracts that must be pushed to perform an instance creation.
At this moment, if the user wants to create an instance of an openzeppelin-eth/ERC20 and has some local contracts added, running zos create will push them all, which is not necessary. Also, if the user has some contracts added to the project (let's say, contract A and B) and they run zos create C, it will not only push C but also A and B which is also not necessary.

Closing in favour of #1250


update to 1.0.1

Why?
To update to 1.0.1 release
Changes

update version in project and podspec
last tag version had a warning in podspec validation

Issue

Pull Request Test Coverage Report for Build 79

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 90.797%

Totals

Change from base Build 76:
0.0%

Covered Lines:
957

Relevant Lines:
1054

💛  - Coveralls


v1.7 backports 2020-07-22

#12440 -- Fix small CRD issue with toGroups (@lbernail)
#12517 -- Adds documentation for limiting identity-relevant labels used when evaluating Cilium Identities (@seanmwinn)

Backport notes:
#12440 -- ./pkg/apis/cilium.io/v2/client/register.go is here ./pkg/apis/cilium.io/v2/register.go otherwise applied cleanly
#12517 -- concepts/scalability/index.rst does not exist so I put the identity-relevant-labels.rst in the getting started index
Once this PR is merged, you can update the PR labels via:
$ for pr in 12440 12517; do contrib/backporting/set-labels.py $pr done 1.7; done

test-backport-1.7

@seanmwinn Since your PR https://github.com/cilium/cilium/pull/12517 has been marked for 1.6 and 1.7 backport, please review the doc change, as the doc structure has changed since 1.6/1.7.

Labels for the two PRs had not been updated. I just updated them.

test-backport-1.7

test-backport-1.7


[NSFW] arizona-golf-vacations.com

Porn site with adware/malware/scam links. Mostly mix of pics leaked celebrities, OF etc.
Some sites links already blocked via OISD.NL like hxxps://spiuft.com/porno-land?<url-hash>
Against NSFW content I will not provide screenshot this time.

Thank you Tomasz @FadeMind.  Merging.


kubeconfig: Add /cluster suffix to the user AuthInfos entries

Looking at .kube/config, I noticed that entries for other clusters look like:
contexts:
- context:
    cluster: api-ci-xxx:6443
    namespace: origin
    user: cfergeau/api-ci-xxx:6443
  name: origin/api-ci-xxx:6443/cfergeau
users:
- name: cfergeau/api-ci-xxx:6443
  user:
    token: sha256~yyy

By contrast, the entries added by crc are:
contexts:
- context:
    cluster: api-crc-testing:6443
    namespace: default
    user: kubeadmin
  name: crc-admin
- context:
    cluster: api-crc-testing:6443
    namespace: default
    user: developer
  name: crc-developer
users:
- name: developer
  user:
    token: sha256~yyy
- name: kubeadmin
  user:
    token: sha256~zzz

Changing the user names to developer/api-crc-testing:6443 and kubeadmin/api-crc-testing:6443 would make them less ambiguous.

I think it is just the tooling side when you use oc login it does add /cluster suffix as part of name but if you create plain k8s cluster (like using kind/minikube/rancher) it doesn't have that suffix. So if a user using multiple cluster it is not ambiguous.
oc config get-contexts -o name
default/api-j9uzu-y6fxu-668-ki63-p3-openshiftapps-com:443/cluster-admin
default/api-mofrw-ucwdu-x9d-arwe-p3-openshiftapps-com:443/cluster-admin
dev-sandbox-context
kind-kind
kind-kind-cluster
microshift
openshift-dns/api-dzcvb-gyo7k-boc-t9mj-p3-openshiftapps-com:443/cluster-admin
prkumar-dev/api-sandbox-m2-ll9k-p1-openshiftapps-com:6443/prkumar
rancher-desktop

I'm not talking about the context names, which have a crc- prefix in our case, but about the AUTHINFO column in oc config get-contexts output. I don't know how these are named in other clusters, but looking at ~/.kube/config I don't see how this can work without collisions if there is no namespacing at all.

tried adding duplicate entries by hand in the users list and when it has duplicate entries, oc errors out with the following error:
error: error loading config file "/Users/anath/.kube/config": error converting *[]NamedAuthInfo into *map[string]*api.AuthInfo: duplicate name "user" in list:

looking at the code on crc for updating the kubeconfig file, i.e mergConfigfor microshift and writeKubeConfig for ocp it'd be simpler to update the kubeconfig file on snc during the createdisk phase than making changes to the file during crc start

tried adding duplicate entries by hand in the users list and when it has duplicate entries, oc errors out with the following error:
error: error loading config file "/Users/anath/.kube/config": error converting *[]NamedAuthInfo into *map[string]*api.AuthInfo: duplicate name "user" in list:

looking at the code on crc for updating the kubeconfig file, i.e mergConfigfor microshift and writeKubeConfig for ocp it'd be simpler to update the kubeconfig file on snc during the createdisk phase than making changes to the file during crc start

Ah sure if it's simpler to improve this in snc, this works too!

looking at this again, it seems only the ocp bundle has a kubeconfig file, while the microshift preset the bundle has an empty kubeconfig, the kubeconfig file is copied from the VM by crc after crc start, so we have to modify it from crc itself, i've opened #4020 for this

while the microshift preset [...] the kubeconfig file is copied from the VM by crc

And the kubeconfig file created in the VM does not have suffixes?

I am not sure why we are pushing it because context is how oc/kubectl or any component which communicate to the cluster and according to doc https://kubernetes.io/docs/reference/config-api/kubeconfig.v1/#Context it is tuple of cluster endpoint, user and namespace so having the collision is rare until user manually edit the kubeconfig file and put same user entry for the cluster, or I am missing something here. It has been more than 1 year since we are added this and didn't receive any issue around the collision.

This is not about the context section, this is about the users section, which is outside of contexts
See also https://github.com/crc-org/crc/issues/3940#issuecomment-1845104910

Yes I am referring to user section which is consumed by context not directly consumed by client. Also if we really want to have it in sync than I only want to update the user which we add not the whole kubeconfig file which is updated by different tools which is what #4020 is doing.

https://github.com/crc-org/crc/compare/main...praveenkumar:crc:issue_3920

Yes I am referring to user section which is consumed by context not directly consumed by client.

With non-suffixed/namespaced usernames (and this is what crc is doing at the moment), this breaks easily:
contexts:
- context:
    cluster: api-crc-testing:6443
    namespace: default
    user: kubeadmin
  name: crc-admin
- context:
    cluster: api-example-com:6443
    namespace: default
    user: kubeadmin
  name: example-cluster
users:
- name: kubeadmin
  user:
    token: sha256~zzz

With non-suffixed/namespaced usernames

I don't think usernames are namespace suffix even https://github.com/crc-org/crc/issues/3940#issue-2028316040 I see username is prefix by apiserver so I am not sure where the namespace comes (in context field I agree it has namespace detail but not on the user side).

this breaks easily, my 2 clusters will try to use the same token:

Is this example-cluster context created manually or done by some tool?

Is this example-cluster context created manually or done by some tool?

I created it manually. Usernames created by other tools had the form name: cfergeau/api-ci-xxx:6443 as in the first post, hence the suggestion to do the same for crc.

while the microshift preset [...] the kubeconfig file is copied from the VM by crc

And the kubeconfig file created in the VM does not have suffixes?

yeah, that doesn't have suffixes

I only want to update the user which we add not the whole kubeconfig file

Yes we only need to change kubeadmin and developer to kubeadmin/api-crc-testing:6443 and developer/api-crc-testing:6443 in the section specific to crc, we don't need to touch preexisting entries.

while the microshift preset [...] the kubeconfig file is copied from the VM by crc

And the kubeconfig file created in the VM does not have suffixes?

yeah, that doesn't have suffixes

kubeconfig created in the VM is created by openshift-installer and it only have system-admin right and we don't use this kubeconfig for user context. For user context we create kubeadmin and developer user and update it.

Yes I am referring to user section which is consumed by context not directly consumed by client. Also if we really want to have it in sync than I only want to update the user which we add not the whole kubeconfig file which is updated by different tools which is what #4020 is doing.
* [main...praveenkumar:crc:issue_3920](https://github.com/crc-org/crc/compare/main...praveenkumar:crc:issue_3920)

if there are duplicate entries in the users section like below, it throws the error in https://github.com/crc-org/crc/issues/3940#issuecomment-1923594216
users:
- name: kubeadmin
  user:
    token: sha256~zzz
- name: kubeadmin
  user:
    token: sha256~zzz

i got that error by modifying the kubeconfig by hand, but if a kubeadmin user already existed and we wanted to add a new one, we'd overwrite the old one plus kubeadmin, developer are common names

i got that error by modifying the kubeconfig by hand, but if a kubeadmin user already existed and we wanted to add a new one, we'd overwrite the old one plus kubeadmin, developer are common names

But this entry is not created by us, so I don't want to touch existing entry and only have our crc specific entry and in that case this PR will have it kubeadmin/api-crc-testing:6443 so it will not override old one which have no details about the cluster.

while the microshift preset [...] the kubeconfig file is copied from the VM by crc

And the kubeconfig file created in the VM does not have suffixes?

yeah, that doesn't have suffixes

kubeconfig created in the VM is created by openshift-installer and it only have system-admin right and we don't use this kubeconfig for user context. For user context we create kubeadmin and developer user and update it.

right, the steps being for openshift preset are:

the clusters section from the kubeconfig in bundle is added to the global kubeconfig
then token for kubeadmin and developer are requested using the system-admin user's certs
then AuthInfo for the two users (kubeadmin, developer) and Contexts are added to the global kubeconfig (in the addContext func)


Commands not registered?

Hi,
I am using your plugin. It's great. Exactly the thing I need and very lightweight.
I don't know, if it is an error or if it is by purpose: Not all serialized commands are inserted into the register file. The cXXXXX files should be in the register file?!
-rw-r--r--+ 1 httpd httpd  14K  6. Nov 15:07 ba030de4-848f-11e5-9aff-4b9f234306c3
-rw-r--r--+ 1 httpd httpd  14K  6. Nov 15:07 ba0390d4-848f-11e5-991c-c409c2195d3d
-rw-r--r--+ 1 httpd httpd  179  6. Nov 15:01 cfc32e12-848e-11e5-967f-e34c4e614c26
-rw-r--r--+ 1 httpd httpd  182  6. Nov 15:01 cfc3bfd0-848e-11e5-9911-ead199f82018

a:2:{s:36:"ba030de4-848f-11e5-9aff-4b9f234306c3";i:1446822454;s:36:"ba0390d4-848f-11e5-991c-c409c2195d3d";i:1446883654;}

Good to hear the plugin helps you!
That sounds like an error. Could you post the contents of the files? If there's sensitive information in there feel free to replace that by XXXXXX or mask it otherwise.

I should unserialize() them then? Viewing them in any editor make them look like a binary.

I can only think of two situations where this could happen, either the register file didn't update when scheduling or the commands weren't removed from the disk after execution. I thought maybe the timestamp in the files could indicate which is the case.
Best would be of you had some method of reproducing this, perhaps a small script?

The Project is not that small, I don't know where this happened. I will look into this. Unserializing them would be a great help.
I might change to MongoDB either way. Seems more transparent and reproducable to me.

Yes, I think something broke when scheduling because of the serialization. Serialization can be tricky sometimes, maybe there are closures somewhere?
Mongo also serializes, I thinking about a way to reduce the dependency on the serialize function because it makes it hard to see what's happening. I also found that mongo is unable to query serialized data due to null characters. Still I think mongo works a bit better than files. Especially in a distributed environment.
I think your best bet is to implement serialization in your command to make sure the result makes sense. See http://php.net/manual/en/class.serializable.php
Another option you may want to consider (if you're not doing it already) is add tactician's logger middleware to your commandbus, it may give a bit more insight in what's happening.

Ok. I will give MongoDB a try first. Might be visible there were it happend. If the problem still perists, I will look into serializing commands manually. Commands are not using any closures, but some handlers do.
Calling the following will not break serialization?! Seems to work, but maybe this breaks serialization? This is inserted because I can call $commandbus->handle($command) directly without setting the timestamp each time a command should be queued.
EvaluationCommand extends AbstractScheduled....

public function __construct(Evalution $eval)
{
  $this->setTimestamp(Carbon::now()->modify('+10 second')->getTimestamp());
]

Seems to work, but may break serialization? I don't know. This command is essential in the process-logic of my application. I would have noticed if this command isn't executed at all.

Alright, let me know if you can find out what went wrong. I'll keep the issue open for another week or so.

The issue seems to be solved magically. :+1: MongoDB is the solution. Should be used as default. More transparent, more traceable, less errors.
I am going to close this one if all stays in its current state.
Thanks for you help @RonRademaker


Outputting Audit Tool parameters

For debugging purposes when things fail it would be most helpful if Audit tool could output a structured dump of its parameters - at least all the ones that determine pass or failure.
Each test has the set_params function, which could be tapped.
Originated from archive-ops#654

@TBRC-Travis  With respect to calling,  I'm going for the last option, which uses a property definition to invoke.
Because you can also add console log directives to it like:
-D DiagLevel=params,properties,stats,feature1 -D ConsoleLogAppend=true -D ConsoleLogFileName=someFileName.log
I'm also going to implement the as an extension of the current console run. Right now, the work run log is the only file that is output into the argument of the -l flag. The console and diagnostics will go into a file named AuditTest-console-yyyy-mm-dd-hh-MM-ss.txt (which will be sequenced as in the work run log, PASS-W.....). The file will be one file per run, so it will not have the specific work in its name (the parameters don't change by work)

@Travis-TBRC See the tracing and diagnostic options in the asset-manager-169 branch for what I'm going to implement.

@jimk-bdrc what's the advantage of using -D ConsoleLogFileName=someFileName.log versus just running audit-tool -v > someFileName.log?
A -v flag seems a simpler way of specifying -D DiagLevel=params,properties,stats,feature1 and the rest could be handled with redirection to an output file.  Am I missing something?

@jimk-bdrc what's the advantage of using -D ConsoleLogFileName=someFileName.log versus just running audit-tool -v > someFileName.log?

It allows audit tool to be shell independent. It also allows reporting on the command line which generated the audit tool, so that the output destination is included in the logging, like any other parameter.

A -v flag seems a simpler way of specifying -D DiagLevel=params,properties,stats,feature1 and the rest could be handled with redirection to an output file. Am I missing something?

This supports  independently specifying params, properties, stats, and the generic feature1 independently of each other, to avoid wading through verbiage.  If you just want the command line , and not, say, the complete JVM environment, you could just have that. (I added a keyword for the whole JVM, for intense debugging.)

Got it.  Makes sense.  Thanks!

Need to set up pull request automation and project automation to close.


Changes to internal-test-1 docs

WIP - please leave comments!

@gnosed feel free to use anything from this


route:cache with duplicate routes throws wrong exception

I stumbled upon this weird behavior when testing route caching. If I have a routes file containing only the following routes:
Route::get('home', 'WelcomeController@index');
Route::get('home', 'HomeController@index');
Running artisan route:cache throws exception:
exception 'Exception' with message 'Serialization of 'Closure' is not allowed' in ..\vendor\laravel\framework\src\Illuminate\Foundation\Console\RouteCacheCommand.php:95
After carefully inspecting the RouteCollection passed to the buildRouteCacheFile() function in the RouteCacheCommand.php, I see no indication that there are any closures in the collection.
I realize it's silly to define the 'home' route twice pointing to different controllers, but it seems like the wrong exception is being thrown in the above case.

RouteCollection maintains 4 arrays of routes: $routes, $allRoutes, $nameList, and $actionList. After routes #1 and #2 are created for the 'home' path, route #2 overwrites route #1 in $routes and $allRoutes. But $allRoutes, which indexes Route instances by the controller-method "action" string, still holds route #1 ($nameList remains empty since you don't have named routes in this case). This is because $allRoutes is the only array for which the two routes have different indices ('App\Http\Controllers\WelcomeController@index' !=  'App\Http\Controllers\HomeController@index').
In RouteCacheCommand::fire, the foreach loop iterates over the routes in $allRoutes, so it misses preparing route #1 for serialization.
The line unset($container) in Route::prepareForSerialization stops the attempt at serializing the application which is responsible for the exception.

Also, just saw that PR #7432 addresses this issue.


Set MSS value

Hi everyone,
I was wandering if it's possible to set MSS value for TCP streams?
Tried tcp_mss_default, but  doesn't look to have any impact.
Thank you!
Kr,
Dan

python 3.6


Update README.md

Add some more tags to my contributor depiction.
If you feel these are baseless feel free to deny.

We use all contributors bot to add it instead of manually editing the file. You could just add a comment like this below so the bot will create a separate PR and then we can close this.

@allcontributors[bot] please add @M4cs for code idea

@allcontributors[bot] please add @M4cs for bug report

@allcontributors[bot] please add @M4cs for idea bug report


InputPhone: Upgrade intl-tel-input JS

See: https://github.com/jackocnr/intl-tel-input/releases

Yeah, as soon as they figure out which countries to drop or keep 😆

I am updating but the only thing I see weird is the flags are askew?

Nevermind had to update the flags.png's.


does not support comparison of ObjectId

<EMAIL_ADDRESS>supported comparison of ObjectId values, so this example worked:
function ObjectId(value) { // primitive implementation
  return {
    toJSON: () => value
  }
}

const test1 = sift({
  $in: [ObjectId('1'), ObjectId('2')]
})

test1(ObjectId('1')) // expects to be true

In 8.x it returns false, is it expected?

This should be fixed now in 8.5.1. 🙂

@crcn no it's not fixed. Please consider this case (https://repl.it/@stalniy/sift8-error):
const object = { creator: ObjectId('1') }
const test = sift({ creator: ObjectId('1') }

test(object) // false, expects to receive true!

Please reopen the issue

@stalniy  I added a fix under 9.0.0 (basically just adding this: https://github.com/crcn/sift.js/commit/b3df40b3c69f56a019c318bf858fffb10d01573b#diff-6d186b954a58d5bb740f73d84fe39073R565). Let me know if your issue is fixed.

Everything workds good right now! Thanks for the fix @crcn


Fixed rel is valid question

Issues #129
Fixed rel is not valid question
Site's header format
<head>
<title>...</title>
</head>

Coverage remained the same at 100.0% when pulling 3da419caafcd57ccd79bd07b94928ebc692f8be8 on oneheed:Fixed_RelIsNotValid into 41bcffe92caec208baabcc192647becb84da70d1 on hexojs:master.

Fixed by #151


Are there plans to update with mbed os 5.15.3 or wait for 6.0.0?

ARM Internal Ref: IOTCLT-4213

HI @dannywahlquist
We update this application along side https://github.com/ARMmbed/mbed-cloud-client as integrated package. We plan to update to future patch release when we are ready to make next Device Management Client release. Thus we do not do just lib-updates in this repository outside of normal release cycles.
Now, Mbed OS 5.15.2 introduced backwards compatibility breakage for PSA APIs (and a bug in that implementation too), thus the next version we can use will be Mbed OS 5.15.4. We also need to fix the PSA API compatiblity for the client library at the same time.
Otherwise there is no issue with current patch versions. https://github.com/ARMmbed/mbed-cloud-client is already using Mbed OS 5.15.3 (as there is no actual PSA targets in use).

Thanks!

Closing as resolved.


Add attachment type

Summary

Checklist

[ ] If code changes were made then they have been tested.

[ ] I have updated the documentation to reflect the changes.

[ ] This PR fixes an issue.
[x] This PR adds something new (e.g. new method or parameters).
[ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
[ ] This PR is not a code change (e.g. documentation, README, ...)

Will be added to class based implementation only.


[Feature] Compare my metric against someone else's public metric in a report

Is your feature request related to a problem? Please describe.
I would like to compare the metrics of my experiment against someone else's public metrics.
For example, bmazoure has a benchmark project that shows the performance of PPO in procgen environments. When I implemented my own PPO, I want to compare my results with his results directly in a report since

his results are already tracked in W&B,
his W&B project is public and so is the results,
I don't want to re-run his experiments in my projects (could be a waste of resources).

Currently, I can do this via a bit of hack:

I can clone their report into my project
Add my project into the panel grid's run set
(IMPORTANT) de-select their run set (if I don't do this, I cannot select metrics from my own project when adding a chart)
Add a chart from my project
Compare (woohoo!)

https://user-images.githubusercontent.com/5555347/152890048-4012b322-f83e-45f0-bcdd-6891cdf8f031.mp4
Describe the solution you'd like
The process is a bit convoluted and most people probably don't know. Ideally, I should be able to add a run set from an arbitrary public project.

Hey Leslie, Thanks for the comment.

how would we account that the datasets are the same/similar for these metrics?

It's up to the user to know which datasets are used for generating those metrics.

Even though these projects are public, I'm not sure if the owners for these projects would be idea so there would have to be a mutual agreement from both parties.

Maybe it could operate like public github repositories somehow, where you could add a license to the project? That way, some wandb projects' metrics can be used freely, some require attribution, some disallows the metric being used in other projects.


Image without  tag wrapper is not responsive

.sy-slide > a > img is set to 100%. When outside an a tag, it is full-size.
Shouldn't it be .syslide > img ?

good catch, should be both!


cfstore flash-journal integration with config_system (Resubmitted)

Changes so the flash mode can be selected with config system property.
This was previously submitted in this PR:
https://github.com/mbedmicro/mbed/pull/1972
But was changed to remove inadvertent device_has LOWPOWERTIMER losses.
@ohagendorf
Please see this new PR.

much better :)

Why this is not in Target.device_has or even Target.macros???

Why did we merge this? There is clear precedent to use a device_has ASYNC_STORAGE for something that defines HAL capability where STORAGE enables the blocking functionality. Enabling behavior in multiple ways is a really bad idea. This should have also been tested against multiple toolchains and targets, not just the one it supports.
The config system pythons tests failed since targets are not expected to emit or define config: https://circleci.com/gh/ARMmbed/mbed-os/766
Reverting.

The config system pythons tests failed since targets are not expected to emit or define config: https://circleci.com/gh/ARMmbed/mbed-os/766

Actually, targets are fully expected to emit or define config, and this PR is correct in that respect. The tests failed because they wrongly used the K64F target (see #1983 for more details), but that is a problem with the config tests, not with this PR.


Xcode 13.3 - Swift 5.6

Is your feature request related to a problem? Please describe.
Xcode 13.3 ships with Swift 5.6. It seems Xcode 13.3 does not have toolchains option to change swift version to compile the project. So we are stuck with Swift 5.6 and can't downgrade to 5.5.
With Swift 5.6 project is not compiling due to dependency with ClientRuntime package :
#if swift(>=5.6)
      #error("Cannot use a version of Swift greater than available. Please create a Github issue for us to add support for the version of Swift you want to use.")

Describe the solution you'd like
Allow building with Swift 5.6
Describe alternatives you've considered
Downgrading Swift version for compilation seems not easily feasible in Xcode 13.3.
Is the feature request related to any of the existing Amplify categories?
No response
Additional context
Xcode 13.3
Swift Package Manager
branch dev-preview

Thanks for opening this issue @ryancrunchi.
A new dev preview version that fixes this was just released as 1.23.0-dev-preview.0.
You can use this version or continue using the dev-preview branch.
I'm going to close this issue now, but feel free to re-open it if you have any issues.


CHALLONGE_API_URL has changed

should be (api.py):
CHALLONGE_API_URL = "api.challonge.com/v1/"

I'm just starting to look at this code for my own use, and maybe fixing a few outstanding issues. But, it's looking as-thought this was fixed, prior to you filing this issue. Can you confirm if you think this is still an issue?

hi! I retired my use of the challenge Api about a year ago and thus can’t comment on whether or not it has been fixed.
Good luck!
Get Outlook for iOShttps://aka.ms/o0ukef

From: Russell VT<EMAIL_ADDRESS>Sent: Saturday, May 26, 2018 1:41:21 AM
To: russ-/pychallonge
Cc: Lyle Hayhurst; Author
Subject: Re: [russ-/pychallonge] CHALLONGE_API_URL has changed (#10)
I'm just starting to look at this code for my own use, and maybe fixing a few outstanding issues. But, it's looking as-thought this was fixed, prior to you filing this issue. Can you confirm if you think this is still an issue?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/russ-/pychallonge/issues/10#issuecomment-392247222, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AANMd5EnGUqsBIizqclPjftCBRu3HZgyks5t2RUxgaJpZM4H_idj.

You should likely close this request, then... I've now moved to @ZEDGR's fork, which is more-useful/current.
Looking at it, it appears you were just commenting on the description... and I've fixed it on my own fork (current with @ZEDGR's).


CONFIG_NET_SOCKETS_PACKET interferes with other network traffic (gptp, IP)

Describe the bug
I want to send Ethernet packets (AF_PACKET, SOCK_DGRAM) from a BSD socket while also running gPTP on my system, but this has proven problematic.
In trying to debug this, I have simplified my code into an empty main file where only changing one line in prj.conf is enough to trigger the issue.
Here is the content of my prj.conf file (it is very similar to the prj.conf of the gptp sample):
CONFIG_NETWORKING=y
CONFIG_NET_LOG=y
CONFIG_LOG=y
CONFIG_NET_IPV6=y
CONFIG_NET_IPV4=y
CONFIG_NET_DHCPV4=n
CONFIG_NET_UDP=y
CONFIG_NET_TCP=y
CONFIG_NET_STATISTICS=y
CONFIG_NET_STATISTICS_USER_API=y

CONFIG_TEST_RANDOM_GENERATOR=y

CONFIG_NET_PKT_RX_COUNT=32
CONFIG_NET_PKT_TX_COUNT=32
CONFIG_NET_BUF_RX_COUNT=32
CONFIG_NET_BUF_TX_COUNT=32
CONFIG_NET_IF_UNICAST_IPV6_ADDR_COUNT=5
CONFIG_NET_IF_MCAST_IPV6_ADDR_COUNT=5
CONFIG_NET_IF_UNICAST_IPV4_ADDR_COUNT=1
CONFIG_NET_MAX_CONTEXTS=10

CONFIG_INIT_STACKS=y
CONFIG_PRINTK=y
CONFIG_NET_SHELL=y

# Ethernet is needed for gPTP
CONFIG_NET_L2_ETHERNET=y

CONFIG_NET_CONFIG_NEED_IPV6=y
CONFIG_NET_CONFIG_NEED_IPV4=y
CONFIG_NET_CONFIG_SETTINGS=y

CONFIG_NET_CONFIG_MY_IPV6_ADDR="2001:db8::1"
CONFIG_NET_CONFIG_PEER_IPV6_ADDR="2001:db8::2"
CONFIG_NET_CONFIG_MY_IPV4_ADDR="<IP_ADDRESS>"
CONFIG_NET_CONFIG_PEER_IPV4_ADDR="<IP_ADDRESS>"
CONFIG_NET_CONFIG_MY_IPV4_GW="<IP_ADDRESS>"

# gPTP settings
CONFIG_NET_GPTP=y
CONFIG_NET_GPTP_STATISTICS=y
CONFIG_NET_GPTP_GM_CAPABLE=y

#CONFIG_NET_GPTP_LOG_LEVEL_DBG=y
#CONFIG_NET_SOCKETS_LOG_LEVEL_DBG=y
#CONFIG_NET_CONTEXT_LOG_LEVEL_DBG=y
#CONFIG_NET_CONN_LOG_LEVEL_DBG=y
#CONFIG_NET_IF_LOG_LEVEL_DBG=y
#CONFIG_NET_L2_ETHERNET_LOG_LEVEL_DBG=y

# How many traffic classes to enable
CONFIG_NET_TC_TX_COUNT=6
CONFIG_NET_TC_RX_COUNT=6

# Enable priority support in net_context
CONFIG_NET_CONTEXT_PRIORITY=y

With this setup, gPTP works as expected, and my system replies to pings.
Now if both of these lines are included:
CONFIG_NET_SOCKETS=y
CONFIG_NET_SOCKETS_PACKET=y

then my system answers neither gPTP requests or pings.
This is problematic because these contain the functionality I need to set up a BSD socket in my code.
It seems like a callback in the sockets code receives all the ingoing packets, instead of the modules that need them, from what I have observed so far.
To Reproduce
I am using a FRDM K64F connected directly to my computer with an ethernet cable
The code was compiled and flashed to the board using West.
The network traffic between the board and my computer was then observed in Wireshark.
I am running the gptp host on my computer as described here:
https://docs.zephyrproject.org/2.5.0/samples/net/gptp/README.html#setting-up-linux-host
Expected behavior
I expect gptp traffic and ping requests to still be handled normally after I've set my necessary socket options.
Impact
Setting the necessary options to set up an ethernet packet socket diverts other incoming network traffic.
This makes me unable to set up a socket like this while also running gPTP on my system.
Environment (please complete the following information):

OS: Ubuntu 20.04.2 LTS
Toolchain Zephyr v. 2.5.99
Platform: NXP FRDM K64F

@EinarHenriksen could you test the fix proposal at #34899 and report back if your use case works with it.
I did test the PR and everything seems to work as expected but packet socket part of the code is quite convoluted and it is difficult to see all the corner cases.

I'm testing with your code now, and in the basic example this has solved the problem for me too.
Thank you very much for the quick response :)
Though in my application where I set up a BSD socket and send ethernet packets, after a connection has been established between my linux gptp host and the gptp server on my board this warning gets printed for each incoming packet afterwards:
net_conn: pkt cloning failed, pkt <packet pointer> dropped
At this point the packets no longer reach their destination and the system behaves like earlier.
If I don't start the gptp host, I am able to ping the board.

net_conn: pkt cloning failed, pkt  dropped

This means that you run out of net_pkt, you need to increase the number of CONFIG_NET_PKT_RX_COUNT and probably CONFIG_NET_BUF_RX_COUNT too.

I revisited this today, and it seems like what is needed to trigger the buffer leak is to create a socket and to send at least two messages on the socket, while either pinging or sending gptp messages to the board.
Meaning that this triggers a buffer leak for me:
[...]
void main(void) {
        [...]
        s = zsock_socket(AF_PACKET, SOCK_DGRAM, 0x22f0);
        [...]
        zsock_sendto(s, pdu, PDU_SIZE, 0, (struct sockaddr *)&addr, sizeof(addr));
        k_sleep(K_SECONDS(10));
        zsock_sendto(s, pdu, PDU_SIZE, 0, (struct sockaddr *)&addr, sizeof(addr));
        while(1){k_sleep(K_SECONDS(10));}
        return;
}

While this does not:
[...]
void main(void) {
        [...]
        s = zsock_socket(AF_PACKET, SOCK_DGRAM, 0x22f0);
        [...]
        zsock_sendto(s, pdu, PDU_SIZE, 0, (struct sockaddr *)&addr, sizeof(addr));
        while(1){k_sleep(K_SECONDS(10));}
        return;
}

After the second message is sent, the incoming messages fill up the rx buffer.

@EinarHenriksen thanks for the info. I will investigate this.

This is actually the same case that in issue #34462 and the fix in #34475 (see the discussion there). In short, the application needs to call recv() in order to receive and "free" the received packets. If the recv is not called, the incoming packets for AF_PACKET sockets keep piling up and are never freed.

OK, so if I understand this correctly, every incoming packet gets sent to my socket, and then copied to where it is supposed to go?
And in order to avoid this buffer leak I am supposed to regularly call recv() in my application to free up the packet buffer?
Seems like a very backwards way of solving the problem, why would my socket recieve ping- and gptp-packets at all when I have explicitly declared my socket as an avtp packet socket?
I see you are talking about setting up a send-only socket in #34475, which is exactly what I am trying to do, but having to call recv() regularly in my application isn't really a satisfactory solution to that problem in my opinion.
And why does the buffer leak only start happening after I have sent two packets from my socket?

OK, so if I understand this correctly, every incoming packet gets sent to my socket, and then copied to where it is supposed to go?
And in order to avoid this buffer leak I am supposed to regularly call recv() in my application to free up the packet buffer?

Yes, that is the case atm.

Seems like a very backwards way of solving the problem, why would my socket recieve ping- and gptp-packets at all when I have explicitly declared my socket as an avtp packet socket?

Yes, there could be optimization possibilities here if you are only interested in certain type packets. But for example if the application has created ETH_P_ALL type packet socket, then it needs to call recv in order to flush the incoming socket queue because the core IP does not know atm if the application is only sending data or is listening too.

And why does the buffer leak only start happening after I have sent two packets from my socket?

I was not able to replicate the issue in your example code. I modified the packet socket sample app according to your example above and only saw the "leak" if I sent one packet, if I sent two packets, the "leak" disappeared. This could be related to my modifications to the sample app.

I see you are talking about setting up a send-only socket in #34475, which is exactly what I am trying to do, but having to call recv() regularly in my application isn't really a satisfactory solution to that problem in my opinion.

The packet socket code is a bit convoluted and would need an overhaul in order to avoid these weird issues. The code is improving all the time, it was not long time ago when after enabling packet socket, one was not able to receive normal IP packets at all. If you have good ideas how to improve the packet socket handling, or working PR would be even better, it would be great.

Then I will try using recv() as a temporary solution for now.
It seems like most of these problems would be solved by only recieving the specified protocol on a socket though.
I would very much like to know what causes the leak to stop and start when sending packets if you find out, which seems to be the only undefined behaviour/actual bug in my application right now.


Module build failed: SyntaxError: Unexpected token m

This is what I'm getting:
ERROR in ./src/components/config.json
Module build failed: SyntaxError: Unexpected token m
    at Object.parse (native)
    at Object.module.exports (/Users/me/my-project/node_modules/json-loader/index.js:7:48)
 @ ./src/components/Main.js 28:13-37

The relevant JSON file I'm trying to load:
{
  "redirectUri": "http://localhost:8000/webpack-dev-server/"
}

I'm requiring it via var Config = require('./config.json');. I had the same error when I did require('json!./config.json').
I have this in my list of loaders:
{
  test: /\.json$/,
  loader: 'json-loader!json-loader'
}

I got the same error when I moved the loader to the preLoaders section.
This is the version I'm using: "json-loader": "^0.5.4".

Looks like a duplicate of #10 that may have been fixed by #11 but 11 got closed instead of merged.

I ended up using raw-loader and loading my file like this: var Config = JSON.parse(require('components/config.json')); The following is in my loaders section:
{
  test: /\.json$/,
  loader: 'raw-loader'
}

@cheshire137 I ran into the same issue today and for me at least, it was because I wasn't escaping double quotes like
{
    "text": "This is some example \"text\""
}

I also ran into an issue with using ES6 import syntax and eslint-import-plugin, it couldn't find the default export for josn but if you use require you should be a-ok.

I ran into the same issue as well with json-loader.
@cheshire137 I also ran into this issue with raw-loader.
 var Config = require('components/config.json'));
would return module.exports = { json data } and when that was passed to JSON.parse, I got the same Unexpected token m (since the file starts with m). Not sure why just the data within the file was not returned with raw-loader.

Can confirm #11 fixes this issue...

I got the same error. Any news on this issue?
Can also confirm #11 fixes this, why didn't it get merged?

I have the same issue

Can confirm #11 fixes this issue...

Yeah, #11 fixes it for me too.

This issue occurs when applying the json-loader twice. i. e. by using configuration + require("json!. That's wrong. #11 is only a workaround, but not the solution. Fix your configuration resp. code.

Thanks @sokra ! Removing require("json! did the trick.

In case anyone is still having an issue with this loader, I got it to work by adding and extra ! to my import/require statement.
Ex: import Data from '!json!../../data';
And the loader: { test: /\.json$/, loaders: ['json-loader'] }

I fixed this issue by moving json-loader from loaders into preLoaders.

When #11 will be merged to not checkout git repo?

I think I'm having the same problem, but not sure what's causing it. My loader config is:
{
   test: /\.json$/,
   loader: 'json'
}

and then later I attempt to dynamically load some json files with:
const req = require.context('../locales', true, /\.json.*$/)
but get the "unexpected token" error. I tried moving it to preLoaders, to no avail. Finally, I tried commenting out the json loader config altogether, and voila. For some reason it works? Any idea why?

+1

https://github.com/webpack/json-loader/issues/13#issuecomment-188480384

Still can't get it to work despite trying all of the above recommendations.

Switching to fork (compact-json-loader)[#https://github.com/also/compact-json-loader] helps :)

I had to remove the "json!" and then it worked.


Supported Characters

I noticed that my upload was failing when I had a '&' in the filename.  Please add supported (or unsupported) characters to this doc.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5e266861-1776-1cd9-4c80-aeb9fc36bb50
Version Independent ID: de25db8c-55a0-5af5-d735-693215c04efe
Content: Microsoft Azure new support request File Upload utility guidelines
Content Source: articles/azure-supportability/how-to-use-file-uploader.md
Service: azure-supportability
GitHub Login: @genlin
Microsoft Alias: genli

@matthewcordaro Thank you for your feedback! We will review and provide an update as appropriate.

@genlin FYI. Could you please review this request and update as appropriate?

matthewcordaro  We will consider to add the unsupported characters. Thanks for the suggestion!

@genlin Please update this thread when have the document updated with unsupported characters.
@matthewcordaro We are closing this for now. Please feel free to re-open the issue if you've any concerns.


Feat/84593 open school application form in new tab

The code itself looks okay. I'm not that familiar with a2b-internal, but this looks like it is recreating some of the code from the original page (not the one in the new tab). Is there no where we can share some of this code rather than duplicating it? I think the way this is working, if there was a change to the form we would have to change it in two places?

In new screen , most of the code i have used , in case if i change the original code need to do more regression as existing functionality will change, in this case please suggest if you still need me to change


feat: add support for input types date, datetime-local and time

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

7 of 7 (100.0%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 99.132%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
493

Relevant Lines:
493

💛  - Coveralls


Update features model and constants

Linting converted " to '
Moved and renamed features const in youtube-new/proto/conversion.ts to youtube-new/utils/constants.ts.
Created stricter mapping between FEATURE and SEARCH_FEATURE by introducing FEATURE_BY_SEARCH_FEATURE and SEARCH_FEATURE_BY_FEATURE

thank you! 😄


Connection Issue with MariaDB and Inquiry on Connecting to Virtual Machines

Description
I am experiencing while attempting to connect to a MariaDB database using DBeaver.
Upon attempting to establish a connection, I am encountering the following error message: “unexpected end of stream, read 0 bytes from 4 (socket was closed by server).” I have verified the connection details, including the host address, port, username, and password, and all seem to be correct.
Could you please provide guidance on troubleshooting this issue? Are there specific settings or configurations that I should be aware of when connecting to a MariaDB database using DBeaver?
Additionally, I am interested in understanding whether DBeaver supports connections to databases hosted on virtual machines. I am currently attempting to connect to a MariaDB instance running on a virtual machine in Azure, and I would appreciate any insights or recommendations you may have.
Thank you for your time and assistance. I look forward to your prompt response.
DBeaver Version
23.3.3
Operating System
Windows 10
Database and driver
DB: Mariadb Ver 15.1 Distrib 10.6.16-MariaDB
Drivers: MariaDB JDBC driver
Steps to reproduce
Open DBeaver:
Launch DBeaver on your local machine.
New Connection:
In the left panel, select "Database," then choose "New Database Connection."
Connection Configuration:
Select the database you are using (In my case, I would choose MariaDB).
Enter the IP address of the virtual machine in the "Host" or "Hostname" field.
Enter the database port in the corresponding field.
Provide the name of the database.
Enter the username and password.
Connection Test:
After completing the connection details, click on the "Test Connection" button. This is where it indicates the error for me.

Additional context
No response

Hello @DavidRG25
Maybe you can find some answers here: https://github.com/dbeaver/dbeaver/issues/21812
Or here: https://forums.opensuse.org/t/dbeaver-mysql-workbence-unable-to-connect-to-remote-mysql/152497
Or here: https://github.com/dbeaver/dbeaver/issues/19388#issuecomment-1783902344

It's been a while since no update here. If the issue is still actual please let me know and provide additional information.


Setting up environment

I'm not an Android developer but would love to help in this one. I have a question how you have your environment set up. As I'm a mac user I would try to address this issue:

The current stdlib build system also assumes that the host and the target are of the same OS family, so currently only Linux hosts can target Android. Is there anything I can do to allow Mac hosts to also target Android?

It's a cool project!

You maybe should check something like android building from source. You can build it from osx so it's easy to think that it would be something similar to target Android from Swift source

You'll probably have to modify the build files to do this. I kinda understand how the Swift build system works, but you'll have better luck if you ask on the swift-dev mailing list for advice


Standalone image gallery

Type
✨ Feature
Needs

[x] Content from Content Team
First standalone gallery for CGDSYL:
https://wellcomecloud.sharepoint.com/sites/wcdigitalexperience/Shared Documents/_wellcomecollection.org - current/Editorial-Content-Storytelling/Image galleries/Graphic gallery RED 01.docx?d=w6d6db114269a4ff58c1854bb124ba5d6&csf=1

Example image gallery from previous exhibition:
https://wellcomecollection.org/articles/selection-z-objects/

[ ] New visual design
[ ] Analytics and/or component tracking

UI Requirements
Page should include:

Title
Standfirst
Author (optional)

Each image has:

Image (landscape or portrait)
Flexible length copy, not hidden
Image credit (TASL)

We may also want an image gallery promo suited to the format. Here's #667 as a start.
Problem to be solved
Current inline image gallery not suitable for use when the images are the purpose of the story.
Need to be able to include longer paragraph of text
Needs to be lovely and easy to use on mobile
Consider editorial and exhibition use
Acceptance Criteria TBD

[ ] The interface should do this thing
[ ] and this thing
[ ] and this thing.

@jennpb @pollecuttn I'm going to close this for now and create a new ticket to include new set of objectives and investigation from the dev team for early November.