a11y: 'tab' stops scrolling through Table with onRowClick

Seems like accessibility is broken in Table and maybe other components (I haven't tried).
First case: it happens if I press 'Shift-Tab' so it moves the scroll bar up as you can see on the next image. After that the last item is the last visible item, because it then switches focus to a button:

Second case if I press 'Up Arrow' key in a way that partially or fully hides focused item:

You can find this table on codepen: http://codepen.io/dattaya/full/evrYqM/

This is an unfortunate side-effect of windowing. (There are some others, such as "find in page" browser features won't work in the normal way since content isn't actually on the page.)
I'm not sure how easy this would be to fix, to be honest, nor if it belongs in the base react-virtualized library. (It could make a nice addon though.)

Thank you for the explanation, @bvaughn. I don't yet know how this library functions internally so I'm might be saying something stupid but would rendering few more rows that are not visible above and bellow help to resolve this particular issue?

That is already possible, actually. By default, react-virtualized renders 10 rows below the threshold. (Check out the overscanRowCount property.)

I've just realized that Shift-Tab doesn't work at all unless half of an element is shown even then the behavior is buggy as demonstrated above.

nor if it belongs in the base react-virtualized library (It could make a nice addon though.)

Can this be solved in an add-on or requires changes to the core?

I don't know. That sounds like built-in browser behavior, considering the next row(s) are in the DOM just not visible.

I see the problem. If you scroll down first, then use Shift+TAB to scroll back, Grid shifts the rows as described here. The result of this though is that there are no rows forward to tab to.
You could work around this by specifying a naive custom overscanIndicesGetter as shown here:
http://codepen.io/bvaughn/pen/oZyZKg
Admittedly this isn't a very satisfying default behavior though. Hm.

Thank you, @bvaughn. I've tested your example with a custom overscanIndicesGetter in most of the browsers on my PC (Chrome, Firefox, Edge, IE10-11) and it works fine. In FF one row above and bellow the threshold is not enough for speedy (when you hold the key pressed) scrolling with Tab or Shift-Tab but 2 is sufficient.
However I'm not closing this issue in case you want to make it the default behavior.

Thanks for the follow-up info!
I'm going to leave it open for now and give it some more thought. I think maybe I can improve this by default without impacting perf too much.

Default behavior has been fixed/corrected via e6656c1. It will go out with the next point release.

9.6.0 release just went out with this.


ledger init generates wrong waves address

gravity ledger init generates wrong address for node's identity on waves. In privKey.json the TargetChains.waves.Address value is not the seed's address on mainnet but some broken address.

you should provide --network parameter (either mainnet or customnet)

TIL. I used to fix it manually. Will use --network now. Thanks!


Fixes #246
Type of change

New feature (non-breaking change which adds functionality)

Checklist

[x] Unit tests and e2e tests updated
[x] Documentation updated

@seanmalloy can we globally disable the Code Coverage "target check" that "fails" for this PR? Personally I'm not convinced in value of such checks at all, but even taking that aside, the project is currently most certainly not in a state where it'd be ready for such targets yet.

As to DEVELOPMENT.md, I believe one of the commits in this PR already updates it; if there are some specific places I missed, could you help me see them?

@akavel My bad, it's been updated, just somehow I didn't see it :/

can we globally disable the Code Coverage "target check" that seems to "fail" for this PR.

Yes, I can turn it off. I'm not sure how it got turned on. I did not turn it on. The codecov.io stuff if currently intended as a gentle reminder to write unit tests. :-)

@akavel I investigated if there is any easy way to adjust the codecov.io settings, but I was not able to figure it out in 5 minutes. My guess this is a new feature created by codecov.io. Only the Travis CI check is required.
I created #316 for tracking adjusting the codecov.io settings.


Can I use advanced formatting options with direct reference to chartist API?

Hi there,
I'd like to use some more advanced formatting options (my data contains holes) and stumbled over an example on the chartist examples page "Filled holes in data". Now I'm wondering if and how I could use Chartist.Interpolation.cardinal through the angular2-chartist wrapper.
{
  fullWidth: true,
  chartPadding: {
    right: 10
  },
  lineSmooth: Chartist.Interpolation.cardinal({
    fillHoles: true,
  }),
  low: 0
}

Any advice would be great!
Cheers,
Jens

@jensstruemper I am also interested in using this. Please record any findings you have here!

All you need to do is pass it as options. The interface for this lib is the same as Chartist. Let me know if any issues.

So, that's what I tried to do. When adding the following to the options
lineSmooth: Chartist.Interpolation.cardinal({
    fillHoles: true,
  }),

I would get an exception in the browser:
EXCEPTION: Error: Uncaught (in promise): EXCEPTION: Error in ./HomePage class HomePage_Host - inline template:0:0
ORIGINAL EXCEPTION: ReferenceError: Chartist is not defined
ORIGINAL STACKTRACE:
ReferenceError: Chartist is not defined
    at new HomePage (http://<IP_ADDRESS>:8101/build/js/app.bundle.js:68:29)
    at DebugAppView._View_HomePage_Host0.createInternal (HomePage.template.js:16:24)
    at DebugAppView.AppView.create (http://<IP_ADDRESS>:8101/build/js/app.bundle.js:31513:21)
    at DebugAppView.create (http://<IP_ADDRESS>:8101/build/js/app.bundle.js:31725:44)
    at ComponentFactory.create (http://<IP_ADDRESS>:8101/build/js/app.bundle.js:30583:36)
    at http://<IP_ADDRESS>:8101/build/js/app.bundle.js:64787:49
    at ZoneDelegate.invoke (http://<IP_ADDRESS>:8101/build/js/zone.js:323:29)
    at Object.onInvoke (http://<IP_ADDRESS>:8101/build/js/app.bundle.js:37159:41)
    at ZoneDelegate.invoke (http://<IP_ADDRESS>:8101/build/js/zone.js:322:35)
    at Zone.run (http://<IP_ADDRESS>:8101/build/js/zone.js:216:44)
ERROR CONTEXT:
[object Object]

Here the demo code:
import { Component } from '@angular/core';
import { ChartistComponent } from 'angular2-chartist';
import { NavController } from 'ionic-angular';
//import * as Chartist from 'chartist';

@Component({
//  selector: 'demo-app',
  directives: [ChartistComponent],
  template: `
    <x-chartist
      [data]="data"
      [type]="type"
      [options]="options"
      [responsiveOptions]="responsiveOptions">
    </x-chartist>
  `
})
export class HomePage {
  private data:any;
  private options:any;
  private responsiveOptions:any;
  private type:any;

  static get parameters() {
    return [[NavController]];
  }

  constructor(public navCtrl: NavController) {

  this.type = 'Line';

  this.data = {
    labels: ['1', '2', '3', '4', '5', '6'],
    series: [
              {
                data: [1, 2, null, null , 8, 13]
              }
            ]
    };

  this.options = {
    width: '300px',
    height: '200px',
    axisX: {
      lineSmooth: Chartist.Interpolation.simple({
      fillHoles: true })
    }
  }

  this.responsiveOptions = "";

  }
}

I can get rid of the exception my importing everything from the chartist library but the options would still have no effect:
import * as Chartist from 'chartist';

Well, you need to have Chartist imported. So when it is imported you are saying it doesn't work? Is there an error?

Thanks for the confirmation! When I added import * as Chartist from 'chartist'; the exception disappeared but the actual option had no effect (no change when setting "fillHoles from true to false"). However I just realized that the lineSmooth option is not working in axisX  context. Using it like so works as expected:
this.options = {
    width: '300px',
    height: '200px',
    lineSmooth: Chartist.Interpolation.simple({
      fillHoles: false })
  }

Well, you need to have Chartist imported. So when it is imported you are
saying it doesn't work?
On Sun, Oct 23, 2016 at 10:02 AM Jens Strümper<EMAIL_ADDRESS>wrote:

So, that's what I tried to do. When adding the following to the options
lineSmooth: Chartist.Interpolation.cardinal({
fillHoles: true,
}),
I would get an exception in the browser:
EXCEPTION: Error: Uncaught (in promise): EXCEPTION: Error in ./HomePage class HomePage_Host - inline template:0:0
ORIGINAL EXCEPTION: ReferenceError: Chartist is not defined
ORIGINAL STACKTRACE:
ReferenceError: Chartist is not defined
at new HomePage (http://<IP_ADDRESS>:8101/build/js/app.bundle.js:68:29)
at DebugAppView._View_HomePage_Host0.createInternal (HomePage.template.js:16:24)
at DebugAppView.AppView.create (http://<IP_ADDRESS>:8101/build/js/app.bundle.js:31513:21)
at DebugAppView.create (http://<IP_ADDRESS>:8101/build/js/app.bundle.js:31725:44)
at ComponentFactory.create (http://<IP_ADDRESS>:8101/build/js/app.bundle.js:30583:36)
at http://<IP_ADDRESS>:8101/build/js/app.bundle.js:64787:49
at ZoneDelegate.invoke (http://<IP_ADDRESS>:8101/build/js/zone.js:323:29)
at Object.onInvoke (http://<IP_ADDRESS>:8101/build/js/app.bundle.js:37159:41)
at ZoneDelegate.invoke (http://<IP_ADDRESS>:8101/build/js/zone.js:322:35)
at Zone.run (http://<IP_ADDRESS>:8101/build/js/zone.js:216:44)
ERROR CONTEXT:
[object Object]
Here the demo code:
import { Component } from '@angular/core';
import { ChartistComponent } from 'angular2-chartist';
import { NavController } from 'ionic-angular';
//import * as Chartist from 'chartist';
@Component({
//  selector: 'demo-app',
directives: [ChartistComponent],
template:     <x-chartist       [data]="data"       [type]="type"       [options]="options"       [responsiveOptions]="responsiveOptions">     </x-chartist>
})
export class HomePage {
private data:any;
private options:any;
private responsiveOptions:any;
private type:any;
static get parameters() {
return [[NavController]];
}
constructor(public navCtrl: NavController) {
this.type = 'Line';
this.data = {
labels: ['1', '2', '3', '4', '5', '6'],
series: [
{
data: [1, 2, null, null , 8, 13]
}
]
};
this.options = {
width: '300px',
height: '200px',
axisX: {
lineSmooth: Chartist.Interpolation.simple({
fillHoles: true })
}
}
this.responsiveOptions = "";
}
}
I can get rid of the exception my importing everything from the chartist
library but the options would still have no effect:
import * as Chartist from 'chartist';
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/paradox41/angular2-chartist/issues/52#issuecomment-255590342,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACqZMtfSKMLUdbcKWitAj0Je429jjLT6ks5q22jRgaJpZM4KdOxu
.

Sorry if my last post wasn't clear. It is working as expected! I wasn't aware that I had to import chartist on top of angular2-chartist. Can be considered as closed.


3.10.0 added a bug with line identation

Describe the bug
Doesn't properly detect the correct number of space in some cases.
Code sample
<?php

declare(strict_types=1);

namespace a;

class Hello
{
    /** @param mixed[] $items */
    public static function world(array $items, bool $nice): void
    {
    }

    public function hi(): void
    {
        \a\Hello::world(
            items: [
                'a' => [1, 2, 3]
            ],
            nice: false
        );
    }
}

If I add a comma after "nice: false", no error is reported
Custom ruleset
<?xml version="1.0"?>
<ruleset name="My Custom Standard">
  <description>If you are using a custom ruleset, please enter the relevant part here.</description>
</ruleset>

To reproduce
Steps to reproduce the behavior:

Create a file called test.php with the code sample above...
Run phpcs test.php ...
See error message displayed

 21 | ERROR | [x] Line indented incorrectly; expected at least 12 spaces, found 8 (Generic.WhiteSpace.ScopeIndent.Incorrect)

Expected behavior
No error
Versions (please complete the following information)

Operating System
Windows 10

PHP version
8.1

PHP_CodeSniffer version
3.10.0

Standard
psr12

Install type
[composer

Additional context
Add any other context about the problem here.
Please confirm

[x] I have searched the issue list and am not opening a duplicate issue.
[x] I confirm that this bug is a bug in PHP_CodeSniffer and not in one of the external standards.
[x] I have verified the issue still exists in the master branch of PHP_CodeSniffer.

@momala454 Thank you for reporting this. This looks to be the same issue as #504, though it is helpful to have a second code sample to confirm the issue with.
I'll close this issue now as a duplicate. Let's continue monitoring this in #504.


Use pimpl to minimize public API to prevent API/ABI from breaking

This will allow important changes to be backported without the risk of breaking API/ABI
This minimizes the API to literally just:
class NaoLola : public rclcpp::Node
{
public:
  NaoLola();
  virtual ~NaoLola() {}

private:
  class Impl;
  std::shared_ptr<Impl> impl;
};

The decision to leave this in the public API, is if someone wants to use the NaoLola node as a library.

Thought about this one, but this library was originally designed to be used as a library too, not just as a node.
So not merging in these changes.


Question: Billing Refund

When the user refund the purchase
billingManager.restorePurchases(KinAppProductType.INAPP)  return an empty array but if i call billingManager.purchase(this, <your_products_id_here>, KinAppProductType.INAPP) the response is   KinAppPurchaseResult.ALREADY_OWNED. How to fix it?

When the user refund the purchase
billingManager.restorePurchases(KinAppProductType.INAPP)  return an empty array but if i call billingManager.purchase(this, <your_products_id_here>, KinAppProductType.INAPP) the response is  KinAppPurchaseResult.ALREADY_OWNED. How to fix it?

It must be fixed


Failed to start jupyter in the environment error

Applies To

[X] Notebooks (.ipynb files)
[ ] Interactive Window and/or Cell Scripts (.py files with #%% markers)

What happened?
I am facing issues with the jupyter extension on Macbook M1 Pro. Suddenly my extension stopped working.
VS Code Version
1.72.2
Jupyter Extension Version
2022.9.1202862440
Jupyter logs
Visual Studio Code (1.72.2, undefined, desktop)
Jupyter Extension Version: 2022.9.1202862440.
Python Extension Version: 2022.17.13051012.
Workspace folder /Users/manpreet.minhas/manpreetdata/jupypter-notebooks
error 07:33:45.605: Exception while attempting zmq : [Error: No native build was found for platform=darwin arch=arm64 runtime=electron abi=106 uv=1 armv=8 libc=glibc node=16.14.2 electron=19.0.17
    loaded from: /Users/manpreet.minhas/.vscode/extensions/ms-toolsai.jupyter-2022.9.1202862440/out/node_modules/zeromq

	at load.path (/Users/manpreet.minhas/.vscode/extensions/ms-toolsai.jupyter-2022.9.1202862440/out/node_modules/node-gyp-build/index.js:1:3163)
	at load (/Users/manpreet.minhas/.vscode/extensions/ms-toolsai.jupyter-2022.9.1202862440/out/node_modules/node-gyp-build/index.js:1:648)
	at Object.<anonymous> (/Users/manpreet.minhas/.vscode/extensions/ms-toolsai.jupyter-2022.9.1202862440/out/node_modules/zeromq/lib/native.js:1:198)
	at u._compile (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:4:1313)
	at Module._extensions..js (node:internal/modules/cjs/loader:1220:10)
	at Module.load (node:internal/modules/cjs/loader:1035:32)
	at Module._load (node:internal/modules/cjs/loader:876:12)
	at c._load (node:electron/js2c/asar_bundle:5:13343)
	at r._load (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:116:14565)
	at v._load (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:111:65015)
	at E._load (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:111:64383)
	at Module.require (node:internal/modules/cjs/loader:1059:19)
	at p (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:4:699)
	at Object.<anonymous> (/Users/manpreet.minhas/.vscode/extensions/ms-toolsai.jupyter-2022.9.1202862440/out/node_modules/zeromq/lib/index.js:1:144)
	at u._compile (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:4:1313)
	at Module._extensions..js (node:internal/modules/cjs/loader:1220:10)
	at Module.load (node:internal/modules/cjs/loader:1035:32)
	at Module._load (node:internal/modules/cjs/loader:876:12)
	at c._load (node:electron/js2c/asar_bundle:5:13343)
	at r._load (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:116:14565)
	at v._load (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:111:65015)
	at E._load (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:111:64383)
	at Module.require (node:internal/modules/cjs/loader:1059:19)
	at p (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:4:699)
	at 92747 (/Users/manpreet.minhas/.vscode/extensions/ms-toolsai.jupyter-2022.9.1202862440/out/extension.node.js:17:593435)
	at __webpack_require__ (/Users/manpreet.minhas/.vscode/extensions/ms-toolsai.jupyter-2022.9.1202862440/out/extension.node.js:17:1480895)
	at l.zmqSupported (/Users/manpreet.minhas/.vscode/extensions/ms-toolsai.jupyter-2022.9.1202862440/out/extension.node.js:2:2220878)
	at l.isSupportedForLocalLaunch (/Users/manpreet.minhas/.vscode/extensions/ms-toolsai.jupyter-2022.9.1202862440/out/extension.node.js:2:2220621)
	at get isSupported [as isSupported] (/Users/manpreet.minhas/.vscode/extensions/ms-toolsai.jupyter-2022.9.1202862440/out/extension.node.js:2:2220531)
	at t.registerTypes (/Users/manpreet.minhas/.vscode/extensions/ms-toolsai.jupyter-2022.9.1202862440/out/extension.node.js:2:2235624)
	at /Users/manpreet.minhas/.vscode/extensions/ms-toolsai.jupyter-2022.9.1202862440/out/extension.node.js:2:1640908
	at /Users/manpreet.minhas/.vscode/extensions/ms-toolsai.jupyter-2022.9.1202862440/out/extension.node.js:2:1641663
	at /Users/manpreet.minhas/.vscode/extensions/ms-toolsai.jupyter-2022.9.1202862440/out/extension.node.js:2:1641671
	at t.activate (/Users/manpreet.minhas/.vscode/extensions/ms-toolsai.jupyter-2022.9.1202862440/out/extension.node.js:2:1641793)
	at Fn._callActivateOptional (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:102:17678)
	at Fn._callActivate (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:102:17338)
	at /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:102:15133
	at process.processTicksAndRejections (node:internal/process/task_queues:96:5)
	at async E._activate (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:88:8191)
	at async E._waitForDepsThenActivate (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:88:8133)
	at async E._initialize (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:88:7497)]
User belongs to experiment group 'jupyterTest'
User belongs to experiment group 'jupyterEnhancedDataViewer'
info 07:33:45.773: Attempting to start a server because of preload conditions ...
info 07:33:45.777: LSP Notebooks experiment is disabled -- not in treatment group
info 07:33:45.779: Checking for server existence.
info 07:33:45.779: Checking for server usability.
info 07:33:45.807: Loading webview. View is notset
info 07:33:45.807: Loading web view...
info 07:33:45.808: Webview panel created.
info 07:33:45.965: Web view react rendered
info 07:33:46.166: Got env vars ourselves faster /opt/miniconda3/envs/imagesearch/bin/python with env var count 52 in 380ms
info 07:33:46.166: Got env vars ourselves faster /opt/miniconda3/envs/imagesearch/bin/python with env var count 52 in 379ms
info 07:33:46.166: Got env vars ourselves faster /opt/miniconda3/envs/imagesearch/bin/python with env var count 52 in 378ms
info 07:33:46.168: Process Execution: > /opt/miniconda3/envs/imagesearch/bin/python -m pip list
> /opt/miniconda3/envs/imagesearch/bin/python -m pip list
info 07:33:46.169: Process Execution: > /opt/miniconda3/envs/imagesearch/bin/python -c "import jupyter"
> /opt/miniconda3/envs/imagesearch/bin/python -c "import jupyter"
info 07:33:46.169: Process Execution: > /opt/miniconda3/envs/imagesearch/bin/python -c "import notebook"
> /opt/miniconda3/envs/imagesearch/bin/python -c "import notebook"
info 07:33:46.190: Got env vars ourselves faster /opt/miniconda3/envs/imagesearch/bin/python with env var count 52 in 1ms
info 07:33:46.194: Process Execution: > /opt/miniconda3/envs/imagesearch/bin/python -m jupyter kernelspec --version
> /opt/miniconda3/envs/imagesearch/bin/python -m jupyter kernelspec --version
info 07:33:46.509: Starting notebook server.
info 07:33:46.510: Connecting to server
info 07:33:46.510: Launching server
info 07:33:46.510: Starting Notebook
info 07:33:46.510: Got env vars ourselves faster /opt/miniconda3/envs/imagesearch/bin/python with env var count 52 in 1ms
info 07:33:46.510: Got env vars ourselves faster /opt/miniconda3/envs/imagesearch/bin/python with env var count 52 in 1ms
info 07:33:46.524: Generating custom default config at /var/folders/2d/0d1vbdjs5vzffdcg1mgpwnqw0000gp/T/1e5682d6-c7a8-42fe-b638-ad7f266f57e9/jupyter_notebook_config.py
info 07:33:46.525: Starting Jupyter Notebook
Starting Jupyter from /opt/miniconda3/envs/imagesearch/bin/python
info 07:33:46.525: Got env vars ourselves faster /opt/miniconda3/envs/imagesearch/bin/python with env var count 52 in 0ms
info 07:33:46.525: Got env vars ourselves faster /opt/miniconda3/envs/imagesearch/bin/python with env var count 52 in 0ms
info 07:33:46.542: Creating daemon pool for /opt/miniconda3/envs/imagesearch/bin/python with env variables count 52
info 07:33:46.543: Process Execution: > /opt/miniconda3/envs/imagesearch/bin/python -m vscode_datascience_helpers.daemon --daemon-module=vscode_datascience_helpers.jupyter_daemon -v --ppid 9871
> /opt/miniconda3/envs/imagesearch/bin/python -m vscode_datascience_helpers.daemon --daemon-module=vscode_datascience_helpers.jupyter_daemon -v --ppid 9871
info 07:33:46.544: Process Execution: > /opt/miniconda3/envs/imagesearch/bin/python -m vscode_datascience_helpers.daemon --daemon-module=vscode_datascience_helpers.jupyter_daemon -v --ppid 9871
> /opt/miniconda3/envs/imagesearch/bin/python -m vscode_datascience_helpers.daemon --daemon-module=vscode_datascience_helpers.jupyter_daemon -v --ppid 9871
info 07:33:46.544: Process Execution: > /opt/miniconda3/envs/imagesearch/bin/python -m vscode_datascience_helpers.daemon --daemon-module=vscode_datascience_helpers.jupyter_daemon -v --ppid 9871
> /opt/miniconda3/envs/imagesearch/bin/python -m vscode_datascience_helpers.daemon --daemon-module=vscode_datascience_helpers.jupyter_daemon -v --ppid 9871
info 07:33:46.668: Got env vars ourselves faster /opt/miniconda3/envs/imagesearch/bin/python with env var count 52 in 0ms
info 07:33:46.677: Process Execution: > /opt/miniconda3/envs/imagesearch/bin/python (daemon) -m jupyter notebook --no-browser --notebook-dir="/Users/manpreet.minhas/manpreetdata/jupypter-notebooks" --config=/var/folders/2d/0d1vbdjs5vzffdcg1mgpwnqw0000gp/T/1e5682d6-c7a8-42fe-b638-ad7f266f57e9/jupyter_notebook_config.py --NotebookApp.iopub_data_rate_limit=10000000000.0
> /opt/miniconda3/envs/imagesearch/bin/python (daemon) -m jupyter notebook --no-browser --notebook-dir="/Users/manpreet.minhas/manpreetdata/jupypter-notebooks" --config=/var/folders/2d/0d1vbdjs5vzffdcg1mgpwnqw0000gp/T/1e5682d6-c7a8-42fe-b638-ad7f266f57e9/jupyter_notebook_config.py --NotebookApp.iopub_data_rate_limit=10000000000.0
info 07:33:46.677: Waiting for Jupyter Notebook
error 07:33:46.679: Failed to run jupyter as observable with args notebook --no-browser --notebook-dir="/Users/manpreet.minhas/manpreetdata/jupypter-notebooks" --config=/var/folders/2d/0d1vbdjs5vzffdcg1mgpwnqw0000gp/T/1e5682d6-c7a8-42fe-b638-ad7f266f57e9/jupyter_notebook_config.py --NotebookApp.iopub_data_rate_limit=10000000000.0 [g [Error]: Traceback (most recent call last):
  File "/Users/manpreet.minhas/.vscode/extensions/ms-toolsai.jupyter-2022.9.1202862440/pythonFiles/vscode_datascience_helpers/jupyter_daemon.py", line 158, in _start_notebook
    from notebook import notebookapp as app
ImportError: cannot import name 'notebookapp' from 'notebook' (unknown location)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/manpreet.minhas/.vscode/extensions/ms-toolsai.jupyter-2022.9.1202862440/pythonFiles/vscode_datascience_helpers/daemon/daemon_python.py", line 54, in _decorator
    return func(self, *args, **kwargs)
  File "/Users/manpreet.minhas/.vscode/extensions/ms-toolsai.jupyter-2022.9.1202862440/pythonFiles/vscode_datascience_helpers/jupyter_daemon.py", line 111, in m_exec_module_observable
    self._start_notebook(args, cwd, env)
  File "/Users/manpreet.minhas/.vscode/extensions/ms-toolsai.jupyter-2022.9.1202862440/pythonFiles/vscode_datascience_helpers/jupyter_daemon.py", line 160, in _start_notebook
    from notebook import app as app
ImportError: cannot import name 'app' from 'notebook' (unknown location)

	at /Users/manpreet.minhas/.vscode/extensions/ms-toolsai.jupyter-2022.9.1202862440/out/extension.node.js:7:36028] {
  category: 'daemon'
}
Failed to run jupyter as observable with args notebook --no-browser --notebook-dir="/Users/manpreet.minhas/manpreetdata/jupypter-notebooks" --config=/var/folders/2d/0d1vbdjs5vzffdcg1mgpwnqw0000gp/T/1e5682d6-c7a8-42fe-b638-ad7f266f57e9/jupyter_notebook_config.py --NotebookApp.iopub_data_rate_limit=10000000000.0
info 07:33:46.680: Failed to run jupyter as observable with args notebook --no-browser --notebook-dir="/Users/manpreet.minhas/manpreetdata/jupypter-notebooks" --config=/var/folders/2d/0d1vbdjs5vzffdcg1mgpwnqw0000gp/T/1e5682d6-c7a8-42fe-b638-ad7f266f57e9/jupyter_notebook_config.py --NotebookApp.iopub_data_rate_limit=10000000000.0

error 07:33:46.681: Error starting server in serverPreload:  [i [Error]: Traceback (most recent call last):
  File "/Users/manpreet.minhas/.vscode/extensions/ms-toolsai.jupyter-2022.9.1202862440/pythonFiles/vscode_datascience_helpers/jupyter_daemon.py", line 158, in _start_notebook
    from notebook import notebookapp as app
ImportError: cannot import name 'notebookapp' from 'notebook' (unknown location)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/manpreet.minhas/.vscode/extensions/ms-toolsai.jupyter-2022.9.1202862440/pythonFiles/vscode_datascience_helpers/daemon/daemon_python.py", line 54, in _decorator
    return func(self, *args, **kwargs)
  File "/Users/manpreet.minhas/.vscode/extensions/ms-toolsai.jupyter-2022.9.1202862440/pythonFiles/vscode_datascience_helpers/jupyter_daemon.py", line 111, in m_exec_module_observable
    self._start_notebook(args, cwd, env)
  File "/Users/manpreet.minhas/.vscode/extensions/ms-toolsai.jupyter-2022.9.1202862440/pythonFiles/vscode_datascience_helpers/jupyter_daemon.py", line 160, in _start_notebook
    from notebook import app as app
ImportError: cannot import name 'app' from 'notebook' (unknown location)

Failed to run jupyter as observable with args notebook --no-browser --notebook-dir="/Users/manpreet.minhas/manpreetdata/jupypter-notebooks" --config=/var/folders/2d/0d1vbdjs5vzffdcg1mgpwnqw0000gp/T/1e5682d6-c7a8-42fe-b638-ad7f266f57e9/jupyter_notebook_config.py --NotebookApp.iopub_data_rate_limit=10000000000.0

	at t.JupyterConnectionWaiter.rejectStartPromise (/Users/manpreet.minhas/.vscode/extensions/ms-toolsai.jupyter-2022.9.1202862440/out/extension.node.js:2:1992805)
	at t._error (/Users/manpreet.minhas/.vscode/extensions/ms-toolsai.jupyter-2022.9.1202862440/out/extension.node.js:2:1993406)
	at t.__tryOrUnsub (/Users/manpreet.minhas/.vscode/extensions/ms-toolsai.jupyter-2022.9.1202862440/out/extension.node.js:2:1183302)
	at t.error (/Users/manpreet.minhas/.vscode/extensions/ms-toolsai.jupyter-2022.9.1202862440/out/extension.node.js:2:1182711)
	at t._error (/Users/manpreet.minhas/.vscode/extensions/ms-toolsai.jupyter-2022.9.1202862440/out/extension.node.js:2:1181596)
	at t.error (/Users/manpreet.minhas/.vscode/extensions/ms-toolsai.jupyter-2022.9.1202862440/out/extension.node.js:2:1181290)
	at t.error (/Users/manpreet.minhas/.vscode/extensions/ms-toolsai.jupyter-2022.9.1202862440/out/extension.node.js:2:1178796)
	at /Users/manpreet.minhas/.vscode/extensions/ms-toolsai.jupyter-2022.9.1202862440/out/extension.node.js:7:36230] {
  category: 'jupyterconnection'
}

Coding Language and Runtime Version
No response
Language Extension Version (if applicable)
No response
Anaconda Version (if applicable)
4.13.0
Running Jupyter locally or remotely?
Local

@msminhas93 if you run the command "Jupyter: Select Interpreter to start Jupyter Server" in vscode do you have a Python interpreter selected there? If you do, from a terminal are you able to run jupyter notebook from that interpreter? Looks like it's failing to start up the jupyter server for you.

A wrong env was selected! I changed and that fixed the issue. Thanks a ton @IanMatthewHuff!

@msminhas93 Awesome. Glad that it helped.
For what it's worth, we should actually do a better job of surfacing this error on our side. This is a case where there is a difference between the interpreter that we are using to start up Jupyter in general, versus the actual target kernel. In a case like this it's hard for an end user like yourself to see what went wrong. We can look at cleaning this up in the future.
But glad you are up and running in any case.


vendor: update go.etcd.io/bbolt v1.3.4

full diff: https://github.com/etcd-io/bbolt/compare/v1.3.3...v1.3.4

Fix unsafe pointer conversions caught by Go 1.14 checkptr
Fix unexpected delete bucket error: "delete bucket: incompatible value"
Add support for aix
Add go.mod
db.Path() resolves to db.file.Name()

As mentioned in https://github.com/containerd/containerd/pull/4050#issuecomment-596146277 - this update fixes issues when using Go 1.14 / revealed by Go 1.14

@thaJeztah so the plan is to upgrade this package first get a clean run in Go 1.13 and then move to Go 1.14?

@dims partially, yes: IIUC there's more changes needed to make Go 1.14 work (https://twitter.com/AkihiroSuda/status/1242567902156357632?s=20), so at least making sure we get changes in that may be needed to update.

@thaJeztah sounds good! watching this space as we have to bump go in k/k as well https://github.com/kubernetes/kubernetes/pull/88638 ( which means we will need to be able to work with bbolt dependency from both contianerd and etcd )

LGTM


chore: add support for new rocksDB

Purpose

EVM PR https://github.com/Taraxa-project/taraxa-evm/pull/207
How does the solution address the problem

Changes made

prnet cleaned-up successfully


Module not appearing in Foundry's module installer

I could not find this module inside Foundry's module installer. I found a link to the mudule manifest URL posted by Atropos on the Pixels Dice Discord: https://github.com/foundryvtt/pixels/releases/download/0.0.1/module.json and then update the app to version 0.0.2 inside Foundry.
Foundry 10.303, running via Molten Hosting

Fixed now that version 0.1.0 is released the package is public.


fix: use a specific rclone CLI version

This change is part of the following stack:

#40 ◀

#41

Change managed by git-spice.


chore(deps): update module github.com/stretchr/testify to v1.8.4

This PR contains the following updates:

Package
Type
Update
Change

github.com/stretchr/testify
require
patch
v1.8.2 -> v1.8.4

Release Notes

stretchr/testify
v1.8.4
Compare Source
v1.8.3
Compare Source

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

:tada: This PR is included in version 1.0.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Temporary workaround for pandas and xarray frequency changes

Pull Request Checklist:

[x] This PR addresses an already opened issue (for bug fixes / features)

This PR fixes #1534

[x] Tests for the changes have been added (for bug fixes / features)

[x] (If applicable) Documentation has been added / updated (for bug fixes / features)

[ ] CHANGES.rst has been updated (with summary of main changes)

[ ] Link to issue (:issue:number) and pull request (:pull:number) has been added

This PR became a bit more complicated when I realized that xarray's latest release implements the "new" standards, but pandas 2.2 has not yet been released. And some of those changes are not implemented at all yet in pandas[^1]. I.e. pd.tseries.frequencies.to_offset(xr.infer_freq(da)) sometimes raises an error.
What kind of change does this PR introduce?

New function  fix_freq : it takes in a frequency code and translates it to the appropriate syntax. There are, sadly, three cases:

xarray >= 2023.11.0, pandas >= 2.2 : The "new" syntax (see below). Some changes are not yet supported by pandas 2.1.
xarray >= 2023.11.0, but pandas < 2.2 : The "inter[mediate]" syntax. Changes the subdaily codes, but not the coarser ones.
xarray < 2023.11.0, pandas < 2.2 : The "old" syntax, the one you know.

By « syntax » I mean the default codes. The "inter" version is supported by all previous xarray versions and pandas >= 1.0.

All hard-coded frequencies have been adapted for the "inter" syntax. (in the code, tests and notebooks)

fix_freq has been added everywhere conflict was possible

Raised the minimum pin on pandas so we can at least use the "inter" codes and not have a fourth category.

My goal here was to reduce the number of warnings for users. I wanted to avoid xclim's default to trigger user warnings or even errors. I don't think I achieved that goal, but I hope the transition will be smoother nonetheless.
Does this PR introduce a breaking change?
For sure. I think a normal "beginner" usage of xclim would be unchanged, but I'm not so sure about things like xscen or custom indicator modules. But some of that is broken anyway with xarray 2023.11.0 and would further break with pandas 2.2. Hopefully, we are able to control the damage with this PR and makes minimum breaking changes here only.
Other information:
The long term goal is to remove fix_freq when we pin pandas >= 2.2. This PR also introduces a few workarounds to remove at the moment, all denoted with "FIXME"  comments.
Major differences

old
inter
new

AS-JAN
AS-JAN
YS-JAN[^2]

A-JAN
A-JAN
YE-JAN

Q-DEC
Q-DEC
QE-DEC

M
M
ME

H
h
h

T
min
min

S
s
s

[^1]: and I was a reviewer on that PR in xarray. Woopsie!
[^2]: The "new" syntax is not yet supported by pandas (< 2.2), but xarray (>= 2023.11) will warn and return that in xr.infer_freq.

Closed as this seems to complicated. A drastic change in the pins seems cleaner.


Revert "refactor simplify runtime state ctor (#25995)"

This reverts commit a01922cdc55e2b3a63d9a9aafb38ac5ed64c6dd3.
Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Allow optional prediction mask for pixel classification

I suggest adding an optional input to the Run Pixel Classification Prediction node, allowing to choose an image column that contains a prediction mask.
See https://github.com/knime-ip/knip-ilastik/issues/17 for the previous issue opened on knip-ilastik.

Question: is it possible to have "optional" arguments in plugins? :)

@k-dominik yes:
@Parameter(required = false)
private Img maskImage;

You'll have to check for null yourself though. And while I would expect this to work in KNIME, I am not sure how this will be handled in the SciJava Swing UI, as it probably will show a drop-down, but this won't contain a None option. Might be something to improve over there in scijava-common and scijava-ui-swing ...

I've submitted  PR o implement this, and it works fine. Still, I could not find any way to add an optional parameter to the Command.
The problem is that the old macro calls should still work, and to achieve that, the command must have a default value for the new parameter. The only way I found that would actually make the command run without the extra parameter is by setting the new input to "resolved" (which apparently means that it already has a value and is ready to be used). Doing that, though, makes the input not show up in the UI in interactive mode.


LibSodium / LazySodium Problems

Hi,
I've found two problems with your implementation:
First one is, if I want to instantiate a paseto.v2.builder I can't give it my own version of libsodium, despite the interface being available. This one is debatable, would be nice due to the second problem.
Second one, at the moment lazysodium-java has a small implementation bug concerning the loading of libsodium.dll in windows (maybe also linux?). See Issue https://github.com/terl/lazysodium-java/issues/41
I'm not experienced in gradle, but as far as I understand these scripts version 2.5.0 of libsodium get's pulled into this project. So it would be nice, if you could update the project to use a version >3.5.2 (3.5.2 still contains the aforementioned bug) of lazysodium.
At the moment of writing there's not a new version released, so this issue serves as a reminder.
Thx and keep up the good work!

I'll look into updating to the newest version (3.5.2). Provided there's no major changes it should be quite simple.
For overriding, are you wanting to provide a custom instance of LazySodium? Or use another libsodium provider?
My LibSodiumV2CryptoProvider has a constructor which takes a LazySodium instance, you should be able to create a new instance of this class and provide it to the V2 builder.
Something like:
LazySodium customSodium;
LibSodiumV2CryptoProvider sodiumProvider = new LibSodiumV2CryptoProvider(customSodium);
PasetoV2 paseto = new PasetoV2.Builder(new Jvm8Base64Provider(),
					new JacksonJsonProvider(), new LibSodiumV2CryptoProvider()).build();

You just loose the convenience methods under PasetoBuilders, which just select these defaults for you.
If you want to use a different java project to provide libsodium, that should also be possible by extending V2CryptoProvider. Take a look at the LazySodium one linked above. It's pretty simple as it just forwards the calls into LazySodium.

@atholbro version 3.5.2 still has the bug! I've submitted a pull request but it isn't merged into lazysodium. Should hopefully be done in the next days.
That's what I meant, that your Provider has a constructor but it isn't exposed to the outside. would be nice if it would be easy usable. I tried changing the PasetoBuilders to be able to just pass the libsodium as an optional argument during the build process. Complicates some stuff, because now the builder has a direct dependency.
But ultimately this is a design decision up to you.

I've updated the LazySodium to 3.5.2. There was a small change made inside LazySodium which required a tiny change in Paseto. I understand that the bug you're seeing is still in 3.5.2, but now Paseto should support the upcoming version without any further changes.
Which constructor are you not able to access?
This works for me:
`import com.goterl.lazycode.lazysodium.LazySodium;
import com.goterl.lazycode.lazysodium.LazySodiumJava;
import com.goterl.lazycode.lazysodium.SodiumJava;
import net.aholbrook.paseto.PasetoV2;
import net.aholbrook.paseto.base64.jvm8.Jvm8Base64Provider;
import net.aholbrook.paseto.crypto.KeyPair;
import net.aholbrook.paseto.crypto.v2.libsodium.LibSodiumV2CryptoProvider;
import net.aholbrook.paseto.encoding.json.jackson.JacksonJsonProvider;
class Scratch {
public static void main(String[] args) {
LazySodium lazySodium = new LazySodiumJava(new SodiumJava());
LibSodiumV2CryptoProvider v2CryptoProvider = new LibSodiumV2CryptoProvider(lazySodium);
PasetoV2 paseto = new PasetoV2.Builder(new Jvm8Base64Provider(), new JacksonJsonProvider(),
v2CryptoProvider).build();
	KeyPair keyPair = paseto.generateKeyPair();

	System.out.println(paseto.encrypt("test", keyPair.getSecretKey()));
}

}`

Updated the lazysodium library to include your fix @vogt31337. Please upgrade to 3.6.0 🙂

@atholbro fix is now online. And I'll try your example, as soon as you've updated.
Thanks for the example and your work :) :+1:
(Please close the issue when done)

Deploying 0.4.1 which uses LazySodium 3.6.0 now!
If you're using the Hex decoder from 0.3.0, it's been removed. Just use the Hex decoder from Apache Commons Codec.

works :+1:


KAFKA-5957: Prevent second deallocate if response for aborted batch returns

@rajinisivaram, do you remember why completed is an AtomicBoolean in the following commit?
https://github.com/apache/kafka/commit/05b1ebd9ea6ca36a77269c71d598a7f613b277ba#diff-d40f2124414371535f2f1e47089eb71dR53
It seems like it's only ever accessed/mutated by the Sender thread. @hachikuji and I wanted to make sure we were not missing anything while discussing a potential alternative solution to the issue fixed by this PR.

@ijuma I don't remember, but looking at the code, it looks like I was just being extra cautious (unnecessarily).


chore: update to Java 17 and Gradle 8.4

What does this change?
Most of the first-party flutter plugins (like package_info_plus, device_info_plus, connectivity_plus) now require the usage of Java 17, compileSDK 34 and Gradle 8.4.
Having a flutter app with ua_client_hints: 1.2.2 in pubspec and with the following build.gradle config
    compileOptions {
        sourceCompatibility JavaVersion.VERSION_17
        targetCompatibility JavaVersion.VERSION_17
    }

    kotlin {
        jvmToolchain(17)
    }

results in
Execution failed for task ':ua_client_hints:compileDebugKotlin'.
> 'compileDebugJavaWithJavac' task (current target is 1.8) and 'compileDebugKotlin' task (current target is 17) jvm target compatibility should be set to the same Java version.

Updating the build.gradle resolved compilation issue for me and I did not notice any compilation/package behaviour changes.

@wasabeef

@lemonderon @otopba
Thank you!


[Event Request] Codeunit 90 "Purch.-Post" - OnBeforePostInvoice

Dear ALAppExtensions team,
On behalf of 4PS I would like to request integration event 'OnBeforePostInvoice' to be changed in procedure 'PostInvoice' in codeunit 90 "Purch.-Post";
    local procedure PostInvoice(var PurchHeader: Record "Purchase Header")
    var
        TotalAmount: Decimal;
        IsHandled: Boolean;
    begin
        IsHandled := false;
#if not CLEAN19
        OnBeforePostGLAndVendor(PurchHeader, TempInvoicePostBuffer, PreviewMode, SuppressCommit, GenJnlPostLine, IsHandled);
#endif
        //OnBeforePostInvoice(PurchHeader, PreviewMode, SuppressCommit, GenJnlPostLine, IsHandled, Window, HideProgressWindow, TotalPurchLine, TotalPurchLineLCY, InvoicePostingInterface, InvoicePostingParameters); //old
        OnBeforePostInvoice(PurchHeader, PreviewMode, SuppressCommit, GenJnlPostLine, IsHandled, Window, HideProgressWindow, TotalPurchLine, TotalPurchLineLCY, InvoicePostingInterface, InvoicePostingParameters, GenJnlLineDocNo, GenJnlLineExtDocNo, GenJnlLineDocType, SrcCode); //new
        if IsHandled then
            exit;

        with PurchHeader do begin

    [IntegrationEvent(false, false)]
    //local procedure OnBeforePostInvoice(var PurchHeader: Record "Purchase Header"; PreviewMode: Boolean; CommitIsSupressed: Boolean; var GenJnlPostLine: Codeunit "Gen. Jnl.-Post Line"; var IsHandled: Boolean; var Window: Dialog; HideProgressWindow: Boolean; var TotalPurchLine: Record "Purchase Line"; var TotalPurchLineLCY: Record "Purchase Line"; var InvoicePostingInterface: Interface "Invoice Posting"; var InvoicePostingParameters: Record "Invoice Posting Parameters") //old
    local procedure OnBeforePostInvoice(var PurchHeader: Record "Purchase Header"; PreviewMode: Boolean; CommitIsSupressed: Boolean; var GenJnlPostLine: Codeunit "Gen. Jnl.-Post Line"; var IsHandled: Boolean; var Window: Dialog; HideProgressWindow: Boolean; var TotalPurchLine: Record "Purchase Line"; var TotalPurchLineLCY: Record "Purchase Line"; var InvoicePostingInterface: Interface "Invoice Posting"; var InvoicePostingParameters: Record "Invoice Posting Parameters"; GenJnlLineDocNo: Code[20]; GenJnlLineExtDocNo: Code[35]; GenJnlLineDocType: Enum "Gen. Journal Document Type"; SrcCode: Code[10]) //new
    begin
    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 41613.


Resolve ValueSet lookups via Search API

Describe the solution you'd like
Add functionality to the search API to find concepts within a ValueSet resource:

By code
By DisplayName

Return the concept (from the CodeSystem) or Concept Not Found

For value sets that are expanded, it's very simple to look up the codes within the expansion of the valueset. There doesn't need to be any api or utilities for reading an already expanded value set. Even if this is a common operation by developers, there is very little value in providing a common API for that.
So within this issue we should focus on search by value set where a code is the searched parameter. For example, find observations with a code in a given value set .

so the look up from valueset -> codes will be done by the app

De-prioritized for now. Nice to have feature to simplify, hence moving this out of Q3 scope as per discussion with Jing & Fred.


Consider Open Referral's Data Specification in our data model

Open Referral's website: https://www.openreferral.org

Open Referral’s goal is to enable interoperability among diverse technologies that might use resource directory information to help meet people’s needs.

They are working on a Human Services Data Specification and a set of protocols for "accessing, updating, exchanging and synchronizing community resource directory data."
Perhaps their standards can inform how we model our data?

I reviewed the HSDS in more detail today, and I'm really impressed by the level of thought and consideration that's evident in this work. I think the specification lends itself very well to the structuring of data in our food resources app. Reading through the specification made me aware of a number of things that we had not really considered or had glossed over in our initial thinking, particularly accessibility and language data. The design of the schedule table is also extremely helpful as figuring out how to represent schedules is something that has been vexing me. I think what I will do next is to design/implement a local implementation of this with the small data set that we have. I will likely omit a lot of tables that are not relevant but try to stick to being HSDS compliant. The only thing I think we might need to "extend" is the concept of "recently available items".
If there is ever a centrally hosted HSDA, we could proxy most of our requests to that while maintaining a local database for "recently arrived items". In the shorter term, it may make sense for us to start with our own local database modeled in an HSDS compliant way, then evolve later to perhaps synchronizing with a centrally hosted HSDA via background or scheduled jobs, and then eventually maybe we could migrate to straight up proxying all requests straight to the HSDA. Those are just some initial thoughts.

Thanks for the great summary @thomascchen. This all makes sense. Let us know how it goes and if you need any feedback

@iritush Took me a long time, but I did give the HSDS data model a good try in this PR: https://github.com/codeforUV/food_resources/pull/78
Ultimately, I found it a bit too cumbersome to work with for our current needs, so ended up reverting it, but happy to provide more feedback if interested.

Thank you, @thomascchen. Very much appreciated! We are not actively working on this project at the moment but will reach out to you when we work on it again


Sequelize 5.x migration

Juice Shop should at some point be migrated to the latest Sequelize 5.x version which requires the following issues to be addressed in the process. One of the following approaches would have to be chosen:

Make epilogue (which seems unmaintained on GitHub by now) work with Sequelize 5.x
Switch to different API mapping library (needs follow-up change to one typosquatting challenge)
Create all API endpoints manually (probably least favorable due to effort)

Also the application needs to be checked for the use of string-based operators and those would have to be replaced with Op.-operators. Damage to any challenges needs to be checked as well.

😅 The "Database to REST Api" packages don't seem to survive for too long. Didn't we switch to epilogue because some other library was unmaintained?
Did look through the sequelize issues and somebody suggested to use finale-rest. This also has a epilogue compatibility mode.

This project aims to be a Sequelize 4.x and 5.x compatible version of Epilogue.

I :heart: it! Will try it our with current Sequelize and then see if we survive 4:arrow_right:5 migration with it... Thanks!


Continuing TEs sometimes creates new TEs

OS version: All
Browser version: Chrome 74
Extension version: master 35bbd9a

Relevant integration (if any):

🐛 Describe the bug

Continuing a blank entry (no description, no project/tag etc) creates a new entry randomly
See screenshot for reference

Similar issue faced by a customer
https://toggl.slack.com/archives/C02AT86CD/p1550779931033600
Expected behaviour

It should match the grouping logic used by the webapp

Steps to reproduce

Steps to reproduce the behaviour:

Go to webapp add a blank TE to a previous day
Continue the TE and Stop it
In toggl-button click Continue Latest
See new entry added to button, but still grouped in webapp
This is slightly nondeterministic and I'm not able to reliably reproduce it 100%

case link


transition page from splash screen to app screen for onboard

@amazingphilippe @katewilhelm we are unable to have the splash screen load for very long for various reasons.
It is recommended that we have a transition screen before launching users into onboarding so that there is an orientation for all users. We were unable to verify with alt text the splash image or the canada.ca watermark for those technical constraints.

Here is the new splash screen for the app. You can find this in the updated V1 figma.


Support for typings?

I have used google-material-color on my project.
It works well, but my project base on Angular2 and TypeScript.
Once I compile my project, tsc(typscript compiler) show me the error, which say 'cannot find module ...'
Do you have any plan for typings?

Hey @devcken,
No plans to port it to typescript but I can suggest you to use the files under the /dist/ folder directly if you want so that you don't have use any extra JS dependencies. You could use the sass, less... files depending on what you are using?
I don't know if this helps :)

9

I have updated Support For Typings


Create AP for "preferred fieldbook label"

e.g.
label: experimental trial
'preferred fieldbook label': agronomic trial

@pbuttigieg should it be a subclass of rdfs:label? does the obo foundry provide any guidelines about that?

@brianjlowe the ID of the property is http://purl.obolibrary.org/obo/AGRO_01000022

@pbuttigieg should it be a subproperty of rdfs:label? does the obo foundry provide any guidelines about that?

We'll have it as a sibling for now, as not all labels are fieldbook preferred.


run chrome --headless via PHP exec

When I run in shell: chome --headless --disabled-gpu http://mysite.com. Everything is working fine. But when I in the PHP script through exec('chome - headless - disabled-gpu http://mysite.com') - it hangs and does not give the result.
The web server is running on behalf of the user where I run the shell.
But in PHP, exec('chome --disabled-gpu http://mysite.com') does not hangs and is processed.
I want to take screenshots from php. What is missing?
Fedora23, PHP5

Set XDG_CONFIG_HOME and XDG_CACHE_HOME in folder with access for web user solved the problem.


PP-5889 Frontend build pipeline (bump Node version to 12.13.1)

move build pipeline instructions into "code as configuration"
update dockerfile to install new appmetrics
set node engine version
bump appmetrics version

Superseded by https://github.com/alphagov/pay-frontend/pull/1214


fix(android): video flickering add playback start

Summary
Avoid flickering when video playback starts on android
Motivation
Fix: https://github.com/TheWidlarzGroup/react-native-video/issues/3740
This issue gives a very bad quality feedback...
Changes
I fix few warning and did few clean up but the main change is to delay the shutterView removal by 15 ms
Test plan
Can be tested in the sample

I want to make release, so I will merge this


Auto creation of 1-click links in Readme

The Readme should contain links to every script that you can click to trigger install.
Doing this requires a job that updates the links every time the hash for them changes - the link will include the link to the raw script content.
Could we use appveyor to update the script links in the readme after every commit?

I wonder how executable is being generated from PS scripts? Maybe it's worth adding a section in readme?

I see - more details on how boxstarter works?  We can add this to the readme, does that address your questions?
https://boxstarter.org/Learn/WebLauncher

Ah, yes, I see now

@amankkg would you like to create a PR to provide some additional information around this in the readme.md?

We don't need to re-generate the links now that this repo is public.  Closing this issue.  I'll add a readme entry with the WebLauncher link.


Presence dot in the right sidebar is not round when there is an unread counter

The presence dot in the right sidebar becomes narrower when there is unread counter. It should be round regardless of whether there is an unread counter or not.
See Desdemona's dot here:

@zulipbot claim


Missing extra secret keyvault url.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@9c60944). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #49   +/-   ##
=======================================
  Coverage        ?   88.34%
=======================================
  Files           ?       22
  Lines           ?      266
  Branches        ?        9
=======================================
  Hits            ?      235
  Misses          ?       27
  Partials        ?        4

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


subclasses not returned by MongoEngine

Issue
When,

inherited MondoEngine Documents are created in Django along the following form,
base.models.py:
class Company(Document):
  pass

customer.models.py:
class Customer(Company):
  pass

Customer objects are added into MongoDB.

One tries to retrieve these Customer objects, when referencing them as their base Class without specifically importing the child model.

An Exception is raised rather than the Customer class being returned.
Demonstration
$ ./manage.py shell
>>> from base.models import *
>>> cust1 = Company.objects.get(name='Customer1')
Traceback (most recent call last):
  File "<console>", line 1, in <module>
  File "/usr/local/Cellar/python/2.7/lib/python2.7/site-packages/mongoengine-0.4-py2.7.egg/mongoengine/queryset.py", line 724, in get
    return self[0]
  File "/usr/local/Cellar/python/2.7/lib/python2.7/site-packages/mongoengine-0.4-py2.7.egg/mongoengine/queryset.py", line 1026, in __getitem__
    return self._document._from_son(self._cursor[key])
  File "/usr/local/Cellar/python/2.7/lib/python2.7/site-packages/mongoengine-0.4-py2.7.egg/mongoengine/base.py", line 692, in _from_son
    """.strip() % class_name)
NotRegistered: `Company.Customer` has not been registered in the document registry.
                        Importing the document class automatically registers it,
                        has it been imported?

Workaround
By importing the module that defines the Customer class; the correct object is returned,
>>> from customer.models import *
>>> cust1 = Company.objects.get(name='Customer1')
>>> cust1
<Customer: Customer1>

The modules defining more specific objects should not need to be included - this is to allow a generic programming methodology.
Resolution
MongoEngine maintains a registry of all Document classes; this should be consulted when an object is to be returned - using the get_document() function defined in base.py to find the correct class allowing the proper object to be returned to the caller without the need for importing extra modules.
Diff
The following diff resolves the issue.
diff --git a/mongoengine/base.py b/mongoengine/base.py
index 8d0c470..1d72055 100644
--- a/mongoengine/base.py
+++ b/mongoengine/base.py
@@ -681,16 +681,7 @@ class BaseDocument(object):

         # Return correct subclass for document type
         if class_name != cls._class_name:
-            subclasses = cls._get_subclasses()
-            if class_name not in subclasses:
-                # Type of document is probably more generic than the class
-                # that has been queried to return this SON
-                raise NotRegistered("""
-                        `%s` has not been registered in the document registry.
-                        Importing the document class automatically registers it,
-                        has it been imported?
-                    """.strip() % class_name)
-            cls = subclasses[class_name]
+            cls = get_document(class_name)

         present_fields = data.keys()
         for field_name, field in cls._fields.items():

Confirmation
With the patch applied, the query works as expected - without raising an Exception,
$ ./manage.py shell
>>> from base.models import *
>>> cust1 = Company.objects.get(name='Customer1')
>>> cust1
<Customer: Customer1>
>>>

now in dev!  Thanks @aid for the patch


not working with ksplat ?

why isn't it working with mkkellogg'ksplat format ?

Sorry for the delay @cyrilpreiss - this was a proof-of-concept port that was done at a time when mkkellogg's kspat format was in it's first iteration.  He's since improved it.  Definitely wish I'd done the port a little later 👍


Echo framework support

Like Gin currently supported (https://docs.bugsnag.com/platforms/go/gin/), it would nice to support the well-known echo framework: https://echo.labstack.com (https://github.com/labstack/echo)

Hi @crazy-max
We do have an item on our backlog to add Echo framework support. However I should note that no substantial amount of work has been completed for this framework support. As such, we do not have any firm ETA on the release of this functionality. Once we have more information to share we will be sure to update this thread.


CuBLAS

Now that the float32 bugs appear to have been resolved, time to start porting CuBLAS

CuBLAS may have to take a step back. Looking at integrating CuDNN instead

Hey @chewxy I'm really interested in this project but my one blocker is lack of CUDNN support. Have you investigated/started this at all? Thanks

the chad branch will fully support CuDNN. Work is being done right now to support it. See also: https://github.com/chewxy/cu

Awesome news, look forward to using it 👍


Killed server mode in dul (now sits in applicationentity).

This seems to be obsolete code, now server mode sits in applicationentity.

Yes but that would prevent from working at a deeper level than applicationentity. For instance, I have SCP code that directly works at DIMSE/ACSE level. Killing the server code in DUL would make that impossible.

Thinking a bit more about it, the DUL is a layer of the OSI model and can, according to my understanding this model, live by itself without knowing anything of the layers above (DIMSE/ACSE and applicationentity). This was my original motivation for allowing the DUL to accept connections.
On the other hand, I'm not necessarily against deviating from this model if it can lead to simpler code and no practical consequence, but this would need to be discussed.

I'd be happier if all the low level networking code was in a TransportConnection (or similar) class or module. From my reading of the standard, the transport stuff should be separated from both the DUL and the association, and in particular it should be the state machine that controls the higher level networking functionality through AE-1/AE-5/AR-3/AA-2/AA-3, etc rather than AE/Assoc/DUL.
It would also make it easier to maintain.

I like the idea of a TransportConnection class. I also agree that transport stuff would be taken out of the applicationentity, association and DUL, and taken care exclusively by the FSM (through the TransportConnection class)
I think it is was a mistake on my part to have included transport code at the AE/Association, and to a lesser extent at DUL level. I can't remember how I was lead to think it was a good idea though ...
So, can we agree that the ideal structure would be:

AE/Association only talk to ACSE and DIMSE services;
ACSE and DIMSE services only talk to DUL;
DUL drives the FSM;
The FSM deals with low level network stuff;
Low level network stuff would all be encapsulated in a TransportConnection class/module.

Coming back to the original PR, @amosonn was right in the sense that there should not be low-level network stuff all over the place.

Well ... perhaps not so easy (just responding to my last comment). I now see (and remember) the reason behind the AE holding the server socket and checking for incoming connections. This effectively substitute to the first step that should, according to the standard, be done by the FSM.
Insisting that the AE not dealing with low level network operation  may imply something like this (just thinking aloud):

AE (supporting some SOP classes as SCP) starts;
AE starts an Association (A1)  (with related ACSE, DIMCSE, DUL, FSM) that is idle, waiting for connections (throught the FSM/TransportConnection) on the AE port;
When a connection arrives, A1 deals with it and as soon as the AE knows it creates a new Association (A2) listenting on the AE port in a new thread.

Well, if a rewrite of the whole low-level network layer were to be done, I would suggest doing so using asyncio. Co-routines have many advantages over threads: They are, in general, more robust, less prone to strange infinite loops, easier to test, more efficient (at least for IO-bound tasks), and make it easier to communicate between different contexts (removing all the current busy-wait loops and sleeps).
If written with co-routines, network code need indeed exist only in the innermost layer of the fsm; all other layers will just yield from the layer under them. https://docs.python.org/3/library/asyncio-stream.html#asyncio.start_server can then be used to await connections, still leaving the first step of actual handling of the connection to fsm, all the other layers only instantiating the layers under them and passing the socket inwards.
I reached this code in dul while trying to asses the amount of work this would require, sadly right now I don't think I have enough time to dedicate to this.

Very interesting ... Would this be applicable to python2 as well? Just saw the trollius package that seem to provide a python2 implementation of asyncio but is it completely equivalent to python3's asyncio?

Seems trollius is unmaintained, but might still work. How important is the python2 support? I thought the target of pynetdicom3 was to switch to python3.

trollius doesn't seems dead to me - there has been a release today.

@amosonn - I know the first cut of pynetdicom3 was Py3 only, but I think there are lots of users that are thankful it was made Py2+3 compatible. pydicom still supports both and realistically there is no other up to date option for DICOM networking on python 2. Hopefully like me most of those users are working towards python 3, but we need more time to transition!

The release was made mostly to add the banner on top that says that they
don't maintain it anymore. Still, it's supposed to be in working condition,
so it could probably still be used to stay compatible with python 2, at
least for some time.
On 10 March 2018 at 00:41, edmcdonagh<EMAIL_ADDRESS>wrote:

@amosonn https://github.com/amosonn - I know the first cut of
pynetdicom3 was Py3 only, but I think there are lots of users that are
thankful it was made Py2+3 compatible. pydicom still supports both and
realistically there is no other up to date option for DICOM networking on
python 2. Hopefully like me most of those users are working towards python
3, but we need more time to transition!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/pydicom/pynetdicom3/pull/105#issuecomment-371976663,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC_zrQrXlGEJwxI2_Z871a7uoM3-K7j-ks5tcxM7gaJpZM4SVc2S
.

I've been playing around with using gevent for the Transport Service in an experimental repo. I have a couple of targets I'd like to meet for any changes to the transport:

Support for 100 concurrent associations
C-MOVE operations should be possible over the same association
C-CANCEL-* operations should be possible (not sure if they currently are)
Faster than current pynetdicom and pynetdicom3 for 1000 C-STORE oeprations over 1 association and 1 C-STORE operation over 1000 associations.
Simpler to maintain and debug

I like that I can run an SCP in non-blocking mode with gevent
I'd like to maintain backwards compatibility until its dropped by pydicom.

Cool! Is it possible to see this code?
In the meantime I've started working out of the current code, trying to
reduce the complexity of the communication between the association thread
and the dul thread, and eventually drop the one running dul - since even in
the thread-based approach, there's no need for two threads to handle each
association.
I only got half-way through, and it's already incompatible with the current
master, but you can see it on my repo under the branch clean_sockets2.
On Sat, Apr 14, 2018, 06:35 scaramallion<EMAIL_ADDRESS>wrote:

I've been playing around with using gevent for the Transport Service in an
experimental repo. I have a couple of targets I'd like to meet for any
changes to the transport:

Support for 100 concurrent associations
C-MOVE operations should be possible over the same association
C-CANCEL-* operations should be possible (not sure if they currently
are)
Faster than current pynetdicom and pynetdicom3 for 1000 C-STORE
oeprations over 1 association and 1 C-STORE operation over 1000
associations.
Simpler to maintain and debug

I like that I can run an SCP in non-blocking mode with gevent
I'd like to maintain backwards compatibility until its dropped by pydicom.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/pydicom/pynetdicom3/pull/105#issuecomment-381302752,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC_zret-7t9p_B3B6WzCN1z10OuszCyzks5toXySgaJpZM4SVc2S
.

I think the best way is to follow the "sans-io" approach: http://sans-io.readthedocs.io/
This way users aren't tied to gevent/asyncio/etc.  Of course, the DICOM protocol is a bit special, so maybe this is more complicated than for something like HTTP.


Make sprites transparent

Current version looks very ugly in C4 diagrams:

In comparision, logos look much better:

It looks like this is caused by the original images not having a transparent background.
For instance  has a white background.
The new images, for instance  do have a transparent background.
This might be a good time to update the source images to the new location at https://github.com/kubernetes/community/tree/master/icons and re-generate all the sprites.


Clicking submit button multiple times sends multiple web submissions

When a candidate goes into the career portal and gets to the stage of submitting their information.  Every click on the submit or submitting... button sends a new rest call into Bullhorn that creates a unique web response.  This is causing the jobs to be filled with duplicate web responses and the way the system handles deleting / moving web responses is based on candidate and job so they all are moved / deleted together.
Current behavior

Clicking the submit button multiple times sends that number of web responses in.

Expected behavior

One web response per candidate per job

Steps to replicate behavior

Open a Job on the career portal
Click apply
Fill out information
Open dev tools (f12)
Click send / sending... buttons multiple times

See each click sends a new payload into BH

Good catch! We could implement a storage mechanism inside the browsers session storage that would show a "You have already applied to this job" message when the user tries to apply to the same job during the same browser session.
This would keep the user from applying to the same job during the same sitting, but once they close the tab/browser and come back it will act like normal. This is because the Career Portal is anonymous to use and multiple people could share the same machine.
Would this be an acceptable solution?

I think that'd be a great solution.
Thank you

Hi @ccoffman1 , thanks for your feedback! We've introduced this feature fix per @jgodi 's spec above. The source code has been integrated back to the master branch, but hasn't been packaged for release yet. You can either pull the source code and build career-portal locally, or hang tight until the next career-portal release. Hope this helps!


Cleaned up formatting

Added headers and fixed a hyperlink

Also wrote and added needle valve upgrade for BDB

Also wrote and added needle valve upgrade for BDB


Delete entity from EntityManager._entitiesByNames when calling removeEntity

The entity in EntityManager._entitiesByNames will never get deleted, which may cause many problems. One problem I met is that I could not create an entity with the same name as the removed entity.

Nice catch! done


Homo Ref Not added to INI

The homozygous reference calls in the snpSniffer.vcf and not being added to the database.  Likely this is a format difference between samtools and bcftools that the java app is not handling correctly. @sfacista @bryce-turner

Sample	MMRF_1371_2_BM_CD138pos_T1_KHWGS.bwa.bam.snpSniffer	MMRF_2331_2_BM_CD138pos_T5_KHWGS.bwa.bam.snpSniffer
X:119453040	TT	TT
X:47585586	CC	CC
X:79171491	NN	CC
1:109923844	TC	CC
1:110947279	NN	NN
1:111352865	NN	CT
1:113973095	GA	AA

1       109923844       .       T       C   0/1:255,0,255
1       110947279       .       A       .  0/0:0
1       111352865       .       C       .  0/0:0

Just tested with the OLD jar file and still the same issue so there is some difference in the VCF format that is causing the issue during the addition to the database.

So there is a noticeable difference in how AA/homoRef genotypes are encoded
Old_Genotype.vcf
1       111489901       .       A       .       265     .       DP=84;AF1=0;AC1=0;DP4=48,30,0,0;MQ=60;FQ=-262   PL      0
New_Genotype.vcf
1       110947279       .       A       .       244.996 .       DP=85;SGB=-0.379885;RPB=1;MQB=1;MQSB=0.989423;BQB=1;MQ0F=0;AF1=0;AC1=0;DP4=50,27,0,1;MQ=60;FQ=-241.988;PV4=0.358974,0.017788,1,0.178514 GT:PL   0/0:0

@sfacista I'm guessing the code is expecting just a single "0" in the GT column whereas now it adheres to todays specification, not sure if "0" alone was ever acceptable, with 0/0

@sfacista I'm guessing the code is expecting just a single "0" in the GT column whereas now it adheres to todays specification, not sure if "0" alone was ever acceptable, with 0/0

AddFile.java was changed on line 106 so that the homozygous reference is expected as "0/0". Other major revisions were documented.
Pull request created:
https://github.com/tgen/snpSniffer/pull/14/files
Thank you for doing all the work of describing the issue. I tested all the methods, but nothing on live data. Please let me know if anything fails.

@sfacista Yes fixing the addition of 0/0 alleles to the database will resolve this issue.  I did notice that 7-10 of the b38 human positions are never called so we might want to update the target positions but the main problem is resolved


May 1, 2020 expiry date B2C Sign in policy v1

Hi Team,
we have B2C Sign in policy v1 and v2 in azure portal
I heard for B2C Sign in policy v1 (B2C_1A_signup_signin).
After May 1, 2020 you will not be able to use Configurable Token Lifetime policy to configure session and refresh tokens. You can still configure access token lifetimes after the deprecation.
https://docs.microsoft.com/en-us/azure/active-directory/develop/active-directory-configurable-token-lifetimes
is that true that also B2C Sign in policy v1 (B2C_1A_signup_signin) is expiring same date?
thanks,

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 02ff3d62-dc0e-ad0c-f5ae-418337cf31e4
Version Independent ID: d50952b5-6b98-c40d-d3a3-f9cbec58dd28
Content: Configurable token lifetimes in Azure Active Directory - Microsoft identity platform
Content Source: articles/active-directory/develop/active-directory-configurable-token-lifetimes.md
Service: active-directory
Sub-service: develop
GitHub Login: @rwike77
Microsoft Alias: ryanwi

@kamranbashir
Thanks for your feedback! We will investigate and update as appropriate.

big issue is that, this page/documnetation does not work.
Create a new policy , user must reauthenticate case never happen it silently acqire a new session!!! very bizzare
New-AzureADPolicy -Definition @('{"TokenLifetimePolicy":{
"Version":1,
"AccessTokenLifetime":"00:15:15",
"MaxInactiveTime":"00:14:55",
"MaxAgeSingleFactor":"1.00:00:00",
"MaxAgeSessionSingleFactor":"00:59:00",
"MaxAgeSessionMultiFactor":"00:59:00"
}}') -DisplayName "TokenLifetimeDefaultPolicy" -IsOrganizationDefault $true -Type "TokenLifetimePolicy"
Please help us, we unable to perform pen tests!..
Current problems/issues reported:
MS azure-docs on github
https://github.com/MicrosoftDocs/azure-docs/issues/43080
MS azure support
Support request number:<PHONE_NUMBER>00009
Product: Azure Active Directory Business To Consumer (B2C)

Hi @kamranbashir ,
As far as I am aware it is just the Configurable Token Lifetime policy. I'm assigning this issue to the content author to look into the doc bug you described.
Do you get any error message or does it just require the new authentication?
Please post this to Q&A too so we can help troubleshoot with you there. https://docs.microsoft.com/answers/questions/index.html

Adding link to the Microsoft Q&A thread https://docs.microsoft.com/answers/questions/1463/token-lifetime-policy-is-not-working.html

@kamranbashir , I believe this was answered in https://docs.microsoft.com/answers/questions/1463/token-lifetime-policy-is-not-working.html.  Closing this issue, feel free to re-open if necessary.  #please-close


Package sdl2pp

https://github.com/libSDL2pp/libSDL2pp

Thanks for the PR and sorry for the delay!

Thanks for the code improvement and merge of PR.


Uberflip Service

Service name
Uberflip
Proof
https://hackerone.com/reports/863551
Documentation
If the subdomain shows error "Non-hub domain, The URL you've accessed does not provide a hub. Please check the URL and try again." and is pointing toward read.uberflip.com then it is vulnerable to takeover because according to uberflip "The only protection is the customer’s proper management of their subdomains.
For this reason, we do not recommend customers point wildcards to us, and that they follow DNS management best practices by periodically reviewing all their hostnames and subdomains."
Thanks,
Aman Shahid
https://twitter.com/amansmughal

Hi @AmanShahid
Thank you for sharing the report.
Going to uberflip.com for account setup, I could not see any way to signup for a service. Request you to kindly share the process/url to signup for the service to understand the process of hosting a POC for the takeovers.
Best,
sumgr0

Some websites might not be added to an Uberflip account, however it is not possible for takeover. Registering for an account is not possible, you have to book a demo with the sales team.
The Hackerone report that was linked above was an empty takeover, they didn't actually perform it. I find it highly unlikely that someone could register with their sales team pretending to be that company.
Should this be closed as not possible?


load data using bulk interfaces where possible in record page

some events on the record page load entities one at a time and could be easily converted to 'bulk' ermrest queries.

i've seen it and it looks complete to me, but a better test case would be the bdds database, so again i'd like to assign this to mike for review.

Working ok for me on the BDDS/PPMI data.


blog: add v<IP_ADDRESS> release notes

Somehow CI preview does not show the blog post. I confirmed it working locally.

Hashes match binaries


Can not launch the PowerRename

Microsoft PowerToys version
"0.49.1"
Running as admin

[X] Yes

Area(s) with issue?
PowerRename
Steps to reproduce

On File Explorer, right click a file and show context menu.
Select the PowerRename.

✔ Expected Behavior
Launch the PowerRename.
❌ Actual Behavior
Does not launch the PowerRename.
Other Software
Windows 10 21H2 insider release preview (19044.1381).

Seems like #14076 to me.

Can you try installing Microsoft Visual C++ redistributable and check whether PowerRename works after that ?

I has the same problem. Installing Microsoft Visual C++ redistributable 2015-2022 did not help. What has helped was a full reinstall of PowerToys.

I would like to revisit this once 0.51 is out since i think #14076 fixed this

Since will revisiting this in 0.53, removing needs author feedback to prevent accidentally closed by the bot.

@MotoyukiS 0.51 is released, can you try again?

@crutkas I tried 0.51 and launch PowerRename app!
Thanks to fix.

Duplicate of #14219


Scatter plot with density cross-diagonal artifact

There seems to be an issue with the 2d density plot used in the scatter plot

from modelskill.plotting import scatter
import matplotlib.pyplot as plt
import numpy as np

np.random.seed(42)
X = np.random.multivariate_normal([0, 0], [[1, 0.98], [0.98, 1]], 20000)
x = X[:, 0]
y = X[:, 1]
fig, ax = plt.subplots(1, 2, figsize=(14, 6))
scatter(x,y,ax=ax[0])
scatter(x, y, show_density=False, show_hist=True, show_points=False, bins=100, ax=ax[1]);

These bands seems like an artifact.

Same artifact with the plotly backend

And if your variables should be negatively correlated (hopefully not the case for most models😉)

@daniel-caichac-DHI ? Can you verify this?

Yes I have seen this artifact, it depends on the number of bins the data is clustered for the density plot.
The smaller the bin, the smaller the artifact.

Could we use overlapping bins to overcome this artifact (cheap alternative to rolling bins)?

Ok I jsut had some time to look at this, I replicated @ecomodeller  code, but I think the solution is far more simple.
Top figures: Default (20 bins), both points and histogram.
Bottom figures: 100 bins, both points and histogram.

The solution I see it as simple as as increased the extremely low default which is now , bins=20, to something like bins=100 or bins=200.
The scatter plot now follows the histogram. If by default we have bins=20 (as of now), we are clustering water level data in chunks of ~0.5m by ~0.5m, so of course it will look horrid.

Sent this PR
https://github.com/DHI/modelskill/pull/282

Closed by #282


update SBCFM notebook details

What does this PR do?
This PR updates the explanations in the SBCFM notebook by providing more details on the difference between the theory and what we do in practice.
Fixes #\49
Before submitting

[x] Did you make sure title is self-explanatory and the description concisely explains the PR?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you list all the breaking changes introduced by this pull request?
[x] Did you test your PR locally with pytest command?
[x] Did you run pre-commit hooks with pre-commit run -a command?

Codecov Report
Patch and project coverage have no change.

Comparison is base (1588442) 34.23% compared to head (5cef086) 34.23%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #53   +/-   ##
=======================================
  Coverage   34.23%   34.23%
=======================================
  Files          55       55
  Lines        6268     6268
=======================================
  Hits         2146     2146
  Misses       4122     4122

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Refactor team members table in student teams view

Refactor the view student_teams/view.html.erb:
The view is quite bloated and has lots of functionalities written on it. Create a partial to display the table for team members on the student_teams/view?student_id= page.

Added partials for student_teams/view.html.erb => added _team_display.html.erb
in Commit ded2aef281580e4186c397579e545b9e3177fa27


Sticky Scroll Panel Font Size Update Issue

Type: Bug
Hi,
The font size of the sticky scroll panel doesn’t update in real-time with the editor’s font size adjustment while the panel is visible and you’re actively viewing the screen where it is displayed (e.g., when using zoom methods like CTRL + '+'/'-' or CTRL + [MSC] when terminal.integrated.mouseWheelZoom is set to true). The panel only reflects the changes after it is refreshed, such as by exiting and re-entering a function in Python.
VS Code version: Code 1.94.1 (e10f2369d0d9614a452462f2e01cdc4aa9486296, 2024-10-05T05:44:32.189Z)
OS version: Windows_NT x64 10.0.19045
Modes:

Hi thanks for filing this issue. It should be fixed with https://github.com/microsoft/vscode/pull/227400


update dep and resolve typing issue

Why do we want to make this PR? Does it come from the security alerts?

Why do we want to make this PR? Does it come from the security alerts?

nope, it is for typing fix. when i try to upgrade in go testgen, it failed for ts typing check.

/azp run

/azp run tools - sdk-testgen - ci


More what-questions

The what_questions.json should have 3-5 different formulations.

3 additional formulations were added to the what_question for a total of 4.


get the latest refresh time from a table / partition of a semantic model

i want to have an overview of my tables of the model are refreshed. due to having a schedule for certain partition not all partitions are refreshed on the same time. now i need to look these up manually. only checking the refreshes is not sufficient. this because i refresh multiple tables / partitions in one run. so now i can only check if a run is failed or not.
i want a labs function where i can have as out put a list of tables and partitions with the latest refresh time per table / partition.
with this feature i can make a admin portal where i have an overview of tables that not refreshed lately.

You should be able to get this from running a dmv using semantic link’s evaluate_dax function.
$system.tmschema_partitions

perfect thanks! and thanks for developing semantic-link-labs, it really helps for new solutions!


feat: Eip1559 params in extradata

Part of Holocene changes to add EIP1559 params to payload, and using the extradata field in block header to store the value.
Spec: https://github.com/ethereum-optimism/specs/blob/main/specs/protocol/holocene/exec-engine.md

Addressed comments, PTAL again @Rjected @clabby

@Rjected @clabby @mattsse can I get another round of review for this? Also have a question above in one of the review comments

@Rjected PTAL again, removed all panic/unwrap().
Also I can't seem to run the wasm check locally. For example running cargo +stable build -p reth-evm --target wasm32-wasip1 --no-default-features I always get
error[E0463]: can't find crate for `std`
  |
  = note: the `wasm32-wasip1` target may not be installed
  = help: consider downloading the target with `rustup target add wasm32-wasip1`

error[E0463]: can't find crate for `core`
  |
  = note: the `wasm32-wasip1` target may not be installed
  = help: consider downloading the target with `rustup target add wasm32-wasip1`

But running the suggested command is not helpful.

Looks like all the checks pass now (thanks to @Rjected !)
Can I get final reviews from others and see if everything looks good? @tynes @clabby @mattsse


"Generate union cases" does not handle nested patterns

type A = A1 | A2

type B = B1 | B2 of A

let test x =
    match x with
    | B1 -> ()
    | B2(A1 | A2) -> ()

Hover over A1 or A2 in bottom case, it will give bogus suggestion/completion:

Aaahaha, I guess I will have to dive into the code after such a long break ;).
Interesting that nobody caught this before :).
Thanks @latkin !


Support for adoc

I'd really appreciate support for AsciiDoc files with .adoc with UTI dyn.ah62d4rv4ge80c3dtqq. Rendering would be possible using bytesparadise/libasciidoc.

Cool library. The HTML conversion part is probably easy because it's written in Go and it also uses Chroma for syntax highlighting. This will allow us to add it to HTMLConverter.
It's very important to me that Glance's different previews looks consistent and that stylesheets are shared wherever possible. I think getting the CSS right will be the main challenge of this feature. Let's revisit this once https://github.com/bytesparadise/libasciidoc/issues/63 has been implemented.


Add mock client

This can be used to avoid spinning up server instances when running unit tests. This supports generation via request and via options.
Fixes #146
Signed-off-by: Hayden Blauzvern<EMAIL_ADDRESS>
Summary

Release Note

Documentation

@hectorj2f Yea, I'll note in the ticket to start using this. The Cosign PR shows usage of it too


(Fix) Add class 'error' to InputField

Closes #789

Pull Request Test Coverage Report for Build 2025

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 22.372%

Totals

Change from base Build 2019:
0.0%

Covered Lines:
625

Relevant Lines:
2441

💛  - Coveralls


GEOMESA-1850 - Add gt-main back to the HBase distribution

Signed-off-by: Jim Hughes<EMAIL_ADDRESS>

Added to #1545


set header instead of appending them

in order to avoid setting multiple e.g. session handler on retry

Thanks for the fix! 🙂


CH 13: Changing the order of the cells gives different results. Pg 420 - 422

In the Solving an XOR classification problem section, the author defined the model, then defined the loss function and the optimizer, then created the data loader. Finally, he defined the training function followed by plotting the results.
If I follow this same sequence, I get this figure

This figure is different from what is shown in the book!
However, in the notebook, the author defined the data loader, then the model, then the loss function and the optimizer, followed by the training and plotting procedures. That it, he defined the data loader first instead of being before the training procedure.
Can anyone please explain why changing the order of the cells causes such error?

Hm that's weird. I must admit that I've never seen a loss or accuracy plot that looks like a step-wise function. Did you maybe call plt.step instead of plt.plot?

Hi Sebastian, I did several experiments and concluded that there was a problem with the IDE, VS code. I restarted the IDE and my machine, then the code worked as supposed to be.
Thank you so much for your consideration!


Spinbox lags and (thick) lines are not drawn correct

Using the v6.0 from 26-june I reported a small issue with the spinbox controller, specifically an editing cursor while selecting a spinbox on a touchscreen. The issue was addressed by kisvegabor, but I did not check it until yesterday. I downloaded the latest v6.0. Now with the same code the spinbox is pretty laggy when selecting and editing values by turning a rotary switch. Not just that, but I also have 6 small line arrays that make up 2x3 arrows with a linewidth of 5, These arrows now either completely vanish, or are garbled up. I use the arrows to indicate which spinbox is selected (they are toggled by the rotary and the selected group):
old situation (v6.0_26jun):
00.00 <<<  00.00  -> left spinbox is selected
00.00  >>> 00.00  -> right spinbox is selected
new situation(v6.0_latest):
00.00          00.00 -> initially (no arrows visible!)
00.00        >00.00                 -> right spinbox selected (some garbled arrow)
        /
0000  \       <00.00                -> left spinbox selected (notice the line above the spinbox)
There seems to be something wrong in the way the screen is build up, and the lag of the spinbox is also weird.
I'm using an STM32R6 (512K/64K)

Could you send a video about the issue(s)?

Sorry for the inconvenience, but today it is all right. I've seen the STM32 behaving strange on the rotary encoder once before (lag/not responding) but after a hard reset this was solved. This was not the case yesterday, but today all seems well. So it's not a code bug after all.

it's not a code bug after all.

Maybe not in LittlevGL, but usually if hardware works after a reset, it means something is wrong somewhere.

Anyway, I think this issue can be closed.
If finally, you will conclude that it's related to LittlevGL, please comment here and reopen the issue.


Generics not extending on enum values

Generics not extending on enum values

Dart SDK Version:
2.19.0

Whether you are using Chrome, Safari, Firefox, Edge:
Chrome Version 109.0.5414.120
https://dartpad.dev/?

This code is not compiling with the following error:
Uncaught Error: TypeError: Closure 'main_closure': type '(E<num>) => A<num>' is not a subtype of type '(E<dynamic>) => A<num>'

Code:
void main() {
  final list = [...E.values.map((e) => A(e))];
  for (final a in list) {
    print('$a');
  }
}

class A<T extends num> {
  const A(this.e);

  final E<T> e;

  @override
  String toString() {
    return 'A<$T>(e: $e)';
  }
}

enum E<T extends num> {
  a<int>(),
  b<double>(),
  c<num>();

  const E();

  @override
  String toString() {
    return 'E<$T>';
  }
}

But if we remove the generics extension like this:
void main() {
  final list = [...E.values.map((e) => A(e))];
  for (final a in list) {
    print('$a');
  }
}

class A<T> {
  const A(this.e);

  final E<T> e;

  @override
  String toString() {
    return 'A<$T>(e: $e)';
  }
}

enum E<T> {
  a<int>(),
  b<double>(),
  c<num>();

  const E();

  @override
  String toString() {
    return 'E<$T>';
  }
}

It all runs with this output:
A<dynamic>(e: E<int>)
A<dynamic>(e: E<double>)
A<dynamic>(e: E<num>)

Is this intended behaviour?

Shouldn't values be at least a list with the generics for the base class for T?
Shouldn't A instances have picked up the generics from the given parameters?

This looks like a code generation bug:
void main() {
  // int i = E.values; // A value of type `List<E<num>>` can't ...
  print(E.values.runtimeType); // Prints 'JSArray<E<dynamic>>'.
}

enum E<T extends num> { a<int>(), b<double>(), c<num>() }

@johnniwinther, is it a CFE thing that E.values has static type argument E<num> and dynamic type argument E<dynamic>, or could it be caused by one or more backends?
It is in principle a soundness violation when the dynamic type is a proper supertype of the static type, but when the list is immutable it is probably not possible to demonstrate an unsound state.

As for my last question, if you do this fixed like the following:
final a = A(E.a);
print('$a');

The output is:
A<int>(e: E<int>)

Why is it that when I'm doing through the E.values it gets <dynamic> even when the final E e; is let's say <int>?

The way you create the A objects in final list = [...E.values.map((e) => A(e))];, the A will use the type argument used for the E.values field, so with the fix it will be A<num> in all cases. If you do a direct A(E.a) then the type will be A<int>.


Add gcc-4.8 to rhel scripts

Signed-off-by: Joe deKoning<EMAIL_ADDRESS>

I want to test this against rhel7, so please don't merge as yet.  Feedback welcome though as always.

Pull no longer required... This playbook has been replaced by AdoptOpenJDK_Linux_Playbook
In which your changes were added


Idea: Immutable lists with modifications returning new lists - look into Relaxed Radix Binary Trees

Google searching mentioned Relaxed Radix Binary Trees, an immutable datastructure surprisingly claiming performance near arrays in most operations.
https://hypirion.com/musings/thesis https://github.com/hyPiRion/c-rrb

gc may be difficult, immutable lists should either contain ranges of values or other immutable lists?
once a reference count drops to 1 (the container is the only reference) lists can be extracted and reused (and unused elements can be garbage collected)?

Those are technically logarithmic, the log depth is just small for realistic amounts of memory (only several times slower than arrays in that language).
Transients are a lot less convenient in php.
PHP's gc algorithm also poses unique problems - gc will be slow if a lot of immutable collections reference the same array
Something simpler that would have okay typical-case but worse worst-case performance: Storing references to at most 4 zend_array (packed list) instances/ImmutableList/individual zvals internally (and ranges of those arrays) may work for some common use case, for the head/tail for appending/prepending, combining them in place/freeing internally when reference counts drop to 1


descriptor calculation error module 'numpy' has no attribute 'float'

Description:
I tried to run an example from the mordred documentation page but got into error showing "module 'numpy' has no attribute 'float'."
code:
from rdkit import Chem
from mordred import Calculator, descriptors
calc = Calculator(descriptors, ignore_3D=True)
len(calc.descriptors)
len(Calculator(descriptors, ignore_3D=True, version="1.0.0"))
mol = Chem.MolFromSmiles('c1ccccc1')
abc=calc(mol)
print(abc[0].error)
output:
module 'numpy' has no attribute 'float'.
np.float was a deprecated alias for the builtin float. To avoid this error in existing code, use float by itself. Doing this will not modify any behavior and is safe. If you specifically wanted the numpy scalar type, use np.float64 here.
The aliases was originally deprecated in NumPy 1.20; for more details and guidance see the original release note at:
https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations
my environment:
python --version
Python 3.11.3
numpy 1.24.3
I am not sure if i have mistake somewhere and i am new to mordred.
Would appreciate any comments or suggestions.
Rgds
Kit

Numpy < 1.20 should work I think. Installing using conda will probably pickup the correct numpy dependency.

Using the community version of Mordred fixed this issue for me mordred-community and can be installed from PyPI: pip install mordredcommunity


Salt quality and Hash max length

Two quick questions

What should I use for my salt, can I use any type of character and whats the recommended length?
I was planning to store this in the database, how many characters should I account for in worst case scenarios?

The salt length is totally up to you (or whoever is hashing the values). The salt could be a single character, could be a million characters, could be no characters.

How are you generating the numbers to create the hash?
Unless you want to save the generated hashes in case something changes (like the salt or the algorithm), you may not need to store them in the first place.

BTW, if you will store them, figure out what the biggest number(s) you'll send to the encode function will be. if you're using x-bit numbers, look here
Otherwise, however you're generating the numbers need to be used.

The numbers I'm hashing is actually a SQL ID for records. I use it all the time so I considered storing this in the database.
Would 32 characters recommended? I understand it's up to me but would like to know what you would use best trade off between performance / security.
Thanks for the prompt response :+1:

Note that Hashids are not cryptographically secure. (they are just obfuscated values)
The length of the salt does not affect the length of the resultant hashid (it is just used to randomize the alphabet in use). The length of the hash ID is related to the number of values stored in the hashid, the size of the numbers stored, and the length of the alphabet used for encoding.
One test you can do is pick the largest number possible for each value that you may have, and generate a Hashid and measure the string length.  You can also use the min hash length parameter to increase this size.
One note about storing hashids in some databases is that the database field may be case-insensitive.  i.e. FooBar and FOObar and FoObAR are considered the same string.  Select a binary field type/coalition to make sure the field is case sensitive, or use an alphabet with only lower case character or only upper case characters.

Hi @newtonianb, sorry for late response. Looks like the guys have already answered it all!
To reiterate on what @tmorehouse and @miquelfire have said:

The salt characters and length is up to you, honestly makes little difference what you use -- just be sure it's something unique to you / your project. As an example, here's one of the salts I use on my own project: Sup3r--SecreT__s4lt
Id length depends on the size and the number of integers you decide to encode into one id, so encode the largest number(s) and see what length you get. If you decide that 32 characters is enough, use that. I wouldn't worry about performance too much, if you decide to use 255 characters for that column, it'll hardly make a dent for your SQL database, performance-wise.

A quick example link regarding case-sensitivity that @tmorehouse is talking about: https://github.com/ivanakimov/hashids.php/issues/22