Disjoint arrays

Solution 2 for #660 which pre-parses ERC type names and provides expansion information to the render functions. Works great with a few SVDs from the Renesas RA DFP which tend to use disjoint arrays quite frequently.

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @reitermarkus (or someone else) soon.
Please see the contribution instructions for more information.

Let's make release before merging this. @Emilgardis ?

rebase, please

I know re-writing history that is publicly available is generally bad practice, but there were a number of conflicts with master that needed to be resolved in order to rebase.

I know re-writing history that is publicly available is generally bad practice

we generally approve of doing that in prs, especially since thats when you have the opportunity, feel free to squash the commits, for now it's fine though as we're still reviewing this

I found an issue with the check_erc_reprs function when there are registers that use derivedFrom intermingled with registers that could be matched to a disjoint array

I also think the include_info fields of Repr could be simplified by instead utilizing the derived_from field of an erc, which I'd like to do before merging. Should I move this PR to a draft or is it ok for now?

convert it to a draft if you feel there's more to be done 👍🏼

Hey everyone I reworked this to take advantage of the deriveFrom system and I think the logic is a bit easier to follow. Essentially instead of selectively including the register info, I'm allowing regex matched registers to implicitly deriveFrom others. I need to update some of the comments yet, but I'm running into an issue where derived registers each append a pub use <derived_name> in the library, causing a a bunch of rustc error[E0255]: the name <derived_name> is defined multiple times. Here's an example elc.rs.txt generated from R7FA2A1AB.svd.

I think the derive info method is preferable as it adds the least complexity. Let me know and I can squash out the old Representation method.

cc @Emilgardis something with CI

Sorry for the late change, but I found some cases where deriving two arrays with the same name, but different dim_indexes caused naming collisions. I also squashed insignificant commits.

yet one rebase on master, please

Could you also show examples of source -> generated code?

Happy to share some examples. Here's a patched source from the Renesas FSP r7fa2a1ab.svd.patched. Patch addressed some enumeratedValues issues only. The file includes both explicit deriveFrom keys as well as some registers which the PR identifies as ImplicitDerive. The first interesting generated file contains instances handling ImplicitDerive cases: elc.rs. This file is quite long but illustrates good handling of multiple deriveFrom keys where the registers are arrays and the PR renames them to avoid name collisions: pfs.rs. Specifically one instance of P40%sPFS derives from P000PFS  while another derives from P407PFS. You can find other sources in PAC project I'm working on: https://github.com/ra-rs/ra. I'm just waiting on this PR to push PACs for many of the SVDs.

ok. LGFM now.
Fix changelog

Could you also check issues: https://github.com/rust-embedded/svd2rust/issues/283, https://github.com/rust-embedded/svd2rust/issues/169 and https://github.com/rust-embedded/svd2rust/issues/357 ?

After merging, this might be a good opportunity to improve/expand the CI a bit by adding tests against one or more of the Renesas SVDs I've referenced since they exercise this feature extensively. Not sure how that's accomplished but I'm happy to help.

Fixed a comment typo when I did a find/replace:
-    // Locate conflicting regions; we'll need to use unions to derive_infoesent them.
+    // Locate conflicting regions; we'll need to use unions to represent them.

Also cleaned up / reverted some debug items:

Click to expand
--- a/src/generate/peripheral.rs
+++ b/src/generate/peripheral.rs
@@ -1227,7 +1227,6 @@ fn render_ercs(
             RegisterCluster::Register(reg) => {
                 trace!("Register: {}, DeriveInfo: {}", reg.name, derive_info);
                 let mut rpath = None;
-                let before_name = reg.name.to_string();
                 if let DeriveInfo::Implicit(rp) = derive_info {
                     rpath = Some(rp.clone());
                 } else {
@@ -1236,14 +1235,14 @@ fn render_ercs(
                         rpath = derive_register(reg, &dpath, path, index)?;
                     }
                 }
+                let reg_name = &reg.name;
                 let rendered_reg =
                     register::render(reg, path, rpath, index, config).with_context(|| {
                         let descrip = reg.description.as_deref().unwrap_or("No description");
                         format!(
-                            "Error rendering register\nName: {before_name}\nDescription: {descrip}"
+                            "Error rendering register\nName: {reg_name}\nDescription: {descrip}"
                         )
                     })?;
-                reg.name = before_name;
                 mod_items.extend(rendered_reg)
             }
         }

bors r+


Reduce garbage produced every update

Hi, after some profiling found that this library produces quite some garbage every frame/update.

so what I did is to cache ControllerButton.values() and ControllerAxis.values() for the update methods, since those were creating new arrays all the time. (some JVMs might be able to correctly optimize this, but the one I profiled did not)
also the line axisState.put(id, value); was causing the values to be boxed to new Floats every update, so I introduced a simple wrapper class with a mutable float, which does not create any garbage

This only covers the desktop version, similar optimizations could be made for other platforms probably.
IDK if this can be merged as-is, but would love to hear about any suggestions or doubts.

Forgot about this one, sorry, but finally made the changes.


Add license info to /tests and README_TH.md

Add SPDX license info to /tests
Translate license info in README_TH.md
Add NLP-OSS 2023 paper to README_TH.md
Fix test_corpus.py to use revised function names of thai_volubilis_words and thai_wikipedia_titles

coverage: 86.025% (+1.9%) from 84.103%
when pulling 723ba01b9aa83a6e9aaf95a343f2fc921805b3a5 on bact:dev
into 1f4a39ed5065c12483bafdd64180c7c4adf1087d on PyThaiNLP:dev.


New version not available via pod

It seems that new version (1.1) is not available via cocoapods

@ekscrypto, up

@ekscrypto, could you run pod trunk push for updating pod spec on cocoapods spec repositories?


[WIP] add f5 lbaasv2

This is against master.

Can one of the admins verify this patch?

"ok to test" to accept this pull request for testing
"test this please" for a one time test run
"add to whitelist" to add the author to the whitelist

Can one of the admins verify this patch?

"ok to test" to accept this pull request for testing
"test this please" for a one time test run
"add to whitelist" to add the author to the whitelist

Can one of the admins verify this patch?

"ok to test" to accept this pull request for testing
"test this please" for a one time test run
"add to whitelist" to add the author to the whitelist

@nirajdp76, would you please review the PR? Thanks.

@nirajdp76, thanks a lot for your details comments. That really help. I updated the commit with all your comments except two places. Please let me know if you have more comments. Thanks.

one for downloading and unachiving f5.tgz. That is just to overwrite few code related to f5 as one in upstream is out of date. I also suggest to these these steps to giftwrap so that we don't need to do these steps for a package install.

keep two blocks in  roles/neutron-data-network/tasks/main.yml due to clear readability.

@nirajdp76  Hi Niraj, please review. Thanks.

Closing old, unneeded PRs


Update blog app

Solve #54
PR should solve all three sub-problems.

Looks great now!
If you want to continue, you can try to add syntax highlighting using Pygments. You might not get colors on your first try, if that's the case, look at the HTML code to see if code is highlighted. CSS can be added in the next step.

I've just tried to add highlight syntax. I hope that's how you imagine.
file pygments.css was created by doc:
$ pygmentize -S default -f html > style.css
link to doc - command find at the end
and than add stylesheet to base.html:
<link rel="stylesheet" type="text/css" href="/path/to/pygments.css">
I would be glad if you explain class MyRender() in stream. Because I take this class from documentation but I don't understand this class very well. Thank you

Change name of class MyRender to HighlightRender by the documentation.
Create new pygments.css file with command:
$ pygmentize -f html -S colorful -a .syntax > pygments.css


Plugin with menu and codegen doesn't work

Hi @yuanqing,
First of all thanks a lot for creating such a useful toolkit!
Here is my issue. I have an existing plugin which has a menu with a number of features that can be launched from it. Now, I'd like to add a codegen feature for my plugin. I've added all the necessary fields to the package.json
{
  "dependencies": { },
  "devDependencies": { },
  "scripts": {
    "build": "build-figma-plugin --typecheck --minify",
    "watch": "build-figma-plugin --typecheck --watch"
  },
  "figma-plugin": {
    "editorType": [
      "figma",
      "dev"
    ],
    "id": "...",
    "name": "...",
    "capabilities": [
      "codegen"
    ],
    "codegenLanguages": [
      {
        "label": "Typescript",
        "value": "typescript"
      }
    ],
    "main": "src/main.ts",
    "menu": [
      {
        "name": "Feature 1",
        "main": "src/feature1/main.ts",
        "ui": "src/feature1/ui.tsx"
      },
      {
        "name": "Feature 2",
        "main": "src/feature1/main.ts",
        "ui": "src/feature2/ui.tsx"
      },
      {
        "name": "Feature 3",
        "main": "src/feature1/main.ts",
        "ui": "src/feature3/ui.tsx"
      }
    ]
  }
}

I can see my plugin in a Dev Mode in codegen section, but whenever I select something it fails with exception.
figma_app.min.js.br:5 TypeError: modules[commandId] is not a function
    at Proxy.eval (/file/ReoMftOwDV6u2NEV2nHBQQ/PLUGIN_2_SOURCE:5547:19)
    at Object.eval (eval at createScopedEvaluatorFactory (aaded2e9-ae4b-4139-94d3-bc13678f3004:1:6906), <anonymous>:8:16)
    at aaded2e9-ae4b-4139-94d3-bc13678f3004:9:1235
    at aaded2e9-ae4b-4139-94d3-bc13678f3004:9:1908
    at realmEvaluate (aaded2e9-ae4b-4139-94d3-bc13678f3004:9:10651)
    at eval (eval at createCallAndWrapError (aaded2e9-ae4b-4139-94d3-bc13678f3004:1:1794), <anonymous>:1:615)
    at Realm.evaluate (aaded2e9-ae4b-4139-94d3-bc13678f3004:1:1291)
    at MZo.evalCode (figma_app.min.js.br:654:5024)
    at MZo.evalTopLevelCode (figma_app.min.js.br:654:5269)
    at figma_app.min.js.br:1810:178
(anonymous) @ figma_app.min.js.br:5

commandId in that case is a string 'generate'
As a workaround I was able to patch the generated build/main.js by taking in account 'generate' command which comes from figma.command:
  var modules = {
    'src/main.ts--default': (init_main(), __toCommonJS(main_exports))['default'],
    'src/feature1/main.ts--default': (init_main2(), __toCommonJS(main_exports2))['default'],
    'src/feature2/main.ts--default': (init_main3(), __toCommonJS(main_exports3))['default'],
    'src/feature3/main.ts--default': (init_main4(), __toCommonJS(main_exports4))['default']
  };

  // THIS IS THE LINE I PATCHED BY ADDING ' || figma.command === "generate"'
  var commandId = typeof figma.command === "undefined" || figma.command === "" || figma.command === "generate" ? "src/main.ts--default" : figma.command;

  modules[commandId]();

I am wondering if this can be fixed on official level.
Thanks!

I've created a PR with a potential fix

Can you share a GitHub repo with a minimal reproduction of the issue?

Here is the minimal plugin which reproduces the issue
figma_plugin_repro.zip

Possible to put the files in that zip as either a repo or a GitHub gist? Thanks!

Thanks! Can confirm that this is a bug


Add (optional) rule to check consistency of indentation?

Thank you for luacheck! It is a very nice tool.
Are you interested in adding a rule to check that indentation is consistent; for example, that only tabs or only spaces are used? Probably this would be disabled by default, to avoid breaking existing users.
If you like the idea, I would be happy to send a PR.
FYA @alerque

Personally I think this is the wrong tool for the job. Conceptually I think a language linter looking for coding errors should completely ignore anything remotely user-preference or style related. Any valid language syntax should be fair game. Separately a different tool (or possible completely different run time mode of a common tool) could look at the coding style and lint, suggest, or just outright format to taste. This would facilitate CI jobs where style vs. syntax and logic issues were treated differently, style was or was not enforced, etc. Also the kind of options that go into what to allow in a language are fundamentally different from what to allow for style (in my view).
Personally for things like enforcing indentation and checking for mixed space/tab usage I use editorconfig rules and editorconfig-checker for linting (other tools like eclint exist too).
That being said there is not another Lua specific tool (or mode) that handles style robustly at this time and there is precedent for whitespace handling rules mixed in the liter (e.g. https://github.com/lunarmodules/luacheck/blob/master/src/luacheck/stages/detect_bad_whitespace.lua) so I guess I don't have solid reason to object to that ruleset being expanded/improved.

Thanks for those thoughtful comments.
If the maintainers want this feature, I am available to help implement it; but if they don't want it, that is fine.

for example, that only tabs or only spaces are used?

Were you thinking this would be a line-wise, file-wise, or project-wise consistency check?

I was thinking that if a user wants to use the check, they would put something in their configuration like:
indent = 'tabs'

...And then luacheck would perform the check on any file it scans.

Or maybe the configuration might be something like this?
indent = { type='spaces', width=4 }

Or else:
indent_type = 'spaces'
indent_width = 4

the EmmyLuaCodeStyle support this feature，it supports the use of language server, lua lib, and command-line tools in three ways

the EmmyLuaCodeStyle support this feature，it supports the use of language server, lua lib, and command-line tools in three ways

Thanks for mentioning that.

Thank you for luacheck! It is a very nice tool.
Are you interested in adding a rule to check that indentation is consistent; for example, that only tabs or only spaces are used? Probably this would be disabled by default, to avoid breaking existing users.
If you like the idea, I would be happy to send a PR.
FYA @alerque

خههههخههالللالللللللل


v0.2.1 release

Adds in tiny fix for ruby version file and cuts version with STP fixes and CI

Can any two of @mankind / @mrdaniellewis / @adriana-rus / @celonicolosi / @baseonmars give this a quick review. It's just getting ready to cut a patch version and tidy up a ruby version mismatch

Can any two of @mankind / @mrdaniellewis / @adriana-rus / @celonicolosi / @baseonmars give this a quick review. It's just getting ready to cut a patch version and tidy up a ruby version mismatch


add healthdata.gov signals on hospitalizations

We are hoping to migrate the teams doing the hospitalization forecasting challenge at the COVID-19 Forecast Hub over to using the datasets recently (in the last few days) made publicly available at the link below.
Note API links on left-hand panel down the page a bit:
https://healthdata.gov/dataset/covid-19-reported-patient-impact-and-hospital-capacity-state-timeseries

I recommend scraping this as a new data source in epidata, in a new database table. If there are specific indicators to derive from this, I recommend computing those separately and storing them in the existing covidcast table.

Just to note, the API links on the healthdata.gov page are for the metadata only, not the dataset itself. We'll probably need to write a scraper to harvest the CSV link from the page.

In case it's useful, this snippet of code was shared with me as an access to the data:
data.table::fread(
  jsonlite::fromJSON(
    "https://healthdata.gov/api/3/action/package_show?id=83b4a668-9321-4d8c-bc4f-2bef66c49050&page=0")$result$resources[[1]]$url
  )

Right -- that's the metadata query.

when I run this I see the actual data in my R session.

I stand semi-corrected: the query url https://healthdata.gov/api/3/action/package_show?id=83b4a668-9321-4d8c-bc4f-2bef66c49050&page=0 returns the metadata, and the metatdata includes the url for the csv file at https://healthdata.gov/sites/default/files/reported_hospital_utilization_timeseries_20201115_2134.csv. Fair enough!

it ain't pretty, that's for sure.

Moving this to epidata for @dfarrow0 to add the full dataset as a separate endpoint. Once that's done, we'll bounce it back here for covidcast support.


Feature request: dask.dataframe support

Dask dataframes (https://docs.dask.org/en/latest/dataframe.html) are essentially partitioned and out-of-core pandas dataframes.
It would be great to support this for large datasets/remote data/and/or use a cluster to speed up the profiling.

I do some work  in dask these days and would be interested in investigating adding this.  Has anyone started this?

@kyprifog Feel free, would be a great addition. We have spark support in progress (see PRs), which should help to generalize to multiple engines. The best way to reach us is on Slack (see link on top of readme)


[.NET WPF] Crash on nested show cards

Platform
What platform is your issue or question related to? (Delete other platforms).

.NET WPF

Issue
If a card has nested show cards, clicking on the second one crashes (JS can handle this):

  "type": "AdaptiveCard",
  "version": "1.0",
  "body": [
    {
      "type": "ActionSet",
      "actions": [
        {
          "type": "Action.ShowCard",
          "title": "Action.ShowCard",
          "card": {
            "type": "AdaptiveCard",
            "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
            "actions": [
              {
                "type": "Action.ShowCard",
                "title": "Action.ShowCard",
                "card": {
                  "type": "AdaptiveCard",
                  "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
                  "actions": [
                    {
                      "type": "Action.ShowCard",
                      "title": "Action.ShowCard",
                      "card": {
                        "type": "AdaptiveCard",
                        "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
                        "body": [
                          {
                            "type": "TextBlock",
                            "text": "New TextBlock"
                          }
                        ]
                      }
                    }
                  ]
                }
              }
            ]
          }
        }
      ]
    }
  ],
  "$schema": "http://adaptivecards.io/schemas/adaptive-card.json"
}

UWP also has issues with this card #3177

@nesalang this is now approved and yours to drive! thanks


ffmpeg编译报错

编译的时候提示：
./configure: line 1: pr: not found
libavdevice/avdevice.c: In function 'device_next':
libavdevice/avdevice.c:88:13: warning: 'av_oformat_next' is deprecated [-Wdeprecated-declarations]
if (!(prev = av_oformat_next(prev)))
^~
In file included from libavdevice/avdevice.h:51:0,
from libavdevice/avdevice.c:23:
./libavformat/avformat.h:2088:17: note: declared here
AVOutputFormat *av_oformat_next(const AVOutputFormat *f);
^~~~~~~~~~~~~~~
libavdevice/avdevice.c:92:13: warning: 'av_iformat_next' is deprecated [-Wdeprecated-declarations]
if (!(prev = av_iformat_next(prev)))
^~
In file included from libavdevice/avdevice.h:51:0,
from libavdevice/avdevice.c:23:
./libavformat/avformat.h:2080:17: note: declared here
AVInputFormat  *av_iformat_next(const AVInputFormat  *f);
^~~~~~~~~~~~~~~

Hi @bywei,
Are you referring to the compile warnings? I tried re-compiling and it works. There's usually a lot of warnings, but shouldn't affect the code.


Store composition seems to clobber original store value

Description
New to Zedux so this could be user error, but calling store.use seems to clobber the initial state originally set on the store.
Example: https://github.com/marbemac/zedux-use-bug/blob/main/src/App.tsx
When the component is rendered:

Reproduction
Repro: https://github.com/marbemac/zedux-use-bug

@marbemac This is expected, but you've made me realize: The new store docs have no mention of this 😬 . The old docs had this (clearly important) line:
:::important
Each store should only use one core pattern - either the Zero Config or Reducer pattern. A store can contain other stores that use different patterns, but it shouldn't use both patterns itself.
:::

(can see when it was added 4 years ago here, I haven't tracked down where we took it out yet).
I will make sure to get that in the new doc somewhere prominent. The gist is: Stores can be either zero-config or controlled, not both. Composed stores are "controlled" by their child stores/reducers.
Here's an example of what your code could look like, addressing your TS note too:
const childAtom = atom('child', ({ groupId }: { groupId: string }) => {
  const parent = injectAtomInstance(parentAtom, [{ groupId }]);

  const ownStore = injectStore<{ childId: string; parentValue?: string }>({
    childId: 'some-id',
  });

  const composedStore = injectStore(() =>
    createStore({ ownValue: ownStore, parentValue: parent.store })
  );

  composedStore.use({ ownValue: ownStore, parentValue: parent.store });

  return composedStore;
});

Let me know if that makes sense, sorry about the doc mixup.

Ah yeah ok I see, thanks! Definitely feels a bit unintuitive / awkward, but I noticed in the signals RFC that you're looking to solve this with injectMappedSignal which does indeed look much more intuitive.

Wait actually doesn't this mean that the returned store:

Now has childId nested under ownValue e.g. store.ownValue.childId. Not the end of the world of course, can adjust to nest "own store" properties under their own key in the returned store.
Has both store.ownValue.parentValue and store.parentValue - does it matter which is used?

Signals will improve this a lot, removing the redundant .use call and the verbose injectStore(() => createStore()). With stores though, btw, you can prevent extra nesting by creating stores for individual keys. For example:
const childAtom = atom('child', ({ groupId }: { groupId: string }) => {
  const parent = injectAtomInstance(parentAtom, [{ groupId }]);

  const childIdStore = injectStore('some-id');

  const composedStore = injectStore(() =>
    createStore({ childId: childIdStore, parentValue: parent.store })
  );

  composedStore.use({ childId: childIdStore, parentValue: parent.store });

  return composedStore;
});

Thanks! All works, will close this out. Looking forward to the signals work :).


How to enable CORS?

I trie to use this module for my API. But from Vue or apollo client, I have the following error:
 – "Network error: Origin http://localhost:8080 is not allowed by Access-Control-Allow-Origin."
How I Can enable cors to Apollo Server Module?

This has nothing to do with Apollo Server. You can allow CORS for example with an htaccess directive:
https://stackoverflow.com/a/20838470

@MrSnoozles thanks


Do not paging

Do not works the paging, always load the same first data.
What versions do you use to paging?
Your example do not works too. Are you try the paging and works?

+1 Paging doesn't seem to work.

This happened to me and it was because of a problem with the datatables library. Make sure that you have all the necessary javascript references to datatables on your template.


systemctl reload causes Prosody to read wrong configuration file

I'm using the Prosody module with this configuration. When I do systemctl restart prosody.service, everything works as expected:
Okt 31 14:22:13 hostname systemd[1]: Stopped Prosody XMPP server.
Okt 31 14:22:13 hostname prosody[11963]: socket: try to close server with id: 28179a0
Okt 31 14:22:13 hostname prosody[11963]: socket: closing client with id: 28179a0 server to close
Okt 31 14:22:13 hostname prosody[11963]: general: Shutting down...
Okt 31 14:22:13 hostname systemd[1]: prosody.service: Consumed 286ms CPU time, received 24.1K IP traffic, sent 19.6K IP traffic.
Okt 31 14:22:13 hostname prosody[11963]: general: Shutdown status: Cleaning up
Okt 31 14:22:13 hostname prosody[11963]: general: Shutdown complete
Okt 31 14:22:17 hostname systemd[1]: Starting Prosody XMPP server...
Okt 31 14:22:17 hostname prosody[13882]: mod_posix: Prosody is about to detach from the console, disabling further console output
Okt 31 14:22:17 hostname prosody[13884]: mod_posix: Successfully daemonized to PID 13884
Okt 31 14:22:17 hostname prosodyctl[13881]: Started
Okt 31 14:22:17 hostname systemd[1]: Started Prosody XMPP server.

However, when I do systemctl reload prosody.service instead (as one would like to do e.g. when rolling over to a new TLS cert in security.acme.certs.${domainName}.postRun), it says this instead:
Okt 31 14:13:39 hostname systemd[1]: Reloading Prosody XMPP server.
Okt 31 14:13:39 hostname prosody[11963]: mod_posix: Received SIGHUP
Okt 31 14:13:39 hostname systemd[1]: Reloaded Prosody XMPP server.
Okt 31 14:13:39 hostname prosody[11963]: startup: Reloading configuration file
Okt 31 14:13:39 hostname prosody[11963]: certmanager: Searching /nix/store/yq9k33s4n50rrfp1vxqyxxm5q9d3sjhw-prosody-0.11.2/etc/prosody/certs for a key and certificate for example.com...
Okt 31 14:13:39 hostname prosody[11963]: certmanager: No certificate/key found for example.com
Okt 31 14:13:39 hostname prosody[11963]: certmanager: Searching /nix/store/yq9k33s4n50rrfp1vxqyxxm5q9d3sjhw-prosody-0.11.2/etc/prosody/certs for a key and certificate for com...
Okt 31 14:13:39 hostname prosody[11963]: certmanager: No certificate/key found for com
Okt 31 14:13:39 hostname prosody[11963]: certmanager: Searching /nix/store/yq9k33s4n50rrfp1vxqyxxm5q9d3sjhw-prosody-0.11.2/etc/prosody/certs for a key and certificate for example.com...
Okt 31 14:13:39 hostname prosody[11963]: certmanager: No certificate/key found for example.com
Okt 31 14:13:39 hostname prosody[11963]: certmanager: Searching /nix/store/yq9k33s4n50rrfp1vxqyxxm5q9d3sjhw-prosody-0.11.2/etc/prosody/certs for a key and certificate for com...
Okt 31 14:13:39 hostname prosody[11963]: certmanager: No certificate/key found for com
Okt 31 14:13:39 hostname prosody[11963]: certmanager: Searching /nix/store/yq9k33s4n50rrfp1vxqyxxm5q9d3sjhw-prosody-0.11.2/etc/prosody/certs for a key and certificate for example.com...
Okt 31 14:13:39 hostname prosody[11963]: certmanager: No certificate/key found for example.com
Okt 31 14:13:39 hostname prosody[11963]: certmanager: Searching /nix/store/yq9k33s4n50rrfp1vxqyxxm5q9d3sjhw-prosody-0.11.2/etc/prosody/certs for a key and certificate for com...
Okt 31 14:13:39 hostname prosody[11963]: certmanager: No certificate/key found for com

I'm not entirely sure why it's trying to read from /nix/store/yq9k33s4n50rrfp1vxqyxxm5q9d3sjhw-prosody-0.11.2/etc/prosody/certs when I've set it up to read from /var/lib/prosody/certs in my configuration. My hypothesis is that it's reading /nix/store/yq9k33s4n50rrfp1vxqyxxm5q9d3sjhw-prosody-0.11.2/etc/prosody/prosody.cfg.lua instead of /etc/prosody/prosody.cfg.lua, because the former references the certs directory that Prosody is looking at.
Metadata

system: "x86_64-linux"
host os: Linux 4.19.80, NixOS, 19.09.976.c75de8bc12c (Loris)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.3
channels(stefan): ""
channels(root): "nixos-19.09.976.c75de8bc12c, nixos-unstable-20.03pre198214.4cd2cb43fb3"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:
- services.prosody

@majewsky can you check if this is still the case on master? There have been some changes in the meantime.
Also cc @petabyteboy due to 24d5e30b5fcbcd27121047ed210f506273755832.

Yes, I can reproduce on the 20.03 channel. Last nixos-rebuild switch --update succeeded this morning.

@NinjaTrappeur, can you take a look at this?

:+1: I'll have a look tonight.

First of all, thanks for the detailed report Stefan.
We recently heavily reworked this module (more details in
https://github.com/NixOS/nixpkgs/pull/86067 and in the unstable
manual),
that being said, we did not back-ported these changes to 20.03, they
are currently living only in unstable.
I cannot reproduce the bug you're experiencing on unstable. That being
said, I did manage to reproduce this on 20.03. While I can see the same
error as you in the logs, the prosody server seems to use the right
certificate. (Note: I performed this repro in a NixOS VM test with a
self-signed certificates.)
The main difference between 20.03 and unstable here seems to be that
20.03 is still pinning prosody 0.11.3 while unstable is pinning 0.11.5.
I just read the 0.11.4 and 0.11.5 changelog, there's no mention of this
behaviour. That being said, this could have been fixed without appearing
in the changelog.
I don't think prosody is loading the builtin conf file
(/nix/store/xxxx-prosody-xxxx/etc/prosody.cfg.lua) in your case.
Instead, I think prosody is trying to load the certificates from the
specified path, using this nix store as a fallback mechanism. Note: I
did not observed this behaviour with the 0.11.5 version.
We reload prosody by sending SIGHUP to the running process using kill -HUP $MAINPID as per suggested in https://issues.prosody.im/280. This
is also what Debian and Fedora are doing, I guess the problem is not
coming from here.
Now, what could you do?
Honestly, I think moving to unstable is the easiest option for you
here. You'll benefit from the module improvement and won't experience
the same bug.
If that's not an option for you, I'd like you to check whether or not
prosody is sending the right certificate to its peers.
In any case, I think we should backport
ce2a2afac79052b2d0286ff32996fe2097f0d8bfb. This version bump shouldn't
introduce any configuration change and may fix this bug. I'll open a
backport PR shortly.

Unrelated Note for OP: you could spare this letsencrypt key dance by
sharing the keys using a specific group:
  security.acme = {
    (snip)
    certs = {
      "example.com" = {
        allowKeysForGroup = true;
        group = "examplecomcertgr";
        (snip)
      };
    };
    (snip)
  };

  users = {
    groups.sslcertgr = {
      name = "examplecomcertgr";
      members = [ "prosody" ];
    };

Backport PR there: https://github.com/NixOS/nixpkgs/pull/88798

@majewsky can you give this PR a try and report back if it changes things?

Moving to unstable is not an option for me unless stuff were actively broken.
With Prosody 0.11.5 on 20.03, the log output for reloading does not reference /nix/store paths anymore, but I still get:
Jun 04 22:59:36 bet systemd[1]: Reloading Prosody XMPP server.
Jun 04 22:59:36 bet systemd[1]: Reloaded Prosody XMPP server.
Jun 04 22:59:36 bet prosody[1081]: mod_posix: Received SIGHUP
Jun 04 22:59:36 bet prosody[1081]: startup: Reloading configuration file
Jun 04 22:59:36 bet prosody[1081]: example.com:tls: Creating context for c2s
Jun 04 22:59:36 bet prosody[1081]: certmanager: Searching /etc/prosody/certs for a key and certificate for example.com...
Jun 04 22:59:36 bet prosody[1081]: certmanager: No certificate/key found for example.com
Jun 04 22:59:36 bet prosody[1081]: certmanager: Searching /etc/prosody/certs for a key and certificate for com...
Jun 04 22:59:36 bet prosody[1081]: certmanager: No certificate/key found for com
Jun 04 22:59:36 bet prosody[1081]: example.com:tls: Creating context for s2sout
Jun 04 22:59:36 bet prosody[1081]: certmanager: Searching /etc/prosody/certs for a key and certificate for example.com...
Jun 04 22:59:36 bet prosody[1081]: certmanager: No certificate/key found for example.com
Jun 04 22:59:36 bet prosody[1081]: certmanager: Searching /etc/prosody/certs for a key and certificate for com...
Jun 04 22:59:36 bet prosody[1081]: certmanager: No certificate/key found for com
Jun 04 22:59:36 bet prosody[1081]: example.com:tls: Creating context for s2sin
Jun 04 22:59:36 bet prosody[1081]: certmanager: Searching /etc/prosody/certs for a key and certificate for example.com...
Jun 04 22:59:36 bet prosody[1081]: certmanager: No certificate/key found for example.com
Jun 04 22:59:36 bet prosody[1081]: certmanager: Searching /etc/prosody/certs for a key and certificate for com...
Jun 04 22:59:36 bet prosody[1081]: certmanager: No certificate/key found for com

However, my client doesn't complain about invalid certs when connecting after the server reload, so either Prosody eventually seems to pick up the correct certificate or it continues with the previous certificate.

Interesting, maybe this is actually the same behavior we have on unstable. I really don't understand what causes it to load a wrong configuration file. prosodyctl is actually wrapped to include a --config parameter.

Okay I found out why I don't have this issue. Back then (tm) when I set up my prosody, I found out that reloading does not update the certificate correctly, so I told my acme client to systemctl restart prosody after a successful renewal. Maybe this is an acceptable workaround for you.

20.03 is marked as EOL since November 27th.
Does that issue still appear in 20.09? @petabyteboy, did you check if only reloading prosody gets it to re-read the new config files?

I'm not 100% sure how to check if the right config file was read. But this is how it looks after a reload:
Dec 02 23:33:46 schinken systemd[1]: Reloading Prosody XMPP server.
Dec 02 23:33:46 schinken prosody[2564]: mod_posix: Received SIGHUP
Dec 02 23:33:46 schinken prosody[2564]: startup: Reloading configuration file
Dec 02 23:33:46 schinken systemd[1]: Reloaded Prosody XMPP server.
Dec 02 23:33:47 schinken prosody[2564]: petabyteboy.de:tls: Certificates reloaded

But then again I never saw bad log messages.

Can you strace prosody while it's during reload, to confirm?

openat(AT_FDCWD, "/etc/prosody/prosody.cfg.lua", O_RDONLY) = 40
fstat(40, {st_mode=S_IFREG|0444, st_size=5256, ...}) = 0

Then I'd say prosody will successfully read our updated configuration file during reload. If it still doesn't pick up updated certs in that config file, that'd be an upstream bug. Let's close this one.


10.0.19043.1288 not supported

Anybody have an ini for 10.0.19043.1288?

The termsrv.dll from here works for now.
My original search: "19043.1288" in:title,body,comments yielded nothing. I guess the search engine does not respect the quotes.
When I researched using: "1288" in:title,body,comments I found the thread. Thank you.
[https://github.com/stascorp/rdpwrap/issues/1557]

@ChasW1: this did not work for me.


Automated Package Upgrade

:tada: This PR is included in version 7.7.394 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


feat(reverseHighlight/reverseSnippet): Implements reverseHighlight and reverseSnippet

This implements reverseHighlight and reverseSnippet.
The file/function containing the logic is getReversedHighlight
It takes the attributeValue from _highlightResult as a parameter and reverse content inside mark tags.
You can try it in the storybook under the Hits section with the names:

with reverseHighlight function
with reverseHighlight helper
with reverseSnippet function
with reverseSnippet helper

If you have any suggestion about the naming/method I've used let me know

I ran into a problem with reverseHighlighting and non alphanumeric characters where I didn't find which logic to follow. I expose below the 3 method I came across so I can get your thoughts on that.
Could you please let me know what you think/which way is the best for you?
Sorry for the low quality post

The actual behavior that autocomplete follows, which leaves any non alphanumeric character bold.

The sibling behavior, where the non alphanumeric character will take the highlighted value of the previous and next element.

The highlight behavior, where it just escape any non alphanumeric characters like the current highlight method.

cc @algolia/instantsearch-for-websites

Thanks for trying out all those options @shortcuts, I'm a fan of the method #2's output, and I think it would be better for highlight itself too.

@shortcuts The "sibling behavior" version is interesting. The only place I find it a bit weird is:

(Model)

[...] where the last ) is bold. It makes me wonder is never highlighting non-alphanumeric characters would make sense.
Have you seen this pattern anywhere else?

@francoischalifour I've never seen this pattern used before and this behavior is the only reason why I have a doubt about it.
I could think of a workaround for the parenthesis where if something inside is highlighted, we remove the highlight on the opening/closing one but that would leave some characters bold like

Before
After

(ModelExample)
(ModelExample)

The thing is that it would add even more computation on top of what's already done

I think the sibling behaviour in that case is actually correct, since you are matching on the rest of the sentence, including that closing parenthesis. I think (ModelExample) looks more "pay attention from here onwards", while (ModelExample) looks like "pay only attention to 'lExample'", which will be odd if there's other highlighted text after this word.
Google's autocomplete seems to try following a sibling behaviour, although it often sees separators as typos and won't highlight the match

You're right, they are also doing it.
I didn't find a good "long sentence in parentheses" to do more tests but that's already a good point.

Here's what I got for the bundle size
 FAIL  ./dist/instantsearch.production.min.js: 65.29KB > maxSize 65.25KB (gzip)
 PASS  ./dist/instantsearch.development.js: 151.83KB < maxSize 160KB (gzip)

You can increase it to 65.5KB then.


python312Packages.deal-solver: use pytest-cov-stub and pytest-xdist

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 364460

x86_64-linux

:white_check_mark: 16 packages built:

python311Packages.deal
python311Packages.deal-solver
python311Packages.deal-solver.dist
python311Packages.deal.dist
python311Packages.icontract
python311Packages.icontract.dist
python311Packages.pylddwrap
python311Packages.pylddwrap.dist
python312Packages.deal
python312Packages.deal-solver
python312Packages.deal-solver.dist
python312Packages.deal.dist
python312Packages.icontract
python312Packages.icontract.dist
python312Packages.pylddwrap
python312Packages.pylddwrap.dist

Thanks!


changed http call to IFTTT to use POST instead of GET

The GET implementation does not support values with spaces. The workaround would have been to percent-escape the value strings (replace spaces with %20, etc.), which is the approach intimated by the urlencode  branch. The HTTPClient library however doesn't includes a method for this, and IFTTTWebhook is not the right place to implement it.
A better approach I believe is to use POST instead of GET, and pass the values as JSON payload. Aside from not having to percent-encode the values, this has the added benefit of dismissing future issues around maximum length for the values, constraints by the size limit of the URL supported by the IFTTT webserver (unknown by me, but certainly limited). POST may also have added security benefits.
A side-effect of this change is the incompatibility of HTTPS POST using the root cert, so I'm proposing to revert to the fingerprint approach which works fine. (The root cert approach worked fine with GET on my ESP2 Dev Module board, possibly an issue with the WiFi library? I didn't dig deeper, fingerprint works.)
This patch, if accepted, resolves issue #8 and renders redundant the outstanding work on urlencode branch.

Hey @14geronimo this looks great, thank you! Sorry for not seeing it (and the issues I just read) sooner, github hasn't been sending me notifications about this stuff :( I need to do a little testing over the next couple of days and then I'll merge.
That's very curious about the root cert issue... I'll look into that too, but I won't hold up merging and updating for it.
Awesome of you to contribute, thanks!


[language bug] some scss properties aren't highlighted correctly

Does this issue occur when all extensions are disabled?: Yes/No
Yes

VS Code Version:
OS Version:

Version: 1.64.2 (user setup)
Commit: f80445acd5a3dadef24aa209168452a3d97cc326
Date: 2022-02-09T22:02:28.252Z
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.22000
Steps to Reproduce:
This is not an issue with the theme this is an issue with the language mode itself. There is no theme scope available for SCSS to fix this inconsistency without affecting other highlighting.

Open an scss file that has a class name with the font property used.
Swap between scss and css highlighting in the bottom right

The SCSS looks like:

The CSS looks like:

Moved to https://github.com/atom/language-sass/issues/290, which is where we get our scss syntax highlighting grammar from.


Add script for checking if a build is RC or not

Part of a larger effort to increase automation in downstream testing.
Given the build version and date, the script checks the official code freeze date and if the build date is over the code freeze date then the build is considered as RC.
python3 utils/scripts/detect_rc.py --smartsheet-token <truncated> --smartsheet-id <truncated> --build-version 2.13.0-Z --build-date YYYY-MM-DDThh:mm:ss.sssssZ

Code freeze for 2.13.0-10 is on <truncated>
The buiild 2.13.0-10 is NOT an RC because created before code freeze date <truncated>
Days remaining from Code Freeze N

This is insane... I don't understand why we don't have a flag in UMB message for this kind of thing...

Closing and moving in another place


Simplify the product vuex store

What is the motivation for adding / enhancing this feature?

The following actions should be moved to the storefront-api or vue-storefront-api to simplify the frontend logic:

[ ] setupVariants
[ ] preConfigureProduct
[ ] setupAssociated + configureGroupedAsync + configureBundleAsync

What are the acceptance criteria

[ ] ...

Can you complete this feature request by yourself?

[ ] YES
[ ] NO

Which Release Cycle state this refers to? Info for developer.
Pick one option.

[x] This is a normal feature request. This should be available on https://test.storefrontcloud.io and then after tests this can be added to next Vue Storefront version. In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
[ ] (Pick this option only if you're sure) This is an important improvement request for current Release Candidate version on https://next.storefrontcloud.io and should be placed in next RC version. In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
[ ] (Pick this option only if you're sure) This is a critical improvement request for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version. In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Additional information

we have a store with products that have over 20k variants - this would be a great improvement for us!


Invalid namespace error since v2.8.0

After upgrading boxstarter from v2.6.41 to v2.8.0 my packer build fails with an invalid namespace error even though the boxstarter package itself is successfully installed.
Chocolatey installed 1/1 package(s). 0 package(s) failed.
See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).
[PACKER-57137FAB]+ Boxstarter finished Calling Chocolatey to install temp_BoxstarterPackage. This may take several minutes to complete... 00:00:48.5624657
[PACKER-57137FAB]Boxstarter: Restore Automatic Updates from Windows Update
True

Errors       : {Invalid namespace }
ComputerName : localhost
Completed    : True
FinishTime   : 4/17/2016 12:26:18 PM
StartTime    : 4/17/2016 12:25:26 PM

I run the following inline powershell in my packer build:
"inline": [
	"$ErrorActionPreference = \"Stop\"",
	"$env:chocolateyVersion = \"<IP_ADDRESS>\"",
	"iex ((new-object net.webclient).DownloadString('https://chocolatey.org/install.ps1'))",
	"cinst boxstarter -y -version 2.8.0",
	"& \"${env:AppData}\\Boxstarter\\BoxstarterShell.ps1\"",
	"Import-Module \"$($Boxstarter.BaseDir)\\Boxstarter.Common\\boxstarter.common.psd1\"",
	"$secpasswd = ConvertTo-SecureString \"{{user `winrm_password`}}\" -AsPlainText -Force",
	"$credential = New-Object System.Management.Automation.PSCredential (\"{{user `winrm_username`}}\", $secpasswd)",
	"Create-BoxstarterTask $credential",
	"$result = Install-BoxstarterPackage -PackageName c:\\packerfile.ps1 -DisableReboots",
	"Remove-BoxstarterTask",
	"$result",
	"if ($result.Errors.Length -gt 0) { exit 1 }",
	"c:\\packerfile.post.ps1",
	"c:\\sysprep.ps1"
]

It turns out it's unrelated to the upgrade, still investigating what causes it.

Anything in the boxstarter log?

Still trying to get the boxstarter.log from the machine - it's deleted automatically in case of failure - but i found it to be working if I pin all the boxstarter dependencies (boxstarter.common, etc) to 2.7.0. Although I pin the boxstarter chocolatey package version it did fetch the latest version for the dependencies. Going to try and bump them to 2.8.0 one by one to find which package causes the error. At the same time I'll try and get the log file.

Things go wrong as soon as I set boxstarter.bootstrapper v2.8.0 (common and winconfig are fine to set to 2.8.0). The only thing related to namespaces I can find is the following https://github.com/mwrock/boxstarter/search?utf8=✓&q=invalid+namespace, but that's in the wrong package. Were there any changes to bootstrapper that could cause this? The boxstarter.log doesn't seem to provide any actionable information, but I'll tidy it up and add it later.

I'm betting its this commit: https://github.com/mwrock/boxstarter/commit/b3193a6c5a5a530822386261b4db823cbdefc10b#diff-cbc2ad1b6dd0488d34c0b5671b0091fbR121
likely line 162. I tested his on 2012R2 and 2k8r2. Just curious what OS are you building?

I'm using Google Cloud image windows-server-2012-r2-dc-v20160413.

One thing that doesn't help - but might not be the cause - is that $ComputerName="$env:COMPUTERNAME" truncates the computer name.

On my work laptop (win 10) I am able to reproduce this:
C:\dev\chef-provisioning-vsphere [master ↑]> $CCMSplat = @{
>>         NameSpace='ROOT\ccm\ClientSDK'
>>         Class='CCM_ClientUtilities'
>>         Name='DetermineIfRebootPending'
>>         ComputerName='localhost'
>>         ErrorAction='Stop'
>>     }
C:\dev\chef-provisioning-vsphere [master ↑]> Invoke-WmiMethod @CCMSplat
Invoke-WmiMethod : Invalid namespace
At line:1 char:1
+ Invoke-WmiMethod @CCMSplat
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: (:) [Invoke-WmiMethod], Manage
   mentException
    + FullyQualifiedErrorId : InvokeWMIManagementException,Microsoft.PowerShel
   l.Commands.InvokeWmiMethod

should be a pretty easy fix.

Cool thanks. Do you have pre-release packages on chocolatey through which I could verify a fix?

I don't typically post prereleases. This particular bug looks easily reproducable and I may be able to get a release out tonight.

I commented on the commit because it seems to break my pending reboot when trying to install Visual Studio 2015 Enterprise on my Windows Server 2012 R2 machine.

ugh. I have a fix here but want to add a test to insure this does not regress again. Hope to get a release out tonight.

its now released thanks to the help of @riezebosch


Setting SyncVar to Same Value Fires Hook on Host Only

Describe the bug
Repeatedly setting a SyncVar to the same value fires the hook only on the host but not on any clients due to a EqualityComparer difference check in NetworkBehavior SetSyncVar().
To Reproduce
Steps to reproduce the behavior:

Load up the Basic example and change UpdateData() to set a fixed value instead of a random.
Turn on debug logging in Network Manager
Play as LAN Host, observe the hook fires every second
Build and run as LAN Host and run client in editor and observe the hook doesn't fire.

Expected behavior
Consistent behavior for Host and connected clients.  Either remove the difference check or move it to where it will be applied to both host and clients (weaver?).
Desktop (please complete the following information):

OS: Windows
Build target: standalone
Unity version: 2018.4.x LTS
Mirror branch: master

Additional context
Discord discussion suggested a flag to bypass the diff check, default to always do the diff check to avoid network traffic spam.

:tada: This issue has been resolved in version 4.1.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Werewolf game modify Common Actions to speak thoughts out loud

make roles to speak their mind while they act

LGTM


Problem with yarn start

Hi, after I update the new of this bot, I got this error when I type "yarn start"
But is okay if I back to using the old one.
I'm not sure about this situation is wrong with my environment or not?
Thank you
The Error Message is:
/home/aliven2023/solana-jupiter-bot/node_modules/yoga-layout-prebuilt/yoga-layout/build/Release/nbind.js:53
        throw ex;
        ^

Error: ENOENT: no such file or directory, open './config.json'
    at Object.openSync (node:fs:585:3)
    at Object.readFileSync (node:fs:453:35)
    at Object.<anonymous> (/home/aliven2023/solana-jupiter-bot/src/cache.js:2:30)
    at Module._compile (node:internal/modules/cjs/loader:1105:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1159:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Module.require (node:internal/modules/cjs/loader:1005:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.<anonymous> (/home/aliven2023/solana-jupiter-bot/src/utils.js:3:15) {
  errno: -2,
  syscall: 'open',
  code: 'ENOENT',
  path: './config.json'
}
error Command failed with exit code 7.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

I was able to reproduce this issue. Will check it soon. Thanks!

I've reopened cuz I'm not sure that You can comment on the closed issue

Hi, I had already tested it, and is all fine right now. 🙂
Thanks

Hi, this problem had shown again after I updated it 3 days ago.

Yeah, I forgot to push changes from my local 🤦


[BUG] User id detection mistake

Nutgram version
3.17.1
Describe the bug
Either i don't understand something or Nutgram detects userId wrong.
In Nutgram::stepConversation userId equal to botId, but when you get currentConversation in ResolveHandlers::currentConversation it detects as valid userId
To Reproduce

Create simple two step conversation
Begin it
In ConversationCache dump userId it will be equal to your botId
Dump same userId while Nutgram trying to restore Conversation it will be equal to userId

Expected behavior
UserId equal to UserId

Screenshots

Additional context
No response

Basically after sending a message userId of client getting replaced with userId of author of last sended message (your bot)

Ok, for now i'll just use explicit call to stepConversation it seems like it fixes all my problems

Can you please post a snippet to reproduce the issue?

`<?php
declare(strict_types=1);
namespace App\Application\Actions;
use SergiX44\Nutgram\Conversations\Conversation;
use SergiX44\Nutgram\Nutgram;
use SergiX44\Nutgram\Telegram\Types\Keyboard\KeyboardButton;
use SergiX44\Nutgram\Telegram\Types\Keyboard\ReplyKeyboardMarkup;
class TestConversation extends Conversation
{
/**
* @param Nutgram $bot
* @return never|void
* @throws \Psr\SimpleCache\InvalidArgumentException
*/
public function start(Nutgram $bot)
{
$bot->sendMessage('To step two', [
'reply_markup' => ReplyKeyboardMarkup::make(resize_keyboard: true, selective: true)
->addRow(KeyboardButton::make('Let's go'))
]);
$this->next('stepTwo');
}
/**
 * @param Nutgram $bot
 * @return void
 */
public function stepTwo(Nutgram $bot)
{
    $bot->sendMessage('start', [
        'reply_markup' => ReplyKeyboardMarkup::make(resize_keyboard: true, selective: true)
            ->addRow(KeyboardButton::make('Let\'s go'))
    ]);
}

}`

<?php

declare(strict_types=1);

namespace App\Application\Actions;

use SergiX44\Nutgram\Conversations\Conversation;
use SergiX44\Nutgram\Nutgram;
use SergiX44\Nutgram\Telegram\Types\Keyboard\KeyboardButton;
use SergiX44\Nutgram\Telegram\Types\Keyboard\ReplyKeyboardMarkup;

class TestConversation extends Conversation
{
    /**
     * @param Nutgram $bot
     * @return never|void
     * @throws \Psr\SimpleCache\InvalidArgumentException
     */
    public function start(Nutgram $bot)
    {
        $bot->sendMessage('To step two', [
            'reply_markup' => ReplyKeyboardMarkup::make(resize_keyboard: true, selective: true)
                ->addRow(KeyboardButton::make('Let\'s go'))
        ]);
        $this->next('stepTwo');
    }

    /**
     * @param Nutgram $bot
     * @return void
     */
    public function stepTwo(Nutgram $bot)
    {
        $bot->sendMessage('start', [
            'reply_markup' => ReplyKeyboardMarkup::make(resize_keyboard: true, selective: true)
                ->addRow(KeyboardButton::make('Let\'s go'))
        ]);
    }
}

Basically it's supposed to throw you from first to second step and than back, but because after sendMessage userId becomes equal to id of your bot your cache_keys becomes invalid and conversation stops

Facinf a similar issue where the callback is not persistent on the request so somehow it forgets to carry data from the user response.

https://user-images.githubusercontent.com/4071613/230741462-252321ae-43ef-49fb-a7ee-56cfa0645255.mp4
Are you sure?


Accesibility error in mobile top navigation with navigation groups

Summary of the bug
The aria-expanded attribute in ic-navigation-group is causing an accessibility failure in storybook & Cypress tests. This is visible when the mobile menu is open
🪜 How to reproduce
Tell us the steps to reproduce the problem:

With the following code in storybook:

<IcTopNavigation
  appTitle="ApplicationName"
  status="alpha"
  version="v0.0.7"
>
  <IcNavigationGroup slot="navigation" label="Navigation Group">
    <IcNavigationItem label="One" href="/" selected />
    <IcNavigationItem label="Two" href="/" target="_blank" />
  </IcNavigationGroup>
</IcTopNavigation>

view on small device size
open the top nav menu
See the error in the storybook accessibility add in tab:

📝 Acceptance Criteria
Given there is a top navigation with navigation groups on a mobile device
When  the side menu is open
Then there should be no accessibility errors
Additional Info
when this issue is resolved, it should be possible to add the check back into the appropriate top navigation cypress test

Closed as duplicate ticket.


MVP

Can we put together a list of tasks to accomplish in order to get an MVP live for the converged project.
It's very difficult to discern what needs to get done or how to get involved based on the current issues/readme. Perhaps this information is embedded somewhere in prior repos but even I can't seem to figure it out.

Are we talking for the website or in general?

Just the website.

Absolute minimum is what's on nodejs.org moved over to our i18n build system, afaik. I'll try to put more of my own time here after I deal with _unrefActive().

I think we should take the time and look at the content and overall structure as well, before we just pull everything over. There are some quirks on the current nodejs website and I think we could get rid of some of the content (or at least restructure it). That would make it easier for the translators as well.

Do we want to engage the Linux Foundation to provide any design resources?

Do we want to engage the Linux Foundation to provide any design resources?

it was suggested by someone else, and I would prefer to ask the community for design ideas before doing anything major.

@Fishrock123 We've already asked for that and even promoted it and didn't get anything usable yet.
I'd like to inject a little bit of urgency in to this. My impression right now is that things are stalled either because we feel blocked on something we can't identify or because there isn't a good starting point for people to pick up at go.
I'm willing to block out some time to migrate the old build system over the current design and to get a new design from the LF that incorporates the new structure (although I'm probably not the best person to implement the design), documents and messaging we want to highlight. Last time the website took off after I threw up some code (quite terrible code) that was an obvious starting point for others to improve.

@mikeal I have some feedback/request about the build system, I'll write a ticket for it later. I'll also put some time into content structure and can help with the implementation of the design as well (as soon as it is available).
I think what's blocking (at least me) at the moment is that it's not yet clear, when we'll have the first "real" merged version of node/io.js and how the convergence is coming along in this part of the project. So is the core team waiting for the website to be finished or is it the other way round? Do we need a go from the foundation first or what exactly is it we are waiting for.

when we'll have the first "real" merged version of node/io.js and how the convergence is coming along in this part of the project

I don't think we need to block on this. If we have a website ready and we don't have converged releases we'll just put up both io.js and node.js releases.

My impression right now is that things are stalled either because we feel blocked on something we can't identify or because there isn't a good starting point for people to pick up at go.

I actually think it's just blocked on people's time.

I actually think it's just blocked on people's time.

This might be a good reason to just have the LF whip something up to move forward on. Once something is up people can still contribute to it via PRs.

No like, I mean time to do the dirty code/build work, the design doesn't even have to change.

ok, i'm gonna start dumping some code in here. it'll be the old build system with a bunch of new code for the proposed taxonomy and some stub content.
to reduce bike shedding i'm going to propose that i just commit this to master and that anyone else who wants to jump in does the same until it starts to solidify. everyone should continue to tweak the copy and style at will for a bit while we work stuff out, if you're wondering about a change then send it as a PR.
thoughts?

ok, i'm gonna start dumping some code in here. it'll be the old build system with a bunch of new code for the proposed taxonomy and some stub content.

Which old build system? I was hoping to dump the one from io.js here (since that's the best start) but It's gotten pushed back.

to reduce bike shedding i'm going to propose that i just commit this to master and that anyone else who wants to jump in does the same until it starts to solidify. everyone should continue to tweak the copy and style at will for a bit while we work stuff out, if you're wondering about a change then send it as a PR.

I'd say have at it basically until it's live-on-commit like iojs.org.

Which old build system? I was hoping to dump the one from io.js here (since that's the best start) but It's gotten pushed back.

Correct, the gulp build system iojs.org uses, not the makefile nodejs.org is using.


Lessons should be prominently visible on the front page

On the old layout, the lessons pages were immediately noticeable in the sidebar.

There was also a link to Basics on the very bottom of the front page.

With the new layout however, the lessons pages are hidden behind a nav bar toggle. A skim of the page does not lead readers to where they want to go. (The sentence saying "you'll find what you need in lessons" won't be seen on first pass. It should also at least contain a link to assist with navigation.)
Some possible ideas:

insert a section between "Welcome to Elixir School!" and "Why Elixir?" to contain a table of contents of the lessons
insert a large button link for Basics to the "Welcome to Elixir School!" section, similar to the button that was on the bottom of the front page before
only on the front page, change the nav bar's Lessons toggle menu to be expanded and uncollapsible, while moving the text sections down, such that "Welcome to Elixir School!" starts halfway down the page (this would only help the non-mobile layout and would probably wouldn't look as good)

Thanks for calling this out @thth! Thoughts @kinson @jaimeiniesta?


[WIP] Don't save incomplete downloaded files

Description
This seems to ensure that no 0-byte files are present. However, clicking stop button still cause some JPEG files to be incomplete while downloading.
CheckDirectoryForFiles option is not visible since 2017, I don't know why.
For coding discussions, any suitable place? Issues, GitHub discussion (not opened, I suggest turning it on and provide some topic), or something else?
Issue Resolution
#257.
Proposed Changes
New or Changed Features
Does this PR provide new or changed features or enhancements? If so, what is included in this PR?

else you can also open an issue, link it if necessary.

Sometimes they are questions or proposals for code changes, refactoring or function change, and I don't really want to pollute real bug reports/feature requests, and it's intrusive for ordinary issues watcher. However, PRs are indeed a good place for a line-by-line review of code.

Maybe we should set up the Discussions thing (to give the users a new forum). As usual, at the end it's not a problem of setting it up, rather the amount of people who will use it...

This PR is stale as there has been no recent activity. It can be reopened if needed.


enableSingleRequest not working on load

enableSingleRequest is not enabled on the initial request. I am seeing individual requests for each ad. Subsequent refreshes have single request enabled
import { DFPSlotsProvider, AdSlot } from 'react-dfp';
...
<DFPSlotsProvider dfpNetworkId={'9999'} adUnit={"foo/bar/baz"} >
    <AdSlot sizes={[ [900, 90], [728, 90]]} />
    <AdSlot sizes={[ [300, 250], [300, 600]]} />
</DFPSlotsProvider>

It looks like load() is being called for each slot

https://github.com/jaanauati/react-dfp/pull/53, I still need to test this a bit more though.... will have news in the following 2-3 days.

@Matt-Lauderdale just pushed v0.7.0 to npm which ships a fix for single-request-mode, can u please give it a try and let me know?


store KB and models to assets dir

Store all assets in assets/. The various codebases (python/, rust/, js/, ...) can then pick up whatever asset they need at their own time (in a manual or automatic manner, via gh actions). This way, we start to decouple the various codebases from the python one.

Also added metadata.json to the model asset dir. This is not needed to run the model and it's not part of the config; it's just metadata to keep track how the model was created / where it comes from. For now, it just contains the hash of the namespace and model_name, as tracked by our training pipeline.

BTW #2: the idea is that the assets for each model contain 1) all the formats we may need for the various codebases (h5/keras, onnx, tfjs), 2) all the info we need to generate documentation about a given model, e.g., which content types are supported.

This is related to #640.

We should have made the thresholds a different PR. They are wrong. A lot of files are not correctly identified. For example tests_data/basic/json/doc.json is low-confidence and considered text. Same for the documentation test of the Rust library which is (and not recognized as shell anymore due to threshold):
#!/bin/sh
echo hello

argh, sorry. you are right... I added the threhsolds in assets but didn't sync with python and didn't test, need to investigate what's going on.


Recipe for migration JakartaEE Security is wrong

Fixes #111
For more info, see the attached issue.

I believe this part of recipe documentation is auto-generated from the recipe descriptions. @mike-solomon please check if this will be ok going forward.

@okundzich Thanks for your message. I've also created PR for the migration itself here: https://github.com/openrewrite/rewrite-migrate-java/issues/160

Thanks for working on this! All docs in the reference/recipe section are indeed auto generated. Once the recipe itself has been updated and merged in, this doc will be updated in the following release.
Going to go ahead and close this but thanks again for thinking of the docs :)


Need help , My question , I can't show chinese in my project

In my project ,I use the angular-pdf , but  , it's  can't show  chinese pdf , help me ,thanks !!!

Hi @dinglittle , can you provide an example of your code and PDF? Thanks

Thanks you reply !
Now I have another question  , as this , I set $scope.pdfUrl to
"http://xxxx.x.xx.x:8880/utf8-jsp/ueditor/jsp/upload/file/20170522/1495422075553029472.pdf"
(my fileserver address) , but can't show the pdf , like demo , the error
XMLHttpRequest cannot load http://xxxx.x.xx.x:8880/utf8-jsp/ueditor/jsp/upload/file/20170522/1495422075553029472.pdf. No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://localhost:3000' is therefore not allowed access.
is that , I can not  show the pdf , not in my Local Directory ?
And I use the Demo https://sayan.ee/angularjs-pdf/ change de Document URL as a  internet addres , the error
Mixed Content: The page at 'https://sayan.ee/angularjs-pdf/' was loaded over HTTPS, but requested an insecure XMLHttpRequest endpoint 'http://<IP_ADDRESS>:8190/utf8-jsp/ueditor/jsp/upload/file/20170523/1495529485377072631.pdf'. This request has been blocked; the content must be served over HTTPS.
So what is reason , I can't show my pdf ?
Hope your reply!!!

Hi @dinglittle , your second issue can be solved with a simple search in our issue
It's not a problem with this directive but is a server problem. ;)


Probot plugin structure

I am sure others have had conversations about this that I either haven't read or was not privvy to, so I apologize in advance :smile:
I was writing on #120 and started in on an aside about how plugins work.
Plugin method signature
Currently, a probot plugin is a Node.js module which exports a function.
A Hapi plugin is similar, however more flexible.  A Hapi plugin is also, at its core, just a function--but it needn't be in a module which exports only that function.  The flexibility has a tradeoff: it's more difficult (imposslbe?) to automatically discover & load Hapi plugins.  And that's the right choice for Hapi--as such servers typically require a high degree of customization & control--but might not be right for Probot.  Probot should be trivially easy to get running.  Add one or more plugins and go.  The current paradigm enables this with autodiscovery and initialization.  There's another tradeoff, however (more on this later).
That the function signature as described in the documentation, unfortunately, allows no customization.  Plugins will be limited in the functionality they can provide if a plugin cannot accept options.
To contrast with Hapi, its signature is as follows:
module.exports = function myPlugin(robot, options = {}, next) {
  // use `options` object to configure as necessary
  // call next() after initialization--which may be asynchronous!--is complete.
  next();
};

The options object is managed by Hapi, and next() is a function which it provides.  Plugins are loaded in series, and only after a call to next() can another plugin begin initialization.
Probot's stale (as an example) accepts options, but it must handle loading of the options itself!
There may be a current convention around this (YAML file a directory), but there should be a standardized way to do it, or a set of possible ways.  Some other ways:

Leverage environment variables namespaced by probot and plugin, e.g. PROBOT_STALE_SETTING_A
Put plugin config in package.json (I'm not personally hot on this idea, but some people like to reduce clutter)
JSON settings
A .js settings file for more complex configuration
rc files, overrides, etc.

I would not expect each plugin to have its own configuration file.  Agree?
So, if Probot handles loading options thru a number of supported methods, and passes the result  to the plugin function, then Probot has improved the developer experience of a plugin author.
Probot already has an equivalent to next(), which is that a plugin may return a Promise (:+1:).
I haven't checked if Probot has plugins load in serial or parallel?  Either way, serial might be a good idea if we can conceive of Probot plugins having dependencies upon other plugins, which Hapi allows.  Doing it in serial could be a good tradeoff (if not happening already), as I can't really envision it bloating startup time significantly.
Plugin metadata
Another thing Hapi does is says "add attributes property to the plugin function and put your metadata there."  This includes fields like plugin name (attributes.name), version (attributes.version), what other plugins it may depend upon, if it can be loaded multiple times (!!), etc.
To make this less tedious, it allows an attributes.pkg property into which you can throw the contents of your plugin's package.json, and it will derive the useful fields.
But if a plugin author has to load package.json anyway to keep their versions in sync, why couldn't Hapi just do that?  Why shouldn't Probot just do that?
The answer is that a plugin in Hapi is just a function.
In Hapi, like Express, you could write your routes, and put the logic in those routes.  This works fine for very small apps.  But as apps grow, or are planned to become large, it's desirable to architect the app as modules.
Hapi's plugin system enables this, because since a plugin is just a function, a developer needn't create an entirely separate npm module to load one:
- server.js
- lib/
  - plugin-a.js
  - plugin-b.js
- node_modules/
  - hapi/
  - some-other-hapi-plugin/

So, plugin-a.js doesn't have a package.json in which its metadata is stored, and that's OK.
Perhaps a user of Probot has a specific, domain-specific need for a plugin--which is inappropriate to publish as a standalone module.  I don't see why that's out of the realm of possibility?  Yet, this functionality means plugin-a.js can be easily refactored into a reusable npm module if that time comes.  Looking at it from another angle, it also provides a shortcut for a developer to test a plugin intended to become public.
As mentioned above, this will make autodiscovery difficult or impossible if plugins aren't where we expect them to be.
What if...
...Probot's HTTP server was a Hapi server and we just let Hapi take care of the plugins?

Probot could support autodiscovery for 3p (npm install'd) plugins only.
Probot could decorate/hack/monkeypatch Hapi's plugin registration to allow use of a Promise instead of a callback.  If this isn't yet supported in core, I'm sure someone has done it already--Hapi has been steadily gaining support for Promises.
Probot's documentation could distill Hapi's into only that which is of use to most authors of Probot plugins.
Hapi plugins can load Hapi plugins.  Probot could provide an adapter to load "simplified" Probot plugins as a Hapi plugin itself.  For example, if a Probot plugin declines to publish metadata in the "Hapi" way (e.g. all Probot plugins currently in existence), we could pull it from package.json, or wherever else.

TL;DR: Probot's modules should take a page out of Hapi's:

Probot should manage configuration of plugins, so plugin authors don't have to design & implement.
Probot plugin metadata should be stored in, on, or around the plugin function itself--not in a separate file (e.g. package.json).  This makes it easier to get up & running with a new plugin.
Maybe Probot should just use Hapi under the hood and provide ease-of-use enhancements to support Probot's use case(s).

I am sure others have had conversations about this that I either haven't read or was not privvy to, so I apologize in advance 😄

No worries. I'm not sure this has explicitly been discussed, I'm relatively new to the Node ecosystem, so this feedback is great!

Probot should manage configuration of plugins, so plugin authors don't have to design & implement.

👍  Agree. There should be standard ways for configuring both an entire instance (e.g. sweep interval and defaults), as well as configuration for a specific installation (e.g. .github/stale.yml

Probot plugin metadata should be stored in, on, or around the plugin function itself--not in a separate file (e.g. package.json). This makes it easier to get up & running with a new plugin.

I don't really have strong feels on this, besides that I don't want there to be a ton of different ways of doing the same thing.

Maybe Probot should just use Hapi under the hood and provide ease-of-use enhancements to support Probot's use case(s).

Again, don't have strong feels on this. Something to ponder: there may be a future when probot plugins aren't invoked via webhooks, but receive them via some other channel (e.g. server sent events via a persistent connection).  In that world, I'm not sure it makes sense to have all of Hapi as part of the plugin API.

I'll respond a bit more later, but if we're talking a persistent connection-- you're thinking a message queue, MQTT, web sockets or...?

I'll respond a bit more later, but if we're talking a persistent connection-- you're thinking a message queue, MQTT, web sockets or...?

Still to be determined. I just wanted to point out that there's a better than 50% chance that payloads may arrive via some channel other than a web request.

Again, don't have strong feels on this. Something to ponder: there may be a future when probot plugins aren't invoked via webhooks, but receive them via some other channel (e.g. server sent events via a persistent connection). In that world, I'm not sure it makes sense to have all of Hapi as part of the plugin API.

Hapi provides a singleton "Server" object.  All parts of a Hapi app integrate with this object in one way or another.  It's akin to the "robot" object that Probot plugins use (but having much more functionality).  The Server wraps one or more of Node.js' http or https servers.  It also provides routing and a means for defining authentication schemes (e.g. github webhooks).
AFAIK Hapi cannot run without an HTTP or HTTPS connection defined.  It should be optional to actually listen on a port, however.
That said, there's nothing that Hapi does that would prevent an app from using other protocols, transports, and communication schemes.  The plugin ecosystem is well-developed.  For example:

nes - websockets
chairo - Seneca, which supports transports for AMQP, Kafka, Redis, Beanstalk, ActiveMQ, Stomp, etc, etc.

What's cool is that plugins expose functionality to the entire app via the singleton Server; thusly, any plugin can "talk to" any other plugin, if necessary.
Hapi & its ecosystem has solved some of the basic problems Probot is solving.  I'm almost entirely certain it wouldn't be detrimental to Probot, if it were to be used.

@boneskull thanks for the feedback and suggestions. I'd be up for evolving the current plugin structure as needed. However, I'm not sure there's a huge need for it right now.
I'm going to close this issue for now, but happy to continue the conversation if anyone thinks this could solve some existing issues.


389ds is considered as L3 supported container

LABEL com.suse.supportlevel="l3" is set by
https://build.suse.de/request/show/285987

failure: https://openqa.suse.de/tests/10210286#step/_root_BCI-tests_metadata_podman/5

VR: http://kepler.suse.cz/tests/19763#step/_root_BCI-tests_metadata_docker/4

Thanks!


Include more folders in rockspec build steps

Description
This fixes the build via rockspec when installing the plugin through nixpkgs.
Indeed, if the directories are not included, they will not be copied over the installation path.
Also fixed minor tab/space inconsistencies.
Before the patch
Installation path files

Example vim command

After applying the patch
Installation path files

Example vim command

Cheers. I actually don't use luarocks, does this require action upstream by @teto to pull the newer spec?

Yes, the source needs to be updated to use the new git revision.
Thanks for merging so fast though!

@teto knock knock I think this still needs refreshing on luarocks.org?

@rktjmp There is now a github action that submits a new release to luarocks on new tags: https://github.com/nvim-neorocks/luarocks-tag-release . This way you could update luarocks yourself without much overhead and with your API key (or mine but better yours I think :) ) ?   would that be ok if I submitted a PR ? here is a list of a few plugins that already adopted it https://github.com/nvim-neorocks/luarocks-tag-release/wiki/Example-configurations this basically adds a workflow like https://github.com/gennaro-tedesco/nvim-possession/blob/main/.github/workflows/release.yml

I see that luarocks has a "grab all modules associated with my github account" button, so I'm gunna run that so you'll probably get notification of ownership transfer. I'll add that workflow too.

Or, perhaps that button doesn't work... Can you transfer ownership to me https://luarocks.org/modules/soup

I've removed my lush.nvim package from the "root" (i.e. default) manifest so you should be able to upload your own module


Created Shreya_Sarkar.md

What type of PR is this? (check all applicable)

Check according to your PR

[x] 🚀 Added Profile

[ ] ✨ Feature Request

[ ] ✅ Joined Community

[ ] 🌟 Stared the repo

[ ] 🐛 Grammatical Error

[ ] 📝 Documentation Update

[ ] 🚩 Other

Description
I added my README.md file
Add Link of GitHub Profile
https://github.com/zugzwang03

@zugzwang03 thank you contribution to this repo :)


Install from scratch failing

I am following steps over here  for installing REMnux from scratch, however its failing to install with below issue:
I am using VirtualBox 6.1. Also have disabled Hyper-V. Here is the saltstack log file saltstack.log and logs from console console.log

Errors are related to networkminer, PolarProxy and remnux.theme
Also there are issue related to resolution of https://www.netresec.com/?download=NetworkMiner and https://www.netresec.com/?download=PolarProxy, however same works fine on my host system.
Is there any way to point the installer at these offline downloaded packages or maybe will it detect if they are installed already offline ?

Hi @sameerthamke , You're correct in that the errors were caused by NetworkMiner and PolarProxy, and it appears the issue was just a temporary failure in DNS. We have seen this and other errors with the netresec website frequently, but unfortunately those errors are not caused by the installer.
There are many challenges with having the installer point to an offline location, so that won't likely be a feasible option. As for detecting the installation, that would be slightly easier to resolve, but if the installed version is older than the available version, then the same issue would arise.
I've got a couple of ideas on how we might resolve this. I'll keep you posted.

Thank you @digitalsleuth, let me know.

Hi @sameerthamke sorry for the delay with this. I haven't been able to find a good solution to resolve this, as the reliability of the server providing the files is the key issue. The only available option might be to download and store the files within the salt states release itself, which can get bulky.
I'll discuss this with @lennyzeltser and see if it might be worth doing or not.


Javascript Dependencies

Just a question: are all of the dependencies listed in the read-me actually going to be a required part of the ASU standard (e.g. smoothscroll/lighteningtouch/moment)? If not, should there be a separation between baseline stylistic/functional components and add-on/optional ones?

As of right now, the dependencies are strictly required.  The Web Standards JavaScript checks that they are already included in order to run.
We will actually be reducing the dependencies in the near future so that you do not need to include them if you are not going to use certain features:

Moment will only be required for Calendar Downloads.
Smoothscroll will be optional.
LigheningTouch should already be optional.
RespondJS should be already be optional.

It should also be noted in the README.md which dependencies are required and which are optional.  I will make a separate issue for this as an Enhancement.

Thanks, yes, my main concern is the strict checking that results in runtime exceptions for optional JS functionality. I just want to make sure that the minimum features required to adhere to the 'standard' --e.g. header/footer menu collapsing (if that is, indeed, required to adhere to the standard)--are available without manually including these 3rd party assets.
It's not a matter of size, rather, a matter of convenience. I wouldn't mind if the optional dependencies were all built into a single minimized/optimized package that is a part of the distribution. It'd be a lot easier for me to vendorize this into my own project that has its own front-end build lifecycle.

Related issues: #59 and #60


Doesnt seem to do anything?

Is there supposed to be a music player or something on right hand side with all the runelite icons? Ive added in a custom soundfont but the plugin simply doesnt seem to do anything with it.

Yeah I'm having the same issue here. I changed the midi directory to the folder I have of old runescape midis, but is the filename system there causing issues? Are you supposed to make a MIDI folder in your downloads folder where the plugin auto-directs?

AFAICT the file-name (existing in the Default MIDI Music Path) needs to be the same as the track name (plus .mid).
And you need to have the soundfont file at Default Custom SoundFont Path.
I've only downloaded the Runescape 2.sf2 and Start.mid from https://drive.google.com/drive/folders/1Dl3Q1kNx7ouYcDLJhqAUCZxd4ZliShM2 and haven't tried other soundfonts/midis.
But it seems to work for me.

This plugin should be working as intended now, only if using the MacOS or Java version of RuneLite (I do not have Linux). For some reason the Windows version does not seem to load soundfonts. The plugin's path only requires the part after your user home directory (For example, the path could look like: Downloads/Custom.sf2).
And yes, the plugin now decodes music from the game's files directly rather than relying on local midi files. Let me know if you have any questions or thoughts, I will leave this issue open until the plugin is fully functional. Thank you!

still cant seem to get this to work, using the runescape 2.sf2 from the google drive link and when the plugin is active nothing plays


Ace value

A player should have the option to choose the value of the ace depending on his situation within the game:
If a player draws a 4 and an ace, he should pick whether if the ace counts as an 11 or as a 1. If the player counts it as an 11 then 4+11=15.
If the player decides to hit after his total cards are equal to 15, and he pulls an ace, the ace should automatically count as a 1 else the player busts.

I'm going to keep it in the way, which it allocates the aces value, upon every card entry to ultimately max the players hand value whilst minimizing it to be under 21, if possible
According to a guy on reddit


Support for OSM metadata

I tried to find in the documentation how to import metadata about version number, last user, timestamp in my database schema.
Is-it possible to do that with Imposm3 ?
Thanks

status  ->  work-in-progress :)   (  see:  https://github.com/omniscale/imposm3/pull/59  )

I'm coming back about this issue. It looks great for now. Thanks :)

It could be really fine to have metadata in the database schema.

Is there any update about getting the metadata (user, timestamp, etc.)? Issue #59 seems still to be a prototype

Including metadata (user, timestamp, etc.) would be a huge benefit for a project / proof-of-concept currently underway.  Without it we're compelled to look at other tools - and Imposm would be much preferred for many of its other features.

9 months later after my previous question without any answer so far: is there any update about getting the metadata (user, timestamp, etc.)? Issue #59 seems still to be a prototype.
Not having the possibility to get the metadata is huge, huge gap for imposm vs osm2pgsql whose development has recently restarted


Downgrade ng-bootstrap to fix warnings

@wmarques, @pascalgrimaud, This change is required to remove warnings during installation. After you review and merge, please do create a patch release.

Thanks @vishal423
I'll do the release v0.10.1 in few hours


Improved typings for http.ClientRequest, http.ClientResponse, http.reque...

Improved typings for http.ClientRequest, http.ClientResponse, http.request() and http.get().

removed superfluous redeclaration of stream methods
made typing for request options more strict
add comments

@rogierschouten thank you your contributions.
could you apply this change to node/node.d.ts both?

Hi Masahiro,
The interface has changed in v0.12 and I don't have the time to create a 0.12 setup to test with. That's why I didn't dare to update the node.d.ts typings.  I will do that once we upgrade our project to 0.12 which is in a few months.
I would suggest merging these 0.10 changes and then somebody who needs it (probably myself in a few months) can update the 0.12 typings. I will see to it that it is eventually done if no one else picks it up.
Kind regards,
Rogier

@rogierschouten okey! thanks mate.


Unable to import jax installed using prebuilt binaries from the instructions given from readme. (Ubuntu)

I am unable to import JAX following the redme. Please do let me know if i am doing anything wrong.
$ python -V

Python 3.7.12

$ nvcc -V

nvcc: NVIDIA (R) Cuda compiler driver
Copyright (c) 2005-2020 NVIDIA Corporation
Built on Mon_Oct_12_20:09:46_PDT_2020
Cuda compilation tools, release 11.1, V11.1.105
Build cuda_11.1.TC455_06.29190527_0

$ pip install jax[cuda11_cudnn805] -f https://storage.googleapis.com/jax-releases/jax_releases.html

Looking in indexes: https://pypi.org/simple, https://pip.repos.neuron.amazonaws.com
Looking in links: https://storage.googleapis.com/jax-releases/jax_releases.html
Collecting jax[cuda11_cudnn805]
  Using cached jax-0.2.25-py3-none-any.whl
Collecting absl-py
  Using cached absl_py-1.0.0-py3-none-any.whl (126 kB)
Collecting numpy>=1.18
  Using cached numpy-1.21.4-cp37-cp37m-manylinux_2_12_x86_64.manylinux2010_x86_64.whl (15.7 MB)
Collecting scipy>=1.2.1
  Using cached scipy-1.7.3-cp37-cp37m-manylinux_2_12_x86_64.manylinux2010_x86_64.whl (38.1 MB)
Collecting typing-extensions
  Using cached typing_extensions-4.0.1-py3-none-any.whl (22 kB)
Collecting opt-einsum
  Using cached opt_einsum-3.3.0-py3-none-any.whl (65 kB)
Collecting jaxlib==0.1.73+cuda11.cudnn805
  Using cached https://storage.googleapis.com/jax-releases/cuda11/jaxlib-0.1.73%2Bcuda11.cudnn805-cp37-none-manylinux2010_x86_64.whl (138.5 MB)
Collecting flatbuffers<3.0,>=1.12
  Using cached flatbuffers-2.0-py2.py3-none-any.whl (26 kB)
Collecting six
  Using cached six-1.16.0-py2.py3-none-any.whl (11 kB)
Installing collected packages: six, numpy, typing-extensions, scipy, opt-einsum, flatbuffers, absl-py, jaxlib, jax
Successfully installed absl-py-1.0.0 flatbuffers-2.0 jax-0.2.25 jaxlib-0.1.73+cuda11.cudnn805 numpy-1.21.4 opt-einsum-3.3.0 scipy-1.7.3 six-1.16.0 typing-extensions-4.0.1

$ python -c "import jax"

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/ubuntu/NS/VaxNeRF/thridparty/jax/jax/__init__.py", line 37, in <module>
    from jax import config as _config_module
  File "/home/ubuntu/NS/VaxNeRF/thridparty/jax/jax/config.py", line 18, in <module>
    from jax._src.config import config
  File "/home/ubuntu/NS/VaxNeRF/thridparty/jax/jax/_src/config.py", line 27, in <module>
    from jax._src import lib
  File "/home/ubuntu/NS/VaxNeRF/thridparty/jax/jax/_src/lib/__init__.py", line 69, in <module>
    _check_jaxlib_version()
  File "/home/ubuntu/NS/VaxNeRF/thridparty/jax/jax/_src/lib/__init__.py", line 67, in _check_jaxlib_version
    raise ValueError(msg)
ValueError: jaxlib is version 0.1.73, but this version of jax requires version 0.1.74.

The minimum jaxlib was incremented to 0.1.74 in https://github.com/google/jax/commit/3fd3c46f205b9a65bcd6280fd86f1b32c3201d38, which is not yet part of an external release.
This makes me think that despite having installed JAX 0.2.25, you are importing a development version. What is the result of the following?
$ python -c "import jax; print(jax.__path__)"

Actually, I see it in your traceback: you are indeed importing JAX from your git repository.
Try changing the directory so that you import the installed JAX.
Alternatively, you can run
pip install .[cuda11_cudnn805]

to install the appropriate jaxlib for your development version.

@jakevdp , Thank you for you quick response. Unfortunately, I have the same issue because I am unable to import Jax.
$ python -c "import jax; print(jax.__path__)"

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/ubuntu/NS/VaxNeRF/thridparty/jax/jax/__init__.py", line 37, in <module>
    from jax import config as _config_module
  File "/home/ubuntu/NS/VaxNeRF/thridparty/jax/jax/config.py", line 18, in <module>
    from jax._src.config import config
  File "/home/ubuntu/NS/VaxNeRF/thridparty/jax/jax/_src/config.py", line 27, in <module>
    from jax._src import lib
  File "/home/ubuntu/NS/VaxNeRF/thridparty/jax/jax/_src/lib/__init__.py", line 69, in <module>
    _check_jaxlib_version()
  File "/home/ubuntu/NS/VaxNeRF/thridparty/jax/jax/_src/lib/__init__.py", line 67, in _check_jaxlib_version
    raise ValueError(msg)
ValueError: jaxlib is version 0.1.73, but this version of jax requires version 0.1.74.

Ignore that, see my second comment.

Oh, Yes. My bad I was import from the jax git repo. It works fine now. Thanks again for taking you time to respond.


vulkan to work with vector models and embeddings

Hello, I remember a conversation awhile ago and whisper.cpp would not work with GPU acceleration...
Currently, does the ability to run vector models work with GPU acceleration and specifically Vulkan?

Closed due to lack of interest and response.


fix: added tablet landscape icon.

Description

Added Tablet Landscape icon to the canvas size selector.

Fixes #9321
Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested Manually on the canvas

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

/ok-to-test sha=4654573


Variable UID Container

Codecov Report

Merging #711 (2e6972b) into master (32d7c0a) will increase coverage by 5.49%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #711      +/-   ##
==========================================
+ Coverage   70.13%   75.62%   +5.49%
==========================================
  Files         124      127       +3
  Lines       11410    11780     +370
==========================================
+ Hits         8002     8909     +907
+ Misses       3408     2871     -537

Impacted Files
Coverage Δ

assemblyline/odm/models/config.py
99.27% <0.00%> (-0.20%)
:arrow_down:

assemblyline/odm/models/ontology/ontology.py
100.00% <0.00%> (ø)

assemblyline/odm/models/ontology/types/__init__.py
100.00% <0.00%> (ø)

assemblyline/odm/models/ontology/__init__.py
100.00% <0.00%> (ø)

assemblyline/odm/base.py
82.81% <0.00%> (+0.22%)
:arrow_up:

assemblyline/odm/messages/task.py
96.61% <0.00%> (+0.24%)
:arrow_up:

assemblyline/common/heuristics.py
86.95% <0.00%> (+2.17%)
:arrow_up:

assemblyline/odm/random_data/__init__.py
91.03% <0.00%> (+4.39%)
:arrow_up:

assemblyline/datasource/alert.py
92.30% <0.00%> (+7.69%)
:arrow_up:

assemblyline/odm/models/ontology/types/pe.py
100.00% <0.00%> (+100.00%)
:arrow_up:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32d7c0a...2e6972b. Read the comment docs.


⚠ Bofrost.at has degraded performance

In fd54779, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1917 ms

Resolved: Bofrost.at performance has improved in 6fcb996 after 15 minutes.


Refactor enum formatting

Unify formatting code for enum variants and structs.
Fix https://github.com/nrc/rustfmt/issues/406.

Cool :+1:

Updated! Now with extra type layout bug fix for structs!

Thanks for making the changes, looks good.


Add macOS support for KeePassXC package

Motivation for this change
Make the KeePassXC package work on macOS in addition to Linux
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build keepassx-community

Please prefix commit messages with "keepassxc: ...".

I have added support for macOS in b693f989f65d55d2213c52b716cf26fe60e40ad0 and proposed a fix for No known features for CXX compiler "Clang" version 4.0.1. upstream: https://github.com/keepassxreboot/keepassxc/pull/1308 (already merged). I have opted for the app bundle packaging: the app will show in the launcher if ~/Applications is a link to (or contains links into) ~/.nix-profile/Applications. (It can still be launched from console with open -a keepassxc. However, both the dock and the open command have severe cash invalidation issues and it was taking me some effort to convince them that they should stop running old binaries after reinstallations of the application. Nevertheless, the first installation is smooth.)

I have also added macdeployqt to qttools on darwin in fb349c84e2ccdbf45ef3430392927586b76f4ed9 (on staging branch) because it was confusing not to have it, even though with Nixpkgs keepassxc is better without it (because it copies all dependent libraries into the application directory). (It would be nice to upstream an option to disable the use of macdeployqt in keepassxc.)


chore: bdd-spring-1585377576 to 0.0.1

chore: Promote bdd-spring-1585377576 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Support array of strings and single string for aud value

Fix #348

@dgrijalva don't you mind to merge one of fixes for audience as a []string, or string (as RFC says). This one looks like the best one to me.

@dgrijalva do you plan to merge this PR ?

Using interface{} here is the wrong approach.  A custom type Audience []string with the appropriate unmarshall implementation will give you type safety and avoid panics.
Any attempt to fix this will likely be backwards incompatible from a Go perspective.

This is a backward incompatible change. Please see the 4.0.0-preview1 release and see if that resolves your issue.