[BUG] when flutter is 3.10.0,fvm is 2.4.1, fvm's behavior is very strange

My system is windows10.
First this normal，when I use flutter 3.3.4，fvm 2.4.1 ,I use 'fvm flutter packages get' and then the dependent libraries will be downloaded to flutter 3.3.4 is installation directory,like E:\fvm\flutter_sdks\flutter_3.3.4\.pub-cache\hosted.
Now this strange, I use flutter 3.10.0，fvm 2.4.1 ,I use 'fvm flutter packages get' and then the dependent libraries will be downloaded to
default installation directory that is C:\Users\hanger\AppData\Local\Pub\Cache\hosted，and it doesn't downloaded to flutter 3.10.0 is installation directory,like E:\fvm\flutter_sdks\flutter_3.10.0\.pub-cache\hosted.
I don't believe, then I downloaded flutter 3.7.10，its dependent libraries still downloaded to default installation directory.
After trying for a while,I gave up.I don't know from which version it started, it became abnormal.
Who has the same experience as me?
Or did I make a mistake in my operation?

@hanger23 not sure, can you provide the output requested when opening an issue, and also provide steps to replicate?

ok,the output requested:
when is flutter 3.3.4:
        `
        F:\File\temppppppp\flutter_test2>fvm flutter --version
        Flutter 3.3.4 • channel stable • https://github.com/flutter/flutter.git
        Framework • revision eb6d86ee27 (8 months ago) • 2022-10-04 22:31:45 -0700
        Engine • revision c08d7d5efc
        Tools • Dart 2.18.2 • DevTools 2.15.0

        F:\File\temppppppp\flutter_test2>fvm flutter pub get
        Flutter assets will be downloaded from https://storage.flutter-io.cn. Make sure you trust this source!
        Running "flutter pub get" in flutter_test2...                      860ms
        `

when is flutter 3.7.10:
      `F:\File\temppppppp\flutter_test_3_7_10>fvm use flutter_3.7.10
      Project now uses Flutter [flutter_3.7.10]

      F:\File\temppppppp\flutter_test_3_7_10>fvm flutter --version
      Flutter 3.7.10 • channel stable • https://github.com/flutter/flutter.git
      Framework • revision 4b12645012 (8 weeks ago) • 2023-04-03 17:46:48 -0700
      Engine • revision ec975089ac
      Tools • Dart 2.19.6 • DevTools 2.20.1

      F:\File\temppppppp\flutter_test_3_7_10>fvm flutter pub get
      Flutter assets will be downloaded from https://storage.flutter-io.cn. Make sure you trust this source!
      Running "flutter pub get" in flutter_test_3_7_10...
      Resolving dependencies...
        async 2.10.0 (2.11.0 available)
        characters 1.2.1 (1.3.0 available)
        collection 1.17.0 (1.17.2 available)
        js 0.6.5 (0.6.7 available)
        lints 2.0.1 (2.1.0 available)
        matcher 0.12.13 (0.12.16 available)
        material_color_utilities 0.2.0 (0.5.0 available)
        meta 1.8.0 (1.9.1 available)
        path 1.8.2 (1.8.3 available)
        source_span 1.9.1 (1.10.0 available)
        test_api 0.4.16 (0.6.0 available)
      Got dependencies!
      `

when is flutter 3.10.0:
        `F:\File\temppppppp\flutter_test_3_10_0>fvm use flutter_3.10.0
        Project now uses Flutter [flutter_3.10.0]

        F:\File\temppppppp\flutter_test_3_10_0>
        F:\File\temppppppp\flutter_test_3_10_0>fvm flutter --version
        Flutter 3.10.0 • channel stable • https://github.com/flutter/flutter.git
        Framework • revision 84a1e904f4 (3 weeks ago) • 2023-05-09 07:41:44 -0700
        Engine • revision d44b5a94c9
        Tools • Dart 3.0.0 • DevTools 2.23.1

        F:\File\temppppppp\flutter_test_3_10_0>fvm flutter pub get
        Flutter assets will be downloaded from https://storage.flutter-io.cn. Make sure you trust this source!
        Resolving dependencies...
          collection 1.17.1 (1.17.2 available)
          matcher 0.12.15 (0.12.16 available)
          material_color_utilities 0.2.0 (0.5.0 available)
          source_span 1.9.1 (1.10.0 available)
          test_api 0.5.1 (0.6.0 available)
        Got dependencies!
        `

configure environment variables that PUB_CACHE is like E:\pub\cache


Fix buffer-package for non-standard package value

If (buffer-value buffer "package") returned a value that was not
a string designator, and error was signaled and Lem died.
E.g. the file "iterate.lisp" from project :iterate contains the
following property list:
;;;-*- syntax:COMMON-LISP; Package: (ITERATE :use "COMMON-LISP" :colon-mode :external) -*-

Therefore, opening that file and calling lisp-mode killed Lem.
Now, wrap call with ignore-errors and use default if NIL is returned.

like this?
(defun buffer-package (buffer &optional default)
  (let ((package (buffer-value buffer "package" default)))
    (cond ((null package) default)
          ((or (symbolp package)
               (stringp package))
           (string-upcase package))
          ((consp package)
           (string-upcase (car package))))))


Check code samples automatically

I added a small build script that will generate a test file from code samples.
The file will be located in tests/generated_from_code_samples.rs and contains 78 additional tests.
This is a great way to track breaking changes in the code samples.
I also made a few fixes to code samples as there was breaking changes in the past that were not updated.
Use cargo test code_sample -- --test-threads=1 to run them all.
Generated test preview

#[async_test]
async fn code_sample_delete_one_document_1() {
    // Setup
    let client = Client::new("http://localhost:7700", "masterKey");
    let _ = client.delete_index("delete_one_document_1").await;
    let movies = setup_test_index(&client, "delete_one_document_1").await;

    // Code sample
    let progress: Progress = movies.delete_document(25684).await.unwrap();

    // Cleanup
    let _ = client.delete_index("delete_one_document_1").await;
}

#[async_test]
async fn code_sample_delete_documents_1() {
    // Setup
    let client = Client::new("http://localhost:7700", "masterKey");
    let _ = client.delete_index("delete_documents_1").await;
    let movies = setup_test_index(&client, "delete_documents_1").await;

    // Code sample
    let progress: Progress = movies.delete_documents(&[23488, 153738, 437035, 363869]).await.unwrap();

    // Cleanup
    let _ = client.delete_index("delete_documents_1").await;
}

// and 76 other tests like these 2

That's a lot of tests actually.
Maybe we can avoid running code samples test. A compilation check should be enough for them in most cases but I fear it would not be perfect.

What do you think about this @curquiza? Should we run code samples or just check that they compile? Running adds a few minutes of computation on the CI.

It's as you wish :)
This is too much work for the Meili team to integrate into all SDKs, it means what you are doing is a huge bonus in this one 😁 So, do what you prefer since the Meili team haven't made any decision about this yet 🙂 Adding only the compilation is already a good step from my POV :)


chore: align dependencies version with Flow

Hilla pins a couple of dependencies older than the ones defined by Flow. The clash is shown when Vaadin maven plugin fails for some reason and it dumps the project-plugin incompatibilities.
References vaadin/flow#20740

@mcollovati is it necessary to pin those or we could count on a BOM?

@mcollovati is it necessary to pin those or we could count on a BOM?

They are not in Flow BOM. In Flow they are defined in parent pom dependency management and included in flow-server and some other module.

This one should probably be picked to 24.6


Make system parameter syntax more readable

Use something else instead of Position&, const Position& etc.
Maybe Write<Position>, Read<Position>.

Using this in queries looks like:
void system(Query<Read<Position>, Write<Rotation>> query)
{
  for (auto [entity, position, rotation] : query)
  {
   // position has type const Position&, rotation has type Rotation&
  }
}

But with resources we would need to 'dereference' the type manually:
void system(Read<Foo> foo, Write<Bar*> bar)
{
 assets.get().foo(); // .get() returns const Foo&
 assets->foo(); // could also implement operator->
 bar.get()->bar(); // Since Bar* is a pointer itself, overloading operator-> is not possible - would happen with the Renderer resource
}


Poor performance when using [!Mormon] tag

Hello,
Problem
Some of my LDS friends have found this plugin and tried to use it but they found it to hurt their obsidian performance quite a bit. They asked me to try it and see if I could figure out why. Testing on Arch Linux (x86_64)
Testing
I tried out +Genesis 1:1-20 and everything formatted as expected:
> [!Mormon] [Genesis 1:1-20](https://www.churchofjesuschrist.org/study/scriptures/ot/gen/1?lang=eng&id=p1-p20#p1)
>

In the beginning God created the heaven and the earth.

And the earth was without form, and void; and darkness was upon the face of the deep. And the Spirit of God moved upon the face of the waters.

And God said, Let there be light: and there was light.

And God saw the light, that it was good: and God divided the light from the darkness.

And God called the light Day, and the darkness he called Night. And the evening and the morning were the first day.

¶ And God said, Let there be a firmament in the midst of the waters, and let it divide the waters from the waters.

And God made the firmament, and divided the waters which were under the firmament from the waters which were above the firmament: and it was so.

And God called the firmament Heaven. And the evening and the morning were the second day.

¶ And God said, Let the waters under the heaven be gathered together unto one place, and let the dry land appear: and it was so.

And God called the dry land Earth; and the gathering together of the waters called he Seas: and God saw that it was good.

And God said, Let the earth bring forth grass, the herb yielding seed, and the fruit tree yielding fruit after his kind, whose seed is in itself, upon the earth: and it was so.

And the earth brought forth grass, and herb yielding seed after his kind, and the tree yielding fruit, whose seed was in itself, after his kind: and God saw that it was good.

And the evening and the morning were the third day.

¶ And God said, Let there be lights in the firmament of the heaven to divide the day from the night; and let them be for signs, and for seasons, and for days, and years:

And let them be for lights in the firmament of the heaven to give light upon the earth: and it was so.

And God made two great lights; the greater light to rule the day, and the lesser light to rule the night: he made the stars also.

And God set them in the firmament of the heaven to give light upon the earth,

And to rule over the day and over the night, and to divide the light from the darkness: and God saw that it was good.

And the evening and the morning were the fourth day.

And God said, Let the waters bring forth abundantly the moving creature that hath life, and fowl that may fly above the earth in the open firmament of heaven.

but when going into reading mode my performance would drop significantly when scrolling.
Solution
I tried a few different things and eventually discovered that if you removed the [!Mormon] from the inserted text then performance significantly improved. This also impacted styling when rendered. This makes me think there exists some type of inefficiency. I'll look through the code and see if I can find any solution that retains the styling but improves performance.

Found this file: https://github.com/pacokwon/obsidian-lds-scriptures-plugin/blob/main/styles.css , it seems that this is using the callouts feature. It seems this feature, regardless of how I use it, creates performance issues and I suspect that it does the same for my friends. Maybe the plugin could use something else? Not sure if it is just a weird niche issue or if it is more widespread.

Thank you for the report. I'm glad it's getting some use.
Hmm that's strange because I'm on Arch Linux x86 as well and it doesn't seem to cause any issues for me. How is the performance issue manifested? ex> does it stutter when you scroll in read only mode?
You also mentioned the callouts feature itself being an issue. Does just using callouts and not this plugin's feature also affect performance?

Thank you for the report. I'm glad it's getting some use.
Hmm that's strange because I'm on Arch Linux x86 as well and it doesn't seem to cause any issues for me. How is the performance issue manifested? ex> does it stutter when you scroll in read only mode?
Yes
You also mentioned the callouts feature itself being an issue. Does just using callouts and not this plugin's feature also affect performance?
Yes

It's worth noting that I use the built in Nvidia drivers on my PC and that I do not have this performance issue on my macbook. So this could totally just be a rendering issue and nothing wrong with the obsidian software or plugin implementation.

If the callouts feature itself is a problem, then there's not much that I, as the plugin developer, can do about it.
It might be a workaround to implement the feature without using the callouts feature, but I'm actually leaving on my mission in a few days and won't be able to develop that feature myself.
So as of now, that is how it is!

If the callouts feature itself is a problem, then there's not much that I, as the plugin developer, can do about it. It might help to file an issue to the obsidian repository.

Yeah. I figured.

It might be a workaround to implement the feature without using the callouts feature, but I'm actually leaving on my mission in a few days and won't be able to develop that feature myself.

I was thinking about that but not much to do, you're right. Thanks anyway. Good luck.


Config usability

Codecov Report

Merging #41 into master will increase coverage by 0.27%.
The diff coverage is 79.38%.

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   42.71%   42.98%   +0.27%
==========================================
  Files          36       36
  Lines        3800     3857      +57
==========================================
+ Hits         1623     1658      +35
- Misses       2177     2199      +22

Impacted Files
Coverage Δ

src/defs.jl
0% <ø> (ø)
:arrow_up:

src/JEMSS.jl
100% <ø> (ø)
:arrow_up:

src/animation/animation.jl
0% <0%> (ø)
:arrow_up:

src/decision/dispatch.jl
75% <100%> (+5%)
:arrow_up:

src/simulation.jl
68.42% <100%> (ø)
:arrow_up:

src/file/write_sim_files.jl
39.79% <25%> (-0.63%)
:arrow_down:

src/file/file_io.jl
66.92% <66.66%> (-0.01%)
:arrow_down:

src/types/types.jl
73.75% <71.42%> (-0.23%)
:arrow_down:

src/file/read_sim_files.jl
56.87% <73.68%> (-1.77%)
:arrow_down:

src/run_config.jl
61.06% <80%> (+0.34%)
:arrow_up:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bbd76a...6841d36. Read the comment docs.


Android fails to load video with https

Hi Adam,
The mp4 I'm using is from an azure server, and works fine in iOS. It will not play on Android.
As a test, I moved the mp4 to a site using http and it loaded and played fine on Android.
This is the only blocker for me - unfortunately all my video files are going to be served via https. I am attaching the output from Visual Studio.
VideoPlayer_output_Android.txt
Thank you!
PD

Hi @adamfisher have you had a chance to look at this? If you need an https URL I can provide some,
Thanks,
Pete

As you can see from the partial stack trace below, the issue occurs with the native Android MediaPlayer unable to find a content provider capable of handling HTTPs.

Note: HTTPS is not supported before Android 3.1.

08-03 21:39:11.978 I/SurfaceView(20285): surfaceCreated callback +, this = Octane.Xam.VideoPlayer.Android.Widget.VideoView\{2555a91 VFE...... .F....ID 0,0-720,1136\}\
08-03 21:39:11.982 E/MediaPlayer(20285): setDataSource: IOException! uri=https://defaultwebcentralus224.blob.core.windows.net/wowvideos/636373709759305171hb.mp4\
08-03 21:39:11.982 E/MediaPlayer(20285): java.io.FileNotFoundException: No content provider: https://defaultwebcentralus224.blob.core.windows.net/wowvideos/636373709759305171hb.mp4\
08-03 21:39:11.982 E/MediaPlayer(20285): 	at android.content.ContentResolver.openTypedAssetFileDescriptor(ContentResolver.java:1123)\
08-03 21:39:11.982 E/MediaPlayer(20285): 	at android.content.ContentResolver.openAssetFileDescriptor(ContentResolver.java:958)\
08-03 21:39:11.982 E/MediaPlayer(20285): 	at android.content.ContentResolver.openAssetFileDescriptor(ContentResolver.java:881)\
08-03 21:39:11.982 E/MediaPlayer(20285): 	at android.media.MediaPlayer.setDataSource(MediaPlayer.java:1018)\
08-03 21:39:11.982 E/MediaPlayer(20285): 	at android.widget.VideoView.openVideo(VideoView.java:437)\

Some things to try:

Pass the URL without the protocol: //:example.com/video.mp4
Instead of using XAML, make an explicit call to myPlayer.Source = VideoSource.FromUri(""); trying it with/without the protocol.
Finally it may come to creating an Android content provider to extend the ContentProvider class and register it in your AndroidManifest.xml. Unless you have altered the manifest, I'm surprised you would need to do this as Android projects don't have an issue with this by default as is the case with the Chill Player example app I was able to verify it does work with the azure URL you mentioned above.

Thanks Adam, I appreciate your advice. I'll give these ideas a try.
Pd
On Sun, Aug 27, 2017 at 9:53 PM Adam<EMAIL_ADDRESS>wrote:

As you can see from the partial stack trace below, the issue occurs with
the native Android MediaPlayer unable to find a content provider capable
of handling HTTPs.
Note: HTTPS is not supported before Android 3.1.
08-03 21:39:11.978 I/SurfaceView(20285): surfaceCreated callback +, this = Octane.Xam.VideoPlayer.Android.Widget.VideoView{2555a91 VFE...... .F....ID 0,0-720,1136}
08-03 21:39:11.982 E/MediaPlayer(20285): setDataSource: IOException! uri=https://defaultwebcentralus224.blob.core.windows.net/wowvideos/636373709759305171hb.mp4
08-03 https://defaultwebcentralus224.blob.core.windows.net/wowvideos/636373709759305171hb.mp4\08-03 21:39:11.982 E/MediaPlayer(20285): java.io.FileNotFoundException: No content provider: https://defaultwebcentralus224.blob.core.windows.net/wowvideos/636373709759305171hb.mp4
08-03 https://defaultwebcentralus224.blob.core.windows.net/wowvideos/636373709759305171hb.mp4\08-03 21:39:11.982 E/MediaPlayer(20285): 	at android.content.ContentResolver.openTypedAssetFileDescriptor(ContentResolver.java:1123)
08-03 21:39:11.982 E/MediaPlayer(20285): 	at android.content.ContentResolver.openAssetFileDescriptor(ContentResolver.java:958)
08-03 21:39:11.982 E/MediaPlayer(20285): 	at android.content.ContentResolver.openAssetFileDescriptor(ContentResolver.java:881)
08-03 21:39:11.982 E/MediaPlayer(20285): 	at android.media.MediaPlayer.setDataSource(MediaPlayer.java:1018)
08-03 21:39:11.982 E/MediaPlayer(20285): 	at android.widget.VideoView.openVideo(VideoView.java:437)\
Some things to try:

Pass the URL without the protocol: //:example.com/video.mp4
Instead of using XAML, make an explicit call to myPlayer.Source =
VideoSource.FromUri(""); trying it with/without the protocol.
Finally it may come to creating an Android content provider
https://developer.android.com/guide/topics/providers/content-provider-creating.html
to extend the ContentProvider class and register it in your
AndroidManifest.xml. Unless you have altered the manifest, I'm surprised
you would need to do this as Android projects don't have an issue with this
by default as is the case with the Chill Player example app I was able to
verify it does work with the azure URL you mentioned above.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/adamfisher/Xamarin.Forms.VideoPlayer/issues/59#issuecomment-325248327,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABFe6sPRh5NXb6rAzNkscx9b0j39h3nUks5sciutgaJpZM4O_bx7
.

The URL below does not work in my app or the Chill Player (Android) either. I tried your suggestions regarding the protocol, no dice. I can play this URL in a Xamarin WebView. Not sure where to go with this :@/
"https://defaultwebcentralus224.blob.core.windows.net/wowvideos/636373709759305171hb.mp4"

I am showing that URL as broken. I do remember testing this a while back successfully on the Chill Player example application. HTTPs streams have worked for many other users. One thing that is sometimes helpful is to start with Chill Player's manifest and configuration files and then work to get your project specific items inserted from there. Specifically the AndroidManifest.xml is of particular interest since that is where the content provider configuration lives.

I've been flailing on this for some time. This has me beat. It is not a problem with the Octane player. I can't even get it to play in a simple java Android project using MediaPlayer or VideoView approaches. It does complain about the (java.io.FileNotFoundException: No content provider)
Here is a newer sample video ( I can download the video and play it as a local resource but that's not the ticket) :
https://defaultwebcentralus224.blob.core.windows.net/wowvideos/636403108616662155hb.mp4

We are retrieving our videos from another source now (Azure Media Server) with no problems. This can be closed. Thanks for your help.


remove location parameter

location parameter is a mandatory input when kick off a release run, pipeline scheduled run doesn't accept pipeline parameter which failed daily e2e.
With this PR to set region in pipeline variable instead of pipeline parameter to fix daily e2e failure.

Is this file being used as a template for the PROD E2Es? Why was location required as a parameter, but not any more?

Is this file being used as a template for the PROD E2Es? Why was location required as a parameter, but not any more?

No, we have a template yml for PROD e2e. We choose location parameter for the purpose to remove duplicate code between e2e-with-billing.yml with template-rp-and-billing-e2e.yml, but did not make through.

Looks like we weren't using the parameter I was expecting us to update the spot we used it to. But couldn't find it when I searched the file


aur-fetch: Generate full patch on first clone

Review patches are not being generated on first clone. Fix that.
If --confirm-seen is used on first clone cases, it is assumed the user
trusts the source and the patch generation is skipped.
Hint: Easier to review if whitespace changes are hidden
https://github.com/AladW/aurutils/pull/586/files?w=1

I confirm it fixes the issue 👍

Yeah, fair enough. Don't mind my earlier snark.
On Sat, Aug 10, 2019 at 04:27:25PM -0700, rafasc wrote:

rafasc commented on this pull request.

@@ -129,6 +94,37 @@ fi | while read -r pkg; do
exit 1
fi
fi

Avoid issues with filesystem boundaries. (#274)

export GIT_DIR=$pkg/.git GIT_WORK_TREE=$pkg

I am a bit confused, because that was done in response to your comment...
Checking for the presence of $pkg/.git isn't enough to avoid subsequent git commands failing.
In most cases, It needs at least .git/refs/, .git/objects/ and a valid HEAD file, for commands to consider they're are dealing with a real repository.
I am not sure how we could do what we are doing without bolting these git commands.... :confused:
--
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub:
https://github.com/AladW/aurutils/pull/586#discussion_r312717925

https://github.com/AladW/aurutils/commit/ab9e1ff9dff62123d418af23a339fa99e5d4bf8d#diff-5735282db1c278eacee9db868b359699
I seem to be having the issue that on a new repository, the GIT_DIR variable is not unset and a wrong git clone is attempted. i.e.
user@foxden ~/.cache/aurutils/sync % ~/aurutils/lib/aur-fetch -L /tmp/view.1fLeXkd4 ros-indigo-rosc
pp ros-indigo-rosgraph ros-indigo-rosout ros-indigo-rosclean ros-indigo-rosmaster ros-indigo-rospar
am qt4 ros-indigo-roslaunch ros-indigo-rospy python-sip-pyqt4 phonon-qt4 ros-indigo-roslz4 ros-indi
go-rostest pyqt4 ros-indigo-actionlib-msgs ros-indigo-geometry-msgs ros-indigo-rosbag-storage ros-i
ndigo-topic-tools ros-indigo-tf2-msgs ros-indigo-rosbag ros-indigo-python-qt-binding ros-indigo-tf2
 ros-indigo-rostopic ros-indigo-rosmsg ros-indigo-qt-gui ros-indigo-tf2-py ros-indigo-actionlib ros
-indigo-message-filters ros-indigo-rosservice ros-indigo-rosnode

HEAD is now at 278a944 Update version
From https://aur.archlinux.org/ros-indigo-roscpp
 = [up to date]      master     -> origin/master
Already up to date.
Current branch master is up to date.
ros-indigo-roscpp/.git
fatal: working tree 'ros-indigo-roscpp' already exists.

Should the GIT_DIR and GIT_WORK_TREE variables not be unset at the top of the loop? git clone is giving me some issues if not:
user@foxden ~/.cache/aurutils/sync % ~/aurutils/lib/aur-fetch -L /tmp/view.1fLeXkd4 ros-indigo-roscpp ros-indigo-rosgraph ros-indigo-rosout ros-indigo-rosclean ros-indigo-rosmaster ros-indigo-rosparam qt4 ros-indigo-roslaunch ros-indigo-rospy python-sip-pyqt4 phonon-qt4 ros-indigo-roslz4 ros-indigo-rostest pyqt4 ros-indigo-actionlib-msgs ros-indigo-geometry-msgs ros-indigo-rosbag-storage ros-indigo-topic-tools ros-indigo-tf2-msgs ros-indigo-rosbag ros-indigo-python-qt-binding ros-indigo-tf2 ros-indigo-rostopic ros-indigo-rosmsg ros-indigo-qt-gui ros-indigo-tf2-py ros-indigo-actionlib ros-indigo-message-filters ros-indigo-rosservice ros-indigo-rosnode

Cloning into 'ros-indigo-roscpp'...
remote: Enumerating objects: 90, done.
remote: Counting objects: 100% (90/90), done.
remote: Compressing objects: 100% (60/60), done.
remote: Total 90 (delta 38), reused 78 (delta 29)
Unpacking objects: 100% (90/90), done.
HEAD is now at 278a944 Update version
From https://aur.archlinux.org/ros-indigo-roscpp
 = [up to date]      master     -> origin/master
Already up to date.
Current branch master is up to date.
fatal: working tree 'ros-indigo-roscpp' already exists.
==> ERROR: fetch: ros-indigo-rosgraph: Failed to clone repository

Also it seems odd that without --confirm-seen, aur-fetch will run git reset on a newly cloned repository...

Some experiments in handling more cases: https://github.com/AladW/aurutils/commit/f5f2ba12c4eb1592e843c5910aeecb46baf48ecd


Include all submodules in the release notes.

We are bumping up minor version for every submodule in google-cloud-java on release, even if there is no code changes, it makes sense since we are at least updating the shared dependencies for every submodule.
But what happens is that the release notes do not include every submodule, only the ones had fix/feat PRs, so customers don't know what actually changed if they only care about a certain module.
e.g. java-iam-admin has no code changes in the last two months but we released three minor versions(3.1.0, 3.2.0, 3.3.0), and it is not mentioned in the aggregated release notes https://github.com/googleapis/google-cloud-java/releases.
Ideally, we should include all submodule in the release notes, and provide information like These modules only have dependencies update or similar ways to submodules only have dependencies update.

@chingor13 Do you receive similar requests from other monorepos? If not, what do you think about pluggable release note function in Release Please? (I want that)


Remove unused internal Variable Viewport::gui_input_group

The gui input group is not needed during the gui input step.

Thanks!


Remove apple-sys dependency

I've been having a lot of trouble building RustDesk on macOS. Long story short, it turns out that apple-sys is very fragile. apple-bindgen will generate code that doesn't compile if not every version of every tool involved on the build computer is perfectly aligned version-wise - and as far as I can tell, there's no way to figure out what versions "match".
Since this was the dependency that pulled in apple-sys, I took at closer look at it, and it turns out that it's not really needed. I couldn't find an available crate that defined the necessary functions in IOKit, but it turns out that there are only two functions, some constants and a couple of type definitions that is use. None of this has changed in macOS for a long time (I think they mostly go back to OSX 10.4/10.5), so chances are that these will stay as they are. I thus found it much better to just define those few things and drop the dependency.
With this version I can finally build RustDesk on macOS, and it's also working as far as I can tell (I've checked that it does in fact register "assertions").
I also removed main.rs since it only led to a lot of compile errors and wasn't in use anyway. That got rid of even more dependencies. I also modified the VSCode configuration that is checked in, since it would fail to work since the "bin" feature has been removed.
I don't know Rust, so please tell me if I've done something stupid, and I will try my best to correct it.

@rustdesk Did you see this?


Remove several Lazy-related objects from every TokenValidationResult

Creating a TokenValidationResult is also creating a Lazy<>, a LazyHelper internal to the Lazy<>, and a Func<> delegate due to the lambda passed to the lazy closing over this.
It's not clear to me why Lazy<> was being used here. There's other lazily-initialized state on the same type that's not using Lazy<>, and I went back and looked at the PR/issue that added this and there's no discussion of it.  Is there some kind of thread-safety guarantee it was trying to provide?  Or was this just done this way because that's how the dev happened to write it?

@brentschmaltz, based on our offline conversation, I revamped it.  Please take a look and let me know if this matches your expectations for what's synchronized and how.


Develop

There are major updates to PowerSystems.jl. In particular a complete remake of PowerSystem struct.
Run methods(PowerSystem) to see the benefits. Now all the methods are strongly typed.
After this PR a fix to printing will be required.

Codecov Report

Merging #30 into master will decrease coverage by 9.68%.
The diff coverage is 61.62%.

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
- Coverage   27.25%   17.57%   -9.69%
==========================================
  Files          17       19       +2
  Lines         510      535      +25
==========================================
- Hits          139       94      -45
- Misses        371      441      +70

Impacted Files
Coverage Δ

src/parsers/standardfiles_parser.jl
75% <ø> (ø)
:arrow_up:

src/models/branches/lines.jl
50% <ø> (ø)
:arrow_up:

src/utils/base_checks.jl
100% <ø> (ø)

src/models/network.jl
0% <0%> (-100%)
:arrow_down:

src/utils/print.jl
0% <0%> (-57.15%)
:arrow_down:

src/utils/ybus_calculations.jl
0% <0%> (-42.86%)
:arrow_down:

src/models/branches/transformers.jl
33.33% <0%> (+8.33%)
:arrow_up:

src/utils/ptdf_calculations.jl
0% <0%> (-82.86%)
:arrow_down:

src/base.jl
100% <100%> (+12.76%)
:arrow_up:

src/models/generation.jl
100% <100%> (ø)

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e394263...8ddb9f0. Read the comment docs.

Tests passed locally on my machine.


Can't find correct object_detection folder

I'm having issues getting the "bash runDocker.sh" command to work properly. It keeps giving the error "bash: exec.sh: No such file or directory". When I run the command "bash exec.sh", it gives this error:
File "/home/username/Object-detection/utils/objDet_utils.py", line 5, in
from object_detection.utils import label_map_util
ImportError: No module named 'object_detection'
I'm guessing this is because it can't find the tensorflow folder with the object_detection folder it needs. I followed the installation instructions and I hopefully have "told" python where the correct object_detection folder is. Any ideas?

Alright I managed to find the object-detection folder it's talking about, but it is still unable to locate that folder properly

Hello @mhvanzui !
Sorry to answer so late. I had ton of things to do and not so much time to check this sandbox project last months ...
I hope you already find a solution to your problem. Nevertheless, the current version of this project work fine for me (running into the docker container from the provided dockerfile).
If you were trying to install tf-objectdetection outside of docker, I recommend you to take a look at the project github page (lot of usefull informations): https://github.com/tensorflow/models/blob/master/research/object_detection/g3doc/installation.md
Bye.


Document Neuropixels and related

Adding all Neuropixels related documentation in this PR.

Closing this PR, changes were merged and are being addressed in #162.


wstunnel on windows.

is it possible to use this library on windows?

referred commit done for issue https://github.com/rightscale/wstunnel/issues/34


TextFields don't support disabled input text styling

Raised internally at b/245672222.
Issue When a text field is in a disabled state (enabled: false), any initialText value doesn't have disabled text styling:

Expected We'd expect to see the input text in the same state as the other disabled values (ie. opacity 0.38):

(from https://m3.material.io/components/text-fields/specs)
This can be verified in the following Dartpad: https://dartpad.dev/?4d3d979fd0ff6b00823573c9d7e0d609
Or with the following constructors:
TextField(
    controller: TextEditingController(text: 'this text should be in disabled style but it is not'),
    decoration: const InputDecoration(
        enabled: false,
        icon: Icon(Icons.person),
        ),
    ),

or for a TextFormField:
TextFormField(
    initialValue: 'this text should be in disabled style but it is not',
    decoration: const InputDecoration(
        enabled: false,
        icon: Icon(Icons.person),
    ),
    onSaved: (String? value) { /* save something */ },
);

From some investigation, there's no direct way from the InputDecoration theme to override the input style.
It can, however, be overridden by changing the theme's value for textTheme.subtitle1, or directly modifying the input style in text_field.dart. This doesn't support state, so we cannot currently do something like:
TextStyle _m3InputStyle(BuildContext context) =>    MaterialStateTextStyle.resolveWith((Set<MaterialState> states) {
      final textTheme = Theme.of(context).textTheme;
      if (states.contains(MaterialState.disabled)) {
          return textTheme.bodyLarge!.copyWith(color: textTheme.bodyLarge!.color!.withOpacity(0.38));
      }
      return textTheme.bodyLarge!;
    });

Solution: Ideally, text_field.dart would be updated to permit state resolution.

Hello, @esouthren  Thanks for bringing this up. I was able to reproduce this issue on the following platform on the stable channel.

Android
iOS
Web
MacOS
Linux
Windows

✅
✅
✅
✅
✅
✅

CC @Renzo-Olivares


chore(formatting): adds prettier for consistent coding style

Adds auto-formating tools for better code-clarity and collaboration.
Why this patch?
The plugin's code is quite complex and missing a lot of dev-ops types
checks and standards. One of the key problems with codebases like this is
on-boarding new developers to the codebase (like myself). When there is
a consistent and enforced coding-style (irrespective of what the coding
style is) it makes it significantly easier for collaborators and
maintainers to get on with the job in hand. It also, from a day-2-day
developer perspective, significantly reduces cognitive overhead re
reading code.
Finally this is a "trial balloon" PR, if this patch is accepted I will
likely do more work on testing and docs for the project.
Notes on the config

The new prettier config is a non-standard setup, but a close-match to
how the code currently looks.
120 col-width print width (instead of the better and more
information-dense 88), this is so the diff after applying prettier to
the code is less disruptive, whilst still showing the benefits of using
a prettier.
We use tabWidth setting of 4 as the code uses that more common
setting instead of the more compact 2 spaces - note that 2 often leads
to more readable and compact code.
We enforce trailing commas, as that seems to be the norm in this
code-base. We choose the es5 standard here.
We enforce tailing semi-colons (semi) as the majority of code used
that flavour of js/ts.
For now we only run on code and not json files.

Notes on the tooling
This is designed such that npm run pretty re-formats the code for
development, and when integrated with ci/cd, prettyCheck will return
non-zero exit codes when formatting doesn't match the coding standards.

Thank you for your PR! I think this is an excellent workspace setup! It must be quite helpful for us.
However, could you refine it further with a bit of additional work? Here are some suggestions that I noticed:

Please ensure it is cross-platform runnable. (Windows cannot accept single quotes in filenames in the scripts.)
Additionally, I noticed that it cannot pass extra arguments (such as --check) to the subscripts. (However, This could be attributable to my setup mistakes).
Please add main_org.js to the .prettierignore.

I know it is a little rude to ask for more of your kind contributions, but please help us make it the best it can be!

Please ensure it is cross-platform runnable. (Windows cannot accept single quotes in filenames in the scripts.)

👍 Done with caveats: I don't have access to a windows box at the moment but I think the escaped double quotes \" should work.

Additionally, I noticed that it cannot pass extra arguments (such as --check) to the subscripts. (However, This could be attributable to my setup mistakes).

👍 My oversight was using yarn invocations instead of using npm. npm requires jumping through a couple more hoops. Thank you for highlighting this! 🙏

Please add main_org.js to the .prettierignore.

👍

I know it is a little rude to ask for more of your kind contributions, but please help us make it the best it can be!

全く失礼ではありません。迅速なご返信に感謝いたします。
Also note that I had mistakenly not re-run the prettier on the original code, after changing the printWidth to 120; doing so makes this initial diff much smaller and easier to reason about.

I have confirmed your kindly modification, and working fine also on Windows machine!
Thank you for your contribution! I am so happy to merge it!
P.S. And, very gratifyingly, my knowledge also has improved. I appreciate so much for you and so much for the Engineers' power of improving the world by sharing good things. そして日本語でのコメントもありがとうございます。ほっとします！


STORM-1602 Blobstore UTs are failed on Windows

ensures objects of InputStream / OutputStream are closed after using

clojure: with-open
java: try-with-resource

skip checking symbolic link in LocalizerTest when on Windows

Windows seems not handle symbolic link in compressed file properly

#1227 is based on 1.x-branch.

+1


Finetuning Microsoft Phi 3.5 Vision

I find Microsoft's Phi 3.5 vision instruct performs much better than Florence 2. Since it's an instruct model, it also has the benefit of taking text instruction as input to help describing the images with the desired syntax.
Since you already have a dataset, maybe it could be interesting to finetune this model too 😀
https://huggingface.co/microsoft/Phi-3.5-vision-instruct
Just sharing the idea! M
Thank you for sharing your work <3

mark~ something down the road to check out


Update mobile prepare models documentation

Correct the command line examples to match the actual location of freeze_graph.

Old command line example showed freeze_graph in tensorflow/tools
freeze_graph is actually located in tensorflow/python/tools. The documentation immediately above the command line example states this.
Modify the command line example to run using the tensorflow/python/tools location.
The command line for graph_transforms does not need to be updated.

Nagging Assignee @protoget: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @protoget: It has been 29 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.


feat: support websocket reverse proxy

What type of PR is this?

feat: A new feature
What this PR does / why we need it (English/Chinese):
Support reverse proxy for websocket
Which issue(s) this PR fixes:
Fixes (https://github.com/cloudwego/hertz/issues/926)

use gofumpt -e -d -w -extra .


Frequency modulation (FM)

How to modulate one waveform/track with another to achieve FM(Freq. Modulation)?

Hi, goal of plugin - simple API for sounds playback. You can't do really complex stuff.
To do this, you should work directly with WebAudio API.


boards: nrf52840dk_nrf52840: Do not enable arduino_serial by default

This is a follow-up to commit 25d7a09aa5e3b1826c1571872204852815df3ad0.
The arduino_serial/uart1 node should not be enabled by default because even if an application does not use it, the default CONFIG_SERIAL=y setting causes that it is anyway initialized, so the UARTE peripheral acquires its assigned pins (and they cannot be used in other way) and its enabled receiver causes increased current consumption (by ~500 uA) when the CPU is sleeping. This affects e.g. the boards/nrf/system_off sample.
Applications that actually need to use this UART or shields that use the arduino_serial node should enable the node explicitly.
Keep this node disabled by default for the nrf52840dk_nrf52840 board and also for boards whose definitions are mostly copies of the above: nrf52833dk_nrf52833 and nrf21540dk_nrf52840.
Update also accordingly a few overlay files in tests/ that were disabling this node because of the pins it undesirably acquired.
Signed-off-by: Andrzej Głąbek<EMAIL_ADDRESS>

Rebased.


Add primitive and boolean getter support to BeanInterfaceProxy

close #12

Coverage increased (+0.008%) to 99.095% when pulling 4e29b44a5ebb062176d0e749b30eb4cfee6514fe on dota17:ISSUE#12 into 208d3082cd5cdab39da8873cf741f8b672d1af5b on super-csv:master.


Clarify wording of CannotCoverFee API error.

Issue
https://input-output-rnd.slack.com/archives/CDM8B0AN9/p1627563147092700
Overview
This PR tries to clarify the wording of the CannotCoverFee API error.
It also fixes the broken "I need about pretty n ada" wording. (The "pretty" was erroneously included in the generated text output.)

bors r+

bors r+

Hmm
bors r+


fix Player.stop() not working

in src/Player/Player.ts on line 179 i changed data: { track: null }, to data: { track: { encoded: null } }, so <Player>.stop() works again (before it wasn't skipping the playing song)
I also ran npm run build to build it with the updated code

Looks Good!!


HADOOP-11823: dont check for verifier in RpcDeniedReply

When RPC returns a denied reply, the code should not check for a verifier. It is a bug as it doesn't match the RPC protocol. (See Page 33 from NFS Illustrated book).

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
35
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1052
trunk passed

+1
compile
1183
trunk passed

+1
checkstyle
20
trunk passed

+1
mvnsite
29
trunk passed

+1
shadedclient
682
branch has no errors when building and testing our client artifacts.

+1
javadoc
22
trunk passed

0
spotbugs
39
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
38
trunk passed

_ Patch Compile Tests _

+1
mvninstall
20
the patch passed

+1
compile
996
the patch passed

+1
javac
996
the patch passed

+1
checkstyle
24
the patch passed

+1
mvnsite
29
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
633
patch has no errors when building and testing our client artifacts.

+1
javadoc
24
the patch passed

+1
findbugs
50
the patch passed

_ Other Tests _

+1
unit
42
hadoop-nfs in the patch passed.

+1
asflicense
41
The patch does not generate ASF License warnings.

5033

Subsystem
Report/Notes

Docker
Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-106/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/106

JIRA Issue
HADOOP-11823

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 3f42594db77d 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 7f1b76c

Default Java
1.8.0_212

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-106/1/testReport/

Max. process+thread count
447 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-nfs U: hadoop-common-project/hadoop-nfs

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-106/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
39
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1029
trunk passed

+1
compile
998
trunk passed

+1
checkstyle
21
trunk passed

+1
mvnsite
30
trunk passed

+1
shadedclient
694
branch has no errors when building and testing our client artifacts.

+1
javadoc
25
trunk passed

0
spotbugs
38
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
35
trunk passed

_ Patch Compile Tests _

+1
mvninstall
18
the patch passed

+1
compile
972
the patch passed

+1
javac
972
the patch passed

+1
checkstyle
17
the patch passed

+1
mvnsite
31
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
615
patch has no errors when building and testing our client artifacts.

+1
javadoc
26
the patch passed

+1
findbugs
43
the patch passed

_ Other Tests _

+1
unit
41
hadoop-nfs in the patch passed.

+1
asflicense
40
The patch does not generate ASF License warnings.

4781

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-106/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/106

JIRA Issue
HADOOP-11823

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 37a3bd54fe3c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 62efb63

Default Java
1.8.0_212

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-106/2/testReport/

Max. process+thread count
448 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-nfs U: hadoop-common-project/hadoop-nfs

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-106/2/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
35
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1175
trunk passed

+1
compile
1067
trunk passed

+1
checkstyle
23
trunk passed

+1
mvnsite
32
trunk passed

+1
shadedclient
173
branch has no errors when building and testing our client artifacts.

+1
javadoc
27
trunk passed

0
spotbugs
43
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
41
trunk passed

_ Patch Compile Tests _

+1
mvninstall
20
the patch passed

+1
compile
1046
the patch passed

+1
javac
1046
the patch passed

+1
checkstyle
24
the patch passed

+1
mvnsite
32
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
727
patch has no errors when building and testing our client artifacts.

+1
javadoc
27
the patch passed

+1
findbugs
51
the patch passed

_ Other Tests _

+1
unit
48
hadoop-nfs in the patch passed.

+1
asflicense
43
The patch does not generate ASF License warnings.

4721

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-106/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/106

JIRA Issue
HADOOP-11823

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 3f2d9f1b7eb0 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / e872ceb

Default Java
1.8.0_212

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-106/3/testReport/

Max. process+thread count
315 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-nfs U: hadoop-common-project/hadoop-nfs

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-106/3/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
69
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1068
trunk passed

+1
compile
1031
trunk passed

+1
checkstyle
26
trunk passed

+1
mvnsite
29
trunk passed

+1
shadedclient
785
branch has no errors when building and testing our client artifacts.

+1
javadoc
27
trunk passed

0
spotbugs
39
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
38
trunk passed

_ Patch Compile Tests _

+1
mvninstall
21
the patch passed

+1
compile
1009
the patch passed

+1
javac
1009
the patch passed

+1
checkstyle
25
the patch passed

+1
mvnsite
31
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
634
patch has no errors when building and testing our client artifacts.

+1
javadoc
27
the patch passed

+1
findbugs
45
the patch passed

_ Other Tests _

+1
unit
42
hadoop-nfs in the patch passed.

+1
asflicense
39
The patch does not generate ASF License warnings.

5070

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-106/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/106

JIRA Issue
HADOOP-11823

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 8f7be2be646c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 00b5a27

Default Java
1.8.0_222

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-106/4/testReport/

Max. process+thread count
412 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-nfs U: hadoop-common-project/hadoop-nfs

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-106/4/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
41
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1051
trunk passed

+1
compile
1051
trunk passed

+1
checkstyle
21
trunk passed

+1
mvnsite
25
trunk passed

+1
shadedclient
669
branch has no errors when building and testing our client artifacts.

+1
javadoc
25
trunk passed

0
spotbugs
38
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
37
trunk passed

_ Patch Compile Tests _

+1
mvninstall
17
the patch passed

+1
compile
989
the patch passed

+1
javac
989
the patch passed

+1
checkstyle
18
the patch passed

+1
mvnsite
26
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
637
patch has no errors when building and testing our client artifacts.

+1
javadoc
24
the patch passed

+1
findbugs
49
the patch passed

_ Other Tests _

+1
unit
43
hadoop-nfs in the patch passed.

+1
asflicense
42
The patch does not generate ASF License warnings.

4887

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-106/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/106

JIRA Issue
HADOOP-11823

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux e81a9e50dca4 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 8943e13

Default Java
1.8.0_222

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-106/5/testReport/

Max. process+thread count
412 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-nfs U: hadoop-common-project/hadoop-nfs

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-106/5/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
65
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1180
trunk passed

+1
compile
1059
trunk passed

+1
checkstyle
19
trunk passed

+1
mvnsite
27
trunk passed

+1
shadedclient
689
branch has no errors when building and testing our client artifacts.

+1
javadoc
27
trunk passed

0
spotbugs
43
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
40
trunk passed

_ Patch Compile Tests _

+1
mvninstall
18
the patch passed

+1
compile
1119
the patch passed

+1
javac
1119
the patch passed

+1
checkstyle
19
the patch passed

+1
mvnsite
28
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
632
patch has no errors when building and testing our client artifacts.

+1
javadoc
23
the patch passed

+1
findbugs
47
the patch passed

_ Other Tests _

+1
unit
44
hadoop-nfs in the patch passed.

+1
asflicense
41
The patch does not generate ASF License warnings.

5206

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-106/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/106

JIRA Issue
HADOOP-11823

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux cee25b4ea04c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 4cb22cd

Default Java
1.8.0_222

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-106/6/testReport/

Max. process+thread count
447 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-nfs U: hadoop-common-project/hadoop-nfs

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-106/6/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
158
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1406
trunk passed

+1
compile
1347
trunk passed

+1
checkstyle
32
trunk passed

+1
mvnsite
39
trunk passed

+1
shadedclient
907
branch has no errors when building and testing our client artifacts.

+1
javadoc
29
trunk passed

0
spotbugs
47
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
45
trunk passed

_ Patch Compile Tests _

+1
mvninstall
24
the patch passed

+1
compile
1079
the patch passed

+1
javac
1079
the patch passed

+1
checkstyle
24
the patch passed

+1
mvnsite
29
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
717
patch has no errors when building and testing our client artifacts.

+1
javadoc
28
the patch passed

+1
findbugs
48
the patch passed

_ Other Tests _

+1
unit
42
hadoop-nfs in the patch passed.

+1
asflicense
57
The patch does not generate ASF License warnings.

6151

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-106/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/106

JIRA Issue
HADOOP-11823

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux da89ff560e7f 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / e04dcfd

Default Java
1.8.0_212

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-106/7/testReport/

Max. process+thread count
340 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-nfs U: hadoop-common-project/hadoop-nfs

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-106/7/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
37
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1098
trunk passed

+1
compile
1031
trunk passed

+1
checkstyle
32
trunk passed

+1
mvnsite
37
trunk passed

+1
shadedclient
757
branch has no errors when building and testing our client artifacts.

+1
javadoc
34
trunk passed

0
spotbugs
48
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
45
trunk passed

_ Patch Compile Tests _

+1
mvninstall
22
the patch passed

+1
compile
994
the patch passed

+1
javac
994
the patch passed

+1
checkstyle
31
the patch passed

+1
mvnsite
37
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
665
patch has no errors when building and testing our client artifacts.

+1
javadoc
32
the patch passed

+1
findbugs
55
the patch passed

_ Other Tests _

+1
unit
50
hadoop-nfs in the patch passed.

+1
asflicense
49
The patch does not generate ASF License warnings.

5137

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-106/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/106

JIRA Issue
HADOOP-11823

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux ada61698f5b9 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 3329257

Default Java
1.8.0_222

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-106/8/testReport/

Max. process+thread count
413 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-nfs U: hadoop-common-project/hadoop-nfs

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-106/8/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
124
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1221
trunk passed

+1
compile
1211
trunk passed

+1
checkstyle
26
trunk passed

+1
mvnsite
32
trunk passed

+1
shadedclient
815
branch has no errors when building and testing our client artifacts.

+1
javadoc
26
trunk passed

0
spotbugs
45
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
41
trunk passed

_ Patch Compile Tests _

+1
mvninstall
23
the patch passed

+1
compile
1067
the patch passed

+1
javac
1067
the patch passed

+1
checkstyle
25
the patch passed

+1
mvnsite
31
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
753
patch has no errors when building and testing our client artifacts.

+1
javadoc
28
the patch passed

+1
findbugs
51
the patch passed

_ Other Tests _

+1
unit
44
hadoop-nfs in the patch passed.

+1
asflicense
45
The patch does not generate ASF License warnings.

5699

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-106/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/106

JIRA Issue
HADOOP-11823

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux c2582b257ed4 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 915cbc9

Default Java
1.8.0_222

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-106/9/testReport/

Max. process+thread count
306 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-nfs U: hadoop-common-project/hadoop-nfs

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-106/9/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.


[ENH] Lambda step: Add support for kwargs in function

Codecov Report

Merging #8 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master      #8   +/-   ##
======================================
  Coverage    96.5%   96.5%
======================================
  Files          13      13
  Lines         600     600
  Branches      114     114
======================================
  Hits          579     579
  Misses         14      14
  Partials        7       7

Impacted Files
Coverage Δ

baikal/steps/expression.py
100% <100%> (ø)
:arrow_up:

baikal/_core/step.py
94.39% <0%> (ø)
:arrow_up:

baikal/_core/model.py
100% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f31aae...18c2c12. Read the comment docs.


Wrong place for 3522 in russia_kazakhstan_abkhasia_south_ossetia.ndcs_with_5_subscriber_digit

Noted that Phony.plausible?("+73522456729") returns false.
That's because the code 3522 is located in ndcs_with_5_subscriber_digit instead of ndcs_with_6_subscriber_digits.

Thanks so much, again!


Create Disenroll Command

remove student from lesson
Syntax disenroll /l lesson /s student

closed after feature scope discussion


Compatibility with Forge and/or ModLoader(MP)

Compatibility with ML(MP) can be easily achieved by editing the client (and) server jar.
However, Forge requires some patching procedure and so I am not sure if RetroMCP-Java is directly compatible with it.
Is there any way to use Forge (and ML(MP)) with RetroMCP-Java or does this need additional changes inside RetroMCP-Java?

The best way to use Forge in RMCP-J is to use the reobfuscated binaries provided on SourceForge and other archives and decompile it alongside MC. Fernflower usually decompiles it without errors, but what it misses, are simple.

There is no full support for Forge and ML yet due to the lack of patches, however you can still edit jars in jars/ after running setup task. Be it patching or simply adding class files to a jar. Then you can run decompile on the modified jars and fix all errors that weren't patched automatically.

Okay, thank you very much for the information. I succeeded in doing it with @PhoenixVX's approach.
You can decide whether to leave this issue open. For me, this is kind of solved now

@ThexXTURBOXx
Could you provide exact steps to add Forge to this MCP distribution?
I've tried doing it myself but failed.
Here is what i did:

Added contents of the client-forge.zip for 1.2.5 from Forge official site to minecraft.jar
Decompiled
Got bunch of decompilation errors

 Error on line 780 in src\minecraft\forge\MinecraftForge.java
 method next() is already defined in class forge.MinecraftForge.OreQuery.OreQueryIterator

 Error on line 576 in src\minecraft\forge\ForgeHooksClient.java
 int cannot be dereferenced

 Error on line 577 in src\minecraft\forge\ForgeHooksClient.java
 int cannot be dereferenced

You don't need to worry about the sources not matching the compiled classes. Only thing you need to worry about are the reobfuscation hashes to tell if these classes are edited, which updatemd5 exists for.

I was able to add Forge (and MLMP for that matter) to all versions which they are (respectively) available for. As already said, you run setup and install Forge as always: By isntalling the client and server files to the minecraft.jar and minecraft_server.jar, respectively.
After that, run decompile and you will see that it will try recompiling the sources in the end, which fails (most likely).
Then, you need to fix the decompiled sources according to the error messages. Then, run updatemd5 as already said and it should be fine.
You can now use your setup as usual.

Ah, ok, i didn't knew that there are usable src files even if decompilation fails and you can actually edit them.
I've had preconception that i need to fix them beforehand so that.
Still it's gonna be a hassle to get any decompiled mod up and running due to structure difference with old MCP.
Thanks for help.

Well.... I guess the other option is for somebody to port all the patches to Diffpatch, which is Forge's current library for patching source code, that RMCP also uses.

What is basic workflow required to add a patch?
I would also like to know if it will be much different from adding a new target version, for example 1.4.7?

The basic workflow for adding a patch is to decompile the game, and fix the sources, then use the createpatches command to generate patches in the root of the MCP folder. It will patch from the decompiled source to the fixed source (temp/client/src -> src/minecraft).
As for adding a version, that requires numerous parts. First of which is to create a versions.json in the same folder as RetroMCP which will replace the version JSON gotten from the MCPHackers website. The next is to create or port mappings for said version either through Enigma or Matcher (can be used to match mappings from nearby versions). Next is to create patches if necessary (they haven't been necessary for versions after alpha. Next is to create Exceptor patches which fix methods to have throws SomeException. Finally, you should be able to make a workspace that does all this instantly.
If you want to look at the format, https://mcphackers.github.io/versions/versions.json is what is used for RetroMCP.

Ok, i'm thinking it might be useful to port old .srg(+ .csv files) mappings to new .tiny ones.
Because as i see it fixing forge sources after adding it to .jar file is one thing.
But there is also mod sources with different mapped names.
I could add their obfuscated version to .jar and fix them along with the forge ones but i think it'll be easier with old mappings because you can use previous mod sources unchanged.
Is there such converter already?
If not i would like to get any info about .tiny and old .srg mapping structure to try to write a converter.

I've created multiple converters for SRG to Tiny, but all of them are mainly only useful for a certain version range.
As for the above, Forge is supposed to be decompiled alongside MC, do not use the Forge sources. The mappings will automatically adjust the source properly.
As for the Tiny mapping and SRG mapping spec, that's not all you need. You first need to know if you are going to be using Tiny v1 (doesn't preserve parameters, very similar to SRG) or Tiny v2 (Not similar to SRG), but in either case, it will require knowing ASM (thus Minecraft on the classpath) as SRG doesn't use signatures, but Tiny does. After that, you finally realize that mappings are NOT set in the SRG. The SRG just apply intermediary names to fields and methods, while mapping class names. The CSVs in the conf folder perform the remapping of SRG to named mappings, so you need to read the CSVs also.
In other words, it's a huge pain. I can probably help you get setup with this if you are on Modification Station though, and if I have time, I may even be able to write one for you.
Tiny v2 spec: https://github.com/FabricMC/tiny-remapper/issues/9

You can re-export SRGs as Tiny v2 straight from Enigma. Not sure why @PhoenixVX is overcomplicating it. And also, you shouldn't have any trouble adding mod sources if they used original MCP mappings, because that's what RetroMCP is using for all versions which were already in MCP (except for a1.1.1-a1.1.2_01). Other versions were mapped either from scratch or matched from another version.

The SRGs don't contain the mappings. They contain the intermediary names, unless you like field_1234_j and func_13843_a for fields and methods respectively, that is not useful to anyone.

Ones in conf are useless. You need SRGs from temp which are produced upon decompiling.


Tabs: Add light variant

The problem
Carbon core recently implemented light variant of tabs.
The solution
Implement it.

@asudoh Just cleaning up the issues related to the Carbon Web Components January 13 release.  This issue is included in the release, but doesn't appear to be finished.  Should I move this issue to the next release in March?
cc:  @jeffchew

@asudoh Just cleaning up the issues related to the Carbon Web Components January 13 release.  This issue is included in the release, but doesn't appear to be finished.  Should I move this issue to the next release in March?
cc:  @jeffchew

@asudoh I just found my notes on the scheduling of this issue.  Moving it to the March release.
cc:  @jeffchew

@asudoh I just found my notes on the scheduling of this issue.  Moving it to the March release.
cc:  @jeffchew


videojs 6 deprication

videojs version: 6.8.0
use the plugin as npm package (yarn add videojs-markers)
I get 2 warnings on run time:

videojs.plugin() is deprecated; use videojs.registerPlugin() instead
videojs.createEl() is deprecated; use videojs.dom.createEl() instead

It's still working, bug it's better to fix those warning

Seems like there is a pull request for this issue:
https://github.com/spchuang/videojs-markers/pull/86
Is it possible to review and approve it. Thanks.

just accepted the pr

Thanks!!
Please bump the version and publish it to npm.

It seems like the main maintainer has left GitHub. :(
Due to this, I've released new version in the fork - npm.

Hi, I'm happy to add other folks as collaborators if anyone is interested. I can also give access to update the npm package so people can continue with the same one without having to change to a new one

@spchuang Is it fixed?


Update self_cell to v0.10.0

Hi, I'm the author of self_cell and I've recently released a new version and yanked all previous versions due to serious soundness bugs (see https://github.com/Voultapher/self_cell/releases/tag/v0.10.0 for details). These have been addressed and as far as I can tell your project was not directly affected. Regardless I've taken the precaution of yanking all previously affected versions and am now going through reverse dependents updating them. The tests pass and the interface stayed the same so I hope this PR is fine as is.

excellent, have been looking forward to this fix!

v0.15.1 published


add license and license statement

Source: DIDEO review by W.R. Hogan, 01/29/2016

I suggest Creative Commons BY 3.0:
http://creativecommons.org/licenses/by/3.0/

After consultation with Richard Boyce, I added the license. Based on OBO Foundry suggestions I went with BY 4.0 (https://creativecommons.org/licenses/by/4.0/)


Add aria-label to search input

https://github.com/react-bootstrap-table/react-bootstrap-table2/issues/930

@zhr1130 thanks, I will publish in next release


Exception (CpuTypeForTestBundleAtPath) running Xcode 7 GUI tests

Running with current master branch of xctool -- regular unit tests work fine. Running test against an Xcode 7 GUI test target gave me this
 [Info] Collecting info for testables...2015-08-03 10:33:24.315 xctool[37209:4760274] *** Assertion failure in cpu_type_t CpuTypeForTestBundleAtPath(NSString *__strong)(), /Users/xxxx/src/xctool/xctool/xctool/XCToolUtil.m:890
2015-08-03 10:33:24.315 xctool[37209:4760274] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Bundle's executable code doesn't support nor i386, nor x86_64 CPU types. Bundle path: /Users/xxxx/Library/Developer/Xcode/DerivedData/xxxxxxx-dhccsjqgjrauqgcfaozlviqpoeno/Build/Products/Debug-iphonesimulator/XXXXXXGUITests.xctest, supported cpu types: (null).'
*** First throw call stack:
(
	0   CoreFoundation                      0x00007fff95e1e03c __exceptionPreprocess + 172
	1   libobjc.A.dylib                     0x00007fff91a0976e objc_exception_throw + 43
	2   CoreFoundation                      0x00007fff95e1de1a +[NSException raise:format:arguments:] + 106
	3   Foundation                          0x00007fff9850a753 -[NSAssertionHandler handleFailureInFunction:file:lineNumber:description:] + 169
	4   xctool                              0x000000010ac8c83a CpuTypeForTestBundleAtPath + 1531
	5   xctool                              0x000000010acaccaa -[SimulatorInfo productBundlePathCpuType] + 63
	6   xctool                              0x000000010acacd22 -[SimulatorInfo simulatedCpuType] + 86
	7   xctool                              0x000000010acace70 -[SimulatorInfo simulatedDeviceInfoName] + 198
	8   xctool                              0x000000010acad47f -[SimulatorInfo maxSdkVersionForSimulatedDevice] + 56
	9   xctool                              0x000000010acad5ff -[SimulatorInfo simulatedSdkVersion] + 134
	10  xctool                              0x000000010acad8b8 -[SimulatorInfo systemRootForSimulatedSdk] + 40
	11  xctool                              0x000000010acada6e -[SimulatorInfo simulatedRuntime] + 63
	12  xctool                              0x000000010acadc85 -[SimulatorInfo simulatedDevice] + 82
	13  xctool                              0x000000010acab42b CreateTaskForSimulatorExecutable + 265
	14  xctool                              0x000000010acbcea3 -[OCUnitIOSLogicTestQueryRunner createTaskForQuery] + 462
	15  xctool                              0x000000010ac9871a -[OCUnitTestQueryRunner runQueryWithError:] + 364
	16  xctool                              0x000000010acb9959 +[TestableExecutionInfo queryTestCasesWithSimulatorInfo:error:] + 411
	17  xctool                              0x000000010acb8ede +[TestableExecutionInfo infoForTestable:buildSettings:simulatorInfo:] + 300
	18  xctool                              0x000000010ac9e0aa __56-[RunTestsAction runTestables:options:xcodeSubjectInfo:]_block_invoke + 860
	19  libdispatch.dylib                   0x00007fff90efb323 _dispatch_call_block_and_release + 12
	20  libdispatch.dylib                   0x00007fff90ef6c13 _dispatch_client_callout + 8
	21  libdispatch.dylib                   0x00007fff90efa365 _dispatch_queue_drain + 1100
	22  libdispatch.dylib                   0x00007fff90efbecc _dispatch_queue_invoke + 202
	23  libdispatch.dylib                   0x00007fff90ef96b7 _dispatch_root_queue_drain + 463
	24  libdispatch.dylib                   0x00007fff90f07fe4 _dispatch_worker_thread3 + 91
	25  libsystem_pthread.dylib             0x00007fff93444637 _pthread_wqthread + 729
	26  libsystem_pthread.dylib             0x00007fff9344240d start_wqthread + 13
)
libc++abi.dylib: terminating with uncaught exception of type NSException

../xctool/xctool.sh: line 54: 37209 Abort trap: 6           "$XCTOOL_DIR"/build/$REVISION/$XCODEBUILD_VERSION/Products/Release/bin/xctool "$@"

If I put in a simple fix (  if (!archs) return CPU_TYPE_ANY;), then I get this error:
Failed to query the list of test cases in the test bundle: The bundle at /Users/xxx/Library/Developer/Xcode/DerivedData/xxxx-dhccsjqgjrauqgcfaozlviqpoeno/Build/Products/Debug-iphonesimulator/xxxxGUITests.xctest does not contain an executable.
It looks like GUI test bundles are sufficiently different to need more fixes than just this.

We aren't going to add Xcode 7 UI tests supporter in the nearest future (subscribe here: https://github.com/facebook/xctool/issues/534).
I have tried to work on this about a month ago and was able to almost make xctool run them but then I hit the issue in Xcode 7 test framework or somewhere else. For now I am waiting for more stable releases on Xcode 7 and probably will give it a shot one more time later but it isn't hi-pri for us, unfortunately. If you want to try to fix it I can share my work in a separate brunch.
Closing in favor of https://github.com/facebook/xctool/issues/534.

It's not high enough priority for us yet either.  GUI tests seem to not be very stable yet -- we're just experimenting.  Once there's a release, we'll revisit.  I subscribed to the other issue to keep track and possibly pitch in later.

Sounds good!

@ExtremeMan I'm looking into picking this up. Is the nekto/support_ui_testing branch up to date with the work you did? Also, if you could give me a summary of the issues you ran into that would be great.

Replied in https://github.com/facebook/xctool/issues/534.

@ExtremeMan I seem to be getting the same when trying to run Specta tests with xctool and Xcode 7 GM #580


The object storage service benchmarks should specify specific versions of libraries rather than pull the latest

In pull request #446  PKB was updated to handle the new Azure storage libraries.  What we should do to avoid breaks like this in the future is to declare the version on the pip install etc in the prepare.

Done. https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/461


feat: make credentials optional in test mode with warnings

[!IMPORTANT]
Make credentials optional in test mode by introducing a Credential enum and updating providers to handle missing credentials gracefully.

Behavior:

Credential enum introduced in model.rs to handle credentials as Static, Dynamic, FileContents, None, or Missing.
AnthropicProvider and OpenAIProvider constructors updated to accept Credential instead of CredentialLocation.
get_api_key method in AnthropicProvider and OpenAIProvider now returns Option to handle missing credentials.
In test mode, missing credentials are logged as warnings instead of causing errors.

Provider Config:

ProviderConfig deserialization updated to convert CredentialLocation to Credential using try_from method.
Default API key locations for Anthropic and OpenAI providers made public.

Misc:

Removed unused std::env imports from anthropic.rs and openai.rs.

This description was created by  for 75482dd36eb4655b68880a15ba8d548617b0befc. It will automatically update as commits are pushed.

sounds good; now the flow is much clearer

@virajmehta I was thinking - what if we implement TryFrom for provider credentials to keep the conversion logic separate? Since I'm already working on the new() function changes, I could do this for all providers if you think it's useful. What are your thoughts?
Like:
impl TryFrom<Credential> for AnthropicCredentials {
   fn try_from(credential: Credential) -> Result<Self, Error> {
       match credential {
           Credential::Static(key) => Ok(AnthropicCredentials::Static(key)),
           // ... other matches
       }
   }
}

@virajmehta I was thinking - what if we implement TryFrom for provider credentials to keep the conversion logic separate? Since I'm already working on the new() function changes, I could do this for all providers if you think it's useful. What are your thoughts?
Like:
impl TryFrom<Credential> for AnthropicCredentials {
   fn try_from(credential: Credential) -> Result<Self, Error> {
       match credential {
           Credential::Static(key) => Ok(AnthropicCredentials::Static(key)),
           // ... other matches
       }
   }
}

I think this is sensible if the logic is: Pass in an optional into Provider::new(), unwrap_or(default_location), use the TryFrom from that into a Credential, then use the TryFrom from that into a provider-specific credential. Does that match what you were thinking?

@virajmehta I was thinking - what if we implement TryFrom for provider credentials to keep the conversion logic separate? Since I'm already working on the new() function changes, I could do this for all providers if you think it's useful. What are your thoughts?
Like:
impl TryFrom<Credential> for AnthropicCredentials {
   fn try_from(credential: Credential) -> Result<Self, Error> {
       match credential {
           Credential::Static(key) => Ok(AnthropicCredentials::Static(key)),
           // ... other matches
       }
   }
}

I think this is sensible if the logic is: Pass in an optional into Provider::new(), unwrap_or(default_location), use the TryFrom from that into a Credential, then use the TryFrom from that into a provider-specific credential. Does that match what you were thinking?

Yes, exactly! The flow would be

Optional location -> unwrap_or(default)
CredentialLocation -> Credential (using existing TryFrom)
Credential -> Provider-specific credential (using new TryFrom)

Yes, exactly! The flow would be

Optional location -> unwrap_or(default)
CredentialLocation -> Credential (using existing TryFrom)
Credential -> Provider-specific credential (using new TryFrom)

cool let's do that

Yes, exactly! The flow would be

Optional location -> unwrap_or(default)
CredentialLocation -> Credential (using existing TryFrom)
Credential -> Provider-specific credential (using new TryFrom)

cool let's do that -- thank you for being thoughtful here!

I've updated all providers to handle optional credentials in test mode following earlier feedback. let me know if anything needs to be changed.

@virajmehta I don't think so. We need E2E tests for the "standard" case where credentials are provided, or dynamic inference is used. But not for the "don't panic on E2E tests missing credentials".

@virajmehta  added unit tests for credential handling in all providers. each test covers:

static credentials
dynamic credentials
missing credentials (test mode)
invalid credential types and error cases

let me know if the test coverage looks good and I can move on to adding e2e tests for standard credential flows.

@virajmehta added unit tests for credential handling in all providers. each test covers:

static credentials
dynamic credentials
missing credentials (test mode)
invalid credential types and error cases

let me know if the test coverage looks good and I can move on to adding e2e tests for standard credential flows.

Unit test coverage looks good! The current e2e tests already test the default heavily. What I would do there is pick a test type and change it to dynamic credentials just so that this code path is covered for each model provider. This shouldn't take too long. Thanks for all your help!


Updating the element templates with camunda:Connector leads to duplicated camunda:connector element in XML

Describe the bug
Given one template on my local machine
When I make a change to it i.e. increase the version number
The upgrade is correctly suggested in the UI. ✔
When upgrade to the newer version
Then the one camunda:connector element in the XML is not replaced, but it is duplicated. ❌
Steps to reproduce

Create a new template in your element-template folder in your Camunda Desktop Modeler installation with the following content:

This is the same template example provided here that uses the Camunda 7 Connectors. See docs here and here
{
  "$schema"<EMAIL_ADDRESS>  "name": "ConnectorGetTask-LOCAL",
  "id": "9a158cf8-c500-40d8-90a5-c4a62727684110",
  "appliesTo": [
    "bpmn:Task"
  ],
  "version": 1,
  "properties": [],
  "scopes": [
    {
      "type": "camunda:Connector",
      "properties": [
        {
          "label": "ConnectorId",
          "type": "String",
          "value": "My Connector HTTP - GET",
          "binding": {
            "type": "property",
            "name": "connectorId"
          }
        },
        {
          "label": "Method",
          "type": "String",
          "value": "GET",
          "binding": {
            "type": "camunda:inputParameter",
            "name": "method"
          }
        },
        {
          "label": "URL",
          "type": "String",
          "value": "https://bpmn.io",
          "binding": {
            "type": "camunda:inputParameter",
            "name": "url"
          }
        },
        {
          "label": "Response",
          "type": "String",
          "value": "wsResponse",
          "binding": {
            "type": "camunda:outputParameter",
            "source": "${S(response)}",
            "scriptFormat": "freemarker"
          }
        }
      ]
    }
  ]
}

Create a new C7 BPMN diagram and add a task to it

Apply the template to the task and save

Increase the version number in the template from 1 to 2

Go to your diagram from (3.) and Upgrade the template

Open the XML view and see two entries of camunda:connector in the XML

See screen recording:
https://user-images.githubusercontent.com/25924333/192004921-64472a7e-0147-4a23-82f9-e49a746341ff.mov
And the only difference between the two templates is the version:

Expected behavior
The upgrade of the template should replace my cammunda:Connector, not duplicate it.
Environment

OS: all
Camunda Modeler Versions : tested in v4.12.0 and v5.3.0
Execution Platform: Camunda Platform 7
Installed plug-ins: Cawemo Cloud Connect Plugin

Additional context
The issue has been reported by a customer via SUPPORT-14645

Thanks for reporting. Moving to backlog for the moment.
CC @christian-konrad.

In case we fix this, this would require a patch release of 4.12 since the customer is not able to migrate their plugins to 5.x for now.
@nikku I assume it's been a while since the last patch release was built (I think it was v4.8.1). What's the effort to provide one (in case we already have this fixed in 5.x)?

Low effort to patch release this. We have an existing process + branching strategy in place.

Hi Team, customer has migrated their plugins to V5.x now.  Is it possible to get a timeline for a fix on V5?

Hello, any news on fixing this issue?


Feat: Create VC as JWT

Description

In the Controllers, an option has been added to generate a VC as a JWT (JSON Web Token). By default, this option is set to false. When set to true, the response will be a JWT containing the VC.
Additionally, certain exception handling has been revised and corrected due to the integration of the new SSI-lib

Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review:

[ ] DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
[ ] Copyright and license header are present on all affected files

should be with the latest ssi agent lib current (main) in order for the tests to work @borisrizov-zf

@mustafasalfiti I'll ping you when the new release of the ssi-lib is out, so you can update.

IP check link: https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/14592
IP check status: Approved
Ready to merge.

@mustafasalfiti please rebase to the latest develop version (there was a minor update merged a week ago).

@thackerronak Hi, it seems something went wrong with the rebase/merge since now we're getting unwanted changed in the CHANGELOG. Please review and push again.

@borisrizov-zf Rebase is done

@nitin-vavdiya Hi, I'm doing manual tests. If all goes well, I'll merge and notify you.

Dash review required
https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/14889


add kinesis lag metric

Fixes #6739.
Description
This PR adds an additional set of SeekableStreamSupervisor lag metrics, based on time in millis behind the latest offsets of the stream, allowing the Kinesis indexing service extension to have a lag metric. scheduleReporting  and emitLag were pushed down from KafkaSupervisor into SeekableStreamSupervisor, and two additional abstract methods, getPartitionRecordLag and getPartitionTimeLag which collect the two types of lag metrics per partition of the stream.
Kafka's existing lag metrics are still collected in the same format for backwards compatibility.
ingest/{supervisor type}/lag
ingest/{supervisor type}/maxLag
ingest/{supervisor type}/avgLag

and the new time metrics have a /time suffix.
ingest/{supervisor type}/lag/time
ingest/{supervisor type}/maxLag/time
ingest/{supervisor type}/avgLag/time

Currently KafkaSupervisor only emits the former set of metrics, and KinesisSupervisor, after this PR, will emit only the latter. It seems possible for KafkaSupervisor to emit both sets of metrics, but I will save that for a follow-up PR.

This PR has:

[ ] been self-reviewed.

[ ] using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)

[ ] added documentation for new or modified features or behaviors.
[ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
[ ] added or updated version, license, or notice information in licenses.yaml
[ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
[ ] added unit tests or modified existing tests to cover new code paths.
[ ] added integration tests.
[ ] been tested in a test Druid cluster.

Key changed/added classes in this PR

SeekableStreamSupervisor
KafkaSupervisor
KinesisSupervisor

Codecov Report

Merging #9509 into master will increase coverage by 0.98%.
The diff coverage is 57.89%.

@@             Coverage Diff              @@
##             master    #9509      +/-   ##
============================================
+ Coverage     63.56%   64.55%   +0.98%
- Complexity    23489    23571      +82
============================================
  Files          3040     2932     -108
  Lines        125895   119897    -5998
  Branches      17410    16048    -1362
============================================
- Hits          80026    77394    -2632
+ Misses        38673    35519    -3154
+ Partials       7196     6984     -212

Impacted Files
Coverage Δ
Complexity Δ

...pervisor/SeekableStreamSupervisorTuningConfig.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

.../kafka/supervisor/KafkaSupervisorTuningConfig.java
100% <ø> (ø)
12 <0> (ø)
:arrow_down:

...xing/seekablestream/supervisor/TaskReportData.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...esis/supervisor/KinesisSupervisorTuningConfig.java
100% <100%> (ø)
12 <1> (+1)
:arrow_up:

.../druid/indexing/kinesis/KinesisRecordSupplier.java
55.27% <100%> (+0.84%)
35 <2> (+2)
:arrow_up:

...uid/indexing/kafka/supervisor/KafkaSupervisor.java
79.51% <20%> (+10.49%)
24 <1> (-1)
:arrow_down:

...blestream/supervisor/SeekableStreamSupervisor.java
27.25% <59.18%> (+1.5%)
62 <5> (+7)
:arrow_up:

...indexing/kinesis/supervisor/KinesisSupervisor.java
75% <83.33%> (+0.21%)
33 <2> (+1)
:arrow_up:

...main/java/org/apache/druid/guice/DruidBinders.java
33.33% <0%> (-8.34%)
3% <0%> (ø)

...org/apache/druid/segment/realtime/FireHydrant.java
58.33% <0%> (-8.34%)
14% <0%> (-1%)

... and 148 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7401bb3...646a70b. Read the comment docs.


Gradient boosting classifier

Objective

Fixes: https://github.com/mapbox/gabbar/issues/11
Jupyter notebook: notebooks/GradientBoostingClassifier.ipynb

Features of changeset used

Features created
Features modified
Features deleted
Area of changeset bbox
Total user changesets
Total user features

Algorithm

sklearn.ensemble.GradientBoostingClassifier

Metrics
Classification report
                    precision    recall  f1-score   support

problematic         0.99      0.64      0.77      1522
not problematic     0.95      1.00      0.97      9956

avg / total         0.95      0.95      0.95     11478

Metric from cross-validation: 0.95

Closing in favor of: https://github.com/mapbox/gabbar/pull/30


Up Frames can connect to multiple child components and fix data propagation on attach/detach/delete

Frames are a bit messy, but functional! I will be refactoring this into modules in another pass this week, but I want to get this out there for now.
This PR includes the following changes:

Up Frames can now take inputs from multiple children (for example, when turning a Butane Component into an Up Frame and dropping multiple Docker Images inside)
When you attach a component to a parent, we will now run queue up only those input socket's Attribute Values for Dependent Values Update that have different inputs as a result of the attachment (this fixes a bug where we were not always re-running the right functions, which was the original bug)
When you orphan a component, we first cache the current impacted input sockets so we can rerun them after we remove the FrameContains edge (another bug, as we were rerunning funcs THEN removing the edge, womp womp)
Note: This takes significant advantage of the latest change to Dependent Values Update as any Input Socket's Attribute Value that gets queued for DVU will probably (always?) have a dynamic function that sets the value, meaning it will run during the next DVU job
When we remove the Component on delete (because it doesn't have a resource), we also orphan it, making sure that any impacted input sockets are queued up for DVU
Add a complex test for multiple components as children of an Up Frame, with nesting, moves, and deletes, making sure the data flows as expected
Added some test helpers to make it faster to write tests for frames as we continue to cover the various permutations.
Add some tracing for the rebaser loop so we can see the count of updates and conflicts better in Jaeger and Honeycomb. I needed this to debug an issue while I was working on this and left it in as this will be valuable for us in the short term (and more valuable as we enrich the metadata we return)

via Election 2020 on GIPHY

bors try

bors r+


Next/20230209/v1

Test for old bug https://redmine.openinfosecfoundation.org/issues/3286
Disable 5198 for now.

Requires a fix to both master and master-6.0.x wrt the stream event.


Extend special popup window handling to any non-popup child of a popup.

Fixes https://github.com/godotengine/godot/issues/66016
Alternative to https://github.com/godotengine/godot/pull/69626

I have tested this PR on Windows and it solves the linked issue for me.

Thanks!