IdentityServer4 hang-up

Hi IdentityServer4er,
I created an IdentityServer4 demo with MS Dotnet core 1.1 and deploy to ubuntu 16.04. This demo uses memory users and works well in my local windows machine.
After deploying to ubuntu, when try to login with some user, IdentityServer4 will hang-up. I checked the log:

info: Microsoft.AspNetCore.Server.Kestrel[14]
Connection id "0HL2M89T5U0QT" communication error.
Microsoft.AspNetCore.Server.Kestrel.Internal.Networking.UvException: Error -32 EPIPE broken pipe

I have build nginx service behind Kestrel.
The attached file is login form and click the Login, the request will be timeout(504)

Looking forward to your reply!

you probably need to take this problem to the Microsoft's Kestrel repo on github.


search nicknames (issue 2240)

PR for issue #2240
According to the document, nicknames and email addresses are stored separately in different rows. So I query the CONTACT_ID at first and query email address according to CONTACT_ID

@philipwhiuk Done :) I created a method getNicknameCursor, but there is an error under strict mode that the cursor isn't released. But I do release it in another method fillContactDataFromNickname, should I ignore it?

@philipwhiuk Sorry I forgot it.. I have fixed it and squashed the commits into one :)

@Valodim Thanks for your review! I have updated it and squashed the commits :)
Besides extract a method, a another change is that for this method, I make the nickname method and another method return a boolean value indicating whether there is a contact matched

Sorry for the delay. from a quick glance this looks good now. I'll need to test and look at it again, will try to do that very soon. Thanks for your work!

I just tested this and it didn't actually work for me. I created a contact, added a nickname, and then searched both for a prefix or an infix of the nickname, but the result of the contacts provider query was empty. Am I doing something wrong maybe?

@Valodim Could you please try it again? :)

@Valodim , made the required changes and squashed the commits :) In my opinion putting the contacts queried by nickname on the top is OK (For me I also want them to be on the top :) )

thanks! :+1:


Fix for Busted Menu Audio Layout

The previous audio button behavior has been broken for what appears to be a long time. The audio buttons would drift off the screen if menu text got too long.
Fix for: http://manage.dimagi.com/default.asp?225035
Implementing the new Audio UI to Biyuen's spec was surprisingly not well supported, had to implement a custom layout rule.
NOTE: I'm going to figure out whether this needs to make it into 2.27, will probably splice in the change if so.
Examples of the new behavior for short and long text, along with the broken behavior, and the pre-new-ui behavior (far right) that is really awkward on larger screens:

@ctsims Hey so I'm confused as to what part of this PR is actually fixing the issue of the audio icon getting cut off. It seems like the ShrinkingLinearLayout resolves the issue of the icon being way over to the right side of the screen when the text only takes up part of the screen width, but I don't see how it resolves the reverse issue. Would you mind clarifying, just for sake of understanding?

@amstone326 @phillipm feedback addressed

@ctsims Will merge, but can you answer my question?

@amstone326 Thanks for flagging, sorry to miss that question:
Linear layouts function in one of two modes:
Mode 1: the layout adds its children in order, providing no real advice as to how long they should "Try" to be until one runs off the screen
^ This is what the old layout was doing
Mode 2: The layout tells its children "You get 20% of the width, you get 30% of the width, etc, etc" and the children will always be that width, alternatively it can say, "Child A gets 20%, Child B gets 30%, Child C gets 'the rest'", but the overall view has to be as wide as the screen.
^ This is the "Other broken example" which will never get something "Pushed" off the screen but also means your views can't be next to each other 'until' they need to fill up the width.
The way the PR addresses the "getting cut off" part of the problem is that it has you set everything up in Mode 2 (IE: The view is fully maximized in width and it is clear what % of the screen each child gets), but then also lets you provide a heuristic to say "One of these views might actually want to be way less big". It essentially takes the static view (Mode 2), measures all of the children in anticipation of drawing, but then measures one specific child in a vacuum, and if it's smaller than the "% of the screen" layout it forces it to be the size it 'wants' to be.
Kind of awkward to explain, might be easier to whiteboard if you have a few minutes.

@ctsims Hey that actually made a lot of sense for the most part. The only thing I'm still not following is what in this PR is actually making this happen: "The view is fully maximized in width and it is clear what % of the screen each child gets". I see that you added android:layout_weight="1" to the row_txt view, but based upon the documentation here https://developer.android.com/guide/topics/ui/layout/linear.html#Weight, I would expect you to have to give a layout_weight attribute to the row_img view as well, in order for the image to not get cut off when the text is long. What am I missing?


After redirect with cleanup-hook component render a previous value

Version
5.2.0
Test Case
With state as context - https://codesandbox.io/s/suspicious-easley-svkt2?file=/src/App.js
With state as mobx's observable - https://codesandbox.io/s/adoring-fog-dsvew?file=/src/App.js:353-381
Steps to reproduce
Preconditions:

component A as a page for react-router
component B as a page for react-router
state which is used in A and B

Expected Behavior

Initial state { value: 0 }
Initial URI - /a
React-router renders the component A. It renders { value: 0 }.
Redirect to /b
Component A has a cleanup hook where the state was updated to  { value: 1 }
React-router renders the component B. It renders { value:1 }

Actual Behavior
In .5 component B renders an old state { value: 0 }  (before cleanup in component A).
After it reacts for changes for second rerender it has a new state { value:1 }.
I bet either I'm doing smth wrong or I don't understand how it's possible to clean/reset global stores/states.
I'd appreciate any feedback.

This doesn't have anything to do with React Router. You're using Context incorrectly. By changing a property on the context value, you're not triggering an update of that context value. This is much like using useRef instead of useState. You need some sort of mechanism to broadcast context updates through your tree.

Right, it was a silly attempt. Fixed the demo with context - https://codesandbox.io/s/suspicious-easley-svkt2?file=/src/App.js.
Less verbose demo with mobx - https://codesandbox.io/s/adoring-fog-dsvew?file=/src/App.js:353-381.

Should I open a new one or there's a chance you have a look at this one? @timdorr


fix(persons): fix infinite loading when saving some persons

:tada: This PR is included in version 2.29.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Not an issue but seeking to replicate outputs from a service that appears similar to CNNMRF

This album here: https://imgur.com/a/e24sj
I was using -type transfer -mode memory and content weight 2-10. I am very new to CNNMRF, and thus am unsure if any of the settings are capable of making the images compare to each other.
The "triangle style" is one of the most interesting styles I am trying to replicate: https://imgur.com/a/6ZWGJ Trying to get the CNNMRF output to look like the Dreamscopeapp output.
Can @chuanli11 provide any assistance? Point me towards the right commands? Or point me towards a more suitable style transfer project for these goals?

according to dreamscope's owner it runs on neural style, and before seeing the leaf picture I would have been sure about it.
try to change mrf_weight a bit.
I also always wondered how results would be with 4 mrf layers instead of 3, if you have the vram to do it give it a shot.

Hi,  I guess neural style suits better for what dreamscope does. CNNMRF can be a bit too rigid -- unless you what have more style-faithful results.


Rename proposals JSON field functionInterface to targetFunction

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Update Use Cases and DG Format

Things done:

Update Use cases to follow the format as stated in Issue #44.
Update DESIGN section of DG.

Before:

After:

Update headers: "(OUTDATED)" appended to the end when that section is outdated.
Update Glossary to include CSV.

Codecov Report

Merging #55 (b296751) into master (3fb88d6) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #55   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Documentation

[X] User Guide
[X] Developer Guide
[X] Javadocs

Sections updated under UG

NIL

Sections updated under DG

DESIGN

Appendix: Requirements -> Use cases

Classes with Javadocs update

NIL

Here are some guidelines I followed while updating the DG, it would be good to follow these in future commits to DG, to ensure consistency:
I intend to follow closely the HighWater DG for most aspects of our DG as I feel that it is very well-written, and if our DG is similar in quality to that, there should be no issues to our documentation.
I have also referred to the AB3 DG a lot regarding when to use callouts and markups.

Use of present tense to signify work in progress (e.g. developers are to add additional classes...)
Make use of Cause - Effect Structure (e.g. CLI gives the user an easy way to input commands... Therefore ...)
Liberally make use of Markups (e.g. when describing relevant classes)
When coming across jargon, do remember to add it in the Glossary section in alphabetical order.
As a follow up of point 4, when referencing words from the Glossary, do add a clickable link that takes the reader back to the glossary section. I have decided that for this particular purpose, the format will just be a bolded, clickable word. Our DG is online so the word will show up in blue.

For example, "RC4" is a word in the glossary, and should be written as [**RC4**](#glossary)

IMPORTANT!!!
When writing the description in your PRs in the future, do add the section I have written at the top. I will check the documentation based on this section of the PR description.
Checking the tasklist signifies that that portion of the documentation is ready to be checked (even if it may not have been changed at all). The "Sections updated under..." portion will tell me which part of the UG/DG/java files to look at/compare.
As of now, please DO NOT change the headers with the (OUTDATED) word. I intend to check through those sections again before we submit v1.2, and so I will remove it myself :))

Oh one more thing that would be of great help is to deploy the docs on your repo and include a link to the DG. Would help a lot with seeing how the actual documentation will look like.


Create chapter index

Creates a chapter index page for a story. I'm not sure what callback to pass to createChapterStructure though (in my "Play" button with event listener for click).
closes #20

For now callback is displayChapterEnd method in game logic which is passed to drag and drop when images are created. Later it will be changed to function that shows up popup window with message.

There is an issue with logic, and I'm unsure of how to adapt things. If you select a chapter from chapterIndex page, it will take you to the correct chapter HOWEVER once you complete the chapter, it may take you to the wrong next chapter. (Ex. if you start at Chapter 4 and complete it, it will take you next backwards to an uncompleted chapter, like Chapter 2).
This is because goToNextChapter function in the story module finds the next chapter by looking for the next unfinished chapter, and is not based on chapter number.
We could create another goToNextChapter function specifically for chapterIndex, or we could change the implementation of goToNextChapter. I'm not sure what's the better approach, what do you guys think?

I think changing the implementation of goToNextChapter might be the most long-term solution, if it's not too hard or doesn't take too long

This is because getCurrentChapter function in the story-factory finds the next chapter by looking for the next unfinished chapter, and is not based on chapter number.

That's right, when i was creating it i didn't take into consideration that user can start with another chapter than the first one. At least it works as intended :D

We could create another goToNextChapter function specifically for chapterIndex, or we could change the implementation of goToNextChapter. I'm not sure what's the better approach, what do you guys think?
**the "easiest" solution would be to switch getCurrentChapter function to search for current chapter num + 1, this will cause changes to be made in logic module as well, but is this the best approach?

Maybe we will add another function in story-factory that searches for last completed chapter and returns next one which status is uncompleted? What do you think about that? Of course it probably dosen't matter which way we will choose, changes in goToNextChapter seem inevitable.

I was thinking, if there is a change in that part of the logic, maybe it can help me with the storyEnd home button as well since looking for an uncompleted chapter that doesn't exist is the problem as well, at least I think it can help? I'm not even sure, my brain is spaghetti today haha

That's right, when i was creating it i didn't take into consideration that user can start with another chapter than the first one. At least it works as intended :D

I am not sure if I understand you guys right... The user shouldn't be able to start with another chapter then chapter 1, right? All chapters except chapter 1 should be locked and a chapter should be only unlocked when the previous chapter has been completed. Or do you think it makes sense, that users can play chapters without having the story context from previous chapters?
I can see the problem e.g. when user completed first 4 chapters, then goes back to overview page and clicks on e.g. chapter 2 to replay it again. Then after click on next button it would take him not to chapter 3 but chapter 5.

**the "easiest" solution would be to switch getCurrentChapter function to search for current chapter num + 1, this will cause changes to be made in logic module as well, but is this the best approach?

Spontaneously I would say this is the easiest approach which makes most sense to me for this issue.

**the "easiest" solution would be to switch getCurrentChapter function to search for current chapter num + 1, this will cause changes to be made in logic module as well, but is this the best approach?

Spontaneously I would say this is the easiest approach which makes most sense to me for this issue, because it works in the end for both scenarios.

I was thinking, if there is a change in that part of the logic, maybe it can help me with the storyEnd home button as well since looking for an uncompleted chapter that doesn't exist is the problem as well, at least I think it can help? I'm not even sure, my brain is spaghetti today haha

Spontaneously I think so too... It could help with your issue as well. Because when we check for last chapter number and in this case instead of adding currentChapterNumber + 1 we set chapterNumber = 1, then your button should work fine.

ter 1 should be locked and a chapter should be only unlocked when the previous chapter has been completed. Or do you think it makes sense, that users can play chapters without having the story context from previous chapters?

Yes the buttons for certain uncompleted chapters can be locked somehow, thats true. But it still stands that the logic needs to be changed, also to allow chapters to be replayable like you said. In that case, ill try altering it to find chapternum + 1.

This is because getCurrentChapter function in the story-factory finds the next chapter by looking for the next unfinished chapter, and is not based on chapter number.

That's right, when i was creating it i didn't take into consideration that user can start with another chapter than the first one. At least it works as intended :D

We could create another goToNextChapter function specifically for chapterIndex, or we could change the implementation of goToNextChapter. I'm not sure what's the better approach, what do you guys think?
**the "easiest" solution would be to switch getCurrentChapter function to search for current chapter num + 1, this will cause changes to be made in logic module as well, but is this the best approach?

Maybe we will add another function in story-factory that searches for last completed chapter and returns next one which status is uncompleted? What do you think about that? Of course it probably dosen't matter which way we will choose, changes in goToNextChapter seem inevitable.

True, its not really a bug, just needs a different implementation now that chapterIndex exists lol.
I'm not sure I understand, why does a chapter have to be found by last completed chapter? Perhaps start button on starting page should always start at chapter 1, since chapterIndex will allow players to jump between chapters if they want.

UPDATE:
I've managed to get chapterIndex to work, I've tested things myself and all looks fine. Chapters now flow logically in order, and there is logic now to lock certain chapters to avoid people from jumping ahead in the story.
There are some notable changes I've made to other files, so I want to let you all know about them here.

I've replaced getCurrentChapter function with getChapter, which works by returning a chapter based on it's chapter number. findNextChapter function now works by returning currentChapterNumber + 1.
setCompletionStatus in Chapter module had to be changed, since with chapterIndex chapters can be replayed, and it would cause the completed chapters to switch back to uncomplete.
-"Start" button in the homepage is hard coded to always start at chapter 1. Perhaps it could dynamically start wherever the person last finished in the story, this is also possible.

I really like this changes, good work!


allow setting the preferred feeSize

When sending a very small amount 0.0001 as a full transfer, Dash Insight API failed with a 400 complaining the fee of 191 was less than the minimum 192.
This allows overriding the default selected fee from fee.min (191) to fee[feeSize].
feeSize can be a string value of min, mid, or max corresponding to the values returned by DashTx.appraise(...)
let txDraft = await dashwallet.legacy.draftTx({
  utxos,
  inputs,
  output,
  feeSize: 'max',
})

@coolaj86, as discussed, go ahead and fix the underlying issue that's causing the error rather than giving users an option to select fees.

Replaced by https://github.com/dashhive/DashTx.js/pull/35
The root cause was essentially this:
  let lastTime;
  for (;;) {
-   lastTime = thisTime;
    if (thisTime === lastTime) {
      break;
    }
+  lastTime = thisTime;
  }


Camera getWorldPoint() briefly inaccurate during zoom change while following sprite

Version

Phaser Version: 3.15.1, 3.17.0, 3.24.1

Operating system: MacOS, iPad OS

Browser: Tested on Safari, Chrome, Firefox

Description

If the camera is set to follow something, calling getWorldPoint() while the camera zoom is changing will very briefly send an inaccurate coordinate.
Example Test Code

class myScene extends Phaser.Scene {
  constructor() {
    super('sceneTest');
  }

  preload() {
    this.load.image('player', 'player.png');
  }

  create() {
    var sprite = this.add.sprite(0, 0, 'player');

    this.cameras.main.startFollow(sprite);

    var context = this;

    this.input.keyboard.on('keydown_P', function (event) {
        if(context.cameras.main.zoom > 0.5)
          context.cameras.main.setZoom(Math.round(1000 * (context.cameras.main.zoom - 0.05)) / 1000);
    });

    this.input.keyboard.on('keydown_O', function (event) {
        if(context.cameras.main.zoom < 1)
          context.cameras.main.setZoom(Math.round(1000 * (context.cameras.main.zoom + 0.05)) / 1000);
    });

    this.coordinates = [];
  }

  update() {
    if(this.cameras.main.getWorldPoint(0, 0).x === this.coordinates[0] && this.cameras.main.getWorldPoint(0, 0).y === this.coordinates[1])
      return;

    this.coordinates = [
      this.cameras.main.getWorldPoint(0, 0).x,
      this.cameras.main.getWorldPoint(0, 0).y
    ];

    console.log(this.coordinates);

    var thing = this.add.text(this.coordinates[0], this.coordinates[1], 'O');
  }
}

var config = {
  type: Phaser.AUTO,
  width: document.documentElement.clientWidth,
  height: document.documentElement.clientHeight,
  resolution: window.devicePixelRatio,
  autoResize: true,
  pixelArt: true,
  scene: [ myScene ]
};

var game = new Phaser.Game(config);

Additional Information

In the example, the update code is checking whether the coordinates from getWorldPoint() is the same as the last check. If it is different, it will log the console and put text unto the coordinate it was given. This means that with each camera zoom, a letter "O" will appear at coordinates from getWorldPoint(0, 0).
There are only 10 camera zooms, so ideally there will only be 10 "O"s and 10 logs from the console. Instead, there is 20 "O"s and 20 logs implying that there is a brief moment of inaccuracy when calling getWorldPoint().
This issue only happens when the camera is set to follow something.

When following something, the Camera matrix is updated in the preRender step. Testing it in update is testing it prior to those changes, so it's entirely possible for the camera matrix to be updated in the same game step, but after your test takes place. If you wish to use the latest camera matrix (which is what getWorldPoint does) then you need to check it based on a Scene render event, so it has the most current values within it.

See the new Camer FOLLOW_UPDATE_EVENT to deal with this situation.


type Path not correctly defined

type Path should be (string | number)[] instead of (string | number | boolean)[].
propEq is currently defined with (string | number[]) instead of type Path

Wait, propEq should be using Prop as it is now rather than Path, right?
I merged in your suggestion of kicking boolean out of Path now. Thanks for bringing that up. :)

sorry, my mistake: pathEq!

Thanks! :)

No problem. Dank u


Limit Long Titles

Describe where the project does not conform to style guidelines
For this event, the title takes up a majority of the dialog box. This makes the box look terrible, squeezing all the text into a small section at the end.

Describe how the project could be changed
We should have the webform recommend concise event titles, and put in a hard limit on the number of characters.

Since the MS Form doesn't support response length restrictions, we can just include a polite restriction message like the one in the form's description field. Is 60 characters a good maximum length?


Commoncode

Issue
Provide common code base repository for Java and Android.
https://github.com/idpass/idpass-lite-java/issues/10
Changes
Add android folder from where aar Android library is built.

Add Android aar build
Extracted Dlib models outside from native library when building for Android

Test sample idpass-lite-java-android-0.1.aar library. And test example Android usage snippet

Why Is the folder called app and not aar?
Why do we have layout defined?

app is the default folder name when Android project created
layout.xml is now removed

A scale of 1 corresponds to 1 pixel per module and runs perfectly without intermittent error during unit tests. Scaling it up will result in very intermittent false alert unit test error (1 out of 50).
I tried to research more and found the explanation here

Why Is the folder called app and not aar?
Why do we have layout defined?

app is the default folder name when Android project created
layout.xml is now removed

A scale of 1 corresponds to 1 pixel per module and runs perfectly without intermittent error during unit tests. Scaling it up will result in very intermittent false alert unit test error (1 out of 50).
I tried to research more and found the explanation here

@rjmangubat23 Is it the best practice to put the aar code in an app folder? Can you check how other projects are doing?

@rjmangubat23 Is it the best practice to put the aar code in an app folder? Can you check how other projects are doing?

@rjmangubat23 Is it the best practice to put the aar code in an app folder? Can you check how other projects are doing?

Hello @jeremi after checking other projects, I agree that we shouldn't put the aar code in app folder. @typelogic I would suggest to refactoring the app folder to a more specific name like aar as @jeremi suggested?
Just to note, in renaming/refactoring in Android:

Rename the directory name
Update change name in settings.gradle

Please see sample projects:
https://github.com/journeyapps/zxing-android-embedded
https://github.com/journeyapps/zxing-android-embedded/blob/master/settings.gradle

@rjmangubat23 Is it the best practice to put the aar code in an app folder? Can you check how other projects are doing?

Hello @jeremi after checking other projects, I agree that we shouldn't put the aar code in app folder. @typelogic I would suggest to refactoring the app folder to a more specific name like aar as @jeremi suggested?
Just to note, in renaming/refactoring in Android:

Rename the directory name
Update change name in settings.gradle

Please see sample projects:
https://github.com/journeyapps/zxing-android-embedded
https://github.com/journeyapps/zxing-android-embedded/blob/master/settings.gradle


rpg maker just exports nwjs folder and no game

this issue is related to rpg maker MV
I've updated nwjs to 0.49.2 or higher: ✅
I've installed the discord-rpc node module: ✅
There's a node_modules folder in my project directory: ❌
Describe the bug
when i export my game, game.exe just opens a window that says nw.js and the node-modules folder is completely gone, even in the master directory
To Reproduce
Steps to reproduce the behavior:

export a game

Expected behavior
the game to export normally?
Desktop (please complete the following information):

OS: [windows 10]
Plugin version: ???

ok well now my rpg maker installation is screwed up, i reinstalled it TWICE and it's still doing the same thing. :(((((

That's weird, especially if this plugin caused this. Can you show me your project directory structure?

well unfortunately i can't now cause everything broke while i was
troubleshooting. the original project file is corrupted (most maps are
gone). and i had to reinstall rpg maker 3 times. MV is still broken on my
pc but mz is working fine. i tried converting the project to mz (made a
copy first) and it still didnt open which means it might've been something
to do with my project itself. i doubt it was your plugin
best regards, BudgieMint
On Thu, Aug 22, 2024, 22:03 Santtu Salmela @.***> wrote:

That's weird, especially if this plugin caused this. Can you show me your
project directory structure?
—
Reply to this email directly, view it on GitHub
https://github.com/00due/Discord-RPC-for-RMMZ/issues/9#issuecomment-2306140183,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQ2ZMURVKPM7DIBEI44EZV3ZS2YC3AVCNFSM6AAAAABM7FOVOWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBWGE2DAMJYGM
.
You are receiving this because you authored the thread.Message ID:
@.***>

Yeah, I'm sorry that happened.
If you're not doing it yet, I really, really recommend you to set up git or another version control for your project(s). That helps you to keep backups of the code easily, and always reverting back to another state, in case something goes wrong. The simplest way to do that is probably to just install Github Desktop, and create a new repository to your project's folder.


UI still shows objects as refreshing

Description
In v0.6.0, we no longer clear kargo.akuity.io/refresh annotation. Instead, we record the value into status lastHandledRefresh to indicate that it refreshed. The UI needs to adapt to this change, because it constantly shows resources as refreshing.

apiVersion: kargo.akuity.io/v1alpha1
kind: Warehouse
metadata:
  annotations:
    kargo.akuity.io/refresh: "2024-05-07T17:22:27Z"
  creationTimestamp: "2024-05-07T00:50:04Z"
  generation: 1
  name: kargo-demo
  namespace: kargo-demo
  resourceVersion: "6053436"
  uid: 70cc1244-cd5a-4d02-a6ae-521e90f12d54
spec:
  subscriptions:
  - image:
      imageSelectionStrategy: SemVer
      repoURL: nginx
      semverConstraint: ^1.24.0
status:
  lastFreight:
    images:
    - digest: sha256:9f0d283eccddedf25816104877faf1cb584a8236ec4d7985a4965501d080d84f
      repoURL: nginx
      tag: 1.26.0
    name: 7108dff8f88f66318b3a1b8adb7519198d5d2cce
  lastHandledRefresh: "2024-05-07T17:22:27Z"
  observedGeneration: 1

Steps to Reproduce
Refresh a Warehouse, probably others
Version
v0.6.0-rc.2

Logs
Paste any relevant application logs here.

Not sure if this affects CLI as well

It does not affect the CLI. The problem is that the frontend is looking at the wrong (non-existing) field, causing the value to always mismatch which spawns the loader.
It's being used correctly everywhere else.


Cannot perform CREATE SECRET. This session does  not have a current database. Call 'USE DATABASE', or use a qualified name. 2024-10-31 13:01:47 INFO [snowflake.connector.connection] closed

Hello
After running this
snow git setup "$GIT_REPO_NAME" --database="$GIT_REPO_DB" --schema="$GIT_REPO_SCHEMA" --debug
I have this error:
Cannot perform CREATE SECRET. This session does
not have a current database. Call 'USE DATABASE', or use a qualified name.
2024-10-31 13:01:47 INFO [snowflake.connector.connection] closed

did you happen to run the instructions as in  https://github.com/Snowflake-Labs/snow-cli-demo?tab=readme-ov-file#snowflake-environment and make sure terminal you are running the instructions does have GIT_REPO_DB and GIT_REPO_SCHEMA environment variables while running the command.

Yes, I did the same instructions and have setted uo the variables db schema and warehouse


Todo testing version 2

In this PR I and @Beardless-sheik did the following:

Add tests for:
- editing a task's description
- updating a task's completed status
- and clearing all completed tasks from the list
Add functions for the above tests
We use the mock storage object you have created in Part 1 of this project to mock the localStorage updates.

I appreciate your time taken in reviewing my project. Thanks.


Show user assigned groups

Not sure if we should also show the users assigned groups on the following page too:
http://tygr.jamie.sh/users
Groups get assigned from the following url:
http://tygr.jamie.sh/users/create

Probably a little too much information here, for the most part if you want to know what groups a user is part of or want to change it you can just click on their name. It's not particularly important information for the index.


Issue with dynamic input[:type] bindings in Internet Explorer

Version
2.6.10
Reproduction link
https://codesandbox.io/s/serene-flower-nwgc5
Steps to reproduce
I'm trying to create a simple <input>-element component, which has  dynamic type bindings
like <input[:type="text|number|tel|email|radio|checkbox"]>.
The following template-example-code is working as intended in all browsers,
but IE is throwing an error, when this code is used:
data.checkbox = []
<template>

    {{ checkbox }}

      <input :type="field.type" :value="field.value" v-model="checkbox">
      {{ field }}

</template>

What is expected?
Normal type-binding like the input[radio] :value-binding example in the docs:
https://vuejs.org/v2/guide/forms.html#Radio-1
What is actually happening?
IE11 error message:

Multiple definitions of a property not allowed in strict mode

Even if I'm using :type="'checkbox'" to bind it directly to a string, it's not working in IE.
So currently I need to use type="checkbox" with an v-if="type ==='checkbox'" condition as workaround.
Maybe I'm doing something wrong, but the doc example isn't mentioning this caveat.

I tested your sample on an index.html file (code sandbox doesn't run on IE) and the code works just fine til IE9. I imagine you have something else in your code creating the bug or there is a transpilation bug somewhere else that creates an extra property on an object (that's the only thing I can tell from the error message). Let me know if you find out more information that could help
this is the file I used to test:
<!DOCTYPE html>

    <meta charset="UTF-8" />
    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
    <meta http-equiv="X-UA-Compatible" content="ie=edge" />
    <title>Document</title>

      {{ checkbox }}

        <input :type="field.type" :value="field.value" v-model="checkbox" />
        {{ field }}

Hi, and first of all thank you for the help and really fast response.
I've tried your code example and indeed it's working in IE, so I assume it's related to vuecli.
Sorry for that, I should have tested it in a more basic setup.
(New cli-issue https://github.com/vuejs/vue-cli/issues/4989 IE9 works, only IE10/11 is effected)
I wish you great holidays, R


pkl Writer

I would like to be able to evaluate existing pkl files and also write changes.
For my use case, I want to provide an UI for a pkl-based configuration. I then want write back the changes the user has made to the original pkl file.

When you consume a .pkl file through language bindings, it gets fully evaluated and the bindings copy the fully expanded data over to the host language. You can't preserve lazy relationships and/or for/when generators this way. This is why we've never built such a Writer; it seems against the point.

Ok, makes sense for me for the current model. But don't you think it would be valuable to use Pkl from both sides? E.g. to have a package that is capable of parsing Pkl to an AST and writing it back after a manipulation.

If you want UI-manipulated static data to be validated by Pkl, I'd dump it into JSON and let your Pkl module use pkl:json's Parser to consume/check it in Pkl.

That's the main point why I opened the issue: I could totally move forward this way, but the user would loose all the awesome features of Pkl when the final format is always JSON.

capable of parsing Pkl to an AST and writing it back after a manipulation.

In very many discussions, this is a source of cognitive dissonance; Pkl isn't a static data format. Yes, you could parse it into an AST, but it would be deeply non-trivial for your GUI to decide how to mutate said AST to change a setting. You'd have to resolve all names and determine whether you're at the end of an amends chain before you can write things out.

That's the main point why I opened the issue: I could totally move forward this way, but the user would loose all the awesome features of Pkl when the final format is always JSON.

If you're giving people a GUI, they don't see the code at all, so there hardly is any Pkl features GUI users will ever see. If you want a strong validation stage, because your GUI could generate settings that don't work (mutually incompatible property settings, for example), then you can still have that using pkl:json. I'm not sure what the strict win is from having the GUI write Pkl, which humans are not supposed to touch.

While I completely understand what you're saying, I think the reason for the cognitive dissonance is that one of, if not the main, use-cases for language bindings is to programmatically load configuration directly into an application. That is, I just want to allow users of my application to write .pkl, rather than using pkl to generate another format.
In that scenario, being able to write back to the configuration is very common - basically every other static configuration format supports this, preserving comments, etc. If we assume that this is a requirement of my application, then I can't really use .pkl as the native format, I have to use JSON, YAML, TOML or something similar. In that case all that pkl (IIUC?) brings to the table is validation, which I can get from something like JSON-schema (albeit much more verbosely).
To add slightly more to the dissonance, pkl does seem to sell itself for this use case:

Integrated application configuration
Embed Pkl into your applications for runtime configuration, and receive code generation for Java, Kotlin, Swift, and Go.

All that is not to say that pkl-go should support writing BTW, just to explain why I think there's confusion.

one of, if not the main, use-cases for language bindings is to programmatically load configuration directly into an application

Entirely agreed.

In that scenario, being able to write back to the configuration is very common

True, but that's when the configuration on disk is just a serialised form of application-determined (simple - i.e. numbers, booleans, strings) values.

basically every other static configuration format supports this, preserving comments, etc.

So, here's the thing to solve. If your Pkl file says
myValue = myListing.fold(0, (acc, it) -> acc + it)

and your application determines that myValue = 5; what are you writing back? myValue = 5 or do you know the underlying reason why it's now 5 (and what that means in terms of myListing)? This is a problem you don't have in static formats, because they don't allow you to express these computations.
This gets worse when you have amends chains; if you have the following files;
someTemplate.pkl:
someValue = 10

someAmender.pkl:
amends "someTemplate.pkl"

someValue = super.someValue + 1

someFurtherAmender.pkl:
amends "someAmender.pkl"

Now suppose your application loads someFurtherAmender.pkl. If your applications now changes someValue to be 42, which file should you write what to?


fixed python 2 errors in super()

I also added an option for multivariate y (needed for my application) and moved _check_param_grid to fit as per scikit-learn dev guidelines.

Thanks for the fixes. I split into two commits and pushed the changes to master.


Disable controls for non-admins on SubmissionStatus page

Disable tagging and commenting functionality for non-admins on Submission Status page

Oh yes, I am aware of that. We mostly want to avoid accidental changes by non-admins through the Submission Status page.


Maybe we should do some optimizations.

I will check some media classes, the images seem to be served lossless...

Slightly better now:

Removed the lossless, removed the videos from home, added srcset.

Performance goes a bit up & down, but this might be good enough for now:

Yes indeed.... Nice to have those media classes so it can be easily fixed.


Test results show test descriptions instead of names

I'm not sure if this is intentional, but I just noticed that test results show the description in the beginning of the request block. IMHO, it would be more appropriate to display the name (description could be displayed optionally based on the settings, if at all). Example:

I think it would make more sense to have Demo test one at the top of the TEST RESULTS output instead of Test with no dependencies..

Actually, it would be title before description. For me, title is not quite the same as name. Unfortunately, I used name for referencing (identifier would have been better). As a result, the name is somehow technically required. That's why I introduced another title, which is used for the display. I also use the name as a fallback instead of title. However, this also affects the changed behavior in the CLI
https://github.com/AnWeber/httpyac/blob/main/src/utils/requestUtils.ts#L207-L214

Right, I actually meant the title (I assume the text to the right of the region delimiter ### is the title and it is a shortcut for # @title). And you're right, the id would be less ambiguous, but name/title/description also make sense.


openmpi: 3.1.3 -> 4.0.0

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/openmpi/versions.
meta.description for openmpi is: '"Open source MPI-3 implementation"'.

Checks done (click to expand)

built on NixOS
/nix/store/ffryrx1cm1jyl8d1gcqdwblqx73nk73d-openmpi-4.0.0/bin/ortecc passed the binary check.
/nix/store/ffryrx1cm1jyl8d1gcqdwblqx73nk73d-openmpi-4.0.0/bin/mpirun passed the binary check.
/nix/store/ffryrx1cm1jyl8d1gcqdwblqx73nk73d-openmpi-4.0.0/bin/mpiexec passed the binary check.
/nix/store/ffryrx1cm1jyl8d1gcqdwblqx73nk73d-openmpi-4.0.0/bin/ompi-clean passed the binary check.
/nix/store/ffryrx1cm1jyl8d1gcqdwblqx73nk73d-openmpi-4.0.0/bin/ompi-server passed the binary check.
/nix/store/ffryrx1cm1jyl8d1gcqdwblqx73nk73d-openmpi-4.0.0/bin/mpicc passed the binary check.
/nix/store/ffryrx1cm1jyl8d1gcqdwblqx73nk73d-openmpi-4.0.0/bin/mpic++ passed the binary check.
/nix/store/ffryrx1cm1jyl8d1gcqdwblqx73nk73d-openmpi-4.0.0/bin/mpicxx passed the binary check.
Warning: no invocation of /nix/store/ffryrx1cm1jyl8d1gcqdwblqx73nk73d-openmpi-4.0.0/bin/mpifort had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/ffryrx1cm1jyl8d1gcqdwblqx73nk73d-openmpi-4.0.0/bin/mpif77 had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/ffryrx1cm1jyl8d1gcqdwblqx73nk73d-openmpi-4.0.0/bin/mpif90 had a zero exit code or showed the expected version
/nix/store/ffryrx1cm1jyl8d1gcqdwblqx73nk73d-openmpi-4.0.0/bin/mpiCC passed the binary check.
Warning: no invocation of /nix/store/ffryrx1cm1jyl8d1gcqdwblqx73nk73d-openmpi-4.0.0/bin/opal_wrapper had a zero exit code or showed the expected version
/nix/store/ffryrx1cm1jyl8d1gcqdwblqx73nk73d-openmpi-4.0.0/bin/orte-clean passed the binary check.
Warning: no invocation of /nix/store/ffryrx1cm1jyl8d1gcqdwblqx73nk73d-openmpi-4.0.0/bin/orted had a zero exit code or showed the expected version
/nix/store/ffryrx1cm1jyl8d1gcqdwblqx73nk73d-openmpi-4.0.0/bin/orterun passed the binary check.
/nix/store/ffryrx1cm1jyl8d1gcqdwblqx73nk73d-openmpi-4.0.0/bin/orte-info passed the binary check.
/nix/store/ffryrx1cm1jyl8d1gcqdwblqx73nk73d-openmpi-4.0.0/bin/orte-server passed the binary check.
/nix/store/ffryrx1cm1jyl8d1gcqdwblqx73nk73d-openmpi-4.0.0/bin/ompi_info passed the binary check.
14 of 19 passed binary check by having a zero exit code.
0 of 19 passed binary check by having the new version present in output.
found 4.0.0 with grep in /nix/store/ffryrx1cm1jyl8d1gcqdwblqx73nk73d-openmpi-4.0.0
directory tree listing: https://gist.github.com/765e9dd281b613a799ee516d7a16555e
du listing: https://gist.github.com/44c0558bbcdd9a1d50994b7abe02e657

Rebuild report (if merged into master) (click to expand)

131 total rebuild path(s)
39 package rebuild(s)
39 x86_64-linux rebuild(s)
34 i686-linux rebuild(s)
26 x86_64-darwin rebuild(s)
32 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
cntk
dl-poly-classic-mpi
freecad
getdp
globalarrays
gromacsDoubleMpi
gromacsMpi
haskellPackages.haskell-mpi
hdf5-mpi
ior
lammps-mpi
netcdf-mpi
neuron-full
neuron-mpi
openmolcas
openmpi
parmetis
python27Packages.cntk
python27Packages.dask-jobqueue
python27Packages.dask-xgboost
python27Packages.distributed
python27Packages.h5py-mpi
python27Packages.mpi4py
python27Packages.neuron-mpi
python27Packages.neurotools
python37Packages.cntk
python37Packages.dask-jobqueue
python37Packages.dask-xgboost
python37Packages.dftfit
python37Packages.distributed
python37Packages.h5py-mpi
python37Packages.lammps-cython
python37Packages.mpi4py
python37Packages.neuron-mpi
quantum-espresso-mpi
raxml-mpi
scalapack
scotch
siesta-mpi

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/ffryrx1cm1jyl8d1gcqdwblqx73nk73d-openmpi-4.0.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A openmpi https://github.com/r-ryantm/nixpkgs/archive/33a5876a255db193c1b8c0d0e906e2ce93219d4a.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/ffryrx1cm1jyl8d1gcqdwblqx73nk73d-openmpi-4.0.0
ls -la /nix/store/ffryrx1cm1jyl8d1gcqdwblqx73nk73d-openmpi-4.0.0/bin

cc @markuskowa for testing.

duplicate of https://github.com/NixOS/nixpkgs/pull/54877


Added On/Off Scheduling and Frequency Limiting (Android and iOS)

Hey @QuantumRand, looks very promising. I will look through the code and try to get back to you soon.

+1

bump
Frequency limiting needs to be high priority for this plugin in my opinion.


Terminal filename linkifier fails on lines that no not have a space after last column

VSCode Version: 1.15.1
OS Version: MacOS 11.0

Steps to Reproduce:

Open terminal and use any command line tool that reports filenames as results, like find/grep tools, linters, compilers.
Try to click the filename

If working it should open the mentioned file at the line and optionally column mentioned in the line clicked, the format is very easy filename:line:column:....
The feature works fine only if the is a space after the last colon: filename:line:column: foo will work but ``filename:line:column:bar` will not.

In example above clicking on the first match will fail as the "class" does not have a space before it, but the second line will work as it happens to be a line starting with a space.
Note: I tested the same feature in other terminals and they seem to be working fine.

Thanks for the issue. Closing it as a duplicate of #21125

@meganrogge I am afraid that is not a duplicate of the mentioned ticket. It is a very simple bug cause by a broken regex that has nothing to do with other extensions.

@ssbarnea oh yeah I see that now thanks

here's your other example working as expected

@meganrogge I was able to narrow down the bug the issue happens only when the file is at the root of the repository, basically when you have no path component on the first element:
$ rg console_
setup.cfg:82:1:console_scripts =
lib/ansiblelint/__main__.py:37:40:from ansiblelint.color import console, console_stderr
lib/ansiblelint/__main__.py:118:9:        console_stderr.print(Markdown(msg))
lib/ansiblelint/color.py:15:1:console_stderr = Console(file=sys.stderr, theme=_theme)

In this case clicking fails to work as expected only of the first item, what happens is that vscode prompts to check which file to open, something like screenshot below:

PS. I tested it with vscode-insiders too.


Ocean Pokemon Spawns

Howdy there peeps,
A few pokemon appear to be leaving the ocean and reaching up to  mach 10 speeds once they hit land. I've seen a Walmer & Clobbopus so far do this.
Thanks

Yeah this is a pixelmon mod issue, not a Nebula issue. Not sure if it was already reported on the pixelmon tracker.

Pixelmon known issue, reported to them already! Thank you for your report!


origin check for external login servers break users created <cf170

Mid 2014, with cf170, the column "origin" was introduced. Its default is 'uaa'. See also:
https://github.com/cloudfoundry/uaa/blob/5cbf9c1b65598892e6f72966a1288e11f72e793a/server/src/main/resources/org/cloudfoundry/identity/uaa/db/postgresql/V1_7_0__OriginAndExternalIDColumns.sql
Recent versions of UAA now forbid external login servers (source=login) to use the UAA origin attribute for creating tokens for users. While I understand the idea and concept of this origin attribute, forbidding the usage is a breaking change and invalidates all users created <cf170 or after cf170 if created with origin=uaa - which was allowed until recently.
This check is too restrictive and breaks compatibility, so I suggest to remove this checking.
Story that introduced this: https://www.pivotaltracker.com/n/projects/997278/stories/119860913
Referenced code change: https://github.com/cloudfoundry/uaa/blob/develop/server/src/main/java/org/cloudfoundry/identity/uaa/authentication/manager/LoginAuthenticationManager.java#L130

Am I correctly assuming this is the check we are talking about?
    if(info.get(OriginKeys.ORIGIN)!=null && info.get(OriginKeys.ORIGIN).equals(OriginKeys.UAA)){
        throw new BadCredentialsException("uaa origin not allowed for external login server");
    }

Since the user created has password="", enabling the creation of origin=uaa would mean I can bypass the login server, go directly to the UAA token endpoint with a known password.

Original story link
https://www.pivotaltracker.com/n/projects/997278/stories/119860913

Yes, this is the line I am talking about. We did some tests and verified that it is not possible to go directly to the UAA and get a UAA token.
Until CF170, the column "origin" even did not existed, so previously, there must have been another indicator than the origin column that this user can only be authenticated by the login server.
Do you agree that this change in the code is breaking backward compatibility to users created prior to CF170 using the login server?

@msmolny
Yes, I agree it breaks backwards compatibility. I think that's a fact rather than a consensus claim.
origin=uaa is our indicator on what type of user this is, and where the authentication for this user belongs.
Actions like "reset password" suddenly become available to users that should not be able to authenticate on the UAA.
In the use case where the user is disabled in the IDP, they would still have access using UAA's own mechanism. This is troublesome. I looked into the history of this
Prior to the origin column, we had in chronological order

random password set for user
blank "" password
origin was set to "login-server" for any request coming through that path
We then introduced the ability to set origin since the login-server itself desired to differentiate between IDPs it was using.

The intention was never meant to allow the login-server to override that behavior by setting it to "uaa"
It was a bug that was fixed.
The easiest way to identify UAA vs non UAA users that both have origin="uaa" is to run a script that checks the bcrypt match for an empty password string "" and then commence a migration
If there are no non UAA users, the a simple SQL migration to adjust the value of the column.
I'm going to close this issue, as I don't think that this long after we have released the fix it would be wise to revert the fix and by doing so create some of the issues I mentioned above.

@msmolny for further discussion, please contact myself and Sree Tummidi over email or slack.


Build browser image for node 18.12.0 LTS chrome 106 firefox-106

Builds browser image for node 18.12.0 LTS with Chrome 106.0.5249.91 and Firefox 106.0.2.
Closed my other PR as chrome 107 isn't in stable channel yet...

Any chance this one could get reviewed soon? We're wanting it badly!! 😅

@jordanpowell88 🙏


*: remove tikv-importer

Signed-off-by: kennytm<EMAIL_ADDRESS>
What have you changed? (mandatory)
The KV importer service has been extracted into the tikv/importer repository. Only the SST importer service needs to remain here. All code related to the KV importer has been removed here.
What are the type of the changes? (mandatory)

Engineering (engineering change which doesn't change any feature or fix any issue)

How has this PR been tested? (mandatory)
cargo check
Does this PR affect documentation (docs) or release note? (mandatory)

May need to be included in the release note for the source code location.

Does this PR affect tidb-ansible update? (mandatory)
No, the binary has already been switched to be packaged from tikv/importer.
Refer to a related PR or issue link (optional)
Benchmark result if necessary (optional)
Add a few positive/negative examples (optional)

/run-integration-tests

If we can support a plugin which can let the user register their own gRPC server, maybe we can make code cleaner, right?  @kennytm

@siddontang Certainly. But that may make using Importer harder, since that ImportSSTService plugin will need to be installed on every TiKV node.

Could you move src/import to components/import?

@overvenus OK, will move in another PR.

/run-integration-tests

https://internal.pingcap.net/idc-jenkins/blue/organizations/jenkins/tikv_ghpr_test/detail/tikv_ghpr_test/6452/pipeline/
thread 'raftstore-1-1::test_node_request_snapshot_reject_merge' panicked at 'called `Result::unwrap()` on an `Err` value: "SendError(..)"', src/libcore/result.rs:999:5

I guess it is spurious.
/test

/run-integration-common-test


⚠ ClamAV has degraded performance

In fdf8e7e, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 53 ms

Resolved: ClamAV performance has improved in 7b564c9.


Doesn't swipe forward if there's no backward available

Doesn't swipe forward if the "back" arrow in the UI is grayed out.

Trying to replicate this but for me it is working.
The add-on is not working on the "New Tab" page, is that what is happening for you?
What works for me:

Open a bookmark
Click on a link
Swipe back
"Back" arrow is now greyed out
Swipe forward = works

Thanks for replying! It now works for me - no idea what the issue was...


fix(#1145): assertion failure in runner

Description
Fixes #1145
https://github.com/usebruno/bruno/assets/84461672/a5447101-6f0b-4b96-9c33-a85f98c12862
https://github.com/usebruno/bruno/assets/84461672/27283003-a701-4506-9e49-772e102d631c
Contribution Checklist:

[x] The pull request only addresses one issue or adds one feature.
[x] The pull request does not introduce any breaking changes
[x] I have added screenshots or gifs to help explain the change if applicable.
[x] I have read the contribution guidelines.
[x] Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.

Closing this pull request because the issue it tries to solve has already been fixed.


Sync main into rhoai-2.8

Prepare for 2.8.2 release.
Will close: https://issues.redhat.com/browse/RHOAIENG-6393

Opened by mistake

/lgtm

/hold

/unhold


invalid pcap: bad option length

I stumbled onto the attached pcap. Wireshark, tcpdump, and Zeek all read it without complaint, but when our pcap tool tries to index it, it returns the error message:
$ pcap index -r full.pcapng
invalid operation: invalid pcap: bad option length

The above is reproducible as of pcap commit e0bc881.
Perhaps it truly is bad and we're just the only tool with code sophisticated enough to notice it. However, since the other tools don't seem to have a problem with it, I figure it's worth checking if this isn't maybe a bug on our part... or, if it is truly "bad", if it's something where we could stand to be more tolerant like the other tools appear to be.
full.pcapng.zip

Verified in pcap commit c9d7736. Now the index gets created without complaint.
$ pcap index -r full.pcapng
[{"Blocks":[{"Offset":0,"Length":76},{"Offset":76,"Length":48},...

Thanks @mattnibs!


Make helpers available in subclasses

Updating settings code to define :top_level_setting with parent's
:inheritable_setting when available. This will emulate inheritance,
with its expected capabilities (sharing and overriding).
This fixes #1617

Merged, thank you.


Recommended Workflow for Custom Dataset

Hi Dario,
Just read your paper - super cool work!
I was wondering whether you would be willing to share your recommended workflow for using your model on a custom dataset with a different target class and data source than the ones used in the paper (buildings from Google Street View in my case)
I am thinking along these lines:

Segment GSVs with PointRend to obtain segmentation masks
--> Which output format do you expect for the masks?

Obtain approximate pose distribution
--> Not sure how to obtain this, tbh, any tips? What concretely needs to be provided to the model?

Train model
--> Would you recommend starting the training from scratch or can your pre-trained checkpoint work with out-of-distribution classes, such as buildings?

Run inference
--> How long does inference on a single image take approximately?

Thank you for your support and see you at CVPR,
Kevin

Hi Kevin,
Sorry for the late reply! For some reason I thought I had already replied. Perhaps I drafted an answer but forgot to send it! :)

The format is not really that important, since you can write a custom data loader. In the end, the model expects binary segmentations masks in the [0, 1] range, but in our datasets the masks are stored in RLE compressed format using pycocotools (in order to save space).
This is the tricky part. Ideally, you would need a rough pose annotation for each image in your dataset, according to some canonical reference frame (e.g. the roof should point towards +Y, the front door towards +X, or something like that). You might need to find or build a pose estimator for buildings. Alternatively, since you are using Google Street View images, you could exploit multi-view information, i.e. correspondences between different images. Then you can run COLMAP or similar methods, and align the poses to a canonical frame.
I recommend starting from scratch, since the distribution is very different.
This highly depends on the GPUs and hyperparameters, but I think that with proper tuning you should be able to get 1 image/second.

Thanks for sharing your advice!


chore: switch grpc api version to v1

Update values.yaml so that the default
version of the grpc API is now v1 from v0

bors merge


Use new metadata API

@johnspackman Can you review and merge if you approve of the PR?

I think we can remove getQoodooVersion instead of deprecate it, could‘nt we?

In this case you must chance template_vars.js, line 69 too!

I tried to remove the method and there was a problem which I did not have the time to investigate - that's why I left it and deprecated it for the time being. I agree with you and will have a second look hopefully later today.

@hkollmann @johnspackman Ok, I have reworked it so that now the version number is no longer taken from the versions.txt file but from the Manifest.json (as it should be). For this to work, you need the newest master with  @hkollmann's PR that bumped the version numbers (otherwise it the version is still 5.1, which is invalid semver in any case).

@johnspackman can you review so that this can get merged? Thanks!


firejail: fix examples

pkgs is not always global in the nix configuration file
Motivation for this change
In a relatively default configuration.nix file, the snippets found in configuration.nix man page are not working because pkgs is not "global".
error: undefined variable 'lib'
       at /etc/nixos/configuration.nix:25:27:
           24|       firefox = {
           25|           executable = "${lib.getBin pkgs.firefox}/bin/firefox";
             |                           ^
           26|           profile = "${pkgs.firejail}/etc/firejail/firefox.profile";
       … while evaluating 'isFunction'

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

the lib in these examples shouldn't be taken from pkgs but from a module argument; the module system also passes lib as an argument to each module. the firejail module (and indeed most documentation) assumes that modules are declared with at the config, options, pkgs, lib arguments. changing a few occurences here isn't a great solution, we should probably try to be more clear about which arguments documentation expects in modules instead.

Thanks for the explanations. I'm closing the PR.


EnableDefaultContentItems

EnableDefaultContentItems is not documented. See this thread on SO and https://github.com/aspnet/Docs/issues/7951

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ab5a5a0e-ae03-1237-6ebe-743066f27fa9
Version Independent ID: a342bfa4-4b0c-0a47-3695-858044f5aa5f
Content: MSBuild Reserved and Well-known Properties - Visual Studio
Content Source: docs/msbuild/msbuild-reserved-and-well-known-properties.md
Product: visual-studio-dev15
GitHub Login: @Mikejo5000
Microsoft Alias: mikejo

Closing this one in favor of #2016


Update documentation

Pull Request Test Coverage Report for Build 736

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 79.46%

Totals

Change from base Build 726:
0.0%

Covered Lines:
1973

Relevant Lines:
2483

💛  - Coveralls


Help. Understanding of custom actions. AASM + rails_admin

Hi, I've read readme on custom actions.
I'm trying to debug https://github.com/zcpdog/rails_admin_aasm
there are 2 pull requests, I've tried to install those as well. - still no luck.
Issue: I can't understand what state_event method should do https://github.com/zcpdog/rails_admin_aasm/blob/master/lib/rails_admin_aasm/field.rb#L107

when I choose a state from rails_admin - event is not being triggered.
I do understand that I shouldn't report here, but since maintainer is not active, I want to have some understanding and I've tried my best to understand the problem. Any help is appreciated.

3)Can't understand when this method is called.
https://github.com/zcpdog/rails_admin_aasm/blob/master/lib/rails_admin_aasm/action.rb#L22-L46
I've tried to put breakpoints and it never calls.
4)How would you solve this problem? Basically, when event is selected, it needs to call the event method before model is updated/saved.
5)https://github.com/zcpdog/rails_admin_aasm/blob/master/lib/rails_admin_aasm/action.rb#L50
Should be :put method added as well?
6)I can throw away aasm, if you tell me some better alternative that works well with Rails_admin.
State_machines looks like are not being maintained.
7)Is there something missing from this gem in order to work with rails_admin?
Please help!

Looks like Custom action is not what needed. What is needed is to modify Edit action to handle state property differently if changed.

No updates, closing.


Servo docs update

[x] Touch up the jsDoc descriptions.
[x] Port the servo docs from pxt-microbit
[x] Add pages for stop, setRange, and setStopOnNeutral.

Comment: Seems to be a decompile to field editor problem in docs:

RE: #720

Probably need to use toggleOffOn instead of toggleOnOff

Works in the editor but not in the docs. This works too: //% on.shadow=toggleOnOff

File a bug . I’ll take a look.
Get Outlook for iOShttps://aka.ms/o0ukef

From: Galen Nickel<EMAIL_ADDRESS>Sent: Thursday, February 28, 2019 7:34:15 PM
To: Microsoft/pxt-common-packages
Cc: Peli de Halleux; State change
Subject: Re: [Microsoft/pxt-common-packages] Servo docs update (#722)
Works in the editor but not in the docs. This works too: //% on.shadow=toggleOnOff
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fpxt-common-packages%2Fpull%2F722%23issuecomment-468530134&data=02|01|jhalleux%40microsoft.com|1ab6b5cead074c5d599708d69df6c763|72f988bf86f141af91ab2d7cd011db47|1|0|636870080566262889&sdata=V%2BBqJfo66t1ypNiSoincfDTb9qLWk5RgM4aBHZSm1x4%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAD-4KZaRZwC5I4VHI7bTEueTWdtBc_QDks5vSJ-3gaJpZM4bXgso&data=02|01|jhalleux%40microsoft.com|1ab6b5cead074c5d599708d69df6c763|72f988bf86f141af91ab2d7cd011db47|1|0|636870080566272898&sdata=FhMt9MFtZYNUl1iEOiQNUxhAgX%2F%2BPFrXw6EVa0BQ2J4%3D&reserved=0.


Error when plotting phase folded RVs

Hi,
I got the following error when Juliet was going through the plot of phase folded RVs!
/Users/jvines/anaconda2/lib/python2.7/site-packages/numpy/core/fromnumeric.py:2920: RuntimeWarning: Mean of empty slice.
out=out, **kwargs)
/Users/jvines/anaconda2/lib/python2.7/site-packages/numpy/core/_methods.py:85: RuntimeWarning: invalid value encountered in double_scalars
ret = ret.dtype.type(ret / rcount)
Traceback (most recent call last):
File "juliet.py", line 1807, in
ax_res.set_ylim([-5np.median(rv_bin_err),5np.median(rv_bin_err)])
File "/Users/jvines/anaconda2/lib/python2.7/site-packages/matplotlib/axes/_base.py", line 3457, in set_ylim
bottom = self._validate_converted_limits(bottom, self.convert_yunits)
File "/Users/jvines/anaconda2/lib/python2.7/site-packages/matplotlib/axes/_base.py", line 3068, in _validate_converted_limits
raise ValueError("Axis limits cannot be NaN or Inf")
ValueError: Axis limits cannot be NaN or Inf

Hi @jvines! Thanks for catching this --- this was just a plotting bug, which has now been resolved in commit 6ebb2df4d5bdea87ad22d238a73f51f01c1e4454. I will thus proceed to close this issue as resolved!
Thanks for using juliet!


Shift-home and shift-end key combinations not working in Windows editor (AsciidocFX version 1.8.8)

While using the editor, holding down the shift key and pressing the home or end keys do not highlight text in the current line to the beginning or end of the line (which is the normal behavior for this key combination).  I had not noticed this issue prior to version 1.8.8 of the Windows build.

Key handling mechanism has changed. There is default settings by ace and also you can configure it on Settings > Shortcut Settings.
Search "Select to" and you should see the default commands. You can modify the ones that you want. Let me know if it stills doesn't work. If it doesn't work, please enable debugging in the shortcut settings, and share the log output.

I was able to modify the settings to my liking, thank you.
I would recommend that the default settings be the following, at least in the Windows release:

Select to line end = Shift+End
Select to line start = Shift+Home

Maybe it's just me, but I use those keyboard shortcuts all the time.    I don't recall any other Windows programs using different shortcuts for those actions, I think they are pretty universal.
Thanks for all your work on this project.


Adding Connection, Driver tests and removing unsued utilities

This change is

Reviewed 7 of 7 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks broke.

Comments from the review on Reviewable.io

Review status: all files reviewed at latest revision, all discussions resolved, some commit checks broke.

Comments from the review on Reviewable.io


pip install plotly fails with IOError: [Errno 2] No such file or directory: 'README.rst'

Fixed by https://github.com/plotly/python-api/pull/250. To re-install, you'll need to run:
$ pip install plotly --upgrade --no-cache-dir

(otherwise, pip will try re-installing with the existing cached version 1.7.3, which was broken)


In depth review of MLJModel loading time is necessary

Importing MLJModels takes way longer than it should given that it doesn't really include any packages beyond the basic ones.
In view of the recent speedup achieved by tweaking how the metadata was retrieved, it would be useful to know what takes time when loading MLJModels and dig.
I suspect some of the work to reduce this latency will go in fixing things in MLJBase as well.
Help to do this would be very welcome (at this point it's just a case of figuring out what operation takes how much  time when loading everything).
-- the first thing to check is that the actions where MLJModels retrieves the list of models and metadata is not super slow.

Hehe, now it's ~4s 😄 most of which is MLJBase I think.
We can probably further improve this but for now I'm closing this.


new RPS statistic in the RPS line type; inverted score

Describe the New Feature
A new RPS statistic output for the RPS line type that inverts the current scale being used. The new RPS statistic would have 1 as a perfect score, and 0 as having no skill.
Since this changes the output format, we also need to update the version number from met-9.0 to met-9.1.
Acceptance Testing
List input data types and sources.
Describe tests required for new functionality.
Time Estimate
8 hours.
Sub-Issues
Consider breaking the new feature down into sub-issues.
No sub-issues required.
Relevant Deadlines
None
Funding Source
2760811
Define the Metadata
Assignee

[x] Select engineer(s) or no engineer required
[x] Select scientist(s) or no scientist required

Labels

[x] Select component(s)
[x] Select priority
[x] Select requestor(s)

Projects and Milestone

[x] Review projects and select relevant Repository and Organization ones
[x] Select milestone

Define Related Issue(s)
Consider the impact to other METplus components.
Delete items that do not apply.

[ ] Define new issue for METdb.
[ ] Define new issue for METviewer.

Time Estimate
Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.
Define Related Issue(s)
Consider the impact to the other METplus components.

[X] METplus, MET, METdb, METviewer, METexpress, METcalcpy, METplotpy
[ ] Define new issue for METdb to update the schema.
[ ] Define new issue for METviewer to aggregate/plot the new stat.

New Feature Checklist
See the METplus Workflow for details.

[X] Complete the issue definition above.
[X] Fork this repository or create a branch of develop.
Branch name: feature_<Issue Number>_<Description>: featuer_1280_rps
[ ] Complete the development and test your changes.
[ ] Add/update unit tests.
[ ] Add/update documentation.
[ ] Push local changes to GitHub.
[ ] Submit a pull request to merge into develop, listing the <Issue Number> in the title.
[ ] Iterate until the reviewer(s) accept and merge your changes.
[ ] Delete your fork or branch.
[ ] Close this issue.

Test link to METplus/#213

Informed from CPC that primary score would be RPSS, which scores negative infinite to 1, with 1 being perfect skill. Possible choice to invert score orientation of RPS was to match the typical scale of skills scores and RPSS. Reaching out to EMC members for naming preference, possible option is "RPS (positive oriented)".

EMC has suggested naming conventions of "RPS + oriented" and "RPS - oriented" for RPS statistics.

The existing RPS columns are named:
TOTAL, N_PROB, RPS_REL, RPS_RES, RPS_UNC, RPS, RPSS, and RPSS
This issue will add another column for the quantity "1 - RPS".  RPS is a well-defined statistic between 0 and 1, with 0 being perfect.  As such, I recommend that we keep the existing RPS column name unchanged.
The recommended names, "rps + oriented" and "rps - oriented", would make more sense when used together, but less sense when used individually.  In probability-space, the value "1-p" is often called the "complement" of p.  Following that convention, I propose that we name our new column RPS_COMP, for the complement of the RPS statistic.

On 4/28/20, confirmed with NCAR statisticians (Barb Brown and Eric Gilleland) and EMC scientists (Binbin Zhou) that naming the new column RPS_COMP is acceptable.  Per Binbin, we should install met-9.1_beta1 on venus or mars for him to test.

The WWRP/WGNE Joint Working Group on Forecast Verification Research (https://www.cawcr.gov.au/projects/verification/) does include the following note about RPS:
Range: 0 to 1.  Perfect score: 0.
Characteristics: Measures the sum of squared differences in cumulative probability space for a multi-category probabilistic forecast. Penalizes forecasts more severely when their probabilities are further from the actual outcome. Negative orientation - can "fix" by subtracting RPS from 1
This negative orientation version of RPS is exactly what we added in the new RPS_COMP (for the complement of RPS).


could not find any enabled regions"

I am facing these issues could not find any enabled regions".I am building a new cloud-nuke image and following the documentation but this error. Can someone please help me?

Could you provide a bit more context? What command are you running? Could you share the full log output and error?

I'm seeing this when I run cloud-nuke aws --dry-run using credentials and a region of us-gov-west-1.  If I use the same credentials to run aws ec2 describe-regions, I am receiving this result:
{
    "Regions": [
        {
            "Endpoint": "ec2.us-gov-west-1.amazonaws.com",
            "RegionName": "us-gov-west-1",
            "OptInStatus": "opt-in-not-required"
        },
        {
            "Endpoint": "ec2.us-gov-east-1.amazonaws.com",
            "RegionName": "us-gov-east-1",
            "OptInStatus": "opt-in-not-required"
        }
    ]
}

I am running into this same error, and it seems that GovCloud is not supported.  I've run this tool on commercial accounts, but GovCloud is another AWS partition and requires a number of changes.

@johnegrosjean  Do you have a link to the documentation?

@johnegrosjean  Do you have a link to the documentation?

Ah, if this is a GovCloud issue, then let's consolidate the discussion into #157.

Ah, if this is a GovCloud issue, then let's consolidate the discussion into #157.

Running into the same issue here:
INFO[2021-04-01T11:03:52-04:00] The following resource types will be nuked:
INFO[2021-04-01T11:03:52-04:00] - ami
INFO[2021-04-01T11:03:52-04:00] - asg
INFO[2021-04-01T11:03:52-04:00] - ebs
INFO[2021-04-01T11:03:52-04:00] - ec2
INFO[2021-04-01T11:03:52-04:00] - ecscluster
INFO[2021-04-01T11:03:52-04:00] - ecsserv
INFO[2021-04-01T11:03:52-04:00] - eip
INFO[2021-04-01T11:03:52-04:00] - ekscluster
INFO[2021-04-01T11:03:52-04:00] - elb
INFO[2021-04-01T11:03:52-04:00] - elbv2
INFO[2021-04-01T11:03:52-04:00] - lambda
INFO[2021-04-01T11:03:52-04:00] - lc
INFO[2021-04-01T11:03:52-04:00] - rds
INFO[2021-04-01T11:03:52-04:00] - s3
INFO[2021-04-01T11:03:52-04:00] - snap
ERRO[2021-04-01T11:04:01-04:00] *errors.errorString could not find any enabled regions
github.com/gruntwork-io/cloud-nuke/aws/aws.go:73 (0x1974bb5)
github.com/gruntwork-io/cloud-nuke/aws/aws.go:86 (0x1974ce6)
github.com/gruntwork-io/cloud-nuke/commands/cli.go:200 (0x19939ce)
github.com/gruntwork-io/gruntwork-cli@v0.1.2/errors/errors.go:93 (0x16a175e)
github.com/urfave/cli@v1.20.0/app.go:490 (0x1691402)
github.com/urfave/cli@v1.20.0/command.go:210 (0x169269b)
github.com/urfave/cli@v1.20.0/app.go:255 (0x168f5e8)
github.com/gruntwork-io/gruntwork-cli@v0.1.2/entrypoint/entrypoint.go:21 (0x1996478)
github.com/gruntwork-io/cloud-nuke/main.go:13 (0x19966a7)
runtime/proc.go:204 (0x10395e9)
runtime/asm_amd64.s:1374 (0x106b901)
  error="could not find any enabled regions"

@mitchbregs did you find any work around on the above issue? I am facing the same issue here.

nvm, added printf statement for debug logs, seems like there was insufficient permission. But pre-defined error statement "ERROR: could not find any enabled regions" doesn't give much of a info to debug.
func retryDescribeRegions() (*ec2.DescribeRegionsOutput, error) {
	regionsToTry := append(OptInNotRequiredRegions, GovCloudRegions...)
	for _, region := range regionsToTry {
		svc := ec2.New(newSession(region))
		regions, err := svc.DescribeRegions(&ec2.DescribeRegionsInput{})
		if err != nil {
		fmt.Printf(" error: %s\n", err.Error()) // debug logs
			continue
		}
		return regions, nil
	}
	return nil, errors.WithStackTrace(fmt.Errorf("could not find any enabled regions"))
}


Exclude dynamically changing data from text

There currently exists a way to exclude dynamically changing data (e.g. dates) from JSON. It would be nice to extend this to text documents (and maybe HTML) as well.

Has there been any updates to this issue?

No, there hasn't been any work done on it. I don't actively develop the gem anymore, though I do review and discuss proposed patches.

Oh, hi!  I've been working on a comparison tool specifically designed for JSON data that supports ignoring specific parts of the document.  It's still wet around the ears and definitely not worth adding as a dependency to this gem... but maybe an adapter can be written?  Or, of course, feel free to swipe any ideas and/or code that's useful.  :)
https://github.com/realgeeks/check_please

Oh, hi!  I've been working on a comparison tool specifically designed for JSON data that supports ignoring specific parts of the document.  It's still wet around the ears and definitely not worth adding as a dependency to this gem... but maybe an adapter can be written?  Or, of course, feel free to swipe any ideas and/or code that's useful.  :)
https://github.com/realgeeks/check_please

Oh, see also https://github.com/mcmire/super_diff/

Oh, see also https://github.com/mcmire/super_diff/


feat(explain): reimplement explain using pretty-xmlish

Edit: here's an example from planner tests:
Projection { cost: 8163.5923, exprs: [ sum {  } ] }
└── Aggregate { aggs: [ sum {  } ], cost: 8161.992, group_by: [] }
    └── Projection { cost: 7964.3843, exprs: [ l_extendedprice, l_discount ] }
        └── Filter
            ├── cond: and
            │   ├── lhs: >= { lhs: l_shipdate, rhs: 1994-01-01 }
            │   └── rhs: and
            │       ├── lhs: > { lhs: 1995-01-01, rhs: l_shipdate }
            │       └── rhs: and
            │           ├── lhs: >= { lhs: 0.09, rhs: l_discount }
            │           └── rhs: and { lhs: > { lhs: 24, rhs: l_quantity }, rhs: >= { lhs: l_discount, rhs: 0.07 } }
            ├── cost: 7210.72
            └── Scan { cost: 4000, list: [ l_quantity, l_extendedprice, l_discount, l_shipdate ], table: lineitem }

Demo:
> explain create table t(v1 int not null, v2 int not null);
+---------------------------------------------------------------------------------+
|                                                                                |
| CreateTable                                                                     |
| ├── columns: [ Column { name: v1, type: INT }, Column { name: v2, type: INT } ] |
| ├── cost: 0.1                                                                   |
| ├── database_id: 0                                                              |
| ├── name: t                                                                     |
| ├── ordered_ids: []                                                             |
| └── schema_id: 0                                                                |
|                                                                                |
+---------------------------------------------------------------------------------+
in 0.025s
> create table t(v1 int not null, v2 int not null);
+---+
| 1 |
+---+
in 0.003s
> explain insert into t values(1, 1), (4, 2), (3, 3), (10, 12), (2, 5);
+-------------------------------------------------+
|                                                 |
| Insert { cols: [ v1, v2 ], cost: 20, table: t } |
| └── Values { cost: 10, rows: 5 }                |
|     ├── [ 1, 1 ]                                |
|     ├── [ 4, 2 ]                                |
|     ├── [ 3, 3 ]                                |
|     ├── [ 10, 12 ]                              |
|     └── [ 2, 5 ]                                |
|                                                 |
+-------------------------------------------------+
in 0.006s
> create table ttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttt(v1 int not null, v2 int not null);
+---+
| 1 |
+---+
in 0.003s
> explain insert into ttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttt values(1, 1), (4, 2), (3, 3), (10, 12), (2, 5);
+--------------------------------------------------------------------------------------------+
|                                                                                |
| Insert                                                                                |
| ├── cols: [ v1, v2 ]                                                                       |
| ├── cost: 20                                                                               |
| ├── table: ttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttt |
| └── Values { cost: 10, rows: 5 }                                                           |
|     ├── [ 1, 1 ]                                                                           |
|     ├── [ 4, 2 ]                                                                           |
|     ├── [ 3, 3 ]                                                                           |
|     ├── [ 10, 12 ]                                                                         |
|     └── [ 2, 5 ]                                                                           |
|                                                                                |
+--------------------------------------------------------------------------------------------+
in 0.006s

Before this PR, we have:
> explain create table t(v1 int not null, v2 int not null);
+---------------------------------------+
| CreateTable: name="t", ... (cost=0.1) |
|                                       |
+---------------------------------------+
in 0.024s
> create table t(v1 int not null, v2 int not null);
+---+
| 1 |
+---+
in 0.003s
> explain insert into t values(1, 1), (4, 2), (3, 3), (10, 12), (2, 5);
+-----------------------------+
| Insert: t[v1, v2] (cost=20) |
|   Values: 5 rows (cost=10)  |
|                             |
+-----------------------------+
in 0.006s
> create table ttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttt(v1 int not null, v2 int not null);
+---+
| 1 |
+---+
in 0.002s
> explain insert into ttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttt values(1, 1), (4, 2), (3, 3), (10, 12), (2, 5);
+-----------------------------------------------------------------------------------------------------------+
| Insert: ttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttt[v1, v2] (cost=20) |
|   Values: 5 rows (cost=10)                                                                                |
|                                                                                |
+-----------------------------------------------------------------------------------------------------------+
in 0.006s

This is a first demonstration of pretty-xmlish. There are some improvements I plan to do with the library so there will be another PR after this.

Again need help on fixing tests...

What help do you need? 👀

What help do you need? 👀

I expect the test data to be somehow generated, but I don't know how 😳
Sorry, I should've explained earlier.

I expect the test data to be somehow generated, but I don't know how 😳

Do you want make apply_planner_test?

Others generally feel good to me! As a person not very familiar with pretty-printing, the major benefits I felt are:

Adding one layer of IR separates concern of "what to print" and "how to print", and makes implementation easier.
The wrapping behavior is cool: (it's worth adding to the doc for pretty-xmlish 🤔)

+--------------------------------------------------------------------------------------------+
|                                                                                |
| Insert                                                                                |
| ├── cols: [ v1, v2 ]                                                                       |
| ├── cost: 20                                                                               |
| ├── table: ttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttt |
| └── Values { cost: 10, rows: 5 }                                                           |
|     ├── [ 1, 1 ]                                                                           |
|     ├── [ 4, 2 ]                                                                           |
|     ├── [ 3, 3 ]                                                                           |
|     ├── [ 10, 12 ]                                                                         |
|     └── [ 2, 5 ]                                                                           |
|                                                                                |
+--------------------------------------------------------------------------------------------+

BTW, I still don't fully understand what's the differences between pretty-xmlish and pretty, and other benefits of pretty-xmlish. To gain more adoption, it might be better to make it more clear and include some examples in the future. 🫣

it's worth adding to the doc for pretty-xmlish 🤔

What do you mean 'doc'? I have an RFC for pretty-xmlish but idk why it's not on crates.io...

Short answer: when you need the └── thingy, it requires a stack in the textualizer, which is impossible with pretty.

it's worth adding to the doc for pretty-xmlish 🤔

What do you mean 'doc'? I have an RFC for pretty-xmlish but idk why it's not on crates.io...

+1 request for the code docs that can be shown in docs.rs. Now it looks blank. 🫥

it's worth adding to the doc for pretty-xmlish 🤔

What do you mean 'doc'? I have an RFC for pretty-xmlish but idk why it's not on crates.io...

+1 request for the code docs that can be shown in docs.rs. Now it looks blank. 🫥

I think the rfc is pretty descriptive. I think it's better than comment-based docs... But it's just my personal opinion.

I think the rfc is pretty descriptive. I think it's better than comment-based docs... But it's just my personal opinion.

From a user point of view, I think I need a quick start example. The RFC looks TL;DR. 🤣

I think the rfc is pretty descriptive. I think it's better than comment-based docs... But it's just my personal opinion.

From a user point of view, I think I need a quick start example. The RFC looks TL;DR. 🤣

I assume you're asking me to write a TL;DR for the rfc. I will do that tomorrow. You can stop me before that if that's not what you want.

@wangrunji0408 I have just came up with a perfect idea on addressing the binary expression problem. I'll do that tomorrow.
It requires extending the enum Pretty that makes the pretty printing result "binary" if two of its members are either binary or text.
In case they're not, or the line will become too long, the node will be displayed as a record with two fields.
This resolves the problem I mentioned just now.

I think the rfc is pretty descriptive. I think it's better than comment-based docs... But it's just my personal opinion.

From a user point of view, I think I need a quick start example. The RFC looks TL;DR. 🤣

I assume you're asking me to write a TL;DR for the rfc. I will do that tomorrow. You can stop me before that if that's not what you want.

I mean the instructions for use, i.e. what code should I write to pretty print my struct. 🤔
A TL;DR for the design doc (RFC) is also nice to have.

I see. That's totally reasonable. I'll see what I can do.

I have partially fixed the problems of pretty-xmlish. It remains to deal with binary expressions... But IMO, in risingwave, there is no such design, right?

I have partially fixed the problems of pretty-xmlish. It remains to deal with binary expressions... But IMO, in risingwave, there is no such design, right?

Yes. In RisingWave (and old version RisingLight), expressions and plan nodes are assembled into different enums separately.

I have partially fixed the problems of pretty-xmlish. It remains to deal with binary expressions... But IMO, in risingwave, there is no such design, right?

Yes. In RisingWave (and old version RisingLight), expressions and plan nodes are assembled into different enums separately.

Why does risinglight migrated to this type unsafe approach then? 🥲

A little question: why did you force-push? It made "Show changes since your last review" doesn't work 😇

Of course it's because I always forget to sign off my commits :cry:

@wangrunji0408 please take a look. If you think it's okay to address binary expressions later, feel free to merge this.
If you want me to fix the problem and then merge it, let me know. I think we can first integrate this shit into risingwave which does not have this expression-statement mixed structure first :)

Why does risinglight migrated to this type unsafe approach then? 🥲

It is an limitation of the egg framework. 🥲

Looks good to me. Please also fix the CI test before merging. Thx!

The doctest is failing!? 😲

Thank you @xxchan @wangrunji0408, w/o you guys I couldn't have discovered the (several) critical bug(s) of pretty-xmlish. I am also inspired to design some new features of it.
Thank you very much!


Add go.mod and convert imports to mod

First of all, nice work. The first mqtt-broker written in go thats simple to read :+1:
This PR just convert the library to an go-mod so that it can easy be used by other projects ( and addons )
.. plugins coming soon :)

Hello stackshadow, sorry for not responding to your PR, I've been away for a bit.
Please reopen your PR or create a new one and submit the changes again. I hope we can build something great!
Thank you for your interest.


Picture not rerendering on iOS

Hi!
I'm creating a drawing-like component using skia and gesture handler. My code looks like this (simplified):
const DrawBoard = forwardRef<DrawBoardType, Props>(({style}, ref) => {
    const path = useSharedValue<Element>({path: Skia.Path.Make(), paint: Skia.Paint(), type: "draw"});
    const lastTouch = useSharedValue<{x: number; y: number}>({x: 0, y: 0});
    const {toolbar} = useToolbar();
    const currentPicture = useSharedValue(emptyPicture);

    const panGesture = Gesture.Pan()
        .maxPointers(1)
        .minDistance(0)
        .averageTouches(true)
        .enabled(toolbar.activeTool !== Tools.None)
        .onStart(e => {
            const newPath = Skia.Path.Make();
            newPath.moveTo(e.x, e.y);
            if (toolbar.activeTool === Tools.Pencil || toolbar.activeTool === Tools.Eraser) {
                newPath.lineTo(e.x, e.y);
            }
            const newPaint = Skia.Paint();
            newPaint.setStyle(PaintStyle.Stroke);
            newPaint.setColor(Skia.Color(toolbar.color));
            newPaint.setStrokeWidth(toolbar.strokeWidth);
            if (toolbar.activeTool === Tools.Eraser) {
                newPaint.setBlendMode(BlendMode.Clear);
            } else {
                newPaint.setBlendMode(BlendMode.Src);
            }
            path.value = {
                path: newPath,
                paint: newPaint,
                type: toolbar.activeTool === Tools.Eraser ? "erase" : "draw"
            };
            lastTouch.value = {x: e.x, y: e.y};
        })
        .onUpdate(e => {
            if (toolbar.activeTool === Tools.Rectangle) {
                path.value.path.reset();
                path.value.path.addRect({
                    x: lastTouch.value.x,
                    y: lastTouch.value.y,
                    width: e.x - lastTouch.value.x,
                    height: e.y -lastTouch.value.y
                });
            } else if (toolbar.activeTool === Tools.Circle) {
                path.value.path.reset();
                path.value.path.addCircle(lastTouch.value.x, lastTouch.value.y, Math.sqrt(Math.pow(e.x - lastTouch.value.x, 2) + Math.pow(e.y - lastTouch.value.y, 2)));
            } else {
                path.value.path.lineTo(e.x, e.y);
            }
            // update the picture
            currentPicture.value = createPicture(
                canvas => {
                    canvas.drawPath(path.value.path, path.value.paint);
                }
            )
        })
        .onEnd(() => {
            path.value = {path: Skia.Path.Make(), paint: Skia.Paint(), type: "draw"};
        });

    return (
        <View style={[style, {pointerEvents: toolbar.activeTool === Tools.None ? "none" : "auto"}]}>
            <View style={styles.container}>
                <GestureDetector gesture={panGesture}>
                    <Canvas style={styles.canvas}>
                        <Picture picture={currentPicture} />
                    </Canvas>
                </GestureDetector>
            </View>
        </View>
    )
});

This works fine on Android, but on iOS the Picture doesn't rerender. I already added logs inside of the createPicture function and saw, that it is called while painting and also the value of the path looks good, so I have no idea why the picture doesn't rerender.

Can you provide a standalone reproducible example? I would be happy to take a look

Repro is available here: https://github.com/mbpictures/react-native-skia-sketch-repro

Any updates?

I've noticed that on iOS, removing the following: {pointerEvents: toolbar.activeTool === Tools.None ? 'none' : 'auto'} make the example work immediately, no idea why

Thanks for the investigation! Removing {pointerEvents: toolbar.activeTool === Tools.None ? 'none' : 'auto'} didn't work for me. Also interesting: I use the exact same code in my production app, but with additional saving/restoring of the canvas/the drawing. When I close the app and open it again, so the drawings get reloaded, they show up on the screen. That's the reason I thought it is not a layout related bug. However updating the code as you did (giving the canvas the style of flex: 1, instead of using absolut positioning) worked, which is kinda weird for me!

Having the exact same issue as you, on new architecture. Initially the path will render properly, but might randomly disappear. Only fully closing and opening the app resolves the issue.

@shopify/react-native-skia 1.5.0
Expo SDK 52
RN 0.76.3
iPhone 15 Pro Max simulator

@mbpictures I was able to reproduce the issue in a minimal example. Hopefully we can find the root cause issue.
@JonathanLab Would you mind share your code with us? That would be interesting data.


Power state is missing

I'm not getting the powerstate for vms i.e. "Deallocated", "Running"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2b408d60-f96c-a7ea-3fc5-638fcaf322c0
Version Independent ID: c186d2b8-ecb0-9d47-bb2a-3a3ede3f0c70
Content: Query output of Azure PowerShell cmdlets
Content Source: docs-conceptual/azps-7.3.2/queries-azureps.md
Service: azure-powershell
GitHub Login: @mikefrobbins
Microsoft Alias: mirobb

@placidseven - It doesn't appear that the cmdlets used in the article return any type of Power state property.
Can you elaborate on what you are trying to accomplish?

@placidseven - Can you elaborate on what you are trying to accomplish here in this issue?

@placidseven - Since we have not heard back from you we will now proceed to close this thread.
However if you can share additional information requested and circle back on this thread , we will gladly reopen the issue and continue the discussion. Thank you.


"'ranger_usersync_log_dir'' is undefined' during usersync config

Ranger usersync installation is breaking due to "ranger_usersync_log_dir'' being undefined in roles/ranger/usersync/templates/usersync_install.properties.j2
#user sync log path
logdir= {{ ranger_usersync_log_dir }}

This variable was probably missed by the log4j configuration unification see https://github.com/TOSIT-IO/tdp-collection/pull/704

Just saw that #710 is fixing the issue, reviewing


CONFIG: Switch to CleanMoq

This is a standard compliant change to switch the Moq library to CleanMoq

This was already done closing issue


Default to 0 if repetitions is not found

Fixes https://dimagi.sentry.io/issues/5841775442/?referrer=issue_alert-slack&notification_uuid=b8a118fd-80ed-4cfe-b3ca-d67754f2d2f0&alert_rule_id=14063560&alert_type=issue
Description

Although this will fix the issue above, I still want to investigate how this came to be an issue exactly. This thing should not have happened.
User Impact

Demo

N/A
Docs

N/A

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Additional details and impacted files

:loudspeaker: Thoughts on this report? Let us know!

Superseded by https://github.com/dimagi/open-chat-studio/pull/685


Check used tools versions

Check tools versions in all scripts:

git
sops
yq

Don't check tools versions in git hooks to reduce load.
Only check during installation.


manpage does not describe -D option

The synopsis section of the manpage has:
fasd [-A|-D] [paths ...]
Later, under Compatibility, the -A option is described:

 In shells  without  prompt  command  or prompt  command  substitution  (tcsh for instance), you can add entries manually with "fasd -A"

However, the -D option isn't described at all. Presumably, it removes entries?

It shows up in the examples and it shows up in fasd --help, so I'm guessing this is something that was missed? But, yeah, it removes entries :}


Log error if watcher is not defined

Just to make the title clear -- we probably should not disallow watcher-less components as one may often require static reusable templates, instead an erroneous watcher path must be logged, e.g. watcher /bad/path does not exist