Unpooled.wrappedBuffer with a direct ByteBuffer on android/dalvik wraps as a heap bytebuf

in https://github.com/netty/netty/blob/4.0/buffer/src/main/java/io/netty/buffer/Unpooled.java
when wrapping a java.nio.ByteBuffer that is direct (indeed a java.nio.DirectByteBuffer), the function
public static ByteBuf wrappedBuffer(ByteBuffer buffer) (line 182)
tests if the buffer hasArray() in order to determine if to create an UnpooledHeapByteBuffer or an UnpooledDirectByteBuffer.
Obviously, we expect this function to chose, in our case, an UnpooledDirectByteBuffer for the wrapping. But on android/dalvik, the result is the opposite, because the dalvik direct ByteBuffer returns true for its member .hasArray() !
Don't ask me why.
I suggest to change line 186 from:
if (buffer.hasArray()) {
to:
if (buffer.hasArray() && ! buffer.isDirect()) {
just to make sure in the case of a dalvik direct ByteBuffer that apparently "hasArray" while being a direct ByteBuffer.
Tested on dalvik API level 19

@nlavan thanks for reporting. I will fix it... I was a bit surprised but it seems "valid" that even a direct buffer may have an byte[].
See
https://docs.oracle.com/javase/8/docs/api/java/nio/ByteBuffer.html#allocateDirect-int-

yep, i didnt check the dalvik source code...
btw, i think your fix should also apply to 4.1 branch, right?

yep 4.0 and 4.1

@nlavan will be fixed by https://github.com/netty/netty/pull/5636

@normanmaurer thanks for the quick fix, and for Netty's amazing work in general. Netty rocks, after the learning curve is passed...

Fixed by https://github.com/netty/netty/pull/5636


Fix wrongly displayed markdown

Signed-off-by: Eduard Laur<EMAIL_ADDRESS>
What this PR does / why we need it:
Github is wrongly displaying toml markdown in accessing_files.md

Special notes for your reviewer:
If applicable:

[x] this PR contains documentation
[ ] this PR contains unit tests
[ ] this PR has been tested for backwards compatibility

Sure

@mattfarina Done


Revenants are ridiculously tanky

Description
Revenants, either innately or by draining souls (I can't really tell you which) can become extremely tanky. They can very haunt medbay an entire round, and get to the point where they can kill someone the INSTANT they fall asleep, and tank many many shots and then go invisible and run away and re-initiate. They snowball very hard.
I don't know if they are innately tanky or if this is just something that happens with soul drain that doesn't have an upper limit.
Screenshots

Additional context
Fighting an ambush antagonist with over 1k health that can phase through walls, pick its fights all the time, cause hull breaches and stack up corpses which generate diseases which WILL eventually generate sleeping sickness is VERY not fun to fight against.

pretty sure their HP is meant to scale with the amount of essence they actually have (so it shouldn't exceed like 150 most of the time?)
granted I didn't write rev but last time I played it that's how it was - you soulsuck someone in the wrong location and four greytiders can almost/can kill you
is it because that TotalDamage is indeed that, the damage total, and it's counted damage healed over time (by adding more essence) because the way rev is coded?

If someone wants to tweak some values, there's a value for how much essence is recovered per second as well as a conversion factor for damage total to essence.


Edits to installation instructions

Edits to install instructions

Closing this PR due to changes, will look at them and create a new PR after updating my changes with the changes coming in with the latest approved PR.


Add new check in APIView to verify and enforce package name approval

Add new step in API check step to enforce package name approval for preview version release.

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow


⚠ Bofrost.com has degraded performance

In 7b47ad2, Bofrost.com (https://www.bofrost.com) experienced degraded performance:

HTTP code: 200
Response time: 836 ms

Resolved: Bofrost.com performance has improved in 843056c after 10 minutes.


Apostrophe in  Breaking HTML Rendering

Apostrophes seem to be breaking the html rendering.  The MJML code below has 2 mj-text blocks in succession.  With the apostrophe in "doesn't", it breaks the HTML rendering in the subsequent mj-text block--looking at the generated HTML, the second  code is there in full without being converted.
This can be replicated on http://miml.io/try-it-live/ using the code below.  This is a new issue that cropped up recently--the same code worked on try-it-live a few days ago.
<mjml>
  <mj-body>
    <mj-container>
      <mj-section padding="0">
        <mj-column>
          <mj-text font-size="18px" color="#b94f27" font-family="helvetica" padding-bottom="0px" font-weight="bold">Why doesn't this work?</mj-text>
          <mj-text font-size="16px" color="#5d5d5d" font-family="georgia, serif" line-height="24px" padding-top="5">This should be on a new line with a new font...</mj-text>
        </mj-column>
      </mj-section>
    </mj-container>
  </mj-body>
</mjml>

Render With Apostrophe

Render Without Apostrophe

Hi @ericboles, thanks for opening the issue and big up for making it so clear with code and screenshots 👍
This is an issue related to the encoding of special characters in v3.3.0 (beta.3), we'll fix it in a future update, thanks for spotting it! If needed, please note that you can use the v3.2.2 locally (see install MJML locally) where this issue isn't happening.
Cheers

Hey @ericboles, sorry I didn't update you earlier, it was fixed in MJML and it's fixed on the try it live editor too!
Thanks again for reporting :)

Thanks @ngarnier.  That's working now--good to see.  That said, somewhere along the way we seem to have lost the ability to retain HTML entities in the conversion from MJML to HTML.  The entities are now output as their respective characters...like → instead of →
We've often found not using the entity can cause problems in older clients... And further problems when you want to take advantage of   to ensure a call to action like "Read More" doesn't line break in the middle.
Any chance of retaining the entities?

I think you're describing issue #343. We also have this problem and as a workaround we encode our content twice before inserting it into our MJML (turning a literal & into &amp; ... but watch out for ' because certain versions of outlook don't like it- use ' instead).
Hopefully when the parser work is finished we can remove this hack!

@levilansing sorry for posting on an old issue but this is still a problem in v3.3.5. I should not have to use the double encode hack for URLs right?  (URLs with question marks, and apostrophes)
It wasn't immediately obvious to me because, for example,   was just showing up as a space in the compiled HTML.

AFAIK it is still an issue in v3.3.5. It was my understanding the underlying issue would be fixed in 4.0 because of a new parser. However, I haven't tried it out yet and haven't seen any activity on the related issues.

@tolusonaike indeed it's an issue, but as pointed by @levilansing on February 25th, you're describing a different issue (#343).


The problem about testing results using the 3D60 dataset

Hello, I encounter a problem similar to zcq15 about 3D60 dataset test. I have tryed to retrained the network on 3D60, but the results seemed to poor compared with the results in paper. I just used your codes directly and didn't do any data preprocessing on 3D60. The results with the given parameters are

I have also tested the 3D60 dataset with the given model parameters, but it seem to worse than the results in paper too. the results are below

Is there any additional operations on 3D60 dataset just like Stanford2D3D?
Thanks for your help. Looking forward for the reply!

You may have set the input size of 3D60 to (512, 1024), the previous papers usually use (256, 512) as the input size for 3D60 and PanoSUNCG.

Hello, can you share the 3D60 data set, thank you very much！

https://vcl3d.github.io/3D60/download.html


Fixes #25 - added encodeURIComponent to sanitize HTML body

Added encodeURIComponent around the body parameter of FormData that was sent to the backend.  This effectively fixes #25 as well.

That's great @krishnagopinath Thanks :smile:


Extract pages from a PDF document

Is it possible to extract PDF pages from a document? Let‘s say I have a document with 6 pages and I want to generate a new document that just contains pages 1-3?

One option would be generating the document with 6 pages and then generating another document where the first one is included using PDFExternalDocument.
PDFExternalDocument is currently only on develop

So you basically mean something like that?
let urlToSixPagesDoc = ...
let threePagesDocument = PDFExternalDocumentObject(url: urlToSixPagesDoc, pages: [1,2,3])


Debugging Swerve Drivetrain

why is there no need to call m_swerve anymore?

I think there was never a need to call it since we were accessing methods that we already in the file

why is there no need to call m_swerve anymore?

I think there was never a need to call it since we were accessing methods that we already in the file

so true


Partial Least Square SVD

Added Partial Least Square SVD transformer and tests for it.
Scikit-learn context

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart:


After installing node.Js VS code will no longer open. Even after re installing.

 command not found message.
Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.91
OS Version: mac OS 17.7.10

Steps to Reproduce:

installed vs code studio
installed node.js
VS code will no longer open. even after reinstalling or after deleting code map in Library.
when trying to open vs code a screen flashes but after that vs code closes again right away.
when having vs code in dock the maps i opened last time before downloading node.js are still opened when right clicking vs code. even after re installing vs code.

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.91.0. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

i am using this version of VS code... Problem is not solved

I'm also facing this same issue.......I tried to re-install vs code multiple time but still won't open then in the terminal of macos I tried writing out some commands to know the exact problem. Afterwards, I found out there's some file that's missing. Below I'm attaching screenshot of the file name that's missing.

I even tried with installing the latest version of vs code.........on my other laptop, I installed vs code and it's working fine on that one and I also checked all the files that it contains but there's no file like AppleIntelSKLGraphicsGLDriver. From this what I concluded is there's no file like this as vs code is working fine on my other laptop completely fine without this file and on the laptop where vs code isn't opening the terminal is showing this file is missing due to which it's not opening. I think the problem is something else actually. Please look into this and provide me with a solution asap.

@JoepKamminga problem got solved.....download older version of vs code and uninstall the new version.
link for older version: https://code.visualstudio.com/updates/v1_90


fix #2438 make sure each async part of HttpConnection is abortable

Everything old is new again, some lessons have to be learned over and over 😢
In NEST 0.x and 1.x the HttpConnection async bits is implemented using a marvalous APM callback soup implementation which was hard to read but battle hardened.
With 2.x we finally took the plunge to a TAP and async/await based implementation which is a joy to read. However in doing so we did not port all the timeouts registered with the threadpool to make the unabortable bits such as GetRequestStreamAsync and GetResponseAsync.
This PR brings back some APM wrapped to a Task with Task.Factory.FromAsync and ThreadPool.RegisterWaitForSingleObject is back in action to guard these calls.
To test this works start an 5.x elasticsearch server and use the AutoResponder in fiddler and set up the following rules:

Then using
static void Main(string[] args)
{
	Task.Run(async () =>
	{
		var connectionSettings = new ConnectionSettings(new Uri("http://ipv4.fiddler:9200"))
			.RequestTimeout(TimeSpan.FromSeconds(3));
		var client = new ElasticClient(connectionSettings);

		//var response = client.RootNodeInfo();
		var response = await client.RootNodeInfoAsync();
		Console.WriteLine(response.DebugInformation);
		Console.ReadKey();
	}).Wait();
}

First using the latest rc3 you'll see the synchronous code path adheres the timeout but the async code path does not.
If you then add manual references to a build from this branch you'll see both behaving fine.
If you uncheck the delay rule in fiddler you'll see both request succeeding again with no timeouts.

LGTM 👍 will merge into 5.x and port to 2.x and master now

ported to 2.x in d377118618730516716717fa3d40facff5eb0cf7
ported to master in e3d961bd43bb6e6f4d8d40fdd57c2b8797831de5


feat: Add vars to :host for shadow dom situations

Adds the vars to :host. This is to make them available inside of shadow dom that includes Fabric.
Why?
If fabric is included in shadow dom, all styling using :root as a selector will just be ignored.  Meaning everything fed by vars will turn up as undefined.
Potential problems
Other things in the fabric setup might need to be handled. There is a few rules in the reset amongst other things that are targeting :root. Those will not currently work.
Other potential solves
It could potentially work to generate default values on stuff like the colors? The veil of shadows would still block the variable, but the default would still do the trick, and magic using the variable for something inside the component could still do that.
Today it looks like:
.text-gray-600 {
color: var(--f-gray-600);
}
If we generated this instead?
.text-gray-600 {
color: var(--f-gray-600, #525247);
}

I feel like this is a good way to go for now. If we run into issues down the line we could revisit. The main advantage though seems to be (unless I misunderstand) that we can handle more than just colours this way. If we use your alternate suggestion, it would only work for colours right?

The alternative would cover the same as this ( All vars could potentially carry a default )  None of those fixes would fix the stuff like reset , but it could possibly be fixed by a little bit of build magic when we generate fabric.css?   (replace  ":root" with ":root,:host" )


nixos/containers: don't create veths if not configured

Previously, setting "privateNetwork = true" without specifying host and
local addresses would create unconfigured interfaces: ve-$INSTANCE on the host
and eth0 inside the container.
These changes is rebased part of the original PR #3021.
Motivation for this change
I have quite a few containers running on my home server and most of them use macvlans to connect to my local network. As a result, I'm left with a bunch of useless interfaces both on the host and inside containers (ve-$INSTANCE and eth0). It's not critical, but it would be nice to get rid of them.
Things done
I tried to run tests from nixos/tests/containers using $ nix-build nixos/tests/container-<test> and looking at result/log.html. Some tests failed, but they also fail for me on the current master, so I'm not sure how to check if proposed changes break anything.

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

@Mic92 can you please look at this one? Is there something more I should test/change?


GenSoftware:  Fix arc-theme installation

Arc-theme is not present in the Ubuntu 16.04 repositories which causes the script to fail on xenial.
This is an initial fix by adding the PPA for the same.
Further things to add:

[ ] Add arc icons
[x] Ubuntu 18.04 has these in its main repo itself. Add an if-else case to handle the different OSes
[ ] Tweak Tool is required to change the themes.
But 16.04 uses unity-tweak-tool whereas 18.04 uses gnome-tweak-tool
This will require the previous mentioned step.

Would recommend keeping PR open till all issues are fixed @rajat2004

@rsnk96 That's what I was thinking.


Question about commit the vendor directory

I read this in the documentation:

Read over the contents of vendor/ and make sure it looks reasonable. Then commit the Godeps/ and vendor/ directories to version control.

Why it is a good practice to commit the vendor directory? Usually this is something bad in other languages.
I didn't found information about this topic.
Thank you for your time.

I'm wondering this too, since godep restore and godep get seem to have no problem downloading and installing the dependencies specified in Godeps.json. If we don't need offline builds, do we really need to commit the vendor/ folder? Is something going to blow up in my face if I don't?

I am closing this issue because the repo is going to be archived.


Deduplicate a lot of javascript code in billing.js

The first 3 commits are from #11124. Please merge that PR before taking a look at this (Or close that )

Merged, thanks @hackerkid! This cleanup looks great. And thanks @showell for help with the review!


added full example of config and fixed some typos in find example.

As you requested, here are the changes.

Thanks.


Crypto setup script

We should have a crypto setup script to automate all the key setup. Related to #45 and #46.
The usage would be something like this:
$ crypto-setup init
===== consul =====
----> encryption key
no encryption key found, generating into inventory/group_vars/all/all.yml

==== marathon ====
----> certificate
no certificate found, generate? [Y/n]
generating certificate...
password? []: *****
writing certificate to inventory/marathon.jks
writing password to inventory/group_vars/marathon/all.yml

----> user
use basic auth to connect? [Y/n]
username [admin]: *****
password: *****
writing user:pass to inventory/group_vars/marathon/all.yml

If an update is needed (password change, etc), the user can run crypto-setup update COMPONENT [COMPONENT...]

+1 we need to focus on making it easy to set up security.

Could this just 'happen' instead of being a script that needs running/input? Secure by default seems like an even better path for usability.

We're doing it this way to avoid using default passwords. This will make it as easy as possible to set up security without leaking secrets.

When security is set up, these are the items that will need to be changed:

[ ] Create Self-signed TLS certs (this script)
[ ] mesos leader/follower credentials (this script)
[ ] mesos --authenticate flag (if credential is set)
[ ] mesos --authenticate_slaves flag (if credential is set)
[ ] consul acl_master token (this script)
[ ] consul gossip key (this script)
[ ] consul acl_datacenter
[ ] consul default acl_policy
[ ] consul ssl configuration
[ ] k/v auth in consul for nginx container. Create username:password combo in this script, and a role to upload to consul k/v. Let's make the password bcrypt using htpasswd -B if nginx supports it.
[ ] create zookeeper credentials
[ ] create zookeeper ACL on /mesos znode (in playbook if zk security is set)
[ ] create zookeeper ACL on /marathon znode (in playbook if zk security is set)
[ ] create nginx + consul-template container

I've added the relevant items to the description up top. I'm also going to change this to be noninteractive for now. It'll generate and store nicely random internal passwords and keys just fine without any user input.

+1

merged into 0.2-dev


qt: Update assets and colorize them theme related

This PR ist part of a series of +-25 PRs related to UI redesigns. Its ancestor is #3573, its successor is  #3575. I did not screenshot every single PR and its changes, instead i made "walk through all screen" videos with the result of this PR series and also with the 0.15 UI. If there are any concrete screenshots wanted, just let me know. To build with the full set of changes you can build from the branch xdustinface:pr-ui-redesign which always contains all changes.
 -> Walk through 0.15
 -> Walk through Redesign
I tried to give the commits enough text to make things obvious without a lot description for each PR. Also here, if you want more description for this specific PR, let me know.
About this PR

Replaces all checkbox and radiobutton assets with new ones aligned with the css style changes
Brings some changes to the usage of the arrows.
Updates all icons (at least all that will be still used after my next few PRs)
Updates the spinner
Makes sure icons are updated to the correct theme color if the theme gets changed
Adds GUIUtil::getIcon and GUIUtil::setIcon methods. They allow to colorize two colored icons.. Ideally those colors should be just black 0x000000 or white 0xFFFFFF. But the methods fill everything below 0x7F7F7F with the first color provided and the other part with the alternative color provided. So you can either get themed colored icons or directly set one for QAbtractButton derivations.

Preview

Send Dark: develop
Send Dark: After

Console Dark: develop
Console Dark: After

Send Light: develop
Send Light: After

Console Light: develop
Console Light: After

Ready for review! I updated the initial post with some description and screenshots.

I'm not a fan of the new "send/receive/send to self" icons.
I also don't like the HD logo
Otherwise looks good

I'm not a fan of the new "send/receive/send to self" icons.

Me neither, at least for the transaction screen. But they will be removed from there anyway in a follow up PR. I just did them this way for the debug console, there were the same ones used. But overall i think i will also drop them from there because i didn't find a way yet to align them properly with the increasing/decreasing text... So you may not longer need to look at them soon anyway :D

I also don't like the HD logo

I also partially share that with you, but only for hd_disabled.. and to be honest, i didn't put a lot love into this because i want to remove it anyway with #3688.. just created it for this PR to have it similar to the new hd_enabled.

Agree with @PastaPastaPasta re some new icons (hd/sent/received/to_self), would rather keep the old ones for now.

Okay i reverted the arrows. But regarding the HD icon i don't get it :D Look at the following.. does it really make sense to move it out of this PR now? IMO the old one doesn't fit any better in there.. rather worse since its smaller. Still want to revert it, let me know

HD enabled before
HD enabled now

HD disabled before
HD disabled now

Well, it's actually easier to say if it's a HD wallet or not looking at the smaller one imo.

Soo there we go, i still don't like its since its kind of pointless after the statusbar PR and i actually wanted to update all icons in one PR but what should i say if you both feel different 😄


freshness review and updates

@jaszperez,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@jaszperez : Thanks for your contribution to the Azure documentation! The author, @MarkusVi, has been notified to review your proposed change.

#sign-off


fatal: Couldn't find remote ref refs/heads/master�

Full error:
fatal: Couldn't find remote ref refs/heads/master
fatal: The remote end hung up unexpectedly�
I initialize a repository using:
repo init -u git@gitlab.mycompany.com:manifests/release.git -b release-2.9.0 -m c4_windows_master.xml
Sync using:
repo sync -d -c -q --jobs=8 --no-tags
Since I use Jenkins in my build environment, if I don't wipe the workspace, the same commands as above are executed, however the 'repo sync' command throws the fatal error.  This does not happen on linux using google's repo tool (with or without jenkins, it was manifested in jenkins).
In examining the trace log on windows I find this:
: git fetch --quiet origin --no-tags +refs/heads/master:refs/remotes/origin/master 1>| 2>|�
Looking at the trace log on linux I see this:
: git fetch --quiet origin --no-tags +refs/heads/release-2.9.0:refs/remotes/origin/release-2.9.0 1>| 2>|
Contents of .repo/manifests/.git/config on windows looks like this:
[core]
repositoryformatversion = 0
filemode = false
symlinks = false
ignorecase = true
hideDotFiles = dotGitOnly
[remote "origin"]
url = git@gitlab.mycompany.com:manifests/release.git
fetch = +refs/heads/:refs/remotes/origin/
[branch "default"]
remote = origin
merge = refs/heads/release-2.9.0�
Contents of .repo/manifests/.git/config on Linux looks like this:
[core]
repositoryformatversion = 0
filemode = true
ignorecase = true
precomposeunicode = true
[remote "origin"]
url = git@gitlab.mycompany.com:manifests/release.git
fetch = +refs/heads/:refs/remotes/origin/
[branch "default"]
remote = origin
merge = refs/heads/release-2.9.0
If I run 'git fetch --quiet origin --no-tags +refs/heads/master:refs/remotes/origin/master' I see the fatal error thrown.
If I run  'git fetch --quiet origin --no-tags +refs/heads/master:refs/remotes/origin/release-2.9.0'  no errors.
This version of repo seems to always run 'git fetch --quiet origin --no-tags +refs/heads/master:refs/remotes/origin/master' instead of the branch specified.
Let me know if you need more info.  I think this is headed in the right direction!  Thanks for providing a native windows tool!

I have a similar issue. The problem (I believe) is that the .repo\manifests\.git\HEAD file is saved with Windows-style newline (\r\n), but read as a binary file (see https://github.com/esrlabs/git-repo/blob/stable/project.py#L2544). The code that reads the current branch (see https://github.com/esrlabs/git-repo/blob/stable/project.py#L1263) reads default\r as the name instead of default. This creates a chain reaction where repo reverts to the master branch for the manifest.
A simple workaround is to rewrite the .repo\manifests\.git\HEAD file with a Unix-style end-of-line (\n only) before running repo sync.
@mputz86 I think fixing this issue should be easy enough (GetHead function should treat \r\n as \n).

Note: Given that Git For Windows contains a dos2unix utility, it is actually easy to fix the HEAD file. Simply run the command below after every repo init
dos2unix .repo\manifests\.git\HEAD

Note: Issue #41 is a duplicate of this issue.

That sounds like an option rather than an issue=!
On Tue, Sep 13, 2016, 7:29 PM Renaud Paquay<EMAIL_ADDRESS>wrote:

Note: Issue #41 https://github.com/esrlabs/git-repo/issues/41 is a
duplicate of this issue.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/esrlabs/git-repo/issues/33#issuecomment-246878854,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AH5okbmUfuCuf8yy4J58Y-4sAJUOwWb2ks5qp04EgaJpZM4H87WI
.

@matcheydj I don't quite understand your comment... What is an option?

Hi esrlabs/git-repo,
I'd like to add you to my professional network on LinkedIn.

David

Confirm that you know David: https://www.linkedin.com/comm/start/accept-invitation?sharedKey=H5LrZNVs&invitationId=6188766520202584064&trk=eml-guest-invite-cta&trkEmail=eml-invite_guest-null-2-null-null-0~itucqblq~3q
You received an invitation to connect. LinkedIn will use your email address to make suggestions to our members in features like People You May Know. Unsubscribe here: https://www.linkedin.com/e/v2?e=0-itucqblq-3q&t=lun&midToken=AQFmrFVhGEd36Q&ek=invite_guest&loid=AQHrrLVJFdud3AAAAVeLqu0JC44-IGpUEFoWcxq1RevBa9NwGxW4azx2P-yIYod6N2o9Z7ByFTSgWio6l1UFVc3rGwq9K138QLhvX0JNDFBSG7xFY2vGCJyfBBRSAJH0uZIwvtPUZZdGTSQFqepXcB5qel44w1u9cxm2LcELiT-qfBfSpMLMzjO3I48bRNO1nmQn&eid=0-itucqblq-3q
This email was sent to<EMAIL_ADDRESS>If you need assistance or have questions, please contact LinkedIn Customer Service: https://www.linkedin.com/e/v2?e=0-itucqblq-3q&a=customerServiceUrl&ek=invite_guest
© 2016 LinkedIn Corporation, 2029 Stierlin Court, Mountain View CA 94043. LinkedIn and the LinkedIn logo are registered trademarks of LinkedIn.

@matcheydj I think you just invited your entire contacts list to LinkedIn.

David Matchey would like to connect on LinkedIn. How would you like to respond?
Accept: https://www.linkedin.com/comm/start/accept-invitation?sharedKey=H5LrZNVs&invitationId=6188766520202584064&trk=eml-first_guest_reminder_01-hero-121-accept_text&trkEmail=eml-first_guest_reminder_01-hero-121-accept_text-null-noghnm~iu4ibqh6~os
View David Matchey's profile: https://www.linkedin.com/comm/start/accept-invitation?sharedKey=H5LrZNVs&invitationId=6188766520202584064&trk=eml-first_guest_reminder_01-hero-3-profile_text&trkEmail=eml-first_guest_reminder_01-hero-3-profile_text-null-noghnm~iu4ibqh6~os
You received an invitation to connect. LinkedIn will use your email address to make suggestions to our members in features like People You May Know. Unsubscribe here: https://www.linkedin.com/e/v2?e=noghnm-iu4ibqh6-os&t=lun&midToken=AQFmrFVhGEd36Q&ek=first_guest_reminder_01&li=123&m=unsub&ts=HTML&eid=noghnm-iu4ibqh6-os&loid=AQFcesX4CPxuYAAAAVexqWuIBPjpH8X7ur5fmFuh8mBILRF8JrX3C6ykHpqTRHjp3hc3gdigfZ-vhIsduD40DvEYdoXVUQ29iq8oreeX9i-ElSzHJcb1czM74vUPsWzoKH_bkpjG19Ox1Gj3yNSP1d6bKa5G83jxX8wmt9hqbz0yW_BqFC8bFbILlaN6p7_4rrew
This email was sent to<EMAIL_ADDRESS>If you need assistance or have questions, please contact LinkedIn Customer Service: https://www.linkedin.com/e/v2?e=noghnm-iu4ibqh6-os&a=customerServiceUrl&ek=first_guest_reminder_01
© 2016 LinkedIn Corporation, 2029 Stierlin Court, Mountain View CA 94043. LinkedIn and the LinkedIn logo are registered trademarks of LinkedIn.

Thanks for your report ! I merged #41 and there was a link to this - @fzbassman could you check that your problem is solved? Otherwise, please open another issue :), thanks !

I had a similar issue when I was making customizations to the defualt.xml  on a new branch. Once I pushed that branch to the remote repo worked as expected.


popup: How can I define a popup.html for the extension?

How can I use a popup react page and communicate with chrome messages with my inject script?

it has no relation with this repo :-) see doc of chrome, chrome.runtime.sendMessage things, I can not remember exactly.


Dynamic Header

Hello,
I don't really understand how to use dynamic headers. I am trying to integrate my headers for the table like this:

        {headers.map((header, i) => (

            {header}

        ))}

However, when I check the headers for small devices,  the first 2 headers are the only ones shown.
Thanks for your attention, I really like this project.

Hey @jdrag12. Would you mind sharing the snippet with https://codesandbox.io or similar? I'll see if I can help.

Sure Coston, thanks a lot.
Codesandbox URL: https://codesandbox.io/s/crazy-kare-nr79u
Issue: Only the first 2 headers are visible in small devices.

Ahh, I get it now. Your table starts with two headers, then you add more, and it doesn't update. Add something that changes with the headers as the Table key, like products.length.

Now, every time the products change, the header state will update.

Ok, that works. Thank you very much Coston.


Create Utility functions for tasks involving more than 3-4 steps

Create a utility function which helps to create high end components with ease.
Create the functions under Solaris class. createPage is an example

@SujalChoudhari can you please assign this issue to me

@harsh-2O
What all utility function are you planning to add?
Please provide a list of those.

Commit c6e4ae2:
With this commit, we have a createComponent method that effectively eliminates the need of using Atoms and Atomizer. Hence This task is partially solved.


Contact Custom field - Issue after type conversion from number to text

Describe the bug

after conversion of type from number to text field if we added text then it is not showing text value

https://www.berrycast.com/conversations/327e19d4-af58-5bde-933a-a895235be821

I believe this is fixed, but not moved


Incompatible with Device.BeginInvokeOnMainThread()?

In the README file you say:

Keep in mind that the plugin was not design to communicate with UI thread

However, I was wondering: what's the issue about calling to Device.BeginInvokeOnMainThread() at the end of the StartJob() method? Would that not work?
P.S.: great work on conceptualizing this lib btw!

Hi @knocte , Thank you
I think there is no need to wrap the StartJob method with BeginInvokeOnMainThread, what remember with BeginInvokeOnMainThread  method is,  it used to make the expression run on the UI thread.

there is no need to wrap the StartJob method with BeginInvokeOnMainThread

I never said to wrap the StartJob method with BeginInvokeOnMainThread, I said to call BeginInvokeOnMainThread inside the StartJob method, at the end, when you already have the results of your background execution.

@knocte there is no need to use BeginInvokeOnMainThread inside the StartJob you are trying to  make the expression run on the UI thread, StartJob supposed to be runned on the background thread.

But after the background thread has finished, there's a need to notify the UI thread to do stuff (otherwise what's the purpose of the background thread if not other than to have an effect on what the user sees at some point?).

Hi @knocte, that is the limitation i discussed in "Quirks and Limitation" section, The purpose of this plugin is to simplify the background execution per platform, just like how facebook ans twitter handle the aggregation in the background.
But If you want to dig deeper about advance Background Service per each platform you can check on this links below:
Android BackgroundServices LINK
iOS BackgroundServices LINK
Hope it helps.

Hi @knocte, that is the limitation i discussed in "Quirks and Limitation" section

I know, that's why I started this issue saying "In the README file you say:".
So this issue is to discuss why is there this limitation? can you elaborate on how this is a limitation? what happens if you just use BeginInvokeOnMainThread at the end of the StartJob method? does it crash? what do you exactly mean with it being a limitation?

Hi @knocte , the limitation being not able to communicate with UI Thread (so when using BeginInvokeOnMainThread  which would actually call RunOnUiThread method for Android and InvokeOnMainThread for iOS).


Add can_set_up_interviews? authorisation method

Context
We need a consistent way to check for permission to set up interviews.

Changes proposed in this pull request
Adds can_set_up_interviews? method to ProviderAuthorisation.

Guidance to review

Link to Trello card
https://trello.com/c/YJRz2no1/3904-update-providerauthorisation-service

Things to check

[x] This code does not rely on migrations in the same Pull Request
[x] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[x] API release notes have been updated if necessary
[x] Required environment variables have been updated added to the Azure KeyVault

Thanks @despo amended to accommodate support users https://github.com/DFE-Digital/apply-for-teacher-training/pull/5102/commits/878d6d651f5e31d9dca31ae426504bc1e5e7e0dc


[AIRFLOW-2267] Airflow DAG level access

Make sure you have checked all steps below.
JIRA

[x] My PR addresses the following Airflow JIRA issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-2267
In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a JIRA issue.

Description

[x] Here are some details about my PR, including screenshots of any UI changes:
Provide DAG level access for airflow.  The detail design could be found at https://docs.google.com/document/d/1qs26lE9kAuCY0Qa0ga-80EQ7d7m4s-590lhjtMBjmxw/edit#

Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:
Unit tests are added.

Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

[x] Passes git diff upstream/master -u -- "*.py" | flake8 --diff

hey @mistercrunch,  @jgao54 and everyone,  I have a MVP which I get it working on my local box for airflow DAG level access. I would like to get some early feedback and see if I miss anything.  I put up a small doc on the design(https://docs.google.com/document/d/1qs26lE9kAuCY0Qa0ga-80EQ7d7m4s-590lhjtMBjmxw/edit#)
Couples of todo:

code clean up.
flake8
provide filter for model view
unit tests

Here's an idea -- what if DAGs were namespaced, and you could grant permissions using glob patterns. Examples:
read_dag: *
read_dag: product_analytics.*
read_dag: procuct_analytics.tableau_daily_job
This maps well to administrator, group (team) access, and one-off access use cases.

It's planned already to have a perm to read all DAGs and another to write on all DAGs. We're thinking that many environment will have "read all dags" as part of their lower level of access.
DAGs are not namespaced at the moment and namespacing DAGs is out of scope for this PR/feature. If/when namespacing/tagging is introduced, related perms and logic can be created.
DAG number in organizations is usually in the 10s or hundreds, larger environments are probably low thousands. Technically this is not an issue for the perm-related models.
If we want to enable per-DAG access, we need to create a set of permissions per DAG, there's just no way around it.
It's also possible to generate roles programmatically if you wanted to have regex or a rule based approach.
We could, though I don't think it's necessary yet, allow the creation of special regex-DAG-perms.

Got it, I missed the "all_dags" keyword on my first read through.
I'm still wondering what the workflow would look like for a regular user who doesn't have read/write on all_dags -- after creating a DAG, would they have to ask the admin to give them permissions on it?

hey @mistercrunch  and @jgao54 , just FYI, I have modified the pr to include filter for non-dag view. Please take a look when you have the chance. Next I will add unit test, fix flake8, and add documentation.

Filter has been implemented.

Can you please add the handling of creating the perm on the refresh/ endpoint?

@feng-tao  just caught back up from vacation, will take a look at this next day or two!

I wanted to add important notes following a conversation with Tao.
So our security model currently lives in FAB, and trying to reference it in Airflow core (either through the FAB's model) or AirflowSecurityManager (build on top of FAB's SecurityManager) requires importing / instantiating the Flask app. We absolutely do not want this.
So there are two possible paths to avoid this dependency:

One is to say that access control lives on the web server and anything that needs access control would be done through REST. That means that if we want access control in the CLI (and we do!), we would have to re-write the CLI to go through the REST api. We clearly want to do this at some point anyway.

Promote the access control as an Airflow-core concept. This requires refactoring access control logic out of www_rbac and into the core of Airflow itself. To do this, could "stub" the security models from FAB into airflow/models.py, meaning we can access permission information without loading up the Flask App. I'm a bit confused as I couldn't find the rbac-related migrations in the repo. This also means refactoring things that are now in AirflowSecurityManager as a construct that does not depend on FAB's SecurityManager.

cc @jgao54 , but @mistercrunch  I think currently the RBAC UI directly reference RBAC models(https://github.com/apache/incubator-airflow/blob/master/airflow/www_rbac/security.py)

@mistercrunch not sure if i interpreted your comment correctly, since the security models are class attributes in SecurityManager, technically we could just do the following without instantiating the security manager:
from airflow.www_rbac.security import AirflowSecurityManager
user_model = SecurityManager.user_model

Overall, I think the direction of this PR is good. Thanks for cleaning up the security.py and making it more OOP. My only concern is just the hardcoding of the role names (it's my bad though, I did this when I first created security.py)
I liked the idea of introducing namespace which @gsilk mentioned, especially given kubernetes has the concept of namespaces so it could potentially work nicely with the kubernetes executor. (but  yes, out of scope for this pr)

hey @jgao54 , sorry for delay in reply.  Thanks for the review. I still have some issues with fixing the existing tests. Will get to it in the next week. Couples of questions based on your comment though:

For this pr, I think we should do the sync_to_db for role only on the webserver side. If we do it on the scheduler side, we need to pull all the models file from FAB into airflow core(cc @mistercrunch ).
Do you think we should have db-migration script for FAB related tables?
For travis CI, it complains about ab_permission_view_role table can't be found for the test_views test. This table is from FAB. I wonder have you experiences and have any idea of why the table can't be found?

PS: I really need to finish this pr, otherwise I keep getting merge conflict :(

Hey @feng-tao, I saw your comment in #3319.  I have seen the Add Permission to Role Error in the past but haven't gotten to to the bottom of it. My understanding is that the security manager is trying to add many dupes of (perm, view_menu). First db write works but for each dupe it would violate the integrity error and return None (and logs the Creation of Permission View Error error but doesn't throw an exception), then it attempts to add the pvm to the role (which is None, so it fails with Add Permission to Role Error).
FYI, this code is in FAB' security manager class, specifically, in the add_permissions_view method:
            for permission in base_permissions:
                pv = self.add_permission_view_menu(permission, view_menu)
                role_admin = self.find_role(self.auth_role_admin)
                self.add_permission_role(role_admin, pv)

It's not a blocker or anything, but still worth investigating. I'll try to take some time next week to dig a bit further.
In terms of the unit test failure, it's a slightly different issue: OperationalError: (sqlite3.OperationalError) no such table: ab_permission_view_role. I suspect the db session object in the unit test doesn't see the FAB-generated tables exist (since we use scoped session). Although this could be fixed in unit test (I haven't taken too close of a look yet), I am suspecting maybe this is comes down to the way I've set up in app.py:
db = SQLA(app)
...
appbuilder = AppBuilder(app, db.session, ...)

May make more sense to do:
from settings import Session
appbuilder = AppBuilder(app,  Session, ...)

Getting back to your questions:

if i understood correctly, this would mean that the roles are synced only upon (1) starting the webserver (2) when airflow sync_perm is called. Otherwise they stay stale. Is that correct? If so, this may be confusing since the scheduler will sync the DAG file but doesn't sync its custom permissions.

That's a good question! The migration code is currently in airflow initdb, which is an idempotent call, but is only used when first setting up airflow.  Perhaps it's more intuitive to add it in airflow upgradedb instead (which initdb calls anyways). Alternatively, we can add them as part of the migration script, The reason I initially didn't go down this path was because FAB itself lazily creates the tables when the application starts. This could become problematic in the future if our models diverge from FAB models, so perhaps its something we want to disable... and use db migration only. I think this is another reason to manager security models in airflow core rather than FAB.

As discussed in my previous comment. I'll budget some times next week to investigate into the db session side of things as well.

Another thing I've just come to realize is that this PR doesn't yet support parsing access-control in the DAG file.
For example:
dag = DAG('mydag', access_control={`role`: [ 'custom_role1'] }, ...)
In my head I thought it did because it was in the original proposal, so you can ignore my comment on:

If so, this may be confusing since the scheduler will sync the DAG file but doesn't sync its custom permissions.

I think this would be a helpful feature since it makes dag-level access control more manageable, but can wait for another pr :)

thanks Joy @jgao54 , I wasn't aware of the requirement of doesn't yet support parsing access-control in the DAG file.. I will create a follow up jira and implement in a different pr once this pr is checked in. Thanks for the info.

I Would like to help in completing this feature if any help is required .. I could not see any docs for it would you need help for it ?

hey @gauthiermartin , thanks for the help. I put up a doc at https://docs.google.com/document/d/1qs26lE9kAuCY0Qa0ga-80EQ7d7m4s-590lhjtMBjmxw/edit# initially.  I think this pr is almost done and ready for review(needs couples of more tests and doc). But I will create a couple of follow up tickets after this pr is done.  Feel free to discuss/take those  :)

@feng-tao Alright, Thank you for the docs. Best place to check for those new ticket is Apache JIRA right ?

@feng-tao If you dont mind I would like to leave some question into the google docs ... those will clearly help my understranding and might also help for the actual doc

hey @gauthiermartin , feel free to put the comment in the doc.

hey @jgao54 @mistercrunch , I updated the pr with all the related DAG level tests(and fix all/most the existing tests) . I add a small node in updating.md as well for the feature. It is in final shape for review. Could you pl take a look when you have the chance?
Two features are in scope but will do in later once this pr is checkedin:

Create role modelView
Support for DAG class which could create/sync new permissions.

@feng-tao  Ok . I guess i will only ask one question that seem still unclear to me.  In your google docs you mention that admin could create a new role to allow read/write access on a set of dag. Is there a feature that allows you to group dag in a set and then use the group to filter them ? I see that we can set filter all_dag and by dag_id which means we need to select each individual dag an add it to role permissions ?

@gauthiermartin currently not. The fab security model doesn't have the concept of 'group', so users are directly mapped to roles. It's possible to create our own abstraction layers later on, but is out of scope for this pr.

hey @jgao54 , @gauthiermartin , maybe we could add a cli command to allow admin to add dag with prefix/regex and assign to certain role? I could do it in a later pr if we think this is useful.

@jgao54 Ok. I see. I think it could be a useful feature to be able to handle 'group' authorization/rights onto a defined set of DAGs. I would definitely be interested in this feature

@feng-tao I think we should wait for another pr and brainstorm on the concepts and figure out the best way to do this.

@gauthiermartin I'd recommend adding the group feature directly in FAB. I think the proper, backward compatible design is to add a relationship (many-to-many) between roles and groups, and adapt the SecurityManager class to reflect that.

the jenkins is running at https://github.com/feng-tao/incubator-airflow/pull/7

hey @jgao54 , @mistercrunch , I create the following jiras as follow ups for this pr:
https://issues.apache.org/jira/browse/AIRFLOW-2694 #Allow parsing access control in DAG file
https://issues.apache.org/jira/browse/AIRFLOW-2693 # Implement sync_perm model view endpoint
https://issues.apache.org/jira/browse/AIRFLOW-2695 # Support assign groups of dag permission to a role

The jenkins test pass for most ORM. And FYI, I disable 2,3 tests which are pretty flaky(sometimes pass, sometimes fail).

Codecov Report

Merging #3197 into master will decrease coverage by 59.01%.
The diff coverage is 1%.

@@             Coverage Diff             @@
##           master    #3197       +/-   ##
===========================================
- Coverage   76.83%   17.81%   -59.02%
===========================================
  Files         204      205        +1
  Lines       15485    15489        +4
===========================================
- Hits        11898     2760     -9138
- Misses       3587    12729     +9142

Impacted Files
Coverage Δ

airflow/settings.py
75.42% <ø> (-5.09%)
:arrow_down:

airflow/utils/db.py
15.07% <ø> (-18.26%)
:arrow_down:

airflow/www_rbac/decorators.py
0% <0%> (-66.67%)
:arrow_down:

airflow/www_rbac/filters.py
0% <0%> (ø)

airflow/www/views.py
0% <0%> (-68.95%)
:arrow_down:

airflow/www_rbac/security.py
0% <0%> (-95.13%)
:arrow_down:

airflow/www_rbac/views.py
0% <0%> (-71.58%)
:arrow_down:

airflow/bin/cli.py
14.7% <11.11%> (-49.38%)
:arrow_down:

airflow/www_rbac/app.py
20.93% <22.22%> (-79.07%)
:arrow_down:

airflow/www_rbac/validators.py
0% <0%> (-100%)
:arrow_down:

... and 168 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89c1f53...504c1ab. Read the comment docs.

@feng-tao, @jgao54 , @mistercrunch  I would be intrested into helping for the follow up features of this pull request . Is their anyway i can join you guys into it ?

@feng-tao -59.01% coverage in the Codecov report above is pretty concerning. I'm surprise that removing a few tests would ever contribute to dropping coverage that bad.

@mistercrunch , I think I just turned off the following two tests:
test_mark_success_no_kill` (not run for mysql) and test_change_state_for_tis_without_dagrun
And for my pr(1300+) line, I think 500 line ~ 600 line are test. I doubt it could drop the project coverage by 59%. If I would guess, I modify the app.py interface to add session as input argument for better testing purpose which triggers something non test code...
Looking at the coverage report(https://codecov.io/gh/apache/incubator-airflow/commit/f0b4d6c0ea22214c9c2396d03153317cd082017f), I am not sure if it is correct(hash code is the same as my commit, and it shows www_rbac/views.py coverage is 0...)

hey @mistercrunch , I do a local code coverage for this pr on my local repo which shows 77% coverage(https://codecov.io/gh/feng-tao/incubator-airflow/pull/7).

hey @mistercrunch , I trigger another code coverage report(https://codecov.io/gh/feng-tao/incubator-airflow/pull/9/diff) on the pull request in my local repo which shows coverage is 77%.

PTAL @mistercrunch @jgao54

LGTM

This puts the DAG level access in the 1.10 section of UPDATING.md - could you move it to the master section please? :)

hey @gauthiermartin , just want to check with you and see if you want to contributing the remaining features for this part(e.g group filtering etc)

@kaxil , could we add this change including https://github.com/apache/incubator-airflow/pull/4305 to v10.2? Or v10.2 is for minor patch only?

@feng-tao I be might be interested in contributing the features. Do any brainstorm or diagram have been done on how and where those changes would be implemented ?

@feng-tao This is a big change, not sure if we should include in 1.10.2. Also, it would have transitive dependencies and resolving can be a nightmare. However, I don't have a strong reservation against it, so give it a try on cherry-pick this on v1.10-test branch (may be on your fork).


Repeatedly prompted for the purchase in react-native-iap IOS. No callback on the listener

Please use the Discussion board if you want to get some help. Please use issues to report bugs.

Description
I am facing an issue while integrating react-native-iap on iOS. I am able to fetch the products I created on app store connect.
The purchase popup appears after clicking on the purchase button and entering my Apple credentials. However, after a successful payment, there is no callback on the listener. After that, I'm repeatedly prompted for the purchase, regardless of how many times I enter my password. And if I cancel the payment, I get a proper response on my currentPurchaseError state.

Expected Behavior
For purchase to complete (either fail or pass). And receive a callback from the listener. If not at least it should not prompt for payment again.

Screenshots

Environment:

"react": "17.0.2"
"react-native": "0.66.5"
"react-native-iap": "^12.12.1"
Platforms (iOS, simulator, device):

To Reproduce
Below is the code for my PurchaseScreenIOS screen

I have selected for In-App Purchase in Xcode and created products on apple app store connect.

[Optional] Additional Context

Steps to resolve.

use a physical device for testing
requestPurchase({sku: id})
.then(async data => {
console.log("Purchase was completed");
})
.catch(err => {
console.log("Purchase was not completed");
});
No need for listeners
Use "react-native-iap": "^12.10.7"

Hello @aabhiitatva, I have the same issue here, but I don't have access to a physical device, only an emulator.
Do you know if this issue is strictly related to the emulator? I've followed the steps you describe to resolve but the problem persists.


Documentation error? WinMR vertical touchpad/joystick direction mismatch with Unity docs

See the bottom of the Unity docs page:
https://docs.unity3d.com/Manual/Windows-Mixed-Reality-Input.html
It states that the positive direction for vertical axis is up, however on the WinMR page (link below) the info is reversed (positive is down). Could someone double check and fix whichever is the case? I am testing this on oculus and trying my best to reach WinMR devs because I'm fixing up my VR input wrapper causing bugs in my cross platform games...
link to WinMR input page https://docs.microsoft.com/en-gb/windows/mixed-reality/gestures-and-motion-controllers-in-unity
[Enter feedback here]

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1e7991d3-d96c-3695-c2e6-8abed3de51b2
Version Independent ID: b8f20855-b2c4-dc12-34d7-5f0795cfb78b
Content: Gestures and motion controllers in Unity - Mixed Reality
Content Source: mixed-reality-docs/gestures-and-motion-controllers-in-unity.md
Product: mixed-reality
GitHub Login: @thetuvix
Microsoft Alias: alexturn

On the WinMR input page this is called out in the note at the bottom of the table....

I did not understand this inversion from the note. Yes, axis IDs differ, and while taking that into account the axis UP is still reversed compared to the Vive (or so the theory goes, until I can confirm myself with a test)
But thanks for the note! I will try to remember to update this post in February when I get my hands on WinMR and Vive again.


[FOR DISCUSSION ONLY] Fix rubocop violations

What do people think about Rubocop?
I'm in favour of getting it into our build process in order to enforce a consistent coding style. I care less about which particular style we use, and more about the consistency.
This branch demonstrates how we can update Rubocop, automatically generate some config files and then start to fix violations of the Ruby Style Guide.
We can get it into our build process fairly easily by using the .rubocop_todo.yml file, as that disables all the rules we're in violation of. As we go through and remove violations we can regenerate the .rubocop_todo.yml file which will ensure that future violations of the same rule will raise an error.
What do y'all think?

I think this would be a good idea. It'll be a bit of a challenge making sure we keep ratcheting up the number of checks we're doing, but as soon as we have a few checks, it will mean we can't make things worse. Consistency is definitely a worthwhile goal in terms of making the app more maintainable - there is a lot of inconsistency in the app at the moment.

I have rubocop integrated with my editor already and always use it on greenfield projects. I wouldn't mind agreeing on a styleguide and following it eg by updating the file to match the styleguide before you make any changes to it. Having to do that would a bit of a distraction from the actual problem though. It's also distracting when a CI build fails because of it.
All in all, I think it's a good tool devs can use, but perhaps we shouldn't be enforcing it?
Also, there is this https://github.com/alphagov/styleguides/blob/master/using-rubocop.md

All in all, I think it's a good tool devs can use, but perhaps we shouldn't be enforcing it?

I think we probably have to enforce it for it to become useful. If it's not enforced then I can imagine a situation where in a given team of people, only a subset of them care enough to use the tool and fix any violations.

Also, there is this https://github.com/alphagov/styleguides/blob/master/using-rubocop.md

Awesome. I hadn't seen that before and it looks like it contains useful information.

I'm going to close this for now. I'll look at the styleguide page @tadast linked to and decide what to do with this.


PropertiesToInclude update generates a SqlException: Incorrect syntax near ';'.

I am trying to use BulkUpdate to update a single field of a table.
The entities are created with just the primary key and the field to update set.
var entitiesToUpdate = new List<Entity>();
entitiesToUpdate.Add(new Entity { PrimaryKey = keyValue, FieldToUpdate = updateValue });

This is the configuration used:
var bulkConfig = new BulkConfig { PropertiesToInclude = new List<string> { "FieldToUpdate" } };
context.BulkUpdate(entitiesToUpdate, bulkConfig);

I expect this to update the entities by matching using the primary key PrimaryKey, and only updating the FieldToUpdate field.
Instead it throws a SQLException Incorrect syntax near ';'.
The generated SQL is:
MERGE [Schema].[EntityTable] WITH (HOLDLOCK) AS T USING [Schema].[EntityTableTempf1703585] AS S ON T.[PrimaryKey] = S.[PrimaryKey];
Looking at the TableInfo class LoadData<T>, it seems like PropertiesToInclude is ignored if UpdateByProperties is not true, but I am not sure why this is. As far as I can tell from the documentation UpdateByProperties is used to specify an alternate set of properties to use for matching the record to update, instead of the primary key. I do not see why we would need to set  UpdateByProperties to use PropertiesToInclude.
The invalid SQL is generated in SqlQueryBuilder.MergeTable as none of the if statements evaluate to true, in particular the OperationType.Update statement which relies on having at least one property to update.
I am happy to submit a PR to fix this but i'm not sure what the intention was with the coupling requirement of PropertiesToInclude and UpdateByProperties.

I updated to 3.3.7 and got the same exception.

I have just made a Test and it passes:
public class Entity
{
	public int EntityId { get; set; }

	public string FieldToUpdate { get; set; }
}

//----

public DbSet<Entity> Entities { get; set; }

private void RunUpdateToInclude(bool isBulkOperation)
{
	var entitiesToUpdate = new List<Entity>();
	entitiesToUpdate.Add(new Entity() { FieldToUpdate = "xx" });
	entitiesToUpdate.Add(new Entity() { FieldToUpdate = "yy" });

	using (var context = new TestContext(ContextUtil.GetOptions()))
	{
		if (context.Entities.Count() == 0)
		{
			context.Entities.AddRange(entitiesToUpdate);
			context.SaveChanges();
		}
	}

	entitiesToUpdate[0].FieldToUpdate = "xx2";
	using (var context = new TestContext(ContextUtil.GetOptions()))
	{
		var bulkConfig = new BulkConfig { PropertiesToInclude = new List<string> { nameof(Entity.FieldToUpdate) } };
		context.BulkUpdate(entitiesToUpdate, bulkConfig);
	}
}

Ok I worked out the issue.. I was passing the database field name into the PropertiesToInclude list, but the case differs between the database and the entity. When I pass the actual Property name using nameof, it works.
I would like to submit a PR to give a clearer error message rather than generating invalid SQL, do you think it is better to throw an exception if any of the passed in properties don't exist on the entity, or throw an exception if there are not enough fields to produce a valid merge statement?

I am doing some refactoring now so I have just added this validation, thx for suggestion.
From now on exception is always thrown is any of Properties is not correct.


Clean EIA 860 and 923 FGD operation and maintenance data

Overview
Closes #3392 and #3394.
What problem does this address?
Cleans 923 FGD Operation and Maintenance data and 860 FGD Equipment data for preparation for harvesting.
What did you change?

Drop values with plant and control id values of NA.
Replace . values with NA.
Convert dollars to thousands of dollars.
Fix datetimes for SO2 test dates.
Ensure a unique primary key and drop some duplicated rows.
Write asset checks to check for continuity, null columns, and cost totals equaling their components

Still to do:

[x] Resolve merge conflicts with main
[x] Add all fields to PUDL metadata and encode them (uncomment existing lines).
[x] Update coding tables to actually encode the relevant columns
[x] Fix asset checks for fast ETL
[x] Add fields for 860 records, add io manager and write _core table to DB
[x] Write remaining tests for 860
[x] Update alembic migrations
[x] Why aren't encoding tables encoding?
[x] After PR reviewed, redo alembic migrations to only have one
[ ] Deal with unit suffixes for proportions
[ ] Fix docs build

Questions for reviewer:
We're dealing with pct inconsistently in PUDL. I'm standardizing to 0-1 scale, instead of 0-100. What "unit" suffix makes most sense here? _rate, _ratio, _proportion, etc.?
Testing
How did you make sure this worked? How can a reviewer verify this?
Materialize _core_eia923_fgd_operation_maintenance and _core_eia860_fgd_equipment
# To-do list
- [ ] Ensure docs build, unit & integration tests, and test coverage pass locally with `make pytest-coverage` (otherwise the merge queue may reject your PR)
- [x] Review the PR yourself and call out any questions or issues you have
- [x] Update release notes

That docs build error looks like the error I fixed with my own docs changes - I can take a look to debug before taking a deeper look in the actual review.

@e-belfer It looks like there were significant decreases in test coverage for pudl.transform.eia923 and pudl.transform.eia860 based on the CodeCov report. Is this expected?  It seems like maybe some of the new functions aren't actually getting called?

Well, we know that the asset checks are actually running, because a failed check can fail the integration tests. But, for some reason codecov isn't actually marking them as covered...

but if that turns out to be some deep rabbit-hole we can mark the asset checks as #pragma: no cover and sort out the issue later.

This has indeed turned out to be a rabbit hole. I'm going to write up a new issue to keep track of some asset check improvements including this one, and pragma: no cover the asset checks for now.


New getting started not working with companion enabled

This is happening on https://dev.js.ipfs.io/

Also, it seems that the code block could take more horizontal space in lower resolutions.

After investigating, the issue only happens if IPFS companion is enabled. Disabling it works.

This should be just using IPFS and not window.ipfs.


Nx test fails after creation of stencil library

After creating a new empty nx workspace and creating a stencil library (nx g @nxext/stencil:lib my-lib), jest throws the following error.
$ nx run my-lib:test --verbose

>

> nx run my-lib:test --verbose
[47:28.6]  testing spec  #files
[47:28.6]  jest args: --projectType=library --tsConfig=libs/my-lib/tsconfig.lib.json
           --configPath=libs/my-lib/stencil.config.ts --outputPath=dist/libs/my-lib --spec --max-workers=8

[ ERROR ]  runJest: TypeError: Class extends value #<Object> is not a constructor or null

Test Suites: 0 of 2 total
Tests:       0 total
Snapshots:   0 total
Time:        0 s
———————————————————————————————————————————————

>  NX   ERROR  Running target "my-lib:test" failed

  Failed tasks:

  - my-lib:test

  Hint: run the command with --verbose for more details.

here is the package.json
package.txt

I also had this problem when migrating from NX11 to NX12. The cause was incompatible Jest dependencies. After all Jest dependencies were compatible with each other, it worked again. The only pain point is the non-migrated version of the plugin. I can only run it in version 11. All other NX plugins are version 12 :-( In my opinion, this is because: NX 12 brings Jest with version 27. Jest 27 does not yet work with StencilJS, see https://github.com/ionic-team/stencil/ issues / 2942 or https://github.com/ionic-team/stencil/issues/2922.
If anyone disagrees or has additional information, please share

The main problem here is definitely the jest version. Something I try to override but unfortunately Nx does set the version of jest to 27. I wait for the stencil fix here eagerly

Using NX11 does work. Thank you Chris for linking to the issue in stencil-js. Guess I'll wait with the migration to 12 until they fixed the issue

Today Stencil 2.13 came out with support for jest 27


Allow CosmosDbTrigger connection to be specified in named ConnectionString

At the moment, it appears that the only choice for setting the connection string is to give the name of a top-level app setting (inside Values collection in local.settings.json).
It would be very useful if there were a setting to say that the connection string values are stored within the "ConnectionStrings" section.
(It does appear that there might be a way to use a specific "CosmosDb" named value in "ConnectionsStrings" but it looks like it has now been removed - and besides, I am unsure as to the relationship between these dotnet isolated functions extensions and the existing webjob extensions)

@Morreed Interesting, thought a bit weird. I'd be concerned that an update could break that.
For the moment I have just duplicated the Connection String in the Values collection in local.settings.json and my ARM deployment.

Hierarchical configuration settings are supported and you do have support for configuration sections.
In addition to the local.settings.json, you could have a JSON configuration source with the hierarchy you want (including a connection strings section), as long as the reference you have in the attribute matches that hierarchy (like you have in the example above).
I hope that helps, but let us know if you need an example here.

@fabiocav Thanks for the reply!
What I have is a shared piece of startup code which loads my Cosmos ConnectionString like this:
configuration.GetConnectionString("CosmosDb");
So my appsettings.json has
"ConnectionStrings": {
    "CosmosDb": "<etc>"
}

In my functions app startup, I actually am adding a JSON source to the HostBuilder (and deploy this file with my Functions into Azure):
var host = new HostBuilder()
     .ConfigureFunctionsWorkerDefault( ... )
     .ConfigureAppConfiguration((context, builder) =>
          {
                builder..AddJsonFile(Path.Combine(context.HostingEnvironment.ContentRootPath, "appsettings.json"));
          })
      . // snip
      .Build();

and I can use Cosmos within my code no matter if it is a Functions project.
But then I come to add a CosmosDbTrigger and I cannot re-use that app settings value I have with the connection string.  I can just about get on board with having to add it to local.settings.json for local debug (but it would be nice not to have to) - but I really don't want to have to go back and restructure my appsettings and startup logic just because the CosmosDbTrigger requires the setting in a specific place.
Unless you can enlighten me and tell me what I should be putting in the ConnectionStringSetting which will work with my existing configuration?

@andrew-tevent for the OOP model, this wouldn't be recommended or work as expected. The recommended approach would be to define that in app settings (which could continue to follow the hierarchy you have defined above) and would be automatically picked up by the host.
That also keeps secrets out of configuration files.
Would that approach work for you?

@fabiocav Can you expand on what you mean?  I am defining it in app settings.

That also keeps secrets out of configuration files.

I handle my secrets with ARM Templates / KeyVault at deploy-time.

@andrew-tevent can you clarify what ConnectionStrings section you're referring to? Is that what is in the portal?

@fabiocav I'm talking about these - configured in appSettings.json

Which are accessible using IConfiguration:

Which can then be overridden in ARM Templates:

(Which also then appear in the Azure Portal:)

My previous comment applies, but only for input and output bindings. Setting that from a file configuration source for triggers has limitations.
Setting those using App Settings and Key Vault references is the recommended approach.

Related question for @fabiocav
Is it possible to reference the app configuration service settings via the Input Bindings and Triggers?
I tried doing that and expected to have the functions execute correctly - but instead they failed to start with exception
" A host error has occurred during startup operation 'aabc18d9-dc39-4f13-81cd-04388f44269e'.
[2021-12-08T16:09:33.499Z] Microsoft.Azure.WebJobs.ServiceBus: Microsoft Azure WebJobs SDK ServiceBus connection string 'ServiceBusV2-ConnectionString' is missing or empty."
PS: running .NET 6 isolated function app with app configuration service integration via managed user identity
Should I open another issue?


How to avoid abuse of RAM by evil contract account?

Basically when an action is executed, we can add notifier by calling require_recipient. It's useful for linking actions from different contracts to work as a whole. But it also introduces new security problems. If the recipient itself is a contract, then the recipient's  action handler can consume RAM on behalf of the original action. This may not be the expected result of original action. Following snippet shows that require_authorization only checks the authorization against the current action.
How to solve this problem?
void apply_context::update_db_usage( const account_name& payer, int64_t delta ) {
   if( delta > 0 ) {
      if( !(privileged || payer == account_name(receiver)) ) {
         require_authorization( payer );
      }
   }
   trx_context.add_ram_usage(payer, delta);
}

void apply_context::require_authorization( const account_name& account ) {
   for( uint32_t i=0; i < act.authorization.size(); i++ ) {
     if( act.authorization[i].actor == account ) {
        used_authorizations[i] = true;
        return;
     }
   }
   EOS_ASSERT( false, missing_auth_exception, "missing authority of ${account}", ("account",account));
}

Contracts delegating action processing to other contracts have a trust relationship with the other contracts.  To prevent unexpected RAM consumption, the best way is to control all of the relevant accounts and contracts.  A less attractive but possibly effective way is to only delegate to verified open source contracts that have been frozen by dropping ownership permissions.
There have been discussions about how to provide relative certainty that you can delegate to an arbitrary contract and still be assured there will be no RAM consumption.  Code has not yet been written and there is no schedule. Watch future release notes.


New action request: actions-rs/clippy-check

Action name
uses: actions-rs/clippy-check
Reasons
actions-rs/clippy-check

Intended usage
actions-rs/clippy-check

I have checked the internal marketplace for similar actions and couldn't find one that works for us.

[X] I have checked the internal marketplace first

:robot: Found these results:

Check
Results
Links

CodeQL on the forked repo
:white_check_mark:
CodeQL run

Security scan:

Check
Result

No Dependabot configuration found
⛔

No CodeQL Init found
⛔

No CodeQL Analyze found
⛔

:robot: Found these results:

Check
Results
Links

CodeQL on the forked repo
:white_check_mark:
CodeQL run

Security scan:

Check
Result

No Dependabot configuration found
⛔

No CodeQL Init found
⛔

No CodeQL Analyze found
⛔

:robot: Check completed with result: ⚠
Found 26 Dependabot security vulnerabilities:
14 where high and 12 where moderate.
Use this link to verify the alerts.


libx86emu: 1.14 -> 2.0

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/libx86emu/versions.
meta.description for libx86emu is: '"x86 emulation library"'.
Compare changes on GitHub

Checks done (click to expand)

built on NixOS

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 2.0 with grep in /nix/store/9984lh9g0h5lzm4swbq31gmvrmw40ar9-libx86emu-2.0

directory tree listing: https://gist.github.com/c671522eae3e27af73c26db93ca49266

du listing: https://gist.github.com/3d6a1756877eb14c1f41de89533d3a66

Test this build with Cachix (click to expand)

One time setup in nixpkgs Git checkout:
cachix use r-ryantm
git remote add r-ryantm https://github.com/r-ryantm/nixpkgs.git

Test this build:
git fetch r-ryantm && git checkout 02f5daa167df4c6d8e4e24b743ea007aca54a48d && nix-shell --pure -I nixpkgs=. -p libx86emu

cc @bobvanderlinden for testing.

Success on x86_64-linux (full log)
Attempted: libx86emu
Partial log (click to expand)
ln -snf libx86emu.so.2 /nix/store/9984lh9g0h5lzm4swbq31gmvrmw40ar9-libx86emu-2.0/lib/libx86emu.so
install -m 644 -D include/x86emu.h /nix/store/9984lh9g0h5lzm4swbq31gmvrmw40ar9-libx86emu-2.0//include/x86emu.h
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/9984lh9g0h5lzm4swbq31gmvrmw40ar9-libx86emu-2.0
shrinking /nix/store/9984lh9g0h5lzm4swbq31gmvrmw40ar9-libx86emu-2.0/lib/libx86emu.so.2.0
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9984lh9g0h5lzm4swbq31gmvrmw40ar9-libx86emu-2.0/lib
patching script interpreter paths in /nix/store/9984lh9g0h5lzm4swbq31gmvrmw40ar9-libx86emu-2.0
checking for references to /build in /nix/store/9984lh9g0h5lzm4swbq31gmvrmw40ar9-libx86emu-2.0...
/nix/store/9984lh9g0h5lzm4swbq31gmvrmw40ar9-libx86emu-2.0

Success on aarch64-linux (full log)
Attempted: libx86emu
Partial log (click to expand)
ln -snf libx86emu.so.2 /nix/store/q1rvhijac6fq5ibvp4589dabf9s3lx81-libx86emu-2.0/lib/libx86emu.so
install -m 644 -D include/x86emu.h /nix/store/q1rvhijac6fq5ibvp4589dabf9s3lx81-libx86emu-2.0//include/x86emu.h
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/q1rvhijac6fq5ibvp4589dabf9s3lx81-libx86emu-2.0
shrinking /nix/store/q1rvhijac6fq5ibvp4589dabf9s3lx81-libx86emu-2.0/lib/libx86emu.so.2.0
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/q1rvhijac6fq5ibvp4589dabf9s3lx81-libx86emu-2.0/lib
patching script interpreter paths in /nix/store/q1rvhijac6fq5ibvp4589dabf9s3lx81-libx86emu-2.0
checking for references to /build in /nix/store/q1rvhijac6fq5ibvp4589dabf9s3lx81-libx86emu-2.0...
/nix/store/q1rvhijac6fq5ibvp4589dabf9s3lx81-libx86emu-2.0

hwinfo, for which I packaged this library, still works well with this change. So :+1:

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: libx86emu
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


BUG: Unhandled exception during task queue run loop.

2016-04-11 21:02 CRITICAL task_queue                    BUG: Unhandled exception during task queue run loop.
Traceback (most recent call last):
File "/usr/local/lib/python2.7/dist-packages/flexget/task_queue.py", line 47, in run
self.current_task.execute()
File "/usr/local/lib/python2.7/dist-packages/flexget/task.py", line 69, in wrapper
return func(self, *args, **kw)
File "/usr/local/lib/python2.7/dist-packages/flexget/task.py", line 579, in execute
self._execute()
File "/usr/local/lib/python2.7/dist-packages/flexget/task.py", line 545, in _execute
self.__run_task_phase(phase)
File "/usr/local/lib/python2.7/dist-packages/flexget/task.py", line 409, in __run_task_phase
if phase == 'input' and response:
File "/usr/local/lib/python2.7/dist-packages/flexget/plugins/list/trakt_list.py", line 91, in len
return len(self.items)
File "/usr/local/lib/python2.7/dist-packages/flexget/plugins/list/trakt_list.py", line 140, in items
raise plugin.PluginError('Could not retrieve list from trakt (%s)' % e.args[0])
PluginError: Could not retrieve list from trakt (HTTPSConnectionPool(host='api-v2launch.trakt.tv', port=443): Read timed out. (read timeout=30))

You got a timeout from trakt. This shouldn't crash the task, did it?

That was exactly my question.

hmm, let me rephrase.
Did it crash flexget?

How do I know?
I found that line in the log and that traceback in a crash file.

if the log didn't stop there, flexget didn't crash.
maybe a crash report for something like a timeout is too severe, perhaps it'll be better just to log an error

The log didn't stop.

This is definitely a bug and should be handled. We shouldn't be having tracebacks in normal operation.


Update versions of VS and Roslyn 2.0.0 dependencies

VS has gone RTM so, updating to the RTM versions of those dependencies.
Roslyn does not publish our shim packages on NuGet.org, so updating those
to a non-ancient version for projects that use 2.0.0. The projects that
use 1.3.x are staying put for now.
The code change is dealing with something that was obsoleted.

FYI only


✨ Record video from frame processor

What feature or enhancement are you suggesting?
Forgive me if this already exists but I have not found any information about it.
When I try to record a video with a frame processor the video that is recorded is directly the output of the camera not the processed video.
What Platforms whould this feature/enhancement affect?
iOS, Android
Alternatives/Workarounds
I could not find
Additional information

[X] I agree to follow this project's Code of Conduct
[X] I searched for similar feature requests in this repository and found none.

When I try to record a video with a frame processor the video that is recorded is directly the output of the camera not the processed video.

Hey- what is a processed video?

Ah you mean a Skia Frame Processor? No, this is currently not possible. This limitation is documented in the docs.
It's very very very very hard to build this, and I currently don't have the time to do so.


[Backport to main] tune error message for no ML node case

Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #780 (29df28c) into main (56cdb85) will decrease coverage by 0.33%.
The diff coverage is 0.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##               main     #780      +/-   ##
============================================
- Coverage     84.17%   83.85%   -0.33%
+ Complexity     1039     1035       -4
============================================
  Files            99       99
  Lines          3740     3740
  Branches        344      344
============================================
- Hits           3148     3136      -12
- Misses          445      456      +11
- Partials        147      148       +1

Flag
Coverage Δ

ml-commons
83.85% <0.00%> (-0.33%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

.../java/org/opensearch/ml/task/MLTaskDispatcher.java
32.94% <0.00%> (ø)

.../cluster/MLCommonsClusterManagerEventListener.java
65.62% <0.00%> (-12.50%)
:arrow_down:

...ain/java/org/opensearch/ml/task/MLTaskManager.java
61.92% <0.00%> (-4.07%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


github: *.nix files have no syntax highlighting anymore

I'm sure it worked less than 24h ago. Perhaps it's just a temporary problem?

stdenv.mkDerivation {
  name = "foo";
}

Might be: https://github.com/github/linguist/commit/aa6b88197123926c26b16a6a17ea5846b3917fc9

Aha see https://github.com/github/linguist/commit/07096f84f5a2cd96efbb39995405442fea178d48

https://github.com/github/linguist/issues/2885

Their platform sucks so much even they are unable to use it correctly so that maintainers would get an email notification in time.

This is thankfully resolved :smile:


\usetikzlibrary should have same highlighting as \usepackage for multiple libraries

The command \usetikzlibrary only highlights the first item on a list, but the expected behavior should be to color the same way as RequirePackage or usepackage

Should be enough to replace curly_group_text with curly_group_text_list in https://github.com/latex-lsp/tree-sitter-latex/blob/cd75e362a17c22ed90bcbdbaa78c2c7519ceb094/grammar.js#L996, right?

It is now working as intended :)


Can we use Context API in server side Rendering?

I noticed that nuget package is not containing the react 16.3. By when can we expect the latest version of react integrated with the nuget package and use context API.

This is available in 4.0.0-beta5

@dustinsoftware How can we use this when rendering components but not one single app component ?


Switch to print css file before downloading pdf

Hi there
Is there a way to swap out the webpage's css file to the media @print css file before saving the PDF?
Could work better for PDF layouts. Any tips / ideas?
Thanks

I'm interested to this as well

+1

+1000 ;)

Any thoughts about this issue?!

Probably using jQuery or CommonJS to create an div-element, I call it now container-Element, with position fixed and left -10000px. Then cloning the to have to be printed elements into this one element. Apply print.css by adding an class to the container-Element so that child-Elements are using print-CSS. Then call your jspdf code on the container-Element


DCOS-22309: chore(package): backport integration-test script to 1.11

this should help us to investigate and identify flaky tests on 1.11 🙇

@juliangieseke just approved but you won the race merge :P

@Fabs @nLight Could you re-approve? I only resolved the merge conflict, two newly added scripts in the package.json lead to the conflict

rebased

@orlandohohmeier looks like I can't merge this 😓


Update bcpkix-jdk18on, bcprov-jdk18on to 1.79

About this PR
📦 Updates

org.bouncycastle:bcpkix-jdk18on
org.bouncycastle:bcprov-jdk18on

from 1.78.1 to 1.79
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.bouncycastle" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.bouncycastle" }
}]

labels: dependency, library-update, commit-count:1

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.52%. Comparing base (f2ec559) to head (a4edeb4).
Report is 23 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1796      +/-   ##
==========================================
+ Coverage   79.46%   79.52%   +0.06%
==========================================
  Files         144      144
  Lines        5010     5016       +6
  Branches      674      682       +8
==========================================
+ Hits         3981     3989       +8
+ Misses       1029     1027       -2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


The Kong docker image kong:0.12.2 failed

The Kong docker image failed
The stdout print /docker-entrypoint.sh: line 12: kong: command not found when starting the container
Version: 0.12.2
Possible reason: The kong install was failed on image building stage. The rpm url in Dockerfile is https://bintray.com/kong/kong-community-edition-rpm/download_file?file_path=dists%2Fkong-community-edition-0.12.2.el7.noarch.rpm, returned 404. The url is actually https://bintray.com/kong/kong-community-edition-rpm/download_file?file_path=centos%2F7%2Fkong-community-edition-0.12.2.el7.noarch.rpm. The query parameter file_path is different.

Hi, yes, we are aware and submitted a fix that is pending for review on the docker hub already. Thanks for reporting and sorry for the trouble!

Btw, this should only affect the centos image. The alpine one should be fine.

Appreciate your work!

@thibaultcha would it be possible to have the latest tag on alpine?

@CyExy This will be our policy starting with 0.13

This has been resolved now

@thibaultcha I don't think it is resolved... am I missing something?
docker run -ti --rm kong:0.11.2 bash

Unable to find image 'kong:0.11.2' locally
0.11.2: Pulling from library/kong
5e35d10a3eba: Pull complete
eaea1d1a065c: Pull complete
8fa0dbcc3a61: Pull complete
Digest: sha256:0fc4dfaff0ae6618fdf3574b369cc803d0e7768792aaceee5e819d7995f65e79
Status: Downloaded newer image for kong:0.11.2

[root@d8cc7973db18 /]# cat /usr/local/
bin/     etc/     games/   include/ lib/     lib64/   libexec/ sbin/    share/   src/

There is no kong in /usr/local/ still.

I still have this issue also
docker run -ti --rm kong:0.11.2 bash
Unable to find image 'kong:0.11.2' locally
0.11.2: Pulling from library/kong
5e35d10a3eba: Already exists
eaea1d1a065c: Pull complete
8fa0dbcc3a61: Pull complete
Digest: sha256:0fc4dfaff0ae6618fdf3574b369cc803d0e7768792aaceee5e819d7995f65e79
Status: Downloaded newer image for kong:0.11.2

[root@733f673e7ed8 /]# ls /usr/local/
bin  etc  games  include  lib  lib64  libexec  sbin  share  src

[root@733f673e7ed8 /]# kong
bash: kong: command not found

kong isn't there...

@optii @jaygorrell Alpine version should work docker run -ti --rm kong:0.12.2-alpine bash

It does, but this issue is specifically for the kong:0.12.2 tag.

Yes with alpine it does work, but that is not to the point, how did the 0.12.2 end up getting pushed to docker hub without kong in it... we've been using this version for a while without any problems.
Surely if a change was made to the docker the least that could have been checked is that kong actually exists on the image. I mean for stuff running in production it could end up being quite messy.

Hi All - I'm the Principal Product Manager here at Kong Inc. and I wanted to jump in this thread to say I'm sorry.  Thanks for your forgiveness, and thanks for being part of the Kong Community!


Added cyrillic (russian only) transliteration rules

Thanks! (And sorry this took so long.) I've just cut a new release which includes you change.

Thanks to you for this lib.


Empty string doesn't work.

Lexer can't recognoze empty string as valid. Rather throws error (LexingError: Unterminated string).

Fixed with this commit.


Invalid Request error - Engine not found

Steps done to install zsh_codex
1.) Installed openai using pip install openai
2.) Clone the repo with the given link, in my custom dir.
3.) Added source "$ZSH_CUSTOM/plugins/zsh_codex/zsh_codex.plugin.zsh" to my .zshrc
4.) Created openaipirc with the secrets generated from https://beta.openai.com/account/api-keys

Do you have access to Codex? Having access to the API is not sufficient,  see https://github.com/tom-doerr/vim_codex/issues/12

Oh ! I didn't know i need to have sufficient access for this. Thanks for the quick reply.


Italian Resources

Where is Resources.it.resx?

hi @makkros, are you looking for this? https://github.com/Microsoft/BotBuilder/blob/master/CSharp/Library/Microsoft.Bot.Builder/Resource/Resources.it.resx

thanks @Andrea-Orimoto , but I mean in the nuget packages, I found that it missed the it folder with the italian assembly. It's just my case or it's an error?
thanks

@makkros I'm closing this for inactivity. If you would like to continue the conversation here please do.  We can always reopen if needed.


[NEW] Could kvrocks support multi db paths

The problem/use-case that the feature addresses
During use kvrocks, we found kvrocks always write data to one db path, this behavior is not friendly, we want to kvrocks could write data to different db paths.
Description of the feature
As we know, rocksdb support multi db paths, so we hope kvrovks also could support this feature, we could set multi db paths by config set or function, maybe could create new db path if data file size of current db path exceeds setting threshold value.
Alternatives you've considered
different namespaces have different db paths.
Additional information
NULL
中文描述
功能解决的问题/用例
rocksdb能够对多个目录下的数据进行读写
功能描述
在使用过程中发现，在长时间写入后，都是写入到一个rocksdb数据文件中，希望通过函数控制数据库路径，或者控制rocksdb数据库文件在多大之后新建目录进行新的数据写入
你考虑过的替代方案
每次新建一个namespace，就按照namespace的名字，在rocksdb指定目录创建一个文件夹，相关数据存储到指定目录
在读写某个namespcae目录数据的时候对应打开，长时间不没有操作则关闭
其他信息
无

I think this idea makes sense. I ever also wanted to support it, this feature may bring many advantages

If there are some small disks, we also could provide big db
As we know, now there are many storage media with different speeds, such as AEP, SSD, HDD, we can store low level data on the fast storage, to gain better performance.
In cloud environment, we could use local disk and remote storage simultaneously.

Some related problems

Multi db paths bring troubles to maintain database storage.
For backup, it may bring some problems, since we may not just use hard link for rocksdb backup
Similar with backup, full replication needs also one checkpoint. And replica needs to handle how to store checkpoint of master.

PS: to acquire more people concerns, l add descriptions  in English, please correct me if I have misunderstandings

I see. Multipath database storage will cause other related problems
My requirement is to control the path to read the database through code
Is this feasible?
If you can, I hope to open it and dynamically modify the database path, so as to achieve my purpose
For example:
The database path in the configuration file is loaded by default, and redis and rocksdb data are synchronized
After modifying the database path, synchronize redis and rocksdb data again
明白了，多路径数据库存储存会产生其他先关问题
我这边的需求是想通过代码控制读取数据库的路径
这样是否可行？
如果可以希望能够开放出，动态修改数据库路径，从而达到我这种使用目的
例如：
默认加载配置文件中的数据库路径，redis与rocksdb数据同步
修改数据库路径后，再次同步redis与rocksdb数据

Hi @JackyLucifer Even multi db paths solution has several problem we need to deal with, i think it make much sense, it is worth putting energy to dig into.
your requirement is much customized and trick, i don't think we could support it, you can implement it in your branch.

OK


Update TTRPC

Vendor v1.2.3
Ref: https://github.com/containerd/containerd/pull/9704

/test pull-containerd-node-e2e


add hazelword.md

Project Name：Hazelword
add add hazelword.md forW3F Grant Proposal

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@ydong3, @ywdlucking needs to sign the CLA, because they are the one that committed the file to your repo.

Due to our reasons, it cannot be updated at #538, so keep to #551


Expose the entire router state in data function

I guess it would be more of a discussion than an issue, but while working on the real world example rewritten with solid app router, I encountered a situation where I'd like to access the router.location and listen to the change within the data function.
I thought about just using the useRouter and access router.location but it turns out we can't access this context in data functions. Digging a bit into the source code, I figured you manually generate getters for query and params to be passed into the data function props.
Is there a reason we just don't feed the whole state proxy into the data function here:
https://github.com/ryansolid/solid-app-router/blob/bb251041c245ed2247cbb1885f16acf981c11e70/src/index.tsx#L205-L212
Like so:
return levels[i].handler.data!(state);

I did patch it locally and it seems to work and since the proxy already exist I don't think we pay any perf price. That being said, I guess we are exposing more than the user could ever need.. And I would understand if you'd prefer discarding that issue.

I think this is reasonable. Especially now that I've hoisted it and router levels are no more than index used to resolve nested Routes. I had different behavior since I constructed params differently. And now that I've hoisted it above as you say you can't access that context. Which is an interesting point on it's own as it means the router needs to be the lowest global context, if you want to be able to read from context above it. It also mean data functions are outside of the tree so they can't leverage any nested contexts. I realized this while implementing and I'm not sure there is much to do for it since to parallelize nested we need to do this. With this setup we can navigate to..
users/123/settings and load both the user page and the user settings sub page in parallel while loading the data for both in parallel as well.
It does leave some questions on cascading data loads. Like what if the settings doesn't have enough from the url to know what data it needs, and needs to wait for the parents data to load first. In that case though I guess you wouldn't bother with a nested data component since you can't fetch in parallel anyway. Basically the view hierarchy can communicate to each other through props on the Route component or Context, but the data hierarchy has no similar way to communicate now that i've hoisted it. And in fact outside of a global store or props cannot communicate its results (nested contexts aren't available). These restrictions seem mostly fine but I feel like we can do better.
The answer might be related to this suggestion. Anything stored on the router itself would form a singleton context of sorts. But cleanup might be obvious. Anyway this is the sort of thing I'm thinking about.