[DO NOT MERGE] 2020-09-01-preview Batch endpoints, deployments and jobs

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[X] I commit to follow the Breaking Change Policy of “no breaking changes
[X] I have reviewed the documentation for the workflow.
[X] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[X] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
Adding a new service

[X] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable version with Breaking Change Validation errors
[ ] Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

/azp run automation - sdk

Re-creating this PR as a draft PR, as the original PR was merged by mistake earlier..
Tagging @markcowl / @chiragg4u from the original PR..

While adding new version the recommendation is to copy the existing version into new directory structure for first commit and then push new changes for easy review. Please create new branch with this recommendation for faster review.

Please remove the draft flag if you would like to get the review started.

@chiragg4u, this is the same exact PR here, that I re-created as a draft PR, as per the feedback on the ARM API review alias. The previous PR here  was merged by mistake, even with the DoNotMerge tag.
Let me know if you still want me to remove the draft flag. Thanks

Can the reviewer add 'DoNotMerge' tag for this PR? I am not able to add it to this PR, I have an active request pending to join this group to give me permissions to add tags to this PR, however it has not been pending for a while.

Main 2020-09-01-preview PR moved to #12508


Update package version

3.2.1-alpha.2 (2023-11-15)
Bug Fixes

frontend: 调整release job 顺序, frontend使用最新发布的packages (ae9c5c7)

:tada: This PR is included in version 3.2.1-alpha.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 3.2.1-online.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.2.2-alpha.2 :tada:
The release is available on npm package (@alpha dist-tag)
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.2.2-alpha.2 :tada:
The release is available on npm package (@alpha dist-tag)
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.2.2-alpha.2 :tada:
The release is available on npm package (@alpha dist-tag)
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 3.2.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Build fails when using case sensitive folders on Windows

Ninja is unable to find files in folders using upper case letters when case sensitive folders are enabled.
Issue can be reproduced by setting up the following folder structure and using the build.ninja file below.
test_ninja.zip
`-- test_ninja
     |-- bar
     |    `-- hello.c
     |-- Foo
     |    `-- hello.c

test_ninja must be a case sensitive folder.
fsutil.exe file setCaseSensitiveInfo .\test_ninja\ enable
# build.ninja
cc     = gcc

rule compile
  command = $cc -c $in -o $out

rule link
  command = $cc $in -o $out

#Example 1: Using incorrect casing for 'foo'. Ninja correctly reports an error
#build hello.o: compile foo/hello.c
#Output => ninja: error: 'foo/hello.c', needed by 'hello.o', missing and no known rule to make it

#Example 2: Using correct casing for 'Foo'. Ninja reports the same error, but it should be able to find it.
#build hello.o: compile Foo/hello.c
#Output => ninja: error: 'Foo/hello.c', needed by 'hello.o', missing and no known rule to make it

#Example 3: Using incorrect casing for 'Bar'. Ninja reports the expected error "No such file or directory"
#build hello.o: compile Bar/hello.c
#[1/2] gcc -c Bar/hello.c -o hello.o
#FAILED: hello.o
#gcc -c Bar/hello.c -o hello.o
#gcc: error: Bar/hello.c: No such file or directory
#gcc: fatal error: no input files
#compilation terminated.
#ninja: build stopped: subcommand failed.

#Example 4: Using correct casing for 'bar'. Everything is lower case and so it works
#build hello.o: compile bar/hello.c

build hello: link hello.o

default hello

I would expect Example 2 above to work.
Changing the following function RealDiskInterface::Stat in disk_interface.cc to not perform a transform to lower case makes it work as expected.
TimeStamp RealDiskInterface::Stat(const string& path, string* err) const {
....

**Removing the two lines below fixes the issue**
  //transform(dir.begin(), dir.end(), dir.begin(), ::tolower);
  //transform(base.begin(), base.end(), base.begin(), ::tolower);

....
}

Does it work if you apply this patch?
https://github.com/ninja-build/ninja/pull/1671

Does it work if you apply this patch?
#1671

No, I get the same error using that pull request

In that case, can you make a pull request that does your suggested change, and add several test cases for your scenero?
It would also be interesting to see if there is any noticeable performance degradation with your change.

The suggested change is just a workaround. Case sensitive folders on Windows is simply something Ninja doesn't support (yet).

In that case, can you make a pull request that does your suggested change, and add several test cases for your scenero?
It would also be interesting to see if there is any noticeable performance degradation with your change.

Is there a good way to test the performance?
I had to do a few more changes to get all the tests (ninja_test.exe) to pass, so it would be nice to know if the performance has been impacted by those changes.

No, not yet. #1733

I have looked a little bit more at the code and I can see that the casing is only an issue if the stat cache is being used.
If it is not being used then StatSingleFile is called instead of StatAllFilesInDir. The call to StatSingleFile is done prior to converting the path to lower case. This means that if stat cache is disabled then it actually works as expected on case sensitive folders.
My first take on fixing the case sensitive issues with the stat cache involves.
Remove the following line.
transform(dir.begin(), dir.end(), dir.begin(), ::tolower);
As I see it, the line does not make a difference on case insensitive folders.
The dir variable is later used in a call to FindFirstFileExA and on case insensitive folders casing does not matter.
It is also used as a key in the cache_. The key is case sensitive, but will not change between each call to RealDiskInterface::Stat, so not converting this to lower case should be fine.
Removing just this line fixes the issue with using the stat cache, when folders are using upper case letters and are case sensitive.
It does however not fix the issue with filenames having upper case letters.
In StatAllFilesInDir file names are being converted to lower case before being added to the DirCache within the cache_.
If these two " transform(lowername.begin(), lowername.end(), lowername.begin(), ::tolower); and transform(base.begin(), base.end(), base.begin(), ::tolower); " conversions are removed then it works as expected on case sensitive folders, but it will break it for people not using the correct casing on case insensitive systems because the key within the cache is case sensitive.
I have solved this by adding two entries for files containing upper case letters into the cache. One with the casing returned by FindFirstFileExA or FindNextFileA and another entry where it is converted to lowercase + suffix.
Example.
`-- bar
     |-- Hello.c
     |-- hello.c
     |-- hello.c_key

The cache will then contain:
cache["bar"] = {
 ["Hello.c_key"] = "Timestamp for Hello.c",
 ["hello.c_ckey"] = "Timestamp for Hello.c",
 ["hello.c_key"] = "Timestamp for hello.c",
 ["hello.c_key_key"] = "Timestamp for hello.c_key"
}

Hello.c with capital 'H' will result in two entries.
A suffix of "_key" is added to all filenames (keys) and a suffix of "_ckey" is added for lower case converted keys.
Without the suffix to all keys then a file with the name "Hello.c" and "hello.c_ckey" would end up with the same key.
The find operation in RealDiskInterface::Stat will then have to be modified so it tries the different combinations. First without changing the casing + "_key", then lower case + "_key" and finaly lower case + "_ckey".
Another option would be to check if the folder is case sensitive before deciding whether we should convert the filenames to lower case or not.
According to a comment here https://stackoverflow.com/questions/52206212/programmatically-check-windows-10s-case-sensitive-directory-attribute this does however not look to be supported by the Windows API headers.
"It's not exposed yet in the Windows API, at least not in the 10.0.17134 headers"
Requesting this information for each folder might eventually also impact the performance more compared to adding the additional entries to the cache, but I don't know this.

https://github.com/MartinBP/ninja/commit/791890cd50a635b3671f101a281ef7ec935725c2

I decided to go for a much simpler solution that covers almost all the cases. #1884
The only case not covered by this solution is if there are two or more files with the same name (except casing) in the same case sensitive folder. All other cases should be handled by simply not converting the path to lower case.
It is still okay to convert all file names to lower case on both case sensitive and case insensitive folders, so I have not changed that.

I would be glad if it gets merged and released pretty soon, so that there might be a chance that it will be included in the next Visual Studio release/update.

Last time I checked Visual Studio was still shipping Ninja 1.8, so don't get your hopes up.

Dear @jhasse, I just checked and both, Visual Studio 2019 (16.11.9) and Visual Studio 2022 (v17.0.4), now come with the latest version (v1.10.2) of ninja. (Had this PR been merged already, both Visual Studio versions would have this fix already.)

The PR looks okay but I'm not using Ninja on Windows much, so I can't review it enough.

Is there something that can be done to further progress this PR? Or is this PR doomed to become stale forever?

Had this PR been merged already, both Visual Studio versions would have this fix already.

The PR has been created after v1.10.2 was released, so no, it would not have this fix already.

[...] but are there some further tests that I can run, so the PR can be accepted?

Is there something that can be done to further progress this PR?

Unfortunately there are no easy-to-run scripts to check for performance regressions (see #1733). Creating such a script or manually checking would be the next step. Tests where the DirCache matters on Windows in particular.

Had this PR been merged already, both Visual Studio versions would have this fix already.

The PR has been created after v1.10.2 was released, so no, it would not have this fix already.

Sorry, my bad. I misread 2020 as 2021.

[...] but are there some further tests that I can run, so the PR can be accepted?

Is there something that can be done to further progress this PR?

Unfortunately there are no easy-to-run scripts to check for performance regressions (see #1733). Creating such a script or manually checking would be the next step. Tests where the DirCache matters on Windows in particular.

To be honest, I do not really understand why you expect this PR to have any impact on the performance, in particular with the DirCache.
If I read it correctly, the changes of this PR are equivalent to the following, even more simple diff:
--- a/src/disk_interface.cc
+++ b/src/disk_interface.cc
@@ -180,13 +180,14 @@ TimeStamp RealDiskInterface::Stat(const string& path, string* err) const {
     dir = path;
   }

+  string dir_origcase = dir;
   transform(dir.begin(), dir.end(), dir.begin(), ::tolower);
   transform(base.begin(), base.end(), base.begin(), ::tolower);

   Cache::iterator ci = cache_.find(dir);
   if (ci == cache_.end()) {
     ci = cache_.insert(make_pair(dir, DirCache())).first;
-    if (!StatAllFilesInDir(dir.empty() ? "." : dir, &ci->second, err)) {
+    if (!StatAllFilesInDir(dir_origcase.empty() ? "." : dir_origcase, &ci->second, err)) {
       cache_.erase(ci);
       return -1;
     }

From this it should be obvious that the only difference is that StatAllFilesInDir() (and internally FindFirstFileExA) now receives a directory name which is no longer guaranteed to be all lower-case.
As a result there will not be any difference if the file-system is not case-sensitive. (Even when looking for the wrongly cased filename, FindFirstFileExA will find the file; as before.)
On the other hand, for case-sensitive file-systems it now makes a difference: Without the changes from this PR the file cannot be found if its real case is not all lower-case. While with this PR it now can be found.
Still, the changes from this PR should not have any impact on performance for none case-sensitive file-systems.
The impact on performance for case-sensitive file-systems is noticeable only insofar as the build-process now no longer will fail.

Makes sense, thanks for the explanation. I've merged the PR :)

Thanks, I am glad I was helpful in analyzing and progressing this PR. 😄


Migrate SubQuery projects repo under kodadot

let's migrate subquery repository under kodadot org

Is this done?

Continue to

#1394


[TS migration] Migrate 'Indicator.js' component to TypeScript

Details

[TS migration] Migrate 'Indicator.js' component to TypeScript
Fixed Issues

$ https://github.com/Expensify/App/issues/25104
PROPOSAL: N/A
Tests

[x] Verify that no errors appear in the JS console

Use the same user account on all devices.
Open the app on device A and add a bank account. Close the app on the device A.
Open the app on device B and remove the bank account that was added in step 2.
Open the app on device A, go to bank account -> you will see it still have the removed bank account. Try to delete it. You should see an error that your bank account has already been deleted. If you check the user avatar on the home screen you should see a red dot indicator.

Offline tests

N/A
QA Steps

[x] Verify that no errors appear in the JS console

Use the same user account on all devices.
Open the app on device A and add a bank account. Close the app on the device A.
Open the app on device B and remove the bank account that was added in step 2.
Open the app on device A, go to bank account -> you will see it still have the removed bank account. Try to delete it. You should see an error that your bank account has already been deleted. If you check the user avatar on the home screen you should see a red dot indicator.

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

I will review in a few hours.

Sorry, got sidetracked. Reviewing this today.

@akinwale Please don't forget to take a look at this one 🙂

@akinwale Please don't forget to take a look at this one 🙂

Reviewing now. :)

@VickyStash One more step for the test steps (for the failure indicator): Enable "Simulate failing network requests" in settings.

@danieldoglas kind bump 🙂

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/danieldoglas in version: 1.4.12-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
cancelled 🔪

🍎 iOS 🍎
cancelled 🔪

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/danieldoglas in version: 1.4.12-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
cancelled 🔪

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/danieldoglas in version: 1.4.12-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.12-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


[AutoPR botservice/resource-manager] Bot Service: fixed readme error, added java readme

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/6429

(message created by the CI based on PR content)

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/6070


Any report or arxiv?

@zhimin-z No for a paper, I am an engineer, not a scientist.  Any report would be instantly out of date, the leaderboards are live for this purpose.


Update orders, trades with pagination

In this issue, we only update orders and trades follow a new data structure from API.
We'll create pagination for orders and trades in another issue in the feature.


Invalid proofs and violated protocol log messages on develop CLI

Preliminary Checks

[X] This issue is not a duplicate. Before opening a new issue, please search existing issues: https://github.com/MinaProtocol/mina/issues
[X] This issue is not a question, feature request, RFC, or anything other than a bug report. Please post those things in GitHub Discussions: https://github.com/MinaProtocol/mina/discussions

Description
We recently built the Berkeley CLI from the develop branch (commit 74337aef15fe65127de36d091340f396ae2f0c77) and have noticed some strange log messages. Proofs are not being validated correctly.
Chain id: 8c4908f1f873bd4e8a52aeb4981285a148914a51e61de6ac39180e61d0144771
We're getting a lot of entries like
{
  "action": "Trust_system.Actions.Sent_invalid_proof (external transition with state hash $state_hash)",
  "expiration": "2023-05-19 18:24:38.320328Z",
  "host": HOST_IP,
  "peer_id": "12D3KooWJQJJ6boizi6b9knQGYAVVrqnCbGGaXsZNAirunfQeFZS",
  "port": 8302,
  "sender_id": {
    "host": "<IP_ADDRESS>",
    "peer_id": "12D3KooWDKdHVbnkM7GJYML6ogYR5KmHUj9Ngnq1Lk42xcXnf2sx",
    "libp2p_port": 64779
  },
  "state_hash": "3NLGAuQumbvEq7svoLxFf1Q4bJx7Kc2i5pmnwHXQSW3y94XcmeJJ"
}

and
{
  "action": "Trust_system.Actions.Violated_protocol (Peer sent us bad proof for their best tip)",
  "expiration": "2023-05-19 15:31:28.462497Z",
  "host": HOST_IP,
  "peer_id": "12D3KooWJQJJ6boizi6b9knQGYAVVrqnCbGGaXsZNAirunfQeFZS",
  "port": 8302,
  "sender_id": {
    "host": "<IP_ADDRESS>",
    "peer_id": "12D3KooWP1B5ZinhnkatdA9rxEEbzKdj8j1MfKPmzQTNy1orYoy5",
    "libp2p_port": 46385
  }
}

and
Validation error: external transition with state hash $state_hash was rejected for reason "invalid proof"

We're connecting several peers (~15) but can't seem to progress past the genesis block.
Note:
Building from the rampup branch (commit 8bc96f320bd2b9fb0a2ef262e26265fe6b235a54) works as expected, no faulty peers, syncing relatively quickly, etc.
Steps to Reproduce

git pull develop
./nix/pin.sh
nix develop mina
dune exec src/app/cli/src/mina.exe --profile=devnet -- daemon -libp2p-keypair ~/.libp2p/key --peer-list-url https: //storage.googleapis.com/seed-lists/berkeley_seeds.txt --config-file genesis_ledgers/berkeley.json

Expected Result
Correctly validate proofs and observe blocks from peers
Actual Result
See description
How frequently do you see this issue?
Always
What is the impact of this issue on your ability to run a node?
Blocker
Status
Mina daemon status
-----------------------------------

Global number of accounts:                     7405
Block height:                                  1
Max observed block height:                     1
Max observed unvalidated block height:         0
Local uptime:                                  2m55s
Ledger Merkle root:                            jxx14ajKiweveJ7iAxtzTiLfAm3KXj5Y4MMvkbLc2qhi2LYnzLS
Protocol state hash:                           3NKv6abeNz6uwAifpH7UmYi1NoAaiJXpQx1FKoDMUM7UD3v38ycB
Chain id:                                      8c4908f1f873bd4e8a52aeb4981285a148914a51e61de6ac39180e61d0144771
Git SHA-1:                                     74337aef15fe65127de36d091340f396ae2f0c77
Configuration directory:                       /home/quantifier/.mina-config
Peers:                                         6
User_commands sent:                            0
SNARK worker:                                  None
SNARK work fee:                                100000000
Sync status:                                   Synced
Catchup status:
        Finished:  1

Block producers running:                       0
Coinbase receiver:                             Block producer
Best tip consensus time:                       epoch=0, slot=0
Best tip global slot (across all hard-forks):  0
Consensus time now:                            epoch=2, slot=6357
Consensus mechanism:                           proof_of_stake
Consensus configuration:
        Delta:                     0
        k:                         290
        Slots per epoch:           7140
        Slot duration:             3m
        Epoch duration:            14d21h
        Chain start timestamp:     2023-04-06 23:30:01.000000Z
        Acceptable network delay:  3m

Addresses and ports:
        External IP:    _
        Bind IP:        <IP_ADDRESS>
        Libp2p PeerID:  12D3KooWJQJJ6boizi6b9knQGYAVVrqnCbGGaXsZNAirunfQeFZS
        Libp2p port:    8302
        Client port:    8301

Metrics:
        block_production_delay:             7 (0 0 0 0 0 0 0)
        transaction_pool_diff_received:     1
        transaction_pool_diff_broadcasted:  0
        transactions_added_to_pool:         0
        transaction_pool_size:              0

### Additional information

_No response_

@Isaac-DeFrain the develop is not compatible withrampup or berkeley branches, hence, most likely won't work with currently deployed Berkeley testnet. Please use rampup instead.
Simple branching strategy is the following:

compatible is always compatible with the mainnet and has soft-forkable fixes for mainnet.
rampup is always compatible with the running Berkeley testnet and has soft-forkable protocol fixes and compatible SnarkyJS changes.
berkeley is the branch we’d be releasing off of for the mainnet hard fork. This should have all the changes in rampup but may additionally have fixes for Berkeley testnet that require a hard fork of the testnet and we may want to plan the release/redeployment for these fixes instead of disrupting the testnet immediately.
develop is for everything that we’d want to release as fast follow soft fork after the hard fork.

Thanks for the info @shimkiv!


Retry fetching results when running agent

Currently after 15s when running long running agent it times out and you need to refresh to see the chat record.

This PR resolved this issue: https://github.com/nearai/nearai/pull/553
The UI will now poll every ~1.5 seconds for latest messages/files regardless of failed API requests or run status.


make a preloader for Tools Dashboard

Reason/Context
With the addition of new Tools Dashboard in the website, this page now requires a preloader to get rendered before all the details of the tools are shown. Right now, when the browser requests the  AsyncAPI Tools Dashboard , it takes some time for the page to show the Tools information because of lot of tools being imported and rendered from a tools.json file.
Description
You need to design a proper preloader that aligns with the AsyncAPI design system and brand and then add it to the website.

Is there any design present or do I need to create a new one ?

Is there any design present or do I need to create a new one ?

You have to make a design first according to the AsyncAPI theme. You can take the help from some design contributors to understand the theme present in website.

Ok

Is this still up for grabs?

@sambhavgupta0705 @Maniktherana Any updates on the issue? are you working this issue to create a PR?

@akshatnema I was having some issues getting the loading state to trigger. I gave more details on slack, I'll tag you again. However, I do see that there's a PR on this so I'll pick something else up for the time being.


Doc generation of mixin props

I have a mixin that adds props to the component. Is it possible for those props to also be documented with the component they are added to?

I did not think about it, it's a good contribution, I need to add it in the vue styleguidist configuration to add the list of objects that will be the mixins and add them as global. Thanks! @lancetharper

Te lo agradezco pe causa!


Add templates for template repository

Templates need review before creating templates repo

@CaroFG Is SECURITY.md still needed? Otherwise I'll review your PR

@CaroFG Is SECURITY.md still needed?

I think it's best to remove the INTEGRATIONS-CONTRIBUTING file, maybe just add a link to it on the readme. Also, if we can put a default code of conduct, I'll remove that file too, which was obsolete anyways...

I don't really get why you want to get rid of the INTEGRATIONS-CONTRIBUTING file could you explain? Thanks
Because it duplicates the content and if they modify it on their side, it won't be up to date on ours, so I think it's better to just add a link to it

Are we OK to remove INTEGRATIONS-CONTRIBUTING?

I am wondering do we actually want this in the devrel repo or do we create a new repository?

I am wondering do we actually want this in the devrel repo or do we create a new repository @ferdi05 ?

What do you think would be the most useful for our team? I think cloning a template repo, so I would go for a new repo, but I'm unsure. With issue and PR templates too.

I would go for a new repo too.

A template repo has been created: https://github.com/meilisearch/template-repo/
Closing this PR since the content doesn't belong here anymore


Confusion between “submitter input” and “justification”

from discussion with @maccraymer

We have two terms, “justification” and “submitter input”. In the interface they refer to the same thing (because justification is the only thing in submitter input) so it was confusing when the labels were different and we agreed that it’s better to refer to submitter input as justification, too.


How to skip first iteration time in process bar ?

Description & Motivation
Because the first iteration time is incorrect (model initialization and torch.compile when first interation)
Pitch
No response
Alternatives
No response
Additional context
No response
cc @borda

I agree it would be nice if we could re-init the progress bar automatically after the first or so iterations. With the current progress bar implementation, this is doable but not trivial.


How make android map & web map mix？

if the phone no google play（too many many phone no google Play in Asia），
I want use web map + Native Map in Android Phone ~

do u have web-maps-utils?

There's a similar lib for web here: https://github.com/googlemaps/v3-utility-library


Smart Dropdown with text input search

🚀 Feature

There are so many color and colormap options and we want to keep them. Also we want to provide a better experience on GUI. Hence, here i am proposing to have a dropdown with a text search as seen here: https://www.w3schools.com/howto/howto_js_filter_dropdown.asp
Motivation

There are so many colors and colormaps. Right now it is not easy to grab you like.
Pitch

This will make your life easier :)
Alternatives
I can not think any better but i am open to suggestions.
Additional context

To clarify the additional suggestion we had during the meeting: the actual list being searched could be bigger than the list being displayed without any search. In the CSS/js example I think you could do this with a .initially-hidden class that you apply to hidden elements on the list, and that you remove/ignore when you start filtering.

Hi @jni , yes, i put css example to give a feeling. I will implement it in the way we discussed during the meeting.

This might be an interesting starting point:
https://stackoverflow.com/questions/4827207/how-do-i-filter-the-pyqt-qcombobox-items-based-on-the-text-input


Transfer Data from the Page Menu View Controller to Another

I have a collection view embed in table views on a page menu view controller. like below.

i need to be able to tab on a collection view cell for data the text and images to be transferred onto another view controller.
MoviesViewController. swift is view controller that i instantiated from the storyboard into the page menu.
in this file i used the code below.
`override func prepareForSegue(segue: UIStoryboardSegue, sender: AnyObject?) {
    if segue.identifier == "MovieDisplayID" {

        let preDisplay : MovieDisplayViewController = segue.destinationViewController as! MovieDisplayViewController

        print("Segue Performed.")

        preDisplay.moviePhoto.image = UIImage(named: "greatest")

    }
}`

i made a print to check whether the segue is actually performed and yeah it does. but it gives an error when i try to transfer an image.
Error message says... Thread 1 : Signal SIGABRT
Could not cast value of type 'UINavigationController' (0x10970c860) to 'Page_Test_3.MovieDisplayViewController' (0x1074719d8).
(lldb)

Please Help me!!

can u post ur project link @Gigiiasante ?


Report expected bundle size increases

Description
Whenever people reach for a new dependency, they have to determine whether the added benefits outweigh the cost, or the other way around.
In the case of Skia, it can seem like the app is increasing by a huge amount, I've seen numbers like 100MB and 247MB mentioned – but what really matters is the size of the app as it will be downloaded in the app store / play store.
If we report these numbers (and how we calculated them), people can use that information to help inform the decision on whether to use Skia or not.

There's an increase in the bundle size for both platform

Platform
Bare repo
Skia Included

Android
26.9MB
63.9MB

iOS
1.1MB
3.6MB

   "@shopify/react-native-skia": "^0.1.142",
   "react": "18.0.0",
   "react-native": "0.69.4"


Port project to io.js?

Seems like a good play. Would there be any objections or concerns about doing this?

You are talking about v2 right?

Sure :) Although if v1 would be easy to port then maybe that too?

I think we should only do v2 for now. Most people who pick up the project are barely familiar to nodejs and adding io.js to the mix would be confusing for now.

Tr3w

io.js is merging back into node, lets look at it when that merger is done


comply to the proper RFD specification

Hi!
I fixed nostalgy in Debian yesterday and saw there is a patch there that fixes install.rfd for it to use the proper RFD specification.
So here it is! Thanks for developing nostalgy.

This pull request should be closed as it doesn't apply to TB68 and future versions (this rdf file is gone!)


PluginDescriptor no longer serialisable.

Elisp tests currently fail
Addresses #92
@cocreature or @gracjan please have a look at the elisp tests, the wire format has now changed.
This may also make the ExtendedCommandDescriptor unnecessary

The format returned by plugins doesn’t make sense. Here’s a simplified response
{
  "plugins": [
    [
      "base",
      [
        {
          "name": "version"
        },
        {
          "name": "plugins"
        }
      ]
    ],
    [
      "eg2",
      [
        {
          "name": "sayHello"
        }
      ]
    ]
  ]
}

The problem is that you are using an array of arrays where each inner array represents a plugin. The inner array always contains only two elements with the first one being the plugin name and the second being an array of plugins.
I don’t see any good reason to not just use a hashmap that maps from plugins to lists of commands. Otherwise the IDE side then needs to convert this array of two element arrays into a hashmap to do anything reasonable with it.

Leaving aside the serialisation, which is completely unoptimised, the key type is to return
-- | Subset type extracted from 'Plugins' to be sent to the IDE as
-- a description of the available commands
type IdePlugins = [(PluginId,[CommandDescriptor])]

instead of the full Plugins structure, which was returned before in the "base:plugins" command.
This does not touch the current commandDetail command that still returns the ExtendedCommandDescriptor.

How about making that a map from PluginId to [CommandDescriptor]?

BTW, if I run the console (which in this case prints JSON encode output), I get
{"plugins":
  [
    ["base",
      [{"contexts":["none"],"name":"version","additional_params":[],"ui_description":"return HIE version","file_extensions":[]}
      ,{"contexts":["none"],"name":"plugins","additional_params":[],"ui_description":"list available plugins","file_extensions":[]}
      ,{"contexts":["none"],"name":"commands","additional_params":[{"rp":["plugin","the plugin name","text"]}],"ui_description":"list available commands for a given plugin","file_extensions":[]}
      ,{"contexts":["none"],"name":"commandDetail","additional_params":[{"rp":["plugin","the plugin name","text"]},{"rp":["command","the command name","text"]}],"ui_description":"list parameters required for a given command","file_extensions":[]}
      ]
    ]
   ,["eg2",
     [{"contexts":["none"],"name":"sayHello","additional_params":[],"ui_description":"say hello","file_extensions":[]}
     ,{"contexts":["none"],"name":"sayHelloTo","additional_params":[{"rp":["name","the name to greet","text"]}],"ui_description":"say hello to the passed in param","file_extensions":[]}
     ]
    ]
   ,["ghcmod",
     [{"contexts":["file"],"name":"check","additional_params":[],"ui_description":"check a file for GHC warnings and errors","file_extensions":[".hs",".lhs"]}
     ,{"contexts":["file"],"name":"lint","additional_params":[],"ui_description":"Check files using `hlint'","file_extensions":[".hs",".lhs"]}
     ,{"contexts":["project"],"name":"find","additional_params":[{"rp":["symbol","The SYMBOL to look up","text"]}],"ui_description":"List all modules that define SYMBOL","file_extensions":[".hs",".lhs"]}
     ,{"contexts":["file"],"name":"info","additional_params":[{"rp":["expr","The EXPR to provide info on","text"]}],"ui_description":"Look up an identifier in the context of FILE (like ghci's `:info')","file_extensions":[".hs",".lhs"]}
     ,{"contexts":["point"],"name":"type","additional_params":[],"ui_description":"Get the type of the expression under (LINE,COL)","file_extensions":[".hs",".lhs"]}
     ]
    ]
   ,["hare",
     [{"contexts":["point"],"name":"demote","additional_params":[],"ui_description":"Move a definition one level down","file_extensions":[".hs"]}
     ,{"contexts":["point"],"name":"dupdef","additional_params":[{"rp":["name","the new name","text"]}],"ui_description":"Duplicate a definition","file_extensions":[".hs"]}
     ,{"contexts":["region"],"name":"iftocase","additional_params":[],"ui_description":"Converts an if statement to a case statement","file_extensions":[".hs"]}
     ,{"contexts":["point"],"name":"liftonelevel","additional_params":[],"ui_description":"Move a definition one level up from where it is now","file_extensions":[".hs"]}
     ,{"contexts":["point"],"name":"lifttotoplevel","additional_params":[],"ui_description":"Move a definition to the top level from where it is now","file_extensions":[".hs"]}
     ,{"contexts":["point"],"name":"rename","additional_params":[{"rp":["name","the new name","text"]}],"ui_description":"rename a variable or type","file_extensions":[".hs"]}
     ]
    ]
   ]
  }

Which seems to do what we want. Maybe lose the outer layer "plugins":[] and do the list directly.

I don’t see why we want an array of two element arrays here instead of a map from plugin names to an array of commands.

Because a PluginDescriptor is not round trip serialisable, because of the
CommandFunc.
And at the moment the [Service] layers are unused, and are intended for
internal plugin plumbing anyway.
So the only thing an IDE should care about is the PluginId and the
commands exposed, as per the CommandDescriptor.
On Mon, Nov 23, 2015 at 12:54 PM, Moritz Kiefer<EMAIL_ADDRESS>wrote:

How about making that a map from PluginId to [CommandDescriptor]?
—
Reply to this email directly or view it on GitHub
https://github.com/haskell/haskell-ide-engine/pull/93#issuecomment-158903822
.

There is no reason not to do a map from PluginId to CommandDescriptor.

I feel like we’re talking at crosspurposes. I completely agree with the general idea of not serializing the PluginDescriptor. I just want it to be serialized as a map rather than an array of tuples, aka
{"plugins":
  {"base":
      [{"contexts":["none"],"name":"version","additional_params":[],"ui_description":"return HIE version","file_extensions":[]}
      ,{"contexts":["none"],"name":"plugins","additional_params":[],"ui_description":"list available plugins","file_extensions":[]}
      ,{"contexts":["none"],"name":"commands","additional_params":[{"rp":["plugin","the plugin name","text"]}],"ui_description":"list available commands for a given plugin","file_extensions":[]}
      ,{"contexts":["none"],"name":"commandDetail","additional_params":[{"rp":["plugin","the plugin name","text"]},{"rp":["command","the command name","text"]}],"ui_description":"list parameters required for a given command","file_extensions":[]}
      ]
   }
}

Yes. A map please!

LGTM, feel free to merge it. I’ll fix the elisp tests later.
Maybe we should separate the elisp part so that we don’t break travis everytime someone makes a change to the protocol and doesn’t also change the elisp.
Otherwise we’re going to end up with a state where we have five different IDE integrations in this repo and if someone makes a change he has to know each of them to be able to fix the tests.

Maybe we should separate the elisp part so that we don’t break travis everytime someone makes a change to the protocol and doesn’t also change the elisp.

I may be off, but I like the idea of plugins being in this repository.
I have the impression the more the community unite on this repe, the better it is.
Also, It's pleasant to see that the plugin break.
I'd much rather have a pull request delayed because it's breaking some ide plugins than the opposite

@rvion I tend to agree, but let me explain my reasoning:
At some point we’ll (hopefully) have at least integrations for emacs, vim & atom. I think it’s unreasonable to except contributors to know how the integrations in all three of those work. This puts us in a dilemma:
Either we force them to learn each of them, which doesn’t seem like a good idea. Or we allow people to submit prs with failing tests as long as they only concern IDE integrations and then wait for other people to contribute them and then merge all of those prs quickly to reduce the amount of breakage on master. I suppose we could also do prs against the branch of the pr with the new ide integrations, but I fear that we scare away contributors.

@cocreature in my opinion, I think it is better to either merge PR with some test failing and encourage the community to fix them soon after or let package maintainer make PR against specific repo branch to update their ide-integration code.
To my opinion, a failing test is the most effective way to make things get fixed. It's more effective than issue opening, more informative, and it invites all collaborators to improve the current state :)
Here are some more arguments in favor of a central unique repository with subfolders for different plugin integration:

Hie was born because the community was too much divided. Splitting this package might destroy all of our hopes of unification. Imagine if some ide-integration-plugin authors decide to depends on an extra linux only tool ? We won't know right away, and we'll have no controll over it. If we want to end up with a single tool, I think we need to be host all ide plugins.
Easier ide-plugins discoverability.
easier to see share code/ideas between plugins, look at how one implemented such or such feature, and do the same for an other ide.
One repository is the only simple way to ensure there is no regression or breakage across the ecosystem, to make stable releases, etc.
I have the impression to often see ide-itegrators quickly become less motivated to update their plugins because it will work good enough for them. Having them all here will federate more maintainers
keeping everything together simplify future possible features, such as automating plugin installation directly in hie, etc..

ping @JPMoresmau @gracjan @alanz to include them in that discussion

@JPMoresmau @gracjan @alanz  discussion starts here: https://github.com/haskell/haskell-ide-engine/pull/93#issuecomment-158959598

You convinced me :)


ruff server: Introduce settings for directly configuring the linter and formatter

Summary
The following client settings have been introduced to the language server:

lint.preview
format.preview
lint.select
lint.extendSelect
lint.ignore
exclude
lineLength

exclude and lineLength apply to both the linter and formatter.
This does not actually use the settings yet, but makes them available for future use.
Test Plan
Snapshot tests have been updated.

Will --config come later, or is it already supported? That was the last piece of the proposal, IIRC -- but may be misremembering.

@charliermarsh That will come later! I'll be working on that next week.


Fix last page when including a tutorial

Because the tutorial start with 0, the array length will need to be adjusted

what is the expected behaviour, when user at the last question?
throw to question 1 or homepage? or thankyou page?

it should be modified totalQuestion ?
const totalQuestion = Object.keys(questions).length + 1

it should be modified totalQuestion ?
const totalQuestion = Object.keys(questions).length - 1

yes i think that is the code that lead to a bug, should dynamically check if the question started with tutorial or not

need review yaa @jarooda on my PR https://github.com/jarooda/family-100/pull/7 to solve this issue


Adding a Navigation bar (header)

Please assign me the task under Hacktoberfest 2024.
I could create a simplistic navigation bar containing logo, toggle dark/light mode button and the github icon! This is to ensure that this info always appears on the top of of page for easier navigation and enhanced user experience. I would also make sure to create the navbar responsive to screen size and works good on mobile as well as laptop.

ok
sounds good.

I have created a navbar that enhances the overall design and functionality of the website. The new navbar includes essential features such as a logo, dark/light mode toggle, and github access. I believe this addition improves the user experience significantly.
@JayShukla8 kindly merge my pull request! #51

Issue resolved


Enable MessageLoop unit-test in FML after the Flutter runner has migrated to using them.

The original migration was reverted but the unit-tests were still in place. These tests are now causing flakes. These have been disabled.

cc @gw280 @iskakaushik FYI


"Kill and wipe" does not actually kill task

Steps to reproduce (using latest master):

Create an app as follows

{
  "id": "/le-sleep",
  "cmd": "sleep 3600",
  "cpus": 1,
  "mem": 128,
  "disk": 0,
  "instances": 3,
  "container": {
    "type": "MESOS",
    "volumes": [
      {
        "containerPath": "hi",
        "mode": "RW",
        "persistent": {
          "size": 16,
          "type": "root",
          "constraints": []
        }
      }
    ]
  }
}

Using the Marathon UI, select one of the instances and click "Kill and Wipe"

The task is expunged from Marathon, but if you go to the Mesos UI, the task is actually not killed.

@timcharper Do you have logs for this?

It's pretty easy to reproduce. I'll get them.

Same error here:

create app

{
  "id": "/state-full-postgres",
  "cmd": null,
  "cpus": 1,
  "mem": 512,
  "disk": 0,
  "instances": 0,
  "acceptedResourceRoles": [
    "*"
  ],
  "container": {
    "type": "DOCKER",
    "volumes": [
      {
        "containerPath": "pgdata",
        "mode": "RW",
        "persistent": {
          "size": 1069200,
          "type": "mount",
          "constraints": [
            [
              "path",
              "LIKE",
              "/mnt/sd.+"
            ]
          ]
        }
      }
    ],
    "docker": {
      "image": "postgres:latest",
      "network": "BRIDGE",
      "portMappings": [
        {
          "containerPort": 5432,
          "hostPort": 0,
          "servicePort": 10000,
          "protocol": "tcp",
          "name": "postgres",
          "labels": {}
        }
      ],
      "privileged": false,
      "parameters": [],
      "forcePullImage": false
    }
  },
  "env": {
    "POSTGRES_PASSWORD": "password",
    "PGDATA": "pgdata"
  },
  "portDefinitions": [
    {
      "port": 10000,
      "protocol": "tcp",
      "labels": {}
    }
  ],
  "upgradeStrategy": {
    "minimumHealthCapacity": 0,
    "maximumOverCapacity": 0
  }
}

curl to slave: "http://<IP_ADDRESS>:5051/state" | jq .reserved_resources_full.foo

"disk": {
      "persistence": {
        "id": "state-full-postgres#pgdata#8296045d-f388-11e6-bd95-0242da34cb9b",
        "principal": "marathon"
      },
      "volume": {
        "mode": "RW",
        "container_path": "pgdata"
      },
      "source": {
        "type": "MOUNT",
        "mount": {
          "root": "/mnt/sda"
        }
      }
    }

Kill and wipe from marathon UI -> master logs:

[2017-02-15 18:00:46,789] INFO  Expunging instance [state-full-postgres.marathon-8296045e-f388-11e6-bd95-0242da34cb9b] (mesosphere.marathon.api.TaskKiller$$EnhancerByGuice$$6900c557:ForkJoinPool-2-
worker-15)

[2017-02-15 18:00:46,792] INFO  Removed app [/state-full-postgres] from tracker (mesosphere.marathon.core.task.tracker.InstanceTracker$InstancesBySpec$:marathon-akka.actor.default-dispatcher-6)

[2017-02-15 18:00:46,793] INFO  receiveInstanceUpdate: instance [state-full-postgres.marathon-8296045e-f388-11e6-bd95-0242da34cb9b] was deleted (Killed) (mesosphere.marathon.core.launchqueue.impl.T
askLauncherActor:marathon-akka.actor.default-dispatcher-20)

[2017-02-15 18:00:46,793] INFO  initiating a scale check for runSpec [/state-full-postgres] due to [instance [state-full-postgres.marathon-8296045e-f388-11e6-bd95-0242da34cb9b]] Killed (mesosphere.
marathon.core.task.update.impl.steps.ScaleAppUpdateStepImpl$$EnhancerByGuice$$7fc9e45f:marathon-akka.actor.default-dispatcher-6)

[2017-02-15 18:00:46,793] INFO  Already running 0 instances of /state-full-postgres. Not scaling. (mesosphere.marathon.SchedulerActions:ForkJoinPool-2-worker-27)

curl to slave: "http://<IP_ADDRESS>:5051/state" | jq .reserved_resources_full
same result:

...
"disk": {
      "persistence": {
        "id": "state-full-postgres#pgdata#8296045d-f388-11e6-bd95-0242da34cb9b",
        "principal": "marathon"
      },
      "volume": {
        "mode": "RW",
        "container_path": "pgdata"
      },
      "source": {
        "type": "MOUNT",
        "mount": {
          "root": "/mnt/sda"
        }
      }
    }

To fix i have to:
1 delete de persistent volumes from master (curl -X POST http://<IP_ADDRESS>:5050/master/destroy-volumes)
2. unreserved resources expicit (-X POST http://<IP_ADDRESS>:5050/master/unreserve)

Log output: https://gist.github.com/timcharper/5f198b7db9303a5d3cd37686d974d0ec

Root cause isolated:

in TaskKiller.scala, we expunge before we kill.
When we expunge the task, this begins a new recovery deployment.
The new recovery deployment acquires a lock in MarathonSchedulerActor
By the time MarathonSchedulerActor receives the message to request that the tasks get killed, the lock fails here

Fix submitted: https://phabricator.mesosphere.com/D533

@alexispetalas - thanks for your comment. I think that the bug that you're encountering may be a different one, though, #5142 . A fix has landed in master (along with this one) and we will back port for the next release.


docs: update readme

Signed-off-by: Arteev Raina<EMAIL_ADDRESS>Fixes : #92
Description :
Typo fixed in Readme
Please ensure Checkmark the following :

[ ] - Tested Localy
[ ] - Checked in IE11 and Firefox
[ ] - Checked in mobile
[ ] - Backend work
[ ] - Frontend work
[ ] - Bug Fixes
[x] - Enhancements

@BetaCat0 Are there any other issues that need help? I would love to contribute.

@arteevraina I think the actual port is 3030 indeed. Why changed it to 3000?
https://github.com/casbin/casbin-dashboard/blob/7851225732e602626eab7c95a57eea8967542539/web/package.json#L18-L23

It runs port on 3030, so close the PR.


Backport: Storage provider refactor including latest build scripts and docs to the release-1.7 branch

Description of your changes:
The NFS repo is preparing to release from its own repo instead of the main rook/rook repo. This updates everything from master for critical build changes that are required for this separate build and release process.
Checklist:

[ ] Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
[ ] Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
[ ] Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
[ ] Reviewed the developer guide on Submitting a Pull Request
[ ] Documentation has been updated, if necessary.
[ ] Unit tests have been added, if necessary.
[ ] Integration tests have been added, if necessary.
[ ] Pending release notes updated with breaking and/or notable changes, if necessary.
[ ] Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
[ ] Code generation (make codegen) has been run to update object specifications, if necessary.

Will open a different PR to resolve merge conflicts...


Use https instead of http

The Twitter link didn't use https

:+1:
/cc @robbyrussell

Conflicts with #3664, requiring manual merge. I manually made the same changes over there too.
There's another twitter link in the upgrade.sh script, too.


/tree/ should redirect to /notebooks/ if  is a notebook file

Problem
When redirecting users to a particular file (from nbgitpuller), it is important to not need prior knowledge on wether the target is a file or a directory. In lab and classic notebook, we can send people to /tree/<path>, it redirects to /notebooks/<path> if it's a notebook or /tree/<path> if it's just a directory, based on what ContentsManager says.
retrolab doesn't do that - if you go to /tree/<path> but <path> is a notebook you get an error.
Proposed Solution
https://github.com/jupyterlab/retrolab/blob/0f7c026472e64b9f9073cce47a00c072d6a84af5/retrolab/app.py#L99 currently handles redirects. We could either figure out a contentsmanager check here, or do that on the client side

Thanks @yuvipanda.
Probably doing the redirect in that handle will be enough. RetroLab should then be able to handle URLs that look like /retro/notebooks/example.ipynb


Timeout in startMultiple() needed

A timeout in the function startMultiple() is required, as in the tare() function.

Implemented now in version 1.1.5.
Sorry for late response...


please drop any feature requests here

Hat says add:
- backgroundColor: string;
- textColor: string;
- bodyColor prop: string;

here  is  what  I'm working  on

custom text  (user  can  change  from  connect  button  to  something  else
onSuccess event
balance     (the prop to  show / hide balance)

@abdul-kabugu i am not sure this is going to work as an out of the box component anymore as we move away from moralis servers

@BillyG83     TY  for  info ,  is  still  issue  open  ?  I  can  work  on it  ?

@abdul-kabugu sure you are welcome to work on it. the aim was to provide connect button without Moralis server and add some nice new features like customisation. I do not think it s possible without firebase or NextJS as a backend. But you could try or even just change the scope of this. FYI  now has customisation so you could use it in  and job done for V1

i'm going to close this as we have a new plan of how to re-create the functionality of Connect Button with NextJS or Firebase


Issue of bert_model arg in run_classify.py

Hi,
I am trying to understand the bert_model arg in run_classify.py. In the file, I can see
tokenizer = BertTokenizer.from_pretrained(args.bert_model)

where bert_model is expected to be the vocab text file of the model
However, I also see
model = BertForSequenceClassification.from_pretrained(args.bert_model, len(label_list))

where bert_model is expected to be a archive file containing the model checkpoint and config.
Please help to advice the correct use of bert_model if I have my pretrained model converted locally already.
Thanks!

Hi, please read this section of the readme.


How to customize the "Meta table" for special Model.

Like  Post Model has default meta table,
but User Model may need another meta table, like user_metas.

If I create a new Model inheritance  \Zoha\Meta\Models\Meta, and set $table to Meta table name "user_meta",  but all trait MetableBase , GetMeta ... use the default Meta Model ...

Why do you want to create a separate table for user's model meta?
Meta uses polymorphic relationship, which allows you to use a table for all models.
For example, for your User model, the value of the column owner_type will be equal to App\User. And for your posts model, the value of this column will be equal to App\Post.
Or maybe I did not understand my purpose correctly!
Can you explain better?

Yes, I know owner_type for more Models.
Whether this will cause the table data volume to increase too quickly, leading to slow queries ?

As far as I know the physical database size or number of records don't matter. what matters is the number of queries .
In this package, I tried to minimize the number of queries.
Even if you use withMeta method for eagle loading , only one query will be used for getting all meta data from database .

Anyway, thanks for your suggestion.
I'm trying to add this feature to later versions .

Thanks

I release version 1.5 . Now you can use separate meta table for each of your models.
Custom Meta Table


User ConfigParser instead of RawConfigParser

It would be nice to be able to use interpolation of values in the config file.
It would allow to store variables with role id's and use those variables in custom aliases.

It looks like this makes the tests fail because of the date_format setting that uses % signs in its value. I'd be happy to merge your PR if you have an idea how to make this change backwards compatible.

The plan is now to move away from the ini format for the configuration file (see #137), which means interpolation won't be possible anyway. I'll close this PR, but feel free to comment if you know other configuration formats that would allow interpolation.


improve error message for no docker connection

The Problem:
OP #357 Our error message is not very good if we can't connect to the docker client.
The Fix:
This improves the error message if we can't connect to docker. It also allows the "version" and "config" commands to be run regardless of docker's state or version.
The Test:

Stop your Docker daemon
Run a ddev command that's not version or config. You should get a clear error message that we can't connect to Docker.
Run ddev version and ddev config. These commands should work normally without docker running.

Automation Overview:

Related Issue Link(s):
Release/Deployment notes:

duplicate of https://github.com/drud/ddev/issues/357

My mistake. Thought this was an issue not a PR at a glance. I should read more carefully :)


msg gets appended to SPINNERS elements

Example:
 @spinner :clock "Loading..." sleep(1)
 @spinner :clock "Loading..." sleep(1)
 @spinner :clock "Loading..." sleep(1)
 @spinner :clock "Loading..." sleep(1)

Only Vector{String} elements are affected.

A copy of the vector should be sent instead.

#138


System.InvalidOperationException: Sequence contains more than one element

Hi all you smart people,
I have an issue. Using EF7 beta 6
        public IViewComponentResult Invoke(/*ICollection<Mission> missions*/) {
            var ticks = SystemClock.Instance.GetCurrentInstant().Ticks;
            var missions = db.Missions
                .Include(m => m.Owner)
                .Include(m => m.Players)
                    .ThenInclude(p => p.User)
                .Include(m => m.Activity)
                    .ThenInclude(a => a.Game)
                .Where(m => m.Scheduled >= ticks)
                .Where(m => m.Players.Count < m.Activity.Slots)
                .OrderBy(m => m.Scheduled)
                .Take(4).ToList();
            return View(missions);
        }

The code above produces System.InvalidOperationException: Sequence contains more than one element on the ToList() and I don't think it should. See the stack trace at https://gist.github.com/damccull/0ea09acbeb668d72f465
The gist also contains each of the models, the applicationdbcontext, and anything else I thought may be relevant to this...
I'd like to know why this is, and how to fix it if possible. I've been told my code is horribly inefficient, but optimization is something I'll tackle after I get it working.
I'll post anything else you need, but I'm not sure what that might be, so please ask away.

I have determined the culprit is .Where(m=>m.Players.Count < m.Activity.Slots)
This causes exception.
.Where(m => m.Scheduled >= ticks)
.Where(m => m.Players.Count < m.Activity.Slots)

This does not.
.Where(m => m.Scheduled >= ticks)

Am I just doing it wrong or is this a bug?

@damccull traversing navigation properties in LINQ queries is being implemented at the moment. Some scenarios are enabled in our working code base, but not in Beta 6. Work is tracked by #325.


Adding docs for snyk

https://deploy-preview-325--roadie.netlify.app/docs/integrations/snyk/ <- rendered page

[ch2140]

No problem. Thanks for the review


[FEATURE] test and improve RCA algorithm with actual data produced by STAC night time light data pipeline

Feature Description
after #2963 is being done, RCA algorithm logic needs to be tested with actual data produced by the pipeline code and /vrt endpoint
Feature Implementation
No response
Feature Alternatives
No response
Feature Impact
No response
Feature Rationale
No response
Feature Considerations
No response
Feature Requirements
No response
┆Issue is synchronized with this Wrike task by Unito

this was already closed


Add new game unitangle

@Priyanshi662  pls check this PR

@Priyanshi662  PLS CHECK This pr

thank for your support see you again in any other Competition @Priyanshi662


Support for ESM configs

Describe the feature
Support loading ESM config files. Currently only CommonJS svelte.config files are supported because the code uses require to load it.
I think that this line needs to change to use import(..) . Note though that TS will transpile this to a require anyway, that's why you need to create a const dynamicImport = new Function('path', 'return import(path)'); function and use that one as a workaround (see https://github.com/microsoft/TypeScript/issues/43329 for more info).
A Usecase
Support ESM svelte.config.js in SvelteKit
Alternatives
none
Additional context
Blocker for https://github.com/sveltejs/kit/pull/936

Needs support for async config from vite, this has been merged but not released https://github.com/vitejs/vite/pull/2758
Also does this mean that going forward there will be no svelte.config.cjs and we should discourage its use or are both allowed?
And while we're at it, whats the list of locations vite-plugin-svelte should look for svelte.config.c?js ?  (see https://github.com/sveltejs/vite-plugin-svelte/issues/23 for context)

Update, async config hook might be a better place: https://github.com/vitejs/vite/pull/2800

Both cjs and js should be supported. It should check .js first, then .cjs to be in line with the order how language-tools and SvelteKit (will) resolve it.
Regarding "where to look": I think this was never specified. But we should, at some point, to save us some maintenance 😄

Initial code here https://github.com/sveltejs/vite-plugin-svelte/compare/feat/async-load-config-esm  needs to wait until vite 2.16 is released and peer dependency updated.
should we try to get rid of everything non-esm and make vite-plugin-svelte itself a type: module too?
Here's another require call: https://github.com/sveltejs/vite-plugin-svelte/blob/a2acab981c91dd47aa036798ef0bf79d9c805342/packages/vite-plugin-svelte/src/index.ts#L161 , anything else?

You also need to replace the require-relative dependency I think.

Very interested in this PR. Anything I can do to help?

unfortunately jest doesn't really support esm, so a fallback to cjs is needed.
@dummdidumm would it be ok to require the cjs extension or fallback to require if import throws?

Fine with me, if import() throws for real users later on there's not much you can do anyway.

released in 1.0.0-next.8

I encountered a bug on windows. It tells me that the given path is not a valid scheme. Seeing that I remembered that I had the same issue in language-tools and what I did was wrapping the path with pathToFileUrl - sorry for not catching that earlier.


[BUG] Discord Client crashes upon opening channel

Describe the bug
Upon selecting a channel specific channel, the Discord client greys out and the entire user interface disappears
To Reproduce
Steps to reproduce the behavior:

Click on the channel
Not certain as to why it happens, probably a weird message in the channel cannot be loaded and causes the client to crash

Expected behavior
The channel is supposed to open and display the messages
Screenshots

Desktop (please complete the following information):

OS: Windows 11 Pro
Node version v16.13.2

@all-contributors please add @ipxter for bug


PERF: Prefer multiplication to division

Multiplication is a faster operation than division, so
prefer to store 1/spacing values to be used repeatedly.

@nocnokneo Comments addressed.

Makes sense, thanks.


Update tests with broken GCS links

GCS files no longer exist, updated to general GCS location and updated tests accordingly

Fixes: https://github.com/GoogleCloudPlatform/java-docs-samples/issues/1786

Thanks for the update! @lesv can you approve this PR?


[wip] Remove dependency on lyft/api

TL;DR
This PR eliminates dependency on lyft/api fork
Type

[x] Bug Fix
[ ] Feature
[ ] Plugin

Are all requirements met?

[ ] Code completed
[ ] Smoke tested
[ ] Unit tests added
[ ] Code documentation added
[ ] Any pending items have an associated Issue

Tracking Issue
https://github.com/flyteorg/flyte/issues/742

Codecov Report

Merging #71 (f0be597) into master (334748c) will increase coverage by 0.35%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
+ Coverage   70.10%   70.46%   +0.35%
==========================================
  Files          57       57
  Lines        1967     1967
==========================================
+ Hits         1379     1386       +7
+ Misses        449      443       -6
+ Partials      139      138       -1

Flag
Coverage Δ

unittests
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

cache/auto_refresh.go
81.05% <0.00%> (+7.36%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 334748c...f0be597. Read the comment docs.


Use FileLock as a decorator

Should be possible by inheriting from contextlib.ContextDecorator.  What's required to contribute to the project?

This is already possible https://github.com/tox-dev/py-filelock/blob/main/src/filelock/_api.py#L207-L229

@gaborbernat sorry, I meant as a context decorator.

Can you give an example of where, how and why you would want this?

@FileLock(lock_file_path)
def function_that_must_not_run_in_parallel():
    ...

I am using this for a regression test, where if I have multiple instances running on the same machine they interfere with each other.  My current workaround is:
class _FileLockDecorator(filelock.FileLock, contextlib.ContextDecorator):
    pass

@_FileLockDecorator(lock_file_path)
def run_regression():
    pass

I was wondering if this could become a part of the package?

Sure, put in a PR with tests, documentation and changelog entry 👌

@gaborbernat I made a PR with tests, documentation (I added an example in the tutorial in index.rst) & a changelog entry
Is there anything else I should add?
https://github.com/tox-dev/py-filelock/pull/128
Thanks


Pirate guns

About the PR
Adds some pirate themed weapons using sprites from CEV-Eris for mappers to use if they want to map a new pirate shuttle.
Screenshots
musket

flintlock

flaregun

pirate revolver

Changelog
No changelog because the guns need to be mapped in.
I'd also appreciate any balance/spritework feedback.

linter failing


support for "book", "buy", "checkout", "donate", "order" as type in GooglePayButton component

I am working on an app that has allows its user to donate using Google Pay. So the "Pay with G Pay" text on the button just doesn't sound right. It would have been nice if all types were supported.

 Now there is only a white option with or without shadows.

This is a great request, although I'll need to think about it a little bit. I believe we can add the assets to this library, and although it will expand the size of the npm module you download, as long as people enable resource shrinking on Android, it should have no effect on final app size (but I'd want to test that out to be sure).

Any updates on the ability to style the GooglePayButton to dark or black mode please? Google Pay & Wallet Console is requesting we do this to be able to grant us the integration. Thank you.

Hi, I haven't been working on this and it's not immediately planned
Rather than adding in these assets to this library itself,  the plan is to find if Google provides a friendlier asset type for the google pay button as they have with the "add to google pay" button - https://developers.google.com/pay/issuers/apis/push-provisioning/android/branding-guidelines#flutter (they're providing it for flutter, but it's also much nicer for RN). I'd be surprised if they didn't, and this will make it much easier for folks to customize this button

Dark buttons will be made available in https://github.com/stripe/stripe-react-native/pull/1051

Just wanted to ask, have you found friendlier asset types for these buttons? I think besides using "donate" it would also allow us to use borderRadius like with the Apple Pay button (and their defaults are round https://developers.google.com/pay/api/android/guides/brand-guidelines#payment-buttons, in fact I'm worried that they'll have an issue with ours not being round)

The new asset types for PlatformPayButton offer donate and are rounded- they follow Google's newest guidelines

Thanks for the heads up! Unfortunately I can't upgrade to that version yet, as the latest Expo SDK version is incompatible, but will keep it in mind for when it is. Google have gotten back to me and they indeed require the latest guidelines, so for now I'll just use a static image


ignore large column test

ignore ignore large column test because of https://github.com/pingcap/tispark/issues/1942

/run-all-tests mode=simple


GPU Path optimizations

As discussed, I am going to open this pull request with the changes we did in the previous weeks.
Let me know how we want to proceed. Note that in principle, each single commit can be compiled and should work as is.

This PR will essentially be satisfied once redgreen-optimized is merged into develop.

The remaining gap is in this draft PR: https://github.com/marsdeno/ectrans/pull/4 (not meant to be merged, just documentation purpose)


hipblaslt_ext::getAllAlgos returns solutions, none of which are supported

hipblaslt_ext::getAllAlgos returns algos which can then be validated using hipblaslt_ext::matmulIsAlgoSupported. For some cases, all the algos returned are invalid.
This seems to be an issue that hipBLASLt team needs to look into. Collect such cases and logs for hipBLASLt team to look into.

Observation of investigation:

On bert-base-cased, we hit the issue of getAllAlgos() returning all invalid solutions, only when we disable MLIR.

I have opened a ticket for this issue against hipBLASLt.

Feedback from the hipBLASLt team:
This is a standard behavior. getall means to get all the solutions, and when that solution is valid
for a certain size, checked by issuppoted then call matmul.


nixos/sudo: enable by default

Description of changes
The default was accidentally changed to false in https://github.com/NixOS/nixpkgs/pull/262790

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Thank you for noticing this quickly! Merging this without waiting for full ofborg because this has the potential of locking people out of their systems.

What should I do if I got locked out of my machine? I can login as my user, but I can't run nixos-rebuild or anything. I don't remember the password for root either & disabled SSH login too. This is an EC2 VM. None of the connect options seem to be working... I think a few of VMs are affected...


Bump to v0.8.1-pre

r? @fiveop @posborne

@homu r+

:pushpin: Commit bfe2be5 has been approved by posborne

:zap: Test exempted - status


Set up deployment context var for google tag manager

This PR sets up a config variable for the google tag manager ID.
It also changes config.template to set up global variables with var so we don't have to disable eslint every time we add a new config variable in config/Config.js
Closes https://github.com/opentargets/platform/issues/1491

@mbdebian google tag manager ids follow the following regex /^GTM-\w+/


Sneha hero section

I added hero-section for a Ecoshop for which I used HTML, CSS AND Javascript. The site is completely functional, Responsive and user friendly.

Done with hero section

Update branches.


MIREOT 'categorical variable', 'relative risk', and 'variable' from STATO

Add 'categoricalVariable' as UAL of 'categorical variable', and 'variable' as UAL of 'variable'.


If error in _export then _error task is not execute

Overview
if error in _export then _error task is not execute.
Reproduction
Reference to huga in _export, but huga is not difined.
And, I expect run echo error!!!!!!!!! in error, but ReferenceError: "huga" is not defined error occur again.
+task1:
  _export:
    hoge: ${huga}
  sh>: echo "hoge"

_error:
  sh>: echo error!!!!!!!!!

$ java -jar ~/src/github.com/katsuyan/digdag/pkg/digdag-0.9.40-SNAPSHOT.jar run workflow.dig --rerun
2019-08-18 20:57:53 +0900: Digdag v0.9.40-SNAPSHOT
2019-08-18 20:57:55 +0900 [INFO] (main): Database migration started
2019-08-18 20:57:55 +0900 [INFO] (main): Applying database migration:20151204221156
2019-08-18 20:57:55 +0900 [INFO] (main): Applying database migration:20160602123456
2019-08-18 20:57:55 +0900 [INFO] (main): Applying database migration:20160602184025
2019-08-18 20:57:55 +0900 [INFO] (main): Applying database migration:20160610154832
2019-08-18 20:57:55 +0900 [INFO] (main): Applying database migration:20160623123456
2019-08-18 20:57:55 +0900 [INFO] (main): Applying database migration:20160719172538
2019-08-18 20:57:55 +0900 [INFO] (main): Applying database migration:20160817123456
2019-08-18 20:57:55 +0900 [INFO] (main): Applying database migration:20160818043815
2019-08-18 20:57:55 +0900 [INFO] (main): Applying database migration:20160818220026
2019-08-18 20:57:55 +0900 [INFO] (main): Applying database migration:20160908175551
2019-08-18 20:57:55 +0900 [INFO] (main): Applying database migration:20160926123456
2019-08-18 20:57:55 +0900 [INFO] (main): Applying database migration:20160928203753
2019-08-18 20:57:55 +0900 [INFO] (main): Applying database migration:20161005225356
2019-08-18 20:57:55 +0900 [INFO] (main): Applying database migration:20161028112233
2019-08-18 20:57:55 +0900 [INFO] (main): Applying database migration:20161110112233
2019-08-18 20:57:55 +0900 [INFO] (main): Applying database migration:20161209001857
2019-08-18 20:57:55 +0900 [INFO] (main): Applying database migration:20170116082921
2019-08-18 20:57:55 +0900 [INFO] (main): Applying database migration:20170116090744
2019-08-18 20:57:55 +0900 [INFO] (main): Applying database migration:20170223220127
2019-08-18 20:57:55 +0900 [INFO] (main): Applying database migration:20190318175338
2019-08-18 20:57:55 +0900 [INFO] (main): Database migration successfully finished.
2019-08-18 20:57:56 +0900 [WARN] (main): Reusing the last session time 2019-08-17T00:00:00+00:00.
2019-08-18 20:57:56 +0900 [INFO] (main): Using session /Users/katsuya.tajima/src/github.com/katsuyan/digdag-example/notificaiton/.digdag/status/20190817T000000+0000.
2019-08-18 20:57:56 +0900 [INFO] (main): Starting a new session project id=1 workflow name=workflow session_time=2019-08-17T00:00:00+00:00
2019-08-18 20:57:57 +0900 [ERROR] (0018@[0:default]+workflow+task1): Configuration error at task +workflow+task1: Failed to evaluate a variable ${huga} (ReferenceError: "huga" is not defined) (config)
2019-08-18 20:57:57 +0900 [ERROR] (0019@[0:default]+workflow^error): Configuration error at task +workflow^error: Failed to evaluate a variable Failed to evaluate a variable ${huga} (ReferenceError: "huga" is not defined) (config) (ReferenceError: "huga" is not defined) (config)
2019-08-18 20:57:57 +0900 [INFO] (0018@[0:default]+workflow^failure-alert): type: notify
error:
  * +workflow+task1:
    Failed to evaluate a variable ${huga} (ReferenceError: "huga" is not defined) (config)
  * +workflow^error:
    Failed to evaluate a variable Failed to evaluate a variable ${huga} (ReferenceError: "huga" is not defined) (config) (ReferenceError: "huga" is not defined) (config)

Task state is saved at /Users/katsuya.tajima/src/github.com/katsuyan/digdag-example/notificaiton/.digdag/status/20190817T000000+0000 directory.
  * Use --session <daily | hourly | "yyyy-MM-dd[ HH:mm:ss]"> to not reuse the last session time.
  * Use --rerun, --start +NAME, or --goal +NAME argument to rerun skipped tasks.

Reference
I wrote details at https://qiita.com/katsuyan/items/9846749fa8ccb98cd022 (Japanese)

Sorry for my late response.
I agree with that invalid _export definitions cause fail of _error: task is not good behavior.
We need to think about how to solve this issue.


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_8bv9oysu42/clone/recipe/meta.yaml:16: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_8bv9oysu42/clone/recipe/meta.yaml:21: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_8bv9oysu42/clone/recipe/meta.yaml:37: missing_documentation: The recipe is missing a doc_url or doc_source_url
WARNING: /tmp/abs_8bv9oysu42/clone/recipe/meta.yaml:37: missing_description: The recipe is missing a description
ERROR: /tmp/abs_8bv9oysu42/clone/recipe/meta.yaml:37: missing_license_family: The recipe is missing the about/license_family key.
ERROR: /tmp/abs_8bv9oysu42/clone/recipe/meta.yaml:37: missing_dev_url: The recipe is missing a dev_url
Errors were found


SyntaxError

Your main function in test.py is not an async function, but you have an "await" inside it. This is a SyntaxError.

Hello. I'm going to publish new version with new features. Thanks a lot for that warn!On Jun 15, 2023 00:16, László Zsolt Nagy @.***> wrote:
Your main function in test.py is not an async function, but you have an "await" inside it. This is a SyntaxError.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>


fix: unable to save changes to the main loot table as "null" is not an integer

When saving changes to the main table, the request returns "null" as a literal string - added a check for this to fix it

Oh, odd-- thank you for the fix!

Oh, there might be an issue if the main table is left empty as well?
production.ERROR: mt_rand(): max(-1) is smaller than min(0) {"userId":2,"exception":"[object] (ErrorException(code: 0): mt_rand(): max(-1) is smaller than min(0) at /home/soulsdeveloper/soulsbetween.com/www/app/Models/Loot/LootTable.php:150)

Oh hmm, my expectation would be that there is always something in the main table tbh


Improve load path order spec

What was the end-user problem that led to this PR?
The problem was for a while I've had a spec failing locally and that's annoying.
What was your diagnosis of the problem?
My diagnosis was that if you install a development version of bundler in your system (through bin/rake install:local), this spec starts failing with:
 $ bin/rspec -e "orders the load pa"
Run options: include {:full_description=>/orders\ the\ load\ pa/}

Randomized with seed 55764

Bundler.setup
  load order
$ /home/deivid/.rbenv/versions/2.6.3/bin/ruby \
  -I/home/deivid/Code/bundler/lib:/home/deivid/Code/bundler/spec -rsupport/hax \
  -r/home/deivid/Code/bundler/spec/support/artifice/fail /home/deivid/Code/bundler/exe/bundle \
  install --retry 0
Fetching source index from file:///home/deivid/Code/bundler/tmp/gems/remote1/
Resolving dependencies...
Fetching rake 12.3.2
Installing rake 12.3.2
Fetching activesupport 2.3.2
Installing activesupport 2.3.2
Fetching actionmailer 2.3.2
Installing actionmailer 2.3.2
Fetching actionpack 2.3.2
Installing actionpack 2.3.2
Fetching activerecord 2.3.2
Installing activerecord 2.3.2
Fetching activeresource 2.3.2
Installing activeresource 2.3.2
Using bundler 2.1.0.pre.1
Fetching rails 2.3.2
Installing rails 2.3.2
Bundle complete! 1 Gemfile dependency, 8 gems now installed.
Use `bundle info [gemname]` to see where a bundled gem is installed.
# $? => 0

$ /home/deivid/.rbenv/versions/2.6.3/bin/ruby -I/home/deivid/Code/bundler/lib -e  \
  <<EOS
          require 'rubygems'
          require 'bundler'
          Bundler.setup
          puts $LOAD_PATH
EOS
/home/deivid/Code/bundler/lib
/home/deivid/.rbenv/rbenv.d/exec/gem-rehash
/home/deivid/Code/bundler/tmp/gems/system/gems/rails-2.3.2/lib
/home/deivid/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/bundler-2.1.0.pre.1/lib
/home/deivid/Code/bundler/tmp/gems/system/gems/activeresource-2.3.2/lib
/home/deivid/Code/bundler/tmp/gems/system/gems/activerecord-2.3.2/lib
/home/deivid/Code/bundler/tmp/gems/system/gems/actionpack-2.3.2/lib
/home/deivid/Code/bundler/tmp/gems/system/gems/actionmailer-2.3.2/lib
/home/deivid/Code/bundler/tmp/gems/system/gems/activesupport-2.3.2/lib
/home/deivid/Code/bundler/tmp/gems/system/gems/rake-12.3.2/lib
/home/deivid/.rbenv/versions/2.6.3/lib/ruby/site_ruby/2.6.0
/home/deivid/.rbenv/versions/2.6.3/lib/ruby/site_ruby/2.6.0/x86_64-linux
/home/deivid/.rbenv/versions/2.6.3/lib/ruby/site_ruby
/home/deivid/.rbenv/versions/2.6.3/lib/ruby/vendor_ruby/2.6.0
/home/deivid/.rbenv/versions/2.6.3/lib/ruby/vendor_ruby/2.6.0/x86_64-linux
/home/deivid/.rbenv/versions/2.6.3/lib/ruby/vendor_ruby
/home/deivid/.rbenv/versions/2.6.3/lib/ruby/2.6.0
/home/deivid/.rbenv/versions/2.6.3/lib/ruby/2.6.0/x86_64-linux
# $? => 0

$ /home/deivid/.rbenv/versions/2.6.3/bin/ruby -I/home/deivid/Code/bundler/lib -e puts\ \$LOAD_PATH
/home/deivid/Code/bundler/lib
/home/deivid/.rbenv/rbenv.d/exec/gem-rehash
/home/deivid/.rbenv/versions/2.6.3/lib/ruby/site_ruby/2.6.0
/home/deivid/.rbenv/versions/2.6.3/lib/ruby/site_ruby/2.6.0/x86_64-linux
/home/deivid/.rbenv/versions/2.6.3/lib/ruby/site_ruby
/home/deivid/.rbenv/versions/2.6.3/lib/ruby/vendor_ruby/2.6.0
/home/deivid/.rbenv/versions/2.6.3/lib/ruby/vendor_ruby/2.6.0/x86_64-linux
/home/deivid/.rbenv/versions/2.6.3/lib/ruby/vendor_ruby
/home/deivid/.rbenv/versions/2.6.3/lib/ruby/2.6.0
/home/deivid/.rbenv/versions/2.6.3/lib/ruby/2.6.0/x86_64-linux
# $? => 0
    orders the load path correctly when there are dependencies (FAILED - 1)

Retried examples: 0

Failures:

  1) Bundler.setup load order orders the load path correctly when there are dependencies
     Failure/Error:
       expect(load_path).to start_with(
         "/gems/rails-2.3.2/lib",
         "/gems/activeresource-2.3.2/lib",
         "/gems/activerecord-2.3.2/lib",
         "/gems/actionpack-2.3.2/lib",
         "/gems/actionmailer-2.3.2/lib",
         "/gems/activesupport-2.3.2/lib",
         "/gems/rake-12.3.2/lib"
       )

       expected ["/gems/rails-2.3.2/lib", "/home/deivid/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/bundler-2.1.0.....3.2/lib", "/gems/actionmailer-2.3.2/lib", "/gems/activesupport-2.3.2/lib", "/gems/rake-12.3.2/lib"] to start with "/gems/rails-2.3.2/lib", "/gems/activeresource-2.3.2/lib", "/gems/activerecord-2.3.2/lib", "/gems/actionpack-2.3.2/lib", "/gems/actionmailer-2.3.2/lib", "/gems/activesupport-2.3.2/lib", and "/gems/rake-12.3.2/lib"

       Commands:
       $ /home/deivid/.rbenv/versions/2.6.3/bin/ruby \
         -I/home/deivid/Code/bundler/lib:/home/deivid/Code/bundler/spec -rsupport/hax \
         -r/home/deivid/Code/bundler/spec/support/artifice/fail /home/deivid/Code/bundler/exe/bundle \
         install --retry 0
       Fetching source index from file:///home/deivid/Code/bundler/tmp/gems/remote1/
       Resolving dependencies...
       Fetching rake 12.3.2
       Installing rake 12.3.2
       Fetching activesupport 2.3.2
       Installing activesupport 2.3.2
       Fetching actionmailer 2.3.2
       Installing actionmailer 2.3.2
       Fetching actionpack 2.3.2
       Installing actionpack 2.3.2
       Fetching activerecord 2.3.2
       Installing activerecord 2.3.2
       Fetching activeresource 2.3.2
       Installing activeresource 2.3.2
       Using bundler 2.1.0.pre.1
       Fetching rails 2.3.2
       Installing rails 2.3.2
       Bundle complete! 1 Gemfile dependency, 8 gems now installed.
       Use `bundle info [gemname]` to see where a bundled gem is installed.
       # $? => 0

       $ /home/deivid/.rbenv/versions/2.6.3/bin/ruby -I/home/deivid/Code/bundler/lib -e  \
         <<EOS
                 require 'rubygems'
                 require 'bundler'
                 Bundler.setup
                 puts $LOAD_PATH
       EOS
       /home/deivid/Code/bundler/lib
       /home/deivid/.rbenv/rbenv.d/exec/gem-rehash
       /home/deivid/Code/bundler/tmp/gems/system/gems/rails-2.3.2/lib
       /home/deivid/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/bundler-2.1.0.pre.1/lib
       /home/deivid/Code/bundler/tmp/gems/system/gems/activeresource-2.3.2/lib
       /home/deivid/Code/bundler/tmp/gems/system/gems/activerecord-2.3.2/lib
       /home/deivid/Code/bundler/tmp/gems/system/gems/actionpack-2.3.2/lib
       /home/deivid/Code/bundler/tmp/gems/system/gems/actionmailer-2.3.2/lib
       /home/deivid/Code/bundler/tmp/gems/system/gems/activesupport-2.3.2/lib
       /home/deivid/Code/bundler/tmp/gems/system/gems/rake-12.3.2/lib
       /home/deivid/.rbenv/versions/2.6.3/lib/ruby/site_ruby/2.6.0
       /home/deivid/.rbenv/versions/2.6.3/lib/ruby/site_ruby/2.6.0/x86_64-linux
       /home/deivid/.rbenv/versions/2.6.3/lib/ruby/site_ruby
       /home/deivid/.rbenv/versions/2.6.3/lib/ruby/vendor_ruby/2.6.0
       /home/deivid/.rbenv/versions/2.6.3/lib/ruby/vendor_ruby/2.6.0/x86_64-linux
       /home/deivid/.rbenv/versions/2.6.3/lib/ruby/vendor_ruby
       /home/deivid/.rbenv/versions/2.6.3/lib/ruby/2.6.0
       /home/deivid/.rbenv/versions/2.6.3/lib/ruby/2.6.0/x86_64-linux
       # $? => 0

       $ /home/deivid/.rbenv/versions/2.6.3/bin/ruby -I/home/deivid/Code/bundler/lib -e puts\ \$LOAD_PATH
       /home/deivid/Code/bundler/lib
       /home/deivid/.rbenv/rbenv.d/exec/gem-rehash
       /home/deivid/.rbenv/versions/2.6.3/lib/ruby/site_ruby/2.6.0
       /home/deivid/.rbenv/versions/2.6.3/lib/ruby/site_ruby/2.6.0/x86_64-linux
       /home/deivid/.rbenv/versions/2.6.3/lib/ruby/site_ruby
       /home/deivid/.rbenv/versions/2.6.3/lib/ruby/vendor_ruby/2.6.0
       /home/deivid/.rbenv/versions/2.6.3/lib/ruby/vendor_ruby/2.6.0/x86_64-linux
       /home/deivid/.rbenv/versions/2.6.3/lib/ruby/vendor_ruby
       /home/deivid/.rbenv/versions/2.6.3/lib/ruby/2.6.0
       /home/deivid/.rbenv/versions/2.6.3/lib/ruby/2.6.0/x86_64-linux
       # $? => 0
     # ./spec/runtime/setup_spec.rb:164:in `block (3 levels) in <top (required)>'
     # ./spec/spec_helper.rb:127:in `block (2 levels) in <top (required)>'
     # ./spec/spec_helper.rb:96:in `block (2 levels) in <top (required)>'
     # ./spec/support/rubygems_ext.rb:43:in `load'
     # ./spec/support/rubygems_ext.rb:43:in `gem_load'

Finished in 0.82951 seconds (files took 1.17 seconds to load)
1 example, 1 failure

Failed examples:

rspec ./spec/runtime/setup_spec.rb:149 # Bundler.setup load order orders the load path correctly when there are dependencies

Randomized with seed 55764

This is because the development version of bundler installed gets activated and that messes up the load path assertion.
What is your fix for the problem, implemented in this PR?
My fix is to build the development bundler gem, install it to tmp/system and make sure that version gets activated. And include that in the test assertion.
Why did you choose this fix out of the possible options?
I chose this fix because it makes the spec independent from the developer's environment.

Just a tiny improvement in one spec, so I will merge it.
@bundlerbot r+


[HOLD for payment 2022-12-22] DEV - Loading indicator is not  in center on Add Bank Account

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Login to new
go to Settings - payments - Add Payment method - Bank Account
observe the loading indicator

Expected Result:
The loading indicator should be in the center.
Actual Result:
The loading indicator isn't in center
Workaround:
unknown
Platform:

Where is this issue occurring?

Web

Version Number: 1.2.36-2
Reproducible in staging?: Needs preproduction (Seems happening only in DEV)
Reproducible in production?: Needs reproduction
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/206236316-1ad5c227-7d66-4c22-a73b-07f5a8e58b83.mov
Expensify/Expensify Issue URL:
Issue reported by: @varshamb
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1670352022190369
View all open jobs on GitHub

I'm unable to reproduce this on v1.2.36-2 web chrome, so I’m going to close this issue in the absence of clearer reproduction steps to reliably reproduce it.

I can reproduce in all of them, but in DEV, not staging.. so I guess that explains why you can't reproduce :P. Looks like a regression that is going to be deployed at some point

Ahh, yeah, it is in the description Reproducible in staging?: Needs preproduction (Seems happening only in DEV) 🤦

The regression seems to be coming from this PR: https://github.com/Expensify/App/pull/12954

@aldo-expensify are we making this a deploy blocker then?

Well, I think it becomes a deploy blocker when it reaches staging. I don't know if we can use the label before that.

Oh sorry, I saw it on the deploy checklist here when I was going through - should have checked in the PR for the state. Cool, makes sense. Want to add the Internal label in the interim though?

Draft PR up: https://github.com/Expensify/App/pull/13499

👋 I'm going to be out from tomorrow when this payment is due.
@varshamb I've sent you an offer for $250 for reporting the issue, and @thesahindia $1k for the PR review. Can you please accept the job offers on this. Once you have, do confirm here in the issue. @JmillsExpensify I'm co-assigning you to settle those contracts if you wouldn't mind!
As for the rest of the checklist..

[@aldo-expensify] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

@aldo-expensify what do you think about this one? I think that will inform whether we should add a regression test for this, as it's largely a cosmetic UI placement issue.

@aldo-expensify what do you think about this one? I think that will inform whether we should add a regression test for this, as it's largely a cosmetic UI placement issue.

@mvtglobally do you know if this is already part of a test? (Verifying that the loading spinner is in the middle of the panel and not at the top)

Settled up with @thesahindia. 👍

@aldo-expensify it would likely be here if so: https://expensify.testrail.io/index.php?/cases/view/1971065&group_by=cases:section_id&group_order=asc&display_deleted_cases=0&group_id=229065

Thanks @trjExpensify. I modified the step 4. to be
4. Verify the loading spinner appears vertically centred and then the plaid modal is displayed.
Does that sound good?

@varshamb I've sent you an offer for $250 for reporting the issue, and @thesahindia $1k for the PR review. Can you please accept the job offers on this. Once you have, do confirm here in the issue. @JmillsExpensify I'm co-assigning you to settle those contracts if you wouldn't mind!

Circling back on this. I'm still waiting for @varshamb to accept the offer before I can finalize the contract and settle up the reporting bonus.

@varshamb Quick reminder that you have an offer outstanding in Upwork for this job. Please accept the offer so we can make sure you're paid.

@varshamb Reminding you again that you have an outstanding offer you need to accept in Upwork, thanks!

Awesome, thanks for accepting @varshamb. I've settled up!
@aldo-expensify that edit looks good, so closing this out now. Thanks ya'll!


Add custom logrotate config

Still needs deployment/testing

Rebased

Has this been applied?

Rebased, force-pushed

Merging based on 157


Plaxrun iteration over a map of parameters marshals values

Example:
plaxrun -run demos/iterate.yaml -dir demos -g iterate-v1 -log debug
plaxrun -run demos/iterate.yaml -dir demos -g iterate-v2 -log debug

with
name: iterate
tests:
  basic:
    path: iterate-test.yaml

groups:
  iterate-v1:
    tests:
      - name: basic
    iterate:
      params: |
        [{"WANT":"tacos"},{"WANT":"chips"}]
  iterate-v2:
    tests:
      - name: basic
    iterate:
      param: "WANT"
      params: |
        ["tacos","chips"]

and
spec:
  phases:
    phase1:
      steps:
        - pub:
            payload:
              make:
                name: mock
                type: mock
        - recv:
            chan: mother
            pattern:
              success: true
        - pub:
            payload: '{"want":"?WANT"}'
        - recv:
            pattern: '{"want":"?x"}'
            timeout: 1s
            guard: |
              return bs["?x"] == bs["?WANT"] && bs["?x"].substring(0,1) != '"'

iterate-v2 does what I want: it iterates with values tacos (string) and chips (string), but iterate-v1 iterates with "tacos" (with embedded quotes) and "chips" (with embedded quotes). I think the behavior should be the same, and I think it should be iterate-v2's behavior. ?

The example in the plaxrun manual works because the values are integers, which don't get quotations when serialized.