Update on GitHub Advanced Security workbook

In this PR I am updating the current GitHub Advanced Security workbook.
New features:

Filtering by organizations
Filtering by repository topics

@v-spadarthi
@NikTripathi
I could not find a way to conditionally render filters (repositories and repo topics). The idea behind these filters is that if repositories are selected, the topics filter should not be enabled, and vice versa. I was able to find a workaround where you have to deselect all repositories in order to activate the repo topics filter, but it's not ideal. Do you have any recommendations on how to improve this functionality?

Hello @AlexDeMichieli, Thank you for raising this PR. This PR will be investigated and will update you by 25 August, 2023.

Hello @AlexDeMichieli, I was trying to test the playbook but I have incomplete sample data.
Can you please share the sample data to the test the workbook, Thanks.

Hello @AlexDeMichieli, I was trying to test the playbook but I have incomplete sample data. Can you please share the sample data to the test the workbook, Thanks.

Hi @v-prasadboke ; what test data are you missing? and how can I export test data from Sentinel? thanks!

Hello @AlexDeMichieli, We already have sample data for table githubscanaudit_CL but its incomplete.
Please modify these sample data ( https://github.com/Azure/Azure-Sentinel/blob/05276177f3272a3d374550676ba12643ab37388c/Sample Data/githubscanaudit_CL.json#L4 ) as per required results.
Also please share the working images of these workbook.
Thanks,
Prasad Boke.

Hi @v-prasadboke, please find below the screenshots of the dashboards

I've included additional data in the document you've shared (here's the link to download it). It should be enough to test the "topics" filter. I left some comments in the JSON file that describe the data:
https://drive.google.com/file/d/1aBrcCORfJnTxO4IrTUIvrfTXxV1l2Z0P/view?usp=sharing

Hello @AlexDeMichieli, Thank you for sharing the sample data and working images of workbook.
Will examine this images and update you about the same before EOD.

Hello @AlexDeMichieli, all looks good. Please resolve the Branch conflicts so this PR can get merged

Hi @v-prasadboke , for some reason I cannot solve the merge conflict nor see what areas of the workbook should get fixed. When I pull the master branch into my feature branch, no changes occur.  The new file should completely override the previous one.

Hi @v-prasadboke , for some reason I cannot solve the merge conflict nor see what areas of the workbook should get fixed. When I pull the master branch into my feature branch, no changes occur. The new file should completely override the previous one.

Yes that is right, Or what we can do is we can overwrite the older workbook with the new one.
First pull the latest from master and as you see a merge conflict overwrite the older one with new one.
Thanks.

Hi @v-prasadboke , I'm stuck, sorry! I tried following your steps with no avail. I can't seem to fix the merge conflict. Is there anything you could do on your end? Thanks!

Hello @AlexDeMichieli, I've resolved the merge conflicts. You can proceed with repackaging the solution.
Thank you.

Hi @v-prasadboke , thanks for the help!   Currently, the repository and topics filters are mutually exclusive, but not in a smart way. You'll need to deselect all repositories in order to activate the repo topics filter, but it's not ideal. Do you have any recommendations on how to improve this functionality?

Hello @AlexDeMichieli, We are having a discussion about this. And update you about the same before 04 September, 2023.
Meanwhile you can repackage the solution using V3 tool.
Thanks.

Hi @v-prasadboke , thanks for the help!  Currently, the repository and topics filters are mutually exclusive, but not in a smart way. You'll need to deselect all repositories in order to activate the repo topics filter, but it's not ideal. Do you have any recommendations on how to improve this functionality?

Hello @AlexDeMichieli, Sorry but for repo and topic I'm seeing only 1 option

Hello @AlexDeMichieli, Hope you are doing well. We just wanted to know if there are any updates on the above requested changes.
Thanks.

Hello @AlexDeMichieli, Please drop me a mail with attached json file.
<EMAIL_ADDRESS>Thanks.

Hello @AlexDeMichieli, I've received the json file. Will review it and update you about the same before 12 September, 2023.

Hello @AlexDeMichieli , Reason behind zip 3.0.0 even if repackaged to 3.0.1 is the latest 3.0.0 is not live yet.
I dont have the access to partner center where github solution can be pushed to live, If you have the access to the partner center please push the solution to live

Hello @AlexDeMichieli, Looks like you have not repackaged the solution properly.

Please Repackage the solution again properly.

Hi @v-prasadboke , I'll give it another shot and I'll let you know if I have any issues

Hello @AlexDeMichieli, Thank you for the updates.

Hello @AlexDeMichieli, The 3.0.0 of Github is live. You can repackage the solution with 3.0.1 Thanks

Hello @AlexDeMichieli, Hope the issue is resolved with 3.0.1 repackaging and you are repackaging it too. Just wanted to know some updates on the solution. Thanks.

Hello @AlexDeMichieli, Please confirm on the maintemplate.
Thanks.

Hello @AlexDeMichieli, Please confirm on the maintemplate. Thanks.

Hi Prasad, I'll be back to the office next Tuesday. Thanks so much for repackaging the solution! I just wanted to confirm the next steps. Can I pull from the branch, get the mainTemplate.json and publish it?

Hello @AlexDeMichieli, Review is not completed yet. I was waiting for your confirmation on maintemplate. Is it ok or not?
I'll review the maintemplate and get it merged.
Please keep the solution on hold for publishing.

Hi @v-prasadboke , the maintemplate looks fine to me! Thanks!

Thank you @AlexDeMichieli for confirmation.

Hi @v-prasadboke, what would be the next step? Thanks!


EnableRateLimiting does nothing on a RazorPage method

When I place the EnableRateLimitingAttribute on the RazorPage class, the rate limiter is respected. When I only place it on a Post method of the RazorPage, the rate limiter is ignored.
This works:
[AllowAnonymous]
[EnableRateLimiting(RateLimitingPolicies.PasswordResetPolicy)]
public class PasswordForgotModel : PageModel
{
   public async Task<IActionResult> OnPostAsync(string? returnUrl = null, CancellationToken cancellationToken = default)
   // ...
}

This doesn't
[AllowAnonymous]
public class PasswordForgotModel : PageModel
{
   [EnableRateLimiting(RateLimitingPolicies.PasswordResetPolicy)]
   public async Task<IActionResult> OnPostAsync(string? returnUrl = null, CancellationToken cancellationToken = default)
   // ...
}

There are no specifics in the documentation other than "The same rules apply to Razor Pages". So how can we enable ratelimiting on the POST of a razor page and not on the GET via the attribute?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: bb96b20f-0991-d6de-4d98-192cd469460f
Version Independent ID: bb96b20f-0991-d6de-4d98-192cd469460f
Content: Rate limiting middleware in ASP.NET Core
Content Source: aspnetcore/performance/rate-limit.md
Product: aspnet-core
Technology: aspnetcore-performance
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

@theo-albers filters can't be apply to  Razor Page handlers, see Authorize attribute and Razor Page
I'll get this documented.
@wtgodbe  or @BrennanConroy  will correct me if I'm wrong.

Ah, OK, it's not clear those filters are used by reading the docs. Of course you can't repeat all requirements here, but a small pointer here would be useful.

Maybe it's also worth mentioning that adding a named ratelimiter attribute requires the ratelimiter to exist. There will be a runtime exception at the page with the attribute when the rate limiter doesn't exist.

Maybe it's also worth mentioning that adding a named ratelimiter attribute requires the ratelimiter to exist. There will be a runtime exception at the page with the attribute when the rate limiter doesn't exist.

Great error message.


Legend text overlaps and alignment is thrown off when font size is changed

Can you add better handling of different font sizes for legend text? From what I can tell, the calculation for position of each legend item is based off of a fixed height/width or something. When I change the font size of the ".c3-legend-item text" the different legend items overlap each-other along the X axis and the height is not recalculated to vertically align the color-chip with the vertical center of the text.
Thanks and great project!

+1

Hi @guywithcrookedface! That is indeed a bug! Marking as such!

Sweet, thanks @aendrew

Yeah, need that feature also. It would be great if i just manual can trigger to recalculate hights of the fonts etc.
i had two pie charts with :
CSS:
.pie1 .chart .c3-legend-item {
font-size:4vh;
}
.pie2 .chart .c3-legend-item  {
fontz-size:1vh;
}
The fonts sure have different sizes, but the text-box is calculated like the initial font-size was set from the c3.css (12px) .
a fix would be great


refactor(kalman_filter): prefix package and namespace with autoware

Description
prefix package and namespace with autoware
Related links
Parent Issue:

Link https://github.com/autowarefoundation/autoware/issues/4569

How was this PR tested?
Notes for reviewers
None.
Interface changes
None.

Effects on system behavior
None.

Back to draft to fix the issue in https://github.com/autowarefoundation/autoware.universe/pull/7787#discussion_r1663650652

@SakodaShintaro @technolojin fixed in 8b607239ca1d2975aea0cd3b1e91ae4f2ed7676f

@manato @YoshiRi Could you review this pull-request?

@esteve Could you resolve the conflicts?

@Motsu-san fixed

I think we need approve from each components maintainers.

Sensing: @manato
Planning/Control: @TakaHoribe
Architect: @yukkysaito

Hi, could you approve this PR? We have already checked this PR.

@kminoda @yukkysaito
It seems that we need a code owner review for this PR.


Explore players from club

At the moment, we are able to explore duplicate items and items in the transfer list, but we aren't able to explore the players that we have on the club.

Sorry, just seeing this now! Been busy with college stuff. I'll try to look into this as soon as I can. Thanks.

Sorry it took so long, busy times for me. But I just pushed this feature. Check out the ClubSearchQuery class and read the comments in the class to understand how to use some of the properties. Once you've constructed your query, you can pass it into QueryClubAsync.
Closing this for now, but if you run into any issues with the class feel free to let me know here.

Thanks for the new feature, it will be very helpful for me.


[impex] header colum parser replaces all strings

The header colum parser currently removes all spaces. This leads to corrupted modifier values (like date formats for the date resolvers)

fixed in develop


feat: add replace and replace_strict

What type of PR is this? (check all applicable)

[ ] 💾 Refactor
[ ] ✨ Feature
[ ] 🐛 Bug Fix
[ ] 🔧 Optimization
[ ] 📝 Documentation
[ ] ✅ Test
[ ] 🐳 Other

Related issues

Related issue #
Closes #

Checklist

[ ] Code follows style guide (ruff)
[ ] Tests added
[ ] Documented the changes

If you have comments or can explain your changes, please do so below.

thanks @EdAbati for your review!
i've removed replace for now, we can address it later, replace_strict is more needed for the Plotly PR
I've also rewritten the signature to align it with the Polars args old and new instead of mapping - it's also a bit more concise to do
nw.col(col).replace_strict(order, range(len(order)))

than
nw.col(col).replace_strict({key: i for i, key in enumerate(order)})

Excellent comments, thanks both for reviews! 🙏
i've amended the error message so now it shows something like:
ValueError: replace_strict did not replace all non-null values.

The following did not get replaced: ['cd']


Docs: Add release notes

Testing: make docs
@ebd2 @akshatnair
Also, @ebd2 after this is in could you add release notes and also update the documentation for the slider stuff and mode switching that you've added.

Looks good % comments


Code formatting

For consistency reason, I have committed .vscode/settings.json file (what VSCode calls "workspace settings"). I hope everyone uses VSCode but if not then let's discuss on Discord what you use and how to keep it consistent.
You may wonder -- the code format settings are actually not in the file because it's pretty much the default settings. The other settings in the file came from Invenia's BlueStyle.
I have opened every Julia file and hit Save button to reformat everything. All changes are already in this PR.

I guess I ran into the same problems as in #115
Filed some bugs against DocumentFormat.jl;

https://github.com/julia-vscode/DocumentFormat.jl/issues/140
https://github.com/julia-vscode/DocumentFormat.jl/issues/141

Closing this PR in favor of using JuliaFormatter.jl


Revert default in-memory for small datasets

Users are reporting issues and confusion about setting default in-memory to True for small datasets.
We see 2 clear use cases of Datasets:

the "canonical" way, where you can work with very large datasets, as they are memory-mapped and cached (after every transformation)
some edge cases (speed benchmarks, interactive/exploratory analysis,...), where default in-memory can explicitly be enabled, and no caching will be done

After discussing with @lhoestq we have agreed to:

revert this feature (implemented in #2182)
explain in the docs how to optimize speed/performance by setting default in-memory

cc: @stas00 https://github.com/huggingface/datasets/pull/2409#issuecomment-856210552

cc: @krandiash (pinged in reverted PR).


Suggestion: use status bar background color API

https://code.visualstudio.com/updates/v1_53#_status-bar-entry-background-color-api

Nice, I did not know about that!

Will be included in the next release:


Unable to find service broadlink/send

Hi. I'm getting an error with SmartIR.
Device : Broadlink RM Mini 3
Home Assistant version : 0.112.0.dev20200605
Installed by copying SmartIR to custom_components. Yaml Config are as follows : -
smartir:
check_updates: false
remote:

platform: broadlink
host: <IP_ADDRESS>
mac: c8-f7-42-f5-f5-fd   # i also tried 'c8:f7:42:f5:f5:fd' format.

climate:

platform: smartir
name: Master Bedroom Air Conditioner
unique_id: MBr_AC
device_code: 1020
controller_data: <IP_ADDRESS>
temperature_sensor: sensor.temperature
humidity_sensor: sensor.humidity
power_sensor: binary_sensor.ac_power

Error :
Log Details (ERROR)
Logger: custom_components.smartir.climate
Source: core.py:1218
Integration: SmartIR (documentation)
First occurred: 11:12:53 AM (2 occurrences)
Last logged: 11:12:54 AM
Unable to find service broadlink/send
Traceback (most recent call last):
File "/config/custom_components/smartir/climate.py", line 338, in send_command
self._commands[operation_mode][fan_mode][target_temperature])
File "/config/custom_components/smartir/controller.py", line 93, in send
'broadlink', 'send', service_data)
File "/usr/src/homeassistant/homeassistant/core.py", line 1218, in async_call
raise ServiceNotFound(domain, service) from None
homeassistant.exceptions.ServiceNotFound: Unable to find service broadlink/send
Home Assistant has started!
Full HA Logs
2020-06-08 11:11:59 WARNING (MainThread) [homeassistant.loader] You are using a custom integration for sonoff which has not been tested by Home Assistant. This component might cause stability problems, be sure to disable it if you experience issues with Home Assistant.
2020-06-08 11:11:59 WARNING (MainThread) [homeassistant.loader] You are using a custom integration for smartir which has not been tested by Home Assistant. This component might cause stability problems, be sure to disable it if you experience issues with Home Assistant.
2020-06-08 11:12:53 ERROR (MainThread) [custom_components.smartir.climate] Unable to find service broadlink/send
Traceback (most recent call last):
File "/config/custom_components/smartir/climate.py", line 338, in send_command
self._commands[operation_mode][fan_mode][target_temperature])
File "/config/custom_components/smartir/controller.py", line 93, in send
'broadlink', 'send', service_data)
File "/usr/src/homeassistant/homeassistant/core.py", line 1218, in async_call
raise ServiceNotFound(domain, service) from None
homeassistant.exceptions.ServiceNotFound: Unable to find service broadlink/send
2020-06-08 11:12:54 ERROR (MainThread) [custom_components.smartir.climate] Unable to find service broadlink/send
Traceback (most recent call last):
File "/config/custom_components/smartir/climate.py", line 330, in send_command
await self._controller.send(self._commands['off'])
File "/config/custom_components/smartir/controller.py", line 93, in send
'broadlink', 'send', service_data)
File "/usr/src/homeassistant/homeassistant/core.py", line 1218, in async_call
raise ServiceNotFound(domain, service) from None
homeassistant.exceptions.ServiceNotFound: Unable to find service broadlink/send
2020-06-08 11:14:29 ERROR (MainThread) [custom_components.smartir.climate] Unable to find service broadlink/send
Traceback (most recent call last):
File "/config/custom_components/smartir/climate.py", line 338, in send_command
self._commands[operation_mode][fan_mode][target_temperature])
File "/config/custom_components/smartir/controller.py", line 93, in send
'broadlink', 'send', service_data)
File "/usr/src/homeassistant/homeassistant/core.py", line 1218, in async_call
raise ServiceNotFound(domain, service) from None
homeassistant.exceptions.ServiceNotFound: Unable to find service broadlink/send
2020-06-08 11:14:30 ERROR (MainThread) [custom_components.smartir.climate] Unable to find service broadlink/send
Traceback (most recent call last):
File "/config/custom_components/smartir/climate.py", line 330, in send_command
await self._controller.send(self._commands['off'])
File "/config/custom_components/smartir/controller.py", line 93, in send
'broadlink', 'send', service_data)
File "/usr/src/homeassistant/homeassistant/core.py", line 1218, in async_call
raise ServiceNotFound(domain, service) from None
homeassistant.exceptions.ServiceNotFound: Unable to find service broadlink/send

sorry. my mistake. was using the wrong ip address. I cant seem to delete. so will close it.


Is it possible to download file from app cache using Download Manager

I'm doing POST api call, send data
And receive from backend file(base64) pdf
If I use Download Manager in config = receive an error 16
Mb there is solution to save this file inside cache and  after that to download to user folder ?
const res = await RNFetchBlob.config({
      addAndroidDownloads: {
        useDownloadManager: true,
      },
    }).fetch(
      'POST',
      url,
      {
        'Transfer-Encoding': 'Chunked',
        'access-token': token || '',
        'Content-Type': 'application/json',
      },
      JSON.stringify({
        type: 'daily',
        createdDateStart: moment(createdTime).format('YYYY-MM-DD'),
        fileType: 'pdf',
      }),
    )

error message: " Error: Download manager failed to download from  https:... Status Code = 16 "

Please provide a complete error log

Please provide a complete error log

Error: Download manager failed to download from  https.... Status Code = 16

Probably your application can't reach the URL that you want to get file, check the URL and all headers and params that you are passing.

You can download it to file cache and then use the media store API to move it in the downloads, sure.
But that won't resolve issues with the download if these are on server side


refac revocation txs signature panel

the process of signing the emergency tx, unvault emergency tx and cancel tx is not clear both in the code and for the user.
The user do not understand what to do and tabs are not clickable.
to fix this:

list revocation txs with a disclaimer "sign this three txs"
each revocation tx has its own state with a SignState attached

this certainly will be fixed in the same time with the external signer interface


[Fix] Clean code for resnet application @open sesame 04/26 10:15

fix typo
Use const for catched exception
use EXIT_SUCCESS macro
use error code

Signed-off-by: Jiho Chu<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #1888. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

:octocat: cibot: @jihochu, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/1888-202204211212020.97520089149475-36ca7fefef5a063100d666818272fafa97940a39/.

Could check the https://github.com/nnstreamer/nntrainer/blob/main/docs/contributing.md and use clang-format?

:octocat: cibot: @jihochu, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/1888-202204211738560.58169198036194-f2cff48c7105b2e07de09aa920cd15df705a4f1e/.

:octocat: cibot: @jihochu, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/1888-202204211824240.38645696640015-559ab54c5cbd7eb3d14404303b74139a5d32e6ec/.

:octocat: cibot: @jihochu, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/1888-202204261014400.11114501953125-559ab54c5cbd7eb3d14404303b74139a5d32e6ec/.

because of the ci server url issue, you need the rebase the main branch which includes the fix.


[Question] pydantic from pip instead apt?

Would it be possible to change pydantic from apt to pip for every ubuntu distro? apt version got stuck in an older version and it's not being updated.
https://github.com/ros/rosdistro/blob/0fb47463146b75e74481fb5c1a82709d6e2c7af9/rosdep/python.yaml#L7822-L7835

Would it be possible to change pydantic from apt to pip for every ubuntu distro? apt version got stuck in an older version and it's not being updated.

No, because then we can't actually release packages that depend on pydantic onto the buildfarm (only packages that come from packages can be used on the buildfarm).
I think the best bet is to open an issue on the upstream Debian package and see if we can get some movement on it, which will eventually filter down into Ubuntu.
Because there is nothing to do here, I'm going to close this out.


Add some Mac OS X suggestions

I got dtdump to compile on Mac OS 10.6.8 without too much difficulty, and it works well with nice -20. Thank you!

@droelfdroelf gentle ping :)


yarn:lint not catching some test "warnings" which should actually be "errors"

Example: this shouldn't be an arrow function
Needs investigating.

Many libraries still use the only-warn plugin, unfortunately. Closing in favor of https://github.com/microsoft/botbuilder-js/issues/2745.

Oh yeah, we talked about that.

All good! It's confusing to say the least.


Xresources in readme

I extracted the colors for neovim terminal emulator and put them in the README for simplicity.
I think that having just 1 Xresources file and providing ways to convert the files (I only know this website, if there are better/other I'd be happy to know them) is easier than maintaining different repositories with all configurations.

Thank you for the pull request!
terminal.sexy looks nice! I added some changes (used Gist for .Xresources etc.) and merged it.


Restructure for compatibility with ArduinoIDE & PlatformIO

Arduino IDE and PlatformIO both have specific requirements the structure of a library, so that sketches and other source files are properly compiled.
The Arduino IDE and PlatformIO Part 1: How to structure a project to be compiled by both blog post describes why putting header and source files in the src directory and .ino sketches in the examples directory is necessary. They provide the following example project as a summary:
senseAndUpload/
├── examples/
|   ├── exampleWifi/
|   │   └── exampleWifi.ino
|   └── exampleNBIoT/
|       └── exampleNBIoT.ino
└── src/
  ├── device/
  |   └── sensor.h
  └── networking/
      ├── nbiot.h
      └── wifi.h

NOTE that as we move or rename files, it is important to use the git mv command to preserve git history. For details and examples, see https://www.educative.io/answers/how-to-rename-or-move-files-in-git.

A suggested structure for this project might be:
senseAndUpload/
├── examples/
|   ├── getValuesCO2/
|   │   └── getValuesCO2
|   └── getValuesModularSensors/
|       └── getValuesModularSensors.ino
|   └── runSoilDevice/
|       └── runSoilDevice.ino
└── src/
  ├── main.h
  ├── sensors/
  |   ├── co2_sensor.h
  |   └── co2_sensor.cpp
  └── soilDevice/
      ├── soilDevice.h
      └── soilDevice.cpp

Maybe model a little bit like https://github.com/EnviroDIY/KellerModbus?
I'll look for another example.

Completed with PR:

#19


Rewrite custom require hook & source map tests

This is a rewrite of the source map tests so I can add the test coverage required in #66. This necessitated replacing the Babel test with a better one for generic custom require hooks.
This uses a new npm package named source-map-fixtures. It provides a few source files with different source map variants, making it easier to generate fixtures. I'm planning on updating the source map tests in AVA as well.
I've solved the problem of generating coverage reports for testing by adding a _generateCoverage script in test/fixtures. It generates a report for the source map fixtures.
And finally I've excluded the two tests from the coverage report. Seemed silly to get missing test coverage for the tests…

\o/ this is looking great, and is very much appreciated. let me know when you need a thorough review.

@bcoe I'm finished with this now, thanks.

The tests run way faster without the babel step, this is great.


filtered due to its short length

How to retain sequences below 1000bp in centrifuger-build?
Especially for the viral sequences, it is best to preserve those that are above 500 bp.

Yes, some abnormal intervals have already been masked.

Now there is another question I want to ask: Approximately how long does it take to build a centrifuger index with 200Gbp of data?  I have already submitted the task to run for 16 hours, and it's still not finished.

That could take a few days. How many threads do you give it, and how much memory do you have?

16 threads  and 500G memory

Then you may try to run centrifuger-build with the option "-t 16 --build-mem 400G", which might make it faster in the end. Nevertheless, I think it will still take a few days. This is one of the drawbacks of FM index :(..

Hi @yi1873 , just want to follow up on the progress of the indexing building. Is it still running? Does it output something like extract XXX chunks?


answered questions related to git and version control

Answered all questions, no merge conflicts. Ready to launch.


NodeJS Wrapper and demo for Procupine

Expected behavior
Javascript API to initialize/start wake word engine with an example to run in NodeJS

is this a feature request?

Yes, it is

the best way to go about it is to do it yourself. if the code is good I can possibly merge it back in.

@kenarsa I'd like to work on this task if it's still welcome. Can you re-open the ticket please? that way I can reference it when I send a PR

also, I'd like to publish this as an npm module, if that's ok with you

@mreinstein here's a node.js add on one a different repo:
https://github.com/alexmoon/pv-porcupine
and browser add-on here:
https://github.com/jaxcore/bumblebee-hotword/
We'd really appreciate it if you could send a PR to add these capabilities inside the main Porcupine repo

Just a note, you can't use pv-porcupine  as is, there are a couple of issues(already described here , but looks like repo is not maintained).
I was able to workaround with few fixes in their source code

@dmytrobr cool! Yeah, that's why it would be good to have a wrapper inside the main repo as it will be maintained up-to-date then.

I've got a version on my local machine that almost works. I'm able to load the wasm module, and pipe the audio from a microphone stream to it. It's not detecting keywords yet, probably passing data in the wrong format.
Question, do you know what endianness is expected in the input data?

Here's what I've got so far: https://pastebin.com/sSsVZfq2
This runs without error, but I never actually see any keywords being identified. I'm using the mic module to pass 16 bit, signed int, little endian, 1 channel pcm directly to porcupine's process(data) call. I'm wondering if I need some of the logic from https://github.com/Picovoice/Porcupine/blob/master/demo/js/picovoiceAudioManager.js#L18-L44
(I say some because it looks like that logic does some format conversion to go from what the browser web audio api produces into int16, 16 bit values that porcupine understands, + some sample rate conversion logic, + some logic to send the right amount of data to porcupine using engine.frameLength.
Any ideas/suggestions/help would be greatly appreciated. I think this is close to working!

whats the sampling rate? It needs to be 16K. Also, each frame needs to have frameLength samples. If still doesn't work might be good to store audio when passed to engine into a WAV file to make sure it sounds ok. hope it helps.

I believe I'm matching what porcupine needs (see https://github.com/mreinstein/node-porcupine/blob/master/index.js#L68-L72 )
other possibilities:

maybe this is a bit of logic to grab? https://github.com/alexmoon/pv-porcupine/blob/master/index.ts#L96 looks like it handles some of the node buffer handling stuff
is it possible my keywordIDs array has bad/wrong/outdated data?

yup. that looks good.

donno about this repo really. the author can possibly help more.
not likely. if there is bad data there the initialization would fail.

Well I've tried numerous things, and I cannot seem to get node/wasm porcupine to recognize anything.
I've tried both 1.5 and 1.6 versions of the library with various settings. While it doesn't crash, I also don't see any keywords actually being recognized engine.process(data) just always returns -1.
I'm out of ideas at the moment. :-/

@dmytrobr seems to have it working somehow. Can you help?

We made npm packages for recording audio and feeding it into porcupine. these are for running within the browser but should help as a reference for a node implementation.
https://github.com/Picovoice/web-voice-processor
https://github.com/Picovoice/Porcupine/tree/master/binding/js/porcupine_manager

I managed to figure out how to do this and published a new nodejs package that re-wraps the porcupine libraries along with microphone recording and the correct processing:
https://github.com/jaxcore/bumblebee-hotword-node
I included 2 examples showing how to record from the microphone and stream into Porcupine and it works really, really well.  The newest version Porcupine works amazingly well!


WebGL2 vertex array objects

That should make scenes with many objects run faster due to reduced API overhead.
Before merge, please test it on various devices.
Also tried implementing VAO using WebGL1 extension, but that didn't work out, because there was no way to specify the attribute layout.
No new API, should just work. Tested on a lot of projects and editor, but only on my PC.

Actually gives too many compatibility problems for a tiny perf benefit - doesn't worth it.


Support "tool" role in messages

What are you trying to do?
The new Herme 2 Pro model recommends results from function calling to come in messages with the role "tool", eg:
<|im_start|>tool
<tool_response>...result here...</tool_response>
<|im_end|>

The chat api doesn't support messages with a role "tool" - treats it as a bad request.
How should we solve this?
Accepting the "tool" role in messages API would make life easier for those using Hermes Pro - and any future models that are likely to be based off the same open data sets.
This has implications for how templating works in Ollama - it may even require a total rethink of templates.
What is the impact of not solving this?
Not solving it means that users have to create their own templates and use Ollama's raw option, which negates some of the joy of using Ollama in the first place.
I truly believe function calling and building local agents is one area where Ollama really could excel, if the experience of doing so is made totally painless.
Anything else?
Repo of Hermes Pro function calling with prompting/templating instructions:
https://github.com/NousResearch/Hermes-Function-Calling

You will probably also need the assistant_tool_call role for support JSON-mode response:
<|im start|>assistant
<tool_call>...requested tools here...</tool_call>
<|im_end|>

JSON-mode for <|im_start|>assistant<tool_call>... support is also needed.

JSON-mode support for <|im_start|>assistant<tool_call>... is also needed.

This is also needed for a cleaner implementation within langchain.
Currently ChatOllama doesn't support handling ToolMessage which is of type tool.
In order to work around this, within OllamaFunctions (a tool calling compatible subclass of ChatOllama) we pass ToolMessage as type assistant.

From what I can see, this issue has been fixed in https://github.com/ollama/ollama/pull/5284.

Yep, as of 0.8.2 Ollama supports the TOOL message role as well.
Unfortunately it doesn't support streaming function calling yet

Hi there! Tools are now supported in Ollama. See https://ollama.com/blog/tool-support


Removing time import from FR

Linked issue(s):
Removed import time from FR example.
What change does this PR introduce and why?
Please check if the PR fulfills these requirements

[ ] Include reference to internal ticket and/or GitHub issue "Fixes #NNNN" (if applicable)
[ ] Relevant tests for the changes have been added
[ ] Relevant docs have been added / updated

Two tips:

Always include an informative title for your PRs
Rebase off of trunk to clean up the commit history — looks like this PR only adds a few commits over top of #329. Only those commits should be reflected in this PR

Moved to #335


Creating BSC safe gets stuck on "Loading your safe.."

Description
Creating a BSC safe gets stuck on the final stage after pressing the button "Get Started", showing "Loading your safe". I've waited for too long (5-10m) with different wallets and different browsers.
Environment

Browser: Chrome, Safari
Wallet: MetaMask
Safe: ??
Environment:

BSC (mainnet)

Steps to reproduce

Connect wallet
Select BSC network
Continue until end
"Create"
"Get Started

Expected result
Navigate to safe.
Obtained result
"Loading your safe".
Screenshots

There are indexing issues related to rate limiting applied by binance. I will close this issues as this is unrelated to the Safe web interface.


Fix transactions not being rolled back when the individual statements succeed, but the committing the transaction fails.

This can happen e.g. when using deferred foreign keys (as seen in the tests), or when accessing the database from multiple processes, causing a commit to fail with an "database is busy" error.

I have merged the latest changes and all tests pass for me. Could you please have a look at this pull request?

merged into release branch


Updated dependency on strobe-rs to 0.5

The strobe-rs API as of 0.5 is pretty much identical to the one exposed in strobe.rs here.

Thanks!


[GROW-3262] add repr to RedisCluster objects

Pull Request check-list
Please make sure to review and check all of these items:

[ ] Does $ tox pass with this change (including linting)?
[ ] Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
[ ] Is the new or changed code fully tested?
[ ] Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
[ ] Is there an example added to the examples folder (if applicable)?
[ ] Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
when looking through sentry, it's hard to debug redis-py related issues, because object is not represented well. This PR added __repr__ method to NodeCommands and PipelineCommand to show data on sentry
current:

with this PR:

Codecov Report
Patch coverage: 50.00% and project coverage change: -31.58% :warning:

Comparison is base (179891d) 92.37% compared to head (4754c5a) 60.80%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master      #15       +/-   ##
===========================================
- Coverage   92.37%   60.80%   -31.58%
===========================================
  Files         119      119
  Lines       30678    30681        +3
===========================================
- Hits        28340    18655     -9685
- Misses       2338    12026     +9688

Files Changed
Coverage Δ

redis/cluster.py
90.71% <50.00%> (-0.19%)
:arrow_down:

... and 82 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


fix(react-router): correctly set pathChanged in router events

fixes #2638

needs some tests

@merthanmerter not aware of such use cases, if they arise, we can still add it later.


Example chunk of code in README 'HxResponseTrigger' didn't working

// When we load our page, we will trigger any event listeners for "my-event.
async fn index() -> (&'static str, HxResponseTrigger) {
    (
        "Hello, world!",
        HxResponseTrigger::normal(["my-event", "second-event"]),
    )
}

error on here
        .route("/index", get(index))
 │     the trait bound `fn() -> impl std::future::Future<Output = (&'static str, axum_htmx::HxResponseTrigger)> {index}: axum::handler::Handler<_, _>` is not satisfied rustc (E0277) [15, 30]
 │      the following other types implement trait `axum::handler::Handler<T, S>`:
 │        <axum::handler::Layered<L, H, T, S> as axum::handler::Handler<T, S>>
 │        <axum::routing::MethodRouter<S> as axum::handler::Handler<(), S>>
 │     required by a bound introduced by this call rustc (E0277) [15, 26]

my dependencies
[dependencies]
axum = "0.7.2"
axum-htmx = "0.5.0"
serde = { version = "1", features = ["derive"] }
tokio = { version = "1", features = ["full"] }
tower-livereload = "0.9.1"

Hey, thanks for pointing this out.
This is because HxResponseTrigger only impls IntoResponseParts, and we need to pass that before the body.
I've updated the README with the correct code - I also made a note of this in the documentation!11
use axum_htmx::HxResponseTrigger;

async fn index() -> (HxResponseTrigger, &'static str) {
    (
        HxResponseTrigger::normal(["my-event", "second-event"]),
        "Hello, world!",
    )
}


fix: some export some const

If you do not export these consts, the third party developer have to rebuild these const.

不暴露出去的话push还得自己写参数，另外例程似乎忘记更新了，这里一并更新了

url不需要导出，改一下吧

Done


Allow bridge name to be passed in to interface bridge

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:
/kind bug
/kind enhancement

What happened:
Currently interface with bridge only allows default br1 to be defined in manifests. When messing around with adding a new network type e.g. a DevicePluginInterface the interface was set to type bridge and qemu added it to the vm under the default bridge name even though Plug() was empty for the interface definition.
What you expected to happen:
Be able to define custom bridge names.
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

KubeVirt version (use virtctl version):
Kubernetes version (use kubectl version):
VM or VMI specifications:
Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

/kind enhancement

@gageorsburn I'm currently working on issue #1329 - once it is fixed, there will be no conflicts between the bridge created for the device plugin and the one created for the pod network.
I plan to name the bridge: br1-<network name> so it is guaranteed not to conflict with the default name.

@yuvalif Thanks, I saw that issue get created after this one but that was essentially my goal. I'd love to help with the implementation in any way I can. I have a very specific use case that I'm trying to support.

@gageorsburn would be great if you can have a look here: https://github.com/kubevirt/kubevirt/pull/1342 and provide feedback. Mainly on whether this satisfy your case.

Closing because no longer relevant with multus instead of yuvalif's PR.


Cannot retrieve block from a previous access node

Problem
I'm trying to retrieve blocks from access-001.mainnet1.nodes.onflow.org:9000.
Everything goes well until I reach this height 7652359. At this height and the following the api return a Not found error.
If I use a previous version of the cli, I'm able to retrieve the block but not with the latest version (cf: screenshot below).
Steps to Reproduce
You can use two different version of the cli to reproduce the bug and see that it was working in version 1.3.3 of the cli and not in the version 1.3.4

Context
I need to retrieve transactions from those block.

This looks like it may be the same issue as this: https://github.com/onflow/flow-cli/issues/1160
A fix for that issue has been merged and will be out next release.


Can I use Client secret besides certificates for realizing app-only access for my Azure AD app?

I'm not able to access sharepoint online tenant using azure ad app with client secret , i'm getting 401 access denied message. But when i'm trying with certificate i'm able to access the sharepoint tenant using my console app. Need suggestion.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e082eb56-fafb-9ef7-fadb-e0b90f5369a9
Version Independent ID: 0f1a3528-3615-5722-2352-a1ad4622c244
Content: Granting access via Azure AD App-Only
Content Source: docs/solution-guidance/security-apponly-azuread.md
Product: sharepoint
GitHub Login: @spdevdocs
Microsoft Alias: spdevdocs

Can you confirm what auth flow you are using to authenticate with Azure AD to obtain a token and how you are accessing the SharePoint? SharePoint CSOM/REST, Microsoft Graph API, etc?
It sounds like the Azure AD application using the client credentials via the app-only flow but need to confirm...

The FAQ at the bottom states the following:
"Q: Can I use other means besides certificates for realizing app-only access for my Azure AD app?
A: No, all other options are blocked by SharePoint Online and will result in an Access Denied message."

Thanks @andrewconnell :- We use Client grand Auth flow using CSOM classes to obtain token with certificate and without certificate. But we are successfully able to connect with the token provided cetificate only, others giving 401 error.


process-user-data: create generic file provider for userdata

The docker provider currently looks up a certain path to find a user data file. We can generalize this to use it also for config disks.
In mkosi the process-user-data service has a soft dependency on a mount unit that will mount a confidisk with the label "cidata". the service can then consume the userdata from the mount point.
This will enable mkosi x86_64 images to work on libvirt unmodified.

FYI my test run that uses this rather than initdata is failing: https://github.com/stevenhorsman/cloud-api-adaptor/actions/runs/12071315597/job/33663455543 and it looks like pull image is going wrong. I will try and debug this locally to see if I can work out what's happening with daemon.json etc

FYI my test run that uses this rather than initdata is failing: https://github.com/stevenhorsman/cloud-api-adaptor/actions/runs/12071315597/job/33663455543 and it looks like pull image is going wrong. I will try and debug this locally to see if I can work out what's happening with daemon.json etc

yes, I can see the same on azure:
CreateContainer fails: rpc error: code = Internal desc = failed to pull manifest error sending request for url (https://index.docker.io/v2/library/nginx/manifests/sha256:e56797eab4a5300158cc015296229e13a390f82bfc88803f45b08912fd5e3348)

Stack backtrace:
   0: anyhow::kind::Adhoc::new
   1: image_rs::image::ImageClient::pull_image::{{closure}}.14396
   2: <kata_agent::storage::image_pull_handler::ImagePullHandler as kata_agent::storage::StorageHandler>::create_device::{{closure}}

Yeah, I saw a few tests that passed too. Sorry for the lack of debug info, my test VM's kcli seems to be on strike:
# sudo kcli create pool -p /var/lib/libvirt/images default
Creating pool default...
Pool default already there.Leaving...
# kcli download image ubuntu2204
Grabbing image ubuntu2204 from url https://cloud-images.ubuntu.com/releases/22.04/release/ubuntu-22.04-server-cloudimg-amd64.img
Image ubuntu2204 not Added because Pool default not found

so I'm setting up a new test env, which means a new mkosi image build with a different ssh key, so I might not have much usefulness tonight!

This might be user error, but when logging into the VM I'm seeing:
[root@fedora ~]# ls /run/peerpod
policy.rego
[root@fedora ~]# journalctl -u process-user-data
Nov 29 10:54:38 fedora process-user-data[431]: 2024/11/29 10:54:38 [userdata/provision] unsupported user data provider, we extract and calculate initdata hash only.
Nov 29 10:54:38 fedora process-user-data[431]: 2024/11/29 10:54:38 [userdata/provision] File /run/peerpod/initdata not found, skipped initdata processing.
Nov 29 10:54:38 fedora bash[469]: cat: /run/peerpod/initdata.digest: No such file or directory
Nov 29 10:54:38 fedora bash[462]: ERROR: Algorithm "sha256" expects a size of 32 bytes, got: 0
Nov 29 10:54:38 fedora bash[517]: cat: /run/peerpod/initdata.digest: No such file or directory
Nov 29 10:54:38 fedora bash[515]: ERROR: Algorithm "sha384" expects a size of 48 bytes, got: 0
Nov 29 10:54:38 fedora systemd[1]: Finished process-user-data.service - Process user data.

This might be user error, but when logging into the VM I'm seeing:
[root@fedora ~]# ls /run/peerpod
policy.rego
[root@fedora ~]# journalctl -u process-user-data
Nov 29 10:54:38 fedora process-user-data[431]: 2024/11/29 10:54:38 [userdata/provision] unsupported user data provider, we extract and calculate initdata hash only.
Nov 29 10:54:38 fedora process-user-data[431]: 2024/11/29 10:54:38 [userdata/provision] File /run/peerpod/initdata not found, skipped initdata processing.
Nov 29 10:54:38 fedora bash[469]: cat: /run/peerpod/initdata.digest: No such file or directory
Nov 29 10:54:38 fedora bash[462]: ERROR: Algorithm "sha256" expects a size of 32 bytes, got: 0
Nov 29 10:54:38 fedora bash[517]: cat: /run/peerpod/initdata.digest: No such file or directory
Nov 29 10:54:38 fedora bash[515]: ERROR: Algorithm "sha384" expects a size of 48 bytes, got: 0
Nov 29 10:54:38 fedora systemd[1]: Finished process-user-data.service - Process user data.
[root@fedora ~]# ls /run/media/cidata/user-data
/run/media/cidata/user-data

yeah, this is not pretty, but not an error, i think. it tries to measure initdata.digest as a non-criticial post-execution step, even if it's not present. I didn't invest too much into it, since attestation-agent was supposed to handle that in the near future. but we can probably do something like a path watcher that will trigger only if /run/peerpod/initdata.digest is written

Sorry, I'm not too worried about the initdata message, just posting the full log. I think the unsupported user data provider bit and lack of daemon.json is the key point which suggests to me that the FileUserDataProvider isn't being created?

Sorry, I'm not too worried about the initdata message, just posting the full log. I think the unsupported user data provider bit and lack of daemon.json is the key point which suggests to me that the FileUserDataProvider isn't being created?

oh. yes, good catch. this means that /run/media/cidata/user-data does not exist, can you confirm?

Sorry, I'm not too worried about the initdata message, just posting the full log. I think the unsupported user data provider bit and lack of daemon.json is the key point which suggests to me that the FileUserDataProvider isn't being created?

oh. yes, good catch. this means that /run/media/cidata/user-data does not exist, can you confirm?

It does:
# cat //run/media/cidata/user-data
#cloud-config

write_files:
  - path: /run/peerpod/agent-config.toml
    content: |
      server_addr = 'unix:///run/kata-containers/agent.sock'
      guest_components_procs = 'none'
      image_registry_auth = 'file:///run/peerpod/auth.json'
  - path: /run/peerpod/daemon.json
    content: |
      {

that's why I think it might be user error here. I'm doing a build with some debug added to pud to try and check I'm even using the correct version of code...

Sorry, I'm not too worried about the initdata message, just posting the full log. I think the unsupported user data provider bit and lack of daemon.json is the key point which suggests to me that the FileUserDataProvider isn't being created?

oh. yes, good catch. this means that /run/media/cidata/user-data does not exist, can you confirm?

It does:
# cat //run/media/cidata/user-data
#cloud-config

write_files:
  - path: /run/peerpod/agent-config.toml
    content: |
      server_addr = 'unix:///run/kata-containers/agent.sock'
      guest_components_procs = 'none'
      image_registry_auth = 'file:///run/peerpod/auth.json'
  - path: /run/peerpod/daemon.json
    content: |
      {

that's why I think it might be user error here. I'm doing a build with some debug added to pud to try and check I'm even using the correct version of code...

if it is present then it's maybe a race condition. Can you restart the process-user-data unit to see whether it picks up the file?
or compare the timestamps of the logs unit and the process-user-data unit?

Ok, so after rebuilding everything with my dodgy debug I have some more results:

Runs 1 & 2 worked and created the pod correctly:

[root@fedora ~]# ls /run/peerpod
agent-config.toml  auth.json  daemon.json  policy.rego
[root@fedora ~]# journalctl -u process-user-data
Nov 29 13:52:21 fedora systemd[1]: Starting process-user-data.service - Process user data...
Nov 29 13:52:21 fedora process-user-data[536]: Looking for /run/media/cidata/user-data, err: &v%!(EXTRA <nil>)2024/11/29 13:52:21 [userdata/provision] HasUserDataFile
Nov 29 13:52:21 fedora process-user-data[536]: 2024/11/29 13:52:21 [userdata/provision] provider: File, userDataPath: /run/media/cidata/user-data
Nov 29 13:52:21 fedora process-user-data[536]: 2024/11/29 13:52:21 [userdata/provision] Wrote /run/peerpod/agent-config.toml
Nov 29 13:52:21 fedora process-user-data[536]: 2024/11/29 13:52:21 [userdata/provision] Wrote /run/peerpod/daemon.json
Nov 29 13:52:21 fedora process-user-data[536]: 2024/11/29 13:52:21 [userdata/provision] Wrote /run/peerpod/auth.json
Nov 29 13:52:21 fedora process-user-data[536]: 2024/11/29 13:52:21 [userdata/provision] File /run/peerpod/initdata not found, skipped initdata processing.
Nov 29 13:52:21 fedora bash[564]: cat: /run/peerpod/initdata.digest: No such file or directory
Nov 29 13:52:22 fedora bash[560]: ERROR: Algorithm "sha256" expects a size of 32 bytes, got: 0
Nov 29 13:52:22 fedora bash[643]: cat: /run/peerpod/initdata.digest: No such file or directory
Nov 29 13:52:22 fedora bash[632]: ERROR: Algorithm "sha384" expects a size of 48 bytes, got: 0
Nov 29 13:52:22 fedora systemd[1]: Finished process-user-data.service - Process user data.
[root@fedora ~]# cat /run/media/cidata/user-data
#cloud-config

write_files:
  - path: /run/peerpod/agent-config.toml
    content: |

Run 3 failed and it looks like /run/media/cidata/user-data was completely missing there:

[root@fedora ~]# ls /run/peerpod
policy.rego
[root@fedora ~]# journalctl -u process-user-data
Nov 29 13:46:11 fedora systemd[1]: Starting process-user-data.service - Process user data...
Nov 29 13:46:11 fedora process-user-data[545]: Looking for /run/media/cidata/user-data, err: &v%!(EXTRA *fs.PathError=stat /run/media/cidata/user-data: no such file or directory)2024/1>
Nov 29 13:46:11 fedora process-user-data[545]: 2024/11/29 13:46:11 [userdata/provision] bunsupported user data provider, we extract and calculate initdata hash only.
Nov 29 13:46:11 fedora process-user-data[545]: 2024/11/29 13:46:11 [userdata/provision] File /run/peerpod/initdata not found, skipped initdata processing.
Nov 29 13:46:11 fedora bash[575]: cat: /run/peerpod/initdata.digest: No such file or directory
Nov 29 13:46:12 fedora bash[565]: ERROR: Algorithm "sha256" expects a size of 32 bytes, got: 0
Nov 29 13:46:12 fedora bash[645]: cat: /run/peerpod/initdata.digest: No such file or directory
Nov 29 13:46:12 fedora bash[639]: ERROR: Algorithm "sha384" expects a size of 48 bytes, got: 0
Nov 29 13:46:12 fedora systemd[1]: Finished process-user-data.service - Process user data.
[root@fedora ~]# ls /run/media/cidata/user-data
ls: cannot access '/run/media/cidata/user-data': No such file or directory

I retried ls /run/media/cidata/user-data for a few minutes until the vm got deleted and it never seemed to be written
I used exactly the same deployment and images for these runs, so I'm not sure why /run/media/cidata/user-data was written in two runs, but not the third, but this might explain why the CI tests pass sometimes and not others?

Ok, so after rebuilding everything with my dodgy debug I have some more results:

Runs 1 & 2 worked and created the pod correctly:

[root@fedora ~]# ls /run/peerpod
agent-config.toml  auth.json  daemon.json  policy.rego
[root@fedora ~]# journalctl -u process-user-data
Nov 29 13:52:21 fedora systemd[1]: Starting process-user-data.service - Process user data...
Nov 29 13:52:21 fedora process-user-data[536]: Looking for /run/media/cidata/user-data, err: &v%!(EXTRA <nil>)2024/11/29 13:52:21 [userdata/provision] HasUserDataFile
Nov 29 13:52:21 fedora process-user-data[536]: 2024/11/29 13:52:21 [userdata/provision] provider: File, userDataPath: /run/media/cidata/user-data
Nov 29 13:52:21 fedora process-user-data[536]: 2024/11/29 13:52:21 [userdata/provision] Wrote /run/peerpod/agent-config.toml
Nov 29 13:52:21 fedora process-user-data[536]: 2024/11/29 13:52:21 [userdata/provision] Wrote /run/peerpod/daemon.json
Nov 29 13:52:21 fedora process-user-data[536]: 2024/11/29 13:52:21 [userdata/provision] Wrote /run/peerpod/auth.json
Nov 29 13:52:21 fedora process-user-data[536]: 2024/11/29 13:52:21 [userdata/provision] File /run/peerpod/initdata not found, skipped initdata processing.
Nov 29 13:52:21 fedora bash[564]: cat: /run/peerpod/initdata.digest: No such file or directory
Nov 29 13:52:22 fedora bash[560]: ERROR: Algorithm "sha256" expects a size of 32 bytes, got: 0
Nov 29 13:52:22 fedora bash[643]: cat: /run/peerpod/initdata.digest: No such file or directory
Nov 29 13:52:22 fedora bash[632]: ERROR: Algorithm "sha384" expects a size of 48 bytes, got: 0
Nov 29 13:52:22 fedora systemd[1]: Finished process-user-data.service - Process user data.
[root@fedora ~]# cat /run/media/cidata/user-data
#cloud-config

write_files:
  - path: /run/peerpod/agent-config.toml
    content: |

Run 3 failed and it looks like /run/media/cidata/user-data was completely missing there:

[root@fedora ~]# ls /run/peerpod
policy.rego
[root@fedora ~]# journalctl -u process-user-data
Nov 29 13:46:11 fedora systemd[1]: Starting process-user-data.service - Process user data...
Nov 29 13:46:11 fedora process-user-data[545]: Looking for /run/media/cidata/user-data, err: &v%!(EXTRA *fs.PathError=stat /run/media/cidata/user-data: no such file or directory)2024/1>
Nov 29 13:46:11 fedora process-user-data[545]: 2024/11/29 13:46:11 [userdata/provision] bunsupported user data provider, we extract and calculate initdata hash only.
Nov 29 13:46:11 fedora process-user-data[545]: 2024/11/29 13:46:11 [userdata/provision] File /run/peerpod/initdata not found, skipped initdata processing.
Nov 29 13:46:11 fedora bash[575]: cat: /run/peerpod/initdata.digest: No such file or directory
Nov 29 13:46:12 fedora bash[565]: ERROR: Algorithm "sha256" expects a size of 32 bytes, got: 0
Nov 29 13:46:12 fedora bash[645]: cat: /run/peerpod/initdata.digest: No such file or directory
Nov 29 13:46:12 fedora bash[639]: ERROR: Algorithm "sha384" expects a size of 48 bytes, got: 0
Nov 29 13:46:12 fedora systemd[1]: Finished process-user-data.service - Process user data.
[root@fedora ~]# ls /run/media/cidata/user-data
ls: cannot access '/run/media/cidata/user-data': No such file or directory

I retried ls /run/media/cidata/user-data for a few minutes until the vm got deleted and it never seemed to be written
I used exactly the same deployment and images for these runs, so I'm not sure why /run/media/cidata/user-data was written in two runs, but not the third, but this might explain why the CI tests pass sometimes and not others?
I tried a 4th and 5th time and they both works, so the failure doesn't seem "sticky" either (but might be in the CI due to name clashing or something over incomplete cleanup)

it looks like there's a (race) condition that will prevent the run-media-cidata.mount unit to start and process-user-data doesn't depend on it. I think there is only casual coupling between the mount unit and process-user-data.service. That wouldn't explain why it fails on azure, though, since there is no cidata iso device.

there was a nonsensical After= directive on the mount unit that created a cyclic dependency for systemd that will not be produce the mount failures (not deterministically, because systemd is using some best-effort heuristic to break the cycle)

Cool - I'll re-cherry pick and test it with my mkosi tests. Thanks!

This worked for me: https://github.com/stevenhorsman/cloud-api-adaptor/actions/runs/12120024152/job/33788637325 🥳

yup, I can confirm: azure e2e + libvirt suite seem to work reliably w/ this change

Hi @mkulke !
I reviewed the code, looks fine to me but I'm not knowledgeable on this part. So waiting on @bpradipt 's review too.
I got a question though, more a curiosity. Each provider implements the UserDataProvider interface, and newProvider returns just one provider, and FileUserDataProvider takes precedence over the provider's specific. I'm wondering if there is an use case for returning multiple providers (e.g. FileUserDataProvider and AzureUserDataProvider). There is?

Hi @mkulke !
I reviewed the code, looks fine to me but I'm not knowledgeable on this part. So waiting on @bpradipt 's review too.
I got a question though, more a curiosity. Each provider implements the UserDataProvider interface, and newProvider returns just one provider, and FileUserDataProvider takes precedence over the provider's specific. I'm wondering if there is an use case for returning multiple providers (e.g. FileUserDataProvider and AzureUserDataProvider). There is?

No, if we have a user-data file on the fs, we don't need to fetch it from IMDS. usually it's either config-disk or IMDS, but both wouldn't make sense.


Correct number of characters vs. bytes

According to my test, this function writes at most 1024 wide characters, not bytes. That was probably just a copy-paste from wsprintfA.

@vid512 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@vid512 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

From my tests, 1024 characters are written and the null terminator is then appended, resulting in 2050 bytes being written.
I opened PRs about it a while ago:
https://github.com/MicrosoftDocs/sdk-api/pulls?q=is%3Aopen+is%3Apr+author%3Ajustanotheranonymoususer+nf

Yes, you are correct, I have overlooked the terminating zero. It would be better to add single explicit sentence about what happens in this case: only first 1024 characters + terminating zero are written, value 1024 is returned... This is not immediately obvious just from description "maximum buffer size" given in bytes. Anyway, your PR is more complete, so I am closing this.


BC_22: GDP, life expect.., population etc. selected in drop down of X-Axis but it still retain previously selected value

SEVERITY: Major
MODULE: Bar Chart
OS/BROWSER: Windows 7 / Chrome 45.0
STEPS TO REPRODUCE:

Navigate to URL: http://static.gapminderdev.org/vizabi/release/v0.5.1/preview/barchart.html
Bar chart page will be loaded
Click on Axes menu
Select either Region or Geo code on x-axis dropdown
These two selected values will get updated under the dropdown
Now select the values other than two mentioned above i.e. GDP, life expect.., Population
Note that selected values i.e. GDP, life expect.., Population will not get updated under the drop down

ACTUAL RESULTS:
Selected GDP, Life expect…, Population, etc. in x-axis but these selected values not updated below the drop down
EXPECTED RESULTS:
Any new value is selected in drop down of x-axis, it should be get updated below the dropdown
SCREENSHOT:

@SadiaKualitatem. Now in develop branch there is no values under dropdown list. Is it correct?

@maximhristenko
Retest Result:
Retested in develop branch & found that values are no more appearing under dropdown list.

yes


Helm Chart Breaks Deployment in Kuma

With the latest version of Helm chart (2.10), deploying KIC when Kuma fails. It is related to this PR, #619
We need a way to manually mount. The proposed solution from mesh team is to use a ContainerPatch. Use the following as a guide:
apiVersion: kuma.io/v1alpha1
kind: ContainerPatch
metadata:
  name: container-patch-kong-token
  namespace: kong-mesh-system
spec:
  sidecarPatch:
    - op: add
      path: /volumeMounts/-
      value: '{ "mountPath": "/var/run/secrets/kubernetes.io/serviceaccount/token", "name":"kong-1656434665-kong-token", "readOnly": "true", "subPath": "token" }'
    - op: add
      path: /volumeMounts/-
      value: '{ "mountPath": "/var/run/secrets/kubernetes.io/serviceaccount/ca.crt", "name":"kong-1656434665-kong-token", "readOnly": "true", "subPath": "ca.crt" }'
    - op: add
      path: /volumeMounts/-
      value: '{ "mountPath": "/var/run/secrets/kubernetes.io/serviceaccount/namespace", "name":"podinfo", "readOnly": "true", "subPath": "namespace" }'

Could have a kuma: enabled flag or something to trigger the creation of ContainerPatch.
Prerequisites

[ ] https://github.com/Kong/kubernetes-testing-framework/issues/303

@doctorwu does the above patch indeed work in your case? If you review the kuma-sidecar container before adding it, do you already have a volumeMounts with something else in it?
I'm able to install the CI test standalone Kong instance (which is functionally equivalent to a data plane node for this purpose--it lacks a controller container for sidecar to find the token in) with https://github.com/Kong/charts/commit/3bbd8a3b0acaefb5e54e58304e46ea288d3c23ef:
helm install -n kuma-demo fexample  /tmp/symkong -f ci/test3-values.yaml --set proxy.type=NodePort --set waitImage.enabled=false --set deployment.serviceAccount.enableKumaPatch=true

However, I had to modify the patch to add volumeMounts first. That yours worked without it suggests there's some other Kuma setting that results in its own volumeMount, which the add I have for the empty array would then wipe out, which would be bad.
json-patch indicates we can probably avoid this with the EnsurePathExistsOnAdd option, but it needs to be set in Kuma's code. Since something would need to change in code and I'm not 100% sure how that handles arrays, I'm inclined to add an annotation that indicates the Secret to mount as a standard feature, since it seems like running on Pods without automount easily would be good to have.

@jakubdyszkiewicz would know more than I would about this.


update link to 1000 common passwords

xato.net is dead; replace with link to archive.org, as the xato.net site suggests.

merged in d3b488f5bd17b4cf662613e0d3d62f9675ff3cdc, thanks!


TGI on NVIDIA GH200 (Arm64)

Feature request
Would it be possible to build/publish an arm64 container image for the text-generation-inference?  I would like to be able to run it on a NVIDIA GH200 which is an arm64-based system.
Thanks,
Jonathan
Motivation
Current images won't run on arm64.
Your contribution
I've tried to build the image myself, but I haven't been able to get it to build successfully.

Hi @dartcrossett 👋
Thanks for the request. I think at the moment it's not in our plans given bandwidth. But we're making some large changes anyways to how things are built + deployed.
Basically separating the TGI backend from the frontend, which might make it easier.
If you have any successes on building the docker image please feel free to post in this issue. Similarly if you know of any gotchas & errors, go ahead 👍

whats the source on those gpus? 🥲 @dartcrossett

The GH200s were purchased from NVIDIA and contain a single H100 Nvidia GPU.
Thanks,
Jonathan


Auto deploy workflow

Added a workflow that purports to deploy the client application to cloud.gov.
TODO:

[ ] fix the org argument to point to the right place
[ ] get the credentials created and stored in the right place (or update the workflow to point to the right place if they are there already)
[ ] verify that we don't need to add a working-directory argument to usds/cloud-gov-cli, because cf7 handles relative paths, right??

Note that there's no way to test the third bullet above without just merging this and running it (or making it run on push to this branch, but that seems like a more or less equivalently cowboyish move).


Spyder takes about 45 minutes to launch!

From<EMAIL_ADDRESS>on 2015-01-24T18:46:24Z
Spyder Version:  2.3.1
Python Version:  2.7.8
Qt Version    :  4.8.6, PyQt4 (API v2) 4.11.1 on Darwin
pyflakes >=0.5.0:  0.8.1 (OK)
pep8 >=0.6      :  1.5.7 (OK)
IPython >=0.13  :  2.2.0 (OK)
pygments >=1.6  :  1.6 (OK)
pandas >=0.13.1 :  0.14.1 (OK)
sphinx >=0.6.6  :  1.2.2 (OK)
psutil >=0.3    :  2.1.1 (OK)
rope >=0.9.2    :  0.9.4 (OK)
matplotlib >=1.0:  1.3.1 (OK)
sympy >=0.7.0   :  0.7.5 (OK)
pylint >=0.25   :  None (NOK)
What steps will reproduce the problem?

What is the expected output? What do you see instead?
Please provide any additional information below
.
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=2136

From ccordoba12 on 2015-01-30T14:16:30Z
This is most probably an error with your installation, or with you configured Spyder.
Please open a terminal and run
spyder --reset

or, if that command fails, just do
rm -R ~/.spyder2

That should fix your problem for sure.
Status: WontFix


Async Support with Vim 8

Actually I'm a little off using Java with Vim since was pretty slow with huge projects.
I see that some time ago was added a support for asynchronous process with Neovim. I'm still using Vim instead of Neovim.
There any plans to also support the new Vim 8 features (async, jobs, timers)?

If you mean async completions, so I guess this is in the case of YCM or
neocomplete, am I right?
What about maven/gradle execution, I will work on it of cause. But
little bit later.
On 09-15 (07:09), Adelar da Silva Queiróz wrote:

Actually I'm a little off using Java with Vim since was pretty slow with
huge projects.
I did see that some time ago a support for asynchronous process with
Neovim. I still using Vim instead of Neovim.
There any plans to also support the new Vim features?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, [1]view it on GitHub, or [2]mute the thread.
Reverse link: [3]unknown
References
Visible links

https://github.com/artur-shaik/vim-javacomplete2/issues/261
https://github.com/notifications/unsubscribe-auth/AEozu6GGzlVmUFVQbaNSbIqR-GoauK45ks5qqVGcgaJpZM4J96eX
https://github.com/artur-shaik/vim-javacomplete2/issues/261

--
Best regards,
Artur Shaikhullin

@artur-shaik no, I mean maven execution. Nice! So this issue can be closed?

Let's keep it for a while as reminder.
On 09-15 (10:00), Adelar da Silva Queiróz wrote:

[1]@artur-shaik no, I mean maven execution. Nice! So this issue can be
closed?
—
You are receiving this because you were mentioned.
Reply to this email directly, [2]view it on GitHub, or [3]mute the thread.
Reverse link: [4]unknown
References
Visible links

https://github.com/artur-shaik
https://github.com/artur-shaik/vim-javacomplete2/issues/261#issuecomment-247387523
https://github.com/notifications/unsubscribe-auth/AEozuyP0dMF0JvxA_5CU8JolqrzypRT7ks5qqXmmgaJpZM4J96eX
https://github.com/artur-shaik/vim-javacomplete2/issues/261#issuecomment-247387523

--
Best regards,
Artur Shaikhullin

nice, I just come back, Holiday is over。

@wsdjeg welcome back :smile:

Here's what :help version8
says about asynchronous I/O with JSON:
Closely related to channels is JSON support. JSON is widely supported and can easily be used for inter-process communication, allowing for writing a server in any language. The functions to use are |jsonencode()| and |jsondecode()|.
This makes it possible to build very complex plugins, written in any language and running in a separate process.
Job, Times, Partials and more... new packages built-in vim 8 feature..
I think @artur-shaik can take advantages using new api and able to reduce to two limitations described in Readme(Non-blocking execution at startup java file)
I swear, Concurrent programming is always hard.

@artur-shaik is this usefull?
Java Language Support for Visual Studio Code has landed - Repository

@ehzShelter yeah just made some researche. Good looking api, but don't think that we can move to it soon. But who knows.
@adelarsq not really sure, need to look deeper.

@artur-shaik Anyway.. I love your plugin :) lightweight ...!


Requeset UI change

The editor is more and more complex.
If only provide webui bind by some buttons is not enough, and need to make many changes upstream.
I request to reduce some buttons and use the interaction of the editor self.

Like this?

I'll push this changes by tomorrow

Merged

I realize that the difference in UI is already very small. I will add some modes to vite later, which can detect extension or online at compile time, which can further reduce code differences. Anyway, thanks for your work.


Roll Flutter Engine from 76a156784168 to 00a73bcfd218 (3 revisions)

https://github.com/flutter/engine/compare/76a156784168...00a73bcfd218
2022-06-03<EMAIL_ADDRESS>Roll Skia from 3789354a3088 to 74949fc4c203 (1 revision) (flutter/engine#33800)
2022-06-03<EMAIL_ADDRESS>Roll Dart SDK from 16b0538e6ccf to d8fa5b4cd4fe (1 revision) (flutter/engine#33799)
2022-06-03<EMAIL_ADDRESS>Roll Skia from 02031e67d014 to 3789354a3088 (1 revision) (flutter/engine#33798)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Bump version for 12.13.0 release

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@warrensplayer
The PR subject has the old 12.13.0 version number. It should be 12.14.0.


Image borders are ignored

Probably we should use Markdown/Sphinx syntax anyway instead of HTML.

The raw  are being transformed to a directive via a regex, and it
doesn't processes those border properties at all (nor the widths).
I searched and didn't find a built-in way to add a border to the
images.  So, I ignored it for the time being.  I guess it should be
done in CSS.  I just found this:
https://docs.typo3.org/m/typo3/docs-how-to-document/master/en-us/WritingReST/Images.html
which says :class: with-border, but that doesn't add a border, it
puts a CSS class (not sure if with-border is in the default css or
not), but it seems like closer to the right way to do things.  (maybe
in our case, it's better to have a border by default, and remove the
border only when desired?)
Adding the CSS is easy,
sphinx-lesson:sphinx_lesson/_static/sphinx_lesson.css
There is support for explicit widths of the figures, but I left that
off when setting things up.  Should we use that by default?  I just
had the idea that it's better to leave it off, and try to keep the
images narrow enough so that they aren't compressed too much when the
page is narrow - since people will be working on narrow screens
anyway.  I think the default is 1:1 pixel ratio.

Thanks! We can fix this later this week, now risk of conflicts since I am recreating screenshots and also doing edits in the episode mds.

This is indeed solved in the latest build.


i18n(locales): add week granularity localization for Spanish

Add week granularity for Spanish location.

Codecov Report

Merging #677 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #677   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           8      8
  Lines        1536   1536
  Branches      244    244
=====================================
  Hits         1536   1536

Impacted Files
Coverage Δ

arrow/locales.py
100% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6785237...06d1113. Read the comment docs.


Fix/negotiations ui improvements

What's new
Add 3 more functionality to the negotiations panel, namely:

button to clear all existing negotiations
button to reset selected negotiations
button to restore all cleared negotiations

fixes
Improvement to the user interface of the negotiation panel, namely:

make the tree structure more obvious
have each negotiation and it's content separated for easier viewing
improvements to the overall presentation

[Describe your changes]

Added 3 more buttons at the top of the negotiations panel, namely clear, reset and restore. The buttons are disabled until conflicts prop is not empty.
Upon clicking the clear button, localStorage will store the list of nodeIds of the conflicts that are currently presented on the panel and reset the negotiationContents state to an empty object. Subsequent renders with new nodeIds in the conflicts prop will be compared to the ids in localStorage and will not be updated in the negotiationContents if the ids exist in localStorage. Do also note that I refactored the negotiationContents to be an object in useState instead of a standalone array as I think it will be beneficial in future if we want to manipulate the negotiations.
Clicking the reset button will set negotiationTrajStore back to an empty object and clear the highlighted negotiation trajectories while automatically collapsing any expanded tree node and resetting the selected colors.
Clicking restore will clear the list of nodeIds stored in localStorage and will render all the negotiations on negotiations panel. I added this button so that users don't have to clear cache every time they want to reset the nodeIds.
Read the 2 sections above
Self-checks

[x] I'm familiar with and follow this  Typescript guideline
[x] I added unit-tests for new components
[x] I tried testing edge cases
[ ] I tested the behavior of the components that interact with the backend, with an e2e test

Discussion
Should we include the buttons in the tour guide? I feel that it might be quite hard to integrate the buttons into the guide due to it's implementation so maybe we can have a separate FAQ page to tell users what the buttons are meant to do?

Should we include the buttons in the tour guide? I feel that it might be quite hard to integrate the buttons into the guide due to it's implementation

Mmm.. maybe I'm missing something but I think we can explain what each button does and select them as well. Let's check with @val.

we can have a separate FAQ page to tell users what the buttons are meant to do

I like this idea as well.

Mmm.. maybe I'm missing something but I think we can explain what each button does and select them as well. Let's check with @Val.

Oh ... cause I was worried that users may not know they need to reset the local storage through the reset button. Maybe I am thinking too much about this.  I think a simple, temporary FAQ page should suffice if this is needed as I assume we would be changing data sources?


Command line push failures with status code 400 do not have a reason phrase

It just shows "Bad Request". This is bad since it means people can't debug their push failures very easily.

Ok, work on it now.

The revert is verified in DEV. Will leave this open for functional test fix.


feat: Add juju systemd notices charm library

Hello hello -
This pull request proposes adding the machine charm library juju_systemd_notices to operator-libs-linux. The juju_systemd_notices charm library is already used within the HPC team, but we are looking for an upstream home (+ reviews) for this charm library so that other charm teams can make use of it.
This pull request itself adds:

The juju_systemd_notices charm library itself.
Unit tests for the juju_systemd_notices charm library.
Integration tests for the juju_systemd_notices charm library.

You can view the juju_systemd_notices charm library in action within the slurmd-operator here: https://github.com/omnivector-solutions/slurmd-operator.
Miscellaneous
I only modified files particular to juju_systemd_notices, but a few extra commits are coming up because I needed to rebase my feature branch where I was developing the library. I had a couple chore(wip) commits so I could share my current progress with others, but I squashed them into one commit before opening this pull request.

Hmm... seems like there is a discrepancy between with (... patch(...)) in Python 3.8 versus 3.10. Shouldn't be too hard to fix.

Alright @benhoyt and @jnsgruk - just finished this round of updates per your feedback so far. Let me know what you think after the CI checks complete!

@NucciTheBoss Two other things:

Would also be good to update the README with a link to this lib under Usage.
Integration tests are failing. Doesn't look related to this PR, but are you able to investigate? If so, it might be an intermittent failure as this succeeded earlier today.

2. Integration tests are failing. Doesn't look related to this PR, but are you able to investigate? If so, it might be an intermittent failure as this succeeded earlier today.

@benhoyt sure I can take a look - seems like the test_snap_refresh integration test is busted. It looks like it is timing out trying to refresh the lxd snap to latest/candidate; it's hanging on waiting for lxd daemon to stop. This might not be right, but I believe it's hanging because the integration tests are using the lxd-agent inside the test container images to communicate with the images. It's probably hanging because it's waiting for the connection to close, but since we are using it to communicate with the container, it won't close. Easiest solution is to likely just change the snap that we are testing/refreshing.

Okay - everything should be good now. @benhoyt I fixed the bummy snap integration test by replacing the lxd snap being manipulated within the test_snap_refresh integration test with hello-world instead. That seemed to do the trick at least for me locally. @jnsgruk let me know if there are any other modifications necessary. Otherwise, I think this charm lib is ready to be merged :tada:

Thanks for the test fix for test_snap_refresh @NucciTheBoss!


New Group Types

Add new group types in UI after libGPML is integrated https://github.com/PathVisio/GPML/issues/17

Which group types? Location related? @mkutmon


Consider showing type information in PEP 484 format

An example of the current behavior:

When we show list[int, int], what we mean is that it's a list with two items, both of type int. However, if I go write a function which would accept this variable, I would actually write:
from typing import List

def print_odd_even(l: List[List[int]]):
    for l2 in l:
        for x in l2:
        print(x, "is even" if x % 2 == 0 else "is odd")

These two syntaxes are nearly identical, and I think that even though the current behavior is more "exact", the conflict between the official type hint syntax may cause confusion as we improve our support for typing/generics.
I think it's worth figuring out if we should stop including the extra info we have in its current form, and maybe try to figure out some better way to show the info that doesn't conflict with the standard way of writing types in PEP 484.

In the new language server, things are shown much more closely (with hints, identically) to PEP 484/typing.

The original example of foo = [[1, 2], [3, 4]] just shows list instead (as it is a specific instance of the real list type. There may be some loss or tooltip change that can be made to better display lists of known-consistent types, which I've opened as #605.


"Missing required parameter: refresh_token" after v21

Describe the bug:
Calls failing with the last release. This is a continuation of what i mentioned here;
https://github.com/googleads/google-ads-dotnet/pull/573#issuecomment-2472906991
System.AggregateException
  HResult=0x80131500
  Message=One or more errors occurred. (Status(StatusCode="Internal", Detail="Error starting gRPC call. TokenResponseException: Error:"invalid_request", Description:"Missing required parameter: refresh_token", Uri:""", DebugException="Google.Apis.Auth.OAuth2.Responses.TokenResponseException: Error:"invalid_request", Description:"Missing required parameter: refresh_token", Uri:"""))
  Source=Google.Ads.Gax
  StackTrace:
   at Google.Ads.Gax.Interceptors.UnaryRpcInterceptor.<>c__DisplayClass1_0`2.<Intercept>b__0(Task`1 oldTask)
   at System.Threading.Tasks.ContinuationResultTaskFromResultTask`2.InnerInvoke()
   at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread threadPoolThread, ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location ---
   at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread threadPoolThread, ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)
--- End of stack trace from previous location ---
   at Google.Api.Gax.Grpc.ApiCall.GrpcCallAdapter`2.<>c__DisplayClass4_0.<<CallAsync>g__WaitAndCallHandlers|0>d.MoveNext()
   at Google.Api.Gax.Grpc.ApiCallRetryExtensions.<>c__DisplayClass0_0`2.<<WithRetry>b__0>d.MoveNext()
   at OPG.Jobs.Ads.GoogleAdsSyncJob.<OnRun>d__3.MoveNext() in C:\Repos\dotnet-api\OPG.Jobs\Ads\GoogleAdsSyncJob.cs:line 54

  This exception was originally thrown at this call stack:
    Google.Apis.Auth.OAuth2.Responses.TokenResponse.FromHttpResponseAsync(System.Net.Http.HttpResponseMessage, Google.Apis.Util.IClock, Google.Apis.Logging.ILogger)
    Google.Apis.Auth.OAuth2.Requests.RequestExtensions.PostFormAsync(object, System.Net.Http.HttpClient, string, System.Net.Http.Headers.AuthenticationHeaderValue, Google.Apis.Util.IClock, Google.Apis.Logging.ILogger, System.Threading.CancellationToken)
    Google.Apis.Auth.OAuth2.Flows.AuthorizationCodeFlow.FetchTokenAsync(string, Google.Apis.Auth.OAuth2.Requests.TokenRequest, System.Threading.CancellationToken)
    Google.Apis.Auth.OAuth2.Flows.AuthorizationCodeFlow.FetchTokenAsync(string, Google.Apis.Auth.OAuth2.Requests.TokenRequest, System.Threading.CancellationToken)
    Google.Apis.Auth.OAuth2.Flows.AuthorizationCodeFlow.RefreshTokenAsync(string, string, System.Threading.CancellationToken)
    Google.Apis.Auth.OAuth2.UserCredential.RefreshTokenAsync(System.Threading.CancellationToken)
    Google.Apis.Auth.OAuth2.TokenRefreshManager.RefreshTokenAsync()
    Google.Apis.Auth.OAuth2.TokenRefreshManager.GetAccessTokenForRequestAsync(System.Threading.CancellationToken)
    Google.Apis.Auth.OAuth2.UserCredential.GetAccessTokenWithHeadersForRequestAsync(string, System.Threading.CancellationToken)
    Grpc.Auth.GoogleAuthInterceptors.FromCredential.AnonymousMethod__0(Grpc.Core.AuthInterceptorContext, Grpc.Core.Metadata)
    ...
    [Call Stack Truncated]

Inner Exception 1:
RpcException: Status(StatusCode="Internal", Detail="Error starting gRPC call. TokenResponseException: Error:"invalid_request", Description:"Missing required parameter: refresh_token", Uri:""", DebugException="Google.Apis.Auth.OAuth2.Responses.TokenResponseException: Error:"invalid_request", Description:"Missing required parameter: refresh_token", Uri:""")

Inner Exception 2:
TokenResponseException: Error:"invalid_request", Description:"Missing required parameter: refresh_token", Uri:""

As mentioned in the PR there should now be a new way to register the client via DI - the extension package is still not released. Aside from that the latest version gives me this bug. Im not sure if the new di stuff fixes this or not.
Steps to Reproduce:
Please provide a code snippet or steps to consistently reproduce the experienced behavior.
[DO NOT INCLUDE ANY PERSONAL OR SENSITIVE DATA IN YOUR SUBMITTED CODE]
Startup.cs
services.AddSingleton<GoogleAdsClient>();
GoogleAdsSyncJob.cs
var customerService = _client.GetService(Services.V17.CustomerService);

var listAccessibleCustomersResponse = await customerService
    .ListAccessibleCustomersAsync(new ListAccessibleCustomersRequest(), CallSettings.FromCancellationToken(cancellationToken));

Expected behavior:
Client library version and API version:
Client library version: v21.1.1 and v21.1.0
Google Ads API version: 17
.NET version: net8
Operating system (Linux, Windows, ...) and version (if the bug is platform-specific): windows
Request/Response Logs:

Anything else we should know about your project / environment

Hi @sommmen, I found the cause of your issue, I should have a fix ready by next week.
Sorry about this.

This is fixed by adding the Dependency-Injection-related classes in Google.Ads.GoogleAds.Extensions v2.0.3.


⚠ Bofrost.lu has degraded performance

In d1f2962, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1443 ms

Resolved: Bofrost.lu performance has improved in d673c45 after 6 minutes.


Add favorites dashboards

Hi @ykuc!
This repository is not the relevant place for this feature, so I'm closing this issue, please follow https://github.com/datalens-tech/datalens/issues/222


Can't handle command-line parameters and using data from protractor.conf.js file for retry attempts instead

Hi. Today I've found an issue that seems 'ptotractor-retry' can't handle a situation when we are passing parameters to Protractor from command-line like '--params.{some_parameter}' - for the first time (main tests run) everything fine, but as soon as it will try to re-run failed tests - will be used data from protractor.conf.js file instead of passed before params.
So for even small change I need to create separate config-file instead of parameters.
Any ideas how to resolve this issue?

Yep ,
I may have an idea why it s happening, I would need to repro to check.

It could be easily reproduced by making your test(s) broken, set retry to '3' for example, in protractor.conf.js provide browser as 'firefox', and launch from command-line using 'chrome' instead - protractor protractor.conf.js --browser='chrome'
For the first time it will launch Chrome as provided in command-line, but for retry it will use 'protractor.conf.js' and Firefox will be used for all retries.

Maybe it's possible to generate some temporary file inside of your folder where all passed parameters could be reused for retry? At this moment I'm seeing that your module is awesome, but with this issue I need to create for each new case (different parameters) new separate protractor.conf.file with needed change inside.

Hi @dreuxl! I'm wondering if there is any progress with this issue?


Rework of cfn-stack-rename

Hi Ian,
I came across your tool which is a great idea - I have reworked it quite a bit. I have not as yet properly tested it only tested that things are going through as expected which they all seem to be.
figured I would raise this pr for you to take a look at. If you are interested in this approach / want to merge it feel free, if you have any suggestions / improvements etc. feel free to comment / let me know. Completely up to you what you do with this. I figured it was only fair to contribute this back into your project - if it is any good.

Hey sorry for not getting back to you, I was actually very close to abandoning this as it has been a tad bit infuriating :) I have gotten it to the point where I am ok with it. if you want to include it I will leave it here: https://github.com/vamegh/cfn-stack-rename I am an awful maintainer - I don't know if I will get the chance to maintain it - either way do with it as you please :)


Updated Dockerfile* and .dockerignore

To fix --version parameter

I think that dune subst is useless here, we're using dune-build-info to embed the build information, and we're not substituting strings like VERSION in the source.

I have tried it without dune subst and it does seem to be necessary:
$ grep subst Dockerfile.worker
RUN opam exec -- dune subst

Then build it and test:
~/ocluster$ docker build -f Dockerfile.worker .
Sending build context to Docker daemon  1.726MB
Step 1/17 : FROM ocaml/opam:debian-11-ocaml-4.13@sha256:fe25836078456e1691b59e28b8fdf1a1feb34f122c9810642282d5d9530fb4ef AS build
...
Successfully built b8852f6f0651
~/ocluster$ docker run b8852f6f0651 --version
v0.1-101-g18e2b79

If I remove the line: sed -i '/dune subst/d' Dockerfile.worker
~/ocluster$ docker build -f Dockerfile.worker .
Sending build context to Docker daemon  1.726MB
Step 1/16 : FROM ocaml/opam:debian-11-ocaml-4.13@sha256:fe25836078456e1691b59e28b8fdf1a1feb34f122c9810642282d5d9530fb4ef AS build
...
Successfully built 54a00130a9d5
~/ocluster$ docker run 54a00130a9d5 --version
n/a


Operator not always picking all the logs from head of file

Describe the bug:
We've noticed that some of the logs are not reaching the backend in this case Elasticsearch. After some investigation the team noticed some of the logs were not leaving fluentbit.
Expected behaviour:
All the logs collected from local files should reach Elasticsearch (or any other log aggregation backend).
Steps to reproduce the bug:

Single node k8s cluster (all roles) to simplify the analysis.
In the cluster node run a sample sequential log generator

sudo curl -L https://raw.githubusercontent.com/paynejacob/sequential-log-generator/master/example.sh | sh

save the sample yaml below as head.yml
run the install script (requires kubectl and helm v3)
once all the logging pods are up https://<elasticsearch_host>:7200/examplelogs/_search?pretty should return 3k+ log entries.

curl -XDELETE http://jpayne.do.rancher.space:7200/*
helm install rancher-logging-crd https://charts.rancher.io/assets/rancher-logging/rancher-logging-crd-3.6.000.tgz --create-namespace=true --namespace=cattle-logging-system
sleep 3
helm install --create-namespace=true --namespace=cattle-logging-system rancher-logging https://charts.rancher.io/assets/rancher-logging/rancher-logging-3.6.000.tgz
kubectl create namespace examplelogs
kubectl apply -f ~/head.yml

Additional context:
This is a Rancher packaged logging-operator but all upstream is untouched so we can expect to match functionality/features with v3.6
Environment details:

Kubernetes version: v1.18
Cloud-provider/provisioner: Rancher provisioned RKE DigitalOcean cluster.
logging-operator version: v3.6
Install method: helm v3
Logs from the misbehaving component: as provided in steps
Resource definition (possibly in YAML format) that caused the issue, without sensitive data:

Sample yaml (head.yml)
apiVersion: logging.banzaicloud.io/v1beta1
kind: Output
metadata:
  name: examplelogs
  namespace: examplelogs
spec:
  elasticsearch:
    host: <elasticsearch_host>
    port: 7200
    scheme: http
    ssl_verify: false
    ssl_version: TLSv1_2
    index_name: examplelogs
---
apiVersion: logging.banzaicloud.io/v1beta1
kind: Logging
metadata:
  name: examplelogs
  namespace: examplelogs
spec:
  controlNamespace: cattle-logging-system
  fluentbit:
    inputTail:
      Tag: "examplelogs"
      Path: "/examplelogs/*.log"
    extraVolumeMounts:
      - source: "/examplelogs/"
        destination: "/examplelogs/"
        readOnly: true
  fluentd:
    disablePvc: true
---
apiVersion: logging.banzaicloud.io/v1beta1
kind: Flow
metadata:
  name: examplelogs
  namespace: examplelogs
spec:
  localOutputRefs:
    - examplelogs
  filters:
    - stdout:
        output_type: json

/kind bug

I am observing a similar behavior with GKE and AKS collected kubelet logs:
Rancher is collecting the kubelet logs from the AKS nodes from this path: /var/log/azure/kubelet-status.log
Rancher is collecting the kubelet logs from the GKE nodes from this path: /var/log/kube-proxy.log
GKE is log rotating the logs more aggressively I observed it in a daily basis so the log might be empty if the cluster has been running longer than a day.

The fluentbit under the logging operator is not designed to process non kubernetes logs. I beleive the issue can be that these log lines are processed by the kubernetes filter which cannot attach metadata information to them, or at least fails in some cases. I would recommend creating a fully separate daemonset with a custom fluentbit config to process those logs, send them to stdout and then the logging operator can handle them as usual container logs.


Microlearning library update

There's been updates on the Microlearning library which we should consider updating them in Ultra Essentials

[x] - Change Course Release Dates
[x] - Set a Primary Instructor
[ ] - Announcements vs Messages
[x] - Organise Discussion Boards using Folders
[x] - Using the Search Tool
[ ] - Add an Image as a Thumbnail in a Learning Module (we will update this next week in line with Allan Theophanides new update)
[ ] - Create Groups in Ultra

I have updated the following short videos:

Change Course Release Dates
Set a Primary Instructor
Organise Discussion Boards using Folders
Using the Search Tool
Add an Image as a Thumbnail in a Learning Module (we will update this next week in line with Allan Theophanides new update)
Create Groups in Ultra

I have also updated a draft on "Search in Ultra" in OneNote.
I have added a "Quick Start Guide - Add Thumbnail Images to Learning Modules"

I have updated Ultra Essentials Change Log


MIDI / SoundFont tab in iOS AudioKitDemo

This is mostly a port of the current OS X demo app, to add the MIDI and sound font for testing on that platform. It will need more polish, including a tab bar icon.
The good news is that it is working for me. I do not experience crashes when playing the keyboard on iOS either with this code. There seems to be a little bit of occasional audio distortion, but that's another issue.
So whatever is triggering the "many notes" crashes must be somewhere else, maybe in the way that the MIDI playground currently sends the events?

Even the many note bug persists, it is good to know it is not due to the midi changes.


English user manual not available

Inside cloud HIMS, clicking to user manual English showed a blank page.

Now User Manual in ENglish in available in the website.


fix test_bucket_create_exists

This PR attempts to fix test_bucket_create_exists by using appropriate status and error_code.
Signed-off-by: Utkarsh Srivastava<EMAIL_ADDRESS>

@TejasC88 can we merge this PR?

Is this test passing even with the fixes?
I found the same issue and tested the same code proposed in the PR, but the problem is that rgw from the main branch is not returning BucketAlreadyOwnedByYou (if my understanding is correct that error code is not even defined in: rgw_common.cc)


chore: catalog metadata updates

Issue #27

:tada: This PR is included in version 0.5.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Rename Snippet Master to All in one Snippet Master

task commit refs Link : https://github.com/vitabletec/SnippetMaster/pull/16


How to impose left and right restrictions on the DateTime Axes?

ScottPlot Version: ScottPlot5.0
How to limit the range of the DateTime Axes when initializing Scottplot? like limiting the Axes:
myPlot.Axes.SetLimits(-100, 150, -5, 5);

I would like to start at 2022-12-01 00:00:00 and end at 2022-12-01 00:30:00 on the time axis below.

Hi @HuShanzhi,
ScottPlot uses OADate format for DateTimeAxes. This is essentially a double variable. You can convert a familiar DateTime to OADate as follows.
DateTime from = DateTime.ParseExact("2022-12-01 00:00:00", "yyyy-MM-dd HH:mm:ss", System.Globalization.CultureInfo.InvariantCulture);
DateTime to = DateTime.ParseExact("2022-12-01 00:30:00", "yyyy-MM-dd HH:mm:ss", System.Globalization.CultureInfo.InvariantCulture);

myPlot.Axes.SetLimits(from.ToOADate(), to.ToOADate(), -5, 5);

Hi @HuShanzhi,
ScottPlot uses OADate format for DateTimeAxes. This is essentially a double variable. You can convert a familiar DateTime to OADate as follows:
DateTime from = DateTime.ParseExact("2022-12-01 00:00:00", "yyyy-MM-dd HH:mm:ss", System.Globalization.CultureInfo.InvariantCulture);
DateTime to = DateTime.ParseExact("2022-12-01 00:30:00", "yyyy-MM-dd HH:mm:ss", System.Globalization.CultureInfo.InvariantCulture);

myPlot.Axes.SetLimits(from.ToOADate(), to.ToOADate(), -5, 5);

@StendProg
Thank you for your reply. It was very helpful !

Sorry, I have to reopen this issue because I have a related question about the last two parameters of function SetLimits().
Is there a function like myPlot.Axes.SetLimits(from.ToOADate(), to.ToOADate(), -5, 5) to limit the upper and lower limits of the y-axis for Multiple Axes？
I have discovered a solution  #850 for Scottplot4.0. Is there a similar method for 5.0?

Sorry, I have to reopen this issue because I have a related question about the last two parameters of function SetLimits().
Is there a function like myPlot.Axes.SetLimits(from.ToOADate(), to.ToOADate(), -5, 5) to limit the upper and lower limits of the y-axis for Multiple Axes？
I have discovered a solution #850 for Scottplot4.0. Is there a similar method for 5.0?

The problem has been resolved.
var newYAxis = myPlot.Axes.AddLeftAxis();
newYAxis.Max = 100;
newYAxis.Min = -100;