Support excluding expected long duration operations from some analysis

Problem statement
I need to track requests/connections/dependencies that are expected to have a long duration (minutes/hours), and exclude them from performance analysis, computation of average response time, and slow request/dependency detection.
These expected long-duration operations currently make all the performance analysis tools in App Insights pretty useless - eg the perf analysis shows them as red, and when the operations graph Y axis is in minutes or hours, important details (eg a slow request taking 15s) are invisible.
An example (which would be much worse for longer-running operations):

(Note that only the expected long-duration requests are visible)
Examples of such long-duration operations are web sockets connections, and GRPC streaming connections.
Describe the solution you'd like.
There should be a way to flag an operation as "expected long duration", which results in it being excluded from duration analysis tools in the portal. An example is the http.long_running: true property that is set by SignalR; though this attribute shouldn't be http only.
The ASP.NET ApplicationInsights lib drops any RequestTelemetry when the request Activity has a "http.long_running" == "true" tag. I believe the intent with this is to hide the request that corresponds to the websocket connection, but I think this is a hack. The health and duration of the connection is important, and it is lost when this is discarded.
Here's the PR for it: Suppress long running SignalR connections #2372
Describe alternatives you've considered.
For now I'm just dealing with the fact that all the performance visualization tools in App Insights are wrong - at least I have the data in the logs and can filter on a custom property.
Additional context.
Here's an issue discussing the SignalR telemetry decisions: https://github.com/dotnet/aspnetcore/issues/29699
We use a custom websocket implementation instead of SignalR, for a number of reasons - one is telemetry customization and the lack of visibility provided by SignalR. For SignalR the decision to drop telemetry describing the connection is understandable, since SignalR provides a number of different connection types (websocket, long polling, server-sent events) that don't necessarily have a persistent network connection for the duration of the SignalR session.
However if you focus on websockets and GRPC bidirectional streaming, I think the right model for this sort of thing is an outer connection with inner outgoing calls and incoming requests, where the connection, requests, and dependencies each have their own spans. Since there's no connection telemetry item in App Insights, we're using RequestTelemetry to represent the connection, which works great for understanding the per-client flow, but makes all the perf analysis tools much less useful.

I need to track requests/connections/dependencies that are expected to have a long duration (minutes/hours), and exclude them from performance analysis, computation of average response time, and slow request/dependency detection

Is this a feature request for the Application Insights UI? Or something to be done in this SDK?

Hi @cijothomas - I believe there are 2 requirements:

A standard and documented way to flag "expected long running operations" - ideally this should be in OpenTelemetry so it could be re-used by AppInsights and there's less risk of conflict in the future.
UI support for excluding "expected long running operations" when doing performance analysis, or anywhere where slow ops are flagged.

Makes sense.
For 1, Nothing exists today in OTel conventions. It could be a while before it gets added....
For 2, This would be best directly reported in the UI feedback tool, so the right folks are notified. (This repo is only for sdk part).

Thanks @cijothomas  - that's helpful.
I haven't gone through all the OTel fields. We are using http.long_running: true in the absence of a standard (for WebSocket connections and GRPC connections and GRPC streaming requests and responses).
Is there a github repo for the UI feedback tool? If not, how do I contact that team?

There is no github repo for UI Feedbacks. The best way I know is to use the "Feedback" button right in the Application Insights portal itself,


Docs (readme): Add DELETE to dav_methods of nginx conf to allow deletes

Closes #1
Adds missing DELETE method among dav_methods directive of nginx config. This allows WebDAV deletions, or else the server returns 405.

Verified with #3


Change Reason.Create to enforce a Guid id

The current .Create accepts any string and crashes run-time. Let's
use the compiler to remove a potential run-time error.
If we need it to be a Guid we should not allow strings, even if that
makes the method slightly easier to use. It does so at the expense
of making run-time errors more likely.
┆Issue is synchronized with this Asana task

➤ Einar Ingebrigtsen commented:
Great point @TomasEkeli - what if we went one further and actually use a ConceptAs called ReasonId. We could then have have an implicit operator on that that parsed the string and actually have the code passing in a string and the parsing would happen implicitly and fail in the same way.

➤ Tomas Ekeli commented:
What I want to avoid is that code that looks fine and builds fine crashes at run-time
Example:
Reason.Create("something not a guid", "A good reason", "description");
If we had a ReasonId : ConceptAs with an implicit operator that does Guid.Parse we would still let this slip past the compiler and turn into a runtime exception.
Can we, perhaps, have strings as Ids instead of Guids?

➤ Einar Ingebrigtsen commented:
new Guid() or Guid.Parse() will not evaluate at build time, so you still have the same problem. It will only be seen at runtime no matter what you do for that.
If we want to evaluate this at build time, we could create a Roslyn extension that does the check.
I'm not too keen on having it as a string, even though that would work in isolation. The reason is that we're looking at including rules, broken rules and reasons as part of the MetaModel and actually promoting Rules, BrokenRules and Reasons into Artifacts - which would then require them to be Guids.

➤ Einar Ingebrigtsen commented:
I will move this into Triage for prioritization for now and as a non-breaking change we'll add the ConceptAs<> for this, building on your Pull Request.


A bit of Danish translation pt. 2

Tonight's translation (might be a few days before the next one) - and now I noticed the diplomat file as well ;)

Awesome work, @Zleep-Dogg! Thank you


Can not login

Using lastest release version.
With cookie:
Trying to log with saved cookie Error at doLogin(): (<class 'httplib.BadStatusLine'>, BadStatusLine("''",), <traceback object at 0x039DEE18>) Cannot Login!
Without cookie:
Logging in... Unknown login issue, please use cookie login method.

Can you login on site?

Yeah, works correctly.

weird, I can login just fine in my pc.
Looks like the server returning empty response, that's why the app throws bad status line error.
If you are using antivirus/firewall, ensure the application has access to the internet.

Nice hunch, my av updated to a new version yesterday, I will check it out.

And that was it. Thanks.

Weirdly, I need to report that I suffer from second half - unable to login with password.
Cookie method works.


[resolves #689] Exclude generated subsystem module definition from SCM

Refer to this link for build results (access rights to CI server needed):
https://fabric8-ci.fusesource.com/job/wildfly-camel-pullreq/484/
Test PASSed.


Handle load archive job cache error

Context
Currently, when the archive job cache tried to load any out-of-date archive job it will trigger an error thrown from the cache get and becomes an unhandled error (to radar detection as well).
Adding the IOException type to the catch clause to reduce the error noise.
Checklist

[ ] ./gradlew build compiles code correctly
[ ] Added new tests where applicable
[ ] ./gradlew test passes all tests
[ ] Extended README or added javadocs where applicable
[ ] Added copyright headers for new files from CONTRIBUTING.md

Is there a reason why we are loading old archived jobs? should we fix that instead?

Is there a reason why we are loading old archived jobs? should we fix that instead?

@sundargates My understanding is that this could be from stale actors on failed jobs that didn't get persisted at all. Treating it as a cache miss and the get() call to a cache should not be considered critical/unhandled exception anyway.


Make sure that the root-ca alias notbefore/notafter date is correct when used

The option to override the certificates validity for the aliases can lead to the situation that the chain certificates for the "current" signer are not considered "active" which leads to problems with the GetNextCA command in SCEP. The system should prevent/correct the validity dates of all "upper" certificates to contain the validity of all active dependants.

GetNextCa is no longer using the root alias so this is no longer a problem


util/wrap.pl: use the apps/openssl.cnf from the source tree

The make install_fips target failed in pull request #13684
msp@debian:~/src/openssl$ make install_fips
*** Installing FIPS module
install providers/fips.so -> /opt/openssl-dev/lib/ossl-modules/fips.so
*** Installing FIPS module configuration
fipsinstall /opt/openssl-dev/ssl/fipsmodule.cnf
FATAL: Startup failure (dev note: apps_startup()) for ./apps/openssl
... No such file or directory:crypto/conf/conf_def.c:771:calling stat(fipsmodule.cnf)
...
make: *** [Makefile:3341: install_fips] Error 1

because the openssl fipsinstall command was loading a previously installed
configuration file instead of the copy shipped with the source tree.
msp@debian:~/src/openssl$ strace -f make install_fips |& grep openssl.cnf
[pid 128683] openat(AT_FDCWD, "/opt/openssl-dev/ssl/openssl.cnf", O_RDONLY) = 3

This issue reveiled a more general problem, which applies to the tests as well:
unless openssl is installed, the openssl app must not use any preinstalled
configuration file. This holds in particular when the preinstalled configuration
file load providers, which caused the above failure.
The most consistent way to achieve this behaviour is to set the OPENSSL_CONF
environment variable to the correct location in the util/wrap.pl perl wrapper.

Checklist

[x] tested make test (with in-tree and out-of-tree build)
[x] tested make install_fips  (with #13684)

Uhmmmmm, please pay attention to the error message:
... No such file or directory:crypto/conf/conf_def.c:771:calling stat(fipsmodule.cnf)

Do you know that the directory /opt/openssl-dev/ssl/ exists (yet)?  If not, you might want to fix that first.

Uhmmmmm, please pay attention to the error message:
... No such file or directory:crypto/conf/conf_def.c:771:calling stat(fipsmodule.cnf)

Well observed. But that error is actually a different issue: it is a consequence of me following the instructions in the comments of the openssl.cnf file (after a previous install) and uncommenting two lines related to the FIPS module.
msp@debian:/opt/openssl-dev/ssl$ diff openssl.cnf.dist openssl.cnf
--- openssl.cnf.dist	2021-02-08 23:49:22.332083687 +0100
+++ openssl.cnf	2021-02-07 13:29:47.718621142 +0100
@@ -49,7 +49,7 @@
 # fips provider. It contains a named section e.g. [fips_sect] which is
 # referenced from the [provider_sect] below.
 # Refer to the OpenSSL security policy for more information.
-# .include fipsmodule.cnf
+.include fipsmodule.cnf

 [openssl_init]
 providers = provider_sect
@@ -59,7 +59,7 @@
 default = default_sect
 # The fips section name should match the section name inside the
 # included fipsmodule.cnf.
-# fips = fips_sect
+fips = fips_sect

 [default_sect]
 # activate = 1

I haven't looked into that yet, it was just the trigger which led me to this pull request, because it broke make install_fips.

I would argue that fipsinstall should not load the default configuration at all.

This PR is in a state where it requires action by @openssl/committers but the last update was 30 days ago

Rebased and cleaned up. No sure how much of this pr is still relevant because I haven't been able to pay much attention to the recent development.

I suppose the Windows minimal build failure is relevant.

@t8m @levitte one question: to test the fix for the Windows minimal build failure locally, I configured and built from a _build subdirectory using the commands from that build:
C:\src\openssl\_build> perl ..\Configure no-makedepend no-bulk no-deprecated no-fips no-asm -DOPENSSL_SMALL_FOOTPRINT VC-WIN64A

When building the target providers\common\der\der_rsa.h,  the perl command fails because of a missing oids_to_c::process_leaves subroutine:
C:\src\openssl\_build> nmake
...
        "C:\Strawberry\perl\bin\perl.exe" "-I." -Mconfigdata "..\util\dofile.pl" "-omakefile" "..\providers\common\der\der_rsa.h.in" > providers\common\include\prov\der_rsa.h
Undefined subroutine &oids_to_c::process_leaves called at ..\providers\common\der\der_rsa.h.in line 18.
NMAKE : fatal error U1077: ""C:\Strawberry\perl\bin\perl.exe"": Rückgabe-Code "0x1"
Stop.
NMAKE : fatal error U1077: ""C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.28.29910\bin\HostX64\x64\nmake.exe"": Rückgabe-Code "0x2"
Stop.

The build stops,  leaving me with a zero-byte der_rsa.h.
Using the same configuration command in the source tree, the build succeeds, apparently because of the extra arguments "-Iproviders\common\der" ... -Moids_to_c.
C:\src\openssl> perl .\Configure no-makedepend no-bulk no-deprecated no-fips no-asm -DOPENSSL_SMALL_FOOTPRINT VC-WIN64A
...
C:\src\openssl> nmake providers\common\include\prov\der_rsa.h
...

        "C:\Strawberry\perl\bin\perl.exe" "-I." "-Iproviders\common\der" -Mconfigdata -Moids_to_c "util\dofile.pl" "-omakefile" "providers\common\der\der_rsa.h.in" > providers\common\include\prov\der_rsa.h
Use of uninitialized value in join or string at C:/Strawberry/perl/lib/re.pm line 45.
Use of uninitialized value in join or string at C:/Strawberry/perl/lib/re.pm line 45.
Use of uninitialized value in join or string at C:/Strawberry/perl/lib/re.pm line 45.
Use of uninitialized value in join or string at C:/Strawberry/perl/lib/re.pm line 45.
Use of uninitialized value in join or string at C:/Strawberry/perl/lib/re.pm line 45.
Use of uninitialized value in join or string at C:/Strawberry/perl/lib/re.pm line 45.

Do you have any idea why the subdirectory build fails for me but succeeds in the GitHub build?

@t8m @levitte one question: to test the fix for the Windows minimal build failure locally, I configured and built from a _build subdirectory using the commands from that job:
Using the same configuration command in the source tree, the build succeeds, apparently because of the extra arguments "-Iproviders\common\der" ... -Moids_to_c.
Do you have any idea why the subdirectory build fails for me but succeeds in the GitHub build?

This is really for @levitte - for some reason the $args{deps} does not contain the oids_to_c.pm dependency. But why...

This is really for @levitte...

@t8m I almost assumed that. But  I didn't want to appear impolite by disregarding you in my question. ;-)

Last force-push was a simple autosquash without moving the merge-base (i.e., no tree changes).

This pull request is ready to merge

Merged to master in 3ab736acb89c277bd174f958591c65c66d611c72. Thanks @t8m!

@t8m @levitte one question: to test the fix for the Windows minimal build failure locally, I configured and built from a _build subdirectory using the commands from that job:
C:\src\openssl\_build> perl ..\Configure no-makedepend no-bulk no-deprecated no-fips no-asm -DOPENSSL_SMALL_FOOTPRINT VC-WIN64A

When building the target providers\common\der\der_rsa.h, the perl command fails because of a missing oids_to_c::process_leaves subroutine:
C:\src\openssl\_build> nmake
...
        "C:\Strawberry\perl\bin\perl.exe" "-I." -Mconfigdata "..\util\dofile.pl" "-omakefile" "..\providers\common\der\der_rsa.h.in" > providers\common\include\prov\der_rsa.h
Undefined subroutine &oids_to_c::process_leaves called at ..\providers\common\der\der_rsa.h.in line 18.
NMAKE : fatal error U1077: ""C:\Strawberry\perl\bin\perl.exe"": Rückgabe-Code "0x1"
Stop.
NMAKE : fatal error U1077: ""C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.28.29910\bin\HostX64\x64\nmake.exe"": Rückgabe-Code "0x2"
Stop.

The build stops, leaving me with a zero-byte der_rsa.h.
Using the same configuration command in the source tree, the build succeeds, apparently because of the extra arguments "-Iproviders\common\der" ... -Moids_to_c.
C:\src\openssl> perl .\Configure no-makedepend no-bulk no-deprecated no-fips no-asm -DOPENSSL_SMALL_FOOTPRINT VC-WIN64A
...
C:\src\openssl> nmake providers\common\include\prov\der_rsa.h
...

        "C:\Strawberry\perl\bin\perl.exe" "-I." "-Iproviders\common\der" -Mconfigdata -Moids_to_c "util\dofile.pl" "-omakefile" "providers\common\der\der_rsa.h.in" > providers\common\include\prov\der_rsa.h
Use of uninitialized value in join or string at C:/Strawberry/perl/lib/re.pm line 45.
Use of uninitialized value in join or string at C:/Strawberry/perl/lib/re.pm line 45.
Use of uninitialized value in join or string at C:/Strawberry/perl/lib/re.pm line 45.
Use of uninitialized value in join or string at C:/Strawberry/perl/lib/re.pm line 45.
Use of uninitialized value in join or string at C:/Strawberry/perl/lib/re.pm line 45.
Use of uninitialized value in join or string at C:/Strawberry/perl/lib/re.pm line 45.

Do you have any idea why the subdirectory build fails for me but succeeds in the GitHub build?

I find that modify the configdata.pm can build sussced on subdirctory


Search Suggestions

Can you provide some pics of what this will look like once implemented for the end user?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 393443ee-bbb2-09d5-c16c-2522ca855c57
Version Independent ID: 44ae935c-f080-d1ce-4c2c-463121fb7911
Content: Customize query suggestions in SharePoint search - SharePoint Online
Content Source: SharePoint/SharePointOnline/manage-query-suggestions.md
Service: sharepoint-online
GitHub Login: @arnek
Microsoft Alias: arnek

Hello @dataCollegechurch I am proposing thru a Pull Request, to add a Screenshot to the article, if the author approves it, it will be reflected online. Thanks

@dataCollegechurch Thank you for submitting feedback. We understand that this issue has been resolved.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.


Exception Handling in Get exam Schedule

The get exam schedule handler was giving the Same output for User not logged In and No response from amizone, therefore it was obsolete and user can't be told if there are Exams or not.
close #59

Damn congrats on your first PR!!!!

Also one more thing make sure in descriptions you mention which issue this closes like this:
closes #33

LGTM


LogLevel as label included

As recommended by the Loki team I try to use as few as possible labels. Sadly this library includes level although I'm not allowing it in the include:
new LoggerConfiguration()
    .ReadFrom.Configuration(configuration)
    .WriteTo.GrafanaLoki(lokiConfig.Uri,
        httpClient: new CustomHttpClient(lokiConfig),
        labels: new[]
        {
            new LokiLabel { Key = "Instance", Value = Environment.MachineName },
            new LokiLabel { Key = "Job", Value = lokiConfig.JobName }
        },
        textFormatter: new CompactJsonFormatter(),
        restrictedToMinimumLevel: configuration.GetValue<LogEventLevel>("Serilog:MinimumLevel:Default"),
        filtrationMode: LokiLabelFiltrationMode.Include,
        filtrationLabels: new[] { "Instance", "Job" })
    .CreateLogger();

Am I missing something or is this an actual bug?

Hello, @MeikelLP!
As it is mentioned here.
This is a sink for logger, so I decided that it's reasonable to keep a log level as always present value. That behavior is designed

Also, I see that you are using JsonFormatter. So I could recommend look at LokiJsonTextFormatter, which does not generate level as label.
Also, I could offer a quick solution for case if a concrete formatter is required. Create a wrapper like this.
Also, just want to ask. How critical is to not a create level label? Is it comfortable to browse logs with Grafana without coloring levels?

Hey, thanks for the quick answer.
I know log level labels are very beneficial. From what I read in the docs and heard in Loki talks I decided to test it without level for now. Maybe I add it later.
I will try the LokiJsonTextFormatter. For now this looked like a bug because I explicitly do not include level :)

As for me, level label is not a big deal, cause it is not a dynamic label (cause, there are only 6 possible variants of it's value (you could see it here).
It should be bug, if it was not implemented by design.
You are not the first one, who ask about this behavior, so I will create an action item for v7 milestone

I see, I'm looking forward to it :)


Add UtilityType

Just found this repo and introduced and added a link swift macro about converting utility types like typescript I made. Thank you!
UtilityType: UtilityType is an innovative library designed to realize TypeScript's UtilityTypes in Swift. See more details: https://www.typescriptlang.org/docs/handbook/utility-types.html

looks very interesting!


wip(installer): stubs experimental installer

First glance over the codechanges looks good to me. I'll do a test in the snap version and the pure version soon.

Thanks, @bernermic. I'll need to append a few commits to this PR before it's ready to ship, so there's no urgency in testing it. I just wanted to get your eyes on it for a general 👍 / 👎  on the approach. It sounds like we're on the same page, though.
Thanks! I'll request your review again when this guy is actually ready to merge 🙂

Known-issue: default YAML configs will only coincidentally (at best) be correct on Unix systems. This will not be ready for merging until the configs are informed by the installation process.

Looks like I also broke some tests. Whoops.

Remember to:

Fix the known-issue above
Update the README
Include https://github.com/cheat/cheat/pull/541 in the 3.7.0 release

@bernermic, please take a look now when you have a moment. At this point, I'm pretty happy with this. This should provide our users with a very pleasant and usable configuration out-of-the-box with zero manual configuration.
Please let me know if you'd like to see anything changed. Otherwise, I'll plan on cutting a new release in the near-term. Thanks!

FYI, this is the 3.7.0 release candidate. (I'm going to close this draft PR when we're all finished looking at it.)
https://github.com/cheat/cheat/pull/543

Released with 3.7.0. Closing draft PR.

@bernermic, I went ahead and released this, because I'm pretty confident that you'll like this implementation. That said, by all means feel free to share some feedback when you have the time - but no rush! Thanks :slightly_smiling_face:

Hey chris,
thanks 🙏 I will test this some time soon and give you feedback.

Sounds great, @bernermic. Thanks!


Remove warning message about missing compiler arguments

It turns out that this message was more noise than help. For example, it would often show up when adding a new file to a SwiftPM project: The file gets added before we reload the package and thus we don’t have build settings for the new file for a short while. Since we can’t dismiss the notification we sent to the client, the notification will stick around.
Let’s just remove the message.

@swift-ci Please test


Error rendering Postgresql/PostGIS geometry columns

Hi,
Postgresql/PostGIS geometry columns are rendered fine, when the geometry is based on the OpenGIS specification. POINT, LINESTRING, POLYGON, etc, based geometries are well transformed to text for display.
But when the geometry is based on the SQL-MM specification (CURVEPOLYGON, CIRCULARSTRING, etc) the rendering fails with: Unkown Geometry Type.
This happens in version 5.2.4 and 5.2.5.
I've attached an image.

How to reproduce the error:
Just run:
select st_geometryfromtext('CURVEPOLYGON(CIRCULARSTRING(0 0, 4 0, 4 4, 0 4, 0 0),(1 1, 3 3, 3 1, 1 1))')

and the output will show the error.

DBeaver Installation Details:
dbeaver5.2.5.txt

SQL-MM specification is not supported yet. Mark as FR.

Any plans to implement such support?

Probably we'll use https://github.com/geotools/geotools lib for that.
Generally this feature is planned as a part of #4222

GeoTools added its own WKT reader and some Geometry subclasses to handle some of the curves. They are dynamically turned into line strings during rendering so you get the right visual.

We won't use GeoTools for now because it is too heavy.
We use https://github.com/locationtech/jts and unfortunately it doesn't support advanced geometry formats.
However I've found a small Java library WKG (https://github.com/jericks/wkg) which does. It works fine and I'll include it in the next version as a workaround. I hope that locationtech guys will add support for extra spatial formats one day.

Note: CURVEPOLYGON, MULTICURVE  and other curve geometries are not supported by OSM/Leaflet engine (https://gis.stackexchange.com/questions/231485/preserving-curve-geometries-in-leaflet) so graphical geometry viewer won't work. But at least you can see it in the text mode.

verified


set default of replacingmergetree.delete.column to _sign

If the table has _sign and is_deleted columns , then there is an error with inserting data with existing tables where only the _sign column is present.

@subkanthi, I think, it would be better if default value for replacingmergetree.delete.column was null. We can get defaults from existant constants IS_DELETED_COLUMN, SIGN_COLUMN. So we can define replacingmergetree.delete.column as undefined by null value and use defaults instead.


CF logs fails when upgrading CF from CF270 to CF-Deployment 1.19

When doing the deploy to upgrade as soon as the api vms start to update we get failure using cf logs.
There is a long gap until the log-api is finally updated before cf logs is working again.  In some of our production envs this could be as much as several hours due to the large number of gorouters which are updated between api and log-api.
We see the following errors in the CloudController logs.
api/189f002f-8cc0-4210-acb7-5401be60dcde:/var/vcap/sys/log/nginx_cc# tail -f nginx.access.log | grep 0eecf6e0
api.au-syd.bluemix.net - [30/Jul/2018:00:36:29 +0000] "GET /internal/log_access/0eecf6e0-4483-47d9-bfa6-7de663e756e3 HTTP/1.1" 404 423 "-" "Go-http-client/1.1" <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS> vcap_request_id:650d2bb9-67b5-47f2-4e12-eb9ac68e9712::e55ec39e-d517-4c20-9a7e-22e31e569261 userid:38b0cd23-8d5c-4b1f-8b55-017d9ee23a83 clientid:cf response_time:0.008

and in the "old" traffic controller logs ...
==> /var/vcap/sys/log/loggregator_trafficcontroller/trafficcontroller.log <==
2018/07/30 00:32:30 Non 200 response from CC API: 404 for 0eecf6e0-4483-47d9-bfa6-7de663e756e3

The upgrade is from CF release (270) (Loggregator 92) to cf-deployment 1.19 (loggregator 102)
We need a process to be able to do this upgrade with no failure in the cf logs command.   Will the loggregator 102 work with the old cloud controller?  So if we upgrade loggregator first will this make think compatible?

so after doing a bunch more digging I did find that in Loggregator 92 I see this ...
https://github.com/cloudfoundry/loggregator-release/blob/305cd0ca1e6efabecab68baff5e5810050ba6cdc/src/code.cloudfoundry.org/loggregator/trafficcontroller/internal/auth/log_access_authorizer.go#L32
which is calling the /internal/log_access/<guid>  this was REMOVED from CC and therefore we get the errors.
We are attempting to do our upgrade by

disabling access control
doing the deploy to see if we have no log loss.

Is there a better suggestion?   Was there some documentation that we could not upgrade from 92 to cf-deployment 1.19?

@andrew-edgar
Your suggested upgrade strategy should work. However, when disabling access control you also allow access to the firehose (with all app logs) to anybody. If that is not a problem in your environment, you should be all good.
You already got to the root cause, but just to confirm: The underlying issue you are observing is caused in the change of authorization endpoint on the Cloud Controller. In an older version (compatible with loggregator v92) the endpoint was located at /internal/log_access/. In the current version (supported by loggregator => v93) it is located at /v4/internal/log_access/.
There is tooling and documentation to support the upgrade from cf-release -> cf-deployment located here. For orchestrating an upgrade with less downtime, the folks who manage cf-deployment may know more.


hashchange: Remove hiding of recent topics.

Recent Topics is hidden when we switch to a narrow view or the All Messages view, so this call is not needed. It will also become actively unhelpful when we build a stream-specific recent topics page, because then it will be possible to have a hash change that shouldn't close the recent topics view.
Manually tested switching between All Messages, Recent Topics, and narrow views.

This looks good to me, merged, thanks @evykassirer! @amanagr FYI in case you recall some reason this might be a bad idea. It was introduced in 1eafb1d8b3af0a2cee3c3d58647ca3829bc5419c, along with the other lines that seem to hide recent topics in the same code path (via hashchanged).

So, I'm pretty sure this broke the changes that were made in 72189250a2b9d1ef2ce965913e7de39a5e6c3d92.
Now, in Recent conversations, if you open search and select All messages from the dropdown (or clear the input and hit Enter), the view doesn't change from Recent conversations (although the blue highlight in the left sidebar does change to All messages).

@laurynmm how do you feel about this as a fix?
diff --git a/web/src/narrow.js b/web/src/narrow.js
index a66ab3f8f7..af1d7c1dfd 100644
--- a/web/src/narrow.js
+++ b/web/src/narrow.js
@@ -1028,6 +1028,14 @@ export function deactivate(coming_from_recent_topics = false, is_actively_scroll
     if (narrow_state.filter() === undefined && !coming_from_recent_topics) {
         return;
     }
+    // If we're coming from recent topics to All messages, we need to hide
+    // the recent topics view.
+    if (narrow_state.filter() === undefined && coming_from_recent_topics) {
+        if (recent_topics_util.is_visible()) {
+            recent_topics_ui.hide();
+        }
+    }
+
     blueslip.debug("Unnarrowed");

     if (is_actively_scrolling) {

That fixes the view not changing. But then, in the browser history, there's a weird issue with the browser title being set to "All messages", but the hash being set to "#" (which returns the default view). So if a person has "Recent conversations" as their default, then browsing back and forth changes the tab title, but not the view.
The hash being set to "#" and therefore the default view seems to be something that was missed in #25759.

Ah great callout thanks. Okay how about this?
diff --git a/web/src/hash_util.ts b/web/src/hash_util.ts
index 239eae8201..15c69a207d 100644
--- a/web/src/hash_util.ts
+++ b/web/src/hash_util.ts
@@ -109,7 +109,7 @@ export function by_stream_topic_url(stream_id: number, topic: string): string {
 // corresponding hash: the # component
 // of the narrow URL
 export function operators_to_hash(operators?: Operator[]): string {
-    let hash = "#";
+    let hash = "#all_messages";

     if (operators !== undefined) {
         hash = "#narrow";
diff --git a/web/src/narrow.js b/web/src/narrow.js
index a66ab3f8f7..af1d7c1dfd 100644
--- a/web/src/narrow.js
+++ b/web/src/narrow.js
@@ -1028,6 +1028,14 @@ export function deactivate(coming_from_recent_topics = false, is_actively_scroll
     if (narrow_state.filter() === undefined && !coming_from_recent_topics) {
         return;
     }
+    // If we're coming from recent topics to All messages, we need to hide
+    // the recent topics view.
+    if (narrow_state.filter() === undefined && coming_from_recent_topics) {
+        if (recent_topics_util.is_visible()) {
+            recent_topics_ui.hide();
+        }
+    }
+
     blueslip.debug("Unnarrowed");

     if (is_actively_scrolling) {


rename to aiopenstack?

Since most of community already adapted this naming convention, I think it might be easier to find this lib under name aiopenstack for new users.

go for it with new release.


Eve MotionBlinds

Pull Request to add Eve MotionBlinds for WWST

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Documentation for available options

Do you want to request a feature or report a bug?
Feature
What is the current behavior?
I can't find any documentation for the packager options
What is the expected behavior?
It would be cool to be able to have documentation for the packager options
Please provide your exact metro-bundler configuration and mention your metro-bundler, node, yarn/npm version and operating system.
N/A

100+ this. I was looking for ways to increase the available memory to each worker that metro-bundler spawns and short of digging through complected mountains or just hacking it in place, I didn't find any other way. I hacked it in place for now... Not fun: every time you have to wipe your node_modules for various fun reason it has be re-done.

@mjesun is working on this, and we are hoping to streamline the public API for Metro soon :) Closing this issue for now as it's on our roadmap and we are actively working on it, so it's not actionable on its own.

So, any progress on this?

You can find some of that stuff here: https://facebook.github.io/metro/. Still a lot to document (especially what has been worked lately), but should serve as a basis.


please add minimum Rust version to CI

I'd like to know what the minimum support Rust version if for lazy_static. I'm not necessarily asking for any particular policy with respect to semver, but just knowing that lazy_static works on Rust 1.x is incredibly useful information.

Looks like lazy_static works at least as far back as 1.11.0 before the compiler stopped working on my machine so I guess we just need to pick a version and include it in CI. 1.15.1? 1.20.0?

https://github.com/rust-lang-nursery/lazy-static.rs/commit/c0fbc23aa9924eba2c134745f0a353bb97c08d23 added 1.21.0 as the minimum supported version, so I think we can go ahead and close this one now.


[FLINK-32564][table] Support Cast From BYTES to NUMBER

What is the purpose of the change
Implement CAST from BINARY/VARBINART/BYTES to NUMBER
Brief change log
 CAST from BINARY/VARBINART/BYTES to NUMBER for Table API and SQL
Syntax:
CAST(NUMBER AS BYTES)
Examples:
Flink SQL> select cast(cast('1234' as BYTES) as BIGINT);;
res: 1234

Flink SQL> select cast(cast('1234' as BYTES) as DOUBLE);
res: 1234.0

select cast(cast('123' as BYTES) as TINYINT);
res: 123

Flink SQL> select cast(cast('123' as BYTES) as INT);
res:123

Flink SQL> select cast(cast('123' as BYTES) as FLOAT);
res:123.0

Flink SQL> select cast(cast('123' as BYTES) as SMALLINT);
res:123

Verifying this change

This change added tests in CastFunctionITCase.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (yes)
If yes, how is the feature documented? (docs)

@flinkbot run azure


Add support for Whaleclub

Hi,
how about adding support to anonymous Whaleclub exchange? Anonymous means that there is no ID verification needed, only email registration.
There is REST API available.

Link no longer exists


JSON vulnerability

Hello @vttn, as mentioned here i provided outdated link, sorry.
It would be great to have updated version https://www.ruby-lang.org/en/news/2020/03/19/json-dos-cve-2020-10663/

Hello @zhyhun-ivan
Thank you for alerting us. We will make a release as soon as possible to address the issue.
@vttn

Hello @zhyhun-ivan,
This is now fixed in the latest release.
Regards,
@vttn


updating commit ref and GIF

I updated the commit to a slightly updated version (which includes more categories). I also linked to a GIF, which is ~20MB - so feel free to not use the GIF if you think it is too large.

Thanks @cornhundred for the update.
20MB is indeed quite large. Do you think it's possible to compress it a little bit?
I sometimes use the following ffmpeg command to convert a video into a gif (tweaking it or adjusting the scale might help):
ffmpeg -i input.mp4 -r 20 -vf scale=1024:-1 output.gif

Hi @jtpio I would like to add a different example to the Gallery (I haven't made a pull request), but I just wanted to check whether 1.6MB is too large for a GIF for the gallery:
https://github.com/ismms-himc/visium-clustergrammer2/blob/working/img/visium-clustergrammer2_borderless_small.gif

Thanks for the heads-up.
I suppose this is referring to https://github.com/voila-gallery/voila-gallery.github.io/pull/15?

Yeah, I'll make a small GIF here too

Closing this PR since the public examples are now added to https://github.com/voila-gallery/voila-gallery.github.io.
Thanks again @cornhundred for all the contributions!


Support for ignoring column definition order?

Feature request
It would be greatly appreciated if you supported ignoring column definition order.
Motivation
Our Planetscale diffs are dominated by many CREATE TABLE diffs where columns are re-ordered. This is kind of unavoidable because team members maintain schema changes and when Planetscale merges them and then they apply them to their branch, their branch adds columns in a different order from main - I don't think it's fair to expect every migration tool to carry the burden of re-ordering columns, and in fact most do not (Drizzle-kit does not).
Why I think this is in scope for schemadiff
schemadiff project already makes an effort to ignore irrelevant schema changes, e.g. in this comment about textual diff:

The textual diff still works semantically under the hood, and it will ignore trailing comma changes, index reordering, cosntraint name changes, etc.

Furthermore, the April 2023 Vitesse blog post about schemadiff kicks this can down the road a few times:

And, if you want to compute the order in which the changes must take place (some scenarios dictate a specific order, a topic for a future post), then you'd need to solicit confirmation from MySQL by applying changes on the server, iteratively.

Say we want to determine whether the two have a different set of columns (let's ignore ordering for now). How would we do that?

note: I opened a support ticket with Planetscale on this and they referred me to the schemadiff blog post and acknowledged that others share my UX issue. This tells me that they would pay attention if schemadiff enabled this functionality for them!
note: I don't want to make this an XY problem but I propose this could be most easily achieved by first sorting lines inside a CREATE TABLE block. Could this be an option in DiffHints?
Thank you very much!

I realize I probably should have opened this in the Vitesse schemadiff repo - please let me know if you want me to close and re-open in that repo.
Thanks!

So first of all, the reason that this works the way it works is because column order is meaningful. The most obvious example of that is select * where the order of columns returned depends on the order of columns in the table. We want to be really careful about not breaking people's queries, which could happen if ordering is ignored.
If someone has a select * query on a dev branch that works fine and then does a DR where in the end the ordering is different and ignored, that select * query could likely break on their production branch in very unexpected ways.

Our Planetscale diffs are dominated by many CREATE TABLE diffs where columns are re-ordered. This is kind of unavoidable because team members maintain schema changes and when Planetscale merges them and then they apply them to their branch, their branch adds columns in a different order from main - I don't think it's fair to expect every migration tool to carry the burden of re-ordering columns, and in fact most do not (Drizzle-kit does not).

It highly depends on which tools you look at and what the ecosystem(s) are that you're operating in. Many other tools and ORMs do use select * queries which will break if you ignore column ordering, since column ordering is meaningful as mentioned above. Those tools are also order of columns aware and handle it appropriately. At least in my personal opinion, that's also what an ORM or schema management tool should do, as ordering is meaningful and I'd say it's pretty much expected that people will also write their own custom specific queries outside of the ORM using things like select *.
The contextual dependency also means the effort to change this is not isolated to just schemadiff. It means that all systems at PlanetScale need to be aware of a user configurable setting for each database, because we cannot change the default for this as this would potentially break many existing users of PlanetScale. Fun fact, we use Ruby on Rails ourselves where ActiveRecord is ordering aware and it also uses select *, so we'd never want to enable this for ourselves as it risks breaking queries in unexpected ways.
So the only option if we decide to support this is to have a user configurable setting that affects quite a few components in the stack, so it's a significant engineering effort beyond just schemadiff.

Thank you for this thoughtful response @dbussink !
In my support conversation with Planetscale, I noted exactly the select * case you mentioned and I understand that column order matters. **
But I'm not actually proposing that Planetscale change how they merge branches, just that they implement a UI to visualize a diff in a way that ignores or de-emphasizes re-ordering of columns. Sort of like the "Hide whitespace" option in GitHub's diff view. Their diff visualization stack starts with schemadiff, which motivates this request; I made the case that since many ORMs ignore column re-ordering, this is a practical if imperfect way to diff; I also argued that since schemadiff supports other quality of life omissions (like order of indices, which probably never affect business logic), this may fit the goals of the project.
@dbussink - can you help me brainstorm how Planetscale might implement this kind of feature, which I think would be great? Maybe they could preprocess schemas by sorting columns before they even use schemadiff?
**Note on column order: It appears that several popular ORMs ignore column order: my quick research seemed to show that Drizzle-kit, Prisma, and SQLAlchemy all at least in some cases ignore column order (I have used these three myself). You also mention ORM tools that are aware of column order ("Those tools are also order of columns aware and handle it appropriately."), so even if they use select * there may not be confusion on the ORM's side.
Thanks and feel free to close this issue if it's a definite "no"!

But I'm not actually proposing that Planetscale change how they merge branches, just that they implement a UI to visualize a diff in a way that ignores or de-emphasizes re-ordering of columns.

This is not something we want to do. The diff has meaning and is directly coupled to the DDL statements that are generated. So if we don't want to show a diff, that implies we don't want to generate the DDL statements and the DR should not re-order.
Having something that does not show a diff, but then does run ALTER TABLE operations to re-order is a big no-no for us since it's very surprising and unintuitive behavior. So the only real way to handle this is to make sure it's done consistently.

I also argued that since schemadiff supports other quality of life omissions (like order of indices, which probably never affect business logic), this may fit the goals of the project.

Indexes are fundamentally differently, exactly because they have no semantic meaning. It is also not possible to reorder indexes in MySQL therefore as well, unlike columns which can be reordered using ALTER TABLE. So that's why these are treated differently and they can't be considered similar to behavior for columns.

@dbussink - can you help me brainstorm how Planetscale might implement this kind of feature, which I think would be great? Maybe they could preprocess schemas by sorting columns before they even use schemadiff?

I don't think this is very useful to be honest. This is something that has much more internal considerations that are not really visible to people outside PlanetScale that we need to consider.

Thanks and feel free to close this issue if it's a definite "no"!

We're tracking the feedback at the moment, but there's no immediate commitment that we will change anything. So going to close this issue for now then.

Thanks for the responses @dbussink
I may open an issue on Drizzle about re-ordering columns.


Add ObservedGeneration to the sub Resources

This patch does a few things:

it adds a Status.OservedGeneration to the sub custom resources (API, Sched and Share)
it proposes to bump the observedGeneration at the beginning of the reconciliation loop, after we init the conditions
it checks, at the top level, if the ObservedGeneration matches with the metadata.generation assigned to the subCR(s)
it propagates the full chain to the StatefulSet, to make sure we are able to mark DeploymentReadyCondition as True only when we know the controller is looking at the last Generation for the StatefulSet as well
update the comparison between '.Generation' and '.ObservedGeneration' to match the logic of the statefulset controller

For function tests we need https://github.com/openstack-k8s-operators/lib-common/pull/488

/retest

/retest

/test manila-operator-build-deploy-tempest

/test manila-operator-build-deploy-tempest

we need https://github.com/openshift/release/pull/51050 to make tempest working again

The Prow patch landed, let's retest

/test manila-operator-build-deploy-tempest


upgrade to latest dependencies (#3468)

bumping golang.org/x/tools 3f4194e...729e159:

729e159 go.mod: update golang.org/x dependencies
38ed81a gopls/internal/regtest/marker: porting extract tests
bbf8380 gopls/internal/regtest/marker: use golden diffs for suggested fixes
51df92b go/ssa: two minor cleanups
e7fb31a internal/cmd/deadcode: rename -format to -f
c538b4e internal/cmd/deadcode: add -whylive=function flag
b753e58 internal/lsp/helper: fix misspelled "Code generated" comment
2638d66 internal/cmd/deadcode: omit package/func keywords in default output
118c362 gopls/internal/lsp/source: fix signatureHelp with pointer receivers
4124316 gopls/internal/lsp/cache: remove baseCtx from the View
8b89cfa gopls/internal/lsp/cache: remove forceReloadMetadata from clone
d2c415d gopls/internal/lsp/cache: pass workspace information into createView
2ddaad7 gopls/internal/lsp/cache: isolate getWorkspaceInformation from Session
4df4d8d internal/cmd/deadcode: support -json, -format=template
2881318 gopls/internal/lsp/source: enable nilness Analyzer in gopls
25924d0 go/analysis/passes/nilness: fix bug in method value
53cd36b gopls: remove dead code
7e0917a go/ssa: update builder doc comment
942d9ac go/ssa: don't treat _ specially in Prog.{Func,Const,Var}Value
227e728 go/ssa: delete pre-go1.18 obsolete code
9f1cca3 go/ssa: remove Function.Syntax optimization
0ee4d87 go/ssa: create methods on demand
04cf269 gopls/internal/lsp/cache: allow duplicate analyzer names
08edf75 gopls/internal/regtest/marker: port half of the suggestedfix markers
e6864f1 go/ssa: hang instances off generic Function, not Program
753c5d6 gopls/internal/lsp/cache: move 'contains' from snapshot to view
24c5a47 gopls/internal/lsp/cache: make options immutable on the View
e125dc6 gopls/internal/regtest/marker: port remaining rank and snippet tests
26349af gopls/internal/regtest/marker: port remaining completion tests
5e2efda gopls/internal/regtest/marker: port rank and func_rank tests
970eac5 gopls/internal/regtest/marker: port builtin/keyword completion tests
c90d0df go/ssa: make isParameterized thread-safe
02f3758 gopls/internal/regtest/marker: port five arbitrary completion tests
ee25040 gopls/internal/regtest/marker: port all prepare markers
9e94edb go/ssa: clarify Program.RuntimeTypes
75ff53b go/ssa: build methods of RuntimeTypes lazily
2bc9e16 go/ssa: TestStdlib: report count of syntactic functions too
f4cf222 go/ssa: new for var semantics
11828ff gopls/internal/lsp: add OnSave diagnostics
7ca319e go/ssa: split 'create' and 'build' for every Function
3aa6cfd internal/gopathwalk: check ignored directories lexically
1762c80 internal/gopathwalk: use filepath.WalkDir instead of internal/fastwalk
9cf559c go/analysis/passes/errorsas: remove old comment
ec032e3 go/packages: two clean-ups
9482e85 gopls/internal/lsp/cmd: add GOPACKAGESDRIVER to stat
ccc652a go/ssa: eliminate Program.{bounds,thunks} memoization
fcb8d5b go/ssa: some preparatory cleanups
099b552 gopls/internal/regtest/marker: port the links marker
50cdf2a gopls/internal/regtest/marker: port case sensitive completion tests
df7023e gopls/internal/regtest/marker: port all deep and fuzzy completion tests
b90ce15 gopls/internal/regtest/marker: port statements completion tests
d187d99 gopls/internal/regtest/marker: port remaining @signature markers
080c202 gopls/internal/lsp: fix code action panic on params of external funcs
ff1953b go/packages: don't fail if GOPACKAGESDRIVER leaves Compiler/GOARCH=""
4dca902 go/internal/packagesdriver: be defensive wrt error results
672de52 go/ssa: simplify Alloc helpers
931c74e internal/lsp/analysis: warn about incorrect type in embed directive
1cf8b0d go/ssa: new range var semantics
7c4d876 gopls/internal/lsp/source: remove unused parameters (cleanup)
b82788e gopls/internal/lsp: add semantic highlighting for go: directives
6da1917 go/packages: remove pre-go1.16 overlay support
5ab57de go/packages: ensure that types.Sizes is correct
02048e6 go/packages: document that types.Sizes may be nil
5185da1 internal/refactor/inline: avoid redundant import names added by inlining
6360c0b gopls/internal/lsp/source: find linkname directives without parsing
71f6a46 cmd/bundle: drop old +build lines
cdf1b5e cmd/present: drop NaCl reference from docs
99bbd3c go/callgraph/vta: use core type for struct fields
8ed1113 go/ssa: add support for range-over-int
7df9d5f gopls/internal/lsp: fix signature crash on error.Error
43c41b5 internal/refactor/inline: reify implicit return conversions
53e637b internal/refactor/inline: improve check for last uses of free vars
61bb3e9 internal/refactor/inline: less hacky solution for eliding braces
8a71c39 gopls/internal/lsp/source: abort change signature on overlapping calls
f744e4b go/ssa: propagate goversions in ssa
6fcd778 gopls/internal/lsp: add code actions to remove unused parameters
918e96a internal/refactor/inline: use binding decl with literalization
12b5dad gopls: deprecate "tempModfile" and "expandWorkspaceToModule" settings
f85b3f7 internal/refactor/inline: don't treat blanks as decls in declares()
3484534 internal/refactor/inline: docs for 0.14 release notes
b9b97d9 go/types/objectpath: remove method sorting
9b63f3d gopls: upgrade x/telemetry dependency
f38ff07 internal/refactor/inline: T{} is duplicable for struct/array
ecbfa88 go/analysis/passes/timeformat: simplify isTimeDotFormat
187911b internal/refactor/inline: more precise SelectorExpr effects
dbf6f42 go/analysis/passes/httpmux: add command
7e7568c go/analysis/passes/httpmux: check for enhanced ServeMux patterns
b268156 gopls: allow all drive letters in cache/filemap_test.go
be4e4d6 go/analysis/passes/internal/analysisutil: account for nil Func.Pkg
0e4fc90 internal/refactor/inline: add missing spread context (return)
8954aa7 go/types/internal/play: fix slice OOB when *ast.File is selected
fda3fe3 gopls/internal/lsp: use the correct options for semantic tokens legend
f6d8589 cmd/compilebench: pass linker flags to prebuild
5874869 go/analysis/passes/internal/analysisutil: add IsFunctionNamed
0b06fd8 cmd/gonew: skip Test if exec is unsupported
f5fd4c9 go/analysis/passes/bools: use astutil.Unparen
59ac17f go/analysis/passes/internal/analysisutil: remove Unparen
a3b5082 go/analysis/passes/appends: improve check for append builtin
395d393 go/analysis/passes/internal/analysisutil: add IsNamedType
22abcd6 oogo/analysis/passes/bools: remove duplicate functions
bumping golang.org/x/mod 5b69280...6e58e47:
6e58e47 modfile: improve directory path detection and error text consistency
bumping golang.org/x/crypto e3cc52e...eb61739:
eb61739 ssh: allow to configure public key auth algorithms on the server side
42c83ff ssh: try harder to detect incorrect passwords for legacy PEM encryption
e668aa9 go.mod: update golang.org/x dependencies
df0bc9e chacha20poly1305: guard PSHUFB usage with GOAMD64_v2
74c2ba9 crypto/hkdf: remove useless call to Reset
cf8dcb0 ssh: add test case against ssh CLI
4f30245 x509roots: catch the zero-roots case when generating the bundle
1d57292 x509roots: check HTTP response status code and media type
8779cbd all: update go directive to 1.18
2aeefc3 ssh: add support for SSH_AGENT_CONSTRAIN_EXTENSION with id 255
bumping golang.org/x/oauth2 3c5dbf0...e067960:
e067960 go.mod: update golang.org/x dependencies
4c91c17 google: adds header to security considerations section
bumping knative.dev/reconciler-test 36fcbd0...9972366:
9972366 upgrade to latest dependencies (# 631)
bumping golang.org/x/net b225e7c...fbaf412:
fbaf412 go.mod: update golang.org/x dependencies
cc6f4d1 http2: remove ancient build-tagged files for unsupported Go versions
a720b30 http2: allocate buffer pools using pointers to arrays
a7ef1a2 internal/quic/cmd/interop: don't t.Log after test finishes
26ea817 http2: unconditionally recycle responseWriterState
39c9d01 quic: don't send CONNECTION_CLOSE after stateless reset
45fa414 quic: undo accidental rename of test helpers
434956a quic: include more detail in connection close errors
ec29a94 quic: provide source conn ID when creating server conns
5791239 internal/quic/cmd/interop: skip tests when exec is unavailable
4865e2a internal/quic/cmd/interop: add interop test runner
770149e quic: pad ack-eliciting server Initial datagrams
05086a7 quic: fix panic when handling resent CRYPTO data
0526b49 quic: fix data race caused by aliased DCID
6d267b1 quic: properly shut down connections on listener close
642f15e quic: support stateless reset
4c7a5b6 http2: add test for push promise accounting underflow
48a5977 quic: support Retry
9ef1b72 quic: move more testConn behavior into testListener
37479d6 http2: fix underflow in http2 server push
d23d9bc all: update go directive to 1.18
92728b3 dns/dnsmessage: document that Skip does not fully validate the header
bumping google.golang.org/api 0d3b865...83b8a6c:
83b8a6c chore(main): release 0.150.0 (# 2244)
85e85ad feat(transport): Log DirectPath misconfiguration (# 2225)
f56fb11 chore(all): update all (# 2251)
7529003 feat(all): auto-regenerate discovery clients (# 2252)
c08d405 feat(all): auto-regenerate discovery clients (# 2250)
b56da3d feat(all): auto-regenerate discovery clients (# 2249)
8bfbeac feat(all): auto-regenerate discovery clients (# 2246)
5693997 feat(all): auto-regenerate discovery clients (# 2245)
2ce2d2d feat(all): auto-regenerate discovery clients (# 2243)
bumping knative.dev/eventing 7a645f8...32d7dd8:
32d7dd8 Allow configuring whether to allow cross namespaces Brokers configuration references (# 7455)
203fa93 Add deprecation warnings for EventType v1beta1 (# 7453)
e5f2814 support auto generation of Sequence identity service account [OIDC] (# 7361)
8ebe869 Deprecate EventType v1b1 API (# 7303)
a9320dc Add deprecation warnings for v1b2 (# 7454)
3162518 [main] Upgrade to latest dependencies (# 7450)
d964da3 Don't use async handler (# 7415)
bumping golang.org/x/term ea6303a...70d3a0b:
70d3a0b go.mod: update golang.org/x dependencies
6a610bc all: update go directive to 1.18
bumping knative.dev/pkg 6564cf1...97c7258:
97c7258 Bump golang.org/x/tools from 0.14.0 to 0.15.0 (# 2897)
99fa268 Bump golang.org/x/oauth2 from 0.13.0 to 0.14.0 (# 2895)
81a5838 Bump cloud.google.com/go/storage from 1.34.1 to 1.35.1 (# 2898)
b3e7ef5 Bump google.golang.org/api from 0.149.0 to 0.150.0 (# 2896)
4e16990 Bump golang.org/x/net from 0.17.0 to 0.18.0 (# 2894)
bumping golang.org/x/sys 2964e1e...cb378ae:
cb378ae syscall: call getfsstat via libc on openbsd
661d749 unix: use libc stubs for OpenBSD pledge+unveil
1168e25 unix/linux: update Linux kernel to v6.6
249e16f unix: require minimum OpenBSD 6.4 for pledge, unveil
1e63810 unix: stop counting trailing NUL for abstract addresses starting with NUL
1bfbee0 all: update go directive to 1.18
1d9f0b6 unix: add linux cachestat system call
8ccaaf0 windows: add GetFileTime
6ee6208 windows: add missing TCP and UDP socket options and control message types
bumping golang.org/x/text f488e19...6c97a16:
6c97a16 all: update go directive to 1.18

Signed-off-by: Knative Automation<EMAIL_ADDRESS>

/retest

/retest

OCF Webhook is merging this PR


Ignore upcoming warning for unnecessary override

See https://github.com/dart-lang/test/pull/1631
This method will be removed from the PlatformPlugin interface, which
means that the override annotations will surface diagnostics. This will
not impact flutter externally until the version of test_core that is
pinned is updated, however it does impact internal users where this code
will be used with the latest test_core before it is rolled here.
Preemptively ignore the diagnostic that will surface when this code is
used with the upcoming version of PlatformPlugin to allow a non-atomic
roll. The ignores and annotations will be removed once test_core has
been published and can be rolled to the flutter repo.

test-exempt: prepares analysis improvements


Solana Integration

Implement integration with the Solana blockchain to enable cross-chain capabilities and interaction with Solana-based assets and smart contracts.

Research Solana's RPC and Web3 libraries for integration.
Define data structures and flows for Solana transactions and account signature (is near mpc already supporting EdDSA ?)
Tests

The goal is to enable seamless interaction with the Solana blockchain within the platform by providing signature capabilities and dispatch.

Hey @douglasgalico - thanks for your reported issue! Is this something you plan to implement? Its certainly already true that MPC contract supports ecdsa (thats whats its intended for).
I am not sure if anyone has done any implementation yet, but this other package already has some other chains:
https://github.com/near/multichain-tools/tree/main/src/chains


Add code example for environment module

I tend to aggree with @p-fernandez that the payload in a separated way is great because we could also optionally annotate the actual payload interface for easier usage in the future. So think we can merge this one


feat: update for Intellij 2023.1

Update for Intellij 2023.1

@nexoscp hi!
I didn't merge release/2.0.0 into master, that's why you have conflicts. Please re-target your mr to branch, which I created for you - release/2.1.0

Hello everybody. Do you have any estimation of when this will be in production?
Cheers!

Hello everybody. Do you have any estimation of when this will be in production?
Also,  These links take us to the old repository (https://github.com/Pakisan/jasyncapi-idea-plugin), not this one. It would be nice to update this.
Apologies for commenting on the PR, but seems like there isn't an issue open to track this work.
Cheers! 🙇

Hi @alvesf2
I Will make the proposed changes, by myself, run check compatibility tests, and send them to review today evening(02.05)

Hello everybody. Do you have any estimation of when this will be in production?
Also,  These links take us to the old repository (https://github.com/Pakisan/jasyncapi-idea-plugin), not this one. It would be nice to update this.
Apologies for commenting on the PR, but seems like there isn't an issue open to track this work.
Cheers! 🙇

Hi @alvesf2
I Will make the proposed changes, by myself, run check compatibility tests, and send them to review today evening(02.05)

Hi, again @Pakisan Usually how long does it take for IntelliJ to validate this change?
Thank you,
Fábio

Hello everybody. Do you have any estimation of when this will be in production?
Also,  These links take us to the old repository (https://github.com/Pakisan/jasyncapi-idea-plugin), not this one. It would be nice to update this.
Apologies for commenting on the PR, but seems like there isn't an issue open to track this work.
Cheers! 🙇

Hi @alvesf2
I Will make the proposed changes, by myself, run check compatibility tests, and send them to review today evening(02.05)

Hi, again @Pakisan Usually how long does it take for IntelliJ to validate these changes?
Thank you, Fábio

Hi!

The review may take up to two business days (Monday - Friday, CET timezone, excluding official holidays). You will get a response on the Email used to register in the Marketplace. If you have any questions or feedback, please reach out to the Support team at

I missed with release channel. Re-targeted release to stable now.
You can download the plugin and install it manually from the release page. I pushed all changes to the release branch and attached .jar, .zip

Hello everybody. Do you have any estimation of when this will be in production?
Also,  These links take us to the old repository (https://github.com/Pakisan/jasyncapi-idea-plugin), not this one. It would be nice to update this.
Apologies for commenting on the PR, but seems like there isn't an issue open to track this work.
Cheers! 🙇

Hi @alvesf2
I Will make the proposed changes, by myself, run check compatibility tests, and send them to review today evening(02.05)

Hi, again @Pakisan Usually how long does it take for IntelliJ to validate these changes?
Thank you, Fábio

Release was approved and available now


wasm loader: Fix checks for opcode ref.func and else

Fix wasm loader integrity checks for opcode ref.func and opcode else:
for opcode ref.func, the function must be an import, exported, or present in a
table elem segment or global initializer to be used as the operand to ref.func,
for opcode else, there must not be a else previously.
Reported in #3336 and #3337.
And fix mini loader PUSH_MEM_OFFSET/POP_MEM_OFFSET macro
definitions due to the introducing of memory64 feature.

LGTM


Add a list of labels at the creation of a Pie when giving it a list of doubles

Suggestion: Add a list of labels at the creation of a Pie when giving it a list of doubles

double[] _pieValues = new double[];
string[] _pieLabels = new string[];

ScottPlot.Plot myPlot = new();

myPlot.Plot.Add.Pie(_pieValues, _pieLabels);

myPlot.SavePng("bug.png");

assign  me for that i want to do

I believe this cookbook example can help you reach your goal!
https://scottplot.net/cookbook/5.0/Pie/PieSliceLabelsAndLegend/


highlight tag move detection errors in the logs

This addresses the comment
https://github.com/kubernetes/k8s.io/pull/499#issuecomment-573267644
that the log output for tag moves is currently not really readable.
/cc @justinsb @dims @ps882

/lgtm


Introduce locale that covers ♮-calculus transition systems

We want to introduce a locale that covers all transition systems whose process type is the type process of the ♮-calculus and for which bisimilarity is a congruence with respect to all constructors of the process type. As a second step, we want to move the setup of the equivalence_simp method for the bisimilarity relations of the ♮-calculus to this locale, which results in this setup being done only once instead of once per bisimilarity relation.

Apparently it is not possible to define the quotient type and the lifted operations inside the locale. Therefore we keep the equivalence_simp setup per transition system but still move the compatibility laws that back ∏-compatibility into the locale (which in particular makes the use of parallel_list_preservation with its dependency on other facts simpler).

Unfortunately we cannot make use of  natural_transition_systems when lifting operators for weak bisimilarity relations. This is most likely related to #14. For now, we just don’t use natural_transition_systems in the weak case.


Protonet logo

Protonet Server / Software
Logo files at https://protonet.info/wp-content/uploads/2014/01/protonet_logo_2015_4c.zip
via https://protonet.info/de/ueber-uns/presse/

Added 4413382f761cfa4446446bc1f52cd30df12102f0
Thanks


generated_plugin_registrant is adding _ to import file

Hi,
The class generated_plugin_registrant.cc generated for windows, linux as adding _
my class name is ABSPrinterPlugin, while generating the generated_plugin_registrant.cc its adding _ i.e a_b_c for the capital first three letters
#include <abs_printer/a_b_s_printer_plugin_c_api.h>
actual include file which is
#include <abs_printer/abs_printer_plugin_c_api.h>

I believe this file is created by the Flutter SDK, so I recommend asking about it in the Flutter repository.


[SPARK-10359][PROJECT-INFRA] Multiple fixes to dev/test-dependencies.sh script

This patch includes multiple fixes for the dev/test-dependencies.sh script (which was introduced in #10461):

Use build/mvn --force instead of mvn in one additional place.
Explicitly set a zero exit code on success.
Set LC_ALL=C to make sort results agree across machines (see https://stackoverflow.com/questions/28881/)

Actually, it occurred to me that I should really be setting LC_ALL=C at the top of the script to guard against future problems in case we add additional locale-sensitive command calls. Let me make that change now...

Actually, it occurred to me that I should really be setting LC_ALL=C at the top of the script to guard against future problems in case we add additional locale-sensitive command calls. Let me make that change now...

Merged build finished. Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48560/
Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48560/
Test FAILed.

Test build #48561 has started for PR 10543 at commit 1844d32.

Test build #48561 has started for PR 10543 at commit 1844d32.

Test build #48561 has finished for PR 10543 at commit 1844d32.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #48561 has finished for PR 10543 at commit 1844d32.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48561/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48561/
Test PASSed.

Merged build finished. Test PASSed.

Test build #48562 has started for PR 10543 at commit 58142e0.

Test build #48562 has started for PR 10543 at commit 58142e0.

The latest test run passed the build tests and I manually tested this on the AMP Jenkins workers, so I'm going to speculatively merge this and will re-test the failing PRs. If that doesn't work, I'll hotfix to disable this test pending real investigation.

The latest test run passed the build tests and I manually tested this on the AMP Jenkins workers, so I'm going to speculatively merge this and will re-test the failing PRs. If that doesn't work, I'll hotfix to disable this test pending real investigation.

Test build #48562 has finished for PR 10543 at commit 58142e0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #48562 has finished for PR 10543 at commit 58142e0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48562/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48562/
Test PASSed.

Merged build finished. Test PASSed.


About dataset

Hi, bittnx
I wondered how to merge the training data and testing data. I download the data from the official website, while the training and testing data is seperated. While in your code, I saw them was processed in a folder.
trainSet = CmFile::loadStrList(wkDir + "ImageSets/Main/train.txt");
testSet = CmFile::loadStrList(wkDir + "ImageSets/Main/test.txt");
classNames = CmFile::loadStrList(wkDir + "ImageSets/Main/class.txt")
I even could not find class.txt in all the folders.
So when I do ./BING_linux , I met errors:
Dataset:`/home/june/projects/VOC2007' with 0 training and 0 testing
WinRecall.m Base = 2, W = 8, NSS = 2, perSz = 130
Invalidate CvMat data file /home/june/projects/VOC2007Results/ObjNessB2W8MAXBGR.xP
What should I do next? Thank you very much.

The train.txt, test.txt  and class.txt should be in the directory ~/ImageSets/Main/. If you didn't find them, make sure to download again from Mingming Cheng's website. 0 training and 0 testing means it didn't find the train.txt and test.txt. Another important thing is to check the format of .txt in linux. You can read this link:http://superuser.com/questions/294219/what-are-the-differences-between-linux-and-windows-txt-files-unicode-encoding.

@RyanCV Hi, thanks to reply. When I works on opencv 3.0, I met problems in the issues before which cannot be solved. So, I change to opencv 2.4.9, while opencv_imgcodecs cannot be found. Could you tell me which subversion you use, such as 2.4.*?

There is a bit of explanation missing on how to prep the vov2007 dataset for this.
More info can be found in this github below, and as mentionned before it's important to fix the endlines of ImageSets/Main/class.txt to be Unix and not Windows
https://github.com/varun-nagaraja/BING-Objectness

For dataset preparation, check:
http://kylezheng.org/objectproposal/


forwarding_rule support argument network_tier

TL;DR
i'm try to create a tcp internal lb, hit error Error "creating ForwardingRule: googleapi: Error 400: STANDARD network tier (the project's default network tier) is not supported: Network tier other than PREMIUM is not supported for loadBalancingScheme=INTERNAL., badRequest"
Expected behavior
support argument network_tier for google_compute_forwarding_rule
Observed behavior
My Project Network Service Tier config is Standard,  ip_address is not set. The error pops up when creating resource. Bypassing this issue, I have to define the network_tier  to "PREMIUM" explicitly in google_compute_forwarding_rule.
Terraform Configuration
resource "google_compute_forwarding_rule" "default" {
  project               = var.project
  name                  = var.name
  region                = var.region
  network               = data.google_compute_network.network.self_link
  subnetwork            = data.google_compute_subnetwork.network.self_link
  network_tier          = "PREMIUM"
  allow_global_access   = var.global_access
  load_balancing_scheme = "INTERNAL"
  backend_service       = google_compute_region_backend_service.default.self_link
  ip_address            = var.ip_address
  ip_protocol           = var.ip_protocol
  ports                 = var.ports
  all_ports             = var.all_ports
  service_label         = var.service_label
  labels                = var.labels
}

module "test_ilb" {
  source        = "GoogleCloudPlatform/lb-internal/google"
  version       = "~> 5.0"
  project       = var.project_id
  global_access = false
  network       = data.google_compute_network.my-network.name
  subnetwork    = data.google_compute_subnetwork.my-subnetwork.name
  region        = var.region
  name          = local.resource_name
  ports         = ["8080"]
  source_tags   = []
  target_tags   = []
  backends      = []
  health_check  = local.health_check
}

Terraform Version
$ terraform version
Terraform v1.3.7
on linux_amd64
+ provider registry.terraform.io/hashicorp/google v4.84.0
+ provider registry.terraform.io/hashicorp/google-beta v4.84.0
+ provider registry.terraform.io/hashicorp/random v3.5.1

Additional information
No response

@TedCat According to this doc internal load balancer is only supported for Premium tier.
https://cloud.google.com/load-balancing/docs/choosing-load-balancer#summary-gclb

@TedCat According to this doc internal load balancer is only supported for Premium tier.
https://cloud.google.com/load-balancing/docs/choosing-load-balancer#summary-gclb

For educational purposes, I think this could be revisited.


⚠ BCR Bot has degraded performance

In 73aa604, BCR Bot (https://bcr.alternativasinteligentes.com/BCRApi/web/chatbot) experienced degraded performance:

HTTP code: 200
Response time: 11974 ms

Resolved: BCR Bot performance has improved in 649fdfe.


Loader

How to add loader to the input field on any search? Upon getting a result, lets hide it and select else lets add a new value.
Thanks

The plugin doesn't have loader option, you have to do it manually, have a look to the events doc
https://dragonofmercy.github.io/Tokenize2/events.html


The authentication samples cannot work

It appears they use a depreciated API, I cannot find documentation so far for a current equivalent for MS Graph with Intune.
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 1249c655-3885-5a2d-1e70-191bd11640ce
Version Independent ID: ec51b113-d125-f517-0bbd-35cc3073af2f
Content: Get started with the Microsoft Graph PowerShell SDK
Content Source: microsoftgraph/docs-conceptual/get-started.md
Product: non-product-specific
Technology: microsoft-graph-powershell
GitHub Login: @msewaweru
Microsoft Alias: eunicewaweru

Hi @plonialmoni - Thanks for raising this issue. Please clarify what error you are getting and the steps to reproduce.


feat: add profile collector agent provider

What this PR does / why we need it:
add profile collector agent provider
Specified Reviewers:
/assign @sfwn

move this provder to erda repo, so close this pr


Capstone: Hackathon website

This capstone project:
Builds a personalized website based on an online website for a conference, With the  provided design guidelines for you to create to build it.
Chose a tech hackathon topic different than the one in the original design.
Video Explainer:
https://www.loom.com/share/b20aec5d094f453d837772b4b836aff3
Follow the design guidelines
Colors.
Typography: font face, size and weight
Layout: composition and space between elements.
The pages should look almost identical to the original design. Small adjustments like text or image changes are acceptable.
You can use a CSS framework (for example Bootstrap) for styling, if you want to.
Build only these 2 pages:
The home page.
The about page.
Each of these pages  have versions for 2 different screen sizes:
Mobile: up to 768px wide.
Desktop: 768px or wider.

Hi.
Can you please show me or elaborate on what the about page is like because
I don't think I understand what I'm supposed to do.
Thank you
On Fri, 28 Oct 2022, 00:33 TufoinNkuo, @.***> wrote:

@.**** requested changes on this pull request.
Hi @Ambient567 https://github.com/Ambient567
Great work so far. There are some issues that you still need to work on to
go to the next project but you are almost there!
To Highlight
✅ You used the correct Github flow
✅ Descriptive pull request message
✅ linter error checks validated
✅ Documented your work professionally
Required Changes ♻

please like the previous reviewer noted, it seems you are missing
the about page.please kindly implement it. according to the project
guidlines, it should....

contain a Home page and About page.
It's possible to navigate between the pages, there's a link from
Home page to About page and the opposite too.
Both pages contain the same navbar and footer.

[image: tufoin]
https://camo.githubusercontent.com/390ff6df69f616b7bc414a19b5d616347cd06d8efca4e488a84add6689435cec/68747470733a2f2f6d656469612e67697068792e636f6d2f6d656469612f635961423156796344624f794f69586343782f67697068792e676966
Optional suggestions
_Every comment with the [OPTIONAL] prefix won't stop the approval of this
PR. However, I strongly recommend you to take them into account as they can
make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something
is not 100% clear.
Please, remember to tag me in your question so I can receive the
notification.
Please, do not open a new Pull Request for re-reviews. You should use the
same Pull Request submitted for the first review, either valid or invalid
unless it is requested otherwise.
As described in the Code reviews limits policy
https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have
a limited number of reviews per project (check the exact number in your
Dashboard). If you think that the code review was not fair, you can request
a second opinion using this form. https://airtable.com/shrQAqnBwek5a0O0s
—
Reply to this email directly, view it on GitHub
https://github.com/Ambient567/Capstone_Project/pull/1#pullrequestreview-1159117872,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARQA6TVCAN2QYRKCNSMMO7LWFL7L5ANCNFSM6AAAAAARPKWTAA
.
You are receiving this because you were mentioned.Message ID:
@.***>

@Ambient567  . this is how the about page looks like
desktop

kindly check the behance design well and you will see both versions


terraform, gke: updating and applying notebook_nodes_version doesn't guarantee nodes are updated

It seems that declaring notebook_nodes_version and applying it doesn't make sure node pools get updated at all times.

I think maybe the issue is for node pools with no nodes when applying, and that updating the notebook_nodes_version then leads to nothing happening for those. I'm not sure though.

This was caused by a bug introduced recently by me in #3373. Its an easy fix, but I need to re-visit GKE node pools, things didn't upgrade fully due to this :'(


[Remove] Remaining Joda and Joda Dependency

Joda was deprecated in Elasticsearch 7.x. OpenSearch should have proactively removed in 2.0. This PR removes the remaining Joda dependency and formatting logic in favor of java 8 time. It adds a new LegacyFormatName class, however, to ensure camelCase DateFormat is supported for indexes created in ElasticSearch 7.x (and carried through OpenSearch 1.x).
relates #5910
relates #8110

@github-actions  Pull Request Checks / Verify Description Checklist (pull_request) Failing after 2s 🔫  (this PR template check is burdensome. It shouldn't fail PRs.)

@github-actions Pull Request Checks / Verify Description Checklist (pull_request) Failing after 2s 🔫 (this PR template check is burdensome. It shouldn't fail PRs.)

We try to address few things with this check:

follow the template (no matter maintainer or contributor)
ask people to report flaky test failure (no matter maintainer or contributor) till we get situation improved

@github-actions  Pull Request Checks / Verify Description Checklist (pull_request) Failing after 2s 🔫 (this PR template check is burdensome. It shouldn't fail PRs.)

@nknize This is a good criticism of the template for pull requests, want to make an issue to channel this discussion?
Note; this check on is triggered if you update the description, no commits/pushes required to go from failing to passing.

@github-actions Pull Request Checks / Verify Description Checklist (pull_request) Failing after 2s 🔫 (this PR template check is burdensome. It shouldn't fail PRs.)

We try to address few things with this check:

follow the template (no matter maintainer or contributor)
ask people to report flaky test failure (no matter maintainer or contributor) till we get situation improved

I opened #10970
We shouldn't conflate flaky test failures with this issue. They're a separate issue tied to other bad behaviors (e.g., only relying on PRs for testing instead of testing locally) .

@nknize minor one, I think this issue deserves changelog entry

@nknize nice cleanup, curious why you've opted to use ZonedDateTime instead of OffsetDateTime (which it is recommended by the standard library):

It is intended that {@code ZonedDateTime} or {@code Instant} is used to model data
in simpler applications.  {@code OffsetDateTime}  may be used when modeling date-time concepts in
more detail, or when communicating to a database or in a network protocol.

AFAIK the  ZonedDateTime is susceptible to daylight saving rules whereas OffsetDateTime is not (small example below):
ZonedDateTime.now().plusDays(7) -> 2023-11-07T13:44:56.092955-05:00[America/Toronto]
OffsetDateTime.now().plusDays(7) -> 2023-11-07T13:44:56.093087-04:00

curious why you've opted to use ZonedDateTime instead of OffsetDateTime

Because ZonedDateTime is the same concept used in Joda which works off the TimeZone and with a change this large I wanted to preserve the logic as much as possible for bwc. There's all sorts of interesting blog posts out about this very topic.

Because ZonedDateTime is the same concept used in Joda which works off the TimeZone and with a change this large I wanted to preserve the logic (and minimize the blast radius) as much as possible for bwc.

That makes sense, for sure, thanks!

Hi @nknize, the PR is stalled. Is this being worked upon?

These PRs have been ready for review / approval for quite a while. Either no one has been comfortable approving them or everyone is busy with their own tasks. I'll rebase when there's a need (approval or change) otherwise I'll be rebasing in perpetuity.

These PRs have been ready for review / approval for quite a while. Either no one has been comfortable approving them or everyone is busy with their own tasks. I'll rebase when there's a need (approval or change) otherwise I'll be rebasing in perpetuity.

To be fair, @reta reviewed it on November 13th, asked a question and got no reply.

won't be actively working unless needed


Mailing lists

When a team submits stats, we send an email out to the team accountables. Some teams may want to have a customized list (e.g. LA has a T2 statistician accountable).
Add a way to specify customer email lists and use that list when sending the report emails.

I added primitive support with https://github.com/pdarg/tmlpstats/pull/49. We should make this a first class setting that's configurable be users.

This is related to issue #60


Fancy Zone changes selected custom layout to default after reboot.

Microsoft PowerToys version
0.47.0
Running as admin

[X] Yes

Area(s) with issue?
FancyZones
Steps to reproduce
After selecting a layout in editor. FancyZones works well, after reboot, holding shift defaults to priorityGrid.
✔ Expected Behavior
I think it should default to the selected or custom edited one, that I was using.
❌ Actual Behavior
it reverts to default after reboot
I think it has something to do with AMD apu, on 4k screen, maybe fancy thinks after reboot, the monitor is changed and reverts to default.
Other Software
No response

Thanks for reporting this. This issue is a duplicate. We'll track this in #13625  to centralize the discussion thread.


Fixed Errors in %rm

Fixed bugs in %rm
Bugs

%rm [open slots] would not output the expected verification text
%rm 0 would close the room instead of changing the open slots to 'f'
/room was running entirely separate code from %rm

sorry it took me so long to get to this. life is busy


vcpkg was unable to detect the active compiler's information

Hi
I'm using llvm build from source
clang --version
clang version 18.0.0 (git@github.com:llvm/llvm-project.git 444abb396c340e52a8a4db5778b7d6b3b6195070)
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: /usr/local/bin

clang++ --version
clang version 18.0.0 (git@github.com:llvm/llvm-project.git 444abb396c340e52a8a4db5778b7d6b3b6195070)
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: /usr/local/bin

Trying to install a library:"
dyarosh@dyarosh-linux:~/space/vcpkg$ ./vcpkg --version
vcpkg package management program version 2023-08-09-9990a4c9026811a312cb2af78bf77f3d9d288416

See LICENSE.txt for license information.

./vcpkg install benchmark

I get a failure:
vcpkg was unable to detect the active compiler's information.
dyarosh@dyarosh-linux:~/space/vcpkg$ ./vcpkg install benchmark
Computing installation plan...
The following packages will be built and installed:
    benchmark:x64-linux -> 1.8.2
Detecting compiler hash for triplet x64-linux...
error: while detecting compiler information:
The log file content at "/home/dyarosh/space/vcpkg/buildtrees/detect_compiler/stdout-x64-linux.log" is:
-- Configuring x64-linux-rel
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:112 (message):
    Command failed: /snap/cmake/1329/bin/cmake /home/dyarosh/space/vcpkg/scripts/detect_compiler -G Ninja -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/home/dyarosh/space/vcpkg/packages/detect_compiler_x64-linux -DCMAKE_MAKE_PROGRAM=/home/dyarosh/space/vcpkg/downloads/tools/ninja/1.10.2-linux/ninja -DCMAKE_SYSTEM_NAME=Linux -DBUILD_SHARED_LIBS=OFF -DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=/home/dyarosh/space/vcpkg/scripts/toolchains/linux.cmake -DVCPKG_TARGET_TRIPLET=x64-linux -DVCPKG_SET_CHARSET_FLAG=ON -DVCPKG_PLATFORM_TOOLSET=external -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON -DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON -DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON -DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE -DCMAKE_VERBOSE_MAKEFILE=ON -DVCPKG_APPLOCAL_DEPS=OFF -DCMAKE_TOOLCHAIN_FILE=/home/dyarosh/space/vcpkg/scripts/buildsystems/vcpkg.cmake -DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON -DVCPKG_CXX_FLAGS= -DVCPKG_CXX_FLAGS_RELEASE= -DVCPKG_CXX_FLAGS_DEBUG= -DVCPKG_C_FLAGS= -DVCPKG_C_FLAGS_RELEASE= -DVCPKG_C_FLAGS_DEBUG= -DVCPKG_CRT_LINKAGE=dynamic -DVCPKG_LINKER_FLAGS= -DVCPKG_LINKER_FLAGS_RELEASE= -DVCPKG_LINKER_FLAGS_DEBUG= -DVCPKG_TARGET_ARCHITECTURE=x64 -DCMAKE_INSTALL_LIBDIR:STRING=lib -DCMAKE_INSTALL_BINDIR:STRING=bin -D_VCPKG_ROOT_DIR=/home/dyarosh/space/vcpkg -DZ_VCPKG_ROOT_DIR=/home/dyarosh/space/vcpkg -D_VCPKG_INSTALLED_DIR=/home/dyarosh/space/vcpkg/installed -DVCPKG_MANIFEST_INSTALL=OFF
    Working Directory: /home/dyarosh/space/vcpkg/buildtrees/detect_compiler/x64-linux-rel
    Error code: 1
    See logs for more information:
      /home/dyarosh/space/vcpkg/buildtrees/detect_compiler/config-x64-linux-rel-CMakeCache.txt.log
      /home/dyarosh/space/vcpkg/buildtrees/detect_compiler/config-x64-linux-rel-out.log
      /home/dyarosh/space/vcpkg/buildtrees/detect_compiler/config-x64-linux-rel-err.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_configure_cmake.cmake:344 (vcpkg_execute_required_process)
  scripts/detect_compiler/portfile.cmake:18 (vcpkg_configure_cmake)
  scripts/ports.cmake:147 (include)

error: vcpkg was unable to detect the active compiler's information. See above for the CMake failure output.

error: vcpkg was unable to detect the active compiler's information. See above for the CMake failure output.

And what does the error say?

Sorry
CMake Error at /snap/cmake/1329/share/cmake-3.27/Modules/CMakeTestCXXCompiler.cmake:60 (message):
  The C++ compiler

    "/usr/local/bin/clang++"

  is not able to compile a simple test program.

  It fails with the following output:

    Change Dir: '/home/dyarosh/space/vcpkg/buildtrees/detect_compiler/x64-linux-rel/CMakeFiles/CMakeScratch/TryCompile-9T8LY3'

    Run Build Command(s): /home/dyarosh/space/vcpkg/downloads/tools/ninja/1.10.2-linux/ninja -v cmTC_6df89
    [1/2] /usr/local/bin/clang++   -fPIC -MD -MT CMakeFiles/cmTC_6df89.dir/testCXXCompiler.cxx.o -MF CMakeFiles/cmTC_6df89.dir/testCXXCompiler.cxx.o.d -o CMakeFiles/cmTC_6df89.dir/testCXXCompiler.cxx.o -c /home/dyarosh/space/vcpkg/buildtrees/detect_compiler/x64-linux-rel/CMakeFiles/CMakeScratch/TryCompile-9T8LY3/testCXXCompiler.cxx
    [2/2] : && /usr/local/bin/clang++ -fPIC  CMakeFiles/cmTC_6df89.dir/testCXXCompiler.cxx.o -o cmTC_6df89   && :
    FAILED: cmTC_6df89
    : && /usr/local/bin/clang++ -fPIC  CMakeFiles/cmTC_6df89.dir/testCXXCompiler.cxx.o -o cmTC_6df89   && :
    /usr/bin/ld: cannot find -lstdc++: No such file or directory
    clang++: error: linker command failed with exit code 1 (use -v to see invocation)
    ninja: build stopped: subcommand failed.

  CMake will not be able to correctly generate this project.
Call Stack (most recent call first):
  CMakeLists.txt:12 (enable_language)

I guess it really wants libstdc++. It is broken on my computer

Please provide detailed logs.
/home/dyarosh/space/vcpkg/buildtrees/detect_compiler/config-x64-linux-rel-CMakeCache.txt.log
/home/dyarosh/space/vcpkg/buildtrees/detect_compiler/config-x64-linux-rel-out.log
/home/dyarosh/space/vcpkg/buildtrees/detect_compiler/config-x64-linux-rel-err.log

Thanks for posting this issue. Please reopen this issue if this is still a problem for you.


[CI error] failed to install tool dependencies

failed to install tool dependencies if @typescript upgrade to  "~5.5.3" in ci check from https://github.com/Azure/azure-sdk-for-js/pull/30170
https://dev.azure.com/azure-sdk/public/_build/results?buildId=3934504&view=logs&j=7871e8ac-1348-5c5a-3691-0fa1e72e8e2e&t=5e018f36-ed2a-5edc-dc10-75fad779593a&l=37

@jeremymeng ,could you help take a look? thanks?
in https://github.com/Azure/azure-sdk-for-js/pull/30170 I will revert this version change for oracledatabase to unblock our release.

@kazrael2119 I have a fix here https://github.com/Azure/azure-sdk-for-js/pull/30294

Should be fixed now


Logging of scan statistics when and after the scan is/was executed

Extend logging capabilities for the scanner:

log total amount of detected cryptographic assest after the scan
...

Can i work on this ?

@yashathwani sure, feel free to add logging capabilities and make a pr.


Implement the AdminNetworkPolicy api CRD

This PR serves to implement the AdminNetworkPolicy CRD described in further detail with https://github.com/kubernetes/enhancements/issues/2091.
The goal is to ensure this does not merge without solving all of the TODO's described in the KEP.

/assign @Dyanngg

Sure I can do that @danwinship, thanks!

For now I broke the API changes explicitly out in it's own commit https://github.com/kubernetes-sigs/network-policy-api/pull/30/commits/f296a3ec9ed5e061da1e60b88e4dd4964ded3962

/assign @thockin @caseydavenport @danwinship

https://github.com/kubernetes-sigs/network-policy-api/pull/31 Pulls all the scaffolding out of this PR :)

/assign @Dyanngg

/assign @abhiraut

This Issue https://github.com/kubernetes-sigs/network-policy-api/issues/28 is of direct relation to the API

@fasaxc If you could PTAL at this spec and possibly elaborate more on your existing comment from the ANP KEP that would be great

Pushed some changes in response to @danwinship's comments, resolved the necessary comments it covered. The unresolved comments still need some more discussion, and so does the N/S selection debate https://github.com/kubernetes-sigs/network-policy-api/issues/28

Pushed another round of changes, specifically creating a new BaselineAdminNetworkPolicy object and syntax changes in response to feedback.

Yes, that is the current plan in my opinion @thockin

Did you mean to commit a binary?

Originally I did so we could control the controller-tools binary but I removed it

Pushed changes in response to Dan's Review and meeting last week

@astoycos Could you also retry assigning me? I'm in the K8s org now, probably need you to add me as a maintainer for this repo

/assign @Dyanngg

Next round of changes have been pushed, I will work to create some sample yaml's for us to study this week.

/lgtm
/hold
would be good to get another review from Tim, especially around the *[]

CC @thockin

/un-hold

/remove hold

/unhold

We discussed this with Tim today in the impromptu sig-network-policy api meeting today and he agreed we should go ahead and merge as is, and he will review/ open issues if needed.
Thanks for all the help everyone!


[SR-1812] HashTable init error: "Generic parameter ObjectType could not be inferred"

Previous ID
SR-1812

Radar
None

Original Reporter
brett (JIRA User)

Type
Bug

Environment
Swift 3 / Xcode 8 beta 1 (8S128d)

Additional Detail from JIRA

Votes
0

Component/s
Compiler

Labels
Bug, DiagnosticsQoI, TypeChecker

Assignee
None

Priority
Medium

md5: 307de2e06433bb33c9405df667523633

Issue Description:
In Swift 3, Xcode 8 gives a buildtime error "Generic parameter 'ObjectType' could not be inferred" when initializing the HashTable class, both through `init()` and through `weakObjects()`.
var hashes = HashTable.weakObjects()

NSHashTable worked correctly in Swift 2.2.

Auditing some of those old issues to see if they are still relevant, this seems to be fixed so I think we can close. Feel free to reopen if you still think there is still something to be discussed.


Variable name clashes in decision trees

The way that pattern matching is represented using decision trees in FCS sometimes leads to variable name shadowing that seems to change the semantics of the original match expression.  I don't know if this is a bug, or if it is because I should be using some other method than names to distinguish variables in general.
Example
Consider the following match expression:

match xs with | x::xs -> x::xs

This is represented in FCS as:

IfThenElse
  (UnionCaseTest (Value val xs,type Microsoft.FSharp.Collections.List<'a>,Cons),
   Let
  ((val xs,
    UnionCaseGet
  (Value val xs,type Microsoft.FSharp.Collections.List<'a>,Cons,field Tail)),
   Let
  ((val x,
    UnionCaseGet
  (Value val xs,type Microsoft.FSharp.Collections.List<'a>,Cons,field Head)),
   NewUnionCase
  (type Microsoft.FSharp.Collections.List<'a>,Cons,[Value val x; Value val xs]))),
   Call
  (None,val raise,[],[type 'a Microsoft.FSharp.Collections.list],
   [NewRecord
  (type Microsoft.FSharp.Core.MatchFailureException,
   [Const (".\Test\Lib.fs",type Microsoft.FSharp.Core.string);
    Const (96,type Microsoft.FSharp.Core.int32);
    Const (8,type Microsoft.FSharp.Core.int32)])]))

At the second let (for x) the xs in scope is the one introduced by the decision tree representation as the name for the tail rather than the scrutinee, so that x becomes the head of the tail of the scrutinee, rather than the tail of the scrutinee.
Question
As far as I can tell, the two xs here both have the same DisplayName, CompiledName, FullName and LogicalName.  Is there some other property that can be used to distinguish variables in general?
For example, is there some property P such that xs.P is the same for the xs occurring on lines 2 and 10 of the FCS representation above, but different from the xs occurring at line 4 (or line 12) of the above?
Ideally I would like a property which is a simple built in datatype like string because I would like to use variables as keys in a Map (e.g. a type environment).

As far as I can tell, the two xs here both have the same DisplayName, CompiledName, FullName and LogicalName. Is there some other property that can be used to distinguish variables in general?

Can you use  the object identity to distinguish?

Also, pragmatically speaking you may be able to use the DeclarationLocation as a qualifier in such cases


Clear saved accounts

Users should be able to clear the logins saved in Identity & wipe localStorage.
Especially when using on a shared computer.
I added a PoC - let me know if you would like me to PR this.

Thanks for the suggestion. We will need to implement a log out flow for an individual account whereby a user verifies they know their seed phrase before clearing their accounts.

Ok so rather than have 1 "clear all" button, have individual buttons that show a "do you know or have safely stored your seedphrase for this account?" confirmation popup before clearing.

Yea maybe even just secondary confirmation and just use clear()
Any thoughts on encrypting all data stored in local storage for additional security?

@maebeam would it be ok just to have a single button to remove all, using the same step1 step2 approach as the sign-up component for confirmation with a i understand log me out confirmation text ?
@carsenk probably best to create separate issue for encrypting all data to discuss a change to do that? That way  they can agree its worth working on before you spend time on it?
I have a feeling it may be a conscious decision why they haven't encrypted all data so would be good to get that background info.

@tijno i'm ok with a flow that signs out of all accounts if the user types some text a la sign up flow
@carsenk if you'd like to propose this please open a new issue. however, i don't see what benefits we would get from encrypting the data in local storage. what would it be encrypted with?

@tijno i'm ok with a flow that signs out of all accounts if the user types some text a la sign up flow
@carsenk if you'd like to propose this please open a new issue. however, i don't see what benefits we would get from encrypting the data in local storage. what would it be encrypted with?

Pubkey data maybe I was thinking, but yea really kind of just pointless, nevermind 👍

@maebeam please check copy & flow below
ones happy with that side I will finalise and submit at PR

copy in confirmation screen:

Wipe Login Data

Confirming this step will remove your login data from your browser. If you use a seedphrase to login to your account, make sure you have recorded this securely.

Enter "i understand log me out" to confirm you really want to wipe your login data!

By proceeding, you agree that you will need to re-enter your seed phrase on login to access your account.

pr #39
closing issue


Add browser push notifications

Simplest approach would be to use the existing FCM features in the backend to push to browsers. Ask me if you want to know more about how it works, can also refer to trustroots code for this https://github.com/Trustroots/trustroots (which I wrote the FCM/push stuff for).

Hi all! Cool that @jskollin and I take this on?