Upgrade to 1.2.0 has broken zimfw/utility module on macOS

zimfw version: 1.2.0 (previous commit is 8724686)
ZIM_HOME:      /Users/javi/.zim
Zsh version:   5.7.1
System info:   Darwin ABAR.local 19.4.0 Darwin Kernel Version 19.4.0: Wed Mar 4 22:28:40 PST 2020; root:xnu-6153.101.6~15/RELEASE_X86_64 x86_64

gist of .zimrc and .zshrc: https://gist.github.com/jeevatattva/b46ec41f880c76ccc2ede3b070795929

Description
After upgrading from 1.1.1 to 1.2.0, aliases inutility are broken.
e.g. output of ls command,
$ ls
ls: illegal option -- -
usage: ls [-@ABCFGHLOPRSTUWabcdefghiklmnopqrstuwx1%] [file ...]

and similarly, chmod +x <file> is failing too.
chmod: illegal option -- -
usage:	chmod [-fhv] [-R [-H | -L | -P]] [-a | +a | =a  [i][# [ n]]] mode|entry file ...
	chmod [-fhv] [-R [-H | -L | -P]] [-E | -C | -N | -i | -I] file ...

Steps to reproduce

Current version 1.1.1.
zimfw upgrade
Open terminal, type ls or use chmod.
Error

Haven't tested this using a vanilla install yet. I'll update this issue when I get to try it.
Images or other information
N.A.

Not sure how the changes in version 1.2.0 would cause this. What do you get when you run
print ${+commands[dircolors]}

? In BSD or macOS, you should get 0.

Thank you for the input.
In my current work environment,
$ print ${+commands[dircolors]}
1

When I get a chance to check this on my other macOS machine, which still has version 1.1.1, I'll report it here.

If you installed the GNU coreutils in your MacOS, but you're still using the BSD ls, then this kind of conflict can happen. The Homebrew coreutils was once broken, as it was symlinking dircolors (but not ls), and that was quickly fixed back then.

The changes in this Pull Request might fix your issue:  https://github.com/zimfw/utility/pull/1

@ericbn You're spot on. I recently installed GNU coreutils but haven't symlink'd those utilities to /usr/bin/local. But have them added in $PATH but with lesser precedence to /bin.
 $ printenv PATH|awk -F: '{for(i=1; i<=NF; i++) print $i}'
/usr/local/bin
/usr/bin
/bin
/usr/sbin
/sbin
/Applications/Wireshark.app/Contents/MacOS
/usr/local/opt/coreutils/libexec/gnu bin
/Users/javi/Development/Go/bin
/Users/javi/Library/Python/3.8/bin

And ls and chmod were working in a sub shell.
I'll check out your changes and report back.


Adding cheatcode vm.mint(token, to, amount)

Component
Forge
Describe the feature you would like
Often it is useful to mint yourself some tokens and you have to come up with some unique ways to get those tokens, probably doing some vm.prank and transfer, but this also requires finding a "victim" address. This is less than ideal. (once or twice I even had tokens "siphoned from the victim" while testing on latest block, ie. victim transferred tokens out)
I propose a generic method for implementing a cheatcode vm.mint(token, to, amount) to mint yourself tokens:

call token.balanceOf
see what slots are being accessed
set the slot to amount (where slot value == token.balanceOf(to))

This would require listening to sload (or more complex analysing the contract bytecode) but eventually this will be generic for most if not all tokens.
Alternatively, replacing the tokens code entirely might work better. (with delegatecall to original code if msg.data != balanceOf)
Additional context
No response

@hananbeer can we close this one per twitter replies?
https://twitter.com/gakonst/status/1576721992035618818
https://twitter.com/msolomon44/status/1576721884778885120

yes, my bad


generalizequerywrites: helper shortcuts

Adds helper functions to more easily make the classes used in cartography.graph.model.
Recreates the AWSLambda ingestion query with these helper functions.
Later, we can add things like automatically including a lastupdated PropertyRef

This is cool. Can you also add to the PR description or a comment on what implementing this would look like without the helper function so that we can compare?

This is cool. Can you also add to the PR description or a comment on what implementing this would look like without the helper function so that we can compare?

Yes, For comparison, we can look at the SimpleNodeWithSubResourceSchema built here manually
https://github.com/lyft/cartography/blob/36c6ed3ba5540a8975b371230b047249c559cf08/tests/data/graph/querybuilder/sample_models/simple_node.py#L46
, versus built with the helper functions:
https://github.com/lyft/cartography/blob/3921739be77714b7866f1eccc7b4038e1da0853b/tests/unit/cartography/graph/test_schema_builder.py#L21
You don't save lines of code, but organizing the code is visually easier for some people.

I personally like the look of option 1 better because it feels more "declarative" to me. For example if I want to see in code how a SimpleNodeWithSubResourceSchema is defined, it makes sense to me that there is a class with that name.
Being able to specify any string as the class name in option 2 feels more error prone to me because for example if I'm someone who doesn't know the internals of how build_node_schema() or build_rel_properties() work, then outside of actually running the code I have no warnings about picking a cls_name that already exists.
Open to other thoughts here.

Let's close this one out for now. We talked about this last month and I think it makes more sense to have these classes statically defined. Happy to revisit at any time though.


[WIP] Error logging callback

What does this PR do?
This PR adds a callback that logs ICL outputs during eval. It modifies the custom metrics to keep track of incorrect model outputs. Each metric is responsible for specifying the table schema for logging cached responses as well as specifying how to format the cached responses using the tokenizer.
The EvalOutputLogging callback is then responsible for logging the cached results in table format after each evaluation.

What issue(s) does this change relate to?

Before submitting

[ ] Have you read the contributor guidelines?
[ ] Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
[ ] Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
[ ] Did you update any related docs and document your change?
[ ] Did you update any related tests and add any new tests related to your change? (see testing)
[ ] Did you run the tests locally to make sure they pass?
[ ] Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

Looks good. Would be nice if there was an option to save results to a file or the cloud but that might be better suited for a different PR doing it for all evals

Looks good except for my one comment. Would be nice if there was an option to save results to a file or the cloud but that might be better suited for a different PR doing it for all evals

I believe this will work out of the box as composer's logger functionality will include wandb/s3/etc in the logger destinations and then log them all simultaneously. I am going to mock up a test branch on foundry that tests s3 and wandb!

Successfully merged here


Make op_test decorator remove the previous class

I replicated the logic in chainer/testing/_bundle.py.
This fixes the warning messages in #6599, which are invalid, I think.

Jenkins, test this please

Jenkins CI test (for commit c37cb360e60151357a629f7401ec5ec190b3b044, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

Jenkins, test this please

Jenkins CI test (for commit c37cb360e60151357a629f7401ec5ec190b3b044, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

LGTM


Addon operator for core-dns

In the first Cluster Addons meeting it was decided to write a addon operator for core-dns. This would be a first concrete step to test the waters, inspire others and get some end-to-end testing mileage out of this.
@justinsb and others (who?) demonstrated interested in this.

I'm interested in building/helping out with an implementation! (1 of n?)

Thanks @johnsonj - that's great!

I'm interested in this too.

Nice one @SataQiu!

I am interested as well!

We're cancelling the meeting tomorrow (19th April), but maybe let's review some of the code/ideas/approaches in the meeting in two weeks?

Next meeting is tomorrow. Did anyone start work on this and can share some of the code or at least some thoughts?

See #7 and #8 for kubebuilder and operator-sdk solutions that play with various ideas regarding packaging, reconciliation, interfaces, edge-cases, RBAC, and usability

Bump -- expect to be resolved by merging #7


specials/ladybug with test.with.iaf=true: Unnecessary build of the Frank!Framework sources

In build.properties, you can set maven.skip.tests=true. That skips the unit tests when building Ladybug, but I am missing a similar option to skip the unit tests of the F!F coude.

I discovered that you can control the FF! build by creating frank-runner/specials/iaf-webapp/build.properties.
I see now that the title of this issue is wrong. It is of course OK that the FF! sources are built. It is about unnecessary execution of the unit tests.


make Literal::Array#push accept multiple values

Related to #134

The current implementation of #push was only allowing for one value to
be passed in, but if the goal is to match ruby's functionality, then it
should accept multiple.
We also want to ensure that we perform the right type checking logic for
both scenarios.

Converting to draft while I try to resolve conflicts...

Thanks @phillipspc !


Not Implemented exception when executing js script

I'm trying to scroll down the list of element on the screen by calling execution of javascript like this:
driver.ExecuteScript("arguments[0].scrollIntoView()", element);

and test failed with the following output in cmd:
POST /session/55DDFBA4-E1B7-4CFA-ADFB-A7E8E8CCC0C0/execute HTTP/1.1
Accept: application/json, image/png
Content-Length: 139
Content-Type: application/json;charset=utf-8
Host: <IP_ADDRESS>:4723
{"script":"arguments[0].scrollIntoView()","args":[{"ELEMENT":"42.7341964.2.414","element-6066-11e4-a52e-4f735466cecf":"42.7341964.2.414"}]}
HTTP/1.1 501 Not Implemented
Content-Length: 84
Content-Type: text/plain; charset=utf-8
Command not implemented: POST: /session/55DDFBA4-E1B7-4CFA-ADFB-A7E8E8CCC0C0/execute
When this method is supposed to be implemented? Or is there any workaround?

We haven't implemented the async javascript API (/session/:sessionid/execute) - this is on our backlog as a feature enhancement.
If you can see the element, you can send a click to it even if its not in the view. This is coming in the next release of WinAppDriver 0.6.

Hi, unfortunately i am not able to send a click to element when it's not in view. I am using 0.6v. Do yoou know why this is not working?

Hey @alakshmi1030
Any estimation on when this can be implemented?

Any update on JavascriptExecutor implementation?

is there a WinAppDriver JS desktop app example available?

@Clemensreijnen Not yet. We welcome any JS (or any other languages) examples from the community!

@hassanuz got some example up and running. https://github.com/Clemensreijnen/AppiumOnWindowsWithJS/blob/master/README.md

Is this enhancement coming in any upcoming release?
Is there any other alternative to scroll web elements into view? I am unable to interact with these since the elements are hidden from view.

Is there any news on this topic?

Hi @vishnu45 and @RobinSmit,
WinAppDriver doesn't support ExecuteScript as of right now.

Hassan, its 2020. Any update on this one?
I got a student in my course who's unable to access HTML controls placed inside of an Internet Explorer control which sits in her UI.
Any clue in this regard will be helpfu.


Edit an exported scene var from the inspector's dropdown menu

If you export a variable to get another scene reference in current one. You get a nice line in the inspector representing the scene. But if you want to edit it, you are to open it manually, though it is right there. It would be a nice feature if user could be able to open/edit the scene from the dropdown menu in the inspector. Fro now you can only 'Edit' the resource properties of the scene, which is not quiet what is expected.
Is applicable for both 2.x and 3.x branches.

Feature and improvement proposals for the Godot Engine are now being discussed and reviewed in a dedicated Godot Improvement Proposals (GIP) (godotengine/godot-proposals) issue tracker. The GIP tracker has a detailed issue template designed so that proposals include all the relevant information to start a productive discussion and help the community assess the validity of the proposal for the engine.
The main (godotengine/godot) tracker is now solely dedicated to bug reports and Pull Requests, enabling contributors to have a better focus on bug fixing work. Therefore, we are now closing all older feature proposals on the main issue tracker.
If you are interested in this feature proposal, please open a new proposal on the GIP tracker following the given issue template (after checking that it doesn't exist already). Be sure to reference this closed issue if it includes any relevant discussion (which you are also encouraged to summarize in the new proposal). Thanks in advance!

This is already possible:
export(PackedScene) var myscene


Turning on and off all the time

Hi there!
I got a weird behaviour with my Hyperion-setup. It is a Lightberry-setup with v4l2 grabber. And for the last 2 months, it works perfectly with standalone effects (Rainbow swirls etc) but as soon as I'm turning on a movie with the grabber activate, it goes something like this: for the first 20-30 seconds, it works perfectly. Then the top and the bottom LEDs of the TV just goes blank. The side LEDs of the TV works for additional 5-6 seconds and then also goes blank. After 5-6 seconds again, it all turns on again and works for 20-30 seconds again .. and it just does that over and over.
I'm not sure really where to start debugging. Is it a power supply error, since the "local" effects seems to work perfectly? I did a screenshot from the grabber, and it seems to work aswell, except for these red lines everywhere. Is that normal? (see attached)

Anyone care helping a beginner of this? :( Can I debug this somehow?

i have the errors myself :(
did you find out anything?

i have the errors myself :(
did you find out anything?

 After that everything seems pretty much better. It's still going on and off, but not as often, more after a couple of minutes or so. Very weird, but yeah that's what I did.

issues with usb grabbers are known, we are working on them


[Candidate 2v2 Green Silk ZH v1] Units and Rangers can be air dropped on outer islands

Observed behavior
Units and Rangers can be air dropped on outer islands. The Dozer I managed to drop just once. Appears to be not straight forward to do.
Expected behavior
Units and Rangers can not be air dropped on outer islands.
Screenshots

Green Silk ZH v1.zip
Fixed this issue, along with #570 and #568.

Fixed


⚠ Samsung has degraded performance

In b7a97b5, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2306 ms

Resolved: Samsung performance has improved in c613f7a.


Restore Pool Shares section

Fixes #1042 .
Changes proposed in this PR:

restore pool shares section tab in profile history

If you have selected network where the subgraph is offline the tab never loads. If i select just the network with online subgraph and refresh it works.

Now UI, output of liquidity should be exactly like we do it on the pool tab where we do not output the datatoken. This is what I get on my pool shares:

Each time i swap tabs/change networks i get different numbers

Yes, I encountered the same issue, still on it

somewhere we have way too many refetches, like when I deselect a network while pool shares tab is open, it looks like 2 rounds of fetches happen shortly after another. This is also visible in the above posted screen recording

I'll hop on this pr, the whole Profile component is acting weird, hope we won't need big refactor

Current state, picked up on what was in here, think all the errors are gone and I also made sure to unify the calculations between what we do on asset's pool tab and here in the pool shares table. So far, so good but one major problem I can't find the exact reason yet. Basically the numbers are correct, but they are on the wrong asset, here the below asset should display 15 OCEAN and the top one 11 OCEAN

Somewhere in getAssetsFromPoolShares() matching ddoList with assetList seem to not work out correctly, investigating...

I'm checking it out too

The numbers look good. We can do a lot of optimizations at a later time. Currently if i uncheck/check another network we refetch everything and it's slow.

Currently if i uncheck/check another network we refetch everything and it's slow.

yes, whenever chainIds changes all subgraphs are hit again to get the new poolShares in the Profile provider. Which then triggers various effects in subcomponents to recalculate. Only using some delta between previous selected chainIds and newly selected ones, and then only hit those subgraphs could be a first effective optimization


Update navbar.md

https://github.com/react-bootstrap/react-bootstrap/issues/5752
Regarding issues raised in the link above by @kyletsang  I am proposing the following changes this document:
https://getbootstrap.com/docs/5.0/components/navbar/
Under section “How it works” I can eliminate bullets 2 and 3. And replace them with a bullet point about the update requiring .container within all navbars and how it simplifies the requirements for spacing and flex.
I updated all the code examples from div class="container-fluid" to div class="container" in lines 39, 89, 96, 122, 141, 170, 191, 229, 242, 256, 282, 294, 325, 354, 383, 456, 464, 472, 480, 496, 547, 577, 607, 645,
Then on section “containers” I change that paragraph to “All navbars require a .container within. You can also wrap an entire navbar with a .container which does not require any overrides and works across all devices.“
Also removed div class = “container-fluid” /div tag from the first example code in the “containers” section.
Hope you like the changes.

Is it safe to close, then?

Actually the changes were meant to be in react-bootstrap, not regular bootstrap 😀
We just need our docs to mention the inner container and fix the example code.

Shit 🤦🏽♂ I'm so sorry. I'm still really new to GitHub, and struggle to find where everything is at 😕. Again, I'm sorry... can I still contribute and make those edits or no?

@bravogeorge, no problem, we were all new at some point.  Did you make the changes directly in the Github interface?  If so, I'd recommend cloning a local copy of react-bootstrap and modifying it there.  There should be a number of files you'll need to update to to close that issue.
@ffoodd, we can close this.


Running multiple Task parallelly

Is there any option available for Community version to run multiple tasks in parallel?

You can add multiple scripts to a Script task or several tables to an import/export task

Option to create a composite task (which can include import, export, script etc. at the same time) and schedule it is available in Enterprise Edition only.

i have save export task from the collection of scripts; however, i have to run one at a time.

I understand your question now. I mark the ticket as a feature request.


Disable automatic scalafmt

This is unbearably slow.

[x] I've read the CONTRIBUTING guidelines

Oh, yes. That makes sense, we should also add the scalafmt check to travis as @xuwei-k suggested.

You could give sbt-scalafmt 2.0.0 a try.  It includes performance improvements: https://github.com/scalameta/sbt-scalafmt/releases/tag/v2.0.0, both in using zinc's analysis to make scalafmt incremental and caching of the Scalafmt object.

closing in favor of https://github.com/sbt/sbt/pull/4623


UI broken in compare page.

URL: https://demo.gitea.com/phoedos/pmd/compare/main...big-commit-simulation

Now is Internal Server Error

This page works in my local. (But the repo is too big to migrate, so I cloned it, and only pushed two branches to my local server, I think there's no diffs)

I remember you are using MacOS. Maybe it is related.

After I forked this repository to my account, and compare worked.

Now working fine for me. Maybe the compare is too large and it takes time to load.


feat: added title to s51 advice api

Describe your changes
Ticket: https://pins-ds.atlassian.net/browse/ASB-2196
Adds title field to S51 advice both endpoints
Type of change 🧩

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update
[ ] Other (please explain in the description section above)

Checklist before requesting a review

[x] I have performed a self-review of my own code
[x] I have double checked this work does not include any hardcoded secrets or passwords
[x] I have made corresponding changes to the documentation
[x] I have provided details on how I have tested my code
[x] I have referenced the ticket number above
[x] I have provided a description of the ticket
[x] I have included unit tests to cover any testable code changes

:tada: This PR is included in version 1.7.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.17.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.22.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Upgrade to bdg-formats:0.6.0, add Fragment datatype converters

Resolves #779, #788. This is a fairly big PR and could use some close review. I'm CCing @arahuja to review the modifications to the VariantContextConverter, and @laserson and @ilveroluca to review the Fragment additions.
There are a few things in specific that I think could use a closer look. I'll comment on these inline.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/892/Build result: FAILUREGitHub pull request #815 of commit fb9d61b565f699aa299586411f15ad05919ec789 automatically merged.Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos spark-test) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/815/merge^{commit} # timeout=10 > git branch -a --contains 4f6bb9dd5981f6a3e9f3d9a8603fceea97ba47c3 # timeout=10 > git rev-parse remotes/origin/pr/815/merge^{commit} # timeout=10Checking out Revision 4f6bb9dd5981f6a3e9f3d9a8603fceea97ba47c3 (origin/pr/815/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f 4f6bb9dd5981f6a3e9f3d9a8603fceea97ba47c3First time build. Skipping changelog.Triggering ADAM-prb ? 2.6.0,2.10,1.4.1,centosTriggering ADAM-prb ? 2.6.0,2.11,1.4.1,centosTouchstone configurations resulted in FAILURE, so aborting...Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/893/Build result: FAILUREGitHub pull request #815 of commit f748972ee0add05a9e8e7b468115069a0677e4e6 automatically merged.Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos spark-test) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/815/merge^{commit} # timeout=10 > git branch -a --contains 2652b76de6cc2f4a8f71ba26634cac6f5db01bd6 # timeout=10 > git rev-parse remotes/origin/pr/815/merge^{commit} # timeout=10Checking out Revision 2652b76de6cc2f4a8f71ba26634cac6f5db01bd6 (origin/pr/815/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f 2652b76de6cc2f4a8f71ba26634cac6f5db01bd6First time build. Skipping changelog.Triggering ADAM-prb ? 2.6.0,2.10,1.4.1,centosTriggering ADAM-prb ? 2.6.0,2.11,1.4.1,centosTouchstone configurations resulted in FAILURE, so aborting...Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

Jenkins, test this please.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/896/Build result: FAILUREGitHub pull request #815 of commit f748972ee0add05a9e8e7b468115069a0677e4e6 automatically merged.Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos spark-test) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/815/merge^{commit} # timeout=10 > git branch -a --contains 2652b76de6cc2f4a8f71ba26634cac6f5db01bd6 # timeout=10 > git rev-parse remotes/origin/pr/815/merge^{commit} # timeout=10Checking out Revision 2652b76de6cc2f4a8f71ba26634cac6f5db01bd6 (origin/pr/815/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f 2652b76de6cc2f4a8f71ba26634cac6f5db01bd6First time build. Skipping changelog.Triggering ADAM-prb ? 2.6.0,2.10,1.4.1,centosTriggering ADAM-prb ? 2.6.0,2.11,1.4.1,centosTouchstone configurations resulted in FAILURE, so aborting...Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/897/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/908/
Test PASSed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/909/Build result: FAILURE[...truncated 16 lines...]First time build. Skipping changelog.Triggering ADAM-prb ? 2.6.0,2.10,1.4.1,centosTriggering ADAM-prb ? 2.6.0,2.11,1.4.1,centosTriggering ADAM-prb ? 2.3.0,2.10,1.3.1,centosTriggering ADAM-prb ? 2.3.0,2.11,1.3.1,centosTriggering ADAM-prb ? 2.6.0,2.11,1.3.1,centosTriggering ADAM-prb ? 2.3.0,2.10,1.4.1,centosTriggering ADAM-prb ? 2.3.0,2.11,1.2.1,centosTriggering ADAM-prb ? 1.0.4,2.11,1.2.1,centosTriggering ADAM-prb ? 1.0.4,2.10,1.2.1,centosTriggering ADAM-prb ? 2.3.0,2.11,1.4.1,centosTriggering ADAM-prb ? 2.3.0,2.10,1.2.1,centosTriggering ADAM-prb ? 2.6.0,2.10,1.3.1,centosADAM-prb ? 2.3.0,2.10,1.3.1,centos completed with result FAILUREADAM-prb ? 2.3.0,2.11,1.3.1,centos completed with result FAILUREADAM-prb ? 2.6.0,2.11,1.3.1,centos completed with result FAILUREADAM-prb ? 2.3.0,2.10,1.4.1,centos completed with result FAILUREADAM-prb ? 2.3.0,2.11,1.2.1,centos completed with result FAILUREADAM-prb ? 1.0.4,2.11,1.2.1,centos completed with result FAILUREADAM-prb ? 1.0.4,2.10,1.2.1,centos completed with result FAILUREADAM-prb ? 2.3.0,2.11,1.4.1,centos completed with result FAILUREADAM-prb ? 2.3.0,2.10,1.2.1,centos completed with result FAILUREADAM-prb ? 2.6.0,2.10,1.3.1,centos completed with result FAILURENotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/910/Build result: FAILURE[...truncated 16 lines...]First time build. Skipping changelog.Triggering ADAM-prb ? 2.6.0,2.10,1.4.1,centosTriggering ADAM-prb ? 2.6.0,2.11,1.4.1,centosTriggering ADAM-prb ? 2.3.0,2.10,1.3.1,centosTriggering ADAM-prb ? 2.3.0,2.11,1.3.1,centosTriggering ADAM-prb ? 2.6.0,2.11,1.3.1,centosTriggering ADAM-prb ? 2.3.0,2.10,1.4.1,centosTriggering ADAM-prb ? 2.3.0,2.11,1.2.1,centosTriggering ADAM-prb ? 1.0.4,2.11,1.2.1,centosTriggering ADAM-prb ? 1.0.4,2.10,1.2.1,centosTriggering ADAM-prb ? 2.3.0,2.11,1.4.1,centosTriggering ADAM-prb ? 2.3.0,2.10,1.2.1,centosTriggering ADAM-prb ? 2.6.0,2.10,1.3.1,centosADAM-prb ? 2.3.0,2.10,1.3.1,centos completed with result FAILUREADAM-prb ? 2.3.0,2.11,1.3.1,centos completed with result FAILUREADAM-prb ? 2.6.0,2.11,1.3.1,centos completed with result FAILUREADAM-prb ? 2.3.0,2.10,1.4.1,centos completed with result FAILUREADAM-prb ? 2.3.0,2.11,1.2.1,centos completed with result FAILUREADAM-prb ? 1.0.4,2.11,1.2.1,centos completed with result FAILUREADAM-prb ? 1.0.4,2.10,1.2.1,centos completed with result FAILUREADAM-prb ? 2.3.0,2.11,1.4.1,centos completed with result FAILUREADAM-prb ? 2.3.0,2.10,1.2.1,centos completed with result FAILUREADAM-prb ? 2.6.0,2.10,1.3.1,centos completed with result FAILURENotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

Jenkins, test this please.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/911/
Test PASSed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/917/Build result: FAILURE[...truncated 22 lines...]First time build. Skipping changelog.Triggering ADAM-prb ? 2.6.0,2.10,1.4.1,centosTriggering ADAM-prb ? 2.6.0,2.11,1.4.1,centosTriggering ADAM-prb ? 2.3.0,2.10,1.2.1,centosTriggering ADAM-prb ? 2.6.0,2.10,1.3.1,centosTriggering ADAM-prb ? 2.6.0,2.11,1.3.1,centosTriggering ADAM-prb ? 2.3.0,2.11,1.2.1,centosTriggering ADAM-prb ? 2.3.0,2.10,1.4.1,centosTriggering ADAM-prb ? 2.3.0,2.10,1.3.1,centosTriggering ADAM-prb ? 2.3.0,2.11,1.4.1,centosTriggering ADAM-prb ? 2.3.0,2.11,1.3.1,centosTriggering ADAM-prb ? 1.0.4,2.11,1.2.1,centosTriggering ADAM-prb ? 1.0.4,2.10,1.2.1,centosADAM-prb ? 2.3.0,2.10,1.2.1,centos completed with result SUCCESSADAM-prb ? 2.6.0,2.10,1.3.1,centos completed with result SUCCESSADAM-prb ? 2.6.0,2.11,1.3.1,centos completed with result SUCCESSADAM-prb ? 2.3.0,2.11,1.2.1,centos completed with result SUCCESSADAM-prb ? 2.3.0,2.10,1.4.1,centos completed with result SUCCESSADAM-prb ? 2.3.0,2.10,1.3.1,centos completed with result FAILUREADAM-prb ? 2.3.0,2.11,1.4.1,centos completed with result FAILUREADAM-prb ? 2.3.0,2.11,1.3.1,centos completed with result FAILUREADAM-prb ? 1.0.4,2.11,1.2.1,centos completed with result FAILUREADAM-prb ? 1.0.4,2.10,1.2.1,centos completed with result FAILURENotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

Seems like a git force-push test failure, Jenkins retest this please

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/918/Build result: FAILUREGitHub pull request #815 of commit a030f785aafcffe903f352fe260be17f2629d67f automatically merged.Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos spark-test) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/815/merge^{commit} # timeout=10 > git branch -a --contains 74212d3177a2a30e9ea6ae30306ae2c08c26a5cc # timeout=10 > git rev-parse remotes/origin/pr/815/merge^{commit} # timeout=10Checking out Revision 74212d3177a2a30e9ea6ae30306ae2c08c26a5cc (origin/pr/815/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f 74212d3177a2a30e9ea6ae30306ae2c08c26a5cc > git rev-list 74212d3177a2a30e9ea6ae30306ae2c08c26a5cc # timeout=10Triggering ADAM-prb ? 2.6.0,2.10,1.4.1,centosTriggering ADAM-prb ? 2.6.0,2.11,1.4.1,centosTouchstone configurations resulted in FAILURE, so aborting...Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

oops

[ERROR] Failed to execute goal on project adam-core_2.10: Could not resolve dependencies for project org.bdgenomics.adam:adam-core_2.10:jar:0.17.2-SNAPSHOT: Could not find artifact org.bdgenomics.bdg-formats:bdg-formats:jar:e1ca0a3 in central (http://repo.maven.apache.org/maven2) -> [Help 1]

https://github.com/fnothaft/adam/pull/7 was merged in here but was still pointing to a custom build of bdg-formats later than 0.6.0
Let me push my change to bdg-formats, we can release a 0.6.1 or 0.7.0, then depend on that here.

Proposed https://github.com/bigdatagenomics/bdg-formats/pull/63 with the change that https://github.com/fnothaft/adam/pull/7 (and now this PR) needs

This is up to date with @ryan-williams's fixes (that upgrade us to bdg-formats/0.6.1). I think this resolves all outstanding issues.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/919/Build result: FAILUREGitHub pull request #815 of commit d2e94787c26851c2466bc58bde8f73d0faf94187 automatically merged.Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos spark-test) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/815/merge^{commit} # timeout=10 > git branch -a --contains bc4503d59d30134ccbdc82c62e6fbadc43b86677 # timeout=10 > git rev-parse remotes/origin/pr/815/merge^{commit} # timeout=10Checking out Revision bc4503d59d30134ccbdc82c62e6fbadc43b86677 (origin/pr/815/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f bc4503d59d30134ccbdc82c62e6fbadc43b86677 > git rev-list 74212d3177a2a30e9ea6ae30306ae2c08c26a5cc # timeout=10Triggering ADAM-prb ? 2.6.0,2.10,1.4.1,centosTriggering ADAM-prb ? 2.6.0,2.11,1.4.1,centosTouchstone configurations resulted in FAILURE, so aborting...Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

Jenkins, test this please.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/920/Build result: FAILUREGitHub pull request #815 of commit d2e94787c26851c2466bc58bde8f73d0faf94187 automatically merged.Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos spark-test) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/815/merge^{commit} # timeout=10 > git branch -a --contains bc4503d59d30134ccbdc82c62e6fbadc43b86677 # timeout=10 > git rev-parse remotes/origin/pr/815/merge^{commit} # timeout=10Checking out Revision bc4503d59d30134ccbdc82c62e6fbadc43b86677 (origin/pr/815/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f bc4503d59d30134ccbdc82c62e6fbadc43b86677 > git rev-list bc4503d59d30134ccbdc82c62e6fbadc43b86677 # timeout=10Triggering ADAM-prb ? 2.6.0,2.10,1.4.1,centosTriggering ADAM-prb ? 2.6.0,2.11,1.4.1,centosTouchstone configurations resulted in FAILURE, so aborting...Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

missing unordered.sam, maybe I forgot to git add it?

or it's in adam-core test/resources and is being referenced from adam-cli and the letter's not being found

Ah, let me fix that.

weirdly, it passes for me locally.
should we make adam-cli tests include the adam-core test/resources in their resources path?

we already do a somewhat silly thing and have the same bqsr1.sam file in adam-cli and adam-core

Yeah, I've just symlinked them from adam-core to adam-cli.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/921/Build result: FAILUREGitHub pull request #815 of commit<PHONE_NUMBER>d38e47960078b1d1ce449d910f8774 automatically merged.Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos spark-test) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/815/merge^{commit} # timeout=10 > git branch -a --contains b78391de596106ed2c3b8e246ed5128b748da22a # timeout=10 > git rev-parse remotes/origin/pr/815/merge^{commit} # timeout=10Checking out Revision b78391de596106ed2c3b8e246ed5128b748da22a (origin/pr/815/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f b78391de596106ed2c3b8e246ed5128b748da22a > git rev-list bc4503d59d30134ccbdc82c62e6fbadc43b86677 # timeout=10Triggering ADAM-prb ? 2.6.0,2.10,1.4.1,centosTriggering ADAM-prb ? 2.6.0,2.11,1.4.1,centosTouchstone configurations resulted in FAILURE, so aborting...Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

Jenkins, retest this please

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/922/
Test PASSed.

Could we get merge/additional review by the end of the week? This has been open more than a month.

This LGTM @fnothaft. A couple of observations:

Sorry that my PR on this PR has cluttered up the review here! I think that leaving that one hanging until we got this one in might have been a better course of action, I'll try to be more clear about that in the future.
This seems similar to the last time I looked at it but with the simplification that you took out the Sequence stuff and just have ARs in the Fragment, right?

Fixed the oops @ryan-williams and rebased.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/946/Build result: FAILUREGitHub pull request #815 of commit 283ea9de6876e3b0add91ea50ca046d4a52dc7f6 automatically merged.Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos spark-test) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/815/merge^{commit} # timeout=10 > git branch -a --contains 3506f59eec4f134e457c43afa5dd771bb1eaec03 # timeout=10 > git rev-parse remotes/origin/pr/815/merge^{commit} # timeout=10Checking out Revision 3506f59eec4f134e457c43afa5dd771bb1eaec03 (origin/pr/815/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f 3506f59eec4f134e457c43afa5dd771bb1eaec03 > git rev-list b78391de596106ed2c3b8e246ed5128b748da22a # timeout=10Triggering ADAM-prb ? 2.6.0,2.10,1.4.1,centosTriggering ADAM-prb ? 2.6.0,2.11,1.4.1,centosTouchstone configurations resulted in FAILURE, so aborting...Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

Jenkins, test this please.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/948/
Test PASSed.

@massie @laserson @ryan-williams if I don't get any further comments on this, I will merge it myself on Monday.

I just reviewed this again and I didn't see any outstanding issues by @laserson or @ryan-williams, so I'm going to merge it now.


Updated tabula jar, fix boolean handling and fix silent op

Contains 3 commits by Kcivey,
I added some Log4j flags which fix silent operation.

Thanks.


added improved po_box handling

Before:
 StreetAddress::US.parse("PO Box 163, Alexandria, VA, 22303")
 => #<StreetAddress::US::Address:0x007ffad0b2a8e0 @unit_prefix="Box", @unit="163", @street="Alexandria", @redundant_street_type=true, @street_type=nil>

after:
 StreetAddress::US.parse("PO Box 163 Alexandria VA 22303")
 => #<StreetAddress::US::Address:0x007f89d99ec1f8 @unit_prefix="Box", @unit="163", @city="Alexandria", @state="VA", @street="22303", @redundant_street_type=true, @street_type=nil>

I mentioned this in slack, but If you're expecting that unit key value to be PO Box, the test should be testing for it to be PO Box it should fail until it's fixed. Context: https://crowdfiber.slack.com/archives/C4RMP4CJE/p1520285117000599


Corrrect authorization notes in README.md

The service account needs to be member of App Engine default account, per troubleshooting and docs:
https://cloud.google.com/functions/docs/troubleshooting#role-actAs
https://cloud.google.com/functions/docs/reference/iam/roles#additional-configuration
https://cloud.google.com/functions/docs/concepts/iam#runtime_service_accounts

@googlebot I signed it!


Added instructions for increasing the priority of tickets

Signed-off-by: Paul Rothrock<EMAIL_ADDRESS>

This issue has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!
/cc @jasonblais @hanzei

@icelander Gentle reminder about this PR

@icelander I'm closing this PR for now, but keeping the branch. Please just reopen it, if you still want to work on this.


How to open dialog for new bookmark ?

Hello,
With DBeaver under kubuntu 18 I try to use bookmarks as it is written at
https://github.com/dbeaver/dbeaver/wiki/Bookmarks
But when some table is opened(I select 1st column and 1st row) : https://imgur.com/a/79W9217
I can not to open dialog to save this location as bookmark.
I press CTRL+d and nothing happened.
I found option to set hot key for bookmark dialog activating : https://imgur.com/a/jQ5aSXf
but setting CTRL+d  hot key did not help and no open dialog to save this location as bookmark.
I did not find any ( context ) menu options for this...

How can I do it?

If there is a way to freeze 1 column(id) at left part and always
to have it visible while scrolling columns to right ?

Thanks!

1 Please set focus on the table in DB Navigator tree and create bookmark via shortcut or Edit>Add bookmark
2 Yes: please right-click on the column header and select Pin column there

If you what to keep the column pinned after closing the table, press Save filter settings button to the right of the top filter field of table Editor. The column will be pinned during current DBeaver session.


Auto increment the ID value when the value is null

I have encountered an unexpected behaviour trying to insert nested data into the store - all objects where just created, so they do not have an ID yet.
Here are my models:
export default class Board extends Model {
  static entity = 'boards'

  static fields () {
    return {
		id: this.increment(),
		name: this.string('my board'),
		holds: this.hasMany(Hold, 'board_id')
    }
  }
}

export default class Hold extends Model {
  static entity = 'holds'

  static fields () {
    return {
      id: this.increment(),
      ip: this.string(),
      board_id: this.number()
    }
  }

When I call:
Board.dispatch('insertOrUpdate', { data: state.current_board }).then((entities) => { .... })

where data equals:
{
	"$id": 1,
	"id": 1,
	"name": "bigb",
	"holds": [
		{
			"id": null,
			"ip": "<IP_ADDRESS>"
		},
		{
			"id": null,
			"ip": "<IP_ADDRESS>",
		},
		{
			"id": null,
			"ip": "<IP_ADDRESS>",
		},
		{
			"id": null,
			"ip": "<IP_ADDRESS>",
		},
		{
			"id": null,
			"ip": "<IP_ADDRESS>",
		},
		{
			"id": null,
			"ip": "<IP_ADDRESS>",
		},
		{
			"id": null,
			"ip": "<IP_ADDRESS>",
		},
		{
			"id": null,
			"ip": "<IP_ADDRESS>",
		},
		{
			"id": null,
			"ip": "<IP_ADDRESS>",
		}
	]
}

The returned entities looks like this:
{
	"boards": [
		{
			"$id": 1,
			"id": 1,
			"name": "bigb",
			"holds": []
		}
	],
	"holds": [
		{
			"$id": 2,
			"id": 2,
			"ip": "<IP_ADDRESS>",
			"board_id": 1,
		}
	]
}

Query for ID with holds:
Board.getters('query')().with('holds').find(entities.boards[0].id) ==>
 {
	"$id": 1,
	"id": 1,
	"name": "bigb",
	"holds": [
		{
			"$id": 2,
			"id": 2,
			"ip": "<IP_ADDRESS>",
			"board_id": 1,
		}
	]
}

I can not make any sense of this...
Why is only the last Hold created?
Am I doing something wrong?
-- Thank you for this beautiful piece of software!

Hm... Could you try removing id field from holds to see if that make any difference? It should work with null but maybe this is a defect in somewhere and I would like to see if it changes anything!

Thanks for your quick reply.
Yep, that's it!
I'm passing Hold() objects to insertOrUpdate. If remove those id fields beforehand (delete hold.id) to remove those id-fields - it just works as expected.

... and if I set those ids to id = undefined, that also works fine.

Thank you for the confirmation! Now I understand that this is the at least expected behavior right now that Vuex ORM will treat null as a valid value. So the id key would not getting incremented.
I guess there's no point of arrowing null as a value when defining increment field, so let me fix this to be same behavior as undefined!

Thank you for looking into it! Would be great to have a fix, as the workaround - deleting fields beforehand - feels rather clumsy. :)

I further noticed that although the number of created objects is correct, the reference ids, ie. board_id is 0 or all objects.
Is this a related problem, or should I create a new one?

Hm... Yeah, that is weird. I'll look into that problem along with this issue too! If it's not related, I'll separate issue for that.

Now this issue is fixed at Vuex ORM 0.26.1! 🎉
https://github.com/vuex-orm/vuex-orm/releases/tag/v0.26.1
Thanks to @kkyouhei for the awesome fix!


Improvements to cvrp_reload.py

Fixed an issue where the wrong index could have been passed to the disjunction in different examples.
Improved module documentation

oups, I manage to rebase  your branch against master but need a new PR to change here -_-

OK push by hand your branch on master...
git clone git@github.com:robin-vjc/or-tools.git
git checkout improve-cvrp-reload-example
git remote add google git@github.com:google/or-tools.git
git fetch --all
git rebase google/master
git push google HEAD:master

@Mizux sorry - I realized something was off when I started to receive a bunch of CI notifications. Will make a new PR to master.

@robin-vjc no need a new PR I manage to push them on master...


Make init.py work in python3

Adding the updated relative import style for py3 compatibility (from .core import *) /

:sparkles: :cake: :sparkles:


"Pădurișu" is listed in the drop-down menu

Description:
"Pădurișu" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Pădurișu" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Pădurișu, CĂLĂRAȘI (Frumușani)".


Proposal to fix redshift and pg operator store_last_results

In the redshift and pg operators, the document store_last_results is described in the document, but it can not be used.
http://docs.digdag.io/operators/redshift.html
store_last_results: BOOLEAN

Whether to store the query results to redshift.last_results parameter. Default: false.

Setting first stores the first row to the parameter as an object (e.g. ${redshift.last_results.count}).

Setting all stores all rows to the parameter as an array of objects (e.g. ${redshift.last_results[0].name}). If number of rows exceeds limit, task fails.

I confirmed the code inside.
https://github.com/treasure-data/digdag/blob/14545bdf0eab7aa93964c9cdbcb766ca5c9a10fb/digdag-standards/src/main/java/io/digdag/standards/operator/td/TdRunOperatorFactory.java#L70
pg and reshift did not seem to be implemented yet.
Since I think that users are having trouble if unimplemented features are listed, I would like to delete items of pg and redshift store_last_resutls until they are implemented.
I modified it like the following and built it. I want to send pullreq, but is there any problem?
diff --git a/digdag-docs/src/operators/pg.md b/digdag-docs/src/operators/pg.md
index 20613d354..4ae26b3a8 100644
--- a/digdag-docs/src/operators/pg.md
+++ b/digdag-docs/src/operators/pg.md
@@ -25,20 +25,6 @@ _export:
   insert_into: summary_table

-+select_members:
-  pg>: select_members.sql
-  store_last_results: first
-
-+send_email:
-  for_each>:
-    member: ${pg.last_results}
-  _do:
-    mail>: body.txt
-    subject: Hello, ${member.name}!
-    to: [${member.email}]
-```
-
 ## Secrets

 * **pg.password**: NAME
diff --git a/digdag-docs/src/operators/redshift.md b/digdag-docs/src/operators/redshift.md
index 4373ccd2b..b2544d6a7 100644
--- a/digdag-docs/src/operators/redshift.md
+++ b/digdag-docs/src/operators/redshift.md
@@ -25,20 +25,6 @@ _export:
   insert_into: summary_table

-+select_members:
-  redshift>: select_members.sql
-  store_last_results: first
-
-+send_email:
-  for_each>:
-    member: ${redshift.last_results}
-  _do:
-    mail>: body.txt
-    subject: Hello, ${member.name}!
-    to: [${member.email}]
-
 ## Secrets

 * **aws.redshift.password**: NAME
@@ -91,24 +77,6 @@ _export:
   download_file: output.csv

-* **store_last_results**: BOOLEAN
-
-  Whether to store the query results to ``redshift.last_results`` parameter. *Default:* `false`.
-
-  Setting ``first`` stores the first row to the parameter as an object (e.g. ``${redshift.last_results.count}``).
-
-  Setting ``all`` stores all rows to the parameter as an array of objects (e.g. ``${redshift.last_results[0].name}``). If number of rows exceeds limit, task fails.
-
-  Examples:
-
-  store_last_results: first
-
-  store_last_results: all
-
 * **database**: NAME

   Database name.

Hello, @hiroyukim
I tried this issue using the digdag 0.9.24.
The store_last_results parameter worked fine with the pg> operator.
(I don't have redshift test environment, so I can't test redshift> operator.)
https://github.com/hiroyuki-sato/digdag-support/blob/master/core_717_pg_store_test/00README.md

@hiroyuki-sato
I encountered this event around November, and I could confirm that it works in the current version. Thank you for confirmation.


fix: RunLoadTest renamed to RunLoadTestV1 on GH

@nschonni Thank you for your contribution, I am merging it now and it should be live soon.


Graph Query Error: Something went wrong processing the GraphQL request.

Description
Steps to reproduce

Change to "staging" or "production"-environment
Now suddenly you cannot query for "images {
url
}" although the property is present in the .json File
Changing to "dev"-environment fixes the problem, until you change the environment again.

Other information

Embedded Assets version: 2.10.7
Craft CMS version: 3.7.44

Thanks for reporting - should be fixed now in Embedded Assets 2.11.0.


added sanskar-p's details to data.json

Pull Request
Proposed Changes

Give a summary of the changes made in the repository.
List the dependencies used.
Also mention the issue number [Fixes #(issue)].

Issue #40
Added my details to data.json
Types of changes made

[ ] Fixed Bug
[ ] Added new Features
[x] Edited Documentations
[ ] Enhanced the working of code
[ ] Additional Changes
Mention any Additional Change here

Additional Info
Provide additional information(if any) you want to convey.
Viability of Code
Describe the tests that you ran to verify the changes made. Mention the tests for easy reproducibility.

Test 1
Test 2

Mention(if any) specific Test Configurations used:

Filmware version:
Hardware:
Toolchain:
SDK:

Screenshots or GIFs (if any)
Attach screenshots of the changes made for easy reference.

Original
Updated

Attach_Original_Screenshot
Attach_Updated_Screenshot

Checklist:

[x] My code follows the Mentioned Guidelines for the project
[x] I have self-reviewed the changes made
[] I have made the changes easy to understand by adding comments
[ ] My changes does not generate new warnings/errors
[ ] I have attached relevant screenshots to display the changes made
[x] I have made the required changes to the documentations

@all-contributors add @sanskar-p  for docs


Slack link is inactive

Hi K3ai team,
I like your tool a lot, is there a working slack link for easier communication?

hi there @mat-ej  sorry about that here's the active link https://join.slack.com/t/k3ai/shared_invite/zt-s8p2id50-CVcFTz_bV_X57UKcnOmV9A
btw did you try our new version of the tool k3ai-core?


Feature request: Get position in viewport

So local vs global coordinate systems were a bane of my existence for a pretty long time. Moving children of different parents to each other (for sick UI effects for example) can get insane with get_position_in_parent()+get_parent().get_position_in_parent() and so on for each parent you have.
What I'm sure a lot of people will find use of is a quick and simple way to just grab coordinates of a node with viewport 0.0 being origin and move them based on that.

we have Control.get_global_pos() and Node2D.get_global_pos()
isn't that enough for you?

global is not good enough for complex hierarchy, for 2d canvasitem::get_viewport_transform ( ) should work per the docs.

Get this item’s transform in relation to the viewport.

@volzhs no it's not. I can give you an example: You have CanvasLayer/Control/GridContrainer/Sprite and CanvasLayer/Control2/Sprite in different locations. Try to lerp one node to another with global_pos, you'll see why I brought up this issue.
@tamkcr Yes, that's exactly what I was looking for. Thank you very much!


File upload iPhone

Hi everyone!
Everytime I upload a file (image) from my phone, my server always receive the filename : image.jpg. I have many problems with my cache because of this... :(  (Django PIL)
Can I change the file.name of the file that I want to upload?
Thank you very much!

use Upload.rename() read the docs.


type 'Null' is not a subtype of type 'String' in type cast (version 2.0.9)

Command:
$ escompress -i"input.txt" -o"output.lz4"
Error message:
type 'Null' is not a subtype of type 'String' in type cast
#0      main (file:///home/xxx/.pub-cache/hosted/pub.dev/es_compression-2.0.9/bin/es_compress.dart:57:40)
#1      _delayEntrypointInvocation.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:295:33)
#2      _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:192:26)

Env:
Tested on both Windows 10  and Ubuntu
Dart SDK version: 2.19.2 (stable) (Unknown timestamp) on "linux_x64"
es_compression-2.0.9

Pushed 2.0.10 to pub.dev.
Please try again and let me know if everything work for you.

@sethloco
It works for me.
Thanks!


dotnet 3.1 Support

When is it likely to happen?

@oriolaakeem: Could you clarify exactly what you're expecting? Are you talking about libraries or templates? I'd expect the libraries to work with .NET Core 3.1 already, as they target netstandard2.0.
We have no current plans for the libraries here, but if you're facing a problem I'd be happy to look into it, if you can provide more details.

the possibility is using google-cloud-dotnet-powerpack for net core 3.1 projects and the templates as well. I tried to set up a new project using the template. It didn't work

"google-cloud-dotnet-powerpack" isn't a package though - it's just the name of this repo.
The templates haven't been updated in a long time, and should potentially be deleted - but the packages should be fine.
I really hope there's no need for the templates to be honest - if you basically just want to install the ASP.NET Core Diagnostics packages, I suggest you read https://googleapis.dev/dotnet/Google.Cloud.Diagnostics.AspNetCore/latest/index.html which is more up-to-date.


[tinyutf8] Updating to v4.0.2

Update DuffsDevice/tinyutf8 library from v3.0.1 to v4.0.2

Thanks for the PR!


Deprecation Notice: Class ParsedownExtraTest located

proxychains4 composer update
[proxychains] config file found: /usr/local/etc/proxychains.conf
[proxychains] preloading /usr/local/Cellar/proxychains-ng/4.14/lib/libproxychains4.dylib
Loading composer repositories with package information
Updating dependencies (including require-dev)
Nothing to install or update
Package container-interop/container-interop is abandoned, you should avoid using it. Use psr/container instead.
Package moontoast/math is abandoned, you should avoid using it. Use brick/math instead.
Package zendframework/zend-code is abandoned, you should avoid using it. Use laminas/laminas-code instead.
Package zendframework/zend-escaper is abandoned, you should avoid using it. Use laminas/laminas-escaper instead.
Package zendframework/zend-eventmanager is abandoned, you should avoid using it. Use laminas/laminas-eventmanager instead.
Package zendframework/zend-http is abandoned, you should avoid using it. Use laminas/laminas-http instead.
Package zendframework/zend-loader is abandoned, you should avoid using it. Use laminas/laminas-loader instead.
Package zendframework/zend-math is abandoned, you should avoid using it. Use laminas/laminas-math instead.
Package zendframework/zend-server is abandoned, you should avoid using it. Use laminas/laminas-server instead.
Package zendframework/zend-stdlib is abandoned, you should avoid using it. Use laminas/laminas-stdlib instead.
Package zendframework/zend-uri is abandoned, you should avoid using it. Use laminas/laminas-uri instead.
Package zendframework/zend-validator is abandoned, you should avoid using it. Use laminas/laminas-validator instead.
Package zendframework/zend-xmlrpc is abandoned, you should avoid using it. Use laminas/laminas-xmlrpc instead.
Package zendframework/zendxml is abandoned, you should avoid using it. Use laminas/laminas-xml instead.
Generating optimized autoload files
Deprecation Notice: Class ParsedownExtraTest located in ./vendor/erusev/parsedown-extra/test/ParsedownExtraTest.php does not comply with psr-0 autoloading standard. It will not autoload anymore in Composer v2.0. in phar:///usr/local/bin/composer/src/Composer/Autoload/ClassMapGenerator.php:185
ocramius/package-versions: Generating version class...

@aidantwoods
I fixed this issue.
Could you review and publish it ?

+1

+1

+1

Add this to composer.json autoload section
"exclude-from-classmap": [
        "/vendor/erusev/parsedown-extra/test"
]


Security issues with bibtex-ruby and nokogiri

I have a jupyterbook repository hosted on Github. I received two security alerts from GitHub that suggest to upgrade bibtex-ruby and nokogiri.
I'm a noob with ruby bundles, I tried
bundle update bibtex-ruby nokogiri

but then of course I get dependency issues
Bundler could not find compatible versions for gem "bibtex-ruby":
  In Gemfile:
    bibtex-ruby (>= 5.1.0)

    jekyll-scholar was resolved to 5.16.0, which depends on
      bibtex-ruby (~> 4.0, >= 4.0.13)

How do I solve the security issues?

Hmmm - that's a tough one, so it's not letting you update them because of dependency conflicts? Have you tried totally deleting the Gemfile.lock file and re-installing?
We are also working on re-configuring the backend of Jupyter Book so that it no longer relies on Jekyll...hopefully that will make these installation and security issues go away

For my github repo, there was a patch for nokogiri automatically created as a branch -- which I was then able to merge to my master branch and pull back to my local repo.  When I later went to run make serve, it prompted me to update the gemfile and dependencies  using bundle install. That was it for  the nokogiri vulnerability at least.
I haven't resolved the bibtex-ruby one yet.

Yes, now I got the pull request for nokogiri too, and then I replicated it for bibtex-ruby (i.e. I changed the Gemfile.lock. I don't know if that is good practice though.

@matteoacrossi as far as I know the problematic bibtex-ruby version is a dependency of an older version of jekyll-scholar. The newer version of jekyll-scholar (which would fix this security issue) depends on a newer version of jekyll, but the (current) github-pages gem depends on the older jekyll version.
Did your fix actually work? I was under the impression that there is nothing we could do about it (that a new version of the github-pages gem would have to be released first).

I don't know if it worked in the sense of actually updating the gem, but the vulnerability issue has gone.

Closing as this should be superceded by beta.jupyterbook.org


cocomac: Watch unitedshutters.co.uk

cocomac requests the watch of the watch_keyword unitedshutters\.co\.uk. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

unitedshutters\.co\.uk has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Rejected by tripleee in Charcoal HQ. Reason: 'sorry, didn't notice the PR -- duplicate'


Seems not working for Apple Silicon processor

WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested rosetta error: Unimplemented syscall number 284  %

@Greyb0w1er, thanks for pointing that out. I have added the missing architecture images to address this issue. If you encounter any further problems, please let me know!
https://hub.docker.com/layers/ksg97031/frida-gadget/latest/images/sha256-6d82c4789c2f05f978ed745d5e07b180425dfd0967b7fdb2a7642ea665f8a405?context=repo


Add missing build arg in gitlab ci

The failed pipeline is still caused by auth update, integration testing is skipped in https://github.com/RedHatProductSecurity/openlcs/pull/224


walkDir does not work

Describe the bug 🐛
A clear and concise description of what the bug is.
The walkDir iterator outputs nothing regardless of the contents of the directory.
To Reproduce 👨🔬
Steps to reproduce the behavior:

Create SPA
Use this code:

import happyx, os

appRoutes("app"):
  "/":
    tDiv:
      for i in walkDir("."): # does not work on all paths
        {i} # only an empty div is created regardless of how many files/directories exist

Run hpx dev

Output HTML:

    <meta charset="utf8">
    <title>app</title>

Expected behavior 🤔
A clear and concise description of what you expected to happen.
The expected output should be like the following code:
import os
for i in walkDir("."):
  echo i # outputs current directory's contents

Using this code on https://play.nim-lang.org, outputs the following:
(kind: pcDir, path: "./nimble")
(kind: pcDir, path: "./nim")

Please complete the following information 📃

OS: [e.g. Win10] Arch Linux
OS Version [e.g. 22] Rolling
HappyX version [e.g. 2.4.1] (to see it you can use hpx -v) HappyX 3.8.0
HappyX project type [ssr/spa] SPA
Nim version [e.g. 2.0.0] 2.0.2
Browser [e.g. chrome] (For SPA projects) Firefox
Browser Version [e.g. 22] 121.0.1 (64-bit)

Additional context ✌
Add any other context about the problem here.
This may affect other iterators like walkDirs and walkDirRec. I did not check that though.

The expected output should be like the following code:
import os
for i in walkDir("."):
  echo i # outputs current directory's contents

Well, that code doesn't work when placed outside the route either, in global scope. It only works if you put it in a static: block, in which case it is run as nimscript during the compilation process. The issue with most of the path procs from std/os is that they are not supported in browser js scripts, since the browser sandboxes code and hides access to the directory structure on the front end.
Since a SPA project is on the front-end, you either want to show the directory structure in which the project exists, which can only be gotten at compiletime, or you want your SPA script to be able to search around independently on a visitor's directory structure, which is a huge security no-no that browser sandboxing is meant to avoid. Or, you don't want to use a SPA at all and instead want to use an SSR to dynamically explore your own file structure.

Oh right, everything is being loaded client side so the file directory isn't available. Thank you for your explanation! I will probably switch to SSR or SSG then.


Delete .DS_Store

accidentally pushed

https://github.com/GoogleCloudPlatform/anthos-config-management-samples/blob/main/fleet-tenancy/terraform/.DS_Store also needs to be deleted.


Outside border with rectangle causes issue for editing inside

Hi,
I have tried to explain the issue below.
To create a page template like the one shown below, I need a rectangular outside of the page. When I do that, anything in the rectangle becomes "not touchable" because I always choose rectangle if I click there. The only workaround is hiding that. Any solution for this problem? Anybody else using the page template like this?

Uncheck pointer events under Properties in the Style panel.


get_in() raises TypeError when index is a string but structure is a list

from funcy import get_in

get_in({}, "key")  # example 1
get_in([], "key")  # example 2

In the code sample above, example 1 returns the default value because the path doesn't exist. However, example 2 fails with:
.../site-packages/funcy/colls.py in get_in(coll, path, default)
    271     for key in path:
    272         try:
--> 273             coll = coll[key]
    274         except (KeyError, IndexError):
    275             return default

TypeError: list indices must be integers or slices, not str

This is understandable but to handle this case, a special error handling needs to be added around the function and it kind of defeats the purpose of a simple one-liner. It is also not documented.
I would be happy to do a PR if you agree get_in() should handle this exception automatically by also returning the default value.

The thing is this is intended behavior. Python is strict on types, i.e. example 2 is indeed an error.
I understand there might be use cases for second example to return none silently. What is your?

Btw, you can use silent(get_in)([], ...) though.
And sorry for slow response

The use case is quite common. If get_in is used to drill into deeply nested JSON structures, it can easily happen that somewhere along the path, the object is not a dictionary but a list. And in that case, one would expect to get the default value, since the path doesn't exist. But instead a TypeError is raised.
It seems inconsistent, because if a key is missing, KeyError nor IndexError are raised. And they are also caused by a wrong key. Just not the wrong type but a wrong value.

Missing key and unexpected structure type are different cases. If you are looking for a string key in a list then you get a TypeError, any other errors also pop up, so it's perfectly consistent now.
If silent() is a problem then you can use ignore(TypeError).

From the documentation:

Returns a value corresponding to path in nested collection.

It doesn't say anything about type checking or type requirements. So I assumed that the behaviour is the same as for other similar technologies, such as XPath, JSONPath or CSS selectors. E.g. unresolvable path results in default value, not an error.

If silent() is a problem then you can use ignore(TypeError).

If I'm not mistaken, ignore is a decorator and cannot by used in-line just as silent(get_in)([], ...) was suggested previously. Could you please show how to use it inline? If it cannot be used inline, then it kind of defeats the purpose of the library because again, I would disable more errors than needed.

Behavior is close to Pythons not anything else. I understand that expectations might vary, but ignoring a TypeError like this while might be desirable for some uses will conceal bugs on other ones. So I am going strict here as Python does. funcy is not designed to be quick and dirty do my thing lib, but quick do my thing lib. I still follow DWIM when it's unambiguous.

If I'm not mistaken, ignore is a decorator and cannot by us ...

Both silent() and ignore() are decorators, both might be used inline. In fact silent(func) is exactly the same as ignore(Exception)(func). So you may use it like:
val = ignore(TypeError)(get_in)(data, path, default=some_value)

# Or make an alias for it to be reused
dirty_get_in = ignore(TypeError)(get_in)  # choose any name you see fit
val1 = dirty_get_in(data, path1, default=some_value)
val2 = dirty_get_in(data, path2)

Thank you for the example. Unfortunately, it works only partially. It doesn't given back the default value, because it just ignores the error (the code never gets to the return of the default).
ignore(TypeError)(get_in)([], ["x"], default="default")
then produces None rather then "default"
If ignoring the error is not acceptable, the easiest solution for me is to take the function out of the library and reimplement it myself. It has only 8 lines and no dependency on the rest of the library code.
Just in case anyone else bumps into this problem, this was my solution:
def get_in(coll, path, default=None):
    """Returns a value at path in the given nested collection."""
    for key in path:
        try:
            coll = coll[key]
        except (KeyError, IndexError, TypeError):
            return default
    return coll

Another example to prove my point: The bolton.itertools.get_path() from a different library also interprets "string key to a list" as "missing path" and raises either the same exception as for any other missing path or returns the default value.

Reopening this to fix it via documenting and providing alternative ways.

Added a get_lax() to do the same thing but ignore index TypeErrors


Projected NFT funnel

Projected NFT Funnel
Setup

Add extensions.yml to folder where the game binary is located:

extensions:
  - name: "Cardano Projected NFT"
    type: cardano-projected-nft
    contract: "703ec99926211daafe291951b778d4da7736a8b0da2aeb92305b511a72"
    startSlot: 43201686
    scheduledPrefix: cpnft

Add vars to .env:

CARP_URL=http://localhost:3000
CARDANO_NETWORK=preprod
CARDANO_CONFIRMATION_DEPTH=10

We also need to update the Paima docs with information about this CDE as well

We also need to update the Paima docs with information about this CDE as well

will add, are the docs blocking this PR to be merged?


update to 7.7.4

@feniix
is it possible that this PR will be merged and a new container is being build at some point?

@daruziek or @lhemala you can fix the conflicts and I will merge and publish a new image


DOC: Adding best Deal section on homepage

What's wrong with the existing documentation
there is nothing to show in best deal section

File to change
to add best deal section
Details of the change
No response
Type of change
No response
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@arghadipmanna101 please assign this issue to me under gssoc

@arghadipmanna101 please assign this issue to me under gssoc

please assign this issue to me @arghadipmanna101

okay i will make PR @arghadipmanna101


Enabling external shuffle service in spark operator

@liyinan926
Can you please confirm if external shuffle service support is available in spark operator.
Thanks
Shenson

No, Spark on Kubernetes doesn't support dynamic resource allocation and external shuffle services yet.


Suggestion: include items/s and belts required in CSV

Added item rate to CSV in 9c1643db4f910b4c968cb0f91318ff0bb7da6d38.


Unable to set connection pool to read-only

Environment
HikariCP version: 3.2.0
JDK version     : 1.8.0_161
Database        : MySQL
Driver version  : 8.0.11

⚠ Using the latest and greatest

*Have you searched the CLOSED issues already? How about checking [stackoverflow]
Yes
I've got 2 datasources - 1 is for write and the other for read. I've tried to set the property in my Spring Boot application.properties file, but the configuration shown in the catalina.out log shows that the readOnly setting is false.
I have a configuration class that uses the properties in the application.properties files to configure the pool, but can't seem to get it to change the readOnly property from false to true.
I also tried to put a setReadOnly(true); statement within the dataSource() method - didn't work.
@Configuration
@EnableTransactionManagement
@EnableConfigurationProperties
@ConfigurationProperties(prefix = "reader.datasource")
@EnableJpaRepositories(
        entityManagerFactoryRef = "entityManagerFactory",
        basePackages = {"com.abc.data.reader.repo"})
public class ReaderDataSourceConfig extends HikariConfig {

    @Bean(name = "readerDataSource")
    public DataSource dataSource() {
        return new HikariDataSource(this);
    }

    @Bean(name = "entityManagerFactory")
    public LocalContainerEntityManagerFactoryBean entityManagerFactory(
            EntityManagerFactoryBuilder builder, @Qualifier("readerDataSource") DataSource dataSource) {
        return builder.dataSource(dataSource).packages("com.abc.repo")
                .persistenceUnit("reader")
                .build();
    }

    @Bean(name = "transactionManager")
    public PlatformTransactionManager transactionManager(@Qualifier("entityManagerFactory") EntityManagerFactory entityManagerFactory) {
        return new JpaTransactionManager(entityManagerFactory);
    }
}

And the lines from the properties file:
#HikariCP Reader config
reader.datasource.jdbc-url=jdbc:mysql://...
reader.datasource.username=###
reader.datasource.password=#####
reader.datasource.driver-class-name=com.mysql.cj.jdbc.Driver
reader.datasource.maximum-pool-size=10
reader.datasource.connection-timeout=60000
reader.datasource.max-lifetime=1800000
reader.datasource.minimum-idle=10
reader.datasource.validation-timeout=15000
reader.datasource.read-only=true         ***tried multiple variations***
reader.datasource.hikari.read-only=true
reader.datasource.readOnly=true
reader.dataSource.cachePrepStmts=true
reader.dataSource.prepStmtCacheSize=250
reader.dataSource.prepStmtCacheSqlLimit=2048
reader.dataSource.useServerPrepStmts=true
reader.dataSource.useLocalSessionState=true
reader.dataSource.rewriteBatchedStatements=true
reader.dataSource.cacheResultSetMetadata=true
reader.dataSource.cacheServerConfiguration=true
reader.dataSource.elideSetAutoCommits=true
reader.dataSource.maintainTimeStats=false
reader.datasource.pool-name=ReaderPool

Is it not possible to set it through a property file?

For me the readOnly property works when I pass it using my properties file. How does the created HikariConfig look like if you load the properties file? May it be that you misspelled "datasource". As shown in the example configuration it should spell "dataSource".

So I found that I did have lowercase and snake case mixed in. I converted it all to snake case and made sure that the config classes were looking for that as well. I tried both reader.dataSource.read-only and reader.dataSource.readOnly. The log file shows:
DEBUG com.zaxxer.hikari.HikariConfig - readOnly........................false
So no change at all.

readOnly is a first order property, and should not be qualified with dataSource..


⚠ Avatar API Endpoint has degraded performance

In 1b4f425, Avatar API Endpoint (https://avatar.roblox.com/v1/avatar-rules) experienced degraded performance:

HTTP code: 200
Response time: 4405 ms

Resolved: Avatar API Endpoint performance has improved in bd318be after 12 minutes.


Fix a few graph issues.

Show day of week in the graph tooltip.
Don't hide overflow from the graph panel, as it covers long tooltips.
Add units to graph axes.
Improve graph data set names shown in the dialog.
The log based taxi graphs are now all based on trips/hour.  This allows direct comparison of monthly and daily graphs.
Convert log scales to human values for axes and tooltips.
Adjust instagram overlay size.  Add one line of text in general.  Hide the scrollbar unless needed.  If there is no image, allow even more text.

Addresses issues #123 (increase message overlay size), #119 (log2 scaling), and #120 (show human values not log values).


ambient: initial status writing

This PR builds out initial support for writing to status. This is a new condition on Service/ServiceEntry to indicate the waypoint binding status.
Decisions to make:

Do we use Patch or Update (prefer patch)
Do we use pkg/status/manager.go - probably nice but needs to support patch if we do for ^
API decision around naming of condition types and reasons

The current PR is just a POC, don't worry about the quality which is low.
End result:
apiVersion: networking.istio.io/v1
kind: ServiceEntry
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"networking.istio.io/v1beta1","kind":"ServiceEntry","metadata":{"annotations":{},"name":"test-se","namespace":"default"},"spec":{"hosts":["dummy.example.com"],"ports":[{"name":"tcp","number":9090,"protocol":"TCP"}],"resolution":"DNS"}}
  creationTimestamp: "2024-07-08T16:24:18Z"
  generation: 2
  name: test-se
  namespace: default
  resourceVersion: "64229"
  uid: 92cd1a63-b46d-4cac-92c7-0129217a6770
spec:
  hosts:
  - dummy.example.com
  ports:
  - name: tcp
    number: 9090
    protocol: TCP
  resolution: DNS
status:
  conditions:
  - lastTransitionTime: "2024-07-08T16:24:56.946472175Z"
    message: Successfull attached to waypoint default/waypoint
    reason: WaypointAccepted
    status: "True"
    type: istio.io/WaypointBound
  observedGeneration: "2"
  validationMessages:
  - documentationUrl: https://istio.io/v1.23/docs/reference/config/analysis/ist0133/
    level: WARNING
    type:
      code: IST0133
  - documentationUrl: https://istio.io/v1.23/docs/reference/config/analysis/ist0134/
    level: WARNING
    type:
      code: IST0134

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

might be related to https://github.com/istio/istio/issues/52000 indirectly?

PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

So on the leader election, its harder than I thought..
Requirements:

When we start leading, we MUST process all existing items (and then any updates of course)
When we stop leading, we MUST not write status any longer
When we stop leading, we SHOULD do as little work as possible

The problem is we need to:

Start a leader election in pilot/pkg/bootstrap
Somehow pass some context over to kubecontroller.NewMulticluster to pass it down into the ambient controller
Somehow use that...

Ideally, we could do something like
OnLeaderStart: register all handlers (which triggers events for all existing state)
OnLeaderStop: de-register handlers

There are  problems with this, though.

There is no de-register in krt, at least right now. It could be added, its just a nontrivial amount of work.
How do we do the callbacks? There is no ordering between ambient controller starting and the leader election code triggering; either could happen first. We could have some new LeaderWatcher thing where I can subscribe to it, and it handles the out of order, but its a lot of machinery for something so simple.

For now, I have just put this behind a feature flag, off by default. The leader election is only strictly required when multiple versions are running concurrently anyways, so its not THAT bad right now. We should fix before 1.24 though

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
0b30778d3cc9a1858a570b5d916568f79c33d295
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
0b30778d3cc9a1858a570b5d916568f79c33d295
link
true
/test gencheck

lint_istio
0b30778d3cc9a1858a570b5d916568f79c33d295
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
0b30778d3cc9a1858a570b5d916568f79c33d295
link
true
/test gencheck

lint_istio
0b30778d3cc9a1858a570b5d916568f79c33d295
link
true
/test lint

unit-tests-arm64_istio
0b30778d3cc9a1858a570b5d916568f79c33d295
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
0b30778d3cc9a1858a570b5d916568f79c33d295
link
true
/test gencheck

lint_istio
0b30778d3cc9a1858a570b5d916568f79c33d295
link
true
/test lint

unit-tests-arm64_istio
0b30778d3cc9a1858a570b5d916568f79c33d295
link
true
/test unit-tests-arm64

unit-tests_istio
0b30778d3cc9a1858a570b5d916568f79c33d295
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

yeah I have a commit that I built that before I realized the "reconcile everything when we win the election" issue

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
0b30778d3cc9a1858a570b5d916568f79c33d295
link
true
/test unit-tests-arm64

unit-tests_istio
0b30778d3cc9a1858a570b5d916568f79c33d295
link
true
/test unit-tests

lint_istio
6bda38d153e92497c71f027b3f5d80dbe5f57bc1
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

The leader election is only strictly required when multiple versions are running concurrently anyways

Is this true? It seems like if istiod scaled out you'd still potentially have a problem with each one trying to write status. Ideally I guess they'd all be trying to write the same state, or we have other problems to fix, so maybe it's ok.

Is this true? It seems like if istiod scaled out you'd still potentially have a problem with each one trying to write status. Ideally I guess they'd all be trying to write the same state, or we have other problems to fix, so maybe it's ok.

Exactly. Not great, but not entirely broken

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
6126482b4d249d91b4766f20ba16fd4c0c0dd742
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
6126482b4d249d91b4766f20ba16fd4c0c0dd742
link
true
/test gencheck

lint_istio
6126482b4d249d91b4766f20ba16fd4c0c0dd742
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
76c3496fe5531d05f7c89a46bb53fa9960b7edfa
link
unknown
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

/retest


Fix for complex projections that include navigations

Fix #3633
cc @maumar @anpete

@natemcmaster @maumar Not sure what happened to @maumar's original fix, but I prefer the approach in the origin PR. I.e. Enhance the QuerySourceTrackingExpressionVisitor to return null for this case.

The PR @maumar had introduced a bug into other query tests. I'm going to rework this a little as there is a low-hanging, slight perf improvement available.

Updated using @maumar 's original approach but with an additional condition check

:shipit:


Change place size messaging and implementation to use square km

Using square degrees means the restriction varies based on latitude, and it means we can't reasonably communicate the way the restriction works to users because no one knows what a square degree is. This changes most uses of the restriction to use square kilometers.

Unless there's a good way to calculate area in km2 in RGeo, I think this probably just makes things more confusing by creating two separate ways we measure area, one for new uploads and another for places already in the database.

I don't really see a way forward here. We need one way to calculate area, preferably before the places gets added to the database, and I don't think we have one.


don't count comment lines as lines of source code

If I'm not mistaken comment lines are being counted
more over, empty lines shouldn't be taken into account either

+1 for separating:
Lines Of Code
Lines of Comments

I would also appreciate a few separate counts. (SLOC with comments, SLOC without comments, SLOC without comments or empty lines).
I tend to write a ton of documentation, and I'm wary of hitting my coworkers with a 1500 line PR that's really 800 lines of unit/integration tests, 350 lines of comments, and 350 lines of logic.

Bump

+1


Generate XML SBOM

Changing the hardcoded --jsonFile flag to --xmlFile in sbom.sh should command TemurinGenSBOM.java to generate an XML file instead of a json. And then I just changed any json variable name to xml to clear any confusion

This pr depends on the discussion in https://github.com/adoptium/temurin-build/issues/4061#issuecomment-2516605041

The errors in the workflow checks suggest we are missing a dependency when using the XML generator
BUILD SUCCESSFUL
Total time: 2 seconds
OpenJDK SBOM will be /home/jenkins/workspace/target/OpenJDK-sbom.json.
Exception in thread "main" java.lang.NoClassDefFoundError: org/codehaus/stax2/ri/Stax2WriterAdapter
	at com.fasterxml.jackson.dataformat.xml.ser.ToXmlGenerator.<init>(ToXmlGenerator.java:276)
	at com.fasterxml.jackson.dataformat.xml.XmlFactory.createGenerator(XmlFactory.java:527)
	at com.fasterxml.jackson.dataformat.xml.XmlFactory.createGenerator(XmlFactory.java:30)

This is fixed by this PR: https://github.com/adoptium/temurin-build/pull/4077

Thanks for trying this @Haroon-Khel
as you say this work is dependent on discussion https://github.com/adoptium/temurin-build/issues/4061#issuecomment-2516605041
also fix: https://github.com/CycloneDX/cyclonedx-core-java/issues/562


Table not visible

I have installed the library and copy/paste the example from docs but the table is not visible. Only the pagination part is visible.

@TechSaq please wrap a table component in outer View and give that view a height and width.


Test: Cert checks followup

Follow up on https://github.com/canonical/lxd-ci/pull/116 (https://github.com/canonical/lxd-ci/pull/125).

@tomponline I haved missed passing the variable for the short form function. Fixed now.


Hide sensitive information from getting displayed/logged.

Changelog: (Fix | Bugfix): Fixes the issue with sensitive details are exposed in build log files
fixes #535

[x] Refer to the issue that supports this Pull Request.
[ ] If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
[x] I've read the Contributing guide.
[x] I've followed the PEP8 style guides for Python code.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

It looks great. Is it possible add a test to check this new output?

Depends on https://github.com/conan-io/conan/pull/8132

Depends on https://github.com/conan-io/conan-package-tools/pull/538

Codecov Report

Merging #536 (3110972) into develop (b6d6816) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #536      +/-   ##
===========================================
+ Coverage    79.13%   79.21%   +0.08%
===========================================
  Files           41       41
  Lines         4917     4932      +15
===========================================
+ Hits          3891     3907      +16
+ Misses        1026     1025       -1

Impacted Files
Coverage Δ

cpt/runner.py
91.52% <100.00%> (+0.18%)
:arrow_up:

cpt/test/integration/docker_test.py
88.88% <100.00%> (+1.13%)
:arrow_up:

cpt/test/integration/base.py
97.56% <0.00%> (+2.43%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6d6816...3110972. Read the comment docs.


chore: minor typos in the docs

Description
Fixes minor typos in the docs
Hope it helps,
Br,
Tudor.
Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[x] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

N/A
Risk

None, docs only
Testing

None
Engineering

Operations

Screenshots (if applicable)

hello, gotcha, i ll use that for future prs 🤝


Disable Simplyfying Polygons

Is it possible to disable the Simplyfying-Algorithm for special layers or sources?
Here is a screenshot with disabled the simplyfying.

And here with active simplyfying.

The version with disabled simplyfying is the correct layout.

Try a custom build with a different value for ol.SIMPLIFY_TOLERANCE

No I don't think it can be disabled on a layer / source basis, it's a general setting currently.

Is there a possibility to make the simplify_tolerance configurable?

@SimonA84 can you provide a link to an example that reproduces the issue you are seeing?

At the moment it's not possible to provide a link.
The problem didn't appear with OL3.10.1 but with newer versions.

I dont't know what has changed, but the problem didn't occour in my last test.
@tschaub One of the customers of the company changed to the new product version. So can I provide a link http://<IP_ADDRESS>:8081/HHOHL/


[BUG] Print to PDF - ERR_NAME_NOT_RESOLVED

Describe the bug

Product Flavor

[ ] Managed (https://rxresu.me)
[X] Self Hosted

To Reproduce

Host on docker behind traefik
Click on print to pdf
Get status 500 error.
Checking logs:

[Nest] 44  - 05/10/2022, 4:28:24 PM   ERROR [ExceptionsHandler] page.goto: net::ERR_NAME_NOT_RESOLVED at https://resume.com//username/resume/printer?secretKey=secret

=========================== logs ===========================
navigating to "https://resume.com//username/resume/printer?secretKey=secret", waiting until "load"
============================================================
    at PrinterService.printAsPdf (/app/server/dist/printer/printer.service.js:39:20)

Expected behavior
It should print to pdf but there seems to be something wrong with the routing I don't know about.
Desktop (please complete the following information):

OS: Linux
Browser All
Version 3.4.4

Additional context
Everything else seems to work fine, don't see any other errors being thrown in the server.
There is a similar issue opened about print to pdf not working but they are getting a different error.
Docker compose
version: '3'
services:
  resume-server:
    image: amruthpillai/reactive-resume:server-latest
    container_name: resume-server
    environment:
      - TZ=UTC
      - PUBLIC_URL=https://resume.com/
      - PUBLIC_SERVER_URL=https://resume.com/api
      - SECRET_KEY=<secret>
      - POSTGRES_HOST=<db>
      - POSTGRES_PORT=5432
      - POSTGRES_USER=resume
      - POSTGRES_PASSWORD=<pass>
      - POSTGRES_DB=resume
      - JWT_SECRET=<secret>
      - JWT_EXPIRY_TIME=604800
      - GOOGLE_API_KEY=<api>
    networks:
      - lab
    restart: unless-stopped
    labels:
      - traefik.enable=true
      - traefik.http.routers.resume-server.entrypoints=https
      - traefik.http.routers.resume-server.rule=Host(`resume.com`) && PathPrefix(`/api`)
      - traefik.http.routers.resume-server.service=resume-server
      - traefik.http.services.resume-server.loadbalancer.server.port=3100
      - traefik.http.routers.resume-server.tls.certresolver=letsEncrypt
      - traefik.http.routers.resume-server.middlewares=resume-stripprefix
      - traefik.http.middlewares.resume-stripprefix.stripprefix.prefixes=/api
  resume-client:
    image: amruthpillai/reactive-resume:client-latest
    container_name: resume-client
    environment:
      - TZ=UTC
      - PUBLIC_URL=https://resume.com/
      - PUBLIC_SERVER_URL=https://resume.com/api
      - PUBLIC_FLAG_DISABLE_SIGNUPS=false
    depends_on:
      - resume-server
    restart: unless-stopped
    networks:
      - lab
    labels:
      - traefik.enable=true
      - traefik.http.routers.resume-client.entrypoints=https
      - traefik.http.routers.resume-client.rule=Host(`resume.com`)
      - traefik.http.routers.resume-client.service=resume-client
      - traefik.http.services.resume-client.loadbalancer.server.port=3000
      - traefik.http.routers.resume-client.tls.certresolver=letsEncrypt
volumes:
  pgdata:

networks:
  lab:
    external: true

As say in other issues it looks like you have a duplicated / in your URL "https://resume.com//username/resume/printer?secretKey=secret"
Change occurrences of
      - PUBLIC_URL=https://resume.com/

to
      - PUBLIC_URL=https://resume.com

(i.e. remove the trailing /)