omero: Add detailed version requirements

Conversion of https://docs.google.com/spreadsheets/d/1TRJUhdMZ_pnHxg1TUk9Lf_oQcx2paZtwWMjTybQ7qZo/edit#gid=0 to sphinx markup
This isn't intended to mirror the installation prerequisites; it's primarily of interest to ourselves and sysadmins who need to know what's supported for the deployment timeframe of an OMERO installation.  From that point of view it's a much more detailed overview of each prerequisite, which could be cross-referenced from the install docs.  This is a detailed list of all of the released versions of our prerequisites, and their release and support timeframes.  It also details which versions are provided by each version of each distribution/operating system.  The intent is that this gives a detailed overview of what's supportable, and what's obsolete/unsupportable, and the varying degrees between these states, to enable us to clearly plan what we will support for the 5.1 (and later) releases.  The support states are certainly something which needs wider discussion; this is just the initial conversion of the spreadsheet to give us a starting point for doing that (I just filled in vaguely sensible values to mostly match the current status quo).
This might not be in the most appropriate place in the manual, it can certainly be moved to e.g. the developer part if that's better.  While it's not intended to mirror the installation instructions, it's clearly got some similarities, so if there's a way to better integrate the information here with what's already in the manuals, I'd be happy with that.
I've checked the HTML and PDF tables, but they could do with double-checking to ensure they are legible and (most importantly!) factually correct.

Staged at http://www.openmicroscopy.org/site/support/omero5.1-staging/sysadmins/version-requirements.html.

I have pushed fixes for all the minor comments.
We could really do with sitting down and going through the data to properly specify what our support policies will be for 5.1 for all the marked sections.  What would be the best way to do this?  Meeting/chat sometime this week?

I've not yet got around to much helping with https://trello.com/c/E3APkGze/258-versions-of-prerequisites and this stuff does need to be figured out before we release 5.1.0, though I am way behind you in knowing the details, I also have some graphs reimplementation cleanup, and I am in imminent danger of being sucked into rendering settings work. However, I am happy to meet, especially if I can be useful, this week or next. Who should be in the meeting? Is this about putting together a clear, succinct case for proposed prerequisites, to be shared via nitpick or whatever, ready for another meeting at which they may or may not be approved?

Does @joshmoore need to be involved in this discussion? Might be best to schedule a time once he's back on Friday.

Also, can we please avoid individual Trello links in the public documentation? It's not very good practice to point externals at something they don't have permission to view.

@hflynn Yes.  It's not intended to be merged with the link in, just a point for something which needs looking at to ensure the information is accurate.  It does need discussion prior to being suitable for merging.

:+1:  just wanted to clarify

the build system is also complaining about the https://fedoraproject.org/wiki/Releases#Current_Supported_Releases anchor link - I know it works but given the content is nearly at the top of the page anyway, could you just remove the anchor so I don't have to add it to the ignore list to get the build green?

Document updated to include https://docs.google.com/document/d/1z6S6fVK6Ls7WhJ0kLOyPApegKiG-F-21kCjVyk4ivnc/edit# as Jason suggested.
I've tidied it a bit more (renamed Link to Reference,or Ref where space is limited).  Are there any outstanding changes to the wording or layout etc.?

Sorry, didn't get on to this today, will read it over properly and comment tomorrow

@joshmoore The latest commit should address most of your comments.  Is the 5.0/5.1/5.2 support in the tables and the updated summary at the start OK structure-wise?  The actual support statuses may still need tweaking; I've added deprecated statuses where we would drop support in the following release.

Few extra nitpicks about wording but otherwise I think we are good

Changes all look fine to me, thanks! I'll merge once builds are green and it should be live after lunch.

Ok, all green, merging.

--no-rebase

I can't help but wonder if we ought to be saying something about supported web browser versions too. @aleksandra-tarkowska, @will-moore, have we a card or anything about that?

@mtbc We've generally been quite conservative about deprecating browser support. We may not have perfect appearance on IE8, but we do support it and everything else since.

@will-moore Having a concrete list of what is supported in 5.0, what we plan to support in 5.1 and in 5.2 does give a roadmap for where we are right now and where we will be in the future.  It wouldn't be much work to add such a list to this version requirements file.  That's irrespective of whether we're being conservative or not.
But note the supported operating systems section on this page; the minimum web browser versions should match what's supported here.  e.g. Since our minimum Windows version is 7, the minimum IE versions does not need to include versions in XP/Vista.  Likewise for Safari on MacOS <8. etc.


duplicity: add setuptools_scm dependency

Motivation for this change
duplicity fails to build
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@ofborg eval

Result of nixpkgs-review pr 118334 at 1526abb2 run on x86_64-linux 1

3 packages built successfully:

deja-dup
duplicity
duply

3 suggestions:

warning: unused-argument
Unused argument: backblaze-b2.
Near pkgs/tools/backup/duplicity/default.nix:12:3:
   |
12 | , backblaze-b2
   |   ^

warning: unused-argument
Unused argument: fetchpatch.
Near pkgs/tools/backup/duplicity/default.nix:2:3:
  |
2 | , fetchpatch
  |   ^

warning: missing-patch-comment
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/tools/backup/duplicity/default.nix:37:5:
   |
37 |     ./linux-disable-timezone-test.patch
   |     ^


Search box does not wait for new results after new input

Steps to reproduce:

Type in "PCSK" in the gnomAD search box.
Wait for search results to appear. The first result should be "PCSK1".
Type "9" and press enter.

Expected behavior:
Search results for "PCSK9" are fetched and the first result is selected. The browser navigates to the gene page for PCSK9.
Actual behavior:
The first result of the current list is selected. The browser navigates to the gene page for PCSK1.

This is a classic race condition that benefits from using an Observable. Something like switchMap would solve your problem. Suppose keydown$ is the stream of keydown events then something like this would work
import {switchMap, map} from 'rxjs/operators'
const searchResult$ = keydown$.pipe(
  map(() => inputDOMElement.value),
  switchMap(searchTerm => getGraphQLResult(searchTerm),
);

where getGraphQLResult sends out an AJAX request for the search result for a given searchTerm.

This one wasn't so much because of a race condition... the search box would ignore the result of any in progress requests when it made a new one. However, if it already had a list of results loaded, then pressing enter while a request was in progress would select from the existing list instead of waiting for the request to finish. The solution was to clear the list of results when the input changed.


What constitutes a Security Advisories?

I think it would be a good idea to draw up a document that can help people decide what a Security Advisory is.

Closing as there some discussions in the FIG group about that topic and some PSRs are on their way.


Update README.md

Is Ecto.DateTime the new way to represent datetime?
Using datetime gives me:
* (ArgumentError) invalid or unknown type :datetime for field :sent_at. Maybe you meant to use Ecto.DateTime as the type?

Thank you! :heart:
Yes, Ecto.DateTime should be used exclusively now.

:tada: :+1:


Error with variable of type object, type object literal required.

https://github.com/Azure/bicep/blob/022f601c96eb77bbcd6abbb4dbd270e56349583b/src/Bicep.Core.IntegrationTests/Scenarios/FallbackTopLevelResourcePropertiesTests.cs#L264

This error message is not helping me to understand what the issue is here. I am not sure how I can turn an "object", into an "object literal".
I suspect that this is working as intended, but the error message could explain what is intended better. I am unsure if what I am trying to do here is illegal, or if I am just doing it incorrectly?

Object literal means that object needs to be declared in place. Module params cannot be passed as variable or parameter, you need to make object there.

I think we can use this issue to track an improvement to the error message.


Go Checker Compile Test Files

Hey! This is my first attempt at contributing to a vim plugin, so let me know if there is anything that looks funky. Closes: https://github.com/benekastah/neomake/issues/282. Uses the Syntastic implementation as a reference.
Also makes an assumption that you've opened vim from the root of your project. Not sure else how to get around that issue.

This needs to be debased.
Can you provide some snippets to test this, I.e. an example project?

@derekdowling
Ping.

Closing due to lack of response, feel free to re-open / comment, of course.


Added optional restart field to AppUpdate API

This PR fix #2363 but it will need some work from the UI, to pass the same restart: false flag during the push.
After a lot of thoughts the problem was related to an unwanted call to the DeployApp, after an UpdateApp.
The problem is that if the DeployApp will fail, then the Update will fail as well, and no updated sources are going to be uploaded to try to fix the issue.
To fix this keeping the old behavior for backward compatibility and also to keep the same restart during the epinio app update command a new optional restart flag can be provided, to force the not-restart (by default it's true).
Changes to the models.Manifest struct was needed, because it was using internally the same models.ApplicationUpdateRequest as a Configuration. While containing the same fields (until now) these two struct are conceptually different, and they could/should be different.  A new similar ApplicationConfiguration struct was added, to avoid having the Restart flag in the Manifest.

Speaking with @torchiaf this looks to be ok! Mergin' it. :rocket:

Retested in epinio-server v1.10.0-rc1

Check on CLI same as here and working.

Unzip this faulty-dir: faulty-dir.zip
Create app with faulty dir:

epinio push -n testapp-faulty -p ~/faulty-dir

Push the correct folder but with -i 1:

epinio push -n testapp-faulty -p assets/sample-app -i 1

No error is shown and app is correctly pushed:

➜  epinio git:(main) ✗ epinio push -n testapp-faulty -p assets/sample-app -i 1

🚢  About to push an application with the given setup
Manifest: <<Defaults>>
Name: testapp-faulty
Source Origin: /home/mmartin/suse/epinio-repos/epinio/assets/sample-app
AppChart:
Target Namespace: workspace
Instances: 1
Routes: <<default>>

Output:
Deploying application ...
.....
🕞  Creating application resources
✔  App is online.
Name: testapp-faulty
Namespace: workspace
Builder Image:
Routes:
1: https://testapp-faulty.<IP_ADDRESS>.omg.howdoi.website
➜  epinio git:(main) ✗  epinio info

✔  Epinio Environment
Platform: k3s
Kubernetes Version: v1.25.4+k3s1
Epinio Server Version: v1.10.0-rc1
Epinio Client Version: v1.10.0-rc1

Rechecked as well in UI that app can be redeployed from faulty apps


Fix JDBCIO Perf Tests

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Add a link to the appropriate issue in your description, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run Java JdbcIO Performance Test

Run Java JdbcIO Performance Test

Run Java JdbcIO Performance Test

Run Java JdbcIO Performance Test


How to change tabs programatically?

Is there a way to switch between the tabs programatically? Triggering click or tap events on a tab is not working. Thanks.

Hello Joel,
I found the tabs will occupy 2 rows when tab count more than 5, now I have 12 tabs (tablet) and still want make them all in one row, how can I achive that by using your tab plugin?
Thanks a lot!
Best regards, xeoshow


How to get G-force, Harsh Braking and Acceleration when i have x,y z data?

Hello, I have got raw data x, y z but I don't know how to calculate G-force, Harsh Braking, and Acceleration. i am developing an app where I need to gather data of Harsh Braking, and Acceleration, So can you please help me to find a way to calculate.
Thanks
constructor(props) {
    super(props);
    setUpdateIntervalForType(SensorTypes.accelerometer, 200);
    this.accelSubscription = accelerometer.subscribe(({x, y, z, timestamp}) => {
      this.setState({
        accel_x: x,
        accel_y: y,
        accel_z: z,
        time: timestamp,
      });

    });
    this.state = {
      acceleration: 0,
      accel_x: 0,
      accel_y: 0,
      accel_z: 0,
      time: 0,
      speed: 0,
    };
  }

I don't think this is directly an issue with this library is it? Maybe asking this question on stack overflow in a more general way is helpful. The X Y Z data is straight what the iOS / Android sensor returns so searching for answers in the iOS / Android realm would probably yield the best results.
Hope you find a good solution, closing this issue for now, feel free to repoen if it turns out to be a library issue. Also, if you find a solution feel free to contribute to the docs so that others can find a good solution right away and don't have to go through the same struggle as you


fix(ci): make cla checks case insensitive

great, glad you caught this.
The commit message needs a minor amend to:
ci: make cla checks case insensitive

ci: is a type and can be used as a scope:
https://github.com/ockam-network/ockam/blob/develop/tools/commitlint/commitlint.config.js


Servlet springAwareVaadinServlet is currently unavailable

Hello,
On shutdown of Tomcat, I'm getting errors such as below, with the error forwarding continuing on until the log is full. Any ideas on what may be causing this? Or how I may be able to handle it? The 'millions of instances' for deallocation is a mystery. I am happy to provide any helpful information.
Thanks.
Application setup:
Vaadin 7.3.5
Servlet 3.0
spring-boot 1.0.2.RELEASE
spring-boot-vaadin 0.0.2-SNAPSHOT
Tomcat 7.0.50
Java 7
@Push(transport = Transport.LONG_POLLING) is enabled
Included in application.properties:
vaadin.servlet.asyncSupported=true
vaadin.servlet.params.productionMode=false
vaadin.servlet.params.heartbeatInterval=300
vaadin.servlet.params.closeIdleSessions=true
vaadin.servlet.params.legacyPropertyToString=false
server.sessionTimeout=25
Stack trace:
2014-12-09 03:21:54.568  INFO 19115 --- [ost-startStop-2] o.a.c.c.C.[Catalina].[localhost].[/SD4]  : Closing Spring root WebApplicationContext
Dec 09, 2014 3:21:54 AM org.apache.catalina.loader.WebappClassLoader clearReferencesJdbc
SEVERE: The web application [/SD4] registered the JDBC driver [oracle.jdbc.OracleDriver] but failed to unregister it when the web application was stopped. To prevent a memory leak, the JDBC Driver has been forcibly unregistered.
Dec 09, 2014 3:21:54 AM org.apache.catalina.loader.WebappClassLoader clearReferencesJdbc
SEVERE: The web application [/SD4] registered the JDBC driver [org.netezza.Driver] but failed to unregister it when the web application was stopped. To prevent a memory leak, the JDBC Driver has been forcibly unregistered.
Dec 09, 2014 3:21:54 AM org.apache.catalina.loader.WebappClassLoader clearReferencesThreads
SEVERE: The web application [/SD4] appears to have started a thread named [pool-10-thread-1] but has failed to stop it. This is very likely to create a memory leak.
Dec 09, 2014 3:21:54 AM org.apache.catalina.loader.WebappClassLoader checkThreadLocalMapForLeaks
SEVERE: The web application [/SD4] created a ThreadLocal with key of type [com.google.gson.Gson$1] (value [com.google.gson.Gson$1@62dcfc44]) and a value of type [java.util.HashMap] (value [{}]) but failed to remove it when the web application was stopped. Threads are going to be renewed over time to try and avoid a probable memory leak.
Dec 09, 2014 3:21:54 AM org.apache.catalina.loader.WebappClassLoader checkThreadLocalMapForLeaks
SEVERE: The web application [/SD4] created a ThreadLocal with key of type [com.google.gson.Gson$1] (value [com.google.gson.Gson$1@62dcfc44]) and a value of type [java.util.HashMap] (value [{}]) but failed to remove it when the web application was stopped. Threads are going to be renewed over time to try and avoid a probable memory leak.
Dec 09, 2014 3:21:54 AM org.apache.catalina.loader.WebappClassLoader checkThreadLocalMapForLeaks
SEVERE: The web application [/SD4] created a ThreadLocal with key of type [com.vaadin.util.CurrentInstance$1] (value [com.vaadin.util.CurrentInstance$1@1a360711]) and a value of type [java.util.HashMap] (value [{class com.vaadin.server.VaadinService=com.vaadin.util.CurrentInstance@5109fa88, class com.vaadin.ui.UI=com.vaadin.util.CurrentInstance@661f2048, class com.vaadin.server.VaadinSession=com.vaadin.util.CurrentInstance@5808b59}]) but failed to remove it when the web application was stopped. Threads are going to be renewed over time to try and avoid a probable memory leak.
Dec 09, 2014 3:21:54 AM org.apache.catalina.loader.WebappClassLoader checkThreadLocalMapForLeaks
SEVERE: The web application [/SD4] created a ThreadLocal with key of type [org.springframework.core.NamedThreadLocal] (value [Request attributes]) and a value of type [org.springframework.web.context.request.ServletRequestAttributes] (value [org.apache.catalina.connector.Request@3a3c82e1]) but failed to remove it when the web application was stopped. Threads are going to be renewed over time to try and avoid a probable memory leak.
Dec 09, 2014 3:21:54 AM org.apache.catalina.loader.WebappClassLoader checkThreadLocalMapForLeaks
SEVERE: The web application [/SD4] created a ThreadLocal with key of type [org.springframework.core.NamedThreadLocal] (value [Locale context]) and a value of type [org.springframework.context.i18n.SimpleLocaleContext] (value [en_US]) but failed to remove it when the web application was stopped. Threads are going to be renewed over time to try and avoid a probable memory leak.
Dec 09, 2014 3:21:54 AM org.apache.catalina.core.StandardWrapper unload
INFO: Waiting for 7189547 instance(s) to be deallocated for Servlet [springAwareVaadinServlet]
2014-12-09 03:21:54.999  WARN 19115 --- [io-8009-exec-48] a.c.c.C.[.[.[.[springAwareVaadinServlet] : Servlet springAwareVaadinServlet is currently unavailable
2014-12-09 03:21:55.008  WARN 19115 --- [bio-8009-exec-1] a.c.c.C.[.[.[.[springAwareVaadinServlet] : Servlet springAwareVaadinServlet is currently unavailable
2014-12-09 03:21:55.008  WARN 19115 --- [bio-8009-exec-4] a.c.c.C.[.[.[.[springAwareVaadinServlet] : Servlet springAwareVaadinServlet is currently unavailable
2014-12-09 03:21:55.029  WARN 19115 --- [io-8009-exec-19] a.c.c.C.[.[.[.[springAwareVaadinServlet] : Servlet springAwareVaadinServlet is currently unavailable
2014-12-09 03:21:55.033 ERROR 19115 --- [io-8009-exec-48] a.c.c.C.[.[.[.[springAwareVaadinServlet] : Servlet.service() for servlet springAwareVaadinServlet threw exception
java.lang.IllegalStateException: Cannot forward after response has been committed
at org.apache.catalina.core.ApplicationDispatcher.doForward(ApplicationDispatcher.java:349)
at org.apache.catalina.core.ApplicationDispatcher.forward(ApplicationDispatcher.java:339)
at org.springframework.boot.context.web.ErrorPageFilter.handleException(ErrorPageFilter.java:135)
at org.springframework.boot.context.web.ErrorPageFilter.doFilter(ErrorPageFilter.java:104)
at org.springframework.boot.context.web.ErrorPageFilter.doFilter(ErrorPageFilter.java:85)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:243)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
at org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:749)
at org.apache.catalina.core.ApplicationDispatcher.processRequest(ApplicationDispatcher.java:487)
at org.apache.catalina.core.ApplicationDispatcher.doForward(ApplicationDispatcher.java:412)
at org.apache.catalina.core.ApplicationDispatcher.forward(ApplicationDispatcher.java:339)
at org.springframework.boot.context.web.ErrorPageFilter.handleException(ErrorPageFilter.java:135)
at org.springframework.boot.context.web.ErrorPageFilter.doFilter(ErrorPageFilter.java:104)
at org.springframework.boot.context.web.ErrorPageFilter.doFilter(ErrorPageFilter.java:85)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:243)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
at org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:749)
at org.apache.catalina.core.ApplicationDispatcher.processRequest(ApplicationDispatcher.java:487)
at org.apache.catalina.core.ApplicationDispatcher.doForward(ApplicationDispatcher.java:412)
at org.apache.catalina.core.ApplicationDispatcher.forward(ApplicationDispatcher.java:339)
at org.springframework.boot.context.web.ErrorPageFilter.handleErrorStatus(ErrorPageFilter.java:119)
at org.springframework.boot.context.web.ErrorPageFilter.doFilter(ErrorPageFilter.java:100)
at org.springframework.boot.context.web.ErrorPageFilter.doFilter(ErrorPageFilter.java:85)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:243)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
at org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:749)

This bug is related to issues with Vaadin push implementation and Tomcat. With Jetty I hadn't any issues. Check this topic at official Vaadin forum about Tomcat issues: https://vaadin.com/forum#!/thread/8232643

Thanks for the response. I am upgrading our Vaadin version, to see if it helps with the intermittent push "hang" issue. Tomcat 7 appears to be is causing some pains with the latest spring boot jpa as well.

Closing since this no longer applies to Vaadin4Spring.


Add limit parameter to search command (fix issue #2402)

This have a problem with a limit greater that 100 (this limit is in the crates.io API). Here I can do 3 things, allow only limits values between 1 to 100, allow any value and let it crash when value is greater than 100, or query as pages as needed for satisfy the limit.
Any suggestion?

This looks good to me, I'm fine letting the maximum limit get defined by crates.io so we don't hardcode it in two places.

Looks like a test may need to get updated as well?

The crates.io maximum is about API results pagination, I think isn't directly related with the maximum on cargo search command, but I think 100 results is enough for the command line interface. I will allow only values 1..100.

Looks like the tests may still be failing?

Now tests are fixed, I think the problem is a temporary problem obtaining a package.

@bors: r+ 53c9374c9f6a72e3c9db0d3c524233f2a04d58a6
Thanks!

:hourglass: Testing commit 53c9374 with merge 075e824...

:sunny: Test successful - cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64


[BUG] Missing dependency in custom theme

Describe the bug

Create new theme:
npx @shopware-pwa/cli@canary create-theme
extend from @shopware-pwa/default-theme
run yarn dev
NodeJS 15.14.0
shopware-pwa canary (8.2)

hey @super-kamil , there are problems with Node v15 now, I'm grouping these issues in #1463 and we plan to resolve that soon.
Could you check this on node v14 and let us know if you still have problems there?

Hi @patzick, thanks but it does not work.
nvm use 14.16.0
npx @shopware-pwa/cli@canary create-theme
yarn dev -> same error

rm -rf node_modules/ yarn.lock my-theme/node_modules/
yarn
cd my-theme && yarn
yarn dev -> same error

thanks @mkucmus. now it works 🎉 this step should be added to the documentation.

thanks @mkucmus. now it works  this step should be added to the documentation.

It will be added definitely! thanks for feedback 💪🏻


[Feature Request] handle preprocess prior to schema validation.

our code has a very loose parse
const parseBasic = (data: any) => {
  const schema = z
    .object({
      name: z.string(),
      letter: z.preprocess(v => (v as string)?.toUpperCase(), z.enum(['A', 'B'])),
    })
    .describe('Basic');

  try {
    return schema.parse(data);
  } catch (error: any) {
    console.warn(schema._def.description + 'SchemaError', {
      ...error.issues,
    });

    return data;
  }
};

parseBasic({ name: 'Jay', letter: 'a' });
// { name: 'Jay', letter: 'A' }

We love that it adds types to our json, and if the json schema is wrong it simply logs a warning.
But there is a few cases were we would like to preprocess the data prior to parsing incase the parsing fails, we would still like to have the preprocess.
Unfortunately there is no way to currently accomplish this.
const parseBasic = (data: any) => {
  const schema = z
    .object({
      name: z.string(),
      letter: z.preprocess(v => (v as string)?.toUpperCase(), z.enum(['A', 'B'])),
      fieldThatDefDoesNotExisit: z.string(),
    })
    .describe('Basic');

  try {
    data = schema.preProcess(data);  // this does not currently exist
    return schema.parse(data);
  } catch (error: any) {
    console.warn(schema._def.description + 'SchemaError', {
      ...error.issues,
    });

    return data;
  }
};

parseBasic({ name: 'Jay', letter: 'a' });
// *logs warning*
// { name: 'Jay', letter: 'a' } <= ideally still would be  {name: 'Jay', letter: 'A' }'

Is this what you are looking for?
const preSchema = z.object( {
    letter: z.string().toUpperCase(),
} )

const schema = preSchema.passthrough().pipe(
    z.object( {
        name: z.string(),
        letter: z.enum( [ 'A', 'B' ] ),
    } )
)

console.log( preSchema.parse( { name: 'Jay', letter: 'a' } ) ) // { letter: 'A' }
console.log( schema.parse( { name: 'Jay', letter: 'a' } ) ) // { name: 'Jay', letter: 'A' }

If you found my answer satisfactory, please consider supporting me. Even a small amount is greatly appreciated. Thanks friend! 🙏
https://github.com/sponsors/JacobWeisenburger

Hi @JacobWeisenburger thanks for the quick reply,
Alas no, I was just using fieldThatDefDoesNotExisit to trigger a schema error,
The idea is that even though the Schema DOES have a failure we would still like to preprocess.
Here is a cleaner example.
onst schema = z.object({
  stringKey: z.preprocess(v => (typeof v === 'string' ? v.toUpperCase() : v), z.enum(['A', 'B'])),
  numberKey: z.preprocess(v => (typeof v === 'number' ? Math.floor(v) : null), z.number()),
});

const data1 = { stringKey: 'a', numberKey: 10.2 };
const data2 = { stringKey: 'notA', numberKey: 10.2 };
const data3 = { stringKey: 'a', numberKey: 'string' };

// currently
schema.parse(data1); // success { stringKey: 'A', numberKey: 10 }
schema.parse(data2); // fail { stringKey: 'notA', numberKey: 10.2 }
schema.parse(data3); // fail { stringKey: 'a', numberKey: 'string' }

// idealy we still want to prePreccess
schema.preProcess(data1); // { stringKey: 'A', numberKey: 10 }
schema.preProcess(data2); // { stringKey: 'NOTA', numberKey: 10 }
schema.preProcess(data3); // { stringKey: 'A', numberKey: null }

In reality the json error won't be this egregious, we use the parse function mostly to just know that the schema and data are a bit off to fix at a later date.
We still end up using the data, and it would help us narrow down what is a possible if we know that preprocessing DEFINITLY took place.
I don't think this is currently not possible looking at the documentation.

Is this what you are looking for?
const data1 = { stringKey: 'a', numberKey: 10.2 }
const data2 = { stringKey: 'notA', numberKey: 10.2 }
const data3 = { stringKey: 'a', numberKey: 'string' }

const preSchema = z.object( {
    stringKey: z.string().toUpperCase(),
    numberKey: z.union( [
        z.number().transform( v => Math.floor( v ) ),
        z.any().transform( () => null ),
    ] ),
} )

console.log( preSchema.parse( data1 ) ) // { stringKey: 'A', numberKey: 10 }
console.log( preSchema.parse( data2 ) ) // { stringKey: 'NOTA', numberKey: 10 }
console.log( preSchema.parse( data3 ) ) // { stringKey: 'A', numberKey: null }

const schema = preSchema.passthrough().pipe(
    z.object( {
        stringKey: z.enum( [ 'A', 'B' ] ),
        numberKey: z.number(),
    } )
)

console.log( schema.parse( data1 ) ) // { stringKey: 'A', numberKey: 10 }
console.log( schema.safeParse( data2 ).success ) // false
console.log( schema.safeParse( data3 ).success ) // false

If you found my answer satisfactory, please consider supporting me. Even a small amount is greatly appreciated. Thanks friend! 🙏
https://github.com/sponsors/JacobWeisenburger

It would solve my example but not what I am asking,
The idea is, "Even if the Schema fails there is a way to preprocess"

I really don't understand what you are asking for then, because I feel I have solved the problems you have presented. Please explain a little more what I'm not solving.

I want the schema to be strict and throw when the data is unexpected, I can catch this and log,
I would like to have a preprocessor in place that formats the data without needing to strictly parse.
I was hoping to use the same library, and make use of the "preprocess" that is built into the schema.

I was hoping to use the same library, and make use of the "preprocess" that is built into the schema.

To the best of my knowledge this is the part that can't be solved currently. I can label this issue as a new feature request, but realistically, I highly doubt it will ever be added. But who knows, I could be wrong.

It's true that the "ask" here is not well-defined.
It's not clear when Zod should continue execution vs. deeming the input "un-preprocessable". What should be returned if you pass in an array instead of an object into .preProcess? What if there's no letter key in the object? What if your preprocess function throws an error (as it would if the letter value wasn't a string). What if the ZodPreprocess is the endpoint of a ZodPipeline? There are a lot of edge cases in any possible implementation of .preProcess and I don't see a clean way to determine/explain what a .preProcess() method would actually do. Zod is currently all-or-nothing because that's the only way for it's behavior to be consistent and predictable.
You should think about what you really are trying to achieve here. There are ways to make Zod's parsing more customizable or forgiving, including those suggested by Jacob.  You should define a schema that carves out exceptions for things like extraneous fields, etc, then use standard .parse.


Add blog post showing how to deploy to Heroku

Not sure if it was supposed to be so simple haha :joy:
Maybe I need do add more details or create a specific section for this?

Coverage remained the same at 88.034% when pulling 825ffe159bcdb3bf587c81ba9d2b6b955fed9318 on guilatrova:master into e6845e0cf1d77aefb35f7eeafb04d73d1b2f5432 on coryhouse:master.

Coverage remained the same at 88.034% when pulling 825ffe159bcdb3bf587c81ba9d2b6b955fed9318 on guilatrova:master into e6845e0cf1d77aefb35f7eeafb04d73d1b2f5432 on coryhouse:master.

I think this works we can adjust format as we have other methods of deployment.
What do you think @nickytonline and @coryhouse?

Thanks! 👍


[Feat] Add mathajax and latex equation feature to blog

This allows us to add latex equations to blog and render them using mathjax.
Following the process from here and here

merged!


feat(stages): recover senders for both DB and static file transactions

With this PR, when recovering senders in the SenderRecovery pipeline stage, we will look into both database table Transactions and static files for Transactions segment. It becomes relevant when https://github.com/paradigmxyz/reth/pull/5733 is merged.
One thing to note with the current implementation is that we no longer retrieve RawKey and RawValue from the database when querying transactions for sender recovery, but instead decode them before passing the transactions to threads for recovery. The bench showed there's no significant difference in performance between the two approaches.
Holesky benchmark (main vs this PR):
ubuntu@reth4:~/reth-snaps-alexey$ hyperfine './reth_main stage --chain holesky run --datadir ~/.local/share/reth/holesky --from 0 --to 808004 senders'
Benchmark 1: ./reth_main stage --chain holesky run --datadir ~/.local/share/reth/holesky --from 0 --to 808004 senders
  Time (mean ± σ):     48.451 s ±  0.335 s    [User: 1696.042 s, System: 6.879 s]
  Range (min … max):   47.847 s … 48.946 s    10 runs

ubuntu@reth4:~/reth-snaps-alexey$ hyperfine './reth_6089_raw stage --chain holesky run --datadir ~/.local/share/reth/holesky --from 0 --to 808004 senders'
Benchmark 1: ./reth_6089_raw stage --chain holesky run --datadir ~/.local/share/reth/holesky --from 0 --to 808004 senders
  Time (mean ± σ):     52.559 s ±  0.146 s    [User: 1762.202 s, System: 8.185 s]
  Range (min … max):   52.248 s … 52.708 s    10 runs

In addition to that, we need to keep in mind that now transactions, headers, and receipts can be in static files, so when calculating the stage checkpoint, we need to look in both database and static files. I introduced a trait StatsReader for that, and replaced all calls to tx.entries::<T>() with it.

Okay, it performs worse... I need to return the raw inserts functionality
ubuntu@reth4:~/reth-snaps-alexey$ hyperfine './reth_main stage --chain holesky run --datadir ~/.local/share/reth/holesky --from 0 --to 808004 senders'
Benchmark 1: ./reth_main stage --chain holesky run --datadir ~/.local/share/reth/holesky --from 0 --to 808004 senders
  Time (mean ± σ):     48.451 s ±  0.335 s    [User: 1696.042 s, System: 6.879 s]
  Range (min … max):   47.847 s … 48.946 s    10 runs

ubuntu@reth4:~/reth-snaps-alexey$ hyperfine './reth_6089 stage --chain holesky run --datadir ~/.local/share/reth/holesky --from 0 --to 808004 senders'
Benchmark 1: ./reth_6089 stage --chain holesky run --datadir ~/.local/share/reth/holesky --from 0 --to 808004 senders
  Time (mean ± σ):     64.176 s ±  0.451 s    [User: 1700.714 s, System: 15.671 s]
  Range (min … max):   63.374 s … 64.920 s    10 runs

Raw query looks good
ubuntu@reth4:~/reth-snaps-alexey$ hyperfine './reth_main stage --chain holesky run --datadir ~/.local/share/reth/holesky --from 0 --to 808004 senders'
Benchmark 1: ./reth_main stage --chain holesky run --datadir ~/.local/share/reth/holesky --from 0 --to 808004 senders
  Time (mean ± σ):     48.451 s ±  0.335 s    [User: 1696.042 s, System: 6.879 s]
  Range (min … max):   47.847 s … 48.946 s    10 runs

ubuntu@reth4:~/reth-snaps-alexey$ hyperfine './reth_6089_raw stage --chain holesky run --datadir ~/.local/share/reth/holesky --from 0 --to 808004 senders'
Benchmark 1: ./reth_6089_raw stage --chain holesky run --datadir ~/.local/share/reth/holesky --from 0 --to 808004 senders
  Time (mean ± σ):     52.559 s ±  0.146 s    [User: 1762.202 s, System: 8.185 s]
  Range (min … max):   52.248 s … 52.708 s    10 runs

Anyway, will remove the querying for snapshots at all for now, because we don't write to them yet.

ETA bug is unrelated to these changes, the progress is calculated correctly


chore(starknet_integration_tests): use available ports for state sync

Stack:

#2796
#2795
#2794
#2789 ⬅
#2788
#2787
#2786
#2781
#2780

⚠ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

This change is

✓ Commit merged in pull request #2796


Unable to compile CouchDB with dunfell branch

I got an error while trying to compile couchdb: "No package 'erl_ei' found"
I'm using dunfell branch and erlang version <IP_ADDRESS>.

Right, that happens for 20.x, 21.x and 22.x because the patches for pkg-config (from this layer) were not available (yet) for these erlang versions. Also the couchdb 3.1.2 does not support erlang 23.x or 24.x.
So, two options here: bump couchdb to 3.2.x or backport the pkg-config patch to the missing erlang versions.
Does updating couchdb work for you ?

The patch has already work before. I was using CouchDB 3.1.1 with erlang version <IP_ADDRESS> (commit 286eb34 from March 2021)
If you can add 3.2.x to dunfell, I will try if it works.

Hello @dmrayt
I've added again the 3.1.1 and 3.1.2 now using apache archives that is suppose to not disappear. Please, try it using the Erlang <IP_ADDRESS> or <IP_ADDRESS>.
Unfortunately the Erlang version <IP_ADDRESS> is not building yet.
The couchdb 3.2.x require some dependencies that Yocto/OE dunfell branch does not have. So, it's better to stick with 3.1.x on dunfell.

I was able to build couchdb 3.1.2 and erlang <IP_ADDRESS> with the current commit in dunfell branch.
Thanks.


feat(cli): generate changelog from JSON context

Description
This implements generating a changelog from a pre-generated JSON context, which allows for more extensibility.
Motivation and Context

closes #657

How Has This Been Tested?
As of now, only manual tests have been performed. I'm not sure what the best strategy for unit-testing this would be.
Types of Changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation (no code change)
[ ] Refactor (refactoring production code)
[ ] Other

Checklist:

[x] My code follows the code style of this project.
[ ] I have updated the documentation accordingly.
[x] I have formatted the code with rustfmt.
[ ] I checked the lints with clippy.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 19.44444% with 29 lines in your changes missing coverage. Please review.

Project coverage is 36.97%. Comparing base (4b0c0eb) to head (db48024).
Report is 1 commits behind head on main.

Files
Patch %
Lines

git-cliff/src/lib.rs
0.00%
27 Missing :warning:

git-cliff-core/src/changelog.rs
77.78%
2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #784      +/-   ##
==========================================
- Coverage   36.97%   36.97%   -0.00%
==========================================
  Files          20       20
  Lines        1531     1553      +22
==========================================
+ Hits          566      574       +8
- Misses        965      979      +14

Flag
Coverage Δ

unit-tests
36.97% <19.45%> (-<0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

This would be more useful if we added an optional free-form dictionary (e.g., additional_data) to both Release and Commit. In the current state, we may only change the existing context fields.

Damn, this is nice! Thanks for going ahead and implementing it 🔥

This would be more useful if we added an optional free-form dictionary (e.g., additional_data) to both Release and Commit. In the current state, we may only change the existing context fields.

I definitely agree, would love to have that. We can use serde_json::Value for that I reckon.

Great! Is extra an acceptable name? The originally proposed additional_data is also an OK option, but a bit long IMO.

We should update the documentation about this. We can create a new page under /docs/usage. (I'm okay with adding it if you are not interested :))

If you could just push a file with some kind of an outline here, I'll be glad to fill it in.

Can you add a fixture test to verify this behavior?

Absolutely, once we've settled on the extra attribute name.

Yes, I think extra (or extra_data or custom_data) is a good name!

@orhun I added the extra attribute and a fixture test. However, it seems like there is a bug - the commit.extra field gets lost somewhere on its way into the template. I found that it is still present in changelog.rs#542 (I did a dbg!(&release) there), but it is not present inside the Template.render method. How can that happen?

Ah, there is a custom Serialize implementation for Commit where you should add the new field :)
https://github.com/orhun/git-cliff/blob/a71649b6cd5a72c2a6b20c08dc1b8dfa37c19a6b/git-cliff-core/src/commit.rs#L397

@orhun I added a simple docs page and everything except Docker automated builds passed - those are still running.

Oops, is_terminal() check seems to have broken the fixture tests, I will look into it later.
ref: 135938f698470974860c43f1b25414ebc46a9d73

Thanks for the review and for the improvements, I can't wait to use it!


Rename map.json to map.js

Hi! I opened this pull request because in webpack projects module parse failed and need an appropriate loader to handle json file type.

Hi, this is merged and published to npm v2.2.0. Thanks.

Thank you so much!


WFLY-4499 Fix Compiler Warnings in Transactions Subsystem

The transactions subsystem contains several compiler warnings. Some of
them (mostly related to generics) are quite easy to fix.
Issue: WFLY-4499
https://issues.jboss.org/browse/WFLY-4499

Linux with security manager Build 1181 is now running using a merge of dd34b8b1cfbc0c322e424d114457d947b1204ee5

Windows Build 1317 is now running using a merge of dd34b8b1cfbc0c322e424d114457d947b1204ee5

Linux Build 6205 is now running using a merge of dd34b8b1cfbc0c322e424d114457d947b1204ee5

Linux with security manager Build 1181 outcome was SUCCESS using a merge of dd34b8b1cfbc0c322e424d114457d947b1204ee5
Summary: Tests passed: 822, ignored: 356 Build time: 0:06:52

Windows Build 1317 outcome was SUCCESS using a merge of dd34b8b1cfbc0c322e424d114457d947b1204ee5
Summary: Tests passed: 2842, ignored: 416 Build time: 0:52:58

Linux Build 6205 outcome was SUCCESS using a merge of dd34b8b1cfbc0c322e424d114457d947b1204ee5
Summary: Tests passed: 2842, ignored: 416 Build time: 0:56:24

patch looks good to me


README

README
As a boot camp student,
I want the prework notes to be structured on a webpage,
So that I can easily find and read the information.
GIVEN the prework project repository,
WHEN I view the README for the repository,
THEN I can see a professional README that provides information on the project and how to use it

issue has been fixed i have added and created my notes on why what how and when for this project


Admin: Vector layer ordering issue

Vector layers used for AOI, and Image Preview are not rendering in the proper order.

Refactored admin app previewLayer functionality

Tweaked the layers array so that the vector layers are always on top.
Removed hardcoded URL for basemap
Switched IP address for basemap to
geoserver-demo01.dev.ossim.org/geoserver
Moved client zoom level indicator down a bit in the UI so that it is
not covered up on smaller browser resolutions


Immense Keyboard Input Delay

When using either the exe or the code, both give keyboard input delay in and out of valorant. I'm not sure why, but the game is nearly unplayable at some points because of this. Is there a reason for this?

It definitely originated from the "keyboard" library. I will review this library and come back.

İssue #6
I looked for "keyboard" library problems and no one reported a problem, I suspect my own code, but no problem, no delay when using the code.
Note: You can edit the source code for this project to work more efficiently. The code works extremely well for me.
OS: Windows 10
Python version: 3.8.9
Keyboard lib version: 0.13.5


Proxy served on all (sub)domains

Here's my caddyfile (I have to use port 443 for other reasons, but this happens on any port):
pi:443 {
    tls off
}
proxy.website.com:443 {
    forwardproxy {
        basicauth username password
        serve_pac config.pac
    }
    tls off
}

pi is my server's hostname in my LAN. A proxy is hosted at proxy.website.com, which is what should be happening. The problem is, it's also hosted on port 443 on any other domain. This Caddyfile is just one example. No matter what I try, I can't only host the proxy on one domain, no matter the port or domain.
Another example:
website.com:80 {
    root websiteroot
    ext html htm
}
proxy.website.com:80 {
    forwardproxy {
        basicauth username password
    }
}

Here, a webpage won't get served at website.com:80.
Instead, a proxy will. this makes it impossible to have a proxy served only on a subdomain, on the same port.

Perhaps we could introduce a -sni-first flag (as in #12), except by this issue the flag would also disable forwardproxy's "fallback" behavior. In other words, without the -sni-first flag, the forwardproxy plugin tells Caddy to "fall back" to the site of the forwardproxy when the Host header doesn't match any site definitions. This is how it already works. But if we use -sni-first then we would have to disable that, since we would match on SNI to find the site definition that applies to that request, then consume the Host header with forwardproxy.
It's a bit of a hack, and very, very niche use, and we'd have to consider on the implications for probe resistance. Feedback and critique welcome.

I don't think the -sni-first should disable the forwardproxy's "fallback" behavior.
When proxy traffic comes with HTTPS, caddy knows it is for the proxy site(which configured with forwardproxy).

Now we should be able to do this.
@forward_proxy {
	var {http.request.tls.server_name} example.com
	not host example.com
}
route @forward_proxy {
	forward_proxy
}


Chromecast not showing up on Arch

OS:
Arch Linux
Issue Descriptions:
I have both a chromcast 2 and chromecast audio on my network and i'm not finding an option for chromecast on gdmp. I can cast fine using GP in a browser.
Steps to Reproduce:
Start GDMP and there is no chromecast selector to be found.

Known issue that is fixed in master:
https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/issues/1335#issuecomment-234106545

@jostrander This appears to actually be a missing dependency (linked issue is RE only one chromecast appearing)
@brentluna Can you please ensure that your firewall allows communication on port 5353 and you have avahi installed and running


Remove all associated proxy instances if service app resource is absent

This change is

Reviewed 22 of 22 files at r1.
Review status: all files reviewed at latest revision, 4 unresolved discussions.

Modules/SharePointDsc/DSCResources/MSFT_SPAccessServiceApp/MSFT_SPAccessServiceApp.psm1, line 126 at r1 (raw file):

            }

            # Remove the connected proxy(ies)

We probably don't need the comments here, it's pretty self explanatory so I would rather take them out. Same for all instances of this one

Modules/SharePointDsc/DSCResources/MSFT_SPExcelServiceApp/MSFT_SPExcelServiceApp.psm1, line 141 at r1 (raw file):

            }

            Remove-SPServiceApplication $app -Confirm:$false

Can I get you to fix the lack of use of positional parameters on these seeing as we're touching the same code. Should read:
Remove-SPServiceApplication -Identity $app -Confirm:$false

Tests/Unit/SharePointDsc/SharePointDsc.SPAccessServiceApp.Tests.ps1, line 34 at r1 (raw file):

        Mock Set-SPAccessServicesApplication { }
        Mock Remove-SPServiceApplication { }
        Mock Get-SPServiceApplicationProxy { return $null }

Why are we returning null here? We would expect it to return null when it doesn't exist and return a value when it does, so this should vary by test context. Same for all of the tests where you have done this.

Tests/Unit/SharePointDsc/SharePointDsc.SPWordAutomationServiceApp.Tests.ps1, line 300 at r1 (raw file):

                })
            }
            Mock Remove-SPServiceApplication { return $null }

Why did you add a return value here?

Comments from Reviewable

@NikCharlebois Happy with the changes (reviewable is having a moment so I can't close that off) - just need you to do a pull from dev to resolve merge conflicts and we are good to go.

@BrianFarnhill merges and changes have been done

Done. Merged and committed back the files
From: Brian Farnhill<EMAIL_ADDRESS>Sent: Tuesday, October 11, 2016 6:31 PM
To: PowerShell/SharePointDsc<EMAIL_ADDRESS>Cc: Nik Charlebois<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [PowerShell/SharePointDsc] Remove all associated proxy instances if service app resource is absent (#414)
@NikCharleboishttps://github.com/NikCharlebois Happy with the changes (reviewable is having a moment so I can't close that off) - just need you to do a pull from dev to resolve merge conflicts and we are good to go.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/PowerShell/SharePointDsc/pull/414#issuecomment-253066584, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ACbdzVzDfsjIID2udo0GnnmMlQG4Ooq7ks5qzA4xgaJpZM4KOwZe.

Review status: 0 of 23 files reviewed at latest revision, 4 unresolved discussions.

Modules/SharePointDsc/DSCResources/MSFT_SPAccessServiceApp/MSFT_SPAccessServiceApp.psm1, line 126 at r1 (raw file):
Previously, BrianFarnhill (Brian Farnhill) wrote…
> We probably don't need the comments here, it's pretty self explanatory so I would rather take them out. Same for all instances of this one

Comments taken out.

Modules/SharePointDsc/DSCResources/MSFT_SPExcelServiceApp/MSFT_SPExcelServiceApp.psm1, line 141 at r1 (raw file):
Previously, BrianFarnhill (Brian Farnhill) wrote…
> Can I get you to fix the lack of use of positional parameters on these seeing as we're touching the same code. Should read:
>
>     Remove-SPServiceApplication -Identity $app -Confirm:$false

Params added

Tests/Unit/SharePointDsc/SharePointDsc.SPAccessServiceApp.Tests.ps1, line 34 at r1 (raw file):
Previously, BrianFarnhill (Brian Farnhill) wrote…
> Why are we returning null here? We would expect it to return null when it doesn't exist and return a value when it does, so this should vary by test context. Same for all of the tests where you have done this.

Null no longer returned.

Tests/Unit/SharePointDsc/SharePointDsc.SPWordAutomationServiceApp.Tests.ps1, line 300 at r1 (raw file):
Previously, BrianFarnhill (Brian Farnhill) wrote…
> Why did you add a return value here?

Null value removed

Comments from Reviewable

Reviewed 6 of 22 files at r2, 13 of 13 files at r3.
Review status: 19 of 23 files reviewed at latest revision, 1 unresolved discussion.

Tests/Unit/SharePointDsc/SharePointDsc.SPAccessServiceApp.Tests.ps1, line 34 at r1 (raw file):
Previously, NikCharlebois (Nik Charlebois) wrote…
> Null no longer returned.

Why is it here at all though? It should be mocked differently in each context

Comments from Reviewable

You need to do a pull from dev and resolve the conflict in changelog.md before appveyor can run.

Review status: 17 of 21 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

Comments from Reviewable

Reviewed 22 of 24 files at r4.
Review status: 21 of 22 files reviewed at latest revision, 1 unresolved discussion.

tl4b52d1.a1v.txt, line 1 at r4 (raw file):

Merge remote-tracking branch 'refs/remotes/PowerShell/dev' into Issue-360-Fix

Whats this file dude? Can you remove it please

Comments from Reviewable

Review status: all files reviewed at latest revision, 1 unresolved discussion.

tl4b52d1.a1v.txt, line 1 at r4 (raw file):
Previously, BrianFarnhill (Brian Farnhill) wrote…
> Whats this file dude? Can you remove it please

Dang, not sure why this ile got put in...I totally missed it. My pull/merges are still problematic...sorry, yet again about this

Comments from Reviewable

Review status: all files reviewed at latest revision, 1 unresolved discussion.

Tests/Unit/SharePointDsc/SharePointDsc.SPAccessServiceApp.Tests.ps1, line 34 at r1 (raw file):
Previously, BrianFarnhill (Brian Farnhill) wrote…
> Why is it here at all though? It should be mocked differently in each context

It has been remove entirely

Comments from Reviewable

Reviewed 1 of 1 files at r5.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable


Fix user agent SDK name & version generation

Currently generating UNKNOWN_NAME & UNKNOWN_VERSION
https://github.com/Azure/azure-sdk-for-java/blob/master/sdk/anomalydetector/azure-ai-anomalydetector/src/main/java/com/azure/ai/anomalydetector/AnomalyDetectorClientBuilder.java#L196
https://github.com/Azure/azure-sdk-for-java/blob/master/sdk/synapse/azure-analytics-synapse-spark/src/main/java/com/azure/analytics/synapse/spark/SparkClientBuilder.java#L260

This is not an issue. If the artifact name is defined, the artifact-name.properties file will be generated and the user agent string will read from it. The links in the issue description are libraries that were generated without this autorest option defined, so, they default to "Unknown".


Test for OpenShift 4.x+ compatibility

There had been previous approaches to use OpenShift with Dataverse.
Since OS4 is based on Kubernetes 1.16, we should be able to use our tools with it.
OS is a very popular K8s distribution, so it would spread the usability and adaption further. It has many neat features like built-in Jenkins, registry etc. It might be useful for local dev, too.

Sounds great. Just to chime in, Adam Bien talks about OpenShift all the time on his airhacks podcast. It does seem to be popular and supporting it better might help adoption (strategic goal number 1 for Dataverse). Plus, it would make our contacts at Red Hat happy. I forget if I told you that we're talking (off and on) about getting Dataverse in OpenShift catalog some day. It would be great advertising. 😄 Please remind me to tell you more about this.

We have an OpenShift cluster in DataverseEU project and going to try Kubernetes installation there. I'm not expecting too much differences, usually it's only Storage specification should be changed to get it there.


[Bug]  linker cc not found at nightly image

It looks like the cc linker is missing at the current nightly docker image.
For example this ci fail https://github.com/LuckyTurtleDev/more-wallpapers/actions/runs/3534612074/jobs/5931687750.
It does not have a custom linker defended.
INFO  [cargo_doc2readme::input] Running rustc -Zunpretty=expanded
   Compiling proc-macro2 v1.0.47
   Compiling unicode-ident v1.0.1
   Compiling syn v1.0.96
error: linker `cc` not found
  |
  = note: No such file or directory (os error 2)

error: could not compile `proc-macro2` due to previous error
warning: build failed, waiting for other jobs to finish...
error: could not compile `syn` due to previous error
Error: Failed to read crate code: Cargo failed to expand the macros

Interesting. Does the musl toolchain from rustup finally support dynamic linking and procedural macros? Last time I checked it was completely impossible to use dynamic linking with rustup's musl toolchain


[Bug]: Doesn't work with openai/whisper-large-v2

What happened?
To reproduce the error:
With  examples/whisper
python prepare_whisper_configs.py --model_name openai/whisper-large-v2 --multilingual
When
python -m olive.workflows.run --config whisper_cpu_int8.json
[2023-07-27 08:17:13,182] [DEBUG] [config.py:122:fill_in_params] Missing parameter data_dir for component load_dataset
[2023-07-27 08:17:13,192] [DEBUG] [engine.py:618:resolve_goals] Resolving goals: {'latency': {'avg': None}}
[2023-07-27 08:17:13,192] [DEBUG] [engine.py:637:resolve_goals] No baseline got as no goal is provided the the goal is threshold
[2023-07-27 08:17:13,192] [DEBUG] [engine.py:436:run_no_search] Step no search with search point {'OnnxConversion': {}, 'OrtTransformersOptimization': {}, 'OnnxDynamicQuantization': {}, 'InsertBeamSearch': {}, 'AppendPrePostProcessingOps': {}} ...
[2023-07-27 08:17:13,192] [INFO] [engine.py:882:_run_pass] Running pass OnnxConversion
[2023-07-27 08:17:13,193] [DEBUG] [engine.py:890:_run_pass] Loading model from cache ...
[2023-07-27 08:17:13,196] [INFO] [engine.py:882:_run_pass] Running pass OrtTransformersOptimization
[2023-07-27 08:17:13,197] [DEBUG] [engine.py:744:_prepare_non_local_model] Model path is None, local or string name. No need to prepare
[2023-07-27 08:17:18,135] [ERROR] [engine.py:942:_run_pass] Pass run failed.
Traceback (most recent call last):
  File "/home/ykrasilnikov/.local/lib/python3.10/site-packages/olive/engine/engine.py", line 930, in _run_pass
    output_model = host.run_pass(p, input_model, data_root, output_model_path, pass_search_point)
  File "/home/ykrasilnikov/.local/lib/python3.10/site-packages/olive/systems/local.py", line 33, in run_pass
    return the_pass.run(model, data_root, output_model_path, point)
  File "/home/ykrasilnikov/.local/lib/python3.10/site-packages/olive/passes/olive_pass.py", line 391, in run
    components.append(self._run_for_config(child, data_root, config, str(component_output_path)))
  File "/home/ykrasilnikov/.local/lib/python3.10/site-packages/olive/passes/onnx/transformer_optimization.py", line 104, in _run_for_config
    optimizer = transformers_optimizer.optimize_model(input=model.model_path, **run_config)
  File "/home/ykrasilnikov/.local/lib/python3.10/site-packages/onnxruntime/transformers/optimizer.py", line 323, in optimize_model
    model = load_model(temp_model_path or input)
  File "/home/ykrasilnikov/.local/lib/python3.10/site-packages/onnx/__init__.py", line 176, in load_model
    load_external_data_for_model(model, base_dir)
  File "/home/ykrasilnikov/.local/lib/python3.10/site-packages/onnx/external_data_helper.py", line 65, in load_external_data_for_model
    load_external_data_for_tensor(tensor, base_dir)
  File "/home/ykrasilnikov/.local/lib/python3.10/site-packages/onnx/external_data_helper.py", line 45, in load_external_data_for_tensor
    with open(external_data_file_path, "rb") as data_file:
FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmp9o2iozdo/model.onnx.data'
[2023-07-27 08:17:18,135] [WARNING] [engine.py:362:run] Failed to run Olive on cpu-cpu: [Errno 2] No such file or directory: '/tmp/tmp9o2iozdo/model.onnx.data'
Traceback (most recent call last):
  File "/home/ykrasilnikov/.local/lib/python3.10/site-packages/olive/engine/engine.py", line 337, in run
    output = self.run_no_search(
  File "/home/ykrasilnikov/.local/lib/python3.10/site-packages/olive/engine/engine.py", line 443, in run_no_search
    ) = self._run_passes(next_step["passes"], model, model_id, data_root, accelerator_spec)
  File "/home/ykrasilnikov/.local/lib/python3.10/site-packages/olive/engine/engine.py", line 845, in _run_passes
    model, model_id = self._run_pass(pass_id, pass_search_point, model, model_id, data_root, accelerator_spec)
  File "/home/ykrasilnikov/.local/lib/python3.10/site-packages/olive/engine/engine.py", line 930, in _run_pass
    output_model = host.run_pass(p, input_model, data_root, output_model_path, pass_search_point)
  File "/home/ykrasilnikov/.local/lib/python3.10/site-packages/olive/systems/local.py", line 33, in run_pass
    return the_pass.run(model, data_root, output_model_path, point)
  File "/home/ykrasilnikov/.local/lib/python3.10/site-packages/olive/passes/olive_pass.py", line 391, in run
    components.append(self._run_for_config(child, data_root, config, str(component_output_path)))
  File "/home/ykrasilnikov/.local/lib/python3.10/site-packages/olive/passes/onnx/transformer_optimization.py", line 104, in _run_for_config
    optimizer = transformers_optimizer.optimize_model(input=model.model_path, **run_config)
  File "/home/ykrasilnikov/.local/lib/python3.10/site-packages/onnxruntime/transformers/optimizer.py", line 323, in optimize_model
    model = load_model(temp_model_path or input)
  File "/home/ykrasilnikov/.local/lib/python3.10/site-packages/onnx/__init__.py", line 176, in load_model
    load_external_data_for_model(model, base_dir)
  File "/home/ykrasilnikov/.local/lib/python3.10/site-packages/onnx/external_data_helper.py", line 65, in load_external_data_for_model
    load_external_data_for_tensor(tensor, base_dir)
  File "/home/ykrasilnikov/.local/lib/python3.10/site-packages/onnx/external_data_helper.py", line 45, in load_external_data_for_tensor
    with open(external_data_file_path, "rb") as data_file:
FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmp9o2iozdo/model.onnx.data'
[2023-07-27 08:17:18,144] [INFO] [engine.py:365:run] Package top ranked 0 models as artifacts
[2023-07-27 08:17:18,144] [WARNING] [packaging_generator.py:35:generate_output_artifacts] No model is selected. Skip packaging output artifacts.

Version?
Name: olive-ai
Version: 0.3.0
Summary: Olive is an easy-to-use hardware-aware model optimization tool that composes industry-leading techniques across model compression, optimization, and compilation.
Home-page: https://microsoft.github.io/Olive/
Author: Microsoft Corporation
Author-email<EMAIL_ADDRESS>License: MIT License
Location: /home/ykrasilnikov/.local/lib/python3.10/site-packages
Requires: numpy, onnx, optuna, pandas, protobuf, pydantic, pyyaml, torch, torchmetrics, transformers
Required-by:
freeze
alembic==1.11.1
attrs==21.2.0
Automat==20.2.0
Babel==2.8.0
bcrypt==3.2.0
blinker==1.4
build==0.10.0
certifi==2020.6.20
chardet==4.0.0
click==8.0.3
cloud-init==23.2.1
cmaes==0.10.0
cmake==3.27.0
colorama==0.4.4
coloredlogs==15.0.1
colorlog==6.7.0
command-not-found==0.3
configobj==5.0.6
constantly==15.1.0
contextlib2==21.6.0
contourpy==1.1.0
cryptography==3.4.8
cycler==0.11.0
dbus-python==1.2.18
Deprecated==1.2.14
distro==1.7.0
distro-info===1.1build1
filelock==3.12.2
flatbuffers==23.5.26
fonttools==4.41.1
fsspec==2023.6.0
greenlet==2.0.2
httplib2==0.20.2
huggingface-hub==0.16.4
humanfriendly==10.0
hyperlink==21.0.0
idna==3.3
importlib-metadata==4.6.4
incremental==21.3.0
jeepney==0.7.1
Jinja2==3.0.3
joblib==1.3.1
jsonpatch==1.32
jsonpointer==2.0
jsonschema==3.2.0
keyring==23.5.0
kiwisolver==1.4.4
launchpadlib==1.10.16
lazr.restfulclient==0.14.4
lazr.uri==1.0.6
lit==16.0.6
Mako==1.2.4
MarkupSafe==2.0.1
matplotlib==3.7.2
more-itertools==8.10.0
mpmath==1.3.0
netifaces==0.11.0
networkx==3.1
neural-compressor==2.2.1
numpy==1.25.1
nvidia-cublas-cu11==<IP_ADDRESS>
nvidia-cuda-cupti-cu11==11.7.101
nvidia-cuda-nvrtc-cu11==11.7.99
nvidia-cuda-runtime-cu11==11.7.99
nvidia-cudnn-cu11==<IP_ADDRESS>
nvidia-cufft-cu11==<IP_ADDRESS>
nvidia-curand-cu11==<IP_ADDRESS>
nvidia-cusolver-cu11==<IP_ADDRESS>
nvidia-cusparse-cu11==<IP_ADDRESS>
nvidia-nccl-cu11==2.14.3
nvidia-nvtx-cu11==11.7.91
oauthlib==3.2.0
olive-ai @ file:///home/ykrasilnikov/Olive
onnx==1.14.0
onnxruntime-extensions==0.8.0
opencv-python-headless==<IP_ADDRESS>
optuna==3.2.0
ort-nightly==1.16.0.dev20230725005
packaging==23.1
pandas==2.0.3
pexpect==4.8.0
Pillow==10.0.0
pip-tools==7.1.0
prettytable==3.8.0
protobuf==3.20.3
psutil==5.9.5
ptyprocess==0.7.0
py-cpuinfo==9.0.0
pyasn1==0.4.8
pyasn1-modules==0.2.1
pycocotools==2.0.6
pydantic==1.10.12
PyGObject==3.42.1
PyHamcrest==2.0.2
PyJWT==2.3.0
pyOpenSSL==21.0.0
pyparsing==2.4.7
pyproject_hooks==1.0.0
pyrsistent==0.18.1
pyserial==3.5
python-apt==2.4.0+ubuntu1
python-dateutil==2.8.2
python-debian==0.1.43+ubuntu1.1
python-magic==0.4.24
pytz==2022.1
PyYAML==5.4.1
regex==2023.6.3
requests==2.25.1
safetensors==0.3.1
schema==0.7.5
scikit-learn==1.3.0
scipy==1.11.1
SecretStorage==3.3.1
service-identity==18.1.0
six==1.16.0
sos==4.4
SQLAlchemy==2.0.19
ssh-import-id==5.11
sympy==1.12
systemd-python==234
threadpoolctl==3.2.0
tokenizers==0.13.3
tomli==2.0.1
torch==2.0.1
torchmetrics==0.10.0
tqdm==4.65.0
transformers==4.31.0
triton==2.0.0
Twisted==22.1.0
typing_extensions==4.7.1
tzdata==2023.3
ubuntu-advantage-tools==8001
ubuntu-drivers-common==0.0.0
ufw==0.36.1
unattended-upgrades==0.1
urllib3==1.26.5
wadllib==1.3.6
wcwidth==0.2.6
wrapt==1.15.0
xkit==0.0.0
zipp==1.0.0
zope.interface==5.4.0

Hi, @YuriyKrasilnikov
I think you hit the bug introduced by ORT fixes to move intermediate model from model source folder into temp folder for model with external data. (https://github.com/microsoft/onnxruntime/pull/16716)
Once the ORT with above PR is release, Olive need specify use_external_data_format=True at https://github.com/microsoft/Olive/blob/main/olive/passes/onnx/transformer_optimization.py#L104C44-L104C58
From the time being, there are two work around for the issues:

use the official onnxruntime 1.15.1
if you would like to use ort nightly build, would you please add use_external_data_format=True in Olive code mentioned in above link?

Hi @YuriyKrasilnikov , this is a known issue from ort-nightly. We are still fixing this. Can you try a different ort-nightly version? python -m pip install ort-nightly==1.16.0.dev20230629002 --index-url https://aiinfra.pkgs.visualstudio.com/PublicPackages/_packaging/ORT-Nightly/pypi/simple/

@xiaoyu-work thank you!!!
It works!!!


We are still missing a logout button, if you want to logout you need to remove the account manually through your device's settings.

BTW, try to use a descriptive title if you want your issue to be fixed.


FIX[JSONLoader]: Solving ValidationError when load()

In json_loader.py,
When text is a dict type,
text = text or  ""

The above snippet at line 100 make the program raise ValidationError from pydantic when calling Document(page_contnt=text, metadata=metadata) right after
Addressed this by converting text to dict whenever text is None
 text = json.dumps(content) if content else ""

Thank you for all the pointers. I have added unit tests and the option to validate text_content. After the change, the code was quite cumbersome, so I have broken load() into smaller methods. Please feel free to make any changes accordingly


Fix OmniSharp --encoding switch to apply to both stdin and stdout

When the --encoding switch was specified, it unintentionally only applied to stdin, but not stdout. This was due to the fact that the SharedConsoleWriter was instantiated before Console.OutputEncoding was set. Because SharedConsoleWriter initializes itself with the current value of Console.Out, it had the default encoding rather than the intended encoding.
A bit subtle.
cc @david-driscoll and @nabychan

:+1:


Add microservice calculating state from activity and detectedAnomaly

Is your feature request related to a problem? Please describe.
We need to calculate the machine state from activity and detectedAnomaly
Describe the solution you'd like
So we need a microservice enabled by default subscribing to all machines, watching for activity and detectedAnomaly and then applying the logic.
Logic (proposal, suggestions welcome):
Foreach activity message: if activity is false, then set state to UnspecifiedStopState. If activity is true, then set state to ProducingAtFullSpeedState (use timestamp of incoming activity message as state timestamp)
Foreach detectedAnomaly:

get current activity by fetching last x (e.g., 100) activity messages from kafka, ordering them by timestamp (not timestamp of kafka, but of the message) and then jus taking the last one (reason: it could happen that the messages are unordered).
If activity is true, then ignore message.
If activity is false, then set state to detectedAnomaly (assuming detectedAnomaly is a string containing a valid state number in here: https://docs.umh.app/docs/concepts/state/, need to append documentation to suggest using these state numbers instead of a free-written string)

it should be enabled by default in the helm chart and should be able to disabled in 000_commonConfig
Describe alternatives you've considered
Doing this logic in Node-RED and MQTT is impossible as it requires persisting state (where Node-RED is not good in).
Additional context
The logic above is a proposal and can be modified for a more reliable / performant approach. As a second step you could store the activity state also in-memory and only fetch it from kafka during startup. For performance: it should be able to handle 10 incoming activity and detectedAnomaly messages per second.

Should this application run in "at-least-once" mode, or is it ok to drop messages ?


Add prerequisite when installing via helm

Currently by "simply" following the instructions users face with:
❯    helm install kserve oci://ghcr.io/kserve/charts/kserve --version v0.13.0

Pulled: ghcr.io/kserve/charts/kserve:v0.13.0
Digest: sha256:84ec987a507fd494e9e1e4fb8110c56594fa37609cff6bd1d6eb4b5b84386aee
Error: INSTALLATION FAILED: unable to build kubernetes objects from release manifest: [resource mapping not found for name: "serving-cert" namespace: "default" from "": no matches for kind "Certificate" in version "cert-manager.io/v1"
ensure CRDs are installed first, resource mapping not found for name: "modelmesh-webhook-server-cert" namespace: "default" from "": no matches for kind "Certificate" in version "cert-manager.io/v1"
ensure CRDs are installed first, resource mapping not found for name: "selfsigned-issuer" namespace: "default" from "": no matches for kind "Issuer" in version "cert-manager.io/v1"

PING @alexagriffith @theofpa

/lgtm
/assign @yuzisun

/close


[ButtonBase] Fix borderRadius for Chrome 63

Fixes #8216. I tested it on Canary 63.0.3230.0.

@gokulchandra Thanks :)

I'd love to help more.

@gokulchandra Don't miss our good first issue tag :)


Fix Bug 4010 - API method to register does not return authentification token

Motivation and context

fixes #4010
When email verification is turned off in the all-auth settings, the rest-register api does not return auth-token key. This pull request solves the issue by returning the key in this condition.
Changes:

Modify get_response_data of RegisterViewEx in iam views to add a new response field 'key'
The value of key will depend on the email verification setting of all-auth. If email verification is 'none', its value will be request user's auth token key else it will be 'None'.

How has this been tested?

Tests

Created tests for 'rest_register' api located in cvat/iam/tests/test_rest_apis.py to verify its response, both in case of email verification being turned on and turned off.
From the root directory ran python manage.py test cvat.apps.iam.tests to run the tests

Checklist

[x] I submit my changes into the develop branch
[x] I have added a description of my changes into CHANGELOG file
[ ] I have updated the documentation accordingly
[x] I have added tests to cover my changes
[x] I have linked related issues (read github docs)
[ ] I have increased versions of npm packages if it is necessary (cvat-canvas,
cvat-core, cvat-data and cvat-ui)

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[x] I have updated the license header for each file (see an example below)

# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

Hi, @g-kartik
Thank your for the contribution!
Please expect delay in review because of New Year coming, and have a nice New Year celebration!

Hi, @g-kartik
Thank your for the contribution!
Please expect delay in review because of New Year coming, and have a nice New Year celebration!

Okay, Thank you!


Fix linux arm build

There is a copy-and-paste error in the Makefile. This fixes it.

Coverage remained the same at 38.88% when pulling eefe667346149190c3dbe93dbf3bff5ca881704d on fix/linux-arm-build into fc0214e82b661022001ab647613f27f4eafd0925 on main.


Fix nav issue after pressing "add more votes" on My votes step

@LukeSugiura please provide more info on how to test this.

i prefer we hold this, there is no emergency to push this. QA to focus on rest


feat(core): option to disable creating index files

Status
READY
Description
Adds an option to disable creating index.ts files.
Related PRs
Todos

[ ] Tests
[ ] Documentation
[ ] Changelog Entry (unreleased)

Steps to Test or Reproduce
Set option:
{
    output: {
        index: false
    }
}

My motivation for this change: When using vite there's no tree-shaking during development, so having an index barrel file causes every model to be fetched before the app can load. In a big app this is thousands of requests.

@codebutler seems really great I am just not sure about the name of the options do you have other idea then “index”? Personally nothing come to my mind

@codebutler seems really great I am just not sure about the name of the options do you have other idea then “index”? Personally nothing come to my mind

It's also known as a barrel file.  Something like createIndex, createIndexFile, or createBarrelFile?


Remove uppercase wordings

Questions
Answers

Description?
Remove uppercase wordings

Type?
improvement

BC breaks?
no

Deprecations?
no

Fixed ticket?
-

Sponsor company
@Creabilis

How to test?
-

Ping @Julievrz for review :)

@florine2623 That's expected behavior, @micka-fdz just wanted to remove the upper cases from wording. It's QA. ✅
You may ask why - necause, now when we decide that we want it lowercase, we will just remove the CSS rule. It wasn't possible before. 👍


Wrong weigths file for yolov3-tiny !!

Hello. You should update the readme, because the link for weigths file of "yolov3-tiny" is directing to weigths file of "yolov3". I downloaded it from https://pjreddie.com/darknet/yolo/  and now it is working properly.

Thanks i have update the documentation


[Android] backfaceVisibility not working.

View Style backfaceVisibility on android not working.
just set backfaceVisibility: 'hidden' and nothing happen.

that's also a knowing issue 😀 #6695 , has been pending for a long time

@nihgwu  Ahaha, thanks again)

@facebook-github-bot label Icebox

Hi there! This issue is being closed because it has been inactive for a while.
But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/android-backfacevisibility-not-working
ProductPains helps the community prioritize the most important issues thanks to its voting feature.
It is easy to use - just login with GitHub.
Also, if this issue is a bug, please consider sending a PR with a fix.
We're a small team and rely on the community for bug fixes of issues that don't affect fb apps.

@facebook-github-bot close


[Statie] add basic Latte filters

https://latte.nette.org/cs/filters

fix similarPost filter, register all services + add test

Not relevant anymore.


make service-list table body scrollable

#24

Hi,
Thank you for the contribution !
Please attach screenshots showing the difference for me to merge / update the package atom :)

Hey, I just tested the branch from @jtbairdsr and took some screenshots. I hope this is what you were looking for. Notice the little scroll bar on the right.
before

after

By the way, great addon. I just started using it but it already proved very handy. Thanks :)

Hi @eipiminus1 thank you for the screenshots, very helpful !

Nice! This was never released though. Had to copy/paste the changes.


ERROR: Cannot read property 'unshift' of undefined

I'm submitting a...

[ ] Bug report
[ ] Feature request
[ ] Documentation issue or request

In package

[ ] @ng-toolkit/init
[ ] @ng-toolkit/serverless
[ ] @ng-toolkit/universal
[ ] @ng-toolkit/pwa
[ ] @ng-toolkit/firebug

Current behavior

Expected behavior

Minimal reproduction of the problem with instructions

Example repository

What is the motivation / use case for changing the behavior?

Environment

Angular version: X.Y.Z

- Node version: XX
- Platform:

Others:

x2

x3

Closed as duplicated (#695)


Fix yaml.load warning

Used safe_load which limits the ability to construct an arbitrary Python object to simple Python objects like integers or lists. Check https://pyyaml.org/wiki/PyYAMLDocumentation#loading-yaml for further details

Close: https://github.com/eabglobal/juniper/issues/26


[stable/mogodb] Write access to volume broken

Is this a BUG REPORT or FEATURE REQUEST? (choose one):  BUG REPORT
Version of Helm and Kubernetes:
Helm Version: 2.9.1
Kubernetes Version: 1.10
Which chart:
stable/mongodb
What happened:
I installed the chart with no additional configuration. The pod went into a crash loop with the following log output:
Error executing 'postInstallation': EACCES: permission denied, mkdir '/bitnami/mongodb/data'

How to reproduce it (as minimally and precisely as possible):
helm install stable/mongodb --name mytest
kubectl logs deploy/mytest-mongodb

I had the same issue since the new version.
Version of Helm and Kubernetes:
Helm Version: 2.9.1
Kubernetes Version: 1.10.4
Which chart:
stable/mongodb
Welcome to the Bitnami mongodb container
Subscribe to project updates by watching https://github.com/bitnami/bitnami-docker-mongodb
Submit issues and feature requests at https://github.com/bitnami/bitnami-docker-mongodb/issues

nami    INFO  Initializing mongodb
mongodb INFO  ==> Deploying MongoDB from scratch...
Error executing 'postInstallation': EACCES: permission denied, mkdir '/bitnami/mongodb/data'

Seems buggy only with Chart Version: 3.0.4
helm install stable/mongodb --name mytest --version 3.0.3 works.

I had the same issue.
Version of Helm and Kubernetes:
Helm Version: 2.9.1
Kubernetes Version: 1.10.4
Which chart:
stable/mongodb
What happened:
Error executing 'postInstallation': EACCES: permission denied, mkdir '/bitnami/mongodb/data'

I have same issue for both charts 3.0.3 and 3.0.4
Version of Helm and Kubernetes:
Helm: 2.8.2
Kubernetes Version: v1.10.0
Which Chart:
stable/mongodb
What happened:
Error executing 'postInstallation': EACCES: permission denied, mkdir '/bitnami/mongodb/data'

I'm also encountering this issue but can't find a reliable way to reproduce it.


highlight and cross of the completed task

highlight and strike through the tasks which have been completed (check button)

Hi
Can I be assigned to this issue ?

Hi Can I be assigned to this issue ?

Assigned!, Thank you for showing interests


[BUG] Wrong error message during sign up

Browser Details: Chrome Version 85.0.4183.102 (Official Build) (64-bit)
Device Details: macOS 10.15.6 (MacBook Pro)
Note: Tried on cloud.
Steps to replicate:

Hit https://app.appsmith.com/user/login
Sign up with details -<EMAIL_ADDRESS>Sign out
Now go to the sign up page and again try to sign with<EMAIL_ADDRESS>
Actual Result: Message is displayed 'There is already an account registered with this username<EMAIL_ADDRESS>Please sign in.'
Expected Result: Message should be 'There is already an account registered with this Email<EMAIL_ADDRESS>Please sign in.'
Note: Since there is no mention of username on login/signup screens, it should be handled that way.

This can be resolved by changing the error text for the enum USER_ALREADY_EXISTS_SIGNUP in the file AppsmithError.java


[Bug] totalLabel overlap don't work when has datazoom

Version
1.12.9
Link to Minimal Reproduction
no need
Steps to Reproduce
a.txt
Current Behavior

Expected Behavior
拖动datazoom 标签防重叠能够生效
Environment
- OS:
- Browser:
- Framework:

Any additional comments?
No response

配置 overlap 后，实际已生效


Add coverall to follow our coverage

Hey guys !
I want to add Coverall to our repository because it'll help us to follow our coverage by adding a badge in our README.md plus it'll add comments in PRs which will indicate if our coverage is lower than before.
@mdo if you're ok with that, please see :

https://coveralls.io/sign-up
https://docs.coveralls.io/coveralls-notifications
https://github.com/nickmerwin/node-coveralls#usage

Edit:
Currently we have that, but it's normal :

/CC @XhmikosR @bardiharborow @cvrebert

ping @mdo we need you 🙏 😆

@Johann-S: I added this myself. Can you rebase?

Oh, and add the badge in README too.

Thanks @XhmikosR, I added the badge 😉

@Johann-S: can you change it to shields.io?


SPIKE: To implement new Dashboard

Child of #556

Can we use the existing widget library for the new user dashboards?
Can we use the existing flow for Dashboards?
If 1st is a no then finalize the design to separate the widget libraries from Tempus
If 1st is True then check for Cross compatibility between Angular 1.x and Angular 7

POC: A small working model demonstrating the outcome of the above points.
Depends on #1046

After Analysis it was found that current implementation of dashboards and widgets cannot be used in the new implementation, as the widgets which we will be displaying in the dashboards will be interactive and there will be lot of changes  need to be made if will use the old approach.
So the new approach is that a new implementation for user persona will be done based on the new mock ups provided.


MAINT: Remove remaining numpy.int_ and filter np.long warning

Hi @rgommers,
This is a follow-up PR for https://github.com/scipy/scipy/pull/19310.
I missed these two int_s because they were imported as numpy.int_ instead of np.int_.

Good catch. CI is unhappy though, looks like there's a bit more to clean up.

Ah yes, there was one more place - now it should be fine.

@rgommers @hawkinsp @pllim
I pushed a change that additionally filters numpy warning in scipy.

Sorry Mateusz, more trivia to work through - the CI failing on test_warning_calls_filters is real. The comment in that test explains - I think you can add this one to allowed_filters.

@pllim thanks for the review! I kicked off new nightly builds, so the fix should propagate shortly.

I can confirm that the warning is now gone. Thanks again for the quick fix!


⚠ GLDDNS Server (ns2.glddns.com) has degraded performance

In 53de112, GLDDNS Server (ns2.glddns.com) (ns2.glddns.com) experienced degraded performance:

HTTP code: 200
Response time: 513 ms

Resolved: GLDDNS Server (ns2.glddns.com) performance has improved in 260ae87 after 10 minutes.


package.json

Hi! First, thank you! Great set! Have you considered adding a package.json so that the repo can be downloaded with NPM?
Thanks again!

@ecarlisle from the command line, run: richleland/pygments-css


Upgrade default OpenSearch version to 1.2.2

Signed-off-by: TheAlgo<EMAIL_ADDRESS>Description
Upgrade default OpenSearch Version to 1.2.2
Issues Resolved
#178
Check List

[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Workflows will pass once OpenSearch 1.2.2 is available in docker hub

1.5.5 take by another PR use higher number @TheAlgo

1.2.2 opensearch released, please update these @TheAlgo.
Thanks.

1.2.2 opensearch released, please update these @TheAlgo.
Thanks.

@peterzhuamazon Do we want to wait for #171 to get merged and then address the CVE or should we bump version of #171 . I can do that honour there instead of here. Opinions?

use version 1.5.7

This will go after #159 and #84

Hold on as we have new issues for repository-azure, 1.2.3 incoming.
https://github.com/opensearch-project/opensearch-build/issues/1365

@TheAlgo please change to 1.2.3 as we have released the new version.
Thanks.

@DandyDeveloper please give an approval as we need to update OpenSearch to 1.2.3.
Thanks.


[e2e] Fix platform-integrations flake marker

What does this PR do?
Motivation
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on


added initial version of document generator

Adding initial version of Document Generator
modified from tensorflow/tools/docs
The docs can be created and pushed to  /docs
Once this pull request is accepted, we can add the command to "generate and push the docs" to build pipeline.

Reopening to fix CLA

@ewilderj I made first commit without adding email address, please help me figure out how to fix it.

Overrode the CLA status, submitter used wrong email address in error.

@seanpmorgan Sean, after discussion with @armando-fandango : We plan to address current comments and then make sure doc generator works nicely from command line, and then someone else, who're familiar enough with bazel, can take over from there in a separate PR for bazel integration.
What do you think?

@seanpmorgan Sean, after discussion with @armando-fandango : 1) We plan to address current comments and then make sure doc generator works nicely from command line; 2) and then someone else, who're familiar enough with bazel, can take over from there in a separate PR for bazel integration.
What do you think?

Sounds great. Thanks everyone for the reviews and iteration

FYI, @MarkDaoust added an example build_docs.py script to use the API generator: https://github.com/tensorflow/docs/blob/master/tools/templates/build_docs.py
Teams typically keep this in their tools/ directory (or wherever you want), and then it outputs to docs/api_docs/python/ (for example, see TF Datasets). This is the path we need to add to out importer config to bring it into the site.

closing this and creating a fresh pull request as the API generator is changed.


Failing UglifyJS due to ES6 in Modal.js

Summary:
Getting error:
SyntaxError: Unexpected token: punc ()) [./~/react-modal/lib/components/Modal.js:56,0]
In the method:
getDefaultProps: function () {
    return {
      isOpen: false,
      portalClassName: 'ReactModalPortal',
      ariaHideApp: true,
      closeTimeoutMS: 0,
      shouldCloseOnOverlayClick: true,
      parentSelector: () => document.body
    };
  },

Steps to reproduce:

Include react-modal node module
run UglifyJS

Expected behavior:
Doesn't die in UglifyJS
Additional notes:
Second time this has crept in within the past month or two.

Obviously, the simple fix here is to change the line
parentSelector: () => document.body

to
parentSelector: function() { return document.body; }

What version are you running?

In 1.6.5 (our latest release) that line doesn't look like what you have reported.
https://github.com/reactjs/react-modal/blob/3ada4fba8133db5750decb72cede1992c5d8a40a/lib/components/Modal.js#L56

Deleting my node modules folder and running a fresh install seemed to fix the issue.  My package defn is "^1.4.0"


How to clear data from DataConnector?

First off, cool project, I appreciate it!
I was trying to clear a graph that already had some existing data with a particular DataConnector that has a finite max_points, but I've tried setting the data using empty lists and it keeps complaining that NoneTypes are not subscriptable.
After reading the code a bit, I tried to clear the data with cb_set_data using 2 empty deques with my desired maxlen like this:
self.data_connector.cb_set_data(deque(maxlen=self.max_samples), deque(maxlen=self.max_samples))

But it still complained about the same problem.
Am I missing a way to clear plot data?

It took me a bit longer, that I anticipated. But now you should be able to use clear method in DataConnector to clear plot data. Please have a look at the latest release v0.6.7.

Nice! It works well for my purposes. Thank you for the prompt response!


Update kexec module to use Nan2

node-kexec is being used by several packages like usrbinenv or nodeos-mount-filesystems (in the future joker), but it's using directly the v8 APIs and is giving some problems on the latests versions of Node.js when compiling it. It would be needed to port it to use Nan2 instead.

Done in master, clossing.


[BUG] "TypeError: option values must be strings" when writing apiversion to config

Describe the bug
When trying to setup pylips with an old PhilipsTV (model 42PFL6097K/12 using apiversion 1) it throws a TypeError, because in line 156 it tries to write an integer to the config.
Console output

python pylips.py --host <IP_ADDRESS>

Checking API version and port...
Trying http://<IP_ADDRESS>:1925/6/system
Trying http://<IP_ADDRESS>:1925/5/system
Connection refused
Trying http://<IP_ADDRESS>:1925/1/system
Could not find a valid API version! Pylips will try to use ' 1 '
Traceback (most recent call last):
  File "pylips.py", line 477, in <module>
    pylips = Pylips(args.config)
  File "pylips.py", line 83, in __init__
    if self.find_api_version(self.verbose):
  File "pylips.py", line 156, in find_api_version
    self.config["TV"]["apiv"] = api_version
  File "C:\Users\davod\AppData\Local\Programs\Python\Python38\lib\configparser.py", line 1258, in __setitem__
    self._parser._validate_value_types(option=key, value=value)
  File "C:\Users\davod\AppData\Local\Programs\Python\Python38\lib\configparser.py", line 1185, in _validate_value_types
    raise TypeError("option values must be strings")
TypeError: option values must be strings

How to fix
Change line 156 to:
self.config["TV"]["apiv"] = str(api_version)

Thanks @DavidSchmidt00!
Wow, this is embarrassing - I guess I've been spending too much time with JS lately... Fixed now, sorry about that!

Thanks @DavidSchmidt00!
Wow, this is embarrassing - I guess I've been spending too much time with JS lately... Fixed now, sorry about that!

Thanks :)

Thanks :)


Update OCL AutoIt script

OCL is an awesome script and is easily the most popular non-core feature offered by Muledump. The script could use some updating to make it more user friendly.

Connections utilize non-secure, non-https connections; this should be changed.
Usage of Flash Projector requires modifying the user to modify the script.
Users can encounter installation and usage bugs which also may require modifying the script manually.

Either OCL should be updated to include the bug fixes and made more user friendly, or a customized oneclicklogin.au3 script generator should be added to Muledump.

For the immediate future, mulelogin.au3 has been updated with the following:

#RequireAdmin enabled by default at the top with simple instructions for disabling
Prompts updated to be more informative
SWF now loaded via HTTPS
ShellCommand section comments and examples updated