Reduction in /metadata API calls for multiple datasets

For a variety of projects, we've had to query /datasets and for each dataset, query the corresponding metadata using the /metadata endpoint. This often results in a lot of requests (sometimes 200+), which causes a slight delay and some extra load, that could potentially be unavoided.
We save our own data in the metadata column in the metadata table. This is primarily the data we've been interested in, but I believe there have been cases where we've been interested in the other columns (excluding keys).
Would there be a solution where these requests could be grouped into one? I'm happy to elaborate and submit a PR based on any approach that is agreed upon. This would be a beneficial addition to a multitude of internal projects.

For the record - we discussed this a while back (2 years ago), in a Slack thread, though (I just sent you the link). Let us make sure we share the arguments / conclusions here, for posterity.
Btw, this is somewhat related to

#104

in terms of providing optimized interfaces for bulk-retrieving data to populate UI elements for dataset display / selection.
The gist of the discussion 2 years ago was

You may want to do lazy loading in the client instead of retrieving all the data, to avoid long initial loading times?
However, if you have to do this server-side, perhaps you could extend Terracotta for your use case (we discussed a plugin, although we do not have any guidance on how to develop plugins)
This sparse and use-case-specific metadata retrieval sounds like a nice case for GraphQL, but maybe that is way to big a cannon...
@dionhaefner recommended:

From the top of my head, I would maybe make this endpoint accept a POST request with all requested keys as request body. Perhaps also restrict which entries you want, retrieving >1k geometry footprints when all you need is cloudcover would blow up your response size.

Since then, STAC has seen more uptake and could be an alternative route to explore for exposing metadata-heavy EO data collections in a programmatic way.

PRs welcome. I would probably accept the design proposed above if implemented cleanly:

make this endpoint accept a POST request with all requested keys as request body. Perhaps also restrict which entries you want, retrieving >1k geometry footprints when all you need is cloudcover would blow up your response size.

During a conversation with Jonas, I proposed introducing a ?metadata=true flag to the /datasets endpoint. These are my key reasons for it:

This flag would not require users to make two separate API calls. With the POST option, users would essentially have to pass the response from one endpoint to another to retrieve additional data. If the response body is large (which is often the case), repeatedly sending such large payloads seems inefficient.
This approach ensures we don't introduce a new request method, keeping the API's design uniform.
From my understanding, implementing ?metadata=true seems to be simple, as I believe we would only need to extend the query with a JOIN if metadata is true. It seems more clean than adding an entirely new endpoint.

I'd love to hear both of your opinions on this approach – and which one you think we should go with. I can submit a PR for either of them depending on what you decide :)
Both of them work for me, and they both solve my issue, so I'm happy either way :)
Thanks a lot for participating in this discussion and for sharing your thoughts.

I'm not 100% happy with giving up the strict separations of endpoints (every endpoint only does one thing)

Same here. How would we call a new bulk metadata retrieval endpoint, though? Just want to see whether we can semantically expand the existing endpoints in a meaningful way...
/more-metadata? /metadata-multi? /metadatas? /metadata-reduce? Or just branch on whether /metadata receives a GET or a POST request?

Also, POST would be more flexible in that you can first search for lots of datasets, then only get metadata for some of them.

Both for dataset selection and metadata property selection, POST seems more clean to me. With GET, you would need to include the column names in the URL, and I guess the list could get long.
Btw, how can a user get the names of available metadata properties (if they only have the endpoint)? By retrieving the metadata for one item and then get the property names from the response?
Another design question: Would we allow for a POST request that gives you data for all datasets (with pagination), i.e. without specifying datasets to retrieve metadata for?

Or just branch on whether /metadata receives a GET or a POST request?

That was my suggestion. So you'd either have GET example.com/metadata/key1/key2/key3 or POST example.com/metadata. The distinction is unambiguous because in the latter case you're not passing any keys, so they must be in the request body.

Btw, how can a user get the names of available metadata properties (if they only have the endpoint)? By retrieving the metadata for one item and then get the property names from the response?

I guess so. Not perfect but anything else seems like overkill.

Another design question: Would we allow for a POST request that gives you data for all datasets (with pagination), i.e. without specifying datasets to retrieve metadata for?

I see no legitimate use case for this.

Thanks for the comments!
Just to make sure I'm understanding correctly - and we're all on the same page - the PR should include the following:

A POST example.com/metadata endpoint, where the payload is an array of objects with a k/v pair used for the filtering and another array of keys for the response.

Example:

{
   "filter":[
      {
         "key1":"val1"
      },
      {
         "key2":"val2",
         "key2-1":"val2-1"
      }
   ],
   "response":[
      "key1",
      "key2",
      "key3"
   ]
}

Please let me know if you think the payload should be different.
Are we adding limits to this? Either a hard-coded limit or one the user can specify?

This should be opt-in only.

Is this a requirement for the PR or something that we should look into doing at a later date? Would there be a major performance difference for this endpoint vs. the /datasets endpoint, in terms of potential for DOS?
If this is desired for the PR, how should users be able to opt in/out?

Empty arrays should not be allowed.

I can see there being a potential use-case for this if the amount of datasets is not large and all the information should be displayed on a viewer. It is probably a niche use case though, but users will likely try to go around it if they need it.

If I'm missing or misunderstanding anything, please let me know. I'll get started on a PR as soon as we agree on the final details – thank you both again :)

I would just use this payload to start with:
{
    "keys": [
        ["key1a", "key2a", "key3a"],
        ["key1b", "key2b", "key3b"],
        ...
    ]
}

There's no "filtering" involved, the user is expected to call /datasets, then use the response to populate the request body.
As for the desired columns, we can just add these as a query parameter to the /metadata endpoint.

Are we adding limits to this? Either a hard-coded limit or one the user can specify?

This should use the same pagination as /datasets.

Is this a requirement for the PR or something that we should look into doing at a later date? Would there be a major performance difference for this endpoint vs. the /datasets endpoint, in terms of potential for DOS?

I'm not sure. This fetches much more data than /datasets so the queries may get expensive. Then again, pagination would probably alleviate that. We can start implementing the feature then think about that later (maybe after some benchmarking).


🐛 [Bug] Borders on Profile Page

🐛 Bugreport

Remove the grey border around the QR-Code Part

in PR https://github.com/gradido/gradido/pull/887


Modded ores don't spawn on Beta generation

I've created a few worlds with Tech Reborn and Astromine, and both of their sets of ores will not spawn on Beta generation. Other mods that affect cave generation, such as Cave Biomes, are working fully alongside this type of generation, and the ores spawn in normal terrain generation.

Appears to be an issue with the datapack-based biomes the mod uses.  I'll look into workarounds.

Partially fixed, Astromine should now be compatible.  Unfortunately Tech Reborn appears to inject its ores only into biomes supplied to the vanilla biome provider.  Since the biomes in this mod are not added to the default world type, they do not get TR's ores.

Apologies for the lateness of this, I've only recently figured out how to get TR to work with the mod and added it to v1.0.8.  Thanks for your patience (if you're still waiting)!


Motion: PDF-headers duplicated while line-number-outside

When using the outside line number mode, headers get displayed twice in PDF.

surprisingly, it only happens when using line numbers outside. With line numbers inside and line numbers off, everything works as it is supposed to.

I found the bug, and that's weird.
The first (with the line number) gets displayed, cause of the h1 (2 3 4 5) Tag is processed. that's correct.
The other one gets processed, cause a span Tag gets processed, which is the weird part.
The correct structure (which should also be healthier for line-numberin purpose would be:)

 HEAD

But what CKEditor is doing in here:

   HEAD

The PDF routine is doing everything correctly (h-tags should not be treated differently to other tags).
So the CKEditor routine has to be changed.
@emanuelschuetze

@tsiegleauq I'm not sure if we can fix easily this CKEdtior behavior. Maybe you can make a quick fix today in your pdf code? I want to make a 2.1b4 release tomorrow.

There can not be a quick fix for that on PDF generation side. Adding
special cases for this requires a whole re-write of the parser.
On Mar 3, 2017 15:25, "Emanuel Schütze"<EMAIL_ADDRESS>wrote:

@tsiegleauq https://github.com/tsiegleauq I'm not sure if we can fix
easily this CKEdtior behavior. Maybe you can make a quick fix today in your
pdf code? I want to make a 2.1b4 release tomorrow.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/OpenSlides/OpenSlides/issues/3025#issuecomment-283966189,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJwkyNCBG9FLMcUIqQ114VKP9EuM6_iaks5riCLxgaJpZM4MPhXv
.


pip3 install keras, face_recognition, opencv-python
python3 main_code.py

hi,
could you please give some description? I dont understand what is not working


[IDF5.0] abort() on core 1 doesn't lead to reboot (IDFGH-9183)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

IDF version.
v5.0
Operating System used.
Linux
How did you build your project?
Command line with idf.py
If you are using Windows, please specify command line type.
None
Development Kit.
Custom board, ESP32-S3
Power Supply used.
9V wall plug
What is the expected behavior?
Reboot when calling assert(false) or abort() on core 1.
What is the actual behavior?
Doesn't reboot. The last printed line is Rebooting... and then the board is stuck.
This only happens for aborts on core 1. On core 0 it works fine.
Steps to reproduce.
Note:  This is tested using an ESP32-S3

Create an example project for the ESP32-S3 with the standard settings
Use the code from the "More Information" section
Flash it and run it, observe the logs

Debug Logs.
I (91) cpu_start: Pro cpu start user code
I (91) cpu_start: cpu freq: 160000000 Hz
I (91) cpu_start: Application information:
I (94) cpu_start: Project name:     foo
I (98) cpu_start: App version:      1
I (102) cpu_start: Compile time:     Jan 19 2023 12:57:05
I (109) cpu_start: ELF file SHA256:  0997ddcfa6d99dd4...
I (114) cpu_start: ESP-IDF:          v5.0
I (120) heap_init: Initializing. RAM available for dynamic allocation:
I (127) heap_init: At 3FC94480 len 00055290 (340 KiB): D/IRAM
I (133) heap_init: At 3FCE9710 len 00005724 (21 KiB): STACK/DRAM
I (140) heap_init: At 3FCF0000 len 00008000 (32 KiB): DRAM
I (146) heap_init: At 600FE010 len 00001FF0 (7 KiB): RTCRAM
I (153) spi_flash: detected chip: gd
I (157) spi_flash: flash io: dio
I (161) cpu_start: Starting scheduler on PRO CPU.
I (0) cpu_start: Starting scheduler on APP CPU.

abort() was called at PC 0x42007937 on core 1
0x42007937: taskFn at /home/marcel/abort-bug-minimal-sample-proj/main/foo.c:8

Backtrace: 0x40375cd2:0x3fceac20 0x40379b69:0x3fceac40 0x4037f02a:0x3fceac60 0x42007937:0x3fceacd0 0x4037c4fd:0x3fceacf0
0x40375cd2: panic_abort at /opt/esp/idf/components/esp_system/panic.c:412

0x40379b69: esp_system_abort at /opt/esp/idf/components/esp_system/esp_system.c:142

0x4037f02a: abort at /opt/esp/idf/components/newlib/abort.c:38

0x42007937: taskFn at /home/marcel/abort-bug-minimal-sample-proj/main/foo.c:8

0x4037c4fd: vPortTaskWrapper at /opt/esp/idf/components/freertos/FreeRTOS-Kernel/portable/xtensa/port.c:151

ELF file SHA256: 0997ddcfa6d99dd4

Rebooting...

More Information.
A minimal example:
#include "freertos/FreeRTOS.h"
#include "freertos/task.h"

#include <stdio.h>

void taskFn(void* foo) {
    vTaskDelay(pdMS_TO_TICKS(2500));
    abort();
    while(1) {

    }
}

void app_main(void)
{
    TaskHandle_t xHandle = NULL;
    xTaskCreatePinnedToCore(taskFn, "MyTask", 4096, NULL, tskIDLE_PRIORITY, &xHandle, 1);
}

This was reported in https://github.com/espressif/esp-idf/issues/10320 and fixed through https://github.com/espressif/esp-idf/commit/c280d4b56e1429ff9aa1f7f8bf6afa6381a099f7

That's good news. Feel free to close this bug as duplicate.
Any plan on when a release containing the fix will be available?

Any plan on when a release containing the fix will be available?

Release v5.0.1 is under internal QA, hopefully it will be published in next few weeks.


Fix Cigars Sprites + YAML fix for Inhand unlit cigars/cigs

About the PR

For the longest time cigars and a little while ago cigs were not working properly inhand when lit or unlit. For some reason there was never a held prefix for the item component so I added that and fixed up the sprites to match and work on all angles.
Why / Balance

Ruins my entire emersion and thinks this game is unrealistic :trollface:
Changelog
Make sure to take this Changelog template out of the comment block in order for it to show up.
:cl:

fix: Lit cigars inhand sprites are now visible.

Cant you just add this to the BaseCigar? IIRC all of them follow the same structure so it wouldnt look that odd (would have to test tho) Also, this needs a screenshot

Cant you just add this to the BaseCigar? IIRC all of them follow the same structure so it wouldnt look that odd (would have to test tho) Also, this needs a screenshot

I am but a humble YAML warrior, but no I don't think it would work like that considering the sprites are not in the same folder. I also just tested it and it did not work. I will send screenshots after I update the fancy cigar sprites to be match. I think for future purposes the fancy cigar might have a slightly different inhand sprite so I will make it separated.


Test components with Singel

Using https://github.com/diegohaz/singel to check if Reas components conform to the Singel pattern.

Codecov Report

Merging #87 into master will not change coverage.
The diff coverage is 100%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3795db1...511aa36. Read the comment docs.


Can't find RTSPlayerPawn, trouble with the tutorial

// From README.md
1. Create a RTSPlayerPawn blueprint.

I can't seem to find a blueprint define called RTSPlayerPawn. The instructions say  to create this pawn as the camera. Am I doing something wrong?

Whoops, this is made in the project not the plugin


Merge commits from 1.0.x

Do you want to reference the original 1.0.x PR's in the commit message for this PR?


Migrate solid-oidc issues from authentication-panel

.. issues that can be clearly separated. Leave general discussions, comparisons etc..

Non-exhaustive list of issues candidate for migration:
https://github.com/solid/authentication-panel/issues/181; https://github.com/solid/authentication-panel/issues/86; https://github.com/solid/authentication-panel/issues/146

I have moved all the issues that were clearly Solid-OIDC, so I'll mark this as closed. If there are other issues to move, please let me know


Error on multiple select?

When doing a multiple select of images (shift/enter) it appears that not all
images are selected from the first to the last. It appears that only those
images that are contained in certain columns are selected.

Issue is with the most recent version of ImageListView.

Operating system is Windows 7 (64 bit).

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 21 Oct 2014 at 6:42

I can't replicate this. Please resubmit this issue with more details.


Create and deploy chocolatey packages during release

:white_check_mark: Build ConfuserEx 488 completed (commit https://github.com/mkaring/ConfuserEx/commit/cc1ee40d1a by @mkaring)

:white_check_mark: Build ConfuserEx 507 completed (commit https://github.com/mkaring/ConfuserEx/commit/21043078f8 by @mkaring)


@prisma/client is not being installed when you run npx prisma generate

Bug description
There seems to have been a regression between 2.23.0 and 2.24.0 where npx prisma generate does not install the @prisma/client package by default.
This makes our onboarding workflow quite a bit more error prone.
How to reproduce

1. Setup your project
mkdir fresh-package && cd fresh-package
npm init -y
npm install prisma
npx prisma init

2. Add a model to your prisma/schema.prisma
// This is your Prisma schema file,
// learn more about it in the docs: https://pris.ly/d/prisma-schema

datasource db {
  provider = "postgresql"
  url      = env("DATABASE_URL")
}

generator client {
  provider = "prisma-client-js"
}

model User {
  id    Int     @id @default(autoincrement())
  email String  @unique
  name  String?
}

3. Run npx prisma generarate

Create a index.js script

import { PrismaClient } from "@prisma/client"
console.log(PrismaClient)

You'll see a red squiggly line with the following error:
Cannot find module '@prisma/client' or its corresponding type declarations.

This is because the @prisma/client package was never installed. It's not in node_modules or in the package.json
Expected behavior
We should install the @prisma/client package when you run npx prisma generate.
If you run through the steps with npm install<EMAIL_ADDRESS>you'll see the Prisma Client is installed. It should also appear in the package.json.
Prisma information

Environment & setup

OS: OSX
Database: Any
Node.js version: v14.16.0

Prisma Version
npx prisma version
Environment variables loaded from .env
prisma               : 2.24.0
@prisma/client       : Not found
Current platform     : darwin
Query Engine         : query-engine f3e341280d96d0abc068f97e959ddf01f321a858 (at node_modules/@prisma/engines/query-engine-darwin)
Migration Engine     : migration-engine-cli f3e341280d96d0abc068f97e959ddf01f321a858 (at node_modules/@prisma/engines/migration-engine-darwin)
Introspection Engine : introspection-core f3e341280d96d0abc068f97e959ddf01f321a858 (at node_modules/@prisma/engines/introspection-engine-darwin)
Format Binary        : prisma-fmt f3e341280d96d0abc068f97e959ddf01f321a858 (at node_modules/@prisma/engines/prisma-fmt-darwin)
Default Engines Hash : f3e341280d96d0abc068f97e959ddf01f321a858
Studio               : 0.397.0

Also appears in @dev and 2.24.1.

Duplicate of https://github.com/prisma/prisma/issues/7579


Feature proposal: savable filters

I think it would be handy to be able to save filters. this PR is just a quick and dirty proof-of-concept. I haven't checked where sleek stores the user config but I would imagine the saved filters could live in a json file next to the actual todo.txt file.

Hi @freder , thanks for the PR, really appreciate it.
I havn't had the chance to check what exactly is done in your code, so I'm just refereing to the PRs title. Filter (contexts, projects, priorities) are already being persisted in the user configuration (/home/$USER/.config/sleek/user-preferences.json). So if you select one the filters and close sleek, your selected filter should still apply when you reopen sleek. If this doesnt happen on your side, you might have found a bug and I would be looking forward to a bug report.
Anyhow I just double checked the latest release and it doesn't seem broken. But maybe I'm misreading your proposal.


util: Added script to copy resources from mongodb

This script copies all resources from a mongodb database locally The script creates a resources.json and downloads all the resources. It also updates the resources.json to point to these local downloads instead of the cloud bucket.

Change-Id: I15480c4ba82bbf245425205c9c1ab7c0f3501cc3

I am trying to get the download progress working, I am having some issues trying to fix import errors when I try to use src/python/gem5/utils/progress_bar.py.

@trollet91 Thanks for the detailed review! This is really helpful!

There is another bug that I found, the resources with new versions with the same URL as older versions will not update to point to the local version. I will push another commit with all the requested changes and this bug fixed.

There is still an error with md5sum, it is because the md5 on the JSON is that of the decompressed file.
Potential solution:

add a field to the JSON that refers to the compressed md5 as well.

I could not find a way to get hard links to work with git. I just put the default config in the offline_db folder. For using the config files I switched it to python as the config file that we have in gem5 is a .py file.


Making AppImages updateable

To make an appimage updateable, we need to pass the parameter -u to appimagetool.
appimagetool is called by the function generate_type2_appimage which pass all its arguments to appimagetool.
generate_type2_appimage is called by the main script pkg2appimage but isn't passing any arguments.
My temporary fix, to make an appimage updateable,  is to edit the script pkg2appimage to add the arguments -u "<url>" to the function call of generate_type2_appimage.
It would be good to be able to do:

./pkg2appimage-*.AppImage recipes/XXX.yml -u "<url>"
or to add the update url directly to the yml file.

What do you think?
Thx

As pkg2appimage is meant as a tool for end users to make AppImages from debs for applications where the original author does not provide official AppImages, this has not been implemented. What is your use case?

pkg2appimage is used to to make official VSCodium's AppImage.
I've just updated the script to always use the lastest version of pkg2appimage to avoid an issue with some distro.

Please ask the VSCodium project to provide an official AppImage.

official VSCodium's AppImage.

Hi @daiyam I can't seem to find it on https://vscodium.com/?

Yep, it's not on the website ;) but the AppImage are available at https://github.com/VSCodium/vscodium/releases


/${USER:ID}/g triggers Expected a number and instead saw 'U'

The following RE
/\${USER:ID}/g

Causes the following jslint errors
 #1 Expected a number and instead saw 'U'.
    /\${USER:ID}/g; // Line 1, Pos 4
 #2 Expected '}' and instead saw 'S'.
    /\${USER:ID}/g; // Line 1, Pos 5
 #3 Unescaped '}'.
    /\${USER:ID}/g; // Line 1, Pos 12

https://regexr.com/49oq7
Originally reported here: https://github.com/reid/node-jslint/issues/174

The current version of JSLint says

Expected '0'.
Expected '}' and instead saw 'U'.

Looks like JSLint wants us to escape { and } here.

I am concerned about the following: what if one linting tool tells us to do something, and the other tells us to do the opposite?
See https://eslint.org/docs/rules/no-useless-escape.

\$\{USER:ID\} would be an example of a useless-escape.
JSLint is wrong to require escape here isn't it?

@Mehuge {} in some cases is used for specifying a quantifier, e. g. \d{4} (means "exactly four digits"). I guess JSLint wants us to explicitly indicate that { and } here are intended to be treated literally.

'/${USER:ID}/g' expects the braces to be literal, so escape them.

Regular expression syntax does not require the escape, as they are already interpreted as literal.
The quantifier syntax is defined as. It's variants similarly so.
{n} where n is an integer >= 1
USER:ID is not an integer, therefore {USER:ID} is not interpreted as a quantifier and the { } don't need to be escaped.  So it seems a bit strange that as they are interpreted as literals without the escape, in line with no-useless-escape, jslint should require them to be escaped.
Or perhaps I am misunderstanding what the point of the no-useless-escape comment above was trying to convey.

Clearly you are.

Clearly I am what?
Misunderstanding the point of no-useless-escape or I clearly am required to escape?
Clearly you don't want to discuss or clarify, so I am out.


Add node update controller to the deployments

Is your feature request related to a problem? Please describe.
Add node update controller to the deployments.
Describe the solution you'd like in detail
Add node update controller to the deployments so that the controller can run along with the csi driver.

/assign


fix: change x attr to y for y icon property

Looks a bit like a typo or I'm missing something? :)

Totally a typo :)


feat: support add components prefix

Description
Add a custom configuration compPrefix
Support adding a prefix to the custom components type name generated by the unplugin
Example：
Components({
  dts: true,
  compPrefix: 'El',
  dirs: ['src/components']
})

-- TestComp: typeof import('src/component/TestComp')['default']
++ ElTestComp: typeof import('src/component/TestComp')['default']
Components({
  dts: true,
  compPrefix: {
    prefix: 'El',
    include: ['test/components'],
  },
  dirs: ['src/components', 'test/components']
})

-- TestComp: typeof import('test/component/TestComp')['default']
++ ElTestComp: typeof import('test/component/TestComp')['default']
OtherTestComp: typeof import('src/component/TestComp')['default']
Linked Issues
https://github.com/antfu/unplugin-vue-components/issues/372 how to add prefix with src/components or dirs ?
https://github.com/antfu/unplugin-vue-components/issues/385 How to add the prefix of all components in the 'src/components' directory ?
Additional context
I test this in my protect and it perform perfectly.

Another issue about that #438
Would be great to merge that new feature

+1. Need this feature for testing a Nuxt package where components have a prefix.
Did anyone find a workaround for now?

Would be a really useful feature, for example for PrimeVue, where compontents have no prefix.

Hey @winchesHe I tried out your fork, but I can't get it to work. Hope you could help me.
I'm trying to get this to work in my Vitest setup, but it always fails to resolve components.
[Vue warn]: Failed to resolve component: mc-attachments-display-item

That component is located at src/runtime/components/Attachments/DisplayItem.vue.
I tried this:
Components({
  dts: true,
  dirs: ["src/runtime/components"],
  deep: true,
  compPrefix: "Mc",
  directoryAsNamespace: true,
  allowOverrides: false,
})

But with no luck. Any idea on what to try or how to debug?

Hey @winchesHe I tried out your fork, but I can't get it to work. Hope you could help me.
I'm trying to get this to work in my Vitest setup, but it always fails to resolve components.
[Vue warn]: Failed to resolve component: mc-attachments-display-item

That component is located at src/runtime/components/Attachments/DisplayItem.vue.
I tried this:
Components({
  dts: true,
  dirs: ["src/runtime/components"],
  deep: true,
  compPrefix: "Mc",
  directoryAsNamespace: true,
  allowOverrides: false,
})

But with no luck. Any idea on what to try or how to debug?

maybe try the directoryAsNamespace false

Hey @winchesHe I tried out your fork, but I can't get it to work. Hope you could help me.
I'm trying to get this to work in my Vitest setup, but it always fails to resolve components.
[Vue warn]: Failed to resolve component: mc-attachments-display-item

That component is located at src/runtime/components/Attachments/DisplayItem.vue.
I tried this:
Components({
  dts: true,
  dirs: ["src/runtime/components"],
  deep: true,
  compPrefix: "Mc",
  directoryAsNamespace: true,
  allowOverrides: false,
})

But with no luck. Any idea on what to try or how to debug?

maybe try the directoryAsNamespace false

Also tried that. Still nothing. Is there a way to check which components it got and how it named them?

Another way I know is change the file name, It seems to be generated based on the file name.
If you want to check how it named them you can debug the plugin in you editor.

will this get merged?


Implement stdlib smt module for Word key/values

Partially addresses issue https://github.com/maticnetwork/miden/issues/258 by introducing the procedures smt::get, smt::update and smt::insert in a new smt standard library module. These procedures allow manipulation of compacted sparse Merkle trees with Word-sized keys. The sparse Merkle tree advice set is modified to permit a compacted representation, where leaf values can be stored at depths that are smaller than the maximum depth of the tree.
Integration tests are present for these three procedures, with some associated documentation describing the structure of the compact representation.
The following tasks remain to be implemented:

[x] Handle insertion case when the branching point is an existing compacted leaf node, not an internal node (referred to as a type 1 insertion in the smt_insert_key integration test documentation)
[ ] Use empty hashes that assume a maximum tree depth of 256
[ ] Fix get_path test case error for non-compacted SMT advice set
[ ] Fully document the procedures (including soundness checks and required advice tape)
[ ] Refactor Miden assembly to improve readability and reduce cycle count by optimizing stack accesses

Thank you! This looks great! A few comments about the general approach and structure (i.e., this is not an in-depth review).

I think the overall approach works, and I don't see any soundness issues. But I'd like more people to review the general construction (not Miden assembly implementation) to see if maybe you and I missed anything.
I would probably put compact SMT advice set into a separate module. It will result in some code duplication - but shouldn't be too bad since you can reuse Store in both w/o modifications. I think it might be cleaner that way. We could call them SimpleSmt and CompactSmpt or something similar.
The comments you have in integration tests are awesome! But I'd probably move them either to .masm file or to the SMT module. I, personally, tried to understand how SMT works by reading .masm file and only then went to look at tests.
For the .masm module, I'd probably have just two external interfaces: get and set. Internally, set could still split out into update vs. insert (and the split could be determined using advice input), but externally, I think it would be much more convenient to have only these two procedures exposed.
We can probably simplify management of the advice tape by creating one or more specialized decorators. Such decorator could be executed once at the beginning of the procedure and it would inject all required values (in the right order) into the advice tape.
I wonder if we can make insertions simpler if we allow leaf nodes to be only at specific depth. For example, we could say that a leaf nodes must be at depth which are multiples of 8 (e.g., 8, 16, 24 etc.).  This way, depth of a given branch always increases in increments of 8. But I haven't really thought about this much - so, it is possible that this actually complicates things more.

Superseded by https://github.com/0xPolygonMiden/miden-vm/pull/1046, https://github.com/0xPolygonMiden/miden-vm/issues/1048, https://github.com/0xPolygonMiden/miden-vm/pull/1036 and other related PRs.


Latest version is still 1.1.4 on atom packages

Hi
I tried installing this package but the listed version is still the old one. There was an old issue #5, with a similar problem but it seems that package.json has the correct version, so I don't know if something else is needed.

For now I've installed from source, but it would be better to have the official version updated.

Hi @fernando-alves, thanks for pointing this out!
Looks like the v1.1.5 release didn't get updated on the Atom Package Manager. To fix this I've tagged a new version (v1.1.6) and have verified that it shows up properly on APM.
This should let you install from inside the Atom Package Manager now rather than from source.

Great, that worked. Thanks!


bower support

Hi there,
I really like this jquery plugin, but unfortunately it is not available on bower (http://www.bower.io). Could you add it to bower for a simple dependency management?
Thanks!

Good idea, I will look to do this when I have time!

I registered your repo at bower. It is now available under the name jquery-load-template and directly linked to this code repository. It was very simple:
bower register jquery-load-template git://github.com/codepb/jquery-template.git


docker: Add docker to the release pipeline

Summary
Add a docker multi-arch build + deployment configuration.
For now the docker hub deployment is disabled.
Goreleaser provides binaries from the build step to the Dockerfile to ensure containers have the same files as the archives.
Test Plan
Tested with goreleaser release --skip-publish --snapshot --rm-dist
The files are here:
~$ docker images|grep conduit
algorand/conduit   1.0.1-next-amd64   0863fc121046   About a minute ago   96.9MB
algorand/conduit   latest-amd64       0863fc121046   About a minute ago   96.9MB
algorand/conduit   1.0.1-next-arm64   907990ee4310   About a minute ago   90.5MB
algorand/conduit   latest-arm64       907990ee4310   About a minute ago   90.5MB

The architecture appears as expected:
~$ docker image inspect algorand/conduit:latest-arm64 | grep Architecture
        "Architecture": "arm64",
~$ docker image inspect algorand/conduit:latest-amd64 | grep Architecture
        "Architecture": "amd64",

Looking good to me + Docker image builds successfully on my local machine.
I can't seem to run it locally due to exec: "./conduit": permission denied: unknown errors.

cd cmd/conduit and then run the command
I was playing around with possibly giving more informative suggestions by looking at the command's exec path, the current working directory, and computing a rel-path. But then I convinced myself that it wasn't worth it.

This Dockerfile needs goreleaser to build it, it does something special which puts the precompiled binaries at the root of the filesystem. I'm not exactly sure what the unknown permission denied error is, but I'm sure it's related.
The benefit is you know the artifacts in the tar files are identical to the ones in the docker image. The downside is you can't build it normally.
Can you think of a way to help people avoid trying to build it manually?


feat: sniping mode functionality moved to widget level

Description
Moved the sniping mode functionality support at widget level, and updated the test cases
Fixes #8667
Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Automated cypress tests

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:green_circle: Total coverage has increased
// Code coverage diff between base branch:release and head branch: fix/sniping-mode-refactor

Status
File
% Stmts
% Branch
% Funcs
% Lines

:green_circle:
total
55.63 (0.09)
37 (-0.01)
35.77 (0.01)
55.98 (0.1)

:red_circle:
app/client/src/actions/propertyPaneActions.ts
81.25 (-3.37)
100 (0)
40 (-10)
75 (3.57)

:green_circle:
app/client/src/ce/constants/messages.ts
77.09 (0.08)
100 (0)
32.06 (0.21)
81.99 (0.09)

:red_circle:
app/client/src/components/editorComponents/WidgetNameComponent/index.tsx
96.88 (-0.09)
83.64 (0)
100 (0)
96.77 (-0.11)

:green_circle:
app/client/src/sagas/SnipingModeSagas.ts
38.46 (18.46)
2.08 (-1.05)
28.57 (-11.43)
40.68 (19.89)

:green_circle:
app/client/src/selectors/commentsSelectors.ts
85.25 (1.64)
64.71 (2.95)
73.33 (0)
90.59 (2.35)

:red_circle:
app/client/src/utils/WidgetFactory.tsx
71 (-2.91)
66.67 (-3.92)
61.11 (-3.6)
71 (-2.91)

:red_circle:
app/client/src/utils/autocomplete/TernServer.ts
52.71 (-0.23)
40.83 (-0.84)
36.21 (0)
56.74 (-0.25)

:green_circle:
app/client/src/widgets/BaseWidget.tsx
79.69 (0.83)
46.81 (2.37)
75.76 (0.76)
78.86 (0.89)

:green_circle:
app/client/src/widgets/CanvasWidget.tsx
96 (0.08)
66.67 (0)
100 (0)
97.87 (0.04)

:green_circle:
app/client/src/widgets/ListWidget/index.ts
11.39 (2.3)
0 (0)
0 (0)
12.5 (2.5)

:green_circle:
app/client/src/widgets/ModalWidget/index.ts
50 (3.33)
0 (0)
0 (0)
50 (3.33)

:green_circle:
app/client/src/widgets/TableWidget/index.ts
47.06 (3.31)
100 (0)
0 (0)
47.06 (3.31)

:green_circle:
app/client/src/widgets/TabsWidget/index.ts
35.29 (4.04)
0 (0)
0 (0)
35.29 (4.04)

/ok-to-test sha=dd0227a

Test result: https://github.com/appsmithorg/appsmith/runs/4064269697

/ok-to-test sha=80f58dc

/ok-to-test sha=79995b6

/ok-to-test sha=fbf3775

/ok-to-test sha=fbf3775

/ok-to-test sha=b9bb424

/ok-to-test sha=999832c

/ok-to-test sha=999832c

/ok-to-test sha=4d6ba97

/ok-to-test sha=4d6ba97

/ok-to-test sha=fca78f9

/ok-to-test sha=8ca7869

/ok-to-test sha=3a73293

@pranavkanade was this PR not merged? is #8667 still open?


Alarm Confirm/acknowledge results in Status Code BAD

Please provide us with the following information:

This issue is for a: (mark with an x)
- [x] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

Start the Application with Alarms that are raised automatically
Connect to the OPCUA Server via Ua Expert for example
Confirm or acknowledge an alarm
Result will be:

Any log messages given by the failure

none

Expected/desired behavior

The result is Good

OS and Version?

Executed in the docker container image mcr.microsoft.com/iotedge/opc-plc:latest

Mention any other details that might be useful
The error may be located in the opc ua library.

Thanks! We'll be in touch soon.

Thanks for reporting this, we are investigating and will get back ASAP.


Is there a better way to "ban" unwanted types, like DateTime?

This is something I came up in 5 minutes.
Still not perfect because I can still "create the class" with datetime and not use them.. but ok!
I could achieve the same result using rosyln analyzers
    [Fact]
    public void Test1()
    {
        var r = Types
            .InCurrentDomain()
            .That()
            .ResideInNamespaceContaining("Template.")
            .And()
            .MeetCustomRule(
                r1 => r1.Fields
                    .Any(f => f.FieldType.Name == nameof(DateTime))
            )
            .Should()
            .NotHaveDependencyOnAll()
            // .NotBeUsedByAny()
            .GetResult();

        r.IsSuccessful
            .Should()
            .BeTrue();
    }

Every rule is divided into two parts, before and after  Should:

before Should - you select types for testing
after Should-  you define constraints which given type should pass or not

so, an idiomatic way to write this rule would be:
 var r = Types
     .InCurrentDomain()
     .That()
     .ResideInNamespaceContaining("Template.")
     .ShouldNot()
     .MeetCustomRule(
         r1 => r1.Fields
             .Any(f => f.FieldType.Name == nameof(DateTime))
     )
     .GetResult();

but I am not sure if this is what you are asking for.

What I'm asking is, if you wanted to prohibit the DateTime (or anything else) usage in the solution, how would you achieve that?

As you pointed out at the beginning, there are two ways, using Roslyn analyzers or through unit tests, both methods are valid, but they work on different levels.


Time points for daily climatology are not intuitive

📰 Custom Issue
Hello :)
I have a cube containing 4 full years of daily data. Using aggregated_by, I aggregate the cube using a "day" and "month" coordinate. This produces a daily climatology with time points that start in July 🤯 (the bounds are as expected).
Mathematically, this makes sense, since the mean of, e.g. (Jan 1, 2000), (Jan 1, 2001), (Jan 1, 2002) and (Jan 1, 2003) is in July 2001.
However, scientifically, this doesn't make sense, since a scientist would expect the first time point of a daily climatology created as above to be Jan 1.
The CF conventions state (at the end of paragraph 2 in Section 7.4): "The time coordinates should be values that are representative of the climatological time intervals, such that an application which does not recognise climatological time will nonetheless be able to make a reasonable interpretation.". I'm not sure this is happening in this case.
Would it be better to set the time points in the climatology file such that they are more representative of the climatological time intervals?

Related: #1422

Thanks @rcomer; I did search for previous issues but apparently not very well! 😜

If the plan is to use the upper or lower bound as the point, it may also be worth considering #3456.
Recent discussion on Met Office Yammer indicates that climatologies loaded from pp-files have the points matching the upper  bound, which does cause problems in coord-categorisation.  I understand that @lbdreyer may be looking into that issue, but it would be good to make the outcome of this consistent with the outcome of that I think.

See also #4665, which raises the same problem for monthly climatologies.

In discussion earlier, @rcomer, @jamesp and I concluded that the main blocker to fixing this is a decision as to what the behaviour should be. Broadly, we shouldn't be guessing what the user wants unless they asked us to.
An option would be to ask the user to choose / make them choose. I'm aware that this is similar to forcing them to fix it afterwards, but it should make that process quicker (and we could leave the current default in place as it's probably not a bad common sense choice when we're not working with a climatology).
Would that work for you @ehogan @mokhodge? Or is there better logic that you're aware of that we could use to derive a default that's reasonable in more circumstances?
n.b. #4295 showed an implementation of the above suggestion.

Thanks @wjbenfold, @rcomer, @jamesp! I would be happy to specify the required behaviour when creating the climatology. Would it be possible to include a climatological example in the documentation that demonstrates how to request this behaviour, please? :)

@wjbenfold , @rcomer , I have found this behaviour to be quite inconvenient, but I do deal with climatologies a lot. It was worse when I was new to Iris because it was only further down the line, when trying to complete another process with my data I realised the coordinate had been effectively reversed (dec was june etc).
It sounds good to put in an option to fix this. Would it also be possible to put in a warning message that let's users know that when they use this function this can happen if they don't choose otherwise?

Would it also be possible to put in a warning message that lets users know that when they use this function this can happen if they don't choose otherwise?

Hi @tkcollier, I'm not sure this is a good route to take (though open to arguments to the contrary). When we add more warnings, people become less sensitised to warnings, and for a lot of people (everyone using aggregated_by on something that isn't a climatology) there will be a warning here that doesn't matter to them.
I'd hope that adding an argument to the function that lets you choose how to overcome this (with associated information in the docstring) and an example in the docs (as @ehogan requested above) would allow someone hitting this issue to follow a chain of discovery something along the lines of
"that's odd" -> checks docs for function -> learns how to fix it -> makes fix
without causing warning fatigue in those for whom it isn't relevant?

I think @tkcollier  has a good point that you don't want to find out that things are odd after you've done a lot of processing.  You could conceivably have developed your code against a data set with an odd number of years - in that case the current behaviour would give you something that looked sensible in your time coordinate.  Then you add a year to your data set and only now realise something is wrong.
So I think I'm leaning back toward's @trexfeathers' idea of changing the default behaviour if the operation "looks climatological".  It could be configurable as well, of course.
We could add in a warning that is only thrown when the data "looks climatological", which would avoid the problem of clogging up the stderr when the warning is irrelevant.  But that's basically admitting that the default behaviour isn't helpful...

@wjbenfold @rcomer @jamesp Specifying an opition would work for me. If it is monthly climatology then it would be fine in most use cases to just return the month time points e.g. 01, 02, 03... and the same for daily rather then providing the whole DD-MM-YYYY string.

if the operation "looks climatological"

@rcomer I'm a bit worried that guessing this would lead to hard to diagnose errors and that any logic that tried this would cause more confusion in how it broke than it would save. I'm happy to be wrong about that though. I guess we could warn that we're assuming the data is climatological and actioning that? What sort of logic would you apply to catch climatological cases but not non-climatological ones?

just return the month time points e.g. 01, 02, 03...

@mokhodge I'm not sure what you mean here? Do you mean having a time coordinate that just gives a month but no year (and if so, how would that interact with the bounds, which have day, month and year)? Do the CF conventions include the ability to reference a month without a year?

if the operation "looks climatological"

@rcomer I'm a little bit worried that guessing this would lead to hard to diagnose errors, but maybe just looking for non-contiguous ranges would do it.

just return the month time points e.g. 01, 02, 03...

@mokhodge I'm not sure what you mean here? Do you mean having a time coordinate that just gives a month but no year (and if so, how would that interact with the bounds, which have day, month and year)?
I went digging in the CF conventions some more (https://cfconventions.org/Data/cf-conventions/cf-conventions-1.9/cf-conventions.html#climatological-statistics) and found the examples. Based on example 7.9, it looks like the correct choice for @ehogan's original question is 16/1/2000?

@wjbenfold example 7.9 is a seasonal climatology example; for the daily climatology example, I would expect there to be as many time points as there are days in a year (as defined by the input data), starting from Jan 1.

@wjbenfold I think what I meant is what @ehogan is describing. so if I give it a list of time points that have say 11 different months then I would want the climatology points to be 11 long, with a timepoint and corresponding .data for each month. If doing monthly climatology then I think the day and year returned are pretty meaningless. Although if CF conventions say it needs to return a day and year then fine but some kind of warning to describe why it has returned a time points as DD-MM-YYYY (and how they are calculated) instead of just MM would be useful as all I want to know for example is what the mean is for each month in the time series and knowing that the first month of the returned climatology corresponds to the first month in the original time series I provided it and so on.
Bonus functionality would be if I gave it a load a timeseries data say for Jan, March, October then it would return the monthly climatology with time points for Jan, March and October so Months 01, 03 and 10 rather than it returning the timepoints just months 1, 2, 3 (or 0, 1, 2 if using python indexing conventions) but actually the data for month 2 would be for March. Because I think the latter is what might happen in iris at the moment. Not sure if that makes sense - let me know.

if the operation "looks climatological"

@wjbenfold I'm a little bit worried that guessing this would lead to hard to diagnose errors, but maybe just looking for non-contiguous ranges would do it.

I wondered about checking contiguity too, but any coordinate that doesn't have bounds is non-contiguous.  Also you might average over a long contiguous time series to get an annual climatology.  The simplest thing would be to just check whether the upper and lower output bounds are more than a year apart, and declare a climatology in that case.  I'm racking my brains to think of an example where that would give a problematic false positive...

@mokhodge If doing monthly climatology then I think the day and year returned are pretty meaningless.

For you use-case, could you just ignore the output time coordinate and use the month number coordinate instead?

I've been thinking a bit more about this, and I'm drawn to a climatological argument to Cube.aggregated_by that causes it to set the points based on the point in the first cell that's contributing. It can then set the climatological boolean on any coordinates that have been treated as such whilst it's doing the aggregation.

should also be done for collapsed points

@rcomer would you see this as meaning something needed to change for collapsed points too? I've just about got my head around climatological aggregation but can't tell if you can also do a climatological collapse.

@wjbenfold if I only need a climatology for DJF, then I would just load all the data for December, January and February and collapse across the lot.  I would expect the point of the resulting scalar time coordinate to be consistent with having done aggregated_by("season", iris.analysis.MEAN) on a complete data set.
Having said that, if we're adding an optional keyword rather than changing the default behaviour then I don't think the inconsistency would matter as much.


fix(biome): remove 'css' duplicate

Problem:
There was 2 instances of the css string inside filetypes.
Solution:
Remove the duplicate and rearrange the filetypes in alphabetical order.

We could add a lint rule that ensures these kinds of items are alphabetized...


In Windows, Chinese characters are garbled

set locale = chinese
1、 .\toolkit.exe config -l=zh
2、 .\toolkit.exe -h

This will be fixed in 0.4.5


Index and member access in Ref

In GitLab by @ksiero on Nov 10, 2020, 15:38
Index and member access in Ref would make creating subref really easy. This would just create new subref with calculated offset and datatype. This would be useful etc. in wrapping record for Python and everywhere where the subref is created.

In GitLab by @ksiero on Nov 26, 2020, 10:57
mentioned in commit e796193716bd664416bf3252c79be97a1492f9ef

In GitLab by @ksiero on Dec 4, 2020, 16:28
mentioned in commit ad4dcb89b5d4855888e95f2d50d697c573e5568e

In GitLab by @ksiero on Nov 25, 2020, 09:33
mentioned in commit cc40c352ced7f0f2a661f1f540dda027ad50371b

In GitLab by @ksiero on Nov 24, 2020, 10:00
mentioned in commit 0a1a7db49f50a3a209c37ca1d9f79b6bc062c2a3

In GitLab by @ksiero on Nov 12, 2020, 14:36
mentioned in commit 65ce488f52c62bc6b652d84db2b4c821e32d9a50

In GitLab by @ksiero on Nov 26, 2020, 09:13
mentioned in commit e3f524e409474a0574a149ebf0ef58def3ba376b

In GitLab by @ksiero on Nov 12, 2020, 14:30
mentioned in commit 3222604f101bbd074ee7d7ac4bc26761f8a4087d

In GitLab by @ksiero on Nov 26, 2020, 15:13
mentioned in commit 032ff514a770389b68d09cfb9b61b0881413c002

In GitLab by @ksiero on Jan 17, 2021, 11:51
mentioned in commit dec6654a03a766e971bfbc0306d66fe91a5b03b6

In GitLab by @ksiero on Jan 18, 2021, 24:25
mentioned in commit 1641c2a29a4ff6fa3b7548237bb38c95fcec60cf

In GitLab by @ksiero on Jan 19, 2021, 12:19
mentioned in commit db0c6689a482ebdba87428edb0df63395eb59af2


Add MeshCentral to Remote Access and Control tools

Add MeshCentral to Remote Access and Control tools

I forgot about MeshCentral! I used it once and it was pretty good.


Codelens for tests only works for single test project in Solution

If you create 2 test projects in a solution as described in this comment on #1934, the second project does not show CodeLens annotations for running the tests. I was able to reproduce this case in VsCode on MacOS
https://github.com/OmniSharp/omnisharp-vscode/issues/1934#issuecomment-450362167

Can you please describe step by step the repro scenario or provide a sample project with this behavior?
It is not entirely clear to me how this should be repro based on the linked description. The original issue was closed because the step to add a newly created project to the solution was missing which caused the behavior (OmniSharp would track the solution and new project didn't belong to the solution).
Thanks.

No problem.

dotnet new sln -n CodeLensTest
Create test folder mkdir Test, cd ./Test
Create test project dotnet new xunit
Add project to solution dotnet sln ../CodeLensTest.sln add ./Test.csproj
Codelens annotations for Run Test and Debug Test appear on Scaffolded test method
Create second test folder mkdir Test2, cd ./Test2
Create test project dotnet new xunit
Add project to solution dotnet sln ../CodeLensTest.sln add ./Test2.csproj
build solution dotnet build CodeLensTest.sln
CodeLens annotations remain for test method in Test project but do not appear in Test2 project

This problem was resolved after upgrading mono as identified in #3034


[RFC] Dumping a string as properly escaped Crystal string literal

The spec command generates Crystal source code looking like this (simplified): %(require "./#{path}").
path is an arbitrary path and may include characters or combinations of characters that lead to the resulting code being either illegal or messed up (for example if it contains ", #{ or {{).
Some problems can be fixed using String#dump. That would escape double quotes, string interpolation and any illegal characters. But it does not excape macro expressions. This could theoretically offer an oportunity for code injection. For the spec runner that's maybe not a relevant threat, but would still cause issues when you're working with funny paths.
I'm not aware of any solutions in the compiler or stdlib that make this safe to work. Except appling manual gsubs which are prone to being incomplete.
(This specific use case could probably also make use of Compiler access to construct the respective AST nodes programmatically instead of letting the parser do that. This should avoid problems with string literal transformation.)
I've faced this problem before with baked_file_system. Since then it has a specific encoder which should make sure the generated string literals are sane and don't try to expand macro expressions: https://github.com/schovi/baked_file_system/blob/master/src/loader/string_encoder.cr
There surely are other cases as well, either in the compiler or in user code (macro run programs would come to mind) where a string is supposed to be written as a string literal in Crystal code and not cause any unexpected effect.
Maybe we could add handling for macro delimiters to String#dump. But I don't think that's good. I it my understanding that String#dump is a pretty generic method to escape a string using common escape sequences and not specific to Crystal syntax. So even escaped interpolation might be unexpected behaviour when you're using this method for other context than Crystal code (or Ruby which has the same syntax).
So perhaps it would be better to have a separate method specifcally for escaping a Crystal string literal. Or it could be a flag on String#dump. I'm not sure what's the best API.
Comments?

What about a string literal that is immune to any interpretation, wouldn't that solve all these usecases? Something like %l(a literal \ and two literal {{ with two literal }} coming after, literal #{ too followed by a literal }), l for literal, but totally up to discussion of course.
Of course to then interpolate values you would have to use concatenation or String.build directly, but maybe that's not so bad for mostly generated code.

As a workaround for now I guess you could wrap the generated code into {% verbatim do %} {% end %}

This is just String.inspect, and it should simply be fixed to be safe against macros

it my understanding that String#dump is a pretty generic method to escape a string using common escape sequences and not specific to Crystal syntax.

inspect is made to be specific to Crystal, though

What about a string literal that is immune to any interpretation, wouldn't that solve all these usecases?

So %l would essentially be %q wrapped in verbatim 🤔
It still needs to escape the end delimiter, and currently that's not possible in percent string literals. But can probably be fixed relatively easily (#5403). And the escape method would need to support a configurable end delimiter.
@oprypin Yeah, that's actually a good point 🤔 🤔 I'd really like inspect to return what could be used as crystal code to recreate that exact value. At least where that's possible, primitives, simple data structures. Unfortunately #7525 has lead us in a different direction 😞
But with this use case in mind, it actually fits perfectly I think. Just add macro expression escapes.

Can you provide an example of code injection? I also don't understand how this can happen given that macros are compile time things. Security concerns with code injection only happen at runtime.

Generally: security vulnerabilities always find a way. Someone will see how to exploit it even if you don't see right now.
Using Crystal compiler & source code as an implementation detail of some service turns this into a run-time injection.
Silly example: there's an online service that lets you download a binary which only prints the text that you supplied to it. It happens to be implemented by creating source code puts #{input.inspect}. You call it with download_binary?text=Hello {%`echo pwned`%}.

I don't think @straight-shoota's motivation here is runtime security though, but code generation safety.

But macro code isn't executed inside string literals...

Hmmmm seems so :o
https://carc.in/#/r/9zi8

Both security and safety are a concern here.

Can you provide an example of code injection?

Say I'd run a service that provides ready-built custom hello world programs. Users can enter a name to be greeted and the service then compiles a binary with the user-provided name embedded. Obviously, it uses Crystal as a programming language because it's simply the best for this kind of software ;) When the user-provided name contains unescaped macro expressions, it could be used for code injections. A name like {{ `run_some_program` }} for example could compromise the build service.
Macro expressions in string literals do work inside a macro block:
{% begin %}
  puts "{{`echo ok`}}" # => ok
{% end %}

https://carc.in/#/r/9zi9

Yes, but how can an string passed by a user get into that macro.

Oh, I just read it. If you provide user input to a program, I think you have other concerns too, like using a sandbox, etc. At that point, having a library or something that escapes that code sounds good. I'm not sure it belongs to the std.
That said, I wouldn't mind a macro_escape method for String, but we'd have to be careful about explaining when to use it.

Plus you already have this implemented. I just don't think this is a common use case, to be honest.

There isn't actually much that needs to change. I believe we can agree that the return value of String#inspect should be a valid and self-contained string literal in Crystal. This is almost the case except for macro expressions.
To fix this we have basically two options:

escape macro expression delimiters in String#inspect
don't evaluate macro expressions in string literals

I'd actually prefer the latter. I don't think it's useful to have macro expansion in literals, it can certainly be surprising. It's also not consistent because it doesn't even work outside of macro bodies (so perhaps it's just a mistake that it works inside?). If you need to expand a macro expression inside a string literal, you can just wrap it in string interpolation. The compiler could even resolve that interpolation at compiler time, so that "#{ {{ foo }} }" is completely equivalent to "{{ foo }}". Reads a bit mor ugly, but this is really a very rare use case. I'd rather have that than lots of escaped curly braces in String#inspect.
Furthermore we should also clarify the use case and behaviour of #dump. I'm actually not sure anymore what it is about.
Currently, it's exactly the same except that all non-ascii characters are also escaped. Crystal code must be UTF-8 and doesn't need unicode characters escaped. So the combunation of unicode escapes + string interpolation escapes doesn't seem to make sense.


Push Changes - Feedback from John

After John discussed with Michael - seems like the best approach for handling subscriptionIds is to perform regular syncs - the pushsubscriptionchange method doesn't seem to make sense.

So just to make sure I understand the model we're recommending: whenever you visit a page that wants to use push notifications, you register and get back the subscription object, and you unconditionally pass it to sendSubscriptionToServer().
And while implementing sendSubscriptionToServer() is outside the scope of this sample, the idea would be that it would submit a combination of the subscription id, the subscription endpoint, and... what else? A user identifier? Or a browser identifier? Or both? And how will the server know to expire old subscription entries?
The changes you made look :+1: to me, so I don't think this should delay your merge. Happy to take the discussion off this PR if needed.


fast-route data found, but no collection exists for: kadira_settings

Getting this error when package updated

I hope this is fixed now with FR 2.0


Add TikTok please

Hi,
Addon for FF (107.0.1 64Bit Windows) does not work with Tik Tok Videos, such like: this or this.
Would be great, if it would ;-D
Thank you.

Maybe over the holidays I might find some time to finally take a stab at #3 and make the list of domains this add-on applies to configurable. No promises yet, though…


Conditionaly define EMBER_AF_PLUGIN_REPORTING

Problem
With the move to #3464, EMBER_AF_PLUGIN_REPORTING is enabled globally (see #3608)
It should be enable only if needed.
Proposed Solution
One possible solution would be to fix the templates helper and add an hasReportableAttributes method that will conditionally include this macro in gen_config.zapt
One other possible solution would be for the gen_config.zapt #define to be part of a global header that is generated at built-time. It may also enable the ability to automatically include the right dependencies for building depending on the set of choosen cluster.

I believe in practice in CHIP all attributes are reportable, and all nodes have attributes that can change (e.g. in Basic), so reporting is always needed...

Per @bzbarsky-apple 's comment above, closing, makes sense that reporting is always required. Please re-open if we're missing something!


Fix kitty tests with darwin global zshenv

Description of changes
The patch fixes tests on darwin.
Fixes: https://github.com/NixOS/nixpkgs/issues/312692
Patch posted upstream: https://github.com/kovidgoyal/kitty/pull/7800
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[X] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

FYI ultimately the issue is because 1) zsh is not isolated (is it because macos has sandbox = false by default?) and 2) nix-darwin configures zshenv so that when $HOME is not ~, it will dump to stderr from gpg-connect-agent. So while this fix should unblock the package builds on darwin, the IN_NIX_SHELL part may be unnecessary once https://github.com/LnL7/nix-darwin/pull/1051 is merged. (The patch that removes unnecessary test skips is still useful regardless.)

The issue with nanoseconds truncated in tests apparently is due to old Apple SDK used to build in nixpkgs that does not have utimensat? https://github.com/NixOS/nixpkgs/issues/143987#issuecomment-955749038

The tests now pass for darwin x86 as:
test_transfer_receive (kitty_tests.file_transmission.TestFileTransmission.test_transfer_receive) ... ok
test_transfer_send (kitty_tests.file_transmission.TestFileTransmission.test_transfer_send) ... ok

This is because of the patch included. I don't think we should merge it here though (it was merged in upstream: https://github.com/kovidgoyal/kitty/pull/7939) I will drop the patch and disable the test cases for now, but we should be able to re-enable them with the next kitty release.


png::decoder::Row is missing from the documentation

No page has been generated for Row and no link either.

I think this is because the struct is missing from the re-export at the crate root:
https://github.com/image-rs/image-png/blob/28035fd57312c29b38db5988fe84135de2d50e5d/src/lib.rs#L76-L81

Note that InterlacedRow has been made public in https://github.com/image-rs/image-png/pull/495


Critical bug PBIRS 15.0.1103.232

Hi,
new version of May2020 PowerBI Report Server 15.0.1103.232 still contain critical bug. In this version is completely not working scheduled data refresh in scale-out deployment, see https://community.powerbi.com/t5/Report-Server/PBI-Server-May-2020-not-refreshing-saved-reports/m-p/1135485
Please remove PBIRS May 2020 form downloads and go back to January 2020

Thanks for your comment, @josef78 . This looks like a support request or product question rather than documentation feedback. You might find a solution in the Power BI Community, at https://community.powerbi.com. If not, you can get support by going to https://support.powerbi.com.

@mihart Thanks, but, community cannot solve bug in Microsoft product, and support.powerbi.com is only for cloud Power BI service, not for Power BI Report Server, it is different product.


npm-run-all hijacks config field in package.json

Assigning properties to config in package.json produces errors like unknown options: 'myapp:option1', 'myapp:option2'.
npm-run-all should use a more specific field or at least coexist with other libraries using the config field.

@jakobrosenberg it's due to #60

I experienced the same problem, with CZ configured in config causing an npm-run-all error


terraform failing to create aws_iam_role_policy_attachment during planning

Description
Please provide a clear and concise description of the issue you are encountering, and a reproduction of your configuration (see the examples/* directory for references that you can copy+paste and tailor to match your configs if you are unable to copy your exact configuration). The reproduction MUST be executable by running terraform init && terraform apply without any further changes.
If your request is for a new feature, please use the Feature request template.

[x ] ✋ I have searched the open/closed issues and my issue is not listed.

⚠ Note
Before you submit an issue, please perform the following first:

Remove the local .terraform directory (! ONLY if state is stored remotely, which hopefully you are following that best practice!): rm -rf .terraform/
Re-initialize the project root to pull down modules: terraform init
Re-attempt your terraform plan or apply and check if the issue still persists

Versions

Module version [Required]: 20.2.0

Terraform version: 1.7.2

Provider version(s):
aws 5.35.0

Reproduction Code [Required]

Steps to reproduce the behavior:
module "eks_managed_node_group" {
  depends_on = [module.eks_cluster_k1]
  for_each   = toset([module.vpc.private_subnet_ids[0]])
  source     = "terraform-aws-modules/eks/aws//modules/eks-managed-node-group"
  version = "~> 20.2.0"

  name            = "ng-core"
  cluster_name    = local.cluster_name
  cluster_version = local.cluster_version

  cluster_primary_security_group_id = module.eks_cluster_k1.cluster_primary_security_group_id

  vpc_security_group_ids = [aws_security_group.allow_us_east_1.id, module.vpc.default_security_group_id]

  min_size     = 1
  max_size     = 1
  desired_size = 1

  instance_types = ["m7g.large"]
  capacity_type  = "ON_DEMAND"
  ami_type       = "BOTTLEROCKET_ARM_64"
  subnet_ids     = [each.value]
}

Expected behavior
Should work without issues

Actual behavior
Seeing errors during planning phase

Terminal Output Screenshot(s)

Additional context

you are doing two things that are really bad, one of which won't work when creating resources for the first time
module "eks_managed_node_group" {
  # See - https://github.com/hashicorp/terraform/issues/26383#issuecomment-699149145
  # Do not use `depends_on` like this, it already implicitly is dependent on the cluster due to the information it requires from the control plane
  depends_on = [module.eks_cluster_k1]
  # See - https://github.com/hashicorp/terraform/issues/30937
  # You should use static keys when iterating over objects with `for_each`
  for_each   = toset([module.vpc.private_subnet_ids[0]])
}

For now, there isn't any module changes related to this error - you will need to modify how you are using the module to remediate the errors

thank you. i didnt know about these 2 pitfalls. especially the one about depends_on still confuses me heh.


Fix potential hang in Sender.Send()

There were two observers of env.Sent, the session mux and the sender. If the sender was the first to read from the channel, this would cause the session mux to be blocked.
In order to support multiple observers, the channels must be treated as semaphores which are signaled when closed.
Don't terminate a session's mux if a transfer wasn't sent due to context cancellation/timeout (this is not terminal).

[ ] The purpose of this PR is explained in this or a referenced issue.
[ ] Tests are included and/or updated for code changes.
[ ] Updates to CHANGELOG.md are included.
[ ] MIT license headers are included in each file.

/azp run


Markers column: move information to cell_type column (To Marcel Schulz)

The “marker” content for IHECRE00000253 could be moved to “cell_type” (“early T cell precursor (ETP) phenotype”).

Interesting observation. I am not sure though currently. When I look at the other entries from this record it states: that it is from capillary blood (tissue_type) and a primary tissue from a t-cell acute lymphocytic leukaemia (donor_health_status). So I guess the question is whether the marker "early T cell precursor (ETP) phenotype" refers to something they observe looking at the results from sequencing all cells, or whether some kind of cell sorting was done. If something was sorted, we need to contact the people involved to know in detail which markers were used. Then it may be possible to derive a more  concrete cell type.

EpiRR:
T-cell Acute Lymphocytic Leukemia from capillary blood of donor: Necker_TALL_001
I will contact Salvatore Spicuglia to ask about what markers did they use at Necker hospital (sample provider).

@daniel-rico were you able to follow up on this? we are still missing the appropriate markers.


I have a problem if using serial.v1/enumerator on macOS High Sierra (10.13.5)

Hi I'm trying to get information about the connected serial devices using the serial.v1/enumerator library but I get the following error:
go build go.bug.st/serial.v1/enumerator: invalid flag in #cgo LDFLAGS: -fconstant-cfstrings
My sample code used which comes from the godoc documentation of the serial.v1 library (https://godoc.org/go.bug.st/serial.v1) is:
package main

import "go.bug.st/serial.v1"
import "go.bug.st/serial.v1/enumerator"
import "fmt"
import "log"

func main() {

    ports, err := serial.GetPortsList()
    if err != nil {
        log.Fatal(err)
    }
    if len(ports) == 0 {
        log.Fatal("No serial ports found!")
    }
    for _, port := range ports {
        fmt.Printf("Found port: %v\n", port);
    }

    ports, err = enumerator.GetDetailedPortsList()
    if err != nil {
        log.Fatal(err)
    }
    if len(ports) == 0 {
        log.Fatal("No serial ports found!")
    }
    for _, port := range ports {
        fmt.Printf("Found port: %v\n", port);
    }
}

go env:
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/gibranvargas/Library/Caches/go-build"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/gibranvargas/go"
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/vm/fs2hwdyd6gg88yt_k41zmjwm0000gp/T/go-build854035366=/tmp/go-build -gno-record-gcc-switches -fno-common"

I tried the code in a Windows and Linux environment and I dont get the error. Has anybody encounter this issue?

It seems that golang has introduced restrictions on the cgo LDFLAGS, this is security related: https://github.com/golang/go/issues/23749.
BTW the good news is that it seems the flag -fconstant-cfstrings has been whitelisted and the patch will be availbale in go1.11: https://github.com/golang/go/commit/f7c2a71632854050d9fe6de115c6c346fcd9774c#diff-4edde0d5efc092a14e579fd0de312bdeR51
So, until go1.11 is published, some quick workarounds:

remove the -fconstant-cfstring flag from usb_darwin.go and see if it compiles fine without it.
use the CGO_LDFLAGS_ALLOW="-fconstant-cfstring" env variable that should allow the above flag.
revert to a previous version of go :-)


HHH-16180 - Add test and fix

AssertionError when using using native query on table with InheritanceStrategy.JOINED

hi @jrenaat @beikov, I think there's still a bug, I get an exception as soon as the class hierarchy is not empty ? See https://github.com/hibernate/hibernate-orm/commit/58e858bf71291783209aa06e36b55c4e0e90bbd2#r127066983
What can I do to help ?

Create a new JIRA issue and open a PR with this change @jonenst, then we can look into it.

Hi @beikov, thanks, here's the JIRA https://hibernate.atlassian.net/browse/HHH-17303 and the PR https://github.com/hibernate/hibernate-orm/pull/7427


Estimating error term initial conditions $\boldsymbol\epsilon_0$

[x] present a model with the autoregressive cycle component

$$\epsilon_{t}=\alpha_1\epsilon_{t-1}+\dots+\alpha_p\epsilon_{t-p}+e_t$$
$$e_t\sim\mathcal{N}(0\sigma_e^2)$$

[x] also estimate the initial conditions $\boldsymbol\epsilon_0 = \epsilon_0, \dots, \epsilon_{-p+1}$ following the normal prior
$$\boldsymbol\epsilon_0  \sim\mathcal{N}_p(\mathbf{0}_p,\sigma_0^2I_0)$$
[x] write a short note
[x] a quick derivation or full conditional posteriors for the $T$-vector $\boldsymbol\epsilon$, $p$-vectors $\boldsymbol\epsilon_0$
[x] an R function with the sampler
[x] include your name in the author list

Hey @Punzbd This is a masterpiece! Thank you so much for this contribution! I corrected some typos and improhed your code by defining the Ha and HaHa matrices (v good names).


[Feature]: Add a custom AI that can call rest API endpoint

Checklist

[X] I've searched for similar issues and couldn't find anything matching
[X] I've discussed this feature request in the K8sGPT Slack and got positive feedback

Is this feature request related to a problem?
Yes
Problem Description
Our company developed another platform on top of openAI for compliance and security reason. And we can only use the internal API (similar API signature like openAI). Currently the openAI integration directly calls CreateChatCompletion as go-client code which does not work for our use case
Solution Description
Can we have a AI option that can call AI API as rest point? It will take the following parameters as configurable input from CLI/API

AI endpoint
Request payload body (json string)
Authentication header

Benefits
this provide more flexibility on the client side to configure the rest endpoint directly
Potential Drawbacks
No response
Additional Information
No response

Hi @lili-wan thanks for creating this issue.
If you're using an openAI like API you can configure an alternative endpoint e.g.
bash k8sgpt auth new --backend localai --model <model_name> --baseurl http://localhost:8080/v1

Would this work for you? Or do you have a completely different API?

Hi @lili-wan thanks for creating this issue. If you're using an openAI like API you can configure an alternative endpoint e.g.
bash k8sgpt auth new --backend localai --model <model_name> --baseurl http://localhost:8080/v1

Would this work for you? Or do you have a completely different API?

Is it necessary to provide a localai sample project for user to make integration with their self hosted llm?  Just a suggestion. @AlexsJones

Hi @lili-wan thanks for creating this issue. If you're using an openAI like API you can configure an alternative endpoint e.g.
bash k8sgpt auth new --backend localai --model <model_name> --baseurl http://localhost:8080/v1

Would this work for you? Or do you have a completely different API?

Is it necessary to provide a localai sample project for user to make integration with their self hosted llm? Just a suggestion. @AlexsJones

There are lots of tutorials on how to use k8sgpt/localAI.
The question I have is regarding @lili-wan use case for a generic restful API.

I've tried to setup the localai to point to a local endpoint made with huggingface tgi.
 k8sgpt auth update localai --model tgi --baseurl https://deepseek.k8scluster.ch/v1

but I get a
➜ k8sgpt analyze -b localai --explain
   0% |                                                                                | (0/17, 0 it/hr) [0s:0s]
Error: failed while calling AI provider localai: error, status code: 422, message:

Running a test query although works fine
curl https://deepseek.k8scluster.ch/v1/chat/completions \
    -X POST \
    -d '{
  "model": "tgi",
  "messages": [
    {
      "role": "system",
      "content": "You are a helpful assistant."
    },
    {
      "role": "user",
      "content": "What is deep learning?"
    }
  ],
  "stream": true,
  "max_tokens": 100
}' \
    -H 'Content-Type: application/json'


Fixed a typo in a comment.

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

@bors: r+ b186d2f5ae2ad958b50d85936214cbc9afb58f07

:hourglass: Testing commit b186d2f with merge 14c0535...

:sunny: Test successful - cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64


It is possible to subscribe two o more publications into a form

I try to use the CRUD resouce into a form  that contains two fields that are each one an array of objects.
First CRUD is ok, but second doesn't fill the selector with the query associated.
It is possible something like that?
"pages": [
{
"name": "insert",
"type": "page",
"query_name": ["phonetypes","emailtypes"],
						"components": [
							{
								"name": "insert_form",
								"title": "New Customer",
								"query_name": "customer",
								"mode": "insert",
								"submit_route": "clients",
								"cancel_route": "clients",
								"type": "form"
							}
						]
					},......}

Thanks

Add query name to containing page's "related_queries" array.
On Jun 19, 2016 03:35, "hulaigann"<EMAIL_ADDRESS>wrote:

I try to use the CRUD resouce into a form that contains two fields that
are each one an array of objects.
First CRUD is ok, but second doesn't fill the selector with the query
associated.
It is possible something like that?
"pages": [
{
"name": "insert",
"type": "page",
"query_name": ["phonetypes","emailtypes"],
                    "components": [
                        {
                            "name": "insert_form",
                            "title": "New Customer",
                            "query_name": "customer",
                            "mode": "insert",
                            "submit_route": "clients",
                            "cancel_route": "clients",
                            "type": "form"
                        }
                    ]
                },......}

Thanks
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/perak/kitchen-site/issues/313, or mute the thread
https://github.com/notifications/unsubscribe/AFXrXqaRSAR0npia1czHuQsISCXXHAjxks5qNJzMgaJpZM4I5EhF
.

Excellent!!!
"related_queries":[{"name":"phonetypes"},{"name":"emailtypes"}],
Thanks


Release/0.2.2

Should the vendor folder have been deleted too, rather than just excluded?

@paulboocock yup, I had removed them but in the same commit as adding to gitignore, which undid it 🤦  - fixed with rebase now. :)

Out of scope for 0.2.2 but it would be good to do a 0.2.3 with Snyk scanning in to. This is used in production now and doesn't have automated Snyk scanning on release.

Good shout, I hadn't realised it's not on here. We have a 0.2.3 bugfix release coming so we can get it into that one.


How to finetune with LoRA on a finetuned LLaMA with LoRA rather than the original LLaMA?

Nice work!
I can finetune the LLaMA-7B model via the script run_finetune_with_lora.sh
deepspeed ${deepspeed_args}
examples/finetune.py
--model_name_or_path ${model_name_or_path}
--dataset_path ${dataset_path}
--output_dir ${output_dir} --overwrite_output_dir
--num_train_epochs 2
--learning_rate 1e-4
--block_size 512
--per_device_train_batch_size 2
--use_lora 1
--lora_r 8
--save_aggregated_lora 0
--deepspeed configs/ds_config_zero3.json
--bf16
--run_name finetune_with_lora
--validation_split_percentage 0
--logging_steps 20
--do_train
--ddp_timeout 72000
--save_steps 5000
--dataloader_num_workers 1
| tee ${log_dir}/train.log
2> ${log_dir}/train.err
Then I get the checkpoints of LoRA at /output_models/finetune_with_lora. But I am wondering how to finetune the LLaMA with already finuetuned with LoRA. In other words, how to perform another fine-tuning based on the first fine-tuning? Should I change the  --model_name_or_path parameter or use another script? Looking forward to your reply.

I have the same request

check merge_lora.py
Merge base model and lora model into a full model.

This issue has been marked as stale because it has not had recent activity. If you think this still needs to be addressed please feel free to reopen this issue. Thanks


All Latency Tests have No Results

All the latency tests have a large cursor instead of results in the display.

If possible please fix quickly, thank you.

I am fixing this right now.

Thanks for raising this up. This is fixed. Root cause is the subscription hosts Azure storage accounts running out of MSDN monthly $150 budget. It seems someone repeatedly download blobs and generate a $200 billing for bandwidth on 4th March.

Thank you!


[Feature Request] Add OVH as provider

Hello,
Would it be possible to add the OVH provider?
If you authorize me I can make a PR for that, I already tested a little but the keys to configure OVH with LEGO requires the key “APIEndpoint” which is formatted in the code as “ApiEndpoint”, so it requires a modification of the code more important than adding (unless there is another way) :
ProviderOVH: providerGenerator(ovh.NewDefaultConfig, ovh.NewDNSProviderConfig

I'm fixing some autocert bugs. Then I'll check it for you. Get back to you later.

done please test if it works

As for not receiving your reply for 2 days, I'm closing this issue for now.


Mouse drag should not show selection handles

Description
Fix a bug that SelectableText sometimes show selection handles on Flutter Web
Related Issues
Fixes #69001
Tests
I added the following tests:
See files.

@justinmc @chunhtai please review :)

The Google testing failure seems like an infrastructure problem to me, I'm rerunning it.


Fixed a bug when some plugins wouldn't be editable

Since real preview now stores the data about corresponding plugins
on actual plugin markup (in forms of classes and jQuery data) -
plugins that have their markup somehow modified or cloned wouldn't
appear triggering tooltip or being editable by double clicking on
them. That was happening because libraries usually keep classes but
they do not keep the data and event handlers associated with the
plugin, so in case e.g. a slide was cloned - it wouldn't be
editable, you would have to find the original slide and double
click on that. This commit changes the way handlers for plugins are
attached so the only thing that is required from a library
modifying the plugin markup is the cms-plugin-x class.
Doesn't need the changelog since real preview was introduced in 3.4

nice 👍

Coverage increased (+1.2%) to 90.344% when pulling 9158768c85c27e110caec37262c6e0518e7b3e40 on vxsx:bugfix/dynamic-plugin-markup into 5c09f1d731aa644fb091941654a37843ff9eab7a on divio:develop.


Change the model-serve base image to RedHat.

As discussed in a meeting yesterday, in order to reduce the number of vulnerable libraries in the dockerimage, I would suggest to switch for the RedHat-based OpenJDK image. The new model-server image was working fine for our use cases.
According to trivy, the openjdk:11 base image contains 323 vulnerable libs/software (UNKNOWN: 0, LOW: 123, MEDIUM: 61, HIGH: 109, CRITICAL: 30).
According to trivy, the RedHat-based base image contains 97 vulnerable libs/software (UNKNOWN: 0, LOW: 52, MEDIUM: 45, HIGH: 0, CRITICAL: 0).
Trivy was run on the latest modelix-model image (image ID 3d0f0ea586e4) to obtain this result. The used command was trivy image modelix/modelix-model:latest .

Merged in with updated commit message in https://github.com/modelix/modelix.core/commit/c793daf1b27c0a0e4ec7398a89d9cc6d7e5234e7


Possibly fixed on gh-1417 branch

Wasn't fixed by #1438

Also there seems to be an issue with the json serde as I get the following json POST when one feed term is enabled and the other disabled
{
   "selectedIdSet":null,
   "fetchRelationships":false,
   "expression":{
      "type":"operator",
      "op":"AND",
      "children":[
         {
            "type":"term",
            "field":"Status",
            "condition":"EQUALS",
            "value":"Unlocked",
            "docRef":null
         },
         {
            "type":"operator",
            "op":"OR",
            "children":[
               {
                  "type":"term",
                  "field":"Feed Name",
                  "condition":"EQUALS",
                  "value":"COUNT_FEED_SMALL",
                  "docRef":null
               },
               {
                  "type":"term",
                  "field":"Feed Name",
                  "condition":"EQUALS",
                  "value":"COUNT_FEED_LARGE",
                  "docRef":null
               }
            ]
         }
      ]
   },
   "pageRequest":{
      "offset":0,
      "length":100
   },
   "sortList":null
}```

A partial fix has been merged but in some instances when the tab is opened the filter is not applied.  I think there is a race condition somewhere so the fetch is done before the criteria is set.
Needs more testing/investigation

I'm not seeing this race condition following further changes so closing


Wrong border-bottom of the last  inside a

Ionic version:  (check one with "x")
(For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] 2.x
[x] 3.x
[ ] 4.x
I'm submitting a ...  (check one with "x")
[x] bug report
[ ] feature request
Current behavior:
The last input on a form inside a <ion-list> shows at longer boder-bottom than the previous ones in Android.
Expected behavior:
All of them should be the same.
Steps to reproduce:
Use this page template to reproduce the issue:
<ion-header>
  <ion-navbar>
    <ion-title>Form test</ion-title>
  </ion-navbar>
</ion-header>

<ion-content>
  <ion-list>
    <ion-item>
      <ion-label>First input</ion-label>
      <ion-input></ion-input>
    </ion-item>
    <ion-item>
      <ion-label>Another input</ion-label>
      <ion-input></ion-input>
    </ion-item>
    <ion-item>
      <ion-label>One more input</ion-label>
      <ion-input></ion-input>
    </ion-item>
  </ion-list>
</ion-content>

You get something like the image below (highlighted what I'm referring to):

Related code:
https://stackblitz.com/edit/ionic-idg4tc - Check pages/home/home.html.
Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
cli packages: (C:\Users\Ivan.Perez\AppData\Roaming\npm\node_modules)

    @ionic/cli-utils  : 1.13.1
    ionic (Ionic CLI) : 3.13.2

global packages:

    cordova (Cordova CLI) : 7.0.1

local packages:

    @ionic/app-scripts : 1.3.12
    Cordova Platforms  : none
    Ionic Framework    : ionic-angular 3.5.0

System:

    Node : v6.11.0
    npm  : 3.10.10
    OS   : Windows 7

Misc:

    backend : legacy

Hello! Thank you for opening an issue with us!
This may or may not be intentional. I have labeled this with the "design decision" label because these types of things are going to be reviewed again in the near future.
Thank you for using Ionic

it's a bit annoying, are there good methods for this?

Guys, is there any solution for this? This is quite annoying!

The material design specs clearly are against the observed behavior here https://material.io/guidelines/components/text-fields.html

Unless there's a clear reason why this design decision was made by the implementor, we should make this change based on the Material Design specs.

Is there a way to quick fix this on an app using an Ionic older version?

Like this:
<ion-list>

  <ion-item>
    <ion-label floating>Email</ion-label>
    <ion-input required type="email"></ion-input>
  </ion-item>

  <ion-item>
    <ion-label floating>Password</ion-label>
    <ion-input required type="password"></ion-input>
  </ion-item>

  <div hidden></div>

</ion-list>


Aurora - Profile pictures have a straight line (shadow) next to them

Title says it all:

Up!

Here you can sovle it:
[class*="avatar-"], .image-33JSyf {
	box-shadow: none !important;
}

Here you can sovle it:
[class*="avatar-"], .image-33JSyf {
	box-shadow: none !important;
}

Where should we put this? I don't know CSS

base.css Line 358 (Section 3.a. Messages and Codeblocks)

OK so it works by putting this code in the live CSS Editor.


After treesitter update highlighting colors changed

Did you check docs and existing issues?

[X] I have read all the tokyonight.nvim docs
[X] I have searched the existing issues of tokyonight.nvim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
v0.9.5
Operating system/version
MacOS 14.2.1
Describe the bug
After this commit in the treesitter the highlighting looks different.
https://github.com/nvim-treesitter/nvim-treesitter/commit/2c1eb02e92734406866b993bd87111891830455b
Before:

After:

Steps To Reproduce
Update treesitter to at least 2c1eb02e92734406866b993bd87111891830455b and see typescript react files component names highlighting clours.
Expected Behavior
Color shouldn't be red - maybe it's me but it looks slightly off
Repro
-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath, })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
  "folke/tokyonight.nvim",
  "folke/tokyonight.nvim",
  -- add any other plugins here
}
require("lazy").setup(plugins, {
  root = root .. "/plugins",
})

vim.cmd.colorscheme("tokyonight")
-- add anything else here

I guess my example might have similar root cause

For those struggling with this, here are some highlight overrides that help keep things looking the way they used to (at least for typescript/react):
  on_highlights = function(hl, c)
    hl.Include = {
      fg = c.purple
    }
    hl.Label = {
      fg = c.red
    }
<EMAIL_ADDRESS>= {
      fg = c.blue1
    }
<EMAIL_ADDRESS>= {
      fg = c.dark3
    }
    hl['Function'] = {
      fg = c.blue
    }
    hl['CmpItemKindVariable'] = {
      fg = c.orange,
    }
    hl['LspKindFile'] = {
      fg = c.magenta2
    }
  end

I'm having a similar issue with yaml files and lua if statements. Yaml files are pretty much all the same color now and lua if statements are no longer colored.

A temporary fix is to lock tree sitter to 2c1eb02e92734406866b993bd87111891830455b.

hint: treesitter

So you’re saying I should file an issue with treesitter that yaml is all the same color and lua if statements aren’t colored?

I'm saying you're not using treesitter.
This is how it looks with treesitter:
Lua

Yaml

If Statements:

If it doesn't look like the screenshots, then something is wrong with your config.

I think the original issue is still valid, although I'm not sure whether the fix lies here or somewhere else. It seems like something changed with the way the treesitter typescript parser identifies things. Here is inspect info from tressitter locked to commit 2c1eb02e92734406866b993bd87111891830455b:

and here is the same file with the latest from treesitter:

It used to be blue, now it's red. Also just noticed export is different.
I've been getting around this by using the on_highlights callback:
local tokyo = {
  "folke/tokyonight.nvim",
  lazy = false,
  priority = 1000,
  opts = {
    style = "storm",
    lualine_bold = true,
    on_highlights = function(highlights)
<EMAIL_ADDRESS>= '#2ac3de'
    end
  },
}

Anyways, hope this helpful, and any insight would be appreciated!

The issue ispretty obvious from inspect.
TSX tags have alwasy been red as you can see in both your screenshots.
You've enabled the nvim-treesitter option additional_vim_regex_highlighting to also always load the old Vim syntax files.
Don't do that! That's just asking for issues.
That option should be removed.
I don't have the Inspect Synatx section:

Oh interesting. I did have that enabled. However, disabling it doesn't change it's been reclassified from @constructor.tsx to @tab.tsx. Thanks for the info!


P2IDR Script and test

Closes #12 together with https://github.com/0xPolygonMiden/miden-base/pull/187
The script works in all test cases. However, we can't really add assets to the account (and assert for it), because account::add_assets is missing. When we have it, we can finalize the scripts.
I might be able to reduce duplicated code, I am unsure if I need to create always a new MockDataStore or TransactionExecutor for every transaction.

Closing in favor of https://github.com/0xPolygonMiden/miden-base/pull/244


CircleCI: build & test debug + release

This runs each test once on the debug build and once on the release build.

The config.yml file may not be pretty, but the CircleCI web UI looks pretty nice.


Modularization // J9 prep

Define modules, dependencies, exports, opens for J9

Obsolete, as there are no dependencies on java version.


Updated Prerequisites

added this in the Prerequisites

Remove any previously created Restore Points (from the Restore Point Collection) that were created via Standard Policy if you want to recreate\convert the existing VM as TVM else the conversion operation will fail with OperationNotAllowed with Status Code 409 and ErrorMessage: "'VMName' cannot be upgraded to Trusted Launch as it is configured for Azure Backup using standard policy. Trusted Launch Backup is supported using Enhanced policy. Learn more about supported Trusted Launch upgrade scenarios at https://aka.ms/TrustedLaunchUpgrade".

Adding this change because of this: Based on the learnings from the ICM Incident-431365919 Details - IcM (microsofticm.com), I believe that we could avoid cases and escalations, if we leave a note for customers that may be converting their Standard VMs into TVMs: Enable Trusted launch on existing VMs - Azure Virtual Machines | Microsoft Learn

@AjKundnani
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off