Compile errors with iosfwd.h and Visual Studio 2019 Preview

Description
Tests involved a CHECK on std::string values will not compile in Visual Studio 2019 preview. It appears this is because <string> in this version does not drag in <ostream> anymore.
Steps to reproduce

Install Visual Studio 2019
Add (or overwrite an existing) example:

#include <doctest/doctest.h>

DOCTEST_MAKE_STD_HEADERS_CLEAN_FROM_WARNINGS_ON_WALL_BEGIN
#include <string>
DOCTEST_MAKE_STD_HEADERS_CLEAN_FROM_WARNINGS_ON_WALL_END

TEST_CASE("will not compile in VS2019") {
    CHECK(std::string("foo") == std::string("bar"));
}

Compile to get the following error

1>C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.20.27305\include\xstring(383): error C2027: use of undefined type 'std::basic_ostream<char,std::char_traits<char>>'
1>C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.20.27305\include\iosfwd(212): note: see declaration of 'std::basic_ostream<char,std::char_traits<char>>'
1>C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.20.27305\include\xstring(4285): note: see reference to function template instantiation 'std::basic_ostream<char,std::char_traits<char>> &std::_Insert_string<char,std::char_traits<char>,unsigned __int64>(std::basic_ostream<char,std::char_traits<char>> &,const _Elem *const ,const _SizeT)' being compiled
1>        with
1>        [
1>            _Elem=char,
1>            _SizeT=unsigned __int64
1>        ]
1>C:\dev\sins2\src\external\doctest\doctest.h(794): note: see reference to function template instantiation 'std::basic_ostream<char,std::char_traits<char>> &std::operator <<<char,std::char_traits<char>,std::allocator<char>>(std::basic_ostream<char,std::char_traits<char>> &,const std::basic_string<char,std::char_traits<char>,std::allocator<char>> &)' being compiled
1>C:\dev\sins2\src\external\doctest\doctest.h(839): note: see reference to function template instantiation 'doctest::String doctest::detail::StringMakerBase<true>::convert<T>(const T &)' being compiled
1>        with
1>        [
1>            T=std::string
1>        ]
1>C:\dev\sins2\src\external\doctest\doctest.h(993): note: see reference to function template instantiation 'doctest::String doctest::toString<L>(const T &)' being compiled
1>        with
1>        [
1>            L=std::string,
1>            T=std::string
1>        ]
1>C:\dev\sins2\src\external\doctest\doctest.h(1141): note: see reference to function template instantiation 'doctest::String doctest::detail::stringifyBinaryExpr<std::string,char[3]>(const L &,const char *,const R (&))' being compiled
1>        with
1>        [
1>            L=std::string,
1>            R=char [3]
1>        ]
1>C:\dev\sins2\src\test\engine\string\test_to_string.cpp(8): note: see reference to function template instantiation 'doctest::detail::Result doctest::detail::Expression_lhs<const std::string &>::operator ==<char[3]>(const R (&))' being compiled
1>        with
1>        [
1>            R=char [3]
1>        ]
1>C:\dev\sins2\src\test\engine\string\test_to_string.cpp(8): note: see reference to function template instantiation 'doctest::detail::Result doctest::detail::Expression_lhs<const std::string &>::operator ==<char[3]>(const R (&))' being compiled
1>        with
1>        [
1>            R=char [3]
1>        ]

Extra information
`/showIncludes' for VS2017 (will compile)
1>Note: including file: C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\string
1>Note: including file:  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\istream
1>Note: including file:   C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\ostream
1>Note: including file:    C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\ios
1>Note: including file:     C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\xlocnum
1>Note: including file:      C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\climits
1>Note: including file:       C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\yvals.h
1>Note: including file:        C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\yvals_core.h
1>Note: including file:         C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\xkeycheck.h
1>Note: including file:         C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\crtdefs.h
1>Note: including file:          C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\vcruntime.h
1>Note: including file:           C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\sal.h
1>Note: including file:            C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\concurrencysal.h
1>Note: including file:           C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\vadefs.h
1>Note: including file:          C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\corecrt.h
1>Note: including file:        C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\crtdbg.h
1>Note: including file:         C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\vcruntime_new_debug.h
1>Note: including file:          C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\vcruntime_new.h
1>Note: including file:        C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\use_ansi.h
1>Note: including file:       C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\limits.h
1>Note: including file:      C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\cmath
1>Note: including file:       C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\cstdlib
1>Note: including file:        C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\stdlib.h
1>Note: including file:         C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\corecrt_malloc.h
1>Note: including file:         C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\corecrt_search.h
1>Note: including file:          C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\stddef.h
1>Note: including file:         C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\corecrt_wstdlib.h
1>Note: including file:        C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\math.h
1>Note: including file:         C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\corecrt_math.h
1>Note: including file:       C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\xtgmath.h
1>Note: including file:        C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\xtr1common
1>Note: including file:      C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\cstdio
1>Note: including file:       C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\stdio.h
1>Note: including file:        C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\corecrt_wstdio.h
1>Note: including file:         C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\corecrt_stdio_config.h
1>Note: including file:      C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\streambuf
1>Note: including file:       C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\xiosbase
1>Note: including file:        C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\xlocale
1>Note: including file:         C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\cstring
1>Note: including file:          C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\string.h
1>Note: including file:           C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\corecrt_memory.h
1>Note: including file:            C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\corecrt_memcpy_s.h
1>Note: including file:             C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\errno.h
1>Note: including file:             C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\vcruntime_string.h
1>Note: including file:           C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\corecrt_wstring.h
1>Note: including file:         C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\stdexcept
1>Note: including file:          C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\exception
1>Note: including file:           C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\type_traits
1>Note: including file:            C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\xstddef
1>Note: including file:             C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\cstddef
1>Note: including file:             C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\initializer_list
1>Note: including file:           C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\malloc.h
1>Note: including file:           C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\vcruntime_exception.h
1>Note: including file:            C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\eh.h
1>Note: including file:             C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\corecrt_terminate.h
1>Note: including file:          C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\xstring
1>Note: including file:           C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\xmemory0
1>Note: including file:            C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\cstdint
1>Note: including file:             C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\stdint.h
1>Note: including file:            C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\limits
1>Note: including file:             C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\ymath.h
1>Note: including file:             C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\cfloat
1>Note: including file:              C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\float.h
1>Note: including file:             C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\cwchar
1>Note: including file:              C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\wchar.h
1>Note: including file:               C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\corecrt_wconio.h
1>Note: including file:               C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\corecrt_wctype.h
1>Note: including file:               C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\corecrt_wdirect.h
1>Note: including file:               C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\corecrt_wio.h
1>Note: including file:                C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\corecrt_share.h
1>Note: including file:               C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\corecrt_wprocess.h
1>Note: including file:               C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\corecrt_wtime.h
1>Note: including file:               C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\sys/stat.h
1>Note: including file:                C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\sys/types.h
1>Note: including file:            C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\new
1>Note: including file:            C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\xutility
1>Note: including file:             C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\utility
1>Note: including file:              C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\iosfwd
1>Note: including file:            C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\xatomic0.h
1>Note: including file:            C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\intrin0.h
1>Note: including file:         C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\typeinfo
1>Note: including file:          C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\vcruntime_typeinfo.h
1>Note: including file:         C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\xlocinfo
1>Note: including file:          C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\xlocinfo.h
1>Note: including file:           C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\ctype.h
1>Note: including file:           C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\locale.h
1>Note: including file:         C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\memory
1>Note: including file:          C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\xmemory
1>Note: including file:         C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\xfacet
1>Note: including file:        C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\system_error
1>Note: including file:         C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\cerrno
1>Note: including file:         C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\xcall_once.h
1>Note: including file:         C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\xerrc.h
1>Note: including file:        C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\share.h
1>Note: including file:  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\xstring_insert.h
1>Note: including file:  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\xpolymorphic_allocator.h
1>Note: including file:   C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\tuple

`/showIncludes' for VS2019 Preview (will NOT compile)
1>Note: including file: C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.20.27305\include\string
1>Note: including file:  C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.20.27305\include\xstring
1>Note: including file:   C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.20.27305\include\iosfwd
1>Note: including file:    C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.20.27305\include\yvals.h
1>Note: including file:     C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.20.27305\include\yvals_core.h
1>Note: including file:      C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.20.27305\include\crtdefs.h
1>Note: including file:       C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.20.27305\include\vcruntime.h
1>Note: including file:        C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.20.27305\include\sal.h
1>Note: including file:         C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.20.27305\include\concurrencysal.h
1>Note: including file:        C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.20.27305\include\vadefs.h
1>Note: including file:       C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\corecrt.h
1>Note: including file:      C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.20.27305\include\xkeycheck.h
1>Note: including file:     C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\crtdbg.h
1>Note: including file:      C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.20.27305\include\vcruntime_new_debug.h
1>Note: including file:       C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.20.27305\include\vcruntime_new.h
1>Note: including file:     C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.20.27305\include\use_ansi.h
1>Note: including file:    C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.20.27305\include\cstdio
1>Note: including file:     C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\stdio.h
1>Note: including file:      C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\corecrt_wstdio.h
1>Note: including file:       C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\corecrt_stdio_config.h
1>Note: including file:    C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.20.27305\include\cstring
1>Note: including file:     C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\string.h
1>Note: including file:      C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\corecrt_memory.h
1>Note: including file:       C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\corecrt_memcpy_s.h
1>Note: including file:        C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\errno.h
1>Note: including file:        C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.20.27305\include\vcruntime_string.h
1>Note: including file:      C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\corecrt_wstring.h
1>Note: including file:    C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.20.27305\include\cwchar
1>Note: including file:     C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\wchar.h
1>Note: including file:      C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\corecrt_wconio.h
1>Note: including file:      C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\corecrt_wctype.h
1>Note: including file:      C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\corecrt_wdirect.h
1>Note: including file:      C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\corecrt_wio.h
1>Note: including file:       C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\corecrt_share.h
1>Note: including file:      C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\corecrt_wprocess.h
1>Note: including file:      C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\corecrt_wstdlib.h
1>Note: including file:      C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\corecrt_wtime.h
1>Note: including file:      C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\sys/stat.h
1>Note: including file:       C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\sys/types.h
1>Note: including file:    C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.20.27305\include\xstddef
1>Note: including file:     C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.20.27305\include\cstddef
1>Note: including file:      C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\stddef.h
1>Note: including file:      C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.20.27305\include\xtr1common
1>Note: including file:     C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.20.27305\include\cstdlib
1>Note: including file:      C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\math.h
1>Note: including file:       C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\corecrt_math.h
1>Note: including file:      C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\stdlib.h
1>Note: including file:       C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\corecrt_malloc.h
1>Note: including file:       C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\corecrt_search.h
1>Note: including file:       C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.20.27305\include\limits.h
1>Note: including file:     C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.20.27305\include\initializer_list
1>Note: including file:   C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.20.27305\include\xmemory0
1>Note: including file:    C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.20.27305\include\cstdint
1>Note: including file:     C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.20.27305\include\stdint.h
1>Note: including file:    C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.20.27305\include\limits
1>Note: including file:     C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.20.27305\include\cfloat
1>Note: including file:      C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\float.h
1>Note: including file:     C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.20.27305\include\climits
1>Note: including file:    C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.20.27305\include\new
1>Note: including file:     C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.20.27305\include\exception
1>Note: including file:      C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.20.27305\include\type_traits
1>Note: including file:      C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\malloc.h
1>Note: including file:      C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.20.27305\include\vcruntime_exception.h
1>Note: including file:       C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.20.27305\include\eh.h
1>Note: including file:        C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\corecrt_terminate.h
1>Note: including file:    C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.20.27305\include\xutility
1>Note: including file:     C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.20.27305\include\utility
1>Note: including file:    C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.20.27305\include\xatomic0.h
1>Note: including file:    C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.20.27305\include\intrin0.h
1>Note: including file:   C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.20.27305\include\xpolymorphic_allocator.h
1>Note: including file:    C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.20.27305\include\tuple
1>Note: including file:  C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.20.27305\include\cctype
1>Note: including file:   C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\ctype.h

Hi!
I'll try to get to this when I can, but for now I'd recommend including whatever STL headers are necessary to make things compile.
Thanks for reporting!

Thanks @onqtam , that is indeed the route I have currently picked (just adding extra #include <ostream> in my test files).

But on the top of my head - actually <string> should provide ostream& operator<<(ostream& ... - <iosfwd> has nothing to do with operator<< - only with forward declaring ostream...

basic_ostream<charT, traits>& operator<<(basic_ostream<charT, traits>& os, const basic_string<charT, traits, Allocator>& str);
template<class charT, class traits, class Allocator> basic_istream<charT, traits>& getline(basic_istream<charT, traits>& is, basic_string<charT, traits, Allocator>& str,
charT delim);

as seen here: https://en.cppreference.com/w/cpp/header/string
So I'm a bit clueless as to why this could have happened. But anyway I'll try VS 2019 when I get the chance.

So I managed to play a bit with VS 2019 and turns out this is an STL bug - the user should be able to do the following:
#include <string>
#include <iosfwd>

void foo(std::ostream& s) {
    s << std::string("");
}

But with VS 2019 that is no longer possible. This is valid code since operator<< for std::string uses std::ostream only by reference so we do not need the definition of std::ostream but internals of the <xstring> header (included by <string>) start using parts of std::ostream. I see that they changed from including <istream> and <ostream> to just including <iosfwd> which is not sufficient in this case.
I'll probably file a bug report when I get the chance but there is nothing I'm willing to do on the side of doctest because there are only 2 options: either disable detection for operator<< for std::string (which would need to be forward declared as a type) so your std::string asserts won't print the contents of the string, or doctest has to include a header, which is a clear no (because of compile times).

Thanks @onqtam , checked on the bug report, interesting chain of events and reasoning. fwiw I tend to agree with Billy O'Neal's assessment of the issue. It looks like this will require a change to doctest as it would be very unfortunate if out of the box experience with vs2019 and onward was unfriendly. Thanks again for the great library.

It's the right decision for Visual Studio. I'm really reluctant to adding an include just for this though... So I'll have to think about this - don't expect a resolution soon - sorry :|

No worries at all, I've worked around it for now and have no other issues!

I had the same problem building on macOS 10.14, note that it works in Debug mode, but fails in Release.
A quick look in libc++ files shows that the operator<<(basic_ostream&, std::basic_string) is defined in <ostream>...

I’m using VS2019. The posted solution (manually including  in every test cpp file, tried before and after "doctest.h") fixes some errors, but I still get error lnk2001:
common_factor.test.cpp.1.o : error LNK2001: unresolved external symbol "public: void __cdecl doctest::detail::ResultBuilder::unexpectedExceptionOccurred(void)" (?unexpectedExceptionOccurred@ResultBuilder@detail@doctest@@QEAAXXZ) operations.test.cpp.1.o : error LNK2001: unresolved external symbol "public: void __cdecl doctest::detail::ResultBuilder::unexpectedExceptionOccurred(void)" (?unexpectedExceptionOccurred@ResultBuilder@detail@doctest@@QEAAXXZ) unrepresentable_operation_error.test.cpp.1.o : error LNK2001: unresolved external symbol "public: void __cdecl doctest::detail::ResultBuilder::unexpectedExceptionOccurred(void)" (?unexpectedExceptionOccurred@ResultBuilder@detail@doctest@@QEAAXXZ) Direction.test.cpp.1.o : error LNK2001: unresolved external symbol "public: void __cdecl doctest::detail::ResultBuilder::unexpectedExceptionOccurred(void)" (?unexpectedExceptionOccurred@ResultBuilder@detail@doctest@@QEAAXXZ) FixedRational.test.cpp.1.o : error LNK2001: unresolved external symbol "public: void __cdecl doctest::detail::ResultBuilder::unexpectedExceptionOccurred(void)" (?unexpectedExceptionOccurred@ResultBuilder@detail@doctest@@QEAAXXZ) Matrix.test.cpp.1.o : error LNK2001: unresolved external symbol "public: void __cdecl doctest::detail::ResultBuilder::unexpectedExceptionOccurred(void)" (?unexpectedExceptionOccurred@ResultBuilder@detail@doctest@@QEAAXXZ) Point.test.cpp.1.o : error LNK2001: unresolved external symbol "public: void __cdecl doctest::detail::ResultBuilder::unexpectedExceptionOccurred(void)" (?unexpectedExceptionOccurred@ResultBuilder@detail@doctest@@QEAAXXZ) C:\Users\atimh\code\rational_geometry\bin\rational_geometry_test.exe : fatal error LNK1120: 1 unresolved externals

@atimholt judging by the linker errors I would say the reason is that you have forgotten to implement the test runner using either DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN or DOCTEST_CONFIG_IMPLEMENT - one of these 2 identifiers must be defined in exactly one .cpp file before including the framework header because doctest.h is actually a header file and a .cpp file bundled together in a single header file, and the .cpp part needs to be compiled somewhere - checkout the relevant docs for supplying your own main.

 Didn’t put #include <ostream> in my main test file (tests.cpp), just every other file. Takeaway is, put #include <ostream> in every file that has #include "doctest.h".

@theodelrieu are you sure you had the same problem on OSX? Was it a compiler error or was it a linker error like reported here: https://github.com/onqtam/doctest/issues/126 ...? If your problem is a linker error perhaps you might try the dev branch - I just pushed a fix recently for #126.
You mentioned that the failure is only in Release - that could be precisely the same issue which agurtovoy reported here: https://github.com/onqtam/doctest/issues/126#issuecomment-491919296

I just pushed a fix for this in the dev branch - will release in an official version soon: https://github.com/onqtam/doctest/commit/1fe42c94591dfc299f93c41230b6b2673e4b1bf6

Looks like the same problem indeed.


fix: fill in the required args for Api::Impl

Commit Message: ``
Additional Description:
Risk Level: Low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]

Thanks! Could you please amend the commit message to include a Signed-Off-By field? Otherwise the DCO check is bound to fail.
Also run ./tools/code_format/check_format.py fix to fix formatting errors.

Thanks! Could you please amend the commit message to include a Signed-Off-By field? Otherwise the DCO check is bound to fail.
Also run ./tools/code_format/check_format.py fix to fix formatting errors.

As long as @antoniovicente (or someone) is working on testing tools in CI I'm fine to merge this as is. Thank you!

Yes, I'm looking into it in https://github.com/envoyproxy/envoy/pull/14615
Thanks for the fix!

As long as @antoniovicente (or someone) is working on testing tools in CI I'm fine to merge this as is. Thank you!

Yes, I'm looking into it in https://github.com/envoyproxy/envoy/pull/14615
Thanks for the fix!


!! Version confusion !!

Hey all together!
I am really surprised about the recent wave of commits by @Bin-Ro (formerly known as @Dyingisasnaturalasliving), which changed versions back to Aliengo support.
Make sure to select your version carefully.
Go1 users should at least fall back to the last commit on version 3.8.0, if not even further.

As I have documented here: https://github.com/MAVProxyUser/YushuTechUnitreeGo1/blob/main/SDK.md
Do not use one of these versions of the SDK, because they do NOT support go1: https://github.com/unitreerobotics/unitree_legged_sdk/releases/tag/v3.2 https://github.com/unitreerobotics/unitree_legged_sdk/releases/tag/v3.3 https://github.com/unitreerobotics/unitree_legged_sdk/releases/tag/v3.3.1 https://github.com/unitreerobotics/unitree_legged_sdk/releases/tag/v3.3.2 https://github.com/unitreerobotics/unitree_legged_sdk/releases/tag/3.3.3 https://github.com/unitreerobotics/unitree_legged_sdk/releases/tag/3.3.4 https://github.com/unitreerobotics/unitree_legged_sdk/releases/tag/v3.8.1 https://github.com/unitreerobotics/unitree_legged_sdk/releases/tag/v3.8.2 https://github.com/unitreerobotics/unitree_legged_sdk/releases/tag/v3.8.3 https://github.com/unitreerobotics/unitree_legged_sdk/releases/tag/v3.8.4

Isn't the Go1 branch newer than 3.8.0?

At the time it wasn't
I haven't checked again, if something changed

Hello, the latest version of our Go1 SDK is 3.8.0

But what about 3.8.6?
It states Go1 support
@xyq1223

But what about 3.8.6? It states Go1 support @xyq1223

+1 for this

Sorry for the mistake in the reply just now, the latest version is 3.8.6


Test failure due to log after test completes in UCP integration tests

Context
It's against the rules to use testing.T.Log after the test associated with the testing.T instance has completed. We found a case of this in our automated test runs.
This is a non-deterministic failure and doesn't reproduce all of the time. Since the root cause is "logging after the test has finished" it is definitely timing related.
A quickf ix for this would be to disable the logging since it's only needed to diagnose problems.
A better solution would be to build a wrapper for the test logger that shuts down when the test completes. It's not possible in all circumstances to prevent this kind of problem. We've hit this in a few places in the code when using dependencies we don't control.
Details
From: https://github.com/radius-project/radius/actions/runs/6482555392/job/17602307102?pr=6445
 panic: Log in goroutine after Test_RadiusPlane_ResourceAsync has completed: "ts"="2023-10-11 12:50:12.232183" "level"=0 "msg"="Message loop stopped..."

goroutine 467 [running]:
testing.(*common).logDepth(0xc002348340, {0xc002922c30, 0x4c}, 0x3)
	/opt/hostedtoolcache/go/1.21.1/x64/src/testing/testing.go:1022 +0x674
testing.(*common).log(...)
	/opt/hostedtoolcache/go/1.21.1/x64/src/testing/testing.go:1004
testing.(*common).Log(0xc002348340, {0xc0027b3cf0, 0x1, 0x1})
	/opt/hostedtoolcache/go/1.21.1/x64/src/testing/testing.go:1045 +0x7e
github.com/go-logr/logr/testr.logInfo({0x389cc68, 0xc002348340}, 0xc0023e2cc8, 0x0?, {0x33aa8e2, 0x17}, {0x0, 0x0, 0x0})
	/home/runner/go/pkg/mod/github.com/go-logr/logr@v1.2.4/testr/testr.go:101 +0x197
github.com/go-logr/logr/testr.testloggerInterface.Info({{0x0, {0x3888868, 0x0}, {0x0, 0x0, 0x0}, {0x0, 0x0}, 0x1, 0xc0000db270}, ...}, ...)
	/home/runner/go/pkg/mod/github.com/go-logr/logr@v1.2.4/testr/testr.go:148 +0x106
github.com/go-logr/logr.Logger.Info({{0x38b88c8?, 0xc0022d3b00?}, 0xc00020aaf0?}, {0x33aa8e2, 0x17}, {0x0, 0x0, 0x0})
	/home/runner/go/pkg/mod/github.com/go-logr/logr@v1.2.4/logr.go:278 +0xe4
github.com/radius-project/radius/pkg/armrpc/asyncoperation/worker.(*AsyncRequestProcessWorker).Start(0xc0022d3b60, {0x38b4730?, 0xc00020aaf0})
	/home/runner/work/radius/radius/pkg/armrpc/asyncoperation/worker/worker.go:214 +0x49f
github.com/radius-project/radius/pkg/ucp/integrationtests/testrp.AsyncResource.func3()
	/home/runner/work/radius/radius/pkg/ucp/integrationtests/testrp/async.go:86 +0x5d
created by github.com/radius-project/radius/pkg/ucp/integrationtests/testrp.AsyncResource in goroutine 376
	/home/runner/work/radius/radius/pkg/ucp/integrationtests/testrp/async.go:85 +0xfd0
FAIL	github.com/radius-project/radius/pkg/ucp/integrationtests/radius	3.567s

AB#9698

Happened again: https://github.com/radius-project/radius/actions/runs/10221277475/job/28283443714?pr=7781. I have been running into this a few times for the last few days.


add a section about the compiler team

Fixes #25

Thanks! If you have time, could you also add some of the other items you mention in #25? Then we could close that issue.

Thanks!


PLT-7204 Part 2: Dynamic query

[x] Adds new library hasql-dynamic-syntax for AST-based dynamic query generation
[x] Adds schema types and tables for marlowe schema.
[x] Rewrites getPayouts to use hasql-dynamic-syntax

Pre-submit checklist:

Branch

[x] Tests are provided (if possible)
[ ] Test report is updated (if relevant)
[x] Commit sequence broadly makes sense
[x] Key commits have useful messages
[ ] Relevant tickets are mentioned in commit messages
[x] Formatting, PNG optimization, etc. are updated

PR

[x] Self-reviewed the diff
[x] Useful pull request description

Review required
[x] Substantial changes to code, test, or documentation
[ ] Change made to Marlowe validator (@bwbush and @palas must be included as reviewers)
Review not required
[ ] Minor changes to non-critical code, documentation, nix derivations, configuration files, or scripts
[ ] Formatting, spelling, grammar, or reorganization

[x] Reviewer requested

This looks good, but there was too much code in the new package for me to review in great detail and there are no tests in the new package's test suite yet.
Yeah, I didn't think the new code was particularly high-risk for correctness because it was largely copied-and-pasted from existing high-assurance code (and the types are pretty good here at eliminating errors). At some point, I will write tests for these, for now it's implicitly tested by the integration tests.
How were the golden tests generated and checked for correctness? Are they just to detect regressions?
These are generated in GetPayoutsSpec.hs. Correctness is less the goal as change detection and accurate documentation off what SQL is generated by the code under various configurations. The correctness is checked by the integration tests.
Finally, can we add a changelog entry to runtime for this. Are there no API or breaking changes?
No changelog needed - it's an internal change


Cmmeyer fix/551 lambda layers patch

Issue #, if available:
#551
Description of changes:
Temporary patch for Lambda layers resources until spec is updated.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Codecov Report

Merging #553 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #553   +/-   ##
=======================================
  Coverage   84.23%   84.23%
=======================================
  Files         109      109
  Lines        5937     5937
  Branches     1349     1349
=======================================
  Hits         5001     5001
  Misses        619      619
  Partials      317      317

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2e10f7...e2c55c8. Read the comment docs.


ENH Refactor Element and graphql hoc

Issue https://github.com/silverstripe/silverstripe-elemental/issues/1164
Notes:

I haven't implemented the AC "(refactor) Triggering actions on state change" - I've made a comment about it https://github.com/silverstripe/silverstripe-elemental/issues/1164#issuecomment-2068481613 - I don't intend to implement it though if someone is able to demonstrate a non-convoluted way to implement an alternative I'm happy to refactor
I haven't implemented the AC "Passing down callbacks in context (note that context is required to pass props to the buttons because they're added via js injector in registerTransforms.js)" - I've made a comment about it https://github.com/silverstripe/silverstripe-elemental/issues/1164#issuecomment-2068381327. I do not intend to implement this AC
I haven't implmented the AC "Use of setTimeout in Element.js" as things don't work when setTimeout is removed, presumably due to timing issues. I have made it to the original timeout happens inside a .then() block so it always happens after the HTTP request has returned.
I haven't implemented the AC "Moving context to its own file ... or remove the need for context." as I was asked to revert it in this comment in peer review
I've removed some jest tests on SaveAction-test.js and PublishAction-test.js as there is simply now less logic and props passed via context in SaveAction and PublishAction. I choose not to add in equivalent tests in Element-test.js adding in "child Actions" would require doing stuff with injector to replicate what registerTransforms.js does now, and also because these functionality is already covered by behat tests in edit-block-element.feature (save button) and publish-block-element.feature (publish button)
I've commented out a failing behat test and raised a follow card to address https://github.com/silverstripe/silverstripe-elemental/issues/1177. It's a very weird and convoluted issue which I spent a great deal of time on though was ultimately unable to resolve

Seems to work fine in the browser as-is so we're just dealing with code quality at this point. If the refetch queries change I've suggested above doesn't remove the timeout, it may not be worth doing.


error with file train_fcn8s. I am getting following error: subprocess.CalledProcessError: Command '['git', 'log', '-n', '1', '--pretty=%h']' returned non-zero exit status 128.

Please install git in that case.

Please install git in that case.

My system has installed git with 'git version 2.7.4', but I also met this error: "subprocess.CalledProcessError: Command '['git', 'log', '-n', '1', '--pretty=%h']' returned non-zero exit status 128."

Maybe you downloaded the tar ball version of this repo? Instead of git
clone?
On Wed, Jul 3, 2019 at 3:13 BarryBA<EMAIL_ADDRESS>wrote:

Please install git in that case.
My system has installed git with 'git version 2.7.4', but I also met this
error: "subprocess.CalledProcessError: Command '['git', 'log', '-n', '1',
'--pretty=%h']' returned non-zero exit status 128."
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/wkentaro/pytorch-fcn/issues/108?email_source=notifications&email_token=ABA4LE76ZHFTWANXDDJSPU3P5QDN7A5CNFSM4G5GXHT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZDBSBQ#issuecomment-507910406,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABA4LE72N3CPWXDMC6JNEGLP5QDN7ANCNFSM4G5GXHTQ
.

--
Kentaro Wada / 和田 健太郎
https://wkentaro.com http://wkentaro.com

Maybe you downloaded the tar ball version of this repo? Instead of git clone?
On Wed, Jul 3, 2019 at 3:13 BarryBA @.***> wrote: Please install git in that case. My system has installed git with 'git version 2.7.4', but I also met this error: "subprocess.CalledProcessError: Command '['git', 'log', '-n', '1', '--pretty=%h']' returned non-zero exit status 128." — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#108?email_source=notifications&email_token=ABA4LE76ZHFTWANXDDJSPU3P5QDN7A5CNFSM4G5GXHT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZDBSBQ#issuecomment-507910406>, or mute the thread https://github.com/notifications/unsubscribe-auth/ABA4LE72N3CPWXDMC6JNEGLP5QDN7ANCNFSM4G5GXHTQ .
-- Kentaro Wada / 和田 健太郎 https://wkentaro.com http://wkentaro.com

Yeah. Just as you say. I downloaded the tarball version of the repo.

Please clone this repo via git.
On Wed, Jul 3, 2019 at 11:18 BarryBA<EMAIL_ADDRESS>wrote:

Maybe you downloaded the tar ball version of this repo? Instead of git
clone?
On Wed, Jul 3, 2019 at 3:13 BarryBA @.***> wrote: Please install git in
that case. My system has installed git with 'git version 2.7.4', but I also
met this error: "subprocess.CalledProcessError: Command '['git', 'log',
'-n', '1', '--pretty=%h']' returned non-zero exit status 128." — You are
receiving this because you modified the open/close state. Reply to this
email directly, view it on GitHub <#108
https://github.com/wkentaro/pytorch-fcn/issues/108?email_source=notifications&email_token=ABA4LE76ZHFTWANXDDJSPU3P5QDN7A5CNFSM4G5GXHT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZDBSBQ#issuecomment-507910406>,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABA4LE72N3CPWXDMC6JNEGLP5QDN7ANCNFSM4G5GXHTQ
.
-- Kentaro Wada / 和田 健太郎 https://wkentaro.com http://wkentaro.com
Yeah. Just as you say. I downloaded the tarball version of the repo.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/wkentaro/pytorch-fcn/issues/108?email_source=notifications&email_token=ABA4LEY7OIJEJUKMQNLFNV3P5R4HBA5CNFSM4G5GXHT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZD7Y6Y#issuecomment-508034171,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABA4LE2HJ2ITESAYVLMPCRDP5R4HBANCNFSM4G5GXHTQ
.

--
Kentaro Wada / 和田 健太郎
https://wkentaro.com http://wkentaro.com

Please clone this repo via git.
On Wed, Jul 3, 2019 at 11:18 BarryBA @.> wrote: Maybe you downloaded the tar ball version of this repo? Instead of git clone? On Wed, Jul 3, 2019 at 3:13 BarryBA @.> wrote: Please install git in that case. My system has installed git with 'git version 2.7.4', but I also met this error: "subprocess.CalledProcessError: Command '['git', 'log', '-n', '1', '--pretty=%h']' returned non-zero exit status 128." — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#108 <#108>?email_source=notifications&email_token=ABA4LE76ZHFTWANXDDJSPU3P5QDN7A5CNFSM4G5GXHT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZDBSBQ#issuecomment-507910406>, or mute the thread https://github.com/notifications/unsubscribe-auth/ABA4LE72N3CPWXDMC6JNEGLP5QDN7ANCNFSM4G5GXHTQ . -- Kentaro Wada / 和田 健太郎 https://wkentaro.com http://wkentaro.com Yeah. Just as you say. I downloaded the tarball version of the repo. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#108?email_source=notifications&email_token=ABA4LEY7OIJEJUKMQNLFNV3P5R4HBA5CNFSM4G5GXHT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZD7Y6Y#issuecomment-508034171>, or mute the thread https://github.com/notifications/unsubscribe-auth/ABA4LE2HJ2ITESAYVLMPCRDP5R4HBANCNFSM4G5GXHTQ .
-- Kentaro Wada / 和田 健太郎 https://wkentaro.com http://wkentaro.com

Ok, thanks for your relpy.


HAWKULAR-454 - Accounts 1.0.12.Final and required changes

@ppalaga , I had problems with src-deps, but I wanted to send this PR anyway, to see if it looks good to you.
@mtho11 , could you also check if this PR fixes the login issue?

Wow, the build time really went up.

Issues: http://fpaste.org/265243/44181201/
and this:
WebSocket connection to 'ws://localhost:8080/hawkular/feed-comm/ui/ws' failed: Error during WebSocket handshake: Unexpected response code: 404

About the build time: it seems that the current master has taken 17 minutes already. So, it's not a problem in this PR.

PR updated with changes to the versions of Agent, Bus and Command Gateway.
@jmazzitelli , could you please check this as well, specially to verify that I haven't missed any component update?

This looks good.

lgtm


Add a check for operator scope

What this PR does / why we need it:
This PR prevent users request private operator from the out of namespace of operandRegistry.
Hold it unit we get the list of public and private operators
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #337
Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

NONE

/retest


Pinned requirements versions.

Current Behavior
Is it really necessary to have the package versions so specific?
fluent-logger==0.9.6
msgpack
python_dotenv==0.10.1
PyYAML==5.3.1

Desired Behavior
Relax the issues as much as possible so logging still works and does not limit other modules to such a specific versions.

for some reason fluentd asked for pinned requirements, but i don't think there is any good reason for it.


Error reading bibliography on Windows

I am using pandoc with the Manubot project and encountered a pandoc-citeproc issue that appears to be Windows-specific.  I am executing a simplified version of the pandoc call in the Manubot build script.  My simplified version is:
pandoc --bibliography=output/references.json --output=output/manuscript.html output/manuscript.md

This generates the error:
Error reading bibliography .\output/references.json Error in $: Failed reading: Cannot decode input: Data.Text.Internal.Encoding.decodeUtf8: Invalid UTF-8 stream
Error running filter pandoc-citeproc:
Filter returned error status 1

I am running this in Git bash on Windows 10.  It appears that the prefix .\ is prepended to my bibliography filename, and the resulting file .\output/references.json does not exist.
Version info:
$ pandoc --version
pandoc.exe 2.3.1
Compiled with pandoc-types <IP_ADDRESS>, texmath <IP_ADDRESS>, skylighting 0.7.3
$ pandoc-citeproc --version
pandoc-citeproc 0.14.5

The error message suggests that your references.json file is
not properly UTF-8 encoded.
You can probably fix it in a decent text editor, or
you can use iconv as suggested in the pandoc manual.


Feature: set active SelenideDriver

Create method for setting currenly active SelenideDriver with it's own SelenideConfig
The problem
If user wants to open two browsers in test, he need to point browser explicitly.
For example (https://selenide.org/2018/10/10/selenide-5.0.0/):
SelenideDriver browser1 = new SelenideDriver();
SelenideDriver browser2 = new SelenideDriver();

browser1.open("https://google.com");
browser2.open("http://yandex.ru");

browser1.$(h1).shouldHave(text("Google"));
browser2.$(h1).shouldHave(text("Yandeks"));

Solution can might look like this:
    SelenideConfig browserConfig1 = new SelenideConfig()
      .baseUrl("http://google.ru");
    SelenideDriver selenideDriver1 = new SelenideDriver(browserConfig1);
    WebDriverRunner.setActiveSelenideDriver(selenideDriver1);
    Selenide.open("/signin");
    assertThat(selenideDriver1.url()).isEqualTo("http://google.ru/signin");

    SelenideConfig browserConfig2 = new SelenideConfig()
      .baseUrl("http://ya.ru");
    SelenideDriver selenideDriver2 = new SelenideDriver(browserConfig2);
    WebDriverRunner.setActiveSelenideDriver(selenideDriver2);
    Selenide.open("/signin");
    assertThat(selenideDriver2.url()).isEqualTo("http://ya.ru/signin");

@sanchek While I may be mistaken, it seems to me an over-complication.
If you really need to use different SelenideDriver instances in tests, why not just instantiate them and store into test field? It's much more simple and predictable than playing with static methods.
public class MyJUnitTest {
  private SelenideDriver web = new SelenideDriver();

  @Test
  public void someTest() {
    web.open("https://google.com");
    web.$(h1).shouldHave(text("Google"));
  }

To me changeing currect active driver looks like more simple and reusable solution.
First of all, you can use and adopt any previously written testcases without any meaningful modifiactions.
Second, whithout changing webdriver you wont be able to use PageObject pattern without calling webdriver instance, and also PageObject classes should me modified.
Example:

Yes, but it's a bad idea to open a web page in a constructor. What if you rewrite your page object a little, so that you don't need to pass SelenideDriver to it?
Something like
class LoginPage() {
  private val profileHeader = $(...);
  private val signInPhoneField = $(...);
}

class MyTest {
  private SelenideDriver web = new SelenideDriver(new SelenideConfig().browserSize("1024x768").baseUrl("http://ya.ru"));

  @Test
  public void someTest() {
    val page = web.open("https://google.com", LoginPage::class.java);
    page.profileHeader.shouldHave(text("Google"));
  }
}

In this case I've got error: No webdriver is bound to current thread: 17. You need to call open(url) first.
I suppose it's because of SelenideElement (profileHeader) inside PageObject should be found via $ be the same webdriver that opened this page.

@sanchek Yes, and we have issue for that: https://github.com/selenide/selenide/issues/1048 :)
Unfortunately, it's a bit hard to fix that issue by the moment...
Another option would be to declare page object fields with FindBy annotation:
class LoginPage() {
  @FindBy(id="...")
  private val profileHeader;

  @FindBy(xpath="...")
  private val signInPhoneField = $(...);
}

@sanchek One option that I am thinking about is adding method WebDriverRunner.setSelenideConfig().
It solves your problem, but doesn't introduce complexity with SelenideDrivers.

I don't understand how this method should be implemented and used.
Does the user need to recreate the driver after setting the config?

Using this method, we could rewrite your initial code sample this way:
  SelenideConfig browserConfig1 = new SelenideConfig().baseUrl("http://google.ru");
    WebDriverRunner.setSelenideConfig(browserConfig1);
    Selenide.open("/signin");
    assertThat(selenideDriver1.url()).isEqualTo("http://google.ru/signin");

    SelenideConfig browserConfig2 = new SelenideConfig().baseUrl("http://ya.ru");
    WebDriverRunner.setSelenideConfig(browserConfig2);
    Selenide.open("/signin");
    assertThat(selenideDriver2.url()).isEqualTo("http://ya.ru/signin");

As you see, we just eliminated selenideDriver1 and selenideDriver2. Everything else is the same.

It looks quite clear, but I'm afraid that just changing the config will change the behaviour of first opened page (timeout and etc.)

@sanchek Now you see how complex it is. :)
There is hundred of such nuances: "what if..", "in which order...", "what could be affected...".
The idea is that SelenideConfig will be hold in ThreadLocal. After calling WebDriverRunner.setSelenideConfig, it will applied only to current thread.

After discussion we realized that users need only to set Config, not the whole SelenideDriver. Superseded by https://github.com/selenide/selenide/issues/1372.


Add Aron Gassilewski to Contributors list

Add Aron Gassilewski to Contributors list.
Thanks for the helpful tutorial!

Hi  @Argasz, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added social share  to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.


Expose RemixRestClient and GraphQLClient types for @shopify/shopify-app-remix

Overview/summary
I want to pass my admin rest or graphql api client in a seperate server file in remix js. But the types are not exposed.
export const loader = async ({ request }: LoaderFunctionArgs) => {
  const { session, admin } = await authenticate.admin(request);

  const themes = await getThemes(session, admin.rest);

  return json({ themes });
};

I want to do something like this in another file but I do not see any export from the library for RestClient or GraphqlClients
export async function getThemes(session: Session, rest: RemixRestClient) {

   const themes = await rest.resources.Theme.all({ session: session });

  return themes;
}

Note
If this is a generic type which is generated when running  shopifyApp({..}) It will be also great if this can be accessed through the returned object so I can reexport from the shopify.server.ts file

Hi @matteodepalo Because module resolution is not node in the remix app, I'm not able to import types for shopify resources as well from the api. I cannot get the Theme, Product, Etc type from this package as well.
export async function getJobs(shopName: string, themes: Theme) {
  ...
}

I managed to extract the types from the shopify.server.ts file like so. Using it in our custom starter:
/* Getting types */
export type AdminMain = Awaited<ReturnType<typeof authenticate.admin>>;

export type AdminApiContext = AdminMain["admin"];
export type AdminApiSession = AdminMain["session"];

export type AdminGraphqlClient = AdminApiContext["graphql"];
export type AdminRestClient = AdminApiContext["rest"];

I had a similar issue with accessing "AdminApiContext" and importing it via @shopify/shopify-app-remix/server fixed it for me.


Hemihydranencephaly

Label
Hemihydranencephaly
Synonyms
Hemi-hydranencephaly
Synonym type
exact
Definition
Hemi-hydranencephaly is a very rare condition characterized by complete or almost near-complete unilateral absence of the cortical cortex, which is filled by a sac of cerebrospinal fluid.  The presumed cause is a prenatal vascular disruption with occlusion of the carotid artery territories ipsilateral to the damaged brain. It is a form of hydranencephaly.
Parent term
Hydranencephaly
Children term(s)
No response
ORCID Identifier
No response
Website URL
https://pmc.ncbi.nlm.nih.gov/articles/PMC3564735/
Additional comments
We had an inquiry from a patient affected with this condition.  Note that this is a form of hydranencephaly which is listed already in MONDO (we have a NORD report).  The main difference with the hydranencephaly is the better outcome for  Hemi-hydranencephaly.   Please consider it for inclusion (note that it is not listed in Orphanet but hydranencephaly is);  if decided not to list it I will update the NORD report and comment about the different forms. Thank you, Gioconda Alyea

[like]  Gioconda Alyea reacted to your message:

From: Yousif @.>
Sent: Wednesday, November 13, 2024 10:18:06 PM
To: monarch-initiative/mondo @.>
Cc: Gioconda Alyea @.>; Author @.>
Subject: Re: [monarch-initiative/mondo] Hemihydranencephaly (Issue #8311)
We have added the new term hemi-hydraencephaly in #8367https://github.com/monarch-initiative/mondo/pull/8367. Thank you!
—
Reply to this email directly, view it on GitHubhttps://github.com/monarch-initiative/mondo/issues/8311#issuecomment-2474937128, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A4QAWD6WCNSGWRGYXZONLST2APFZ5AVCNFSM6AAAAABRJ4I6S2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZUHEZTOMJSHA.
You are receiving this because you authored the thread.Message ID: @.***>
Any review, use, distribution or disclosure by others is strictly prohibited.


USHIFT-335: fix mDNS server tests

Limit the tests to IPv4 lookups only. Restructure the code so each address
lookup is its own subtest. Simplify the actual test using the assert
package to verify that the expected address appears in the list of
responses.

I've updated the ticket for this to suggest creating an e2e test instead of trying to make the unit tests work. There are too many system dependencies for this to be a reliable unit test.
/close


CLI export compatiblity with napari tracks reader plugin

ultrack export zarr-napari  not natively compatible with napari tracks reader plugin
CSV header has to be in name TrackID, t, x, y, z. Note that the header order does not matter. Currently need to manually modify the output file. Perhaps adding an option to fit the header name.
Or should I change to use TrackMate output?

Hi @jackyko1991,
Ultrack should come with its own napari reader plugin.
It's very similar to the plugin you linked, but it also loads other columns and the division relationship.
Is the ultrack reader plugin not available for you?
Could you try checking if there were any errors by going to the Plugins ... > Plugins Errors in the menu bar?

Hi Jordao,
Do you mean I need to use napari comes with ultrack but not the native one? Would the plugins be available to install separately?
Jacky

From: Jordão Bragantini @.>
Sent: Wednesday, January 3, 2024 10:16 PM
To: royerlab/ultrack @.>
Cc: Ka Ko @.>; Mention @.>
Subject: Re: [royerlab/ultrack] CLI export compatiblity with napari tracks reader plugin (Issue #58)
Hi @jackyko1991https://github.com/jackyko1991,
Ultrack should come with its own napari reader plugin.
It's very similar to the plugin you linked, but it also loads other columns and the division relationship.
Is the ultrack reader plugin not available for you?
Could you try checking if there were any errors by going to the Plugins ... > Plugins Errors in the menu bar?
—
Reply to this email directly, view it on GitHubhttps://github.com/royerlab/ultrack/issues/58#issuecomment-1876042303, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AC4BUB7PUO4YTPLP76TLGTDYMXKEDAVCNFSM6AAAAABBL2RSYOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZWGA2DEMZQGM.
You are receiving this because you were mentioned.Message ID: @.***>

The ultrack .csv reader comes with the ultrack python package.
They're implemented here and here and it should be enabled by default.
Would it be better to have it as a separate plugin? I can see how ultrack has several dependencies, and it might not be the most straightforward package to install.

I am working on Napari on a machine with native Napari only.
IMO I don't think a separate plugin is necessary. I may check with the author of napari tracks reader plugin to add the function to load custom header names.

recently, we update so ultrack provides its own napari-reader plugin


Honor ignoreFiles in the FS watcher

I have been using blogdown and whenever temporary files are generated or Rmd files are updated Hugo will rebuild numerous times (and ping the browser to live-reload) so I added functionality to filter out files matching any of the ignoreFiles regexes from the list of content files to determine if a rebuild should occur.
It felt like assets shouldn't have a filter applied (though maybe they should and this filter should apply to both types... easy enough to change) so it only applies to content in the partitioned list; if this should be updated to filter both types let me know.
Sorry the diff is a bit visually jarring -- it wraps a large chunk of the newWatcher method...
Addresses #3811

The AppVeyor build fail looks not related to the PR changes. @johnewart could you try to force a rebuild? IMO rebasing your branch over current master and push -f should do the job and make sure it's up to date.
I wait for this change to be merged :-)

Would be great if this could be merged (having the issues as mentioned in #3811)


Metrics disabled

What happened:
We would like to avoid sending metrics data to the splunk.
I have configured:
splunk-kubernetes-metrics:
enabled: false
but metrics configuration was deployed:
NAME                                                  DESIRED   CURRENT   READY   UP-TO-DATE   AVAILABLE   NODE SELECTOR                 AGE
daemonset.apps/my-release-splunk-kubernetes-logging   5         5         5       5            5           beta.kubernetes.io/os=linux   9m50s
daemonset.apps/my-release-splunk-kubernetes-metrics   5         5         5       5            5           beta.kubernetes.io/os=linux   9m50s
NAME                                                       READY   UP-TO-DATE   AVAILABLE   AGE
deployment.apps/my-release-splunk-kubernetes-metrics-agg   1/1     1            1           9m50s
deployment.apps/my-release-splunk-kubernetes-objects       1/1     1            1           9m50s
NAME                                                                  DESIRED   CURRENT   READY   AGE
replicaset.apps/my-release-splunk-kubernetes-metrics-agg-6f6494d6cf   1         1         1       9m50s
replicaset.apps/my-release-splunk-kubernetes-objects-588948c4f        1         1         1       9m50s
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

Kubernetes version (use kubectl version):1.18 client ; 1.16 server
Ruby version (use ruby --version):
OS (e.g: cat /etc/os-release):
Splunk version:
Others:

please share the full values.yaml and commands used to deploy.
Likely just an issue with the config of the values.yaml


add case study for unionbigdata in English

What type of PR is this?
/kind documentation
What does this PR do / why do we need it:
This PR adds an English case study titled "UnionBigData's Utilization of Karmada in the Construction of I3Plat at BOE."
Which issue(s) does this PR fix:
Fixes #none
Special notes for your reviewer:
The first two pictures of the architecture have been redrawn in both English and Chinese. The last five pictures remain unchanged. May readers understand them by referring to the context.
I have generated and reviewed the English translation myself. I believe it is understandable, and the terms are correct.

I noticed the DCO problems, I'll fix it right now with new signed-off-by line.


works great!

Hello, leaving you this comment:
This script is working like a charm! Thank you

Glad to hear it! No worries, and happy to help 😀


Fix user key creation.

With ansible-playbook <IP_ADDRESS>, user key creation fails because ansible interprets the with_items key as a string instead of a jinja variable. This pull request fixes that issue.
Please be aware that I'm not confident that this is backwards-compatible with older versions of ansible-playbook. Can someone confirm or deny this?
UPDATE:
Running grep -r 'with_items: [^"]' on the source tree reveals that this is a common issue. I'd fix this if desired.

I just saw that this duplicates #1068, so please ignore.


Is the 'top' span required?

Do we really need to tell user that this button will take you to the top of the screen?

remove it! please


Error if I type # 3 times in the editor

Steps to Reproduce
I am trying to create a level 3 title, so I type # 3 times in the editor area
I see the following error:

<missing conversion parameter: amount, source unit, destination unit>

Technical details:

Version: 0.11.9
Node Version:
Browser/OS: Safari Version 10.1 (126<IP_ADDRESS>.34)
Database: MySQL 5.6.34

Hey @lunarbase, I'm sorry but I've been unable to replicate this at all and there's not enough information here to move forwards.
I'm going to close this issue for now because the error message you're seeing isn't generated by Ghost or any of it's dependencies which suggests it's something specific to your setup. If you can provide more information or can show this is an issue in Ghost rather than with your setup we can re-open. Additional information would be things like:

details of where are you seeing the error (screenshots are most useful)
details of any errors seen in the web inspector console (right click, choose "Inspect", click the "Console" tab)
details of any failing network requests or the responses from save requests (can be seen in the "Network" tab of web inspector

You've also mentioned on Slack that you are using Softaculous which is a setup we don't recommend nor support, seeing as you are also having other issues with API requests I would start by contacting<EMAIL_ADDRESS>


Allow linking to specific parts of documentation from navigation

In my current documentation I have a bunch of code examples inlined with the conceptual parts. It would be useful if it was possible to add links to the navigation so that they link to these inlined examples. In terms of configuration I mean something like this:
{
  path: 'examples/table-header-example',
  title: 'Table Header Example',
  link: 'table/header#example'
},

So instead of generating an entire page, it would generate a link to another, ideally with an anchor.

This will finally soon be released in v2.5. You can test it in catalog@next. Please let me know if you encounter any bugs!


fix: add default SqlReadJournal static method

Changes
In the PersistenceQuery, in the GetDefaultConfig the framework relies on the fact that in the SqlReadJournal there is a public static method called "GetDefaultConfig". However, this is not the case int this implementation of the class and the ReadJournalFor will fail without that.

This is not quite the solution for the problem.


Changing position of  from top to bottom

Hi,
I´m trying to change position of "" element from the top to bottom under "MultiFile-list".
Do you have an idea, how to do it?
Thanks for every advices.

It's not possible to do this with the current version of the plugin. But what you want can easily be achieved by changing "append" to "prepend" on this line:
https://github.com/fyneworks/multifile/blob/master/jquery.MultiFile.js#L205
Option 1:
We could add an option to toggle that command between append and prepend. eg.:
$(...).MultiFile({
prepend: true //  tell the plugin to put the list *before* the element
})

Then we can change line 205 to MultiFile.wrapper[ options.prepend?'prepend':'append' ]
OR
Option 2:
Instead of assuming the list goes within the plugin wrapper we could create a new option for the list's target element and put the list wherever that may be. eg.:
<div id="my-container"/><!-- the list will be placed inside this div -->
<input type="file" class="multi"/>

<script>
$(...).MultiFile({
listContainer: '#my-container' // tell the plugin where to put the list
})
</script>

Then we can change line 205 to $( options.listContainer || MultiFile.wrapper).append
Make sense?
I would argue Option 2 is best as it provides the most flexibility. But maybe we should just do both.

Thanks, great, I used option 2 and it works perfectly.
Thanks again


CIP-0381 | Adjust preamble and structure w.r.t CIP-0001

Fixes #718.
@michaelpj @iquerejeta I had thought this CIP was well on the way to Active by now but so far nobody has suggested this to the CIP repository.  It seemed like costing and other prerequisites were proceeding as per expectations in CIP35.

Did that ever follow through into a release in Plutus, and if so should we merge this current update as Active?
In any case: does the Path to Active here accurately, and in enough detail, suggest whatever official steps that have been taken & whatever might remain to be done?

(updated proposal)

It's going to be in Conway. Ideally it would have a more worked-out path to active, and we could tick some of the boxes as we go, but :shrug:


account support

Hello,
is it possible to add account support for speedtest.net?
Would be awesome to collect and archive the download statistics.
Or is there any other possible solution for this?
kind regards

This has been attempted several times.  The functionality has been fragile and hasn't worked for any extended period of time.  As such, I recommend using some other tracking technique, such as using the --csv or --json outputs, and tracking yourself.


Where is the basic Quick Start / Documentation on using this?

Hi,
I was wondering where the basic Quick Start / Documentation on using this Library is.
Especially for something as complex as a crawler, it would be immensely helpful to include a quick start wiki page and some sample code showcasing common usage scenarios.
This will also help increase usage of your library.
Thank you!
-Shiva

Yeah. Can't use this without it.

I don't know if it is still applicable, but here is a link to the old Getting Started page on CodePlex: https://ncrawler.codeplex.com/wikipage?title=Getting Started


Commands: Show :makemore: for test262 whenever tests get added :^)

LGTM! We should probably wait for @linusg as he's probably the number one user of this API.


feature/cplp 830 put app detail

Fix Provided for Error Reported by Julia. RemoveRange Function has some issue. It throw the exception as below. Instead of RemoveRange calling  Remove method which work
Exception thrown: 'System.InvalidOperationException' in Microsoft.EntityFrameworkCore.dll: 'The entity type 'SelectEnumerableIterator<ValueTuple<string, string, string>, OfferDescription>' was not found. Ensure that the entity type has been added to the model.'

I checked the sources of Select and RemoveRange ( https://source.dot.net/#System.Linq/System/Linq/Select.cs + https://github.com/dotnet/efcore/blob/release/6.0/src/EFCore/DbContext.cs ). RemoveRange is overloaded and it seems the compiler binds to RemoveRange(params: object[]) instead of RemoveRange(IEnumerable). From my understanding there is nothing wrong in our code, Microsoft should have defined it using generigs as RemoveRange(IEnumerable) to resolve the ambiguity.

public void RemoveRange(IEnumerable entities) where TEntity : class
=> _dbContext.RemoveRange(entities);
This one has worked. I have committed the changes


Persist max trace length in ExecutionTrace

After a programs execution trace has been generated it is padded to the next power of two.  In doing so we lose the length of the unpadded trace. We should consider persisting the max_len as part of the ExecutionTrace.
https://github.com/0xPolygonMiden/miden-vm/blob/3022d257eec9cdeca2273b0b66b633bcb3552274/processor/src/trace/mod.rs#L286

Alternatively we could introduce a TraceInfo struct that holds this information and make that a field in the ExecutionTrace struct.
pub struct TraceInfo {
     main_trace_len: usize,
     range_table_len: usize,
     hasher_chiplet_len: usize,
     ...
     padded_len: usize
}

Yes, this would be great to add. I like the approach with a more detailed TraceInfo struct.

Closed by #1029.


enhancement - plug in elmo into word embeddings

https://github.com/deepmipt/DeepPavlov/pull/292

https://github.com/johndpope/elmo_experiments/blob/master/elmo_experiment/notebooks/elmo_text_classification_on_imdb.ipynb


Add Ref verification to aggregate report pipeline

Add Repository Resource Ref verification to aggregate reports pipeline.

/azp run python - aggregate-reports

/azp run python - aggregate-reports

/azp run python - core - ci

/azp run python - aggregate-reports


[Frontend] Multiple conversations/projects in the UI

What problem or use case are you trying to solve?
When running with UI, you can have only one conversation. It's perfectly normal to want more than one, each with a name, so that the user can go back to an older one with a click. As I think we all know, LLM and LLM-based apps have "threads" or similar, it's just such a widespread and handy feature.
Describe the UX of the solution you'd like
I'm not sure of the details here, we just need a list of named conversations, so you can switch back to another. Of course, when you switch, it would load the history of that conversation.
Do you have thoughts on the technical implementation?
In the backend, something like this is implemented, albeit in a basic way: one can run main.py with --name session_name and it loads that session.
We may need to understand and implement a bit more, for this to go smoothly:

in particular, we may want to not reload the runtime, just the controller and event stream
the runtime does have an eventstream instance IIRC; that means we'd need some way to replace it / set to another

Additional context
UI sessions have a non-descript hash as session name, which as far I recall is "forgotten" once you change the session. It should be possible to store it and restore it. The backend doesn't care (once auth passes), it will load an older session.

Also related:
https://github.com/All-Hands-AI/OpenHands/issues/5211

Multiple sessions is currently in progress.


Rubra RedDog error

Hello, I am running RedDog and I am getting the error that is detailed below. I reported this problem in RedDog GitHub and they suggested that it could be a problem with Rubra and server permissions. I am running the pipeline on a torque/qsub system.  Could you help me? Thanks in advance!
Starting pipeline...
155 jobs to be executed in total
Traceback (most recent call last):
File "/usr/local/bin/rubra", line 11, in
load_entry_point('Rubra==0.1.5', 'console_scripts', 'rubra')()
File "build/bdist.linux-x86_64/egg/rubra/rubra.py", line 66, in main
File "build/bdist.linux-x86_64/egg/ruffus/task.py", line 2680, in pipeline_run
ruffus.ruffus_exceptions.RethrownJobError:
Exceptions running jobs for

'def RedDog.makeDir(...):'

Original exception:

Exception #1
exceptions.Exception(qsub command failed with exit status: 172):
for RedDog.makeDir.Job = [False -> dir.makeDir.Success]

Traceback (most recent call last):
  File "build/bdist.linux-x86_64/egg/ruffus/task.py", line 517, in run_pooled_job_without_exceptions
    return_value =  job_wrapper(param, user_defined_work_func, register_cleanup, touch_files_only)
  File "build/bdist.linux-x86_64/egg/ruffus/task.py", line 447, in job_wrapper_io_files
    ret_val = user_defined_work_func(*param)
  File "RedDog.py", line 955, in makeDir
    runStageCheck('makeDir', flagFile, outPrefix, full_sequence_list_string)
  File "build/bdist.linux-x86_64/egg/rubra/utils.py", line 128, in runStageCheck
    status = runStage(stage, *args)
  File "build/bdist.linux-x86_64/egg/rubra/utils.py", line 144, in runStage
    exitStatus = distributedCommand(stage, commandStr, pipeline_options)
  File "build/bdist.linux-x86_64/egg/rubra/utils.py", line 122, in distributedCommand
    return script.runJobAndWait(stage, logDir, verbosity)
  File "build/bdist.linux-x86_64/egg/rubra/cluster_job.py", line 65, in runJobAndWait
    jobID = self.launch()
  File "build/bdist.linux-x86_64/egg/rubra/cluster_job.py", line 138, in launch
    str(returnCode)))
Exception: qsub command failed with exit status: 172

Hello again, I have ran RedDog using root user and now the error is the following
Starting pipeline...
155 jobs to be executed in total
Traceback (most recent call last):
File "/usr/local/bin/rubra", line 11, in
load_entry_point('Rubra==0.1.5', 'console_scripts', 'rubra')()
File "build/bdist.linux-x86_64/egg/rubra/rubra.py", line 66, in main
File "build/bdist.linux-x86_64/egg/ruffus/task.py", line 2680, in pipeline_run
ruffus.ruffus_exceptions.RethrownJobError:
Exceptions running jobs for

'def RedDog.makeDir(...):'

Original exception:

Exception #1
exceptions.Exception(qsub command failed with exit status: 1):
for RedDog.makeDir.Job = [False -> dir.makeDir.Success]

Traceback (most recent call last):
  File "build/bdist.linux-x86_64/egg/ruffus/task.py", line 517, in run_pooled_job_without_exceptions
    return_value =  job_wrapper(param, user_defined_work_func, register_cleanup, touch_files_only)
  File "build/bdist.linux-x86_64/egg/ruffus/task.py", line 447, in job_wrapper_io_files
    ret_val = user_defined_work_func(*param)
  File "RedDog.py", line 955, in makeDir
    runStageCheck('makeDir', flagFile, outPrefix, full_sequence_list_string)
  File "build/bdist.linux-x86_64/egg/rubra/utils.py", line 128, in runStageCheck
    status = runStage(stage, *args)
  File "build/bdist.linux-x86_64/egg/rubra/utils.py", line 144, in runStage
    exitStatus = distributedCommand(stage, commandStr, pipeline_options)
  File "build/bdist.linux-x86_64/egg/rubra/utils.py", line 122, in distributedCommand
    return script.runJobAndWait(stage, logDir, verbosity)
  File "build/bdist.linux-x86_64/egg/rubra/cluster_job.py", line 65, in runJobAndWait
    jobID = self.launch()
  File "build/bdist.linux-x86_64/egg/rubra/cluster_job.py", line 138, in launch
    str(returnCode)))
Exception: qsub command failed with exit status: 1


r2d2::Error vs diesel::r2d2::Error

Hi
I am trying to change .unwrap to ? in some of my diesel code.
I got: the trait bound diesel::r2d2::Error: std::convert::From<r2d2::Error> is not satisfied
Is this by intention/design or just something not yet done?
the get() method of diesel::r2d2::Pool returns r2d2::Error and not diesel::r2d2::Error, that's how I ran into this

See http://docs.diesel.rs/diesel/r2d2/type.PoolError.html

This is still a problem. The only workaround seems to be importing and maintaining the correct version of r2d2 manually.

As Sean pointed out above the error type is reexported with a different name in the diesel::r2d2 module.
That issue is now over an year closed. If you think that issue some old issue has regressed please open a new issue.


expose the stroke-linecap props in progress component

Please make sure these boxes are checked before submitting your PR, thank you!

[x] Make sure you follow Element's contributing guide (中文 | English | Español | Français).
[x] Make sure you are merging your commits to dev branch.
[x] Add some descriptions and refer relative issues for you PR.

It draws the pie chart easily by expose the stroke-linecap props
https://github.com/ElemeFE/element/issues/15467

Sorry, we have no plan to support this


Add index that makes query listing galleries on brand page go from 14…

…s to 14ms

Tests are failing, but looks good

test this please


tryListenOnPipe can be slow

We are receiving traces that tryListenOnPipe is slow and takes up to 1sec

The main thread and extension host communication via a named pipe, like other parts in our system. To generate the (random) name for that pipe I have used crypto#randomBytes. Contradicting to the docs it turns out that this call, on windows, takes roughly 1 second to finish.
Adding candidate-label for consideration, fix is trivial.

:+1:


API not working anymore

Since 5 Days I get the error pydeepl.pydeepl.TranslationError: DeepL call resulte in a unknown result
Seems like deepL closed the api? I tryed it on different computers to get sure that the did not just blocked me.

Yes it seems that they did something, whatever it exactly may be.

Hi. I was going to report the same…
In [1]: from pydeepl import translate

In [2]: translate("I love testing DeepL from command line with Python", to_lang='FR', from_lang='EN')
---------------------------------------------------------------------------
TranslationError                          Traceback (most recent call last)
<ipython-input-2-6e2d3b7070cf> in <module>()
----> 1 translate("I love testing DeepL from command line with Python", to_lang='FR', from_lang='EN')

/usr/local/lib/python3.6/dist-packages/pydeepl/pydeepl.py in translate(text, to_lang, from_lang, json)
     93
     94     if 'result' not in response:
---> 95         raise TranslationError('DeepL call resulted in a unknown result.')
     96
     97     translations = response['result']['translations']

TranslationError: DeepL call resulted in a unknown result.

From what I see here, https://www.deepl.com/api.html, the API is now only for paying users.

API Access

What is the Authentication Key and where can I find it?

The Authentication Key is a code that enables DeepL Pro subscribers access to our API. The Authentication Key looks similar to “df4385c2-33de-e423-4134-ca1f7b3ea8b7”. You can find your unique Authentication Key in your DeepL Pro Contract page.

So I guess there is two possible directions now:

add some code to pydeepl to allow the user to use their own API key, maybe stored in a file ~/.deepl.apikey or some thing like this. Example of code:

import deepl
deepl.apikey("~/.deepl.apikey") # read and load it
deepl.translate("Now it works, with your own key!")

stop pydeepl development and mark is as deprecated.

For my own usage, I won't buy a key so I stopped using my deepl.py script.

A pull requests made by @MrMonk3y changing the api endpoint fixed the issue. It's up-to-date and I'll create a new release to the pip package right now.

Good!
Tell me if you want me to test the script before you release it to pip, I can pip install directly from github!

I tested it before merging but feel free to check it. Additional testing is always good.

I was getting this error before updating:
---------------------------------------------------------------------------
JSONDecodeError                           Traceback (most recent call last)
<ipython-input-1-35b09e15e9bb> in <module>
      5 to_language = 'ES'
      6
----> 7 translation = pydeepl.translate(sentence, to_language, from_lang=from_language)
      8 print(translation)
      9

/usr/local/lib/python3.6/dist-packages/pydeepl/pydeepl.py in translate(text, to_lang, from_lang, json)
     90     }
     91
---> 92     response = requests.post(BASE_URL, json=parameters).json()
     93
     94     if 'result' not in response:

/usr/local/lib/python3.6/dist-packages/requests/models.py in json(self, **kwargs)
    894                     # used.
    895                     pass
--> 896         return complexjson.loads(self.text, **kwargs)
    897
    898     @property

/usr/lib/python3/dist-packages/simplejson/__init__.py in loads(s, encoding, cls, object_hook, parse_float, parse_int, parse_constant, object_pairs_hook, use_decimal, **kw)
    516             parse_constant is None and object_pairs_hook is None
    517             and not use_decimal and not kw):
--> 518         return _default_decoder.decode(s)
    519     if cls is None:
    520         cls = JSONDecoder

/usr/lib/python3/dist-packages/simplejson/decoder.py in decode(self, s, _w, _PY3)
    368         if _PY3 and isinstance(s, binary_type):
    369             s = s.decode(self.encoding)
--> 370         obj, end = self.raw_decode(s)
    371         end = _w(s, end).end()
    372         if end != len(s):

/usr/lib/python3/dist-packages/simplejson/decoder.py in raw_decode(self, s, idx, _w, _PY3)
    398             elif ord0 == 0xef and s[idx:idx + 3] == '\xef\xbb\xbf':
    399                 idx += 3
--> 400         return self.scan_once(s, idx=_w(s, idx).end())

JSONDecodeError: Expecting value: line 1 column 1 (char 0)

But now it's fine!

Already pip tested. Worked!

Am 28.09.2018 um 09:53 schrieb Lilian Besson<EMAIL_ADDRESS>Good!
Tell me if you want me to test the script before you release it to pip, I can pip install directly from github!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Good! Good job @EmilioK97 !

It seems to be still broken when using python2.7

Broken.....

Does anyone knows a great alternative for this api?

Broken too.
I now use the googletrans API (more insights here).


Replace occurrences of a word in a file

Script Title - Replace occurrences of a word in a file by another word
what will change -
This new script will read a file and replace all occurrences of the first word with the second one.
How to use: python input_file.txt word1 word2
Instructions

Create a new folder for your script and file/folder name should be appropriate.
Create a README.md in your folder for program Instructions
add requirements.txt if needed

Please add/delete options that are not relevant.

[x] Adding New Code
[x] Improving Code
[x] Improving Documentation
[x] Bug Fix

Programming Language

[x] Python

:star2: Star it :fork_and_knife:Fork it :handshake: Contribute to it!
Discord server  - https://discord.gg/FXyh2S3
Happy Coding,

Hello, I would like to work on this issue.

@nandacamargo Hi ! can i work on it?

I would also like to work on this. Can you please assign me on this?

Hello, I would like to work on this. if possible can you please assign this to me also?

Can you review my PR?
Add new script to replace words #226
Thank you!


Issue 11 order assuring option for faster opertations

Closes #11
An alias was also created for the assureOrder function, called just o, so the hack can be used with less code pollution.

Thanks to codeclimate, I took some time refactoring the code following the concept of recipes and ingredients to remove some ignored repetitions he was showing.
So, there is a lot of refactoring in the code but notice that no external contract had been changed.
For the relevant changes in this PR, check the edit on the main comment


fix(#3279): plug AvailabilityActor directly to MqttActor

TODO

[ ] tests

Proposed changes
Because the C8yMapperActor synchronously first receives a message from the input channel, and then produces output by sending to the output channel, if one of these channels block, the other one will also not be processed.
In this case, there was a loop: C8yMapperActor sent MqttMessages to AvailabilityActor, and AvailabilityActor send PublishMessages to C8yMapperActor for it to relay it to MqttActor.
When a sender for PublishMessages was full when AvailabilityActor tried sending another message, it would block, so until this message was processed, AvailabilityActor wasn't processing now input. However, if before this output was sent by C8yMapperActor there was another message to relay to AvailabilityActor, and the inbound channel was also full, this would result in a deadlock where neither AvailabilityActor input or output could be sent through.
Types of changes

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
[ ] Documentation Update (if none of the other choices apply)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

#3279

Checklist

[x] I have read the CONTRIBUTING doc
[x] I have signed the CLA (in all commits with git commit -s)
[x] I ran cargo fmt as mentioned in CODING_GUIDELINES
[x] I used cargo clippy as mentioned in CODING_GUIDELINES
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments

Superseded by #3295


Add Django 3.0 support

Note that I did not add testing against 3.8 since that seems to have its own errors and could be handled in another PR instead.

I'm not sure why I'm getting the errors on travis since it does work locally for all tox environments

thank you Oscar, I merged your branch into my pplnx-dev branch

@peppelinux Is this something you are planning to release on PyPi? Not sure how maintained this repo is any more (@knaperek)


[WIP] Release next

Codecov Report

Merging #455 (26e0485) into master (cbbd9be) will decrease coverage by 0.03%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master     #455      +/-   ##
==========================================
- Coverage   81.71%   81.68%   -0.04%
==========================================
  Files          87       87
  Lines        7519     7539      +20
  Branches      949      951       +2
==========================================
+ Hits         6144     6158      +14
- Misses       1368     1374       +6
  Partials        7        7

Impacted Files
Coverage Δ

packages/rax-compat/src/create-element.ts
89.71% <74.07%> (-2.88%)
:arrow_down:

packages/plugin-store/src/index.ts
94.95% <100.00%> (+0.31%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


use email if real_name is empty

If the 'real_name' field is empty/blank, messages to Slack look like:
Resolved by @micah. Bug now POST, assigned to **. Unresolve with @rhcos-triage-bot unresolve

This will test if the real_name string is empty and use the email
value if so.

I don't have the scaffolding to test this, apologies in advance.


Can't upgrade dataserv-client on FreeBSD

sudo pip install dataserv-client --upgrade fails with:
Collecting storjnode>=0.0.11 (from dataserv-client)
Could not find a version that satisfies the requirement storjnode>=0.0.11 (from dataserv-client) (from versions: 0.0.1, 0.0.2, 0.0.3)
No matching distribution found for storjnode>=0.0.11 (from dataserv-client)```

I've got storjnode 0.0.3 installed and can't upgrade further.

dataserv-client don't support python3 at the moment. Follow the install introduction: https://github.com/Storj/dataserv-client/blob/master/README.rst#linux-ubuntumintdebian

dataserv-client don't support python3 at the moment. Follow the install introduction: https://github.com/Storj/dataserv-client/blob/master/README.rst#linux-ubuntumintdebian

Thanks, didn't realize that. The newly introduced graphviz dependency is nuts on a headless box...

Thanks, didn't realize that. The newly introduced graphviz dependency is nuts on a headless box...

graphviz will be removed with the next storjnode version. You can install the storjnode develop branch but i don't know how stable the develop branch is. Better wait for the next storjnode release.

Oh alright, thanks!


Uncaught Error: ENOENT: no such file or directory, uv_chdir

[Enter steps to reproduce:]

...
...

Atom: 1.33.0 x64
Electron: 2.0.11
OS: Mac OS X 10.14.1
Thrown From: linter-js-standard package 6.1.0
Stack Trace
Uncaught Error: ENOENT: no such file or directory, uv_chdir
At /Applications/Atom.app/Contents/Resources/app.asar/node_modules/graceful-fs/polyfills.js:21

Error: ENOENT: no such file or directory, uv_chdir
    at process.chdir (/app.asar/node_modules/graceful-fs/polyfills.js:21:9)
    at process.chdir (/app.asar/node_modules/graceful-fs/polyfills.js:21:9)
    at settings.style.lintText (/packages/linter-js-standard/lib/linter-js-standard.js:25:17)
    at _combinedTickCallback (internal/process/next_tick.js:138:11)
    at process._tickCallback (internal/process/next_tick.js:180:9)

Commands
  2x -1:06.8.0 core:move-down (input.hidden-input)
     -1:06.0 core:move-up (input.hidden-input)
  2x -1:05.7.0 core:move-left (input.hidden-input)
     -1:05.2.0 core:backspace (input.hidden-input)
     -1:04.0 core:save (input.hidden-input)
     -0:59.1.0 tree-view:move (span.name.icon.icon-file-directory)
     -0:58.8.0 editor:move-to-end-of-screen-line (input.hidden-input)
  4x -0:57.9.0 core:backspace (input.hidden-input)
     -0:53.3.0 core:confirm (input.hidden-input)
     -0:41.7.0 tree-view:move (span.name.icon.icon-file-text)
     -0:41 editor:move-to-end-of-screen-line (input.hidden-input)
  4x -0:40.7.0 core:move-left (input.hidden-input)
  4x -0:39.4.0 core:select-left (input.hidden-input)
     -0:34.8.0 core:confirm (input.hidden-input)
  6x -0:15.7.0 find-and-replace:select-next (input.hidden-input)
  2x -0:10.9.0 core:save (input.hidden-input)

Non-Core Packages
atom-ide-ui 0.13.0
busy-signal 1.4.3
compare-files 0.8.1
github-atom-light-syntax 0.5.0
intentions 1.1.5
language-babel 2.85.0
language-dotenv 1.2.0
language-liquid 0.7.0
language-nunjucks 4.2.1
linter 2.2.0
linter-js-standard 6.1.0
linter-ui-default 1.7.1
pigments 0.40.2

Thanks for reporting this issue. What kind of file did you have open when you were trying to save? Was it an ordinary local file?

I’m still not entirely sure under which circumstances this happens, however, the underlying cause should now be fixed with https://github.com/ricardofbarros/linter-js-standard/commit/922125f13e9226803d0e6231e635541b142b7ef6 in linter-js-standard v6.1.1.


Imported roosterjs 6.19.1 to switch to using clearBlockFormat by default

Imported roosterjs 6.19.1 to switch to using clearBlockFormat by default. Also includes multi-line pre text paste into single bug fix.

tran test


Annotation processor error "Could not execute transformation"

I'm seeing:
What went wrong:
Execution failed for task ':appname:transformLogLifeCycleProcessorAbcDebug'.
> Could not execute transformation

This is with the following top-level build.gradle:
// ..
    dependencies {
        classpath 'com.android.tools.build:gradle:1.2.2'
        classpath 'com.github.stephanenicolas.loglifecycle:loglifecycle-plugin:1.0.3'
    }

And apply plugin: 'loglifecycle' added to the app module's build.gradle. Can provide more environment info if needed.

Same error here.
@kiwiandroiddev do you have things like Dagger or ButterKnife which use annotations?

@mlatu yes we're using butterknife. Is there some sort of conflict?


Cannot read property 'onDidChangeTitle' of undefined

Issue Id: 4a236dab-f5d3-3f82-6b00-3d7661f17c4bVersions - 1.24.0-<PHONE_NUMBER>4dcbe9aca0e5ca3ba8a53808b122b6-  b4e6fe3bd751448783ed20c8e49fdabd69514b8d-  f67e6397855fb25becbdf33df185f96da7fdd108Stack TypeError: Cannot read property 'onDidChangeTitle' of undefined/vs/workbench/parts/scm/electron-browser/scmViewlet.ts#1345:80 (onSelectionChange)/vs/workbench/parts/scm/electron-browser/scmViewlet.ts#1155:8 (call)/vs/base/common/event.ts#142:18 (fire)/vs/workbench/services/scm/common/scmService.ts#115:29 (_i)/vs/base/common/lifecycle.ts#51:16 (dispose)/vs/workbench/services/scm/common/scmService.ts#76:18 (dispose)/vs/workbench/api/electron-browser/mainThreadSCM.ts#317:13 (apply)/vs/workbench/services/extensions/node/rpcProtocol.ts#265:16 (_doInvokeHandler)/vs/workbench/services/extensions/node/rpcProtocol.ts#250:27 (_invokeHandler)/vs/workbench/services/extensions/node/rpcProtocol.ts#196:39 (_receiveRequest)/vs/workbench/services/extensions/node/rpcProtocol.ts#178:9 (_receiveOneMessage)/vs/workbench/services/extensions/node/rpcProtocol.ts#111:65 (onMessage)/vs/workbench/services/extensions/node/rpcProtocol.ts#307:4 (call)/vs/base/common/event.ts#140:15    at Socket. (out/vs/workben

Great catch, bot!
Repro:

Install an extension which contributes a view to the SCM viewlet
Open a repository
Run Git: Close Repository
💥


Make the first user an admin

Currently the only way to create the first admin user is to update the record in the DB. This fixes it by making the first user an admin.
Two questions:

I checked the existing (integration) test but it didn't test anything related to the roles, so I'm not sure if/how we can extend it. We could test in testSuccessfulRegistration that the body contains Administrator and in a separate test where we create a user with a fixture, that it does not?
I'm not sure if putting the logic in the controller is the way to go. I tried looking at other places where this kind of logic resides but couldn't really find any.

I totally missed that there is an repman:create:admin command. Still this might be useful?

Sorry, but it doesn't seem like a good idea to me. We can optionally add a description to the documentation, or call this command during the first installation
For the future, you can always open the issue and talk things over so that you don't have to produce the code :wink:
Thanks for your time :tropical_drink:


Disable diagnostic IDE0003 (Remove 'this' qualification)

This rule conflicts with SA1101, where the StyleCop rule is preferred for this project.
Fixes #530

This works for me.