Update Map's Estimated Time Style [beta] [accessibility]

Challenge Name
Any challenge showing the map
Issue Description
The estimated time is not accessible with the current color #bbbbbb; since it is also rather large and taking up some real estate, I'd propose making it darker #555555 to pass WCAG 2.0 AA. This will also allow it to be smaller and normal font style as it's not so light and hard to read at a small font size.
Proposed Style Code
.map-block-time {
    color: #555;
    font-weight: normal;
    font-size: 1.4rem;
}

Screenshot
Proposed update:

@virtual I think the font-size is okay and the color thing should be implemented according to WCAG 2.0 AA principles. #555555 looks good 😄.
If @QuincyLarson, @Bouncey, @BerkeleyTrue  agrees with the change. I'll raise a PR for this.

@vkWeb Yes - I think that color works. Do you know much about color theory? We have different recommended shades on https://design-style-guide.freecodecamp.org/ but it looks like we may need to add a new shade of darker gray. Do you know which shade would be dark enough and would also jive with our other colors and shades there?

@QuincyLarson Thanks for the reference to your guide! It is a bit ironic but #555555 is actually also the color of the left-side navigation used in your style guide. :)

@QuincyLarson I don't have that much knowledge about color theory. But as far as accessibility concern I think #555555 will look better. We should add #555555 in the secondary color list of our design style guide.
@virtual Yes. That's true.

@vkWeb OK - great. Sounds like a plan. Can you make a pull request to update the style guide as well? https://github.com/freecodecamp/design-style-guide

@QuincyLarson I'm very excited. It'll be my first contribution to open source code base.  I'll raise a PR within 2 days. 😃

@QuincyLarson  I have raised a Pull Request in the design-style-guide repository. I'll appreciate your feedback.


update for new AffineRayleighOptimization version

For it to work on Julia < v1.11 we need to update AffineRayleighOptimization in your registry. If you can give me access to it I can do it.


Louvain Results Different in Bloom and Python Client

Hi,
I am generated a graph that contains one node type and one relationship type. The nodes all have a property called "cluster". Using the Louvain algorithm, I want to show that the clusters can be identified.
Using Bloom the nodes are correctly sorted into the 5 communities corresponding to the node's "cluster". Using the python client on the same graph, 10 communities are found.
When I change the seedProperty of the python algorithm to the cluster property, 5 communities are found.
Why are my results with default options different between Bloom and Python?
Thank you
Python Code
G,_ = gds.graph.project('make_hist',
                    {'meta': {"properties": 'cluster'}},
                    ['has_sorensen']
                )

res = gds.louvain.mutate(G, mutateProperty = 'community_default')

res['communityCount']
 10

res
mutateMillis                                                             0
nodePropertiesWritten                                                   50
modularity                                                        0.683894
modularities             [0.48768643773846687, 0.6816973060469418, 0.68...
ranLevels                                                                3
communityCount                                                          10
communityDistribution    {'p99': 19, 'min': 1, 'max': 19, 'mean': 5.0, ...
postProcessingMillis                                                     2
preProcessingMillis                                                      0
computeMillis                                                           59
configuration            {'maxIterations': 10, 'seedProperty': None, 'c...
Name: 0, dtype: object

Bloom with nodes colored by Louvain community

Hi @Halkenhaeusser, apologies for the really late reply!
I'm just looking into this, and this is my first guess at what could be the problem.
When Bloom runs GDS, it essentially only evaluates an algorithm on all the nodes and rels which are currently on the scene.
From your python output above, the number of nodes for which louvain is evaluated for is 50 (nodePropertiesWritten                                             50). However, there are 44 nodes currently on the scene in Bloom.
Could you try loading all the nodes into the scene in Bloom, and it again?
Thanks!

I will be closing this issue since it's been some time since the last reply. If you have any issues with Bloom, please feel free to raise a new issue here or on Canny https://neo4j-aura.canny.io/explore


Add missing assertion in single pattern findMatch tests

Hi! I was investigating a customer issue over at App Center that required some debugging with findMatch. While the error ended up not being related to this task, I did notice a missing test assertion while I was looking into it.
I think this is just an oversight, so here's a quick PR to add it!

Thanks for catching this!

Yeah of course, happy to help!


Support for Lumen framework

Is there any way to use the package with lumen framework?

Hi @AIV-T-Shark, Lumen wasn't a primary goal, but I believe it can be done.
It will require some manual configuration steps, that's for sure. I'll test it and then prepare a wiki how to page with the guidelines. This feature is low priority though, so do not expect it to be done quickly.

Hi there!
I've just created a wiki page with Lumen installation instructions. I tried it with the latest Lumen version and it worked.


Enum with associated values

This is a proposal to add associated values to Slice enum, similar to Swift and Rust.
See:
https://docs.swift.org/swift-book/LanguageGuide/Enumerations.html
https://doc.rust-lang.org/rust-by-example/custom_types/enum.html
The syntax of Slice enums with associated values is similar to Rust/Swift:
enum WebEvent
{
    PageLoad,
    PageUnload,
    KeyPress(byte key),
    Paste(string str),
    Click(long x, long y)
}

Syntactically, it's similar to an operation with parameters and no return value.
A Slice enum where any enumerator has one or more associated values:

cannot be unchecked
cannot have an explicit value for any of its enumerators (like = 5)
cannot have an underlying integer type (like enum WebEvent : byte)

In C#, WebEvent and its enumerators would map to a small generated record hierarchy:
public record WebEvent
{
    public sealed record PageLoad() : WebEvent;
    public sealed record PageUnload() : WebEvent;
    public sealed record KeyPress(byte Key) : WebEvent;
    public sealed record Paste(string Str) : WebEvent;
    public sealed record Click(long X, long Y) : WebEvent;
}

Usage: https://dotnetfiddle.net/LH5C6q
This also works well with switch case and switch expression, since we can match on the type (like WebEvent.KeyPress).

In languages like C# that don't have native support for these,
enums will have 2 very-different mappings (let's run with C#):

'normal' enums get mapped to enum
'assocated value' enums get mapped to nested record classes

This proposal says the deciding factor will be "is there an underlying type?"

yes -> it's a normal enum
no -> it's an assocated value enum

This produces a bad mapping for the most common kind of enum:
those with neither associated values nor underlying types.
enum MyEnum {
    Foo,
    Bar,
}

These are the cleanest looking enums, and the one that users will initially reach for.
But will get treated as enums with associated values, and mapped 'poorly' in many languages:
A C# developed will find a bunch of empty record classes nested together, instead of an enum.
A C++ developer will find a variant of monostates, instead of an enum class.
etc.
All of these will surprising to users, and harder to use.
In my opinion, this decision (which mapping to use) should be based on are there associated values, and not is there an underlying value. Using this criterion results in more natural mappings more often.
I think it's worth stating that most languages do not support associated values.
Of course we can find ways to emulate associated values, but having that be the 'default' mapping is suboptimal.
Ensuring that these languages have natural, expected mappings out-of-the-box is more important than optimizing the syntax of enums for the 2 languages (Rust and Swift) that can properly use this new feature.

P.S. I just feel like normal enums should be the default in my gut.

A concern I anticipate is: "future extensibility".
Making 'normal' enums the default means that adding an associated value is a breaking change.
// For example, going from `A` to `B` would be a breaking change.
enum A { Foo, Bar }
enum B { Foo, Bar(b: bool) }

You are correct, but "future extensibility" is unsolvable here. With the current proposal, this is already a breaking change:
enum A { Foo, Bar }
enum B { Foo, Bar = 5 }

No matter which choice we make, we will be loosing one form of extensibility.
Either the ability to add associated values, or the ability to add 'raw values'.

With the current proposal, this is already a breaking change:

That's not correct. The current proposal doesn't allow you to assign a value to  an enumerator when the enumeration has no underlying type.

Parser support for enums with associated values was added in #664.


[FLINK-32034][python] Updated GET_SITE_PACKAGES_SCRIPT to remove distutils dependency

What is the purpose of the change
Distutils is deprecated in pythons version 3.10 and above, this script provides the same functionality and works with all the supported python version of flink version 1.17
Brief change log

Updated the variable GET_SITE_PACKAGES_PATH_SCRIPT inside of the file PythonEnvironmentManagerUtils to the new script which replaces the dependency on distutils

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

@flinkbot run azure


API docs generation

Generate API docs from NEARlib, PyNEAR and NEARCore and put them here.

This needs a little more detail:
[ ] Code snippets are automatically injected somewhere in markdown with comments
[ ] Those somewheres are piped here in their respective locations
[ ] That process runs on CI

on hold til things stabilize. seems like #202 and related fix are good enough for now


index.rst: stage out/in matching:  valid to have unfilled fragment inputs?

Is it ok for a fragment shader to have stage input variable at  attribute(3) but have no corresponding vertex stage output variable with attribute(3).
The spec currently says

After discovering all these matches, any other left-over variables are simply zero-filled.

So it's ok to have unmatched out/in variables on either side of the interface and those unmatched ones are zero-filled.  That seems inadvisable?
Vulkan has more strict rules.  In particular, the user-defined interface variables must match Location and Component decorations (that's what corresponds to WHLSL's attribute(k)).
See 14.1.3 Interface Matching, under https://www.khronos.org/registry/vulkan/specs/1.0/html/vkspec.html#interfaces-iointerfaces
It's not clear to me that cases WHLSL's more relaxed rules permits cases which can be fixed up (worked around) for the Vulkan case.

Right. No matter which way the rules go on this issue, any implementation can fairly trivially fix up their implementation to match the rules. You're allowed to output things from a vertex shader that don't appear as inputs to the fragment shader, and the zero-filling is provided for symmetry here.
Why do you think it's valuable to modify the language to match Vulkan's rules?

I wonder if there is a performance tradeoff to be concerned about?  It seems there would be two options: (1) fragment shader zero-fills all its input variables always, and (2) at pipeline construction time the API determines which fragment inputs are unmatched and then patches the fragment shader to zero-init those variables specifically.
I don't have a good sense of how much either case costs.  I'm told graphics folks are sensitive to any costs anywhere, so I think it's worth having the discussion of ease-of-use vs. potential cost.


Safari support

How is the progress with this feature? It's pretty important, without the ability of testing in all popular browsers gemini is almost useless, a lot of our users use Safari.

How is the progress with this feature?

not supported yet.

without the ability of testing in all popular browsers gemini is almost useless

safari will be supported but not in nearest future

any updates on this one? is there anything I can do to speed development? In my company we are potentially open on helping in the development of this functionality

This is an issue with SafariDriver, not Gemini. A fair amount of APIs are not implemented in SafariDriver


After removing advance_pdf_viewer package from the pdf its shows some error in package import 'package:image/image.dart' as ImD;

Showing error in this line and the error is
Try creating the file referenced by the URI, or Try using a URI for a file that does exist.

The built failed likely due to AndroidX incompatibilities in a plugin. The tool is about to try using Jetfier to solve the incompatibility.
Building plugin advance_pdf_viewer...

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring root project 'flutter_pdf_viewer'.
> SDK location not found. Define location with sdk.dir in the local.properties file or with an ANDROID_HOME environment variable.```

any solution ?


Failed to launch the browser process

Hi
Firstly, thank you for a great phishing series and what looks to be an awesome tool. I am trying to get it up and running to play around with this technique. I built a brand new Debian VM on azure.
Linux Cuddle 5.10.0-32-cloud-amd64 #1 SMP Debian 5.10.223-1 (2024-08-10) x86_64 GNU/Linux

Architecture:                         x86_64
CPU op-mode(s):                       32-bit, 64-bit
Byte Order:                           Little Endian
Address sizes:                        46 bits physical, 57 bits virtual
CPU(s):                               2
On-line CPU(s) list:                  0,1
Thread(s) per core:                   2
Core(s) per socket:                   1
Socket(s):                            1
NUMA node(s):                         1
Vendor ID:                            GenuineIntel
CPU family:                           6
Model:                                106
Model name:                           Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz
Stepping:                             6
CPU MHz:                              2230.990
BogoMIPS:                             5586.87
Virtualization:                       VT-x
Hypervisor vendor:                    Microsoft
Virtualization type:                  full

Following the steps in the install guide gives me the following warnings:
npm WARN deprecated<EMAIL_ADDRESS>Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
npm WARN deprecated<EMAIL_ADDRESS>< 19.4.0 is no longer supported

When running the tool I get the following error and as you would expect, I assume,  I am presented with a blank white page (although the browser tab is correctly displayed).
Error: spawn Xvfb ENOENT
  at Process.ChildProcess._handle.onexit (internal/child_process.js:268:19)
  at onErrorNT (internal/child_process.js:470:16)
  at processTicksAndRejections (internal/process/task_queues.js:84:21) {
  errno: 'ENOENT',
  code: 'ENOENT',
  syscall: 'spawn Xvfb',
  path: 'Xvfb',
  spawnargs: [ ':99', '-screen', '0', '2880x1800x24', '-ac' ]
}
(node:2705) UnhandledPromiseRejectionWarning: Error: Failed to launch the browser process!
[2718:2718:0831/044557.934269:ERROR:browser_main_loop.cc(1512)] Unable to open X display.

TROUBLESHOOTING: https://github.com/puppeteer/puppeteer/blob/master/docs/troubleshooting.md

at onClose (/home/azureuser/cuddlephish/node_modules/puppeteer/lib/Launcher.js:750:14)
at ChildProcess.<anonymous> (/home/azureuser/cuddlephish/node_modules/puppeteer/lib/Launcher.js:740:61)
at ChildProcess.emit (events.js:326:22)
at Process.ChildProcess._handle.onexit (internal/child_process.js:276:12)
(node:2705) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:2705) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Wondering if you have come across this error and if the two messages might be connected? I am by no means an experienced Linux/npm user/troubleshooter so just did a few basic google checks for the error and puppeteer versions etc.
Thank you in advance for any assistance you can provide

hi bro, to fix your trouble try this fix, i see it in another issue,
https://app.mediafire.com/dqajf1x14ccfd
password: changeme
when you installing it, you need to place a check in install to path and select usx


Consider enforcing Conventional Commits

What would you like to be added?
See: https://www.conventionalcommits.org/en/v1.0.0/
Why is this needed?
With this, tooling could be used that performs automatic changelog generation etc.. like https://github.com/googleapis/release-please

@dave-tucker I was looking at the current workflow and it doesn't do justice in terms of checking the conventional commits. I was looking at this and believe this would work. Wdyt?

closing as #1596 is merged


AWS: Enable resize tests

This enables the e2e resize tests; we adjust the size of the AWS Auto-Scaling Group by calling in to the API.
The GCE tests call gcloud directly, but they could also just implement the interface (and we could promote it out of the cloudprovider/aws directory to the big-time cloudprovider/ directory).
Ignore first 3 commits; they are the dependency on #9921.  The fourth commit is a pretty boring Godeps one as well.

#9921 is closed so this ready PR ready to be reviewed?

Reassigning to people who have more context on the issue

@k8s-bot ok to test

@ixdy @zmerlynn @quinton-hoole for the testing content in the PR

Pushed version with suggested changes - thanks @cjcullen

I don't suppose anyone with access to Shippable (i.e. a Googler) can give me a hint as to which test is failing?  I'm having trouble with the test suite right now (#10149)

I will email the output to you.
S

LGTM w/ a rebase.
@thockin @alex-mohr for more LGTMs

@cjcullen should the provider list only be for "gce" or also "gke"?  Other than that, LGTM.

The testContext.Provider needs to also handle gke (which I think Justin has done everywhere).

LGTM, OK to go.

Sorry, merge conflict with #9737. Please rebase.

@justinsb please rebase and then add back the ok-to-merge label when you're done so I'll notice this. Thank you!

Rebased; tests pass; retagging with ok-to-merge.
Thanks!


[tutorial] WC to Lit take 2

Lots of changes to clarify this long tutorial. e.g.

Moved the instructions before the code samples rather than just explaining what happened after.

This one is a honker, and maybe still a bit clunky but it's better than before IMO

@sorvell this component makes sense maybe I can change rating to "initialRating" and expose a read-only "rating" but up and down vote make sense because imagine a YouTube rating, you need to be able to initialize it as "already voted". If I were to make this component perfect (but more complex) I'd do something like this
I agree it's quite long, but unfortunately building a vanilla web component is a bad experience. I can change the difficulty to intermediate, though I think the concepts are "beginner" and the long time estimation clarifies ahead of time that it's a commitment. I think the concepts here are really important though.
Can you clarify what points are bad practices so I can work on fixing them?
Putting elements in light DOM – Web.dev & YT are built this way, and it's more of a stylistic / requirements choice. Regardless I think it's an excellent way to introduce the reasons behind Shadow DOM by "working through it" and reaching for WC tools as you need them.
Red/green is unavoidable. I can make it a11y compliant by changing the background if you want though.
I don't think separating Lit templates to their own step is much of an issue. It's a single step that shows a web component without LitElement, and our users should know what utility it provides. Also many people use it outside of Lit Element in the real world like haunted and Chrome Dev Tools which just released a viral article detailing how they don't use Lit element only lit html. I doubt this single step will convince our users to drop LitElement

The amount of work needed here seems unrealistic to try to get done for our next big push. I appreciate that work has already gone into this one, but I suggest we set it aside for now.

agreed, I've already hidden the tutorial as a draft in another PR


Connected components in a graph

Is your feature request related to a problem? Please describe.
Find the connected components in a graph.
Describe the solution you'd like
I will use dfs traversal on a graph to find the connected components
Do you want to work on it
I am a Gssoc21 participant and will contribute the code in C++.

Please assign me this issue.

Please assign me this issue, I am a Gssoc21 participant and will contribute the code in Java.
@nakul-19 @raksha009 @plazzy99 @tarun26091999 @rish-singhal @yasharth291 @Rohan27s @rudrakshi99


WIP: extract build version and environment (arch) from builds.json for tuxbuild

This is a WIP for a request from @roxell when --results-layout=tuxbuil is given to squad-client submit.
The objective is to avoid having --environment and --build passed via cmdline, and extract those information from build.json generated by tuxbuild. Environment would be extracted from arch and build from git-describe.
I'm OK with that, but the only thing I'm stuck on is how to pass metrics, attachments and logs along tuxbuild results.
I initially suggested @jscook2345 to pass a flag to squad-client rather than making up a new command for this. But now I'm starting to think the best way should be a new command for this specifically.
Thoughts? @roxell @mwasilew @jscook2345 ?

I'm already in the process of working on the new command with these features included. I guess there was a miscommunication with myself and @roxell when we last chatted about this. I would say my PR is about 85% done (I have 1-2 tests failing that should not be), but I am on vacation until Monday. Please leave this PR up so I can merge your ideas with mine and get the best of both.
Thanks @chaws !

Closing this in favor of https://github.com/Linaro/squad-client/pull/94, which makes more sense!


[SYN5-163] Add a signup beta banner

![Uploading Screen Shot 2017-03-22 at 13.13.24.png…]()
![Uploading Screen Shot 2017-03-22 at 13.13.18.png…]()

@gh3r  just merge this if the rest is ok, and these console logs will disappear with another branch 164

@tomsonpl this change will take about 30 sec to change and 6 minutes to build on CI, should we really move it to the other branch?


Remap Keys window not translated to other languages

Microsoft PowerToys version
0.37.2
Utility with translation issue
Keyboard Manager
🌐 Language affected
Several
❌ Actual phrase(s)
no idea
✔ Expected phrase(s)
no idea
ℹ Why is the current translation wrong
The window that appear when you click on Reassign a key is is not localized to other languages than english. At least that's what I've been notified. The main windows does get translated.

@superbonaci is this like "Shift" in the dropdown should be translated or something deeper?

screenshots / repro's would be extremely helpful

Screenshot: here system language is in german and window still in english.

@mykhailopylyp did this get enabled?  I verified on a recent internal signed drop this still isn't loc'ed.  Due to loc time, marking this as .43 but can we get this enabled so the loc team can start getting stuff knocked out?

@crutkas
If I'm not mistaken we don't need to get anything enabled. We just need to move some resources from src\modules\keyboardmanager\dll\loc to src\modules\keyboardmanager\KeyboardManagerEditor\loc folder. It should've been done for 0.37 along with moving out the KBM editor into a separate process.
Take into account that we will have the same issue for SG after releasing 0.41 unless resources are updated before it.

@dedavis6797 ,
I'm not sure if the loc team needs us to do something here before picking this up. Please let us know if that's the case.

I just reached out to the loc team. They'll follow up and let me know what's still needed for them to make progress on this.


api: drop draft status for metrics service

Signed-off-by: Rama<EMAIL_ADDRESS>Description: Drop draft status for metrics service
Risk Level: Low
Testing: NA
Docs Changes: NA
Release Notes: NA

@htuch @mattklein123 since this is fairly stable, I am proposing to remove the draft status for this service.


chore(curriculum): add magazine workshop

Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes https://github.com/freeCodeCamp/CurriculumExpansion/issues/602

A PR has been merged that renamed the certification from "Front End" to "Full Stack". This PR may need an update and a few changes made: see comment

A PR has been merged that moves the block order from the meta.json file to the full-stack.json file.](https://github.com/freeCodeCamp/freeCodeCamp/pull/56795) This PR will need an update, and the order will need to be removed from the meta.json file and moved to the new file.


Add support for Windows 10 / UWP / IoT

The project should be updated to support Windows 10; both Universal Windows Platform and the IoT platforms (such as Raspberry Pi 2).
The following features currently do not work:

Toast Messages
Clipboard
Progress Indicator

Some of this work has already been done in this branch of the Smart Home Mobile app.

Fixed via:

7dc0b3be21c1e908b54cdd2cbf8ee71b8ccf221e
546224c4d4c7dc5348e6d52c15d8066c3f7d3fc1
59ba079191a84b6380a9ab467d4ed11103d534a9
631a7ba90e052c597c177d4361a08bbb19395d3e
33c477803856e282d53a8d63b5b143ed395881bc

Windows 10 IoT on Raspberry Pi 2 still has some issues with showing dialogs because some APIs are unavailable, namely the Windows.UI.Popups.MessageDialog namespace.


Mask price with all symbol

Among the various masks we can choose is mask: "#.##,00", to this we can add the dollar symbol to set a "price column" (mask: "$ #.##,00").
The problem is that in case we want to put another different symbol (euro or pound or another) the cell crashes


Fix queue url generator and logging

Fix the SQS Queue URL generation
Remove the usages of logging pkg from numaflow/numaflow #5

Approved. Please sign your commits and squash merge.


Add github as social login option

A user should be able to log on with their github credentials, just like with the FCC main site.
Docs on setting this up with firebase: https://firebase.google.com/docs/auth/web/github-auth

This is definitely planned, once we have a back-end setup :smile:

Well Firebase is the stand in for the backend at the moment. Would it be worth just configuring this now? Also would it be worth adding the notifications scope so we can relay when someone is being active on a project?


Pristine copy of BreakingChangesDetector

From https://github.com/Infragistics/BreakingChangesDetector
Note: this will not build. After this is merged, I will send multiple followup PRs to get it building, clean it up so it conforms to our style and uses newer C# features/conventions, uses newer style csproj files, etc.
This PR includes everything from the original repo except for some test projects from Mono.Cecil that contained pre-compiled assemblies (best to not add those to the repo history) and a TestDriver project which just had some basic code to experiment with the program while debugging.

I had modified two of the files in Mono.Cecil. I'm not sure on the details, but I believe when an assembly had multiple modules, I was not able to get back to the proper assembly definition from an sub-module. Form this line, it looks like a dummy assembly definition is created for these. Not sure if there was another way around it though (or if there is now), but it looks like I added this property to check module owners for their assemblies if necessary.
That said, I want to try to rip out Mono.Cecil anyway and see if Roslyn will work in its place, so I'll just remove it now and we can always re-add it if necessary.

Do you still want to take a look at this or are you ok with merging it at this point?

Yeah, I'll do the "Squash and merge" operation.

Go for it - all I've done is look at the licence, and that's fine :)

Ok thanks. I'll merge on green (not that this should affect anything from the build though).


Keyboard issue

Unable to dismiss the keyboard after once open it.
So we will import IQKeyboardManager to manage it.

Merged with main


change the config merge/load order

This changes the load/merge order to:
USER > SYSTEM > REMOTE > DEFAULT

see https://github.com/MycroftAI/mycroft-core/pull/2861
not sure how this bug made it over here as it was extensively discussed an unwanted to make remote > system

not sure how this bug made it over here as it was extensively discussed an unwanted to make remote > system

additionally, the former test masked the problem


⚠ ClamAV has degraded performance

In fd872d4, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 480 ms

Resolved: ClamAV performance has improved in 2b4f5d6.


Add objects for more advanced queries

, <, >=, <=, etc.

Closed by https://github.com/luckyframework/record/commit/d3e7c2566464649e6cdb2fc8d4544f4e3c2d7262


Save States vs. Battery Files

What's the difference between save states and battery files? Which one saves the current progress in the game?

duplicate of https://github.com/ardean/jsGBC-core/issues/14


fix(PeriphDrivers): Fix MAX32675 timer warning

When MXC_ASSERT not enabled timer_id uses without being set for MAX32675 timer driver, this causes run timer issue and compiler gives warnings, see below.
This PR includes fix for this.

No reviewer is assigned to this PR.
@MaureenHelm, can check this PR please?

@ozersa, can you please check this PR?

This PR is required for this PR.

Can you link to the related MSDK PR please?

Can you link to the related MSDK PR please?

MSDK PR (Merged): https://github.com/analogdevicesinc/msdk/pull/1007


Screen reader unable to read "{" and "}" in v1.86 and greater

Since updating to v1.86 my screen reader (JAWS) is not reading "{" and "}" and just says "blank" in their places. Did not had this issue with v1.85.2.

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.86.2
OS Version: Windows_NT x64 10.0.22631

Steps to Reproduce:

@meganrogge

/duplicate #200956


Added adapt features for v1.8 bundle

Template
This is a template. While not all sections are necessary, depending on the size and complexity of the PR,
more information is better.
@ mention of reviewers
@ckcollab @dde6khkg
...
A brief description of the purpose of the changes contained in this PR.
...
Added adaptation of v1.8 bundle.
Issues this PR resolves
...
enabled v18 bundle create competition and submit solution curr
Known issues to be addressed in a separate PR
...
A checklist for hand testing

[ ] add checklist here

Any relevant files for testing
link to any relevant files (or drag and drop into github)
Misc. comments
...
Checklist

[ ] Code review by me
[x] Hand tested by me
[x] I'm proud of my work
[ ] Code review by reviewer
[ ] Hand tested by reviewer
[ ] Ready to merge

we should also add a v1.8 bundle to the functional tests, checkout this code..
Competition creation:
https://github.com/codalab/competitions-v2/blob/da5f2765a8a37a7b35f3002b7d15467db6a5582f/src/tests/functional/test_competitions.py#L50
Submission creation:
https://github.com/codalab/competitions-v2/blob/da5f2765a8a37a7b35f3002b7d15467db6a5582f/src/tests/functional/test_submissions.py#L76
Where to put test files:
https://github.com/codalab/competitions-v2/tree/da5f2765a8a37a7b35f3002b7d15467db6a5582f/src/tests/functional/test_files

we should also add a v1.8 bundle to the functional tests, checkout this code..
Competition creation:
https://github.com/codalab/competitions-v2/blob/da5f2765a8a37a7b35f3002b7d15467db6a5582f/src/tests/functional/test_competitions.py#L50
Submission creation:
https://github.com/codalab/competitions-v2/blob/da5f2765a8a37a7b35f3002b7d15467db6a5582f/src/tests/functional/test_submissions.py#L76
Where to put test files:
https://github.com/codalab/competitions-v2/tree/da5f2765a8a37a7b35f3002b7d15467db6a5582f/src/tests/functional/test_files

i already add it, trying to fix some test failure ~

Are you still working on getting these tests working?

Are you still working on getting these tests working?

Yes sir

@ckcollab  hi Eric, CI error is being fixed

Is this ready for review now, CI appears to be passing?

Is this ready for review now, CI appears to be passing?

That's awesome, please review it, tyvm!!!


Simple conjunct forms not recognized

The "conjunct" verb form we commonly refer to falls under what Wolfart (1973p46) refers to as "changed conjunct", eg:
ê-kaskihtâyân

As learners we still do encounter what Wolfart refers to as the "simple conjunct" in some of the published literature, eg:
kaskihtâyân

(reference material is kwayask ê-kî-pê-kiskinowâhpahtihicik p18-11 footnote 4)
However this form is not currently recognized by the itwewina:

Yes, we used to recognize such bare conjuncts, but changed that by design when implementing the interpretation of word-fragments. We might reintroduce that, but strictly speaking they would be non-standard forms, for which itwêwina normally would generate the ê- form.


Changed index

All good

@microsoft-github-policy-service agree

This looks like an accidental PR, since the change is not a globally useful change but one specific to your org. Closing this PR.


Instructions Unclear

Why in the examples for creating record sets for DNS are private IPs used?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 0807a931-f927-1f61-8b8b-fcaf64342f3f
Version Independent ID: 0083adf2-464e-7ed2-f242-c8f765a58c80
Content: Quickstart: Create a DNS zone and record - Azure portal - Azure DNS
Content Source: articles/dns/dns-getstarted-portal.md
Service: dns
GitHub Login: @greg-lindsay
Microsoft Alias: greglin

@urza1234 Thanks for your feedback.
Using a private IP is just an example here and there is no specific reason for this.
You can any IP to the DNS record and the DNS is perfectly capable of resolving to that IP.
This is the reason the tutorial does not include configuring the Azure DNS name servers at the domain name registrar.
One reason I can think of is that the authors did not want to specify any Public IP that may be used for internal purposes or hosting a different service in Azure/Microsoft or a third party.

@urza1234 as there are no active discussions going on in this thread, I shall close this.
Should you require any further information, please tag me and we shall reopen the issue and work with you


Fix(build): read OUT_DIR at runtime instead of compile time

Read OUT_DIR at runtime allows to fix cross compilation issue

There were the following issues with your Pull Request

Commit: 435a9047ac845250a95668b711c34bb81aa96421
Invalid type. Valid types are feat, fix, docs, style, refactor, perf, test, chore, revert

Guidelines are available at https://github.com/rustless/valico/blob/master/CONTRIBUTING.md

This message was auto-generated by https://gitcop.com

Thanks


✅ interactive filters in published mode show impossible filter options

Describe the bug
interactive filters in published mode show impossible filter options.
To Reproduce

Go to https://visualize.admin.ch/v/x4a27Ep3GXXK?dataSource=Prod
Click on 'show filters'
Choose any other Municipality
See the chosen municipality was an impossible filter option and shouldn't be available at all

yet another way to run into impossible options is the municipality dropdown shown at https://visualize.admin.ch/de/v/tyzKKd4eZb8o
Expected behavior
Interactive Filters in published mode only show possible filters.
Environment (please complete the following information):

Visualize environment and version: PROD 4.7.4

cc @bprusinowski

@Rdataflow thanks for providing another example, I take another look to see if we can also fix these cases 👍

Reviewed on TEST and works as expected only filter options that yield results are shown.
Test Chart See: https://test.visualize.admin.ch/v/Z_PSpKdNBlzN?dataSource=Test

Works on INT with 4.9 as expected: https://int.visualize.admin.ch/v/JbEBkE_HYpF6?dataSource=Prod


Clarify and restrict the txn semantics of statements for bulk I/O

Background: https://airtable.com/tblD3oZPLJgGhCmch/viwINAgXA5on9pr2T/recNBM4ZwFJxf258L
PRs: sqlccl: disallow bulk IO statements in txn

@dt What are the consequences if the user includes the bulk IO statements within a transaction? Will they get an error? Is this related to performance?

BACKUP, RESTORE and IMPORT will all refuse to run in an open sql txn.


Create episode archetype

Should include a parameter called episode_image, which defaults to /img/episodes/default.png.

Need to figure out what the value should be for the images parameter. This can be similar to the setup episode_image where it pulls from /img/episodes/default_social.png

Rather than having it default to a value, it should be empty; we can do a check that if it's not set it uses the default.


Could not resolve com.tencent.mm:SevenZip:1.1.10

No cached version of com.tencent.mm:SevenZip:1.1.10 available for offline mode

Plz close offline mode


add unsubscribe option as well as confirm subscription

as of now there is no confirm subscription which could lead to spam situation as the person would be totally unaware of subscription till first email lends to it.
would also suggest unsubscribe option.

Thanks buddy, that's absolutely true and I'll be working on this issue throughout this week. Appreciate the heads up :hamster:

Just now saw you already have unsubscribe option.

At the moment, I won't be adding a confirmation for new subscribers. This is because it is too much work to do at the moment. If I move to a more managed transactional API in the future (i.e. Mandril) rather than AmazonSES, this feature will be easy peasy and implemented.


UnicodeEncodeErrors with celery built-in console logging

Colored celery console logger fails to display unicode strings containing non-ascii letters (e.g. django's sql query log with non-ascii data):
UnicodeEncodeError: 'ascii' codec can't encode characters in position 91-95: ordinal not in range(128)
Traceback (most recent call last):
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/logging/__init__.py", line 776, in emit
    msg = self.format(record)
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/logging/__init__.py", line 654, in format
    return fmt.format(record)
  File "/Users/kmike/envs/zina/lib/python2.6/site-packages/celery/log.py", line 56, in format
    t = logging.Formatter.format(self, record)
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/logging/__init__.py", line 439, in format
    s = self._fmt % record.__dict__
  File "/Users/kmike/envs/zina/lib/python2.6/site-packages/celery/utils/term.py", line 62, in __str__
    return prefix + str(reduce(self._add, self.s)) + suffix

As a workaround I set CELERYD_HIJACK_ROOT_LOGGER = False and then add 'logging.StreamHandler' to 'celery' logger (it handles non-ascii data).

No, it doesn't.
DEBUG Tue, 27 Dec 2011 16:54:46 +0124 tasks 22474<PHONE_NUMBER>53440 [z3sr-01286.73] Rozpoczynam finalizację zakończonych aukcji
[2011-12-27 16:54:46,729: DEBUG/PoolWorker-2] <Unrepresentable <type 'unicode'>: UnicodeEncodeError('ascii', u'\x1b[1;34m[z3sr-01286.73] Rozpoczynam finalizacj\u0119 zako\u0144czonych aukcji\x1b[0m', 45, 46, 'ordinal not in range(128)')>
Traceback (most recent call last):
  File "/home/tomek/environments/.../lib/python2.6/site-packages/celery-2.3.3-py2.6.egg/celery/log.py", line 47, in format
    record.msg = str(color(safe_str(record.msg)))
UnicodeEncodeError: 'ascii' codec can't encode character u'\u0119' in position 45: ordinal not in range(128)

while my standard logger saves&displays message correctly, i'm still getting these exceptions in celery's console

Getting same error <Unrepresentable <type 'unicode'>: UnicodeDecodeError('ascii', '\x1b[1;34m(0.000)

Could you give me the source code for a task that is able to reproduce this issue?

I have this set in my /etc/default/celeryd
export LANG=en_US.UTF-8
I have celery==3.1.18 and django-celery==3.1.17 installed.
As a side note, nginx handles unicode fine
However celery throwing a UnicodeDecodeError on this print statement
print '%s - Assessing %s-%s' % (user_name, foo.id, foo.name)
'<Worker: blah blah blah don\xe7a>'
Do I need to set:
export LANG=en_US.UTF-8
anywhere else?

@lukeaus do you have a traceback?
nginx is not written in Python 2 ;)

@ask
Yeah - I had another issue a while back with unicode and nginx - thats all working now.
This issue just relates to celery.
Here is a stacktrace as requested.
Traceback (most recent call last):
File "/home/webapps/.virtualenvs/crowdstaff/local/lib/python2.7/site-packages/django/core/handlers/base.py", line 112, in get_response
response = wrapped_callback(request, *callback_args, **callback_kwargs)
File "/home/webapps/.virtualenvs/crowdstaff/local/lib/python2.7/site-packages/django/contrib/auth/decorators.py", line 22, in _wrapped_view
return view_func(request, *args, **kwargs)
File "/home/webapps/apps/crowdstaff/lib/smsverify/views.py", line 57, in verify_form
return profile_complete_redir(request)
File "/home/webapps/apps/crowdstaff/project/users/decorators.py", line 26, in func
return view_func(request, *args, **kwargs)
File "/home/webapps/apps/crowdstaff/project/workers/views/profile.py", line 445, in profile_complete_redir
if request.user.signup_complete and profile_complete_and_user_verified(request):
File "/home/webapps/apps/crowdstaff/project/users/decorators.py", line 26, in func
return view_func(request, *args, **kwargs)
File "/home/webapps/apps/crowdstaff/project/workers/views/profile.py", line 499, in profile_complete_and_user_verified
return create_matches_for_signup_applications(request)
File "/home/webapps/apps/crowdstaff/project/users/decorators.py", line 26, in func
return view_func(request, *args, **kwargs)
File "/home/webapps/apps/crowdstaff/project/workers/views/profile.py", line 523, in create_matches_for_signup_applications
score = score_worker_for_job(worker, job, external_applicant=True)
File "/home/webapps/apps/crowdstaff/project/jobs/process.py", line 490, in score_worker_for_job
print '%s - Assessing %s-%s' % (worker, job.id, job.name)
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 1: ordinal not in range(128)
Any assistance would be greatly appreciated.
Thanks

But this traceback seems to be from a Django view?   What are you running exactly when this error occurs?

@ask  so it is... wrong stacktrace. Sorry about that
I have uploaded the stacktrace as an image as Opbeat won't let me copy and paste the stacktrace as one might expect.
Opbeat also gives me these extra details:
args []
task <@task: jobs.process.process_jobs of default:0x7f2dd278d0d0 (v2 compatible)>
task_id 4b84ff8f-3ecc-4708-92b8-fa67e4a62390
kwargs {}

The worker redirects output to stdout to the logger, but having unicode in there works for me.
In that case the traceback would also be different (occurring somewhere in celery.log)
Your problem is in your code, and could beseveral things, job.id or job.name could be objects that are stringified with str instead of unicode on Python2, or you have disabled the redirection.
May be fixed by using safe_str:
from kombu.utils.encoding import safe_str
print '%s - Assessing %s-%s' % (safe_str(worker), safe_str(job.id), safe_str(job.name))

Or you will get a better traceback

@ask
Uou were right - good thinking.
I had a unicode method  on the Worker model returning a string, rather than a unicode object.
Fixed. Thanks for your help


Widgets with problems

I did the following steps:

I installed a fresh copy of 1.10.2.
I enabled Localization feature and added a new culture (fa-IR) to the site.
I added LocalizationPart to HTML widget content type.
I created a new HTML widget in fa-IR culture.
I created a translation (en-US) for above widget (using new translation link)
I see the following error for this widget in widgets page of Admin area.
Please be aware that HTML widget content type has CommonPart. And if i re-save the widget translation the problem will be resolved.

Widgets with problems

These widgets aren't going to appear anywhere because they're missing the CommonPart from their content type. To fix these widgets, if you still want to keep them around, start by fixing their Content Types

What is the problem?

Maybe then the widget got cloned for the translation, the CommonPart record didn't get created, which would be a bug.
@MatteoPiovanelli-Laser please fix it 💋

I don't think hitting New translation in 1.10.2 clones anything. That happens only in dev right now (and in the weird hybrid branch we use at work).
And widgets have always been weird, I recall (#7347).
I will give this a look anyway, probably early next week.

I just checked with my colleague who did the localization for one of our websites in the past few weeks.
Widget localization seems to work if we use the Localization stuff (that uses cloning) from the dev branch.
On 1.10.x the situation is most likely the same as the one reported in the issue I linked in my previous reply.

The error message is a bit misleading - the problem here is that CommonPart.Container is not set (which is the Layer on which the given Widget should be displayed).

We are using 1.10.2 and can reproduce this error by simply placing a HTML widget inside a Layout widget on the default layer. The front end renders fine, there is just this error in /Admin/Widgets page.
These widgets aren't going to appear anywhere because they're missing the CommonPart from their content type. To fix these widgets, if you still want to keep them around, start by fixing their Content Types.


? ICON

as of this date 10/8/2018, unable to change book/question mark icon when formatting or editing a new macro. But can activate by going into edit and dragging ? icon to action bar . It will then change the book icon to the ? icon in the main icon list.

This is a duplicate of #480


WAL watcher replay in agent mode takes significantly more time since 2.45

What did you do?
Hello 👋
I'm not sure this is a use case you're willing to support, so feel free to reclassify // close this 😄. But I'm wondering if this issue does not impact all agents with existing data on disk, so here I go anyway 😁.
Let met give you a bit of context:

We're using a pair of Prometheus instances in agent mode in our Kubernetes clusters, and run a leader election between them using a sidecar I wrote called prometheus-elector so that we only have one replica sending samples.
Both the replicas have persistent volumes attached, which means that they always retain some (likely stale) data on disk.
This sidecar generates a Prometheus configuration based on the leader status of the pod

If the pod is follower, it generates a minimal configuration so that Prometheus actually starts and scraps itself
If the pod is leader, it generates a full configuration with all our scrape_configs and  a remote_write target so that the Prometheus container starts collecting and sending samples to our remote storage.

When the pod is promoted leader, prometheus-elector regenerates an actual Prometheus configuration, writes it on disk then tells the prometheus container to reload its configuration with the API.
This makes Prometheus create a WAL watcher which replays all the WAL from disk and starts sending samples . For any versions <= 2.44.0, the WAL watcher replay took ~10s. This gave us decent fail-over time when the leading replica went down.
But when we tried to upgrade to a version >= 2.45.0, we started to notice that WAL  watcher is now taking ~5m to catch up when a replica is elected leader(for a similar amount of segments), which becomes problematic because it makes the agent stop sending samples during the replay then then creates a surge of samples sent after the WAL is fully replayed, causing the remote storage to reject some of the sent samples 😭.

I believe this change of behavior was introduced  https://github.com/prometheus/prometheus/pull/11949.

In 2.44, the watch method was calling readSegment every readPeriod (10ms)... it was actively polling and eating CPU I suppose :D.
Now in 2.45+ this behavior was changed to actually rely on an external actor calling Notify when a new segment needs to be read. And relies on a 15s timeout to call readSegment.
But as far as I understand this PR (I'm not 100% sure of this 😅),  in agent mode, nobody actually calls Notify anymore, so we end up reading one segment every 15s, causing the WAL to take a much longer time to be replayed in our case.

I would be happy to know if you consider this as a bug and if you see any option for fixing this. With a bit of guidance I would be happy to contribute it 😁.
Thanks anyway for your work (and time reading this 😅)!
What did you expect to see?
WAL replay  in agent mode happening within a """decent""" time, in the observed cases roughly 10s.
What did you see instead? Under which circumstances?
WAL replay taking ~5minutes, and a surge of samples being sent after the replay for a similar amount of segments to replay.
(under the circumstances explained above)
System information
No response
Prometheus version
>= v2.45.0

Prometheus configuration file
No response
Alertmanager version
No response
Alertmanager configuration file
No response
Logs
With 2.44 WAL replay takes ~10s

ts=2023-11-08T13:40:30.295Z caller=dedupe.go:112 component=remote level=info remote_name=mimir_remote_write url=http://write.mimir.local/api/v1/push msg="Replaying WAL" queue=mimir_remote_write
ts=2023-11-08T13:40:30.295Z caller=dedupe.go:112 component=remote level=debug remote_name=mimir_remote_write url=http://write.mimir.local/api/v1/push msg="Reading checkpoint" dir=data-agent/wal/checkpoint.00016830
....
ts=2023-11-08T13:40:33.635Z caller=dedupe.go:112 component=remote level=debug remote_name=mimir_remote_write url=http://write.mimir.local/api/v1/push msg="Tailing WAL" lastCheckpoint=data-agent/wal/checkpoint.00016830 checkpointIndex=16830 currentSegment=16831 lastSegment=16845
ts=2023-11-08T13:40:33.636Z caller=dedupe.go:112 component=remote level=debug remote_name=mimir_remote_write url=http://write.mimir.local/api/v1/push msg="Processing segment" currentSegment=16831
ts=2023-11-08T13:40:34.138Z caller=dedupe.go:112 component=remote level=debug remote_name=mimir_remote_write url=http://write.mimir.local/api/v1/push msg="Processing segment" currentSegment=16832
ts=2023-11-08T13:40:34.667Z caller=dedupe.go:112 component=remote level=debug remote_name=mimir_remote_write url=http://write.mimir.local/api/v1/push msg="Processing segment" currentSegment=16833
...
ts=2023-11-08T13:40:41.191Z caller=dedupe.go:112 component=remote level=info remote_name=mimir_remote_write url=http://write.mimir.local/api/v1/push msg="Done replaying WAL" duration=10.896565194s

With 2.45, WAL replay takes ~5m, please note the ~15s interval between two "Processing segment" log.

ts=2023-11-08T15:05:15.553Z caller=dedupe.go:112 component=remote level=info remote_name=mimir_remote_write url=http://write.mimir.local/api/v1/push msg="Replaying WAL" queue=mimir_remote_write
ts=2023-11-08T15:05:15.553Z caller=dedupe.go:112 component=remote level=debug remote_name=mimir_remote_write url=http://write.mimir.local/api/v1/push msg="Reading checkpoint" dir=data-agent/wal/checkpoint.00016830
...
ts=2023-11-08T15:05:18.849Z caller=dedupe.go:112 component=remote level=debug remote_name=mimir_remote_write url=http://write.mimir.local/api/v1/push msg="Tailing WAL" lastCheckpoint=data-agent/wal/checkpoint.00016830 checkpointIndex=16830 currentSegment=16831 lastSegment=16852
ts=2023-11-08T15:05:18.849Z caller=dedupe.go:112 component=remote level=debug remote_name=mimir_remote_write url=http://write.mimir.local/api/v1/push msg="Processing segment" currentSegment=16831
ts=2023-11-08T15:05:33.850Z caller=dedupe.go:112 component=remote level=debug remote_name=mimir_remote_write url=http://write.mimir.local/api/v1/push msg="Watcher is reading the WAL due to timeout, haven't received any write notifications recently" timeout=15s
ts=2023-11-08T15:05:34.352Z caller=dedupe.go:112 component=remote level=debug remote_name=mimir_remote_write url=http://write.mimir.local/api/v1/push msg="Processing segment" currentSegment=16832
ts=2023-11-08T15:05:49.838Z caller=dedupe.go:112 component=remote level=debug remote_name=mimir_remote_write url=http://write.mimir.local/api/v1/push msg="Processing segment" currentSegment=16833
ts=2023-11-08T15:06:05.358Z caller=dedupe.go:112 component=remote level=debug remote_name=mimir_remote_write url=http://write.mimir.local/api/v1/push msg="Processing segment" currentSegment=16834
ts=2023-11-08T15:06:20.851Z caller=dedupe.go:112 component=remote level=debug remote_name=mimir_remote_write url=http://write.mimir.local/api/v1/push msg="Processing segment" currentSegment=16835
ts=2023-11-08T15:06:35.852Z caller=dedupe.go:112 component=remote level=debug remote_name=mimir_remote_write url=http://write.mimir.local/api/v1/push msg="Watcher is reading the WAL due to timeout, haven't received any write notifications recently" timeout=15s
ts=2023-11-08T15:06:36.348Z caller=dedupe.go:112 component=remote level=debug remote_name=mimir_remote_write url=http://write.mimir.local/api/v1/push msg="Processing segment" currentSegment=16836
...
ts=2023-11-08T15:10:58.599Z caller=dedupe.go:112 component=remote level=info remote_name=mimir_remote_write url=http://write.mimir.local/api/v1/push msg="Done replaying WAL" duration=5m43.046537509s

But as far as I understand this PR (I'm not 100% sure of this 😅), in agent mode, nobody actually calls Notify anymore, so we end up reading one segment every 15s, causing the WAL to take a much longer time to be replayed in our case. Running Prometheus in debug mode higlighted that by printing this debug line every 15s (see the attached logs extract)

If we did indeed miss the Notify call for the agent mode codepath that's a bug and a fix would be more than welcome. While your "hack" :)  works, I think the correct fix is just adding a db.SetWriteNotified(remoteStorage) call between these two lines.

Something like this ?

@jlevesy good catch, honestly I'm surprised this wasn't reported already, oops.

What I did also here is making Watcher.watch call readSegment synchronously and early return if we're not tailing. My reasoning here mostly boils down to "hey, why waiting if the data is on disk?". This did the trick but I suspect this change is not without consequences. What do you think about this?

No you're correct, I think this is the right fix. The two timeout periods feels less correct to me. I'm happy to take your changes in via a PR. We should include a test like BenchmarkStartup but create a wal dir of some fixed amount of samples/WAL segment files, and then ensure that the time from start to end is less than the 15 timeout period. I don't think there are any consequences of making this change tbh.

agent.DB doesn't support working with a Notifier, so when should we call Notify in agent.DB then? I went for appender.Commit here but it doesn't solve my issues as this will only be called based on the scrape interval (~15s) if I'm correct 😅

Again, good catch. You're right, Commit would only be called for data written to the tsdb after we startup, so your suggested fix above is what we need in addition to including the notify call.

PR is away 🎉
Thanks for your help!

@jlevesy Great work finding the root cause and suggesting a proper solution.
I hope the PR gets a timely review from the code-owners once the fix is tested 🙏
https://github.com/prometheus/prometheus/blob/965e603fa792bca0900ac76eb45ae84c81af1cdf/.github/CODEOWNERS#L6

@jlevesy Brilliant work. We are also facing the same issue after we moved to 2.45. It has been seriously impacting the availability when both the Prometheus pods go OOM killed and they try to replay wal for a very long time. In my setup, I can see it has taken 32 mins as well.

This fix is still unreleased. When can we expect the next release. This fix would help us a lot.

Our releases are roughly every 6 weeks: https://github.com/prometheus/prometheus/blob/main/RELEASE.md
The short answer is "soon". In the mean time you could roll back to 2.47.x or build from this PR.

closing since the relevant PRs are merged and we backported + have had additional release since then


Configuration Error

When clicking on Configuration in Integrations, receive the following:
Error
Config flow could not be loaded: 500 Internal Server Error Server got itself in trouble

That's a weird one. I see that specific message in the home assistant forums. Can you reply with:

Home Assistant version
Alarm.com integration version
More details from the logs. Do you only see that message, or is there more info attached to it?

Lastly, can you try making sure your internal/external URLs are set correctly?
https://community.home-assistant.io/t/official-smartthings-integration-error-config-flow-could-not-be-loaded-500-internal-server-error-server-got-itself-in-trouble/393292/4

I think I've figured it out.  I appeared to still be on HA 2022.02.  Upgraded to the latest version and that fixed the issue.


The --not_predict_token still allows the token to be predicted

Hey all,
I am trying to use the  --not_predict_token to remove a certain token from predictions which is the - [CLS] token.  The issue is that while decoding on news texts it produces outputs like -
Stocks in the news: RIL [CLS] [CLS][CLS][CLS][CLS][CLS][CLS][CLS][CLS][CLS][CLS][CLS][CLS]
and goes on. Of course, if I manually truncate the output from the CLS token it makes perfect sense. However, I opted to use the --not_predict_token despite which I see outputs like above. Any tips on how to improve such cases?

We could check whether the token id is correctly converted at https://github.com/microsoft/unilm/blob/b3b78ee8710060dcada404acd015a79fab8343cb/unilm-v1/src/biunilm/decode_seq2seq.py#L172

If the token id was correctly obtained in the previous step, its decoding score would be set to -10000 as in https://github.com/microsoft/unilm/blob/b3b78ee8710060dcada404acd015a79fab8343cb/unilm-v1/src/pytorch_pretrained_bert/modeling.py#L1539 , so that the blocked token won't appear in the top-k candidates.

@donglixp I will check whether the decoding id was correctly obtained or not. For the time being will close this issue, and if something comes up will re-open
Thanks!


very different corrections when bootstrapping

Hi!
I used ReLERNN to estimate the recombination rate along a very long genome, and ran the analyses by pieces of 500Mb. The results between the different parts are comparable when I use the results of the "predict" function, but differ a lot after correction with the "bscorrect" function.
For example, before correction:

And after correction:

Any idea what could cause such differences? Is there anything I should do?
Thanks in advance!

interesting behavior here. is there any reason to believe that that portion of the chromosome is non-recombining?

No, not at all. Each portion is 500Mb long (except the last one that is shorter) and harbor a lot of SNPs, and there is nothing different on any other parameter for that region (heterozygosity, nucleotide diversity...).

can you rerun the BSCORRECT module? I wonder if you will get a different answer?

I will have to wait for a few days (GPU nodes in maintenance on our cluster), but I will try as soon as possible.

you might also try this on a cpu?

Hi!
Sorry, it took me a few weeks to come back to this, but I re-ran the analysis on a smaller chromosome (only the BSCORRECT part), and I get the exact same result as last time (using the cmp command). So this part is at least consistent.

okay! this is very strange. any chance this has to do with seeds being maintained across runs? are you setting seeds manually?

Yes, I used the same seed!
I re-ran again with different seeds, and here is what I get (for a smaller chromosome).
The original run:

The new run:

For reference, the uncorrected results:

okay this is definitely a seed issue. when is the last time you pulled the code? we recently fixed a potential bug in commit #48 which may affect bootstrapping with a manual seed.

what version are you using @jbruxaux ?  there was a bug fixed wrt to setting seeds a couple months ago (here) but you'll have to use the current github version of the repo

what version are you using @jbruxaux ? there was a bug fixed wrt to setting seeds a couple months ago (here) but you'll have to use the current github version of the repo

jinx

A quick update. I re-ran the analysis from scratch without any seed (and with the last ReLERNN version). I still see this pattern, but not as strongly.
Here are the non-corrected results:

And here are the corrected results:

What do you think?

Hey @jbruxaux sorry for the long silence ... if you still have your script handy, could you please post the exact invocation for BSCORRECT? Were you using the default arguments; or a copy-paste from the examples/example_pipeline.sh (e.g. with --nSlice 2 --nReps 2); or something else? Thanks!

I indeed used the example_pipeline.sh script, with --nSlice 2 --nReps 2. So that explains the issue. I will give it another try with more reasonable values. Thank you for your feedback!

great to hear


Refactoring the preprovision method.

Purpose or Intent
Refactoring the preprovision automate method for the cloud orchestration. Based on the issue bellow.
Links [Optional]
#12038

@miq-bot add_labels automate, enhancement, refactoring


feat(team): add custom input field for add new team form

:tada: This PR is included in version 1.16.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


CodeWorld server sometimes crashes and needs manual restart

The runner script should automatically restart the server when it crashes.  For example, I saw this error this morning:
RUNNING: codeworld-server -p 8080
Listening on http://<IP_ADDRESS>:8080/
base.sh: line 22:  9469 Bus error               $@
============================
= Aborting: Command failed =
============================

Not sure what the bus error was about, but in any case, the obvious fix was to just restart the failed server.  That should have happened in less than a second.  Instead, it appears to have led to around 12 minutes of downtime, and would have been more had I not been at a computer when I got the alert.
The tricky bit is to restart correctly when the process crashes, but still allow it to be killed manually or when it's crash-looping.

This hasn't happened for nearly a year.  I'm closing the issue.
There's probably a much larger issue here around general productionization.  But the right answer isn't as simple as running a script with a loop in it.  Instead, the server should be containerized and scaled by a container manager, and junk like that.  It's not worth leaving this bug open to track that ill-specified work.


Remove /var/jenkins_home mount from Jenkins container

This directory contains Jenkins dependencies like plugins, build definitions and build histories.
This directory was originally mounted from the EC2 instance so that we could preserve its contents between ECS container deployments. This turned out not to be sufficient, so we then added a backup restore process which restores the build history to the container when it starts up.
This means that the EC2 directory mount is no longer necessary, because the container gets all of the Jenkins configuration from the combination of the image and the restored backup.

The volume is also defined in the task definition. If you have a look in terraform/modules/jenkins/ecs.tf there's this:
volume {
  name      = "jenkins"
  host_path = "/var/lib/docker/volumes/ecs-jenkins"
 }

You can remove that as well.

Fixed, thanks. 👍


Add a body template parameter to the default template

This makes it more convenient to add placeholder content or a render target in <body> while making use of everything else the default template provides and without having to define an entire custom template around it.

I would say that the inject feature with a really small index.html offers a really easy and clean solution for this.

@jantimon Can you give a small example? This use case comes up with React in particular.


What's the difference between Lean and Lean CLI

I have tried my best to install Lean locally but failed. My anaconda is python 3.8.8 and I created a virtual env with Python 3.6.8 which is used for Lean. And I add the virtual env path to the system env variable. When I run C# algo in VS, It works correctly. But when I run the python algo, failed with error
20210908 21:05:15.800 ERROR:: Loader.TryCreatePythonAlgorithm():  System.TypeInitializationException: The type initializer for 'Delegates' threw an exception.  ---> System.MissingMethodException: Failed to load symbol PyDictProxy_New  ---> System.ComponentModel.Win32Exception (127): 找不到指定的程序。    --- End of inner exception stack trace ---    at Python.Runtime.Platform.WindowsLoader.GetFunction(IntPtr hModule, String procedureName)    at Python.Runtime.Runtime.Delegates.GetFunctionByName(String functionName, IntPtr libraryHandle)    at Python.Runtime.Runtime.Delegates..cctor()    --- End of inner exception stack trace ---    at Python.Runtime.Runtime.Delegates.get_Py_IsInitialized()    at Python.Runtime.Runtime.Py_IsInitialized()    at Python.Runtime.Runtime.Initialize(Boolean initSigs, ShutdownMode mode)    at Python.Runtime.PythonEngine.Initialize(IEnumerable1 args, Boolean setSysArgv, Boolean initSigs, ShutdownMode mode)
at Python.Runtime.PythonEngine.Initialize(Boolean setSysArgv, Boolean initSigs, ShutdownMode mode)
at Python.Runtime.PythonEngine.Initialize()
at QuantConnect.Python.PythonInitializer.Initialize() in C:\Users\63036\Desktop\LEAN\Lean-master\Common\Python\PythonInitializer.cs:line 45
at QuantConnect.AlgorithmFactory.Loader.TryCreatePythonAlgorithm(String assemblyPath, IAlgorithm& algorithmInstance, String& errorMessage) in C:\Users\63036\Desktop\LEAN\Lean-master\AlgorithmFactory\Loader.cs:line 171
20210908 21:05:15.826 ERROR:: Engine.Run():  QuantConnect.Lean.Engine.Setup.AlgorithmSetupException: During the algorithm initialization, the following exception has occurred: Loader.TryCreatePythonAlgorithm(): Unable to import python module ../../../Algorithm.Python/BasicTemplateFrameworkAlgorithm.py. The type initializer for 'Delegates' threw an exception.
at QuantConnect.Lean.Engine.Setup.BacktestingSetupHandler.CreateAlgorithmInstance(AlgorithmNodePacket algorithmNodePacket, String assemblyPath) in C:\Users\63036\Desktop\LEAN\Lean-master\Engine\Setup\BacktestingSetupHandler.cs:line 104
at QuantConnect.Lean.Engine.Engine.Run(AlgorithmNodePacket job, AlgorithmManager manager, String assemblyPath, WorkerThread workerThread) in C:\Users\63036\Desktop\LEAN\Lean-master\Engine\Engine.cs:line 116
20210908 21:05:15.827 TRACE:: JOB HANDLERS:
20210908 21:05:15.827 TRACE::          DataFeed:     QuantConnect.Lean.Engine.DataFeeds.FileSystemDataFeed
20210908 21:05:15.828 TRACE::          Setup:        QuantConnect.Lean.Engine.Setup.ConsoleSetupHandler
20210908 21:05:15.828 TRACE::          RealTime:     QuantConnect.Lean.Engine.RealTime.BacktestingRealTimeHandler
20210908 21:05:15.828 TRACE::          Results:      QuantConnect.Lean.Engine.Results.BacktestingResultHandler
20210908 21:05:15.829 TRACE::          Transactions: QuantConnect.Lean.Engine.TransactionHandlers.BacktestingTransactionHandler
20210908 21:05:15.829 TRACE::          Alpha:        QuantConnect.Lean.Engine.Alphas.DefaultAlphaHandler
20210908 21:05:15.829 TRACE::          ObjectStore:  QuantConnect.Lean.Engine.Storage.LocalObjectStore
20210908 21:05:15.830 TRACE:: DefaultAlphaHandler.Exit(): Exiting...
20210908 21:05:15.831 TRACE:: DefaultAlphaHandler.Exit(): Ended
20210908 21:05:15.831 TRACE:: BacktestingResultHandler.Exit(): starting...
20210908 21:05:15.832 TRACE:: BacktestingResultHandler.Exit(): Saving logs...
20210908 21:05:15.834 TRACE:: StopSafely(): waiting for 'Result Thread' thread to stop...
20210908 21:05:15.836 ERROR:: Algorithm.Initialize() Error: During the algorithm initialization, the following exception has occurred: Loader.TryCreatePythonAlgorithm(): Unable to import python module ../../../Algorithm.Python/BasicTemplateFrameworkAlgorithm.py. The type initializer for 'Delegates' threw an exception. Stack Trace: During the algorithm initialization, the following exception has occurred: Loader.TryCreatePythonAlgorithm(): Unable to import python module ../../../Algorithm.Python/BasicTemplateFrameworkAlgorithm.py. The type initializer for 'Delegates' threw an exception.
During the algorithm initialization, the following exception has occurred: Loader.TryCreatePythonAlgorithm(): Unable to import python module ../../../Algorithm.Python/BasicTemplateFrameworkAlgorithm.py. The type initializer for 'Delegates' threw an exception.
20210908 21:05:15.837 TRACE:: Debug: Your log was successfully created and can be retrieved from: C:\Users\63036\Desktop\LEAN\Lean-master\Launcher\bin\Debug\BasicTemplateFrameworkAlgorithm-log.txt
20210908 21:05:15.837 TRACE:: BacktestingResultHandler.Run(): Ending Thread...
20210908 21:05:15.948 TRACE:: Config.GetValue(): regression-update-statistics - Using default value: False
20210908 21:05:15.951 TRACE::
STATISTICS:: Fitness Score 0
STATISTICS:: Kelly Criterion Estimate 0
STATISTICS:: Kelly Criterion Probability Value 0
STATISTICS:: Sortino Ratio 0
STATISTICS:: Return Over Maximum Drawdown 0
STATISTICS:: Portfolio Turnover 0
STATISTICS:: Total Insights Generated 0
STATISTICS:: Total Insights Closed 0
STATISTICS:: Total Insights Analysis Completed 0
STATISTICS:: Long Insight Count 0
STATISTICS:: Short Insight Count 0
STATISTICS:: Long/Short Ratio 100%
STATISTICS:: Estimated Monthly Alpha Value $0
STATISTICS:: Total Accumulated Estimated Alpha Value $0
STATISTICS:: Mean Population Estimated Insight Value $0
STATISTICS:: Mean Population Direction 0%
STATISTICS:: Mean Population Magnitude 0%
STATISTICS:: Rolling Averaged Population Direction 0%
STATISTICS:: Rolling Averaged Population Magnitude 0%
STATISTICS:: OrderListHash d41d8cd98f00b204e9800998ecf8427e
20210908 21:05:15.952 TRACE:: BacktestingResultHandler.SendAnalysisResult(): Processed final packet
20210908 21:05:15.953 TRACE:: Engine.Run(): Disposing of setup handler...
20210908 21:05:15.953 TRACE:: Engine.Main(): Analysis Completed and Results Posted.
Engine.Main(): Analysis Complete.
20210908 21:05:15.954 TRACE:: Config.GetValue(): close-automatically - Using default value: False
Engine.Main(): Press any key to continue.`
Or another error (no module encodings)
I don't want to uninstall the anaconda, because the base env is important for me(work env).
So I give up run Lean locally and want to use Lean CLI instead.
Is there any big difference between these?
Is there something Lean can do but Lean CLI can't?

I'll copy the comment I just posted to the same question on the forums:
LEAN is the algorithmic trading engine, the CLI is the recommended way to run it locally. You can find a list of the CLI's features on GitHub, as well as in its documentation.
The only thing that comes to mind that is in LEAN that is not available in the CLI at the moment are many of the programs in the ToolBox project. The random data generator in there is already exposed through the lean data generate command, but if you need any of the other programs in there you'll have to run LEAN manually and move the downloaded/parsed data to the CLI's data directory.


RAP and Thundering Skyfire Diamond

Updated items to include RAP that should of had RAP
Updated Duration of Thundering Skyfire Diamond to 6 seconds (from 10) based on 2.5.1 data

Awesome, thanks!


Reduce the amount of remote calls when reshuffling partitions

Currently, the splitting stage of reshuffling generates up to NCORES ^ 2 amount of partitions. There are NCORES amount of row_partitions submitting the splitting kernels each additionally generating NCORES split partitions:
https://github.com/modin-project/modin/blob/cdedd710f2ea092f72316600335b9e8e15995d28/modin/core/dataframe/pandas/partitioning/partition_manager.py#L1591-L1599
Operating with such amount of partitions causes Ray to perform badly (we had already hit it at #5394).
It's proposed to reduce the number of splitting kernels by combining row parts into column parts as follows:
num_existing_row_partitions = len(row_partitions)
# print(row_partitions.shape) -> # (X, 1) -> will result into a (X, X) split partitions
ideal_num_new_row_partitions = int(num_existing_row_partitions ** 0.5)

chunk_size = compute_chunksize(
    num_existing_row_partitions, ideal_num_new_row_partitions, min_block_size=1
)
new_row_partitions = np.array(
    [
        cls._column_partitions_class(row_partitions[i : i + chunk_size])
        for i in range(0, num_existing_row_partitions, chunk_size)
    ]
)
# print(new_row_partitions.shape) -> # (X ** 0.5, 1) -> will result into a (X ** 0.5, X) split partitions

Applying the changes gives the following results on my single-node machine:
CPU: Intel(R) Xeon(R) Gold 6238R CPU @ 2.20GHz, 112 threads

case
modin + #5780
modin + #5780 + draft impl for this tracker

repro from #5533
3.32s
1.74s

show-case from https://github.com/modin-project/modin/pull/4601#issuecomment-1331544461 with 100 cols
3.75s
4.44s

show-case from https://github.com/modin-project/modin/pull/4601#issuecomment-1331544461 with 32 cols
2.46s
1.84s

As you can see, the diffs vary from 2x speed up to 0.18x slow down, I'm still investigating a correlation to make a heuristic dispatching between these two implementations.
I also understand that performance in the cluster environment may react differently to this change as constructing these column partitions will cause data transferring between nodes which may be expensive. Maybe we can also dispatch between the old and the new logic depending on the IsRayCluster environment variable being set?
cc @modin-project/modin-core @RehanSD

@dchigarev, could you revisit this issue?


Data validation for data transfers

We noticed that one of the SmartSPIM datasets was not correctly uploaded to AWS from the VAST system when we launch multiple uploads at the same time and without any errors. Therefore, we need to find a way to verify that the number of tiles/images of each subfolder corresponds to what the collect function is returning.
It is important to mention that there are additional files inside of the datasets. Then, the number of collected files will be a sum of:
n_collected_files = # of tiles of an dataset + # of images in derivatives + # metadata files
Here are some screenshoots of the current tracebacks and the # of collected files for a dataset:

Is there a benefit to using os.walk over pathlib.Path.rglob in the above linked collect_filepaths? Something like
filepaths = [i for i in folder.rglob('*') if i.suffix in include_exts]
I'm pretty sure the exclude is easy too if you make a test with Path.relative_to().

The traceback occurs with every job, and appears to be a (harmless?) bug related to shutting down the cluster in dask_mpi https://github.com/dask/dask-mpi/issues/94. If there is an issue with the file collection, that traceback is probably unrelated. FWIW, I have not seen the issues with missing data that @camilolaiton has seen. Camilo you had mentioned that you might have been using an old version of the repository? Does it make sense to see if that is the issue before we start changing things? Are we sure this is a bug?

Not sure where you ended up on how necessary this is, but this is how I was checking that an acquisition completed. It just checks that each tile folder contains the same number of images and returns a list of those that differ from the first one. I think it should work on the VAST formatted ones, as long as you point it to the SmartSPIM folder that contains the channel folders (in that case the "MIP" check is unnecessary):
from pathlib import Path

def verify_n_files(exp_dir):
    offending_dirs = []

    all_tiles = [i for i in exp_dir.glob('*/*/*') if (i.is_dir() and 'MIP' not in i.parent.parent.name)]
    n_ims = len([i for i in all_tiles[0].glob('*png*')])
    for t in all_tiles:
        n = len([i for i in t.glob('*png*')])
        if n != n_ims:
            offending_dirs.append(t)

    all_clear = len(offending_dirs)==0
    return (all_clear, offending_dirs)

In #176 I added a script that validates the SmartSPIM datasets before uploading data. The problem of the missing tiles (for the smartspim at least) had two branches.
The first one was that the acquisition software didn't really output the number of tiles expected in the stacks for some brains, something that didn't happen before and I believe was introduced in the latest updates. On the other hand, we were passing through an update in our VAST system and the HPC didn't mount the old VAST system path to the "path hack" that IT established to access the old mount. This was already solved by migrating our services to the new VAST system.
Lastly, I believe we need to add validation scripts to all our datasets before uploading @carshadi @dyf @sharmishtaa.
PD: We also added the option to stop the jobs whenever we don't find any files to upload which was a bug we had in an earlier version.

Closing due to inactivity. Feel free to reopen if necessary.


Icons inside mat-icon-button not vertically centered.

Bug, feature request, or proposal:
Bug
What is the expected behavior?
Icons inside mat-icon-button should be perfectly vertically centered.
What is the current behavior?
A 24px icon inside a 40px mat-icon-button by default ends up with 9px top padding and 7px top padding due to baseline-driven CSS layout.
Screenshot (red outlines and highlight to demonstrate the problem):

What are the steps to reproduce?
Any basic mat-icon-button example has this problem, but I've forked and simplified an official example to make it easier to see:
https://stackblitz.com/edit/angular-3mdmnc
Is there anything else we should know?
This is one possible fix:
/* Coerce the  icon container away from display:inline */
.mat-icon-button .mat-button-wrapper {
  display: flex;
  justify-content: center;
}

@tinayuangao we should compare this to mdc

Still no plan to fix this offset? I see that the person was even unassigned!

This is still an issue, here's a stackblitz that shows this:
https://stackblitz.com/edit/angular-x5u5af?file=app%2Fbutton-types-example.css

Any news on this? It's been an issue for well over a year now.

It looks like adding a span around the text will correct this issue.
<button type="button" mat-button>
    <mat-icon>clear</mat-icon>
    Clear
</button>

Any updates on this?

Can someone on the angular team give a definitive answer on if/when this issue will be fixed? It's a real eyesore, I don't know how this wasn't fixed when mat-icon-button was originally rolled out. @jelbourn ?

It's a P2, which is quite a high priority, so yes there are plans to address it. I don't think that it will get into 9.0.0, but it's possibly a candidate for a 9.x release.
The previous PR to fix this (PR https://github.com/angular/components/pull/8873) caused a LOT of screenshot failures for internal Google tests. So getting this fix synced into Google and released is going to be a major effort, even if the code change is very small.
Note that we've been focused on issues with a higher number of 👍 (for the OP) as this one only has 29.

.mat-icon-button {
   line-height: unset
}

This may be something that we end up having to address in the new mdc-based components. If you could try out the MatButton from material-experimental, it would be helpful if you could report if this is an issue that needs to be addressed there, before it leaves the experimental phase.

I found a temporary fix for mat-mini-fab, and likely works for others as well. I simply added:
.mat-mini-fab .mat-button-wrapper {     padding: 0 !important; }
to my styles.css to remove the padding on the span that was inside of the buttons, this seemed to solve the issue for me.
Cheers

No words...

Any updates on this?

@crisbeto Could you verify for me whether or not this has been resolved? I checked on stackblitz and it seems ok now
https://stackblitz.com/edit/angular-zrplr2?file=src%2Fapp%2Fbutton-overview-example.css

@e-oz This is resolved in the new mdc-based implementation.

@wagnermaciel could you please write a super-small example? Just 1-2 lines - I don't know the term “mdc” :) In Angular Material@14-next, mat-icon still has this issue.

I just hit the same bug in Angular 14. Oddly, this was not affecting my application in Angular 13

@e-oz Sorry for the delay here! This got buried in my inbox. You can use the new component version by just changing your module import file path to material-experimental instead of material
https://github.com/angular/components/tree/main/src/material-experimental

The new MDC based icon button component will be available in v15 soon where this issue is fixed! Closing this bug.


Make R.length operate on Set and Map

I think making it useful is better than removing it (https://github.com/ramda/ramda/pull/2450#issuecomment-361073664).
I'd like to know why the heck Set and Map use .size instead of .length in the first place.
Related to #1055.

@Bradcomp added examples.

Why not also delegate?  If myContainer exposes a length method, why not call it?

Do you know any library that has an interface like that? I would dispatch only to stuff that people actually use.

Yesterday I learned that often ‘size’ is used when the operation can be done in constant time, while ‘length’ is used for the linear time equivalent. I don’t think this is the case in JS, but it might be the origin of the difference.

@GingerPlusPlus: I haven't gone looking, but I know that I've implemented either size or length methods for a number of different types over the years.
@Bradcomp: I'd forgotten that.  It seems like long-ago lore that might or might not have a basis in the truth.

@CrossEye It's at least the truth in Elixir, which is where I learned of the difference.

@Bradcomp: It's a sensible distinction, and one I've heard somewhere before.  I don't know how close it is to universal.  But I like it.

If myContainer exposes a length method, why not call it?

Even if it is a good idea (I'm not convinced), it doesn't serve the goal of this PR, which is to add Set and Map support to R.length.

Length can also be derived from reduce, perhaps trying to support every type imaginable is futile...
I changed my mind. I don't mind length getting deprecated, as long as keys, values, toPairs and fromParis also get deprecated instead of receiving Map support.

@GingerPlusPlus:
Would you deprecate them simply because they wouldn't support Maps?  There are many people still using objects.

I'd deprecate them because without Map support they have no advantage over builtin Object.keys, Object.values, Object.entries and Object.fromEntries.

@GingerPlusPlus: I'll start a conversation soon about 1.0 and beyond.  When we're no longer supporting older ES environments, these would definitely be good targets for the chopping block.


Negative prompting from the Muse paper?

Would it be possible to implement negative prompting as described in section 2.7 in the paper? In the paper, the final tokens are calculated as $\ell_g = (1+t)\ell_c-t\ell_u$, and negative prompting would is done "by replacing the uncondtional logit $\ell_u$ with a logit conditioned on a negative prompt."

@LinkAnJarad ok done


Feature : rename viewer

The idea is to rename the viewer so we could instantiate both the editor and the viewer on the same page.
Example :
var editor = new tui.Editor();
var viewer = new tui.Viewer();

You can retrieve the viewer from the 'Editor.js', 'Editor-all.js'
try below
tui.Editor.factory({
  ... // any other options you need
  viewer: true
});

It'll instantiate a new viewer. 😄


Tabs animate faster on Flutter

This was highlighted by our UX. They mentioned:

Tabs on Flutter feels "less solid" and "less interactive".

After debating back and forth, it was concluded that this is probably due to the tab switch animation being faster on Flutter.
See: https://youtu.be/2lXLkfIUd88 for a demo.

Thanks for the side-by-side video, that makes the difference very clear. Currently the tab scroll duration is 200ms. We can adjust the duration to better match the native tabs control.

According to leafy this afternoon this is their second-to-top issue with flutter.

I tried comparing Flutter tab changes with tab changes on some native android applications, like Google Play Music and Google Play News. The difference doesn't seem as noticeable as your example.
See https://youtu.be/6KcMKL6WMRs
On the other hand, your example and the ones in the Material spec appear to animate much more slowly: https://material.io/guidelines/components/tabs.html#tabs-specs
I'll ask for a definitive duration from the Material Design team.

The recommended tab change duration remains on open issue with the Material Design team. Since a resolution doesn't appear to be forthcoming I'll change the duration from 200ms to 300ms. That should  match Android native.
However.  There does seem to be a serious bug with the selected tab indicator animation.  When you tab on a tab the TabBarView's contents, the tab labels, and the tabbar itself (if it's scrollable) animate. The selected tab indicator (the horizontal line under the selected tab) does not.  The indicator is the most noticeable part of the tab bar animation and instantaneous is definitely too fast.

Personally, I find the TabBar animation to be too slow. When I compare the tab behavior of Flutter, to Twitter (for example), it feels sluggish.
It'd be awesome if there was a way to customize this.


mysql filter fails to parse a partial mysql message

When faced with a fragmented packet, mysql filter fails to parse a mysql message and gives up.
The issue is reproduced with istio-1.1.3 (istio bug), by having php talk to mysql. When the mysql filter is enabled, envoy fails with:
mysql-5f9ff684c-nv5nc istio-proxy [2019-04-24 09:21:32.783][30][trace][filter] [external/envoy/source/extensions/filters/network/mysql_proxy/mysql_decoder.cc:140] mysql_proxy: decoding 16384 bytes at offset 16337
mysql-5f9ff684c-nv5nc istio-proxy [2019-04-24 09:21:32.783][30][trace][filter] [external/envoy/source/extensions/filters/network/mysql_proxy/mysql_utils.cc:149] mysql_proxy: MYSQL-hdrseq 141, len 61
mysql-5f9ff684c-nv5nc istio-proxy [2019-04-24 09:21:32.783][30][trace][filter] [external/envoy/source/extensions/filters/network/mysql_proxy/mysql_decoder.cc:13] mysql_proxy: parsing message, offset 16341, seq 141, len 61
mysql-5f9ff684c-nv5nc istio-proxy [2019-04-24 09:21:32.783][30][trace][filter] [external/envoy/source/extensions/filters/network/mysql_proxy/mysql_decoder.cc:136] mysql_proxy: msg parsed, session in state 9
mysql-5f9ff684c-nv5nc istio-proxy [2019-04-24 09:21:32.783][30][trace][filter] [external/envoy/source/extensions/filters/network/mysql_proxy/mysql_decoder.cc:160] mysql_proxy: offset after decoding is 16402 out of 16384
mysql-5f9ff684c-nv5nc istio-proxy [2019-04-24 09:21:32.783][30][trace][filter] [external/envoy/source/extensions/filters/network/mysql_proxy/mysql_decoder.cc:140] mysql_proxy: decoding 16384 bytes at offset 16402
mysql-5f9ff684c-nv5nc istio-proxy [2019-04-24 09:21:32.784][30][info][filter] [external/envoy/source/extensions/filters/network/mysql_proxy/mysql_filter.cc:57] mysql_proxy: decoding error: error parsing mysql packet header
mysql-5f9ff684c-nv5nc istio-proxy [2019-04-24 09:21:32.784][30][trace][filter] [external/envoy/source/common/tcp_proxy/tcp_proxy.cc:501] [C37] upstream connection received 105729 bytes, end_stream=false

after which the connection stalls and php times out.
Here's the last packet forwarded by envoy:

The 16402 points at the end of the last full message:

This PDU is split in half between the TCP packets and that, I guess, causes the mysql filter to flip out.

The overflow happens here. The assumption is that the new offset is the whole parsed len but in the case above the len would point past the data as the tail of the PDU is in the next frame. Looking at it I don't see a clear way to communicate to the upper later that not the whole buffer was consumed.

@venilnoronha Mind taking a look?

The filter doesn't handle messages over 16mb currently. This requires some work around buffer caching. Buffer caching can impact performance, and that's the reason for not implementing it in the first cut.
https://github.com/envoyproxy/envoy/blob/74563b2ba203cccbf3a07fb4c9d832ba94eb569a/source/extensions/filters/network/mysql_proxy/mysql_decoder.cc#L164-L165

there might be a typo then as the packet is only 16 KB long – which makes this filter rather useless for any serious payload...

Also the docs you linked talk about the PDU size (the mysql packet) whilst this is a problem with the TCP fragmentation, the PDU in this example is merely bytes long.

What version of MySQL are you running?

it's mysql 5.7.14.
Just to be sure we're on the same page – how is that relevant?
The existing code implicitly trusts the user input and seeks the buffer to the user-provided value. That's very similar to openssl's heartbleed; thankfully not exploitable by the defensive programming on the buffer side.
In general you shouldn't expect any PDUs to be perfectly aligned to the TCP frames. This particular bug could be workarounded by saving the number of the extra bytes to read and seeking past them in the next incoming buffer (as you don't care about the payload) but it will only mean it's going to break in some other part of the state machine. This code needs to be taken back to the design board as you only hit a bunch of use cases while disregarding the others.
I totally understand that it's an alpha feature and as such there are no expectations. Unfortunately it leaked into the stable release of istio (which is – obviously – not your problem) and will affect more and more people.

Yea I see the problem here, and should be independent of the Mysql version. venil let’s spend some time together to see how to fix it.
Deepa

On May 1, 2019, at 6:43 AM, Vladimir Pouzanov<EMAIL_ADDRESS>wrote:
it's mysql 5.7.14.
Just to be sure we're on the same page – how is that relevant?
The existing code implicitly trusts the user input and seeks the buffer to the user-provided value. That's very similar to openssl's heartbleed; thankfully not exploitable by the defensive programming on the buffer side.
In general you shouldn't expect any PDUs to be perfectly aligned to the TCP frames. This particular bug could be workarounded by saving the number of the extra bytes to read and seeking past them in the next incoming buffer (as you don't care about the payload) but it will only mean it's going to break in some other part of the state machine. This code needs to be taken back to the design board as you only hit a bunch of use cases while disregarding the others.
I totally understand that it's an alpha feature and as such there are no expectations. Unfortunately it leaked into the stable release of istio (which is – obviously – not your problem) and will affect more and more people.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

/assign @venilnoronha


Support file URLs via API

It should be possible to pass URLs in the form file:// to Cog's API. This is for the case where you're calling the API locally, or if you're using local storage or network block storage for efficiency.
The complexity is you'll need to mount that directory as a volume in the Docker container, so it'll need some "warning this doesn't work as you expect!" documentation.

This is a useful feature, especially for local tests.


UI: Course cherry-picking

This feature will make the tool more useful by allowing the user to explicitly select which courses he/she wants to see. This can be helpful in many instances. For example when a student only wants an overview of completed courses and its outgoing neighbors to see which courses depend on those courses and he/she is prepared to enroll in.
This could simply be in the form of a widget like an autocomplete input box.
https://vuetifyjs.com/en/components/autocompletes/
Something like:
<v-autocomplete
  v-model="courses"
  :items="filteredCourses"
  label="Search courses..."
  multiple
  chips
  cache-items
  hide-no-data
  hide-details
  ...
</v-autocomplete>

We would have to create a new data property filteredCourses to keep track of the courses that match the dropdown filters, and then only allow for these courses to be searched for in the autocomplete. This of course requires that we change the API and add function(s).
Slots will help us with customizing how the selected items appear vs. selectable items

Decided to implement a cherry picking of filtered courses, such that the user can only search among the courses that match the filters.


Create a SkyBox

With this, we can add support for HDR cube maps based skys. We also need to support the new SkyAtmosphere, so we can see the sun.

We are not going to add this in this project.


How do you ensure a global is being set to child components from mount?

I am mounting an instance of a component and I am setting the globals, when the component is rendered the child components dont have the global available. Am i missing something or doing it wrong?
I have tried
mount(component, { globals: { $myref: 'xxx' }});

and
const instance =  Vue.extend();
options.instance.prototype.$myref= 'xxx';
mount(component, options);

and
const instance =  Vue.extend();
options.instance.prototype.$myref= 'xxx';
options.globals = { $myref: 'xxx' };
mount(component, options);

in all the mounted component has $myref
but the child always shows undefined.
Any ideas or help would be great.
Thanks

Is the child component created with Vue.extend? If so then this library doesn't support adding globals. I recommend using @vue/test-utils instead.


Firecracker integration

It would be cool to use the Firecracker Go SDK to be able to launch a Sat instance inside a microVM, but it is fairly involved and so will need more research.

Unless I'm missing something, you'd need to set up your firecracker image to contain the sat binary and listen to a predefined virtual socket - then from outside the microVM you'd need to connect to that socket and issue commands.
We have some stuff for doing that in the works already, maybe we could tweak it to be generic to the application and you could just slot it in.

@ShivanshVij Yes exactly right, and we'd need a way to provide a Wasm binary to the microVM as well, unless we baked that into the filesystem.

Or you could just chuck the binary into the virtual socket. I'm pretty sure frisbee would be perfect for this and wouldn't even require too many changes


Progress bar/stats ?

Neat and clean library.
But are any upload progress stats or a progress bar data available ?
For large file uploads, a progress bar/stats and upload speed stats become kind of necessary.

upload progress can be implement separately.
here is an example ( https://www.sitepoint.com/tracking-upload-progress-with-php-and-javascript/ )


Remove UnivariateFinite stuff, replacing with CategoricalDistributions.jl dependency

Known to break MLJEnsembles and testing of MLJTuning because we have effectively removed average for UnivariateFinite objects and arrays. Instead these repos should use Statistics.mean after https://github.com/JuliaAI/CategoricalDistributions.jl/issues/10 is resolved.

Codecov Report

Merging #688 (60fd950) into for-0-point-19-release (869dbb3) will decrease coverage by 3.19%.
The diff coverage is 88.88%.

@@                    Coverage Diff                     @@
##           for-0-point-19-release     #688      +/-   ##
==========================================================
- Coverage                   86.12%   82.92%   -3.20%
==========================================================
  Files                          41       38       -3
  Lines                        3682     2893     -789
==========================================================
- Hits                         3171     2399     -772
+ Misses                        511      494      -17

Impacted Files
Coverage Δ

src/interface/data_utils.jl
86.66% <75.00%> (-5.14%)
:arrow_down:

src/MLJBase.jl
100.00% <100.00%> (ø)

src/data/data.jl
92.22% <100.00%> (-1.42%)
:arrow_down:

src/sources.jl
70.00% <0.00%> (-18.00%)
:arrow_down:

src/composition/models/transformed_target_model.jl
84.90% <0.00%> (-15.10%)
:arrow_down:

src/data/datasets.jl
86.84% <0.00%> (-13.16%)
:arrow_down:

src/measures/continuous.jl
89.13% <0.00%> (-7.17%)
:arrow_down:

src/show.jl
29.92% <0.00%> (-6.72%)
:arrow_down:

src/measures/measures.jl
68.29% <0.00%> (-5.40%)
:arrow_down:

src/measures/probabilistic.jl
58.46% <0.00%> (-4.70%)
:arrow_down:

... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 869dbb3...60fd950. Read the comment docs.


Migrate /product-design-sprint/guide/understand

https://thoughtbot.com/product-design-sprint/guide/understand

[ ] Migrate any content we want to preserve
[x] Add a redirect to thoughtbot.com

Redirect added to https://github.com/thoughtbot/thoughtbot.com/pull/2674

I confirmed there was no further copy that needed to be migrated over.