Add support for gradient color in Bar progress

Adds possibility to set Bar color to gradient using
react-native-linear-gradient.
New gradient property was added to Bar property list to describe
gradient color.

Sorry for the very slow review, but I'm a bit hesitant to add a dependency with a native component.

I don't think that there is another way of getting gradients in NR efficiently then through native components.

how exactly can I use the gradient property in the Progress.Bar tag? without any animation.
Thank you.

Here's a way to do it in Windows 7 http://fav.me/d2rzppj
Replace uifile42 in shell32 with this code:
<element background="Gradient(argb(255, 139, 155, 181), argb(255, 152, 167, 188), argb(255, 86, 100, 113), 3)"

Hey @dluksza
thanks for the pull request, can you provide an example of its implementation
Best Regards

Hello @HasnAr
class SomeComponent extends Component {
    progressGradient = {
        colors: ['#d2ff19', '#09cfee'],
        start: {x: 0, y: 1},
        end: {x: 1, y: 0}
    };

    render() {
        return (
                    <Bar progress={this.calculateProgress()}
                         borderColor={`rgba(126, 122, 144, 0.5)`}
                         borderWidth={0.3}
                         useNativeDriver={true}
                         gradient={this.progressGradient}     //<-----
                         borderRadius={10}
                    >
        );
    }

}

I'm rejecting this due to added dependency and complexity of integration. Maybe it's a good package on it's own?

TBH I don't want to fork this project, would prefer to have it here.
How about removing added dependency and adding an optional property that would return progress widget? Then by default it could be a simple view, and if one would need something more advanced (like a gradient) it could be constructed within this callback.

@dluksza Could you please share any example to get the gradient work on the progress bar?

Any updates?

@yarilchenko
Could you provide your fork/branch? I want to use this.  As current latest still not support this progressGradient.


Discrepancies with icons on toolbar

Sorry to add to your workload...but maybe I'm just not understanding the Move | Copy | Scale | Rotate | Pan tool. The title of the tool seem to have nothing to do with what I can achieve with them.
First, the MCSRP tool.

While the tooltip lists 5 different actions, only 3 icons appear, all of which deal with moving items. There is no apparent Scale, Rotate or Pan functions.
The "ScaleRot" tool actually functions, allowing one to Scale and Rotate a graphic, but the tooltips read "Move one Stroke/Group" and "Copy one Stroke/Group"...the tooltips accidentally taken from the Move tool? Copy and paste can be our friend, until it isn't. :-)

Thanks for the report.
the tools are (Move | Copy | Pan)  and  (Scale | Rotate).
This version fixes this (also includes the other fixes already committed)
ppInk_hints.zip

@PeteCrowe
Can we consider this as closed ?

My apologies for not responding sooner. There are still issues, some related to the tooltips, others that I've newly discovered, but still relevant to the Move | Copy | Pan (P) and Scale | Rotate (S) tools.
When in the Scale | Rotate tool, with the two tool fly-out displayed, the ToolTips over the Scale and Rotate tool are incorrect, displaying the tool tips from the P tool instead of the S tool (see image). In addition, if I have that tool fly-out displayed from the S tool, and I want to change tools, say doing a mouse click on the P tool, the tool pop-out does not change to reflect the change of tool. Clicking the P tool still displays the S tool pop-out. This only applies to the P and S tools. If I have the S tool fly-out displayed, and I attempt to click on the Rectangle (R) tool, the fly-out NOW updates and displays all the variations of the R tool.
Thank you! Happy Holidays.

a copy/paste error : should be good
ppInk fix ScaleRot Hint.zip
Note : this beta also includes a new feature "Extra Pens"

All of the tool tip and flyout issues have been resolved. But now, there is a blank space under the custom pens (I use my menu vertically). Also, I can't access the options dialog anymore. Right clicking brings up a drawing tool and results in pen marks.

The extrapens option was not implemented correctly with vertical toolbar
ppInk extraPens Vert.zip

This now works and the original bug can be closed. Many thanks for your diligence and hard work.


PATCH-2: View/Controller design pattern

Builds on top of #290

Update AppAdmin
Use CircleCI pipeline number as build number
Runtime environment detection (since we are using trunk based development, we cannot rely on env vars to detect the environment)
Move Svgs to separate folder
Refactor page components to use the View/Controller design pattern
Update generator to reflect the new pattern
Page transitions
Refactor content injection (CMS groundwork)
Optimize images based on component size
Calculate static image sizes
Update Readme

[AUTOMATED] Latest version has been pushed to preview.
Preview deployed at https://preview-bae8179.dev.nextjs-boilerplate.jam3.cloud.jam3.net

TIP: To bypass the preview credentials, use this link https://test<EMAIL_ADDRESS>

[AUTOMATED] Latest version has been pushed to preview.
Preview deployed at https://preview-903b4e4.dev.nextjs-boilerplate.jam3.cloud.jam3.net

looking great, I cloned it and played around a bit
found only one more thing @edgardz, the cookie banner is not clickable
maybe we can just add in the $elements array => cookie after pages
and then just @include z-index(cookie)

[AUTOMATED] Latest version has been pushed to preview.
Preview deployed at https://preview-b758c1c.dev.nextjs-boilerplate.jam3.cloud.jam3.net

[AUTOMATED] Latest version has been pushed to preview.
Preview deployed at https://preview-b4579c4.dev.nextjs-boilerplate.jam3.cloud.jam3.net

[AUTOMATED] Latest version has been pushed to preview.
Preview deployed at https://preview-cbf6722.dev.nextjs-boilerplate.jam3.cloud.jam3.net

[AUTOMATED] Latest version has been pushed to preview.
Preview deployed at https://preview-2d16811.dev.nextjs-boilerplate.jam3.cloud.jam3.net

[AUTOMATED] Latest version has been pushed to preview.
Preview deployed at https://preview-6eac162.dev.nextjs-boilerplate.jam3.cloud.jam3.net

[AUTOMATED] Latest version has been pushed to preview.
Preview deployed at https://preview-f03ca4e.dev.nextjs-boilerplate.jam3.cloud.jam3.net

[AUTOMATED] Latest version has been pushed to preview.
Preview deployed at https://preview-b003b7d.dev.nextjs-boilerplate.jam3.cloud.jam3.net

[AUTOMATED] Latest version has been pushed to preview.
Preview deployed at https://preview-9a2c62c.dev.nextjs-boilerplate.jam3.cloud.jam3.net

[AUTOMATED] Latest version has been pushed to preview.
Preview deployed at https://preview-6cff671.dev.nextjs-boilerplate.jam3.cloud.jam3.net

[AUTOMATED] Latest version has been pushed to preview.
Preview deployed at https://preview-7fb89b6.dev.nextjs-boilerplate.jam3.cloud.jam3.net


is the training setting same as default Mask R-CNN 1×training setting?

❓ Questions and Help

Can you expand on your question?
If I understand your question correctly, then yes, the training setting in this repo for Mask R-CNN is the same as the one for Detectron, using the 1x schedule.

Yes, I mean the 1×training setting for MaskRCNN in Detectron. Thank you~


persist saved games & add id to saved game state

save finished games to local storage and reload them on startup
preparation for #103

Hey @maracuja-juice,
Your changes look good to me!
View build log
TravisBuddy Request Identifier: 1e855960-3cdf-11e9-a665-7766e5f56462

The last commit broke the snapshots. Will fix it.

Tests are fixed now.

With the newest version of storybook I run into the following issue on this branch when trying to run yarn storybook:
File '/user/repo/node_modules/redux-persist/es/integration/react.js' is not under 'rootDir' '/user/repo/src'. 'rootDir' is expected to contain all source files

Any idea on how to resolve this @RohrerF?

I was able to solve the above error by moving the rootDir to /.


[stable/datadog] Deprecate stable/datadog

What this PR does / why we need it:
Add deprecation notice for this repository, has been replaced by https://github.com/DataDog/helm-charts accessible at helm.datadoghq.com
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/lgtm


Does this fork include the high-level NEST library?

Is your feature request related to a problem?
I have a customer who would like to use a high-level client like NEST on OpenSearch.
What solution would you like?
A high-level client similar to NEST to be included in this fork.
What alternatives have you considered?
NA
Do you have any additional context?
Just wanted to confirm if this fork includes high-level client like NEST.

Hi @yuwindr, NEST has been included in this repo and has been renamed to OSC (OpenSearch Client) and can be found in https://github.com/opensearch-project/opensearch-net/tree/main/src/Osc.

Thank you for the confirmation @guiangumpac!


Support transactional queries?

Support transactional queries?

See https://github.com/chennaione/sugar/issues/433


Separation of concerns

Separate visualization from test logic, which are mixed up right now.
Architectural proposal: implement observer pattern:
Reporter <- Events - TestRunner
The TestRunner should emit at least the following events:

start
end
error
profileStart
profileEnd
profileError
snippetStart
snippetEnd
snippetError

Done in v1.5.0


Config for ESP32Uno with RM68090 2.8" touch (MCUfriends copy)

Describe the bug
*unable to calibrate simple 4 wire resistive touch *
Device hardware

MCU: ??? ESP32 UNO board (Pins have been changed according to the info in the ESPiTFT library)
Display with link: ??? 2.8" resistive MCU copy (https://www.banggood.com/Geekcreit-UNO-R3-Improved-Version-+-2_8TFT-LCD-Touch-Screen-+-2_4TFT-Touch-Screen-Display-Module-Kit-Geekcreit-for-Arduino-products-that-work-with-official-Arduino-boards-p-1428291.html?utm_source=googleshopping&utm_medium=cpc_organic&gmcCountry=DE&utm_content=minha&utm_campaign=minha-de-en-pc&currency=EUR&createTmp=1&utm_source=googleshopping&utm_medium=cpc_bgs&utm_content=frank&utm_campaign=frank-ssc-de-all-en-0608feed&ad_id=440288844860&cur_warehouse=CN)
GUIslice config selected: ??? ard-adagfx-MCUFriends or ESPi_TFT

Checklist to try first
Most display/touch issues can be identified by working through the steps in the Configuring GUIslice guide. all walkthroughs have been followed and extensive googleing has been carried out to no avail....
Please confirm whether:

Display works correctly with standalone display driver library examples (eg. TFT_eSPI graphicstest, Adafruit graphicstest, etc.) without GUIslice: ??? Display functions perfectly in all manner (both display AND touch) and can be successfully calibrated using examples from MCU Friends library.
Touch works correctly with standalone touch library examples without GUIslice: ???
Touch works using Adafruit Touchscreen demo (raw data from all areas of the screen can be observed via seriell monitor.
Touch pins are as follows: XP: 14, XM: 4, YP: 15, YM: 27 (confirmed via calibration example in MCUFriends library)
All other pins are standard UNO shield layout/ESPuno layout.

Expected behavior
A. I should be able to select MCUFriends 4Wire config file, define touch pins, and screen should function with touch.
or
B. I should be able to configure the ESPi_TFT library, select and configure esp-tftespi-default-simple and display should function with touch
Actual behavior
only a small area of the touch screen is active, and calibration does not work.
Error Message
*using the touch caillibration Sketch provided in GUISlice the error message „rotation not detected, wrong pins“ is shown. Only a small area of the Touch Pad is active and not all boxes can be selected. *
Additional info
*In order for ard-shld-mcufriend_4wire to function, the ADA_simple_touch workarounds need to be copied from GUIslice_drv_tft_espi.cpp and added to GUIslice_drv_adagfx.cpp, otherwise code is unable to compile for the ESP32 due to port names? and pin definitions?
Once completed the display functions, however touch cannot be calibrated. Its as though touch only works on the lower right corner. The best way I can explain it is the touch screen has shrunk, you can select any part of the display, but only from a small area of the touch screen.
The display will also function if GUIslice_drv_tft_espi.h is used, however  DRV_DISP_ADAGFX and DRV_DISP_ADAGFX_MCUFRIEND need to be defined in esp-tftespi-default-simple.h, otherwise display shows only a white screen. (also unable to funtion externally using TFT_eSPI library. (I suspect forcing the display ID could be a workaround for this, but I havent found a way to configure it yet), however the bug remains.
All the ADA_touch_simple workarounds are defined.
Using either configure files with default settings results in a black screen thats pixelated in different colors (I suspect this is due to sharing pins between display and touch, as outlined in the ADA_Simple_touch workarounds). However, ard-shld-mcufriend.h works. *

Problem identified

analogread was not set to 10 bit
RM68090 not supported by TFT_eSPI library

Solution
ESP32 workarounds need to be added to GUIslice_drv_adagfx.cpp (including the following!!)
#if defined(FIX_4WIRE_ADC_10)       analogReadResolution(10);     #endif
(its located much further down on the page, so i missed it the first time when adding the workarounds)
This will allow the code to compile for the ESP32 using DRV_DISP_ADAGFX, DRV_DISP_ADAGFX_MCUFRIEND,  and DRV_TOUCH_ADA_SIMPLE drivers. (target device set to Arduino)
Please implement this to a new config file eg. ESP32_RM68090
I have spoken with the guys from the TFT_eSPI, they have no interest in finding workarounds for this diplay, so I reccomend a config file for this perticular display in conjunction with ESP32 that doesnt rely on their drivers, using the workaround outlined here

@MickTheMechanic -- my apologies as I had overlooked this issue. Not sure if it is still useful for you, but I have now integrated a change into the master branch that auto-detects ESP32 and enables the 10b ADC workaround for the Adafruit 4-wire touch mode.
You did mention that you'd like to see a specific config file for the ESP32 RM68090. If this is still helpful, please attach the version you are working to this ticket so that I can integrate it or see how it differs from existing config files. If further changes are needed to the core GUIslice library for this, please let me know and I'll reopen the issue. thanks!

Hi, yeah its not super important to me anymore, but generally somewhat important nonetheless.
These partictular screens are sold on Banggood and are quite common, but there are no functioning drivers in the TFT_ESPI library, making using them with an ESP32 a bit tricky.
The first problem was regarding touch, but it looks like you have that covered.
The second problem was a custom config was needed. The workaround was to use ard_mcufriends config file, but this means you have to set the target device to Arduino in the builder, and SPIFFS will not be supported.
Im not sure if you want to pursue this further, perhaps a note in the config file outlining the workaround and its limitations would be enough.

HI I am now to this,
I am using ESP32 nodemcu with RP6809 for image display from the SD card could you please help me here


WCAG 2.4.3 focus order - PDF3: Ensuring correct tab and reading order in PDF documents

not applicable to software - related to pdf authorship


When I reproduced your paper,i meet the problem: running build running build_py copying alphapose/version.py -> build/lib.linux-x86_64-3.7/alphapose running build_ext running develop running egg_info error: [Errno 13] Permission denied

When I reproduced your paper, I followed the instructions of your Steps of Installing Activity2Vec and
executed this command line:
cd AlphaPose && python setup.py build develop && cd ..
and the following errors occurred:
running build
running build_py
copying alphapose/version.py -> build/lib.linux-x86_64-3.7/alphapose
running build_ext
running develop
running egg_info
error: [Errno 13] Permission denied
How to solve it?

Please check your folder permission.

Sorry.How to do it in detail?i am a beginner. add the sudo?

i try to add sudo and excute the command line:
sudo python setup.py build develop && cd ..
but the new error appear:
File "setup.py", line 90
[os.path.join(*module.split('.'), p) for p in sources],
SyntaxError: only named arguments may follow *expression
what does it mean? @DirtyHarryLYL

Hi @ydx980521 ,
Thanks for playing with Activity2Vec! The setup procedure of AlphaPose will produce a folder "build" under AlphaPose. The error information means that the folder cannot be successfully created.
Two reasons may cause this: one is the folder permission problem, which can be changed by the chmod command of Linux (you can search for the instructions of chmod in Google ;-) ); second is your disk doesn't have enough space, which can be checked with the df command of Linux.
In the normal situation, this information is unlikely to occur. Thus I believe the latter reason is more possible.


GitHub Actions: Rector Binary Not Found in Workflow

I have Rector already included in my project and configured it in the duster.json file as follows:
{
    "scripts": {
        "lint": {
            "rector": ["./vendor/bin/rector", "--dry-run"]
        },
        "fix": {
            "rector": ["./vendor/bin/rector"]
        }
    },
    "processTimeout": 120
}

Everything works perfectly in my local environment. However, when running this setup in my GitHub Actions workflow, Rector fails to execute with the following error:
sh: exec: line 0: ./vendor/bin/rector: not found
Even though Rector is installed, it seems that GitHub Actions cannot locate the binary. Below is my workflow file for reference:
name: Duster Fix

# Commits made in here will not trigger any workflows
# Checkout Duster's documentation for a workaround

on:
    push:
        branches: [main]
    pull_request:

jobs:
    duster:
        runs-on: ubuntu-latest

        permissions:
            contents: write

        steps:
            - uses: actions/checkout@v4
              with:
                  ref: ${{ github.event.pull_request.head.ref }}
                  repository: ${{ github.event.pull_request.head.repo.full_name }}

            - name: 'Duster Fix'
              uses: tighten/duster-action@v3
              with:
                  args: fix

            - uses: stefanzweifel/git-auto-commit-action@v5
              id: auto_commit_action
              with:
                  commit_message: Dusting
                  commit_user_name: GitHub Action
                  commit_user_email<EMAIL_ADDRESS>
            - name: Ignore Duster commit in git blame
              if: steps.auto_commit_action.outputs.changes_detected == 'true'
              run: echo ${{ steps.auto_commit_action.outputs.commit_hash }} >> .git-blame-ignore-revs

            - uses: stefanzweifel/git-auto-commit-action@v5
              with:
                  commit_message: Ignore Dusting commit in git blame
                  commit_user_name: GitHub Action
                  commit_user_email<EMAIL_ADDRESS>
I would appreciate any assistance in resolving this issue. Thank you!

You may need to update the workflow to install all your dependencies.
See https://github.com/tighten/duster/issues/148 for a similar issue.

The issue has been resolved. It was the same problem as #148.
Thank you!


Identifying User by username produces an Error

According to the docs, one of id, username, email, or ip_address are required:
https://docs.sentry.io/platforms/javascript/guides/react/enriching-events/identify-user/
However, including only a username produces an error due to this line:
https://github.com/getsentry/sentry-php/blob/17588a2a00d2c4f3f55d847cdb5684ee676c4e1e/src/UserDataBag.php#L74

This is in conflict with https://develop.sentry.dev/sdk/event-payloads/user/ which says that You should provide at least either an `id` (a unique identifier for an authenticated user) or `ip_address` (their IP address). @HazAT what's the correct behavior?

If it helps, I can verify that the sentry-python package allows username only. We have been using that as our identifier on python projects and so would like to be consistent and do the same in our PHP projects if possible.

Went ahead and created a PR in case it's determined that username and email are valid identifiers. Thanks for taking a look at this!

@ste93cry docs were not exhaustive enough, so they are not updated from:

You should provide at least either an id (a unique identifier for an authenticated user) or ip_address (their IP address).

to:

You should provide at least one of id, email, ip_address, username for Sentry to be able to tell you how many users are affected by one issue (for example). Sending a user that has none of these attributes (and only custom attributes) is valid, but not as useful.

So UserDataBag.php guard is not necessary and can be safely removed.

3.0.3 was just released fixing this 👍
Thank you for the report, and also for starting the fix 💪


Wrong deconstruction of connect pool

You must close session first, otherwise a normal database will keep the session alive until its timeout reaches.

Sorry, not sure what is the problem exactly, destroying a session should close it too. Which backend exactly do you use where it doesn't happen?
P.S. Please copy paste text and not screenshots for illustrating your point, TIA.

Sorry for this mistake


Fix indentation

Got this warning when compiling with GCC6. Seems like the file had some misleading indentation. :-)
mbedtls-2.2.1/library/x509_crl.c: In function ‘mbedtls_x509_crl_parse’:
mbedtls-2.2.1/library/x509_crl.c:508:5: warning: this ‘else’ clause does not guard... [-Wmisleading-indentation]
else
^~~~
mbedtls-2.2.1/library/x509_crl.c:514:9: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘else’
if( ret == 0 )
^~

Thank you, Kai!


Avoid token reentry attacks

Avoid token reentry attacks, like AMP token.

Hey @wenzhenxiang - thanks for the PoC of reenty protection. We have implement a complete version on #132 therefore we gonna close this pull request!


Updated configuration to reflect latest retry policy limits

@swylezol,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@swylezol : Thanks for your contribution to the Azure documentation! The author, @jeffhollan, has been notified to review your proposed change.

#sign-off

@jeffhollan Hi Jeff, please review or approve? Thanks!

#sign-off

@swylezol - The author has approved your proposed changes. Please resolve the merge conflict so the changes can be merged. Thanks


Disable condition on checkstyle step and add skip variable.

This PR disables the conditional step on the checkstyle step. The effect is that it will now happen during a PR which will increase PR validation time. I also added a condition on the whole analyze job which allows us to skip it. You can't skip it during PR validation, but it means if a problem in say Cosmos is blocking the release pipeline for KeyVault that we can skip over it should we need to. I've started doing this in the few places to allow for some breakglass options in the future.

/cc @Azure/azure-sdk-eng

/azp run java - core


C Bindings show incorrect behavior in certain circumstances when dropping structs

OS: Devuan 2.0-Beta ("ASCII") Linux
Language: C
Compiler: GCC v6.3.0 (Debian Version 6.3.0-18)
Version: livesplit-core v0.9.0
Issue: livesplit-core's c bindings show incorrect behavior in certain circumstances when dropping structs.
Example Code:
#include <stdio.h>
#include "livesplit_core.h"

int main(void){
  ParseRunResult result;
  FILE *f;
  Run run;
  char *p = "path/to/lss/file"
  f = fopen(p, "r");
  res = Run_parse_from_file_handle(fileno(f), p, true);
  ru = ParseRunResult_unwrap(res);
  fclose(f);
  /* Error Arises here */
  ParseRunResult_drop(res);
  printf("%s\n", Run_get_category(run));
  Run_drop(run);
  return 0;
}

Steps to Reproduce:

Put the above file in a c file, making sure that the c bindings for livesplit core are findable by your compiler
Replace the path string with a path to any given lss file that has a category.
Compile with GCC dynamically (I specifically used gcc main.c -o test.exe -llivesplit_core)
Run the executable.

Expected Behavior: Program should print the category to the terminal, and then exit.
Actual Behavior: Program prints out the category to the terminal, and then segfaults.
Additional Information: The code above is only  sample to reproduce the bug. I ended up finding this bug by other means. The bug also only seems to happen IF you drop the results and run. If you do one, but not the other, it doesn't cause an error. Further the order in which you do it is also important, along with if there is a print statement or not.
Removing the print statement results in a coredump with the error: free() invalid pointer, assuming you drop the ParseRunResult before you drop the Run. If you drop the Run before ParseRunResult, then it coredumps with corrupted size vs prev size error. If you add the print statement before dropping, it results in the same error (for the most part), with it coredumping with double free or corruption error, the only difference is the value that comes in the error changing (with it being either (out) or (!prev)).
The weird thing is, the Run is still valid as the code initially written shows, as it does print out the value correctly. If this is expected behavior it should be documented, but I highly doubt this is the correct behavior.

I'm closing this issue due to this being correct behavior of the API, just not entirely documented. This is shown in Bug #115 (which was created in response to this bug).


add more SAFETY comments and lint for missing ones in bevy_ecs

Objective
SAFETY comments are meant to be placed before unsafe blocks and should contain the reasoning of why in this case the usage of unsafe is okay. This is useful when reading the code because it makes it clear which assumptions are required for safety, and makes it easier to spot possible unsoundness holes. It also forces the code writer to think of something to write and maybe look at the safety contracts of any called unsafe methods again to double-check their correct usage.
There's a clippy lint called undocumented_unsafe_blocks which warns when using a block without such a comment.
Solution

since clippy expects SAFETY instead of SAFE, rename those
add SAFETY comments in more places
for the last remaining 3 places, add an #[allow()] and // TODO since I wasn't comfortable enough with the code to justify their safety
add  #![warn(clippy::undocumented_unsafe_blocks)] to bevy_ecs

Note for reviewers
The first commit only renames SAFETY to SAFE so it doesn't need a thorough review.
https://github.com/bevyengine/bevy/pull/4835/files/cb042a416ecbe5e7d74797449969e064d8a5f13c..55cef2d6fa3aa634667a60f6d5abc16f43f16298 is the diff for all other changes.
Safety comments where I'm not too familiar with the code
https://github.com/bevyengine/bevy/blob/774012ece50e4add4fcc8324ec48bbecf5546c3c/crates/bevy_ecs/src/entity/mod.rs#L540-L546
https://github.com/bevyengine/bevy/blob/774012ece50e4add4fcc8324ec48bbecf5546c3c/crates/bevy_ecs/src/world/entity_ref.rs#L249-L252
Locations left undocumented with a TODO comment
https://github.com/bevyengine/bevy/blob/5dde944a3051426ac69fdedc5699f7da97a7e147/crates/bevy_ecs/src/schedule/executor_parallel.rs#L196-L199
https://github.com/bevyengine/bevy/blob/5dde944a3051426ac69fdedc5699f7da97a7e147/crates/bevy_ecs/src/world/entity_ref.rs#L287-L289
https://github.com/bevyengine/bevy/blob/5dde944a3051426ac69fdedc5699f7da97a7e147/crates/bevy_ecs/src/world/entity_ref.rs#L413-L415

Definitely on board for these changes! I'll done one last review once conflicts have been resolved, but I think this is pretty much good to go.


(SyncWorker_3) [custom_components.solarman.solarman] Querying inverter 2208xxxxxx at x.x.x.x:8899 failed on connection start with exception [ConnectionRefusedError]

Anyone got any idea?
ip adress and serial are 100% correct and ip is pingable and web interface is reachable
Device Information
Serial Number:
Register Key:
Hardware Version:
AEW2-0005-03
Software Version:
4790123201R
Cloud Information
Connection Status:
OK

Got the same error. (deye sun600g3-eu-230)

I never used to have this issue before but lately I've been I've been getting timeouts

Same here, never had an issue before.
This is the error:
This error originated from a custom integration.
Logger: custom_components.solarman.solarman
Source: custom_components/solarman/solarman.py:173
Integration: Solarman (documentation, issues)
First occurred: 12:45:04 (7 occurrences)
Last logged: 12:51:04
Querying inverter xxxxxxxxx at 192.168.x.xxx:8899 failed on connection start with exception [OSError]

Hopefully this will help, debug the issue further:
Logger: homeassistant
Source: custom_components/solarman/__init__.py:35
Integration: Solarman (documentation, issues)
First occurred: 19:02:26 (2 occurrences)
Last logged: 19:03:08

Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/config/custom_components/solarman/__init__.py", line 35, in update_listener
    hass.data[DOMAIN][entry.entry_id].config(entry)
KeyError: 'solarman'


update profile.yaml from createMakefiles

add a check in createMakefiles() that offers to update your profile.yaml for you
inspired by #117
won't be relevant if we opt for #246

not relevant because we opted for #246


Non-aligned loop keyword formatting

I'm very new to Common Lisp, so watch out for incorrect/naive assumptions!
Following on from this issue about the formatting of conditional clauses in loop https://github.com/nobody-famous/alive/issues/130. Just to recap, here's some real code with a hand formatted loop.
(defun lookup (map value)
  (loop for (dst src len) in map
        when (and (>= value src) (< value (+ src len)))
        do (return (+ dst (- value src)))
        finally (return value)))

When I use Alive as a formatter, it indents the when keyword.
(defun lookup (map value)
  (loop for (dst src len) in map
          when (and (>= value src) (< value (+ src len)))
        do (return (+ dst (- value src)))
        finally (return value)))

Trying to work out why these conditional clauses aren't indented to match the rest of the loop.
Digging into the formatting code I noticed that they aren't actually included in the list of loop keywords.
https://github.com/nobody-famous/alive-lsp/blob/763633bbdaf270bd86e532be3f3d63e46cb44cd3/src/format.lisp#L26-L27
Without going on a deeper dive, I'm not sure whether this happens because the when keyword isn't included in *loop-keys* or some other mechanism.
There are quite a few more loop clauses that are also not included: https://www.cs.cmu.edu/Groups/AI/html/cltl/clm/node240.html

As another comparison, here's the "silly" loop example from Practical Common Lisp.

;; Before formatting
(loop for i from 1 to 100
      if (evenp i)
        minimize i into min-even and
        maximize i into max-even and
        unless (zerop (mod i 4))
          sum i into even-not-fours-total
        end
        and sum i into even-total
      else
        minimize i into min-odd and
        maximize i into max-odd and
        when (zerop (mod i 5))
          sum i into fives-total
        end
        and sum i into odd-total
      do (update-analysis min-even
                          max-even
                          min-odd
                          max-odd
                          even-total
                          odd-total
                          fives-total
                          even-not-fours-total))

;; After formatting
(loop for i from 1 to 100
        if (evenp i)
        minimize i into min-even and
        maximize i into max-even and
        unless (zerop (mod i 4))
        sum i into even-not-fours-total
        end
        and sum i into even-total
        else
        minimize i into min-odd and
        maximize i into max-odd and
        when (zerop (mod i 5))
        sum i into fives-total
        end
        and sum i into odd-total
      do (update-analysis min-even
                          max-even
                          min-odd
                          max-odd
                          even-total
                          odd-total
                          fives-total
                          even-not-fours-total))

Getting the nested indentation correct between each if/else/when/end seems quite tricky, but it does seem strange for do to be the only clause that is aligned with for.

I would assume this was intentional behaviour, but if not, would you accept a PR that would fix the alignment?

Yeah, I never quite finished that. I got to where the nested if syntax was the next thing to do and decided to work on other features instead.
PRs are welcome. What I tend to do with PRs is try everything I can think of to break them. If it all works fine, then I'll merge it.


xen-tools: Enable QEMU modules

Enable QEMU modules to reduce memory footprint
Signed-off-by: Sergey Temerkhanov<EMAIL_ADDRESS>

Hey @temerkhanov -- I'm going through all of your outstanding PRs this week -- and on this one here's what I'm seeing. After building it with modules enabled, I actually see qemu itself INCREASE in size (not sure what's up with that) by almost one Mb (12353768 currently vs 13271016 with this PR applied).
On top of that, it seems that only 3 things got converted into modules and their size is completely negligible:
$ ls -l usr/lib/xen/lib/qemu/
total 68
-rw-r--r--    1 root     root         14280 Nov 19 19:53 audio-oss.so
-rw-r--r--    1 root     root          5848 Nov 19 19:53 block-dmg-bz2.so
-rw-r--r--    1 root     root         42824 Nov 19 19:53 ui-curses.so

So questions for you: were you expecting more of the things to get converted into modules?
Basically what I'm trying to say is that right now this --enable-modules just doesn't seem to bring any benefit at all. Am I missing something?

This is an experimental PR, the idea was to strip QEMU down step by step.

Understood @temerkhanov -- but I guess my point is that it maybe the case that for us modules are not really worth it anyway. At any rate, how about we add it to kvm-tools and how we build an experimental qemu there and close this PR then?


[TIR] Restrict tir.transform.CombineContextCall to host functions

Previously, the tir.transform.CombineContextCall pass applied to all functions in an IRModule, but was only applied to modules that contain only host functions.  This commit updates tir.transform.CombineContextCall to apply only to host functions.

@tvm-bot rerun


Installation stuck with +apxs2 if php5.load.bak~ exists due to a previous installation

Hi!
I just noticed a weird thing and I thought I mention it.
I have Ubuntu 14.04 LTS and the latest version (1.20.5) of phpbrew. When I try to install a php version for the first time with the +apxs2 modifier everything works perfectly and the installation process successfully completes, but if I try to install and compile another php version with +apxs2 then the installation process "stuck" after the successful build process and after the "Installing..." text appears in the console. The situation is the same if I use the debug mode, I don't get any information about what happening. The installation process just stuck at that point and there is no timeout with error messages as I experienced.
What I figured out is that the above mentioned problem can be connected with the php5.load.bak~ backup file (located in /etc/apache2/mods-available on my computer) which is created before the php5.load file will be modified due to the +apxs2 modifier. So every time when the +apxs2 modifier used, the php5.load file will be modified, therefore a backup file (php5.load.bak~) will be created from it first. What I experienced is that if this backup file exists before a new installation, then the installation process will stuck as I mentioned earlier. But, if I remove the backup file before a new installation then the installation won't "stuck". That's all.
I hope this description will help.

Sorry this mechanism is designed in PHP system, Apache SAPI will modify the php5.load file automatically, this can't be fixed from phpbrew.


Wrong binning of histogram with default thresholds

I use the code in https://bl.ocks.org/mbostock/3048450 with this data
data = [10, 11, 8, 17, 2, 17, 6, 5, 3, 14, 16, 2, 1, 238, 5, 96, 5, 23, 2, 1, 17, 72, 9, 3, 63, 16, 10, 2, 10, 6, 39, 2, 1, 12, 4, 4, 9, 10, 9, 14, 8, 2, 76, 3, 15, 23, 18, 6, 6, 37, 13, 25, 25, 3, 20, 10];
The binning is correct with the original code. But when I remove the line of specifying thresholds .thresholds(x.ticks(20)), the biggest element (238) isn't plotted correctly. I used the latest version of d3 v4 as exactly in the link above.

That example assumes that the bins are of uniform width, which is true if the scale’s domain is niced and you use scale.ticks as histogram.thresholds.
If you don’t specify thresholds of uniform widths, which often happens for the first and last bin when using default thresholds, then you must change the rendering code to accommodate variable-width bins. Instead of:
bar.attr("width", x(bins[0].x1) - x(bins[0].x0) - 1);

You’d say:
bar.attr("width", d => x(d.x1) - x(d.x0) - 1));

I recommend looking at my newer Observable histogram example:
https://beta.observablehq.com/@mbostock/d3-histogram


[vcpkg] fatal_error when patch fails to apply

Continued work from #6578

Quoting from previous pr:

This pr MUST NOT CONTAIN any improvement nor any update to any port. It is just a review of portfiles to make them adhere better to CMake standards and vcpkg's best practices, towards the goal of enabling a FATAL_ERROR for unmerged patches.
Any help is very appreciated, just let me know if you want to participate

Wondering why a change in a common script does not trigger a whole rebuild? @Rastaban
I will continue the work without the support of CI, which I was hoping to exploit

@cenit #6036 (the first change I made when joining this team) was supposed to add that feature but has been sitting idle for a number of reasons. I should get back to getting it done but we're a little overwhelmed getting through PRs right now.

How is this expected to work with source which has already had the patches applied?

I will remove any usage of vcpkg_apply_patches (and we should mark it as deprecated) inside any portfile. That should be enough :)

Not sure what you mean. My point is that we actually apply the patches to the source in the buildtrees and we don't re-download and unpack the source unless we need to. That means if the port gets installed and then removed and then installed again the patches are already applied in the source and the user will get an error.

If the buildtrees folder has been deleted, the error is impossible.
If the buildtrees folder is already there, the hash of source+patch will match and no patch will be re-applied to the same source.
The problem should be non-existent using the most newer vcpkg routines, or am I missing something?
Will check for sure, in any case a solution in possible

I'm wrong and you're right, just actually tried to get patches to apply again and they were skipped no problem. Carry on!

Is this patch ready to merge?

I will remove any usage of vcpkg_apply_patches (and we should mark it as deprecated) inside any portfile. That should be enough :)

What about patches applied to the packaged directory after installation and not the source dir?

They should not have problem until they are valid patches!

Is this patch ready to merge?

Absolutely not. I just reached a green mark, but I think I am at 50%
I do these kind of work in my spare time, so sorry for taking more than expected

They should not have problem until they are valid patches!

Maybe I should shorten the quote to the concern I had:

(and we should mark it as deprecated)

which would also make patches applied to the package dir deprecated.
If not working patches on the package dir are FATAL_ERRORS patching the package dir should be preferred to using string(REGEX REPLACE) manipulations because the patches fail loudly if something changes while the "regex replace" fails silently. I would consider this a nice "feature" of this change

@cbezault just port cleanup. If anyone wants to join me in the effort, he/she is more than welcome!

closes #6137

I'm skeptical that most of these most recent changes are necessary to allow us to FATAL_ERROR on failed patch application...

it's to mark some functions as deprecated (vcpkg_extract_archive and vcpkg_apply_patches), in order to avoid future usage and at the same time avoid current ports to trigger any warning...

@cbezault apart from regressions, which I will fix asap, I think that this PR is getting ready for a final full-rebuild, to verify that patches already applied using modern routines are not failing.
In fact, I mostly touched only ports that had deprecated functions inside portfiles, because those were broken by default in case this PR was accepted, but I had no chance to test ports without dependencies that were touched here (very few i suppose and hope).
I hope that it can be discussed merging this PR very soon, because due to its broad spectrum, it is difficult to keep in sync with master. Also, i think it is vital to this project, now that it's getting traction, to accept only PR without any broken patch, so the sooner the mechanism is in place, the better it is, imho of course.

I am working through regressions (luckily they don't seem too many)
The first one,  3fd, has this error:
    1>C:\VS2017\Stable\MSBuild\Microsoft\VC\v160\Microsoft.CppBuild.targets(425,5): error MSB8040: Spectre-mitigated libraries are required for this project. Install them from the Visual Studio installer (Individual components tab) for any toolsets and architectures being used. Learn more: https://aka.ms/Ofhn4c [C:\vsts\_work\2\s\buildtrees\3fd\x86-windows-all\v2.6.2-c8e9e110eb\3FD\3FD.vcxproj]

I tried to replicate it locally and installing spectre mitigated libs as said by the very clear error message is enough to fix it. Maybe in the new CI machines those are not installed anymore, @Rastaban?

It's going to take a little while to get through all these files and fix the regressions but I'm on it.

as of now there is only 1 regression, pdal, which I cannot also reproduce locally.
I am going to trigger a full rebuild to see if there is some port I am missing.

Seems like you're still working through changes. Let me know when it's time for a review.

I am just trying to fix regressions... but I fear that many of them are just due to the upgrade to CI and ports incompatible with VS2019...

I will let you know when it’s over for me because I cannot fix ports without really touching them deeply. Unfortunately the master is a moving target and so merging with it is always a pain and CI times explode...

/azp run

apart from OTL, I can't reproduce any error locally from the linux point of view. Will inspect osx and win errors later

I can't reproduce any of the regression from the latest completed build on osx too.
Last "offline" checks will be done for windows.
I suspects regressions are due to some misconfiguration of new CI machines (I have not even inspected logs as of now)

That's surprising I haven't updated the osx machines in a whike.

I also can't reproduce regression from very latest build on x64-uwp, arm64-windows and arm-uwp. I don't know what's going on, all the regressions seem false alarms. @Rastaban do you have any idea? I will inspect logs from CI later. Sorry I am very busy in these days

I think I will just inspect logs and then, depending on what I will find, I might just bump control files of those very specific ports regressed at the end of the latest build, to see if it is enough to fix them

Sounds like a good course of action. I think it's time where the team can start spending calories with a deeper investigation of failures than you might have access to. Also Rastaban is out of the office until tomorrow I think.

bumping all the regressions, one by one in order to better understand the problems, was enought to solve most of them. Only one is remaining, the only one that I can reproduce (albeit with a different problem), and it is with pmdk and only in x64-windows.
Locally I have this error:
common.rc(76): error RC2237: numeric value expected at e9154b18ac

I will just try to bump also this one to trigger a rebuild and see what happens. Hoping for the best. In that case, @vicroms, I think that this PR is in the best possible situation for a merge: no regression (or just one...), many many ports fixed along the way (new passes, yay), and patches/upgrades cannot be accepted anymore if they break a patch or do not apply them correctly

I've reviewed all this files. It's a lot and so I might have missed something but it looks good to me.

Thanks a lot @cbezault
I tagged @vicroms because I misunderstood you already changed project
Glad you were still on it :)

I'm still around just winding down.

You cannot escape

I will try my best for that to happen, locking you here inside monstrous PRs


Issue #645 Custom CopilotKit Content solved

Custom CopilotKit Content solved.

Hey @Mayank77maruti, the dev.to link takes me to a 404.

Hi @NathanTarbert sir ,
I have added post on dev.to you check here https://dev.to/mayank_mohapatra/copilotkit-2dik

but donot know why they got my account banned for the posting the same from my previous account

@Mayank77maruti, please leave this Issue open but add your file.
Also, please remove the spaces in the file name and insert a hyphen between (my-custom-content.md)
Give the file a unique name; you can use something like -  name-custom-content.md

Sir i have changed the file name but i didnot get "please leave this Issue open but add your file" that you mentioned.

Sir should i push the changes from a new branch without tagging the issue.

Thank you @Mayank77maruti!

Your most welcome sir.


InvalidOperationException: Cannot resolve scoped service 'Microsoft.AspNetCore.Authentication.Cookies.ITicketStore' from root provider.

Is it possible to resolve a scoped service for use with ITicketStore? For example, if I want to use a DbContext to load the ticket data upon renew.
If not, does that mean I need a singleton DbContext?

ITicketStore needs to be a singleton. What you'd do is inject the IHttpContextAccessor into your store and then per request resolve the DBContext from the already scoped request services container.
Alternatively you could inject the IServiceProvider, create your own scope, and then resolve the DBContext.

Thanks, I was able to get it working with IHttpContextAccessor. I guess I need to get back to blogging because this needs some documentation.


Uncaught Error: The specified module could not be found./?~\AppData\Local\atom\app-1.32.2\res...

[Enter steps to reproduce:]

...
...

Atom: 1.32.2 x64
Electron: 2.0.9
OS: Unknown Windows version
Thrown From: Atom Core
Stack Trace
Uncaught Error: The specified module could not be found.
\?\C:\Users\Darkks\AppData\Local\atom\app-1.32.2\resources\app.asar.unpacked\node_modules\keyboard-layout\build\Release\keyboard-layout-manager.node
At ELECTRON_ASAR.js:166

Error: The specified module could not be found.
\\?\C:\Users\Darkks\AppData\Local\atom\app-1.32.2\resources\app.asar.unpacked\node_modules\keyboard-layout\build\Release\keyboard-layout-manager.node
    at process.module.(anonymous function) [as dlopen] (ELECTRON_ASAR.js:166:20)
    at Object.Module._extensions..node (module.js:671:18)
    at Object.module.(anonymous function) [as .node] (ELECTRON_ASAR.js:180:18)
    at Module.load (module.js:561:32)
    at tryModuleLoad (module.js:504:12)
    at Function.Module._load (module.js:496:3)
    at Module.require (/app.asar/static/index.js:47:45)
    at require (internal/module.js:11:18)
    at customRequire (~/AppData/Local/atom/app-1.32.2/resources/app/static/<embedded>:1:623185)
    at get_KeyboardLayoutManager (~/AppData/Local/atom/app-1.32.2/resources/app/static/<embedded>:14:3073054)
    at get_manager (~/AppData/Local/atom/app-1.32.2/resources/app/static/<embedded>:14:3073134)
    at Object.getCurrentKeyboardLayout (~/AppData/Local/atom/app-1.32.2/resources/app/static/<embedded>:14:3073260)
    at e.keystrokeForKeyboardEvent (~/AppData/Local/atom/app-1.32.2/resources/app/static/<embedded>:14:996407)
    at KeymapManager.t.exports.KeymapManager.keystrokeForKeyboardEvent (~/AppData/Local/atom/app-1.32.2/resources/app/static/<embedded>:11:1224708)
    at KeymapManager.t.exports.KeymapManager.handleKeyboardEvent (~/AppData/Local/atom/app-1.32.2/resources/app/static/<embedded>:11:1222693)
    at WindowEventHandler.handleDocumentKeyEvent (~/AppData/Local/atom/app-1.32.2/resources/app/static/<embedded>:11:282763)

Commands

Non-Core Packages
atom-beautify 0.33.4
atom-bootstrap4 1.4.0
atom-clock 0.1.16
atom-uikit 1.2.2
autoclose-html 0.23.0
emmet 2.4.3
highlight-selected 0.14.0
pigments 0.40.2
uikit-atom 0.3.2

Thanks for contributing!
We noticed that this looks like a duplicate of #14461 so you can subscribe there for updates if you'd like.  Also, if you have an anti-virus program running you can try temporarily disabling it and then reinstall Atom to see if that helps.

Because we treat our issues list as the Atom team's backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn't an exact duplicate but is closely related.
For information on how to use GitHub's search feature to find out if something is a duplicate before filing, see the How Can I Contribute? section of the Atom CONTRIBUTING guide.


The number of steps and collaborators should update on the project card

On the Project sub-app home page, the cards do not display the correct number of collaborators nor the correct number of activities.

Right now, this would create a heavy load on the system, in particular when there are more than 10 projects on the list.
We'll remove the information from the project card for the time being.

Right now, this would create a heavy load on the system, in particular when there are more than 10 projects on the list.
We'll remove the information from the project card for the time being.

To be investigated later.


Enhancement suggestions

Change to transport controls provided by MediaPlayerElement and AreTransportControlsEnabled so that all the system media integration works.
Allow pausing to completely freeze the visualizer output frame including decay, etc. so that the spectrum can be studied at specific points in the playback.
Make the visualizer output be a video stream that can be cast to another Windows 10 PC or external playback device along with the audio.

Thank you for the feedback - will look into it.


fix regression in find_in_workspaces

Fix regression of #713.
This came up in ros/ros#83.

+1

+1


2.3.0 install uses cpu only

[ ] I didn't find a similar issue already open.
[ ] I read the documentation (README AND Wiki)
[ ] I have installed FFMpeg
[ ] My problem is related to Spleeter only, not a derivative product (such as Webapplication, or GUI provided by others)

Description

Step to reproduce

Installed using ...
Run as ...
Got ... error

Output
Share what your terminal says when you run the script (as well as what you would expect).

Environment

OS
Windows

Installation type
Conda / pip

Hardware spec
GPU / CPU / etc ...

Additional context
did not use gpu
https://oss.singchina.com/upload/res.singschool.com/637679332437315016-min.png

Is it possible to use only cpu for prediction？

Tensorflow only works with NVIDIA cards, provided that you have CUDA drivers installed.


Lumen support & refactor

Added supoort for Lumen framework
Added stored_event_job config option. You can redefine HandleStoredEventJob class.
Fixed bad usage of ProjectorStatus model. Removed any hardcode of table name, query builder, etc.
Added .idea to .gitignore

Excellent, thanks!


Set GDA2020 as the default reference frame

Currently, GDA94 is the default reference frame.  On import, files introduced in GDA2020 or other non-GDA94 reference frames will produce a warning. Setting GDA2020 as the default reference frame forms part of a national approach to transition to the new datum from 1 January 2020. See https://www.icsm.gov.au/gda2020 for more details.

This issue has been addressed in commit https://github.com/icsm-au/DynAdjust/pull/35/commits/0a59407411fd19f86fe4bc03240ea5fc41dabbc1


Manually limit memory consumption

Hi,
is it please possible to set a limit on the amount of memory MMseqs2 uses for its computations? Or to set the number of computation chunks?
I know from the MMseqs2 wiki it automatically detects how much memory it can use and eventually it splits database into chunks etc. But this is not practical for grid computing environment where you have to request a specific amount of memory a priori and your job is then executed on a machine which actually has much more memory but it is shared with other jobs. It can then happen that MMseqs2 will consume more memory than allowed just because its available from the system point of view. The queue management software will then kill the job as it exceeded assigned resources.

I just pushed a new parameter --split-memory-limit where you can specify how much memory the split based tools (prefilter, swap...) are allowed to use in megabyte.

Thank you very much for adding this.

I broke something else though, hold on with upgrading just yet.

Now its okay


Add note to README and tutorial on project name choices

Reminds users to avoid creating projects with names like my-nbdev-project that will fail to produce a Python package that can be easily imported

Don't forget to run the command nbdev_install_git_hooks before making a PR, there is a lot of metadata in your notebooks that is removed automatically when you do this (and avoid merge conflicts). Will merge and stripout this PR manually later today if you can't make the change.

Thanks for doing it :)

Thanks for the reminder - for some reason the git hooks were not triggered with GitKraken and I forgot to manually run nbdev_clean_nbs.


Fabric 1.20.1 Client crash after clicking in enchantment table

Required information:

1.20.1 Fabric

eso-fabric-1.20.1-1.0.5.jar

Logs:
https://gist.github.com/pewblaze/fd016fe66bb3761fd5ef38d9d44f2531

Crashlog:
https://gist.github.com/pewblaze/cd5215f75d7cd7f27f0665778043d424

Joined server, opened enchantment table & clicked inside it -> Crash.

Fixed in 1.0.6


Momentum Threat Tracker

May be a v11 issue but when you minimize it, it goes out of sight down and no way to find it other than reloading the page.

Yeah it happens for me too, turning off the UI makes it possible to bring the tracker back but when the module is on it just slides completely off the screen never to be seen again.


Lossless FLAC file format issue

Hello, I've noticed that FLAC file format cannot be played both with OpenSL and Hybrid Player. The issue can be easily reproduced with demo app too. The logcat rise the following exception (running OnePlus 3 stock ROM - Android 6.0):
12-01 22:20:11.765: A/OMXCodec(29344): frameworks/av/media/libstagefright/OMXCodec.cpp:4118 CHECK_EQ( params.nBitPerSample,16u) failed: 0 vs. 16
12-01 22:20:11.766: A/libc(29344): Fatal signal 6 (SIGABRT), code -6 in tid 29529 (ALooper)

Or this (running OnePlus One - CyanogenMod 13):
12-01 22:23:30.848: I/FFmpegExtractor(2182): android-source:0x95e9dcc0
12-01 22:23:30.850: D/FFmpegExtractor(2182): unsuppoted codec(flac) by official Stagefright
12-01 22:23:30.850: D/FFmpegExtractor(2182): ffmpeg detected media content as 'audio/flac' with confidence 0.88
12-01 22:23:30.850: I/MediaExtractor(2182): Use extended extractor for the special mime(audio/flac) or codec
12-01 22:23:30.853: I/FFmpegExtractor(2182): the duration is 00:02:10.61
12-01 22:23:30.853: I/FFmpegExtractor(2182): stream_index: 0
12-01 22:23:30.853: I/FFmpegExtractor(2182): support the codec(flac) disposition(0)
12-01 22:23:30.853: I/hexdump(2182): 00000000:  10 00 10 00 00 00 0f 00  31 0a 0a c4 42 f0 00 57  ........1...B..W
12-01 22:23:30.853: I/hexdump(2182): 00000010:  e4 30 93 c0 95 86 14 10  a8 39 7b 3b a9 d8 5a e1  .0.......9{;..Z.
12-01 22:23:30.853: I/hexdump(2182): 00000020:  97 85                                             ..
12-01 22:23:30.853: D/FFmpegExtractor(2182): bit_rate: 0, sample_rate: 44100, channels: 2, bits_per_coded_sample: 0, block_align: 0 bits_per_raw_sample: 16, sample_format: 1
12-01 22:23:30.853: I/FFmpegExtractor(2182): the time is 00:02:10.61
12-01 22:23:30.853: D/FFmpegExtractor(2182): Reader thread starting
12-01 22:23:30.853: D/FFmpegExtractor(2182): supported mime: audio/flac
12-01 22:23:30.856: I/OMXClient(2182): Using client-side OMX mux.
12-01 22:23:30.926: V/FFmpegOMXPlugin(2182): makeComponentInstance 'OMX.ffmpeg.flac.decoder'
12-01 22:23:30.926: D/SoftFFmpegAudio(2182): SoftFFmpegAudio component: OMX.ffmpeg.flac.decoder mCodingType: 28
12-01 22:23:30.927: A/OMXCodec(2182): frameworks/av/media/libstagefright/OMXCodec.cpp:4129 CHECK_EQ( params.nBitPerSample,16u) failed: 0 vs. 16
12-01 22:23:30.928: A/libc(2182): Fatal signal 6 (SIGABRT), code -6 in tid 2346 (ALooper)

Standard Media Player works without problem. Is this a bug or FLAC are not supported?
Thanks

Hey maybe I'm near the solution but since I'm not so much familiar with your code there is still something I don't understand. I've changed this parameter useLowLatencyIfAvailable = true; (default is false). Now the OnePlus 3 works with .flac file format without issue (at least for now), but on OnePlus One still return the same error on OMXCodec.cpp
So now I suppose that there is a problem while passing audio info between the player and flac decoder, in particular bitPerSample parameter.
I'll try to test this on more devices and see what's happens.
Hope you can clarify my ideas :smiley:

Hi. Thanks for the issue report.
However, I cannot reproduce this on my setup. I guess this might be a specific FLAC files or specific devices issue, so could you upload your FLAC files which can reproduce this?
(NOTE: email me if files should not be available on public)

My test setup:

FLAC files

(16, 24) bit x (16, 22.05, 24, 32, 44.1, 48, 88.2, 96) kHz   (created by Audacity)

Devices

Nexus 5X + Android 7.0 official ROM
Nexus 5 + Android 6.0.1 official ROM

Okay so maybe you have right about device specific issue. Tested FLAC in 16, 24 bit PCM on a Galaxy Nexus running stock Android 4.3 and it works. Upgrade OnePlus 3 to Android 7.0 solve the issue once and for all, Galaxy S6 running Android 6.0.1 also no problem. So there must be something in the OnePlus One and in the older firmware of the 3 that makes crash with FLAC files. Anyway standard media player works always without issue, also PowerAmp and AIMP works always without issue (They have a 10 band equalizer so I suppose they use OpenSL too). So I'm wondering if there could be a workaround for this, maybe skip bitPerSample checks, because as I understand from CM source (https://github.com/CyanogenMod/android_frameworks_av/blob/cm-13.0/media/libstagefright/OMXCodec.cpp @ 4129) the problem is that 'nBitPerSample' param is always 0 whatever file I play. Or, if possible, include a FLAC decoder inside the library itself (I suspect that PowerAmp/AIMP works because this). Let me know what do you think.

Thanks for the investigation! It seems a device specific issue around FLAC format extractor.

So I'm wondering if there could be a workaround for this, maybe skip bitPerSample checks

I am not sure that we can workaround this by skipping nBitPerSample checks, because PowerAmp and AIMP do not use Android framework audio decoder for FLAC format (*).

Or, if possible, include a FLAC decoder inside the library itself

Yeah, this is the most reliable solution. However it requires lots of work to integrate with current implementation of this library...
(*) PowerAmp and AIMP specs

PowerAmp

Using libflac? : Yes
10 bands equalizer: Yes (maybe their original implementation)
Using OpenSL ES: Partially Yes  (it uses AudioTrack by default, but PowerAmp v3 alpha has OpenSL ES option)

AIMP

Using libflac? : Yes (via BASS audio library)
10 bands equalizer: Yes (using BASS FX library)
Using OpenSL ES: Maybe Yes (I can see OpenSL ES message on logcat)


HWKAMP-555 | Enable CommunicationDetailsCache api and implementation to return list for specified id

https://issues.jboss.org/browse/HWKAPM-555
Review notes:

PR assures that in each unit used cache is empty.

@jpkrohling could you please review?

First round finished.

One thing that is missing is the CommunicationDetailsCache.store method doesn't support the function for determining the id to be used. This will be necessary so that the CommunicationDetails with same id will be stored using a key based on the target fragment id.
Not sure how one of the tests work, as the infinispan cache would be have storing two objects with the same id ("id1") so it should have overwritten the first - maybe I've missed something?

@pavolloffay Apart from the few comments I made (and the latest one which can be ignored), LGTM.

@objectiser updated version is here.

@pavolloffay LGTM :+1:


Remove versions before 3.111.0

Currently, only the version 3.111.0 of the polyfill-libraries is in production.
For now, remove any prior versions as they are unused.

Summary of the diff: https://gist.githubusercontent.com/xtuc/5e6a3b5ceee959c9288e8c183844aa8f/raw/91a1ca480cca37eb06e5e183bc6bca36629f6e05/gistfile1.txt, since GitHub can't render it.

LGTM as a comment because GitHub won't let me actually approve:


how to use this package with spatie/laravel-glide ?

Hello!
in my project I use glide this way:
use League\Glide\ServerFactory;
use League\Glide\Responses\LaravelResponseFactory;
Route::get('glide/{path}', function($path) {
    $server = ServerFactory::create([
        'response' => new LaravelResponseFactory(app('request')),
        'source' => app('filesystem')->disk('public')->getDriver(),
        'cache' => storage_path('glide'),
    ]);
    return $server->getImageResponse($path, Input::query());
})->where('path', '.+');

Tell me, please, how can I integrate a spatie / image-optimizer into this scheme?

I'm not using Glide atm and don't know how to hook it in. If you find a good way, please share it here.

I found this solution https://gist.github.com/cron13/1d8892153cbd60200917c452e24f9ce9


64-bit dartium build failing in runhooks on buildbot

The error happened after reverting the build slave to ubuntu precise, and there seems to be a python script missing in the mojo download hook:
_______ running '/usr/bin/python src/third_party/mojo/src/mojo/public/tools/download_shell_binary.py --tools-directory=../../../../../../tools' in '/b/build/slave/dartium-linux-x64-be/build'
Traceback (most recent call last):
File "src/third_party/mojo/src/mojo/public/tools/download_shell_binary.py", line 101, in
sys.exit(main())
File "src/third_party/mojo/src/mojo/public/tools/download_shell_binary.py", line 98, in main
return download(args.tools_directory, args.version_file)
File "src/third_party/mojo/src/mojo/public/tools/download_shell_binary.py", line 49, in download
download_version_for_platform(version, platform, tools_directory)
File "src/third_party/mojo/src/mojo/public/tools/download_shell_binary.py", line 67, in download_version_for_platform
depot_tools_path)
File "/b/build/slave/dartium-linux-x64-be/build/src/third_party/mojo/src/mojo/public/tools/pylib/gs.py", line 31, in download_from_public_bucket
env=env)
@alan-knight @terrylucas

The issue is fixed with cl https://codereview.chromium.org/2378683002/
An equivalent fix was landed against mojo last year in https://chromium.googlesource.com/external/mojo/+/97b3360decaf5d0fa129f67e6648e7b81516d6fb
and we just didn't have it in our copy.

We need to copy gsutil to depot_tools/third_party with
cp -r /b/depot_tools/external_bin/gsutil/gsutil_4.7/gsutil /b/depot_tools/third_party
and then
chmod 775 /b/depot_tools/third_party/gsutil/gsutil
chmod 775 /b/depot_tools/third_party/gsutil/gsutil.py
Then the fix will work.


feat(firestore-bigquery-export): merge partitioning, clustering, wildcard Ids, backup collections & fixes

WIP PR just for review - will be closed and replaced with a new PR with clean commit history

Codecov Report

Merging #890 (e3e3374) into next (3b1cf99) will increase coverage by 0.15%.
The diff coverage is 88.89%.

@@            Coverage Diff             @@
##             next     #890      +/-   ##
==========================================
+ Coverage   50.19%   50.34%   +0.15%
==========================================
  Files          30       30
  Lines        1329     1335       +6
  Branches      197      202       +5
==========================================
+ Hits          667      672       +5
- Misses        661      662       +1
  Partials        1        1

Impacted Files
Coverage Δ

firestore-bigquery-export/functions/src/config.ts
85.72% <83.34%> (-3.17%)
:arrow_down:

firestore-bigquery-export/functions/src/index.ts
100.00% <100.00%> (ø)


Version > 4.8 does not generate WASM module correctly

Bug report

What is the current behavior?
When using a version above 4.8 and if the module is importing multiple JS functions the resulting .wasm module has an invalid structure and the browser will error with expected valid import module name.
If the current behavior is a bug, please provide the steps to reproduce.
The following example builds fine using 4.8 but not when using the latest:
https://github.com/rustwasm/wasm-bindgen/tree/master/examples/console_log
If you comment out the additional #[wasm_bindgen] on the console log binding functions so only one is being included the module will build correctly.

What is the expected behavior?
The generated module should be valid for a browser to understand.

Other relevant information:
webpack version:  4.10
Node.js version: 10.0.0
Operating System: Mac OS 10.13.4
Additional tools: Firefox Nightly, Rust Nightly, wasm-bindgen 0.2.11

Does it work using 4.9? We introduced a mangle feature in 4.10 IRC which causes that error.

Yes 4.9 - works

see #7487

The console_log example works now.


Savers with Ledger

Savers with Ledger
Hello,
the savers of my ledger are not being displayed, even if I click on the Ledger box.
Also in my wallet it is not being displayed. In both cases I clicked on refresh

Windows 11 latest Asgardex app 1.20.4
regards

@Solipsos 1.20.5 was released that has updated savers view logic. Please give that a try and let me know.

We have tested with BTC and there is an error where it is not getting the correct address when trying to do a tx.
Suspect the blank client created within the ledger logic is being used instead of the ledger address.

Will look to fix in the next release.

ETH Works but

you need to have blind signing enabled on ledger and you need enough eth in your keystore to pay for the gas because it currently looks at your keystore address instead of the ledger address for gas. Another issue that needs to be fixed.

working. am able to see keystore and ledger savers positions.


TypeScript: "Go to definition" stopped working after the latest update

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.75.1
OS Version: MacOS Montrey 12.6 (21G115)

Steps to Reproduce:

Start a TypeScript project
Configure a tsconfig and install a local version of TypeScript (I'm using the 2.6.2)
Click on {} in the bottom-right corner, then select the TypeScript working area version (the bug is not present with the TypeScript vscode version)
Right click a method call (or any TypeScript object) and select "go to the definition"
(alternative) CMD + click on a method call

However, the IntelliSense results correctly working as it completes the method names, and leaving the mouse over a method it shows me the signature. But "go to definition" doesn't work and if I hover the method while pressing CMD the method name is not underlined.

Closing as that TS version is very old and no longer being actively supported for our tooling
It sounds like everything is working with VS Code's TS version, so you either can use that for editor tooling or update your workspace version of TS to a more modern version


feat(pageserver): add aux_file_v2 feature flag

Problem
Added aux_file_v2 to the TimelineMetadata structure. The structure has not been touched for several months so I'm skeptical whether we can really add it there...
The flag cannot be reverted to false once being set. Once the tenant config has try_enable_aux_file_v2 set to true, the write path of AUX file will read this flag and set the timeline to have aux_file_v2 enabled. This flag will be persisted into the index part, so even if the flag got lost in the tenant config, the page server will still proceed with the v2 storage.
Summary of changes
Checklist before requesting a review

[x] I have performed a self-review of my code.
[x] If it is a core feature, I have added thorough tests.
[ ] Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
[ ] If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

[ ] Do not forget to reformat commit message to not include the above checklist

need to fix unit tests, e2e works.

As said on slack, I think for the rollout we can just add it as a per-tenant config, no need to have it in timeline metadata. That would simplify this I think.

@arpad-m The timeline metadata is here to prevent the flag from being accidentally reverted, and also handle branching/history correctly. If the control plane / storage controller can guarantee that the flag won't be flipped, then it's fine to set it as a tenant config. (I can simply rename the current tenant config try_enable_aux_file_v2 to aux_file_v2 and drop all timeline metadata code if we decide to do so.)

I feel the only thing we are uncertain is whether we need to persist the aux_file_v2 state. Maybe I can submit a pull request with only tenant config change to unblock myself, and go back to this discussion later?

Opened https://github.com/neondatabase/neon/pull/7505 instead. We can discuss the metadata change later.


SXWN9000 for text node rule

When I have a rule on text
<sch:rule context="text()">

then the compiled stylesheet generates a warning
Warning at char 7 in xsl:apply-templates/@select on line 142 column 66 of stage-3.xsl:
  SXWN9000: The child axis starting at a text node will never select anything
Warning at char 11 in xsl:apply-templates/@select on line 142 column 66 of stage-3.xsl:
  SXWN9000: The attribute axis starting at a text node will never select anything

Could this be avoided?
Using Saxon <IP_ADDRESS>.

Replacing https://github.com/dmj/schxslt/blob/086a08182532eac7376dceaf191c3046bf498542/src/xslt/compile.xsl#L258
with something like
          <call-template name="schxslt:handle-attr-and-children"/>

and relocating xsl:apply-templates into that named template might work in this particular case, although ugly...
Just my quick thought.

This curently works, indeed. But I don't think that this is a viable solution: Saxon issues the warning during static analysis. It might be just a matter of time until Saxon catches up.
Maybe suppressing Saxon warnings alltogether is an option?
If not, we could utilize @use-when and create different paths depedning on the xsl:vendor system property. But this should be the last resort.

Addendum: With queryBinding xslt3 the solution would be xsl:mode on-no-match=shallow-skip. I currently need the apply-templates call b/c the built-in template rule for elements ignores the attribute axis.

No, this is not true. Still need to apply to @* when an element has matched.

Right, the viability depends entirely on Saxon's evolution.
I don't know what the best solution would be... In general I would hesitate to suppress warnings, for fear of overlooking helpful ones.

This problem is solved: SchXslt now uses "ex-post rule match selection" by default. I.e.: The validation stylesheet chains rule templates with xsl:next-match.


[DO NOT MERGE] Remove provider name from event wrapper

NOTE: While this PR is ready for review, it should not be merged until the changes in https://github.com/stacklok/minder/pull/3093 are deployed to production.
Fixes #3071
Final step in the process in migrating over to provider ID instead of provider name.
Summary
Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.
Fixes #(related issue)
Change Type
Mark the type of change your PR introduces:

[ ] Bug fix (resolves an issue without affecting existing features)
[x] Feature (adds new functionality without breaking changes)
[ ] Breaking change (may impact existing functionalities or require documentation updates)
[ ] Documentation (updates or additions to documentation)
[ ] Refactoring or test improvements (no bug fixes or new functionality)

Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist:

[x] Reviewed my own code for quality and clarity.
[ ] Added comments to complex or tricky code sections.
[ ] Updated any affected documentation.
[x] Included tests that validate the fix or feature.
[ ] Checked that related changes are merged.

coverage: 47.855% (-0.02%) from 47.877%
when pulling 172d99446255207eea878d04f0ed38047ca03ade on eiw-remove-provider-name
into 5ed6788e2e2c75edb52a55dee1568815100a25af on main.


Change mock implementation to use store.KVStore instead of maps

Resolves https://github.com/celestiaorg/optimint/issues/134
Apologies for messed up commit history, need to make sure to squash before merging!

Codecov Report

Merging #146 (12dd50f) into main (8a15588) will decrease coverage by 0.40%.
The diff coverage is 57.69%.

@@            Coverage Diff             @@
##             main     #146      +/-   ##
==========================================
- Coverage   57.47%   57.06%   -0.41%
==========================================
  Files          24       24
  Lines        1987     2122     +135
==========================================
+ Hits         1142     1211      +69
- Misses        729      786      +57
- Partials      116      125       +9

Impacted Files
Coverage Δ

state/executor.go
69.44% <ø> (ø)

types/serialization.go
57.47% <0.00%> (-4.26%)
:arrow_down:

node/node.go
52.87% <52.56%> (-6.95%)
:arrow_down:

da/mock/mock.go
75.51% <57.14%> (-24.49%)
:arrow_down:

p2p/client.go
67.97% <57.14%> (+0.50%)
:arrow_up:

p2p/gossip.go
85.24% <91.66%> (+3.42%)
:arrow_up:

node/aggregator.go
68.62% <100.00%> (+1.62%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e58172...12dd50f. Read the comment docs.

@tzdybal I don't see an option for me to assign a Reviewer so pinging you here.


Update to Error Prone 2.17.0

Fixed some minor Javadoc warnings reported by the new version.

Also, from watching the Error Prone tracker, it seems another release may be coming very soon to fix some bugs (see here).  It may be best to just wait for that release and do that update in this PR.

Switching to draft until next EP release comes out

I have permission to change the job names. But let's just wait until after the other fixes go in; no urgency here

@lazaroclapp I think this is ready for a re-review.  Once you approve, I will update the branch protection job names and then land.


feat: migrate from yarn to pnpm

Description
I had to remove the dynamic version ranges from the package.json and pin all the versions, as pnpm updated some of the versions ranges. This broke some tests. Some versions probably did a minor update which was breaking. Fun!
I'd be fine with leaving them pinned, but we can add dynamic version ranges back. I'd use ~ instead of ^, though.
TODO:
We need to determine if using pnpm's node-linker=isolated (which is their default, recommended one) breaks serverless deployments, as written here. Possible workarounds (if it in fact is an issue) could be found here and here.
Another possible workaround, if determined to be an issue, would be to use node-linker=hoisted. The benefit of this would be that we then wouldn't need a workaround for this typescript bug anymore. However, in this exact typescript issue comment, he writes the following (point 5.):
"But that might not be the case; imagine you publish express-app to the npm registry and someone installs it in a project using isolated mode - then express-serve-static-core is not present and it could introduce TypeScript errors on their side!"
So, basically, it could cause issue for people installing payload with pnpm's isolated mode. This is probably not an issue if we keep the workaround I've already included in this PR, though.  However,, isolated mode should be helpful for tackling phantom dependencies when we switch to Workspaces.
If we decide to thus switch to node-linker=hoisted, we should keep the workaround and create a github action which builds the application using isolated mode as well, to verify it still works there,

[X] I have read and understand the CONTRIBUTING.md document in this repository.

Type of change

[ ] Chore (non-breaking change which does not add functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Change to the templates directory (does not affect core functionality)
[ ] Change to the examples directory (does not affect core functionality)
[X] This change requires a documentation update

Checklist:

[ ] I have added tests that prove my fix is effective or that my feature works
[X] Existing test suite passes locally with my changes
[X] I have made corresponding changes to the documentation

Merged into 2.0 with e24ad67168e06e28683ce448869f65fdb3001773


google img tags

Additional google tags for image https://support.google.com/webmasters/answer/178636?hl=en
title, geo_location and license

Looks good to me but I’d prefer having the property called image.geoLocation instead of image.geo_location to stay with camel case.

I've fixed camel case for geoLocation.

Thanks!


[SMD-500] implement the new validation

Change description

creates tables as a root level package outside of the main application code that leverages pandera for pd.DataFrame validation

tables implements a class TableSchema used to define a table's ID tag, columns, error messages and extraction parameters

TableSchema implements two public methods - extract and validate

extract can be passed a "worksheet" in the form of a pd.DataFrame and any tables marked with the relevant ID tag will be extracted and returned

validate can be passed extracted tables, which are then validated against using the types and pa.Checks defined in the TableSchema.columns

TableSchema.messages will need to be passed in order for validate to return messages depending on the type of error raised, these messages can be mapped to either an error type or an error type and a column. This allows for messages to be defined at either table scope or column scope for each type of error.

[X] Unit tests and other appropriate tests added or updated

[ ] README and other documentation has been updated / added (if needed)

[X] Commit messages are meaningful and follow good commit message guidelines (e.g. "FS-XXXX: Add margin to nav items preventing overlapping of logo")

How to test

scripts/new-validation.py has been added with an example use case that can be modified and experimented with for testing etc

Screenshots of UI changes (if applicable)

Outstanding considerations:

behaviour of the TableSchema may be unstable if attributes are modified post-init. Thinking that it's either best to make sure this is robust, with the use of properties and setters or to just make the object instances "immutable"
pa.validate carries out validation and type "coercion", but if there are any errors then it doesn't return the coerced table. This means that downstream processes may have to use a mix of correctly types tables and some that are all str/pd.object.. this doesn't immediately seem to be an issue because our current transformation layer returned all columns as strings but this may mean that further downstream validation checks need to consider that columns may not be typed accurately (e.g. ints are still strings) OR we need to ensure that all tables are coerced that are returned from TableSchema.validate even if there are validation errors


[BugFix] Only log create task run status log when it's not rejected and created

Why I'm doing:

TaskRun's state will be always PENDING in follower if it's merged in leader

What I'm doing:

Update follower's state to SUCCESS, otherwise the merged task run will always be PENDING.

TODO: 1. add a MERGED state later. 2. support batch update to reduce the number of edit logs.
Fixes #issue
What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

branch-3.1 https://github.com/StarRocks/starrocks/pull/43052


[APPM-1299] CSS issue in both store and publisher

Reference: https://wso2.org/jira/browse/APPM-1299

Not related to IoT server, hence closing the issue.


Delete .validation

Removing this file in a separate PR as suggested in #60574

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[n/a] Have you validated your manifest locally with winget validate --manifest <path>?
[n/a] Have you tested your manifest locally with winget install --manifest <path>?
[n/a] Does your manifest conform to the 1.1 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

cc @denelon @ryfu-msft


More breakages on master

Compilation error is:
file:///C:/Users/Kent/Repository/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_advanced_networkimage-0.5.0-alpha.3/lib/src/transition/transition_to_image.dart:254:33: Error: The argument type 'void Function(ImageInfo, bool)' can't be assigned to the parameter type 'ImageStreamListener'.

 - 'ImageInfo' is from 'package:flutter/src/painting/image_stream.dart' ('file:///C:/Users/Kent/Repository/flutter/packages/flutter/lib/src/painting/image_stream.dart').
 - 'ImageStreamListener' is from 'package:flutter/src/painting/image_stream.dart' ('file:///C:/Users/Kent/Repository/flutter/packages/flutter/lib/src/painting/image_stream.dart').
Try changing the type of the parameter, or casting the argument to 'ImageStreamListener'.
    _imageStream.removeListener(_updateImage);

                                ^

Fixing this - will PR shortly.

any updates on this ? I am waiting for this change

I'm waiting for this update fix to be pushed too so I can build my project again.  Tried to reference the fixed branch, but having problems putting the PR in my yaml because the branch name has a forward slash in it and can't figure out how to refer to it.  Here's what I tried:
flutter_advanced_networkimage:
    git:
      url: https://github.com/kentcb/flutter_advanced_networkimage.git
      ref: fix/104

I've tried putting it in quotes or replacing the / with / but that didn't work.  Any advice, or should I just wait for the official PR?  Thanks.

I will fix this asap.

@Skquark Interesting that the ref doesn't work for you because that's exactly what I'm using to get around this. I'm on Windows - perhaps that is a factor.

I get the following after the latest fix:
flutter: Error caught by Crashlytics plugin:
flutter: package:flutter/src/widgets/framework.dart 1101:9                                    State.setState.<fn>
package:flutter/src/widgets/framework.dart 1127:6                                    State.setState
package:flutter_advanced_networkimage/src/transition/transition_to_image.dart 371:5  _TransitionToImageState._catchBadImage
package:flutter/src/painting/image_stream.dart 474:24                                ImageStreamCompleter.reportError
package:flutter/src/painting/image_stream.dart 409:9                                 ImageStreamCompleter.setImage
package:flutter/src/painting/image_stream.dart 709:5                                 MultiFrameImageStreamCompleter._emitFrame
package:flutter/src/painting/image_stream.dart 694:7                                 MultiFrameImageStreamCompleter._decodeNextFrameAndSchedule
```

And the image disappear.

My code looks like this:
```
    return TransitionToImage(
      image: AdvancedNetworkImage(
        url,
        useDiskCache: true,
        timeoutDuration: Duration(seconds: 10),
      ),
      fit: fit,
      duration: duration,
      loadingWidget: placeholder
```

If i just do a immediate return; in TransitionToImage._catchBadImage it seem to work fine..

Ok here is a minimal test case causing an error:
import 'package:flutter/material.dart';
import 'package:flutter_advanced_networkimage/provider.dart';
import 'package:flutter_advanced_networkimage/transition.dart';

class TestApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: TransitionToImage(
        image: AdvancedNetworkImage(
          'https://dummyimage.com/640x4:3/',
        ),
        loadingWidget: TransitionToImage(
          image: AdvancedNetworkImage(
            'https://dummyimage.com/240x4:3/',
          ),
        ),
      ),
    );
  }
}

void main() {
  runApp(TestApp());
}

The error is:
FlutterError
   setState() called after dispose():
   _TransitionToImageState#86abf(lifecycle state: defunct, not
   mounted, ticker inactive)
   This error happens if you call setState() on a State object for a
   widget that no longer appears in the widget tree (e.g., whose
   parent widget no longer includes the widget in its build). This
   error can occur when code calls setState() from a timer or an
   animation callback. The preferred solution is to cancel the timer
   or stop listening to the animation in the dispose() callback.
   Another solution is to check the "mounted" property of this
   object before calling setState() to ensure the object is still in
   the tree.
   This error might indicate a memory leak if setState() is being
   called because another object is retaining a reference to this
   State object after it has been removed from the tree. To avoid
   memory leaks, consider breaking the reference to this object
   during dispose().

@mchome seems like the issue is still present:
/.pub-cache/hosted/pub.dartlang.org/flutter_advanced_networkimage-0.5.0-alpha.3/lib/src/transition/transition_to_image
.dart:303:49: Error: The argument type 'void Function(ImageInfo, bool)' can't be assigned to the parameter type 'ImageStreamListener'.

- 'ImageInfo' is from 'package:flutter/src/painting/image_stream.dart'
- 'ImageStreamListener' is from 'package:flutter/src/painting/image_stream.dart'

Try changing the type of the parameter, or casting the argument to 'ImageStreamListener'.

return oldImageStream?.removeListener(_updateImage);

Error: No named parameter with the name 'onError'.

_imageStream.addListener(_updateImage, onError: _catchBadImage);

And a couple more similar ones.
They all seem to be related to the image stream's methods such as removeListener & addListener.
My flutter doctor, I use beta channel:
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel beta, v1.6.3, on Mac OS X 10.14.4 18E226, locale en-US)

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
[✓] iOS toolchain - develop for iOS devices (Xcode 10.2.1)
[✓] Android Studio (version 3.4)
[✓] VS Code (version 1.34.0)
[!] Connected device
    ! No devices available

! Doctor found issues in 1 category.


Add Travis

Add travis to the repo,
Add lint and flow tests in it.

courtesy https://github.com/nitish24p/react-worker-image/pull/2


bounds property on  does not work

I cannot seem to set the bounds on a GoogleMap component. As far as I can tell you are supposed to set the "bounds" property to be a LngLatBounds object.
As a work around to this I attempted to call the fitBounds function directly once the component had been mounted however the map state did not exist (yet). Is there a event for when the map has initialised?

@TomCaserta I tried using the tilesloaded event on the map and it seems to do the trick, although there's a delay for the update until well, the tiles are loaded. Would be best to be able to set bounds on init, but until that's supported this will do for now.
<GoogleMap
   ref="map"
   ...
   onTilesloaded={this.tilesLoadedHandler} >
</GoogleMap

@solace option one is what i am using and works well until the parent is rerendered... any solution to that?

@mmahalwy : Does this help: https://gist.github.com/solace/edfade8f48ce03de5ef9a1221e1c26b2 ?

We're going to look into this shortly. Close for now
We're also looking for maintainers. Involve in #266 to help strengthen our community!

@solace anyone knows a better solution? I'm looking at how to solve the same issue, and there is no docs for doing proper fitBounds with your current markers in a markerClusterer.

It wasn't meant to be a complete solution, just point people in the right direction.
You may have to take a look inside the lib in node_modules to figure out what will work for you.  Those same files will also have the functions so you can see what params they need you to pass in.  If it helps, grep for the functions used to find file they're in.
Based on how you're implementing it, you will also need to dump your objects to see what values are available to you.  It took me some trial and error to find the right combination, which is why the gist says 'YMMV'.
Good luck.

@solace, your rebuildMarkers function looks like this now (and works):
rebuildMarkers(markers) {
    const newBounds = new google.maps.LatLngBounds();

    if (markers.length) {
      const latLongMarkersArray = map(markers, m => pick(m, ['longitude', 'latitude']));
      each(latLongMarkersArray, (marker) => newBounds.extend(new google.maps.LatLng(marker.latitude, marker.longitude)));
    }

    let newState = {
      center: this.state.center,
      zoom: this.state.zoom
    };

    if (newBounds && this.refs.map && this.refs.map.fitBounds) {
      this.refs.map.fitBounds(newBounds);
      const newCenter = newBounds.getCenter();

      newState = {
        center: {
          lat: newCenter.lat(),
          lng: newCenter.lng()
        },
        zoom: this.state.zoom
      };
    }

    this.setState({
      center: newState.center,
      zoom: newState.zoom,
      bounds: newBounds
    });
}

I'm glad you found a solution for your problem.
I can't recall at this point, and am not going to go check, but the onChange may have been to handle zoom in/out and dragging of the map to update the positions, otherwise when new markers come in from props, the center and bounds would jump away from where the user had them.
Of course, I could be wrong.

@solace Now is named onCenterChanged.

so.... @tomchentw did fitBounds() get removed from the 'ref'. When I log this.refs.map (after putting a ref on the GoogleMap component I don't see 'fitBounds' anywhere. I can't see the ref in CDM() function, but I see it when I log it in the render portion of the component.

Hello fellas,
how this get closed without any further reading or proper solution?

A year later, still looking for a proper solution as well


Hyprland crashes swiping through workspaces and accidentally use more fingers while swiping

Hyprland Version
 System/Version info
Hyprland, built from branch main at commit bcba3951f45f11245d424274130eb3a0ac790d93 dirty (input: Only limit drag resizes (5164)).
Date: Tue Mar 19 17:03:31 2024
Tag: v0.37.1-22-gbcba3951

flags: (if any)

System Information:
System name: Linux
Node name: Kanto
Release: 6.8.2-arch2-1
Version: #1 SMP PREEMPT_DYNAMIC Thu, 28 Mar 2024 17:06:35 +0000

GPU information:
00:02.0 VGA compatible controller [0300]: Intel Corporation Alder Lake-P GT2 [Iris Xe Graphics] [8086:46a6] (rev 0c) (prog-if 00 [VGA controller])

os-release: NAME="Arch Linux"
PRETTY_NAME="Arch Linux"
ID=arch
BUILD_ID=rolling
ANSI_COLOR="38;2;23;147;209"
HOME_URL="https://archlinux.org/"
DOCUMENTATION_URL="https://wiki.archlinux.org/"
SUPPORT_URL="https://bbs.archlinux.org/"
BUG_REPORT_URL="https://gitlab.archlinux.org/groups/archlinux/-/issues"
PRIVACY_POLICY_URL="https://terms.archlinux.org/docs/privacy-policy/"
LOGO=archlinux-logo

plugins:

Bug or Regression?
Bug
Description
I configured to be able to use 3 fingers to swipe through workspaces.
While swiping through workspaces, hyprland crashes if i accidentally touch the touchpad with a fourth finger.
For this crash to happen, at least 2 workspaces need to be open (otherwise i cannot swipe to the other)
How to reproduce

Launch Hyprland
Open a Window (Workspace 1)
Open another workspace (Workspace 2)
Open any window on Workspace 2, so it doesnt disappear while switching to another workspace
swipe using 3 fingers from Workspace 2 to Workspace 1 (or vice versa)
While swiping, place a fourth finger on the touchpad

Crash reports, logs, images, videos
hyprland.log
hyprlandCrashReport22910.txt

update


Why you don't accept async actions in Redux?

I'm new to Redux, but I was just wondering, why you don't accept async actions in Redux? Why it's our job (developers) to use middleware such as redux-thunk in order to handle async actions? I've written a simple imagination code  of how Redux could (probably) handle both async and sync actions without throwing any annoying error saying: "Actions must be plain objects. Use custom middleware for async actions.", see:
const asyncActionCreator = async ()=>{
    const response = await fetch("https://jsonplaceholder.typicode.com/posts");
    return {
        type: "FETCH_POSTS",
        payload: response
    }
}

const SyncActionCreator = () => {
  return {
        type: "SYNC_ACTION",
        payload: "Just a normal synchronous action"
    }
}

function dispatch(action){
    Promise.resolve(action).then(actionObj => console.log(actionObj))
}

dispatch(asyncActionCreator()) // you can copy the entire code and test it in browser's console, or codepen.
dispatch(SyncActionCreator()) //

With all respect.
Islam.

This is already answered in the FAQ: https://redux.js.org/faq/actions#how-can-i-represent-side-effects-such-as-ajax-calls-why-do-we-need-things-like-action-creators-thunks-and-middleware-to-do-async-behavior


FindElementByAccessibilityId is not implemented in selenium python

selenium python version:3.4.3

Hi @camillake,
Selenium clients are generally written for the web counterpart where Accessibility Id is not relevant. You should use the Appium clients which are the extension of the Selenium ones with more app specific features. For instance, you can use the Appium Python Client to test an app with the Python language binding. They also have a readme section showing how to find element(s) by accessibility id using their library.

I am copying the code from Appium Inspector and pasting in my IntelliJ where I use Java to write my script. I always must modify the Appium notation so that I can write my script using TestNg annotation, like I can't use findEelementByAccessibilty and instead I must change it to find element by id then I copy the id and use it. Is there a library I can use to automatedly use findElementByAccessibilty rather than modify to findElementById?