Contribution guide should point to MDK development guide

I imagine the community will want to contribute to the guidelines. The contributor guide for this repo should point to docs describing how to deal with the mdk files.

Not sure when this was done, but this is completed - contributing section of the docs/design/README.md points to the madoko website.


Fix unexpected Decimal sign behavior from Decimal(sign:exponent:significand:)

Resolves #833. Fixes an issue that caused the initialized Decimal's sign not to match the passed sign when significand is negative. More information in the linked issue.

@swift-ci please test

This would break clients who expect the documented behavior rather than the buggy one. Importantly, there are synchronized changes that would also cause some clients expecting the buggy behavior to break.

Agreed the fix should not revert to the buggy behavior.
The actual fix is to make the RC follow ABI stability to not break existing clients with old toolchains


Enhance about us

Changes
Enhance about us page's code, according to https://github.com/game-ci/documentation/issues/458.

Set default theme based on user preference
Serve & optimize header background image
Refactor sections' structure and update CSS
Increase social icon & avatar size in profile
Update light theme primary color(#2b896a): Not picking a color to fulfill the AA grade contrast as it will further lower the ones with dark background (i.e. footer)
Deprecate some CSS classes
Convert image to Webp
Fix timeline UI in mobile
Standalone team info data

Desktop:
https://github.com/game-ci/documentation/assets/21377181/e174b237-5e52-4d92-9dcc-516c35ec44bf
Mobile:
https://github.com/game-ci/documentation/assets/21377181/10eebbda-c32b-4830-9971-865079b16825
Checklist

[x] Read the contribution guide and accept the
code of conduct
[x] Readme (updated or not needed)
[x] Tests (added, updated or not needed)

Excellent! Thanks for your contribution!


r30gb does not work on Yi Dome 1080p BFUS serial

I am trying to run the hack but the camera won't start. Clearly blue WiFi led is settling on the on state after blinking a few times but the camera does not do calibration.
I received camera today with intent to run custom fw, which I can see is beta. Is there anything worth trying to make it work?
Does it make a difference if I copy r30gb release contents to 32GB SD card formatted using a camera but on Linux?
Obviously after removing SD card camera works fine. Current firmware is <IP_ADDRESS>A_201908271549.

The camera creates log files when WiFi connection is established and Reset is pressed  (names them tar.gz but it is plain tar - I recompressed these after removing my wifi pass):
start_reset.tar.gz
wifi_connected.tar.gz
@roleoroleo I have a suspicion the software version number <IP_ADDRESS>A is more likely to be MStar based on other v4 threads, yet the serial number of the latest model of Dome 1080p (YHS_2016) starts with BFUS pointing to r30gb.
I also tried backup.tar.gz and Factory dir on FAT32 SD did not change name nor backup was created after plugging in power.
Anything else worth trying?
Log files contain list of files/modules.

Please close the issue - my BFUS camera is an MStar model - MStar firmware flashed just fine and works perfectly.


Fix C/Fortran API TPLs dependencies

I believe the README is fine as it is now.
The libmesh adapters also requires MPI, tribits will resolve this at configure time.

What about the new Boost dependency? Don't we need to update the configuration example?

You are right. I submitted a new PR.


feat: use ibm provider for module-metadata generator

Description
Generate metadata-module.json using ibm provider
Check the relevant boxes:

[ ] Bug fix (nonbreaking change that fixes an issue)
[x] New feature (nonbreaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Examples or tests (addition or updates of examples or tests)
[ ] Documentation update
[ ] CI related update (pipeline, etc.)

Checklist

[ ] If relevant, a test for the change has been added or updated as part of this PR.
[ ] If relevant, documentation for the change has been added or updated as part of this PR.

Merge

Merge using "Squash and merge".
Make sure to use a relevant conventional commit message that is based on the PR contents. The commit message determines whether a new version of the modules needs to be released, and if so, which semver number to use).

@akocbek See https://github.com/terraform-ibm-modules/common-dev-assets/pull/197/files#r1004544953


update mapping

Codecov Report
Attention: Patch coverage is 93.54839% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.19%. Comparing base (477b74b) to head (e10dd01).
Report is 1 commits behind head on master.

Files
Patch %
Lines

src/views/location_api.py
92.85%
2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
+ Coverage   77.88%   78.19%   +0.30%
==========================================
  Files           6        6
  Lines         199      211      +12
==========================================
+ Hits          155      165      +10
- Misses         44       46       +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fix Lower Bound of Binary Arrays

This Postgres defaults to 1. See https://github.com/GoogleCloudPlatform/pgadapter/issues/1259

Closing in favor of #1302


SQL Editor: parameters binding improvements

We need to show parameters binding dialog(s) before actual query execute
We need to show actual query text in the dialog (makes great sense for long scripts)

verified


Extract methods

Description of the Change:
Added two new utilities to extract a numerical representation of a circuit from an Engine object: extract_unitary and extract_channel.
The first returns a numerical array that represents a unitary transformation (and it's applicable to the case where in the circuit specification there are only ops of type Gate).
The second returns a numerical array that represents a channel (and it's applicable to the case where in the circuit specification there are only ops of type Gate or Channel).
Both functions support an option to vectorise the indices that correspond to different modes. This makes extract_unitary return a matrix, and extract_channel return a rank-4 tensor (if the option representation is 'choi' or 'liouville') or a rank-3 tensor (if the option representation is 'kraus')
extract_unitary also supports the option backend which can take the value 'fock' (default), which results in a numpy array output, or 'tf' which results in a TensorFlow tensor output.
Benefits:
Now a user can specify a circuit and ask for a numerical representation of the transformation that it represents.
Possible Drawbacks:
What drawbacks? xD
Related GitHub Issues:
None (that I know of)

Great, thanks for the PR @ziofil!
I notice some of the tests are currently failing (https://travis-ci.org/XanaduAI/strawberryfields/builds/498260170?utm_source=github_status&utm_medium=notification). Is this still a work-in-progress, or do you expect to resolve those shortly? If so, we can get started on code review.

Hi Nathan,
Ah, it's because I used f-strings, and you're also checking that the code works for python 3.5
I'll update the code to use the format() syntax.

Ignore the codecov bot for now - the comment will be automatically updated with the correct coverage once the build passes

The remaining issue is that I need to use the Engine's method _add_subsystems(), and it begins with an underscore... I don't see a way out other than refactor the code and make it part of the public interface, but it's probably even worse.

@ziofil, all good - we're okay with ignoring that linting rule :slightly_smiling_face:
Everything looks like it's passing now :champagne:
Will you be adding any more commits, or is it okay to begin the code review?

No, I'm done. 👍

Hi @ziofil, I've done a code review, as well as pushing a small commit to integrate the new functions into the SF documentation, and make sure everything renders correctly (let me know if you think anything should be changed).
It looks really fantastic! Especially the documentation, really in-depth and well covered. I think only a couple of minor commits are needed before it gets merged.

The comments you added to the extract_channel function are great, and will really help with maintainability if someone else is working on this part of the codebase in the future. Do you mind quickly adding similar comments to extract_unitary, or where ever you think they might be useful?

Tests: the test should be modified as per https://github.com/XanaduAI/strawberryfields/pull/48#discussion_r260674838 to correctly allow the environment variables to set the backends. This is something I can quickly do.

Documentation: It would be nice to have a short example in the documentation of usage. Another thing that crossed my mind - do you think defining equations could be useful, for example when discussing the channel representation?

Hi @josh146

sure, no problem, I'll do that.
ok, please go ahead
sure, how would you like the example to be formatted? Something like a doctest?

3. sure, how would you like the example to be formatted? Something like a doctest?

I was thinking something very simple, like Sphinx code-block example at the top of the Engine page in the documentation:
https://strawberryfields.readthedocs.io/en/latest/code/engine.html

What kind of equations do you have in mind? The definitions of channel action like
C(ρ) = tr_A[(ρᵀᴬ ⊗ Iᴮ)Λᴬᴮ]?

Yeah, just something like you have written, that clearly defines the various channels etc.

Is the current version enough, or should I add more?

I was a bit late with my reply, what you have looks perfect :slightly_smiling_face:

I would commit all the minor suggestions myself, but it says I don't have push permissions to the repo 🤔

Just one or two tiny suggestions to commit, but all good on my side :)


Mono Port

Purpose of code changes on this branch: Porting morelinq to the Mono Platform. The Mono Port targets the runtime version corresponding to .NET 3.5. This review request does not treat a possible the Silverlight->Moonlight port.
The existing project solution can be easily opened and compiled with MonoDevelop (v.2.2.x).
MonoDevelop also provides out of the box Integration with NUnit, there is no (!) configuration necessary to run the test project. Simply choose "run element" from the test projects context-menu.
Morelinq does use Warning Level 4 and the "treat Warnings as Errors" options. I advocate this usage. However, it seems gmcs (the Mono C#3.0 compiler) is a little stricter in terms of warnings than Mircosoft's csc.
This causes one error in the MoreLinq main project, which can be easily fixed via supressing
this error. It can be discussed if we should introduce conditional compilation (in this case preprocessing) here, although I don't think it makes much sense yet.
Index: trunk/MoreLinq/Consume.cs
===========================================================
========
--- trunk/MoreLinq/Consume.cs	(revision 151)
+++ trunk/MoreLinq/Consume.cs	(working copy)
@@ -1,4 +1,4 @@
-Ôªø#region License and Terms
+#region License and Terms
 //
 // MoreLINQ - Extensions to LINQ to Objects
 // Copyright (c) 2008-9 Jonathan Skeet. All rights reserved.
@@ -32,8 +32,13 @@
         public static void Consume<T>(this IEnumerable<T> source)
         {
             source.ThrowIfNull("source");
+
+			// Disable Warning CS0219: The variable element is assigned but its value is never

used
+			// This is only necessary when compiling for mono
+			#pragma warning disable 0219
             foreach (T element in source)
             {
+
             }
         }
     }

Porting is more difficult in the testing project. For some reason gmcs does not like the private DisposeTestingSequenceEnumerator class nested in TestingSequnce, it assumes access to the Disposed event would be impossible due to it's protection level (which is wrong IMHO). I will further discuss this problem on the Mono mailing list, however I think it doesn't hurt too much moving DisposeTestingSequenceEnumerator out of TestingSequence and making it a seperate class. I still end up with a CS0067 warning (event not used) on the event, which needs to be fixed.
As a side note, it should be discussed to which naming convention for member variables this code should stick to, at the moment there it is none, making it difficult to separate between method locals and class members. And I think copying the Event variable in Dispose() is unnecessary too.
Index: trunk/MoreLinq.Test/TestingSequence.cs
===========================================================
========
--- trunk/MoreLinq.Test/TestingSequence.cs	(revision 151)
+++ trunk/MoreLinq.Test/TestingSequence.cs	(working copy)
@@ -1,4 +1,4 @@
-Ôªøusing System;
+using System;
 using System.Collections;
 using System.Collections.Generic;
 using NUnit.Framework;
@@ -13,7 +13,56 @@
             return new TestingSequence<T>(elements);
         }
     }
+
+	/// <summary>
+	/// The actual enumerator used by <see cref"TestingSequence(Of T)">.
+	/// </summary>
+	/// <remarks>
+	/// This class should not be used directly. Normally this would have been a private
nested
class of TestingSequence, this breaks
+	/// </remarks>
+	internal class DisposeTestingSequenceEnumerator<T> : IEnumerator<T>
+    {
+        private readonly IEnumerator<T> sequence;

+		// Disable Warning CS0067: The event
`MoreLinq.Test.DisposeTestingSequenceEnumerator<T>.Disposed' is never used
+		// This is only necessary when compiling for mono
+		#pragma warning disable 0067
+        public event EventHandler Disposed;
+
+        public DisposeTestingSequenceEnumerator(IEnumerator<T> sequence)
+        {
+            this.sequence = sequence;
+        }
+
+        public T Current
+        {
+            get { return sequence.Current; }
+        }
+
+        public void Dispose()
+        {
+            sequence.Dispose();
+            var disposed = Disposed;
+            if (disposed != null)
+                disposed(this, EventArgs.Empty);
+        }
+
+        object IEnumerator.Current
+        {
+            get { return Current; }
+        }
+
+        public bool MoveNext()
+        {
+            return sequence.MoveNext();
+        }
+
+        public void Reset()
+        {
+            sequence.Reset();
+        }
+    }
+
     /// <summary>
     /// Sequence that asserts whether its iterator has been disposed
     /// when it is disposed itself and also whether GetEnumerator() is
@@ -46,7 +95,7 @@
         public IEnumerator<T> GetEnumerator()
         {
             Assert.That(this.sequence, Is.Not.Null, "LINQ operators should not enumerate
a sequence
more than once.");
-            var enumerator = new
DisposeTestingSequenceEnumerator(this.sequence.GetEnumerator());
+            var enumerator = new
DisposeTestingSequenceEnumerator<T>(this.sequence.GetEnumerator());
             enumerator.Disposed += delegate { disposed = true; };
             this.sequence = null;
             return enumerator;
@@ -56,45 +105,5 @@
         {
             return GetEnumerator();
         }
-
-        private class DisposeTestingSequenceEnumerator : IEnumerator<T>
-        {
-            private readonly IEnumerator<T> sequence;
-
-            public event EventHandler Disposed;
-
-            public DisposeTestingSequenceEnumerator(IEnumerator<T> sequence)
-            {
-                this.sequence = sequence;
-            }
-
-            public T Current
-            {
-                get { return sequence.Current; }
-            }
-
-            public void Dispose()
-            {
-                sequence.Dispose();
-                var disposed = Disposed;
-                if (disposed != null)
-                    disposed(this, EventArgs.Empty);
-            }
-
-            object IEnumerator.Current
-            {
-                get { return Current; }
-            }
-
-            public bool MoveNext()
-            {
-                return sequence.MoveNext();
-            }
-
-            public void Reset()
-            {
-                sequence.Reset();
-            }
-        }
-    }
+     }
 }

Next two problems are MinBy and MaxBy tests, somehow the extension method on null value usage confuses gmcs and let's it generate a Warning CS1720: Expression will always cause a `System.NullReferenceException'. Our test could not prove any better this warning is invalid ;-)
Index: trunk/MoreLinq.Test/MinByTest.cs
===========================================================
========
--- trunk/MoreLinq.Test/MinByTest.cs	(revision 151)
+++ trunk/MoreLinq.Test/MinByTest.cs	(working copy)
@@ -1,4 +1,4 @@
-Ôªøusing System;
+using System;
 using System.Collections.Generic;
 using NUnit.Framework;

@@ -11,6 +11,9 @@
         [ExpectedException(typeof(ArgumentNullException))]
         public void MinByNullSequence()
         {
+			// Disable Warning CS1720: Expression will always cause a
`System.NullReferenceException'
+			// This is only necessary when compiling for mono
+			#pragma warning disable 1720
             ((IEnumerable<string>)null).MinBy(x => x.Length);
         }

Index: trunk/MoreLinq.Test/MaxByTest.cs
===========================================================
========
--- trunk/MoreLinq.Test/MaxByTest.cs	(revision 151)
+++ trunk/MoreLinq.Test/MaxByTest.cs	(working copy)
@@ -1,4 +1,4 @@
-Ôªøusing System;
+using System;
 using System.Collections.Generic;
 using System.Collections.ObjectModel;
 using NUnit.Framework;
@@ -12,6 +12,9 @@
         [ExpectedException(typeof(ArgumentNullException))]
         public void MaxByNullSequence()
         {
+			// Disable Warning CS1720: Expression will always cause a
`System.NullReferenceException'
+			// This is only necessary when compiling for mono
+			#pragma warning disable 1720
             ((IEnumerable<string>)null).MaxBy(x => x.Length);
         }

I have attached a complete patch. For some reason google code doesn't support patch review, so
don't get confused by the branch stuff.

Originally reported on Google Code with ID 59
Reported by @JohannesRudolph on 2010-04-08 16:51:41

FWIW, I have built current master using MonoDevelop, and ran tests OK. I don't think there is anything left to do here.

I guess some problems just go away after (shamefully) neglecting them for 5 years! :stuck_out_tongue: Credit to @JohannesRudolph for trying.


Add unit tests for Problem

An initial set of unit tests for the Problem module. Can include tests for compute_residual_and_jacobian in a future PR.

Looks good


Rename library to SpanQ

A catchy name is half the work of promotion!
original idea by: https://www.reddit.com/r/csharp/comments/1eoqibi/comment/lhfaz1g/

Hey, I agree it's a catchy name, but I prefer when libraries have clear names that show what they do.

Thank you for the advice!
It's a bit of a hassle to change the name of a library that has already been released, and the name that directly expresses the functionality of being able to use "LINQ" with "span" is a bit simple, but I think it's not bad.
I'll keep this in mind in the future.


Respond with previous URL when a duplicate webmention is detected

When you send a second webmention, Bridgy replies with: Sorry, you've already published that page, and Bridgy Publish doesn't yet support updating or deleting existing posts.
It would help to add a "url" attribute that provides the url of the previous syndication. This would allow me to send webmentions for posts that had previously be syndicated and get the URL of that syndication into my system :)
(Originally published at: https://eddiehinkle.com/2018/07/18/7/reply/)

interesting! good idea. in the short term, you can grab the last 10 publishes from bridgy's API: http://brid.gy/about#api . they're ordered chronologically, descending, so the most recent one will be first.

we'd also have to figure out where exactly to return the url. human readable text messages for 400 errors are currently shared by both webmention and interactive publish, so i can't really change that one to return json. i guess maybe i could return it in the http Location header?

Hmm, interesting. the 400 errors aren't JSON? I guess maybe Telegraph is transforming the response into JSON, because when Telegraph returns the http_body from a bridgy failure, it returns a JSON object with an error attribute.
HTTP location header could work. Might have to tweak Telegraph to return that value to webmention status. Currently it only passes through the http code and body

eddie says API sounds good. tentatively closing. feel free to reopen!


Cannot setup enviroment variables for instagram_basic_display

Hi,
As Instagram changed their API Permissions lately, I am trying to implement the Instagram Basic Display API at one of my Ruby on Rails websites. I have already manually get my first long-lived access token and the next step is to get the media from instagram and find a way to automatically update the long-lived access token within the app. I found your article at ConvertKit really helpful and interesting. I installed your instagram_basic_display gem and tried to follow the guidelines here at github but obviously I face a problem on setting the enviroment variables. Could you please be more specific in which file exactly the enviroment variables should be saved and how it should look like?
Thank you in advance,
Elina

Hi Elina,
You can set environment variables in Ruby apps in several ways:

You can set them in your terminal with export MY_VARIABLE=my_value. Keep in mind that those variables will be stored in your bash history, so you might want to periodically clear them out so that you're not storing sensitive information in your history.

You can define your variables when starting your server. For example, in a Rails application: MY_VARIABLE=my_value rails s. Again, that will stay in your bash history, so be careful to clear your bash history to remove the sensitive variables.

You can use a gem to pick up environment variables. Usually, I use the dotenv gem so that I can set environment variables for different environments in different files (e.g. .env.development for development and .env.production for production). I suggest taking a look at that gem. You would then create a .env file that contains the instagram variables.

If you would prefer another way to set the variables (perhaps just passed into the configuration), you are welcome to create a PR to do that!

Hi Raquel,
Thank you very much for your prompt response. It really helped me to solve
the problem.
Kind regards,
Elina
On Sun, Jul 26, 2020 at 1:56 PM Raquel Moss<EMAIL_ADDRESS>wrote:

Closed #6 https://github.com/ConvertKit/instagram_basic_display/issues/6
.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ConvertKit/instagram_basic_display/issues/6#event-3586977958,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIZHLR5UH56FJCZAWIILWULR5QDWJANCNFSM4PH5KYQQ
.


Add technical spec regarding encoding and data storage

Hi, I tried to verify the build provenance using the cosign tool, but this does not seem to be compatible (yet).
Is there any technical spec regarding how the provenance attestation data is encoded and added to the container registry? From a quick tests, it looks like the the attest-build-provenance action does the following:

The attestation data is added to the OCI v2 registry next to the image manifest (application/vnd.oci.image.index.v1+json for multi-arch images)
The attestation data itself is a sigstore v0.3 bundle (application/vnd.dev.sigstore.bundle.v0.3+json), which links to the image manifest using an OCI Referrer
The payload of the sigstore bundle contains the in-toto statement ( https://in-toto.io/Statement/v1 )
The predicate contains the gh action provenance data as https://slsa.dev/provenance/v1.

For verification, you need to do the following:

get the digest of the container (the manifest / index)
get the referrer by type for the manifest / index

The downloaded data is a sigstore v0.3 bundle, whereby the .dsseEnvelope.payload contains the in-toto Statement v1. The subject hereby points to the image manifest digest. The predicate contains the provenance v1 data and the signature can be checked by verifying the integrity of the DSSE.

Cosign does not yet support Sigstore bundles, but we're using the same spec for storing bundles which will be implemented in cosign at some point.

Thanks for adding the reference to the readme. By that, I'll close the issue.


how call server related methods/functions in nuxtServerInit

Is it possible to do something like this?
actions: {
        nuxtServerInit({ commit }, { req }) {
            const fs = require('fs');
            const content = fs.readFileSync(__dirname + '../package.json');
            console.log('secret');
            commit('SET_USER', content);
        }
    }

Hi @Mirodil
Yes it's totally possible to do that in the nuxtServerInit method 👍

One more question on NuxtServerInit.
When is it called?
On every server side request before fetch and data?
Actually timeline of events (life cycle of the page)  would be very
interesting to find out mire about.
On 17 Jan 2017 09:04, "Sébastien Chopin"<EMAIL_ADDRESS>wrote:

Closed #142 https://github.com/nuxt/nuxt.js/issues/142.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/nuxt/nuxt.js/issues/142#event-925390040, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ABHXrKgPhXTGBbmTf0fPWSm29X9a4e5Lks5rTIQigaJpZM4LlDtP
.

This throws errors to console.
ERROR in ./store/index.js
Module not found: Error: Can't resolve 'fs' in '/Users/mkhojirakhimov/Documents/Projects/
examples/nuxtjs01/store'
 @ ./store/index.js 23:21-34
 @ ./store nonrecursive ^\.\/.*\.js$
 @ ./.nuxt/store.js
 @ ./.nuxt/index.js
 @ ./.nuxt/client.js
 @ multi webpack-hot-middleware/client?reload=true ./.nuxt/client.js

The idea of this framework very good, I like it. But I did not get, Why nuxt.js exposing nuxtServerInit to client side?

Just realized the default webpack configuration for client-side bundles does not specify any external modules. So you may try adding fs module in nuxt.config.js to the list of externals:
build: {
  extend(config, context) {
    if (context.isClient) {
        config.externals = ['fs']
    }
  }
}


Add cases for TimePeriodExtractor & TimePeriodParser in Spanish

Hello, I find the division of a day quite confusing. I've established a different time division than that of the cases already there. Mine is:
por la mañana 8:00-12:00
por la tarde 13:00-20:00
por la noche 20:00-23:59
I don't understand either why the original cases define mediodía as 12:00-16:00. I've checked the Real Academia Española and other resources, maybe it's more like hours near 12:00.
Just a little comment. Thank you!

You are correct. "mediodía" should not be a time range. It should be the same as "noon".
The other definitions follow default ranges that can be configured differently.


IOSOSX-595: Bump version, add distribution name/version

Hi @frankus, thanks for the PR. Would you mind closing this one and opening a new one against the mParticle-Apptentive (https://github.com/mparticle-integrations/mparticle-apple-integration-apptentive) repository?

Done. https://github.com/mparticle-integrations/mparticle-apple-integration-apptentive/pull/1


Websocket is not running, could not able to debug

Hi everyone,
I've implemented websockets with pusher replacement successfully on my system. However sometimes when I am installing it on dev servers it seems, websocket is not starting. Its only showing plain message as 'Starting the WebSocket server on port 6001..." .
I am not able to understand the reasons & don't know how to debug as no error messages are being shown from this package. Can anybody advice?
For your information,
my dev server IP is local network ie. 192.168.X.X  & pusher port 6001.
No SSL etc. Its plain.
SITE_URL/laravel-websockets also not able to connect. So my understanding is websocket is not correctly starting.
Any clue would be great help to me.
Thanks

Already abandoned

Hi Parallels999,
I didn't catch you. Could you please help me understanding.

Hello @skodilkar, are you using a Docker container to run your application? If so, make sure you forward your ports in your docker-compose
 ports:
            - '${APP_PORT:-80}:80'
            - '${VITE_PORT:-5173}:${VITE_PORT:-5173}'
            - '6001:6001'
            ```


[5.3] Make resource routes singular

Currently, the resource's name will be used for the route wildcards to the show, update and delete methods. This PR modifies this behaviour to use the singular form of the resource name. The reason for it is that implicit route model binding requires you to use the same variable name as the name of the wildcard. Hence, this PR allows for more sane (aka singular) variable naming.
Example:
routes.php

Route::resource('users', 'UsersController');

----------------------------------------
UsersController.php

public function show(User $user)
{
    //
}

In the example above, prior to this PR, the variable would have to be named $users to be implicitly bound to its model.

Yeah I like this idea :+1:
I know we talked about it already @phroggyy, but when you manually route model bind in RouteServiceProvider, you can pass any var name into your resource controller methods (singular or plural, etc.).  However, implicit model binding requires exact same plural var name as URI segment generated by Route::resource().  If implicit model binding accepted ANY var name, and just verified using your type int or by checking var instance type (as you suggested), then it would behave more like a manual/explicit route model bind, and it would be a non-breaking PR that could be applied to 5.2.

It makes pretty decent sense but obviously would have BC implications. What would the upgrade guide look like?

@taylorotwell, check my comment...

When you [manually/explicity] route model bind in RouteServiceProvider, you can pass any var name into your resource controller methods (singular or plural, etc.). However, implicit model binding requires exact same plural var name as URI segment generated by Route::resource(). If implicit model binding accepted ANY var name, and just verified using your type hint or by checking var instance type, then it would behave more like a manual/explicit route model bind. This would also make it a non-breaking PR that could be applied to 5.2.

Amirite?

I have been thinking about this since #11644. It would be nice if the default behaviour was to make the widlcards singular, but as mentioned the BC issue is a problem.
I am not sure what is involved with the method JesseLeite is proposing, but it sounds interesting.
If that can't be done I might have some ideas how to adjust this and keep BC by allowing some options to be set.

@lagbox I've managed to get @JesseLeite's proposal working locally. I still have to write a few tests, but expect a new PR up tonight or so :)

@taylorotwell this will be non-BC if #11999 is accepted I'm quite sure

I'm still interested in finding out if we can make Route::resource accept an option for the resource parameter place-holder. @JosephSilber and I have talked about this on Slack (which we needs logs for or something) :|

Yeah I like the idea of making it optional, that would mean no BC. It does make sense to make it singular because majority of the named routes revolve around one entity, with the exception of .index
Could even make an method on the route object for those that want to use it now something like Route::enableSingularResources() then make it the new default in laravel 5.3...

@lagbox I like your solution in #11644 specifically this:
Route::resource('users.photos', 'PhotoController', ['wildcards' => [
    'users' => 'user', 'photos' => 'photo'
]]);

Which would allow people to use whatever they want for the wildcards.

@ryanmortier yea that was a quick idea that I have a working example of in a gist.
I was kinda waiting to see how this current PR resolved before PR'ing that change, but if we are looking for that I can make one.

@taylorotwell It can be done. I have an example of doing it by extending ResourceRegistrar and lucasmichot has a PR in to do it.

Closing this one in favor of https://github.com/laravel/framework/pull/12061


Microsoft web Dev

@Lanretech-debug could you add some description to this issue? Thanks!

Closing as no description was added to issue.
@Lanretech-debug please feel free to open a new issue with description as you find any items to update.


RT-5.1: Singleton Interface

Hi,
1.) Mac address is not getting populated and hence added code to get it using gnmi.get
2.) Packets counters for larger MTU will be updated in /ethernet/counters , hence added check to verify them.
Thanks,
Prabha

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 46.471%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
586

Relevant Lines:
1261

💛  - Coveralls

singleton_6.txt
Please check passed log.
Thanks,
Prabha

singleton_latest.txt
Please find passed log.

Seems there is some change when I'm verifying this PR. Can you please confirm if the PR need rebase?

Seems there is some change when I'm verifying this PR. Can you please confirm if the PR need rebase?

@ming2004 I saw the changes and did rebase also removed certain parts of code as it is removed now.
Currently we have added change  only in two places . To populate mac address and configure description for interface.

and it is rebased .


Format all go files correctly, and check the linting on travis

Even reverted the gofmt commit to check that it worked!


[WIP] Viewport animation using MapController.

NOTE: Do not merge, WIP.

Add viewport animation support to MapController
MapController takes new prop, aniamteViewport, when true, a change viewport results in animation which linearly interpolates changed attributes.
MapController updates all its children recursively and sets their viewport prop to animated viewport, right before then get rendered.
Temporarily updated 3d-heatmap and geojson examples to test animation.

NOTE: Do not merge, WIP.

added

@ibgreen code is not ready to merge, as I left few comments and need cleanup, but if you have any feedback I can address that and make this PR ready to land.

cool


Extract surveys.js as a separate JS bundle

For: https://trello.com/c/ZEJRuWiU/151-reduce-need-to-change-static-js-when-deploying-surveys-part-2
The contents of surveys.js can change frequently as we introduce new
surveys and retire old ones.  Every time we deploy these changes the
application.js bundle gets a new digest hash and so frequent visitors
have to re-download the whole JS bundle just to get these updates to
surveys.  To avoid this we separate the surveys.js so it is required
separately and changes to it will not change the digest of the main
application.js.
The assumption here is that applications using the JS provided by
static only do so by using the layouts via slimmer and not by requesting
the application.js or header-footer-only.js files directly.  If that
is the case they will also need to be updated to also request the
surveys.js bundle.

v noice 👍  Will review

Has this been tested on integration, end to end with a couple of frontend apps?

@fofr tested on integration on a few pages and it seems to all work.  I also tested the "doesn't invalidate the main js bundle" part of it by deploying this, then deploying a version with a change to surveys.js.  The application.js asset didn't get a new digest, but the surveys.js did.  Are you happy for me to merge?


ng new ignores --collection for checking schematic options

🐞 Bug report
Command (mark with an x)

[x ] new
[ ] build
[ ] serve
[ ] test
[ ] e2e
[ ] generate
[ ] add
[ ] update
[ ] lint
[ ] extract-i18n
[ ] run
[ ] config
[ ] help
[ ] version
[ ] doc

Is this a regression?
Yes, before you could use --collection to run a custom schematic for ng new.
Description
The schematic in --collection is ran, but options are based on @schematics/angular:ng-new instead of --colleciton.
The issue is how collectionNameFromArgs is extracted from the options:
https://github.com/angular/angular-cli/blob/main/packages/angular/cli/src/commands/new/cli.ts#L48
const {
      options: { collectionNameFromArgs },
    } = this.context.args;

If this line is changed to:
const {
      options: { collection: collectionNameFromArgs },
    } = this.context.args;

The options from --collection are used correctly.
🔬 Minimal Reproduction
Try to use ng new --collection with a collection that has arguments not in @schematics/angular:ng-new

🔥 Exception or Error
Only options for @shematics/angular:ng-new are recognized.

Package                      Version
------------------------------------------------------
@angular-devkit/architect    0.1400.1 (cli-only)
@angular-devkit/core         14.0.1 (cli-only)
@angular-devkit/schematics   14.0.1 (cli-only)
@schematics/angular          14.0.1 (cli-only)

@jaschwartzkopf, your investigation looks good. Want to try to land a PR?

Hi, @alan-agius4. This is now working, thank you for the fix! Still I think there is similar problem with the ng g command:
"ng g @custom-schematics:schematic-name --custom-schematic-property=value" is throwing
Error: Unknown arguments: custom-schematic-property

@Lipata, that seems to be an unrelated issued.
Please open a new issue with a minimal reproduction.
Thanks.


dts: stm32f334: Delete usb node

STM32F334 SoCs don't include USB controller,
so delete USB node for theses SoCs in DT.
Signed-off-by: Yannis Damigos<EMAIL_ADDRESS>

Codecov Report

Merging #10740 into master will decrease coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #10740      +/-   ##
==========================================
- Coverage   53.26%   53.13%   -0.14%
==========================================
  Files         215      215
  Lines       25827    25827
  Branches     5695     5695
==========================================
- Hits        13758    13724      -34
- Misses       9753     9793      +40
+ Partials     2316     2310       -6

Impacted Files
Coverage Δ

include/posix/posix_sched.h
0% <0%> (-100%)
:arrow_down:

lib/posix/pthread_barrier.c
0% <0%> (-100%)
:arrow_down:

lib/posix/pthread_cond.c
62.5% <0%> (-20.84%)
:arrow_down:

lib/posix/pthread.c
68.03% <0%> (-12.33%)
:arrow_down:

lib/posix/pthread_mutex.c
76.38% <0%> (-1.39%)
:arrow_down:

subsys/logging/log_output.c
83.33% <0%> (+1.19%)
:arrow_up:

subsys/logging/log_core.c
78.4% <0%> (+2.34%)
:arrow_up:

lib/posix/pthread_sched.c
62.5% <0%> (+20.83%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c229126...bcbb0ee. Read the comment docs.


Support exclude

Example
let g:mr#mru#exclude = '\(COMMIT_EDITMSG\|README.md\)'

Close due to #4


fix: send offlineCount of 0

What does this change?
Ensure we still collect 0 values.
Why?
0 is falsy in JS – 🤦♂

Stricter comparisons can be enforced with ESLint, see https://github.com/guardian/dotcom-rendering/pull/7152


update the JSX render class to not explicitly inject HTML inside of t…

…he body tag, allowing for head meta tags and such to be injected and handled by the browser.

@jaymanmdev seems like the test suite failed because of the changes you made. Please read the test file and try to fix the issue.

Other than that, I like the idea behind this pr! :)

Sorry, this is my first ever PR in any repo so I am still getting the hang of it, I'm getting in the habit of running the tests before submitting an adjustment to my PR/s from now on. Thanks!

Our contributing guidelines are really basic but that's the one thing that's included in them. 😅

Our contributing guidelines are really basic but that's the one thing that's included in them. 😅

Ah, I didn't pick up on that guidelines file - my bad! I tested the suite this time though.

Just make a sub-test, e.g.
Deno.test('something', async (t) => {
  await t.step('first step', async () => {
    // some code
  })
})

Just make a sub-test, e.g.
Deno.test('something', async (t) => {
  await t.step('first step', async () => {
    // some code
  })
})

I'll quickly do this now, and submit an adjustment.

b1341059dd16ef47954ad1c94e865c41c836a73e
Let me know what you think.

I removed the head manipulation that I was doing as the browser knows where to put specific tags, unless specifically stated otherwise (e.g. putting a meta tag inside the body tag.). We can build out better sanitization of the HTML later on if you'd like?
I added a new test case to test this.


Updated backoff to use absl::Random

https://github.com/grpc/grpc/pull/26479 & internal b/192110891

grpc_build_artifacts_multiplatform: running

grpc_aws_basictests_php: running

Also some of iOS tests failed with the following error
   Headers/Public/abseil/absl/random/internal/pcg_engine.h:265:20: error: implicit conversion loses integer precision: 'uint64_t' (aka 'unsigned long long') to 'int' [-Werror,-Wshorten-64-to-32]
    return rotr(s, rotate);

Abseil just got the new release now so let's re-hydrate this!

grpc_build_artifacts_multiplatform: running

This is a nice step toward #17891.


Fixed several TSLint typedef issues in BotConfig.ts

Several TSLint 'typedef' warnings were solved in MSBot\src\BotConfig.ts.

Closed due to changes in master that would lead to several merge conflicts


Support dark theme for tailwind-scrollbar

Currently, the plugin doesn't work with the dark variant.

Hey, thanks for bringing this up. I've more generally enabled variants in the plugin in v1.1.2. To add dark mode scrollbars utilities, set 'dark' as a variant for scrollbar in the variants object in your tailwind config:
variants: {
    // ...
    scrollbar: ['dark']
}

Of course, you'll also need to have darkMode set to 'media' or 'class', but I assume that if you're here asking about dark mode, you've already got that covered. ;)


Fix US postcodes and generate address area data

Fix US postcode data and all missing address areas based on the postcode.

Checklist

[x] If this is a releasable change, has a news fragment been added?

Explanation
A news fragment is required for any releasable change (i.e. code that runs in or affects production) so that a corresponding changelog entry is added when releasing.
Check changelog/README.md for instructions.

[x] Has this branch been rebased on top of the current develop branch?

Explanation
The branch should not be stale or have conflicts at the time reviews are requested.

[x] Is the CircleCI build passing?

General points

Other things to check

Make sure fixtures/test_data.yaml is maintained when updating models
Consider the admin site when making changes to models
Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

More details in the PR description would be really useful for reviewers too :) E.g. Why the change is happening, the logic used and why particular choices were made over others.


Handle panics in the user callbacks

Add panic::catch_unwind around the callback calls.

I think this will only apply to certain user-callback calls, and will probably require being implemented uniquely by each backend.
For example in the macOS backend most user-callback calls occur on the main rust thread, while a certain few (i.e. Resized, Focused) are called by objective-C NSWindowDelegate callbacks. As a result probably only the delegate callback calls need to be wrapped in catch_unwind.
@tomaka In this case, what should be done once the unwind has been caught? I'm thinking that either:

The error could be stored somewhere so that the panic! can be re-invoked once execution is passed back to the main rust thread. One problem with this is that if a panic! occurs during window resizing, the panic!ing user callback will be called again and again until the resize has ended and only then will the panic! occur on the main rust thread.
Some objective-C equivalent to panic! is called. Is this even safe though? It would probably be weird for the user to sometimes get rust panic!s and other times get objective-C panics. For this reason I'm probably leaning towards 1 despite the resizing issue.

I encountered a need to handle errors at the caller of EventsLoop::poll_events/run_forever.
I think that I have something to do with this issue.
Rather than using panic::catch_unwind, I think it is a good solution to add the try_poll_events/try_run_forever method and return the error value to the caller and handle it appropriately.

After EventLoop 2.0, there will be no returning from run on certain platforms. On those platforms, I'm pretty sure this means there will be no good time to resume_unwind.
One idea is to catch the panic and pass it into the callback. Something like changing the callback to take a Result<Event<T>, Panicked> parameter instead of an Event<T>.
struct Panicked(Box<Any + Send + 'static>);

What platforms does this still need to be implemented on? This has been fixed on Windows,
I'd like to split this into separate issues for each platform, for improved tracking.

What is the exact need?
With evl2, the x11 and Wayland backend do not invoke the user callback from withing a system callback, so panics simply unwind the rust app without crossing FFI frontier. Is anything ore needed?

For Linux, no. This may be necessary on iOS, Android, macOS, and the web, though.


Trigger modified after getText and textChange callbacks

Please check if the PR fulfils these requirements

[ ] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes/features)
[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix.

What is the current behaviour? (You can also link to an open issue here)
Currently, the annotation label only updates in the measurement table if the user intentionally changes the position of the annotation to force a modified event to be triggered causing the table to update with the correct new value.

What is the new behaviour (if this is a feature change)?
Now those events are being triggered, updating the table properly if the annotation has changed.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No breaking changes.

Other information:

:tada: This PR is included in version 4.8.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Change block states repr syntax

Change the block states syntax from ["foo":"bar"] to the new form ["foo"="bar"].
See also: https://github.com/Bedrock-OSS/bedrock-wiki/commit/8beb57b4b998ea84f15488dfaf703c67667c5450

See also: https://github.com/phoenixr-codes/mcstructure/commit/9cd44e61cd0406d8553327278f8af8b23fadec54


Hide split variants (Feature Request)

Currently, all variants are displayed on the article. However, if the articles are split in the listing, you will see all variants multiple times. Once as a single article and once as a variant selector.

Here an option would be helpful, which shows only the variant attributes on the article for selection, which are not already split.
In this example, in the category the variants are split by color and the sizes are available for selection:

Hi @simgero
Thanks for the great suggestion, I updated it in the latest PR, please have a look :)

Looks perfect. Thanks for this enhancement.


MeshSync: Support discovery of Citrix Service Mesh #745

Signed-off-by: vijcheru<EMAIL_ADDRESS>
Description

This PR fixes #745
Notes to reviewers:
Checklist

[x] DCO signed.
[x] Title of the PR starts with area name, e.g. meshery:, mesheryctl:, ui:.

Nice work @vijcheru, I've no objection with this PR getting merged, however if you could also add Octarine service mesh's meta information too in this, then that would be great!

Nice work @vijcheru, I've no objection with this PR getting merged. This PR fulfils it's objective. however, if you could also add Octarine service mesh's meta information too in this, then that would be great!

Would that be octarinesec/microservice-proxy?

I looked into the dockerhub and couldn't find a separate image for service mesh... I guess, we can open a separate issue to track it, and then ask user to install octarine and check which images are used and populate them into this file.

@leecalcote , it's good to be merged!!!

@dheerajng in terms of determining whether a Citrix Service Mesh is present I the environment, we will look for a container image with the name “cpx” in it, correct?

We need to look for two container images:
i) quay.io/citrix/citrix-istio-adaptor
ii) quay.io/citrix/citrix-k8s-cpx-ingress
docker.io/citrix/citrix-k8s-ingress-controller is not the right image. This is for ingress controller.


client.UpdateChannel(); updates only once.

So yeah here is my code :
if (input.startsWith("TOPIC")) {
text = message.content.split(" ")[1];
bot.UpdateChannel(message, {topic: text});
}
(input is message.content.toUpperCase();)
and when I use the command it updates once then can't update anymore.

Should be fixed on indev

Dupe of #455


Validated NFD with recent kubernetes version (1.9.2), could add some doc.notes

Here are some notes from  "a newcomer run attempt" validating NFD on top of
current k8s (1.9.2). Some doc (code?) changes could be made based on findings.
Systems configuration:
4 nodes as KVM-style VMs on top of x86_64 HW
Distro on all nodes: CentOS 7, stock "minimal server" config
Added repositories for:

Kubernetes: packages.cloud.google.com/yum/
Docker: download.docker.com/linux/centos/7

Kernel: 3.10.0-693.17.1.el7.x86_64
Docker: docker-ce-17.12.0.ce-1.el7.centos.x86_64
kube- ctl,adm,let versions: 1.9.2
Cluster initial creation by "kubeadm init" and "kubeadm join"

NFD Building does not work behind proxy. This can be improved by PR #91, thanks to @marquiz for creating this PR.

Tried stand-alone run as in README "Command Line Interface". This chapter does not describe how to run NFD as standalone. By checking Dockerfile it becomes clear that container activation is enough. Mentioning this in README would add clarity.

Tried to run as cluster job. label-nodes.sh schedules a pod run on every node which is in "Ready" state. In a default-config cluster, the master node is tainted:NoSchedule which results in one of scheduled pods doomed to fail. If a clean run is desired, we should either schedule NUM-1 jobs leaving master out (master will not get labels, but if it remains NoSchedule that will be consistent, right), or Master config needs to be modified. We could add note in README, and/or comment in label-nodes.sh?

A job run on a node will detect features as designed, but labels-add part will fail in a default-config cluster, caused by RBAC (Role-based Access Control) blocking get,set operations. RBAC was added after NFD was written? The first error will be:

can't get pods: pods "node-feature-discovery-f2v8m" is forbidden: User "system:serviceaccount:default:default" cannot get pods in the namespace "default"

To solve RBAC blockers:
Role access rights can be added using audit2rbac tool. Use of audit2rbac tool requires auditing configured. Roles adding needs 3 iterations to cover all stages of similar errors:

User cannot get pods in the namespace "default"
User cannot get nodes at the cluster scope
User cannot update nodes at the cluster scope

With role rights added, the NFD label adding starts to work.
The main level README could mention roles rights dependency.

README states that "The discovery script will launch a job on each unlabeled node". But that seems not so: label-nodes.sh script does not check labeled vs. unlabeled nodes. It launches a cluster job with NumNodes desired completions. That means, job is always restarted on any Ready node.

Mixed success case: If some node is not able to complete the successful run, for example if RBAC state (see point 4 above) is incorrect on some nodes and correct on others (happens for example if roles have been added using audit2rbac, followed by new node join), cluster will run repeated NFD jobs on "good" nodes in order to fulfill the number of desired completions, and marks overall job progress as good. This is misleading and incorrect as some nodes will remain unlabeled. To cover such mixed cases, more sophisticated logic like "give me exactly one good completion per node" will be required instead of simple "give me N overall completions". Doc change or separate issue based on this? Not sure does k8s provide easy API for such scheduling.

Everything mentioned in this issue was covered by #91, #104, #126, we can close this now.


Hug with python 3.7.1 error

I use hug and sqlalchemy hug -f admin_app/app.py,got such error:
Traceback (most recent call last):
  File "/Users/xxx/miniconda3/envs/python3/lib/python3.7/site-packages/hug/development_runner.py", line 108, in reload_checker
    if path[-4:] in ('.pyo', '.pyc'):
TypeError: 'NoneType' object is not subscriptable```

#691 can fixes the problem.

This is fixed in the 2.4.2 release


mongodbDatabase not created and mongodbUsername cannot login

Describe the bug
A clear and concise description of what the bug is.
Version of Helm and Kubernetes:
1.13
Which chart:
stable/mongodb
What happened:
User mongodbUsername created (visible in system.users) but impossible to log in with mongo <db> -u <user> -p <pw> --authenticationDatabase admin. Loging in as root works
Database mongodbDatabaseis not created.
However init logs show that it is created, but doing show dbs as root doesn't list it. Doing use db...will create the database
What you expected to happen:
The database should be created and the user should be able to log in
How to reproduce it (as minimally and precisely as possible):
I am using terraform. I checked that all variables are defined
resource "helm_release" "mongo-db" {
    name      = "mongodb"
    namespace = "botfront"
    chart     = "stable/mongodb"
    set {
        name  = "mongodbUsername"
        value = "${var.mongo_username}"
    }
    set {
        name  = "mongodbPassword"
        value = "${var.mongo_password}"
    }
    set {
        name  = "mongodbRootPassword"
        value = "rootPw"
    }
    set {
        name  = "mongodbDatabase"
        value = "${var.mongo_database_name}"
    }
}

Anything else we need to know:

Hi @znat ,
Please, could you edit the title of the issue to reference the problem?
Apart from that, I have checked it and it seems you're right, the database is not created, I am going to create an internal task to fix this.
Thank you very much for reporting.

Hello guys,
I'm experiencing exactly the same thing. Any clue on what's going on here? This is blocking our deployment :(

For me, mysteriously, it works now on new deployments.

@znat @miguelaeh I'm still perfectly able to reproduce the issue, simply running the exemplar command in the readme:
helm install --name my-release \
  --set mongodbRootPassword=secretpassword,mongodbUsername=my-user,mongodbPassword=my-password,mongodbDatabase=my-database \
    stable/mongodb

If I enter the container and I do mongo -u my-user --authenticationDatabase admin and I enter the password I get
2019-10-18T12:44:43.565+0000 E QUERY    [js] Error: Authentication failed. :
connect@src/mongo/shell/mongo.js:344:17
@(connect):2:6
exception: connect failed

If I enter as root user I can successfully authenticate, but if I try to list the dbs with show dbs I get
admin   0.000GB
config  0.000GB
local   0.000GB

@znat are you installing the latest version of the chart or are you sticking to a specific one?
This is not at all a secondary issue... it's vital to bring the mongodb container to life :(
Any help is greatly appreciated!
Thanks,
-Luca

The issue seems to be back. Now I'm not using terraform anymore, but using this chart as a dependency in another chart. Here are my values:
mongodb:
  mongodbUsername: rw
  mongodbPassword: password
  mongodbRootUsername: root
  mongodbRootPassword: password
  mongodbDatabase: bf

mongo bf -u rw -p password --authenticationDatabase admin fails
However, I can login as root and do:
> use bf
switched to db bf
> db.getUsers()
[
	{
		"_id" : "bf.rw",
		"userId" : UUID("95981ad3-05fe-44e2-b1da-cd6a84ce76da"),
		"user" : "rw",
		"db" : "bf",
		"roles" : [
			{
				"role" : "readWrite",
				"db" : "bf"
			}
		],
		"mechanisms" : [
			"SCRAM-SHA-1",
			"SCRAM-SHA-256"
		]
	}
]

Any idea?

Ok, got it. Just needed to not specify an authentication database


Run checkstyle in CI

I noticed that it's possible to make a formatting error, such as disorganize imports or change indentation, without ./gradlew check noticing. This issue proposes adding more rigorous checkstyle and code linting integration to this project.
An idea is to use the baseline toolkit, but we can also write the linting configuration by hand.

How are we doing on this? Most modules are running checkstyle, right?

This can probably be superceded by all the individual tasks for Baseline integration.

Thanks! I'll close this.


Make static plots the default again

Reasons:

Users do not read the instructions (in general)
Users do not read the instructions to setup Plotly in Jupyter notebook and JupyterLab, and sometimes they don't even know which one are they using
Static plots work out of the box in Jupyter notebook, JupyterLab, and Spyder, and with a plt.show() (that users are not doing anyway) it works from any terminal as well.

This issue is so critical I am thinking of advance the release to June.


[Feature]: Ability to modify config values per runtime (for testing purposes)

Is there an existing issue for this?

[X] I've not found one

What is a reason behind changing the behavior?
The current implementation of the Config Manager in Nest.js is global per runtime, which means that all modules share the same configuration object. This can lead to unexpected side effects and issues when writing tests, as changes made to the configuration during a test run might affect other tests or test suites.
The primary motivation for this change is to improve the testability of the application by allowing developers to create isolated configuration instances for individual test suites. This ensures that configuration changes made during a test run do not affect other test suites, leading to more reliable and easier-to-maintain tests.
E.g., if we have to test a module that has different behaviours based on envs, we will write such test cases:

root module
root module > when env "boo" is false
root module > when env "boo" is true

And the Config would be shared for each test suite.
Propose the solution
A clear and concise description of the solution with considered benefits and drawbacks
A possible solution is to provide a utility function that generates a new instance of ConfigManager for each test suite, allowing developers to have isolated configurations for different test suites.
Benefits:

Improved testability of the application
Isolated configuration instances for different test suites
Easier-to-maintain and more reliable tests

Drawbacks:

Additional utility function to be maintained
Slightly increased complexity in test setup

Adoption
The proposed solution should not (I'm not sure 😅) introduce breaking changes to the existing implementation. Developers can continue using the global configuration object in their applications, while using the new utility function to create isolated configurations for test suites. No migration is necessary for existing applications.

Config object is an global instance of ConfigManager. Such can be created via
import { ConfigManagerFactory } from '@unifig/core';

const config = ConfigManagerFactory.create();

const validationError = config.registerSync({
  templates: [AppOptions],
  adapter: new EnvConfigAdapter(),
});

instead of
import { Config } from '@unifig/core';

const validationError = Config.registerSync({
  templates: [AppOptions],
  adapter: new EnvConfigAdapter(),
});


Is config.json obsolete?

I can't find config.json in cet_1_9_2.zip.
If this change is unintentional, can I solve this problem by reusing the previous config.json?

It is deprecated, use the ingame settings :)

It is deprecated, use the ingame settings :)


Having VMProbe as part of the VictoriametricsV1beta1Client

It would be nice to have VMProbe as part of the VictoriametricsV1beta1Client
see api/client/versioned/typed/victoriametrics/v1beta1/victoriametrics_client.go
This will allow to interact with it like we interact with the VMAgent.
type VMAgentInterface interface {
	Create(ctx context.Context, vMAgent *v1beta1.VMAgent, opts v1.CreateOptions) (*v1beta1.VMAgent, error)
	Update(ctx context.Context, vMAgent *v1beta1.VMAgent, opts v1.UpdateOptions) (*v1beta1.VMAgent, error)
	UpdateStatus(ctx context.Context, vMAgent *v1beta1.VMAgent, opts v1.UpdateOptions) (*v1beta1.VMAgent, error)
	Delete(ctx context.Context, name string, opts v1.DeleteOptions) error
	DeleteCollection(ctx context.Context, opts v1.DeleteOptions, listOpts v1.ListOptions) error
	Get(ctx context.Context, name string, opts v1.GetOptions) (*v1beta1.VMAgent, error)
	List(ctx context.Context, opts v1.ListOptions) (*v1beta1.VMAgentList, error)
	Watch(ctx context.Context, opts v1.ListOptions) (watch.Interface, error)
	Patch(ctx context.Context, name string, pt types.PatchType, data []byte, opts v1.PatchOptions, subresources ...string) (result *v1beta1.VMAgent, err error)
	VMAgentExpansion
}

What do you think ?
Is there a reason why it's not here ?
Thanks.

Hello, I think it's a bug. Those interface must be generated, but for some reason it doesn't.

Was added as part of v0.40.0 release


M3-1784 - Add WebdriverIO user agent to requests/browser settings

Adds a custom user agent to browser configs and axios requests (now includes WebdriverIO) this will allow us to filter out e2e test runs from our API usage reporting.

To Test
In a spec file, after the browser.url() command, add:
browser.debug()

Run the modified test spec with yarn e2e --spec=e2e/specs/path/to/spec.js
Once the debug REPL is available, open the browser's dev tools and look at the request headers for individual requests in the network tab.
Confirm WebdriverIO is in the user-agent header
Run the same test in Firefox ``yarn e2e --spec=e2e/specs/path/to/spec.js --browser=firefox`
Confirm WebdriverIO is in the user-agent header

Coverage remained the same at 27.882% when pulling 51002dfa0df78b4ab3b79ef4b3dbfab04ac15dec on patthiel:M3-1784 into ac54898cad609da93ceaeae33595f4f4f5418d00 on linode:develop.


🐛 Describe the bug
while i use the command: "colossalai run --nproc_per_node 1 --master_addr GPU001 --master_port 29505 --host GPU001 main.py", it's not working.
but the command  "colossalai run --nproc_per_node 1 --master_addr localhost --master_port 29505 --host GPU001 main.py" is ok.
What kind of problem may this be？
Environment
No response

Hi @bingokunkun , master_addr is used in setting up NCCL distributed groups, thus it should be specific address. host consissts of the addresses used to setting up SSH connections, and they can be any host name that can be resolved by SSH.


Add Usage: Host it

It would be nice to quickly deobfuscase code via an online website as well. I suggest using github.io for this.

I completely agree with you - it would be nice to have this hosted online, and it will be. Once the restringer.tech site is online, I'll update the README file.
Thanks for suggesting this!
I will close this issue now.


[REPL] Switch to jsDelivr

unpkg has been intermittent for ~6 months. jsDelivr is more resilient, (seems to) supports CORS and also hosts files from GitHub, so switching to it would fix #282 as well.

Let us know if the jsDelivr team can help with anything. jsDelivr is under active development and aims at production use-cases with multi-CDN logic https://www.jsdelivr.com/network/infographic

In my related comment, I suggested using Skypack to help with package compatibility: https://github.com/sveltejs/sites/issues/137#issuecomment-1360763974

jsDelivr also has esm.run, which does ESM conversion and minification as well.

@longnguyen2004 thanks for the suggestion (as well as the issues in Svelte itself - sorry we have a hard time keeping up with all the issues :smile:)

Let us know if the jsDelivr team can help with anything. jsDelivr is under active development and aims at production use-cases with multi-CDN logic https://www.jsdelivr.com/network/infographic

@jimaek, just curious, how were you made aware of this issue? Do you have a GitHub alert for jsDelivr always running or something?

Yep I monitor jsDelivr mentions in case someone needs help

Hi, I'm experimenting with jsDelivr in REPL(See #551). So far loving it, only issue is that it doesn't resolve barrel imports(https://cdn.jsdelivr.net/npm/radix-svelte/dist/components) while unpkg does(https://unpkg.com/radix-svelte/dist/components).
That is something that would make transitioning very easy. Is this possible to implement on jsdelivr's end? cc @jimaek

Hi, I'm experimenting with jsDelivr in REPL(See #551). So far loving it, only issue is that it doesn't resolve barrel imports(https://cdn.jsdelivr.net/npm/radix-svelte/dist/components) while unpkg does(https://unpkg.com/radix-svelte/dist/components). Can be done manually in the REPL by resolving with different methods('.js', '.mjs', '.cjs', './index.js', 'index.cjs', 'index.mjs'), but that would require 7 fetch requests in worst case, which is too much to be doing on user's device.
That is something that would make transitioning very easy. Is this possible to implement on jsdelivr's end? cc @jimaek

Hey, we support server-side resolving in ESM mode so this would generally work: https://cdn.jsdelivr.net/npm/radix-svelte@latest/dist/components/+esm but here the package declares exports and doesn't expose that directory, so it can't be accessed like that. For packages with no exports it works with all files.

I am facing some weird problems with esm.run, where the output component code just doesn't work with esm.run, but does with regular old jsdelivr. Is there a way to configure the rollup and terser version esm.run uses?

Is there a way to configure the rollup and terser version esm.run uses?

No, but if the files happen to be built using an older version, we might be able to update them to the version we use at this time.

We gave up on esm.run because the bundling was causing issues with ending up with multiple versions of the Svelte runtime. jsdelivr would still be interesting though

Svelte 4 returns a .cjs file for the compiler, which jsdelivr correctly serves with application/node mime-type. However, Chrome doesn't recognize that as JavaScript. That leaves us stuck with unpkg for Svelte 3/4
Svelte 5 avoids this by returning a .js file for the compiler, so we could probably use jsDelivr for Svelte 5
@PuruVJ I'm not sure I understand your mention of radix-svelte above. As far as I'm aware, libraries are bundled by rollup in the browser, so their mime types would not matter and we only need to worry about Svelte itself.

Where do you anticipate that being a problem? We use fetch and eval to load the compiler, rather than import or importScripts, so it should be fine


[BUG] Triangle suffix

Expected behaviour
A number to be printed out, all alone
Current behaviour
The number was printed out followed by the triangle character
Steps to reproduce
Type sleep 5 in the terminal or print out a number

fixed in dev with this snipppet
void kprintn(int num) {
    char buf[15];
    itoa(num,buf,10);
    kprintf(buf);
    terminal_column--;
    kprintf(" ");
    terminal_column--;
}


[DISCUSSION] mcc and mnc qualifiers

Just curious, is there any reason for this strange formatting of mcc and mnc qualifiers?
https://github.com/iBotPeaches/Apktool/blob/master/brut.apktool/apktool-lib/src/main/java/brut/androlib/res/data/ResConfigFlags.java#L179-L201
I mean, looking at the AOSP source code, there's a plain %d formatting for any value other than 0, no leading zeros.
https://android.googlesource.com/platform/frameworks/base/+/master/core/java/android/content/res/Configuration.java#2512
https://android.googlesource.com/platform/frameworks/base/+/master/libs/androidfw/ResourceTypes.cpp#3370

There is not - I'm guessing before AOSP source was out - this was the interpretation of how it functions. I might go back and look at the Froyo release to confirm that, but otherwise I don't think there is any Apktool specific reason.

I dug a bit deeper. This table gives these examples:
mcc310
mcc310-mnc004
mcc208-mnc00

Regarding mcc field: IMSI MCC (Mobile Country Code), corresponding to mcc resource qualifier. 0 if undefined.
Regarding mnc field: IMSI MNC (Mobile Network Code), corresponding to mnc resource qualifier. 0 if undefined. Note that the actual MNC may be 0; in order to check for this use the MNC_ZERO symbol.
Which seems to imply that stored value of MNC_ZERO is -mnc0/-mnc00/-mnc000, while stored value of 0 means any/undefined mnc.
Wikipedia says that MCC is always 3-digit, while MNC can be 2-digit (European standard) or 3-digit (North American standard), and an example says "MNC of 001 is not the same as MNC of 01".
Which is odd, because the source code I linked you to doesn't make any kind of differentiation when constructing the qualifiers, and both 001 and 01 are stored as 1.
Here's a partial output of aapt2 dump resources framework-res.apk | grep mcc | sort:
      (mcc286-mnc2) true
      (mcc286-mnc2) true
      (mcc286-mnc3) false
      (mcc286-mnc3) true
      (mcc286-mnc3) true
      (mcc295-mnc1) false
      (mcc295-mnc1) true
      (mcc295-mnc1) true
      (mcc302-mnc220) 1410
      (mcc302-mnc220) false
      (mcc302-mnc220) true
      (mcc302-mnc220) true
      (mcc302-mnc221) false
...
      (mcc520-mnc65535) true
      (mcc520-mnc65535) true
      (mcc520-mnc65535) true
      (mcc525-mnc1) false
      (mcc525-mnc1) true
      (mcc525-mnc1) true
      (mcc525-mnc17) 1380
      (mcc525-mnc3) false
      (mcc525-mnc3) false
      (mcc525-mnc3) true
      (mcc525-mnc5) false
      (mcc525-mnc5) false
      (mcc525-mnc5) true
      (mcc530-mnc24) false
      (mcc530-mnc24) false
      (mcc530-mnc24) true
      (mcc530-mnc5) false
      (mcc602-mnc1) false
      (mcc602-mnc1) true
      (mcc602-mnc1) true

We can see no leading zeros here at all.
It's known that -mnc65535 is -mnc0 (vs. undefined), because 6553==MNC_ZERO, but it's really either -mnc00 or -mnc000 (no way to know, 00 is used in Europe while 000 by One network in Bermuda).
For the rest, it's entirely unclear, e.g. does -mnc1 mean -mnc01 or -mnc001 when both are valid?

I'm very confused.

Did you stumble onto some issue that led you to this? I'm just weary of changing something I haven't touched in a decade.


Build is failing because of bad pip dependency

@tchiapuziowong Looks the the build for this pack is failing to find the PyPI package pyaoscx: https://circleci.com/api/v1.1/project/github/StackStorm-Exchange/stackstorm-aoscx/3/output/103/0?file=true&allocation-id=5fa59913b270d70782b8e95d-0-build%2F53654357  (scroll all the way to the bottom)
Collecting pyaoscx>=0.2.1 (from -r /home/circleci/repo/requirements.txt (line 3))
  Could not find a version that satisfies the requirement pyaoscx>=0.2.1 (from -r /home/circleci/repo/requirements.txt (line 3)) (from versions: 0.1.1, 0.1.2, 0.2.0)
No matching distribution found for pyaoscx>=0.2.1 (from -r /home/circleci/repo/requirements.txt (line 3))

Looks like this pack only supports python3, so the python2 build was failing because the python dependencies can't be met on python 2.
Made a PR #2 to fix this.
TODO, we need to skip python2 builds for packs that only support python 3.


Add a page in the manual about packaging

Discuss CFLAGS (e.g. Arch has settings), bundling file detection with licenses, shipping the manual, and who is doing it (i.e. wonderful people, but not my focus).

Also instructions about running the full test suite (some are disabled if MIME data is absent), and which files need to be bundled (the same as the published crate).

Also note about DFT_VERSION_HERE patching, e.g.:
https://github.com/openbsd/ports/blob/cccd1a7109c42d7d38913fff8a7b7445c617ea6e/devel/difftastic/Makefile#L27


Accounting debug api

The aim of this pull request is to create the
/balances

/balances/{peer}

endpoints in the debug api that return the swap balances associated with peers in json format

Some fixes in the latest commit addresses nearly-missed issues from https://github.com/ethersphere/bee/pull/427#pullrequestreview-459122006

I have updated this PR by addressing some comments that are left and also made some improvements. It is ready for another review. I am not sure why Validator naming changes are here, but I did not revert them.

I have updated this PR by addressing some comments that are left and also made some improvements. It is ready for another review. I am not sure why Validator naming changes are here, but I did not revert them.

thank you!
regarding the naming changes, please see this comment from @metacertain.
also, it seems @ralph-pichler made an additional comment previously, although i am not exactly sure of what he is referring to.

I have updated this PR by addressing some comments that are left and also made some improvements. It is ready for another review. I am not sure why Validator naming changes are here, but I did not revert them.

the whole validator interface naming is annoying and tbh I am a bit oblivious to why on earth does a single validator need to implement an interface in its own. then this whole ordeal of Validator vs ChunkValidator vs ChunksValidator vs ChunkValidators is prevented. or we can find some completely orthogonal name for the validator that checks all validators (validator, validator)

Thanks guys for very thoughtful reviews and the merge.


Bump terraform version 1.7.3

Refactor https://github.com/ZOSOpenTools/terraformport/pull/6 to make patches reusable.

/run test again as the prev one stalled / timed out for some reason.

/run tests
Prev one stalled / timed out for some reason.

/run tests

Ready to merge


CASMNET-1174

Summary and Scope
Add an option to retain LAG #s while generating configs.
PR checklist (you may replace this section):

[x] I have run nox locally and all tests, linting, and code coverage pass.
[x] I have added new tests to cover the new code
[x] My code follows the style guidelines of this project
[x] If adding a new file, I have updated pyinstaller.py
[x] I have updated the appropriate Changelog entries in readme.md
[x] I have incremented the version in the readme.md
[x] I have incremented the version in canu/.version

Issues and Related PRs
CASMNET-1174
Testing
Odin, virtual

@lukebates123
ttp.lazy_import_functions: failed to save ttp_dict_cache.pickle '[Errno 2] No such file or directory: '/tmp/_MEIdddent/ttp/ttp_dict_cache.pickle''
Traceback (most recent call last):
  File "canu/cli.py", line 318, in <module>
  File "site-packages/click/core.py", line 1128, in __call__
  File "site-packages/click/core.py", line 1053, in main
  File "site-packages/click/core.py", line 1659, in invoke
  File "site-packages/click/core.py", line 1659, in invoke
  File "site-packages/click/core.py", line 1659, in invoke
  File "site-packages/click/core.py", line 1395, in invoke
  File "site-packages/click/core.py", line 754, in invoke
  File "site-packages/click/decorators.py", line 26, in new_func
  File "canu/generate/network/config/config.py", line 392, in config
  File "canu/generate/switch/config/config.py", line 497, in generate_switch_config
  File "site-packages/ttp/ttp.py", line 230, in __init__
  File "site-packages/ttp/ttp.py", line 347, in add_template
KeyError: 'utils'
[64574] Failed to execute script cli

I believe we have a miss in pyinstaller.

Fanta data seems like many lags aren't getting read in from the running config (Mellanox).
interface mlag-port-channel None
interface mlag-port-channel None mtu 9216 force
interface mlag-port-channel None switchport mode hybrid
interface mlag-port-channel None description "sw-spine-001:1==>ncn-m001:pcie-slot1:1"
interface mlag-port-channel None no shutdown
interface mlag-port-channel None lacp-individual enable force
interface mlag-port-channel None description "sw-spine-001:2==>ncn-m002:pcie-slot1:1"
interface mlag-port-channel None description "sw-spine-001:3==>ncn-m003:pcie-slot1:1"
interface mlag-port-channel None description "sw-spine-001:4==>ncn-w001:pcie-slot1:1"
interface mlag-port-channel None description "sw-spine-001:5==>ncn-w002:pcie-slot1:1"
interface mlag-port-channel None description "sw-spine-001:6==>ncn-w003:pcie-slot1:1"

Why is this happening?  Suspect this isn't really meant for Mellanox atm.
If the lag number doesn't exist this should be an error, not None.


Automatic batching causes some requests to never return + large delays

Idk why, it broke memedows for a while.

Batching is no more for now, we'll see what happens if it's added back


Change application name

After changing applications name, this is not shown in gui. even after reload its not the new name.
--> Frontend sends wrong request updateoidcclientconfig instead of update application

:tada: This issue has been resolved in version 0.100.0 :tada:
The release is available on:

GitHub release
v0.100.0

Your semantic-release bot :package::rocket:


Default images are non-LTS Ubuntu

From the v0.5.3 release notes (https://github.com/docker/machine/releases/tag/v0.5.3), it mentions that "Most base images are now set to Ubuntu 15.10".  Is there a reason why we have a non-LTS Ubuntu as the default?  I'd expect to receive the latest LTS release when creating instances.  If it was to support overlay networks, that is not an issue anymore because 1.10 has support for kernel 3.10+ when using overlay networks.

We use the latest available.  It's fairly easy to get a custom version of Ubuntu (e.g. 15.04 or 14.04) through --amazonec2-ami-id or similar flags.


[cfe] No error if local variable is referenced before its initialization

The following test fails in CFE (works well in analyzer)
var x = 0;

f(y) {
  var z = x; // No expected error in CFE
//        ^
// [analyzer] unspecified
// [cfe] unspecified
  if (y) {
    x = x + 1; // No expected error in CFE
//  ^
// [analyzer] unspecified
// [cfe] unspecified
    print(x); // No expected error in CFE
//        ^
// [analyzer] unspecified
// [cfe] unspecified
  }
  var x = x++;
//        ^
// [analyzer] unspecified
// [cfe] unspecified
  print(x);
}

main() {
  f(true);
}

Tested on the edge (Sept 4, 2023) SDK on Linux x64

It seems that the CFE does report an error, but in a different way: the declaration of the local variable is treated as the error, and its uses before the declaration are treated as the context.
I suggest adjusting the error expectations for the test as shown below. @johnniwinther WDYT?
var x = 0;

f(y) {
  var z = x;
//        ^
// [analyzer] unspecified
  if (y) {
    x = x + 1;
//  ^
// [analyzer] unspecified
    print(x);
//        ^
// [analyzer] unspecified
  }
  var x = x++;
//        ^
// [analyzer] unspecified
//    ^
// [cfe] unspecified
  print(x);
}

main() {
  f(true);
}

Could we (easily?) report the error on the uses (instead of the declaration) ? It looks like that would be more hopeful.


MBbloom-- module support

https://github.com/RedisBloom/RedisBloom

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


'tokio-runtime-worker' panicked at src/lib.rs:804:9

Getting several errors in syslog as shown below:
 varnishd[3997540]: Child (3997553) said thread 'tokio-runtime-worker' panicked at src/lib.rs:804:9:
 varnishd[3997540]: Child (3997553) said called `Result::unwrap()` on an `Err` value: SendError { .. }

This is on Varnish 7.3.0 using vmod-reqwest 0.0.9.
Are those expected under any circumstances?
Thank you.

Hi, than kyou for reporting this!
that's not expected, it looks like the channel got broken, which could be because the task timed out and disappeared, maybe?
A few questions:

Does it happen often?
is there any chance the crashes are related to a VCL reload or other admin tasks?
can you share the VCL you are using?
what kind of backend is vmod_reqwest talking too?

cheers,

Thank you so much for your fast response.

Does it happen often?

For example, it happened about 24 times in the last 60 minutes.

No.

can you share the VCL you are using?

Unfortunately no, only parts of it.

what kind of backend is vmod_reqwest talking too?

Well, I am sending some PURGE requests to the same (self) Varnish instance.
Here is some VCL code.
sub vcl_init {
    new client = reqwest.client();
}

sub vcl_backend_response {
...
   if (beresp.http.SOMETHING) {
        client.init("async", "http://<IP_ADDRESS>:80", "PURGE"); # http://<IP_ADDRESS>:80 is self (the same Varnish instance)
        client.set_header(name="async",key="SOMETHING", value=beresp.http.SOMETHING);
        client.send("async");
   }
...

Thank you.

thanks, I'll try to reproduce that. It could be that the backend task finishes faster than the purge, so the core processor doesn't have anyone to send the response.
could you add that line after the client.send() please?
std.log(client.status("async"));

essentially we'll force the VCL to way for the response. It'll make the processing a tiny bit slower (a few milliseconds, I expect), but if it solves the issue, that's a clear indicator of where the problem lies

Indeed adding the client status logging fixed the issue.
No such errors given for the last 15 minutes after applying this.
Will keep watching this for more hours.
I guess that using a "sync" fetch instead of "async", would have also fixed that, but would be a bit slower, right?
Thank you for your help.

@gecon , I just pushed https://github.com/gquintard/vmod-reqwest/commit/c0e3d35a11d85361680ef67bd7c6e848b1c285ad which according to my testing fixes the issue, would you mind giving it a try?

actually, grab the latest commit from main, I caught a issue if varnish sends us empty buffers and fixed it

I use Varnish 7.3 so I applied your commits on Jul 3, 2024 on your v0.0.9 code and build the .so again.
I removed the std.log(client.status("async")); line from the VCL..
The fix seems to work.
There are no such errors afterwards.
Thank you very much for your prompt response and actions!

excellent, thank you @gecon for the confirmation and opening the issue too)!


Mail read/unread icon (envelope) indication inverted.

Expected behavior
When opening an unread email the mail status should change to 'read' and the envelope icon in the top navigation bar should change to 'open'. Then when trying to mark the message as unread by clicking on the envelope icon, the envelope should change to 'closed'
Actual behavior
When opening an unread email, its status changes to 'read', but the envelope icon remains 'unread' (closed). When returning to to message folder or overview, the message is clearely marked as read but even when going back into the message, the envelope icon is still closed.
Now when marking the message as unread via the envelope icon, the message status correctly changes to unread, but the envelope icon opens!
Steps to reproduce

open unread email
go back to inbox and check mail got marked as read
open the same (now read) email again
(step 2 & 3 are optional)
click on envelope icon
return to inbox and check read/unread status

Environment
K-9 Mail version: 5.702
Android version: 9
Account type (IMAP, POP3, WebDAV/Exchange): IMAP
Please take some time to retrieve logs and attach them here: -

I guess the envelope simply represents the action and not the actual state...

All the icons in the toolbar represent actions. If you long-press the envelope icon you'll also see "Mark unread" or "Mark as read" depending on the current state of the message. That's the action that will be performed when you press the icon.
Closing this issue because it's working as intended.

Was this different in versions <5.700 or why is this confusing the hell out of me?
The thing is, when clicking on it and the icon opens/closes it seems like a status indicator.
I've checked and in Gmail it actually has the same behavior as currently in k9 5.702. But the avoid confusion by automatically going back to the inbox when marking the mail as read from within the email.

The behavior hasn't changed from 5.600.


Adding DearAzure - AZ-INDIA Group

Adding DearAzure - AZ-INDIA Group

Hi @saineshwar . Welcome to the Global Azure 23. Are you planning to use Sessionize for your Call for Speakers? Thanks

Hi @saineshwar . Welcome to the Global Azure 23. Are you planning to use Sessionize for your Call for Speakers? Thanks

No, we already have speakers.

Ok sounds good. Thank you. Let's merge and close this PR. Thank you and let us know if you need any help to organize your event.
Have a great day.

Just to comment @saineshwar and @hugobarona, there is another reason to put up Sessionize. There does not neeed to be an open CFP. BUT, you can use Sessionize to show off your event sessions on globalazure.net! We can pull in your session set and put them in the catalogue so that potential attendees for your event can find you. Also, bragging rights! ;) Now, you are not required at all to use Sessionize in this capacity, but see it as an opportunity!


Contribution

Updated reference: Nikea to scikit-xray
Instructions on cloning using https option
Instructions for fetching upstream

Looks good other than a few minor line comments!  Thanks for doing this!

I made the changes.

I added 2 double colons

Looks good, thanks for updating!


resources: update endwalker effect ids

I didn't get gen_effect_id.ts to work, but I commented the ESLint part and let it write the text that is not linted to file and then lint it manually.
Oops, this patch break Samurai and Dancer, as there are changes

In the future could you try to make each PR pass CI? It's very hard for me to merge things when there are multiple patches that don't pass.  Ways you can do this differently in the future are:

if two patches must be submitted together (dancer/samurai/effects), then put them in the same PR (feel free to separate them into different commits)
if one patch depends on another patch but not vice versa, then you can change github to say you are merging into the other PR (vs merging into quisquous:main)

I will pull these and make sure they are ok locally and merge them, if so.

Ah, you are right. I'll do that in the future!


DBParameterGroup doesn't have the requested parameter value

What is the URL of the document?

Which section(s) is the issue in?

What needs fixing?

Additional context
I am currently trying to create the below DBParameterGroup. It can create james-rds-parametergroup-test, but when I check rds.logical_replication in AWS console, it doesn't have 1, but 0 (default value). Could you share exact example to create the parameter group w/ custom parameters?
apiVersion: rds.services.k8s.aws/v1alpha1
kind: DBParameterGroup
metadata:
  name: james-rds-parametergroup-test
spec:
  name: james-rds-parametergroup-test
  description: Test parameter group for ACK
  family: postgres13
  parameters:
    - parameterName: rds.logical_replication
      parameterValue: "1"

Hi @jamesseo-alation! Unfortunately, this is a known issue (see #869) :( I'm trying to figure out a clean solution to this...

/remove-lifecycle rotten

This is a duplicate of #869


Add security plugin check in startup script to to support bundle manifest for min distributions

Currently if the OpenSearch min bundle is run using opensearch-tar-install.sh script, it will fail due to lack of security plugin in the bundle.
Add security plugin check in the startup script.
This will help in generating bundle manifest with artifact location for the min snapshot artifact generated during distribution build.

I believe we need to check for any plugin configuration that goes in start up script. This includes:

Security
Performance Analyzer
K-NN

See start up scripts here: https://github.com/opensearch-project/opensearch-build/tree/main/scripts/startup

Hi @rishabh6788 I believe we can close this issue now since we added the check?


[ENH] Debugging - "raise" exception without actually raising an exception (print stack)

Is your feature request related to a problem? Please describe.
It would be super helpful to be able to print a stack trace like what is done in Python in traceback.print_stack() in Cython without having to raise an actual exception that halts the operation with a real Exception being raised.
https://github.com/cython/cython/issues/1755
Note:
import traceback
try:
  raise Exception()
except:
  traceback.print_exc()

does not work. It only prints the current line, not the stack trace.
Could someone explain if this is not feasible why it isn't?
Couldn't you just use the same insert fake stack traces code that's called when an exception is raised also when an exception isn't raised but the developer has used some special Cython keyword to denote the simulation of an Exception raised?
Describe the solution you'd like.
No response
Describe alternatives you've considered.
No response
Additional context
No response

The issue here is that Cython generates the traceback on demand as the exception propagates upwards. So at the point you catch it the only bit of stack trace that exists is for the line where the exception is thrown.
The main reason for that is to reduce overhead in the common (non-exception) case - we really don't want to be spending time tracking the call stack.
If we were to do this, it would probably have to be a compiler directive to turn it on so you'd only be able to get the full trace for functions where this is manually enabled.
I think it'd actually end up being a reasonable performance cost in a lot of cases so we wouldn't want to enable it by default.


Allow setting custom file extension from command line

By passing -DPD_EXTENSION=".pd_something" at command line, you can set a custom file extension.
So for example:
cmake .. -DPD_PATH=/Applications/Pd-0.55-0.app/Contents/Resources -DPD_EXTENSION=".pd_darwin"

or
cmake -BBuild -DPD_PATH=/Applications/Pd-0.55-0.app/Contents/Resources -DPD_EXTENSION=".pd_darwin"

(hold on, I think I made small mistake)