Accessing private parts of datasketches

We have noticed this recent change https://github.com/apache/druid/commit/e648b01afba52ee5b980d28b16b636e346a86819
This change introduced a piece of code which bypasses public API of DataSketches and accesses a private part of implementation.
https://github.com/apache/druid/blob/033989eb1d8f4f91268b2d7d4d3dc73af7bf2c3f/extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/theta/SketchAggregator.java#L60
We believe that it is problematic and can lead to wrong results.
We have this in our documentation:
/**

Although the gadget object is initially an UpdateSketch, in the context of a Union it is used
as a specialized buffer that happens to leverage much of the machinery of an UpdateSketch.
However, in this context some of the key invariants of the sketch algorithm are intentionally
violated as an optimization. As a result this object can not be considered as an UpdateSketch
and should never be exported as an UpdateSketch. It’s internal state is not necessarily
finalized and may contain garbage. Also its internal concept of “nominal entries” or “k” can
be meaningless. It is private for very good reasons.
*/

Thanks a lot for pointing this out, @AlexanderSaydakov ! I had missed this while making the changes in the mentioned commit.
What I really intended to do was get a better estimate of the memory used by a org.apache.datasketches.theta.Union.
As the Union interface does not expose a getCurrentBytes() or similar method, I had to resort to the reflection.
Please advise what would be a better way to achieve the same.

PLEASE, engage with us and help us understand what it is you are trying to do. If it means adding a public API to accomplish it, we are more than willing to do that.

Please don't take it personally that nobody reached out to you about the original problem. The Druid project is a big place with a lot of dependencies, and not all contributors are aware of how willing those various dependencies' maintainers are to work with us. Your willingness to work with us over the years is very much appreciated, as is the fact that you took the time to write up your concerns about this particular case.

The memory currently being used by a Union or Sketch is rather complex.

The commit is from #12073, #12022 which are trying to improve memory estimation in the on-heap indexing implementation. The goal of the patch is to decide when to spill an on-heap index to disk. To do this properly, we need a way to estimate the memory usage of the index. The patch works by adding an aggregateWithSize() method to on-heap aggregators that (1) does an aggregation and (2) returns the amount of additional memory use caused by that particular aggregation. Each aggregator is associated with a particular row in the index, so we then sum up the memory used by all aggregators in all rows to get the memory footprint of the entire index.
The private field in this case is being used by SketchAggregator to implement the memory-estimation piece of aggregateWithSize().
We shouldn't be using private fields like that, so we should find another way to solve the original problem.
One obvious solution I can think of is to use a simple formula, like something that is based only on the size parameter and the number of items added so far. I'm not sure how accurate this would be since I'm not super familiar with how the sketches internally manage their on-heap memory. But maybe it'd be close enough? If we do go this way, an implementation note: at ingestion time, it's likely that a small number of items get added to each sketch. (Like in the 1 to 50 range.) I think some sketches have a special mode they use when the number of added items is low, and whenever that is true, we'd want to take that into account to avoid overcounting memory usage.
@AlexanderSaydakov or @leerho do you have any other, better suggestions? & @kfaraz could you please work with them to implement a better solution when we come up with one?

As gian mentioned, the code is reaching in and grabbing the _gadget as a short-term solution to grab the number of bytes used.  It would absolutely be preferable for the UnionSketch to also expose the same .getCurrentBytes() method.
In terms of the implementation, the sketch that was grabbed is only being used to call .getCurrentBytes() and is used for no other purpose.  The memory counting structure works with deltas, so if reset was called and the number got smaller, there would then be a negative delta in memory usage and the memory consumption values would be updated accordingly.
The intention was always to open a ticket to request that the public API be extended.  We wanted to have a concrete example of why we needed the method rather than just asking for a random method, so we wanted the PR to actually exist before doing the request.  In the end, the request back to the datasketches got lost in the shuffle of getting the interface changes worked out, so that's our bad.

I have added a PR, mentioned just above, to directly address this issue.  It will be released with the next Java release which should be relatively soon since we also want to release a new KllDoublesSketch, plus a few other things.
I do respectfully request that you do not lock your "short-term" solution in a formal release.
Please note: the getCurrentBytes() method implemented here as well as in your "short-term" solution will only report a different value after the internal gadget goes through a resize when the current internal hash table is full. In between these resize events this method will return the value from the previous resize event.   If you serialize the union via toByteArray() the length of the byte array will exactly be the value returned by this method.  It also represents (approximately) how much RAM the union is using.
However, if you do union.toByteArray(union.getResult()), the size will generally be much smaller as the union has been "pulled back to K" and compacted.
We don't recommend that you actually serialize the union to either store to disk or to transport to another machine because it is so much larger than the compact sketch you get when you getResult().

The value is currently being used to estimate the total size in memory of the onheap Aggregator object, so the semantics that you mentioned are exactly what we want.  It's never used to determine or allocate the number of bytes actually required to store, persist or transport the sketch.
It's also perfectly fine that it doesn't always produce a new value.  That's understood and accounted for.
Thanks for such a quick turnaround on an update to the base library.  As soon as that's release, let us know and we will update the code to remove the reflection.

@gianm @imply-cheddar @kfaraz
This is to let you know that datasketches-java 3.2.0-RC1 is up for vote.  This release contains two important features requested by Druid or Druid users:

This release extends the quantiles KLL sketch to include both doubles
and float types as well as full updatable operation off-heap in contiguous memory.
This release also adds two new methods to Theta Union based on the
discussion on Druid issue # 12261:

getCurrentBytes() This behaves similarly to the Theta Sketch method
by the same name.
getMaxUnionBytes() This behaves similarly to the static Theta / Sketches
method by the same name, but is non-static and returns the maximum stored
bytes for this union given its nominal entries configuration.

If you would like to vote, please do :)
Thanks,
Lee.

Also, @AlexanderSaydakov is working to extend the DataSketches Druid adaptor to accommodate the new KllSketch.

@gianm @imply-cheddar @kfaraz
Question:
With the new datasketches-java 3.2.0-RC1 that is in vote right now, it is not possible to merge a KllFloatsSketch into a KllDoublesSketch as it will throw an error. Even if this were possible, you would naturally lose some accuracy (at the primitive level) going from a float to a double.  Nevertheless, it would be relatively straightforward to create a "converter tool" that would create a KllDoublesSketch from a KllFloatsSketch that one could use before a merge.    Is such a capability of interest in the Druid community?  If so, could it wait until the next datasketches-java release?

With the new datasketches-java 3.2.0-RC1 that is in vote right now, it is not possible to merge a KllFloatsSketch into a KllDoublesSketch as it will throw an error. Even if this were possible, you would naturally lose some accuracy (at the primitive level) going from a float to a double. Nevertheless, it would be relatively straightforward to create a "converter tool" that would create a KllDoublesSketch from a KllFloatsSketch that one could use before a merge. Is such a capability of interest in the Druid community? If so, could it wait until the next datasketches-java release?

If we're going to support using both at ingestion time, then I think a converter would be useful, since that would allow people to switch from the float sketch to the double sketch without creating a new column. However, I don't think it's essential enough to block datasketches-java releases. We will just need to document that at the current time, if you want to switch KLL sketch implementations, you should create a new column, and you can't merge sketches of two different types.

@abhishekagarwal87 fyi, I tagged this with 0.23.0 due to the discussion above. I hope we can include this change.

Sure thing, @gianm.

This is fixed by #12522 #12509


this._queries is not iterable

Have Pull Request nighyl extension installed.
I see this in VS Code insiders in the Developer Console:
TypeError: this._queries is not iterable
	at t.StateManager.<anonymous> (/Users/isidor/.vscode-insiders/extensions/github.vscode-pull-request-github-insiders-2020.6.34021/media/extension.js:1)
	at Generator.next (<anonymous>)
	at /Users/isidor/.vscode-insiders/extensions/github.vscode-pull-request-github-insiders-2020.6.34021/media/extension.js:1
	at new Promise (<anonymous>)
	at n (/Users/isidor/.vscode-insiders/extensions/github.vscode-pull-request-github-insiders-2020.6.34021/media/extension.js:1)
	at t.StateManager.setIssueData (/Users/isidor/.vscode-insiders/extensions/github.vscode-pull-request-github-insiders-2020.6.34021/media/extension.js:1)
	at t.StateManager.<anonymous> (/Users/isidor/.vscode-insiders/extensions/github.vscode-pull-request-github-insiders-2020.6.34021/media/extension.js:1)
	at Generator.next (<anonymous>)
	at /Users/isidor/.vscode-insiders/extensions/github.vscode-pull-request-github-insiders-2020.6.34021/media/extension.js:1
	at new Promise (<anonymous>)
	at n (/Users/isidor/.vscode-insiders/extensions/github.vscode-pull-request-github-insiders-2020.6.34021/media/extension.js:1)
	at t.StateManager.refresh (/Users/isidor/.vscode-insiders/extensions/github.vscode-pull-request-github-insiders-2020.6.34021/media/extension.js:1)
	at /Users/isidor/.vscode-insiders/extensions/github.vscode-pull-request-github-insiders-2020.6.34021/media/extension.js:1
	at l.fire (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:45)
	at /Users/isidor/.vscode-insiders/extensions/github.vscode-pull-request-github-insiders-2020.6.34021/media/extension.js:1
	at processTicksAndRejections (internal/process/task_queues.js:93)

Do you also see this with the latest version of the extension? (2020.6.41221) Have you modified the githubIssues.Queries setting?

@RMacfarlane I have not modified the githubIssues.Queries setting. I had extension auto update setting and I was using PR extension nightly, so yes I think I was on latest.

Plus 1.
I see this issue as well:
Error:
var Module=typeof DracoDecoderModule!=="undefined"?DracoDecoderModule:{};var isRuntimeInitialized=false;var isModuleParsed=false;Module["onRuntimeInitialized"]=function(){isRuntimeInitialized=true;if(isModuleParsed){if(typeof Module["onModuleLoaded"]==="function"){Module["onModuleLoaded"](Module)}}};Module["onModuleParsed"]=function(){isModuleParsed=true;if(isRuntimeInitialized){if(typeof Module["onModuleLoaded"]==="function"){Module["onModuleLoaded"](Module)}}};function isVersionSupported(versionString){if(typeof versionString!=="string")return false;const version=versionString.split(".");if(version.length<2||version.length>3)return false;if(version[0]==1&&version[1]>=0&&version[1]<=3)return true;if(version[0]!=0||version[1]>10)return false;return true}Module["isVersionSupported"]=isVersionSupported;var moduleOverrides={};var key;for(key in Module){if(Module.hasOwnProperty(key)){moduleOverridError: abort(TypeError: this._queries is not iterable). Build with -s ASSERTIONS=1 for more info.

Error: abort(TypeError: this._queries is not iterable). Build with -s ASSERTIONS=1 for more info.    at process.abort Z~/.vscode/extensions/cesium.gltf-vscode-2.2.12/node_modules/draco3dgltf/draco_decoder_gltf_nodejs.js:35:7672)    at process.emit (events.js:208:15)    at processEmit (~/.vscode/extensions/node_modules/signal-exit/index.js:161:1)    at process.emit (~/.vscode/extensions/zignd.html-css-class-completion-1.19.0/node_modules/source-map-support/source-map-support.js:453:21)    at processPromiseRejections (internal/process/promises.js:201:33)    at processTicksAndRejections (internal/process/task_queues.js:86:32)

Version:
Version: 1.47.3
Commit: 91899dcef7b8110878ea59626991a18c8a6a1b3e
Date: 2020-07-23T13:08:29.692Z
Electron: 7.3.2
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 19.5.0

This should have been fixed as part of 2a26ec7fb2b590ea40550c5677c81f241d7ec798, this._queries is now always initalized to an empty array.


updated hyperlinks in README to direct to docs

Coverage remained the same at 99.589% when pulling fd1f52907224689a7151c94b3ce7812bbeaf9a7c on babbush:develop into fd1f8a72855cad2277168fc0156b6a15e906c568 on quantumlib:develop.


Reading compressed json files

Is your feature request related to a problem? Please describe.
raw downloaded Red Pajama V2 data is stored in json.gz. Curator does not support reading from compressed json.
Describe the solution you'd like
support for reading compressed json files
Describe alternatives you've considered
first decompress using bash commands and then read the decompressed data.

Check in with @yyu22 to close this.

yes this can be close as dask can read compressed json


Correct the description of the behavior for omitted language/country

Based on the CRT's source code exploration

@ddv239 : Thanks for your contribution! The author, @corob-msft, has been notified to review your proposed change.

@ddv239 : Thanks for your contribution! The author, @corob-msft, has been notified to review your proposed change.

@ddv239 : Thanks for your contribution! The author, @corob-msft, has been notified to review your proposed change.


Issue found using atom, but tabnine-atom GH repo has issues disabled.

Sorry for the confusing non-sublime issue, but I wanted to make it clear that I'm not trying to file it here.

Whoops. Issues in tabnine-atom are now enabled.


[Hotfix][docs][checkstyle] Fix DummyInputFormat class lacks Javadoc

What is the purpose of the change
Fix DummyInputFormat class lacks Javadoc
Brief change log
Add Javadoc for DummyInputFormat
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot run azure

@flinkbot run azure

@flinkbot run azure


Could someone help me explain the sentences?

What is your question?
There is a function in PlayState.hx:
function goodNoteHit(note:Note):Void
{
	if (!note.wasGoodHit)
	{
		if(cpuControlled && (note.ignoreNote || note.hitCausesMiss)) return;   //sentence 1
                //...
               callOnLuas('goodNoteHit', [notes.members.indexOf(note), leData, leType, isSus]);   //sentence 2
                //...
        }
}

1、 What does sentence 1 do?
2、About sentence 2:
(1) Sentence 2 means I can use  function goodNoteHit in LUA Script, right?
(2) What are the meanings of the four parameters [notes.members.indexOf(note), leData, leType, isSus]? Could you give me an example of using this function in LUA Script?
Thanks very much!

"Sentence 2," calls the function goodNoteHit with parameters of:
Index of the Note, Note (0-3 being left, down, up, right), Note Type, Is Sustain Note
"Sentence 1" is an if condition, it checks for if cpuControlled is true and if the note is ignores or if the note is a hurt/bad note.

@NS-Unfair "Sentence 1" only has a return, return to where?

@NS-Unfair "Sentence 1" only has a return, return to where?

do you seriously not know what a return is?


Update html5lib-tests test to official repo

Blocked on:

[ ] https://github.com/html5lib/html5lib-tests/pull/136

If the tests end up moving to the WPT then we should switch to tracking that instead.

I updated the format of the description to try out the new github task lists, which are supposed to help track dependencies on other tickets. :shrug:

Nice, thanks!


Update the READMEs for the test/infra/azure

Description
Some minor updates in the test/infra READMEs.
Type of change

This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).
Fixes: #issue_number

Auto-generated summary

🤖[deprecated] Generated by Copilot at 3d369ae
Summary
:pencil2::art::memo:

The pull request enhances the documentation of the test infrastructure for the radius project by fixing the formatting and style of the README.md files in the ./test/infra and ./test/infra/azure directories.

A markdown file needed some fixing
The headings and links were quite mixing
So they changed the main title
And added some white space vital
To make the README.md more convincing

Walkthrough

Changed the heading level of the main titles in test/infra/README.md and test/infra/azure/README.md to follow the markdown convention (link, link)
Added blank lines before and after code blocks in test/infra/azure/README.md to improve the readability and formatting of the markdown document (link, link, link, link)
Wrapped URLs with angle brackets in test/infra/azure/README.md to make them clickable links in the markdown document (link, link, link)
Changed the bullet points from - to * in test/infra/azure/README.md to be consistent with the rest of the document (link, link)

/ok-to-test


NameError: uninitialized constant GovukComponentsHelper

I've been trying to add govuk-components to another rails service and came across this issue while trying to deploy the app to production. Everything seems to work and run correctly in development. I'm not sure if perhaps its a config setting in the rails app that is making the server fail when it starts up.
https://github.com/DFE-Digital/get-help-with-tech/pull/466#issuecomment-692632722

Interesting. I can recreate locally by changing config.load_defaults from 5.2 and 6.0 as you say in the referenced ticket.
It would appear that between the two versions of Rails, something has changed in the way helpers are loaded. There's more info here, I'll have a closer look over the next day or two.

Scratch the above, the helper module is called GovukComponentHelper (singular) and the file is govuk_components_helper.rb (plural), that's probably the cause. I'll fix it tomorrow.

I was wondering if it was because of the filename here https://github.com/DFE-Digital/govuk-components/blob/master/app/helpers/govuk_components_helper.rb  but inside the file the module is GovukComponentHelper


feat: show message box on close of feedback form

What does this PR do?
Shows message box on close of feedback form
Screenshot / video of UI

What issues does this PR fix or reference?
Closes #9192

Migration of forms in https://github.com/podman-desktop/podman-desktop/pull/10000 ! What a PR number 🥇💯


Add alpha quality support for rds DBCluster

Description of your changes
Add support for dbCluster in RDS using ACK code gen.
Steps followed till now -

Fixes #272
I have:

[x] Read and followed Crossplane's contribution process.
[x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested
Manual testing is in progress.

@muvaf opened this mr to replace https://github.com/crossplane/provider-aws/pull/489 and have  addressed all comments from there.
Going to work on manually testing it as the next step.

This is looking pretty good @hiteshghia ! I have a few comments but I think it's pretty close to merge. I have a few PRs up in code-generator that generates lateInitialize and isUpToDate (without this Update will never be called), so I can take care of those in another PR, no need to write them now.

@muvaf I was hoping to take a  stab at that as well next  after merging this, unless  there is rush to  get it in.

This is looking pretty good @hiteshghia ! I have a few comments but I think it's pretty close to merge. I have a few PRs up in code-generator that generates lateInitialize and isUpToDate (without this Update will never be called), so I can take care of those in another PR, no need to write them now.

@muvaf I was hoping to take a stab at that as well next after merging this, unless there is rush to get it in, lmk.

@muvaf I have attempted to address your comments but facing multiple issue, I am going to attempt to frame the story of things that are going wrong :

After the first commit in this PR, I could create a db cluster but the READY never updated to true for the managed resource and condition and the state/reason never updated to available. It was stuck in "creating" state. But in the aws console it was created/available fine.

During ^^ time the provider would go into crashloop backoff because of NPE in zz_controller.go as it expects filterList to be init.

So I went ahead added that in subsequent commit. Once I did that, the npe filterList went away but the provide reconciler loop would keep going into the Create method of the controller and keep erroring with DBCluster already exists.

At this point I did a make clean, deleted the .work vendored folder and refreshed all the dependencies. The DBCluster already error kept happening.

After which I decided to first fix the comments in the PR before starting to dig into the above error and stumbled into multiple different issues. I addressed all the comments in the PR in subsequent commits.

I addressed https://github.com/crossplane/provider-aws/pull/546#discussion_r576658849 and https://github.com/crossplane/provider-aws/pull/546#discussion_r576659384 in that order.

For the first pass for the VPCSecurityGroupIDs, I did not ignore it in the generator-config.yaml. But while creating the rds db cluster I started getting the following error:
2021-02-28T17:25:47.029-0800	DEBUG	provider-aws	Cannot resolve managed resource references{"controller": "managed/dbcluster.rds.aws.crossplane.io", "request": "/example-rds", "uid": "8863eb4b-cace-4b36-bdbe-ee00a02df8b3", "version": "120207", "external-name": "example-rds", "error": "cannot update managed resource: DBCluster.rds.aws.crossplane.io \"example-rds\" is invalid: spec.forProvider.vpcSecurityGroupIDs: Invalid value: \"null\": spec.forProvider.vpcSecurityGroupIDs in body must be of type string: \"null\"", "errorVerbose": "DBCluster.rds.aws.crossplane.io \"example-rds\" is invalid: spec.forProvider.vpcSecurityGroupIDs: Invalid value: \"null\": spec.forProvider.vpcSecurityGroupIDs in body must be of type string: \"null\"\ncannot update managed resource\ngithub.com/crossplane/crossplane-runtime/pkg/reconciler/managed.(*APISimpleReferenceResolver).ResolveReferences\n\t/Users/hghia/go/src/cd.splunkdev.com/crossplane/provider-aws/.work/pkg/pkg/mod/github.com/crossplane/crossplane-runtime@v0.12.1-0.20210219155338-30a941c3c3c6/pkg/reconciler/managed/api.go:147\ngithub.com/crossplane/crossplane-runtime/pkg/reconciler/managed.(*Reconciler).Reconcile\n\t/Users/hghia/go/src/cd.splunkdev.com/crossplane/provider-aws/.work/pkg/pkg/mod/github.com/crossplane/crossplane-runtime@v0.12.1-0.20210219155338-30a941c3c3c6/pkg/reconciler/managed/reconciler.go:551\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/Users/hghia/go/src/cd.splunkdev.com/crossplane/provider-aws/.work/pkg/pkg/mod/sigs.k8s.io/controller-runtime@v0.8.0/pkg/internal/controller/controller.go:293\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/Users/hghia/go/src/cd.splunkdev.com/crossplane/provider-aws/.work/pkg/pkg/mod/sigs.k8s.io/controller-runtime@v0.8.0/pkg/internal/controller/controller.go:248\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func1.1\n\t/Users/hghia/go/src/cd.splunkdev.com/crossplane/provider-aws/.work/pkg/pkg/mod/sigs.k8s.io/controller-runtime@v0.8.0/pkg/internal/controller/controller.go:211\nk8s.io/apimachinery/pkg/util/wait.JitterUntilWithContext.func1\n\t/Users/hghia/go/src/cd.splunkdev.com/crossplane/provider-aws/.work/pkg/pkg/mod/k8s.io/apimachinery@v0.20.1/pkg/util/wait/wait.go:185\nk8s.io/apimachinery/pkg/util/wait.BackoffUntil.func1\n\t/Users/hghia/go/src/cd.splunkdev.com/crossplane/provider-aws/.work/pkg/pkg/mod/k8s.io/apimachinery@v0.20.1/pkg/util/wait/wait.go:155\nk8s.io/apimachinery/pkg/util/wait.BackoffUntil\n\t/Users/hghia/go/src/cd.splunkdev.com/crossplane/provider-aws/.work/pkg/pkg/mod/k8s.io/apimachinery@v0.20.1/pkg/util/wait/wait.go:156\nk8s.io/apimachinery/pkg/util/wait.JitterUntil\n\t/Users/hghia/go/src/cd.splunkdev.com/crossplane/provider-aws/.work/pkg/pkg/mod/k8s.io/apimachinery@v0.20.1/pkg/util/wait/wait.go:133\nk8s.io/apimachinery/pkg/util/wait.JitterUntilWithContext\n\t/Users/hghia/go/src/cd.splunkdev.com/crossplane/provider-aws/.work/pkg/pkg/mod/k8s.io/apimachinery@v0.20.1/pkg/util/wait/wait.go:185\nk8s.io/apimachinery/pkg/util/wait.UntilWithContext\n\t/Users/hghia/go/src/cd.splunkdev.com/crossplane/provider-aws/.work/pkg/pkg/mod/k8s.io/apimachinery@v0.20.1/pkg/util/wait/wait.go:99\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1373"} 2021-02-28T17:25:47.029-0800	DEBUG	controller-runtime.manager.events	Warning	{"object": {"kind":"DBCluster","name":"example-rds","uid":"8863eb4b-cace-4b36-bdbe-ee00a02df8b3","apiVersion":"rds.aws.crossplane.io/v1alpha1","resourceVersion":"120207"}, "reason": "CannotResolveResourceReferences", "message": "cannot update managed resource: DBCluster.rds.aws.crossplane.io \"example-rds\" is invalid: spec.forProvider.vpcSecurityGroupIDs: Invalid value: \"null\": spec.forProvider.vpcSecurityGroupIDs in body must be of type string: \"null\""}

At which point I added ignored   CreateDBClusterInput.VpcSecurityGroupIds and  ModifyDBClusterInput.VpcSecurityGroupIds in the generator-config and added it as a custom param.

After doing that, the above error about vpcSecurityGroupId being null went away but I started getting -
2021-02-28T17:58:22.289-0800	DEBUG	provider-aws	Cannot create external resource	{"controller": "managed/dbcluster.rds.aws.crossplane.io", "request": "/example-rds", "uid": "8863eb4b-cace-4b36-bdbe-ee00a02df8b3", "version": "123049", "external-name": "example-rds", "error": "cannot create DBCluster in AWS: InvalidParameterValue: The parameter MasterUserPassword must be provided and must not be blank.", "errorVerbose": "InvalidParameterValue: The parameter MasterUserPassword must be provided and must not be blank.\ncannot create DBCluster in AWS\ngithub.com/crossplane/provider-aws/pkg/clients.Wrap\n\t/Users/hghia/go/src/cd.splunkdev.com/crossplane/provider-aws/pkg/clients/aws.go:644\ngithub.com/crossplane/provider-aws/pkg/controller/rds/dbcluster.(*external).Create\n\t/Users/hghia/go/src/cd.splunkdev.com/crossplane/provider-aws/pkg/controller/rds/dbcluster/zz_controller.go:119\ngithub.com/crossplane/crossplane-runtime/pkg/reconciler/managed.(*Reconciler).Reconcile\n\t/Users/hghia/go/src/cd.splunkdev.com/crossplane/provider-aws/.work/pkg/pkg/mod/github.com/crossplane/crossplane-runtime@v0.12.1-0.20210219155338-30a941c3c3c6/pkg/reconciler/managed/reconciler.go:670\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/Users/hghia/go/src/cd.splunkdev.com/crossplane/provider-aws/.work/pkg/pkg/mod/sigs.k8s.io/controller-runtime@v0.8.0/pkg/internal/controller/controller.go:293\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/Users/hghia/go/src/cd.splunkdev.com/crossplane/provider-aws/.work/pkg/pkg/mod/sigs.k8s.io/controller-runtime@v0.8.0/pkg/internal/controller/controller.go:248\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func1.1\n\t/Users/hghia/go/src/cd.splunkdev.com/crossplane/provider-aws/.work/pkg/pkg/mod/sigs.k8s.io/controller-runtime@v0.8.0/pkg/internal/controller/controller.go:211\nk8s.io/apimachinery/pkg/util/wait.JitterUntilWithContext.func1\n\t/Users/hghia/go/src/cd.splunkdev.com/crossplane/provider-aws/.work/pkg/pkg/mod/k8s.io/apimachinery@v0.20.1/pkg/util/wait/wait.go:185\nk8s.io/apimachinery/pkg/util/wait.BackoffUntil.func1\n\t/Users/hghia/go/src/cd.splunkdev.com/crossplane/provider-aws/.work/pkg/pkg/mod/k8s.io/apimachinery@v0.20.1/pkg/util/wait/wait.go:155\nk8s.io/apimachinery/pkg/util/wait.BackoffUntil\n\t/Users/hghia/go/src/cd.splunkdev.com/crossplane/provider-aws/.work/pkg/pkg/mod/k8s.io/apimachinery@v0.20.1/pkg/util/wait/wait.go:156\nk8s.io/apimachinery/pkg/util/wait.JitterUntil\n\t/Users/hghia/go/src/cd.splunkdev.com/crossplane/provider-aws/.work/pkg/pkg/mod/k8s.io/apimachinery@v0.20.1/pkg/util/wait/wait.go:133\nk8s.io/apimachinery/pkg/util/wait.JitterUntilWithContext\n\t/Users/hghia/go/src/cd.splunkdev.com/crossplane/provider-aws/.work/pkg/pkg/mod/k8s.io/apimachinery@v0.20.1/pkg/util/wait/wait.go:185\nk8s.io/apimachinery/pkg/util/wait.UntilWithContext\n\t/Users/hghia/go/src/cd.splunkdev.com/crossplane/provider-aws/.work/pkg/pkg/mod/k8s.io/apimachinery@v0.20.1/pkg/util/wait/wait.go:99\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1373"} 2021-02-28T17:58:22.289-0800	DEBUG	controller-runtime.manager.events	Warning	{"object": {"kind":"DBCluster","name":"example-rds","uid":"8863eb4b-cace-4b36-bdbe-ee00a02df8b3","apiVersion":"rds.aws.crossplane.io/v1alpha1","resourceVersion":"123049"}, "reason": "CannotCreateExternalResource", "message": "cannot create DBCluster in AWS: InvalidParameterValue: The parameter MasterUserPassword must be provided and must not be blank."}

For adding referencer for the master user password all I did was ignored that field in generator config and added MasterUserPasswordSecretRef *xpv1.SecretKeySelector json:"masterUserPasswordSecretRef,omitempty"`` in custom_types.go. I did not resolve any reeferences in referencer.go, but I am not sure how to handle that. rdsInstance eg that you pointed to is not really using code gen, rather uses the internal rds client which has some logic in getPassword method...

Please advice on how to proceed. Thanks.
@muvaf.

@muvaf ok I think I have addressed all comments. Two things to note - https://github.com/crossplane/provider-aws/pull/546#discussion_r586129671 and  https://github.com/crossplane/provider-aws/pull/546#discussion_r586058170

Thanks a lot @hiteshghia ! I'll follow up with a PR to fill the missing parts.


Citations should be DOI or pubmed

For pubmed IDs
http://www.ebi.ac.uk/ols/ontologies/obi/terms?iri=http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FOBI_0001617
http://purl.obolibrary.org/obo/OBI_0001617

DOI
http://www.ebi.ac.uk/ols/ontologies/cheminf/properties?iri=http%3A%2F%2Fpurl.org%2Fontology%2Fbibo%2Fdoi
http://purl.org/ontology/bibo/doi

Not sure how to use these in the links.  Also, currently citations are dropped.

Changed annotation for PubMed Number and added rendering of citation to collection page.


[2.x] Fix unexpected JSON resource serialization

Continuation of #432 as it remains a problem in the latest version of Inertia.
I was in the process of porting the project to Inertia and I encountered a very unexpected issue with the JSON resources serialization. Some had a different structure in comparison to the one returned from API routes - a data wrapper was present.
I tinkered with the source code and discovered that the issue lies in how resources are being serialized in the response master/src/Response.php#L136.
I was surprised to find out that the FakeResource used for tests has a $wrap property set to null to mitigate this issue but that has not been documented anywhere. Without this property, the test for response with JSON resource fails.
To fix this unexpected behavior I changed the logic for resource serialization to make sure not to use the data wrapper.

Hey thanks for this contribution!
This issue has come up in the past, see #93.
My concern with this change is that it's a pretty big breaking change that would require updating your page components to use the non-wrapped version of the data.
To this point I've recommended that people using resources put JsonResource::withoutWrapping in their app service provider, and that way folks can opt-in to this behavior by using this existing Laravel option.
We could bake this opinion into this adapter directly, but (at least from what I can tell) there would be no way to opt-out of it, so we need to make sure that's the right decision.
Unfortunately I don't use resources in my Inertia apps, so I can't really speak to this. I'm going to ask around to see what others think 👍
Either way it would have to be included as part of a major version release, which we are planning to do soon, so if we do want to make this change the timing is right.

I use JSON resources in my Inertia projects all the time. Why? So I can filter out data that I don't want to share publicly and add more properties at the same time (e.g. relations, computed attributes, etc...), all from a centralized location that I can reuse.
Personally, I've always found the data wrapping annoying, but I've never disabled it because of another annoyance: the $wrap property on JsonResources can be set to null to prevent wrapping, but it doesn't work when you instantiate a collection like this: ExampleResource::collection($models).
Related issues/PRs:

https://github.com/laravel/framework/issues/49155
https://github.com/laravel/framework/pull/43463

So, I'm all for disabling the JSON data wrapping for the next major release 👍
I understand that some people may not want to change all the references in their projects,  so could we add a global configuration to revert back to the old data-wrapping behavior?

@TheDoctor0 Hey I think we're going to make this change for 2.x. Would you mind resolving the conflicts and also adding a test for this (assuming it's not too hard to test)?

@reinink of course, I will update the PR whenever I have some free time this week.

@TheDoctor0 great, thanks!

@reinink change ported to 2.x version and covered with tests.


enhance/tutorial updates

remove skip welcome tutorial
update tutorial

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Fix various spelling and grammar bugs

Thanks for this tutorial. Here's a PR for various typos I found working through it.

Thank you @rwillmer! 🙏


Secure connections with latest OSDP Spec [SBCK]

So the newer Spec has deprecated the Master key approach (I don't have the Spec).
I was wondering if there is any plan to update this amazing framework to support SCBK

Sorry replying late.   I don't have the newer spec as well. I probably can refer to other language implement for this.


Bonding information in PDB from standard tables

PBD CONNECT record is only needed for bonds that are not in the standard table for connectivity. Chemfiles should use this table to be able to have all bonds in the system.

I can not find these "standard residue connectivity table" described in the PDB standard, so I am going to close this.
If you have more information on this matter, please share!


Phone Number use

If the configured international phone number is used, is it a human making that call from MSRC or is it an automated system? If the phone number requires options to be pressed, asking this question to understand whether a 24 hour helpdesk number with options can be used or if an automated system is used.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0a455a24-920e-f9f8-7a6f-60b5f4019acd
Version Independent ID: e6a4d8e2-0ada-e535-810f-5eb19e45ee1e
Content: Provide security contact details in Azure Security Center
Content Source: articles/security-center/security-center-provide-security-contact-details.md
Service: security-center
GitHub Login: @memildin
Microsoft Alias: memildin

@NTDS, thanks for the question.
The phone number is not used today and MSRC will not call you about security events.
This email notification settings page will shortly be changed, and the phone number field will be removed.
The documentation will of course also be updated.
Please be in touch if you have any further questions.

#please-close


Remove dep of postgresql

We are not using postgresql in indy anymore. Due to some CVE
reporting, let's remove it.

LGTM.


[Logging] log context redefined with XCC when use zephyr logging api with SOF

Describe the bug
According to the document here: https://docs.zephyrproject.org/latest/reference/logging/index.html, I defined log context with LOG_MODULE_REGISTER or LOG_MODULE_DECLARE, and for inline functions in header file, I used LOG_MODULE_DECLARE within that function. But I can not compile SOF application with XCC, and GCC is good.
Errors when use XCC to compile:
modules/sof/libmodules_sof.a(kpb.c.obj): In function `z_log_printf_arg_checker':
(.bss.__log_current_dynamic_data$24337+0x0): multiple definition of `__log_current_dynamic_data$24337'
modules/sof/libmodules_sof.a(pipeline-stream.c.obj):(.bss.__log_current_dynamic_data$24337+0x0): first defined here
modules/sof/libmodules_sof.a(idc.c.obj): In function `z_log_printf_arg_checker':
(.bss.__log_current_dynamic_data$24137+0x0): multiple definition of `__log_current_dynamic_data$24137'
modules/sof/libmodules_sof.a(pipeline-params.c.obj):(.bss.__log_current_dynamic_data$24137+0x0): first defined here
modules/sof/libmodules_sof.a(idc.c.obj):(.bss.__log_current_dynamic_data$24337+0x0): multiple definition of `__log_current_dynamic_data$24337'
modules/sof/libmodules_sof.a(pipeline-stream.c.obj):(.bss.__log_current_dynamic_data$24337+0x0): first defined here

Patch to replace SOF log calls with zephyr API:
5411.patch.txt
If I make some functions not inline, the issue can not be reproduced: https://github.com/thesofproject/sof/pull/5459
To Reproduce

Clone sof repo: git clone https://github.com/thesofproject/sof.git
Apply the patch: 5411.patch.txt
Go to SOF directory, clone zephyr repo with: ./script/xtensa-build-zephyr.py -c
export XTENSA_TOOLS_ROOT=xtensa-tool-path.
build SOF+Zephyr with ./script/xtensa-build-zephyr.py tgl

Or with zephyr style, you can apply my patch to SOF module, and build SOF.
Expected behavior
SOF replace with zephyr logging api, it should be built.
Environment (please complete the following information):

Toolchain: XCC
Commit SHA: e186ebc314

This is due to the use of LOG_MODULE_DECLARE() inside the inline function in component-ext.h. AFAICT, XCC emits the same symbol names based on the source file for those static variables inside functions (hence the same number after the dollar sign). Because of this, multiple use of these inline functions (e.g. comp_params()) across different C files will result in same symbol names in all the corresponding object files. During linking, all these object files have symbols of the same name, and thus failing. Later version of GCC is smarter about this situation and does not emit these type of symbols anymore. However, due to XCC being horribly outdated, we are stuck with this kind of issue. This is not an issue with the logging subsystem, but an issue with XCC. A workaround would be do create a dedicated logging printf-like function in C file for components, and use LOG_MODULE_DECLARE() these instead of having them in all those inline functions.

A workaround would be do create a dedicated logging printf-like function in C file for components, and use LOG_MODULE_DECLARE() these instead of having them in all those inline functions.

You mean I should create a function which wraps LOG_INF/LOG_ERR/LOG_WRN/LOG_DBG, and use LOG_MODULE_DECLARE() within the function? This looks like four functions, because we have four log levels.  Could you please explain more detailed

Since those inline functions call, e.g., comp_err(), you can create some wrappers to functions which eventually call LOG_*(), as long as these new functions are in a C file.

Once the PR in SOF is merged, could you close this issue once you have confirmed that it is no longer an issue? Thanks.

Since the PR in SOF has been merged, is this still an issue for you?

Liam suppose this will be fixed later, alright, let's close for now.


Added onRemove callback and fixed React setState() warning

Hi,
Let me know if you would like to use this change or would like me to make changes. I needed a handy way to know when a notification was removed.
Also, thanks for a flexible and easy to use package.
Thanks,
-Gavin

Thanks for the contribution @gj262. Merged.


import/export DBF files (xBase/dBase format)

Original author<EMAIL_ADDRESS>(November 11, 2010 07:33:35)
Ability to open/import .dbf files from shapefile sets(.shp, .dbf, .shx, etc.), and ability to save back to/export as .dbf.
I've attached a sample shapefile set.
Eric Jarvies
Original issue: http://code.google.com/p/google-refine/issues/detail?id=186

OpenLibre supports importing DBF files and then saving as CSV.
Closing issue as will not support, since there is a pretty easy open source workaround.

Here's a link to the help page for the feature in the latest version of OpenLibre. https://help.libreoffice.org/7.2/en-US/text/scalc/guide/dbase_files.html

I'm not sure the existence of an external utility makes this feature request unneeded/undesirable. There's plenty of functionality that we bundle to make things easier for users. Also GIS Shapefiles are based on this standard. It looks like JavaDBF and xBaseJ are still the two main contenders in this space.

@tfmorris Ah good find for resurrection.  Agree, let's reopen this as we've heard from a more GIS folks about better support in OpenRefine.  This issue will help.

@tfmorris wouldn't it make sense to use Geotools and it's ecosystem of plugins?  https://docs.geotools.org/stable/userguide/library/data/shape.html
They are used also in Geoserver


Application launch hooks

Changes

Implemented applications launch hooks

Hooks are executed before or after application launch and has access to launching context <ApplicationLaunchContext>
They are executed by order (attribute on hook) lowest -> highest -> None
Pre launch hooks:

Are executed before application process is opened.
Are meant for changing environments, modify launch arguments, prepare workfile from template etc.
If one will crash others won't continue and application won't be started.
If crash is caused by known issue it is expected to raise ApplicationLaunchFailed exception with user readable message.

Post launch hooks:

At the moment won't affect anything and error messages are not captured and showed.
Crash of one won't affect others.

New classes:

LaunchHook - base abstract class of launch hook which contain launch hook logic, should not be used as base for hooks
PreLaunchHook - inherit from LaunchHook currently do not contain any modifications in logic - abstract class for prelaunch hooks
PostLaunchHook - inherit from LaunchHook currently do not contain any modifications in logic - abstract class for postlaunch hooks
currently classes PreLaunchHook and PostLaunchHook are implemented only to help differentiate if should be executed before or after application launch, but may contain different code in the future
LaunchHook on the other hand should not be used as base class for hooks. It is possible to do so but hook will never load.

Launch hooks are file based python scripts which must contain class definition which inherit from classes PreLaunchHook or PostLaunchHook

I used prefix for hook filenames pre_* and post_* to differentiate between them. (It is not requirement)
Filenames starting with underscore _ are skipped.

Converted (and modified) current hooks and added few new:

Created global pre launch hook which works only on host applications.

Prepare host environments, context environments and collect data about last workfile
Copied code which was in ApplicationLaunchContext and was executed all the time

Created global post launch hook which cares about ftrack changes (change status, start timer etc.)

Copied code which was in ApplicationLaunchContext and was executed all the time

Implemented prelaunch hooks for NukeX, NukeStudio, Hiero to add launch argument after executable (and add last workfile path)
Implemented prelaunch hooks for Photoshop, AfterEffect, Harmony and TVPaint where python script must be executed instead of application executable

Tested:

[x] Photoshop
[x] AfterEffect
[ ] Harmony
[x] TVPaint

Converted Unreal, Celaction and Fusion hooks

Tested:

[ ] Unreal
[ ] Celaction
[ ] Fusion

Ftrack sync to avalon can use application manager for validations of applications on sync

added TVPaint, Adobe AfterEffects (2020, 2021) and Adobe Photoshop 2021 to applications settings

Questions

Should be LaunchHook renamed to _LaunchHook so it's visible it should not be used.
I don't like posthook, are you OK with post? Any better suggestions?

TODO

Better hooks paths getter + how to add (register) different paths to hooks (for Ftrack etc.).

With this, we are limiting the launch arguments in the executables. We should add the option to add arguments directly to the executable field.
Let's use executable field directly to verify it, in cases where it doesn't contain "", but if we find quotes in the path, we'll consider it's content to be executable and everything else it's arguments. that way we can still tweak arguments directly in the settings without touching the pre-hooks, and pre-hooks will only append extras

With this, we are limiting the launch arguments in the executables. We should add the option to add arguments directly to the executable field.

@mkolar wouldn't be more user friendly to add app attribute launch_arguments?

As we discussed on friday it would be safer to separate executable and arguments to different inputs.
Before I can do that there are needed changes from https://github.com/pypeclub/pype/pull/762/files so I have to wait for that.
How it may look:


Support rollover for archive storage

When --es-archive.enabled=true --es-archive.use-aliases=true are present in the storage options the rollover init (ES storage dependency) and rollover rollover (cron job) jobs should be created.

General question: What are the implications if the CR enables and then disables these options? (same for normal storage i.e. non-archive).
Do we need the operator to perform any additional actions when enabling rollover where ES cluster already exists - and similarly if moving from using rollover to no longer using rollover?

General question: What are the implications if the CR enables and then disables these options? (same for normal storage i.e. non-archive).

none, rollover is enabled or disabled purely based on storage options - see my first comment.

Do we need the operator to perform any additional actions when enabling rollover where ES cluster already exists - and similarly if moving from using rollover to no longer using rollover?

migration to/from rollover/daily indices is not supported. Users would have to do that manually. Migration from rollover to daily indices might be challenging and we haven't considered it when we were working on rollover.

@jpkrohling Is there any way the operator could prevent such upgrades? i.e. if user goes from a valid to an invalid state - prevent the invalid state being acted upon?

We should probably have the same check when changing storage backends or strategies.

Sort of. We cannot prevent updates to the CR, but we can revert the user's change. Inside the controller's applyElasticsearch, we could place a check and verify this specific case. If the new value is incompatible with the previous, revert the change and continue the reconciliation, so that the updated CR is persisted.

We should probably have the same check when changing storage backends or strategies.

We support changing storage backends and strategies.


reinitialize tracker for same object

I want to reinitialize the tracker which completely scan the image for the same object. If object is lost then tracker stays at the position where it lost, but if enters from some another side then tracker doesn't identify it.
Is there any solution for that?

Solved:-)

Hi, If you are still alive after covid and everything happened in these two crazy years. how did you solve that issue. am facing the same issue.


add CDE website & api

adds CDE Website and API
I'm just winging this based on your config file, I havent tried this on my machine

I was confused by all these commits on my PR. but maybe that's just how this works


May need a procedure for separating export of specimen table in case of mixed collections

At the moment this is theoretical. No use case as yet.

It is already possible to separate out records in table specimen by "collectionid".


Webhook bugfix: ClusterSecretStore with caProvider type Secret does pass the secret's namespace

Problem Statement
ClusterSecretStore with Webhook provider using caProvider type Secret becomes unready when upgrading past v0.9.12 with the error failed to get cert from secret: failed to resolve secret key ref: cannot get Kubernetes secret "redacted": an empty namespace may not be set when a resource name is provided
This occurs even when a namespace is provided in spec:
spec:
  provider:
    webhook:
      caProvider:
        key: <redacted>
        name: <redacted>
        namespace: <redacted>
        type: Secret

Related Issue
https://github.com/external-secrets/external-secrets/issues/3959
Proposed Changes
Add StoreKind to wh when creating a new client so that it is available within the call to whClient.wh.GetHTTPClient(ctx, provider)
Checklist

[x] I have read the contribution guidelines
[x] All commits are signed with git commit --signoff
[ ] My changes have reasonable test coverage
[x] All tests pass with make test
[x] I ensured my PR is ready for review with make reviewable

I'm unsure if this fix requires additional test coverage, but I'm happy to add some if necessary.

/ok-to-test sha=fbdfb51071b46da00900136ec94c1bf836e05887


test: Wait for POD readiness before test steps

Applying an L7 policy may make 'httpGet' readiness probes fail for the
duration the policy is in effect. Reduce test flakiness by waiting for
POD readiness before applying any policies in the individual test
steps.
Signed-off-by: Jarno Rajahalme<EMAIL_ADDRESS>

test-me-please

test-gke

test-me-please

Coverage increased (+0.01%) to 42.64% when pulling fb5a2a3482f391a8ada2d63b58a8d2af987db178 on pr/jrajahalme/test-wait-for-pod-readiness-before-tests into 61c2b4d02b562d4fc7a37e1048c41d566b12e5ef on master.

I was looking into these flakes last week also, will see how it behaves now.


Fixed: correct conversion from unsigned int to int. private data memb…

…ers rename,initial frame for video verification is faster

Changes moved to SDK-3231


add xrefs to COVID-19

this addresses Paola's request in #1216
@ShahimEssaid please check the diff, I think it is okay, but want to confirm

talked to @ShahimEssaid, okay to merge (if the build passes)


Allow exporting PCK files without export templates installed

It's not necessary to have compiled export templates to export a PCK. When doing a quick test, the Godot editor executable can be used to run a PCK, no export template required. This PR un-disables the Export PCK button when export templates are missing.
This work was sponsored by The Mirror.

needs rebase

Thanks!

Cherry-picked for 3.6.


Create example.domain.dev.json

Requirements

[x] You have completed your website.
[x] The website is reachable.
[x] The CNAME record doesn't contain https:// or /.
[x] There is sufficient information at the owner field.

Description

Website Link / Preview

Closed for lack of activity/response.


x/build/cmd/coordinator: misc/cgo/testplugin.TestIssue25756pie fails on darwin-arm64 builder deterministically but only in sharded mode

CL https://go-review.googlesource.com/c/go/+/319489 added a test to misc/cgo/testplugin. The test is failing in the darwin-arm64 builder.
Interestingly, I cannot reproduce the failure locally on a darwin-arm64 machine, by running cd GOROOT/misc/cgo/testplugin; go test. I also cannot reproduce the failure on gomote, by running gomote run $VM go/bin/go tool dist test testplugin or gomote run $VM go/src/all.bash.
But it does fail consistently on the build dashboard and with trybot ( https://storage.googleapis.com/go-build-log/d4df70bf/darwin-arm64-11_0-toothrot_5af7c061.log )
Maybe there is some unusual setting on the builder?
cc @toothrot  @cagedmantis @dmitshur

This test has also passed for me locally on an M1 machine with macOS 11.3.1, so it seems like a builder issue. I'll try to look at why it's failing in post-submit but not via gomote.

The test also passes on the builder as invoked during release tests (i.e., with something like release -target=darwin-arm64 -version=go1.17beta123 -watch -rev=ff7d5f97b3375a87e2de90f42e96983e5f0f95a4). This supports a theory that the problem could be related to coordinator using SplitMakeRun mode (where it compiles, then snapshots, then run the tests) during TryBots and post-submit builds.

This supports a theory that the problem could be related to coordinator using SplitMakeRun mode

That suggests a possible connection to #33598.

I've investigated this more today. The test is passing on a physical darwin/arm64 machine, via sequential (non-sharded) test execution, when executed on its own, but failing specifically when executed by cmd/coordinator in sharded test mode on this builder. It's really nice that it fails so reproducibly and gives us a chance to investigate it, as it's likely the root cause for this problem may shared across more builder issues, though the feedback loop is quite slow.
Getting to the bottom of it will take longer, so I'll send a CL to skip the test for now, so that its failure doesn't mask other darwin/arm64 regressions in the mean time.

I confirmed that the test passes on MacOS 12 as a simple all.bash invocation. I'll add a skip matching https://go-review.googlesource.com/c/go/+/321349/.

This seems to be fixed.  We are running the test and nobody is complaining.


BUG @Schema#implementation not processed on properties when generating open api 3.1.0

Problem
When generating OpenAPI 3.1.0 spec the @Schema#implementation value on a property is ignored.
Expected behaviour
@Schema#implementation  is considered also in OAS3.1
Reproducer
The issues is reproduced in the following test (note that the test is successful if the model resolvers generate OAS3.0.1 instead):
    @Test(description = "Shows that @Schema#implementation is not propagated from property when using oas 3.1.0")
    public void testModelWithCustomSchemaImplementationInPropertyForOas31() {

        String expectedYaml = "ModelWithCustomSchemaImplementationInProperty:\n" +
                "  type: object\n" +
                "  properties:\n" +
                "    exampleField:\n" +
                // the expected type is int rather than string as we override the type with @Schema(implementation = Integer.class)
                "      type: integer\n" +
                "      format: int32\n";

        Map<String, io.swagger.v3.oas.models.media.Schema> stringSchemaMap = ModelConverters.getInstance(true).readAll(ModelWithCustomSchemaImplementationInProperty.class);

        // fails as @Schema#implementation is not processed and therefore the original property type is used (String)
        SerializationMatchers.assertEqualsToYaml31(stringSchemaMap, expectedYaml);
    }

    static class ModelWithCustomSchemaImplementationInProperty {

        @Schema(implementation = Integer.class)
        private String exampleField;

        public String getExampleField() {
            return exampleField;
        }

        public void setExampleField(String exampleField) {
            this.exampleField = exampleField;
        }

    }

Investigation with proposed solution
Looking at the ModelResolver code, it seems that @Schema annotation is not propagated when attempting to resolve a model for a property (it is excluded from context annotations in ModelResolver#682). There is an attempt to reconcile this information at ModelResolver#719 (through AnnotationsUtils.getSchemaFromAnnotation). Information from @Schema#implementation is not used here but I imagine that it is necessary to use this information before attempting to resolve the model rather than after as it seems central in the model resolution process. Therefore I wonder if possibly overriding the AnnotatedType#type  used for context.resolve in ModelResolver#716 could be a proper solution for the issue?

Fixed by #4720, will be a part of newest release.


[AutoPR cognitiveservices/data-plane/CustomVision/Training] Custom vision 3 1

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/7074

(message created by the CI based on PR content)


data.plt.ccc_circos_plot does not exist any more

data.plt.ccc_circos_plot(res_key='cell_cell_communication') called in Cell_Cell_Communication tutorial  gives an error message: 'NoneType' object is not callable.
Is this function moved elsewhere or renamed?

Which version of stereopy are you using? ccc_circos_plot is added on version 0.14.0b1, if it isn't, you need to reinstall to this version by specifying explicit version number because it is only a beta build.
Running command: pip install --force-reinstall stereopy==0.14.0b1


gdal: switch to openexr_3

There are several CVEs affecting openexr v2 and it seems to disturb people. As gdal supports openexr v3, let's live in the future and upgrade this dep.
Fix #366916

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I agree with this change. Thanks for acting on this so quickly @autra .

Flagging as security related.

Result of nixpkgs-review pr 366939 run on x86_64-linux 1

15 packages marked as broken and skipped:

python311Packages.python-mapnik
python311Packages.python-mapnik.dist
python311Packages.rio-tiler
python311Packages.rio-tiler.dist
python311Packages.worldengine
python311Packages.worldengine.dist
python312Packages.python-mapnik
python312Packages.python-mapnik.dist
python312Packages.rio-tiler
python312Packages.rio-tiler.dist
python312Packages.shimmy
python312Packages.shimmy.dist
python312Packages.worldengine
python312Packages.worldengine.dist
t-rex

1 package failed to build:

apacheHttpdPackages.mod_tile

162 packages built:

cloudcompare
entwine
gdal (python312Packages.gdal)
gdalMinimal
gmt
gplates
grass
mapcache
mapnik
mapproxy
mapproxy.dist
mapserver
merkaartor
mysql-workbench
octavePackages.mapping
openorienteering-mapper
otb
paraview
pdal
perl538Packages.Tirex
perl538Packages.Tirex.devdoc
perl540Packages.Tirex
perl540Packages.Tirex.devdoc
postgresql13JitPackages.postgis
postgresql13JitPackages.postgis.doc
postgresql13Packages.postgis
postgresql13Packages.postgis.doc
postgresql14JitPackages.postgis
postgresql14JitPackages.postgis.doc
postgresql14Packages.postgis
postgresql14Packages.postgis.doc
postgresql15JitPackages.postgis
postgresql15JitPackages.postgis.doc
postgresql15Packages.postgis
postgresql15Packages.postgis.doc
postgresql16JitPackages.postgis
postgresql16JitPackages.postgis.doc
postgresql16Packages.postgis
postgresql16Packages.postgis.doc
postgresql17JitPackages.postgis
postgresql17JitPackages.postgis.doc
postgresql17Packages.postgis
postgresql17Packages.postgis.doc
python311Packages.bsuite
python311Packages.bsuite.dist
python311Packages.cartopy
python311Packages.cartopy.dist
python311Packages.django-bootstrap4
python311Packages.django-bootstrap4.dist
python311Packages.django-bootstrap5
python311Packages.django-bootstrap5.dist
python311Packages.drf-extra-fields
python311Packages.drf-extra-fields.dist
python311Packages.fiona
python311Packages.fiona.dist
python311Packages.folium
python311Packages.folium.dist
python311Packages.gdal
python311Packages.geoarrow-pandas
python311Packages.geoarrow-pandas.dist
python311Packages.geoarrow-pyarrow
python311Packages.geoarrow-pyarrow.dist
python311Packages.geodatasets
python311Packages.geodatasets.dist
python311Packages.geopandas
python311Packages.geopandas.dist
python311Packages.geoparquet
python311Packages.geoparquet.dist
python311Packages.inequality
python311Packages.inequality.dist
python311Packages.libpysal
python311Packages.libpysal.dist
python311Packages.mapclassify
python311Packages.mapclassify.dist
python311Packages.momepy
python311Packages.momepy.dist
python311Packages.morecantile
python311Packages.morecantile.dist
python311Packages.msticpy
python311Packages.msticpy.dist
python311Packages.netbox-documents
python311Packages.netbox-documents.dist
python311Packages.osmnx
python311Packages.osmnx.dist
python311Packages.plotnine
python311Packages.plotnine.dist
python311Packages.pygmt
python311Packages.pygmt.dist
python311Packages.pyogrio
python311Packages.pyogrio.dist
python311Packages.rasterio
python311Packages.rasterio.dist
python311Packages.rioxarray
python311Packages.rioxarray.dist
python311Packages.shimmy
python311Packages.shimmy.dist
python311Packages.wktutils
python311Packages.wktutils.dist
python312Packages.bsuite
python312Packages.bsuite.dist
python312Packages.cartopy
python312Packages.cartopy.dist
python312Packages.django-bootstrap4
python312Packages.django-bootstrap4.dist
python312Packages.django-bootstrap5
python312Packages.django-bootstrap5.dist
python312Packages.drf-extra-fields
python312Packages.drf-extra-fields.dist
python312Packages.fiona
python312Packages.fiona.dist
python312Packages.folium
python312Packages.folium.dist
python312Packages.geoarrow-pandas
python312Packages.geoarrow-pandas.dist
python312Packages.geoarrow-pyarrow
python312Packages.geoarrow-pyarrow.dist
python312Packages.geodatasets
python312Packages.geodatasets.dist
python312Packages.geopandas
python312Packages.geopandas.dist
python312Packages.geoparquet
python312Packages.geoparquet.dist
python312Packages.inequality
python312Packages.inequality.dist
python312Packages.libpysal
python312Packages.libpysal.dist
python312Packages.mapclassify
python312Packages.mapclassify.dist
python312Packages.momepy
python312Packages.momepy.dist
python312Packages.morecantile
python312Packages.morecantile.dist
python312Packages.msticpy
python312Packages.msticpy.dist
python312Packages.netbox-documents
python312Packages.netbox-documents.dist
python312Packages.osmnx
python312Packages.osmnx.dist
python312Packages.plotnine
python312Packages.plotnine.dist
python312Packages.pygmt
python312Packages.pygmt.dist
python312Packages.pyogrio
python312Packages.pyogrio.dist
python312Packages.rasterio
python312Packages.rasterio.dist
python312Packages.rioxarray
python312Packages.rioxarray.dist
python312Packages.wktutils
python312Packages.wktutils.dist
pytrainer
pytrainer.dist
qgis
qgis-ltr
qmapshack
saga
sumo
survex
therion
tunnelx
udig
vpv

I think, even more correct solution would be to update default openexr version from 2 to 3

I think, even more correct solution would be to update default openexr version from 2 to 3 . But that's much bigger task.

Indeed. Should v2 be marked as insecure? (can we affort that?) It's a bit above my paygrade but some of these CVEs seems quite serious. Someone more knowledgeable in security should check though :-)

I've opened a followup: https://github.com/NixOS/nixpkgs/pull/367406  for the rest of the packages.

I think, even more correct solution would be to update default openexr version from 2 to 3 . But that's much bigger task.

Indeed. Should v2 be marked as insecure? (can we affort that?) It's a bit above my paygrade but some of these CVEs seems quite serious. Someone more knowledgeable in security should check though :-)

Make a sense to mark v2 as insecure.

I think, even more correct solution would be to update default openexr version from 2 to 3 . But that's much bigger task.

Indeed. Should v2 be marked as insecure? (can we affort that?) It's a bit above my paygrade but some of these CVEs seems quite serious. Someone more knowledgeable in security should check though :-)

Before removal it would probably make sense to move all the packages currently using openexr 2 to openexr_3, then mark openexr 2 with knownVulnerabilities. This should allow us to backport the changes to stable without breakages (hopefully...). Then if we have no more dependents we can remove openexr_2 completely.
Note that moving some of the packages to openexr_3 will need to go through staging (e.g. gst_all_1.gst-plugins-bad)

Note that moving some of the packages to openexr_3 will need to go through staging (e.g. gst_all_1.gst-plugins-bad)

And actually I guess this PR should go to staging too.

I  changed the base to staging, and I'm going to do that as well for https://github.com/NixOS/nixpkgs/pull/367406

Note that moving some of the packages to openexr_3 will need to go through staging (e.g. gst_all_1.gst-plugins-bad)

And actually I guess this PR should go to staging too.

I don't think so.
Number of affected packages in this PR is following:
Package: added 0, removed 0, changed 97, Rebuild: linux 97, darwin 6

Note that moving some of the packages to openexr_3 will need to go through staging (e.g. gst_all_1.gst-plugins-bad)

And actually I guess this PR should go to staging too.

I don't think so.
Number of affected packages in this PR is following:
Package: added 0, removed 0, changed 97, Rebuild: linux 97, darwin 6

The labels are off then? When I tried nixpkgs-review, I had a higher amounts of rebuids... I'll test again a bit later

We don't need to go via staging branch for gdal PRs. My nixpkgs-review built 162 packages. Limit for staging is > 500.

Ok, fair enough, I rebased and switched the base branch back to master.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 366939

x86_64-linux

:fast_forward: 13 packages marked as broken and skipped:

python312Packages.python-mapnik
python312Packages.python-mapnik.dist
python312Packages.rio-tiler
python312Packages.rio-tiler.dist
python312Packages.shimmy
python312Packages.shimmy.dist
python312Packages.worldengine
python312Packages.worldengine.dist
python313Packages.python-mapnik
python313Packages.python-mapnik.dist
python313Packages.worldengine
python313Packages.worldengine.dist
t-rex

:x: 16 packages failed to build:

cloudcompare
otb
postgresql14Packages.postgis
postgresql14Packages.postgis.doc
python312Packages.django-bootstrap4
python312Packages.django-bootstrap4.dist
python312Packages.django-bootstrap5
python312Packages.django-bootstrap5.dist
python312Packages.drf-extra-fields
python312Packages.drf-extra-fields.dist
python312Packages.netbox-documents
python312Packages.netbox-documents.dist
python313Packages.drf-extra-fields
python313Packages.drf-extra-fields.dist
python313Packages.netbox-documents
python313Packages.netbox-documents.dist

:white_check_mark: 105 packages built:

apacheHttpdPackages.mod_tile
entwine
gdal (python312Packages.gdal)
gdalMinimal
gmt
gplates
grass
mapcache
mapnik
mapproxy
mapproxy.dist
mapserver
merkaartor
mysql-workbench
octavePackages.mapping
openorienteering-mapper
paraview
pdal
perl538Packages.Tirex
perl538Packages.Tirex.devdoc
perl540Packages.Tirex
perl540Packages.Tirex.devdoc
postgresql13JitPackages.postgis
postgresql13JitPackages.postgis.doc
postgresql13Packages.postgis
postgresql13Packages.postgis.doc
postgresql14JitPackages.postgis
postgresql14JitPackages.postgis.doc
postgresql15JitPackages.postgis
postgresql15JitPackages.postgis.doc
postgresql15Packages.postgis
postgresql15Packages.postgis.doc
postgresql16JitPackages.postgis
postgresql16JitPackages.postgis.doc
postgresql16Packages.postgis
postgresql16Packages.postgis.doc
postgresql17JitPackages.postgis
postgresql17JitPackages.postgis.doc
postgresql17Packages.postgis
postgresql17Packages.postgis.doc
python312Packages.bsuite
python312Packages.bsuite.dist
python312Packages.cartopy
python312Packages.cartopy.dist
python312Packages.fiona
python312Packages.fiona.dist
python312Packages.folium
python312Packages.folium.dist
python312Packages.geoarrow-pandas
python312Packages.geoarrow-pandas.dist
python312Packages.geoarrow-pyarrow
python312Packages.geoarrow-pyarrow.dist
python312Packages.geodatasets
python312Packages.geodatasets.dist
python312Packages.geopandas
python312Packages.geopandas.dist
python312Packages.geoparquet
python312Packages.geoparquet.dist
python312Packages.inequality
python312Packages.inequality.dist
python312Packages.libpysal
python312Packages.libpysal.dist
python312Packages.mapclassify
python312Packages.mapclassify.dist
python312Packages.momepy
python312Packages.momepy.dist
python312Packages.morecantile
python312Packages.morecantile.dist
python312Packages.msticpy
python312Packages.msticpy.dist
python312Packages.osmnx
python312Packages.osmnx.dist
python312Packages.plotnine
python312Packages.plotnine.dist
python312Packages.pygmt
python312Packages.pygmt.dist
python312Packages.pyogrio
python312Packages.pyogrio.dist
python312Packages.rasterio
python312Packages.rasterio.dist
python312Packages.rioxarray
python312Packages.rioxarray.dist
python312Packages.wktutils
python312Packages.wktutils.dist
python313Packages.django-bootstrap4
python313Packages.django-bootstrap4.dist
python313Packages.django-bootstrap5
python313Packages.django-bootstrap5.dist
python313Packages.gdal
python313Packages.pygmt
python313Packages.pygmt.dist
python313Packages.pyogrio
python313Packages.pyogrio.dist
pytrainer
pytrainer.dist
qgis
qgis-ltr
qmapshack
saga
sumo
survex
therion
tunnelx
udig
vpv


Is it possible to send a message to a specific Skype Account using nodejs?

Is it possible to send a message to a specific Skype Account using nodejs?
Example: I'm trying to send a message to a specific Skype account (Person 2) if my bot does not have the answer. Then, catch again the answer to resend to the first user (Person 1).
I'm using NodeJs v8.12, and BotBuilder v4
Thanks

Hi Alexandre! This is a how-to question, and the Bot Framework teams prefers that How-To questions are asked over on Stack Overflow. Additionally, I noticed that you've asked an identical question there, so I'm going to close this.


Suggested edits to data

Hello there! I used Mavo to suggest the following edits:
Added Learn Teach Code!
Preview my changes here: http://localhost:4000/organizations/?organization-storage=https%3A%2F%2Fgithub.com%2FLearningNerd%2Fsite%2F_data%2Forganization.csv

This was just a test by Liz and myself.


Context#fail should include document title/URL in error message

(Removed from milestone: needs more design of document/traits interaction, not sure how to do it right, don't want to do quick-and-dirty)


museum: init at 0-unstable-2024-03-02

Description of changes
https://github.com/NixOS/nixpkgs/issues/292641
for now untested. will need to package client and write a module.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Draft until ready, then.

Looks like the mobile apps now have support for custom servers.

I've took back what you've did with a more recent version and tried it. For me it fails completely because it's searching for a configurations/local.yaml. I tried to dig up a bit and found out that it's searching for this file here<EMAIL_ADDRESS>I'm not an expert in development but for me it does not look that good to have it like that. I'm not sure it can work within Nix right ? I tried to do a symlink from the share/configurations to bin/configurations to have it alongside the binary but even there it has to be run from the same folder. I'm not sure you can fix it with Nix but maybe I'm wrong.

looks like it uses the directory in which you were before executing the binary file, it should just work inside a systemd service, I really need to get back to this soon

I finally got back into it and made a quick module to test the service.
I can make it work but in order to do so you have to put in systemd service the working directory to ${src}/bin which I don't know if it's good practice or not tbh.

superseded by #325659


Add cardinality_limit to scrape config

Proposal
In order to stop targets from overloading label values and also the metric __name__ index, add a scrape config limiter that limits the number of unique label values per scrape.
This will protect, for example:

When other metric systems are translated to Prometheus incorrectly and tag values become part of the metric name.
When a piece of data is not filtered and exposed as thousands of label values.

Should we enable that setting for any label name?

That's not a bad idea. Would we want one setting for metric names and one for label values?
label_cardinality_limit

The metric name is a label value.

Hello from the bug scrub!
We assume that maintaining such a limit will inflict additional cost during the scrape (but we might be wrong ;).
Also, given that nobody started to work on this in the last two years, maybe it isn't that much needed. (We already have a lot of other limits you can set.)
We'll close this now, but if anyone has concrete plans to work on this, please follow up and we'll re-open.

Is this actually solved? I don't think it is.

It is not solved, but the bug scrub decided to not leave issues open that are unlikely to ever being worked on unless it's a feature we deem so crucial that we accept the issue to stay open for years.
Do you think this issue is crucial enough to reach that bar?

I think this would be a very important improvement to the cardinality explosion limit options we have. We have limits for the number of label names as well as various length limits. But no actual limits for metadata like label or metric name cardinality.
I don't have concrete plans to work on this, but I can see if I can get it on my team's roadmap.

I've updated the proposal to be for a carinality_limit setting.

The cardinality of the whole scrape is just the number of samples in the scrape, and we can limit that via sample_limit. I understand this issue as a limit of the cardinality per label name. I assume that will be non-trivial to track during the scrape, while at the same time I don't think how that's better to protect against cardinality explosions than sample_limit.

A good example of this is where someone trivially exposes StatsD metrics as Prometheus without converting part of the tree to labels.
We might want, say 1000-5000 samples from a scrape, but only 100-200 unique metric names.
Just having sample_limit is not good enough to cover 1000s of unique metric names coming from a scrape.

So what's worse for Prometheus resource-wise:

1000 uniquely named metrics in a scrape, no labels involved.
Only one metric name in the scrape, but with 3 labels of cardinality 10 each.

Both result in 1000 time series. I should probably think this through more carefully, but my intuition would have been that case (2) is actually worse. The proposed cardinality limit would allow to weed out (1) while allowing (2), though.

This is not a direct Prometheus resource issue that shows up in the TDSB. It is a downstream effect on Prometheus user interfaces.
The Prometheus UI and Grafana pull metadata json like /api/v1/label/__name__/values for use with name auto-completion. I have examples where systems have generated tens of thousands of metric names. Especially bad because the label values are now in the metric name. This results in megabytes of metadata json. These explosions tank Grafana UI performance.

This is basically related to https://github.com/prometheus/prometheus/issues/12795, which puts limits on the output of the metadata endpoints. With a scrape limit, we could avoid ingesting the bad data in the first place.

:shrug: I would still prefer limiting the metadata endpoints and let Prometheus ingest what it can ingest without TSDB and query problems.
But sure, if you feel that's an important feature, we'll leave this open (but I wouldn't be surprised if this turns out to be "not as easy as it looks" for performance reasons).


Bug in upcoming version: Nested documentation sidebar items are hidden

To retain the current (release) behaviour, hyde.subdirectories must be set to dropdown or flat when using grouped documentation sidebars. This setting should be automatic for documentation pages to preserve BC and intended behaviour.

Related bug: _docs/index.md is no longer hidden either.


Fix compile on redox

Redox still sets cfg(unix), this is a cfg that will fix compile issues on Redox
(yes, this does mean I am switching the allocator)

Oh, yeah. Almost forgot that.


Remove early return from gizmo intersect_ray

Remove early return from EditorNode3DGizmo::intersect_ray that is preventing to have gizmos that use Mesh collision + Segment collision.

Actually, thinking about it, we might as well remove the return in the selectable icon check some lines above: https://github.com/godotengine/godot/blob/659178e85fed5a7ee80d76329a977ac3943c7d77/editor/node_3d_editor_gizmos.cpp#L604
Otherwise we will have the same problem with gizmos that have both an icon and selectable segments or meshes.

Yee, I agree, I can remove that as well.

Done

Thanks!

Cherry-picked for 3.4.


Add "navbar-static-bottom" style

It would be great to have static bottom nav similar to navbar-static-top, which scrolls sideways.
Currently there is navbar-fixed-bottom only.
The reason why we need this is because when content doesn't fit height, navbar-fixed-bottom overlaps it, see screenshot:
http://i1304.photobucket.com/albums/s528/Vladimir_Shyshov/ScreenShot2012-10-16at52014PM_zpsa0766e23.png
Should be:
http://i1304.photobucket.com/albums/s528/Vladimir_Shyshov/ScreenShot2012-10-16at52104PM_zpsc464e1d3.png

.navbar-static-bottom {
  @extend .navbar-fixed-bottom;
  position: relative;
  border-width: 1px 1px 0;
}

This helped me


unicode module doesn't work with with daemon mode

What did you expect to happen?
unicode fonts should be setup appropriately both in normal startup and when launching emacs as a daemon e.g. with emacsclient -a="" test.org
What actually happened?
unicode-fonts-setup does not get run
Steps to reproduce:

Use emacs 26.3
enable unicode in private init.el
launch emacs using emacsclient -a="" test.org
type or paste text from non-latin unicode
Note the font using describe-char
Now launch emacs normally, not as a daemon
type or paste text from non-latin unicode
Note the font using describe-char. It is a good font setup by unicode-fonts-setup

System information:

emacs   version    26.3
        features   XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS MODULES THREADS LCMS2
        build      Dec 25, 2019
        buildopts  (--without-compress-install --without-dbus --with-modules 'CFLAGS=-O2 -g3')
        windowsys  w32
        daemonp    daemon
doom    version    2.0.9
        build      HEAD -> develop, origin/develop, origin/HEAD
        dir        ~/.config/doom/
system  type       windows-nt
        config     x86_64-w64-mingw32
        shell      C:/bin/emax64-26.3/libexec/emacs/26.3/x86_64-w64-mingw32/cmdproxy.exe
        uname      n/a
        path       (c:/bin/ C:/Program Files (x86)/Common Files/Oracle/Java/javapath C:/Windows/system32 C:/Windows C:/Windows/System32/Wbem C:/Windows/System32/WindowsPowerShell/v1.0/ C:/Windows/System32/OpenSSH/ C:/ProgramData/chocolatey/bin C:/Program Files/Calibre2/ C:/Program Files (x86)/gnupg/bin C:/Program Files/TortoiseGit/bin C:/Program Files (x86)/ZeroTier/One/ C:/Program Files (x86)/NVIDIA Corporation/PhysX/Common C:/Program Files (x86)/Intel/Intel(R) Management Engine Components/DAL C:/Program Files/Intel/Intel(R) Management Engine Components/DAL C:/Program Files/ImageMagick-7.0.10-Q16 C:/texlive/2020/bin/win32 C:/Program Files (x86)/Wolfram Research/WolframScript/ ~/AppData/Local/Microsoft/WindowsApps C:/tools/Cmder C:/Program Files/Oracle/VirtualBox ~/AppData/Local/Pandoc/ . c:/bin/emax64-26.3/libexec/emacs/26.3/x86_64-w64-mingw32)
config  envfile    nil
        elc-files  0
        modules    (:completion company ivy :ui doom doom-dashboard hl-todo modeline ophints (popup +defaults) pretty-code unicode vi-tilde-fringe window-select workspaces :editor file-templates fold snippets :emacs dired electric (undo +tree) vc :term eshell shell term vterm :checkers syntax :tools debugger (eval +overlay) lookup magit :lang emacs-lisp latex markdown org sh web :app calendar :config literate (default +bindings +smartparens))
        packages   ((solarized-theme) (selected) (doom-snippets :ignore t))
        unpin      (n/a)
        elpa       (n/a)

To make it work include the following snippet into config.el
 (defun unicode-fonts-setup-h (frame)
    "Run unicode-fonts-setup, then remove the hook."
    (progn
      (select-frame frame)
      (unicode-fonts-setup)
      (message "Removing unicode-fonts-setup to after-make-frame-functions hook")
      (remove-hook 'after-make-frame-functions 'unicode-fonts-setup-h)
      ))

  (add-hook 'after-make-frame-functions 'unicode-fonts-setup-h nil)

See discussion in the upstream bug (reported many years ago and not fixed)

I can try to hack around dooms init code and submit a reasonable workaround. They don't seem to want to fix it upstream

The problem was simple testing the variable initial-window-system is deprecated. One should call (display-graphic-p)


Are you manually rebuilding it or are you generating the code from the mruby project?

Just curious about your strategy because I have gotten close to rewriting a lot of Ruby in Go but then realized I should have generated the code from the original C project.
Recently I have considered using purego package to include libruby
Do you still have to essentially implement each major data type?

I'm not sure about what you need to use Ruby.
This project is still experimental to re-implement mruby in pure Go.
The reason is:

To bind a C library in Go is not easy to build an executable
Convert between Go and Ruby types has an extra cost

However, you need to consider that the mruby is not 100% the same as CRuby, the mruby is lightweight and can be easily embedded into other applications. You can image mruby is more like Lua.
This project has a lot of different designs with mruby. For example, I use Go's type to replace mrb_value that mruby and Go shared the same data type. This is inspired by Shopify/go-lua.

I got it working by embedding downloading the latest and embedding it then running it when needed as a memfd. You can have the output as a hash that already exists projects that let you convert that hash to Go structs.
But I totally agree this method is not great. I was looking at the new project purego which helps you remove cgo from your codebase, which there are several reasons why that is ideal and Ill assume you know them.
I do get mruby is smaller and honestly is a better goal. I already started using ruby to configure vagrant like VMs. I like using it as a configuration language, but mruby is even better.
I will look at the go-lua, I have been interested in specifically those projects because I do think they serve as a guide to do the addition. And obviously mruby would be a better configuration language.
I would like to find ways to help if possible, I have a lexer and parser for ruby already built. I even have a basic VM but the classes are not complete.

The parser isn't the priority feature for this project. I plan to use mrbc until the mruby virtual machine gets completed support written in go.
Giving some PR to this project is welcome. However, this project still needs many re-designed from mruby. (e.g. use Go's GC, and type, how the extension works, etc.) It will cause many times rewrites to adjust the design can fit Go's language feature.
By the way, Ruby 3 adds prism to generate the parser which is my best option to make this project compile Ruby code.

I appreciate the information, it is helpful on how I can make contributions
and get a better idea of what you expect from the project which is critical
to being able to contribute. I love the goal and I think you clearly have a
vision for how it should work.
I actually have not actually looked into Ruby 3 so I will look into prism,
and the other features added. I have been too deep into Go to play with
Ruby recently.
If you have the time, can you explain in more detail what rewrites you have
in mind? I think with collaboration we could get this live faster. I have
been reviewing the lua examples to try to get a good idea on structure.
On Mon, Jan 29, 2024 at 12:01 AM 蒼時弦や @.***> wrote:

The parser isn't the priority feature for this project. I plan to use mrbc
until the mruby virtual machine gets completed support written in go.
Giving some PR to this project is welcome. However, this project still
needs many re-designed from mruby. (e.g. use Go's GC, and type, how the
extension works, etc.) It will cause many times rewrites to adjust the
design can fit Go's language feature.
By the way, Ruby 3 adds prism https://github.com/ruby/prism to generate
the parser which is my best option to make this project compile Ruby code.
—
Reply to this email directly, view it on GitHub
https://github.com/elct9620/mruby-go/issues/1#issuecomment-1914154117,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AZRD5OEJK455QWYNFDHEVYLYQ5JOLAVCNFSM6AAAAABCJPZSNGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJUGE2TIMJRG4
.
You are receiving this because you authored the thread.Message ID:
@.***>

Currently, my works depend on features/ which I use to verify that Ruby code can work as expected (may not fully correct) I think you can start from it or add something and try to make it work.
I didn't have any plans for now because it is still my toy project. My work will try to rewrite mruby's C code to Go if possible. And use more cleaner way if Go provides related language features.


Please consider tagging releases

Hi, I know Zycore is mainly used as an internal library of some Zyantific projects (like Zydis), so working with releases for this library is not really that useful to you, but while maintaining the Zydis Debian package (that is now in Debian Unstable :D) I noticed that Zydis requires some features not present in Zycore 1.0.0, so I have to manually backport every change you make to Zycore that is also used in Zydis.
This is quite laborious and error prone, since with these backports I just aim at making the compiler happy - some behavioral changes and security fixes will certainly be missed, and Debian could end up having a Zydis library that depends on a buggy/unsafe Zycore, resulting in a buggy/unsafe Zydis.
Debian packages should be built from stable releases, so I can't just package the latest master (well, I could, but it is highly discouraged, and creates some issues like the impossibility of applying security fixes to packages in Debian stable, as they can't receive feature updates).
While certainly handy, I'm not asking for API or ABI stability, just some way to make sure that Zydis can be safely built from a tagged release - downstream and upstream should always collaborate :)

Hi there, sorry for not tagging the releases. We planned to do it, but forgot about it. We will check which version of Zycore is used in the Zydis releases and add tags for these commits.

but forgot about it

Don't worry, happens to me all the time :)
Thanks!

Added it to the version bump checklist. Hope we won't forget it next time then!

I noticed that in https://github.com/zyantific/zycore-c/commit/636bb29945c94ffe4cedb5b6cc797e42c98de3af you bumped the version field in CMakeLists.txt to 1.1.0. I believe that you could tag that commit as the 1.1.0 release, right?

You are correct. I just pushed the tag for this specific commit :-)

Thanks!
I'm closing this as you tagged the latest release and updated the checklist, but of course feel free to reopen it if you still need to handle something related to this issue.
Thanks again for the collaboration :)


Purchase Types Stipends [REQUEST]

Is your feature request related to a problem? Please describe.
It is very nice to be able to define custom purchase types in the Jump Options aside from just Perks and Items. It is even nicer to be able to create custom currencies and give them a starting budget. It brightens my life to be able to define a CP stipend specifically for the Items section.
It would be perfect to be able to define a stipend of any currency type for any custom purchase types, not just items. As far as I can tell, that's not something that can be done at present.
Describe the solution you'd like
I create the purchase type 'powers'. There is a tab on the side where i can select any existing purchase type, any available currency, and assign it a stipend that will be added only in that specific tab, like for the item stipend. Bonus points if we can define multiple stipends for multiple currencies, for a single purchase type.
In fact,

The middle tab does not appear to be used for anything other than showing the names of existing currencies, which is already the case in the left tab.
I think it could be repurposed to show a 'Stipend' tab every time we click on a purchase type in the rightmost tab, showing the name of the selected purchase type, and allowing us to select:

the currency
the stipend amount

Actually, the information could also be shown on the rightmost tab, like:

Name

Perks
CP
0

Items
CP
300

instead of just

Name

Perks

Items

I have implemented this feature and it will be present in the v1.3.3 release. However, I have not implemented the ability to have stipends for multiple currencies in a single purchase type. First, I have never actually seen a purchase type that actually uses more than a single currency. Second, doing this would require a complete redesign of how budgeting, currencies, and purchase types are handled internally. The rest of your request is fine though, and you'll be able to try it out in the next release.


Status icons blink when the Simple Calendar is running.

Very good module, I really like it.  The only problem I have is when i have Simple Calendar running, both icons and effect descriptions blink. They blink after hovering over them, as if they were refreshing on a regular basis.  It is related to refreshing Simple Calendar - set every 1 second causes blinking and refreshing of effect icons.
When the game is paused or during a fight - everything is fine.
Is there any way to solve this problem?

Likely the css not playing nice with getting refreshed every single second.

All in all it will be easier to set the refresh to 60 seconds, then it's
fine.  All in all Calendar refresh is not needed every 1 second.  Thank you
for your answer.
pt., 17 mar 2023, 15:20 użytkownik Zhell @.***> napisał:

Is there any way to solve this problem?

But I'll leave this up in case someone else is feeling adventurous.
—
Reply to this email directly, view it on GitHub
https://github.com/krbz999/visual-active-effects/issues/35#issuecomment-1473918458,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A6Q7RKTJ6AMRNTYO3WHQIGDW4RXL5ANCNFSM6AAAAAAV5HFB4M
.
You are receiving this because you authored the thread.Message ID:
@.***>

In the v11 release, the application will not refresh visually while hovered over. Ending the hover state will immediately refresh it (if there have been "pending" rendering calls).

Implemented feature:
While the panel is being hovered over, certain hooks will not refresh (re-render) the application. Some still will, such as updates to active effects and token selection, but updates to time will not. The application will remember if such a hook tried to render it, and will refresh once the user leaves the application (mouseout).

Hi @krbz999,
I believe I'm having this issue even with the latest updates. Here is a video of the VAE effect blinking each second. It's not urgent but kind of annoying out of combat as you can't read a VAE without pausing the game/calendar or opening the sheet.
Simple Calendar Example.webm
I'm using:
VAE - 10.0.18
Simple Calendar - 2.3.13
Foundry - 10.291
DnD5e - 2.2.1
Any help would be greatly appreciated and please let me know if you need any further info.

You are on the latest update compatible with Foundry Version 10. This issue was closed as part of VAE v11.0.0.


FQDN related identity disappeared

The testing cluster got into a state where an IP cache entry pointed to an identity that no longer existed. Based on the IP in the ipcache entry, it is reasonable to assume that the ipcache entry was created as a result of an FQDN policy rule. Several FQDN rules are loaded.

The kvstore did not know about the identity referred to in the ipcache entry
Removing the ipcache manually from kvstore resulted for it to be re-created instantly which indicates that at least one agent was still holding a reference count to the ipcache entry.
Restarting all agents resolved the situation. The ipcache entries first disappeared and where then re-created together with a new identity. Likely when the DNS poller queried the name again.

I think https://github.com/cilium/cilium/pull/6250 fixed this, so I'll close this optimistically.


Research/analysis on disease-specific financing

What does the data say? Are there enough countries with data? From when?

Originally posted by @jm-rivera in https://github.com/ONEcampaign/topic_health_financing/issues/5#issuecomment-1433335005
Is this a place to look at the covid data?

Closing based on #44


Fixed Read-Channel Native bug (word_counter/read_addr)

Fix to the cache-memory's data-memory write-enable signal. As it was using the registed it could write in a different address (RAW)


Q: support for auto-coloring Rust code?

Does this crate support markdown syntax for adding colors to Rust code like below (i.e. color consistently and automatically informing you whether it's a struct, or function, or enum, or keyword, etc)?
struct Struct {
    field1: String,
}

I have no clue what you are asking. Please use more words and examples.

That's not what markdown does. That's what GH and similar things do. It's called "syntax highlighting". Markdown turns that word, "rust", into a class. That's what we do here too. You can then use that class, with JavaScript for example, to do syntax highlighting yourself.


Add a templates dir runtime parameter

Today, if you clone, build and then run ruller-dsl-feature-flag the following error will happen:

This happens because it tries to look for templates at the /app/templates folder, which most definitely does not exists by default on devs machines.
I think this is hardcoded because the main way to run ruller-dsl-feature-flag is with it's Docker image. But that may not always be the case, specially in development time.

Great!