VM initialization failed

monarch --version
Dart SDK version: 2.19.4 (stable) (Tue Mar 7 09:58:46 2023 +0000) on "linux_x64"
moarch init
VM initialization failed: Invalid vm isolate snapshot seen
monarch run -v
VM initialization failed: Invalid vm isolate snapshot seen

what I do wrong?

Hi, please confirm you downloaded the latest monarch linux binaries from:
curl -O https://d148mrbia1nlbw.cloudfront.net/linux/monarch_linux_2.1.10.tar.xz

Then run monarch --version, its output should be something like:
$ monarch --version
Monarch version 2.1.10

Monarch modules:
- cli: 3.0.3
- controller: 1.3.1
- platform_app: 2.1.1
- preview_api: 2.3.0

Revision:
fb0f51b2d2cd719485f054d39b7a68349f2baf95

Then please make sure you are running monarch init inside a flutter project.
If you are getting the same error, please run flutter doctor -v and post the output here.


feat(core): TypeScript 3.7

This PR adds TypeScript 3.7.
Please take a look and see if I forgot anything, or if we can simplify anything! 🙏

Other than the fact that CI is still failing - the changes here are good.

@Andarist I'm going to merge this in and try to figure out the test failures in another commit.


Slow render issue when maximizing/restoring window

VSCode Version: Code 1.8.0 (38746938a4ab94f2f57d9e1309c51fd6fb37553d, 2016-12-13T17:45:32.595Z)
OS Version: Windows_NT ia32 10.0.14965

See below - notice the right and bottom parts of the window take a while (several seconds) to refresh. I was debugging in this case, but the issue occurs regardless of what mode you're in

Here is the same scenario on a windows 10 parallel's VM on macOS. Interestingly much faster. Potential differences: touch screen, low on memory, other CPU hogging activities.

Please comment on Kais performance questions, likely related. Also you can run a chrome profile session to capture where time is spend:
To create a CPU profile using developer tools in VS Code:

select Help > Toggle Developer Tools
click on Profiles
click the start button
do whatever you need to do to get the CPU spin high
wait for some time (10-20 seconds should be enough)
stop the profiling
click the save button and attach the output file to this issue

A number of days has past without answer on the questions asked. I am thereby going to close this issue to clean up our backlog of issues. Once you can answer on the questions, the issue can be reopened again. Thanks for understanding this process!


Embedly support doesn't account for protocol relative urls

I just added SSL support to Crater and it seems the embedly images are not being saved as protocol relative urls.
We should save a thumbnailUrl like this:
thumbnailUrl: "//i.embed.ly/1/image/crop?url=http%3A%2F%2Fjoshowens.me%2Fcontent%2Fimages%2F2015%2FFeb%2Fsecurity-settings-header.jpg&key=386ad471df374e12ae61b1af9a2acaa1&width=200&height=125",
  title: "Environment Settings and Security with Meteor.js"

but instead right now we are getting this:
thumbnailUrl: "http://i.embed.ly/1/image/crop?url=http%3A%2F%2Fjoshowens.me%2Fcontent%2Fimages%2F2015%2FFeb%2Fsecurity-settings-header.jpg&key=386ad471df374e12ae61b1af9a2acaa1&width=200&height=125",
  title: "Environment Settings and Security with Meteor.js"

If it's just a matter of removing the http: it shouldn't be too hard. Embedly also has a secure argument (see http://embed.ly/docs/api/extract/arguments) but it's only available for paid plans apparently. We might not need it though?

Based on my limited testing, just removed the http: should make it a relative url and it seems to work on the images I've tested.

Fixed in https://github.com/TelescopeJS/Telescope/commit/3e97b453dec0a04efbd4898afa10f098d74f9f9e


bundler is missing from the dependencies

Reported by @spidey in https://github.com/danger/danger-gitlab-gem/issues/10

On a new container I'm using gem install danger-gitlab but danger is complaning about bundler missing when actually running. Running gem install danger-gitlab bundler instead solves it.

danger doesn't have bundler as dependency but references Bundler here.
https://github.com/danger/danger/blob/873627ecce0c8f78ffd95912b3c4d50c91ad591c/lib/danger/plugin_support/gems_resolver.rb#L14
Most CI services have bundler pre-installed in their virtual machine so I guess many people don't notice this issue so far.

Oops, I just noticed that bundler is bundled gem since Ruby 2.6.0.
Danger supports Ruby >= 2.7.0 so I think this issue cannot be reproduced now.
https://www.ruby-lang.org/en/news/2018/12/25/ruby-2-6-0-released/

Bundler is now installed as a default gem.


Index updates are extremely slow

I'm in a situation where a test runs faster on Mongo than on Fongo. This test uses a tiny data set (~100 documents), each containing a few fields, included a few indexed arrays (with ~50 entries in each).
As shown in the VisualVM profile below, Fongo's IndexAbstract.remove is very slow because it spends a lot of time in ArrayList.remove, which relies on the equals implementation of its members. Unfortunately, BasicBSONObject.equals is slow as heck so the performance really goes down the drain.

I'm unsure if the solution is to store something else than BSONObjects in the List or to use another data structure instead of the List? Note that BasicBSONObject.hashcode is almost as challenged as its equals method as it too serializes the object to byte[] on each call :rage:

Hi,
I start a tests, but didn't find the same result as you.
Perhaps my data are wrong.
How many index do you have ?

I have 11 indexes. I'm doing bulk updates ($set) of a few fields that are indexed, including some of the array (with $addToSet).

So, you use the "old" api (with DBs) ?

Yes, that is correct.

@ddossot , could you check https://github.com/fakemongo/fongo/pull/160 in your environment? It should help you.

Hi, @ddossot, can you check #160 if it helps ?
Thanks

Unfortunately not because my codebase has evolved in a way that prevents me to test this particular issue independently of other issues (mainly #153 and #154).

and now O:-) ?

Nope, still almost twice slower on Fongo than Mongo :sweat:

And profile is same? oO Can you create a synthetic test for this case?

I'll see what I can do next week.


Flicking when dragging final Items

In the demo, there is a small glitch/flicking of the first item when you drag the last item.
Maybe the first items are being unnecessarily rendered?

I can't reproduce your problem, which browser and platform are you using?

I'm using Mac OS X and it happens both in Safari and Chrome.

I actually see it any time I try to drag anything but the first item left:

Chrome 47.0.2526.111 on OS X 10.10.

hm going frame-by-frame it looks like the flicker is the "placeholder" being added to the markup in the wrong place:

That's very helpful @evanc , I can reproduce it now.
Thanks guys, a fix will be made soon.

Please try version 1.3.2.
I've also added some tests for this situation.
https://github.com/jasonslyvia/react-anything-sortable/blob/eb8bd5e03f64bbd827b10647471bc84aa3fa2d37/test/specs/sortable-test.js#L158


How to put your school

When I copy the auth on line 124 of Chrome_SPARXBWK.py it says its trying to sign me in to Holsworthy Community College. How could I change this to my school so it works. Thanks

Working on a fix should be finished by today.

I have fixed this issue with the latest version and created a step by step guide.

Hello it works now thanks for helping :)


Changes in "Edit Reference" do not up date in the ref list

We edit Article Title, Authors, issue dates, pages, but these changes do not are available in ref list

Reference editing is not stable yet, but it's being worked on with the highest priority. See #235

Closing this. Will be covered via #235.


feat(shared-data): add heater shaker 2d render key

Overview
This PR adds the 2D render key for the heater shaker.

@mmencarelli @jerader The last conversation I had about SVG module styling/colors is captured in this figma frame: https://www.figma.com/file/JcVc9XgI0nCZfOHUsiC4CM/Modules-Overview?node-id=507%3A1751

I updated the colors so that it matches the other modules for now. We can definitely make changes in follow up PRs.

I updated the colors so that it matches the other modules for now. We can definitely make changes in follow up PRs.

works for me! Thanks for handling that @shlokamin


Hung when building 18.4.0

OS: macOS Catalina 10.15.3
CMD: ./buildDockerImage.sh -v 18.4.0 -x
I am trying to build the 18.4.0-XE version and am getting hung in two places:
...
Complete!
Loaded plugins: ovl <-- Hung here for 2 minutes
Examining ...

and
...
Successfully built 272b967feafc
Successfully tagged oracle/database:18.4.0-xe <-- Hung here indefinitely

For the last one I need to go into system management and end the yes process.  So this is likely due to this line:
https://github.com/oracle/docker-images/blob/f472904a92cec25c2cf508ed7d1f5d1d81a12487/OracleDatabase/SingleInstance/dockerfiles/buildDockerImage.sh#L225-L226

The first hang is not a hang, it's yum not displaying any output during the build process. It's furiously updating things in the background, just not logging anything.
The second hang is also likely not a hang, just taking a very long time to prune dangling images on your system. You can run that command manually first, i.e. docker image prune before you build so you can see the output.

Okay the first part makes sense.  If this is the step that downloads the database install binary then I would expect a 2 minute wait time.
However, I disagree with the second hand.  Even if I had multi-gigabit amount of images to clean up in the prune command, this command should not take > 10 minutes.  This only happens when doing an 18.4.0 build.

You're right, it shouldn't, but I can understand that it does. The step cleans up all the dangling layers and on a Mac, Docker uses a hidden VM which has fairly woeful filesytem performance. I would expect the time taken to create and remove those layers could be a while, especially given how large some of those layers for 18.4 can be.

docker image prune outside of this script takes my system sub-second time to complete.  I'll go ahead and leave this issue open just in case anyone else faces this issue.  Perhaps it is a docker on mac issue?

I'm going to close this issue because it's outside the scope of this repository.

I'd like to reopen this issue as I am facing the same problem.
I was looking in my ActivityMonitor what was eating my CPU during and saw that the process 'yes' was taking almost all my CPU for one of the cores. After killing this process building the Docker was almost instantly done.
The yes command is used in the prune step to approve pruning as can be seen by the original message.
Doing a quick google found me this on the yes command: https://lifehacker.com/stress-test-your-mac-with-the-yes-command-1564681908. It can apparently be used to 'stress test' your mac...
Hence, I think the yes command has a nasty side effect when run on a mac..

@gvenzl perhaps this line should be removed from the buildDockerImage.sh script? I can't see any value in it now. Users should maintain and manage their own layers (including dangling ones) and Docker provides plenty of commands to do that these days.

Yeah, that seems like a better solution.

Is this repo open to community PRs?  If so I would be more than willing to create a PR for this.

Is this repo open to community PRs? If so I would be more than willing to create a PR for this.

Absolutely. Please review the Contribution Guide (CONTRIBUTING.md) in the root which outlines the requirements for signing the Oracle Contributor Agreement prior to submitting a PR, but we'll gladly accept them.

Okay, looks like oracles contributor agreement takes quite a lot of liberties with intellectual property.  Unfortunately, I won't be able to make a contribution at this time.  😭

Okay, looks like oracles contributor agreement takes quite a lot of liberties with intellectual property. Unfortunately, I won't be able to make a contribution at this time. 😭

That's a shame. Note that the Oracle Contributor Agreement FAQ outlines why we need the contributor agreement and how it protects both Oracle and contributing developers. We use the same type of agreement used by other large organisations including the Apache Foundation and Free Software Foundation.

Hy folks,
I'd like to share the problem I'm facing:
---> Running in 6623a972913b
Loaded plugins: ovl
https://yum.oracle.com/repo/OracleLinux/OL7/latest/x86_64/repodata/repomd.xml: [Errno 12] Timeout on https://yum.oracle.com/repo/OracleLinux/OL7/latest/x86_64/repodata/repomd.xml: (28, 'Resolving timed out after 30534 milliseconds')
Trying other mirror.
https://yum.oracle.com/repo/OracleLinux/OL7/latest/x86_64/repodata/repomd.xml: [Errno 12] Timeout on https://yum.oracle.com/repo/OracleLinux/OL7/latest/x86_64/repodata/repomd.xml: (28, 'Resolving timed out after 30538 milliseconds')
Trying other mirror.
https://yum.oracle.com/repo/OracleLinux/OL7/latest/x86_64/repodata/repomd.xml: [Errno 12] Timeout on https://yum.oracle.com/repo/OracleLinux/OL7/latest/x86_64/repodata/repomd.xml: (28, 'Resolving timed out after 30534 milliseconds')
Trying other mirror.
https://yum.oracle.com/repo/OracleLinux/OL7/latest/x86_64/repodata/repomd.xml: [Errno 12] Timeout on https://yum.oracle.com/repo/OracleLinux/OL7/latest/x86_64/repodata/repomd.xml: (28, 'Resolving timed out after 30537 milliseconds')
Trying other mirror.
https://yum.oracle.com/repo/OracleLinux/OL7/latest/x86_64/repodata/repomd.xml: [Errno 12] Timeout on https://yum.oracle.com/repo/OracleLinux/OL7/latest/x86_64/repodata/repomd.xml: (28, 'Resolving timed out after 30536 milliseconds')
Trying other mirror.
...
Any idea? All the mirrors are returning timeout...

Please continue here: https://github.com/oracle/docker-images/issues/2241


Entity - Move default cast handlers to config

Description
The main reason for moving this to config is to be able to use Registars to extend the defaultCastHandles without having to modify every entity object.
Checklist:

[ ] Securely signed commits
[x] Component(s) with PHPDoc blocks, only if necessary or adds value
[ ] Unit testing, with >80% coverage
[ ] User guide updated
[x] Conforms to style guide

more configs for the god of configs
private -> protected && MyBaseEnity extends Entity

It seems @iRedds 's way is enough.
Is it something missing?

This may require changelog update and upgrade_420.rst
https://github.com/codeigniter4/CodeIgniter4/blob/develop/user_guide_src/source/changelogs/v4.2.0.rst
https://github.com/codeigniter4/CodeIgniter4/blob/develop/user_guide_src/source/installation/upgrade_420.rst
btw, @kenjis for mandatory file changes note for public/index.php and spark:
https://github.com/codeigniter4/CodeIgniter4/blob/develop/user_guide_src/source/installation/upgrade_420.rst#id7
it seems it needs to be in changelog as well.

@najdanovicivan specifically mentions Registrars. While using a BaseEntity would solve this for an app it does not allow things like libraries to offer their own cast extensions.
I know we've piled a lot into Config but it is our pivot point for extendability. I think one way to help this will be to move all files that are actually BaseConfigs into their own system namespace and then only have a few in App that extend them - this way any given app's config folder might only have 4-5 files instead of 25.

@najdanovicivan specifically mentions Registrars. While using a BaseEntity would solve this for an app it does not allow things like libraries to offer their own cast extensions.
I know we've piled a lot into Config but it is our pivot point for extendability. I think one way to help this will be to move all files that are actually BaseConfigs into their own system namespace and then only have a few in App that extend them - this way any given app's config folder might only have 4-5 files instead of 25.

I was speaking about same stuff a while ago. It will be best if we can have all the default configs under CodeIgniter/Config namespace so that Config namespace contains only overrides. It will make updates much more easier in the future since there won't be missing parameters when new configs are introduced.

@samsonasik I sent a PR #5837

I think one way to help this will be to move all files that are actually BaseConfigs into their own system namespace and then only have a few in App that extend them - this way any given app's config folder might only have 4-5 files instead of 25.

I agree that. I feel there are too many config files in app/Config/.

Is it a better experience for the developer to have 4 config files and then have to hunt down system config files, copy them to the app config folder and modify from there? To me it seems the cleanliness of the config folder like that would makes things more of a pain for the end user.
As framework developers we can either be very opinionated, and not need as much configuration options, or be very flexible and give the developer the opportunity to change the system to be what they need it to be. CodeIgniter has always been more of the latter type of framework. One reason we have more config files now is because we split the app config file into separate files to makes things more clear and easy to find.
I'm all for having original copies in the system folder. This allows us to add config settings and not break apps that miss adding new options to their existing config files.

I think we could do a better job of splitting out "basic" from "advanced" config. For example, I would expect someone making their own Exception or View extensions to know what they were doing enough already to migrate a Config from system to app, whereas just about everyone needs to open up Routes.php in every app.
It also isn't just about the files - if all of our App versions extend their parent classes then we can keep their content slimmer and leave out "advanced" options. For example Cache.php could be trimmed down to four properties instead of the current 11, many of which won't ever be touched.

What is the benefit for the developer of hiding configuration options? I personally don't see any - only the possibility of confusion. I know I personally would be irritated if I had to go snooping through system files to discover there was a configuration option. To me, having them in the app config file aids discoverability, causes less friction when it is needed, and doesn't cause any harm for people to ignore them. Kind of the php.ini :)
I suppose we do have a little precedent for this with Services, though that feels different to me.

I would think the benefit is less work when updating CodeIgniter, as the app folder has to be updated manually everytime. While there are tools to assist with that, it is still more work.

@lonnieezell regarding the configs we can still have all the files in Config namespace but instead of having
class App extends BaseConfig

we'll have
class App extends CodeIgniter\Config\App

That way there will be no need to hunt down for any files when it's needed to make changes to the configs. As override files will already be in place. It just gives us the ability for framework to work without config files as those will be loaded from system namespace. More importantly if there is new config class or parameter introduced it will be available in the system namespace so when framework is updated it will not crash due to missing configs.

@najdanovicivan I agree, and believe I said earlier I'm ok with that. I just wasn't sure hiding config options in /app was a good idea.

It seems to me that overuse of Config and Registrar is not a good idea.
The idea of Entity Config does not feel right.
I still do not understand the need for this PR.
It seems sufficient to create (extend) your own Entity class and use it.

@najdanovicivan If you wish to pursue this please address the questions above or start a forum thread to gauge community interest in this as a new feature. Closing as stale for now.


memcpy easier to access

Is it possible to make the memcpy functions easier to access in python? I can see they are part of the runtime but it would nice if they were accessible via wp.memcpy_h2d

Hi @jc211, can I ask the use case? Is wp.copy() on arrays not enough here?
I am a bit wary of exposing all these 'low level' operations on the main API. But I think accessing them through the context object is OK if you really need them.


Revert "build: update linting (#3112)"

Description

This pull request temporarily reverts #3112 (commit d7c387f33394eb94b0fb49256c69c3f417e149ab) on account of a broken build (example: https://jenkins-oss.wixpress.com/job/detox-ios-60-5-master/1451/console)

@noomorph sorry about this, we'll be sure to restore this tomorrow, first this.

For features/enhancements:

[ ] I have added/updated the relevant references in the documentation files.

For API changes:

[ ] I have made the necessary changes in the types index file.

Hopefully there is no need. Igor updated Node.js on CI
https://jenkins-oss.wixpress.com/job/multi-detox-master/2131/

No need. The build is passing already.

@noomorph the point was to protect your Sunday :-) But sure, looks like we're safe. Thanks.


2D->3D

https://github.com/kenshohara/3D-ResNets-PyTorch/blob/f399b376ca555f0ff925d77517313164c66504f9/models/densenet.py#L193
This gives an error on my side, stating that the 2D layer expects a 2D input. Should this be a 3D BatchNorm layer instead?

I am wondering the same thing. Did you figure this out ?

@patricio-astudillo In case you haven't solved it yet. I changed it to 2D to 3D because it throws out a dimension error as you mentioned. Then, the error is gone and worked well.


Not working with new vim 8 version

Plugin breaks vim completely. I have blank screen and error

Please make sure you are using the latest version both of nerdtree and nerdtree-git-plugin. If not, please upgrade them.
If the error still occurs, please tell me your system info and vimrc.

side note: make sure git status works properly - i had the issue that i had to confirm the license agreements of xcode again and therefore it didn't work anymore. 👯

I've updated both nerdtree and nerdtree-git-plugin and still experiencing this problem.
my .vimrc gist
$ git --version
git version 2.10.0
hub version 2.2.5

$ uname -a
Linux espresso-pc 4.7.4-1-ARCH #1 SMP PREEMPT Thu Sep 15 15:24:29 CEST 2016 x86_64 GNU/Linux

$ vim --version
VIM - Vi IMproved 8.0 (2016 Sep 12, compiled Sep 15 2016 10:09:09)
Included patches: 1-5
Compiled by Arch Linux
Huge version with GTK2 GUI.  Features included (+) or not (-):
+acl             +file_in_path    +mouse_sgr       +tag_old_static
+arabic          +find_in_path    -mouse_sysmouse  -tag_any_white
+autocmd         +float           +mouse_urxvt     +tcl/dyn
+balloon_eval    +folding         +mouse_xterm     +termguicolors
+browse          -footer          +multi_byte      +terminfo
++builtin_terms  +fork()          +multi_lang      +termresponse
+byte_offset     +gettext         -mzscheme        +textobjects
+channel         -hangul_input    +netbeans_intg   +timers
+cindent         +iconv           +num64           +title
+clientserver    +insert_expand   +packages        +toolbar
+clipboard       +job             +path_extra      +user_commands
+cmdline_compl   +jumplist        +perl/dyn        +vertsplit
+cmdline_hist    +keymap          +persistent_undo +virtualedit
+cmdline_info    +lambda          +postscript      +visual
+comments        +langmap         +printer         +visualextra
+conceal         +libcall         +profile         +viminfo
+cryptv          +linebreak       +python/dyn      +vreplace
+cscope          +lispindent      +python3/dyn     +wildignore
+cursorbind      +listcmds        +quickfix        +wildmenu
+cursorshape     +localmap        +reltime         +windows
+dialog_con_gui  +lua/dyn         +rightleft       +writebackup
+diff            +menu            +ruby/dyn        +X11
+digraphs        +mksession       +scrollbind      -xfontset
+dnd             +modify_fname    +signs           +xim
-ebcdic          +mouse           +smartindent     -xpm
+emacs_tags      +mouseshape      +startuptime     +xsmp_interact
+eval            +mouse_dec       +statusline      +xterm_clipboard
+ex_extra        +mouse_gpm       -sun_workshop    -xterm_save
+extra_search    -mouse_jsbterm   +syntax
+farsi           +mouse_netterm   +tag_binary
   system vimrc file: "/etc/vimrc"
     user vimrc file: "$HOME/.vimrc"
 2nd user vimrc file: "~/.vim/vimrc"
      user exrc file: "$HOME/.exrc"
  system gvimrc file: "/etc/gvimrc"
    user gvimrc file: "$HOME/.gvimrc"
2nd user gvimrc file: "~/.vim/gvimrc"
       defaults file: "$VIMRUNTIME/defaults.vim"
    system menu file: "$VIMRUNTIME/menu.vim"
  fall-back for $VIM: "/usr/share/vim"
Compilation: gcc -c -I. -Iproto -DHAVE_CONFIG_H -DFEAT_GUI_GTK  -pthread -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/libdrm -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16 -I/usr/include/pango-1.0 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/harfbuzz -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/harfbuzz -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -D_FORTIFY_SOURCE=2  -march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
Linking: gcc   -L. -Wl,-O1,--sort-common,--as-needed,-z,relro -fstack-protector -rdynamic -Wl,-export-dynamic -Wl,-E -Wl,-rpath,/usr/lib/perl5/core_perl/CORE  -Wl,-O1,--sort-common,--as-needed,-z,relro -L/usr/local/lib -Wl,--as-needed -o vim   -lgtk-x11-2.0 -lgdk-x11-2.0 -lpangocairo-1.0 -latk-1.0 -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lpangoft2-1.0 -lpango-1.0 -lgobject-2.0 -lglib-2.0 -lfontconfig -lfreetype -lSM -lICE -lXt -lX11 -lXdmcp -lSM -lICE  -lm -lncurses -lelf -lnsl    -lacl -lattr -lgpm -ldl   -Wl,-E -Wl,-rpath,/usr/lib/perl5/core_perl/CORE -Wl,-O1,--sort-common,--as-needed,-z,relro -fstack-protector-strong -L/usr/local/lib  -L/usr/lib/perl5/core_perl/CORE -lperl -lpthread -lnsl -ldl -lm -lcrypt -lutil -lc   -L/usr/lib -ltclstub8.6 -ldl -lz -lpthread -lieee -lm

Oh my bad, I had not read FAQ part more closely and now I see that bug was related to problem with fish and setting shell to fish after setting shell to sh. I fixed this issue by removing set shell=/bin/fish from my config. I wonder why it worked in the first place with vim 7


Doc.java:85-87: Method shortUrl should be executed...

Puzzle 212-00b195c0 in src/main/java/com/nerodesk/om/Doc.java:85-87 has to be resolved: Method shortUrl should be executed from a proper place on the UI in order to provide sharing short links functionality for users.... The puzzle was created by Alexey Saenko on 23-Apr-2015.
If you have any technical questions, don't ask me, submit new tickets instead

@pinaf this is your task

@yegor256 there is no milestone yet, so I set it to 0.4

@karato please see PR #262

@karato please see PR #262

@pinaf will take a look, thanks

@karato fixed!

@yegor256 Closing this issue now...

@pinaf Many thanks! 30 mins were added to your account in Transaction ID AP-7CL85627UC769562X (task took 142 hours and 11 mins)... +30 added to your rating, current score is: +7600


refactor: begin to de-globalize masternodeSync

Issue being fixed or feature implemented

minimizing global uses
What was done?

Started the deglobalization, a future PR should be done to continue this deglobalization
How Has This Been Tested?

Breaking Changes

none
Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added or updated relevant unit/integration/functional/e2e tests
[x] I have made corresponding changes to the documentation

For repository code-owners and collaborators only

[x] I have assigned this pull request to a milestone

linter complains:

A new circular dependency in the form of "masternode/sync -> validation -> masternode/sync" appears to have been introduced.

Yup. I see that 👍

applied

pls see https://github.com/UdjinM6/dash/commits/pr5103 for more suggestions

Seems all good changes to me. Applied


Duplicate read of associated records when using AssociationLoader

Hi everyone!
First, i would like to thank you for your awesome job on the OSS community!
I've probably a bug using graphql-batch.  I've duplicate reads of replacements associated records when i use the AssociationLoader class, only after a succeed mutation, not when i use a query. If i disable the batch it works well.
Any idea of what's going bad?
data: {,…}
createMandate: {...}
errors: []
mandate: {…}
[...]
replacements: [{id: "144", flexibleTime: false, endsAt: "2019-04-12T01:00:00Z", priority: false,…},…]
0: {id: "144", flexibleTime: false, endsAt: "2019-04-12T01:00:00Z", priority: false,…}
1: {id: "145", flexibleTime: false, endsAt: "2019-04-13T01:00:00Z", priority: false,…}
2: {id: "144", flexibleTime: false, endsAt: "2019-04-12T01:00:00Z", priority: false,…}
3: {id: "145", flexibleTime: false, endsAt: "2019-04-13T01:00:00Z", priority: false,…}
[...]
success: true

# app/models/mandate.rb
class Mandate < ApplicationRecord
  has_many :replacements, class_name: 'Replacement', autosave: true, dependent: :destroy
  has_many :proposals, through: :replacements, class_name: 'Proposal'

  accepts_nested_attributes_for :replacements, allow_destroy: true
end

# app/graphql/types/mandate.rb
class Types::Mandate < Types::BaseObject
  [..]
  field :replacements, [::Types::Replacement], "Mandate's replacements", null: false
  [..]

  def replacements
    AssociationLoader.for(Mandate, :replacements).load(object)
  end
end

# app/graphql/association_loader.rb
class AssociationLoader < GraphQL::Batch::Loader
  def self.validate(model, association_name)
    new(model, association_name)
    nil
  end

  def initialize(model, association_name)
    @model = model
    @association_name = association_name
    validate
  end

  def load(record)
    raise TypeError, "#{@model} loader can't load association for #{record.class}" unless record.is_a?(@model)
    return Promise.resolve(read_association(record)) if association_loaded?(record)
    super
  end

  # We want to load the associations on all records, even if they have the same id
  def cache_key(record)
    record.object_id
  end

  def perform(records)
    preload_association(records)
    records.each { |record| fulfill(record, read_association(record)) }
  end

  private

  def validate
    unless @model.reflect_on_association(@association_name)
      raise ArgumentError, "No association #{@association_name} on #{@model}"
    end
  end

  def preload_association(records)
    ::ActiveRecord::Associations::Preloader.new.preload(records, @association_name)
  end

  def read_association(record)
    record.public_send(@association_name)
  end

  def association_loaded?(record)
    record.association(@association_name).loaded?
  end
end

I've found that if i add a uniq in this method, it fix my problem:
# app/graphql/association_loader.rb
 def perform(records)
    preload_association(records)
    records.each { |record| fulfill(record, read_association(record).uniq) }
  end

Not sure if it's the best way to fix the issue

Just stumbled across the same problem.
It turned out that Preloader doesn't take into account uniqueness of records and adds duplicates to the resulting associations ('cause it loads associated records for each passed object).
Solved by adding uniq here:
def perform(records)
-  preload_association(records)
+  preload_association(records.uniq)

end

NOTE: we use an upgrade version of association_loader.rb compatible with Rails 6: https://gist.github.com/palkan/03eb5306a1a3e8addbe8df97a298a466

I've found that if i add a uniq in this method, it fix my problem:
# app/graphql/association_loader.rb
  def perform(records)
    preload_association(records)
    records.each do |record|
      read_association_record = read_association(record)

      if read_association_record.is_a? ActiveRecord::Associations::CollectionProxy
        read_association_record = read_association_record.distinct
      end

      fulfill(record, read_association_record)
    end
  end

Not sure if it's the best way to fix the issue

anyway, it helped me, thanks!

Could this be related to https://github.com/rails/rails/issues/36396. If so it was fixed in https://github.com/rails/rails/pull/36429

@bricesanchez ,
your method is particularly works when the associations have no order_values, if the associations have order_values and order by expressions not appear in select list, it will raise this database error:
ActiveRecord::StatementInvalid: PG::InvalidColumnReference: ERROR:  for SELECT DISTINCT, ORDER BY expressions must appear in select list
so I use the following method to avoid the problem:
def perform(records)
    preload_association(records)
    records.each do |record|
      read_association_record = read_association(record)

      if read_association_record.is_a? ActiveRecord::Associations::CollectionProxy && read_association_record.order_values.empty?
        read_association_record = read_association_record.distinct
      end

      fulfill(record, read_association_record)
    end
  end

wish the author to fix the problem in essence

@palkan
Suppose A has_many B, and B has_many C
If I have a query:
query {
  A{
    B{
      C{
        field
       }
     }
  }
}

records.uniq can uniq A and B records, but C records still probably duplicated read, so it can not solve the problelm totally.
Luckily the problem seems to solved by the authors.

The only way i found to really fix this issue was to update my rails app to 6.0+. Thanks for your help! 😃


Reagents permanently pollute bloodstream unless drawn with blood

Description
Oxygen and carbon dioxide do not tick down at 1u like most other reagents that do not have stomach/heart reactions. Its possible to fill someone with 250u and make it impossible for them to be injected or fed unless someone realizes they can draw chemicals with blood to make space in bloodstream.
Reproduction
Inject yourself with oxygen/carbon dioxide, check solution.
Screenshots

I think this issue is caused because the chemstream cannot metabolize gases for some reason...
My best guess is the lungs cannot metabolize solutions, and the only metabolizer for these "chemicals" are gas type organs

I think this issue is caused because the chemstream cannot metabolize gases for some reason...
My best guess is the lungs cannot metabolize solutions, and the only metabolizer for these "chemicals" are gas type organs
This would need to be either fixed in the code or gases need to have some sort of metabolism effect.

I think you're on the right track here. Using CO2 as an example, the only metabolism is for gas. The solution in my mind is to treat the non-metabolizing gases like plasma/trit are in the gases YAML.
  metabolisms:     Poison:       effects:       - !type:HealthChange         damage:           types:             Poison: 3       - !type:AdjustReagent         reagent: Inaprovaline         amount: -2.0     Gas:       effects:       - !type:HealthChange         scaleByQuantity: true         ignoreResistances: true         damage:           types:             Poison:               1
This will require adding poison metabolisms for all the gases that can now be found in liquid form thanks to the condenser:

Oxygen
Carbon Dioxide
Nitrous Oxide
Frezon

There is already precedence for this behavior with cold/inert gases under nitrogen:
  metabolisms:     Poison:       effects:       - !type:HealthChange         damage:           types:             Cold: 1 # liquid nitrogen is cold
If we want to do this "right" I think having these reagents reduce body temp is also appropriate, kinda like we do for Insuzine / Leporazine. If you think that's appropriate, I can make the changes & PR, but I'm still relatively new to the codebase & want to make sure I'm not thinking about it like an idiot.


[v1.1][ISSUE-188] Refine Distiller close file and UT

Due to code security scan, add close file to after read files in save logits function

Add save logits function check in UT

@XinyaoWa , I found github hosted runner seems has some issue today, I restarted the first action but it kept pending for github to assign runner. So you don't need to expect first two UT to complete.  Need to test UnitTest locally.

@XinyaoWa , I found github hosted runner seems has some issue today, I restarted the first action but it kept pending for github to assign runner. So you don't need to expect first two UT to complete. Need to test UnitTest locally.

I have tested the UT locally and they passed. So should I wait for fixing, or directly merge?


Modal component causes 'Error: Token must be defined!' for AoT runtime

I use shared module to define Modals and share it with different parts of the app
import { NgModule, ModuleWithProviders } from '@angular/core';
import { CommonModule } from '@angular/common';
import { FormsModule } from '@angular/forms';

import { ModalModule } from 'ng2-bootstrap';

@NgModule({
  imports: [
      CommonModule,
      ModalModule.forRoot()
  ],
  exports: [
      CommonModule,
      FormsModule,
      ModalModule
  ]
})
export class SharedModule {
  static forRoot(): ModuleWithProviders {
    return {
      ngModule: SharedModule
    };
  }
}

JIT compilation and runtime work fine.
AoT compilation works fine but during runtime I got this error:
EXCEPTION: Uncaught (in promise): Error: Token must be defined!
Error: Token must be defined!

The issue disappears when I remove modal component div (bsModal) from template.
I use Angular 2.4.1, ng2-bootstrap 1.1.16-11
Here is a repo with steps to reproduce:
https://github.com/irsick/ng2-bootstrap-bsModals-issue
Probably it's related to #986

interesting, huge thanks for repo!

I will take a look asap

I'm getting the same issue with the typeahead directive. Angular 2.4.2, ng2-bootstrap 1.1.16-11, AOT build.

@valorkin Any update on this? It would appear that ng2-bootstrap is currently unusable with AOT builds for certain directives, including modal and typeadead.

I tried to reproduce, but works fine for me. Can you do a sample repo

Did you try the sample repo from @irsick ?

Just checked repo. AoT build has throws runtime error as it supposed to do:

I think it is missing the stuff from the utils folder in the AOT build.

rechecked just in case<EMAIL_ADDRESS>

found some sortable component issues, but @irsick repo found another issues
I will try to fix it completely, seems you are using angular-seed repo?

@valorkin Yes, I am using the seed.

updated ng2-bootstrap to v1.2.3, no AoT compilation issues now, but
seems to be seed issue, or what so ever
Error: Error encountered resolving symbol values statically. Could not resolve events relative to /Users/valorkin/work/open-source/temp/ng2-bootstrap-bsModals-issue/node_modules/protractor/built/runner.d.ts., resolving symbol Runner in /Users/valorkin/work/open-source/temp/ng2-bootstrap-bsModals-issue/node_modules/protractor/built/runner.d.ts
    at simplifyInContext (/Users/valorkin/work/open-source/temp/ng2-bootstrap-bsModals-issue/node_modules/@angular/compiler/bundles/compiler.umd.js:25709:25)
    at StaticReflector.simplify (/Users/valorkin/work/open-source/temp/ng2-bootstrap-bsModals-issue/node_modules/@angular/compiler/bundles/compiler.umd.js:25721:15)
    at StaticReflector.annotations (/Users/valorkin/work/open-source/temp/ng2-bootstrap-bsModals-issue/node_modules/@angular/compiler/bundles/compiler.umd.js:25214:82)
    at NgModuleResolver.resolve (/Users/valorkin/work/open-source/temp/ng2-bootstrap-bsModals-issue/node_modules/@angular/compiler/bundles/compiler.umd.js:17564:84)
    at CompileMetadataResolver.getNgModuleMetadata (/Users/valorkin/work/open-source/temp/ng2-bootstrap-bsModals-issue/node_modules/@angular/compiler/bundles/compiler.umd.js:18072:62)
    at addNgModule (/Users/valorkin/work/open-source/temp/ng2-bootstrap-bsModals-issue/node_modules/@angular/compiler/bundles/compiler.umd.js:24980:60)
    at /Users/valorkin/work/open-source/temp/ng2-bootstrap-bsModals-issue/node_modules/@angular/compiler/bundles/compiler.umd.js:24991:16
    at Array.forEach (native)
    at _createNgModules (/Users/valorkin/work/open-source/temp/ng2-bootstrap-bsModals-issue/node_modules/@angular/compiler/bundles/compiler.umd.js:24990:28)
    at analyzeNgModules (/Users/valorkin/work/open-source/temp/ng2-bootstrap-bsModals-issue/node_modules/@angular/compiler/bundles/compiler.umd.js:24865:16)
Compilation failed

if using https://github.com/irsick/ng2-bootstrap-bsModals-issue
@sublime392 please try latest too

and why not to use angular-cli?

I will try to create/modify what @irsick has later tonight in order to demonstrate what I am seeing. In the meantime:
If I only import the modules I need like import { ModalModule } from 'ng2-bootstrap/modal I get the message about Token needs to be defined, or whatever. I also do not see anything from the utils in the compiled code.
If I import like import { ModalModule } from 'ng2-bootstrap I was getting an error about the private  items in sortable. Now (1.2.3) I get ng2-bootstrap/sortable/sortable.component.ngfactory.ts(424,35): error TS2346: Supplied parameters do not match any signature of call target.
I believe I also saw that error on 1.2.2 but it was after the private items error so I ignored it.
Like I said thought, I will try to get something demonstrable later on.
Why am I using the seed?  It is what I started my current project with back when Angular2 first went to beta. It is all I know at this point.

@valorkin I see the sortable compile error I now get with 1.2.3 seems to related to mouse event comment in this issue: https://github.com/valor-software/ng2-bootstrap/issues/1514

@sublime392 fixed in v1.2.4, please try again ;D

I've tested my repo with ng2-bootstrap 1.2.5. The issue still persists.

I don't know if this is totally useless information, or not:
I turned off the minification on my build and found the source of the token error (not the reason)
For this line
           this._ModalDirective_40_5 = new import18.Wrapper_ModalDirective(new import10.ElementRef(this._el_40), this._vc_40.vcRef, this.renderer, this.parentView.injectorGet(import19.ComponentLoaderFactory, this.parentIndex));
the import19 does not have a ComponentLoaderFactory (undefined).
import19 looks like:
Object
AccordionComponent:e(e)
AccordionConfig:e()
AccordionModule:e()
AccordionPanelComponent:e(e)
AlertComponent:e(e)
AlertConfig:e()
AlertModule:e()
BarComponent:e(e)
BsRootModule:e()
ButtonCheckboxDirective:e()
ButtonRadioDirective:e(e)
ButtonsModule:e()
CarouselComponent:e(e)
CarouselConfig:e()
CarouselModule:e()
ClassName:Object
CollapseDirective:e(e, t)
CollapseModule:e()
DateFormatter:e()
DatePickerComponent:e(e)
DatepickerConfig:e()
DatepickerModule:e()
DayPickerComponent:e(e)
DraggableItemService:e()
DropdownConfig:e()
DropdownDirective:e(e, t, n)
DropdownMenuDirective:e(e, t)
DropdownModule:e()
DropdownService:e()
DropdownToggleDirective:e(e, t)
ModalBackdropComponent:e(e, t)
ModalBackdropOptions:e(e)
ModalDirective:e(e, t, n, i)
ModalModule:e()
MonthPickerComponent:e(e)
Ng2BootstrapModule:e()
NgTranscludeDirective:e(e)
OnChange:i(e)
PagerComponent:e(e, t, n)
PaginationComponent:e(e, t, n)
PaginationModule:e()
PopoverConfig:e()
PopoverContainerComponent:e(e)
PopoverDirective:e(e, t, n, i, a)
PopoverModule:e()
ProgressDirective:e()
ProgressbarComponent:e(e)
ProgressbarConfig:e()
ProgressbarModule:e()
RatingComponent:e()
RatingModule:e()
Selector:Object
SlideComponent:e(e)
SortableComponent:e(e)
SortableModule:e()
TabDirective:e(e)
TabHeadingDirective:e(e, t)
TabsModule:e()
TabsetComponent:e(e)
TabsetConfig:e()
TimepickerComponent:e(e)
TimepickerConfig:e()
TimepickerModule:e()
TooltipConfig:e()
TooltipContainerComponent:e(e)
TooltipDirective:e(e, t, n, i, a)
TooltipModule:e()
TypeaheadContainerComponent:e(e)
TypeaheadDirective:e(e, t, n, i, a)
TypeaheadMatch:e(e, t, n)
TypeaheadModule:e()
TypeaheadOptions:e(e)
TypeaheadUtils:e()
YearPickerComponent:e(e)
isBs3:i()
modalConfigDefaults:Object
__proto__:Object

@valorkin I tried loading a modal straight in the root app component instead of a feature module. The error changed to TypeError: import69.PositioningService is not a constructor
In the compiled code looks like import69.PositioningService points to this._PositioningService_98
 if (token === import69.PositioningService) {
           return this._PositioningService_98;
  }

but this._PositioningService_98 points to import69.PositioningService?
 Object.defineProperty(AppModuleInjector.prototype, "_PositioningService_98", {
            get: function () {
                if (this.__PositioningService_98 == null) {
                    this.__PositioningService_98 = new import69.PositioningService();
                }
                return this.__PositioningService_98;
            },
            enumerable: true,
            configurable: true
        });

And you are using forRoot? Can you fork and update sample repo?

@valorkin Here you go. I tried to keep it to the bare minimum for example. Instructions are in README.  https://github.com/sublime392/ng2-bootstrap-bsModals-issue

Awesome, thank you! We are getting closer.
From first look code should work,
Seems too much gulp magic

@mgechev have you seen such things before?

@valorkin I figured it out! woot!
  Type 'BsRootModuleInjector' is not assignable to type 'ComponentFactoryResolver'.
    Types of property 'resolveComponentFactory' are incompatible.
      Type '<T>(component: new (...args: any[]) => T) => ComponentFactory<T>' is not assignable to type '<T>(component: Type<T>) => ComponentFactory<T>'.
        Type 'ComponentFactory<any>' is not assignable to type 'ComponentFactory<any>'.
          Types have separate declarations of a private property '_viewClass'.

whyyyy?

your PR published as v1.2.6

I can not handle this gulp stuff

I am glad I was able to help a little. I am also pretty stoked about making my first PR to such an awesome project.

@sublime392 my congratulations with first PR :)
give me a note, did it helped?

@valorkin I apologize, but I don't understand this part:

give me a note, did it helped?

https://github.com/valorkin/ng2-bootstrap-bsModals-issue
can you try npm run build.prod here?
may be you will be able to fix it

I tweaked a couple of imports and it worked. Now I see the bs folder is gone though.

Thanks I will check it asap

tried again with ng2-bootstrap v1.2.6
seems fixed

I still get Error: Token must be defined! similar issue with PaginationComponent
this._PaginationComponent_64_3 = new import61.Wrapper_PaginationComponent(this.renderer, new import31.ElementRef(this._el_64), this.parentView.injectorGet(import62.PaginationConfig, this.parentIndex));

I got same setup (I am importing PaginationModule.forRoot() and exporting in my SharedModule.
I tried local build of ng2-bootstrap and exporting PaginationConfig class fixed the issue

dist/tmp/node_modules/ng2-bootstrap/index.ngfactory.ts(137,127): error TS2345: Argument of type 'this' is not assignable to parameter of type 'ComponentFactoryResolver'.
  Type 'BsRootModuleInjector' is not assignable to type 'ComponentFactoryResolver'.
    Types of property 'resolveComponentFactory' are incompatible.
      Type '<T>(component: new (...args: any[]) => T) => ComponentFactory<T>' is not assignable to type '<T>(component: Type<T>) => ComponentFactory<T>'.
        Type 'ComponentFactory<any>' is not assignable to type 'ComponentFactory<any>'.
          Types have separate declarations of a private property '_viewClass'.

@valorkin  -- did you ever resolve this error?  I get the same error on a library I'm working on, and this github issue is literally the ONLY google result :)

@jlee1201 it seems pretty change:
replace all 'export *' with named exports

actually, I finally figured out that it was because I was using symlink for the library I was working on.  Related to: https://github.com/Microsoft/TypeScript/issues/9552


Audit records

System updates/changes to some records in the database should be logged into an audit table for tracking purposes. examples:
When a comment is redacted due to PI, a new audit record should be created with: datetime, record_id, record_type

@saravanpa-aot   let us know if you feel like this should be Parking Lot.


Plugin "record" does not exist in Angular 5

Description
plugin "record" does not exist appears when I try to add video tag with 'record' plugin. This the configurations I added.
var player = videojs('myVideo', {        // video.js options       controls: true,       loop: false,       fluid: true,       plugins: {         record: {           audio: true,           video: true,           maxLength: 10,           debug: true,         },       },     });
And I used npm to install packages and I import those package via .angular-cli.json file with correct paths.
versions
videojs
Using the latest versions
browsers
Chrome 65.0
OSes
MacOS High Sierra

@delockdown it's always a good idea to explain why the ticket was closed, maybe others ran into same issue.


Using yii alias in dsn is not resolved - can't open database

After cloning yii-app and adding yiisoft/db-sqlite I wanted to play with the migrations. But didn't work due to the error - can't open database. After a couple of time for debugging I figured out, that the alias won't work:/
What steps will reproduce the problem?
'yiisoft/aliases' => [
'aliases' => [
'@root' => dirname(DIR),
'@assets' => '@root/public/assets',
'@assetsUrl' => '@baseUrl/assets',
'@npm' => '@root/node_modules',
'@public' => '@root/public',
'@resources' => '@root/resources',
'@runtime' => '@root/runtime',
'@views' => '@root/resources/views',
'@message' => '@root/resources/message',
],
],
'yiisoft/db-sqlite' => [
    // working! 'dsn' => 'sqlite:'. dirname(__DIR__) .'/runtime/data/tropfendb.db',
    'dsn' =><EMAIL_ADDRESS>//not working
],

run vendor/bin/yii database/list
What is the expected result?
List of current tables in the database.
What do you get instead?
unable to open database file
Additional info

Q
A

Version
DEV

PHP version
8.0.0

Operating system
Ubuntu

Currently you have to resolve alias yourself before passing it to connection instance.

Dsn string cannot contain alias - only direct path


V5 Navbar : navbar-toggler button not move to right side without brand

my navbar doesn't have a brand so I tried to move the navbar-toggler button to right side but unfortunately it didn't work even if I use .float-end utility class and also I tried to use .position-absolute .end-0 it bring another issue to navbar.
Here a live example :
https://codepen.io/themes4all/pen/LYxydqz
What I want to achieve :
https://www.codeply.com/p/t0Fau4H1h7

@devhoussam you can use margin-left: auto. The bootstrap utility class for this is ms-auto (example).

@devhoussam you can use margin-left: auto. The bootstrap utility class for this is ms-auto (example).

thank you for your help


🐛 Fix exception in attribute analyzers

This fixes an exception inside the analyzer. This is an edge case that happens when there's an annotation for a property that is also a constructor parameter for a record. Since this analyzer should not be used for records anyways, it's safe to fail silently rather than with a warning.

Do you have an example for this? I was curious on which case was giving the error :o

In my project it was:
[Serializable]
public readonly record struct Timer(
    [property: ShowInEditor] float Time,
    [property: ShowInEditor] float CurrentTime,
    [property: ShowInEditor] bool JustFinished
) : IComponent


Laravel 5.2.45 Installation Error

Hi, not sure if anyone else has had this issue, but when trying to require this package through composer, I am getting the below output. I am running 5.2.45 on a local dev environment under Valet on my Macbook Pro. Any suggestions would be welcome.
composer require caffeinated/shinobi
Using version ^3.0 for caffeinated/shinobi
./composer.json has been updated
Loading composer repositories with package information                                                                                Updating dependencies (including require-dev)         Your requirements could not be resolved to an installable set of packages.
Problem 1
- Conclusion: remove laravel/framework v5.2.45
- Conclusion: don't install laravel/framework v5.2.45
- caffeinated/shinobi 3.0.x-dev requires illuminate/config 5.3.* -> satisfiable by illuminate/config[5.3.x-dev, v5.3.0, v5.3.4].
- caffeinated/shinobi v3.0 requires illuminate/config 5.3.* -> satisfiable by illuminate/config[5.3.x-dev, v5.3.0, v5.3.4].
- caffeinated/shinobi v3.0.1 requires illuminate/config 5.3.* -> satisfiable by illuminate/config[5.3.x-dev, v5.3.0, v5.3.4].
- caffeinated/shinobi v3.0.2 requires illuminate/config 5.3.* -> satisfiable by illuminate/config[5.3.x-dev, v5.3.0, v5.3.4].
- caffeinated/shinobi v3.0.3 requires illuminate/config 5.3.* -> satisfiable by illuminate/config[5.3.x-dev, v5.3.0, v5.3.4].
- don't install illuminate/config 5.3.x-dev|don't install laravel/framework v5.2.45
- don't install illuminate/config v5.3.0|don't install laravel/framework v5.2.45
- don't install illuminate/config v5.3.4|don't install laravel/framework v5.2.45
- Installation request for laravel/framework (locked at v5.2.45, required as 5.2.*) -> satisfiable by laravel/framework[v5.2.45].
- Installation request for caffeinated/shinobi ^3.0 -> satisfiable by caffeinated/shinobi[3.0.x-dev, v3.0, v3.0.1, v3.0.2, v3.0.3].

v3.x is only for Laravel 5.3+
You will need to install v2.x for Laravel 5.2.


Automatic file detection

For codemods like same => deepEquals, we should just examine the AVA config in package.json to determine which files are test files, which are sources, etc.
We could do similar things for mocha/tap/etc by parsing their configs. (not sure we want to go down that road).

I understand your reasoning behind for the first part, but that may not include test helper files. For instance, if your tests are in test.js, and you wrote your assertion helpers (which use t.same()) in test-helper.js, then you would not update the right file.

Right, our code would need to figure that out. The convention is they can be in a helpers folder, or prefixed with a _.
I think we should do this once, in AVA itself, so other modules can reuse it: https://github.com/sindresorhus/ava/issues/700

And we shouldn't forget about fixtures.


fix path for molecule binary in container

Describe what this PR does and why we need it:
Makes it so the molecule binary is in the PATH in the molecule container

Coverage remained the same at 40.97% when pulling b02e418e901491f45e2bb45847776986a23b755d on fabianvf:add-molecule-test-image into 46b08730aef197e5e1aca370d6e5594f0346f8a3 on openshift:master.

/lgtm


jx-build-controller after admin operator install results in CrashLoopBackOff status

jx version: version: 3.2.188
Our team is trying to setup JenkinsX through the admin operator on a vanilla Kubernetes cluster in AWS EKS. Using a self hosted Gitlab repository and not using public Github.com.
Created our repository in our Gitlab instance with the following command:
jx admin create --git-kind gitlab --git-name adgantt --git-server https://gitlab.team-domain.com --git-token <PAT> --git-public false --no-operator --repo jenkins-x-admin
Repository creation was successful and looks like the expected files are present in the repo.
Proceeded to run the following admin operator command:
jx admin operator --username adgantt --token <PAT> -u https://gitlab.team-domain.com/admins/jenkins-x-admin
The installation runs as expected and logs the following health status summary:
jx gitops webhook update --warn-on-fail
WARNING: failed to create Scm client for https://github.com/admins/jenkins-x-admin.git: failed to find git token: could not find git token for git server https://github.com
jx health status -A
NAME                          NAMESPACE                     STATUS                        ERROR MESSAGE
daemonset                     kuberhealthy                  OK
deployment                    kuberhealthy                  OK
dns-status-internal           kuberhealthy                  OK
jx-bot-token                  jx                            ERROR                         Check execution error: pod deleted unexpectedly
jx-pod-status                 kuberhealthy                  OK
jx-secrets                    kuberhealthy                  OK
jx-webhook                    jx                            ERROR                         Check execution error: jx/jx-webhook: error when waiting for pod to start: the khcheck check pod is deleted, waiting for start failed
jx-webhook-events             jx                            ERROR                         Check execution error: jx/jx-webhook-events: error when waiting for pod to start: the khcheck check pod is deleted, waiting for start failed
network-connection-check      kuberhealthy                  OK

Please note in the output, the reference to github.com instead of our expected gitlab.team-domain.com.
When reviewing the namespaces created from the process:
% kubectl get namespaces
NAME               STATUS   AGE
default            Active   7d6h
istio-system       Active   2d5h
jx                 Active   4h2m
jx-git-operator    Active   7d4h
jx-production      Active   4h2m
jx-staging         Active   4h2m
kube-node-lease    Active   7d6h
kube-public        Active   7d6h
kube-system        Active   7d6h
kuberhealthy       Active   4h2m
nginx              Active   4h2m
tekton-pipelines   Active   4h2m

Looking at the pods in the various namespaces, I see the following issue in the jx namespace:
% kubectl -n jx get pods
NAME                                            READY   STATUS             RESTARTS   AGE
bucketrepo-bucketrepo-5697f998bc-pb2w7          1/1     Running            0          4h29m
jx-build-controller-57b8fcdb55-pthlv            0/1     CrashLoopBackOff   57         4h29m
jx-gcactivities-27175320-thlnj                  0/1     Completed          0          61m
jx-gcactivities-27175350-fb6rj                  0/1     Completed          0          31m
jx-gcpods-27175320-dkthf                        0/1     Completed          0          61m
jx-gcpods-27175350-tn565                        0/1     Completed          0          31m
jx-pipelines-visualizer-779cc99c9-xnkkd         1/1     Running            0          4h25m
jx-preview-gc-jobs-27175360-klqwd               0/1     Completed          0          21m
jx-preview-gc-jobs-27175370-gwngg               0/1     Completed          0          11m
jx-preview-gc-jobs-27175380-6q6mp               0/1     Completed          0          65s
lighthouse-foghorn-6b4dcfb95d-c4qdt             1/1     Running            0          4h25m
lighthouse-gc-jobs-27175320-s99qr               0/1     Completed          0          61m
lighthouse-gc-jobs-27175350-vl4fq               0/1     Completed          0          31m
lighthouse-gc-jobs-27175380-hfckw               0/1     Completed          0          65s
lighthouse-keeper-8579c6c87-4qzsw               1/1     Running            0          4h25m
lighthouse-tekton-controller-684b96dd8d-t2h6c   1/1     Running            0          4h25m
lighthouse-webhooks-5d8fbd6fbf-rbbbd            1/1     Running            0          35m

The logs for the jx-build-controller pod show the following, which also notes references to github.com instead of our expected Gitlab domain of gitlab.team-domain.com
% kubectl logs -n jx jx-build-controller-57b8fcdb55-pthlv
{"endpoint":"tempo.jx-observability:14268","level":"info","msg":"Initializing OpenTelemetry Traces Exporter","time":"2021-09-01T18:59:49Z","type":"jaeger:http:thrift"}
{"error":"Post \"http://tempo.jx-observability:14268/api/traces\": dial tcp: lookup tempo.jx-observability on <IP_ADDRESS>:53: no such host","level":"warning","msg":"Traces Exporter Endpoint configuration error. Maybe you need to install/configure the Observability stack? https://jenkins-x.io/v3/admin/guides/observability/ The OpenTelemetry Tracing feature won't be enabled until this is fixed.","time":"2021-09-01T18:59:49Z"}
{"level":"info","msg":"about to run: git config --global credential.helper store in dir .","time":"2021-09-01T18:59:49Z"}
{"level":"info","msg":"starting build controller","time":"2021-09-01T18:59:49Z"}
{"level":"info","msg":"starting secret watching masker","time":"2021-09-01T18:59:49Z"}
{"level":"info","msg":"Watching for Secret resources in namespace jx","time":"2021-09-01T18:59:49Z"}
{"level":"info","msg":"Watching for Secret resources in namespace jx-git-operator","time":"2021-09-01T18:59:49Z"}
{"level":"info","msg":"Watching for PipelineActivity resources in namespace jx","time":"2021-09-01T18:59:49Z"}
{"level":"info","msg":"The service is ready to listen and serve.","time":"2021-09-01T18:59:49Z"}
{"level":"info","msg":"ignoring secret bucketrepo-config","time":"2021-09-01T18:59:49Z"}
{"level":"info","msg":"adding mask of secret jenkins-maven-settings entry settings-security.xml ","time":"2021-09-01T18:59:49Z"}
{"level":"info","msg":"adding mask of secret jenkins-maven-settings entry settings.xml ","time":"2021-09-01T18:59:49Z"}
{"level":"info","msg":"ignoring secret jenkins-x-bucketrepo entry BASIC_AUTH_USER","time":"2021-09-01T18:59:49Z"}
{"level":"info","msg":"adding mask of secret jenkins-x-bucketrepo entry BASIC_AUTH_PASS ","time":"2021-09-01T18:59:49Z"}
{"level":"info","msg":"adding mask of secret jx-basic-auth-htpasswd entry auth ","time":"2021-09-01T18:59:49Z"}
{"level":"info","msg":"adding mask of secret jx-basic-auth-user-password entry password ","time":"2021-09-01T18:59:49Z"}
{"level":"info","msg":"adding mask of secret jx-basic-auth-user-password entry username ","time":"2021-09-01T18:59:49Z"}
{"level":"info","msg":"ignoring secret jx-boot entry username","time":"2021-09-01T18:59:49Z"}
{"level":"info","msg":"adding mask of secret jx-boot entry gitInitCommands ","time":"2021-09-01T18:59:49Z"}
{"level":"info","msg":"adding mask of secret jx-boot entry password ","time":"2021-09-01T18:59:49Z"}
{"level":"info","msg":"ignoring secret jx-boot entry url","time":"2021-09-01T18:59:49Z"}
{"level":"info","msg":"adding mask of secret lighthouse-hmac-token entry hmac ","time":"2021-09-01T18:59:49Z"}
{"level":"info","msg":"adding mask of secret lighthouse-oauth-token entry oauth ","time":"2021-09-01T18:59:49Z"}
{"level":"info","msg":"adding mask of secret tekton-container-registry-auth entry .dockerconfigjson ","time":"2021-09-01T18:59:49Z"}
{"level":"info","msg":"adding mask of secret tekton-git entry username ","time":"2021-09-01T18:59:49Z"}
{"level":"info","msg":"adding mask of secret tekton-git entry password ","time":"2021-09-01T18:59:49Z"}
{"level":"info","msg":"wrote git credentials file /tmp/git-creds/git/credentials","time":"2021-09-01T18:59:49Z"}
{"level":"info","msg":"about to run: git clone https://github.com/admins/jenkins-x-admin.git /tmp/jx-git-154599549 in dir /tmp","time":"2021-09-01T18:59:49Z"}
{"level":"info","msg":"Cloning into '/tmp/jx-git-154599549'...\nremote: Support for password authentication was removed on August 13, 2021. Please use a personal access token instead.\nremote: Please see https://github.blog/2020-12-15-token-authentication-requirements-for-git-operations/ for more information.\nfatal: Authentication failed for 'https://github.com/admins/jenkins-x-admin.git/'","time":"2021-09-01T18:59:50Z"}
{"level":"fatal","msg":"failed to get cluster requirements: failed to clone cluster git repo https://github.com/admins/jenkins-x-admin.git: failed to clone repository https://github.com/admins/jenkins-x-admin.git to directory: /tmp/jx-git-154599549: failed to run 'git clone https://github.com/admins/jenkins-x-admin.git /tmp/jx-git-154599549' command in directory '/tmp', output: 'Cloning into '/tmp/jx-git-154599549'...\nremote: Support for password authentication was removed on August 13, 2021. Please use a personal access token instead.\nremote: Please see https://github.blog/2020-12-15-token-authentication-requirements-for-git-operations/ for more information.\nfatal: Authentication failed for 'https://github.com/admins/jenkins-x-admin.git/''","time":"2021-09-01T18:59:50Z"}

It appears that our non-Github.com git URL is not making its way through each of the propagated commands. We could use some help resolving the issue to use our Gitlab repository instead of the default Github.com service.

Found an update in the jx-requirements.yml file to specify the Gitlab server, and this seems to correct the issue with the jx-build-controller pod issue above. Closing the ticket as no longer an issue.
For reference, Git configuration reference: https://jenkins-x.io/v3/admin/setup/config/git/


Show optgroup during search

I'm using <optgroup> to group choices and it works fine. When the user starts searching, though, the optgroups aren't rendered. This is a huge problem for me as several choices have the same name but are under a different group. Without the group names it's impossible for the user to know what he's selecting.
Is there any way to show the optgroups even during search? Any chance you could add this functionality otherwise?
The order of search results would need to change if this is enabled I guess because you only want to print the group names once. The order of the groups should probably also be configurable. In my case I would like to retain the order of the groups regardless of where the most relevant search result is.

Please may you provide a jsfiddle highlighting the issue

Here's a fiddle that highlights this, and my other two issues in one:
https://jsfiddle.net/n7yvrdzL/5/

Please re-open this issue.

Can this issue be re-opened?

why haven't this been implemented?

why haven't this been implemented?

Is there a fix to this issue, or a workaround for it?


can you please add another stuff to this tool?

it is creating any domains but is it posible for you to make it so that we can change the second domain?
for example we give google.com and it is changind to xx--google2309ı.com but it should do it freesite.tk or whatever we want.
sorry for my bad english but i hope you did understand what i mean

Disclaimer: I do not support any illegal activities, and I am not responsible for my solution being used for malicious purpose. So, only start security penetration after written permissions only.
No, it's not possible.. But, you can register the domain and redirect it there or apply an iframe (depends upon your creativity)
I think, this closes the following issue..

I do not support any illegal activities, and I am not responsible for my solution being u

if the tool is giving to everyone the same url do you think any url is open for register? no one of us is supporting illegal activities just asking

I do not support any illegal activities, and I am not responsible for my solution being used for malicious purpose.

if the tool is giving to everyone the same url do you think any url is open for register? no one of us is supporting illegal activities just asking

Just simply saving myself from legal stuff (not only you, there are others too on GitHub)
You can check it yourself, or maybe use any API for getting it done (for automation)

Now, this should close the following issue.


Add ability to disable staging through PUT /v2/apps/:guid

This PR introduces a new, temporary config property called temporary_disable_v2_staging that can be used to disable package staging through the v2 APIs. The property will be removed once the v2 APIs are fully disabled, hence the temporary_ prefix.
In capi-k8s-release this property will default to true. We do not validate that the v2 APIs work in cf-for-k8s so disabling this can help reinforce their lack of support and encourage users to move over to clients that use the v3 APIs.
Additionally, this fixes an issue where the PUT /v2/apps/:guid API would not detect that a package uploaded to the package registry needed staging. This resulted in cf push commands that used the /v2/apps/:guid endpoint to hang until staging timed out.
CAKE Story: #175157530

Rebased and merged manually. Closing this PR.


Where should package_title be defined, and to what?

package_title is only used in the general_cover_sheet.docx, which is used in the send to court code. It isn't defined by the weaver at all however.
It seems to be mostly related to MAVC, but it is defined in some older interviews, like https://github.com/SuffolkLITLab/docassemble-MAMotiontoVacateMaritalHome/blob/e663ac3bdbe35983d77527012fca9ad29359cc0e/docassemble/MAMotiontoVacateMaritalHome/data/questions/Motion to Vacate Marital Home.yml#L937.  If I had to guess, maybe it's only useful for multiple forms that are all in the same package, i.e. 209A?
Shoud the instance in the cover sheet be removed, or should we have more documentation (and something generated in the weaver) for it instead?

If I had to guess, maybe it's only useful for multiple forms that are all in the same package, i.e. 209A?

Yes, I think that was the original thought. I agree that generating something for it in the Weaver is a good idea. package_title is generated as a placeholder by searching the first key in interview_metadata in the MAVC repo. We might not have copied that behavior over to AssemblyLine. That does feel like a reasonable shim for now.
Also see #13

Sounds good. I like the default shim in AL, and we can try to add it in the wizard after multiple attachments get in (https://github.com/SuffolkLITLab/docassemble-assemblylinewizard/issues/113).


Large oscillations in vision-based position control mode (on Intel Aero RTF)

Bug description
The drone flies with oscillations of 1+ meters around the desired position.
To Reproduce
I am using the PX4 release 1.8.0 on the Intel Aero RTF with the following parameter changes in EKF2:
EKF2_AID_MASK: 24 (Don't use GPS, fuse vision position and yaw)
EKF2_EV_DELAY: 20.0 ms
EKF2_HGT_MODE: Vision
Also, for safety reasons I minimized some MPC velocities and accelerations:
MPC_ACC_* = 2.0
MPC_TKO_SPEED = 1.0
MPC_VEL_MANUAL = 3.0
MPC_XY_CRUISE = 3.0
MPC_XY_VEL_MAX = 1.0
MPC_Z_VEL_MAX_UP = 1.0
I am using SVO for visual odometry and send the position estimates through mavros (VISION_POSITION_ESTIMATE).
On the following video you can see the RVIZ visualization of the local position estimate (named drone) and visual odometry output (named drone_vision). They nicely follow each other so the EKF2 estimator seems to be working fine. When the line with the dots appear, the line visualizes the desired trajectory and the dots are the setpoint positions sent to the drone (again with mavros + SET_POSITION_TARGET_LOCAL_NED).
rviz.zip
Any ideas on how this oscillation could be eliminated?

Is your SVO pose estimate correctly scaled?

Are you using an external scale estimation filter?

Are you using an external scale estimation filter?

Not that I know of. SVO is currently only using the camera stream (no IMU, because it only made things worse, maybe because of corrupt timestamps) Could that be the problem? Can PX4 do this, or is this the job of SVO?

@szebedy How are you estimating scale if you don't use IMU measurements? I assume you only use the downward -facing camera and not stereo?
If I'm not mistaken SVO alone doesn't use IMU but needs to be coupled to something like https://github.com/ethz-asl/ethzasl_msf to use IMU and get scale.

Hi @ChristophTobler thank you for your reply.
I guess I am not estimating the scale. SVO has a parameter called map_scale, which is the average scene depth in meters on initialization. I set this to 1.5 and hold the drone at approximately 1.5 meters above the ground when I start SVO.

Could you please provide a log?

@ChristophTobler, I made a new test because unfortunately I don't have the log from the previous test. This time I tried to initialize SVO more precisely (measured the 1.5 m above the ground such that it corresponds with the map scale) and the oscillation wasn't so large, but still noticeable (about 0.5 m).
Here is the log: https://review.px4.io/plot_app?log=31639308-68b2-4741-a348-ae7d496a3c46
And here is the visualization of the flight:
rviz2.zip
Can you tell from these if the oscillation is due to the imprecise VO scaling?

Yes the problem was the VO scaling. If I initialize SVO precisely then the drone flies real nicely.


Replaced semicolon with comma which was prematurely ending var declarations

This was causing an error when require()ing the library via Browserify.

Can you please merge this change? I like this library but I am forced to use my own fork as long as this bug exists.

Thanks!

Sorry about the delay in getting this in - I'll need to get a better method for tracking open PRs over my projects.

Published as v2.0.8


[Rating] Removed focusing bug

Hey guys, fixed a small bug which called the focus handler of the input element if you revisit the site.
Fixes #31020

[X] I have followed (at least) the PR section of the contributing guide.
[ ] I have added tests

Okay I just checked the tests and I have no idea why they are failing. Argos CI says it differs from the desired image but I can't find a difference to how it was before. The CircleCI pipeline fails where I did not made any changes.

Note that this breaks the keyboard behavior on https://deploy-preview-31033--material-ui.netlify.app/components/rating/#basic-rating.

So I basically reverted my changes and added a test which detects if the focus is not handled correctly. The test fails with my original change.

I wouldn't go in this direction. If we do this in one component we would need to do it in all components. Let's continue exploring and brainstorming more solutions in the is issue. Thanks for the effort so far @LukasGerm


Fixed an issue when case timeout returned an incorrect exception and effect the next other test case

Hi!
This is my main account, I submitted the test case here
Associated with https://github.com/cbeust/testng/pull/2440

Hi!
This is my main account, I submitted the test case here

Also please do add an entry into CHANGES.txt

All done!


Secondary environment variable name

Fixes #30

LGTM
Also @NathanFallet In the process of converting the library to async await so the entire auth process is being reworked in that branch. https://github.com/vapor-community/google-cloud-kit/pull/44
I'd take a look into upgrading here as soon as we can. I've been a little behind but if your specific API is being used I'd go ahead and use that branch or the latest commit hash and pin to that.

@Andrewangeta Okay so I keep the branch here unmerged. In case you want to merge it (even in your own branch) feel free to do what you need.


invoke server method,how get return value,eg string

invoke server method,how get return value,eg string,thank you
public string SendComplex(ComplexMessage message)  {
  Clients.All.notifyComplex (message);
  return "OK"

}

Hi, I'll need some more information to help. Can you post some of your client code? In general, you should have something like this:
SwiftR.connect("http://yourserver.com") { connection in
    self?.complexHub = connection.createHubProxy("complexHub")

    self?.complexHub.on("notifyComplex") { args in
        let m: AnyObject = args!["0"] as AnyObject!
        print(m)
    }
}

I need some method like SignalR-objc method,like below code
renderHub?.invoke("hello", withArgs: renderArgs, completionHandler: { (response, error) -> Void in
print("(response)")
})
thank you

OK, I see. I haven't added support for invoke return values yet. I agree that this would be nice to have. I'll work on it next.

Commit fb4fdce4c9a2a9ae95be2a4f63f2c46beae953dd adds this support. The invoke signature is now:
public func invoke(method: String, arguments: [AnyObject]?, callback: ((AnyObject?, String?) -> ())? = nil)

Here's an example usage:
simpleHub.invoke("sendSimple", arguments: ["Simple Test", "This is a simple message"]) { (result, error) in
    if let e = error {
        print("Error message: \(e)")
    } else {
        print("Success!")
        if let r = result {
            print("Result: \(r)")
        }
    }
}

Thank you!

Change is included in v0.8.1.


Add a proxy subprotocol

PR description
A naive implementation of a protocol allowing the exchange of messages between participants, using the notion of "site".
This subprotocol is added to the devp2p protocol family, and becomes available to coordinate communications between nodes.

with a change to the subprotocol to use a 3 char code lgtm.


Cannot delete files/folders from the explorer

VSCode Version: 1.36.0
OS Version: Linux (several versions)

Steps to Reproduce:

Open a folder in the explorer
Select a file/folder
Press the Delete (or Del) key on the keyboard

This should delete the file/folder but instead it makes the explorer search for the file/folders named "Delete". Pressing the Delete more times will only append "Delete" to the end of the search query (eg. "DeleteDeleteDelete...").
Right clicking a choosing Delete from the dialog box works fine.
Does this issue occur when all extensions are disabled?: Yes
Note: I don't know if this is a known bug, but seems to be fixed in the insiders build.

/duplicate of #76514


Help menu overflow due to too many options

This issue is raised in this PR
Basically if there are too many options, the user won't be able to view all of the options on the command line.  Definitely not ideal ...
There are hacks around this.  For example, you could pipe the std errors to a file for view everything.
Another option perhaps is to hack the unix man command to allow to the full help menu to be viewed through more or less.  Any thoughts?

Moved to q2cli: https://github.com/qiime2/q2cli/issues/132


Bug in the blacklist command

Describe the issue
Code or steps to reproduce
Usage with prefix !
!blacklist @Stitch#9441

Expected an actual behaviour
Blacklists me. Instead, it says "guildID must be between 17 and 19 characters.
Further details

discord.js version: latest master
node.js version: 10.0.0
Klasa version: latest master
[ ] I have modified core files.
[ ] I have tested the issue on latest master. Commit hash:

Actually scratch that, I messed up the spacing.


Optimus 2.0.7

Improvements for profiler and several functions

Coverage increased (+3.0%) to 90.159% when pulling 5e26e1726af843b80cdeb4e48d364782d59eb817 on develop into c6589099e1d8b43bedd14f31cc95e4f622771836 on master.


[charts] add support for podLabels and podAnnotations to occm and cinder-csi-plugin charts

What this PR does / why we need it:

feat: add support for defining podLabels and podAnnotations in the openstack-cloud-controller-manager and cinder-csi-plugin charts
fix: apply commonAnnotations to all resources in cinder-csi-plugin chart

Which issue this PR fixes(if applicable):

fixes -

Special notes for reviewers:

please let me know if I should move the fix for commonAnnotations to a seperate PR
please let me know if I chose the correct chart versions - I did not find any documentation about the conventions used by the charts in this repo. My interpretation was the following: the minor chart version is in sync with the appVersion which in turn is in sync with the minor k8s release

Release note:

NONE

/ok-to-test
/easy-cla

Could we wrap all these into some template functions, so that we don't need to write whole with-toYaml-end?

I added helper templates to remove the need to write "with-toYaml-end" and addressed the remarks inline.
@dulek Would you please take another look?

/lgtm
Leaving approval for someone more experienced with Helm.

/remove-lifecycle stale

/retest

@dulek , @kayrus , @zetaab
do any of you have capacity to take a look at this PR?
As far as I can tell I implemented the requested changes. As described in my first comment I'm unsure about the chart version and would suggest squashing the commits after your review is finished.

/lgtm

@dulek , @kayrus , @zetaab, @jichenjc
Sorry for pinging you again. Unfortunately the PR was closed when I failed to correctly rebase my branch. This also removed the lgtm labels.
Do any of you have bandwidth to take another look at this PR?
As described above I think I implemented all requested changes from the review.
I also added an explanation to the first comment, describing why I think this change might be useful.

have you tested this PR in your env? I don't use this chart and it's hard to say whether everything works as expected.

have you tested this PR in your env? I don't use this chart and it's hard to say whether everything works as expected.

Yes I tested these changes. We are using this in production since I opened this PR.
I wanted to contribute these changes, so we don't have to use our own fork anymore.

/lgtm

/approve


[REQUEST] Support for icon packs

Include the ability to use icon packs for the Android apps in the Widgets and Apps pages.

@srcamarda Would a simple "please" kill you?

Hey @Slim08, this is not in an imperative tone. It's just a description of the suggestion, as it is done in formal requests.
Maybe you are not very familiar with git professionally. Sorry if it was interpreted in another way.


Vulnerability in express-1.0.3.tgz (Root Library) > ejs-2.7.4.tgz (Vulnerable Library).

Describe the bug:
We are getting vulnerability error in @cisl/express-1.0.3 version.
Below is the dependency tree:
@cisl/express-1.0.3.tgz (Root Library)
❌ ejs-2.7.4.tgz (Vulnerable Library)
Expected behavior
The @cisl/express should not be having any dependency on vulnerable components.
Actual behavior
The dependent package ejs-2.7.4 refers to be vulnerable components, as per the author the ejs-3.1.6 has the fix for the same.

Thanks for reporting. This has been fixed in 605752d9e111f5979d9441e69ce380da5a274a75, and was included in v1.0.4 release.


Change disassembly to use WorkbenchList

Change disassembly to use WorkbenchList: #130438
Created this since I wasn't able to properly merge the original PR: #133703.
Also need help since I'm not familiar enough with HTML/CSS:

Can't scroll horizontally even if horizontalScrolling is set to true. Didn't work like this several weeks ago, not sure what's wrong here.
List elements that contain source code are not indented correctly.
Based on my test in #130438, I wasn't able to find a way to fix the breakpoint column (elements) from scrolling horizontally.

@roblourens @weinand  FYI. Also, we need some help in the items listed in the description, can you add 'help-needed' label to this PR, and probably ping those who may know how to solve these problems in your team?

I agree with @yuehuang010's comment. Regarding the horizontal scrolling, make sure that you have enabled the global horizontal scrolling setting for the workbench which enables it in all lists. And make sure that you have the right CSS to size rows to the width of their contents, not the width of the container.

I wasn't able to find a way to fix the breakpoint column (elements) from scrolling horizontally.

Sorry, I don't understand what you're asking

@roblourens I'm not sure how to fix them so it would be great if you could provide more details.

make sure that you have enabled the global horizontal scrolling setting for the workbench which enables it in all lists

Yes I have that enabled in both user and workspace settings (ID workbench.list.horizontalScrolling).

make sure that you have the right CSS to size rows to the width of their contents, not the width of the container

Not sure how to do this or if I did something wrong?

Sorry, I don't understand what you're asking

The entire page is a list, including the breakpoint column. So when scrolling horizontally, it would be scrolled out of the view port. We need a way to fix it from scrolling horizontally. I have tried some methods that works for native table/list like position:sticky, but none of them work.
Also, you didn't answer my second question so I try to add some details here. I would like the indentation the same as what we have currently. But with this PR, the disassembly lines that have source code are not indented correctly:

You can use the developer tools to see the sizes of elements and what CSS is applied. You can look at the search view with horizontal scrolling enabled for a working example

The .monaco-list-row element should have the width of its content. That is measured here https://github.com/xisui-MSFT/vscode/blob/de7d0b420d7cb41e29df77307c929019ebb04eec/src/vs/base/browser/ui/list/listView.ts#L711 where it is applied to the DOM.
Regarding the sticky sidebar, I think that is doable with the list. https://stackoverflow.com/questions/57435232/position-sticky-not-working-for-horizontal-scrolling-when-element-width-increase looks helpful
I am not seeing that, I see this

@roblourens I still need to spend some time to test (1) and (3). I think (2) is a display rounding error for certain resolution. I use an empty div of the same size as breakpoint element as a placeholder for source lines. So for some display resolution, the height of this div may be slightly larger than the height set, and therefore occupies the corresponding space in the following line. I think an acceptable workaround is to set its height to 1px since it's always blank and we won't need event listeners for it.

I use an empty div of the same size as breakpoint element as a placeholder for source lines

You probably want to do this with something like the margin or padding CSS properties, not an empty div.

I use an empty div of the same size as breakpoint element as a placeholder for source lines

You probably want to do this with something like the margin or padding CSS properties, not an empty div.

Can padding/margin be fixed from scrolling?

@roblourens List row size doesn't seem to fit to its content for me. Content (a child):

Where the size of list row:

And interestingly, the size of text is larger than both...:

Any insights?

@roblourens ping since I didn't see any response for a long time 😊

I've been out sick this week so far. In general I recommend looking at what the search view is doing and trying to copy it.

I mean this one in the sidebar where horizontal scrolling works:

Abandoning this PR since there are more issues than we expected, and yet we didn't see any progress in the past several weeks.


Switch to hudanimations_manifest

Further documentation: http://huds.tf/forum/showthread.php?tid=151

Added in a048003.


how to only optimize color

I want to know how to fix the geometry of my input, so I can only optimize the color and not optimize the geometry. Specifically, I want to know how to modify the codes?

Hi -- the easiest way to do this would be to comment out line 421 (https://github.com/threedle/text2mesh/blob/5578d47f4812a9660d73e9628416741bb425c0b7/main.py#L421C1-L422C1) in the code. The mesh geometry will no longer be updated during the optimization.


Mark trainer.data_connector as protected

What does this PR do?
Part of #9778
Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

[ ] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[ ] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure your PR does only one thing, instead of bundling different changes together?
[ ] Did you make sure to update the documentation with your changes? (if necessary)
[ ] Did you write any new necessary tests? (not for typos and docs)
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] Did you list all the breaking changes introduced by this pull request?
[ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[ ] Is this pull request ready for review? (if not, please submit in draft mode)
[ ] Check that all items from Before submitting are resolved
[ ] Make sure the title is self-explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃

I'm fine with moving forward if we want to change the internals of the DataConnector. But it seems we don't actually have any concrete plans (see section about Connectors in https://docs.google.com/document/d/1xHU7-iQSpp9KJTjI3As2EM0mfNHHr37WZYpDpwLkivA/edit#).
In the past we have expressed some ideas to better define and restrict the responsibilities of the connectors. I will add more ideas there in the document.


Some points found in debugging.

If pserver can't save checkpoint, the job can't be fault-tolerant, should the whole job exit?
If num_sample == 0 when we do evaluator, what cost should be displayed?

Should we support split a job with a file-list not only recordio format.And then user can use their format without convert to recordio file.

And should we support split txt file to tasks?

It's easy to confuse to call it cloud_reader because we can cloud_reader train data and so we can read test data from the cloud? So rename it to get_task_train_data?

If pserver can't save checkpoint, the job can't be fault-tolerant, should the whole job exit?

We don't consider pserver fault tolerant currently. It's not a blocking issue, yet we need to fix it later.

If num_sample == 0 when we do evaluator, what cost should be displayed?

If num_sample == 0 trainer.py would never call event_handler

Should we support split a job with a file-list not only recordio format.

I agree, I remember there was an issue for that.

If pserver can't save checkpoint, the job can't be fault-tolerant, should the whole job exit?

Did you found that pserver can't save checkpoint? I have a fix here: https://github.com/PaddlePaddle/Paddle/pull/5053

Should we support split a job with a file-list not only recordio format.

That is a good point, probably not for this experiment. (this can be fixed after refactor, everything becomes an OP).

It's easy to confuse to call it cloud_reader because we can cloud_reader train data and so we can read test data from the cloud? So rename it to get_task_train_data?

Do you mean we need to express the fact that cloud_reader is just for training, not for testing? Yes that's is a good point. get_task_train_data is a candidate, maybe we need to think for more candidates before we decide. Let's not worry about this one now, and focus on finishing the experiment and fixing all the bugs found by the experiment.

Ye, all of these are just for discussion and should not block the experiment.


ssl.SSLWantReadError in version 3.3.0

Version: 3.3.0
Platform: Python3.7 aws Lambda and Python 3.6 Ubuntu 18.04
Description:
Hello
We upgraded today version to the last one - 3.3.0 from 3.2.1.
When we did that we started to get ssl error.
reverting version to 3.2.1 fix the issue...
code:
from redis import StrictRedis
cache = StrictRedis(
    host=SESSION_CACHE_HOST,
    db=int(SESSION_CACHE_DB),
    password=SESSION_CACHE_PASS,
    ssl=True)
print(cache.keys())

traceback:
Traceback (most recent call last):
...
 File "/var/task/redis/client.py", line 1307, in exists
 return self.execute_command('EXISTS', *names)
 File "/var/task/redis/client.py", line 836, in execute_command
 conn = self.connection or pool.get_connection(command_name, **options)
 File "/var/task/redis/connection.py", line 1049, in get_connection
 if connection.can_read():
 File "/var/task/redis/connection.py", line 666, in can_read
 return self._parser.can_read(timeout)
 File "/var/task/redis/connection.py", line 280, in can_read
 return self._buffer and self._buffer.can_read(timeout)
 File "/var/task/redis/connection.py", line 190, in can_read
 raise_on_timeout=False)
 File "/var/task/redis/connection.py", line 159, in _read_from_socket
 data = recv(self._sock, socket_read_size)
 File "/var/task/redis/_compat.py", line 58, in recv
 return sock.recv(*args, **kwargs)
 File "/var/lang/lib/python3.7/ssl.py", line 1037, in recv
 return self.read(buflen)
 File "/var/lang/lib/python3.7/ssl.py", line 913, in read
 return self._sslobj.read(len)
ssl.SSLWantReadError: The operation did not complete (read) (_ssl.c:2488)

Got the same error in AWS Beanstalk ...

Also seeing this behavior in AWS Lambda Python3.7.

Based on the traceback I suspect that SSL connections raise a different exception when they are in nonblocking mode than normal sockets. I’ll have a hot fix out in a few hours.

Confirmed my suspicion here: https://docs.python.org/3/library/ssl.html under notes about nonblocking sockets.
I’ll work on a fix when I’m at my desk.

Just pushed a fix to Github. Will release 3.3.1 once Travis gives the all clear.

redis-py 3.3.1 is now available on PyPI. Thanks for reporting this. Please confirm that this fixes your issue.

Still getting an error, however it is slightly different than before.
Code:
import redis

r = redis.StrictRedis(host=host, port=port, password=pw, ssl=True)
r.keys('*')

traceback:
Traceback (most recent call last):
  File "test-redis.py", line 8, in <module>
    r.keys('*')
  File "/tmp/env/lib/python3.6/site-packages/redis/client.py", line 1387, in keys
    return self.execute_command('KEYS', pattern)
  File "/tmp/env/lib/python3.6/site-packages/redis/client.py", line 836, in execute_command
    conn = self.connection or pool.get_connection(command_name, **options)
  File "/tmp/env/lib/python3.6/site-packages/redis/connection.py", line 1060, in get_connection
    if connection.can_read():
  File "/tmp/env/lib/python3.6/site-packages/redis/connection.py", line 677, in can_read
    return self._parser.can_read(timeout)
  File "/tmp/env/lib/python3.6/site-packages/redis/connection.py", line 291, in can_read
    return self._buffer and self._buffer.can_read(timeout)
  File "/tmp/env/lib/python3.6/site-packages/redis/connection.py", line 201, in can_read
    raise_on_timeout=False)
  File "/tmp/env/lib/python3.6/site-packages/redis/connection.py", line 170, in _read_from_socket
    data = recv(self._sock, socket_read_size)
  File "/tmp/env/lib/python3.6/site-packages/redis/_compat.py", line 58, in recv
    return sock.recv(*args, **kwargs)
  File "/usr/lib/python3.6/ssl.py", line 997, in recv
    return self.read(buflen)
  File "/usr/lib/python3.6/ssl.py", line 874, in read
    return self._sslobj.read(len, buffer)
  File "/usr/lib/python3.6/ssl.py", line 633, in read
    v = self._sslobj.read(len)
ssl.SSLWantReadError: The operation did not complete (read) (_ssl.c:2305)

@jzillioux Thanks. I'm looking into this now. I have an assumption and need to setup an SSL connection to test.

I just pushed another fix. SSL connections in non-blocking mode raise SSL-specific exceptions to indicate that there is no data to read on the socket. Additionally, they have their own error numbers which do not correspond to non-SSL socket error numbers.
I've pushed 3.3.2 to PyPI. Please let me know if this fixes the issue for you.

I'm getting an ImportError related to the SSLWantReadError class. I use Python 2.7.6 so the ssl module in stdlib is known to be outdated. But I did not find anything regarding dropping support for Python < 2.7.9, so I think this still count as a regression?
File "eggs/redis-3.3.2-py2.7.egg/redis/__init__.py", line 1, in <module>
    from redis.client import Redis, StrictRedis
File "eggs/redis-3.3.2-py2.7.egg/redis/client.py", line 13, in <module>
    from redis.connection import (ConnectionPool, UnixDomainSocketConnection,
File "eggs/redis-3.3.2-py2.7.egg/redis/connection.py", line 42, in <module>
    ssl.SSLWantReadError,
AttributeError: 'module' object has no attribute 'SSLWantReadError'

Tested with python 3.6.8 and python 2.7.15 on Ubuntu 18.04 and the changes in 3.3.2 resolved the issues I was seeing.

@jzillioux Awesome, thanks for testing.
@JokerQyou Thanks for reporting this. I'll install an older 2.7.x release and see how difficult it will be to support the ssl module in Python < 2.7.9.

Just released 3.3.3 which accommodates all versions of Python 2.7.

FYI I just released redis-py 3.3.4. This version supports all versions of Python 2.7 and also checks to ensure that nonblocking socket reads behave correctly.
3.3.1, 3.3.2 and 3.3.3 could potentially fail to report a real socket error.


feat: twitter clone pivot app

This PR updates the app to a Twitter-like clone.
Got DB migration, might break other dev db. So I created a new db just for this branch on vercel
TOOL-49

The plan is to merge in this app, then tear it down to its bare essentials

Reset the database on prod to fit new schemas


DOC: give read_clipboard a signature

Wouldn't necessarily need to add everything that read_table accepts, but at minimum adding a couple common ones like delim_whitespace and sep would make it nicer for argument completion in interactive use.
https://github.com/pydata/pandas/blob/master/pandas/io/clipboard.py#L6

Actually it is:) PR is appreciated.


Add environment value and set config appropriately

Description of the change

By default the app-config.production.yaml file is not used in bootup process of backstage. This leads to misconfiguration and confusion (see attached issue). This PR is a no-op for folks who continue to not set backstage.environment value, however those using the production string will have the config correctly passed in.
Existing or Associated Issue(s)

https://github.com/backstage/backstage/issues/25189
Additional Information

It is not strictly required to pass in --config app-config.yaml however I felt that being extra verbose would be clearer in this case.
I noticed that the ct install tests were failing, even off master, and I believe this is due to the NODE_ENV not being set correctly thus causing the guest auth provider to error out. I now set that env var based on the backstage environment
Checklist

[x] Chart version bumped in Chart.yaml according to semver.
[x] Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
[x] JSON Schema generated.
[x] List tests pass for Chart using the Chart Testing tool and the ct lint command.

@ChrisJBurns sorry to tag you in this directly, but wanted to make sure you saw it as its marked stale! Would appreciate a review :)


Introduction to Dynamic Host Configuration Protocol (DHCP)

Proposed title of article
Introduction to Dynamic Host Configuration Protocol (DHCP)
Introduction
The vast majority of the host on the internet are user-end devices. These devices require a unique identifier on the internet known as an Internet Protocol (IP) address.
This address can be configured as static by a network administrator or dynamically using Dynamic Host Configuration Protocol (DHCP).
This article will look at DHCP version 4 (DHCPv4) and DHCP version 6 (DHCPv6).
Key takeaways:
At the end of this article, the reader should have learned:

What DHCP is
the need for DHCP
The various versions of DHCP in used

References:
https://www.efficientip.com/what-is-dhcp-and-why-is-it-important/

good topic @raboba2re - approved.