Invalid JSON

The JSON value shared in the first example under the Prerequisites section has an invalid syntax. Line 6 at least requires a trailing comma and if this fabric setting is following the same structure as the others (e.g. name/parameters pairs), it should probably look more like the following:
{
"name": "CentralSecretService",
"parameters": [
{ "name": "IsEnabled", "value": "true"}
{ "name": "MinReplicaSetSize", "value": "3"}
{ "name": "TargetReplicaSetSize", "value": "3"}
]
}

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1d9706bb-4b9e-c17d-8c00-a69d10e47f81
Version Independent ID: 9d7f41f2-05b3-f638-00c4-bc10698d591f
Content: Azure Service Fabric - Using Service Fabric application KeyVault references
Content Source: articles/service-fabric/service-fabric-keyvault-references.md
Service: service-fabric
GitHub Login: @athinanthny
Microsoft Alias: atsenthi

@WhitWaldo Thanks for the feedback! We are currently investigating and will get back on this.

@WhitWaldo Thanks, you are right. The JSON is not well-formed.

@VikasPullagura-MSFT  @tijoytom  While you're making changes, I'd also suggest adding a note about ensuring that this isn't implemented except against v7 of the SF cluster version or higher as it'll prevent app registration in versions lower than that.


Help

Please tell me, what am I doing wrong? I enter a number without a country code, namely without +7. What could be the problem?

Hi,
To sign in to Telegram Web without a QR code, please visit the Telegram Web sign-in page and choose the option to log in via phone number.
Follow these steps:

Step 1: Identify and enter the country where your cellphone is registered, in words (e.g., Afghanistan, Albania, Algeria). You need to enter this into the script at the first prompt with the same spelling used by Telegram.
Step 2: At the second prompt, enter your mobile number without the initial zero (0).

The script operates by initiating a virtual browser session that accesses the official Telegram sign-in page linked above. Enter the same combination that works for you on the official page when prompted by the script. Note: The script does not transmit or save your password or phone details directly. However, it does save the "logged in" browser session to your hard drive, which should be kept secure.

Step 3: You will be prompted for a 5-digit one-time password, which will be sent to your registered device.
Step 4: If you have two-factor authentication (2FA) enabled, you'll need to enter this as well to proceed.

Thanks.


rename QiskitBackendNotFoundError to BackendNotFoundError

Following the suggestion from https://github.com/Qiskit/qiskit-terra/issues/601#issuecomment-471257119

Please refer to my comment on the recent PR about this: https://github.com/Qiskit/qiskit-terra/pull/3208#pullrequestreview-297841112
If we want to do this we'll have to subclass QiskitBackendNotFoundError and properly deprecate it to make sure people can transition. But I personally don't understand the point here, sure BackendNotFoundError is probably a better name for the exception, but the amount of effort to just rename it to drop the 'Qiskit' seems kind of high.

Indeed. Just renaming is not enough. Proper deprecation is needed.

Wondering why renaming it. Qiskit (Terra) is not and end-user software,  can be used with many other libraries by a product developer, so having the Qiskit prefix will give more context to the developer about where the exception is coming.

That would apply to every exception.
It's relatively easy to see where is the exception is coming from if that's a problem.

I agree with @atilag,  however it looks a really good first issue for a beginer
I'll work on this one

closing following https://github.com/Qiskit/qiskit-terra/pull/3208#pullrequestreview-297841112


Collections meeting 06/27

Topics for the next meeting, feel free to add more:

Should we provide buffering transformations on Iterator (as implemented in #96) or only on Iterable (as in the 2.12 collections)?
Empty parameter list vs no parameter list? We should make a decision based on the direction Dotty will take. Also consider Java interop.
Implicit builders #112 vs #114.
Type inference issue for collect (see #117)
Merge Vector (#115)
Merge Traversable and Iterable operations (#119 and #120)
Runtime error with Dotty only in #48
Non-laziness of #::

Meeting summary:

Use #114 and defer type-driven building to a later time. Investigate Dotty build problem (@szeiger)
Merge #115, add StrictOptimizedSeqOps (@julienrf)
Non-laziness of right-associative operators: Don't have such operators until we can fix the underlying problem
Only add methods like dropRight to Iterable, not Iterator (same as Scala 2.12 collections)
Defer decision about empty parameter lists

That all sounds good.

I’m closing this issue because we have created separated issues for each actionable thing.


Update readme & check installation instructions

I quickly tried to see if I could reproduce #169 in 5 mins with a clean zip from the repo and by following the instructions.
Personally, I'm having trouble even getting installing dependencies using npm install. (I am running a fairly new version of npm, which has caused me some grief on other projects as well -- but that's besides the point).
I think we should take a look at the readme and required packages and see if they cannot be upgraded so that it's easier to set up.

@nicoverbruggen This is now fixed!

And a duplicate of #180 ;)


Install and Sync AWS for build binary & deploy

Problems solved in this PR

after_success and before_install are only executed for Build Binary and Deploy stages
Users that fork this repo and lack of AWS won't have failing CI builds

@juanpaucar Could you please take a look?
NOTE: You can see the generated configuration  by copying the .travis.yml and pasting it here

Thanks @juanpaucar


Add stable releases

Since bugs in the Ruby LSP can be disruptive of developer's workflows, we should have a stable release branch, which includes only changes that we are confident can be pushed forward.
Investigate and prototype a mechanism for doing regular stable releases from a stable branch. Tapioca has something similar and can serve as an example.

First of all get rid of https://github.com/Shopify/ruby-lsp/blob/main/shipit.production.yml, since I found out that ShipIt works just fine without it and since the name needs to match the stack name now, it ends up causing problems with different ShipIt stacks.

First of all get rid of https://github.com/Shopify/ruby-lsp/blob/main/shipit.production.yml, since I found out that ShipIt works just fine without it and since the name needs to match the stack name now, it ends up causing problems with different ShipIt stacks.

What is the difference between semantic versioning and the 0-0-stable style versioning?


More some performance optimizations

Another solid decrease in the diff time (7s => 4s). This plus the last PR have decreased the diff time to about 25% of the original time. I'm now seeing 40s => 10s on one page and 25s => 4s on another overall.

Nice, LGTM.


Legend SQL - assortment of changes

What type of PR is this?
Improvement/Bug Fix
What does this PR do / why is it needed ?

allow realias of column to table column name
splitPart support
handle aggregations within case statement

Which issue(s) this PR fixes:
Other notes for reviewers:
Does this PR introduce a user-facing change?

/easycla


Component math

Delete all the boilerplate from CRA (text, images, styles).
Create a directory called components.
Inside components create a new Calculator.js file.
In Calculator.js, create a React component that matches this design
Test it in the browser; it should render without problems

STATUS: INVALID CODE REVIEW REQUEST 🛑 🛑
Hi @Iptysam,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
1. You have used the wrong workflow. You should request a merge to the develop branch not the main branch
2. I would also recommend you update your README with detailed instructions on how to set up and run the project locally
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. And please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.


Java 11 and extract Process name

Send process name and process user as default application name and user name on headers

This includes an alternative way to extract real process name for windows but should remove next commit
Once removed  process name is  extracted from executed file name

The process name will always be "java.exe", so we need a method to get the main "package"/class/something.
We might want to upgrade to java 11 anyway in our next breaking change.

Decided on making this the main module name

apologies for I am uninitiated, but is there a valid reason for breaking 1.8 compat with this change?


scripts: ci: Add Sanitycheck testsuite to CI

run-ci.sh: pytest will execute the sanitycheck testsuite on
matrix 1 from scripts/tests/sanitycheck directory in any
scenario.
TestReport: Junitxml report for pytest is captured in
./pytest_out/sanitycheck_testsuite.xml and then copied to
shippable/testresults.
Signed-off-by: Aastha Grover<EMAIL_ADDRESS>

also, this will have the same test run on every single matrix node, so now it will run the same tests 5 times.
Please look at how it was done with west (which was removed in commit: 2fd7876aa7156664c357e61dd74e2eac363ae02e)

also, this will have the same test run on every single matrix node, so now it will run the same tests 5 times.

Followed how it was done in west and testsuite will now run on matrix node 1.

We really should do this as a github action.  See .github/workflows/west_cmds.yml for how to only run this if we modify sanitycheck related files in a PR.

We really should do this as a github action.

what is the benefit of this? I understand this with west, but why is this relevant for sanitycheck? We will have more (10x) of those pytest tests for all the scripts we have under scripts/, do we want to create a GH action for each?

what is the benefit of this? I understand this with west, but why is this relevant for sanitycheck? We will have more (10x) of those pytest tests for all the scripts we have under scripts/, do we want to create a GH action for each?

Yes, if we have 10x scripts that have pytests, we should add a github workflow to run those tests when the scripts get modified in a PR.  I'm kinda abusing the action/workflow terms here.  I don't see any particular reason not to utilize github to run such tests in a workflow.

Yes, if we have 10x scripts that have pytests, we should add a github workflow to run those tests when the scripts get modified in a PR.

IMO tests need to run always, and not only when the scripts themselves change, ie.. we might change the python version in docker which would result in those python scripts not working correctly, so we will never be able to catch such issues, this also could happen if we update some other dependency.
So I am fine having one GH action that runs all pytest testsuites for example, but doing an action for each is going to be a stretch...
Still want to hear about the benefit of doing this in general though. What is the strategy here? Those tests run and complete in seconds, so it can't be execution time...

IMO tests need to run always, and not only when the scripts themselves change, ie.. we might change the python version in docker which would result in those python scripts not working correctly, so we will never be able to catch such issues, this also could happen if we update some other dependency.
So I am fine having one GH action that runs all pytest testsuites for example, but doing an action for each is going to be a stretch...
Still want to hear about the benefit of doing this in general though. What is the strategy here? Those tests run and complete in seconds, so it can't be execution time...

Why? what value is there in running the tests for something that hasn't changed.  I was suggesting using a workflow since it separates out the type of tests being run.  I don't think it makes sense to mix tests run via sanitycheck with other tests in run_ci.sh and we should transition the bsim tests out of run_ci.sh

Why? what value is there in running the tests for something that hasn't changed.

environment change can also be a factor, so if we have a new yaml parser, a new python version, or whatever, this will find issues. If we are going to test only when the code being tested has changed then we will miss those.
But I guess I am willing to go to the separate action route, we need to move bsim and edtt out as well however, though from what I see, this will be tough to isolate only to bluetooth changes, see https://github.com/zephyrproject-rtos/zephyr/pull/25564#pullrequestreview-436936854

@aasthagr  will you be able to make a GH action out of this, something similar to the west actions in .github/workflows/west_cmds.yml ?

@aasthagr will you be able to make a GH action out of this, something similar to the west actions in .github/workflows/west_cmds.yml ?

Sure, will do that. And the tests need to run only when there are changes to sanitylib or sanitycheck script?

Sure, will do that. And the tests need to run only when there are changes to sanitylib or sanitycheck script?

correct

Might want to add a dummy change to sanitycheck to make sure this tests out ok. Maybe do a separate PR based on this w/the dummy change showing this action running.

I already tested this out on my forked, but surely can do a separate PR to show this is working.

I already tested this out on my forked, but surely can do a separate PR to show this is working.

Pointed to your fork where this ran is fine as well.  Just add a comment in the PR to show it.

I already tested this out on my forked, but surely can do a separate PR to show this is working.

Pointed to your fork where this ran is fine as well. Just add a comment in the PR to show it.

Forked repository depicting the workflow run for snaitycheck-testsuite : https://github.com/aasthagr/zephyr/actions/runs/162425604.

hmm, wonder why this is passing in your fork but the testsuite failing in current master, see:
>       assert all(x in list(discards.values()) for x in [expected_discards])
E       assert False
E        +  where False = all(<generator object test_apply_filters_part1.<locals>.<genexpr> at 0x109c163d0>)

scripts/tests/sanitycheck/test_testsuite_class.py:221: AssertionError
------------------------------------------------------------ Captured log setup -------------------------------------------------------------
DEBUG    sanitycheck:sanitylib.py:2532 Reading test case configuration files under /Users/anashif/zephyr/zephyrproject/zephyr/scripts/tests/sanitycheck/test_data/testcases/tests...
DEBUG    sanitycheck:sanitylib.py:2535 scanning /Users/anashif/zephyr/zephyrproject/zephyr/scripts/tests/sanitycheck/test_data/testcases/tests
DEBUG    sanitycheck:sanitylib.py:2535 scanning /Users/anashif/zephyr/zephyrproject/zephyr/scripts/tests/sanitycheck/test_data/testcases/tests/test_a
DEBUG    sanitycheck:sanitylib.py:2543 Found possible test case in /Users/anashif/zephyr/zephyrproject/zephyr/scripts/tests/sanitycheck/test_data/testcases/tests/test_a
ERROR    sanitycheck:sanitylib.py:1518 /Users/anashif/zephyr/zephyrproject/zephyr/scripts/tests/sanitycheck/test_data/testcases/tests/test_a/test_ztest_error.c: Found a test that does not start with test_
ERROR    sanitycheck:sanitylib.py:1518 /Users/anashif/zephyr/zephyrproject/zephyr/scripts/tests/sanitycheck/test_data/testcases/tests/test_a/test_ztest_error_1.c: found invalid #ifdef, #endif in ztest_test_suite()
ERROR    sanitycheck:sanitylib.py:1518 /Users/anashif/zephyr/zephyrproject/zephyr/scripts/tests/sanitycheck/test_data/testcases/tests/test_a/test_ztest_error.c: Found a test that does not start with test_
ERROR    sanitycheck:sanitylib.py:1518 /Users/anashif/zephyr/zephyrproject/zephyr/scripts/tests/sanitycheck/test_data/testcases/tests/test_a/test_ztest_error_1.c: found invalid #ifdef, #endif in ztest_test_suite()
DEBUG    sanitycheck:sanitylib.py:2535 scanning /Users/anashif/zephyr/zephyrproject/zephyr/scripts/tests/sanitycheck/test_data/testcases/tests/test_c
DEBUG    sanitycheck:sanitylib.py:2543 Found possible test case in /Users/anashif/zephyr/zephyrproject/zephyr/scripts/tests/sanitycheck/test_data/testcases/tests/test_c
DEBUG    sanitycheck:sanitylib.py:2535 scanning /Users/anashif/zephyr/zephyrproject/zephyr/scripts/tests/sanitycheck/test_data/testcases/tests/test_b
DEBUG    sanitycheck:sanitylib.py:2543 Found possible test case in /Users/anashif/zephyr/zephyrproject/zephyr/scripts/tests/sanitycheck/test_data/testcases/tests/test_b
DEBUG    sanitycheck:sanitylib.py:2532 Reading test case configuration files under /Users/anashif/zephyr/zephyrproject/zephyr/scripts/tests/sanitycheck/test_data/testcases/samples...
DEBUG    sanitycheck:sanitylib.py:2535 scanning /Users/anashif/zephyr/zephyrproject/zephyr/scripts/tests/sanitycheck/test_data/testcases/samples
DEBUG    sanitycheck:sanitylib.py:2535 scanning /Users/anashif/zephyr/zephyrproject/zephyr/scripts/tests/sanitycheck/test_data/testcases/samples/test_app
DEBUG    sanitycheck:sanitylib.py:2543 Found possible test case in /Users/anashif/zephyr/zephyrproject/zephyr/scripts/tests/sanitycheck/test_data/testcases/samples/test_app
DEBUG    sanitycheck:sanitylib.py:2486 Reading platform configuration files under /Users/anashif/zephyr/zephyrproject/zephyr/scripts/tests/sanitycheck/test_data/board_config...
DEBUG    sanitycheck:sanitylib.py:2489 Found platform configuration /Users/anashif/zephyr/zephyrproject/zephyr/scripts/tests/sanitycheck/test_data/board_config/1_level/2_level/board_config_1.yaml
DEBUG    sanitycheck:sanitylib.py:2489 Found platform configuration /Users/anashif/zephyr/zephyrproject/zephyr/scripts/tests/sanitycheck/test_data/board_config/1_level/2_level/board_config_2.yaml
DEBUG    sanitycheck:sanitylib.py:2489 Found platform configuration /Users/anashif/zephyr/zephyrproject/zephyr/scripts/tests/sanitycheck/test_data/board_config/1_level/2_level/board_config_3.yaml
------------------------------------------------------------- Captured log call -------------------------------------------------------------
DEBUG    sanitycheck:sanitylib.py:2655 platform filter: ['demo_board_2']
DEBUG    sanitycheck:sanitylib.py:2656     arch_filter: None
DEBUG    sanitycheck:sanitylib.py:2657      tag_filter: None
DEBUG    sanitycheck:sanitylib.py:2658     exclude_tag: None
INFO     sanitycheck:sanitylib.py:2675 Building initial testcase list...
========================================================== short test summary info ==========================================================

wonder why this is passing in your fork but the testsuite failing in current master, see:

btw, that failure is so difficult to decrypt and understand, so this needs to be improved, I really can't see quickly what is failing. you should try and avoid asserting on something like that assert all(x in list(discards.values()) for x in [expected_discards])

hmm, wonder why this is passing in your fork but the testsuite failing in current master, see:

I am not able to reproduce this error on the main branch as well. Please try to rebase on your end and see if the issue still exists.

I am not able to reproduce this error on the main branch as well. Please try to rebase on your end and see if the issue still exists.

I am always on the tip of the mainline branch...

I am not able to reproduce this error on the main branch as well.

my other comment about the assert still applies.

I am always on the tip of the mainline branch...

fails for me on Linux and MacOS...

I am not able to reproduce this error on the main branch as well.

my other comment about the assert still applies.

Sure, Will have to submit the change in another PR I think but the error message doesn't seem to be due to the assert statement. From your logs the error message is in /test_data/testcases/tests/test_a/test_ztest_error.c: Found a test that does not start with test_.
And the assert statement is just asserting on the exepected discard values in the test_apply_filter function . I am not sure how should it be changed. Any suggestions?


require('react-dnd') causes type error on linux but not on os-x.

I have an admittedly strange technology stack, but I'm hoping you can help me anyway. I'm using rails with browserify-rails to use recent versions of reactjs (15.0.2), redux (3.5.2), and react-dnd (2.1.4).
On os-x it works great but on linux I get very strange behavior. The first time I require react-dnd I get the following stack trace, the second time I get an object with a function DragDropContext but DropTarget and DragSource are undefined.

Failing on this line of code.
arguments[4]["/home/thomas/checker-cruncher/node_modules/react-dnd-html5-backend/lib/shallowEqual.js"][0].apply(exports,arguments)
I've previously had issues with capitalization on these two operating systems, osx doesn't care so require("react-DND") is the same as require("react-dnd") but I don't think that's the problem this time. Or at least I haven't found it.
Do you have any ideas as to what I'm doing wrong, or how I can narrow down the problem?
 Clearing the browserify-rails cache solved the problem. I apparently just needed to wine to someone before I could figure it out.

It happens to the best of us!


Logging doesn't work in the examples

I'm running RUST_LOG=debug target/examples/triangle and getting now output. We have lots of info! calls in the device implementation (like this one) that are expected to show up.

Turns out the applications need to call env_logger::init() to switch the "log" crate into the old behavior. I wonder if we need to add it to all our examples...

The situation has changed with #695, though it's still confusing by the user to get the error in the shader log. Perhaps, we can add a get_program_log call on failure to print out the error in some (or one) of the examples.


new container needs to be added to master container file

Added "tiprack-1000ul-H.json" -- please check that JSON is valid and add to master container file

Coverage remained the same at 94.791% when pulling 920556138f23018646774fee2d94db72b77615cc on tiprack-1000ul-H-container into c8c8d054bbdd6e18324eec6b8b41009a9ec2266c on master.

I just added this new container to a separate PR, so closing this one


[edn/dv] add CSRNG command item to EDN DV env

Description
During DV of the EDN block different commands are passed to the EDN via the TLUL interface. These commands sometimes need to be randomized to different degrees and with various constraints.
For this the CSRNG command item would come in handy. We should replace the current variables making up the commands with an object of the csrng_item class. and utilize it in the whole test environment.
The csrng_item class can be found under hw/dv/csrng_agent/csrng_item.sv.

I'm not so sure anymore whether I like the idea of using the CSRNG cmd item. The cmd item has random distributions for the different fields that fit the requirements of the CSRNG tests. However, I'm not sure if there is a one to one overlap for those random distributions between EDN and CSRNG. An Idea would be to add functions that prepare the item for different use cases. We could, for example, add a ranomize_boot_ins() function, where the acmd field is set to INS, clen is set to 0 and the glen and  fips0 are randomized. If we add a function for each command type eg. boot_ins, boot_gen, auto_gen and auto_res, this could be an improvement. Otherwise I'm not sure if this is an improvement.

We've just discussed this in person and I agree that there is probably little to be gained from using the csrng_item for EDN DV. In my view, this can be closed.

Thanks @vogelpi. I will close this issue now.


Test case illustrating the issue with cartesian product move in vehicle routing

In reference to the discussion on Stackoverflow, I created this PR with a test case that shows the problem with cartesianProductMoveSelector.

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

ok to test.
Thanks for reporting. Due to a conference, I won't be able to merge next week, but I 'll leave it open for the week after.

Reproduced locally with this code. Looking into it tomorrow.

Before the move happens, these are the states of the moves:
CompositeMove:
    firstMove: [Customer-2, Customer-7, Customer-8] {Vehicle-4 -> Customer-22}
    secondMove: [Customer-2] {Vehicle-4 -> Customer-33}
Undo CompositeMove:
    firstMove: [Customer-2] {Vehicle-4 -> Vehicle-4}
    secondMove: [Customer-2, Customer-7, Customer-8] {Vehicle-4 -> Vehicle-4}

Start state:
V0 - ... - C11 - C33 - C26
V1 - C22 - C13 - ...
V4 - C2 - C7 - C8 - C21 - ...

Start state (first move entities annotated):
V0 - ... - C11 - C33 - C26
V1 - C22 - C13 - ...
V4 - [C2 - C7 - C8] - C21 - ...

Middle state (first move entities annotated):
V0 - ... - C11 - C33 - C26
V1 - C22 - [C2 - C7 - C8] - C13 - ...
V4 - C21 - ...

Middle state (second move entities annotated):
V0 - ... - C11 - C33 - C26
V1 - C22 - [C2] - C7 - C8 - C13 - ...
V4 - C21 - ...

End state (second move entities annotated):
V0 - ... - C11 - C33 - [C2] - C26
V1 - C22 - C7 - C8 - C13 - ...
V4 - C21 - ...

End state
V0 - ... - C11 - C33 - [C2] - C26
V1 - C22 - C7 - C8 - C13 - ...
V4 - C21 - ...

The undo second move is wrong basically - but without doing the first move, it's impossible to predict the undo move of the second move...

Workaround: add a moveFilter to filter out CompositeMove which a pair of moves that have an entity in common in Move.getPlanningEntities()

Thanks for reporting. Based on this PR I've managed to extract an isolated test case:
http://github.com/droolsjbpm/optaplanner/commit/8c3769d37
and created this jira:
https://issues.jboss.org/browse/PLANNER-611
I probably won't fix it immediately - so far the only fix I can think of has a major API impact on the Move interface - but I 've added it to my 7.0 API impact list.


Add support for graded color support detection

Like with https://github.com/chalk/supports-color/releases/tag/3.0.0
What's the best way to implement this in the CLI? Use different error codes? Output? Both?
// @Qix-

Hmm, tricky. Error codes would be less than ideal; 0 means OK, and I don't think breaking that pattern is safe.
Output would probably be ideal; 0 (with error code <>0), and then 1-3 for specific level support.

How about level-specifying flags? By default, you're asking if it supports any color.
supports-color with a 0 exit code means supports any color
supports-color --256 with a 0 exit code means supports 256 ansi color codes
supports-color --true with a 0 exit code means supports true-color

^ this. :+1:

:+1: But flags should be consistent with the level names we use in the API.

@sindresorhus you can't - not directly, at least. If we have the same arguments as what supports-color looks for, then you'll always return 0.

@sindresorhus poke close


Question: in which file are all passives listed?

I'd like to help out and fix all the issues with incorrect phrasing of some mods, that don't allow PoB to load them up (red text).

@Openarl sorry for the @, but I think you could help. :)

Hi, I'm not extremely familiar with the codebase, but I think you might be looking for Modules/ModParser-3_0.lua

@Olxinos thanks, i'll have a look.

Found it, but in ModCache.lua :)


The website does not show saved data for email and name input fields

[ ] The input fields should all show the saved messages according to requirements. But the name and email input fields do not show the stored data. So, please use the right function to retrieve the stored data for name and input fields as well.he input fields should all show the saved messages according to requirements. But the name and email input fields do not show the stored data. So, please use the right function to retrieve the stored data for name and input fields as well.

[ ] The input fields should all show the saved messages according to requirements. But the name and email input fields do not show the stored data. So, please use the right function to retrieve the stored data for name and input fields as well.he input fields should all show the saved messages according to requirements. But the name and email input fields do not show the stored data. So, please use the right function to retrieve the stored data for name and input fields as well.

Thank you for your constrictive suggestion.


[ALLUXIO-1798] Add license header to files in core/server/src/main/we…

Add license header to jsp files in core/server/src/main/webapp and core/server/src/main/webapp/worker

Can one of the admins verify this patch?

Hi, I am a new contributor. Cheng Chang created this task.

Thanks for submitting a pull request to Alluxio!
We found your commits on GitHub aren't linked to a valid Github account yet (see your commits at https://github.com/amplab/tachyon/pull/2867/commits) where the icon on the left is a gray cat rather than your profile picture. For us to properly credit your contributions, could you please set up your Github account by following the Github instructions here

Thanks for your reply and instruction! It seems that I cannot change the the Github's account for this PR. I will close this one and pull again.


Wishlist: netlist on all layers available please, for awesome visualisation!

I have been using this tool with huge gratitude for a year or so now as I assemble prototypes. However, I just stumbled on the netlist export and view options and this would make a killer tool for communicating to people who don't have EDA software installed / on their phone/tablet(!) about where signals run.
Is there any chance you could add the option to:

export all copper layer traces
display all copper layer traces on the front/back view simultaneously for the selected net
perhaps even show different layer traces with different colours to highlight where they have changed layer in the view requested in the bullet point above

If you could do the first two of the above, that would make it a kick-ass portable visualiser for designs. Thanks for your amazing work.

A number of web viewers for kicad files exist that do what you want. For example https://eyrie.io/
I don't have plans to have more copper layers displayed as it doesn't help with the main use case of this tool: assembly help.

Fully understand that stance and thank you for pointing me to an
alternative. If you ever change your mind, please voice it loudly as I'll
be jumping to update the plugin!
On Wed, 12 Oct 2022 at 13:32, qu1ck @.***> wrote:

A number of web viewers for kicad files exist that do what you want. For
example https://eyrie.io/
I don't have plans to have more copper layers displayed as it doesn't help
with the main use case of this tool: assembly help.
—
Reply to this email directly, view it on GitHub
https://github.com/openscopeproject/InteractiveHtmlBom/issues/331#issuecomment-1276087712,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AU2SFZVZEM5S4CV2LKA5AP3WC2VXRANCNFSM6AAAAAARDE2E3Y
.
You are receiving this because you authored the thread.Message ID:
@.***>


Update functions-infrastructure-as-code.md

Updated sample ARM template examples and recommended settings for function app.
Created separate tabs for Linux and Windows to avoid confusion.

@patelchandni : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"

@patelchandni : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@patelchandni : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@patelchandni : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@patelchandni : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@patelchandni : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@patelchandni : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@patelchandni : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@patelchandni : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@patelchandni : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@patelchandni : Thanks for your contribution! The author(s) have been notified to review your proposed change.

These commits are now in https://github.com/MicrosoftDocs/azure-docs-pr/pull/187571 #please-close


Landscape pages are downloaded as portrait

When hitting preview, the preview looks good as landscape, but when downloading the PDF, it gets generated in portrait with the page cut off

please fix it, upvoting, thanks.

Hey there! I had the same issue but hopefully I fixed it. Please check the PR above if you can and tell us if it worked :)


CKEdtior renders with empty content although it exists in the props

I have a React\Flux app. When entering the parent component of the CKEditor, I'm fetching data from the server, so in the initial loading, the 'content' prop of the CKEditor is empty, and after a few moments (when the fetching is done) the CKEditor component receives the content (props.content), but it doesn't always show it.
It actually depends on the loading of the parent component, when the user refreshes the page then everything works good, but if the user navigates from another component (different route) then the props.content in the CKEditor contains the content, but nothing is being shown in the CKEditor text box.
(Just to make it clear - in both cases the props.content of the CKEditor (eventually) contains the real content, but only in one case it shows it (meaning, working properly)).
Could you please assist?
Thanks,

Hi, This must be happening because your CKEditor instance was rendered before there was data in the content prop. To fix this, you must only render your CKEditor instance after your data is fetched. So you can add a check in your code like this -
if(props.content == null){
    return null;
}else{
    return <Ckeditor ...>
}

The above check will render CKeditor once the props.content is populated with your data.
In case you need to forcefully update the content of already rendered CKEditor after the data is retrieved from server then refer this issue - #13 . Here I have explained how to update content in CKEditor.

#13 it solved it. Thanks!

I have a better fix for this that allows the editor to be constructed and receive updates
class Wysiwyg extends React.Component { 	constructor() { 		super(); 		this.editor = null; 	} 	componentDidUpdate() { 		if (this.editor) { 			this.editor.setData(this.props.value); 		} 	} 	render() { 		const editorValue = this.props.value || ''; 		return ( 			<div className='wysiwyg-wrapper'> 				<CKEditor 					content={editorValue} 					events={{ 						"change": (evt) => { 							const newContent = evt.editor.getData(); 							this.props.onChange(newContent); 						}, 						"loaded": (evt) => { 							this.editor = evt.editor; 						} 					}} 				/> 			</div> 		); 	} }


Wrong Return URL after Payment Due to this Plugin

I am using this plugin together with the "PostFinance E-Payment Gateway for WooCommerce" by mame dev. After finalizing a payment I got to see the "Oops, this page cannot be found" every time. I went through lengthy trouble shooting sessions with the developer mame dev until he found out that it is actually this "Hyyan WooCommerce Polylang Integration" plugin causing the return URL to be:
http://www.[domain].com/en/checkout//1769/order-received/1769/?key=wc_order_56212c7e09a10&v=d1a0eba20b32
instead of
http://www.[domain].com/en/checkout/order-received/1769/?key=wc_order_56212c7e09a10&v=d1a0eba20b32
The PostFinance plugin gets its return URL through the WooCommerce function "get_return_url()", which is apparently modified by this plugin in some mysterious way.
Can you please fix this bug so that this WooCommerce Polylang Integration plugin works seamlessly with all payment gateways? Thanks very much!

Hey @jannisf ,
It's probably too late for you but for it may be useful for the others.
After a long diagnostic, I fixed this issue by commenting line 250 ($value) in blob/master/src/Hyyan/WPI/Endpoints.php :
$url = trailingslashit($permalink)
          . $endpoint
          . '/'
          //. $value
          . $query_string;

Now it generates the correct url :smile:

I made much more complicated solution because I couldn't find the exact cause. I made a pull request and my solution is working as well https://github.com/hyyan/woo-poly-integration/pull/25

Fixed in version 0.27


chore: additional checks before adding tapInternalKey

Try out this version of Leather — Extension build, Test report

Ref #4125
Not entirely sure if this is appropriate logic, but if I understand correctly, the additional check ensures TR script spends don't automatically have the tapInternalKey added, invalidating the tx.
We should sunset auto-adding of tapInternalKey as it's a bit of a naive solution I think. Instead, developers should be taught to add it rather than relying on some implicit tx mutating behaviour.
cc/ @gregdhill

@gregdhill to test and confirm if fixed

Just tested and now works for script-path spends @kyranjamie :tada:

@kyranjamie this is yet to be released correct?

@danielsimao this will be included in our next release


Create Resurses whit Azure

History Notes:
(Fill in the following template if multiple notes are needed, otherwise PR title will be used for history note.)
[Component Name 1] (BREAKING CHANGE:) (az command:) make some customer-facing change.
[Component Name 2] (BREAKING CHANGE:) (az command:) make some customer-facing change.

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

hi @knbz is this a PR working in progress? pls mark title [WIP] then. thanks.


ci: add persist-credentials into false

:tada: This PR is included in version 1.3.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add CI pipeline

Make sure the Test library is either in the main Project.toml in the extras section or in the tests Project.toml.

Check the secrets and the environments, and replace the values set in env as apikey and secret.


Please bump version number and npm publish last version

Please don't take this the wrong way. I write this as an issue but I'm not pushing you :) Thx!

no problem, I can just not do it tonight ;)

Of course. No problem! Thx
El 23/01/2015 15:32, "Julien Valéry"<EMAIL_ADDRESS>escribió:

no problem, I can just not do it tonight ;)
—
Reply to this email directly or view it on GitHub
https://github.com/darul75/express-session-json/issues/11#issuecomment-71240479
.


Update native agents

:tada: This PR is included in version 2.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Porting the app to Windows

If we're able to run the app on Windows, we'll be able to use any version of Android on an emulator to play the game.
Due to the way the app is written, we can pretty much share all the code which is not in the Android project.
I already am experienced with writing Windows apps, so I hope this won't be much difficult.
But, don't hope too much on this or expect it to happen soon.
I'll only start working on this once the Android version becomes more stable.

Closing in favour of #80.
This solution would require the emulator to be always on screen which isn't very convenient for people without multiple screens.
We're instead planning on adding root support.
FGO JP should work with root by default.
You can use MagiskHide with FGO NA till the engine update arrives.

This solution would require the emulator to be always on screen which isn't very convenient for people without multiple screens.
To be honest as a emu user i don't mind that, if you don't have 12-16gb ram then the emu is mostly likely going to take most of you're ram, leaving you with little space of other programs in the first place.
I can just leave it running when i'm resting, outside or just doing others things. Come on man, my enhancement request was closed for this.

Look into #80, it's much better, trust me. You can minimize the Emulator that way.


Review milestone 4

Addresses #100
I reviewed our repository for our work this week and here are some minor fixes. Please review and merge.

Graet


App crash - "Value does not fall within the expected range."

I'm having this random exception which maskes my app crash

Value does not fall within the expected range.
index and count exceed length of list

at Quobject.Collections.Immutable.ImmutableList1.CheckRange(Int32 idx, Int32 count) at Quobject.Collections.Immutable.ImmutableList1.RemoveRange(Int32 index, Int32 count)
at Quobject.EngineIoClientDotNet.Client.Socket.OnDrain()
at Quobject.EngineIoClientDotNet.Client.Socket.EventDrainListener.Quobject.EngineIoClientDotNet.ComponentEmitter.IListener.Call(Object[] args)
at Quobject.EngineIoClientDotNet.ComponentEmitter.Emitter.Emit(String eventString, Object[] args)
at Quobject.EngineIoClientDotNet.Client.Transports.WebSocket.b__0()
at Quobject.EngineIoClientDotNet.Thread.EasyTimer.<>c__DisplayClass1.b__0()
at System.Runtime.CompilerServices.TaskAwaiter.<>c__DisplayClass0.b__1()
at System.Runtime.CompilerServices.AsyncMethodBuilderCore.ContinuationWrapper.Invoke()
at System.Threading.Tasks.SynchronizationContextAwaitTaskContinuation.<>c__DisplayClass0.<_cctor>b__1(Object state)
at System.Threading.WinRTSynchronizationContext.Invoker.InvokeCore()

What version of EnginIoClientDotNet are you using?
There was a bug fix in 0.9.14 https://github.com/Quobject/SocketIoClientDotNet/issues/18 that should prevent this exception.

We are currently using version 0.9.17

Fixed in 0.9.18.


Clarify, update Learn ES2015 page.

It's standardized now! I think this is a good first step.
(Bad storm here, trying to make sure I can make the PR while there still is power...)

@thejameskyle This better?


Make a log file after force stop

When I run pybot, expect Report and Log after end of the test.
But if it stopped in running unfortunately, I couldn't get anything. This make me harder to get why the test is not run well or not end. ( especially when include thread logic )
I want get a log file after stopped a execution.

If you press Ctrl-C once or send INT or TERM signal, Robot exists gracefully and generates logs and reports. If you stop it otherwise, it will exit immediately and won't finish output.xml nor spend time generating logs/reports. Could you clarify how would you like this to be enhanced? More information in the User Guide:
http://robotframework.org/robotframework/latest/RobotFrameworkUserGuide.html#stopping-test-execution-gracefully
Notice also that broken output.xml can be fixed with separate fixml tool and logs/reports generated afterwards with Rebot.

I have a keyword what waiting for a specific log as a thread.
It is not end until log found. Stop execution gracefully it impossible.
( That's a hang like a race condition. )
But I want know what happen until that error. Is it possible?

If you forcefully stop a process, there's no way the process could still do something like generate logs and reports. You need to use some other mechanism for communication. This issue tracker is not the right place to discuss about alternatives.

i met the same problem


ACTIVESCRIPTING is removed in 2016, should reflect that

Documentation for sp_add_job (https://docs.microsoft.com/en-us/sql/relational-databases/system-stored-procedures/sp-add-jobstep-transact-sql?view=sql-server-2017) should be fixed to reflect the fact that the ACTIVESCRIPTING option was actually removed in SQL Server 2016.
Same for the how-to article: https://docs.microsoft.com/en-us/sql/ssms/agent/create-an-activex-script-job-step?view=sql-server-2017.

@msebolt -- please look into this issue 2407.  Minor FYI, this article is owned by SteveStein.  However, this item might be resolvable in the triage stage.

@slepmog Thank for the feedback!
The changes have been made and merged.


Implement View Pop Out in Error Suppression

As an ECMPS admin, I want to see the view pop out in the Error Suppression Screen so that I can support program goals.
Given an ECMPS admin user logs in
When they navigate to the Error Suppression screen table
Then there will see a view submission button

Given an ECMPS admin user navigates to the Error Suppression screen table
When they click on the view button
Then the open pop-out will open and will have all fields as shown in the wireframe below
https://xd.adobe.com/view/96db9ac9-f9a6-4427-9c8b-f057858d6776-c388/screen/b28c5de7-ef05-469a-a925-360317e84f67/

@mosesdeeCVP

Private Zenhub Image

View Pop Out in Error Suppression is updated


[Frontport main] Remove some styling overrides (#594)

Description
Frontporting #594 to main
Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.
[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ohltyler Could you help fix the failing tests?

Looks to be entirely unrelated with these changes, but I'll take a look

@kaituo I've updated the failing unit tests.


units: Add must_use

Enable return_self_must_use and also run the linter locally with must_use_candidate.
Add must_use attribute as required excluding obvious functions (conversion, getters, etc).
Done as part of https://github.com/rust-bitcoin/rust-bitcoin/issues/3185

This is the first two patches out of #3704 with review suggestions seen to.

In 5d53302eedb1b2f79ac3d97ee927eb9d42c1af94:
trailing whitespace in units/src/locktime/relative.rs
Otherwise ACK.

Bizarre, git log --patch is showing trailing whitespace still in units::locktime::relative on the value function but my editor does not. Am I awake or asleep still?
I went to investigate because the git hooks don't find it either. Too weird.

master is broken right now, fixed in #3721.


feature: Add table or modify existing table

Hi!
Thanks for your work on this project. I'm hoping to reopen a feature request that you guys started a few years ago.
Link

a) Have a table placeholder shape in my layout, and stuff a table into it - this doesn't seem to be possible as I can't set rows,cols etc on an existing table shape
or b) Create a new table shape using the height,width,left,top etc from a placeholder shape in the layout. This seems to fail as the actual shape in the slide ends up with height,width,top,left all set to 0. The cloned placeholder shape seems to not copy these values into the local shape?

Additionally, would it be possible to modify the dimensions of an existing table (i.e. rows/columns)?
Wondering if there was any work on this that wasn't merged or if a solution could be cobbled together.
Thanks in advance,
Mitch

Check out TablePlaceholder.insert_table():
https://python-pptx.readthedocs.io/en/latest/api/placeholders.html#pptx.shapes.placeholder.TablePlaceholder.insert_table
The inserting row/column feature is pending, but described in another open issue.


Make project reuse compliant

What this PR does / why we need it:
Make project reuse compliant
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:

/lgtm

@RaphaelVogel can you take another look, I had to fix third-party files copied in this repo with af31931

Should we also add the "Modifications Copyright" for files under pkg/admission/?

And also maybe we should add the "Modification Copyright" for the following file pkg/lakom/utils/cosign_utils.go

For completeness the Comment field can include the HEAD commit from which the file was copied. That is just a suggestion.


Plugin crashes client when switching to profile with it on while logging in

If you load default profile without the plugin and then login to a leagues world and the auto profile switch triggers this plugin to load, it crashes/prevents the client from working.

Is the crash/prevention permanent? I'm looking at this now

I don't know but it's generating a lot of traffic in the runelite discord and the fix is to uninstall it while in safe mode.

So this is still happening, "Fat Rat" is a profile without the plugin and is set to a non-league account. LeaguesV is a profile for leagues that has the plugin installed. Seems to crash here downloading/enabling the plugin upon first login. Just wanted to post here so you know it might not be fixed yet

 So this is still happening, "Fat Rat" is a profile without the plugin and is set to a non-league account. LeaguesV is a profile for leagues that has the plugin installed. Seems to crash here downloading/enabling the plugin upon first login. Just wanted to post here so you know it might not be fixed yet

Can you show that this is the plugin that is causing the issue? The fix was to have the plugin do a check to see if the plugin exists on a profile switch and if it does, do stuff and if not then shut down immediately/not do anything, the bug previously was hanging on profile switch to a non plugin profile gbecause it waited on something that got terminated or something.


Extract HttpUserAgent class from HttpSM

This extracts a new class with 3 fields (entry, raw_buffer_reader, and txn). It doesn't have much responsibility yet. But it does provide a starting point for moving some behavior out of the state machine.

[approve ci]

My objective is to move some of the logic for response headers into this new class. For example, HttpSM::setup_push_read_response_header() can be moved entirely or in part into this new class.

Hmm, the goal is still unclear to me. If it's going to be like we can get anything about a user agent from HttpUserAgent, and anything about a server from HttpServer that kinda make sense. But we already have client_info and server_info in HttpTransact::State. What would be the difference? And why don't you move other variables that are related to client (e.g. client_request_hdr_bytes, client_tcp_reused, client_protocol`, etc) into the class?

I wanted to split up the class a bit based on the single responsibility principle to make it more manageable. I did not have a long-term vision of how the refactoring would continue, but I'd like to try moving the other client fields over (in this PR) like you suggested, and splitting out HttpServer in a separate one.
I'm pretty new to the codebase and it's not very clear to me yet which fields belong together. I thought client and user agent were somehow different concepts in the codebase, because they are named differently.

The goal is to encapsulate these fields such that the state machine doesn't need to access this data at all. If it has less data it has to manage directly it will be a lot easier to follow the logic. I want to move operations on client and server data out of the state machine, so that the state machine focuses on changing between states correctly and delegates the details of changing the state to those new classes.

Thanks for the clarification.

I wanted to split up the class a bit based on the single responsibility principle to make it more manageable.

Sounds reasonable. You've already answered my question on the other comment but I was not sure what the responsibility of the new class where you have only one for user agent side.

I'm pretty new to the codebase and it's not very clear to me yet which fields belong together. I thought client and user agent were somehow different concepts in the codebase, because they are named differently.

I'd say nobody fully understand the concepts 🙂 The two terms might have been used for a client on HTTP layer and a client on TCP layer, but this is just my guess.

The goal is to encapsulate these fields such that the state machine doesn't need to access this data at all. If it has less data it has to manage directly it will be a lot easier to follow the logic.

Sounds great. Let's make it happen.

Rebased on master.

Rebased on master.

[approve ci autest]

The autest failure on this one indicates a real problem. I've been working on it but debugging the state machine without unit tests is a relatively large time sink.

I found the bug. I missed a single !, and I think I spent as much time finding that single missing ! as I spent making this entire PR. I'm going to add a unit test that covers that case, but I'm encountering a lot of segfaults in the test setup.

Rebased on master. Some unfinished changes also got pushed by mistake.

Rebased on master to resolve merge conflict.

[approve ci autest]

There isn't supposed to be any logic change. The AuTests passing gives me a little confidence that the behavior is preserved, and I am planning to add some more unit tests in a followup PR.


Fix animation editor button callback parameter bug

It just fix one error when opening window to choose animation clip to animation library.

Looks good! Could you squash the commits? See PR workflow for instructions.

Looks good! Could you squash the commits? See PR workflow for instructions.

updated

You seem to have merged instead of force pushing after your rebase, so there are now 4 commits instead of 1.

I will merge it into one commit. Sorry for that.

For the record, this was superseded by #62151.


Disable dangling-reference and overloaded-virtual warnings when using gcc 13

@baldersheim : please review

I assume we must to a code cleanup before going to gcc 13.


Why does the llama-13b model take up 72G after loading into GPU memory

I really hope to get your reply. thank you

Please share more details. Where do you encounter your issue (converting model, building engine or runtime) and what script do you use?

Close this bug because the issue is inactivated. Feel free to ask here if you still have question/issue, we will reopen the issue.


Config & Contract files are not copied when running node ace configure

Description
Bug: Template stripe.ts files are not copied when running node ace configure @mezielabs/adonis-stripe
Package version
adonis-stripe 1.0.4
Error Message & Stack Trace
Error stack trace:
node ace configure @mezielabs/adonis-stripe
...
UnhandledPromiseRejectionWarning: Error: Template file not found<EMAIL_ADDRESS>
Actual paths: ../templates/config/stripe.txt  & ../templates/contracts/stripe.txt
Relevant Information
I think you might've forgot to update the file paths in the command script. Anyway, I've resolved the issue by manually copy-pasting the two files into my project. And now it works fine! Thank you for the package

This has been fixed in the latest release.


release .apk on github repo

please release .apk on github repo
some testing devices that are inconvenient to log in play store
thanks

It needs playstore to check that's why i didn't put the apk here

it needs playstore to check.
but on testing devices, it does not need to log in the playstore

and this apk is a splited apk on playstore, which is difficult to install manually and easily

I put it on aptoide and apkpure (officially)
https://play-integrity-api-checker.en.aptoide.com/app
https://apkpure.com/play-integrity-api-checker/gr.nikolasspyr.integritycheck
Also on:
AT&T GamesHub
Beam Apps
Blu US GamesHub
Cricket GamesHub
HONOR App Market
Huawei Petal Search
JioStore
One Store
Oomph Indonesia
OPPO App Market
PWG
RuStore
Softonic
Tracfone GamesHub
UScellular GamesHub
Verizon GamesHub
Xiaomi GetApps

thanks.
can also put on github via its release featrue


[AutoDiff] Update @differentiable attribute, refactor lookupFuncDecl method.

Add adjoint access level check to @differentiable attribute.

If the original function is "exported" (public or @_versioned), then the
adjoint must also be exported.

Generalize lookupFuncDecl function and add it as a method to TypeChecker
so that it can be used for type-checking #adjoint expression in a later
commit.

@rxwei
Could you please re-review? I made some slightly non-trivial changes in https://github.com/apple/swift/pull/17246/commits/47f49f6da1880a587e25481d8d9aa48403c4b1e4.

LGTM

Good idea about renaming @_versioned to @usableFromInline, done.

@swift-ci Please test tensorflow

@swift-ci Please test tensorflow

@swift-ci Please test tensorflow


uncaught exception 'CALayerInvalidGeometry', 'CALayer position contains NaN: [nan inf]

Not sure if this could be a specific error to my app but I'm getting this full error message
"Terminating app due to uncaught exception 'CALayerInvalidGeometry', reason: 'CALayer position contains NaN: [nan inf]"
I am using the modal transition to a uitableview and adding uitableview to     [self.animator setContentScrollView:detailViewController.tableView];
If there is any clue on how i might be able to change this i could push it as a fix. but if you think its a simple thing to change it would really help my app. I plan to release it soon!
Great job on this wonderful control!

Hi @WizKIDz ,
I think it should be some value that pass into CGRectMake is not valid. There is someone send email to me about this also, I will look into it.

Got same crash,
http://i58.tinypic.com/2mhcth4.png

Hi @surkis @WizKIDz ,
I cannot reproduce the issue, could you build simple project that simulate your app structure for me. :(

I just add the code that prevent crash from unexpected value like Inf or Nan. If you guys still see the crash happen, please re-open the issue.


[GSSOC 23] Script Addition

Aim

A  utility for searching strings hardcoded by developers in programs. It uses a modular tokenizer that can handle comments, any number of backslashes & nearly any syntax you throw at it.

Details
it is designed to process any syntax and following languages are officially supported:
ada, applescript, c, c#, c++, coldfusion, golang, haskell, html, java, javascript,
jsp, lua, pascal, perl, php, powershell, python, ruby, scala, sql, swift, xml

Do I want to work on this:

[x]  Yes
[ ] No

@avinashkranjan pls assign this issue  to me i am very happy contribute

Go Ahead @slayerrr12


Delegate Methods

Hello
What about developing also delegate methods?
Like those ones:
- (void)atAppUpdaterDidShowUpdateDialog
- (void)atAppUpdaterUserDidLaunchAppStore
- (void)atAppUpdaterUserDidSkipVersion
- (void)atAppUpdaterUserDidCancel

Sounds like a great idea to me.

I agree :smile: Will do it asap, thanks!

Hi, I do not understand. Are you working on that? How long does it take you, at about?
Thank you.

Il giorno 21/nov/2015, alle ore 14:17, Jean-Pierre Fourie<EMAIL_ADDRESS>ha scritto:
I agree  Will do it asap, thanks!
—
Reply to this email directly or view it on GitHub https://github.com/apptality/ATAppUpdater/issues/11#issuecomment-158639697.

I'm currently busy with work stuff, will do it when I can.

I'd much prefer this moved to using UIAlertController and expose UIAlertAction.  I'll create a PR for this since I'm needing it for a local project.

Sorry for long wait guys, been super busy with full-time work and other personal projects. The above is fixed with commit dc16fe76ba81be6372323c7b24625559c6d3f9b3
Thanks for reporting issues!


Improve hell threads handling and fix mute

Please improve notifications to not include notifications from "hell threads".  Some clients, like Yana, show a notification for every reaction / reply in a thread you where mentioned in.
Solution I'd like is you just show reaction or reply to my posts directly - So I.E take this small thread example:
A <- my note
-- B
---- C
-- D
You should show a notification for B and D, but not C. This will then keep notifications manageable, even if conversation in the thread continues forever.
On a related note, I also can't mute people from Yana. Or at least notifications from them are still displayed.

What about situation:
A
-- B <- my note
---- C
-- D
should we get notifications for C?
I think so, but might be difficult to implement....since when getting C we don't know who's the publisher of note B (parent to C)....

I think so too, not sure what's best to implement there

Added checking if notification events include a e tag with marker reply which references any of user's cached events.
It's not perfect, since there might not be all user events in cache, but it helps a bit.
Will think of a better way for 0.16.0 milestone.


Adding support for scoring strategy

We need to have control from the operator over the different scoring strategies we're offering via the scheduler plugin.
Therefore, we are introducing a new ScoringStrategy API field in NUMAResourcesScheduler.
This field specifies the desired scoring strategy and passes it to the scheduler.
https://issues.redhat.com/browse/CNF-5871

@ffromani changed the code according to your suggestions.


feat: filter capabilities depending on selected runtime

Closes #1224

This PR was deployed with mocked data in the following URLs for your appreciation:

Frontend: https://fabric8-launcher-frontend-pr-1252-app.surge.sh
Welcome App: https://fabric8-launcher-frontend-pr-1252-welcome-app.surge.sh
Storybook: https://fabric8-launcher-frontend-pr-1252-storybook.surge.sh


How do I swipe away the last item in the panCardView

panCardView is preventing me from clearing my Observable collection by swiping it out of the view?
How do I swipe away the last item in panCardView? Is there some sort of a flag?

Hi @whiterabbitj you can add an empty view as the last item of your ItemsSource (use DataTemplateSelector for this).
And then check ItemAppeared event or ItemAppearedCommand, if your item is visible then perform clearing your collection


Editor, function folding, reducing space used on screen

From @GoogleCodeExporter on May 31, 2015 11:25
1. In the editor since there is little space, folding methods/functions
out of the way would be enhance the screen use especially for us on screen
keyboard users.

2. Some sort of variable / method word folding to reduce the characters
along a line?

3. Page down would also be nice for moving around the script

They are in here because I see them as really for the medium to long term
but worth mentioning I think.
I love the freedom of python on my phone.

Original issue reported on code.google.com by Panquisitive on 16 Mar 2010 at 6:00
Copied from original issue: damonkohler/android-scripting#250

From @GoogleCodeExporter on May 31, 2015 11:25
Original comment by<EMAIL_ADDRESS>on 31 Mar 2010 at 10:23


0.9.5 EGUI Custom font example error

I was about to publish 0.9.5 and checking the examples I saw that the egui custom font doesn't work. I need to take a look but I don't have time right now, probably until next week, so I am adding this issue to not forget it.

This is failing for me even using the main branch 0.9.4. And it seems that the online example doesn't work either... so, this is not a blocker because is already on prod? Must be fixed of course but I am inclined to release 0.9.5 and handle this on 0.9.6 or 0.10.


Catch OSError when rmtree, to avoid memory leak

We are seeing some error like:
==== detail start, at 20211220.032154.893 ====
Traceback (most recent call last):
File "/data/projects/fate/eggroll/python/eggroll/core/utils.py", line 146, in wrapper
return func(*args, **kw)
File "/data/projects/fate/eggroll/python/eggroll/roll_pair/egg_pair.py", line 247, in run_task
shutil.rmtree(path)
File "/opt/app-root/lib64/python3.6/shutil.py", line 486, in rmtree
_rmtree_safe_fd(fd, path, onerror)
File "/opt/app-root/lib64/python3.6/shutil.py", line 424, in _rmtree_safe_fd
_rmtree_safe_fd(dirfd, fullname, onerror)
File "/opt/app-root/lib64/python3.6/shutil.py", line 428, in _rmtree_safe_fd
onerror(os.rmdir, fullname, sys.exc_info())
File "/opt/app-root/lib64/python3.6/shutil.py", line 426, in _rmtree_safe_fd
os.rmdir(name, dir_fd=topfd)
OSError: [Errno 39] Directory not empty: '0'
this lead to memory leak of our container, since each clean job cannot finish in eggpair, and those process just keep retrying.
So I just catch the OSError and log it, but don't fail on error.
Fixes  ISSUE#xxx
Changes:

ping?

@guojiex Thank you for your Pull Request and the detailed error description!
I apologize for the delayed response. Your fix indeed makes sense. From the stack trace you provided, we can see that shutil.rmtree may fail due to the directory not being empty in certain scenarios. In such cases, rather than letting the task fail outright, it's more reasonable to catch the OSError and log it without failing on the error.
Your approach can help prevent memory leaks in our container, and it's vital for ensuring the stability of our system.
Before we can merge your PR, I must ask you to fix the DCO (Developer Certificate of Origin). This is required by the community contribution guidelines for Linux Foundation projects. You can fix the DCO by running the following commands:
git rebase HEAD~5 --signoff
git push --force-with-lease origin patch-1

Once you have completed these steps, please notify us in this PR, and we will review and merge it as soon as possible.
Thanks again for your contribution!


Number of notifications

Hello,
I would like to know if it is normal to see 2 notifications of the same application regarding SDL.
I have installed the hello SDL application in your documentation (https://smartdevicelink.com/en/guides/android/getting-started/hello-sdl-android/) and when the app is connected to the car, 2 notifications are visible. Althouth, the FordPass app only shows one notification (see screenshot below)
OS & Version Information

Android Version: 9

This is normal. They are two different notifications. One for the transport connection that works for all apps. The other is for the specific apps and their services.

Hello @joeygrover,
In that case, how can Ford bypass this situation by having only one notification?
thanks,
Diogo

Per the previous comment, it is using the transport service that the other app has started. Only one transport service is necessary for all apps.

But if I uninstall the demo application, and only stay with the FordPass app I only see one notification.

Their implementation is likely incorrect then. There is no way to properly get around the transport service notification.


Users May Choose Interface Language option not working

Description of problem
Checking this box should allow site users to select a different language for the interface than the one used for content. This option does not work.
Description of solution
When you switch the site Language from English to secondary language (German, for me), by having the Users May Choose Interface Language option Enabled, a user's Preferred Locale (default English) should override the site language and show the Persona Bar in English, but the site content in the set language.
Additional context
When you switch the site Language from English to secondary language (German, for me), by having the Users May Choose Interface Language option Enabled, a user's Preferred Locale (default English) should override the site language and show the Persona Bar in English, but the site content in the set language.
Screenshots
This is how it used to look in DNN's menu prior to version 9

The logical place is to put a similar dropdown in the Persona Bar

The menu would only show up when multiple languages are enabled.. possibly when content localization is enabled.. same logic as legacy. It should change language only for edit controls and person bar.
Affected version

[x] 9.1.1+

@dnnsoftware/tag we've had some discussion about this within ESW. This has apparently been removed with the event of Persona Bar. What is your opinion on bringing this feature back?

I agree it's an important feature, especially for admins working on ML sites with languages they don't understand. Yet I don't think putting it in the logo-menu would be the right place, as this feels more like a personal setting than a system-thing.
If I would design it, I would personally think it should be in a user-menu or something like that, because that's where I would look for it.

I am moving this issue to AdminExperience where it needs to be handled and closing #2321 since they explain the same problem but this one has a bit more comments.


Dpl 791 styling changes

ONT Run page reformatting

Create,reset,back buttons to display at top
Spacing between headers
Vertical align of instrument and state fields

Subtle border between Filter panel and table to give visual clarity in all pages with filter option

'Generate sampleshheet' changed to button with a download icon in ONTRunIndex and PacbioRunIndex

Added Download icon

Pool/new page styling changes for Pacbio and ONT

ONTFlowCell changes
-Change the tick colour in the TractionFieldError component to match the darker green colour in the Flowcell component

Change bootstrap colours to tailwind border-warning border-danger etc

Sorting button fix in Firefox

All working as expected. Just a couple of things:

I wonder if the download sample sheet button could be a different colour? It is currently the same as the edit button
On the pool new page there is a slight misalignment on the vertical for 1a and 1b

I think ONT run could do with a bit of a redesign but we agreed to roll that out into another story.

I have given a different colour to download initially, but with all that different colors on different buttons (Start etc) it looks like a rainbow effect with having too many colours  :) , that's why changed to this.  But, I will give it a go with another color  and see how it goes

All working as expected. Just a couple of things:

I wonder if the download sample sheet button could be a different colour? It is currently the same as the edit button
On the pool new page there is a slight misalignment on the vertical for 1a and 1b

I think ONT run could do with a bit of a redesign but we agreed to roll that out into another story.
Done

Is this color ok?

New story added for ONTFlowCell restyling
https://github.com/sanger/traction-ui/issues/1244


Export int64 sum as MetricDescriptor_INT64 to Stackdriver

Could you also update newTypedValue() (https://github.com/rakyll/opencensus-go/blob/817f33c09ad7f45e284d646a05a0bbe2c5c304d3/exporter/stackdriver/stats.go#L322)?
If the Measure is INT64, sum data should be wrapped to INT64 too.

@rakyll it might be helpful to update your commit message to mention the issue in question.


[Klima data] Fix for mobile menu

Description

Adds a mobile menu
Refactors layout components

Related Ticket
Resolves #1761
Resolves #1796
Changes

Before
After

img here
img here

Checklist

[X] I have run npm run build-all without errors
[X] I have formatted JS and TS files with npm run format-all

Hey there, a few issues:
Sometimes, but not always, clicking the first link in the menu leads to this:

Also, sometimes the link stops working. It only happens on the first link ("Overview"), and not every time, and I can't figure out why sometimes nothing happens and sometimes it throws the error message. Not sure how to reproduce this one consistently. Accessing the console on mobile browser apparently isn't so straight forward (need to hook the phone up to a PC/Mac). If you need the console printout, I'll look into this later/tomorrow (bit of a packed day for me).
Also, the "constantly redraw charts" bug is in this one. Not sure if by accident or by design because your fix hasn't been merged yet. If it's the latter, you can ignore this one.

Hey, the menu looks great but it doesn't match the designs: https://www.figma.com/file/mXI4SzNNmoefYnOdcbXZcO/Carbon-Dashboard?node-id=3086%3A10114&mode=dev
Are there other designs for the menu?

Hey there, a few issues:
Sometimes, but not always, clicking the first link in the menu leads to this:

Also, sometimes the link stops working. It only happens on the first link ("Overview"), and not every time, and I can't figure out why sometimes nothing happens and sometimes it throws the error message. Not sure how to reproduce this one consistently. Accessing the console on mobile browser apparently isn't so straight forward (need to hook the phone up to a PC/Mac). If you need the console printout, I'll look into this later/tomorrow (bit of a packed day for me).
Also, the "constantly redraw charts" bug is in this one. Not sure if by accident or by design because your fix hasn't been merged yet. If it's the latter, you can ignore this one.

I could reproduce it. Another tricky one I fear. On it.

@sprrwhwk @0xtapi The bug with the overview link not working properly was beyond tricky, I had to make heavier changes than I wanted. Let me know if you see anything weird.

 Menu opens at the bottom and there's a small transparent element on top of the menu. All other sites look good (and work) on all other browsers. Not really a show stopper, but maybe you can take a look again and see if there's a quick fix for this?


invalid option: - 'Rakefile'

Ruby 2.5.1
Rails 5.2.0
RuboCop 0.55.0

[denis@thinkpad portal]$ bundle exec rubocop
invalid option: - 'Rakefile'
/home/denis/.asdf/installs/ruby/2.5.1/lib/ruby/gems/2.5.0/gems/rubocop-0.55.0/lib/rubocop/options.rb:21:in `parse'
/home/denis/.asdf/installs/ruby/2.5.1/lib/ruby/gems/2.5.0/gems/rubocop-0.55.0/lib/rubocop/cli.rb:37:in `run'
/home/denis/.asdf/installs/ruby/2.5.1/lib/ruby/gems/2.5.0/gems/rubocop-0.55.0/bin/rubocop:13:in `block in <top (required)>'
/home/denis/.asdf/installs/ruby/2.5.1/lib/ruby/2.5.0/benchmark.rb:308:in `realtime'
/home/denis/.asdf/installs/ruby/2.5.1/lib/ruby/gems/2.5.0/gems/rubocop-0.55.0/bin/rubocop:12:in `<top (required)>'
/home/denis/.asdf/installs/ruby/2.5.1/bin/rubocop:23:in `load'
/home/denis/.asdf/installs/ruby/2.5.1/bin/rubocop:23:in `<top (required)>'
/home/denis/.asdf/installs/ruby/2.5.1/lib/ruby/gems/2.5.0/gems/bundler-1.16.1/lib/bundler/cli/exec.rb:75:in `load'
/home/denis/.asdf/installs/ruby/2.5.1/lib/ruby/gems/2.5.0/gems/bundler-1.16.1/lib/bundler/cli/exec.rb:75:in `kernel_load'
/home/denis/.asdf/installs/ruby/2.5.1/lib/ruby/gems/2.5.0/gems/bundler-1.16.1/lib/bundler/cli/exec.rb:28:in `run'
/home/denis/.asdf/installs/ruby/2.5.1/lib/ruby/gems/2.5.0/gems/bundler-1.16.1/lib/bundler/cli.rb:424:in `exec'
/home/denis/.asdf/installs/ruby/2.5.1/lib/ruby/gems/2.5.0/gems/bundler-1.16.1/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
/home/denis/.asdf/installs/ruby/2.5.1/lib/ruby/gems/2.5.0/gems/bundler-1.16.1/lib/bundler/vendor/thor/lib/thor/invocation.rb:126:in `invoke_command'

I can't duplicate this yet. What are the contents of your RUBOCOP_OPTS environment variable?

@mikegee .rubocop
What do you need to do to see RUBOCOP_OPTS?

What do you need to do to see RUBOCOP_OPTS?

echo $RUBOCOP_OPTS from your shell.

Was that really the content of a file called .rubocop? It looks a lot more like a .rubocop.yml.

@mikegee

Yes .rubocop.yml

@mikegee yes. .rubocop does not exist.

Welp, this makes no sense then. You reported a failure to handle a command line option of "Rakefile", but you are not passing that option in the three places Rubocop pulls from: .rubocop file, ENV['RUBOCOP_OPTS'], and the command line itself. 🤔


test case for projects

it will great if someone writes some test cases to check that all the projects are error free.

it's difficult to add test cases for each project we've done it manually,

Wait , I will try.

@okay


CHAOS-4162 ChaosHub changes

Introduction to ChaosHub page
Change chaosguard to ChaosGuard
Change chaos hub to ChaosHub
Change headings

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://65c5f71a82d16f85fd666ec0--harness-developer.netlify.app


Importing JosiahSiegel GitHub Actions into project

The goal is to import these GitHub Actions (remote repos) developed in Mr. Siegel GitHub personal account into the CDC ReportStream project as local actions.
├── azviz-action
├── action-connect-ovpn
├── checksum-validate-action
├── git-secrets
├── randomrepo
├── rapid-wsl
├── reliable-pull-request-action
├── remote-branch-action
├── runleaks
├── slack-boltjs-app
├── stackoverflow_in_pg
├── terraform-stats
├── terraform-templates
└── workflow-housekeeper

There are only 3 GitHub Actions to be imported:
JosiahSiegel/runleaks (scan_action_logs)
JosiahSiegel/terraform-stats (alert_terraform_changes, deploy_terraform)
JosiahSiegel/action-connect-ovpn (vpn-azure)
I will contact @JosiahSiegel directly and ask him about these GitHub Actions to know about the internal development milestones he has planned on these projects.
I strongly believe that this is something we should do asap so that we can have a better understanding on the maturity level these three projects have or if there is something else he has planned to release.
I will keep you all posted on this as conversation will progress.
Note: Importing these and replacing any references made in the code is something that should have no implications but I will let you know.

Based on @devopsmatt recommendation, I will focus on just fitting these GitHub Actions into the already established format on GH and elsewhere. Based on the maturity of the project we are assuming these GHA do not require any additional development.
Note: I am only concerned that these specific actions are directed to unique commits and not to the latest-tag, release or versions. This was the reason for my initial plans to contact @JosiahSiegel and inquire about it.

I am concerned on targeting a specific commit for these GitHub Actions.

runleaks
https://github.com/JosiahSiegel/terraform-stats/commit/68b8cbe42c494333fbf6f8d90ac86da1fb69dcc2
https://github.com/JosiahSiegel/action-connect-ovpn/commit/794339aff94452216c97f609476c367a43a31295

It seems that there is either a previous attempt to import these GitHub Actions or what already exists in the .github/actions folder is required to interface with the remote-action. I can either spend time trying to figure out what is going on (which is part of a larger initiative to learn about the framework) or simply effectively save time and directly ask Mr. Siegel about it.
Note: I will continue to review these GHA but time is limited and I have very little time to waste since the devops team is leaving. I will take the path of directly asking Mr. Siegel if he can provide me with some insights.

I will take now the easy/quick approach of forking JosiahSiegel repos into my account and then update the GitHub Actions use entries to point to the newly forked repos.
This is not a solution but rather a less intrusive/disruptive change to the existing workflows.
While this is happening, I will engage the CDC GitHub Organization and request for them to fork the repos from JosiahSiegel.
Note: This request might take some time but meanwhile we can use those forked repos.

While this is resolved, I will go ahead and just include these original repos into the project's .github/actions section and leave them there as placeholders. Just to make sure they are part of the codebase and tied to the project.

I have now created a branch named "importing-gha" and injected the three repositories into the .github/actions folder as placeholders for completing the importing process.
`devops: prime-reportstream (master=) $ git checkout -b importing-gha ;
Switched to a new branch 'importing-gha'
devops: prime-reportstream (importing-gha) $ git status ;
On branch importing-gha
Untracked files:
(use "git add ..." to include in what will be committed)
.github/actions/action-connect-ovpn/
.github/actions/runleaks/
.github/actions/terraform-stats/
nothing added to commit but untracked files present (use "git add" to track)`

devops: prime-reportstream (importing-gha) $ git status ;
On branch importing-gha
nothing to commit, working tree clean
devops: prime-reportstream (importing-gha) $ git push --set-upstream origin importing-gha ;
Username for 'https://github.com/CDCgov/prime-reportstream.git': emvaldes
Password for<EMAIL_ADDRESS>Enumerating objects: 58, done.
Counting objects: 100% (58/58), done.
Delta compression using up to 16 threads
Compressing objects: 100% (49/49), done.
Writing objects: 100% (55/55), 19.21 KiB | 3.84 MiB/s, done.
Total 55 (delta 11), reused 1 (delta 0), pack-reused 0 (from 0)
remote: Resolving deltas: 100% (11/11), completed with 3 local objects.
remote:
remote: Create a pull request for 'importing-gha' on GitHub by visiting:
remote:      https://github.com/CDCgov/prime-reportstream/pull/new/importing-gha
remote:
remote: GitHub found 7 vulnerabilities on CDCgov/prime-reportstream's default branch (2 high, 5 moderate). To find out more, visit:
remote:      https://github.com/CDCgov/prime-reportstream/security/dependabot
remote:
To https://github.com/CDCgov/prime-reportstream.git

[new branch]          importing-gha -> importing-gha
branch 'importing-gha' set up to track 'origin/importing-gha'.

After importing all Josiah Siegel's GHA into the project, I have now modified the only two references within the GitHub Actions file structure pointing to these repos.

`devops: actions (importing-gha=) $ git log -p ./deploy-backend/action.yml ;
commit fe62ba3ba2ad556f5e812f60df42895268b60da2 (HEAD -> importing-gha, origin/importing-gha)
Author: Eduardo Valdes Jr<EMAIL_ADDRESS>Date:   Tue Oct 8 15:41:18 2024 -0700
Modifying links to JosiahSiegel's GHA (remote repositories)

diff --git a/.github/actions/deploy-backend/action.yml b/.github/actions/deploy-backend/action.yml
...

 uses: JosiahSiegel/checksum-validate-action@ebdf8c12c00912d18de93c483b935d51582f9236

 ## uses: JosiahSiegel/checksum-validate-action@ebdf8c12c00912d18de93c483b935d51582f9236

 uses: ./.github/actions/checksum-validate-action

`

## - uses: josiahsiegel/action-connect-ovpn@794339aff94452216c97f609476c367a43a31295

uses: ./.github/actions/action-connect-ovpn

Reverting changes because it broke the build process.
Test Results
1 239 tests  ±0   1 235 ✅ ±0   7m 41s ⏱ -4s
  162 suites ±0       4 💤 ±0
  162 files   ±0       0 ❌ ±0
Results for commit https://github.com/CDCgov/prime-reportstream/commit/a538a8a6acb7ecb815dc97460f2ce74874ed8434. ± Comparison against base commit https://github.com/CDCgov/prime-reportstream/commit/5025bf5dc5269757cbe82711aaf80c4a4b88b99f.

devops: actions (importing-gha=) $ git log -p ./deploy-backend/action.yml ;
commit bcdd7f14dc68b8ecd95f071d5f71fe8c3f4d682d (HEAD -> importing-gha, origin/importing-gha)
Author: Eduardo Valdes Jr<EMAIL_ADDRESS>Date:   Tue Oct 8 16:16:04 2024 -0700
Reverting changes to references for JosiahSiegel's GHA (remote repositories)

diff --git a/.github/actions/deploy-backend/action.yml b/.github/actions/deploy-backend/action.yml
index 930a08db5..de808a918 100644
--- a/.github/actions/deploy-backend/action.yml
+++ b/.github/actions/deploy-backend/action.yml
@@ -333,8 +333,8 @@ runs:
- name: Validate function app checksum
if: inputs.checksum-validation == 'true'
-      ## uses: JosiahSiegel/checksum-validate-action@ebdf8c12c00912d18de93c483b935d51582f9236
-      uses: ./.github/actions/checksum-validate-action
+      uses: JosiahSiegel/checksum-validate-action@ebdf8c12c00912d18de93c483b935d51582f9236
+      ##<EMAIL_ADDRESS>(Replace) uses: ./.github/actions/checksum-validate-action

+    - uses: josiahsiegel/action-connect-ovpn@794339aff94452216c97f609476c367a43a31295
+    ##<EMAIL_ADDRESS>(Replace) - uses: ./.github/actions/action-connect-ovpn

All GitHub Actions and Workflows are not preset with entries that indicate what lines need to be replaced when changes in the imported repos are completed and they are functional.
There are now changes I have to perform to update self and cross referencing issues within the repos themselves. After that, the next step is to identify existing and/or missing references to INPUTS, SECRETS and ENV variables.
Once that is resolved, then we can switch on these replacements.
Until then, nothing will work and cannot be enabled to avoid breaking the build process.

There are 14 externally residing on Mr. Josiah Siegel's personal repos that are to be imported and we need to identify them (temporarily) with some sort of prefix until we can normalize their naming patterns within the prime-reportstream GitHub Actions conventions.
For that, I will rename these repos so that it's clear the purpose of those within the GHA folder.
e.g.: josiahsiegel--***
Note: This is for now while I work on these within my branch. Before merging into MASTER we should have a decision made in this regard.

We have now identified and documented all secrets and variables used in these GitHub Actions.
We are currently reviewing which of these already exists in this project and which ones are missing.
The goal here is to make sure that all parameters defined in the imported GitHub Actions are present in the Prime-ReportStream project. Once all missing items are identified, we will proceed to contact the repos maintainer (Mr. Joisah Siegel) and ask for his guidance to the configure the missing components so the import process basic onboarding is completed.
We have a lot to work on after these steps are completed because the import itself is not enough and we need to create new GitHub Workflows to tests these imported GitHub Actions.

It's now decided to disregard all the Josiah Siegel's external/remote repos that we initially targeted to import as it seems (based on his input) that only the "action-connect-ovpn" GitHub Action is worth importing.
devops: actions (importing-gha $=) $ git rm -r --cached ./azviz-action ./checksum-validate-action ./git-secrets ./randomrepo ./rapid-wsl ./reliable-pull-request-action ./remote-branch-action ./runleaks ./slack-boltjs-app ./stackoverflow_in_pg ./terraform-stats ./terraform-templates ./workflow-housekeeper ;
rm '.github/actions/azviz-action/.github/workflows/sample_full_workflow.yml'
...
rm '.github/actions/checksum-validate-action/.github/dependabot.yml'
...
rm '.github/actions/git-secrets/.gitattributes'
...
rm '.github/actions/randomrepo/.github/workflows/main.yml'
...
rm '.github/actions/rapid-wsl/.gitignore'
...
rm '.github/actions/reliable-pull-request-action/.github/workflows/test-action.yml'
...
rm '.github/actions/remote-branch-action/.github/workflows/test-action.yml'
...
rm '.github/actions/runleaks/.github/dependabot.yml'
...
rm '.github/actions/slack-boltjs-app/.dockerignore'
...
rm '.github/actions/stackoverflow_in_pg/.gitignore'
...
rm '.github/actions/terraform-stats/.github/ISSUE_TEMPLATE/bug_report.md'
...
rm '.github/actions/terraform-templates/.devcontainer/Dockerfile'
...
rm '.github/actions/terraform-templates/azure/modules/azure_ad/v2/files/winrm.ps1'
...
rm '.github/actions/workflow-housekeeper/.github/dependabot.yml'
...

Based on Josiah Siegel's recommendation:
[...] I was just saying the only critical action is the vpn one. All others support some other optional/nice-to-have feature (and can be replaced if you want to).
You can treat my actions like you treat the hundreds of gradle public libraries used by reportstream or copy and paste their guts directly into the project if you no longer wish to use the public source.
For public libraries, there are variables used in test build workflows that users do not need to be aware of. It is the same thing here. The only thing that matters is the input/output of the action.yml and reportstream is already doing that correctly.


World-Gen Config

Could you at some point make a pass at adding a config option to disable World-Gen for ores? I was working on transitioning Nikolite Ore over to the CoFH World ore generation system this morning to lower the spawn rates a tad and realized it can't be disabled right now, which means the only way to modify the spawn rates is pre-generating a world, using a world editor to replace Nikolite with Air or Stone, and then applying retro-gen with CoFH World to the existing terrain for Nikolite.

Yeah, that would definitely be possible

It's really annoying that Nikolite spawns and you can't disable it. Now I have Nikolite from three different mods ://

FYI, I'll implement this after BTM is over, most likely. So, at the beginning of October I guess

I guess this should do the trick for now. Will publish a new version on CurseForge in a bit

Nice, thank you :)


Any plans to support specifying SLA using both "time" and "duration" options?

I want to apply workflow to execute tasks both when the execution time exceeds the threshold and when it exceeds a specific time, but it is an error.
For example, Use Digdag v0.9.27.

Create example.dig

timezone: UTC

sla:
  duration: 00:00:10
  +duration-notice:
    echo>: 'sla duration!'
  time: 12:00:00
  +time-notice:
    echo>: 'sla time!'

+task:
  echo>: sleep 3600

Run example.dig

example.dig failed with error: SLA must be specified using either the 'time' or 'duration' option (config) error.
$ docker run -it --rm -v `pwd`:/src szyn/docker-digdag:latest run -a example.dig
2018-10-03 11:15:18 +0000: Digdag v0.9.27
2018-10-03 11:15:21 +0000 [WARN] (main): Using a new session time 2018-10-03T00:00:00+09:00.
2018-10-03 11:15:21 +0000 [INFO] (main): Using session /src/.digdag/status/20181003T000000+0900.
error: SLA must be specified using either the 'time' or 'duration' option (config)

Do you any plans to support specifying SLA using both "time" and "duration" options?

If there is no additional comment I will close it later.

@yoyama Sorry for the delay in my reply.
@muga Thank you for your suggestion. I will try it!

May you want to setup sla option for each task instead of workflow (attempt) correct? Can task_ttl help your case?


support SOCTOU feature in EM_RANDLES_BATMAC

📝 Description of the feature
please add support to define Equilibrium voltage (OCV) in EM_RANDLES_BATMAC. Its the 4th field in second card.
💡 Steps for implementing the feature
This is a curve input which should be defined as a negative number.
🔗 Useful links and references
No response

0.4.0 supports it now

0.4.0 supports it now


PR for Create a Wishlist Item

I have made edits so that this can be merged and fixed an inconsistency in the wishlist item-model representation


Discussion: Should Underscore support string syntax for deep property access?

With #2494 Underscore functions that previously accepted a property name string, can now also accept an array representing a list of deeply nested property names.
For example:
var postAuthorIds = _.pluck(posts, ['author', 'id']);

A possible additional layer of syntactic sugar would be to allow users to pass a . delimited string to more tersely express the same idea:
var postAuthorIds = _.pluck(posts, 'author.id');

The goal of this issue is to determine if Underscore should support deep property access via a string syntax.
Pros

Cleaner (less noisy)
Proven managable/successful/popular by Lodash
Compatible with Lodash
Can be used in places where arrays cannot (like keys of a _.matcher object).
Prefered over the array syntax by devs. (According to @jdalton's Twitter Poll)

Cons

Could be seen as overly magical. See #2268 for a discussion of this concern.
Can be ambiguous in the case of a key containing a literal . character. Applications that use such keys may have a hard time upgrading. Users will have to know to fallback to the array syntax in this case.
Does not work well with dynamic keys. Users will have to know to fallback to the array syntax in this case as well.

Feel free to voice your support/objections on adding this syntax with a 👍  / 👎  on this issue. Please save the comments for raising new pros/cons or discussing the various tradeoffs.

Should Underscore support string syntax for deep property access?

If we're going to support deep name access via array paths, then yes, we should also take string shorthand.

I'm fine with it, as long as we don't go off into hell of abstract [] pattern matching. Simple a.0.b.c => ['a', '0', 'b', 'c'].

I don't think it would be hellish.  We should allow one level of bracket, for things that you'd expect like array indices and keys with dashes and the like.
Consider throwing if there are brackets inside brackets.. Lodash does all of this with a regex, fwiw.  We could do it that way, or with a single pass.

I don't think it would be hellish. We should allow one level of bracket

What would be the downside of only supporting . paths, and not [] paths?

I picture a lot of attempts at using a[0].foo, which wouldn't go as expected.  That's the main thing.

It sounds like we have enough of a concensus here to move forward with the string syntax.


Return meta data as promise

refs #7095
In preparation to get asynchronous image-dimensions we need to promisify the ghost_head helper

returns a new Promise from meta data
uses Promise.props() to resolve getClient() and getMetaData()

Closed in favour of #7152


Inline code block style changed

Describe the bug
Content `const x = 1` should be rendered like  const x = 1 .
Steps to reproduce

Type content like `const x = 1`

The version of Memos you're using
0.18.2
Screenshots or additional context
No response

Updated with https://github.com/usememos/memos/commit/c9146bc749b28443144413d0e105e543352b9d91


SWDEV-296233

Add missing algorithms for spmv and spmm

0,1,2,3,4,5,6 ... is redundant. There's already a mechanism for numbering.
shall we test?

I assume you are referring to the enums? I have a very slight preference for the explicit numbering as I think it makes it more clear that each value has an associated number and that in particular the order that the enums appear matters. That being said I dont really care that strongly. I assume @YvanMokwinski  you want to get rid of them? If @ntrost57 you also agree then thats a consensus and I will remove the enum numbering on all the enums. Thoughts?

No I'm fine with explicit numbering. I was just raising the comment as I've seen it many times. The question is : are values important? maybe they are not, maybe they are not but the order is still important to keep a certain 'compatibility'.

No I'm fine with explicit numbering. I was just raising the comment as I've seen it many times. The question is : are values important? maybe they are not, maybe they are not but the order is still important to keep a certain 'compatibility'.

If I am understanding your question, I think the values are important but the order isn't I don't think. For example a user might do something like;
status = HIPSPARSE_STATUS_SUCCESS;
if(status == 1)
{
//do something
}
The ordering I don't think is important as we always access them using routines like: hipErrorToHIPSPARSEStatus(hipError_t status) which I think makes the order in which they appear not matter. As long as the values are the same for the user then the order they appear in the enum I don't think matters.

No I'm fine with explicit numbering. I was just raising the comment as I've seen it many times. The question is : are values important? maybe they are not, maybe they are not but the order is still important to keep a certain 'compatibility'.

If I am understanding your question, I think the values are important but the order isn't I don't think. For example a user might do something like;
status = HIPSPARSE_STATUS_SUCCESS;
if(status == 1)
{
//do something
}
The ordering I don't think is important as we always access them using routines like: hipErrorToHIPSPARSEStatus(hipError_t status) which I think makes the order in which they appear not matter. As long as the values are the same for the user then the order they appear in the enum I don't think matters.
So I guess what I meant in my previous was that the value matters but not the order (although it probably makes sense to maintain the ordering increasing with value?)

I understand your point but as user, doing if status==1 is not the greatest thing to write.
Anyway if we want to keep compatibility then values can't change. Either the numbering is explicit and then order doesn't matter (you can change the order but I don't see the need for it), or the numbering is implicit and then defined by the order.
On my question: "shall we test?", it means that on the fact that values can't change, to ensure compatibility maybe we can write some tests (not now) to enforce values.
ASSERT_EQ( ((int)a), 1);
ASSERT_EQ( ((int)b), 2);
etc ....
this way if something is changed accidentally we can catch it right away, avoiding the need of understanding what's been broken in future compatibility bugs.

No I'm fine with explicit numbering. I was just raising the comment as I've seen it many times. The question is : are values important? maybe they are not, maybe they are not but the order is still important to keep a certain 'compatibility'.

If I am understanding your question, I think the values are important but the order isn't I don't think. For example a user might do something like;
status = HIPSPARSE_STATUS_SUCCESS;
if(status == 1)
{
//do something
}
The ordering I don't think is important as we always access them using routines like: hipErrorToHIPSPARSEStatus(hipError_t status) which I think makes the order in which they appear not matter. As long as the values are the same for the user then the order they appear in the enum I don't think matters.
So I guess what I meant in my previous was that the value matters but not the order (although it probably makes sense to maintain the ordering increasing with value?)

I understand your point but as user, doing if status==1 is not the greatest thing to write.
Anyway if we want to keep compatibility then values can't change. Either the numbering is explicit and then order doesn't matter (you can change the order but I don't see the need for it), or the numbering is implicit and then defined by the order.
On my question: "shall we test?", it means that on the fact that values can't change, to ensure compatibility maybe we can write some tests (not now) to enforce value correctness.
ASSERT_EQ( ((int)a), 1);
ASSERT_EQ( ((int)b), 2);
etc ....
this way if something is changed accidentally we can catch it right away, avoiding the need of understanding what's been broken in future compatibility bugs.

Sure we can test.


⚠ Bofrost.fr has degraded performance

In c2274de, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1029 ms

Resolved: Bofrost.fr performance has improved in 811d31b after 39 minutes.