[issue-368] knative integration with DataIndex and JobService

Implements the Knative integration for DataIndex and JobService as well as the workflow as outlined in the ADR:
https://docs.google.com/document/d/1UIfprTNr1fKNhc7ngvbPDzSFdePg-_GPtxxvqsLi2NA/edit#heading=h.ds8q4xtkmu64
Unit test cases are updated. See the ADR for common test cases:
https://docs.google.com/document/d/1UIfprTNr1fKNhc7ngvbPDzSFdePg-_GPtxxvqsLi2NA/edit?usp=sharing
Motivation for the change:
Knative integration
Fix #368
Checklist

[x] Add or Modify a unit test for your change
[x] Have you verified that all the tests are passing?

How to backport a pull request to a different branch?

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

To pass the file generation check, make sure to run:
make generate-all, then make vet fmt before commiting.

To pass the file generation check, make sure to run:
make generate-all, then make vet fmt before commiting.

Thanks!

Hi @jianrongzhang89 , this starts to look good!
Some results here:
Case1:
DI, JS and workflows takes eventing configuration from the platform
https://github.com/flows-examples/techpreview2/tree/main/platforms/data_index_and_jobservice_as_platform_service_postgresql_persistence_knative_eventing/case1

The use case works, evens are produced/registered as expected.

Expected triggers are created

NAME                                                        BROKER    SINK                                             AGE   CONDITIONS   READY   REASON
callbackstatetimeouts-callbackevent-trigger                 default   service:callbackstatetimeouts                    50m   7 OK / 7     True
sonataflow-platform-data-index-jobs-trigger                 default   service:sonataflow-platform-data-index-service   52m   7 OK / 7     True
sonataflow-platform-data-index-process-definition-trigger   default   service:sonataflow-platform-data-index-service   52m   7 OK / 7     True
sonataflow-platform-data-index-process-error-trigger        default   service:sonataflow-platform-data-index-service   52m   7 OK / 7     True
sonataflow-platform-data-index-process-node-trigger         default   service:sonataflow-platform-data-index-service   52m   7 OK / 7     True
sonataflow-platform-data-index-process-sla-trigger          default   service:sonataflow-platform-data-index-service   52m   7 OK / 7     True
sonataflow-platform-data-index-process-state-trigger        default   service:sonataflow-platform-data-index-service   52m   7 OK / 7     True
sonataflow-platform-data-index-process-variable-trigger     default   service:sonataflow-platform-data-index-service   52m   7 OK / 7     True
sonataflow-platform-job-service-create-job-trigger          default   service:sonataflow-platform-jobs-service         52m   7 OK / 7     True
sonataflow-platform-job-service-delete-job-trigger          default   service:sonataflow-platform-jobs-service         52m   7 OK / 7     True

Expected sinkbindings are created

callbackstatetimeouts-sb                  SinkBinding   sinkbindings.sources.knative.dev   broker:default   True
jobs-service-sb                           SinkBinding   sinkbindings.sources.knative.dev   broker:default   True
@jianrongzhang89 to be continued tomorrow.

Hi @jianrongzhang89 I was executing the following usecase in Openshift (since before I worked with minikube only) and I can see the following weird behaviour.
https://github.com/flows-examples/techpreview2/tree/main/platforms/data_index_and_jobservice_as_platform_service_postgresql_persistence_knative_eventing/case1

The Job service deployment is produced.
And after some minutes, when the callbackstatecallback workflow build finished, the corresponding deployment is also produced.

But, if I wait some time, I start to see the workflow and the JS restarting forever.
See some cases here:

Hi @jianrongzhang89 I was executing the following usecase in Openshift (since before I worked with minikube only) and I can see the following weird behaviour.
https://github.com/flows-examples/techpreview2/tree/main/platforms/data_index_and_jobservice_as_platform_service_postgresql_persistence_knative_eventing/case1

The Job service deployment is produced.
And after some minutes, when the callbackstatecallback workflow build finished, the corresponding deployment is also produced.

But, if I wait some time, I start to see the workflow and the JS restarting forever.

I will look into it. Thanks.

Hi  @jianrongzhang89 , here goes some more test results with the latest changes:
Case 2)  Is still failing
https://github.com/flows-examples/techpreview2/tree/main/platforms/data_index_and_jobservice_as_platform_service_postgresql_persistence_knative_eventing/case2
After deploying the DI, JS, and the workflow, we have same outcome as before:
kubectl get workflow -n case2-kn-eventing

NAME                    PROFILE   VERSION   URL   READY   REASON
callbackstatetimeouts   preview   0.0.1           False   DeploymentFailure

Case 5) is now working with the following considerations:
https://github.com/flows-examples/techpreview2/tree/main/platforms/data_index_and_jobservice_as_platform_service_postgresql_persistence_knative_eventing/case5
Trigger names collision:
When we use the SFCP, with the cluster-wide instance of the DI, JS, and Broker, all the triggers must be created in the namespace of the SFP that defines these objects. (in the example case5-kn-eventing). This is necessary from the point of view of Knative Eventing.
And thus, if we deploy a workflow "callbackstatetimeouts" in namespace1, a trigger with the name callbackstatetimeouts-callbackevent-trigger will be created in "case5-kn-eventing".
Now, if we deploy "callbackstatetimeouts" in nampespace2, the operator will try to create callbackstatetimeouts-callbackevent-trigger in "case5-kn-eventing" and will produce an error.
The error only happens of course when we use that cluster-wide configuration.
Well, considering that we are doing work in parallel, to support the same workflow name to be deployed in different namespaces, I think this trigger issue, must be fixed as part of this PR. Not too much really.
note: we should include the namespace in the trigger name only for workflows that are deployed in a different ns I think.
Trigger names length:
It looks like the Trigger names, IDK why, must be no longer than 63 characters. With a larger name, it looks like the trigger is created, but, it doesn't work. And, by querying triggers with "kn trigger list", we can see the following output.
sonataflow-broker   service:sonataflow-platform-data-index-service   9s    3 OK / 6     False   NotSubscribed : Subscription.messaging.knative.dev "sonataflow-broker-sonataflow-pla6ff7c12b8027f7bef859225cc5ef7cf" is invalid: metadata.labels: Invalid value: "sonataflow-platform-data-index-service-process-def-triggerssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff": must be no more than 63 characters
Considering that we are not that far to reach that limit, think we must:

Ask if this is an error in Knative Eventiing. Why so short trigger names?. Maybe in some newer version this was fixed, or mabye this is needed.

Mabye the rational for that limit is this: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#:~:text=in RFC 1035.-,This means the name must%3A,start with an alphabetic character

If that length is there for good reasons, we must apply a smart trimming of the names for the generated Triggers, otherwise the probability of a failure is huge and the integration won't work.

On the other hand, the SinkBinding names looks to support 253 characters like other k8s objects.

@wmedvede @jianrongzhang89 For the naming problem, let's usetrigger-<randon-id> as used by pods. Then we just have to make sure that this info is tied to the parent object. If in a workflow, we can add to the .status.triggers attribute an array of knative triggers. The same for DI and JS. Then, the name won't be a matter anymore and we have a good way of finding the relation between then.

For case 2, there is no broker defined in the platform's spec.inventing field and the workflow does not have sink defined. In this case, based on our previous discussions, the test is intended to fail. Please see the ADR https://docs.google.com/document/d/1UIfprTNr1fKNhc7ngvbPDzSFdePg-_GPtxxvqsLi2NA/edit?usp=sharing use case #1.1.
@ricardozanini could you please confirm this is the desired behavior?

Hi @jianrongzhang89 , here goes some more test results with the latest changes:
Case 2) Is still failing https://github.com/flows-examples/techpreview2/tree/main/platforms/data_index_and_jobservice_as_platform_service_postgresql_persistence_knative_eventing/case2
After deploying the DI, JS, and the workflow, we have same outcome as before:
kubectl get workflow -n case2-kn-eventing

NAME                    PROFILE   VERSION   URL   READY   REASON
callbackstatetimeouts   preview   0.0.1           False   DeploymentFailure

@wmedvede @jianrongzhang89 For the naming problem, let's use trigger-<randon-id> as used by pods. Then we just have to make sure that this info is tied to the parent object. If in a workflow, we can add to the .status.triggers attribute an array of knative triggers. The same for DI and JS. Then, the name won't be a matter anymore and we have a good way of finding the relation between then.

@ricardozanini @wmedvede this is a great idea. This limitation is indeed required by the Knative eventing itself, as it uses a label with the trigger name in the subscription objects. I updated the PR with a slightly different implementation using the knative's function ChildName() to generate the trigger name.  It is based on the parent object (data index, job index or workflow)'s UID and make sure that the generated name won't be longer that 63 characters. Here are an example of the trigger names:
data-index-jobs-9e8d24ce-5032-4771-9934-da0c15fd69cc
data-index-process-definition-73a585bd4a43f0ee289b57dfbedf39dd9
data-index-process-error-9e8d24ce-5032-4771-9934-da0c15fd69cc
data-index-process-node-9e8d24ce-5032-4771-9934-da0c15fd69cc
data-index-process-sla-9e8d24ce-5032-4771-9934-da0c15fd69cc
data-index-process-state-9e8d24ce-5032-4771-9934-da0c15fd69cc
data-index-process-variable-5fa0f63cae14d1df1c1bd23aaa599b559e8
jobs-service-create-job-9e8d24ce-5032-4771-9934-da0c15fd69cc
jobs-service-delete-job-9e8d24ce-5032-4771-9934-da0c15fd69cc
greetingtest5-greetingevent-be7d8bd8dce1feb49e4e476c2842512b8ea
greetingtest5-greetingevent2-0a73c1906bdc359d653befc487a9f7048e
Since  these triggers have labels or owner references that indicate which workflows (or dataindex or job service's) they belong to already, it does not seem to me that we need to add the information to workflow's status. Please let me know if I missed something and this is really required. Thank you.

@jianrongzhang89 agreed with the naming approach, many thanks for looking into this!
Regarding with the test failure, please see my changes here: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/487/files#diff-4782f3846c145011deb7edc727cc7dd3016d1683615d1f426ce246e57908daf2
It should help fix this bug and have access to utils.GetClient() across all tests.

@ricardozanini could you please confirm this is the desired behavior?

It's, but we have to add an event or a clear status to the object alerting users about this behavior.

@ricardozanini could you please confirm this is the desired behavior?

It's, but we have to add an event or a clear status to the object alerting users about this behavior.

@ricardozanini the sonataflow status already has error message in the condition:
status:
address: {}
conditions:
- lastUpdateTime: "2024-06-15T01:16:08Z"
status: "True"
type: Built
- lastUpdateTime: "2024-06-15T01:16:08Z"
message: Error in deploy the workflow:no sink configured in the workflow or
the platform when Job Service or Data Index Service is enabled
reason: DeploymentFailure
status: "False"
type: Running
observedGeneration: 1
services:
dataIndexRef:
url: http://sonataflow-platform-data-index-service.sonataflow-infra
jobServiceRef:
url: http://sonataflow-platform-jobs-service.sonataflow-infra
Is there anything additional needed?

@jianrongzhang89 agreed with the naming approach, many thanks for looking into this!
Regarding with the test failure, please see my changes here: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/487/files#diff-4782f3846c145011deb7edc727cc7dd3016d1683615d1f426ce246e57908daf2
It should help fix this bug and have access to utils.GetClient() across all tests.

The test failure is fixed.

@wmedvede in your test case, had u seen the message in the Platform status?

@wmedvede in your test case, had u seen the message in the Platform status?

@jianrongzhang89 was right, we have said that if DI and JS is present, and  we can't grab the source to connect the WF with, and  error must be produced. This report was my fault. I can see the message in the WF status.
`
status:
address: {}
conditions:

lastUpdateTime: "2024-06-20T12:00:17Z"
status: "True"
type: Built
lastUpdateTime: "2024-06-20T12:00:17Z"
message: Error in deploy the workflow:no sink configured in the workflow or the
platform when Job Service or Data Index Service is enabled
reason: DeploymentFailure
status: "False"
type: Running
observedGeneration: 1
services:
dataIndexRef:
url: http://sonataflow-platform-data-index-service.case2-kn-eventing
jobServiceRef:
url: http://sonataflow-platform-jobs-service.case2-kn-eventing

`

HI @jianrongzhang89 I have found one issue that would be great if you can take a look.
In use case3:
https://github.com/flows-examples/techpreview2/tree/main/platforms/data_index_and_jobservice_as_platform_service_postgresql_persistence_knative_eventing/case3
I have executed these steps with the following results:

Execute the use case as usual:

kubectl kustomize platforms/data_index_and_jobservice_as_platform_service_postgresql_persistence_knative_eventing/case3 | kubectl apply -f - -n case3-kn-eventing

after some time, we get two workflows running, callbackstatetimeouts and eventstatetimeouts, DI, JS, all good.

we delete the callbackstatetimeouts with
kubectl delete workflow callbackstatetimeouts -n case3-kn-eventing

the corresponding triggers and sb are also removed, good!

we delete the eventstatetimeouts with

kubectl delete workflow eventstatetimeouts -n case3-kn-eventing
the corresponding triggers and sb are also removed, good!

so, now we have only DI, JS and the broker.

now we deploy only the eventstatetimeouts

kubectl apply -f   07-sonataflow_eventstatetimeouts.sw.yaml -n case3-kn-eventing
The deployment procedure starts, the wf build happens, the deployment is created, the triggers too, but WF never starts well:
And keeps restarting.

I can see this error in the logs:
https://gist.github.com/wmedvede/f7a7e0ea93f4319727fee3cfc39aaa5b

@jianrongzhang89 I just tested with adding only the following to the sonataflowplatform:
eventing:
    broker:
      ref:
        name: kafka-broker
        namespace: sonataflow-infra
        apiVersion: eventing.knative.dev/v1
        kind: Broker

The triggers are created:
$ oc get trigger -A
NAMESPACE      NAME                                                              BROKER         SUBSCRIBER_URI   AGE     READY   REASON
orchestrator   data-index-jobs-2ac1baab-d856-40bc-bcec-c6dd50951419              kafka-broker                    6m51s
orchestrator   data-index-process-definition-634c6f230b6364cdda8272f98c5d58722   kafka-broker                    6m51s
orchestrator   data-index-process-error-2ac1baab-d856-40bc-bcec-c6dd50951419     kafka-broker                    6m51s
orchestrator   data-index-process-node-2ac1baab-d856-40bc-bcec-c6dd50951419      kafka-broker                    6m51s
orchestrator   data-index-process-sla-2ac1baab-d856-40bc-bcec-c6dd50951419       kafka-broker                    6m51s
orchestrator   data-index-process-state-2ac1baab-d856-40bc-bcec-c6dd50951419     kafka-broker                    6m51s
orchestrator   data-index-process-variable-6f721bf111e75efc394000bca9884ae22ac   kafka-broker                    6m51s
orchestrator   jobs-service-create-job-2ac1baab-d856-40bc-bcec-c6dd50951419      kafka-broker                    6m51s
orchestrator   jobs-service-delete-job-2ac1baab-d856-40bc-bcec-c6dd50951419      kafka-broker                    6m51s

But they are not in the same namespace as the broker, is that normal?

The trigger is not re-created automatically, is that normal?
Then I edit the eventing spec and I set the broker name to kafka-broker2 and then, only the deleted trigger is (re)created, the other do not change:
$ oc get trigger -A
NAMESPACE      NAME                                                              BROKER          SUBSCRIBER_URI   AGE   READY   REASON
orchestrator   data-index-jobs-2ac1baab-d856-40bc-bcec-c6dd50951419              kafka-broker2                    35s
orchestrator   data-index-process-definition-634c6f230b6364cdda8272f98c5d58722   kafka-broker                     19m
orchestrator   data-index-process-error-2ac1baab-d856-40bc-bcec-c6dd50951419     kafka-broker                     19m
orchestrator   data-index-process-node-2ac1baab-d856-40bc-bcec-c6dd50951419      kafka-broker                     19m
orchestrator   data-index-process-sla-2ac1baab-d856-40bc-bcec-c6dd50951419       kafka-broker                     19m
orchestrator   data-index-process-state-2ac1baab-d856-40bc-bcec-c6dd50951419     kafka-broker                     19m
orchestrator   data-index-process-variable-6f721bf111e75efc394000bca9884ae22ac   kafka-broker                     19m
orchestrator   jobs-service-create-job-2ac1baab-d856-40bc-bcec-c6dd50951419      kafka-broker                     19m
orchestrator   jobs-service-delete-job-2ac1baab-d856-40bc-bcec-c6dd50951419      kafka-broker                     19m

I would expect all triggers (and sinkbindings) to be recreated with the new value

Hi @jianrongzhang89 , when doing knative deployments of a workflow I have found the following issue.
You can see the following Use case 3, knative services reproducer:
https://github.com/flows-examples/techpreview2/tree/main/platforms/data_index_and_jobservice_as_platform_service_postgresql_persistence_knative_eventing/case3-knative-services
In this case, we mark a workflow to produce a knative service deployment instead of a regular kubernetes one, by using the following field:
  podTemplate:
    deploymentModel: knative

see: https://github.com/flows-examples/techpreview2/blob/main/platforms/data_index_and_jobservice_as_platform_service_postgresql_persistence_knative_eventing/case3-knative-services/07-sonataflow_eventstatetimeouts.sw.yaml#L26
With that configuration, we create a knative service to produce the workflow deployment.
And, the Triggers must be adjusted to refer a knative service instead.
This is what we see now:
eventstatetimeouts-event1-8b6712a2-8a8a-4def-a4a3-fdbc34b6e828    sonataflow-broker   service:eventstatetimeouts                       6m27s   1 OK / 7     False   Unable to get the Subscriber's URI : failed to get object case3-kn-eventing-knservices/eventstatetimeouts: services "eventstatetimeouts" not found
eventstatetimeouts-event2-8b6712a2-8a8a-4def-a4a3-fdbc34b6e828    sonataflow-broker   service:eventstatetimeouts                       6m27s   1 OK / 7     False   Unable to get the Subscriber's URI : failed to get object case3-kn-eventing-knservices/eventstatetimeouts: services "eventstatetimeouts" not found
j
I think the issue is not too much, it's just a matter of taking account that when the triggers are created.
The following type must be used instead:
  subscriber:
    ref:
      apiVersion: serving.knative.dev/v1
      kind: Service

And for the SinkBinding we might have to take into account a similar consideration.
DataIndex and JobsService are good, will never be knative services.

@jianrongzhang89 I just tested with adding only the following to the sonataflowplatform:
eventing:
    broker:
      ref:
        name: kafka-broker
        namespace: sonataflow-infra
        apiVersion: eventing.knative.dev/v1
        kind: Broker

The triggers are created:
$ oc get trigger -A
NAMESPACE      NAME                                                              BROKER         SUBSCRIBER_URI   AGE     READY   REASON
orchestrator   data-index-jobs-2ac1baab-d856-40bc-bcec-c6dd50951419              kafka-broker                    6m51s
orchestrator   data-index-process-definition-634c6f230b6364cdda8272f98c5d58722   kafka-broker                    6m51s
orchestrator   data-index-process-error-2ac1baab-d856-40bc-bcec-c6dd50951419     kafka-broker                    6m51s
orchestrator   data-index-process-node-2ac1baab-d856-40bc-bcec-c6dd50951419      kafka-broker                    6m51s
orchestrator   data-index-process-sla-2ac1baab-d856-40bc-bcec-c6dd50951419       kafka-broker                    6m51s
orchestrator   data-index-process-state-2ac1baab-d856-40bc-bcec-c6dd50951419     kafka-broker                    6m51s
orchestrator   data-index-process-variable-6f721bf111e75efc394000bca9884ae22ac   kafka-broker                    6m51s
orchestrator   jobs-service-create-job-2ac1baab-d856-40bc-bcec-c6dd50951419      kafka-broker                    6m51s
orchestrator   jobs-service-delete-job-2ac1baab-d856-40bc-bcec-c6dd50951419      kafka-broker                    6m51s

But they are not in the same namespace as the broker, is that normal?
Then, I create the kafka broker:
$ oc get broker -A
NAMESPACE          NAME           URL                                                                                AGE     READY   REASON
sonataflow-infra   kafka-broker   http://kafka-broker-ingress.knative-eventing.svc.cluster.local/sonataflow-infra/kafka-broker   5m15s   True

But the triggers are never ready, I guess because they should be in the same namespace as the broker?

Thank you for catching this. This issue is fixed.

Hi @jianrongzhang89 , when doing knative deployments of a workflow I have found the following issue.
You can see the following Use case 3, knative services reproducer:
https://github.com/flows-examples/techpreview2/tree/main/platforms/data_index_and_jobservice_as_platform_service_postgresql_persistence_knative_eventing/case3-knative-services
In this case, we mark a workflow to produce a knative service deployment instead of a regular kubernetes one, by using the following field:
  podTemplate:
    deploymentModel: knative

see: https://github.com/flows-examples/techpreview2/blob/main/platforms/data_index_and_jobservice_as_platform_service_postgresql_persistence_knative_eventing/case3-knative-services/07-sonataflow_eventstatetimeouts.sw.yaml#L26
With that configuration, we create a knative service to produce the workflow deployment.
And, the Triggers must be adjusted to refer a knative service instead.
This is what we see now:
eventstatetimeouts-event1-8b6712a2-8a8a-4def-a4a3-fdbc34b6e828 sonataflow-broker service:eventstatetimeouts 6m27s 1 OK / 7 False Unable to get the Subscriber's URI : failed to get object case3-kn-eventing-knservices/eventstatetimeouts: services "eventstatetimeouts" not found eventstatetimeouts-event2-8b6712a2-8a8a-4def-a4a3-fdbc34b6e828 sonataflow-broker service:eventstatetimeouts 6m27s 1 OK / 7 False Unable to get the Subscriber's URI : failed to get object case3-kn-eventing-knservices/eventstatetimeouts: services "eventstatetimeouts" not found j
I think the issue is not too much, it's just a matter of taking account that when the triggers are created. The following type must be used instead:
  subscriber:
    ref:
      apiVersion: serving.knative.dev/v1
      kind: Service

And for the SinkBinding we might have to take into account a similar consideration.
DataIndex and JobsService are good, will never be knative services.

I updated the code to support knative services.

 The trigger is not re-created automatically, is that normal?
Then I edit the eventing spec and I set the broker name to kafka-broker2 and then, only the deleted trigger is (re)created, the other do not change:
$ oc get trigger -A
NAMESPACE      NAME                                                              BROKER          SUBSCRIBER_URI   AGE   READY   REASON
orchestrator   data-index-jobs-2ac1baab-d856-40bc-bcec-c6dd50951419              kafka-broker2                    35s
orchestrator   data-index-process-definition-634c6f230b6364cdda8272f98c5d58722   kafka-broker                     19m
orchestrator   data-index-process-error-2ac1baab-d856-40bc-bcec-c6dd50951419     kafka-broker                     19m
orchestrator   data-index-process-node-2ac1baab-d856-40bc-bcec-c6dd50951419      kafka-broker                     19m
orchestrator   data-index-process-sla-2ac1baab-d856-40bc-bcec-c6dd50951419       kafka-broker                     19m
orchestrator   data-index-process-state-2ac1baab-d856-40bc-bcec-c6dd50951419     kafka-broker                     19m
orchestrator   data-index-process-variable-6f721bf111e75efc394000bca9884ae22ac   kafka-broker                     19m
orchestrator   jobs-service-create-job-2ac1baab-d856-40bc-bcec-c6dd50951419      kafka-broker                     19m
orchestrator   jobs-service-delete-job-2ac1baab-d856-40bc-bcec-c6dd50951419      kafka-broker                     19m

I would expect all triggers (and sinkbindings) to be recreated with the new value
Similarly, if I delete the sinkbinding, it is not automatically re-created

Fix is done so that when a sinkbinding or trigger is deleted, it will get recreated by the operator.
However, when the sonataflowplatform broker name is updated, the trigger's broker won't get updated because the trigger broker name is immutable in Knative. In this case, an error will be generated in the operator logs.

@jianrongzhang89  looks like we need rebasing when you can please.

@jianrongzhang89 looks like we need rebasing when you can please.

@wmedvede code rebased.

@jianrongzhang89 can you please rebase again? 👍

It will be easier if you squash your commits.

@jianrongzhang89 please squash these commits so we have only one to merge. And your rebase will be way easier.

Hi @jakubschwan, @domhanak , I think this is ready for you guys try this from the execution perspective.
Would you mind prioritize?
Thanks!

Guys, @jianrongzhang89 @ricardozanini
I have executed most of the use cases in https://github.com/flows-examples/techpreview2/tree/0ac3f5285fac169bafa0ae84661e6c608e88283c/platforms/data_index_and_jobservice_as_platform_service_postgresql_persistence_knative_eventing
and in general I'd say that most of issues are fixed and working. Great job @jianrongzhang89!
However, I have identified the following situation that looks not good, specially considering that this is probably one of the most frequent setups to use by Parodos.
Full executable usecase here:
https://github.com/flows-examples/techpreview2/tree/main/platforms/data_index_and_jobservice_as_platform_service_postgresql_persistence_knative_eventing/case5
Summarized usecase:

Broker is configured in SPF and deployed in namespace case5-kn-eventing
We configure also a SFCP that points to the SPF in 1
We deploy WF callbackstatetimeouts in a different namespace case5-kn-eventing-workflows. The WF takes the Broker config from the SFCP as expected
We deploy WF callbackstatetimeouts2in namespace case5-kn-eventing. The WF takes the Broker config from the SFP as expected
DI, JS, and both workflows works fine, all Triggers, SBs, etc are created. Events are produced well.

After some time, we try to delete the WFs created before.

We execute  kubectl delete workflow callbackstatetimeouts2 -n case5-kn-eventing
Deletion is produced as expected, associated Triggers and SBs are also deleted as expected.

We execute kubectl delete workflow callbackstatetimeouts -n case5-kn-eventing-workflows
This time the deletion never finishes.
Basically looks to get stuck.

We can query the current workflows and see it all the time.
kubectl get workflows -n case5-kn-eventing-workflows
NAME                    PROFILE   VERSION   URL   READY   REASON
callbackstatetimeouts   preview   0.0.1           True

The controller log attached here:
https://gist.github.com/wmedvede/6da7d3fb3fb9f213ed62c9dbe2609a28

@jianrongzhang89 Would you mind try to reproduce?

Guys, @jianrongzhang89 @ricardozanini
I have executed most of the use cases in https://github.com/flows-examples/techpreview2/tree/0ac3f5285fac169bafa0ae84661e6c608e88283c/platforms/data_index_and_jobservice_as_platform_service_postgresql_persistence_knative_eventing
and in general I'd say that most of issues are fixed and working. Great job @jianrongzhang89!
However, I have identified the following situation that looks not good, specially considering that this is probably one of the most frequent setups to use by Parodos.
Full executable usecase here:
https://github.com/flows-examples/techpreview2/tree/main/platforms/data_index_and_jobservice_as_platform_service_postgresql_persistence_knative_eventing/case5
Summarized usecase:

Broker is configured in SPF and deployed in namespace case5-kn-eventing
We configure also a SFCP that points to the SPF in 1
We deploy WF callbackstatetimeouts in a different namespace case5-kn-eventing-workflows. The WF takes the Broker config from the SFCP as expected
We deploy WF callbackstatetimeouts2in namespace case5-kn-eventing. The WF takes the Broker config from the SFP as expected
DI, JS, and both workflows works fine, all Triggers, SBs, etc are created. Events are produced well.

After some time, we try to delete the WFs created before.

We execute  kubectl delete workflow callbackstatetimeouts2 -n case5-kn-eventing
Deletion is produced as expected, associated Triggers and SBs are also deleted as expected.
We execute kubectl delete workflow callbackstatetimeouts -n case5-kn-eventing-workflows
This time the deletion never finishes.
Basically looks to get stuck.

We can query the current workflows and see it all the time.
kubectl get workflows -n case5-kn-eventing-workflows
NAME PROFILE VERSION URL READY REASON callbackstatetimeouts preview 0.0.1 True

The controller log attached here:
https://gist.github.com/wmedvede/6da7d3fb3fb9f213ed62c9dbe2609a28

@jianrongzhang89 Would you mind try to reproduce?

@jakubschwan   @domhanak Would you mind guys double check this execution so see if you get same results.
Thanks!

@wmedvede @ricardozanini the workflow deletion hanging issue is now fixed with a minor code change. Could you please test again? Thanks.


Change shellsession grammar or  shellscript grammar source for more accurate parsing

This issue is related to a problem with the first command in shellsession not being highlighted correctly (https://github.com/shikijs/shiki/issues/616)
I reported the above issue upstream (https://github.com/jeff-hykin/better-shell-syntax/issues/79) and found that fixing this issue requires action in this repository, so here I am.
First, from a maintenance standpoint, I was told that it would be difficult to update the shellscript grammar to fix the issue. Also, the original shellsession grammar assumes that the grammar file in linguist is used to parse shellscript, not better-shell-syntax used in VS Code. If linguist is used to parse shellscript, shellsession will work correctly.
Therefore, there are two ways to fix this issue.

use linguist instead of better-shell-syntax as the shellscript grammar
fork the better-shell-syntax and shellscript grammars and modify each

I have confirmed that both options will fix the issue. The easiest to work with is option 1, but the possibility of breaking compatibility with other grammars cannot be ruled out. I would like to hear your opinion on this matter.
PS: It seems that only a very few commands are highlighted when linguist is used. Therefore, option 2 may be better if you do not consider the hassle.

Thanks for your effort in investigating and reporting. Unfortunately, neither of the options seems considerable to me. I think it's easier for Shiki to align with VS Code as much as possible (so we could count on the VS Code team to make sure the grammars are up to date and well maintained).
It would be hard to take action about grammar on our side, as Shiki is about the highlighter, and we can't take care of all grammar for different languages.
I suggest you forget about the grammars Shiki has builtin for a moment. Instead you could provide your own grammars as documented https://shiki.style/guide/load-theme, to use another grammar one or fork your own - until VS Code fixes it and get synced down to Shiki.
Thank you.

Thank you for your kind response. I will use custom grammar.
For others who are interested in this issue: I created a project that automatically patches the VS Code grammar to generate a custom grammar for shellsession. If you need it, you can use it from here: https://github.com/Robot-Inventor/shell-session-syntax/


Add the supported platform slaves and who contributed them

Again this might be more a of openjdk-website issue - people will want to know where the binaries are built and it'sa nice shout out to say who's helping out!

Yep, can go on the openjdk website, or the adopt wiki.  I'd argue that it is not interesting enough to users to feature on the adoptopenjdk (a.k.a. getopenjdk) website.

started doing that here: https://github.com/AdoptOpenJDK/openjdk-build/wiki/Build-Machines

Related to #14

@gdams Did that wiki page get moved or did it ultimately become https://github.com/AdoptOpenJDK/openjdk-infrastructure/blob/master/ansible/inventory.yml?

The output of Configure should hopefully do the trick + some extra Meta info from infra

@karianna Do you feel this feature would this feature would be better placed on the website or wiki? I'm not sure where to raise a follow up issue for this

I think having the output of configure in the metadata of the build would actually be a good thing.  That way it would be automatically accessible from the API/Website as well (since we already expose that file - I think)

Follow up https://github.com/AdoptOpenJDK/openjdk-website/issues/740

I'm reopening this as I the Add java version and configure to VersionInfo #1918 PR closed this (but is not related).  We still need to actually push the results of the configure step into the meta data file

actually push the results of the configure step into the meta data file

Shouldn't that be done on the API side? Unless you are wanting the configure_args & java version to be in the metadata and not the VersionInfo?

I'm thinking in the metadata yes.  I'm not sure that our API should be returning that info directly.  Probably worth a discussion in the build channel


more "how to ask" notes

From R inferno:

help.request() is an interactive helper
it points to this seemingly defunct page: https://www.r-project.org/posting-guide.html (now supplanted by https://www.r-project.org/help.html ) -- have a look to see if there's anything useful. it then points to a sequence of other internal links worth reviewing
suggest waiting, reading from perspective of answerer, adding missing info

help.request itself doesn't look worth recommending, though... it asks if i want to update R and when i say no, finds a CRAN mirror for me... um, thanks.

Nice example of how to debug (read docs, pare down the code into the simplest form where the "problem" is still visible): https://stackoverflow.com/a/54695131


[feature] Disassembler machine

Will disassemble GC machines, rockets, rowers back to parts.
Configurable option - recipe loss (%), means how many resources will get back by disassembling
Configurable white/black lists of supported items

GC has deconstructor already


Fix for release build failing due to SDK version incompatibility

Fixes #10. Also includes update that ensures data and type set correctly.
All credit goes to @Momazo7u7 and @sugardave

@poberwong, any chance you can take a look at this?


Validate options passed to DatabasePlumber#inspect

It's very easy to pass minor typos like ignored_adapter instead of ignored_adapters without meaningful feedback.
Validation of the options being passed, along with echoing configuration to the user in output would provide a hint when debugging config.

You need to close this issue ;)


Wrong firmware version in status page

Hi. First of all congratulations for your awesone work! This project is absolutely brilliant.
In the last 2 firmware versions the number showed in the status page is wrong. It is not a big bug but it creates some confusion after upgrade.

Thank you, i will fix this once for all. It is bothering me, too.


UPDATE: prysm docker image

Prysm: https://github.com/prysmaticlabs/prysm/releases/tag/v3.1.1

wrong branch, my bad :)


Revert redirect to development setting

Marko, could you please update the Yoti app so the redirect goes to the local file?

Done 👍


 Why are there two versions of esbuild now?

I've gone ahead an regenerated the lockfile and pushed 548340c32ccdbb157918c5308feacc426d832726. This looks good to me now. We still have mrmime@1 in the tree, but it looks like that's unavoidable until worktop upgrades.

I just pushed the same change because I saw your first comment and not your second yet. I don't know why pnpm does screwy things when you run pnpm update...

This looks good to me now.

Ok, I'll go ahead and merge then


Deploy Packet aarch64 OpenStack

We currently have 3 large aarch64 machines from packet. If we install openstack then we can split this down and get a better test coverage.
I am working with @vielmetti to deploy https://github.com/WorksOnArm/OpenStackWorksOnArm

openstack deployed http://<IP_ADDRESS>/horizon/

Discussion of the details of OpenStack configuration going on in the Packet community Slack channel, which is also IRC Freenode #packethost .

Waiting for an IP address allocation from Packet to provide public IPs for the VMs.

IP's are now allocated.

We appear to have run into https://bugs.launchpad.net/cloud-images/+bug/1573095 to get Ubuntu images up and running.

Hi @vielmetti Have we been able to progress this?

Hi @karianna - the report from the bug report is "if i add a serial console to the VM it boots fine.".
@gdams I'm ready to help tackle this to the best of my ability if it's still an issue.

hi @vielmetti it is still an issue for me. I was going to try and spend a bit more time on it next week as it's been on the backburner for the last week

alerting @edolnx to this (and also via email) for next week.

closing for now as we've got some openlab machines


Implement server-side support scripts to reduce network calls

On sites with large amounts of files, requesting each one can be taxing on the client.  Since server-side scripts are necessary for some bot traffic, implement a helper to help with this.

Preliminary results:
before (52 requests, 396KB, 398ms):

after (12 requests, 336KB, 268ms):


module 'AWSS3' was not compiled for testing

Describe the bug
Running into error module 'AWSS3' was not compiled for testing when running xcodebuild in our CICD pipeline.
Steps To Reproduce
Build the app in CICD pipeline using fastlane to run xcodebuild

Expected behavior
Expects to build the app archive, but fails to build, pointing to the usage of the @testable attribute as the cause of failure.
Amplify Framework Version
2.41.0
Amplify Categories
Storage
Dependency manager
Swift PM
Swift version
5.8
CLI version
12.11.1
Xcode version
16.0
Relevant log output
[15:06:56]: ▸ [AWSS3StoragePlugin] Copy AWSS3StoragePlugin.modulemap -> AWSS3StoragePlugin.modulemap
[15:06:56]: ▸ ::error file=/Users/runner/Library/Developer/Xcode/DerivedData/*****/SourcePackages/checkouts/amplify-swift/AmplifyPlugins/Storage/Sources/AWSS3StoragePlugin/Dependency/UploadPartInput+presignURL.swift,line=8,col=18::module 'AWSS3' was not compiled for testing
[15:06:56]: ▸ @testable import AWSS3

Is this a regression?
Yes
Regression additional context
2.40.0 works fine, issue introduced in 2.41.0
Platforms
iOS
OS Version
iOS 18 / macOS 15.0
Device
iPhone 15 Pro
Specific to simulators
No response
Additional context
No response

I was going to raise the same issue, glad to see it has been fixed. Thanks Amplify team

Fixed in release v2.41.1


Bump maven-enforcer-plugin from 3.0.0-M3 to 3.0.0

Bumps maven-enforcer-plugin from 3.0.0-M3 to 3.0.0.

Commits

b1b2282 [maven-release-plugin] prepare release enforcer-3.0.0
70de3ad Lock maven-jxr-plugin
da3f888 Fix JavaDoc and lock sisu-maven-plugin
014253f update CI url
5409be8 [MENFORCER-211] wildcard ignore in requireReleaseDeps
335f26e [MENFORCER-364] requireFilesExist rule should be case sensitive
faaf5c1 [MENFORCER-280] Enforcer dependency convergence stumbles on selenium-java
ab53fd9 [MENFORCER-357] RequirePluginVersions not recognizing versions-from-properties
1b8ca8f [MENFORCER-388] Extends RequirePluginVersions with banMavenDefaults
ca73329 [MENFORCER-359] RequirePluginVersions fails when versions are inherited
Additional commits viewable in compare view

API change check for com.azure:azure-core
API changes are not detected in this pull request for com.azure:azure-core

API change check for com.azure:azure-core-amqp
API changes are not detected in this pull request for com.azure:azure-core-amqp

API change check for com.azure.spring:spring-cloud-azure-core
API changes are not detected in this pull request for com.azure.spring:spring-cloud-azure-core

API change check for com.azure:azure-core-http-netty
API changes are not detected in this pull request for com.azure:azure-core-http-netty

API change check for com.azure.spring:spring-cloud-azure-trace-sleuth
API changes are not detected in this pull request for com.azure.spring:spring-cloud-azure-trace-sleuth

API change check for com.azure:azure-core-http-okhttp
API changes are not detected in this pull request for com.azure:azure-core-http-okhttp

API change check for com.azure.spring:spring-messaging-azure
API changes are not detected in this pull request for com.azure.spring:spring-messaging-azure

API change check for com.azure:azure-core-serializer-avro-apache
API changes are not detected in this pull request for com.azure:azure-core-serializer-avro-apache

API change check for com.azure.spring:spring-messaging-azure-eventhubs
API changes are not detected in this pull request for com.azure.spring:spring-messaging-azure-eventhubs

API change check for com.azure:azure-core-serializer-json-gson
API changes are not detected in this pull request for com.azure:azure-core-serializer-json-gson

API change check for com.azure.spring:spring-messaging-azure-servicebus
API changes are not detected in this pull request for com.azure.spring:spring-messaging-azure-servicebus

API change check for com.azure.spring:spring-integration-azure-core
API changes are not detected in this pull request for com.azure.spring:spring-integration-azure-core

API change check for com.azure:azure-core-test
API changes are not detected in this pull request for com.azure:azure-core-test

API change check for com.azure:azure-core-tracing-opentelemetry
API changes are not detected in this pull request for com.azure:azure-core-tracing-opentelemetry

API change check for com.azure.spring:spring-cloud-azure-autoconfigure
API changes are not detected in this pull request for com.azure.spring:spring-cloud-azure-autoconfigure

API change check for com.azure.spring:spring-cloud-azure-actuator
API changes are not detected in this pull request for com.azure.spring:spring-cloud-azure-actuator

API change check for com.azure.spring:spring-cloud-azure-actuator-autoconfigure
API changes are not detected in this pull request for com.azure.spring:spring-cloud-azure-actuator-autoconfigure

API change check for com.azure.spring:spring-cloud-azure-stream-binder-servicebus-core
API changes are not detected in this pull request for com.azure.spring:spring-cloud-azure-stream-binder-servicebus-core

API change check for com.azure.spring:spring-cloud-azure-stream-binder-servicebus
API changes are not detected in this pull request for com.azure.spring:spring-cloud-azure-stream-binder-servicebus

API change check for com.azure.spring:spring-cloud-azure-stream-binder-eventhubs
API changes are not detected in this pull request for com.azure.spring:spring-cloud-azure-stream-binder-eventhubs

API change check for com.azure.spring:spring-cloud-azure-stream-binder-eventhubs-core
API changes are not detected in this pull request for com.azure.spring:spring-cloud-azure-stream-binder-eventhubs-core


Localise Zero Trust Architecture in hindi

Zero Trust Architecture is not in hindi
https://glossary.cncf.io/zero-trust-architecture/
Assign me to work on it

can I work on this issue?

This issue is a duplicate of #1354.

closing since this is a duplicate PR. Issue for zero-trust architecture is already being worked on and a PR is under review


demo runner: BLE isn't a valid network for demos if IOT_BLE_ENABLE_MQTT==0

Description
As a suggested fix for issue #1281, I have wrapped certain parts of iot_demo_freertos.c in #if BLE_ENABLED && (IOT_BLE_ENABLE_MQTT == 1) checks.
Checklist:

[ ] I have tested my changes. No regression in existing tests.
[ ] My code is Linted.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Closing this PR as the fix for #1281 is not required.


Clarify that Publish* properties can make apps not debuggable by default

Context: https://github.com/dotnet/runtime/issues/45382#issuecomment-968600238
dotnet publish with various Publish* properties can make an app not debuggable. However, some people use publish as part of their workflow.
This applies to:

PublishSingleFile
PublishAot

There are two approaches to resolving this:
<PublishSingleFile Condition="'$(Configuration)' == 'Release'">true</PublishSingleFile>

or (something like)
<PublishSingleFile Condition="'$(FinalBuild)' == 'true'">true</PublishSingleFile>

We should do the following:

Ensure that Native AOT and Single File docs cover debugging UX / expectations.
Document the pattern for making Publish* properties opt-in (with one or both of the patterns above) with dotnet publish in the publish docs.
Link between the pages.

@hoyosjs @agocke @jkotas @samsp-msft

Singlefile should be debuggable shortly (in a preview of VS). Still worth adding the disclaimer to the docs that it's supported only on 7+

Are there files that need to be copied by the app? I saw mention of that somewhere.

7+ should not need anything - 6 is more of a manual thing but I believe the workflow is somewhat transparent to the user.


fp16_speedup

PR from this issue
https://github.com/open-mmlab/mmdetection/issues/2131

Thanks! Could you fix the linting error?

@hellock I found some bug in the code.
My torch version is '1.3.1+cu100' and it cause problem in line
https://github.com/rydenisbak/mmdetection/blob/fp16_speedup/mmdet/core/fp16/hooks.py#L100
torch_version = [int(v) for v in torch.__version__.split('.')]

We need to change it, for example like this
torch_version = [int(v) for v in torch.__version__.split('.') if v.isdigit()]

or like this
torch_version = [int(v) if v.isdigit() else int(v.split('+')[0]) for v in torch.__version__.split('.') if v.isdigit()]

or like something else

Oh the pytorch versions installed by pip and conda are different. Maybe simply
torch_version = [int(v) for v in torch.__version__.split('.')[:2]]

ok, good


Fixed #35841 -- Re-enabled support for DB-IP databases in GeoIP2.

Trac ticket number
ticket-35841
Branch description
Support for DB-IP Lite databases added in ticket-33442 has regressed. This pull request avoids using str.endswith() in favour of a simple in check again, but now encapsulated in .is_city and .is_country properties.
In addition, a new SUPPORTED_DATABASE_TYPES global set of supported databases is added which provides a place that can be monkey patched should other database types be required as long as they are broadly compatible with the structure of data provided by MaxMind and DB-IP.
I have managed to create a cut-down version of the DB-IP Lite databases as they do not provide sample/test databases themselves as MaxMind do. This took quite some effort 😓
Checklist

[x] This PR targets the main branch.
[x] The commit message is written in past tense, mentions the ticket number, and ends with a period.
[x] I have checked the "Has patch" ticket flag in the Trac system.
[x] I have added or updated relevant tests.
[x] I have added or updated relevant docs, including release notes if applicable.
[x] I have attached screenshots in both light and dark modes for any UI changes.

@HomingHamster could you please test this branch and confirm if this restores the support for DB-IP Lite databases?

Strange that the test suite seems to be stuck, but apart from that, the patch looks very good. Thanks a lot!

Jenkins had a lock on the git repo, I wiped workspaces and I think CI is unblocked. I have pushed a small commit rewording to re-trigger the full run.


Restart method

Do a restart method. Just keep a copy of the initial jmp_buf for the child and use it instead of the normal one.

Absorb into #6


Allow algorithm to be a class

This PR improves the algorithm handling on both encoding and decoding:

Support for passing custom algorithms to handle the signing and verification of tokens
When decoding the role of the alg header is minimized to only be required and value used to sort the given algorithm array.

I'll cleanup things and come back to this in another PR.


Operational Error When Silk Is Used On Big SQL Queries

What
Keep trying the _process_response until it works. It tends to fail with big MySQL queries.
Why
MySQLdb specifically does not manage the connections and will error if you try to reuse a stale connection. One that has closed or expired. You need to explicitly check for this error case and handle it. This PR excepts the OperationalError whenever the silk middleware has to processs a relatively large query in it's _process_response.

@avelis we can discuss on where I put the try catch and maybe think about moving it somewhere closer to the actual cause so we don't mask any other errors. Let me know your thoughts.

@hanleyhansen Could there ever be a scenario where you could get forever stuck in the while loop? I will likely merge but wanted to poke any holes at it before I did.
I terms of placement. I think it's fine.

@avelis straight from the MySQL docs

This exception is raised for errors which are related to MySQL's operations. For example: too many connections; a host name could not be resolved; bad handshake; server is shutting down, communication errors.

So the only way we can get stuck in a loop forever is if the DB server goes down. At the point the person has a different problem though. Too many connections will keep trying and tell there are some available connections. Communication errors, same thing. Other stuff will break before silk gets stucked in a loop forever. Otherwise just catching OperationalError and AttributeError should be safe within the while True: loop.

@hanleyhansen Thanks for the contribution and providing a solution for this scenario!


add benchmark for scrolling very long pictures

This benchmark will track the performance of the RTree implementation to cull very large pictures down to just the portion visible on the screen.

We should have probably added this benchmark back when we fixed https://github.com/flutter/flutter/issues/92366 by adding RTrees to DisplayList in https://github.com/flutter/engine/pull/38429 so that we could track a number of changes that were made to the code - some potentially positive, some potentially regressing.
In particular, I recently ran a local copy of the benchmark from https://github.com/flutter/flutter/issues/92366 and discovered that not only had we lost almost all of the gains, but the app now takes up to 20 seconds to draw its first frame. The root cause is an oversight in an old PR that added fine-grained bounds when drawing one DL into another in https://github.com/flutter/engine/pull/37451 and any case that would cause such a DL -> DL recording. At the time it was added, there weren't any cases where we might do that, but in the intervening time we've added a couple of cases.

Impeller has been rendering layer trees by recording the whole tree into a tree-wide DL. If there is a DLLayer that has a very large DL in it, we will iterate over a large number of operations that might not even pass the culling into the frame-sized tree DL.
Embedders have been recording parts of a tree into DisplayLists using the DisplayListEmbedderViewSlice

When these things happen for the test case mentioned above, 300,000+ drawline calls, that all overlap are iterated and consolidated into a single rectangle somewhat quadratically causing a huge regression.
Some work is being done that will reduce some of these cases, including:

Impeller is switching over to a direct implementation of DlCanvas for rendering the layer tree which will avoid recording a huge DL into another.
@knopp recently modified the consolidation of rectangles to use a DlRegion object which greatly improved its performance, but still doesn't help as much as simply reducing the culling rect to use to iterate the bounds when we are transferring them from one DL to another.

After this benchmark lands, I will be landing a 1-line fix for the biggest cause of the regression here - the fact that iterating the rtree bounds inside DlCanvasToReceiver does not provide the cull rect. (see https://github.com/flutter/flutter/issues/133437)
We should also consider punting on the fine grained bounds for some DisplayLists, particularly if they contain quite a lot of rendering calls. (see https://github.com/flutter/flutter/issues/133436)


MariaDB Timewalking

There is a possibility to enable "timewalking" for my Database.
That means that i can make queries "SELECT * FROM player_details AS IT WAS 2016".
That´s an awesome feature and I want it!

https://modern-sql.com/blog/2018-08/whats-new-in-mariadb-10.3#3.system-versioned-tables
That´s the idea

Actually this is one of the very best ideas I had this week:
With the system versioned db it´s super easy to make a diagram of progress.
that is so awesome!

https://mariadb.org/wp-content/uploads/2017/04/As-Of-Tech-Feature-Overview.pdf
More Sources

http://cs.ulb.ac.be/public/_media/teaching/infoh415/tempfeaturessql2011.pdf
Real Paper on this feature


macOS batch image creation

Adding a new batch image creation feature as requested in https://github.com/huggingface/swift-coreml-diffusers/issues/52
note: That there is a missing requested feature.
This PR generates a batch of images.
This PR does NOT yet have the following features:

select one of the images to share individually (it shares the first generated image)
define the seed that was used for each image in the batch
use a starting seed and increment by one for each image in the batch

It DOES serve as a starting point to view the results of multiple images generated in a batch on macOS.

@pcuenca please do not process this PR yet. I'm going to roll back the Path.swift application support folder issue and move that into its own separate PR. It should be more clearly called out what the issue was in its own thread..

@dolmere How is this progressing? I think it's a great idea, especially for the longer inference times of SDXL, it would be nice to get some parallelization going

It's not parallel operations (yet) it's just a larger batch operation run serially. You can pull the PR's code and run it to see how it's intended.
I'm keeping it aligned with the latest additions as they go but it's too big a PR on its own. I'm trying to pull discreet pieces out of this and local models loader. It's slow going for sure but it's the right way to try to ensure that each change is well documented and reviewed.
Getting DiffusionImage in separately will allow me to pull copy/paste out of this PR and get this a bit closer to coming out of draft.


For vertical (vertical) pictures in the document, mouse clicks cannot zoom in, but zoom out further

Thank you for a great theme!
Have a question about using this theme?
For vertical (vertical) pictures in the document, mouse clicks cannot zoom in, but zoom out further, which should be a wrong behavior.
System: Windows 10
Obsidian: 1.3.5
Theme Version: Latest

For vertical (vertical) pictures in the document, mouse clicks cannot zoom in, but zoom out further, which should be a wrong behavior.

Hello there! This is most likely not a wrong behavior, this feature scales (zoom in/out) the image to the container size, not zoom in image at all times, it comes directly from kepano's Minimal theme. I'm not sure about the possibility of zoom in images at all times.

There should be a limit judgment. If the image cannot be enlarged, then the original size of the image will be maintained. In short, it cannot be further reduced. You can also use vertical (portrait) images to try to see the actual effect.

I've tried it before and can confirm that it's not a wrong behavior, the image zoom function doesn't zoom in on the image, it just scales the image to the container size. Regarding what you describe, I'm not sure it can be implemented in a CSS theme. Maybe you can implement it with a plugin, like image toolkit

This plugin is misbehaving

That's weird, it works fine in my environment. Maybe you can go to the plugin repository and submit an issue to fix the problem

Many people have submitted issues, the plugin has not been maintained for a long time

Oh, it seems so. There shouldn't be much I can do about it.

Your theme is great! It's just that Obsidian runs slowly sometimes. . .

Thanks, I'll try to improve it


Update AAD Token V2

Add Method for GET AAD Token for Azure AAD OAuth V2 by replacing resource to scope

https://github.com/microsoft/ABAP-SDK-for-Azure/pull/94 handles the 2 issues with OCCURS

There're some services like Service Now that require Azure AD Connect V2.0. Currently, this SDK only support V1.0 so I create the new method and change a few parameter from resource (v1) to scope (v2).

Need to redefine and add some enhancement so decide to close the PR for now.

@larshp Hi Lars Hvam,
Is it possible to merge this PR into main branch ? Currently many service required AAD Token version 2 and changes include

Clone Get AAD Token method
Change Parameter name from resource -> scope.
Or if there are anything I have to provide can you give me a suggestion?
Best Regards,

I dont have access, I'm not a maintainer of this repo

Thanks @kritchaponc for making contribution to the Repo.
Instead of changing the code and changing the Resource to scope.  you can setup RFC connection with OAUTH2 URL and ZCL_ADF_SERVICE_AAD~GET_AAD_TOKEN will be the token.
Please let me know if you have any other thoughts.


[FEATURE] Add Provisioning w/Terraform

Add the ability to provision a test cluster to AWS. This step will do the following:
Provision the following instances as a cluster

Ansible controller VM
Pulsar cluster VMs
PulsarClient VMs

Playbook / Role to deploy the controller

Ansible and dependencies
Pulsar and dependencies for JWT
OpenSSL
Pulsar-ansible including a hosts file generated by terraform
(optional) and NB framework.

To work on and test your clusters you will ssh using a key that you create and that will be a gateway to your test cluster. The user will be able to choose what test framework to install.

For reference, this is the bash script: https://github.com/datastax/pulsar-ansible/blob/a16bd34/bash/buildAnsiHostInvFile.sh.


Lots of packages rebuilt but only few installed

Hello,
I'm on FreeBSD 13 and using Synth to keep my system up to date. However, today I've noticed something that I perceive as unwanted behavior. However, by looking at threads over at FreeBSD forum, I see you, @jrmarino, are saying that it's normal.
So, the situation is the following:
I've issued portsnap fetch update and then synth upgrade-system. It re-built lots of packages and then installed lots of packages. I didn't pay attention for some inconsistencies. Everything went smoothly after several hours.
However, by mistake I've issued the portsnap command yet another time after the update and it updated few ports. I said, OK, today I'm updating everything, let's do another round of  synth upgrade-system, it's only few ports that were updated, so it should be harmless. Unfortunately, one of these ports was consolekit2 which were required by pulseaudio, which in turn was required by KDE. So, ~250 packages were rebuilt (of them qt-webengine... :( , anyway...).
To my surprise, though, after the rebuilt of all these packages, only 1 (!!!) was updated by pkg. The question is why just one package was installed? And why then I had to wait several hours to re-build packages that were not gonna be installed?
I know that github issues is not the place for discussion topics but, at least, here I know that my chances of getting answered are greater. Additionally, I think that many people will find the explanation valuable.

So the key here is that 2 different program are involved.

synth - used to build local repositories based on the current ports tree
pkg - used for package maintenance based on the local repository created by synth

You are noticing that pkg decides that only one package requires reinstalling.
There are lots of things pkg considers for this - libraries provided (changes), libraries required (changes), revision updates, dependency changes, option changes, etc.
Synth and poudriere have a completely different approach.  essentially if a dependency is determined to require a rebuild (new version, new option, new revision, missing dependency, etc) it is removed.  Once it's removed, everything that requires it is immediately removed.  that causes a chain reaction of removals.  The majority of the rebuilt packages might be equivalent to what's removed, which is why pkg doesn't think it needs to be reinstalled.
so are poudriere and synth rebuilding hundreds of packages that don't technically need it?  You could argue that, but the final repository will be perfect, but if somebody tried to implement a very complex algorithm to only selectively rebuild packages (probably in multiple passes!) there would likely be edge cases nobody anticipates and the final repository would have errors.
does this explanation help at all?


Add process supervisor tool

The snmpsim-supervisor tool is watching specified directory
for executable files to appear there. Once new files pop up or
existing files modified, the supervisor tool will start or restart
the processes from these executable files. If an executable file
gets removed from the watched directory, corresponding process
will be terminated.

Attn: @zatroa - this pair of tools (snmpsim-restapi-server and snmpsim-supervisor) should bring basic remote control features.


Spatial editor's view settings aren't applied immediately after changing them

Godot version: Git https://github.com/godotengine/godot/commit/e8ff602381edc2bf8ba56de85b50c275c17f9a0c
OS/device including version: Fedora 27
Issue description: The spatial editor's view settings aren't applied immediately after changing them, or even after clicking the Close button of the Settings dialog. Changes will be displayed only once the editor camera is moved by the user somehow, even if the editor update mode is set to Update Always.
Steps to reproduce: Switch to the editor's 3D view, go to the View → Settings menu at the top of the 3D viewport, adjust FOV/Z-Near/Z-Far values then close the settings menu. The displayed values won't change until the editor camera is moved somehow (for instance, by looking around or zooming).

@MelvinWM
Hey, for this issue, should we also add a refresh button for this one?

I can confirm this issue is still present in https://github.com/godotengine/godot/commit/cdcdba704b989aa9d7decc40d3181f8378378512, by the way.
@Amssat221 It would be better to fix the original issue rather than adding a Refresh button (which would be a workaround that makes the GUI more complex).

@Amssat221 I agree with @Calinou , it makes sense to add a button in the other issue reg. editor settings, since the editor settings there cyclically affects the GUI for the editor settings themselves, while that is not the case here. I imagine a good solution might be to instruct the 3D view to update or similar when pressing OK or exiting and saving the settings some other way.
(as a side-note, pressing 'Cancel' in the settings for the 3D view after making some changes seemingly still applies the changes as seen when zooming in or out, instead of having the changes dropped, which seems wrong).

I will work on that. Thanks
Le ven. 5 avr. 2019 à 12:27, MelvinWM<EMAIL_ADDRESS>a écrit :

@Amssat221 https://github.com/Amssat221 I agree with @Calinou
https://github.com/Calinou , it makes sense to add a button in the
other issue reg. editor settings, since the editor settings there
cyclically affects the GUI for the editor settings themselves, while that
is not the case here. I imagine a good solution might be to instruct the 3D
view to update or similar when pressing OK or exiting and saving the
settings some other way.
(as a side-note, pressing 'Cancel' in the settings for the 3D view after
making some changes seemingly still applies the changes as seen when
zooming in or out, instead of having the changes dropped, which seems
wrong).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/18430#issuecomment-480338601,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AoGDY3-YIBDSYMxdmwjKm8KsYw7o9RL9ks5vd3llgaJpZM4TkQq4
.

@Calinou, I went over the problem of the cancel button not working and it makes me believe that the issue is related to ConfirmationDialog in dialogs.cpp. Could you please confirm it


Integrating OAI evals post training

This PR switches our end of training evaluations to use the OpenAI evals framework.

Here's an example task which barely does any training, but does the evaluation (assuming this PR is merged): https://wandb.ai/fixie/ultravox/runs/nxgfzg3v

Not required for this PR, but it looks like wandb has some basic support for handling oaieval outputs, including sample-by-sample visualization, maybe if we can log to the right format we can get this visualization too: https://wandb.ai/wandb_fc/openai-evals/reports/OpenAI-Evals-Demo-Using-W-B-Prompts-to-Run-Evaluations--Vmlldzo0MTI4ODA3

example wandb oaieval run: https://wandb.ai/wandb/jobs/runs/ugqqpjff?nw=nwuser_scott

Justin using wandb.Table was a great idea. It shows all metrics in one table and also allows us to automatically create charts from them.
The charts from multiple experiments can also be stacked, even if they only match partially.


Typesense scout import fails in Laravel 11

Description
My php artisan scout:import fails for large datasets in Laravel11. This issue is not seen with smaller dataset. May be less than 500.
Steps to reproduce
There is no issue when I was on Laravel 10. When I migrated to Laravel 11.X, this issue is seen.
Steps to reproduce:

Create a table with larage data. May be 5000 or 10000.
Do follow the steps of creating toSearchableArray() and Collection as per documentation.
Use "php artisan scout:import "App\Models\YourModel"
You will see error saying record already exist.
On typesense server you will find first batch of initial 500 records already indexed.
So while attempting next batch of index, it is not able to recognise the difference and hence considers documents alre

Expected Behavior
I should get my documents in batches. Atleast in my case it has been always in a batch of 500 documents.
Actual Behavior
I see only first 500 documents indexed but in next batch index it fails saying collection already exists. In laravel10, this was perfectly fine.
Metadata
Typesense Version: 0.26
OS: Ubuntu 22.04

Duplicate of https://github.com/laravel/scout/issues/822#issuecomment-2062750035
Let's continue the conversation in the other issue.


android 混合开发 ，不能自动生成JsonConvert

点击 Build -> FlutterBeanFactory 提示
This project is not the flutter project or the flutterJson in pubspec.yaml with the enable set to false

建议加群 我没玩过混合开发  963752388

点击 Build -> FlutterBeanFactory 提示
This project is not the flutter project or the flutterJson in pubspec.yaml with the enable set to false

咋解决的啊

点击 Build -> FlutterBeanFactory 提示
This project is not the flutter project or the flutterJson in pubspec.yaml with the enable set to false

咋解决的啊

已解决。 打开的项目根目录需要是lib的上一层，然后执行alt+j


UnhandledPromiseRejectionWarning: Error: The request is missing a valid API key.

Though I'm providing correct project id, it is saying invalid api key

@sutriptaroy what environment are you running @google-cloud/translate in? and would you be able to provide some sample code for how you're initializing the client?

Greetings!  If this is still an issue, and you can provide some sample code - please do let us know!


zino1 protocol: parameter case-sensitive inconsistencies with tcl implementation

In the original zino implementation there are a few parameters that use upper-case characters in their names.
Zino2 does not take this into account and only uses lowercase parameter names
This makes the original x11 ritz client crash because it is case-sensitive on its parameter names.
This is identified for the following parameters:
BGP:

bgpAS
bgpOS
remote-AS

BFD:

Neigh-rDNS
bfdAddr
bfdDiscr
bfdIx
bfdState

PR #335 is tested with the  x11 tcl ritz client and seems to work fine

This is related to #281


Draft: remove patches in favor of upgrading the upstream packages

cleaning up PR here

oops sorry, meant to do this in my fork. ignore please


feat: Compile TypeScript and Implement Dynamic Addition of WebView Sidebar Icons

Pull Request Template
Type of PR

[x] Feature - Platform
[x] Feature - Game
[ ] Fix - Bug

Description of PR

A TypeScript to JavaScript compilation process
The implementation of dynamic logic to add icons to the WebView sidebar.

https://github.com/hp-potion/vsc-gameboy/assets/22022776/9f3af345-c040-47a7-9987-a70481242b74
Changes Made

Developed and integrated a TypeScript to JavaScript compilation workflow
Engineered dynamic logic for adding icons to the WebView sidebar

Testing Method

Related Issues

Checklist

[x] Prepared for code review (Assignees set, Labels applied, etc.)
[x] Checked that changes do not negatively affect existing features
[ ] Documentation completed for new features
[ ] All unit tests passed
[ ] Testing in the test environment completed
[ ] Linked this PR in the related issue
[x] Communicated sufficiently with the relevant team or person before submitting PR

Well done.
I have sent an email to Mr.Karen, owner of js-tetris repository for a permission.

Thank you for your efforts.

funtion is good

Well done. I have sent an email to Mr.Karen, owner of js-tetris repository for a permission.


OpenAI Readme Issues

Section link1, link2

Reason:
AzureKeyCredential is not defined.
Suggestion:
Import AzureKeyCredential from package @azure/openai.

Section link1, link2

Reason:
DefaultAzureCredential is not defined.
Suggestion:
Import DefaultAzureCredential from package @azure/identity.
@joheredi, @deyaaeldeen for notification.

The issue has been addressed in the PR above


[Bug]: dest property instead of swDest in WebpackInjectManifest

Provide environment information

@serwist/next: 8.3.0
@serwist/sw: 8.3.0
next: 14.0.4
react: 18.2.0
react-dom: 18.2.0
webpack: 5.89.0

Which project is this issue for?
@serwist/next
Link to reproduction - Issues with a link to complete (but minimal) reproduction code help us address them faster
NA
To reproduce

yarn init -y
yarn set version berry
yarn add next react react-dom @serwist/next @serwist/sw webpack
create empty pages folder
create next.config.mjs

import withPWA from '@serwist/next'

const isDev = process.env.NODE_ENV === 'development'

const nextConfig = {}

export default withPWA({
  dest: 'public',
  disable: isDev,
  cacheOnFrontEndNav: true,
  swSrc: 'app/sw.js',
  swDest: 'public/sw.js'
})(nextConfig)

yarn next build

   ▲ Next.js 14.0.4
   - Environments: .env

 ✓ (serwist) Compiling for server...
 ✓ (serwist) Compiling for server...
 ✓ (serwist) Compiling for client (static)...
 ○ (serwist) Service worker: C:\<PROJECT_NAME>\public\sw.js
 ○ (serwist)   URL: /sw.js
 ○ (serwist)   Scope: /
Failed to compile.

Please check your InjectManifest plugin configuration:
[WebpackInjectManifest] 'dest' property is not expected to be here. Did you mean property 'swDest'?

Cannot read properties of undefined (reading 'source')

Describe the bug
The build phase fails with error:
Please check your InjectManifest plugin configuration:
[WebpackInjectManifest] 'dest' property is not expected to be here. Did you mean property 'swDest'?

Cannot read properties of undefined (reading 'source')

The error should be related to InjectManifest of @serwist/webpack-plugin.
Expected behavior
Build is completed with no errors
Screenshots (if relevant)
No response
Additional information (if relevant)
No response

Remove dest: "public". It is no longer a valid option.
Full list of changes between<EMAIL_ADDRESS>and<EMAIL_ADDRESS>are listed here.

Worked, thanks!


Consider support of exactOptionalPropertyTypes flag

Here it's about the difference of { a: undefined } and {}
I'm not sure if we need to do anything here, but there can be issues regarding setting or not this flag in the future
Issue for strictOptionalProperties – https://github.com/microsoft/TypeScript/issues/44604
It's now named as exactOptionalPropertyTypes – https://github.com/microsoft/TypeScript/pull/44626

I will close it for now as it's stale and no one reported bugs about it


Alternative fix for CVE-2022-24795

This is a "hybrid" of https://github.com/lloyd/yajl/pull/240, https://github.com/brianmario/yajl-ruby/pull/211 and https://github.com/robohack/yajl/commit/166b384aec1cf304859d69f03e42c3ab85c34858
Using abort() to avoid heap corruption/infinite loop while not adding new requirements for clients of this library and/or complex error handling mechanisms.

A long time ago, I have done a ticket:

https://github.com/lloyd/yajl/issues/219


Improve web UI accessibility

There's clearly been an attempt to modernise the web layout from what came before, but in a lot of ways it seems like one step forward, two steps back.
 No indication of page structure, or clickability. If I tilt my laptop screen back so it's horizontal I can see that some of the page is a very light grey, suggesting that "Floating", "LAN", and "WAN" are tabs but that's about it for organization. If I hadn't been using pfSense for years I would have no idea what was going on.
As another example, compare the big bright "add a new schedule" button to the little black + button for adding a firewall rule.
The orange and black is a strong and distinctive colour scheme, let's see it used in the web interface! This isn't just an aesthetic issue; for users with limited visibility the almost complete lack of contrast can cause big accessibility issues. Ditto for the lack of clear functional delineations on the page.

Firewall rules section is being reworked right now. If you can give feedback for opnsense-devel that would be great so we can weave it into the current development efforts:
https://forum.opnsense.org/index.php?topic=1305.0
Accessibility is a broader issue, requiring larger fonts, less intermediate colours and more contrast in general. It might be worth initiating a dedicated theme for that specific purpose?

timeout


quick question:  "--disable-features=IsolateOrigins,site-per-process"

Is there a specific reason why IsolateOrigins and site-per-process are not disabled in puppeteer-real-browser?
Thanks!

Hello, the library is detected when such flags are added. Since it becomes very difficult to detect when the runtime is turned off, bot detection systems now try to proceed through the added flags. When those flags were added, they were not added because the tests failed.


Feat: Make Contact and feedback code responsive.

Describe the feature
I will make contact and feedback form responsive.
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@Its-Aman-Yadav @Kalivarapubindusree Please assign me this task !
It is very important to make forms responsive.
Thank You !


Change buttons to spinner while loading. Componentize buttons. Refact…

…or useResource.
Why was this change made?
So that users know when Sinopia is working.
How was this change tested?
Which documentation and/or configurations were updated?

Yes, error key is being passed around. I think there is an opportunity to refactor in the future, perhaps using a React boundary. (Oh, I like that idea ...)


[ODS-4750]  Migration Support for Change Queries for v3.4 -> v5.0 Upgrade

ODS-4750 is ready now

ODS-4750 is ready now

I think teamcity /Ed-Fi-ODS repo is latest and not match with 5.1.0  tag code . EdFi.Ods.Utilities.Migration.Tests.MigrationTests.all_versions.EdFiOdsVersionJournalTests.MigrationUtilityScriptsShouldBeUpToDateWithCurrentEdFiOdsBuild- That's reason only one test is failing in teamcity.
I took tags/v5.1.0 from Ed-Fi-ODS repo for local and build is green now in my local. Please correct me , I am wrong in my understanding. Thank you!

I think teamcity /Ed-Fi-ODS repo is latest and not match with 5.1.0  tag code . EdFi.Ods.Utilities.Migration.Tests.MigrationTests.all_versions.EdFiOdsVersionJournalTests.MigrationUtilityScriptsShouldBeUpToDateWithCurrentEdFiOdsBuild- That's reason only one test is failing in teamcity.
I took tags/v5.1.0 from Ed-Fi-ODS repo for local and build is green now in my local. Please correct me , I am wrong in my understanding. Thank you!

Build is green in my local

Build is green in my local


Shared github workflows and operator-sdk 1.31

This PR switches the operator to use shared build workflows for building operator, bundle, and catalog/index images.
Additionally operator-sdk is bumped to 1.31. (also includes bump to OPM and controller-gen)
Jira: OSP-29146
Jira: OSP-26858

/test infra-operator-build-deploy-kuttl

/test infra-operator-build-deploy-kuttl

recheck


[CMake]: Use versionless targets from Qt 5.15

in order to facilitate transition to Qt6:
https://doc-snapshots.qt.io/qt6-dev/cmake-qt5-and-qt6-compatibility.html#versionless-targets

In addition to the existing imported targets, Qt 5.15 introduced versionless targets. That is, to link against Qt Core one can both reference Qt6::Core, or Qt::Core

Nice one, have you tried with Qt6 beta yet?
Can you open the same PR for QOlm?
You missed some CMakelists :
https://github.com/OlivierLDff/Qaterial/blob/95b0e8ae9fff157a55b0481ae23583d186c02c18/res/Fonts/CMakeLists.txt#L59-L65
https://github.com/OlivierLDff/Qaterial/blob/1e7ed989b4045a93600d7569a694828817c0eaf3/res/Icons/CMakeLists.txt#L66-L72
https://github.com/OlivierLDff/Qaterial/blob/2c1a9bfc5e44eb6f447f345f2a3cda61661b55e9/tools/HotReload/lib/CMakeLists.txt#L46-L65
https://github.com/OlivierLDff/Qaterial/blob/2c1a9bfc5e44eb6f447f345f2a3cda61661b55e9/tools/HotReload/lib/CMakeLists.txt#L77
https://github.com/OlivierLDff/Qaterial/blob/74d5b8be1c8f8e6c627b09fba2daaf8de5e7c600/tools/HelloWorld/CMakeLists.txt#L35
There is the find_package problem still. But let's first merge the target_link_libraries then the find_package since it seems to require some boilerplate code.
https://github.com/OlivierLDff/Qaterial/blob/2c1a9bfc5e44eb6f447f345f2a3cda61661b55e9/tools/HotReload/lib/CMakeLists.txt#L25

@OlivierLDff I didn't try the beta yet, but i'm thinking about preparing a nice transition and i think the first step is the new target approach.
Yes sorry for the missing files i didn't it through the web github interface i will fix them too

I think it's done for this pr @OlivierLDff

Me in my case I would like to switch to Qt 6 in December, but from what I saw all web modules will not be available in Qt6 so I would need to have Qt5 support
Basically: QtWebEngine QtWebView and so on
So yes we will basically need to have some if conditions to pickup good Qt Version but in your case all the modules that you use in this library are supported by Qt6 (Only web engine is missing i guess)

I would like to use Qt6 as soon as possible to reduce cmake & qml register type boiler plate code.
But same i'm missing the module Multimedia for an application.
I think i will try to build QaterialGallery with Qt6 when it will be available and support both Qt5.15 and Qt6 while Qt5.15 is still LTS.

Yes anyway i'm sure with some boilerplate CMake code we can (in an easy way) have support for both Qt5.15 / Qt6 and even both at the same time just need to investigate a bit

moc is already annoying when mixing qt5 from different version, so i don't think it will support binary compatibility between qt5 and qt6


Missing or wrong labels for certain metrics

Description
Hi, I noticed that for certain metrics either labels are missing or the labels give wrong values.
The following metrics still need labels:
keycloak_logins, keycloak_failed_attempts, keycloak_client_logins, keycloak_failed_login_attempts:
With this metric, it was useful to have the username as a label for understanding where the request is being attempted.
keycloak_response_errors:
With this metric, the realm as a label is missing.

The following metrics has wrong label values:
keycloak_failed_client_login_attempts:
Here has the label "client_id" wrong values.

For the other metrics, the name of the client is set as client_id.
Example:

Expected Behavior
Metrics with the described labels.
Actual Behavior
Labels seem to be missing.
Environment

Spi version: keycloak-metrics-spi-3.0.0
Project Versions: Keycloak 21.1.1

@npriebe adding username to the metric would increase cardinality and afaik it is generally considered poor practice to do that in TSDBs
e.g.
https://grafana.com/blog/2022/02/15/what-are-cardinality-spikes-and-why-do-they-matter

@npriebe did you find any solution ? I find the values as wrong since in every metrics, it's showing me large values (for ex. keycloak_logins_created{realm="xyz",provider="keycloak",client_id="service",} 1.688189803383E9
) for all the clients which doesn't make any sense (considering the amount of requests stats)


Active channels ending in the "disconnected" state

We initially thought this was a deadlock issue, but I'm not so sure. In the list below, there are multiple wires with most counterparties but not with the original seeder (the one that looks like a face, with 196 transactions). George and I noticed this behaviour consistently over multiple browsers.
Hypothesis:

The seeder always has data that I need, so I keep requesting data from them, the torrent wire stays open, and the channel stays alive
Other peers sometimes have data for me, and sometimes don't. When they don't have data for me, I don't request data from them, the torrent wire drops, and the channel is left in a disconnected state.

Possible fixes:

We should handle closing the channel in the case where someone doesn't have data for you for some time. This should happen before the torrent timeout kicks in. This would lead to the channels ending in a closed state, instead of in a disconnected state
In some cases, we might still end up with an open channel without a torrent wire. It's probably worth checking to see if there are open channels with a given peer, in a given direction (send/receive) before setting up a new one. Even if you don't want to reuse these channels, you could use this opportunity to close them. (But we should probably reuse, if we can.)

In some cases, we might still end up with an open channel without a torrent wire. It's probably worth checking to see if there are open channels with a given peer, in a given direction (send/receive) before setting up a new one. Even if you don't want to reuse these channels, you could use this opportunity to close them. (But we should probably reuse, if we can.)

We've decided not to do this in v1, but the work is there in #2004 (george/reuse-channels)

As far as I know we aren't seeing this problem any more.


Cannot get $scope to work ngMaterial directives

Good Morning,
I cannot use $scope from a parent or child controller, with ngMaterial. For example, if I try to use a toolbar directive with $scope.title = "Title" for the brand it will not render. This example failed in the angular-meteor.com tutorial as well. This example works fine out of meteor, with all angular and ngMat versions. Thanks for your help in advance.
Chris

Well, it is probably something very specific to your repo. Material works really well with angular-meteor . here is a demo http://angular-meteor-material.meteor.com/ and the repo is here https://github.com/Tallyb/angular-meteor-material

@zenonn37 please let us know if you found the bug


Add to_int function and tests

Summary
This PR adds a function for casting double and std::vector<double> inputs to int types. This is intended to only be exposed for use with data real and array[] data real types in Stan
Tests
Prim tests added for correctness of return as well as throwing if the input is too large to be represented as an int without overflowing
Side Effects
N/A
Release notes
Added function for casting double and std::vector<double> types to int and std::vector<int> types
Checklist

[x] Math issue #2770

[x] Copyright holder: Andrew Johnson
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

[x] the basic tests are passing

unit tests pass (to run, use: ./runTests.py test/unit)
header checks pass, (make test-headers)
dependencies checks pass, (make test-math-dependencies)
docs build, (make doxygen)
code passes the built in C++ standards checks (make cpplint)

[x] the code is written in idiomatic C++ and changes are documented in the doxygen

[x] the new changes are tested

The Rtools40 mix/fun failures are just the actions hitting the 6hr time limit and being automatically terminated, rather than actual test failures. Given that to_int() isn't touching anything in rev/fwd, and the Jenkins mix/fun tests passed, I'd say that this was safe to approve (and merge after the freeze)


Revert "Bump early operator index to track 4.17"

This reverts commit 5b43cec3754025731508a104be7845966f498497.
This PR has to be re-reverted when the branch cut [4.17] happens

/retest

/lgtm
/approve


Question about the performance on V-COCO dataset

Thanks for your great works!!  :)
Have u ever tried to train the QAHOI on V-COCO dataset? I donot find the results on V-COCO in paper.
If you could give me any help i would be appreciate.Thank you for your help.

We have not yet trained QAHOI on VCOCO, but we provide the training code and evaluation code.

邮件已收到！！


Moving XVP & Ad Framework stuff to 'Firebolt' plugin

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.LaCivita, Jeremy seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.LaCivita, Jeremy seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

I think It makes sense to have XVP stuff segmented, not sure about Ad Framework but maybe.
I dont think the name is right - there is Firebolt stuff elsewhere in the SDK as well so that seems confusing.

I think It makes sense to have XVP stuff segmented, not sure about Ad Framework but maybe.
I dont think the name is right - there is Firebolt stuff elsewhere in the SDK as well so that seems confusing.

Okay, I moved Advertising and Personalization back into Platform via a Profile submodule.
Also took a better (I think) attempt at matching L-SDK style w/ methods that have longer names.

Okay, I moved Advertising and Personalization back into Platform via a Profile submodule.
Also took a better (I think) attempt at matching L-SDK style w/ methods that have longer names.


Fix parquet pruning when column names have periods

Which issue does this PR close?
Closes https://github.com/apache/arrow-datafusion/issues/5708
Rationale for this change
We were seeing wrong results with parquet file that had columns with . in their names
What changes are included in this PR?
Bug fix + test
Are these changes tested?
yes
I also verified that this fixes the issue we saw upstream in IOx https://github.com/influxdata/influxdb_iox/issues/7225#issuecomment-1481809300
Are there any user-facing changes?
bug fix
cc @crepererum

I wonder if we should stop using strings for columns at all to prevent this type of confusion in the future. IIRC this isn't the first bug introduces by it.

For what it is worth, postgres uses all indexes (numbers) as I recall and that has its own set of horrible bugs (when the output indexes get mixed up).


Support for ONNX export

Thank you for the library.
Have you considered adding support for exporting factorized layers (FactorizedConv) to ONNX?

Thanks @mfproto , this is great suggestion. I don't have experience adding layers to ONNX, if you know how to would be awesome if you could start a PR!


end-of-line comments don't get highlighted

a comment at the end of a line inside a JSX component declaration doesn't get picked up and highlighted, see below:

Looks like its a problem of your UI scheme. I can't reproduce it on my Seti UI.

It's a missing rule in the grammar! I'll fix this ASAP.

Hi I'm also having this problem. I'm running the latest 1.16.2 release.

@orktes I'm guessing you became too busy to fix it?
Language selection: Javascript (JSX)
export const FooCt = createContainer(props => {        //working comment
 if (Ninja.face('ninja1', {}).ready()) {               //working comment
  if (dog!==undefined && dog.names) {                  //working comment
   if (Ninja.face('ninja2', {}).ready()) {             //working comment
    if (Array.isArray(myArray) && myArray.length) {    //working comment
     for (let i=0;i<myArray.length;++i) console.log('foo'); //first broken comment. After this the rest will be broken nomatter how far down.
    }        //broken comment /*broken comment*/
   }         /*broken comment*/ //broken comment
  }          //broken comment /*broken comment*/
 }           /*broken comment*/ //broken comment
 return {};  //broken comment /*broken comment*/
}, Foo);     /*broken comment*/ //broken comment

//broken comment

/*broken comment*/

/*
 broken comment
*/

Here's an even simpler example.
The actual grammar problem seems to be related specifically to the for loop.

It's not specific to for loops


run formatter for the first time, fix lint warnings

also added .jshintrc, and made sure for gulp's format to use only 2 spaces instead of the default of 4.

none of the codebase was changed and all of the tests passed. I'm merging this because I'm assuming no one wants to look at the changes that formatting created


Simplify F.batch_renormalization test

Applies the function test case https://github.com/chainer/chainer/pull/3499.
~chainer.Function also needs automatic attribute fallback #5745 for F.batch_renormalization to support ChainerX.~
chainer.Function attribute fallback is implemented in #5828.

@niboshi could you fix the style error importing unittest which is no longer needed?

Oh, fixed.

@hvy Fixed the reviewed points.

Sorry, basically LGTM but I added some minor comments. Could you take a look?

jenkins, test this please.

Jenkins CI test (for commit 33d9fa26a9826404f302807cb7b3843a763dcf27, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

jenkins, test this please.

Jenkins CI test (for commit 6ccfbe807e0f18081a798fe834346888cf66094b, target branch master) succeeded!

LGTM!


Ignoring files

Is it possible to either ignore a list of files or ignore files whose names match a regex?

proof-html currently uses the Nu Validator to check HTML, and htmlproofer to check links.
htmlproofer supports ignoring files by regex: see the ignore_files configuration. proof-html doesn't support this option, but this would be straightforward to add.
Nu Validator, as far as I can tell, doesn't have a convenient way to specify files to ignore (https://validator.github.io/validator/#options).
What's your use case? There might be a simple workaround, e.g., running find ... -delete before running proof-html, if you're doing this in CI and don't need the files that are to be "ignored" (in this case, deleted before proof-html runs).

Thanks for the response, I had some old bootstrap CSS files I didn't want to fix but since that would be under the Nu Validator it looks like I'll have to fix the issues.

You can also ignore CSS altogether, I've done that in one of my projects where I was too lazy to fix the CSS.


Commands which replies -USAGE aren't handled

When executing a command (but just some commands) with the wrong syntax (ex: originate FOOBAR) the reply is neither "+OK" or "-ERR" but instead "-USAGE:". This isn't at all handled (https://github.com/englercj/node-esl/blob/master/lib/esl/Parser.js#L198-L206).
The spec doesn't say anything about that and the API replies aren't really standardised.
I think that we can assume that "-USAGE:" means false for practical reasons.

Closing this since I haven't heard anything in a while. Let me know if I need to reopen.


Add someone to GitHub

If you want to be able to assign bugs to someone, they only need Read access.
Please include:

GitHub ID to add: @joaniefromtheblock
Project to be added to: Besu

One of:

Team to be added to: Besu Docs Maintainers
Role:

Read
Triage
Write
Manage
Admin

See https://github.com/hyperledger/besu-docs/pull/1507 for the approval to add @joaniefromtheblock to the Besu Docs Maintainer list.

invite sent!


[WIP] Implement GaussianNB

@morenol is this PR ready for review? I ask because it is still marked as draft.

Not yet @VolodymyrOrlov, I think that it works but currently there is an excessive amount of cloning that I want to remove

Can you also compare your coefficients with Scikit's Gaussian NB like we did for Categorical NB? https://scikit-learn.org/stable/modules/naive_bayes.html#gaussian-naive-bayes. It would be great if you can add a unit test that compares coefficients directly. Comparing y_hat with y might not be precise enough.


feat: Add uniswapv3-base

Add uniswapv3-base and some basic configuration around it.

Can you update the dYdX provider to accept feeds from base? Also have we decided on the format of what the ticker will look like in their gov proposals?


Crash in on_recv_notify

I don't have much detail here, dropping this so I don't forget. I saw a crash in the following on teardown.
#0	0x0000000104ea129c in quicr::QuicRTransportDelegate::on_recv_notify(unsigned long long const&, unsigned long long const&) ()

This seems to happen in conjunction when there's another weird issue, where I'm seemingly getting loss or the relay is running very slowly even locally. When that's happening, I always get the above on teardown.
qmedia`quicr::QuicRTransportDelegate::on_recv_notify:
    0x105585248 <+0>:   sub    sp, sp, #0x140
    0x10558524c <+4>:   stp    x28, x27, [sp, #0x120]
    0x105585250 <+8>:   stp    x29, x30, [sp, #0x130]
    0x105585254 <+12>:  add    x29, sp, #0x130
    0x105585258 <+16>:  stur   x0, [x29, #-0x18]
    0x10558525c <+20>:  stur   x1, [x29, #-0x20]
    0x105585260 <+24>:  stur   x2, [x29, #-0x28]
    0x105585264 <+28>:  ldur   x8, [x29, #-0x18]
    0x105585268 <+32>:  str    x8, [sp, #0x38]
    0x10558526c <+36>:  stur   wzr, [x29, #-0x2c]
    0x105585270 <+40>:  b      0x105585274               ; <+44>
    0x105585274 <+44>:  ldur   w8, [x29, #-0x2c]
    0x105585278 <+48>:  subs   w8, w8, #0x96
    0x10558527c <+52>:  b.ge   0x1055855cc               ; <+900>
    0x105585280 <+56>:  b      0x105585284               ; <+60>
    0x105585284 <+60>:  ldr    x8, [sp, #0x38]
    0x105585288 <+64>:  ldr    x8, [x8, #0x8]
    0x10558528c <+68>:  add    x0, x8, #0x8
    0x105585290 <+72>:  bl     0x10557d290               ; std::__1::shared_ptr<qtransport::ITransport>::operator->() const
    0x105585294 <+76>:  ldur   x1, [x29, #-0x20]
    0x105585298 <+80>:  ldur   x2, [x29, #-0x28]
->  0x10558529c <+84>:  ldr    x8, [x0] EXC_BAD_ACCESS (code=1, address=0x0)

@RichLogan , there were few things causing crashes that have been fixed. Can you try to reproduce this again?


Passing reference models to decorators

I am implementing a decorator that is supposed to take a model as an argument. Is this supported?
For context, I have an npm library that exposes a set of models. Lets call this library 'lib1'.
`
import @lib1"
using reference.users;
namespace Example {
@myDecorator(reference.users.user)
@entity model myModel {
prop: string;
}
}
`
How do I define the type of reference.users.user in my decorators.tsp file?
extern dec myDecorator(target: Model. value: valueof object) does not work because object is currently deprecated

Fixed it. The model is not a literal. Dropping 'valueof' solved it