big_red_button.py should run the same tests as travis

 Issue by Hixie
Thursday Oct 29, 2015 at 23:42 GMT
Originally opened as https://github.com/flutter/engine/issues/1880

Somehow we should verify that the release we're about to make will be analyzer-clean and pass the tests. This is complicated by the fact that during the release your tree is in a state where 'pub' won't be happy, of course.

 Comment by abarth
Friday Oct 30, 2015 at 16:41 GMT

I discussed this with @sethladd .  One idea is to be able to push a "beta" or "dev" version of the packages to pub that won't be visible to the public.  Then we could test them from pub and once they pass the test, we could flip the bit on the server and make them the production versions of the package.

We now release using git hashes.  We should check Travis before publishing a given git hash.


Add useDispatch() variant for dispatching async thunks

New Features
I propose either adding a variant of useDispatch() (which I'll refer to as useThunkDispatch() throughout this issue), or updating useDispatch() to handle both sync and async actions.
What is the new or updated feature that you are suggesting?
Currently, I've created the following React Hook to use in my codebase. Note that I'm using Redux Toolkit, React Redux, and TypeScript in my codebase.
/**
 * @example
 * When using React Redux, the following boilerplate is required to dispatch an action for an async thunk:
 *
 * ```typescript
 * function ProfilePic(): ReactElement {
 *   const dispatch = useDispatch();
 *   useEffect(() => {
 *     dispatch(ChatsSlice.fetchChat(3));
 *   }, [dispatch]);
 * }
 * ```
 *
 * This function removes the boilerplate as shown below:
 *
 * ```typescript
 * function ProfilePic(): ReactElement {
 *   useThunkDispatch(ChatsSlice.fetchChat(3));
 * }
 * ```
 */
export function useThunkDispatch(actionCreator: AsyncThunkAction<any, any, any>): void {
  const dispatch = useDispatch();
  useEffect(() => {
    dispatch(actionCreator);
  }, [dispatch, actionCreator]);
}

Why should this feature be included?
Currently, we use useDispatch() to dispatch actions but it doesn't work out of the box for async thunks. If you use useDispatch() directly, you get the following error (I've replaced the actual component names with <ComponentName>):
Warning: Cannot update a component (`<ComponentName>`) while rendering a different component
(`<ComponentName>`). To locate the bad setState() call inside `<ComponentName>`, follow the
stack trace as described in https://reactjs.org/link/setstate-in-render

This error can be fixed by using useEffect() to ensure the action is only dispatched once (StackOverflow reference). With either the addition of useThunkDispatch() or the updation of useDispatch() to handle this case, we needn't worry about this anymore.
What docs changes are needed to explain this?
https://react-redux.js.org/api/hooks must document the new/updated hook.

I'm not quite sure what you're proposing here.
useDispatch works fine for dispatching thunks in general, assuming that your Redux store has been configured with the thunk middleware (which Redux Toolkit's configureStore API does by default).  So, the small example you've got listed there is definitely not necessary to dispatch thunks.
If you're getting some kind of a "can't update component A while rendering component B" error, you have some other bug in your code.
There is a complication with useDispatch and thunks at the TypeScript level, because the default Dispatch type doesn't recognize thunks as an acceptable thing to dispatch, but we have documented info on how to extract the type of the real store.dispatch and use that:
https://redux-toolkit.js.org/tutorials/typescript#define-root-state-and-dispatch-types

I agree it's probably a bug in my code. However, I still feel the need to use this custom hook because of this discussion, and the StackOverflow reference I mentioned in my original comment. As per my understanding, dispatching an async thunk (or perhaps any action) before a functional React component has first rendered causes this bug to occur. So, the developer must ensure the dispatch gets delayed using setTimeout(), useEffect(), etc. The other possibility is that useDispatch() isn't to blame but useSelector() because the selector is asking the component to re-render before its first render since it got new data before the first render. If this assumption of mine is wrong, please let me know, and I'll ask on StackOverflow instead.

Yeah, I'm really not sure what the problem statement is here that you're describing.  It would help if you could show an example of the actual code you're concerned with
You definitely should not be dispatching actions directly while rendering, if that's what you're asking:
function MyComponent() {
  const dispatch = useDispatch();
  dispatch(anything()) // DON'T DO THIS!!!

  return <div />
}

This applies for any Redux action (plain action or thunk).  Or, for that matter, React state setting.  Rendering logic should be pure - just props+state -> UI, no side effects.

Actually, that code is also incorrect for the library. It will immediately dispatch when that hook is used, regardless of your intent of what to do with dispatch. That's not what our API should do. We provide the functions, you figure out when to call them.


fix: EntityContextMenu display in an incorrect shape

Hey, I just made a Pull Request!

:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[x] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Before:

After:

Thanks for this! 👍  @codermango


test performance upgrade

Summary
New performance tests are in!!
Major changes:

Added rxjs6
Upgraded all perf test dependencies
Run tests in node 8

Todo
Compare most.js with the latest versions of other reactive frameworks

Thanks, @cortopy! I should have time to look at this over the weekend.

Quick, question about how you ran these.
It's best to run them with as little else running on the machine as possible.  There's really no way to get a "perfect" run (whatever that might mean), of course, but at least on OS X I've seen some weird outliers when I've forgotten to quit everything but a terminal window.
So, if you did that, great!  This looks ready to merge.  If not, would you mind doing another run?  Thanks!
Also, if you're up for it, I'd be delighted to have a similar PR over at mostjs/core.

I did close all windows for the reasons mentioned. But that's a good point. I'll try again by restarting my computer in terminal mode

@briancavalier interestingly, not much of a difference in terminal mode. I've done a new commit with the results

Awesome, thanks @cortopy.  Now we know :). I guess operating systems (perhaps particularly linux) have gotten pretty good at not using resources when idle.


Inventory refactor part 2 - inventory and archetype builders

The big inventory refactor is reaching it's end, so testing can get started. Testing should also target possible inventory plugins.
Changes:

Inventories are no longer populated inside a inventory, but through builders.
Every inventory (except views) are have also a archetype assigned to them.
Implemented the SpongeAPI archetype and inventory builders.
Containers no longer contain the inventory structure, but just slots (ContainerSlots). You can use the transform methods on slots to get the original ones.
All the inventories that are generated with a carrier will also implement CarriedInventory (through class generation)
A client container bug fix. Long clicking a slot (without dragging) was also considered a dragging mode and is now handled like a normal click. This was causing items to disappear.

TODO:

Figure out how to properly handle all the property operations? (When comparing two properties that have the DELEGATE operation, fallback to EQUAL?)
Testing
Bugs?
Anything missing?

I will give this a full review and test it thoroughly tonight. From a quick glance it looks pretty good though :>

I'm not sure what issues I'm supposed to report relating to functionality for this PR, but I have found a few issues in general with inventories/containers.
Shift clicking iron ore(and others like gold) in the furnace does not bring it to the cooking slot like the client expects, but rather to the opposite part of the inventory(hotbar to main/main to hotbar) or stays in its current spot if the other is full. This does not happen to coal which goes to the proper slot.
I cannot open double chests, but I can open single chests which do work well.
Inventories do not have the proper names, most just saying Inventory. The crafting bench has the proper name.
Furnaces do not work at all anymore, at least with coal and iron ore(I recall this working before).

Actually just noticed there was a stack trace when opening double chests: https://gist.github.com/Meronat/3eb9e2a30a53b41d48bd4c2f70e7b4c7

@Meronat The iron ingot recipe isn't registered yet, but you could combine two iron ingots into a steel ingot. And I will fix the inventory names and the double chest error.

Will do some more testing tomorrow and a code review. Maybe rebase on master?

@Meronat I am going to merge this in a few days. In case you want to do some more testing, I am also going to test a bit more. We can always fix any other issues later as they pop up.


Use @colorInt annotation

The first time I used the library, I used colors like R.color.primary by mistake and the intro screen didn't behave as I expected as it expects a color integer 0-255.
Adding the @colorInt annonation warns users doing the same mistake directly in Android Studio.

It's a pretty good thing to have annotations throughout a library - specially one that is not documented as well in the code itself - this looks good to me.


Unable to scroll on the Language list if you have too many languages

If you have too many languages downloaded, some languages may be unselectable if you don't have the proper screen size

Note that this does not happen in the "Second Language" dialogue due to it having a proper scrollbar

I decided to make it a little bit differently. Seems viable for me. @abUwUser what do you say?

seems good! tho i guess it could also be neat to list all available languages and if the language selected isn't available it does automatic download, like what's done at google translate

Yeah, good idea!

Close this issue. The new functionality will be added in a new issue.


implement for const generics

related:

https://github.com/rust-lang/rustfmt/issues/3418
https://github.com/rust-lang/rustfmt/issues/3336

Thank you the review.  I refactored and added comment.

On the beta channel it fails to compile:
Mismatch at src/expr.rs:664:
 }

 fn choose_matcher(pats: &[&ast::Pat]) -> &'static str {
-    if pats.is_empty() { "" } else { "let" }
+    if pats.is_empty() {
+        ""
+    } else {
+        "let"
+    }
 }

 impl<'a> ControlFlow<'a> {


pre-commit is breaking the package

When running pre-commit, it deletes some imports in the init (of this package https://github.com/deep-finder/napari-deepfinder ) that are necessary for the testing to work properly:
from ._reader import napari_get_reader
from ._writer import write_annotations_xml
from ._widget import denoise_widget, reorder_widget, AddPointsWidget
from ._orthoview_widget import Orthoslice

Is this the wanted behaviour for pre-commit? Because maybe I using it the wrong way, but it is causing more damage than improvements for me currently ...

this is a bug in cookiecutter fixed in #119 (not merged yet). This is problem of lack of __all__ in __init__

Thanks a lot! Will there be a way to "update" a plugin afterwards with this change or is a manual intervention needed?

Based on my knowledge there is a need for manually fixing.
You need to add this line to __init__.py
__all__ = ("napari_get_reader", "write_annotations_xml", "denoise_widget", "reorder_widget", "AddPointsWidget", "Orthoslice")

Note on updating, we don’t have this in our docs, but if you use cruft instead of cookiecutter when starting the project, you can use it’s update feature
https://github.com/cruft/cruft

You can remove setup-cfg precommit if you’d like

Yep; you should feel free to add/remove anything you want to tune it to your liking

the setup process of cookiecutter  "napari-foobar"

Maybe we should fix this

the setup process of cookiecutter "napari-foobar"
Maybe we should fix thisfrom the pep you linked @Czaki:

Modules should have short, all-lowercase names. Underscores can be used in the module name if it improves readability. Python packages should also have short, all-lowercase names, although the use of underscores is discouraged.


Update protobuf definitions 20220127

This PR updates protobuffer definitions for the gRPC service using Envoy's RLS. Unfortunately this pulls in a lot of files that we don't really need, but what is/isn't needed is subject to change and requires a pruning process that has to be repeated each time we update. So we just pull in all proto definitions from the relevant repositories (documented in the README.md file under vendor/protobufs along with the reason this is being done) and hope the whole package won't be too big.

LGTM


Add most used tags feature

Expected Behavior
When adding a new page to Pocket, instead of entering in the tag, there should also be a list of most used tags that can be selected. I often finding myself forgetting what tags I previously used, and there's no quick and easy way to see that.
Actual Behavior
Tag entry box with no smart features for suggesting etc.
Next Steps
I'm happy to contribute. I'm familiar with React-Redux stack.
Specifications

Version: Built in to Firefox, see below
Browser: Firefox Quantum 66.0.2 64 bit
Operating System: NixOS

I see this extension is native to Mozilla and should probably be logged on their Bugzilla page? Is that correct?

@BenSchZA  it is good you logged this here as well as we can use this to improve our offering for the chromium browsers. The extension works across chromium browsers as well.
@BenSchZA also feel free to contribute, make sure to work against the develop branch - I will update our contribution guidelines to indicate this

Hi Ben,
Thanks for opening this issue. This repo is for our Chromium-based extensions, so you’re correct that any issues discovered with the Pocket integration in Firefox would be best posted in Bugzilla.
That said, if you find any issues or would like to contribute to our Chromium project, this is the right place.
Regarding your suggestion, we can understand how displaying your most used tags could make tagging more efficient and help you remember what tags you’ve already used. We’re already tracking this request internally, and I’ve added your vote for this request.
If you have any additional feature ideas, please feel free to to share them with the Pocket Support team, who is in charge of tracking them.


BR: Send Ack when receiving an IfStateInfo message

The border router should send an application level Ack message when it receives a IfStateInfos message from the BS.

The IFStateInfo messages are getting redesigned for #3743 (maybe even removed). Closing this as duplicate, because #3743 will cover this aspect (if necessary).


Bug:

Describe the Bug
I have switch bot blinds and when I press the button the blinds are unresponsive and don't do anything.
To Reproduce
press to open or close blinds. The screen toggles back to open with no response
Expected Behavior
Blinds to open or close.
Relevant Log Output
[10/23/2023, 7:16:09 PM] [SwitchBot] Blind Tilt: Family Room Left Hub Device is offline, statusCode: 171. Hub: E7AFD5BA87C0
[10/23/2023, 7:16:10 PM] [SwitchBot] Blind Tilt: Family Room Left Checking Status ...
[10/23/2023, 7:16:14 PM] [SwitchBot] Blind Tilt: Family Room Left Hub Device is offline, statusCode: 171. Hub: E7AFD5BA87C0
[10/23/2023, 7:16:14 PM] [SwitchBot] Blind Tilt: Family Room Left Checking Status ...
[10/23/2023, 7:16:15 PM] [SwitchBot] Blind Tilt: Family Room Left Set TargetPosition: 0
[10/23/2023, 7:16:16 PM] [SwitchBot] Blind Tilt: Family Room Left Hub Device is offline, statusCode: 171. Hub: E7AFD5BA87C0
[10/23/2023, 7:16:16 PM] [SwitchBot] Blind Tilt: Family Room Left Hub Device is offline, statusCode: 171. Hub: E7AFD5BA87C0
[10/23/2023, 7:16:16 PM] [SwitchBot] Blind Tilt: Family Room Left Checking Status ...
[10/23/2023, 7:16:19 PM] [SwitchBot] Blind Tilt: Family Room Left Set TargetPosition: 82
[10/23/2023, 7:16:19 PM] [SwitchBot] Blind Tilt: Family Room Left Hub Device is offline, statusCode: 171. Hub: E7AFD5BA87C0
[10/23/2023, 7:16:19 PM] [SwitchBot] Blind Tilt: Family Room Left Hub Device is offline, statusCode: 171. Hub: E7AFD5BA87C0
[10/23/2023, 7:16:20 PM] [SwitchBot] Blind Tilt: Family Room Left Checking Status ...

Config for homebridge-switchbot
{
    "name": "SwitchBot",
    "credentials": {
        "token": "xxxxxxxxxxxxxxxxxxxxxxxxxx",
        "secret": "xxxxxxxxxxxxxxxx",
        "notice": "Keep your Token & Secret a secret!"
    },
    "platform": "SwitchBot",
    "_bridge": {
        "username": "0E:D4:93:D5:87:A4",
        "port": 54327

Screenshots
No response
Device and Model
Switchbot blind tilt
Node.js Version
18
NPM Version
not sure
Homebridge Version
4.51
Homebridge Switchbot Plugin Version
2.9.1
Homebridge Config UI X Plugin Version
No response
Operating System
rabian

Looks like your hub is offline, based on your logs.

hello,
It shows offline but hub is online. How do you suggest I fix it? I showed you a video through email, but not sure if you received it.

I would make sure Cloud Services are on, if they are already on turn off and back on and reselect the hub.


#added correct way to handling request size

Summary of Changes

Added a faster and more efficient solution for byte data handling.
Improved the handling of request size with a correct and optimized approach.

Pre-launch Checklist

[ ] Verify that all unit tests pass successfully.
[ ] Ensure that request size validation functions as expected.
[ ] Confirm that performance benchmarks show improvement with the updated implementation.

Original Issue
The original implementation used a List<int> (data) to accumulate incoming byte segments. The += operator creates a new list every time data is appended. This approach is inefficient for handling large amounts of data, leading to excessive memory allocations and unnecessary copying of existing data.

Optimized Solution
The updated code replaces the list with a BytesBuilder, a utility specifically designed for efficient byte accumulation. This ensures a more memory- and performance-efficient implementation.

Key Improvements

Efficient Byte Accumulation:

BytesBuilder dynamically grows its internal buffer, avoiding the need to create a new object each time data is appended.
Reduces memory usage and improves performance significantly.

Avoiding Redundant Memory Allocation:

Previously, using += created a new list and copied all existing data into it. BytesBuilder manages memory internally, preventing these redundant operations.

Efficient Data Conversion:

The BytesBuilder.takeBytes() method retrieves the final byte array without additional copying, enabling more efficient conversion to a UTF-8 string.

Preserving Size Check Logic:

The logic for checking the request size (len > serverpod.config.maxRequestSize) is retained.
This ensures oversized requests are detected early and stopped before unnecessary data accumulation.

Benefits of the Optimization

Improved Performance:

BytesBuilder is designed for scenarios requiring dynamic byte accumulation, reducing time complexity and memory overhead.

Cleaner Code:

The optimized implementation is easier to read and understand, as BytesBuilder is semantically appropriate for this use case.

Scalability:

The solution is more suitable for handling larger data streams without performance degradation.

This release improves the efficiency, maintainability, and scalability of handling HTTP request body data.

I have read the CLA Document and I hereby sign the CLA

Update Summary
Changes and Fixes

Added a new ResultRequestTooLarge class:

Implemented a class to handle errors related to request body size exceeding the maximum limit.
Provides detailed information about the maximum allowed size and the actual size of the request.

Enhanced Error Handling:

Improved handling for ResultRequestTooLarge exceptions.
Clear and informative error messages are now sent to users when their request size exceeds the allowed limit.

Optimized _readBody Function:

Simplified logic for improved readability and performance.
Resolved issues with redundant checks and stream reuse, ensuring more reliable behavior.

Added Comprehensive Tests:

Created tests to verify the system's behavior when the request size exceeds the configured limit.
Tests validate both the returned HTTP status code and the error message sent to the user.

Benefits

Improved system stability.
Enhanced code readability and maintainability.
Better user experience with clear feedback on errors.

If you have any questions or suggestions, feel free to reach out.
Thank you! 🚀


Autoimports don't work in global settings with new architecture

See typesafehub/sbteclipse#295 and sbt/sbt-pgp#80.

I have installed sbteclipse as a global plugin (since in most of my builds nothing depends on it). I have some configuration for it in ~/.sbt/0.13/sbteclipse.sbt, that uses EclipseKeys unqualified. When I switched from 2.5.0 to 4.0.0, I needed to add an import there for EclipseKeys. This is not needed if I place the setting in build.sbt, whether the plugin is installed locally or globally.

For sbteclipse, it seems that's only needed with versions of the plugin after switching to the 0.13.5 plugin architecture — that is, after https://github.com/typesafehub/sbteclipse/commit/b6b0379ef9b9c9602a77b7dc09fb1c2bf25b8610#diff-e127bb09dd9d0b8de01cd7be195d59bcR30. This is just a first hypothesis, since I haven't rebuilt a single line of code. But anyhow, with the info I have this looks like a SBT bug.

I've converted a few of my plugins (like sbt-assembly) and others (like bintray-sbt) and thus far I have not encountered this issue.
I've also tried to adhere to Plugins Best Practices strictly.
Is there something peculiar that sbteclipse and sbt-pgp is doing? /cc @jsuereth

It seems like what is happening is that the imports for these keys is happening too late.
If I load the plugin via a file in ~/.sbt/0.13/plugins/gpg.sbt:
addSbtPlugin("com.jsuereth" % "sbt-pgp" % "1.0.0")

And then put my configuration in  ~/.sbt/0.13/gpg.sbt:
pgpPassphrase := Some("<redacted>".toCharArray)

pgpSecretRing := file("<redacted>/secring.asc")

pgpPublicRing := file("<redacted>/pubring.asc")

... then I get the following error:
/Users/timcharper/.sbt/0.13/gpg.sbt:3: error: not found: value pgpPassphrase
pgpPassphrase := Some("<redacted>".toCharArray)

However, if comment out the contents of ~/.sbt/0.13/gpg.sbt, and instead place the configuration in my project build.sbt, then I no longer get the error.
So, AutoImport is working, but it seems like the load order is as follows:

load ~/.sbt/0.13/plugins/gpg.sbt
load ~/.sbt/0.13/gpg.sbt
import com.typesafe.sbt.pgp.PgpKeys._
load ./build.sbt

@timcharper Interesting observation. That could be it.

Note to someone who wants to try fixing this https://github.com/sbt/sbt/blob/v0.13.9/main/src/main/scala/sbt/Load.scala#L74-L85

As seen ^^, I've a fix submitted as a pull request for this issue.

Fixed in #2399.


luv fails to build in OpenBSD

Cheers
I'm trying to build luv in OpenBSD 5.9, but I'm getting the following error
Scanning dependencies of target luv
[ 50%] Building C object CMakeFiles/luv.dir/src/luv.c.o
In file included from /root/luv/src/luv.c:41:
/root/luv/src/dns.c: In function 'luv_getaddrinfo':
/root/luv/src/dns.c:154: error: 'AI_V4MAPPED' undeclared (first use in this function)
/root/luv/src/dns.c:154: error: (Each undeclared identifier is reported only once
/root/luv/src/dns.c:154: error: for each function it appears in.)
/root/luv/src/dns.c:158: error: 'AI_ALL' undeclared (first use in this function)
CMakeFiles/luv.dir/build.make:62: recipe for target 'CMakeFiles/luv.dir/src/luv.c.o' failed
gmake[2]: *** [CMakeFiles/luv.dir/src/luv.c.o] Error 1
CMakeFiles/Makefile2:67: recipe for target 'CMakeFiles/luv.dir/all' failed
gmake[1]: *** [CMakeFiles/luv.dir/all] Error 2
Makefile:127: recipe for target 'all' failed
gmake: *** [all] Error 2

AFAIK OpenBSD does not have those flags, disabling the code does allow me to build e.g.
diff --git a/src/dns.c b/src/dns.c
index f3446f3..8b12bfb 100644
--- a/src/dns.c
+++ b/src/dns.c
@@ -150,13 +150,17 @@ static int luv_getaddrinfo(lua_State* L) {
     if (lua_toboolean(L, -1)) hints->ai_flags |=  AI_ADDRCONFIG;
     lua_pop(L, 1);

+#ifdef AI_V4MAPPED
     lua_getfield(L, 3, "v4mapped");
     if (lua_toboolean(L, -1)) hints->ai_flags |=  AI_V4MAPPED;
     lua_pop(L, 1);
+#endif

+#ifdef AI_ALL
     lua_getfield(L, 3, "all");
     if (lua_toboolean(L, -1)) hints->ai_flags |=  AI_ALL;
     lua_pop(L, 1);
+#endif

     lua_getfield(L, 3, "numerichost");
     if (lua_toboolean(L, -1)) hints->ai_flags |=  AI_NUMERICHOST;

cc https://github.com/neovim/neovim/issues/4620

Sounds good.  Would you like to send a PR so you can credit for the patch in git, or shall I apply it manually?

@creationix I'll start a PR but I'm still running into an issue when loading luv, either I get
cmake -DLUA_BUILD_TYPE=System ..
(...)
LuaJIT 2.0.4 -- Copyright (C) 2005-2015 Mike Pall. http://luajit.org/
JIT: ON CMOV SSE2 SSE3 SSE4.1 fold cse dce fwd dse narrow loop abc sink fuse
> local luv = require('luv')
luajit51:./luv.so: undefined symbol 'pthread_barrier_destroy'
luajit51:./luv.so: undefined symbol 'uv_loadavg'
luajit51:./luv.so: undefined symbol 'pthread_cond_signal'
luajit51:./luv.so: undefined symbol 'uv_exepath'
luajit51:./luv.so: undefined symbol 'pthread_attr_destroy'
luajit51:./luv.so: undefined symbol 'pthread_create'
luajit51:./luv.so: undefined symbol 'pthread_getspecific'
luajit51:./luv.so: undefined symbol 'pthread_rwlock_rdlock
(...)
luajit51:./luv.so: undefined symbol 'pthread_setspecific'
error loading module 'luv' from file './luv.so':
        Cannot load specified object
stack traceback:
        [C]: at 0x0188bef50230
        [C]: in function 'require'
        stdin:1: in main chunk
        [C]: at 0x0188bef07ec0

Or if I force -lpthread, I just get a minimal traceback in luajit
> local luv = require('luv')
error loading module 'luv' from file './luv.so':
        Cannot load specified object
stack traceback:
        [C]: at 0x01f190b50230
        [C]: in function 'require'
        stdin:1: in main chunk
        [C]: at 0x01f190b07ec0

Definitely an issue with libpthread, I dont have more time today, here is a quick log, LD_PRELOAD helps sidestep the libpthread loading after which point we also see some missing libuv symbols
export LD_DEBUG=1
(...)
LuaJIT 2.1.0-beta2 -- Copyright (C) 2005-2016 Mike Pall. http://luajit.org/
JIT: ON SSE2 SSE3 SSE4.1 fold cse dce fwd dse narrow loop abc sink fuse
> require('luv')
dlopen: loading: ./luv.so
 flags ./luv.so = 0x0
head ./luv.so
obj ./luv.so has ./luv.so as head
linking ./luv.so as dlopen()ed
head [./luv.so]
examining: './luv.so'
loading: libpthread.so.20.1 required by ./luv.so
 flags /usr/lib/libpthread.so.20.1 = 0x68
dlopen: failed to open libpthread.so.20.1
unload_shlib called on ./luv.so
unload_shlib unloading on ./luv.so
dlopen: ./luv.so: done (failed).
error loading module 'luv' from file './luv.so':
        Cannot load specified object
(...)


(BKR-895) pull puppet-specific functionality out of beaker

Tasks to complete before merging

[x] create automated testing for beaker-puppet PRs
[x] release a first beaker-puppet gem

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/3801/

@puppetlabs/beaker, @tvpartytonight, would you please take a look at beaker-puppet? I'd like to get a review pass before cutting the first gem to be used for last testing with this code.
Also, note that you can explore testing on that repo by checking out beaker-puppet#1.

now that beaker-puppet 0.1.0 is released, we can look at testing this PR.
@puppetlabs-jenkins retest this please

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/3901/

@puppetlabs-jenkins retest this please

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/3902/

@kevpl it looks like we're going to need this soon. RE is getting ready to cut artifact pathing over to puppet5 soon in prep for the puppet-agent, puppetserver, and puppetdb 5.0.0 releases. Do you have an eta on when we can expect this PR and https://github.com/puppetlabs/beaker/pull/1408 to land? Those releases are scheduled for the 27th.

@puppetlabs-jenkins retest this please

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/3929/

@puppetlabs-jenkins retest this please

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/3930/

@puppetlabs-jenkins retest this please

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/3933/

@puppetlabs-jenkins retest this please

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/3934/

look at that! A green run! I only had to disable these jobs (internal links):

Beaker Acceptance - Puppet
Beaker Acceptance - Reuse Vpool Hosts

I'll create some TODOs in the top to get these prepared for merging...


Trading recommendation

I think there should be a way to only trade pokemon you don't already own, and if you get one that's lower than the specified CP but higher than the highest of its type, it should keep the collected one and drop the lower of the two.

Totally agree.
Add a flag to only transfer pokemons which you already own, and always transfer the lower of them.

Working on a PR to make this happen.

Here is the corresponding pull request #668

please resolve issues with latest DEV branch with that PR #668 and create new PR


Terragrunt Support

Feature Overview
Support terragrunt. https://github.com/gruntwork-io/terragrunt
I'm not sure what to do and if tfaction can support terragrunt.
So first we need to investigate it.
Why is the feature needed?
terragrunt is a popular tool for Terraform users.
So it's good to support terragrunt.
Does the feature include Breaking Changes?
I'm not sure.
Reference

https://github.com/gruntwork-io/terragrunt

I haven't used terragrunt, so your help is welcome!


Repo won't deploy to Netlify, they say to open an issue with node-gyp devs

Hi, my repo won't deploy to Netlify. They suspect it's because of node-gyp. They emailed me back saying,
"I think you should open an issue with node-gyp devs at this point. There's nothing else that seems to be pending from our end that can help with this."
Let me explain the problem:
When I try to deploy this site it gives me an error code 1 message. The site works locally so I assumed it had something to do with Netlify. After Netlify support looked into it they said to open an issue here.
Please let me know what you think and thanks for reading this.

Here is the repo:
https://github.com/nyutuwaigi/unit-storage


Usage of Event Stacktrace is deprecated but still used here

Environment
sentry-elixir 8.0.5 as demonstrated in https://gitlab.com/glitchtip/error-factories/elixir-error-factory
Steps to Reproduce

Run example repo and inspect event data produced by this SDK.

Expected Result
stacktrace should show up in exception
Actual Result
stacktrace shows up in stacktrace field instead. Which is marked as deprecated for some time in https://develop.sentry.dev/sdk/event-payloads/types/
Abbreviated example of event data
{
...
"stacktrace": {
    "frames": [
      {
        "context_line": null,
        "filename": "proc_lib.erl",
        "function": ":proc_lib.init_p_do_apply/3",
        "in_app": false,
        "lineno": 226,
        "module": "proc_lib",
        "post_context": [],
        "pre_context": [],
        "vars": {}
      },
      ...
}

Yes, we can use the new API. However, since Sentry.Event is public, I suggest we change it to match the public API, hide it from the docs, and make this change part of the 9.0.0 release (since it's a breaking change). Hiding it will let us be more flexible in the future with changes, and I don't think user necessarily need it exposed.
@sl0thentr0py, what do you think?

@whatyouhide yes sounds good to me


Search functionality does not find partial matches

I noticed that the search functionality only finds words that are an exact match. For instance, if I search for "eigenvalue" then it will not find the occurrences that e.g. are "eigenvalues" due to the final "s" not yielding an exact match.
Is there a way to improve the search functionality to also include such partial matches to words, i.e. if the searched for word is part of a another larger word?

I will look into it in October. (I made the search feature)


Test interdependence issue

Whilst changing the existing grunt coverage-integration task to be grunt coverage-all in #6704 , I initially put the unit tests after the integration etc tests. That resulted in two tests inside of unit/config_spec.js failing with the output below.
Putting the unit tests first resolves the issue enough for #6704, but it would be good to resolve this issue as it means the tests are affecting each other and they definitely shouldn't be.
1738 passing (2m)
  11 pending
  2 failing

  1) Config Theme should have exactly the right keys:
     AssertionError: expected Object {
  cover: 'casper',
  description: 'casper',
  logo: 'casper',
  navigation: Array [ Object { label: 'Home', url: '/' } ],
  permalinks: '/:year/:month/:day/:slug/',
  postsPerPage: '5',
  title: 'casper',
  url: 'http://my-ghost-blog.com'
} to have keys url, title, description, logo, cover
	extra keys: navigation, postsPerPage, permalinks
      at Assertion.fail (node_modules/should/lib/assertion.js:91:17)
      at Assertion.Object.defineProperty.value (node_modules/should/lib/assertion.js:163:19)
      at Context.<anonymous> (core/test/unit/config_spec.js:41:37)

  2) Config Url urlFor should return url for an author when asked for:

      AssertionError: expected '/author/ghost-owner/' to be '/author/joe-bloggs/'
      + expected - actual

      -/author/ghost-owner/
      +/author/joe-bloggs/

      at Assertion.fail (node_modules/should/lib/assertion.js:91:17)
      at Assertion.Object.defineProperty.value (node_modules/should/lib/assertion.js:163:19)
      at Context.<anonymous> (core/test/unit/config_spec.js:299:61)

I thought I remembered fixing that first one. I know I was able to run the tests in any order at one point.  It was good while it lasted 😐


Apple Clang 16 build issue, requires ld_classic

🐛 Describe the bug
When building from source with the new Apple Clang 16, I see the following error:
  ld: multiple errors: duplicate LC_RPATH '/Users/Adam/spack/opt/spack/darwin-sequoia-m2/apple-clang-16.0.0/cpuinfo-2023-11-04-4sylnhqsvndbdpgwvv3mydc6xhudikqh/lib' in '/Users/Adam/spack/opt/spack/darwin-sequoia-m2/apple-clang-16.0.0/py-torch-2.4.1-wsy5qo376pu3gqk6sazvaff3wf6uo6fl/lib/python3.11/site-packages/torch/lib/libc10.dylib'; duplicate LC_RPATH '/Users/Adam/spack/opt/spack/darwin-sequoia-m2/apple-clang-16.0.0/protobuf-3.13.0-sqetzfmrwohnuex4orfxr5loztdqj6rq/lib' in '/Users/Adam/spack/opt/spack/darwin-sequoia-m2/apple-clang-16.0.0/py-torch-2.4.1-wsy5qo376pu3gqk6sazvaff3wf6uo6fl/lib/python3.11/site-packages/torch/lib/libtorch.dylib'; duplicate LC_RPATH '/Users/Adam/spack/opt/spack/darwin-sequoia-m2/apple-clang-16.0.0/protobuf-3.13.0-sqetzfmrwohnuex4orfxr5loztdqj6rq/lib' in '/Users/Adam/spack/opt/spack/darwin-sequoia-m2/apple-clang-16.0.0/py-torch-2.4.1-wsy5qo376pu3gqk6sazvaff3wf6uo6fl/lib/python3.11/site-packages/torch/lib/libtorch_cpu.dylib'; duplicate LC_RPATH '/Users/Adam/spack/opt/spack/darwin-sequoia-m2/apple-clang-16.0.0/protobuf-3.13.0-sqetzfmrwohnuex4orfxr5loztdqj6rq/lib' in '/Users/Adam/spack/opt/spack/darwin-sequoia-m2/apple-clang-16.0.0/py-torch-2.4.1-wsy5qo376pu3gqk6sazvaff3wf6uo6fl/lib/python3.11/site-packages/torch/lib/libtorch_python.dylib'
  clang++: error: linker command failed with exit code 1 (use -v to see invocation)

Current workaround is to inject -Wl,-ld_classic into the linker, but would be good to fix this as ld_classic is deprecated and will be removed in the future.
Versions

torchvision: 0.19.1
clang: 16.0.0

We implemented a compiler wrapper in Spack that removes duplicate RPATHs, but we're still seeing the following issue:
ld: duplicate LC_RPATH '@loader_path' in '/Users/Adam/spack/opt/spack/darwin-sequoia-m2/apple-clang-16.0.0/py-torch-2.4.1-hlpsikrtvukd4ww7jyghncl63ux7f2pl/lib/python3.11/site-packages/torch/lib/libtorch_cpu.dylib'
clang++: error: linker command failed with exit code 1 (use -v to see invocation)
error: command '/Users/Adam/spack/lib/spack/env/clang/clang++' failed with exit code 1

It's possible the bug is in PyTorch itself, but I'm not familiar enough with CMake to report it.

Sorry @adamjstewart , this is kind of tricky to fix because we build torchvision on some subset of compilers, and that means not all may be properly supported. Especially in this case where the compiler/linker seems to be more pedantic than gcc (which tends to silently just ignore anything it doesn't expect).

This is funny because Google (TF, JAX) have now dropped support for GCC and only support Clang. But I understand the pain of having to support too many compilers/platforms/etc. Ideally someone with more experience with Clang than both of us can submit a patch.
I'm still not 100% convinced that this isn't a bug in Spack's compiler wrappers, so if no one else reports this issue, I wouldn't prioritize it too much.


Add zooming in/out with ctrl key + mouse scroll  feature

ref #9
Hi, I've added zooming in/out feature with ctrl key + mouse scroll.
Please review this PR, thank you.

@szk18
Thanks for your quick fix!
I will merge your PR and prepare a new release!

@nagata-yoshiteru
Thank you! Your vscode  extension is very useful and helpful!
I'm interested in Auto refresh viewer when file has changes feature. so I'm going to try to implement it.

@szk18
Thanks a lot!
I'm looking forward to your future contribution!
By the way, I would like to add your name in README.md as a contributor if you don't mind.
Is it OK?

@nagata-yoshiteru

By the way, I would like to add your name in README.md as a contributor if you don't mind.
Is it OK?

Of course! I'm very happy❤

@szk18
Thanks for your quick reply!
I added your name and released v0.0.7!
I think it will be available in about 30 minutes in the VSCode marketplace.
Thanks!

Thank you @szk18! The auto refresh feature would indeed be very helpful! I believe there are some docs on the vscode site for file system hooks that you can use.


Ensure compatibility with react and react dom 17

What will this achieve?
Enhancement to make sure components are compatible with the latest react version.
How will success be measured?
Components should work with teams that are on react @17.x.x and additionally<EMAIL_ADDRESS>should be added as a valid peer dependency

Not sure how we would "Ensure compatibility" given that we are currently developing against React 16.
If there is a specific issue you are having perhaps you could raise it.
We probably should do as the core Carbon team did and change the peer dependency config.
See https://github.com/carbon-design-system/carbon/pull/7131/files

Probably also worth someone reading the following link. It suggests there are "potential breaking changes" with the event system and "other breaking changes" which are rare.
https://reactjs.org/blog/2020/10/20/react-v17.html

Will be addressed by https://github.com/carbon-design-system/ibm-cloud-cognitive/issues/832

We should make the same peer dependency declaration as carbon-components-react, and this is addressed for ibm-cloud-cognitive and cdai by PR #869. We will test against react 17 as soon as feasible as part of #832 creating example use packages.


Additional entry properties for nested data

I've created a custom mapper and I need to include additional entry properties for nested data. Is there a better way to do this than what I've done for content type id?
class PostMapper < ContentfulMiddleman::Mapper::Base
  def map(context, entry)
    #super
    @children = {
      :queue => [{ :context => context, :entry => entry }],
      :discovered => [entry.id] }
    while !@children[:queue].first.nil? do
      nxt = @children[:queue].pop
      context = nxt[:context]
      entry = nxt[:entry]
      context.content_type_id = entry.sys[:contentType].id
      map_entry_full(entry, context)
    end

    context.date = entry.sys[:createdAt].strftime("%Y/%m/%d")
  end
end

Hey @cearls,
This is now added already in master and will be released shortly.
If using Middleman v4, the update to upstream master will be done in the dl/upgrade-to-v4 branch within the next few hours.
Cheers

@dlitvakb Thanks!


Zube Subscription

We need guidance from Prof on usage of Zube... we need to start paying as of March 1 because we have 5 people in our group.

E-mail lodged. Waiting on response RE: subscription/costs for group.


[FLINK-4778] Update program example in /docs/setup/cli.md due to the change in FLINK-2021

Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the How To Contribute guide.
In addition to going through the list, please provide a meaningful description of your changes.

[x] General

The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
The pull request addresses only one issue
Each commit in the PR has a meaningful commit message (including the JIRA id)

[x] Documentation

Documentation has been added for new functionality
Old documentation affected by the pull request has been updated
JavaDoc for public methods has been added

[x] Tests & Build

Functionality added by the pull request is covered by tests
mvn clean verify has been executed successfully locally or a Travis build has passed

Due to the change in https://github.com/apache/flink/commit/0629e25602eefdc239e8e72d9e3c9c1a5164448e, we need to specify a prefix for input and output files.

Thanks for the PR @heytitle!
Good to merge :-)

Merging

@fhueske you're welcome 😄


add search api

#2  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @radiosilence and the rest of your teammates on  Graphite


stats: append proxy config extra stat tags

Organize the telemetry extension tags in the bootstrap.
Add request_operation pre-configured label.
Append proxy config tags to the defaults and the annotation tags.

@kyessenov: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
1faf319f130bd8d1311ee25c17d55a348f51dd2b
link
/test integ-local-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
1faf319f130bd8d1311ee25c17d55a348f51dd2b
link
/test integ-local-tests_istio

gencheck_istio
1faf319f130bd8d1311ee25c17d55a348f51dd2b
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
1faf319f130bd8d1311ee25c17d55a348f51dd2b
link
/test integ-local-tests_istio

gencheck_istio
3a719ca17f2297daaad3317d142420110e8d8c72
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/assign @douglas-reid
/assign @mandarjog


Peloton Extractor: Issue extracting VTT subs on Peloton videos

Checklist

[X] I'm reporting a bug unrelated to a specific site
[X] I've verified that I'm running yt-dlp version 2022.04.08 (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are alive and playable in a browser
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Description
yt_dlp.webvtt.ParseError: Parse error at position 70318 (near '00:33:02.330 --> 00:')
Verbose log
[debug] Command-line config: ['-vU', '--ignore-errors', '--restrict-filenames', '--audio-quality', '0', '--username', 'PRIVATE', '--password', 'PRIVATE', '--no-overwrites', '--embed-subs', 'https://members.onepeloton.com/classes/player/85dbe9e47de7464f81f2a0a2f3327230']
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, err utf-8, pref UTF-8
[debug] yt-dlp version 2022.04.08 [7884ade65] (zip)
[debug] Python version 3.8.10 (CPython 64bit) - Linux-5.15.0-27-generic-x86_64-with-glibc2.29
[debug] Checking exe version: ffmpeg -bsfs
[debug] Checking exe version: ffprobe -bsfs
[debug] exe versions: ffmpeg 5.0.1 (setts), ffprobe 5.0.1
[debug] Optional libraries: sqlite
[debug] Proxy map: {}
Latest version: 2022.04.08, Current version: 2022.04.08
yt-dlp is up to date (2022.04.08)
[debug] [peloton] Extracting URL: https://members.onepeloton.com/classes/player/85dbe9e47de7464f81f2a0a2f3327230
[peloton] 85dbe9e47de7464f81f2a0a2f3327230: Starting session
[peloton] 85dbe9e47de7464f81f2a0a2f3327230: Logging in
[peloton] 85dbe9e47de7464f81f2a0a2f3327230: Starting session
[peloton] 85dbe9e47de7464f81f2a0a2f3327230: Downloading JSON metadata
[peloton] 85dbe9e47de7464f81f2a0a2f3327230: Downloading token
[peloton] 85dbe9e47de7464f81f2a0a2f3327230: Downloading m3u8 information
[debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, hdr:12(7), vcodec:vp9.2(10), acodec, filesize, fs_approx, tbr, vbr, abr, asr, proto, vext, aext, hasaud, source, id
[debug] Downloading subtitles: eng
[debug] Default format spec: bestvideo*+bestaudio/best
[info] 85dbe9e47de7464f81f2a0a2f3327230: Downloading 1 format(s): 4906+Audio_Selector_Group_1-Original_Mix
[info] Writing video subtitles to: 30_min_Club_Bangers_Ride-[85dbe9e47de7464f81f2a0a2f3327230].eng.vtt
[debug] Invoking downloader on "https://amd-vod.akamaized.net/classes/cycling/04-2022/85dbe9e47de7464f81f2a0a2f3327230/1/hdntl=exp=1651241941~acl=%2f*~id=2cluN8YnNg45FNpWpO8emQ~data=hdntl~hmac=c7078f215d7bd4dbfc602abd90af3f1f95dbd3320613983588e2e19075fa9b13/master_en.m3u8"
[hlsnative] Downloading m3u8 manifest
[hlsnative] Total fragments: 1
[download] Destination: 30_min_Club_Bangers_Ride-[85dbe9e47de7464f81f2a0a2f3327230].eng.vtt
[download] 30_min_Club_Bangers_Ride-[85dbe9e47de7464f81f2a0a2f3327230].eng.vtt.part-Frag1 has already been downloaded
[download] 100% of ~68.72KiB at Unknown speed ETA Unknown (frag 1/1)ERROR: Parse error at position 70318 (near '00:33:02.330 --> 00:')
Traceback (most recent call last):
  File "/usr/bin/yt-dlp/yt_dlp/YoutubeDL.py", line 1408, in wrapper
    return func(self, *args, **kwargs)
  File "/usr/bin/yt-dlp/yt_dlp/YoutubeDL.py", line 1492, in __extract_info
    return self.process_ie_result(ie_result, download, extra_info)
  File "/usr/bin/yt-dlp/yt_dlp/YoutubeDL.py", line 1548, in process_ie_result
    ie_result = self.process_video_result(ie_result, download=download)
  File "/usr/bin/yt-dlp/yt_dlp/YoutubeDL.py", line 2648, in process_video_result
    self.process_info(new_info)
  File "/usr/bin/yt-dlp/yt_dlp/YoutubeDL.py", line 2900, in process_info
    sub_files = self._write_subtitles(info_dict, temp_filename)
  File "/usr/bin/yt-dlp/yt_dlp/YoutubeDL.py", line 3871, in _write_subtitles
    self.dl(sub_filename, sub_copy, subtitle=True)
  File "/usr/bin/yt-dlp/yt_dlp/YoutubeDL.py", line 2846, in dl
    return fd.download(name, new_info, subtitle)
  File "/usr/bin/yt-dlp/yt_dlp/downloader/common.py", line 457, in download
    ret = self.real_download(filename, info_dict)
  File "/usr/bin/yt-dlp/yt_dlp/downloader/hls.py", line 355, in real_download
    self.download_and_append_fragments(
  File "/usr/bin/yt-dlp/yt_dlp/downloader/fragment.py", line 531, in download_and_append_fragments
    result = append_fragment(decrypt_fragment(fragment, self._read_fragment(ctx)), fragment['frag_index'], ctx)
  File "/usr/bin/yt-dlp/yt_dlp/downloader/fragment.py", line 498, in append_fragment
    self._append_fragment(ctx, pack_func(frag_content, frag_index))
  File "/usr/bin/yt-dlp/yt_dlp/downloader/hls.py", line 270, in pack_fragment
    for block in webvtt.parse_fragment(frag_content):
  File "/usr/bin/yt-dlp/yt_dlp/webvtt.py", line 398, in parse_fragment
    raise ParseError(parser)
yt_dlp.webvtt.ParseError: Parse error at position 70318 (near '00:33:02.330 --> 00:')

I'm reporting a bug unrelated to a specific site

site specific issue has cred part aswell, and since this def requires creds, use that

@Ashish0804 There is no reason to mark this as invalid. OP has given the necessary information needed to debug this (verbose log). So just re-labeling is sufficient. Being too strict with the templates only wastes everyone's time as evident by #3583


Alternative implementation for importing using url

Fixes #5431
Changes proposed in this pull request:

This enhancement provides users the flexibility to switch their preference between importing from a local file and a URL;
We altered the logic in both the frontend import-project-ui.js and the backend ImportProjectCommand.java to differentiate between the two project import options.
In alignment with the existing UI design, we integrated a new feature that permits users to clear the local file input.

Pull Request Test Coverage Report for Build #7072

0 of 6 (0.0%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.002%) to 55.623%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

main/src/com/google/refine/commands/project/ImportProjectCommand.java
0
6
0.0%

Files with Coverage Reduction
New Missed Lines
%

main/src/com/google/refine/commands/project/ImportProjectCommand.java
1
8.93%

Totals

Change from base Build #7071:
0.002%

Covered Lines:
15545

Relevant Lines:
27947

💛  - Coveralls

Pull Request Test Coverage Report for Build #7073

0 of 6 (0.0%)  changed or added relevant lines in 1 file are covered.
29 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.09%) to 55.53%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

main/src/com/google/refine/commands/project/ImportProjectCommand.java
0
6
0.0%

Files with Coverage Reduction
New Missed Lines
%

main/src/com/google/refine/commands/project/ImportProjectCommand.java
1
8.93%

main/src/com/google/refine/expr/util/CalendarParser.java
28
33.5%

Totals

Change from base Build #7071:
-0.09%

Covered Lines:
15519

Relevant Lines:
27947

💛  - Coveralls

Hey @wetneb ! Should the new UI meet your approval, I will proceed to adjust the preview_project.cy.js test case accordingly.

Hi, @wetneb ! Thank you for your insightful suggestions. I appreciate your patience as I'm currently tied up with some other tasks. I understand the importance of the test cases and will work on incorporating Java tests (and Cypress tests) as soon as possible. Your guidance has been extremely valuable!

Ok! I think it would be totally okay to have either only java tests or only Cypress tests for this.


Update Logo: Remove Background for Improved Aesthetics

This pull request addresses the issue of the website logo appearing awkward due to its visible background. The background has been removed to create a transparent logo that seamlessly integrates with the website's design.
Changes Made:
Updated the logo file to a version with a transparent background.
Ensured that the logo now blends smoothly with the website's overall aesthetic, enhancing the visual appeal.

@shashankgoud18 make it proper responsive

@YadavAkhileshh As per your suggestion, I've implemented the responsive design adjustments. Please review the changes and let me know if any further improvements are needed.

@shashankgoud18 solve the conflict

I’ve resolved the conflict in the PR. Could you please review it once
again
On Thu, Oct 10, 2024 at 11:40 PM Akhilesh @.***> wrote:

@shashankgoud18 https://github.com/shashankgoud18 solve the conflict
—
Reply to this email directly, view it on GitHub
https://github.com/YadavAkhileshh/Alien-Invasion-Defense/pull/182#issuecomment-2405746876,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BCAI5ZOHJL2CESVYMVFUAA3Z227HTAVCNFSM6AAAAABPR7CXYOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBVG42DMOBXGY
.
You are receiving this because you were mentioned.Message ID:
@.***>

@shashankgoud18  conflict is still there so please solve it

@YadavAkhileshh
Iam solving the conflcts but as you are merging other PR's .The conflicts are raising again.
I have solved the conflicts again. If you are ok with my PR,  merge my PR at first.


Hi, how may I change height of tabbar?

$ ionic info
√ Gathering environment info - done!
Ionic:
ionic (Ionic CLI)          : 4.0.6
Ionic Framework            : @ionic/angular 4.0.0-beta.2
@angular-devkit/core       : 0.7.3
@angular-devkit/schematics : 0.7.3
@angular/cli               : 6.2.0-beta.2
@ionic/ng-toolkit          : 1.0.6
@ionic/schematics-angular  : 1.0.4
System:
NodeJS : v8.9.4 (C:\Program Files\nodejs\node.exe)
npm    : 5.5.1
OS     : Windows 7
I created tabs project of ionic 4 using --type=angular, now i want to change height of tabbar how could I do this please help. I have changed height of title bar but unable to change height for tabbar.

Thank you for the issue! This will be easier than ever with the latest release 4.0.0-beta.14 which allows full control over the tab bar and tab buttons. You'll be able to write the following to change it:
ion-tab-bar {
  height: 70px;
}

See my comment here for more information on the latest API: https://github.com/ionic-team/ionic/issues/15942#issuecomment-433429959


Update machine-learning-services-overview.md

The changes

name of the product changed to SQL Managed Instance - soon to be changed on the portal as well
other small directional changes like mandatory fields, button names, descriptions

@Misliplavo : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Hi @Misliplavo -- This pull request was opened in the public repo. PMs should work in the private repo, per the Microsoft Docs contributor guide. We can keep this PR open for review and merge, but would you make future content updates in the private repo? Thank you!

@Misliplavo : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Hi @Misliplavo -- This pull request was opened in the public repo. PMs should work in the private repo, per the Microsoft Docs contributor guide. We can keep this PR open for review and merge, but would you make future content updates in the private repo? Thank you!

Thank you, I'll have that in mind for the next time.

#sign-off

@Misliplavo: I'm sorry - only the author of this article, @garyericson, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

#sign-off


How to change background-color in Switch and mdl-layout__header

Hi to all,
I'am trying to change the background color in my switch button and in my header after pressing an a href link, however the button and header kept equal.
Has someone tried something like that?
BR

mdl-color--{color-name}-{shade}:
Have you tried this for mdl layout_header?


[Bug] [task definition] 修复任务定义修改,工作流无法生效问题

问题描述：所有版本都存在任务定义修改，但是在工作流当中无法生效问题，反之则可以。有如下几点：
1、修改无前置任务的任务定义，工作流当中不可用
2、修改有前置任务的任务定义，工作流当中不可用
3、切换工作流版本，修改任务定义，工作流当中不可用
动态演示修复前后对比：
一、修复前

二、修复后

@sdhzwc Could u plz use English for PR descriptions?

@sdhzwc Could u plz use English for PR descriptions?

Sorry, my English is not very good
Chinese is my native language, so describing it more smoothly

@sdhzwc Could u plz use English for PR descriptions?

Sorry, my English is not very good Chinese is my native language, so describing it more smoothly

Thanks for your contribution, I changed the content to English.

Please fix ut
Error:  Failures:
Error:    TaskDefinitionServiceImplTest.updateTaskDefinition:201 Expected org.apache.dolphinscheduler.api.exceptions.ServiceException to be thrown, but nothing was thrown.

Codecov Report

Merging #14801 (490f83e) into dev (d983e36) will decrease coverage by 0.07%.
Report is 1 commits behind head on dev.
The diff coverage is 75.00%.

:exclamation: Current head 490f83e differs from pull request most recent head a836c23. Consider uploading reports for the commit a836c23 to get more accurate results

@@             Coverage Diff              @@
##                dev   #14801      +/-   ##
============================================
- Coverage     38.90%   38.84%   -0.07%
+ Complexity     4611     4591      -20
============================================
  Files          1236     1236
  Lines         43449    43414      -35
  Branches       4809     4794      -15
============================================
- Hits          16905    16863      -42
- Misses        24670    24674       +4
- Partials       1874     1877       +3

Files
Coverage Δ

...er/api/service/impl/TaskDefinitionServiceImpl.java
46.95% <75.00%> (+0.94%)
:arrow_up:

... and 53 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

#15036


Feature/tpi 125 bootstrap theme

SonarQube analysis reported 3 issues

 1 critical
 1 major
 1 minor

Watch the comments in this conversation to review them.


Can can I retrain this for another game?

I have a huge data set of pictures and the weights from another YOLOV3 aimbot but when I try to replace the ones in here the python script gets a ton of errors.

Hello, same question here.
I've actually started doing my own yolov3 dataset. When I imported my data set, FPS drops significantly. Right now I can get to about 10 FPS. Thoughts?

Hello, same question here.
I've actually started doing my own yolov3 dataset. When I imported my data set, FPS drops significantly. Right now I can get to about 10 FPS. Thoughts?

The reason your getting slower fps is because your using the larger yolov3 model, when you check what model they are using its the yolov3-mini which is tinny and faster.


Is -orgs mandatory?

It is unclear whether the -orgs flag is mandatory. Without it, with a Personal Access Token, audit does not return any results for me. With -orgs it behaves as expected (output similar to README)
Should a query occur for the orgs accessible (/user/orgs) in the case of empty orgs? Or should the docs mention it (or, should it be a mandatory flag)? Thanks!

It shouldn't be mandatory sorry that PR was just merged I'll fix later
On Fri, Sep 14, 2018 at 22:23 Jeff Bachtel<EMAIL_ADDRESS>wrote:

It is unclear whether the -orgs flag is mandatory. Without it, with a
Personal Access Token, audit does not return any results for me. With -orgs
it behaves as expected (output similar to README)
Should a query occur for the orgs accessible (/user/orgs) in the case of
empty orgs? Or should the docs mention it (or, should it be a mandatory
flag)? Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/genuinetools/audit/issues/8, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABYNbIExQayIql-gVB91U3IiTmEoy9g1ks5ubGSTgaJpZM4WqJyi
.

--
Jessie Frazelle
4096R / D4C4 DD60 0D66 F65A 8EFC  511E 18F3 685C 0022 BFF3
pgp.mit.edu http://pgp.mit.edu/pks/lookup?op=get&search=0x18F3685C0022BFF3


fix(diagnose): filter events on resource UID and version

avoid showing older events associated with previous version of the resource
Signed-off-by: Xavier Coulon<EMAIL_ADDRESS>

Codecov Report

Merging #61 (d155b65) into main (9891d68) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
- Coverage   77.84%   77.81%   -0.03%
==========================================
  Files          15       15
  Lines         835      834       -1
==========================================
- Hits          650      649       -1
  Misses        135      135
  Partials       50       50

Impacted Files
Coverage Δ

pkg/diagnose/events.go
77.27% <100.00%> (-0.99%)
:arrow_down:

testsupport/fake_api_server.go
82.56% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Document Screen Space Needs for Outline Effect

Describe the issue
With the current documentation it's possible to get into a situation where the outline effect doesn't appear to work at all or only works in certain parts of the scene.

This is due to the effect being accomplished in screen space. And when using a screen space effect it's important to understand things like draw order and depth testing. However these things are not discussed in the documentation.
Feature area
Here are some suggestions of things to add:

Add information about it being a screen space effect.

Explain the need for the outline material and the material(s) of the object being outlined to be rendered in a different order.

Recommend a render order to use (greater than 2000?) and explain why that number.

Show screenshots and / or provide clear description of how to set the render layer.

Finally, the document already says to turn off depth writing but doesn't explain why. Depth writing would help solve the draw order problem, but it would also potentially cause the outline material to occlude the object being outlined.

Existing doc link
MRTK Standard Shader - Mesh outlines
Additional context
N/A

Tagging @Cameron-Micka

I'll probably end up moving outlines to their own markdown file (like we did with hoverlight and proximitylight) so I can add all of this extra information. Thanks!

@Cameron-Micka do you have any cycles to look at this?

@Cameron-Micka do you have any cycles to look at this?

Hey @polar-kev, I just started a new project and trying to gauge my availability. I'll put this on my "todo" list to visit as soon as I can. Good news is I just wrote similar docs for MRTK-Unreal we could borrow from: https://github.com/microsoft/MixedReality-GraphicsTools-Unreal/blob/main/Docs/MeshOutlines.md

Closing as stale in favor of MRGT repo. @Cameron-Micka tracking this.

New docs can be found here: https://docs.microsoft.com/en-us/windows/mixed-reality/mrtk-unity/mrtk3-graphicstools/features/mesh-outlines
We also have some ongoing work to improve outline setup: https://github.com/microsoft/MixedReality-GraphicsTools-Unity/issues/33


Use automatic differentiation

I suggest using automatic differentiation to avoid having to manually specify derivative functions.

@kthyng @dpsanders
We are happy to do this for a later version of this package as this suggested feature will certainly improve the usability.

@dpsanders @Shibabrat I am not familiar with this but it sounds like it is probably beyond the scope of improving the basic code structure and setup of this package. Agreed that it is a helpful suggestion for future development.
@dpsanders please let me know if you can agree with this.

Yes I agree that it is beyond the basic restructuring requirement, but would be a huge usability plus for a future version.

@dpsanders You are doing a huge service for @Shibabrat by giving this in-depth feedback. However, it is beyond the scope for the purposes of this software as a JOSS submission and the review may proceed.


Making titles on instructor issue page more descriptive

Having been away from this for a few weeks, I didn't know what the first table was showing me, so I've titled both.

Looks good to me.
Can we automate sending emails to everyone on these lists?
Also can we just dismiss everyone who was in instructor training 2014 or earlier?  If they haven't been in touch in over a year then I think we can safely assume they're not interested.

The problem is that some people will have incomplete instructor training
from (for example) 2014, but then also be in an event in 2015 (taking a
second run at it).  I need a way to mark the earlier events as "closed",
and then we can subtract them from this problem report.


[fix] handle possible epipe exception during ssl write

A small patch which should resolve the following exception.
2015-07-12 05:52:06 +0000 [info]: Token(s) list updated.
2015-07-12 13:57:12 +0000 [warn]: temporarily failed to flush the buffer. next_retry=2015-07-12 13:57:13 +0000 error_class="Errno::EPIPE" error="Broken pipe" plugin_id="object:3fb600e80350"
  2015-07-12 13:57:12 +0000 [warn]: /usr/local/lib/ruby/2.2.0/openssl/buffering.rb:326:in `syswrite'
  2015-07-12 13:57:12 +0000 [warn]: /usr/local/lib/ruby/2.2.0/openssl/buffering.rb:326:in `do_write'
  2015-07-12 13:57:12 +0000 [warn]: /usr/local/lib/ruby/2.2.0/openssl/buffering.rb:344:in `write'
  2015-07-12 13:57:12 +0000 [warn]: /usr/local/bundle/gems/fluent-plugin-logentries-0.2.10/lib/fluent/plugin/out_logentries.rb:129:in `send_logentries'
  2015-07-12 13:57:12 +0000 [warn]: /usr/local/bundle/gems/fluent-plugin-logentries-0.2.10/lib/fluent/plugin/out_logentries.rb:121:in `block in write'
  2015-07-12 13:57:12 +0000 [warn]: /usr/local/bundle/gems/fluentd-0.12.12/lib/fluent/plugin/buf_memory.rb:61:in `feed_each'
  2015-07-12 13:57:12 +0000 [warn]: /usr/local/bundle/gems/fluentd-0.12.12/lib/fluent/plugin/buf_memory.rb:61:in `msgpack_each'
  2015-07-12 13:57:12 +0000 [warn]: /usr/local/bundle/gems/fluent-plugin-logentries-0.2.10/lib/fluent/plugin/out_logentries.rb:112:in `write'
  2015-07-12 13:57:12 +0000 [warn]: /usr/local/bundle/gems/fluentd-0.12.12/lib/fluent/buffer.rb:325:in `write_chunk'
  2015-07-12 13:57:12 +0000 [warn]: /usr/local/bundle/gems/fluentd-0.12.12/lib/fluent/buffer.rb:304:in `pop'
  2015-07-12 13:57:12 +0000 [warn]: /usr/local/bundle/gems/fluentd-0.12.12/lib/fluent/output.rb:321:in `try_flush'
  2015-07-12 13:57:12 +0000 [warn]: /usr/local/bundle/gems/fluentd-0.12.12/lib/fluent/output.rb:140:in `run'
2015-07-12 13:57:13 +0000 [warn]: temporarily failed to flush the buffer. next_retry=2015-07-12 13:57:15 +0000 error_class="OpenSSL::SSL::SSLError" error="SSL_write: bad write retry" plugin_id="object:3fb600e80350"
  2015-07-12 13:57:13 +0000 [warn]: suppressed same stacktrace
2015-07-12 13:57:15 +0000 [warn]: temporarily failed to flush the buffer. next_retry=2015-07-12 13:57:19 +0000 error_class="OpenSSL::SSL::SSLError" error="SSL_write: bad write retry" plugin_id="object:3fb600e80350"
  2015-07-12 13:57:15 +0000 [warn]: suppressed same stacktrace
2015-07-12 13:57:19 +0000 [warn]: temporarily failed to flush the buffer. next_retry=2015-07-12 13:57:27 +0000 error_class="OpenSSL::SSL::SSLError" error="SSL_write: bad write retry" plugin_id="object:3fb600e80350"
  2015-07-12 13:57:19 +0000 [warn]: suppressed same stacktrace
2015-07-12 13:57:27 +0000 [warn]: temporarily failed to flush the buffer. next_retry=2015-07-12 13:57:41 +0000 error_class="OpenSSL::SSL::SSLError" error="SSL_write: bad write retry" plugin_id="object:3fb600e80350"
  2015-07-12 13:57:27 +0000 [warn]: suppressed same stacktrace

e.g. of changes in practice - https://github.com/CenterForOpenScience/cos-ansible-base/blob/feature/cleanup/roles/docker-logentries/files/fluentd/fluent.conf


Changes to which variables are looked for, changes in output structure, etc.

Make "DeepB/C" variables optional (run only if present)
"--only " syntax in runner
Changed output structure when "--isArray" is used

Thanks @mondalspandan !


Update zh_cn.json

Hello @chengziorange,
Thank you for your help on translation, but I'm not integrate any translation directly in the fabric port, because everytime I'll update from the original mod (forge version), I update the translation from the forge version.
So if you want modify translation, please considere make a pull request in the original mod github page : https://github.com/vectorwing/FarmersDelight.

Thanks for the information. I noticed that the zh_cn lang is already up-to-date and precise in the forge repo, I wonder when will it be ported to the fabric version?


ARROW-1927: [Plasma] Add delete function

Hi, I just add the delete function for Plasma and tested. JIRA ticked:
https://issues.apache.org/jira/browse/ARROW-1927

Yes, I will try to create the unit test cases in next commitment.

On 17 Dec 2017, at 11:40 AM, Philipp Moritz<EMAIL_ADDRESS>wrote:
@pcmoritz commented on this pull request.
Hey, this looks good, thanks for the contribution! Can you please also create a unit test that tests the following two scenarios:
make sure an error is raised if the object is in use
test the "normal" case where the object is not in use and make sure it was actually deleted (maybe by trying to create an object with the same object id)
maybe test what happens if an object is deleted that doesn't exist yet.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/apache/arrow/pull/1427#pullrequestreview-83989260, or mute the thread https://github.com/notifications/unsubscribe-auth/Afm26VC0v8ihrTN7qCYl8g60TEQ7M519ks5tBI0hgaJpZM4REiBf.


Fix symbicache

~Symbicache~ f4cache gets updated early in dep_differ. This caused some false positives when reporting that a dependency "remained unchanged".

Renamed symbicache to f4cache

Fixed issues with reporting project status by allowing the caches to check files without updating. This however, required expicitely reporting those files those files to F4Cache as soon as they become available.

Will be rebased after merging #568


cartodb_processed column is kept in header import with the_geom column

STR:
Import a CSV with a single line, representing the headers, containing the_geom. Such as:
the_geom, name
Expected behavior
A table with these columns and no data is imported
Detected behavior
The cartodb_processed_... column that the QueryBatcher generates temporarily is kept in the table

@rafatower closing this one, it's a thing of the query batcher that we're getting rid of... :D


Post-processing of extracted text > subscripts & superscripts

Note: for the prototype, the PDF parser was able to identify superscript and subscript text which was then ignored.

Hey team! Please add your planning poker estimate with ZenHub @opyate @chrisaballard

@stefl14 my notebook with a WIP effort for this task is here. We can go through it this afternoon if you'd like https://github.com/climatepolicyradar/navigator/blob/feat-335-adobe-extract-pipeline/pipeline/temp-adobe-postprocess-sup-sub.ipynb


Fix the colour chart link for Colour::Fixed(u8)

When looking through the docs for some pointers towards designing my own library for ANSI colours I found that the link to the colour chart was broken. I thought I may as well submit a PR fixing it since I'm basically copying your API :wink:

Coverage remained the same at 91.525% when pulling 59432cc0b64ee41778b4bba791889ac6bf53a2a7 on SShrike:patch-1 into f350ab2feb2340bcfb777620b283ab49ec89fab0 on ogham:master.

Coverage remained the same at 91.525% when pulling 64e128e029a341c8a3560599b8cd10de1435b411 on SShrike:patch-1 into f350ab2feb2340bcfb777620b283ab49ec89fab0 on ogham:master.

haha, oops :+1:

:tada:


suggestion: rename podman service to avoid conflict with docker service

podman service  looks as if it was Podman's implementation of docker service.
I suggest renaming podman service to podman daemon, because it seems actually reimplementation of docker daemon that had existed in Docker 1.10 and prior versions.

We're trying to avoid running this as a daemon (using systemd socket-activation, and having a timeout on the command so it's not always on), so podman daemon is probably a bad idea, but I'm not opposed to renaming to ensure we don't conflict.

If so, we should do this quick, before we cut a 1.8.0 final and formalize the name in an official release

@baude @rhatdan @vrothberg PTAL

Or maybe podman system service

podman listen?
Thanks for pointing that out, @AkihiroSuda !

Why would podman service conflict with docker.service?

Podman is not listening by default at docker.sock, If you install podman-docker, it will create a linkfile between /run/docker.sock and /run/podman.sock.  But podman-docker conflicts with docker-* packages.

There's a docker service command -> https://docs.docker.com/engine/reference/commandline/service/

So this is their replacement for dockerd?  If it is, then podman service makes sense.  Except for not listening on docker.sock?

No, it's a swarm command, AFAIK - it launches a service via swarm

Well we have said we will not support Docker swarm, does it matter we have the same name?

Potential confusion? I'd prefer not to knowingly conflict with Docker commands if we can afford not to

Fine, except that if we come up with a strange name for this service.
podman restapi
podman server

podman server sounds good to me

podman system service also works for me

Yes I like keeping it under system.


[Dubbo-1728] Fix the priority of the delay parameter in JVM args #1728 team3

What is the purpose of the change
Fix issue #1728， by BaiJi the 269th team3
Brief changelog
Make the priority of the delay arg in JVM args the highest, which can override the delay arg set in .xml and .properties files.
Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[x] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #2248 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #2248      +/-   ##
============================================
- Coverage     54.57%   54.55%   -0.03%
+ Complexity     5156     5153       -3
============================================
  Files           568      568
  Lines         25019    25019
  Branches       4456     4456
============================================
- Hits          13655    13649       -6
- Misses         9323     9325       +2
- Partials       2041     2045       +4

Impacted Files
Coverage Δ
Complexity Δ

...in/java/org/apache/dubbo/config/ServiceConfig.java
47.44% <100%> (ø)
62 <0> (ø)
:arrow_down:

...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java
41.66% <0%> (-8.34%)
3% <0%> (ø)

...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java
51.89% <0%> (-3.8%)
11% <0%> (-2%)

...he/dubbo/remoting/transport/netty/NettyServer.java
67.85% <0%> (-3.58%)
8% <0%> (-1%)

...onfig/spring/extension/SpringExtensionFactory.java
85.71% <0%> (+10.71%)
10% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c16f78...2159dbf. Read the comment docs.


i think this repo need some todo list or milestone ?

i check some feature in forum is not implemented? maybe you should tell in documentation or readme what is working or not working so everyone can checked or help

Yes, you are right I will create an empty project on this repo so everyone can add ideas.
You can check the project section of the repo.

You can add your ideas as issues or tasks inti the project into the BACKLOG column


cross-plattform support

Are there any plans to runs this on Linux and macOS as well?

Would have to change a few parts. Especially the hotspot creation. I'm willing to help but no longer have as much time anymore. I feel it is useless on Mac and I don't have Linux. If you can try running it on Linux, I think the basic should work as most of it are NPM or electron modules.

I can help with Linux


Update query type of LocalStateQuery protocol for Shelley

See #1366. Shelley will need more/different types of Queries, so the query type of the LocalStateQuery will need to be extended/updated to accommodate for the new functionality required by the Shelley wallet.

In particular the extra things this will cover include:

*Small precision, I was probably a bit tired when I wrote this :upside_down_face:
About the stake distribution, what I meant to say was that, having the last k is nice but NOT sufficient. We need to know the stake distribution of at least the previous epoch. So we are looking more for 10*k than k (although, I assume this particular ratio is not set in stone).

So @dcoutts , @mrBliss and myself discussed this. Our current proposal is:

The Shelley ledger is extended with rules (and state) for maintaining stakepool performance, which can then easily be queried through the LocalStateQuery protocol.
We do not offer the wallet any historical data. If/when the wallet needs to present historical data to the user, it is responsible for replaying the chain as it sees fit (it can of course reuse the ledger library to do so) -- if useful, it could do this out-of-process.

There isn't too much point having the node implement a view on historical data, as in either case the user's machine would now temporarily have two copies of the ledger state in memory. The only advantage might be that the node could maintain additional snapshots of the ledger state (say, one per epoch) but that too is probably excessive for most users (currently that would result in about 11 GB of data), although it might be an option for exchange nodes.


fix: custom Host header.

https://github.com/traefik/traefik/pull/6502

Hello @ISNing,
Thanks for your interest in this Traefik plugin !
Could you add unit tests for your changes for future backward compatibility ?

Yes for sure, I will try to add that after I made everything work :)
(Since I'm haven't ever been working with go, it might cost some time)

@tomMoulard Everything seems works well (atleast for unit tests)
But have no idea how to test it in real traefik...

If you opened this bug fix, you should have a use case where this PR would fix a bug, right ?
Either way, to paraphrase the README, you can do docker compose up at the root of the project. Doing so will spin up a traefik with a whoami container with the plugin attached to the route whoami.localhost.
Therefore, you can do curl whoami.localhost and it will use the local version of the plugin.
The configuration file is the yules-htransformation.yaml file.

@tomMoulard Thanks for your remindness, I've tested it with the docker image. It works as expected.
The bug that it fixes is just like it described in the pr from traefik's header plugin. This pr enables people change there real Host header.
(Sorry for didn't read the readme)

Okay, I will do further real life tests on my side!
Do you mind refacto a little the code?
I am thinking at a module that wraps each header modifications (add, set, delete,...)
Using pseudo go code, it could look like this:
func deleteHeader(request, header) {
	if strings.EqualFold(rule.Header, "Host") {
		req.Host = ""
	} else {
		header.Del(rule.Header)
	}
}

that could be called like deleteHeader(req, rule.Header).
WDYT?

Okay, I will do further real life tests on my side!
Do you mind refacto a little the code? I am thinking at a module that wraps each header modifications (add, set, delete,...) Using pseudo go code, it could look like this:
func deleteHeader(request, header) {
	if strings.EqualFold(rule.Header, "Host") {
		req.Host = ""
	} else {
		header.Del(rule.Header)
	}
}

that could be called like deleteHeader(req, rule.Header). WDYT?

In fact, I thought about it when I first started writing the code, but I didn't do it because I wasn't familiar with go and didn't know which file to put them is better.
So, how do you name the file? Maybe helper.go?

Personally, I would create a pkg/utils package with a header.go file inside.

Indeed, this seems to be a typo, thanks for catching it up!

Personally, I would create a pkg/utils package with a header.go file inside.

I finished and pushed this minutes before.

@tomMoulard It seems to be a typo of the original code, I think you may should give it a look.
https://github.com/tomMoulard/htransformation/blob/814426f0be3f5382fdd9090ea88d7d87c4c1cd4c/pkg/handler/deleter/delete.go#L15

And do you want me to open another pr to correct this? Or you may prefer to correct it by yourself?

Please do correct it! 💯

Please do correct it! 💯

Done here: https://github.com/tomMoulard/htransformation/pull/63

(sorry for my misoperation deleting the branch

I am trying to push a review commit, but I get a permission denied when I try to push.
I get the following:
$ git push
To github.com:ISNing/htransformation.git
 ! [remote rejected] ISNing/main -> ISNing/main (permission denied)
error: failed to push some refs to 'github.com:ISNing/htransformation.git'

Do you mind allowing me to push to your repository ? Otherwise I will get forced to open another PR that will overseed this one.

I am trying to push a review commit, but I get a permission denied when I try to push.
I get the following:
$ git push
To github.com:ISNing/htransformation.git
 ! [remote rejected] ISNing/main -> ISNing/main (permission denied)
error: failed to push some refs to 'github.com:ISNing/htransformation.git'

Do you mind allowing me to push to your repository ? Otherwise I will get forced to open another PR that will overseed this one.

Ive invite you to be collaborator of my repository.
You should be able to access the branch as soon as you accepted the invitation.

Thanks a lot @ISNing !


[Bug] Incorrect syntax near '.' when loading lists on SQL server

Bug report
What I did
Updated backpack/crud from 5.1.2 to 5.4.7
What I expected to happen
What happened
Every crud list gives an error (MS SQL server and every model has a db schema):
SQLSTATE[42000]: [Microsoft][ODBC Driver 18 for SQL Server][SQL Server]Incorrect syntax near '.'. (SQL:
select count(*) as total_rows from (select [comm].[Contact].[ID] from [comm].[Contact]) as [comm].[Contact_aggregator]
)
What I've already tried to fix it
I guess this is a MS sql server only error, but I hope this can be fixed, or changed, so we can keep updating backpack.
It is the dot that causes the problem.
When I change line 250 in backpack/crud/src/app/Library/CrudPanel/Traits/Query.php
from
$outerQuery = $outerQuery->fromSub($subQuery->select($modelTable.'.'.$this->model->getKeyName()), $modelTable.'_aggregator');
to
$outerQuery = $outerQuery->fromSub($subQuery->select($modelTable.'.'.$this->model->getKeyName()), str_replace('.','_',$modelTable).'_aggregator');
the problem is solved.
Is it a bug in the latest version of Backpack?
Yes
Backpack, Laravel, PHP, DB version
When I run php artisan backpack:version the output is:
PHP VERSION:
PHP 7.4.29 (cli) (built: Apr 21 2022 10:16:36) ( NTS )
LARAVEL VERSION:
v8.83.17@2cf142cd5100b02da248acad3988bdaba5635e16
BACKPACK VERSION:
5.4.7@6e1bb116de9f3091530cb9b11edcceb4d252daa8

Up's, I guess that's on me! Sorry @WrdVdb 😞
I am just wondering why replacing . for _ in the $modelTable (aka $model->getTable()) would solve this. Why do you have a dot on the model table ? What's the output of your $model->getTable() ?
Cheers

I us a ms sql server, and it uses schema's, so schema.table. Without the schema in the model, it does not work.

@WrdVdb I am sorry, I am not a mssql user myself and don't have good insights on how it works.
So from your comments I guess that in your model you have something like: protected $table = 'schema.table_name' ?
I guess that under the hood eloquent deals with the . for your, but since we are doing raw queries it doesn't ?
Could you provide me a dump of some $query->toSql() (not the query we are trying to fix here, some other query)? Does the dot get replaced by underscore ? So it is something like select * from schema_table instead of select * from schema.table ?
My concern here is with mysql users that use a dot in the table name (it's not advised, but it's possible).
Cheers

So from your comments I guess that in your model you have something like: protected $table = 'schema.table_name' ?
That is correct, FI

protected $table = 'comm.Contact';
A query would look like this:
select * from [comm].[Contact] where [Email] = ?
The problem is that a alias is added manually in the query that uses the database name, and this can contain an dot.

Ok, so the problem is only on the alias name. Pfiewww 😅 , that's easier to solve, and we really don't care about the agreggator name.
I've submited the PR https://github.com/Laravel-Backpack/CRUD/pull/4784
Thanks for raising the issue and sticking with me to better understand it.
I will close this now 🙏
Cheers


HTTP example uses explicit strand : why

In https://github.com/boostorg/beast/blob/develop/example/http/server/async/http_server_async.cpp the session object uses an explicit strand. Why is this the case?
The Asio documentation says:

Where there is a single chain of asynchronous operations associated with a connection (e.g. in a half duplex protocol implementation like HTTP) there is no possibility of concurrent execution of the handlers. This is an implicit strand.

So why do we need an explicit strand?
Cheers
@vinniefalco @klemens-morgenstern

The beast::tcp_stream allows for specifying a timeout on the stream, which initiates a parallel async_wait on the timer for each asynchronous operation on the stream. Here is where a timeout is set in a specific example: https://github.com/boostorg/beast/blob/develop/example/http/server/async/http_server_async.cpp#L252.
Aside from that, in multi-threaded examples, not using a strand can lead to mistakes and concurrency bugs when users modify the examples for their purposes. These bugs are often silent and difficult to debug.

So i'm not using beast::tcp_stream just a normal tcp_socket. I don't need timers. So in my case, i have an implicit strand right?

Is it good practice in Asio/Beast to disregard the fact that you have an implicit strand and just use an explicit one anyway ? Doesn't that incur a performance overhead?

So i'm not using beast::tcp_stream just a normal tcp_socket. I don't need timers. So in my case, i have an implicit strand right?

Yes, If you design your application in a way that guarantees all operations on an I/O object (like asio::ip::tcp::socket) are sequential and no mutations occur after calling each initiating function, then you don't need a strand because there is no way to have two in-flight completion handlers.

Is it good practice in Asio/Beast to disregard the fact that you have an implicit strand and just use an explicit one anyway ? Doesn't that incur a performance overhead?

I would say the overhead is insignificant compared to the actual task scheduled for execution, so performance-wise, it doesn't make a difference in most applications.


feat: remove legacy variant callers (#295)

Coverage: 88.85% (-0.2%) from 89.023% when pulling 9db4670225b8090ac7fd51dce9cb6ddc0acddb82 on 295-remove-legacy-variant-callers into 6f2edd74f423ed7c65776e4f3943f228fca79990 on main.


Showing types for found definitions

Hey! Thank you for an amazing tool! That is something I have been missing from other theorem provers like Coq.
However, sometimes I want #find to print types of lemmas and definitions which it has found. The reason for that, is that for me, types are much more relevant than names.  When I see the list of suggestion, I first try to find the full type which I have in mind, and only then look at the correspondent name.
Here I implement an option find.showTypes, setting which to true will configure #find to show types as well.

Does that mean you are using loogle’s #find locally? (So far I assumed that all end users use the web service.)
How does that work out for you, in terms of package management, cache management etc? Do you use it on mathlib, or some other project?
As for this feature: We might just add it unconditionally, until someone actually asks for them to be printed without types.
You PR also adds #find as a tactic back. Do you use that actively? Not opposed in this case, but please add a docstring, or use @[inherit_doc …].

Actually, I am just starting with Lean, and still yet to start my first big Lean project :)
However, before I do that I want to port features that I miss from other theorem provers I used (i.e. Coq/Arend/...). One of those features is lemmas search.

Does that mean you are using loogle’s #find locally? (So far I assumed that all end users use the web service.)

Well, I tried to use mathlib's #find locally, but got annoyed very quickly: the search pattern is too restricted.  Then I tried loogle. Web service is nice, but from my experience, sometimes it is crucial to search in the local environment.

How does that work out for you, in terms of package management, cache management etc? Do you use it on mathlib, or some other project?

Performance wise, it is impressive: the first call of #find might take some time (not more than a minute), but all subsequent ones are immediate. So far I haven't used on mathlib.

As for this feature: We might just add it unconditionally, until someone actually asks for them to be printed without types.

We can change the default option to true in this case.

You PR also adds #find as a tactic back. Do you use that actively? Not opposed in this case, but please add a docstring, or use @[inherit_doc …].

Well, I almost always use #find in the middle of my proofs. That is because, I don't really care about the name of the lemma I need before I reach the point when I actually need it. I will add @[inherit_doc …] to #find tactic.

Performance wise, it is impressive: the first call of #find might take some time (not more than a minute), but all subsequent ones are immediate. So far I haven't used on mathlib.

That’s good to hear. We can probably make it even faster by building the two indices (constants and names) in parallel, or on-demand (only one index is used for each query). And it makes sense that it's fast enough™, even without a cache, for smaller projects that don't import mathlib.

That’s good to hear. We can probably make it even faster by building the two indices (constants and names) in parallel, or on-demand (only one index is used for each query)

That would be great!

Should we merge? :)


Add missing indices for update and creation time to all core tables

Default ordering in 'find' APIs is by the 'updated' field so this will help performance. Also lets us prune off objects by these fields quicker if needed.

Coverage increased (+0.02%) to 91.456% when pulling 6c5daed67c093bce828ee8750c8cea938430c88a on tgianos:addMissingIndices into d58da9e6570591fce13c5a1bf6e5126f7dbe5717 on Netflix:master.


patch to add the thread name to gelf message

trivial patch to add the thread name to gelf message only when addExtendedInfo is true
let me know if you'd rather have it as an optional field and i'll add the config parameters.

Hello,
Thanks for your help. Merged.
Anton


chore(package): update loglevel-mixin to version 1.6.0

https://greenkeeper.io/

Current coverage is 86.90% (diff: 100%)

Merging #78 into master will not change coverage

@@             master        #78   diff @@
==========================================
  Files             6          6
  Lines           252        252
  Methods          40         40
  Messages          0          0
  Branches         42         42
==========================================
  Hits            219        219
  Misses           33         33
  Partials          0          0

Powered by Codecov. Last update c78aace...d985173


Remove Travis

Remove travis since it never works and matter merging.

@shargon Could you do this again? https://github.community/t/expected-waiting-for-status-to-be-reported/18001/3


Suggestion: use Intel MKL for linear algebra operations

It appears that you are planning to roll your own linear algebra subroutines.
https://github.com/Dynmi/AlexNet/blob/1436d88cc1568ef4707de4985c1354764bacb772/src/matrix.c#L57-L59
You don't have to reinvent the wheel though, because there is Intel Math Kernel Library, a hyper-optimized library for scientific computing. Attempting to beat hundreds of human-years of engineering is probably not a good use of your time. :)
By the way, the library also runs on Intel GPUs, and some folks are working on Nvidia GPU support (source).

Oops, I missed this bit (emphasis mine)

This project is an unofficial implementation of AlexNet, using C Program Language Without Any 3rd Library, ...

Nevermind then!

Oops, I missed this bit (emphasis mine)

This project is an unofficial implementation of AlexNet, using C Program Language Without Any 3rd Library, ...

Nevermind then!


DBZ-142 Handle national character set columns in DDL parser

Handle the national character sets columns as described here  in the DDL parser.

@DennisPersson thanks for logging the issue and the pull request! This looks good.
Don't worry about the build failures; those are unrelated and we're trying to fix those ASAP. I'll then rebuild this PR and assuming that goes well I'll merge it.

@DennisPersson The PR needs to be rebased on master, and you need to do this if you want to stay on the commit. Or, if you'd rather, I can do this but then the commit will no longer be associated with you. Let me know what you prefer.

@rhauch It doesn't really matter if my name stays on the commit or not, but thanks for asking.
Anyway, I did a rebase now so the branch should be up to date with master now.


Revert "144 add media queries to header and adjust navbar"

bug makes the site stuck in refresh loop when in mobile mode

soled it


Kill archive and parchive tasks

This PR needs someone that knows the desired setup for osfstorage better than I do to look at it and make sure this is doing the right thing.
Ticket
https://openscience.atlassian.net/browse/SVCS-702
Purpose
We dont use them anymore, so this removes the celery tasks, and the code
inside the osfstorage provider that calls them.
Changes
Removes the celery tasks, and the code
inside the osfstorage provider that calls them.
Side effects
QA Notes

Deployment Notes

Coverage increased (+0.2%) to 91.964% when pulling 2343d1dec9bf67cd290c8079b8038590132712d8 on birdbrained:ft/kill-archive into 70c74baa4069acf722b33308bbc81aec7c6c78cb on CenterForOpenScience:develop.

Looks good!  I've remove a few more things and forced-pushed this branch.  Will merge now.  Thanks, @birdbrained!


Amazon Drive change URLs?

When filing an issue, please include the following information if possible as well as a description of the problem.  Make sure you test with the latest beta of rclone.
If you've just got a question then please use the rclone forum instead of filing an issue.

What is your rclone version (eg output from rclone -V)

Which OS you are using and how many bits (eg Windows 7, 64 bit)

Which cloud storage system are you using? (eg Google Drive)

The command you were trying to run (eg rclone copy /tmp remote:tmp)

A log from the command with the -v flag (eg output from rclone -v copy /tmp remote:tmp)

Sorry that launched a bit early. I've a 600GB transfer in progress which has stopped with an unexpected timeout. Disregard for now I was trying to build a report but inadvertently sent this without any data. I'm looking into it and will update if needed.
Regards,

OK I'll close this one, then you can open a new one when you have all the details.