fmt(cstyle): cstyle fixes in src/istgt_iscsi.c

Partially fixes https://github.com/openebs/openebs/issues/2008
Currently excludes the following tests:

line > 80 characters: 429 instances
improper boolean continuation: 48 instances
continuation line not indented by 4 spaces: 47 instances

The script used to fix a majority of the style errors can be found here. Perhaps the indentation errors could be solved via a similar tool.

Output of ./cstyle.pl | wc -l, for reference:
$ ./cstyle.pl src/istgt_iscsi.c | wc -l
     524

which is equivalent to the sum of the excluded test cases above.

Unfortunately, I can't see the output for Better Code Hub, but hopefully it's something related to one of the three errors I mentioned above.


calculated / derived metrics

This needs way more discussion, but putting this as an issue so that I remember.
We can have a calculated/derived metric that's composed of one or more regular metrics and stitched together by an expression of those metrics. These regular metrics still have to abide by the same rules as before -- i.e., they should be an aggregation with a single result column.

In the example above, the regular metrics are views, defined as SELECT SUM(views) FROM B, and signups, defined as SELECT SUM(signups) FROM A. Then they can be composed in various ways to form a derived metric - in the example above, the composing is defined by the expression signups / views to form a ratio.
There will have to various rules on this type of derived metric to make sure that (a) they are always operating on the same level and (b) that they share dimensions and specifically share all required dimensions.

@samredai You should also put your metric templating idea up in an issue! I think you had a nice diagram

@shangyian I'm worried if I create the issue we might actually do it 😭


C++ program for singly link list using class and methods

how to make this hacktoberfest accepted? @subhamtheone

Read the instructions carefully given in the repo

Can you assign this to me?


Linux: send to terminal

I see the options of tmux and screen, how can I send to R in gnome-terminal, pantheon-termin,... instead.
Many thanks!

@randy3k what is "screen" in linux?

@fabeit   [https://en.wikipedia.org/wiki/GNU_Screen]

SendText+ is now capable of sending code to gnome-terminal.


remove callback section

closes #1353

@abbycross already started text edits in PR #1379 so I'll just push code changes here.


Crash at start

Description of Issue: Crash
MCEdit Version: <IP_ADDRESS>
Minecraft Version the world was last opened in: Didn't even get to that part
Operating System: OSX
A screenshot or full text of the error from the console: https://pastebin.com/mSF3DuYj
How to reproduce: ???
Read before submitting
If we are not able to reproduce the error, we may ask for you to submit a world so we can test it. Same process for schematics.
If you have included enough information for each section, please delete the above header and all the text below.

The texture pack loading system is trying to read a file within the .app file, a quick fix would be to temporarily move any resource packs that you current have to another directory, run mcedit, and then move them back when you're done

Podshot, where exactly do I put the texture pack?


Search does not always respect .gitignore in subdirectories

VSCode Version: 1.43.1
OS Version: 16.04.5

I created a bug report previously, but back then I could not reproduce it, see https://github.com/microsoft/vscode/issues/89591
I experienced this problem again and now believe I know how to reproduce it.

Have a .gitignore in a root directory (with some ignores) and then a .gitignore in a sub-directory that might look like this:

/target/

Searching now yields no results in the /target/ directory
Click the Use Exclude Settings and Ignore Files (to disable it) and search, it should show results in the /target/ directory.
Enable  Use Exclude Settings and Ignore Files and search again. It now still shows results in the /target/ directory.

Does this issue occur when all extensions are disabled?: Yes

Did you open some of those files after step 3? If so you will always see results in files that are open in editors.

Entirely possible, and that also makes sense to me. I guess again I'll have to close (and potentially re-open) if I experience this again. Feel like I'm taking too much of your time now.

No worries, it's always possible that there are bugs too


Play single audio file without repeating

I used only 1 item in the array and the player worked fine however the audio is getting played in a loop. I used the trackEnded callback but couldn't find a way to stop the player.

how to get instance of audio player and is there any method to stop audio ?

I used only 1 item in the array and the player worked fine however the audio is getting played in a loop. I used the trackEnded callback but couldn't find a way to stop the player.

You can empty the track array on trackEnded callback. (You can push the track in array again if you want to see it on page)
sample
onEnded($event): void {
this.msaapPlaylist = [];
this.msaapPlaylist.push({
title: 'Play One Track Only',
// link: '../../assets/audios/005_30_second.mp3',
link: 'https://www.w3schools.com/html/horse.ogg',
artist: 'Pulkit',
});
}

Thanks. that worked

Feature available in v8.1.4, v9.2.3, v10.1.4 and v11.0.4.


docs: update README.md with setup instructions

Description
Added setting up instructions to README.md file
Fixes #25
Flutter Channel:

[x] I have used the Flutter Beta channel on my local machine

Type of Change:

Documentation

How Has This Been Tested?
This is tested by running the application after setup. A successful setup will result in successful running of application as per screenshot below.

Checklist:

[x] My PR follows the style guidelines of this project
[x] I have performed a self-review of my own code or materials
[x] I have made corresponding changes to the documentation

@Techno-Disaster and @bartekpacia, should I add the adnroid/ and pubspec.loc into .gitignore?

Nice job:)
Could you remove all the other changes except for README? They're not necessary.

Nice job:)
Could you remove all the other changes except for README? They're not necessary.

Ok, so I'll add them to .gitignore, right @bartekpacia? Or not necessary means I have to delete them from my project folders as well? I don't quite get you. Can you please explain

Also @bartekpacia, I found the location for API_URL in constants.dart and tried to change it to localhost (<IP_ADDRESS>:5000) but that didn't work. When I tried to login, it says 'No internet connection'.

@mtreacy002 I mean that you should you remove all files except README.md from being tracked by git (https://stackoverflow.com/questions/1274057/how-to-make-git-forget-about-a-file-that-was-tracked-but-is-now-in-gitignore). These files are auto-generated and/or specific to your machine so we don't need them in the repository.
Also try changing localhost to "http://<IP_ADDRESS>:4000" (add "http:)

@mtreacy002 I mean that you should you remove all files except README.md from being tracked by git (https://stackoverflow.com/questions/1274057/how-to-make-git-forget-about-a-file-that-was-tracked-but-is-now-in-gitignore). These files are auto-generated and/or specific to your machine so we don't need them in the repository.
Also try changing API_URL to http://<IP_ADDRESS>:4000 (add http, if doesn't work, try with and without the trailing /)

Ok, will try your suggestion (to make git untracked the files).
Tried the http option with and without trailing '/' but still no luck. also the port is 5000 isn't it?

mmm... it says pubspec.lock is conflicting. Is that bcoz I remove it from being tracking by git? I did the git rm --cached pubspec.lock as per @bartekpacia suggested as well as to the rest of the files that accidentally got attached before. But only this one (pubspec) says conflict.
Also, when I run git status from my terminal I couldn't see the conflict.

The Resolve conflicts button here is also disabled. Can you please advise how to solve this, @Techno-Disaster or @bartekpacia?

mmm... it says pubspec.lock is conflicting. Is that bcoz I remove it from being tracked by git? I did the git rm --cached pubspec.lock as per @bartekpacia suggested as well as to the rest of the files that accidentally got attached before. But only this one (pubspec) says conflict.
Also, when I run git status from my terminal I couldn't see the conflict.

The Resolve conflicts button here is also disabled. Can you please advise how to solve this, @Techno-Disaster or @bartekpacia?

wait pubspec lock shoudn't be ignored, please remove it frm git ignore

Nice job:)
Could you remove all the other changes except for README? They're not necessary.

readme and pubspec.lock file too.It shoudn't be added to git ignore

Nice job:)
Could you remove all the other changes except for README? They're not necessary.

readme and pubspec.lock file too.It shoudn't be added to git ignore

Ok, I'll add it again then... 😂

Ok, so, I remove the pubspec'lock from gitignore, but I can't seem to undo the delete already done previously and the merge still has it as conflicting file. should I try to delete it from the `file changes'?

I think I need to close this PR and the working branch coz I can't get the pubspec.lock back after deleting it. would this be ok, @Techno-Disaster and @bartekpacia ? I'll refer this PR in the new one to make sure we can still refer to the communication here.

I think I need to close this PR and the working branch coz I can't get the pubspec.lock back after deleting it. would this be ok, @Techno-Disaster and @bartekpacia ? I'll refer this PR in the new one to make sure we can still refer to the communication here.

yes, messing with git is a part of the developer journey. You can delete the PR then git reset ur fork to the original repo make the changes again and send a new PR


35 console matrix does not show list of available applications

Overriding merge check. Checks are failing on the destroy only due to a problem in IBM Cloud with resource group deletion.


Feature request: support multi-range document formatting

Now that ProvideDocumentRangeFormattingEditsSignature with batch formatting support is added in vscode, could we also add support in the language client as well? Reading through the source code, I suppose this is very easy to implement as we only need to check the server capability and forward parameters to the server.
@c-claeys Do you have any plan to implement this? If not, I can help to draft the change.

PR absolutely welcome

I've been on vacation but I was planning on sending a PR now that I'm back. @daiyousei-qz let me know if you'd prefer otherwise you could help review it instead

I've been on vacation but I was planning on sending a PR now that I'm back. @daiyousei-qz let me know if you'd prefer otherwise you could help review it instead

Please go ahead. I meant to help if you don't have cycles to work on this. Thank you for proposing this fix to LSP!

This is already in.


Add nushell support

Fixes #1441 #1254
The real issue wasn't the missing Nushell class, but rather sys.stdout.write failing to make nushell run the command.
I've fixed that by running a subprocess, however it lacks access to any config/env that is set in the current session, it could be fixed by adding an -l flag to the command, but that will also run anything that run on login (like neofetch).
Still, also added a Nushell class with the relevant overrides.
What do you think @nvbn ? Anything that could be changed let me know, it's my first time writing Python so I'm sure there are things that could be done better

CC @scorphus
Hopefully it's okay to ping you as I see you've made the last release :)

Just tested it on my machine. Nice work!


Unnecessary values in JSON

such as version, access_count, crc (which has already been checked) etc.
remove and send only important attributes
or make verbose mode which sends everything?

No need to not be verbose when:
JSON will get sent periodically until PC-side ACKs => stop sending (terminate task). When data-collector is running, it does not perform operations which would change WL status; safe to assume JSON would be the same for all runtime.
ACKing and terminating the sending task might not even be necessary; if we don't mind little bit of spamming


update(falco): update cpp-httplib to 0.11.3

Signed-off-by: Luca Guerra<EMAIL_ADDRESS>
What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

What this PR does / why we need it:
Update cpp-httplib with the latest version. Fixes potential DoS issue https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=49740 disclosed on 2022-10-31
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: LucaGuerra
Once this PR has been reviewed and has the lgtm label, please assign andreagit97 for approval by writing /assign @andreagit97 in a comment. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, jasondellaluce, LucaGuerra
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/milestone 0.34.0


Rename IPromise.Transform to IPromise.Then

Its not ambiguous and you only have to remember 1 method. I use Dart which has a standard Futures library and I find it a lot easier.

I wish that were possible. I haven't found a way to have Transform be Then and still compile.
If you can find a way to do this please fork the repo, make the change and submit a pull request.
I'd be very keen to have it work the way you suggest.

Hi @ashleydavis,
I think #1 made possible refactoring Transform to Then. I did it on my version project and it worked with no compiler errors out of the box. I'll try to open the git repo by itself and refactor + pass some changes I made:

I added a new public Promise<PromisedT> (PromisedT value) constructor to create a resolved promise, it seemed important because this is the monadic "Return" function.
Changed the internals of Transform (now called Then) to just "fallback" to the "bind" Then using the new constructor like this:

        public IPromise<ConvertedT> Then<ConvertedT>(Func<PromisedT, ConvertedT> f)
        {
            //Argument.NotNull(() => transform);
            return Then((PromisedT t) => (IPromise<ConvertedT>)new Promise<ConvertedT>(f(t)));
        }

I have experience with Futures/Promises since I made my own Futures library for the project, as far as I saw it worked perfectly but I decided not to use your library once #1 was solved.

I'll be really happy if you can get Transform changed to Then ;)
Please submit a PR when you are ready to get your change in.


feature: shorthand syntax

Since you're moving away from / extending EmmyLua, I wondered if there could be a shorthand syntax for some annotations.
The ones I have in mind are
---@params fu number, bar string

as a shorthand for
---@param fu number
---@param bar string

similar to how multiple returns already work.
And the ---@as type already mentioned in #1106.
thanks for the great work on version 3!

After some thought, I decided to reject this requirement.
Compared with the original writing method, this is just a syntax sugar, but it loses the function of comments.
The ---@type x, y way (see #993) will also lose the comments function, but it can provide functions that were not possible before.
Similar features in other languages are written on multiple lines, and I think consistency is necessary.
Moreover, supporting multiple ways at the same time will bring unnecessary complexity and performance loss to the implementation.

Thank you for the info. Personally I don't use the comment feature at all. I use the type annotations mainly for autocompletion while coding and together with function and parameter naming this is in most cases already enough documentation. In this use case the short hand syntax encourages to annotate more types because it is less verbose. It would be more of an annotaed Typescript version of Lua. But I totally understand the point of unnecessary complexity in the implementation!

In case anyone esle looking for this: I only now realized that this is possible with the fun annotation!

---@type fun(fu: number, bar: string)
function test(fu, bar) end

when using it with : notation, don't forget to define self:
---@type fun(self, fu: number, bar: string)
function myTable:test(fu, bar) end


[Package Issue]: 360.360Zip ----- download link error

Please confirm these before moving forward

[X] I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
[X] I have not been informed if the issue is resolved in a preview version of the winget client.

Category of the issue
Installation issue.
Brief description of your issue
can't download this package because of link inexistent
Steps to reproduce
---------winget install 360.360Zip
then error msg
InternetOpenUrl() failed.
0x80072efd : unknown error

Actual behavior
the download link of this package is wrong
Expected behavior
succeed downloading and installing.
Environment
winget --info
Windows 程序包管理器 v1.5.2201
版权所有 (C) Microsoft Corporation。保留所有权利。

Windows: Windows.Desktop v10.0.22621.2283
系统体系结构: X64
软件包: Microsoft.DesktopAppInstaller v1.20.2201.0

Winget Directories
-----------------------------------------------------------------------------------------------------------------------
Logs                               %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\Diag…
User Settings                      %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\sett…
Portable Links Directory (User)    %LOCALAPPDATA%\Microsoft\WinGet\Links
Portable Links Directory (Machine) C:\Program Files\WinGet\Links
Portable Package Root (User)       %LOCALAPPDATA%\Microsoft\WinGet\Packages
Portable Package Root              C:\Program Files\WinGet\Packages
Portable Package Root (x86)        C:\Program Files (x86)\WinGet\Packages

链接
----------------------------------------------------------------------------
隐私声明             https://aka.ms/winget-privacy
许可协议             https://aka.ms/winget-license
第三方声明           https://aka.ms/winget-3rdPartyNotice
主页                 https://aka.ms/winget
Windows 应用商店条款 https://www.microsoft.com/en-us/storedocs/terms-of-sale

管理员设置                                状态
------------------------------------------------
LocalManifestFiles                        已禁用
BypassCertificatePinningForMicrosoftStore 已禁用
InstallerHashOverride                     已禁用
LocalArchiveMalwareScanOverride           已禁用

Screenshots and Logs
2023-09-25 16:10:26.162 [CORE] WinGet, version [1.5.2201], activity [{8B8FD12F-3AE5-42A1-8CC7-28CF06126339}]
2023-09-25 16:10:26.162 [CORE] OS: Windows.Desktop v10.0.22621.2283
2023-09-25 16:10:26.162 [CORE] Command line Args: "C:\Users\kldac\AppData\Local\Microsoft\WindowsApps\winget.exe" install 360.360Zip
2023-09-25 16:10:26.162 [CORE] Package: Microsoft.DesktopAppInstaller v1.20.2201.0
2023-09-25 16:10:26.162 [CORE] IsCOMCall:0; Caller: winget-cli
2023-09-25 16:10:26.165 [CLI ] WinGet invoked with arguments: 'install' '360.360Zip'
2023-09-25 16:10:26.165 [CLI ] Found subcommand: install
2023-09-25 16:10:26.165 [CLI ] Leaf command to execute: root:install
2023-09-25 16:10:26.168 [CLI ] Executing command: install
2023-09-25 16:10:26.175 [REPO] Source named 'winget' is already defined at origin User. The source from origin Default is dropped.
2023-09-25 16:10:26.176 [REPO] Default source requested, multiple sources available, adding all to source references.
2023-09-25 16:10:26.176 [REPO] Adding to source references winget
2023-09-25 16:10:26.176 [REPO] Adding to source references msstore
2023-09-25 16:10:26.176 [REPO] Source past auto update time [5 mins]; it has been at least 5 mins
2023-09-25 16:10:26.670 [CORE] Examining extension: PFN = Microsoft.Winget.Source_8wekyb3d8bbwe, ID = IndexDB
2023-09-25 16:10:26.670 [CORE] Found matching extension.
2023-09-25 16:10:26.673 [REPO] Remote source data was not newer than existing, no update needed
2023-09-25 16:10:26.681 [REPO] Source named 'winget' is already defined at origin User. The source from origin Default is dropped.
2023-09-25 16:10:26.682 [REPO] Source past auto update time [5 mins]; it has been at least 5 mins
2023-09-25 16:10:26.682 [REPO] Multiple sources available, creating aggregated source.
2023-09-25 16:10:26.682 [REPO] Adding to aggregated source: winget
2023-09-25 16:10:26.686 [CORE] Examining extension: PFN = Microsoft.Winget.Source_8wekyb3d8bbwe, ID = IndexDB
2023-09-25 16:10:26.686 [CORE] Found matching extension.
2023-09-25 16:10:26.707 [REPO] Opening SQLite Index for ImmutableRead at 'C:\Program Files\WindowsApps\Microsoft.Winget.Source_2023.924.1943.678_neutral__8wekyb3d8bbwe\Public\index.db'
2023-09-25 16:10:26.707 [SQL ] Opening SQLite connection #1: 'C:\Program Files\WindowsApps\Microsoft.Winget.Source_2023.924.1943.678_neutral__8wekyb3d8bbwe\Public\index.db' [1, 40]
2023-09-25 16:10:26.708 [REPO] Opened SQLite Index with version [1.6], last write [2023-09-25 02:42:23.000]
2023-09-25 16:10:26.741 [REPO] Adding to aggregated source: msstore
2023-09-25 16:10:26.742 [REPO] Sending http GET request to: https://storeedgefd.dsx.mp.microsoft.com/v9.0/information
2023-09-25 16:10:26.903 [REPO] Response status: 200
2023-09-25 16:10:26.903 [REPO] Sending http GET request to: https://storeedgefd.dsx.mp.microsoft.com/v9.0/information
2023-09-25 16:10:26.943 [REPO] Response status: 200
2023-09-25 16:10:27.060 [REPO] Source named 'winget' is already defined at origin User. The source from origin Default is dropped.
2023-09-25 16:10:27.061 [REPO] Source named 'winget' is already defined at origin User. The source from origin Default is dropped.
2023-09-25 16:10:27.061 [REPO] Creating PredefinedInstalledSource with filter [None]
2023-09-25 16:10:27.061 [REPO] Creating new SQLite Index with version [Latest] at ':memory:'
2023-09-25 16:10:27.061 [SQL ] Opening SQLite connection #2: ':memory:' [6, 0]
2023-09-25 16:10:27.098 [REPO] Reading MSI UpgradeCodes
2023-09-25 16:10:27.099 [REPO] Examining ARP entries for Machine | X64
2023-09-25 16:10:27.107 [REPO] Examining ARP entries for Machine | X86
2023-09-25 16:10:27.120 [REPO] Reading MSI UpgradeCodes
2023-09-25 16:10:27.121 [REPO] Examining ARP entries for User | X64
2023-09-25 16:10:27.424 [REPO] Opening SQLite Index for ReadWrite at 'C:\Users\kldac\AppData\Local\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\Microsoft.Winget.Source_8wekyb3d8bbwe\installed.db'
2023-09-25 16:10:27.425 [SQL ] Opening SQLite connection #3: 'C:\Users\kldac\AppData\Local\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\Microsoft.Winget.Source_8wekyb3d8bbwe\installed.db' [2, 0]
2023-09-25 16:10:27.425 [REPO] Opened SQLite Index with version [1.6], last write [2023-09-25 15:06:06.000]
2023-09-25 16:10:27.473 [REPO] Downloading manifest
2023-09-25 16:10:27.473 [CORE] WinINet downloading from url: https://mirrors.ustc.edu.cn/winget-source/manifests/3/360/360Zip/<IP_ADDRESS>1/5a5a-360.360Zip.yaml
2023-09-25 16:10:27.476 [CORE] Download hash: 8a93502cafdce4f10ada081f779851d2fb7c1e201caa25833c315590f139795b
2023-09-25 16:10:27.476 [CORE] Download completed.
2023-09-25 16:10:27.478 [REPO] Finding installed package from available package using system reference search: Query:[none] Include:ProductCode='360zip'[Exact] Include:NormalizedNameAndPublisher='360 zip'+'360 security center'[Exact] Include:NormalizedNameAndPublisher='360zip'+'securitycenter'[Exact]
2023-09-25 16:10:27.484 [REPO] Opening SQLite Index for ReadWrite at 'C:\Users\kldac\AppData\Local\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\StoreEdgeFD\installed.db'
2023-09-25 16:10:27.484 [SQL ] Opening SQLite connection #4: 'C:\Users\kldac\AppData\Local\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\StoreEdgeFD\installed.db' [2, 0]
2023-09-25 16:10:27.484 [REPO] Opened SQLite Index with version [1.6], last write [2023-09-21 20:06:21.000]
2023-09-25 16:10:27.518 [REPO] Sending http POST request to: https://storeedgefd.dsx.mp.microsoft.com/v9.0/manifestSearch
2023-09-25 16:10:28.128 [REPO] Response status: 200
2023-09-25 16:10:28.132 [REPO] Opening pinning index
2023-09-25 16:10:28.132 [REPO] Opening existing pinning index
2023-09-25 16:10:28.132 [REPO] Opening SQLite Index for ReadWrite at 'C:\Users\kldac\AppData\Local\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\pinning.db'
2023-09-25 16:10:28.132 [SQL ] Opening SQLite connection #5: 'C:\Users\kldac\AppData\Local\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\pinning.db' [2, 0]
2023-09-25 16:10:28.133 [REPO] Opened Pinning Index with version [1.0], last write [2023-09-20 13:25:55.000]
2023-09-25 16:10:28.137 [CLI ] Found one app. App id: 360.360Zip App name: 360 Zip
2023-09-25 16:10:28.139 [REPO] Downloading manifest
2023-09-25 16:10:28.139 [CORE] WinINet downloading from url: https://mirrors.ustc.edu.cn/winget-source/manifests/3/360/360Zip/<IP_ADDRESS>1/5a5a-360.360Zip.yaml
2023-09-25 16:10:28.140 [CORE] Download hash: 8a93502cafdce4f10ada081f779851d2fb7c1e201caa25833c315590f139795b
2023-09-25 16:10:28.140 [CORE] Download completed.
2023-09-25 16:10:28.142 [CLI ] Starting installer selection.
2023-09-25 16:10:28.142 [CLI ] Completed installer selection.
2023-09-25 16:10:28.142 [CLI ] Manifest fields: Name [360 Zip], Version [<IP_ADDRESS>1]
2023-09-25 16:10:28.156 [CLI ] Found existing installer file at 'C:\Users\kldac\AppData\Local\Temp\WinGet\360.360Zip.<IP_ADDRESS>1\f73b94d8b36e8a00d4b29fd9f739a541f338caa8b78aa803e7a0bcf7edfe80a2'. Verifying file hash.
2023-09-25 16:10:28.156 [CLI ] Hash does not match. Removing existing installer file C:\Users\kldac\AppData\Local\Temp\WinGet\360.360Zip.<IP_ADDRESS>1\f73b94d8b36e8a00d4b29fd9f739a541f338caa8b78aa803e7a0bcf7edfe80a2
2023-09-25 16:10:28.156 [CLI ] Failed to remove installer file. Reason: remove:   һ          ʹ ô  ļ        ޷    ʡ : "C:\Users\kldac\AppData\Local\Temp\WinGet\360.360Zip.<IP_ADDRESS>1\f73b94d8b36e8a00d4b29fd9f739a541f338caa8b78aa803e7a0bcf7edfe80a2"
2023-09-25 16:10:28.161 [CLI ] Generated temp download path: C:\Users\kldac\AppData\Local\Temp\WinGet\360.360Zip.<IP_ADDRESS>1\f73b94d8b36e8a00d4b29fd9f739a541f338caa8b78aa803e7a0bcf7edfe80a2
2023-09-25 16:10:28.161 [CORE] Downloading to path: C:\Users\kldac\AppData\Local\Temp\WinGet\360.360Zip.<IP_ADDRESS>1\f73b94d8b36e8a00d4b29fd9f739a541f338caa8b78aa803e7a0bcf7edfe80a2
2023-09-25 16:10:28.161 [CORE] DeliveryOptimization downloading from url: https://free.360totalsecurity.com/360zip/360zip_setup_<IP_ADDRESS>1.exe
2023-09-25 16:10:34.972 [CORE] DeliveryOptimization error: 0x80072efd, extended error: 0x00000000
2023-09-25 16:10:34.972 [FAIL] D:\a_work\1\s\external\pkg\src\AppInstallerCommonCore\DODownloader.cpp(289)\WindowsPackageManager.dll!00007FFBDD81A5BD: (caller: 00007FFBDD81AE61) Exception(1) tid(1cb8) 80072EFD
2023-09-25 16:10:34.978 [CORE] Started applying motw to C:\Users\kldac\AppData\Local\Temp\WinGet\360.360Zip.<IP_ADDRESS>1\f73b94d8b36e8a00d4b29fd9f739a541f338caa8b78aa803e7a0bcf7edfe80a2 with zone: 3
2023-09-25 16:10:34.981 [CORE] Finished applying motw
2023-09-25 16:10:34.982 [CORE] WinINet downloading from url: https://free.360totalsecurity.com/360zip/360zip_setup_<IP_ADDRESS>1.exe
2023-09-25 16:10:35.439 [FAIL] D:\a_work\1\s\external\pkg\src\AppInstallerCommonCore\Downloader.cpp(52)\WindowsPackageManager.dll!00007FFBDD7FAEEE: (caller: 00007FFBDD7FBDA9) Exception(2) tid(1cb8) 80072EFD     Msg:[InternetOpenUrl() failed.]
2023-09-25 16:10:35.593 [CLI ] Failed to download, waiting a bit and retry. Url: https://free.360totalsecurity.com/360zip/360zip_setup_<IP_ADDRESS>1.exe
2023-09-25 16:10:36.101 [CORE] Downloading to path: C:\Users\kldac\AppData\Local\Temp\WinGet\360.360Zip.<IP_ADDRESS>1\f73b94d8b36e8a00d4b29fd9f739a541f338caa8b78aa803e7a0bcf7edfe80a2
2023-09-25 16:10:36.101 [CORE] DeliveryOptimization downloading from url: https://free.360totalsecurity.com/360zip/360zip_setup_<IP_ADDRESS>1.exe
2023-09-25 16:10:40.158 [CORE] DeliveryOptimization error: 0x80072efd, extended error: 0x00000000
2023-09-25 16:10:40.158 [FAIL] D:\a_work\1\s\external\pkg\src\AppInstallerCommonCore\DODownloader.cpp(289)\WindowsPackageManager.dll!00007FFBDD81A5BD: (caller: 00007FFBDD81AE61) Exception(3) tid(1cb8) 80072EFD
2023-09-25 16:10:40.159 [CORE] Started applying motw to C:\Users\kldac\AppData\Local\Temp\WinGet\360.360Zip.<IP_ADDRESS>1\f73b94d8b36e8a00d4b29fd9f739a541f338caa8b78aa803e7a0bcf7edfe80a2 with zone: 3
2023-09-25 16:10:40.160 [CORE] Finished applying motw
2023-09-25 16:10:40.160 [CORE] WinINet downloading from url: https://free.360totalsecurity.com/360zip/360zip_setup_<IP_ADDRESS>1.exe
2023-09-25 16:10:40.594 [FAIL] D:\a_work\1\s\external\pkg\src\AppInstallerCommonCore\Downloader.cpp(52)\WindowsPackageManager.dll!00007FFBDD7FAEEE: (caller: 00007FFBDD7FBDA9) Exception(4) tid(1cb8) 80072EFD     Msg:[InternetOpenUrl() failed.]
2023-09-25 16:10:40.643 [CLI ] Caught wil::ResultException: D:\a_work\1\s\external\pkg\src\AppInstallerCommonCore\Downloader.cpp(52)\WindowsPackageManager.dll!00007FFBDD7FAEEE: (caller: 00007FFBDD7FBDA9) Exception(4) tid(1cb8) 80072EFD     Msg:[InternetOpenUrl() failed.]

This seems to be an issue with your connection or specific to your instance of WinGet. I've tested this on a few different computers and all seemed to work for me. I've also checked on the 360Zip website and the URL matches what is in the manifest.
--> Installing WinGet
--> Disabling safety warning when running installer
Tip: you can type 'Update-EnvironmentVariables' to update your environment variables, such as after installing a new software.

--> Configuring Winget
Enabled admin setting 'LocalManifestFiles'.
Enabled admin setting 'LocalArchiveMalwareScanOverride'.

--> Installing the Manifest <IP_ADDRESS>1

Found 360 Zip [360.360Zip] Version <IP_ADDRESS>1
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://free.360totalsecurity.com/360zip/360zip_setup_<IP_ADDRESS>1.exe
  ██████████████████████████████  6.50 MB / 6.50 MB
Successfully verified installer hash
Starting package install...
Successfully installed

--> Refreshing environment variables

--> Comparing ARP Entries

DisplayName DisplayVersion Publisher           ProductCode Scope
----------- -------------- ---------           ----------- -----
360 Zip     <IP_ADDRESS>1     360 Security Center 360zip      Machine

This seems to be an issue with your connection or specific to your instance of WinGet. I've tested this on a few different computers and all seemed to work for me. I've also checked on the 360Zip website and the URL matches what is in the manifest.
--> Installing WinGet
--> Disabling safety warning when running installer
Tip: you can type 'Update-EnvironmentVariables' to update your environment variables, such as after installing a new software.

--> Configuring Winget
Enabled admin setting 'LocalManifestFiles'.
Enabled admin setting 'LocalArchiveMalwareScanOverride'.

--> Installing the Manifest <IP_ADDRESS>1

Found 360 Zip [360.360Zip] Version <IP_ADDRESS>1
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://free.360totalsecurity.com/360zip/360zip_setup_<IP_ADDRESS>1.exe
  ██████████████████████████████  6.50 MB / 6.50 MB
Successfully verified installer hash
Starting package install...
Successfully installed

--> Refreshing environment variables

--> Comparing ARP Entries

DisplayName DisplayVersion Publisher           ProductCode Scope
----------- -------------- ---------           ----------- -----
360 Zip     <IP_ADDRESS>1     360 Security Center 360zip      Machine

Thank you for providing another kind of test result. It's me that should make it work.


add magnetometer support to Android, written by @fluffrabbit

support added via Input.get_magnetometer()
I've commited this because @akien-mga closed #4010 due to rude language in commit messages.

NOTE: I've not tested this code (and I'm not an author).

Not just due to rude language in commit messages, but to non-constructive (and yeah, overall rude) behaviour. Also the author mentioned everywhere that it was copy pasted stuff, and apparently you too haven't tested the changes, so I'm against merging it until someone really takes the time to test the code instead of just copy-pasting from StackOverflow.

Also the various // copypasta comments don't bring much. Yes, Godot's source is not much commented so adding new comments is good, but they should serve a purpose, not just "hey this was a copy paste so if it's bad, don't blame me".

First of all, I want to make it clear that I'm 100% in favor of testing, lest someone were to push code that didn't work. Most Android devices have magnetometers so this shouldn't be a problem for anyone who can compile Godot.
@akien-mga You're making this really personal. As I explained on IRC, which I'm pretty sure you were around to hear, I didn't copypaste a single line from SO; all the copypasta is from Godot's own existing code for accelerometers to ensure that code for the magnetometer works the exact same way.  That's an entirely different issue. Let's keep politics out of this.

This should be a pretty simple patch so there's no point in fighting over
it. We call a thing from the Android (and eventually ios) API, it gives us
a number, we give that number to the game. Even if we don't merge it right
away for whatever reason (it doesn't seem to be a popular feature), having
the pull request around means somebody who needs it can use it, because
it's simple enough that it will merge with newer changes to master or 2.0
or whatever, or at least that's what the git black magic seems to imply :)
So for now everybody is happy.
On 30 March 2016 at 12:29, fluffrabbit<EMAIL_ADDRESS>wrote:

First of all, I want to make it clear that I'm 100% in favor of testing,
lest someone were to push code that didn't work. Most Android devices have
magnetometers so this shouldn't be a problem for anyone who can compile
Godot.
@akien-mga https://github.com/akien-mga You're making this really
personal. As I explained on IRC, which I'm pretty sure you were around to
hear, I didn't copypaste a single line from SO; all the copypasta is from
Godot's own existing code for accelerometers to ensure that code for the
magnetometer works the exact same way.  That's an
entirely different issue. Let's keep politics out of this.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/godotengine/godot/pull/4154#issuecomment-203488887

if it helps the engine it should be approved.

I would like to have this, please. I'll probably end up using it anyway, but it's cleaner if i don't have to maintain a custom local branch.

The problem is, nobody tested this code so far, and it would be meaningless to merge some code if it does not work.
See e.g. https://github.com/godotengine/godot/pull/4154/commits/2de25e28256d0fe73c7f47fcfc5f71af76205618#diff-9aa0676e56e76903d0051c7670e1ddbdR790 where the comment shows that this was not tested by the author. And indeed, the constant used does not exist in the Android API, if you google for it the only match that you get is... this pull request.
So no, this won't be merged until someone takes it seriously and works on an implementation that works (and hopefully does it for iOS too). The existing code is a useful starting point, but it's not ready for merge yet.

Hm, fair enough.

Well it works for me, bugs or no. It's working for somebody else too. And I'm not 100% sure you're right about the flags there, I recall there was some reason I used what I used but I've long since forgotten. I guess when you're so critical of something you're bound to find a problem sooner or later. Try reviewing the whole Godot codebase and I'm sure you'll find a few more.

And I'm not 100% sure you're right about the flags there, I recall there was some reason I used what I used but I've long since forgotten.

http://lmgtfy.com/?q="ASENSOR_TYPE_MAGNETOMETER"

Try reviewing the whole Godot codebase and I'm sure you'll find a few more.

Which I do: https://github.com/godotengine/godot/pulls?q=is%3Apr+author%3Aakien-mga+is%3Aclosed

http://lmgtfy.com/?q="ASENSOR_TYPE_MAGNETOMETER"

Try different Google, and you will find not dull critique, but a solution:
http://developer.android.com/ndk/reference/group___sensor.html

Try different Google, and you will find not dull critique, but a solution:
http://developer.android.com/ndk/reference/group___sensor.html

Which I found already and gave as a solution yesterday: https://github.com/godotengine/godot/pull/4154#issuecomment-216241482
So this was not dull critique, I was just responding to @fluffrabbit's suggestion that I might be doing a PITA review of this PR while I wouldn't be of others. I'm just a PITA on this PR because it's quality is lower than that of other PRs in this repo.

I lent a hand where it was needed, but I am by no means a career programmer. Sure, remove comments, remove trailing whitespace, remove this or that, but the point is that it works (sort of). Anyhow this is no longer my PR and I'm not going to make further PRs on this PR. @Marqin, you made this your project, but as we've seen I don't think Akien can be reasoned with. @akien-mga stop making demands. This is supposed to be a democracy, and the people have spoken.
On a slightly off topic note, since magnetometers will probably by most people be used for sensor fusion to get the device orientation, I imagine the bulk of the Godot userbase, who are (no offense) less technical than engineers, will get rather frustrated trying to hack together something that works, what with all the math and the different calibrations of different devices. I'm probably the first of them to encounter the issue of sensor fusion working one place but not another since that GDscript is my own code, so this is fair warning. Android has its own sensor fusion APIs, but of course those are different from those of iOS, and the powers that be seem to want this ported to iOS, so it's a big inter-platform rodeo. Fair warning to the devs.

I just noticed that my phone has a magnetic sensor so I'm gonna test this tomorrow. A quick glance can see some weird stuff, but I'm gonna review it properly tomorrow, so we can try to end this stuff once and for all (probably gonna be easier to do a new PR myself).
For @fluffrabbit and @Marqin: don't take this personally. Akien might be a bit too harsh sometimes but this is to make Godot have quality code. The second post clearly states this is not tested, so you can't blame him for rejecting the PR. And the comments are clearly not helpful and unprofessional.

This is supposed to be a democracy, and the people have spoken.

This is not supposed to be a democracy. Open source project have always been meritocratic. The opinion of "the people" is of course very valuable and (in our project at least) highly regarded, but in the end it's the code quality that counts.
As I mentioned already, I'm all for adding magnetometer support, it sounds like a great feature that could benefit various users. But I want it done right.

This is supposed to be a democracy, and the people have spoken.

I don't think that "the people have spoken". I was interested in this PR, but given attitudes of both authors and code quality i feel that a saner approach would be to rewrite it myself in order to avoid having unstable and incompetent maintainers.

Superseded by #4845.


[FIX] Rename Protocol classes

Fixes #33
Changes proposed in this pull request:

Before submitting

[ ] I've read and followed all steps in the Making a pull request
section of the CONTRIBUTING docs.
[ ] I've updated or added any relevant docstrings following the syntax described in the
Writing docstrings section of the CONTRIBUTING docs.
[ ] If this PR fixes a bug, I've added a test that will fail without my fix.
[ ] If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

[ ] All GitHub Actions jobs for my pull request have passed.

Codecov Report

Merging #35 (6be5a34) into main (3c8427b) will not change coverage.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##             main      #35   +/-   ##
=======================================
  Coverage   67.17%   67.17%
=======================================
  Files          12       12
  Lines         655      655
  Branches      125      125
=======================================
  Hits          440      440
  Misses        174      174
  Partials       41       41

Impacted Files
Coverage Δ

dodiscover/constraint/_classes.py
0.00% <0.00%> (ø)

dodiscover/_protocol.py
61.53% <100.00%> (ø)

dodiscover/ci/oracle.py
86.95% <100.00%> (ø)

dodiscover/constraint/utils.py
46.15% <100.00%> (ø)

dodiscover/context.py
67.39% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Is there a reason to not be explicit about that they are 'Protocols'?

Is there a reason to not be explicit about that they are 'Protocols'?

Isn't that what was suggested here tho? https://github.com/py-why/dodiscover/issues/33

Is there a reason to not be explicit about that they are 'Protocols'?

@bloebp Have a look at https://developer.okta.com/blog/2019/06/25/iinterface-considered-harmful and replace Java interfaces with Python Protocols and the I-prefix with the Protocol-suffix.
TL;DR: As a user of Graph, you don't care that it's a Protocol. You just care that about its methods:
def f(g: Graph):
    g.nodes() ...

f(nx.DiGraph())


Replication

This PR implement two new modes for replication.
Mode 1: ack client after committing to the master and write the update to the tcp connection to at least one of the slaves.
Mode 2: ack client after committing to the master and at least one of the slaves.
Besides the new unittests, I also manually tested it on the test cluster.

kick build


docker error when running npm run -d cdn in resources team

Do others see this?

I saw this again with latest bosco

Suspect it's here:  https://github.com/tes/bosco/blob/master/src/RunWrappers/DockerUtils.js#L80
I'd need to check with @geophree why we remove the containers here vs just find the existing one - may be a legacy - e.g. where we wanted to always ensure the container had latest configuration.


How to make a puzzle with individual piece sizes and get it solved

I want to create a puzzle for a flag.  This flag has three stripes, all of different widths and I want to have pieces without handles.  Else it would be way to easy to solve.
I use a custom inset:
const customNoneInset = {
          isSlot: () => false,
          isTab: () => false,
          isNone: () => true,
          match: () => true,
          toString: () => 'Empty',
          complement: () => customNoneInset,
          serialize: () => 'E',
        };

and try to sketch pieces like:
this.pp.sketchPiece({
  structure: {
    up: headbreaker.None,
    right: customNoneInset,
    down: headbreaker.None,
    left: customNoneInset,
  },
  metadata: {
    id: 'b',
    targetPosition: { x: 100, y: 0 },
  },
  size: headbreaker.diameter({ x: 200, y: pieceSize.y }),
});

(x is the individual piece width, all pieces shall be ofpieceSize.y height)
This somewhat works, stripes / pieces can be connected, but I don't know which validator to use to have it successfully solved.
Can you help with some example code for this use case?

Hi! I know this may not be best answer, but I'd recommend you to check this headbreaker-based product, which offers some additional ideas about how to implement custom validators: https://github.com/mumuki/mumuki-puzzle-runner/blob/master/lib/public/js/muzzle.js
In particular this piece of code may be of interest to you, since it validates connections manually:
https://github.com/mumuki/mumuki-puzzle-runner/blob/2554b088c068ae7d0b75dd0dda0867c704b63a80/lib/public/js/muzzle.js#L473-L479


pass firefox browsercontext.spec.js tests

closes #92

@Meir017 I didn't know I was able to push to your branch 🤕 sorry about that. But well. some progress in here.

@kblok thanks for the help on this, it's ready for review :)


[Web] the slider freezes after going back and forth

Using svg in thumbImage

Please try to illustrate your issue with this snack

https://snack.expo.dev/@nakshatrasinghh/slider1
Here is my snack

Can you describe what exactly is the problem?
What is the expected behavior, and what is the current behavior?

Do you notice how the slider stops after continuously touching it?
https://user-images.githubusercontent.com/53419293/212381612-c4e4f723-292c-4fea-817f-e3ad0dbdc3d9.mov

This behaviour is not happening when the image is not being passed

When I check your snack, I don't see the issue you describe...
slider-bug.webm

Yes, this issue is not happening on expo, but it happens on react native web view

Also, if I run it on my device (expo) after scanning code, this issue still happens

Snack uses react-native-web, so it's the same stack. My guess is that your code is trying to control the value of the slider while it is changing. So the slider receive both inputs and has to make a choice between the value that changes when the user moves, and the value that you provide as prop.
Anyway, I can't help more as long as you don't reproduce the bug on expo. The rest is probably related to your implementation that I have no access to.

Also, if I run it on my device (expo) after scanning code, this issue still happens

So it's not on the web? On what OS is it then?

Understood, thanks for the help my brother, really means a lot. Cheers and happy coding!

Also, if I run it on my device (expo) after scanning code, this issue still happens

So it's not on the web? On what OS is it then?

iOS web

Snack uses react-native-web, so it's the same stack. My guess is that your code is trying to control the value of the slider while it is changing. So the slider receive both inputs and has to make a choice between the value that changes when the user moves, and the value that you provide as prop.
Anyway, I can't help more as long as you don't reproduce the bug on expo. The rest is probably related to your implementation that I have no access to.

heyy brother, thanks for this, just solved the issue, i was asynchronously changing the value of the text and the slider prop value together, now I made a synchronous call and it works absolutely fine


Nuxt could check if localhost is free

What problem does this feature solve?
If you run nuxt in dev mode and on the localhost is already running another nuxt instance, than you get very strange error. Maybe it will be nice to have cleaner error. Nice to have ;)
What does the proposed changes look like?
Human readable error

This feature request is available on Nuxt community (#c8207)

What strange error are u getting?

I mean I see there listen EADDRINUSE <IP_ADDRESS>:3000, but still took me a time to get the point. :) Especially as I was adding some new packages, so my first thoughts were that problem is somewhere there. ;) Also the link to yarn documentation is misleading...
vents.js:183
      throw er; // Unhandled 'error' event
      ^

Error: listen EADDRINUSE <IP_ADDRESS>:3000
    at Object._errnoException (util.js:1022:11)
    at _exceptionWithHostPort (util.js:1044:20)
    at Server.setupListenHandle [as _listen2] (net.js:1367:14)
    at listenInCluster (net.js:1408:12)
    at GetAddrInfoReqWrap.doListen [as callback] (net.js:1517:7)
    at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:97:10)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.


The deleted application setting which is being edited/renamed reappears after refreshing

Repro Steps:

Right click one application setting and select 'Edit.../Rename...'.
Make sure the edit/rename box is open, delete this application setting.
After deleting successfully, press 'Enter'.
Refresh 'Application Settings' node and check the result.

Expect:
The deleted application setting doesn't reappear.
Actual:
The deleted application setting reappears. Please get the details from "\trinlab2\BAQAFiles\CloudToolsTest\v-dantch\Video\actual.mp4"

Closing this as wont-fix. I don't think many users will do this and I think it's debatable what the expected behavior is. On one hand, it's weird that the setting exists after you just deleted it, but edit and create are very similar behaviors when it comes to app settings.

Ok, got it. And thanks for your update.


Question about developments about new version 1.5 and old version 1.4.3

Hy all,
I have some question that i'd like to know, i'm using w2ui 1.4.3 in a big data project with a lot of management of data, so i have w2ui grid all custom both for ajax response null, ok, ko, error, for example many columns tables has the render function to insert a class in the div td because i need with $(classTD).each(function(){this.text}) to read the data and make controls, all expanded grid, all this to say that w2ui is used a lot and a lot customized in my project.
If i read well the 1.5 version will not have the compatibility with the 1.4.3 version, but sincerely i can't change all the file in the project, we speack about 100 javascript file, so i'd like to know both if will be a migrate file for example and if this will not, for sure all the documentation of w2ui 1.4.3 will be remain online?
Thanks in advantage, and boys w2ui grid is the best object that i never seen, all can be done and managed with w2grid...Well done.
Andrea

this is what i worry about
.. the 1.5 w2ui form send different format data to the server not like the old one (1.4)

I think and hope that Vitmalina will think to this problem, because otherwise all people that today are using 1.4.3 version in a big project in production-work they can't use the new version, i tested the 1.5 version and calling the DB with grid and subgrid seems work the only problem i notified was a css problem of expansion grid, but there are a lot of other not compatibility and this is a problem imho.
Maybe a solution can be renamed the object for example w2grid15 so they can live together and the user can use or the old one or the new one, the first solution that i can think but for sure Vitmalina know better how to do.Othervise i must use the 1.4.3 version for always because the javascript is in the header and the header is in all project so or i do a new folder with a new header or i must use the 1.4.3, but i feel good with the 1.4.3 version, hope that the documentation will remain online.

@vitmalina hello vitmalina any update about "the 1.5 w2ui form send different format data to the server not like the old one (1.4)"
thank you

The problem is that the future w2ui 1.5 will receive for example in data expanded grid both father that children in json in an unic call, instead now you can do a call when click the "+" of the expanded row.
This is a first problem, i work in a big data management and i can't call the DB to receive all data in an unic call, because it's a really problem, for example i have a project where the first call receive about 100-200 records and for every records if i expand the row i have 2-3 thousend sub-records i can't download ALL the records in an unic call, i notified also that some browser like as IE11 for example are not so reactive to scroll all serach all the data, the secondo problem is that all my grids are customized in refresh and onLoad and also this will not compatibile, btw i have 40 grid in all the project.Now IMHO i think the the compatibility from an old version and a new version is a MUST, when i did fractal formule the first thing that people said to me was just keep the compatibility from an old formula and new update otherwise the fractal is broken and the user loose it.
Now i will adapt me but for sue if 1.5 is not compatibile with 1.4.3 i will use 1.4.3...But allow me to say again that a project like w2ui MUST keep compatibility between versions.
Good day
Andrea

I've started my project with 1.4.3 but migrated to 1.5 shortly after I started, so I know a bit about the differences.
For the fun of it, I just downgraded my w2ui sources to 1.4.3 and had very minimal effort to get everything working again.
With 1.5:

With 1.4:

These are the changes I had to make to make my 1.5 stuff work with 1.4.3:

w2layout dows not support onContent so I had to use setTimeout() after loading the content to delay the function calls that were in onContent

The commands for get/delete/save have changed, so I had to adapt my server function to accept the "alias" names:
  if(cmd in ('get', 'get-record', 'get-records')):
      result = self.w2ui_postdata_handler_get(params)
  elif(cmd in ('delete', 'delete-record', 'delete-records')):
      result = self.w2ui_postdata_handler_delete(params)
  elif(cmd in ('save', 'save-record', 'save-records')):
      result = self.w2ui_postdata_handler_save(params)

fields of type list with an url attribute expect the server result to provide items while 1.5 expect records (but still accepts items for backwards compatibility

the form's header CSS was no longer compatible with my additional header buttons, so I removed them to not invest too much time in this

as you can see in the screenshots, there are still a few differences, e.g. the scrollbar in the menu or the form's field all below each other (because 1.4 does not support column layout for auto-forms) or the grid header and buttons not having the correct color (because CSS has changed a bit).

there are no w2utils.formatters in 1.4, that's why the pictures in my grid no longer render - instead the picture's base64 data is displayed.

All in all I must say that it took my less than an hour to fix the issues I encountered from downgrading from 1.5 to 1.4.3, so I guess upgrading from 1.4 to 1.5 can't be such an issue either.
By the way, I'm also using sub-grids and I request their content when they get shown/expanded. I'm not planing on using the new tree-like grids, simply because I need to get data from different tables and the tree-grids don't have their own columns for sub-data.

Hy Mike,
I did a quick experiment using w2ui 1.5 and i notified that is changed also some class used in the grid, yes i can help to try to write a sort of migration, but for the grid.I explain better, i use a lot of grid because i do managment of data from the web downloading data from DB2 so in the server i do all the controls for every row if necessary because if in the row is present for example a particular code i must do a function otherwise another function and so on, this is in general what i do, so when server(PHP) answers to client w2ui in w2ui i able or disable buttons for example...Another function that i use is the control of every row in jquery and to do this i use usally a class in the row, $('.className').each(function(){$(this).text() }) if text is ITALIA i do some control otherwise other controls,  so in the w2ui i must use the render function to add a class(to remain the old controls in javascript, the project is big), because the old project code was done all in server-side, so from php was created with a class template the html that creates the header table and inside the foreach loop the rows and out the loop was created the template close table, all this was in php with a template class(file_get_contents, and passing variables to html from php in array('myVariable' => $myVariable)) and take in html with {myVariable}, when i introduced w2ui for sure i managed the same controls via server but returning a json and after manage data from the client.
Now you can image that in the refresh function and rendering rows i able diasable button allow checkbox check or not etc...etc....All the onLoad or onError is customized, it's a big work of analisis because there are a lot of data and management, if the problem is only rename some class or changed the recid name it's ok but if the problem is all the logic inside it's difficult....I can try to reinstall the 1.5 version and look about differences and try a solution global that allow me to migrate from a version to other, but for sure i don't know if my solution it's ok for other people, i find a solution for my code i can't know all the changed done from 1.4 to 1.5, also because i haven't time to study it, we must know that also if a class name changed we broke the compatibility.
We will see what happen....
Bye

@mpf82 Thanks for your post. Really useful.
This is the issue that I'm encountering with 1.5 ..

.json records with colour via string ( ....,"style": "color:red",... ) stopped working, no colours .. it works
when I switch back to 1.4.3  ( ps: same happens if object is used in lieu of string, same happens=no colours, whatsoever, also in this case migrating back to 1.43 fixes it without any code change )

Not sure if related, but I noticed that 1.5x's grid does load a .json that do -not- contain
the struct header records ( i.e.: {records:[ ......... ) as opposed to only  [........] ... I wonder if this
is related to the colour issue #1 above.

Server response.. I will try the alias solution mpf82 kindly placed earlier in this thread before raising any further flags...

I've been using w2ui for some time, and I also wish to congratulate the author @vitmalina and all of you; it is truly a great library. I apologise if this has been addressed somewhere else, I did
went through the issues but could not find any -recent- issues on this.
Hopefully someone will shed some light on the colour issue, it's really a problem for my implementation ( we use colour codes to display server statuses ......... ). Please let me know if a ticket should be opened or not.
thanks and cordially,
Sergio

Hi Sergio,
about your first issue: w2ui related record attributes must be moved to record.w2ui
From the current w2grid.js:

move rec.summary, rec.style, rec.editable -> into rec.w2ui.summary, rec.w2ui.style, rec.w2ui.editable

So if your record previously looked like:
{ recid: 5, first_name: "Steve", style: "color: red" }

then in 1.5 you need to use:
{ recid: 5, first_name: "Steve", w2ui: { style: "color: red" } }

Cheers, Mike

Hi Mike,
Many thanks on your reply. It worked, colours are back.
I was going to ask just that, about classes and 1.5 documentation...  will report back on #3.
again, thank you and cheers.
s

Hy All,
I'm testing the versions because in some moment is better use the 1.5 and other moments 1.4.3 :) for example the 1.5 versions when i resize column insert the scroolbar under the last row and this is ok, instead the 1.4.3 no but the scrollbar is over the last row.So i have implemented some code of the 1.5 inside the 1.4 and now it's ok the scrolbar is under the last row, but there is a problem in the 1.5 version, i have many grid inside folders loading on document ready and seems that 1.5 version doesn't show well the contents of the rows, but if i resize columns the vision is ok.I think this problem is born from the resizeRecords and in paticular here:
        // find width of frozen columns
       var fwidth = 1;
        if (this.show.lineNumbers)  fwidth += lineNumberWidth;
        if (this.show.selectColumn) fwidth += 26;
        if (this.show.expandColumn) fwidth += 26;
        for (var i = 0; i < this.columns.length; i++) {
            if (this.columns[i].hidden) continue;
            if (this.columns[i].frozen) fwidth += parseInt(this.columns[i].sizeCalculated);
        }
        fcolumns.css('width', fwidth);
        frecords.css('width', fwidth);
        fsummary.css('width', fwidth);
        scroll1.css('width', fwidth);
        columns.css('left', fwidth);
        records.css('left', fwidth);
        summary.css('left', fwidth);

Hi spizzi,
can you create a fiddle to reproduce your problem?
Can you also try to set this grid property and see if it makes a difference for you:

grid.disableCVS = true; // disable virtual column scrolling

(you should probably set this property in your grid constructor)

Hy Mike,
Now i'm at work, i only tried to switch the old code from 1.4.3 to 1.5 and there are differents problematics in jquery folders plugin, but i didn't do changes to the code, just keeping the old code both for server that for client but inserting the 1.5 javascript file so can be this the problem for sue i must adapt and re visiting all the old code to the new version.
I'll try to look better and give you some example on my site default page....
Bye Andrea

Hi again Mike, nothing, i decided to remain the 1.4.3 version(for the moment) at work instead on my personal site i will use the future 1.5 so to see better the changes and how to fix it, because at work the project is too big and there are a lot of functionality, i notified that for example doing a resize grid at document ready and inserting differents grids into folders(we use jquery folders plugin) it's ok with the 1.4.3  instead the 1.5 doesn't do the resize and i don't know why, the logic is simple at document ready if w2grid['nameGrid'] is !== undefined resize it, it works in 1.4.3 but not in 1.5, i create template from php inside the folders and inside the template there is the grid, sincerely at work there are a lot of changes to do because now that i use 1.4.3 in production is all stable all is working fine, i will think in the future but for the moment i remain with 1.4.3.
Later
Andrea

@mpf82
Hi Mike,
In regard to the other problem; of which I've been stuck for 2 days now, the following is happening:

Post requests get cancelled
Toolbar on; event is Delete; using url 'remove: router.php'
Tried all browsers
Tried all php.inis / apache ( ignore_user_abort = on ; everywhere )
But going from 1.5x to 1.4.3 fixes it; ...

Have you or anyone experienced this ? The only reference I could find within the repository was issue #623 but it seems to be a different context.
Any help would be much appreciated, this is literally driving me crazy.
many thanks,
cordially,
Sergio

Hi Sergio,
not sure what's happening on your server side, but my suggestion is to check the request headers and request payload in your browser's network tab. Compare them (1.4 vs 1.5), maybe you'll find the difference.
Also make sure to set w2utils.settings.dataType to whatever fits your needs (w2ui 1.4 default is HTTP, w2ui 1.5 default is HTTPJSON).
I'm using Python and CherryPy server, so I don't have specific recommendations for PHP and Apache.
Best regards,
Mike

you should remove the 1.4.3 library especially on home page download button as soon as possible..
because its like you just make a trap, they downloading something that will be deprecated (not usable with the new one)

I have posted 1.5.rc1 to the website and removed links to 1.4. Documentation is also available for both of them on the website (for 1.5 whatever current state is, it is somewhat incomplete yet).

Thanks Mike ( @mpf82 ) ! ... I hadn't replied to you, sorry. The cause was a null value, just prior
of the event triggering ( onDelete ), it triggers 2 requests - and the faulty one indeed has
an unique header - thanks for the suggestion.
Thanks for your kind attention.
best
s


seperation from reader

I separate nsqio from reader, as the publish or other commands need to write synchronously. Do you have any good ideas?
@mreiferson @ploxiln

The writer should not really be "synchronous", the user should provide a callback which will be called with notification of success ("OK") or some error. The writer can send multiple PUB before receiving notification of the status of the first, they are "pipelined" (the library just has to keep track of the order of commands to know which the response is for).
I recommend trying to open smaller pull requests, with one step of change at a time (that is still able to build and run).

Thanks, I've made a test to run and build in every commit, please take a look again. By the way, I'm sure the nsqio separation from reader is needed. How do you think?

Hi @stackerzzq, we just landed #26 — I realize this hasn't been documented anywhere, but it makes it a little easier to make contributions that follow the style of C we prefer by using make fmt.
If you wouldn't mind rebasing this, and dropping the typedef changes, I'd be happy to review the resulting diff.
Thanks!


[BUG] ACode Pro no longer responds to arrow keys on a physical keyboard

As title, cursor no longer moves when pressing an arrow key.

Also not working on virtual keyboards. Even the arrow buttons in the toolbar are also not working.

As title, cursor no longer moves when pressing an arrow key.

Deleting and reinstalling the app worked for me

As title, cursor no longer moves when pressing an arrow key.

Deleting and reinstalling the app worked for me

Clearing app data also worked, but restoring a backup file from an older version reproduces the bug. Seems that it's a backward compatibility issue.


Warning in console

I found warning in my console.
Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in the componentWillUnmount method.
I make PR to fix it #23

Thank you for your PR. I released a new version


Profile inheritance

Profiles should be able to inherit settings, extensions, and keybinds from other profiles. Specifically, it would be useful to inherit from the default profile.
If this feature already exists, I have not found it.
Problem
Imagine I have multiple profiles. These could be a home and work profile. They could be language-specific profiles like C++, Python, and Javascript. Whatever the case is, I have multiple profiles.
I may choose to install VSCodeVim. Obviously, this extension would be useful to have across all my profiles. Furthermore, the settings related to this extension are likely to be the same across all my profiles.
As it currently stands, I must install VSCodeVim in each profile separately and copy any settings to each profile. If, in the future, I decide to change my VSCodeVim settings, I must copy those changes to each profile. This is a major pain. The problem only gets worse with each extension I wish to share across profiles.
VSCode attempts to solve this issue by allowing you to create a profile by using another as a base. This is insufficient because any changes made to the original profile are not reflected in the new profile.
Solution
Introduce a per-profile setting to inherit from another:
"inherit-profile": "default"
This solution comes with drawbacks. The inheritance graph may contain cycles and may be many levels deep, leading to unexpected behavior on the user's end. This can be solved by only allowing inheritance one level deep. I do not see the need for a profile to inherit from a profile that inherits from another profile.
Another option is to only allow a new profile to inherit from the default profile. This results in a loss in flexibility, but is a simpler solution.

Adding my .02¢, the main reason I would like profile inheritance is so that my keyboard shortcuts, global state, and the main settings (i.e. not extension specific) would carry over to each profile.
I want these to be consistent across all profiles and don't want to have to update 1 change across X number of profiles.

See #156144

/duplicate

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!


Multisig Wallet Ethereum

Hi Team,
I am exploring BitGo for multisig wallet having compatibility with Peatio. As per my understanding it is used only for Bitcoin. So I am searching for a multisig wallet for Ethereum that can connect with Peatio. Please let me know if any opensource wallet is available to achieve the same.
Regards
Abhishek

Bittrex sourcecode: https://github.com/stannak7/bittrex-source-code

Hi Abhishek, Unlike Bitcoin, ETH does not have any native addressing mechanism for multisig. You can write a simple smart contract to achieve this. Please see this link for reference.


Upgrade version 5.4.4

Upgrade version to 5.4.4. Prepare for release

Codecov Report

Merging #266 into 5.4 will increase coverage by 0.34%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                5.4     #266      +/-   ##
============================================
+ Coverage     71.14%   71.49%   +0.34%
+ Complexity      961      960       -1
============================================
  Files           341      341
  Lines         13681    14241     +560
  Branches       2211     2289      +78
============================================
+ Hits           9734    10182     +448
- Misses         2766     2863      +97
- Partials       1181     1196      +15

Impacted Files
Coverage Δ
Complexity Δ

.../main/java/com/alipay/sofa/rpc/common/Version.java
100% <ø> (ø)
0 <0> (ø)
:arrow_down:

...java/com/alipay/sofa/rpc/context/AsyncRuntime.java
53.84% <0%> (-9.8%)
0% <0%> (ø)

...alipay/sofa/rpc/api/future/SofaResponseFuture.java
55.17% <0%> (-6.37%)
5% <0%> (ø)

...pay/sofa/rpc/transport/http/SslContextBuilder.java
18.75% <0%> (-6.25%)
2% <0%> (ø)

...fa/rpc/bootstrap/dubbo/DubboProviderBootstrap.java
60.44% <0%> (-6.22%)
0% <0%> (ø)

...ay/sofa/rpc/protocol/telnet/HelpTelnetHandler.java
82.35% <0%> (-5.15%)
0% <0%> (ø)

...va/com/alipay/sofa/rpc/client/FailoverCluster.java
74.28% <0%> (-4.29%)
0% <0%> (ø)

...va/com/alipay/sofa/rpc/client/FailFastCluster.java
75% <0%> (-2.78%)
0% <0%> (ø)

...n/java/com/alipay/sofa/rpc/ext/ExtensionClass.java
77.77% <0%> (-2.23%)
0% <0%> (ø)

.../sofa/rpc/client/aft/impl/TimeWindowRegulator.java
81.91% <0%> (-2.18%)
7% <0%> (ø)

... and 123 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d201534...1f582d5. Read the comment docs.


Add support for plugins written in other BEAM languages

Per this support discussion, it would be nice to have a straight-forward and dev-friendly mechanism for:

allowing plugins to be written in LFE, Elixir, Joxa, etc., and
allowing plugins to have dependencies that are written in other BEAM languages

Have you tried writing a plugin that depends on a plugin to compile the language with the proper hooks?

Write a lfe-compiling plugin that's in Erlang
Write a plugin in LFE, which depends on the LFE-compiling plugin (as a plugin, not a dep)
Have the LFE-written plugin add a pre-compile hook in its config calling the LFE-compiling plugin
???
Success

It's untested stuff, but it sounds like it could work. I'm also not sure how much better the flow could ever be.

I have not tried that yet. I will do so, and report on my progress here ...

I had to go back and add functionality to the LFE rebar3 compile plugin, as the original LFE rebar compile code was only looking in src (and whatever was provided in erl_opts). This update process brought up some interesting dev use cases:

I had to essentially copy about 80% of the code from rebar_erlc_compiler.erl, changing as necessary for .lfe files. It would be nice if a) more of the code was exported, and if so, b) parameterized for easier overriding of file extensions, etc. (I know there are a host of things I just glossed over with that "etc." ...)

Having rebar use a different compiler function is fairly easy, since a function is passed as a parameter to rebar_base_compiler:run/4 ... but, as noted above, it would be nice if doterl_compile didn't have to be copied/pasted (and was updated to be more generic, of course).

I have yet to discover the similar mechanism (if one exists) for compiling plugins. I thought that plugins would just use the compile provider, but it's looking like .erl-specific code is getting executed when I try to compile an LFE plugin (via a provider hook). I am going to have to troubleshoot the errors [1] more tonight (it could very well be a bad copy/paste).

All that being said, this is definitely good progress :-)

[1]: Here are the errors I'm seeing:
===> Compiling lfe-version
===> erl_opts [debug_info,debug_info]
===> Files to compile first: []
===> error undef [{'lfe-version',module_info,[exports],[]},
                         {rebar_plugins,validate_plugin,1,
                             [{file,
                                  "/home/travis/build/rebar/rebar3/_build/default/lib/rebar/src/rebar_plugins.erl"},
                              {line,103}]},
                         {rebar_plugins,handle_plugin,3,
                             [{file,
                                  "/home/travis/build/rebar/rebar3/_build/default/lib/rebar/src/rebar_plugins.erl"},
                              {line,73}]},
                         {rebar_plugins,'-handle_plugins/3-fun-0-',3,
                             [{file,
                                  "/home/travis/build/rebar/rebar3/_build/default/lib/rebar/src/rebar_plugins.erl"},
                              {line,42}]},
                         {lists,foldl,3,[{file,"lists.erl"},{line,1261}]},
                         {rebar_plugins,handle_plugins,3,
                             [{file,
                                  "/home/travis/build/rebar/rebar3/_build/default/lib/rebar/src/rebar_plugins.erl"},
                              {line,41}]},
                         {rebar3,run_aux,2,
                             [{file,
                                  "/home/travis/build/rebar/rebar3/_build/default/lib/rebar/src/rebar3.erl"},
                              {line,103}]},
                         {rebar3,main,1,
                             [{file,
                                  "/home/travis/build/rebar/rebar3/_build/default/lib/rebar/src/rebar3.erl"},
                              {line,47}]}]
===> Plugin {'lfe-version',".*",
                       {git,"https://github.com/lfex/rebar3-lfe-version.git",
                           {branch,"master"}}} not available. It will not be used.
===> Verifying dependencies...
{"init terminating in do_boot",killed}

Crash dump was written to: erl_crash.dump
init terminating in do_boot (killed)

That is just saying that lfe-version doesn't export any functions and it needs to export at least init/1

Yeah, that's the first thing I checked, thinking maybe I'd not been paying attention when I created the module ... but it does in export the three functions expected by the provider behaviour :-/
Maybe there's a typo somewhere? I'll check it out tonight.

Yeah, I think there's an problem with the code copied and adapted from rebar_erlc_compiler.erl ... the lfe-version plugin's not even compiling.

I'm adding @rvirding on this, since I may have just run into a limitation in LFE.
Below are the notes for a project that has a rebar.configwith the following contents:
{plugins, [
  {'lfe-compile', ".*",
    {git, "https://github.com/lfex/rebar3-lfe-compile.git", {branch, "master"}}},
  {'lfe-version', ".*",
    {git, "https://github.com/lfex/rebar3-lfe-version.git", {branch, "master"}}}
]}.

Attempting to compile (e.g., with $ DEBUG=1 rebar3 compile, as shown above) fails.
I think tried the following:
$ rebar3 shell
Erlang/OTP 17 ...
1> lfe_shell:server().
LFE Shell V6.4 (abort with ^G)
> (slurp "_build/default/plugins/rebar3-lfe-version/src/lfe-version.lfe")
_build/default/plugins/rebar3-lfe-version/src/lfe-version.lfe:1: error expanding (do 1)
error
> (c "_build/default/plugins/rebar3-lfe-version/src/lfe-version.lfe")
_build/default/plugins/rebar3-lfe-version/src/lfe-version.lfe:1: error expanding (do 1)
error

When these didn't work, I suspected failed shadowing of do/1:
> (do "asd")
1: error expanding (do "asd")
error

Having more or less confirmed that, I checked to see what would happen if (export all) was used instead (without causing LFE to think that the do macro was being called in the export form), and it worked from the REPL:
> (slurp "_build/default/plugins/rebar3-lfe-version/src/lfe-version.lfe")
#(ok lfe-version)
> (c "_build/default/plugins/rebar3-lfe-version/src/lfe-version.lfe")
#(module lfe-version)
> (lfe-version:module_info 'exports)
(#(module_info 0)
 #(module_info 1)
 #(provider-name 0)
 #(short-desc 0)
 #(deps 0)
 #(init 1)
 #(do 1)
 #(format_error 1)
 #(info 1))

So, it looks like LFE can't compile a module that exports a do/1 function.
However, all of this still didn't help; with the change of export to (export all) and a fresh compile, the error is still happening:
$ DEBUG=1 rebar3 compile
...
===> error undef [{'lfe-version',module_info,[exports],[]},
                         {rebar_plugins,validate_plugin,1,
                             [{file,
                                  "/home/travis/build/rebar/rebar3/_build/default/lib/rebar/src/rebar_plugins.erl"},
                              {line,103}]},
                         {rebar_plugins,handle_plugin,3,
                             [{file,
                                  "/home/travis/build/rebar/rebar3/_build/default/lib/rebar/src/rebar_plugins.erl"},
                              {line,73}]},
                         {rebar_plugins,'-handle_plugins/3-fun-0-',3,
                             [{file,
                                  "/home/travis/build/rebar/rebar3/_build/default/lib/rebar/src/rebar_plugins.erl"},
                              {line,42}]},
                         {lists,foldl,3,[{file,"lists.erl"},{line,1261}]},
                         {rebar_plugins,handle_plugins,3,
                             [{file,
                                  "/home/travis/build/rebar/rebar3/_build/default/lib/rebar/src/rebar_plugins.erl"},
                              {line,41}]},
                         {rebar3,run_aux,2,
                             [{file,
                                  "/home/travis/build/rebar/rebar3/_build/default/lib/rebar/src/rebar3.erl"},
                              {line,103}]},
                         {rebar3,main,1,
                             [{file,
                                  "/home/travis/build/rebar/rebar3/_build/default/lib/rebar/src/rebar3.erl"},
                              {line,47}]}]
===> Plugin {'lfe-version',".*",
                       {git,"https://github.com/lfex/rebar3-lfe-version.git",
                           {branch,"master"}}} not available. It will not be used.
===> Verifying dependencies...

More later ...

First, it looks like your provider hooks are wrong, it should be:
{provider_hooks, [{pre, [{compile, {lfe, compile}}]}]}.

That doesn't fix it entirely for me, it seems the compile provider isn't in scope when it tries to run it.

I think I've cornered the final issue but I probably won't get it fixed until tonight or tomorrow.

I think I "fixed" it actually, but it seems to go into an infinite loop. It also seems to do that if I just run rebar3 lfe compile. Might this be an issue in the plugin and not rebar3 causing this and my fix could be correct if it goes into this infinite loop? :)

Ah, I found the issue. the lfe-compile provider is attempting to run the compile providers hooks. You shouldn't do that :)

Should help https://github.com/rebar/rebar3/pull/530

I can tell you the problem with 'do'. It is a macro so when (do 1) occurs
inside (export ...) it is expanded as a macro and the do body is too small
so the expansion fails and generates an error. You should not call a
function 'do'.
Robert
On 20 June 2015 at 20:27, Tristan Sloughter<EMAIL_ADDRESS>wrote:

Should help #530 https://github.com/rebar/rebar3/pull/530
—
Reply to this email directly or view it on GitHub
https://github.com/rebar/rebar3/issues/525#issuecomment-113800738.

 Hopefully something can be figured out for LFE because it is too late to be changing providers to use a function other than do/1...

Wow, @tsloughter  -- this is amazing! I only just logged in now (was down and out with a migraine all yesterday).  Thanks so much for looking into all the issues here!!
I think that the (export all) workaround will suffice -- changing do in either of LFE or rebar3 sounds like too much. It will just have to be one of those idiosyncrasies we'll have to document for writing rebar3 plugins in LFE.

There are three things I'm seeing now ... and I'm stumped on how to get further insight:

an error with no stacktrace when compiling the rebar3-lfe-compile plugin
"lfe" being both found and not found in the rebar3-lfe-version plugin
a project that depends upon these two plugins saying that the rebar3-lfe-version plugin is not available

More info on these below.
Details for the first issue
In the rebar3-lfe-compile plugin's working directory:
$ DEBUG=1 rebar3 compile
===> Consult config file "rebar.config"
===> Consult config file "rebar.lock"
===> Consult config file "/Users/oubiwann/lab/lfe/rebar3-lfe-compile/rebar.config"
===> Consult config file "rebar.lock"
===> Consult config file "/Users/oubiwann/lab/lfe/rebar3-lfe-compile/rebar.config"
===> Uncaught error in rebar_core. Run with DEBUG=1 to see stacktrace
===> Uncaught error: {error,function_clause}

No insight on the context of the rebar_core  function call, nor the full stacktrace (just the error message).
Details for the second issue
In the rebar3-lfe-version plugin's working directory, the command is listed in the help output:
$ rebar3 help
Rebar is a tool for working with Erlang projects.

Usage: rebar [-h] [-V] [<task>]

  -h, --help     Print this help.
  -V, --version  Show version information.
  <task>         Task to run.

Several tasks are available:

app_discovery
deps                 List dependencies
install_deps         Install dependencies
lock                 Locks dependencies.
test_deps            Install dependencies needed only for testing.

lfe <task>:
  compile        The LFE rebar3 compiler plugin

Run 'rebar help <TASK>' for details.

but says that "lfe" can't be found when executing compile:
$ rebar3 lfe compile
===> Command lfe not found

Details for the third issue
I've got an lfetool branch with the following rebar.config file:
{plugins, [
  {'lfe-compile', ".*",
    {git, "https://github.com/lfex/rebar3-lfe-compile.git", {branch, "master"}}},
  {'lfe-version', ".*",
    {git, "https://github.com/lfex/rebar3-lfe-version.git", {branch, "master"}}}
]}.

When running any command, it warns about multiple .app.src files (there is only one in each pluging/dependency) and it says that lfe-version is not available and won't be used (even though it's in the _plugins directory):
$ rebar3 help
===> More than one .app.src file in /Users/oubiwann/lab/lfe/lfetool/_plugins/lfe-*/src
===> More than one .app.src file in /Users/oubiwann/lab/lfe/lfetool/_plugins/lfe-*/src
===> More than one .app.src file in /Users/oubiwann/lab/lfe/lfetool/_plugins/lfe-*/src
===> Plugin {'lfe-version',".*",
                       {git,"https://github.com/lfex/rebar3-lfe-version.git",
                           {branch,"master"}}} not available. It will not be used.

Rebar is a tool for working with Erlang projects.
...
lfe <task>:
  compile        The LFE rebar3 compiler plugin

Run 'rebar help <TASK>' for details.

Ah, interesting -- I had been using a rebar3 which I compiled. When I downloaded the latest from s3, rebar things are no longer broken:

Issue 1 (from the previous comment) is gone now.
Issue 2 is also gone, being replaced by an issue with plenty of info in the stacktrace for me to debug.
Issue 3 is also gone.

So, uh, is lfe now properly supported and able to work with in-lfe plugins?

Not sure. Still debugging the rebar3-lfe-compile plugin ... I'm having a hard time sorting out which parts of rebar3 compile to re-use for LFE plugins.  Simply having rebar3-lfe-compile handle ./src is obviously not enough. Having it run the compile providers hooks is too much.  I need to figure out how to tell it to compile all {lfe, compile} provider hooks. Still digging through source ...

Took a break and I'm back :-)
I think I have a better handle on this now. Basically, the fact that I had set up the provider hooks config incorrectly early on, started me down an incorrect conceptual path. I've adjusted now, and if the configuration is correct, then I don't need to worry about plugin sources, etc. getting found -- rebar3 will do that for me, if everything is set up correctly.
Once I get this tuned and working, I'll update with success and close.
Or pester with more questions...

Looks like most of it's sorted: plugins, dependent plugins, etc., are being compiled. There's an error in my LFE compile code, however: dependencies are not being compiled. Overall, looking good so far.

One solution would be to remove the do macro. I don't think anyone is using
it and it is not that useful with out a setq. :-)
Robert
On 22 June 2015 at 00:01, Duncan McGreggor<EMAIL_ADDRESS>wrote:

Took a break and I'm back :-)
I think I have a better handle on this now. Basically, the fact that I had
set up the provider hooks config incorrectly early on, started me down an
incorrect conceptual path. I've adjusted now, and if the configuration is
correct, then I don't need to worry about plugin sources, etc. getting
found -- rebar3 will do that for me, if everything is set up correctly.
Once I get this tuned and working, I'll update with success and close.
Or pester with more questions...
—
Reply to this email directly or view it on GitHub
https://github.com/rebar/rebar3/issues/525#issuecomment-113963637.

I'll have to check the monad library and see if @correl is using it ...

@oubiwann I'm not using it for anything

@oubiwann can we consider this supported? I'm guessing documentation would be needed to finalize it, or did you have any other major blocker?

Yeah, I think we can consider this supported for now. I think the only
blockers I'm running into are implementation details in the compiler plugin
(e.g., not downloading and building dependencies of dependencies). I need
checkout some native Erlang plugins (with deps of deps) and confirm what I
believe to be the standard behaviour. If any issues arise in those
investigations, I can always open up a specific ticket.
On Thu, Jul 2, 2015 at 10:13 AM, Fred Hebert<EMAIL_ADDRESS>wrote:

@oubiwann https://github.com/oubiwann can we consider this supported?
I'm guessing documentation would be needed to finalize it, or did you have
any other major blocker?
—
Reply to this email directly or view it on GitHub
https://github.com/rebar/rebar3/issues/525#issuecomment-118064276.


[Mayastor]: [I just get one online msn node and the others still offline.. please find the list of errors Received NotifyRegistrationStatus call: &RegistrationStatus{PluginRegistered:true,Error:,}&& (node:1) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag --unhandled-rejections=strict (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1) && Failed to start mayastornode watcher: Error: connect EHOSTUNREACH <IP_ADDRESS>:443]

Are you reporting an issue with existing content?
Please describe the error or omission, or your suggestion for improvement.
Please include a link the affected page(s)
Are you proposing new content, or a change to the existing documentation layout or structure?
Please describe your proposal.

Moving reporter's description of the issue to comments, rather than the issue title.  Moving to "Bug" label, not "Documentation".
Quote:
I just get one online msn node and the others still offline.. please find the list of errors Received NotifyRegistrationStatus call: &RegistrationStatus{PluginRegistered:true,Error:,}&& (node:1) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag --unhandled-rejections=strict (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1) && Failed to start mayastornode watcher: Error: connect EHOSTUNREACH <IP_ADDRESS>:443

User's original report content (from #openebs @ kubernetes.slack.com)
Seeking your help in #mayastor openebs solution
https://mayastor.gitbook.io/introduction/quickstart/deploy-mayastor
I have followed all steps and stuck in $ kubectl get msn -n mayastor
I am just getting one online msn node and others still offline
Kindly find logs associated from loki
Received NotifyRegistrationStatus call: &RegistrationStatus{PluginRegistered:true,Error:,} --> on all mayastor-csi pods while all pods are up & running with no issue
I have tested other csi-drivers either newer or older with no luck :disappointed:
NAME            STATE     AGE
kube-worker00   offline   24m
kube-worker01   offline   24m
kube-worker02   online    24m

Providing @jkryl 's response from the #openebs slack channel, as it is possibly relevant to both reported cases
Quote:
I suppose that you are testing 0.6 version of images (latest tag). Could you try to restart moac pod and see if it makes any difference? If it does not, could you make sure that you don’t have any firewall rules in your cluster that would prohibit gRPC traffic between MOAC and storage nodes (port 10124)?


Added internal cross-references in Fast DDS-Docs [8788]

This pull request:

Improves cross-referencing so that it does not overload the documentation sections.
Adds links to the API reference where required.
Adds missing documentation to the API reference.
Fixes minor writing errors to achieve better coherence of the documentation as a whole.

Build status:

Build status:

Build status:

Build status:

Build status:

Build status:

Build status:

Build status:

Build status:


Reach Broccoli 1 & 2 compatibility

Switch deprecated broccoli-writer to broccoli-plugin
(https://github.com/broccolijs/broccoli/blob/master/docs/broccoli-1-0-plugin-api.md)
Upgrade broccoli-flatiron

I saw the deprecation warning using ember-cli-addon-docs. I did a fork to check that these changes were working, it seems ok. Is this something you want to get test covered @ef4?

Thanks, this is great, sorry for the delay.


'GPTNeoXForCausalLM' object has no attribute 'generation_config'

I try to use LoRA to tuning this model, while when I using this model, I got the error "AttributeError: 'GPTNeoXForCausalLM' object has no attribute 'generation_config'"
How could I fix that in a simple way, thanks.
peft_model_id = "/root/dolly/alpaca-lora-dolly-2.0"
config = PeftConfig.from_pretrained(peft_model_id)
model = AutoModelForCausalLM.from_pretrained(config.base_model_name_or_path, return_dict=True, load_in_8bit=True, device_map='auto')
tokenizer = AutoTokenizer.from_pretrained(config.base_model_name_or_path)

# Load the Lora model
model = PeftModel.from_pretrained(model, peft_model_id)
batch = tokenizer(Hello: ", return_tensors='pt')
with torch.cuda.amp.autocast():
  output_tokens = model.generate(**batch, max_new_tokens=50)
print('\n\n', tokenizer.decode(output_tokens[0], skip_special_tokens=True))

I think you're asking about something not covered by this repo.
Generally, check that you are using the latest transformers and that your model dir correctly has all pieces of the model.
But it's possible this error is 'correct' for your model.


Redirect to login with responseOverrides doesn't come back to the requested page

Describe the bug
Redirect to the login page, forgets the previous path, and always returns to the home page.
All the pages in our app should be served to authenticated users. So instead of making a login button we automatically redirect all the users to the login page.
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Use the staticwebapp.config.json below
Navigate to /page1 page
It will redirect to the authentication page, authenticate
Instead of returning to /page1 the app will return to / (index page)

{
  "navigationFallback": {
    "rewrite": "/index.html"
  },
  "routes": [
    {
      "route": "/*",
      "allowedRoles": [
        "authenticated"
      ]
    }
  ],
  "auth": {
    "rolesSource": "/api/GetRoles",
    "identityProviders": {
      "azureActiveDirectory": {
        "userDetailsClaim": "http://schemas.xmlsoap.org/ws/2005/05/identity/claims/name",
        "registration": {
          "openIdIssuer": "https://login.microsoftonline.com/XXXXXXXXXXXXXXXXXXXXXXXX",
          "clientIdSettingName": "AAD_CLIENT_ID",
          "clientSecretSettingName": "AAD_CLIENT_SECRET"
        },
        "login": {
          "loginParameters": [
            "resource=https://graph.microsoft.com"
          ]
        }
      }
    }
  },
  "responseOverrides": {
    "401": {
      "redirect": "/.auth/login/aad",
      "statusCode": 302
    }
  }
}

Expected behavior
Even with auth redirection with responseOverrides it should return to the originally requested page and not the index page.
Screenshots
If applicable, add screenshots to help explain your problem.
Device info (if applicable):

OS: Windows 11
Browser Chrome, Edge
Version All

Additional context
Add any other context about the problem here.

You will achieve the desired behavior if you update the redirect to include a post login redirect uri to the .referrer. You can update the "redirect" to the following: "/.auth/login/aad?post_login_redirect_uri=.referrer". This .referrer keyword ends the login flow back at the endpoint that started the login flow in the first place.

Thank you @mkarmark ! I didn't find it in the docs for some reason...

This should be on the docs.
I discovered it a couple of weeks ago. And there are two questions on this in the last days. I discovered by chance in one of the discussions and it was from end of 2021. There is much functionality that could wait to be documented. But this is a "game-killer" if not implemented in many company environments. People do not click twice on the link.

Totally agree, we are working on a doc update. Thanks for the feedback!


Adding a Regression label type

Adds a Regression label type that can store regression values and their associated confidences and other custom attributes.
An evaluate_regressions() method is also added that provides support for computing common regression evaluation metrics as well as generating scatterplots that can be used to analyze predicted regressions w.r.t. ground values, optionally stratified by an additional categorical or numeric variable.
Example usage
import random
import numpy as np

import fiftyone as fo
import fiftyone.zoo as foz
from fiftyone import ViewField as F

dataset = foz.load_zoo_dataset("quickstart").select_fields().clone()

# Populate some fake regression + weather data
for idx, sample in enumerate(dataset, 1):
    ytrue = random.random() * idx
    ypred = ytrue + np.random.randn() * np.sqrt(ytrue)
    confidence = random.random()
    sample["ground_truth"] = fo.Regression(value=ytrue)
    sample["predictions"] = fo.Regression(value=ypred, confidence=confidence)
    sample["weather"] = random.choice(["sunny", "cloudy", "rainy"])
    sample.save()

print(dataset)

results = dataset.evaluate_regressions("predictions", gt_field="ground_truth", eval_key="eval")

# Print some standard regression evaluation metrics
results.print_metrics()

# Plot a scatterplot of the results colored by `weather` and scaled by `confidence`
plot = results.plot_results(labels="weather", sizes="predictions.confidence")
plot.show()

session = fo.launch_app(dataset)

# Show the samples with the smallest regression error
session.view = dataset.sort_by("eval")

# Show the samples with the largest regression error
session.view = dataset.sort_by("eval", reverse=True)

mean squared error        59.69
root mean squared error   7.73
mean absolute error       5.48
median absolute error     3.57
r2 score                  0.97
explained variance score  0.97
max error                 31.77
support                   200

Regression scatterplots can also be attached to the App to enable interactive exploration of regression results:

@benjaminpkane thanks for the regression App support!


[Feature Request] 2D Physics Implementation

A proper 2D physics engine support, either from scratch or by integrating an existing engine...

[ ] Integration of JBox2D

Now that the engine has been ported to JavaFX, this will thought of at a later date


[Revise subclass] [add synonym] MONDO:0020708 "Brachial Amyotrophic Diplegia"

For Brachial Amyotrophic Diplegia consider adding the synonyms "flail arm syndrome" "FAS" and "man-in-barrel syndrome"
Also consider making this a subclass of ALS
https://link.springer.com/article/10.1007/s00415-015-7993-z

@kshefchek based on this paper, I'm not sure if ALS is an appropriate parent:
https://www.ncbi.nlm.nih.gov/pmc/articles/PMC4461255/
"The relationship between FAS and ALS is still unclear. Some researchers argue this syndrome is a variant of ALS, while others believe that FAS is an independent entity[3–5]."

I added the synonyms


Resources used during training in paper?

Hi, I was wondering which GPUs were used during training, the approximate total training time and number of GPUS. Thanks!

I was using an A6000 48GB GPU for training. If I remember correctly, it takes about 15 minutes to train on the Pubmed node classification task with a single GPU, and about 5-6 hours on the Arxiv node classification task HO template (ND takes a bit longer since the prompt will be longer). If you train with multiple GPUs using DeepSpeed, the training time can be reduced proportionally to the number of GPUs with minimal overhead. (e.g. 1.5h with 4 GPUS on arxiv node classification)


Hash examples

Please add an example for using a custom hash.  And an example for specializing a class for the hash used by unordered_dense.
Thank you for your work on this!

I see what i can do 👍

Updated docs, will create a new release 1.3.2 with minor fix.