AniFlix and Animeflix.live is dead

Source name
AniFlix and Animeflix.live
Source language
English
Source link
animeflix.live animeflix.mobi animeflix.gg
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a title with source name.
[X] I have updated all installed extensions.
[X] I have opened WebView and checked that the source website is down.
[X] I will fill out all of the requested information in this form.

Looks like AniFlix shut down completly, migrate to other extensions

I know, I just want dead extensions to be clear of the extensions list.


Implement longest match mode in std.regex

hsteoh reported this on 2014-08-07T18:15:14Z
Transfered from https://issues.dlang.org/show_bug.cgi?id=13268
CC List

dmitry.olsh (@DmitryOlshansky)

Description
Currently, the | operator works on a first-match basis, such that a pattern like (ab)|(abcd) will never match the second alternative because (ab) is always matched first.

It would be nice if there was a way to do greedy matching between alternations, such that an alternation a|b|c|... will always prefer the longest match. Probably this will have performance implications, so perhaps a "greedy alternation" operator distinct from | should be used. Maybe something like |* might be a possible syntax:  (ab)|*(abcd) will capture (abcd) if the input contains "abcd", but fallback to (ab) only if the input doesn't contain "abcd" but does contain "ab".

Precedents for greedy alternation include lex / flex, which take a list of input regexen and always performs longest-match on them. In essence, given a list of patterns P1, P2, ..., the equivalent of P1 |* P2 |* ... is performed.

dmitry.olsh (@DmitryOlshansky) commented on 2016-04-06T10:12:12Z
This is possible to achieve but rather on a whole-regex level then on each alternation level.


Remove default proxysql service from package

Hey @daveallen
Sorry for the delay, I created the solution for the underlying default service problem.
Addressing: https://github.com/ernestas-poskus/chef-proxysql/issues/28

Thanks Ernestas!!


Fix JPetOptionsTools functions returning pointer to local variable

Fix issue with JPetOptionsTools functions returning pointers to local std::string variables.

retest this please

retest this please

retest this please


Investigate API Route Versioning in the Spring Way

With RMB-based modules, each RAML definition of API routes had a version number.  This same version number was echoed into the module's ModuleDescriptor.json.
In Spring Way modules, that same version field is still in the descriptor, however, there are no corresponding RAML files that would define what this version is.
Furthermore, this API version seems to be completely separate from semver and the normal FOLIO module versioning system.  Very few notes regarding this versioning seem to exist (and all that do apply in RMB only).
(sorry Noah, I accidentally closed this - placed back into to do.)

For now, I am just assuming it is arbitrary and incrementing in the rewrite.  However, this may not be correct and, as such, I am leaving this issue open until investigation is completed.

There is currently no correlation.  Some issues such as FOLIO-1767 were raised but never went anywhere.

module versions and interface versions are somewhat independent, to allow multiple modules to supply different implementations of the same interface. Also, one module can provide multiple interfaces. There’s a discussion to be had about whether interfaces should be first-order entities in the Okapi data model, but for now they are defined as part of a module’s module descriptor, possibly not ideal. The versioning in the RAML files and the module descriptor refers to the interface version, and is not full SemVer (it is just major/minor, no patch or pre-release).

As a result of my conversation with other devs, they would like to move to a system where Okapi directly consumes the OpenAPI spec so this information would not be duplicated.  Raised in OKAPI-1042.  Additionally, a similar RMB-based approach was closed as wontdo: OKAPI-339 since OpenAPI is the new preference.

For now, I am just assuming it is arbitrary and incrementing in the rewrite. However, this may not be correct and, as such, I am leaving this issue open until an investigation is completed.

I have now changed this to version 4.1 instead of a new major version 5.0.  This may be revised once #4 is completed and we determine the new API schema, however, keeping it as 4.1 makes deployment easier (since mod-circulation requires version 3.x or 4.x).


fix: navbar item validation done correctly

Motivation
The validation system currently doesn't accept type: "dropdown". Let's redesign the validation schema.
Have you read the Contributing Guidelines on pull requests?
Yes
Test plan
I added two more test cases.
Related PRs
Followup of #5072.

@slorber Ready for review. Joi is really a pain 😅

That seems nice thanks 👍
Not 100% sure it's perfect but doesn't matter, we'll fix the bugs in the upcoming bugfixes releases


[Suggestion] Maybe add the comparison and benchmark with other css frameworks ?

Did't find a resonable benchmark but make a little comparison with emotion.js:
source code:
import { css } from '@iandx/easy-css'
import { css as emotionCss } from "@emotion/css"

function simplePerformanceTest(tag: string, easyFunc: (i: number) => any, emotionFunc: (i: number) => any) {
  console.log(`[----${tag}----]`)
  for (const round of [10, 100, 1000, 10000]) {
    console.log(`----${round}----`)
    console.time(`easy-css`)
    for (let i = 0; i < round; i++) {
      easyFunc(i)
    }
    console.timeEnd(`easy-css`)
    console.time(`emotion`)
    for (let i = 0; i < round; i++) {
      emotionFunc(i)
    }
    console.timeEnd(`emotion`)
  }
  console.log("")
}

// pre-rendered for easy-css
simplePerformanceTest(
  "reuse",
  () => {
    css`
      color: red;
      font-weight: bold;
      display: flex;
    `
  },
  () => {
    emotionCss`
      color: red;
      font-weight: bold;
      display: flex;
    `
  }
)

simplePerformanceTest(
  "new",
  i => {
    css`
      color: red;
      font-weight: bold;
      display: flex;
      font-size: ${i}px;
    `
  },
  i => {
    emotionCss`
      color: red;
      font-weight: bold;
      display: flex;
      font-size: ${i}px;
    `
  }
)

Result:

So in the "reuse" part, because that the css string is static, so with easy-css's pre-parsing tech, it costs almost nothing whatever the number of the round is. And in the "new" part, for that everytime the index "i" is new, there's no way to statically analyze it in build time, however as you can see the "dynamic" runtime cost is way lower than emotion. (notice that emotion stucks when the round is 10,000)

Maybe a quick demo? Like [this one](https://codesandbox.io/s/css-in-js-comparison-forked-tqlg1?file=/src/App.js

https://github.com/mui/material-ui/issues/22342

Demo here
Only implement runtime easy-css, because static pre-parsed one is the same with pure css therotically.
Here's the result
First render:

Render multiple times:


Parallel query iterator filtering

What problem does this solve or what need does it fill?
I'm in the process of implementing an "update smear" to reduce CPU usage by applying updates to a portion of elements in a query, rather than doing it all in a single frame. I'm building my project with this system in place in the beginning, so I can be sure to program around its quirks. This works well, however I'm forced to run the element updates one after another, rather than in parallel chunks, because the internal structures that (for example) .par_for_each() uses don't appear to be exposed. It would also not be possible to efficiently .skip(x) elements when I don't care about it them, since .next() does a bunch of work to get data from the world that may not be necessary to fetch.
That said, the smear without chunked parallel processing is already much more efficient than updating the hundreds of thousands of objects I've thrown at it, so it's not a dire issue that needs solving.
What solution would you like?
A way to apply a .filter() or .skip() to .par_for_each(). Alternatively, an equivalent .chunk()-ing function that can be used in parallel iterators without causing lifetime issues.
What alternative(s) have you considered?
I've been attempting to work about the existing iterator, but have been having lifetime issues when implementing a parallel version that I don't believe can be resolved without additional functionality within the engine. I have also looked into Rayon, but would much prefer not to drag in that dependency when Bevy has already implemented a stripped down "game-engine optimized" version of it.
I've also considered doing the work in an detached thread, but collecting the query data as often as I need that would not be CPU or memory efficient, and would cause synchronization issues when bringing the data back into the world state, especially as the project grows.

Note that bevy_tasks already parallel iterator filter / map / flatten / etc functionality. The old version of Bevy ECS implemented that parallel iterator interface, but we dropped support for it in Bevy ECS V2 (in the interest of time / getting Bevy 0.5 out the door). We can probably re-add support by implementing the bevy_tasks ParallelIterator trait for some new Query::par_iter(&self) -> ChunkedIterator. We should use the current par_for_each and the previous par_iter implementations as a reference when implementing this.

I was wondering why I couldn't find it implemented anywhere in the repo, I was unaware it was removed. That's good to know.

related te #2088

This is a very important and useful feature for handling large amounts of entities without implementing this filtering with manual synchronization around it.


Doc.save returns true, but document isn't saved when geo indexed array is [nil, nil]

I ran into an issue where Mongoid claims a successful save, but the document is not saved.
Consider this scenario in Mongoid / Rails:
class Place
  include Mongoid::Document

  field :loc, type: Array # [longitude, latitude]
  index [[ :loc, Mongo::GEO2D ]]
end

place = Place.create!(:loc => [nil,nil], :name => "Some Place") #  => #<Place _id: 4f3ad5f756fc8a6d04000003, loc: [nil, nil]  ...>

Notice how there is no error creating a new place.  This works the same when using Place.new(...) and place.save, where place.save will return true, as if it was saved successfully.
And in the mongo terminal error messages are
> db.places.save({name: "Some Place", loc: [null,null] })
location object expected, location array not in correct format

> db.places.save({name: "Some Place", loc: [null,50] })
location object expected, location array not in correct format

> db.places.save({name: "Some Place", loc: [50,null] })
geo values have to be numbers: { 0: 50.0, 1: null }

Is this a bug?

You need to use safe mode in order for the db errors to come back:
place = Place.safely.create!(:loc => [nil,nil], :name => "Some Place")


Nomad autoscaling

In order to actually make better use of our new clusters we should take advantage of autoscaling the AWS autoscaling groups. Right now they are hardcoded using the terraform core workspaces.
My proposed approach is to run an instance of the nomad autoscaling daemon on the monitoring server since it will have access to metrics across the cluster already. I haven't had time to look into this yet, so I'm not able to determine what kind of configuration this will require, but the core instances will most likely need additional IAM privileges for controlling the amount of instances in the groups. Those are still in the per-cluster iam.nix file. (which we should probably pull into bitte proper).

[ ] Update IAM permissions for core group with whatever is needed for autscaling
[ ] Move iam.nix to bitte repo and import from clusters.
[ ] Ensure the new ZFS-based ASG AMIs are available in all regions (they can only be copied in the development aws org).
[ ] Update the package for nomad-autoscaler in this repo.
[x] Write a NixOS module for it (probably heavily based on https://github.com/hashicorp/nomad-autoscaler/blob/master/demo/remote/aws_autoscaler.nomad and maybe running a consul-template for the config).
[ ] Determine what metrics other than CPU/Memory we need to decide on the required number of instances.
[ ] Bonus points for boosting the startup performance of the ASG AMIs by unifying the caching and utilizing seaweedfs.

See https://github.com/hashicorp/nomad-autoscaler

I think most of this has been satisfied
cc @nrdxp

Looks like a lot of these old issue are pretty stale :sweat_smile:
I checked what should already be done. Moving the instance to monitoring may actually be a good idea since it can pull the data locally instead of over the network, but I'm not sure if that would actually change anything substantially. I dunno if anyone has gotten around to fixing the AMI since the recent ZFS breaks though.
Right now we are only using CPU and memory to determine scaling actions so there is still potential to improve this aspect. And I would probably add another point:

[ ] setup for dynamically scaling Nomad task groups


Missing LICENSE

I see you have no LICENSE file for this project.  The default is copyright.
I would suggest releasing the code under the GPL-3.0-or-later or AGPL-3.0-or-later license so that others are encouraged to contribute changes back to your project.

This repo is just a placeholder for some configuration files, I didn't really feel the need to add a license...
But if the default is copyright, I added a license file.
I'm more in favor of MIT licenses.


Bug: Region Playlist Edit button shows column view toggles

v2.12.13
Clicking the Edit Project button in Region Playlist window shows the visible columns context. Also right-clicking nearly anywhere in the window shows this context.
Expected - only seeing this context when right-clicking column header

Ah, oops. Looks like this bug has been in the Windows pre-release builds since May. Fixing!


Game phases second half automated

This PR is aimed to test the procedure of starting the second half of a game in an automated way. It relates to issue #6.

Isn't it missing the test_scenario.json file?

I will shortly upload it and the README

Just one point is that I have used system time among other simulated clock types. Do you think it is problematic? as you mentioned in the test_supervisor documentation that it is easier to understand if one clock type is used

This test is one of the cases where it is not possible to stick to one type of clock, so this is ok. It's just that it should be avoided practice when it's possible.


Modification

hi there,
brilliant so far, would it be possible to update this so that each of the areas have a priority between like 1-10
for a prison server so spawn is noneditable but mines are
Much appreciated thanks
Andrew.

Hi, I wish you a good morning and holidays, i would appreciate it if you could explain the first priority in the fields and the last priority in the worlds in a little more detail.

So like if you protect an area within an area.

Thank you for your opinion, I think it complicates it for users, but I'll think about it, have a nice day...
Dear TrFolwe
Discord: trfolwe


add tests for graphql aliases

After working a bit more with aliases today I found a couple more problems, I tried to check the code, but had a hard time figuring out what happened.
Instead I created a couple tests that should check most alias cases. During this progress the relationship test also gave me this error
13:23:38.112 [warning] `b6c6c824-999f-4f50-96bb-e2be5a7401f3`: AshGraphql.Error not implemented for error:

** (Ash.Error.Framework) Framework Error

* Assumption failed: Invalid return from request resolver for "fetch AshGraphql.Test.Post.read" data:
Got:
:error

This should not be possible, please report a detailed bug at:

https://github.com/ash-project/ash/issues/new?assignees=&labels=bug%2C+needs+review&template=bug_report.md&title=

  (ash 2.9.26) lib/ash/engine/request.ex:1224: Ash.Engine.Request.do_try_resolve_local/4
  (ash 2.9.26) lib/ash/engine/request.ex:282: Ash.Engine.Request.do_next/1
  (ash 2.9.26) lib/ash/engine/request.ex:211: Ash.Engine.Request.next/1
  (ash 2.9.26) lib/ash/engine/engine.ex:712: Ash.Engine.advance_request/2
  (ash 2.9.26) lib/ash/engine/engine.ex:637: Ash.Engine.fully_advance_request/2
  (ash 2.9.26) lib/ash/engine/engine.ex:578: Ash.Engine.do_run_iteration/2
  (elixir 1.14.3) lib/enum.ex:2468: Enum."-reduce/3-lists^foldl/2-0-"/3
  (ash 2.9.26) lib/ash/engine/engine.ex:307: Ash.Engine.run_to_completion/1
  (ash 2.9.26) lib/ash/engine/engine.ex:252: Ash.Engine.do_run/2
  (ash 2.9.26) lib/ash/engine/engine.ex:148: Ash.Engine.run/2
  (ash 2.9.26) lib/ash/actions/read.ex:173: Ash.Actions.Read.do_run/3
  (ash 2.9.26) lib/ash/actions/read.ex:96: Ash.Actions.Read.run/3
  (ash 2.9.26) lib/ash/api/api.ex:1837: Ash.Api.read_one/3
  (ash_graphql 0.25.8) test/support/api.ex:1: AshGraphql.Test.Api.read_one/2
  (ash_graphql 0.25.8) lib/graphql/resolver.ex:82: AshGraphql.Graphql.Resolver.resolve/2
  (absinthe 1.7.1) lib/absinthe/phase/document/execution/resolution.ex:232: Absinthe.Phase.Document.Execution.Resolution.reduce_resolution/1
  (absinthe 1.7.1) lib/absinthe/phase/document/execution/resolution.ex:187: Absinthe.Phase.Document.Execution.Resolution.do_resolve_field/3
  (absinthe 1.7.1) lib/absinthe/phase/document/execution/resolution.ex:172: Absinthe.Phase.Document.Execution.Resolution.do_resolve_fields/6
    (ash 2.9.26) lib/ash/error/error.ex:461: Ash.Error.choose_error/2
    (ash 2.9.26) lib/ash/error/error.ex:218: Ash.Error.to_error_class/2
    (ash 2.9.26) lib/ash/actions/read.ex:184: Ash.Actions.Read.do_run/3
    (ash 2.9.26) lib/ash/actions/read.ex:96: Ash.Actions.Read.run/3
    (ash 2.9.26) lib/ash/api/api.ex:1837: Ash.Api.read_one/3
    (ash_graphql 0.25.8) test/support/api.ex:1: AshGraphql.Test.Api.read_one/2
    (ash_graphql 0.25.8) lib/graphql/resolver.ex:82: AshGraphql.Graphql.Resolver.resolve/2
    (absinthe 1.7.1) lib/absinthe/phase/document/execution/resolution.ex:232: Absinthe.Phase.Document.Execution.Resolution.reduce_resolution/1
    (absinthe 1.7.1) lib/absinthe/phase/document/execution/resolution.ex:187: Absinthe.Phase.Document.Execution.Resolution.do_resolve_field/3
    (absinthe 1.7.1) lib/absinthe/phase/document/execution/resolution.ex:172: Absinthe.Phase.Document.Execution.Resolution.do_resolve_fields/6
    (absinthe 1.7.1) lib/absinthe/phase/document/execution/resolution.ex:143: Absinthe.Phase.Document.Execution.Resolution.resolve_fields/4
    (absinthe 1.7.1) lib/absinthe/phase/document/execution/resolution.ex:88: Absinthe.Phase.Document.Execution.Resolution.walk_result/5
    (absinthe 1.7.1) lib/absinthe/phase/document/execution/resolution.ex:67: Absinthe.Phase.Document.Execution.Resolution.perform_resolution/3
    (absinthe 1.7.1) lib/absinthe/phase/document/execution/resolution.ex:24: Absinthe.Phase.Document.Execution.Resolution.resolve_current/3
    (absinthe 1.7.1) lib/absinthe/pipeline.ex:405: Absinthe.Pipeline.run_phase/3
    (absinthe 1.7.1) lib/absinthe.ex:116: Absinthe.run/3
    test/alias_test.exs:236: AliasTest."test relationship alias works correctly"/1
    (ex_unit 1.14.3) lib/ex_unit/runner.ex:512: ExUnit.Runner.exec_test/1

🚀 Thank you for your contribution! 🚀


Lint giving errors

I am not certain how to set this indent validation or even turn it off.
#1
I get this error "Incorrect indentation. Expected -4, got 0" with this perfectly legal code to IBM compiler and RDi. (I don't know why the END_DS lines are there but its allowed).
//  Data structures /Copy Qcpysrc,Dspgminf4   End-ds; /Copy Qcpysrc,Dateutl.Ds   End-ds;
But this begins a massive lint error reporting throughout the whole of the source.
If I remove the End-DS lines then it clears up.
#2
I get this error "Incorrect indentation. Expected 4, got 0", in compile-time arrays (yes they are technically still allowed in **FREE code).
I use compile-time arrays as a poor here-docs.  It allows me to have a seamless area to store things like SQL statements so they are not broken up into chunks in mainline calcs.
#3
I get this error "Incorrect indentation. Expected 4, got 0" for continued constant text.  If you use continuation markers (+/-) in mainline source to append multiple lines of SQL statements (that cannot fit on one line of RPGLE source), the lint parser wants me to indent but that indent will become part of the text string, if you use the plus (+) character.

It might be worth considering having something in the source (a comment or something) that allows me to have the lint parser stop considering that section of code.   It certainly would need to be something that can be safe for compile.

@m-tyler
1
Oh... so your copybooks actually look something like this?
 We are linting based on current source. The linter does not expand the source.
2
Please share a source example where **CTDATA is used and I can get this handle for you.
3
Again, need you to share an example so I can recreate the issue.

@m-tyler
1
Oh... so your copybooks actually look something like this?
Dcl-Ds ABCD;
  FieldA Char(1);
  FieldB Char(1);

Then your base looks like this:
/copy myds.ds
End-Ds;

We are linting based on the current source. The linter does not expand the source.
edit: after some thought, I likely won't work on changing this for a while. It will be something I work on when I have more time to do that!
2
Please share a source example where **CTDATA is used and I can get this handle for you.
3
Again, need you to share an example so I can recreate the issue.

TEMP.RPGLE.txt

These copy book DS' are fixed D-spec code.  I dont know why the programmer added them.
// Data structures  /Copy Qcpysrc,Dspgminf4  End-ds;  /Copy Qcpysrc,Dateutl.Ds  End-ds;
I have actually removed them going forward but they are still valid syntax.  Where it would work is if you wanted to add an additional field to the DS and the DS is a fixed format version.  Full free forms of DS' don't allow this.

You can add append fields definitions to the DS after /COPY statement.  Some /COPY books are used in too many places to support a small addition that most wont use.

@m-tyler Are you able to share an example where the +/- extenders are causing you issues?
For the 'end-ds' issue, the only way to get around it quickly is by adding silly hacks like allowing end-ds after an include, add a directive to skip a line or re-write some parts of the code. I am opting for the the middle option: #57
/copy mycopy.ds
// @rpglint-skip
end-ds;

I have tried to recreate it with no luck. I will wait to hear back from you @m-tyler.

I have published 0.5.6, which has the new @rpglint-skip comment directive and the **CTDATA fix.

I tried a new temp rpg member and I dont get the error either.  the code that does cause the errors is quite large.   However, I move all my SQL code to the left column and work out from there.   My statement is quite large and wont work in a view so I have to load it into source.
TEMP.RPGLE.txt
If this source does not work, then I will email you the original problem source.

@m-tyler I loaded that member into a member also and cannot create the issue either.

Wrap that code into a subroutine or sub-procedure.     Looking at the overall program levels I see that the parser is giving a correct report. I suspect that the new @rpglint-skip will solve this last issue.    I don't use leading spaces in situations like this because I want to use as much of the source line as possible to reduce the number of source lines used.

@m-tyler Great! So what is the status of this issue?

So what you have done so far is great, however for my code I only need to block out sections but it seems that the new comment directive stops the lint process from that point forward (perfectly okay as it stands).
So I guess the resolution for my issue is to have lint ignore continuation lines or have the new directive start and stop lint parsing.
I would mark this as a medium priority issue.

@m-tyler Note that // @rpglint-skip only skips the next line. There is not a way to skip 'blocks' of code.
May I suggest to you to create a new issue with the specific details too? This issue was created with three issues, which isn't normally good for me tracking these things. I am going to close this one for now.


Add {G,S}etSheetPrOptions() to allow to set FitToPage for printing

TL;DR The major feature added is to allow to set the FitToPage option that tells Excel to scale the sheet to fit the page.
The implementation is similar to #149 in which I added {S,G}etSheetViewOptions().
Details below.

New functions SetSheetPrOptions and GetSheetPrOptions to allow to set options on
<sheetPr> and <pageSetUpPr>.
The following options are implemented:

CodeName (string)
EnableFormatConditionsCalculation (bool)
Published (bool)
FitToPage (bool)
AutoPageBreaks (bool)

Codecov Report

Merging #154 into master will decrease coverage by 1.1%.
The diff coverage is 36.2%.

@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
- Coverage   98.47%   97.37%   -1.11%
==========================================
  Files          15       16       +1
  Lines        3219     3277      +58
==========================================
+ Hits         3170     3191      +21
- Misses         30       65      +35
- Partials       19       21       +2

Impacted Files
Coverage Δ

sheetpr.go
36.2% <36.2%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90998bf...a7ce217. Read the comment docs.

I'm working on adding the missing code coverage...

Thanks for merging! :fireworks:


Application Key for WriteOnly access is not working with File Upload

System.AggregateException
HResult=0x80131500
Message=Er zijn één of meer fouten opgetreden.
Source=mscorlib
StackTrace:
at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
at System.Threading.Tasks.Task.Wait()
at LaundryStatistiek.archiver.Archiveer.Go() in D:\SOFT\Insal\HANDSFREE\BetaalAutomaat\BEZETMELDER_soft\LaundryStatistiek\archiver\Archiveer.cs:line 46
at LaundryStatistiek.Program.Main(String[] args) in D:\SOFT\Insal\HANDSFREE\BetaalAutomaat\BEZETMELDER_soft\LaundryStatistiek\Program.cs:line 33
With a 1 bucket - WriteOnly application key, i have these exceptions
Changing the key with an all-access key (write/read,all buckets) everything works.
Inner Exception 1:
AuthorizationException: There was an error during authorization. See inner exception for details.
Inner Exception 2:
Exception: If you are using an Application key and not a Master key, make sure that you are supplying the Key ID and Key Value for that Application Key. Do not mix your Account ID with your Application Key.

I used AccountId but had to use the KeyId.
This is working now.
Maybe change the name for the AccountId parameter in B2Client( ) to AccountOrKeyId

@lucwuyts I think around a year ago B2 moved towards a key-oriented system. The idea would be to use a created key instead of the root account key. It might explain why this library might not align perfectly to the API B2 uses right now. Just thought I'd mention it in case you run into other issues.


Feature not existing for JS SDK

|                   | Given a communication user, get the list of chat threads the user is part of                                           | ✔   | ✔  | ✔    | ✔  |  ✔    | ✔   |
For JS SDK I can't find the way to get list of chat threads for given communication user.
If there is any document which I miss, please reply for this bug

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 68fb8223-453a-b19f-0f2f-c409753ec734
Version Independent ID: f6126346-7f3a-ad46-71c0-ac707b81f6b7
Content: Chat concepts in Azure Communication Services - An Azure Communication Services concept document
Content Source: articles/communication-services/concepts/chat/concepts.md
Service: azure-communication-services
Sub-service: chat
GitHub Login: @tophpalmer
Microsoft Alias: chpalm

@iamrajshah
Thanks for your feedback! We will investigate and update as appropriate.

#reassign: kperla97

The documentation for list threads is here:

#please-close


[DPP-49] Log exceptions

Issue:
Currently exceptions are managed but we have no way of working back why the exception was risen.
Expected outcome:
By adding logging somewhere in the codebase it will be possible of keeping track of what went wrong.

Logging from within the Haxl monad requires a monad transformer which is not an easy implementation. Currently we're satisfied with having the fetching errors being converted in user-facing messages in the report email.


Counting and storing pulses from detector

City of Gothenburg has a suggested improvment for the RSMP due to be able to count vehicles that pass inductive loops in existing infrastructure.
Proposal for requirements specification.
Detector pulse = Pulse from inductive loops when vehicle passes.

Control devices in road traffic signal systems must have a configurable function for detector pulse for all detectors.
Detector pulse in control devices in road traffic signal systems must be able to be connected to any detector connected.
Detector pulse in control device for road traffic signal system must be with storage of number of pulses with a resolution of 5 minutes.
Detector pulse in control device for road traffic signal system must be with storage of number of pulses with at least one week storage.
Detector pulse in control device for road traffic signal system must be with reading of values via:

a.	RS232 interface (terminal program/modem)
b.	web interface
c.	API

Control devices in road traffic signal systems must be able to read out the detector pulse via display, web interface and communication interface.
Control devices in road traffic signal systems must be able to change or reprogram detector pulse via control panel, RS232C and web interface.

Thank you for the input.
However, I wonder if these requirements fits in the RSMP specification. I think these requirements handles traffic counting in general and does not necessarily only applies to RSMP.
At the Swedish Transport Administration, these types of requirements are defined in the requirement document for traffic signals known as Vägtrafiksignalsystem 3.0 (TRVINFRA-00217). You can read it here.
But perhaps requirement 1 and 2 could possibly be incorporated in the RSMP specification. I'll think about that...

Detector pulse = Pulse from inductive loops when vehicle passes.
1. Control devices in road traffic signal systems must have a configurable function for detector pulse for all detectors.

Very similar to requirement K27608 in TRVINFRA-00217

2. Detector pulse in control devices in road traffic signal systems must be able to be connected to any detector connected.

Very similar to requirement K27609 in TRVINFRA-00217

3. Detector pulse in control device for road traffic signal system must be with storage of number of pulses with a resolution of 5 minutes.
4. Detector pulse in control device for road traffic signal system must be with storage of number of pulses with at least one week storage.

Very similar to requirement K27610 in TRVINFRA-00217. But in RSMP, any resolution can be chosen. Storage of traffic data is not applicable to RSMP since all traffic data is transmitted continuously.

5. Detector pulse in control device for road traffic signal system must be with reading of values via:

* a.	RS232 interface (terminal program/modem)
* b.	web interface
* c.	API

Very similar to requirement K27611 in TRVINFRA-00217


Log target = module

2021-11-30 16:39:33  INFO daemon::logger: Initialized logger
2021-11-30 16:39:33  INFO taker: Running version: 0.1.2-11-g09cfe03

instead of
2021-11-30 14:33:14  INFO Initialized logger
2021-11-30 14:33:14  INFO Running version: 0.1.1-367-gcbc42b6

Makes it way easier to interpret logs because we have context who logged what.

bors r+


Question: Parsing responses

I love the concept behind this project and I am exploring the docs and testing. One question that remains is when I use the example code and the response to 'Who was the California Attorney General?' is a giant block of data. I see the elements and the embedding, but if I wanted to parse this data or use this data, how would I?
Is the assumption that I pass this entire response to an LLM with my original query and then get the response?
Thanks

Hi, the recommended approach is to use the fact value on the edge and also potentially enhance it with temporal information in the (created_at, expired_at, valid_at, invalid_at) fields of the edge.

Thank you for the quick response. That makes sense. Is there a standard method of parsing this data? its one element, seems like defining is a string, splitting on ",", then iterating through the elements is cumbersome. Just want to make sure Im not missing something really obvious. ha.

No standard method for this yet unfortunately, but we may add utilities for it in the future.
It is very user specific how you want to represent the input to your llm call so we wanted to keep the options as open as possible, that's why we return the full edge objects.

Hey! If you use the graphiti.search() method you will get a list of EntityEdges back. You can find the class definition in the edges.py file. Note that it inherits from the Edges base class so it will have those values as well. When looking at the code I noticed we are missing the type hint on the return value so I will add that to make it more clear to people reading the code.
If you use the graphiti_search() method we return a SearchResults object which has searchResults.nodes, searchResults.edges, and searchResults.communities fields. These will return lists of these respective objects, which you can control click into to see the class definitions.
For a quick answer though: edge.fact and edge.name is what you will mostly care about for edges, node.name and node.summary for nodes.

Roger, thank you so much. Would recommend a structured object of some kind, like json.
Great! this I can work with. Thank you!

@maglore9900 As @prasmussen15 mentioned, Graphiti returns objects from those method calls: SearchResults containing:

nodes, a list of EntityNode objects
edges, a list of EntityEdge objects
and communities. a list of CommunityNode objects.

These all subclass the pydantic BaseModel and can be serialized using the model_dump_json  method.

model_dump() is exactly what I'm looking for. Thank you!


Add example showing how to access script variables inside InModuleScope

When the test templates were changed to declare some of the resource variables as $script: scope, this prevented these variables from being accessed from within InModuleScope blocks.
InModuleScope blocks will not be used for public functions (*-TargetResource), but are still used for private functions.
There is an way to redeclare a variable declared outside a InModuleScope block so that it can be used inside the block:
InModuleScope $script:DSCResourceName {
    $script:DSCResourceName = (Get-Variable -Name 'DSCResourceName').Value
    # Do some tests
}

This needs to be added as an example in TestGuidelines.md.
I'll submit a PR.

Unfortunately the above suggestion does not work.
Also, see this discussion:
https://github.com/pester/Pester/issues/342
We might just have to redeclare any variables needed in the InModuleScope for private functions. This is a bit messy though and feels like the wrong thing to do.
Any suggestions from you smarter people?

@PlagueHO Yes, this is a problem.
There are two solutions I see on the table right now:

Don't use the script variables inside InModuleScope. You can re-declare them inside the scope without the script prefix if need be.
Switch the script variables back to globals.

I'm leaning towards 1 because globals get defined everywhere and hence could screw up other tests or the module. Though I can see how 1 isn't as clean code-wise.
@mbreakey3 I know you've been working a lot with #169. What do you think?

For now, I agree with you that 1 is the better of the two options. When possible, InModuleScope should only surround the testing of non-exported functions though, which should help. Once the new version of Pester comes out that's supposed to support nested Describe blocks that will be even better, because we can replace InModuleScope with a Describe block instead

I'll close this one until after the new version of Pester is released that will improve the InModuleScope situation.

I've reopened this issue because @narrieta submitted some new tests to xNetworking in this PR. The tests solved some of the problems that I encountered when removing InModuleScope, so I'll submit a PR to add an example to TestGuidelines.md of what he did.


Universidade Vale do Rio Doce - https://www.univale.br/

Hi!

@warleipereira I have to close this request without merging, because you requested to add a non-existent domain to this repository: Host univale.edu.br not found: 3(NXDOMAIN) Please ensure that you are familiar with this repository rules located at the bottom of this page and submit a new request with the correct information. Thank you for understanding!


Impersonate Account Doesn't Execute Transaction In Context Of Impersonated Account

🐛 Bug Report for zkSync Era In-Memory Node
📝 Description
The impersonate account functionality does not appear to execute a transaction setting msg.sender to the impersonated account.
🤔 Expected Behavior
Transaction passes having executed the transaction setting msg.sender to the impersonated account
😯 Current Behavior
Transaction reverts having executed the transaction with msg.sender set to the account I'm signing the transaction with
🖥 Environment

era_test_node version era_test_node 0.1.0-alpha.1

📎 Log Output
As per the followingloutput, the transaction fails with the call graph having been executed from the initiator account, as opposed to the account that I impersonated.
========================================
  Node is ready at <IP_ADDRESS>:8011
========================================
🕵 Account 0x69f33e02555b0634beef0406f99cc7f632b13891 has been impersonated

Validating 0xf7c0bbd0b55ecd4f1f7ed0b01b62f5685848e00828b852acbfa4f38081647a62
Executing 0xf7c0bbd0b55ecd4f1f7ed0b01b62f5685848e00828b852acbfa4f38081647a62
┌─────────────────────────┐
│   TRANSACTION SUMMARY   │
└─────────────────────────┘
Transaction: FAILED
Initiator: 0xbc989fde9e54cad2ab4392af6df60f04873a033a
Payer: 0xbc989fde9e54cad2ab4392af6df60f04873a033a
Gas - Limit: 2_500_000 | Used: 461_380 | Refunded: 2_038_620

Call(Normal) 0xbc989fde9e54cad2ab4392af6df60f04873a033a                   df9c1589  Revert: caller not whitelist setter or owner  2012850
  Call(Normal) 0x2d621b6453de839cb37acf35c5934811b933cc09                   c32d5564  Revert: caller not whitelist setter or owner  1970073

Thank you for the report @bonedaddy ! Do you have any example script we could have to test this out?
We (in theory) have e2e tests to cover this scenario here : https://github.com/matter-labs/era-test-node/blob/main/e2e-tests/test/hardhat-apis.test.ts#L68
Perhaps with your additional example, we can see where the difference is and troubleshoot further

Closing issue as stale


fix(common/Vector): fixed Vector.operate and operateAbsolute handling 0 incorrectly

This PR fixes the vector operations, such as add resulting in incorrect vectors, when z or w is 0 on the vector we are adding to.
import { Vector4 } from '../../src/common';

const v1 = new Vector4(1, 2, 0, 0);
const v2 = new Vector4(2, 2, 2, 2);
const result = v1.add(v2);
console.log(result.x, result.y, result.z, result.w); // actual result: 3, 4, 0, 0 | expected result: 3, 4, 2, 2

BTW, Your contributing guidelines mention creating PR against development branch, but that does not exist

LGTM, thank you for the fixes.


SR-13976: Improve compiler error message: "partial application of ‘mutating’ method is not allowed"

As mentioned on the Jira ticket, partial application is not a well-known term so I have reworded the error messages with a suggested phrase to help people diagnose the issue easier.
Based on the diagnostics definition file there were 4 different combinations that I saw that used the error, below is the wording changes i made:

partial application of 'mutating' method is not allowed -> calling a 'mutating' method without an argument list is not allowed
partial application of 'super.init' initializer chain is not allowed -> calling a 'super.init' initializer chain without an argument list is not allowed
partial application of 'self.init' initializer delegation is not allowed -> calling a 'self.init' initializer delegation without an argument list is not allowed
partial application of 'super' instance method with metatype base is not allowed -> calling a 'super' instance method with metatype base without an argument list is not allowed

The first commit has the change, second commit has the test updates.

Resolves SR-13976. cc @varungandhi-apple

Thanks for the PR. 🙂
Minor comment: Generally we try to implement the test and change in the same commit (or alternately, add a failing test marked as XFAIL in the first commit, and implement the fix and remove the XFAIL in the second commit). For this particular case, it's not a big deal though, as we can squash the changes at the end.

Thanks for the PR. 🙂
Minor comment: Generally we try to implement the test and change in the same commit (or alternately, add a failing test marked as XFAIL in the first commit, and implement the fix and remove the XFAIL in the second commit). For this particular case, it's not a big deal though, as we can squash the changes at the end.

I can squash the commits when I change from calling -> using

I can squash the commits when I change from calling -> using

This is what I have come up with! What do you folks think before I go further? @varungandhi-apple @LucianoPAlmeida @xedin
 if (auto FD = dyn_cast<FuncDecl>(getDC())) {
    if (FD->getParameters()->size() == 0) {
      emitDiagnosticAt(getLoc(), diag::add_empty_parameter_list_fixit,
                       anchor->getName().getBaseIdentifier())
          .fixItInsertAfter(getLoc(), "()");
      }
  }

Here is some of the test output from Constraints/mutating_members.swift
/Users/aajetunmobi/Documents/swiftproject/swift/test/Constraints/mutating_members.swift:9:37: error: incorrect message found
let x = Foo.boom // expected-error{{partial application of 'mutating' method}}
                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                   cannot reference 'mutating' method as a function value
/Users/aajetunmobi/Documents/swiftproject/swift/test/Constraints/mutating_members.swift:11:36: error: incorrect message found
let z0 = y.boom // expected-error{{partial application of 'mutating' method}}
                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                  cannot reference 'mutating' method as a function value
/Users/aajetunmobi/Documents/swiftproject/swift/test/Constraints/mutating_members.swift:12:42: error: incorrect message found
let z1 = Foo.boom(&y) // expected-error{{partial application of 'mutating' method}}
                                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                        cannot reference 'mutating' method as a function value
/Users/aajetunmobi/Documents/swiftproject/swift/test/Constraints/mutating_members.swift:15:10: error: unexpected note produced: did you mean to call 'boom' with '()'?
 return Foo.boom // expected-error{{partial application of 'mutating' method}}

This is what I have come up with! What do you folks think before I go further? @varungandhi-apple @LucianoPAlmeida @xedin
 if (auto FD = dyn_cast<FuncDecl>(getDC())) {
    if (FD->getParameters()->size() == 0) {
      emitDiagnosticAt(getLoc(), diag::add_empty_parameter_list_fixit,
                       anchor->getName().getBaseIdentifier())
          .fixItInsertAfter(getLoc(), "()");
      }
  }

Here is some of the test output from Constraints/mutating_members.swift
/Users/aajetunmobi/Documents/swiftproject/swift/test/Constraints/mutating_members.swift:9:37: error: incorrect message found
let x = Foo.boom // expected-error{{partial application of 'mutating' method}}
                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                   cannot reference 'mutating' method as a function value
/Users/aajetunmobi/Documents/swiftproject/swift/test/Constraints/mutating_members.swift:11:36: error: incorrect message found
let z0 = y.boom // expected-error{{partial application of 'mutating' method}}
                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                  cannot reference 'mutating' method as a function value
/Users/aajetunmobi/Documents/swiftproject/swift/test/Constraints/mutating_members.swift:12:42: error: incorrect message found
let z1 = Foo.boom(&y) // expected-error{{partial application of 'mutating' method}}
                                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                        cannot reference 'mutating' method as a function value
/Users/aajetunmobi/Documents/swiftproject/swift/test/Constraints/mutating_members.swift:15:10: error: unexpected note produced: did you mean to call 'boom' with '()'?
 return Foo.boom // expected-error{{partial application of 'mutating' method}}

I like it! I'd also suggest to add a note - did you mean to call it with '()' and attach a fix-it to that instead of fix-it alone, it make it more clearer.

I like it! I'd also suggest to add a note - did you mean to call it with '()' and attach a fix-it to that instead of fix-it alone, it make it more clearer.

And one more thing - a better check would be to account for defaultable parameters as well, so if there are 0 parameters or all of the parameters are defaultable - fix-it.

And one more thing - a better check would be to account for defaultable parameters as well, so if there are 0 parameters or all of the parameters are defaultable - fix-it.

I like it! I'd also suggest to add a note - did you mean to call it with '()' and attach a fix-it to that instead of fix-it alone, it make it more clearer.

I thought that was the purpose of the add_empty_parameter_list_fixit diagnostic? The last error has an additonal error  did you mean to call 'boom' with '()'? @xedin

Ah, right, sorry I missed that one, then the only viable thing is related to default parameters and we should be good to go!

Ah, right, sorry I missed that one, then the only viable thing is related to default parameters and we should be good to go!

I cannot figure out how to check for that. Is there a part of the docs I should be looking at specifically?

If I remember correctly parameter list consists of ParamDecl * and there is a way to check whether it has a default or not, so you'd just need add a check to make sure that if there are parameters they are all defaulted.

I cannot figure out how to check for that. Is there a part of the docs I should be looking at specifically?

An example you can look at :) https://github.com/apple/swift/blob/19a4df331c3de41dac1b2d069cbda863ed0f24e5/lib/Sema/CSSimplify.cpp#L3437-L3446

Sorry for the delay folks. The example posted earlier has some functions that aren't available in the file, as to not add more imports I went down the ParamDecl route.
  if (auto FD = dyn_cast<FuncDecl>(getDC())) {
    auto params = FD->getParameters();

    bool hasNonDefaultParam =
        std::any_of(params->begin(), params->end(),
                    [](ParamDecl *param) { return !param->isDefaultArgument(); });

    if (params->size() == 0 && !hasNonDefaultParam) {
      emitDiagnosticAt(getLoc(), diag::add_empty_parameter_list_fixit,
                       anchor->getName().getBaseIdentifier())
          .fixItInsertAfter(getLoc(), "()");
    }
  }

Btw is it ok to force push over this branch?

Yeah, it's fine to force push.

@abdulajet There is an llvm equivalent of std::any_of - it works with ArrayRefs so you don't have to use begin/end e.g. llvm::any_of(params, [](const ParamDecl *param) { ... })

I would suggest using llvm::none_of here though to avoid negative checks.

Also, please don't apologize about delays or similar. 😄 It's totally okay. You're doing this in your free time and we are thankful for your contributions, at whatever pace works for you.

Thanks for all the help!
 if (auto FD = dyn_cast<FuncDecl>(getDC())) {
    auto params = FD->getParameters();

    bool hasNoNonDefaultParams = llvm::none_of(
        *params, [](ParamDecl *param) { return param->isDefaultArgument(); });

    if (params->size() == 0 && hasNoNonDefaultParams) {
      emitDiagnosticAt(getLoc(), diag::add_empty_parameter_list_fixit,
                       anchor->getName().getBaseIdentifier())
          .fixItInsertAfter(getLoc(), "()");
    }
  }

Ill get the tests done then push this up.

Sounds great, thank you!

if (params->size() == 0 && hasNoNonDefaultParams) {

I think you mean ||

aha yes i 100% do. cheers

Sorry if this is being nitpicking but I think that llvm::all_of would be more readable here
Because (params->size() == 0 || hasNoNonDefaultParams) reads has no params or has no non default params
But (params->size() == 0 || allParamsHaveDefaultArg) reads has no params or all parameters have a default argument which reads as exactly what is the intention here without double no. WDYT @xedin?
Both are fine but the first one took me more time to understand ...

Works either way, I think it's a matter of personal preference.

I have an issue where the conditions for the fixit are being applied where they shouldn't:
super.baseFunc0() in NameLookup/name_lookup.swift is passing the condition of no params. So i think we also need to check if the function isnt being called already:
if ((params->size() == 0 && hasNoNonDefaultParams) && notBeingCalled) {

}

Is there someone I can see an example of a check for if the function is being called? Not sure i can see anything on the public interface of FuncDecl or UnresolvedDotExpr
For @xedin you mentioned

Please add a test case or two for the fix-it as well

in the initial discussion. Should this be in its own test file?
Thanks all!

So i think we also need to check if the function isnt being called already:

Shouldn't the logic which detects that it's a partial application already handle that?

Should this be in its own test file?

I think you can add new tests to test/Constraints/members.swift.

Shouldn't the logic which detects that it's a partial application already handle that?

Oh yeah, of course! In that case, I am not sure why the diag is being called for this test
Here is an example of the failing test from NameLookup/name_lookup.swift
super.baseFunc0() // expected-error {{instance member 'baseFunc0' cannot be used on type 'ThisBase1'}}
// expected-error@-1 {{cannot reference 'super' instance method with metatype base as a function value}}

@abdulajet Since baseFunc0 is an instance method its signature is (Self) -> () -> Void, I think the diagnostic logic is wrong and it shouldn't even talk about partial application in this case since it's used from a class func context so super there means a different thing.

Cool, ill look into that

@xedin I have had a look around, the path I was going down was trying to see if the function was marked with a class descriptor and returning false out of the diagnostic. Would this a good solution or would it be better to go further upstream and stop the PartialApplicationFailure::diagnoseAsError() function from being called for a class func entirely.
Thanks again

@abdulajet The way diagnostics are currently implemented in the solver is two-fold - there is a "ConstraintFix" and that has a "FailureDiagnostic" attached to that. ConstraintFix subtypes are responsible for failure identification and information storage, FailureDiagnostic subtypes are responsible for diagnostic emission based on collected information.
What you want to do here is to prevent a fix (AllowInvalidPartialApplication in this case) from being recorded in situations like what you have described. There is a method which is responsible for verifying references - isInvalidPartialApplication (it's called by ConstraintSystem::resolveOverload), you'd need to adjust isInvalidPartialApplication to consider declaration context associated with given constraint system (accessible via DC member of ConstraintSystem) before making decisions about invalid partial applications.

Amazing! Will take a look, thanks.

Hey @xedin Apologies for not coming back with code but my build broke so rebuilding for Xcode so I can debug easier. Thank you for the explanation, I had a look at the files you suggested and to just check my understanding:
The DeclContext object that I have in isInvalidPartialApplication is the context in which the line of code is being called right? So in our case, whether it is being called from a class function.

getStaticSpelling seems to only return  StaticSpellingKind::KeywordStatic or StaticSpellingKind::None. Any ideas @LucianoPAlmeida?
cheers

getStaticSpelling  seems to only return StaticSpellingKind::KeywordStatic  or  StaticSpellingKind::None. Any ideas @LucianoPAlmeida?
cheers

Hey @abdulajet :)
Sorry, I've been a bit swamped these days so I'm maybe a bit out of context here ...
But for what I understood, what @xedin meant is that in isInvalidPartialApplication since the base is a super expression (UDE->getBase()->isSuperExpr()) it would be not valid to be reference it on a class method context (in this case staticTestSuper1). So what we want is to check for the context the FD is in not FD itself.
So what we probably want is on https://github.com/apple/swift/blob/281ce3d77ebfe587b4344f10496f3a9a1a411c5c/lib/Sema/ConstraintSystem.cpp#L2139
To check for the class method context
auto ctxDecl = cs.DC->getAsDecl(); // Get Context declaration in this case `staticTestSuper1`
if (UDE->getBase()->isSuperExpr() && baseTy->is<MetatypeType>() &&
     !FD->isStatic() &&
     (!ctxDecl || ctxDecl->getDescriptiveKind() != DescriptiveDeclKind::ClassMethod)) // Since UDE->getBase()->isSuperExpr() is true, this would could not be consider a partial application if the context in what it is called is a class method
  return true;

That is what I understood from the problem, but as I mentioned I'm a bit out of context so sorry if I get something wrong @xedin =]

i see! i'll give that a go, thank you!

Yes, @LucianoPAlmeida that sounds reasonable to me.

Ok very close now! getting an error when running the test now (stack trace below). I had a play and it happens whenever the existing check returns false.
Assertion failed: ((matchCanFail || callArgumentMatch) && "Call arguments did not match up?"), function coerceCallArguments, file /Users/aajetunmobi/Documents/swiftp/swift/lib/Sema/CSApply.cpp, line 5792.
Please submit a bug report (https://swift.org/contributing/#reporting-bugs) and include the project and the crash backtrace.
Stack dump:
0.	Program arguments: /Users/aajetunmobi/Documents/swiftp/build/Ninja-RelWithDebInfoAssert/swift-macosx-x86_64/bin/swift-frontend -target x86_64-apple-macosx10.9 -module-cache-path /Users/aajetunmobi/Documents/swiftp/build/Ninja-RelWithDebInfoAssert/swift-macosx-x86_64/swift-test-results/x86_64-apple-macosx10.9/clang-module-cache -sdk /Applications/Xcode-12.3.0.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.1.sdk -swift-version 4 -ignore-module-source-info -typo-correction-limit 10 -typecheck -verify -disable-objc-attr-requires-foundation-module /Users/aajetunmobi/Documents/swiftp/swift/test/NameLookup/name_lookup.swift -typo-correction-limit 100
1.	Swift version 5.5-dev (LLVM d890ae6d708cef6, Swift 3d2fd566cc67e7b)
2.	While evaluating request TypeCheckSourceFileRequest(source_file "/Users/aajetunmobi/Documents/swiftp/swift/test/NameLookup/name_lookup.swift")
3.	While evaluating request TypeCheckFunctionBodyRequest(name_lookup.(file).ThisDerived1.staticTestSuper1()@/Users/aajetunmobi/Documents/swiftp/swift/test/NameLookup/name_lookup.swift:291:14)
4.	While type-checking statement at [/Users/aajetunmobi/Documents/swiftp/swift/test/NameLookup/name_lookup.swift:291:33 - line:341:3] RangeText="{
    super.baseInstanceVar = 42 // expected-error {{member 'baseInstanceVar' cannot be used on type 'ThisBase1'}}
    super.baseProp = 42 // expected-error {{member 'baseProp' cannot be used on type 'ThisBase1'}}
    super.baseFunc0() // expected-error {{instance member 'baseFunc0' cannot be used on type 'ThisBase1'}}
    super.baseFunc0(ThisBase1())()
    super.baseFunc1(42) // expected-error {{instance member 'baseFunc1' cannot be used on type 'ThisBase1'}}
    super.baseFunc1(ThisBase1())(42)
    super[0] = 42.0 // expected-error {{instance member 'subscript' cannot be used on type 'ThisBase1'}}
    super.baseStaticVar = 42
    super.baseStaticProp = 42
    super.baseStaticFunc0()

    super.baseExtProp = 42 // expected-error {{member 'baseExtProp' cannot be used on type 'ThisBase1'}}
    super.baseExtFunc0() // expected-error {{instance member 'baseExtFunc0' cannot be used on type 'ThisBase1'}}
    super.baseExtStaticVar = 42 // expected-error {{instance member 'baseExtStaticVar' cannot be used on type 'ThisBase1'}}
    super.baseExtStaticProp = 42 // expected-error {{member 'baseExtStaticProp' cannot be used on type 'ThisBase1'}}
    super.baseExtStaticFunc0()

    var bs2 = super.BaseNestedStruct()
    var bc2 = super.BaseNestedClass()
    var bo2 = super.BaseUnionX(24) // expected-error {{type 'ThisBase1' has no member 'BaseUnionX'}}
    var bo3 = super.BaseNestedUnion.BaseUnionX(24)
    var bt2 = super.BaseNestedTypealias()

    super.derivedInstanceVar = 42 // expected-error {{type 'ThisBase1' has no member 'derivedInstanceVar'}}
    super.derivedProp = 42 // expected-error {{type 'ThisBase1' has no member 'derivedProp'}}
    super.derivedFunc0() // expected-error {{type 'ThisBase1' has no member 'derivedFunc0'}}
    super.derivedStaticVar = 42 // expected-error {{type 'ThisBase1' has no member 'derivedStaticVar'}}
    super.derivedStaticProp = 42 // expected-error {{type 'ThisBase1' has no member 'derivedStaticProp'}}
    super.derivedStaticFunc0() // expected-error {{type 'ThisBase1' has no member 'derivedStaticFunc0'}}

    super.derivedExtProp = 42 // expected-error {{type 'ThisBase1' has no member 'derivedExtProp'}}
    super.derivedExtFunc0() // expected-error {{type 'ThisBase1' has no member 'derivedExtFunc0'}}
    super.derivedExtStaticVar = 42 // expected-error {{type 'ThisBase1' has no member 'derivedExtStaticVar'; did you mean 'baseExtStaticVar'?}}
    super.derivedExtStaticProp = 42 // expected-error {{type 'ThisBase1' has no member 'derivedExtStaticProp'; did you mean 'baseExtStaticProp'?}}
    super.derivedExtStaticFunc0() // expected-error {{type 'ThisBase1' has no member 'derivedExtStaticFunc0'; did you mean 'baseExtStaticFunc0'?}}

    var ds2 = super.DerivedNestedStruct() // expected-error {{type 'ThisBase1' has no member 'DerivedNestedStruct'}}
    var dc2 = super.DerivedNestedClass() // expected-error {{type 'ThisBase1' has no member 'DerivedNestedClass'}}
    var do2 = super.DerivedUnionX(24) // expected-error {{type 'ThisBase1' has no member 'DerivedUnionX'}}
    var do3 = super.DerivedNestedUnion.DerivedUnionX(24) // expected-error {{type 'ThisBase1' has no member 'DerivedNestedUnion'}}
    var dt2 = super.DerivedNestedTypealias(42) // expected-error {{type 'ThisBase1' has no member 'DerivedNestedTypealias'}}

    var des2 = super.DerivedExtNestedStruct() // expected-error {{type 'ThisBase1' has no member 'DerivedExtNestedStruct'; did you mean 'BaseExtNestedStruct'?}}
    var dec2 = super.DerivedExtNestedClass() // expected-error {{type 'ThisBase1' has no member 'DerivedExtNestedClass'; did you mean 'BaseExtNestedClass'?}}
    var deo2 = super.DerivedExtUnionX(24) // expected-error {{type 'ThisBase1' has no member 'DerivedExtUnionX'}}
    var deo3 = super.DerivedExtNestedUnion.DerivedExtUnionX(24) // expected-error {{type 'ThisBase1' has no member 'DerivedExtNestedUnion'; did you mean 'BaseExtNestedUnion'?}}
    var det2 = super.DerivedExtNestedTypealias(42) // expected-error {{type 'ThisBase1' has no member 'DerivedExtNestedTypealias'; did you mean 'BaseExtNestedTypealias'?}}

    super.Type // expected-error {{type 'ThisBase1' has no member 'Type'}}
  "
5.	While type-checking expression at [/Users/aajetunmobi/Documents/swiftp/swift/test/NameLookup/name_lookup.swift:295:5 - line:295:34] RangeText="super.baseFunc0(ThisBase1())("
Stack dump without symbol names (ensure you have llvm-symbolizer in your PATH or set the environment var `LLVM_SYMBOLIZER_PATH` to point to it):
0  swift-frontend           0x0000000112204907 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) + 39
1  swift-frontend           0x00000001122039d5 llvm::sys::RunSignalHandlers() + 85
2  swift-frontend           0x0000000112204f36 SignalHandler(int) + 262
3  libsystem_platform.dylib 0x00007fff2038ed7d _sigtramp + 29
4  libsystem_platform.dylib<PHONE_NUMBER>00000000 _sigtramp +<PHONE_NUMBER>9975561888
5  libsystem_c.dylib        0x00007fff2029d720 abort + 120
6  libsystem_c.dylib        0x00007fff2029c9d6 err + 0
7  swift-frontend           0x0000000112760413 (anonymous namespace)::ExprRewriter::coerceCallArguments(swift::Expr*, swift::AnyFunctionType*, swift::ConcreteDeclRef, swift::ApplyExpr*, llvm::ArrayRef<swift::Identifier>, swift::constraints::ConstraintLocatorBuilder, llvm::ArrayRef<swift::AppliedPropertyWrapper>) (.cold.72) + 35
8  swift-frontend           0x000000010e09578b (anonymous namespace)::ExprRewriter::coerceCallArguments(swift::Expr*, swift::AnyFunctionType*, swift::ConcreteDeclRef, swift::ApplyExpr*, llvm::ArrayRef<swift::Identifier>, swift::constraints::ConstraintLocatorBuilder, llvm::ArrayRef<swift::AppliedPropertyWrapper>) + 8427
9  swift-frontend           0x000000010e09e7d0 (anonymous namespace)::ExprRewriter::finishApply(swift::ApplyExpr*, swift::Type, swift::constraints::ConstraintLocatorBuilder, swift::constraints::ConstraintLocatorBuilder) + 7376
10 swift-frontend           0x000000010e0a4fb8 (anonymous namespace)::ExprRewriter::visitApplyExpr(swift::ApplyExpr*) + 440
11 swift-frontend           0x000000010e0882b6 (anonymous namespace)::ExprWalker::walkToExprPost(swift::Expr*) + 22
12 swift-frontend           0x000000010e4ece1b (anonymous namespace)::Traversal::visitApplyExpr(swift::ApplyExpr*) + 123
13 swift-frontend           0x000000010e4ea3d1 swift::Expr::walk(swift::ASTWalker&) + 81
14 swift-frontend           0x000000010e081708 (anonymous namespace)::ExprWalker::rewriteTarget(swift::constraints::SolutionApplicationTarget) + 136
15 swift-frontend           0x000000010e0814ce swift::constraints::ConstraintSystem::applySolution(swift::constraints::Solution&, swift::constraints::SolutionApplicationTarget) + 622
16 swift-frontend           0x000000010e248c19 swift::TypeChecker::typeCheckExpression(swift::constraints::SolutionApplicationTarget&, swift::OptionSet<swift::TypeCheckExprFlags, unsigned int>) + 633
17 swift-frontend           0x000000010e24891d swift::TypeChecker::typeCheckExpression(swift::Expr*&, swift::DeclContext*, swift::constraints::ContextualTypeInfo, swift::OptionSet<swift::TypeCheckExprFlags, unsigned int>) + 77
18 swift-frontend           0x000000010e308a4b (anonymous namespace)::StmtChecker::typeCheckASTNode(swift::ASTNode&) + 235
19 swift-frontend           0x000000010e30a9dc swift::ASTVisitor<(anonymous namespace)::StmtChecker, void, swift::Stmt*, void, void, void, void>::visit(swift::Stmt*) + 124
20 swift-frontend           0x000000010e309d50 bool (anonymous namespace)::StmtChecker::typeCheckStmt<swift::BraceStmt>(swift::BraceStmt*&) + 128
21 swift-frontend           0x000000010e3091f3 swift::TypeCheckFunctionBodyRequest::evaluate(swift::Evaluator&, swift::AbstractFunctionDecl*) const + 931
22 swift-frontend           0x000000010e5deaee llvm::Expected<swift::TypeCheckFunctionBodyRequest::OutputType> swift::Evaluator::getResultUncached<swift::TypeCheckFunctionBodyRequest>(swift::TypeCheckFunctionBodyRequest const&) + 414
23 swift-frontend           0x000000010e5de88b llvm::Expected<swift::TypeCheckFunctionBodyRequest::OutputType> swift::Evaluator::getResultCached<swift::TypeCheckFunctionBodyRequest, (void*)0>(swift::TypeCheckFunctionBodyRequest const&) + 107
24 swift-frontend           0x000000010e54b655 swift::TypeCheckFunctionBodyRequest::OutputType swift::evaluateOrDefault<swift::TypeCheckFunctionBodyRequest>(swift::Evaluator&, swift::TypeCheckFunctionBodyRequest, swift::TypeCheckFunctionBodyRequest::OutputType) + 37
25 swift-frontend           0x000000010e33d95e swift::TypeCheckSourceFileRequest::evaluate(swift::Evaluator&, swift::SourceFile*) const + 366
26 swift-frontend           0x000000010e33ea8f llvm::Expected<swift::TypeCheckSourceFileRequest::OutputType> swift::Evaluator::getResultUncached<swift::TypeCheckSourceFileRequest>(swift::TypeCheckSourceFileRequest const&) + 415
27 swift-frontend           0x000000010e33e844 llvm::Expected<swift::TypeCheckSourceFileRequest::OutputType> swift::Evaluator::getResultCached<swift::TypeCheckSourceFileRequest, (void*)0>(swift::TypeCheckSourceFileRequest const&) + 100
28 swift-frontend           0x000000010e33d710 swift::TypeCheckSourceFileRequest::OutputType swift::evaluateOrDefault<swift::TypeCheckSourceFileRequest>(swift::Evaluator&, swift::TypeCheckSourceFileRequest, swift::TypeCheckSourceFileRequest::OutputType) + 32
29 swift-frontend           0x000000010d58c19e swift::CompilerInstance::forEachFileToTypeCheck(llvm::function_ref<void (swift::SourceFile&)>) + 174
30 swift-frontend           0x000000010d58c03a swift::CompilerInstance::performSema() + 74
31 swift-frontend           0x000000010d41ee43 swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) + 7011
32 swift-frontend           0x000000010d36f0c7 main + 519
33 libdyld.dylib            0x00007fff20365621 start + 1

@abdulajet
By a quick look, what I could see is that since we aren't considering super.baseFunc0(ThisBase1())() as an invalid partial application(which seems correct) but there isn't other diagnostic being emitted for that, this is being considered as "valid".
I think we should emit the same instance member 'baseFunc0' cannot be used on type 'ThisBase1' as super.baseFunc0() on line above because is the same problem. We have to found why this isn't emitted for this situation in specific :)

ok! so it was crashing because it was expected to have some sort of diagnostic but it wasn't producing one?

ok! so it was crashing because it was expected to have some sort of diagnostic but it wasn't producing one?

From my current understanding, yes exactly :)
What I would expect is for both cases to produce the same diagnostic like
 super.baseFunc0() // expected-error {{instance member 'baseFunc0' cannot be used on type 'ThisBase1'}}
 super.baseFunc0(ThisBase1())() // expected-error {{instance member 'baseFunc0' cannot be used on type 'ThisBase1'}}

thank you! will take a look

Better thinking about it ... since (_self: ThisBase1) -> () -> Void is the type of super.baseFunc0 this super.baseFunc0(ThisBase1()) may be considered a partial application? In that case the invalid application diagnostic would be correct in this situation.
cc @xedin

@LucianoPAlmeida Yes, I think that's correct - super.baseFunc0(ThisBase1()) should really be considered a partial application.

@LucianoPAlmeida would that be this specific test case or all the ones we suspected to be wrong in this test file?

@LucianoPAlmeida Yes, I think that's correct - super.baseFunc0(ThisBase1()) should really be considered a partial application.

That makes sense, thank you @xedin

@LucianoPAlmeida would that be this specific test case or all the ones we suspected to be wrong in this test file?

This applies only for this case I think, as Pavel mentioned super.baseFunc0(ThisBase1()) is a partial application, so even if it is on a context of a static function it should be considered an invalid partial application. I think that maybe one option we have for this is to do an additional consideration on the check for the UnresolvedDotExpr and consider that it is an invalid partial application also if getFunctionRefKind is a FunctionRefKind::DoubleApply. WDYT @xedin?

I think DoubleApply but itself is insufficient, I think we need to check in what context we are trying to use super. and then suggest that instance methods can't be used on metatype base? Or maybe checking a type of super would be sufficient?

I think DoubleApply but itself is insufficient, I think we need to check in what context we are trying to use super. and then suggest that instance methods can't be used on metatype base? Or maybe checking a type of super would be sufficient?

Hum, @xedin maybe we don't even have to check for invalid partial application in this super.baseFunc0() case. It is already producing a instance member 'baseFunc0' cannot be used on type 'ThisBase1' diagnostic which is given by a fix, so if we know that this is already invalid (checking if there is already a fix recorded) so there is no need for check for isInvalidPartialApplication because we already know that super. is invalid on this context. Do you think this makes sense?
I'm right now rebuilding all after rebase with main, but after that I can debug and confirm if that is possible :)

Does it do it in all three cases e.g. super.baseFunc0(), super.baseFunc0(ThisBase1()), and super.baseFunc0(ThisBase1())()?

Does it do it in all three cases e.g. super.baseFunc0(), super.baseFunc0(ThisBase1()), and super.baseFunc0(ThisBase1())()?

Not in all cases, but if I think it should be possible to tweak that where the fix is recorded maybe?

Yeah, that's what I was thinking...

so instead of a check on it being a class function there should be a check if a fix has been recorded already for a function called on "super"?
i know this ticket wasn't as straight forward as expected so i appreciate the time and help!

Yeah, that's what I was thinking...

Awesome! Thanks @xedin

so instead of a check on it being a class function there should be a check if a fix has been recorded already for a function called on "super"?

@abdulajet
If I understand correctly yes, but also see where the AllowTypeOrInstanceMember is recorded for super.baseFunc0() and tweak the logic to also record it for super.baseFunc0(ThisBase1()) and super.baseFunc0(ThisBase1())() :)

Does this diagnostic work differently from isInvalidPartialApplication? I couldn't find the ConstraintFix. I did see the function bool AllowTypeOrInstanceMemberFailure::diagnoseAsError() in CSDiagnostics.cpp. The diagnostic we are hoping to trigger is on line 3957

Took another look, so AllowTypeOrInstanceMember::diagnose gets called for super.baseFunc0(), as expected, but not for super.baseFunc0(ThisBase1())() which I guess is what we want to change?
I am thinking whether diagnose gets called is based on the ConstraintSystem passed to AllowTypeOrInstanceMember::create which is where I am a bit stuck. cc @xedin @LucianoPAlmeida

hey folks, bumping this! would love to get it across the line

@LucianoPAlmeida Would you like to take charge on this one since you have worked on AllowTypeOrInstanceMember diagnostic?

@LucianoPAlmeida Would you like to take charge on this one since you have worked on AllowTypeOrInstanceMember diagnostic?

For sure @xedin :)
I'll take a look as soon as possible

@LucianoPAlmeida did you get a chance to look at this? Cheers

Hi @abdulajet,
Unfortunately I completely forgot this one, because there was some other issues on my queue already so this one got lost, sorry for that. I have some issues I'm currently working on and lately is been more difficult to find free time for Open Source, so I cannot promise I'll be able to look at this soon... sorry

no worries! take your time

Should we scope this down to message adjustments? I think changing it to say referencing ... as a function value should be landable by itself and all of the additional changes could be done in a separate PR.

Should we scope this down to message adjustments? I think changing it to say referencing ... as a function value should be landable by itself and all of the additional changes could be done in a separate PR.

Given that the SR is only about the terminology, I think this would be fine :)
Perhaps we could create another SR for the additional issues? It would also be easier to describe the additional issues specifically there to narrow that from this thread since it got a lot of things(e.g. implementation details, crash logs and so on...) and is a bit hard to narrow it down.
Maybe it would also be good to add a FIXME(diagnostics) comment around the problematic case as well(as far as I remenber the additional issue is about a specific edge case)? What you think @xedin?

I think using FIXME(diagnostics) would be fine as soon as we have all of the issues filed as SRs so it's easy to keep track of them and tackle one by one.

ok to revert back to just changing the text of the diagnostic then 2 new SRs. One for the diagnostic being called incorrectly and a dependent one that adds the fix it?

ok to revert back to just changing the text of the diagnostic then 2 new SRs. One for the diagnostic being called incorrectly and a dependent one that adds the fix it?

Sounds good to me =]

SRs:
https://bugs.swift.org/browse/SR-15250
https://bugs.swift.org/browse/SR-15251

SRs:
https://bugs.swift.org/browse/SR-15250
https://bugs.swift.org/browse/SR-15251

Thank you!
For this one then we only need to rebase with man, make sure all tests pass, add the proper TODO(diagnostics) referencing the SRs and this would be good to go I think

Sure thing! Will do it this weekend

Did we want to leave it as "calling" or change to "referencing"

Did we want to leave it as "calling" or change to "referencing"

From what I see here https://github.com/apple/swift/pull/35466#discussion_r559252420 we agreed on cannot reference 'mutating' method "foo" as a function value

Agree with @LucianoPAlmeida here, "referencing" seems more appropriate here.

@LucianoPAlmeida updated to use "reference" and added some comments to name_lookup.swift for the linked SRs. Let me know if they are better placed elsewhere

@swift-ci Please smoke test

@abdulajet there is one missing test to adjust /test/type/self.swift:358


Apply standard format code

https://standardjs.com/rules.html

Sorry, there is no interest to this repository to adopt Standard style.


Read current version of config store from metadata file

Changes

Added reading and writing to store metadata file which will reside in _CONIFG_STORE directory
Currently only active version is stored but can store any key value pairs
Keep a back up of old store metadata file if case we want to recover from a failed deployment
Added more unit tests
Removed rollback for Deployable interface as the deploy will be used for rollback as well

@sahilTakiar can you review?

Whats the reason for removing the rollback method? The problem with just having a deploy method is that now deployed version are basically mutable.
The advantage of the rollback method is that it shouldn't need to modify any files, it just changes the symlink file.

A version is NOT mutable. Take a look at line 436 in the deploy method, we skip copy a new set of files from classpath only if the version does not exist on HDFS. For instance when we rollback from 0.7 to 0.3 no new configs will be copied to 0.3 directory even if the files have changed in classpath. We only update the metadata file to 0.3

Ok thats fine, but still whats the reason for not having a rollback method that just sets the version.

We do not have the need for that now. Let us add the rollback interface when such a requirement comes up.
From the StoreDeployer I always call the deploy method with the version to be deployed. It can either be an existing version (a rollback) or a new version.

I'm confused, I thought the point of this PR was to add rollback functionality as stated in the PR description "Removed rollback for Deployable interface as the deploy will be used for rollback as well"
My question is whats the justification for using the deploy method for rollbacks instead of having an explicit rollback method? The rollback method shouldn't be particularly complex as you already have the work to update the symlink file. I think having a rollback method makes more sense than using the deploy method for rollbacks, at least from a usability perspective.

Hi @sahilTakiar
If we have separate methods rollback and deploy the user has to pass from command line or in the azkaban props the operation he is trying to do. Then the StoreDeployer needs to have logic to decide whether to call SimpleHDFSStore.deploy or SimpleHDFSStore.rollback.
With the way I have it, the user does not have to specify the operation from command line and StoreDeployer always calls SimpleHDFSStore.deploy
We can discuss offline if you still have concerns.

Can rollbacks just be done from the command line? If its Azkaban there can be a separate job for rollbacks.
We can discuss more on Monday.

LGTM

Had some offline discussion about whether to include the rollback feature - sticking to current approach for now to unblock this PR, and will discuss with @chavdar offline


Understanding type and hierarchy or tracked exceptions

Hi folks,
I have a question about how we track and display exception. I think that we may be displaying an inner exception where the outer exception should be shown and I would like to validate whether my reasoning makes sense.
Scenario:
(Full repro code below.) Inside an Azure Function I am using an Http Client to call an invalid URL and then I use response.EnsureSuccessStatusCode() to get an exception thrown. Later I catch and track that exception.
If I inspect that exception in VS I see that this is a nested exception. The outer exception is HttpRequestException and it is wrapping an SocketException. This makes sense.

However, when I look at the E2E telemetry, see the following, which I find confusing.
a)	The exception is shown twice – in the context of the dependency and then in the context of my method.
b)	The overview shows the type of the inner exception, where as the mindset I have is in terms of the outer exception – after all the outer type is what I have specified when catching it by type.

The way the information is presented is a property of the data, not the UI. You can see it in the telemetry details:
[ Go to Log Analytics and Run Query ]

After adding the TrackedExplicitly flag I was able to understand why I see the exception twice – it was logged by the runtime and rethrown and then it was logged by me again. This is very confusing: it took adding the TrackedExplicitly flag to understand but now that I do, I do not know if and how we can make it better. Perhaps there is any context I am missing around this, I would love to know.
The other point - taking the “main” type from the inner rather than the outer type seems less understandable. My code explicitly works with an HttpRequestException but I see a different type in the logs. Is there a specific reason why it works this way?
Thank you!
Full repro code:
using System;
using System.Threading.Tasks;
using System.Net.Http;
using System.Collections.Generic;
using Microsoft.AspNetCore.Mvc;
using Microsoft.Azure.WebJobs;
using Microsoft.Azure.WebJobs.Extensions.Http;
using Microsoft.AspNetCore.Http;
using Microsoft.Extensions.Logging;
using Microsoft.ApplicationInsights;
using Microsoft.ApplicationInsights.Extensibility;

namespace GregP_Functions05
{
    public class Func_03_04
    {
        public const string Version = "9";

        private readonly TelemetryClient _telemetryClient;

        public Func_03_04(TelemetryConfiguration telemetryConfig)
        {
            _telemetryClient = new TelemetryClient(telemetryConfig);
        }

        [FunctionName("Func-03-04")]
        public async Task<IActionResult> Run(
                            [HttpTrigger(AuthorizationLevel.Anonymous, "get", Route = null)] HttpRequest req,
                            ExecutionContext context, ILogger log)
        {
            string funcName = $"{typeof(Func_03_04).FullName}.Version.{Func_03_04.Version}";

            log.LogInformation("C# HTTP trigger function processed a request.");
            log.LogInformation($"Exec type: \"{funcName}\".");

            string simulateFailureStr = req.Query["SimulateFailure"];
            simulateFailureStr = String.IsNullOrEmpty(simulateFailureStr) ? "false" : simulateFailureStr;
            bool simulateFailure = Boolean.Parse(simulateFailureStr);

            try
            {
                using (HttpClient client = new HttpClient())
                {

                    using (HttpResponseMessage response = await client.GetAsync(simulateFailure
                                                                            ? "https://www.bing.comX/search?q=My+Query+Term"
                                                                            : "https://www.bing.com/search?q=My+Query+Term"))
                    {
                        response.EnsureSuccessStatusCode();

                        const string expectedContent = "<title>My Query Term - Bing</title>";
                        string responseContent = await response.Content.ReadAsStringAsync();
                        bool? hasExpectedContent = responseContent?.Contains(expectedContent);

                        if (true != hasExpectedContent)
                        {
                            throw new Exception("Remote call succeeded, but response did not contain the expected content.");
                        }
                    }
                }
            }
            catch (HttpRequestException exception)
            {
                _telemetryClient.TrackException(
                                        exception,
                                        new Dictionary<string, string>() { ["TrackedExplicitly"] = true.ToString() });
            }

            return new OkObjectResult($"\"{funcName}\" completed. simulateFailure={simulateFailure}. Time is {DateTimeOffset.UtcNow}.");
        }
    }
}

The fact that exception is shown twice is due to this known issue, where DependencyTrackingModule reports an exception. (i.e it calls TrackException). This bug/issue exists only in .net core implementation, and not in .net framework. This must be fixed.
https://github.com/microsoft/ApplicationInsights-dotnet/issues/1362

The sdkVersion field in the Exception gives a hint to who/how this was tracked - rdddsc - indicates from DependencyTrackingModule. dotnetc  - indicates manual track.

The Exception telemetry correctly has outerType as HttpRequestException and innermostType as
System.Net.Sockets.SocketException

Maybe this UI is designed to show innermost exception than outermost one. I'll let UI team comment on this. @zakimaksyutov ?

Closing as no action on this for a long time.

Could this be reopened for discussion please? The situation with the Azure Portal's UI is still the same as reported earlier by @macrogreg. I strongly agree that the outermost exception should be displayed on the failures/end-to-end transaction details views, instead of the innermost. Then, when troubleshooting a particular case, the developer could still drill down in Log Analytics and see the inner exception. But for a quick check, it's extremely confusing to see that my code tracks one type of exception, but on the portal I see another one. What do you think about this @cijothomas @zakimaksyutov ?

I'll wait to see if @zakimaksyutov knows if this is intentional in UI.

Any news on this? I want to second @peterbozso  that this behaviour is very confusing as App Insights UI shows the inner exception type rather than the outer exception type

Why was this issue closed? It was never answered.


Some details about Debian 10

Hello together,
at first i should apologize for my bad english.
So with that out of the way, i found some things while installing only the Internet Monitoring to a Debian 10 VM running on Unraid.
First i followd the instructions given within the readme.md but kept running into issues.
I managed to instull it properly by doing some steps before i run the main.yml.
The folder /home//internet-monitoring, /home//internet-monitoring/grafana and /home//internet-monitoring/prometheus needed to be created and also the /home//internet-monitoring/grafana/config.monitoring should be created and filled before running the main.yml.
Also i needed to install sshpass, rsync and sudo to the system.
The last thing i needed to do is running the playbook with --ask-pass because i let it run localy.
I think maybe this should be extendet to the readme.md but i don´t know if this is just my fault :'D
Just tought i let you all know what i needed to do before the install won´t fail.
The system was cleanly installed on a small VM with the newest debian iso from their website.
Greetings from Germany
Panics11

@Panics11 - The Ansible playbook should create all those for you, unless you somehow aren't logged in as a user on the system (I noticed you put /home//internet-monitoring and not /home/pi/internet-monitoring?).
Also, when you download this project and expand it, or git clone it to your Pi, it should have created all the relevant folder structures for you where the configurations go (and the ones that aren't there are then created by Ansible).

@geerlingguy the path was /home/<user>/internet-monitoring i wrote but missed the code tags :/
I don´t installed the playbook to a raspberry pi cuz i don´t have any free pi´s right now and installed it directly in a VM running on my Homeserver witch is running Unraid.
I cloned it with git but it doesn´t created the relevant folders.
Just wanted to wrote this down if someone is in my situation..
Also i edit my recent post with code Tags so it will get displayed properly..


Kirstie's To Do list - Week starting 28th August 2017

URGENT

[ ] Letters of recommendation for SRA application deadline 26th July

To Do
Emails/Online

[ ] Email NCH re inclusivity call
[ ] Add ICON2017 slides to whitakerlab.github.io
[ ] Reply to PB email about  outreach
[ ] Introduce HQ to CSAP folk & Inga
[ ] Schedule call w Wellcome Trust
[ ] Invoice to British Library
[ ] Invoice to Fuel
[ ] Newsletter - August #74
[ ] Newsletter - September #78
[ ] Write RA job description

Waiting on admin response

[x] Survey for research fellows office hours -- see #81
[x] Coordinate Data Blitz for CamNeuro

Next step (after 5th September) - merge presentations together

[x] Doodle for Neurohackweek advisory meeting
[ ] DBS check with STEM Ambassadors

NSPN Analyses

[ ] Run longitudinal pipeline on HPHI

[ ] Need to be able to actually run code on HPHI first! See #39 😕
[ ] Need to copy over the data from HPC
[ ] Also need to check that everything looks good

[ ] Incorporate von Economo atlas in NSPN code
[ ] Send HCP parcellation data to JS deadline 1st August
[ ] Email to SW & PV re analysis update

NSPN Data Management (issue list)

[ ] Update data management team on Cambridge repository -- see NSPN-DM-#1
[ ] Arrange date for next data management meeting

👉 Email sent 31st August

Blogs/interviews/writing

[ ] Edit story engine for Mozilla
[ ] Call for evidence -- see #76
[ ] Apply for rOpenSci fellowship -- see #66 deadline 1st September
[x] Research report for Turing -- see #69  deadline 22nd August

Invited talks/teaching

[x] Talk for brainintensive -- see #65
[ ] Presentation for Turing grad students

BrainAge

[ ] Get code installed & running
[ ] Send questions to FL

OpenAdvice

[ ] Migrate to organisation ProjectOpenAdvice & build website there: https://projectopenadvice.github.io/
[ ] Merge jekyll pull request

OpenConCam

[ ] Rearrange meeting & make to do list

Peer Reviews

[ ] A0029 deadline August 29th
[ ] A0030 deadline August 30th

MozFest

[ ] Read through spreadsheet & categorise

Email MB re: dat project

Introduce AM & VL

Email TN re: logistics

Email CH re: FA

TFL data study group - hackathon


Create hallifordschool.txt

hallifordschool.co.uk

Note site must be visited with www. at front, e.g. www.hallifordschool.co.uk for website to load

@g14bowaterp Pull request merged. Thank you!


set_volume doesn't work for more than one added sounds

i think i discovered a bug. the volume field of more than 1 sound is completely ignored.
i went ahead and fixed it, you can check out my fork's volume-fix branch (https://github.com/tshrpl/audio-engine_by_Rodrigodd/tree/volume-fix), there's an example multiple_tracks demonstrating this issue

Fixed by #5


Update upgrades.md

Fixes a typo and adds documentation for running the snap upgrade action on kubernetes-worker units.

This change is

LGTM. I've been testing k8s upgrades with Juju recently and these are indeed the correct steps.


IBM Provider: enable ESO to pull secrets by name

Problem Statement
ESO for IBM Provider requires secret ID to pull secret from Secrets Manager
Related Issue
https://github.com/external-secrets/external-secrets/issues/2210
Proposed Changes
This PR enables ESO to pull IBM Provider secrets by name. For this, the list of secrets matching the name provided by user to a secret ID is fetched and then the relevant details of the secret are retrieved.
The documentation has also been updated accordingly.
Checklist

[x] I have read the contribution guidelines
[x] All commits are signed with git commit --signoff
[x] My changes have reasonable test coverage
[x] All tests pass with make test
[x] I ensured my PR is ready for review with make reviewable

Hi @idan, this PR is to address https://github.com/external-secrets/external-secrets/issues/2210 as discussed earlier.

@moolen PR is approver. Can you help with merging it?

Thanks @nitnis @IdanAdar @moolen for the help.
I have documentation updated in this PR and would like to know if there are additional steps to be taken for it to be reflected in the site https://external-secrets.io/v0.8.1/provider/ibm-secrets-manager/.
As per my understanding, docs are per release number. If so, when is the next release being planned. Thanks again.

Next release comes right after #2325; earöy next week i guess


Merge to live

So SSO GA can be announced tomorrow.

Docs Build status updates of commit bcebf39:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/design/authentication-patterns.md
:white_check_mark:Succeeded
View

docs/develop/authorize-to-microsoft-graph.md
:white_check_mark:Succeeded
View

docs/develop/create-sso-office-add-ins-aspnet.md
:white_check_mark:Succeeded
View

docs/develop/create-sso-office-add-ins-nodejs.md
:white_check_mark:Succeeded
View

docs/develop/overview-authn-authz.md
:white_check_mark:Succeeded
View

docs/develop/sso-in-office-add-ins.md
:white_check_mark:Succeeded
View

docs/develop/troubleshoot-sso-in-office-add-ins.md
:white_check_mark:Succeeded
View

docs/includes/register-sso-add-in-aad-v2-include.md
:white_check_mark:Succeeded
View

docs/includes/sso-tutorial-prereqs.md
:white_check_mark:Succeeded
View

docs/outlook/authenticate-a-user-with-an-sso-token.md
:white_check_mark:Succeeded
View

docs/outlook/authentication.md
:white_check_mark:Succeeded
View

docs/outlook/implement-sso-in-outlook-add-in.md
:white_check_mark:Succeeded
View

docs/quickstarts/sso-quickstart.md
:white_check_mark:Succeeded
View

docs/reference/manifest/webapplicationinfo.md
:white_check_mark:Succeeded
View

docs/reference/requirement-sets/identity-api-requirement-sets.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Add setHeader to ClientRequest

A ClientRequest instance has a setHeader method.

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at<EMAIL_ADDRESS>Thanks!

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Looks like some tests are failing– they don't seem related though. Could you rebase?

Ah, the lines in the .exp file have changed by 1. I'll update


good first issue label

What article on docs.github.com is affected?

What part(s) of the article would you like to see updated?

Additional information

good first issue label


UofT-DSI | applying_statistical_concepts - Assignment 2

What changes are you trying to make?
Implemented a linear regression model to predict miles per gallon (MPG) based on various car features
What did you learn from the changes you have made?
I learned how to effectively apply linear regression using scikit-learn, including how to interpret the coefficients and the importance of data visualization for understanding relationships between variables.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Made additional analysis of the results from the linear regression model, focusing on interpretation and insights gained
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
How were these changes tested?
A reference to a related issue in your repository (if applicable)
Checklist

[ ] I can confirm that my changes are working as intended

A2: Complete
Q2(ii) The plotted line represents the "line of best fit" which is the red line on the plot that minimizes the squared distance between the fitted (plotted) line and the observations (blue dots).  Correlation is a measure of a linear association that ranges between -1 and 1.
Great work!


Fix internal README link

Fixes #237.
Later on, I might go back and create a table of contents for the README. :-)

Thanks. :+1: