Refactor unit tests to use libvmi for resource creation

What this PR does
Before this PR:

Unit tests directly created and modified VM and VMI resources by manipulating their fields.
After this PR:
Unit tests have been refactored to use the libvmi package for creating and modifying VM and VMI resources, promoting readability and standardization.

Partially address: https://github.com/kubevirt/kubevirt/issues/12059
Why we need it and why it was done in this way

Using the libvmi package simplifies the unit tests and makes them more readable.
This approach ensures a standard way of creating VM and VMI resources across tests.

The following tradeoffs were made:

Direct manipulation of resources was replaced with utility functions, which may introduce minor overhead but enhances readability and maintainability.

The following alternatives were considered:

Continuing with direct manipulation of resources in tests, which was deemed less maintainable.
Links to places where the discussion took place: Issue discussion: #12059

Special notes for your reviewer

Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[x] PR: The PR description is expressive enough and will help future contributors
[x] Code: Write code that humans can understand and Keep it simple
[x] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note

Refactored unit tests to use libvmi package for resource creation and modification

@alicefr @jean-edouard @fossedihelm
Could you please give me feedback on this PR when you have some free time?
Thank you!

@aliamerj please squash the merge commit, we need to have a clean git history. Additionally, could you please rewrite your commit message with a short title and then a brief explanation of the change in the commit body?

sorry
i will do it right now

i believe i squashed the merge commit,

Yes , you are right , it gets overwritten i applied your suggestions
Thank you for your review I really appreciate that

@fossedihelm
thank you very much for reviewing my code
and i hope i did not waste your time

When I run make test, it changes the BUILD.bazel file. Is this behavior expected, or should I roll back the BUILD.bazel file to its original state?

When I run make test, it changes the BUILD.bazel file. Is this behavior expected, or should I roll back the BUILD.bazel file to its original state?

This is an expected behavior. You have to run make && make generate and add all the changes to your commit.
Otherwise build will fail. Thank you

I don't know what just happened. I just want to help and complete this task this week. If I made any mistakes or wasted anyone's time, I am really sorry.

I want to keep working on this project and I am planning to complete the task of refector all unit tests to use libvmi package this week
So right now I am working on other files should I push it in the same pull request or open new one
Make new commit or amend them
Or waiting for the approval and merger the current commit and then push new one ??

I want to keep working on this project and I am planning to complete the task of refector all unit tests to use libvmi package this week So right now I am working on other files should I push it in the same pull request or open new one Make new commit or amend them Or waiting for the approval and merger the current commit and then push new one ??

It is better to create separate PRs. This will help reviewers a lot. :) Thank you

I accidentally closed this. I hope you still receive notifications about my pull request.
I fixed all issue with it

@fossedihelm
I have addressed all the feedback.
Thank you so much for consistently reviewing my code and providing valuable feedback. It has been incredibly helpful, and I truly appreciate it.
I hope I have not taken up too much of your time.

@aliamerj Did you change smth to the PR description template? There is the release note label required so I think you changed smth:
Maybe you dropped release-note?
"```release-note
NONE
```"

In any case I think release note is not required here: just put a NONE :)

/area-remove instancetype

Hello @fossedihelm
is there anything i need to change in this PR ??

@fossedihelm
I addressed it
thank you for feedback : )

/test all

/test all

/ok-to-test

There was conflict in this PR and it was labeled as needs-rebase
So I resolved it using GitHub editor and this made 2 comments
Is everything is okay ??

We don't use merge. You need to rebase your branch on main and force push

@fossedihelm
If I rebased the 2 commits into one
Won't this make my commit mix with commit `Merge branch 'main'  into... '
Is this okay or do I need to remove the new commit ?

@aliamerj If you rebase I can provide my final feedback. Thank you

@fossedihelm
I believe i rebased it

dropped it

@aliamerj would be possible to avoid all the additional prints? They are redundant and just make the change larget.
The rest looks good


Observation.effectiveDateTime (Sexual Orientation) is not truncated

Effective DateTime is not listed among the dates that need to be truncated to year on the UDS+ Sexual Orientation Resource IG page (https://fhir.org/guides/hrsa/uds-plus/StructureDefinition-uds-plus-sexual-orientation-observation.html). It looks like the other Observation-based resources do call this out as needing truncation, so I'm guessing this one was just missed.
Inferno does not validate this date is truncated, however the UDS+ testing sandbox does.
Please update the IG to call out that this date needs to be truncated as well.

I also noticed Observation.issued on lab observation and clinical result observation is not called out as needing to be truncated. However, the UDS+ sandbox does not throw any errors when we don't truncate that. So I'm not clear if those should be truncated or it's fine to send the full instant.

The updates being done for 1.0.2 will be pushed to include these date truncation requirements as constraints and will be incorporated into INFERNO also and can be validated before submitting data to HRSA.

As discussed at office hours today, that seems like a reasonable solution


[Windows] Clean Install_user Temp directory

Description
The install_user Temp directory is never cleaned.
This user is used for Visual Studio, Kubernetes tools, and other installation. The Temp directory contains several resources, that are not useful at runtime (installer profile should not be used any time...)
I've checked here, it's appr. 7Gb we can reclaim:
https://github.com/asbiin/windows-test/actions/runs/3419158662/jobs/5692324619
Another option would be deleting the install_user profile entirely, which might have other consequences...
Related issue:
Check list

[ ] Related issue / work item is attached
[ ] Tests are written (if applicable)
[ ] Documentation is updated (if applicable)
[X] Changes are tested and related VM images are successfully generated

/azp run windows2019,windows2022


Unexpected cfg condition value warning: vsda

I encountered a warning related to an unexpected cfg condition value in the file src/tunnels/challenge.rs. The Rust compiler flagged the following:
warning: unexpected `cfg` condition value: `vsda`
 --> src/tunnels/challenge.rs:6:11
  |
6 | #[cfg(not(feature = "vsda"))]
  |           ^^^^^^^^^^^^^^^^
  |
  = note: expected values for `feature` are: `default` and `vscode-encrypt`
  = help: consider adding `vsda` as a feature in `Cargo.toml`
  = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration

Is vsda a needed feature or should it be removed?

how did you encounter this error? any steps to reproduce it?

Steps to Reproduce:
Run the project build (cargo build or cargo run) after cloning the repository.
The compiler issues the above warning.
Platform: Linux/amd64
Github Codespaces


Returning promise.bind() in then() looses "this"

Promise.resolve().then(function() {
  return new Promise(function(resolve) {
    resolve();
  }).bind({ a: 1 });
}).then(function() {
  console.log(this);
});

Outputs window.
However appending a then() makes it work:
Promise.resolve().then(function() {
  return new Promise(function(resolve) {
    resolve();
  }).bind({ a: 1 }).then(function() {});
}).then(function() {
  console.log(this);
});

Interesting, thanks. However I'd argue that the first is correct behaviour and the propagation of the bound value is the bug. bind should only influence linear chains. Consider
Promise.bind(a).then(function() {
    return Promise.bind(b);
}).then(function() {
    console.log(this); // a or b?
})

Especially when some of your handlers are returning promises that you didn't create yourself, you'll want it to be a.

@bergus it should be a. That makes sense for the arguments you've yourself said.

@benjamingr Yes, but the case that "works" for the OP is a bug, isn't it?
var dummy = { a: 1 };
Promise.resolve().then(function() {
  return Promise.bind(dummy).then(function() {});
}).then(function() {
  console.assert(this !== dummy, "callback should not be bound");
});

Especially that it works when .then(function() {}); is commented out makes this suspicious.

Reopening because either the first behaviour is a bug, or the second one is :smile:

@bergus Yes, I agree. But propagating this to the upper promise chain is useful. Consider the following:
function wrappedApi(args) {
  var _resolve;
  var promise = new Promise(function(resolve) {
    _resolve = resolve;
  });

  return prerequisite().then(function() {
    return ajax(args).then(function(val) {
      _resolve(this);
      return val;
    }, catch(function(e) {
      _resolve(this);
      throw e;
    }));
  }).bind(promise);
}

wrappedApi.then(function(result) {
  console.log(this.responseText);
});

If there is a method to propagate this to the upper chain,  then life would be easier.
function wrappedApi(args) {
  return prerequisite().then(function() {
    return ajax(args).propagateContext();
  });
}

The intention has never been so that unknown code could change this for you. In your example it would be less confusing if you did wrappedApi().then(result => console.log(result.responseText))

@petkaantonov The result is not the XHR object. How to resolve the promise with JSON.parse(req.responseText) and bind this  to the XHR object ?@petkaantonov The result is not the XHR object. How to resolve the promise with JSON.parse(req.responseText) and bind this  to the XHR object ?

I don't think you should do that at all. If prerequisite fails, there is no XHR object to bind to… which does not only lead to your confusing wrappedApi code, but also makes its usage complicated.
I'd probably either return [json, XHR] tuples and use spread, or let the user explicitly write out prerequisite and the nested then calls (which can handle different errors cleanly).

@bergus If prerequisite fails, you can handle it inside wrappedApi or in global unhandledrejection. In wrappedApi().catch(), you should check the error code, not handle prerequisite errors and re-throw it.
Returning [result, thisObj] is weird, and thisObj will lost in the following chain... We should hide the complexity in the low level.


feat(tf): Adding Tempo helm chart

Adding Grafana Tempo helm chart
Description
This is to provide tracing capabilities using Grafana Tempo
Checklist

[X] CI tests are passing
[X] README.md has been updated after any changes to variables and outputs. See https://github.com/particuleio/terraform-kubernetes-addons/#doc-generation

Hi @don-yoyowallet , thanks a lot for the PR, could you rebase and squash with only one commit with semver title (like the title of your PR)
Also do you mind signing the DCO ?


CDPS-903: Add sub-domains to reference data codes

Codecov Report
Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.11%. Comparing base (4640a45) to head (5acb733).

Files with missing lines
Patch %
Lines

...ital/hmpps/prisonperson/jpa/ReferenceDataDomain.kt
66.66%
1 Missing :warning:

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #104      +/-   ##
============================================
+ Coverage     78.06%   78.11%   +0.05%
- Complexity      586      588       +2
============================================
  Files            95       96       +1
  Lines          1915     1924       +9
  Branches        175      175
============================================
+ Hits           1495     1503       +8
- Misses          315      316       +1
  Partials        105      105

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[QUESTIONS]

How do I allow users to close the menu by tapping in the white space? Is it already a feature that I can't find?
How do I change the button colour when the menu is open? I want to change the cancel/dismiss button's background from the normal red to gray.
I might just contribute if those two features don't exist yet! :+1:

Use FloatingActionMenu#setClosedOnTouchOutside(true).
Use FloatingActionMenu#setMenuButtonColorNormal(int color) or FloatingActionMenu#setMenuButtonColorNormalResId(int colorResId).

Thanks! That worked perfectly. For the 2nd issue, I wrote the following code for changing the dismiss button colour:
public FloatingActionMenu fabMenu;
fabMenu = null; // get it!

fabMenu.setOnMenuToggleListener(new FloatingActionMenu.OnMenuToggleListener() {
            @Override
            public void onMenuToggle(boolean opened) {
                Log.d("FAB", "Floater is toggling...!");
                if (fabMenu.isOpened()) {
                    fabMenu.setMenuButtonColorNormalResId(R.color.colorWhite);
                    Log.d("FAB", "Setting to white");
                }
                else {
                    fabMenu.setMenuButtonColorNormalResId(R.color.colorRed);
                    Log.d("FAB", "Setting to red");
                }
            }
        });

I couldn't use .setMenuButtonColorNormal() for this, for some reason.


AFK version of this

https://github.com/GSRHackZ/EdgyBot

Code is obfuscated at time of writing, recommended that anyone else that plans to use it takes a good look at it beforehand.
Closing issue.


[HW]

Name: Anjali Vishwakarma
Email<EMAIL_ADDRESS>Linkedin Profile: linkedin.com/in/anjali-vishwakarma-078911162
Attach the homework step I screenshots below:

Attach the homework step II screenshots below:

Hey Anjali Vishwakarma, great job! Congrats! Here is your badge! https://api.badgr.io/public/assertions/kl3pYGw3SomMvdYiLFTjaw


Not all users with gray names get colorized, while "Colorize users without color set (gray names)" is enabled

Describe the bug
Not all users with gray names get colorized, while "Colorize users without color set (gray names)" is enabled. Or am I missing something? Also, is that option new?
Example:

To reproduce
Find someone *shrug* or make an alt account and let it type maybe.
Chatterino version
Chatterino 2.3.0 (commit 58017a754)
Operating system
Windows 10 64-Bit

The user might have their colour manually set to gray
Gray could be one of the colours chosen from as a random pick

Can look into this later today

The user in question is using #4C4A4A which is a gray color.
The point of the setting is to change the color of people who have never chosen a color, which causes them to return no color information, so Chatterino labeled these users as "graynames". People who have chosen gray colors for their names are unaffected.
Also Chatterino uses color normalization so you are likely to see all kinds of gray hex's show up as the same gray visually.

Just as Felanbird explained, the user you've shown is not a greyname - a greyname is a user, who has never set their color - "beent0jailmate" has set it, it's just a coincidence that he set it to grey, thus this is not a Chatterino issue.
And to answer your question:

Also, is that option new?

Yes, this is quite recent. Option has been a part of nightly builds for some time (since 18th Oct 2020) but 2.3.0 is the first stable release with filters support.

ah, I think everyone calling it "gray names" confused me
I forgot that there is an option that allows them to return to no color.


Add more colorschemes, effects, and fonts

Elaborate your issues please??

@adamtherookie Explain your issue please.

@adamtherookie Explain your issue please.

In the website/static/colorschemes and website/static/effects directories respectively there are self-explanatory CSS files for user page colorschemes and link hover effects. It's less of an issue and more of an enhancement because we currently only have 2 effects and about 7 colorschemes.

OK

Reopening, but won't accept any more colorscheme PRs until we have a decent amount of effects and fonts too.

Reopening, but won't accept any more colorscheme PRs until we have a decent amount of effects and fonts too.

ok

@all-contributors please add @Rishav1707 for design and code.


[CS2103-W14-3] Bamboo

Bamboo helps college students manage their personal finances and achieve their financial goals. It is optimized for CLI users so that frequent tasks can be done faster by typing in commands.

Codecov Report

Merging #68 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #68   +/-   ##
=========================================
  Coverage     72.31%   72.31%
  Complexity      400      400
=========================================
  Files            70       70
  Lines          1228     1228
  Branches        124      124
=========================================
  Hits            888      888
  Misses          308      308
  Partials         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6389d85...96d46b7. Read the comment docs.

Codecov Report

Merging #68 into master will increase coverage by 1.37%.
The diff coverage is 87.96%.

@@             Coverage Diff              @@
##             master      #68      +/-   ##
============================================
+ Coverage     72.31%   73.68%   +1.37%
- Complexity      400      433      +33
============================================
  Files            70       76       +6
  Lines          1228     1315      +87
  Branches        124      125       +1
============================================
+ Hits            888      969      +81
- Misses          308      314       +6
  Partials         32       32

Impacted Files
Coverage Δ
Complexity Δ

src/main/java/seedu/address/Main.java
0.00% <ø> (ø)
0.00 <0.00> (ø)

...in/java/seedu/address/commons/core/LogsCenter.java
78.37% <ø> (ø)
10.00 <0.00> (ø)

...main/java/seedu/address/commons/core/Messages.java
0.00% <ø> (ø)
0.00 <0.00> (ø)

.../main/java/seedu/address/commons/core/Version.java
82.50% <ø> (ø)
19.00 <0.00> (ø)

...n/java/seedu/address/commons/core/index/Index.java
100.00% <ø> (ø)
10.00 <0.00> (ø)

...ress/commons/exceptions/IllegalValueException.java
100.00% <ø> (ø)
2.00 <0.00> (ø)

...ava/seedu/address/commons/util/CollectionUtil.java
87.50% <ø> (ø)
5.00 <0.00> (ø)

...main/java/seedu/address/commons/util/FileUtil.java
77.27% <ø> (ø)
9.00 <0.00> (ø)

...main/java/seedu/address/commons/util/JsonUtil.java
94.11% <ø> (ø)
8.00 <0.00> (ø)

...in/java/seedu/address/commons/util/StringUtil.java
94.73% <ø> (ø)
7.00 <0.00> (ø)

... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6389d85...04ef133. Read the comment docs.


feat: add biome

biome has been added to lspconfig and to the mason registry by now, this PR simply adds the missing mapping

@williambotman /fixup


Error: undefined method 'to_unsafe' for Foo (compile-time type is MyModule)

Noticed a regression in nightly Athena CI. Was able to reduce it to the following:
require "spec"

module MyModule; end

class Foo
  include MyModule
end

it do
  a = Foo.new
  a.as(MyModule).should be a.as(MyModule)
end

Seems to be a regression from #14728 in that a in this case is typed as an interface module so doesn't actually respond to #object_id or #to_unsafe. At least that's what I'm getting from the full trace:
In test.cr:11:18

 11 | a.as(MyModule).should be a.as(MyModule)
                     ^-----
Error: instantiating 'MyModule#should(Spec::BeExpectation(MyModule))'

In src/spec/expectations.cr:467:41

 467 | failure_message ||= expectation.failure_message(self)
                                       ^--------------
Error: instantiating 'Spec::BeExpectation(MyModule)#failure_message(Foo)'

In src/spec/expectations.cr:68:55

 68 | "Expected<EMAIL_ADDRESS>(#{identify(@expected_value)})\n     got: #{actual_value.pretty_inspect} (#{identify(actual_value)})"
                                                      ^-------
Error: instantiating 'identify(MyModule)'

In src/spec/expectations.cr:79:15

 79 | value.to_unsafe
            ^--------
Error: undefined method 'to_unsafe' for Foo (compile-time type is MyModule)

Reduced further:
module MyModule; end

class Foo
  include MyModule
end

a = Foo.new.as(MyModule)

if a.responds_to?(:object_id)
else
  a.to_unsafe
end

The only implementation of MyModule is Foo which clearly implements object_id. So the to_unsafe code path should not be reachable.
Before https://github.com/crystal-lang/crystal/pull/14728, the if statement would be replaced by a.object_id. If there was a chance that object_id is not implemented for MyModule, this should fail to compile as well.

Modules are similar to abstract classes in this aspect so I don't think they can be exhausted like that.

Ah, right. That's unfortunate.
The change from 1dac1b0 (#14728) is really just about adding an alternative code path for types that don't implement object_id:
+if value.responds_to?(:object_id)
   "object_id: #{value.object_id}"
+else
+  value.to_unsafe
+end

But now it crashes on types that actually do implement it. 🤷

Trying to refactor the control flow as a workaround causes an ICE:
module MyModule; end

class Foo
  include MyModule
end

a = Foo.new.as(MyModule)

if !a.responds_to?(:object_id) && a.responds_to?(:to_unsafe)
  a.to_unsafe
else
  a.object_id
end # BUG: trying to downcast (Foo | MyModule) (Crystal::MixedUnionType) <- Foo (Crystal::NonGenericClassType) (Exception)


With multiple features selected, indicate which one is mouse-hovered in the sidebar multiselect list

Edit: The remaining task is highlighting the list item when hovering the selected feature on the map, which is discussed and agreed on starting here: https://github.com/openstreetmap/iD/issues/2949#issuecomment-431540750
Original issue:
Identification of items in the multiselect list should be improved:
When the mouse is over an item of the list, selection halos of all other selected elements should be disabled temporarily.
This will likely require similar software infrastructure as #2946 , and is a prerequisite for some further potential enhancements of iD.

I'm not removing the halo from the other selected items.  They are still selected and the user shouldn't forget about that just because they happen to put their mouse over that selection list.
But I agree that:

when mousing over a list item, that feature should get a hover style (maybe it does already)
the hover style should be more distinguishable from the select style with consideration for colorblind users (I think it may only get a slight opacity bump)
breathe behavior needs to be aware of hover style if it is mucking with opacity

I'm not removing the halo from the other selected items.

I believe the user wants to go through the list quite fast searching for an item. Anything delaying the visisual detection of the hovered feature seems to be bad.

They are still selected and the user shouldn't forget about that just because they happen to put their mouse over that selection list.
I would disagree in this specific case. While the mouse is over the buttton the users can't do anything harmful with the mouse. The only hamful thing they can do is using some shortcut keys, but they can't really work on the map for any significant time period without moving the mouse away from the hovered item; therefore they don't really have time to forget.

If the users were able to fill in the inspector with the keybord during hovering the item, I would agree; but the inspector is unavailable while the multiselect list is open.
In addition multiple items being selected is still visible, because the multiselect list is shown.
If you still want to protect something, you can consider disabling shortcut keys which are changing map data according to the hidden selection; but I think the risk is very low anyway.

In adition to the hover function, which has been discussed above, a reserse hover function would be useful. If the mouse is over one or more selected items on the map, the respective item of the multiselect list should be highlighted

@quincylvania, @bhousel,
How do you think about my last comment here?
Everything else was done in #5402, thanks @quincylvania.

@slhh Reverse hover-highlighting does sound useful! I'd recommend creating a new issue for it and closing this issue since the original task was completed. I think it's more likely that someone will decide to work on an issue if it is clearly defined with a small scope (though this isn't always possible.)

If the mouse is over one or more selected items on the map, the respective item of the multiselect list should be highlighted. The list should be automatically scrolled to to show this item if required.

Sounds ok to me 👍

I'd recommend creating a new issue for it and closing this issue since the original task was completed.

@bhousel, feel free to request this, but I think we don't need to do so in this special case. The title does still fit and I have edited the oriigal post to make clear what is remaining.
Otherwise, please update the label. We seem to have consent, and the considering label might prevent contributions.

oh yeah, we don't really need a new issue.  I'll just retitle it..

Just to restate the issue with a gif - it's this:
We currently support hovering on list items to highlight map features.  We should also support hovering on map items to highlight list features.

Hi I'm a new contributed and would like to look at this. Please could someone give me a hint as to where the code for this is, its a new and large codebase so a few comments from someone will save me a few hours of digging


E3002 false positives with intrinsics returning complex types

CloudFormation Lint Version
0.72.5
What operating system are you using?
Linux (Fedora)
Describe the bug
When using intrinsic functions to retrieve complex (ie structured) data from custom resources for other resources E3002 incorrectly marks the intrinsic as invalid properties of the resource.
For example, given a custom resource which returns an AWS::Lambda::Function Code object:
"Code": {
   "S3Bucket": "<name>",
   "S3Key": "<object-key>",
   "S3ObjectVersion": "<object-version>"
}

Then referencing this as the Code: property of another AWS::Lambda::Function, eg
Code: !GetAtt CustomResource.Output.Code
cfn-lint raises an E3002 of the form:
E3002 Invalid Property Resources/Helper/Properties/Code/Fn::GetAtt
This can be suppressed in the resource's Metadata, but only by suppressing all E3002 errors for that resource, where other instances of the error could be legitimate.    While I imagine that the vast majority of values returned from custom resources are scalars, they are no required to be, and therefore can provide structure as well as values.  Certainly at least in the specific case described here the various Code. attributes are all correctly referenced when actually running the template.
Expected behavior
E3002 Should not be raised when an intrinsic is used to return information for a valid partial attribute path.
Since scalars are the most common return values it may be a reasonable compromise to raise a context specific W or I code
At the very least even if metadata annotation is required to suppress this case it should be a unique code, which can be supressed without also supressing common errors such as attribute name typos
Reproduction template
Parameters:
    RoleArn:
        Type: String
    FunctionArn:
        Type: String

Resources:

    GetCodeForLatestS3Object:
        Type: Custom::LambdaSource
        Properties:
            ServiceToken: !Ref FunctionArn
            S3Url: "s3://some-bucket/lambdazips/helper.zip"

    Helper:
        Type: 'AWS::Lambda::Function'
        Properties:
            Handler: 'helper.lambda_handler'
            Role: !Ref RoleArn
            Code: !GetAtt GetCodeForLatestS3Object.Code

Yea I think we are handling custom resources for simple types but not for complex types.  Let me double check it and correct it.


Implement a Maven extension

Task Description
The extension should be a separate module and contain a class that has a @PostConstruct method which sets:
org.carlspring.testing.idempotence.basedir=target/test-resources

Currently, this is hard-coded in IdempotenceProperties to default to target/test-resources, if no value is set for theorg.carlspring.testing.idempotence.basedir System property.
Open Questions
Notes
Task List
The following tasks will need to be carried out:

[x] Investigate the issue.
[x] Provide a solution.
[x] Test the fix.
[x] Update the documentation.

Useful Commands
Incurred Costs
Task Relationships
This task:

Is a sub-task of:
Depends on:
Is a follow-up of:
Relates to:

#10

Resources
Useful Links
Points of Contact

@carlspring

Implemented.


Data Quality: Headways

When viewing the data for the commuter rail in the dashboard, headways are often missing points on the graph, yet, they read out realistic headway numbers on the points that do exist

Some charts look very strange

Alright this was actually just a bug in the logic on the dashboard. Data looks okay now


Polymer element

Could you create polymer element?

sorry,I don't really know what you mean.

where can see javaScript API about google webVR ?thanks for answer me!

doc

https://www.polymer-project.org/1.0/docs/start/reusableelements.html

Like this https://elements.polymer-project.org/elements/google-youtube

I did this a few days ago when I was trying to learn Polymer. Right now it just using the iframe BTS, but I am looking into getting rid of that (not a trivial task).
https://github.com/adipirro/vrview-element

@adipirro That's more of a well rounded element than the one I created for my specific needs: https://github.com/gdgfresno/valleydevfest/blob/develop/src/elements/vr-view.html (usage: https://github.com/gdgfresno/valleydevfest/blob/3cdd8024108913a65236e928bdaf72798c8a8a27/src/elements/map-block.html#L140). My problem is that when I deployed that to FireBase it was giving an error, while I was hosting it with gh-pages + CloudFlare (for https for my custom domain) it was working. I ended up dedicating a separate site for my 360 views.

Huh...any chance you could post the error you were getting or give a link to the version deployed on firebase?

I'm back on FireBase now (after splitting the 360 part out to a separate website) so I don't have the faulty version active any more. The error message was something about cannot load. I cannot find a screenshot now. The VR view window is black and there's a white error message on it. Similar when the URL just simply wrong.
Lately on FF I captured these errors: Failed to load ‘https://valleydevfest-620d6.firebaseapp.com/vrview.html?image=/images/backgrounds/location_hall.jpg&is_stereo=false’. A ServiceWorker passed a redirected Response to FetchEvent.respondWith() while RedirectMode is not ‘follow’.. There can be multiple problems though and this would be just one of them. There maybe something with the PWA itself, in case of a PWA the service worker is there, and it may interfere with something?

I was looking into creating a Polymer element for this too without the iframe. What makes this difficult at the moment, is everything is bundled with Browserify including the main.js, which deals with the initialisation of the PhotosphereRenderer, getting the asset paths etc.
Ideally, there should be a build task which can expose the PhotosphereRenderer at runtime, so we can create an instance of it with our own parameters. That would be the first step at least ;)

The error was related to using custom domain along with Firebase + VR View. As soon as I deployed a PWA instance without a custom domain, I didn't run into the error message

Polymer element is out of scope. Would be great to see a third party implementation though!


Responsive Sign-In Form with appealing styling.

Issue Type:

[ ] Bug Report
[X] Feature Request
[ ] Documentaion

Describe the bug
I have noticed that there is no Sign-In form template available on your website with good modern styling.
Possible solution
I want to add a CSS template for a modern Sign-In Form. I am a GSSOC'22 participant, kindly assign this issue to me. Thank you!
Screenshots
No screenshots are available.

Sign In form template already exists.

Okay, no issues.


fix: support short_link_v2

Description
close #6933
Checklist

[X] I read the extension guidelines
[X] I read the documentation about publishing
[X] I ran npm run build and tested this distribution build in Raycast
[X] I checked that files in the assets folder are used by the extension itself
[X] I checked that assets used by the README are placed outside of the metadata folder

@pernielsentikaer Thank you. ❤


Correct spelling of function name "broadcat!"

Replace "broadcat!" with "broadcast!".

Thank you!


InaccessibleObjectException when calling distinct on a stream in OGNL

MyBatis version
3.5.9
Database vendor and version
MySQL 5.7
Test case or example project
Example project, linked to test case
Steps to reproduce

Checkout the project listed above
Make sure you are running Java 17+
Make sure you have docker installed (I used test containers to make the example cleaner)
In the project, run mvn clean install (If you don't use test containers a lot, this might take a minute to pull everything)

Expected result
Maven will compile the project, spin up the test db container, pass all tests, and build successfully.
Actual result
The build will fail because of a test failure. The test fails with the following error:
### Error querying database.  Cause: java.lang.reflect.InaccessibleObjectException: Unable to make public final java.util.stream.Stream java.util.stream.ReferencePipeline.distinct() accessible: module java.base does not "opens java.util.stream" to unnamed module @7f1dd5e7
### Cause: java.lang.reflect.InaccessibleObjectException: Unable to make public final java.util.stream.Stream java.util.stream.ReferencePipeline.distinct() accessible: module java.base does not "opens java.util.stream" to unnamed module @7f1dd5e7
        at com.sikina.mybatisproblem.ExampleMapperIntegrationTest.shouldGetThings(ExampleMapperIntegrationTest.java:43)

Hello @Luke-Sikina ,
Thank you for the report and the complete repro!
This problem has been fixed in 3.5.10 which is currently available in the snapshot repo.
We plan to release 3.5.10 soon, so it would be great if you could try the snapshot and see if there is any other issue.
Related issues:

#2383
#2392
https://github.com/jkuhnert/ognl/pull/144

@harawata Thank you for the quick response! I just tried using 3.5.10-SNAPSHOT and it worked perfectly. I even added some other logic that uses a more complex collector that I was concerned about, and it still worked perfectly. I've pushed the fixed unit test to a new branch in my repro repo, in case you need to refer to it: https://github.com/Luke-Sikina/mybatisproblem/tree/snapshot-fix
I'm not sure if you close issues when you cut the relevant release, or when you commit the fix, so I'm going to let you close this at your discretion.
Thank you for solving this; I'm looking forward to 3.5.10!

Thanks for the swift feedback!
And the update is reassuring. :D
Closing as a duplicate of #2392


Need examples for StorySticker

Hello everyone,
Thanks for your wonderful effort in providing us an easy to use instagram api.
I'm finding some hardships when trying to post stories with a link sticker. Using the StoryLink class correctly makes the link available (when using height and width big enough to cover most of the story) but no sticker is being visualized.
I tried to apply other sticker with the StorySticker class, but nothing seems to work.
Looking in the documentation, I can't find a working example of StorySticker usage and the old links to using "Charles" are all expired, so I'm not sure what I should be doing. Would you please submit a working example so I can try and learn?
Thanks a lot

Hello @itsManeka ,
Thanks for spending your time answering me! I understand that instagrapi doesn't have sticker images, what I was wondering about was how to process Instagram images so I can show them using instagrapi, since the guide doesn't have any examples and I have no idea on how to do it since I 'm new to this. Would it be possible to have this added to the guide? Or having some code snippet that lets me understand how to do that?
Thanks a lot

@itsManeka thanks for the response, now I understand! What I'm wondering about now (maybe I'm missing something) is what are the StorySticker objects supposed to do since the sticker should only be merged into the base image. Thanks anyway for the explaination!

I believe that stickers should have different classes due to their different functionalities (reactions, links, locations, etc.)
Most likely there are also properties with different names on the endpoints and, therefore, they should be separated.
If there are no more questions left, I believe the issue can be closed.

Thanks! Yes, I'll close the issue


Provide meaningful default configuration for the inspectIT sample agent

This will allow anyone to the start the sample without having to mount the configuration volume. If someone wants to change the configuration, he can mount the volume. In addition we should provide the default configuration in this repository, so that one can download this configuration and use it in the mapping.
-- stupid question, mario did already take care of this.

So now it's open again. We currently automatically integrate the default sample configuration of an inspectIT agent. I think we need to integrate the configuration for the dvdstore here by default.


reinvent_shared.yml: ResolvePackageNotFound: intel-openmp=2019.5

The installation instructions currently fail at $ conda env create -n reinvent -f reinvent_shared.yml with the following output:
Collecting package metadata (repodata.json): done
Solving environment: failed

ResolvePackageNotFound:
  - intel-openmp=2019.5

Indeed, when I search the channels listed in the yml file, there are no 2019.5 variants:
$ conda search -c rdkit -c pytorch -c openeye -c omnia -c anaconda -c conda-forge intel-openmp
Loading channels: done
# Name                       Version           Build  Channel
intel-openmp                2017.0.4      hf7c01fb_0  anaconda
intel-openmp                2017.0.4      hf7c01fb_0  pkgs/main
intel-openmp                2018.0.0               8  anaconda
intel-openmp                2018.0.0               8  pkgs/main
intel-openmp                2018.0.0      h15fc484_7  anaconda
intel-openmp                2018.0.0      h15fc484_7  pkgs/main
intel-openmp                2018.0.0      hc7b2577_8  anaconda
intel-openmp                2018.0.0      hc7b2577_8  pkgs/main
intel-openmp                2018.0.3               0  anaconda
intel-openmp                2018.0.3               0  pkgs/main
intel-openmp                  2019.0             117  anaconda
intel-openmp                  2019.0             117  pkgs/main
intel-openmp                  2019.0             118  anaconda
intel-openmp                  2019.0             118  pkgs/main
intel-openmp                  2019.1             144  anaconda
intel-openmp                  2019.1             144  pkgs/main
intel-openmp                  2019.3             199  anaconda
intel-openmp                  2019.3             199  pkgs/main
intel-openmp                  2019.4             243  anaconda
intel-openmp                  2019.4             243  pkgs/main
intel-openmp                  2020.0             166  anaconda
intel-openmp                  2020.0             166  pkgs/main
intel-openmp                  2020.1             217  anaconda
intel-openmp                  2020.1             217  pkgs/main
intel-openmp                  2020.2             254  anaconda
intel-openmp                  2020.2             254  pkgs/main

Does the yml file need updating, or have I missed a step somewhere? Can I substitute 2019.5 for 2019.4, or would one of the 2020 versions be a better option (i.e. backwards compatibility)?
Cheers

Hej, thanks for pointing this out!
Indeed, we had that issue before but forgot to remove the version requirement in the public repository. Try the newest commit, it should work now (and default to some 2020 version).
Please let me know, whether this solved the problem.

Thanks for the quick response, and sorry for my slow follow up.
That commit fixed it for me, so I'll close this issue. Thanks again!


Update ToolType input schema

See related slack thread (private).
The goal of this PR is to improve the ToolType specs in openapi.json. At the moment, the ToolType::NoTool and ToolType::OneOf are wrongly typed as
{
  "type": "object",
  "default": null,
  "nullable": true
},

instead of a string enum with values none/auto.
For what I understood, #[serde(untagged)] doesn't play well when the possible values are either an object or a string enum value. At least I did not managed to get it right.
What I did in this PR is:

remove #[serde(untagged)]
rename NoTool to none
rename OneOf to auto
remove the "any string is supported" (FunctionName(String)) from the ToolType enum. I think this is here for backward compatibility but it is not a proper argument in the OpenAI reference
still accept "any string" and parse it into a Function object as if it was provided as a function object. This means we still support "any string" but won't have it in the official specs.
added some docs (examples and descriptions)

This PR seems to be compiling and generating the correct openapi specs but I haven't tested it properly.
Also related:
Based on OpenAI reference, possible values are none (i.e. don't use tools), auto (i.e. you can use a tool), required (i.e. you must use a tool) and {"type": "function", "function": {"name": "my_function"}} (i.e. you must use this specific tool).

we support none => OK
we support auto using OneOf => I'm actually not sure if the OneOf logic a "can use" or "must use"
we don't support required => out of scope for this PR
when passing an object, we don't require and we don't handle "type": "function" => out of scope for this PR

closing this PR as these changes were included in this PR https://github.com/huggingface/text-generation-inference/pull/2601. Thank you @Wauplin!


Rewrite in ES6 using webpack

This branch converts the codebase from CoffeeScript to ES6, and replaces previous gulp tasks with webpack only. It still needs a lot of attention before it can be considered stable and merged in.
Todo

[ ] Address all failing specs (17 at time of writing).

[ ] Test throughly for regressions. This may require a bit of backtracking and documenting features that have snuck in without being fully documented.

[ ] Write unit tests around any undocumented behaviour that was discovered during above testing.

[ ] Add multiple compile targets with webpack like we had before:

[ ] rivets.bundled.js (sightglass included, unminified)
[ ] rivets.bundled.min.js (sightglass included, minified)
[ ] rivets.js (standalone, unminified)
[ ] rivets.min.js (standalone, minified)

I'm trying to address the Rivets.TextTemplateParser is undefined errors. It seems that TextTemplateParser.parse() has been replaced by parseTemplate(), but this is now exposed as an ES6 module rather than a property on the global rivets._ object. Is that correct? This means it can't be tested in the same way – we either need to import it into the unit test, which means having some sort of require mechanism in the mocha test runner html page, or parse the template using rivets as a public user would, but I'm not sure how to go about that. Hope I'm making sense...

After spending some more time with the code, I think we have 2 options: add an extra property to the rivets factory in export.js that can expose private functions for testing (something like rivets._ = {parseTemplate}), or use babel in the test runner so we can import private functions for testing. My inclination is for the latter. @mikeric , @Duder-onomy , thoughts?

Having a hard time researching how to elegantly integrate a babel compiler as part of the mocha-phantomjs test script. This would be a lot easier with Karma, I feel. Reckon that's an option? Or do you know a better way to use es6 in our tests with mocha?

@Leeds-eBooks sorry to barge in. I use karma with mocha for ES6/babel in projects at work.  For my side projects I use a module loader I created that you can hook babel directly into, and run in the browser/phantomjs, which runs mocha directly; no Karma.
Karma is a good alternative.

@MiguelCastillo Your module loader sounds intriguing. Is it public?

Yeah, it is public. https://github.com/MiguelCastillo/bit-imports.
The example is all written in ES2015 and transpiled in the browser.  I can perhaps create a quick scaffold for bit-imports/babel/mocha, if you are interested.

Here are the unit tests using with bit-imports/mocha that run in the browser/phantomjs... https://github.com/MiguelCastillo/bit-imports/tree/master/test
https://github.com/MiguelCastillo/bit-loader/tree/master/test
If you want to see a unit test setup with multiple module types running, check this one out.
https://github.com/MiguelCastillo/bit-sandbox

@MiguelCastillo so how would we go about setting this up for the rivets tests? If I understand your docs correctly, we load bit-imports in a regular script tag in the runner.html page, then System.import() our test js files and the rivets es6 modules we want to test directly?

@Leeds-eBooks Yup, broad strokes that's correct.  Load bit-imports and System.import specrunner.  There are a few steps in between that I am writing a recipe for. I will send out a link a little later when it's ready.
In the meantime, if you want to see a setup that's running this unit test setup, take a look here. No instruction on what the moving pieces are, and that's what I am writing as a recipe for you today.
If I have time today, I will fork rivets and do a setup in for this branch.

index.html has mocha loaded via script tag.
polyfill promises if needed.
load bit imports via script tag.
load a config file script to setup bit-imports.
setup mocha.
System.import unit tests.

Hi everyone, I've just pushed a commit that gets the parseTemplate module function into the global scope so it can be tested. It's not the prettiest solution but I haven't had time to get my head around the bit-imports concept (sorry @MiguelCastillo :/ ) and as it's only a problem with one small part of the tests I don't think it's something any of us should spend a lot of time on. I am using an npm pretest script to call babel (as a global npm package) on the src/parsers.js file and put the transpiled output in spec/lib/parsers.js, it works, the tests pass. If anyone would like to make this more elegant please do!
There are now just 3 tests failing. They have me stumped, for now.

I have added some logs to my local repo to try and work out what's going with the rv-each binder. This is what I'm getting:
it("lets you push an item", function() {
  var view = rivets.bind(fragment, model);
  var originalLength = model.items.length;

  // one child for each element in the model plus 1 for the comment placeholder
  Should(fragment.childNodes.length).be.exactly(model.items.length + 1);

  console.log(model.items.length); // LOGS: 3
  console.log(model.items.map(function(x) {return typeof x + " " + x;})); // LOGS: ["object [object Object]","object [object Object]","object [object Object]"]
  model.items.push({"val": 3});
  console.log(model.items.map(function(x) {return typeof x + " " + x;})); // LOGS: ["object [object Object]","object [object Object]","object [object Object]","object [object Object],[object Object],[object Object],,push","string push"]
  console.log(model.items.length); // LOGS: 5

  Should(model.items.length).be.exactly(originalLength + 1);
  Should(fragment.childNodes.length).be.exactly(model.items.length + 1);
});

So after push({"val": 3}), the array gains 2 new elements – an array which seems to be a copy of the parent array itself, and a string "push". @mikeric Can you shed any light on this? I've tried with no success to find the source of this behaviour. Thanks!

If you feel that this branch is ready to merge, I can install this branch in a big project to check if there are any breaking changes.

@jhnns Thanks man, but until all tests are passed, I don't think it's worth it, as they are testing for basic functionality and failing tests to me mean a broken rivets. Do you have any insight into this specific problem? There are only 3 tests that we still failing and I'm banging my head against a brick wall trying to fix them... There's something weird going on with the each binder and mutation of the input array but I can't trace the source of the issue.

@Leeds-eBooks I'm suspecting line 56 in adapter.js is misbehaving. This is the line in charge of pushing the elements to the array. Since the wrapping function is an arrow function you can not use the arguments object there. So probably that's your culprit.

@ydaniv Ah thanks man, but I spotted that one and it doesn't fix the problem. Weird that it wasn't causing any failing tests. Anyway I'll push that fix today. But still completely stuck on this!

@Duder-onomy I'm still getting 3 failing tests, under Rivets.binders each-* and under Functional input.

@Duder-onomy So what next?

@Leeds-eBooks Now we crack open the champaign and retire.
Hah, sorta kidding.
Before merge:

I think we should really stress test this thing. I have a ton of tests wrapped around Rivets for our SPA framework, some of which I am going to copy over into the rivets test suite. Memory leaks should also be considered. There are many memory leak issues opened in the past that we can go through and ensure are still patched.
There are a ton of issues still open. I wanted to go through and do the work of documenting/merging and including these issues as tests into the new re-write.
I would also like to AB test it with the original for speed and other pain points.
The test I fixed was kind of a hack I think (now that I have slept on it) I think the publish method on the binding should always have the scope of the binding. Meaning that I would like to move its scope binding upstream to the bindings initialization. This way people that implement binders that publish will not need to worry about the publish method having the proper scope. Also, using .bind() is slow, and creates a new, bound copy of the method. I was going to look through the source more to find some inspiration, but my inclination is to use function closure to solve scope problems instead of calling .bind everywhere.

Last thing before we merge:

Ask the community to pull this branch into their repo and try it out. (we should also pull it into our own)

Post Merge :

I would like to make the documentation incredibly pimp, think, inline editors demonstrating binders, formatters, components etc.

Anyhow. I have made a deal with my girlfriend that I will keep holy the Sabbath and work on Rivets 8hrs every Sunday. Otherwise I will find some time during the week to slam out some small issues.  I am seriously looking forward to having feature parity with the original.
What say you?

@Duder-onomy Haha I might just do that anyway, without the retiring bit.
I think you might have to lead on the overview-based tasks, like deciding how best to stress-test it, the implementations of .bind(), etc., at least at first. My knowledge of the codebase is bitty and I have far, far less confidence with the overall structure than you do, for now. I think what I might do over the rest of this week is go through the issues and see if there are any that can be closed, easily applied to this branch or discussed further. Or do you think that's jumping the gun?

@Leeds-eBooks That sounds great. I will jump in if I see something. I also do not mind taking the lead on the stress test / including additional tests for memory leak etc.
I will touch base when I have begun that work.

I'd be happy to review the code before merge. Anyway, thank you guys for investing your time! :+1:

This looks fantastic! Looking forward to using it. Let me know if I can help getting it ready / finding edge cases!

Hey all, I have just written a new binder for one of my own projects that interfaces with Set(), I called it set-each-* so you use it like rv-set-each-item="theSet". Exactly the same behaviour as the each-* binder, but required a basic fork of the each-* binder routine and some simple (side-effect-free) changes to the standard '.' adapter.
Do you think this is something that should be included in the rewrite, considering that we are doing it in ES6 anyway? If the general consensus is yes, I will include it, along with unit tests, in a new branch off es6 and we can merge it back in if it works after rigorous testing.

@Duder-onomy any thoughts on this?

What is the status of this branch? It's been hanging around for months now and it would be great to get it moving again. What's holding us back and what needs to be done next? And does anyone have any thoughts on the Set binder I mentioned above?

I've been doing some work in this branch. After some struggle to get working i managed to setup a environment to compile it with the current dependencies (babel 4 etc).
But since the dependencies are somewhat outdated i tried to update them.
In branch https://github.com/mikeric/rivets/compare/es6...blikblum:update-dependencies i got to work with babel 6 and latest dependencies.
To do it i had to change some variable declarations and class constructors to match es6 rules which babel 6 enforces (see http://stackoverflow.com/questions/31067368/javascript-es6-class-extend-without-super)
So far, so good, but unfortunately the generated bundled file is somewhat bigger (62kb) than babel 4 (58kb) and coffee (52kb). Needs to compare the minified to get a definitive conclusion.
In the next days, i will try to add the minified builds and setup some performance tests. Later see the memory leaks, specially the one in todomvc
So, i think this branch still need some more work before being marked as ready to ship

PR #541 adds standalone and minified builds
As a side note, the minified size of es6 build is slight smaller than coffee one

I started to look into performance of es6 build.
First try at http://codepen.io/blikblum/pen/mVBvpv
es6 one seems a bit slower (see console)
A jsperf setup would allow to confirm this finding

http://jsperf.com/rivetsjs-builds-performance
ES6 build is a bit slower than coffee. VueJs outperforms both

@blikblum getting this:
Uncaught TypeError: Cannot read property 'name' of undefined.

message: Uncaught TypeError: Cannot read property 'name' of undefined
fileName: http://jsperf.com/benchmark-47.js
lineNumber: 21

Seems a issue with the jsperf code, not affecting the test itself. When an error occurs inside the tests it's marked as error in the Ops/sec column.
In my side sometimes i also get:
TypeError: P(...)[0] is undefined.
It's not specific to this test. This also has an error: http://jsperf.com/conditional-function-call

Ah ok. In any case this is interesting! Any thoughts as to where the slow down in the es6 branch might stem from?

@Leeds-eBooks yes.
The garbage collector is taking much more time in es6. traverse and parser functions also are slower. The basic difference is that coffee uses for and for in loops while es6 uses forEach and Object.keys together with temporary arrays created on the fly.
I started to change es6 to get in line with coffee (see https://github.com/blikblum/rivets/tree/use-for-loop-in-view-traverse ) but, given the mem leaks of both versions, which can affect performance, i will try to plug them first.
In the mean time, can you look at #541 and #544 ? It updates the configuration and facilitate the work of testing the versions.

I started reports for #432 #551 and #478 on this branch.
Out of the box it doesn't pass the tests due to missing configuration for babel 6. It needs the fixes @blikblum made in PR. In the meantime i patched locally.
CC : @Leeds-eBooks

@blikblum i think you're right about rivets performances. forEach is largely less performant (by 10 times) than a good old for (var i ; i < length ; i++). See here https://jsperf.com/for-vs-foreach/75


Require Hound only in Test Env

Hound is only required for Integration Tests. It should not be required for Prod.

thanks


Error when collapsing on an emoji

When the last character of the line that is collapsed is an emoji, an error is thrown :
════════ Exception caught by painting library ══════════════════════════════════
The following ArgumentError was thrown while building a TextSpan:
Invalid argument(s): string is not well-formed UTF-16

This error occurs only when a preDataText param is specified

I guess this is the problem
https://github.com/dart-lang/sdk/issues/35798
widget.data.substring(0, endIndex) => String.fromCharCodes(widget.data.runes, 0, endIndex)

Can you please upload minimum reproducible code?


feat: Explicit loading of local schema

Changes
The following only apply to connectors that use static schema.json when serving ListObjectMetadata:

ObjectName must be passed to Read method.
Read will error out common.ErrOperationNotSupportedForObject for ObjectNames that are not found under schemas.json.
Parsing schema.json is done on package import. JSON parsing error is ignored, we assume the file is valid. If at least one test exists this will be caught.
Added mapping ObjectName to Response Field for ZendeskSupport and Intercom.
Fix ZendeskSupport to locate correct JSON path even for special objects by relying on ObjectNameToResponseField map described in the step 4. Note: Intercom returns special type field that tells where the array is located so it already covers all ObjectName space.
Log error when any OpenAPI schema cannot be processed. If we update OpenAPI file we will be notified about unexpected changes.

PS
Let me know if this PR needs splitting.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#1001
#1000  👈
#999
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Cobalt0s and the rest of your teammates on  Graphite

Changes
The following only apply to connectors that use static schema.json when serving ListObjectMetadata:

ObjectName must be passed to Read method.
Read will error out common.ErrOperationNotSupportedForObject for ObjectNames that are not found under schemas.json.
Parsing schema.json is done on package import. JSON parsing error is ignored, we assume the file is valid. If at least one test exists this will be caught.
Added mapping ObjectName to Response Field for ZendeskSupport and Intercom.
Fix ZendeskSupport to locate correct JSON path even for special objects by relying on ObjectNameToResponseField map described in the step 4. Note: Intercom returns special type field that tells where the array is located so it already covers all ObjectName space.
Log error when any OpenAPI schema cannot be processed. If we update OpenAPI file we will be notified about unexpected changes.

PS
Let me know if this PR needs splitting.

Please split this up and request a review

Changes
The following only apply to connectors that use static schema.json when serving ListObjectMetadata:

ObjectName must be passed to Read method.
Read will error out common.ErrOperationNotSupportedForObject for ObjectNames that are not found under schemas.json.
Parsing schema.json is done on package import. JSON parsing error is ignored, we assume the file is valid. If at least one test exists this will be caught.
Added mapping ObjectName to Response Field for ZendeskSupport and Intercom.
Fix ZendeskSupport to locate correct JSON path even for special objects by relying on ObjectNameToResponseField map described in the step 4. Note: Intercom returns special type field that tells where the array is located so it already covers all ObjectName space.
Log error when any OpenAPI schema cannot be processed. If we update OpenAPI file we will be notified about unexpected changes.

PS
Let me know if this PR needs splitting.

Please split this up and request a review

Ok, lets start with parameter validation. I started with enforcing ObjectName to be required for Read method.
Generalized it more. https://github.com/amp-labs/connectors/pull/1013 The PR is bigger but it addresses 1 issue at the large scale. Lauren asked a while ago about ObjectName being required.
I will be splitting this PR bit by bit by concept (this helped me generalize the problem).

@RajatPawar I repurpopsed this PR and it was split into chunks. Check graphite for the full tree structure. It is ready for review.


Cannot use it behind company proxy

Hello, I can use the tool normally when I am out of VPN, but in my company, it gets blocked as requires a proxy. The proxy settings here are set up in windows, but seems it is not considering them. There is some parameter to pass the proxy or any hint on how to use it behind a proxy?

Hi, We had a similar issue with proxy settings blocking this. The workaround was to hardcode in the company proxy settings,
Replace line “const vstsWebApi = new vsts.WebApi(accountUrl, authHandler);”  in “node_modules\process-migrator\build\NodeJs\nodejs\NodeJsUtilities.js” as per the below.
const options = {
proxy: {

    proxyUrl: "[http://%3cPROXY%20URL%3e:%3cPROXY%20PORT%3e]http://<PROXY URL>:<PROXY PORT>",  //needs to be prefixed with http(s)

    proxyUsername: "<PROXY USERNAME>",

    proxyPassword: "<PROXY PASSWORD>"

},

ignoreSslError: true

};
const vstsWebApi = new vsts.WebApi(accountUrl, authHandler, options);

We will release an update addressing previous problems. For new issues, create a ticket, and we'll resolve it promptly. Thank you for you.


multicluster: Defaulting demo to Tresor certificate issuer

This PR removes optionality of running OSM Multicluster w/ other cert issues.
This PR hard-codes tresor as the only Multicluster demo cert issuer.
The goal is to simplify.
Signed-off-by: Delyan Raychev<EMAIL_ADDRESS>

Codecov Report

Merging #3767 (ae1e5a9) into main (32b9a78) will decrease coverage by 0.22%.
The diff coverage is 29.62%.

@@            Coverage Diff             @@
##             main    #3767      +/-   ##
==========================================
- Coverage   69.98%   69.76%   -0.23%
==========================================
  Files         185      185
  Lines       10366    10406      +40
==========================================
+ Hits         7255     7260       +5
- Misses       3062     3097      +35
  Partials       49       49

Flag
Coverage Δ

unittests
69.76% <29.62%> (-0.23%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/envoy/bootstrap/config.go
93.95% <0.00%> (-1.94%)
:arrow_down:

pkg/errcode/errcode.go
100.00% <ø> (ø)

pkg/envoy/cds/cluster.go
94.04% <33.33%> (-1.11%)
:arrow_down:

pkg/envoy/cds/response.go
80.00% <40.00%> (-4.13%)
:arrow_down:

pkg/envoy/lds/ingress.go
79.03% <0.00%> (-5.46%)
:arrow_down:

pkg/envoy/lds/tracing.go
84.21% <0.00%> (-4.68%)
:arrow_down:

pkg/envoy/lds/rbac.go
81.03% <0.00%> (-4.43%)
:arrow_down:

pkg/envoy/lds/auth.go
93.33% <0.00%> (-3.22%)
:arrow_down:

pkg/envoy/lds/inmesh.go
77.77% <0.00%> (-2.61%)
:arrow_down:

pkg/envoy/lds/egress.go
82.35% <0.00%> (-2.50%)
:arrow_down:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ef0c47...ae1e5a9. Read the comment docs.


OpenBSD is missing SI_ASYNCIO and SI_MESGQ

Check if macros SI_ASYNCIO and SI_MESGQ are defined as macros.  This
allows to run tests on OpenBSD 6.5, where the macros are missing.
This is identical to patch-boost_test_impl_execution_monitor_ipp in
OpenBSD Ports, except that I added a comment.

This change assumes that system headers always define SI_ASYNCIO and SI_MESGQ as macros. This seems to be true in at least FreeBSD, glibc, illumos, and musl.

Thanks for the report, this is currently building in branch topic/PR-231-defines-missing-openbsd

Merged to next.

In master, closing


ENG-578: IT (Part 1) - Manifest (#665)

Merges the feature branch into main. After this I'll rebase the followups https://github.com/consensus-shipyard/ipc/pull/671, https://github.com/consensus-shipyard/ipc/pull/683 and https://github.com/consensus-shipyard/ipc/pull/700

@aakoshh Clippy looks grumpy.


BulletSharp, OpenTK & Scale

Hello,
Whenever I use this method:
public Matrix4 GetTransformation(bool inverted = true)
        {
            if(_transformationDirty && !OverrideMatrix)
            {
                Matrix4 rotation = Matrix4.CreateRotationX(_rotation.X) * Matrix4.CreateRotationY(_rotation.Y) * Matrix4.CreateRotationZ(_rotation.Z);
                Matrix4 scale = Matrix4.CreateScale(Scale);
                Matrix4 translation;

                if (inverted)
                    translation = Matrix4.CreateTranslation(new Vector3(-1.0f, 1.0f, -1.0f) * _position);
                else
                {
                    translation = Matrix4.CreateTranslation(_position);
                }

                _transformationMatrix = scale * rotation * translation;
                _transformationDirty = false;
            }

            return _transformationMatrix;
        }

and replace Matrix4.CreateScale with Matrix4.Identity, my collisions work, but when I leave it that way, they won't work at all. I tested this with a BoxShape (50, 0.1, 50) and falling Cubes (BoxShapes).
When I put these lines into the demo project:

            Matrix4 rotation = Matrix4.CreateRotationX(0f) * Matrix4.CreateRotationY(0f) * Matrix4.CreateRotationZ(0f);
            Matrix4 scale = Matrix4.CreateScale(new Vector3(50f, 0.1f, 50f));
            Matrix4 translation = Matrix4.CreateTranslation(0f, -50f, 0f);

            // create the ground
            CollisionShape groundShape = new BoxShape(50, 50, 50);
            collisionShapes.Add(groundShape);
            CollisionObject ground = LocalCreateRigidBody(0, scale * rotation * translation, groundShape);
            ground.UserObject = "Ground";

I get a very weird effect that I don't quite understand. So what is the deal with scaling and how would I do it in this case?

Bullet doesn't support scaling the transformation matrix.
Try this:
groundShape.LocalScaling = new Vector3(50f, 0.1f, 50f);
You'll need different shapes for different sized boxes.

Thank you for the quick response!
I just tried that and there still is no collision with the scaled ground:
https://streamable.com/1enu0

I solved it!
If someone happens to have the same issue, here is what I did:
// don't apply rotation or scale
DefaultMotionState myMotionState = new DefaultMotionState(Matrix4.CreateTranslation(entity.Position));

// when you sync your transforms, apply scale:
Entity.TransformationMatrix = Matrix4.CreateScale(Entity.Scale) * World.CollisionObjectArray[i].WorldTransform;

Thank you for helping me :)

There are a few ways to work with scales.

Pass the required dimensions to the BoxShape constructor and render a graphical box shape of the same size. Keep LocalScaling = 1.

Pass the required dimensions to the BoxShape constructor and render a unit box (size 1) scaled by the dimensions given to the BoxShape. Keep LocalScaling = 1. (I think this is what you did.)

Create a unit box "new BoxShape(1)" and scale it using LocalScaling. The graphics engine should render a unit box scaled by the dimensions given to the BoxShape and also by LocalScaling.

LocalScaling is more useful for complex shapes, e.g. if you have a triangle mesh shape that is difficult to scale otherwise.


ignore_errors doesn't work as expected if show_indicator is set to False

Description
From what I understood, if ignore_errors is set to True then if any TestCase's metric measurement fails it would not affect the evaluation of other TestCases and their evaluation would continue.
https://github.com/confident-ai/deepeval/blob/7032d7d48bc6fa53d1562979e97d0dda94cb571c/deepeval/metrics/indicator.py#L131-L141
But this only happens when show_indicator is set to True. When it is set to false, the ignore_errors flag is of no use as the errors do affect and stop the evaluation of all TestCases.
https://github.com/confident-ai/deepeval/blob/7032d7d48bc6fa53d1562979e97d0dda94cb571c/deepeval/metrics/indicator.py#L171-L179
The error occurs in metric.a_measure and not in tasks.append and thus it is not caught by the try except blocks.
To Reproduce

Use a custom metric and raise an Exception in a_measure
Call evaluate with show_indicator to False and ignore_errors set to True

    results = evaluate(
            test_cases=test_cases,
            metrics=list(evaluators),
            show_indicator=False,
            print_results=False,
            use_cache=False,
            ignore_errors=True
        )

Desktop:

OS: Docker with Ubuntu
Version 0.21.48

@adayush thanks for the detailed explanation, was easy to reproduce! Fixed it in v0.21.50, TYSM!

Glad to know I was able to help! 😄


Need Spec Details of VM instances

Hi Team
We have been Using the monero app js application for our application. We had been facing certain error after transaction more than 10  in our application.Is there any specification for the vm instance to be applied please provide us if there is any machine spec to be given for deployment of core js application

Hi there, the core-js code is what is bundled up with the client software. We haven't seen any minimum requirements.


Change to the WebSocket Timeout in in LiteCore

Originally filed against the wrong repo:
https://github.com/couchbase/couchbase-lite-android/issues/1913

Per this couchbase/couchbase-lite-ios#2447, the WebScoket implementation in LiteCore has implemented the timeout. To avoid conflict or duplication, we should disable WebSocket (read/write) timeout from the platform code. If it cannot be disabled, we probably need to set it to be longer that what LiteCore is using.

According to: https://github.com/square/okhttp/blob/parent-2.4.0/okhttp/src/main/java/com/squareup/okhttp/OkHttpClient.java#L247 just don't specify a timeout.

FIxed here: https://github.com/couchbase/couchbase-lite-java/pull/111


feat: image transitions

https://github.com/user-attachments/assets/d03498de-f118-458c-8648-c197bf37ed75
🔗 Linked issue
https://github.com/johannschopplich/unlazy/issues/51
❓ Type of change

[x] ✨ New feature (a non-breaking change that adds functionality)

📚 Description
This adds optional transitions between BlurHash or ThumbHash via a new prop. It uses the Canvas API for compatibility and performance. This resolves the linked issue.

Hey @johannschopplich so sorry about that! I was doing a lot of testing from before I moved from css to canvas and I had forgot to revert things back when doing that (making changes in all packages trying to get css to work before reverting to canvas)
I also will bring back the comments. I did have a bot check my code for any vulnerabilities and I didn't even notice it removed all the dang comments when I did that.

Hey @johannschopplich so sorry about that! I was doing a lot of testing from before I moved from css to canvas and I had forgot to revert things back when doing that (making changes in all packages trying to get css to work before reverting to canvas)
I also will bring back the comments. I did have a bot check my code for any vulnerabilities and I didn't even notice it removed all the dang comments when I did that.

Also: please add the documentation for the new feature.

I had already updated the readme.md and the examples and totally didn't realize there was a docs directory. Getting this part done now and I think we will be all set! :)

Thanks a lot for your feedback!

Thanks for the PR! Unfortunately I haven't had time to review it yet. 🥲

Thanks for the PR! Unfortunately I haven't had time to review it yet. 🥲

Hey no rush at all! My project isn't launching till closer to end of Q1. Take your time :)


[ BLAS ] Add trigonometric transformation functions

In order to accelerate trigonometric calculations, add such transformation functions in BLAS module
Add zlib license file

Self evaluation:

Build test:	 [X]Passed [ ]Failed [ ]Skipped
Run test:	 [X]Passed [ ]Failed [ ]Skipped

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2395. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

:octocat: cibot: @skykongkong8, nntrainer/tensor/neon_mathfunc.h does not include Doxygen tags such as @file @brief @author @bug. You must include the Doxygen tags in the source code. Please refer to a Doxygen manual at http://github.com/nnstreamer/TAOS-CI/blob/main/ci/doc/doxygen-documentation.md

To contributor, We have used 'Signed-off-by:' notation by default to handle the license issues, that result from contributors. Note that 'Is there a Signed-off-by line?' is important because lawyers tell us we must have to it to cleanly maintain the open-source license issues even though it has nothing to do with the code itself.

:octocat: cibot: @skykongkong8, nntrainer/tensor/neon_mathfunc.h does not include Doxygen tags such as @file @brief @author @bug. You must include the Doxygen tags in the source code. Please refer to a Doxygen manual at http://github.com/nnstreamer/TAOS-CI/blob/main/ci/doc/doxygen-documentation.md

To contributor, We have used 'Signed-off-by:' notation by default to handle the license issues, that result from contributors. Note that 'Is there a Signed-off-by line?' is important because lawyers tell us we must have to it to cleanly maintain the open-source license issues even though it has nothing to do with the code itself.

:octocat: cibot: @skykongkong8, nntrainer/tensor/neon_mathfunc.h does not include Doxygen tags such as @file @brief @author @bug. You must include the Doxygen tags in the source code. Please refer to a Doxygen manual at http://github.com/nnstreamer/TAOS-CI/blob/main/ci/doc/doxygen-documentation.md

:octocat: cibot: @skykongkong8, nntrainer/tensor/neon_mathfunc.h does not include Doxygen tags such as @file @brief @author @bug. You must include the Doxygen tags in the source code. Please refer to a Doxygen manual at http://github.com/nnstreamer/TAOS-CI/blob/main/ci/doc/doxygen-documentation.md

:octocat: cibot: @skykongkong8, nntrainer/tensor/neon_mathfunc.h does not include Doxygen tags such as @file @brief @author @bug. You must include the Doxygen tags in the source code. Please refer to a Doxygen manual at http://github.com/nnstreamer/TAOS-CI/blob/main/ci/doc/doxygen-documentation.md

:octocat: cibot: @skykongkong8, nntrainer/tensor/neon_mathfunc.h does not include Doxygen tags such as @file @brief @author @bug. You must include the Doxygen tags in the source code. Please refer to a Doxygen manual at http://github.com/nnstreamer/TAOS-CI/blob/main/ci/doc/doxygen-documentation.md

:octocat: cibot: @skykongkong8, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2395-202401081200230.99420499801636-3f3c15df88e3f1b4d0bd850f62e241dd11b62055/.

:octocat: cibot: @skykongkong8, nntrainer/tensor/neon_mathfunc.h does not include Doxygen tags such as @file @brief @author @bug. You must include the Doxygen tags in the source code. Please refer to a Doxygen manual at http://github.com/nnstreamer/TAOS-CI/blob/main/ci/doc/doxygen-documentation.md

:octocat: cibot: @skykongkong8, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2395-202401081345250.63921403884888-738f95253ee835fc3934f5e3454670df4bf2298c/.

:octocat: cibot: @skykongkong8, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2395-202401081411370.78653788566589-3c00617abbbda05352eda5032e7887a3e2eebd0c/.


feat: tag catalog images with the associated repo git hash

What is this PR doing

the catalog image will now also be tagged with the git short-hash of the repository's HEAD commit and pushed alongside other catalog image tags.

Why is it being done

tagging the catalog image with a git hash will enable the ability to perform continuous deployment to staging/integration environments via app-interface (OSD-13603)

Hello @mrbarge could you please fix the commit message to follow the convention https://github.com/rhobs/observability-operator#commit-message-convention

Due to the identified issues above, this is going to be re-attempted in a separate PR. Closing this one out for now.


add invalidate to HMR API

refactor HMR javascript part to reduce duplication

What kind of change does this PR introduce?
feature

Did you add tests for your changes?
yes

Does this PR introduce a breaking change?
yes

What needs to be documented once your changes are merged?
module.hot.invalidate()
Calling this method will invalidate the current module which disposes and recreates this module when the HMR update is applied. This bubbles like a normal update of this module. invalidate can't be self-accepted by this module.
When called during the idle state, a new HMR update will be created containing this module. HMR will enter the ready state.
When called during the ready or prepare state, this module will be added to the current HMR update.
When called during the check state, the module will be added to the update when an update is available. If no update is available it will create a new update. HMR will enter the ready state.
When called during the dispose or apply state, HMR will automatically do an additional dispose and apply cycle after the current cycle has finished.
Use cases
Conditional accepting
A module can accept a dependency, but can call invalidate when the change of the dependency is not handle-able:
import { x, y } from "./dep";

const oldY = y;

processX(x);
export default processY(y);

module.hot.accept("./dep", () => {
  if(y !== oldY) {
    // This can't be handled, bubble to parent
    module.hot.invalidate();
    return;
  }
  // This can be handled
  processX(x);
});

Conditional self accept
A module can self-accept itself, but can invalidate itself when the change is not handle-able:
const VALUE = "constant"

export default VALUE;

if(module.hot.data && module.hot.data.value && module.hot.data.value !== VALUE) {
  module.hot.invalidate();
} else {

  doSomeSideeffect();

  module.hot.accept();
  module.hot.dispose(data => {
    revertSomeSideeffect();
    data.value = VALUE;
  });
}

Triggering custom HMR updates
const moduleId = chooseAModule();
const code = __webpack_modules__[moduleId].toString();
__webpack_modules__[moduleId] = eval(`(${makeChanges(code)})`);
if(require.cache[moduleId]) {
  require.cache[moduleId].hot.invalidate();
  module.hot.apply();
}

Notes
When invalidate is called, the dispose handler will eventually called and fill module.hot.data. If no dispose handler is registered an empty object is still provided for module.hot.data.
Make sure to not get catched in a invalidate loop, by calling invalidate again and again. This will result in stack overflow and HMR entering the fail state.

@pmmmwh @gaearon Do this help for react-fast-refresh in webpack?
@evilebottnawi for style-loader?

A module can self-accept itself, but can invalidate itself when the change is not handle-able

Is there any way to reliably capture the list of exports without generating code? Whether CJS or ESM.

A module can self-accept itself, but can invalidate itself when the change is not handle-able

Is there any way to reliably capture the list of exports without generating code? Whether CJS or ESM.

import * as SELF from "./self.js";
Object.keys(SELF)

In loose ESM and CJS you could also use Object.keys(require.cache[module.id].exports).
Or Object.keys(__webpack_require__(module.id)).
In webpack 5 there is __webpack_exports_info__.usedExports, which is a list of all used exports. That probably doesn't help you as you can't access the value.
We could consider adding a __webpack_exports_info__.providedExports, which would list all exports.
Note that these variants above have different properties regarding marking all exports as used and enumerating mangled export names.

variant
all exports marked as used
export names
list unused exports

import * as SELF
yes
real
yes

require.cache
no
mangled
no

__webpack_require__(module.id)
no
mangled
no

__webpack_exports_info__.usedExports
no
real
no

__webpack_exports_info__.providedExports
no
real
yes

Note that export name mangling only happen in production mode.


Detect suitable torch version

🚀 The feature
Detect a suitable pytorch version when building from source in setup.py. This could be opt-in via environment variable, perhaps like VISION_SELECT_SUITABLE_TORCH
Motivation, pitch
Makes building from source (especially in a CI environment) simpler and allows the correct version of torch to be selected, reducing the chance of incompatibility or build failure.
Alternatives
No response
Additional context
No response

I might try to implement this

Could you clarify the use case here? When you are building from source, are you building the latest main, a tag / release/* branch, or some arbitrary commit? All of them require a different torch:

main: latest torch nightly binary
tag / release/* branch: corresponding  torch test binary
arbitrary commit: there is no corresponding torch version. Your best bet is to find the date of the commit and go with an adjacent torch nightly binary

All scenarios above require torch binaries not hosted on PyPI. And AFAIK, you cannot use custom wheel indices inside setup.py.

Could you clarify the use case here? When you are building from source, are you building the latest main, a tag / release/* branch, or some arbitrary commit? All of them require a different torch:
* `main`: latest `torch` nightly binary

* tag / `release/*` branch: corresponding  `torch` test binary

* arbitrary commit: there is no corresponding `torch` version. Your best bet is to find the date of the commit and go with an adjacent `torch` nightly binary

All scenarios above require torch binaries not hosted on PyPI. And AFAIK, you cannot use custom wheel indices inside setup.py.

The use case is building releases from source. Could you elaborate on the torch test binary?

Ok, if you want to built releases rather than release candidates, you don't need test binaries, but can go with the corresponding torch release. Setting an environment variable should be sufficient:
https://github.com/pytorch/vision/blob/f3d6c6be5396d7dcfd25271568a3dd35c0e03f25/setup.py#L56-L58
However, note that this will pull from PyPI unless the requirement is already satisfied. Meaning, you don't have control over the CUDA version the torch binary is compiled against.

Closing this due to inactivity. Feel free to re-open if there is anything new here.


Path Gallery

my gallery path is set wrong. can you help me?

i mean i cant save the photo to internal or external device.

Why is wrong? can you give me more information please?
download the example of magical camera, save a picture and search this in gallery images... if your picture is here, maybe you dont implement correct magicalcamera.

Hi fabian, sorry for late reply.
problem already solved. hehe.
thank you so much.
2017-04-20 6:30 GMT+08:00 Fabian Rosales (Frosquivel Developer) <
<EMAIL_ADDRESS>
[image: Boxbe] https://www.boxbe.com/overview Fabian Rosales
(Frosquivel Developer<EMAIL_ADDRESS>is not on your Guest
List
https://www.boxbe.com/approved-list?tc_serial=29896175003&tc_rand=736684870&utm_source=stf&utm_medium=email&utm_campaign=ANNO_MWTP&utm_content=001&key=BK5uXWg402RP%2BhKVJex9yKKkD%2Bzd1zR024aipHcksfE%3D&token=hdAQWSLs%2BWTR39Id%2FFlQ3qO2Cl0EIsEFrMbj5XlxaB3LaexvmL5E1j7pA5Lz5tb8
| Approve sender
https://www.boxbe.com/anno?tc_serial=29896175003&tc_rand=736684870&utm_source=stf&utm_medium=email&utm_campaign=ANNO_MWTP&utm_content=001&key=BK5uXWg402RP%2BhKVJex9yKKkD%2Bzd1zR024aipHcksfE%3D&token=hdAQWSLs%2BWTR39Id%2FFlQ3qO2Cl0EIsEFrMbj5XlxaB3LaexvmL5E1j7pA5Lz5tb8
| Approve domain
https://www.boxbe.com/anno?tc_serial=29896175003&tc_rand=736684870&utm_source=stf&utm_medium=email&utm_campaign=ANNO_MWTP&utm_content=001&dom&key=BK5uXWg402RP%2BhKVJex9yKKkD%2Bzd1zR024aipHcksfE%3D&token=hdAQWSLs%2BWTR39Id%2FFlQ3qO2Cl0EIsEFrMbj5XlxaB3LaexvmL5E1j7pA5Lz5tb8
Why is wrong? can you give me more information please?
download the example of magical camera, save a picture and search this in
gallery images... if your picture is here, maybe you dont implement correct
magicalcamera.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/fabian7593/MagicalCamera/issues/22#issuecomment-295473996,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AZizZ-0DN5bua3FR41zrdQVB_aiBG-Gzks5rxosUgaJpZM4Mt3eL
.

--
Regards,
Haris Afandi
Software Engineer
Connect Seven Solution Sdn Bhd (924787-D)
Unit C-02-06, iTech Tower, Jalan Impact,
Cyber 6, 63000 Cyberjaya, Selangor, Malaysia.
Office: +60 15 4840 7746
Mobile: +60 11 3923 4837
http://www.c7solution.com

Thanks for use MagicalCamera


Project branches

I'm trying to point CMake's ExternalProject_Add to set up a dependency on this library.
I put release/3.70 as git tag, but this branch was removed. This breaks my build. Should release branches/tags ever be removed? Am I better off just pointing at master?

@concubicycle You probably have referenced a branch or? The tags are listed at https://github.com/nlohmann/json/tags.

Ah, yep! I put release/3.7.0. v3.7.2 is probably what I want.

Indeed you should use tags.

@concubicycle Do you need further assistance with this issue?

No, thank you guys!


Add snapshot option for Geting Metadata

Some notes:

Passing GetOption to Database's metadata function
Previously, when GetRawMetadata, a default Snapshot is acquired. Not this changed to un-geting it.
Some function unify the metadata logic.

CI failed is unrelated, rerun


Fixes for #2891 #2889

References

Fixes #2891
Fixes #2889

Description
This is a small follow-up PR to fix the mentioned issues
Checklist

[x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
[x] My PR passes ESLint validation using yarn lint
[x] My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
[x] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
[x] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
[x] If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
[x] If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
[x] If my PR fixes an issue ticket, I've linked them together.

@atarix83 The suggestion from CodeQL is to turn LazyDataServicesMap into an actual Map object:
in data-services.map.ts:
export const LAZY_DATA_SERVICES = new Map<string, () => Promise<Type<HALDataService<any>>>>()
LAZY_DATA_SERVICES.set(AUTHORIZATION.value, () => import('./data/feature-authorization/authorization-data.service').then(m => m.AuthorizationDataService));
...

in lazy-service pass both the map and the key, so you can write something like:
if (map.has(key)) {
   const loader = map.get(key):
   loader();
} else {
   trow new Error(`The key ${key} was not found in the map ${map}`);
}

where map has the type Map<string, () => Promise<any>> in the method to ensure that loader() is indeed a function that returns a promise. If that doesn't appease CodeQL, you may need to explicitly test that loader is a function as well.

thanks @artlowel for suggestions, now every checks pass and PR is to be reviewed


System.Array.type() client-side implementation should return a reference to System.Array, not Array

This issue has been reported in a forum thread (see "See also" below). The System.Array.type() client-side implementation opens a possibility for ambiguous reference of System.Array in one of its returned values, leading to runtime errors when building code with Bridge and using this environment.
Steps To Reproduce
It is not trivial to build the scenario and reproduce the issue, as it will require the Office.js lib and probably also MS-Office licensed software installed. Files and step-thrus are provided in the forum thread below, so the instructions are not going to be re-posted here.
See Also
Bridge forums thread: Regression issue 16.8.2 to 17.2.0

The fix was approved in the forum thread and the pull request merged!


Sliders and color picker loses focus when dragging outside of rect

Godot version
v4.0.alpha.custom_build [8cb51a642]
System information
Linux Fedora, Radeon RX 590
Issue description
Controls seem to lose mouse focus while dragging. Happens with sliders and color picker at least.
Steps to reproduce
Drag a slider or a color on a color picker
https://gfycat.com/physicalgratefulauklet
Minimal reproduction project
No response

Related to https://github.com/godotengine/godot/issues/63544.

Can no longer reproduce in rc5.


Provisioning V2 / RKEv2 does not work with third party node drivers

Rancher Server Setup

Rancher version: 2.6.3
Installation option (Docker install/Helm Chart): docker

Information about the Cluster

Kubernetes version: v1.21.9+rke2r1
Cluster Type (Local/Downstream): Infrastructure using third party node driver

User Information

What is the role of the user logged in?: Admin

Describe the bug
When trying to provision a cluster with a third party node
driver, that isn't a builtin, provisioning of a rke2 cluster fails.
Third Party node drivers added to rancher get a randomly assigned name as their
kubernetes resource name:
harvester       186d
linode          312d
nd-rjl9k        44m

But rke2 assumes the name when trying to provision machines leading to an error:
This error also isn't logged properly in the UI. There machines are only
described as Waiting to schedule machine create.
  status:
    conditions:
    - message: nodedrivers.management.cattle.io "nutanix" not found
      reason: Error
      status: "False"
      type: CreateJob

I assume this piece of code is responsible: https://github.com/rancher/rancher/blob/release/v2.6/pkg/controllers/provisioningv2/rke2/machineprovision/args.go#L298
func getNodeDriverName(typeMeta meta.Type) string {
	return strings.ToLower(strings.TrimSuffix(typeMeta.GetKind(), "Machine"))
}

Which simply takes the Kind of the machine crd, in my case NutanixMachine.
To Reproduce

Add a third party node driver
Spawn a rke2 cluster

Result
The cluster is stuck in provisioning and only showing
Waiting to schedule machine create as status for machines
Expected Result
The cluster provisions sucessfully
Workaround
Create the nodedriver manually in the backing kubernetes cluster with the correct name

still a problem

still a problem

we're having the same issue here with our custom node driver. @maxaudron did you end up fixing this issue somehow?

still a problem

Can we re-open this ticket? Its not possible to provision RKE2 clusters with the nutanix node driver

Workaround
Create the nodedriver manually in the backing kubernetes cluster with the correct name

Need to fix the v2prov assumption that NodeDriver resources will have a specific name; or fix how 3rd party node drivers are named when installed.

This is required due to the fact that node drivers were initially designed to be decoupled from the name with RKE1, however with v2prov (and specifically CAPI), CRDs are required (which was correctly pointed out here: https://github.com/rancher/rancher/issues/37074#issue-1183315207). In regards to a long term solution, we have determined that the best case solution is a change in the UI, since there is no way to remove the rancher requirement that the names have to be unique due to the generated CRDs, and validating that all node drivers have a different display name would not be a suitable alternative as opposed to just using the name of the corresponding nodedriver CR. cc @gaktive
The below provides a potential workaround. This assumes that one has created a third party driver in the rancher UI, with the correct url, ui url, and display name.
NODEDRIVER="<NODE DRIVER NAME, ex. (nd-12345)>"; kubectl get nodedriver "${NODEDRIVER}" -o yaml | yq 'del(.status) | .metadata |= with_entries(select(.key == "annotations")) | .metadata.annotations |= with_entries(select(.key == "publicCredentialFields" or .key == "privateCredentialFields"))' | yq ".metadata.name = .spec.displayName"

These are the minimum required fields to create a node driver. Once this yaml is retrieved, it can be piped to kubectl apply and the correspondingly generated node driver should be created. (My yq is a little rusty but this should suffice)

Note: you cannot attempt you use this script to create a node driver with an identical name to another, it won't work as they are backed by k8s CRs.

@jakefhyde can you file a ticket in rancher/dashboard and link back here?

@rancher/docs , FYI moved this to "Release Note" status as we would want to include the workaround https://github.com/rancher/rancher/issues/37074#issuecomment-1664722305 in the next release notes, not specifically 2023-Q4/2024-Q1 releases.

@gaktive Holding off on creating dashboard ticket for now, may require some additional work.

@snasovich do you mean the emergency release we're currently working on, or the one after?

@martyav , any next release. Won't hurt to put in the out-of-band release you mentioned - but we will want to retain it in Q3/v2.7-Next release notes as well as this won't be fixed in it.

Removing milestone from this issue as it's unlikely we will get to it soon especially given workaround exists.


Random but high-frequency NPE while mget

Expected behavior
When jedis.exists(bytes) returns true, then jedis.get(bytes) should return the value held at the key
Actual behavior
This is my method for getting a value for a string key. The value is also a String.
public <T extends Serializable> T getPersistedCache(@Nonnull String key) {
    requireNonNull(key);

    EntitySerializer serializer = new EntitySerializer();

    byte[] value;

    try (Jedis jedis = getPool().getReadOnlyResource()) {
      byte[] bytes = key.getBytes(UTF_8);
      if (!jedis.exists(bytes)) {
        return null;
      }
      value = jedis.get(bytes);
    } catch (Exception e) {
      logRedisException(e);
      return null;
    }

    return (T) serializer.deserialize(value);

  }

I understand jedis.exists(key) is not the best way to check if the key exists in Redis, but that is not the issue I want to raise here.
The issue is, even after checking for exists which returns
returns true, the jedis.get(bytes) returns null. This does not happen for all the keys and all the time but some time
Steps to reproduce:
There is no systematic way of reproducing the issue right now. It is happening only in my production environment
Redis / Jedis Configuration
Jedis version:
2.7.3
Redis version:
3.2.5
Java version:
1.8.161

I don't see any mget calls in here as the title describes. What's getReadOnlyResource BTW?. That's not Jedis code.
Please try to provide a reproducible case using Jedis code only. Otherwise it's hard for us to help.

Sorry, can't help without a some complete sample code where we can run some benchmarks or tests. There are some pieces missing here which we can't really guess. On a different subject, almost all of the concurrency issues that we've seen are related to custom user code .
I'd suggest taking a second look to your wrapper or provide some small complete example which we can run to try and trigger the bug. I'll close this in the mean time as there's not much we can do.

@marcosnils apologies for the noise caused. Just to put closure to this discussion, the issue was we were trying to get the expired tokens. There is some weird behavior seen in REDIS when a key has been expired, in a close proximity to that time, the exists(key)  return true but the get(key) returns null.
My approach to solve this issue is to stop using exists for now as its behavior is not deterministic. Instead I will handle the null returned by redis in application.