[Parse] Add fix-its for empty Swift 2 operator decl braces. (#4309)

Explanation: In simple cases, Swift 2's operator declaration syntax can be trivially migrated to Swift 3. This adds a fix-it to do that and enables it for use by the migrator.

Scope: Affects diagnostics for Swift-2-style operator declarations. Does not affect code that has already switched to Swift 3 style.

Issue: rdar://problem/27576922

Reviewed by: @rjmccall, @nkcsgexi

Risk: Very low.

Testing: Added new compiler regression tests.

Before merging this pull request to apple/swift repository:

[ ] Test pull request on Swift continuous integration.

Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please smoke test
    All supported platforms     | @swift-ci Please smoke test and merge
    OS X platform               | @swift-ci Please smoke test OS X platform
    Linux platform              | @swift-ci Please smoke test Linux platform

A smoke test on macOS does the following:

Builds the compiler incrementally.
Builds the standard library only for macOS. Simulator standard libraries and
device standard libraries are not built.
lldb is not built.
The test and validation-test targets are run only for macOS. The optimized
version of these tests are not run.

A smoke test on Linux does the following:

Builds the compiler incrementally.
Builds the standard library incrementally.
lldb is built incrementally.
The swift test and validation-test targets are run. The optimized version of these
tests are not run.
lldb is tested.

Validation Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please test
    All supported platforms     | @swift-ci Please test and merge
    OS X platform               | @swift-ci Please test OS X platform
    OS X platform               | @swift-ci Please benchmark
    Linux platform              | @swift-ci Please test Linux platform

Lint Testing
    Language     | Comment
    ------------ | -------------
    Python       | @swift-ci Please Python lint

Note: Only members of the Apple organization can trigger swift-ci.

@swift-ci Please test


Backport 2.16: Add tests for AES-GCM when called through single-step cipher API

This is the backport to Mbed TLS 2.16 of #2199, fixing #2198.
Internal ref: IOTSSL-2631

I ran a new CI job on this old PR and it passed. Marking as ready to merge.


feat: query string dynamic app config

Context
This PR allows for the app config to reference a json over network. This allows for
fast swapping of data source configuration, OIDC, etc, without recompiling the application.
If the configUrl query string is passed, the worklist and modes will load from the referenced json
rather than the default .env config
If there is no configUrl path provided, the default behaviour is used and there should not be any
deviation from current user experience.
Points to consider

User have to enable this feature by setting dangerouslyUseDynamicConfig.enabled:true. By default it is false.
Regex helps to avoid easy exploit
User must set cross-origin = same-origin to avoid potential harder exploit

Sample local config
/* Dynamic config allows user to pass "configUrl" query string this allows to load config without recompiling application. The regex will ensure valid configuration source */
  dangerouslyUseDynamicConfig: {
    enabled: false,
    regex: /.*/,
  }

Example usage
http://localhost:3000/?configUrl=http://localhost:3000/config/example.json
This PR is related to another PR https://github.com/OHIF/Viewers/pull/2925

Checklist
PR

[x] Brief description of changes
[x] Links to any relevant issues
[ ] Required status checks are passing
[x] User cases if changes impact the user's experience
[x] @mention a maintainer to request a review

Code

[x] My code has been well-documented (function documentation, inline comments,
etc.)

Public Documentation Updates

[x] The documentation page has been updated as necessary for any public API
additions or removals.

@sedghi @wayfarer3130 - request to review this PR.
@cupidchan FYI.


Prioritize repositories from the SBT plugin?

When fetching metadata, the repositories are tried in order one after the other. Those from https://repo.scala-sbt.org/ and https://repo.typesafe.com/typesafe often land in front of the repository list, actually supply few dependencies, and are usually longer to answer than Central. Putting them deeper in the list would speed up things, as we wouldn't even try to reach them most of the time.

Done a long time ago. Central is given a higher priority than the scala-sbt and typesafe repositories in the sbt plugins.


feat(multiple): Components should throw an error if their theme styles are missing

Components should check whether their theme styles are included on the page and throw an error if they are missing. It is easy for application authors to add a new component to their application without remembering to include the appropriate styles in their theme file.

We have the existing warning in the MatCommonModule that checks for the presence of a theme, but ask discussed, it's problematic to expand it into an error for the following reasons:

It isn't 100% reliable, because we don't know when the styles will be loaded. E.g. the theme could load after the app has been initialized.
The current approach only detects mat.core. If we wanted to expand it to all components, we'd have to add theme markers to all component themes which will increase bundle size.
We'd have to introduce getComputedStyle calls for each Material module which can be expensive.


Incomplete Code for Chapter 2 - Vector and Raster Data Examples_vf.ipynb

Hello,

In the image above what file should be read and stored to boundary variable?
Thanks

I have the same question!


A primitive formatter.

There seems to be a weird bug where after every element it thinks there should be 2 blocks of indentation.
For example, for this lalrpop file:
| <-  caret

// uses_statements
// everything else

Pressing enter if the caret is there would just work and creates and moves the caret to the beginning of the new line.
While if the caret is here, in a file like this:
use crate::grammar::*;
grammar;
| <- caret here

// everything else

Pressing enter there would move create the next line, but would also move the caret 2 blocks forward(2 tabs / 8 spaces):
use crate::grammar::*;
grammar;

        | <- caret here

// everything else

Same thing happens within all kinds of blocks, like
grammar;

NonTerminal = { | <- caret here
}

Press enter.
grammar;

NonTerminal = {
....1...2...3
}

The caret should be at the position marked with 1, but intellij puts it at 3.
However, writing the alternative at the 3 position like:
grammar;
NonTerminal = {
            sy0 sy1 sy2 ...
}

And then formatting, will yield a file properly formatted, like this:
grammar;
NonTerminal = {
    sy0 sy1 sy2
}

Did you give up on this? If you want help I can take a closer look.

Rather than gave up I moved it to the formatter branch(maybe open another PR). The only thing I couldn't get right were the alignments, and I'd be happy with any help I can get on them.


fix from format in card

Closes #232

Also fixes #232

Good catch @apbendi
Changes look good, re-approved by me! Confirmed this fixes #232 also so @radchukd I edited your PR description so the issue will be linked and closed automatically once it's merged


Instructions needed for non-obvious hci mechanics.

I didn't discover You Monster until looking through the code, because nowhere was there any indication of how to sell something (nor the sale cost).  I was actually pretty surprised that right-click worked.  There needs to be hovertext or a [?] thing or something available to explain game actions which are non-obvious.

@blackhole12 commented on this in #23.

You can also shift-click to buy or sell 10 at a time. Technically speaking, proper UI design demands that we expose buttons that the user can click to perform these actions, because on a mobile device, you can't shift click or right click at all. Once we have buttons that perform these actions, the buttons can have a tooltip that says "you can also sell ponies by right clicking on them" or something. Cookie clicker puts these buttons below whatever building you are hovering over, but this still doesn't work for mobile and it's really frustratingly unreliable because the buttons keep vanishing while clicking them. If someone has UI suggestions for this, it would be appreciated.

Partially solved by #52


Dask subflows trigger immediate computation

Details about the quacc environment
master
What is the issue?
The dask examples suggest that the result of a flow using dask as the backend should be a delayed, but the implementation triggers a compute(), which is blocking in dask. I think the .compute() is unintended:
https://github.com/Quantum-Accelerators/quacc/blob/main/src/quacc/wflow_tools/decorators.py#L461
How can we easily reproduce the issue?
https://quantum-accelerators.github.io/quacc/user/wflow_engine/wflow_engines1.html#running-a-pre-defined-workflow
from ase.build import bulk
from quacc.recipes.emt.slabs import bulk_to_slabs_flow

# Define the Atoms object
atoms = bulk("Cu")

# Define the workflow
delayed = bulk_to_slabs_flow(atoms)

# Print the results
result = client.gather(client.compute(delayed))
print(result)

Hi @zulissimeta! Thanks for your comment. This is an issue I have been unable to solve since implementing Dask support a few weeks ago; see #1381 and the links therein. It has to do with @delayed objects being passed to other @delayed functions and influences recipes with the @subflow pattern like the example above. I'll edit this comment with more details later this evening for context in case anyone is interested.

@zulissimeta: I stand corrected. Apparently, I unknowingly solved an unrelated issue that was forcing me to include .compute() in the @subflow definition as a bad workaround. There is still the concurrency issue with @subflows that I mentioned in #1381, but that is distinct.
The reported issue is fixed in #1471. Thank you for your report!


Simplify comment regexes + support all valid line endings

By not listing all valid line endings explicetely, we can simplify the regular expressions for comments and make them more correct.

Relevant: http://www.ecma-international.org/ecma-262/5.1/#sec-7.4

nice!


Ensure survey prompt is not displayed multiple times

For #4002

[ ] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
[ ] Title summarizes what is changing.
[ ] Has a news entry file (remember to thank yourself!).
[ ] Appropriate comments and documentation strings in the code.
[ ] Has sufficient logging.
[ ] Has telemetry for enhancements.
[ ] Unit tests & system/integration tests are added/updated.
[ ] Test plan is updated as appropriate.
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).

I think we'd need this fix in the insidersNativeNotebookSurvey.ts too.

Dmn it, just merged the PR.
Will create another PR for that.


Error Detection Tutorials v1

I did two things on this branch

Cleaned up the ErrorDetector class in order to make it more general, and allow users to more easily create their own error detectors
Created a simple tutorial showing users how to create their own error detctors

Please note that we'll need to change some of our existing tutorials to match the new error detection scheme, but this was required anyway. @JVonderwell @gmichalo @j48zheng Should we update tutorials on this branch, or create a new issue to refactor tutorials?

@j48zheng I haven't used spark a ton, do you know what function I would use to do that?


[DO NOT MERGE] Auto PR to update dependencies of pilot

This PR will be merged automatically once checks are successful.
none

@istio-testing: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/pilot-presubmit.sh
a428715019fa55dd34a0a5d8fd1deb977438dc82
link
/test pilot-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


clicking on datagrid rows and other links shouldn't change the page position

When a user clicks on the revisions grid, the UI jumps to the top of the page. Probably something to do with ui-router's ui-sref linking feature.

Fixed, closing.


Can't find fNbt.csproj

I installed monodevelop successfully and mostly pulled in the project successfully except it can't find fNbt.csproj or the fNbt namespace.
Any help is appreciated.

I read this and it was a little misleading.
https://github.com/SirCmpwn/TrueCraft/wiki/compiling
On Sat, Jun 27, 2015 at 6:54 PM, Drew DeVault<EMAIL_ADDRESS>wrote:

Have you ever wondered about the origin of the term "readme"?
https://github.com/SirCmpwn/TrueCraft#compiling
—
Reply to this email directly or view it on GitHub
https://github.com/SirCmpwn/TrueCraft/issues/175#issuecomment-116166682.

--
NOTICE: This electronic mail message and any files transmitted with it are
intended exclusively for the individual or entity to which it is addressed.
The message, together with any attachment, may contain confidential and/or
privileged information. Any unauthorized review, use, printing, saving,
copying, disclosure or distribution is strictly prohibited. If you have
received this message in error, please immediately advise the sender by
reply email and delete all copies.

I don't know why that page exists. I removed it.

Cool. Thank you. I'll give the readme a shot
On Sat, Jun 27, 2015 at 7:58 PM, Drew DeVault<EMAIL_ADDRESS>wrote:

I don't know why that page exists. I removed it.
—
Reply to this email directly or view it on GitHub
https://github.com/SirCmpwn/TrueCraft/issues/175#issuecomment-116178250.

--
NOTICE: This electronic mail message and any files transmitted with it are
intended exclusively for the individual or entity to which it is addressed.
The message, together with any attachment, may contain confidential and/or
privileged information. Any unauthorized review, use, printing, saving,
copying, disclosure or distribution is strictly prohibited. If you have
received this message in error, please immediately advise the sender by
reply email and delete all copies.

I'm a java developer and I'm not used to this environment.
I'm running the server no problem, simply by hitting f5 in monodevelop.
How do I run the client?
On Sat, Jun 27, 2015 at 7:59 PM, Josh Chappelle<EMAIL_ADDRESS>wrote:

Cool. Thank you. I'll give the readme a shot
On Sat, Jun 27, 2015 at 7:58 PM, Drew DeVault<EMAIL_ADDRESS>wrote:

I don't know why that page exists. I removed it.
—
Reply to this email directly or view it on GitHub
https://github.com/SirCmpwn/TrueCraft/issues/175#issuecomment-116178250
.

--
NOTICE: This electronic mail message and any files transmitted with it are
intended exclusively for the individual or entity to which it is addressed.
The message, together with any attachment, may contain confidential and/or
privileged information. Any unauthorized review, use, printing, saving,
copying, disclosure or distribution is strictly prohibited. If you have
received this message in error, please immediately advise the sender by
reply email and delete all copies.

Right click (in monodevelop) TrueCraft.Launcher and set it as the start-up project, then hit F5 again.

Awesome. Thanks for the quick response.
On Sat, Jun 27, 2015 at 8:56 PM, Drew DeVault<EMAIL_ADDRESS>wrote:

Right click (in monodevelop) TrueCraft.Launcher and set it as the
start-up project, then hit F5 again.
—
Reply to this email directly or view it on GitHub
https://github.com/SirCmpwn/TrueCraft/issues/175#issuecomment-116182526.

--
NOTICE: This electronic mail message and any files transmitted with it are
intended exclusively for the individual or entity to which it is addressed.
The message, together with any attachment, may contain confidential and/or
privileged information. Any unauthorized review, use, printing, saving,
copying, disclosure or distribution is strictly prohibited. If you have
received this message in error, please immediately advise the sender by
reply email and delete all copies.

I press your suggestion to do still error.
where is the fNbt.csproj?

RTFM, dude


Benchmarking the jest script

The goal is to benchmark the jest script to monitor and analyze the test suite run time over time using https://github.com/TheSavior/timing-stats.
At the end of the build, there will be a file called build_times.json. This is specified in the package.json file. It will append the current results to whatever the content of that file is. If CI pushes back to master this is trivial. In order to push to a different branch, we'll need to check out the other branch before running add-temp-timing-to-json and then pushing.

These benchmark times will be heavily affected by the load on Travis servers, so I'm worried this will be unreliable

Sorry, I don't think I added enough context since I've been talking to @cpojer for a while about this. Here is a blog post draft that walks through part of the goal for this type of data.
I think part of this will be an exploration of the data. While travis load surely changes, we may still be able detect trends or bigger problems. I think it could be reasonable to explore this and decide if we get anything valuable out of it.

Thanks!
We'll probably try to see if the new benchmarking feature inside of Jest may work for this: https://github.com/facebook/jest/pull/3026 and then come back to your PR. I'm super interested to see if CI is stable enough to track this long-term.


Add IPv6 Extension Fragment Header

Why do we need this header? smoltcp does not support fragmentation.

@whitequark this is part of the IPv6 implementation issue https://github.com/m-labs/smoltcp/issues/103#issuecomment-357706855
Per RFC 8200 Section 4:

A full implementation of IPv6 includes implementation of the
following extension headers:
Hop-by-Hop Options
Fragment
Destination Options
Routing
Authentication
Encapsulating Security Payload

In talking with @dlrobertson, I believe the plan is to simply recognize these headers and then return the appropriate ICMPv6 response.

OK

@m-labs-homu r+

:pushpin: Commit 1746ddc has been approved by whitequark

:hourglass: Testing commit 1746ddc58909c543ff514d0da0bd52b0c908a991 with merge dbaabd7304087301680a5a9ed312f9235e71deda...

:broken_heart: Test failed - status-travis

@m-labs-homu retry

:hourglass: Testing commit 1746ddc58909c543ff514d0da0bd52b0c908a991 with merge e114c46fce2283ef452c78c8bba60346e0dcbd29...


feat: introduce GGMLBlock and implement SVD(Broken)

In the past few weeks during my free time, I've been working on implementing this PR. In this PR, I introduced the GGMLBlock, making it easier to implement neural networks. In most cases, it's straightforward to implement the corresponding GGMLBlock from nn.Module. I have implemented the majority of the building blocks for SVD and the SVD pipeline, except for VScalingWithEDMcNoise, which is also relatively simple to implement.
However, I've started to feel fatigued. ggml's batch inference implementation for certain operators has issues, and although I've addressed some problems in this branch https://github.com/leejet/ggml/tree/batch-inference, it's not entirely resolved. Furthermore, there are situations where NaN occurs in the implementation of some operators, and these issues also need to be fixed. If I have time in the future, I'll continue addressing these issues with ggml. However, for now, I'll be allocating my free time to other tasks as I've already invested a considerable amount of effort in implementing this PR over the past few weeks. Perhaps I'll merge this PR first, even though the SVD support is broken. This is because the PR introduces GGMLBlock, which makes it convenient to use ggml for implementing neural networks. The test results for batch inference are documented in the comments of the test functions in unet.hpp/vae.hpp; take a look if you're interested.

this is amazing news, thank u so much for ur hard work leejet. can't wait u guys fix svd and try it on here
on the side note = convert feature seems still not working for quantize to under fp16 it seems, i tried to convert sdxl turbo to q5.1 and it didnt generate images [i mentioned it in that issues in safetensors topic]. could u please fix it as it will be very useful to convert svd model to quantize to q4.1 for example will be very fast

Doing batch inference will only be reserved for when you have a lot of VRAM. I think now we will be able to perform a single computation of a UNet in which a batch of conditionals c = [c, uc] is used.

I was planning to refactor Stable Diffusion to have an API similar to llama.cpp and also support offloading, computing sd, and controlnet on the GPU. However, upon reviewing this refactoring, I think it's better to just extend what I need to make a web UI work.

I was planning to refactor Stable Diffusion to have an API similar to llama.cpp and also support offloading, computing sd, and controlnet on the GPU with low VRAM. However, upon reviewing this refactoring, I think it's better to just extend what I need to make a web UI work.

@FSSRepo  Basically this PR that I'm implementing: https://github.com/leejet/stable-diffusion.cpp/pull/157
I split the loading logic of clip, vae, and unet, and then added the set_options api. I think we did the same thing.

It is understandable that problems will arise, ggml is mainly to satisfy llama's reasoning. However, for me, ggml has several advantages that cannot be ignored compared to pytorch. It is small enough (pytorch cuda dependency is about 1GB), and it supports quantification very well, and supports windows rocm.

GGMLBlock is very educational and this implementation is great.

Doing batch inference will only be reserved for when you have a lot of VRAM. I think now we will be able to perform a single computation of a UNet in which a batch of conditionals c = [c, uc] is used.

For svd, batch inference is a must, the ne3 is actually batch size * num video frames.

on the side note = convert feature seems still not working for quantize to under fp16 it seems, i tried to convert sdxl turbo to q5.1 and it didnt generate images [i mentioned it in that issues in safetensors topic]. could u please fix it as it will be very useful to convert svd model to quantize to q4.1 for example will be very fast. converting on the fly works but converting to gguf dont

did you use the fp16-fix vae?

on the side note = convert feature seems still not working for quantize to under fp16 it seems, i tried to convert sdxl turbo to q5.1 and it didnt generate images [i mentioned it in that issues in safetensors topic]. could u please fix it as it will be very useful to convert svd model to quantize to q4.1 for example will be very fast. converting on the fly works but converting to gguf dont

did you use the fp16-fix vae?

I found several problems when using it now. Regarding generating seeds, if the seed is 42, then the generated pictures are correct.
But if the seeds are random, the pictures will often be generated very strangely. I don’t know much about the performance on pytorch.
seed 42:

random seed

What shocks me is that for a 768x768 image (sdxl-turbo) on 7900xtx, a single sampling only takes 0.35s. It seems that the performance bottleneck lies in the decoding operation.

im using taesdxl and it works great, with taesdxl i dont need to use vae fp16 fix and generated images are great, however, what i meant was converting the models to q4.1 gguf files with -m convert command in cmd for having smaller models which gave me errors after generating image [the same as converting safetensors topic in issues if i remember]

But if the seeds are random, the pictures will often be generated very strangely

@Cyberhan123 I got same result in sd-webui using seed 297003140.

I will merge this PR even though the SVD support is broken. This is because the PR introduces GGMLBlock, which makes it convenient to use ggml for implementing neural networks. I have other changes that rely on GGMLBlock, such as adding support for stable cascade. I will try to fix the SVD issue later if I have time.


[new wireframe] get analytics data

[ ] TPS
[ ] Productivity
[ ] # of Delegates
[ ] # of Voters

@lizhefeng please schedule meeting with uu-z to discuss the API

@uu-z can you please update when can we have those API?


Generate inventory-report for basic orgs.csv

o	Org Name
o	Owner
o	Is PAT Project Collection Admin

this API should be able to check whether a PAT has the collection admin role (although figuring out the exact args is tricky): https://docs.microsoft.com/en-us/rest/api/azure/devops/security/permissions/has-permissions?view=azure-devops-rest-6.0

Move the Is PAT Collection Admin to a separate issue (#310)


Why is the promtail_config_positions empty by default?

ciao, please note that i'm currently in the process to get acquainted with loki and promtail. i was just wondering why the default for promtail_config_positions is an empty mapping. the application's default is /var/log/positions.yml which it can't write to when deployed with this role.

It was kept empty to use the default from loki and allow to override it when the environment requires this.
When looking at upstream, it will default to /var/log/positions.yml - https://github.com/grafana/loki/blob/master/pkg/promtail/positions/positions.go#L33
Possible ways forward that I see:

define the variable per default and ensure that file is writeable by the promtail user/group
ensure that promtail is added to the syslog group per default, then the any file in /var/log/* would be writeable by promtail

Open to further suggestions and happy to accept a PR :-)

i hope to come back w/ a pr when i'm through w/ my whole setup. just saying that /var/log/… seems wrong, /tmp/… is okay and working, but /var/promtail/positions.yml makes the most correct impression to me.


Can I set parameter: 'seed' value when using Python API of xgboost?

I set the same seed in param dict, but xgb outputs different result each time. This problem didn't happen when I used xgb.conf file to train xgb. By the way, whether is the Python-xgboost slower than direct using xgb.conf when training?

All the language bindings of xgboost should runs at exactly the same speed. For simple models, the result should be reproducible. But there can be indetermism due to floating point rounding errors. see http://xgboost.readthedocs.org/en/latest/faq.html#slightly-different-result-between-runs


[Feature Request]: More convenient access to Craft Lists.

First: Thank you for creating this plugin. It is great!
My request is hopefully a simple one.

It would be great if you could add multiple recipes to a quick craft list for x amounts or handle the current recipe like a craft list until x amounts are crafted (endurance possible).
Something like this:
Rightclick > add recipe to queue for X amount. > Start crafting. >finished > empty list/queue. (or manually empty it)
Possibly with any amount of recipes!
Right now you have to add it, then edit the amounts you want and then start crafting it from the menu.

The intended way of making lists is not through context menus, that's just for making a quick addition to a list and isn't meant to serve as the main way doing it.
The main way is through the list editor window itself, where you'll add the recipes through the dropdown and you can adjust values there a lot easier.


Yubikey failure mode wording isn't clear

If your security key has an error or times out, you get a screen that says "Please reinsert your key and activate it", with "Try again" and "More Options" buttons.
It's not clear (or at least it wasn't to me) that you have to click try again before re-inserting your key. Could we adjust the wording on that error screen slightly? I'm not sure what better wording might be, Paul or Jared might be able to help here?

Yep that makes a lot of sense to me 👍

It currently says "Something went wrong. Please re-insert your key and try again" which LGTM


Terminal rendering is buggy

Type: Bug
When my terminal has some output printed (eg.: via console log statements), it becomes buggy when I scroll through the output. Particularly, when the output is multi-lined, some of the lines duplicate while scrolling, making it hard to read the output.
Only when the output gets rendered for the first time, it appears proper/correct. if i resize the terminal window and scroll through previous outputs on the terminal, this bug starts appearing of lines getting duplicated. please resolve this ASAP. I have been noticing this bug since many months now.
VS Code version: Code 1.94.2 (384ff7382de624fb94dbaf6da11977bba1ecd427, 2024-10-09T16:08:44.566Z)
OS version: Windows_NT x64 10.0.22631

This issue seems to originate from an upstream component and is not something VSCode can fix by making a change to our code. As such, I will go ahead and close it. Please try to reproduce in Windows Terminal and report to microsoft/terminal with repro steps.
If you cannot reproduce in Windows Terminal, chances are it's fixed in a later version of Windows. You can read more about how we consume conpty here. Thanks for understanding.
/label upstream terminal-conpty windows


please delete this PR

Docs Build status updates of commit 7d4e4fa:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

testingTesting.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@lajanuari :)


BUG: scipy.interpolate.interp1d left hang

Describe your issue.
I am having problems with scipy.interp1d function. Even the most simple example provided in the package documentation, is left hanging.
Everything works fine until I actually try to use the interpolate.interp1d function.
I already removed scipy, using pip, and installed it again. The problem still persisted.
Reproducing Code Example
x = np.arange(0, 10)
y = np.exp(-x/3.0)
f = interpolate.interp1d(x, y)

xnew = np.arange(0, 9, 0.1)
ynew = f(xnew)   # use interpolation function returned by `interp1d`
plt.plot(x, y, 'o', xnew, ynew, '-')
plt.show()

### Error message

```shell
The code is left hang and nothing happen.

SciPy/NumPy/Python version information
1.8.0 1.21.0 sys.version_info(major=3, minor=10, micro=6, releaselevel='final', serial=0)

Suspect that something is wrong with your python install and/or scipy build. How did you install scipy?
Here's how I'd investigate:

Does it still hang if you remove the plotting call? (best, remove the whole of matplotlib from this script)
Does pure numpy work, if you only keep x = np.arange(0, 10); print(x), does it print it?
If it does but interp1d call hangs, does it hang on from scipy import interpolate or f = interpolate.inter1d(...) or f(xnew)?

Hi @ev-br ,
The scipy installation was done using pip install scipy.
The code hangs in f(xnew).
I was able to make scipy run, as expected, in a conda environment. I am however puzzled about this particular problem. I have been using scipy for a while without any problems, up until now.

Definitely an installation glitch it is.
A first suspect is using pip in a conda environment. It can have weird effects, as they say.
Maybe try a more recent scipy version (why would you use 1.8.0 still) either with pip in a fresh virtualenv, or with from conda-forge in a clean conda environment?


Allow scoring the diff between two arbitrary revisions

It might happen that a vandal edits the same page many times, and each of the edits has a low probability of being reverted, and still the whole set of edits, if looked at as a single edit (e.g. by enabling the enhanced recent changes preference), would have a high probability of being reverted.
In order to have predictions for these sequential edits, it seems necessary to be able to score a revision by comparing it with an older revision than the previous (parent) revision.
E.g.: I want to know the probability of this diff being reverted:
https://pt.wikipedia.org/w/index.php?diff=42204427&oldid=42203059
instead of the probabilities of each of the intermediary diffs for that page:

https://pt.wikipedia.org/w/index.php?diff=42204427
https://pt.wikipedia.org/w/index.php?diff=42204377
https://pt.wikipedia.org/w/index.php?diff=42204313
https://pt.wikipedia.org/w/index.php?diff=42204295
https://pt.wikipedia.org/w/index.php?diff=42204294
https://pt.wikipedia.org/w/index.php?diff=42204279
https://pt.wikipedia.org/w/index.php?diff=42204267
https://pt.wikipedia.org/w/index.php?diff=42204265
https://pt.wikipedia.org/w/index.php?diff=42204253
https://pt.wikipedia.org/w/index.php?diff=42204235
https://pt.wikipedia.org/w/index.php?diff=42204234
https://pt.wikipedia.org/w/index.php?diff=42203059

This shouldn't be too hard.  I talked this over with Helder, but I forgot to capture the notes.  Here is my proposal.

We add parent_revision.id as a Datasource

This will allow us to specify the revision that we would like to be treated as the parent to the dependency injection system.  It will be a little bit awkward for the batching strategy we do now (that assumes the parent_id can be found by looking at revision_metadata.parent_id).  I don't suspect this will be too bad though since we can solve() the parent_revision.id dependency from, a cache that contains revision.metadata and possibly parent_revision.id already.

We change the format of revids string in ORES to allow for parents to be specified

Right now, we can specify a list of revisions to score by splitting them by bars -- e.g., 1234|5678|9876.  So, a regex for that would be: [0-9](\|[0-9])*  I propose that we extend this format to optionally include a colon separated parent_id -- e.g. 1233:1234|5677:5678|9875:9876.  So, this would change the regex to: ([0-9]:)?[0-9](\|([0-9]:)?[0-9])*  This would allow someone to mix requests for revisions that have an old parent_id with requests for revisions that would use the default -- e.g., 1234|5677:5678|9876

Just in case we want to be consistent with how MediaWiki does this: users can create internal links to
[[Special:Diff/123/456]] (using "/" as a separator instead of ":") and the link will point to
https://en.wikipedia.org/w/index.php?oldid=123&diff=456

For the use case being described, it should also be possible to filter by user, or otherwise cherry-pick over edits by known users, so that we're only scoring the alleged vandal's edits.  Interposing reverts would be tricky here, cos they would be removing part of the signal.

https://ores.wmflabs.org/v2/scores/enwiki/damaging/4010401?datasource.revision.parent.id=1100
This now works just fine.


exec_aud.sh <- Need Push Fix to Github

Not sure how to correctly execute the Git Push / Commit / Add, feel free to make a working version.

Entering the Danger Zone.

Fixed with @brplcc , with contributions from @TacticalTux and @wes34.


google/flan-t5-small, PrefixTuning: RuntimeError: shape is invalid for input of size

When running PrefixTuning, with a SEQ_2_SEQ_LM task on google/flan-t5-small model from HuggingFace, I get the following error:
...
  File "/home/src/hac/engine.py", line 34, in _update
    outputs = model(**inputs)
  File "/home/.venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1194, in _call_impl
    return forward_call(*input, **kwargs)
  File "/home/.venv/lib/python3.10/site-packages/peft/peft_model.py", line 705, in forward
    past_key_values = self.get_prompt(batch_size)
  File "/home/.venv/lib/python3.10/site-packages/peft/peft_model.py", line 242, in get_prompt
    past_key_values = past_key_values.view(
RuntimeError: shape '[8, 8, 16, 6, 85]' is invalid for input of size 524288

For a reference, [8, 8, ... is [batch_size, num_virtual_tokens, ....
On the other hand, google/flan-t5-base and google/flan-t5-xl worked properly in the exact same setting.

Try 512-num_virtual_tokens
https://discuss.huggingface.co/t/tensor-size-error-in-peft-prefix-tuning/32264/3

I encountered a similar issue with the mT0-small model. To address this, I made some modifications to the internal implementation. Here's a brief overview of the changes:

Modification in prefix_tuning/model.py:
I adjusted the token dimension specifically for the mT0-small model. The updated __init__ method in prefix_tuning/model.py now looks like this:
def __init__(self, config):
    super().__init__()
    self.prefix_projection = config.prefix_projection
    # Special handling for mT0-small model
    if 'mt0-small' in config.base_model_name_or_path:
        token_dim = 6 * 64  # Custom dimension for mT0-small
    else:
        token_dim = config.token_dim

Adjustment in peft_model.py:
Similarly, in peft_model.py, I made a conditional change to the token_dim based on whether the model is mT0-small. The relevant code snippet is:
token_dim = peft_config.token_dim if 'mt0-small' not in peft_config.base_model_name_or_path else (6 * 64)
past_key_values = past_key_values.view(
    batch_size,
    peft_config.num_virtual_tokens,
    peft_config.num_layers * 2,
    peft_config.num_attention_heads,
    token_dim // peft_config.num_attention_heads,
)

These changes specifically tailor the token dimension to align with the requirements of the mT0-small model. So basically, the token_dim for this model should have been 384 not 512, i think that is because the MT5Attention for small model has in_features=512, out_features=384


Thumbnails of photos

Last thing I can think of to improve is to create option of showing thumbnails below the slider.
I'm creating estate agency page and on single offer page I would like to show slider (except that I'm using slider on first page as background of first view) with thumbnails so it would like similiar to this

This would be optional setting.

I thought about it and updated the code to be classed inside .vue-flux instead of scoped, so will only inherit the styles when they are placed inside the component and will be easier to overwrite.
This way you can place the flux-index component outside and give it any appearance you need having the same functionality. This means, vertical, horizontal, aligned any side, with arrows or with scrolls.
If you agree with this latest changes will release it this afternoon finally :)

Sure sounds great.

Remember to keep wiki's up to date when you release 3.0.0 as it's most important thing for other devs.

Wiki should be updated now. Let me know if something missing :)


ERROR [preprocess]: Can not load "webpack"!

I'm submitting a bug report
Webpack version:
<EMAIL_ADDRESS>Webpack Karma version:
2.0.1
Karma version:
1.4.0
Please tell us about your environment:
Windows 10
Browser: PhantomJS 2.1.1
Current behavior:
Not working keep getting ERROR [preprocess]: Can not load "webpack"!
Expected/desired behavior:
Run Test
Current karma config looks like this
require('babel-register');
const webpack = require('../webpack.config.babel.js');
const path = require('path');
module.exports = function(config) {
  config.set({
    basePath: '../',
    frameworks: [ 'mocha', 'chai-sinon' ],
    browsers: [ 'PhantomJS' ],
    files: [ 'test/browser/**/*.js' ],
    preprocessors: {
      'test/**/*.js': [ 'webpack' ],
      'src/**/*.js': [ 'webpack' ]
    },
    webpack,
    webpackMiddleware: { noInfo: true }
  });
};

Sorry you can close this one, was an error in my webpack config


translate

need Chinese translate！！！！！

'Kay, I'll try to write it, but it may be not so correct.

In fact, I have already translated it, but I don't know how to upload it to you. Should I directly package the jar for you or not?? I need you to give me permission for a project

I'm sorry for making this decision without permission. I was worried that I wouldn't be able to contact you, so I asked my friends. They taught me how to use fork to upload files, and I have no intention of infringing. I just want to use your mod in my modpack. I'm a beginner in this industry and I'm not sure about many things. If it causes any trouble for you, please contact me!!! I'm really sorry

Additionally, I encountered a crash while adjusting the weather to Stormy using instructions, and I am unsure of the reason. I hope it can be fixed

In the water, entering the water during a storm can cause collapse

Thanks a lot! You may open the pull request to push your translate to my repository with preservation of your copyright.
As for the error you found, can you describe it in more detail?

I think I've figured out what crash you're talking about. It was fixed in Seasons API  1.2-BETA-2

I understand, the bug has been fixed, and
DefaultTXTLangZH.zip
I don't know how to use GitHub. However, with the help of a friend, I forked your project and uploaded the source file. If possible, I will try to submit a Chinese translation directly here for you to update easily!


Feat/multi dropdown component

WIP.
Focus on creating the multiple pick dropdown.
Issue: https://github.com/stardust-ui/react/issues/388

It also drops down under code editor in docsite:

Warnings

:warning:
There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

  Generated by :no_entry_sign: dangerJS

any idea why this is happening in the screener tests?
https://screener.io/v2/states/rkGqtccHX.stardust-ui-react/feat%2Fmulti-dropdown-component/1024x768/Chrome/inputexampleinputslotshorthandtsx-0

@Bugaa92

any idea why this is happening in the screener tests https://screener.io/v2/states/rkGqtccHX.stardust-ui-react/feat%2Fmulti-dropdown-component/1024x768/Chrome/inputexampleinputslotshorthandtsx-0

This happens because of the


Verification

Description Of Changes
Adds tests and scaffold to run those tests as a verification of quickstart implementation
Motivation and Context
The verification phase validates that all steps completed correctly, and gives actionable data to the end user in event of issues.
Testing
Built QSG and ran Pester tests to validate them
Change Types Made

[ ] Bug fix (non-breaking change)
[x] Feature / Enhancement (non-breaking change)
[ ] Breaking change (fix or feature that could cause existing functionality to change)
[x] PowerShell code changes.

Related Issue

Fixes #121
Change Checklist

[x] Requires a change to the documentation
[x] Documentation has been updated
[ ] Tests to cover my changes, have been added
[ ] All new and existing tests passed.
[ ] PowerShell v2 compatibility checked.

@corbob since this is Pester I asked for a more familiar eye in the review here.

I put a change in that moves the helper function for the tests into the Get-helpers file.
Tested this thoroughly and all tests pass without a fuss. I'm good with merging now as well.

Tested locally and everything passed for me. Sending it.


Single end command suggestions

To make the pipeline work with single end data as well as paired-end, we will need different commands for the pre-alignment steps. Once we have a bam file, everything should be the same. I think.
Current paired-end specific jobs are:

FastQC

fastqc -q ${read1} ${read2}

Trim Galore!

trim_galore --paired --gzip --fastqc_args "-q" $read1 $read2

STAR:

STAR --genomeDir $index \\
         --sjdbGTFfile $gtf \\
         --readFilesIn $trimmed_read1 $trimmed_read2 \\
         --runThreadN ${task.cpus} \\
         --twopassMode Basic \\
         --outWigType bedGraph \\
         --outSAMtype BAM SortedByCoordinate\\
         --readFilesCommand zcat\\
         --outFileNamePrefix \$prefix

FastQC is easy, that runs on a per-file basis anyway so we just remove read 2:
fastqc -q ${read1}

Trim Galore! isn't much more difficult:
trim_galore --gzip --fastqc_args "-q" $read1

And again for STAR I think we just drop read 2:
STAR --genomeDir $index \\
         --sjdbGTFfile $gtf \\
         --readFilesIn $trimmed_read1\\
         --runThreadN ${task.cpus} \\
         --twopassMode Basic \\
         --outWigType bedGraph \\
         --outSAMtype BAM SortedByCoordinate\\
         --readFilesCommand zcat\\
         --outFileNamePrefix \$prefix

This one will need testing as I'm not so familiar with star.

Ok, there are a few extras downstream:

DupRadar will also need to have paired set to FALSE
featureCounts needs to have the -p flag removed

I think that's it..


do ipadapter_face and ipadapter together

can we try to do ipadapter face and ipadapter together?
maybe like this
hidden_states = hidden_states + self.scale1 * ip_hidden_states + self.scale2 * ip_face_hidden_states

or maybe a better way this using a class to handle multiple adapters.

can we try to do ipadapter face and ipadapter together? maybe like this hidden_states = hidden_states + self.scale1 * ip_hidden_states + self.scale2 * ip_face_hidden_states

I think it maybe work, you can have a try?

ok,i'll have a try

in this comfy extension https://github.com/cubiq/ComfyUI_IPAdapter_plus/blob/main/IPAdapterPlus.py .He has a similar implementation which I think works well.
style:

face:

output:

@cubiq

can you share the code to do that without comfyui?


Normalized WH Prediction seems to get better performance

https://github.com/developer0hye/YOLOv3-PyTorch-Colab
https://colab.research.google.com/drive/1ikcj4kJ2N1ny3jIHuEFIZTnwlV9-nCw4
I am experimenting with the variant of your code.
I got the higher mAP with normalized wh prediction instead of wh divided by the stride.
The results of 170 epoch trained yolv3 tiny
AP for aeroplane = 0.7843
AP for bicycle = 0.8139
AP for bird = 0.6702
AP for boat = 0.6116
AP for bottle = 0.5703
AP for bus = 0.8028
AP for car = 0.8394
AP for cat = 0.8012
AP for chair = 0.5465
AP for cow = 0.7497
AP for diningtable = 0.6677
AP for dog = 0.7366
AP for horse = 0.8391
AP for motorbike = 0.8023
AP for person = 0.7880
AP for pottedplant = 0.4613
AP for sheep = 0.7257
AP for sofa = 0.6991
AP for train = 0.8025
AP for tvmonitor = 0.7194
Mean AP = 0.7216

You means that you didn't divide all acnhor boxes with stride, right?
------------------ 原始邮件 ------------------
发件人: "Yonghye<EMAIL_ADDRESS>发送时间: 2020年3月22日(星期天) 中午11:27
收件人<EMAIL_ADDRESS>抄送<EMAIL_ADDRESS>主题: [yjh0410/pytorch-yolo-v2-v3] Normalized WH Prediction seems to get better performance (#27)
https://github.com/developer0hye/YOLOv3-PyTorch-Colab
https://colab.research.google.com/drive/1ikcj4kJ2N1ny3jIHuEFIZTnwlV9-nCw4
I am experimenting with the variant of your code.
I got the higher mAP with normalized wh prediction instead of wh divided by the stride.
The results of 170 epoch trained yolv3 tiny
AP for aeroplane = 0.7843
AP for bicycle = 0.8139
AP for bird = 0.6702
AP for boat = 0.6116
AP for bottle = 0.5703
AP for bus = 0.8028
AP for car = 0.8394
AP for cat = 0.8012
AP for chair = 0.5465
AP for cow = 0.7497
AP for diningtable = 0.6677
AP for dog = 0.7366
AP for horse = 0.8391
AP for motorbike = 0.8023
AP for person = 0.7880
AP for pottedplant = 0.4613
AP for sheep = 0.7257
AP for sofa = 0.6991
AP for train = 0.8025
AP for tvmonitor = 0.7194
Mean AP = 0.7216
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Yeah, I divide all anchor boxes with input size.
I make the model to predict normalized width and height(0~1)
So, I divide your default anchor with 13 and then got the normalized anchor box.

Oh! Sounds good!
See the formulation:
tw = log(box_w/p_w)
I think we needn't to divide them by width of input image beacuse of:
tw = log((box_ww)/(p_ww))=log(box_w/p_w)
I will try this on YOLO-v3. Maybe there is also some improvement!
In addition, I replace the SubtractMean func with Normalize func in data_augment following your advice.
class Normalize(object):
    def init(self, mean, std):
        self.mean = np.array(mean, dtype=np.float32)
        self.std = np.array(mean, dtype=np.float32)
    def call(self, image, boxes=None, labels=None):
        image = image.astype(np.float32) / 255.
        image -= self.mean
        image /= self.std
        return image.astype(np.float32), boxes, labels
where the mean=(0.485, 0.456, 0.406) and std=(0.229, 0.224, 0.225) which are used in imagenet.
I wish it will bring some improvement.
------------------ 原始邮件 ------------------
发件人: "Yonghye<EMAIL_ADDRESS>发送时间: 2020年3月22日(星期天) 中午11:31
收件人<EMAIL_ADDRESS>抄送: "ら ．Secret"<1394571815<EMAIL_ADDRESS>主题: Re: [yjh0410/pytorch-yolo-v2-v3] Normalized WH Prediction seems to get better performance (#27)
Yeah, I divide all anchor boxes with input size.
I make the model predict normalized width and height(0~1)
So, I divide your default anchor with 13 and then got the normalized anchor box.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

I hope too!
Also, be careful about calculating the bounding box!
https://github.com/developer0hye/YOLOv3-PyTorch-Colab/blob/92b191d64c4e730607318cbd9514e41794fbf743/model.py#L211-L222

Hellow!
I finished training my yolo-v2 with normalize data_augment. But I get a little worse result:
Previous：74.4%（416）and 76.8%（608）
Now：74.3%（416） and 76.0%（608）
I'm not sure this is because of something random or the normalize data_augment.
Nevertheless, I want to keep the normalize data_augment.
------------------ 原始邮件 ------------------
发件人: "Yonghye<EMAIL_ADDRESS>发送时间: 2020年3月22日(星期天) 中午11:46
收件人<EMAIL_ADDRESS>抄送: "ら ．Secret"<1394571815<EMAIL_ADDRESS>主题: Re: [yjh0410/pytorch-yolo-v2-v3] Normalized WH Prediction seems to get better performance (#27)
I hope too!
Also, be careful about calculating the bounding box!
https://github.com/developer0hye/YOLOv3-PyTorch-Colab/blob/92b191d64c4e730607318cbd9514e41794fbf743/model.py#L211-L222
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

@yjh0410
Good Experiment!
Do you modify the base transform used in voc_eval.py?

Yes, I do.
    dataset = VOCDetection(args.voc_root, [('2007', set_type)],
                           BaseTransform(net.input_size, mean=(0.485, 0.456, 0.406), std=(0.229, 0.224, 0.225)),
                           VOCAnnotationTransform())
I tend to think that this is because of something random like random sample，random initialization.
------------------ 原始邮件 ------------------
发件人: "Yonghye<EMAIL_ADDRESS>发送时间: 2020年3月22日(星期天) 下午4:52
收件人<EMAIL_ADDRESS>抄送: "ら ．Secret"<1394571815<EMAIL_ADDRESS>主题: Re: [yjh0410/pytorch-yolo-v2-v3] Normalized WH Prediction seems to get better performance (#27)
@yjh0410
Good Experiment!
Do you modify the base transform used in voc_eval.py?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

I think so! Did you train the model with normalized wh prediction??

I'm training the tiny-yolo-v3 with normalized wh prediction and normalize data_augment. Looking forward to good news ！
------------------ 原始邮件 ------------------
发件人: "Yonghye<EMAIL_ADDRESS>发送时间: 2020年3月22日(星期天) 下午5:17
收件人<EMAIL_ADDRESS>抄送: "ら ．Secret"<1394571815<EMAIL_ADDRESS>主题: Re: [yjh0410/pytorch-yolo-v2-v3] Normalized WH Prediction seems to get better performance (#27)
I think so! Did you train the model with normalized wh prediction??
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

@yjh0410
Ah Okay!!! You make me inspired!
Are you a student or researcher??

Haha！I’m a student.
------------------ 原始邮件 ------------------
发件人: "Yonghye<EMAIL_ADDRESS>发送时间: 2020年3月22日(星期天) 下午5:42
收件人<EMAIL_ADDRESS>抄送: "ら ．Secret"<1394571815<EMAIL_ADDRESS>主题: Re: [yjh0410/pytorch-yolo-v2-v3] Normalized WH Prediction seems to get better performance (#27)
@yjh0410
Ah Okay!!! You make me inspired!
Are you a student or researcher??
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Ah, me too. Actually I am a graduate student. KK I was curious about this.

Fighting！Fighting！！
You also make me inspired. I believe you will do a very great job！
------------------ 原始邮件 ------------------
发件人: "Yonghye<EMAIL_ADDRESS>发送时间: 2020年3月22日(星期天) 下午5:51
收件人<EMAIL_ADDRESS>抄送: "ら ．Secret"<1394571815<EMAIL_ADDRESS>主题: Re: [yjh0410/pytorch-yolo-v2-v3] Normalized WH Prediction seems to get better performance (#27)
Ah, me too. Actually I am a graduate student. KK I was curious about this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

@yjh0410
Thanks! Fighting！Fighting!!! I also believe in you!!~

This is my tiny-yolo-v3's mAP:
AP for aeroplane = 0.7967
AP for bicycle = 0.8083
AP for bird = 0.6907
AP for boat = 0.5946
AP for bottle = 0.5727
AP for bus = 0.8075
AP for car = 0.8332
AP for cat = 0.8078
AP for chair = 0.5523
AP for cow = 0.7414
AP for diningtable = 0.6883
AP for dog = 0.7560
AP for horse = 0.7956
AP for motorbike = 0.8130
AP for person = 0.7872
AP for pottedplant = 0.4576
AP for sheep = 0.7254
AP for sofa = 0.7081
AP for train = 0.7894
AP for tvmonitor = 0.6993
Mean AP = 0.7213

I use the normalize data_augment and no any division on anchor boxes or groundtruth boxes. It is better than original result 71.3% mAP.

Although with division and without divison are mathematically equivalent, I think there is something about trade-off for a computer bringing the above different result.

Following that, I'm training yolo-v3 which consumes about 24 hours. And I plan to update all my models with normalize data_augment（Even though it doesn't bring any improvement，almost detectors use that. I think there is something I haven't known, and I need to study it deeply and check my data_augment codes carefully.）.

Looking forward to good news！

------------------ 原始邮件 ------------------
发件人: "Yonghye Kwon"<notifications@github.com>;
发送时间: 2020年3月22日(星期天) 晚上8:57
收件人: "yjh0410/pytorch-yolo-v2-v3"<pytorch-yolo-v2-v3@noreply.github.com>;
抄送: "ら ．Secret"<1394571815@qq.com>;"Mention"<mention@noreply.github.com>;
主题: Re: [yjh0410/pytorch-yolo-v2-v3] Normalized WH Prediction seems to get better performance (#27)

@yjh0410
 Thanks! Fighting！Fighting!!! I also believe in you!!~

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Yeah!! Great! Keep up the good work!

So, the range of predicted wh of your model is 0 to 1? or 0 to img.width and 0 to img.height??

Yolo-v3 predicts the tw and th which are equal to log(box_w / pw) and log(box_h / p_h) instead of wh. They are both small increments.
My all anchor boxes are as following:(Original anchor boxes \times 32)
MULTI_ANCHOR_SIZE = [[32.64, 47.68], [50.24, 108.16], [126.72, 96.32],
                     [78.4, 201.92], [178.24, 178.56], [129.6, 294.72],
                     [331.84, 194.56], [227.84, 325.76], [365.44, 358.72]]
# MULTI_ANCHOR_SIZE = [[1.02, 1.49], [1.57, 3.38], [3.96, 3.01],
#                      [2.45, 6.31], [5.57, 5.58], [4.05, 9.21],
#                      [10.37, 6.08], [7.12, 10.18], [11.42, 11.21]]
------------------ 原始邮件 ------------------
发件人: "Yonghye<EMAIL_ADDRESS>发送时间: 2020年3月23日(星期一) 中午11:08
收件人<EMAIL_ADDRESS>抄送: "ら ．Secret"<1394571815<EMAIL_ADDRESS>主题: Re: [yjh0410/pytorch-yolo-v2-v3] Normalized WH Prediction seems to get better performance (#27)
So, the range of predicted wh of your model is 0 to 1? or 0 to img.width and 0 to img.height??
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

What happed when we train the model with mutl scale??
Is the anchor size changed??

During multi scale training stage, We change nothing but only input size. It works for my yolov2, but dose not for my yolov3. I'm not sure why.
---Original---
From: "Yonghye<EMAIL_ADDRESS>Date: Mon, Mar 23, 2020 12:03 PM
To<EMAIL_ADDRESS>Cc: "Mention"<mention@noreply.github.com>;"Jianhua<EMAIL_ADDRESS>Subject: Re: [yjh0410/pytorch-yolo-v2-v3] Normalized WH Prediction seems to get better performance (#27)
What happed when we train the model with mutl scale??
Is the anchor size changed??
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

I think... to solve the problem we should use the normalized anchor box[0, 1] for supporting invariant to input shape.

Maybe. I will try again following your advice.
---Original---
From: "Yonghye<EMAIL_ADDRESS>Date: Mon, Mar 23, 2020 13:36 PM
To<EMAIL_ADDRESS>Cc: "Mention"<mention@noreply.github.com>;"Jianhua<EMAIL_ADDRESS>Subject: Re: [yjh0410/pytorch-yolo-v2-v3] Normalized WH Prediction seems to get better performance (#27)
I think... to solve the problem we should use the normalized anchor box[0, 1] for supporting invariant to input shape.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

@yjh0410
Thanks! I am also trying the various methods to improve performance!

Hellow!
I have tried some menthos to improve my model. But almost failed. For example：
Method 1: Normalize ab to [0, 1], also gt box.
In tiny-yolo-v2.py, I divided anchor boxes by 13 to normalize them to [0, 1], and also normalize gt box with input size to [0, 1]. But this maked my tiny v2 drop some points——60.2% vs 61.6%. Tiny-v3 didn't, either.
Method 2: *Use the original anchor boxes, no division, and success !
After I multiplied my all anchor boxes by 32 to map them into the scale of input size(416) (and normalize data_augment), yolo-v3 got 81.0 mAP higher than my previous result 80.8 mAP. Thanks a lot for your advice !!
Method 3: Use xywh to compute loss instead of txtytwth which I used to compute loss
I find some YOLO-v3 projects predicts txtytwth and maps them to xywh, then adds xywh into loss function while I use txtytwth to compute loss. So I tried the former one, but got a worse result: 68 % vs 72.1%(tiny v3). Tiny-v2 dropped much, too. Perhaps there are some hidden tricks I don't know. But I'm sure that YOLOv3 uses tw, th according to his paper.
I'm struggling with multi-scale training trick for my v3.
------------------ 原始邮件 ------------------
发件人: "Yonghye<EMAIL_ADDRESS>发送时间: 2020年3月23日(星期一) 中午1:47
收件人<EMAIL_ADDRESS>抄送: "ら ．Secret"<1394571815<EMAIL_ADDRESS>主题: Re: [yjh0410/pytorch-yolo-v2-v3] Normalized WH Prediction seems to get better performance (#27)
@yjh0410
Thanks! I am also trying the various methods to improve performance!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

@yjh0410
Thanks a lot for your exeperiments!
I also have tried some methods.
Method 1: Use Sigmoid instead of Softmax to predict the class
I got a worse result. But, the official implementation used sigmoid to predict the class of objects. So, I keep up the sigmoid implementation!
yolov3 tiny with softmax: 72.5 %
yolov3 tiny with sigmoid: 72.1 %
Keep up the good work!! Fighting! Fighting!!

@yjh0410
Ah, I also have a plan that is applying other learning rate decay methods like cosine decay scheduler.

Sounds reasonable !
I have never tried other lr schedulers.
I also plan to use focal loss to compute class loss with sigmoid not softmax.
Looking forward to your good news !!
------------------ 原始邮件 ------------------
发件人: "Yonghye<EMAIL_ADDRESS>发送时间: 2020年3月25日(星期三) 中午11:25
收件人<EMAIL_ADDRESS>抄送: "ら ．Secret"<1394571815<EMAIL_ADDRESS>主题: Re: [yjh0410/pytorch-yolo-v2-v3] Normalized WH Prediction seems to get better performance (#27)
@yjh0410
Ah, I also have a plan that is applying other learning rate decay methods like cosine decay scheduler.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

@yjh0410
And I have a plan to support to resume of the training!


[Discussion] vela init UX

➜  /Users/zhouzhengxi/Programming/golang/src/github.com/zzxwill/kubevela git:(component-api) ✗ vela init
Welcome to use KubeVela CLI! We're going to help you run applications through a couple of questions.

Environment: default, namespace: default

? Do you want to setup a domain for web service:  poc.oam.dev
? Provide an email for production certification<EMAIL_ADDRESS>? What would you like to name your application:  cool
? Choose an workload for your component:  webservice
? What would you name this webservice:
? specify app image nginx:1.9.4
? specify port for container 80
Error: create app err: resource name may not be empty

➜  /Users/zhouzhengxi/Programming/golang/src/github.com/zzxwill/kubevela git:(component-api) ✗ vela init
Welcome to use KubeVela CLI! We're going to help you run applications through a couple of questions.

Environment: default, namespace: default

? What would you like to name your application:  yes
? Choose an workload for your component:   [Use arrows to move, type to filter]
> backend
  task
  webservice
Error: read workload type err interrupt

➜  /Users/zhouzhengxi/Programming/golang/src/github.com/zzxwill/kubevela git:(component-api) ✗ vela init
Welcome to use KubeVela CLI! We're going to help you run applications through a couple of questions.

Environment: default, namespace: default

? What would you like to name your application:

Message Do you want to setup a domain for web service doesn't prompt every time.
I learnt from the live broadcast by @wonderflow , it's by-design. Is there an option to reset the domain?
How about changing it to Set  a domain for web service? I was about to input yes for it.
As it's a very cool one command, how about making it simpler by removing What would you name this webservice? We can use the app name as the component name.

✗ vela init
Welcome to use KubeVela CLI! We're going to help you run applications through a couple of questions.

Environment: default, namespace: default

? What would you like to name your application:  cool
? Choose an workload for your component:  webservice
? What would you name this webservice:  cool-comp
? specify app image nginx:1.9.4
? specify port for container 80
Error: create app err: resource name may not be empty

Nits:
Let's do Welcome to use KubeVela, not Welcome to use KubeVela CLI

Synced with @zzxwill , he will improve the interaction flow of the "vela init", which I think it should be called "vela app init"

According to our plan, we will not work further on it


Images intermittently not loading on MacOS

I've been having a annoying problem with images sometimes not loading for a few minutes at a time.
I have a lot of tumblr RSS feeds that I follow, which I frequently encounter posts that embed multiple large gifs. The problem seems to be related to these. Sometimes these are slow to load. If I wait, generally they'll load and I can continue without issue. If I move to the next item in my feed before the images are loaded, I find that images will not load at all for any post. Going back to the first post which failed to load doesn't help. This continues for a while until it seems like a timeout is reached, and images suddenly start working normally again. I can also fix it by restarting NetNewsWire, but I find that the problem often immediately re-occurs when I do that, so it's not a very good solution.
It feels to me like there's an image loading queue that's getting clogged somehow? But I don't know if that's how the internal architecture of NNW works or not. I'm using the MacOS version 6.1.8, but the problem has been occurring for at least a couple point releases now. I'm not sure when I first noticed it; I want to say not more than 6 months ago and maybe as recently as 1 to 2 months.
Thanks for your consideration, and all the work you do!

The image loading in the article views is done entirely by the system — NetNewsWire code doesn’t play a role in it. If this is happening specifically with Tumblr, then it’s most likely a Tumblr issue and, unfortunately, not something we can fix.

Interesting. In that case, I think we can close this out. Thanks!


chore(sync): Update Zebra mainnet and testnet checkpoints - 13 July 2022

Motivation
Updating the checkpoints speeds up Zebra's syncing.
Solution

Update Zebra mainnet and testnet checkpoints on 13 July 2022

Review
This is urgent because we want it in the next release.
Reviewer Checklist

[ ] CI might not pass, because syncing needs other fixes

Follow Up Work

#4776 is also needed to make syncing work

#4776 is also needed to make syncing work

Not really from here, i synchronized the mainnet with the main branch locally. It was a slow process at the end (toke around 14 hours) but never hanged or crashed. I think the checkpoint update will help to make sync faster given the current block sizes we are seeing in the network.
Anyways, everything seems to point to a problem in the batches so i think your PR will maybe fix the underlying problem. I will take a look into it now.

This passed the CI we expect it to pass, so I admin-merged it.


"Conflicting field types" warning when a rich text field is empty (Gatsby 4 / Strapi 4)

Hi,
I have a collection with an optional rich text field. If there is at least one entry with the rich text not empty and an other entry with the field empty, Gatsby will display a warning and the field will be omitted from the GraphQL schema:
warn There are conflicting field types in your data.

If you have explicitly defined a type for those fields, you can safely ignore this warning message.
Otherwise, Gatsby will omit those fields from the GraphQL schema.

If you know all field types in advance, the best strategy is to explicitly define them with the `createTypes` action, and skip inference with the `@dontInfer` directive.
See https://www.gatsbyjs.org/docs/actions/#createTypes
STRAPI_XXXXX.yyyyy:
 - type: object
   value: { data___NODE: [Object] }
 - type: string
   value: ''

NB: The associated "textNode" field will still be generated.

@tms0 did you managed to fix it?
I have the same issue.
I have a component called Sections/TextSection. Using the component as an example, I get these results for the following query:
query MyQuery {
  allStrapiComponentSectionsTextSection {
    nodes {
      copy {
        data {
          copy
        }
      }
    }
  }
}

All fields with content
All copy fields have content: no errors. Output looks fine.
GraphiQL
{
  "data": {
    "allStrapiComponentSectionsTextSection": {
      "nodes": [
        {
          "copy": {
            "data": {
              "copy": "Must not be empty"
            }
          }
        },
        {
          "copy": {
            "data": {
              "copy": "Lorem ipsum"
            }
          }
        }
      ]
    }
  },
  "extensions": {
    "enableRefresh": "true"
  }
}

One field empty
At least one copy field is empty. An error occured and the build would break.
warn There are conflicting field types in your data.

If you have explicitly defined a type for those fields, you can safely ignore this warning message.
Otherwise, Gatsby will omit those fields from the GraphQL schema.

If you know all field types in advance, the best strategy is to explicitly define them with the `createTypes` action, and skip inference with the `@dontInfer` directive.
See https://www.gatsbyjs.org/docs/actions/#createTypes
STRAPI__COMPONENT_SECTIONS_TEXT_SECTION.copy:
 - type: object
   value: { data___NODE: [Object] }
 - type: string
   value: ''

GraphiQL
{
  "errors": [
    {
      "message": "Cannot query field \"copy\" on type \"STRAPI__COMPONENT_SECTIONS_TEXT_SECTION\".",
      "locations": [
        {
          "line": 4,
          "column": 7
        }
      ],
      "extensions": {
        "stack": [
          "GraphQLError: Cannot query field \"copy\" on type \"STRAPI__COMPONENT_SECTIONS_TEXT_SECTION\".",
          "    at Object.Field (/Users/###PATH_TO_PROJECT###/node_modules/graphql/validation/rules/FieldsOnCorrectTypeRule.js:48:31)",
          "    at Object.enter (/Users/###PATH_TO_PROJECT###/node_modules/graphql/language/visitor.js:323:29)",
          "    at Object.enter (/Users/###PATH_TO_PROJECT###/node_modules/graphql/utilities/TypeInfo.js:370:25)",
          "    at visit (/Users/###PATH_TO_PROJECT###/node_modules/graphql/language/visitor.js:243:26)",
          "    at validate (/Users/###PATH_TO_PROJECT###/node_modules/graphql/validation/validate.js:69:24)",
          "    at graphqlMiddleware (/###PATH_TO_PROJECT###/node_modules/express-graphql/index.js:98:38)",
          "    at processTicksAndRejections (internal/process/task_queues.js:95:5)"
        ]
      }
    }
  ]
}

Defining types leads to data: null
Trying to fix the error by explicitly defining the corresponding types leads to the fact that although there is no error, I don't get any data either.
GraphiQL
// gatsby-node.js

exports.createSchemaCustomization = ({ actions }) => {
  const { createTypes } = actions
  const typeDefs = `
    type STRAPI__COMPONENT_SECTIONS_TEXT_SECTION_COPY_TEXTNODE implements Node {
      copy: String
    }

    type STRAPI__COMPONENT_SECTIONS_TEXT_SECTIONCopy {
      data: STRAPI__COMPONENT_SECTIONS_TEXT_SECTION_COPY_TEXTNODE
    }

    type STRAPI__COMPONENT_SECTIONS_TEXT_SECTION implements Node {
      copy: STRAPI__COMPONENT_SECTIONS_TEXT_SECTIONCopy
    }
  `
  createTypes(typeDefs)
}

{
  "data": {
    "allStrapiComponentSectionsTextSection": {
      "nodes": [
        {
          "copy": {
            "data": null
          }
        },
        {
          "copy": {
            "data": null
          }
        }
      ]
    }
  },
  "extensions": {
    "enableRefresh": "true"
  }
}

Am I missing something in the type definition or something else?
Environment
Gatsby

Node 14.19.0
NPM 6.14.16
Gatsby 4.2.0
gatsby-source-strapi 2.0.0

Strapi

@strapi/strapi 4.1.7
@strapi/plugin-graphql 4.1.7
The database type does not seem to make any difference:

sqlite3 5.0.2
pg: 8.7.3

@thomaseckhardt I am having a similar issue. When setting up my createSchemaCustomization like you did with your types, I also received null values.
Instead of using the types in the documentation explorer I used the definitions on the left side of the /__graphql interface.
In your case that would change your code to:
type strapiComponentSectionsTextSectionCopyTextnode implements Node {
  copy: String
}

type strapiComponentSectionTextSectionCopy implements Node {
  data: strapiComponentSectionsTextSectionCopyTextnode
}

type strapiComponentSectionsTextSection implements Node {
  copy: strapiComponentSectionTextSectionCopy
}

Thanks for your interest in this project. This plugin is moving into the Gatsby User Collective and this repo will be archived. Please open an issue in that repository, submit a PR if you'd like to see this implemented, or join us on Discord if you have questions!


ARROW-10646: [C++][FlightRPC] Disable flaky Flight test on Windows

On Windows, gRPC sometimes gives us a blank peer address.

I did not as I haven't been able to reproduce it yet.

I see, thank you.

I'll merge anyway.


When a file is changed in two devices before syncing, does not merge

Hi,
If I try to sync between two devices a specific file that has been changed on both systems, then after syncing the changes of the last one are kept hence we have data loss. No merging is made (maybe is not needed) but it as second file with the suffix (-conflict) could be created in order to prevent the data loss.

The synchronization principle of this plug-in is to use the file modification time as the main basis. It cannot handle conflicts like git. Generally, the probability of multiple terminals modifying the same file at the same time is very low. Just set an appropriate synchronization time, so without thinking

Right.
I just synced today's note and already lost data.

Are there any bugs in using it?

Fine. Keep it for your self. Just uninstalled. Regards


use depcheck

Hi all,
This has been bugging me a bit,
we can use the depcheck instead of writng our own dependency check.
Thanks :smile:

p.s. this makes the deps check work on windows

LGTM

@noamokman you also want --ignore-dirs=build,dist. I'll add that


New sample for MiniTerm

Add new sample for MiniTerm

Use CsWin32 invoke PTY APIs
Using C# Process to manage child processes
.NET 8 as targetFramework
Support NativeAOT

@microsoft-github-policy-service agree

@microsoft-github-policy-service agree

@lhecker
Sorry, I found some mistakes in this example.  🥲
I will close this PR and modify the code.

Thanks! You are welcome to continue using this PR and this branch for your work. We would be happy to have your contribution! 🙂


Make / arrow keys navigate previous insertions in prompt buffers

Is your feature request related something that is currently hard to do? Please describe.
A certain Vim plugin I've come around (vimspector), is using prompt buffers. The UI of the "prompt"s doesn't feel like a "real" prompt's UI. If you'll take a look at prompts implemented using GNU readline, you'll notice that the main feature missing from Vim's prompt buffers is the ability to edit previous commands and navigating between them with the up/down arrow keys.
Describe the solution you'd like
I'd like the up/down arrow keys bound to navigate between previous "commands" I ran in the prompt. The UX I'm interested in is the UX that almost any prompt (even Vim's : prompt) implements.
Describe alternatives you've considered
Well I guess it should be possible to create sophisticated mappings for this but it seems this will be possible only if the prompt buffer's callbacks, insert the previous "commands" to a history file, as a start.
IMO Vim should handle this by himself, along with the mappings. Plugin authors shouldn't take care of that themselves because it's so natural to expect.
Additional context
\cc @puremourning

Reference https://github.com/puremourning/vimspector/issues/52
I too would like to see prompt buffers improved and I somewhat suspect they are not a widely used feature.
In many ways, a natural behaviour would be to have the exact behaviour and mappings of the command line, but rendered within the frame of the window. Perhaps I'm imagining a window-local command line, which becomes active when the user enters insert mode within a prompt-buffer. I suspect that's a significant amount of work, however.
To briefly explain the use-case, the prompt-buffer is being used to emulate a REPL (an evaluation loop with a debugger abstraction server). So, user enters insert mode, enters a debugger command or expression to evaluate, hits <CR> and Vimspector sends that command to the server, and prints the result in the buffer. I can see a use case for a 'command-buffer' where other REPL-like, or interactive interfaces could be implemented. I have seen a number of plugins attempt similar things with complex mappings, etc.
Thoughts from the community ?

For the record, I realise that the up/down behaviour could be implemented in vimspector with appropriate buffer-local insert-mode mappings, but I'd rather use pure features than complex additional UI complexity in the plugin, if that's at all possible.

What you describe is probably the todo item to add a command line history.  That would indeed work similar to the Vim command history, but only use the history of the prompt buffer.

For others, from :help todo
Prompt buffer:
- Add a command line history.
- delay next prompt until plugin gives OK?
- add prompt_addtext({buf}, {expr})	none	add text to a prompt buffer

I think you're right Bram that the original request is the "add command line history" entry, though i think what i suggested was more general, so that effectively your command-line mode mappings would also be in effect, and possibly even things like wildmenu and such (as i said, i realise this may be monstrously difficult, having not looked at the command line implementation).


feature request: lookahead and lookbehind

feature request: https://www.regular-expressions.info/lookaround.html

Hi @theo-dep - how did the lookahead/behind work out for you? Did you ever implement this?
As mentioned in #38 I am considering re-implementing the data-model, but it would require some rewriting.. I don't think I will be adding any feature in the near future. I have a lot on the program privately that limits my time available for it.

Hi, it is a long time ago, I do not remember if that code work 😅 and if I finally used it.
Do not worry, I am in other project now, I wish to thank you for the future work!


✨ [Feature] Auth supports session driver

Before feedback (在反馈之前)

[X] There are no features that I want to submit in Issues (当前 Issues 中没有我将要提交的新功能)

Describe Feature (描述功能)
Currently, Auth only supports JWT driver, we want to add the session driver since framework supports the session feature.

hey, I can try to take care of this issue

Sure, thanks!


#375: Show incomplete knockout results

Resolves #375

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.05%) to 88.465%

Totals

Change from base Build<PHONE_NUMBER>:
0.05%

Covered Lines:
5388

Relevant Lines:
5803

💛  - Coveralls


PT-1720 | Refactoring & cleaning up

Description :sparkles:
refactor: use HDS v3.7's breakpoints directly if possible
old breakpoint name (old breakpoint width) / new name (new width):

sm (768px) -> m (768px) = $breakpoint-m in HDS v3.7
md (992px) -> l (992px) = $breakpoint-l in HDS v3.7
xlg (1600px) -> xxl (1600px), a custom breakpoint, not in HDS v3.7

refs PT-1720 (cleaning up / refactoring after the fact)
refactor: make queryToString function faster, conciser & more readable
refs PT-1720 (cleaning up / refactoring)
refactor: remove header stylings as unnecessary (no need with HDS v3.7)
refs PT-1720 (cleanup / refactoring after the fact)
Issues :bug:
Closes :no_good_woman:
Related :handshake:
PT-1720
https://github.com/City-of-Helsinki/palvelutarjotin-ui/pull/304
Testing :alembic:
Automated tests :gear:
Manual testing :construction_worker_man:
Screenshots :camera_flash:
Additional notes :spiral_notepad:

kultus-ui branch is deployed to platta: https://kultus-ui-pr316.dev.hel.ninja :rocket::rocket::rocket:

TODO:

[ ] Update snapshots

kultus-ui branch is deployed to platta: https://kultus-ui-pr316.dev.hel.ninja :rocket::rocket::rocket:

@nikomakela @melniiv @jakezu This is now ready for code review, the rollouts are failing but there's a service portal ticket for that which you should be able to see.

@nikomakela @melniiv @jakezu This is now ready for code review, the rollouts are failing but there's a service portal ticket for that which you should be able to see.

Is the readiness probe checked from the wrong path (again)?


Prepare for new release of Bitbucket

Workflow links: https://github.com/atlassian-labs/atlassian-slack-integration-server/actions/runs/1754442939, https://github.com/atlassian-labs/atlassian-slack-integration-server/actions/runs/1754442939.

Integration tests passed, so current version 3.0.4 was marked as compatible with Bitbucket 7.20.0.


How to config CkFinder in HtmlContentEditor

Dear All Pro,
I tried many times configuring CKFinder into HtmlContentEditor but it's really different from the regular MVC I did.
Specifically with regular Mvc, I can easily configure:

For Serenity, I can only use the attribute [HtmlContentEditor] or custom with [MyCustomHtmlContentEditor], and the result looks like the image below:

I am really having trouble, please share me your way. Thank you!
@volkanceylan please help me!

Hi @huynhvanquy ,
what exactly do you want to achieve?
Do you just want to have an action button after that text field?
With kind regards,
John

Hi @huynhvanquy ,
what exactly do you want to achieve?
Do you just want to have an action button after that text field?
With kind regards,
John

Hi @JohnRanger
I want to upload image, file in CKEditor (using CKFinder or other). Now, i only upload image from url. Thanks!

Share for those who are in need!

@huynhvanquy Did you made it? I also create a MyCustomHtmlContentEditor.ts like yours. So i also need to put ckfinder under Script filefolder?
I download the ckfinder from this url https://ckeditor.com/ckfinder/download/#net

I got an error like below. What should I need to change?


Add external vision to EKF2 and EKF2 replay

Added external vision messages to replay logging and play them in ekf2 replay

Ah! This is failing here because other changes to enable pushing vision position estimate data into ekf2 are not in here. I'll add them.

This PR needs the visionSupport branch from ECL. That is why it fails.

@devbharat Looks good in general! Can you provide us with a log so that we can try the replay and then merge this?

@tumbili I shared logfile with you on Skype last week.

@devbharat Can you do this a little less obscure, e.g. in an email to Paul and Roman and/or a direct link here to Google drive or Dropbox?

Try this link for the log file with the replay message. The vision messages are logged under RPL5.x RPL5.y RPL5.z RPL5.yaw. I'd say that the logged vision positions are very very close to ground truth and EKF2 should be tuned to agree to them strongly.

I don't know why the sit test is failing. Its not a build error, and is only failed after I updated the branch from master.

Jenkins test this please

@priseborough @tumbili Can you help to get this in?

I can when i have received a replay log to test this on. All i can do at the moment is verify that it hasn't broken the default behaviour.

@Paul I've added a link to the replay log with vision in the message above. It's a public Google drive link.

@devbharat You haven't yet added the code required to set the the external vision system position and yaw angle 1-sigma observation error estimates . The default value of 0.01 does not work.

I have changed the defaults t 0.1 and updated the ecl reference here:
https://github.com/PX4/Firmware/tree/pr-ekf2VisionSupport

I'll eventually add a mavlink message to communicate the covariance matrix next week.

@devbharat Unfortunately due to the merging of of https://github.com/PX4/Firmware/pull/4518 this PR now has a number of conflicts that need to be resolved. Can you please have a look at them. TXS.

Should work now

Flight test results with default parameters (GPS, Baro and Magnetometer fusion) here:
http://logs.uaventure.com/view/wfws8hYiuZJMF8rMxnaCRT

We need to get this PR rebased and merged as it is holding up support for EV fusion tuning

I've pushed a rebase of this to here: https://github.com/priseborough/Firmware/tree/px4_push_ev_Ekf2_replay
Can someone please verify that it can log and replay EV data.

I just tested it. It played the replay file fine. I've not analyzed the replayed file itself.
Both the original replay file and the created "replayed" logfile are available here. It's a public link.

@devbharat Was that log recorded using the rebased branch?

It was from 3c968f32a532a1c05eb8343f0f34c0c5fe05e24f

The EKF2 parameters on your board are out of date then.

The replay.px4log file was the same old one. The replay_replayed.px4log is the replayed file using the commit I mentioned above. I do not have the hardware running to really collect a new dataset right now.

When can you have that running? The testing is incomplete until that can be done.

@devbharat Looking at the replay results, the method you have used to only log the yaw data and then convert it back to a quaternion assuming zero roll and pitch inside ekf2_replay_main.cpp is causing problems with gimbal lock and needs to be changed to logging the whole quaternion. The EKF converts the EV quaternion internally to a yaw angle using either a 321 or 312 Euler sequence depending on the orientation of the vehicle, and it is not practical to replicate this functionality inside ekf2_replay_main.cpp.
I have also spotted a rebase error in sdlog2.c
I will push fixes for these to my branch for you to test when you get your setup working.

@devbharat I have pushed updates for the logging and replay to my branch:
Fixes the rebase error
Logs the quaternions for use in the replay
Logs the error estimates for use in the replay

I'll try to get a handheld dataset tomorrow.

@devbharat Given I am now the person working on this PR, it makes more sense for it to reference the branch where i can update it as required. I will open a new PR referencing a branch in origin and close this one if that's OK with you.

No problem.

@devbharat what was the intended use of the EKF2_MIN_EV parameter?

Closing this and replacing with https://github.com/PX4/Firmware/pull/4647


Call new talker function on item select

This would allow better support for talkers lacking all the information required for the GUI in their "list" API calls. Such as not returning the image URL, description, publisher, etc.
It may be advantageous to add a "complete" to the series table too.

In general the Talker should just make the extra call to the api.

In general the Talker should just make the extra call to the api.

If you mean at search or series list time, that can result in a lot (hundreds, possibly thousands) of unneeded extra calls and extended waits times into the minutes. It's the same as loading all the cover images before they are required. To be respectful to the API, fetching additional data as needed (for a small list with auto-tagging or when selected in the GUI) seems like a sane approach.

I've added a complete field to ComicSeries. This will prevent the possibly of every time a series is selected in the GUI that a new fetch from the API is triggered.
I'm not sure there is another way around doing something like this for the GUI when supporting multiple APIs. The only other option I see is limiting the results for series and issues and then having next/previous buttons.
An extreme example of having to make thousands of additional API calls would be 2000 AD which has 2335 issues currently.

What is the difference between using these new functions to get the individual series and issue info and calling the existing functions that do the same thing?

I'll give a couple of examples:
Metron:
search_for_series is run (GUI and CLI) and will not return an image for the series. To get an image (usually the first issue) would require an additional call to list all the issues. That would be 1 extra call for each item in the search result (which is capped at 500) that a user may never select and see.
fetch_issues_by_series (GUI only function) fetches the issue list but the API call does not return the issue title or the description. A call for the full issue information will (and the talker should cache it too so if that is selected for tagging no new API call is required). Again, this would be upto thousands of calls for the descriptions that may never been needed.
MangaUpdates:
The publisher is missing from search and requires another call for each series item to populate.
GCD (Not an API but still represents the issue)
The issue list is missing the image URL. For each issue in the issue list a single scrape is required. A single scrape takes about 1-2 seconds and so would add up quickly.
When it comes to issueidentifer which uses search_for_series and fetch_issues_by_series_issue_num_and_year the extra calls aren't required. For search_for_series as it's only a title and fetch_issues_by_series_issue_num_and_year will have to do these additional calls but shouldn't be as much of a problem as the number required will be limited via the issue number. There is also no way around the extra calls as the information is required for ii to work.
Hopefully that makes it clearer that the additional functions will not do the same as any of the current functions. In a general sense all "search" and "issue list" API calls return a limited subset of information and a single API to a different endpoint returns all available information which may be wanted for the GUI (CV excluded because CT was built around its information). Taking into account possible API call limits (just 1 every second for example) and delays of many minutes for information that the user will never require would not be out of the norm.
An argument about how much it matters if there is missing information can be made but then you could say the same about loading the cover images etc. An issue list with only the issue number and nothing else is not a great user experience and people using the GUI you would imagine want to see the information. Although only filling it in when someone clicks on an item isn't the best, it seems like the best middle ground.

So that's not the direction I was trying to go in, what I meant is what information does fetch_additional_issue_info_on_click provide that fetch_comic_data doesn't and why wouldn't we just add that information to fetch_comic_data

So that's not the direction I was trying to go in, what I meant is what information does fetch_additional_issue_info_on_click provide that fetch_comic_data doesn't and why wouldn't we just add that information to fetch_comic_data

Should be with you now. fetch_comic_data returns GenericMetadata. A similar function fetch_full_comic_data to return ComicSeries | ComicIssue and do so based on series_id and issue_id could be added:
    def fetch_full_comic_data(
        self, issue_id: str | None = None, series_id: str | None = None
    ) -> ComicSeries | ComicIssue | None:
        comic_data = None
        if issue_id:
            comic_data = self._fetch_issue_data_by_issue_id(issue_id)
        elif series_id:
            comic_data = self._fetch_series_data(int(series_id))

        return comic_data

The series_id and issue_number was left in fetch_comic_data as a "maybe" fallback but with how CT works now, there should never be an instance where the issue_id is unknown.
Is this more where you intended?

Ok, so ignoring ComicSeries for the moment what does fetch_full_comic_data provide that fetch_comic_data doesn't and why wouldn't we just add that information to fetch_comic_data

Ok, so ignoring ComicSeries for the moment what does fetch_full_comic_data provide that fetch_comic_data doesn't and why wouldn't we just add that information to fetch_comic_data

As mentioned, it returns GenericMetadata when ComicSeries/ComicIssue is needed because the current list of ComicSeries/ComicIssue will be updated with the information.

Ok, so what does ComicIssue provide that GenericMetadata doesn't and why wouldn't we just add that information to GenericMetadata

Ok, so what does ComicIssue provide that GenericMetadata doesn't and why wouldn't we just add that information to GenericMetadata

I think we both may be getting lost here.
Everything comic talker related is in ComicSeries and ComicIssues, going to and from the cache, to issueidentifer, the GUI windows etc. until it's ready to be sent out into the taggerwindow fields/saved and then it's converted GenericMetadata. If GenericMetadata was used it would then have to be converted back to ComicSeries/ComicIssue because the series window and issue window use them respectively. So it would go: CV -> ComicIssue -> GenericMetadata -> ComicIssue to update the list[ComicIssue] used by the issue window.
I feel like I should be seeing something obvious but I can't? It's the same "data" but formatted in different ways.


Update get_micro_data.py

OG-USA needs to be updated to account for the separation of PT income from ordinary income in TC (via PR #913).  The more recent PR #987 now allows this to be done properly.

Fixed via PR #246


DependencyChecker with tests

[x] Introduce DependencyChecker which can determine if any dependencies have been modified.
[x] Move the DartDependencyBuilder into a separate file.
[x] Add unit tests for DartDependencyBuilder.
[x] Add unit tets for DependencyChecker

Part of #7014
@Hixie @tvolkert @cbracken

LGTM, pending Travis results (it was failing before)


Logging plugin

Show prev state, action, and next state (like the redux logger)
Show origins, patches, and effects (something that redux can't do)

https://github.com/prodo-ai/prodo/pull/44


Make it an installable NPM module

Adding this issue to track the feature branch that enables EyeGlass support.

Fixed in v0.1.3 -- https://github.com/NYPL/design-toolkit/commit/1d31970c625353fc4ce631283496db207593a1a3
It is now an installable NPM module, see installation docs.


[Snyk] Security upgrade sails from 0.12.14 to 1.5.12

Snyk has created this PR to fix 4 vulnerabilities in the npm dependencies of this project.
Snyk changed the following file(s):

package.json
package-lock.json

Vulnerabilities that will be fixed with an upgrade:

Issue
Score

Regular Expression Denial of Service (ReDoS) SNYK-JS-PATHTOREGEXP-7925106
  738

Asymmetric Resource Consumption (Amplification) SNYK-JS-BODYPARSER-7926860
  696

Cross-site Scripting SNYK-JS-SEND-7926862
  391

Cross-site Scripting SNYK-JS-SERVESTATIC-7926865
  391

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
Max score is 1000. Note that the real score may have changed since the PR was raised.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Regular Expression Denial of Service (ReDoS)
🦉 Cross-site Scripting

A descrição do pull request não atende aos critérios estabelecidos. É importante que a descrição explique claramente o motivo da mudança e inclua um passo a passo para testar o pull request. Escrever uma boa descrição de pull request é essencial para facilitar a revisão e compreensão das alterações realizadas.
Esse comentário foi gerado por inteligência artificial


Server doesn't seem to be running at all on M3 mac. Empty server logs.txt and app logs showing "ERROR SearchState.syncTags():164 - failed to sync tags: Could not connect to the server."

Hi,
I've installed unlost.ai and given it all the relevant permissions, etc. on my M3 Mac Pro. I've been running it for over 8 hours with both Screen Capture and Meeting Capture enabled and I can see it has a large amount of recordings in the recordings folder. However, there are absolutely no results when I search anything and no autosuggestions when I type @ for example.
Looking at the logs in UnlostApp.nosync, the logs/server/logs.txt file is completely empty. In the logs/app/<date>.log.txt, I consistently see the error: "ERROR SearchState.syncTags():164 - failed to sync tags: Could not connect to the server.".
This leads me to the conclusion that the actual Unlost backend/server is not running at all for some reason. I'd really love to get this running. I'm leaving it running for now in the hopes that when there's a fix and the server runs correctly, I will then be able to search through all my current recordings.
Any help? Not sure what's gone wrong. I've also tried removing and reinstalling unlost but that didn't help.
Thanks in advance,

Same issue here