jami-xml

General workshop guidance

jami-xml

[ ] README.md
[ ] Test coverage
[ ] Java example

It has some schema documentation for 3.0, maybe would be a good idea to have one for 2.5 too. https://github.com/MICommunity/psi-jami/tree/master/jami-xml/documentation/schema

Test coverage for jami-xml

Some tests are marked as @Ignore. The reasons behind need further investigation.


Create UNIQUE INDEX on many2many incorrectly

GORM Playground Link
https://github.com/go-gorm/playground/pull/81
Description
According to the log, gorm tried to
CREATE UNIQUE INDEX "idx_t01_t02_binds_name1" ON "t01_t02_binds" ("name1")
CREATE UNIQUE INDEX "idx_t01_t02_binds_name2" ON "t01_t02_binds" ("name2")

But it shouldn't be UNIQUE, or it's not many2many.

Hi @jinzhu , can gorm create index but not unique?

Hi @StephanoGeorge
It is better to create a composited index in this case, I think maybe you should change Name as the primary key to create a composited primary key(index) or customize the join table to create indexes as you want. http://v2.gorm.io/docs/many_to_many.html#Customize-JoinTable

OK thanks, but I meant:
CREATE INDEX "idx_t01_t02_binds_name1" ON "t01_t02_binds" ("name1")
CREATE INDEX "idx_t01_t02_binds_name2" ON "t01_t02_binds" ("name2")

Because it is still very frequent to search for related objects based on the primary key of an object, like:
select name2 from t01_t02_binds where name1 = '1'

But If you think this is unnecessary(I can customize the association table to specify the index), that's it.

Hi, I think it is better to use the name column as primary key, if it is defined as the primary key, databases will create the index for it by default.

BTW, you can create create unique index with tag index like index:",unique", so we can't not include the index tag when creating the join table.


Operations sorting order for the "mixin" in CLI

Problem statement
Is there any way to set a sort order for paths in the resulting document for the mixin when using CLI? Something like this:
swagger mixin /o CombinedOutput.json /sort tags_desc headers.json http://url1.my.com/swagger/swagger.json http://url2.my.com/swagger/swagger.json
At least, in my case, it would be enough if it had preserved the order defined in the command and sources, but it hadn't. It sorted all paths in mixed alphabetical order.
Thanks,

not at the moment, I fear: operations are a map, so the scanning order is lost by the go map. We have a similar issues with properties, for which some x-go-order extra has been added, but not for operations.


fix: allow to override config file name with -X ld flag

Motivation
adrgen.config.yml is very prominent in the top level repository folder estate for an auxiliary tool.
Users may want to change that, for example, to a more subtle .adrgen.yml.
Proposed solution

Change constant to variable so that people can use "-X github.com/asiermarques/adrgen/internal/config.FILENAME=.adrgen"

Successfully proto-using it here. The sooner this can be merged & released the better :wink: — Thanks in advance!

@asiermarques Hey, would you be interested in merging this?


Mypy improvements for lazy_load

Following up on my previous MR ( https://github.com/getmoto/moto/pull/7045 ), here's what it looks like to get XRaySegment back on moto.lazy_load. It's a little bit of a funky overload, and I also enabled warn_unused_ignores in mypy so that I could construct a negative test for the typing on XRaySegment.
I won't mind if you decide not to take this MR, but I wanted to see if it could be done, at least.
Edit: warn_unused_ignores made mypy's approval more fragile than I realized. I walked that back to be just for test_mypy.py, and put back in some of the ignores that I had originally removed. I kept in the removal of a lot of them though, since I think they're genuinely no longer needed.

Actually I think this solution is not very elegant, and I'll just close this unless I hit on a better way to handle it.

Thanks for looking into it regardless @tungol!
FWIW, the current solution doesn't bother me that much. It is a special usecase after all, quite different from the regular mock_service-decorators, so it makes sense to me that the typing approach is also different.


Publish in PyPi

The mlserver package is currently not published in PyPi. This leads to work arounds (e.g. pip install git+github.com/SeldonIO/mlserver) which are not ideal.

Fixed by #78


Shrinking with flatMap

To what should I shrink with flatMap? Say I have this generator:
jsc.nat.generator
    .flatMap(n => {
        const t = Array(n).fill(jsc.nat.generator);
        return jsc.generator.pair(jsc.generator.constant(n), jsc.generator.tuple(t));
    })

How does my shrink work? Is it only a nat shrink or something else?

You have to write that yourself unfortunately.
One simple solution is to shrink the contains of the "tuple", but keep n fixed.
Side-note:
jsc.array.generator.map(arr =>
  [arr.length, arr]
);

I.e. I very rarely need to rely on flatMap: map and combine are often enough (only exception: generation well-typed lambda calculus terms, but that's quite advanced need, IMHO).

Ok, thanks


Fix a number of performance issues (reported by Coverity Scan)

The latest scan reported a number of performance issues because
several for loops used expensive copy operations.
After adding the const attribute to compare operators, const
could also be used in most for loops.

The fix is not very right.
for (auto && should be used instead.

I did not know auto && up to now, and it is currently used only once in Tesseract code. Why would it be better than const auto &?

auto && means auto when we have a simple value.
auto && means auto & when we have a reference.
auto && means const auto & when we have a const reference.
auto && means auto && when we have && reference.
In other words auto && selects right thing for you.
If you set auto & and then for some reason you change iteration range to const, you need manually fix all places. With auto && you are already set.

In other words auto && selects right thing for you.

That's indeed a nice feature, but an explicit const attribute has also advantages because it helps human readers and detects missing const attributes like the ones in the compare operators. Therefore I'd prefer to use const where it is possible.
So how should we fix the reported performance issues? Use auto && instead of auto & and keep the const auto & cases? Or use auto && and const auto &&?

but an explicit const attribute has also advantages because it helps human readers and detects missing const attributes like the ones in the compare operators

When you will be updating code const->non const you'll have to fix all places again.

So how should we fix the reported performance issues?

auto &&

Use auto && instead of auto &

Almost always auto &&. There are some rare cases when you have pointer and want explicitly use auto or auto *.

and keep the const auto & cases?

While refreshing codebase all such cases must be changed to auto &&.

const auto &&?

Did not see const auto && usages anywhere. Do not sure exactly what is it and how it works. Do not use it.
It can mean const auto &.
But also it may mean copy as in raw auto which is bad.

So, we should use auto && everywhere (almost).

I updated the PR now to use auto && (although I still think that const auto & has advantages, too).

thanks

https://stackoverflow.com/questions/26541920/is-it-a-good-practice-to-use-const-auto-in-a-range-for-to-process-the-element
https://stackoverflow.com/questions/29320575/whats-the-difference-between-and-in-a-range-based-for-loop
https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2014/n3994.htm
https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2014/n3853.htm


please add signature for message namespace with options

See https://github.com/aspnetboilerplate/abp-ng2-module/issues/50

Done via https://github.com/aspnetboilerplate/aspnetboilerplate/pull/4525


Improved type definitions for JSON api responses

Search Terms
fetch body json generic
Suggestion
There are actually two suggestions here that would work together. I'll present them separately.

A generic version of the json() method on a fetch Response with the following signature: json<T>(): Promise<T>.

A Json<T> type that is equivalent to T only if T contains properties that can be represented as valid JSON. Implementation below. The main thing here is to enforce that any properties of type Date in T are correctly mapped from a string in order to convert Json<T> to T.

Use Cases
The use cases for both features are pretty much the same so I'll deal with them together.
When fetching data from an API we create types to represent the data that is being returned. For example, say we have the following type:
type Foo = {
    name: string;
    date: Date;
};

And we want to fetch one from an API then we'll write a function like so:
async function getFoo(): Promise<Foo> {
    const response: Response = await fetch('https://example.com/foo');
    return await response.json();
}

The problem here is that elsewhere in the application if we try use the date property on a Foo then it won't actually be of type Date, but most likely will be a string because that is how it is often represented in JSON. This leads to runtime errors, usually along the lines of some Date method being undefined for string.
Obviously we could put this down to bad programming and recognise that we should create some type to represent the data that's actually being returned from the API, for example:
type FooDto = {
    name: string;
    date: string;
};

and then update the API function to be:
async function getFoo(): Promise<Foo> {
    const response: Response = await fetch('https://example.com/foo');
    const foo: FooDto =  await response.json() as FooDto;
    return {
        ...foo,
        date: new Date(foo)
    };
}

However, it places a large burden on the developer when this needs to be done for many types and it is still error prone if the developer forgets to create the DTO type.
In our projects we have found a better way to mitigate this problem by defining a Json<T> type like so:
export type Json<T> =
    T extends Date ? string :
    T extends Array<(infer U)> ? JsonArray<U> :
    T extends object ? { [K in keyof T]: Json<T[K]> } :
    T;

interface JsonArray<T> extends Array<Json<T>> { }

We can then define a function get<T> along these lines:
async function get<T>(url: string): Promise<Json<T>> {
    const response: Response = await fetch(url);
    return await response.json()
}

And so our implementation of getFoo becomes:
async function getFoo(): Promise<Foo> {
    const foo: Json<Foo> = await get('https://example.com/foo');
    return {
        ...foo,
        date: new Date(foo)
    };
}

Basically, the upshot of having the type Json<T> is that it is now not possible to forget to supply the mapping from Json<Foo> to Foo because in this case a Json<Foo> is not directly assignable to Foo due to the Json<Foo> knowing that the date property is actually a string in the Json payload. Furthermore, there is no longer a need to mandate that a DTO type be created for every object (or every object that contains a Date property). This leads to code that is therefore less prone to errors.
From our perspective it would therefore seem to make sense if something along these lines was incorporated into lib.d.ts. Our suggestion is therefore to add the Json<T> type definition and update the json() method to have the signature json<T>(): Promise<Json<T>>.
However, we obviously realise that there might be some reservations with this implementation. The main points that spring to mind are:

Can we assume that all dates are represented as a string in a JSON payload? This certainly seems like the most common representation, but I'm sure there will be others out in the wild.
Are there other complex types like Date that suffer from this problem?
Obviously none of this prevents developers from having type mismatches between the client and server.

To give my two cents on this, I think that the solution proposed does not prohibit someone from just calling json<any>() which would effectively give them the existing behaviour, and in fact for backwards compatibility it would probably make sense to default the generic argument to any so that existing code of that didn't specify the generic argument would still be valid. Essentially, I think that this proposal enhances the types for most cases without regressing things in the other cases.
Anyway, I hope this can at least form the start of something useful that can be included in lib.d.ts to improve the typing of data returned from an API.
Checklist
My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

Obviously none of this prevents developers from having type mismatches between the client and server.

This is exactly why I'm against this proposal

This is exactly why I'm against this proposal

That would be ideal, but it doesn't seem possible to solve with Typescript alone as they don't 'Add or rely on run-time type information in programs, or emit different code based on the results of the type system.'
This proposal seems more about trying to improve the type definitions for the response.json() function. Currently the definition is json(): Promise<any>;, with the any allowing a cast to any other type. However, we already some situations where that cast would be wrong, due to json not supporting those value types (e.g. Date). By adding a type overload of json<TExpectedResponse>(): Promise<Json<TExpectedResponse>> the consumer of .json() would know when their type is inaccurate.
As far as I know, the primitive types which json doesn't support are Date, undefined, and function. It seems like both undefined and function get removed when serialized, and so it might be worth returning the never type for these cases. I.e
export type Json<T> =
    T extends Date ? string :
    T extends undefined ? never :
    T extends Function ? never :
    T extends Array<(infer U)> ? JsonArray<U> :
    T extends object ? { [K in keyof T]: Json<T[K]> } :
    T;

interface JsonArray<T> extends Array<Json<T>> { }

or filtering them out from the resulting type.
I think this proposal would be especially helpful as it's an incorrect type when fetching data, where we already don't have much type information. Helping to prevent people from having runtime errors by calling date functions on a string seems extremely worthwhile.

Counter proposal, json() : Promise<unknown>

I think there are two points emerging here that are worth picking apart.

No one has any guarantee at runtime that the data coming off the wire is going to match what they expected when they declared their types.
Json is not as complete as JavaScript in the types it can represent (Date being the obvious example).

Obviously you seem very concerned about point 1, and rightly so it's a source of many mistakes.
However, this proposal is really about addressing point 2. I put the following caveat:

Obviously none of this prevents developers from having type mismatches between the client and server.

in because I wanted to make it clear that I was not trying to address point 1 with this proposal.
You are right that the data is unknown coming off the wire, but to get any benefit out of TypeScript we have to assign a type to this data at some point. Your proposal would make it mandatory for developers to perform an explicit cast to their type, but it still doesn't do anything to help them make sure they've done this correctly. What we're proposing here is a way to provide the developer with some compile time checks around the types of data they can expect to receive in a JSON payload, such that if their target type cannot be represented in JSON, as they have defined it, it would have to be mapped.

Use a type validation/data mapping library like,

https://github.com/gcanti/io-ts
https://github.com/pelotom/runtypes
https://github.com/anyhowstep/type-mapping
https://github.com/hapijs/joi
etc.

Adding <T> is just adding a hidden cast. Whether you're casting to a JSON object or some other object, a cast is a cast.
With a data mapping library, it won't even really matter what the actual response is.
The data mapping library will map the string value to a Date value.
You don't have to restrict yourself to just "valid JSON types"

As noted, there are some very nice libraries available these days for enforcing (yay!) the shape of JSON data off the wire, as well as some options for generating .d.ts from a JSON schema.
In terms of adding this definition to the library, we think this kind of definition best belongs in user space as people tend to have a lot of different opinions about what constitutes valid and what doesn't. On balance the overall gained value is IMO not that great since the restrictions around which types are JSONable and which aren't isn't that hard to internalize.

@RyanCavanaugh thanks for your response, and all the great work that you do on Typescript!
It seems like there are two scenarios:

The ideal scenario: people use a type validation library, and json() : Promise<unknown> is the return type.

People do implicit casts from response.json() to their domain types.

I actually agree with @AnyhowStep's proposal to change the type to json() : Promise<unknown>. However, I imagine that the Typescript team would be reluctant to change it, as it would be a breaking change for the users doing implicit casts to their domain types.
Given these users doing an implicit cast already, it seems like it would benefit them to show where the type they are trying to cast to is impossible, given the json spec. It seems like the original mapped type was too opinionated as to date serialisation. If it was instead:
export type Json<T> =
    T extends Date ? unknown : // instead of string
....

this would be agnostic of how they serialise their Dates, but also show them that the type they are expecting is impossible.

the restrictions around which types are JSONable and which aren't isn't that hard to internalize

I agree that the restrictions aren't hard to internalise (if you know they exist), but I also doubt that developers always check their domain models for any dates before casting.

@richthornton I agree with your points and that whilst it's not hard to internalise the JSON spec, one of the main advantages of a type system is that it puts knowledge back in the world rather than requiring it to be in the developer's head. Even small amounts of individual knowledge eventually accumulate over the size of an entire program.
From the JSON spec do you not think the following definition would be more correct?
export type Json<T> =
    T extends boolean | number | string | null ? T :
    T extends Array<(infer U)> ? JsonArray<U> :
    T extends object ? { [K in keyof T]: Json<T[K]> } :
    never;

interface JsonArray<T> extends Array<Json<T>> { }

As we know that JSON can never represent anything except these primitive types, or arrays and objects of them.
I respect the original decision to close this issue as I understand the conservative viewpoint of the TypeScript team, but I just wanted to include this for posterity.


Improved humanoid walking example

Adds "experimental" behaviors for the humanoid including:

robust walking with gait options
handstand
flips

Fixes quadruped hill task.

The behaviors can still be improved, but this code is ready for review.


Support location in bq operator

Set Job location for non-US location.
Fixes #1088

@yoyama can you review this PR?

@tkawachi Thank you for your contribution.
I left comments, please check them.
In addition, adding integration tests is preferred.
https://github.com/treasure-data/digdag/blob/master/digdag-tests/src/test/java/acceptance/td/BigQueryIT.java

Thank you for your review, @yoyama.
I have added the integration test, but for the extract and load tests, the location of the BigQuery and GCS bucket must match. Currently, I suppose US bucket is set as GCS_TEST_BUCKET, but in addition to this, bucket of other location is needed.
If you can create the bucket for me, I will write an integrated test for extract and load. Since we used asia-northeast1 in other tests, a bucket for asia-northeast1 might be desirable.

@yoyama I wrote tests for load and extract. It assumes that GCS_TEST_BUCKET_ASIA is in asia-northeast1, not asia (BigQuery can't be located in asia).  Where can I check the test result of CircleCI?

@tkawachi I pushed your PR to digdag repo to run CircleCI.
It failed as follows.
https://app.circleci.com/pipelines/github/treasure-data/digdag/718/workflows/237633a7-4be4-4697-8e66-45195f1505b3/jobs/4699/parallel-runs/1?filterBy=ALL
Could you confirm it ?

@tkawachi I add a minor comment. Could you confirm it ?

I updated the docs. I didn't change bq_ddl.md since it already mentions about location.

Hello @tkawachi
Thank you for your great PR and contribution to digdag!
We are really appreciated with your efforts.
We would like to deliver some TD/Digdag swag to you as a token of our appreciation.
If you don't mind, could you fill your address in the following Google form? So that we can send to you.
https://forms.gle/37jhNBFJo9kyLvLx9


Buf1 or Buf2 Wrong Folder

One of the "Bufs" is ordering folders incorrectly, causing the pipe to move up and down and the bird to split. On Buf1 the pipes float and the bird splits in half. I use the latest version of MacOS Monterey.
.

Hi! You need to navigate into both buf1 and buf2 and sort the folders by "Date Modified" - see the README

The folders are sorted by "Date Modified", maybe I could try setting it up again?

Are you sure they're sorted by Date Modified right now? The little "Up" chevron (to the left of Date Modified) makes me think that they're sorted by the first column instead.
I don't know what "Today" means in the first column - I see "Name" there instead. So maybe you have a different finder setup.

YES YES YES YES! IT WORKS!

"Date Modified" is to the right of the folders in "Buf1" and "Buf2". You must have the carrot facing upwards, (the carrot is hidden until you click the "Date Modified" carrot.


Remove container after failure with --force-rm

Fixes #6757

+1 for an update on this one.
Don't mind if it ends up as a --force-rm flag to "really mean it", as opposed to changing the original --rm flag, as per historical intentions (see https://github.com/docker/docker/issues/6757#issuecomment-47715711). But having some sort of flag to actually do the thing would be very helpful.


Extend constant bit-width

Describe your feature request.
32-bit is too less for signed-constant in many applications.
Describe the solution you'd like
Change the internal variable data type from int to, for example, int64_t.
Additional context
Test with nibbler wrapper generation and LMAC generation.

One more thing on this, the current verilog-generation will need modification to handle this widening.
Please ping me if the changes are going to be merged...

Also, Huaixi notified me another issue in verilog-generation, about handling negative numbers (this is sometimes unavoidable, as BvConst uses the signed int for storage, even if someone writes in 2's complement when using the APIs, it will be converted to a negative number internally if it is wide enough) I'm not sure what's the opinion on using the signed number there, but I'm planning to add the conversion to 2's complement in verilog-generation.

The change will be made in branch/PR #156
Currently, I'm changing bit-vector values to int64_t, but can be easily changed to uint64_t or size_t.
Seems like most of use cases don't need the signed feature, shall we change it to the unsigned version?

It would be slightly easier for the verilog generator to handle just the unsigned case. But one more question, is there a range check in ilang::BvConst?

Then let's change to the unsigned version.
No checking now - can add it as well

Okay, thanks!

BTW, would you like me to commit to issue-154 or start a new branch for updating verilog-gen?

Same branch may be better, since they are correlated?

Okay, no problem.


Fix arm64 downloads for HashiCorp tools

Description
Fix arm64 tool downloads in arkade get.
This change currently includes terraform and packer.
(These are the tools that we offer and have arm64 binaries.)
Motivation and Context
We should try to find a mechanism to properly test tool downloads on different architectures.
(Currently there is an issue for that #557.)
Until that we have to patch every tool by hand, to avoid issues like #564.

[ ] I have raised an issue to propose this change, which has been given a label of design/approved by a maintainer (required)
[x] Issue #564 and https://github.com/alexellis/arkade/issues/564#issuecomment-955524650

How Has This Been Tested?

[ ] Yes
[X] No

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Documentation

[ ] I have updated the list of tools in README.md if (required) with ./arkade get -o markdown
[ ] I have updated the list of apps in README.md if (required) with ./arkade install --help

Checklist:

[X] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I've read the CONTRIBUTION guide
[X] I have signed-off my commits with git commit -s
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

[X] I have tested this on arm, or have added code to prevent deployment

@jsiebens do Hashicorp have a URL for downloads that we can use to find the latest release version? See also: #560
cc @nicholasjackson

Terraform, yes there is an API, other tools have a version checker api i think. Let me dig

Wow, these notes are so good, this link should have everything you need. I'm not at my computer so can't check but this looks great to me.
https://sleeplessbeastie.eu/2021/02/12/how-to-check-the-hashicorp-software-version/

In hashi-up I'm using this resource to get the latest versions:
https://releases.hashicorp.com/index.json


chore(deps): update node.js to v10.20.1

This PR contains the following updates:

Package
Type
Update
Change

node
devDependencies
minor
10.19.0 -> 10.20.1

Release Notes

nodejs/node
v10.20.1
Compare Source
Notable changes
Due to release process failures, Node.js v10.20.0 shipped with source
and header tarballs that did not properly match the final release
commit that was used to build the binaries. We recommend that Node.js
v10.20.0 not be used, particularly in any applications using native
add-ons or where compiling Node.js from source is involved.
Node.js v10.20.1 is a clean release with the correct sources and is
strongly recommended in place of v10.20.0.
v10.20.0
Compare Source
macOS package notarization and a change in builder configuration
The macOS binaries for this release, and future 10.x releases, are now
being compiled on macOS 10.15 (Catalina) with Xcode 11 to support
package notarization, a requirement for installing .pkg files on macOS
10.15 and later. Previous builds of Node.js 10.x were compiled on macOS
10.10 (Yosemite) with a minimum deployment target of macOS 10.7 (Lion).
As binaries are still being compiled to support a minimum of macOS 10.7
(Lion) we do not anticipate this having a negative impact on Node.js
10.x users with older versions of macOS.
Notable changes

buffer: add {read|write}Big[U]Int64{BE|LE} methods (garygsc) #19691
build: macOS package notarization (Rod Vagg) #31459
deps:

update npm to 6.14.3 (Myles Borins) #32368
upgrade openssl sources to 1.1.1e (Hassaan Pasha) #32328
upgrade to libuv 1.34.2 (cjihrig) #31477

n-api:

add napi_get_all_property_names (himself65) #30006
add APIs for per-instance state management (Gabriel Schulhof) #28682
define release 6 #32058
turn NAPI_CALL_INTO_MODULE into a function (Anna Henningsen) #26128

tls:

expose keylog event on TLSSocket (Alba Mendez) #27654
support TLS min/max protocol defaults in CLI (Sam Roberts) #27946

url: handle quasi-WHATWG URLs in urlToOptions() (cjihrig) #26226

Commits

[64744a282e] - (SEMVER-MINOR) buffer: add {read|write}Big[U]Int64{BE|LE} methods (garygsc) #19691
[8a0ed8f1ff] - build: macOS package notarization (Rod Vagg) #31459
[42af3b861a] - build,win: fix goto exit in vcbuild (João Reis) #30931
[b164a2e3bf] - console: add trace-events for time and count (James M Snell) #23703
[04cd67f85e] - deps: upgrade npm to 6.14.4 (Ruy Adorno) #32495
[8d85a43d99] - deps: update term-size with signed version (Rod Vagg) #31459
[76033c5495] - deps: update archs files for OpenSSL-1.1.1e (Hassaan Pasha) #32328
[64c184836b] - deps: adjust openssl configuration for 1.1.1e (Hassaan Pasha) #32328
[c8f5ab2089] - deps: upgrade openssl sources to 1.1.1e (Hassaan Pasha) #32328
[bf26c44c92] - deps: remove *.pyc files from deps/npm (Ben Noordhuis) #32387
[c2b3cf61ce] - deps: update npm to 6.14.3 (Myles Borins) #32368
[8cae4dde91] - deps: upgrade npm to 6.14.1 (Isaac Z. Schlueter) #31977
[47046aa5a9] - deps: openssl: cherry-pick 4dcb150 (Adam Majer) #32002
[098704c85d] - deps: upgrade to libuv 1.34.2 (Colin Ihrig) #31477
[4b1cccc4ce] - deps: upgrade to libuv 1.34.1 (Colin Ihrig) #31332
[fff6162693] - (SEMVER-MINOR) deps: upgrade to libuv 1.34.0 (Colin Ihrig) #30783
[6826ef0568] - deps: upgrade to libuv 1.33.1 (Colin Ihrig) #29996
[aed7ca4fb0] - deps: upgrade to libuv 1.32.0 (Colin Ihrig) #29508
[794abbc758] - deps: upgrade to libuv 1.31.0 (Colin Ihrig) #29070
[ed71f55a54] - deps: upgrade to libuv 1.30.1 (Colin Ihrig) #28511
[7cde563235] - deps: upgrade to libuv 1.30.0 (Colin Ihrig) #28449
[b53ce6e6c5] - deps: upgrade to libuv 1.29.1 (Colin Ihrig) #27718
[9b2b66b7d8] - deps: V8: cherry-pick d89f4ef (Milad Farazmand) #31753
[7eac95981e] - deps: upgrade npm to 6.13.7 (Michael Perrotte) #31558
[db24641fbe] - deps: upgrade npm to 6.13.6 (Ruy Adorno) #31304
[2e3d511cff] - doc: correct version metadata for Readable.from (Dave Vandyke) #32639
[34c1c2a82b] - doc: add missing version metadata for Readable.from (Anna Henningsen) #28695
[aa7d369c72] - doc: update releaser list in README.md (Myles Borins) #32577
[05f5b3ecc4] - doc: remove em dashes (Rich Trott) #32080
[ffa9f9bd1b] - doc: fix changelog for v10.18.1 (Andrew Hughes) #31358
[0177464b0e] - doc,tools: get altDocs versions from CHANGELOG.md (Richard Lau) #27661
[e9c590ea00] - (SEMVER-MINOR) n-api: define release 6 (Gabriel Schulhof) #32058
[239377b654] - (SEMVER-MINOR) n-api: correct instance data tests (Gabriel Schulhof) #32488
[ecbb331be0] - (SEMVER-MINOR) n-api: add napi_get_all_property_names (himself65) #30006
[f29fb14cf6] - (SEMVER-MINOR) n-api: add APIs for per-instance state management (Gabriel Schulhof) #28682
[20177b9946] - n-api: turn NAPI_CALL_INTO_MODULE into a function (Anna Henningsen) #26128
[017909b847] - test: fix tool path in test-doctool-versions.js (Richard Lau) #32645
[1ea70d641d] - test: fix flaky doctool and test (Rich Trott) #29979
[89692ff19b] - test: end tls connection with some data (Sam Roberts) #32328
[9bd1317764] - test: mark empty udp tests flaky on OS X (Sam Roberts) #31936
[5484e061b5] - test: scale keepalive timeouts for slow machines (Ben Noordhuis) #30834
[3f9cec3f51] - test: add debugging output to test-net-listen-after-destroy-stdin (Rich Trott) #31698
[f1a8791316] - test: allow EAI_FAIL in test-http-dns-error.js (Colin Ihrig) #27500
[4b9a77909b] - test: mark tests as flaky (João Reis) #30848
[a8fd8a1a61] - test: mark http2 tests as flaky on 10.x (AshCripps) #31887
[2315270cb6] - test: try to stabalize test-child-process-fork-exec-path.js (Refael Ackermann) #27277
[a2b0e9ef6a] - (SEMVER-MINOR) tls: expose keylog event on TLSSocket (Alba Mendez) #27654
[1cfb45732a] - (SEMVER-MINOR) tls: support TLS min/max protocol defaults in CLI (Sam Roberts) #27946
[a175b8d3a7] - tools: only fetch previous versions when necessary (Richard Lau) #32518
[3756be8511] - tools: add NODE_TEST_NO_INTERNET to the doc builder (Joyee Cheung) #31849
[ac1ea7312a] - tools: make doctool work if no internet available (Richard Lau) #30214
[f235eea8b3] - tools: unify make-v8.sh for ppc64le and s390x (Richard Lau) #31628
[61e2d4856d] - tools: use CC instead of CXX when pointing to gcc (Milad Farazmand) #30817
[4390674624] - url: handle quasi-WHATWG URLs in urlToOptions() (Colin Ihrig) #26226
[dc61e09feb] - v8: fix load elimination liveness checks (Ben Noordhuis) #31613

Renovate configuration
:date: Schedule: At any time (no schedule defined).
:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.
:recycle: Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".
:no_bell: Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

Available now for Enterprise: Renovate Pro with real-time webhook handling and priority job queue.

:tada: This PR is included in version 5.0.19 :tada:
The release is available on:

v5.0.19
GitHub release

Your semantic-release bot :package::rocket:


Add python36 support

Adds six as a dependency to support both python3 and python2

Confirmed travis is running python27 and 36 tests


[Proposal] Array.prototype.slice reference

Currently, spreads and rest parameters compile using Array.prototype.slice. Which makes sense in a browser environment where you wouldn't want the global namespace polluted as part of the 6to5 philosophy.
However, in certain cases it might make sense to store slice as a variable in the topmost context and reuse it throughout a single file. This would help save on bytes in the browser, which is why many libraries do this.
Currently,
(function() {
  function bar(...items) {
  }

  function foo() {
    return bar("test", ...arguments);
  }
}());

Compiles to:
(function() {
  function bar() {
    var items = Array.prototype.slice.call(arguments);
  }

  function foo() {
    return bar.apply(null, ["test"].concat(Array.prototype.slice.call(arguments)));
  }
}());

However, I think the following would be more readable, and would save on bytes.
(function() {
  var slice = Array.prototype.slice;

  function bar() {
    var items = slice.call(arguments);
  }

  function foo() {
    return bar.apply(null, ["test"].concat(slice.call(arguments)));
  }
}());

Thoughts?

As of 2.6.0, 6to5 now uses a for loop instead of Array.prototype.slice.


Notification Mail Attachement

Hello TechGuy!
Thanks for the effort and more thanks for sharing it!
It's pretty cool!
The Script work's fine so far! Just try to understand how it works and expand the functionality a bit!
Added the Lines:
Snip...
##SEND NOTIFICATION MAIL
Write-au2matorLog -Type Info -Text "Send Info Mail about new BackUp to Chef Andreas"
Send-MailMessage -From AndreasEMAIL.com -Subject "Ein neues Inca FehlerLog Backup wurde erstellt" -To AndreasEMAIL.com -Body "INCA FehlerLogdaten Backup wurde erstellt!" -BodyAsHtml -SmtpServer SMTPSERVERADDRESS.com
...endSnip
Works well and send me the notification via email. If it runs on my system there is no need for auth.
If i try to add the "Attachement" -> "LogFile" which is predefined at the beginning of script it's not gonna work!
I'am pretty new to the "power of shell" so forgive me if this is a dumb question to you!
Greetings Andreas

What is the error message when you try to send with an attachment?


libsinsp/version.h is fragile with respect to use of __STDC_FORMAT_MACROS

Describe the bug
version.h at commit c8af440082fd996ade25b2128167168db98710a5 is a bit fragile with respect to its use of __STDC_FORMAT_MACROS. If that preprocessor define is set before including intttypes.h, it allows adding formatting directives like PRIu32 to sprintf/printf/etc.
The problem is that __STDC_FORMAT_MACROS must be defined before the first include of inttypes.h. If another header includes version.h but also includes inttypes.h before version.h without __STDC_FORMAT_MACROS, the formatting directives won't be available.
I suppose you could fix all includes of inttypes.h in libs to ensure that __STDC_FORMAT_MACROS is defined, but I would think an easier solution would be to move the implementation of the methods into a version.c file and control the includes there.
How to reproduce it
I can't include the full build log, since this is a custom use of libs, but I do get this error:
XXX/userspace/libsinsp/version.h: In constructor 'sinsp_version::sinsp_version(const string&)':
XXX/userspace/libsinsp/version.h:39:45: error: expected ')' before 'PRIu32'
   m_valid = sscanf(version_str.c_str(), "%" PRIu32 ".%" PRIu32 ".%" PRIu32,

If I add __STDC_FORMAT_MACROS to the include of inttypes.h in userspace/libscap/plugin_info.h and userspace/libscap/uthash.h, I can build without this error.
Expected behaviour

Screenshots

Environment

Falco version:

System info:

Cloud provider or hardware configuration:
OS:

Kernel:

Installation method:

Additional context

Hi Mark, thanks for discovering this!

I suppose you could fix all includes of inttypes.h in libs to ensure that __STDC_FORMAT_MACROS is defined, but I would think an easier solution would be to move the implementation of the methods into a version.c file and control the includes there.

Can't we define the symbol as a compiler flag instead?
I mean, this way the symbol is globally visible and exported before anything else.


Compute the probability for the optimal sequence

Hi
Thanks for your work
I was wondering if we can compute  the probability for the optimal sequence
Thanks

Hi @s14t284, could you tell me how to get each tokens predicted probability instead of predicted label?


Follow decorator return type hints if available

Sometimes, like discussed in pallets/click#2138, decorators may return something other than a simple decorated function. We could try to have a look at decorator return types to see if we could parse it out. Not sure how complicated it would be though.

So what needs to happen is:

Somehow associate decorators or their return types with names (function/class defs)
When resolving types, we inspect the return type hint to see if the returned type is still a function or something else
If it's a function, we can try to retrieve the return type
If it's an instance, we can inspect its __call__ or whatever is used

But this is more of a shift than I thought at first. We don't follow the hints of functions defined in examples anyway. So if we were to consider implementing this, that would be first. And since we don't want to run the code, we can't use the type hint resolving we currently have. We'd have to parse type hints from source instead.
Not sure if this is worth it.


Run NWB Conversion from YAML specification

Motivation
This PR introduces the most straightforward way of writing a .yml file that specifies all information needed to run a typical conversion using non-custom DataInterfaces.
The .yml language allows three levels for custom information (both metadata and DataInterface specifications) to be specified: (i) on the outermost level, the information applies to all sessions of all experiments, (ii) at the experiment level, only applies to sessions within that experiment nesting, (iii) specific metadata to only a particular session.
This PR does require some of the utils.conversion_tools functions to be split into a utils.nwbfile_tools to avoid circular import with the new function.
A separate follow-up PR will extend the .yml language to allow reverse f-string glob specification whenever their dataset is hierarchically structured, possibly using keywords that can also serve as NWBFile metadata such as session_id, subject_id, and so on. This approach will greatly reduce redundancy in the .yml language for datasets that rigorously adhere to the specified structure, but will not be so rigorous that it cannot support custom sessions outside this structure (which is mainly what this current PR resolves).
How to test the behavior?
A testing .yml file is included, which uses actual GIN data in its construction. The parsing function runs on this .yml to produce an .nwb file, whose internal structure is then verified to match the intended specification.
Checklist

[X] Have you checked our Contributing document?
[X] Have you ensured the PR description clearly describes the problem and solutions?
[X] Have you checked to ensure that there aren't other open or previously closed Pull Requests for the same change?

To-Do from pre-PR: use DANDI default naming scheme for optional nwbfile_name

Returning to draft until I figure out the DANDI organization integration

@bendichter Usage of DANDI organize convention for establishing unique filenames is now established.
For any session in the .yml file that does not have an nwbfile_name set, it is temporarily assigned an alias temp_nwbfile_name_{#}.nwb; this is because DANDI organize finds the minimal amount of metadata to include in the file name to uniquely distinguish it from all the other NWBFiles in the directory, meaning it can't really be resolved at the level of individual files.
After all the NWBFiles are written, it then triggers a renaming only for the temporary aliases (anything with an nwbfile_name pre-specified stays as-is) based on the organization convention, but considering all the metadata across all the files for maximum distinction.
Right now, if there isn't enough metadata for DANDI to make an intelligent decision, it raises an assertion prior to renaming, but keeps the written NWBFile with the temporary alias to avoid losing the data in the file. The user can then manually rename the file if they wish. This is mostly triggered by the special case of using the .yml to convert only a single session.
For more than a single session, there will usually be enough for the organize to distinguish based on session_start_time alone, which sends us back to the age-old question of should we set session_start_time to be a required metadata field in all cases?

Code is all mostly ready to go, but waiting on next release to do a version bump for altering the tool import structure.


Make it optional to return an error from Inject()

Don't require Inject methods to return an error. A lot of them don't need to, and return nil is a lot of typing.

Good job [Kiddo]@ooesili very good observation!  This programming thing just might work out for you.  Hang in there!


Async Crypto Endeavour

Ref https://github.com/libp2p/js-libp2p-crypto/pull/10

Only missing the Sauce Labs testing badge

done


Fix spurious test failure when GIT_EDITOR is set

git var checks the $GIT_EDITOR environment variable before the core.editor config knob. TestGitDir intends to verify that the latter is respected, so sanitize the environment before running the test and restore it upon completion.

:+1:

Thanks!


Redesign for new rules

See https://github.com/rust-lang/rust/issues/20749
Since Get, Set and Action are auto implemented, then we could use tuples for the Self type and associated types.

Got problems with either lifetimes or calling static method on trait.

Can add a phantom enum struct pub struct Me<T>; and pass it in as Me<Self> as first parameter.


Left-hand nav preview overflows with a multi-line message that includes a link

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Send these message to a chat

Heading to this vegan place.
Garðurinn
+354 561 2345
[https://maps.app.goo.gl/zPX37o4GU22P9xtGA?g_st=ic](https://maps.app.goo.gl/zPX37o4GU22P9xtGA?g_st=ic)

> Dylan and myself are heading to Ramen Momo right now if anyone wants to join.

It's very good, but only fits 8 people inside.

Observe the LHN

Expected Result:
There should be no overflowing
Actual Result:
Looks weird in the LHN with overflowing
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: 1.2.90-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @conorpendergrast
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1679921293018429
View all open jobs on GitHub

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

This is duplicated with https://github.com/Expensify/App/issues/16563 and fixed already in https://github.com/Expensify/App/pull/16559

Nice!


implement toggle mode

i want to switch mode (diff / no mode).

I did a fork which made this plugin working again and which adds as well a simple toggle function: https://github.com/mittelmark/git-gutter-vim/


Amend axis label & tick labels on data dashboard homepage

Needs to be larger

Alternatively make scale-less versions labelled as 'trends' which link through to the specific graphs #177

It certainly looks better without the axis labels I think.
And at the risk of being a pain, it led me to wonder what the visualisation looks like with the key but without the axis labels (just to help provide some context to viewers).
Feels like this should remain a prototype , rather than changes pushed across the site, until we speak with YFF however?

These look great @slowe @ODILMichelle - I think no axis labels with a key looks best - then you can get an idea of overall trends before clicking onto the main page for specific figures.

Yes - I think it needs the key, unless we can pick a single variable to plot

I'm going to say this is complete as we have the ability to do this. We can continue ongoing discussions in #192


Can this be used to convert any css to Tailwind or just in a laravel application?

@Gazzooks This extension can convert any css to tailwind


Notebook cell editors missing contribs

Open notebook editor
The first code cell editor has language hovers, suggest, breakpoint decorations in the gutter, etc. In all of the other editors, these features don't show up, and I see the editor contribs not being instantiated.

Debugging, at https://github.com/microsoft/vscode/blob/25bb57566d7b9d3528220b15b0dac05b5bebbf90/src/vs/editor/browser/widget/codeEditorWidget.ts#L329, I see codeEditorWidgetOptions.contributions is a closed generator, so no contribs are instantiated

@mjbvz wondering whether this is from https://github.com/microsoft/vscode/pull/163309?
cc @rebornix

Thanks!


Explore compact labeled records and variants

Hydra currently distinguishes between product types, which apply to unlabeled / integer-indexed tuples, and record types, which apply to records with labeled fields. Similarly, Hydra has sum types and also union types. For many purposes (e.g. inference), the unlabeled product types are simpler and more efficient to work with, and of course the data representation of tuples is more compact than that of records. In principle, all records could be represented as tuples, but manipulated as records with the help of a dictionary which mediates between indexes and field names.
Explore this once the code base has settled a bit (i.e. once #118 is merged).

my intuition is that you'll want to get rid of products/sums and only use records/unions.

"Get rid of" may be too strong a phrase. We still need tuples in the language for the same kinds of use cases which tuples serve in Haskell. I would say that both record types and product types are necessary, but that in many cases, we can replace record instances with tuple instances.

Note that for projections, injections, and also for case statements (if a default branch is supported), we still do need to provide integer-valued field indexes, but not necessarily field names. It is the dictionary which lets us map between names and numbers.


Write integration tests

Fixes #9

Codecov Report

Merging #11 (08c79e8) into main (7e708a6) will increase coverage by 13.17%.
The diff coverage is n/a.

:exclamation: Current head 08c79e8 differs from pull request most recent head d182680. Consider uploading reports for the commit d182680 to get more accurate results

@@            Coverage Diff             @@
##            main      #11       +/-   ##
==========================================
+ Coverage   6.14%   19.31%   +13.17%
==========================================
  Files          7        6        -1
  Lines        586      554       -32
  Branches      54       53        -1
==========================================
+ Hits          36      107       +71
+ Misses       550      447      -103

Impacted Files
Coverage Δ

unetseg/train.py
12.29% <0.00%> (+12.29%)
:arrow_up:

unetseg/evaluate.py
20.75% <0.00%> (+20.75%)
:arrow_up:

unetseg/postprocess.py
26.78% <0.00%> (+26.78%)
:arrow_up:

unetseg/predict.py
36.92% <0.00%> (+36.92%)
:arrow_up:

unetseg/utils.py
53.33% <0.00%> (+53.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e708a6...d182680. Read the comment docs.


Move _worker_check() logic to process_dataloader() in DDPSpawnStrategy class.

Proposed refactor
This issue follows @ananthsub 's https://github.com/PyTorchLightning/pytorch-lightning/issues/11756 to move strategy-specific dataloader logic to the stategies.
Motivation
_worker_check() in data_connector.py is used to check the number of workers for the dataloader when user sets up DDP_SPAWN strategy.
https://github.com/PyTorchLightning/pytorch-lightning/blob/cc43d07db1ab77385feff04c01f040c5cad805a9/pytorch_lightning/trainer/connectors/data_connector.py#L274
Since this dataloader verfication logic is dpp_spawn strategy specific, it'll be better we moved the logic to DDPSpawnStrategy class. By doing so, _worker_check() can be removed from data_connector.py.
Pitch
This logic check could be moved to process_dataloader() in DDPSpawnStrategy class.

Additional context
cc: @edward-io @four4fish @ananthsub

If you enjoy Lightning, check out our other projects! ⚡

Metrics: Machine learning metrics for distributed, scalable PyTorch applications.

Lite: enables pure PyTorch users to scale their existing code on any kind of device while retaining full control over their own loops and optimization logic.

Flash: The fastest way to get a Lightning baseline! A collection of tasks for fast prototyping, baselining, fine-tuning, and solving problems with deep learning.

Bolts: Pretrained SOTA Deep Learning models, callbacks, and more for research and production with PyTorch Lightning and PyTorch.

Lightning Transformers: Flexible interface for high-performance research using SOTA Transformers leveraging Pytorch Lightning, Transformers, and Hydra.

cc @justusschock @awaelchli @ninginthecloud @rohitgr7 @otaj @tchaton @akihironitta

Closing because no longer relevant. The logic was recently reworked (#18737, #18649, #18591) and the worker_check function is no longer just ddp-spawn specific.


user creation issue fixed

Fixes issue with user creation not working due to current_password being required.

@Samsinite, I cleaned this up and removed the extra database call at https://github.com/inigo-llc/token_authenticate_me/blob/ccf9715740a936c30251daf97c7b8254a09824d3/lib/token_authenticate_me/models/authenticatable.rb#L72. This was corrected by adding https://github.com/inigo-llc/token_authenticate_me/blob/ccf9715740a936c30251daf97c7b8254a09824d3/lib/token_authenticate_me/models/authenticatable.rb#L67

:+1:


Pushing Trained Agent to Hub - Unit1

Hello,
When trying to run the cell for pushing to the hub, I am getting error messages from the package_to_hub function.
Please keep in mind all the other cells run smoothly up to that point.
I have tried the 'try it yourself' cell, filling in details, the message was "NoSuchDisplayException: Cannot connect to "None"" (left side of the screenshot)
I also tried the 'solution' cell, (changing repo_id of course) and the message was "NameError: name 'base' is not defined" (right side of the screenshot)
Looking forward for a solution, as I am eager to complete the course before the deadlines.
Thanks!

Hey there :wave: , this is a common problem, you need to restart the notebook. What it simply means for the left one is that you didn't run a virtual screen and the second that you need to restart the virtual screen


Options to disable error listener and/or enable Monolog handler

Resolves #232.
As mentioned in the issue, having both the Monolog handler & the ErrorListener installed results in having duplicate entries.
I added a configuration option to disable the ErrorListener. I also added the ability to configure the Monolog handler through the bundle.
I still need to add some tests as well, but I wanted to get some feedback first on whether or not this approach is good.

@Jean85 Tests added

Hi  @Jean85  @H could someone explain me how this is supposed to work?
When service Sentry\Monolog\Handler is private one and cannot be used in config files?
In SentryExtension I found only:
`     if (! $errorHandler['enabled']) {
$container->removeDefinition(Handler::class);
        return;
    }`

and configuration for parameters of this service.
But still adding to monolog config lines:
monolog:     handlers:         sentry:             type: service             id: Sentry\Monolog\Handler  service with this id is not found as this is not public..

Services don't need to be public to be used. You can use proper injection to obtain them.

Ok, I will double check twhy it could not find the service in my case until I redeclared it myself in my own services.yml

@Jean85  looks like symfony cache strange behaviour which got me confused. Thanks for quick answer.
After cleaning everything once more ( and also removing cache folder) somehow it started to work with   id: Sentry\Monolog\Handler


Home page ui improvement. Button, text size, navbar

What's the style idea?
Details:

Button Design Improvement.
Text Size Deceased.
Navbar Names Hover Improvement.
Content added for " What is DevsInTech Community? ".

Can you please assign me this tasks under GSSOC'23
Add screenshots
Before:

After:

Code of Conduct

[X] I agree to follow this project's Code of Conduct

@ojasaklechayt Thank you for raising this issue, go forward, I'm assigning this to you.


Add default handling of Space and Enter to Pressable

Please select one of the following

[ ] I am removing an existing difference between facebook/react-native and microsoft/react-native-macos :thumbsup:
[ ] I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos :thumbsup:
[x] I am making a fix / change for the macOS implementation of react-native
[ ] I am making a change required for Microsoft usage of react-native

Summary
In React Native Windows, Pressable will by default handle onKeyUp / onKeyDown to call onPress / onPressIn / onPressOut. We were missing that in React Native macOS, due to differences in our keyboard event API. React Native Windows sends all keyboard events to JS, whereas React Native macOS only sends keyboard events to JS if validKeysUp / validKeysDown is specified.
Let's implement this default keyboard handling for Pressable in React Native macOS as well. The logic added is mostly a copy of the logic in React Native Windows with a few key differences:

We add a default validKeysDown prop if the calling code doesn't specify one. This is needed due the API difference mentioned above.
We fire onPress  with onKeyDown instead of onKeyUp. This is a platform difference between Windows and macOS. In Windows natively, button presses are preferred to be fired with onKeyUp. Furthermore, you can "cancel" a button press  by pressing Tab in between your keyDown and your keyUp. This quirk is not present in native macOS.
Because of (2), I chose not to port the following change, where one can cancel the onPress https://github.com/microsoft/react-native-windows/commit/ed1e85ecf40c9261ffb4f479775e373e4b566f21

Changelog

[macOS] [Changed] - Add default handling of Space and Enter to Pressable
Test Plan
In progress...

Made https://github.com/microsoft/react-native-macos/pull/1623 which is the same fix in Pressability.js but instead of making default validKeysDown props for Pressable, made the validKeysDown/Up props implicit default contain Enter and Space in RCTView so that the same behavior works in Touchables, Button, etc.

Closing in favor of #1623


draft Support  table create、drop、truncate etc

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

no use


Go Extension does not work

Description
When using any of the commands for the go extension the error command 'go.gopath' not found becomes present.
This same thing happens for every go command and reduces usability of the go extension.
Have tried Go: Install/Update Tools and command 'go.tools.install' not found is reported.

Is there any update on this bug?

Sorry for the necro, however I'm getting this exact issue using Go 1.14.1 on linux/amd64
GOARCH="amd64"
GOBIN="/home/csnet/go/bin"
GOCACHE="/home/csnet/.cache/go-build"
GOENV="/home/csnet/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/csnet/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build390077288=/tmp/go-build -gno-record-gcc-switches"```

@cmoog

For me not only go but even html and simple vanilla javascript is not working even extensions are failing to work like html formatter.

Also in response to @kylecarbs my path is as follows:
/usr/local/go/bin:/home/rudi/go/bin:/usr/local/go/bin::/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin

@Rudi9719 I think there is an issue with your path. Observe how your GOBIN and GOPATH are not present in the PATH you've just pasted above.

@Rudi9719 Your $GOBIN is /home/rudi/go/bin but your $GOPATH is /home/csnet/go. Not sure if you are intentionally using a different home directory.
@Abhid14 Can you open a new issue regarding what errors you're getting?

@Abhid14 Can you open a new issue regarding what errors you're getting?

So far so Good since build 3.0.2 Will surely report if any problem occurs. Thank you!


Fix typo in Point.str

Add a missing space in string conversion function of Point class.

I have no authority to accept your change regardless...  but, I would recommend making two separate PRs instead of burying your single character correction in a pile of unrelated other changes.  For the string formatting related changes I would personally tend to go ahead and change to .format() if they are being rewritten en-masse anyways.

I actually intended the pull request for the missing space character only and not for the subsequently pushed commits. I will close this request and try again.


Refactor front-end

Ideally, [these] (http://briantford.com/blog/huuuuuge-angular-apps) guidelines should be followed to ensure that the code remains manageable, and that duplication is avoided.

Virtually done.


PR: Setup the initial structure for the documentation

Add a basic description of the project
Add the config files
Add an About section
Add the structure for the documentation

Hello @jnsebgosselin! Thanks for submitting the PR.

There are no PEP8 issues in the file docs/conf.py !

In the file pyhelp/__init__.py, following                are the PEP8 issues :

Line 19:1: E402 module level import not at top of file

There are no PEP8 issues in the file pyhelp/managers.py !


fix(overscroll): make Plate fixed on mobile

https://github.com/aeternity/superhero-wallet/pull/931#discussion_r603594655

Proposing to close this in favor of #1006 #1010 #1011, as suggested here https://github.com/aeternity/superhero-wallet/pull/931#discussion_r613115772.
Approved by @onvisions by presenting this demo https://github.com/aeternity/superhero-wallet/pull/931#issuecomment-820632343.


Automatic JWK enrichment

This PR will allow to derive most standardized common parameters from already specified parameters.
This is a follow-up to a few points which could not be addressed in #520, but were brought up by me in #518.
Overview
Using all of its features, given an X.509 certificate, you can acquire a JWK like this:
::JWT::JWK.new(certificate)

This will extract the public key, construct the JWK, and try to set the following parameters:

kid as previously implemented
x5c is a representation of the certificate
x5t and x5t#S256 are wide-spread certificate thumbprints
key_ops and use state allowed key usages and are derived from the X.509 keyUsage extension, if present
alg will be set to a sensible default depending on use and kty

Of course, any parameters specified in the above invocation will still take precedence.
There is even support for the x5u parameter, to fetch a remote certificate chain:
x5u_fetcher = ->(uri) {
    # Fetch uri, return as Array of OpenSSL::X509::Certificate
}
::JWT::JWK.new(jwks_hash, nil, enrich_key: true, x5u_handler: x5u_fetcher)

TODO

[ ] Proper certificate validation
[ ] Check if code from x5c_key_finder can be reused
[ ] new README examples
[ ] Update changelog

I realize this is a WIP but I got very curious so will drop a few comments.


Logger fails at scale

Didn't happen before, but now this is happening:
When running on 1 or 2 nodes the logger works fine.
When running on 2+ nodes nothing logs...
Might be a race condition which dist.barrier() might fix.
@neggert any thoughts?

I can't get anything to log other than epoch and gpu details, even with single GPU. Is this coming from trainer.trainer around _process_output()? If someone can point me in the right direction, maybe add in some prints() or extra error messages, I might be able to submit a PR.

ok, fixed the issue. I was still referencing the logger.experiment object outside of the trainer. This shouldn't be done in any way.
@jamesjjcondon verify with this fix?

Yep. working now. Cheers. And I just saw your 9-steps medium article from July. Super helpful. Thanks!


How can i  split Inbreast by myself

Hi, would you be able to share the code of how you split the dataset for four-view and two-view of Inbreast?

Hi woshishei555,
I uploaded a notebook Preprocessing_INbreast.ipynb in the utils folder with the full preprocessing code.


New membership request

I have request to be a member about the kubeedge,can you agree +1 for me ? @Poorunga  https://github.com/kubeedge/community/issues/100
What would you like to be added/modified:
Why is this needed:

done


Now it also works while logged in trough RDP

Maybe this will help some people.
try {     $WmiLoggedOnUsers = (Get-WmiObject Win32_LoggedOnUser).Antecedent      If($WmiLoggedOnUsers.Count -gt 1) {         $WmiLoggedOnUsers = $WmiLoggedOnUsers -match "Domain="DOMAIN""     }     $WmiUserValid = ($WmiLoggedOnUsers | Select-Object -Unique -First 1) -match 'Domain="([^"]+)",Name="([^"]+)"'     If(-not $WmiUserValid){         Throw "Returned object is not a valid WMI string"     }     $UserName = "$($Matches[1])\$($Matches[2])"     $ObjUser = New-Object System.Security.Principal.NTAccount($UserName)     $Sid = $ObjUser.Translate([System.Security.Principal.SecurityIdentifier])     $SidValue = $Sid.Value     $Message = "User SID is $SidValue."     Write-Host "$Message" } catch [Exception] {     $Message = "Unable to get user SID. $_"     Write-Host "$Message"     exit }

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 77e14da1-102d-3ddf-e2a1-a20ce533b95a
Version Independent ID: 374edc4c-f527-b7b7-c291-353928b97d8d
Content: Configure Windows 10 Client Always On VPN Connections
Content Source: WindowsServerDocs/remote/remote-access/vpn/always-on-vpn/deploy/vpn-deploy-client-vpn-connections.md
Product: windows-server
Technology: remote
GitHub Login: @Teresa-Motiv
Microsoft Alias: v-tea

#assign:IngridAtMicrosoft

#assign:HeidiLohr


Any API documentation of .NET object library available?

Is there any good way to get an overview of what parts of .NET API are implemented in Bridge.NET? The homepage does not provide any obvious link to such documentation, nor can I find any coming with the installation. So far, I've just referred to docs.microsoft.com and hoped the implementation matches, but is there a better way?
In fact, I don't even know what version of .NET API Bridge.Net tries to follow!

Oh, just realized I can read <project>/packages/Bridge.Core.1x.x.x/lib/net40/Bridge.xml using text editor and it will act as servicable documentation. But since it's XML, I suppose it ought to be read by some other program. What program exactly, and can it be run from the system terminal (I mean, without opening an IDE)?

There is an user-contributed tool that was shared at some point in our gitter channel. I'm not sure how up-to-date it would be, but it's worth a try. It is a direct comparison between what is and what is not in both frameworks.
Other than that, Bridge aims to follow what's in .NET API. So you can rely on their documentation, and report here (please do a search in existing issues beforehand) if there's no open requests for that feature.
Sometimes there may be limitations that made it unable to be ported in, but most times it is just that we weren't aware of the need of that class/method, and we prioritize development on what's demanded by the community.
Well, we also prioritize merging pull requests of features and fixes provided by the community, by the way!

@michaelcheers message back then was:

I made a similar tool
you can see here: https://michaelcheers.github.io/ReflectionComparison-Results/result.html

The result of the above link appears to be somewhat out of date. I do believe more of the API is now supported by Bridge.

It hasn't been updated for a while.


Add badges

Codecov Report

Merging #14 (7562e63) into main (47d83e2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #14   +/-   ##
=======================================
  Coverage   76.52%   76.52%
=======================================
  Files           6        6
  Lines         230      230
=======================================
  Hits          176      176
  Misses         38       38
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47d83e2...7562e63. Read the comment docs.


Drop support for Python 3.4

Because of:

DEPRECATION: Python 3.4 support has been deprecated. pip 19.1 will be the last one supporting it. Please upgrade your Python as Python 3.4 won't be maintained after March 2019 (cf PEP 429).

See https://travis-ci.org/pydoit/doit/jobs/640146558#L213

Obsolete, closing.


Run separate thread and keep checking the currently running coroutine, so you can sort of profile the code

Added, doesn't help much tho


Filament 3 compatibility

Will this be available in Filament 3?
(Im posting here because the suggeestions page gives me a 404 error).

Hi @albertobenavides,
we don't have much time for it at the moment, but yes, we are planning support for Filament 3 and it could be done until the end of February.
Thanks


OutputSegments

Another take on https://github.com/dwrensha/capnproto-rust/pull/43.

This looks great, thanks David!


update rdmty bar color for gunbreaker and dancer

colors match what fflogs went with for the new jobs

Thanks, much appreciated! <3


sub-commands with global options + help?

Is this doable with pflag? Like what cobra supports but more minimal/library form.
(cobra is way overkill for my use-case)

pflag has FlagSets which you can manage as you see fit. But the concept of subcommands and global flags and all of that are a cobra concept. You're going to have to rebuild cobra :-(

I see; Thanks!


No license file

I was looking to upload this color scheme to my dotfiles repo, but the vim color file only makes the following mention of the license, but no actual license text.

" Quantum - A 24-bit Material color scheme for Vim
" Author: Brandon Siders
" License: MIT

Would you mind adding a license file to your project so I can include the license text within my dotfiles?

Consider it done!


Detail for the Ensembled Model

Hi! Thank you for your great work! And I have a question about the ensembled model that you mentioned in your paper. I did not find the code about the ensembling techniques and the model trained through this repo can just achieve performence of the single mode in your paper. Can you provide the code about this or make an explanation? Thank you!

Thank you for your kind words and great question!
I didn't spend too much time focusing on ensembling because it's quite challenging to implement for real-time applications. For the ensembling, I used the same approach as QCNet, where I ensembled 10 models trained with different random seeds or slight variations in their architecture. You can refer to the supplementary materials of QCNet for more details on the ensembling technique.
I hope this helps! Feel free to reach out if you have any more questions.

This help me a lot, thx!


Transaction getting reverted on minting the wrapped document on v5.1.0

Hi Team,
We were using version @tradetrust/token-registry version 4 and it was working fine.
Now we are upgrading to latest version v5.1.0 with ethers v5, but transaction getting reverted
When we are minting the document it is not working, transaction execution is getting reverted.
We are trying it on stability.
We have updated the schema as well and the schema validation is getting validated as true.
We have also tried using @trustvc/trustvc, but that is also not helping.
we are using the same rpc on v4 and it was working fine on v4.
can you let us know about any know issues with v5 so we can try finding a workaround for this.
Is there any existing react implementation for the same package ?

Hi @manishraana
just notice your issue. Is it possible to provide a code snippet? or for which smart contract function are you interacting with.
Thanks

Hi @manishraana
You are calling the correct mint function signature from token registry v5.
the fields that you have provided to the mint functions were correct, inline with the our tested mint in polygon.
0x6010a5e7
000000000000000000000000773060d0bb516587cfe0490e2077c285870b826e
000000000000000000000000773060d0bb516587cfe0490e2077c285870b826e
4324c06aa42bd2ac0ba3baf121843ac4978e77ee51856292beb8f6c974994838
0000000000000000000000000000000000000000000000000000000000000080
0000000000000000000000000000000000000000000000000000000000000000

https://amoy.polygonscan.com/tx/0x71ce1e7a3a8d351decc7740c14e87726680757d5029963a411253985536bec57

However, I notice that you are interacting with the smart contract 0xa142aeEBd17Fdc685e5BaD09C5b7f37D5210Dc08, which has been created within 0xcd4d27b7c25F57D8121F6E8fdc668b6AA9a212a9 address, using 0x773060D0BB516587cFE0490e2077c285870B826e address.
Can i confirm that there's an oversight on this?
If this is intentional, you will need to look into Roles and Access control, to allow non smart contract creator addresses to interact with the contract.


WIP [GC] add test benchmark, reduce escapes to heap

Description
this PR is to clean up packages, add tests and benchmark tests

Packages
helper/hex
change:

use strings.Builder implement string concatenation

benchmark result:
goos: linux
goarch: amd64
pkg: github.com/dogechain-lab/dogechain/helper/hex
cpu: Intel(R) Core(TM) i7-10700K CPU @ 3.80GHz
BenchmarkEncodeToHex-16           	37461463	        31.26 ns/op	     192 B/op	       3 allocs/op
BenchmarkEncodeToHexUsePlus-16    	31697625	        36.03 ns/op	     224 B/op	       4 allocs/op
BenchmarkEncodeUint64-16          	78871396	        15.73 ns/op	      40 B/op	       2 allocs/op
BenchmarkEncodeUint64Old-16       	84103098	        14.91 ns/op	      56 B/op	       2 allocs/op
PASS
coverage: 58.8% of statements
ok  	github.com/dogechain-lab/dogechain/helper/hex	4.916s

EncodeUint64 method exist escapes, use strings.Builder replace

func EncodeUint64(i uint64) string {
	enc := make([]byte, 2, 10)
	copy(enc, "0x")

	return string(strconv.AppendUint(enc, i, 16))
}

types/address.go
change:

use sync.Pool cache []rune slice

benchmark result:

before:

goos: linux
goarch: amd64
pkg: github.com/dogechain-lab/dogechain/types
cpu: Intel(R) Core(TM) i7-10700K CPU @ 3.80GHz
BenchmarkEIP55-16    	 5708048	       209.9 ns/op	     737 B/op	      12 allocs/op
PASS
ok  	github.com/dogechain-lab/dogechain/types	1.415s

after:

goos: linux
goarch: amd64
pkg: github.com/dogechain-lab/dogechain/types
cpu: Intel(R) Core(TM) i7-10700K CPU @ 3.80GHz
BenchmarkEIP55-16    	 6647642	       182.7 ns/op	     481 B/op	      11 allocs/op
PASS
ok  	github.com/dogechain-lab/dogechain/types	1.402s

types/encoding.go
change:

use string constant
use strings.Builder implement string concatenation

Changes include

[x] Bugfix (non-breaking change that solves an issue)

Checklist

[x] I have assigned this PR to myself
[x] I have added at least 1 reviewer
[x] I have added the relevant labels

Testing

[x] I have tested this code with the official test suite

Codecov Report

Merging #281 (3a0d9f8) into dev (d7c5a9e) will increase coverage by 0.42%.
The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##              dev     #281      +/-   ##
==========================================
+ Coverage   47.74%   48.16%   +0.42%
==========================================
  Files         132      133       +1
  Lines       20125    20188      +63
==========================================
+ Hits         9608     9723     +115
+ Misses       9684     9632      -52
  Partials      833      833

Impacted Files
Coverage Δ

helper/hex/hex.go
86.20% <100.00%> (ø)

types/address.go
59.57% <100.00%> (+12.35%)
:arrow_up:

types/encoding.go
100.00% <100.00%> (+100.00%)
:arrow_up:

... and 3 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Auto-update of time on Bluetooth meters (UPLOAD-236)

Addresses UPLOAD-236.

@krystophv Another small update to fix an issue found during testing.

@krystophv Yet another review of this one, please :)


website claims OS X binaries exist but there doesn't seem to be any present

The main web page at https://github.com/OpenVnmrJ/OpenVnmrJ claims under the Downloads section that "OS X: Built on 10.11 (El Capitan) and tested on 10.11 and 10.10 (Yosemite)" exist for use on OS X. However the only files available are dvdImage_OpenVnmrJ_1.1A_DD2.tbz and dvdImage_OpenVnmrJ_1.1A_MI.tbz both of which, when uncompressed and load.nmr is executed, fail on macOS with the error...
grep: /etc/selinux/config: No such file or directory
Disabling SELinux, System Reboot Required.
You must reboot the system prior to continuing the install.
cat: /etc/selinux/config: No such file or directory
/Users/howarth/Downloads/dvdimageOVJ/load.nmr: line 250: /etc/selinux/config.mod: No such file or directory
mv: rename /etc/selinux/config.mod to /etc/selinux/config: No such file or directory
chmod: /etc/selinux/config: No such file or directory
Where are the actual binaries for OS X located?

I used to have a version on my personal github account. I must have accidentally removed it. I just uploaded it to the OpenVnmrJ releases page at https://github.com/OpenVnmrJ/OpenVnmrJ/releases

Dan,
Thanks. The OpenVnmrJ11A.pkg installed and worked fine under High
Sierra Developer Beta 9 with the exception of one glitch. The application
produced an error alert and quit unless I change the line in /etc/hosts
from...
<IP_ADDRESS>       localhost
to
<IP_ADDRESS>       localhost Mac-Pro.local
to match the output of 'hostname'. I would be nice if OpenVnmr could be
made to accept a simple 'localhost' as a fallback hostname so users didn't
have to edit the network files manually.
Jack
ps I also noticed that the
binary /Applications/OpenVnmrJ_1.1.app/Contents/MacOS/VJ is reported by
file to be a fat binary...
$ file VJ
VJ: Mach-O universal binary with 2 architectures: [i386:Mach-O executable
i386] [x86_64:Mach-O 64-bit executable x86_64]
VJ (for architecture i386): Mach-O executable i386
VJ (for architecture x86_64): Mach-O 64-bit executable x86_64
Is the entirety of OpenVnmrJ compiled as x86_64 on macOS? I ask because the
next release of macOS past High Sierra might eliminate the i386 code
support in the OS so it would be a very good idea to convert the  OpenVnmrJ
build to be 64-bit throughout.
On Fri, Sep 8, 2017 at 9:50 PM, Dan Iverson<EMAIL_ADDRESS>wrote:

I used to have a version on my personal github account. I must have
accidentally removed it. I just uploaded it to the OpenVnmrJ releases page
at https://github.com/OpenVnmrJ/OpenVnmrJ/releases
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/OpenVnmrJ/OpenVnmrJ/issues/129#issuecomment-328247039,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC4Q6tarxutcmwHYVCZOsCs7-B5wP2cmks5sge7_gaJpZM4PR0LI
.

Dan,
What is the status of being able to execute 'seqgen' to compile
sequences on non-console workstations? It is useful to be able to display
the pulse sequence used for an experiment. Has anyone managed to edit the
existing /vnmr/psg/seqgenmake to allow it to work on under x86_64 Linux
with the i386 legacy support packages?
Jack
On Fri, Sep 8, 2017 at 9:50 PM, Dan Iverson<EMAIL_ADDRESS>wrote:

I used to have a version on my personal github account. I must have
accidentally removed it. I just uploaded it to the OpenVnmrJ releases page
at https://github.com/OpenVnmrJ/OpenVnmrJ/releases
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/OpenVnmrJ/OpenVnmrJ/issues/129#issuecomment-328247039,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC4Q6tarxutcmwHYVCZOsCs7-B5wP2cmks5sge7_gaJpZM4PR0LI
.

I will look into using localhost if the hostname does not exist in /etc/hosts. Compiling for 64-bit is a bigger job, especially if data acquisition is involved (i.e., for Linux systems). For MacOS, it may be more manageable and it may be a good place to start.
The seqgen command should work on all systems. On MacOS systems from a terminal, you may need to do "source /vnmr/user_templates/.vnmrenvsh" first, in order to set the PATH variable and some other parameters.

I worked through converting psglib to 64 bit at one point (see #20), it's
not that much work, mostly just getting all the structure alignments
correct, iirc.  I was linking the pulse sequence against some 64bit
libraries, so all the seqgenmake output (up to and including the pulse
sequence binary) was 64 bit.
Dan, has there been any progress on clarifying the contributions issue?
On Tue, Sep 12, 2017 at 8:09 PM, Dan Iverson<EMAIL_ADDRESS>wrote:

I will look into using localhost if the hostname does not exist in
/etc/hosts. Compiling for 64-bit is a bigger job, especially if data
acquisition is involved (i.e., for Linux systems). For MacOS, it may be
more manageable and it may be a good place to start.
The seqgen command should work on all systems. On MacOS systems from a
terminal, you may need to do "source /vnmr/user_templates/.vnmrenvsh"
first, in order to set the PATH variable and some other parameters.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/OpenVnmrJ/OpenVnmrJ/issues/129#issuecomment-328936365,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AATsLweVztBPgID-d4HjIo-K0dogpjtLks5shsj1gaJpZM4PR0LI
.


metrics: reduce cardinality of cilium_k8s_client_api_latency_time_seconds_bucket metric

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
cilium_k8s_client_api_latency_time_seconds_bucket metric includes path as a label. some paths contain unbounded values like node names or pod names, resulting in a very high number of series relative to other cilium metrics. some examples of paths with unbounded values:
/apis/cilium.io/v2/ciliumnodes/$NODE_NAME
/apis/cilium.io/v2/namespaces/$NAMESPACE/ciliumendpoints/$POD_NAME

Cilium Version
cilium image (running): v1.12.0
Kernel Version
not relevant
Kubernetes Version
not relevanet
Sysdump
No response
Relevant log output
No response
Anything else?

Code of Conduct

[X] I agree to follow this project's Code of Conduct

... and let me piggyback just one more thing, scope label also contains some unbounded values. some examples:
cilium_event_ts{action="GET",scope="/v1/endpoint/$ENDPOINT_ID",source="api"}
cilium_event_ts{action="DELETE",scope="/v1/endpoint/container-id:$CONTAINER_ID",source="api"}

had an offline chat with @aanm, it looks like a regression in v1.12. in v1.11 and v1.10 path label shows up like this:
path="/apis/cilium.io/v2/namespaces/{namespace}/ciliumendpoints/{name}"

could we backport this to v1.12? 🤔


FRONTEND WITH FRAMEWORK: REACT-1.6 Create and initialize a React App

Contributors are required to include information about any prerequisite for installing React, its syntax , an example , an explanation (a good starting point https://reactjs.org/docs/create-a-new-react-app.html) about what each statement : For eg, What is npx, what does "cd" do , what does "npm start" do etc.
Also make sure -
Avoid copy/paste, We will be checking.
Changes should be made inside the Frontend_Web_Development_React_Angular_Vue/ dir inside Frontend_Web_Development_React_Angular_Vue branch.
Task will be assigned on first come first serve
Check out Contribution Guidelines
and Code Of Conduct

can i work on this

Can I work on a Video tutorial for this?

i will make video with documentation

I want to make the documentation to create and initialize a create app using npx command and show how to use this command to initialize an app with a template(including a custom template).

ok done I will do this

Can i do this

@riasenpai I would like to work on this issue. If it is reassigned , please do consider me for it.

can i do ?
please assign me

@paras-saxena11 bro it is already given to someone.Please wait for new issues

okay @anandhu720.
till when new issues will come?

can i do this

Till which date I have to submit

@Adarshswain max one week.Try to finish before that

Ok sure I will do it within 2 days

@riasenpai ma'am can you please assign this one to me?

@riasenpai ma'am can you please assign this one to me?

@ishangupta6412 bro this issue is assigned already to someone. Till then wait for new issues and stay active on discord.

pls assign me this issue i have to work on this

/assign this issue to me

/assign

@Adarshswain any updates on your work

sir i have almost completed sir within 2 day i will submit

Try to make it fast.5 days already finished bro

Yes bro tommorow I will submit forsure

Sir I have submitted the PR. please Check

What is status, If not resolved can I work on this ?

alerady done


Dunno

What is the problem you are having with rclone?
What is your rclone version (eg output from rclone -V)
Which OS you are using and how many bits (eg Windows 7, 64 bit)
Which cloud storage system are you using? (eg Google Drive)
The command you were trying to run (eg rclone copy /tmp remote:tmp)
A log from the command with the -vv flag (eg output from rclone -vv copy /tmp remote:tmp)

I'll close this issue - please re-open if you figure out what it was about!


AppWrite integration

it would be nice to add AppWrite integration as a service.
A complete backend solution for your [Flutter / Vue / Angular / React / iOS / Android / ANY OTHER] app

@Yurgeman   Kindly Add and Vote for this request here: https://feedback.coolify.io/


Does P4Runtime define a way for controller to configure timeout value for tables with idle timeout notification?

If not, should it?
I have a half-memory that I may have created an issue on this topic before.  I do recall Antonin saying that P4Runtime as defined today does not (yet) have a way to refer to properties of an entire table, so the answer may be the same here.
This need not hold up the v1.0 of the P4 Runtime API spec.  If it doesn't get into there, it seems worth it to me to consider how to add such a feature after that release.

Currently the timeout value is set per entry which gives a lot of freedom to the client (may be tricky to implement exactly but the spec does say that the server should try to approximate the timeout values as well as possible).
There is no way to set a default table-wide timeout value. There is no good way to set table-wide properties currently, but applying an entry property value to ALL entries in a table should be possible (without iterating over all entries) if we were to extend the wildcard mechanism (leave the "key" empty) that we already have for ReadRequest to WriteRequest as well. One could use this to overwrite the timeout value for every entry with a single TableEntry message.
Do you have a use-case in mind for which the current level of support (per-entry timeout) is insufficient or inconvenient?
Being able to activate / de-activate idle timeout on a table with a simple Protobuf message, without overwriting the timeout value for each entry with 0 with a wildcard Write, could be convenient. We could also introduce the ability to provide a default timeout value for the entire table (instead of just an on / off switch) but the semantics may be harder to define (interactions between default value and per-entry value) and we may have to wrap idle_timeout_ns inside a Protobuf message (to distinguish between 0 & unset).
I suggest we think about a generic mechanism to set dynamic table properties after the v1.0 release. Maybe we can simply add a new "entity" for this.

OK, now I know I am having a senior moment, because I am sure you have pointed out exactly these issues to me before :-)
Yes, there is no rush on any changes here for v1.0 release.  I had forgotten about the ability for the controller to specify an independent timeout value per table entry.
If you don't mind leaving this open for the possibility of asking about it in a post-v1.0-release working group meeting when things are otherwise quiet, maybe this time I will remember we talked about it.


Optimize imports using Intellij IDEA

Imports in the project are not cleaned up, and are not consistant: this is an update just using the "optimise imports" action from IntelliJ IDEA.
If that's fine with you @langchain4j , I can do another PR adding https://github.com/jhipster/prettier-java which is the official Prettier version for Java, maintained by the JHipster project.

The build is failing, but it seems to be because the main branch is currently broken. I'll wait until this is fixed and updated this branch.

Pardon for the broken main, I have fixed it, but I can't resolve the conflict in this PR


test: add benchmark for govukButton()

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.387%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
197

Relevant Lines:
197

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.387%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
197

Relevant Lines:
197

💛  - Coveralls


Remove Uphold as they have sunset ILP.

Description

Uphold no longer offers ILP (see https://support.uphold.com/hc/en-us/articles/360043226052). Hence this MR removes mention of Uphold as they are now no longer awesome. At least in regard to Web Monetization.

Thank you @Potherca !


Support yml as a file suffix

Hi,
first of all: Awesome idea and library. Thank you.
Many tools and libraries use yml as a file suffix for YAML files. I intuitively created a file called charts.yml.
Do you think you can support both file suffixes: yaml  and yml?

Thanks for the feedback, glad to hear it. 😄
I don't have a strong preference between the two file extensions, but I would not want to break existing setups. If you want to put in a PR to first try .yaml, and then .yml, I would merge it.
You can also use charts.yml by using the -f flag - helmfile -f charts.yml.

Going to close this, the workaround is there and if you feel strongly feel free to submit a PR.


Resolve Mining Feature dependencies and move to separate project

Refer to discussion on PR https://github.com/stratisproject/StratisBitcoinFullNode/pull/370
Mining Feature dependencies were resolved as follows:

Fixed RPCFeature.cs to look for actions in assemblies of configured full node features/controllers.
Configuration/Logging/LoggingConfiguration.cs

Remove reference to mining feature.
Add "RegisterLoggingConfiguration" method to be called from Mining feature.

Features/Consensus/ConsensusManager.cs

Remove dependency on Miner by adopting "GetWorkRequired" method from Miner

Features/Consensus/UnspentOutputs.cs

Make "_Outputs" public (was internal) to allow access by Miner from a different assembly

Features/Mining/MiningFeature.cs

Added new MiningRPCController class to feature.
Call RegisterLoggingConfiguration (see above)

Features/Miner/MiningRPCController.cs (new)

Adopted "generate" method from wallet RPC controller

Features/Miner/PowMining.cs

Move "GetWorkRequired" method to Consensus to remove its dependency on Miner

Features/Wallet/WalletRPCController.cs

Remove "generate" method which has been adopted by the new MiningRPCController

Instead of the coding we are adding to RPCFeature.cs we could add it to WebHostExtensions.cs:

using Microsoft.AspNetCore.Hosting;
using Microsoft.Extensions.DependencyInjection;
using Stratis.Bitcoin.Builder.Feature;
using Stratis.Bitcoin.Features.RPC.ModelBinders;
using System.Reflection;
using System.Linq;

namespace Stratis.Bitcoin.Features.RPC
{
    public static class WebHostExtensions
    {
        public static IWebHostBuilder ForFullNode(this IWebHostBuilder hostBuilder, FullNode fullNode)
        {
            hostBuilder.ConfigureServices(s =>
            {
                var mvcBuilder = s.AddMvcCore(o =>
                {
                    o.ModelBinderProviders.Insert(0, new DestinationModelBinder());
                    o.ModelBinderProviders.Insert(0, new MoneyModelBinder());
                });

                // Include all feature assemblies for action discovery otherwise RPC actions will not execute
                foreach (var assembly in fullNode.Services.Features.OfType<FullNodeFeature>().Select(x => x.GetType().GetTypeInfo().Assembly).Distinct())
                    mvcBuilder.AddApplicationPart(assembly);
            });

            return hostBuilder;
        }
    }
}


usockets update to 0.3.4

Library name:
usockets
New version number:
0.3.4
Other information that may be useful (release notes, etc...)
https://github.com/uNetworking/uSockets

@marzwu, the PR has been merged, please get latest source and try again.


Update order of '--secret-rm' and '--secret-add'

When using both --secret-rm and --secret-add on docker service update, --secret-rm was always performed last. This made it impossible to update a secret that was already in use on a service (for example, to change it's permissions, or mount-location inside the container).
This patch changes the order in which rm and add are performed, allowing updating a secret in a single docker service update.
Before this change, the rm was always performed "last", so the secret was always removed:
$ echo "foo" | docker secret create foo -f -
foo

$ docker service create --name myservice --secret foo nginx:alpine
62xjcr9sr0c2hvepdzqrn3ssn

$ docker service update --secret-rm foo --secret-add source=foo,target=foo2 myservice
myservice

$ docker service inspect --format '{{ json .Spec.TaskTemplate.ContainerSpec.Secrets }}' myservice | jq .
null

After this change, the rm is performed first, allowing users to update a secret without updating the service twice;
$ echo "foo" | docker secret create foo -f -
1bllmvw3a1yaq3eixqw3f7bjl

$ docker service create --name myservice --secret foo nginx:alpine
lr6s3uoggli1x0hab78glpcxo

$ docker service update --secret-rm foo --secret-add source=foo,target=foo2 myservice
myservice

$ docker service inspect --format '{{ json .Spec.TaskTemplate.ContainerSpec.Secrets }}' myservice | jq .

[
  {
    "File": {
      "Name": "foo2",
      "UID": "0",
      "GID": "0",
      "Mode": 292
    },
    "SecretID": "tn9qiblgnuuut11eufquw5dev",
    "SecretName": "foo"
  }
]

Commit message has a typo s/-=add/-add

commit message has a typo s/-=add/-add

nice catch; updated :smile:

I remember pointing this out on one of the earlier PRs, and getting the response that there would be a --replace-update flag to handle this case. But I guess we didn't add that?
Anyway, LGTM. Just wondering if there was a reason for it to behave this way.
cc @ehazlett

I remember pointing this out on one of the earlier PRs, and getting the response that there would be a --replace-update flag to handle this case. But I guess we didn't add that?

I missed that particular comment I guess, but there's indeed an open PR for that; https://github.com/docker/docker/pull/28461. That's still an option for future enhancement, but the basic options should work as well, and having rm always trump other options doesn't really make sense, and (IMO) is surprising behavior.

This can probably be merged unless there are outstanding concerns.

LGTM


Plot: Feature vectors spots, gaps, laberinths.

Given our current output from the network centrality code:
          "slope": -63.8,
          "offset": -1276.0,
          "offset50": -746.0,
          "mean": -551.25,
          "std":<PHONE_NUMBER>3025244,
          "latitude": 27.8923,
          "longitude": 11.6277,
          "date": "2016-02-15"

Can we make these plots?

We can get the feature vector itself from the return value of subgraph_centrality(), which is called in process_satellite_data.py


Add other user object data

Hi,
would it be possible to add additional user object data?
I'm looking for users is_staff or is_superuser
Need to work with this data in a place where I'm not able to get to the User object model.
And this plugin was already able to provide me with the username.
Thanks,
Christian

Looking at the tests, you should already get the full user object, same as if you'd use request.user


Failed to load CoreNFC on ios crash.

dyld: Library not loaded: /System/Library/Frameworks/CoreNFC.framework/CoreNFC
Referenced from: /var/containers/Bundle/Application/EB1AFB0C-E3D8-4400-ACED-58AB61EA86F9/Runner.app/Runner
Reason: image not found
I noticed nfc_in_flutter has this in their podspec, I tried this, but it didn't help.
s.weak_frameworks = ['CoreNFC']
Possible fix:  https://stackoverflow.com/questions/44946057/dyld-library-not-loaded-rpath-corenfc-framework-corenfc-ios11-and-xcode-9-be
or see: https://github.com/semlette/nfc_in_flutter/issues/20
I just updated Xcode, not sure if this was the cause, but it just started happening.
I'm testing on an iPhone 6.
  Nothing worked.  But I found this: https://medium.com/5-minute-break-while-coding/create-a-mostly-swift-framework-with-optional-features-7e8a9ac960f9

Are you saying you were able to get it working on the iPhone 6, but it has since stopped working?
From what I can tell, NFC reads were not allowed by third party applications on anything prior to the iPhone 7.
https://www.bluebite.com/nfc/iphone-nfc-compatibility
I have a 6s, and I am finding that await NfcManager.instance.isAvailable() returns false
and if I try to read a card anyways, nothing happens.
pbspec:  nfc_manager: ^1.3.2+4

Hello Every one
I am Working coreNFC Project I can Able read and write the NFC Tag I am Getting issue while password protected the NFC device using CoreNFC if any body having the idea regarding please let us know it will help me a lot
Thanks & Regards
iOS Developer


Revert "Mark several tests as flaky"

@mpociecha @dragos This only disables the HCR tests, should this be increased to the PC tests mentioned in #927?

It's hard to say whether marking changingManyPreferencesAtOnce as flaky solved the problem completely, since it was tested only during two builds. On the other hand I also don't like the idea of disabling tests completely.
@dragos WDYT?

@lrytz You can start another IDE validation build but I can't guarantee that it works. :(

OK, I started two more builds - thanks for the help!


Make timezone_at() keyword-args-only

Avoid problems like #37 from gotcha'ing anyone ever again. There's no real standard for the order of lat and lng so we can fix this with keyword args only

I am going to take care about the Readme, so you at least don't have to worry about this.