versionCode not increased

it looks like versionCode is never increased before releasing a new version. From the last release's build.gradle:
        versionCode 1
        versionName "1.1"

This is from tag 1.11 – the third release, so I'd expected
        versionCode 3
        versionName "1.11"

instead. Unfortunately, that's not just a cosmetic thing: versionCode is what Android uses internally to tell versions apart. Which means, the newer versions won't be offered for update, as Android thinks they're already installed. And even if force-updated, it will make reporting of issues difficult: which "version 1.1" had the user installed – this one (1.11) or the previous one?
TL;DR: could you please increase versionCode with each release (for technical reasons) – and versionName (to not confuse users :speak_no_evil:)? Thanks!

Hi IzzySoft, thank you again for commenting more than a year on this subject :)
I totally forgot about that. To correct this problem, do you think I should make new version with versionCode = versionName = GitHub release tag = 1.12?

I just realized that versionCode should be an integer apparently. I'll do versionCode equals 2 and the rest equals 1.12

Eh, so I remembered correctly I reported that already once… :see_no_evil: Yes, versionCode must be a positive integer. There are several patterns for this used in practice:

simply use it as "counter" – increase by 1 each release, then look at it after 5 years and say: oh, we did 42 releases :grin:
doing some maths. Using semantic versioning for versionName, then calculate versionCode as 10000xmajor + 100xminor + patch – so e.g. v1.0.3 results in 10003
lazy bob wants to be cool: use the time, pattern YYYYMMDD (err, limits you to 1 release per day – so don't make mistakes :rofl:)

Just remember: you can never ever decrease. So switching is possible from item 1 -> 3 but not the other way around.

I'll do versionCode equals 2 and the rest equals 1.12

Works for starters, yes! Always look towards the future – as that's where the rest of your life will happen :smile:
PS: Should you like a nice badge, you're welcome to link it :smiley:

Just noticed my "link it" was broken; fixed :wink:

Oh, I never quite got what you meant with the badge thing. Yeah sure, I'll add it!

I never quite got what you meant with the badge thing.

Yeah, my bad, giving you the link to my test site which is not available from outside my test net :see_no_evil:

Yeah sure, I'll add it!

Thanks! My repo seems to have a constantly growing number of users – 250k+ hits per day, 25k+ visitors per day downloading ~25G per day currently. For the close to 700 apps listed there it enables them to "set and forget": install the app and automatically get updates :smiley:


Anchors and Hashchange are impossible to use

Description
It is completely impossible to use simple anchors with this plugin. Neither the hashchange event nor a simple location.hash modify is possible since it always throws an error that I should use the vite-plugin-ssr. But there is not a single function to react to hashchanges, navigate to a hash or any kind of documentation.
I don't believe that this is supposed to be.
How can I fix that?
Error Stack
assert.js:40 Uncaught Error<EMAIL_ADDRESS>Usage] Manipulating `window.history.state` is forbidden (only vite-plugin-ssr is allowed to). Does one of your library try to manipulate it?

I agree this is something that should be fixed.
It's a regression introduced by https://github.com/brillout/vite-plugin-ssr/commit/510501b5d2757bc6e2be191ee07ce3d70c7b6797.
Does your use case work with 0.4.18?

Also, what is your use case?

I am developing a Single Page Presentation Website with animated scrolling between the sections. The Problem is that navigate doesn't fire the hashchange listener when loading the site together with an anchor. I managed to do some workarounds but I think it would be great if there is a way to handle Anchors.
Btw: I am using client side navigation!

The Problem is that navigate doesn't fire the hashchange listener when loading the site together with an anchor.

That seems unrelated to vps though.
That said, I do think vps can improve anchor use cases. I'll have a look at this.

That would be great! Thank you!

Fix released in 0.4.21. You should now be able to seamlessly use hash navigation. Let me know if something doesn't work.
(Btw. https://github.com/sponsors/brillout in case that's something you(r company) would be interested in.)

Seems to work, thank you!


Stop sending helper into node

Removed: Chef::Node.send(:include, ConsulCookbook::Helpers) from helper
Added extend ConsulCookbook::Helpers to attributes/default.rb
Run in windows, centos6 and centos7 via test kitchen.
Second kick at the can, so to speak. Solves: https://github.com/johnbellone/consul-cookbook/issues/498

Codecov Report

Merging #500 into master will increase coverage by 0.9%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master     #500     +/-   ##
=========================================
+ Coverage    61.4%   62.31%   +0.9%
=========================================
  Files           8        8
  Lines         399      398      -1
=========================================
+ Hits          245      248      +3
+ Misses        154      150      -4

Impacted Files
Coverage Δ

libraries/helpers.rb
54.54% <ø> (-1.98%)
:arrow_down:

libraries/consul_service_windows.rb
35.89% <0%> (-12.83%)
:arrow_down:

libraries/consul_execute.rb
100% <0%> (+45%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd0d583...f6ea29e. Read the comment docs.


cellranger scATAC workflow

Hello,
I used cellranger_workflow on Terra for my 10x scATAC-seq data. It worked pretty well last month but it gives me an error as below. may I know what could be the possible problem?
2019/10/04 21:48:39 Starting container setup. 2019/10/04 21:48:42 Done container setup. 2019/10/04 21:48:43 Starting localization. 2019/10/04 21:48:55 Localizing input gs://fc-6cb77780-e1cc-4346-8964-cce827d68568/5e52ff5e-a9e1-4f44-b23a-f179a7b74a13/cellranger_workflow/e62b09d8-4d10-468f-9e51-cea18ab5a217/call-generate_bcl_csv/script -> /cromwell_root/script 2019/10/04 21:48:56 Localizing input gs://fc-6cb77780-e1cc-4346-8964-cce827d68568/cellrangersamplesheet.csv -> /cromwell_root/fc-6cb77780-e1cc-4346-8964-cce827d68568/cellrangersamplesheet.csv 2019/10/04 21:49:02 Done localization.
2019/10/04 21:49:03 Running user action: docker run -v /mnt/local-disk:/cromwell_root --entrypoint= sccloud/cellranger@sha256:12d71966d2579f9d9ad8af0047df02057ef7101463f25d9a6dc0fef0b7c0a13f /bin/bash /cromwell_root/script Traceback (most recent call last): File "", line 10, in  File "/opt/conda/lib/python3.7/site-packages/pandas/core/series.py", line 3825, in map new_values = super()._map_values(arg, na_action=na_action) File "/opt/conda/lib/python3.7/site-packages/pandas/core/base.py", line 1300, in _map_values new_values = map_f(values, mapper) File "pandas/_libs/lib.pyx", line 2228, in pandas._libs.lib.map_infer File "", line 10, in  File "/opt/conda/lib/python3.7/re.py", line 192, in sub return _compile(pattern, flags).sub(repl, string, count) TypeError: expected string or bytes-like object
2019/10/04 21:49:15 Starting delocalization. 2019/10/04 21:49:16 Delocalizing output /cromwell_root/run_ids.txt -> gs://fc-6cb77780-e1cc-4346-8964-cce827d68568/5e52ff5e-a9e1-4f44-b23a-f179a7b74a13/cellranger_workflow/e62b09d8-4d10-468f-9e51-cea18ab5a217/call-generate_bcl_csv/run_ids.txt Required file output '/cromwell_root/run_ids.txt' does not exist.
Also, here is the content in my sample sheet.

Sample
Reference
Flowcell
Lane
Index
Data type

DNA_Lib 10696
hg19_atac_v1.0.1
gs://fc-6cb77780-e1cc-4346-8964-cce827d68568/H2NYMBGXC/190925_SL-NXC_0725_AH2NYMBGXC/
1-4
SI-NA-A1
atac

Thanks,

Can you please share the actual sample sheet file? Thanks.

Here you go.

On Oct 7, 2019, at 11:27 AM, Joshua Gould<EMAIL_ADDRESS>wrote:
Can you please share the actual sample sheet file? Thanks.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/klarman-cell-observatory/cumulus/issues/1?email_source=notifications&email_token=AIKTOK2RYOJFO3XXLNFMNYTQNNINHA5CNFSM4I5ZDBAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAQYOFY#issuecomment-539068183, or mute the thread https://github.com/notifications/unsubscribe-auth/AIKTOK47Z7RHZRHMHNTG4KLQNNINHANCNFSM4I5ZDBAA.

It looks like you forgot the attachment. Thanks.

I can still see the attachment in the email but it looks like it can not be uploaded to GitHub. Do you have another email address that I can send to you directly.
Thanks,
Jingyi

On Oct 7, 2019, at 1:51 PM, Joshua Gould<EMAIL_ADDRESS>wrote:
It looks like you forgot the attachment. Thanks.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/klarman-cell-observatory/cumulus/issues/1?email_source=notifications&email_token=AIKTOKYPDL7XA46WTGR3LXTQNNZINA5CNFSM4I5ZDBAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEARHGDQ#issuecomment-539128590, or mute the thread https://github.com/notifications/unsubscribe-auth/AIKTOK2YQI2XTX7QP6YTNK3QNNZINANCNFSM4I5ZDBAA.

You can email us at cumulus at broadinstitute dot org
On Mon, Oct 7, 2019 at 1:55 PM wjyzidane<EMAIL_ADDRESS>wrote:

I can still see the attachment in the email but it looks like it can not be uploaded to GitHub. Do you have another email address that I can send to you directly.
Thanks,
Jingyi

On Oct 7, 2019, at 1:51 PM, Joshua Gould<EMAIL_ADDRESS>wrote:
It looks like you forgot the attachment. Thanks.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/klarman-cell-observatory/cumulus/issues/1?email_source=notifications&email_token=AIKTOKYPDL7XA46WTGR3LXTQNNZINA5CNFSM4I5ZDBAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEARHGDQ#issuecomment-539128590, or mute the thread https://github.com/notifications/unsubscribe-auth/AIKTOK2YQI2XTX7QP6YTNK3QNNZINANCNFSM4I5ZDBAA.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.


auto scale min/max option doesn't seem to change anything

The option "Toggle auto scale min/max" doesn't seem to do anything.  I'm not too sure if I'm missing something that should trigger the auto scale min/max.  Thanks.

The change happens when you're zooming and scrolling a chart

I don't see any change in behaviour for zooming/scrolling in Line Charts when using "Toggle auto scale min/max".  From looking at the code I see where _autoScaleLastLowestVisibleXIndex/_autoScaleLastHighestVisibleXIndex are set but they don't seem to be used anywhere.

I see it now.  It's more visible in the scrolling and the shift of the graph from the recalculated offset values.  My mistake.


Truncate drops indexes?

I'm using L7 with the version 4 of the package.
truncate() drop my indexes, is that normal? I don't think it used to be before.

@elfeffe show code for understanding behaviour

Products::truncate();

Yes, currently we haven't merged this PR for version 4 https://github.com/jenssegers/laravel-mongodb/pull/1993
However, it will be soon, hopefully.

Oh, great, thank you

This should be fixed, I've merged master to develop.
Thanks!


Initializing progress inside a hidden div leads empty progress bar

If you initialize progress bar inside a hidden div causes progress bar not to render. Re-rendering (removing from DOM and restoring it back) solves the problem.
TODO: add a jsFiddle link

I'm having trouble with this too. I'd like the loading bar to render in an initially-hidden pop up modal. Rendering after the modal pops up results in terrible performance.

looks like the progress is actually rendered but with wrong dimension( width and height ). there is a function "fit" which should resize the bar container, but somehow it didn't update the container.
I'll try to add two patch:

fix "fit" function so we can update dimension when needed.
add support of 100% in dimension so the size of bar automatically fit the size of its container.

reference: b190750bb726cdafdc603fa87e53ffb36a27ff74  and dd66ae2373f6df570678adae8f9fbf456d2ed447
I added some options to solve this and related issues:
data-bbox
I used getBBox to calculate the progress bar's dimension, which is not available when element is hidden. so I update all presets to add a default bbox, and add the "data-bbox" option for users who customize their own progress bar.
If you use presets, you won't have to worry about this since I've added a bbox config for each preset.
data-set-dim
I've fixed the fit function to always update dimension if it's not set from user, so calling bar.fit() should work now, Then I found - if user set the width/height with external css, it won't work because the fit function overwrite it. set data-set-dim="false" can disable fit function from modify the container's dimension.


Crash user settings

Holovibes sometimes crash at the opening. Removing the user settings solves the problem.
Further investigations needs to be done to understand how to reproduce the crash.
It seems to be related to the execution of other versions of holovibes, and the use of the camera.

One of the sources: opening the app with the settings set on an active camera in holo mode, was solved


Terminal windows are closed whenever updated from the store

On several occasions I've experienced that when I leave my computer for a while and come back, all my terminal windows are gone.
After some investigation I've reached the conclusion that this happens because the app was installed through the Microsoft store, and just received an update.
This is probably fine for your average note taking app or Candy Crush game, but for a terminal with several tabs open that do actual work (and perhaps even long-running (like several days) processes open in remote SSH sessions) this is completely unacceptable.
Is there a way to avoid the terminal being restarted after receiving an update through the Store? A notification would be fine to let me know that I should restart it on the earliest convenient moment, but having it just disappear can in the worst case scenario cost me days of work that will need to be restarted, and in the best case some inconvenience and a few minutes to get back to where I was before...
Luckily a workaround exists: disable apps auto-updating (https://support.microsoft.com/en-us/help/15081/windows-turn-on-automatic-app-updates), but is there really no better way of handling this?

Environment
Windows build number: [Version 10.0.18362.418]
Windows Terminal version (if applicable): 0.7.3382.0

Steps to reproduce
Do normal everyday work in terminal, wait for an update to arrive.
Expected behavior
A notification to restart the app at my earliest convenience, or that the app continues to run with the old version, and that all new instances are started as the new version (like in Linux, where executables linger on in RAM until closed regardless of whether the file they started from still exist).
Or at the very least that it would notify me that new updates were available, but not install them.
Actual behavior
Terminal windows suddenly disappear with no explanation whatsoever, before I open the Store app and see that it was just now updated...
Sorry if this issue seems a bit salty, but it's really annoying - right up there with getting to the office in the morning to continue where you left off yesterday, only to find out that the PC rebooted automatically to install Windows updates (hint: not cool).

Actually, the way you're doing it for Visual Studio Code is perfect - why not use the same approach here if possible? :)

+1 I just lost hours worth of state because of this behavior.

The other way around is also not good.
Previously I had a lot of errors in my Event Viewer from Windows Update about the fact that Windows Terminal can't be updated, because the executable is running.
We need a better process of updating the app. And it would be nice if we have some kind of configuration options like: automatic restart after update - on/off and so on :)

Just having automatic updates install upon next launch would be a perfectly fine behavior.

Also note, there is a massive difference in these experiences:

windows restarts while my console apps are running and all my terminal state is lost AND my enqueued commands for long-running operations to finish while i am sleeping are in an unknown state
windows restarts for updates after my enqueued commands finish and all my terminal state is lost
windows waits to restart before my enqueued commands finish and restarts terminals with the same windows open
windows waits to restart before my enqueued commands finish, and upon restart, terminal relaunches to to the exact same display state
windows waits to restart before my enqueued commands finish, and upon restart, terminal relaunches to to the exact same display state including command history

please, on behalf of developers everywhere with long build times, consider moving us more and more to #5

@DHowett-MSFT I see that you've mentioned this issue from other closed issues but you have not actually commented here regarding the problem or the intention to fix it. I was about to open a new report because this issue also doesn't capture the entire story. But instead I'll post some findings here and hope that you can shed some more light on what the plans are.
First, the problem is not just that the console sessions are silently closed when the program automatically updates. I haven't been able to fully trace what set of circumstances causes this, but I've had processes just get orphaned. The only reason I even realize this is that when I go to re-open one of my command line processes, I see that the listening port is still in use and I can't open it. I've then had to go searching through TCPView and Process Explorer to find the orphaned process and kill it.
Second, I tried to circumvent all of this by installing the Terminal app via Chocolatey. However, it still gets updated via the Windows Store!? I'm not sure why that would happen if I did not install via the Store.
At the very least I would LOVE an option to disable automatic updates. Another solution might be to tie all updates to Terminal to the next Windows reboot cycle? But I think from your comments on other threads this is what you aren't able to do when distributing via the Store.
I would also make the recommendation to just not distribute this application on the Windows Store. This is not really an ideal app for that delivery mechanism. This is a power user / developer targeted app, so I would think it would be distributed more like Visual Studio or Visual Studio Code, or even Power Toys.
Thanks for your teams work on this app. Unfortunately I am going to have to abandon it until this issue is fixed because I'm losing a lot of time and work every other week when an update is pushed and my long-running processes are lost.

You've got the critical points down pat.
For right now, it's possible to extract the msixbundle (and the architecture-specific msix inside it) and run WindowsTerminal.exe directly. We're not intending on breaking this. 🤞

@DHowett Thank you for the quick response!
I went ahead and uninstalled my existing copy of Terminal (thereby unlinking it from the Windows Store), and am now running it directly from the exe extracted from the package you referred to. Appears to work the same, although the version number in the about box is listed as 0.11.200512003-release1.0.
Hopefully this helps some others who are struggling with the automatic updates. I will keep an eye on the repo so that I can perform my own updates manually.

@DHowett Thank you for the quick response!
I went ahead and uninstalled my existing copy of Terminal (thereby unlinking it from the Windows Store), and am now running it directly from the exe extracted from the package you referred to. Appears to work the same, although the version number in the about box is listed as 0.11.200512003-release1.0.
Hopefully this helps some others who are struggling with the automatic updates. I will keep an eye on the repo so that I can perform my own updates manually.

So you did not install from the msixbundle available from the 'Releases' page?
That's what I just did, and how Store reports the app is 'installed'... so I expect it will still be subject to (auto)updates. Correct?
Can you please elaborate on how you got a runnable instance deployed without Store considering it's installed (and thus needs updating)?
TIA

@sba923 You can "unzip" the msixbundle, and then just run the exe from there. I copied the folder to Program Files and added it to my PATH env for extra convenience.
I have had no problems with auto-updates since doing it this way. I watch the github project for any releases that have fixes/features that I want.

@sba923 You can "unzip" the msixbundle, and then just run the exe from there. I copied the folder to Program Files and added it to my PATH env for extra convenience.
I have had no problems with auto-updates since doing it this way. I watch the github project for any releases that have fixes/features that I want.

Thanks for the tip!
I chose not to add the folder to the PATH, because that's not absolutely required (and I have a theory where adding tons of app folders to the PATH would slow down the system...).
Something worth mentioning: uninstalling will delete %LOCALAPPDATA%\Packages\Microsoft.WindowsTerminal_8wekyb3d8bbwe\LocalState where the settings.json file is located (I know, that's part of the "good" sandboxing idea beyond store app deployment), so you'll lose your settings if you don't make a copy first.
In the "XCOPY-deployed" instance, the settings.json file resides at %LOCALAPPDATA%\Microsoft\Windows Terminal.
HTH

I have a theory where adding tons of app folders to the PATH would slow down the system

A bit of research can help you get the info you need in order to be able to perform the necessary tests to confirm/deny your theory so you can start acting on knowledge. Don't act on theories!

Bash PATH length restrictions
Duplicate entries in $PATH a problem?

I have a theory where adding tons of app folders to the PATH would slow down the system

A bit of research can help you get the info you need in order to be able to perform the necessary tests to confirm/deny your theory so you can start acting on knowledge. Don't act on theories!

Bash PATH length restrictions
Duplicate entries in $PATH a problem?

I support your reasoning, but a simple model proves that the more folders you have on the PATH, and the more items therein, the more time it takes to search for a specified EXE or DLL.
Of course, the actual measurable impact depends on how much optimization (e.g. caching) has been put into that search algorithm, and of the platform's performance.
And that is context and OS-dependent (the articles you refer to pertain to searches done by the bash shell on Unix, my use case is the Windows APIs that rely on EXE/DLL searches on the PATH).
My plan is to start a discussion there hoping that some Microsoft people with knowledge about those internals will react to my "theory."

Seeing this issue as well, its very annoying.

What's the point of swooping in like a hawk to close other reports of this problem if this issue is just going to sit here, stale?

@aaroneg because having six copies of an issue is harder on us, and harder to present to our leadership, than one issue with a robust single discussion thread in it? This issue isn’t stale insomuch as it has to move at the speed of Windows, rather than the speed of our open-source project.

Now: it seems like the discussion here has reached its terminus, so there isn’t value in leaving it unlocked for angry people to get their digs in. It’s on our radar–just as much as it has been since our first update–and we only have as much sway with the store folks as we can get.


Fix - implement curry() with placeholder support - Implementation 2

Ques

Implement curry() with placeholder support

Section
Solution -> Curry Implementation 2
Fix
When doing the merge of arguments, replace the placeholder only till nextArgs (or argsFrom) has data. Otherwise, keep it as a placeholder. Hence, a length check is required here for argsFrom. Otherwise, a case like this will fail -
curriedJoin(_, _, _)(1)(_, 3)(2)

Thank you!!

Can we also include every solved questions link in the main readme.md file also so that it will be really easy to navigate through the present solutions, and that could also have the links as tabular format which might also include the different locations links as well.
Hopefully this will reach to the repo owners.


Update PingResource.java

Dear @Akhiiii,
Thank you for your interest in contribution to OFBiz.
Currently, the Apache OFBiz use SVN for code management.
If you would like to contribute any feature, you can discuss it on the dev mailing list [1] and I recommend you to read this document, Contributors Best Practices [2].
[1] http://ofbiz.apache.org/mailing-lists.html
[2] https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Contributors+Best+Practices

No feedback,  now conflicts, closing


[stable/spinnaker]#1899 Added nodeSelector for spinnaker

[stable/spinnaker] Added nodeSelector for spinnaker.
related to #1899

/cc @viglesiasce


Server Lag Issues

Origin: https://github.com/CumulusMC/Art-of-Alchemy/issues/25, https://github.com/CumulusMC/Art-of-Alchemy/issues/42
I haven't exactly been able to replicate this yet. If anyone experiencing this could submit information about the circumstances around it, that would be much appreciated.

Solved: #42


Enhancement: Ability to change the order of the presets

What features would you like to see added?
Having the ability to rearrange presets would be incredibely useful
More details
[insert picture of a profile with a lot of presets here]
Which components are impacted by your request?
UI
Code of Conduct

[X] I agree to follow this project's Code of Conduct

You can somewhat do this now as presets are ordered by last updated, with recent at the top, as well as the default preset being at the top.


maybe you should add type="button" attribute for every button

I have use it in bootstrap modal and inner form , when I click the button "choose file", the modal has be closed.

i check this, but i dont have the same behavor. Everything looks fine. See here

@ssbeefeater I click choose file button, the form has be submit, then, current page has be relaod, so , modal has be closed.

I see now. It's easy fix.


devspace sync --all option

Is your feature request related to a problem?
Not related to a problem
Which solution do you suggest?
When using devspace sync --config some/devspace.yml if you have multiple sync defined in your file, devspace sync will ask you which sync you want to start.
Having an option --all to start all sync at the same time with the same one command would be great :)
It would start all syncs, just like they would all be started when you simply run devspace dev

/kind feature

@igoooor yes I think that is a good idea. Implementation shouldn't be too hard since the functionality is basically already there.

Cool! can't wait for it :D

+1 on this
Currently having to run 4 different session and running each sync manually via command arguments. Would be great if we could just put all this into the devspace config file and forgot about it!

@JParkinson1991 As a workaround I use the command dev --skip-pipeline which according to the help does Skips build & deployment and only starts sync, portforwarding & terminal which is what we want. Not straightforward, but it works ;)


incorrect rows reported in onChangeVisibleRows

There is a bug in onChangeVisibleRows when the renderSeparator is not null. The _updateVisibleRows function does not account for the presence of separator frames in the _childFrames array.

Built using https://gist.github.com/dmueller39/f95028f6fe8bd251944bb604e51f18b2
There is a PR for this already, but I figured I needed to open an issue to give it more visibility:
https://github.com/facebook/react-native/pull/6965

@facebook-github-bot duplicate #6702

@damusnet tells me this issue is a duplicate of #6702. Let's discuss there, closing this one.


Not an issue ,but rather a question

is it safe to set emojis as custom status? ,they work just like if you had nitro!!

Sorry for late reply (damn GitHub doesn't send push notifications on issues). I tested this and for me it's client only and automatically resets after a minute. Anyway I recommend not to set custom emojis to status


onedrived-pref wrong

Traceback (most recent call last):
File "/usr/lib/python3.6/site-packages/keyring-11.0.0-py3.6.egg/keyring/backends/kwallet.py", line 37, in priority
bus = dbus.SessionBus(mainloop=DBusGMainLoop())
AttributeError: module 'dbus' has no attribute 'SessionBus'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/bin/onedrived-pref", line 11, in
load_entry_point('onedrived==2.0.0', 'console_scripts', 'onedrived-pref')()
File "/usr/lib/python3.6/site-packages/pkg_resources/init.py", line 572, in load_entry_point
return get_distribution(dist).load_entry_point(group, name)
File "/usr/lib/python3.6/site-packages/pkg_resources/init.py", line 2755, in load_entry_point
return ep.load()
File "/usr/lib/python3.6/site-packages/pkg_resources/init.py", line 2408, in load
return self.resolve()
File "/usr/lib/python3.6/site-packages/pkg_resources/init.py", line 2414, in resolve
module = import(self.module_name, fromlist=['name'], level=0)
File "/usr/lib/python3.6/site-packages/onedrived-2.0.0-py3.6.egg/onedrived/od_pref.py", line 9, in
import keyring
File "/usr/lib/python3.6/site-packages/keyring-11.0.0-py3.6.egg/keyring/init.py", line 3, in
from .core import (set_keyring, get_keyring, set_password, get_password,
File "/usr/lib/python3.6/site-packages/keyring-11.0.0-py3.6.egg/keyring/core.py", line 153, in
init_backend()
File "/usr/lib/python3.6/site-packages/keyring-11.0.0-py3.6.egg/keyring/core.py", line 66, in init_backend
keyrings = filter(limit, backend.get_all_keyring())
File "/usr/lib/python3.6/site-packages/keyring-11.0.0-py3.6.egg/keyring/util/init.py", line 21, in wrapper
func.always_returns = func(*args, **kwargs)
File "/usr/lib/python3.6/site-packages/keyring-11.0.0-py3.6.egg/keyring/backend.py", line 196, in get_all_keyring
exceptions=TypeError))
File "/usr/lib/python3.6/site-packages/keyring-11.0.0-py3.6.egg/keyring/util/init.py", line 31, in suppress_exceptions
for callable in callables:
File "/usr/lib/python3.6/site-packages/keyring-11.0.0-py3.6.egg/keyring/backend.py", line 188, in is_class_viable
keyring_cls.priority
File "/usr/lib/python3.6/site-packages/keyring-11.0.0-py3.6.egg/keyring/util/properties.py", line 24, in get
return self.fget.get(None, owner)()
File "/usr/lib/python3.6/site-packages/keyring-11.0.0-py3.6.egg/keyring/backends/kwallet.py", line 135, in priority
return super(DBusKeyringKWallet4, cls).priority - 1
File "/usr/lib/python3.6/site-packages/keyring-11.0.0-py3.6.egg/keyring/util/properties.py", line 24, in get
return self.fget.get(None, owner)()
File "/usr/lib/python3.6/site-packages/keyring-11.0.0-py3.6.egg/keyring/backends/kwallet.py", line 38, in priority
except dbus.DBusException as exc:
AttributeError: module 'dbus' has no attribute 'DBusException'

What version of keyring is you using? Check it running pip3 freeze | grep keyring. I'm running with this one:
keyring==11.0.0
keyrings.alt==3.0


Index entry left behind on deleting the item that triggered a dynamic hook

Tried in onBeforeUpdate as well as in OnAfterUpdate
doc.delete()

The record gets deleted but the index entry remains. The index is an automatic unique index.
Also get same result for db.delete(id) and orient.getGraph().command('sql',"delete vertex #17:0" ) where #17:0 is the RID of the current record.
Note: If I delete some other record, then things are find.
orientdb-community-2.1-rc3

hi @Ziink,
Indexes are not triggered if you do a delete from an hook, because indexes as well are hooks, please do the delete outside the hook.
This may be fixed in 3.0.

Hi,
This has been fixed in 3.0.0
Closing


Not working in case of VideoView

I like to rotate my VideoView. I tried your library but it did not worked in this case. Any workout for this?

VideoView draws directly into video memory, It isn't possible to rotate it the way RotateLayout does it.

Hi, do you know why the views  can only be ratated in multiples of 90 degress?
I've modified this library by removing the fixAngle method to allow rotation for any angle, and indeed the view rotates its drawn content by the specified angle but the view itself is not rotated (example 45 degrees), but if I rotate in a 90 degrees it rotates view itself correctly.
I've search arounf the web and everybody says "use setrotation" or "rotation in xml...", but I'm not able to rotate a view itself by 45 degrees.
Can anyone point me in the right direction to be able to rotate a view in arbitrary angle?
Thank you very much

@david99999 It is possible to rotate a view by any angle. But there is a problem. Any view in Android should be inside a rectangle with the sides parallel to the sides of the screen. And determining rectangle containing another, rotated rectangle is not a trivial task. This is why I skipped implementation of rotation of non multiple of 90. But it still can be done and it isn't very challenging task.

Hi @rongi thank you very much for your answer, is there any way to override the onlayout por the required method to draw directly in a rotated position?

@david99999 Yes, it is possible, but not trivial and requires some effort.

@rongi thank you, can you point me in the right direction to do that?
Which method should I used?


Remove unnecessary operation when sorting users

Maybe there was a good reason for this .reverse() but I can't admit I'm seeing it right now...
The entire method could probably use a rewrite but this is the least that can be done here.

I wouldn't merge this because #167 actually knows which user modes are used on the server, and that can be used instead of this hardcoded array.

Okay, I did it in 53c367b58bcdf5068390ba2f6d50d7e278f9b95f, and now it sorts the whole user list within a single pass. Closing this PR.

Reopening this: even though it's already done in #167, it is still a few weeks down the road (that kind of change requires intensive testing and is not ready yet, not to mention reviewers' time allocation) while this PR is already there and done.
If others think it's unnecessary so be it, but I think this is a minor improvement that can easily go with the next patch release.

It's obviously not a massive improvement (although it is an improvement none-the-less) so I wouldn't have spent the time looking for it. However, as you have already done the work, I see no reason to deny it, especially as #167 won't be done anytime soon (we are at the very least waiting on 2 bugs to be fixed with the framework itself).
So I'll :+1: this but stick second reviewer on it, and @maxpoulin64 or @xPaw can fight it out :-P

I guess I'll side with @YaManicKill on this one, since it is a really trivial fix and :+1:. It's kind of useless even for me as this really only moves 4 values, but I don't see any particular reason to deny it. I'm looking forward to @xPaw 's actual proper implementation of course.


[TOPI]][RELAY][MXNET]Reverse/Flip operator

reverse/flip added support for axes similar to mxnet/numpy.
@FrozenGene Please help me to review this PR.

@siju-samuel please rebase the code.


Glob pattern in included files produces different results each time

Type: Bug
When using a glob pattern in "files to include" in the search bar such as ./workspace/path/to/**/*.py, I get different results everytime I click on the refresh icon.
This is not the case when I only use a wildcard like *.py.
Tested with Version 1.79.2 and 1.80.0-insider.
Version: 1.79.2
Commit: 695af097c7bd098fbf017ce3ac85e09bbc5dda06
Date: 2023-06-14T08:59:55.818Z
Electron: 22.5.7
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: <IP_ADDRESS>-electron.0
OS: Linux x64 5.15.0-76-generic snap
VS Code version: Code 1.79.2 (695af097c7bd098fbf017ce3ac85e09bbc5dda06, 2023-06-14T08:59:55.818Z)
OS version: Linux x64 5.15.0-76-generic snap
Modes:

System Info

Item
Value

CPUs
Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz (16 x 2300)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: disabled_softwarevulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
1, 2, 2

Memory (System)
30.97GB (12.49GB free)

Process Argv
--no-sandbox --force-user-env --unity-launch --crash-reporter-id 28e31990-950d-453b-bda3-028fa6c72c02

Screen Reader
no

VM
0%

DESKTOP_SESSION
ubuntu

XDG_CURRENT_DESKTOP
Unity

XDG_SESSION_DESKTOP
ubuntu

XDG_SESSION_TYPE
x11

Extensions: none
A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscoreces:30445986
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
pythonvs932:30410667
py29gd2263:30776702
vsclangdf:30486550
c4g48928:30535728
dsvsc012cf:30540253
pynewext54:30695312
azure-dev_surveyone:30548225
3biah626:30602489
pyind779:30671433
89544117:30613380
vscrpc:30673769
pythonsymbol12:30671437
showlangstatbar:30737416
vsctsb:30748421
pythonms35:30701012
03d35959:30757346
pythonfmttext:30731395
pythoncmvfstrcf:30756944
fixshowwlkth:30771522
pythongtdpath:30769146
i26e3531:30780429
pythonnosmt12:30779714
pythonidxptcf:30772540
pythonnoceb:30776495
e537b577:30772215

Are the results always missing some, or is it just sometimes whole and sometimes not? Are you hitting the limit to the number of files searched?

Thank you for looking into this.
The number of results and the number of files with hits are different each time I refresh the search.
The file limit is never reached.

Hmm. Are you waiting until the search finishes? Can you provide a screen recording?

https://github.com/microsoft/vscode/assets/27998820/392de948-b576-42d2-82c0-8544939d368c

I think this should be fixed by https://github.com/microsoft/vscode/pull/189289. It seems that there is supposed to be a message about hitting the file limit. The reason that it's much lower than the actual limit stated in the settings is because of a race condition documented in this issue: https://github.com/microsoft/vscode/issues/189359

@qi55wyqu This should be fixed and we would appreciate you trying it out and letting us know if you still see the problem, thanks

@qi55wyqu This should be fixed and we would appreciate you trying it out and letting us know if you still see the problem, thanks

I can confirm that it has been fixed. Thank you very much!


Add video to overview article

@jinzh-azureiot : Thanks for your contribution to the Azure documentation! The author, @dsk-2015, has been notified to review your proposed change.

@kgremban could you help review and merge this change? I added a cloud 9 video to the overview article.

Looks good. It seems that my author changes haven't caught up here yet, so I'll send an email to the reviewers with the approval.


Add new theme feature

Allow user to choose their favourite theme (Dark or light) for ModCheck

Codecov Report
Patch coverage: 15.21% and project coverage change: -1.53 :warning:

Comparison is base (0e69638) 69.35% compared to head (ffbf38a) 67.83%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #89      +/-   ##
============================================
- Coverage     69.35%   67.83%   -1.53%
- Complexity      477      479       +2
============================================
  Files            86       88       +2
  Lines          1560     1604      +44
  Branches        172      176       +4
============================================
+ Hits           1082     1088       +6
- Misses          416      453      +37
- Partials         62       63       +1

Impacted Files
Coverage Δ

...rc/main/java/seedu/address/logic/LogicManager.java
65.21% <0.00%> (-9.79%)
:arrow_down:

...va/seedu/address/logic/commands/CommandResult.java
60.00% <0.00%> (-23.34%)
:arrow_down:

...java/seedu/address/logic/commands/DarkCommand.java
0.00% <0.00%> (ø)

...ava/seedu/address/logic/commands/LightCommand.java
0.00% <0.00%> (ø)

.../seedu/address/logic/parser/AddressBookParser.java
69.56% <0.00%> (-6.63%)
:arrow_down:

src/main/java/seedu/address/model/Model.java
100.00% <ø> (ø)

...rc/main/java/seedu/address/model/ModelManager.java
94.36% <0.00%> (-5.64%)
:arrow_down:

src/main/java/seedu/address/ui/MainWindow.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/model/UserPrefs.java
81.08% <77.77%> (+1.08%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[FEATURE] Support CF_TRACE environment variable

What area do you want to see improved?
terraform provider
Is your feature request related to a problem? Please describe.
When I apply a seemingly-reasonable terraform plan only to then see opaque, API-relevant errors from the provider, I'm not sure what I'm doing wrong.
Describe the solution you would like
I would like the provider to respect the CF_TRACE=true environment variable, so that I can see what API calls the provider is making.
Describe alternatives you have considered
I tried using TF_LOG=DEBUG but the output was not helpful since it didn't tell me anything about what the provider was actually doing, only the parts that Terraform cares about.
Additional context
In this particular case, I was seeing:
│ Error: Error pushing app
│
│   with module.spiff.cloudfoundry_app.connector,
│   on ../main.tf line 134, in resource "cloudfoundry_app" "connector":
│  134: resource "cloudfoundry_app" "connector" {
│
│ error while waiting for app spiffworkflow-connector package to build: received state FAILED while waiting for async process
╵

The actual problem was that I was pushing a docker image using a bad imageref, and staging was failing with a 403. Setting CF_TRACE=true might not have revealed that was the problem, but it was something I tried along the way, and I was surprised that it didn't work.
Similarly, I was seeing:
│ Error: API Error in creating managed service instance
│
│   with module.spiff.cloudfoundry_service_instance.database,
│   on ../main.tf line 24, in resource "cloudfoundry_service_instance" "database":
│   24: resource "cloudfoundry_service_instance" "database" {
│
│ Unable to create service instance spiffworkflow-database: executing POST request for /v3/service_instances failed: cfclient error (CF-UnprocessableEntity|10008): Invalid
│ space. Ensure that the space exists and you have access to it.

The actual problem was that cloudfoundry_service_instance wants the space attribute to be the .id (GUID) for the space, not the name, which is what I supplied. It would be good to get a "that doesn't look like a GUID" hint. Or, to be consistent, cloudfoundry_service_instance could optionally accept org_name + space_name in lieu of space, with behavior similar to cloudfoundry_app: it expects names attributes for its target org and space and looks up the GUID transparently.

This issue has 2 parts to it:

For the first part, an issue and fix has been raised in the go-cfclient. We'll need to get this merged before addressing it here.

As for the second part of the error, I'd like to point out that a validation for UUID was missing, which has been addressed.


Missing peer dependency in react-scripts

You have peerDependenciesMeta there without actual peerDependencies - I believe this doesn't work as expected, peerDependenciesMeta requires peerDependencies to be there as it's merely additional information, not a replacement.

Hmm it would seem you're correct: https://github.com/yarnpkg/yarn/pull/6671/files.
It's a bit of a tricky situation since it doesn't appear that npm has support for this yet, and adding under peerDependencies will start throwing warnings for folks that don't have<EMAIL_ADDRESS>or later.
We may want to do this as part of our v4 release. I'll mark as such and see what the other maintainers think.

From what I understand CRA+TS would be broken for strict package managers like pnpm or yarn in pnp mode without this peer dependency specified. I was facing similar problem lately for the other package and we decided to just go with specifying peer dep and marking it as optional. We can always recommend using new version of npm and on older versions it will merely cause a warning - things will still be very much functional, so... 🤷♂

Good point. Oct 21 appears to have been the first Node release that included npm >= 6.10. I'm okay with the warning to support the other package managers.


Multimaster vagrant

Added an environment variable to choose the number of masters to Vagrantfile.

I signed it!


Global timeout for an entire flow

I did some research on the documentation but couldn't find a desired answer. Is there a way to set up timeout for an entire Metaflow Flow?
Something like a @timeout decorator for the FlowSpec class?
from metaflow import FlowSpec, timeout, step
import time

@timeout(seconds=5)
class TimeoutFlow(FlowSpec):

    @step
    def start(self):
        time.sleep(10)
        self.next(self.end)

    @step
    def end(self):
        pass

if __name__ == '__main__':
    TimeoutFlow()

Thank you!

@zexuan-zhou step-functions create supports a global --workflow-timeout. Having a flow-level @timeout like you suggested would be a good idea, so it would work for local runs too.
Thanks for the suggestion!

@zexuan-zhou step-functions create supports a global --workflow-timeout. Having a flow-level @timeout like you suggested would be a good idea, so it would work for local runs too.
Thanks for the suggestion!

@zexuan-zhou step-functions create supports a global --workflow-timeout. Having a flow-level @timeout like you suggested would be a good idea, so it would work for local runs too.
Thanks for the suggestion!

Thank you for the fast reply. I wasn't aware of the timeout functionality in step functions. Appreciate it.

@zexuan-zhou step-functions create supports a global --workflow-timeout. Having a flow-level @timeout like you suggested would be a good idea, so it would work for local runs too.
Thanks for the suggestion!

Thank you for the fast reply. I wasn't aware of the timeout functionality in step functions. Appreciate it.


Installation problem

when tried to install with pip in virtual environment, it throws an error as below.

pip install ml_metrics
Collecting ml_metrics
Using cached ml_metrics-0.1.4.tar.gz (5.0 kB)
Preparing metadata (setup.py) ... error
error: subprocess-exited-with-error

× python setup.py egg_info did not run successfully.
│ exit code: 1
╰─> [1 lines of output]
error in ml_metrics setup command: use_2to3 is invalid.
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed
× Encountered error while generating package metadata.
╰─> See above for output.
note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

Same for me

pip install --upgrade pip "setuptools<58.0"
Run this before installing ml_metrics. I tried and it worked.
Source: LINK

Thank you @chita216.
I do:
pip install --upgrade pip "setuptools<58.0"
pip install ml_metrics --upgrade


symbiflow: fix extraction of runtimes

Signed-off-by: Alessandro Comodi<EMAIL_ADDRESS>Fixes https://github.com/SymbiFlow/fpga-tool-perf/issues/242

Otherwise LGTM if it goes green.


Missing OMIM/DOID

IN the new version of normalization, there are about 25 identifiers that are not showing up in the final output for disease/phenotpyic feature.
DOID:0060320
DOID:0060321
DOID:0111946
DOID:11086
DOID:11282
DOID:11772
DOID:12143
DOID:1283
DOID:1392
DOID:14070
DOID:1607
DOID:1920
DOID:2058
DOID:4377
DOID:4379
DOID:9341
OMIM:114580
OMIM:177800
OMIM:212050
OMIM:607644
OMIM:613108
OMIM:613956
OMIM:614162
OMIM:615527
OMIM:616445

This happens as follows: during merge, these get glommed together with an HP.   In many cases, this seems entirely legitimate.
During type assignment, this gets turned into a phenotypic feature (no mondo + HP)...
During output, it is recognized that OMIM, DOID are not valid identifier prefixes for phenotypes and they are stripped out.

Fundamentally, this represents differing views across vocabularies on the type of a disease/phenotype.  DOID really think that hypoglycemic coma is a disease, even if everybody else says it's a phenotype.
--
Options:

Update phenotypic feature in the biolink model to include DOID and OMIM as valid prefixes.  This is basically saying that we think that DOID and OMIM have misclassified these entities.

Make DOID / OMIM + HP come out as Disease nodes.  This is saying that we think uniformly that HP (and possibly UMLS, etc) have misclassified them.

As is, we say that these are incompatible, forget about them.

It may be worth holding off until we understand conflation better.


Why is LAYER_ARRAY_BUFFER_SIZE set to 65536 in wavenet.cpp?

I am trying to run this code on the Daisy Seed platform, which has limited memory, and I observe significant memory usage spikes during the instantiation of _layer_buffers. Is this specific number  tied to a specific requirement for the Wavenet model's performance or functionality?

Nah. The thinking when I first wrote that was that I'd rather not have to copy the end of the buffer back to the start too often, and I was thinking about general-purpose computers where memory is cheap.
However, the cost of that memcpy is probably vanishingly small compared to the rest of what's going on.
I forget the full context since I'm not looking at it, but I thought I had a few comments about it. There is a lower length limit, but this isn't close to it.
You should be able to shorten it a lot without any consequences.
But also, the allocations there shouldn't be in a time-critical part of the code. They are right now, and it's just a to-do to clean that up (i.e. do all the memory allocations during Reset().)
hope that helps!


RichEditBox raises TextChanged event when spellcheck detects misspelt word

Describe the bug
The Microsoft.UI.Xaml.Controls.RichEditBox raises its TextChanged event when the spellcheck detects a misspelt word even though the text did not actually change.
Steps to reproduce the bug
To demonstrate the issue, create a new blank WinUI 3 app project in Visual Studio and put the following code in your MainWindow.xaml and MainWindow.xaml.cs files:
MainWindow.xaml:
<?xml version="1.0" encoding="utf-8"?>
<Window
    x:Class="RichEditBox_Test.MainWindow"
    xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
    xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
    xmlns:local="using:RichEditBox_Test"
    xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
    xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
    mc:Ignorable="d">
    <StackPanel Margin="8">
        <TextBlock Text="Please enter some text in the RichEditBox below, then press the SetText() button."/>
        <RichEditBox x:Name="_richEditBox"/>
        <Button Content="SetText()" Click="ButtonSetText_OnClick"/>
        <TextBlock x:Name="_textBlockInfo"/>
    </StackPanel>
</Window>

MainWindow.xaml.cs:
using Microsoft.UI.Text;
using Microsoft.UI.Xaml;

namespace RichEditBox_Test
{
    public sealed partial class MainWindow : Window
    {
        public MainWindow()
        {
            this.InitializeComponent();
        }

        private void ButtonSetText_OnClick(object sender, RoutedEventArgs e)
        {
            this._richEditBox.TextChanged -= this.RichEditBox_OnTextChanged;
            this._textBlockInfo.Text = "";

            this._richEditBox.Document.SetText(TextSetOptions.None, "This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times. This is just some random text, that is spelled correctly and will now repeat 100 times.\r\nBut this word here is not spelled correctly: qw\r\n");

            this._richEditBox.TextChanged += this.RichEditBox_OnTextChanged;

            // Please note, that we subscribed to the TextChanged event after changing the text.
        }

        private void RichEditBox_OnTextChanged(object sender, RoutedEventArgs e)
        {
            this._textBlockInfo.Text = "TextChanged event raised!";
        }
    }
}

The issue is only reproducible, when the user has written some text in the RichEditBox before. I assume, that spellcheck does not kick in, when the user has never written any text in the RichEditBox before.
So, please enter some text in the RichEditBox and then press the SetText() button. This will replace the text in the RichEditBox  with some very long text with a misspelt word at the end and then subscribe an event-handler to the TextChanged event. The purpose for the wall of text before the misspelt word is to create some delay, so that the issue is easier to see.
You will see, that the TextChanged event will be raised as soon as the spellcheck detects and underlines the misspelt word "qw".
Expected behavior
When spellcheck detects a misspelt word, it should not raise a TextChanged event, because the text did not actually change.
Screenshots
Edit: https://youtu.be/cTotf9H2LXw
NuGet package version
WinUI 3 - Windows App SDK 1.5.6: 1.5.240802000
Windows version
Windows 10 (21H2): Build 19044
Additional context
No response

@JuliusZet This seems to be the current behavior. One way to work around this might be look at the TextChanging event whose args contain IsContentChanging to notify if the content is actually changing.

I believe this is by design.  The WPF counterpart to this explicitly says that it's raised when any formatting changes, which would include the spellcheck underline:
https://learn.microsoft.com/en-us/dotnet/api/system.windows.controls.primitives.textboxbase.textchanged?view=windowsdesktop-8.0#system-windows-controls-primitives-textboxbase-textchanged
@ranjeshj 's suggested workaround is how I believe you are meant to detect change to the text itself.


Implement additional scenarios in the integration suite

We need to decide which scenarios we want to implement, and limit the scope of this issue.

This will not be implemented in the scope of the Priviledge project.


WAVLM_BASE pipeline shows different hidden states when compared to the HuggingFace model.

🐛 Describe the bug
When comparing the WAVLM_BASE model from the Torchaudio pipeline with the one HuggingFace provides (here : https://huggingface.co/microsoft/wavlm-base), it appears that the returned hidden states show different outputs EXCEPT for the first layer.
I provided a Colab example below :
https://colab.research.google.com/drive/1gEapCvAXCTCtauUjF_DvxW5nkiznbdsH?usp=sharing
What I find weird is that both models return the same first hidden states, even though other layers are different...
I tested the HuBERT pipeline with the HuggingFace one and layers were identical, so it seems to be the case for some models only (such as WavLM).
I tried tweaking the configuration files of both models in order to achieve the same outputs for both models but without any success. Some parameters might differ between architectures even though after analyzing them, I did not a see major difference...
Versions
PyTorch version: 2.0.1+cu118
Is debug build: False
CUDA used to build PyTorch: 11.8
ROCM used to build PyTorch: N/A
OS: Ubuntu 20.04.5 LTS (x86_64)
GCC version: (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0
Clang version: 10.0.0-4ubuntu1
CMake version: version 3.25.2
Libc version: glibc-2.31
Python version: 3.10.11 (main, Apr  5 2023, 14:15:10) [GCC 9.4.0] (64-bit runtime)
Python platform: Linux-5.15.107+-x86_64-with-glibc2.31
Is CUDA available: False
CUDA runtime version: 11.8.89
CUDA_MODULE_LOADING set to: N/A
GPU models and configuration: Could not collect
Nvidia driver version: Could not collect
cuDNN version: Probably one of the following:
/usr/lib/x86_64-linux-gnu/libcudnn.so.8.7.0
/usr/lib/x86_64-linux-gnu/libcudnn_adv_infer.so.8.7.0
/usr/lib/x86_64-linux-gnu/libcudnn_adv_train.so.8.7.0
/usr/lib/x86_64-linux-gnu/libcudnn_cnn_infer.so.8.7.0
/usr/lib/x86_64-linux-gnu/libcudnn_cnn_train.so.8.7.0
/usr/lib/x86_64-linux-gnu/libcudnn_ops_infer.so.8.7.0
/usr/lib/x86_64-linux-gnu/libcudnn_ops_train.so.8.7.0
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True
CPU:
Architecture:                    x86_64
CPU op-mode(s):                  32-bit, 64-bit
Byte Order:                      Little Endian
Address sizes:                   46 bits physical, 48 bits virtual
CPU(s):                          2
On-line CPU(s) list:             0,1
Thread(s) per core:              2
Core(s) per socket:              1
Socket(s):                       1
NUMA node(s):                    1
Vendor ID:                       GenuineIntel
CPU family:                      6
Model:                           79
Model name:                      Intel(R) Xeon(R) CPU @ 2.20GHz
Stepping:                        0
CPU MHz:                         2200.216
BogoMIPS:                        4400.43
Hypervisor vendor:               KVM
Virtualization type:             full
L1d cache:                       32 KiB
L1i cache:                       32 KiB
L2 cache:                        256 KiB
L3 cache:                        55 MiB
NUMA node0 CPU(s):               0,1
Vulnerability Itlb multihit:     Not affected
Vulnerability L1tf:              Mitigation; PTE Inversion
Vulnerability Mds:               Vulnerable; SMT Host state unknown
Vulnerability Meltdown:          Vulnerable
Vulnerability Mmio stale data:   Vulnerable
Vulnerability Retbleed:          Vulnerable
Vulnerability Spec store bypass: Vulnerable
Vulnerability Spectre v1:        Vulnerable: __user pointer sanitization and usercopy barriers only; no swapgs barriers
Vulnerability Spectre v2:        Vulnerable, IBPB: disabled, STIBP: disabled, PBRSB-eIBRS: Not affected
Vulnerability Srbds:             Not affected
Vulnerability Tsx async abort:   Vulnerable
Flags:                           fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology nonstop_tsc cpuid tsc_known_freq pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 x2apic movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single ssbd ibrs ibpb stibp fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm rdseed adx smap xsaveopt arat md_clear arch_capabilities
Versions of relevant libraries:
[pip3] numpy==1.22.4
[pip3] torch==2.0.1+cu118
[pip3] torchaudio==2.0.2+cu118
[pip3] torchdata==0.6.1
[pip3] torchsummary==1.5.1
[pip3] torchtext==0.15.2
[pip3] torchvision==0.15.2+cu118
[pip3] triton==2.0.0
[conda] Could not collect

Hi @SevKod, thanks for reporting the issue. The reason is in get_intermediate_outputs method of Transformer model, positional_bias is ignored, however it should be used as input to the next transformer layer.
https://github.com/pytorch/audio/blob/0db5ab2558232c6b29f4e98e0e9d007b49d28960/torchaudio/models/wav2vec2/components.py#L463
To get identical output as HuggingFace, you can try this script:
#Load the torchaudio model and apply feature extraction
bundle = torchaudio.pipelines.WAVLM_BASE
model_torch = bundle.get_model().to(device)
features = []
x, _ = model_torch.feature_extractor(waveforms, None)
x, masks = model_torch.encoder._preprocess(x, None)
position_bias = None
x = model_torch.encoder.transformer._preprocess(x)
for layer in model_torch.encoder.transformer.layers:
    x, position_bias = layer(x, masks, position_bias=position_bias)  # Ignore position_bias
    features.append(x)

I will make a quick fix today. Thanks for looking into it.

Thanks a lot @nateanl for answering so quickly and for the fix !
I might have found another issue this time regarding the WavLM-LARGE model (still about feature extraction). Don't know if I have to re-open another issue though, but here it is :
When extracting features, the WavLM_Large feature extraction method returns the same weights on each tensor columns (past the the 5th layer). Here is an example :
https://colab.research.google.com/drive/1I_zvmY3DomzQyGxe402BOAAZ5CnN4ToQ?usp=sharing
As seen from the example above, computed weights appear to be the same on each column from the output tensor (can be mainly seen when printing the 5th layer and below...). This does not appear to be normal... (Or maybe there is a different way of using this model ?).
In any case, thank you in advance for your help !

What happens with https://github.com/pytorch/audio/pull/3350 applied? i.e. if we try nightly build?

What happens with #3350 applied? i.e. if we try nightly build?

Just tested it and it still appears to be the case :
https://colab.research.google.com/drive/1H_HLBUcyQS7u4lHMWXOwYIYN81rS5tIm#scrollTo=_c68RCbaBcAX

The difference between WavLM hidden states in TorchAudio and HF Transformers seems to come from the model configuration. To reproduce HF result one needs to set encoder_layer_norm_first = True when creating WavLM model in TorchAudio (this parameter are False by default)
Indeed, in WavLMEncoderStableLayerNorm, used by HF by default, the norm is applied at the beginning at the layer, and in TorchAudio this depends on EncoderLayer.layer_norm_first
In this notebook (slightly modified version of @SevKod's) I patched bundle config of WAVLM_LARGE with  encoder_layer_norm_first = True, and the hidden states produced by TorchAudio matched that of HF - except for the first and the last layer. This remained difference is due to how "hidden state" is defined: in TorchAudio the value is saved after a layer , and in HF it is saved before a layer
Note that WAVLM_BASE and WAVLM_BASE_PLUS additionally set _normalize_waveform to False by default, which would also create a difference with the HF output (if preprocessing waveform with transformers.Wav2Vec2FeatureExtractor)
@nateanl @mthrok, perhaps we could modify the default config for WavLM bundles? It seems that features generated with encoder_layer_norm_first = True make more sense, since they don't have repeated rows described above

Addressed via #3660


Support for .addData and .removeData?

I'm trying to use this library to re-use a graph that can switch from 7 items to 30 items. It seems that whenever the number of items changes I get Uncaught TypeError: Cannot set property 'value' of undefined This happens every time the number of values to be charted changes.
If I have the redraw option enabled then these errors do not occur. With the redraw I would need to set animation: false otherwise I get some flickering in the chart.
Is this expected, or, am I probably implementing the graphs in the wrong way?
Thanks! this project is awesome

can you make a unit test or a jsbin or something - I'm not actively using react-chartjs at the moment because I got caught up in another project but I'll have a look

ah, in trying to figure out how to recreate the issue with jsfiddle/bin I found what the problem was, and it was my code. I had a chartData object with {datasets: {key1: {...}, key2: {...}} instead of {datasets: [{...},{...}]
Which works fine except for when updatePoints() was called.
Thank you for your time!


[globo] Fix error on some globo videos #4346

I've fixed an error (#4346) on some globo videos. The problem was that some videos have a m3u playlist listed on the format's list. I'm new to python and youtube-dl, so I don't know if my fix is the best possible.

Thanks, merged.


change dtype of output after passing through lora_A

System Info
peft 0.6.2
Who can help?
No response
Information

[ ] The official example scripts
[ ] My own modified scripts

Tasks

[ ] An officially supported task in the examples folder
[ ] My own task or dataset (give details below)

Reproduction
I am not sure if this is really a bug but my question is that after passing the input x through lora_A, should we cast it to the lora_B.weight.dtype like we do it for lora_A.weight.dtype in the first place?
I am talking about this line: https://github.com/huggingface/peft/blob/32357c2dd2bab768da554d0b1b7dc15825689eb2/src/peft/tuners/lora/bnb.py#L290
instead of output = lora_B(lora_A(dropout(x))) I was thinking if the following should be done output = lora_B(lora_A(dropout(x)).to(lora_B.weight.dtype)) because otherwise for instance in mixed precision training x becomes fp32 but then after passing through lora_A, it becomes bf16 as the input to lora_B. So I was thinking whether we should cast it back to fp32.
Thanks very much for your help in advance!
Expected behavior
na

I face the same thing, what ever the model dtype is it change to fb32. if you change the dtype of the model after you create it would only change the dtype of the LoRA parameter, not the base model.
`model_id = "BAAI/bge-small-en-v1.5"
tokenizer = AutoTokenizer.from_pretrained(model_id)
model = AutoModel.from_pretrained(model_id,torch_dtype=torch.bfloat16)
def create_peft_config(model):
from peft import (
get_peft_model,
LoraConfig,
TaskType,
prepare_model_for_kbit_training,
)
peft_config = LoraConfig(
    task_type=TaskType.FEATURE_EXTRACTION,
    inference_mode=False,
    r=128,
    lora_alpha=12,
    lora_dropout=0.03,
    target_modules = ["query", "value"]
)
model = prepare_model_for_kbit_training(model)
model = get_peft_model(model, peft_config)
model.print_trainable_parameters()
return model, peft_config

create peft config
model, lora_config = create_peft_config(model)
print(model.dtype) # the output is torch.float32
if we change the dtype of the model like this model.dtype = torch.bfloat16`
the base model still has dtype float32

There is a fix #1010

Thanks @baoleai for pointing this out! Unfortunately it does not resolve my issue because I still see that result += lora_B(lora_A(dropout(x))) * scaling and after passing x through lora_A, it becomes bf16 as the input to lora_B. On the other hand, I'd like to make sure that the output of lora_A to be cast to the lora_B.weight.dtype.

@huseyinatahaninan For us to reproduce, do you have a small code snippet that shows this issue cropping up?

Thanks @BenjaminBossan, actually I am not 100% sure if this is an issue really. Maybe it's just the way it's supposed to be. Consider this minimal example:
import torch
from peft import get_peft_model, LoraConfig
from transformers import AutoModel

if __name__ == "__main__":
    model = AutoModel.from_pretrained("distilgpt2")
    lora_cfg = LoraConfig(r=8, lora_alpha=16, lora_dropout=0.05, bias="lora_only", task_type="lm")
    model = get_peft_model(model, lora_cfg)
    model = model.cuda()

    # prepare dummy inputs
    input_ids, labels = torch.randint(0, 1000, (2, 4)).cuda(), torch.randint(0, 1000, (4,)).cuda()

    # forward pass
    with torch.autocast(enabled=True, dtype=torch.bfloat16, device_type="cuda"):
        outputs = model(input_ids)
        loss, logits = outputs[:2]

If you add a breakpoint to https://github.com/huggingface/peft/blob/67a08009ff1f0b4282003c0aba174d0be292c10e/src/peft/tuners/lora/layer.py#L373 you'll see that lora_A(dropout(x)) gives dtype=torch.bfloat16 and that's the input to lora_B. I was wondering if we should also modify the dtype after passing through lora_A similar to what happens a line before x = x.to(lora_A.weight.dtype).
Essentially something like the following:
y = lora_A(dropout(x))
y = y.to(lora_B.weight.dtype)
result += lora_B(y) * scaling

The reason that I am asking this has to do with differentially private training and I can explain why I'd like to give input to lora_B as torch.bfloat32 instead of torch.bfloat16 if you'd like but that's a bit out of scope :) I have different ways to handle this so it's all good but just wanted to quickly double check with you if this behavior is intended because I do see that x.dtype is modified for lora_A layer so it makes me question why it's not modified for lora_B layer.

Thanks for explaining @huseyinatahaninan. I think that if we're inside an autocast context, it is not totally unexpected that the input dtype would be the one indicated in the context. Although I agree that this could be considered inconsistent when comparing lora_A and lora_B, I'm not sure if your use case is common enough to justify making the suggested change.

I have different ways to handle this so it's all good

Please let us know if that no longer works with PEFT, otherwise I'd say let's keep it as is.

differentially private training

Nice, happy to see more work being done on this with LoRA.

That sounds great, thanks very much @BenjaminBossan, appreciate the discussion and this awesome repo :)


Reseting a ng-src value

When setting a ng-src to '' to clean its value does not work in Chrome. It does work in Firefox. Here is the jsfiddle:
http://jsfiddle.net/escalant3/3B5ej/

w3c: A URL that is not the empty string, optionally with leading and/or trailing space characters.

I've just encountered the same issue. And if I figured this right, the specs define that the src attribute on the img tag is optional. Hence, when ng-src evaluates to null or any other invalid path (empty for instance) I think the src attribute shouldn't be removed from the img tag completely.


Hash of conditions has unexpected results

I want to use a hash condition to narrow WHICH companies the user can update.
puts (can? :update, Company)         # => false
puts (can? :update, user.company)  # => false

can :update, Company, id: user.company_id

puts (can? :update, Company)         # => true
puts (can? :update, user.company)  # => true

Why are both items returning true? I included the hash condition because I don't want the user to be able to update any company.

This is by design. It is explained here: https://github.com/CanCanCommunity/cancancan/wiki/Checking-Abilities#checking-with-class
To check whether your user can update any company, you could use can? :update, Company.new instead.

@alexsanford Thank you very much - I have a follow-up on this.


Publish main to live on 8/30 @ 10:30 am

Docs Build status updates of commit 3a64a19:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/New-DlpComplianceRule.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Set-DlpComplianceRule.md
:white_check_mark:Succeeded
View (exchange-ps)

teams/teams-ps/teams/Get-CsTeamsShiftsConnectionTeamMap.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/New-CsTeamsShiftsConnectionTeamMap.md
:white_check_mark:Succeeded
View (teams-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Add support for ag grid 27.3.0 blank/notblank filter options

Add support for blank/notBlank filter options present in ag-grid v27.3.0
Merges behaviour with existing not/notnull options

Hi,
Thanks for the PR. I wasn't aware of blank/not blank filter options.
I didn't have a chance to test it yet, but I wonder if it shouldn't also check for empty/whitespace strings.
https://github.com/ag-grid/ag-grid/blob/0bc513e1df5d2c6a5441f631f29b44746712c1e0/community-modules/core/src/ts/filter/provided/text/textFilter.ts#L237
https://github.com/ag-grid/ag-grid/blob/0bc513e1df5d2c6a5441f631f29b44746712c1e0/community-modules/core/src/ts/filter/provided/simpleFilter.ts#L630

To do that reliably you'd need to inspect the underlying type for the given property name in GetPredicate, since the blank filters can be applied to more than just strings.
I can take a look into this when I get some time - we have a hack in our project for now, replacing blank/notblank for the existing null/notnull filter types in a custom modelbinder.


[MMP] Add filter/view for automod messages

Setting to filter AM messages from priority view and also a view that only shows AM messages.  Based on sender name, not title.

Part of new modmail


Make layout prettier in extended-resource-node.md

Removed redundant blank lines
Provide indentation with two space in curl
Format YAML section

Thanks.
/lgtm
/approve


Should give a "thing" more meaning

Maybe just a string that says something like "things could be events, speakers, sponsors and more"

Ah, especially now that I typed 'devopsdays-cli add' and was surprised to not see event

For my clarity, first you create a thing and then you add the thing to another thing?

Fixed in 6c4fc1054d9c53c3d4020257bf48aea21e2df2b0


[NeuralynxRawIO] Clean time parsing

At long last, replaced the complicated header dictionaries with more general patterns and checks. There are a few more tweaks on this that will be nice but this is a good chunk. As before, depends on the prior chain with NeuraviewTestAndRefactor.

Sadly the delay in review has now caused there to be conflicts between my others use of the latest master python-neo and these changes. I guess no conflicts with python-neo per se yet.

I should also mention that the change to the BaseRawIO._signal_channel_dtype broke a lot of derived classes that I have. I know that is not part of the public interface but thought I should mention it.

Hey Peter yeah, sorry the buffer io was something we had planned for quite a spell and needed to get done. Sam was putting all of his effort into that lately. We have one last big buffer based set of changes, but reviewing these PRs is on Sam's todo list. (I remind him to do it :) )

I guess I don't understand the need for buffer_id, even having read the enhancement proposal, but I assume it is important at some level.
I ended up merging the changes in this PR into my master branch forked from the main master. There weren't many conflicts so hopefully that should not be a problem in the future when these changes here are merged into the main master.


[Bug] Fixes always passing 'wait' to tiller

What is the purpose of this pull request?:
What issue does this pull request address?: Fixes #
Notes for reviewers to consider:
Specific reviewers for pull request:
@gardlt @drewwalters96 @alanmeadows

LGTM.


Missing configuration files of EDAC. The $num_epochs$ of SAC-N is set not the same as original paper of EDAC.

No EDAC folder in $./configs/$
$num\_epochs$ is set as 250 in config files of SAC-N. But, in the original paper, SAC-N is trained over 3000 epoches. I would like to know if the results listed in the table were run for 250 epoches or 3000 epoches?

Hi,

This pull request should solve the issue
It was trained for 3000 epoches as in the original paper

Thanks for pointing this out


xEndorse: GitHub Readme!

endorsement here!

thanks! just put a like here dont need to make a new issue https://github.com/sw-yx/sw-yx/issues/12


solve relay store not deleting removed nodes

Stale nodes that are no longer displayed a first removed after the query component (that ONCE referenced them) unmounts. Ideally, we want those removed after they are no longer referenced in the query.
This is an performance issue for long-running applications.

https://github.com/facebook/relay/issues/3165

See https://github.com/n1ru4l/graphql-live-queries/blob/eb6297ae677c5ee186d15d130a014a3340d9e703/packages/example/client/src/createRelayEnvironment.tsx#L13-L34

This is now solved. The scheduleGC method is now part of the public API.


GPMDP: Error during query: (sqlite3.OperationalError) database is locked

Home Assistant release (hass --version):
0.29.0.dev0
Python release (python3 --version):
Python 3.4.2
Component/platform:
media_player/gpmdp
Description of problem:
The following error message appears in my console after a few hours of operation. I haven't observed any adverse impact yet to the functionality of the platform module, but each time the parameter return seems to contain a reference to my GPMDP entity ('media_player.living_room_music')
Expected:
No errors in console.
Log output:
16-09-20 20:56:36 homeassistant.components.recorder: Error during query: (sqlite3.OperationalError) database is locked

[SQL: 'SELECT states.state_id AS states_state_id, states.domain AS states_domain, states.entity_id AS states_entity_id, states.state AS states_state, states.attributes AS states_attributes, states.event_id AS states_event_id, states.last_changed AS states_last_changed, states.last_updated AS states_last_updated, states.created AS states_created \nFROM states \nWHERE (states.domain IN (?) OR states.last_changed = states.last_updated) AND states.domain NOT IN (?, ?) AND states.last_updated > ? AND states.last_updated < ? AND states.entity_id = ? ORDER BY states.entity_id, states.last_updated']

[parameters: ('thermostat', 'zone', 'scene', '2016-09-20 03:56:31.666910', '2016-09-21 03:56:31.666910', 'media_player.living_room_music')]

Additional:
I have tried totally wiping my database file and having HaSS recreate fresh one. The problem resurfaces in time. Verified the permission and ownership of the DB file.

I stopped receiving this error prior to 0.29dev. I think it was unrelated to the GPMDP module.


On orchest update also update third-parties we ship (such as Argo Workflows)

Describe the problem this improvement solves
Changes to the value files of a thirdparty, e.g. orchest-values.yaml of argo-workflows, are not picked up on orchest update. However, we of course want these changes to be picked up as well given that they interact with the Orchest application (and thus the deployments of the thirdparties needs to match the version of Orchest that is running).
(This issue was mentioned in https://github.com/orchest/orchest/pull/1048#issuecomment-1176079684 first).
Describe the solution you'd like
To make sure the orchest-controller also updates third-parties we can add the orchest-values.yaml of the third-parties to the respective CR Object (as Managed Fields). This way on orchest update the orchest-controller can change (or add) values in the CR Object to make sure the third-parties are updated as well.
By making them Managed Fields we also communicate to the user that they shouldn't be updating the values manually, but doesn't strictly prohibit them from doing so.

In #1126 it is implemented a little bit differently than this issue. The CR object is not updated by the default values in orchest-values.yaml files, once the user overwrites the default values or even the controller updated with different default values or new helm templates, the controller checks the deployed manifests of the third-party addon with the new manifests if the manifests are different, the controller deploys the new manifests.


VS2019 Blazor templates not available

Describe the bug
Following the instructions from here: https://docs.microsoft.com/en-us/aspnet/core/client-side/spa/blazor/get-started?view=aspnetcore-3.0&tabs=visual-studio using Windows 10 Pro (Version 10.0.17763.316) and VS2019 (Version 16.0.0 Preview 3.0) on 64-bit. From a VS2019 Developer Command Prompt, I run:
dotnet new -i Microsoft.AspNetCore.Blazor.Templates

then, start a fresh instance of VS2019 and choose New ASP.NET Core Web Application, I see several templates, but nothing for Blazor.
To Reproduce
Steps to reproduce the behavior:

Using this version of ASP.NET Core 3.0.100-preview-010184, Windows 10 Pro 10.0.17763.316 and VS2019 Preview (Version 16.0.0 Preview 3.0)
From the VS2019 Developer Command Prompt, run this code dotnet new -i Microsoft.AspNetCore.Blazor.Templates
Launch VS2019, choose Create New Project -> ASP.NET Core Web Application -> click Create -> Choose "ASP.NET Core 3.0" and ".NET Core" from dropdowns at the top.
Do not see any Blazor templates available.

Expected behavior
Expected to see a Blazor template available.
Additional context
Uutput of dotnet --info:
.NET Core SDK (reflecting any global.json):
 Version:   3.0.100-preview-010184
 Commit:    c57bde4593

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.17763
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   C:\Program Files\dotnet\sdk\3.0.100-preview-010184\

Host (useful for support):
  Version: 3.0.0-preview-27324-5
  Commit:  63a01b08e5

.NET Core SDKs installed:
  2.1.202 [C:\Program Files\dotnet\sdk]
  2.1.500 [C:\Program Files\dotnet\sdk]
  2.1.502 [C:\Program Files\dotnet\sdk]
  2.1.504 [C:\Program Files\dotnet\sdk]
  2.1.600-preview-009426 [C:\Program Files\dotnet\sdk]
  2.1.600-preview-009497 [C:\Program Files\dotnet\sdk]
  3.0.100-preview-010184 [C:\Program Files\dotnet\sdk]

.NET Core runtimes installed:
  Microsoft.AspNetCore.All 2.1.6 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.1.7 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.1.8 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.App 2.1.6 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.1.7 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.1.8 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 3.0.0-preview-19075-0444 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 2.0.9 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.6 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.7 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.8 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 3.0.0-preview-27324-5 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.WindowsDesktop.App 3.0.0-preview-27325-3 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

To install additional .NET Core runtimes or SDKs:
  https://aka.ms/dotnet-download

This command
dotnet new -i Microsoft.AspNetCore.Blazor.Templates

is required if you want to use Blazor templates from command line.
To see Blazor templates in VS you have to install Blazor Language Services. This is step number 1 in the doc: https://docs.microsoft.com/en-us/aspnet/core/client-side/spa/blazor/get-started?view=aspnetcore-3.0&tabs=visual-studio

@Andrzej-W Thanks! I didn't catch that. I agree, after installing the extension the VS2019 side works as described.
Also though, that command:
dotnet new -i Microsoft.AspNetCore.Blazor.Templates

That seems to do something, but also returns the "usage" help screen as if an incorrect variable was passed. FYI
  Restoring packages for C:\Users\RobSe\.templateengine\dotnetcli\v3.0.100-preview-010184\scratch\restore.csproj...
  Installing Microsoft.AspNetCore.Blazor.Templates 0.7.0.
  Generating MSBuild file C:\Users\RobSe\.templateengine\dotnetcli\v3.0.100-preview-010184\scratch\obj\restore.csproj.nuget.g.props.
  Generating MSBuild file C:\Users\RobSe\.templateengine\dotnetcli\v3.0.100-preview-010184\scratch\obj\restore.csproj.nuget.g.targets.
  Restore completed in 3.32 sec for C:\Users\RobSe\.templateengine\dotnetcli\v3.0.100-preview-010184\scratch\restore.csproj.

Usage: new [options]

Options:
  -h, --help          Displays help for this command.
  -l, --list          Lists templates containing the specified name. If no name is specified, lists all templates.
  -n, --name          The name for the output being created. If no name is specified, the name of the current directory is used.
  -o, --output        Location to place the generated output.
  -i, --install       Installs a source or a template pack.
  -u, --uninstall     Uninstalls a source or a template pack.
  --nuget-source      Specifies a NuGet source to use during install.
  --type              Filters templates based on available types. Predefined values are "project", "item" or "other".
  --dry-run           Displays a summary of what would happen if the given command line were run if it would result in a template creation.
  --force             Forces content to be generated even if it would change existing files.
  -lang, --language   Filters templates based on language and specifies the language of the template to create.

Templates                                         Short Name            Language          Tags
-------------------------------------------------------------------------------------------------------------------------------
Console Application                               console               [C#], F#, VB      Common/Console
Class library                                     classlib              [C#], F#, VB      Common/Library
WPF Application                                   wpf                   [C#]              Common/WPF
Windows Forms Application                         winforms              [C#]              Common/WinForms
Unit Test Project                                 mstest                [C#], F#, VB      Test/MSTest
NUnit 3 Test Project                              nunit                 [C#], F#, VB      Test/NUnit
NUnit 3 Test Item                                 nunit-test            [C#], F#, VB      Test/NUnit
xUnit Test Project                                xunit                 [C#], F#, VB      Test/xUnit
Razor Page                                        page                  [C#]              Web/ASP.NET
MVC ViewImports                                   viewimports           [C#]              Web/ASP.NET
MVC ViewStart                                     viewstart             [C#]              Web/ASP.NET
Blazor (hosted in ASP.NET server)                 blazorhosted          [C#]              Web/Blazor/Hosted
Blazor Library                                    blazorlib             [C#]              Web/Blazor/Library
Blazor (Server-side in ASP.NET Core)              blazorserverside      [C#]              Web/Blazor/ServerSide
Blazor (standalone)                               blazor                [C#]              Web/Blazor/Standalone
ASP.NET Core Empty                                web                   [C#], F#          Web/Empty
ASP.NET Core Web App (Model-View-Controller)      mvc                   [C#], F#          Web/MVC
ASP.NET Core Web App                              webapp                [C#]              Web/MVC/Razor Pages
ASP.NET Core with Angular                         angular               [C#]              Web/MVC/SPA
ASP.NET Core with React.js                        react                 [C#]              Web/MVC/SPA
ASP.NET Core with React.js and Redux              reactredux            [C#]              Web/MVC/SPA
Razor Class Library                               razorclasslib         [C#]              Web/Razor/Library/Razor Class Library
ASP.NET Core Web App (Razor Components)           razorcomponents       [C#]              Web/RazorComponents
ASP.NET Core Web API                              webapi                [C#], F#          Web/WebAPI
global.json file                                  globaljson                              Config
NuGet Config                                      nugetconfig                             Config
Dotnet local tool manifest file                   tool-manifest                           Config
Web Config                                        webconfig                               Config
Solution File                                     sln                                     Solution

Examples:
    dotnet new mvc --auth Individual
    dotnet new web
    dotnet new --help

After creating Blazor project. When i tried to run. Blank page is opened and immediately closed. In the output window i see following errors.
'dotnet.exe' (CoreCLR: clrhost): Loaded 'C:\Program Files\dotnet\shared\Microsoft.NETCore.App\3.0.0-preview-27324-5\System.Threading.Timer.dll'.
Exception thrown: 'System.IO.FileNotFoundException' in System.Private.CoreLib.dll
Exception thrown: 'System.IO.FileNotFoundException' in System.Private.CoreLib.dll
Exception thrown: 'System.IO.FileNotFoundException' in System.Private.CoreLib.dll
'dotnet.exe' (CoreCLR: clrhost): Loaded 'C:\Program Files\dotnet\shared\Microsoft.NETCore.App\3.0.0-preview-27324-5\System.Threading.Overlapped.dll'.
'dotnet.exe' (CoreCLR: clrhost): Loaded 'C:\Program Files\dotnet\shared\Microsoft.NETCore.App\3.0.0-preview-27324-5\System.Runtime.Serialization.Xml.dll'.
Exception thrown: 'System.IO.FileNotFoundException' in System.Private.CoreLib.dll
Exception thrown: 'System.IO.FileNotFoundException' in System.Private.CoreLib.dll
'dotnet.exe' (CoreCLR: clrhost): Loaded 'C:\Program Files\dotnet\shared\Microsoft.NETCore.App\3.0.0-preview-27324-5\System.Reflection.Emit.ILGeneration.dll'.
'dotnet.exe' (CoreCLR: clrhost): Loaded 'C:\Program Files\dotnet\shared\Microsoft.NETCore.App\3.0.0-preview-27324-5\System.Reflection.Emit.Lightweight.dll'.
'dotnet.exe' (CoreCLR: clrhost): Loaded 'C:\Program Files\dotnet\shared\Microsoft.NETCore.App\3.0.0-preview-27324-5\System.Reflection.Primitives.dll'.
'dotnet.exe' (CoreCLR: clrhost): Loaded 'C:\Program Files\dotnet\shared\Microsoft.NETCore.App\3.0.0-preview-27324-5\System.IO.FileSystem.Primitives.dll'.
'dotnet.exe' (CoreCLR: clrhost): Loaded 'C:\Program Files\dotnet\shared\Microsoft.NETCore.App\3.0.0-preview-27324-5\System.Dynamic.Runtime.dll'.
'dotnet.exe' (CoreCLR: clrhost): Loaded 'C:\Program Files\dotnet\shared\Microsoft.NETCore.App\3.0.0-preview-27324-5\System.Threading.ThreadPool.dll'.
Exception thrown: 'Microsoft.DotNet.Cli.Utils.GracefulException' in dotnet.dll
The program '[11056] dotnet.exe' has exited with code 1 (0x1).

@RobSeder after running the initial command, you can then run dotnet new blazorserverside
The project opens just fine in VS2019. Is this not the behavior you want?

@carlosrfernandez As noted above, it also produces a "usage" screen which makes it look like something was entered incorrectly.

Thanks for your help, @Andrzej-W