Running dealbot on other networks

For the testing of the OhSnap FIP on the butterfly network a request was made to deploy an instance of dealbot for the butterfly network to automation deal making for robust testing of the network upgrade. This contains the general issues faced during the deployment / use of dealbot.
I was able to some what successfully make the deployment (controller) by referencing the nerpanet deployment, but ran into issues when trying to start a dealbot daemon.

When trying to create a dealbot daemon, the form values for the docker repo and image label were not submitted with the http request to create the daemon. Maybe related to #357.

Dealbot depends on the docker container produced by the lotus development team which is only produced for mainnet. Supporting dealbot for butterfly, or other networks would require building additional docker containers. Building the additional container itself isn't an issue but would be a one off and if not done carefully could introduce tech-debt to the lotus project / community (this is a lotus issue, but here for context).

Dealbot controller uses a helm chart (lotus-bundle) which is hardcoded[0] for mainnet and making any changes to the chart would required additional development in dealbot to support the changes, which could affect the running dealbot mainnet service.

[0] https://github.com/filecoin-project/helm-charts/blob/dealbot-0.0.12/charts/lotus-bundle/templates/statefulset.yaml#L179-L180

Currently, lotus doesn't produce nerpanet or calibrationnet docker images, so we would have to build them manually
This PR could be useful for making code usable on multiple networks.
This PR might help with this https://github.com/filecoin-project/lotus/pull/8158
regardless, Travis is right that we have mainnet snapshot imports, and that'd need to be changed regardless.


Can I use a new activation function?

Hi,
I would like to try ELU activation function on my task. Can I add
elif act == "elu":
return tf.nn.elu
on get_activation function in modeling.py and modify "hidden_act": "gelu" to "elu" in bert_config.json?
After modifying "hidden_act", can I pre-train a model from your checkpoint? Or should I pre-train a model from scratch?
Thank you very much.

Maybe you need to retrain your model.


Please file releases!

Hi,
could you please file releases here?
And, better, add SDIST archives at Pypi?
Thanks a lot!
\B.

Very happy to do more here.  Can you spell out in a bit more detail want you what you would like to see happen? I am new to releasing python libraries.
So far, twine was used to release versions here following some tutorial:
https://pypi.org/project/google-nest-sdm/
Are there additional options needrd when releasing? Or tag them on Github somehow?

Hi, Allen,
Yes, sure.
your library supports an integration in Home Assistant, I would like to use your library in my Gentoo Overlay for Home Assistant, hope you don't mind.

Therefore I would need a release file either at Pypi in SDIST format, or as a tar.gz on github. I cannot use a library in wheel format. Normally, when no SDIST can be found at Pypi, I would take the source from Github. This was not possible in this case, because you do not yet tag releases here.
A release on Github is OK, but a Pypi SDIST tar.gz release would be preferred, because this could use Gentoo's mirror system and updates download stats. Most of the other (~1100) integrations I use for the repo have both. If something goes wrong with one release, I would have the chance to try the other. This happens from time to time. Would avoid holdups if other libraries depend on it.
Please add a tag for 0.1.6. As soon as you add a tag, Github builds a usable source archive. Make sure that release points in Github are on the same commit which was used for the release in Pypi.
If you build an SDIST for Pypi, make sure that all files needed for building are included. A common mistake is a missing requirements.txt or README.md which the is opened by setup.py during compile process.
One or more of the requirements of this library are pinned to a specific version. Hard pinning may work now, but will lead to problems if an other integration updates it's requirements. To avoid future issues it would be good if this library would change its pinning to allow any higher version and just set a minimum version. Especially when you pin very common libraries like aiohttp or requests-oauthlib.

Thanks a lot for your work.
\B.

Ah, and, sorry, forgot:

It makes things easier if the library name at Pypi matches Github repository name.

Thanks, very helpful guidance and context.
I found this tutorial for setting up requirements.txt from a venv: https://developer.akamai.com/blog/2017/06/21/how-building-virtual-python-environment
However it pins versions on everything.   My impression is that requirements.txt is more for the dev environment: is pinning an OK practice in that case?
I'll check in the commands I'm using for release for extra visibiilty.

Fixed with commits:
096adacdd2ab528a5af4771af21afe6a054c1257,
870fd9972b17a6a5c0bd87f16ebd39b3b592e3e5,
444e324bf02b1662a31c173ebe01adc58bf8eb57

Yep. You made it! Thanks. Led to a couple of new Ebuilds:

add google-nest-sdm-0.1.6
update google-nest-sdm-0.1.9
add google-api-core-1.23.0
add google-auth-1.22.0
update google-auth-1.22.1
add grpc-google-iam-v1-0.12.3
add google-cloud-pubsub-2.1.0
add libcst-0.3.13
add proto-plus-1.11.0


Sybil Attacker Report By farmerxx

Related Safe Addresses
0xfe829126d66c600252fec58a7c399803b80684f6
0xf5ac3b58b7401c44e41b29cba29bec2a2b5e1a38
0xf102005c2de92915a299e27b0545a7cda1a2fb49
0xe27f943e46a1076b14932d951d75cab570a6ffc9
0xd731376a2f275e146794aa17bebc615598f62d62
0xd3ff49ac8f1057e6c9a0501c1fef465e6f189856
0xbf80a3f74f46fff82cd47074732e4109b303633c
0xb1ec865651b22799fb6902731b57576b81bd99c4
0xaeff3468f2d4016419bb4fc04652c6b517a8cb03
0xa54f8112426ca0a74fc500654bcc8717b9dc45f5
0x90ab4c351300d6ce2ac1525c6e7d696969af6c01
0x801aa03c0980bbf85dd4ac46f6a600c954d9ec05
0x6fb3675e15897ce28d27dff110a41db0e2171ad7
0x63c18f6392b70d27a50cb6fc7133ca2a4ab0b336
0x55d8cee19bcc3374b612d65be402a861eb309147
0x510c6d81b99346a7d9fd2763fa78e611bca1a3fc
0x4edb110ad280723b83600bed9e2c464470cbfec5
0x3b0bb0d23e3e7733149c0d29f8225bff997ebe3f
0x37bf6ddbceb50d14d23e539c4bff42916bf45256
0x268f37043c085c30589a9e9465cb5fca8119be95
0x13010e967e4ed3e6cd6deb53d9fe2a58f33e9e94
0x0c4b703b48dfe1765c5cccb537d6b9401c8603cc
0x097258ca2e5931e36793ebe9c1fb258c6e325583
0x03123428d49bd6f391362cae7f27a4c990b16af7
Reasoning
All Safe address were executed only one transaction by 0x66A0FF664f8509370C5D718A0f69AC1DC01f5c3D 482 days ago.
All Safe address have only one executed transaction and never use again.
Methodology
Analyse the Safe address with same Safe airdrop amount.
Safe Address
My Safe Address
0x75c5d4B456b697C9CCa3DAAf4c4a2392b3E1Ddbb

Thanks for the report. All of these Safes have been found by a previous report, unfortunately.


Update readme to include more examples

@bterlson  looks like auto-merge is blocked, could you help merge the PR?

/check-enforcer reset

/check-enforcer evaluate

/check-enforcer override


fix code snippet for old diagnostics

Description
This PR solves a small bug when calculating the code snippets of some diagnostics.

Checklist

[ ] I have linked to any relevant issues.
[x] I have commented my code, particularly in hard-to-understand areas.
[ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book).

[ ] If my change requires substantial documentation changes, I have requested support from the DevRel team

[x] I have added tests that prove my fix is effective or that my feature works.
[ ] I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
[x] I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
[x] I have requested a review from the relevant team or maintainers.

Just thinking, maybe a few simple tests that do the happy path and also bounds checks might be worth it so we don't introduce unwanted behaviour?

I have changed the algorithm to something easier to understand, more performant, given that we iterate the string only once, and I have also written more tests.


Remove UsePrivilegeSeparation from the Docker sshd_config, see #2876

This removes the UsePrivilegeSeparation line from sshd_config, which is deprecated and causes this warning in the logs for every single ssh connection:
Aug 15 18:28:57 sshd[1200]: rexec line 32: Deprecated option UsePrivilegeSeparation

This should resolve #2876

Codecov Report

Merging #4722 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #4722      +/-   ##
=========================================
- Coverage   20.71%   20.7%   -0.01%
=========================================
  Files         167     167
  Lines       32355   32355
=========================================
- Hits         6702    6699       -3
- Misses      24672   24674       +2
- Partials      981     982       +1

Impacted Files
Coverage Δ

modules/process/manager.go
69.56% <0%> (-4.35%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f24ba27...bf25eb6. Read the comment docs.


Feature request: WSL mode

Version of VSCode: 1.19.3
Version of the extension: current master
OS: Windows 10
Description:
I want to install rust in wsl. I changed
https://github.com/editor-rs/vscode-rust/blob/f78d23430af4a6429f7b686e6c5f7c3895e2052a/src/components/cargo/output_channel_task_manager.ts#L59-L65
to

this.runningTask = new Task(
    this.configuration,
    this.logger.createChildLogger('Task: '),
    'wsl',
    [executable, ...args],
    cwd
);

set working directory to project root (at config)
and changed
https://github.com/editor-rs/vscode-rust/blob/f78d23430af4a6429f7b686e6c5f7c3895e2052a/src/components/cargo/CargoTaskManager.ts#L302-L308
to

const userWorkingDirectory = this._configuration.getCargoCwd();
if (userWorkingDirectory !== undefined && userWorkingDirectory !== workingDirectory) {
    const manifestPath = correctPath(join(workingDirectory, 'Cargo.toml'));
    args = ['--manifest-path', manifestPath].concat(args);
    workingDirectory = userWorkingDirectory;
}
return { args, workingDirectory };

cargo check/build/test works well. But it's too hacky and it should be configurable.
Output of the "Rust logging" channel:
<not relevant>

I would also like to see support for Windows Subsystem for Linux in Windows 10. Here is the filepath that it's installed to when I follow the guidelines in the Rust website.
✗ whereis rustc
rustc: /home/damianrivas/.cargo/bin/rustc
✗ whereis cargo
cargo: /home/damianrivas/.cargo/bin/cargo

If you rely on the command line in any way, it's possible to run processes in WSL like this (as an example):
CMD:
wsl.exe /home/damianrivas/.cargo/bin/cargo $(wslpath 'C:\Users\Damian\rust\hello\hello.rs')

Explanation:

wsl.exe: Recommended method to invoke WSL
wlspath: A built-in interoperability WSL tool to convert between Unix and Windows paths.
C:\Users\Damian\rust\hello\hello.rs: the Windows path where the file we want to run is located.

I hope this helps!


Stop loading blueprints in a staging map.

As of now all blueprints have to be loaded inside of a staging map to avoid them overlapping with whatever's at 0,0. Ideally, we could just load grids at the correct coordinates in the first place.

Well they would be if teleporting grids between maps actually worked.


Added EnumPrism and Codable as sources and dropped autogeneration

Changes

Dropped generation run script from the project;
Added Codable and EnumPrism files inside of the project.

JIRA Ticket
@VerizonAdPlatforms/mobile-sdk-developers: Please review.

@AndriiMoskvin @VladyslavAnokhin Should I remove AutoGeneratable and AutoPrism protocols?

RFR


Please add: Tiling Shell (Gnome Extension)

Please add: Tiling Shell (Gnome Extension)
https://extensions.gnome.org/extension/7065/tiling-shell/
https://github.com/domferr/tilingshell

I want the same thing, so I just asked on his Repo if we can get permission to package it. As soon as he gives us that Permission, we can begin.
Packaging for NixOS is actually very easy, I can show you how it's done if you want. Spread the knowledge so that in the future you can package it yourself :)

I've created a package for my personal use.

He just answered. He said he doesn't want it to be packaged. So I'm afraid I can't help you, sorry :)
But I guess we could use the one from Yash-Garg? It probably should be okay since it's very clear that this package isn't official and noone will open issues at the original Repo :)


Improved region definition with recursive window shrinkage

I implemented a new region definition method.
Currently, regions are defined by the following steps:

Starting from the most significant variant, we add a flanking window (default: 1.5 Mb upstream and downstream) around the index variant to define a region
Remove variants in the region, and repeat the first step until none remains
Merge regions if they overlap.
If --max-region-width (default: 6 Mb) is supplied, any regions that exceed the size will be split into multiple regions, just by consecutively taking 6Mb regions from the beginning.

Here, the fourth step could be problematic because it does not consider association significance -- e.g., the lead variant in a large region might be around 6 Mb; and thus its LD neighbors will be split into separate regions.
In this PR, I replaced the fourth step with the following:
4. If --max-region-width (default: 6 Mb) is supplied, any regions that exceed the size will repeat the first step with a shrunken window size (default: current window size * 0.9) -- and continue the steps 1-4 until none exceeds the maximum size.
I think this implementation is better than 1) the current implementation because this considers association significance when splitting; and better than 2) using a shorter window size because this only splits a region that exceeds the maximum size.
Technically, this is implemented by recursively calling generate_bed function which is more intuitive than having a separate split function.

In the R7 demo phenotypes, there are 41 regions that exceeds the 6 Mb threshold. The proposed method splits them nicely, still maintaining the minimum region length > 1.3 Mb.

yep the PR does what it advertises.
This is an improvement compared to  the previous behavior! Off course there can be high LD variants left outside the regions (as in all regions but making them smaller increases that chance) and the LD based segmentation is really the correct way to go.
Instead of trying to pre-segment whole genome, slightly easier is to compute LD for the index variant and choose region based on that LD.   But this should be good enough for now and these regions can be reviewed and reran as needed.

Thanks Mitja! I 100% agree -- LD-based segmentation is WIP and it'd be great to have it in future releases. I will run this for all the r7 demo phenos and will share the results.


How to fine-tune deepseek v2 models?

Hi,
Can you please give us instructions about fine-tuning deepseekv2 model? Can we  use finetune.py script from DeepSeek-MoE
https://github.com/deepseek-ai/DeepSeek-MoE/blob/main/finetune/finetune.py

No plans...

No plans...

why,we have the needs

We are also very interested to do this. So far our experiments have been unsuccessful. It would be incredible if we could get some clues.

We are also very interested to do this. So far our experiments have been unsuccessful. It would be incredible if we could get some clues.

what is the problem? i have use some repo like  MFTCoder/Firefly to train it successful except for the eval during training; and  loss decrease normal.   These training pipeline will be ok?

We are also very interested to do this. So far our experiments have been unsuccessful. It would be incredible if we could get some clues.
I have record the bugs during  match  deepseek-v2 to  training repos
can we have a wechat  to communicate these cases?  my :  yiyepiaoling0715

We are also very interested to do this. So far our experiments have been unsuccessful. It would be incredible if we could get some clues.

2024-07-26 16:03:47.197 | 07/26/2024 08:03:47-INFO-train_utils batch_shape=torch.Size([1, 4596]),batch_numel=4596 |
-- | -- | --
  |   | 2024-07-26 16:03:47.197 | 07/26/2024 08:03:47-INFO-train_utils [TRAIN][train_task_index=0,task_loss=1.030632] |
  |   | 2024-07-26 16:07:23.645 | 07/26/2024 08:07:23-INFO-train_utils eval_and_save_model in completed_steps= 45 |
  |   | 2024-07-26 16:07:35.024 | Traceback (most recent call last): |
  |   | 2024-07-26 16:07:35.024 | File "/lpai/code/mft-coder-zyy-dev/2c3fd4/mft_peft_hf/src/pefts/mft_accelerate.py", line 573, in  |
  |   | 2024-07-26 16:07:35.025 | main() |
  |   | 2024-07-26 16:07:35.025 | File "/lpai/code/mft-coder-zyy-dev/2c3fd4/mft_peft_hf/src/pefts/mft_accelerate.py", line 569, in main |
  |   | 2024-07-26 16:07:35.026 | accelerate_train(accelerator, model, train_dataloader, valid_dataloader, optimizer, lr_scheduler, num_update_steps_per_epoch, len(train_dataset), args) |
  |   | 2024-07-26 16:07:35.026 | File "/lpai-running/code/mft-coder-zyy-dev/2c3fd4/mft_peft_hf/src/pefts/train_utils.py", line 454, in accelerate_train |
  |   | 2024-07-26 16:07:35.026 | stall_num_iter=eval_and_save_model(model=model,valid_dataloader=valid_dataloader, |
  |   | 2024-07-26 16:07:35.026 | File "/lpai-running/code/mft-coder-zyy-dev/2c3fd4/mft_peft_hf/src/pefts/train_utils.py", line 178, in eval_and_save_model |
  |   | 2024-07-26 16:07:35.026 | outputs = model( |
  |   | 2024-07-26 16:07:35.026 | File "/opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl |
  |   | 2024-07-26 16:07:35.027 | return self._call_impl(*args, **kwargs) |
  |   | 2024-07-26 16:07:35.027 | File "/opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl |
  |   | 2024-07-26 16:07:35.027 | return forward_call(*args, **kwargs) |
  |   | 2024-07-26 16:07:35.027 | File "/opt/conda/lib/python3.10/site-packages/deepspeed/utils/nvtx.py", line 15, in wrapped_fn |
  |   | 2024-07-26 16:07:35.027 | ret_val = func(*args, **kwargs) |
  |   | 2024-07-26 16:07:35.027 | File "/opt/conda/lib/python3.10/site-packages/deepspeed/runtime/engine.py", line 1852, in forward |
  |   | 2024-07-26 16:07:35.027 | loss = self.module(*inputs, **kwargs) |
  |   | 2024-07-26 16:07:35.027 | File "/opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl |
  |   | 2024-07-26 16:07:35.027 | return self._call_impl(*args, **kwargs) |
  |   | 2024-07-26 16:07:35.027 | File "/opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1574, in _call_impl |
  |   | 2024-07-26 16:07:35.027 | hook_result = hook(self, args, result) |
  |   | 2024-07-26 16:07:35.027 | File "/opt/conda/lib/python3.10/site-packages/deepspeed/utils/nvtx.py", line 15, in wrapped_fn |
  |   | 2024-07-26 16:07:35.028 | ret_val = func(*args, **kwargs) |
  |   | 2024-07-26 16:07:35.028 | File "/opt/conda/lib/python3.10/site-packages/deepspeed/runtime/zero/parameter_offload.py", line 232, in _end_of_forward_hook |
  |   | 2024-07-26 16:07:35.028 | self.get_param_coordinator(training=False).reset_step() |
  |   | 2024-07-26 16:07:35.028 | File "/opt/conda/lib/python3.10/site-packages/deepspeed/runtime/zero/partitioned_param_coordinator.py", line 212, in reset_step |
  |   | 2024-07-26 16:07:35.028 | assert_ints_same_as_other_ranks([m.id for m in self.__submodule_order]) |
  |   | 2024-07-26 16:07:35.028 | File "/opt/conda/lib/python3.10/site-packages/deepspeed/utils/nvtx.py", line 15, in wrapped_fn |
  |   | 2024-07-26 16:07:35.028 | ret_val = func(*args, **kwargs) |
  |   | 2024-07-26 16:07:35.028 | File "/opt/conda/lib/python3.10/site-packages/deepspeed/runtime/zero/utils.py", line 88, in assert_ints_same_as_other_ranks |
  |   | 2024-07-26 16:07:35.028 | raise RuntimeError(f"disagreement between rank0 and rank{dist.get_rank()}: " |
  |   | 2024-07-26 16:07:35.028 | RuntimeError: disagreement between rank0 and rank1: rank0: [4401208739789388772,<PHONE_NUMBER>637291626,<PHONE_NUMBER>513248870,<PHONE_NUMBER>033919771,<PHONE_NUMBER>129086120,<PHONE_NUMBER>050526523,<PHONE_NUMBER>162370942,<PHONE_NUMBER>643025700, -4890141335760487581,<PHONE_NUMBER>400720072, ...] rank1: [0, 1, 2, 4, 17, 5, 6, 7, 8, 9, 11, 10, 18, 12, 13, 16, 14, 15, 19, 355, 20, 21, 22, 23, 24, 26, 25, 356, 27, 349, 29, 30, 33, 31, 32, 34, 35, 38, 36, 37, 39, 40, 43, 41, 42, 44, 45, 48, 46, 47, 49, 50, 53, 51, 52, 54, 55, 58, 56, 57, 59, 60, 63, 61, 62, 64, 65, 68, 66, 67, 69, 70, 73, 71, 72, 74, 75, 78, 76, 77, 79, 80, 83, 81, 82, 84, 85, 88, 86, 87, 89, 90, 93, 91, 92, 94, 95, 98, 96, 97, 99, 100, 103, 101, 102, 104, 105, 108, 106, 107, 109, 110, 113, 111, 112, 114, 115, 118, 116, 117, 119, 120, 123, 121, 122, 124, 125, 128, 126, 127, 129, 130, 133, 131, 132, 134, 135, 138, 136, 137, 139, 140, 143, 141, 142, 144, 145, 148, 146, 147, 149, 150, 153, 151, 152, 154, 155, 158, 156, 157, 159, 160, 163, 161, 162, 164, 165, 168, 166, 167, 169, 170, 173, 171, 172, 174, 175, 178, 176, 177, 179, 180, 183, 181, 182, 184, 185, 188, 186, 187, 189, 190, 193, 191, 192, 194, 195, 198, 196, 197, 204, 205, 208, 206, 207, 209, 210, 213, 211, 212, 214, 215, 218, 216, 217, 219, 220, 223, 221, 222, 224, 225, 228, 226, 227, 229, 230, 233, 231, 232, 234, 235, 238, 236, 237, 239, 240, 243, 241, 242, 244, 245, 248, 246, 247, 249, 250, 253, 251, 252, 254, 255, 258, 256, 257, 259, 260, 263, 261, 262, 264, 265, 268, 266, 267, 269, 270, 273, 271, 272, 274, 275, 278, 276, 277, 279, 280, 283, 281, 282, 284, 285, 288, 286, 287, 289, 290, 293, 291, 292, 294, 295, 298, 296, 297, 299,


Revert renaming to camelCase functions used in ERB - doesn't work

Live testing has revealed breakage after ESLint fixes - camelCase named JS functions are not working in ERB files.

Mmm, I am starting to think that we better increase the release cadence.
Camaleon being a pure OSS project, we bare have time to contribute on some weekends or holidays/vacations. So it will take forever to wait, for example for v.3 with all the targets completed. We'll get too far out of sync with our own code changes - I mean we'll simply forget some things :)
In every company that I've worked developers were not fond of big releases taking 3 to 6 months to prepare.


Syntax highlighting Command Output Text

It would be incredibly helpful to have the regex selection of a text output in terminal be able to be highlighted.
In the case of an output log steam, having any 'error' or 'warning' keywords highlighted would be helpful.
Exmaple regex for finding 'error' in a commands output: 'error.*?([;\n$])'
Is this possible to achieve utilizing the code from this repo?
How can we achieve this?

No, zsh-syntax-highlighting only handles the zsh command line. Command output does not pass through zsh at all. I'd recommend seeing if your terminal emulator has such a feature.

For your specific use-case, just pipe to egrep --color '^|error'.  You might need to add stdbuf(1) on the LHS of the pipe.  For the general case, expect(1) might be a good place to start.  Feel free to ask further on<EMAIL_ADDRESS>


Missing links

Searching for "backup and restore" produces 8 pages of results, this being the only actual hit for "backup and restore".  Then this page encourages you to go search for "backup and restore".
It appears the previous backup and restore documentation is no longer in the product documentation.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0574e6fc-c4e3-2f7d-c4ee-18084a1a6f15
Version Independent ID: 7e5356bd-bda4-730a-423a-54646ad10ebf
Content: Back up systems and data
Content Source: Skype/SfBServer2019/migration/back-up-systems-and-data.md
Product: skype-for-business-itpro
GitHub Login: @kenwith
Microsoft Alias: kenwith

@JoshJ-MSFT @ Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

@officedocsbot assign @scanum

@JoshJ-MSFT Regarding the e-mail from Ken, please let me know which article you would like to have added to this doc.


"tuple is not valid solidty type"

It works when there is a tuple input, but when there's an tuple output, it's returning the error: tuple is not valid solidty type. Using the ABI:
[
    {
        "inputs": [
            {
                "internalType": "uint256",
                "name": "Id",
                "type": "uint256"
            },
            {
                "internalType": "address",
                "name": "_who",
                "type": "address"
            },
            {
                "internalType": "uint256",
                "name": "_amount",
                "type": "uint256"
            }
        ],
        "name": "dummySetter",
        "outputs": [],
        "stateMutability": "nonpayable",
        "type": "function"
    },
    {
        "inputs": [
            {
                "internalType": "uint256",
                "name": "Id",
                "type": "uint256"
            }
        ],
        "name": "dummyGetter",
        "outputs": [
            {
                "components": [
                    {
                        "internalType": "address",
                        "name": "user",
                        "type": "address"
                    },
                    {
                        "internalType": "uint256",
                        "name": "amount",
                        "type": "uint256"
                    }
                ],
                "internalType": "struct dummy.dummyStruct",
                "name": "",
                "type": "tuple"
            }
        ],
        "stateMutability": "view",
        "type": "function",
        "constant": true
    }
]

Hey I think I solved this on the latest release can you try to download package 1.1.1 and it should support tuple outputs. Let me know if it works for you and if it doesn’t il take a look. @butttons

Ah, that was it. I was on 1.0.10, and misread the version on NPM, assuming it's the latest. The 1.1.1 build works fantastic, thanks for your swift response and this wonderful package.

Awesome, appreciate the kind words happy developing!! 👍👍


descent3-unwrapped: 1.5.0-beta-unstable-2024-10-29 -> 1.5.0-beta-unstable-2024-12-14

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for descent3-unwrapped is: Game engine for a 6DOF first-person shooter
meta.homepage for descent3-unwrapped is: https://github.com/DescentDevelopers/Descent3
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.5.0-beta-unstable-2024-12-14 in filename of file in /nix/store/ppw5y6y6lfjq65jnzps9gq1d5hgld6yz-descent3-unwrapped-1.5.0-beta-unstable-2024-12-14

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath

descent3
descent3-unwrapped

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/ppw5y6y6lfjq65jnzps9gq1d5hgld6yz-descent3-unwrapped-1.5.0-beta-unstable-2024-12-14 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A descent3-unwrapped https://github.com/r-ryantm/nixpkgs/archive/518c9960399bf34550b346a073beb97ac13a3367.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/518c9960399bf34550b346a073beb97ac13a3367#descent3-unwrapped

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/ppw5y6y6lfjq65jnzps9gq1d5hgld6yz-descent3-unwrapped-1.5.0-beta-unstable-2024-12-14
ls -la /nix/store/ppw5y6y6lfjq65jnzps9gq1d5hgld6yz-descent3-unwrapped-1.5.0-beta-unstable-2024-12-14/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 2 packages built:

descent3
descent3-unwrapped

Maintainer pings
cc @Jayman2000 for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

@NixOS/nixpkgs-merge-bot merge


[Bug]: regenerate with keep-gamerules

/mv version -p output
4.3.2-SNAPSHOT-b870
Server logs
none
Server Version
paper 1.19.3

Bug Description
when you use /mv regen {WORLD} [-s [SEED]] [--keep-gamerules]
this should regenrate the world with seed you want and all flags keep same but the seed should be a word, if you use a number in the [Seed] it's get changed to 0
and another thing --keep-gamerules don't remmber the worldborder
Steps to reproduce
create a world
/mv cerate test normal
regerate it
/mv regen test -s 11111 --keep-gamerules
this will change the seed to 0 and worldborder get reseted
Agreements

[X] I have searched for and ensured there isn't already an open or resolved issue(s) regarding this.
[X] I was able to reproduce my issue on a freshly setup and up-to-date server with the latest version of Multiverse plugins with no other plugins and with no kinds of other server or client mods.

The world border is not a gamerule, and thus it does not get remembered with --keep-gamerules but the -s is ignored in testing

Can also confirm I am having these issues as well


Main beta

Guys don't worry.
It was opened ardently but I will use it for our 3.0.0 release PR cause we need such PR anyway )


Add value validation to TypeSpecs

Such as minLength and pattern matching.

Is this still a thing? @daschult

@RikkiGibson I haven't killed it off yet. It's something I'm hoping to get back to someday to see if it offers a better experience than Mappers. I don't really have any immediate plans for it, though.


Startup time slower even though running as gapplication service

Describe the bug
I have a shell script that launches "walker --gapplication-service" and walker normally (to have it open on boot). But even though it should be running as a service, subsequent walker calls seem to not use the service and are slower to launch then when I was previously using the runAsService option to create the systemd service.
Version
Master
Minimal Config
Config is currently default, and theme is same as Kanagawa theme (though defined in Nix home manager)
To Reproduce
The script I have in my exec-once of Hyprland is just:
walker --gappliaction-service
sleep 0.5
walker
Expected behavior
I would think this would launch the walker service, then launch walker using the service, and then continue using the service for any following walker calls.
Screenshots
N/A
Desktop

OS Nix
DE Hyprland

Additional context
I have the option runAsService disabled btw, but this is equivalent to --gapplication-service afaik

You'd need to provide a full script.
You can do walker --gapplication-service -b and walker -b to see if the service is being called. The service should log (after opening second time) something along the lines of Visible (re-open).
For Hyprland I personally just do exec-once=walker --gapplication-service in my Hyprland config.

When I run walker -b with the script running walker -gapplication-service I get this:
walker -b
Startup:<PHONE_NUMBER>924064418
start run:<PHONE_NUMBER>924180311
start handle cmd:<PHONE_NUMBER>948708075
run activate:<PHONE_NUMBER>948723689
Calc disabled: currently 'qalc' only.
INFO Failed to realize renderer of type 'GskNglRenderer' for surface 'GdkWaylandToplevel': Failed to create EGL display
priority=5 code_file=../gsk/gskrenderer.c code_line=753 code_func=gsk_renderer_new_for_surface glib_domain=Gsk
INFO Failed to realize renderer of type 'GskGLRenderer' for surface 'GdkWaylandToplevel': Failed to create EGL display
priority=5 code_file=../gsk/gskrenderer.c code_line=753 code_func=gsk_renderer_new_for_surface glib_domain=Gsk
INFO Failed to realize renderer of type 'GskVulkanRenderer' for surface 'GdkWaylandToplevel': Could not create a Vulkan instance: The requested version of Vulkan is not supported by the driver or is otherwise incompatible for implementation-specific reasons. (VK_ERROR_INCOMPATIBLE_DRIVER)
priority=5 code_file=../gsk/gskrenderer.c code_line=753 code_func=gsk_renderer_new_for_surface glib_domain=Gsk
Visible (first ui)<PHONE_NUMBER>353565998
and then running walker -gapplication-service -b and then running walker -b all of the debug mesagges are displayed from the --gapplication-call. So I would assume the service is not running initially from this.
This is the script:
{ pkgs, ... }:
pkgs.writeShellScriptBin "walkerLaunch" ''
walker --gapplication-launch
walker
''

That scripts looks cursed. i literally dunno what this is even supposed to do. why do you run walker after starting the service?
Log messages being shown in the server instance, means the server instance is working.

Yeah I probably am doing something wrong on the script side, but it is just meant to start the service and then launch walker straight after so it appears straight away on boot

It’s also in Nix so that will just equate to a script file that is just what is in the “”

I mean, sure... the script executes things.... but if it closes, it also closes the service.

Ahh, yes of course it does. I was doing this because as far as I know the order of the exec-once calls are arbitrary so I can’t do:
exec-once = walker —gapplication-service
exec-once = walker
As I was running into a similar problem here, though this might be due to a different reason I’m not sure

I mean.. if you only want it to be shown when opening Hyprland... you'd just do exec-once=walker -n i guess? + ofc launching the service anyways for other usage.

Yep, that makes more sense. Thanks. I was originally starting on Hyprland launch as the first launch when the service is running in the background is like a normal launch, but I would assume that is by design.


Add new Rails/TimeUnitNumberForm cop

This PR adds new Rails/TimeUnitNumberForm cop.
It checks the usage of singular and plural method forms for year, week, month, day, hour, minute, and second.
# bad
1.hours
42.minute

# good
1.hour
42.minutes

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
[ ] If this is a new cop, consider making a corresponding update to the Rails Style Guide.

What is the difference to Rails/PluralizationGrammar?


Expand child list when filtering

I have set collapsed property to be true on new TreeviewItem, but i want it to the collapsed property to be false on filtering item. So that user can see what items are filtering. Thanks!

Yes, I will have a fix for this. Thank for your idea.

Thanks for the quick reply! Hope to see the tix soon.
Best,
Phoebe
On Sun, May 21, 2017 at 8:30 PM Leo Vo<EMAIL_ADDRESS>wrote:

Yes, I will have a fix for this. Thank for your idea.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/leovo2708/ngx-treeview/issues/7#issuecomment-302991134,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ARID3M0Iohez2TGqdDJ0HhuFQIpsxNrNks5r8QFsgaJpZM4NhxSV
.

--
Best,
Phoebe Y. Maio
Email<EMAIL_ADDRESS>Github https://github.com/phoebeye | Linkedin
http://www.linkedin.com/in/phoebeye/ I Facebook
https://www.facebook.com/phoebe.ye.5

This enhancement is included in version 0.0.4.

Thank you so much!
Best,
Phoebe
On Tue, May 23, 2017 at 1:21 AM Leo Vo<EMAIL_ADDRESS>wrote:

Closed #7 https://github.com/leovo2708/ngx-treeview/issues/7.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/leovo2708/ngx-treeview/issues/7#event-1093181283, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ARID3CR-DQ3x6QSYFUxLakY1GZ3STsshks5r8pcjgaJpZM4NhxSV
.

--
Best,
Phoebe Y. Maio
Email<EMAIL_ADDRESS>Github https://github.com/phoebeye | Linkedin
http://www.linkedin.com/in/phoebeye/ I Facebook
https://www.facebook.com/phoebe.ye.5


Error thrown when going to address page of transaction hash

I typed /address/0xbac4cb10f95b37dab2c8a78e880d39661cc53f87386ded2fb721ac2304113ea3 into the address bar by mistake instead of /tx/0xbac4cb10f95b37dab2c8a78e880d39661cc53f87386ded2fb721ac2304113ea3.
The page is blank accept for the header and footer. There is no error message displayed on the page like the one you get going to /address/notanaddress. I sat waiting for a while until I realized the rest of the page wasn't loading.
In the browser console an error is thrown:
Error: invalid address (argument="address", value="0xbac4cb10f95b37dab2c8a78e880d39661cc53f87386ded2fb721ac2304113ea3", code=INVALID_ARGUMENT,

The fix is probably simple and related to address parsing.

BTW, sorry for the lack of updates, I'm in the middle of a trip/conferences, it's been a little hard to find time/silent place to concentrate on work.
I think the next few days I'll cleanup the issues backlog (or at least answer most of them), but pls keep them coming :)

This issue appears to have been solved. The AddressOrENSNameNotFound component renders when you do this now that we use isAddress in useAddressOrENS.


TextField docs for getting value

Description
This PR adds examples of how to use the value from a TextField in both TextField and onChanged.
Related Issues
Closes https://github.com/flutter/flutter/issues/39661
Tests
None, just a docs change.

@HansMuller Is onSubmitted the best way to get a value from a TextField?  Also, am I overdoing it with the dartpad examples or are we trying to move in that direction?

@justinmc I don't think that we're anywhere near close to overloading on dartpad examples. More is better!
It would probably be helpful to reiterate the different between onSubmitted and onEditingComplete in the example. Basing the example on the former seems reasonable to me.

Please check that the samples analyze OK:
TMPDIR=/tmp dart dev/bots/analyze-sample-code.dart --temp=samples


feat: completing docs

Completing the docs and Finalize it with Final touch!
In this Pull Request, I'm completing the docs and updating some documentations~!

Poggers,  Let's merge it to master

Merged #33 into master.


Option to label axes

Could we please have an option to label our axes? It's pretty easy based on
, I did a mockup myself.

@bkil Axis Titles/Labels is in the Roadmap.
Still don't know how to implement this as tables don't support this.
For now, you can use a wrapper
 with a
 and axis titles as separate elements.

The messy, hacky proof of concept you see on the screenshot was produced by this:

https://github.com/bkil/osm-tooling/blob/0a234fba20bc8d375183feb464b02e59f9e9d83e/src/web/barchart.css#L39

You can find the live demo link in the head of spamisi.sh - I'm too embarrassed to link to it directly. :smile:
Basically, I align the first header cell and rotate the second one via selectors like .barchart > thead > tr > * + th, although my positioning is much inferior to how you are doing it, hence why I would like to use your library instead.

Ok, let me try to help you here...
HTML Structure:

 ...

 Y Axis Label

 X Axis Label

CSS:
body {
  display: flex;
  justify-content: center;
  align-items: center;
  height: 100vh;
  margin: 0;
}
#my-chart {
  display: grid;
  grid-template-columns: 40px 600px;
  grid-template-rows: 250px 40px;
  grid-template-areas:
    "y-axis chart"
    "x-axis x-axis";
}
#my-chart > table {
  grid-area: chart;
}
#my-chart > .y-axis {
  grid-area: y-axis;
  text-align: center;
  writing-mode: tb-rl;
}
#my-chart > .x-axis {
  grid-area: x-axis;
  text-align: center;
}

Result:

I think we I'll add this example to the docs...

Thank you for the example, although I've also understood what you meant in your original comment. This workaround is not acceptable. My solution keeps the semantic value of the table (showing the column headings in the table header row) and displays correctly under console based browsers and could be consumed by machines as well, while the same can't be said about random div's.

Although, I see what you did there with writing-mode. :rocket:

Docs updated: https://chartscss.org/components/axes/#axis-title

So is this a "WONTFIX" or is it still on the roadmap?

Basically
 tags don't support axe titles.
I like your solution, you are using
 tag, I don't use this tag at all. Very interesting use-case. But when developing a framework, we need to address all the edge cases.
You do have a great workaround using the table raw data (located in
), BUT it works only for single-datasets, not for multiple-datasets. When we have a many  /  tags inside your
 tag, which one is used as axe title?

       Country
       Gold
       Silver
       Bronze

For now I prefer to use an externa
 although I know it's not a semantic solution. But I'm not abandoning your approach, I will have to think how to make implement this for all edge cases.

Yes, I was wondering how this could be solved in a more universal way. I agree that this will probably be a special case only supported by single dataset tables and should be switched on with a special option.
Some of the maths will get a little bit more messy due to conditionally having to create space for the axis titles, but I think it could be worth it. I see tables and charts with single datasets pretty often, so this could be something that people should see often.
And of course I love it how it still displays correctly in Links2. :heart: :nerd_face:
After having seen how easily CSS charting could be done, it kills me to see all these review and comparison sites use .jpeg's or iframes (not long ago Flash) just to display such simple charts.

@bkil possible solution using grid, check this out https://github.com/ChartsCSS/charts.css/issues/45
doesn't solve the multiple-datasets issue but at least now I have a simple implementation for axis titles.

Basically
 tags don't support axe titles.
I like your solution, you are using
 tag, I don't use this tag at all. Very interesting use-case for this tag.
But when developing a framework, we need to address all the edge cases. You do have a great workaround using the table raw data (located in
), BUT it works only for single-datasets, not for multiple-datasets. When you have many  /  tags inside your
 tag, which one will be used as axe title?

       Country
       # of Gold Medals
       # of Silver Medals
       # of Bronze Medals

For now I prefer to use an externa
 although I know it's not a semantic solution. But I'm not abandoning your approach, I will have to think how to implement this for all edge cases.

Definitely agree with the mentality of "when developing a framework, we need to address all the edge cases ... including the multiple datasets". In this particular case, though, how could it be possible to implement this inside
...
 tag? In the example quoted above, neither of the individual  headers, nor the concatenation of them, would be a good y-axis label. The proper y-axis label sentence should be something like "# of medals", which has to be provided by another tag.

Still don't know how to implement this as tables don't support this.

So, I think the extra
 tag i.e. the Axis Title approach is inevitable. It would end up with a wrapper with 2 more div.axis-title tags. The next question is, could we legitimate the axis title tags into General Anatomy, and even predefine some CSS classes for them? Just like the way Charts.css predefines a set of CSS classes for the beautiful legends.

I have a way to add axis titles using CSS Grid. I need to develop this. But the solution will not require extra
 elements. It will use existing markup.

Interesting. I hope that "existing markup" is not the  headers. The  in multiple-datasets can not be used to derive a proper y-axis label.

Simple 2D tables with a single dataset are very common in the real world. I wouldn't mind if we had two separate solutions, so that at least the simple ones could look awesome under links2 or on dumb HTML preview panels (and maybe in HTML emails as well, though not sure if this is something that is being optimized for).


add chaos-mesh repo

@wuxiaohui94 The Helm Hub is going to be deprecated soon and will point people to the Artifact Hub. So your repository is not lost in the process, can you please list it on https://artifacthub.io/

The Helm Hub has been superseded by the Artifact Hub. Chart repositories should now be listed there. Closing this PR.


Update device mappings

Fixes #337
@phickey

🇨🇭  (there's some more updates/corrections, will raise as new PR)


How to prevent filtered log output to the console?

  fastify.register(fastifySentry, {
    shouldHandleError(error, request, reply) {
      if (error.name == 'NotFoundError') {
        return false
      }
      return true
    }
)

I want to filter these logs in the console as well:

Hi @meotimdihia ! The shouldHandle function should filter error events that the Sentry SDK sends to your Sentry instance, it doesn't have nothing to do with the errors logged on stdout. You can prevent something logged on stdout maybe using the log level configuration of the fastify logger.

Looking at what we do in the plugin here, we log the error anyway. This is consistent to what the default error handler in fastify does. As far as I know though, it doesn't log 404 with an error level, I suspect that this might be caused by the use of @fastify/sensible? Are you able to try the same thing without using the plugin error handler and see if the error is logged anyway?

I am not sure how I feel about making the plugin filter error logs , I don't think it can be done via logger setting either, see https://getpino.io/#/docs/help?id=log-filtering.

@dnlup thanks, I'll investigate the problem further.
I guess it is not related to this plugin :)

One last thing, you can use a custom error handler instead of the one provided by the plugin and filter the logs however it's needed by your application.

@dnlup thanks, I'll investigate the problem further. I guess it is not related to this plugin :)

No problem 😉


Back up and install macOS settings

Find a way to download all settings, back them up to dot files repo and add to the install process.
For example using Mackup

User preferences are in ~/Library/Preferences. We can read the files with $ defaults read <file_name>.
Check $ man defaults to learn more about the defaults cli tool where you can read and write user preferences.


form fields focus

Hellow all,
I have a page with multiple paper-inputs, and would like to navigate through the inputs using the tab key.
Also I would like to use <IP_ADDRESS>-SNAPSHOT because of its element support, as well as Vaadin icons. But there is an issue with the tab navigation, i need to tab twice in order to get to the next paper-input.
There is one thing that may be of interest, though. On the rendered page, the paper-input elements get tabindex="0" as well as paper-input-container element gets tabindex="0". All this is happening with GWT-2.8.0-beta1 & <IP_ADDRESS>-SNAPSHOT as of today.
I ahve noticed that <IP_ADDRESS> does not have that issue. Also, <IP_ADDRESS> does not generate those tabindex attributes.
For now GWT-2.8.0-beta1 & <IP_ADDRESS> works, therefore I had to revert back to <IP_ADDRESS>.
Is it something that can be fixed easily? I don't know much about Polymer and GWT, but if someone guides me I can try to fix it, already having a project to test it.
Kind Regards to all

Can you try <IP_ADDRESS>-SNAPSHOT, this should be fixed.


Missing tag for version 1.5.5-10

I saw the release of version 1.5.5-10 in the maven central repository, but I didn't find the tag for this version in Github

added it


Provide a deterministic method of associating the task execution with the terminal instance

Issue type: Feature Request
For our extension, we need an API to associate task execution instances with terminal instances that are used for rendering task output.
If that's not possible to implement, we'd need a method for determining a category of each terminal instance. This API would help us identify a subset of terminals being used for rendering task outputs.
//cc @dbaeumer @Tyriar

Follow up on a discussion started in #46192.

One thing that should be noted is that there is the concept of a composite task which simply spawns n other tasks. A composite task has no own command and therefore when executed can't provide a process id (since it doesn't spawn a process). So the processId for a task in the API can only be optional.

@alpaix can you go over the exact case you need this for? It wasn't clear to me from the other discussion. Is this for the case where VS Code is the host, launches a task and the task output needs to be sent not to a terminal but to some task output pane in a VS guest?

@Tyriar Based on an earlier proposal we're trying to pursue a unified model of task output sharing. The host IDE will provide an API to enumerate terminals used for rendering task outputs along with an API to read/write from these terminals. Our extension will take care of mirroring terminals' content. In case of VSCode being a host, we're planning to share task-specific built-in terminals only, mostly because of different permissions needed for sharing interactive terminals. Given that limitation, we'd wanted to be able to identify which terminals are used for terminals. This could be done either by associating task execution with a terminal instance or by having a terminal category or similar.
Thoughts?

@dbaeumer In case of a built-in terminal used for task outputs what process ID would be provided?

@alpix the process id of the shell running the command. E.g. the same as Terminal#processId.
Actually if you only need to have terminal groups then I would propose that we have the API on the terminal. Something like:
enum TerminalGroup {
   Interactive, Task
}

Here is the current thinking on my side:
export namespace window {
    export interface Terminal {
        type: TerminalType;
    }

    export type TerminalType {
        Interactive,
        Task
    }
}

As for whether we need to associated a task with a terminal I'm still not sure. If we do I think this would be @dbaeumer providing this API, something along the lines of:
export namespace window {
    export class Task {
        terminal: Terminal;
    }
}

Or:
export namespace window {
    export class Task {
        processId: Thenable<number | undefined>;
    }
}

We cannot have an API on Terminal that gives the task as the tasks part has a dependency on the terminal part, not the other way around.

We cannot have an API on Terminal that gives the task as the tasks part has a dependency on the terminal part, not the other way around.

@dbaeumer perhaps the eventual terminal type API shouldn't exist at all because of this? This will be the first task-specific API in the terminal within VS Code. My implementation will probably just check waitOnExit for now.
I'm leaning more towards just this in the long term to enable getting a list of task terminals and being able to link them:
export namespace window {
    export class Task {
        terminal: Terminal;
    }
}

According to the current VSCode task execution model, task terminals can be shared across different task executions. Meaning, the same task could be associated with various terminal instances at different point of times. So I think it'd be more practical to add terminal property to the TaskExecution class. Alternatively, terminal property could also be placed in TaskStartEvent.
I like the idea of having TerminalGroup categories. It's beneficial to our extension to distinguish a  terminals based on the group property.

So I think it'd be more practical to add terminal property to the TaskExecution class.

@alpaix that's what I meant, I haven't used the task API yet 😄

@Tyriar

@dbaeumer perhaps the eventual terminal type API shouldn't exist at all because of this? This will be the first task-specific API in the terminal within VS Code. My implementation will probably just check waitOnExit for now.

I agree and the whole underlying problem is that neither you nor me want to expose implementation details. That tasks use terminal as an execution engine is something I don't want to have in the API either :-) especially since there are still old tasks that don't even run in the terminal (but for LiveShare I think we need to ignore this). This is why I opted for a processId since the stable thing around tasks is that they are executed via processes (with the exception of composite tasks)
Since we split the terminal into a renderer and the tty engine I can even think about using a terminal for output that is not bound to a process. So having an indication on a terminal what is is used for might not be a bad idea. But may be that shouldn't be something you infer. It should be something tasks passes into the terminal instance.
Regarding:

Meaning, the same task could be associated with various terminal instances at different points of time. So I think it'd be more practical to add terminal property to the TaskExecution class. Alternatively, terminal property could also be placed in TaskStartEvent.

This is exactly the opposite. A task when executed is always bound to one terminal. However tasks reuses terminal (renderers) and the same terminal can be used for different task runs.

@dbaumer I'm probably missing something.

This is exactly the opposite. A task when executed is always bound to one terminal.

The same task could be executed in different terminals. For instance, when the terminal instance used earlier was either closed by a user or is busy rendering some other task. Do you say terminal property value of the task would change after each execution?

After chatting with @dbaeumer in Slack we're leaning towards adding a processId in the task APIs. Then you will be able to compare with Terminal.processId to get the mapping.

@alpaix you should be able to map tasks with their terminals fairly reliably already by listening to the proposed APIs: window.onDidOpenTerminal and workspace.onDidStartTask, similar to the code sample in https://github.com/Microsoft/vscode/issues/46192#issuecomment-381597261.

@alpaix I misunderstood your statement. Just to clarify: a task execution is bound to exactly one terminal. When a task execution is bound to a terminal the terminal can not serve any other task. The same terminal renderer can server n different task execution in sequence. If a task is executed 2 times it might or might not use the same terminal renderer.
One thing to add for the processId. The id will be undefined for tasks that are not bound to a process / shell. These tasks don't generate any output right now.

I added corresponding API to monitor the process start / end of a task. I will close the issue. Please ping if you think there is still work to do.


Bulk index and Sidekiq: java.lang.OutOfMemoryError: Java heap space

Hi!
I use the Elasticsearch::Persistence.client client to perform parallel bulk inserts in ES 5.2. The bulk insert is done by sidekiq jobs.
Here some config information:
- bootstrap.memory_lock=true
- ES_JAVA_OPTS=-Xms5g -Xmx5g
- maximal memory limited to 10 G
- thread_pool.bulk.queue_size: 500
- CPU 8 cores
- Sidekiq processes: 6
- Sidekiq threads per process: 15
- All processes has all 15 threads processing an IndexerJob
- All done proposed here: https://www.elastic.co/guide/en/elasticsearch/reference/current/tune-for-indexing-speed.html

Here a small example:
class IndexerJob < ActiveJob::Base
  def perform(objects)
    Elasticsearch::Persistence.client.
      bulk(index: MyModel.index_name,
              type: MyModel.document_type,
              body: objects)
  end
end

I get this error in ES after some jobs are processed:
java.lang.OutOfMemoryError: Java heap space
Dumping heap to java_pid1.hprof ...
Heap dump file created [5474370005 bytes in 45.184 secs]

Question: Do I need to flush the bulk insert after insert to reduce heap memory or what I am doing wrong?
Another question: Are the bulk inserts asynchronous or not?
I have read something about bulk here: https://www.elastic.co/guide/en/elasticsearch/client/java-api/current/java-docs-bulk-processor.html (setFlushInterval, setConcurrentRequests). Can I config the bulk insert with elasticsearch-rails?

Hi, first, thanks for all the detailed info!

Do I need to flush the bulk insert after insert to reduce heap memory or what I am doing wrong?

in general, it is best to leave Elasticsearch at defaults. That said, you might experiment here by executing the indices.flush_synced operation between the batches, and observe the effect on the memory. Also, if this is a heavy import, which takes significant time, you might want to experiment with disabling the refresh interval to see if it has any desirable effect.

Are the bulk inserts asynchronous or not?

Not on the Ruby layer, and they are not "asynchronous", but parallel on the Elasticsearch layer -- the requests for each shard are executed on corresponding node in parallel.
I've sometimes experiment with making the operations asynchronous on the Ruby layer (using process/threads), and I always felt like the throughput increase isn't worth it. That said, I'd like to experiment by using https://github.com/grosser/parallel and capture some benchmarks, if there'd be more time.
That said, you probably have a lot of asynchronicity coming from the fact that you're using Sidekiq for processing the operations -- essentially pushing data to Elasticsearch in parallel, in 15 threads. Or, and I'd need to verify this, in 6 * 15 threads (15 threads per worker, 6 workers in total). This might easily overload the cluster, because it cannot keep up. Are you checking for the 429 HTTP status code coming from Elasticsearch, and stalling the jobs in that case a bit, effectively applying this back-pressure to the Sidekiq layer?
(Mental note to myself: this should be added to the example in the Rails example application.)

I have read something about bulk here:

These parameters apply to the Java API, not the HTTP REST API, which the Ruby client uses.
Regarding your main question about the out-of-memory error, my best bet is that you're overloading the cluster either with too much parallelism or too big batches. So, the easiest way is to cut down the number of Sidekiq workers, and see what happens. If that helps, you can go in the other direction, and decrease the number of documents (objects in your code) you're sending in each bulk operation, and see what happens. Depending on your data and the desired requirements, you might find a good balance here.
Of course, there knobs to turn, such as indices.memory.index_buffer_size, or other strategies, like temporarily increasing the number of nodes in the cluster, but I'd first try the techniques applied in the former paragraph.
Can you check these out and let me know how everything behaves? Heavy bulk loading is an important use case and the more info there is out there, the better!

Thank you for the detailed answer. My seed pre-configures ES with:
'index.refresh_interval' => -1,
'index.number_of_replicas' => 0

Sidekiq
I have some Ruby processing and DB queries in my IndexerJob before the bulk import happens. An important note is, that Sidekiq threads (in my case 15 threads per worker process) are concurrent but not parallel. Only the 6 worker processes works in parallel. And I don't get 429 HTTP code errors.
Index buffer size
I have found indices.memory.index_buffer_size on ES documentation. Default is 10% of the JVM heap memory. Actually I have running the seed with the following config without crash:
HW config

CPU 8 cores
about 40 GB RAM

ES config

bootstrap.memory_lock=true
indices.memory.index_buffer_size=10%
thread_pool.bulk.queue_size=500
ES_JAVA_OPTS=-Xms10g -Xmx10g
maximal memory limitation to 20 G

ES transient config (only on seed)

index.refresh_interval=-1
index.number_of_replicas=0

Sidekiq config

Sidekiq processes: 6
Sidekiq threads per process: 15
All processes has all 15 threads processing an IndexerJob
The bulk document size is not constant. It varies from 4000 to 5500 documents per bulk insert.

Any idea why the Index memory is only rising?

Thanks for all the details!

Actually I have running the seed with the following config without crash (...)

So, what has changed since your original configuration?

Any idea why the Index Memory is only rising (linear)?

Yes, that seems quite logical to me -- when you look at the type of the memory, it's the "Terms" part of the "Index Memory" output. It grows with the amount of documents you keep adding to the index during the bulk load, because that's the fundamental Lucene data structure keeping the inverted index.
This should correspond to the curl 'http://localhost:9200/_cluster/stats?pretty&human' | jq '.indices.segments.terms_memory' part of the "Cluster Stats" API output.
If you would be interested in the lowest-level details, you may check the "Segments" API in verbose mode: curl 'http://localhost:9200/_segments?human=true&verbose=true' | jq ., which would give you the breakdown for specific fields. (Not sure now if it's available on 2.x though.)

Actually I have running the seed with the following config without crash (...)
So, what has changed since your original configuration?

I'm still interested if anything has changed in your configuration and/or environment, since the operation has been failing previously, and now runs fine. Any news there? :)

Hi! The problem was the amount of RAM. Giving more RAM to the machine and to the JVM solves the problem. In fact, the Index Memory has reached the maximal memory. That causes the error. Working with the following memory configuration all works fine for the moment:

ES_JAVA_OPTS=-Xms20g -Xmx20g
maximal memory limitation to 40 G

Here a good documentation that I have found: https://thoughts.t37.net/how-we-reindexed-36-billions-documents-in-5-days-within-the-same-elasticsearch-cluster-cd9c054d1db8

Closing because this has been resolved.


Colorado 2019

#38

Pull Request Test Coverage Report for Build 187

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 66.205%

Totals

Change from base Build 185:
0.0%

Covered Lines:
909

Relevant Lines:
1373

💛  - Coveralls


USB Keyboard SmartCard Authentication issue

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

https://github.com/FreeRDP/FreeRDP/wiki/BugReporting

XfreeRDP Version 2.0.0-RC2
Server to Connect Windows Server 2008 R2
SmartCARD : LENOVO KEYBOARD SMARTCARD
I want to use the above mentioned Lenovo Keyboard Smart card for authentication.But when i got the session of the server it gets stuck on "Please unlock the smart card with external device".

Support questions please via IRC or mailing list.

You should get the reader doc:
https://download.lenovo.com/pccbbs/options/usb_smartcard_kb_en.pdf
That message doesn’t come from FreeRDP, but from the card driver.  Check the leds and the doc. My guess is that it requests that you type the PIN on the keypad.


[BUG] Worksheet interface has changed type of columns member field

🐛 Bug Report
When moving from version 4.1.1 to 4.2.0 - we noticed the Worksheet.columns type has changed from:
columns: Array<Partial<Column>>;

to:
	columns: Array<Column>;

This wouldn't ordinarily be a problem except that the current Column interface requires the user to specify a series of member fields in the Column instance that should either:
a) be nullable or
b) have a helper function (like Worksheet.addColumn(..) )
so that the user doesn't have to specify the value for fields that have should have obvious default values.  Example - callers who are inserting mundane columns into a worksheet shouldn't need to manually populate the following fields:
	outlineLevel: number;
	hidden: boolean;
	style: Partial<Style>;
	values: ReadonlyArray<CellValue>;

Lib version: 4.2.0
Steps To Reproduce
The following is now an error in typescript (only as of version 4.2.0):
worksheet.columns = [{header:'some header', key: 'some key'}]

The expected behaviour:
The likely preferred solution would be to simply allow users to use a convenience function like the Table.addColumn(..) function - but rather exposed in the Worksheet (like addRow(..) already is).

It looks like this has been corrected on Oct 28th - but it still might be helpful to add that convenience function to the Worksheet interface (addColumn(WorksheetColumnProperties)) or something like this - to allow you to make your columns member field into a non partial one day.


Deeplink error

Hi
Thanks for develop SolPlay for other developers.
I have problem for used Solpaly when transfer token or transfer NFT callback is error
Deeplink error: Error: Expected signatures length to be equal to the number of required signatures + Data:
Solana.Unity.SDK.PhantomDeepLink:ParseSuccessfullySignedTransaction(String)
What should i do?

Hey yes thats an error for ios deeplink. Im already investigating. Didnt find a solution yet.

@Woody4618
No this error for Android .
what is the solution؟

Signature was empty
How fill up Signature ?

Talk to Solana Support on the Solana Live Support so that your issue can be looked into.

Hey, i have a potential fix.
Could you try integrate this branch:
https://github.com/Woody4618/Solana.Unity-SDK.git#Remove_WebSocket
Just add it as usual in the package manager git url field.
Let me know if that fixes it.

@Woody4618
Thanks man.
but  project have a error .
error on websocketOnOnError

Puh hmm, can you give a bit more detail on this?

Error! Unable to connect to the remote server
when logined .   I have error

Which RPC uri do you have configured on the WalletHolder?

when change RpcCluster in WalletHolderService to dev net .
i have error.

Yeah it doesnt work for all RPCs. Maybe you dont need it. Its only used to get account updates for Tiny Adventure and to always have the current solbalance of the wallet available live. Are deeplink transactions working now?

yesh. is working  deeplink transactions
Thank you so much

For the Socket thing I can make another update or you try to disable the socket connection yourself and use GetBalance on the basewallet instead to get the current sol balance if you need it.

now , I disable the socket connection

Hi @Woody4618
I have a question . your project support PDAs and SPL Token ?

yes

Hi
How are you?
Happy New Years.
I have a question ?
How Create NFT in Solplay?
Are you have a example ?


New 1.50 update not working for windows 32 bit

it seems like the new 1.50 bloxstrap update doesnt work for windows 32 bit and there is no option to choose which version of it you want to download

Added an x86 build to the release page, sorry about that.


Add resource creation timestamps to API

Fix #1345. Creation Timestamp only, for now.

[x] Namespaces
[x] Applications
[ ] Configurations
[ ] Catalog Services
[ ] Service Instances

Codecov Report

Merging #1462 (aa9002d) into main (6aa8893) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main   #1462      +/-   ##
========================================
- Coverage   9.06%   9.04%   -0.03%
========================================
  Files         79      79
  Lines       7581    7598      +17
========================================
  Hits         687     687
- Misses      6849    6866      +17
  Partials      45      45

Flag
Coverage Δ

unittests
9.04% <0.00%> (-0.03%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

internal/application/application.go
0.00% <0.00%> (ø)

internal/cli/usercmd/app.go
4.95% <0.00%> (-0.09%)
:arrow_down:

internal/cli/usercmd/namespace.go
1.44% <0.00%> (-0.04%)
:arrow_down:

internal/cli/usercmd/push.go
6.81% <0.00%> (-0.07%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6aa8893...aa9002d. Read the comment docs.


Bundle web-tree-sitter and added Haskell support

This pull request changes the build process of vscode-parse-tree to build web-tree-sitter, rather than depending on the published version in the NPM package registry, as it frequently lags behind the main version.
Furthermore, it uses this to add support for Haskell.

This seems to have loading path issues?

How come the yarn.lock keeps getting bumped? Are you explicitly asking it to upgrade everything?

I don't know, to be honest?

I've merged haskell-support into this pull request.

This is the diff for Haskell support:
https://github.com/pokey/vscode-parse-tree/pull/20/commits/a5f6a921c034df0f92e7e501136d8e55fdb1735e

Is this one ready for another round of review?  If not, of course feel free to re-request review when you want me to have another look

I don’t use yarn, so I’m not sure how it differs from npm, but npm run compile calls make compile, which generates the required vendor/web-tree-sitter/[VERSION]/ dependency.

I don’t use yarn, so I’m not sure how it differs from npm, but npm run compile calls make compile, which generates the required vendor/web-tree-sitter/[VERSION]/ dependency.

Hmm I cloned a fresh repo on your branch, and did an npm run compile (or rather, a yarn compile, which is the same), and got the following:
make: *** No rule to make target `parsers/tree-sitter-agda.wasm', needed by `compile'.  Stop.
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

I believe that's because the dependency of parsers/tree-sitter-agda.wasm is node_modules/tree-sitter-agda/package.json, but that doesn't yet exist because nothing has been installed yet, as I haven't yet run yarn (equivalent to npm install).
If, however, I instead start by running yarn, I get the following error:
➜ yarn
yarn install v1.22.17
warning ../../package.json: No license field
[1/5] 🔍  Validating package.json...
warning<EMAIL_ADDRESS>The engine "vscode" appears to be invalid.
[2/5] 🔍  Resolving packages...
error Package "web-tree-sitter" refers to a non-existing file '"/Users/pokey/src/vscode-parse-tree-test/vendor/web-tree-sitter/v0.20.4"'.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

Because I haven't yet run yarn compile.  That's what I meant by a chicken-and-egg thing.  You need to compile to create the proper dependencies, but then you need the proper dependencies to compile
I think we probably need to split the makefile's compile rule into two separate rules: one to build the web-tree-sitter package, and one to compile.  You would run the first rule, then run yarn, then run the second rule.  Make sense?

Changes:

Build web-tree-sitter in the preinstall script, rather than the compile script;
Added a patch to web-tree-sitter to bump the version number;
Add the vendor and .make-work directories to the list of excluded paths;
Removed the old version of web-tree-sitter from yarn.lock.

Ok so this all looks great! +70 for persistence 😅. I updated the contributing instructions; they haven't really changed it seems but I find it works better if I run yarn compile so that emscripten ends up on the path. A couple things left:

[ ]  Would be good to update the docs with instructions on how to upgrade web-tree-sitter, ie: that patch file, etc
[ ]  I'm still getting those failures on the cursorless html test cases after installing this branch locally.  If you're unsure how to debug the cursorless side of things I'd be happy to pair

stack trace: TypeError: Cannot read property 'apply' of undefined
	at [/Users/pokey/.vscode/extensions/pokey.parse-tree-0.14.0/node_modules/web-tree-sitter/tree-sitter.js:1:10374]()
	at _ZN3TagC2E7TagTypeRKNSt3__212basic_stringIcNS1_11char_traitsIcEENS1_9allocatorIcEEEE (<anonymous>:wasm-function[141]:0xad34)
	at _ZN3Tag8for_nameERKNSt3__212basic_stringIcNS0_11char_traitsIcEENS0_9allocatorIcEEEE (<anonymous>:wasm-function[125]:0xaa8e)
	at tree_sitter_html_external_scanner_scan (<anonymous>:wasm-function[25]:0x9d5e)
	at ts_parser_parse_wasm (<anonymous>:wasm-function[214]:0x24857)
	at Parser.parse ([/Users/pokey/.vscode/extensions/pokey.parse-tree-0.14.0/node_modules/web-tree-sitter/tree-sitter.js:1:35040]())
	at [/Users/pokey/.vscode/extensions/pokey.parse-tree-0.14.0/out/extension.js:82:43]()
	at Generator.next (<anonymous>)
	at fulfilled ([/Users/pokey/.vscode/extensions/pokey.parse-tree-0.14.0/out/extension.js:5:58]())
	at runMicrotasks (<anonymous>)
	at processTicksAndRejections (internal[/process/task_queues.js:93:5]())

How do I reproduce this HTML error?

You should be able to do a local package and install of this extension, then clone cursorless and run unit tests locally

Ok as discussed this one now seems to be working for me with cursorless locally, so just docs on how to upgrade web-tree-sitter and I think we're good to go!

I have added a short section documenting how to update web-tree-sitter, and I've added the version number to the patch file so that we can store some historical patches if we need to, and to make the upgrade process easier, e.g., no need for creating empty patches or for changing the patching code.

@wenkokke Are you also working on support for Haskell in cursorless-dev/cursorless-vscode?
If not I might look in too starting since cursorless could make my work week a lot easier :smile:

Yes, that’s next on my calendar, but if you’d like to have a chat I’d be happy to!


keystore: improve fingerprint mismatch error message

Show the filename & fingerprint for the mismatching key to assist
troubleshooting.
Targeting https://github.com/coreos/rocket/issues/655

ah, thanks! lgtm


Missed InvalidChangesetError errors on apply_action!/2 because they got transformed into :debug messages

In my application, an error gets raised because I tried to call Ecto.Changeset.apply_action!/2 on an invalid changeset.

** (Ecto.InvalidChangesetError) could not perform update because changeset is invalid.\n\nErrors\n\n %{\n […]

The problem is that I missed those errors because the error got transformed into a :debug message.
It happens because Phoenix Ecto considers that Changeset errors are only user errors and mark them as 4xx:
https://github.com/phoenixframework/phoenix_ecto/blob/v4.1.0/lib/phoenix_ecto/plug.ex#L6
and Plug Debugger converts 4xx errors to :debug logs:
https://github.com/elixir-plug/plug/blob/v1.10.3/lib/plug/debugger.ex#L165
Let me also please just stress that missed errors are terrible and scary.
Applying an action on an invalid changeset is a server error, not a user error. And devs need to be notified for such errors through error logs.

Please open up an issue on phoenix_ecto.


[SR-2660][Driver] Handle .swiftmodule inputs

Allow users to pass .swiftmodule files into the Swift driver when compiling without -g. The .swiftmodule files are then passed to the linker via -add_ast_path so that LLDB can access their AST information.
This addresses one of two driver changes suggested in the comments of https://bugs.swift.org/browse/SR-2660. The second is to detangle the -g option with the driver logic that determines whether to run a merge module job or not.
In addition to the unit tests, to make sure the debug info was being read properly by lldb, I also ran bash build-driver.sh on an updated version of the sample project attached to the original bug report, which I've uploaded here: https://github.com/modocache/SR-2660.

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test

Hooray! I'll try to disentangle -g in another pull request soon.

We should run empty_directory(%t) at the start and put all of the other intermediate files inside it (%t/simple.txt etc). But this fix is fine to repair the build first.


German translations

This merge request adds all missing German translations and fixes several problems with the existing ones (typos, punctuation, grammar, incomplete/outdated, and wrong translations).
Although German is my mother tongue, it's probably a good idea, if another German native speaker can have a look at this.

Coverage remained the same at 32.341% when pulling 5bc5aa2230811cf21b56d1c9f4fbd6e8b3858e8b on der-lyse:german-translations into 6c1dc60d68be4adfc8dcf9dee5f08fc8b21d7362 on akrennmair:master.

Thanks! Please update PO-Revision-Date and Last-Translator fields at the beginning of the de.po file.
You can also add yourself to Language-Team—we don't have formal translation teams, so people just write themselves in if they like. AFAIK we don't use this info in any way, but I might decide to ping you sometime to see if you want to update the translation.

Alright. I used the commit timestamp from my last commit making contentual changes to the de.po. I hope, that's correct. Do you want me to rebase it?

Thanks! I don't think the rebase is necessary.
I'll merge this once Travis is done with the checks.

Coverage remained the same at 32.341% when pulling c2c2dc0f2cffef6d8c0123c6812834f1d892d63b on der-lyse:german-translations into 6c1dc60d68be4adfc8dcf9dee5f08fc8b21d7362 on akrennmair:master.

Coverage remained the same at 32.341% when pulling c2c2dc0f2cffef6d8c0123c6812834f1d892d63b on der-lyse:german-translations into 6c1dc60d68be4adfc8dcf9dee5f08fc8b21d7362 on akrennmair:master.


Set Icon (On windows and MacOS)

Hi,
Thanks for the work you guys have done. I tried it create native image on windows and MacOS and its very easy to build and use.
Now my question is regarding setting Icon!! I have built helloFXML.exe from the example but it comes without ICON. Is there any way to set custom Icon? Tested on Mac and same issue. I'm assuming this is true for all OS (At least Desktop).

Basically the same answer as in https://github.com/gluonhq/client-maven-plugin/issues/220#issuecomment-670948048 applies here too, at least for macOS. It is relatively easy though to create such an .app bundle with icon yourself. I did it by creating a dummy .app bundle via the jpackage tool, which lets you specify a custom icon and other things and then later opened this .app folder and replaced the launcher with the executable file created by the client-maven-plugin and additionally deleted some other folders which are not needed anymore.

@mipastgt thanks for the tip. I have found the solution for both MacOS and Windows. I'm going to close the issue now.


compareSTR compatibility with STR imputation results

Hello,
I've been trying to use compareSTR to compare STR genotypes from a GWAS dataset imputed with the STR reference panel (1000G) against the same samples, but sequenced (whole-genome) and called with gangSTR. CompareSTR says it allows calls from hipSTR which is the base of the STR imputation, but the software doesn't recognize the vcftype. Is is possible to make compareSTR suitable to read imputed VCFs files? the imputation of STRs was done with Beagle as recommended.
Thanks!
~B

Hi B,
Sorry for the slow response. TRtools currently doesn't support Beagle, but it's a relative quick change to fix that. What's your use case (which tools are you intending to use)?
There's a catch. Beagle emits two types of output: hardcalls (i.e. this sample has genotype allele-1/allele-2) and probabilities (AP or GP format fields, which give a percent chance to each sample for each possible genotype). So far the tools have only been designed to work with hardcalls and not probabilities - adding the ability to read Beagle hardcall input won't change that. But for imputed callsets, probabilities are potentially more suited to downstream analyses like association testing.
If you desire to use the probabilities, then TRTools isn't the right tool for that at the moment (unless you want to contribute to making it so). If you plan on using the hardcalls, then we can make that work.

Hello,
Thank you for your answer. It's fine to use Beagle hardcalls for the task I have to do. I have to calculate the concordance between the imputed genotypes and the gangSTR called genotypes for the same samples. It's like comparing HipSTR vs gangSTR but this will be imputed hardcalls vs gangSTR. I'll appreciate your help.
~B

Well, it took much longer than desired, but TRTools now supports VCFs imputed by Beagle.
If you're still interested in that, read the short section of the docs here for a description of the script that you need to run on the Beagle VCF prior to using it with TRTools. Once that script is run, using Beagle with TRTools should be pretty seamless. Let us know if you have any issues, questions, or documentation suggestions!


Tests separate - old structure

Description
Please explain the changes you've made.
Type of change

This pull request fixes a bug in Radius and has an approved issue (issue link required).
This pull request adds or changes features of Radius and has an approved issue (issue link required).
This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #issue_number

Hi @vinayada1 - can you provide a description for this? What's changing in this PR and how can we review it?

Hi @vinayada1 - can you provide a description for this? What's changing in this PR and how can we review it?

Sorry meant to open this against my fork.


ari 3.0 - Prometheus metrics

Add prometheus metrics to the various parts of the ARI codebase.

A big thing is tracking when timeouts occur for #29

For the metrics that are simply counters of "how many times we did this", and that have the ability to fail or succeed, let's treat them as CounterVecs using labels for Success vs Fail.
To keep the code clean, I'd like to move as much of the metric decision-making out of the ari work function.  A simple Success/Fail would work this way:
At the point we want to record the metric, call a function that'll handle the decision-making for us
metricYesNo( "metricname", err )
The metricsYesNo() function then does any testing to determine the appropriate labeling, and logs the metric event:
if ( err != nil )
    increment "metricName" using label "Fail"
else
    increment "metricName" using label "Success"

Note to myself - need to look into mapping the destination metric to string.
And, since I'm using a string rather than hard-coded metric name like before, if it's trying to update a metric that doesn't exist, should we report it or simply debug or ?


put all queryable features in SupportsFeatureMixin

Purpose or Intent
The idea is to document the various features that are being gated by the SupportsFeatureMixin.
A list is maintained directly in the mixin.
This way, when a new feature is added to a class (via supports or supports_not) it would be validated against this list to make sure there's some explanation or documentation for the feature.  And, the feature documentation should have some description as to what is specifically gated by the feature.
props to @blomquisg for the idea and the wording :smile:
@blomquisg @Fryguy @jameswnl @chrisarcand @gauravaradhye thoughts?

@miq-bot add_labels wip, pluggable providers

Cool idea...I'd like to see where this goes.  I'm not sure about the mixing in at the ApplicationRecord level, but I can't really think of anything else.  One concern there is that migrations use ApplicationRecord (they probably shouldn't but some of them need the ar_region stuff, I think).

I'm not sure about the mixing in at the ApplicationRecord level

We can also add it to every "root" obj where it makes sense, np. It's probably better to make it more explicit

@miq-bot remove_label wip

@Fryguy I reduced this PR to just add the guard of features.
It's :green_apple: , so please merge at your discretion :smile:

@miq-bot add_label darga/no

@Fryguy @blomquisg ping, would you merge this?

This looks good to me, so going to merge.  I find the .send calls all over the place to be unnecessary, but that can be cleaned up separately.


RATIS-913. Fix remaining (new) checkstyle violations

What changes were proposed in this pull request?

Ignore violations in NativeIO-related classes, as these will be removed in RATIS-757.
Apply @dineshchitlangia's fix for PlatformUtils from aca98ffd3c94ca9e2f9c0798897631b726b381dd, which was lost between patches 001 and 002 in RATIS-740.
Fix few remaining violations.

https://issues.apache.org/jira/browse/RATIS-913
How was this patch tested?
$ ./dev-support/checks/checkstyle.sh
...
INFO] BUILD SUCCESS

https://github.com/adoroszlai/incubator-ratis/runs/629340756

Thanks @bshashikant for reviewing and merging this.


Create headers of functions/classes

We should create blank functions/classes with the expected input, documentation, and some unit tests for them. We can treat this as a skeleton to build on later. For example the stat functions we expect to use such as linear regression.

That sounds like a fantastic idea to me. It'll also be a nice way to slice up what needs to be implemented.

We have been doing this as far as I know. :3 I can add some more empty functions.

Please add more functions if required based on the package. We have some, others may be missing.


Noise and atmosphere simulations comparison

@keskitalo @cbischoff
Ok, I fixed the bugs in the noise and atmosphere scaling, now I believe the results are consistent.
I am using 177 microK * sqrt(s) for the white noise level both in T and P.
The spectra below are pseudospectra done with anafast, just corrected by the sky fraction, no mask deconvolution.
I scaled the input noise, the input atmosphere and the white noise level to the full experiment length so I could compare them all.

For SAT instead I have a large discrepancy:
SAT HFS1
I take the input cl for 10 days I multiply by:
(10 * simulations_efficiency / 8)

so I get noise for 1 tube and 1 day at 100% efficiency, and the full focal plane (8 is the thinning factor from the simulations).
Then I scale to 7 years at 20% efficiency and all tubes:
(7 * 365.25 * .2) / 4

For the white noise level instead:
net = 747.0 * u.uK * u.s ** .5
num_detectors_per_tube = 8438
num_tubes = 4
integration_time_per_detector_per_pixel = (7 * u.year * .2/num_hit_pixels).to(u.s)
integration_time_per_pixel= integration_time_per_detector_per_pixel*num_detectors_per_tube*num_tubes
std = net / np.sqrt(integration_time_per_pixel)
white_noise_cl = pixarea * std**2

and I get a white noise Cl of: 3.0707861e−19 K^2

@keskitalo any suggestion of what could be wrong?

Wow. Is that about a 3 orders of a magnitude difference? Has to be something obvious. We should start by estimating the single detector noise level from the simulated maps and see if it has anything to do with the value in the hardware map.

ok, I'll do that and post here

@keskitalo
full is: /global/cscratch1/sd/keskital/s4sim/reference_tool/out/00000000/pole_noise_SAT_HFS1_filtered_telescope_all_time_all_bmap.fits
std_per_pixel = np.sqrt(cl_full[1][500:].mean() / sky_fraction / pixarea)
0.0004924752646626618

which is consistent with:
full[1][full[1] != hp.UNSEEN].std()
0.0004347912651196421

then I get the integration_time_per_pixel I computed in the post above, which is: 7259059.1 s
std_per_pixel * np.sqrt(integration_time_per_pixel)
std_per_pixel * u.K * np.sqrt(integration_time_per_pixel)
1.3268584 K s ^ 0.5

instead of net = 747.0 * u.uK * u.s ** .5

I have the hitmap for your case evaluated here: /global/cscratch1/sd/keskital/s4sim/reference_tool/out2/00000000/pole_noise_SAT_HFS1_filtered_telescope_all_time_all_hmap.fits

what is the sample rate?

20Hz

ok, I think they are consistent:
hits.sum()/1e9
7.31

total_hits = 10 * u.d * simulations_efficiency * num_detectors_per_tube / 8 * (20 * u.Hz)
8.44e9

@keskitalo if I take wcov instead and I do:
std_wcov = np.sqrt(wcov[5] * hits)
Shouldn't I get the NET? np.median(std_wcov[std_wcov != 0]) is 0.0035

The hardware map has NET=747.0uK/sqrt(Hz). With your sigma=0.0035K_CMB I get NET=sigma/sqrt(fsample)=782.6uK. Seems perfectly consistent to me.

yes, right, hitmap and wcov are fine. It is the noise in the binned map which seems way too high, or I've messed up the calculations somewhere, I'll crosscheck again.

If I get C_ell of the noise from the wcov for the full sky, as:
wcov[3].mean()*pixarea
4.7e-14 K ^ 2

is consistent with:
cl_full[1][500:].mean()
6.33e-14 K ^ 2

from the DSR I have num_detectors_per_tube = 8438, where do I find the number of detectors in s4sim?

From /global/cscratch1/sd/keskital/s4sim/reference_tool/logs/pole_noise_SAT_HFS1.log it looks like there were 1076 detectors (line 129).

still something wrong, let's do without scaling, just the TOAST simulations:

White noise from TOAST wcov np.mean(wcov[wcov !=0]) * pixarea is 7.2e-13

The simulated noise, EE with anafast just corrected for the sky fraction is 9e-13

The issue is the estimate from NET which is 1e-15
  white_noise_cl_sims = pixarea * (747e-6)**2 / (
      10 * (24*3600) * 0.4629 * 1076 / num_hit_pixels
  )

Same using the hitmap 1.3e-15
  white_noise_cl_sims = pixarea * net**2 * (20 * u.Hz) / (
       hits[hits > 0].mean()
  )

I think I know what is going on. TOAST modulates the raw detector sensitivity with the observing elevation. Increased atmospheric loading at low observing elevation reduces sensitivity. The model is
NET(el) = (A / sin(el) + C) * NET(45)

and the hardware map values for the HFS1 band are
A = 0.30
C = 0.58

This gives the following curve:

From the Pole, lower Celestial latitude always means lower observing elevation so the raw NET estimate systematically underestimates the noise below 45 degrees:

This is only considering about 2/3 of the most hit pixels. If you consider all hit pixels, you find:

I am guessing that your power spectra are completely driven by those super noisy DEC > -30 pixels where the NET(45) underestimates the noise by as much as X40.
Anafast is clearly not suited for analyzing so unevenly distributed integration depth maps. At the very least, the noisiest pixels should be masked out.

thanks @keskitalo!
masking the 10% pixels with higher wcov and use median instead of mean to get the noise from wcov is enough to have a rough consistency check:

ok, I'll go ahead and run all the channels through


remove parts of docs about i64 limits applying to python ints

Change Summary
This removes the places where the docs still talk about ints being internally handled as i64s. As discussed in #6889 this isn't the case anymore. The "Pydantic V2 Plan" page also talks about it but I've left it as is since it's a historic page and not really part of the current docs.
Related issue number
fix #6889
Checklist

[X] The pull request title is a good summary of the changes - it will be used in the changelog
[X] Unit tests for the changes exist
[X] Tests pass on CI
[X] Documentation reflects the changes where applicable
[X] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Thanks @ImogenBits
I left a comment
Please update

updated with a better description


[SMALLFIX] LocalFilePacketReader fix

Limit the end of the local file reader to be the file length, otherwise the reader may read outside the file.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/16884/
Test PASSed.


bpf: remove cgrpid_tracker

There is an issue with the cgroup tracker id (details can be found below). This issue causes policyfilter to misbehave. Furthermore, the original intention behind the cgroup tracker id was never implemented and so it currently serves no purpose. Its only user is the policyfilter.
This patch removes the cgroup tracker id, and, instead, computes the cgroup id at the time of the policyfilter check. For most common setups (cgroupv2) the overhead of doing so is negligible. Computing the cgroup id at the time of check is more reliable and also simplifies the code.
More details can be found below.
We have a namespaced policy installed that mathes connect() calls to <IP_ADDRESS>, and execute the following on a pod in the same namespace:
kubectl exec -it nonqos-demo -- curl <IP_ADDRESS>
We observe two things:

there is no event from the policy (as we were expecting)
the cgroup tracker id of the curl process is the same as the parent runc process (which should not be the case)

The exec event we get from curl has:
.process.pid: 244958
.process.binary: /usr/bin/curl
.parent.pid: 244948
.parent.binary: /usr/bin/runc
Looking at the cgroup tracker id in the execve map for these two pids we see:
"cgrpid_tracker": 2371
"cgrpid_tracker": 2371
Which means that the cgroup id tracker is not correct, and the curl process will not be matched by the policy.
The issue might arise from the fact that in the wake_up_new_task(), computing the cgroup tracker id, uses get_current_cgroup_id(). We are, however, still in the parent so the get_current_cgroup_id() helper will return the cgroup of the parent, not of the child (which is what we want).
To simplify the code complexity (both from the perspective of understandabiliuty but also verification complexity), we instead remove the tracker id and retrieve the current cgroup id at the time of the check. This is much simpler, and not less efficient for the common case (cgroupv2).
Following the same steps with a version build with the current patch, produces an event as expected.

Nice lets go for correctness first and we can optimize later if perf ever is measurable.

btw @jrfastab, @kkourt usually those cases will fork and then migrate the tasks to the appropriate cgroup since they don't fork from pid 1 of container, so to catch those in bpf I planned this https://github.com/cilium/tetragon/blob/pr/tixxdz/cgroup-bpf-full/bpf/cgroup/bpf_cgroup_attach_task.c#L32  but due to lack of time...
There is also the new way of CLONE into new cgroup https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v6.6-rc5&id=ef2c41cf38a7559bbf91af42d5b6a4429db8fc68  , which I'm tracking in a separate clone+namespaces issue...
For this wake_up_new_task() even if we are passing the new task and fetching its cgroup (not the parent) but down the line if the fs uses a cgroupv2 then it switches back to cgroupv2 helpers which only work with current context...
Our own bpf cgroup helpers are far superior since they allows to work on target tasks https://github.com/cilium/tetragon/blob/main/bpf/lib/bpf_cgroup.h#L377 transparently for both cgroupv1 and cgroupv2, I should just have used this instead of upstream bpf helper...
Anyway thanks for fixing this, I plan to retake and finish it.