Strict equality is too strict in Scala 3.5

In Scala 3.5, assertEquals doesn't enable to compareSet of different types:
//> using dep org.scalameta::munit::1.0.1

class FooTest extends munit.FunSuite {
  test("foo") {
    assertEquals(Set(2: Any), Set(2))
  }
}

Compiling project (test, Scala 3.5.0, JVM (17))
[error] ./foo.test.scala:5:5
[error] Can't compare these two types:
[error]   First type:  Set[Any]
[error]   Second type: Set[Int]
[error] Possible ways to fix this error:
[error]   Alternative 1: provide an implicit instance for Compare[Set[Any], Set[Int]]
[error]   Alternative 2: upcast either type into `Any` or a shared supertype.
[error] I found:
[error]
[error]     munit.Compare.compareSubtypeWithSupertype[Set[Any], Set[Int]](
[error]       /* missing */summon[Set[Any] <:< Set[Int]])
[error]
[error] But no implicit values were found that match type Set[Any] <:< Set[Int].
[error]     assertEquals(Set(2: Any), Set(2))
[error]     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[[syntax trees at end of                     typer]] // /Users/mbovel/munit-bug/foo.test.scala
package <empty> {
  class FooTest() extends munit.FunSuite() {
    this.test("foo")(
      {
        {
          val obtained$1: Set[Any] = Set.apply[Any]([2:Any : Any]*)
          val expected$1: Set[Int] = Set.apply[Int]([2 : Int]*)
          def clue$1: String = this.assertEquals$default$3[Set[Any], Set[Int]]
          this.assertEquals[Set[Any], Set[Int]](obtained$1, expected$1, clue$1)(
            loc = munit.Location.generate,
            munit.Compare.compareSubtypeWithSupertype[Set[Any], Set[Int]](
              /* missing */summon[Set[Any] <:< Set[Int]])
          )
        }
      }
    )
  }
}

Error compiling project (test, Scala 3.5.0, JVM (17))
Compilation failed

This is because in 3.5, the B type parameter of assertEquals is inferred to be Set[Int] instead of Set[Any] as in 3.3
assertEquals's signature:
https://github.com/scalameta/munit/blob/b02ef31983df653014ab22244f1815cb9d066fb5/munit/shared/src/main/scala/munit/Assertions.scala#L91-L95
Instances of Compare are defined as:
https://github.com/scalameta/munit/blob/b02ef31983df653014ab22244f1815cb9d066fb5/munit/shared/src/main/scala/munit/Compare.scala#L104-L108
https://github.com/scalameta/munit/blob/b02ef31983df653014ab22244f1815cb9d066fb5/munit/shared/src/main/scala/munit/Compare.scala#L116-L120

Thanks for reporting! Isn't this expected though? I don't the exact background behind strictEquality, but since Set is invariant I would assume sets of different types are indeed not comparable.
If needed we can include the proposed fix, but I am not sure about what cases the current behaviour would be problematic in.

Isn't this expected though?

That depends on your expectations of type inference.

Before we would infer the type parameter of the second set to also be Any since that is the only instantiation for which an implicit value of type Compare could be found.
Now we first instantiate the type variable of the second set to be Int (as we would if it was val binded) and then proceed  with implicit search. In the above example, the change in inference causes a new error. In other cases, the earlier instantiation can in contrary reduce the possible ambiguities in the implicit search.

on the other hand let's say Set[Animal] and Set[Bird] -> I might have some birds in the animal set so we would be all good

Yeah, that's similar to our use-case. I find it reasonable to want to test the return value of method whose return type is defined in terms of an interface (as foo in the following example) by comparing the return value with a concrete instance.
That said, it's worth noting that the current MUnit behavior is in line with Scala's strict equality, so that might be okay.
//> using dep org.scalameta::munit::1.0.1

trait Interface
case class Impl() extends Interface

def foo(): Set[Interface] = Set(Impl())

class FooTest extends munit.FunSuite:
  val s = Set(2)

  test("foo (normal equality)"):
    assert(foo() == Set(Impl())) // Works in Scala 3.3 and 3.5

  test("foo (strict equality)"):
    import scala.language.strictEquality
    assert(foo() == Set(Impl())) // Fails in Scala 3.3 and 3.5

  test("foo (assertEquals)"):
    assertEquals(foo(), Set(Impl())) // Works in Scala 3.3, fails in Scala 3.5

Wait, seeing that there is an CanEqual.canEqualSet defined in the standard library, that might actually be bug!

In case there is a special type class for Scala itself, we could do the same, which would allow us not to change interfaces :thinking:


Update CoC link for Matplotlib.

Addresses comment of @tacaswell on gh-257

Okay, merging in order not to leave the incorrect/incomplete info on the site for too long.


Split apart Action types.

InstallPlanAction
~RemovePlanAction~
AlreadyInstalledAction
~NotInstalledAction~
ExportPlanAction

(with some common base types)

This has been wedged for 6 months so I'm going to close it. Please feel to reopen or make a new PR if you wish to bring it back.


Don't panic!

As seen in #63 there're code paths which can lead to a panic! rather than an orderly error handling and reflection in an appropriate error code. Let's fix those!

I looked over the code (as of the changes in the PR https://github.com/rust-embedded/cargo-binutils/pull/74) to see what code can panic and as far as I can see the only places that can panic would be due to a change in the build-cache structure or other abnormal issues caused by cargo or the OS. So I think its safe to close this issue.

https://github.com/rust-embedded/cargo-binutils/blob/8a6da67d395474832fea3b6cc620c6984529206c/src/lib.rs#L69-L71
Should only be possible if the build-cache structure changed.

https://github.com/rust-embedded/cargo-binutils/blob/8a6da67d395474832fea3b6cc620c6984529206c/src/lib.rs#L355-L357
Could only be possible if artifact.executable somehow pointed to the root / which would mean cargo gave us invalid data.

Indeed this looks a lot better now than back in April. Happy to close this off now.


[Bug - Horizontal] Perfectly functional timelines, but countless notifications of "no date found for ___.md" (for each event), everytime I open the timeline note.

First I want to thank you so much for this plugin, you saved my life,
I absolutely love this, is the best timeline plugin that exists, I use everyday, for basically everything.
And before you, I was having to use some old version of obsidian, only to not lose the Darakah's functioning timeline (that stopped working on the updates of obsidian). Thanks to you, now I can use the updated version of obsidian, and still be able to use timelines
But does exist any way to make those notifications not appear everytime I open a timeline note? Or is it normal?

I tried to check, if I writed something wrong (despite all the timelines appearing and functioning perfectly... On the perfect dates I set...) I tought that maybe I was writing the dates wrong somehow, maybe something related to the dates was missing... I tried including the hours... Tried including other optional sections that I've seen across the tutorials, in those event notes...
But I couldn't find anything that I did, that was wrong comparing to the tutorials... And the notifications persist...

And this happens with all event notes... It doesnt matter if they are "range", or "dot"...
Is it a bug, or am I doing something wrong?
Sorry for the broke english 🇧🇷
Thanks in advance

Hey, thanks for creating an issue. It's interesting that it's giving you that notice for Agosto de 2024.md because the event looks correct and the only time I create a Notice is when there is no start date, as in if someone accidentally deleted it or left it blank, etc. And your event clearly has a start date...
Out of curiosity, what does your timeline block look like?

How interesting!
I recreated your note to see if I could recreate it, and sure enough!
I get this error in the console:
{
  event: {
    tags: "timeline, goals"
  },
  eventData: null
}

My first guess is that I'm not handling the tags string correctly and therefore it gets wonky. I'll look into it!

This has been fixed in release 2.2.2

Damn, it worked perfectly!!
Thank you so much!!!!


FLEX-2915 Removes NewOrganisationIdentification

This pull request makes the build fail.

SonarQube analysis reported 7 issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 DeviceManagementEndpoint.java#L310: Remove this unused method parameter "request".
 DeviceManagementEndpoint.java#L424: Remove this unused method parameter "request".
 DeviceManagementEndpoint.java#L155: Define a constant instead of duplicating this literal "Exception: {}, StackTrace: {}" 3 times.
 DeviceManagementService.java#L442: Complete the task associated to this TODO comment.
 DeviceManagementService.java#L591: Complete the task associated to this TODO comment.
 DeviceManagementEndpoint.java#L375: Complete the task associated to this TODO comment.
 DeviceManagementEndpoint.java#L398: Complete the task associated to this TODO comment.

All is well.


Could u add features use percentage of available balance and add password protection to account_id?

Lets say risk 5% of available balance in account.
Password protect webhook post message like account_id + password ETH/USDT buy 500$ x125

Yes. I was planning to add orders by percentage of balance. I'll do it one of these days.
I'm not sure what security value would add having a password in the alert. Both the account name and the alert would be in the same place. If someone finds one he would also find the other. Or am I missing something?
It's not hard to add at all. I just don't figure out the situation where it would be really needed.

Leave the password question I noticed setting up a account is with 14 + characters should be safe enough. 7tRtilcaC85Is5335B almost uncrackable!
looking forward to the balance order type

Orders by percentage of balance are up.

Sweet I’m gonna make a docker image for this. So I can scale this with Kubernetes and loadbalance it properly!


Transaction calls are not returning the result with version 20.12

Team:
Thank you for your massive work on providing the SDK.
TestTransaction.txt
We have been using the Java SDK for Avatax. We wanted to upgrade from version 20.10 to 20.12
But we are facing the following issue
The transactions are getting created in the Avalara side, but SDK does not get the result of the REST call from Avalara side. Till Version 20.10 we never faced this issue. From my Analysis In the code RestCall.java line 152 is false and so TransactionModel is not getting returned.
I am attaching the test code:
Please replace the Username, Password and Avalara Company Code in the code.
Thank you for all your help.
Krishna

Hi @krishnaswami-rajagopalan ,
We are looking into the issue and able to reproduce it. The fix will be deployed as part of next release.
Thanks,
Sachin

Hi @krishnaswami-rajagopalan ,
The issue reported is fixed and released (version: 21.12.1); please verify and let us know if you have any observation.
Thanks,
Sachin

@avasachinbaijal Thank you for the quick response. I will check and give my feedback.
Krishnaswami
from SmartERP

@avasachinbaijal It is working. I tested the code that I had attached and could get the results. We will test all the processes such and get back to you.


Rewrite relocation to be compliant with P1144

Relocation now mostly follows the API proposed in P1144. Parlay will also defer the implementation of relocation operations to the compiler/library if they are present, which currently works on Arthur O'Dwyer's LLVM fork here.

Codecov Report
Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9e60787) 96.91% compared to head (237f69c) 96.69%.
Report is 1 commits behind head on master.

Files
Patch %
Lines

include/parlay/internal/integer_sort.h
66.66%
2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
- Coverage   96.91%   96.69%   -0.23%
==========================================
  Files          56       57       +1
  Lines        3701     3724      +23
==========================================
+ Hits         3587     3601      +14
- Misses        114      123       +9

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@DanielLiamAnderson belated ping! The deadline for P1144R10 is early on February 15th — any chance this PR could be merged by then?

Oops, yes, I'll try!  I just want to finish a little more testing but I'll see if I can do that asap.


FALLBACK_PTRS is hardcoded to 9

Is your design request related to a problem? Please describe.
It causes confusion and errors when setting up new render tasks

This variable shouldn't have a reason to exist anymore. But I'm not 100% sure.

Still exists because of the createinstancesfortlas function. removing this is going to be a bit annoying. Hopefully soon we can remove fallback.


Fix HOMEBREW_BUNDLE_WHALEBREW_SKIP

[x] Add test to ensure the skipper reads the HOMEBREW_BUNDLE_WHALEBREW_SKIP environment variable
[x] Fix the skipper to actually read from the HOMEBREW_BUNDLE_WHALEBREW_SKIP environment variable

Thanks again @jarrodldavis!


[Improve] Improve streampark-test-utils module based on [6 Testing]

Search before asking

[X] I had searched in the feature and found no similar feature requirement.

Description
[Improve] Improve streampark-test-utils module based on 6 Testing
Usage Scenario
No response
Related issues
#2986
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

This module is not missing the testing cases


Single quote in the title is replaced by the encoded html version

I have a sample document like this:
Foo's bar
------------

when rendered the title shows up as Foo’s bar

This is with Chrome 48.0.2564.109 on Linux x86-64.

Hello @ismail
Indeed I can reproduce this issue. Not sure what I'm doing wrong, I'm using doctitle method from Asciidoctor core: https://github.com/asciidoctor/asciidoctor-chrome-extension/blob/master/app/js/renderer.js#L80
asciidoctorDocument.$doctitle(Opal.hash({sanitize: true}))
"Foo’s bar"

asciidoctorDocument.$doctitle()
"Foo’s bar"
```

I can decode HTML entities with:
```javascript
var doctitle = asciidoctorDocument.$doctitle(Opal.hash({sanitize: true}));
document.title = $("<div />").html(doctitle).text();
```
@mojavelinux What do you think ?

Any chance of getting this fix integrated soon?

This is on my list. I'll look into it asap. I have a strong hunch about what needs to happen.

Correct, this is currently a missing feature in the doctitle function. We need to make sanitize an enum that accepts various types of sanitization (:cdata, :plain, etc). (See https://github.com/asciidoctor/asciidoctor/blob/master/lib/asciidoctor/document.rb#L629)
What I recommend is to not use the sanitize flag and instead use jQuery or the DOM to strip HTML elements and decode/resolve entities.
var doctitle = asciidoctorDocument.$doctitle();
var filter = document.createElement('div');
filter.innerHTML = doctitle;
document.title = filter.textContent;

That's going to give you perfect results.

PR sent.

:+1:

Thanks!


Correct management api usage example

Motivation
Which issue does this fix? Fixes #issue number
If no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?
Checklist

[ ] Code follows coding conventions held in this repo
[ ] Automated tests have been added
[ ] Tests are passing
[x] Docs have been updated (if applicable)
[ ] Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test
If manual testing is required, what are the steps?

Nice catch, thank you :)


Fixes alt attributes

The alt attribute should be an textual alternative to the image, not a description of the image.

Fixes #53.

One note above. Otherwise, after resolving the conflicts, this looks good.

Spaces removed.

Thanks. Branch conflicts still need to be resolved before we can merge.

@btrem No worries! Basically after I merged the other PRs, branch fix_alt_attr conflicted with the latest main branch here.
I think what you'd want to do in your forked repository is:

pull the latest from main branch of this repo ("upstream") https://github.com/microformats/microformats.io
merge those commits int into your fork's main branch
switch to branch fix_alt_attr
run git rebase, which should replay the commits in fix_alt_attr on top of main
push fix_alt_attr and it should appear here without conflicts

If that doesn't work, it looks like github might let me manually fix it in the web editor, but I haven't tried that out yet.

@gRegorLove nothing I do seems to resolve this. I don't know why. The code that is in the merge conflict in the github web editor does not appear in branch. I also tried to fix it in that editor, but the changes were not saved (probably because I don't have the necessary permissions).

Screw it. I gave up and created a new branch/PR #58.  :-/


Handle Docker Compose files as YAML

Sort Everything is capable of sorting Docker Compose files when the filetype is set to YAML, would it be possible to add this as a default?

Have created a PR: https://github.com/bennycode/sort-everything/pull/15

Thanks for making the PR! With which filenames have you tested it? When using docker-compose.yaml it was working for me already as it is. Can you confirm that textEditor.document.languageId really returns dockercompose?

Have tested and this has been working, any chance to merge?

Yes, I will merge it and make a new release. Thank you very much for your contribution. 🥳

Thank you 🤩

Great, I released it with v1.4.1 🚀


[BUG] SetFilters function in useTable hook not sync with url properly

Describe the bug
setFilters function in useTable hook not working properly. When you set filters like this
let filters: CrudFilters = [];
setFilters(filters, "replace");

The page URL did not change. In app.tsx, I pass the "true" parameter via syncWithLocation.
To Reproduce
Steps to reproduce the behavior:

Go to 'App.tsx' and pass "true" value to "syncWithLocation" parameter.
Then use 'useTable' hook and get 'setFilters' function.
First use 'setFilters' function to real filter. Then call it with empty array.
See error

Expected behavior
The page URL changes with filters.
Screenshots

Videos
https://user-images.githubusercontent.com/24412394/188372981-037b92a7-ffa0-4ce7-966c-4cffdf108197.mp4
Desktop (please complete the following information):

OS: Windows 11
Browser: chrome
Refine Version: 3.56.11
Used dataProvider: custom

Hey @mustafaulukaya ,
We've released<EMAIL_ADDRESS>Could you approve this fix?

Hey,
The bug was successfully fixed. Thank you and your team. Have a great day!


feat: add new exchange UI

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Also this PR should not go to master branch but to new-origin-integration

Please merge to preview branch


Add andytinkham & itsbrugu to conjur-credentials-plugin developers

Signed-off-by: Andy Tinkham<EMAIL_ADDRESS>
Description

Add Jenkins users andytinkham and itsbrugu (github users: @andytinkham and @itsbrugu) to developers for https://github.com/jenkinsci/conjur-credentials-plugin. We will need merge access to the repo, please. (Tag: @cyberark-bizdev for confirmation)
Submitter checklist for adding or changing permissions

Always

[X] Add link to plugin/component Git repository in description above

For a newly hosted plugin only

[ ] Add link to resolved HOSTING issue in description above

For a new permissions file only

[ ] Make sure the file is created in permissions/ directory
[ ] artifactId (pom.xml) is used for name (permissions YAML file).
[ ] groupId / artifactId (pom.xml) are correctly represented in path (permissions YAML file)
[ ] Check that the file is named plugin-${artifactId}.yml for plugins

When adding new uploaders (this includes newly created permissions files)

[X] Make sure to @mention an existing maintainer to confirm the permissions request, if applicable
[X] Use the Jenkins community (LDAP) account name in the YAML file, not the GitHub account name
[X] Make sure to @mention the users being added so their GitHub account names are known if they require GitHub merge access (see below).
[X] All newly added users have logged in to Artifactory at least once

Reviewer checklist (not for requesters!)

[ ] Check this if newly added person also needs to be given merge permission to the GitHub repo (please @ the people/person with their GitHub username in this issue as well). If needed, it can be done using an IRC Bot command
[ ] Check that the $pluginId Developers team has Admin permissions while granting the access.
[ ] In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
[ ] If security contacts are changed (this includes add/remove), ping the security officer (currently @Wadeck) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it

I'm not sure why the Validation step says I need to log into artifactory. I did that just prior to submitting the PR... Is there something I missed?

I don't need 4 additional mails 🥴
We (the hosting team) can trigger builds ourselves too.

I don't need 4 additional mails 🥴
We (the hosting team) can trigger builds ourselves too.

Sorry - the Details for the Validation says to Close and reopen the PR.  The Validation check is still failing though. I have logged in to Artifactory, however.

It can take up to an hour for people to show up in https://reports.jenkins.io/artifactory-ldap-users-report.json

Oh, I see it's hourly rebuild. OK - I'll trigger the rebuild in an hour.

where are you seeing hourly rebuild?

where are you seeing hourly rebuild?

I meant "refresh", and it's in the Details for the Validation as well.

It can take up to an hour for people to show up in https://reports.jenkins.io/artifactory-ldap-users-report.json

It was over 2 hours ago when I logged in, and I do show up in that json.

Oh, I see I need to get Brugu to log into Jira now. There wasn't anything about that in the PR template.

I submitted a PR for updating the instructions: https://github.com/jenkins-infra/repository-permissions-updater/pull/2894

Brugu tells me he has now signed in to Jira, so please trigger a rebuild. Thanks!

Brugu tells me he has now signed in to Jira, so please trigger a rebuild. Thanks!

Looks all good, all this PR needs is approval by the maintainer you mentioned.

I've pinged him internally as well. Hopefully, he'll approve it soon. Thanks for all the help & guidance & patience on this!

approve


HADOOP-18469: centralise XML parser creation in XMLUtils

Description of PR
How was this patch tested?
For code changes:

[x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@steveloughran I can rework this to just have the hadoop-common changes and can do other PRs to uptake this in yarn, hdfs, etc.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 40s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 32 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 46s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
25m 48s

trunk passed

+1 :green_heart:
compile
23m 39s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
20m 50s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
4m 20s

trunk passed

+1 :green_heart:
mvnsite
12m 58s

trunk passed

+1 :green_heart:
javadoc
10m 54s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
10m 16s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
19m 48s

trunk passed

+1 :green_heart:
shadedclient
24m 40s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 31s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
7m 31s

the patch passed

+1 :green_heart:
compile
22m 49s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
22m 49s

the patch passed

+1 :green_heart:
compile
21m  7s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
21m  7s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
4m 15s

root: The patch generated 0 new + 327 unchanged - 2 fixed = 327 total (was 329)

+1 :green_heart:
mvnsite
13m  7s

the patch passed

+1 :green_heart:
javadoc
11m 19s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
10m 49s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
21m  4s

the patch passed

+1 :green_heart:
shadedclient
21m 31s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
18m 38s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

+1 :green_heart:
unit
3m 11s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
244m  3s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
unit
100m 29s

hadoop-yarn-server-resourcemanager in the patch passed.

-1 :x:
unit
25m  1s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
hadoop-yarn-server-nodemanager in the patch passed.

+1 :green_heart:
unit
7m 51s

hadoop-mapreduce-client-core in the patch passed.

+1 :green_heart:
unit
9m 27s

hadoop-mapreduce-client-app in the patch passed.

-1 :x:
unit
1m 47s
/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-hs.txt
hadoop-mapreduce-client-hs in the patch failed.

-1 :x:
unit
1m 19s
/patch-unit-hadoop-tools_hadoop-rumen.txt
hadoop-rumen in the patch failed.

+1 :green_heart:
asflicense
1m 30s

The patch does not generate ASF License warnings.

723m 45s

Reason
Tests

Failed junit tests
hadoop.cli.TestCLI

hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer

hadoop.cli.TestAclCLI

hadoop.hdfs.TestEncryptionZonesWithKMS

hadoop.cli.TestHDFSCLI

hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForAcl

hadoop.cli.TestErasureCodingCLI

hadoop.cli.TestCryptoAdminCLI

hadoop.cli.TestCacheAdminCLI

hadoop.hdfs.TestEncryptionZones

hadoop.cli.TestXAttrCLI

hadoop.cli.TestAclCLIWithPosixAclInheritance

hadoop.cli.TestDeleteCLI

hadoop.yarn.server.nodemanager.webapp.dao.gpu.TestGpuDeviceInformationParser

hadoop.yarn.server.nodemanager.containermanager.resourceplugin.gpu.TestGpuDiscoverer

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4940/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4940

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 40fec3ac9dce 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 17f57cfa940e9827f24e460f4cf3a3efe2ab6d7c

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4940/1/testReport/

Max. process+thread count
3447 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-tools/hadoop-rumen U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4940/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 48s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 32 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 44s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
29m 51s

trunk passed

+1 :green_heart:
compile
27m  3s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
23m 24s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
4m 56s

trunk passed

+1 :green_heart:
mvnsite
13m 47s

trunk passed

+1 :green_heart:
javadoc
11m 21s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
10m 52s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
20m 46s

trunk passed

+1 :green_heart:
shadedclient
22m 11s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 30s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
7m 47s

the patch passed

+1 :green_heart:
compile
24m 54s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
24m 54s

the patch passed

+1 :green_heart:
compile
22m  2s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
22m  2s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
4m  8s

root: The patch generated 0 new + 327 unchanged - 2 fixed = 327 total (was 329)

+1 :green_heart:
mvnsite
13m 25s

the patch passed

+1 :green_heart:
javadoc
10m 20s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
10m 13s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
22m 46s

the patch passed

+1 :green_heart:
shadedclient
21m 30s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
18m 42s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

+1 :green_heart:
unit
3m  0s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
238m 36s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
unit
99m 10s

hadoop-yarn-server-resourcemanager in the patch passed.

-1 :x:
unit
24m 34s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
hadoop-yarn-server-nodemanager in the patch passed.

+1 :green_heart:
unit
7m 46s

hadoop-mapreduce-client-core in the patch passed.

+1 :green_heart:
unit
9m 27s

hadoop-mapreduce-client-app in the patch passed.

+1 :green_heart:
unit
5m 32s

hadoop-mapreduce-client-hs in the patch passed.

+1 :green_heart:
unit
1m 12s

hadoop-rumen in the patch passed.

+1 :green_heart:
asflicense
1m 42s

The patch does not generate ASF License warnings.

735m  0s

Reason
Tests

Failed junit tests
hadoop.cli.TestCLI

hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer

hadoop.cli.TestAclCLI

hadoop.hdfs.TestEncryptionZonesWithKMS

hadoop.cli.TestHDFSCLI

hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForAcl

hadoop.cli.TestErasureCodingCLI

hadoop.cli.TestCryptoAdminCLI

hadoop.cli.TestCacheAdminCLI

hadoop.hdfs.TestEncryptionZones

hadoop.cli.TestXAttrCLI

hadoop.cli.TestAclCLIWithPosixAclInheritance

hadoop.cli.TestDeleteCLI

hadoop.yarn.server.nodemanager.webapp.dao.gpu.TestGpuDeviceInformationParser

hadoop.yarn.server.nodemanager.containermanager.resourceplugin.gpu.TestGpuDiscoverer

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4940/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4940

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux a05528c9ecf7 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / fff1369d995a96ac4881d5b7516f6e54569b26ae

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4940/2/testReport/

Max. process+thread count
3250 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-tools/hadoop-rumen U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4940/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 39s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 32 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 55s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
27m 17s

trunk passed

+1 :green_heart:
compile
26m 29s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
23m 40s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
4m 20s

trunk passed

+1 :green_heart:
mvnsite
12m 49s

trunk passed

+1 :green_heart:
javadoc
10m 52s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
10m 57s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
21m 17s

trunk passed

+1 :green_heart:
shadedclient
21m 48s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 31s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
7m 33s

the patch passed

+1 :green_heart:
compile
25m 40s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
25m 40s

the patch passed

+1 :green_heart:
compile
23m 17s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
23m 17s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
4m 27s

root: The patch generated 0 new + 327 unchanged - 2 fixed = 327 total (was 329)

+1 :green_heart:
mvnsite
13m 28s

the patch passed

+1 :green_heart:
javadoc
10m 27s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
11m 18s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
23m 24s

the patch passed

+1 :green_heart:
shadedclient
21m 52s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
19m 12s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

+1 :green_heart:
unit
3m  7s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
249m 14s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
unit
99m 11s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
unit
25m 15s

hadoop-yarn-server-nodemanager in the patch passed.

+1 :green_heart:
unit
7m 51s

hadoop-mapreduce-client-core in the patch passed.

+1 :green_heart:
unit
9m 34s

hadoop-mapreduce-client-app in the patch passed.

+1 :green_heart:
unit
5m 24s

hadoop-mapreduce-client-hs in the patch passed.

+1 :green_heart:
unit
1m 22s

hadoop-rumen in the patch passed.

+1 :green_heart:
asflicense
1m 32s

The patch does not generate ASF License warnings.

746m  3s

Reason
Tests

Failed junit tests
hadoop.cli.TestCLI

hadoop.cli.TestHDFSCLI

hadoop.cli.TestCacheAdminCLI

hadoop.cli.TestXAttrCLI

hadoop.cli.TestAclCLI

hadoop.cli.TestErasureCodingCLI

hadoop.cli.TestDeleteCLI

hadoop.cli.TestCryptoAdminCLI

hadoop.cli.TestAclCLIWithPosixAclInheritance

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4940/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4940

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 71639cc71038 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / f5d0221d60df1a4697c547b8248d81da20dce2fd

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4940/3/testReport/

Max. process+thread count
2833 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-tools/hadoop-rumen U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4940/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 40s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 32 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 49s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
27m  5s

trunk passed

+1 :green_heart:
compile
26m 33s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
23m 33s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
4m 33s

trunk passed

+1 :green_heart:
mvnsite
13m 32s

trunk passed

+1 :green_heart:
javadoc
10m 59s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
10m 33s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
21m  3s

trunk passed

+1 :green_heart:
shadedclient
21m 47s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 29s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
7m 47s

the patch passed

+1 :green_heart:
compile
25m 52s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
25m 52s

the patch passed

+1 :green_heart:
compile
23m 27s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
23m 27s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
4m 19s

root: The patch generated 0 new + 328 unchanged - 1 fixed = 328 total (was 329)

+1 :green_heart:
mvnsite
13m 41s

the patch passed

+1 :green_heart:
javadoc
10m 46s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
11m 33s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
23m  5s

the patch passed

+1 :green_heart:
shadedclient
22m  3s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
19m  1s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

+1 :green_heart:
unit
3m  8s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
252m  1s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
unit
99m 32s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
unit
24m 35s

hadoop-yarn-server-nodemanager in the patch passed.

+1 :green_heart:
unit
7m 46s

hadoop-mapreduce-client-core in the patch passed.

+1 :green_heart:
unit
9m 31s

hadoop-mapreduce-client-app in the patch passed.

+1 :green_heart:
unit
5m  9s

hadoop-mapreduce-client-hs in the patch passed.

+1 :green_heart:
unit
1m 17s

hadoop-rumen in the patch passed.

+1 :green_heart:
asflicense
1m 35s

The patch does not generate ASF License warnings.

748m 57s

Reason
Tests

Failed junit tests
hadoop.cli.TestCLI

hadoop.cli.TestHDFSCLI

hadoop.cli.TestCacheAdminCLI

hadoop.cli.TestXAttrCLI

hadoop.cli.TestAclCLI

hadoop.cli.TestErasureCodingCLI

hadoop.cli.TestDeleteCLI

hadoop.cli.TestCryptoAdminCLI

hadoop.cli.TestAclCLIWithPosixAclInheritance

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4940/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4940

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 0defe4bdbba3 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 095970c436451d5fb2b0615306c4eb54a0720d3a

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4940/4/testReport/

Max. process+thread count
3335 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-tools/hadoop-rumen U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4940/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 39s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 33 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 45s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
25m 46s

trunk passed

+1 :green_heart:
compile
23m 26s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
20m 51s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
4m  3s

trunk passed

+1 :green_heart:
mvnsite
13m 26s

trunk passed

+1 :green_heart:
javadoc
10m 58s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
10m 20s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
19m 58s

trunk passed

+1 :green_heart:
shadedclient
21m 26s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 30s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
7m 27s

the patch passed

+1 :green_heart:
compile
23m 59s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
23m 59s

the patch passed

+1 :green_heart:
compile
21m 40s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
21m 40s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
5m 38s
/results-checkstyle-root.txt
root: The patch generated 9 new + 328 unchanged - 1 fixed = 337 total (was 329)

+1 :green_heart:
mvnsite
12m 55s

the patch passed

+1 :green_heart:
javadoc
9m 29s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
10m 19s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
21m 32s

the patch passed

+1 :green_heart:
shadedclient
24m  3s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
19m 41s

hadoop-common in the patch passed.

+1 :green_heart:
unit
3m  4s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
251m 55s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
unit
99m 14s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
unit
24m 27s

hadoop-yarn-server-nodemanager in the patch passed.

+1 :green_heart:
unit
7m 40s

hadoop-mapreduce-client-core in the patch passed.

+1 :green_heart:
unit
9m 26s

hadoop-mapreduce-client-app in the patch passed.

+1 :green_heart:
unit
5m 12s

hadoop-mapreduce-client-hs in the patch passed.

+1 :green_heart:
unit
1m 39s

hadoop-rumen in the patch passed.

+1 :green_heart:
asflicense
1m 36s

The patch does not generate ASF License warnings.

734m 23s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestRollingUpgrade

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4940/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4940

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux ef0fe259e6fa 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 2cd117a523bd44ae44083f4fe34531c75e5102d5

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4940/5/testReport/

Max. process+thread count
3159 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-tools/hadoop-rumen U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4940/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 50s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  2s

codespell was not available.

+0 :ok:
detsecrets
0m  2s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 33 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 56s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
25m 57s

trunk passed

+1 :green_heart:
compile
24m 28s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
25m 17s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
5m 31s

trunk passed

+1 :green_heart:
mvnsite
15m 35s

trunk passed

+1 :green_heart:
javadoc
12m 48s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
10m 56s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

-1 :x:
spotbugs
2m  7s
/branch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
hadoop-yarn-server-nodemanager in trunk failed.

-1 :x:
spotbugs
1m  6s
/branch-spotbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
hadoop-mapreduce-client-core in trunk failed.

-1 :x:
spotbugs
1m  6s
/branch-spotbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt
hadoop-mapreduce-client-app in trunk failed.

-1 :x:
spotbugs
1m  8s
/branch-spotbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-hs.txt
hadoop-mapreduce-client-hs in trunk failed.

+1 :green_heart:
shadedclient
27m 26s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 30s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
7m 41s

the patch passed

+1 :green_heart:
compile
22m 39s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
22m 39s

the patch passed

+1 :green_heart:
compile
21m  8s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
21m  9s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
4m 34s
/results-checkstyle-root.txt
root: The patch generated 27 new + 436 unchanged - 1 fixed = 463 total (was 437)

+1 :green_heart:
mvnsite
13m 22s

the patch passed

+1 :green_heart:
javadoc
11m 11s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
10m 55s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
21m 55s

the patch passed

+1 :green_heart:
shadedclient
21m 49s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 45s

hadoop-common in the patch passed.

+1 :green_heart:
unit
3m  5s

hadoop-hdfs-client in the patch passed.

+1 :green_heart:
unit
240m  7s

hadoop-hdfs in the patch passed.

+1 :green_heart:
unit
99m 25s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
unit
24m 43s

hadoop-yarn-server-nodemanager in the patch passed.

+1 :green_heart:
unit
7m 44s

hadoop-mapreduce-client-core in the patch passed.

+1 :green_heart:
unit
9m 26s

hadoop-mapreduce-client-app in the patch passed.

+1 :green_heart:
unit
5m 12s

hadoop-mapreduce-client-hs in the patch passed.

+1 :green_heart:
unit
1m 28s

hadoop-rumen in the patch passed.

+1 :green_heart:
asflicense
1m 43s

The patch does not generate ASF License warnings.

739m 54s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4940/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4940

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 5cac9e38c6e3 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / d8dd8eba3e187ae02ca371c597fe0570463941fe

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4940/6/testReport/

Max. process+thread count
3127 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-tools/hadoop-rumen U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4940/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 49s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 33 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 50s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
25m 55s

trunk passed

+1 :green_heart:
compile
23m 20s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
20m 59s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
4m 20s

trunk passed

+1 :green_heart:
mvnsite
13m 19s

trunk passed

+1 :green_heart:
javadoc
11m  7s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
10m 34s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
19m 53s

trunk passed

+1 :green_heart:
shadedclient
21m 31s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
7m 44s

the patch passed

+1 :green_heart:
compile
22m 43s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
22m 43s

the patch passed

+1 :green_heart:
compile
20m 45s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
20m 45s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
4m  0s

root: The patch generated 0 new + 436 unchanged - 1 fixed = 436 total (was 437)

+1 :green_heart:
mvnsite
13m 12s

the patch passed

+1 :green_heart:
javadoc
10m 44s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
10m 45s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
22m  9s

the patch passed

+1 :green_heart:
shadedclient
21m 38s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 37s

hadoop-common in the patch passed.

+1 :green_heart:
unit
3m  7s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
309m 41s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
unit
99m 21s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
unit
24m 34s

hadoop-yarn-server-nodemanager in the patch passed.

+1 :green_heart:
unit
7m 39s

hadoop-mapreduce-client-core in the patch passed.

+1 :green_heart:
unit
9m 22s

hadoop-mapreduce-client-app in the patch passed.

+1 :green_heart:
unit
5m 33s

hadoop-mapreduce-client-hs in the patch passed.

+1 :green_heart:
unit
1m 23s

hadoop-rumen in the patch passed.

+1 :green_heart:
asflicense
1m 37s

The patch does not generate ASF License warnings.

789m  6s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.TestBatchIbr

hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped

hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting

hadoop.hdfs.server.datanode.TestDataNodeErasureCodingMetrics

hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure

hadoop.hdfs.server.datanode.TestDataNodeVolumeMetrics

hadoop.hdfs.server.balancer.TestBalancerRPCDelay

hadoop.hdfs.server.blockmanagement.TestReconstructStripedBlocksWithRackAwareness

hadoop.hdfs.server.datanode.TestDiskError

hadoop.hdfs.server.blockmanagement.TestBlocksWithNotEnoughRacks

hadoop.hdfs.server.mover.TestMover

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4940/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4940

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux aff3310d094d 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e62c46888f327b7214cfd7094cfee7afed64a751

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4940/7/testReport/

Max. process+thread count
3142 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-tools/hadoop-rumen U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4940/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 39s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 50s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
26m  6s

trunk passed

+1 :green_heart:
compile
23m 20s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
21m  5s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
4m  8s

trunk passed

+1 :green_heart:
mvnsite
2m 55s

trunk passed

+1 :green_heart:
javadoc
2m 39s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
2m 12s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
4m 37s

trunk passed

+1 :green_heart:
shadedclient
21m 53s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 33s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 33s

the patch passed

+1 :green_heart:
compile
22m 48s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
22m 48s

the patch passed

+1 :green_heart:
compile
20m 46s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
20m 46s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
4m  5s
/results-checkstyle-root.txt
root: The patch generated 11 new + 182 unchanged - 1 fixed = 193 total (was 183)

+1 :green_heart:
mvnsite
2m 55s

the patch passed

+1 :green_heart:
javadoc
2m 24s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 59s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
4m 16s

the patch passed

+1 :green_heart:
shadedclient
21m 24s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
18m 44s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

+1 :green_heart:
unit
1m  5s

hadoop-rumen in the patch passed.

-1 :x:
asflicense
1m 25s
/results-asflicense.txt
The patch generated 1 ASF License warnings.

234m 30s

Reason
Tests

Failed junit tests
hadoop.util.TestXMLUtils

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4940/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4940

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux 45925de3a47c 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / b05445fe6890bb54997c17a7c5fe24a5ad7818a7

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4940/8/testReport/

Max. process+thread count
1740 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-rumen U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4940/8/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 38s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 53s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
26m  8s

trunk passed

+1 :green_heart:
compile
23m 25s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
20m 56s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
5m 15s

trunk passed

+1 :green_heart:
mvnsite
3m  1s

trunk passed

+1 :green_heart:
javadoc
2m 33s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
2m 17s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
4m 10s

trunk passed

+1 :green_heart:
shadedclient
21m 49s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 30s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 31s

the patch passed

+1 :green_heart:
compile
22m 47s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
22m 46s

the patch passed

+1 :green_heart:
compile
20m 51s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
20m 51s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
4m 13s
/results-checkstyle-root.txt
root: The patch generated 2 new + 182 unchanged - 1 fixed = 184 total (was 183)

+1 :green_heart:
mvnsite
2m 59s

the patch passed

+1 :green_heart:
javadoc
2m 16s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
2m 10s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
4m 24s

the patch passed

+1 :green_heart:
shadedclient
21m 52s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 41s

hadoop-common in the patch passed.

+1 :green_heart:
unit
1m  5s

hadoop-rumen in the patch passed.

-1 :x:
asflicense
1m 16s
/results-asflicense.txt
The patch generated 1 ASF License warnings.

236m  0s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4940/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4940

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux 6bf3ada162cd 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / b45ba50c7026731b3b00b24371762c1a9282b69a

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4940/9/testReport/

Max. process+thread count
1301 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-rumen U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4940/9/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 38s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 40s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
27m 53s

trunk passed

+1 :green_heart:
compile
25m 42s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
23m 31s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
4m 48s

trunk passed

+1 :green_heart:
mvnsite
2m 59s

trunk passed

+1 :green_heart:
javadoc
2m 32s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 58s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
4m 43s

trunk passed

+1 :green_heart:
shadedclient
22m  5s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 31s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 28s

the patch passed

+1 :green_heart:
compile
25m 12s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
25m 12s

the patch passed

+1 :green_heart:
compile
23m 27s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
23m 27s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
4m 24s

root: The patch generated 0 new + 182 unchanged - 1 fixed = 182 total (was 183)

+1 :green_heart:
mvnsite
2m 50s

the patch passed

+1 :green_heart:
javadoc
2m 28s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 57s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
4m 38s

the patch passed

+1 :green_heart:
shadedclient
21m 46s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
19m 10s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

+1 :green_heart:
unit
1m  4s

hadoop-rumen in the patch passed.

+1 :green_heart:
asflicense
1m 17s

The patch does not generate ASF License warnings.

247m 16s

Reason
Tests

Failed junit tests
hadoop.util.TestXMLUtils

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4940/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4940

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux 7da3270bc8b2 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e2050715e5ef04d499da8dc7a90ef3dd59ebe02f

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4940/10/testReport/

Max. process+thread count
1301 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-rumen U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4940/10/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 50s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 20s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
27m 42s

trunk passed

+1 :green_heart:
compile
26m  8s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
23m 12s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
4m 31s

trunk passed

+1 :green_heart:
mvnsite
3m 13s

trunk passed

+1 :green_heart:
javadoc
2m 37s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
2m  5s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
4m 13s

trunk passed

+1 :green_heart:
shadedclient
21m 10s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 30s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 37s

the patch passed

+1 :green_heart:
compile
25m 31s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
25m 31s

the patch passed

+1 :green_heart:
compile
23m 28s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
23m 28s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
4m 23s

root: The patch generated 0 new + 182 unchanged - 1 fixed = 182 total (was 183)

+1 :green_heart:
mvnsite
3m 18s

the patch passed

+1 :green_heart:
javadoc
2m 18s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 59s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
4m 25s

the patch passed

+1 :green_heart:
shadedclient
22m  3s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
19m  9s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

+1 :green_heart:
unit
1m  6s

hadoop-rumen in the patch passed.

+1 :green_heart:
asflicense
1m 20s

The patch does not generate ASF License warnings.

247m 10s

Reason
Tests

Failed junit tests
hadoop.util.TestXMLUtils

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4940/11/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4940

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux 6fa060e0880d 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / edb2decbe6f8526af588ba6680e57eee789fd789

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4940/11/testReport/

Max. process+thread count
3159 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-rumen U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4940/11/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 43s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 46s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
26m 19s

trunk passed

+1 :green_heart:
compile
23m 27s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
20m 45s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
4m 12s

trunk passed

+1 :green_heart:
mvnsite
3m  3s

trunk passed

+1 :green_heart:
javadoc
2m 36s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
2m 20s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
4m 30s

trunk passed

+1 :green_heart:
shadedclient
21m 20s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 31s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 34s

the patch passed

+1 :green_heart:
compile
22m 35s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
22m 35s

the patch passed

+1 :green_heart:
compile
20m 45s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
20m 45s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
4m  6s

root: The patch generated 0 new + 182 unchanged - 1 fixed = 182 total (was 183)

+1 :green_heart:
mvnsite
2m 55s

the patch passed

+1 :green_heart:
javadoc
2m 16s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
2m 23s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
4m 21s

the patch passed

+1 :green_heart:
shadedclient
21m 21s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 48s

hadoop-common in the patch passed.

+1 :green_heart:
unit
1m  3s

hadoop-rumen in the patch passed.

+1 :green_heart:
asflicense
1m 20s

The patch does not generate ASF License warnings.

234m 26s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4940/12/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4940

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux 29cf89afc73a 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 93a7556c6c833fa84beb0ebbbf7de97589a13f2a

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4940/12/testReport/

Max. process+thread count
3159 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-rumen U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4940/12/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

should those tests be removed, or simply modified to expect the different failure?
what does happen now when something invalid is tried? an exception raised or simply the result ignored.
(FWIW, this is why I prefer LambdaTestUtils.intercept(); that will print the toString value of the callable invoked if the exception isn't raised, so you can design tests to be meaningful on failures.)

@steveloughran the transformer tests that I added and then removed - they do not fail. The transformer in the PR as is does not seem to stop DTD entities altogether (it does for DOM and SAX parsing). The transformers are not as widely used in the hadoop code base as DOM parsing and often the input is already parsed (via DOM or SAX parsing) before it is transformed.

thanks, happy with the explanation.
I'm +1 for the change. there is one suggestion, use AbstractHadoopTestBase, but its not a blocker for this patch. if you don't want to do that, say so and i will merge as is.

@steveloughran I fixed the formatting issue and the build passed

merged to trunk; will see the build in 3.3. changed the title of the commit as (a) the centralisation hasn't taken place (b) didn't want to have to choose between us and non us spellings of centralise


Phoenix issue 168 - Show balance/channels at startup even when the wallet has not finished channel reestablish

We've recently encountered various connection issues. One such issue was a problem connecting to the Electrum server. And unfortunately, our code base was written such that, the balance was displayed as zero until the electrum connection was up-and-running. :poop: Thus, during that time we received emails from several panicked users - not because the app couldn't connect ... but because the app was showing them a zero balance!
Lesson learned: If you tell people their balance is zero, they are likely to freak out. :exploding_head: And understandably so.
We could simply display the balance as "pending" until the electrum connection is up. However, I find this to be unsatisfactory. It's really just annoying. I should be able to open the app in airplane mode, and it should show me my balance (as of the last time I was connected).
This PR provides a proper solution to the problem, and allows consumers (read: Phoenix app) to display the most-recent balance immediately after the app is launched.
The reason this wasn't possible before, is because the wallet balance is extracted from Peer.channels, the publication of which was suspended until the electrum channel had populated certain variables:
launch {
  // we don't restore closed channels
  db.channels.listLocalChannels().filterNot { it is Closed }.map {
    logger.info { "n:$remoteNodeId restoring ${it.channelId}" }
    val state = WaitForInit(
      staticParams = StaticParams(nodeParams, remoteNodeId),
      currentTip = currentTipFlow.filterNotNull().first(), // <= suspends
      currentOnChainFeerates = onChainFeeratesFlow.filterNotNull().first() // <= suspends
    )
    // ...
    _channels = _channels + (it.channelId to state1)
  }
}

The interesting thing here is that we already read the channels at boot: db.channels.listLocalChannels(). If we simply had access to this information, the UI could solve its problem:
So this PR makes a minor change:
// The channels map, as initially loaded from the database at "boot" (on Peer.init).
// As the channelsFlow is unavailable until the electrum connection is up-and-running,
// this may provide useful information for the UI.
private val _bootChannelsFlow = MutableStateFlow<Map<ByteVector32, ChannelState>?>(null)
val bootChannelsFlow: StateFlow<Map<ByteVector32, ChannelState>?> get() = _bootChannelsFlow

launch {
  // we don't restore closed channels
  val bootChannels = db.channels.listLocalChannels().filterNot { it is Closed }
  _bootChannelsFlow.value = bootChannels.map { it.channelId to it }.toMap()
  // restore channels (nb: suspends on currentTipFlow & onChainFeeratesFlow)
  val channelIds = bootChannels.map {
    logger.info { "n:$remoteNodeId restoring ${it.channelId}" }
    val state = WaitForInit(
      staticParams = StaticParams(nodeParams, remoteNodeId),
      currentTip = currentTipFlow.filterNotNull().first(),
      currentOnChainFeerates = onChainFeeratesFlow.filterNotNull().first()
    )
    // ...
    _channels = _channels + (it.channelId to state1)
  }
}

And with the corresponding change in the UI, hopefully this will result in less :cursing_face: and more :sunglasses:
https://user-images.githubusercontent.com/304604/118713280-bbc13400-b7ef-11eb-9604-832d851f6f70.mp4

Related: https://github.com/ACINQ/phoenix-kmm/issues/168

How do you handle having these two flows in the app?
You first use bootChannelsFlow to show the initial balance, and then channelsFlow to update it once channels are up?

Can you also update the version to snapshot?

You first use bootChannelsFlow to show the initial balance, and then channelsFlow to update it once channels are up?

Exactly. The corresponding PR in Phoenix is here

Can you also update the version to snapshot?

Done


New Feature: Add join meeting via link functionality

Current behaviour :
User can join with meeting ID/pass :

New feature:
Join with URL,

Make a text box to enter a URL in above table
eg. https://us06web.zoom.us/j/85420625507?pwd=ZaxjiSNMUBvgyZ9QOaVRUcZyfS5onz.1
Find a way to join meeting via URL from zoom docs

I think we can deprioritize this, we want to guide people to use our app instead of joining the meeting from the website.


implement the manager-feature so the manager can edit any profile-page

Closed manually because of team decision.


Layout problem in landscape mode

There is a minor bug with toolbar in landscape mode. The navigation drawer layout is a bit upper and the text becomes too small

Hi.
I'm currently aware of this issue. I'm still trying to figure out the best solution to this. In the meanwhile you can check this fix:
https://github.com/kanytu/android-material-drawer-template/issues/38

The issue is only present in the ScrimInsetsFrameLayout layout. It is fixed by changing the activity layout file.
For the ScrimInsetsFrameLayout element, change layout_width="match_parent" to layout_width="@dimen/navigation_drawer_width"

That's a very interesting fix. I will have to have a look at it when I have the time. Thanks :+1:

@WillemFTW  that fix wont work. Also in this template the layout containing the ScrimInsetsFrameLayout has the correct value:
https://github.com/kanytu/Android-studio-material-template/blob/master/MaterialNavigationDrawerActivity/root/res/layout/activity_top.xml.ftl#L39

@WillemFTW The fix won't work as the problem is still present without ScrimInsetsFrameLayout. However the layout_width still needs to be changed to layout_width="@dimen/navigation_drawer_width" as you pointed out.

Hoe to change the tittle of the toolbar respectively when user clicks the items in navigation drawer


Display nodes no longer working?

Many display nodes are not working after latest update.
Display int, display any. I also noticed other node sets display type nodes dont show info anymore
Is this a bug with new comfy?

seems to be working for me in a fresh install, is everything up to date?

I have this problem as well and I updated earlier today. I was coming here to look for a solution - in my case it's the "display any" node that won't display anything besides the word "output".

It seems to be working for me as well. Is it still not working for you? Any other specific details by chance?

In fact it's all nodes that used to be showing text strings that are not working anymore for me.
Output to terminal console is still working properly, so the basic exchange of data between nodes is still working properly, it's just the preview that is causing problems.
I found a thread on reddit describing something very similar to my own problem, and it looks like it was caused by a custom node, but they don't know which one. So I'll try removing them to find the culprit and I'll come back when I find it.
Any other thing I should be trying ?
Thanks a lot for the follow-up, I appreciate it.

it looks like it was caused by a custom node, but they don't know which one. So I'll try removing them to find the culprit and I'll come back when I find it.

Cool, if you binary search through your extension (as in, bulk remove half at a time and keep cutting it in half until it works) you can usually narrow it down pretty quickly.

Any other thing I should be trying ?

If you open your browser DevTools to the Console tab (usually F12 key on your keyboard), and then execute your workflow up to the rgthree-comfy Display Any node, you can see if there's any relevant error output that occurs in the console around that time it should be displaying something.

I removed the custom nodes and only kept yours and a few others and I can confirm that "show any" is now working again to display strings.
I'll put back some of the essential nodes I am working with first, and then I'll use a most systematic approach along the lines of a binary tree, as recommended. I'll be back with more info about what's causing this.
One thing is clear: it's not rgthree !

I found the culprit: ComfyUI-DeepFuze !
I've removed it, and now all nodes that are supposed to display text strings from an input are working again.

I was just going to comment this, I solved my issue by reinstalling comfy, but it was deepfuze that did it.  I don't know if installing deepfuze did more than install a node, it changed things many other nodes relied on.


Add the creation of firewall_rule and output AZURE_POSTGRESQL_DATABASE_NAME

Description

Fixes #20
@rajeshkamal5050 and @mbilalamjad for notification.
Type of Change

[ ] Non-module change (e.g. CI/CD, documentation, etc.)
[ ] Azure Verified Module updates:

[ ] Bugfix containing backwards compatible bug fixes

[x] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
[ ] The bug was found by the module author, and no one has opened an issue to report it yet.

[ ] Feature update backwards compatible feature updates.
[x] Breaking changes.
[x] Update to documentation

Checklist

[x] I'm sure there are no other open Pull Requests for the same update/change
[x] My corresponding pipelines / checks run clean and green without any errors or warnings
[x] I did run all  pre-commit checks

@mbilalamjad  Could you help review this PR? Thanks a lot.


[Android]Sound only playing through headphones

I know that iOS had a same issue on sound playing only through headphones.
(https://github.com/luanpotter/audioplayers/issues/33)
I am facing same problem with android.
static AudioCache player = AudioCache(prefix: 'sound/');
player.load('beap.mp3');
player.play('beap.mp3');

this works perfect on iOS. but for Android, sound only plays through headphone.
Is there a way to fix this?
Thank you

Does that happens with multiple devices? As far as I remember we don't have any code to select where to play the sound despite the respectSilence flag, which by your code, you don't use, so maybe the device you used to test has some config to play only on the headphones?

I am testing this on Samsung Galaxy S6.  I tested same code on Galaxy S10, and it worked fine.
I was thinking same, config to play only on the headphones, but i don't see any where to config sound properties.

Closing this due to reports of this being fixed on newer versions. Feel free to open a new issue in case of this still happening


fix(ONYX-1287): broken spacing between home view sections

This PR resolves ONYX-1287
Description
This PR is an attempt to fix the broken spacings between home view sections. Here I am attempting a fix using the first approach suggested below in the thread👇.
Full Context from Slack Pasted Below

I noticed an extra margin between some rails in the home view - this is mainly because we define an ItemSeparatorComponent on the HomeView level. This is fine in the case where all sections are defined, however in our case, some sections might be missing and that will lead  to additional spaces representing missing section.
If we want reliable margins, I see two possible approaches:

Move the spacings one level below to the individual sections level.

Pros: easy to implement
Cons: we need to make sure all new sections include the same spacing logic (I guess this will be easier done than said)

Have some logic within the HomeView component to check if an item is empty or not.
For example: In the case of auction results, a function like isSectionEmpty()  that checks the count of auction results count of a section in case its typeName is HomeViewSectionAuctionResults

Pros: We can stick to the ItemSeparatorComponent API
Cons: more or less complex to implement and will require us to unmask the sections relay fragments or something similar to check if the section is empty or not

Any other thoughts?

https://github.com/user-attachments/assets/ce8e35df-fac4-4e0f-b1b0-82df7fa43e88

PR Checklist

[x] I have tested my changes on iOS and Android.
[x] I hid my changes behind a feature flag, or they don't need one.
[x] I have included screenshots or videos, or I have not changed the UI.
[x] I have added tests, or my changes don't require any.
[x] I added an app state migration, or my changes do not require one.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

Fix broken padding between home view sections - mounir

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

This PR contains the following changes:

Cross-platform user-facing changes (Fix broken padding between home view sections - mounir)

  Generated by :no_entry_sign: dangerJS against 4c17bae143af17e729ac0d3204e40333c99fd136


Windows 32bit: HelpFlagsTest fails due to missing specifications

Describe the bug
OpenJDK Test HelpFlagsTest fails on Windows 32bit, JDK11 and JDK16, due to an apparent test config issue.
JDK11: https://ci.adoptopenjdk.net/job/Test_openjdk11_hs_extended.openjdk_x86-32_windows_testList_0/10/console
JDK16: https://ci.adoptopenjdk.net/job/Test_openjdk16_hs_extended.openjdk_x86-32_windows_testList_0/7/consoleFull
To Reproduce
Grinder link
Expected behavior
I expect the test to pass, as it does on Windows 64bit.
Screenshots
23:47:39  STDERR:
23:47:39  java.lang.AssertionError: HelpFlagsTest failed:
23:47:39  Tool jaccessinspector-32.exe not covered by this test. Add specification to jdkTools array!
23:47:39  Tool jaccesswalker-32.exe not covered by this test. Add specification to jdkTools array!
23:47:39
23:47:39  	at HelpFlagsTest.main(HelpFlagsTest.java:378)
23:47:39  	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
23:47:39  	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
23:47:39  	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
23:47:39  	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
23:47:39  	at com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:298)
23:47:39  	at java.base/java.lang.Thread.run(Thread.java:829)
23:47:39
23:47:39  JavaTest Message: Test threw exception: java.lang.AssertionError
23:47:39  JavaTest Message: shutting down test

Additional context
Test will be excluded. Link pending.

I am presuming the jdkTools array is in upstream code, in which case this issue should get reported and fixed upstream.

Issue reported here: https://bugs.openjdk.java.net/browse/JDK-8273235
Seems a simple enough fix now I've read the code. Have added notes on the fix to that bug.

Closed now that #3149 is merged.