Change 3D examples to save_last_frame

Currently, we get from time to time the message:
Command killed due to excessive memory consumption
Command time: 775s Return: 137

from read the docs build.
I think we should speed up the building process a bit, and my idea is to render only the last frame from the 3D examples.
EDIT:
After this pr: Build took 529 seconds

While the 3d examples certainly do take a comparatively long time to render, simply removing the animation from them doesn't feel like a step in the right direction to me.
Manim can be used for 3D animations, so we should also properly showcase that. What I do agree with, however, is that I think it would make sense to replace the current 3D examples (in particular ThreeDCameraRotation, and ThreeDCameraIllusionRotation) with ones that illustrate Manim's 3D capabilities a bit better; I've always found two so similar examples in the gallery a bit odd.

In general, I agree, there should be some 3d examples.
However, I find it a bit unnecessary that they are rendered for every commit that is done, and it readthedocs is currently the longest build in our pipeline.
Is there maybe an option in the manim_directive to render these videos for the release version o f the docs and only save the last frame for commits in pull requests?
That would be a very elegant solution.

In general, I agree, there should be some 3d examples.
However, I find it a bit unnecessary that they are rendered for every commit that is done, and it readthedocs is currently the longest build in our pipeline.

Given our not too great test coverage, the documentation build also tests whether the changes from a PR still allow currently existing scenes render successfully; I can remember multiple occasions where problems were detected only due to build failures in the documentation.

Is there maybe an option in the manim_directive to render these videos for the release version o f the docs and only save the last frame for commits in pull requests?
That would be a very elegant solution.

We could look into that and I'd be somewhat confident that we could get it to work -- but at the same time this would mean that we couldn't properly preview changes of PRs adding new examples to the documentation any longer. I'd be interested what other devs think about this.

I think the issue with RTD is that we can only have 2 concurrent builds active. When we can get our manim_directive.py to render scenes with renderer=opengl, I think this will drastically cut down the time for RTD and make time less of an issue. I don't think we should outright remove 3D examples though unless they're too similar/not needed. I agree that some could be images, but we can and should have a few videos for 3D animations.
Sometimes the docs are built unnecessarily though. In the past, we've run into concurrency issues because multiple PRs are waiting in line for RTD and don't actually need to render the docs. In these cases, it would be nice to manually kick the PR from using RTD so others can use it, but I think for now we'll just have to wait the 588~657 seconds that RTD usually takes.

ok, I've now updated only the ThreeDSurfacePlot example:

@jsonvillanueva please remember to label/make the PR name more descriptive before merging... oh wait that's me.


Sql-Formatter plugin can not work in IE browser

In IE browser，it is report error msg.

whether this plugin can support IE, when the version is greater than 2.3.4 ?

Yes. IE is not supported, as SQL Formatter is built with ES6 target, which isn't supported by IE.
If you need IE support, you have the option to compile it with Babel to ES5.
https://kangax.github.io/compat-table/es6/

@nene I try compile it with Babel to ES5, but I found it also can not work in IE, because The Babel cannot transform unicode regex.
so. It there any way to compile it?

What about using regexpu to transform these regexes to ES5?
I suspect though that the main problem is that sql-formatter builds lots of these regexes dynamically, and these can't be detected by these transformation tools.
I think there are really only a few places where we really need these unicode regexes. The main one being matching of identifiers. And this part definitely can't be transformed, as it's not part of a /regex-literal/u.
I think it should be possible to eliminate most of our current unicode regexes (or maybe only use them when unicode support is detected in browser). I'll reopen this issue to reconsider.


install home assistant on ubuntu server 16.04 arm

i dont' install homeassistant on my ubuntu
i use code : sudo pip3 install homeassistant
and it's display as flow

Same as https://github.com/home-assistant/home-assistant.io/issues/6216


Nested matching appears to be broken

I just wanted to start by saying thanks again for a great lib!
I've been trying to upgrade the sift dependency for mson from version sift 9.0.0. Unfortunately, I'm seeing a number of issues. I dug into a particular problem and am seeing an issue with matching nested queries, e.g. the following filter doesn't capture any values with sift v13.1.10. It does however work with sift v9.0.0:
import sift from "sift";

const where = {
  fields: {
    firstName: {
      value: {
        $eq: "Jimmy"
      }
    }
  }
};

const whereProps = {
  fields: {
    firstName: {
      value: "Jimmy"
    }
  }
};

const sifted = [whereProps].filter(sift(where));
console.log({ sifted });

Here's a codesandbox for it not working in v13.1.10. And one for it working in v9.0.0
I haven't had a chance yet to identify a root cause yet.

Glad you like it! v12-ish introduces a behavior change to better match MongoDBs functionality, so nested query searches like yours won't work anymore. Here's what you can do:
const test = sift({
  "fields.firstName.value": {
    $eq: "Jimmy"
  }
})

test({
  fields: {
    firstName: {
      value: "Jimmy"
    }
  }
}); // true

Mongodb demo: https://mongoplayground.net/p/tPM8-xAb-4J
Code sandbox: https://codesandbox.io/s/sift13110-6gv4c
Let me know if you need anything else!

Interesting. Could you please elaborate on why we wouldn’t support both notations? (Perhaps this is more a question for MongoDB)

Could you please elaborate on why we wouldn’t support both notations?

For Sift, the reasoning is that a lot of other Node modules that interact with MongoDB also use Sift, so it made sense to keep the functionality identical to ensure that all queries in Sift were also usable with MongoDB.
I don't know exactly why Mongo doesn't allow for nested queries, but my guess is that it's to create a boundary between the query language and data. For example, in MongoDB you can insert a document with a $ operator like so:
db.somestuff.insert(firstName: {
  value: {
    $eq: "Jimmy"
  }
});

And then query that:
db.people.find({
  fields: {
    firstName: {
      value: {
        $eq: "Jimmy"
      }
    }
  }
});

Here's a demo: https://mongoplayground.net/p/jtnF2Z4es4S

I'm not sure I follow. Here's a mongoplayground where you can filter by nested values in MongoDB, the exact filter that sift v13.1.0 does not support.
Configuration:
[
  {
    fields: {
      firstName: {
        value: {
          $eq: "Jimmy"
        }
      }
    }
  }
]

Query:
db.collection.find({
  fields: {
    firstName: {
      value: {
        $eq: "Jimmy"
      }
    }
  }
})

☝🏻 MongoDB in this case is treating $eq has a prop. Here's a better example: https://mongoplayground.net/p/0UIcUQl8Z3v

OK, I think I follow now. Here you can see that the nesting does not work, but the dot notation does work


DLP-809: Add support for DLP payload logging rule/account settings

Description
DLP recently added support for partial payload logging, which will log a portion region of matching requests and encrypt it using a user-provided public key. This PR adds support for setting that public key and enabling payload logging for individual rules.
Has your change been tested?
The change includes unit tests to cover the new functions. These tests match the actual responses given/URLs used by the public API.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

thanks! a couple of small nitpicks but overall looking good!

I think I've addressed your comments, if you want to take another look

thanks @OrionNebula ✨


docs: random typos

@aaronArinder: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/


reduce repetitive spl_object_hash() at SendResponseEvent

[x] Is this related to quality assurance?

@samsonasik while we are at it, can you also add import for the spl function? Thanks

@Xerkus done ;)

@samsonasik thank you


update dependencies and move to inline sourcemaps for dev

Newer versions of VSCode seem to not follow the webpack-internal eval sourcemaps (like browsers are doing).
Apart from moving to inline sourcemaps i couldn't find a working solution.
There will be a slight change in compile time, but it is neglectable. Generated files (in development) will be larger, but memory consumption should be the same.

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Reviewer - this PR has made changes to one or more package.json files.

Snapshot stored with reference name:
refs/pull/14411/merge
Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14411/merge/index.html
To test a playground add it to the URL, for example:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14411/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/14411/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/14411/merge
https://gui.babylonjs.com/?snapshot=refs/pull/14411/merge
https://nme.babylonjs.com/?snapshot=refs/pull/14411/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/14411/merge#BCU1XR#0

already factorized TBH. webpackTools contains the default webpack configuration. This is a relic of older, quieter, more sane days.
I'll see what I can do

Reviewer - this PR has made changes to one or more package.json files.

Reviewer - this PR has made changes to one or more package.json files.


CChart tooltips not showing like the demo

Chart tooltip is not showing as the Demo. Instead it shows under the chart when a data point is hovered.

This is the demo:
My code (copied from the Docs ):
<CChart
  type="bar"
  data={{
    labels: ['January', 'February', 'March', 'April', 'May', 'June', 'July'],
    datasets: [
      {
        label: 'GitHub Commits',
        backgroundColor: '#f87979',
        data: [40, 20, 12, 39, 10, 40, 39, 80, 40],
      },
    ],
  }}
/>

Is the a dependency/additional lib that I'm missing? Looking forward for some help.

Same issue here. Couldn't figure out what's missing.

I got the same issue and couldn't figure out


bug - requesting history on initial sign in

Not sure if you'll be able to replicate the bug but on the first opening of the app and authenticating, chat histories would not load and this status was persistent until i quit and relaunched the app, at which point it would then work appropriately and load chat history.

can you open the inspector and see if there is any exception?
have you tried switching conversations and return to this one?


Accept pathlib.Path as pattern in read_hdf

[x] Tests added / passed
[x] Passes flake8 dask
[x] Fully documented, including docs/source/changelog.rst for all changes

pandas can deal with pathlib objects in read_hdf, the current read_hdf in dask either expects a string or a list. pathlib objects aren't subclasses of str so they need special treatment.

Any interest in adding support for the fspath protocol? https://www.python.org/dev/peps/pep-0519/
Here's where pandas does it: https://github.com/pandas-dev/pandas/blob/89444ad5d3426dd1898b96477f767996c7f48ca0/pandas/io/common.py#L121-L161 (along with some backwards compatibility things).

No rush.  Thanks for helping out!
On Thu, Mar 29, 2018 at 5:16 PM, Jörg Dietrich<EMAIL_ADDRESS>wrote:

Thanks for your comments. Just to let you know, I'm planning to address
these ~end of next week.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask/pull/3335#issuecomment-377375098, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AASszPUkb0KRfryzBEVfa1nLRWLx7xfXks5tjU86gaJpZM4S8spk
.

Thanks for picking this up, @jrbourbeau! It got lost among too many other things.

I totally understand : ) thanks for your work on this

In [5]: path.__fspath__??
Signature: path.__fspath__()
Docstring: <no docstring>
Source:
    def __fspath__(self):
        return str(self)

@martindurant I moved the path-like object to string conversion into a utility function in dask/bytes/utils.py

Are there any remaining concerns for this PR @martindurant @TomAugspurger?

Thanks for your work on this @joergdietrich and for the reviews @martindurant and @TomAugspurger


[SIP-22] Proposal for changes to time filter to allow for more flexible time range selections

[SIP] Proposal for changes to time filter to allow for more flexible time range selections
Motivation
Time is a first order dimension and the primary way to filter datasets. A few issues that need to be resolved:

It is currently impossible to specify commonly filtered time ranges on recurring charts and dashboards. (ie. last full week, etc.)
It is unclear to users what time ranges are being specified
Date ranges are conflated with date+time ranges

Currently in Superset, there are a few different ways to specify a time range for a set of data in Explore View:

On the ‘Defaults’ tab, there are a few options here:

No filter - no specified range; return all data
All other options are presets filtering on time ranges relative to today. The units of time referenced here convert to # of days. For example:

Week = 7 days
Month = 30 days
Quarter = 90 days
Year = 365 days

#### On the ‘Custom’ tab, there are 2 options:
1. Relative to today is similar to Defaults, however this is flexible enough historical and future looking as well as controls on units of time
2. Start/End is pretty self explanatory. The one notable element here is the ability to use English to express time; however this is somewhat limited
#### All date/time ranges start at 00:00:00 time
Proposed Change
The main issues we need to solve are:

Ability to specify relative dates that are not relative to today
Ability to specify start of time units
Clearly display time ranges being filtered for
(Nice to have - improve usability by adding more common default time ranges)

Changes to Defaults tab

Modify Defaults tab to organize by unit of time
Add clarifying time range selected
Augment default time ranges
Add Week Start Date
Modify months to be interpreted as calendar months (otherwise use weeks)

Changes to Custom tab
Mostly, the same with the following modifications:

Add ability to anchor to specific date (defaulted to Today)
Show selected time range
Keep ability to do “english” language times (ie. 6 hours ago, now, etc. through Start/End dates)

New or Changed Public Interfaces

Will need to keep superset tables that at minimum contain calendar months (ie. how many days in each month, etc.) if not standard time tables if eventually we want to get fancier with time ranges

@mistercrunch @xtinec @john-bodley @datability-io @betodealmeida

@john-bodley i think this is compatible with SIP-15's proposal. Am fine disregarding time in the Defaults->DAY and above unit of time options

@vylc I think these changes make a lot of sense and touch on some aspects of SIP-15 regarding explicit callout. A few comments/thoughts:

It's also worth pointing out that the current relative timestamp sometimes uses now and other times uses today as the reference point which is somewhat confusing.

Related to SIP-15 should we align on supporting dates and timestamps or just make everything timestamps? I proposed the former in SIP-15 but I'm not opposed to the later. Note there are other temporal grains; week, month, quarter, year etc. however we (and other BI tools) normally just encode these as timestamps.

For DAY I'm not sure that  "Today so far (now)" should reference now as we're talking about dates and not times. I'm uncertain whether it should be [, today) (exclusive of today) or [, tomorrow) (inclusive of today).

We need to ensure that the time window is apparent when the widget is closed.

From a UX perspective we're really specifying a time window either as: i) a start and and end, ii) a start with a duration, or iii) and end with a duration and was wondering whether there was merit in trying to design this into the widget somehow (which ties into #4).

We also have a time grain selector and wonder if it make sense to keep these decoupled or somehow combine them.

Also here is Looker's various date/time filters which provide some additional context regarding the various patterns they support.

I really like this proposal, as I often find myself needing an interval that isn't available. I recently opened a PR which solves a subset of this problem, namely the now/today one ( #7525 ), but I do feel that Superset would benefit a lot from adding more functionality in this space. I would like to add that Last Month or similar might mean very different things to different people; for one it means a moving window(e.g. 2019-04-30 to 2019-05-29) , while for others it usually means last full period (2019-05-01 to Today). This is often tightly coupled with time grains, and probably benefits from anecdotal analysis where the current functionality was insufficient.

Thanks for sharing this proposal! In the future when proposing a change to UX of the tool please add the label design-review.

The number of defaults under for example the Default - Today tab is overwhelming. We should draw a thoughtful line around how many options we provide users. The more choices a user is presented with, the longer the user will take to reach a decision. Check out Hick's Law.
This feels like a move towards supporting power user needs over general usability. It should be noted this provides greater friction for the non-power user. Having to select Today, Day, Week of Month first to find a specific default is not as user friendly/discoverable as it exists today. I question if some aspects of this should this live behind a more advanced option and/or feature flag for the time filter?
I appreciate that you're trying to provide greater clarity of the selected time range for the user. The placement of the what I would suggest calling "Selected Time Range" looks like a bit of an afterthought right now. My guess is this a limitation of the tool you're using to mock this up in. It would be worth thinking about the hierarchy of information here. Rank it and order it as such. I would probably place the selected time range first. I think this is a great add all around.
Week Start Day under Defaults > Week/Month is a bit hidden and unless I'm mistaken should probably be closer to the Today, Day, Week, Month selector.

• I like that we explicitly note the time range selected. The placement feels a little weird though; would like a design pass. Agreed with @john-bodley's point above that we should show this after selection as well.
• I’m not sure about the [Today, day, week, month, year] drop-down in the defaults. It took me a while to grock, and I wondered at the number of defaults (could it lead to the paradox of choice?). It feels sufficiently complex that it feels like more than “Defaults” i.e. starts feeling "Custom." I think it's worth re-considering how we group these options at the highest level (relative / absolute seem like bigger distinctions, possibly).
• I like all the changes to custom tab
• I may be missing something, but I don’t think this actually solves the “Ability to adjust start time.” We could do that by adding a custom for the start date

@vylc @sylvia-tomiyama If there is alignment on the solution and it can be clearly documented I can take a pass at visually representing it. I don't have the cycles to get involved in the discussion or wait for it to land but I can mock up once we have a clear and unified vision.
Sylvia, note It might take time away from GMUI support as we try to launch.
Feel free to tag me here when it's ready.


feat: first-class Deno installs

This adds support for first-class Deno installs via the recently-added Deno provider.
Specifically:

generator.install('deno:path') corresponds to a stdlib install and will populate a versioned stdlib mapping for path to the Deno standard librariy.
generator.install('denoland:oak') corresponds to a third-party Deno.land install and will populate the mapping similarly.

In addition a new defaultRegistry option is added as well as the ability for the providers object to provide registry mappings.
defaultRegistry applies the default registry for generator.install('x') to default to generator.install('registry:x') with the default obviously being npm:.
providers having custom registry: entries allows custom registry provider mappings via new Generator({ providers: { 'npm:': 'unpkg', 'denoland:': 'custom' } }) sort of thing ensuring this all is consistent with the provider and registry separation model.

Love this, many thanks 🥇


Fixes Cross Publishing

I've just realized we should cross-publish with +publishSigned instead of just publishSigned, now that we have cross compatibility through scala 2.11 and 2.12. Also, if we don't apply allSettings to the root project, the cross versioning starts with scala 2.10.
This PR comes to fix it.
@dialelo  @peterneyens  could you take a look? Thanks!

Good catch! LGTM

It seems I didn't check the documentation for 2.11 after the cats update, I think we are missing import cats.syntax.either._ in docs.md.

Current coverage is 76.03% (diff: 100%)

Merging #86 into master will not change coverage

@@             master        #86   diff @@
==========================================
  Files            10         10
  Lines           242        242
  Methods         240        240
  Messages          0          0
  Branches          2          2
==========================================
  Hits            184        184
  Misses           58         58
  Partials          0          0

Powered by Codecov. Last update 8927046...c663372

:+1: Thanks for cleaning up after me :blush:


refactor: reimburse sats on failed USD payment

Description
This PR is to add a condition where we reimburse the original sats sent instead of reverting the original usd transaction for a failed USD LN payment.
The original USD transaction entries are left untouched, and the new code simply adds a recordReceive call which adds 2 new BTC transactions to the ledger (a credit to the user, and a corresponding debit to lnd).
I explored optionally recreating the part of the medici void method that only updates the original journal/transactions but skips the addReversedTransactions call, but doing this would significantly expand the scope of this PR (introduce a Journal schema, replicate consistency guarantees and add tests etc.). So given this, the original USD transactions remain untouched.

I explored optionally recreating the part of the medici void method that only updates the original journal/transactions but skips the addReversedTransactions call, but doing this would significantly expand the scope of this PR (introduce a Journal schema, replicate consistency guarantees and add tests etc.). So given this, the original USD transactions remain untouched.

Your thinking on this was to update prior ledger transaction in place?
if this is the case: typically we don't want to change any written transaction. a ledger should be thoughts as an append only database.

@vindard there is a conflict with this PR


Move private property to dataset options and disallow PUT on external datasets

If we consider metadata on external datasets immutable in our system, a PUT should fail.
However, currently we have the private attr in the meta data, and I reckon that this could actually be changed over time.
Problem is I think we show the "private" icon in many places taken from the dataset response.
This would not be possible unless it was included as a readonly attr on the dataset response, but only mutable in the options

external datasets do not have immutable metadata.
In fact external data (uploaded or downloaded) might not have any metadata at all and we & users need a way to manage it.

OK - was just considering (maybe I already did) hiding the edit toggle for external datasets.

The distinction between dataset metadata and settings is not always clear I agree.
We have various things linked to a dataset that are very independent from each other:

classic human metadata: (title, alias, description, contact, etc
external settings (url, format, delimiter)
private flag
ACL of allowed editors
origin, creator which are immutable
key, sourceKey, importAttempt as backend managed keys only


fix kind issue in CI.

kind in master is broken, see: https://github.com/kubernetes-sigs/kind/issues/509, use released version as a workaround.

For the record - I'm not sure 0.2.1 is best option, it's from Mar27 - and may not work with the image we built.
Maybe we can checkout on SHA, from 2-3 days ago ?
We'll also need a similar fix in the Docker image, but less urgent.
And thanks for the quick fix !

Yes, it's really annoying that kind master is broken. Let's see if kind v0.2.1 is stable or not.


Adding initial implementations of DL approach

See files inside of kings02/

Removed some testing notebooks that I didn't mean to commit.


In your R script (create_regions_from_gencode.R) there is a small bug

transcripts.data <- unlist(transcripts.data) ###ERROR
exons.data <- unlist(exons.data)
threeUTRs.data <- unlist(threeUTRs.data)
fiveUTRs.data <- unlist(fiveUTRs.data)
cds.data <- unlist(cds.data)
introns.data <- unlist(introns.data)
genes.data <- unlist(genes.data) ####ERROR

There error is:
Error in getListElement(x, i, ...) :
  GRanges objects don't support [[, as.list(), lapply(), or unlist() at
  the moment
Calls: unlist ... FUN -> [[ -> [[ -> getListElement -> getListElement
Execution halted

I did not need those lines to work for my purposes, but just an FYI on the issue.

I have the same problem，Bioconductor 3.8 may not support the this，but I didn't solve it

Thanks @Alex-Nesta and @xf78 for reporting the issue. I will try to have a fix soonish. In the meantime, can you check if the data you need is here: https://github.com/saketkc/gencode_regions/tree/master/data Happy to add if it's missing (which is very likely!)

I had the same issue, using GenomicFeatures v 1.34.3 (not sure which other packages/versions might be relevant for this). It appears that genes(), transcripts(), and promoters() return a GRanges object ["The only exception being when genes is used with single.strand.genes.only=FALSE, in which case a GRangesList object is returned."], while threeUTRsByTranscript(), fiveUTRsByTranscript(), cdsBy(), exonsBy(), intronsByTranscript() return a GRangesList object, so for the latter ones the unlist is required, but not for the former ones.
By simply removing the lines as mentioned above
transcripts.data <- unlist(transcripts.data)
and
genes.data <- unlist(genes.data)
as well as replacing
promoters.data <- unlist(promoters(TxDb, upstream=len, downstream=len))
with
promoters.data <- promoters(TxDb, upstream=len, downstream=len)
I managed to recreate the files as provided in data/GRCm38/vM14/

Hi, having the same problem here. Is it possible to get the data for GRCh37 uploaded to https://github.com/saketkc/gencode_regions/tree/master/data ?
Thank you!

I also encountered this issue currently, using conda hosted R-3.3.2 to install dependencies solved the issue.
However, while conducting problem searching, I noticed that
The overall goal of all these changes is to bring more consitency between IRanges and GRanges objects
 (GRanges objects will also support [[, unlist(), as.list(), and lapply() in Bioconductor 3.8).

in unlist doesn't work for IRanges, so maybe downgrading to Bioconductor 3.8 version can also solve the issue (I'm not pretty sure, haven't tried yet).

Running into this same issue now


Spotify connect delay (lyric offset options)

ranges from 300 ms to 3 seconds. default is 400 ms because of my testing (local google home casting). hope this helps people. i think it's ready to merge

Package.resolved also added to git ignore here finally


a few more fixes to the vagrant code reloading feature

This just fixes some bugs that we ran into when testing this functionality internally.

Any updates on this?

Merged this branch and built it and I'm still getting a panic on start up: https://gist.github.com/latortuga/0216f3c0cf2e11b4ec8b

cc/ @burke ?

Any updates on this?

@doy: it looks like we still need to land this before killing off our fork right? If so, is this up to date and ready for a re-review?

@latortuga: that panic looks unrelated to the changes in this diff. This is rebased on upstream and the new integration tests exercise the code that paniced for you.
@doy: This lgtm and matches what we've been running successfully at Stripe for months so I'm pretty confident in it.


2 way Org Chart

Is it possible to build a 2 way Org Chart. which to add a level of nodes on the top of the root(company) to show the owners/stockholder of it.

Yes, it's possible but will require significant additional work on top of the current code

I think yes, but will require significant amount of additional work

Is it possible to build a 2 way Org Chart. which to add a level of nodes on the top of the root(company) to show the owners/stockholder of it.

Have you been successful?


docs(readme): add 'who is using it?' chapter

Coverage remained the same at 72.945% when pulling c4821d54196b36f0514993256cdc25b5a31ed00e on master into 1d628b3aabbd6e16e8f64ee92a4a4fd748345aa5 on<EMAIL_ADDRESS>


[BUG] Molotov / Incendiary damage not showing

https://github.com/5stackgg/web/commit/bf017c4b05253230bfcb5dc48cea4147a2ed4903


description improvements

When using type in description, break them into separate words:
MyThing type is currently displayed as "mything", should be "my thing"

if the entities don't have "name" field, just display the number of entities in the list, instead of "undefined + N items"

\o/ thanks for capturing this...


[WIP] Drop PyTorch 1.9 support

What does this PR do?
See title
Fixes #15346
Does your PR introduce any breaking changes? If yes, please list them.
Drops PyTorch 1.9 support, as expected by our support window
Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[ ] Did you make sure to update the documentation with your changes? (if necessary)
[n/a] Did you write any new necessary tests? (not for typos and docs)
[n/a] Did you verify new and existing tests pass locally with your changes?
[x] Did you list all the breaking changes introduced by this pull request?
[ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

[ ] Is this pull request ready for review? (if not, please submit in draft mode)
[ ] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @carmocca @akihironitta @borda @justusschock @awaelchli @rohitgr7

PyTorch 1.13 is not yet out officially, so we shouldn't be dropping 1.9 yet

I know. The release date is supposedly today

Marking as ready to run tests. Still WIP

@carmocca how much is missing here?

This needs to be split into 2:

Drop 1.9 support
Add 1.13 testing

The latter is blocked by issues with IPUs and colossalai

@carmocca For the latter, is the issue that these libraries don't provide a package with support for 1.13, or is it our implementation that needs updates?
How about we keep the IPU job running on 1.12? And run colossalai tests only on <= 1.12? If Graphcore and Colossal don't release new packages before our next release, we can implement checks that inform the user that these strategies are not yet supported on pytorch >= 1.13.
Since these are optional dependencies for Lightning, I don't think they should block us from providing support and testing of  core for the latest pytorch version.

I've removed all 1.13 related changes so that this can go before #15403.
Note that we need to update IPUs because they use 1.9


[tool_crash] FileSystemException: Cannot create file, OS Error: Is a directory, errno = 21

Command
flutter create .

Steps to Reproduce

...
...
...

Logs
FileSystemException: Cannot create file, OS Error: Is a directory, errno = 21
#0      _File.throwIfError (dart:io/file_impl.dart:675:7)
#1      _File.createSync (dart:io/file_impl.dart:306:5)
#2      ForwardingFile.createSync (package:file/src/forwarding/forwarding_file.dart:26:16)
#3      ErrorHandlingFile.createSync.<anonymous closure> (package:flutter_tools/src/base/error_handling_io.dart:295:22)
#4      _runSync (package:flutter_tools/src/base/error_handling_io.dart:600:14)
#5      ErrorHandlingFile.createSync (package:flutter_tools/src/base/error_handling_io.dart:294:5)
#6      Template.render.<anonymous closure> (package:flutter_tools/src/template.dart:321:28)
#7      _LinkedHashMapMixin.forEach (dart:collection-patch/compact_hash.dart:633:13)
#8      Template.render (package:flutter_tools/src/template.dart:281:24)
#9      CreateBase.renderMerged (package:flutter_tools/src/commands/create_base.dart:485:21)
<asynchronous suspension>
#10     CreateBase.generateApp (package:flutter_tools/src/commands/create_base.dart:508:23)
<asynchronous suspension>
#11     CreateCommand.runCommand (package:flutter_tools/src/commands/create.dart:369:31)
<asynchronous suspension>
#12     FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1408:27)
<asynchronous suspension>
#13     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:153:19)
<asynchronous suspension>
#14     CommandRunner.runCommand (package:args/command_runner.dart:212:13)
<asynchronous suspension>
#15     FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:420:9)
<asynchronous suspension>
#16     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:153:19)
<asynchronous suspension>

[✓] Flutter (Channel stable, 3.24.0, on macOS 15.1 24B5009l
    darwin-arm64, locale en-UA)
    • Flutter version 3.24.0 on channel stable at
      /Users/sokoleuk/Documents/flutter
    • Upstream repository
      https://github.com/flutter/flutter.git
    • Framework revision 80c2e84975 (2 weeks ago), 2024-07-30
      23:06:49 +0700
    • Engine revision b8800d88be
    • Dart version 3.5.0
    • DevTools version 2.37.2

[✓] Android toolchain - develop for Android devices (Android
    SDK version 35.0.0)
    • Android SDK at /Users/sokoleuk/Library/Android/sdk
    • Platform android-35, build-tools 35.0.0
    • Java binary at: /Applications/Android
      Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      17.0.10+0-17.0.10b1087.21-11609105)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.4)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15F31d
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google
      Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2024.1)
    • Android Studio at /Applications/Android
      Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      17.0.10+0-17.0.10b1087.21-11609105)

[✓] VS Code (version 1.92.1)
    • VS Code at /Applications/Visual Studio
      Code.app/Contents
    • Flutter extension can be installed from:
      🔨
      https://marketplace.visualstudio.com/items?itemName=Dar
      t-Code.flutter

[✓] Connected device (4 available)
    • iPhone 15 Pro (mobile)          •
      7C01BB44-26FD-4492-BBB4-47B0C3D5CADF • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-17-5 (simulator)
    • macOS (desktop)                 • macos
      • darwin-arm64   • macOS 15.1 24B5009l darwin-arm64
    • Mac Designed for iPad (desktop) • mac-designed-for-ipad
      • darwin         • macOS 15.1 24B5009l darwin-arm64
    • Chrome (web)                    • chrome
      • web-javascript • Google Chrome 127.0.6533.100
    ! Error: iPad (Iliusha) is not available because it is
      unpaired. Pair with the device in the Xcode Devices
      Window, and respond to any pairing prompts on the
      device. (code -29)

[✓] Network resources
    • All expected network resources are available.

• No issues found!

Flutter Application Metadata
Type: malformed
Version: null
Material: true
Android X: false
Module: false
Plugin: false
Android package: null
iOS bundle identifier: null
Creation channel: null
Creation framework version: null

Closing as duplicate of https://github.com/flutter/flutter/issues/98066


Module

Don't know how Drupal::currentUser and Drupal::service work together so I prefer to separate them


[Bug] Commissioning error occurs with TC-OO-2.4 (Semi-automated).

Describe the bug
When I run the following test, an error occurs. Commissioning was successful with TC-OO-1.1 but failed with TC-OO-2.4.

Steps to reproduce the behavior
Only SDK YAML Test was performed.
Expected behavior
No response
Log files
th_light_log.log
PICS file
No response
Screenshots
No response
Environment
TH version 2.10+spring2024
TH OS ubuntu 22.04 lts
Remote PC OS:Windows 10
Additional Information
No response

Hi @HirokiOgawa1129 Could you try with the new version?
Please, follow the steps bellow:

cd ~/certification-tool
./scripts/stop.sh
./scripts/ubuntu/auto-update.sh v2.10.1+spring2024
./scripts/start.sh

I had some time, so I updated the test harness and checked it. An error has occurred. An error has occurred on Commission DUT to TH.
Uploading UI_Test_Run_2024_08_29_09_02_22.log…

@rquidute any updates on this?

I was not able to reproduce this issue


Absolute position custom Portal for tooltip, menu, popover

Feature request
I am not sure if this is a bug or a feature request but it relates to https://github.com/radix-ui/primitives/issues/760
Overview
Making absolute "custom" Portal works with element that are allowing it (e.g. tooltip, menu, popover,...).
The following code only works if the "custom" Portal is position at the top left of the view screen (e.g. fixed)
  <Tooltip.Root>
    <Tooltip.Trigger />
    <Portal.Root containerRef={portalRef}>
      <Tooltip.Content portalled={false}>
       Content
      </Tooltip.Content>
    </Portal.Root>
  </Tooltip.Root>

The sandbox to show the problem is here.
Examples in other libraries
https://chakra-ui.com/docs/overlay/popover#rendering-the-popover-in-a-portal
https://chakra-ui.com/docs/components/portal
Who does this impact? Who is this for?
This is a little bit more advance since it requires a custom Portal but I think all user would benefit from this.
Additional context
Thank you for the great work on Radix UI! Let me know if you need help.

Yep! That's the one! Shall we close this as a duplicate of that? It seems once that is fixed the example in this issue should work?

Closing as duplicate of #370


THE BIG ONE.

Global branch into the dev branch. :earth_asia:

https://media.giphy.com/media/pwQdvTbFhds3e/giphy.gif
https://media.giphy.com/media/ueXmX9280F54Y/giphy.gif

Was there any conflicts in this merge you had to solve manually @angaither?

The code looks good. Will do another test this by building it locally.

@sergii-tkachenko nope, no conflicts

Ok, the build looks good! :+1:


💙 new drop

:zap: show whirls and chroma in landing
:wrench: new drop is whirls

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type

[ ] Bugfix
[ ] Feature
[ ] Refactoring
[x] The ususal

Context
New drop is Whirls
Did your issue had any of the "$" label on it?

[ ] My DOT address: Payout

Copilot Summary

🤖[deprecated] Generated by Copilot at 686db40
This pull request updates the generative NFTs carousel and the Whirls collection page. It adds more collection ids to the useCarouselGenerativeNftEvents function in CarouselTypeGenerative.vue and changes the nuxt-link component in UnlockableLandingTag.vue to match the new collection name and URL.

🤖[deprecated] Generated by Copilot at 686db40

useCarousel adds
more collections to display
diverse NFTs shine

link #8538

Let's merge this one first

Updated in https://github.com/kodadot/nft-gallery/pull/8553/commits/fb89dcef8ad4e32243426798d1a28a9b15456711


NameError: Name MNIST is not defined

I am following the Deep MNIST tutorial. After copy-pasting code till here, I get a NameError. The exact output is
Traceback (most recent call last):
  File "Deep_MNIST.py", line 29, in <module>
    batch = mnist.train.next_batch(50)
NameError: name 'mnist' is not defined

This is my file-
x = tf.placeholder(tf.float32, shape=[None, 784])
y_ = tf.placeholder(tf.float32, shape=[None, 10])

W = tf.Variable(tf.zeros([784,10]))
b = tf.Variable(tf.zeros([10]))

sess.run(tf.initialize_all_variables())

y = tf.nn.softmax(tf.matmul(x,W) + b)

cross_entropy = tf.reduce_mean(-tf.reduce_sum(y_ * tf.log(y), reduction_indices=[1]))

train_step = tf.train.GradientDescentOptimizer(0.5).minimize(cross_entropy)

for i in range(1000):
  batch = mnist.train.next_batch(50)
  train_step.run(feed_dict={x: batch[0], y_: batch[1]})

correct_prediction = tf.equal(tf.argmax(y,1), tf.argmax(y_,1))
accuracy = tf.reduce_mean(tf.cast(correct_prediction, tf.float32))
print(accuracy.eval(feed_dict={x: mnist.test.images, y_: mnist.test.labels}))

Thanks!

Hi! Look a little earlier at the instructions, the first section is about loading the MNIST data. And you need to run the following before your snippet of code above:
from tensorflow.examples.tutorials.mnist import input_data
mnist = input_data.read_data_sets('MNIST_data', one_hot=True)

@hnarayanan I already have the MNIST_data directory(i had done it earlier)

Yes, but you need to load it in the context of the current python script that you're attempting to run. (In either case, this is a general support issue that I think will soon be moved to StackOverflow.)

@hnarayanan How do I load it in context? And also this is not on SO because my account is temporarily not being able to ask questions :P

@hnarayanan thanks for your help

had the same error, thanks.

Same problem, thanks!

Results:
runfile('C:/Users/3/Documents/Python Scripts/TensorFlow/mnist_basic1.py', wdir='C:/Users/3/Documents/Python Scripts/TensorFlow')
Extracting MNIST_data\train-images-idx3-ubyte.gz
Extracting MNIST_data\train-labels-idx1-ubyte.gz
Extracting MNIST_data\t10k-images-idx3-ubyte.gz
Extracting MNIST_data\t10k-labels-idx1-ubyte.gz
0.9199
Cut and Paste this:
from tensorflow.examples.tutorials.mnist import input_data
mnist = input_data.read_data_sets('MNIST_data', one_hot=True)
import tensorflow as tf
x = tf.placeholder(tf.float32, [None, 784])
W = tf.Variable(tf.zeros([784, 10]))
b = tf.Variable(tf.zeros([10]))
y = tf.nn.softmax(tf.matmul(x, W) + b)
y_ = tf.placeholder(tf.float32, [None, 10])
cross_entropy = tf.reduce_mean(-tf.reduce_sum(y_ * tf.log(y), reduction_indices=[1]))
train_step = tf.train.GradientDescentOptimizer(0.5).minimize(cross_entropy)
init = tf.global_variables_initializer()
sess = tf.Session()
sess.run(init)
for i in range(1000):
batch_xs, batch_ys = mnist.train.next_batch(100)
sess.run(train_step, feed_dict={x: batch_xs, y_: batch_ys})
correct_prediction = tf.equal(tf.argmax(y,1), tf.argmax(y_,1))
accuracy = tf.reduce_mean(tf.cast(correct_prediction, tf.float32))
print(sess.run(accuracy, feed_dict={x: mnist.test.images, y_: mnist.test.labels}))

i am getting this now
No module named 'tensorflow.examples.tutorials


Update gitleaks configuration & dependencies

Description

Bump poetry hook version
Make gitleaks mega-linter check only look at files in the PR
Update dependencies

License Acceptance

[x] This repository is Apache version 2.0 licensed and by making this PR, I am contributing my changes to the repository under the terms of the Apache 2 license.

Type of changes

[ ] Add/update a helper script
[ ] Add/update link to an external resource like a blog post or video
[ ] Bug fix
[ ] New feature
[x] Test updates
[ ] Text cleanups/updates

Checklist

[x] I have read the CONTRIBUTING document.
[x] All new and existing tests pass.
[ ] Any scripts added use #!/usr/bin/env interpreter instead of potentially platform-specific direct paths (#!/bin/sh is an allowed exception)
[ ] Scripts added/updated in this PR are all marked executable.
[ ] Scripts added/updated in this PR do not have a language file extension unless they are meant to be sourced and not run standalone. No one should have to know if a script was written in bash, python, ruby or whatever. Not including file extensions makes it easier to rewrite the script in another language later without having to change every reference to the previous version.
[ ] I have confirmed that any links added or updated in my PR are valid.

🦙 MegaLinter status: ❌ ERROR

Descriptor
Linter
Files
Fixed
Errors
Elapsed time

❌ ACTION
actionlint
1

1
0.05s

✅ COPYPASTE
jscpd
yes

no
1.84s

✅ EDITORCONFIG
editorconfig-checker
3

0
0.02s

✅ REPOSITORY
gitleaks
yes

no
0.07s

✅ REPOSITORY
git_diff
yes

no
0.01s

✅ REPOSITORY
grype
yes

no
10.47s

✅ REPOSITORY
secretlint
yes

no
0.89s

✅ REPOSITORY
trivy
yes

no
5.81s

✅ REPOSITORY
trivy-sbom
yes

no
4.58s

✅ REPOSITORY
trufflehog
yes

no
3.25s

✅ SPELL
lychee
2

0
0.71s

⚠ YAML
prettier
2

1
0.61s

✅ YAML
v8r
2

0
3.05s

✅ YAML
yamllint
2

0
0.31s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff
MegaLinter is graciously provided by


Loading abbreviations on plugin install

Hi. What is the usual way to persist the abbreviations list? I made a file with a list of abbr command calls, to be just sourced when I want to setup a new machine with my settings.
If there is no standard way of keeping abbreviations and other similar commands, it would be a nice feature to source some plugins files only once on installation (and update?).

@laughedelic I don't use abbreviations, but if I were you, I would create a "guarded" snippet that has all the abbr function calls and then sets a universal variable "on" so that the next time the snippet runs you skip running the abbr commands.
What do you think?

Hi! Sorry, I missed your comment.
This is, of course, a workaround. I was just thinking of some more convenient support from fisherman for this, like treating some conventionally named file in the plugin in a special way.
Anyway, it's not a big deal, so if you're not interested in such feature and there's no much demand for it, you can close the issue, I'm going to use this workaround for myself.

I personally don't use abbr (avoid it rather), so it's not that important for me, but your idea could be completely implemented via a plugin and I am sure others would benefit from it, since abbr is a popular command.

but your idea could be completely implemented via a plugin and I am sure others would benefit from it, since abbr is a popular command.

My point was a bit more general than just a special treatment of abbr. I mean more like a way for a plugin to "initialize" on install, which is a one time action not repeated on every fish load.

@laughedelic Yes, I see what you mean now. I am not against it, if someone wants to implement this and send a PR, I would be glad to help debug it or review it.
I'd personally prefer to keep what plugins can and can't do to a bare minimum, but that's just me. I want fisherman to evolve and adapt to whatever you and other users want, that's why I am still helping to maintain the project nowadays.
Lately, I like fin more, but even fin had to make some compromises in the name of backward compatibility. Maybe when I get some free time I'll start something new with a different set of ideals.


Nil options and nested schema oddity

When you pass in a nil for an option value the non-nil values are bubbled to the top of the defined options list for the nested schemas.
In this example there's two nested schemas but the problem only needs one.
schema = Dry::Validation.Schema do
  configure do
    option :foo
    option :bar
    option :fizz
  end

  required(:data).schema do
    required(:attributes).schema do
      required(:buzz).filled
      validate(buzz?: [:buzz]) do |value|
        p foo: foo, bar: bar, fizz: fizz
      end
    end
  end

  # validate(data?: [:data]) do |value|
  #   p foo: foo, bar: bar, fizz: fizz
  # end
end

schema.with(foo: 'foo', bar: 'bar', fizz: 'fizz').call(data: {attributes: {buzz: 'buzz'}})
# {:foo=>"foo", :bar=>"bar", :fizz=>"fizz"}

schema.with(foo: nil, bar: 'bar', fizz: 'fizz').call(data: {attributes: {buzz: 'buzz'}})
# {:foo=>"bar", :bar=>"fizz", :fizz=>nil}

schema.with(foo: 'foo', bar: nil, fizz: 'fizz').call(data: {attributes: {buzz: 'buzz'}})
# {:foo=>"foo", :bar=>"fizz", :fizz=>nil}

schema.with(foo: 'foo', bar: 'bar', fizz: nil).call(data: {attributes: {buzz: 'buzz'}})
# {:foo=>"foo", :bar=>"bar", :fizz=>nil}

If you were to check on the values of the options outside of any .schema the nil would be in the correct place.
I'm using version 0.10.3.

Nested schemas use separate schema objects, and options from the top level schemas are not propagated to the nested schemas (at least not yet). I need to think about this a bit as I'm not sure how exactly I want to solve this. For now, using top-level validate block with a path to a value (using an array of symbols) should work (if that doesn't work, then it's an obvious bug and should be easy to fix, please let me know if that's the case).

This DSL is removed in dry-schema, which will be used for schemas in dry-validation 1.0.0. This means it won't be addressed and similar functionality can be achieved using the new rule system.


Rename file option missing

The rename file option is now missing in the files pane:

there is actually no rename anymore. We don't really have a rename api in VFS, I was doing a GET, then a PUT with the new name, but there are many different situations where that doesn't work as intended so I just removed it

Removed feature because it doesn't work well... closing for now


vsock: Incorrect number of bytes of data received from vsock on Windows

Describe the bug
A test script is running on the host, sending bytes of data over vsock. Another application that has developed with a wrapper for working with vsock receives this data on Windows guest.
The problem is that vsok on the WIndows side reads randomly more or less data than was sent from the Linux side.
TraceView logs:
LogSession0.txt
To Reproduce
On Linux host run this:
vsock_test.txt
On Windows guest run this:
client_test.txt
With this imported vsock wrapper:
winSock.txt
Expected behavior
Well, I kind of expect WIndows to receive exactly as many bytes over vsock as it is sent)
Screenshots
From Linux host:

From Windows guest:

Host:

Disto: "Linux Mint 21.1 (Vera)"
Kernel version: 5.15.0-91-generic
QEMU version: QEMU emulator version 6.2.0 (Debian 1:6.2+dfsg-2ubuntu6.15)
QEMU command line: launch from VirtManager app (i think qemu-system-x86_64 will be good)
libvirt version: 6.2.0
libvirt XML file for windows:
windows10.txt

VM:

Windows version: Windows 10 Pro Build 19041.vb_release.191206-1206
Which driver has a problem: viosock
last commit hash: 515a6a25f408192525587c90a1cad2d553c93c4f

Additional context
The problem disappears (for the current test) if you increase the buffer. But this approach to solving the problem does not seem right to me

Hello,
IMHO this is a feature, not a bug. The socket is of the SOCK_STREAM; type which means that data are being sent and received as a stream of bytes. Thus, sending **N** bytes in one sendcall does not imply their reception in onerecv` call. It depends on how quickly the data are transferred between the host and the VM.
You would need a datagram (message-based) socket, however, I do not think such sockets are supported by the Socket driver at the moment.


ISPN-11902 WriteBehindFaultToleranceTest.testBlockingOnStoreAvailabil…

…ityChange random failures

Test would fail if store was marked unavailable between
writing the SHARED and PRIVATE storage iterables

https://issues.redhat.com/browse/ISPN-11902

@wburns I need some more info here, I can't see the connection between the commit message/PR description and the code change :)

The code is right here https://github.com/infinispan/infinispan/blob/master/core/src/main/java/org/infinispan/interceptors/impl/CacheWriterInterceptor.java#L262
The problem is that the store is private and thus this method here will call running the SHARED writes and then afterwards with the PRIVATE ones. So it writes to the store and then is marked unavailable before it gets to the PRIVATE modifications, which is empty.
So by ignoring empty it makes this test pass, which is what the old code was doing that I removed.

I have reworked the persistence manager api for the put map use case and this PR is no longer needed - superseded by https://github.com/infinispan/infinispan/pull/8417


Support for Wordpress Multisite, ie no virtual hosts but multiple domains

We run a WPMU (wordpress multisite) with hundreds of domains. They all use the same log file but there are no virtual hosts.
Rows from log file:
<IP_ADDRESS>- - [08/Aug/2018:11:20:02 +0200] "GET /a-beginners-guide-to-making-fire/ HTTP/1.1" 200 20898 "-" "Mozilla/5.0 (compatible; Dataprovider.com;)" asite.co.uk/a-beginners-guide-to-making-fire/ <IP_ADDRESS>- - [08/Aug/2018:11:20:03 +0200] "GET /author/wp_admin/ HTTP/1.1" 200 25460 "-" "Mozilla/5.0 (compatible; Dataprovider.com;)" newsite.co.uk/author/wp_admin/ <IP_ADDRESS>- - [08/Aug/2018:11:20:04 +0200] "GET /ads.txt HTTP/1.1" 404 13427 "-" "Mozilla/5.0 (compatible; Dataprovider.com;)" alovelysite.co.uk/ads.txt <IP_ADDRESS>- - [08/Aug/2018:11:20:04 +0200] "GET / HTTP/1.1" 200 21667 "-" "Mozilla/5.0 (Linux; Android 5.1.1; SM-G925F Build/LMY47X) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/45.0.2454.94 Mobile Safari/537.36" othersite.co.uk/index.php

You can do this by doing some log preprocessing. Please take a look at #673 or at the examples section (virtual hosts) for how to distinguish those requests.

Closing this. Feel free to reopen it if needed.


Trailing / added to curl examples

When users click the copy button, it adds a trailing slash that is not visible in the example.
How it appears in the browser:

What gets copied to clipboard:
curl -X GET "https://api.lightstep.com/public/v0.2/ORGID/projects/PROJECTID/metric_alerts" \
 -H "accept: application/json" \

Not sure how to remove the \ or where that might be configured. Spend some time searching but I don't think I am searching for the right thing

Hello! Just seeing if this issue can be helped


Testament pointer breakdown in some translations.

Hi, thanks for this little handy script!
I noticed when doing a bulk build of all the Bibles that the testament combination is not working that well on line 13 so I would suggest the following fix
# load the list of books per/testament
testaments = bible_mod.get_structure()._books
# merge the books
books = []
for testament in testaments:
    books += testaments[testament]

This way it working even if there is not new or old testament books in the translation.
I have forked the repo and will be using it to setup a major update to the old getBible v1 API so not all the changes is that practical (since I am trying to hold to some v1 conventions), but if I run into any other issue I will be sure to let you know.

I have now forked this REPO, and have largely improved it to build a whole host of Bible JSON files. We have changed the structure, and now have Chapters, Books, and whole Translations.
We have also added a hash function to easy track changes in the Modules from Crosswire, and so update files in your applications. Review and contributions are welcome....
For those who are interested https://github.com/getbible/v2_builder see ya  :+1:

I would make a pull request here... but this REPO seems inactive for 3 years now.

Checkout the new https://github.com/getBible/librarian
It is also python based, and gives you access to the Crosswire Scripture Modules as an API, see in more on the API here: https://getbible.net/docs


Fix exception in example on first run

This adds db.create_all() to the main block of the example code. Otherwise, database operations error on the first run because none of the tables exist.

Closing from lack of response.


Update README.md

added section for Docs API

Hi, I can't add a reviewer for this change... can someone PTAL? Thx!

Thanks for the contribution!

removed mention of the app until the code gets in


DHCP server does not work because VM has the wrong mac address with canal CNI

It appears that the DHCP server is not able to issue leases because the mac address assigned to the VM is not actually set.
What happened:
DHCP failed to get a lease:
Starting network...
udhcpc (v1.23.2) started
Sending discover...
Sending discover...
Sending discover...
Usage: /sbin/cirros-dhcpc <up|down>
No lease, failing
WARN: /etc/rc3.d/S40-network failed

Also notice that the Mac address is not what I have configured: 52:54:00:93:17:63
$ ifconfig
eth0      Link encap:Ethernet  HWaddr 52:54:00:1F:59:33
          inet6 addr: fe80::5054:ff:fe1f:5933/64 Scope:Link
          UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
          RX packets:24 errors:0 dropped:0 overruns:0 frame:0
          TX packets:10 errors:0 dropped:0 overruns:0 carrier:0
          collisions:0 txqueuelen:1000
          RX bytes:2376 (2.3 KiB)  TX bytes:1332 (1.3 KiB)

What you expected to happen:
DHCP should get a lease.
How to reproduce it (as minimally and precisely as possible):
apiVersion: kubevirt.io/v1alpha2
kind: VirtualMachineInstance
metadata:
  name: testvm
spec:
  domain:
    devices:
      disks:
        - name: containerdisk
          volumeName: containervolume
          disk:
            bus: virtio
        - name: cloudinitdisk
          volumeName: cloudinitvolume
          disk:
            bus: virtio
      interfaces:
      - name: default
        bridge: {}
        macAddress: "52:54:00:93:17:63"
    resources:
      requests:
        memory: 64M
  networks:
  - name: default
    pod: {}
  volumes:
    - name: containervolume
      containerDisk:
        image: kubevirt/cirros-registry-disk-demo
    - name: cloudinitvolume
      cloudInitNoCloud:
        userDataBase64: SGkuXG4=

Run it and connect to the console:
kubectl apply -f vm.yaml
virtctl console testvm

Hi @justinbarrick just a quick question you are using k8s or openshift?
If you are using k8s can you please tell me what network plugin you are using?

@justinbarrick what version of kubevirt you are using?
I test it using your yaml and everything works as expected
[root@localhost]$ ./cluster/virtctl.sh console testvm
Successfully connected to testvm console. The escape sequence is ^]

login as 'cirros' user. default password: 'gocubsgo'. use 'sudo' for root.
testvm login: cirros
Password:
$
$ ip a
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue qlen 1
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
    inet <IP_ADDRESS>/8 scope host lo
       valid_lft forever preferred_lft forever
    inet6 ::1/128 scope host
       valid_lft forever preferred_lft forever
2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1450 qdisc pfifo_fast qlen 1000
    link/ether 52:54:00:93:17:63 brd ff:ff:ff:ff:ff:ff
    inet <IP_ADDRESS>/24 brd <IP_ADDRESS> scope global eth0
       valid_lft forever preferred_lft forever
    inet6 fe80::5054:ff:fe93:1763/64 scope link
       valid_lft forever preferred_lft forever
$

I am using latest Kubevirt (based on master). My network plugin is canal.

Yeah, this seems to be an issue with canal. I tried on flannel and calico and it is working. We use calico in production, so I'm all set here, but the issue should probably get fixed.

/kind bug

I will take this one

@justinbarrick ping?


v1/v1beta3 API usage does not appear in Cloud Console

It's visible here:
https://console.developers.google.com/appengine?project=
but not here:
https://console.developers.google.com/apis/api/datastore.googleapis.com/overview?project=

Not for me

The first link (if you add your project ID) should show usage for Datastore Entity Writes, Datastore Entity Deletes, Datastore Read Operations, and Datastore Small Operations -- does that show up for you?
It unfortunately does not show the current rate of these usages.

I'm experiencing this as well. App Engine shows data for v1beta2 requests but nothing for v1beta3. API Manager shows an empty graph for v1/v1beta3

Is this going to be fixed? Why is Datastore the only API that doesn't have a graph of requests?

Yeah, that's very frustrating: google shutting down working API, and replaces with new API without "beta" label but whcih simply does not work. We are doing crazy things running API without monitoring in production.
@richardkazuomiller
Please upvote hee if you have not yet: https://code.google.com/p/google-cloud-platform/issues/detail?id=82&q=product%3DDeveloperConsole&colspec=ID Type Product Status Stars Summary Priority Owner Log#makechanges

Closing in favor of linked issue above.


reconcile issue on annotation updates

Pull request checklist

Pull request type

Please check the type of change your PR introduces:

[x] Bugfix
[ ] Feature Enhancement
[ ] Test Automation
[ ] Code Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Community Operator listing
[ ] Other (please describe):

What is the current behavior?

What is the new behavior?

How risky is this change?

[ ] Small, isolated change
[ ] Medium, requires regression testing
[ ] Large, requires functional and regression testing

Image: quay.io/badri_pathak/ibm-spectrum-scale-csi-operator:reconcilefix_v20

Regression passed:

@saurabhwani5 Please verify upgrade scenarios and optional config in the OCP also.


Frozen "Save File" dialog (mac os)

Thanks for this great library, I love how quick and simple it is, I'm having some trouble with the save dialog option:
if (ImGui::MenuItem("Save as...")) {
              auto destination = pfd::save_file("Select a scene file", currentScenePath).result();
              if (!destination.empty()) Application::getSceneManager().saveScene(destination);
}

The save dialog shows up correctly, but upon clicking "save" it freezes for several seconds. After waiting for a while it becomes active again (meaning you can type and click the buttons). Clicking again save repeats the process (gets frozen).
The same thing happens if you click `cancel instead. The file never gets written/saved

More info: It looks to work OK when choosing an existing file (overwrite)

Ha, I had the same issue.


Temporary ignoring of vulnerabilities

First of all, thanks for the great package. It is a very useful tool in keeping our code safe, much appreciated.
My feature request is inspired by the fact that we are using pip-audit in our CI/CD pipeline and this means that if a vulnerability is detected, this has to be dealt with immediately. Sometimes there is no "proper" fix available yet and we resort to simply ignoring the vulnerability with --ignore-vuln. This doesn't bother me much, but I would prefer it if this ignore could be made temporary, so that we will be forced to revisit the issue at a later date.
Keen to hear your thoughts on this idea. One of our team might even be able to contribute to the implementation, if desired. I could also just be not seeting some existing feature that would solve our problem.

Hi @KeithWM, thanks for the feature request!
Out of curiosity: is your CI/CD pipeline built on GitHub Actions and, if so, are you using pypa/gh-action-pip-audit?
The reason why I ask is because this kind of feature might be a better fit for the action, rather than pip-audit itself -- pip-audit itself currently has no notion of its own time, and encoding "fix by" metadata into its CLI arguments might be a little bit clunky 🙂

Hi Woodruff,
No, we are using Bitbucket pipelines.
How would you build the feature into the github action? Maybe a similar idea would be possible for Bitbucket pipelines.

How would you build the feature into the github action? Maybe a similar idea would be possible for Bitbucket pipelines.

For GitHub Actions, we could probably do something like this:
- uses<EMAIL_ADDRESS>  with:
    ignore-vulns: |
      PYSEC-AAAA-BBBB:YYYY-MM-DD
      CVE-AAAA-BBBB:YYYY-MM-DD

i.e. each ID listed under ignore-vulns could be listed with an optional YYYY-MM-DD date, after which the ignore rule is no longer respected.
That being said, I find that pretty clunky, and I'm not a huge fan of adding syntax to the action that isn't also present in the CLI 🙂
Ultimately, this kind of statefulness might be outside of pip-audit (and the action's) scope: I think the "right" way to do this might be to have some additional periodic workflow in your CI/CD that checks a custom JSON/YAML/whatever file you define, and invokes pip-audit with the appropriate --ignore-vuln flags depending on the date. Do you think that would work for your case?

I think you're right that it is better for pip-audit to be agnostic of time and date. In Bitbucket pipelines, I think we could do some shell scripting to first populate a list of --ignore-vuln options based on the datetime and then add these (if any) to the pip-audit call.
Maybe a feature that could lie within pip-audit is that you can specify to ignore a vulnerability until a fix is available?

Maybe a feature that could lie within pip-audit is that you can specify to ignore a vulnerability until a fix is available?

Yeah, this is possible (although we've had some design concerns in the past about allowing users to ignore vulnerabilities by default). #243 has some more context 🙂
TL;DR there is that users might pass --ignore-unfixed or similar just to get things working, and then subsequently ignore serious vulnerabilities that are "unfixed" but can be remediated in other ways (like outright removal, or downgrading, etc.).

Good points. There is a big difference though between a blanket --ignore-unfixed and a --ignore-vuln-until-fixed ABC-123. Even then, that could allow packages that never fix their vulnerabilities to remain ignored forever. That's why I'd like the user to be able to set a date, thereby actively acknowledging how long they are willing to run the risk posed by the vulnerability. I did come up with some scripting that would (probably) work in our Bitbucket CI/CD, but it's really clunky.

CC @di for thoughts -- I'm pretty ambivalent 🙂

I don't like the "until fixed" option at all, it puts you at the mercy of the maintainers of the dependency package. I've made a quick mockup of what I think might be nice in a fork. I will create a PR as a suggestion.


ENH: add function to split the internal name field in newick into name and support value

#2045
Summary by Sourcery
Add a new function to split internal node name fields in Newick format into separate name and support values, and implement corresponding tests to ensure correct functionality.
New Features:

Introduce a function split_name_and_support to handle Newick format internal node name fields that contain both a name and a support value.

Tests:

Add parameterized tests for the split_name_and_support function to verify its behavior with various input cases, including valid and invalid formats.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>1
Details

18 of 18 (100.0%)  changed or added relevant lines in 1 file are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.001%) to 91.929%

Files with Coverage Reduction
New Missed Lines
%

src/cogent3/maths/scipy_optimize.py
2
84.92%

Totals

Change from base Build<PHONE_NUMBER>6:
-0.001%

Covered Lines:
32358

Relevant Lines:
35199

💛  - Coveralls


Signin with github for accout sync not working in VS Code insider

Does this issue occur when all extensions are disabled?: No

VS Code Version:  61ba389b
OS Version: Ubuntu 22.04LTS
VS Code Insider from Snap Store

Steps to Reproduce:

Accounts
Sign in to Sync > Github

/gifPlease

Thanks for reporting this issue! Unfortunately, it's hard for us to understand what issue you're seeing. Please help us out by providing a screen recording showing exactly what isn't working as expected. While we can work with most standard formats, .gif files are preferred as they are displayed inline on GitHub. You may find https://gifcap.dev helpful as a browser-based gif recording tool.
If the issue depends on keyboard input, you can help us by enabling screencast mode for the recording (Developer: Toggle Screencast Mode in the command palette). Lastly, please attach this file via the GitHub web interface as emailed responses will strip files out from the issue.
Happy coding!

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Allow showing a loading spinner instead of showing the console unless there is an error

I set my console_timeout to 250 because many of the commands I run end up showing the console, so I'd rather see it quickly.
However, most of the time I can just dismiss it. It will also close automatically. So that means it's not really of any use to me other than for the fact that it lets me know that something's happening and Neogit isn't frozen.
That's why I think this should be Neogit's behavior:

Show a spinner whenever a command starts that is taking long (short countdown of ~100ms to start?)

This could be made configurable
Could also be offered as a statusline component

If the underlying command exits with 0, just stop showing the spinner, since Neogit will change its UI accordingly anyway
Show the console only if there is an error

Again, this could be made configurable

Yeah, I had a similar thought the other day. Is this something you want to take a crack at?

I can do it, but WDYT about the design alternatives?

Show a spinner somewhere within the Neogit status buffer

If so, where?

Offer it as a statusline component
Both?
Allow configurable spinner?

I can make my own assumptions/decisions, but happy to hear what you think :)

You could probably get away with using a floating window that has the same background color as the buffer, that doesn't get focused on creation. Maybe even just vim.notify() with some extra arguments?
Or, echo/redraw so it appears in the cmd line. The Refs buffer does that when loading cherries for a ref.
Statusbar could be fine, but I havent messed with that before.
I wouldn't put it as -part- of the status buffer though. That would get expensive to rerender just for a spinner

You could probably get away with using a floating window that has the same background color as the buffer

What do you mean by this? A sort of overlay on top of the Neogit status window?

Statusbar could be fine, but I havent messed with that before.

I actually think this is the easiest approach:

Offer a way to only show the console on nonzero exit codes
Offer a variable or Lua function that can be used in a statusline, or in a statusline plugin

Example:
-- Neogit config
auto_show_console_error_only = true

-- Lualine example with lazy.nvim
return {
  "nvim-lualine/lualine.nvim",
  config = function()
    local lualine = require("lualine")
    lualine.setup({
      sections = {
        lualine_a = { "mode", require("neogit.process").status },
      },
    })
  end,
}

Then it's mostly done.

You could probably get away with using a floating window that has the same background color as the buffer

What do you mean by this? A sort of overlay on top of the Neogit status window?

Yeah, like that. Noice (and fidget, nvim-notify, cmp, ...) just place a floating window. Without a border it would blend in very smoothly.
I think showing on error-only would make sense. Since I added some logic to check for git hooks a few days ago, the "timer" idea doesn't really make sense to me. Like, I suppose if something is taking a long time you might want to see why, but besides a hook I'm not sure what would take a long time.
Would the status line get repainted frequently enough to make a spinner meaningful? IIRC it's a poll model, not a push model, so if it stopped polling for updates you might get stale state shown. But maybe I'm wrong 🤷🏼 Regardless, I'm not against it.

Here's a little POC for a spinner in the message window, if you like:
api.nvim_create_user_command("SpinnerPOC", function(args)
  local pattern = {
    "-",
    "\\",
    "|",
    "/"
  }

  local function setInterval(interval, callback)
    local timer = vim.uv.new_timer()
    timer:start(interval, interval, function()
      callback()
    end)
    return timer
  end

  local function clearInterval(timer)
    timer:stop()
    timer:close()
  end

  local count = 0
  local timer = setInterval(50, vim.schedule_wrap(function()
    count = count + 1
    vim.cmd(string.format("redraw | echomsg '%s Running Process'", pattern[(count % #pattern) + 1]))
  end))

  vim.defer_fn(
    function()
      clearInterval(timer)
      vim.cmd("redraw | echomsg ''")
    end,
    3000
  )
end, {
    desc = "spin POC",
  })

So I've been exploring using :h vim.notify for this. It seems like the default Neovim implementation of vim.notify does not allow one to update an existing notification. So if I make a vim.notify call to update the spinner for each one of its frames, and then I happen to have a plugin like nvim-notify installed, I get this:

That means that if I want to use vim.notify I should probably choose between:

Showing a static message (no spinner) for users without any notify plugins, or
Targeting a specific notify replacement plugin (like nvim-notify), or
Detecting which plugin is installed and doing something different depending on that

Would probably need to support mini-notify.nvim, nvim-notify...
Could decide to show a spinner if the user does not have any plugin enabled, though
But I think it would be a mess

The reason I'm thinking about this is because I don't enjoy the idea of showing our own notification buffer, because I know users of notify replacement plugins would enjoy a notification in their own format.
I will explore the statusline idea for a bit now.

We used to have a bespoke notification component that I removed a while ago because it was from a time before the vim.notify() interface, and the proliferation of those plugins.
All sounds reasonable - just showing a popup without a nifty spinner doesn't really communicate what I think you have in mind here, and... we can already do that, so thats no fun.
Lemme know how the statusline idea goes :)

Basically something like this:
_G.neogit_progress_statusline_frame = "⠋"

local function on_neogit_process_start()
  local spinners = { "⠋", "⠙", "⠹", "⠸", "⠼", "⠴", "⠦", "⠧", "⠇", "⠏" }
  local index = 1

  local timer = vim.loop.new_timer()
  timer:start(
    0,
    100,
    vim.schedule_wrap(function()
      _G.neogit_progress_statusline_frame = spinners[index] .. " Committing..."
      index = (index % #spinners) + 1
      vim.cmd("redrawstatus")
      -- If lualine is installed: require("lualine").refresh()
    end)
  )

  local function on_neogit_process_end()
    _G.neogit_progress_statusline_frame = ""
    vim.cmd("redrawstatus")
    -- If lualine is installed: require("lualine").refresh()
    timer:stop()
    timer:close()
  end

  vim.defer_fn(on_neogit_process_end, 3000)
end

vim.api.nvim_create_user_command("NeogitProgressStart", on_neogit_process_start, { desc = "" })

function neogit_progress()
  return _G.neogit_progress_statusline_frame or ""
end

Sample usage in Lualine:

Sample usage in a regular statusline:
vim.o.statusline = "%!v:lua.neogit_progress()"

I'm just exploring, please don't hesitate to say no to my ideas :smile:

Fixed in https://github.com/NeogitOrg/neogit/pull/1551 ! <3


[Bug] Refreshing profile with DPM closed does not work

Description
After having closed Desmos Profile Manager (DPM) on my device, if I refresh my profile page all the data disappear and cannot be loaded properly. No error is shown inside the console.
Steps to reproduce:

Log with DPM
Close DPM from the mobile device
Refresh the profile page

Screenshot

Fixed with #4


Change upgrade URL to extension manifest URL instead of the upgrade service redirect

Summary
Resolves #3823
Several problems are being addressed regarding the Upgrade? column on the Installed Extensions tab.
Prior to this PR, a ##.##.## image is generated by the Update Service based on the existence of any reported instance of an extension version greater than the one currently installed.  That image would be used to create an image link to a redirect URL in the Update Service that is currently not functional.  Therefore, the user experience is not only misleading but also broken.
The system is also flawed in the sense that there are often valid use cases for there being a version of an extension that has been reported to the Update Service that is invalid or under development (i.e., v10 extensions for DNN).  Therefore, the version image created by the Update Service results in a false positive (e.g. "99.99.99" or "10.00.00").
Therefore, the PR still checks to see that a potential upgrade is available, but instead of rendering a version image, the UI simply renders a "Check" text link that now points to the URL contained in the extension manifest instead of the upgradeURL (the broken redirect URL referenced earlier).
With these changes, we could now update all core extension URLs to point to the appropriate URLs.  Also, we should notify extension vendors of this change so they can leverage this new tie-in in a different way if desired.
See below for a visual of the UI changes.

This change renders the update service and the associated community metrics useless.  As such, I do not approve this change

@mitchelsellers okay, it appears we had a gross misunderstanding among the leadership team then.  Let's discuss when you return from vacation.

Thanks for the quick conversation @mitchelsellers - I'll push a commit shortly to add the image back in, but I'll leave the URL as is.  Enjoy your vacation!

Okay, changes pushed and the version image is now back in.


Refresh Token Does Not Return Nonce

Issue / Steps to reproduce the problem
Calling Refresh Token with a nonce in the request does not return a nonce.
OpenID Connect Core Section 2 states:

If present in the Authentication Request, Authorization Servers MUST include a nonce Claim in the ID Token with the Claim Value being the nonce value sent in the Authentication Request.

Relevant parts of the log file
2018-03-27 16:29:45.182 -05:00 [INF] ValidatedAuthorizeRequest
{
  "ClientId": "native.code",
  "ClientName": "Native Code",
  "RedirectUri": "redacted-app://oauth-callback/",
  "AllowedRedirectUris": [
    "redacted-app://oauth-callback/"
  ],
  "SubjectId": "redacted",
  "ResponseType": "code",
  "ResponseMode": "query",
  "GrantType": "authorization_code",
  "RequestedScopes": "openid redacted offline_access",
  "State": "Sulxc0EcL85Hu_gbQiK7ATf7kG9jCQKiwfxf3Owd_cc",
  "Nonce": "okfVh2Fd2up_lmJPQ_YcsG6JXUDdn6LAUEIlsny9jEE",
  "Raw": {
    "nonce": "okfVh2Fd2up_lmJPQ_YcsG6JXUDdn6LAUEIlsny9jEE",
    "response_type": "code",
    "code_challenge_method": "S256",
    "scope": "openid redacted offline_access",
    "code_challenge": "onjmf4iyxfZyl182EOBDZQ7E3tRqrxSZYCUQpFMF3bo",
    "redirect_uri": "redacted://oauth-callback/",
    "client_id": "native.code",
    "state": "Sulxc0EcL85Hu_gbQiK7ATf7kG9jCQKiwfxf3Owd_cc"
  }
}
2018-03-27 16:29:49.734 -05:00 [INF] Invoking IdentityServer endpoint: IdentityServer4.Endpoints.TokenEndpoint for /connect/token
2018-03-27 16:29:49.743 -05:00 [INF] Token request validation success
{
  "ClientId": "native.code",
  "ClientName": "Native Code",
  "GrantType": "refresh_token",
  "RefreshToken": "fbe9280ef6ac22a04b605688929d842c4db72fa241b0161bcc37d22d29f638e7",
  "Raw": {
    "refresh_token": "fbe9280ef6ac22a04b605688929d842c4db72fa241b0161bcc37d22d29f638e7",
    "scope": "openid redacted offline_access",
    "redirect_uri": "redacted://oauth-callback/",
    "client_id": "native.code",
    "grant_type": "refresh_token"
  }
}

Isn't that statement from the spec at the time the code is being exchanged for the access & refresh token? I don't think that's at the time a refresh token is being exchanged for a new access token.

@WilliamDenniss - Reading back through, this makes sense as to not pertaining to a refresh token request

So then can we close this issue?

Agreed. This is how Google has implemented it too.
When the point was raised earlier, I thought the error was on the authorization_code exchange, not refresh_token. Looking at the spec, it is a little ambiguous, but I think the intention is that it's only the code exchange (and that's how everyone has implemented it).
Thanks for the discussion!


Add auto-reset points to visibility record

You can talk to @longquanzheng and @vancexu about the details.

code path for adding auto-reset points into mutableState: https://github.com/uber/cadence/blob/e58ce1a84859b3dec6a2ed256a63d01d168f207a/service/history/mutableStateBuilder.go#L1880


Support context menu with copy options in strings view

In strings view, right clicking currently does nothing.  It should bring up a context menu with options to copy or copy with a transform (built-in or custom).

Just noting that double-right clicking jumps to the string in linear view (which also seems like unexpected UX behavior)

Would also like to have an option to toggle sorting by address or by string

Resolved in builds >= 3.1.3616


encoding options

fs.readFileSync and fs.writeFileSync encoding options passed with an object
There was a bug in non-latin characters that will convert them to html entities

@cantecim Thanks! We appreciate your PR.


NOT enough space to finish installation

Hey unkn0wn,
What is your solution to finish the installing of HTK? It seems like not enough workspace.
Regards

im not sure what you mean by not enough workspace but if you mean not enough storage in your system then i would suggest running apt clean and apt autoclean and removing any files you dont use


TS 1.10 Azure F5Telemetry_event_CL does not exist.

When using the Azure Log Analytic Consumer, there does not seem to be a F5Telemetry_event_CL.  The example report includes this as the base for the report queries. The other fields do not exist in any of the other tables.
F5Telemetry_event_CL
| where event_source_s == "request_logging"
|summarize AggregatedValue = count() by bin(TimeGenerated, 1h)
| sort by TimeGenerated desc

OR
F5Telemetry_event_CL
| where isnotempty(attack_type_s)
|summarize AggregatedValue = count() by bin(TimeGenerated, 1h)
| sort by TimeGenerated desc

The event type exists in the constants.js:98:
    EVENT_TYPES: {
        DEFAULT: 'event',
        AVR_EVENT: 'AVR',
        APM_EVENT: 'APM',
        ASM_EVENT: 'ASM',
        AFM_EVENT: 'AFM',
        LTM_EVENT: 'LTM',
        CGNAT_EVENT: 'CGNAT',
        SYSLOG_EVENT: 'syslog',
        EVENT_LISTENER: 'event',
        SYSTEM_POLLER: 'systemInfo',
        IHEALTH_POLLER: 'ihealthInfo'
    }

Environment

Telemetry Streaming Version: 1.10
BIG-IP Version: 14.1.2 (Azure PAYG)

Summary
A clear and concise description of what the bug is.
Please also include information about the reproducibility and the severity/impact of the issue.
Steps To Reproduce
Steps to reproduce the behavior:

Submit the following declaration:

{
    "class": "Telemetry",
    "controls": {
        "class": "Controls",
        "logLevel": "info"
    },
    "My_System": {
        "class": "Telemetry_System",
        "systemPoller": {
            "interval": 60
        }
    },
    "My_Listener": {
        "class": "Telemetry_Listener",
        "port": 6514
    },
   "My_Consumer": {
       "class": "Telemetry_Consumer",
       "type": "Azure_Log_Analytics",
       "workspaceId": "blah",
       "passphrase": {
           "cipherText": "secret"
       }
   }
}

Import Azure Log Analytic Report Example and view following error:

'where' operator: Failed to resolve table or column expression named 'F5Telemetry_event_CL'

If issue persists, please open a support ticket.

Request id: 8f1070d7-4c27-4ac7-8c15-3f5b15294221

Expected Behavior
F5Telemetry_event_CL should exist.
Actual Behavior
F5Telemetry_event_CL does not exist.
Including a screenshot of all the events that are sending.  None of the events include the fields for attack_type_s or event_source_s , etc.

Do you have any BIG-IP features that are using your TS event listener as a logging destination?
https://clouddocs.f5.com/products/extensions/f5-telemetry-streaming/latest/event-listener.html

Configured in ASM and AFM.  Waiting on AUTOTOOL-768 to spool up again and test.

It looks like the example is outdated and the F5Telemetry_event records have now been broken up into much more specific event types (e.g. F5Telemetry_LTM). I have added AUTOTOOL-1503 to our internal product backlog to update the example.

This issue has been resolved as part of the 1.13.0 release.


Image action with incorrect cursor position (v1.11.2)

on version v1.11.2
Maybe it is just me but If I include an image on the editor the following syntax is being inserted:
"![](", "http://)"

instead of:
"![](http://", ")"

In my case I removed the "http://" completely since I usually copy and paste urls from the browser url bar.

This has to do with the way other settings work, like the one that prompts for user input for the URL. I hope to improve this in version 2 of SimpleMDE.


feat: hasura allow list plugin

Description
Add a new plugin to generate metadata files for hasura
Related #7476

Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[x] Added jest test suite to verify plugin functionality

Test Environment:

OS: Windows
@graphql-codegen/hasura-allow-list:
NodeJS: 16

Checklist:

[x] I have followed the CONTRIBUTING doc and the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

Further comments
See the issue for any discussion.

@charlypoly I pushed a change. Did not manage to get the plugin description to show up in the plugin hub screen, despite my best efforts. Probably missing something.

@BenoitRanque It's normal, our plugins doc build system is fetching data (description is part of it) from NPM.
Your package is not published yet but the description should appear in the future (I'll check)

@charlypoly I pushed a change. Did not manage to get the plugin description to show up in the plugin hub screen, despite my best efforts. Probably missing something.

It's good to go, let's release! 📦
Thank you for your contribution!


runtime: clean up last of -Wqual-cast warnings

This fixes up the remaining cast qualifier warnings from GCC 6.  Use
multiple casts to adjust the const qualification.  Prefer C++ style
casts.  NFC.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@swift-ci please test and merge

Could it be worth activating this compiler flag by default to prevent future regressions (assuming it isn't already enabled)?

@swift-ci please clean test Linux platform

Build failed
Swift Test Linux Platform
Git Sha - 2952d464594bcc3da042ba7dd886d6c4730eb99f

The clang-import failure seems unrelated

@swift-ci please smoke test Linux platform

@swift-ci please test Linux platform

@gparker42 ping

@jrose-apple think you could poke @gparker42 for a review?  This is a trivial (NFC) change :-).

Ugh, seems that there are more of these that are showing up overtime.  I think that @hughbe's idea of enabling this by default is a great idea.  Ill adjust the patch for the additional cases.

@swift-ci please test

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 7bd2256120ccf63a6dc3603774a32c2c96614ca5

@swift-ci please clean test Linux platform

Sorry, got distracted. I didn't fix the extra inhabitant warnings because I suspected that the cast warning was a sign of a real bug. Unfortunately it doesn't look like I filed a bug report about that bug, and I can't remember offhand exactly what I was worried about. (Some case where we're storing an extra inhabitatant on a type that doesn't have space for one, maybe.)
Otherwise this looks fine.

The inhabitant one is now explicitly removing the const on the type, so it should be equivalent to the existing code.  This set of fixes just explicitly either preserves or drops the const qualifier or the signed qualifier on a char type.


notifyItemMoved method

Hey,
im looking for an alternative method for
notifyItemMoved(fromPosition, toPosition);
I tried:
notifyParentItemChanged(fromPosition);
notifyParentItemChanged(toPosition);
But it didnt work. Any solutions?

Right now we haven't made the Parent/Child moved notify methods. The best I can suggest is a poor mans moving:
remove the parentItem
notifyParentItemRemoved
add the parentItem to new position
notify ParentItemInserted

Note, notifyParentItemChanged does not allow any "structural changes" which moving a parent from one point to another would be.
We do have plans for creating notifyMoved methods that will work, I'll make a separate issue for those to keep better track soon.

Hmm,
notifyItemMoved(fromPosition, toPosition)
for parent-items works. How do i swap two child items?
Object listItem = getListItem(i);
if(listItem instanceof ParentWrapper){
// DO PARENT STUFF
}else{
//????
}
I cant wrap the listItem into a ChildWrapper or Childobject.
So lastParent.getChildItemList().add(//CHILDOBJECT NEEDED)
doesnt work.

This may have already been figured out but in
lastParent.getChildItemList().add(//CHILDOBJECT NEEDED)
the child object that you need is in fact the listItem Object variable you pulled out.
Not sure if that helps any.

Resolved in 2.1.0.


Directions for calling ./hack/prepare.sh in the provider guide

Description of your changes

In the context of https://github.com/crossplane-contrib/provider-jet-template/issues/3, this change proposes to move repo preparation shell commands into the script hack/prepare.sh of crossplane-contrib/provider-jet-template. This has some advantages like:

Simplifying the provider guide a bit
Decoupling the two repos a bit: For instance, as we might further evolve the hack/prepare.sh script in crossplane-contrib/provider-jet-template, the guide just instructs the user to call it.

Depends on https://github.com/crossplane-contrib/provider-jet-template/pull/9
I have:

[X] Read and followed Crossplane's contribution process.
[X] Run make reviewable to ensure this PR is ready for review.
[ ] Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Not a full test of the guide, however, tested by running hack/prepare.sh in https://github.com/crossplane-contrib/provider-jet-template/pull/9.

Thank you @turkenh.


Glitch in drawing of sparse console with variable size

The following changes the sparse console's size every tick. Is this just happening on my end or is the drawing glitchy?
bracket_terminal::add_wasm_support!();
use bracket_terminal::prelude::*;

struct State {
    n: i32,
}

impl GameState for State {
    fn tick(&mut self, ctx: &mut BTerm) {
        let mut draw_batch = DrawBatch::new();
        draw_batch.target(1);
        draw_batch.cls();
        self.n = (self.n + 1) % 80;
        draw_batch.draw_box(
            Rect::with_size(0, 0, self.n, 1),
            ColorPair::new(RGB::named(WHITE), RGB::named(BLACK)),
        );
        draw_batch.submit(0).expect("Batch error");
        render_draw_buffer(ctx).expect("Render error");
    }
}

fn main() -> BError {
    let context = BTermBuilder::simple80x50()
        .with_font("vga8x16.png", 8u32, 16u32)
        .with_sparse_console(80u32, 25u32, "vga8x16.png")
        .build()?;
    let gs = State { n: 0 };
    main_loop(context, gs)
}

Here's a screenshot of the glitch:

I don't reproduce it using the same code. Are you running it with default features?

I've tried it with and without. The above was created and run from the bracket-lib/bracket-terminal/examples directory.

yeah same thing. I put the code in bracket-lib/bracket-terminal/examples/test.rs and ran it with cargo run --example test. no glitch here

I am reproducing it on a different computer as well. Both are running Windows 10 with default features but one builds with x86_64-pc-windows-msvs and the other with x86_64-pc-windows-gnu.

are you using bracket-lib from git or the latest crates.io release? I don't reproduce with the master branch from git :
bracket-lib = {git="https://github.com/thebracket/bracket-lib"}

I'm using the one from git.

I reproduce it on another computer ! investigating... This might be dependant on the opengl version

The problem occurs only when using DrawBatch, and the glitch appears only when current frame is different from the last one. This code not using batches works fine :
    fn tick(&mut self, ctx: &mut BTerm) {
        ctx.cls();
        self.n = (self.n + 1) % 80;
        ctx.draw_box(0, 0, self.n, 1, RGB::named(WHITE), RGB::named(BLACK));
    }

Also when pausing the animation with the batch version so that it changes only when you press a key :
        if ctx.key.is_some() {
            self.n = (self.n + 1) % 80;
        }

you can see that the rendering is ok for any value of n. But every time n changes, the next frame is broken.

Found it !
draw_batch.target(1);

should be
draw_batch.target(0);

You have only one console and consoles id start with 0. On the other hand, Bterm accepting an invalid console id is probably a bug

That's not right.. I'm following directly from the bracket-lib/bracket-terminal/examples/sparse.rs example.
https://github.com/thebracket/bracket-lib/blob/19f065594b2328e8f31bb3f2e5156a14485abe3f/bracket-terminal/examples/sparse.rs#L18-L20
https://github.com/thebracket/bracket-lib/blob/19f065594b2328e8f31bb3f2e5156a14485abe3f/bracket-terminal/examples/sparse.rs#L41-L44
The terminal builder creates 2 consoles, a simple one (indexed 0) and a sparse one (indexed 1). draw_batch.target(0) draws on the simple console so you won't see the glitch since its size never changes (always 80x50). The glitch occurs when the sparse console changes size every draw draw_batch.target(1).

Indeed.
What I don't get with sparse consoles is how to handle several operation on the same console cell. For example, draw_box first fills the area with white spaces, then draws the rectangle around the box. As far as I understand, this means there are two SparseTile with the same id in the tiles array and I don't understand how this is handled in the rendering backend.

Just thought I'd mention that I've reverted to the more stable crates.io version for development and this issue doesn't seem to be present in there.

I ran the attached (original) code on my workstation, and it ran glitch-free on the latest HEAD/master. It ran ok in my Ubuntu VM, also. Scaling the window and messing with display scaling didn't seem to make it fail.
 One will overwrite the other, or you'll get odd overlay effects. You can actually use that for some pretty funky stuff with alpha enabled... but it isn't really meant to happen.
Anyway, the overdraw is a feature on flexible consoles - and a bug on sparse consoles. I'll see about cleaning up the sparse console and adding index checking on the set target call.

The glitch seems to be gone now. Great!