fix: make /user nav mobile friendly

Fixes FX-2055

made the nav bar scroll horizontally at < 768px
added a gradient block as an affordance to make it clear that it's scrollable

Questions:

do I have to use magic number media queries like this in the stylus files, or is there a nicer way to do it?
I made .settings-tabs use flexbox on all sizes - is this safe? if not, I could maybe move it into the media query?

@adamvert niiice! 🎉 💪 ✨
Couple of things:

I think the magic number is fine here. When developing in our "preferred" way (using palette/react) we have helpers for these media queries so you can reference breakpoints without specifying their underlying width values, but for these older components I think this is fine.
The flexbox everywhere is probably okay, but I would verify yourself by looking at different breakpoints. If it looks 👍 then 🚀 . I don't believe that class name is used anywhere else!
Would you mind removing the gradient? I believe our design pattern for horizontal scrolling in general is to bleed to the edge! (Although this looks cool 😄 ).

Thanks @sweir27 !

the flexbox looks fine to me at every size
I removed the gradient 😢


Angular 10 update

Bug with Angular 10
SocketIOModule.forRoot returns a ModuleWithProviders type without a generic type argument. Please add a generic type argument to the ModuleWithProviders type. If this occurrence is in library code you don't control, please contact the library authors.

Which platform(s) does your issue occur on?
Both
Please, tell us how to recreate the issue in as much detail as possible.
Simply start app

Wip it will be published soon

Hello,
@triniwiz when will you publish a new version?

Hello,
@triniwiz when will you publish a new version?

@nuno-morais https://github.com/triniwiz/nativescript-plugins

@nuno-morais https://github.com/triniwiz/nativescript-plugins

Thanks. Maybe this issue should be closed :)

Thanks. Maybe this issue should be closed :)

BTW, I've found an issue here: https://github.com/triniwiz/nativescript-plugins/blob/master/packages/nativescript-socketio/platforms/android/include.gradle
You didn't close the brackets. 🤔

BTW, I've found an issue here: https://github.com/triniwiz/nativescript-plugins/blob/master/packages/nativescript-socketio/platforms/android/include.gradle
You didn't close the brackets. 🤔

should be all fixed up now :) release 4.0.1

should be all fixed up now :) release 4.0.1

Hi @triniwiz , when would that be released? Last release appears to be still 3.x

@EricBorland @triniwiz/nativescript-socketio


Update Dockerfile

Added PostgreSQL log and config

By default the image is setup to log to stdout and the config is in the data volume: /var/lib/postgresql/data/postgresql.conf.  With their being no way to undo a defined volume, we only set volumes for data and let users define other volumes and bind mounts when they need to.

Thanks @yosifkit for letting me know about this! So, what should I do with #197  for making next update ?

closing old issue


End position of elements

I noticed that there is a starting position of an element, but no end position available.
I am looking for a way to find position in a case like this:
<root>
  <foo>
    <bar/>
    <bar/>
  </foo>
</root>

Taking the element /root/foo, I would want to have the < of the opening <foo> and then the > of the closing </foo>.
I noticed #10 and the commit mentioning the addition of range, but can't seem to find it in the current API.

Yes, it was removed recently. You can use 0.15 for now.
The reason it was removed is because each node and attribute would have to store Range<usize>, which is 16 bytes on 64bit targets and affects memory usage quite significantly.

I plan to re-add this feature, but can you explain your use case? I'm really curious.
The reason it was removed was not only because it was a bit hard to implement, but because I just couldn't see when it could be useful.

I plan to re-add this feature, but can you explain your use case? I'm really curious. The reason it was removed was not only because it was a bit hard to implement, but because I just couldn't see when it could be useful.

Sure: I am working on a Language Server Protocol server (for a VScode plugin). Parsing XML, and highlighting some part of the XML for the editor. This requires to have start and end position in the form of line/position-in-line.
Using ropey it is possible to translate between position in file <-> line/position-in-line pretty easily. But even that requires to know where an element starts, and where it ends.
I guess, writing editors/editing functionality, it makes sense to have all kind of other positional information (start of element, end of element, end of closing element, …).

Yay, I noticed you added this, and made a new release. Many thanks!
Here is how this looks like in action:

Great!


[INTERNAL] CAM onboarding of managed directory and subaccount

The mananged directory in our canary integration system must be onboarded to CAM

won't be fixed


BSimFeatureVisualizer decompiler highlighting is hard to read in dark mode

Describe the bug
When inspecting BSim features in BSimFeatureVisualizer, the code highlighted in orange in the decompiler view is often very hard to read in dark mode (see screenshots below).
To Reproduce
Steps to reproduce the behavior:

Go to BSim --> BSim Feature Visualizer
Select a feature in the table
Check the highlighted code in the decompiler view

Expected behavior
Readable highlighted code.
Screenshots
BSimFeatureVisualizer:

Decompiler:

BSimFeatureVisualizer:

Decompiler:

Attachments
N/A
Environment (please complete the following information):

OS: Linux fedora 6.12.4-200.fc41.x86_64
Java Version: openjdk 21.0.4 2024-07-16 LTS
Ghidra Version: 11.3_DEV
Ghidra Origin: locally built from the GitHub repo without any changes (commit 8bbc1d054075d0626eba621b470077a17e3dc16a)

Additional context
N/A

I also tried to find the relevant color option under Tool Options but could not locate it.

You should be able to change all colors of this feature via the Theme settings from the Front End window.
It looks like each theme color value has the prefix  color.bsim.graph.    I see 21 different entries defined.


Fallback to request scope if missing from auth challange

I've run across an issue similar to these: https://github.com/containerd/containerd/issues/3761 https://github.com/containerd/containerd/issues/3556
The general consensus is that this is an issue with the registry - which does seem to be the case for me as well (a badly behaving proxy is likely the culprit).
This change adds a fallback to fill in the scope (if missing from the auth challenge) by using the scope of the original request. In my case (and I suspect the linked cases as well), this fixes the issue.
This fallback behavior seems like a reasonable change to make the resolver more robust, even if there are good arguments to be made that the registry is not to spec. I'm interested in any feedback on this approach, and would love to merge it if there's some consensus.

Codecov Report

Merging #4223 into master will increase coverage by 0.01%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##           master    #4223      +/-   ##
==========================================
+ Coverage   38.34%   38.36%   +0.01%
==========================================
  Files          90       90
  Lines       12728    12732       +4
==========================================
+ Hits         4881     4884       +3
  Misses       7181     7181
- Partials      666      667       +1

Flag
Coverage Δ

#windows
38.36% <25.00%> (+0.01%)
:arrow_up:

Impacted Files
Coverage Δ

remotes/docker/authorizer.go
71.72% <25.00%> (+0.04%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d7104c...0a306d0. Read the comment docs.

@dmcgowan could you take a look at this one?

This should already be fixed by https://github.com/containerd/containerd/commit/08517e586485ef3b977b641c7dcc3ea33f6a6148#diff-c50d42c66aca162275ba2e7e834b1c48
The scopes will already get merged with the context when doBearerAuth is called. Can you please try with one of the beta releases and report an issue if it is not working for your use case.


useParams depends on multiple path order

Version
5.1.2
Test Case
https://codesandbox.io/s/react-router-89vgr?file=/index.js:0-936
Steps to reproduce
Click on Client : Create
Expected Behavior
:action should be defined
Actual Behavior
:action stay undefined
Informations
This seems to be due to the path order in the route:
:action stay undefined with this declaration:
   <Route path={['/clients', '/clients/:action']} component={Clients} />

If I reverse the path order with :
   <Route path={[ '/clients/:action', '/clients']} component={Clients} />

It works like a charm

That's because it's matching the /clients route first. If you use the exact prop, this will go away.

Ok, thanks
I was confused because I didn't understood at this moment why path='/clients/:action' didn't do the tricks for both routes


Postgres data migration: hook up

Description
A detailed explanation of the changes in your PR.
Feel free to remove this section if it is overkill for your PR, and the title of your PR is sufficiently descriptive.
Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why
you did not do so. Valid reasons include, for example, "CI is sufficient",
"No testable changes". Feel free to attach JSON snippets, curl commands,
screenshots.
In addition to reviewing your code, reviewers must also review your testing
instructions and make sure they are sufficient.

/test all

/test all

/test all

/test all

/test images

/test all

/test all

/test all

/test all

@c-du Looks like this change breaks TLS test https://issues.redhat.com/browse/ROX-12307


Icons now work with Select All

Are you sure this actually fixes anything? since my refact this file isn't even used.

@anthonydresser this is a patch for the release which doesn't include your refactor

I noticed, which is why I deleted my comment.

@abist I think we can live without this fix for today's August recovery build.  Let's merge this into master and pick-up in the build we're planning toward the end of next week.

@abist I'll merge this now to include in today's test build.


Taking advantage of rendered cube to apply transformations

Is it possible to take advantage of the rendered 3D space to appply transformations of hotspots accordingly?
For example, having ground hotspots rendered in regard to distance like so:

There's support for applying an arbitrary 3D transform to a hotspot (the perspective options object to the Hotspot constructor), but Marzipano can't help you calculate the appropriate transform, since it has no understanding of the physical (real-world) geometry underlying the image.

I'm expecting it not to be within your scope since it seems like active feature development is minimal, but my understanding of the following in terms of effort is thin; I would love to be able to project a pano onto provided geometry to achieve the above effect (like with KRpano at https://krpano.com/examples/?depthmap). Is this something that you/Google would consider ever implementing?
PS this is not supposed to come across as an insult or frustration wrt active development. I appreciate this library so much more than closed source, non-standard XML implementations of an arbitrary scripting language.

@tjgq my idea was to get only approximate transforms. The above example is from kuula and I don't expect this to be based on real world geometry either. I guess Marzipano knows the necessary transforms within the cube projection - for example we could assume the hotspots lie at a pre-defined height on the bottom cubeface and transform them accordingly?

Unfortunately, nobody at Google is actively working on Marzipano, myself included. I can put in some time to investigate/fix bugs and review pull requests, but major feature work would have to come from external contributions.
I think there are two potential features (related to scene geometry) being discussed in this thread:
Positioning hotspots. This can range from a simple assumed geometry (e.g. a fixed ground plane as suggested by @jordyno) or a full-blown depth map. Either way, this is just 3D geometry calculations, and the way Marzipano renders scenes doesn't need to change. (I don't think any of the existing code helps either, since Marzipano currently has no concept of a ground plane, or depth in a physical sense.)
Scene transitions. This is the ability to transition seamlessly between scenes, by using the depth map to interpolate the view between them (as in the krpano demo mentioned by @campmdabt). This would require changes to how Marzipano renders scenes.

@tjgq correct, I am in the first feature group, which should not be too difficult to implement. I am thinking that there should be a way to do the transforms on the ground plane in a similar fashion as shown in the embedded hotspots demo with the iframe transformation - in that case it's the front facing plane. My understanding is that it can be done using extra transforms and perspective radius somehow at this point of code in the demo: https://github.com/google/marzipano/blob/c9a847e090876bf361a8397349aa8b49aefdec43/demos/embedded-hotspots/index.js#L55
What I am looking into is doing these transforms without as little guesswork as possible.

@tjgq I misunderstood what Jordy was looking for in the original ask, so I'll keep that thread out of this specific git issue to keep it clean. Thanks for the info about development!

@campmdabt using the depthmap would surely be the best way to do it and also a welcome addition to Marzipano, but that seems too much work. Unless someone with skills and motivation joins :)

@tjgq I got it almost figured out, all I need is an formula, which doesn't need to be super precise, to calculate the estimated perspective radius for each hotspot within "assumed space".
I've built a simple illustrative demo of my intentions:

calculating extraTransforms was fairly simple, but finding a formula for the perspective.radius is beyond my miserable math knowledge. Any ideas here?
In the demo above I am using fixed 'assumed' values for radius based on pitch:
pitch....radius
0.15.....1900
0.2.......1400
0.5.......550
0.785..365
1.0.......305
1.57....260

@jordyno I threw together this spreadsheet to give you a few starting points, assuming I understand correctly that you're looking to get radius for a given pitch.
The first chart compares them directly to get a power distribution y=326.4x^(-0.891). The second chart uses the inverse of the radius (1/radius) to get a much closer approximation using a 2nd order polynomial y=-0.0015x^2+0.0049x-0.0002, but there are very few significant figures in those coefficients, so in the 3rd chart I multiplied all the 1/radius values by 1000, so (1/radius)*1000, to give you more sig figs, y=-1.4843x^2+4.9218x-0.2086. After calculating the y value, just divide by 1000 then take the inverse and you should have your radius.
Hope that helps!
Marzipano.xlsx

@jordyno I threw together this spreadsheet to give you a few starting points, assuming I understand correctly that you're looking to get radius for a given pitch.
The first chart compares them directly to get a power distribution y=326.4x^(-0.891). The second chart uses the inverse of the radius (1/radius) to get a much closer approximation using a 2nd order polynomial y=-0.0015x^2+0.0049x-0.0002, but there are very few significant figures in those coefficients, so in the 3rd chart I multiplied all the 1/radius values by 1000, so (1/radius)*1000, to give you more sig figs, y=-1.4843x^2+4.9218x-0.2086. After calculating the y value, just divide by 1000 then take the inverse and you should have your radius.
Hope that helps!
Marzipano.xlsx

@campmdabt thank you! I tried some curve fitting already and came up with a silly equation of Math.roundTo((200 + (26571 - 200)/(1 + (coords.pitch/0.0241)^1.447)) - 300, 6)
This worked approx fine. Today I gave it a second though, made a simple drawing and realized it's just a dead simple right angle triangle!!! :D
So the solution is as simple as it gets: radius = (a / cos(α) ) * const, where a is the height of the tripod and const is a proposed radius for element under the "camera" divided by tripod height.

@campmdabt thank you! I tried some curve fitting already and came up with a silly equation of Math.roundTo((200 + (26571 - 200)/(1 + (coords.pitch/0.0241)^1.447)) - 300, 6)
This worked approx fine. Today I gave it a second though, made a simple drawing and realized it's just a dead simple right angle triangle!!! :D
So the solution is as simple as it gets: radius = (a / cos(α) ) * const, where a is the height of the tripod and const is a proposed radius for element under the "camera" divided by tripod height.

Ah, makes perfect sense that it would mirror actual geometry if the pano is flat. I was thinking a similar thing to start, but then said "we don't have the distance to that point, so we can't use trig..." However we DO know the angle... Thanks Marzipano!

Ah, makes perfect sense that it would mirror actual geometry if the pano is flat. I was thinking a similar thing to start, but then said "we don't have the distance to that point, so we can't use trig..." However we DO know the angle... Thanks Marzipano!

Is this discussion still open?


Cannot set video width or height

Current Behavior
When I provide a value other than auto or 100%  for width/height to ReactPlayer it is ignored.
Expected Behavior
The style I provide to react player should be respected.
Steps to Reproduce
https://github.com/cookpete/react-player/blob/c9421f718f71be46172b24e19d64a9d4aeaa500e/src/players/FilePlayer.js#L329-L332
should  be
    const style = {
      width: width || '100%',
      height: height || '100%'
    }

Have you tried using the width and height props?

Individual players use 100% width and height in order to fill the top level wrapper, which gets given the width and height that you pass as props.
For example:
<ReactPlayer width='640px' height='480px' />

results in something like:
<div style={{ width: '640px', height: '480px' }}>
  <video style={{ width: '100%', height: '100%' }} /> // 100% here to fill the wrapper
</div>


New rule: grouping imports by type of imported entity

In our projects we trying to keep imports clean as possible and we grouping imports by type of imported entity:

imports from node modules (all things)
imports from types
imports from interfaces
imports from enums
other imports (classes, functions, constants)

import * as escodegen from 'escodegen-wallaby';
import * as espree from 'espree';
import * as ESTree from 'estree';

import { TObject } from './types/TObject';

import { IGeneratorOutput } from './interfaces/IGeneratorOutput';
import { IJavaScriptObfuscator } from './interfaces/IJavaScriptObfsucator';
import { ILogger } from './interfaces/logger/ILogger';
import { IObfuscationResult } from './interfaces/IObfuscationResult';
import { IOptions } from './interfaces/options/IOptions';
import { IRandomGenerator } from './interfaces/utils/IRandomGenerator';
import { ISourceMapCorrector } from './interfaces/source-map/ISourceMapCorrector';
import { ITransformersRunner } from './interfaces/node-transformers/ITransformersRunner';

import { LoggingMessage } from './enums/logger/LoggingMessage';
import { NodeTransformer } from './enums/node-transformers/NodeTransformer';
import { TransformationStage } from './enums/node-transformers/TransformationStage';

import { EspreeFacade } from './EspreeFacade';
import { NodeGuards } from './node/NodeGuards';

It will nice to have rule that will check that grouping by type of imported entity.
If few things are imported from the module - import should be attached to the group by most prevailing type of imported entity:
import {TFoo, TBar, IFoo} from '../../foo'; <- add to types group

Up this. For a reference, in the python world, isort supports sectioning the imports, based on their properties: https://github.com/timothycrosley/isort#custom-sections-and-ordering
It would make the code very clean to read.

i believe this is precisely the feature addressed in PR #3733, which will ship soon!

@giladgray no. Improt types in this PR is package, same folder or otjer folders.

@sanex3339 yes, that's precisely what the PR I linked is about. i even left a comment there that the word "types" was confusing.

(sorry, let the PR close it)


There are missing steps in the release command reference

On this page:

https://lfe.io/reference/lfe-rebar3/current/command-ref/projects/release.html

These steps are missing:

cd into project dir
generate release

Fixed by @starbelly in https://github.com/cnbbooks/lfe-rebar3-command-reference/commit/cc598cdf52820b97154a4de59f2f11b9f6d9b299!


Reorganize codata constants data

I´ll try to break down my draft #17577 into smaller bits, starting by this pull request.
Reference issue
gh-17577
What does this implement/fix?
It slims down the _codata.py file by moving the constants data in their own file. This makes its editing easier.
Additional information
This pull request should not break anything as the changes are only internal.

Could anyone give me a hint why the file scipy/constants/codata_constants_2002.txt can't be found?

Try adding it to the list in meson.build, https://github.com/scipy/scipy/blob/main/scipy/constants/meson.build

relevant CI error seems to be
scipy/constants/_codata.py:106: in parse_constants_2002to2014
    uncert = float(line[77:99].replace(' ', '').replace('(exact)', '0'))
E   ValueError: could not convert string to float: '0.00000029e'
        constants  = {'alpha particle-electron mass ratio': (7294.2995361, '', 2.9e-06), '{220} lattice spacing of silicon': (1.920155714e-10, '2          m', 3.2e-07)}
        d          = '\n             2010 Fundamental Physical Constants --- Complete Listing\n\n\n  From:  [http://physics.nist.gov/constan...1\nWien](http://physics.nist.gov/constan...1/nWien) wavelength displacement law constant                   2.897 7721 e-3           0.000 0026 e-3           m K\n'
        line       = 'alpha particle mass                                         6.644 656 75 e-27        0.000 000 29 e-27        kg'
        name       = 'alpha particle mass'
        uncert     = 2.9e-06
        units      = ''
        val        = 6.64465675e-27

For the parsing of the 2002 file I came up with the following parsing function but it contains loads of regular expressions:
def parse_constants_2002to2006(d: str) -> dict[str, tuple[float, str, float]]:
    constants = {}
    for line in d.split('\n'):
        if line == "":
            continue
        if line[1] == " ":
            continue
        if line[1] == "-":
            continue
        name = line[1:61].rstrip()
	significant = re.search(r'\d*.\d*', line[62:95].replace(" ","")).group()
	exponent = re.search(r'e-*\d*', line[62:95].replace(" ","")).group()
	val = float(significant+exponent)
	uncert_non_zeros = re.sub(r'[()]', '',  re.search(r'\(\d*\)', line[62:95]).group())
 	uncert_zeros = re.sub(r'\d', '0', significant).group()
	uncert = float(uncert_zeros.replace(uncert_zeros[-len(uncert_non_zeros):], uncert_non_zeros) + exponent)
	units = line[96:].rstrip()
        constants[name] = (val, units, uncert)
	return constants

I have to look at it again another time and perhaps it´s way to complicated.

This sounds like a good idea. While we're at it - what do you think about saving the data into a single .npz file at build time and installing that instead of the .txt files? That will make the wheel and on-disk installed sizes smaller; the text files are almost 200 kb; the binary equivalent is going to be a lot smaller.
We're doing this already in scipy.special. It should be pretty straightforward, the only thing to think about is to write the file to the build dir rather than in-tree. This can be done with a simplified version of https://github.com/scipy/scipy/blob/main/scipy/special/utils/makenpz.py


Changing an example does not update all widgets

e.g. when opening a method with an example in two browsers

After making ExampleReferences (almost) obsolete, this works now.

After making ExampleReferences (almost) obsolete, this works now.


Display of README on Pypi

See https://pypi.python.org/pypi/pyahocorasick/1.1.1
This is not looking good.
There are some limits to what ReST features Pypi supports.
The issue is likely around links:

http://stackoverflow.com/questions/16367770/my-rst-readme-is-not-formatted-on-pypi-python-org
http://inre.dundeemt.com/2014-05-04/pypi-vs-readme-rst-a-tale-of-frustration-and-unnecessary-binding/

This may help https://mg.pov.lt/restview/

Note that I played a bit with this this week-end trying to find where in the README ReST there is something that makes Pypi choke. There is something for sure and restview pointed to errors though I could not tell which one exactly...

@pombredanne Maybe we could we use shorter README for PyPI? Just an introduction and the link to readthedocs.org.

Maybe we could we use shorter README for PyPI? Just an introduction and the link to readthedocs.org.

Definitely. This is redundant now. Let me streamline this and send a PR

Thanks a lot! Your contribution in docs in priceless.
Is it possible to an update existing version of package on PyPI? Or we have to make a new release?

The simplest is to publish a new dot version. And this make sense since the code was updated too.

You wrote:

Thanks a lot! Your contribution in docs in priceless.

Thank you for your appreciation! it's not like I am putting lipstick on a bullddog: your code is great. Some decent doc is what will make it known.
I am also a selfish bastard: since I am using this library seriously now, I want it to be successful and healthy: with a good looking and decent doc, the likeliness some other folks will use it increases and more users may contribute to its well being ;)

Hmm, still doesn't look good. Maybe we should remove from setup.py option long_description? The homepage of package is displayed on PyPI, for a potential user checking out the docs would cost one additional click.

@pombredanne Thank you for kind word about the code. :) And you're perfectly right, a documentation is the ad of module. It should be nice and clean.
I wish I could spend more time on this project (and other side projects), but shortage of time is terrible. Moreover, my doctors say that I must not spend whole day at front of computer. :)

Maybe we should remove from setup.py option long_description

Let me craft a simple long description just for Pypi.

@WojciechMula this is because the setup.py tries to truncate the readme. I made some changes and tested them here by updating manually the long description on Pypi: https://pypi.python.org/pypi/pyahocorasick/1.1.2
If you have no objections, I can push a new release to Pypi. For now I made these changes in the aptly number #42 PR.

Now looks OK, great! Of course, please upgrade PyPI.

I tagged 1.1.3 and pushed a new Pypi release with python setup.py clean --all sdist --formats=bztar,gztar,zip register upload
It is there: https://pypi.python.org/pypi/pyahocorasick/1.1.3

I ended up repushing a new 1.1.5 release because of the bad URL fixed https://github.com/WojciechMula/pyahocorasick/commit/2144668e44e0b5a72c7c4fa2337df171667b3eeb


Support wasm

This is a very simple PR which enables the project to be built in a wasm environment, tested on rust stable v1.60.0 with the command cargo build --features wasm --target wasm-unknown-unknown
Relates to issues #25 and #26.
This doesn't refactor any of the code, like a previous attempt, and just uses a new wasm feature and conditional compilation.

It's useful for wasm apps to be able to call the plotly newPlot (+/- react) function directly, so I've added wasm bindings to those to functions.
Down the line, I wonder if it would be useful to implement bindings for validate and/or validateTemplate. It would then be possible to use those functions to validate Plot::to_json() output with the reference implementation in a testing configuration.


Rewrite concepts section

Closes: #191
This PR rewrites concepts section with new content.

@sideninja fixes:
https://github.com/onflow/docs/pull/207

more fixes:
https://github.com/onflow/docs/pull/211

@nialexsan @bthaile ready for final review and then merge when you think it's ok.


Improve type coverage (WIP)

This is an ongoing WIP to improve some of the public TypeScript type declarations.

Superseded by #156 .


Release builds on Windows include Deubg symbols, but not on Linux

It seems there is an inconsistency in debug info being included in Release builds.
Release builds always use the Release build type (not the RelWithDebInfo one), so they aren't included by default from a cmake perspective.
On Windows, this is ran (from the toolchain file):
set(CMAKE_CXX_FLAGS_RELEASE "${VCPKG_CRT_LINK_FLAG_PREFIX} /O2 /Oi /Gy /DNDEBUG /Z7 ${VCPKG_CXX_FLAGS_RELEASE}" CACHE STRING "")

Note /Z7, which adds debug info for release builds.
Would it be a reasonable addition to add -g to Release builds on Linux? We'd like to store symbols for our externals on Linux, and assumed it'd all be there considering it is on Windows.
Thanks!

Would it be a reasonable addition to add -g to Release builds on Linux?

IMHO yes.
Though storing debug symbols on Linux is a major PITA.

We use debuginfod internally. It rocks

Do you use it on dev machines too?

Some information
The option CMAKE_<LANG>_FLAGS_<CONFIG> first introduced in https://github.com/microsoft/vcpkg/commit/eba9f6a812edb48f14b5ad931d4f909e48f5b70d while added /Zi, and update to /Z7 in https://github.com/microsoft/vcpkg/commit/26516fe485b0e9048dd4809256a7e4526957c6e9 with current options, and eventually inherited to scripts/toolchains/windows.cmake.
For the option CMAKE_<LANG>_FLAGS_<CONFIG>_INIT in scripts/toolchains/linux.cmake, it introduced in https://github.com/microsoft/vcpkg/commit/f35ff4c8bc0fbe52a3c5c78f74f7c33e550b12e1.
It seems there is no special instructions for adding debug info options
Referrence
https://learn.microsoft.com/en-us/cpp/build/reference/z7-zi-zi-debug-information-format?view=msvc-170
https://gcc.gnu.org/onlinedocs/gcc-14.1.0/gcc/Debugging-Options.html

Maybe time to collect useful resources? But I don't know where to start.
https://www.tweag.io/blog/2023-11-23-debug-fission/

@WangWeiLin-MV sure, I understand it's not too difficult to add them manually (and that's what I did for us). However, the issue here is about the inconsistent defaults. On Windows, you just get symbols by default. On linux, by defaut, you don't.
People here are talking about symbol storage/splitting as well. In my opinion, this is out of scope for vcpkg (it doesn't do storage for windows either), but a great way to do symbol storage on Linux is build with symbols, store the binaries in a place accessiable by a debuginfod server, then strip the binaries you ship to customers. Then debuggers (lldb and gdb both support this) can be pointed to your server to download the debug symbols. It can even download executables in cases like coredumps that those are not available.
(I'm now worried I misread your comment...not sure if you're saying "no special instruction" as in "current state is fine" or that "it would not be special/difficult to pass -g by default")

@russelltg Sorry for not making it clearer. I only looked into the change history and found that there's no comments or documents was given about the options added many years ago, so further research is needed on current issue.


STOR-1010: Rebase to v1.25.0 for OCP 4.13

Diff to upstream v1.25.0:
https://github.com/kubernetes-sigs/azurefile-csi-driver/compare/v1.25.0...jsafrane:rebase-v1.25.0
Upstream changelogs since v1.21.0 (OCP 4.12):

https://github.com/kubernetes-sigs/azurefile-csi-driver/releases/tag/v1.25.0
https://github.com/kubernetes-sigs/azurefile-csi-driver/releases/tag/v1.24.0

Adds "support management api for volume snapshot (https://github.com/kubernetes-sigs/azurefile-csi-driver/pull/1118)"

We still don't support snapshots on Azure File volumesin OCP, there is still no API to restore them.

https://github.com/kubernetes-sigs/azurefile-csi-driver/releases/tag/v1.23.0

Adds "add accountAccessTier parameter in storage class (https://github.com/kubernetes-sigs/azurefile-csi-driver/pull/1109)"

https://github.com/kubernetes-sigs/azurefile-csi-driver/releases/tag/v1.22.0

Adds "support cross subscription with management api (https://github.com/kubernetes-sigs/azurefile-csi-driver/pull/1077)"

Not sure if we need to document it / test it.

@openshift/storage

There's a new 1.26.1 release, do we want to update to that one? The fix seems relevant.
Also, if we do any further updates, we could also update the OWNERS file.

Good catch, I opened a new PR https://github.com/kubernetes-sigs/azurefile-csi-driver/pull/1173
/close

ehm, https://github.com/openshift/azure-file-csi-driver/pull/23


Allow generic function types as type arguments

Allow generic function types as type arguments per https://github.com/dart-lang/language/issues/496 in the VM

@crelier I presume you are still waiting for the CFE implementation to be completed before you can close this

Now that the CFE has provided an implementation behind a flag, I am able to test and I found 2 issues in the VM.
The first one relates to a wrong usage of the trail to avoid infinite recursion. It is easy to fix.
The second one is more complicated and relates to indices assigned by CFE in kernel files to reference declared type parameters. The VM and CFE are not agreeing on this assignment. Since this is not my code, I am still investigating to figure out who is correct and how to fix it. I suspect the issue is on the VM side. Stay tuned.


ci: increase the files checked for changes before load docs cache

Description
Increase the files checked for changes before load docs cache.
Currently CICD does not check changes in the doc directory. This checks against it.
Issue linked
NA
Checklist

[ ] I have visited and read Develop PyMAPDL.
[ ] I have tested my changes locally
[ ] I have added necessary documentation or updated existing documentation.
[ ] I have followed the PyMAPDL coding style guidelines.
[x] I have added appropriate unit tests that also ensure the minimal coverage criteria.
[x] I have reviewed my changes before submitting this pull request.
[x] I have linked the issue or issues that are solved to the PR if any.
[x] I have assigned this PR to myself.
[x] I have marked this PR as draft if it is not ready to be reviewed yet.
[x] I have made sure that the title of my PR follows Commit naming conventions (e.g. feat: adding new MAPDL command)

@pyansys-ci-bot LGTM.


Cache instructions available on AMD APUs under ROCM platform ?

Is there any instruction to flush the cache and invalidate the cache L2 in specific ? The reason for asking is to achieve coherency between CPU and GPU accessing the DRAM in APUs there should be cache flushing action? How is it done , what is the instruction for the same ?

@VishwasRao17 don't write a paragraph in the ticket title.

Ok, I wont . Is there a pointer for my question please.

best place to start on ROCm rocm.github.io documentation Also you can look at HSA Foundation spec for background on the runtime and system architecture for ROCm

@gstoner I was going through the ISA sea islands , this is because AMD Kaveri GPU follows Sea Islands Architecture. There they quote in introduction, page no 1-2 (" invalidate and flush caches on the Sea Islands GPU, and ") . But it was not mentioned in the ISA as a command as such . The statements says when the host tries to offload work to GPU , it should copy the contents to device memory and invalidate the L2 cache . So this must be done in ROCM too while offlading the kernel to device memory.  So I am curious how it is done ? I need to apply something similar in my application.

Invalidating L2 cache is done using AQL packet commands, using the various hsa_fence_scope_t values in the packet. Refer to the HSA Runtime specification for a description of AQL and controlling memory synchronization.


Feature/new design update

Description and Motivation

Swap card updated to new design
LP card updated to new design
Vault card updated to new design

Related Issues

Checklist:

[ ] I have read Migaloo's contribution guidelines.
[ ] My pull request has a sound title and description (not something vague like Update index.md)
[ ] All existing and new tests are passing.
[ ] I updated/added relevant documentation.
[ ] The code is formatted properly yarn lint.
[ ] The project builds and is able to deploy on Netlify yarn build.

Looks good. Let's remove the sliders though, as they are conflicting with our minimal design.


tra-analysis v 3.0.0 aggregate PR

Overview
The PR contains changes mainly from 3 different branches aimed to simplify and standardize the module structure of tra-analysis, provide future functionality, and implement proper unit testing for critical tools. The module should be backwards compatible with any code written with tra-analysis 2.x except in the cases where bug fixes were made (where the coe would not function properly in 2.x anyways).
Each branch's changes are summarized in their own section.
Submoduling Changes
The changes from submoduling should not break any existing code using tra-analysis, however some function calls have been deprecated in favor of the new submodule structure and should be used in the future.

Module path and name changes (refer to individual modules for exact changes):

ported analysis.Array to new module Array
ported analysis.ClassificationMetric to new module ClassificationMetric
ported analysis.CorrelationTest to new module CorrelationTest
added new module Fits
ported analysis.KNN to new module KNN
ported analysis.NaiveBayes to new module NaiveBayes
ported analysis.RandomForest to new module RandomForest
ported analysis.RegressionMetric to new module RegressionMetric
ported analysis.Sort to new module Sort
ported analysis.StatisticalTest to new module StatisticalTest
ported analysis.SVM to new module SVM

Modules that lost "classness". Compatibility layers have been created to allow for backwards compatibility:

CorrelationTest
NaiveBayes
RandomForest
Sort
StatisticalTest

Modules with major bug fixes:

StatisticalTest
SVM

Equation submodule
The Equation branch added a new submodule to tra-analysis that has no current implementation, and is aimed to be implemented later as a minor update. The new equation submodule contains classes and methods to create symbolic equations and expressions.

Brief descriptions of submodules:

Expression: Extends and wraps HybridExpressionParser
Hybrid: contains HybridExpressionParser and helper methods. HybridExpressionParser uses a combination of regex and Backus–Naur form parsing to evaluate symbolic expressions
RegexInplaceParser: a pure regex parser to evaluate 4-function symbolic expressions
BNF: a pure Backus–Naur form parsing tree to evaluate symbolic expressions

Unit Tests
Unit tests were added for most submodules, and made fixes to ensure the tests passed. In most cases, these unit tests used very simple test data as inputs for the functions of these modules.
Modules with new tests are:

Array
ClassificationMetric
CorrelationTest
KNN, NaiveBayes
RandomForest
RegressionMetric
SVM.

Note that some modules do not have all functionality tested. Modules which still do not have any unit tests are titanlearn, visualization, and StatisticalTest.
Submodule bug fixes from this branch will be considered to be part of the submoduling changes.
Misc. changes

Docker environment fixes and optimizations from #58
additions of kivy and pyparsing to the requirements.txt
Minor edits to README.txt

Review methodology

Automated unit tests have verified that the changes did not cause any unwanted behavior
Manual reviews should go over some if not all parts of the PR. When submitting a review, please indicate which files were reviewed. If changes are requested ensure they specify which line(s) the changes pertain to.
rc2 will follow after an initial round of review
Final merging will be dependent on all reviews being submitted for rc1 and rc2.

@devksingh4
The *_obj files are included as backwards compatibility, the new submodules are no longer class based and would break existing code.

backwards compatibility

We're updating major version anyways, yes? Considering that right now, only our code is using analysis, let's rip the bandaid off and get rid of object-based submodules.

Because it may or may not break our own code an I would like it to continue working as we update it.

Because it may or may not break our own code an I would like it to continue working as we update it.

So let's integration test our stuff, see if it does break our own code and then check how hard it would be to fix the breaks. I don't want to accumulate more technical debt more than we have to, and maintaining this double-system for backward compat will not be fun down the line.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.5 out of 6 committers have signed the CLA.:white_check_mark: jzpan1:white_check_mark: AGawde05:white_check_mark: ltcptgeneral:white_check_mark: zpan1:white_check_mark: devksingh4:x: == seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Please note that the version and changelog will be updated a final time before finishing the merge.


[Feature Request] Keep (only) playlist songs cach.

An option to only keep songs from the playlist would be nice.
Right now you can keep every song ever played.
Or delete any song not in the queue. (Guess for if you have songs in the queue more than once?)
Keeping playlist songs would be a welcome feature. (Don't care much for random songs people queue.)

When I write local playlists, this will be one of the special playlists, like the autoplaylist.


Add support for Amazon Linux 2 extra kernels

What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area build
/area pkg
What this PR does / why we need it:
Fixes #90
Special notes for your reviewer:
This PR:

fixes a bug in the Makefile (now it ensures to use a specific shell)
adds support for Amazon Linux 2 extra kernels

Does this PR introduce a user-facing change?:
NONE

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign fntlnz after the PR has been reviewed.
You can assign the PR to them by writing /assign @fntlnz in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zuc: There is not a label identifying the kind of this PR.
Please specify it either using /kind <group> or manually from the side menu.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Welcome @zuc! It looks like this is your first PR to falcosecurity/driverkit 🎉

/honk

@leodido: Unable to find goose. Have you checked the garden?

In response to this:

/honk

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leodido
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leodido]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Add to capacitor community plugins

Describe the solution you'd like:
Plugin to be added to the capacitor community plugins.  Adding feature request to cross reference to the plugin propsal.
Additional context:
https://github.com/capacitor-community/proposals/issues/108

Hi @pete-mcwilliams,
thank you for your request.
This plugin is now maintained by the Capawesome Organization.
We do not plan to move it to the Capacitor Community Organization.


The resize layer produces invalid output

I believe methods other than :nearest don't currently work.

nearest

linear

cubic

Also related to https://github.com/elixir-nx/nx/issues/838.

We can port the implementation from the other project. We could use NxImage once we extract it, however as far as I understand Axon wants to support arbitrary number of spatial dimensions, so we will need a tweaked implementation.

(off topic) Are you able to give more info about NxImage? I am in the middle of exploring image processing in Elixir on the edge and that sounds very interesting. I suppose it's an internal project, as there are exaclty two hits on google for "NxImage" :D

@jonatanklosko crop and resize is a good start. I'd be interested to contribute to further implementation when the time comes.


Refactor and remove legacy APIs/testing internals.

This PR removes the following (and does some minimal refactoring in the process):

numba.core.compiler.compile_isolated this function was used a lot in Numba's test suite and exists from a time where the compiler was less isolated than it is now. The function itself also relies on "nested contexts" within the same target which has been discovered to cause numerous issues in practice.
numba.tests.support.TestCase::run_nullary_func this method isn't really used very much in the test suite or needed any more, refactoring to remove it was trivial.
numba.tests.support.CompilationCache, this was used in the test suite from a time when the Numba dispatchers were less well isolated and compile_isolated needed somewhere to cache results, this isn't needed any more since compile_isolated is removed.
"nested context" as a concept from the numba.core.registry.CPUTarget, this was used a lot in conjunction with the now removed compile_isolated, it has a history of causing hard to debug problems.

Notes for the reviewer:

These patches are reasonably isolated to one file being changed per commit.
Patch b91050302 fixes a bug in _typeof.cpp that was hidden by compile_isolated, it is therefore less "easy" to review.
Patch 834ec6b53 also includes a minor refactor to test_svml.py to better use existing testing infrastructure to achieve isolation.

I'll review from 1305229 to 7ea64ab

Many thanks for the review @sklam. I think I've addressed all the comments and have added a SHA to each one to hopefully make it easier to see the change that implements the fix.
I think there's two changes made that do not correspond to a requested change:

b22f8dd is fixing up parfors testing to look for the gufunc assembly output that matches the compilation of interest opposed to checking all outputs (there can now be a few as the compilation context is shared). This change is require to make the parfors tests pass.
7ef939a is fixing up against #9309.

There's very little chance of public CI being able to successfully run with this diff as too many tests have changed and the time limits will be exceeded as a result of running them all, we'll have to rely on the build farm.

Speculatively testing 7ef939a on the buildfarm with ID: numba_smoketest_cpu_yaml_186.

I have reviewed everything. It's just pending the one spelling fix and buildfarm to complete

Many thanks @sklam, spelling/typo fix is in 99a7655. Conflicts against main (688c5141) resolved in ad5f660.

Speculatively testing 7ef939a on the buildfarm with ID: numba_smoketest_cpu_yaml_186.

This passed.

@sklam 086b212 should resolve the merge conflict with main, this branch should now be the same as #9349.

Not going to wait for CI


Addition of callback_arg to psk_client_callback functions

I want to receive a custom argument in the callback set via SSL_set_psk_client_callback. Currently, the callback provides with the SSL* but I have a scenario where I have more than one SSL clients to manage in a single application context. When the callback is called, I don't have a good way of knowing for which SSL Client this callback has been called.
Similar APIs to set the callback argument are available for another callback functions e.g. SSL_set_msg_callback_arg.
This request is for addition of APIs like SSL_set_psk_client_callback_arg, SSL_CTX_set_psk_client_callback_arg, SSL_set_psk_server_callback_arg, SSL_CTX_set_psk_server_callback_arg. The APIs will take a void* argument and store it in the SSL/SSL_CTX and pass it back when calling the callback.

You can use the EXDATA in an SSL object to add your specific needs.  The problem with changing API of the callback function is that, well, it changes the API and we can't do that in a dot release.  Sorry, it was a goof to leave it out, but there is a workaround.


[no such file or directory: 'x86_64'] when building the library in TensorFlow Lite for iOS

Hi all, I encountered with an issur when trying to setting up the environment to build TensorFlow Lite for iOS. .
But when I was trying to build the library for all five supported architectures on iOS using tensorflow/contrib/lite/build_ios_universal_lib.sh, I have the follwing issue.
xcrun: error: SDK "iphonesimulator" cannot be located
xcrun: error: SDK "iphonesimulator" cannot be located
xcrun: error: unable to lookup item 'PlatformPath' in SDK 'iphonesimulator'
xcrun: error: SDK "iphonesimulator" cannot be located
xcrun: error: SDK "iphonesimulator" cannot be located
xcrun: error: unable to lookup item 'Path' in SDK 'iphonesimulator'
xcrun: error: SDK "iphoneos" cannot be located
xcrun: error: SDK "iphoneos" cannot be located
xcrun: error: unable to lookup item 'SDKVersion' in SDK 'iphoneos'
gcc --std=c++11 -O3 -DNDEBUG -miphoneos-version-min=9.0 -DGEMMLOWP_ALLOW_SLOW_SCALAR_FALLBACK -fembed-bitcode -Wno-c++11-narrowing -mno-thumb -fno-exceptions -isysroot  -arch x86_64 -O3 -I. -I/Users/zhangjiawei/tensorflow/tensorflow/contrib/lite/../../../ -I/Users/zhangjiawei/tensorflow/tensorflow/contrib/lite/downloads/ -I/Users/zhangjiawei/tensorflow/tensorflow/contrib/lite/downloads/eigen -I/Users/zhangjiawei/tensorflow/tensorflow/contrib/lite/downloads/gemmlowp -I/Users/zhangjiawei/tensorflow/tensorflow/contrib/lite/downloads/neon_2_sse -I/Users/zhangjiawei/tensorflow/tensorflow/contrib/lite/downloads/farmhash/src -I/Users/zhangjiawei/tensorflow/tensorflow/contrib/lite/downloads/flatbuffers/include -I/Users/zhangjiawei/tensorflow/tensorflow/contrib/lite/gen/obj/ -I/usr/local/include -c tensorflow/contrib/lite/allocation.cc -o /Users/zhangjiawei/tensorflow/tensorflow/contrib/lite/gen/obj/ios_x86_64/tensorflow/contrib/lite/allocation.o
gcc -miphoneos-version-min=9.0 -fembed-bitcode -mno-thumb -isysroot  -arch x86_64 -O3 -I. -I/Users/zhangjiawei/tensorflow/tensorflow/contrib/lite/../../../ -I/Users/zhangjiawei/tensorflow/tensorflow/contrib/lite/downloads/ -I/Users/zhangjiawei/tensorflow/tensorflow/contrib/lite/downloads/eigen -I/Users/zhangjiawei/tensorflow/tensorflow/contrib/lite/downloads/gemmlowp -I/Users/zhangjiawei/tensorflow/tensorflow/contrib/lite/downloads/neon_2_sse -I/Users/zhangjiawei/tensorflow/tensorflow/contrib/lite/downloads/farmhash/src -I/Users/zhangjiawei/tensorflow/tensorflow/contrib/lite/downloads/flatbuffers/include -I/Users/zhangjiawei/tensorflow/tensorflow/contrib/lite/gen/obj/ -I/usr/local/include -c tensorflow/contrib/lite/context.c -o /Users/zhangjiawei/tensorflow/tensorflow/contrib/lite/gen/obj/ios_x86_64/tensorflow/contrib/lite/context.o
gcc --std=c++11 -O3 -DNDEBUG -miphoneos-version-min=9.0 -DGEMMLOWP_ALLOW_SLOW_SCALAR_FALLBACK -fembed-bitcode -Wno-c++11-narrowing -mno-thumb -fno-exceptions -isysroot  -arch x86_64 -O3 -I. -I/Users/zhangjiawei/tensorflow/tensorflow/contrib/lite/../../../ -I/Users/zhangjiawei/tensorflow/tensorflow/contrib/lite/downloads/ -I/Users/zhangjiawei/tensorflow/tensorflow/contrib/lite/downloads/eigen -I/Users/zhangjiawei/tensorflow/tensorflow/contrib/lite/downloads/gemmlowp -I/Users/zhangjiawei/tensorflow/tensorflow/contrib/lite/downloads/neon_2_sse -I/Users/zhangjiawei/tensorflow/tensorflow/contrib/lite/downloads/farmhash/src -I/Users/zhangjiawei/tensorflow/tensorflow/contrib/lite/downloads/flatbuffers/include -I/Users/zhangjiawei/tensorflow/tensorflow/contrib/lite/gen/obj/ -I/usr/local/include -c tensorflow/contrib/lite/downloads/farmhash/src/farmhash.cc -o /Users/zhangjiawei/tensorflow/tensorflow/contrib/lite/gen/obj/ios_x86_64/tensorflow/contrib/lite/downloads/farmhash/src/farmhash.o
gcc --std=c++11 -O3 -DNDEBUG -miphoneos-version-min=9.0 -DGEMMLOWP_ALLOW_SLOW_SCALAR_FALLBACK -fembed-bitcode -Wno-c++11-narrowing -mno-thumb -fno-exceptions -isysroot  -arch x86_64 -O3 -I. -I/Users/zhangjiawei/tensorflow/tensorflow/contrib/lite/../../../ -I/Users/zhangjiawei/tensorflow/tensorflow/contrib/lite/downloads/ -I/Users/zhangjiawei/tensorflow/tensorflow/contrib/lite/downloads/eigen -I/Users/zhangjiawei/tensorflow/tensorflow/contrib/lite/downloads/gemmlowp -I/Users/zhangjiawei/tensorflow/tensorflow/contrib/lite/downloads/neon_2_sse -I/Users/zhangjiawei/tensorflow/tensorflow/contrib/lite/downloads/farmhash/src -I/Users/zhangjiawei/tensorflow/tensorflow/contrib/lite/downloads/flatbuffers/include -I/Users/zhangjiawei/tensorflow/tensorflow/contrib/lite/gen/obj/ -I/usr/local/include -c tensorflow/contrib/lite/error_reporter.cc -o /Users/zhangjiawei/tensorflow/tensorflow/contrib/lite/gen/obj/ios_x86_64/tensorflow/contrib/lite/error_reporter.o
gcc --std=c++11 -O3 -DNDEBUG -miphoneos-version-min=9.0 -DGEMMLOWP_ALLOW_SLOW_SCALAR_FALLBACK -fembed-bitcode -Wno-c++11-narrowing -mno-thumb -fno-exceptions -isysroot  -arch x86_64 -O3 -I. -I/Users/zhangjiawei/tensorflow/tensorflow/contrib/lite/../../../ -I/Users/zhangjiawei/tensorflow/tensorflow/contrib/lite/downloads/ -I/Users/zhangjiawei/tensorflow/tensorflow/contrib/lite/downloads/eigen -I/Users/zhangjiawei/tensorflow/tensorflow/contrib/lite/downloads/gemmlowp -I/Users/zhangjiawei/tensorflow/tensorflow/contrib/lite/downloads/neon_2_sse -I/Users/zhangjiawei/tensorflow/tensorflow/contrib/lite/downloads/farmhash/src -I/Users/zhangjiawei/tensorflow/tensorflow/contrib/lite/downloads/flatbuffers/include -I/Users/zhangjiawei/tensorflow/tensorflow/contrib/lite/gen/obj/ -I/usr/local/include -c tensorflow/contrib/lite/interpreter.cc -o /Users/zhangjiawei/tensorflow/tensorflow/contrib/lite/gen/obj/ios_x86_64/tensorflow/contrib/lite/interpreter.o
clang: error: no such file or directory: 'x86_64'
clang: warning: no such sysroot directory: '-arch' [-Wmissing-sysroot]
make: *** [/Users/zhangjiawei/tensorflow/tensorflow/contrib/lite/gen/obj/ios_x86_64/tensorflow/contrib/lite/allocation.o] Error 1
make: *** Waiting for unfinished jobs....
clang: error: no such file or directory: 'x86_64'
clang: warning: no such sysroot directory: '-arch' [-Wmissing-sysroot]
clang: error: no such file or directory: 'x86_64'
clang: warning: no such sysroot directory: '-arch' [-Wmissing-sysroot]
make: *** [/Users/zhangjiawei/tensorflow/tensorflow/contrib/lite/gen/obj/ios_x86_64/tensorflow/contrib/lite/context.o] Error 1
make: *** [/Users/zhangjiawei/tensorflow/tensorflow/contrib/lite/gen/obj/ios_x86_64/tensorflow/contrib/lite/downloads/farmhash/src/farmhash.o] Error 1
clang: error: no such file or directory: 'x86_64'
clang: warning: no such sysroot directory: '-arch' [-Wmissing-sysroot]
make: *** [/Users/zhangjiawei/tensorflow/tensorflow/contrib/lite/gen/obj/ios_x86_64/tensorflow/contrib/lite/error_reporter.o] Error 1
clang: error: no such file or directory: 'x86_64'
clang: warning: no such sysroot directory: '-arch' [-Wmissing-sysroot]
make: *** [/Users/zhangjiawei/tensorflow/tensorflow/contrib/lite/gen/obj/ios_x86_64/tensorflow/contrib/lite/interpreter.o] Error 1

System information

OS Platform and Distribution: macOS High Sierra 10.13.2(17C88)
TensorFlow version (use command below): v1.3.0-rc2-20-g0787eee 1.3.0
Python version: 3.6.1
GCC/Compiler version (if compiling from source): GCC 4.2.1 Compatible Apple LLVM 6.0 (clang-600.0.57)
Exact command to reproduce: bash tensorflow/contrib/lite/build_ios_universal_lib.sh
Have I written custom code?: no
TensorFlow installed from: source
Bazel version: N/A
CUDA/cuDNN version: N/A
GPU model and memory: N/A

Has anyone else had the same problem?

Thank you for your post. We noticed you have not filled out the following field in the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Thanks.
Have I written custom code
TensorFlow installed from
Bazel version
CUDA/cuDNN version
GPU model and memory

@tensorflowbutler thanks, I've updated that.

@aselle can you comment on this one?

To fix this, open in XCode > Preferences > Locations and look Command Line Tools. Mine was empty. Selecting a value fixed in that dropdown fixed this issue for me.

@mikeknapp Thanks, it works!


Inline context help for nimble-combobox

😯 Problem to Solve
Hi all - I'm starting to look at this feature, part of the new routines UX that requires Nimble updates.
The goal of the feature is to be able to display inline help for the workspace selector field. The current wireframes show this UX:

Hovering the ℹ icon would display a tooltip. This would require changes to the nimble-combobox.
💁 Proposed Solution
I'm anticipating pushback on the UX above, mostly because it conflicts with the existing UX for displaying validation errors:

My proposal would be to move the tooltip hover icon into the component's label. This approach can apply to all form controls, so it's both easier to implement and less cognitive load for users.
Here's an example of how Grafana's design system does inline help:

My intent for this issue is to come to a consensus on the correct UX and implementation for the feature. Based on the outcome, I can create a spec if needed. My understanding is that we'll also need to create or update an IxD spec.
🙋♂ Open issues

[ ] Decide on UX of inline help for form controls
[ ] I noticed in Storybook that the combobox doesn't seem to have a label attribute. Will we need to add this?
[ ] Should we resurrect the nimble-tooltip for this feature?

Please set up a meeting with @leslieab, @NIbokeefe, and @mollykreis to discuss direction.

Visual design is available as nimble-toggle-tip.

Closing in favor of https://github.com/ni/nimble/issues/1876


docker-compose run --rm rocm-from-src doesn't work

docker-compose.yml rule roct-deb uses ./roct/roct-thunk-src-dockerfile from .env configuration file.
from roct-thunk-src-dockerfile:
RUN mkdir -p ${HSATHK_BUILD_PATH} && \
  cd ${HSATHK_BUILD_PATH} && \
  git clone --depth=1 --branch=master https://github.com/RadeonOpenCompute/ROCT-Thunk-Interface.git ./ && \
  make -j $(nproc) deb && \
  dpkg -i build/deb/hsakmt-dev-*.deb && \
  ln -sr /opt/rocm/libhsakmt/lib/libhsakmt.so.1 /opt/rocm/libhsakmt/lib/libhsakmt.so && \
  cd ~ && rm -rf ${HSATHK_BUILD_PATH}

or make -j $(nproc) deb doesn't work as rule deb doesn't exist anymore from https://github.com/RadeonOpenCompute/ROCT-Thunk-Interface.git repository

@Sumenia , thanks for reporting, I'll fix it.


Missing Forgelin message/crash

I'm getting a message on the client and a crash on the server stating Vanilla Immersion requires Forgelin 1.5.0.
I've got Forgelin 1.5.0.  I even re-downloaded it and replaced it in case I had a corrupt version.  Unfortunately I'm still seeing the same thing.
Vanilla Immersion 1.12-<IP_ADDRESS>
Forgelin 1.5.0
Forge 2415

This issue appears to be on Forgelin's side, version 1.5.0 on CF and the Maven still are 1.4.2 in the @Mod annotation. I'll get a fix to Forgelin and release a version of VI that doesn't depend on a given version of Forgelin for now.


Support large_string as indexable column in FTS?

I've seen there are some datasets like afg1/litscan-epmc-subset and baber/USPTO that have large_strings but does not support FTS because of this condition https://github.com/huggingface/datasets-server/blob/main/services/worker/src/worker/job_runners/split/duckdb_index.py#L77
Should we add large_string as part of the condition?

yes, it seems logical to support both

Done by #2755


Session race on device reconnect

Describe the bug
Client doesn't receive any updates from server. This is difficult to reproduce and happens sometimes after a reconnect (but not always). I suspect a race condition during session re-creation (see log below).
Which project is your bug related to?

[ ] Client
[ ] ManagedClient
[ ] MQTTnet.Server standalone
[x] Server
[ ] Generic

To Reproduce
Difficult to tell. We are working with MQTTnet v2.8.5 and preparing the switch to the newest version, but it will take a while to confirm.
Additional context / logging
 1) MqttTcpServerAdapter.MqttTcpServerListener[6] (Verbose)
    Client '<IP_ADDRESS>:51234' accepted by TCP listener '<IP_ADDRESS>:1883, ipv4'.

 2) MqttTcpServerAdapter.MqttTcpServerListener.MqttChannelAdapter[15] (Verbose)
    RX <<< Connect: [ClientId=abc123] [Username=myusername] [Password=mypassword] [KeepAlivePeriod=10] [CleanSession=True]

 3) MqttHandler
    Allowing connection for device abc123: ConnectionAccepted

 4) MqttTcpServerAdapter.MqttTcpServerListener.MqttChannelAdapter[15] (Verbose)
    Disconnecting [Timeout=00:00:30]

 5) MqttServer.MqttClientSessionsManager.MqttClientSession.MqttClientKeepAliveMonitor[15] (Verbose)
    Client 'abc123': Stopped checking keep alive timeout.

 6) MqttServer.MqttClientSessionsManager.MqttClientSession[15] (Info)
    Client 'abc123': Disconnected (clean=True).

 7) MqttHandler
    Device abc123 is now offline

 8) MqttServer.MqttClientSessionsManager[15] (Verbose)
    Stopped existing session of client 'abc123'.

 9) MqttServer.MqttClientSessionsManager[15] (Verbose)
    Created a new session for client 'abc123'.

10) MqttServer.MqttClientSessionsManager[6] (Verbose)
    Session for client 'abc123' deleted.

11) MqttTcpServerAdapter.MqttTcpServerListener.MqttChannelAdapter[15] (Verbose)
    TX >>> ConnAck: [ConnectReturnCode=ConnectionAccepted] [IsSessionPresent=False]

12) MqttServer.MqttClientSessionsManager[15] (Info)
    Client 'abc123': Connected.

13) MqttHandler
    Device abc123 is now online

Expected behavior
I would expect the line (10) not to happen after line (9). Since those calls are performed by different threads, it is probably a race condition. After connection completes, the device has no session, so it doesn't receive any topic updates.

@chkr1011 I guess, this should not appear in the 3.0.5 version anymore...

Thanks for the super fast answer. I checked the git history of the MqttClientSessionsManager between 2.8.5 but didn't notice any related fixes. I will setup a test with latest NuGet package, but it is quite difficult to reproduce :(


imagemagick: remove breaking quotes in configure

Remove extraneous quotes in configure that break the content of delegates.xml by adding unintended spaces.

Motivation for this change
The current package in master is broken, because the commands in delegates.xml that are not available at compile time are written with an extra space. For instance potrace is written  potrace, and any command that requires potrace in the PATH will try to call  potrace and fail (e.g. try to convert a raster image to SVG).
This is caused by double quoting and an extra space in configure.ac. This patch fixes the error in configure.
The patch should be removed once the bug is fixed upstream, of course.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[X] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 117158 at 175b6f92 run on x86_64-linux 1

13 packages marked as broken and skipped:

autotrace
gimpPlugins.exposureBlend
gimpPlugins.texturize
glimpsePlugins.exposureBlend
glimpsePlugins.texturize
gnome3.gnome-documents
hhvm
invoice2data
spring
springLobby
...

120 packages skipped due to time constraints:

abiword
adapta-gtk-theme
arc-theme
arx-libertatis
asciidoc-full
asciidoc-full-with-plugins
asymptote
awesome (awesome-4-0)
beets
bibata-cursors
...

107 packages built successfully:

asc-key-to-qr-code-gif
beetsExternalPlugins.alternatives
beetsExternalPlugins.copyartifacts
beetsExternalPlugins.extrafiles
betterlockscreen
blockhash
brasero
brasero-original
cd-hit
chafa
cuneiform
devede
dmtx-utils
docbook2odf
dvd-slideshow
dvdauthor
dvdbackup
fbida
fgallery
fontpreview
fped
freedroid
frescobaldi
gnome3.gdm
gnome3.gnome-panel
goattracker
goattracker-stereo
gopro
hello-wayland
i3lock-fancy
i3lock-pixeled
imagemagick
imagemagickBig
imagemagick_light
imgproxy
ldgallery
ledger-live-desktop
libwmf
lilypond
mastodon
mate.caja-extensions
mate.caja-with-extensions
mediainfo-gui
megapixels
multilockscreen
netbeans
nixos-icons
noteshrink
optar
paperless
paperwork
pdf-redact-tools
pdf2odt
pdfsandwich
perl530Packages.Gtk3ImageView
perl530Packages.PerlMagick
perl532Packages.Gtk3ImageView
perl532Packages.PerlMagick
php73Extensions.imagick
php74Extensions.imagick
php80Extensions.imagick
playonlinux
portmod
pqiv
protonvpn-gui
python38Packages.SQLAlchemy-ImageAttach
python38Packages.Wand
python38Packages.paperwork-backend
python38Packages.paperwork-shell
python38Packages.pyocr
python38Packages.pyvips
pywal (python38Packages.pywal)
python39Packages.SQLAlchemy-ImageAttach
python39Packages.Wand
python39Packages.paperwork-backend
python39Packages.paperwork-shell
python39Packages.pyocr
python39Packages.pyvips
python39Packages.pywal
recoverjpeg
ripcord
rubyPackages.rmagick (rubyPackages_2_6.rmagick)
rubyPackages.ruby-vips (rubyPackages_2_6.ruby-vips)
rubyPackages_2_7.rmagick
rubyPackages_2_7.ruby-vips
rubyPackages_3_0.rmagick
rubyPackages_3_0.ruby-vips
shutter
solfege
soulseekqt
sound-juicer
stm32cubemx
swaylock-fancy
tango-icon-theme
timelapse-deflicker
tiv
ttygif
urn-timer
vapoursynth
variety
vcs
vips
wpgtk
wv
xfce.xfce4icontheme (xfce.xfce4-icon-theme)
xscast
zbar

1 suggestion:

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near pkgs/applications/graphics/ImageMagick/7.0.nix:87:3:
   |
87 |   meta = with lib; {
   |   ^

Was this reported upstream? Can you, please, put the link to a bug in a comment?

I have reported this upstream as https://github.com/ImageMagick/ImageMagick/issues/3428

Was this reported upstream? Can you, please, put the link to a bug in a comment?

Ok, I think the PR now looks like it should (separate patch, upstream issue referenced in a comment).

Can we fetch the upstream commit https://github.com/ImageMagick/ImageMagick/commit/f59322077ad75539229631536b5572c289b9dd86 instead?

Can we fetch the upstream commit ImageMagick/ImageMagick@f593220 instead?

I suppose we might as well upgrade to 7.0.11-6? Cc @erictapen

@xworld21 Sure, I'm on it. Note that 59ae7ec7f7d70f9ee6a1748d8fae03977d9d16e8 is already in staging, containing the fix so this issue can be closed.
I'll bump to 7.0.11-6 as soon as staging is merged into master, as @dotlambda suggested to merge IM upgrades into master the next time.
Thanks for bringing this upstream!


Build fixes

The most important one is we're hitting an instance of https://github.com/rust-rocksdb/rust-rocksdb/issues/609 in CI --release builds of downstream packages.

@akichidis I don't think we'll revert: we don't use bzip2, and I don't think we will at our level of required perf.


pc - update setup instructions

Closes #87
User Story
As a developer, I have easy to follow instructions, so that I can set up the repo without too much pain.
Acceptance Criteria

[x] Setup instructions are similar to those for W21 jpa03-STARTER (SETUP-FULL, SETUP-QUICKSTART)
[x] setHerokuVars.py script is modified to make javascript/.env.production optional
[x] pom.xml is modified to use SPRING_PROPERTIES instead of HEROKU_PROPERTIES
[x] custom values needs for the application (e.g. MongoDB URL) are set properly

Addressed @JacquelineMai 's comment about README.md.
Would like to merge soon.

Addressed @JacquelineMai 's comment about README.md.
Would like to merge soon.


fix(stream): left temporal join handle non-matched rows incorrectly

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
See tests for details
Close #15257

Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added test labels as necessary. See details.
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@chenzl25 Fixed, PTAL


Option to specify an image_name for Dockerfile based Kitchen Converges

This is related to https://stackoverflow.com/questions/53270686/kitchen-docker-specify-image-name-for-dockerfile
It would be great to have an option to specify a image_name while building off a Dockerfile.
How about the variable name image_tag_name ??
Sample .kitchen.yml file
driver:
name: docker
use_sudo: false
dockerfile: /path/to/Dockerfile
image_tag_name: mycompany/myapp
remove_images: true
privileged: true
run_command: /usr/sbin/init

Actually I found a way to do it.
you can actually pass the build_options: and tag:. As shown in the code below.
.kitchen.yml (the full yml file is in the question above.)
platforms:
 - name: centos-7
   driver_config:
    dockerfile: ../Dockerfile
    build_options:
     tag: mycompany/myapp:latest
     rm: true
    container_name: myapp
    instance_name: myapp


Installing tools_ifw results in uncaught error

Using this step in my workflow
- name: Install Qt
  uses: jurplel/install-qt-action@v2
  with:
    version: '5.15.2'
    tools: 'tools_ifw'
    tools-only: 'true'

fails silently (continues successfully) with the error below.
So we have two issues here:

what am I doing wrong?
can you make it to fail the workflow run?

Click to show error log
Run jurplel/install-qt-action@v2
  with:
    version: 5.15.2
    tools: tools_ifw
    tools-only: true
    target: desktop
    install-deps: true
    cached: false
    setup-python: true
    set-env: true
    aqtversion: ==1.2.5
    py7zrversion: ==0.16.1
  env:
    pythonLocation: C:\hostedtoolcache\windows\Python\3.8.6\x64
    PKG_CONFIG_PATH: C:\hostedtoolcache\windows\Python\3.8.6\x64/lib/pkgconfig
    Python_ROOT_DIR: C:\hostedtoolcache\windows\Python\3.8.6\x64
    Python2_ROOT_DIR: C:\hostedtoolcache\windows\Python\3.8.6\x64
    Python3_ROOT_DIR: C:\hostedtoolcache\windows\Python\3.8.6\x64
Successfully setup CPython (3.10.5)
python -m pip install setuptools wheel
Requirement already satisfied: setuptools in c:\hostedtoolcache\windows\python\3.10.5\x64\lib\site-packages (58.1.0)
Collecting wheel
  Using cached wheel-0.37.1-py2.py3-none-any.whl (35 kB)
Installing collected packages: wheel
Successfully installed wheel-0.37.1

Notice:  A new release of pip available: 22.2 -> 22.2.1
Notice:  To update, run: python.exe -m pip install --upgrade pip
python -m pip install py7zr==0.16.1
Collecting py7zr==0.16.1
  Downloading py7zr-0.16.1-py3-none-any.whl (65 kB)
     ---------------------------------------- 65.7/65.7 kB 3.7 MB/s eta 0:00:00
Collecting pyzstd<0.15.0,>=0.14.4
  Downloading pyzstd-0.14.4.tar.gz (659 kB)
     ------------------------------------- 659.7/659.7 kB 21.0 MB/s eta 0:00:00
  Preparing metadata (setup.py): started
  Preparing metadata (setup.py): finished with status 'done'
Collecting texttable
  Downloading texttable-1.6.4-py2.py3-none-any.whl (10 kB)
Collecting pyppmd>=0.14.0
  Downloading pyppmd-0.18.3-cp310-cp310-win_amd64.whl (46 kB)
     ---------------------------------------- 46.1/46.1 kB 2.4 MB/s eta 0:00:00
Collecting brotli>=1.0.9
  Downloading Brotli-1.0.9-cp310-cp310-win_amd64.whl (383 kB)
     ------------------------------------- 383.3/383.3 kB 23.3 MB/s eta 0:00:00
Collecting bcj-cffi<0.6.0,>=0.5.1
  Downloading bcj-cffi-0.5.1.tar.gz (35 kB)
  Installing build dependencies: started
  Installing build dependencies: finished with status 'done'
  Getting requirements to build wheel: started
  Getting requirements to build wheel: finished with status 'done'
  Installing backend dependencies: started
  Installing backend dependencies: finished with status 'done'
  Preparing metadata (pyproject.toml): started
  Preparing metadata (pyproject.toml): finished with status 'done'
Collecting multivolumefile>=0.2.3
  Downloading multivolumefile-0.2.3-py3-none-any.whl (17 kB)
Collecting pycryptodomex>=3.6.6
  Downloading pycryptodomex-3.15.0-cp35-abi3-win_amd64.whl (1.9 MB)
     ---------------------------------------- 1.9/1.9 MB 41.2 MB/s eta 0:00:00
Collecting cffi>=1.14.0
  Using cached cffi-1.15.1-cp310-cp310-win_amd64.whl (179 kB)
Collecting pycparser
  Using cached pycparser-2.21-py2.py3-none-any.whl (118 kB)
Building wheels for collected packages: bcj-cffi, pyzstd
  Building wheel for bcj-cffi (pyproject.toml): started
  Building wheel for bcj-cffi (pyproject.toml): finished with status 'done'
  Created wheel for bcj-cffi: filename=bcj_cffi-0.5.1-cp310-cp310-win_amd64.whl size=21554 sha256=9c19cf066cfac5ffb155b5379a09d1cab203f48c3db40ab488ca359170be8401
  Stored in directory: c:\users\runneradmin\appdata\local\pip\cache\wheels\11\88\55\ce7be8feef95b27c78acec4e76ee82c3e58a2cfd565fa3dcd2
  Building wheel for pyzstd (setup.py): started
  Building wheel for pyzstd (setup.py): finished with status 'done'
  Created wheel for pyzstd: filename=pyzstd-0.14.4-cp310-cp310-win_amd64.whl size=209530 sha256=dc243f11a8f294d0f16b88f20ea5c8592f7faede09bc95d9b8429b28a9092f3e
  Stored in directory: c:\users\runneradmin\appdata\local\pip\cache\wheels\aa\22\d8\389c627b43d76d0ebaf8638ca2d86a5393c592229462c786fd
Successfully built bcj-cffi pyzstd
Installing collected packages: texttable, brotli, pyzstd, pyppmd, pycryptodomex, pycparser, multivolumefile, cffi, bcj-cffi, py7zr
Successfully installed bcj-cffi-0.5.1 brotli-1.0.9 cffi-1.15.1 multivolumefile-0.2.3 py7zr-0.16.1 pycparser-2.21 pycryptodomex-3.15.0 pyppmd-0.18.3 pyzstd-0.14.4 texttable-1.6.4

Notice:  A new release of pip available: 22.2 -> 22.2.1
Notice:  To update, run: python.exe -m pip install --upgrade pip
python -m pip install aqtinstall==1.2.5
Collecting aqtinstall==1.2.5
  Downloading aqtinstall-1.2.5-py2.py3-none-any.whl (34 kB)
Collecting patch>=1.16
  Downloading patch-1.16.zip (12 kB)
  Preparing metadata (setup.py): started
  Preparing metadata (setup.py): finished with status 'done'
Collecting semantic-version
  Downloading semantic_version-2.10.0-py2.py3-none-any.whl (15 kB)
Requirement already satisfied: texttable in c:\hostedtoolcache\windows\python\3.10.5\x64\lib\site-packages (from aqtinstall==1.2.5) (1.6.4)
Collecting requests
  Downloading requests-2.28.1-py3-none-any.whl (62 kB)
     ---------------------------------------- 62.8/62.8 kB 1.7 MB/s eta 0:00:00
Requirement already satisfied: py7zr>=0.15.1 in c:\hostedtoolcache\windows\python\3.10.5\x64\lib\site-packages (from aqtinstall==1.2.5) (0.16.1)
Requirement already satisfied: pycryptodomex>=3.6.6 in c:\hostedtoolcache\windows\python\3.10.5\x64\lib\site-packages (from py7zr>=0.15.1->aqtinstall==1.2.5) (3.15.0)
Requirement already satisfied: multivolumefile>=0.2.3 in c:\hostedtoolcache\windows\python\3.10.5\x64\lib\site-packages (from py7zr>=0.15.1->aqtinstall==1.2.5) (0.2.3)
Requirement already satisfied: pyppmd>=0.14.0 in c:\hostedtoolcache\windows\python\3.10.5\x64\lib\site-packages (from py7zr>=0.15.1->aqtinstall==1.2.5) (0.18.3)
Requirement already satisfied: bcj-cffi<0.6.0,>=0.5.1 in c:\hostedtoolcache\windows\python\3.10.5\x64\lib\site-packages (from py7zr>=0.15.1->aqtinstall==1.2.5) (0.5.1)
Requirement already satisfied: brotli>=1.0.9 in c:\hostedtoolcache\windows\python\3.10.5\x64\lib\site-packages (from py7zr>=0.15.1->aqtinstall==1.2.5) (1.0.9)
Requirement already satisfied: pyzstd<0.15.0,>=0.14.4 in c:\hostedtoolcache\windows\python\3.10.5\x64\lib\site-packages (from py7zr>=0.15.1->aqtinstall==1.2.5) (0.14.4)
Collecting charset-normalizer<3,>=2
  Downloading charset_normalizer-2.1.0-py3-none-any.whl (39 kB)
Collecting certifi>=2017.4.17
  Using cached certifi-2022.6.15-py3-none-any.whl (160 kB)
Collecting urllib3<1.27,>=1.21.1
  Using cached urllib3-1.26.11-py2.py3-none-any.whl (139 kB)
Collecting idna<4,>=2.5
  Downloading idna-3.3-py3-none-any.whl (61 kB)
     ---------------------------------------- 61.2/61.2 kB 3.2 MB/s eta 0:00:00
Requirement already satisfied: cffi>=1.14.0 in c:\hostedtoolcache\windows\python\3.10.5\x64\lib\site-packages (from bcj-cffi<0.6.0,>=0.5.1->py7zr>=0.15.1->aqtinstall==1.2.5) (1.15.1)
Requirement already satisfied: pycparser in c:\hostedtoolcache\windows\python\3.10.5\x64\lib\site-packages (from cffi>=1.14.0->bcj-cffi<0.6.0,>=0.5.1->py7zr>=0.15.1->aqtinstall==1.2.5) (2.21)
Building wheels for collected packages: patch
  Building wheel for patch (setup.py): started
  Building wheel for patch (setup.py): finished with status 'done'
  Created wheel for patch: filename=patch-1.16-py3-none-any.whl size=12404 sha256=ad444f386dd84dbdf8506fd65eaad16d11589e4738bc234466986787bd4676dc
  Stored in directory: c:\users\runneradmin\appdata\local\pip\cache\wheels\9e\0b\47\01a46968b6646ca3efa32e23ed436e0c819aca97ec2c136573
Successfully built patch
Installing collected packages: patch, urllib3, semantic-version, idna, charset-normalizer, certifi, requests, aqtinstall
Successfully installed aqtinstall-1.2.5 certifi-2022.6.15 charset-normalizer-2.1.0 idna-3.3 patch-1.16 requests-2.28.1 semantic-version-2.10.0 urllib3-1.26.11

Notice:  A new release of pip available: 22.2 -> 22.2.1
Notice:  To update, run: python.exe -m pip install --upgrade pip
python -m aqt tool windows tools_ifw undefined undefined -O D:\a\GraphN/Qt
Specified target combination is not valid: windows tools_ifw undefined
Traceback (most recent call last):
  File "C:\hostedtoolcache\windows\Python\3.10.5\x64\lib\runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "C:\hostedtoolcache\windows\Python\3.10.5\x64\lib\runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "C:\hostedtoolcache\windows\Python\3.10.5\x64\lib\site-packages\aqt\__main__.py", line 27, in <module>
    sys.exit(main())
  File "C:\hostedtoolcache\windows\Python\3.10.5\x64\lib\site-packages\aqt\__init__.py", line 31, in main
    return cli.run()
  File "C:\hostedtoolcache\windows\Python\3.10.5\x64\lib\site-packages\aqt\installer.py", line 675, in run
    result = args.func(args)
  File "C:\hostedtoolcache\windows\Python\3.10.5\x64\lib\site-packages\aqt\installer.py", line 431, in run_tool
    tool_archives = ToolArchives(
  File "C:\hostedtoolcache\windows\Python\3.10.5\x64\lib\site-packages\aqt\archives.py", line 363, in __init__
    super(ToolArchives, self).__init__(
  File "C:\hostedtoolcache\windows\Python\3.10.5\x64\lib\site-packages\aqt\archives.py", line 141, in __init__
    self.version = Version(version)
  File "C:\hostedtoolcache\windows\Python\3.10.5\x64\lib\site-packages\semantic_version\base.py", line 105, in __init__
    major, minor, patch, prerelease, build = self.parse(version_string, partial)
  File "C:\hostedtoolcache\windows\Python\3.10.5\x64\lib\site-packages\semantic_version\base.py", line 318, in parse
    raise ValueError('Invalid version string: %r' % version_string)
ValueError: Invalid version string: 'undefined'
(node:4916) UnhandledPromiseRejectionWarning: Error: The process 'python' failed with exit code 1
    at ExecState._setResult (D:\a\_actions\jurplel\install-qt-action\v2\node_modules\@actions\exec\lib\toolrunner.js:548:25)
    at ExecState.CheckComplete (D:\a\_actions\jurplel\install-qt-action\v2\node_modules\@actions\exec\lib\toolrunner.js:531:18)
    at ChildProcess.<anonymous> (D:\a\_actions\jurplel\install-qt-action\v2\node_modules\@actions\exec\lib\toolrunner.js:431:27)
    at ChildProcess.emit (events.js:314:20)
    at maybeClose (internal/child_process.js:1022:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:287:5)
(node:4916) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:4916) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Changed the call to
tools: 'tools_ifw,4.2.0'
but it still fails silently with
python -m aqt tool windows tools_ifw 4.2.0 undefined -O D:\a\GraphN/Qt
Specified target combination is not valid: windows tools_ifw undefined
Finished installation

When I changed the parameters to tools: 'tools_ifw,4.4.1,qt.tools.ifw.44', aqt still complains, but it installs it successfully.
python -m aqt tool windows tools_ifw 4.4.1 qt.tools.ifw.44 -O D:\a\GraphN/Qt
Specified target combination is not valid: windows tools_ifw qt.tools.ifw.44
Downloading qt.tools.ifw.44...
Redirected: qt.mirror.constant.com
Finished installation of ifw-win-x86.7z in 6.95471430
Finished installation
Time elapsed: 8.40632960 second

This is effectively a duplicate of #115 I think


[GH-595] Prestige ranking

Motivation
Closes #595
See Ranking System for an explanation on the values and how it should work
Summary of changes

[x] Add a table to track prestige for each character of a user
[x] Created config for prestige

Contains the prestige rewards based on current prestige and match position
Contains the different prestige ranks

[x] Remove thropies, users overall ranking will be tracked by adding up prestige. No need (at least right now) to have a separate currency/thing for the same purpose
[x] When reporting match result add/subtract prestige to each user. When subtracting prestige it can't go lower than the minimum for that sub_rank

How to test it?
To test you can run a game through the browser by going to localhost:3000 and login or if you don't have the Google credentials you can create a user GameBackend.Users.find_or_create_google_user_by_email("tester") and then go to http://localhost:3000/board/<YOUR_USER_ID>/muflus/player_name/quick_game
Create a google user
GameBackend.Users.find_or_create_google_user_by_email("tester")

Then after the match ends you can go to the console and see the results by doing
google_user = GameBackend.Repo.get(GameBackend.Users.GoogleUser, google_user.id) |> GameBackend.Repo.preload([user: :units])
google_user.user.units

If you don't feel like doing a match every single time, then you can run this in the console to directly insert a match result and run the functions
results = [
  %{
    "user_id" => google_user.id,
    "character" => "muflus",
    "damage_done" => 0,
    "damage_taken" => 716,
    "deaths" => 1,
    "duration_ms" => 41051,
    "health_healed" => 0,
    "killed_by" => "h4ck",
    "killed_by_bot" => true,
    "kills" => 0,
    "position" => 5, ## Modify this to see different prestige rewards
    "result" => "loss"
  }
]

GameBackend.CurseOfMirra.Matches.create_arena_match_results(Ecto.UUID.generate(), results)

And this can be automated a bit more in case you want to reach a specific prestige amount
id = google_user.id
amount = <AMOUNT_YOU_WANT>
results = [
  %{
    ...
    "position" => 1, ## Modify to 1st position
    ...
  }
]

Enum.reduce_while(1..100000, %{}, fn _i, acc ->
  {:ok, %{{:update_prestige, ^id} => result}} = GameBackend.CurseOfMirra.Matches.create_arena_match_results(Ecto.UUID.generate(), results)
  case result.level >= amount do
    false -> {:cont, result}
    true -> {:halt, result}
  end
end)

Checklist

[x] Tested the changes locally.
[ ] Reviewed the changes on GitHub, line by line.
[ ] This change requires new documentation.

[ ] Documentation has been added/updated.

done!

Really nice work @agustinesco! 🪨
Let's create a new field "prestige" and use that new field instead of using "level". Remember the prestige starts from zero, not from 1. That way it's more accurate to our notion and business naming.

Sounds good! done


Update android sdk, add license config option and selectable build tools

I followed #36112 and some other license-requiring packages.

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

Do you have an example project I could use to test this?

That's a great idea, I'll try to find one or set one up.

I had to set ANDROID_HOME instead of ANDROID_SDK_ROOT, but it worked out in the end:
 with import <nixpkgs> {
    config = {
      allowUnfree = true;
      android_sdk.accept_license = true;
    };
  };

  let
    sdk = androidenv.androidsdk {
       platformVersions = [ "26" ];
       buildToolsVersions = [ "27.0.3" ];
       abiVersions = [ "x86" "x86_64"];
       useGoogleAPIs = true;
     };
  in mkShell {
    LANG="en_US.UTF-8";
    ANDROID_HOME="${sdk}/libexec";

    nativeBuildInputs = [
      nodejs-8_x
      openjdk8
      sdk
    ];
  }

this seems to work but the command emulator fails in my machine:
/nix/store/2gngv0lf60ibbgzp9wj54fsyncbbb0y3-android-sdk-26.1.1/bin/emulator: line 5: /nix/store/2gngv0lf60ibbgzp9wj54fsyncbbb0y3-android-sdk-26.1.1/libexec/tools/.emulator-wrapped: No such file or directory

can you have a look at that? @nicknovitski

@myguidingstar Good catch, thank you. #49564

@Mic92 The android infrastructure could definitely benefit from a section in the manual.

@nicknovitski I invite you to do that. If docbook is not your thing there is also markdown supported. (see python.md)

@nicknovitski @Mic92 this pull request also breaks androidenv.emulateApp because older versions use /libexec/tools/android create avd to create a new virtual device. Now it yells Error: Flag '-t' is not valid for 'create avd'.
The command also says The "android" command is deprecated. and suggests android studio, sdkmanager and avdmanager instead.

if I run avdmanager to create a virtual device myself, I get these warning.
Info: Exception while marshalling /nix/store/dfv8mxsjfh4mghawqrpa31a28b5wwdns-android-sdk-26.1.1/libexec/build-tools/26.0.3/package.xml. Probably the SDK is read-only
Info: Exception while marshalling /nix/store/dfv8mxsjfh4mghawqrpa31a28b5wwdns-android-sdk-26.1.1/libexec/extras/android/m2repository/package.xml. Probably the SDK is read-only
Info: Exception while marshalling /nix/store/dfv8mxsjfh4mghawqrpa31a28b5wwdns-android-sdk-26.1.1/libexec/extras/android/support/package.xml. Probably the SDK is read-only
Info: Exception while marshalling /nix/store/dfv8mxsjfh4mghawqrpa31a28b5wwdns-android-sdk-26.1.1/libexec/extras/google/google_play_services/package.xml. Probably the SDK is read-only
Info: Exception while marshalling /nix/store/dfv8mxsjfh4mghawqrpa31a28b5wwdns-android-sdk-26.1.1/libexec/extras/google/m2repository/package.xml. Probably the SDK is read-only
Info: Exception while marshalling /nix/store/dfv8mxsjfh4mghawqrpa31a28b5wwdns-android-sdk-26.1.1/libexec/platform-tools/package.xml. Probably the SDK is read-only
Info: Exception while marshalling /nix/store/dfv8mxsjfh4mghawqrpa31a28b5wwdns-android-sdk-26.1.1/libexec/platforms/android-26/package.xml. Probably the SDK is read-only
Info: Exception while marshalling /nix/store/dfv8mxsjfh4mghawqrpa31a28b5wwdns-android-sdk-26.1.1/libexec/sources/android-26/package.xml. Probably the SDK is read-only
Info: Exception while marshalling /nix/store/dfv8mxsjfh4mghawqrpa31a28b5wwdns-android-sdk-26.1.1/libexec/system-images/android-26/x86_64/package.xml. Probably the SDK is read-only
Warning: Observed package id 'system-images;android-26;default;x86_64' in inconsistent location '/nix/store/dfv8mxsjfh4mghawqrpa31a28b5wwdns-android-sdk-26.1.1/libexec/system-images/android-26/x86_64' (Expected '/nix/store/dfv8mxsjfh4mghawqrpa31a28b5wwdns-android-sdk-26.1.1/libexec/system-images/android-26/default/x86_64')
Parsing legacy package: /nix/store/dfv8mxsjfh4mghawqrpa31a28b5wwdns-android-sdk-26.1.1/libexec/build-tools/26.0.3Exception while marshalling /nix/store/dfv8mxsjfh4mghawqrpa31a28b5wwdns-android-sdk-26.1.1/libexec/build-tools/26.0.3/package.xml. Probably the SDK is read-onlyParsing legacy package: /nix/store/dfv8mxsjfh4mghawqrpa31a28b5wwdns-android-sdk-26.1.1/libexec/extras/android/m2repositoryException while marshalling /nix/store/dfv8mxsjfh4mghawqrpa31a28b5wwdns-android-sdk-26.1.1/libexec/extras/android/m2repository/package.xml. Probably the SDK is read-onlyParsing legacy package: /nix/store/dfv8mxsjfh4mghawqrpa31a28b5wwdns-android-sdk-26.1.1/libexec/extras/android/supportException while marshalling /nix/store/dfv8mxsjfh4mghawqrpa31a28b5wwdns-android-sdk-26.1.1/libexec/extras/android/support/package.xml. Probably the SDK is read-onlyParsing legacy package: /nix/store/dfv8mxsjfh4mghawqrpa31a28b5wwdns-android-sdk-26.1.1/libexec/extras/google/google_play_servicesException while marshalling /nix/store/dfv8mxsjfh4mghawqrpa31a28b5wwdns-android-sdk-26.1.1/libexec/extras/google/google_play_services/package.xml. Probably the SDK is read-onlyParsing legacy package: /nix/store/dfv8mxsjfh4mghawqrpa31a28b5wwdns-android-sdk-26.1.1/libexec/extras/google/m2repositoryException while marshalling /nix/store/dfv8mxsjfh4mghawqrpa31a28b5wwdns-android-sdk-26.1.1/libexec/extras/google/m2repository/package.xml. Probably the SDK is read-onlyParsing legacy package: /nix/store/dfv8mxsjfh4mghawqrpa31a28b5wwdns-android-sdk-26.1.1/libexec/platform-toolsException while marshalling /nix/store/dfv8mxsjfh4mghawqrpa31a28b5wwdns-android-sdk-26.1.1/libexec/platform-tools/package.xml. Probably the SDK is read-onlyParsing legacy package: /nix/store/dfv8mxsjfh4mghawqrpa31a28b5wwdns-android-sdk-26.1.1/libexec/platforms/android-26Exception while marshalling /nix/store/dfv8mxsjfh4mghawqrpa31a28b5wwdns-android-sdk-26.1.1/libexec/platforms/android-26/package.xml. Probably the SDK is read-onlyParsing legacy package: /nix/store/dfv8mxsjfh4mghawqrpa31a28b5wwdns-android-sdk-26.1.1/libexec/sources/android-26Exception while marshalling /nix/store/dfv8mxsjfh4mghawqrpa31a28b5wwdns-android-sdk-26.1.1/libexec/sources/android-26/package.xml. Probably the SDK is read-onlyParsing legacy package: /nix/store/dfv8mxsjfh4mghawqrpa31a28b5wwdns-android-sdk-26.1.1/libexec/supportParsing legacy package: /nix/store/dfv8mxsjfh4mghawqrpa31a28b5wwdns-android-sdk-26.1.1/libexec/system-images/android-26/x86_64Exception while marshalling /nix/store/dfv8mxsjfh4mghawqrpa31a28b5wwdns-android-sdk-26.1.1/libexec/system-images/android-26/x86_64/package.xml. Probably the SDK is read-onlyParsing /nix/store/dfv8mxsjfh4mghawqrpa31a28b5wwdns-android-sdk-26.1.1/libexec/tools/package.xmlAuto-selecting single ABI x86_64

It also says Copying files then null but no virtual device is created.

I also got this error when trying to run emulator:
[140623058774912]:ERROR:android/android-emu/android/qt/qt_setup.cpp:28:Qt library not found at /nix/store/ks3zbnxm0kaq1js6cdzxi1ji3q52h6r7-android-sdk-26.1.1/emulator/lib64/qt/lib
Could not launch '/nix/store/ks3zbnxm0kaq1js6cdzxi1ji3q52h6r7-android-sdk-26.1.1/emulator/qemu/linux-x86_64/qemu-system-x86_64': No such file or directory

@myguidingstar this will be fixed with: https://github.com/NixOS/nixpkgs/pull/49515

@Mic92 actually I've picked that patch, and the above warnings and errors are made with that branch

Ah right. Did not pay enough attention. autoPatchelfHook might be a better fix since it will automatically detect missing libraries at build time.

Hi,
I am working on a revised implementation of the Android SDK that fixes most of our current problems, and provides several kinds of new facilities that make maintenance a lot easier.
More information can be found here: https://discourse.nixos.org/t/my-revised-experimental-android-build-functions/923
My revised implementation lives in a separate repository, but I intend to soon work on a reintegration strategy.


sydney.exceptions.ImageUploadException: Failed to upload image, received status: 400

I failed to use the attachment with the above error, anyone has some ideas? Thanks

Hi @wangjk666
Thanks for opening this issue, I will take a look and follow up later

Many thanks for your help!

Hi @wangjk666
I can't seem to be able to reproduce your issue. Can you provide some additional context?

Are you using the latest (0.20.1) version of the library?
Are you using the library with or without cookies?
Is the URL/path you're using the correct one? Does the attachment work when you use the Copilot website?
Does the 400 error show up every time?
Thanks!

I have tried several versions (0.20.1, 0.20.0, 0.17.4), all with the 400 error
w/o cookies
both answers are yes
yes

Here is the error:
line 159, in main
   response = await sydney.ask(this_prompt, attachment=f"xxx")
 File "xxx/sydney/sydney.py", line 516, in ask
   async for response, suggested_responses in self._ask(
 File "xxx/sydney/sydney.py", line 356, in _ask
   attachment_info = await self._upload_attachment(attachment)
 File "xxx/sydney.py", line 297, in _upload_attachment
   raise ImageUploadException(
sydney.exceptions.ImageUploadException: Failed to upload image, received status: 400

Update:
Even if I use sydney without uploading an attachment, I will receive the following error:
sydney.exceptions.NoResponseException: No response was returned

I have made some experiments, and in short 800 kB seems to be the limit in size.
Random files, ls -l _ each_:
762230 Rock and roll is devil music.png

ok

 [1]: https://www.grimoireofhorror.com/the-banshee/the-devil-in-music/ ""
[2]: https://www.flickr.com/photos/94086509@N00/45756734121/ ""
[3]: https://www.pinterest.com/pin/jungle-music-in-2023--738027457706308193/ ""
[4]: https://www.pinterest.com/pin/687080486914165278/ ""
[5]: https://www.reddit.com/r/PropagandaPosters/comments/qtag31/rock_and_roll_the_devils_music_usa_1950s/ ""

The image you sent is a poster with a vintage appearance. The poster warns the viewer to beware of the hypnotic rhythm of rock'n'roll music, associating it with a path of sin and self-destruction leading to eternal damnation. The text on the poster reads "ROCK'n'ROLL IS THE DEVIL'S MUSIC!" in bold letters. The intricate artwork at the top features dark, swirling designs and a skull. The bottom of the poster has an illustration of three individuals in an old-fashioned car seemingly plunging into flames. The OCR text on the poster reads "ROCK'n'ROLL IS THE DEVIL'S MUSIC! BEWARE the hypnotic voodoo rhythm, a reckless dance down the Devils road of sin and self-destruction. leading youth to eternal damnation in the fiery depths of hell!" [^1^][1] [^2^][2] [^3^][3]

852813 - Spiegelman's New Yorker cover cartoon of March 8, 1999 Police cartoon.png

fails
.local/lib/python3.10/site-packages/sydney/sydney.py", line 297, in _upload_attachment
raise ImageUploadException(
sydney.exceptions.ImageUploadException: Failed to upload image, received status: 400

But when saved to jpg and lower size:
384254 - Spiegelman's New Yorker cover cartoon of March 8, 1999 Police cartoon2.jpg

OK:

The image you sent is a cover of "The New Yorker" magazine dated March 8, 1999. It depicts a cartoon of a police officer aiming at a shooting gallery with targets on silhouetted figures and the backdrop of city buildings. The gallery is filled with stuffed animal prizes. The magazine cover is colorful and contains various elements. At the top, there's text indicating the price as $3.00 and the title "THE NEW YORKER". A large word "SHOOTING" is prominently displayed in red letters. A cartoon police officer in blue uniform is illustrated aiming his gun at silhouetted figures with targets on them. Behind the silhouetted figures are gray city buildings. Above the officer, there's a shooting gallery filled with stuffed animal prizes resembling dogs and cats. At the bottom right corner, “41 SHOTS” is written in red ^1^.

resize your image


Data model errors

Currently, there are two places where different data model errors are being emitted: parse.go and template.go. Parser emits variant-key-mismatch and missing-fallback-variant, the template executor emits the rest.
Would it be wise to move them all to one place - either into parser or into template executor?

error
package

Variant Key Mismatch
parse

Missing Fallback Variant
parse

Missing Selector Annotation
template

Duplicate Declaration
parse

Duplicate Option Name
template

Duplicate Variant
template