ccache: 4.2 -> 4.2.1

Motivation for this change
Update to the latest version: https://github.com/ccache/ccache/releases/tag/v4.2.1
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@r-burns @veprbl

I've created an upstream pull request for env-instead-of-compgen.patch: https://github.com/ccache/ccache/pull/835/files.

Also, test.basedir usually passes on Darwin, but it occasionally fails, so I've disabled it.

Result of nixpkgs-review pr 119176 at dbeee740 run on aarch64-linux 1

2 packages built successfully:

ccache
ccacheStdenv

@kira-bruneau It looks like test.modules started failing again on Hydra some while ago: https://hydra.nixos.org/build/144701939/nixlog/1
Do you know if it's the same error message as before?

Hmm, so this broke between the 4.2.1 bump and the 4.3 bump. Git bisect tells me that something in the #122068 staging-next cycle was the cause. @kira-bruneau, I think our macOS testing setups must differ in some way if https://github.com/NixOS/nixpkgs/pull/122492#issuecomment-837413608 succeeded for you. I'm on 10.15 with a sandboxed multi-user Nix install and getting the same errors as hydra.

Ah, I suppose sandbox on/off might explain it!
(I don't use macOS myself, just on CI)

Oh right, yeah sorry I had the sandbox disabled because there were some problems with it on Big Sur: https://github.com/NixOS/nix/issues/4658. I think the fix should be available in nixUnstable, so I will try it out.

I bisected the issue to 96bbe339d47d4bc78cc9eaf0845734f80fe2d56b but don't see why that would have caused this regression.
Maybe the isCxx flag in the cc-wrapper is not being set (so c++ includes are not available) because clang is not being invoked like a typical c++ compiler? The command line in the module test looks like this:
/tmp/nix-build-ccache-4.2.1.drv-0/source/build/ccache clang -fmodules -fcxx-modules -c test1.cpp -MD
The progname is simply clang and there is no -x c++ option, so maybe we should add another case to the cc-wrapper so that -fcxx-modules enables isCxx:
https://github.com/NixOS/nixpkgs/blob/961cae37edeb34b5dec8060e49e5abbde3af9c00/pkgs/build-support/cc-wrapper/cc-wrapper.sh#L54-L55
Or maybe c++ includes should always be enabled, since clang is able to automatically detect that this .cpp file is c++.

Ok, now that I've looked at this a bit, it's much more clear to me. https://github.com/NixOS/nixpkgs/commit/96bbe339d47d4bc78cc9eaf0845734f80fe2d56b broke this because after that revert, including C++ standard library headers requires isCxx to be set, in addition to the more lenient cxxInclude.
https://github.com/NixOS/nixpkgs/commit/54c7a0f42287f63c2db8086a8ad46ac981364378 must have fixed the ccache module test, which is why we were were able to originally un-disable it. My kneejerk reaction is to want to un-revert the commit, but clearly there are bigger-picture issues with making the C++ standard library includes always available, so I'll leave that to people more versed in stdenv.
In the meantime, I see two potential fixes for this:

tell ccache to use -x c++ when using ordinary clang to compile C++ code, as our toolchain otherwise won't enable C++ standard library includes
have -fcxx-modules enable isCxx


Additional context and questions for operator capabilities

Description of the change:
Adding additional context and questions to the operator capability levels based on additional changes I have made to https://docs.google.com/document/d/1xGRdDO04VjQSRMUHi1JfSakrpDSi-cosV5ppeWcay_A/edit# since this PR was created.
Motivation for the change:
Provide a little bit more detail around each capability level.

@dmesser @shawn-hurley @camilamacedo86 If you have any time to review this, that would be fantastic.

@dmesser Thank you very much for the review, addressed the comments now based on your feedback.

@dmesser If you have time, another review on this after addressing the feedback would be great.

@davidffrench I think @asmacdo is still implementing the docs pipeline. Probably safe to ignore for now.

@davidffrench I think @asmacdo is still implementing the docs pipeline. Probably safe to ignore for now.

Thanks @dmesser . Will ignore the tests. I have pushed the RED method footnote now, this is ready for another review.

@davidffrench Makes sense. Can you apply your changes also the the copy of operator-capabilities.md in doc/website/content/en ? We are currently migrating our docs and need to ensure, that during the transition period stuff stays in sync.

@davidffrench Makes sense. Can you apply your changes also the the copy of operator-capabilities.md in doc/website/content/en ? We are currently migrating our docs and need to ensure, that during the transition period stuff stays in sync.

Done now @dmesser

@davidffrench I don't see it. Did you push your commit?

Apologies @dmesser . Pushed and tabbed out of the terminal. Needed to force push after rebasing from master. Done now


Fix leaking threads in backup

What changes are proposed in this pull request?
This closes the thread pools used during backup and restore from backup.
Why are the changes needed?
Since the thread pools were not being closed, the threads were being leaked and not garbage collected.
Does this PR introduce any user facing changes?
No

alluxio-bot, merge this please


Can't find mfem

I have set MFEM_DIR as C/mfem, where mfem is installed. However, error occurs as

Well, mfem is found. But SDL2 library is not found.

Okay, I have installed the missing package via pacman and accomplished compiling. But when trying to run it, error comes as
libwinpthread-1.dll libstdc++-6.dll libgcc_s_seh-1.dll libfontconfig-1.dll missing.

I assume you are using Windows from the .dll shared library suffix. Please make sure your mingw setup provides the appropriate shared libraries.

You can also try these steps (using vcpkg): https://github.com/GLVis/glvis/blob/92595f9c5ee58e729bc2368d452039eb80eeee56/INSTALL#L152-L172

Oh my bad. I need to tap in commands.

Without command line options, GLVis starts in server mode and accepts TCP connections from other (MFEM based, typically) applications such as ex1 and ex1p from MFEM.
For some of the basics, see https://glvis.org/options-and-use and https://mfem.org/serial-tutorial.


Update servers.json for DarkMC

General:

[ ] The pull request title is descriptive. (ex. Added Lunar Network, not Updated servers.json)
[ ] The pull request does not contain any unrelated commits.  (ex. commits from previous pull requests)

Mapping Additions or Updates:

[ ] My formatting matches the pre-existing formatting.
[ ] There are no syntax errors.
[ ] There is no pre-existing mapping with my id.
[ ] My field values match your requirements.
You can view our patterns here: servers.schema.json, or take a look below and complete the field checklist:

[ ] id: a lowercase string (ex. myserver)
[ ] name: a string (ex. MyServerPvP)
[ ] addresses: an array with lowercase strings (ex. of address my.server)

You do not need to specify sub-domains, Lunar Client services automatically detect them.

Logo Additions or Updates:

[ ] My image is a .png file.
[ ] I uploaded the image in the logos directory.
[ ] My image is transparent & square (1:1 aspect ratio).
[ ] My image is a minimum of 512 pixels in width and height.
[ ] My images image name matches its mapping id.

I made this pull request again because yesterday I only made a pull request on the DarkMC Network logo, now I'm adding it to the servers.json as well


Documentation link on wiki has malformed URL (Bugzilla Bug 2469)

This issue was created automatically with bugzilla2github
Bugzilla Bug 2469
Date: 2020-01-16T15:02:53+00:00
From: David Harris <>
To:   @mdkinney
CC:
Last updated: 2020-01-16T15:02:53+00:00

Comment 10925
Date: 2020-01-16 15:02:53 +0000
From: David Harris <>

Industry Specification: ---
Target OS: ---
Bugzilla Assignee(s): @mdkinney

Link on page https://github.com/tianocore/tianocore.github.io/wiki/EDK-User-Documentation
named EFI/ UEFI Driver Library Specification
points to
http://sourceforge.net/projects/efidevkit/files/Documents/EfiDriverLib.pdf/download/download
But will not resoleve unless the trailing (duplicate) /download is removed.


New (enhanced?) redirection system

New (enhanced?) redirection system
This PR introduces breaking changes
I propose a new redirection system which seems more straightforward for me at least.
I have also added the possibility to add a cooldown to the redirection.
Also, I felt that having a whole file to instantiate and execute the redirection is a bit overkill. I have therefore made the redirection in the HTML file itself.
This new system also takes care of both fr and fr-FR languages.
For instance, if we set up a redirection with these languages (order matters, first is the default): en-US, fr-FR, fr-CA and the user has accepted these languages: jp-JP, fr; he will be redirected to fr-FR because fr-FR is the first code in french.

@Sukaato I have updated redirection.js with your requested changes. Could you resolve the conflict in index.html?


'Uncaught Error: Cannot find module 'function e(t,n,r)...

Basically a function is passed as module name in resulted code. I believe it's the same issue as reported in https://github.com/jmreidy/grunt-browserify/issues/149. The project I'm working on is open source, you can see it here at https://github.com/mohsen1/swagger-docs

For the recored, this is happening at mohsen1/swagger-docs@ 510f53596d8d4832515ae31eba2feea388ba8b60 right now.

Did you manage to solve it?

@jacktator I don't remember haha! I guess I stopped using browserify then...

This is an issue with concat. See this stackoverflow question for some "hotfix" type solutions. I switched to brunch because it fixed all problems I had with browserify


Lock store endpoint_config has no attribute 'type'

Rasa version:1.9.5
Rasa SDK version (if used & relevant):
Rasa X version (if used & relevant): 0.27.4
Python version: rasa x docker image
Operating system (windows, osx, ...): rasa x docker image
Issue:
This line https://github.com/RasaHQ/rasa/blob/master/rasa/core/lock_store.py#L250 should be lock_store = _load_from_module_string(endpoint_config)
endpoint_config is a string so it has no attribute type and fails with this error:
Error (including full traceback):
2020-06-16 14:03:23 INFO     root  - Starting Rasa server on http://localhost:5005
2020-06-16 14:03:24.004532: E tensorflow/stream_executor/cuda/cuda_driver.cc:351] failed call to cuInit: UNKNOWN ERROR (303)
Experienced exception while trying to serve
Traceback (most recent call last):
  File "/opt/venv/lib/python3.7/site-packages/rasa/core/lock_store.py", line 261, in _load_from_module_string
    lock_store_class = common.class_from_module_path(endpoint_config.type)
AttributeError: 'str' object has no attribute 'type'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/opt/venv/lib/python3.7/site-packages/sanic/app.py", line 1167, in run
    serve(**server_settings)
  File "/opt/venv/lib/python3.7/site-packages/sanic/server.py", line 892, in serve
    trigger_events(before_start, loop)
  File "/opt/venv/lib/python3.7/site-packages/sanic/server.py", line 668, in trigger_events
    loop.run_until_complete(result)
  File "uvloop/loop.pyx", line 1456, in uvloop.loop.Loop.run_until_complete
  File "/opt/venv/lib/python3.7/site-packages/rasa/core/run.py", line 245, in load_agent_on_start
    _lock_store = LockStore.create(endpoints.lock_store)
  File "/opt/venv/lib/python3.7/site-packages/rasa/core/lock_store.py", line 38, in create
    return _create_from_endpoint_config(obj)
  File "/opt/venv/lib/python3.7/site-packages/rasa/core/lock_store.py", line 250, in _create_from_endpoint_config
    lock_store = _load_from_module_string(endpoint_config.type)
  File "/opt/venv/lib/python3.7/site-packages/rasa/core/lock_store.py", line 265, in _load_from_module_string
    f"Could not find a class based on the module path "
AttributeError: 'str' object has no attribute 'type'
Traceback (most recent call last):
  File "/opt/venv/lib/python3.7/site-packages/rasa/core/lock_store.py", line 261, in _load_from_module_string
    lock_store_class = common.class_from_module_path(endpoint_config.type)
AttributeError: 'str' object has no attribute 'type'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/opt/venv/bin/rasa", line 8, in <module>
    sys.exit(main())
  File "/opt/venv/lib/python3.7/site-packages/rasa/__main__.py", line 91, in main
    cmdline_arguments.func(cmdline_arguments)
  File "/opt/venv/lib/python3.7/site-packages/rasa/cli/run.py", line 114, in run
    rasa.run(**vars(args))
  File "/opt/venv/lib/python3.7/site-packages/rasa/run.py", line 56, in run
    **kwargs,
  File "/opt/venv/lib/python3.7/site-packages/rasa/core/run.py", line 216, in serve_application
    endpoints.lock_store if endpoints else None
  File "/opt/venv/lib/python3.7/site-packages/sanic/app.py", line 1167, in run
    serve(**server_settings)
  File "/opt/venv/lib/python3.7/site-packages/sanic/server.py", line 892, in serve
    trigger_events(before_start, loop)
  File "/opt/venv/lib/python3.7/site-packages/sanic/server.py", line 668, in trigger_events
    loop.run_until_complete(result)
  File "uvloop/loop.pyx", line 1456, in uvloop.loop.Loop.run_until_complete
  File "/opt/venv/lib/python3.7/site-packages/rasa/core/run.py", line 245, in load_agent_on_start
    _lock_store = LockStore.create(endpoints.lock_store)
  File "/opt/venv/lib/python3.7/site-packages/rasa/core/lock_store.py", line 38, in create
    return _create_from_endpoint_config(obj)
  File "/opt/venv/lib/python3.7/site-packages/rasa/core/lock_store.py", line 250, in _create_from_endpoint_config
    lock_store = _load_from_module_string(endpoint_config.type)
  File "/opt/venv/lib/python3.7/site-packages/rasa/core/lock_store.py", line 265, in _load_from_module_string
    f"Could not find a class based on the module path "
AttributeError: 'str' object has no attribute 'type'

Thanks for raising this issue, @erohmensing will get back to you about it soon✨
Please also check out the docs and the forum in case your issue was raised there too 🤗

Following up @erohmensing @sara-tagger

ping

@tatianafrank Thank you for spotting this! The bug will be fixed in the next release.

Thanks @chkoss ! When is the next release scheduled for?


ISPN-11424 Remove deprecated memory configurations from internal caches

https://issues.redhat.com/browse/ISPN-11424

@ryanemerson This will silence the WARNs

I see a single related failure: org.infinispan.client.hotrod.event.ClientClusterExpirationEventsTest.testNullValueMetadataExpiration

This is also failing on master unfortunately:
https://ci.infinispan.org/job/Infinispan/job/master/2030/#showFailuresLink
https://ci.infinispan.org/job/Infinispan/job/master/2011/#showFailuresLink

Thanks @gustavonalle


Complex RDF takes lot of time from Jena

Jena takes a lots of time to compile small RDF model and it might now scale very well when we add more data.  This is particularly an issue when using EmbeddedStore.  We are using full OWL reasoner, maybe we could settle for something less demanding (we need a limited set of functionnalities like symmetrics, inverseOf, transitivity and inheritance (others ).
Another option is to NOT use RDF and rely on a clever relational database for the whole database and just pull RDF from it to create the landing page.

See #27.


Add pypsark api for Optimize

Can we add functions to DeltaTable to perform optimization in pyspark ?
Or is there any other way to do in the delta release 1.2.0 ?

Hi @KeertiBafna, currently there are Python APIs for optimize. Scala APIs are being added in https://github.com/delta-io/delta/pull/961. Let us know if you are interested in contributing the Python APIs.

Hi @vkorukanti 👋 I can work on this if it's ok.

@vkorukanti I initiated some draft work here. You can check it out and let me what you think. I am planning to test this by building #961 locally. I appreciate any guidance 😅

@burakyilmaz321 The python test failures on master branch are fixed now. Could you please rebase this PR? Thank you!


Delete tasks

Branch for the delete-task feature.
Implements basic logic and test cases mirroring the existing DeleteCommand feature. Also includes refactoring to TaskList class
to mirror UniquePersonList to hopefully make future UI implementation more straightforward. Finally, includes some changes to test classes; ModelStub has been refactored out for reuse across existing and newer testcases.

Codecov Report

Merging #23 (97a9dee) into master (ac30030) will decrease coverage by 0.54%.
The diff coverage is 48.78%.

@@             Coverage Diff              @@
##             master      #23      +/-   ##
============================================
- Coverage     71.85%   71.30%   -0.55%
- Complexity      428      434       +6
============================================
  Files            76       79       +3
  Lines          1318     1352      +34
  Branches        135      139       +4
============================================
+ Hits            947      964      +17
- Misses          327      342      +15
- Partials         44       46       +2

Impacted Files
Coverage Δ

...main/java/seedu/address/commons/core/Messages.java
0.00% <ø> (ø)

.../seedu/address/logic/parser/AddressBookParser.java
84.21% <0.00%> (-4.68%)
:arrow_down:

src/main/java/seedu/address/model/Model.java
100.00% <ø> (ø)

...rc/main/java/seedu/address/model/ModelManager.java
90.56% <0.00%> (-5.44%)
:arrow_down:

...s/model/task/exceptions/TaskNotFoundException.java
0.00% <0.00%> (ø)

...c/main/java/seedu/address/model/task/TaskList.java
25.00% <25.00%> (-35.00%)
:arrow_down:

...eedu/address/logic/commands/DeleteTaskCommand.java
83.33% <83.33%> (ø)

.../address/logic/parser/DeleteTaskCommandParser.java
100.00% <100.00%> (ø)

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac30030...97a9dee. Read the comment docs.


build(docker): dockerize all applications

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@semantic-release dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Symfony 51 rector rule incorrectly rewrites Responses

Hi Tomas,
I'm working on upgrading Symfony 4.4 application to 5.3 and I'm using your amazing tool to help me with that process. However, I encountered an incorrect change of code for the static Response::create() method to new Response() in one of the rules.
Here is original code:
class TestController extends AbstractController
{
	public function someAction(): JsonResponse
	{
		return JsonResponse::create(['data' => '...'], Response::HTTP_OK);
	}
}

Rector configuration (using version ^0.12.5):
return static function (ContainerConfigurator $containerConfigurator): void {
	// get parameters
	$parameters = $containerConfigurator->parameters();
	$parameters->set(Option::PATHS, [
		__DIR__ . '/src',
	]);

	$parameters->set(Option::BOOTSTRAP_FILES, [
		__DIR__ . '/vendor/autoload.php'
	]);

	$containerConfigurator->import(SymfonyLevelSetList::UP_TO_SYMFONY_51);
};

Here is the result after running rector:
1) src/Controller/TestController.php:10

    ---------- begin diff ----------
@@ @@

        public function someAction(): JsonResponse
        {
-               return JsonResponse::create(['data' => '...'], Response::HTTP_OK);
+               return new \Symfony\Component\HttpFoundation\JsonResponse();
        }
 }
    ----------- end diff -----------

Applied rules:
 * StaticCallToNewRector (https://github.com/symfony/symfony/pull/35308)

I think that the rule should preserve the arguments of the create() method when refactoring to the new form to avoid breaking app logic.
A minimum working repository is here: https://github.com/fvozar/rector-symfony-response-rector-bug

Hi, thank you for your report and demo link!
Could you send a failing test case in a pull-request, so we have it covered in Rector?
You can click "Create a Test" button at demo page - https://getrector.org/demo

Thanks for the quick response!
Here is the link https://getrector.org/demo/1ec4df24-0291-65ee-8763-0f2f5d9422c1, but there is an error saying
Rector could not run due to error: Undefined constant Rector\Symfony\Set\SymfonySetList::SYMFONY_51

That's probably because there is old version of Rector.
Could you create test fixture manually and send PR to responsible rule in the meantime?

Pull request is ready. Is this what should have I done? Sorry, it's my first contribution here

Yes, that's great, thanks :+1:


Clarification:  public $n_btc_mined;

Hi, can someone please clarify to me what this actually is? I took it that that is the total amount of bitcoins ever mined to date ( 24 hour delayed )
However upon looking at the value of $n_btc_mined -  1,900.00000000
That cannot be all the bitcoins ever mined. So, can someone just give me a recap what $n_btc_mined represents and then, can we update the documentation to add some clarity.
Much love from South Africa

Hey @ErikThiart
The value represents the total btc mined in the last 24 hours.
Much love from the UK ;)


[BUG] Rectnagle WM not detected on macOS

General description of bug:

What happened: Window manager identified as "Quartz Compositor"
What should happen: Window manager identified as "Rectangle"
Fastfetch version used: 2.15.0
Did it work in an older version: No, checked in 2.14.0 (didn't check older)
Where did you get the binary: Homebrew
Does this issue still occur in the latest dev build? Yes

Screenshot

It works correctly in neofetch. This is the script neofetch uses to detect Rectangle and its output
% ps_line="$(ps -e | grep -o \
                    -e "[S]pectacle" \
                    -e "[A]methyst" \
                    -e "[k]wm" \
                    -e "[c]hun[k]wm" \
                    -e "[y]abai" \
                    -e "[R]ectangle")"
% echo $ps_line
Rectangle
Rectangle

Happy to run test scripts but I don't know C well enough to debug myself.

Duplicate #984


Prevent circular dependencies

Make sure that we are covered for the cases of circular dependencies. Need to make sure to not recursively fetch transitive dependencies if they have already been added to the the descriptor dependencies.

Not sure if it was an issue before, but with https://github.com/coralogix/protofetch/pull/108 circular dependencies should not be a problem.


[QUESTION] Does Learning Pathways support more than once instance in the tenant?

WEB PART NOT LOADING: If you are getting the error: "Microsoft 365 learning pathways has a configuration issue. Ask your administrator for assistance". Please review the Diagnosing Pre-Check guidance before submitting your bug.

Submit your question
What is the context of your question

[X] Installation
[ ] Administration
[ ] Custom Content
[X] M365 learning pathways web part

What is your question
Does Learning Pathways support more than once instance in the tenant? e.g. multiple learning pathways site. I have a large tenant with a requirement to have more than one site.
I see there are tenant properties which points to one. I have been following the installation script: https://github.com/pnp/custom-learning-office-365/tree/master/webpart - the admin page does not load with the error in the F12 console "This site is not the Microsoft 365 learning pathways site as defined by the tenant property MicrosoftCustomLearningSite".
Is there any workaround or does the web parts operation depend on these properties?

No, you can only have one instance per tenant. You can however put the web part on any site collection in the tenant you just have to manage the learning content from one central site. If you've tried installing multiple instances you now have things a bit scrambled as you've figured out.  If this is a test situation then you can just work in the last site that was created and delete the others. If this is a production scenario and you need to keep the original then you'll have to delete the others and run PowerShell to fix the tenant app property that points to the learning pathways site that is the master. UpdateM365lpSiteUrl.ps1

Ok thanks, it’s only test environment thanks for the pointers.
Is the solution going open source or support for this coming? Reason is, we have a requirement for this but the tenant is shared with 11 orgs and various different uses and implementation.
If not, no worries, I’ll set client expectations.
Get Outlook for iOShttps://aka.ms/o0ukef

From: Julie Turner<EMAIL_ADDRESS>Sent: Friday, June 12, 2020 5:08:30 PM
To: pnp/custom-learning-office-365<EMAIL_ADDRESS>Cc: Paul Bullock<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [pnp/custom-learning-office-365] [QUESTION] Does Learning Pathways support more than once instance in the tenant? (#276)
No, you can only have one instance per tenant. You can however put the web part on any site collection in the tenant you just have to manage the learning content from one central site. If you've tried installing multiple instances you now have things a bit scrambled as you've figured out. If this is a test situation then you can just work in the last site that was created and delete the others. If this is a production scenario and you need to keep the original then you'll have to delete the others and run PowerShell to fix the tenant app property that points to the learning pathways site that is the master. UpdateM365lpSiteUrl.ps1https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpnp%2Fcustom-learning-office-365%2Fblob%2Fmaster%2Fwebpart%2FUpdateM365lpSiteUrl.ps1&data=02|01|paul.bullock%40capacreative.co.uk|b1f1c5862f654bca480808d80eeada38|b65b38dfdc4640ca92b9547172742753|0|0|637275749138802696&sdata=UE5vuynoCJDAbuOE79K2in3tzKPBQblDgnFzL01%2FT7Y%3D&reserved=0
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpnp%2Fcustom-learning-office-365%2Fissues%2F276%23issuecomment-643354922&data=02|01|paul.bullock%40capacreative.co.uk|b1f1c5862f654bca480808d80eeada38|b65b38dfdc4640ca92b9547172742753|0|0|637275749138802696&sdata=1eiiscSF1QjTSMRQoEetXo3Iv6fl7WZNBAeadRM3e7I%3D&reserved=0, or unsubscribehttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACC7Z4OHZ3ZLHGVL2ORDBXTRWJHH5ANCNFSM4N4N5MIA&data=02|01|paul.bullock%40capacreative.co.uk|b1f1c5862f654bca480808d80eeada38|b65b38dfdc4640ca92b9547172742753|0|0|637275749138812689&sdata=4gX3EdN8b965yh42u%2F52KrRiLKFeNCpvbWYESLZ4jZc%3D&reserved=0.

It will not ever support multiple deployments.
With regard to open source, I cannot really answer that question as that is not a decision I'm making.  But... since I did all the coding I can tell you that even if you had the source it would be a pretty heavy lift... the easiest way might be to hard code certain values and then do site collection deployments.
One workaround I can think of, create custom assets for each of the orgs in separate site collections that are secured to people in those orgs.  Then create custom subcategories to address that content.  Then the web part is pinned to that subcategory.  Even though the other subcategories would be visible no one could access the content inside them.
Another option is to build custom content packs for each of the orgs, although that would mean maintaining the content manifests with no UI.

Ah, I just realized what I said re: open source, I am super sorry! hope I didn't offend, that didn't come across respectful towards you or your work.
Thank you for your suggestions and your advice on this, I do appreciate this. I will have a look and see if I can get this working or if one instance would be fine.

Not even a little offended so don't worry about it, I was more meaning even with the source it's a pretty heavy lift to change it to work in a tenant app catalog deploy, it's just not architected for that. Let me know where you get and if you need to ask more questions feel free to submit them. I'll close the issue. Thanks.


Routing Error does not indicate the string which has an issue

Issue: Currently having the problem of urls must start with a leading slash found in the rules.py. Cannot figure out which url is the issue.
Replicate: Have an incorrect url
Expected: Indicate what the incorrect url is.

Please do not open issues for such simple improvements. A PR is more than enough.

my bad, was just following recommendations listed when opening a pr

that's meant for bigger developments so people don't waste time for something we're never going to merge


feat: async init indexdb

I have encountered a performance issue in my project where some users experience a significant delay during the initialization of IndexDB, causing the rendering process to be blocked. To address this problem, I have implemented a solution to optimize the performance.
My approach involves introducing a variable to control the operation of IndexDB. When the createCacheProvider function is called, it will return a map object, and the operation of IndexDB will be locked. This means that any subsequent operations on IndexDB will be prevented until the initialization process is completed, and the lock is released.
By implementing this solution, I aim to improve the user experience by ensuring that the rendering process is not blocked by lengthy IndexDB initialization.

Few questions:

Do you have information on how is performance (database initialization and population) related to database size?
What happens to cache writes that happen during database initialization?
Should there be added a function callback parameter onInit?

Few questions:

Do you have information on how is performance (database initialization and population) related to database size?
What happens to cache writes that happen during database initialization?
Should there be added a function callback parameter onInit?

In my project, I have added some logging code as shown below. Occasionally, some users experience up to a 10-second delay during indexDB initialization, and I'm not sure why.
const cacheProvider = useCacheProvider({   dbName: DB_NAME,   storeName: STORE_NAME,   storageHandler: gcStorageHandler,   version: DB_VERSION, }); if (!cacheProvider) {   initDBTime = new Date().getTime();   return null; } if (initDBTime) {   const cost = new Date().getTime() - initDBTime;   slardar.sendLog?.({   extra: {       cost,     },   });   initDBTime = undefined; }

During database initialization, cache data is still written to the map but not stored in the database.

Yes, that's a good idea, and I have added it.

I think this is not the proper solution for this problem.

this doesn't address the problem of slow initialization, just hides it;
cached data won't be accessible when app starts and this makes this package useless
this adds a breaking change
during initialization new data won't be stored in persistent cache

I'm using this package in apps to cache only few requests and database initialization and hydration takes less than a second.
I think you might be caching hundreds of requests and this is why it takes so much time to initialize.
Please take a look at implementing simple garbage collector: https://github.com/piotr-cz/swr-idb-cache?tab=readme-ov-file#implement-garbage-collector

I did simple performance check with 20× CPU slowdown in DevTools:

Empty database: useCacheProvider takes ~700ms
Database with large 9 GraphQL entries: useCacheProvider takes ~1000ms

I still think that garbage collector is the way to address this issue


Issue when running train_sft.sh

I ran into a problem when running train_sft.sh after finishing all setups.
The terminal output is as follow:
[W socket.cpp:601] [c10d] The IPv6 network addresses of (cernet2.net, 52533) cannot be retrieved (gai error: -5 - No address associated with hostname).
[W socket.cpp:601] [c10d] The IPv6 network addresses of (cernet2.net, 52533) cannot be retrieved (gai error: -5 - No address associated with hostname).
[W socket.cpp:601] [c10d] The IPv6 network addresses of (cernet2.net, 52533) cannot be retrieved (gai error: -5 - No address associated with hostname).
[W socket.cpp:601] [c10d] The IPv6 network addresses of (cernet2.net, 52533) cannot be retrieved (gai error: -5 - No address associated with hostname).
[W socket.cpp:601] [c10d] The IPv6 network addresses of (cernet2.net, 52533) cannot be retrieved (gai error: -5 - No address associated with hostname).
[E socket.cpp:860] [c10d] The client socket has timed out after 1800s while trying to connect to (cernet2.net, 52533).
Traceback (most recent call last):
  File "/home/jc/workspace/FineGrainedRLHF/./sft/run_sft.py", line 480, in <module>
    main()
  File "/home/jc/workspace/FineGrainedRLHF/./sft/run_sft.py", line 190, in main
    model_args, data_args, training_args = parser.parse_args_into_dataclasses()
  File "/home/jc/app/anaconda3/envs/rlhf/lib/python3.9/site-packages/transformers/hf_argparser.py", line 226, in parse_args_into_dataclasses
    obj = dtype(**inputs)
  File "<string>", line 108, in __init__
  File "/home/jc/app/anaconda3/envs/rlhf/lib/python3.9/site-packages/transformers/training_args.py", line 1115, in __post_init__
    and (self.device.type != "cuda")
  File "/home/jc/app/anaconda3/envs/rlhf/lib/python3.9/site-packages/transformers/utils/import_utils.py", line 987, in wrapper
    return func(*args, **kwargs)
  File "/home/jc/app/anaconda3/envs/rlhf/lib/python3.9/site-packages/transformers/training_args.py", line 1475, in device
    return self._setup_devices
  File "/home/jc/app/anaconda3/envs/rlhf/lib/python3.9/site-packages/transformers/utils/generic.py", line 50, in __get__
    cached = self.fget(obj)
  File "/home/jc/app/anaconda3/envs/rlhf/lib/python3.9/site-packages/transformers/utils/import_utils.py", line 987, in wrapper
    return func(*args, **kwargs)
  File "/home/jc/app/anaconda3/envs/rlhf/lib/python3.9/site-packages/transformers/training_args.py", line 1460, in _setup_devices
    torch.distributed.init_process_group(backend="nccl", timeout=self.ddp_timeout_delta)
  File "/home/jc/app/anaconda3/envs/rlhf/lib/python3.9/site-packages/torch/distributed/distributed_c10d.py", line 754, in init_process_group
    store, rank, world_size = next(rendezvous_iterator)
  File "/home/jc/app/anaconda3/envs/rlhf/lib/python3.9/site-packages/torch/distributed/rendezvous.py", line 246, in _env_rendezvous_handler
    store = _create_c10d_store(master_addr, master_port, rank, world_size, timeout)
  File "/home/jc/app/anaconda3/envs/rlhf/lib/python3.9/site-packages/torch/distributed/rendezvous.py", line 177, in _create_c10d_store
    return TCPStore(
TimeoutError: The client socket has timed out after 1800s while trying to connect to (cernet2.net, 52533).
ERROR:torch.distributed.elastic.multiprocessing.api:failed (exitcode: 1) local_rank: 0 (pid: 3785353) of binary: /home/jc/app/anaconda3/envs/rlhf/bin/python
Traceback (most recent call last):
  File "/home/jc/app/anaconda3/envs/rlhf/bin/torchrun", line 8, in <module>
    sys.exit(main())
  File "/home/jc/app/anaconda3/envs/rlhf/lib/python3.9/site-packages/torch/distributed/elastic/multiprocessing/errors/__init__.py", line 346, in wrapper
    return f(*args, **kwargs)
  File "/home/jc/app/anaconda3/envs/rlhf/lib/python3.9/site-packages/torch/distributed/run.py", line 762, in main
    run(args)
  File "/home/jc/app/anaconda3/envs/rlhf/lib/python3.9/site-packages/torch/distributed/run.py", line 753, in run
    elastic_launch(
  File "/home/jc/app/anaconda3/envs/rlhf/lib/python3.9/site-packages/torch/distributed/launcher/api.py", line 132, in __call__
    return launch_agent(self._config, self._entrypoint, list(args))
  File "/home/jc/app/anaconda3/envs/rlhf/lib/python3.9/site-packages/torch/distributed/launcher/api.py", line 246, in launch_agent
    raise ChildFailedError(
torch.distributed.elastic.multiprocessing.errors.ChildFailedError:
============================================================
./sft/run_sft.py FAILED
------------------------------------------------------------
Failures:
  <NO_OTHER_FAILURES>
------------------------------------------------------------
Root Cause (first observed failure):
[0]:
  time      : 2024-01-18_14:17:20
  host      : cernet2.net
  rank      : 0 (local_rank: 0)
  exitcode  : 1 (pid: 3785353)
  error_file: <N/A>
  traceback : To enable traceback see: https://pytorch.org/docs/stable/elastic/errors.html
============================================================

I find the solution:
add the following item in /etc/hosts:
<IP_ADDRESS> cernet2.net


Fix Collection Methods Called on DataManagers

Description of the PR
This PR fixes the common breaking change caused by Discord.js' DataManagers: calling Collection methods on DataManagers.
Semver Classification

[ ] This PR only includes documentation or non-code changes.
[x] This PR fixes a bug and does not change the (intended) framework interface.
[ ] This PR adds methods or properties to the framework interface.
[ ] This PR removes or renames methods or properties in the framework interface.

https://github.com/dirigeants/klasa/pull/927#issuecomment-588349644


METRON-725: Javadoc is broken by the use of apiNote

As noted in the ticket, there are 3 options for fixing this

Just delete the offending inherited javadoc
Explicitly inherit the Javadoc
Enable the @apiNote tag

This PR just does the first one, but it's easy to change if anybody has a strong preference. I lean pretty heavily towards 1 or 2 (because 3 is apparently more intended towards the Java language, rather than outside usage)
To test, just run mvn javadoc:javadoc.
This also suggests that we should be running this as part of our normal build process (and I'll create a ticket if people agree).

Yeah, I'm ok with this fix.  I shouldn't have just green-lit the inherited javadoc suggested by the IDE.
Also, I think we probably should do the following during builds:

generate javadoc
generate the site-book

My only concern is that we already have hefty build times, but maybe that's not a good enough reason to avoid these kinds of errors.
Anyway, +1 by inspection.

I agree on the "should", and share the same concerns. It would be nice to get everything generated and run regularly, but improving our build is a prereq for that.
There's probably a discussion to be had on that, but I suspect it's not worth having until after the build times are a little more under control.
Thanks for reviewing this.


CANINE models cannot be benchmarked on QA tasks

The models google/canine-s and google/canine-c fails when trying to benchmark them on QA tasks.

This is due to them now having a fast tokenizer - closing.


Redundant Symbol "[]" in NOTATION

Description
There seems to be redundant "[]" in the Notation section. They locates before the main text and after the notation section title.
(Optional:) Please add any files, screenshots, or other information here.
Source paper:  https://doi.org/10.48550/arXiv.2401.15129

(Required) What is this issue most closely related to? Select one.
Formula
Internal issue ID
9304881e-e361-4543-bfd8-f2248adaa68e
Paper URL
https://arxiv.org/html/2401.15129v1
Browser
Chrome/<IP_ADDRESS>
Device Type
Desktop

Thanks for the quick action!


Segmentation fault on glfwTerminate

OS: Alpine Linux 3.21.0_alpha20240923 x86_64
Kernel: Linux 6.6.58-1-lts
WM: River (Wayland)
GPU: Intel HD Graphics 510

(sorry for my English, I used google translate in places)
Available glfw3-dev packages: glfw-dev, glfw-wayland-dev.
glfwTerminate() causes segfault in both packages.
And glfw-wayland-dev causes segfault on desktop (river tag) switching.
Note: Clang/GCC - same result
Note2: if I remove the glfwTerminate call, the segfault does not appear
Code:
#include <GLFW/glfw3.h>

int main() {
    if (!glfwInit()) return -1;

    GLFWwindow *w = glfwCreateWindow(640, 480, "test", 0, 0);
    if (!w) {
        glfwTerminate();
        return -1;
    }

    glfwMakeContextCurrent(w);

    while (!glfwWindowShouldClose(w)) {
        glfwPollEvents();
        glfwSwapBuffers(w);
    }

    glfwTerminate();
    return 0;
}

Error (gdb run):
Thread 1 "test" received signal SIGSEGV, Segmentation fault.
get_meta (p=p@entry=0x7ffff7cff420 "e") at src/malloc/mallocng/meta.h:141
warning: 141	src/malloc/mallocng/meta.h: No such file or directory

Backtrace:
#0  get_meta (p=p@entry=0x7ffff7cff420 "e") at src/malloc/mallocng/meta.h:141
#1  0x00007ffff7f9eb9f in __libc_free (p=0x7ffff7cff420) at src/malloc/mallocng/free.c:105
#2  0x00007ffff7f9e658 in free (p=<optimized out>) at src/malloc/free.c:5
#3  0x00007ffff7fb6036 in regfree (preg=<optimized out>) at src/regex/regcomp.c:2926
#4  0x00007ffff7f01d99 in ?? () from /usr/lib/libglfw.so.3
#5  0x00007ffff7efbc39 in ?? () from /usr/lib/libglfw.so.3
#6  0x000055555555527e in main ()

Full backtrace:
#0  get_meta (p=p@entry=0x7ffff7cff420 "e") at src/malloc/mallocng/meta.h:141
        offset = 0
        index = 31
        base = 0x7ffff7cff410
        meta = 0x0
        area = <optimized out>
#1  0x00007ffff7f9eb9f in __libc_free (p=0x7ffff7cff420) at src/malloc/mallocng/free.c:105
        g = <optimized out>
        idx = <optimized out>
        stride = <optimized out>
        start = <optimized out>
        end = <optimized out>
        self = <optimized out>
        all = <optimized out>
        mi = <optimized out>
        base = <optimized out>
        len = <optimized out>
        e = <optimized out>
#2  0x00007ffff7f9e658 in free (p=<optimized out>) at src/malloc/free.c:5
No locals.
#3  0x00007ffff7fb6036 in regfree (preg=<optimized out>) at src/regex/regcomp.c:2926
        tnfa = 0x7ffff7d01210
        i = 14
        trans = <optimized out>
#4  0x00007ffff7f01d99 in ?? () from /usr/lib/libglfw.so.3
No symbol table info available.
#5  0x00007ffff7efbc39 in ?? () from /usr/lib/libglfw.so.3
No symbol table info available.
#6  0x000055555555527e in main ()
No symbol table info available.

The regfree call in the backtrace looks like its steming from _glfwTerminateJoysticksLinux.
This may be related to

#2464

The regfree call in the backtrace looks like its steming from _glfwTerminateJoysticksLinux. This may be related to
* [Double regfree bug #2464](https://github.com/glfw/glfw/issues/2464)

Can you check if the crash still happens with glfw 3.3.10 or newer? It seems like the Alpine Linux package still uses 3.3.9 where the fix from above is not implemented.

Thanks, I have compiled 3.4 and there is no crash
But will the bug be fixed for earlier versions?


Golang based editor

Anyone know of a golang one ?
Outputting svg with golang is very easy as well as pdf.
It's just a matter of finding a parser to parse the mermaid markdown.
Ultimately I want to use this to allow developer to describe orchestration workflows and then codegen the Js code that executes the workflow.
The Js runs inside a JavaScript VM that is build with golang.
I know this is a Js based project but I figured it's worth asking.

Check this project: https://github.com/mermaidjs/mermaid.cli


Remove a space in `Guidance on plans to support the writing project'

Hi, Blaine. I really enjoyed your recent EmacsConf talk. I plan to incorporate several of your ideas in the mess of multiple projects that I find myself in. What great ideas and advice.
I noticed some superfluous leading space characters in the :GUIDANCE: for Guidance on plans to support the writing project. (It's a curse; I can't help it.) This is a pull request to remove them.
Feel free to just directly apply the changes your repo, if you like.

Hi Gary,
Thank you very much for the feedback on my talk and the pull request. I will accept the request. I appreciate the contribution!
Blaine


Magnetic windows

Summary of the new feature/enhancement
Tangently related to FancyZones, I would like to see magnetic windows, that snap to one another and the border of the screen.
Options can include strength of the magnetism, if it should apply to windows and/or screens, and if it should be enabled on the edge between two screens.

Hi @benwa
please add your comment in https://github.com/microsoft/PowerToys/issues/181
that is the tracker for a similar issue.
I'm closing this one.
Thanks.


Added documentation for orbit image mixin.

Small addition to orbit rotator documentation. Added the orbit-image mixin to the docs as it wasn't included but fairly important if you're using images in your rotator.

Thanks for this!


api: Add getMessageCompat helper, for servers with and without FL 120

We can use this to get raw Markdown content for quote-and-reply
(#116) and for the "Share" option on a message. For those, we only
care about the raw Markdown content and so could just as well have
used the raw_content field on the get-single-message response, for
servers pre-120. But...
We can also use this for #73, "Handle Zulip-internal links by
navigation", to follow /near/ links through topic/stream moves
(see implementation in zulip-mobile). For that, we'll need more than
just the message's raw Markdown.
Fixes: #140

Thanks for the review! Revision pushed.

Thanks! Looks good; merging.


Linting has started failing

First occurrence: https://github.com/anitagraser/movingpandas/actions/runs/3493470868

Hey, Anita! This is because flake8 has moved to GitHub. I would be happy to submit a PR for the fix.


Implement missing functions 10-minute tutorial with Koalas

This is the list of missing functions for 10-minute tutorial with Koalas (#196)

[ ] DataFrame.T
[ ] DataFrame.at
[ ] DataFrame.iat
[ ] DataFrame.reindex
[ ] DataFrame.shift
[ ] DataFrame.sub
[ ] DataFrame.apply
[ ] DataFrame.append
[ ] DataFrame.pivot_table
[ ] DataFrame.to_hdf

Some functions could be implemented for both DataFrame and Series.
For contributors, please mention that you're working on some functions here and go ahead.

@HyukjinKwon any thoughts?

Let's focus on: pivot_table, reindex, apply, append, at, T, to_hdf (in this order)
The other functions have big performance impact and will require more careful integration with spark, by using window functions under the hood for example.
@garawalid, if you are looking at implementing some of them, I suggest that we go in this order. What are your thoughts?

I can definitely start with reindex,  append and at as those three all seem pretty straight forward.
The others seem tricky to me for different reasons:

pivot_table and T might require special care with their implementation as they potentially move around huge amounts of data between workers.
apply should probably take UDFs since pandas/NumPy methods need to move the data from the Spark process to the Python process and back. Expecting the user to use PySpark UDFs however, would (again) break the separation between the (Py)Spark and pandas APIs.
to_hdf should be easy to implement but requires a decision if the write to disk should happen from Spark or from Python.

Does anybody still use hdf these days? Maybe I'm not familiar enough with the pandas use cases. I feel maybe it's ok to skip hdf given people rarely use that in "big data".

@rxin, FWIW I think you are right that to_hdf is a very rarely used function. I'm sure there are edge cases, but I've never seen it used.

I've seen people (including myself) using HDF5 files to store Keras models but I've also never seen anyone using it with pandas or Spark. So probably it makes most sense to leave it out for now and wait until someone requests this feature (if ever).

@thunterdb pivot_table sounds a little bit tricky, I'll start with a simple version and we will improve it with different PR.
Thanks @floscha, @rxin, @athena15 , @thunterdb . I'll update the list as you suggested.

We will ignore iat because it needs the position of the row.

I skipped DataFrame.shift because we can't union DataFrame of nulls with another one.


Append-method as counterpart to the existing prepend-method.

I was wondering why there isn't an append-method while the prepend-method is supplied. I created the append-method by mostly copying and pasting the prepend method, including unit tests.

@Timmitry It's already there and called Concat. I wish you had checked in first by opening an issue and proposing the idea. It would saved you duplicating the work and the trouble of submitting a PR.

Ah, right, there is an overload for Concat, I was only looking for the method Append...
You're right, I should first open an issue in the future. However, since I'm new to Git and Github, this was a good exercise, nonetheless.

BTW, Append is available in LINQ to Objects when targeting .NET Core so I'm guessing it's coming to the full .NET Framework soon.


New version: HTTPToolKit.HTTPToolKit version 1.14.8

Pull request has been created with WinGet Automation :rocket:
Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:


Secret encoding option and otplib.js compatibility

Hello,
I'm trying to set up a app that receives a secret from a Node.js server that is using otplib. On their docs, the secret is a "base32 encoded hex secret key".
My problem is that when I create a HOTP
OTP.generateHOTPCode(_secret, _counter, algorithm: Algorithm.SHA256)
it generates a key, but it's different from the one on the server so it fails to verify it.
So I thought that maybe the secret is decoded differently on the 2 packages. How should I encode the secret on the server-side so that both packages produce the same output?

I am going to need some more info to get a clearer picture. Anything from the Secret, Algorithm, Digest, the counter being off, or how we implement Base32 can cause this.
For the server:
What algorithm are you using (the default for HOTP in their docs is SHA1)?
Are you using a custom digest?
Are you using the default encoding of ascii per their docs?
Can you potentially get me the output of the secret in byte form (this is to check if our base32 implementations are different somehow)?
For dart-otp:
Is secret the same string as in the node.js server?
You can import the base32 library and use base32.decode() to get the bytes of the secret. Are they the same as the servers?
Is the time on the server out of sync with the client?
What value are you using for _counter ?

Ok, sure.
First when registering for 2FA, I use their method of token generation with authenticator.generateSecret(), and save that in a secure storage on app. I use algorithm: SHA256 and encoding: hex. I've also tried with ascii, utf8 and base64 but no luck.
No custom digest.
When checking the otp I apply the same options. I'm not sure, if I can send you a byte form of the secret, but the there is a decode method that basically exposes the base32 module. If i input a base32 key likeOBRWE5CEFNFWQQJRMZRGM4LZMZIGKKZU I get a<PHONE_NUMBER>2b4b68413166626671796650652b34 hex string.
I've checked if secret is the same. Also checked the time, it's the same, but not sure about the timestaps (also tried TOTP, but that doesn't work either). Counter is a int type var with value of 1 on both server and app.
Anyway, I'll try to import the base32 lib in both apps and you suggested and I'll come back with an update.

Ok, thank you for the info, since we can rule out the base32 decode, I will focus on the otp. The last edit helps. I will attempt to replicate this locally. Just give me a bit of time to setup a node project to test with.

Ok, I think I found the problem, its related to converting the counter into a list of bytes for the HMAC library. Something is messed up there and causing problems. Currently added tests from the RFC data sets so that i can run tests and figure out how to get accurate results. Thanks for bringing this to my attention. I will try to get it working asap as this is a major bug.

Thanks for maintaining this awesome lib!

So it wasn't quite what I thought it was at first, but it definitely was in that area. Turns out I wasn't doing padding right for TOTP, and I am not supposed to bad for HOTP. Along with that, I found that otplib does not base32 decode for you if you use hotp directly. So you need to base32 decode yourself. Otherwise it takes the string, takes the ascii decimals for each letter, and uses that as the secret. I only support base32 as input, so you need to do a base32 decode of the secret before passing it into the otplib hotp stuff. I will have an example script I used for testing to show you what I mean.
I will be releasing version 2.1.0 shortly. It has all the fixes, all the tests, additional features, and some other stuff I have found.
Since the HOTP RFC does not have instructions or support SHA256 and SHA512, I have defaulted back to SHA1 for HOTP, as I have found out that libraries don't handle SHA256 and SHA512 the same way, since its unsupported. SHA256/512 were added in the TOTP RFC, and have instructions on how to do padding and truncating of the secret to make it fit the 20, 32, and 64 byte requirements of the 3 supported hashes (SHA1, SHA256, and SHA512). In the TOTP RFC, SHA256 is the default, but in HOTP, SHA1 is.
I found other libraries (primarily otblib and speakeasy) don't do the padding for HOTP if you use the non-default hashes, so you get weird results. I made mine match otplib and speakeasy, but also added an option if you want to use TOTP style secret padding with HOTP, but remember compatibility might be a problem between languages and different libraries. My recommendation is to switch to TOTP, or use SHA1 for HOTP (though my codes for HOTP do match otplib and speakeasy when using sha256 and sha512 now)
As for the node.js script I used for testing, that is here:
const otplib = require('otplib')
const speakeasy = require('speakeasy')
const base32 = require('thirty-two')

const hotp = otplib.hotp

const secret = 'OBRWE5CEFNFWQQJRMZRGM4LZMZIGKKZU';
const counter = 1

hotp.options = { algorithm: 'sha256', encoding: 'ascii'}
// Alternative:
// const secret = hotp.generateSecret();
// Note: .generateSecret() is only available for hotp and not totp/hotp

var tokense = speakeasy.hotp({
  secret: secret,
  encoding: 'base32',
  counter: counter,
  algorithm: 'sha256'
});

const token = hotp.generate(base32.decode(secret), counter);
console.log(token)
console.log(tokense)

Hopefully that shows you what I meant about base32. otplib only does base32 decode if you use their authenticator methods, which are TOTP.
Anyways. Thank you for all this, you still found some bugs, and I will be releasing 2.1.0 once I update documentation, readmes, and analyzer/formatting stuff.

2.1.0 released, I am closing this for now. If the issue isn't resolved, please reopen.


Added a page with an iframe to creating a new Labs project (newProject.md)

Signed-off-by: ChetanDehane<EMAIL_ADDRESS>

Hey @arsulegai i made changes file as per your suggestion please review it. Thank You!


Feature request: Load Game

There is no option to restart the game in the original

Yes, I know, as my rewrite progresses I will enable this option for sure.
There is still a lot of work until I will be able to add this feature! :)

Of course this is just a reminder


Upstream changes from internal for March 23

Can one of the admins verify this patch?

@tensorflow-jenkins: test this please.

@tensorflow-jenkins test this please

@tensorflow-jenkins test this please


Rename csproj to NLog.Targets.Redis

Change namespace to NLog.Redis?
Currently NLog.Targets

If it followed the good standard then it should be:
Target-alias: Redis
Target-Assembly: NLog.Targets.Redis
Then my idea will continue to fly: https://github.com/NLog/NLog/issues/2944

so it's currently good now?

Well right now the assembly is called NLog.Redis.dll (instead of NLog.Targets.Redis), but both names works.

It's kind of complicated due to #10 @snakefoot. It would be nice if the Nuget package matched the namespaces and NLog target name, but this might get complicated.

Btw. looks the naming guide for a NLog-extension-package is NLog.Targets.Whatever. So the csproj file should probably be renamed to NLog.Targets.Whatever.csproj.

renamed to NLog.Targets.Whatever.csproj.

Good idea :)

@snakefoot can You link to that naming guide You mentioned?
@304NotModified so are You going to rename repos, projects and nuget packages according to that naming convention?
There is an option to reserve prefix at NuGet (https://github.com/NuGet/Home/wiki/NuGet-Package-Identity-Verification) so maybe all official targets could be published as NLog.Targets.*?

Don't have link. The "guide" comes from seeing what the majority has done.
Sent from my Sony Xperia
---- Tomasz wrote ----
@snakefoothttps://github.com/snakefoot can You link to that naming guide You mentioned?
@304NotModifiedhttps://github.com/304NotModified so are You going to rename repos, projects and nuget packages according to that naming convention?
There is an option to reserve prefix at NuGet (https://github.com/NuGet/Home/wiki/NuGet-Package-Identity-Verification) so maybe all official targets could be published as NLog.Targets.*?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/NLog/NLog.Redis/issues/8#issuecomment-441183967, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AK-fnMpZuzmpCaDT4ghwFhsnrsIhBr2-ks5ux7hWgaJpZM4XUQUF.


Improved dev environment

[fix/improve-dev-environment 9923f65] Improved dev environment

@fabiocicerchia please remove the nginx cache layer for dev environment! Thanks!


chore!: change package name

I'll hold onto this PR for a while until I make sure both Yamato and UPM wouldn't break.

@MFatihMAR have we tested what this PR would do to a project using the old package and would need to update to this package ? I suspect that its going to be somewhat of a pain because of the asmdef change and potentially the script links? I assume there will be some document somewhere to help folks make that migration?

@MFatihMAR have we tested what this PR would do to a project using the old package and would need to update to this package ? I suspect that its going to be somewhat of a pain because of the asmdef change and potentially the script links? I assume there will be some document somewhere to help folks make that migration?

yeah, very good point. I haven't tested or wrote a doc about how to migrate yet.
this PR is still a draft. lots of changes went into develop recently already. this PR is the last gate (except docs & md files, including CHANGELOG -should we change names there retrospectively?) before we finalize package renaming. so I'd expect this PR to be updated a few more times with fixes, guides and other issues. BUT, I wanted to keep the ball rolling here as I imagine this PR to be the last one :)
back to migration doc, I could work with SA folks for that. I could also summarize my own "migration experience" as a baseline. package name change would break codebases for sure because devs now required to update dependencies section of their manifest.json and package.json files. there needs to be a place for these things.

I have plans to address namespace/asmdef migration under a separate PR (with MovedFrom attrs & MigrateFromMLAPI.md doc).
I think this PR is ready to go and there is no reason to hold onto it any longer (I constantly merge develop back into this and resolve conflicts / file moves).
Can we get this in?

I notice we still have a Documentation~/MigrateFromMLAPI.md file.  Also there is a Documentation~/Manual.md file which references MLAPI.  @Briancoughlin are these files still desired?


.dot parser library

Hi,
Is there a (PHP) library available that can parse *.dot files and expose the graph objects in PHP?

Hi @mihai-stancu! I'm not aware of any implementations for this, currently. If anybody happens to find or build one, please make sure to let us know in #15 :+1:


Near duplicate PESC Award Level types

There are several members of PESC Award Level Type that are near identical.  For example:
<owl:NamedIndividual rdf:about="http://ceds.ed.gov/terms#NI001668151668">
		<rdf:type rdf:resource="http://ceds.ed.gov/terms#C001668"/>
		<rdf:type rdf:resource="http://www.w3.org/2004/02/skos/core#Concept"/>
		<dc:creator>Common Education Data Standards</dc:creator>
		<rdfs:label>Master\'s Degree</rdfs:label>
		<skos:inScheme rdf:resource="http://ceds.ed.gov/terms#C001668"/>
		<skos:prefLabel>Master\'s Degree</skos:prefLabel>
		<skos:notation>4.2</skos:notation>
		<skos:definition>Master\'s Degree</skos:definition>
		<dc:identifier rdf:datatype="http://www.w3.org/2001/XMLSchema#token">001668151668</dc:identifier>
		<dc:description>Master\'s Degree</dc:description>
	</owl:NamedIndividual>

and
	<owl:NamedIndividual rdf:about="http://ceds.ed.gov/terms#NI001668151678">
		<rdf:type rdf:resource="http://ceds.ed.gov/terms#C001668"/>
		<rdf:type rdf:resource="http://www.w3.org/2004/02/skos/core#Concept"/>
		<dc:creator>Common Education Data Standards</dc:creator>
		<rdfs:label>Master\'s Degree</rdfs:label>
		<skos:inScheme rdf:resource="http://ceds.ed.gov/terms#C001668"/>
		<skos:prefLabel>Master\'s Degree</skos:prefLabel>
		<skos:notation>IPEDS7</skos:notation>
		<skos:definition>Master\'s Degree</skos:definition>
		<dc:identifier rdf:datatype="http://www.w3.org/2001/XMLSchema#token">001668151678</dc:identifier>
		<dc:description>Master\'s Degree</dc:description>
	</owl:NamedIndividual>

I can recognize from the codes used for skos:notation that the former comes from PESC and the latter from IPEDS, but this isn't explicit.
It seems wrong to put IPEDS codes in a values space called after PESC.
If you need both you could have an IPEDS Award Level Type and allow values from either it or or the PESC scheme.
(I won't comment on listing CEDS as the creator of either PESC or IPEDS classification schemes)

This would require a change in the CEDS element directly since the element PESC Award Level Type element contains both of those codes. If PESC lists both sets in their element, then CEDS would replicate that. If they have removed one, then CEDS can  make the change to remove one as well.  And you are correct, we do need to review the "creator" section for elements that are pulled from other standards.

Thank you @AEMDuaneBrown I will check with my friends at PESC on this, but the documentation that I have does not suggest that they use the IPEDs terms. It's possible though that they use them somewhere else.
Either way, I still don't think it is a good idea for CEDS to publish IPEDS levels in a scheme called PESC Award Level Types. It would be better to separate them from the PESC levels and say that the PESC property can take values from both schemes.


Terminal doesn't scroll down on every keypress

At the moment it's only scrolling down when pressing "normal keys", but doesn't with enter, backspace, delete, arrow keys, ctrl+whatever...

Fixed, thanks.


publish power_plus

The data of the plenticore adapter are an important input to control some other devices (e.g. switching of heat pump). In some cases I needed the information which is calculated in the plenticore adapter as "power_plus".
Instead of re-implementing the same calculation in different places (and because it may be useful as well for other users), I propose to publish the power_plus value.
Changes done:

remove redundant calculation of remaining consumption
set to 0 after sunset
publish power_plus

Thank you


Extend options to allow empty arrays and ignored properties

When building responses for REST List responses, an empty array is significant. So extended options to allow them to pass through.
Also added support for a  simple-minded excludedProperties to prevent omitEmpty from traversing/processing specific properties. (Just in case you want to exclude something from processing due to weirdness in requirements.

Any updates on this? I also have a similar use case. Thanks


Invocations are missing ARN and requestId is ERROR

Reported by a user using the 0.1.1 version of the go agent. Invocations are making it through the data pipeline, but not viewable in the dashboard because of this missing data.

Closed by #24


[V6] call to Array.findIndex breaks IE

V6 seems to use findIndex which needs a polyfill in some browsers.
I'd be happy to create a documentation PR if i'm not missing something here.

Here's the es6 polyfill if someone stumbles upon this until this is clarified:
if (!Array.prototype.findIndex) {
  Array.prototype.findIndex = function (predicate) {
    if (this === null) {
      throw new TypeError('Array.prototype.findIndex called on null or undefined');
    }
    if (typeof predicate !== 'function') {
      throw new TypeError('predicate must be a function');
    }
    const list = Object(this);
    const length = list.length >>> 0;
    const thisArg = arguments[1];
    let value;

    for (let i = 0; i < length; i++) {
      value = list[i];
      if (predicate.call(thisArg, value, i, list)) {
        return i;
      }
    }
    return -1;
  };
}

Thanks for pointing that out, @pulse00. I didn't write that line. 😀 I'll write that another way.

Fixed published in v6.0.0-rc.4.


Notifier update

Add notifications after run_all has completed
Slight clean up/refactor

:+1: please merge this


Add "include" to plugin.json

Someone brought this plugin to my attention, so I added it to the plugin database (which will let your plugin to show up on the website)
In there I'm currently working on a build system, which right now only adds the .millennium, backend and other required folders into the build. include is a list of relative paths that tells the builder they are vital and need to be included in the final build. In your case, public, or whatever is needed. You can see in the build some important stuff is missing.
Don't worry about altering your current build system or removing it, this is just millennium specific stuff and wont interfere with anything :)

Oh nice, I was waiting for millennium 1.16.0 to release before adding it to plugdb. But this works too.
I added the include to the plugins.json and fixed webkit not building. Also opened a pr to update the submodule https://github.com/shdwmtr/plugdb/pull/4


reduce now works on objects

Now that simple JS objects are treated as functors, map and filter works over it, reduce should also work over objects.

:-1: for me. this has come up over and over.

Aww okay.

See #1327 for earlier discussion.

See #1327 for earlier discussion.

And #1067.
And #257, #364, #546, #625, #656, #920, and probably others.
Yes, this has come up a few times.
But this reminds me of a PR I started and then didn't follow up on.


Will TinyConstraints have livereload?

Will TinyConstraints have live reload like Stevia?
https://github.com/freshOS/Stevia

Thanks @rlam3, that's a great idea! I'm gonna research the possibilities.

I'm afraid not.


feat: GAE_DEPLOYMENT_ID used for minor version

The GAE_DEPLOYMENT_ID environment variable (with a fallback to
GAE_MINOR_VERSION) will be used as the default value of
minorVersion_.

Looks like tests must be updated?

PTAL


Add missing VEP fields for variant page

The current variant page uses PolyPhen and SIFT fields from VEP.
https://github.com/macarthur-lab/gnomad_browser/blob/b4ff2705fd540037acc31f234f660b26162f5207/templates/variant_details.html#L1-L9
However, these fields are not currently stored in Elasticsearch, which prevents replicating the current variant page (#156).

@gtiao confirmed these annotations are included in the gnomAD release, so we just need to not discard them when exporting to Elasticsearch.


Was the code for calculating Chamfer Distance and normal consistency score provided?

Was the code for calculating Chamfer Distance and normal consistency score provided?
Thanks!

Yes, please check cd_normal_fscore.cu.


Response closure not getting called after validation

Alamofire: 4.4.0
Xcode Version 8.3.2 (8E2002)
iOS target: 10.3
I am using Alamofire to authenticate a user. When the server is given invalid credentials it responds with a 401 and a JSON object that describes the error.
When I use the following code:

SessionManager
    .default
    .request(AccountRouter.authenticate("blah blah", ""))
    .validate({ (request, response, data) -> Request.ValidationResult in
        return Request.ValidationResult.failure(RemoteError.nilData)
    })
    .response(completionHandler: { (response: DefaultDataResponse) in
        result = response
        print(response)
    })

the response closure is never called.
If I remove validate everything works as expected. Is there something I am missing that will make it work or is this a bug of the library.
PS.  I want to use RequestAdapter and RequestRetrier to refresh access tokens and the should(_ manager: SessionManager, retry request: Request, with error: Error, completion: @escaping RequestRetryCompletion) only gets called after validation.

Apparently it was a problem on my part on the RequestRetrier.


Looking for a graphist

I'm looking for a graphist to at least create an icon for engge.

Thanks @elvisish for your proposition, I like the idea of the gradient.

Thanks @elvisish for your proposition, I like the idea of the gradient.

Haha, no problem, the font could definitely do with changing, I was just mocking up an idea based on the Thimbleweed Park colors (i think this might look acceptable as an icon tbh, but probably want it doing better for a full logo)

Haha, no problem, the font could definitely do with changing, I was just mocking up an idea based on the Thimbleweed Park colors (i think this might look acceptable as an icon tbh, but probably want it doing better for a full logo)


error after changing the ip address

Hi, I changed the IP in the apk file, according to the instructions, but now the application is not installed, it gives an error:
adb: failed to install C:\Users\vad1m\Downloads\com.projectbsds.v41150.apk: Failure [INSTALL_PARSE_FAILED_NO_CERTIFICATES: Failed to collect certificates from /data/app/vmdl1166510165.tmp/base.apk: META-INF/APKEASYT.SF indicates /data/app/vmdl1166510165.tmp/base.apk is signed using APK Signature Scheme v2, but no such signature was found. Signature stripped?]
what needs to be done to fix it?

You need to sign the apk

Use apkeasytool


Provider to import default components

Is there an MDXProvider of sorts that we can use to basically define the imports that can be accessed across all MDX files?
I tried the below approach and it didn't work.
components/MDXComponents.js
import EmailSignUp from './EmailSignUp';

const MDXComponents = {
  EmailSignUp,
  // ... other components
};

export default MDXComponents;

In _app.mdx
import { MDXProvider } from '@mdx-js/react';
import MDXComponents from '../components/MDXComponents';

function MyApp({ Component, pageProps }) {
  return (
    <MDXProvider components={MDXComponents}>
      <Component {...pageProps} />
    </MDXProvider>
  );
}

export default MyApp;

My .msx file
# Title

## H2

## H2

## H2

## H2

<EmailSignUp />

## H2

Any help will be appreciated. I don't want to include the component in 100s of files.
@B2o5T

https://nextra.site/docs/docs-theme/theme-configuration#mdx-components

This is exactly what I was looking for... Thank you so much!


Migrations for Direct Award

Summary
Separate PR to run migrations for DIrect Award before introducing any additional logic, to make sure it doesn't break stuff.
Main PR to follow this is https://github.com/alphagov/digitalmarketplace-api/pull/624, which contains some more info

Not going to put this in as a separate PR because the tests rely on SQLAlchemy understanding the models, which aren't available to this migration by itself.


Publish Stage

fix nil values sorting with a given sort key
Add useAmountInput integration tests
Take into account manual entry for Swap's Max/Half
Change swap fee tokens automatically if there's not enough balance to pay fees

QA is offline for testing, and don't want to deploy on Friday, so I propose we deploy Monday.

Stepper is broken

NVM

Wait stepper IS broken


envoy.fault filter listener based fault injection

Signed-off-by: Jyoti Mahapatra<EMAIL_ADDRESS>Description: Add support for listener based faulting.
When the application talks to other clusters through sidecar, we can inject fault on egress path. This helps when the target cluster is a virtual third party host and we cannot do downstream cluster name based fault injection at the target side car.
Risk Level: Low
Testing: Unit Tests
Docs Changes: Docs are included with the api protos
Release Notes:

@mattklein123 WDTY of this change?
I will add docs and tests once we converge on the right approach.

@jyotima what I would do here is add a configuration option to allow all of the runtime keys to be overriden. Right now they are hard coded. The config options can default to the current hard coded keys. Thank you!
/wait

@kathan24 here is the PR

@mattklein123 Do take a look and let me know if this is what you meant.
I will update the docs and add tests in the meantime

@mattklein123 I think this time its actually close to what you had in mind and its simple. Thanks for helping me through this.
Do we need a version_history change for this?

@mattklein123 Thank you for the suggestion for separate tests. Please do take a look again

the build is failing with this error: source/extensions/filters/http/fault/fault_filter.cc:66:66: error: use of undeclared identifier 'delay_percent_runtime'   delay_percent_runtime_ = PROTOBUF_GET_STRING_OR_DEFAULT(fault, delay_percent_runtime,
However it doesnt fail on my box, i am checking the issue right now

Thank you for helping @mattklein123


blog post link fails HSTS with chrome

Alright, thanks for the heads up.  I'll probably just convert it to markdown and put it in the repo.

Fixed by #51.

You probably meant that it's fixed by #50.

Correct.  Thanks.  I edited the comment accordingly.


Support dry-run when upgrading to v19

What use cases do you see for other operations common issues to surfact - in Scaling, Create , Update etc ?

This given issue is due too a flag we require that is later removed. Added more details  @kaarthis


local echo: Introduce client_key on the server.

We are deprecating local_id/local_message_id on the Python server.
Instead of the server knowing about the client's implementation of
local id, with the message id = 9999.01 scheme, we just send the
server a client_key to echo back to us.
Right now this client_key happens to be local_id, but that will
change in future commits.
The goal for client_key in future commits will be to:
* Have it for all messages, not just locally rendered messages
* Not have it overlap with server-side message ids.
The history behind local_id having numbers like 9999.01 is that
they are actually interim message ids and the numerical value is
used for rendering the message list when we do client-side rendering.

Automated message from Dropbox CLA bot
@showell, it looks like you've already signed the Dropbox CLA. Thanks!

We tentatively decided to call this client_message_id instead.  It doesn't effect this PR yet, but we are thinking it would be an opaque string field, and for the web app, we'd probably just increment a serial number for each new message we send to the server.

Closing.  (consolidated into #5779)


Kpt inserts !!int YAML tags for string setters that had integer values

Expected behavior
I'd expect that if a setter is defined with type string then integer tags would not be added to the output YAML.
Actual behavior
Given the a directory containing the following Kptfile:
apiVersion: kpt.dev/v1alpha1
kind: Kptfile
metadata:
  name: my-account
packageMetadata:
  shortDescription: Example
openAPI:
  definitions:
    io.k8s.cli.setters.account-id:
      type: string
      x-k8s-cli:
        setter:
          name: account-id
          value: "123"
          isSet: true

And a single resource file:
apiVersion: example.com/v1alpha1
kind: Account
metadata:
  name: my-account
spec:
  accountID: 123 # {"$kpt-set":"account-id"}

If I run kpt cfg set . account-id abc, then the resource file is modified to:
apiVersion: example.com/v1alpha1
kind: Account
metadata:
  name: my-account
spec:
  accountID: !!int abc # {"$kpt-set":"account-id"}

Information
Kpt version: 0.38.1

@etefera @runewake2 can one of you take a quick look at this?

This is related to the way we handle types currently. That is a valid yaml value btw but it creates confusion. I figured out a way to fix this(change the type of field value using setters) in the next branch and implemented it. I will fix it in the master as well as users are running into this issue.

@phanimarupaka before we backport a fix let's make sure the @ashlineldridge doesn't have a work around first.  If there is a work around in their workflow then I am OK just adding a test to the next branch and making sure that with the next release we don't hit this.

@ashlineldridge can you advise us on the urgency of this fix?

Couple of workarounds here:

What is the intended type of accountID field ? Seems like it should be a string. If so, why is it's value an integer currently(which is incorrect) ?
The quick 1 time fix is to do the sed operation to replace accountID: 123 with accountID: "123" and it works fine further going.

If accountID can be of any type, then remove type: string from setter definition in Kptfile.

@mikebz @phanimarupaka Thanks for the update and the workarounds. This is not urgent - we have worked around it by ensuring that our string setters are specified with quotes in the resource YAML files.


callback.eventProperties.number

I was just helping a client with this StatusPage integration which was relatively easy to set up (which is great) the only issue I experienced was that the StatusPage.io script was trying to create, update and resolve incidents on status page using “callback.eventProperties.number” but no such property existed. I changed this to be “callback.eventIdentifier” instead and everything started to work correctly. Is it possible to get the script on github updated to use that by default ? or is there a reason why eventProperties.number should be used out of the box?

In the demo flow we show that the Incident ID in StatusPage matches the Incident ID in ServiceNow. The "usage" section of the shared library specifically calls this out:
    // If the user responded with 'create statuspage.io incident', then create a new StatusPage Incident using the
    // callback.eventProperties.number value as the Incident Number and add a message of "A new issue has been detected."
    if( callback.response.toLowerCase() == 'create statuspage.io incident' ) {
        var statusPageData = StatusPage.createStatusPageIncident( callback.eventProperties.number, "A new issue has been detected.");
    }

I could add a note to the README.md page that also calls this out.


(PUP-8220) puppet lookup based on factfile restriction

When using puppet lookup with --facts, if the facts file overrides any of
hostname, domain, fqdn, clientcert, then it must override all of them.

Jenkins please test this with servertest

Jenkins please test this with servertest

Jenkins please test this with servertest

Jenkins please test this with servertest

Jenkins please test this with servertest

Jenkins please test this with servertest

jenkins please test this with servertests

I'm gonna merge this since tests passed.
I'll then work on the follow-up for this PR, which should merge these overridden facts with the trusted facts, as right now trusted facts cannot be overridden.


fix atom-shell build error since quotes in spawn

./script/build
Node: v0.10.35
npm: v1.4.28
Installing build modules...
Installing apm...
Installing modules ✓
Deduping modules ✓

events.js:72
        throw er; // Unhandled 'error' event
              ^
Error: spawn ENOENT
    at errnoException (child_process.js:1011:11)
    at Process.ChildProcess._handle.onexit (child_process.js:802:34)

I think it is related #47 , but it is happened in OS X.
I think quoting path caused error in spawn. I introduced in #44 , but I'm not sure it is ok in Windows.
I don't have Windows environment. So, I can't test it.
After I removed quotes, It's ok to run grunt task.
./script/build
Node: v0.10.35
npm: v1.4.28
Installing build modules...
Installing apm...
Installing modules ✓
Deduping modules ✓
Running "build-atom-shell" task

This also happened to me on OS X. Your quote removal also fixed my problem. Thank you.

@outsideris Thanks!

Good!


Add socket types ZMQ_CLIENT & ZMQ_SERVER

Hi, good job with this library. THanks!
It would be good to get also socket types ZMQ_CLIENT & ZMQ_SERVER available. Documnted here http://api.zeromq.org/4-2:zmq-socket
This allows one server to many clients.

I checked the 4.2.2 C header file and found that these socket types are in DRAFT status.
I think it is not safe to enable them. Are these features available in other bindings?

Yes you are correct it is still in draft status since 2015 :-( and "could" be unstable. Too bad!
https://rfc.zeromq.org/spec/41/


⚠ Bofrost.at has degraded performance

In da1fa17, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1930 ms

Resolved: Bofrost.at performance has improved in 375d71b.


Added few comments in the code and renamed url variable to URL to mat…

@MwinyiMoha , in Go , variables with initials e.g url, http need to be capitalized to URL and HTPP respectively. For the case of url , I have renamed it to URL.
This might also mean URL variable can be accessed by  packages , which might not be something you desire. Please advice.

Well, thanks @AntonyIS for reminding me about go conventions in naming variables. Nice catch there, uri should be capitalized.  Regarding access outside the package, I believe that should not be an issue. That's because the URL variable is defined inside a function limiting it's scope to the body of the function. If it was for example, package scoped, capitalizing it would export it.


Print total number of issues, even if maxIssues is not reached, exit code 0

Your feature request may already be reported!
Please search in the issues before creating a new one.
Current Behavior

Currently, if the maxIssues threshold isn't reached, the process exits cleanly and doesn't output the same "Analysis failed with n issues" message indicating the total number
Context

We check the total number against the allowed number in our CI pipelines, to make sure if a new lower bound is reached that we configure out detekt.yml to make that the new maxIssues.
But it's not easy to do this without either running the process twice, or piping stderr to a file and parsing the error count that way.

Why don't you use a baseline instead? I have a baseline with all the current errors and set the allows errors to 0. The baseline suppresses all those known errors but doesn't allow new ones.
Then I also have a nightly that regenerates that baseline. Because we don't allow to merge anything with new errors that task only removes the fixed things from the baseline to avoid regressions.


Add whitespace between code and line numbers in Notebook Cells

Without the whitespace between the line numbers and code, I find the code a little hard to read.
I would like to enable the line numbers when working on large cells.
Note: I enable line numbers because I'd like to collapse some of the code (such as loops and the like).

@roblourens /cc

Same as https://github.com/microsoft/vscode/issues/129146 actually


Update ESLint for looser rules and for JS

Update ESLint to be better for JS to support codebase shift from TS to JS

Note: .ts and .tsx files will no longer be covered by ESLint. These files will be migrated over to JS eventually
Changed from airbnb rules to google rules, these seem to be slightly nicer
There may still exist some annoying rules, let me know if you encounter one and I will have a look at whether we should disable.

Updated VS Code settings to support this change, and fixed a formatted conflict bug

Fixes #86

LGTM


feat(streaming): implement arrangement backfill frontend

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?

[x] frontend needs to change to propagate TableCatalog rather than TableDesc. This is so we can construct both StateTable and StorageTable. This breaks the Chain proto definition. IMO this is acceptable, since when recovering, we will only use StreamFragment, i.e. it is independent of Chain protobuf definition. The only time it would break is if we were running an old frontend with new compute node, but I think that is unlikely.
[x] Feature gate it. This PR can just check correctness by enabling feature gate temporarily.
[x] ~Performance benchmark against backfill for mv-on-mv nexmark queries.~ Separate PR.

Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[x] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

Documentation

[x] My PR contains user-facing changes.

Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.

Installation and deployment
Connector (sources & sinks)
SQL commands, functions, and operators
RisingWave cluster configuration changes
Other (please specify in the release note below)

Release note

Mark as ready for review to test it on CI.

Blocked by another strange bug. Take a look at test4.sql
You may reproduce it like so:
./risedev d; ./risedev psql -f test4.sql < /dev/null; ./risedev k

The final index only has 2 rows, although upstream has 4. Seems like some rows could not be read from snapshot.
The logs has the following debug messages (repeated twice):
risingwave_storage::hummock::iterator::merge_inner: PeekMut are dropped without used. May be caused by future cancellation
risingwave_storage::hummock::iterator::merge_inner: PeekMut are dropped without used. May be caused by future cancellation

Apart from that I couldn't find other hints of what went wrong.

Mark as ready for review to test it.

test_cdc_backfill failed in this PR.
Can reproduce locally with:
MADSIM_TEST_SEED=1693457553767963000 cargo make stest --no-fail-fast -- test_cdc_backfill

Not sure if it's related to some changes I made here. Investigating. cc @StrikeW in case you can spot some error easily.

Thank you, I have tracked down the issue, will fix it soon.

Thank you, I have tracked down the issue, will fix it soon.

Btw e2e source test is failing too https://buildkite.com/risingwavelabs/pull-request/builds/30610#018a49da-9599-4225-aa3d-8e25e3586fcc
Could it be same underlying root cause?

Seems not the same issue, it is always reproducible?

Seems not the same issue, is it always reproducible?

Fixed it, it's caused by this PR.

Passed all the tests. Will polish it up now and get it ready for review.

Testing it again.

Is this replaced by #13622?


Hardware Feature Request: USB 3 chip

It would be great to get faster speeds on the USB side of the SDWireC. Is this planned as a future update?

Hi @moqmar , we are currently working on a design of a new version that utilizes GL3231S which is a USB3 UHS-II capable media chip.
This will of course will require some changes in regard of shape of the board. We are aiming to release the new version by the end of this summer at the latest.
Please raise your concerns if you have any or maybe features that you would like to see added. Thank you for your interest on the project

Thank you for the quick reply back in March, I'm really looking forward to the new version! Is the release still planned for the next months? We are considering whether to wait to order a few of the new version.

@moqmar still not ready for production we are expecting to have prototype run number 3 to arrive this friday, we need to do the tests and then according to results we may need another prototyping run so I cant really promise a date for it

Sounds good, then I'll be waiting for it 😉

@moqmar we are in process of implementing firmware for the SDWire Gen2 but I would like to send you a sample when it is ready to be used. Can you please reach out to us from this email?


buildRustPackage: Provide overrideAttrs

Motivation for this change
Previously, calls to overrideAttrs applied to the wrapped mkDerivation call, and overriding calls to buildRustPackage thus wasn't possible.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

This has been discussed a few times: https://github.com/NixOS/nixpkgs/pull/46842, https://github.com/NixOS/rfcs/pull/67
AIUI this is currently stuck in RFC.

@alyssais I see. Thanks for the info!


[SUPPORT] DateType can't be transformed to right data by kafka avro

Describe the problem you faced
If using DeltaStreamer to get kafka avro data to hudi, DateType can't be transformed to right data (like 2020-8-24). DateType column data always shows 1970-01-01.
To Reproduce
Steps to reproduce the behavior:
I use debezium to get some mysql tables datas to kafka (with avro schema), and then use DeltaStreamer to save in hudi. I checked columns and found that every DateType column data always shows 1970-01-01.
In org.apache.hudi.AvroConversionHelper hudi use these codes to cast int to date:
case (DateType, INT) =>
  (item: AnyRef) =>
    if (item == null) {
      null
    } else {
      if (item.isInstanceOf[Integer]) {
        new Date(item.asInstanceOf[Integer].longValue())
      } else {
        new Date(item.asInstanceOf[Long])
      }
    }

I write some codes to test this:
// 18498 is in a row with type int and logical type date in kafka avro data
System.out.println(new java.sql.Date(18498));// hudi method
System.out.println(org.apache.spark.sql.catalyst.util.DateTimeUtils.toJavaDate(18498));// some spark method

result:
1970-01-01
2020-08-24

Environment Description

Hudi version : 0.6.0

Spark version : 2.4.4

Hive version : 2.3.3

Hadoop version : 2.8.5

Storage (HDFS/S3/GCS..) : HDFS

Running on Docker? (yes/no) : no

Additional context
I think it's a bug, but I'm not sure if anyone else has encountered it and can prove that it's ubiquitous.
If this is really a bug, I think we should open a JIRA to propose a PR to fix it.

Looking at the constructor of java.sql.Date,
Date(long date) :Constructs a Date object using the given milliseconds time value.
It expects time resolution in milliseconds.
But from debezium and Avro specification page, it looks like INT for DATE logical type represents the number of days since epoch.
Filed a Jira : https://issues.apache.org/jira/browse/HUDI-1225
cc @shenh062326
@cdmikechen : Can you send a PR to fix it ?

@bvaradar
Yes, of course. I will deal with it recently.
I've test a case in hive, I found hive may also parse date type as int and display it as yyyy-mm-dd, according to day offsets from 1970-01-01.

Thanks. Closing this issue as it is tracked in Jira


The diff coverage is 97.95%.

@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   90.86%   91.09%   +0.23%
==========================================
  Files          84       75       -9
  Lines       14152    13278     -874
==========================================
- Hits        12859    12096     -763
+ Misses       1293     1182     -111

Flag
Coverage Δ

lint_rules
?

loki
91.09% <97.95%> (-0.01%)
:arrow_down:

transformations
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

loki/sourcefile.py
88.31% <83.33%> (-0.47%)
:arrow_down:

loki/backend/cufgen.py
95.83% <95.83%> (ø)

loki/backend/__init__.py
100.00% <100.00%> (ø)

loki/expression/symbols.py
96.91% <100.00%> (ø)

loki/ir.py
91.65% <100.00%> (ø)

loki/program_unit.py
96.53% <100.00%> (ø)

loki/transform/transform_inline.py
81.17% <100.00%> (+0.68%)
:arrow_up:

loki/transform/transform_utilities.py
89.91% <100.00%> (+3.05%)
:arrow_up:

loki/frontend/regex.py
95.93% <0.00%> (-0.60%)
:arrow_down:

loki/build/workqueue.py
66.19% <0.00%> (-0.47%)
:arrow_down:

... and 22 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Indeed, very neat and well tested! GTG, going in...


kitty: 0.25.1 -> 0.25.2

Things done

Built on platform(s)

[ ] x86_64-linux
[x] aarch64-linux (via Docker)
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

The test failure you worked around is not related to this update or even to kitty. The same failure also happens with alacritty for example. Do you know when the failure was introduced?

The test failure you worked around is not related to this update or even to kitty. The same failure also happens with alacritty for example. Do you know when the failure was introduced?

Caused by https://github.com/NixOS/nixpkgs/pull/171280. I submitted a workaround in https://github.com/NixOS/nixpkgs/pull/177461.

OK, the fix for the previously failing test has been merged into master, so this PR now passes the test and should be ready for review.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/921


Update State of Web Type article

Some small edits and corrections. Also updated the author page.

:+1: Building and deploying now.


Fix Illegal Op permissions caused by exception

When execute opcommand cause exception, the op permission WON'T be reset.

Thanks for your suggestion.
Is it better now? :-)


How to use the extension after installing it?

I can't find svg2ico in the extension menu

I tried to use it, too. I could find a new output format in the Save as... menu. Save as type: "Win Icon File (*.ico)"
However, I get an exception when I try to use it.

What is inkscape version you use?

I am having the same problem. here is my version:
1.0 (4035a4fb49, 2020-05-01)
and here is the error:
Traceback (most recent call last):
File "svg2ico.py", line 79, in
e.saveToFilename(args.o)
File "svg2ico.py", line 61, in saveToFilename
img = Image.open(self.ifName)
File "/usr/lib/python3.8/site-packages/PIL/Image.py", line 2818, in open
raise IOError("cannot identify image file %r" % (filename if filename else fp))
OSError: cannot identify image file '/tmp/ink_ext_XXXXXX.svg6PJON0'

Hi, this still seems to be an issue.
Traceback (most recent call last):
File "C:\Users*\AppData\Roaming\inkscape\extensions\svg2ico\svg2ico.py", line 79, in
e.saveToFilename(args.o)
File "C:\Users*\AppData\Roaming\inkscape\extensions\svg2ico\svg2ico.py", line 61, in saveToFilename
img = Image.open(self.ifName)
File "C:\Program Files\Inkscape\lib\python3.10\site-packages\PIL\Image.py", line 3147, in open
raise UnidentifiedImageError(
PIL.UnidentifiedImageError: cannot identify image file 'C:\Users\****\AppData\Local\Temp\ink_ext_XXXXXX.svgFJRVS1'
Inkscape 1.2.1 (9c6d41e410, 2022-07-14)
Windows 11

As @ginopc mentioned, version 0.2 of this extension isn't compatible with Inkscape 1.0 and later. I added issue #5 and pull request #6 to update the code for Inkscape 1.0.


update loop of frequencies (dict)

Now the template expects a dict
I also opted for a different structure for the dict as
{"label": "1000GMAF, "value": 0.0003}

What do you think of that - makes the code more readable downstream I think :)

I also moved the get_variant test stuff into a fixture which removes some boilerplate!

:+1:


[bal-input-slider] dark green bar is not filled to the center of the circle, when moving to the right or left side

moved to https://github.com/baloise/design-system/issues/724


nova f5 health check is wrong

What version (commit) do you encounter this issue on?
v12.1.0-rc1
What type of issue is this (bug, feature, documentation, regression)?
bug, regression
What is the expected behavior?
heath check is happy
What is actually happening?
health check is sad
How can we reproduce this issue?
run in a lab with health checks
How can we verify your issue is addressed?
heath checks are happy
If this is a large issue, what can be done immediately to alleviate the issue while working on a longer-term solution?
doc change / warning
What is your evaluation on the importance of this issue, and why?
high, this effects a current release
What branches / milestones do you believe this issue should target?
The list below is what is currently supported for backports
Remove branches (lines) you do not wish to target.

[ ] Master #966
[ ] liberty-12.1
[ ] liberty-12.0

NB If I didn't have the PR to reference, this bug submission would give me no clue as to what the actual problem is, other than 'health check is sad'

sorry, I was making this from @b3rnard0's laptop at the end of the day.
the nova url specifies v3, we need to change that to v2.1 as v3 is deprecated.