New Branding - New Sign In Imagery

Details
Add new sign in imagery as part of new branding project

Fixed Issues

$ https://github.com/Expensify/App/issues/12253
Tests

[ ] Verify that no errors appear in the JS console

WEB / Desktop

[ ] Visually QA Sizes for small, tablet, desktop, and wide screen sizes

All Platforms:

[ ] On log in page, visual QA

[ ] Type in email with 2FA enabled, visual QA Magic Code page on both small and wide screen

[ ] Type in magic code, visual QA 2FA page on both small and wide screen

[ ] Click "go back"

[ ] Type in email that does not exist as an account

[ ] visual QA Magic Code page on both small and wide screen

[ ] Go to password page, (to do this I hardcoded showPasswordForm  as true and all others as false in signInPage.js), visual QA on both small and wide screen

[ ] repeat steps going offline for each page and ensure only one offline indicator shows.

Offline tests

QA Steps

[ ] Verify that no errors appear in the JS console
[ ] Same as tests

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[ ] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

 Or will we continue using the pattern of only displaying it on the magic link/2FA screens?

 If you have the K2 extension, you can simply click: [this button]

Hmm in terms of offline indicator, the one below the image definitely feels nicer but my fear is that on shorter device frames, they won't be visible? What do you think?

@shawnborton I agree with the offline indicators looking better underneath. But I imagine with the google/apple auth it'll get even more crowded. We could shrink to fit everything into the window size... but maybe using the other one is fine since it follows the pattern throughout the app anyways?
Also just merged main and I'll see if there's still PHP errors. Other than that, is there anything else visually I should address? Working to get this merged ASAP!

Hmm yeah, and actually with a long scrolling page, we run into some weird issues with trying to fix the offline indicator to the bottom, especially with the keyboard open right?
No other visual things that I can think of, let's get this merged and then we can follow up and put the Lottie animation in there!

https://github.com/Expensify/App/pull/16735#issuecomment-1500520686
@shawnborton could I get the wordmark version of this?

@shawnborton and @thesahindia
Okay after sitting on it, I agree- let's move the offline indicator back below the button and above the image in that case. It will stay in the same place for desktop. It will push the image down at most.

Here is the adhoc wordmark: expensify-logo--adhoc.svg.zip

I agree with that latest set of screenies for the offline indicator being the cleanest, let's go with that.

Sweet, that should be all the necessary updates, going to update my screenshots now!

LOGOS TESTS - @shawnborton I'm not sure the pills are readable enough for some of these, thoughts?

Dev
Staging
Production
AdHoc

I think it's okay, I kinda like how small and subtle it is personally :)

Sweet! In that case, this is ready for review @thesahindia @AndrewGable

Looks like that is a bug reproducible on main. @thesahindia
To reproduce, you log into an account with 2FA with no passwordless beta:

Update, @thesahindia this is not a bug and expected behavior. If you are not on the passwordless beta this is the flow with 2FA:
Mobile:

Desktop:

To easily test without beta, go to SignInPage.js and replace all Permissions.canUsePasswordlessLogins(this.props.betas); with Permissions.canUsePasswordlessLogins(['passwordless']);
Likewise, to test beta, use Permissions.canUsePasswordlessLogins([]);

Done! @thesahindia

@thesahindia this should be good for final review if you're able to prioritize it!

I think the password spacing is NAB for this PR. And Adhoc logo addressed here.

@thesahindia @AndrewGable merged main, final review!

@AndrewGable looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

🤔 - The checklist test must have been running, but checklist was all filled out.

🚀 Deployed to staging by https://github.com/AndrewGable in version: 1.3.1-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/AndrewGable in version: 1.3.1-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.1-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Add Continuous Integration

To help build the binary releases, use a Continuous Integration system such as AppVeyor and Travis CI. There should be 64-bit Debug and Release builds for all three major operating systems supported by virt86 (Windows, Linux and Mac OS X) with the most commonly used compilers on each platform (MSVC, GCC and Clang). Consider 32-bit builds if there is enough interest.
The final package should also include the README.md and LICENSE files from the root of the project.
Note that Mac OS X support depends on #1 and #4.

AppVeyor script added with PR #15.

Basic Travis CI script added with PR #16. Travis does not publish artifacts, so none will be created for Linux. The script also doesn't support Mac OS X, which is still unimplemented.

Travis CI script updated to build for Mac OS X on PR #18. This completes basic support for CI on all three major operating systems supported by virt86.


Validator: Test OpReturnValue type check

The check already existed.  I added a test for it.
Fixes https://github.com/KhronosGroup/SPIRV-Tools/issues/876

Rebased. Keeping LGTM


Cron Alarm not scheduled at startup of gladys

Hello,
I've made test with cron alarm and when creating an alarm while gladys is up,it works fine.
But when you restart Gladys, previous cron alarm seems to be ignored.
When Gladys is up and I create an alarm, I see in the log the line "Scheduled alarm , with id ".
While at startup, I don't see that log and alarm does not works.

completely right, thx for the feedback I'm on it :)


[WIP] Dynamically Sized Jobs - Scale Down

What type of PR is this?
/kind feature
What this PR does / why we need it:
This includes Phase 1 implementation for Dynamically Sized Jobs KEP #1851
Which issue(s) this PR fixes:
Fixes #77
Special notes for your reviewer:
Scale Down only implementation for RayClusters
Does this PR introduce a user-facing change?

Scale Down implementation for RayClusters

cc @andrewsykim @astefanutti

/ok-to-test

/cc

/retest

/retest

friendly ping :) @kerthcet @alculquicondor

/hold
Waiting for the release of 0.7 before merging this

/retest

any update about this PR ?
It was looking as a good start

This needs a contributor to pick up the work and complete the scale up design and implementation.

I am wondering if I can help on this one and the follow-ups

I’m wondering if I could assist with this task and any follow-ups.


Flicker ranger raider fire damage with Oro`s

Hi need your help with this ))
https://pastebin.com/y2TwZxVd

What kind of help? Is there some kind of bug in this setup?
Elaborate on what you want.

i need normal gear set for this bield and flask.maybe more powerfull gem


New MessagePassing for bipartite graphs

I propose the following modification of MessagePassing class, which should fix the problem mentioned in #182

Awesome! I made some minor changes and added tests. Thank you!


Turning fan on/off is not working

I have 2 dreo fans (Tower fan DR-HTF004s and Pedestal Fan DR-HAF003S). I added both to HA and was able to turn them on and off using the integration. But now its not working for both the fans. When i try to turn them on or off using the power button in the integration nothing happens (essentially the state does not change). I enabled the debug logging and see below in the log
2024-05-12 14:44:49.014 WARNING (DreoWebSocketStream) [homeassistant.helpers.frame] Detected that custom integration 'dreo' calls async_create_task from a thread at custom_components/dreo/basedevice.py, line 53: self.async_schedule_update_ha_state(True), please report it to the author of the 'dreo' custom integration
2024-05-12 14:44:49.015 ERROR (DreoWebSocketStream) [homeassistant] Error doing job: Task exception was never retrieved
Traceback (most recent call last):
File "/config/custom_components/dreo/pydreo/commandtransport.py", line 129, in _ws_consumer_handler
self._ws_consume_message(json.loads(message))
File "/config/custom_components/dreo/pydreo/commandtransport.py", line 161, in _ws_consume_message
self._recv_callback(message)
File "/config/custom_components/dreo/pydreo/init.py", line 324, in _transport_consume_message
device.handle_server_update_base(message)
File "/config/custom_components/dreo/pydreo/pydreobasedevice.py", line 79, in handle_server_update_base
self._do_callbacks()
File "/config/custom_components/dreo/pydreo/pydreobasedevice.py", line 117, in _do_callbacks
cb()
File "/config/custom_components/dreo/basedevice.py", line 53, in update_state
self.async_schedule_update_ha_state(True)
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1252, in async_schedule_update_ha_state
self.hass.async_create_task(
File "/usr/src/homeassistant/homeassistant/core.py", line 816, in async_create_task
self.verify_event_loop_thread("async_create_task")
File "/usr/src/homeassistant/homeassistant/core.py", line 440, in verify_event_loop_thread
frame.report(
File "/usr/src/homeassistant/homeassistant/helpers/frame.py", line 162, in report
_report_integration(what, integration_frame, level, error_if_integration)
File "/usr/src/homeassistant/homeassistant/helpers/frame.py", line 203, in _report_integration
raise RuntimeError(
RuntimeError: Detected that custom integration 'dreo' calls async_create_task from a thread at custom_components/dreo/basedevice.py, line 53: self.async_schedule_update_ha_state(True). Please report it to the author of the 'dreo' custom integration.
2024-05-12 14:44:49.023 WARNING (DreoWebSocketStream) [py.warnings] /config/custom_components/dreo/pydreo/commandtransport.py:101: RuntimeWarning: coroutine 'Entity.async_update_ha_state' was never awaited
await self._ws_handler(ws)
2024-05-12 14:45:05.524 WARNING (DreoWebSocketStream) [homeassistant.helpers.frame] Detected that custom integration 'dreo' calls async_create_task from a thread at custom_components/dreo/basedevice.py, line 53: self.async_schedule_update_ha_state(True), please report it to the author of the 'dreo' custom integration

This was actually fixed in v 0.6.4. If anyone else runs into similar issue just update your integration in HACS to 0.6.4 or later.


Readers might copy not reliable code

This looks a bit better:
try
{
MyConfiguration.SuspendExecutionStrategy = true;
...
} finally {
MyConfiguration.SuspendExecutionStrategy = false;
}

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d5b00663-cf69-4f4b-4d86-4b94c861e5ff
Version Independent ID: 77d50147-5917-2af4-0aef-6c55dbaab6bd
Content: Connection resiliency and retry logic - EF6
Content Source: entity-framework/ef6/fundamentals/connection-resiliency/retry-logic.md
Product: entity-framework
GitHub Login: @divega
Microsoft Alias: divega

when you manually call execution strategy instead of creating particular execution strategy it may be worth to use DbProviderServices.GetExecutionStrategy(DbConnection) method. Would you agree?

Thank you for requesting a change to the EF6 documentation. We are prioritizing improvements to the EF Core documentation and at this time we are not making changes to the EF6 documentation.
However, we will consider well-written community pull requests to improve the EF6 documentation. The documentation source is located in the EntityFramework.Docs repository on GitHub. To submit a pull request:

Find the file to update and click on it to open

Click on the edit button (✏) to edit in your web browser

When done, add a title and description, then use the "Create a new branch and start a pull request." option.

(Note that you can also clone the docs repo and do a GitHub PR in the normal way.)


fix: change iOS react header import style to work with Expo SDK

Expo 44.0 now requires importing RN headers using #import <React/*.h> form, see https://github.com/expo/expo/issues/15622#issuecomment-997141629 . Old import style will cause the following build errors.

Showing Recent Messages
CompileC /Users/abing/Library/Developer/Xcode/DerivedData/GcoresMobile-gakxkwdaeaesajbslhafuviqcirt/Build/Intermediates.noindex/Pods.build/Debug-iphoneos/react-native-cookies.build/Objects-normal/arm64/RNCookieManagerIOS.o<EMAIL_ADDRESS>normal arm64 objective-c com.apple.compilers.llvm.clang.1_0.compiler (in target 'react-native-cookies' from project 'Pods')
    cd /Users/abing/Code/gcores/gcores-mobile/ios/Pods
    export LANG\=en_US.US-ASCII
    /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -x objective-c -target arm64-apple-ios11.0 -fmessage-length\=0 -fdiagnostics-show-note-include-stack -fmacro-backtrace-limit\=0 -std\=gnu11 -fobjc-arc -fobjc-weak -fmodules -fmodules-cache-path\=/Users/abing/Library/Developer/Xcode/DerivedData/ModuleCache.noindex -fmodules-prune-interval\=86400 -fmodules-prune-after\=345600 -fbuild-session-file\=/Users/abing/Library/Developer/Xcode/DerivedData/ModuleCache.noindex/Session.modulevalidation -fmodules-validate-once-per-build-session -Wnon-modular-include-in-framework-module -Werror\=non-modular-include-in-framework-module -Wno-trigraphs -fpascal-strings -O0 -fno-common -Wno-missing-field-initializers -Wno-missing-prototypes -Werror\=return-type -Wdocumentation -Wunreachable-code -Wno-implicit-atomic-properties -Werror\=deprecated-objc-isa-usage -Wno-objc-interface-ivars -Werror\=objc-root-class -Wno-arc-repeated-use-of-weak -Wimplicit-retain-self -Wduplicate-method-match -Wno-missing-braces -Wparentheses -Wswitch -Wunused-function -Wno-unused-label -Wno-unused-parameter -Wunused-variable -Wunused-value -Wempty-body -Wuninitialized -Wconditional-uninitialized -Wno-unknown-pragmas -Wno-shadow -Wno-four-char-constants -Wno-conversion -Wconstant-conversion -Wint-conversion -Wbool-conversion -Wenum-conversion -Wno-float-conversion -Wnon-literal-null-conversion -Wobjc-literal-conversion -Wshorten-64-to-32 -Wpointer-sign -Wno-newline-eof -Wno-selector -Wno-strict-selector-match -Wundeclared-selector -Wdeprecated-implementations -DPOD_CONFIGURATION_DEBUG\=1 -DDEBUG\=1 -DCOCOAPODS\=1 -DOBJC_OLD_DISPATCH_PROTOTYPES\=0 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS15.0.sdk -fstrict-aliasing -Wprotocol -Wdeprecated-declarations -g -Wno-sign-conversion -Winfinite-recursion -Wcomma -Wblock-capture-autoreleasing -Wstrict-prototypes -Wno-semicolon-before-method-body -Wunguarded-availability -fembed-bitcode-marker -index-store-path /Users/abing/Library/Developer/Xcode/DerivedData/GcoresMobile-gakxkwdaeaesajbslhafuviqcirt/Index/DataStore -iquote /Users/abing/Library/Developer/Xcode/DerivedData/GcoresMobile-gakxkwdaeaesajbslhafuviqcirt/Build/Intermediates.noindex/Pods.build/Debug-iphoneos/react-native-cookies.build/react-native-cookies-generated-files.hmap -I/Users/abing/Library/Developer/Xcode/DerivedData/GcoresMobile-gakxkwdaeaesajbslhafuviqcirt/Build/Intermediates.noindex/Pods.build/Debug-iphoneos/react-native-cookies.build/react-native-cookies-own-target-headers.hmap -I/Users/abing/Library/Developer/Xcode/DerivedData/GcoresMobile-gakxkwdaeaesajbslhafuviqcirt/Build/Intermediates.noindex/Pods.build/Debug-iphoneos/react-native-cookies.build/react-native-cookies-all-non-framework-target-headers.hmap -ivfsoverlay /Users/abing/Library/Developer/Xcode/DerivedData/GcoresMobile-gakxkwdaeaesajbslhafuviqcirt/Build/Intermediates.noindex/Pods.build/Debug-iphoneos/react-native-cookies.build/all-product-headers.yaml -iquote /Users/abing/Library/Developer/Xcode/DerivedData/GcoresMobile-gakxkwdaeaesajbslhafuviqcirt/Build/Intermediates.noindex/Pods.build/Debug-iphoneos/react-native-cookies.build/react-native-cookies-project-headers.hmap -I/Users/abing/Library/Developer/Xcode/DerivedData/GcoresMobile-gakxkwdaeaesajbslhafuviqcirt/Build/Products/Debug-iphoneos/react-native-cookies/include -I/Users/abing/Code/gcores/gcores-mobile/ios/Pods/Headers/Private -I/Users/abing/Code/gcores/gcores-mobile/ios/Pods/Headers/Private/react-native-cookies -I/Users/abing/Code/gcores/gcores-mobile/ios/Pods/Headers/Public -I/Users/abing/Code/gcores/gcores-mobile/ios/Pods/Headers/Public/DoubleConversion -I/Users/abing/Code/gcores/gcores-mobile/ios/Pods/Headers/Public/RCT-Folly -I/Users/abing/Code/gcores/gcores-mobile/ios/Pods/Headers/Public/React-Core -I/Users/abing/Code/gcores/gcores-mobile/ios/Pods/Headers/Public/React-callinvoker -I/Users/abing/Code/gcores/gcores-mobile/ios/Pods/Headers/Public/React-cxxreact -I/Users/abing/Code/gcores/gcores-mobile/ios/Pods/Headers/Public/React-jsi -I/Users/abing/Code/gcores/gcores-mobile/ios/Pods/Headers/Public/React-jsiexecutor -I/Users/abing/Code/gcores/gcores-mobile/ios/Pods/Headers/Public/React-jsinspector -I/Users/abing/Code/gcores/gcores-mobile/ios/Pods/Headers/Public/React-logger -I/Users/abing/Code/gcores/gcores-mobile/ios/Pods/Headers/Public/React-perflogger -I/Users/abing/Code/gcores/gcores-mobile/ios/Pods/Headers/Public/React-runtimeexecutor -I/Users/abing/Code/gcores/gcores-mobile/ios/Pods/Headers/Public/Yoga -I/Users/abing/Code/gcores/gcores-mobile/ios/Pods/Headers/Public/fmt -I/Users/abing/Code/gcores/gcores-mobile/ios/Pods/Headers/Public/glog -I/Users/abing/Code/gcores/gcores-mobile/ios/Pods/Headers/Public/libevent -I/Users/abing/Code/gcores/gcores-mobile/ios/Pods/Headers/Public/react-native-cookies -I/Users/abing/Library/Developer/Xcode/DerivedData/GcoresMobile-gakxkwdaeaesajbslhafuviqcirt/Build/Intermediates.noindex/Pods.build/Debug-iphoneos/react-native-cookies.build/DerivedSources-normal/arm64 -I/Users/abing/Library/Developer/Xcode/DerivedData/GcoresMobile-gakxkwdaeaesajbslhafuviqcirt/Build/Intermediates.noindex/Pods.build/Debug-iphoneos/react-native-cookies.build/DerivedSources/arm64 -I/Users/abing/Library/Developer/Xcode/DerivedData/GcoresMobile-gakxkwdaeaesajbslhafuviqcirt/Build/Intermediates.noindex/Pods.build/Debug-iphoneos/react-native-cookies.build/DerivedSources -F/Users/abing/Library/Developer/Xcode/DerivedData/GcoresMobile-gakxkwdaeaesajbslhafuviqcirt/Build/Products/Debug-iphoneos/react-native-cookies -fmodule-map-file\=/Users/abing/Code/gcores/gcores-mobile/ios/Pods/Headers/Private/React/React-Core.modulemap -fmodule-map-file\=/Users/abing/Code/gcores/gcores-mobile/ios/Pods/Headers/Public/yoga/Yoga.modulemap -include /Users/abing/Code/gcores/gcores-mobile/ios/Pods/Target\ Support\ Files/react-native-cookies/react-native-cookies-prefix.pch -MMD -MT dependencies -MF /Users/abing/Library/Developer/Xcode/DerivedData/GcoresMobile-gakxkwdaeaesajbslhafuviqcirt/Build/Intermediates.noindex/Pods.build/Debug-iphoneos/react-native-cookies.build/Objects-normal/arm64/RNCookieManagerIOS.d --serialize-diagnostics /Users/abing/Library/Developer/Xcode/DerivedData/GcoresMobile-gakxkwdaeaesajbslhafuviqcirt/Build/Intermediates.noindex/Pods.build/Debug-iphoneos/react-native-cookies.build/Objects-normal/arm64/RNCookieManagerIOS.dia -c<EMAIL_ADDRESS>-o /Users/abing/Library/Developer/Xcode/DerivedData/GcoresMobile-gakxkwdaeaesajbslhafuviqcirt/Build/Intermediates.noindex/Pods.build/Debug-iphoneos/react-native-cookies.build/Objects-normal/arm64/RNCookieManagerIOS.o

In file included from /Users/abing/Code/gcores/gcores-mobile/node_modules/@react-native-cookies/cookies/ios/RNCookieManagerIOS/RNCookieManagerIOS.m:8:
In file included from /Users/abing/Code/gcores/gcores-mobile/node_modules/@react-native-cookies/cookies/ios/RNCookieManagerIOS/RNCookieManagerIOS.h:9:
/Users/abing/Code/gcores/gcores-mobile/ios/Pods/Headers/Public/React-Core/React/RCTBridgeModule.h:68:11: warning: duplicate protocol definition of 'RCTBridgeModule' is ignored [-Wduplicate-protocol]
@protocol RCTBridgeModule <NSObject>
          ^
In module 'React' imported from /Users/abing/Code/gcores/gcores-mobile/ios/Pods/Headers/Public/React-Core/React/RCTBridgeModule.h:11:
/Users/abing/Code/gcores/gcores-mobile/ios/Pods/Headers/Public/React-Core/React/RCTBridgeModule.h:68:11: note: previous definition is here
@protocol RCTBridgeModule <NSObject>
          ^
In file included from /Users/abing/Code/gcores/gcores-mobile/node_modules/@react-native-cookies/cookies/ios/RNCookieManagerIOS/RNCookieManagerIOS.m:8:
In file included from /Users/abing/Code/gcores/gcores-mobile/node_modules/@react-native-cookies/cookies/ios/RNCookieManagerIOS/RNCookieManagerIOS.h:9:
/Users/abing/Code/gcores/gcores-mobile/ios/Pods/Headers/Public/React-Core/React/RCTBridgeModule.h:394:11: warning: duplicate protocol definition of 'RCTTurboModuleRegistry' is ignored [-Wduplicate-protocol]
@protocol RCTTurboModuleRegistry <NSObject>
          ^
In module 'React' imported from /Users/abing/Code/gcores/gcores-mobile/ios/Pods/Headers/Public/React-Core/React/RCTBridgeModule.h:11:
/Users/abing/Code/gcores/gcores-mobile/ios/Pods/Headers/Public/React-Core/React/RCTBridgeModule.h:394:11: note: previous definition is here
@protocol RCTTurboModuleRegistry <NSObject>
          ^
In file included from /Users/abing/Code/gcores/gcores-mobile/node_modules/@react-native-cookies/cookies/ios/RNCookieManagerIOS/RNCookieManagerIOS.m:8:
In file included from /Users/abing/Code/gcores/gcores-mobile/node_modules/@react-native-cookies/cookies/ios/RNCookieManagerIOS/RNCookieManagerIOS.h:9:
/Users/abing/Code/gcores/gcores-mobile/ios/Pods/Headers/Public/React-Core/React/RCTBridgeModule.h:424:1: error: duplicate interface definition for class 'RCTModuleRegistry'
@interface RCTModuleRegistry : NSObject
^
In module 'React' imported from /Users/abing/Code/gcores/gcores-mobile/ios/Pods/Headers/Public/React-Core/React/RCTBridgeModule.h:11:
/Users/abing/Code/gcores/gcores-mobile/ios/Pods/Headers/Public/React-Core/React/RCTBridgeModule.h:424:12: note: previous definition is here
@interface RCTModuleRegistry : NSObject
           ^
In file included from /Users/abing/Code/gcores/gcores-mobile/node_modules/@react-native-cookies/cookies/ios/RNCookieManagerIOS/RNCookieManagerIOS.m:8:
In file included from /Users/abing/Code/gcores/gcores-mobile/node_modules/@react-native-cookies/cookies/ios/RNCookieManagerIOS/RNCookieManagerIOS.h:9:
/Users/abing/Code/gcores/gcores-mobile/ios/Pods/Headers/Public/React-Core/React/RCTBridgeModule.h:438:1: error: duplicate interface definition for class 'RCTBundleManager'
@interface RCTBundleManager : NSObject
^
In module 'React' imported from /Users/abing/Code/gcores/gcores-mobile/ios/Pods/Headers/Public/React-Core/React/RCTBridgeModule.h:11:
/Users/abing/Code/gcores/gcores-mobile/ios/Pods/Headers/Public/React-Core/React/RCTBridgeModule.h:438:12: note: previous definition is here
@interface RCTBundleManager : NSObject
           ^
In file included from /Users/abing/Code/gcores/gcores-mobile/node_modules/@react-native-cookies/cookies/ios/RNCookieManagerIOS/RNCookieManagerIOS.m:8:
In file included from /Users/abing/Code/gcores/gcores-mobile/node_modules/@react-native-cookies/cookies/ios/RNCookieManagerIOS/RNCookieManagerIOS.h:9:
/Users/abing/Code/gcores/gcores-mobile/ios/Pods/Headers/Public/React-Core/React/RCTBridgeModule.h:444:18: error: property has a previous declaration
@property NSURL *bundleURL;
                 ^
In module 'React' imported from /Users/abing/Code/gcores/gcores-mobile/ios/Pods/Headers/Public/React-Core/React/RCTBridgeModule.h:11:
/Users/abing/Code/gcores/gcores-mobile/ios/Pods/Headers/Public/React-Core/React/RCTBridgeModule.h:444:18: note: property declared here
@property NSURL *bundleURL;
                 ^
In file included from /Users/abing/Code/gcores/gcores-mobile/node_modules/@react-native-cookies/cookies/ios/RNCookieManagerIOS/RNCookieManagerIOS.m:8:
In file included from /Users/abing/Code/gcores/gcores-mobile/node_modules/@react-native-cookies/cookies/ios/RNCookieManagerIOS/RNCookieManagerIOS.h:9:
/Users/abing/Code/gcores/gcores-mobile/ios/Pods/Headers/Public/React-Core/React/RCTBridgeModule.h:452:1: error: duplicate interface definition for class 'RCTViewRegistry'
@interface RCTViewRegistry : NSObject
^
In module 'React' imported from /Users/abing/Code/gcores/gcores-mobile/ios/Pods/Headers/Public/React-Core/React/RCTBridgeModule.h:11:
/Users/abing/Code/gcores/gcores-mobile/ios/Pods/Headers/Public/React-Core/React/RCTBridgeModule.h:452:12: note: previous definition is here
@interface RCTViewRegistry : NSObject
           ^
In file included from /Users/abing/Code/gcores/gcores-mobile/node_modules/@react-native-cookies/cookies/ios/RNCookieManagerIOS/RNCookieManagerIOS.m:8:
In file included from /Users/abing/Code/gcores/gcores-mobile/node_modules/@react-native-cookies/cookies/ios/RNCookieManagerIOS/RNCookieManagerIOS.h:9:
/Users/abing/Code/gcores/gcores-mobile/ios/Pods/Headers/Public/React-Core/React/RCTBridgeModule.h:469:1: error: duplicate interface definition for class 'RCTCallableJSModules'
@interface RCTCallableJSModules : NSObject
^
In module 'React' imported from /Users/abing/Code/gcores/gcores-mobile/ios/Pods/Headers/Public/React-Core/React/RCTBridgeModule.h:11:
/Users/abing/Code/gcores/gcores-mobile/ios/Pods/Headers/Public/React-Core/React/RCTBridgeModule.h:469:12: note: previous definition is here
@interface RCTCallableJSModules : NSObject
           ^
/Users/abing/Code/gcores/gcores-mobile/node_modules/@react-native-cookies/cookies/ios/RNCookieManagerIOS/RNCookieManagerIOS.m:94:22: warning: 'sendAsynchronousRequest:queue:completionHandler:' is deprecated: first deprecated in iOS 9.0 - Use [NSURLSession dataTaskWithRequest:completionHandler:] (see NSURLSession.h [-Wdeprecated-declarations]
    [NSURLConnection sendAsynchronousRequest:request  queue:[[NSOperationQueue alloc] init]
                     ^
In module 'Foundation' imported from /Users/abing/Code/gcores/gcores-mobile/ios/Pods/Headers/Public/React-Core/React/RCTBridgeModule.h:8:
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS15.0.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSURLConnection.h:454:1: note: 'sendAsynchronousRequest:queue:completionHandler:' has been explicitly marked deprecated here
+ (void)sendAsynchronousRequest:(NSURLRequest*) request
^
/Users/abing/Code/gcores/gcores-mobile/node_modules/@react-native-cookies/cookies/ios/RNCookieManagerIOS/RNCookieManagerIOS.m:272:23: error: declaration of 'RCTConvert' must be imported from module 'React.RCTConvert' before it is required
    NSString *name = [RCTConvert NSString:props[@"name"]];
                      ^
In module 'React' imported from /Users/abing/Code/gcores/gcores-mobile/ios/Pods/Headers/Public/React-Core/React/RCTBridgeModule.h:11:
/Users/abing/Code/gcores/gcores-mobile/node_modules/react-native/React/Base/RCTConvert.h:27:12: note: declaration here is not visible
@interface RCTConvert : NSObject
           ^
3 warnings and 6 errors generated.

@safaiyeh any chance you could help with this 🙏

Let’s ship it! Would this be breaking for people who use vanilla React Native? @capezzbr @ouabing

:tada: This PR is included in version 6.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


microk8s is not running on CentOS 7.2

Please run microk8s.inspect and attach the generated tarball to this issue.
We appreciate your feedback. Thank you for using microk8s.
I use the stable and beta version, it can't running.
centos:~$ microk8s.status
microk8s is not running. Use microk8s.inspect for a deeper inspection.
centos:~$ microk8s.inspect
Inspecting services
  Service snap.microk8s.daemon-cluster-agent is running
  Service snap.microk8s.daemon-flanneld is running
  Service snap.microk8s.daemon-containerd is running
  Service snap.microk8s.daemon-apiserver is running
  Service snap.microk8s.daemon-apiserver-kicker is running
  Service snap.microk8s.daemon-proxy is running
  Service snap.microk8s.daemon-kubelet is running
  Service snap.microk8s.daemon-scheduler is running
  Service snap.microk8s.daemon-controller-manager is running
  Service snap.microk8s.daemon-etcd is running
  Copy service arguments to the final report tarball
Inspecting AppArmor configuration
Gathering system information
  Copy processes list to the final report tarball
  Copy snap list to the final report tarball
  Copy VM name (or none) to the final report tarball
  Copy disk usage information to the final report tarball
  Copy memory usage information to the final report tarball
  Copy server uptime to the final report tarball
  Copy current linux distribution to the final report tarball
  Copy openSSL information to the final report tarball
  Copy network configuration to the final report tarball
Inspecting kubernetes cluster
  Inspect kubernetes cluster

Building the report tarball
  Report tarball is at /var/snap/microk8s/1047/inspection-report-20191111_113738.tar.gz

inspection-report-20191111_113738.tar.gz

It seems the hostname of your machine includes underscores. This is not a valid node name. Could you try editing /var/snap/microk8s/current/args/kubelet to append the line --hostname-override=mynode and then restart the cluster with microk8s.stop; microk8s.start?

@ktsakalozos
Thank you.
Use  --hostname-override=mynode is worked for me to start up the microk8s. BUT dns addon will not working. So change the hostname is the right way  to solve my issue. Thanks.


in germany, the dot is used as thousand separator

...and never ever the space! never!

You'll probably have better luck over here: https://github.com/foretagsplatsen/numbro


fix:修复了被open调用时，set_schema会重复添加数据的问题

What problem were solved in this pull request?
Issue Number: close #xxx
Problem: 在NLJ里面会遍历多次右表，就会调用很多次close和open，而open当中会调用set_schema，从而导致join的时候就会出来一个几十个field和value的tuple，后续的话会被select的字段给过滤掉，不影响正确性
What is changed and how it works?
在set_schema当中每次先清空原本tuple当中的field即可。
Other information

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Create LICENSE

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.83%. Comparing base (b424dc1) to head (bd90c2f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #30   +/-   ##
=======================================
  Coverage   95.83%   95.83%
=======================================
  Files          17       17
  Lines         336      336
=======================================
  Hits          322      322
  Misses         14       14

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


kie-test-util: add common persistence utils

cherry-picked to 6.4.x

+1, waiting for build to succeed and then will merge.


Syntax error on voice.gd on godot 4.1.4

Hi,
I tried to run the latest godot 4 example with GodotSteam 4.1.4 pre-compile version.
When trying to make a build, it didn't work because of a syntax error on the voice.gd script.
It happens because it seems that on the 4.1.x versions, the cast in for loops is not possible.
voice.gd (l.142)
for i: int in range(0, mini(local_playback.get_frames_available() * 2, local_voice_buffer.size()), 2):
I tested on 4.2.2 pre-compile version and it works, so I am pretty sure that a little PR is needed.

Hmm, yeah, that's a pretty wild looking for loop line.  Interesting it works in 4.2.2.  I will have to check it out and get it fixed up.  Thanks for reporting it!

Sorry for the long delay!  These tutorials are going to be replaced soon with new ones from Skillet which will link to working code in an actual game.  It should solve these issues.
Also the voice stuff needs a bit of overhaul, I think.  We talked about changing some things internally too.


[Docs] Update YAML reference doc to include properties of builtin pulumi variable

Hello!

Vote on this issue by adding a 👍 reaction
If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details
Per @AaronFriel, there are three properties exposed on the builtin pulumi variable: pulumi.cwd, pulumi.project, and pulumi.stack. However, these properties do not seem to be documented in the Pulumi reference documentation.
Affected area/feature
The Pulumi YAML documentation

Closed via https://github.com/pulumi/pulumi-hugo/pull/2344


Wait for InstallPlan to complete when installing the OSP operators

Till now we weren't waiting for the OSP operators to be completely installed what may cause some race conditions. This PR ensure the InstallPlan is completed before proceeding consuming the deployed operators.

/trigger github-experimental


[AI-4525] Add toggle for FIPS mode

What does this PR do?

Motivation

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
[ ] If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Superseded by #19179


fix extra validation issues

Docs Build status updates of commit b6c9d92:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

dynamics-gp/distribution/Inventory2.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 26f4d25:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

dynamics-gp/distribution/Inventory2.md
:white_check_mark:Succeeded
View

dynamics-gp/web-components/connecting-to-the-web-client.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@edupont04
This PR fixes two issues that were a little trickier to figure out. Please review and merge at your convenience :)
Thanks!!


Request for using test data

Hello,
Many thanks for your work.
I'd like to use matio's hdf5 datasets to test an implementation of Matlab's interface to HDF5 including v7.3 format mat files. Can I add the dataset submodule to my repo?  Thanks.
Sorry for using the issue tracker for this request that is not an actual matio issue, but I didn't know how to contact the matio maintainers.

Yes, you can use the test files as you like. They are available from https://sourceforge.net/p/matio/matio_test_datasets/ci/master/tree/ .

Many thanks for your reply, I added the submodule with this changeset.

https://github.com/tbeu/matio/blob/master/.gitmodules uses some different url, but I guess both cases are valid.

At least that url seams to work for me.
Le lun. 8 mai 2023 à 18:47, tbeu @.***> a écrit :

https://github.com/tbeu/matio/blob/master/.gitmodules uses some different
url, but I guess both cases are valid.
—
Reply to this email directly, view it on GitHub
https://github.com/tbeu/matio/issues/204#issuecomment-1538712656, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAVE2CPFBDFPWC4MH6FGEF3XFEPRRANCNFSM6AAAAAAXU7JVLU
.
You are receiving this because you authored the thread.Message ID:
@.***>


osvr_server aborts when compiled with GCC 4.8.x std::regex not implemented

This issue was reported by @mastykin via Gitter Chat Apr 05 04:51
Due to commit: f1a4a5925a1435121ac627ed328a557506850a02
The problematic line here
The use of std::regex is not implemented in GCC 4.8.x (see references)
Upgrading to GCC 4.9.x or higher will resolve the issue.
The code will not fail to compile, it will fail at runtime as follows:
./osvr_server
[OSVR Server] Using default config file - pass a filename on the command line to use a different one.
[OSVR Server] Using config file 'osvr_server_config.json'
[OSVR Server] Constructing server as configured...
[OSVR Server] Loading auto-loadable plugins...
[OSVR Server] Loading plugins...
[OSVR Server]
[OSVR Server] Instantiating configured drivers...
[OSVR Server]
terminate called after throwing an instance of 'std::regex_error'
what(): regex_error
Aborted (core dumped)

GDB backtrace: http://pastebin.com/PLux4MeT
References:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53631
http://stackoverflow.com/questions/20027305/strange-results-when-using-c11-regexp-with-gcc-4-8-2-but-works-with-boost-reg
http://stackoverflow.com/questions/12530406/is-gcc-4-8-or-earlier-buggy-about-regular-expressions

Oh, rats. can't even compile-time detect it. We're not doing anything too complex with that code (It's just trying to figure out what got passed: does it end with :portnum? does it have some weird thing like tcp:// in it?), so that we can normalize the most common cases. So it could presumably be fairly easily re-written to not use a regex and or use alternate regex libraries (less desireable since IIRC boost regex isn't header only). I would like to keep GCC 4.8 usable.
I suppose this would be an argument for putting these little utility functions (not just the containers and essential utilities) in some separate place and unit testing them like crazy, though I don't know which of the various builders run the tests.
Happy to accept help on this one - I'd have to go digging through refs to see if there's a good string member function to solve this in an efficient way (since it's like "find first not of" on a reversed string)

I think there is code to parse things like this in VRPN.  It was written before the regex stuff came into C++.

The code in VRPN does not seem to be quite as robust, but it should work fine on expected input cases.
I believe this is the code to get the port number:
https://github.com/vrpn/vrpn/blob/e75e92c11ac7aef840a29755d33606a4f338fba4/vrpn_Connection.C#L6419

When this crashes for me on gcc 4.8.4, it is throwing an exception for a non-matching bracket.  Removing the brackets from the expression makes the code run (but not work correctly), so it looks like maybe there is an implementation that is broken or we're not properly escaping some character...

Fixed in https://github.com/OSVR/OSVR-Core/pull/481 by replacing the regex code with std::string and isdigit() function.  This issue can be closed when the pull request is merged.

I was just going through some old issues, I am going to close this out since the linked pull was merged. No testing to make sure that this was resolved happened, it just seemed stale.


MyBinder shows only the Python GISandbox environment

How about the R GISandbox environment?

@eshook
Correct me if I'm wrong, but I believe MyBinder supports only one environment.
A possible workaround (there may be something better), clone the repository, in the clone delete environment.yml and rename R-environment.yml to environment.yml -- that should provide you a working R environment.


Support binary deployments of .NET Core apps onto a Windows stack

Same as #151 +support for netcoreapp3.1 apps

Noticed that there was no / endpoint configured by default for our sample netcoreapp3.1 app -- we had to amend the template "WeatherForecastController" to add a / endpoint

Closing; the strategy for this work has changed & is now tracked by #162


Release v0.21.0 on November 16, 2021

Checklist

[x] Create the new release branch with minor version, i.e. release-0.21 for v0.21.0.

You can use the existing branch for patch releases.

[x] Tag release by running Tag action in Github UI against release branch, i.e. release-X branch.

Use v-prefixed version, like v0.21.0, for both description and tag.

[x] Run CI action against release branch.
[x] Tag the next pre-release by running Tag action in Github UI against master branch, if it's not a patch release.

The tag should be v0.22.0-rc.0 if you're releasing v0.21.x.

[x] Validate that you can install the published version, basic sanity check.
[x] Run Promote action to promote it in alpha channel if it's pre-1.0.
[ ] Use Github UI to generate release notes.

Make sure to scan all PRs marked with breaking-change and add instructions for users to handle them.

[x] Create the next release issue with a title that has its date, 4 weeks after the current release day.
[ ] Announce in Slack, Twitter etc.

I have merged a couple of approved PRs and I was too fast that CI broke in master because we don't require PRs to be up-to-date. https://github.com/crossplane/provider-aws/pull/950 is opened to fix it.
We'll continue the release process once that PR is merged.

@muvaf what is missing to create Release ? I can see that some Folks using 0.21.x ;)

@haarchri It's the generated release notes in Github. Details are here: https://github.com/github/feedback/discussions/5975#discussioncomment-1660720
I guess I'll have to go with manual release notes until the issue is fixed.

Done! https://github.com/crossplane/provider-aws/releases/tag/v0.21.0


"Failed to get ports for pod" logged at ERROR level for most pods

I'm using datadog-agent 6.1.0 on Kubernetes v1.8.9, running on GKE.
When the agent starts up I see several logs like this:
[ AGENT ] 2018-03-26 09:31:40 UTC | ERROR | (kubelet.go:170 in createService) | Failed to get ports for pod fluentd-gcp-v2.0.9-976xf

Looking at the code (https://github.com/DataDog/datadog-agent/blob/614a3ffc537e4d360bcc5c0adca09015e8a28422/pkg/collector/listeners/kubelet.go#L170) I see that this error log is made for every container that doesn't have any ports specified.
I don't think that this is an error condition, or even something that should be a warning.

I got the same issue here ? any way to solve this ?

[ AGENT ] 2018-04-23 12:50:40 UTC | ERROR | (kubelet.go:170 in createService) | Failed to get ports for pod fluentd-6bzxm

Is this a bug or at least an error with a known fix?  I am trying to understand the source if this error and how to remedy it.
[ AGENT ] 2018-05-15 17:26:55 UTC | ERROR | (kubelet.go:170 in createService) | Failed to get ports for pod calico-node-...
[ AGENT ] 2018-05-15 17:26:55 UTC | ERROR | (kubelet.go:170 in createService) | Failed to get ports for pod fluent-bit-...
[ AGENT ] 2018-05-15 17:26:55 UTC | ERROR | (kubelet.go:170 in createService) | Failed to get ports for pod prometheus-alertmanager-...```

Hey all,
This was indeed set as Error while it should just be a Debug log.
It happens if for instance we don't find ports in pod spec of the pod.
The PR that fixed this is https://github.com/DataDog/datadog-agent/pull/1490 and the fix is embedded in the version 6.2 of the agent that we released a few days ago (will be available at datadog/agent:latest).
Could you give this a try and let us know if that helps ?
Best Regards,


Use cl-cairo2 for drawing menus, panels etc

I've managed to pass pixel buffer from cairo directly to texture without copying it into a lisp array but cairo uses reversed argb format which OpenGL is supposed to support but I think either cl-opengl doesn't or there's no way to make cepl use it. If I'm not mistaken it's both and needs to be fixed in both libraries.
There are two workarounds:

Write a c library with a single function to switch blue and red components.
Pass bgr colors to cl-cairo2:set-source-rgb.

Off the top of my head: can we just use a custom shader to swap the components.
For ages I was drawing components in the wrong order (the gif in the readme is an example, the colours are incorrect). The fix was just swapping the colours in the shader.

On 30 Apr 2017, at 13:07, naryl<EMAIL_ADDRESS>wrote:
I've managed to pass pixel buffer from cairo directly to texture without copying it into lisp array but cairo uses reversed argb format which OpenGL supposed to support but I think either cl-opengl doesn't or there's no way to make cepl use it. If I'm not mistaken it's both and needs to be fixed in both libraries.
There are two workarounds:
Write a c library with a single function to switch blue and red components.
Pass bgr colors to cl-cairo2:set-source-rgb.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I found a way to load it with correct pixel format, but it requires a call to internal cepl.types::make-pixel-format.


Do not allow empty wish

Describe the bug
Right now, the UI allows the user to submit an empty wish. We shouldn't allow that.
To Reproduce
Steps to reproduce the behavior:

Do not add any wish
Hit the Add button
An empty eish gets added.

Expected behavior

The add button shouldn't be enabled unless a wish(at least 2 characters) are added.

Dada I accepted the challenge

Can I solve it?

@Eth3R-One if your not solving the issue then i want @atapas  sir to assign this issue to me

@Mohimkhan This issue was not assigned to me. However you can request a PR if the assigned person hasn't made any PR yet

@Mohimkhan This issue was not assigned to me. However you can request a PR if the assigned person hasn't made any PR yet

oh I wanted to say this to @rafeuddaraj brother, mistakenly mention you. Tnx for the suggestion.

Hi, @atapas I don't see this issue getting fixed. May I work on this?


Lexical Issue and Deprecated Methods

After upgrading Snowplow tracker pod version to 1.1.2. I have 4 warnings coming out of the SDK. One is a Lexical/Preprocessor issue and the 3 deprecated methods. I have attached a screenshot with all the warnings I am facing.

Closing as I think it has been fixed along with #432


[do not merge - WIP] add tags to snapshots, restored volumes

Fixes #307
Fixes #278
Initial implementation for AWS. These changes:

copy tags from the source EBS volume to the snapshot when taking a backup
copy tags from the snapshot to the new EBS volume when doing a restore
add ark-specific tags to the snapshot with the backup name and pv name (may be redundant - is this true in all cases?)

This is intentionally the MVP for this feature request. I didn't modify plugin interfaces or do significant refactoring to be able to tag with things like pod name. The dynamic provisioner already tags volumes with pv, pvc, namespace name and that seems sufficient.
Looking for feedback before proceeding to other cloud providers or fixing unit tests.
cc @totemcaf @activeshadow @rbowlby @kaspernissen @ncdc @nrb

This is great! Thank you. 👍
In our case we have multiple k8s clusters in the same region so there's always a chance that the snapshots could originate from either. A tag specifying the k8s cluster name could prove useful, if not merely for our use case.

I like this, even in the most basic case of retaining tags for restore. I think I agree with @rbowlby that having some sort of tag for the cluster could prove useful.
Amazon's docs point out that there's a limit of 50 user-defined tags, though I doubt we'd really get close to that.

cluster name is added by the AWS dynamic provisioner, so covered there

@ncdc are you happy with this approach?

@skriss approach seems reasonable

addressed feedback and added implementations for Azure, GCP. haven't tested those or re-tested AWS yet.

This approach isn't right for GCP; will need to look at that more.

OK, I've updated the implementations for Azure and GCP to address the nuances there, and have tested both successfully.

@skriss we should test the ark server without and then with this change to see if it fixes a problem where the kops master isn't allowed to attach ebs volumes that ark creates from snapshots.

xref #369

okay, I can try that out - never used kops before but it'll be a good chance to get some familiarity.

btw, @ncdc this should be ready for another review, as I've tested the core functionality across clouds. whenever you get a chance.

I used kops for the first time this morning. Installed using brew and it was pretty simple.

OK did kops testing - first tried a backup/restore with ark:master; the restore failed due to unable to attach the volume. Then did the same with this PR; the restore succeeded. (separately, I need to add one more item to the minimal IAM permissions in our docs since this PR adds a DescribeSnapshots call).

Yay!

addressed all feedback and fixed 2 other minor issues

Generally LGTM. Would be nice to have some unit tests for the tagging (copy from volume to snapshot, copy from snapshot to volume, ark assigned tags, new ark assigned tags overwrite previously set ark assigned tags).

Can definitely add units, although I'll have to do some refactoring first to separate the tag logic into helpers that I can test without actually making any API calls. Want me to do that before merge?

Yes please. LMK if you want to discuss the splits.

@ncdc please review https://github.com/heptio/ark/pull/341/commits/22d4ce27db95e6197b67234f68ef9404c2d99fb5 before I proceed to the other providers

@skriss that looks good, but do you need to do any sorting in the unit test since getCreateTagsInput uses map-order sorting (i.e. not guaranteed) to iterate through arkTags?

good idea.

So far this looks good to me, I'd echo some sorting in the units.

okey doke, unit-tested all the tags. i'll do some squashing before merge.

squashing done - @ncdc this is ready for a final review.

went through a backup & restore on AWS and everything looks good.

LGTM. You've tested GCP and Azure too?

I tested GCP and Azure manually before adding the unit testing for tags - think I need to go through that again given the little bit of refactoring?

Can't hurt :)

GKE looks good. Having a hard time getting a working azure env atm.

Ok, was able to successfully test on azure too.

@ncdc this is ready to merge when you are.

how to add tags to the snapshot when taking the backup?


refactor htlc interceptor

Adds a flag that makes htlc interception a requirement. The switch will queue htlcs as long as there is no interceptor connected. When the stream disconnects, htlcs waiting for resolution will not resume automatically.
Supersedes #6165
Solves #6161

@carlaKC @champo I tried a few variations of the always on interceptor and ended up with what's in this PR. Tried to address the outstanding comments in https://github.com/lightningnetwork/lnd/pull/6165

This is a great improvement! Moving the logic to interceptable switch makes a lot of sense.

could it reject all htlcs when an interceptor is not connected rather than queue them?

could it reject all htlcs when an interceptor is not connected rather than queue them?

That is a dangerous setup. The interceptor may have signaled to settle an htlc. Then lnd goes down for some reason, replays the packet but finds no interceptor. It will then fail the htlc while the interceptor assumes it has been settled.

could it reject all htlcs when an interceptor is not connected rather than queue them?

That is a dangerous setup. The interceptor may have signaled to settle an htlc. Then lnd goes down for some reason, replays the packet but finds no interceptor. It will then fail the htlc while the interceptor assumes it has been settled.

I mean new HTLCs, not ones that were already received, or is that what this does do?

Got it. Yes, I think that could be safe. Not sure though if we have the (persisted) information somewhere that indicates whether the htlc is new or not.
We have the plan to do a height watcher in a follow-up pr that fails htlcs when they get close to the broadcast deadline. This has sort of the same effect when the interceptor doesn't connect anymore, only delayed.
Are concerns about force-closes the reason why you ask?

We have the plan to do a height watcher in a follow-up pr that fails htlcs when they get close to the broadcast deadline. This has sort of the same effect when the interceptor doesn't connect anymore, only delayed.

Are concerns about force-closes the reason why you ask?

I think force closes are definitely a concern due to closing costs but also the case that excessively holding HTLCs start to represent a cost to the holding party. I think failing HTLCs is a simpler failure mode than holding other people's pending payments open

The always-on mode is intended for interceptors that are high availability. Given that, dangling htlcs should be an edge case.

Is the queue bounded by the HTLC slots? The other concern is that if the interceptor failed that HTLCs would queue endlessly?

Added commit that fails fresh packets if the interceptor is required but not connected. Interested to hear the opinion of reviewers on this addition.

I think failing HTLCs when the interceptor is disconnected is not a good idea from a reliability stand point given that only one interceptor can be registered at a given time. It means deploys or restarts of an interceptor are always visible downtime to users or if you use the interceptor to enforce some sort of traffic policy it means unwanted HTLCs might be handled automatically. Always holding HTLCs + height based failure IMO makes it safe to use the API and easier to reason about what's going on from the implementors point of view.

A compromise could be: don't hold HTLCs longer than x blocks when interceptor is disconnected?

If the interceptor is down, isn't it preferred to present the user with a failure rather than holding on to the htlc and locking capital along the route for an extended period of time (several blocks)?

Yeah I'm saying hold capital for the least possible amount of time

I guess that depends on whether you expect the interceptor to have high uptime or not. The question can also be: if the intercptor will come right back up, why present the user with a failure? That said, this can be easily customized with a small patch, I'll defer to the mantainers opinions.

What would be a reasonable time for this? To just cover deployment windows, it doesn't need to be long. Definitely not until getting close to htlc expiry.

I think a watcher that does the following two things should cover it all:

Watches block height for all pending intercepts and auto-fails before the channel is force-closed
Keeps a timer for new pending intercepts and auto-fails if no interceptor connects in time.

@yyforyongyu: review reminder

Rebased

Taking over review from @yyforyongyu to balance his load a bit.

Who can hit the merge button on this triple green check pr? There is more work to do within this theme!


https://hacktoberfest.lingonsaft.com/ Homepage, shows countdown negative

Homepage of the repo here
https://hacktoberfest.lingonsaft.com/
shows countdown in negative.
I think we should update it for next year's hacktoberfest and be ready with it.
Any thoughts?

That sounds like a good idea :) want to make a pull request?

I will start working on it.


Lab 6, Ex 5: Payload is missing

Module: 6
Lab/Demo: 6
Exercise : 5
Task: 2
Step: 9
This step asks you to choose the "2 Failed messages" payload.  There's no payload with this name in the list of payloads being shown.

@AnnetteGill thanks for the feedback, we have updated the instructions to reflect a new different payload and the option to select any other payload should that option no longer exist in the future. In the context of this specific exercise, it doesn't matter which payload is selected.

Thank you, that's good.


Release/0.19.1

Codecov Report

Merging #558 (e77805b) into main (e19efce) will decrease coverage by 1.00%.
The diff coverage is 23.80%.

@@            Coverage Diff             @@
##             main     #558      +/-   ##
==========================================
- Coverage   97.57%   96.56%   -1.01%
==========================================
  Files          56       56
  Lines        2271     2303      +32
==========================================
+ Hits         2216     2224       +8
- Misses         55       79      +24

Impacted Files
Coverage Δ

pfhedge/stochastic/local_volatility.py
82.85% <ø> (ø)

pfhedge/nn/functional.py
86.23% <20.00%> (-9.16%)
:arrow_down:

pfhedge/autogreek.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e19efce...e77805b. Read the comment docs.


[PDI-13713]: XML Input StAX reader doesn't add namespace info on attributes

There is a fix for attributes and EndElement also.
It's added unit tests.

@mattyb149 Hi, please review the fix.

Do we need null checks around things like a.getName().x()? Or does the API guarantee non-null names, etc.

Javadoc (e.g.http://docs.oracle.com/javase/7/docs/api/javax/xml/stream/events/StartElement.html) doesn't point that a.getName() can return null. At the same time if the method does it (e.g. getAttributeByName ), it is pointed explicitly.
So we don't need null checks around cases a.getName().x()

@mattyb149 apparently - once an element or an attribute exists in XML doc it has to have a name.


Energy jump at the start of the day since 21/10/22

I have had glow running for several months and was working perfectly. Recently I noticed that the energy was incorrect and saw these values in HA;

Looking back in the history I see that it started to happen overnight on 21/10. Seems I was getting updates of zero regularly but then it stopped and every morning since it jumps from zero to a few hundred Watt hours instantly which then skews the figures.

Not sure if something in HA broke it or an ESP update.
Anyone else seen this or can shed some light on it?
I have set internal_filter: 100ms but this has made no difference.
Thanks

Strange, I've never come across that before

Yes, very odd. That is how mine used to look.
Today on looking at the power I get two blips when there was no generation. I use this only for a solar generation meter (as the inverter's energy over-reads) and it was dark at these times.
I have overlaid the inverter's power and it has no spikes but other than that it tracks almost identically.


[GLib] Add GArrowStringViewDataType

Describe the enhancement requested
arrow::StringViewType has been introduced.
GLib needs to be implemented as GArrowStringViewDataType.
Component(s)
GLib

Issue resolved by pull request 44687
https://github.com/apache/arrow/pull/44687


Ensure only single precision is being used

Metal on OS X does not support double precision.
See https://github.com/glium/glium/issues/1908 for related info

In reference to jpaoneMines/csci441#15


mem: skip defer for performance

We're looking to move to go-capnproto2 from the original and we've been comparing the performance of the two using alecthomas' go serialization benchmark suite.
This is a minor patch which improves the speed moderately.  We're still looking at options for increasing the speed.  Most of them probably involve changing the go structs to pointers, if that's amenable to you.
Here's the performance comparison with and without this changeset:
https://gist.github.com/abraithwaite/a8876d351edf16bc052cd6b5acdaa330
I'm not sure why the svgs don't render nicely on gist though :-(

How I wish that defer was faster.  This seems fine.
I remember Jason using that benchmark suite to compare perf numbers before.  You may also be interested in running go test -bench='BenchmarkUnmarshal_Reuse', which makes even less allocations with an increase in potential complexity.  I haven't gotten around to upstreaming those.
I'm curious: why will converting the structs to pointers make perf improvements?  I recently made a largeish API change to remove allocations in the hot paths because it was adversely impacting perf.

My mistake.  My expectation is that by not allocating the metadata structs it'll speed it up a bit.

Coming back to this:

why will converting the structs to pointers make perf improvements?

You may also be interested in running go test -bench='BenchmarkUnmarshal_Reuse'

That's exactly what I was looking for.  Only just got around to reading that code.  I also made a patch for the the serialization benchmarks repo. Here are the results: https://gist.github.com/abraithwaite/905555e81b35eca8d30987690dfc1220
Very nice! 👏

Merged with some tweaks to critical sections.
You should go ahead and upstream the benchmark changes.


chore(nps): Move publishing dryrun script to nps

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


replace size-comparison in test with "hasSameSizeAs"

My SonarLint-plugin displayed this as warning and I just applied the quick-fix.

Hi @nils4cosee,
thanks for the quick fix. It looks like there is similar occurrence in DiagnosisKeyServiceTestHelper:
assertThat(actKeys).withFailMessage("Cardinality mismatch").isNotNull().hasSize(expKeys.size());

@michael-burwig I fixed that warning as well.

I was a bit quick with creating this PR. Please do not merge at the moment. Even though it is only a small fix. You can do the fix yourself if you want, but please not (yet) with my name on it.


Cli should ignore a config file env variable value of empty string

Also fix test framework to not generate an empty string WSK_CONFIG_FILE env value by default

@csantanapr - good travis/pg.  Ready for review/merge.  Thanks!

@mdeuser did you addressed @rabbah comments ?

@rabbah please review the latest changes and either approve or request changes

This PR also includes the change to have the CLI ignore a WSK_CONFIG_FILE value that's an empty string.  I'd like the ability for a given test suite to run correctly by itself with a set of test defaults, but also to run in another context with an externally provided WSK_CONFIG_FILE setting that provides context aware behavior.  Using the CLI environment variable seemed like a good way to do this.
Using an empty WSK_CONFIG_FILE value still works.  The CLI will simply ignore it.  Travis/PGs passed with this change - are the package installation needs included in those test suites?

I'll add a separate WSK_CONFIG_FILE empty string test to make sure the empty string test continues to work correctly.

I think I did not communicate my concern clearly - let me try again. In the presence of a ~/.wsprops file, setting WSK_CONFIG_FILE= forces (today) the CLI to ignore the property file and hence start with no properties.
For example:
> ls ~/.wskprops
/my/home/.wskprops

> WSK_CONFIG_FILE= wsk property get --all --apihost xxx
whisk auth
whisk API host
whisk API version	v1
whisk namespace		_
whisk CLI version	2017-06-09T21:18:47+00:00
whisk API build		Unknown
whisk API build number	Unknown

This feature is used by the catalogs to override the presence of a local file when installing catalogs.

Ah.. I now understand.  Currently, there's no test that enforces the above behavior; thus the need for that test.  I'll also need to back out the CLI change to maintain that behavior.  Probably need a doc update to describe this as well.

@rabbah - test added.  original capability restored.

@mdeuser is this pr abandoned?

@mdeuser the comment and test for WSK_CONFIG_FILE == "" are 👍
but this change is still in and is a breaking change:
+        val envMap = { cliCfgFile map {f => Map("WSK_CONFIG_FILE" -> f) } getOrElse Map() }
can we back these out?

@rabbah - i missed the earlier comment.  sorry.  yeah, i no longer need this WSK_CONFIG_FILE behavior change as i was able to extend some tests with cli property changes set in the superseding test class.  so the only change in this pr that seems relevant is the updated test case and the property.go comments.  that's probably what you are suggesting.

indeed.

pg2/2071

@rabbah - travis passed.  related pg tests passed.  ready for final review/merge


[Waiting for CLA signed] Update maintain-dm-using-tiup.md

tiup start start prod-cluster 修改为 tiup dm start prod-cluster

What is changed, added or deleted? (Required)

Which DM version(s) do your changes apply to? (Required)

[ ] master (the latest development version, including v3.0 changes)
[x] v2.0 (TiDB DM 2.0 versions)
[ ] v1.0 (TiDB DM 1.0 versions)

What is the related PR or file link(s)?

This PR is translated from:
Other reference link(s):

Do your changes match any of the following descriptions?

[ ] Delete files
[ ] Change aliases
[x] Have version specific changes
[ ] Might cause conflicts after cherry-picked

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

correct command

@ireneontheway PTAL

Can you  sign our Contributor License Agreement
before we can accept your contribution? @mac119

@mac119 Please take a look?

This PR is ready for merge after you sign the CLA. Thanks for your contribution. @mac119

As the license doesn't pass, I‘ll reopen later.

@mac119 Can you sign our Contributor License Agreement?

Hi,@mac119. Thanks for your contribution. We've adopted your advice and reopened it in https://github.com/pingcap/docs-dm/pull/360 and https://github.com/pingcap/docs-dm/pull/396. Because we cannot merge this PR for the lack of your Contributor License Agreement.


Mutual exclusive properties?

Recently I'm looking Telegram Bot API which is plain REST APIs. There is a some point that attract me, it's rare, but reasonable limitation of API schema.
https://core.telegram.org/bots/api/#inlinekeyboardbutton
The document says

You must use exactly one of the optional fields.

Which means, if you set a property of the API, then you can't set the others. It's kind of a mutual exclusive. Could schema-inspector model this?

Hi @heycalmdown
You can extend the schema-inspector to allow this behaviour.
var schema = {
    type: 'object',
    exec: function (schema, post) {
          // here you can check the root object post and check if only 1 key is available here
    }
};

Hope it helps!


Bot not updating this repo?

I've made several releases of this package, but the bot hasn't made any PRs. See https://pypi.org/project/versioned-hdf5/#history.
CC @conda-forge/bot

Hi! I hope you've been well!
The issue here is that you are making tags, but not github releases on the upstream repo.

A tag generates a URL like this
https://github.com/deshaw/versioned-hdf5/archive/refs/tags/1.3.3.tar.gz

whereas the feedstock is expecting a URL of the form
https://github.com/deshaw/versioned-hdf5/releases/download/{{ version }}/{{ name }}-{{ version }}.tar.gz

There are a number of possible remedies to this including changing the feedstock, making sure to do a github release instead of a tag, or making a PR to the bot to try tag URLs for github versions.

Ah, I forgot that I have to manually convert the tags into releases, because the rever release activity is broken. Let me do that now and see if the bot runs.

A way to avoid this in the future is to change the feedstock to use the tag URL format above. Every github release makes a tag too.

Actually I think I do need to do that, because when I manually create the release, I don't always upload the release files to it.
Is there any reason to not just use pypi for the release file? That should be the canonical place to get it from.

In fact, using the file from a tag would not be a good idea because that is just GitHub automatically zipping up the git repo at that tag. But you need to build from the source distribution, not from git (it wouldn't matter for this feedstock, but in general there can be files that are in the source distribution that aren't tracked by git).

For a pure python package a GitHub release will work fine. I have several feedstocks that work this way. An sdist does not appear to be required in simple cases at least. I cannot speak to this package.
GitHub automatically creates release tarballs of the repo for releases. See the links on the releases page.
You are free to ship releases from w/e source you'd like of course!

Yes, I know GitHub does it automatically. That's what I was referring to above ("GitHub automatically zipping up the git repo at that tag"). But that's not at all the same thing as an sdist.
Is there a canonical way to get a link from PyPI? The link from the PyPI page has a hash in the URL, which is not ideal.


Code Comments and Fix to Token Generation

I added one library getPass, which lets us hide the username and password entry. This works fine in Rstudio, I have not tested it in Jupyter where it might not work.

I fixed the EDL credential token retrieve to work even if a user doesn't have a token yet, otherwise users had to first use the website to generate the first time.

Went through and clarified most of the code comments.

Remember to update the Quarto file as well.


how to write a paper with R Markdown

Hi @Robinlovelace
Just made these materials, although using RMD instead of quarto.
https://u-shift.github.io/R2Paper/
Maybe we can re-use something, or maybe not :)

Fantastico! Yes let's at least cross-reference that.


demos: Change logo absolute path to relative path

Fixes #2424

VIA has a couple of examples of this, but I'd agree with Karl and just remove it, at least for now.

@karl-lunarg My thought process was that if the user put both repos in the recommended places (some overarching development directory) the logo would appear and if the configuration varied or if  VulkanTools didn't exist on the system the logo simply wouldn't show up. This is the case for Chrome but now that I've switched to viewing this on Firefox, I can see the problem..
I'd prefer a permanent URL to the logo (it looks nicer) but I can just remove the line for now.
Note: This line was copied and pasted from the api dump html template which suffers from the same erroneous absolute file path.

Yes, but many users are going to be using vulkaninfo out of an SDK where there are no GitHub repos checked out.   In addition, it is possible that a user might run vulkaninfo to generate an HTML file and then send it via email to someone to look at.  The recipient isn't likely to have the repos and isn't likely to download the attachment into the exact location in the repo that would make this relative path work.
I think that removing the reference is the best solution.  If we decide to host the image file on a server someplace, then we could put it back.  But I don't think it is worth it.
I'll open an issue on VulkanTools to address the problem there.
Thanks for fixing this!

@karl-lunarg You make a lot of great points. Thanks for all the info!

Pushed to master


When serviceData fails validation, include the service class in the stack trace

This should make it easier to debug #3784.

Warnings

:warning:

Found 'assert' statement added in core/base-service/base.js. Please ensure tests are written using Chai expect syntax

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @paulmelnikow!

  Generated by :no_entry_sign: dangerJS against 33f06093d878bb120689b59fe1e5d61cf7ccbc15


Installation fails with a version conflict

 pip install . -e . results in
Obtaining file:///C:/Users/lab/GithubRepositories/sympy-plot-backends
ERROR: Cannot install sympy-plot-backends 0.8.0 (from C:\Users\lab\GithubRepositories\sympy-plot-backends) because these package versions have conflicting dependencies.

The conflict is caused by:
    The user requested sympy-plot-backends 0.8.0 (from C:\Users\lab\GithubRepositories\sympy-plot-backends)
    The user requested sympy-plot-backends 0.8.0 (from C:\Users\lab\GithubRepositories\sympy-plot-backends)

To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip attempt to solve the dependency conflict

My bad, I wrote the wrong command. Install it with:
pip install -e .


linux-build

Setup a rakefile build script to build the project under linux.
Also fixed existing build errors under linux.

Thanks @cbpassingham. I have a RPi2 on its way that I'll test this on before merging to master.

// TODO: cleanup "Dirty hack attack!"
std::stringstream command;
command << "mkdir -p " << path;
system(command.str().c_str());

Should be able to use an anonymous string:
system(string("mkdir -p " + path).c_str());


Allow to configure a concrete indexRoot to lscount/lsstat

Hi,
Sometimes, one would like (the great) Bosun to query the same Elasticsearch (ES) index for an alert.
Current implementation force the user to use 'prefix-yyyy.MM.dd' index naming convention.
Suggested is to allow the user to configure an indexRoot that will be used as the index name, without Bosun need to suffix it with something or any other changes.
Example use-case is ES indices with a small size of a couple of MB per day. ES indices are an expansive unit in matter of RAM and CPU to maintain it.
Currently I solved this by creating a single index 'my_index-global' and funneling all the relevant logs into it. the I crontab-ed an alias creation  command to add aliases matching Bosun requirements.
Thanks,
Yarden

Best idea I have thought of is to have the prefix argument take a special
character at the end that is not allowed in index names....
On Tue, May 19, 2015 at 4:22 PM, Yarden Bar<EMAIL_ADDRESS>wrote:

Hi,
Sometimes, one would like (the great) Bosun to query the same
Elasticsearch (ES) index for an alert.
Current implementation force the user to use 'prefix-yyyy.MM.dd' index
naming convention.
Suggested is to allow the user to configure an indexRoot that will be used
as the index name, without Bosun need to suffix it with something or any
other changes.
Example use-case is ES indices with a small size of a couple of MB per
day. ES indices are an expansive unit in matter of RAM and CPU to maintain
it.
Currently I solved this by creating a single index 'my_index-global' and
funneling all the relevant logs into it. the I crontab-ed an alias creation
command to add aliases matching Bosun requirements.
Thanks,
Yarden
—
Reply to this email directly or view it on GitHub
https://github.com/bosun-monitor/bosun/issues/974.

Or you could use a verbose postfix. logstashWITHOUT-A-DATE works just as well as logstash@ or whatever obscure character with unknown meaning we can come up with

Verbose postfix may create noise in configuration code, and we cant use the
$(regex end of line and bosun var prefix)
Can we do #,<,@       ?
On Wed, May 20, 2015 at 12:02 AM, Greg Bray<EMAIL_ADDRESS>wrote:

Or you could use a verbose postfix. logstashWITHOUT-A-DATE works just as
well as logstash@ or whatever obscure character with unknown meaning we
can come up with
—
Reply to this email directly or view it on GitHub
https://github.com/bosun-monitor/bosun/issues/974#issuecomment-103666727
.

I think https://github.com/elastic/elasticsearch/issues/9059 talks about the valid characters for index names.

must be lowercase
must NOT start with an underscore, a + or a -
index names starting with '.' are reserved
. and .. are forbidden, though they can occur in the name
\, /, *, ?, ", <, >, |, ,, are forbidden

I don't have any particular preference, which character if single
character, or if verbose
On Tue, May 19, 2015 at 5:41 PM, Greg Bray<EMAIL_ADDRESS>wrote:

I think elastic/elasticsearch#9059
https://github.com/elastic/elasticsearch/issues/9059 talks about the
valid characters for index names.

must be lowercase
must NOT start with an underscore, a + or a -
index names starting with '.' are reserved
. and .. are forbidden, though they can occur in the name
, /, *, ?, ", <,>, |,,, are forbidden

—
Reply to this email directly or view it on GitHub
https://github.com/bosun-monitor/bosun/issues/974#issuecomment-103675477
.

I'd say * and ? should be avoided since we may want to support globs on metrics at some point. So any of the other forbidden index characters would work.

Is pipe a reserved char in Go Template or somewhere in Bosun?

@kylebrandt suggested to short-circut GenIndex function after initializing ES client:
	if len(r.IndexRoot) > 0 {
		if r.IndexRoot[len(r.IndexRoot)-1] == '/' {
			return r.IndexRoot[:len(r.IndexRoot)-1], nil
		}
	}

Tested on my dev-env and it works great!
Can you please add it to next release?
Thanks,
Yarden


CRUD Themes

[ ] Add a route to add new themes
[ ] Add an isActive column in the themes table of the DB for suggested themes

moving the ticket to the right deposit


Docs for new boards

@shaunmulligan, Please merge this when we have images for new boards on docker registry


Add language server and neovim setup instructions

Please check if the PR fulfills these requirements

[ ] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This change introduces README changes containing language server installation steps and Neovim setup guide.

Looks good, thanks! Just a couple of thoughts:

Since VsCode doesn't need the Language Server installed separately, should we have separate headings in the Installation section between between "All in one IDE Plugins" and "Language Server Configurations"? Then it can be clearer that Neovim requires the Language Server to have been installed already, but VsCode doesn't
With the Neovim configuration - it's probably obvious to a neovim expert, but to a newbie it's not clear where that lua file should go.  Can you note it, or include a link to the neovim documentation about how to configure neovim with such lua scripts?

Looks good, thanks! Just a couple of thoughts:
1. Since VsCode doesn't need the Language Server installed separately, should we have separate headings in the `Installation` section between between "All in one IDE Plugins" and "Language Server Configurations"? Then it can be clearer that Neovim requires the Language Server to have been installed already, but VsCode doesn't

Hey! Good points! 👍 I'll do some changes to the headings!

2. With the Neovim configuration - it's probably obvious to a neovim expert, but to a newbie it's not clear where that lua file should go.  Can you note it, or include a link to the neovim documentation about how to configure neovim with such lua scripts?

I guess I agree on that it's not very 'newbie' friendly currently. I can add that it should be required in the init.lua file and add a link to the more extensive documentation https://neovim.io/doc/user/lua-guide.html#lua-guide-config

I did the changes you suggested! Before the merge the branch needs to be autosquashed as there are fixup commits.


[kinetic] Release moveit_pr2 0.7.0

bloom failed with a early EOF error on creating the pull request, I've finished it off manually.
Increasing version of package(s) in repository moveit_pr2 to 0.7.0-1:

upstream repository: https://github.com/ros-planning/moveit_pr2.git
release repository: https://github.com/ros-gbp/moveit_pr2-release.git
distro file: kinetic/distribution.yaml
bloom version: 0.6.4
previous version for package: null

moveit_pr2
* Migrate to format2
* Add Bence as maintainer
* Remove moveit-tutorials dependency
* Contributors: Bence Magyar, Dave Coleman, Isaac I.Y. Saito
* [fix] Remove obsolete dependency on moveit-tutorials #92 <https://github.com/ros-planning/moveit_pr2/issues/92>
* Contributors: Dave Coleman

pr2_moveit_config
* Migrate to format2
* Fix xacro warnings
* [moveit.rviz] Fix always showing init pose. (#89 <https://github.com/ros-planning/moveit_pr2/issues/89>)
  Init pose would always be shown in addition to the current {start, goal} poses. This is useless and confusing.
  Although only thing I did was to remove RobotState panel, and save as to overwrite the same .rviz file, there are some changes that seem unrelated. I do not know what happened but if some of those changes should be reverted let me know.
* allow to open pr2_moveit_config in setup_assistant
  The temp-file does not exist and the moveit_config
  already run_depends on pr2_description anyway.
* add arms_and_torso group
* Contributors: Bence Magyar, Christian Dornhege, Isaac I.Y. Saito, tarukosu, v4hn

pr2_moveit_plugins
* Maintainer update & order dependencies
* pluginlib headers migration
* Migrate to format2
* Add Bence as maintainer
* GetKinematicSolverInfo -> KinematicSolverInfo
* compile with c++11
* Explicitly convert shared_ptr to bool for c++11 compatibility.
* Contributors: Bence Magyar, Christian Dornhege, Dave Coleman, Isaac I.Y. Saito, Maarten de Vries, v4hn

pr2_moveit_tests
* pluginlib headers migration
* Migrate to format2
* Add Bence as maintainer
* Fix xacro warnings
* Fix test compilation
* Fix fcl and kdl dep names
* Contributors: Bence Magyar, Isaac I.Y. Saito

You can rerun it with -p and it will create the pull request only.

I've updated the kinetic.ignored file, I'll re-run bloom now. Thanks for the tips.


I'd like to feature your library on JetpackCompose.app

Hey! I'd like to feature your library on JetpackCompose.app/ComposeCatalog. Just wanted to give you a heads up!

Hey that would be great @vinaygaba! Thank you for considering

@hi-manshu Sorry about not having done that long ago. I completely missed it and got reminded on Twitter over the last couple days.

Please don't be sorry, thanks for considering


[ISSUE #6036]Optimize the PULL_REQUEST_TEMPLATE.md

Make sure set the target branch to develop
What is the purpose of the change
fix #6036
Brief changelog

Optimize the PULL_REQUEST_TEMPLATE.md

Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Codecov Report

Merging #6037 (6b718e5) into develop (4cfd54f) will increase coverage by 0.02%.
The diff coverage is 40.00%.

@@              Coverage Diff              @@
##             develop    #6037      +/-   ##
=============================================
+ Coverage      43.33%   43.36%   +0.02%
- Complexity      8843     8849       +6
=============================================
  Files           1093     1093
  Lines          76851    76854       +3
  Branches       10015    10015
=============================================
+ Hits           33307    33330      +23
+ Misses         39380    39369      -11
+ Partials        4164     4155       -9

Impacted Files
Coverage Δ

.../rocketmq/common/utils/ConcurrentHashMapUtils.java
58.33% <40.00%> (-8.34%)
:arrow_down:

...ache/rocketmq/broker/client/ConsumerGroupInfo.java
69.29% <0.00%> (-3.51%)
:arrow_down:

...he/rocketmq/broker/controller/ReplicasManager.java
44.40% <0.00%> (-2.62%)
:arrow_down:

.../apache/rocketmq/controller/ControllerManager.java
71.87% <0.00%> (-2.09%)
:arrow_down:

...saction/queue/TransactionalMessageServiceImpl.java
50.89% <0.00%> (-1.03%)
:arrow_down:

...rocketmq/client/impl/factory/MQClientInstance.java
47.41% <0.00%> (-0.60%)
:arrow_down:

.../org/apache/rocketmq/store/ha/DefaultHAClient.java
61.53% <0.00%> (-0.52%)
:arrow_down:

...main/java/org/apache/rocketmq/store/CommitLog.java
65.23% <0.00%> (+0.10%)
:arrow_up:

...e/rocketmq/namesrv/routeinfo/RouteInfoManager.java
63.75% <0.00%> (+0.32%)
:arrow_up:

...cketmq/store/ha/autoswitch/AutoSwitchHAClient.java
76.53% <0.00%> (+0.36%)
:arrow_up:

... and 10 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[Fix] Gravity start in front card image

[Fix] Gravity start in front card image

Se arregla el gravity start en la imagen de la tarjeta para poder optimizar las imagenes correctamente

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@6e365bc). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop     #839   +/-   ##
==========================================
  Coverage           ?   27.26%
==========================================
  Files              ?      334
  Lines              ?    20150
  Branches           ?     1896
==========================================
  Hits               ?     5493
  Misses             ?    13995
  Partials           ?      662

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e365bc...e155266. Read the comment docs.


speed up lru cache lookup

The LRU cache is implemented using python dictionaries, where the
function arguments become the "key" for the lookup.
In this lookup, python dictionaries use the __eq__ method to compare
keys (not the __hash__ method).
For pymatgen.core.structure.IStructure, the __eq__ method is very
slow (it checks whether coordinates agree within a given threshold).
The dictionary lookup has a trick: if one looks up by the same object in memory,
then lookup is fast and __eq__ is not called.
This is what happens when you run
mofchecker = MOFChecker.from_cif('tests/structures/str_m1_o12004_MTW.cif')

once (takes ~20s, which is also way too slow but one step at a time).
However, when you run it the next time
mofchecker = MOFChecker.from_cif('tests/structures/str_m1_o12004_MTW.cif')

it now takes ~90s because there are 12 lookups in the LRU cache, each of which takes several seconds.
Here we subclass IStructure, overwriting the equality check to make
cache lookups performant.
Unfortunately, this is also not a satisfactory solution since the
default hash implemented by IStructure is very minimal: it just checks
whether the composition is the same.
I.e. if you are running two structures after another that have the same
composition but different indices you would now get a wrong result.
One could try improving the IStructure hash but, probably the
indices should rather be cached on a MOFChecker instance, not globally.
Since one anyhow creates new instances for new structures that would
solve the cache invalidation issue automatically - the only problem is
that the new code layout with the separate checks makes moving the cache
to the MOFChecker a bit complicated.
Any thoughts @kjappelbaum?

[ ] Breaking change (fix or feature that would cause existing functionality to change)

Thanks for bringing this up. I was aware of how lru works and I am aware that my codes are not fast, but didn't realize that the IStructure equality does not work as I expected. However, it should be easy to make it work as I expect (via the json/string representation of the pmg object) and I can do this next week.
Regarding the wheel: https://github.com/kjappelbaum/mofchecker/issues/145

it should be easy to make it work as I expect (via the json/string representation of the pmg object)

Added this

Codecov Report

Merging #160 (e25ae00) into master (dbbc2b9) will increase coverage by 0.13%.
The diff coverage is 100.00%.

Thanks for the quick implementation, this looks really good to me. The only thing i wanted to test if one can actually have this dict-based hash as cached_property.

The only thing i wanted to test if one can actually have this dict-based hash as cached_property.

sounds good, done!

many thanks, great improvement for the code! and thanks for also including all the comments (I'm still stuck in the application process ...)


Profiles: Export when Show Profile Contents view is open doesn't bring up quick pick

Does this issue occur when all extensions are disabled?: Yes

VS Code Version:

Version: 1.75.0-insider
Commit: 727d2d32aea02baf7d13fa38787e8ed64dd858d0
Date: 2023-01-06T05:21:04.561Z
Electron: 19.1.8
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 20.6.0
Sandboxed: Yes

OS Version:
MacOS Big Sur latest

Steps to Reproduce:

Create a new profile
Click on the Profile Activity Bar icon, then choose Export Profile...

Result: the quick pick comes up...

Now click on the Show Profile Contents menu item to bring up the view
Click on the Export Profile... menu item again

Result: focus just moves to the Show Profile Contents pane

Expectation: Show the Quick Pick so the menu works the same regardless of whether or not the content view is open

I was also hit by this - that by clicking on "Export Profile..." it looks like it has no effect, when it fact it just passed the focus.
@sandy081 we could always show quick pick as Chris suggests?

What about the contents view when you click on Export Profile... again? Does this has to be closed or remain like this? May I understand what is confusing in navigating to the contents view when you click on export profile button?

I think you can leave the view open, but I would open the Quick Pick right away, not force the user to click on the Export button (again).

Another idea (that was also mentioned in the UX call) is how about always open the view and ditch quick pick? This was initial flow actually.

I think that flow might work. My biggest concern is that users might not notice that the focus moved to the view (especially if the view is already open). Long term - maybe the view becomes a custom editor?
fyi @daviddossett @stevencl

Quick pick is removed and by default we show the contents view now.


Add a link to the raw data

Add a link to the raw data under the Links section

Resolved with
550ab03


Add a websocket consumer for the logs

TLDR This PR adds a baby websocket consumer to the Client for the purpose of streaming the task logs from the backend endpoint.
Implementation
As a first step, we add a new module named logs to the Client, with the sole method to connect to the websocket and read from it whatever is being stream.
For the purpose of demonstration, we have created a Flask server that streams some random logs based on the provided TaskId. For dummy purposes, the server is as follows:
from flask import Flask
from flask_sock import Sock
import time
import random
import string

app = Flask(__name__)
sock = Sock(app)

@sock.route("/logs/<task_id>")
def logs(ws, task_id):
    timer = 0
    message = f"Logs of Task_ID: {task_id}."
    ws.send(message)
    while True:
        random_string = "".join(random.choices(string.ascii_lowercase, k=10))
        time.sleep(1)
        timer += 1
        message = f"Simulation Time: {timer}s: {random_string}"
        ws.send(message)

@sock.route("/close")
def close(ws):
    ws.close()

To run this server install pip install flask-sock and it can be launched within the directory it lives with flask run. This provides an IP which we are connecting to, in the dummy implementation in the Client.
On the client, we instantiate a websocket that connects to this IP and that allows users to start streaming the provided logs from the Flask server.
Running the Logs
The first implementation to read the logs is from the CLI, and users can fetch the logs of a certain task via inductiva logs {task_id}.
For example, inductiva logs 1234, provides the following output until it's killed with ctrl+c:

This PR proposes the MVP presented in inductiva/tasks#29.

@sergiomsantos Addressing the general picture, and given that this will be always specific for a task, I moved the file to the tasks folder under the name of streams.py. Hence, we remove another unneeded init file, and the extra name of task in the previous naming.