[request-pull] reorganize imageboard related Bridges

it should fix #372

The following changes since commit c365f35e47ed498d0362fc140f2b6885137fbe6b:
Merge branch 'MangareaderBridge' of https://github.com/logmanoriginal/rss-bridge (2016-09-03 20:39:40 +0200)
are available in the git repository at:
https://framagit.org/peetah/rss-bridge ooruFusion
for you to fetch changes up to e7f2bf19f32263f316f58137e00ed55cb7e8f8f4:
[bridges] Shimmie v2 based imageboards derive from DanbooruBridge (2016-09-04 01:27:58 +0200)

Pierre Mazière (4):
[bridges] one bridge for technically different imageboard solutions
[bridges] Gelbooru based imageboards derive from DanbooruBridge
[Bridges] Moebooru and MyImouto based imageboards derive from MoebooruBridge
[bridges] Shimmie v2 based imageboards derive from DanbooruBridge
bridges/BooruprojectBridge.php | 60 ++++++++++++++++++++++++------------------------------------
bridges/DanbooruBridge.php     | 81 ++++++++++++++++++++++++++++++++++++++++++++++++---------------------------------
bridges/DollbooruBridge.php    | 36 +++---------------------------------
bridges/GelbooruBridge.php     | 39 ++++++++++-----------------------------
bridges/KonachanBridge.php     | 41 +++--------------------------------------
bridges/LolibooruBridge.php    | 43 ++++---------------------------------------
bridges/MilbooruBridge.php     | 32 ++------------------------------
bridges/MoebooruBridge.php     | 49 +++++++++++++++++++++++++++++++++++++++++++++++++
bridges/MspabooruBridge.php    | 36 +++---------------------------------
bridges/Rule34Bridge.php       | 37 ++++---------------------------------
bridges/Rule34pahealBridge.php | 35 +++--------------------------------
bridges/SafebooruBridge.php    | 36 ++++--------------------------------
bridges/SakugabooruBridge.php  | 41 +++--------------------------------------
bridges/Shimmie2Bridge.php     | 31 +++++++++++++++++++++++++++++++
bridges/TbibBridge.php         | 37 ++++---------------------------------
bridges/XbooruBridge.php       | 37 ++++---------------------------------
bridges/YandereBridge.php      | 41 +++--------------------------------------
17 files changed, 202 insertions(+), 510 deletions(-)
create mode 100644 bridges/MoebooruBridge.php
create mode 100644 bridges/Shimmie2Bridge.php

Merged.
Related commits:

e7f2bf19f32263f316f58137e00ed55cb7e8f8f4 - [bridges] Shimmie v2 based imageboards derive from DanbooruBridge - by @pmaziere
fd6bcbbafe70c2e753cede65d2116d543ad7f6ac - [Bridges] Moebooru and MyImouto based imageboards derive from MoebooruBridge - by @pmaziere
8ae05a024123bb1e9b11e213fd78bf93a40b1da1 - [bridges] Gelbooru based imageboards derive form DanbooruBridge - by @pmaziere
97926b839e51abf6d8e4ec616bc7231ecaac6da8 - [bridges] one bridge for technically different imageboard solutions - by @pmaziere


Get all subjects in a document

This may already be possible, but I haven't been able to get anything to work.
I'm trying to get all the subjects in a given document, or even all the subjects matching some predicate in a given document.
Example of what I am trying to do:
for await (const activity of data['https://jshurmer.inrupt.net/public/activities']) {
  //activity is now an ldflex object of each activity at that path
}
//or
for await (const bookmark of data['https://jshurmer.inrupt.net/public/bookmarks']) {
 //bookmark is an ldflex of each bookmark
}
//etc.

I'd be happy to contribute, if this currently is not supported, but could use a pointer on the best way to introduce this functionality. The sparql handler doesn't seem to to be handling this correctly, it expects a predicate but only has the url as a subject. Could this be fixed with a small change to that handler to support no-predicates? or Would it be better to introduce a new .all property that builds a different sparql entirely perhaps?

It's definitely a good idea to have something for all subjects.
However, the syntax you propose would be inconsistent with the notion of a path, and it already has a meaning: https://solid.github.io/ldflex-playground/#['https%3A%2F%2Fjshurmer.inrupt.net%2Fpublic%2Factivities']
For consistency:

data['https://ruben.verborgh.org/profile/#me'] evaluates to 'https://ruben.verborgh.org/profile/#me'
data['https://ruben.verborgh.org/profile/#me'].friends evaluates to 'https://data.verborgh.org/people/ben_abelshausen', etc.
data['https://ruben.verborgh.org/profile/#me'].friends.firstName evaluates to 'Ben', etc.

The functionality you suggest could be implemented as, for example, data['https://jshurmer.inrupt.net/public/activities'].subject, analogously to #27.


octopus: 8.2 -> 8.3

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/octopus/versions.
meta.description for octopus is: '"Real-space time dependent density-functional theory code"'.

Checks done (click to expand)

built on NixOS
/nix/store/vry1vim5nv1zdlm1m9p8218y1pk63v9f-octopus-8.3/bin/oct-atomic_occupations passed the binary check.
/nix/store/vry1vim5nv1zdlm1m9p8218y1pk63v9f-octopus-8.3/bin/oct-run_periodic_table passed the binary check.
Warning: no invocation of /nix/store/vry1vim5nv1zdlm1m9p8218y1pk63v9f-octopus-8.3/bin/oct-display_partitions had a zero exit code or showed the expected version
/nix/store/vry1vim5nv1zdlm1m9p8218y1pk63v9f-octopus-8.3/bin/oct-run_regression_test.pl passed the binary check.
/nix/store/vry1vim5nv1zdlm1m9p8218y1pk63v9f-octopus-8.3/bin/oct-run_testsuite.sh passed the binary check.
Warning: no invocation of /nix/store/vry1vim5nv1zdlm1m9p8218y1pk63v9f-octopus-8.3/bin/oct-analyze_projections had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/vry1vim5nv1zdlm1m9p8218y1pk63v9f-octopus-8.3/bin/oct-vdW_c6 had a zero exit code or showed the expected version
/nix/store/vry1vim5nv1zdlm1m9p8218y1pk63v9f-octopus-8.3/bin/oct-check_deallocs passed the binary check.
/nix/store/vry1vim5nv1zdlm1m9p8218y1pk63v9f-octopus-8.3/bin/octopus passed the binary check.
/nix/store/vry1vim5nv1zdlm1m9p8218y1pk63v9f-octopus-8.3/bin/oct-test passed the binary check.
Warning: no invocation of /nix/store/vry1vim5nv1zdlm1m9p8218y1pk63v9f-octopus-8.3/bin/octopus_mpi had a zero exit code or showed the expected version
/nix/store/vry1vim5nv1zdlm1m9p8218y1pk63v9f-octopus-8.3/bin/oct-propagation_spectrum passed the binary check.
/nix/store/vry1vim5nv1zdlm1m9p8218y1pk63v9f-octopus-8.3/bin/oct-harmonic-spectrum passed the binary check.
/nix/store/vry1vim5nv1zdlm1m9p8218y1pk63v9f-octopus-8.3/bin/oct-casida_spectrum passed the binary check.
/nix/store/vry1vim5nv1zdlm1m9p8218y1pk63v9f-octopus-8.3/bin/oct-vibrational_spectrum passed the binary check.
/nix/store/vry1vim5nv1zdlm1m9p8218y1pk63v9f-octopus-8.3/bin/oct-infrared_spectrum passed the binary check.
/nix/store/vry1vim5nv1zdlm1m9p8218y1pk63v9f-octopus-8.3/bin/oct-xyz-anim passed the binary check.
/nix/store/vry1vim5nv1zdlm1m9p8218y1pk63v9f-octopus-8.3/bin/oct-center-geom passed the binary check.
/nix/store/vry1vim5nv1zdlm1m9p8218y1pk63v9f-octopus-8.3/bin/oct-help passed the binary check.
Warning: no invocation of /nix/store/vry1vim5nv1zdlm1m9p8218y1pk63v9f-octopus-8.3/bin/oct-oscillator-strength had a zero exit code or showed the expected version
/nix/store/vry1vim5nv1zdlm1m9p8218y1pk63v9f-octopus-8.3/bin/oct-dielectric-function passed the binary check.
/nix/store/vry1vim5nv1zdlm1m9p8218y1pk63v9f-octopus-8.3/bin/oct-photoelectron_spectrum passed the binary check.
/nix/store/vry1vim5nv1zdlm1m9p8218y1pk63v9f-octopus-8.3/bin/oct-convert passed the binary check.
/nix/store/vry1vim5nv1zdlm1m9p8218y1pk63v9f-octopus-8.3/bin/oct-local_multipoles passed the binary check.
/nix/store/vry1vim5nv1zdlm1m9p8218y1pk63v9f-octopus-8.3/bin/oct-conductivity passed the binary check.
/nix/store/vry1vim5nv1zdlm1m9p8218y1pk63v9f-octopus-8.3/bin/oct-floquet passed the binary check.
21 of 26 passed binary check by having a zero exit code.
0 of 26 passed binary check by having the new version present in output.
found 8.3 with grep in /nix/store/vry1vim5nv1zdlm1m9p8218y1pk63v9f-octopus-8.3
directory tree listing: https://gist.github.com/9f6b6ce987c25a7b326b6df762f4a24d
du listing: https://gist.github.com/12718c47a42c40b6a2ad02d77e0e7cb1

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)
1 package rebuild(s)
1 x86_64-linux rebuild(s)
0 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
0 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
octopus

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/vry1vim5nv1zdlm1m9p8218y1pk63v9f-octopus-8.3 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A octopus https://github.com/r-ryantm/nixpkgs/archive/b8e09ad0b526eee1009608f28efb5e8745f189e0.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/vry1vim5nv1zdlm1m9p8218y1pk63v9f-octopus-8.3
ls -la /nix/store/vry1vim5nv1zdlm1m9p8218y1pk63v9f-octopus-8.3/bin

cc @markuskowa for testing.

Changelog: http://octopus-code.org/wiki/Changes#.5B8.3.5D_-_2018-11-13


[service-loadbalancer] Name based virtual doc

In the document it is written
Name based virtual hosting: Currently undocumented but possible via annotations.

How can we define the Host field ?

@talset like this:
kubectl annotate svc <your svc name>  "serviceloadbalancer/lb.host=www.domain.com"

oh serviceloadbalancer/lb.host not just "host" ! Thanks @aledbf . I will try.
Maybe you should add that just below the sentence (or I can summit a PR if you want) ?


Add support for OpenShift Pipelines v1.8

Add overlay for OpenShift Pipelines v1.8

LGTM.  Thanks!


Expose Entity Registration Conversation Options

Proposed change
This deserializes the options and conversation fields from the entity registry.  I have limited data there (only Assist, no Alexa/GA), so I started with the field that was most relevant to my needs, but could easily be expanded if someone wants to provide a sample containing Alexa/Google Assistant settings.
Type of change

[ ] Dependency upgrade
[ ] Bugfix (non-breaking change which fixes an issue)
[X] New feature (which adds functionality to an existing integration)
[ ] Breaking change (fix/feature causing existing functionality to break)
[ ] Code quality improvements to existing code or addition of tests

Additional information
Checklist

[X] The code change is tested and works locally.
[X] Local tests pass. Your PR cannot be merged unless tests pass
[X] The code compiles without warnings (code quality check)
[X] Tests have been added to verify that the new code works.

If user exposed functionality or configuration are added/changed:

[ ] Documentation added/updated for http://netdaemon.xtz

I can't seem to edit the labels now, but this should be an enhancement

I can't seem to edit the labels now, but this should be an enhancement

I fixed that but the CI still seem to fail. Please investigate.

Cleaned up the coverage and fixed the tests, should be good to go.


how to solve this error?

I am trying to benchmark my GPU, but I have some problem:
terminate called after throwing an instance of 'std::runtime_error'
what():  CUDNN failure: CUDNN_STATUS_NOT_INITIALIZED in cudnn_helper.h at line: 32
This is full text of my situation.
root@fe903e806138:/DeepBench/code/bin# ls
conv_bench  gemm_bench  nccl_mpi_all_reduce  nccl_single_all_reduce  rnn_bench
root@fe903e806138:/DeepBench/code/bin# ./conv_bench
Times
w      h      c      n      k      r      s    pad_w  pad_h    stride_w  stride_h    fwd_time (usec)  bwd_inputs_time (usec)  bwd_params_time (usec)  total_time (usec)   fwd_algo
terminate called after throwing an instance of 'std::runtime_error'
what():  CUDNN failure: CUDNN_STATUS_NOT_INITIALIZED in cudnn_helper.h at line: 32
Aborted (core dumped)
root@fe903e806138:/DeepBench/code/bin# ^C
root@fe903e806138:/DeepBench/code/bin# ./rnn_bench
terminate called after throwing an instance of 'std::runtime_error'
what():  CUDNN failure: CUDNN_STATUS_NOT_INITIALIZED in rnn_bench.cu at line: 254
Aborted (core dumped)
root@fe903e806138:/DeepBench/code/bin#
if you have any solution, please tell me.

This error typically means that the system is not setup correctly. Based on past experience, I would suggest running some cuda utilities to ensure that the GPU is setup correctly and a context can be established on it. I would recommend looking at the deviceQuery and bandwidthTest samples in the samples/1_Utilities directory in the cuda install.


Refactor Entity Class

Closes #4541

No i cant sorry, would you like to explain how to sort it out?

No i cant sorry, would you like to explain how to sort it out?

I see your fork's develop branch is 12 commits behind the base branch. While your PR branch is 11 commits behind.
You can do this in your IDE's terminal.

Determine the names of your remotes. git remote -v For example in my fork it is:

origin  https://github.com/paulbalandan/CodeIgniter4.git (fetch)
origin  https://github.com/paulbalandan/CodeIgniter4.git (push)
upstream        https://github.com/codeigniter4/CodeIgniter4.git (fetch)
upstream        https://github.com/codeigniter4/CodeIgniter4.git (push)

Go to your fork's develop branch. git checkout develop
Pull latest changes from CI4 repo. git pull upstream develop (just change the remote name to the name you used for CI4 remote)
Push the changes to your fork. git push origin develop
Go to your PR branch. git checkout refactor-entity.
Rebase PR against develop. git rebase develop. If there will be merge conflicts, just resolve them then use git rebase --continue.
Force push to your PR's remote. git push origin refactor-entity --force-with-lease


npx create-turbo@latest fails

What version of Turborepo are you using?
1.4.5
What package manager are you using / does the bug impact?
npm, Yarn v1
What operating system are you using?
Mac
Describe the Bug
When running npx create-turbo@latest folder-name it throws the following error:
➜  Documents npx create-turbo@latest raulmabe
npx: instaló 182 en 11.325s

>>> TURBOREPO

>>> Welcome to Turborepo! Let's get you set up with a new codebase.

? Which package manager do you want to use? npm

Aborting installation.
Unexpected error. Please report it as a bug:
TypeError: import_fs.default.cpSync is not a function
    at run (/Users/raulmateobeneyto/.npm/_npx/679/lib/node_modules/create-turbo/dist/index.js:319:21)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)

A new version of `create-turbo` is available!
You can update by running: yarn global add create-turbo

➜  Documents create-turbo --version
zsh: command not found: create-turbo
➜  Documents yarn global add create-turbo
yarn global v1.22.11
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 🔨  Building fresh packages...
success Installed<EMAIL_ADDRESS>with binaries:
      - create-turbo
✨  Done in 7.46s.
➜  Documents create-turbo raulmabe

>>> TURBOREPO

>>> Welcome to Turborepo! Let's get you set up with a new codebase.

? Which package manager do you want to use? yarn

Aborting installation.
Unexpected error. Please report it as a bug:
TypeError: import_fs.default.cpSync is not a function
    at run (/Users/raulmateobeneyto/.config/yarn/global/node_modules/create-turbo/dist/index.js:319:21)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)

A new version of `create-turbo` is available!
You can update by running: yarn global add create-turbo

Expected Behavior
npx create-turbo@latest to work out of the box...
To Reproduce
Just run the command.
yarn version: 1.22.11
npm version: 6.14.15

The fix is to upgrade to Node 16.

If anyone else is having the same issue, I just solved it by upgrading node version from 14 to 16.


Link to docs

Not necessarily like this, but please add a link to the full docs from the README, there's useful explanations in there.

You're welcome, look good so far!


Hello, i think the API version of rest in the doc (?api-version=2023-03-01) is invalid. When i try this, i have an error message.

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 88c4cfdc-7500-a303-86ae-7bef529754ae
Version Independent ID: eb7ba610-18cf-e39b-0ad1-fc763af7e320
Content: Configure schedule patching on Azure VMs to ensure business continuity in update management center (preview).
Content Source: articles/update-center/prerequsite-for-schedule-patching.md
Service: update-management-center
GitHub Login: @SnehaSudhirG
Microsoft Alias: sudhirsneha

@AKowsigan - Thank you for the feedback, awaiting confirmation from the Engineering team.

@AKowsigan - Thank you for your patience. Received confirmation from the Engg team that the API version is correct, however the http call must be PATCH instead of PUT.
The same has been updated in the docs:
https://learn.microsoft.com/en-us/azure/update-center/prerequsite-for-schedule-patching?tabs=new-prereq-rest-api%2Cauto-portal#enable-schedule-patching-on-azure-vms
https://learn.microsoft.com/en-us/azure/update-center/prerequsite-for-schedule-patching?tabs=new-prereq-rest-api%2Cauto-rest-api#enable-automatic-guest-vm-patching-on-azure-vms

#please-close


JIRAv2 initial PR

Most functionality ported from the hackathon branch
Atlassian-connect based user mapping flow
Many known functional and UX issues

@hanzei @crspeller @jasonblais I think I either fixed and submitted fixes, or filed separate tickets for all of the feedback. Please review, again.

@levb Looks like the build may be failing

@levb Looks like the build may be failing

@jasonblais it's expected, the test target is failing for many known reasons, and the lint target doesn't even exist I think. Will fix post-merge.


Support multiple attributes

This introduces multipartAttributes and multipartAttributesNel.

Codecov Report

Merging #872 into master will increase coverage by 0.45%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #872      +/-   ##
=========================================
+ Coverage   81.45%   81.9%   +0.45%
=========================================
  Files          51      51
  Lines         744     746       +2
  Branches       26      34       +8
=========================================
+ Hits          606     611       +5
+ Misses        138     135       -3

Impacted Files
Coverage Δ

...e/src/main/scala/io/finch/endpoint/multipart.scala
76.66% <100%> (-5.48%)
:arrow_down:

core/src/main/scala/io/finch/Input.scala
100% <0%> (+12.5%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac5fed4...3c62ad9. Read the comment docs.


ignore PyCharm project file

Thanks but see Global/JetBrains.gitignore

OH.... Thanks. but how can we select this when we create new repository?
Is this the only way that we download and add it to our project?

You can't, but the idea is that with git those kind of rules belong in your global ignore list. Have a look at the gitignore man page.


Update versions on README

Codecov Report

Merging #418 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #418   +/-   ##
========================================
  Coverage    77.23%   77.23%
========================================
  Files           46       46
  Lines         1041     1041
  Branches        29       29
========================================
  Hits           804      804
  Misses         237      237

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87c5f93...2a4d564. Read the comment docs.


sdfg

Task Request

Work item

Title

Description

Requirements

Acceptance Criteria

dsafdsaf

hgfhgf

asdf

sdaf

fd

dsf

asdf

fasdf

fhgfhg

fasdf

sfdgg

asdfa

adsf

asdf

df

sdfds

dsf

dsaf


Python 3.7 support issue

generator is not in 3.7 so it is causing error

Also running into this issue

https://github.com/bretttolbert/verbecc
Used this package instead - I just needed the conjugation features of pattern. Verbecc also has conjugation of phrasal verbs (e.g. "had been") which is more useful for my application.

See also #62
Bounty here: https://github.com/clips/pattern/issues/62#issuecomment-391473725

Found the same issue here. Saved me reporting it ;-)


Update Spine version to 1.0.0-pre6 and Spine JS version to 0.14.1.

This PR updates Spine components, including web, to version 1.0.0-pre6.
The new version of Spine JS client is 0.14.1.

@armiol, PTAL.


Add Specs for Search Pipeline SearchResponseProcessors

What is the bug?
Coming from  https://github.com/opensearch-project/OpenSearch/issues/14800#issuecomment-2237118907
I need to add specs/test for two new search response processors.  However, non of the existing processors exist to serve as an example. A search for rerank has no code results.  Similarly for rename_field.
It does look like these used to be part of the smithy spec. but that code has been removed.
It looks like the request processors are included in https://github.com/opensearch-project/opensearch-api-specification/blob/main/spec/schemas/search_pipeline._common.yaml but I don't see any of the response types there

this may be a typo

Do you have any additional context?
The PRs for the two new processor types are targeted for 2.16.0 release.
I don't have the bandwidth to manually recreate all the response processors prior to 2.16.0 code freeze, and I'm hopeful automation already exists to translate them from the old Smithy specs.

What caused this
This was caused by a one typo in the old search_pipeline.smithy file:
list ResponseProcessorList {
    member: RequestProcessor
}

union ResponseProcessor was, therefore, never used anywhere. The built-in Smithy -> OpenAPI tool, as a result, also did not include it in the original OpenAPI file. This file was used to create the spec we see today. Hence, the typo was also carried over.
Note that this kind of errors will be caught by our new spec's linter that checks for unused schemas. 😃
How to fix it

Check out the last Smithy commit
Correct the typo in search_pipeline.smithy
Run ./gradlew build to generate a new OpenSearch.openapi.json. Check out this workflow for more details.
Compare the diff of the new OpenSearch.openapi.json with the old file.
Copy the diff into this spec (i.e. correcting the carried over typo)

Thanks for the instructions, @nhtruong!


Fix warnings

if it turns out that it doesn't actually build and I merged something that broke the master, :knife:

@neongreen lalka, fixi)))00)))


Defining the Archivable property on an instance causes binary serializer to write false for all other instances' Archivable properties

Minimal repro:
use rbx_dom_weak::{InstanceBuilder, WeakDom};

fn main() {
    let dom = WeakDom::new(InstanceBuilder::new("Folder").with_children([
        InstanceBuilder::new("Folder").with_property("Archivable", true),
        InstanceBuilder::new("Folder"),
    ]));

    let file = std::fs::File::create("weird-archivable.rbxm").unwrap();
    rbx_binary::to_writer(file, &dom, &[dom.root_ref()]).unwrap()
}

Output of rbx-util view-binary weird-archivable.rbxm:
---
num_types: 1
num_instances: 3
chunks:
  - Inst:
      type_id: 0
      type_name: Folder
      object_format: 0
      referents:
        - 0
        - 1
        - 2
  - Prop:
      type_id: 0
      prop_name: archivable
      prop_type: Bool
      values:
        - false
        - true
        - false
  - Prop:
      type_id: 0
      prop_name: Name
      prop_type: String
      values:
        - Folder
        - Folder
        - Folder
  - Prnt:
      version: 0
      links:
        - - 2
          - 0
        - - 1
          - 0
        - - 0
          - -1
  - End

There are several things aligning that cause this and make it problematic:

The reflection database is missing default values for Instance.Archivable. This is because Roblox Studio never writes this property, meaning rbx-reflector cannot discover its default value.
Because the reflection database is missing default values for Instance.Archivable, the binary serializer writes the boolean fallback default (which is false) for instances that are missing the Archivable property.
rbx-dom serializes Instance.Archivable asInstance.archivable.
Roblox Studio does not load Instance.Archivable, but does load Instance.archivable. This means all the instances with Instance.archivable == false will in fact be loaded that way in Roblox Studio, and thus will not be saved when publishing to Roblox or when playtesting.

I thought of a few different ways we could solve this:

Don't serialize Instance.Archivable as Instance.archivable. This would still exhibit similar behavior, but since Roblox Studio does not load Instance.Archivable it wouldn't cause problems. The drawbacks are that it would be impossible to serialize an instance that has Archivable == false and have Roblox Studio load the property, and it would still be possible to define Instance.archivable and run into the same problematic behavior. Not a great option.
Allow rbx-reflector patches to define default values for properties, and patch in a default value for Instance.Archivable. No drawbacks that I can see, besides the burdens of implementation and maintenance.
Never serialize archivable properties. This would bring us mostly in line with Roblox's behavior, but it would be impossible to serialize an instance that has Archivable == false and have Roblox Studio load the property, which may be useful when users do not want to save test scripts or other instances that are unnecessary outside of development (here's an example in the wild: https://github.com/Aloroid/gorp/blob/main/src/stories/init.meta.json).

It seems like the only way that totally avoids breakage is 2.

We probably don't want to serialize Archivable to begin with, but I don't want to mark properties unnecessarily as non-serializable, so 2 is the best option IMO.
I think the idea of Roblox deserializing Instance.archivable is really funny though. Under what circumstances would that even come up, ha ha?

After giving this a shot, I've ran into a minor hiccup: the way we handle default properties is per-class right now. This means that in order to override a default for an abstract class like Instance, we'd need to override it for every class that inherits from it. That's a much bigger change than I was hoping for due to the nature of Instance.
I don't really have any good ideas to fix this. I have no problem cascading patches down to every inherited class, but it would mean we'd need to be careful with new patches to Instance's defaults since every one would result in a rather large addition to the database.

It is a little weird how we do that... maybe instead of adding the default value patches to all subclasses, we could change the way rbx_binary's serializer finds default properties? e.g., replace this:
https://github.com/rojo-rbx/rbx-dom/blob/f6007d561bcde2d120922cec818c0765a00ec460/rbx_binary/src/serializer/state.rs#L401-L403
with a call to a function like:
    fn find_default_value(
        database: &'db ReflectionDatabase,
        mut class: &'db ClassDescriptor<'db>,
        canonical_property_name: &str,
    ) -> Option<&'db Variant> {
        loop {
            match class.default_properties.get(canonical_property_name) {
                None => {
                    class = database
                        .classes
                        .get(class.superclass.as_deref()?)
                        .expect("superclass that is Some should exist in reflection database")
                }
                default_value => return default_value,
            }
        }
    }

We wouldn't have to move any existing defaults if we did this (although it's probably a good idea to do so in the future), but it would work with the obvious implementation of property default value patches

Downside: more overhead for inherited properties (assuming we eventually do move default property values into their respective classes), since this does multiple hashmap lookups for each inherited property


May you present a demo for walls doors windows custom usage?

Apologies for the delayed response. Walls and doors can be visualized using the exact same pattern used for CapturedRoom.Object instances. Specifically, you'll

Update room object replicator to accept CapturedRoom.Surface instances.
Map these surfaces to a new RoomSurfaceAnchor ARAnchor subclasses.
For each RoomSurfaceAnchor  in the session, create a new RoomSurfaceEntity, which can have a model component to visualize the surface.


Downloaded bible

next and previous arrow not working

Testing done and found some issues with offline bible
Steps to track the issue:
1.Download any bible
2.switch off the internet
3. There only one book will show for the downloaded bibles (Book which was open while downloading the bible)
even for that book  verse list is not available

https://user-images.githubusercontent.com/102143707/229765020-aea82c63-c6c3-4571-a058-3a53a1452d41.mp4
Here am attaching the screen recording for the reference .
second case : If the internet is on after downloading the bible

Download any bible
for the particular book ( which was open while downloading the bible) , backward arrow is missing , but user can change book from the drowdown.

Moving this issue back to in-progress

Testing completed and verified that this issue is fixed . Thus moving this issue to done.


Fix breaking changes to parameter names

@pjorg could you please merge this and tag a new release. Without this patch, the module is broken.

Thank you! and Thanks for inviting me!


[Bug Report] I have this error

Same here, fails to play most songs now. Some do still work but it's spotty.

Duplicate of #531


Duplicate transactions submitted

This may be a bug in the rpc.rs module, or in the relay_path.rs logic.
Two separate relayer operators reported it:

two same txn in one block:
https://www.mintscan.io/iris/txs/F388151AF2817A8B3F6948455D80E914B7D0459C4D28960D36694378C910D047
https://www.mintscan.io/iris/txs/1E8C05E7D77A864018AFC6154C7C07DBDA003F723526A2B9F6A70C831A7AE003

it's normal situation?

Originally posted by @dualsystems in https://github.com/informalsystems/ibc-rs/issues/1608#issuecomment-987389966

From a Telegram group:

Any idea why we are relaying same transaction twice?
https://www.mintscan.io/comdex/txs/A5129724DBE2BCFD87BF02CFB1ED01BE21D1BD67B73DD4E640881C34D50AC14E
https://www.mintscan.io/comdex/txs/5315E04F87880471CDFE49FF1071431D48CCC3232BEF4648F2AEE655BE62BFE0

It's unclear how to replicate this, so some Hermes logs would be useful in debugging. If any relayer operator is open to sharing their logs with us, we would be grateful!

Here is the logs around the event on Cros-nest's relayer.
We are running Hermes with INFO log level
hermes.log

This is not a bug. It's the same as JUNO chain. One of the transactions is a "no-op". In mintscan it shows both as "success", but only one of them actually executed.


Fix docs: splitting can introduce a hyphen

Just a small typo I found while reviewing this for cargo-crev.

Hi @Minoru, thanks for the PR. Can you explain more why you want to remove hyphen from the docstring?

AppVeyor failure is not related to my change, BTW.


Fix wrong descriptions for scripts

As discussed as PR.

Please do not mention the image name inside the script, most script are not limited to blacklabelops/jenkins


Make docs build from gh_pages

Also add github actions to automatically deploy versions when :

Pushing to main
Releasing a new version


Fix YARN managed mode sample

The sample provided in README.md is obsolete (use the wrong version name
on the jar) and does not include the full HDFS URL, which would eventually
make the YARN application failing.

Hello @csliu, could you help to review this PR?


Release 0.2.0

Gonna wait a couple of days, but there probably aren't really any (more) features to add and this brings us up to the new Kotlin version.

Ok, I think we're ready here...

Completed, I will update README and tag when Maven Central is updated.


[Bug] Some Token don't have a minus button ("-") for Wounds, Fatigue and/or Power Points

After updating to v0.7.3 I didn't see the "-" button for Wounds, Fatigue and/or Power Points for some tokens. The status is always the same for a specific token. F.e. my cleric never sees the "-" for Wounds, Fatigue and Power Points:

While my sorcerer has the "+" / "-" buttons for Power Points and misses them only for Wounds & Fatigue:

Token Action HUD Core: 1.4.11
Token Action HUD SWADE: 0.7.3 (I reseted the Token Action HUD via the "Reset HUD" option after updating to 0.7.3)
Swade System: 3.0.4
Foundry VTT: 11.304
Browser: Google Chrome

Hi @Vogliadicone , the powerpoint one is odd.. the fatigue and wounds, since the current value is 0, it will not show the button, as soon as you change to a number bigger than 0, it will show.

I just saw the error. fix will be available soon.

v0.7.4


Verify signature not working in code using signature generated from openssl command line

OpenSSL version: OpenSSL 1.1.1f  31 Mar 2020
MacOs Catalina 10.15.2
Hi
I'm trying to create a binding from the Crystal programming language to the C API for openssl. It has 3 parts:

generate public and private keypair using secp256k1 curve
sign a message that is the sha256 of the message content
verify the signature created by the signing

At them moment - I can generate the keypair, sign and verify using the code I've written.
But the problem is that if I use any other tool to sign then my code doesn't verify the signature and also a signature generated by my code cannot be verfied by any other tools. When I say other tools I mean e.g. openssl command line, javascript libraries such as elliptic etc
I would like my code to be able to sign and verify in a way that is compatible with the openssl command line and the popular javascript library elliptic.
I can successfully generate a signature on the command line using openssl which is successfully verified in the javascript library elliptic
So I guess my code is not doing something that the openssl command line or the javascript libraries are doing. I would be grateful if someone could point me in the right direction.
Here is the code I have for sign and verify and generation.
example usage is:
  sign(my_hex_private_key, sha256_string) # returns the r,s of the signature as hex
  verify(my_hex_public_key, sha256_string, hex_r, hex_s) # returns true or false

 # Signs a message with a private key
  def self.sign(hex_private_key : String, message : String)
    # Create a EC key structure, setting the group type from NID
    eccgrp_id = LibECCrypto.OBJ_txt2nid("secp256k1")
    raise "Error could not set EC group" unless eccgrp_id != 0
    myecc = LibECCrypto.EC_KEY_new_by_curve_name(eccgrp_id)
    raise "Error could not create curve" if myecc.null?

    # set signing algo - do I need this?
    # LibECCrypto.EC_KEY_set_asn1_flag(myecc, 1)

    # convert hex private key to binary
    bn = LibECCrypto.BN_new
    raise "Error could not create a new bn" if bn.null?
    binary_private_key = LibECCrypto.BN_hex2bn(pointerof(bn), hex_private_key)
    raise "Error private key binary is wrong size" if binary_private_key != 64

    # add binary private key to EC structure
    set_key = LibECCrypto.EC_KEY_set_private_key(myecc, bn)
    raise "Error could not set private key to EC" unless set_key == 1

    # sign
    sign_pointer = LibECCrypto.ECDSA_do_sign(message, message.bytesize, myecc)
    raise "Error could not sign message with key" if sign_pointer.null?

    # get the r,s from the signing
    sign_value = sign_pointer.value
    r_hex = LibECCrypto.BN_bn2hex(sign_value.r)
    s_hex = LibECCrypto.BN_bn2hex(sign_value.s)

    r = String.new(r_hex).downcase
    s = String.new(s_hex).downcase

    # Free up mem
    LibECCrypto.EC_KEY_free(myecc)
    # LibECCrypto.BN_clear_free(bn)
    LibECCrypto.ECDSA_SIG_free(sign_pointer)

    {
      r: r,
      s: s,
    }
  end

  # Verifies a signed message with a public key and the signature
  def self.verify(hex_public_key : String, message : String, r : String, s : String)
    # Create a EC key structure, setting the group type from NID
    eccgrp_id = LibECCrypto.OBJ_txt2nid("secp256k1")
    raise "Error could not set EC group" unless eccgrp_id != 0
    myecc = LibECCrypto.EC_KEY_new_by_curve_name(eccgrp_id)
    raise "Error could not create curve" if myecc.null?

    LibECCrypto.EC_KEY_set_asn1_flag(myecc, 0)

    # convert binary public key to point
    eccgrp = LibECCrypto.EC_GROUP_new_by_curve_name(eccgrp_id)
    raise "Error could not get the group curve" if eccgrp.null?
    ec_point = LibECCrypto.EC_POINT_new(eccgrp)
    raise "Error could not create point from group" if ec_point.null?

    point_res = LibECCrypto.EC_POINT_hex2point(eccgrp, hex_public_key.to_unsafe, ec_point, nil)
    raise "Error could not get point from public key" if point_res.null?

    # set the public key on the EC structure
    set_key = LibECCrypto.EC_KEY_set_public_key(myecc, ec_point)
    raise "Error could not set public key to EC" unless set_key == 1

    # convert r,s hex to bn
    r_bn = LibECCrypto.BN_new
    raise "Error could not create a new bn for r" if r_bn.null?
    LibECCrypto.BN_hex2bn(pointerof(r_bn), r)

    s_bn = LibECCrypto.BN_new
    raise "Error could not create a new bn for s" if s_bn.null?
    LibECCrypto.BN_hex2bn(pointerof(s_bn), s)

    # set r,s onto signature
    sig = LibECCrypto::ECDSA_SIG_Struct_setter.new
    sig.r = r_bn
    sig.s = s_bn

    # verify
    result = LibECCrypto.ECDSA_do_verify(message, message.bytesize, pointerof(sig), myecc)

    # Free up mem
    LibECCrypto.EC_KEY_free(myecc)
    LibECCrypto.EC_POINT_free(ec_point)
    LibECCrypto.BN_clear_free(r_bn)
    LibECCrypto.BN_clear_free(s_bn)

    result == 1
  end

# Creates a Key Pair
  def self.create_key_pair
    # Create a EC key structure, setting the group type from NID
    eccgrp_id = LibECCrypto.OBJ_txt2nid("secp256k1")
    raise "Error could not set EC group" unless eccgrp_id != 0
    myecc = LibECCrypto.EC_KEY_new_by_curve_name(eccgrp_id)
    raise "Error could not create curve" if myecc.null?

    # Create the public/private EC key pair
    gen_res = LibECCrypto.EC_KEY_generate_key(myecc)
    raise "Error could not generate an EC public/private key pair" unless gen_res == 1

    #  Get the private key
    bn = LibECCrypto.EC_KEY_get0_private_key(myecc)
    raise "Error could not get the private key" if bn.null?
    private_key_pointer = LibECCrypto.BN_bn2hex(bn)
    raise "Error could not get the private key pointer" if private_key_pointer.null?
    private_key = String.new(private_key_pointer).downcase

    # Get the public key
    ec_point = LibECCrypto.EC_KEY_get0_public_key(myecc)
    raise "Error could not get the public key" if ec_point.null?
    form = LibECCrypto::PointConversionFormT::PointConversionUncompressed
    eccgrp = LibECCrypto.EC_GROUP_new_by_curve_name(eccgrp_id)
    raise "Error could not get the group curve" if eccgrp.null?
    public_key_pointer = LibECCrypto.EC_POINT_point2hex(eccgrp, ec_point, form, nil)
    raise "Error could not get the public key pointer" if public_key_pointer.null?
    public_key = String.new(public_key_pointer).downcase

    # Free up mem
    LibECCrypto.EC_KEY_free(myecc)
    LibECCrypto.EC_GROUP_free(eccgrp)

    return create_key_pair if private_key.hexbytes? == nil || private_key.size != 64
    return create_key_pair if public_key.hexbytes? == nil || public_key.size != 130

    {
      hex_private_key: private_key,
      hex_public_key:  public_key,
    }
  end

  def self.sha256(base : Bytes | String) : String
    hash = OpenSSL::Digest.new("SHA256")
    hash.update(base)
    hash.hexdigest
  end

Marking as inactive, to be closed at the end of 3.4 dev barring further input


Occasionally the boxes become unclickable

I wish I had more information to help troubleshoot, but I can't reliably make it happen. In Chrome on Windows, occasionally clicking the box does nothing. Sometimes clicking several times will eventually get it to work, and other times I have to reload the page completely to get it to check off.

Actually, the issue appears to be that sometimes it takes a double-click to check the box, and other times a single click will work. Still haven't figured out how to force it to go one way or the other.

I think I experienced something similar early on, and it's probably related to react-native-web handling mouse events in a custom way. If I'm right, the click event doesn't register if you move the mouse (even 1-2 pixels) between mouse down and mouse up. If you're steady it seems to work consistently.


Doesn't work as of 0.6.6

Hi Toni
With Group Roll enabled; Pressing Roll NPC's or Roll All does nothing.
I've tested this with no other modules active and have same result.
Cheers,
Mick

Works perfectly fine for me on 0.6.6.
Is quite broken on 0.7.3 (and likely 0.7.x in general).


Esc+- followed by backspace generates AssertionError

While using iPython 5, I got the below exception when I pressed Esc+- (which showed "Repeat: -1") and then pressed backspace:
Traceback (most recent call last):
  File "/Users/hdara/bin/python/bin/ipython", line 11, in <module>
    sys.exit(start_ipython())
  File "/Users/hdara/bin/python/lib/python2.7/site-packages/IPython/__init__.py", line 119, in start_ipython
    return launch_new_instance(argv=argv, **kwargs)
  File "/Users/hdara/bin/python/lib/python2.7/site-packages/traitlets/config/application.py", line 596, in launch_instance
    app.start()
  File "/Users/hdara/bin/python/lib/python2.7/site-packages/IPython/terminal/ipapp.py", line 348, in start
    self.shell.mainloop()
  File "/Users/hdara/bin/python/lib/python2.7/site-packages/IPython/terminal/interactiveshell.py", line 402, in mainloop
    self.interact()
  File "/Users/hdara/bin/python/lib/python2.7/site-packages/IPython/terminal/interactiveshell.py", line 385, in interact
    code = self.prompt_for_code()
  File "/Users/hdara/bin/python/lib/python2.7/site-packages/IPython/terminal/interactiveshell.py", line 321, in prompt_for_code
    pre_run=self.pre_prompt, reset_current_buffer=True)
  File "/Users/hdara/src/python-prompt-toolkit/prompt_toolkit/interface.py", line 389, in run
    self.eventloop.run(self.input, self.create_eventloop_callbacks())
  File "/Users/hdara/src/python-prompt-toolkit/prompt_toolkit/eventloop/posix.py", line 154, in run
    t()
  File "/Users/hdara/src/python-prompt-toolkit/prompt_toolkit/eventloop/posix.py", line 82, in read_from_stdin
    inputstream.feed(data)
  File "/Users/hdara/src/python-prompt-toolkit/prompt_toolkit/terminal/vt100_input.py", line 380, in feed
    self._input_parser.send(c)
  File "/Users/hdara/src/python-prompt-toolkit/prompt_toolkit/terminal/vt100_input.py", line 299, in _input_parser_generator
    self._call_handler(match, prefix)
  File "/Users/hdara/src/python-prompt-toolkit/prompt_toolkit/terminal/vt100_input.py", line 332, in _call_handler
    self.feed_key_callback(KeyPress(key, insert_text))
  File "/Users/hdara/src/python-prompt-toolkit/prompt_toolkit/interface.py", line 1012, in feed_key
    cli.input_processor.process_keys()
  File "/Users/hdara/src/python-prompt-toolkit/prompt_toolkit/key_binding/input_processor.py", line 201, in process_keys
    self._process_coroutine.send(key_press)
  File "/Users/hdara/src/python-prompt-toolkit/prompt_toolkit/key_binding/input_processor.py", line 158, in _process
    self._call_handler(matches[-1], key_sequence=buffer)
  File "/Users/hdara/src/python-prompt-toolkit/prompt_toolkit/key_binding/input_processor.py", line 228, in _call_handler
    handler.call(event)
  File "/Users/hdara/src/python-prompt-toolkit/prompt_toolkit/key_binding/registry.py", line 31, in call
    return self.handler(event)
  File "/Users/hdara/src/python-prompt-toolkit/prompt_toolkit/key_binding/bindings/basic.py", line 261, in _
    deleted = event.current_buffer.delete_before_cursor(count=event.arg)
  File "/Users/hdara/src/python-prompt-toolkit/prompt_toolkit/buffer.py", line 568, in delete_before_cursor
    assert count >= 0
AssertionError

I am assuming this is not an iPython bug, but otherwise please let me know and I will close this and open one with iPython.

This is definitely a prompt-toolkit bug! Thanks a lot for reporting, this has to be fixed asap.

This has been fixed: https://github.com/jonathanslenders/python-prompt-toolkit/commit/bd5a2dbe2e539a826aebe661a73ada0531ff36ea
However, the behaviour is apparently not yet exactly the same like readline. This needs to be improved.

Yes, this change fixed the issue.
As for not behaving exactly like readline, I just read that M-- C-k should kill text back to the start of the line, so I just filed issue #347.

#347 has been fixed, so I close this one. Feel free to open again, if I'm missing something!


Add performance counters

Add default performance counters.
Test for retrieving the default performance counters.

Getting much better! Good progress


Make /noinfer by the default option

I am not sure if there are users that invoke Boogie without using /noinfer. I've never managed to successfully leverage any of the abstract interpretation algorithms that are build into Boogie. So I think we should make /noinfer be the default behavior. If that is already the case, it might be good to document that.
Thoughts?

In my work on CIVL, I found that sometimes abstract interpretation figures out simple loop invariants when iterating over arrays, which are needed to prove the core invariant.
i := 0;
while(i < n)
invariant 0 <= i && i <= n; // For example this one.
{
  ...
  i := i + 1;
}

But we actually always strive to have our examples verified with /noinfer.

Got it. To me this also says that /noinfer should probably be the default setting.

I am supportive of /noinfer being the default, especially because sometimes inference takes a long time when a significant amount of inlining has been done.
@zvonimir : Please put up a PR.
@RustanLeino : Heads up.

So the idea is that option /noinfer will be removed, and no abstract interpretation is performed unless requested with /infer, right?

Yep, that is my take on this. I got busy with Corral and so I won't be able to get to this today.

@rospoly This is a good first issue to try to resolve as you are learning Boogie.

I'd also like this to be the default behaviour - we specify it from all of our tools (and typically teach students to do it when they're new to using Boogie).

I'm late to the party. Dafny always uses -infer:j. But Dafny can turn this mode on explicitly.


Ambitious Plans - AI

Some form of AI to determine whether news stories (fetched from a source - eg, BBC), are "good" or "bad".
Anything that it thinks is "bad" to be sent as an automatic PR, anything it thinks is good is ignored, and anything it is unsure about gets sent as an Issue.
The system learns based on "closed" issues, what is good and what is bad.
If an issue is updated with a label, then a PR is made and the system learns that it is "bad"

Very ambitious. I know nothing about AI yet.


[Improvement] Only clear notification after reminder has been postponed

Currently when choosing to postpone a reminder from a notification, the notification is immediately removed. When a user cancels the postponement process, the notification is gone even though it hasn't been postponed.
With the changes in this PR a notification will only be dismissed after the postponement process finished successfully. This makes much more sense in my opinion.

Thanks.


Bug:  on_body_entered is called 4 times

Tested versions
4.2.1 - stable
System information
Windows 11
Issue description
Hello, my Game suddenly wont work. I work on a project and all my collisions are called 4 times  simoultaneously? + the timeout doesnt work anymore.
Please Help!!
Steps to reproduce
idk
Minimal reproduction project (MRP)
export_presets.zip

Hi,
This platform is for clearly identified bug reports, not for helping users find bugs in their own code.
Please use other community platforms like the Godot Forum for this, where fellow Godot users can help you find where is the mistake. If it's eventually identified as an engine bug, then you can open a bug report.


Add Wireshark

Add support for Wireshark

Only .exe downloads are reported, but MSIs are available and preferred by many - Winget returns this:
https://www.wireshark.org/download/win64/all-versions/Wireshark-win64-3.4.5.msi
I see the feed XML only lists the exe though. Was this grabbed by watching the app try to auto-update? Maybe the MSI release queries a different feed?!

Yeah, Fiddler to see what Wireshark is doing when checking for updates. MSIs are also here, so I can add to the output:
https://1.na.dl.wireshark.org/win64/Wireshark-win64-3.4.5.exe

I wonder if you could use Wireshark for this instead of Fiddler!

I've tested this - the MSI auto updates to the EXE based installer!
If you'd like the function to output both types, the easiest way seems to be to just change the file extension to msi and the resulting URL works.

Added in 5a6c1a8a44dec82d42c558855f5047f56e8f81dc


Unstructured multisearch response

When calling the multisearch API I was expecting the result to be structured and be able to cast individual response items to MultiSearchItem.
Instead I'm getting a raw map for each. I believe the top-level Response type for that endpoint is missing an unmarshal helper to parse the response body: https://github.com/elastic/go-elasticsearch/blob/19b7047994ef03b78c0a8bc18c5c509dee188d3d/typedapi/core/msearch/response.go.

Fixed in the aforementioned PR, this will be part of the next release!


New all-white tray icon difficult to see on light taskbar

From @chowbok on August 7, 2018 18:41
I have a light-grey taskbar. The new white tray icon in 2.12.0 is nearly impossible to see on there. Can it be made to have a black outline so that it's visible regardless of one's color scheme?
Copied from original issue: RocketChat/Rocket.Chat#11695

From @kaiiiiiiiii on August 7, 2018 18:56
Wrong repository mate :)
Fix which should be pushed with the next release:
https://github.com/RocketChat/Rocket.Chat.Electron/pull/791
// CC: @TwizzyDizzy

From @chowbok on August 7, 2018 19:3
Sorry about that. This is where the app sent me when I selected "report an issue" from the menu. I'm on Linux, by the way. Guess I should have mentioned that, sorry.

@chowbok can you please share a screenshot so we can see how it looks and how other icons are being rendered too?

Since I guess I have the same issue.

Ok, we will add a shadow

I think on windows a colored Logo is more commo

Even on windows 10?

Or we can add an option for people to choose from BW or Colored

On Windows 10 there are some in color and some in white.
I think also that we need a switch to toggle the icon colors (also for the osx menu bar)


"ionic run ios" with multiple developer accounts

When xCode is configured with more than one developer account, ionic seems to use the first account in the list to sign, which causes problems because my apps provisioning profile is from the second account.
Has anyone else found a similar situation, and found a work around for it?
Is there an option for "ionic run ios" that lets me specify which identity / provisioning profile to use?
The docs (https://github.com/driftyco/ionic-cli/blob/master/README.md) seem a bit sparse to me, have I not found a more in-depth document?
Thanks in advance,
Hud

Not sure I've really seen this before.
The ionic run ios commands relies on Cordova, which is really going to handle running the iOS build/xcrun processes based on your xcode project.
What you could do is open your xcode project that cordova generates, go into your information about your app, and selected the identity/profile to use.
Then when you run ionic run ios, it will execute the profile that you just specified. Let me know if that works.


Unhandled Exception: [WinError 267] Directory name invalid

[01/Mar/2018 17:38:49] ** Welcome to SafariBooks! **
[01/Mar/2018 17:38:49] Logging into Safari Books Online...
[01/Mar/2018 17:38:53] Retrieving book info...
[01/Mar/2018 17:38:55] Title: Revive: How to Transform Traditional Businesses into Digital Leaders
[01/Mar/2018 17:38:55] Authors: Brian Manning, Jason Albanese
[01/Mar/2018 17:38:55] Identifier:<PHONE_NUMBER>626
[01/Mar/2018 17:38:55] ISBN:<PHONE_NUMBER>626
[01/Mar/2018 17:38:55] Publishers: PH Professional Business
[01/Mar/2018 17:38:55] Description: GAME-CHANGING DIGITAL TRANSFORMATION:USE DIGITAL STRATEGIES, CHANNELS, AND PLATFORMS TO TRANSFORM ENTERPRISES TO COMPETE IN THE DIGITAL AGE Move from “reactive digital” to “transformative digital”  Use digital capabilities to fundamentally change the way you lead, direct, and structure organizations and teams  Stay focused on the “moving target” of digital best practices, and accelerate your progress towards digital maturity REVIVE will help you build a core business model for creating your own ...
[01/Mar/2018 17:38:55] Release Date: 2015-11-17
[01/Mar/2018 17:38:55] URL: https://www.safaribooksonline.com/library/view/revive-how-to/9780134307626/
[01/Mar/2018 17:38:55] Retrieving book chapters...
[01/Mar/2018 17:39:01]   File "safaribooks.py", line 992, in
SafariBooks(args_parsed)
File "safaribooks.py", line 305, in init
self.create_dirs()
File "safaribooks.py", line 671, in create_dirs
os.makedirs(self.BOOK_PATH)
File "C:\apps\Python\Python36\lib\os.py", line 220, in makedirs
mkdir(name, mode)
[01/Mar/2018 17:39:01] Unhandled Exception: [WinError 267] Directory name invalid : 'D:\books\safaribooks\Books\Revive: How to Transform Traditional Businesses into Digital Leaders' (type: NotADirectoryError)
[01/Mar/2018 17:39:01] Last request done:
URL: https://www.safaribooksonline.com/api/v1/book/9780134307626/chapter/?page=3
DATA: None
OTHERS: {}
200
Server: nginx/1.10.3 (Ubuntu)
Content-Type: application/json
Content-Language: en-US
X-Frame-Options: SAMEORIGIN
x-content-type-options: nosniff
Allow: GET, HEAD, OPTIONS
strict-transport-security: max-age=3600; includeSubDomains, max-age=31536000; includeSubdomains
x-xss-protection: 1; mode=block
Content-Encoding: gzip
Cache-Control: s-maxage=1800
Content-Length: 770
Accept-Ranges: bytes
Date: Thu, 01 Mar 2018 09:39:01 GMT
Via: 1.1 varnish
Connection: keep-alive
X-Client-IP: <IP_ADDRESS>
X-Served-By: cache-hnd18738-HND
X-Cache: MISS
X-Cache-Hits: 0
X-Timer: S1519897141.881305,VS0,VE569
Vary: Accept, Accept-Language, Authorization, Cookie

{"count":21,"next":null,"previous":"https://www.safaribooksonline.com/api/v1/book/9780134307626/chapter/?page=2","results":[{"archive":"https://www.safaribooksonline.com/api/v1/book/9780134307626/","content":"https://www.safaribooksonline.com/api/v1/book/9780134307626/chapter-content/index.html","url":"https://www.safaribooksonline.com/api/v1/book/9780134307626/chapter/index.html","natural_key":["9780134307626","index.html"],"full_path":"index.html","minutes_required":19.549999999999997,"next_chapter":{"title":"","web_url":""},"previous_chapter":{"url":"https://www.safaribooksonline.com/api/v1/book/9780134307626/chapter/epilogue.html","title":"Epilogue. Examples of Digital Trends Accelerating the Digital Revolution","web_url":"https://www.safaribooksonline.com/library/view/revive-how-to/9780134307626/epilogue.html"},"stylesheets":[{"full_path":"9780134307626.css","url":"https://www.safaribooksonline.com/library/css/revive-how-to/9780134307626/9780134307626.css","original_url":"https://www.safaribooksonline.com/library/view/revive-how-to/9780134307626/9780134307626.css"}],"images":[],"asset_base_url":"https://www.safaribooksonline.com/library/view/revive-how-to/9780134307626/","web_url":"https://www.safaribooksonline.com/library/view/revive-how-to/9780134307626/index.html","last_position":null,"videoclips":[],"publisher_scripts":"","publisher_script_files":[],"allow_scripts":false,"videoclip":null,"academic_excluded":false,"subjects":[{"name":"Business","description":""},{"name":"Business Communication","description":""}],"authors":[{"name":"Brian Manning"},{"name":"Jason Albanese"}],"cover":"https://www.safaribooksonline.com/library/cover/9780134307626/","book_title":"Revive: How to Transform Traditional Businesses into Digital Leaders","updated":"2017-03-07T17:29:38.821287Z","site_styles":["https://www.safaribooksonline.com/static/CACHE/css/b8d25f1a9a05.css"],"created_time":"2015-12-02T20:01:17.163719Z","last_modified_time":"2015-12-02T20:01:22.960804Z","filename":"index.html","path":"","epub_properties":null,"head_extra":null,"has_video":false,"title":"Index","description":"","virtual_pages":17}]}

Some books have the same short book name on safaribooks.

I fixed this issue! Thanks again!
But I don't understand the last comment. What do you mean?

Some books have the same short book name on safaribooks.
For example,the following two books have the same short name: Stepping Up
https://www.safaribooksonline.com/library/view/stepping-up/9781292186887/
https://www.safaribooksonline.com/library/view/stepping-up/9781609940584/

Ok, with the last commit I fixed this problem.
Thanks for helping me!

def escape_dirname(dirname, clean_space=False):
if ":" in dirname:
if dirname.index(":") > 30:
dirname = dirname.split(":")[0]
    for ch in ['\\', '/', '<', '>', '`', '\'', '"', '*', '?', '|']:
        if ch in dirname:
            dirname = dirname.replace(ch, "")

    return dirname if not clean_space else dirname.replace(" ", "")

this Statement maybe wrong，not 30 but 0
if dirname.index(":") > 30:

I voluntarily put 30 because I want to split only long title.
Example: there is a book called "HTTP: The Definitive Guide". It's ok for me to display all the book title.
But I can say the same for a book like "Windows Internals, Part 1: System architecture, processes, threads, memory management, and more, Seventh Edition".
Maybe I have to reduce the range that I choose

Now is 15 chars

def escape_dirname(dirname, clean_space=False):
if ":" in dirname and dirname.index(":") > 15:
dirname = dirname.split(":")[0]
    for ch in ['\\', '/', '<', '>', '`', '\'', '"', '*', '?', '|']:
        if ch in dirname:
            dirname = dirname.replace(ch, "")

    return dirname if not clean_space else dirname.replace(" ", "")

Running on Windows system, dirname cannot include ":“.
for ch in ['\', '/', '<', '>', '`', ''', '"', '*', '?', '|', ':']:
if ch in dirname:
dirname = dirname.replace(ch, "")

I always use Linux, so I don't cover well the problems on Windows.
I updated the program adding this fix.


Add ability to reset transitions and times

We might want to do this for resetting in between transactions (for better state debugging)
Tested locally on the simulator, no crashy
@keyme/control-systems-engineers

LGTM


No Ni-Fi pipelines after successful ingestion

Affected module
I guess it is Ingestion Framework.
Describe the bug
I connected to ni-fi. Launched data ingestion. It was successful. But there is no pipelines.
Error logs during ingestion:
[2023-08-17T14:14:00.227+0000] {client.py:134} DEBUG - Traceback (most recent call last):
  File "/home/airflow/.local/lib/python3.9/site-packages/requests/models.py", line 971, in json
    return complexjson.loads(self.text, **kwargs)
  File "/usr/local/lib/python3.9/json/__init__.py", line 346, in loads
    return _default_decoder.decode(s)
  File "/usr/local/lib/python3.9/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/local/lib/python3.9/json/decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/home/airflow/.local/lib/python3.9/site-packages/metadata/ingestion/source/pipeline/nifi/client.py", line 126, in get
    return res.json()
  File "/home/airflow/.local/lib/python3.9/site-packages/requests/models.py", line 975, in json
    raise RequestsJSONDecodeError(e.msg, e.doc, e.pos)
requests.exceptions.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

To Reproduce

Expected behavior
I expected to see pipelines from ni-fi
Version:

OS: macOS 13.5, I launched OMD via docker local deployment https://docs.open-metadata.org/v1.0.0/quick-start/local-deployment
Python version: 3.9.5
OpenMetadata version: 1.1.1
OpenMetadata Ingestion package version: <IP_ADDRESS>
Ni-fi version: 1.15.3

Additional context
I tried with both authentications types.
Also checked ni-fi api via postman and it's OK

We just got the following message in support:
after the release of version 1.2.0, I attempted to connect Apache NiFi to OpenMetadata again, and it seems like I'm encountering the same errors as before. Here's the error output:
"                           [2023-11-08T14:38:15.958+0000] {test_connections.py:198} WARNING - GetPipelines-Expecting value: line 1 column 1 (char 0)
[2023-11-08T14:38:15.958+0000] {test_connections.py:215} INFO - Test connection results:
[2023-11-08T14:38:15.959+0000] {test_connections.py:216} INFO - failed=["'GetPipelines': This is a mandatory step and we won't be able to extract necessary metadata. Failed due to: Expecting value: line 1 column 1 (char 0)"] success=[] warning=[]
[2023-11-08T14:38:15.959+0000] {taskinstance.py:1824} ERROR - Task failed with exception
Traceback (most recent call last):
 File "/home/airflow/.local/lib/python3.9/site-packages/airflow/operators/python.py", line 181, in execute
 return_value = self.execute_callable()
 File "/home/airflow/.local/lib/python3.9/site-packages/airflow/operators/python.py", line 198, in execute_callable
 return self.python_callable(*self.op_args, **self.op_kwargs)
 File "/home/airflow/.local/lib/python3.9/site-packages/openmetadata_managed_apis/workflows/ingestion/common.py", line 201, in metadata_ingestion_workflow
 workflow = MetadataWorkflow.create(config)
 File "/home/airflow/.local/lib/python3.9/site-packages/metadata/workflow/base.py", line 218, in create
 return cls(config)
 File "/home/airflow/.local/lib/python3.9/site-packages/metadata/workflow/base.py", line 123, in __init__
 self.set_steps()
 File "/home/airflow/.local/lib/python3.9/site-packages/metadata/workflow/metadata.py", line 35, in set_steps
 self.source = self._get_source()
 File "/home/airflow/.local/lib/python3.9/site-packages/metadata/workflow/metadata.py", line 54, in _get_source
 source: Source = source_class.create(self.config.source.dict(), self.metadata)
 File "/home/airflow/.local/lib/python3.9/site-packages/metadata/ingestion/source/pipeline/nifi/metadata.py", line 91, in create
 return cls(config, metadata)
 File "/home/airflow/.local/lib/python3.9/site-packages/metadata/ingestion/source/pipeline/pipeline_service.py", line 137, in __init__
 self.test_connection()
 File "/home/airflow/.local/lib/python3.9/site-packages/metadata/ingestion/source/pipeline/pipeline_service.py", line 204, in test_connection
 test_connection_fn(self.metadata, self.connection_obj, self.service_connection)
 File "/home/airflow/.local/lib/python3.9/site-packages/metadata/ingestion/source/pipeline/nifi/connection.py", line 67, in test_connection
 test_connection_steps(
 File "/home/airflow/.local/lib/python3.9/site-packages/metadata/ingestion/connections/test_connections.py", line 265, in test_connection_steps
 return timeout(timeout_seconds)(_test_connection_steps)(
 File "/home/airflow/.local/lib/python3.9/site-packages/metadata/utils/timeout.py", line 54, in inner
 result = fn(*args, **kwargs)
 File "/home/airflow/.local/lib/python3.9/site-packages/metadata/ingestion/connections/test_connections.py", line 104, in _test_connection_steps
 _test_connection_steps_during_ingestion(steps=steps)
 File "/home/airflow/.local/lib/python3.9/site-packages/metadata/ingestion/connections/test_connections.py", line 219, in _test_connection_steps_during_ingestion
 raise SourceConnectionException(
metadata.ingestion.connections.test_connections.SourceConnectionException: Some steps failed when testing the connection: [failed=["'GetPipelines': This is a mandatory step and we won't be able to extract necessary metadata. Failed due to: Expecting value: line 1 column 1 (char 0)"] success=[] warning=[]]
[2023-11-08T14:38:15.964+0000] {taskinstance.py:1345} INFO - Marking task as FAILED. dag_id=tstt_metadata_DEOxeNDP, task_id=ingestion_task, execution_date=20231108T143814, start_date=20231108T143815, end_date=20231108T143815
[2023-11-08T14:38:15.964+0000] {common.py:278} INFO - Sending failed status from callback...
[2023-11-08T14:38:15.965+0000] {server_mixin.py:63} DEBUG - Validating client and server versions
[2023-11-08T14:38:15.968+0000] {common.py:284} INFO - Sending status to Ingestion Pipeline tstt.tstt_metadata_DEOxeNDP
[2023-11-08T14:38:15.984+0000] {ingestion_pipeline_mixin.py:51} DEBUG - Created Pipeline Status for pipeline tstt.tstt_metadata_DEOxeNDP: {'eventType': 'entityUpdated', 'entityType': 'ingestionPipeline', 'entityId': 'ca6850ed-e4dd-4c42-9cff-ccc16b9c3a33', 'entityFullyQualifiedName': 'tstt.tstt_metadata_DEOxeNDP', 'previousVersion': 0.2, 'currentVersion': 0.2, 'userName': 'admin', 'timestamp':<PHONE_NUMBER>983, 'changeDescription': {'fieldsAdded': [], 'fieldsUpdated': [{'name': 'pipelineStatus', 'oldValue': {'runId': '88d0151d-7fc4-4087-8af5-ab4111fd940b', 'pipelineState': 'running', 'startDate':<PHONE_NUMBER>234, 'timestamp':<PHONE_NUMBER>234}, 'newValue': {'runId': '88d0151d-7fc4-4087-8af5-ab4111fd940b', 'pipelineState': 'failed', 'startDate':<PHONE_NUMBER>234, 'timestamp':<PHONE_NUMBER>234, 'endDate':<PHONE_NUMBER>975}}], 'fieldsDeleted': [], 'previousVersion': 0.2}, 'entity': {'id': 'ca6850ed-e4dd-4c42-9cff-ccc16b9c3a33', 'name': 'tstt_metadata_DEOxeNDP', 'displayName': 'tstt_metadata_DEOxeNDP', 'pipelineType': 'metadata', 'fullyQualifiedName': 'tstt.tstt_metadata_DEOxeNDP', 'sourceConfig': {'config': {'type': 'PipelineMetadata', 'includeTags': True, 'includeOwners': True, 'includeLineage': True, 'markDeletedPipelines': True, 'pipelineFilterPattern': {'excludes': [], 'includes': []}}}, 'airflowConfig': {'pausePipeline': False, 'concurrency': 1, 'startDate':<PHONE_NUMBER>000, 'pipelineTimezone': 'UTC', 'retries': 0, 'retryDelay': 300, 'pipelineCatchup': False, 'scheduleInterval': '0 * * * *', 'maxActiveRuns': 1, 'workflowDefaultView': 'tree', 'workflowDefaultViewOrientation': 'LR'}, 'loggerLevel': 'DEBUG', 'deployed': True, 'enabled': True, 'href': 'http://openmetadata-server:8585/api/v1/services/ingestionPipelines/ca6850ed-e4dd-4c42-9cff-ccc16b9c3a33', 'version': 0.2, 'updatedAt':<PHONE_NUMBER>699, 'updatedBy': 'admin', 'changeDescription': {'fieldsAdded': [], 'fieldsUpdated': [{'name': 'deployed', 'oldValue': False, 'newValue': True}], 'fieldsDeleted': [], 'previousVersion': 0.1}, 'deleted': False, 'provider': 'user'}}
[2023-11-08T14:38:15.995+0000] {standard_task_runner.py:104} ERROR - Failed to execute job 158 for task ingestion_task (Some steps failed when testing the connection: [failed=["'GetPipelines': This is a mandatory step and we won't be able to extract necessary metadata. Failed due to: Expecting value: line 1 column 1 (char 0)"] success=[] warning=[]]; 40750)
[2023-11-08T14:38:16.005+0000] {local_task_job_runner.py:225} INFO - Task exited with return code 1
[2023-11-08T14:38:16.015+0000] {taskinstance.py:2653} INFO - 0 downstream tasks scheduled from follow-on schedule check

Not able to reproduce, we have added more troubleshooting section, proper error handling.
Make sure the creds are right, nifi policy created properly, and it should work. Thanks.
Closing this.
cc: @open-metadata/ingestion

@ayush-shah test connection is OK 🤔
However got the same error on 1.2.0

@mrkoloev can you check the policies? if there are no policies found, or there are any policy related permission issue, that it may cause that error.
ref: https://openmetadata.slack.com/archives/C02B6955S4S/p1699905381327759?thread_ts=1696598804.389129&cid=C02B6955S4S

https://community.cloudera.com/t5/Support-Questions/API-call-to-nifi-api-resources-results-in-quot-No-applicable/td-p/363534


[FLINK-27693][state] Support local recovery for non-materialized part

What is the purpose of the change
Support local recovery for the non-materialized part of changelog.
Brief change log

8cc0d2 add localConfig param
8f7f7dd write to double stream
ed4600 add local state registry to discard local changelog handle
8088f0 return local handle after snapshot

Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
This change added tests and can be verified as follows:

ChangelogLocalRecoveryITCase

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: ( no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (yes)
If yes, how is the feature documented? (JavaDocs)

Hi @rkhachatryan, I updated this PR to handle "the last checkpoint(s) aborted and then job terminated" case, and added LocalStateRegistryTest. Could you please take a look again?

Merged manually as 1f9632a07199854c0225bd7f416c038fbf59abe0..52eb7e76b5d66ff5c4d9d4af8a213b5b8f9f8322
(build succeeded after rebasing).


Fix pull errors related to files deleted remotely

In case files are deleted remotely, the files are now ignored during a pull. In other words, "pull" will not touch objects that exist only locally and not remotely.
To delete such objects locally, use "reset local (forced pull)" which will show a popup for these objects and let you delete them.
Closes #4277

@flaiker can you help testing this change?

Uhm, the abapmerge report created by CI isn't possibly saved as a build artifact somewhere right?

A kept a few older versions. Anyone in particular?

Oh the old ones are accessable somewhere in the build repo. I was talking about the one for this pr to repeat my test case of updating abapgit itself. I don't have an npm environment set up.

@flaiker the builds are now saved for each build, click details on the "build" step,

So my test case was:

Downgrade the development version to a commit from 6 months ago
Install the new standalone version from this PR build
Upgrade development version using standalone version
See if the messages appear again ("File not found. Import of object failed")

First of all after pull I got this (unrelated) error on activation:

I pressed activate anyway.
After activation finished I only got warning in the log. Surprisingly lots of warnings based on packages movements. Some were moved automatically on pull, some apparently were not.

Changed package assignment for object CLAS ZCL_ABAPGIT_CTS_API
Changed package assignment for object CLAS ZCL_ABAPGIT_DEFAULT_TRANSPORT
Changed package assignment for object CLAS ZCL_ABAPGIT_LONGTEXTS
Changed package assignment for object CLAS ZCL_ABAPGIT_OBJECT_ENHO_CLIF
Changed package assignment for object CLAS ZCL_ABAPGIT_OO_BASE
Changed package assignment for object CLAS ZCL_ABAPGIT_OO_CLASS
Changed package assignment for object CLAS ZCL_ABAPGIT_OO_FACTORY
Changed package assignment for object CLAS ZCL_ABAPGIT_OO_INTERFACE
Changed package assignment for object CLAS ZCL_ABAPGIT_OO_SERIALIZER
Changed package assignment for object CLAS ZCL_ABAPGIT_PR_ENUMERATOR
Changed package assignment for object CLAS ZCL_ABAPGIT_PR_ENUM_GITHUB
Changed package assignment for object CLAS ZCL_ABAPGIT_SOTR_HANDLER
Changed package assignment for object CLAS ZCL_ABAPGIT_TRANSPORT
Changed package assignment for object CLAS ZCL_ABAPGIT_TRANSPORT_2_BRANCH
Changed package assignment for object CLAS ZCL_ABAPGIT_TRANSPORT_MASS
Changed package assignment for object CLAS ZCL_ABAPGIT_TRANSPORT_OBJECTS
Changed package assignment for object INTF ZIF_ABAPGIT_CTS_API
Changed package assignment for object INTF ZIF_ABAPGIT_LONGTEXTS
Changed package assignment for object INTF ZIF_ABAPGIT_OBJECT_ENHO
Changed package assignment for object INTF ZIF_ABAPGIT_OBJECT_ENHS
Changed package assignment for object INTF ZIF_ABAPGIT_OO_OBJECT_FNC
Changed package assignment for object INTF ZIF_ABAPGIT_PR_ENUM_PROVIDER
Files for object CLAS ZCL_ABAPGIT_LONGTEXTS are not placed in the same folder
Files for object CLAS ZCL_ABAPGIT_OBJECT_ENHO_BADI are not placed in the same folder
Files for object CLAS ZCL_ABAPGIT_OBJECT_ENHO_BADI are not placed in the same folder
Files for object CLAS ZCL_ABAPGIT_OBJECT_ENHO_CLASS are not placed in the same folder
Files for object CLAS ZCL_ABAPGIT_OBJECT_ENHO_CLASS are not placed in the same folder
Files for object CLAS ZCL_ABAPGIT_OBJECT_ENHO_CLIF are not placed in the same folder
Files for object CLAS ZCL_ABAPGIT_OBJECT_ENHO_FUGR are not placed in the same folder
Files for object CLAS ZCL_ABAPGIT_OBJECT_ENHO_FUGR are not placed in the same folder
Files for object CLAS ZCL_ABAPGIT_OBJECT_ENHO_HOOK are not placed in the same folder
Files for object CLAS ZCL_ABAPGIT_OBJECT_ENHO_HOOK are not placed in the same folder
Files for object CLAS ZCL_ABAPGIT_OBJECT_ENHO_INTF are not placed in the same folder
Files for object CLAS ZCL_ABAPGIT_OBJECT_ENHO_INTF are not placed in the same folder
Files for object CLAS ZCL_ABAPGIT_OBJECT_ENHO_WDYC are not placed in the same folder
Files for object CLAS ZCL_ABAPGIT_OBJECT_ENHO_WDYC are not placed in the same folder
Files for object CLAS ZCL_ABAPGIT_OBJECT_ENHO_WDYN are not placed in the same folder
Files for object CLAS ZCL_ABAPGIT_OBJECT_ENHO_WDYN are not placed in the same folder
Files for object CLAS ZCL_ABAPGIT_OBJECT_ENHS_BADI_D are not placed in the same folder
Files for object CLAS ZCL_ABAPGIT_OBJECT_ENHS_BADI_D are not placed in the same folder
Files for object CLAS ZCL_ABAPGIT_OBJECT_ENHS_HOOK_D are not placed in the same folder
Files for object CLAS ZCL_ABAPGIT_OBJECT_ENHS_HOOK_D are not placed in the same folder
Files for object CLAS ZCL_ABAPGIT_OO_BASE are not placed in the same folder
Files for object CLAS ZCL_ABAPGIT_OO_CLASS are not placed in the same folder
Files for object CLAS ZCL_ABAPGIT_OO_INTERFACE are not placed in the same folder
Files for object CLAS ZCL_ABAPGIT_OO_SERIALIZER are not placed in the same folder
Files for object CLAS ZCL_ABAPGIT_PR_ENUMERATOR are not placed in the same folder
Files for object CLAS ZCL_ABAPGIT_PR_ENUM_GITHUB are not placed in the same folder
Files for object CLAS ZCL_ABAPGIT_SOTR_HANDLER are not placed in the same folder
Files for object CLAS ZCL_ABAPGIT_SOTR_HANDLER are not placed in the same folder
Files for object INTF ZIF_ABAPGIT_LONGTEXTS are not placed in the same folder
Files for object INTF ZIF_ABAPGIT_OBJECT_ENHO are not placed in the same folder
Files for object INTF ZIF_ABAPGIT_OBJECT_ENHS are not placed in the same folder
Files for object INTF ZIF_ABAPGIT_OO_OBJECT_FNC are not placed in the same folder
Files for object INTF ZIF_ABAPGIT_PR_ENUM_PROVIDER are not placed in the same folder
Package and path does not match for object, CLAS ZCL_ABAPGIT_LONGTEXTS
Package and path does not match for object, CLAS ZCL_ABAPGIT_OBJECT_ENHO_BADI
Package and path does not match for object, CLAS ZCL_ABAPGIT_OBJECT_ENHO_BADI
Package and path does not match for object, CLAS ZCL_ABAPGIT_OBJECT_ENHO_CLASS
Package and path does not match for object, CLAS ZCL_ABAPGIT_OBJECT_ENHO_CLASS
Package and path does not match for object, CLAS ZCL_ABAPGIT_OBJECT_ENHO_CLIF
Package and path does not match for object, CLAS ZCL_ABAPGIT_OBJECT_ENHO_FUGR
Package and path does not match for object, CLAS ZCL_ABAPGIT_OBJECT_ENHO_FUGR
Package and path does not match for object, CLAS ZCL_ABAPGIT_OBJECT_ENHO_HOOK
Package and path does not match for object, CLAS ZCL_ABAPGIT_OBJECT_ENHO_HOOK
Package and path does not match for object, CLAS ZCL_ABAPGIT_OBJECT_ENHO_INTF
Package and path does not match for object, CLAS ZCL_ABAPGIT_OBJECT_ENHO_INTF
Package and path does not match for object, CLAS ZCL_ABAPGIT_OBJECT_ENHO_WDYC
Package and path does not match for object, CLAS ZCL_ABAPGIT_OBJECT_ENHO_WDYC
Package and path does not match for object, CLAS ZCL_ABAPGIT_OBJECT_ENHO_WDYN
Package and path does not match for object, CLAS ZCL_ABAPGIT_OBJECT_ENHO_WDYN
Package and path does not match for object, CLAS ZCL_ABAPGIT_OBJECT_ENHS_BADI_D
Package and path does not match for object, CLAS ZCL_ABAPGIT_OBJECT_ENHS_BADI_D
Package and path does not match for object, CLAS ZCL_ABAPGIT_OBJECT_ENHS_HOOK_D
Package and path does not match for object, CLAS ZCL_ABAPGIT_OBJECT_ENHS_HOOK_D
Package and path does not match for object, CLAS ZCL_ABAPGIT_OO_BASE
Package and path does not match for object, CLAS ZCL_ABAPGIT_OO_CLASS
Package and path does not match for object, CLAS ZCL_ABAPGIT_OO_INTERFACE
Package and path does not match for object, CLAS ZCL_ABAPGIT_OO_SERIALIZER
Package and path does not match for object, CLAS ZCL_ABAPGIT_PR_ENUMERATOR
Package and path does not match for object, CLAS ZCL_ABAPGIT_PR_ENUM_GITHUB
Package and path does not match for object, CLAS ZCL_ABAPGIT_SOTR_HANDLER
Package and path does not match for object, CLAS ZCL_ABAPGIT_SOTR_HANDLER
Package and path does not match for object, INTF ZIF_ABAPGIT_LONGTEXTS
Package and path does not match for object, INTF ZIF_ABAPGIT_OBJECT_ENHO
Package and path does not match for object, INTF ZIF_ABAPGIT_OBJECT_ENHS
Package and path does not match for object, INTF ZIF_ABAPGIT_OO_OBJECT_FNC
Package and path does not match for object, INTF ZIF_ABAPGIT_PR_ENUM_PROVIDER
Multiple files with same filename, zcl_abapgit_longtexts.clas.abap
Multiple files with same filename, zcl_abapgit_object_enho_badi.clas.abap
Multiple files with same filename, zcl_abapgit_object_enho_badi.clas.xml
Multiple files with same filename, zcl_abapgit_object_enho_class.clas.abap
Multiple files with same filename, zcl_abapgit_object_enho_class.clas.xml
Multiple files with same filename, zcl_abapgit_object_enho_clif.clas.xml
Multiple files with same filename, zcl_abapgit_object_enho_fugr.clas.abap
Multiple files with same filename, zcl_abapgit_object_enho_fugr.clas.xml
Multiple files with same filename, zcl_abapgit_object_enho_hook.clas.abap
Multiple files with same filename, zcl_abapgit_object_enho_hook.clas.xml
Multiple files with same filename, zcl_abapgit_object_enho_intf.clas.abap
Multiple files with same filename, zcl_abapgit_object_enho_intf.clas.xml
Multiple files with same filename, zcl_abapgit_object_enho_wdyc.clas.abap
Multiple files with same filename, zcl_abapgit_object_enho_wdyc.clas.xml
Multiple files with same filename, zcl_abapgit_object_enho_wdyn.clas.abap
Multiple files with same filename, zcl_abapgit_object_enho_wdyn.clas.xml
Multiple files with same filename, zcl_abapgit_object_enhs_badi_d.clas.abap
Multiple files with same filename, zcl_abapgit_object_enhs_badi_d.clas.xml
Multiple files with same filename, zcl_abapgit_object_enhs_hook_d.clas.abap
Multiple files with same filename, zcl_abapgit_object_enhs_hook_d.clas.xml
Multiple files with same filename, zcl_abapgit_oo_base.clas.abap
Multiple files with same filename, zcl_abapgit_oo_class.clas.abap
Multiple files with same filename, zcl_abapgit_oo_interface.clas.abap
Multiple files with same filename, zcl_abapgit_oo_serializer.clas.abap
Multiple files with same filename, zcl_abapgit_pr_enum_github.clas.abap
Multiple files with same filename, zcl_abapgit_pr_enumerator.clas.abap
Multiple files with same filename, zcl_abapgit_sotr_handler.clas.abap
Multiple files with same filename, zcl_abapgit_sotr_handler.clas.testclasses.abap
Multiple files with same filename, zif_abapgit_longtexts.intf.abap
Multiple files with same filename, zif_abapgit_object_enho.intf.abap
Multiple files with same filename, zif_abapgit_object_enhs.intf.abap
Multiple files with same filename, zif_abapgit_oo_object_fnc.intf.abap
Multiple files with same filename, zif_abapgit_pr_enum_provider.intf.abap

I don't know if this behavior is related to the change in this PR. I guess not since for moved objects after pull the old path appears locally deleted, not remotely deleted.
Example:

message_helper was correctly listed as deleted on the remote and neither deleted automatically locally nor was it tried to import the object again which this PR tries to solve. So that seems to work fine!
Some other movements are listed differently. I guess these are the ones where the message "Changed package assignment" was issued for.

Newly pulled packages didn't get their text for some reason:

After pressing refresh and pull again nothing happend. Reset local was able to clean everything up leaving no diffs or warnings at all.
 I was surprised by an ALV to pick a commit from which only listed commits dating back like 1 or 2 months ago. So I went with preparing a branch at that commit instead and checking that out.


rPackages.textshaping: fix build on darwin

Description of changes
Closes #228250.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@ofborg build rPackages.textshaping rPackages.textshaping.passthru.tests

Can you provide some insight as to why fribidi doesn't get linked like normal packages on macos?

No idea. This also happens with some Chicken packages.


Azure Backup

Seems to be a mismatch between this page and this one: https://docs.microsoft.com/en-us/azure/backup/backup-azure-backup-faq with respect to maximum number of data disks attached to  AZure IaaS VM. Says 16 on this page and 32 on the FAQ link I provided.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1cd57b6d-3c6f-e546-b3ea-f83892f4c23d
Version Independent ID: 27aecc7b-f107-96d4-b044-ae026bca2727
Content: Azure subscription limits and quotas
Content Source: articles/azure-subscription-service-limits.md
Service: billing
GitHub Login: @rothja
Microsoft Alias: byvinyal

@declang Thanks for your comment. The feedback has been shared with the content owner for further review. Thanks for your patience.

@declang Thanks for pointing this out. I need to investigate and make sure we get it right in both places. Thanks for your patience.

@declang I have confirmed that 16 is the right number and the docs should be updated to reflect that. Thanks again for the feedback and helping us to be more accurate in our statements.
#please-close


"Fills Automatically Based On State" - Needs correction

There are no attributes that fill automatically based on state.
See the app sketch spreadsheet.
For convenience here's where the autocomplete fields need to come from.
NAICS: A pre-loaded list of all NAICS codes
Substances: A pre-loaded list of substances (can be pulled in realtime from the SRS API too, but, since we're focused on just the clean air act, we can also just preload the list from Section 7412, as noted in the overview doc
Program Name: A pre-loaded list of programs culled from the LRS xml.  Contestants will need to figure out how to do that.

FYI @coderReview please note the above.

Did you intend to close this?


Android Dev - Console warning on open App

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open the app

Expected Result:
No console warning
Actual Result:
There is a console warning (require cycle....)
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: dev
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @bernhardoj
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691817989189509
View all open jobs on GitHub

i think pr is already in progress https://github.com/Expensify/App/pull/25544

This is a dupe then. We can close this one @kavimuru

Closing


Using webpsy package to replace basic function folder

The webpsy package is available now. We can use it to replace the basic function folder.

Done


doc: user guide documentation

this pr is included into https://github.com/Lionk-Framework/Lionk/pull/273


Probably unnecessary check for empty value.

https://github.com/mui-org/material-ui/blob/a3144a493d2022a01ee9afd37cdc96b60a7d84df/packages/material-ui-unstyled/src/ModalUnstyled/ModalUnstyled.js#L235-L237
236 line - children.props.tabIndex is always undefined.

Probably unnecessary check for empty value

@strayiker Not if you do:
<Modal
  open={open}
  onClose={handleClose}
  aria-labelledby="modal-modal-title"
  aria-describedby="modal-modal-description"
>
  <Box tabIndex={12}>Text in a modal</Box>
</Modal>

@oliviertassinari
if (children.props.tabIndex === undefined) {
This line makes sure it is undefined, so yes it always undefined in 236

@strayiker I might have just understood where you are getting at. Please update the issue description with the improvement you are proposing, e.g. a git diff.

Can I take this up?? @oliviertassinari


Running nerdctl compose up immediately exists with "no such file or directory" on -json.log file

Description
Running nerdctl compose up (without the -d detach flag) immediately exits with an error that the container -json.log file does not exist.
Running nerdctl compose up -d; sleep 2; nerdctl compose logs -f works; the containers are created and the log files exist and are tailed to stdout.
This behaviour occurs with both v0.20.0 (as installed by Lima) and current master (ddad5009be1618b213d0da43b03afd3df1e41852) compiled from source.
Steps to reproduce the issue

Create docker-compose.yml file as below
Run nerdctl compose up

version: '3.1'

services:

  db:
    image: postgres:latest
    environment:
      POSTGRES_PASSWORD: postgres
    ports:
      - 5432:5432

Describe the results you received and expected
Expected results:
Container starts and log file is tailed to stdout.
Received results:
nerdctl immediately exists, with the following output (with -debug flag):
dave@lima-default psql-example % nerdctl compose up --debug
DEBU[0000] stateDir: /run/user/501/containerd-rootless
DEBU[0000] rootless parent main: executing "/usr/bin/nsenter" with [-r/ -w/home/dave.linux/dev/containers/psql-example --preserve-credentials -m -n -U -t 1610 -F nerdctl compose up --debug]
INFO[0000] Ensuring image postgres:latest
DEBU[0000] filters: [labels."com.docker.compose.project"==psql-example,labels."com.docker.compose.service"==db]
INFO[0000] Creating container psql-example_db_1
DEBU[0000] failed to run [aa-exec -p nerdctl-default -- true]: "aa-exec: ERROR: profile 'nerdctl-default' does not exist\n\n"  error="exit status 1"
DEBU[0000] verification process skipped
DEBU[0000] creating anonymous volume "43cd122bfc77156a7e186835af920a0ece71334be29f77c931860b073a872ca7", for "VOLUME /var/lib/postgresql/data"
DEBU[0000] final cOpts is [0x6e5a40 0xaafa50 0x6e5e60 0x6e5bc0 0x6e58b0 0xab0e00 0xab1fa0 0x6e62f0]
INFO[0000] Attaching to logs
DEBU[0000] filters: [labels."com.docker.compose.project"==psql-example,labels."com.docker.compose.service"==db]
db_1 |time="2022-05-20T20:39:51Z" level=fatal msg="failed to open \"/home/dave.linux/.local/share/nerdctl/1935db59/containers/default/d3c03ca1e0c65d0bba6e43d24ab8bd5fc5820d276cf9ebda97894d07b2991d57/d3c03ca1e0c65d0bba6e43d24ab8bd5fc5820d276cf9ebda97894d07b2991d57-json.log\", container is not created with `nerdctl run -d`?: stat /home/dave.linux/.local/share/nerdctl/1935db59/containers/default/d3c03ca1e0c65d0bba6e43d24ab8bd5fc5820d276cf9ebda97894d07b2991d57/d3c03ca1e0c65d0bba6e43d24ab8bd5fc5820d276cf9ebda97894d07b2991d57-json.log: no such file or directory"
INFO[0000] Container "psql-example_db_1" exited
INFO[0000] All the containers have exited
INFO[0000] Stopping containers (forcibly)
INFO[0000] Stopping container psql-example_db_1

What version of nerdctl are you using?
Client:
Version:       v0.20.0
OS/Arch:       linux/arm64
Git commit:    e77e05b5fd252274e3727e0439e9a2d45622ccb9
Server:
containerd:
Version:      v1.6.4
GitCommit:    212e8b6fa2f44b9c21b2798135fc6fb7c53efc16
Are you using a variant of nerdctl? (e.g., Rancher Desktop)
Lima
Host information
Client:
Namespace:     default
Debug Mode:    false
Server:
Server Version: v1.6.4
Storage Driver: fuse-overlayfs
Logging Driver: json-file
Cgroup Driver: systemd
Cgroup Version: 2
Plugins:
Log: json-file
Storage: native overlayfs stargz fuse-overlayfs
Security Options:
apparmor
seccomp
Profile: default
cgroupns
rootless
Kernel Version: 5.10.0-13-arm64
Operating System: Debian GNU/Linux 11 (bullseye)
OSType: linux
Architecture: aarch64
CPUs: 4
Total Memory: 3.831GiB
Name: lima-default
ID: a2e0f2fe-8b65-4b55-b746-945a35e37c9f
WARNING: AppArmor profile "nerdctl-default" is not loaded.
Use 'sudo nerdctl apparmor load' if you prefer to use AppArmor with rootless mode.
This warning is negligible if you do not intend to use AppArmor.
WARNING: bridge-nf-call-iptables is disabled
WARNING: bridge-nf-call-ip6tables is disabled

we should merge this https://github.com/containerd/nerdctl/pull/1062/files than I will  push a fix for this issue.
I will take care of it @davebarkerxyz  ;)

This is impacting me. Thank you @fahedouch for taking care of this

Thanks @fahedouch - much appreciated! If you need me to test your fix then please let me know and I'd be happy to help.

@fahedouch Do you have a plant to open a PR?

@AkihiroSuda  Yes, I looked at this yesterday, I made a fix ASAP!

Using the workaround above doesn't seem to fix it for me. I have a compose file with three containers. Two of them start as expected, but one fails with this error message and exits:
foo_bar_1         |time="2022-06-09T10:35:28Z" level=fatal msg="failed to open \"/var/lib/nerdctl/dbb19c5e/containers/default/9326ba0edf486870a2d605b197a3516c5d8091899844b058dfa365b5ceb2fa95/9326ba0edf486870a2d605b197a3516c5d8091899844b058dfa365b5ceb2fa95-json.log\", container is not created with `nerdctl run -d`?: stat /var/lib/nerdctl/dbb19c5e/containers/default/9326ba0edf486870a2d605b197a3516c5d8091899844b058dfa365b5ceb2fa95/9326ba0edf486870a2d605b197a3516c5d8091899844b058dfa365b5ceb2fa95-json.log: no such file or directory"

Take note that I'm running nerdctl bundled with Rancher Desktop.

@nsiepmann I've managed to use the workaround with mutli-container compose files, but I suspect it's highly dependent on timing (how quickly the container starts). You could try increasing the sleep to see if that helps until a fix is available, e.g. nerdctl compose up -d; sleep 10; nerdctl compose logs -f

Fixed in nerdctl v0.21.0
https://github.com/containerd/nerdctl/releases/tag/v0.21.0

I'm running a Gitlab CI step with image ghcr.io/containerd/nerdctl:v0.21.0 and I have a similar error:
time="2022-07-15T15:30:02Z" level=debug msg="failed to run [aa-exec -p nerdctl-default -- true]: \"[92] aa-exec: ERROR: profile 'nerdctl-default' does not exist\\n\"" error="exit status 1"
90time="2022-07-15T15:30:02Z" level=debug msg="verification process skipped"
91time="2022-07-15T15:30:02Z" level=debug msg="failed to run [aa-exec -p nerdctl-default -- true]: \"[93] aa-exec: ERROR: profile 'nerdctl-default' does not exist\\n\"" error="exit status 1"
92time="2022-07-15T15:30:02Z" level=debug msg="verification process skipped"
93time="2022-07-15T15:30:02Z" level=debug msg="failed to run [aa-exec -p nerdctl-default -- true]: \"[94] aa-exec: ERROR: profile 'nerdctl-default' does not exist\\n\"" error="exit status 1"
94time="2022-07-15T15:30:02Z" level=debug msg="verification process skipped"
95time="2022-07-15T15:30:02Z" level=debug msg="failed to run [aa-exec -p nerdctl-default -- true]: \"[95] aa-exec: ERROR: profile 'nerdctl-default' does not exist\\n\"" error="exit status 1"
96time="2022-07-15T15:30:02Z" level=debug msg="verification process skipped"
97time="2022-07-15T15:30:02Z" level=debug msg="failed to run [aa-exec -p nerdctl-default -- true]: \"[96] aa-exec: ERROR: profile 'nerdctl-default' does not exist\\n\"" error="exit status 1"
98time="2022-07-15T15:30:02Z" level=debug msg="verification process skipped"
99time="2022-07-15T15:30:02Z" level=debug msg="failed to run [aa-exec -p nerdctl-default -- true]: \"[97] aa-exec: ERROR: profile 'nerdctl-default' does not exist\\n\"" error="exit status 1"
100time="2022-07-15T15:30:02Z" level=debug msg="verification process skipped"
101time="2022-07-15T15:30:02Z" level=debug msg="failed to run [aa-exec -p nerdctl-default -- true]: \"[98] aa-exec: ERROR: profile 'nerdctl-default' does not exist\\n\"" error="exit status 1"
102time="2022-07-15T15:30:02Z" level=debug msg="verification process skipped"
103time="2022-07-15T15:30:02Z" level=fatal msg="no such file or directory"
104time="2022-07-15T15:30:02Z" level=fatal msg="no such file or directory"
105time="2022-07-15T15:30:03Z" level=fatal msg="no such file or directory"
106time="2022-07-15T15:30:03Z" level=fatal msg="no such file or directory"
107time="2022-07-15T15:30:03Z" level=fatal msg="no such file or directory"
108time="2022-07-15T15:30:03Z" level=fatal msg="no such file or directory"
109time="2022-07-15T15:30:03Z" level=fatal msg="no such file or directory"
110time="2022-07-15T15:30:03Z" level=fatal msg="error while creating container users: exit status 1"

But nothing about log files or sthing like that.


模型非流式回答的内容不完整，而设置stream=True就能完整输出，设置max_tokens无效

@aimi0914 Apologies I had to translate that:
The content of the model's non-streaming answer is incomplete, but setting stream=True can complete the output. Setting max_tokens is invalid #310

I can see you set max_tokens to 4096, but it just stops generating? Very weird. Tbh I'm not really sure how to debug this, since this seems like an application you're creating

@aimi0914 Apologies I had to translate that:
The content of the model's non-streaming answer is incomplete, but setting stream=True can complete the output. Setting max_tokens is invalid #310

I can see you set max_tokens to 4096, but it just stops generating? Very weird. Tbh I'm not really sure how to debug this, since this seems like an application you're creating

My code is as follows, simple call with openai library. Qwen1.5-14B-Chat. The model was deployed using fastchat

@aimi0914 Apologies I had to translate that:
The content of the model's non-streaming answer is incomplete, but setting stream=True can complete the output. Setting max_tokens is invalid #310

I can see you set max_tokens to 4096, but it just stops generating? Very weird. Tbh I'm not really sure how to debug this, since this seems like an application you're creating

Replacing the model with baichuan and testing with the same code is fine. So I suspect it's the qwen model

https://github.com/vllm-project/vllm/issues/3034#issue-2153548212
the same question


CORE-5920 - Let members having declined status re-register

https://r3-cev.atlassian.net/browse/CORE-5920

LGTM - did you test it?

Not yet. Only with unit tests so far. But will do it today.

@yift-r3 I tested it.


Fix msvc17 threads

There is a workaround in the code that is needed for Visual Studio 2012/2013. On Visual Stuidio 2017 it gives the runtime error when joining threads, so it is better to remove it (adding more #if parts).
Is this a correct branch to post PR or WIndows-compatible version is developed elsewhere currently?

See also https://github.com/stxxl/stxxl/issues/57