python function support multiple input typesClassNames

Search before asking

[X] I searched in the issues and found nothing similar.

Motivation
as it is possible in the yaml to define multiple input topics it should be possible as well to reference the typeClassName on the inputspecs level and not only in the input section
    "source": {
        "typeClassName": "schema-test.EasySchema",
        "inputSpecs": {
            "tenant/test-schema/schema.v1": {
                "serdeClassName": "schema-test.EasySchemaSerDe",
                "schemaType": "avro"
            },
            "tenant/test-schema/schema.v2": {
                "serdeClassName": "schema-test.EasySchemaSerDe",
                "schemaType": "avro"
            }
        },
        "subscriptionPosition": "EARLIEST"
    }

Else it isn't possible to define different class references for different topics (if the Class and SerDe is different)
in get_schema() it should have the possibility to reference consumer_conf.typeClassName
so final spec would look like
    "source": {
        "inputSpecs": {
            "tenant/test-schema/schema.v1": {
                "serdeClassName": "schema-test.EasySchemaSerDe",
                "schemaType": "avro",
                "typeClassName": "schema-test.EasySchema"
            },
            "tenant/test-schema/schema.v2": {
                "serdeClassName": "schema-test.EasySchema2SerDe",
                "schemaType": "avro",
                "typeClassName": "schema-test.EasySchema2",
            }
        },
        "subscriptionPosition": "EARLIEST"
    }

Solution
No response
Alternatives
No response
Anything else?
No response
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

The typeClassName should be the same for multiple input topics since there will be only one process function and the typeClassName is the type of the params, like:
def process(params):
  params.age = params.age + 1
  return params

Or else this process method will get a EasySchema or EasySchema2 type parameter.
Although Python doesn't have a type validation, the params can be any type, and users can write code to process different types, but for Java and Golang, the params's type is checked, it should only have one value.
And the structure is defined in the Function.proto file, which is used for Java, Python, and Golang:
message SourceSpec {
    string className = 1;
    // map in json format
    string configs = 2;
    string typeClassName = 5;
...
}

So we cannot define the typeClassName in the inputSpecs

Hi yes but our function could react differently on those inputs (checking as well the topic)
so we do have the usecase for e.g. lookup values which are just initialised and e.g. entities being processed
meaning lookup topics are just processed in memory and entities triggering some other "code"logic
as typeClass is just referencing the Message object and not the processing logic it would still make sense to have that on the inputspec level?!

Hi yes but our function could react differently on those inputs (checking as well the topic)
so we do have the usecase for e.g. lookup values which are just initialised and e.g. entities being processed
meaning lookup topics are just processed in memory and entities triggering some other "code"logic
as typeClass is just referencing the Message object and not the processing logic it would still make sense to have that on the inputspec level?!


Remove IsLocal

#536
@Tratcher
Will need to update a couple repos when this goes in

:shipit: Check Hosting, WebListener, Kestrel, and BasicMiddleware.

:shipit:

Related to this idea, should we move IsHttps to an extension method?

@davidfowl shrug. Last chance if you're going to, but it's not a priority.

The weird thing about it not being a computed property is that the actual scheme and IsHttps can be out of sync. I'm not aware of that being an intentional design choice.

Well, it is actually computed: https://github.com/aspnet/HttpAbstractions/blob/dev/src/Microsoft.AspNet.Http/DefaultHttpRequest.cs#L98-L102, but I guess that's not a guaranteed implementation detail.

I'd very much like the IsHttps property to be kept. My $0.02.

Might make sense to make these things all computed and not settable.

:up: :date: Removed IsLocal from IHttpConnectionFeature

:shipit:


Correct an outdated doc for link previews.

I'll merge, we can just review once via the "Review Complete" label


Added further options for tourists from outside EEA

I've added further options for tourists from non-EEA countries wishing to enter the UK for a short stay. This is a short-term fix: the text is doing too much heavy lifting at present, so I've raised a ticket to make changes to the flow. But at least the info we're giving is correct.
Here's an example of an outcome that'll change once these changes go live: https://www.gov.uk/check-uk-visa/y/russia/tourism

I'm closing this PR as it has been open for a considerable amount of time and we're trying to cut down the number of orphaned PRs in alphagov.


Remove the attribute/list call around the codebase

What is the motivation for adding / enhancing this feature?

If we moved the fetching of attribute meta-data server-side (in the storefront-api or vue-storefront-api or both) we can potentially resign from fetching attribute metadata client's side). This is a huge optimization area as some of the attributes can have 1000+ different select options - plus some e-shops contains thousands of attributes ...
Then the attribute metadata is being provided to the browser with the __INITIAL_STATE__ that causes additional performance harm.
Currently - let's say for a color to display it's the value we're using the optionLabel helper.
If we add the custom_attributes in the product entity in the following format:
{
  "custom_attributes": [
  "attribute_code": "color",
   "value": 150,
  "label": "Red"
]
}

... then we don't have to query for this info.
Vue Storefront is expanding the custom_attributes and removing the property during the indexation and then in the frontend helper and here and here. We should keep this property and potentially stop expanding it in the frontend helpers.
We need to add the label property to be set on mage2vuestorefront - in here as labels don't come from Magento
Note: please test how this will work on multi-valued attributes (in that case value and label should be an array I guess - the value is an array 100%)
It's currently expanded for the configurable_options - https://github.com/DivanteLtd/vue-storefront/blob/19a7c2f836209a57089be6dc2d5413c58032c1fc/core/modules/catalog/helpers/index.ts#L412
So the only places to remove the attribute label translation are:

filters,
product details on PDP.

Then, we can safely remove the product/list calls along with the code
What are the acceptance criteria

[ ] ...

Can you complete this feature request by yourself?

[ ] YES
[ ] NO

Which Release Cycle state this refers to? Info for developer.
Pick one option.

[x] This is a normal feature request. This should be available on https://test.storefrontcloud.io and then after tests this can be added to next Vue Storefront version. In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
[ ] (Pick this option only if you're sure) This is an important improvement request for current Release Candidate version on https://next.storefrontcloud.io and should be placed in next RC version. In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
[ ] (Pick this option only if you're sure) This is a critical improvement request for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version. In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Additional information

Note: the custom_attributes should contain all the attributes that are visible on pdp and comparable

Not: this change should be backward compatible - so we should just remove the attribute/list calls but keep the whole logic for operating and indexind on attributes if anyone used it in the custom theme


Rename the Variant interface to GATKVariant

For consistency with GATKRead

I nominate @cseed to take over the Variant part of the dataflow effort (the Broad part)

I'm assuming that's Cotton?

yes


Replace all lambda functions with custom keras layers

Using lambdas can lead to the model not being usable on other python versions / systems when saving and loading the result as a h5 file (see: https://github.com/keras-team/keras/issues/9595 ).
I suggest replacing all current lambda layers with keras custom layers.
This would mean this project would have to also generate a python file with all custom layer implementations or just ship one with all custom layers (I'd prefer the first one).
It is possible to register custom layers with keras so shipping a function to register all used custom layers would make sense instead of having the user map all custom layers on keras.models.load_model time.
Otherwise users would have to ship the onnx file and run the conversion for each use which isn't really a nice way to go about it IMO.

Revisiting this, since one of the main use cases of onnx2keras for our group is to go PyTorch/CoreML -> ONNX -> Keras -> Tensorflow.js. However, the latter will not be able to run Python Lambda functions. What would you recommend in order to be able to avoid Lambda functions altogether?

In my case a had a problem with the Clip layer, I realized that Cliping equals applying a Relu activation function so I replace in operation_layers.py the following:
    relu_layer = keras.layers.ReLU(max_value=6)

    # def target_layer(x, vmin=0, vmax=6):
    #     import tensorflow as tf
    #     return tf.clip_by_value(x, vmin, vmax)
    # layer = keras.layers.Lambda(target_layer, name=keras_name)
    # lambda_func[keras_name] = target_layer

    layers[node_name] = relu_layer(input_0)


Added new methods to the template for reset calls

I know that the issue #157 it's in discussion, but I found interesting and easy as first change to propose.

@josgilmo perhaps you can put this as an option behind a flag? I like the idea of new features like this being optional.

looks like we'll prefer this PR https://github.com/matryer/moq/pull/181


Importers

This PR introduces a structure for creating importer plugins for atlascope.  Available importer objects are determined by the plugins available to the current instance. Each of these plugins should define some function that accepts a source URI.
The dataset model now includes a CharField importer that refers to the unique name of an importer plugin (among the choices of what is installed). For example "vandy" refers to the installed plugin called atlascope-vandy-importer. Calling some_dataset.perform_import() will send the Dataset's source_uri to the import function defined in the plugin, which is referenced by the Dataset's importer value. There is now a REST endpoint to perform an import on a Dataset.
For development, we can put the source code for importer plugins in a subdirectory called atlascope_plugins, and the docker config will install them as packages in our dev environment.
For production, we should register these plugin repos with PyPI, and any production instances should pip install the plugin or include the PyPI dist name in setup.py.

^^ There's a lot of force-pushing above, mostly because I was working on fixing the CI tests (it was passing locally but not here). The first two commits contain the real changes.


[Question]: Azure Databricks Sharepoint Handler

Question Validation

[X] I have searched both the documentation and discord for an answer.

Question
I'm using LlamaIndex to download files from SharePoint and embed them. This process works perfectly on my local environment. However, when running the same code in Databricks, I encounter an error: "An error occurred while accessing SharePoint: No files found in /tmp/tmp_1ug0awy." How can I resolve this issue? @dosu

@dosu i am using the exact python code that i run it locally via visual studio but inside databricks notebook. i dont need databricks token or anything, im just using a cluster and running a notebook. @dosu

when i run this documents=self.loader.load_data(sharepoint_site_name=site_url_sharepoint,  sharepoint_folder_path="",recursive=True)
i get this error
An error occurred while accessing SharePoint: No files found in /tmp/tmphwfd9j87.
i think it is something with temp file
@dosu please help

how to change the path ? I have added TMPDIR="dbfs/tmp" in my env variables but it is not working @dosu

@dosu apparently it is working but i still have the error an error occurred while accessing SharePoint: No files found in /tmp/tmpw1w3g_s5.  It seems that it is not downloading. the problem is on my local visual studio code, it is working @dosu


[BUG] :- Not getting group Participants

this.sessions[i].ev.on('groups.upsert', item =>{
console.log('groups.upsert',recv ${item.length} groups)
db.get("groups").push(...item).write()
})
this not give any data

Before making issues use the code provided in examples. If no such code is found make it as clear as possible following the documentation and if the issue persists, then make an issue with more detail than just ”no workey”. Issues are not made for issues in your own code, especially with ’BUG’ template. Hence closing this.


Invalid LSP CodeAction response

I have just tried the latest release of omnisharp-roslyn (1.39.11) in LSP mode and the code action response was wrong.
{
  "jsonrpc": "2.0",
  "id": 24,
  "result": [
    {
      "title": "Use implicit type",
      "kind": "refactor",
      "diagnostics": [],
      "data": {
        "Uri": "file:///home/bstaletic/.vim/pack/bundle/start/YouCompleteMe/third_party/ycmd/ycmd/tests/cs/testdata/testy/FixItTestCase.cs",
        "Identifier": "Use implicit type",
        "Name": "Use implicit type",
        "Range": {
          "Start": {
            "Line": 3,
            "Character": 12
          },
          "End": {
            "Line": 3,
            "Character": 13
          }
        },
        "$$__handler_id__$$": "db8ae591-20c6-46a3-89a6-e8c50093aac3"
      }
    }
  ]
}

Code actions responses are supposed to be arrays of Commands and CodeActions.
If the above is supposed to be a Command, it is missing the command property.
If the above is supposed to be a CodeAction, it is missing either command or edit as per

A CodeAction must set either edit and/or a command

I have the same issue with Neovim.

@rachartier Thank you. Though the server shouldn't be relying on codeAction/resolve if the client has not advertised that capability.


Update ntp.leapseconds file for July 1, 2015 leapsecond

This updates the leapsecond file per http://hpiers.obspm.fr/iers/bul/bulc/bulletinc.dat

https://github.com/gmiranda23/ntp/pull/85 beat this one by an hour... closing


"FIPS mode not supported" on OpenSSL 1.1.1

I got an message "FIPS mode not supported", when doing configuration on OpenSSL 1.1.1 with openssl-fips. Building with fips mode has not been supported from OpenSSL 1.1.1?
Related commit hash: https://github.com/openssl/openssl/commit/b53338cbf8822dd774f9e4057307f347d2b63ff0
$ ./config fips shared \
>   --prefix=/usr/local/openssl-1.1.1-fips \
>   --with-fipsdir=/usr/local/openssl-fips-2.0.16
Operating system: x86_64-whatever-linux2

Failure!  build file wasn't produced.
Please read INSTALL and associated NOTES files.  You may also have to look over
your available compiler tool chain or change your configuration.

FIPS mode not supported

$ ./Configure \
>   fips \
>   --prefix=/usr/local/openssl-1.1.1-fips \
>   --with-fipsdir=/usr/local/openssl-fips-2.0.16

Failure!  build file wasn't produced.
Please read INSTALL and associated NOTES files.  You may also have to look over
your available compiler tool chain or change your configuration.

FIPS mode not supported

Correct, the current FIPS module only works with 1.0.2
The project is starting work on a new FIPS module which will be included in the next release.

@richsalz  Sure, thanks for the info.
I wish this ticket will be kept without closing until "a new FIPS module which will be included in the next release".

I have a customer who claims to have a FIPS 140-2 module (from some private company?) that works with the OpenSSL 1.1.1 series.  This requires patching OpenSSL 1.1.1 to re-enable FIPS mode.  Is this not a valid reason for OpenSSL 1.1.1 to allow FIPS mode?

We have no knowledge of that FIPS module and how it works, so that's kinda hard...

Some linux distributions do their own FIPS validations which encompass OpenSSL among others. RHEL has one, and Ubuntu did one recently. AFAIK, they are based on 1.1.1, but I'm not sure.

(A quick search yields that Ubuntu's validation might to be based on 1.0.2)

If that is the case, then they've made an incompatible mod. And sure, they're free to do so...

@quanah you should ask which certificate number matches the validation being used as that will provide details at least of what is being claimed.

@quanah you should ask which certificate number matches the validation being used as that will provide details at least of what is being claimed.

All I need on my end of things is to be able to enable FIPS mode, so they can drop their module in. It's not on me to ensure that their module even works, that's between them and their supplier.  But since you can't enable FIPS mode in 1.1.1, that's somewhat problematic.

It's not that simple. The code to support redirection for FIPS usage was removed. It isn't just a mode change - it is hundreds of hooks to redirect and rename symbols. I doubt that anyone has actually ported those back into the code base for 1.1 at all.

Thanks @t-j-h ! I've been rather skeptical of this entire bit they want to do from the get-go.

@richsalz and others: Any updates on the FIPS roadmap? Several factors prompting that

AES GCM in FIPS mode has a bug (issue). We noticed it also fails GCM spec test 5, 11 and 17.
The OpenSSL FIPS page doesn't educate readers on whats ahead
FIPS 140-3 kicking in in 2019 alongside 140-2

FIPS validation is a huge pain point and pointlessly expensive for modern software development, so what the OpenSSL foundation does is fantastic - much appreciated!
PS: It's probably worth creating a master ticket on the next FIPS release tracking all things 'next-release FIPS'?

I don't speak for the project.  If you have specific questions about the state of things, consider asking on the openssl-users mailing list (see https://mta.openssl.org to join).
I believe your no. 1 will not be a factor as the code will be the standard AES code from the mainline. I believe your no. 3 is not relevant since 140-2 is still available and applicable.
Might I humbly suggest that if you've gotten value from the FIPS work, your company make a donation to the project.

The last blog post was from earlier this year describing some of the current activity and how the new OpenSSL 3.0 will work with FIPS:
https://www.openssl.org/blog/blog/2019/02/13/FIPS-update/
The current timeline aims for us to be code complete by the end of the year with a possible release in early Q2 2020 (although we may not be validated at the point of release).

I found this in the blog post about OpenSSL 3.0 :

The new design incorporates the FIPS module into main line OpenSSL. It will no longer be a separate download and support periods will also be aligned. It will of course be possible to build OpenSSL with or without the FIPS module depending on your own individual circumstances and requirements.

Does this mean that there will be no separate FIPS module to use with OpenSSL 1.1.1 ?

Does this mean that there will be no separate FIPS module to use with OpenSSL 1.1.1 ?

Correct. The new FIPS module will be for OpenSSL 3.0.

I am going to close it. Although it might trigger opening further similar issues as people often do not search closed issues when reporting a new issue.

people often do not search closed issues when reporting a new issue.

FWIW: as a countermeasure, GitHub has a new beta feature which displays matching issues automatically when you enter your new issue.

You can close your own issues, too :)
The next release of OpenSSL is 3.0 and will include the FIPS module. All of this work is being done in the open on GitHub in the "master" branch. There will not be a FIPS module for the 1.1.1 release.

What is this link for:
https://beta.openssl.org/docs/fips/UserGuide-1.1.1.pdf

That's one of the guides for the 1.0.2 FIPS validations.  Version numbering of the FOM got into the two point something -- the reason we jumped to 3.0 for the last major release.


using plugin issue

Hello, developers! Happy New Year! I wish you a productive next year for the engine and the community.
I had some time to play with the engine.  And I have the following problem.
I can not create a component from my own plugin. In the specified code section of the example it always returns null.
https://github.com/crystaldev3d/rbfx/blob/reflection-plugin-test/Source/MyGame/Source/Main.cpp#L132
And I don't understand what the problem is.

The project consists of a plugin (collection of components that need to be exposed to the editor and used by game.exe)
(https://github.com/crystaldev3d/rbfx/tree/reflection-plugin-test/Source/MyGamePlugin)
and a program that uses this plugin.
(https://github.com/crystaldev3d/rbfx/tree/reflection-plugin-test/Source/MyGame)

Do you register your type anywhere?

Of course, here RegisteObject()
https://github.com/crystaldev3d/rbfx/blob/reflection-plugin-test/Source/MyGamePlugin/FPSCameraController.cpp#L41
and here
https://github.com/crystaldev3d/rbfx/blob/reflection-plugin-test/Source/MyGamePlugin/GamePlugin.cpp#L61

@crystaldev3d In this case, plugin is probably not loaded. No errors in logs? Engine should report an error if it tried to load plugin which it doesn't know about. If you use static build, you should statically link your plugin to the executable.

In the end I think I should pay attention to rbfx/sample-project, there everything is set up and works out of the box. Besides my variant (game.exe(logic) + dll(components)) will not work in the editor, but sample-project will work. because the project dll is loaded by both the editor and the launcher.
Sorry for the time. I guess this can be closed.


Added Table of Content

Readme update #262 . added table of content in readme file.

@khushimarothi  awesome work! 👏🏼

Thank you 😄


Add llama2-13b and gemma-7b

Description

Generalize the DAG creation function to support other models.
Add llama2-13b, add gemma-7b models.
Add separate DAGs for nightly and stable maxtext/jax/libtpu installs.

Tests
Tested in my own dev Composer environment: http://shortn/_IXWgZp6KN3
Confirmed that metrics are also uploaded to BigQuery dev_benchmark_dataset.
Checklist
Before submitting this PR, please make sure (put X in square brackets):

[X] I have performed a self-review of my code.
[X] I have necessary comments in my code, particularly in hard-to-understand areas.
[X] I have run one-shot tests and provided workload links above if applicable.
[X] I have made or will make corresponding changes to the doc if needed.

R: @JoeZijunZhou

@vipannalla PTAL, thanks!

Looks good, few minor comments

Looks good, few minor comments

Hmm, I don't think they got published.


Infineon DPS368/DPS3xx Pressure Sensor Software Driver Package

Added support for DPS368/DPS3xx barometric pressure sensor software driver.
sensor_creator package is modified/updated accordingly.
This sensor supports I2C and SPI (4 Wire-Mode3) communication.
Detailed documentation for sensor quick start is included in README.md located under hw/drivers/sensros/dps368/

@saumitra-chafekar This needs rebase on master.

@saumitra-chafekar you should just do git pull --rebase origin master in the mynewt-core repo locally and then force push it. That will get it rebased.


Log response string broke

When activating or deactivating userpresence, the bot says it activated it no matter which setting you toggle (on or off), it says it turns it on.

It was fixed in the last patch.


FastForward on LibreWolf not saving custom bypasses

Body
Custom bypasses are not saved at all, not even during the session.
Steps to replicate:

Open the extension settings
Write a custom bypass
Observe that it doesn't work
Refresh the page / close and reopen the extension settings
Observe that the bypass is gone

My first thought was that this must be a LibreWolf issue, what with all of its security measures. Other extensions, however, can save their settings perfectly fine; this is unique to FastForward.
Version
0.2237
What browsers are you seeing the problem on?
Other
What OS are you seeing the problem on?
MacOS
Anything else?
https://github.com/FastForwardTeam/FastForward/assets/54103478/ec0e5ca6-0ba7-459c-aaf6-e085d8b8d312
(Screen recorder didn't record the extension popup)

Same for me on Firefox, running POP!_OS.

@princessmortix think you could help? I remember one of the devs (possibly you?) mentioning how to fix this.

No, I don't, but the user should unfocus from the text input, and wait at least 1s for it to be saved.


Is building on Windows supported?

Hi,
I am currently looking into using this framework on an upcoming project I am trying to finish. I thought that this was a good lighter alternative for a TCP implementation than LibUV.
I am curious about building on Windows. I was able to use cmake with no erroneous output however I also dont see any binaries or headers.
The makefile doesnt seem to support Windows. Am I just way off the beaten path here?

Hi @nullivex ,
Thank you for your interest in facil.io.
You're welcome to pick the framework apart for parts... but at the moment, Windows support isn't implemented (I'm not sure I'll ever get there, as I have no platform on which to test Windows builds).
To support Windows, there's a some required code updates which are:

Adding Windows support for the evio (evented IO) library by wrapping the Windows IO API.
Adding Windows support for the sock library by wrapping the Windows Socket API.
Adding Windows support for the defer library by adding the Windows Thread API to the thread creation / joining callbacks.
Adding Windows alternatives for POSIX datatypes and assumptions (there aren't many, but there are some), such as wrapping the Windows TempFile API in the fiobj_data type (that currently wraps the POSIX file API).

The Windows "evented" IO design is the greatest of challenges. It's totally different than Linux/BSD/macOS, since it's based on "Completion" rather Tham "Readiness" (a signal is raised once an action finished rather than when an action is possible).
Although this has some advantages for sending data, it's quite difficult to handle when waiting for data and it makes it far harder to bridge the two approaches into a single framework (although I did redesign evio using a "one-shot" approach, so I could eventually bridge the two designs).
I wish I could help you, but most of the windows developers I know use Vagrant or some other VM container (I read Microsoft now supports a Linux subsystem)... especially since most deployments end up running on a Linux/Unix kernel (i.e. AWS, Heroku. etc').
I wish I could help more than that... but the best I can offer is that you use facil.io for parts or opt for a different framework.
Kindly,
B.

I'm closing this issue, but you're welcome to keep chatting on this thread if there's anything you think I could help with.
B.

@boazsegev Hi, thank you for the quick response and the insight. I see the issues that are present I was curious mainly because I like to develop native on Windows and then deploy on to Linux. If that sounds weird, it's because it takes care of true cross OS testing on the way out the door. Its been working well in our development process.
I think for this scenario I will continue working with LibUV again thank you for the time.


Refit segfaults on large data sets

Refit segfaults on large data sets, because
https://github.com/microsoft/LightGBM/blob/9f367d11ad52ae8f2f1cf7b3447735723281d820/src/c_api.cpp#L348
limits the index to be of type int32. With n_estimators=100 this means you'll run into trouble if you're refitting with a little more than 20 million rows (arguably very large values for a refit).
The simplest fix would be to recast i * ncol + j, e.g.
static_cast<size_t>(i) * static_cast<size_t>(ncol) + static_cast<size_t>(j)

I'm happy to submit a PR.
Relevant bits of the backtrace:
AddressSanitizer:DEADLYSIGNAL
=================================================================
==27968==ERROR: AddressSanitizer: SEGV on unknown address 0x7f2fd8ef7800 (pc 0x7f3ef7ed5e4d bp 0x7ffcd3fe60a0 sp 0x7ffcd3fe5ea0 T0)
==27968==The signal is caused by a READ memory access.
    #0 0x7f3ef7ed5e4c in LightGBM::Booster::Refit(int const*, int, int) /home/jtilly/LightGBM/src/c_api.cpp:348
    #1 0x7f3ef7ee9bf9 in LGBM_BoosterRefit /home/jtilly/LightGBM/src/c_api.cpp:1573
    #2 0x7f3f1500762f in ffi_call_unix64 (/opt/conda/envs/lightgbm-dev/lib/python3.8/lib-dynload/../../libffi.so.6+0x662f)
   ...
AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: SEGV /home/jtilly/LightGBM/src/c_api.cpp:348 in LightGBM::Booster::Refit(int const*, int, int)
==27968==ABORTING

@jtilly Thanks a lot for finding and fixing the issue!


[android] When opening My Music for the first time it should show "Last Added" tab, after that the application should remember

If you've never played a song and the first thing you did was to download a song, the first time you open the Music Player you will see an empty list because you've never played anything.
At this moment you should be displayed the "Last Added" tab.
Then, from there on, we should keep track of what was the last tab touched on an internal setting variable (See PreferenceUtils.java which is where it seems apollo keeps its preferences, there seems to be something related setStartPage()).
Classes to look at inside android/apollo:
ProfileActivity.java, PagerAdapter.java, MusicBrowserPhoneFragment.java
CC: @votaguz @alejandroarturom (@arubinofaux wanna do some android?)
$15 bounty for merged pull request to be paid in Bitcoin at the exchange rate of the day on Bitven.com

@gubatron so its not that you want the "Last Added" tab to be always first when My Music is opened for the first time, right? What you want is for it to be first when you just go to My Music without playing or downloading anything or just downloading something. If you played some of your content and then you open My Music for the first time you would expect to see Recent tab?
Just wanted to clarify as I already have it set up so it always opens to the Last Added tab and later on remember which tab you were last. But I dont really know how to do the other part. Let me know.

so its not that you want the "Last Added" tab to be always first when My Music is opened for the first time, right
yes, just the first time.

once you start playing stuff you should see Recent, or whatever last tab you left selected before you leave My Music.

@marcelinkaaa check inside the apollo folder PreferenceUtils.java

I got it already and changed it to page 0 - which is Last Added as a Default Page. Than the code remembers what was your last tab. This is done.
However how about this scenario - you first get the app installed and go to my files, for ex, playing one of  your current songs you already had - thus opening the player, after that you go back to navigation (without being in My Music) and select My Music for the first time - should it still show you recent? Or no matter what you did before the first page you see should be Last Added?


Is the automated build running?

Thanks for putting this together, this is awesome!
Quick question: in the README you mention a Github action that should be pulling the latest docs once a month. But it looks like the last version released was in September. Is the automated builder working? Any support you need?
Thanks!

Hey, glad you like it!
It seems a new tag is correctly pushed automatically every month, but apparently the Github action is not picking it up. I suspect the reason is no new commit was pushed in between. When there's already a build for a given commit, a new tag associated to that same commit doesn't trigger the workflow.
It's hopefully fixed now, let's see next month :) If you have a different idea on why the workflow was not running, please shout!
In the meantime I did a manual push, so the latest release is up-to-date.


Building libjxl dependency Highway 0.14.0 halfway results in "Error running executable: Illegal instruction"

Hello. Hopefully I'm doing this right.
Describe the bug
I am trying to build libjxl (0.5) from the Arch Linux User Repository (AUR) and halfway while building its dependency Highway (0.14.0) from the AUR also , I get this error when I am using the GCC:
[ 56%] Building CXX object CMakeFiles/highway_test.dir/hwy/highway_test.cc.o
[ 58%] Linking CXX executable tests/highway_test
CMake Error at /usr/share/cmake-3.21/Modules/GoogleTestAddTests.cmake:77 (message):
  Error running test executable.

    Aborting...
error: failed to build 'highway-0.14.0-1':

When I try using the clang compiler, I get this:
[ 56%] Building CXX object CMakeFiles/highway_test.dir/hwy/highway_test.cc.o
[ 58%] Linking CXX executable tests/highway_test
CMake Error at /usr/share/cmake-3.21/Modules/GoogleTestAddTests.cmake:77 (message):
  Error running test executable.

    Path: '/home/kylxbn/.cache/paru/clone/highway/src/build/tests/highway_test'
    Result: Illegal instruction
    Output:

Call Stack (most recent call first):
  /usr/share/cmake-3.21/Modules/GoogleTestAddTests.cmake:173 (gtest_discover_tests_impl)

make[2]: *** [CMakeFiles/highway_test.dir/build.make:102: tests/highway_test] Error 1
make[2]: *** Deleting file 'tests/highway_test'
make[2]: Leaving directory '/home/kylxbn/.cache/paru/clone/highway/src/build'
make[1]: *** [CMakeFiles/Makefile2:368: CMakeFiles/highway_test.dir/all] Error 2
make[1]: Leaving directory '/home/kylxbn/.cache/paru/clone/highway/src/build'
make: *** [Makefile:146: all] Error 2
make: Leaving directory '/home/kylxbn/.cache/paru/clone/highway/src/build'

This has been happening since libjxl 0.3.x days (not sure if even older versions are affected, since I only tried compiling 0.3.x), and I was thinking that it was just that my CPU is really old (since it doesn't support SSE 4.2). But I guess I better ask for confirmation regarding this, too.
To Reproduce
I have Paru as my AUR helper, and just trying to install libjxl with it will trigger the error.
paru -S libjxl

It seems to be failing while building the test binaries for Highway. I'm not really familiar with how Highway works, but it looks like it will build test executables, then try to execute it. However, maybe because of that missing SSE 4.2 support on my CPU, some inline assembly code fails to run, resulting in that "Illegal instruction" error and the build failing.
Expected behavior
I was hoping that an Illegal instruction error would not occur.
Environment

OS: Arch Linux with GNU/Linux 5.13.7-zen1-1-zen (Zen kernel)
Desktop: KDE Plasma 5.22.4
Multimedia: PipeWire 0.3.32 and Wayland 1.19 (with xorg-xwayland 21.1.2)
Compiler version: GNU GCC 11.1.0 and Clang 12.0.1
Compile flags: Please see below
Terminal: yakuake
Shell: bash 5.1.008
CPU type: Intel Core 2 Duo P8400 (x86_64) @ 2.26GHz
CPU flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ht tm pbe syscall nx lm constant_tsc arch_perfmon pebs bts rep_good nopl cpuid aperfmperf pni dtes64 monitor ds_cpl vmx smx est tm2 ssse3 cx16 xtpr pdcm sse4_1 xsave lahf_lm pti tpr_shadow vnmi flexpriority vpid dtherm ida
Hardware: 4GB RAM, 140GB HDD, Dell Latitude E5400
cjxl/djxl version string: cjxl v0.5 (not sure if that's how it's shown--I wasn't able to compile cjxl due to dependency problems)

Compile flags:
CARCH="x86_64"
CHOST="x86_64-pc-linux-gnu"
CFLAGS="-march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions \
        -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security \
-fstack-clash-protection -fcf-protection"
CXXFLAGS="$CFLAGS -Wp,-D_GLIBCXX_ASSERTIONS"
LDFLAGS="-Wl,-O1,--sort-common,--as-needed,-z,zelro,-z,now"

Additional context
This is an old laptop and it probably does not support SSE 4.2. While using SIMD instructions is cool and all, maybe a fallback to good old x86_64 ISA would be good if the CPU does not support SIMD? I'm honestly not even sure if the compiler can detect it and if it can be done with stuff like preprocessor commands, but... Just a suggestion? I'm honestly not that familiar with C++.
This was how the build files were generated when I am using GCC
-- The C compiler identification is GNU 11.1.0
-- The CXX compiler identification is GNU 11.1.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Performing Test HWY_EMSCRIPTEN
-- Performing Test HWY_EMSCRIPTEN - Failed
-- Found GTest: /usr/lib64/cmake/GTest/GTestConfig.cmake (found version "1.11.0")
-- Configuring done
-- Generating done
-- Build files have been written to: /home/kylxbn/.cache/paru/clone/highway/src/build

and this is for clang:
-- The C compiler identification is Clang 12.0.1
-- The CXX compiler identification is Clang 12.0.1
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/clang - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/clang++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Performing Test HWY_EMSCRIPTEN
-- Performing Test HWY_EMSCRIPTEN - Failed
-- Found GTest: /usr/lib64/cmake/GTest/GTestConfig.cmake (found version "1.11.0")
-- Configuring done
-- Generating done
-- Build files have been written to: /home/kylxbn/.cache/paru/clone/highway/src/build

Hopefully this is useful! Please tell me if I can provide any more details and I would happily help.

Hi @kylxbn , thanks for this extensive report :)
gtest does indeed run tests during the build to "discover" what tests it should run.
I think the libjxl version is less important than which version of Highway we are using. 0.14.0 should have support for SSSE3, which your CPU supports.
There is even a fallback to no SIMD at all, but this is governed by compiler flags. If the "baseline" (what the build flags tell the compiler and Highway to assume) include SSE4.2 and AES, or even AVX2, then it will crash like this.
To debug this, we can watch for build output like:
Compiled HWY_TARGETS: AVX3 AVX2 SSE4 SSSE3 Scalar
HWY_BASELINE_TARGETS: Scalar
If we're not getting to that point because the Highway tests are failing first, we can set the
CMake variable BUILD_TESTING to OFF. The binary that prints the above output is build/third_party/highway/hwy_list_targets -
are you able to build and run that? If so, what's the output?

Thank you very much for your assistance regarding this matter!
I tried building Highway again, and I was able to see such an output!
[  6%] Building CXX object CMakeFiles/hwy_list_targets.dir/hwy/tests/list_targets.cc.o
[  8%] Linking CXX executable hwy_list_targets
make[2]: Leaving directory '/home/kylxbn/.cache/paru/clone/highway/src/build'
[  8%] Built target hwy_list_targets
make[2]: Entering directory '/home/kylxbn/.cache/paru/clone/highway/src/build'
make[2]: Leaving directory '/home/kylxbn/.cache/paru/clone/highway/src/build'
make[2]: Entering directory '/home/kylxbn/.cache/paru/clone/highway/src/build'
[ 10%] Building CXX object CMakeFiles/hwy.dir/hwy/aligned_allocator.cc.o
[ 13%] Building CXX object CMakeFiles/hwy.dir/hwy/nanobenchmark.cc.o
[ 15%] Building CXX object CMakeFiles/hwy.dir/hwy/targets.cc.o
[ 17%] Linking CXX static library libhwy.a
Compiled HWY_TARGETS: AVX3 AVX2 SSE4 SSSE3 Scalar
HWY_BASELINE_TARGETS: Scalar
make[2]: Leaving directory '/home/kylxbn/.cache/paru/clone/highway/src/build'
[ 17%] Built target hwy

Oops! It looks like AVX/AVX2 is indeed being used, but unfortunately, my CPU looks like it does not support it!
In that case, I guess disabling the tests would be useless, since Highway itself is built with AVX support and so, would probably just crash once libjxl uses it?
I will be very willing to provide more information regarding this issue if needed! It might be hard to find such an old CPU like this, anyway :D

@kylxbn thank you for sharing the output!
Unfortunately this rules out one simple explanation (the baseline being set too high).
This output is as it should be: we are compiling for various instruction sets, but they should only be used if actually supported by the CPU.
Can you help gather more information by running gdb highway_test? (that is the one that failed in your initial report, so it was built, but you can also use other tests if they were built in your second build attempt)
It would be helpful to know which instruction is failing (r to run, then disassemble /m 0x1234, where the latter is the address of the crash), and hopefully also a stack trace to show how we got there (bt full).

Sure! I have some learning to do (I know what GDB, disassembly, stack traces, etc., but I have never used GDB before so this will be a new experience :P )
I'll get back as soon as I have the data to report!
Thank you very much for being patient with me! I sincerely appreciate it.

I think this may be a manifestation of https://github.com/google/highway/issues/318 - we had two "enums" mistakenly set to the same value. I am changing it to an enum class to prevent such errors.

I tried to build google/highway again using the latest master branch and I am sorry to inform that the same error still persists.
I tried to run the test executable with GDB but unfortunately, it seems that cmake (or the build system) deletes the executable after building because it is failing:
[ 54%] Linking CXX executable tests/highway_test
CMake Error at /usr/share/cmake-3.21/Modules/GoogleTestAddTests.cmake:77 (message):
  Error running test executable.

    Aborting...
error making: highway-git

with the significant line being
make[2]: *** [CMakeFiles/highway_test.dir/build.make:102: tests/highway_test] Error 1
make[2]: *** Deleting file 'tests/highway_test'

By the way, this is in no way hurrying people or anything! Just asking for guidance.
Is there a way to prevent cmake from deleting the failing executable? Or if google/highway#318 is still not finished, of course I'd be very willing to wait!
Just thought I'd try to be helpful in any way I can.
Again, thank you very much for your patience regarding this issue!

I've got the same issue building the main branch on Debian using "ci.sh", the file wasn't deleted, gdb says
Program received signal SIGILL, Illegal instruction.
_GLOBAL__sub_I_nanobenchmark.cc () at ../third_party/highway/hwy/nanobenchmark.cc:175
175	  asm volatile(

@kylxbn thank you for checking this again! hm, that's surprising. We do have a new tool to help diagnose this. Can you share the three lines in the build output starting with "Compiled HWY_TARGETS:"?
@error256 Thanks for letting us know. The issue appears to be that your CPU does not support rdtscp. I believe that is supported since Intel Nehalem. Out of curiosity, are you running AMD or something else?
This instruction is actually important and hard to replace, but what we can do is check for it at the start of nanobenchmark and fail gracefully; I will do that.

Out of curiosity, are you running AMD or something else?

An old Pentium D, it's more than enough for most tasks, so I still use it sometimes, but usually not for anything like building libraries, I just happened to.

@error256 got it, thanks for sharing :)

FWIW I also experience this error when building 0.5 on a virtualized macos 10.15. Though not on bare hardware - guessing the virtualized cpu confuses the detection.

Any update on this?

If there's still an issue, please re-open on their github.


PhysicsJS activity delete items issue

In the physicsJS activity, the clear function is not working properly.
Expected behaviour: After clicking the clear button and then clicking on any item on the board, that particular item should get deleted.
Actual behaviour: The item doesn't get deleted,  and  instead an item just above it gets deleted (if present).
https://user-images.githubusercontent.com/89119829/158358745-d54c78d1-6000-4f34-bde5-3d9e1d523019.mp4

Are you working on this issue? @AnandChourasia007

Yes

@AnandChourasia007 I can't reproduce the issue.
Could you explain how to do this?

@llaske , I checked this bug some more and found that this issue is only when using edge and chrome. On Firefox, delete activity works fine.
On edge and chrome, the clicks dont work the same everywhere on the object. Clicking on the upperhalf deletes the object above the current object. Clicking on the lower half actually works as expected and clicking on any spot in the lower half of the object deletes it.

Okay I see. I think that it's because to identify the item clicked, the activity check for the box around the item.
Of course for circle item it means that you could delete an item by clicking outside of the item.
It doesn't depend of the browser.
I don't consider it as a bug.

I shall close this issue then. Thanks.


Several CJK strings on the UI are very difficult to read on standard definition monitors due to font weight and size

VSCode Version: Code - Insiders 1.3.0-insider (a2b9738a942237b59cb920940b93a0206f1b61d0, 2016-07-01T19:24:33.352Z)
OS Version: Linux x64 4.4.0-28-generic, Ubuntu 16.04

--locale=zh-CN bold in debug panel headings:

--locale=ko output panel title (it is 출 but it's awfully close to 춤 and 춥):

/cc @dbaeumer @bpasero @rebornix

If this can be fixed by tweaking our CSS with some rules for CJK, we are good. Otherwise the bigger story is to support setting font from a setting. Moving to Brad first to see if we can fix this with some CJK CSS rules in the same way we do it here https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/electron-browser/media/shell.css#L20

How about something like this?
:root {
  --title-scale: 1em;
}
.monaco-shell:lang(zh-Hans),
.monaco-shell:lang(zh-Hant),
.monaco-shell:lang(ja),
.monaco-shell:lang(ko) {
  --title-scale: 1.2em;
}
.tiny-titles {
  font-size: var(--title-scale);
}

@Tyriar that's a cool way of making it bigger with CSS custom properties.  @bpasero if you don't want to go that route, here is some regular CSS that would be equivalent.
.monaco-shell:lang(zh-Hans) .tiny-titles,
.monaco-shell:lang(zh-Hant) .tiny-titles,
.monaco-shell:lang(ja) .tiny-titles,
.monaco-shell:lang(ko) .tiny-titles {
  font-size: 1.2em;
}

Or a SASS approach
.monaco-shell:lang(zh-Hans),
.monaco-shell:lang(zh-Hant),
.monaco-shell:lang(ja),
.monaco-shell:lang(ko) {
  .tiny-titles {
    font-size: 1.2em;
  }
}

I am very afraid of making such a change without sufficient feedback and testing from our CJK users. We never got this complaint from those users, so I would wait for sufficient number of people to complain.
As a reference, where I felt confident of doing a change: https://github.com/Microsoft/vscode/issues/5260

If English was that blurry and unreadable on the UI it would be a bug and an accessibility issue. Given context a user may know what it says naturally, but the text itself should be readable for the sake of low-vision users as a minimum. Also note that I can read Korean and basic Japanese and it's difficult/impossible to make out these characters. I cc'd @rebornix to get his thoughts on it too since he speaks Chinese.

I wonder if in the end it would not be better to invest in a solution where the user can configure these things, either via settings or by being able to write CSS that gets injected.

I am a Chinese user.
I found some parts of the Code use font sizes smaller than 12px
To better readability, font size need 12 px or more

👍 for asking feedback from CJK users. https://github.com/Microsoft/vscode/issues/5260 has a good list of people.

Sounds good.
It may be a good compromise if we didn't want to change the size of portions of the UI to just strip bold for Chinese, that way this:
(1.0 scale zoomed in 400%)

Becomes:

That way at least some detail comes through in the last character.

If anyone wants to test out bigger/less bold titles you can add a style via devtools.

Help > Toggle Developer Tools
Add a new style rule by pressing the plus

3. Paste in this style:
.monaco-workbench .viewlet .collapsible.header .title {
    font-weight: normal;
    font-size: 14px;
}

Here is my two cents:

Font family is more important than font size. Currently we are using Segoe WPC, it's good enough but still far from perfect. If the font size is small, you have a difficult time to recognize the character. I'll put more info here after doing more investigation. If @bgashler1 wants to do any exploration, I can help on this.
Big font size with normal font weight is better IMHO. There is a good UX blog about Chinese Font Best Practice which suggests use 10.5pt (I suppose it's 14px on web page).

Besides, there are two issue related to Chinese Fonts

The min-width of left side panel is too small.

Sometimes I use cmd++ to increase sizes of UI elements but the context menu doesn't change at all. See below, everything is bigger except the context menu

@rebornix looks like you're on a retina display too, so it is a lot better than a standard scale one, also the fonts selected probably differ across platforms, I was showing the one on Ubuntu.

@Tyriar that's true, retina makes it better. If I plug in another Monitor with no 4k resolution, the characters are showing not that good.

Look at 量 next to 变, it's now a grey sold polygon.

We did quite some tweaking on the selected font via https://github.com/Microsoft/vscode/issues/5260, I am surprised to hear that we still have font issues (related to the font family)?

@bpasero let me correct my words, the fallback sequence of font-family with normal font-weight is perfect. From what I observe, the font-family that takes effect on a clean OSX is Hiragino Sans GB, but with bold font-weight, it looks worse than Helvetica or sans-serif. I'm not a Font expert so it may be just a weight issue :)

#5260 was about using the right glyphs for the right locale, not about optimizing for legibility.

@rebornix
Your image looks strange, PingFang SC is not that bold. Have you installed Office? In the fallback sequence I suggested, following the sequence used for Latin, Microsoft YaHei has a higher priority.
Perhaps the fallback sequence can be improved into:

For zh-CN : font-family: "Segoe WPC", "Segoe UI", -apple-system, BlinkMacSystemFont, "SFUIText", "Helvetica Neue", "Noto Sans", "Microsoft YaHei", "PingFang SC", "Hiragino Sans GB", "Source Han Sans SC", "Source Han Sans CN", "Source Han Sans", sans-serif
For zh-TW : font-family: "Segoe WPC", "Segoe UI", -apple-system, BlinkMacSystemFont, "SFUIText", "Helvetica Neue", "Noto Sans", "Microsoft Jhenghei", "PingFang TC", "Source Han Sans TC", "Source Han Sans", "Source Han Sans TW", sans-serif
For ja : font-family: "Segoe WPC", "Segoe UI", -apple-system, BlinkMacSystemFont, "SFUIText", "Helvetica Neue", "Noto Sans", "Meiryo", "Hiragino Kaku Gothic Pro", "Source Han Sans J", "Source Han Sans JP", "Source Han Sans", "Sazanami Gothic", "IPA Gothic", sans-serif
For ko : font-family: "Segoe WPC", "Segoe UI", -apple-system, BlinkMacSystemFont, "SFUIText", "Helvetica Neue", "Noto Sans", "Malgun Gothic", "Nanum Gothic", "Dotom", "Apple SD Gothic Neo", "AppleGothic", "Source Han Sans K", "Source Han Sans KR", "Source Han Sans", "UnDotum", "FBaekmuk Gulim", sans-serif

(preserving the current Windows — Mac — Linux sequence)
Perhaps @Tyriar can consider using weights like 600 to select a slightly thinner variant on CJK locales.

 To be clear you need a special font with a lot of additional data (gridfits, in detail) to tell the rasterizer how to distort the outline to make the characters’ shape legible.
I have a font called Inziu contains such data, but some rasterizers may IGNORE them, like OSX.

@be5invis My OS is OSX 10.10.5 and yes I've Office 2010 for Mac installed. The funny thing is the Font Family that takes effect is Hiragino Sans GB, which look badly in bold. Not sure whether I miss any System update or not :)

UX Meeting Summary:
We will remove all bold font-weight from the CJK characters as a first step.
This occurs in only a few places. This should solve the issue for many people. It’s possible those with lower-dpi monitors or other factors (potentially operating systems with different fonts or font-rendering algorithms) will need us to take an additional step. We can make this initial change on Insiders build and leave the issue open for further feedback. We then can take further action, if needed from there.


ISPN-14834 Implement CRC16 for hash function option

https://issues.redhat.com/browse/ISPN-14834
Applying suggestions from #10901.
We provide a new key partitioner implementation, CRC16HashFunctionPartitioner.

Seems fine to me.
Another question I have is are we properly having the HR client retrieve the CRC16 hash during the PING command?

Not really :/ Once we receive a new topology on the client and create a consistent hash, it always uses murmur.

Updating the Hot Rod clients by adding an option for CRC16, too.

Needs rebase

Rebased.

I think this is ready now.

@jabolina rebase and I'll merge if CI is ok

Rebased. Added a warning message on RespServer if the cache is clustered and not using CRC16.

The server/test failures seem related, the server is unable to start.

@jabolina

The failures were because the CRC16 class was not registered for reflection, so the quarkus tests failed. This should be good now.

Thanks @jabolina


chore: Add Device Shots to Mockup Tools Section

Added Device Shots, a tool that helps you create beautiful device mockups with the screenshot of your website or mobile application for free, to the Mockup Tools section.
Checklist

[x] I made something good today 💐.
[x] I put links in the correct format: [Tool](link) — description.
[x] My description starts with the lower-case letter and ends with the full stop.
[x] I put the tool in the alphabetical order.

Optional

[ ] I added the appropriate labels: free, open-source or mac.
[ ] I put the tool only to one category.
[x] I followed Contribution Guidelines.

Thanks for contributing 😀


Test markdown path IntelliSense

Test for #140602

[x] Mac @IanMatthewHuff
[x] Linux @brettcannon
[x] Windows @hediet

Complexity: 3
Create Issue

Overview
#140602 adds IntelliSense when completing markdown paths. This includes support for:

Completions for other sections (headers) of the current file using # : [text](#header-id)
Completions for files and directories: [text](./path/to/file)
Completions for link declarations:

[text][link]

[link]: ./path/to/file

Testing
Test out the different forms of of links and make sure the completions work as expected. Cases the check

Test the different forms of links listed above
Test both replacement and insertion completions (use setting or hold shift to change modes)
Test in untitled files and loose files
For path completions, make sure the / references the root of the workspace while path or ./path start from the file's current directory

Note that because quick suggestions are disabled by default in markdown, suggestions will not automatically trigger when you type a-z (but should trigger when you type . or /). You can always trigger suggestions using ctrl+space

Even this works nicely (and actually works in the preview):

Well done!

Sorry for the late start. I was OOF Monday / Tuesday. Jumping on this now.

Awesome, all looked good to me. I filed one issue regarding link behavior not scrolling the correct header onto screen, but I don't think that's related to this change.

Opened https://github.com/microsoft/vscode/issues/141610 for file completions including unrelated options like headings. Otherwise works great!


[Issue-2105] Update chainlist (w44)

Related issue(s)

#2105

Is your feature request related to a problem(s)? Please describe.

Update chain-list

Describe the solution you'd like

Update chain-list

Describe alternatives you've considered

No

Additional context

No

🚀 Deployed on https://pr-2109--sw-web-runner.netlify.app

Updated on target branch


wrong reading stride on  uid::uid_hex()

Hi,
this is a bit strange because the UID should be unique but I always get the same ID.
I'm using the UID for the serial number of my USB and I got<PHONE_NUMBER>38333411000000 on multiple STM32L072 :thinking:
I tried it like this:
    // Create embassy-usb Config
    let mut config = embassy_usb::Config::new(0xc0de, 0xcafe);
    config.max_packet_size_0 = 64;
    config.manufacturer = Some("xxx");
    config.product = Some("yyy");
    config.serial_number = Some(uid::uid_hex());

I can see then a device:
/dev/serial/by-id/usb-xxx_yyy_333347053438333411000000-if000

but with different boards it's always the same.
What am I doing wrong? :see_no_evil:

hmm, the memory address of the UID is correct in the PAC for the L072 :thinking:

This works:
fn read_uid() {
    let base_address: usize = 0x1FF80050;

    let mut unique_id = [0u32;3];
    unsafe {
        unique_id = [
            ((base_address) as *const u32).read_volatile(),
            ((base_address+0x4) as *const u32).read_volatile(),
            ((base_address+0x14) as *const u32).read_volatile(),
        ];
    }
    info!("Unique ID: {:08X} {:08X} {:08X}", unique_id[0], unique_id[1], unique_id[2]);
}

probably there is an embassy bug because it probably assumes that all three 32bit words would follow directly after each other.
There even seems to be other inconsistencies like some STM32 having the 3rd word at offset 0x12. The L072 has it on 0x14 :see_no_evil:

This could be security relevant if UID is used as seed to initialize crypto things :thinking:

If you want this fixed, please send a PR instead of invoking the "could be security relevant" card.

If you want this fixed, please send a PR instead of invoking the "could be security relevant" card.

Ok, playing the "told you so" card somewhen in the future :rofl:  Just kidding.
Tbh, I can't fix it because it's above my skill level. I contributed a couple of other things but I guess it would require fundamental changes how the PAC is defined because it just has a base address and a "stride". But it's not prepared for reading from offsets like 0x00, 0x04 and 0x14.
So idk, can't do anything here :man_shrugging:

why close it? it's not fixed


Only add job if it does not exists

If using the jdbcstore and you use persistent jobdatamap, it will be
null the next system restart, because jobdetail is added with replace =
true. Now the system checks if the job already exists.
Furthermore a loadAfter is added for databaseMigration, when you want to
add the databaseschema of quartz using dbm and quartz is loaded before
dbm, it will fail. Loadafter makes sure this does not happen.

Nice! This is a helpful fix. Ran into this issue several times on developers machines when we first added in quartz. Thanks!

Any plans to include this in a new version?

So I have had requests to go to other way around - re-add the jobs and remove the old ones. That seems safer no?

Isn't that going to cause issues if quartz misfires are used? See http://www.nurkiewicz.com/2012/04/quartz-scheduler-misfire-instructions.html
Let's say you have a job that executes at 2am. Your application goes down at 1:55 am and is restarted(and deployed) at 2:05 am.
If the job is not deleted, quartz will execute the job when it starts due to the misfire policy.
However, if the job is deleted, the misfire "event" is deleted as well. As result, when quartz starts it won't execute the job because the misfire is not detected. As result, the task scheduled at 2am will not be executed till next day.
Does this make sense?

understood. I think I may have make it configurable for the user's desired behavior - this feature or the reverse. Also I had a request to check the jobs and see if the application still even has the class it's looking for to run.


Logout Procedure cleanup

Logging out from an account and logging with another will redirect to the homepage without reloading the content, and showing still the data of the previous account.
We need to test and understand where the cleanup/refresh is needed.

The problem is caused by useGetRefreshToken cache never being invalidated
https://github.com/aalto-grades/base-repository/blob/11cdd0c1ceeefb9df6fcc416625639904ea3ab66/client/src/components/auth/PrivateRoute.tsx#L24-L31
The same lines also cause the bug that requires the user to login twice, due to useGetRefreshToken().data being null. Might be due to some bad timings.
One way to fix the wrong account data issue would be to add this line to the logout function.
queryClient.invalidateQueries({queryKey: ['refresh-token']});

https://github.com/aalto-grades/base-repository/blob/11cdd0c1ceeefb9df6fcc416625639904ea3ab66/client/src/components/auth/UserButton.tsx#L23-L28


IBC support in the marker module

Summary
There is a need to create a marker on the destination chain using a source chain transaction
Problem Definition
We are looking to use a restricted marker in a private zone, and then transfer coins from that marker to the destination chain and have them still be restricted.
Without this feature it may be possible to create the marker ahead of time on the destination chain by determining the ibc denom name and creating a restricted marker with that name. However, ibc denoms don't pass the marker denom validation and would require a gov proposal to create them ahead of time. This would be too cumbersome when wanting to frequently create these markers.
Proposal
Add the ability to create a marker on the destination chain using a source chain transaction. Similar to the regular marker creation message, the source message should be able to define if the marker type and permissions

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged
[ ] Contributor assigned/self-assigned

Some initial comments on markers that get created on the destination chain:

Mint/Burn permissions must be disabled for any ibc/ denom
Supply must not be 'fixed' on an ibc denom because the ibc module will be minting/burning amounts when transferred
Permissions can be copied from the source to the destination with the exception of the mint/burn grants.  Alternatively these could be copied to show correct source values but they would still need to be disabled at point of use.
Destination ibc markers should not be editable since they are a reflection of the source.  It may be easiest to enforce this by removal of grants.  The deposit/withdraw/transfer grants are likely still applicable on the destination chain however any smart contracts used for management will have a different address on the destination chain (if they exist at all).
When the source marker is edited (mostly grants) they should be replicated to the destination chain(s).  There may be limitations on these features which should be called out in the documentation.

See #1127

Implemented in #1127

Overview of implementation.

Markers sent from source chain will have a name of type ibc/ on destination chain.  The record will have a DenomMetaData associated with it where Name and Display will be "chain-id/chain-denom" (i.e pio-testnet-1/nhash)  and Description is "chain-denom is from chain-id" (i.e. nhash is from pio-testnet-1).
Markers are created without Mint/Burn permissions.
Markers are only created with transfer authority grants.  Excluding the other grants ensures the marker immutable from the destination chain.
Transfer authority permissions are a reflection of the source chains transfer permissions.  If the source chain's transfer permissions are updated.  The next transfer of the marker from source to dest chain will update those permissions.
allow_forced_transfer flag is reflected on the destination chain for restricted markers.  If the source chain's allow_forced_transfer flag is changed.  The next transfer of the marker from source to dest chain will update that property.

@jtalis PR #1678  implemented all these changes and is now merged to main.


Don't start/stop container with -DskipTests

Before the change, when running mvn clean install -DskipTests the container would still get started/stopped, which takes considerable amount of time and is not needed in such case.
@rsynek could you please quickly check this?

@rsynek any comments? or shall I merge this?

+1 to merge, thanks!


Added targets input

Current dependencies on/for this PR:

main

PR #283   👈

PR #284

This comment was auto-generated by Graphite.


kbfs: files mysteriously stopped uploading

(I also asked this in keybasefriends kbfs chat.)
problem: files are no longer uploading (this is a copy to a mounted kbfs, not git)
question: How can I troubleshoot why it simply stopped uploading?
system: Fedora 32 server (no GUI). Been using Keybase on this system for years, updating consistently.
version: keybase-<IP_ADDRESS>10125164223.f3b21527b9-1.x86_64
situation:

under DirtyPaths, a directory and two files beneath it are listed (i.e., as found in /keybase/public/toddwarner/.kbfs_status)
kbfs fs uploads says nothing is in process
kbfs fs stat [filepath] gives me the file info and NOT_STARTED
there are no conflicts listed in any of the .kbfs_status file that I can see
quota: I have used kbfs for years and years now, but my quota usage is relatively small
devices: I have two devices with kbfs mounted, but I only write to the fs on one device
I waited a long time today for kbfs to sort itself out. It is unchanged after a couple hours.

my log id: 509cffa4aaea798c9a34451c

Strib helped me. This is what we did:

tried shutting down the services, moving the journal directory out of the way, restarting the service, and coping the files again (this failed to resolve the issue).
tried shutting down the services, nuked ~/.local/share/keybase/kbfs_block*, restarting the service, and coping the files again (this worked)

There is a bug ... some where. :)

I'm having the same issue, and tried several things. Each time I restarted the keybase service, I opened the GUI to check things out. From what I've gathered, opening the GUI is necessary in order for the service to restart fully and properly, and especially to recreate the internal files I kept deleting. In order, here's what I tried:n

Remove the kbfs_block_cache folder

$ keybase ctl stop
$ rm ~/.local/share/keybase/kbfs_block_cache
$ keybase ctl start

At this point, the pending uploads were still there (keybase fs uploads). No apparent change.

Turn off the service again, and move the kbfs_block_cache and kbfs_block_metadata folders into a new old folder, as per @taw00's instructions.
No apparent change. The pending uploads were still there, and the files still existed in the local copy of KBFS.

Turn off the service, move the kbfs_journal folder into old/, and delete the two kbfs_block_* files.
This removed my list of recent files from the app, and removed all pending uploads. It also removed the local copies of the files I wanted to upload from KBFS. Good so far.

Tried re-uploading the files. At first, it displayed a very short upload time (as before), and seemed to show no progress. However, while typing this out, it has changed, and shows some sort of progress.

I repeated step 3, because I realized I was uploading more data than I wanted to sit and wait for; and I repeated step 4 with several small files. Unfortunately, that ended my good luck. The uploads list went back to the same behavior, with a very short estimated time, and no progress.

Repeating step 5. This time, it finally allowed uploading! Yay! I verified that I could see the files from another device.

@taw00 Can you please re-open this ticket, as it's still an issue.

Reopening that @jpaugh 's request.

Still an issue here, too.  Started in the last two or three days.  Retried all suggestions in this thread, none worked.


Upgrade d3-color to v3.1.0

Please upgrade d3-color to use version 3.1.0 in order to fix this vulnerability.

The d3-color module provides representations for various color spaces in the browser. Versions prior to 3.1.0 are vulnerable to a Regular expression Denial of Service. This issue has been patched in version 3.1.0. There are no known workarounds.

duplicate of https://github.com/d3/d3-color/pull/100


Expose affinity matrix visualisation to command line and config

The visualisation takes time. Allow for it to be optional (like all other visualisations) by exposing the flag to command line and config file.

This particular visualisation only happens once and plotting a matrix that is already loaded. It should plot within less than couple of  seconds ?

Yeah actually I had a cluster related issue that was slowing it down.
However still, I think it should have an option like all other visualisations (which also run fast, just prevents clogging up user directories with rubbish they don't need).


push code updates so i can play with schem 1

i think n=100, noise=3, d=1 works pretty great.
the result should have the following properties:
p(MGC) <0.05
p(Dcorr) > 0.05
panel 3 should clearly show spiral
also, A & B should have the same sample size.

just pushed all local changes so you can play with.
all formatting issues are solved.

yay!!!!  the intro text is coming along nicely i think!
On Thu, Nov 3, 2016 at 10:33 AM, cshen6<EMAIL_ADDRESS>wrote:

just pushed all local changes so you can play with.
all formatting issues are solved.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/neurodata/MGC/issues/144#issuecomment-258159109, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AACjclbRghr9BACSOoE-oycX8t7K6rGUks5q6fCfgaJpZM4Kn-tw
.

--
the glass is all full:  half water, half air.
neurodata.io, jovo calendar
https://calendar.google.com/calendar/embed?src=joshuav%40gmail.com&ctz=America/New_York


Reviews Accordion

The movie reviews are truncated and when clicked it doesn't show the remaining text.

@lambeboluwatife assign me

@kmahesh18 it has been assigned to you

npm run dev is automatically terminating... is there any issue here other than review accordion

you can check the site or the codebase for issues. and as for the npm run dev terminating, I don't know about that, it hasn't happened before.


Fix linux build

There were a few imports that did not correspond to their filenames, which is a problem on case-sensitive operating systems. This pull request renames them according to the case of their exports, and also adds lodash to dev dependencies which is required in the build process.

Thanks!


When Zabbix is connected to Elasticsearch, latest data are not working

When Zabbix is connected to elasticsearch as backend, it does not return as many information as from SQL. And zabbixctl dies.
Trace from standard installation:
[TRACE] <~ {   "jsonrpc": "2.0",   "result": [     {       "itemid": "54273",       "clock": "1546513053",       "value": "1",       "ns": "491346373"     }   ],   "id": 10 }
trace from elk installation:
{       "itemid": "86196",       "type": "7",       "snmp_community": "",       "snmp_oid": "",       "hostid": "10267",       "name": "Server log file messages for IP <IP_ADDRESS>",       "key_": "log[(ERROR).*<IP_ADDRESS>]",       "delay": "1h",       "history": "90d",       "trends": "0",       "status": "0",       "value_type": "2",       "trapper_hosts": "",       "units": "",       "snmpv3_securityname": "",       "snmpv3_securitylevel": "0",       "snmpv3_authpassphrase": "",       "snmpv3_privpassphrase": "",       "formula": "",       "error": "",       "lastlogsize": "2343015",       "logtimefmt": "",       "templateid": "0",       "valuemapid": "0",       "params": "",       "ipmi_sensor": "",       "authtype": "0",       "username": "",       "password": "",       "publickey": "",       "privatekey": "",       "mtime": "0",       "flags": "4",       "interfaceid": "0",       "port": "",       "description": "",       "inventory_link": "0",       "lifetime": "30d",       "snmpv3_authprotocol": "0",       "snmpv3_privprotocol": "0",       "state": "0",       "snmpv3_contextname": "",       "evaltype": "0",       "jmx_endpoint": "",       "master_itemid": "0",       "timeout": "3s",       "url": "",       "query_fields": [],       "posts": "",       "status_codes": "200",       "follow_redirects": "1",       "post_type": "0",       "http_proxy": "",       "headers": [],       "retrieve_mode": "0",       "request_method": "1",       "output_format": "0",       "ssl_cert_file": "",       "ssl_key_file": "",       "ssl_key_password": "",       "verify_peer": "0",       "verify_host": "0",       "allow_traps": "0",       "lastclock": "0",       "lastns": "0",       "lastvalue": "",       "prevvalue": ""     }
Produced error:
can't obtain history for items of triggers └─ can't obtain items of triggers    └─ json: cannot unmarshal number into Go struct field Item.lastclock of type string

Hi, currently I'm not working with zabbix environments so I can't check your issue, but I will be glad to merge a PR with the fix.

Sent to your email. Thnx

@limosek Yep, just found the underlying reason why it can't unmarshal. Historically, zabbix returns numbers as strings (in quotes), so zabbixctl expects strings, but timestamps in ELK are numbers, so zabbix returned them as float64. I've fixed it, please try last commit. (You might need to run go get in the repository and then make build)

Just tried.
Got same results. Including part of trace. It seems that lastclock is string and it is "0".
     "verify_host": "0",       "allow_traps": "0",       "lastclock": "0",       "lastns": "0",       "lastvalue": "",       "prevvalue": ""     }   ],   "id": 2 } can't obtain zabbix items └─ json: cannot unmarshal number into Go struct field Item.lastclock of type string

@limosek that's really weird, can you please double-check that you have pulled master and run make build and then called ./zabbixctl? What zabbixctl --version tells you?

I really do know nothing about go ;)
./zabbixctl --version
manual build
I did go get github.com/kovetskiy/zabbixctl
Not sure how to force make build.


Nascent support for ghc-lib parsing

This PR updates parseModuleEx to produce two parse trees, the second produced via ghc-lib. No urgency about merging, just wanted to get you an early glimpse at a diff to enable discussion.

@shayne-fletcher-da this makes GHC 8.2 and below support infeasible. I've tweeted to see if that causes problems. I suggest you change hlint.cabal and .travis.yml to exclude the older GHC's for this PR.


Compatibility with PowerMock

Hi,
this lib looks really nice, thanks for sharing. I have a problem with PowerMock though which I am using to make final classes mockable. I do not want to open up all classes I want to mock just for testing.
Thing is powermock-api-mockito still uses Mockito 1.x which is not compatible with 2.x you are using. Is there a way to work around this (apart from forking your project and make it use Mockito 1.x)? Or is there a version of PowerMock wich is already using Mockito 2.x that I am just not able to find?
How do you treat final classes you want to mock?

I haven't used PowerMock before, I normally make a decision between making the class non-final or creating an interface for it. This library does not solve these problems, so perhaps the best thing to do is to indeed make it use 1.x.

This has not been solved has it? Has any1 found a solution, otherwise I might just make a v1.x variant.

There is no intention for this library to support 1.x indeed.

Okay, I'm going to start a 1.x variant then forked from yours :) If any1 is interessed you can find it on my Github.


Get optimal fee currency.

Get optimal fee currency.

it looks like the token addresses are still hardcoded for just 1 chain.


Fix highlight colors of console context menu

Currently, the consoles' context menus are themed (colored the same as their respective consoles), but hovering over each item does not highlight them (clearly, if at all). The menu items themselves seem to work as usual.

Might be fixed by #7

Fixed in c0abffbdfcb0e6dfa9caa578242a41feef33a15f


Create main.yml

Created action to run tests

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@07c6c6a). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #17   +/-   ##
=========================================
  Coverage          ?   74.37%
=========================================
  Files             ?        9
  Lines             ?      320
  Branches          ?       94
=========================================
  Hits              ?      238
  Misses            ?       34
  Partials          ?       48

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07c6c6a...5b0f1e8. Read the comment docs.


Dynamic ss

Tested with a non-published yet jss version from the dynamic-ss branch.

@cvle @iamstarkov @nathanmarks check it out!

@kof should we delete a branch?

yes


Android IoPay stucks on ioTex native voting

Hello, I think I found a bug on the Android app version 0.4.4(388) I would like to report:
I followed the instructions provided here:

I have some native (non ERC-20) IOTX tokens in my app wallet, I want to stake them and vote for a delegate.

When I reach the page "You are about to process ..." I click on Yes, a popup for confirmation appears, I approve that, but the app stucks on loading forever without ever resolving.

If I touch anything on the screen the loading overlay disappears and no staking has been done, nor I see any transaction history.

This repeats over and over again no matter what I do, I tried waiting for hours, but the app is clearly stuck

I'm not sure how to proceed, any help is appreciated. thank you

Thank you for reporting this issue.
Please try iopay desktop for the immediate access. To investigate the Android compatibility issue, we kindly request some more information from you:

Manufacturer: e.g. samsung
Model: e.g. Mi A2

Manufacturer: Blackview
Model: P2 Lite
Android version: 7.0
Android security patch: 5 May 2017
Kernel: 3.18.35+
Build number: P2_Lite_Blackview_20170622

@puncsky thanks for replying, unfortunately, I cannot try iopay desktop because I cannot access my private key on the app wallet. The app freezes as described above also when trying to view my private key. Also, funds withdrawal freezes the same way, so I'm effectively locked out of my funds...
Please kindly tell me an alternative way of retrieving my private key, or provide an app update that doesnt freeze! thanks

@Tabjones Thank for your information
It seems your wallet could not be unlocked to do some actions.
Could you create another wallet, then view its private key on your phone?
Thanks

@puncsky I can create another wallet, but I cannot see its private key, app hangs the same way as the first wallet.

we may need to build debug apk for @Tabjones ' phone to investigate what issue.
How do you think? @puncsky

Hi @Tabjones
We could not reproduce this on the devices we have. Your help is useful to check it out.
Could you help with checking this issue on debugging apk I'll send to your email the latest android iopay version includes some logs and toast of text?

Hi @hunglmtb
Sure, please send it and instruct me on what to do and how to read logs or whatever else you need.

@Tabjones Thank you. Let me prepare

any news?

@Tabjones I sent to your email<EMAIL_ADDRESS>Could you take a loo

@hunglmtb ok, sorry your mail was sent to the spam by google, so I didn't see it at first! I'll check it out

@hunglmtb I installed the debug app. It seems like it is working. I get some "getAccountByWallet" messages with an address and success messages. this appears when I try to show my private key. Didnt try the voting because I dont have any funds. With the fact that this version is working for me is it possible to update the playstore app and try to retrieve my locked out funds on the other app?

On Sun, 23 Feb 2020 at 15:25, hung le<EMAIL_ADDRESS>wrote:
Thank for your checkingThat means you can view your private key?
If yes, there are some configurations between release and debug version so it couldn't decode account. We need more debug to find which cause the problem, then release an update one. I will ask some checking on your mobile next some days.Thanks for your help

On Sun, Feb 23, 2020, 9:35 PM Federico Spinelli<EMAIL_ADDRESS>wrote:
Ok, thank you. Yes I can see my private key. But It might not just be configurations between builds. My release playstore version is v0.4.4(388), while the debug you gave me is INTERNAL_BUILD(392)
Looks like you are missing some versions on playstore.

On Sun, 23 Feb 2020 at 15:44, hung le<EMAIL_ADDRESS>wrote:
There's a apk version here https://iopay.iotex.io/Could you install apk release one and  view private key on temporary account like debug one?Ps: apk version will not overwrite play store one on the phone
On Sun, Feb 23, 2020, 9:39 PM hung le<EMAIL_ADDRESS>wrote:
Thank for your info. Let's check it out

On Mon, Feb 24, 2020, 12:21 AM Federico Spinelli<EMAIL_ADDRESS>wrote:
I've already checked the apk from your website some days ago, I can see the private key with that, but I was unable to vote the app was freezing.

On Mon, Feb 24, 2020 at 12:37 AM hung le<EMAIL_ADDRESS>wrote:
Got it. Nevermind vote on apk version.To check it out, we will release an update version on play store and you will update and do some actions such as: view private key or stake, vote... Of course, it still not work but will log exceptions running time. We will see what happens with your device and release a patch for this issue and send you a notification of this update when it's ready. Pls feel free if you have any suggestionThanks

ok, thank you, I will wait for it

any news? I didn't get any update on playstore

let me ask @hunglmtb

@Tabjones v0.4.9 is ready on google play. Could you update then try?

closing for now unless there is negative feedback


[TRITON-MLIR][BACKEND]fix atomic_rmw for vector

Is it available to add some tests to cover the issue found?


Danger and ktlint

          3 Messages

:book:
Please add labels to this PR

:book:
This PR does not have any assignees yet.

:book:
This PR does not refer to an existing milestone

  Generated by :no_entry_sign: Danger


fix get account bug

Codecov Report

Merging #124 into release-0.2 will decrease coverage by 0.02%.
The diff coverage is n/a.

@@                Coverage Diff                @@
##             release-0.2     #124      +/-   ##
=================================================
- Coverage           39.6%   39.58%   -0.03%
+ Complexity           598      597       -1
=================================================
  Files                140      140
  Lines               4416     4416
  Branches             322      322
=================================================
- Hits                1749     1748       -1
- Misses              2536     2541       +5
+ Partials             131      127       -4

Impacted Files
Coverage Δ
Complexity Δ

...rc/main/java/com/webank/wecross/resource/Path.java
65.51% <0%> (-3.45%)
11% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78aee52...fc13d55. Read the comment docs.


prevent NullRefrenceException from firing

Console.WriteLine($"Request Params: ProjectFilePath {request.ProjectFilePath}"); will fire NullReferenceException when request was null.

Thanks for the pull request, if you need any help getting anything set up then feel free to let me know. It would be great having more help with this 👍


Flyer returns after being dismissed in FireFox

Issue Description

open up FreeCodeCamp.com in firefox, sign in, and make sure you have at least 5 brownie points.
you should see the "flyer" at the top of the page with a promotional message like "check out our forum"
dismiss it
refresh the page. It comes back.

This is a problem with our use of local storage.

Can I take this?

@flipsyde606, sure :wink:
Check our Guidelines for Contributing and if you need any assistance reach out to the Contributors Chat room.


Development: Enable Static Code Analysis in Local Continuous Integration for Java

Checklist
General

[X] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[X] I chose a title conforming to the naming conventions for pull requests.

Server

[X] I followed the coding and design guidelines.
[X] I documented the Java code using JavaDoc style.

Motivation and Context

At the moment, the LocalCI + LocalVC setup doesn't support Static Code Analysis, which is an important part of the automatic assessment of programming exercises in Artemis.
Description

Static Code Analysis was enabled. The SCA configuration files for Java were already given in the resources directory. I had to add the path where to find the result files in LocalCIBuildJobExecutionService and also add the commands to the script for Gradle and Maven. Lastly, by adapting and refactoring the code from https://github.com/ls1intum/static-code-analysis-parser, we can now parse the result files for various languages and give the user feedback for their submissions.
If we enable SCA for more programming languages in the future, we will already have the corresponding parsers, too.
Steps for Testing

Prerequisites:

1 Instructor
1 Student
1 Programming Exercise with Static Code Analysis enabled

Create a Java Exercise with static code analysis enabled. Add some code that should trigger some warnings, for example, an uninitialised variable. Submit the code and check if you get a SCA warning.
Testserver States

[!NOTE]
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked

Review Progress

Performance Review

[ ] I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance
[ ] I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

[ ] Code Review 1
[ ] Code Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

Exam Mode Test

[ ] Test 1
[ ] Test 2

Test Coverage

Screenshots

Tested on ts6, warnings appear:

We already have the library https://github.com/ls1intum/static-code-analysis-parser. Please don't duplicate the parsers into Artemis, but use the parser library instead. If adaptations and refactorings are necessary, please open a PR over there.

I had talked to Stephan, and he said that I should copy the code as the deployment with Maven Central is a hassle and will be unnecessary soon when we stop supporting bamboo and perhaps even Jenkins.

I tried to test it on legacy ts2 but it doesn't complain about anything. Is there something besides online editing + static code analysis that i need to activate?

TS2 doesn‘t have the LocalCI and LocalVC system connected. Check https://confluence.ase.in.tum.de/pages/viewpage.action?pageId=25252245. I think only ts3, ts6 and ts11

Tested on TS3, works with the given examples. However, uninitialized array variables don't trigger any warnings. Is that currently intended behavior?

I just tested it, and it should warn you if you try using that array. Else it just tells you to avoid using unused variables.

Added a missing test that should cover the ParserException class. Retested locally and everthing still works. Tests added by you also look good to me.


[Discussion] API time format

At the moment we use the ISO 8601 format for dates and times returned internally and over the API. The date format has to be converted to epoch time when sqlite is used since the database doesn't support date/time formats. That means that every read or write operation in sqlite has to do a date conversion. I was wondering if there would be a benefit in using epoch time format for all internal timestamps and only convert them when needed or shown to a user? Thoughts?
ISO 8601
{
    ...,
    created_at: "2014-04-24T11:25:42.451Z"
}

Epoch Time
{
    ...,
    created_at:<PHONE_NUMBER>
}

If we are going to change to epoch time we would need to change the date/time fields in mysql. So this is probably an issue for the future milestone since datatype changes are not supported yet.

I know this has been closed, but, just wanted to comment that after all the discussion ghost exports use microseconds from epoch. If I understand it right, it is the worst choice as it's not human readable, nor standard, and have known issues.

@eloyesp interesting, it actually depends on which database you use because the export does nothing more fancy than an SQL query on all the tables transformed into JSON. It's never really been an issue because the export is imported into Ghost which can handle it, but I guess that it would be annoying if you were trying to do something else with exports.

@ErisDS The issue here is that you are not thinking in other applications, but ghost itself will eventually became another application (it will evolve), some people will try to import what they exported and it will fail.
I think that the export function should be handled as an output, and should follow the rule of "Generous on input, strict on output"

@eloyesp why not submit a fix :)


haskellng: Fix amazonka-core on 7.8

Required adding a flag to the generic builder to build Setup.hs with
core packages even if there is an override in buildInputs, to break
circular dependencies.

@peti ping

OK, looks fine to me.

OK, I'll merge to master with a minor tweak


Make 'opctl node delete' delete opctl containers from the docker runtime

This PR ensures that if using the docker runtime and opctl node delete is called, all opctl containers will be deleted. This is consistent with the new qemu runtime where we delete the opctl VM when opctl node delete is called.

related https://github.com/opctl/opctl/issues/658


Move kfp latest version to a subfolder and add OWNERS file

@sarahmaddox I think this will better reflect ownership. Anyone doing pipelines release will need ownership to this file.
Currently only setting me as reviewer to guard the format.

This change is

/assign @sarahmaddox

Thanks!
Example preview: https://deploy-preview-1326--competent-brattain-de2d6d.netlify.com/docs/pipelines/standalone-deployment-gcp/
/lgtm
/approve


Odd behaviour if using s DataTemplateSelector (yea, I know the issues here are just ignored but maybe someone else had the same problem or a solution for it...)

When using a DataTemplateSelector, the FlowListView Control seems to be randomly choose which template is used for which cell - even if it is 100% clear and correctly served by the template selector (same template instance for additional requests on the same item; not more than 8 on Android).
Here is my current template selector:
public class SearchableDataTemplateSelector : DataTemplateSelector
{
	public DataTemplate ItemTemplate { get; set; }
	public DataTemplate EntryTemplate { get; set; }
	public DataTemplate OtherTemplate { get; set; }

	protected override DataTemplate OnSelectTemplate(object item, BindableObject container)
	{
		switch (item)
		{
			case Item _:
				return ItemTemplate;
			case Entry _:
				return EntryTemplate;
			case Other _:
				return OtherTemplate;
		}

		return null;
	}
}

Item, Entry and Other are all Models on it's own and all implement a interface which is the type of my bounded list. But the FlowListView should not care about it anyway and just use the served template for the cell... currently it using it random on the first call (if the result list is a mixed result) and all other results using the same template for the same list index (even if the model on the slot changes it type due to a list modification). I use this for a whole App Search and I want to display each entry with it's own template.

Would be great if @daniel-luberda would care more about the issues and problems of those controls.. But there is simply no option currently except for a self implementation.

@Sebastian1989101  I think you need to use FlowTemplateSelector.
I just implemented the selector yesterday and it works fine.
    public class NewsTemplateSelector : FlowTemplateSelector
    {
        protected override DataTemplate OnSelectTemplate(object item, int columnIndex, BindableObject container)
        {
            if (item is NewsListItemModel newsListItemModel)
            {
                if (true)
                {

                    switch (newsListItemModel.Type)
                    {
                        case NewsListItemModelType.Normal:
                            return new NewsItemTemplate();
                        case NewsListItemModelType.Header:
                            return new NewsHeaderTemplate();
                        default: throw new NotImplementedException($"{nameof(NewsTemplateSelector)} does not have a template for type: {newsListItemModel.Type}");
                    }
                }
            }

            throw new NotImplementedException($"{nameof(NewsTemplateSelector)} did not receive a {nameof(NewsListItemModel)} item");
        }
    }


Add New Activity : Land-io

Activity ID:<PHONE_NUMBER>90969345

The package will be updated within a week.


Bug: On resuming from sleep, sessionState sensor reports "Locked" indefinitely, even though PC is unlocked.

Describe the bug
I use this program to report my PC's state to Home Assistant via the sessionState sensor. 90% of the time it works correctly, though sometimes after resuming from sleep it will be stuck reporting "Locked" when the device is actually unlocked and in use.
One faulty sequence looks like this:
6:26pm - PC transitions from Unlocked to locked. Sensor updates.
6:32pm - PC goes to sleep. Sensor becomes "unavailable", as expected
6:35pm - PC is worken up from sleep and unlocked. Sensor updates from unavailable to locked.
7pm - PC has been in use for the last half hour, but sensor still saying locked.
I have a VPN running on the PC, so when resuming from sleep it has to reestablish a VPN connection, so the connectivity is a little unstable for the first 30 seconds after boot. But after that it should be able to report unlocked back to Home assistant.
Misc info (please complete the following information):

Windows build (ideally screenshot/info of winver.exe output):
Version 21H1 OS Build 19043.1706
Windows' UI language:
English
HASS.Agent version:
2022.11.4

Please check what's applicable (multiple answers possible):

[x] Installed via installer
[ ] Installed manually
[x] Problem occurs in HASS.Agent
[ ] Problem occurs in Satellite Service

Logs
Attached debug logs of the half hour in question that I detailed above.
[2022-05-31] HASS.Agent_20220531 - debug.log
Thank you!

Hi @karwosts,
Thank you for the detailed bug report :) Could you please confirm that when the fault occurs, HASS.Agent has the right value - you can do so by opening the 'local sensors' window and checking the 'last known value' column:

If it is (and I'm guessing/hoping it is), it's because the system that keeps HASS.Agent from sending the same values fails due to the temp. lack of connection. I'm developing a better system that continuously compares HA's values with that of the agent (hassagent-5), when that's done, this issue will be fixed as well.
The Error checking for updates: API rate limit exceeded error in your logs is new to me, and very interesting, guess I'll have to consider not using GitHubs API anymore.

Thanks, that is (relatively) good news - means the sensor works. Hang tight for the fix :)

Just an idea, but would it make sense to just resend all sensor values anytime MQTT goes from disconnected to connected?
2022-05-31 18:35:34.809 -07:00 [WRN] [MQTT] Not connected, message dropped (won't report again for 5 minutes
2022-05-31 18:35:52.951 -07:00 [INF] [MQTT] Connected
Seems like if you just updated the sensor values here after MQTT connected that might have resolved the issue.
I think I read that you didn't want to send updates continually because that was spamming the MQTT broker, though I'm not sure if spamming HA with polling requests to check the current sensor status is really that much better. If polls are infrequent, then the sensor could have the wrong value for a few minutes after resume from sleep, which is not quite ideal
Thank you very much for the quick updates.

It actually already does that (otherwise it'd fail a whole lot more), but sometimes the package's lost even though it looks sent.
I already request sensor data on intervals for the quick actions, and that doesn't slow anything down. But it could have a somewhat smart algorithm, for instance: after a disconnect, increase the polling interval for 5 minutes.

I've merged all tickets related to this issue into a central pinned one: [#204]
Closing this one to keep it in one place.


Fix UDS tests after signal merge

Description
Fixes https://github.com/Lind-Project/lind_project/issues/350
Fixes the test suite, all tests are successful now.

Changed test uds-serverclient from deterministic to non-deterministic due to order of output being different within runs
Added non-deterministic checks (python file) for uds-serverclient
Changed uds-socketselect test to allow different order of outputs between lind and native output

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Full test suite - Successful
Checklist:

[x] My code follows the style guidelines of this project
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] Any dependent changes have been added to a pull request and/or merged in other modules (native-client, lind-glibc, safeposix-rust)

LGTM! Great work!