How to add a private toolchain (or any other lua script)

I have two cases where I need to make a tweaked toolchain - clang-analyze, and afl. In both cases, these programs work by replacing clang (or gcc) with their own wrapper program, which runs the regular compiler, and then add their own magic on top of that.
When using tundra, is there some official mechanism for defining your own toolchain (similar to clang.lua, or gcc.lua), which is part of your source code tree, and not part of the stock tundra distribution?
The best thing I've come up with so far is this (example here is for afl):

Create a file in my project: build/tundra/tools/afl.lua
Add a new Config that uses the afl toolchain.
Run tundra like so, to compile my project called "Test": TUNDRA_LUA_PATH=`pwd`/build/?.lua tundra2 linux-afl-release Test

It would be useful if one didn't need to setup the TUNDRA_LUA_PATH environment variable. Does it make sense that one could add some kind of lua call, which would add a new directory to the lua search path? You could then call that function at the top of your tundra.lua file, to add in your project-specific lua scripts.
I know this may seem a bit pedantic - I mean what's wrong with just setting TUNDRA_LUA_PATH for this niche case? However, I think it would be a good principle if one could easily add extra augmentations on top of tundra, in the form of lua scripts that are private to the source tree.
afl.lua contents:
module(..., package.seeall)

function apply(env, options)
  tundra.unitgen.load_toolset("gcc", env)

  env:set_many {
    ["CC"] = "/home/ben/dev/afl-2.51b/afl-clang",
    ["CXX"] = "/home/ben/dev/afl-2.51b/afl-clang++",
    ["LD"] = "/home/ben/dev/afl-2.51b/afl-clang",
  }
end

You can add tool paths using the ScriptDir property.  This way they’re loaded just like built in tools and there’s no need for env hacks. Let me know if this doesn’t work for you.

Sorry, ScriptDirs is the appropriate spelling. It adds to the Lua path and anything found there will be importable just like built in tools.

Thanks - that's exactly what I was looking for. Sent a one character PR that fixes the typo in the manual.


Supporting async validation in createServerValidate

Changes
Currently, server-side validation cannot be performed asynchronously. This is particularly inconvenient when using external validation adapters like Zod to check database values against form inputs.
Client-side validation can already be performed asynchronously, and since server-side operations are generally expected to be asynchronous, the impact of this change should be minimal.

[x] Change validatorAdapter().validate() to validatorAdapter().validateAsync()
[x] Fixed onServerValidate property is not supported for validatorAdapter (Ex. Zod) TypeScirpt types

Sample Code
"use server";

import {
  ServerValidateError,
  createServerValidate,
} from "@tanstack/react-form/nextjs";
import { zodValidator } from "@tanstack/zod-form-adapter";
import { redirect } from "next/navigation";
import { z } from "zod";

const serverSchema = schema.extend({
  firstName: z
    .string()
    .min(8, {
      message: "Server: First Name must be at least 8 characters.",
    })
    .refine(async () => {
      // In the actual implementation, queries to the database will be performed here.
      console.log("Server: Validate First Name...");
      await new Promise((resolve) => setTimeout(resolve, 1000));
      return true;
    }),
});

const serverValidate = createServerValidate({
  validatorAdapter: zodValidator(),
  // TypeScript error on following line
  onServerValidate: serverSchema,
});

export default async function someAction(prev: unknown, formData: FormData) {
  try {
    await serverValidate(formData);
  } catch (e) {
    if (e instanceof ServerValidateError) {
      return e.formState;
    }

    // Some other error occurred while validating your form
    throw e;
  }

  // Your form has successfully validated!
  console.log(formData.get("firstName"));

  redirect("/");
}

TypeScript type implementation was referenced from the following code:
https://github.com/TanStack/form/blob/75d25dd16790f88768da75b48a87f0cfc0211fc3/packages/form-core/src/FormApi.ts#L44-L64

Thanks for the PR! Looks good so far but let's doublecheck, have you tested also with validator adapters like zod? Could you also write some unit tests for that?

@Balastrong
Thank you for your feedback!

I have updated the branch to follow the latest main and added tests for the zod-form-adapter. Please review them.
There are type tests for the FormApi in the zod-form-adapter. Do you think type tests for createServerValidate are necessary?
I haven’t added tests for Valibot and yup yet. Are these required? Also, there are no existing tests for createServerValidate within react-form itself. Should I add them as well?

Looking forward to your guidance!

@Balastrong
I don't have time to act on it right now so I won't be adding any new tests in this PR.
Thanks for checking.

I'll take care of that and merge then, thanks! :)


Scrolling on mobile (Dashboard) moves the widgets around

Due to the touch event, the widgets get moved, making scrolling on the dashboard kind of tough.

We are thinking about adding a drag handle to the widgets to avoid this issue.
Thanks for reporting!

Sweet! That would definitely help!

Duplicate of #497.


rescaling animation lines and scales in line charts can create some disorienting effects

Describe the bug
the scales and lines rescale at different speeds, which can cause jumping around or rubber-band ish effects, particularly when toggling a filter that removes/adds a lot of data.
See e.g this clip, where clicking the filter (which removes data) cause the line to immediately drop nearly to the baseline, then to grow back up; it's not clear what the animation is showing in that case -- am I looking at less or more? Likewise when the filter is untoggled, which adds data: the line immediately jumps above the top of the plot viewport, then the line animates in from the top, which kind of creates an impression of the values on the line getting smaller (data being removed).
https://user-images.githubusercontent.com/2380975/182660965-10ed7ce9-6ca3-4eaf-940c-ebb912ef5668.mp4
Expected behavior
I'm not really sure, but just brainstorming here: I think what I would want an animation to do overall is to put the new line I'm looking at in the context of the old line. By animating the line and the scale at the same time, this can be a bit muddy, and sometime the animation can feel like confusing blur of motion rather than helping to contextualize.
One idea to try might be something like: rather than updating the existing line to have new values, add a second line to the plot for the new values and rescale the whole plot to fit that new line while fading out the old line. Something like that might help establish the scale of the pre and post filter lines with an animation that is a bit more "monotonic" (i.e. the animation would only convey one motion of growth or shrinkage, not the up-then-down or down-then-up motions in the clip above). This might only be needed for very large changes -- I have no idea what the threshold would be, but I could imagine updating the existing line might work if the scales are basically the same, and that the "monotonic" treatment might only be needed if the scales are very different (making this up: maybe 2x or more?)

yeah this is not ideal as-is and is something we had to punt on. There are a few animation interactions that are not really working here imo.

Think I have a straightforward solution here. When the underlying data changes:

first, rescale the x axis if needed.
if the y-hull of the new data is larger than the old data, then we rescale the y axis, then the data.
if the y-hull of the new data is smaller than the old data (meaning the old data gets clipped) we can rescale the data first, then the y axis. This will show what's happening while preserving the overall shape.

Would need to try this out and see how it goes.


splice.nix: remove toplevel {build,host,target}Platform in __splicedPackages

These should have been removed in ecab3ede but were not discovered.
Since these were only in __splicedPackages they were only available in callPackage, now that they are removed the entries in aliases.nix will take over.
https://www.github.com/NixOS/nixpkgs/blob/e056730f13ab6ed6d8325d4343752f7f9b9bf60b/pkgs/top-level/aliases.nix#L1817

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Ran outpaths.nix locally so now all the uses should be gone.


[Feature Request] Add multiple schedules to a function

My actions before raising this issue

[x] Followed the troubleshooting guide
[x] Read/searched the docs
[x] Searched past issues

When using cron, if you need to schedule a job at, say, every 90 minutes, you actually need two cron schedules to accomplish that.
To accommodate that, I think it would be fairly easy to make the schedule annotation a comma-separated list.
Expected Behaviour

To schedule a function to run every 90 minutes: schedule: "0 0-21/3 * * *,30 1-22/3 * * *". AFAIK the timezone is always UTC.
Current Behaviour

I don't think the cron connector supports multiple schedules for a single function.
Possible Solution

Comma separated list of schedules.
Steps to Reproduce (for bugs)

Context

I have a job that needs to wait 90 minutes between attempts.
Your Environment

FaaS-CLI version ( Full output from: faas-cli version ):

Docker version docker version (e.g. Docker 17.0.05 ):

Are you using Docker Swarm or Kubernetes (FaaS-netes)?

Operating System and version (e.g. Linux, Windows, MacOS):

Code example or link to GitHub repo or gist to reproduce problem:

Other diagnostic information / logs from troubleshooting guide

Next steps
You may join Slack for community support.

this is not a bug. i'm not sure what derek's complaining about here, because I didn't edit the template.
i'm not going to fill in bug report information just to appease this bot, because this is not a bug report.

I looked at the underlying cron library that this connector uses, and it looks like it supports @every <duration> schedules. Testing.

It looks like the @every syntax works. I'll reopen if I have any more problems.

So was no change required in this instance?

I've turned off that Derek feature :upside_down_face:

So was no change required in this instance?

it was not. the upstream cron scheduling package covers cases such as @every 1h30m. If you need precise scheduling of a function, such as every hour and a half at the 00 and 30 minute-marks, you'd need multiple schedules, though.
@every is based off when you started scheduling, so if you choose 1h30m, it will be 1h30m from when the schedule began. No way to choose specific times.


[HOLD for payment 2024-04-25] [$250] Tax - Not here page opens when clicking currency in tax amount in transaction thread

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.62-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Issue found when executing PR https://github.com/Expensify/App/pull/39562
Action Performed:

Go to staging.new.expensify.com
Go to workspace chat that has tax enabled
Create a manual request with tax
Go to transaction thread
Click Tax amount
Click on the currency

Expected Result:
If the currency for tax amount is not supposed to be accessible in transaction thread, the currency should not be clickable (production behavior)
Actual Result:
The currency in tax amount in transaction thread is clickable, and it leads to not here page instead of currency list
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/8a02e0a8-a3fa-4085-8a50-6d7de8f860b5
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~015297f4039458a835
Upwork Job ID:<PHONE_NUMBER>330332672
Last Price Increase: 2024-04-11

@NikkiWines  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #wave-collect - Release 1

Proposal
Please re-state the problem that we are trying to solve in this issue.
The currency in tax amount in transaction thread is clickable, and it leads to not here page instead of currency list
What is the root cause of that problem?
We use the IOURequestTaxAmountPage for edit flow now but we always pass the action as create here
https://github.croom/Expensify/App/blob/8f90c2567f020ed924a96593244727aace9a7d72/src/pages/iou/request/step/IOURequestStepTaxAmountPage.tsx#L109
What changes do you think we should make in order to solve the problem?
We should use action in route prop here instead of always passing create
 Navigation.navigate(
    ROUTES.MONEY_REQUEST_STEP_CURRENCY.getRoute(action, iouType, transactionID, reportID, backTo ? 'confirm' : '', Navigation.getActiveRouteWithoutParams()),
);

https://github.croom/Expensify/App/blob/8f90c2567f020ed924a96593244727aace9a7d72/src/pages/iou/request/step/IOURequestStepTaxAmountPage.tsx#L109
What alternative solutions did you explore? (Optional)
NA

Thanks for investigating @nkdengineer. Since we don't want the currency to be editable for the tax field, let's go with your alternate solution.

@mollfpr The PR is ready.

Should be fixed

So is there anything we need to do here or can we just close?

We'll need to do a payment to @nkdengineer / @mollfpr for the fix

@mollfpr reminder about the checklist so we can pay in 2 days.

@nkdengineer sent you an offer: https://www.upwork.com/nx/wm/offer/102031741. Please ping me on this issue when you've accepted.
@mollfpr waiting on checklist for you.

Ok @nkdengineer has been paid.
@mollfpr still waiting on the checklist for you.

Sorry for the delay 🙏

[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

No offending PR.

[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

The regression step should be enough.

[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Go to the workspace chat that has tax-enabled
Create a manual request with tax
Go to the transaction thread
Click Tax amount
Click on the currency
Verify that: the currency should not be clickable
👍 or 👎

Regression test issue here: https://github.com/Expensify/Expensify/issues/391684
Payment Summary:
@mollfpr requires payment through NewDot Manual Requests - C+ - $250
@nkdengineer paid through upwork - C - $250
@mollfpr please request on NewDot.

$250 approved for @mollfpr


BUG: OpenVV() relies on global 'element' variable

if you rename 'element' to 'el' in demo.js
`var openvv = new OpenVV(), el = document.getElementById('elementToMeasure');
var executor = openvv
.measureElement(el) ...`
you will get exception:
MeasurementExecutor.js:164 Uncaught ReferenceError: element is not defined     at MeasurementExecutor._instantiateTechnique (MeasurementExecutor.js:164)     at Array.map (<anonymous>)     at MeasurementExecutor._selectTechnique (MeasurementExecutor.js:153)     at new MeasurementExecutor (MeasurementExecutor.js:34)     at OpenVV.measureElement (OpenVV.js:28)     at demo.js:22
I have a patch PR for it, will add it a bit later...

We could wrap the demo code in an IIFE, but it's really just meant to be a simple example of how to use library. This isn't source code for the library itself.

fix PR https://github.com/InteractiveAdvertisingBureau/openvv-html/pull/11

@jdreetz there is a bug (typo) in MeasurementExecutor - using global var element instead of this._element
see PR for a fix.

Good catch! I misunderstood your original comment.


Adding Couchdb views from blueprint

Adding Couchdb views from the blueprints are showing error... Tried with accessing the main app as 'current_app' but showing error 'RuntimeError: Working outside of application context.'
My Code from blueprint for adding/syncing couchdb views are as following:
from flask import current_app as app
manager = CouchDBManager()

with app.app_context():
    manager.setup(app.app_context())
    manager.add_viewdef(my_couchdb_view_from_blueprint)
    manager.sync(app.app_context())

The error message is as following:
RuntimeError: Working outside of application context.
This typically means that you attempted to use functionality that needed
to interface with the current application object in a way.  To solve
this set up an application context with app.app_context().

Please use IRC or Stack Overflow for support questions.


feat: check midway version

Codecov Report
Base: 88.34% // Head: 88.40% // Increases project coverage by +0.05% :tada:

Coverage data is based on head (b9e49bb) compared to base (80349b6).
Patch coverage: 91.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #303      +/-   ##
==========================================
+ Coverage   88.34%   88.40%   +0.05%
==========================================
  Files          40       40
  Lines        4085     4095      +10
  Branches     1195     1197       +2
==========================================
+ Hits         3609     3620      +11
+ Misses        436      435       -1
  Partials       40       40

Impacted Files
Coverage Δ

packages/serverless-spec-builder/src/wrapper.ts
87.06% <0.00%> (ø)

packages/cli-plugin-check/src/index.ts
93.38% <100.00%> (+0.32%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


options.parser default value doesn't apply to request function (only get, post etc.)

The documented options.parser default value of restler.parsers.auto doesn't apply to the request function, but only get, post etc.
It is set in shortcutOptions which is only called from the method-specific functions.
I'm not sure whether the behaviour needs to change or just a hint in the README.md where under "Options" it says

parser A function that will be called on the returned data. Use any of predefined restler.parsers. See
parsers section below. Defaults to restler.parsers.auto.

Just ran into this today. The documentation could be more clear about how request doesn't behave like the other methods, in that options is a required argument, and there is no default parser. Even better, it would be nice for request to behave identically to the shortcut methods.


Several issues with using this plugin

The security/detect-non-literal-fs-filename rule reports fs.${whatever} regardless of whether that's what i'm using or not. For example, i use jsonFile a lot, so an error with jsonFile.readFile gets reported as fs.readFile, when there is no reference to fs on that page. Sure, the error probably still applies, but it's confusing when the error output doesn't line up with the actual code

It's unclear, even with the linked resources, what exactly needs to be done to resolve an issue, or even what the issue is. With the above error, I was not at all sure what the problem really was or how to resolve it. For reference, that file (and just about all instances of that error on my code) are just using paths like this: ${process.cwd()}/path/to/json. I have a hard time seeing how this is exploitable?

I'm getting several unsafe regex errors. Most of them were common regexes (verify zip codes, stuff like that). So as recommended, I used the OWASP link to replace them with their safe variants. Even after replacing them, the error still persists

detect-object-injection. As this test is currently designed, it's completely overwhelming

I really want to use this plugin to easily catch minor security issues, but as is, i can't imagine it doing anything more than frustrate people

1 - This is a known issue unfortunately. If you look at the source you can see that we are only looking for method calls.  If somebody wants to track those references we would accept a pull request.
2 - We could probably improve the documentation here. To clarify for you it's simply pointing out that it could be user input in one of those calls (a variable vs a literal string), which could or could not be bad depending on the context.
3- We process these using a module called safe-regex which has known false positives AND false negatives. We use this rule to trigger re's that may need further in
4- Yup. this is a pretty overwhelming one. We have used it to find issues but it's most certainly a needle in a haystack type assessment when this rule is enabled.
Thanks for your feedback. We use these rules to audit code and identify issues quickly for human review. We find them useful. I'm sorry they frustrate you. We would love them to be better and unless we find significant time to invest or get pull requests to do more state tracking with the underlying ast we can't do much more than what we have.

@rossPatton about safe-regex, it may also report issues due to a potential complexity detected.

I think 1 and 2 can probably be fixed in #109.


Improvement: Re-design Lecture Overview

Problem Description
The previous lecture UI displayed all content on a single page, resulting in long scrolls and a cluttered user experience. This layout was not aligned with the iOS app's design, where lecture details are displayed in a bottom sheet for better organization and user interaction.
Changes

Redesigned the lecture UI to display details in a bottom sheet instead of a single scrolling page.
Made lecture unit headers clickable to trigger the bottom sheet.
Bottom sheet dynamically shows content based on the selected unit (e.g., text, video, etc).
Added scroll support for content overflow and improved typography, spacing, and alignment.

Steps for testing

Navigate to the lecture overview screen in the Android app.
Verify that the headers for each lecture unit are displayed correctly.
Click on a header to open the lecture details in a bottom sheet.
Ensure the bottom sheet content is rendered appropriately for different lecture unit types (e.g., text, video, etc).

Screenshots
Old and new version added for easier comparison
https://github.com/user-attachments/assets/42150565-7626-4585-bac3-bc27c207d5fb
https://github.com/user-attachments/assets/a889b0fb-66fb-41de-b989-d318da818408

Code looks good to me, I just have two minor concerns.

Do you know how common it is for the LectureUnits to have such long descriptions? I checked for this semesters "Patterns in Software Engineering" and the descriptions are quite short, so opening the BottomSheet in fullscreen feels quite overkill, as there is mostly just the title and a single button in the bottom Sheet. If this is the case for most lectures, I think it makes sense to open the BottomSheet without the skipPartiallyExpanded, even if it deviates from the iOS behaviour.
Instead of displaying "Attachement" "Exercise", "Text" etc in the LectureOverviewTab, I think the LectureUnit title should be displayed. (This should also fix the failing tests)
Follow-up: PDFs are currently only displayed as button that can be clicked to download it, but it is not possible to view it within the app. As soon as https://github.com/ls1intum/artemis-android/pull/239 is merged, I think this could be implemented similarly and would be a nice follow up :D


Flow sample without Flow.Path

As you divided Flow to Flow and Flow.Path it would be great to create sample application without using Path because now it's not clear why anyone should use Path and the idea behind it. Documentation in Path class on that theme is missing. Thanks

+1

I've got such really simple example for Flow v0.12. Please see [FlowExample] (https://github.com/DmitriyZaitsev/FlowExample). I hope it can be helpful.

Writing appropriate samples now.  Path has been internalized, and there are already samples without it on master. Samples with it are coming.


[FEATURE REQUEST] Don't import token-sets defined as "treat as source"

:speech_balloon: Description
If I mark a token-set as "source", it doesn't allow me to access those variables in Figma. Ideally it would work the same in the code.
If this is controversial, it would be great if there was a setting passed to the generator (or a config file) that allowed you to ignore certain token-sets. Or ignore source token-sets.
:question: Link to specification or documentation (if available)
Tokens studio docs
Details
themes/semantic-light references colors in core, but they shouldn't be accessible in the code (to prevent people from using colors directly instead of through the semantic theme token set).
In $themes.json there is this:
    "selectedTokenSets": {
      "global": "enabled",
      "core": "source",
      "theme/semantic-light": "enabled"
    },

https://v4.styledictionary.com/examples/splitting-output-files/
Looks like using "filters" is how they recommend doing it.
https://v4.styledictionary.com/reference/hooks/formats/#filtering-tokens

The linked docs require a Figma login.

Updated!

I opened a PR specific to omitting "core" tokens https://github.com/mark-nicepants/figma2flutter/pull/34. It could easily be modified to accept a list of paths for token sets to omit if that need arrises.


A few small changes.

Changes

Added transactions button to settings
Added settings button to transactions
Changed keywords to tags in store wizard
Changed unfollow icon in discover to match other places
Added listing count badge to store tab on user page
Auto highlight text in address bar on focus (makes it quicker to copy or delete)

Strange. I'll take a look, no idea where that came from.

@jjeffryes those deletions exist in master too. It looks like I pulled them in when I merged the latest master into my branch.

I'm looking at a copy of master, it doesn't have the same deletions. I think your branch got out of synch somehow. I'll do a fix and commit it.


Error on setup script

I'm sure it's something I'm doing wrong but on my freshly install macOS Catalina I'm trying to setup your system and when I get to part where I run setup I'm getting a mapfile error - would appreciate any thoughts you might have.
this will install all your apps
bash ~/setup

setup: line 29: mapfile: command not found
setup: line 35: mapfile: command not found

I think it's because of the bash version, mapfile command is available in bash versions 5+. It might be the cause that the bash ~/setup is picking the system-installed bash (which may have not been the updated version).

check the bash version if it is above 5
In bash run mapfile (this is a built-in command and give your a result like)

mapfile [-n count] [-O origin] [-s count] [-t] [-u fd]
        [-C callback [-c quantum]] [array]

and can you tell the output of which bash and bash --version so I can reproduce this.

This might help you https://stackoverflow.com/questions/61647118/bash-5-mapfile-readarray-command-not-found, if the default bash is 3, we can change the script to update the bash first and then proceed.
@That-Dude

macOS ships with bash 3.x as default even with Big Sur. I was running into the same issue until I updated to v5.x
@kalkayan

macOS ships with bash 3.x as default even with Big Sur. I was running into the same issue until I updated to v5.x
@kalkayan

Ok that makes sense.
I guess not everyone is going to want an updated bash in their dev environment so perhaps a method to workaround using mapfile would be a more pragmatic approach.
I think the external files could be read line by line and evaluated using bash v3.

Just a quick update - I really love your concept but I needed it work on a fresh install of macOS, so I've re-written your setup script to work with the inbuilt version of bash that macOS includes by default.
I also ended up adding a few feature that suit my needs.
Thanks again


[CSGen] Don't apply one-way requirement to typed patterns

Typed patterns are represented by a name and a fixed contextual
type, let's not use intermediary type variable and one-way constraint
as its type because that variable would be bound right away to
contextual type. Also setting type of a variable declaration
to a type variable when contextual type is IUO doesn't play well
with overload resolution because it expects an optional type for
declarations with IUO attribute.
Resolves: rdar://80271666

@swift-ci please smoke test

@swift-ci please smoke test


CausalELM v0.5

@JuliaRegistrator register()

Registration pull request created: JuliaRegistries/General/98847
Tip: Release Notes
Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.
@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.5.0 -m "<description of version>" 5a1aa5e748028c69b70b69b7ee8c3657f8ce8aec
git push origin v0.5.0

An unexpected error occurred during registration.

@JuliaRegistrator register

Registration pull request updated: JuliaRegistries/General/98847
Tip: Release Notes
Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.
@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.5.0 -m "<description of version>" 5a1aa5e748028c69b70b69b7ee8c3657f8ce8aec
git push origin v0.5.0


[Question] - Just wanted to confirm that the SFTP plugin handles incomplete Downloads (and uplaods)

Massively look app!! This is great!
I reviewed the code for the SFTP and it looks like it does handle incomplete download and uploads by simply over-writing it?
I have a use-case where the machine that WexFlow will:

Wexflow installed on LocalComputerAAA
Connect to FTP RemoteServer123
Wexflow downloads files from RemoteServer123 and saves them to a NAS or Drive connected to LocalComputerAAA
LocalComputerAAA is frequently restarted and shut down, so I just wanted to confirm its resiliency

Questions
1.) Just to confirm - incomplete files will be 'overwrited' (upload and downloaded
2.) The FTP downloads to the / of where wexflow is hosted on?  Where does the FTP task download files to?

I understand that first the files are downloaded (one by one)
Then the file mover when each task is complete, will move the file from the root / of wexflow to the destination folder.

Is this correct?
3.)  Can you clarify please what the selectFiles property does?
https://github.com/aelassas/wexflow/wiki/Ftp
<?xml version="1.0" encoding="utf-8" ?>
<Tasks>
  <!--
    Ftp is a sequential task that allows to list, upload, download or delete files over FTP, FTPS or SFTP.
  -->
  <Task id="$int" name="Ftp" description="$string" enabled="true|false">
    <!--  The files loaded by the task having as id $taskId will be sent. -->
    <Setting name="selectFiles" value="$taskId" />
    <Setting name="selectFiles" value="$taskId" />
    <!-- You can add as many selecteFiles as you want.-->
    <!--- FTP command. Possible values: list|upload|download|delete-->
    <Setting name="command" value="list|upload|download|delete" />
    <!--- FTP Protocol. Possible values: ftp|ftps|sftp-->
    <Setting name="protocol" value="ftp|ftps|sftp" />

Notes
I will have to do some testing of my own to better understand how these work:

To understand how tagging and renaming files work, refer to the documentation of the ListFiles and Xslt tasks.

I read the documentation,  and this is still unclear to me.  It sounds like some sort of file / task monitor? I'm not quite sure.
Wiki
I will get the Wiki updated with 'Error Handling' in the FTP area once this is confirmed and I understand it.
Thanks so much!

Yes, incomplete files will be overwritten.
Files are saved in Wexflow's Temp folder (C:\Wexflow\Temp).
selectFiles works as follows.
Here is a sample ftp download tagging workflow. Here is a sample upload renaming workflow. Here is the XSLT used for tagging and renaming. You can find a detailed documentation on how tagging and renaming works here.


Fix typo

This PR fixes a trivial typo in a print statement.

Thanks!

BTW @duncanmmacleod - I did a release yesterday with all of the fixes you wrote / suggested that have been closed

BTW @duncanmmacleod - I did a release yesterday with all of the fixes you wrote / suggested that have been closed

Yes, I saw that - I haven't had time to take the new version for a spin, or think about the windows path stuff, but will hopefully find time before I completely forget (which is unfortunately quite likely).


Add PURE annotation to a top-level createSelectorCreator call

This improves tree-shakeability of the createSelectorCreator

Seems reasonable to me, although I don't actually maintain Reselect.  @ellbee ?


Invite for SDK that adds Admin flag

#1757
#1759
User Invite Image below

Created 2 users: 1 with Admin flag false and the other as true

Coverage: 93.98% (-0.005%) from 93.985% when pulling 2be0d228af4c5700153960c8676703464a959ef4 on james-invite-sdk into 5b88479d3e7d88234c27e6f6d3b95c5e89e8bed9 on main.


Document usage of FallibleOperationsDecorator

Document the usage of the decorator introducted by #1190.

Hey @crisidev - Why did you choose to make this decorator only add the InternalServerError to operations that have no other errors defined? When an API server is subject to internal errors (for example network issues connecting to underlying services) I would expect it to add it unconditionally to all operations regardless of this check for shape.errors.isEmpty() simply because there is no native mapping of internal errors to the functional errors of the API. WDYT?
https://github.com/awslabs/smithy-rs/blob/0a13f76568ed1869b5e6f280a62a7354fe7cd421/codegen-server/src/main/kotlin/software/amazon/smithy/rust/codegen/server/smithy/customizations/FallibleOperationsDecorator.kt#L47

I probably did not understand your problem completely. I thought you needed to make the operation fallible even if it was not, not also change operations that can already return errors.
That said, we created this decorator specifically for your use case. If it doesn't fit we can just change it.

Hey, got it, I probably did not explain it clearly.
I am trying to convince that this is needed for other servers too.
I guess that if you write your own API you could add errors as desired.
However in case the API already exists and you would like to create a server for it, it can be quite difficult to map internal errors to one of the API errors if it was not designed to represent these errors, and in this cases an InternalServerError is desired to be returned, and clients will anyhow have to be able to map unknown errors (which can also just be a new API error that was added to the server after the client was generated).
If you agree with that I can update this decorator to InternalServerErrorDecorator.
If not, I can either add a new decorator, or it can live outside of this project if you feel it doesn't belong, or if you believe this is just the wrong approach I would be happy to learn how it is recommended to handle server errors with smithy.

I am happy to change the decorator (or get a pull request) and fulfill the behaviour you are searching for.
On a more general view, I still think that new API should not make use of this as it is an anti-pattern, but for old services I can definitely see the use for it.
I'd rather keep the decorators in smithy-rs repo, so they can be shared with other projects, but I am still confident they should be opt-in only and never a default.


412 Error Response on Claim

Looks like a POST request hitting this endpoint https://smartclaimz.io/rwdbuild/ms/fn/sporwc/e582972467e33521d088dac4a286315c8e68f8faa498adcfffa66f85 is what is causing a 412 response

This was an error on signature submission.  The last part of the URL is part of the signature.  It's possible something was down at that time.  If it ALWAYS fails for your wallet, try doing one token at a time.. if it always fails for your wallet and every single token, then we might need to check our wallet settings and have @Sbcdn  take a look at the back end.

Things are resolved, it was a temporary thing with no changes needed, closing this out.


uuid library doesn't work well with expo

Describe the bug
Error: crypto.getRandomValues() not supported. See https://github.com/uuidjs/uuid#getrandomvalues-not-supported
Reproduction and solution
Use it with any expo app, simply add the<EMAIL_ADDRESS>Solution
After i found the error originating from the uuid library, i checked the latests commits and i noticed it was added recently so i downgraded to 2.5.6 which solved the issue.
i think this should be helpful to fix the issue.
Additional context
<EMAIL_ADDRESS><EMAIL_ADDRESS>
[x] iOS
[ ] Android
[ ] Web

If you are using expo please indicate here:

[x] I am using expo

+1 using Metro

Hello, I'm having this issue too

+1 using Metro;
Android;
<EMAIL_ADDRESS><EMAIL_ADDRESS>

I've created a pull request that integrates the react-native-get-random-values polyfill, which should resolve this problem. This addition ensures that the uuid library functions correctly within the React Native environment by providing the necessary crypto functionality.
Here's the link to the PR for easy access: #952

@Arshiash80 I am getting this same error after instaling this package can you help me:
my expo version is :  "~52.0.11",
"react-native-google-places-autocomplete": "^2.5.7",

@Arshiash80
worked with "react-native-google-places-autocomplete": "2.5.6",
but its not good practice.


ENV vars - All are optional

Hello @barreraalexander
All env variables are optional with defaults:

Debug = True
SECRET_KEY = random 16 chars
Stripe secrets = None (Null)
SERVER_HOST - localhost:8000 (default uvicorn PORT)

Also, when the stripe secrets are not provided the UI shows the product but informs the user using an alert.

Flask version has all these evolutions

All env variables are now optional. Defaults are provided in config.py.

Hello @barreraalexander
In the latest version, the vars are optional but .env values not loaded.
I'm using the latest version and .env is provisioned with all goodies.
The UI informs the user to provide the STRIPE Secrets.
Please check. ty!

DEBUG=True

# Flask SECRET_KEY
SECRET_KEY=Super__hgd

# Stripe Secrets
STRIPE_PUBLISHABLE_KEY=pk_test_WHATEVER
STRIPE_SECRET_KEY=sk_test_WHATEVER

# Server Address (used by Stripe callback)
# Should be the URL used to start the APP
SERVER_ADDRESS=http://localhost:5085/

Alrighty, so the config.py file is fine -- if a environment variable isn't provided in the .env file, config.py will provide defaults. This is okay yes? But your concern is that the docker-compose.yml file isn't loading the .env file, therefore only defaults are being used?  This should now be fixed with the change I made in Dockerfile. On my end, the UI follows the same evolution as the flask app, where clicking on the "Buy Product" button makes a popup occur about the Stripe secrets.

Hello @barreraalexander
The test was made with the manual set up.
If the stripe secrets are provided in .env the pop-up is still there and the user is informed to update the configuration.
I did not debug the app to detect where is the problem.
Please check. Ty!

Oof, I got tied up by misnaming a variable. This is fixed.

Validated. Closing!
Ty @barreraalexander


Use Vue to refactor pull merge UI

This PR would help

https://github.com/go-gitea/gitea/pull/19648
https://github.com/go-gitea/gitea/pull/9307

to get a clear code base.
And this PR use real code to show how to rewrite UI to Vue
At the moment, to keep the UI the same, some Fomantic UI styles are still being used.
I just did some simple tests, it should work as expected. Feel free to report bugs or edit on this PR directly.

@6543 I am cleaning comments, the eslint and script-module cann't work together. pull & try again.

@wxiaoguang please resolve config

Need to confirm a change first: https://github.com/go-gitea/gitea/pull/18177/files#r867490307

I think that the change in pull.tmpl on main branch might be wrong. So I just keep the detailed message textarea for squash merge in this PR. Updated.

@wxiaoguang Merge conflict resolution?

Codecov Report

Merging #19650 (176f9a8) into main (59b30f0) will decrease coverage by 0.03%.
The diff coverage is 38.88%.

@@            Coverage Diff             @@
##             main   #19650      +/-   ##
==========================================
- Coverage   47.39%   47.35%   -0.04%
==========================================
  Files         956      957       +1
  Lines      133115   133546     +431
==========================================
+ Hits        63093    63245     +152
- Misses      62393    62641     +248
- Partials     7629     7660      +31

Impacted Files
Coverage Δ

cmd/hook.go
7.11% <0.00%> (ø)

cmd/serv.go
2.33% <0.00%> (ø)

models/error.go
35.87% <ø> (-0.90%)
:arrow_down:

modules/git/repo_compare.go
65.19% <0.00%> (-1.78%)
:arrow_down:

modules/repository/env.go
100.00% <ø> (ø)

modules/repository/init.go
51.92% <0.00%> (ø)

modules/repository/temp.go
40.90% <ø> (ø)

modules/setting/repository.go
55.71% <0.00%> (-2.50%)
:arrow_down:

modules/templates/helper.go
49.84% <ø> (-0.16%)
:arrow_down:

routers/api/v1/admin/user.go
39.14% <0.00%> (-0.43%)
:arrow_down:

... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e19200...176f9a8. Read the comment docs.


sequence header should be returned as python dict

At the moment the header appears as a np.ndarray with dtype=uint8, so you have to convert it back using
header = json.loads(iseq.header.tostring())

can ring.read() return iseq with iseq.header as a dictionary? Looking at the ring.py code I have NFI how this would be implemented...

This is addressed by the new pipeline code, which assumes headers are always json format and returns a dict (specifically https://github.com/ledatelescope/bifrost/blob/master/python/bifrost/ring2.py#L157).


Dev/colorful hostnames

deploykit.command logging now has colorful hostnames. Up to 8 different colors. We start with green as first hostname color because in single-host use-cases this results in less agressive looking output (default would be red).
see https://gist.github.com/pogobanane/95a75cdc38f0c57c9a5f0b0f14f33a22 how colorcodes match to colors in your terminal

included in https://github.com/numtide/deploykit/pull/16


exclude directory lib

may be we remove lib from repository

It's included because that way people can point to the Github repository and use the library from node modules in the same way as the published package. I'm open to alternatives though

Closing for now. It there is an alternative I'd be very happy to adopt it :)

I don't think many people use it


[CLOYSTER-57] Implement fail2ban

The name says everything.

I think we can hold this PR a little bit, because to it work correctly we need to have a Firewall infrastructure on the code, and we don't have it.
The Firewall will be probably firewalld, however we don't have any control of it yet as we should have.


Unselect configuration file

Once a configuration file is selected the user needs to be able to unselect it if mistaken.
Find way to unselect the selected file.

Not relevant anymore, because we now force user to work with a configuration file.


Is possibile to select which layers to train?

💡 Your Question
Hi,
thanks for super gradients. I want to know if it is possible to select which layers to train using parameters from a recipe? Like having a list of layers and automatically freezing the other layers not included.
If not can you please give me some hint on how to do this for example with a resnet50 model?
Thanks
Versions
3.4.1

Yes, this will be available in 3.5 release. You can see this PR with a preview what is needed to set this.


Add support for tagging Snowflake Alert

Terraform CLI and Provider Versions
Provider: v0.87.1
CLI: 1.7.4
Use Cases or Problem Statement
I am trying to add tags to Snowflake Alerts to identify the environment in which they are running. However, I discovered that neither snowflake_alert nor snowflake_tag_association resources in the Terraform Snowflake Provider support tagging for Alerts.
Currently, the only workaround is to manage the tagging of Alerts using a method other than the Terraform Snowflake Provider, which is not ideal.
By adding support for tagging Alerts in the Terraform Snowflake Provider, it would greatly simplify the management and organization of Alerts across different environments, making it easier to identify and track Alerts based on their associated tags.
Proposal
To address this issue, I propose extending the snowflake_tag_association resource to support tagging for Snowflake Alerts. This would be the most straightforward and consistent approach, as snowflake_tag_association is already used for tagging other Snowflake resources.
By updating the snowflake_tag_association resource to include support for Alerts, users would be able to easily manage and organize their Alerts using tags within the Terraform Snowflake Provider. This would provide a native, integrated solution for tagging Alerts, eliminating the need to rely on external methods or workarounds.
Implementing this solution would involve updating the provider's codebase to accept Alerts as a supported resource type for the snowflake_tag_association resource, along with any necessary modifications to handle the tagging process for Alerts specifically.
How much impact is this issue causing?
Medium
Additional Information
No response

Hey @pei0804. Thanks for reaching out to us.
This is a good suggestion. We are in the process of redesigning the existing resources and adding the missing functionalities as part of https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/ROADMAP.md#supporting-all-snowflake-ga-features). We will address it then.

For the time being, you can also use the https://registry.terraform.io/providers/Snowflake-Labs/snowflake/latest/docs/resources/unsafe_execute resource. This is a dangerous resource, though. Please make sure to read the docs and familiarize yourself with the resource's limitations before using it.

I implemented the code as follows and it worked successfully:
locals {
  database_name = "my_database"
  schema_name   = "my_schema"
}

resource "snowflake_unsafe_execute" "production_environment_tag_association" {
  count = var.is_production_environment ? 1 : 0
  execute = "ALTER ALERT ${local.database_name}.${local.schema_name}.${snowflake_alert.this.name} SET TAG SAMPLE_DATABASE.TAG.ENVIRONMENT = 'prod'"
  revert  = "ALTER ALERT ${local.database_name}.${local.schema_name}.${snowflake_alert.this.name} UNSET TAG SAMPLE_DATABASE.TAG.ENVIRONMENT"
}

Hi @pei0804 👋
Alert tagging is now supported. Also, we've released a new v0.98.0 version (release, migration guide), we recommend upgrading to this version.

Cured. Thank you.


Move addition of passkey header from BaseController to WebView fragment

Summary
The initial work I did to add the passkey protocol header occurs in the BaseController and the PrtV3 authorization strategy classes. Adding the header in these two places covers the scenarios that MSAL/Broker needs.
However, in their non-brokered auth flow, OneAuth utilizes the AuthorizationActivityFactory.getAuthorizationActivityIntent directly, so they are not making use of any controllers in this case (though they do use BrokerMsalController for broker scenarios). (For context, getAuthorizationActivityIntent is called down the line by our strategies).  Thus, with the header logic the way it is, OneAuth is going to need to add the passkey header themselves to their getAuthorizationActivityIntent call.
They brought up the idea that if I were to move the addition of the passkey header to a class that's covered by getAuthorizationActivityIntent, then they would be able to get the logic automatically.
If I move the passkey header logic to WebViewAuthorizationFragment, my understanding is that it would be inherited by both MSAL and broker (so I can also remove the logic from PrtV3 authorization strategy, iiuc) as well as OneAuth. And I also wouldn't have to check for authorization agent == WEBVIEW anymore. But this change would not be correlating to where we typically add headers (which is in BaseController and the PrtV3 auth strategy).
I want to get some input from the team about this before commiting to making such a change. Decided to make the change.

Do we plan to support passkey in standalone MSAL?

Do we plan to support passkey in both standalone MSAL and OneAuth?
Will this be configurable flow by flow?

--
The original design is letting the method that constructs the request to decide if passkey should be supported. This change means 2) is no longer doable. (e.g. you don't want concurrent requests to modify a global static variable)
If 1) and 2) is not a concern (e.g. every request header from MSAL/OneAuth/Broker would always have this value), then this seems OK.

We do plan to support this in standalone MSAL and OneAuth (for 1P apps only). Noting that this header controls whether or not we want to use the custom passkey protocol, which is necessary for cases where WebView is the authorization agent. It does not change the UX of the login page, which is handled by a different query string parameter that is configurable flow by flow.
No, it shouldn't be. Android's WebView does not currently have the capability to support WebAuthn calls automatically like CCT does, which is why the custom protocol was built. So anytime a WebView is being used as the auth agent (whether it's for MSAL, OneAuth, or Broker), we want to state to the server that the passkey protocol should be used, should any passkey request come in.
Another thing about this solution is that if in the future, Android does implement WebAuthn support for WebView, we can turn off this custom protocol in one shot, instead of making the same changes in broker and OneAuth individually.

Do we plan to support passkey in both standalone MSAL and OneAuth?
Will this be configurable flow by flow?

--
The original design is letting the method that constructs the request to decide if passkey should be supported. This change means 2) is no longer doable. (e.g. you don't want concurrent requests to modify a global static variable)
If 1) and 2) is not a concern (e.g. every request header from MSAL/OneAuth/Broker would always have this value), then this seems OK.

We do plan to support this in standalone MSAL and OneAuth (for 1P apps only). Noting that this header controls whether or not we want to use the custom passkey protocol, which is necessary for cases where WebView is the authorization agent. It does not change the UX of the login page, which is handled by a different query string parameter that is configurable flow by flow.
No, it shouldn't be. Android's WebView does not currently have the capability to support WebAuthn calls automatically like CCT does, which is why the custom protocol was built. So anytime a WebView is being used as the auth agent (whether it's for MSAL, OneAuth, or Broker), we want to state to the server that the passkey protocol should be used, should any passkey request come in.
Another thing about this solution is that if in the future, Android does implement WebAuthn support for WebView, we can turn off this custom protocol in one shot, instead of making the same changes in broker and OneAuth individually.

you mentioned "for 1p apps only" - what would happen in the case of 3p MSAL app?


Upgrade Ruby and Rails

This is PR upgrade ruby https://github.com/shescoding/shescoding-dot-org/issues/127  and rails https://github.com/shescoding/shescoding-dot-org/issues/128
Were both issues tackle at the same time as per pre-requisites needed.
Some of the locked Gems has been updated, as per the update.
Tested locally, and runnign the two specs. :smile:

@cherchezlafemme Feel free to ping me in any case with this PR :)


Slight changes

The lecture slide has a linear model superimposed on the plot, so I added one.  With this change came a slew of changes to the html version.  I think we have different RStudio version that render to html differently.  Either way (with this pull or by hand) you could add a lm to the plot.

Great, thanks!


[pkgcfg] Show readme when adding packages. Add info command

Summary
This shows notes whenever a package configuration has a non-empty "readme" field. It also adds a new (hidden) command devbox info <pkg> that displays said info.
I also updated a few readme fields to make them look better.
How was it tested?
devbox add mariadb
devbox add nginx
devbox info mariadb

I do realize that having a config flag for the info command is kinda weird. It's also not really needed (it gets used to build the package config struct but we only really need the name and the "readme" field so the config path is not used). This requires a slight change in pkgcfg architecture so I might do it in a follow up.

Yeah, I think:

devbox info <pkg> should accept any package
It should print the metadata about the package. We already have PkgInfo in nix.go, so it should be trivial to print that.
For packages that have a README / additional configuration info, we can also print that.

I'll add PkgInfo but I have a suspicion it is not useful.


I want To Add Vegetable  website tamplate

Issue Type:

[x] Feature Request

Describe the bug

A clear and concise description of what the bug is.

Possible solution

Describe the solution you thought of.

Screenshots

If applicable, add screenshots to help explain your problem.

please assign me and check pr sir

@adi2002vicky Make a new issue when u r ready!


Reorder validation and Improve documentation to decrease confusion for users

How to categorize this PR?

/area usability
/kind enhancement
What this PR does / why we need it:
Currently, if a user tries to upgrade a Shoot from kubernetes version v1.24.x to v1.25.x, the errors printed are,
The Shoot "local" is invalid:
* spec.kubernetes.allowPrivilegedContainers: Forbidden: for Kubernetes versions >= 1.25, allowPrivilegedContainers field should not be set, please see https://github.com/gardener/gardener/blob/master/docs/usage/pod-security.md#speckubernetesallowprivilegedcontainers-in-the-shoot-spec
* spec.kubernetes.version: Forbidden: admission plugin "PodSecurityPolicy" should be disabled for Kubernetes versions >=1.25, please check https://github.com/gardener/gardener/blob/master/docs/usage/pod-security.md#migrating-from-podsecuritypolicys-to-podsecurity-admission-controller

The users try to act on the first error, and it doesn't work since the field is defaulted by the GAPI server if PodSecurityPolicy admission plugin is not disabled.
This PR reorders the validation so that the errors are shown as:
The Shoot "local" is invalid:
* spec.kubernetes.version: Forbidden: admission plugin "PodSecurityPolicy" should be disabled for Kubernetes versions >=1.25, please check https://github.com/gardener/gardener/blob/master/docs/usage/pod-security.md#migrating-from-podsecuritypolicys-to-podsecurity-admission-controller
* spec.kubernetes.allowPrivilegedContainers: Forbidden: for Kubernetes versions >= 1.25, allowPrivilegedContainers field should not be set, please see https://github.com/gardener/gardener/blob/master/docs/usage/pod-security.md#speckubernetesallowprivilegedcontainers-in-the-shoot-spec

This PR also improves the documentation mentioned in the error.
Which issue(s) this PR fixes:
Part of #5250
Special notes for your reviewer:
Release note:

NONE

/lgtm


HDDS-8672. Support CodecBuffer for the remaining protobuf v2 codecs in hadoop-ozone.

What changes were proposed in this pull request?
This is to continue the work of HDDS-8664. To change all the remaining protobuf v2 codecs in hadoop-ozone.
What is the link to the Apache JIRA
HDDS-8672
How was this patch tested?
By existing tests.

Thanks @szetszwo for the patch.

@adoroszlai , thanks a lot for reviewing and merging this!


nix-output-monitor: <IP_ADDRESS> -> <IP_ADDRESS>

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Builds fine on x86_64 NixOS

Result of nixpkgs-review pr 139336 at f779a0ff run on aarch64-linux 1

2 packages built successfully:

haskellPackages.nix-output-monitor
nix-output-monitor


Add related contents to page

Preview environment created!
The preview environment has been deployed to the cluster.
Client URL: https://pr-1718--epp.elifesciences.org
Storybook URL: https://pr-1718--epp-storybook.elifesciences.org
Note: If this is a new environment, it can take a few minutes for DNS to update.

Preview environment images deployed!
The preview environment has been updated:
client image tag: preview-1718-e061234b209e5b5fdacc9523ca15d92c31545638-20240227.1234
storybook image tag: preview-1718-e061234b209e5b5fdacc9523ca15d92c31545638-20240227.1234
Client URL: https://pr-1718--epp.elifesciences.org
Storybook URL: https://pr-1718--epp-storybook.elifesciences.org
Note: Updated images can take a few minutes to roll out.


Clicking on event emits @cell-click but without Date object; @event-focus emitting twice

Hi @antoniandre , I recently updated vue-cal from version 1 to 2 in my project, and I have a few questions/issues.
1) @cell-click inside events
In v1, I recall that @cell-click was emitted with a JS Date object when you clicked inside a cell, regardless of whether it was inside a calendar event or not (my app depended on this).

cell-click - returns a JS native Date object

Now, clicking inside an event seems to be emitting @cell-click but with no Date object inside. Is this expected behaviour/documented somewhere?
I found the below on event creation, but I couldn't find anything on this particular behaviour of @cell-click:

Event creation will not trigger with a single/double click or click & hold if your cursor is on an event.

2) @event-focus firing twice?
I noticed that clicking on an event seemed to be firing off @event-focus twice. This was the case for both my app and the demo in the docs. Is this to be expected?
https://antoniandre.github.io/vue-cal/#ex--emitted-events

(The screenshot above is from clicking on an event once)
Thank you for your time in advance!

Hi @risafj,
You are right, that's a regressions that I haven't noticed and you're the first to report it.
I will release a patch for that soon.
Thanks for reporting!

Fixed in version 2.24.4, visible in the documentation.
Thanks for reporting again, let me know if it fixes the issue!

@antoniandre Oh wow! Amazed that you released a patch so quickly. Thank you! 👏
I'll test it out and let you know if I notice anything else.

@antoniandre Just upgraded to 2.24.4 and tested it in my app, and everything seems to be working. Thank you so much again!

Awesome, 2 less bugs in the wild!


Refactor to standardize on first argument for methods receiving IO

This introduces some breaking changes but rewards with great developer happyness because you don't need to recall the different placements of io arguments. It is now always the first argument.
There is a somewhat unrelated change in cf613ea which makes upcase argument to Int#to_s a named argument. But it makes sense to introduce that change at the same time as the argument order. It was already only used as a named argument in stdlib so this didn't even need any changes here and it underlines the fact that you would not pass it as positional argument.
Resolves #5916

Rebased on master to fix conflicts

Missed https://github.com/crystal-lang/crystal/blob/d49375b181b9803a5a405b9b04846dce6aec2870/src/crystal/system/win32/process.cr#L159


 C-w does not work for me

This is a known issue that has been addressed on the straight branch. It will be merged sometime late next week. If you'd like to give it a try, sooner, check out this thread.

what is the Doom way to kill a buffer in Ivy minibuffer (SPC ,)?

All "alternative" actions in ivy/counsel commands are available under the C-o prefix.


scansnap-manager is only for the SV600

Hi, Fujitsu releases a different version of scansnap-manager for many of its scanners.  This Cask, which installs version 6.2L10, is only correct for the SV600 and IX500.  All other ScanSnap devices require a different version of the manager.
You can see the problem on this page: http://www.fujitsu.com/global/support/computing/peripheral/scanners/software/

the SV600 requires version 6.2L10   (the ScanSnap Manager included in this cask)
the S1100i requires V6.3L21
S1100: V3.2L31
S1300i:  V6.2L22
S1300: V3.2L31
S300: V4.2L14
S300M: V2.2L11
and so on...  what a nightmare.

Does it make sense to make a separate cask for each scanner?  scansnap-manager-sv600, scansnap-manager-s1300i, scansnap-manager-s300m, etc?
If not, maybe deleting this cask is the correct thing to do?  Right now it's pretty misleading.

I wouldn’t be opposed to removing it entirely.
Having said that, we could certainly create one for each of them, and put them all in caskroom/versions (including the one present here now). Either way, the one in the main repo should be removed.

@mbrgm is starting made a first step towards the second proposed solution in https://github.com/caskroom/homebrew-versions/pull/703. Letting you know in case you’d be interested in collaborating to get the rest of them there.

@mbrgm made a first step towards the second proposed solution in https://github.com/caskroom/homebrew-versions/pull/703. Letting you know in case you’d be interested in collaborating to get the rest of them there.
Not pressuring any of you to do it, naturally, just pointing out there might be a common interest in having this done.

I think I'll start by renaming the existing casks to reflect the matching scanner model, i.e. scansnap-manager-s1300, scansnap-manager-sv600 etc.

Sounds good; makes sense to me.

Is there some way to 'symlink'/alias a cask? Some versions are for multiple models, so I would create an alias for every model. Another solution would be to name it according to the models, i.e. scansnap-manager-s300-s500m-s510. I think our goal should be to help the user decide which version she needs for her model. She will most likely know the model name but not the version number of the software needed. Thoughts?

Is there some way to 'symlink'/alias a cask?

There is not, though there may be in the future.

Another solution would be to name it according to the models, i.e. scansnap-manager-s300-s500m-s510.

Agreed. Seems like the best solution. Inside the cask itself we could leverage name to make explicit that the same cask works for those models:
name 'ScanSnap Manager for model S300'
name 'ScanSnap Manager for model S500M'
name 'ScanSnap Manager for model S510'

Searching by name ins’t yet possible, but being worked on.

Agreed. I took a look at the metacask proposal. Sounds promising. In the meantime, the naming will be a convenient solution. We can refactor this later, when metacasks are available.

Sounds like a decent direction given the limitations.  @mbrgm tell me if you can use help/testing for the S1300i.

@bronson You can take a look at the changes I made in caskroom/homebrew-versions#703 if you want. Maybe you could add the S1300i in a similar fashion.

Done in https://github.com/caskroom/homebrew-versions/pull/703 by @mbrgm.


tempCopyMediaFile() changes the extension of HEIF photos but does not convert them

Calling tempCopyMediaFile() on HEIF image asset that is not a live photo and passing convertLivePhotosToJPG: true changes the file's extension to .jpg but doesn't actually convert it to a JPEG.
It can get really confusing if the temp file is exported and used on a platform that doesn't support HEIF.

@EimantasMorkunas
You right. I've pushed a fix for this.


⚠ Bofrost.at has degraded performance

In cc1cc97, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1933 ms

Resolved: Bofrost.at performance has improved in 5e606c7.


Revert "[10.x] Built in Auth Notification classes implement ShouldQueue interface and Queueable trait"

Reverts laravel/framework#45895

Can we know why this was reverted?
This means I'd need to dig the base classes out the /vendor directory in order to make them queueable.
/vendor is gitignored, so many text editors will not find the base classes via a project-wide text search.
Thanks


iOS App crashes when ReCaptcha Client is requested with site key

Describe the bug
Running the App with ReCaptcha Enterprise SDK on iOS is causing a crash when ReCaptcha Client is requested.
2023-08-23 19:28:39.506442+0530 ReCaptchaSDKTest[1906:189843] -[RCAx_GPBTimestamp initWithTimeIntervalSince1970:]: unrecognized selector sent to instance 0x2817c28e0
2023-08-23 19:28:39.507163+0530 ReCaptchaSDKTest[1906:189843] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[RCAx_GPBTimestamp initWithTimeIntervalSince1970:]: unrecognized selector sent to instance 0x2817c28e0'
*** First throw call stack:
(0x195f17180 0x1950ef9f8 0x195e339bc 0x195f1c9c8 0x195f1e65c 0x100b6a0cc 0x100b46f48 0x100b46ffc 0x100b35be4 0x1010476f4 0x101048c78 0x101050bf4 0x1010518b4 0x10105b77c 0x195b36114 0x195b38cd4)

reCAPTCHA Site Key
6LfoL8snAAAAAMjTYmFPsbT0uuuQAoyuwZA4SbFI
Integration Method
Select the method used to integrate with reCAPTCHA Mobile.

[x] SPM (iOS)
[ ] Cocoapods (iOS)
[ ] Direct Download (iOS)
[ ] GMaven (Android)

SDK Version (e.g. 18.0.1):
18.3.0
To Reproduce
Steps to reproduce the behavior:

Configure the SDK into the app using the instructions given at : link
Run the app on device
Once code for Client generation is executed
App crashes with the above mentioned error

Expected behavior
ReCaptcha Client should be generated without any crash of the app
Screenshots

Screenshot when the app crashes
https://paste.pics/c798ba494ed1f931ad5f667d9be48fd4

Xcode version for iOS (please complete the following information):

14.3.1

Device (please complete the following information):

Model: [iPhone6]
OS: [iOS 12.5.7]
Real Device

Additional context
A user faced similar issue on StackOverFlow, he forgot to configure the Objc Bridging Header file, after configuring the same his issue was resolved.
SO Link
In my case I have configured everything correctly and followed the step by step instructions but still the App crashes when it tries to get a Client using the site key
I have a .zip file of my project uploaded on drive, which you can download and check if you have Xcode 14
https://drive.google.com/file/d/1YE99gkBv5bfxjzFAkl6IbU24KGJfbGho/view?usp=sharing

-ObjC not -Objc
Common mistake!


Add button tooltips are cut off on smaller screens

Happens at screen widths below ~510px. Tooltips don't work on mobile right now but this should get fixed regardless.

Apparently it's not that easy to make the tooltip text wrap in two lines or more.
But there are two other options:

Position the tooltip at the bottom (it was this way before iirc, not my favorite)
Reword the tooltip to be more concise:

english: "Insert a new block here" -> "Insert new block"
german: "Hier einen neuen block einfügen" -> "Neuen Block einfügen"

I think option 2 makes a lot of sense as it would also match the other tooltips on that page better (i.e. "remove block", "edit block" etc). The "here" part of the tooltip is heavily implied by the button's positioning anyway.
Let me know your thoughs.

So the "here" part of the label was deliberate to point the user to that fact. But mh, maybe it's implied enough? Or maybe users don't see the other "add" buttons, but only the first one? Not sure.

Apparently it's not that easy to make the tooltip text wrap in two lines or more.

It's surely not easy to do that perfectly, but what if we just... do something a bit hacky? The tooltip prop of WithTooltip can be a react node. This seems to work?
<WithTooltip
    tooltip={
        <div css={{ maxWidth: "35vw" }}>
            {t("manage.realm.content.add")}
        </div>
    }
    placement="right"
>

It's certainly not perfect because the tooltip "area" can be wider than required by its text, but I'd think it's alright? :shrug:

Yup that works. Didn't even consider the possibility.
Regarding the wording: While I do think the "here" part (in relation to position, that's what I meant in my other comment) is implied enough and that tooltips should be as concise as possible, the point you made about only seeing the first button is fair. So let's stick with your suggestion.


In docs only mode, the secondary 'docs' is gone

🐛 Bug Report
In "docs only mode" (set the main docs' routeBasePath to '/'), the secondary docs (added by @docusaurus/plugin-content-docs plugin) is gone (showing "Page Not Found").
Have you read the Contributing Guidelines on issues?
Yes
To Reproduce
Use Docusaurus 2's official website source as an example:

git clone git@github.com:facebook/docusaurus.git, move website folder somewhere else and go to its path, then yarn, yarn start. It works fine: we have a main docs in localhost:3000/docs/ and a secondary docs in localhost:3000/community/
Modify docusaurus.config.js: line 191, remove the slashes // in // routeBasePath: '/',, so that the main docs can use '/', instead of 'docs', as its routeBasePath. Also delete src/pages/index.js file. These actions enable the docs only mode.
yarn start run the dev server again.

Expected behavior
The main docs should be in localhost:3000.
The secondary docs' base URL should not change, it should be localhost:3000/community/
Actual Behavior
The main docs is indeed in localhost:3000.
But the secondary docs is gone, showing "Page Not Found".
Comment
Maybe the "docs only mode" is designed to be "one instance of docs only, any other homepage, blog, or docs added by @docusaurus/plugin-content-docs plugin will not work"? But it doesn't make good sense. The scenario "the main docs takes the root '/', all other docs and blogs use their own non-root base URL" looks like a valid use case. However, yeah, there is indeed a concern that articles under root docs and those under non-root docs could have conflict of URLs, but still, as long as user doesn't use non-root docs URL base name as root docs article slug, they could co-exist.
Your Environment

Docusaurus version used: 2.0.0-alpha.69
Environment name and version: Node v12.18.1, Yarn v1.19.1
Operating system and version: Windows 10

Hi,
This is something we should figure out, but the order of the docs plugin currently matter, because we are using nested ReactRouter routes for each plugin version.
If the first docs instance catch /* instead of /docs/* (due to using routeBasePath: /), then it will also catch /community/team, but unfortunately /community is not a subroute of the /* parent route,  but a subroute of the /community/* parent route
You can see the routes hierarchy in .docusaurus/routes.js
A temporary workaround is to ensure the docs plugin with the routeBasePath: / appear last, so that we try to match against /* after trying to match against /community/* and not the opposite. I think the preset docs config will be the first. If you intervert the plugins configs, it is likely to work better.
But yes we should find a better solution so that order of presets/plugins do not matter. One of:

ensure parent route /* is always matched after /community/* (also worth generalizing to /docs/* vs. /docs/community/*)
not using parent routes at all, flattening the route config so that we don't have any non-exact (wildcard) routes. (this would mean we won't be able to code-split that routing file easily in the future)

What if I don't want
/docs/ to become /
/docs/design-principles to become /design-principles
/docs/contributing to become /contributing
...,
I just want
/docs/ to become /,
and
/docs/design-principles will stay the same
/docs/contributing will stay the same
....
I didn't check the code underneath, but I imagine the second should be easier to do?

It wouldn't be the most straightforward but you can probably do this today already:
You'd have to apply a slug to all your docs: slug: /docs/contributing.
Or you could move your docs to a /docs subfolder (ie put them  in  /docs/docs 😅 ) and use slug: '/' on the home doc.

Well, with routeBasePath: '/' and slug: /docs/contributing, the primary problem in this issue - the secondary 'docs' (community) is gone - persists.
And putting the files in /docs/docs results in other problems, they just become really messy.

In all cases, the routeBasePath: '/' should be on the latest docs plugin instance (the plugin one, not the preset one), otherwise it would catch routes of the other plugin and show 404.

Hi,
I trying to resolve the same issue. The workaround is not working, it seems. I have configuration as below:
plugins: [
  [
      '@docusaurus/plugin-content-docs',
      {
        id: 'hardware',
        path: './hardware',
        routeBasePath: '/hardware',
        include: ['**/*.md'],
        sidebarPath: require.resolve('./sidebarsHardware.js'),
      },
    ],
],
...
presets: [
    [
      '@docusaurus/preset-classic',
      {
        docs: {
          routeBasePath: '/',
          sidebarPath: require.resolve('./sidebars.js'),
        },
        theme: {
          customCss: require.resolve('./src/css/custom.css'),
        },
      },
    ],
  ],
};

As you said, I have moved the routeBasePath: '/' to the end together with whole presets` part. Unfortunately when I try to reahc any document from sidebardsHardware, it is showing "Page Not Found".

This is due to docs plugin instance ordering.
The one of the preset is applied first and its route / catch everything.
Try interverting the 2 docs plugin config.
I'll ensure later that it works without having to care about ordering, but
for now the workaround should be fine
Le ven. 18 déc. 2020 à 00:55, Bartłomiej Zieliński<EMAIL_ADDRESS>a écrit :

Hi,
I trying to resolve the same issue. The workaround is not working, it
seems. I have configuration as below:
plugins: [
[
'@docusaurus/plugin-content-docs',
{
id: 'hardware',
path: './hardware',
routeBasePath: '/hardware',
include: ['**/*.md'],
sidebarPath: require.resolve('./sidebarsHardware.js'),
},
],
],
...
presets: [
[
'@docusaurus/preset-classic',
{
docs: {
routeBasePath: '/',
sidebarPath: require.resolve('./sidebars.js'),
},
theme: {
customCss: require.resolve('./src/css/custom.css'),
},
},
],
],
};
As you said, I have moved the routeBasePath: '/' to the end together with
whole presets` part. Unfortunately when I try to reahc any document from
sidebardsHardware, it is showing "Page Not Found".
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/facebook/docusaurus/issues/3810#issuecomment-747778772,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFW6PRZ4E3NE5QADB5IORLSVKK6NANCNFSM4UBN275Q
.

It looks like interverting doesn't help.

if inverting does not help, please give me your config and the generated .docusaurus/routes.js, as it contains the final routes that the SPA router will use and can help debug the route resolution priority

It is this repository.
Here are the files where I added a new docs entry for "community": https://gist.github.com/zkochan/9a8ccd0dba1a1752d862079097fb1fc2

In our case, our config file is here, and I have inverted the 2 sections in the config file in a Pull Request, according to the deployment previews on Netlify:

The root (200 OK): https://deploy-preview-59--docs-taichi-graphics.netlify.app/
The /community page (404): https://deploy-preview-59--docs-taichi-graphics.netlify.app/community/

unfortunately it didn't seem to help :( Not sure if there's anything I have missed.
FYI:

The generated routes file is here if it helps.
We are using a slug: / frontmatter for the root page.
Currently we are using a server-side redirect from / to /docs/ without turning on the "docs-only" mode to mitigate this issue.

Thank you so much for your time and help in advance!

Any updates on this issue? Sorry for the bump but I just tested routeBasePath: '/', along with https://docusaurus.io/docs/docs-multi-instance#versioned-and-unversioned-doc on the latest release, it still doesn't seem to work 😿


About Time and Value arguments

Dear Author:
When i use the file you provided to process the data i got this error:

Traceback (most recent call last):
 File "./preprocess/save_dataset.py", line 305, in
  read_from_source(args)
 File "./preprocess/save_dataset.py", line 289, in read_from_source
  raw_data = read_data_from(path, config.tokenizer, ace=args.ace)
 File "F:\Event_Query_Extract-main.\utils\data_to_dataloader.py", line 120, in read_data_from
  output = list(map(partial(unpack_ace_with_vt, tokenizer=tokenizer), output))
 File "F:\Event_Query_Extract-main.\utils\data_to_dataloader.py", line 60, in _unpack_ace_with_vt
  entities = data[-5].split(' ')
IndexError: list index out of range

I checked the code and guessed the possible cause of the problem
After run python preprocess/ace/read_args_with_entity_ace.py
I found the content of the output file as follows:

'Text'
'B-I-O TAG'
'xxxxxxxxxxx.csv'

It is seems to contradict function  _unpack_ace_with_vt
Where is the Time and Value arguments and where is the POS-TAG?
What should I do?

Hi, I also encountered this error.
It seems that the Time, Value and POS-TAG here are all ignored in save_data.py afterwards, so I changed _unpack_ace_with_vt to this, and I think it works
def _unpack_ace_with_vt(data, tokenizer):
    """
    read the data with pos tags
    :param data:
    :param tokenizer:
    :return:
    """
    n = len(data)
    sentence = data[0].split()
    bert_words = tokenizer.tokenize(data[0])
    triggers, arguments = [],  []
    if n > 3:
        mid = (n-3) // 4 + 1
        triggers = [x.split(' ') for x in data[1:mid]]
        arguments = [x.split(' ') for x in data[mid:-2]]
        trigger_count[0] += len(triggers)

    entities = data[-2].split(' ')
    doc_id = data[-1].split(' ')

    return sentence, bert_words, triggers, arguments, entities, None, None, None, doc_id

Hi @zyf-zone, thank you for your interest in our work!
Thank you for bring this issue up! In our work, we ignore value and time argument roles, which can be set when we call the read data function at https://github.com/VT-NLP/Event_Query_Extract/blob/6a1ed5a682912a2882e4bf92d71e9b696d71d207/utils/data_to_dataloader.py#L105. The with_vt argument is for the purpose of including value and time arguments or not. We'll fix the issue shortly. Also thank @xiezhiyu01 for your help!


Create test models for each core test run

At the moment, developers have to remember to create the test models for the first checkout and every time something changes in the testmodels package. Creating these testmodels takes only about 5 seconds on my machine. Instead of expecting developers to prepare the test models manually, they should simply be created for every test run, ideally in a temporary directory.
The way I envision this code:

Check if ribasim conda environment is activated, exit with an error if not
Create a temporary directory
Setup the models with ribasim_testmodels (maybe use https://github.com/cjdoris/PythonCall.jl for that)

Looks like a duplicate of #116

Indeed, my bad. Do you mind closing https://github.com/Deltares/Ribasim/issues/116 since its original description is a bit outdated?

Done. One comment that might still be relevant:

Let's also use this: https://github.com/cjdoris/CondaPkg.jl

Done. One comment that might still be relevant:

Let's also use this: https://github.com/cjdoris/CondaPkg.jl

Note: this part needs at least further investigation, but is probably not feasible if CondaPkg.jl doesn't allow to activate an existing conda environment.

Fixed by #604. That doesn't call Python from the Julia tests, but adds pixi run tests, which generate the test models first. So I'd say this is fixed if you just run pixi run tests.
Running pkg> test is probably still, but then you need to remember to run pixi run generate-testmodels first yourself.
tests = { depends_on = [
    "lint",
    "generate-testmodels",
    "test-ribasim-python",
    "test-ribasim-core",
] }


Question about dist folder

Should the dist/ folder be in .gitignore? It is deleted and recreated when building each time. Or is there a purpose for it to be there in the repo?

In our CI pipeline, we include the dist folder in every release of checkout-js. This practice ensures that the necessary distribution files are readily available for deployment and usage. To illustrate this further, please refer to the following example: https://github.com/bigcommerce/checkout-js/issues/1286.
For your convenience, you can access and download any specific version of the checkout-js repository from our GitHub page, which offers a comprehensive list of tagged releases. Feel free to explore the available versions at: https://github.com/bigcommerce/checkout-js/tags.

Hey @marekceglowski adding from what Peng said, we don't want devs accidentally pushing their local dist folder hence we have added it to gitignore.


ESR-01-010 WP1: Host stdin/out/err File descriptors Accessible by Container Container IO refactoring

Fixed by #777


Maven Central version badge

Can you add one of these for the project please - saves me having to check the releases page to see what the latest released version is, plus you don't need to update your README.md each time.

Thanks!


Improvements to Arabic translation UI

What kind of changes does this PR include?

Changes or translations of Starlight docs site content

Description
Improvements and changed some transliteration.

Thank you for the PR @jermanuts! Would love someone who speaks Arabic to review these changes if possible.
In the meantime, would you mind giving a quick description of what was needed here and why? For example, explaining why داكن is preferable to ليلي, etc.

In Standard Arabic mostly you will see "داكن".
iOS:

Thanks for the input @X7md! Can you confirm the rest of the changes look good to you?

Also google

Great! How about the other changes — https://github.com/withastro/starlight/pull/778/files ?
This PR changes a bunch, not just داكن.

Great! How about the other changes — https://github.com/withastro/starlight/pull/778/files ? This PR changes a bunch, not just داكن.

You can check here https://mostalah.org/ type any word in english. Arabeyes are the best.


SQL parameter hints?

This worked before but after some updates it does not anymore. I guess it's been deleted?
What to use instead? Can't find anything useful in the docs.
hintOptions: {
    parameters: [":foo", ":bar"],
    tables: {
        "sometable":  [ "column1", "column2", "column3", "column4" ]
    }
}

I'm not sure what parameters is supposed to do, but, assuming you're using the sql hinter, tables should still work.

The parameters worked as hints next to the tables, if I did ctrl+space it showed the tables and the parameters. But the parameters part doesn't work anymore. Either I missed something or this worked before but wasn't intend to do.

I don't remember ever having that feature, but then, I don't keep all that close track of sql-hint.js. You can try digging through the git history to see if it ever existed, and if you find it, try to port it forward.

Well, is there any other alternative to add custom hints to sql-hint otherwise?


Remove deprecated go features

[x] Unscoped enum names (deprecated in https://github.com/dagger/dagger/pull/8669)

Re-opening and changing to v0.15.0 in the context of this comment thread https://github.com/dagger/dagger/pull/8900#issuecomment-2465699471


HDDS-3749. Improve OM performance with 3.7% by avoid stream.collect

What changes were proposed in this pull request?
I start a ozone cluster with 1000 datanodes and 10 s3gateway, and run two weeks with heavy workload, and perf om. There are 4 places use stream.collect which cost 3.7% cpu.

stream.collect in Pipeline::getFromProtobuf cost 0.78%

stream.collect in OmKeyInfo::getFromProtobuf cost 1.76%

stream.collect in OMKeyCommitRequest::validateAndUpdateCache cost 0.42%

stream.collect in OMKeyInfo::getProtoBuf cost 0.75

What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3749
How was this patch tested?
Existed tests.

@nandakumar131 Thanks for review. I have updated.

Thanks the quick fix @bharatviswa504.
Do you have any idea how was it possible? The last build seems to be green... What should we improve on our process to avoid some problems?

@elek @bharatviswa504    I think the reason there are code1 and code2 both use java.util.stream.Collectors.   In this patch, I remove code1, and trigger CI, because code2 still use java.util.stream.Collectors, CI does not fail. Then, another commit remove code2, but this patch does not trigger CI again, if trigger, CI will fail, because both code1 and code2 were removed, there are no code use java.util.stream.Collectors. So when merge this patch, CI fail.   Sorry for that.


Added minimum platform problem in cpp using greedy

@mishra10008  Please merge my pull request

@mishra10008  sir please tag this label hackoctober accepted if you fine my pr efficient. Thank you!!


Question about instantiate multiple items

Is there another way to instantiate multiple modals instead of doing it within a script tag? I have a page with a roster of speakers, and I'm trying to set each bio to present a modal of the speaker's bio. From what I see, the only way to instantiate each speaker's bio modal is within a script tag.

Hi @jayhlee,
I'm not sure to understand the question, could you be more specific?


docs: improve documentation for newcomers

Description
This PR moves some documentation around in an attempt to have the most important information available from the main README. I have also rewritten some things and done some extra formatting, but everything should still be there (except for outdated stuff for obvious reasons). I did remove the template-readme files, as they appeared to no longer be relevant (and was also recently removed from the opengeh-repository-template). The diff is kinda wack, so I advise to just look at the final README(s). 😄
To-do:

[ ] Add missing workflow descriptions to CI/CD Pipelines
[ ] Finish Tools section

References

#892

Codecov Report

Merging #950 (2341358) into main (4ee351a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #950   +/-   ##
=======================================
  Coverage   64.85%   64.85%
=======================================
  Files          17       17
  Lines         276      276
  Branches       24       24
=======================================
  Hits          179      179
  Misses         85       85
  Partials       12       12

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[Hub Generated] Review request for Microsoft.Capacity to add version preview/2019-04-01

If you are a MSFT employee you can view your work branch via this link.
Contribution checklist:

[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

Automation for azure-sdk-for-ruby

Automation for azure-sdk-for-python

Automation for azure-sdk-for-js

Automation for azure-sdk-for-java

Automation for azure-sdk-for-go

Can one of the admins verify this patch?

Automation for azure-sdk-for-net
A PR has been created for you:
https://github.com/azure/azure-sdk-for-net/pull/5919
.NET SDK Commits:
https://github.com/adxsdknet/azure-sdk-for-net/pull/5919/commits/74b883fb6230b49ba857468d54fb78307cdcdb1d


State of GPU support for commercial Android devices

Question has been asked in  this thread but got no answer. Just curious what's the plans of TF team to support Android GPUs (or no plan at all) for commercial devices such as Nexus. I understand OpenCL is not included in Android now, but we still have RenderScript. And some work has already been put to this end.
It would be great to know it from TF developers.

@petewarden and @andrewharp: can you offer any guidance?

Most mobile acceleration work being done currently is for the Hexagon DSP, which can offer an order of magnitude speedup. @satok16 has been working on this and may be able to offer more details.
We may also support CUDA on Android in the future, but this would be limited to select Nvidia devices like the TX1/TX2.

@andrewharp Thanks Andre for your reply. So is there any workable toy that I can play with now on any Android GPU? And I saw TF supports OpenCL now (as I configure it it asks me if I want to add OpenCL support). If I have a OpenCL library on my Android device, is it possible that TF can work without further modification?

@PKUEcho See master/tensorflow/contrib/hvx for instructions on running HVX-accelerated TF on supported devices.
We don't currently have internal plans to add OpenCL support on Android, but if the community wants to add it that would be great. I have no idea what sort of issues might be run into though.
Otherwise I'd suggest the HVX option or waiting on CUDA support.

Thanks @andrewharp for your reply!

@PKUEcho For deep learning framework with mobile phone GPU support, you can have a look at MACE and some benchmark results.


[VEN-297] Remove redux

Jira ticket(s)
VEN-297
Changes
Redux and its related libraries are no longer needed as the v2 migration is completed

Another nice clean up 👍


Multi-user performance issues

When hosted at shinyio or cgfi multiple users share a single R instance, since R is single threaded if there is a long running task then all users navigations and interactions must wait for the long running task to finish before they can be processed.
Some articles explaining a potential workaround
https://rstudio.github.io/promises/articles/shiny.html
https://www.r-bloggers.com/2020/03/shiny-performance-tuning-with-future-promises-part-1/
https://www.r-bloggers.com/2020/04/shiny-performance-tuning-with-future-promises-the-practice/

It seems the solution does not work on CGFI server. Investigation in progress

Investigation did not result in any meaningful conclusion. However, it turns out that the async functionality works now correctly, for unknown reason. Closing the issue


Support: Oracle API Gateway as environment list item

What are you trying to achieve?
APIM and APIC customer is requesting Oracle API Gateway support - listed as an environment list item:

@juliajuju93 - Thanks for the bug report! You can now specify any Environment server type you wish by typing directly in the field:

After creating the environment, the type is updated to reflect Oracle API Gateway as requested:


Fix job creating failure across different namespace

Signed-off-by: tu1h<EMAIL_ADDRESS>
What type of PR is this?

/kind bug
What this PR does / why we need it:
Support for kubean and the resources it reference are not in the same namespace
Which issue(s) this PR fixes:

Fixes #481
Special notes for your reviewer:

/lgtm


providers/digitalocean: private ip index bug fix

I just noticed that my private IP was empty in dependent systemctl services because I expected it to be set as COREOS_DIGITALOCEAN_IPV4_PRIVATE_0 but /run/metadata/coreos named it COREOS_DIGITALOCEAN_IPV4_PRIVATE_1. I checked the code and it looks like a minor copy-and-paste error.

Thanks for spotting and fixing this. Just one request and a minor suggestion:

please briefly fill in the body of the commit message, so that tailor is happy
if you are up for some Rust coding, that function may benefit from a little cleanup. In particular, those two *_counter variables should go away in favor of just enumerate().

@lucab Thanks for reviewing this. I'm afraid I've never used Rust before (though it doesn't look too different from C++) and I don't have much time at the moment to set up the build system on my machine and learn the syntax for the full fix. I just wanted to submit this small change before I forgot about it.
The commit message should be fixed now at least.
I'll be happy to contribute more in the future. Sorry about that.

That's totally fine. Commit message looks good to me. Please feel free to contribute in the future if you get the chance, we always welcome contributors!

@tfussell no worries, and thanks a lot for your PR!


Add method to ContentSection to get field names

This moves get_section_questions and get_raw_section_questions from the supplier frontend to avoid exposing the _is_pricing_type method externally. It also brings in a distinction between question IDs, which are used to identify questions in the SSP content. And field names, which are the keys in the API payload that is returned by get_data.

:+1:


work item count for an iteration (create/update/show/create-child).

Like we did in list-iterations response, need to add  WI counts in response of create/update/show/create-child iterations.
Added and modified tests around WI counts.

@pranavgore09 LGTM too once you address the changes proposed by @sbose78 👍

thank you @hectorj2f and @sbose78 for you time and inputs.
I have addressed all those comments here https://github.com/almighty/almighty-core/pull/815/commits/4ac7a5583469d29a24931335d64871a7d4666a24

Codecov Report

Merging #815 into master will decrease coverage by -0.4%.
The diff coverage is 69.23%.

@@            Coverage Diff            @@
##           master     #815     +/-   ##
=========================================
- Coverage   70.38%   69.98%   -0.4%
=========================================
  Files          76       76
  Lines        5322     5348     +26
=========================================
- Hits         3746     3743      -3
- Misses       1223     1244     +21
- Partials      353      361      +8

Impacted Files
Coverage Δ

workitem/undoable_wi_repo.go
17.74% <ø> (-0.6%)
:x:

space-iterations.go
64.7% <100%> (-1.97%)
:x:

iteration.go
84.05% <33.33%> (-2.31%)
:x:

workitem/workitem_repository.go
73.55% <88.23%> (+1.3%)
:white_check_mark:

models/transaction.go
50% <ø> (-30%)
:x:

remoteworkitem/github.go
77.14% <ø> (-22.86%)
:x:

remoteworkitem/scheduler.go
60% <ø> (-17.5%)
:x:

configuration/configuration.go
81.25% <ø> (-1.57%)
:x:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9908fd...4ac7a55. Read the comment docs.