Avoid trying to get datasource name from non-datasource expressions

related to #174

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Manuel Ryan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Merged in #176


Integrate Vultr API2 if possible

What provider would you like to see added to NPM?
Vultr API v2
Have you checked if a certbot plugin exists?
Yes, https://pypi.org/project/certbot-dns-vultr/ which has been updated to support Vultr API v2 based on this GitHub convo:
https://github.com/lezgomatt/certbot-dns-vultr/issues?q=is%3Aissue+is%3Aclosed
Currently, I Can't secure my domains on new Nginx proxy manager installation because the Vultr DNS provider is only using v1, which fails:

Failed to add TXT record for "": Error fetching DNS domains list: 503 - Sorry, all newly created accounts are forbidden from using API v1, all other accounts are able to use this deprecated API until September 30, 2023 at which point Vultr API v1 will be sunset. Please use API v2

If we can get this updated for API V2, it would be greatly appreciated

Same issue here, I have 3 domains which I currently can't renew. Thanks for looking into this.


[improve] [bookie] Change flushEntrylogBytes default value from 256MB to 32MB

Fixes #xyz

Main Issue: #xyz

PIP: #xyz

Motivation

We set flushEntrylogBytes to 256MB in https://github.com/apache/pulsar/pull/6915, however, this value is good for HDD but not SSD. SSD has better performance on small IOs. In order to balance the performance on SSD and HDD, we'd better reduce the value to 32MB.
Modifications

Change flushEntrylogBytes default value from 256MB to 32MB
Verifying this change

[ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[ ] The metrics
[ ] Anything that affects deployment

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository:

Codecov Report

Merging #21131 (ec83a28) into master (c675a3d) will increase coverage by 38.82%.
Report is 25 commits behind head on master.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master   #21131       +/-   ##
=============================================
+ Coverage     33.37%   72.20%   +38.82%
- Complexity    12158    32299    +20141
=============================================
  Files          1623     1887      +264
  Lines        127410   145541    +18131
  Branches      13933    16883     +2950
=============================================
+ Hits          42527   105082    +62555
+ Misses        79258    32037    -47221
- Partials       5625     8422     +2797

Flag
Coverage Δ

inttests
24.14% <ø> (+0.07%)
:arrow_up:

systests
25.05% <ø> (?)

unittests
71.35% <ø> (+39.45%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1535 files with indirect coverage changes


Tailwind 3.x Shift

This pull request contains changes for upgrading to Tailwind 3.x automated by Shift.
Before merging, you need to:

Checkout the shift-57576 branch
Review all pull request comments for additional changes
Run npm install (if nothing installs, try removing package-lock.json first)
Build your CSS assets
Thoroughly review your application for additional styling tweaks

:information_source: Shift detected you were using Just-in-Time (JIT) mode. Since JIT is now enabled by default in Tailwind 3.0, Shift removed your explicit configuration.

:information_source: Tailwind 3.0 changed some of the default color aliases. To maintain the same appearance, Shift explicitly added aliases for any colors used within your project to your Tailwind configuration.

:x: Shift was unable to detect a @tailwind base directive within your project stylesheets. This directive is required in Tailwind 3.0 for utilities like transforms, filters, and shadows to work properly. You may reference the Upgrade Guide for more details on adding this directive.


Native Notebooks - Shift + Enter does not work on first cell of new notebook

Environment data

VS Code version: 1.58.0-insider
Jupyter Extension version (available under the Extensions sidebar): v2021.8.993044620
Python Extension version (available under the Extensions sidebar): v2021.6.944021595
OS (Windows | Mac | Linux distro) and version: Windows

Steps to Reproduce:

Create new notebook
Put something in first cell
Use Shift + Enter shortcut to run

Expected behavior
To be prompted for a kernel and run after selection, then focus moves to next cell
Actual behavior
Focus moves to the next cell, I am not prompted to pick a kernel as none is selected for a new notebook.
Have to put focus back on the first cell and try shift + enter again
*Note: This does not occur if I open an existing notebook that has not been seen by VS Code before

Let's take a look as we contribute shift-enter which just calls VS Code's command. It should popup the kernel.


feat: add Features

What is the purpose of the change
(For example: This pull request improves documation of area A by adding ....
Brief change log
(for example:)

Added content in page XXX
Updated cross reference link in YYY

Verifying this change
(Please pick either of the following options)
This change has been tested locally by rebuilding the doc website and verified content and links are expected
(or)
This change has not been tested locally, because (to-be-explained-why...)

Wow! Nice work here


[FEATURE REQ] Allow users to define the claimToAuthorityPrefix when application_type is web_application or web_application_and_resource_server

Is your feature request related to a problem? Please describe.
When application_type is resource_server, users can define a custom claimToAuthorityPrefix (defaults to "APPROLE_") with the property spring.cloud.azure.active-directory.resource-server.claim-to-authority-prefix-map.roles. However, for web_application the prefix is hardcoded inside the AadOAuth2UserService.extractRolesFromIdToken method.
AadOAuth2UserService.java
Set<String> extractRolesFromIdToken(OidcIdToken idToken) {
        return Optional.ofNullable(idToken)
                       .map(token -> (Collection<?>) token.getClaim(ROLES))
                       .filter(obj -> obj instanceof List<?>)
                       .map(Collection::stream)
                       .orElseGet(Stream::empty)
                       .filter(s -> StringUtils.hasText(s.toString()))
                       .map(role -> AuthorityPrefix.APP_ROLE + role)
                       .collect(Collectors.toSet());
    }

Describe the solution you'd like
Let users define the claimToAuthorityPrefix when application_type is web_application or web_application_and_resource_server by adding a similar property as spring.cloud.azure.active-directory.resource-server.claim-to-authority-prefix-map.roles and using this property in the above method.
Describe alternatives you've considered
For now, I think the alternative is to create an OAuth2UserService bean by extending the AadOAuth2UserService class and overriding the extractRolesFromIdToken method.
Additional context
I am using spring-cloud-azure-starter-active-directory 6.0.0-beta.3
Information Checklist

[ x] Description Added
[x ] Expected solution specified

Hi, @fxpaquette   thanks for reaching out, our repo has to be migrated to azure-sdk-for-java, so I copied the current issue to that repo, let's use that issue to track.

Closing this, redirect to https://github.com/Azure/azure-sdk-for-java/issues/33560.


Define cli params

Definition of the command line arguments. Constructed zarp.config.cli. Modify the setup so that it is used as the entry point.
Fixes #1
Type of change
Please delete options that are not relevant.

[ ] New feature (non-breaking change which adds functionality)

Checklist
Please carefully read these items and tick them off if the statements are true
or do not apply.

[X] I have performed a self-review of my own code
[X] My code follows the existing coding style, lints and generates no new
warnings
[X] I have added type annotations to all function/method signatures, and I
have added type annotations for any local variables that are non-trivial,
potentially ambiguous or might otherwise benefit from explicit typing.
[X] I have commented my code in hard-to-understand areas
[X] I have added ["Google-style docstrings"] to all new modules, classes,
methods/functions or updated previously existing ones
[X] I have added tests that prove my fix is effective or that my feature
works
[X] New and existing unit tests pass locally with my changes and I have not
reduced the code coverage relative to the previous state
[X] I have updated any sections of the app's documentation that are affected
by the proposed changes

Codecov Report

:exclamation: No coverage uploaded for pull request base (dev@6171113). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff          @@
##             dev     #21   +/-   ##
=====================================
  Coverage       ?   8.92%
=====================================
  Files          ?      11
  Lines          ?     728
  Branches       ?       0
=====================================
  Hits           ?      65
  Misses         ?     663
  Partials       ?       0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Closed in favor of #29


Include health checks in the readiness check

Add health checks for REST API and CQL modules
Closes #620

I did some refactoring in the latest commit (as discussed in comments). Please review again.

I did some refactoring in the latest commit (as discussed in comments). Please review again.


Click event on series with area should trigger component event

What problem does this feature solve?
Currently only clicking on exact points of a series results in an event being triggered.
When the series has area shading it should trigger a component event for the series also.
Example the current status with the following:
var container = document.getElementById('main');
var chart = echarts.init(container);
chart.setOption({
  xAxis: {
    data: ['A', 'B', 'C']
  },
  yAxis: {

  },
  series: [{
    type: 'line',
    areaStyle: {},
    data: [120, 200, 150]
  }]
});

chart.on('click', function(params){
  alert('clicked')
})

What does the proposed API look like?
areaStyle: {
    triggerEvent: true
}

Fixed in #15535 which is to be released in 5.3.0.


issue #24: Fixed missing closing quote

Please check the issue URL for details https://github.com/project-trident/trident-core/issues/23

Thanks for catching that!


main.go:846: undefined: s

Could reproduce this, also after deleting go/src/github.com/stapelberg/scan2drive
$ gokr-packer -overwrite=/dev/mmcblk0 github.com/stapelberg/scan2drive
2017/05/18 19:31:37 packer.go:225: installing [github.com/stapelberg/scan2drive]
2017/05/18 19:31:37 gotool.go:60: getting incomplete packages [github.com/stapelberg/scan2drive]
# github.com/stapelberg/scan2drive
src/github.com/stapelberg/scan2drive/main.go:846: undefined: s
src/github.com/stapelberg/scan2drive/main.go:847: undefined: s in s.Serve
2017/05/18 19:34:48 packer.go:228: exit status 2

Woops. Thanks, fixed now. Will set up travis to catch this early in the future.

Travis set up :)


Check if it can easily support python 3.6

According to this graph 3.6 will still exist for along time.
It would be nice to support it if it does not require too many changed.
3.5 is end of life in less than a year so I think it's ok to not support it.

Done in #42


Parse error since last update

Hi,
I have this error since the last update :
/home/****/.oh-my-zsh/oh-my-zsh.sh:42: parse error near `||'
Which is preventing zsh from starting.

Hmm. It's still working for me (on OS X Cygwin), and oh-my-zsh.sh itself hasn't changed since September 28.
Can you do a git status in ~/.oh-my-zsh to make sure you don't have any local modifications?
If you're all synced up, then doing a zsh -lx 2>zsh.log and just doing exit in the resulting shell session will get you a trace log of what zsh is doing on startup, which could help track down the issue.

I found the issue : it's related to #4069
The autocrlf in my .gitconfig was set to true, setting it to false fixed the problem after a new installation.


Add support for Connection URL arguments to Dronecore Applications

Supports TCP, UDP, Serial connection interfaces
Updates takeoff_land example
Issue: #244

Yes, looking good. Some more minor comments.

Verified the connections(serial, udp, tcp) on Intel Aero

Looks good to me.

@Rjasuja looks like there is a style issue left:
https://travis-ci.org/dronecore/DroneCore/jobs/345624574#L879-L888

Updated PR with style changes. Sorry, i missed it again

@Rjasuja thank you!


Modal dialogs always open fullscreen on iOS

Environment

CLI: 5.0.1
Cross-platform modules: 5.0.3
Android Runtime: 5.0.0
iOS Runtime: 5.0.0
NativeScript-Angular: 6.2.0
Angular: 6.1.0

Describe the bug
Modal Dialogs on iOS always display in fullscreen mode, even when fullscreen is set to false.
The fullscreen flag is properly honored on Android.
To Reproduce
Create a HelloWorld app using tns create HelloWorld --ng.
Add a button on the Home page to create a modal dialog. Add a modal dialog component.
On iOS, the dialog always displays full screen.
Expected behavior
iOS should behave the same as Android: when fullscreen is false the dialog should not take up the full screen.
Sample project
Here is the code for my sample modal dialog and the code that displays the dialog.
modal.component.ts:
import { Component } from "@angular/core";
import { ModalDialogParams } from "nativescript-angular/modal-dialog";

@Component({
  selector: "my-modal",
  moduleId: module.id,
  templateUrl: "./modal.component.html"
})
export class ModalComponent {
  words = ["alphabet", "brightness", "color"];

  constructor(private params: ModalDialogParams) {
  }

  close(response: string) {
    this.params.closeCallback(response);
  }
}

modal.component.html:
<GridLayout>
  <ListView [items]="words" class="list-group">
    <ng-template let-word="item">
      <StackLayout (tap)="close(word)" class="list-group-item">
        <Label [text]="word" class="label"></Label>
      </StackLayout>
    </ng-template>
  </ListView>
</GridLayout>

In home.component.ts:
    showModal() {
        let options: ModalDialogOptions = {
            context: {},
            fullscreen: false,
            viewContainerRef: this.vcRef
        };
        this.modal.showModal(ModalComponent, options).then(res => {
            console.log(res);
        })
    }

@RobertGardner currently the modals on iOS are fullscreen by default (which is the iOS recommendation and design guideline). We have a feature request to enhance the modals by proving more supported native options  (here). At this very moment, fullscreen is the only option on iPhone (some possible suggestions are discussed in numerous threads - see these  search results)
Closing as related to the linked feature request.


Zooming over input/radio elements

if you have radio buttons (or i'm assuming other input elements), if the state of them changes, then AnythingZoomer displays the previous state and not the current state when you zoom over again.
you can replicate this in the playground app by adding some radio buttons, zooming over them, double click, change the state of a button, then double click again, then zoom again.

Hi @a-espitia!
Handling form elements isn't built-into AnythingZoomer; but you could use the zoom & unzoom callbacks to listen for changes and update the elements (demo):
$(function() {
  var targets = 'select, input',
    busy = false;

  function updateEls($large, $small) {
    $large.each(function(index, el) {
      if (el.type === 'radio' || el.type == 'checkbox') {
        $small[index].checked = el.checked;
      } else {
        $small[index].value = el.value;
      }
    });
  }

  $("#zoom1").anythingZoomer({
    clone: true,
    // zoom window visible
    zoom: function(e, zoomer) {
      var $large = zoomer.$large.find(targets),
        $small = zoomer.$small.find(targets);
      // change the name attribute of the large radio buttons to
      // separate them from grouping with the small radio buttons
      $large.filter('[name="group"]').each(function(_, el) {
        el.name = 'group2';
      });

      updateEls($large, $small);
      zoomer.$large.on('change, input', targets, function() {
        updateEls($large, $small);
      })
    },

    // zoom window hidden
    unzoom: function(e, zoomer) {
      zoomer.$large.off('change');
    }

  });
});

that seemed to get me a bit closer, however when the zoom it disabled, it's preventing some/most of the input elements.  here's a mockup, if I did it right...
https://jsfiddle.net/aespitia/1xhk3o4b/7/

here's another slight update.  if the button is pre-selected, zoom gets rid of it.  for this example, i preselected radio button 3, but it appears blank, however, when i hover over it, it's there.  so, it's like it kep the selection in the large, but got rid of it in the small window
https://jsfiddle.net/aespitia/1xhk3o4b/11/

In the zoom funciton, I should have switched the parameters of the updateEls function; and for some reason, the overlay is interfering with form interaction - I'll fix that in the code - so I think this demo should work now:
var isMagnifyEnabled = true,
  targets = 'select, input',
  busy = false;

function updateEls($large, $small) {
  $large.each(function(index, el) {
    if (el.type === 'radio' || el.type == 'checkbox') {
      $small[index].checked = el.checked;
    } else {
      $small[index].value = el.value;
    }
  });
}

function ToggleZoom() {
  if (isMagnifyEnabled) {
    $('#zoom1').anythingZoomer('disable');
    isMagnifyEnabled = false;
  } else {
    $('#zoom1').anythingZoomer('enable');
    isMagnifyEnabled = true;
  }
}
/*
 Demo for jQuery AnythingZoomer Plugin
 https://github.com/CSS-Tricks/AnythingZoomer
 */
$(function() {
  $("#zoom1").anythingZoomer({
    clone: true,
    overlay: false,
    // zoom window visible
    zoom: function(e, zoomer) {
      var $large = zoomer.$large.find(targets),
        $small = zoomer.$small.find(targets);
      // change the name attribute of the large radio buttons to
      // separate them from grouping with the small radio buttons
      $large.filter('[name="group"]').each(function(_, el) {
        el.name = 'group2';
      });
      updateEls($small, $large);
      zoomer.$large.on('change, input', targets, function() {
        updateEls($large, $small);
      })
    },

    initialized: function(e, zoomer) {
      isMagnifyEnabled = true;
      // overlay preventing interaction with form elements
      // TODO: fix
      zoomer.$overlay.remove();
    },

    // zoom window hidden
    unzoom: function(e, zoomer) {
      zoomer.$large.off('change');
    }

  });
});

that's awesome, i think that does cover most of it, except for the preloaded checkbox losing it's selection.
i just added checked="checked" on radio 2
https://jsfiddle.net/aespitia/1xhk3o4b/30/

I moved the renaming of the groups to the init function, and re-checked the radio button because it was changed - demo
var isMagnifyEnabled = true,
  targets = 'select, input',
  busy = false;

function updateEls($large, $small) {
  $large.each(function(index, el) {
    if (el.type === 'radio' || el.type == 'checkbox') {
      $small[index].checked = el.checked;
    } else {
      $small[index].value = el.value;
    }
  });
}

function ToggleZoom() {
  if (isMagnifyEnabled) {
    $('#zoom1').anythingZoomer('disable');
    isMagnifyEnabled = false;
  } else {
    $('#zoom1').anythingZoomer('enable');
    isMagnifyEnabled = true;
  }
}
/*
 Demo for jQuery AnythingZoomer Plugin
 https://github.com/CSS-Tricks/AnythingZoomer
 */
$(function() {
  $("#zoom1").anythingZoomer({
    clone: true,
    overlay: false,
    // zoom window visible
    zoom: function(e, zoomer) {
      var $large = zoomer.$large.find(targets),
        $small = zoomer.$small.find(targets);
      updateEls($small, $large);
      zoomer.$large.on('change, input', targets, function() {
        updateEls($large, $small);
      })
    },

    initialized: function(e, zoomer) {
      isMagnifyEnabled = true;
      // change the name attribute of the large radio buttons to
      // separate them from grouping with the small radio buttons
      zoomer.$large.find(targets).filter('[name="group"]').each(function(_, el) {
        el.name = 'group2';
      });
      zoomer.$small.find('[checked]').prop('checked', true);
      // overlay preventing interaction with form elements
      // TODO: fix
      zoomer.$overlay.remove();
    },

    // zoom window hidden
    unzoom: function(e, zoomer) {
      zoomer.$large.off('change');
    }

  });
});

In the latest version, you won't need to include zoomer.$overlay.remove(); anymore.

Thank you so much for your help, this is a great library!


[SPARK-43066][SQL] Add test for dropDuplicates in JavaDatasetSuite

What changes were proposed in this pull request?
This PR proposes to add test for dropDuplicates in JavaDatasetSuite.
Why are the changes needed?
The API dropDuplicates wasn't tested by Java test suite. It'd be better to have a sanity check to verify inter-op between Scala and Java works well.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
CI will verify.

Merged to master.

Thanks for reviewing and merging!


[feature] Maintaining inverse covariance matrix in state and applying updates

Following basic matrix manipulations (read: nothing fancy, see e.g. Algorithm 1 in this source) the kernel matrix inversion might be maintained in state and updated incrementally. This would drastically reduce the time complexity of prediction steps.
I'm happy to tackle this myself, or if someone else takes it first, great - I'm writing this issue to ask for input on the best place to prototype this feature: should it go in GPy/core/gp.py ? Or somewhere else?

It seems like downdates would be an additional feature - clearly useful but not a blocker for online updates - is that right?
And, as long as the numerical instability is disclosed (and not abysmal), the Woodbury update seems like a good starting point - albeit a flawed one.
I'll have to dig into Dr Seeger's thesis...

Following basic matrix manipulations (read: nothing fancy, see e.g. Algorithm 1 in this source) the kernel matrix inversion might be maintained in state and updated incrementally. This would drastically reduce the time complexity of prediction steps.

What is the motivation of doing the incremental matrix inverse update?
For GPs, we often update the kernel parameters frequently, which results into a complete recomputation of the covariance matrix, therefore, an incremental matrix inverse is not plausible. I know such tricks are used in Bayesian linear models for online learning, in which the basis functions are not changed.


Proxy question

I see that proxy is on port 8888 which is the default port for oscam. I have two questions:

is it possible to change proxy port number with env variable?
is dns routed over the proxy too in order to prevent any IP leaks?

You can now use the environment variable PROXY_PORT to set tinyproxy's port.
To verify this, I have set my DNS on my computer to some non existent LAN IP addresses so my internet would no longer work. When going through the proxy, it would work meaning the DNS is routed through the proxy, which itself forwards the DNS traffic to Unbound (<IP_ADDRESS> from its point of view) which forwards it to <IP_ADDRESS> over TLS.

I can't stop repeating myself, you are doing some real amazing job here. This is certainly the best VPN docker available.
I will test it tonight and report back.


The package in NPM is not updated

The package in NPM (version 2.4.0) is not updated with the latest modifications, see:
Latest vs version 2.4.0
I was having a lot of trouble to work with the package till realize this.

Please @remixz consider doing it.
It could be annoying (as working on it this morning for nothing 😢 ).
There are important function's modifications between these two versions such as PersistentMenu, GetStartedButton or even GreetingText.

@remixz This issue can be closed as the v2.5.0 is out.


Feature request

Any one click droplets which are coming up in the near future in the DO or another services?

Hi @joeshua,
That would really be a question for those services, rather than Wagtail itself...
Divio and CodeRed both offer cloud hosting solutions for Wagtail.


Added module for InfluxDB 0.9

Hello,
I created a module for InfluxDB 0.9, thought I'd share.
Regards,
Mike Cebrian

@zackbloom influxDB 0.9 is now stable. Is it possible to have this PR merged? or is there something else that needs to be done on my end?
Regards,
Mike Cebrian

Hi @JSMike, thanks.  Does the current influx db logger not work with 0.9?

The current one only works with Influxdb 0.8.
influxdb 0.9 had some breaking changes: https://influxdb.com/docs/v0.9/about/release_notes.html
"Note: Version 0.9.0 is a completely rewrite of the 0.8.8 codebase. Due to the many breaking changes to the API, versions 0.8 and 0.9 are not interoperable."

Would it be possible to end up with one connector which takes an option of which version it should be compatible with?

What would you like it to default to if the version isn't entered? 0.8 or 0.9?

As long as we bump the major version of BuckyServer in the process, I believe 0.9 would be fine.

Hi,
I've updated the module to work for either version of influxdb. The version can be set in config by changing the legacy flag, either true for influxdb 0.8 or false 0.9. This defaults to false.
I also updated the version to 0.5.0
Note: This may need another update in the future. While the influxdb change log has no mention of deprecating the JSON write protocol, I just noticed that it's listed as deprecated in their documentation. A larger rewrite will be required to use their line protocol :(

Re your note, why don't we change legacy flag to instead be a version string option which can be set to '0.8' or '0.9'.  That way we have a clear path if we need to make another change in the future.

Hi, I'm back. I had some other priorities come up.
I also added a fix for when running BuckyServer outside of the BuckyServer path.
I ran into this issue when running BuckyServer as a service through forever.
It's an issue with the config module, it looks for the config directory using process.cwd() and when the process is started outside of the BuckyServer path it's unable to find the config and fails.
The fix is simple, server.coffee sets the process directory.

@zackbloom Let me know if any other changes are necessary.


Make e2e tests 4, 5, and 9 independent

E2E PULL REQUEST
Related Issue

#7007
Partially #7008

Changes Proposed

Makes specs 4, 5, and 9 independently rerunnable by setting up required data before each spec run

Additional Information

Had to include 9 because it was failing after the changes to 4 and 5
To get spec 5 to run locally, you might need to update your local environment variables for the cypress frontend url so that it can load the patient link correctly. Not sure if this was only because of my individual local environment setup or if this is a common issue that others come across as well. If it is I'd be happy to look into modifying request-utils to make it easier to run locally.

Testing

Run all cypress tests locally

left a couple questions on the setup / util files. will do a second pass on the specs themselves soon


🐛 [firebase_auth] iOS doesn't return quotaExceeded error

Bug report
When a user exceeds the maximum number of phone verification requests he gets verifyPhoneNumberError  instead of quotaExceeded.
Steps to reproduce
Steps to reproduce the behavior:

Call verifyPhoneNumber multiple times.
Phone number is blocked due to to many requests.
Android app gets 'quotaExceeded' error and an iOS app gets verifyPhoneNumber.

Expected behavior
Both platforms should get the same error, described what happened, which is quotaExceeded error.

Flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 1.20.4, on Mac OS X 10.15.6 19G2021, locale en-US)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
[✓] Xcode - develop for iOS and macOS (Xcode 12.0)
[✓] Android Studio (version 4.0)
[✓] VS Code (version 1.49.2)
[✓] Connected device (1 available)

• No issues found!

Flutter dependencies
firebase_auth: 0.16.1

@DamianW93
The latest and re-worked plugin version is ^0.18.1. Can you upgrade to latest and try again to see if it works for you ?
Thanks.


CreateNetwork clarifications --- toatally confused

Hi,
The instructions of how to run CreateNetwork are truly murky because there is no folder called "annotated_tfbs" nor is there an example file.  After a lot of head-scraching this is what I have come up with -- the "mapping_togene" file was the easiest part.
I ran the snakemake pipeline and I am attaching screenshots of my folders from the output folder.  One is the whole folder, and the other is the subfolder "TFBS".  And the subfolders of each TF....

The CreateNetwork talks about ,bed file. I presume this is actually a folder of .bed files??? This I see from the example command and looking in the folder it references in

$ TOBIAS CreateNetwork --TFBS test_data/annotated_tfbs/* --origin test_data/motif2gene_mapping.txt
So the annotated_tfbs/* implies the folder of bed files as in the test data.  Is that right? But there is no such folder in my snakemake outputs.

So in the snakemake ouput this folder is not present, however, there is the TFBS folder  (picture: "TOBIAS TFBS folder") that has individual TF files.

Within each of these folders is a separate bed folder.  Within this bed folder of each TF, is a "_bound.bed" file for each of my conditions.

So this is the file I need to use.  Can you please confirm that?

But then I have to copy each of these "_bound.bed" files to a separate folder and per condition.

Then I can run "CreateNetwork".

Thanks!

UPDATE:  What I outline above does not work, since it wants only one input file. I cannot input multiple files or a collection of bed files.....can I?
After some more juggling, I ran the CreateNetwork with a single "_bound.bed" file for one TF.  This gives me a 1:1 relationship between the TF and other TFs.  I got the following files

adjacency.txt
ANDR_HUMAN.H11MO.1.A_path_edges.txt
ANDR_HUMAN.H11MO.1.A_paths.txt
edges.txt

A. If I look at file 2, it is just a 1:1 between ANDR (androgen receptor) and another TF.  Since this is a "bound" file to begin with, am I looking at TFs that ANDR regulates or whose gene has a ANDR binding site? SInce this is a 1:1 file there seems to be no reason to make a figure out of it.
B. If I look at file 4, edges.txt, it has all the peak information etc., and the last column is the TFs listed in file 2.  The columns have no labels though, it just says SItes1, Sites 2 etc.
C.  How do I create a deeper network? Can I integrate more than 1 TF bed file?
Thanks!
C. What program do you suggest I visualize all this with?

Hey,
you are right, to create proper networks, you will want to use all _bound.bed files from your BINDetect analysis. The pipeline annotates each TFBS with gene IDs of associated genes (=genes that are regulated by the TF being bound there), which are used to create the networks. Because this is not the default output of BINDetect, as these TFBS have not yet received an annotation, the test data has a separate directory with such prepared bed files. However, as I said, the pipeline already handles the annotation and modifies your _bound.bed files with it, so you can just use them for CreateNetwork without additional steps. To use them all at the same time as input (given that you have the default BINDetect output structure), you can use --TFBS TFBS/*/beds/*_<condition>_bound.bed as argument to get the network for one of your conditions (you have to replace <condition> with the name of the condition you want to analyze). The * just means that all characters are allowed here, so all files that fit the other characters but are different at these * parts of the path will be included.
One thing you have to keep in mind is that your --origin file has to match your organism and the TF names have to match the naming scheme used in your analysis. If you are working with human data and the TF names are identical to those in your output, you can use the motif2gene_mapping.txt from the test data. However, if you want to use a specific annotation version or have a different organism, you will need to create one yourself. This issue describes how to create the file from scratch. You can just take the genes.gtf file for your organism and get all lines where gene_name matches one of your TF motif names from your JASPAR file. Each line left contains both the gene_name and gene_id, which you can then use to fill your two columns for you --origin file.
But as you were already able to run CreateNetwork with just one file, this seems to work for you already.
The ANDR_HUMAN.H11MO.1.A_path_edges.txt output file you are talking about shows all genes that had ANDR bound at their promoter, not only a binding site present (though if you wanted to check for that too, you could use the _all.bed files instead of the _bound.bed files). Therefore, ANDR should influence this gene's expression in some way.
File 4 is a global overview containing all information of all TFBS with an annotated target gene + their target gene. So instead of just showing which TF influences the expression of which gene, it also mentions the specific TFBS and other information contained in the input bed file. If you have more input files, it will merged all the information of every TF in this file, while the TF specific files only contain the paths there the specific TF is involved.
The output files can be used as input for any software that create network visualization. There are a few, one I can recommend is Cytoscape, but you can use a tool of your choice.
You can either use the global edges.txt file containing all factors (also contains more information), or the individual networks for each TF (<TF>_path_edges.txt). Within Cytoscape, you can load the network using: "File" -> "Import" -> "Network from file" and set the appropriate Source and Target nodes. You can then use Cytoscape to visualize the network with different layouts.
I hope this clears up your questions!

Hi,
Fantastic! Thanks for your clear explanation and your patience. I really appreciate it.
I will have to try the multiple bed files and report back to you.
Thanks!

UPDATE: So if I point to the folder with the multiple beds and try to input multiple beds at once like this:
 (TOBIAS_ENV) premsubramaniam@pop-os:~/TOBIAS_snakemake/createnetwork_output$ TOBIAS CreateNetwork --TFBS '/home/user/TOBIAS_snakemake/LNCAP_ALL/Copied_Beds/PR_beds/*PR_bound.bed' --origin '/home/user/TOBIAS_snakemake/HOCOMOCOv11_full_annotation_HUMAN_mono.tsv'
I get the error:
ERROR: File "/home/user/TOBIAS_snakemake/LNCAP_ALL/Copied_Beds/PR_beds/*PR_bound.bed" does not exists
Stumped here....
Regards!

UPDATE 2:  So after a lot of commands I conclude it needs an explicit reference to a SINGLE input .bed file.  Anything else does not work.

I can assure you, you can and usually should use multiple input bed files. The problem with your attempt was the use of quotation marks ' in conjunction with wildcards *. If remove the '' from your --TFBS argument, it should work if everything else is correct. Using quotation marks tells the computer that it should take the string input literally as it was written, but in your case, because you used a wildcard to find multiple files with slightly different names, that is not what you want.

You're really good! :-)
Yup, removing the '....' and it reads the whole folder of beds.  Of course, for all the HOCOMO TFs the output exceeds 200GB... phew!.

I ran CreateNetwork on a batch of " _bound.bed" files and got
adjancent.txt
edges.txt
a paths and edges file for each TF for which inputted the bed file.
The edges.txt file output is attached.
What are the column names?
Is this the file to use for looking at the whole network?
Which column is source and which is target?
At the last column there is are names of TF matched to my input mapping files. However, in colmn 4 ="Sites 3" the original HOCOMOCO names are still retained.
If you can please clarify which file to use to build the network and how the connections go it would be very helpful!
edges.txt


Main home page

Context
This page should be the first impression of HYF Belgium

What is HYF?
What's the vision and mission?
Link to students page
Link to sponsorship page
Testimonials
...

This page should be findable through some SEO researches.
Header
Logo -> Image redirect sur home
Navigation

Programe
Collaborate
Volunteer
About us

Sections
Banner
Image background + tagline
Discover
3 blocks section
[see  current block OUR IMPACT]
Success stories
Caroussel with testimonials
Donation
Like now or just
Contact
Mail form + map

See this for inspiration: https://migracode.openculturalcenter.org/


Memory leak when multiple network interface is used

I have a netty server that accept connections and broadcast messages to clients. The server listens to <IP_ADDRESS> . Recently, I realize when there are connections from both <IP_ADDRESS> and the server's IP address, there are serious memory leak and basically every outgoing Direct ByteBuffer were strongly referenced and cannot be gc'd. When only one network interface is used, there is no such problem.
The problem doesn't affect me any more once the behavior is identified. I'm just reporting to see if it is a Netty bug.
environment
Netty: 4.0.25.Final, 4.0.26.Final
Java: java version "1.8.0_31"
  Java(TM) SE Runtime Environment (build 1.8.0_31-b13)
  Java HotSpot(TM) 64-Bit Server VM (build 25.31-b07, mixed mode)
Linux: Linux 3.13.0-32-generic

Server Bootstrap code
new ServerBootstrap()
                    .option(ChannelOption.SO_BACKLOG, 1000)
                    .group(boss, work)
                    .channel(NioServerSocketChannel.class)
                    .option(ChannelOption.TCP_NODELAY, true)
                            //.childOption(ChannelOption.ALLOCATOR, PooledByteBufAllocator.DEFAULT) //not active, so the server is using default allocator

Code that write simply use writeAndFlush to a ChannelGroup:
ChannelGroup connections = new DefaultChannelGroup(GlobalEventExecutor.INSTANCE);
connections.writeAndFlush(buf, matcher);

@mingfai - Thanks for reaching out and reporting this issue.  Do you observe this problem only when these 2 connections are present?  For example if you have 2 connections from other interfaces is the problem still present?  Is there an interesting combination of 2 connections that isn't exactly what you reported where the issue still exists?

@Scottmitch there are two connections from remote and one connection to the loopback address.
With further investigation, my initial assessment that suggest using two different interfaces is may probably be wrong. instead, the non-loopback interface is busy and not able to flush the bytes to the network fast enough. by not to use the loopback address and also reduce network activity the leak seems to be gone.
the symptom is a lot DirectByteBuffer accumulated in the heap can't be free even by a explicit force GC with JVisualVM, and the heap dump indicates those direct buffer are strong referenced. So I can just say in certain scenario, there is memory leak, but can't tell what exactly caused the leak yet.
i'll keep this issue updated. thx

@mingfai also if you could share the heap dump and / or provide a reproducer it would be easier to help. Thanks!

i think i can't provide more information on this issue. thx for your help.

we have upgrade to 4.0.33 then we started seeing High CPU Utilization and server unresponsive . We are using same SimpleChannelInboundHandler for WebSocket and Http Requests . Any help on this greatly appreciated.
we are seeing weird behavior , We are running some Load Test with 400 to 500 websocket connections open and sendign 100-200k messages . Load Testing is going perfectly well but actually the problem starts after compeltion of the Test , Memory Utilization is increasing within short time (1hr to 2hr) then CPU Utilization is reaching 100% and Server unresponsive and some requests are able process at this time also but only 5% chance of success.

@SUNILKAITHA - please open a new issue and provide a reproducer if possible


macincloud systems reporting 100% inode use in Nagios

We've got a lot of these messages in the infrastructure-bot channel related to the macincloud which is concerning and likely needs remediation if it's correct for the macos file system:
HOST: test-macincloud-macos1201-x64-1   SERVICE: Disk Space Root Partition STATE: WARNING MESSAGE: DISK WARNING - free space: / 16525 MiB (13.47% inode=100%)
HOST: test-macincloud-macos1201-x64-2   SERVICE: Disk Space Root Partition STATE: WARNING MESSAGE: DISK WARNING - free space: / 23837 MiB (19.43% inode=100%)
Originally posted by @sxa in https://github.com/adoptium/infrastructure/issues/3372#issuecomment-1932276825
Noting that they are currently offline while we're testing orka, but we should look at checking and resolving this, then re-enabling them.

@steelhead31 Can you take a look at the cause of this - it looks like there is an automounter controlling /home which may be throwing Nagios - also bear in mind that the home directories are under /Users instead of /home on macos.
map auto_home            0        0         0   100%       0         0  100%   /System/Volumes/Data/home

Having done some digging, the root file system for these machines is split across 2 volumes.. e.g
DISK WARNING - free space:
/ 16523 MiB (13.46% inode=100%);
| /=106156MiB;98143;110411;0;122679

As a result, the nagios check_disk plugin needs an additional parameter to calculate the combined space of both of these file systems, the --combine-thresholds parameter should be specified..
DISK OK - free space:
/ 16523 MiB (13.46% inode=100%);
| /=106156MiB;98143;110411;0;122679
A small update to the nagios configuration now has these filesystems alerting properly :)
We should probably look to extend the coverage to other file systems, if these continue to be required.


Release notes generator

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

I like the idea. Didn't read the code but I think this could be a good idea.

[...] but we strongly disagree with the method

Just for clarity's sake, which group are you referring to here? The NixOS documentation team?

I still have some checks to do so the change can be applied seamlessly, hence the lack of overview in the PR description. The reason I went with this approach is because I received feedback from contributors stating that they didn't want to deal with release notes merges from unrelated changes, hence the splitting into separate files that get concatenated.

widening the release notes like this and reconstruction them with (haphazard) string concatenation

Why is the concatenation haphazardous? I don't follow here. The current state of release notes is a collection of list entries, which can be enforced as a format need be.

is not very maintainable in the long run,

Agreed, this is a temporary change to enable editing changes in the release notes. The generation should be more automated as you suggest later and I planned to keep working on further automation that would decouple the actual content generation (provided by contributors) from the rendering/editing (coordinated by the release editor, a role I'm filling for this release).

and we're not entirely sure why we should place the kind of change before the changed thing?

I don't understand what you mean here.

instead we'd propose to make release notes a new module meta attribute (alongside meta.docs) and integrate more with nixos-render-docs (that's why we have a special tool: to hack it as needed!). nixpkgs changes can be put into a placeholder module used only in the docs build, and historic changelogs can be archived when modules are deleted.

This is very valuable feedback, I can explore this further for incoming automations and I'd like to coordinate with you about this topic.
PS: Please, bear in mind that I decided to start working in some kind of practical splitting of notes after I tried to merge some readability improvements on #260467 and receiving feedback from contributors.

@pennae Thanks for clarifying. I think we do agree on a path forward where we render the contents from metadata (in fact I wanted already to start doing so for the "New services" section, as it barely adds any editing beyond the package meta.description for most entries).
The points you are making are valid, but they are problems already existing with the current release notes setup. First, contributors already add list entries to the release notes, so it's the correct assumption to make to have a clean transition to have reassembled notes. And second, the existing section already split logical units into sections that are far apart from each other.

as it stands it makes writing release notes harder, not easier (and doesn't solve the problem of merge conflicts, they're just in different files now)

This approach does get rid of merge conflicts for contributors. In the current state they can arise when two contributors add an entry to the same position of a list concurrently. I don't think it is a bad trade-off to ask people to add entries on files instead of a common relative big file. Contributors won't be interfering with each other's entries after the change, only with the release editor.

Hi @alejandrosame I think what @pennae says has a lot of sense, I would be willing to pair with you so we can maybe try to get closer to this vision of the changelog generation / release notes generation while using your work.
What do you think about that?

@RaitoBezarius sure, like I said, I also agree with @pennae on the vision.


if state has single key, mapStateToProps hasn't whole state as parameter

Hello,
If my state tree looks something like { text: ""}. In this case, mapStateToProps will has only text as parameter. But, if my state tree looks like { text: "", name: ""} and now I have two reducers and mapStateToProps will has whole state tree as parameter. If I need whole state tree in mapStateToProps when there is only one key in state, I need to use combineReducer. Is this intentionally or for some other reason?. Please fill free to close this if this is discussed already and give me that link.
Thanks

Unfortunately I don’t quite understand the question.
mapStateToProps() receives whatever the shape of your state is. So if it is { text, name }, whether you use combineReducers() or write root reducer by hand, you will get { text, name } there.
We suggest using combineReducers() in larger apps but it doesn’t make sense to use it when you only pass a single key. The whole point of combineReducers() is to combine multiple reducers by their keys. If you don’t have multiple reducers yet, don’t worry about it.


[bug] The input/output panel should be hidden if not authorized

Describe the bug
I forgot to test it in restricted mode (the default) so it looks buggy:

Reproduction

Do not set MTB_EXPOSE
Panel is empty as the endpoint reject the request

Expected behavior
Completely hide it when restricted
Operating System
Windows (Default)
Comfy Mode
In a custom virtual env (venv, virtualenv, conda...)
Console output
Not relevant

Additional context
This should all be documented somewhere

How can i "authorize the session" or expose? Is it because i ve enabled user login in my ComfyUI?

Debug:
Disabled

Exposed:
False

Prestartup times for custom nodes:
   0.0 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/ComfyUI-Easy-Use
   0.0 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/rgthree-comfy
  51.6 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/ComfyUI-Manager
Total VRAM 22503 MB, total RAM 63592 MB
pytorch version: 2.5.0+cu124
Set vram state to: NORMAL_VRAM
Device: cuda:0 NVIDIA A10G : cudaMallocAsync
Using pytorch cross attention
[Prompt Server] web root: /home/ubuntu/ai/ComfyUI/web
/home/ubuntu/ai/ComfyUI/venv/lib/python3.12/site-packages/kornia/feature/lightglue.py:44: FutureWarning: `torch.cuda.amp.custom_fwd(args...)` is deprecated. Please use `torch.amp.custom_fwd(args..., device_type='cuda')` instead.
  @torch.cuda.amp.custom_fwd(cast_inputs=torch.float32)
[comfy_mtb] | INFO -> loaded 93 nodes successfuly
[comfy_mtb] | INFO -> Some nodes (2) could not be loaded. This can be ignored, but go to http://None:8188/mtb if you want more information.
[comfyui_controlnet_aux] | INFO -> Using ckpts path: /home/ubuntu/ai/ComfyUI/custom_nodes/comfyui_controlnet_aux/ckpts
[comfyui_controlnet_aux] | INFO -> Using symlinks: False
[comfyui_controlnet_aux] | INFO -> Using ort providers: ['CUDAExecutionProvider', 'DirectMLExecutionProvider', 'OpenVINOExecutionProvider', 'ROCMExecutionProvider', 'CPUExecutionProvider', 'CoreMLExecutionProvider']
Efficiency Nodes: Attempting to add Control Net options to the 'HiRes-Fix Script' Node (comfyui_controlnet_aux add-on)...Success!
### Loading: ComfyUI-Manager (V2.55.5)
### ComfyUI Version: v0.3.7-43-gd6656b0 | Released on '2024-12-17'
[ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/alter-list.json
[ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/github-stats.json
[ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/model-list.json
[ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/extension-node-map.json
[ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/custom-node-list.json
no module 'xformers'. Processing without...
no module 'xformers'. Processing without...
[ReActor] - STATUS - Running v0.5.2-a2 in ComfyUI
Torch version: 2.5.0+cu124
[rgthree-comfy] Loaded 42 extraordinary nodes. 🎉
[ComfyUI Model Manager] current version 2.1.6, web version 2.1.1
[ComfyUI Model Manager] Downloading web distribution...
[ComfyUI Model Manager] Extracting web distribution...
[ComfyUI Model Manager] Web distribution downloaded successfully.
Total VRAM 22503 MB, total RAM 63592 MB
pytorch version: 2.5.0+cu124
Set vram state to: NORMAL_VRAM
Device: cuda:0 NVIDIA A10G : cudaMallocAsync
[tinyterraNodes] Loaded
here: /home/ubuntu/ai/ComfyUI/custom_nodes/ComfyUI-tbox
Using ckpts path: /home/ubuntu/ai/ComfyUI/custom_nodes/ComfyUI-tbox/../../models/annotator
Using symlinks: False
Using ort providers: ['CUDAExecutionProvider', 'DirectMLExecutionProvider', 'OpenVINOExecutionProvider', 'ROCMExecutionProvider', 'CPUExecutionProvider']
Loaded Efficiency nodes from /home/ubuntu/ai/ComfyUI/custom_nodes/efficiency-nodes-comfyui
Loaded ControlNetPreprocessors nodes from /home/ubuntu/ai/ComfyUI/custom_nodes/comfyui_controlnet_aux
Loaded AdvancedControlNet nodes from /home/ubuntu/ai/ComfyUI/custom_nodes/ComfyUI-Advanced-ControlNet
Could not find AnimateDiff nodes
Loaded IPAdapter nodes from /home/ubuntu/ai/ComfyUI/custom_nodes/ComfyUI_IPAdapter_plus
Loaded VideoHelperSuite from /home/ubuntu/ai/ComfyUI/custom_nodes/ComfyUI-VideoHelperSuite
### Loading: ComfyUI-Impact-Pack (V8.0.1)
### Loading: ComfyUI-Impact-Pack (V8.0.1)
Loaded ImpactPack nodes from [Impact Pack] Wildcards loading done./home/ubuntu/ai/ComfyUI/custom_nodes/ComfyUI-Impact-Pack
[Impact Pack] Wildcards loading done.
WAS Node Suite: OpenCV Python FFMPEG support is enabled
WAS Node Suite Warning: `ffmpeg_bin_path` is not set in `/home/ubuntu/ai/ComfyUI/custom_nodes/was-node-suite-comfyui/was_suite_config.json` config file. Will attempt to use system ffmpeg binaries if available.
WAS Node Suite: Finished. Loaded 218 nodes successfully.
        "The only person you should try to be better than is the person you were yesterday." - Unknown
@@device:cuda
@@device:cuda
Please 'pip install xformers'
Nvidia APEX normalization not installed, using PyTorch LayerNorm
# 😺dzNodes: LayerStyle -> Cannot import name 'guidedFilter' from 'cv2.ximgproc'
A few nodes cannot works properly, while most nodes are not affected. Please REINSTALL package 'opencv-contrib-python'.
For detail refer to https://github.com/chflame163/ComfyUI_LayerStyle/issues/5
Failed to auto update `Quality of Life Suit`
QualityOfLifeSuit_Omar92_DIR: /home/ubuntu/ai/ComfyUI/custom_nodes/ComfyUI-QualityOfLifeSuit_Omar92
[ComfyUI-Easy-Use] server: v1.2.6 Loaded
[ComfyUI-Easy-Use] web root: /home/ubuntu/ai/ComfyUI/custom_nodes/ComfyUI-Easy-Use/web_version/v2 Loaded
------------------------------------------
Comfyroll Studio v1.76 :  175 Nodes Loaded
------------------------------------------
** For changes, please see patch notes at https://github.com/Suzie1/ComfyUI_Comfyroll_CustomNodes/blob/main/Patch_Notes.md
** For help, please see the wiki at https://github.com/Suzie1/ComfyUI_Comfyroll_CustomNodes/wiki
------------------------------------------
### Loading: ComfyUI-Impact-Pack (V8.0.1)
[Impact Pack] Wildcards loading done.
[Crystools INFO] Crystools version: 1.21.0
[Crystools INFO] CPU: AMD EPYC 7R32 - Arch: x86_64 - OS: Linux 6.8.0-1017-aws
[Crystools INFO] Pynvml (Nvidia) initialized.
[Crystools INFO] GPU/s:
[Crystools INFO] 0) NVIDIA A10G
[Crystools INFO] NVIDIA Driver: 550.90.07
### Loading: ComfyUI-Inspire-Pack (V1.9)
Import times for custom nodes:
   0.0 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/Bobs_Latent_Optimizer.py
   0.0 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/websocket_image_save.py
   0.0 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/ComfyUI-Impact-Pack
   0.0 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/ComfyUI-IC-Light-Native
   0.0 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/sdxl_prompt_styler
   0.0 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/image-resize-comfyui
   0.0 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/ComfyUI-post-processing-nodes
   0.0 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/cemil-nodes
   0.0 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/CharacterFaceSwap
   0.0 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/ComfyUI-BRIA_AI-RMBG
   0.0 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/ComfyUI_TiledKSampler
   0.0 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/ComfyUI-AutomaticCFG
   0.0 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/ComfyUI_yanc
   0.0 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/civitai_comfy_nodes
   0.0 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/ComfyUI_InstantID
   0.0 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/comfyui-inpaint-nodes
   0.0 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/comfyui-ipadapter-flux
   0.0 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/ComfyMath
   0.0 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/ComfyUI-IC-Light
   0.0 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/ComfyUI-QualityOfLifeSuit_Omar92
   0.0 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/cg-use-everywhere
   0.0 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/ComfyUI-Florence2
   0.0 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/ComfyUI-Inpaint-CropAndStitch
   0.0 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/comfyui-browser
   0.0 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/ComfyUI_essentials
   0.0 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/Derfuu_ComfyUI_ModdedNodes
   0.0 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/efficiency-nodes-comfyui
   0.0 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/ComfyUI_UltimateSDUpscale
   0.0 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/x-flux-comfyui
   0.0 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/ComfyUI-Frame-Interpolation
   0.1 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/ComfyUI-Custom-Scripts
   0.1 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/ComfyUI-TiledDiffusion
   0.1 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/ComfyUI-LivePortraitKJ
   0.1 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/ComfyUI_IPAdapter_plus
   0.1 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/ComfyUI-GGUF
   0.1 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/comfyui-liveportrait
   0.1 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/rgthree-comfy
   0.1 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/ComfyUI-VideoHelperSuite
   0.1 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/ComfyUI-Crystools
   0.1 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/ComfyUI_Comfyroll_CustomNodes
   0.2 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/comfyui_controlnet_aux
   0.2 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/ComfyUI-KJNodes
   0.2 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/ComfyUI-Inspire-Pack
   0.2 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/antrobots-comfyUI-nodepack
   0.2 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/ComfyUI_Sapiens
   0.2 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/PuLID_ComfyUI
   0.4 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/ComfyUI-Manager
   0.4 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/ComfyUI-Advanced-ControlNet
   0.6 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/comfyui-reactor-node
   0.7 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/ComfyUI_tinyterraNodes
   0.8 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/comfyui-art-venture
   0.8 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/ComfyUI-tbox
   1.0 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/ComfyUI-Gemini
   1.0 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/comfyui_segment_anything
   1.2 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/ComfyUI-Model-Manager
   1.5 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/ComfyUI-Easy-Use
   2.5 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/comfy_mtb
   3.1 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/was-node-suite-comfyui
   3.5 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/ComfyUI_LayerStyle
   3.7 seconds: /home/ubuntu/ai/ComfyUI/custom_nodes/ComfyUI-SUPIR
Starting server
To see the GUI go to: http://<IP_ADDRESS>:8188
FETCH DATA from: /home/ubuntu/ai/ComfyUI/custom_nodes/ComfyUI-Manager/extension-node-map.json [DONE]
QualityOfLifeSuit_Omar92::NSP ready

Error handling request
Traceback (most recent call last):
  File "/home/ubuntu/ai/ComfyUI/venv/lib/python3.12/site-packages/aiohttp/web_protocol.py", line 477, in _handle_request
    resp = await request_handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/ai/ComfyUI/venv/lib/python3.12/site-packages/aiohttp/web_app.py", line 559, in _handle
    return await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/ai/ComfyUI/venv/lib/python3.12/site-packages/aiohttp/web_middlewares.py", line 117, in impl
    return await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/ai/ComfyUI/server.py", line 63, in cache_control
    response: web.Response = await handler(request)
                             ^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/ai/ComfyUI/server.py", line 141, in origin_only_middleware
    response = await handler(request)
               ^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/ai/ComfyUI/custom_nodes/comfy_mtb/__init__.py", line 550, in do_action
    return await endpoint.do_action(request)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/ai/ComfyUI/custom_nodes/comfy_mtb/endpoint.py", line 169, in do_action
    result = method(*args) if isinstance(args, list) else method(args)
             ^^^^^^^^^^^^^
  File "/home/ubuntu/ai/ComfyUI/custom_nodes/comfy_mtb/endpoint.py", line 103, in ACTIONS_getUserImages
    if offset <= i < offset + count
                     ~~~~~~~^~~~~~~
TypeError: unsupported operand type(s) for +: 'int' and 'NoneType'

Thanks for the report!
I will fix it but in the meantime just make sure to have at least one image in either folder


Neural Network project avg and project total RAC not sorting correctly.

The avg and total RAC sorting for projects is only sorting by the first digit. For instance, if I sort projects by lowest avg RAC, PrimeGrid will be at the top with 106,000, followed by Numberfields with 10,666. It looks like it's not taking all the digits into account.

Looks like this issue is outdated

This is still an issue. When you click to sort by Total or Avg RAC, it only takes into account the first digit, not the whole number:

ok now it is more specific to what the issue is thanks

marked for closure @denravonska


Update WORKSPACE in Bazel example

v2.3.4 is not available

2.3.4 hasn't been released yet, but this is about 2.3.4-SNAPSHOT.
The problem here actually is that error_prone_ant no longer exists. AFAICT,  it's been replaced with error_prone_core's with-dependencies variant (along with a few unbundled dependencies, due to license concerns)

@tbroyer
Thanks for the reply.
I actually first tried "error_prone_core-with-dependencies-2.3.4-SNAPSHOT"
But I was not able to find artifact-name for the same.
Can you provide the artifact-name that I can use for the "error_prone_core-with-dependencies-2.3.4-SNAPSHOT"?
Thanks.

Try with com.google.errorprone:error_prone_core:jar:with-dependencies:2.3.4-SNAPSHOT, or possibly com.google.errorprone:error_prone_core:2.3.4-SNAPSHOT:jar:with-dependencies.
That being said, it looks like this would eventually have to be moved to using the Skylark jvm_maven_import_external (see https://docs.bazel.build/versions/master/skylark/backward-compatibility.html#remove-native-maven-jar or https://github.com/bazelbuild/bazel/issues/6799)


Formalize "data" package passed to tmt.result.Result

/packit retest-failed

/packit retest-failed


update configuration page

One typo fixed, one comment re: a sentence I'm unclear about, but otherwise, All looks good!

Merging this in since it's better than what we have today.
i'll re-run docgen once the main astro repo docs are updated.


Add integration test to ease continuous integration

The development of this library is horribly slow; not due to the developers but due to me maintaining it. The problem is that merging code every few months requires me to re-understand the whole library and Telegram-API in order to decide if the changes are valid. This is the reason for why this library is bit-rotting :disappointed:
To finally ease development, I suggest to add a very good integration test. This test should test all features of the API with a real bot, if somehow possible. I want to be able to merge immediately if the code looks clean and all tests passed.
Any comments? What do you think @knsd @dns2utf8 @neuschaefer @rockneurotiko?

I like the idea, but I am not sure how we can do it.
Can we redesign the lib as a whole? To make the structure simpler and increase the maintainability?

If we rewrite the lib, can we do it with TDD?
CC: @knsd @neuschaefer @rockneurotiko

Can we redesign the lib as a whole? To make the structure simpler and increase the maintainability?

I'm not sure if this library needs a rewrite -- the API is OK I guess. But maybe we as developer need said rewrite to boost motivation and maintainability (as you said) :stuck_out_tongue:
So I would be OK with rewriting everything, but I'd like to do it in a rather short time (e.g. not over a whole month) and together with someone else. I do have time to work on this from Saturday (or maybe Monday) on for a few weeks at least.
So I'd love to rewrite this with someone else. Do you, @dns2utf8, want to help? What about your time? Apparently we live in the same time zone, which eases development :wink:

I'll help with any rewrite and/or tests all I can (If I don't answer in some time don't worry, this month I'm in a village almost without internet).
I've never made any tests in Rust, how is the best way to go? The language test attribute? Some library? (I found stainless and https://github.com/kriomant/mockers/ but both needs nightly).

I've never made any tests in Rust, how is the best way to go? The language test attribute?

I think  language test attribute should be enough since Api is quite simple and immutable.

Can we redesign the lib as a whole?

Want to propose new api for messages, something like:
let chat = api.chat(chat_id); // Or from input message
chat.message("Any message").web_page_preview(false).reply_to(message).send();
chat.action(ChatAction::Typing).send();
...

So there are two changes:

Populate Chat type with a hidden field token, so we doesn't need to to pass chat_id in every send_* function. Not sure about it. Same things with Message.
Make Message type a builder, so we doesn't need to pass four Nones and remember which None is what.

Also we can migrate to serde from rustc-serialize.

The language test attribute?

Yes, I'd like to go with the built in feature, which is more than enough for simple to medium-sized test-suites. We might want to think about another solution for the integration test (which will perform real network-IO), but I think Rust's default testing system is fine for that, too.

Also we can migrate to serde from rustc-serialize.

Not sure about this. I've never worked with serde, I want to avoid nightly, want to use the easy of macros and I'm skeptical about syntex...

Want to propose new api for messages, something like:

I'm fine with a new API, but I'd say we shouldn't discuss it here. First I want to discuss how we discuss those topics and work on it.
So first, [1] I'd like to know from you nice people if you want to help ...

discuss API design
doing the first big chunk of programming
help improving it once the biggest chunk of functionality is implemented

For (1.) I'd propose another media of communication than GitHub. Transparency is awesome, but sometimes a quick back and forth discussion is needed IMO. I guess we all have a Telegram account, so that would be a sensible choice :wink:
Secondly, [2] please tell me when you can spare some time. Just on the weekend? The whole week, but weekends?
As I already mentioned, I am available from Monday on (the whole week) for a few weeks.
Looking forward to work with you!

I would like to help :smiley:
The bot using this lib has a handwritten parser which I developed with the integrated test suite:
https://github.com/coredump-ch/coredumpbot/blob/master/src/user_input_compiler.rs#L383
I made a Telegram group, if this is ok with everybody:
https://telegram.me/joinchat/AvMyLj-VkTBoU8DAcv-JeA
[1]

yes
yes
in september or later

[2] currently I am preparing myself for my exams in august so I should not invest more than a day :wink:
But that day can be any in the next 5 days, including the rest of today.


Save on change row

I would like to save the edits when the user selects a different row instead of canceling the edit. Is this possible?

I went ahead and added this feature myself. It's not pretty but it seems to work. I'll continue testing it.

diff --git a/jsgrid/jsgrid.js b/jsgrid/jsgrid.js
index e03b080..1463dfb 100644
--- a/jsgrid/jsgrid.js
+++ b/jsgrid/jsgrid.js
@@ -63,6 +63,7 @@
         width: "auto",
         height: "auto",
         updateOnResize: true,
+        updateOnRowChange: false,

         rowClass: $.noop,
         rowRenderer: null,
@@ -1051,7 +1052,13 @@
                 return;

             if(this._editingRow) {
-                this.cancelEdit();
+
+                if (this.updateOnRowChange) {
+                    this.updateItem();
+                }
+                else {
+                    this.cancelEdit();
+                }
             }

             var item = $row.data(JSGRID_ROW_DATA_KEY),

The easiest way is to define rowClick callback.
The default implementation is:
rowClick: function(args) {
    if(this.editing) {
        this.editItem($(args.event.target).closest("tr"));
    }
}

For your scenario it could be
rowClick: function(args) {
    if(!this._editingRow) {
        this.updateItem();
    }
    if(this.editing) {
        this.editItem($(args.event.target).closest("tr"));
    }
}

Hope it will help.

That solution was much cleaner. Thank you. I did have to change the polarity of the first 'if' to save if editing instead of save if !editing. I assume that was a typo.
However, when I select another row while editing it saves but doesn't open the new row to edit. It looks like it might open the row to edit but then both edits get canceled at the same time. Any solution to that issue? I'm browsing the code but it's a little beyond my skill level.

Actually I think I got this figured out. I used the onItemUpdated callback. The system seems to be confused with what is activly being edited. So it start the new edit then the item update ajax returns and stops all edits. So I just delayed the edit until the ajax is finished:

      nextEdit: false,

      rowClick: function(args)
      {
        if (this._editingRow)
        {
          this.updateItem();
          this.nextEdit = args.event.target;
        }
        else if(this.editing)
        {
          this.editItem($(args.event.target).closest("tr"));
        }
      },

      onItemUpdated: function()
      {
        if(this.nextEdit)
        {
          this.editItem($(this.nextEdit).closest("tr"));
          this.nextEdit = false;
        }
      }

All this code was done without editing the jsgrid.js file so props for making a flexible system. Hope this code helps someone in the future.

You are right, there was a typo in the code example.
The issue really takes place for async update.
I think the following solution could be even easier:
rowClick: function(args) {
    var $row = $(args.event.target).closest("tr");

    if(this._editingRow) {
        this.updateItem().done($.proxy(function() {
            this.editing && this.editItem();
        }, this));
        return;
    }

    this.editing && this.editItem();
}

Of course, if you don't like js tricks this.editing && this.editItem(); could be replaced with normal if.
Hope it'll help.

I have a related issue. Right now, the insert button cancels all the edits. I want the form to save the edits when I click the insert button and when I switch rows. How can I do that? Thanks.


 Other weather related infos are working correctly. It was working for a short while after I reseted the watch to factory settings and installed only the needed apps, but an hour or so later it stopped working so I installed a bunch of other apps. Also to note, it works fine on something like the Weather Clock or the Weather App.

I use Tiny Weather Forecast as my source and the banglejs gadgetbridge as bridge.
Installed apps
Anton Clock
About
Lock Widget
Bluetooth ID Widget
Welcome
Scheduler
Alarms Widget
Bootloader
Bluetooth Widget
Notifications (default)
Health Tracking
Settings
Message Icons
Message Widget
Messages
Android Integration
Message List
A Battery Widget (with percentage)
App Manager
Weather
Desktop Launcher
GPS Info
Barometer
Gadgetbridge Music Controls
OpenStreetMap
Thermometer
GPS Time
Languages
Dice-n-Roll
Weather Clock
LCARS Clock
Alarms & Timers
Clockinfo Clock
Clock Info Module
Clock Info Widget

Looks like it might be a colour problem - @peerdavid anything like this ring a bell?

Its an issue with the 2.19 firmware. I have the same problem. Downgrading to 2.18 fixes it.

Thanks for checking - sounds like it's related to this espruino commit and #3144, so should be fixed when this commit makes it to firmware (v2.20 at a guess)

I'll report back whenever 2.20 comes out

2.20 still has the issue.

I guess the above commit wasn't the fix, looks like the bug would need some more scrutiny

Hi there -- I jsut updated and its working on my Bangle so I can't reproduce right now. But to search the bug, I honestly guess its the weather app and not LCARS as LCARS uses the json from the weather app. Especially as of the report that " FWIW I'm using the "weather" app and its broken there too."...

Hmm, wonder if I have some kind of corrupted setting/config file. I'll update again later this week and do a full factory reset to see if it still shows up.

See if it works for you now! I think I corrected that in June: #3461


update Readme.md for clusterloader2 to replace APIResponsiveness with APIResponsivenessPrometheusSimple

ref https://github.com/kubernetes/perf-tests/pull/915

/lgtm
/approve


DO NOT APPROVE - bug bounty test - sorry for spamming :-)    ctvfjj

DO NOT APPROVE - bug bounty test - sorry for spamming :-)    ctvfjj

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


feat(itn): add testcase

This should be merged AFTER https://github.com/wenet-e2e/WeTextProcessing/pull/77 to pass all cases


Submit author response

This PR creates a new responder for the authors to use to submit their response with the command:
@ropensci-review-bot submit response
This will create a new entry in the author-responses Airtable
Also, when all reviews are submitted, a new reminder for authors to send their response is scheduled for 12 days later.
Closes #72

Thank you!!


Moved fq_std from bevy_reflect_derive to bevy_macro_utils

Objective

Fixes #9363

Solution
Moved fq_std from bevy_reflect_derive to bevy_macro_utils, and added pub(crate) use bevy_macro_utils::fq_std; to bevy_reflect_derive to minimise total changes required. This does make the FQ* types public where they were previously private, which is a change to the public-facing API, but I don't believe a breaking one.

I've made the changes requested by @james7132 which increase the overall quality of bevy_macro_utils. I also took the liberty of adding deny(unsafe) (since it wasn't using unsafe anyway), and splitting out the contents of lib.rs into bevy_manifest.rs and label.rs to allow lib.rs to be exclusively used for declaring modules and publishing public members. None of this has materially affected the PR beyond adding documentation and general cleaning.


Add OOP and 'classes' to language

Classes so far look like this
class ClassName {
  init {
    // expressions
  }

  // function declarations / any more classes
  function method {
    return 1
  }
  class NestedClass {
    // No init blockHacktivity
  }
}

object = ClassName()

Where the init block must be placed at the top of the class and is unnecessary. It should be run when the class is initialised.

So far done in e42fa085e0a20e1785b2eecc6baeb9b10c625c96

TODO

Allow for classes to be extended


Normalizing email headers in SQLite

Hey everybody,
I've been spending some time over the past week trying to use mbox-to-sqlite to import my 57gb mbox from GMail.  After a bunch of tinkering I've created an sqlite db for myself, but wanted to talk w/ users of this library (or just Simon) about some suggested enhancements, and whether the changes i made would be worth contributing.
Email headers are mixed case, and SQL is not.
As noted in #5 and #6, running mbox-to-sqlite will fail for arbitrary mbox files with a duplicate column error.  These failures are caused by the fact that SQL and SQLite's column space are single case while email header keys are mixed case.  Attempting to insert mixed case will result in these duplicate column errors.
So what do?
Should mbox-to-sqlite normalize header keys?
I'd posit yes.  My personal solution was to preprocess each message that mailbox produced prior to upserting them as mbox-to-sqlite does.  The normalization I chose was to map mix-cased keys to lowercase, and merge the values of any colliding keys.
Merging values seems fine for my purposes (search & retrieval).  I don't need to trace individual headers back for forensic purposes or the like.
SQLite has a maximum column limit.
After deciding on a strategy for avoiding column naming conflicts, I discovered that SQLite has a limit to the number of columns allowed in a single table.  SQLITE_MAX_COLUMNS is a compile time setting, and defaults to 2000.  Since this setting is determined at compile time I assume it to be immutable for all practical intents and purposes.
This is a problem because the set of columns that mbox-to-sqlite builds can be arbitrarily large, since it's the union of all of the email header keys contained in the mbox.  In my case, 57gb of email contained 4040 unique headers (3574 if mapped to lower case).
Should mbox-to-sqlite provide a (configurable) fixed set of columns?
If we treat SQLITE_MAX_COLUMNS as fixed there's no practical solution other than limiting the number of columns that mbox-to-sqlite produces.  The question shifts to what columns to include, and what to do with remaining headers.
For myself I counted the frequency of headers in my mail archive and used that to filter out a list of headers with 1000 entries or more.  I used that list of columns to set up my messages table, and filter the keys for each record dict.  Any header not in the list gets put into a dict that gets dumped as a JSON string into an additional_headers field.
It shouldn't be hard to automate scanning the headers to calculate the distribution and suggest what an appropriate cut off point might be.
Anyway, if any of these contributions would be helpful, let me know and i can fire up a pr.

p.s. SQLite limits aren't accessible via SQL, but Stack Overflow provides an insane but relatively quick way to find SQLITE_MAX_COLUMNS


Fimset Renaming

Version: 3.0-SNAPSHOT
Build: 2018-06-21 00:22
OS: Windows 10
The renaming MovieSet doesn't seem to be going here. If you
The layout is set to ${movieSet.title}${title} ${- ,edition,} (${year})  for example,
y:\Movies\Jump Street Filmreihe${movie.title} (2012)\21  Jump Street (2012) 480p AC3.avi

this should be already fixed with https://github.com/tinyMediaManager/tinyMediaManager/commit/53c9f6ac183ac7596b9d1897c88b22df08236e6a


supervised option

I am not sure how to exactly build a debian package with this (very new to this), but in packages distributed by Chris Lea for Ubuntu (https://launchpad.net/~chris-lea/+archive/ubuntu/redis-server/+packages), which seems to use this, has the supervised no in /etc/redis/redis.conf.
Was this intentional by design, or would we want to actually turn this on with supervised systemd. The Digital Ocean guide for this this (which builds/installs from source) instructs to do this.

What problem are you actually seeing? Are you using supervised or just asking? I am not disablng this option, simply not enabling it. I am also unsure of those packages you link to and am curious about what advantages they have over others.


CertificateImproperlyFormatted when using a key created through the portal

I can create the VM if I create the key as it's done in this tutorial, but when trying to use a key that I had created earlier in the portal (with default settings, self-signed, pkcs#12), I get a ResourceDeploymentFailure with the message: "The secret retrieved from https://keyvaultname.vault.azure.net/secrets/myselfsignedcert/5c6087a920e04c9d8d92de72738bbd3a is not a properly encoded Base64 string."
It seems to be the same issue as here: https://github.com/Azure/azure-cli/issues/3062, but I don't really understand why one would work and not the other.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 996eb4d1-198e-a69a-b9c5-d247db46d025
Version Independent ID: 5bfe27b3-22e9-efa8-6a1c-3637aa39a049
Content: Tutorial: Secure a Linux web server with SSL certificates in Azure - Azure Linux Virtual Machines
Content Source: articles/virtual-machines/linux/tutorial-secure-web-server.md
Service: virtual-machines-linux
GitHub Login: @cynthn
Microsoft Alias: cynthn

@amunger Thanks for your feedback! We will investigate and update as appropriate.

@amunger       Can you try once with pem format as shown below.

PEM goes well with linux.
After creating the cert in portal, you still need to follow these steps to create a vm secret out of the certificate.

You can also convert from pkcs to PEM

@amunger Did you had a chance to try that out

@amunger
I will close this out for now. If you need additional help please open a new issue.


Failed to start the Dart CLI isolate (null)

Please i have been having issue with my flutter and dart. Most times when i want to run any command in the terminal or run my flutter app from my visual studio code it shows me the error in the image. I have to delete the cache folder in the flutter folder and then i run flutter upgrade again before it works, then after some time it shows me the error again. Please i will be glad if anyone can assist me

@Ghostsmaw
Can you provide the location you have Flutter installed along with your PATH ?
Please don't provide screenshots. Provide the details in properly formatted text. Thanks.

@Ghostsmaw
Can you provide the location you have Flutter installed along with your PATH ?
Please don't provide screenshots. Provide the details in properly formatted text. Thanks.

export PATH="$PATH:/Users/williamspeter/desktop/tools/flutter/bin"
It is installed in my /Users/williamspeter/desktop/tools/flutter/bin

There was a similar issue reported which got closed due to inactivity, https://github.com/flutter/flutter/issues/81914
Labeling it for further insights from the team.
cc: @bkonyi

/cc @christopherfujino
We saw another report for same error.

I still haven't been able to solve the problem

Is everyone encountering this on a Mac? Out of curiosity, what model / year? I'm wondering if this is an issue specifically for Macs with ARM64 M1 chips.

Todo mundo está encontrando isso em um Mac? Por curiosidade, qual modelo/ano? Eu estou querendo saber se este é um problema especificamente para Macs com chips ARM64 M1.

My mac is chip intel, 1,6 GHz Intel Core i5 Dual-Core

@Ghostsmaw você pode enviar seu /Users/williamspeter/desktop/tools/flutter/bin/cache/dart-sdk/bin/dartarquivo?

Last login: Tue Mar 29 16:46:19 on ttys001
/Users/servicesline/Documents/flutter/bin/cache/dart-sdk/bin/dart ; exit;
The default interactive shell is now zsh.
To update your account to use zsh, please run chsh -s /bin/zsh.
For more details, please visit https://support.apple.com/kb/HT208050.
Servicess-Air:~ servicesline$ /Users/servicesline/Documents/flutter/bin/cache/dart-sdk/bin/dart ; exit;
╔════════════════════════════════════════════════════════════════════════════╗
║ The Dart tool uses Google Analytics to report feature usage statistics     ║
║ and to send basic crash reports. This data is used to help improve the     ║
║ Dart platform and tools over time.                                         ║
║                                                                            ║
║ To disable reporting of analytics, run:                                    ║
║                                                                            ║
║   dart --disable-analytics                                                 ║
║                                                                            ║
╚════════════════════════════════════════════════════════════════════════════╝
A command-line utility for Dart development.
Usage: dart <command|dart-file> [arguments]
Global options:
-h, --help                 Print this usage information.
-v, --verbose              Show additional command output.
--version              Print the Dart SDK version.
--enable-analytics     Enable analytics.
--disable-analytics    Disable analytics.
Available commands:
analyze    Analyze Dart code in a directory.
compile    Compile Dart to various formats.
create     Create a new Dart project.
devtools   Open DevTools (optionally connecting to an existing application).
doc        Generate HTML API documentation from Dart documentation comments.
fix        Apply automated fixes to Dart source code.
format     Idiomatically format Dart source code.
migrate    Perform null safety migration on a project.
pub        Work with packages.
run        Run a Dart program.
test       Run tests for a project.
Run "dart help " for more information about a command.
See https://dart.dev/tools/dart-tool for detailed documentation.
logout
Saving session...
...copying shared history...
...saving history...truncating history files...
...completed.
[Processo concluído]

Thanks @Faelnas1! Can you also share the contents of /Users/servicesline/Documents/flutter/bin/cache/dart-sdk/bin/snapshots/?

I have encountered the same error, even after trying:

deleting the files of cache in flutter/bin
disabled firewall (and I have no antivirus installed)
reinstalled flutter SDK

Whenever I run flutter commands, I still get the "Error: Unable to 'pub upgrade' flutter tool." "Failed to start the Dart CLI isolate." error.

@Ghostsmaw
Can you confirm if you are still facing this issue using latest stable version of the framework ?


Fonts vs Android images

Hi, are fonts included in the android images (circleci/android:api-30-node) ? I'm getting an error indicating it is not.
Would it be possible to follow the same approach as in the (pure) openjdk images?

Any update on this issue?

@felicianotech this seems like a trivial task, any hope of getting this done?


Notification separated from in game overlay

Is your feature request related to a problem? Please describe.
Not really a problem, just an option for people to separate the notifications from the in game overlay.
Describe the solution you'd like
Have a checkbox in the Khaos tool to enable/disable the in-game overlay.
And make it somehow possible to read the last command in OBS itself, so it can be shown on your layout.
Describe alternatives you've considered
Have Khaos spit out a .txt file with the last used command.
That way in OBS you can have a text source, reading the .txt that Khaos spit out.
(similar to how streamlabs chatbot spits out a bunch of .txt files for use with OBS and text sources.)
A straight up plugin, for OBS, that reads or gets sent data from the Khaos Tool itself.
Additional context
It makes sense to have something pop up in the game so the streamer/player knows what is going on.
But if someone wants to incorporate it in their layout in OBS somehow, make that possible as well.

Implemented for the next release.


No subdomains returned anymore

I am aware of that rule: "To avoid abuse of this service, we have enforced aggressive rate-limits. During periods of high demand or extensive production, an empty list [] is returned. We do not take responsibility for any malicious use of our data, and such use is entirely unintended." (https://www.subdomain.center/)
But since some time, I do not receive any subdomains anymore from Puncia.
Are there rules regarding limits for subdomains searches (API key, captcha ...) ?

Hello Sébastien!
We were working on migrating & scaling Subdomain Center this month that's why you must have experienced some unusual downtimes. We migrated from AWS to OVH, enhanced the enumeration logic & added over a billion subdomains to the database. In coming months, we will be releasing more features like clustering subdomains not just domain-wise but also application-wise.
Additionally, the rule is changed a little - 'To avoid abuse of this service, we have enforced aggressive rate-limits & a maximum of 500 subdomains per request sorted in a random order. During periods of high demand or extensive production, an empty list [] is returned. We do not take responsibility for any malicious use of our data, and such use is entirely unintended.'
There are no captchas enforced but yes paid users do get an API key with which they get unrestricted access -https://www.arpsyndicate.io/pricing.html
Thanks for reaching out & feel free to ask if you have any additional queries.


CLIF as a relational SQL database

we should make CLIF "SQL ready" because SQL databases have an explicit relational database structure that will help us achieve the goal of having each hospitalization represented coherently in CLIF.
hospitalization: hospitalization_id is the primary key.
vitals: hospitalization_id is a foreign key to link each set of vitals to a specific hospitalization.
labs: hospitalization_id also serves as a foreign key to associate lab results with the corresponding hospital stay.
I also like this:
Foreign Key Constraints: By using SQL, you can enforce foreign key constraints to maintain referential integrity. This ensures that every hospitalization_id in the vitals, labs, or medications tables must exist in the hospitalization table. It helps prevent orphaned records (e.g., vitals records that reference a non-existent hospitalization).
SQL queries will be a very efficient way to do things like identify sepsis, etc.
Let's add a running to do list to this issue. I think we are pretty close!

add a primary key for each table, e.g. vital_id
use SQL datatypes


Proposal: Better Plugin System

Problem
Currently it is not really possible to write a plugin changing Javalin, JavalinConfig or the Context class. It would be nice there would be the standardised way to add the new features to Javalin without changing the core.
I created this issue to discuss if this is an option and how such a plugin could look like. If there is no interest in implementing such feature, this issue can be closed.
Current behaviour
I use the OpenApi plugin as an example. In the current implementation I needed to make the following changes to the JavalinConfig.

public class JavalinConfig {
    public class Inner {
        //...
        @Nullable public OpenApiOptions openApiOptions = null;
        @Nullable public OpenApiHandler openApiHandler = null;
        //...
    }

    //...
    public void enableOpenApi(OpenApiOptions options) {
        inner.openApiOptions = options;
    }

    //...
    public static void applyUserConfig(Javalin app, JavalinConfig config, Consumer<JavalinConfig> userConfig) {
        //...
        OpenApiHandler openApiHandler = null;
        if (config.inner.openApiOptions != null) {
            openApiHandler = new OpenApiHandler(app, config.inner.openApiOptions);
            config.inner.openApiHandler = openApiHandler;
        }
        //...
        if (openApiHandler != null && config.inner.openApiOptions.getPath() != null) {
            app.get(config.inner.openApiOptions.getPath(), openApiHandler, config.inner.openApiOptions.getRoles());
        }
        //...
    }
}

To summarize:

I setup some variables for the options in the Inner class
I added a function for the configuration
I applied my configuration

Proposed Syntax
I would propose a Syntax which allows to define plugins completely separate from the core.
First we would define an interface with lifecycle methods
public interface JavalinPlugin {
    /** Initialize properties and event listener. */
    void init(@NotNull Javalin app, @NotNull JavalinConfig config);

    /** Register handlers */
    void apply(@NotNull Javalin app, @NotNull JavalinConfig config);
}

In the JavalinConfig plugins can be registered.
public class JavalinConfig {
    // ...
    public void registerPlugin(JavalinPlugin plugin) {
        //...
    }

    public <T> T getPlugin(Class<T> pluginClass) {
        //...
    }
    // ...
}

The openapi plugin could then look like the following. Javalin would just need to save all the plugins and call the lifecycle hooks. No changes on the core would be needed.
class OpenApiPlugin(val options: OpenApiOptions) : JavalinPlugin {
    lateinit var handler: OpenApiHandler

    override fun init(app: Javalin, config: JavalinConfig) {
        handler = OpenApiHandler(app, options)
    }

    override fun apply(app: Javalin, config: JavalinConfig) {
        if (options.path != null) {
            app.get(options.path, handler, options.roles)
        }
    }
}

The user could use the plugin like the following:
val openApiPlugin = OpenApiPlugin(OpenApiOptions(...))
val app = Javalin.create {
    it.register(openApiPlugin)
}

There would be no need to define new methods for every configuration.

I created this issue to discuss if this is an option and how such a plugin could look like. If there is no interest in implementing such feature, this issue can be closed.

There is already Javalin#register(extension):
@FunctionalInterface
public interface Extension {
    void registerOnJavalin(Javalin app);
}

which @dherges worked on, I imagine he's interested in this.
The current system works well enough for me, but if you think introducing this will simplify the code I'm all for it. Could you create a PR which ports a few of the existing features to your plugin system?

@tipsy Oh I didn't see that. Thanks for the tip. That's very similar to what I want.
It is probably useful to extend on that. I'm going to create a small PR to test if it works how I imagine.

I created a PR with a small demonstration how it could look like.
I refactored a few features in the JavalinConfig and I think you can already see how this approach is very clean and can be easily extended.

I'll close this, but please include the second part too (refactor existing plugins).


Add support of native SQL

I have used mybatis-dynamic-sql in official projects,which is very convenient.I used mybatis generator to generate code.But there are two small problems.
First, the limit statement. Currently, you must call limit(pageSize).offset(index). Limit (index,pageSize) is not supported.(My database is mysql)
Second，I hope add  support of native SQL,witch can use by lambda like table1Mapper.select(c->c.where(colunm1,isEqualTo(1)).nativeSql("and exists (select * from table2 where table1Id=1 )")).
The resulting SQL looks like this"select * from table1 where colunm1 =1 and exists  (select * from table2 where table1Id=1 )",or more complicated.
Now if I want to write a really complicated SQL, I can only use @selectprovider,and I have to write a new method every time.
Native SQL is important for features that are not currently supported, or for particularly complex SQL.
Would you consider add support of native SQL in next release?

I'm fairly certain that MySQL supports limit and offset. Have you tried it? Their documentation says they support it for compatibility with PostgreSQL: https://dev.mysql.com/doc/refman/5.7/en/select.html
I like the native SQL idea. I will  think about how best to do that.

At limit problem,i mean inner class QueryExpressionWhereBuilder in class QueryExpressionDSL is lack of method,like "limie(pageIndex,pageSize)".
Generate sql like "select xxx from table limit 1,12".

I understand - thanks. But that is so specific to MySql that I'd rather not add it. You should be able to use the existing limit and offset support - limit(12).offset(1).

Thanks a lot,my problem is solved.
Hope to see support for native SQL in the next release soon.


Sort out pagination

Paginated results are required for tune lists (returned from searches) and user lists.  Although there is a servant pagination  style in this case I think probably the least awkward option is to retain the musicrest pagination style.  This requires clients to issue a page parameter in search requests (default 1). At the foot of the returned JSON there is a pagination record consisting of page  (page number) and size  (max pages available).
In addition, a custom response header is transmitted - e.g.:
Musicrest-Pagination: [ page 1 of  6 ]

This is now implemented to match Musicrest by 0b365482f7d9aa688cea2fab178582eabe4d2692.  I'll try to remove the custom Musicrest-Pagination header later if I can.


Add DrawScope.drawCircle

A couple of pictures

[X] CHANGELOG.md's "Unreleased" section has been updated, if applicable.

So this looks fine as far as the code goes.
I guess my only question is... would someone actually use this? Circles on a monospace grid don't seem all that useful.
I could see someone using braille characters (a little like https://chipaca.com/en/2024/01/xbmbraille/), but I don't want to provide that in the core. I'd be open to another module with braille-shape drawing primitives, though.


Prevent crash when setting credit widget subclass

There is a widget subclass CreditsWidgetClass specified in CesiumCreditSystem.h that is currently set to be a subclass of a UUserWidget, so any user-created widget can be set in the editor for this variable. However, later code that uses this variable assumes that it is a subclass of UScreenCreditsWidget:
CesiumCreditSystem.cpp:254
    CreditsWidget =
        CreateWidget<UScreenCreditsWidget>(GetWorld(), CreditsWidgetClass);

At this point, if the user has inadvertently set an arbitrary widget for CreditsWidgetClass, then CreditsWidget will be invalid because CreditsWidgetClass is assumed to be a subclass of UScreenCreditsWidget.
This PR addresses that issue by making the TSubclassOf variable set to a UScreenCreditsWidget type in the first place, so that the user cannot specify an incompatible class.

Thanks @xuelongmu!


Replace ListView with FlatList and SectionList

requires React-Native 0.43
has better API than ListView
is faster
in future ListView will be deprecated in favor of these

Was implemented a month ago.