Fixed /ctf not creating snitches

Note: Closed #17 and made a new commit because of git shenanigans on my part. I apologize for the trouble.

Fix to #16

The ReinforcementCreationEvent handler was executed before the call to BlockPlaceEvent.
This meant that: pendingSnitches.remove(block.getLocation()) in the RCE handler was returning null and prevented the snitch creation.

I got busy IRL shortly the time I made the first PR and I haven't really looked into it after that. Since it seems to still an issue, I'm taking another look into it. (I assume no one is working on it right now)
I've set the priority to NORMAL instead of LOW as indicated.

I think it'd be good to have two listeners here:

The current one at NORMAL priority (which would still be before Citadels HIGH)
An additional one at MONITOR priority which removes the block from pendingSnitches if the event was cancelled

If I understand correctly there should be 3 listeners instead of two, am I correct ?

onBlockPlace(BlockPlaceEvent) at NORMAL
createReinforcement(ReinforcementCreationEvent) at HIGHEST
A new listener at MONITOR that removes the entry from pendingSnitches if the event (BlockPlaceEvent?) has been cancelled.

Is this PR missing commits? Check the diff, it's only one line.

If I understand correctly there should be 3 listeners instead of two, am I correct ?

Yes, as described by you

Is this PR missing commits? Check the diff, it's only one line.

I did mess up locally but yes, only one line was changed. (only the event priority)
I've now added the MONITOR handler as requested. It will be called when the BlockPlaceEvent is cancelled by a previous listener and will remove pending snitches in the eponymous set.
It works on my 1.14 test server but I haven't tested it on 1.16 however.

Good to merge, will go in after the 1.16 update


Storage: Support for matchGlob listObjects parameter

Support for the matchGlob list option is targeted for end of June
API docs:  https://cloud.google.com/storage/docs/json_api/v1/objects/list#list-object-glob
Example implementations:
Python
Java

Seems like we only need to support the Bucket::objects(..) function with an additional optional param called matchGlob.
Expected changes: include only doc blocks and UT/integration tests.


[Feature suggestion] DNSCrypt proxy update

As the core proxy gets a lot more updates than this GUI, I suggest;
Have the client check for updates of DNSCrypt-proxy, and display the info in the client somewhere.
If the updated core can be pulled and installed via the client, that would be ideal for end users.
I understand you may prefer testing a build with the UI before bundling for obvious reasons.
Thing is a lot of the updates have been bug fixes as well as new features, so perhaps a manual forced update with a warning that it has not been tested with Simple DNSCrypt would be adequate.
At the least giving the user a link to the update would seem sensible if there are security issues that are more important than UI functionality.
Many users are not  aware the GUI and the proxy are 2 different projects, so will assume that updates will include any important security fixes.

@Dr-Flay I like the basic idea. I will think about it and possibly set up a separate update channel. But probably still with signed and base tested files (against the UI).
Nevertheless I will try to update the project in the next days. ;)

@bitbeans  Not time yet?

The current version of DNSCrypt-Proxy is 2.0.42, Simple DNSCrypt is still using version 2.0.31!
Please give us an opportunity to update of DNSCrypt-Proxy as soon as possible regardless of the distribution of Simple DNSCrypt.

I`am working on an update at the moment :)


[R2] Add documentation for the R2ObjectBody type

What we describe as R2Object in the docs is actually R2ObjectBody. This fixes it, and documents each of them separately.

diff --git a/content/cloudflare-one/connections/connect-apps/install-and-setup/deploy-cloudflared-replicas.md b/content/cloudflare-one/connections/connect-apps/install-and-setup/deploy-cloudflared-replicas.md
index b6c82a29db725..803c61d1177eb 100644
--- a/content/cloudflare-one/connections/connect-apps/install-and-setup/deploy-cloudflared-replicas.md
+++ b/content/cloudflare-one/connections/connect-apps/install-and-setup/deploy-cloudflared-replicas.md
@@ -55,7 +55,7 @@ You can run the same tunnel across various cloudflared processes for up to 100
{{}}
-For information about running cloudflared instances in a Kubernetes deployment, refer to our examples on GitHub.
+For information about running cloudflared instances in a Kubernetes deployment, refer to the tutorial.
{{}}


Accept allOf JSON schema.

Codecov Report
Attention: Patch coverage is 35.00000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 10.20%. Comparing base (c2016c7) to head (bd24eee).
Report is 5 commits behind head on main.

Files with missing lines
Patch %
Lines

lib/oid4vp.js
35.00%
13 Missing :warning:

Additional details and impacted files
@@            Coverage Diff            @@
##            main      #31      +/-   ##
=========================================
+ Coverage   9.85%   10.20%   +0.35%
=========================================
  Files          4        4
  Lines       1604     1617      +13
=========================================
+ Hits         158      165       +7
- Misses      1446     1452       +6

Files with missing lines
Coverage Δ

lib/oid4vp.js
10.88% <35.00%> (+0.67%)
:arrow_up:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2016c7...bd24eee. Read the comment docs.


Distance between each catFact popup

Changes
The catFact pop-up information now separates when another catFact is spawned and, should work with an infinite amount of catFacts.
Known Bugs/Issues
The current issue regarding the method in place is that the math is inconsistent and may need an update to the method "moveDown" in order to control it better, but as it currently stands everything works and moves properly.
Testing Scene and Script
I used the default tutorial scene to test with the two collectibles. If I knew how to disable the destroy function on the collectible to test the changes I would.
Issue ticket number/link

Checklist before requesting a review

[x] I have performed a self-review of my code
[x] Make sure I am merging my features into the develop branch
[x] I have notified the other members of the programming team that my task is ready to review

issues resolved in commit b0c298a089f14c651550ecddfeb5750aa2a02490 "minor catfactSeparation fixes"


Fix stuck in local minimum / excess loops in path

These two commits provide a practical solution to the problem of the
planner getting stuck in a sub-optimal local minimum. Commonly, these
local minima cause the robot to perform excess loops on its way to the
goal. The solution solves the problem probabilistically by allowing the
multi-homotopy class planner to maintain a second candidate path in the
same homotopy class as the current "best" path. This allows path
exploration to "discover" new paths in a different, potentially better
local minimum, typically leading to the most optimal such alternative
being found.
This solves the following open issues:
https://github.com/rst-tu-dortmund/teb_local_planner/issues/88
https://github.com/rst-tu-dortmund/teb_local_planner/issues/95
https://github.com/rst-tu-dortmund/teb_local_planner/issues/115
https://github.com/rst-tu-dortmund/teb_local_planner/issues/135
It may also address this issue, but I am uncertain what the author means
by "teb cannot converge the path to a good solution.":
https://github.com/rst-tu-dortmund/teb_local_planner/issues/61
The second commit in this series not only improves the chances of
getting out of a local minimum but also improves the chances of finding
a better path around obstacles because it does not keep all the
candidate slots full with only the first few homotopy classes discovered
in exploration.

Thanks a lot, looks good to me and I was able to test this successfully.
However, I have two minor points:

I would like to set selection_pruning_probability to zero for dynamic reconfiguration in order to retain the old behavior, especially in kinetic. We can think of changing this in future distribution. However, I am going to include a value of 0.3 in the teb_local_planner_tutorials configuration files.
What do you think of renaming pruneTebs() to dropTebs() in order to avoid confusions with the meaning of pruning in timed_elastic_band.cpp?

Thanks a lot, looks good to me and I was able to test this successfully.
Yay, glad to hear it.

However, I have two minor points:

I would like to set selection_pruning_probability to zero for dynamic reconfiguration in order to retain the old behavior, especially in kinetic. We can think of changing this in future distribution. However, I am going to include a value of 0.3 in the teb_local_planner_tutorials configuration files.

Sure.  I set the default to 0.0 and renamed the parameter selection_dropping_probability

What do you think of renaming pruneTebs() to dropTebs() in order to avoid confusions with the meaning of pruning in timed_elastic_band.cpp?

I renamed pruneTebs() to randomlyDropTebs(). I also made it return immediately if `selection_dropping_probability is zero.
And, of course, I rebased onto current kinetic-devel.
Thank you!

Since my last submission, upstream changes will break this.  I will fix this for compatibility, rebase, and resubmit shortly.

OK. I have rebased and force-pushed these commits to fix a compatibility issue with
43ea03209 ("Never discarding the previous best teb in renewAndAnalyzeOldTebs")
Should be ready for merging.

thank you @howardcochran ! I'll test this again soon!

thank you @howardcochran ! I'll test this again soon!

Thanks. Let me know if you want additional tweaks.

I'm having a problem that sounds like what you have fixed @howardcochran. As you can see in the picture, my robot gets stuck trying to go through a wall, instead of going around. Is there anyway to download the fix, or should I just wait until it gets merged?

@AntonBock Could you try to clone this merge request and tell me if it fixes your issue?

@croesmann I have cloned the merge request into the melodic devel (had to add #include  in a header file). Unfortunately, it has not fixed the issue. The planner still tries to "teleport" through the wall instead of going around it. Any idea what could cause this? Should I make a new issue?

Are you sure that teb planner knows about your local obstacles?

@maxlein It seems like the planner sees the obstacles. If the obstacle is smaller, ie. just a small traffic cone, the planner will easily make a path around it. I don't know if you can see it in the picture, but the planner doesn't seem to be placing the teb_markers through the wall, although the local path is planned there. This looks like the same problem posed in the ros tutorial found here: https://wiki.ros.org/teb_local_planner/Tutorials/Obstacle Avoidance and Robot Footprint Model, but no solution is given.

@croesmann I have cloned the merge request into the melodic devel (had to add an #include in a header file). Unfortunately, it has not fixed the issue. The planner still tries to "teleport" through the wall instead of going around it. Any idea what could cause this? Should I make a new issue?

@AntonBock, The issue that you illustrate appears very different from what my fix addresses (more on that below).
From the images you have posted, it appears that teb was initialized with an invalid plan (one that goes through the wall), and that it failed to find a valid one. For the most part, Teb depends on being initialized with a global plan that is at least topologically valid. In other words, it works best if the plan provided by the global planner goes around obstacles. Teb will then optimze the global plan from something which may be very sub-optimal and even kinesmatically infeasible into one which is kinesmatically feasible and which optimizes various tunable critera.
If given a "straight line" plan through a wall, Teb will generally push the poses forward and backward away from the wall, but there is nothing in the optimizer graph to push the plan around the wall.
HOWEVER, it may be able to find a way around the wall when you enable its Homotopy Class Planning (by setting the max_number_classes parameter > 1), as this will cause it to explore random paths, which may result in it finding one that goes around that wall. But this can take quite some time and is not guaranteed to happen.
Bottom Line: Look at the configuration of your global planner and make sure it is producing a plan that goes around the wall and that this is the plan that teb is receiving.
What my change does is to keep teb getting stuck with a sub-optimal (but valid) which contains extra loops. In your case, however, it is not finding a valid plan to begin with, so my change is not able to help.

@howardcochran thank you for the detailed response! I'll look into the global planner, and see if that fixes my issue. Sorry for the misunderstanding

@howardcochran thank you for the detailed response! I'll look into the global planner, and see if that fixes my issue. Sorry for the misunderstanding

@AntonBock, you are welcome. Best of luck!

has this been merged! looks like it's exactly the fix I need for the issue of the planner producing all these loops!

@ros-pull-request-builder retest this please

I just rebased this PR to melodic and merged it. Many thanks for your contribution.


Update to support CUDA 6 & 7

Autotools elements need to be updated to support CUDA SDK / Toolkit versions 6.+ and 7.+

CUDA 7.0 Toolkit works fine locally for me.

CUDA 7.0 is working on remote build server as of today.

I assume that since it supports cuda 8, this can be closed?


Add support for multiple segments recorders in add_electrical_series

Right now within the add_electrical_series function in the spikeinterface module the get_traces methods only support the case when the recording is mon-segment.
However, some of the data that we have in gin is multi-segment (specifically I know it is for Neuralynx).  What we are doing right now is to sub-segment the recorder and only propagate one segment:
https://github.com/catalystneuro/nwb-conversion-tools/blob/ca17dd2146b883d60d641090772f236da1a39869/src/nwb_conversion_tools/datainterfaces/ecephys/neuralynx/neuralynxdatainterface.py#L85-L87
We should modify the function add_electrical_series to account for this and write multiple segments.
I was discussing with @bendichter today and for this simple cases could just iterate over every segment and write each as its own electrical series.

Related to #443

To clarify, are you saying the neuralynx files on GIN have more than one seg_index per file?

Yes.

So they do! And interestingly, it seems more complicated to see how many segments one might have in total via spikeextractors (even using dirname), so maybe this is another case to just support SpikeInterface and not the legacy (they both pipe to neo anyhow).

Thanks for checking, I realized that I misread your question above and only answered in positive to the first as I could not parse the second. I think I missed an "exist/are available" there.

Also, how does SpikeInterface handle the start times of the different segments? Is there an internal timestamp denoting the delay between segements? Are they assumed contiguous (in which case why consider them separate at all?)

Every segment has its timestamps. For the data in gin they are not contiguous.

OK then, that is definitely something to add to the add_electrical_series method


[Issue report] Failed to determine device ID (Enterprise Enrollment)

Describe the bug or issue
When trying to enroll this device into an enterprise, it gives the error "Oops! The system failed to determine device identifiers for this device."
Describe your setup

Raspberry Pi Model 4b
r114-r1-rpi4b
Logitech wireless (usb dongle) keyboard, Logitech wired mouse, and Acer touchscreen monitor.

To Reproduce
Steps to reproduce the behavior:

Click "Enterprise Enrollment" at the bottom right.
Enter email and password.
Observe error.

Expected behaviour
The enterprise enrollment should succeed.
Additional context
I saw the other issues, but they all said this was fixed when VPD was added in r92-r2.  I also tried rebooting, logging in as a guest and viewing the SN in chrome://system, and using the r92-r2 release.  Is there something else I need to try?  Some tutorials for chromebooks said to go into dev mode, but there is no dev mode on this so I'm not sure what to do.  Thanks!

Now, this project retains the minimal changes to the original ChromiumOS code. You can try using the openFyde version, which includes our modifications for VPD.

I just tried using openFyde and im experiencing the same issue.
Thank you.

I just tried using openFyde and im experiencing the same issue.
Thank you.

Then this issue is likely unrelated to VPD. Please try adding --allow-init-device-policy-without-state-keys to /etc/chrome_dev.conf, then restart the device and try again.

How would I add this?  Do I need to login in guest mode and put this somewhere?

You will need to gain shell access (by pressing ctrl + alt + F2 this should get you into tty), login with chronos, you can change to root privilege by sudo -i. Also do a mount -o remount rw / to unlock the root file system write permission. Then you may edit the /etc/chrome_dev.conf with any editor available.
Basic command line knowledge and skills are assumed to perform the above.

Thanks, this worked!


Update proxy settings documentation

In the current documentation, it says that for configuring a proxy server you must:
Configure the http.proxy setting in your user settings:
    "http.proxy": "https://<IP_ADDRESS>:5187/"
or for an authenticating proxy:
    "http.proxy": "https://userid:password@<IP_ADDRESS>:5187/"
Additionally, use "http.proxyStrictSSL": false if your proxy server uses a self-signed certificate.

Documentation located at: https://code.visualstudio.com/docs/setup/setup-overview#_proxy-server-support
But, in recent builds (see #22214) that "http.proxy" setting is ignored. The only working way is to pass a parameter to code.exe:
--proxy-server=http://xxxxxx:8080
(see #22214 for details about auth, etc.)
I have spent two hours trying to figure this out, and the solution was really simple when known... please update documentation ASAP when such a big change is committed. Not all of us use "system wide proxy settings".
Anyway, thanks for such an awesome piece of software.

VSCode Version: Code 1.12.2 (19222cdc84ce72202478ba1cec5cb557b71163de, 2017-05-10T13:20:36.315Z)
OS Version: Windows_NT ia32 10.0.15063
Extensions: none

Steps to Reproduce:

Configure "http.proxy" settings. They are ignored as expected (but not documented)

Fixed by Microsoft/vscode-docs#1069


ADD Action buttons bar

As a user
I need to have a bar for the action buttons
So I can perform various game functions easily
##Expectation

The interface will be built by html/css/js

Given a user
When he enters the game
Then he can perform various game functions from the action buttons bar

 Project planning


Add initial FAQ documentation file

LGTM, similar to the review process document, we should consider if we want to include it in the index so that it shows up in ReadtheDocs. Thanks!

Good catch, let me get it in there.


NestJs 9 Support

Currently the package is requiring NestJs 8 as peer dependency. You can only install the extension via a force install. The package should therefor be updated to work with the current Nest Version

I've added NestJS 9 & sentry 7.7.0 in this PR https://github.com/ntegral/nestjs-sentry/pull/93
I've also created a fork-package in the mean time. https://www.npmjs.com/package/@xiifain/nestjs-sentry

Thanks @xiifain .
@Team any plans to merge this to the main branch any sooner?

People, please make this happen. It's a blocker for our update to Nest 9.

There is some update? It would be nice to have this merged, do you know if this library is still maintained?

Last commit was back in January - @ntegral are you around or should we migrate to a fork?

In the meantime, I've created a fork as well - https://github.com/travelerdev/nestjs-sentry
It upgrades to NestJS 9.x support, as well as Sentry 7.x and separates out dependencies on @nestjs/graphql into their own package so that you can add Sentry to Nest without necessarily adding all the graphql-related dependencies (since optionalDependencies doesn't actually work the way this repository uses it - see #83)

Any progress on this?


Serious BUG of this lib !!!

when we run
 npm install --save react-native-device-info

to install this lib , it will remove some lib in node_modules folder directly,
//after install
<EMAIL_ADDRESS>removed 4 packages and updated 316 packages in 110.567s

as a result , the app will not start.
for me it delete 4 lib of my app:

fb-watchman
jest-docblock
big-integer
(haven't found)

Please why this happened ?

you got voted down because of bug title

I have found out that it might be a result of my node version is not working well with my npm version...
:(


Copilot loses focus as chats growing long

As a newbe in js/react developent I am frequenlty usig copilot to help me out. As the chat is growing lenghtly copilot seems to loose focus on its task and the previous discussion. It seems that the chat window copilot is aware of shrinks over time and finally he? just looks at the last post. This results in rahter meaningless reptitions of the same answer over and over again, which is quite frustrating. A remedy is to start a new chat, but then, one have to build a new awareness/context for copilot of the project/task one is working with. That can be time consuming and soon the awareness window starts to shrink again. Frustrating!
A proposal: try to make Copilot aware of its last answer and thus being able to avoid repeating the exact same answer over and over again. Sometimes reprhasing can halp users anderstand better

Can you try to share some specific examples? You can right click + Copy All on the chat conversation, if that helps

Sorry, but I deleted the more or less meaningless chats. What happens is
that the copilot repeats identical answers even if I try to rephrase the
promt. As I wrote before awareness of previous discussions tends to shrink
over time, and finally copilot only takes the latest post into account.
Den lör 27 apr. 2024 kl 00:19 skrev Rob Lourens @.***>:

Can you try to share some specific examples? You can right click + Copy
All on the chat conversation, if that helps
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode-copilot-release/issues/1151#issuecomment-2080186054,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BAUDMVOXHRSIX6ZFZ3NZOX3Y7LHGDAVCNFSM6AAAAABGVR3FKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBQGE4DMMBVGQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Hälsningar
Klas

We fit as much of the history into the prompt as can fit. In a long thread or after longer responses, this might become less of the conversation context. We have a smaller context window than chatgpt for example.


Refactor language providers

Each language provider instance now represents a single template
(i.e. code, doc, or fragment) for a given language. It has an internal
strategy object (*Viewing) to encapsulate template-specific generation
details. The structure of the language provider is simplified to have
a single generate method, corresponding to the generation of a single
template.
The structure of the GAPIC config YAML files has changed to push the
snippet definitions down to a per-template level, to avoid the
explosion of keys for various types of snippet files.
Pre-push hook installed.
Change-Id: Id682441e1b8a3f3209974e0d3ee3642d5a6ce610

@bjwatson, who pair programmed this change with me. (Is there a way to attribute the commit to two authors?)

cc: @pongad (since this touches some Discovery files)

@geigerj Nope, Github's not that clever. You're the primary. :)

I have finished my first pass. I like where this is heading, but I think it could be make more modular (specifically, my suggestion to specify multiple classes in the config files instead of just one).

I think I'm missing context on this change, but the changes to discovery looks good to me.

@pongad The primary motivation is to constrain the number of unique keys in the YAML files (rather than creating a new one for every template type). It also reduces some code duplication.

FYI: I will address feedback in a few successive commits, and then squash them at the end before merging. Hopefully that'll help keep track of what's changed in between feedback comments.

Updated based on feedback, PTAL

Just a couple minor comments on this round, but nothing blocking - take care of the ones you want to. LGTM.

Will merge when the change to googleapis (googleapis/googleapis#23) is approved


Added the ability to append to existing numpy files

The cnpy implementation already had support for appending a tensor to an existing npy file, and this change allows torch users to take advantage of it by adding an option mode third argument to the .savenpy function. It defaults to 'w' to preserve backwards compatibility.

Thanks Mike.. I will check it out and merge it!

merged.. thanks!

Excellent. Thanks for doing that.

On Feb 12, 2017, at 9:07 PM, Hani Altwaijry<EMAIL_ADDRESS>wrote:
merged.. thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


add searching for works user story

First pass at adding some user stories in.
This first one is from a meeting with  @alicerichmond, @kenoir and  @jtweed.
We hope to synthesise some e2e tests from this.
I will move this to a more appropriately named folder in another PR and amend all the code/build things there to not lose focus on the story.

Ping @kenoir - happy with this?

Ping @kenoir - happy with this?


Does this really need to be a module of its own?

It would seem that this role could easily slide into techservicesillinois/terraform-aws-iam instead of being standalone.

That certainly made sense at the time. Now that we've retired Shib in a Box and there are a number of viable alternatives, it probably makes sense to convert it into a more general purpose module in terraform-aws-iam to create a role for ECS containers to access secret values.

I recommend archiving the repo if this is no longer in use by SDG, since it is a public repo, particularly if it is part of shib-in-a-box since it is depreciated.

Yes, archiving, and not deleting, is a very good idea. I don't think Jon and I ever got to talking about what to do after merging in a more general purpose module into the terraform-aws-iam repo, but I never envisioned just deleting it. Thanks for giving us a good reason not to delete it.

Digging more deeply into IAM-related Terraform code, I find that the plot thickens.

I found yet another standalone repository in terraform-aws-sm-secrets-ro-policy. This is called from terraform-aws-ecs-shibd-data-sealer-role, which is the code that @kwessel and I wish to integrate into a submodule under terraform-aws-iam.
There is code in terraform-aws-iam//roles/ecs-task-execution-role that appears as if it ought to grant the GetSecretValue action to the ecs-task-execution-role, but which appeared to not work until we added the shibd-data-sealer role using from terraform-aws-ecs-shibd-data-sealer-role.
In addition, I see code in the ecs-task-execution-role that appears to give the grantee access to all SSM parameters and all SecretsManager secrets. Yikes! This was OK for expediency when we were new to all of this, but we shouldn't give Course Explorer access to the Shibboleth IdP's secrets, for example. Keith and I have refactored the IdP secrets manager code to make a hierarchy (e.g., shibboleth-idp/data-sealer instead of shibboleth-idp-data-sealer. With this hierarchy in place, we could restrict future access to SecretsManager secrets using more precise wildcard patterns.
I looked at terraform-aws-iam as a whole last evening, and I became discouraged. It's a rat's nest with a lot of technical debt and not much documentation. This is understandable given that it was code we wrote early in the game to get off the ground, but these discoveries do not make the terraform-aws-iam a good showpiece to present to campus. There's no question that Amazon IAM is complex, but that complexity is also a compelling reason to give this module an in-depth review for baggage that remains from our early implementation, and to give each submodule some documentation so that people who are not Amazon IAM experts can make sense of it, and make good decisions about how to set up their access control.
After @ddriddle left SDG, I added the terraform-aws-iam//service-roles submodule to eliminate the annoyance that I and service owners had because each of the xxxAdmin roles was a one-off role definition that baked in service-specific policies into modules; the new code means one can simply modify an infrastructure definition and grant access to a lot of things. Apropos of this, there are a few AWS services that need to be added to this module, but I have also reached the conclusion that I misnamed the module. Perhaps service-user would be more descriptive of the function than the present name.

My conclusion here is that fixing the data sealer role stuff is just the tip of the iceberg. I think this whole module deserves a line-by-line review, which will probably flush out some code changes as well as structural changes to the hierarchy.
You already know the reasons that terraform-aws-iam is not a public module, even though I would like it to be so.
I think @edthedev and @tim-morgan are also stakeholders if we intend to push this out to a wider audience. There's a lot of useful code there, but it suffers from being specific to our business needs, and from being written early in our cloud development days.
I would probably name terraform-aws-iam as one of the earliest modules we should schedule for a collaborative review. If someone wants to advocate making this public, I certainly won't object.
BTW, any time we retire a module, we ought to archive it rather than simply deleting it. How long it should remain as archived isn't important until someone asks for support for something we deprecated five years ago. :-)


In a special case, the attribute binding will fail.

Version
3.2.26
Reproduction link
sfc.vuejs.org/
Steps to reproduce
As a comparison, enter the following two sets of characters in the input box.

Enter '1', '2', '3', '4' in order. They are completely different characters.
Enter 'a', 'a', 'a', 'a' in order. They are completely same characters.

What is expected?
In the second case, there should always be a single "a" in the input box.
What is actually happening?
In the second case, Vue does not do anything. The input box behaves just like its default behavior.

Here is my speculation:
Normally, the "value" of the input box is the same as the "text". Therefore, for efficiency, when the value assigned to "text" is the same as the previous one, it is not re-rendered.
However, in the callback of the "input" event, the "value" is the new content entered by the user, and the "text" is the old content that has not been changed. If you try to revert the input box to the old content (by changing the "text"), it will be ignored by Vue.
This behavior is also present on other forms.
(This issue was modified from machine translation. If something is not clear, please feel free to ask.)

A similar problem exists in vue 2, but I haven't tested the version specifically.

I believe that this is the same case as https://github.com/vuejs/vue/issues/7506#issuecomment-372139382 and it always worked like that
When you type "a", component re-renders because previous value of text was "3", but when you type the same letter for the second time, component won't update because value has not changed. You can fix this by setting a new value of the input field in your @input handler.
Updated demo

I think the reason of this bug is the hasChanged function in here: https://github.com/vuejs/vue-next/blob/master/packages/reactivity/src/baseHandlers.ts#L170
In this case, the text you input is same as you input before, so it will not trigger effect or update component.
If we remove the hasChanged function, this bug will be fixed. But this comes with additional performance overhead.
Is there a better way to fix it?

Force trigger the ref with triggerRef(): https://sfc.vuejs.org/#eyJBcHAudnVlIjoiPHNjcmlwdCBzZXR1cD5cbmltcG9ydCB7IHJlZiwgdHJpZ2dlclJlZiB9IGZyb20gJ3Z1ZSdcblxuY29uc3QgdGV4dCA9IHJlZignMycpXG5cbmZ1bmN0aW9uIG9uSW5wdXQoZXZlbnQpIHtcbiAgdGV4dC52YWx1ZSA9IGV2ZW50LmRhdGFcbiAgdHJpZ2dlclJlZih0ZXh0KVxufVxuPC9zY3JpcHQ+XG5cbjx0ZW1wbGF0ZT5cbiAgPGlucHV0IDp2YWx1ZT1cInRleHRcIiBAaW5wdXQ9XCJvbklucHV0XCIgPlxuPC90ZW1wbGF0ZT4iLCJpbXBvcnQtbWFwLmpzb24iOiJ7XG4gIFwiaW1wb3J0c1wiOiB7XG4gICAgXCJ2dWVcIjogXCJodHRwczovL3NmYy52dWVqcy5vcmcvdnVlLnJ1bnRpbWUuZXNtLWJyb3dzZXIuanNcIlxuICB9XG59In0=

Force trigger the ref with triggerRef(): https://sfc.vuejs.org/#eyJBcHAudnVlIjoiPHNjcmlwdCBzZXR1cD5cbmltcG9ydCB7IHJlZiwgdHJpZ2dlclJlZiB9IGZyb20gJ3Z1ZSdcblxuY29uc3QgdGV4dCA9IHJlZignMycpXG5cbmZ1bmN0aW9uIG9uSW5wdXQoZXZlbnQpIHtcbiAgdGV4dC52YWx1ZSA9IGV2ZW50LmRhdGFcbiAgdHJpZ2dlclJlZih0ZXh0KVxufVxuPC9zY3JpcHQ+XG5cbjx0ZW1wbGF0ZT5cbiAgPGlucHV0IDp2YWx1ZT1cInRleHRcIiBAaW5wdXQ9XCJvbklucHV0XCIgPlxuPC90ZW1wbGF0ZT4iLCJpbXBvcnQtbWFwLmpzb24iOiJ7XG4gIFwiaW1wb3J0c1wiOiB7XG4gICAgXCJ2dWVcIjogXCJodHRwczovL3NmYy52dWVqcy5vcmcvdnVlLnJ1bnRpbWUuZXNtLWJyb3dzZXIuanNcIlxuICB9XG59In0=

After testing, this method fails in the following two cases.

without using setup: SFC
Use other components instead of the native form: SFC

triggerRef only works on refs, so it's expected that it doesn't work on this.text.
For case (2), a component won't update if it receives the same props passed to it. In this case you'll have to manually update the input in the child component:

https://sfc.vuejs.org/#eyJBcHAudnVlIjoiPHNjcmlwdCBzZXR1cD5cbmltcG9ydCB7IHJlZiwgdHJpZ2dlclJlZiB9IGZyb20gJ3Z1ZSdcbmltcG9ydCBDb21wIGZyb20gJy4vQ29tcC52dWUnXG5cbmNvbnN0IHRleHQgPSByZWYoJzMnKVxuXG5mdW5jdGlvbiBvbklucHV0KGV2ZW50KSB7XG4gIHRleHQudmFsdWUgPSBldmVudC5kYXRhXG59XG48L3NjcmlwdD5cblxuPHRlbXBsYXRlPlxuICA8Q29tcCA6dmFsdWU9XCJ0ZXh0XCIgQGlucHV0PVwib25JbnB1dFwiIC8+XG48L3RlbXBsYXRlPiIsImltcG9ydC1tYXAuanNvbiI6IntcbiAgXCJpbXBvcnRzXCI6IHtcbiAgICBcInZ1ZVwiOiBcImh0dHBzOi8vc2ZjLnZ1ZWpzLm9yZy92dWUucnVudGltZS5lc20tYnJvd3Nlci5qc1wiXG4gIH1cbn0iLCJDb21wLnZ1ZSI6IjxzY3JpcHQgc2V0dXA+XG5pbXBvcnQgeyByZWYsIG5leHRUaWNrIH0gZnJvbSAndnVlJ1xuICBcbmNvbnN0IGlucHV0ID0gcmVmKClcbiAgXG5jb25zdCBwcm9wcyA9IGRlZmluZVByb3BzKFsndmFsdWUnXSlcbmNvbnN0IGVtaXQgPSBkZWZpbmVFbWl0cyhbJ2lucHV0J10pXG5cbmZ1bmN0aW9uIG9uSW5wdXQoZXZlbnQpIHtcbiAgZW1pdCgnaW5wdXQnLCBldmVudClcbiAgbmV4dFRpY2soKCkgPT4ge1xuICAgIGlucHV0LnZhbHVlLnZhbHVlID0gcHJvcHMudmFsdWVcbiAgfSlcbn1cbjwvc2NyaXB0PlxuXG48dGVtcGxhdGU+XG4gIDxpbnB1dCByZWY9XCJpbnB1dFwiIDp2YWx1ZT1cInZhbHVlXCIgQGlucHV0PVwib25JbnB1dFwiID5cbjwvdGVtcGxhdGU+In0=

I've come up with an argument for this behavior of Vue. This might be an okay explanation:
Vue always assumes that the bound data is the same as the real value of the form. The advantage of this is that when the bound data is assigned by its old value, Vue can ignore the assignment to optimize performance.
However, this assumption is broken in the event that the value of the form is modified by user. At this point, the real value of the component is the value just entered by the user, and the bound data has not yet been updated. In this case, if the bound data is modified with the old value, Vue will incorrectly perform the optimization.
Therefore, to ensure that this assumption always holds. v-modle should always be used to make the data consistent with the true value.


Don't always require port 80 in determineRouterPorts(), fixes #2512

The Problem/Issue/Bug:
@chellman points out in #2512 that if port 80 is occupied, ddev refuses to start, even if the project is configured to not use port 80.
How this PR Solves The Problem:
There was code in determineRouterPorts() that always added port 80 to the ports list. I am not sure if this was debugging code or if I'm about to find out what it was there for.
Manual Testing Instructions:
brew install nmap and then run it with ncat -l -k -p 80
Set project to start with router_http_port: 8080
ddev start
It should work
Automated Testing Overview:

Related Issue Link(s):
Release/Deployment notes:

@chellman reports after kindly testing this that now ddev start works fine, but ddev stop fails when it tries to stop the router,
The Compose file '/Users/chellman/.ddev/.router-compose.yaml' is invalid because:
services.ddev-router.ports contains an invalid type, it should be an array
Failed to stop project project-name:
Failed to run docker-compose [-f /Users/chellman/.ddev/.router-compose.yaml config], err='exit status 1', stdout='', stderr='The Compose file '/Users/chellman/.ddev/.router-compose.yaml' is invalid because:
services.ddev-router.ports contains an invalid type, it should be an array'

This was covered elsewhere, but just in case, it's the empty ports array in that ~/.ddev/.router-compose.yaml.  Sample contents (the offending line is number 6):
version: '3.6'
services:
  ddev-router:
    image: drud/ddev-router:20200909_ddev_router
    container_name: ddev-router
    ports:
    volumes:
      - /var/run/docker.sock:/tmp/docker.sock:ro
      - ddev-global-cache:/mnt/ddev-global-cache:rw
    restart: "no"
    healthcheck:
      interval: 1s
      retries: 20
      start_period: 20s
      timeout: 120s
networks:
  default:
    external:
      name: ddev_default
volumes:
  ddev-global-cache:
    name: ddev-global-cache


Connect to Github notification is noisy

I am always seeing following notification when settings sync install Gitlens

Accounts icon already shows a number badge for this

So not sure if the notification is needed.

Or, at least, add an option "don't show again" or something..

When are you seeing this? I would only expect it to show once, if you accept, for each machine (since I don't think we sync the auth). And once for each workspace, if you reject.
@sandy081 The reason I am showing this notification, is because without it the user just gets an allow authentication access prompt (from the built-in vscode auth) and they wouldn't know why.

Now that I checked, I think one time for each project.

@moshfeu are you rejecting? or accepting?

Rejecting 😳

Ah, so you want an always reject? Curiously, why don't you want it to connect to GitHub?

For now.. I use to reject requests until I need the feature. Nothing personal :)

No worries, just curious. And FYI, the connection provides many passive features -- GitHub avatars, richer issue linking in hovers, rich PR linking in views, hovers, and annotations.

Thanks! I really like this extension and I'll probably connect Github soon.

Ah, so you want an always reject? Curiously, why don't you want it to connect to GitHub?

Personally, I opted out once I saw the permissions requested 🤯

I have the same question.
I just want to see blame message from git history, I don't want to see pull requests or something else.
Can provided an global option to disable connect to GitHub, if anyone want to disable it, just opt out.

Hello, experiencing the same. I keep getting notified on each VSC start, and it's irritating.
I also find the "Cancel" option (button) confusing, but this is a general UX design problem: does it mean "confirm negative intention" (in this case, don't show warning anymore), or "close widget without applying any change" (in this case, show warning again next time)?
Use case: my usage of GitLens is very limited, as I'm a heavy terminal user; additionally, as a general systems administration practice, I don't give permissions to services I don't require. Therefore I don't benefit from authorizing a remote connection.

Yeah, I will definitely be adding a way to completely opt-out soon. Sorry for the inconvenience.

Yeah, I will definitely be adding a way to completely opt-out soon. Sorry for the inconvenience.

Thank you for the addon, it's impressive! :smiley:

@eamodio

The reason I am showing this notification, is because without it the user just gets an allow authentication access prompt (from the built-in vscode auth) and they wouldn't know why.

I think auth feature of VS Code shall be able to handle the UI instead of each extension come up with its own. I would request not to do this (any custom UI or notifications for authentication) instead please raise your concerns with auth feature to handle your request.
@RMacfarlane FYI

It's showing every time I open a new workspace for me.

why don't you want it to connect to GitHub?

The requested authorization is WAY too permisive

This is much different than allowing me to initiate and control actions from my machine (via ssh keys etc) .  Wont this generate an authorization that can me used offline, from their servers, without additional consent/initiation?

@MaerF0x0 Unfortunately currently the VS Code authentication APIs (because of limitations with GitHub auth) don't allow for any permission scopes less permissive than what I'm currently asking for (the repo scope) -- I wish I could just ask for read-only access, but that isn't currently possible.

Can you please verify this fix in tomorrow's insiders edition? Be sure to disable/uninstall the stable version of GitLens first.
You can install the insiders edition from here.
I've reworked the notifications a bit to be clearer and added a "don't ask me again" type option. Unfortunately there still is 1 extra notification in certain cases, but that is because of https://github.com/microsoft/vscode/issues/111529. So once that gets fixed I can remove it.

@eamodio  is it possible that I can generate my own token w/ pared down scopes to provide to the plugin via the settings.json?

I believe so -- during the VS Code auth flow (when it opens the browser window), I believe there is an entry in the statusbar that you can click that will prompt for a PAT.  But I don't believe you can create a PAT with any less scopes than I am currently asking for -- because repo info, prs, issues etc are all under the repo scope.

@eamodio try checking out the personal access token new page, there are lots and lots of options... I understand that vscode maynot have the hooks to allow you to generate one for us, but maybe we could just generate a limited access one to use?
https://github.com/settings/tokens/new

Yes, but as I said -- the ONLY scope on that page that lets you get to repository information -- including PR & Issues -- is the repo scope -- and there is nothing more granular. If there was -- I would be asking for it -- since those are the exact same set of scopes I am choosing from.

@eamodio is it possible that I can generate my own token w/ pared down scopes to provide to the plugin via the settings.json?
to be honest I basically use gitlens in a read only fashion -- to see git praise, to check out branches, commit log etc.
That way it can only run from my machine too?

I raised https://github.com/eamodio/vscode-gitlens/issues/1210 for exactly this. It’s not possible for us to use the authentication feature because we’re on enterprise and VSCode takes me to GitHub.

The VS Code team is trying to auth with GitHub using a GitHub app (rather than tokens) which should offer great granularity in permission requests, but we are currently blocked because of a bunch of technical limitations. So until those get unblocked there isn't much that can be done unfortunately :cry:
@jasonwilliams Try the steps here: https://github.com/eamodio/vscode-gitlens/issues/1208#issuecomment-739052899 but again your PAT would have to have the repo scope for things to work.

Can you please verify this fix in tomorrow's insiders edition? Be sure to disable/uninstall the stable version of GitLens first.
You can install the insiders edition from here.
I've reworked the notifications a bit to be clearer and added a "don't ask me again" type option. Unfortunately there still is 1 extra notification in certain cases, but that is because of microsoft/vscode#111529. So once that gets fixed I can remove it.

Is this still only on insiders?
or on Stable too? I don't see a "don't ask me again" option on stable so was just wondering

Ah, so you want an always reject? Curiously, why don't you want it to connect to GitHub?

Why would I want to connect to GitHub? I can, and have been, using GitLens without connecting to GitHub. The constant prompt is irritating.

Is there a way to connect to GitHub after opting out?

Why would I want to connect to GitHub?

@pcgeek86 Because of the features the integration enables. I'm glad that you are happy with what you have, but there are plenty of people that want/would benefit from a deeper integration with GitHub.
And I 100% agree that the constant prompt is totally aggravating, and I apologize for that (I switched from my own auth to using the vscode auth right before I shipped GitLens 11, and I really needed to do more scenario testing because of those changes). You can use the insiders edition today to get the fix for this, and I will be releasing it to stable very soon.
@mikeyhew You can click the Connect to GitHub... link in the hovers, or click on the Connect command for the remote in the Remotes view.


Avoid races in CD container builds over symbolic references in checkouts

Summary

Categories: cicd.

Don't supply the symbolic GitHub reference name to the ref parameter of the checkout action in the build-push-container-all workflow jobs.
The default behavior of actions/checkout would do the right thing, checking out the SHA of the triggering event, thereby avoiding races with concurrent pushes to the repository modifying the symbolic references.

@mzabaluev I believe this will cause it to check out detached heads when responding to a label event.

@mzabaluev I believe this will cause it to check out detached heads when responding to a label event.

That may be actually the correct way to run: the symbolic branch head may have been pushed to another commit by the time the job runs, which has happened e.g. in https://github.com/movementlabsxyz/movement/actions/runs/11726835429/job/32668512421#step:2:215
I can restore the statements as well, but replace the .ref with .sha.


First try to adopt Python3 and PyQt5

Here's my first bytes to adopt Python3 and PyQt5 in order to modernize this very useful application.
@Kilian Are you interested in this approach?
Here's the TODO that will be updated:

Find all possible regressions and missing changes.

I've also move the TODO file to the root directory for more visibility (standard practice) and convert it and the README files in markdown.
It seems to works quite well. I let you test these changes and give me advices. If you want to commit directly in my fork to update this PR, don't hesitate ;).

Hey Huluti, What would you say are the main benefits of switching to py3 and pyQt5? It's been a while since I worked on Trimage so would like to err on the side of "if it ain't broken..."

(aside from the obvious: we'll want to upgrade eventually, and it cleans up a whole bunch of code, nice!)

In my opinion, the best benefit is to ensure the existence of Trimage in the future when python 2 and qt 4 will be removed from the distribution directories. The work on the repo does not mean to release a new version, it can take some time before leaving an update to be sure of its quality. I am ready to help to make this possible.

Did that convince you?

yes, it's a good reason :)

https://www.phoronix.com/scan.php?page=news_item&px=Ubuntu-Python-2-Demotion
Exactly what I was talking about ;)
I think that my code is ready, could you find time to test it and merge it ?

Will do!

@Kilian any news? ;)

I've been busy outside of OS, sorry! I'll get to this in the near future, thanks for the reminder.

I tried to run it. after getting the pyqt5 bindings for python 3, I quickly ran into this issue:
[kilian:...nal/trimage/python3/Trimage]$ python3 src/trimage/trimage.py
Traceback (most recent call last):
  File "src/trimage/trimage.py", line 18, in <module>
    from filesize import *
  File "/home/kilian/workspace/personal/trimage/python3/Trimage/src/trimage/filesize/__init__.py", line 1, in <module>
    from filesize import traditional, alternative, verbose, iec, si, size
ImportError: cannot import name 'traditional'
[kilian:...nal/trimage/python3/Trimage]$     ```

Does that work for you? I have very little experience with python3 (and haven't touch python in general in many years) so I have no clue on why this works in py2 and not in py3

I'm looking at it and I can not get it to work anymore ... I look at what I can do;)

It starts, but there are three issues I see:
1 functionality is broken. We use generators and calling next changed, so this needs to be updated:
-- a/src/trimage/trimage.py
+++ b/src/trimage/trimage.py
@@ -171,8 +171,8 @@ class StartQT5(QMainWindow):
         delegatorlist = []
         for fullpath in images:
             try: # recompress images already in the list
-                image = (i.image for i in self.imagelist
-                    if i.image.fullpath == fullpath).__next__()
+                image = next(i.image for i in self.imagelist
+                    if i.image.fullpath == fullpath)
                 if image.compressed:
                     image.reset()
                     image.recompression = True

2 some filenames seems to give errors:
Traceback (most recent call last):
  File "src/trimage/trimage.py", line 334, in data
    data = self.imagelist[index.row()][index.column()]
  File "src/trimage/trimage.py", line 389, in __getitem__
    return self.d[key](self.image)
  File "src/trimage/trimage.py", line 357, in <lambda>
    'shortname': lambda i: self.statusStr() % i.shortname,

In updating to pyqt5 for python3, it seems that the file dialog is now Qt's one instead of the native one. Can that be remedied?

After this lands, the debian folder needs an overdo as well, since from quick samples, it's no longer actually valid. Do you have experience there?

1 - So, what you've write is the correct solution that I have to add?
2 - What sort of filenames? Do you have examples?
3 - Strange because it seems that pyqt5 use by default native dialogs...
I'm not an expert in packaging for debian but I can get a look :smiley:

1 - So, what you've write is the correct solution that I have to add?
2 - What sort of filenames? Do you have examples?
3 - Strange because it seems that pyqt5 use by default native dialogs...
I'm not an expert in packaging for debian but I can get a look :smiley:

any updates? on debian they are planning to remove it because is not working anymore

Just to let you know, trimage is listed on https://wiki.debian.org/Qt4Removal and we are killing Qt4-related applications one by one in Debian (as well as in Ubuntu).

I'll try to work on the PR today.

@Kilian for me all is working when launched with:
python3 src/trimage/trimage.py

Super nice @Huluti!
@hosiet could you assist us in updating the debian folder? (incrementing the version numbers is no problem, but there's probably some other notational changes that happened in the last 8 years that might require updates as well.

@hosiet any thing to do to have Trimage 1.0.6 updated in Debian?

First of all, Debian is now in deep freeze state preparing for the release of Debian 10; no new version could be uploaded at this moment. Secondly I'm not the maintainer of trimage in Debian; the maintainer is the team<EMAIL_ADDRESS>and Kilian Valkhof<EMAIL_ADDRESS>. I guess I'll contact them using email first.


feat: introduce environment variables for args

adds fallack to environment variables for common command line
arguments (FLUTTER_VERSION_CHECK, FLUTTER_ANALYTICS)

Fixes: #107046
Signed-off-by: TheOneWithTheBraid<EMAIL_ADDRESS>Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is test-exempt.
[ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

I'd like to get a hint on testing: I'm unsure of how (far) this should be tested in Flutter's tests.

There are a lot of unrelated formatting changes in the patchset. I would revert them so as to make the actual changes much more clear.

I can of course do that but shouldn't we try to keep close to Flutter's default formatting?

There are a lot of unrelated formatting changes in the patchset. I would revert them so as to make the actual changes much more clear.

I can of course do that but shouldn't we try to keep close to Flutter's default formatting?

The flutter repo uses its own set of guidelines for formatting: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#formatting, which is not quite compatible with standard dart/flutter format, typically used by IDEs through the 'format on save' option.
Generally though, as long as the lines are not something that need to change to incorporate the new feature, it is preferable to keep them untouched, to make the review process much smoother.
If you do want to propose far-reaching formatting changes you are welcome to do so in a separate PR.

I don't think we should make all feature arguments configurable via environment variable, as it would make it more difficult to reason about what users are opting in to or out of when filing bug reports. Can you limit this PR to just FLUTTER_VERSION_CHECK?

@christopherfujino I now reduced it to the FLUTTER_VERSION_CHECK and the FLUTTER_ANALYTICS variables.

I don't think we should make all feature arguments configurable via environment variable, as it would make it more difficult to reason about what users are opting in to or out of when filing bug reports. Can you limit this PR to just FLUTTER_VERSION_CHECK?

I don't think we should make all feature arguments configurable via environment variable, as it would make it more difficult to reason about what users are opting in to or out of when filing bug reports. Can you limit this PR to just FLUTTER_VERSION_CHECK?

Even though I think --supress-analytics should be configurable system-wide for compliance reasons, I removed this and reduced this MR to the --no-version-check as this is definitely the more important thing.
Does it looks sound to you now, @christopherfujino? Thanks for your time reviewing this MR.

Thanks a lot for the review. I correspondingly adjusted the code.

Thanks @christopherfujino for the detailed feedback. Maybe even a comment "Look on code style" would have been sufficient...
I correspondingly updated the changes.

In general, do you think you would be open to other parameters as command line arguments too? In particular, I'd still like to have especially the analytics (for legal reasons in PKGBUILDs), the cache location (for proper library/executable separation) and the machine flag (for automation).

You still have failing tests on this PR, and I think you'll need to rebase upstream to fix the ci.yaml validation.

 The CI outputs do not seem very helpful to me.

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8801700922435667617/+/u/run_test.dart_for_tool_tests_shard_and_subshard_general/test_stdout

Thank you for contributing! As you have not responded within 3 weeks, I will be closing this PR as stale. If you are still interested in landing this, feel free to rebase this PR upstream, address code review feedback, and re-open this PR.

@christopherfujino I at least locally fixed the tests and would appreciate re-opening the PR. Thanks a lot.


Track Click events for Create using command line button

Description 📝
Track events for clicking Create using command line Button
What does this PR do?
Tracks click events for Create using command line Button

Confirmed that dev tools show event on button click. 👍 Is this just a ticketless follow up from the initial work?

@mjac0bs Good call. I will create a defect for it


Fix new docs links

Removes /docs path prefix from all docs links.
Fixes firezone/product#426

Pull Request Test Coverage Report for Build ebaec1aa21735ea25adbbb783eaf0a57f9f566b7-PR-865

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 68.937%

Totals

Change from base Build 01cb023cc282f42c2b2313db120b4937af7ddcfb:
0.0%

Covered Lines:
992

Relevant Lines:
1439

💛  - Coveralls


Get shipping option on country select

There is no easy way of displaying valid shipping options in the checkout view - it requires a bit of JS to get hold of shipping options based on what the user selects.
A template tag or base template to help this would be useful

Looking at creating a custom ajax widget might also be a solution


Data/extract data csv postgres

create dummy data for the new tables
extract the data from postgres into excel
excel saved to local directory

Next things to do:

update the code with new tables
do up the views to connect to frontend

Oh and please resolve the merge conflicts as well.


confirm password validation

how to make confirm password validation in custom role ?
how to access anther filed pram in custom role ?

Encode the request body and get the original password value and compare it to custom rule value


github/update: run on current branch

This will be paired with a PR refactoring the workflow on the main branch, but nothing should block merging this early since we do not currently run the workflow on the stable branch.
This PR syncs the update workflow with main's, but doesn't include the parts where we generate files.
It also removes the inputs and schedule parts of the workflow, as the intention is a new call-update.yml workflow will be added to call each branch's update.yml workflow.

@mergifyio queue


document support for query params

Hi @jmorrell !!!
I want to open a PR documenting support for the range query param:
$ curl "https://semver.io/node/resolve/?range=^8.3.0"
8.11.1

Before I do so, just want to make sure it's wanted, and that it has a chance of being merged :)

We've actually stopped using semver.io in all official buildpacks, and it's not really being actively maintained beyond security updates.
I'm happy to merge a PR, but would you be interested in taking back ownership?
cc @hunterloftis

I kinda thought that might be the case. Are you using another service now instead? Solving the range resolution problem a different way?

would you be interested in taking back ownership?

Unfortunately, no. I don't have enough of a need for it right now to take that on.

Are you using another service now instead?

We're using a new service: https://nodebin.herokai.com/ that replaces s3pository and semver.io but is not open source

Cool. Is the outside world (e.g. the @probot org) welcome to use this service?

Ideally not. Currently it only serves Node binaries, but this is likely to be extended in the near future to do things like:

Support other language runtimes, specifically compiled for Heroku's stack images
Run integration tests specific to the Heroku platform before binaries are made available
tag certain releases as "skip" if users experience issues with them on Heroku (ex: Yarn 1.0.0, npm 5.3.0)
etc

While any iterations will be versioned, we're not really intending for the service to be consumed by third-parties.
What is the use-case for @probot? Is it met by semver.io?

Okay thanks for the clarification. semver.io was a longshot solution for  https://github.com/probot/friction/issues/29

Even with no buildpacks using it, semver.io is still receiving ~80k requests / day during the week which is why we haven't taken it down. Ideally we could pass it off to community owners somehow.

semver.io is still receiving ~80k requests / day

That warms my heart :)

Maybe we could start a fund for it with OpenCollective or something. Any idea who's using it? Forked buildpacks mostly?


Update optimization docs

What does this PR do?

Part of docs revamp #7666
Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

[ ] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[ ] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes? (if necessary)
[ ] Did you write any new necessary tests? (not for typos and docs)
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] Did you list all the breaking changes introduced by this pull request?
[ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃
cc @borda

@rohitgr7 Could you add description to the docs revamp PRs regarding the motivation for the change?


.htaccess  issue

Minor thing this, only noticed it today.  The .htaccess that ships with Magento 1.x includes a set of PHP settings that will be ignored by an install running PHP 7.x.
This is because they are contained within an <IfModule mod_php5.c> declaration.
The simple fix for this is to change it to <IfModule mod_php7.c>.  Assuming no other incompatible changes have been made to the content of this block, there are no issues.
This is fairly important because one of the things added in this block by default is:
php_value memory_limit 256M
php_value max_execution_time 18000

..which will be ignored without this change.
Do you think this is important enough to be included in this modul

This is true, and quite important on setups which use mod_php. Most production sites don't, but many development localhosts do. I don't think we can "patch" .htaccess from the module itself, but we document this in readme file, just to remind users.

Cool, that would seem to be sufficient :+1:


Meta: Switch to clang-19 and clang-format-19

clang 19 has been out for some time, and it's becoming increasingly difficult to keep clang-format-18 on updated distros.

I think for the next transition we should think about yeeting our clang-format script and just relying on git clang-format

:man_shrugging: Despite the authors of clang-format disagreeing, I prefer just doing a project-wide reformat on a code base of our size

🤷♂ Despite the authors of clang-format disagreeing, I prefer just doing a project-wide reformat on a code base of our size

Yeah, agree, from experience incremental format is more painful than a one that does the entire thing

🤷♂ Despite the authors of clang-format disagreeing, I prefer just doing a project-wide reformat on a code base of our size

Fair enough. Certainly not a hill I'm willing to die on.


PyString indentation issue

EDIT:  PLEASE IGNORE. We have found the problem. A recent change to our JavaScript implements autoindent when one types directly into a textarea. Apparently, the "I set the field ... to" statement simulates character-by-character typing rather than simply setting the entire contents to the given value, as I had expected.
I am using behat in a Moodle development environment. A behat feature that has worked fine for months has suddenly stopped working, though the feature file itself is unchanged. The failure is occurring in three independent environments: GitHub CI, my own moodle-plugin-ci environment, and a native Moodle + behat environment on Linux. It can't be just a Moodle version problem, as the failure occurs with all Moodle versions in the GitHub CI run.
I have tracked the problem down to the following behat statement within the offending feature file, which inserts Python code into a form field:

    And I set the field "id_template" to:
  """
  import subprocess, json, sys
  {{ STUDENT_ANSWER | e('py') }}
  tests = json.loads('''{{ TESTCASES | json_encode | e('py') }}''')
  test_results = [['Test', 'Expected', 'Got', 'iscorrect']]
  num_right = 0
  for test in tests:
    code = test['testcode']
    expected = int(test['expected'])
    got = eval(code)
    test_results.append([code, expected, got, expected == got])
    if expected == got:
      num_right += 1
  print(json.dumps({
    'testresults': test_results,
    'fraction': num_right / len(tests)
  }))
  """

What that now produces in the target field is:
import subprocess, json, sys
{{ STUDENT_ANSWER | e('py') }}
tests = json.loads('''{{ TESTCASES | json_encode | e('py') }}''')
test_results = [['Test', 'Expected', 'Got', 'iscorrect']]
num_right = 0
for test in tests:
  code = test['testcode']
    expected = int(test['expected'])
      got = eval(code)
        test_results.append([code, expected, got, expected == got])
          if expected == got:
              num_right += 1
              print(json.dumps({
                'testresults': test_results,
                  'fraction': num_right / len(tests)
                      }))

It appears that behat is autoindenting each line to match the previous line, then adding my own indentation to that. This is contrary to the specified behaviour:
"Indentation of the opening """ is not important, although common practice is two spaces in from the enclosing step. The indentation inside the triple quotes, however, is significant. Each line of the string passed to the step definition’s callback will be de-indented according to the opening """. Indentation beyond the column of the opening """ will therefore be preserved."
I have experimented with various alternative base-indentation levels within the PyString (e.g. no indentation, 2, 4 and more) and with different increments within the Python code (1 char, 2 chars and 4 chars). The problem persists in all cases.
I can't be sure what version of behat is running in the moodle-plugin-ci on github, but in my native environment it's behat 3.13.0. This is a relatively old version (April last year) so unless Moodle has somehow triggered an update from an even older version, it seems unlikely that the problem is with behat alone. OTOH the fact that the problem occurs with multiple versions of Moodle (4.1, 4.2, 4.3 and 4.4) and PHP (7.3, 7.4, 8.0, 8.1 and 8.2) seems to rule out Moodle as the source. Leaving with nowhere to look! Any help would be much appreciated.

@trampgeek thanks for the update - yes, that's correct that (most of?) the browser-based Mink drivers set field values by typing into them, as that's the best simulation of user behaviour (e.g. firing keyboard and input events as well as just the final change).


Drop "Design guidelines" menu from documentation

Drop "Design guidelines" menu from the documentation.
If things are only in this part of the documentation and if they are relevant, move them somewhere else in the documentation.

On hold for the moment. We're waiting for a confirmation by ODS.


[Feature][SQL Config] Add SQL config adapter

Purpose of this pull request
[Feature][SQL Config] Add SQL config adapter

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

[ ] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
[ ] If you are contributing the connector code, please check that the following files are updated:

Update change log that in connector document. For more details you can refer to connector-v2
Update plugin-mapping.properties and add new connector information in it
Update the pom file of seatunnel-dist

[ ] Update the release-note.

cc @EricJoy2048 @Hisoka-X

Could you add some unit test for the new module named seatunnel-config-sql to vertify the logical?


testing branch for onbarding

Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL:
iOS PR:
macOS PR:
What kind of version bump will this require?: Major/Minor/Patch
Optional:
Tech Design URL:
CC:
Description:

Steps to test this PR:
1.
1.

OS Testing:

[ ] iOS 14
[ ] iOS 15
[ ] iOS 16
[ ] macOS 10.15
[ ] macOS 11
[ ] macOS 12

Internal references:
Software Engineering Expectations
Technical Design Template

Current dependencies on/for this PR:

main

PR #615   👈

This stack of pull requests is managed by Graphite.


[WIP DO NOT MERGE] Scala-js Travis

Testing to run scala-js tests on travis.

Closing to re-submit, this does not seems to trigger travis build.


editorOverviewRuler, impossible to change color of text highlighted after Ctrl+F

VSCode Version: 1.21.0
OS Version: Ubuntu 16.04

Steps to Reproduce:

Having a light theme (default light)
Double click on a word in the code window
Press Ctrl+F to search in the current file
On a ruler, the blocks are too bright and it's impossible to change their color (can't find any relevant setting).

Does this issue occur when all extensions are disabled?: Yes

The color for that would be editorOverviewRuler.findMatchForeground, but the problem is that the  editorOverviewRuler.selectionHighlightForeground is always painted above.
@alexandrudima Is that intended? If yes, does it mean we should make sure the two colors always use opacity?

If the language mode supports document symbols, wordHighlights are created and that color is also above the find highlights.
The colors for that are "editorOverviewRuler.wordHighlightForeground" and "editorOverviewRuler.wordHighlightStrongForeground"
As it is hard to say which of these highlights is the most important one (all depends on what you are currently looking at), the right way is to always use transparency with editorOverviewRuler colors.
I will annotate the colors and improve the description.


user docs: Add responsive design.

Adds responsive design to user docs for screens with narrow widths.

@brockwhittaker can you review this one?

I checked this out, and it definitely improves the /help/ pages a lot on mobile!  @synicalsyntax from the code, it looks like these CSS changes also change all the other logged-out pages like /apps, /integrations, /login, etc.; is that intentional?

@timabbott Yep, I noticed that those other pages were a bit too squished togetherness on the edges, so I fixed those along the way too.

Ahh, I see.  OK, merged, @brockwhittaker probably still worth your giving this a look in case you have ideas for how to further optimize the CSS.
Thanks @synicalsyntax!

Hey @synicalsyntax, looks good but just curious why'd you change .header .darker to 40px when 100% spans the whole height of the element (and flexibly changes if the height changes)? I just can't tell if I'm missing something.
If no particular reason we should change it back because .header .stripes is also 100%.

@brockwhittaker Yeah, I think I should do some explaining on that..
A while ago I tried to log into the Zulip Mac app; however, upon doing so, the navbar covered the entire screen, hiding all login elements and preventing me from logging in. I later discovered it was because .header .darker was set to 100%.

This is what the app looks like for me right now, and it's because .header is set to 100% and I'm planning to change that soon.
Also, .header .stripes is 40px on my end, I'm not sure why it's showing as 100% for you.

Hm interesting. That's good enough of a reason then; interesting
inconsistency!
On Tue, Feb 21, 2017 at 12:26 PM, Cynthia Lin<EMAIL_ADDRESS>wrote:

@brockwhittaker https://github.com/brockwhittaker Yeah, I think I
should do some explaining on that..
A while ago I tried to log into the Zulip Mac app; however, upon doing so,
the navbar covered the entire screen, hiding all login elements and
preventing me from logging in. I later discovered it was because .header
.darker was set to 100%.
[image: desktop]
https://cloud.githubusercontent.com/assets/15116870/23183309/7b012c3c-f830-11e6-8321-96341225eeda.png
This is what the app looks like for me right now, and it's because .header
is set to 100% and I'm planning to change that soon.
Also, .header .stripes is 40px on my end, I'm not sure why it's showing
as 100% for you.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/zulip/zulip/pull/3722#issuecomment-281469525, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AJ199zRxf7tYg2czAn_tagIx5KapT5Kqks5re0hvgaJpZM4MFODx
.


Emitting event on model change

This is just for discussion.
Do components have to emit changes if the viewmodel changes.
As example
<md-checkbox [(ngModel)]="myValue">
If i check (using the mouse) the checkbox, it's normal to get an event emitted with the value of the change.
But if I fo progamatically do this.myValue = true; Do the checkbox have to emit an event?

+1 this is causing a bug for my when I attempt to implement hierarchical checkboxes.
checking all of the boxes causes the parent box to become checked, all good.
but unchecking a single box cases the parent box to become unchecked, which fires an event, which causes all of the boxes to become unchecked. not good, and also causes a devmode value changed after change detection exception.

@fringd should be fixed in checkbox in the latest release. The fix needs to make its way to other components. The gist is that controls should only fire a change event when they have focus. Closing this into #791


feat: Adding standard transformer keep alive & kafka configurations

Motivation
Recent change on standard transformer, introducing enable gRPC client keep alive and also publish prediction log. This PR adding the required helm chart changes to enable configuration change
Modification
Adding several environment variables
transformer.feast.grpc.keepAliveEnabled
transformer.feast.grpc.keepAliveTime
transformer.feast.grpc.keepAliveTimeout
transformer.model.grpc.keepAliveEnabled
transformer.model.grpc.keepAliveTime
transformer.model.grpc.keepAliveTimeout
transformer.kafka.brokers
transformer.kafka.maxMessageSize
pyfuncGRPCOptions

Checklist

[ ] Chart version bumped
[ ] README.md updated

@tiopramayudi You'll need to use helm-docs to generate README.md.

LGTM, can you rebase @tiopramayudi


Allow supabase stop

Feature request
Is your feature request related to a problem? Please describe.
I often run supabase start and in VS Code terminal and then I close VS Code at some point. This leaves all the containers running in the background. So next time I do supabase start I get Error: listen tcp4 :54321: bind: address already in use.
Describe the solution you'd like
Closing the terminal should stop the supabase containers gracefully (not sure if that's possible).
Describe alternatives you've considered
Otherwise it would be sufficient with a supabase stop command to stop the current containers - problem is that this might save state into supabase/.temp and supabase/.branches even though the containers might come from a different project?
Additional context
Currently I manually stop the containers with the following command
docker stop $(docker ps -aq --filter "name=supabase") && docker rm $(docker ps -aq --filter "name=supabase")

+1.
It might be a good idea to daemonize supabase start cli process. That way it wont lock the terminal. With supabase stop one can stop all the containers.

+1.
It might be a good idea to daemonize supabase start cli process. That way it wont lock the terminal. With supabase stop one can stop all the containers.

supabase stop would be enough for me.

+1
A nice addition to this request would be a command similar to firebase exec

Run the script at scriptpath after starting emulators for the Firebase products configured in firebase.json. Emulator processes will automatically stop when the script has finished running.

supabase stop is available now, and supabase start is detached and warns if an existing setup on the same project is already started :+1:

Thanks for adding this feature! Is there anyway to stop the supabase server using the cli? supabase stop doesn't just shut down the servers, it also wipes/reset all the data from the db. Yet, if I don't use supabase stop the servers never stop running on my machines.

Related: #150
The short term fix is to revert the old behavior (i.e. dump the db on supabase stop), but I'm currently rethinking the (scarcely documented) "branching" feature so that you dump the db on demand instead (as "snapshots").
I'm currently focused on other projects atm though, so if anyone is up for the fix, a PR would be appreciated!


Campaign | Teams: Remove from team

From the team edit popup team members can be removed from the team.

Prototype: https://www.figma.com/proto/7wE0Iveas3GGb8u4oL0714/App-Design-Mitglieder-App-(1)-(Copy)?node-id=2743-11128&t=b8swD5IOAFfZ0OSo-1
Pollion reference: https://github.com/pollion/sunflower-app/issues/96

Please clarify that this function is only available to team leads and not normal team members. @leagerndt @JuliaFreitagBGSt


API Gateway vendor extensions?

Is there any way to implement the Amazon API Gateway vendor extensions (x-amazon-apigateway*) easily for spec generation?
Basically I'm looking for a way to add custom vendor extensions.

at which stage?

or how are you using go-swagger :)

I have my paths being generated, but I need to be able to add the amazon extensions to them. Hopefully this example helps. If there is an easy way for me to add my own extensions that can be generated from comments, it would be awesome.
"paths": {
  "/": {
    "options": {
      stuff
    }
"x-amazon-apigateway-integration": {
  "requestTemplates": {
    "application/json": "{\"statusCode\": 200}"
  },
  "passthroughBehavior": "when_no_match",
  "responses": {
    "default": {
      "statusCode": "200",
      "responseParameters": {
        "method.response.header.Access-Control-Allow-Methods": "'OPTIONS'",
        "method.response.header.Access-Control-Allow-Headers": "'Content-Type,X-Amz-Date,Authorization,X-Api-Key,X-Amz-Security-Token'",
        "method.response.header.Access-Control-Allow-Origin": "'*'"
      }
    }
  },
  "type": "mock"
}

The extensions I need to add are these: http://docs.aws.amazon.com/apigateway/latest/developerguide/api-gateway-swagger-extensions.html

Is there anyway for me to easily integrate these extensions?

you could use a spec that gets merged in during the generation process, but other than that it would require changes to the scan package
A syntax has to be created and then added to the parsers here: https://github.com/go-swagger/go-swagger/blob/master/scan/routes.go#L199

Okay, I have a solution in the works, but I have another issue. AWS does not support response refs. Is there an easy way to make go-swagger put responses inline instead of as $refs?

Not easy it would involve making the strategy for setting responses on a route configurable
https://github.com/go-swagger/go-swagger/blob/master/scan/routes.go#L193
https://github.com/go-swagger/go-swagger/blob/master/scan/validators.go#L568-L595

@FryDay Were you able to get this through?


Periodic crash of a game while exploring the world

OTG Plugin or Mod

[x] OTG Mod for Forge
[ ] OTG Plugin for Spigot

OTG Version

[x] 1.12.2_v8_r1
[ ] 1.12.2_v7_DEV_r26
[ ] 1.12.2-v6
[ ] 1.12.2-v5
[ ] 1.11.2-v8
[ ] 1.11.2-v9
[ ] 1.10.2-v21
[ ] Other - specify here

Forge or Spigot Versions
Forge <IP_ADDRESS>68
Server/Client Log
latest.log
crash-2019-12-23_18.12.47-server.txt
What other plugins are you running?
Biome_Bundle-1.12.2-v6.1.jar
Description
Random crash during normal exploration of the world. Sometimes every few minutes, sometimes you need to play for about 30 minutes. I noticed that this happens during the generation of new chunks.

Hey @Tolans , thanks for reporting this. This is a known bug that we've not been able to reproduce in a development environment. See #269 ,


Apns: Drop binary API support

Since Apple no longer supports this option, neither should we.

Do you have some documentation from Apple about this because I've not idea what any of this means


Throw exception if plugin name contains whitespace

To address issues where plugin names are used but shouldn't contain spaces (e.g. permissions)

Will auto replace spaces with underscore.


@babel/core module not found when use plugin

Hi,
I meet the problem when using the babel preset. here is the code:
{
	"targets": "node > 20",
	"presets": ["@babel/preset-env", "transform-ui5", "@babel/preset-typescript"],
	"plugins": [],
	"sourceMaps": true,
	"ignore": [
		"**/*.d.ts"
	]
}

And when compile the code, it shows error:

Error: babel-plugin-transform-modules-ui5 tried to access @babel/core, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.

And I double confirmed the package, it already in the dependency in package.json file.
...
"devDependencies": {
        "@babel/core": "^7.25.2",
        "@babel/cli": "^7.24.8",
        "@babel/preset-env": "^7.25.3",
        "@babel/preset-typescript": "*",
        "@sapui5/types": "1.127.1",
        "@types/luxon": "^3.4.2",
        "@typescript-eslint/eslint-plugin": "^8.2.0",
        "@typescript-eslint/parser": "^8.2.0",
        "@ui5/cli": "^4.0.4",
        "@ui5/ts-interface-generator": "^0.8.3",
        "babel-preset-transform-ui5": "^7.6.0",
        "eslint": "^9.9.0",
        "typescript": "^5.5.4",
        "typescript-eslint": "^8.2.0"
    },
...

BTW, We use the yarn pnp mode as the package manager.

Hmm, good catch @coderjinhui
I think the dependencies aren't modelled properly. All dependencies are only devDependencies which isn't correct. Since we took over the plugin from Ryan Murphy who started the plugin, we never questioned the dependencies as it always worked. But in many cases, the project using the plugin had already defined the dependency to Babel. Could be also related to yarn which handles the devDeps a bit more strict.
We'll investigate! Thx for reporting...


Provide instructions for changing default datadir

On Windows:
Open the text file at %appdata%/Bitcoin/bitcoin.conf
Add or modify the datadir=D:\Bitcoin or whatever
Let me know if that’s confusing / doesn’t work, happy to help!

Alternatively  just use the Bitcoin Core client and access the configuration file via the menu: Settings > Options... > Wallet > Open Configuration File

Thanks @tooraj-enayati! I've added the ability to set the datadir straight from the Node Launcher


Import geocoding finished email

Closes #8933

CR @matallo

out of curiosity, why the change in the literal? apart from that 👍

I was just following the design files texts, but I can revert that change if you think that's better :)

it was just curiosity, whatever design thinks is best!

✨


⚠ Bofrost.be has degraded performance

In 049ee0d, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1527 ms

Resolved: Bofrost.be performance has improved in a9d814d.


Rewritten Internal React Code With Hooks

In this PR, I rewrote the React part with hooks.
Close #53
Close #42

@wittydeveloper  Any update on this❓

I published a 1.0.0-1 version to test it on codesandbox and there is some backward compat issues: https://codesandbox.io/s/frontier-with-hooks-qefro
I'm gonna take a look soon

Sorry to bump this, but just checking in again to see if there's any update on this?

Hi @neiljohari,
This project needs a good refactoring in order to move forward.
I will benchmark the competitions (react-hook-form, Formik, etc) to see how Frontier can evolve ✨


Unified Kuadrant Single Cluster - Eng Enhacements

What
Some additional eng focusd enhancements around single cluster Kaudrant support

[ ] #622
[ ] https://github.com/Kuadrant/multicluster-gateway-controller/issues/661

removing in favour of  https://github.com/Kuadrant/architecture/issues/44

duplicate of above


Add a section regarding the start notebook

The current docs are lacking.
The following breaks.

Create notebook and start for the first time, all is well.
Stop Notebook.
Start Notebook.
Try to run notebook with any kernel attached.
Fail :
" from fastai import *"
ModuleNotFoundError: No module named 'fastai'

This solves the issue.
TESTED restarted notebook, verified that this works and is broken without this.

Yes, I am sure,
But I could not get the "Python 3" kernel on subsequent reruns.
it just worked on the first run of a notebook.
(i've made 3 new notebooks to test this. )
when a notebook is stopped and then restarted, that kernel (fastai aliased as "Python 3") doesn't exist. (for me. )
Can someone please contradict me.

setup a notebook as described.
run the first 2 cells (past the imports) see that it works
stop the notebook
start the notebook
run the first two cells past the import statements.

if you already have the notebook set up, step 3 is 5 minutes, step 4 is 5 minutes, step 5 is 3 seconds.

Many thanks - this is great. We will have a better solution to this soon, but this is a great interim fix. :)


Test import system test with different file sizes

When we verifying that objects have their correct length, we should use size power of 2 or a multiple of 8.
Some bugs are found when reading blocks are to read the wrong length if the length is not a multiple of 8 (prefer a length like 1357 or similar)

@nopcoder is this closed?

no, it is something we would like to improve.


Can not set --target-platform for locally-built engine

Steps to Reproduce

Compile the engine by following the wiki https://github.com/flutter/flutter/wiki/Compiling-the-engine

Run the following command:

flutter build aar \
    --target-platform android-arm,android-arm64,android-x64
    --local-engine-src-path <my local engine path>/engine/src \
    --local-engine=android_debug_unopt \
    --no-profile --no-release -v

No matter what I set for the --target-platform, the target platform will always android-arm for my command above.
After I read the source code of flutter_tools, I found that it only get the target platform according the local engine path.
https://github.com/flutter/flutter/blob/707f995de35bdf887169fcd39448b877cbcc8992/packages/flutter_tools/lib/src/android/gradle.dart#L622-L623

You can only use the target-platform provided by the locally built engine - if you need a different target-platform you need to build a different engine variant.

drwx------   35 littlegnal  staff      1120 Aug 25 15:32 android_debug_unopt
drwx------   35 littlegnal  staff      1120 Aug 25 15:32 android_debug_unopt_arm64
drwx------   35 littlegnal  staff      1120 Aug 25 15:32 android_debug_unopt_x64
drwx------    6 littlegnal  staff       192 Aug 17 00:52 android_debug_unopt_x86
drwx------   35 littlegnal  staff      1120 Aug 25 15:32 android_profile
drwx------   34 littlegnal  staff      1088 Aug 25 15:32 android_profile_arm64
drwx------   34 littlegnal  staff      1088 Aug 25 15:32 android_profile_x64
drwx------   35 littlegnal  staff      1120 Aug 25 15:32 android_release
drwx------   33 littlegnal  staff      1056 Aug 25 15:32 android_release_arm64
drwx------   33 littlegnal  staff      1056 Aug 25 15:32 android_release_x64
-rw-r--r--    1 littlegnal  staff  15571309 Aug 25 17:36 compile_commands.json
drwx------   80 littlegnal  staff      2560 Aug 25 15:32 host_debug_unopt
drwx------   73 littlegnal  staff      2336 Aug 25 17:50 host_debug_unopt_arm64
drwx------   73 littlegnal  staff      2336 Aug 25 18:05 host_debug_unopt_x64
drwx------  477 littlegnal  staff     15264 Aug 25 15:32 host_profile
drwx------   80 littlegnal  staff      2560 Aug 25 15:32 host_release

I have built different engine variants, it possible to set multiple target-platform to one build command?
If not, one AAR can only use in a single target-platform.

No, its not supported

@jonahwilliams
Can this issue be closed?
Thank you

@littleGnAl my recommendation would be to create different outputs AARs per target platform and then merge them with something like https://stackoverflow.com/questions/54949399/how-to-merge-combine-two-aar-files

@jonahwilliams Thank you.

@littleGnAl
given your last message I feel safe to close this issue, if you disagree please write in the comments and I will reopen it.
Thank you

@TahaTesser Yes, it's okay to close, thank you(I don't know why the bot reopens it...).
@jonahwilliams Btw, I found that it can package all local engines together as a single out/xx/Flutter.framework and replace $FRAMEWORK_PATH/bin/cache/artifacts/engine/ios-xx/ folder on iOS(https://github.com/flutter/flutter/issues/61045#issuecomment-668278475), is there a similar way in Android like that(maybe this has out of the topic of this issue)?


set parameters which guarantee all tests pass

appears n=16 is necessary for tests to pass

(n = 16, q =<PHONE_NUMBER>, t = 1024) sometimes passes, sometimes fails

it looks like with $q$ set this high, we're going to have $q^2 \approx 2^{60}$, which is close to the i64 max of $\approx 2^{64}$.
---- test::tests::test_hom_prod stdout ----
thread 'test::tests::test_hom_prod' panicked at /Users/jacksonwalters/.cargo/registry/src/index.crates.io-6f17d22bba15001f/polynomial-ring-0.5.0/src/ops.rs:102:9:
attempt to add with overflow
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

so it's really just line 55 in lib.rs, which is polymul:
let mut r = x*y;
This multiplication of polynomials occurs first, and afterwards we reduce modulo q. This causes an overflow for large values of q.

for now, the largest set of parameters that seem to pass are $n = 16, q =<PHONE_NUMBER>, t = 512$.

one thing to note is that with q fixed, increasing t by powers of 2 causes the error to increase by powers of 2. so the constant term will be correct (= 6) but you'll get other terms either zero or say 16. If you increase t by a power of 2, you'll get e.g. [6,...,0,...,32,32,0,32,...,0,0,...,32]. This also holds for non-powers of 2, say primes q, t where you get some small constant error term or zero.


composition of hierarchical samplers

Based on the compositional-hierarchical samplers in the book https://link.springer.com/book/10.1007/978-3-319-63113-4 we should be able to use undirected wiring diagrams to compose (i.e. black box combine) samplers for semi-Markov processes.
For the first proof of concept cases, we should consider models where observables and physical state are the same, and that they alone are sufficient to compute the hazards. That is, Markov processes. It's possible semi-Markov processes complicate things a bit, and multiple types of junction and port would be needed, but we can kick that can down the road.

The key thing here is we don't really need to know how probability in semi-Markov processes works categorically in order to be able to compose simulators (samplers) categorically, via operad algebras. This is the pragmatic approach taken in AlgebraicDynamics.jl. Although we do know how to talk about classic dynamical systems categorically, from the perspective of composition, we use UWDs to set up a vectorfield, and then pass it off to numerical solvers for computing trajectories. The composition is what's helpful for scientists and engineers dealing with complex systems.
Unorganized thoughts:

A system is a box of a UWD. We don't know how many counting processes it contains, but at least one. In the most general case it exposes at least 3 ports (of different types?):

one of them is the either the time of next firing if this system fires first or the total hazard rate of all processes in the box
one is it's filtration (or some subset of it)
one is stuff that affects shared state (need to think about this more)

Hi Sean! The book you referenced is the most up-to-date account of what samplers are efficient. Excellent book.
Samplers are composable, as you suggest. The rough rule is that direct samplers can contain direct samplers and first-to-fire samplers can contain any samplers. I just implemented a "multiple-direct" sampler to show how that works for direct methods, and there is already a MultiSampler that can contain other samplers. The main challenge with all of these is how to match a given transition (clock) with a particular sampler in the hierarchy. That isn't often discussed, I think, because it's usually done with ad-hoc code.
I suspect your goal isn't to compose samplers but to compose models, where each model has state and a sampler. We should make an example. The challenge will be merging the identifiers for clocks. If the space of clock ids is separate, they could merge directly. If not, you would want to embed them in a larger space. It's very much a math problem, and the code would follow.

Right, "sampler" is really language for "model" here. Basically I have been wanting to generalize the sort of compositional modeling via operad algebras as demonstrated in AlgebraicDynamics.jl to stochastic systems. It would basically follow the same undirected wiring diagram schema as in that package, but potentially we need to additionally allow for "read only" wires for non mass action terms.
Came down with a slight cold, once I recover, need to devote more brain clock cycles to this.