[documentation] Add Redis to the TCP traffic that needs to be excluded

This page mentions MySQL and SMTP as examples of TCP protocols which aren't properly handled by Conduit.
It would be worth adding Redis to this list, as it too needs to be excluded from Conduit proxied ports.

Is Redis a server-speaks-first protocol like MySQL and SMTP? If so, then we already know the most-likely cause of this and we should just update the documentation for 0.3.1. Our goal is to make this kind of configuration unnecessary for server-speaks-first protocols in 0.4; see #339.
If, however, the Redis protocol isn't a server-speaks-first protocol then this is a different problem and we need to do some debugging to find out what Redis isn't working transparently already.

I think we may have to do debugging to verify what redis actually does when it first gets in contact with a peer. According to https://redis.io/topics/protocol, Redis is generally a request-response protocol, meaning that the client sends packets first. However, you could use redis in Pub/Sub model and this may be an issue that a proxy that might run into. Check out this quote from their documentation.

When a Redis client subscribes to a Pub/Sub channel, the protocol changes semantics and becomes a push protocol, that is, the client no longer requires to send commands, because the server will automatically send to the client new messages (for the channels the client is subscribed to) as soon as they are received.

This sounds like this may be a server-speaks-first protocol. But we can't be certain until we have a good test to confirm that.

UPDATE: Working with @pcalcado to see if we can come to any definite conclusions about Redis through some tests possibly tomorrow.

After running a few tests, we have seen that conduit transparently routes requests through a redis deployment using both Pub/Sub and Request-Response communication patterns. The caveat is that we do not record telemetry for raw TCP which makes it difficult to observe how traffic is flowing through a Redis instance. @bourquep I am curious to know what you see when you inject conduit into a redis environment. Do requests that are targeted for redis hang indefinitely?

@deebo91 What triggered this for me is I started seeing a ton of connection refused errors in my NodeJS service that uses Redis, shortly after injecting conduit into that deployment. I immediately reinjected with Redis port skipped, but did not do any further forensics unfortunately.
It might have been a side effect of the TCP port leaks (see other issue for which I don’t have the number at hand). I’ll check my Redis logs to see if the number of active connections skyrocketed on that specific date and time.

Nope, no spike in Redis connections when I saw this error spike.
Could it be related to the fact that my Redis server is running outside of the k8s cluster and accessed by DNS name?
Anyhow, I had never had this connection error before injecting Conduit, and it went away after skipping the Redis port.

Could it be related to the fact that my Redis server is running outside of the k8s cluster and accessed by DNS name?

How many labels does the DNS name have? e.g. "example.com" has two labels, "www.example.com" has three labels, and "foo.bar.example.com" has four labels. If the service had less than two labels in its DNS name, could you try one that has at least 3?

By "accessed by a DNS name" do you mean that  you did NOT create an Kubernetes service with type = ExternalName for it?

How many labels does the DNS name have?

It has 4 labels.

By "accessed by a DNS name" do you mean that you did NOT create an Kubernetes service with type = ExternalName for it?

Exactly, no k8s service involved. Should I try that?

Exactly, no k8s service involved. Should I try that?

No, ExternalName services won't be supported until #155 is fully fixed. Similarly, if there were only 1 or 2 labels then that isn't expected to work either. However, the configuration you gave should already be working, w.r.t. the being able to contact things outside the cluster.

However, the configuration you gave should already be working, w.r.t. the being able to contact things outside the cluster.

@briansmith does your comment above suggest that this is a bug not related to #155? We could run tests by having an external redis client and try to communicate from a proxy-enabled client from within k8s.

@dadjeibaah At this point I don't think we can blame #155 for this.
I feel like we don't really know what's going on here. It's very possible that this is something Redis-specific but based on @dadjeibaah's testing we can't reproduce it, so it apparently doesn't affect all redis deployments, so I don't think we should just slap a "disable the proxy for Redis" into the docs just yet. We need to find STR.
@bourquep Which version of Redis are you using? Which software was the client and which software was the server? Thanks!

Since we designed the test to accept any redis server, whether it be external or internal to k8s, it is pretty easy to setup a test with an external redis server. I can set that up and see what I find.

FWIW, I looked at https://redis.io/topics/protocol and it doesn't appear to be a server-speaks-first protocol. I did notice that the messages that the client sends to the server might be small. That reminded me of https://github.com/runconduit/conduit/pull/231 (thanks for the link, @seanmonstar). Thus, the issue might be an issue in our protocol-detection logic: maybe we're too eager to assume a connection is an HTTP connection when really it might be a Redis connection.

Let's write a unit test in the proxy where we attempt to send (outbound) the minimal Redis message that a Redis client might send at the beginning of a connection, and see if the protocol detection logic (etc.) is doing the right thing.

@briansmith:

Which version of Redis are you using? Which software was the client and which software was the server?

Server: Redis v3.0.6 (one instance, no replication)
Client: ioredis v2.4.0 (npm package) running on NodeJS v6

Also, and I am terribly sorry for having misreported this earlier, we are not accessing the Redis server via DNS name but rather via it's internal Google Compute Engine IP address (redis://10.x.0.x). We used to access it via DNS name but changed the connection string to point to its internal IP later on, and I had completely forgotten about that. 😩

@bourquep Thanks for those additional details!

@bourquep Thanks again for the additional details. I think what we need to do now is try to reproduce specifically with ioredis. In particular, it seems like if ioredis is using the normal Redis protocol then Conduit's protocol detection logic shouldn't confuse it with HTTP traffic, and so any problem you experienced wouldn't be related to protocol detection. However, if it is using the human-oriented form of the Redis protocol then it might be confusing it with HTTP traffic, because the human-oriented form of the Redis protocol does look quite a bit like HTTP. So we should try to find a tcpdump from ioredis 2.4.0 connecting to a Redis server to make progress.

Something we could also do is add a trace log of the bytes when protocol detection completes, to allow debugging.
A downside is whether there is concern of dumping possibly sensitive bytes into the logs.

I can also setup a NodeJS client that talks to Redis. I currently have a test environment but the client is in go. I can try seeing if I can get tcdumps in my test env.

Digging through the source of ioredis 2.4.0, it seems it is using a protocol that does not look like HTTP: https://github.com/luin/ioredis/blob/v2.4.0/lib/command.js#L146
That means commands look like:
*2
$4
LLEN
$6
mylist

The current protocol detector will notice it isn't the HTTP2 preface, and that *2\r\n is not a valid HTTP1 request line, and so should treat as opaque TCP.

Now that I have 0.3.1 running in prod, I can test this again in a more controlled manner. I'm skipping the Redis outbound port in all my proxy injections right now, but I'll let it go through the proxy for one of my deployments which accesses Redis and monitor the logs more closely.
I should be able to do that early next week.

Hey @bourquep, any update on testing your deployments that access Redis? I tested this with Conduit v0.4.1 and it seemed to work without requiring the --skip-outbound-ports flag.

Yes indeed, haven't had any problem with accessing Redis through Conduit since I-don't-remember-which-release. :)

On May 29, 2018, at 19:17, Kevin Lingerfelt<EMAIL_ADDRESS>wrote:
Hey @bourquep https://github.com/bourquep, any update on testing your deployments that access Redis? I tested this with Conduit v0.4.1 and it seemed to work without requiring the --skip-outbound-ports flag.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/runconduit/conduit/issues/432#issuecomment-392978411, or mute the thread https://github.com/notifications/unsubscribe-auth/AAD-SF6e70Ytfijx27GJq0YExn66uBVjks5t3dcagaJpZM4SQXDD.

@bourquep 🎉 🎉 🎉 Thanks! Am going to close this.


[wip] deprecate passing ModelCheckpoint instance to Trainer(checkpoint_callback=...) [skip ci]

What does this PR do?
Pitch: Deprecate passing ModelCheckpoint instance directly to checkpoint_callbacks argument. Allow only bool.
FAQ
Q: Why can we not just remove the checkpoint_callback argument all together?
A: Lightning philosophy is to provide good defaults, this includes checkpointing. We need a way to turn it off though, i.e., checkpoint_callback=False
Q: Why can't we keep it the way it is?
A: When we add Trainer(checkpoint_callback=mycustomcallback), internally Trainer adds it to self.callbacks.
A problem arises when we reload the Trainer using resume_from_checkpoint="...". In this case, we would end up with a conflict and a decision needs to be made: Do we load the callback that was saved in the checkpoint, or do we overwrite it with the one that is passed in to Trainer. We can try to handle this case and make the decision for the user (#4027) or we go with this PR here to remove the ambiguity alltogether.
Alternatives

Drop checkpoint_callback. This implies no default checkpointing.
Suggestion by @jeremyjordan: Remove checkpoint_callback and if trainer.callbacks is empty, add a ModelCheckpoint automatically. If any other callbacks need to be passed in, we need to supply a ModelCheckpoint manually.
Keep as is, go with #4027 for the fix, document well the behaviour when resuming from checkpoint.

TODOs for this PR:

[ ] update docs
[ ] how to deal with Tuner? (see deleted lines)

Closes #3990
Closes #4027
Related to #4335, as it is a good step in to the direction of allowing multiple model checkpoints.

Hello @awaelchli! Thanks for updating this PR.

In the file tests/checkpointing/test_model_checkpoint.py:

Line 790:1: W391 blank line at end of file

@williamFalcon @teddykoker remove ambiguity by making checkpoint_callback boolean. sg?

I propose to update docs in a follow up PR, otherwise it will a bit too much to review at once.

@s-rog Yes correct. I have already updated these docs you mention on another branch, which will follow up to this. I didn't want to make the PR too big, so keeping it separate.


resolve flake (#5877)

Pull request opened by the merge tool on behalf of #5877

Merged in 8f40a057677e9536c11aea791e512eaf22949bda


Add functionality to increment a b256

Description
The Sway language does not currently support any mathematical operations on a b256. Fuel core v0.19 support will add the WQOP op code for add, sub, shifts, etc but until then an increment by u64 function may be implemented.
https://github.com/FuelLabs/fuel-specs/blob/master/src/fuel-vm/instruction-set.md#wqop-misc-256-bit-integer-operations
Motivation
This functionality is required to optimize storage read/write operations.

Closing in favor of https://github.com/FuelLabs/sway/issues/4790


cannot satisfy dependencies

I'm stuck on to this step
$ stack install --dependencies-only

Error: While constructing the build plan, the following exceptions were encountered:

In the dependencies for gi-gdkx11-<IP_ADDRESS>:
    gi-gdk-3.0.14 must match >=<IP_ADDRESS> && <0.3.23
    gi-gio-2.0.14 must match >=<IP_ADDRESS> && <0.2.53
    gi-gobject-2.0.14 must match >=<IP_ADDRESS> && <0.2.53
needed since gi-gdkx11-<IP_ADDRESS> is a build target.

Plan construction failed.

Tried to do stack install gi-gdk gi-gio gi-gobject, but no difference.
Any ideas?

Hello.
Try this sequence instead.
cd movie-monad/
stack clean
stack setup
stack install haskell-gi
haskell-gi -o lib/gi-gdkx11/GdkX11.overrides -O lib/gi-gdkx11 GdkX11-3.0
haskell-gi -o lib/gi-xlib/xlib.overrides     -O lib/gi-xlib xlib
stack install --dependencies-only
stack build
stack install
stack exec -- movie-monad

:+1:

Thanks for the help.
Unfortunately, I get the same error again. :/

What is the output of stack solver?

$ stack solver
Using configuration file: stack.yaml
Using cabal packages:
- movie-monad.cabal
- lib/gi-gdkx11/gi-gdkx11.cabal
- lib/gi-xlib/gi-xlib.cabal

Using resolver: lts-9.1
Using compiler: ghc-8.0.2
Asking cabal to calculate a build plan...
Trying with packages from lts-9.1 and 4 external packages as hard constraints...
Attempt failed.

>>>> Cabal errors begin
cabal: Could not resolve dependencies:
next goal: gi-gobject (dependency of movie-monad-<IP_ADDRESS>)
rejecting: gi-gobject-2.0.15 (constraint from main config
/tmp/cabal-solver10928/cabal.config requires ==2.0.14)
trying: gi-gobject-2.0.14
next goal: gi-gdkx11 (user goal)
rejecting: gi-gdkx11-<IP_ADDRESS> (conflict: gi-gobject==2.0.14, gi-gdkx11 =>
gi-gobject>=<IP_ADDRESS> && <0.2.53)
Dependency tree exhaustively searched.
<<<< Cabal errors end

Retrying with packages from lts-9.1 and 4 external packages as preferences...
Attempt failed.

>>>> Cabal errors begin
cabal: Could not resolve dependencies:
trying: gi-gdkx11-<IP_ADDRESS> (user goal)
next goal: gi-gio (dependency of gi-gdkx11-<IP_ADDRESS>)
rejecting: gi-gio-2.0.14, gi-gio-2.0.13, gi-gio-2.0.12, gi-gio-2.0.11,
gi-gio-2.0.10, gi-gio-2.0.9, gi-gio-2.0.8, gi-gio-2.0.7, gi-gio-2.0.6,
gi-gio-2.0.5, gi-gio-2.0.4, gi-gio-2.0.3, gi-gio-2.0.2, gi-gio-2.0.1,
gi-gio-<IP_ADDRESS>, gi-gio-<IP_ADDRESS>, gi-gio-<IP_ADDRESS>, gi-gio-<IP_ADDRESS>,
gi-gio-<IP_ADDRESS>, gi-gio-<IP_ADDRESS>, gi-gio-<IP_ADDRESS>, gi-gio-<IP_ADDRESS>,
gi-gio-<IP_ADDRESS>, gi-gio-<IP_ADDRESS> (conflict: gi-gdkx11 => gi-gio>=<IP_ADDRESS> &&
<0.2.53)
Dependency tree exhaustively searched.
<<<< Cabal errors end

*** Failed to arrive at a workable build plan.

Solver could not resolve package dependencies.
You can try the following:
    - Update external packages with 'stack update' and try again.
    - Tweak stack.yaml and try again
        - Remove any unnecessary packages.
        - Add any missing remote packages.
        - Add extra dependencies to guide solver.
        - Adjust resolver.

Here are the contents of my three cabal files.
movie-monad.cabal
name:                 movie-monad
version:              <IP_ADDRESS>
synopsis:             Plays videos using GStreamer and GTK+.
description:          Desktop video player that uses GStreamer and GTK+.
homepage:             https://github.com/lettier/movie-monad
license:              BSD3
license-file:         LICENSE
author:               Lettier
maintainer:           Lettier
copyright:            2017 David Lettier
category:               Multimedia
                      , Multimedia Player
                      , Video
build-type:           Simple
cabal-version:        >=1.10
extra-source-files:     README.md
                      , LICENSE
                      , ./src/dev/Paths_movie_monad.hs
                      , ./src/data/gui.glade
data-files:           data/gui.glade
data-dir:             ./src/

source-repository     head
  type:               git
  location:           https://github.com/lettier/gifcurry.git

executable            movie-monad
  main-is:              Main.hs
  default-language:     Haskell2010
  build-depends:        base >= 4.7 && < 5
                      , text == 1.2.*
                      , process == 1.4.*
                      , MissingH == 1.4.*
                      , haskell-gi-base == 0.20.*
                      , gi-gobject == 2.0.*
                      , gi-gst == 1.0.*
                      , gi-gtk == 3.0.*
                      , gi-glib == 2.0.*
                      , gi-xlib == 0.1.6.*
                      , gi-gstvideo == 1.0.*
                      , gi-gdkx11 == 0.3.*
  ghc-options:        -threaded -with-rtsopts=-N -Wall
  other-modules:      Paths_movie_monad
  hs-source-dirs:     ./src/

gi-gdkx11.cabal
-- Autogenerated, do not edit.
name:               gi-gdkx11
version:            <IP_ADDRESS>
synopsis:           GdkX11 bindings
description:        Bindings for GdkX11, autogenerated by haskell-gi.
homepage:           https://github.com/haskell-gi/haskell-gi
license:            LGPL-2.1
license-file:       LICENSE
author:             Will Thompson, Iñaki García Etxebarria and Jonas Platte
maintainer:         Iñaki García Etxebarria<EMAIL_ADDRESS>category:           Bindings
build-type:         Simple
cabal-version:      >=1.10

library
    default-language:   Haskell2010
    default-extensions: NoImplicitPrelude, ScopedTypeVariables, CPP, OverloadedStrings, NegativeLiterals, ConstraintKinds, TypeFamilies, MultiParamTypeClasses, KindSignatures, FlexibleInstances, UndecidableInstances, DataKinds, FlexibleContexts
    other-extensions:   PatternSynonyms, ViewPatterns
    ghc-options:        -fno-warn-unused-imports -fno-warn-warnings-deprecations
    exposed-modules:    GI.GdkX11
                        GI.GdkX11.Functions
                        GI.GdkX11.Objects
                        GI.GdkX11.Objects.X11AppLaunchContext
                        GI.GdkX11.Objects.X11Cursor
                        GI.GdkX11.Objects.X11DeviceCore
                        GI.GdkX11.Objects.X11DeviceManagerCore
                        GI.GdkX11.Objects.X11DeviceManagerXI2
                        GI.GdkX11.Objects.X11DeviceXI2
                        GI.GdkX11.Objects.X11Display
                        GI.GdkX11.Objects.X11DisplayManager
                        GI.GdkX11.Objects.X11DragContext
                        GI.GdkX11.Objects.X11Keymap
                        GI.GdkX11.Objects.X11Screen
                        GI.GdkX11.Objects.X11Visual
                        GI.GdkX11.Objects.X11Window
    pkgconfig-depends:  gdk-x11-3.0 >= 3.22
    build-depends:
        haskell-gi-base >= 0.20 && < 1,
        gi-gobject == 2.0.*,
        gi-gdk == 3.0.*,
        gi-gio == 2.0.*,
        gi-xlib >= <IP_ADDRESS> && < 0.1.7,
        bytestring >= 0.10 && < 1,
        containers >= 0.5 && < 1,
        text >= 1.0 && < 2,
        transformers >= 0.4 && < 1,
        base >= 4.7 && <5

gi-xlib.cabal
name:               gi-xlib
version:            <IP_ADDRESS>
synopsis:           xlib bindings
description:        Bindings for xlib, autogenerated by haskell-gi.
homepage:           https://github.com/haskell-gi/haskell-gi
license:            LGPL-2.1
license-file:       LICENSE
author:             Will Thompson, Iñaki García Etxebarria and Jonas Platte
maintainer:         Iñaki García Etxebarria<EMAIL_ADDRESS>category:           Bindings
build-type:         Simple
cabal-version:      >=1.10

library
    default-language:   Haskell2010
    default-extensions: NoImplicitPrelude, ScopedTypeVariables, CPP, OverloadedStrings, NegativeLiterals, ConstraintKinds, TypeFamilies, MultiParamTypeClasses, KindSignatures, FlexibleInstances, UndecidableInstances, DataKinds, FlexibleContexts
    other-extensions:   PatternSynonyms, ViewPatterns
    ghc-options:        -fno-warn-unused-imports -fno-warn-warnings-deprecations
    exposed-modules:    GI.Xlib
                        GI.Xlib.Functions
                        GI.Xlib.Structs
                        GI.Xlib.Structs.Display
                        GI.Xlib.Structs.Screen
                        GI.Xlib.Structs.Visual
                        GI.Xlib.Structs.XConfigureEvent
                        GI.Xlib.Structs.XFontStruct
                        GI.Xlib.Structs.XImage
                        GI.Xlib.Structs.XTrapezoid
                        GI.Xlib.Structs.XVisualInfo
                        GI.Xlib.Structs.XWindowAttributes
                        GI.Xlib.Unions
                        GI.Xlib.Unions.XEvent
    pkgconfig-depends:  x11 >= 1.6
    build-depends:
        haskell-gi-base >= 0.20 && < 1,
        bytestring >= 0.10 && < 1,
        containers >= 0.5 && < 1,
        text >= 1.0 && < 2,
        transformers >= 0.4 && < 1,
        base >= 4.7 && <5

Do these match up with yours?

I just cloned the repo, installed "haskell-gi" and run the commands from the tutorial.
I didn't mess with any cabal file. But I'll check to see.

I think only gi-gdkx11.cabal is slightly different
$ diff gi-gdk.cabal.1 ./lib/gi-gdkx11/gi-gdkx11.cabal
39,41c39,41
<         gi-gobject == 2.0.*,
<         gi-gdk == 3.0.*,
<         gi-gio == 2.0.*,
---
>         gi-gobject >= <IP_ADDRESS> && < 0.2.53,
>         gi-gdk >= <IP_ADDRESS> && < 0.3.23,
>         gi-gio >= <IP_ADDRESS> && < 0.2.53,

haskell-gi must have overwritten my cabal file.
Try building the project with my gi-gdkx11.cabal.

Works perfect, thanks.
One thing I instantly noticed, in VLC seeking index is terrible, takes 2-3 secs to move to a different segment of the video.
With movie-monad is instant!! It's great.
( btw, can I switch to full-screen? and change subtitles? )
Thanks for your work!

Thank you @AntouanK.
No subtitle feature as of yet.
No full-screen yet but for now I maximize the window and set the width setting to match the width of my screen.
:+1:

Ok, hopefully you'll get those in as well :)
I'm a Haskell beginner so unfortunately I cannot contribute to this.
Thank you though.

Hello @AntouanK. The master branch now contains fullscreen mode. The fullscreen button will show up alongside the width selector once you choose a video file.
Also, if you like, you can install Movie Monad via Cabal now.
cabal update
cabal install movie-monad

:+1:

@lettier Great! The seeking bar at the bottom is not hidden though and it's over part of the video. Is that normal?
Also, I tried a UHD video ( it says 2160p.BluRay.x265.10bit.HDR in the title ) and it's playing frame by frame.
Could it be some decoder missing on my side?

Hello @AntouanK.
I will hide the bottom controls if in fullscreen mode and the mouse is still. Testing that out right now.
Not sure about the UHD video. Does it occur in other media players?

@lettier Yes, the UHD is also too slow with other players. So ignore that.
Just wondering, is it hard to add support for opening streaming videos, like an .m3u file or the URL directly?

Hello @AntouanK.
Should not be too hard. I will look into it. :+1:

Hello @AntouanK.
I have added support or URL (HTTP/HTTPS) video files. It is in master. :+1:

@lettier Many thanks.
I will test it as soon as I can.


Google Cloud Storage Adapter

Closes appwrite/appwrite#3994

Please sync your branch with main . It has fixes for the failing CI tests

Thank you so much for the PR 🤩. We're adding the hacktoberfest-accepted label to ensure this PR counts towards your Hacktoberfest contributions count. With that said, please stay active on this PR to address any comments once you receive a review. Happy Hacktoberfest! 🎃

@eigengravy is this PR ready for review? Also, would you be able to provide some screenshots of the adapter working?

no, i haven't gotten the adapter working yet.

@eigengravy closing the PR for now. Feel free to reopen it when you're ready to work on it again


Can't use corrscope at all

To Reproduce

Open corrscope and add any WAVE file(s) (any amount of channels)
Click on 'Preview' or 'Render to Video'

Expected behavior
The program works as intended: shows a preview or renders a video.
Actual behavior
Traceback (most recent call last):
  File "corrscope\gui\__init__.py", line 750, in run
  File "corrscope\corrscope.py", line 242, in play
  File "corrscope\corrscope.py", line 207, in _load_channels
  File "corrscope\corrscope.py", line 208, in <listcomp>
  File "corrscope\channel.py", line 79, in __init__
  File "corrscope\wave.py", line 150, in __init__
  File "corrscope\utils\scipy\wavfile.py", line 690, in read
  File "corrscope\utils\scipy\wavfile.py", line 485, in _read_data_chunk
ValueError: mmap=True not compatible with 3-byte container size.

Version

OS: Windows NT 6.1
Corrscope version: 0.8.1
How you installed corrscope: official Windows binaries (x64) from https://github.com/corrscope/corrscope/releases/tag/0.8.1
How you obtained FFmpeg: official Windows binaries from https://ffmpeg.org

Additional context
ffmpeg is not in %PATH%.

Never mind, the WAVE files were 32-bit 48 kHz for some reason. Converting them to 16-bit 44.1 kHz solved the problem.


Navbar profile dropdown menu in Figma

E-builder submission: https://app.clickup.com/t/8684tb8y1

@soniakaukonen is there any mockup/prototype for what should be inside the profile dropdown?


capture contact details on the database to be used in recordgeojson output

Overview
This is a suggestion on how contact details can be captured on pycsw database, so they can be used on ogc-api-records.
It maps also topiccategory and otherconstraints to geojsonrecord properties (license and theme)
Related Issue / Discussion
#806
Additional Information
a new field 'contacts' has been added to the pycsw database
Contributions and Licensing

[x] I'd like to contribute this feature to pycsw. I confirm that my contributions to pycsw will be compatible with the pycsw license guidelines at the time of contribution.

Thank you @pvgenuchten for the PR.
I would prefer if we avoid adding jsons as a new dependency.

We need to test if the new field is populated properly when importing ISO-19115 XML

We need to test if the new field is populated properly when importing ISO-19115 XML

I tested for iso, but not for others like dc

nice, this got merged, thanx for reviewing!


Liquidate feature (Sell at margin)

I think a great feature - considering most of the time we aren't watching the telegram terminal etc. Would be to enable a liquidate for a particular market when the margin reaches a certain level.
E.g you have had a trade open for 5 days which just seems to be ranging and never really getting to the point of selling. You could liquidate this manually - but perhaps you know / feel that the margin may go up to 2% which wont trigger a buy or stop loss, but you would like out of the trade went that happens.
A feature where you could use telegram etc to liquidate when the margin level on the open trade / market next gets to X would be very handy.
In the telegram bot:
_**/liquidate
Which exchange?
Coinbasepro etc....
What market?
BTC-GBP
Liquidate at margin %?
4
Great, your open positions in this market will be liquidated when the margin next gets to 4% or a sell signal whichever is sooner.**_
Could this be added in the next release? It would come in very handy.

I am developing this in the end - will send through a PR for inclusion in the main code base on completion.


Set more specific plugin description.

Not that it's not the best Grunt plugin ever, I just think you could be more specific :).

:laughing: !!!


The user is logged out when the app is killed

Hi,
From my experience, when a user was logged in and then the application is killed (I kill it with Xcode, but it could be killed by iOS), then when the application restarts, the user is not logged in anymore.
This is annoying, since users have to enter their password again regularly. *
I know that this can be worked around using OAuth, but the default behaviour should be that the user remains logged in until logout() is called.

particularly in our situation: we're developing a POS, and this requires that every seller know the password of the SumUp account.

Hi Ceroce.
Thanks for your suggestion. I would assume the users credentials are persisted in the keychain and don't have to be entered manually again.
However I agree that it makes sense to keep the merchant logged in until you explicitly call logout(), especially in a multi-waiter scenario where a single SumUp account is shared.
For the time being OAuth is indeed the best way to achieve what you outlined.
We'll bring it up in one of our upcoming plannings.
Regards,
Lukas

Hi Lukas,
Any update on this? It is still the case and I would like the functionality as well.


Licenses

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring project ':app'.
> You have not accepted the license agreements of the following SDK components:
  [Android SDK Platform 26, Android SDK Build-Tools 26.0.2].
  Before building your project, you need to accept the license agreements and complete the installation of the missing components using the Android Studio SDK Manager.
  Alternatively, to learn how to transfer the license agreements from one workstation to another, go to http://d.android.com/r/studio-ui/export-licenses.html

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

* Get more help at https://help.gradle.org

I just pushed an update to Github and DockerHub to resolve the licenses issue.
We can now use RUN yes | sdkmanager --licenses to accept all licenses. This should be future proof.
I also updated the platform and build-tools version.


cherry-pick add function regexp_extract_or_null

Proposed changes
pick https://github.com/apache/doris/pull/38296

run buildall

run buildall


comp_type in write_cmblock

Hey,
function write_cmblock() in archive.py isn't up to date. In the if-statement (line 626):
if comp_type.upper() not in ['ELEMENT', 'NODE']
ELEMENT has to be changed to ELEM.
Best regards
Andreas

According to the Ansys Programmer's guide (as of 2021R2):
3.2.5. CMBLOCK Command
CMBLOCK defines the entities contained in a node or element component. The command format in

CMBLOCK,Cname,Entity,NUMITEMS,,,,,KOPT

Cname
    Eight character component name.
Entity
    Label identifying the type of component (NODE or ELEMENT).

Reference section 3.2.5 in:
Ansys_Mechanical_APDL_Programmers_Reference.pdf

Is there something else I'm missing?

Thanks for your answer.
That's interesting because in the cdb-Files I am working on, for the type of component ELEM is used and not ELEMENT.
I guess, both types are possible.


Fix renaming fix-it when trailing closures are present.

Explanation: The fix-its for a function now imported as a member are incorrect if there’s a trailing closure, because “the end of the TupleExpr” isn’t the same location as “the close paren”.

Scope: Poor fix-its for dispatch_sync and dispatch_async (and others, but those will by far be the most common).

Issue: rdar://problem/26305887. Reviewed by @DougGregor.

Risk: Low. This only affects diagnostic code, and should not be any more unsafe than the existing code.

Testing: Added compiler regression tests, verified that the fix-it for the original test case is correct.

Before merging this pull request to apple/swift repository:

[ ] Test pull request on Swift continuous integration.

Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please smoke test
    OS X platform               | @swift-ci Please smoke test OS X platform
    Linux platform              | @swift-ci Please smoke test Linux platform

Validation Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please test
    OS X platform               | @swift-ci Please test OS X platform
    Linux platform              | @swift-ci Please test Linux platform

Note: Only members of the Apple organization can trigger swift-ci.

@swift-ci Please test

@swift-ci test


[Auto Complete][Textfield] onFocus and onBlur event

Problem description
Is it possible to support onFocus and OnBlur function for Auto complete or Textfield component? These functions can be very helpful if the content need to be changed into another format once the input is finished and focus is lost.
Versions

Material-UI: v0.15.4
React: all
Browser: all

@oliviertassinari: what do you think about this?
I can open a PR.

I believe that it's a duplicated issue. It's not the first time I see it.

Actually Material UI already has those functions.
Example: http://www.webpackbin.com/E1EYtmk0b

@oliviertassinari: I think we can close this.

I agree, it should be good with https://github.com/callemall/material-ui/pull/3356. Thanks.


makde a rock, paper scissor project

#82 resolve

Thanks for the PR. The website looks dope. It has been merged.
I will be glad if you can leave a star on this repository.


Unable to install

Hi!
When trying to install sticky notes, i get a 404 Not Found error("The requested URL /sticky-notes-1.9/public/setup/install was not found on this server."). (the paths should be working fine as I didn't move any of the files).
Any ideas?

I'm basically having the same problem. I have sticky-notes residing in /var/www/paste, apache is set "Alias /paste /var/www/paste/public" and when I go to /paste it redirects me to /paste/setup/install and Apache throws an /var/www/paste/public/index.php

I'm basically having the same problem. I have sticky-notes residing in /var/www/paste, apache is set "Alias /paste /var/www/paste/public" and when I go to /paste it redirects me to /paste/setup/install and Apache throws an /var/www/paste/public/index.php

Try appending index.php to your URL. It seems like URL rewriting isn't working for your virtual host.

That fixed the problem. Thanks.


CORE-226 - Application Counting

Closes CORE-226

:tada: This PR is included in version 4.2.12 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


set mongodb to use auth and encryption

mongodb traffic should be encrypted and should use authentication.

Its isolated to run on the localhost.  Its ok to run as it is.


Objective 2 text is wrong

Challenge Waypoint: Use RGB values to Color Elements has an issue.
User Agent is: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/46.0.2490.71 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
Text for objective two says "Use rgb to give your body element the background-color of black. For example body { color: rgb(0, 0, 0); }."
There should be "background-" in front of the "color" in the example.

Fixed with https://github.com/FreeCodeCamp/FreeCodeCamp/pull/3931


Unable to log in

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az login
Errors:
The command failed with an unexpected error. Here is the traceback:
Unable to find wstrust endpoint from MEX. This typically happens when attempting MSA accounts. More details available here. https://github.com/AzureAD/microsoft-authentication-library-for-python/wiki/Username-Password-Authentication
Traceback (most recent call last):
  File "/usr/lib64/az/lib/python3.6/site-packages/knack/cli.py", line 231, in invoke
    cmd_result = self.invocation.execute(args)
  File "/usr/lib64/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 663, in execute
    raise ex
  File "/usr/lib64/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 726, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
  File "/usr/lib64/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 697, in _run_job
    result = cmd_copy(params)
  File "/usr/lib64/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 333, in __call__
    return self.handler(*args, **kwargs)
  File "/usr/lib64/az/lib/python3.6/site-packages/azure/cli/core/commands/command_operation.py", line 121, in handler
    return op(**command_args)
  File "/usr/lib64/az/lib/python3.6/site-packages/azure/cli/command_modules/profile/custom.py", line 148, in login
    use_cert_sn_issuer=use_cert_sn_issuer)
  File "/usr/lib64/az/lib/python3.6/site-packages/azure/cli/core/_profile.py", line 157, in login
    user_identity = identity.login_with_username_password(username, password, scopes=scopes, **kwargs)
  File "/usr/lib64/az/lib/python3.6/site-packages/azure/cli/core/auth/identity.py", line 156, in login_with_username_password
    result = self._msal_app.acquire_token_by_username_password(username, password, scopes, **kwargs)
  File "/usr/lib64/az/lib/python3.6/site-packages/msal/application.py", line 1463, in acquire_token_by_username_password
    headers=headers, **kwargs))
  File "/usr/lib64/az/lib/python3.6/site-packages/msal/application.py", line 1482, in _acquire_token_by_username_password_federated
    raise ValueError("Unable to find wstrust endpoint from MEX. "
ValueError: Unable to find wstrust endpoint from MEX. This typically happens when attempting MSA accounts. More details available here. https://github.com/AzureAD/microsoft-authentication-library-for-python/wiki/Username-Password-Authentication

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az login -u {}

Expected Behavior
Environment Summary
Linux-3.10.0-1160.88.1.el7.x86_64-x86_64-with-centos-7.9.2009-Core, CentOS Linux 7 (Core)
Python 3.6.8
Installer: RPM

azure-cli 2.38.0

Additional Context

Thank you for opening this issue, we will look into it.


Improve ember performance on JS

Still a half-baking idea, just wanted to jot down the note. This is a tricky one to do right since the first priority should be to avoid any performance regressions in ember JVM while also avoiding splitting ember into platform-specific implementations which would be terrible.
Back when I did the original cross we did some quickie performance tests with hey for ember-server JS, I think the results are lost on discord somewhere. In any case, they were pretty bad when compared to the Node.js native server. This was particularly disappointing since the Node.js server is itself written in pure Javascript using the same socket APIs we have access to. So in theory, it should be possible to match its performance.
~IIUC ember internally makes heavy use of Array[Byte]. While this makes sense on JVM, I think on JS this ends up as something like Array[Double] (or worse). In JS bytes are generally handled with ArrayBuffer and Uint8Array.~
~Fortunately, in Scala.js a java.nio.ByteBuffer is actually backed by a JS ArrayBuffer by default. Furthermore, fs2.io.net on JVM also uses ByteBuffer-backed Chunk[Byte]s. So at a first glance, it seems like a ByteBuffer-based ember could be good cross-platform solution.~
~But, I'm too new to know the history of ember, and I would not be surprised if ByteBuffers are something that were already tried/rejected for ember JVM. In which case, back to the drawing board.~
Update: This idea was very unbaked. Fortunately I was patently wrong, and on Scala.js Array[Byte] does get optimized to an ArrayBuffer-based type. So none of this ByteBuffer fuss would change anything. Unfortunately, that takes us back to the drawing board for optimization ideas.

The place for optimization is fs2, which has JS-specific code that we can tinker with without messing up JVM.


[Security] Workflow push.yml is using vulnerable action actions/checkout

The workflow push.yml is referencing action actions/checkout using references v1. However this reference is missing the commit a6747255bd19d7a757dbdda8c654a9f84db19839 which may contain fix to the some vulnerability.
The vulnerability fix that is missing by actions version could be related to:
(1) CVE fix
(2) upgrade of vulnerable dependency
(3) fix to secret leak and others.
Please consider to update the reference to the action.

@fockboi-lgtm I'm starting to see a lot of duplicates for this.  Is there something I'm doing wrong to mitigate?

@fockboi-lgtm I think this is already mitigated.  What example are you proposing?  (Please also see the other 2 issues that were opened for this previously.)


add placeholder for additional details

Signed-off-by: Travis<EMAIL_ADDRESS>

Looks like the review app deploy failed

Looks like the review app deploy failed

I forgot to add the image.  Should work now.


Added detection for empty block payloads

Fixes #265

@thec0keman any idea when this will be pushed to npm?

Sorry, realized this question was to the wrong project.


Some improvements on CI

Some improvements on CI
Signed-off-by: julio-cesar-development<EMAIL_ADDRESS>

Commentbuild of commit d950ac1 was successful, LGTM


google custom search and picocoms

Hey,
Ive tried to implement a google custom search on my page. But after Ive inserted the code from google nothing is shown on my page. Maybe the problem is that the code which Ive inserted in the search.md is modified automatically by pico / markdown? The last line is
<gcse:search></gcse:search>
but when I look at the source code it is changed to:
<search></search>
I think thats not correct? Why does this happen :-/

Parsedown, the 3rd-party Markdown parser Pico uses, unfortunately has some known limitations regarding custom HTML elements. Anyway, since a search page is rather part of a website's structure than a website's contents, I recommend moving Google's code to a Twig template. Simply create a search.twig with the code of Google's custom search in your theme's directory and create a search.md with Template: search in its YAML Frontmatter.


Mark JS standard warnings, add semistandard maker.

Based on discussion in https://github.com/neomake/neomake/pull/345

I was just about to open a PR to enable these changes. Could the branch be updated with master and merged, if the maintainers don’t have any issues with it? :)

Updated - I'd love to see this merged too.

Thanks!


If the comparison call to convert fails badly, fail the test but don't abort test altogether

On windows, it seems that convert is failing badly when trying to compare .webp files.  This causes the entire test suite to bork.  This PR adds some tolerance of such failures, and allows testing to continue.
cc @chadrolfs

LGTM


registry not taking path

I am trying to use this library but my schema registry does not follow the path of https://localhost:80/schemas/ids/{id}, it is more like https://localhost:80/api/v1/confluent/schemas/ids/{id}. I would like the library to take the extra path that is provided. I noticed in fetch-schema.js that it does not append the provided path.
const registry = require("avro-schema-registry")(   "http://localhost:80/api/v1/confluent/" );
currently like this

const { protocol, host, port, auth } = registry;

   const requestOptions = {
      host,
      port,
      path: `/schemas/ids/${schemaId}`,
      auth

to this?
 const { protocol, host, port, path, auth } = registry;
 const requestOptions = {
      host,
      port,
      path: `${path}schemas/ids/${schemaId}`,
      auth

It'd make sense, I'll do this soon

Thanks, it would really help.

Out in 1.3.1


Faster finalization of "grpc_build_artifacts" job

When kokoro finished the job, it does rsync of the entire workspace back to an agent, before selecting the actual artifact files.
So if our build ends up with a very large workspace, rsyncing the workspace can take a lot of time.
We already use the delete_nonartifacts.sh trick in multiple places. (also see b/74837748)
I didn't realize previously that it was also important for the grpc_build_artifacts job.
(I think what's making the workspace large is the intermediate files from ruby artifact build, other artifacts get build in a docker container, which doesn't leave intermediate files)
Excerpt from the end of the grpc_build_artifacts log (it takes ~8mins to finalize the job)
[21:52:07] Collecting build artifacts from build VM
[22:00:42] Kokoro builder finished

[01:47:05] Collecting build artifacts from build VM
[01:55:42] Kokoro builder finished

I came up with a more general solution in https://github.com/grpc/grpc/pull/28259.  This PR should only be merged if the altsrc workaround doesn't go through.

Superseded by https://github.com/grpc/grpc/pull/28259.


A string data is not closed

The code highlight is wrong due to a string data is not closed.

Hi @iwate, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.
TTYL, AZPRBOT;

ack

Merged

Thank you very much for your contribution!


Be quiet while npm && bower installs

As of now:
I'm all done. Running bower install & npm install for you to install the required dependencies. If this fails, try running the command yourself.

npm http GET ....
npm http GET ....
....
....

Would be useful if it's something like:
I'm all done. Running bower install & npm install for you to install the required dependencies. If this fails, try running the command yourself.

........ Done! Enjoy :-)

In case of an error:
I'm all done. Running bower install & npm install for you to install the required dependencies. If this fails, try running the command yourself.
.
......Error! There was error check the logs/ try manual install.

It's like --quiet or --silent by default, but just enjoy information to notify the progress.

I prefer a little noise over accidentally hiding away any warnings or errors. Wouldn't this be easier implemented in npm as simply a less noisy installation process?

I'm all done. Running bower install & npm install for you to install the require
d dependencies. If this fails, try running the command yourself.
events.js:141
throw er; // Unhandled 'error' event
^
Error: spawn cmd ENOENT
at exports._errnoException (util.js:870:11)
at Process.ChildProcess._handle.onexit (internal/child_process.js:178:32)
at onErrorNT (internal/child_process.js:344:16)
at nextTickCallbackWith2Args (node.js:442:9)
at process._tickCallback (node.js:356:17)


Confidence Score to IPEntity files

Required items, please complete
Change(s):

Modified all IPEntity files to determine Alert Priority based on Confidence Score
Added logic to filter rows where confidence score was less than 51
Added alertDetailsOverride to coincide with the Alert Priority

Reason for Change(s):

To add the Alert Priority

Version Updated:

Yes

Testing Completed:

Yes

Checked that the validations are passing and have addressed any issues that are present:

No

Hello @mmelndezlujn, Thanks for raising this PR.
This PR will be investigated and will update you about the same before 13 October, 2023.
Until then can you please clear the validation fails.

Hello @mmelndezlujn please repackage the solution and please clear the validation fails.
Instruction on repackaging the solution and using the V3 tool
https://github.com/Azure/Azure-Sentinel/blob/master/Tools/Create-Azure-Sentinel-Solution/V3/README.md

Hello @mmelndezlujn, Please repackage the solution.

Hello @mmelndezlujn, Please repackage the solution after committing your final changes.

Hello @mmelndezlujn, We are waiting for your response.

Hello @mmelndezlujn, please respond to the above comments.

Hello @mmelndezlujn please repackage the solution.

Hello Manuel, Please work on the above requested changes.

Hello there, @mmelndezlujn. Please notify us if any changes are still pending on your end.

Hello there, @mmelndezlujn. Could you please respond to the remarks above?

Hello there, @mmelndezlujn. Please notify us if any changes are still pending on your end.

Hello! I don't think there are any pending changes.

Hello @mmelndezlujn, can you please work on the requested changes.

Task pending on me to review this PR by @mmelndezlujn and help with packaging effort. Would get this addressed by 11/15.

Thanks, Noted @aprakash13.


Compiling CLI version

When I'm trying to compile CLI version, pkg returns a message below:
> Error! Bin file does not exist (taken from package.json 'bin' property)   /var/www/public/paintbynumbersgenerator/src-cli/main.js
So I changed 'bin' property to "./src-cli/main.ts". Then I got a message
> Error! Unexpected token (19:11)   /var/www/public/paintbynumbersgenerator/src-cli/main.ts
How could I compile a CLI version?

main.ts is a typescript file, you need to compile this to main.js. In visual studio code make sure you run the typescript compiler action, or otherwise run tsc -w in the src-cli folder. If you haven't gotten typescript installed you can do so with npm install -g typescript.

@drake7707 Thank you for responding my question! I've compile it successfully.


F541: Invalid replacement with string concatenation

Python allows for string concatenation by placing two strings one after another:
>>> "5" "4"
'54'

It also permits a string followed by a f-string:
>>> "5" f"4"
'54'

Even those immediately concatenated:
>>> "5"f"4"
'54'

However, there is a niche corner case which causes Ruff to generate invalid syntax: if the first string is empty, followed by an f-string, it will incorrectly generate a triple-quote:
>>> ""f""
''
>>> ""f"4"
'4'
>>> """4"
...
  File "<stdin>", line 1
    """4"
    ^
SyntaxError: unterminated triple-quoted string literal (detected at line 1)

The reproducing example for this is:
""f"4"

Which Ruff corrects to:
"""4"

Which is invalid syntax. It's worth noting that I don't think any linter currently supports this!
Discovered by #4822.

Should we automatically fix this case as ""f"4" → f"4"?

Yes, I suspect this is an issue with how strings are formatted -- not just for this case. However, this particular scenario is just very likely for a fuzzer to generate, where other string issues may not be so trivial to trigger.

We ran into something like this before, in the rule that transforms from strings to f-strings (rules/pyupgrade/rules/f_strings.rs):
// If necessary, add a space between any leading keyword (`return`, `yield`, `assert`, etc.)
// and the string. For example, `return"foo"` is valid, but `returnf"foo"` is not.
let existing = checker.locator.slice(TextRange::up_to(expr.start()));
if existing
    .chars()
    .last()
    .map_or(false, |char| char.is_ascii_alphabetic())
{
    contents.insert(0, ' ');
}


Add String.format function.

That's used very often.

Examples?
I went nuts with aliases when Sugar first started and regretted it a lot. It usually causes more confusion than it solves. Also, I'm sure I visited it when the method was first created. Actually I remember mulling over that one for a long, long time, and I felt in the end that assign is very expressive as to what the method does.

Actually looking at the issue, Python's String#format follows assign almost exactly. To be honest I wasn't aware of this before. Maybe that is a good case for changing the name? I felt that assign was appropriate before but now it seems that  format would be more readily understandable?

.net uses Format as well, but its 0 based on indexes not 1 based, I just ended up using assign in the end, its just I had to come find this thread before I realized it existed.

Actually looks like Python is 0 based as well... maybe this is better?
Sugar is in the middle of a rewrite... if changing it is better then now is the time.

FYI my reasoning for being 1 based originally was that Regex replacement tokens are as well (i.e. .replace(/(abc)/, '$1') ... so much for consistency....

yeah I can see that angle of it, but for consistency I would probably go with 0 based indexes but again it is your library so you do what you think is right, I currently wrote the code base to use 1 based indexes but I guess its not a huge task to change back to 0.

I think that if we keep it as assign 1 based indexes is OK, but if it changes to format then 0 based indexes should be used for consistency.
The question is do you think format is more expected/easier to guess?

yes, I think almost every language/platform has the notion of string format, be it s/printf or format and in most cases they work off zero based indexes, so personally I would generally expect most frameworks to use format and be zero indexed by default.
So if you have assign keep legacy behavior and format do more in line with other frameworks (zero based) then I think you have the best of both worlds.

Well I think it's much more of a mixed bag. Most languages have something like sprintf which don't rely on numbered tokens but instead position. This can be limiting however. The power of assign/format is that it can handle named arguments inside an object (which python can also do), and in keeping in line with that indexes are simply named arguments for arrays. However, following that line of thinking it makes no sense for them to be 1 based, and in fact the code itself has a check for "objectType" that is looking more and more silly to me now. Any change that can reduce code also tends to be one that is more intuitive for users and I'm all for that.
However I'm very much against method creep, and I definitely don't want to keep both if it's at all possible. It doesn't seem that assign is doing anything above and beyond python's format so I have no problem removing assign if we change the name.

Okay this will be in the next major release. Aside from the renaming, the most major difference is that String#format will use zero based indexes. There was also a lot of work to bring it in line with Python as I wanted it to throw errors when tokens cannot be parsed, etc. Also you can escape braces now with {{ or }} which is something assign never even thought about. Very clean implementation considering though, and did some benchmarks on it to make sure the performance is good.

Just to note as a disclaimer however, format in Python is doing much more, some useful, some frankly a little bizarre. This is intended as a subset of that behavior.

Note, this has dovetailed very nicely with issue #472. The implementation is exactly the same as described above, but now it will support deep properties with the . operator. For example:
"You live on: {profile.address.street}".format(user);

It also supports array key indexes, so formatting with complex data without merging (which was what Sugar was previously doing) should now be a breeze:
"User {0.profile.username} just sent a message to {1.profile.username}".format(actor, actee);
"User {0.profile.username} just sent a message to {1.profile.username}".format(users); // alternate

Ok! This is out now!


Can the quality of the final generated audio be improved through noise reduction methods?

Checks

[X] This template is only for question, not feature requests or bug reports.
[X] I have thoroughly reviewed the project documentation and read the related paper(s).
[X] I have searched for existing issues, including closed ones, no similar questions.
[X] I confirm that I am using English to submit this report in order to facilitate communication.

Question details
When listening to the final generated audio with headphones, you can hear a slight noise, similar to electromagnetic interference. Can this be removed through noise reduction methods? Are there any recommended noise reduction tools?

would be mitigated if do noise reduction on the reference audio
https://github.com/Anjok07/ultimatevocalremovergui


docker: failed to register layer: Error processing tar file(exit status 1): lchown /usr/bin/etcd: invalid argument.

See 'docker run --help'.

Other details that may be helpful:
Fresh install on a Proxmox server as a container using the debian-9.0 standard image.
Accidentally wiped my old rancher server's disk image and was in the process of recreating the container to restore/rebuild my rancher installation.

See 'docker run --help'.

See 'docker run --help'.

See 'docker run --help'.

  There appears to be a problem with it running "rootless".

This is the exact error that I have. Thanks, it did work with sudo... which I didn't consider because of the rootless thing.

useing the command "sudo usermod -aG docker $USER && newgrp docker" instead of "dockerd-rootless-setuptool.sh install" fixed the problem for me. "dockerd-rootless-setuptool.sh install" seems to break it.

Same issue happened with me as well. I used dockerd-rootless-setuptool.sh with the following docker run without sudo as suggested in this guide.  See 'docker run --help'.

I solved the problem (Proxmox 7.4 + CT ubuntu 22 + fuse-overlay) following the instructions from there : https://forum.proxmox.com/threads/how-to-use-uids-gids-higher-than-65535-in-ct-lxc.66382/
using uid and gid up to 8000000


Upgrade assemblyscript version

We've recently upgraded to the latest master. We'll need to eventually do it again of course, but this issue can be closed.


Infinite DateTime Tree When debuging simple program.

VSCode Version: 1.40
OS Version: LXQt 0.14.1
C# extension Version: 1.21.7
Steps to Reproduce:
1.Net Core 101 from microsoft learn program.
2.Debug on working program
3.Expand DateTime on Transactions.
4.Then Expand DateTime inside and so on.

Hi @dyzav this is expected - all DateTime objects have a property called Date which is of type DateTime. So you are free to expand them forever.


Add circle bodies

[ ] create circle body component
[ ] add circle body to components parser
[ ] make static collisions for circle bodies
[ ] make kinematic collisions for circle bodies
[ ] make list of systems to adapt to new mechanic

Are you considering refactoring the current kinematics systems to use some sort of union component instead of storing a rectangle, to enable all of these different collision types?
If you are interested in adding more complex kinematics (i.e., polygons), what are the benefits to writing your own solver as opposed to integrating something like box2d or chipmunk2d?

For now we do not plan to add polygons to the game. Rectangles and circles should be enough for our gameplay. I think I already found a solution to optimize current collisions system. Details are in comment here: #444
External physics library would be a solution to some problems, but then we would need to integrate it with our ECS library. I think libraries you mentioned are using their own storage for bodies, so connecting them to the Entt components pools would not be worth the effort.

We're not gonna integrate any kind of physics engine to our game.
Physics engine libary like box2D simulates physics realistically.
In our game we don't want physics to be realistic. We want physics interactions solve the gameplay problems which we have and realistic physics engine doesn't solve these problems. That's why we don't use it.

@20zinnm  @PiotrGardocki
Making union component is not the right solution.
Option 1:
We make separate components: RectangleKinematicCollisionBody, CircleKinematicCollisionBody.
Option 2:
We make component like RigidBody which stores things like mass, staticallyMovedUp itd.
And we have another components like: RectCollisionShape, CircleCollisionShape which store collision geometry.
Later we can also make circle collision shapes for static collision body but for now it's not neccessary.

@Czapa10 That's fair. I think Option 2 is how most other "physics" engines work, where there's a rigidbody that stores general information and a flag that indicates what geometry to use.


fail to use

Hi,
does this only work for github enterprise?
I'm trying like this:
#> github-download-stats -repo chaintipper -owner molecular -release "1.0-beta18"
Repository: molecular/chaintipper

and there's no output at all (except the "Repository:..." line)
Do I need to give API token or something? EDIT: tried with an api token, also same output
I feel lost.

It looks like molecular/chaintipper currently only has pre-releases:
https://github.com/molecular/chaintipper/releases
And I've been filtering those out:
https://github.com/andrewsomething/github-download-stats/blob/2db70e709ec6167704c9fab03d09b4a2bfb0bab2/ghds/ghds.go#L80
There should probably be an option for including them.


Fix repository deletion when there is large number of issues in it

Should fix #5238

Codecov Report

Merging #5426 into master will increase coverage by 0.04%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #5426      +/-   ##
==========================================
+ Coverage   37.55%   37.59%   +0.04%
==========================================
  Files         317      317
  Lines       46832    46831       -1
==========================================
+ Hits        17588    17608      +20
+ Misses      26744    26724      -20
+ Partials     2500     2499       -1

Impacted Files
Coverage Δ

models/repo.go
42.81% <0%> (+0.02%)
:arrow_up:

models/repo_indexer.go
50% <0%> (+5.5%)
:arrow_up:

modules/indexer/repo.go
69.84% <0%> (+5.55%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dc805c...b672391. Read the comment docs.

@lunny please send backport


Cancle download file.

Hellow everyone.I have some problem use your library and hangfire.I have a job on the downloading file by the scheduler.When I remove job in the hangfire the downloading continues.How can I cancel downloading files?

Just out of curiosity why did you not fill in the parameters required when making a new issue? Were you unable to see the template?

Unless you respond with details we cannot help you.


HBASE-21718 Implement Admin based on AsyncAdmin

Introduced an AdminOverAsyncAdmin to replace the old HBaseAdmin in ConnectionOverAsyncConnection.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
92
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 44 new or modified test files.

_ HBASE-21512 Compile Tests _

0
mvndep
11
Maven dependency ordering for branch

+1
mvninstall
387
HBASE-21512 passed

+1
compile
200
HBASE-21512 passed

+1
checkstyle
202
HBASE-21512 passed

+1
shadedjars
343
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
472
HBASE-21512 passed

+1
javadoc
144
HBASE-21512 passed

_ Patch Compile Tests _

0
mvndep
18
Maven dependency ordering for patch

+1
mvninstall
295
the patch passed

+1
compile
199
the patch passed

+1
javac
199
the patch passed

+1
checkstyle
40
The patch passed checkstyle in hbase-client

+1
checkstyle
97
hbase-server: The patch generated 0 new + 412 unchanged - 4 fixed = 412 total (was 416)

+1
checkstyle
21
The patch passed checkstyle in hbase-mapreduce

+1
checkstyle
35
The patch passed checkstyle in hbase-thrift

+1
checkstyle
17
The patch passed checkstyle in hbase-backup

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
328
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
665
Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.

+1
findbugs
514
the patch passed

+1
javadoc
143
the patch passed

_ Other Tests _

+1
unit
228
hbase-client in the patch passed.

-1
unit
15801
hbase-server in the patch failed.

+1
unit
1572
hbase-mapreduce in the patch passed.

+1
unit
355
hbase-thrift in the patch passed.

+1
unit
1110
hbase-backup in the patch passed.

+1
asflicense
152
The patch does not generate ASF License warnings.

23621

Reason
Tests

Failed junit tests
hadoop.hbase.client.TestFromClientSideWithCoprocessor

hadoop.hbase.master.procedure.TestSCPWithReplicas

hadoop.hbase.regionserver.TestRegionMergeTransactionOnCluster

hadoop.hbase.master.procedure.TestProcedurePriority

hadoop.hbase.client.TestFromClientSide3

hadoop.hbase.client.TestAdmin1

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-126/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/126

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile

uname
Linux 6c6a5e99dadf 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
HBASE-21512 / ee3774040f

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-126/1/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-126/1/testReport/

Max. process+thread count
5784 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-backup U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-126/1/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
295
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 44 new or modified test files.

_ HBASE-21512 Compile Tests _

0
mvndep
7
Maven dependency ordering for branch

+1
mvninstall
239
HBASE-21512 passed

+1
compile
148
HBASE-21512 passed

+1
checkstyle
166
HBASE-21512 passed

+1
shadedjars
254
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
354
HBASE-21512 passed

+1
javadoc
109
HBASE-21512 passed

_ Patch Compile Tests _

0
mvndep
16
Maven dependency ordering for patch

+1
mvninstall
249
the patch passed

+1
compile
157
the patch passed

+1
javac
157
the patch passed

+1
checkstyle
31
The patch passed checkstyle in hbase-client

+1
checkstyle
71
hbase-server: The patch generated 0 new + 412 unchanged - 4 fixed = 412 total (was 416)

+1
checkstyle
16
The patch passed checkstyle in hbase-mapreduce

+1
checkstyle
27
The patch passed checkstyle in hbase-thrift

+1
checkstyle
12
The patch passed checkstyle in hbase-backup

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
265
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
538
Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.

+1
findbugs
399
the patch passed

+1
javadoc
107
the patch passed

_ Other Tests _

+1
unit
191
hbase-client in the patch passed.

-1
unit
14339
hbase-server in the patch failed.

-1
unit
1569
hbase-mapreduce in the patch failed.

+1
unit
411
hbase-thrift in the patch passed.

+1
unit
1147
hbase-backup in the patch passed.

+1
asflicense
172
The patch does not generate ASF License warnings.

21450

Reason
Tests

Failed junit tests
hadoop.hbase.master.procedure.TestSCPWithReplicas

hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleWAL

hadoop.hbase.regionserver.TestRegionMergeTransactionOnCluster

hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated

hadoop.hbase.client.TestAdmin1

hadoop.hbase.master.TestSplitWALManager

hadoop.hbase.master.procedure.TestProcedurePriority

hadoop.hbase.snapshot.TestExportSnapshotNoCluster

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-126/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/126

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile

uname
Linux dc14f28d6c1c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
HBASE-21512 / ee3774040f

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-126/2/artifact/out/patch-unit-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-126/2/artifact/out/patch-unit-hbase-mapreduce.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-126/2/testReport/

Max. process+thread count
5479 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-backup U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-126/2/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Any other concerns? @openinx


feat: order cache snapshot

:tada: This PR is included in version 0.128.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Use Composer scripts to introduce composer test

https://getcomposer.org/doc/articles/scripts.md#writing-custom-commands

Since PhpUnit is a dev requirement, shouldn't this point to vendor/bin/phpunit rather than just phpunit?

Composer adds vendor/bin to the PATH, so you don't have to add it in yourself :wink: .

Cool! It didn't use to, do you have a reference when this was added? (That's the down-side of being an early adapter, if you don't keep reading up on changes, you quickly fall under the Law of the handicap of a head start)

https://getcomposer.org/doc/articles/scripts.md#writing-custom-commands

Note: Composer's bin-dir is pushed on top of the PATH so that binaries of dependencies are easily accessible as CLI commands when writing scripts.

Not sure when it was added, however.

Law of the handicap of a head start

Hah, didn't know that one. Good find.

Judging by the docs commit log it was added Jul 23, 2014. Thanks for the reference ;-)


desired_links should work like a logical AND filter

desired_links should work as a logical AND by default in order to be more valuable for network use cases and only filter on status.UP links. undesired_links can still work as a logical OR though.
I've had the chance to discuss some cases today with @jab1982 and @italovalcy. A logical AND for desired_links allow network operators to further specify which links should be present in a path, and this can be strategic when trying to further target a path as a constraint.

Landed on https://github.com/kytos-ng/pathfinder/pull/30


Update Drone - clang-14 and gcc-12

Before merging, test locally. "failed updating 4 targets" "error: definition of implicit copy assignment operator for 'const_stream' is deprecated"

Merged via #707


[Bug] get_balance returns 0 including for addresses with funds

🐛 Bug
Runtime issue returning a balance (from get_balance of Libra client) equal to 0 including for addresses with fund (source of truth used is https://libexplorer.com/address/91ab715b12554e87d998c17a3962321d23125461a3cd2ac7495c06792481ddcc after address minted using the POST REST endpoint "faucet.testnet.libra.org".
To reproduce
Code snippet to reproduce

Revision hash: 8b7b9ae47cc92da22113fd98d66826b924c0e239
Branch: testnet
Related issue: https://community.libra.org/t/mint-doesnt-work-under-linux-ubuntu/1901
Rust: rustc 1.40.0-nightly (787005079 2019-10-04)
Perform get_balance for 91ab715b12554e87d998c17a3962321d23125461a3cd2ac7495c06792481ddcc

Another way to reproduce:
libra% account create
>> Creating/retrieving next account from wallet
Created/retrieved account #0 address 1bfb3b36384dabd29e38b4a0eafd9797b75141bb007cea7943f8a4714d3d784a
libra% account mint 0 150
>> Minting coins
Mint request submitted
libra% query balance 0
Balance is: 0.000000

We found an issue and pushed a new release which fixes the issue.  Please confirm and close this issue if it now works for you, thanks!

Tested it and it works on my side.  Please re-open if it isn't working for you

I am reopening the issue:

It does not reference the fix, did you referenced this issue in the pull request? Can you please add the link here?
About testing, how can such regression be prevented?
2.1 Do you have CI/CD on this repository (at least running basic tests automatically)?
2.2 If tests are missing to cover such issue can we open a new issue to add them?\

Thanks,

In addition what is the motivation for the testnet branch? What is your gitflow?

The bug was due to an overflow in the TotalMarketCap resource. Namely people minted too much libra and the total market cap reaches u64::max and would prevent us from further minting due to the mint logic. See the code here.
This should be a testnet only issue and only thing we can do now is to restart the testnet. In the real world scenario we really can't mint that much of libra.

In addition what is the motivation for the testnet branch? What is your gitflow?

The motivation is that this will be the checkpoint of the version of running testnet software. This also means that in order to communicate with testnet, you need to build your local client on that branch, as there can be some breaking change on the master that might cause backward compatibility issue.


[libmysql] build failure fedora 31

Host Environment

OS:fedora31
Compiler: gcc version 9.3.1 20200408 (Red Hat 9.3.1-2) (GCC)

To Reproduce
Steps to reproduce the behavior:
./vcpkg install libmysql
Failure logs
Computing installation plan...
The following packages will be built and installed:
    libmysql[core]:x64-linux
Starting package 1/1: libmysql:x64-linux
Building package libmysql[core]:x64-linux...
CMake Warning at ports/libmysql/portfile.cmake:8 (message):
  libmysql needs ncurses on LINUX, please install ncurses first.

  On Debian/Ubuntu, package name is libncurses5-dev, on Redhat and derivates
  it is ncurses-devel.
Call Stack (most recent call first):
  scripts/ports.cmake:90 (include)

-- Using cached /home/x0rld/vcpkg/downloads/mysql-mysql-server-mysql-8.0.4.tar.gz
-- Using source at /home/x0rld/vcpkg/buildtrees/libmysql/src/ysql-8.0.4-5b0f2bff58
-- Configuring x64-linux-dbg
-- Configuring x64-linux-rel
-- Building x64-linux-dbg
CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:136 (message):
    Command failed: /home/x0rld/vcpkg/downloads/tools/cmake-3.14.0-linux/cmake-3.14.0-Linux-x86_64/bin/cmake --build . --config Debug --target install -- -v
    Working Directory: /home/x0rld/vcpkg/buildtrees/libmysql/x64-linux-dbg
    See logs for more information:
      /home/x0rld/vcpkg/buildtrees/libmysql/install-x64-linux-dbg-out.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_build_cmake.cmake:91 (vcpkg_execute_build_process)
  scripts/cmake/vcpkg_install_cmake.cmake:24 (vcpkg_build_cmake)
  ports/libmysql/portfile.cmake:51 (vcpkg_install_cmake)
  scripts/ports.cmake:90 (include)

Error: Building package libmysql:x64-linux failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: libmysql:x64-linux
  Vcpkg version: 2020.02.04-unknownhash-external

Additionally, attach any relevant sections from the log files above.

install-x64-linux-dbg-out.log
i tried to update and pull as the output say but nothing change

gcc >= 8 build fail memcpy warning -> error ?

sorry but what do you means ? 🤔

Could you please provide the error log in /home/x0rld/vcpkg/buildtrees/libmysql/install-x64-linux-dbg-out.log?

oh yeah i didn't see un provide the config log mb
install-x64-linux-dbg-out.log

No error in that log. Is the log file truncated?

Confirmed, this is a bug. I will try to fix it as soon as possible.
/home/x0rld/vcpkg/buildtrees/libmysql/src/ysql-8.0.4-5b0f2bff58/vio/vio.cc:319:39: erreur: « void* memcpy(void*, const void*, size_t) » écriture dans un objet de type « Vio » {aka « struct st_vio »} sans affectation par copie triviale [-Werror=class-memaccess]
  319 |     memcpy(vio, &new_vio, sizeof(*vio));
      |                                       ^
Dans le fichier inclus depuis /home/x0rld/vcpkg/buildtrees/libmysql/src/ysql-8.0.4-5b0f2bff58/vio/vio_priv.h:37,
                 depuis /home/x0rld/vcpkg/buildtrees/libmysql/src/ysql-8.0.4-5b0f2bff58/vio/vio.cc:46:
/home/x0rld/vcpkg/buildtrees/libmysql/src/ysql-8.0.4-5b0f2bff58/include/violite.h:296:8: note: « Vio » {aka « struct st_vio »} déclaré ici
  296 | struct st_vio
      |        ^~~~~~
cc1plus : tous les avertissements sont traités comme des erreurs

@x0rld
Could you please have a test based on #11303 and help confirm if this can work for you?

I just have to clone your repo and install libmysql  right ?

Yes, you can have a try. I test this on my local and it can work now.


Fix parameter mix-up in the Bybit client and add timestamp field to the JSON payload

On exchanges where the API doesn't send any timestamp, the current system time is used. I think this only occurs in Bitfinex and Gate.io
I also added a small fix on the Bybit client regarding params p and q

Hey, thank you very much for your contribution, I really appreciate it.
The timestamp I wanted to add it, but I hesitated because I considered that the trades were already sorted before being propagated to the client, but it is better to have the timestamps sent by the exchanges


Have the zip manager only zip src files on small change

When making a change to the source files, I don't want to have to zip all of the node_modules when I only changed a src file, and not the dependencies. This implies not cleaning my package folder in between releases.

Won't Do.
Zipping is a trivial operation.


Low hanging fruit gas optimizations

moved global immutable params into constructor since you don't have any setters, removes the unnecessary SLOAD whenever you access one of the vars
packed the state surrounding vk commits to ensure they're in one storage slot
introduced a "wallet salt set" flag that's packed with the rest that allows checking the actual salt in the validate user op function
added a calldata decompressing fallback function, allows saving on calldata costs for L2 deployments (reference the encoding method to learn how to use)

Thanks for the PR. Amazing 🚀

feat: variable to immutable - they were immutable initially but was later changed - but this is good I think even if we have to upgrade whole contract if verifier change.
pack vk commitment state into struct, add cd compression,  - these are good, thanks 👍  I need to learn about LibZip.
optimize wallet salt check - I don't think we need walletSaltSet - this will be always set when creating the wallet. ZK proof will prevent walletSalt from being bytes(0)
Btw TokenRegistry.sol  was copied from other repo and has some pending works - like hardcoding popular tokens as constants to prevent SLOAD (which is why it didn't have same prettier)

I can merge and remove walletSaltSet if its ok. Or do you prefer to do it?

optimize wallet salt check - I don't think we need walletSaltSet - this will be always set when creating the wallet. ZK proof will prevent walletSalt from being bytes(0)

Feel free to remove, actually didn't implement this optimization entirely correctly (see newest commit). Idea is to avoid SLOAD of a fresh slot in validateEmailOp, walletSaltSet can be packed into the first slot of the struct along with the other values but the salt cannot because it's 32-bytes.
The TODO: What prevents wallet salt from being 0/non-zero are mainly reminders for you/the auditor to check so that the invariant walletSaltSet == (walletSalt != bytes32(0)) is kept as I'm not very familiar with the codebase and what things have already been verified and how at different points


What is difference between Rmap and RLocalCachedMap

I have a DB with 100k hashmap. And I run some 10k, 100k loop test to compare time between getting by RMap and getting by RmapCached
redissonRMap.txt
redissonUseLocalCached.txt

I saw no differences in benchmark time. Am i make a wrong config or something

When I use RMapLocalCached, why redisson keep getting result from my Redis DB, I think it should get result from some local variable instead of connecting to Redis DB and get result ?

I use LocalCachedMapOptions.defaults().cacheSize(0).timeToLive(100000)           .evictionPolicy(LocalCachedMapOptions.EvictionPolicy.NONE)           .syncStrategy(LocalCachedMapOptions.SyncStrategy.NONE)           .reconnectionStrategy(LocalCachedMapOptions.ReconnectionStrategy.NONE),
But when i change a value in Redis DB by redis-cli, redisson immediately get a changed value. ?
Thanks.

JDK 1.8_0161
Redisson 3.6.3

I use redisson 3.6.3.
It take 19.86s when I use RLocalCachedMap and 19.98s with RMap. Even when I test with 100k loop, the difference is always  +/- < 1 second.

The problem is that you're getting RLocalCachedMap each time instead of using shared instance.

Oh thanks, I finally get it. It's nice feature bro. I'm moving all from Jedis to your Redisson. Cheers.

Great! I'm closing it then.


Finish deployment for google-symptoms geo aggregation fix

[x] update the API documentation for google-symptoms (https://github.com/cmu-delphi/delphi-epidata/pull/786)
[x] drop bad old data for google-symptoms hhs and nation in the database (https://github.com/cmu-delphi/delphi-admin/pull/16)
[x] run the google-symptoms pipeline once for the full calendar of reference dates and upload

We can decide later whether to regenerate the version history for google-symptoms. iirc the source data doesn't do any backfill or other kinds of revisions, so we can do a straight mapping from reference date to nominal publish date.
Originally posted by @krivard in https://github.com/cmu-delphi/covidcast-indicators/issues/1406#issuecomment-992625290

Done


bump astroid and lazy-object-proxy

Combine these since they must be upgraded together.

This will require a new version of pylint


Automatically include external_hostname & s3_cdn_url in CORS origin (cors_origin)

Enhancement Proposal
Hi,
I think it would be nice to automatically include the configured external_hostname & s3_cdn_url in the CORS origin (cors_origin).
Currently, cors_origin is configurable so we can set that to include both, but it would be nice if the charm would automatically do this for us. This reduces the chance of human error where updating the other settings would make it less of an issue or miss updating cors_origin.
For external_hostname, I think it would need to take into account force_https to see if it should add https:// or just http://.
For s3_cdn_url, it would add it as is.

@javierdelapuente Can you have a look if this is feasible and create a ticket in the backlog, please?

Enhancement Proposal
Hi,
I think it would be nice to automatically include the configured external_hostname & s3_cdn_url in the CORS origin (cors_origin).
Currently, cors_origin is configurable so we can set that to include both, but it would be nice if the charm would automatically do this for us. This reduces the chance of human error where updating the other settings would make it less of an issue or miss updating cors_origin.
For external_hostname, I think it would need to take into account force_https to see if it should add https:// or just http://.
For s3_cdn_url, it would add it as is.

ISD-2708

@javierdelapuente Can you have a look if this is feasible and create a ticket in the backlog, please?

ISD-2708

@javierdelapuente friendly ping

Thanks for the ping @amandahla . You can see the related story in https://warthogs.atlassian.net/browse/ISD-1817


Unable to find the available slot

Today when I logged in manually to the COWIN site, 100 slots were there on the selected date for a selected location, but this script couldn't able to find the slot and didn't notify me (it was on).
If you could check this, would be a great help!
Thanks in advance

Thanks mate, will try.
Keep up the great work


runtime: eliminate usleep(100) in getfull

Currently we use a usleep(100) loop in getfull to "pause" when we're waiting for GC work during STW mark termination. This both wastes CPU and increases STW latency. It has also caused several problems on platforms where 100us sleeps don't work well: it used to require us to raise the system-wide timer resolution on Windows (#8687), and on Unix platforms without high-resolution timers (older Linux on ARM, OpenBSD, and Solaris), this actually gives up the entire rest of the time slice and seriously interferes with profiling signals (#13405).
We should replace this with a more explicit synchronization mechanism. Conveniently, because getfull is only ever used during STW, this synchronization doesn't have to involve anything beyond getfull and putfull. There are two wake-up conditions that, together, are sufficient: a new buffer is added to the full list, or work.nproc == work.nwait. The former case only happens in putfull. Ideally we can sharpen that to "a new buffer is added to the full list and there's a blocked getfull" without introducing races. The latter case requires waking all blocked getfulls, so we have to be careful to not race with another getfull blocking. However, we do know that if work.nproc == work.nwait, some non-blocked getfull will have detected that condition, so it can trigger the global wake up.
/cc @RLH

Too late per Austin.

Commit ee3d201 essentially fixed this. The sleep is still there, but at this point the only time we ever call getfull is in a fallback path of STW mark termination when a rare race happens that causes mark termination to start early (see the commit for more details). I plan to fix this race in Go 1.9, which will actually eliminate getfull and the sleep, but for all practical purposes, this is now fixed.


Title is white(invisible) with Theme.LIGHT

new MaterialDialog.Builder(this)
         .theme(Theme.LIGHT)
         .title("Bilgi")
//       .titleColor(Color.parseColor("#000000"))
         .content(R.string.info_content)
         .positiveText("OK")
         .show();

I use above code to create the Dialog but the title color is white.

Well, the sample project uses mostly light dialogs. It works fine. You
probably have an issue in your Activity theme somewhere.
On Thu, Apr 9, 2015, 7:57 AM Osman Saral<EMAIL_ADDRESS>wrote:

new MaterialDialog.Builder(this)
.theme(Theme.LIGHT)
.title("Bilgi")
//       .titleColor(Color.parseColor("#000000"))
.content(R.string.info_content)
.positiveText("OK")
.show();
I use above code to create the Dialog but the title color is white.
—
Reply to this email directly or view it on GitHub
https://github.com/afollestad/material-dialogs/issues/428.

Do you override textColorPrimary in your Activity theme?

This is the sample project, with a dialog basically identical to the one that would be made above:

I did override textColorPrimary . Thanks


Document "how to run ops test and micro benchmarks"

MACE provides nice ops test and micro benchmarks for efficient development. Documentation is needed.

Coming soon.


ContractionTree.branch_info() returns empty list when slicing is applied

I tried to simulate a 30-qubit GHZ state by ACQDP with slicing enabled, but an IndexError occurred.  I modified line 128 of circuit_simulation.py to open_indices = [i for i in range(n)].  I found that self.branch_info() of the ContractionTree object was an empty list in this case.  Is there a way to resolve this error without decreasing the size of open_indices?
~/simulators/acqdp$ python3 examples/circuit_simulation.py entanglement_30.txt
(3_w,7)-aCMA-ES (mu_w=2.3,w_1=58%) in dimension 3 (seed=542818771, Fri Apr 15 09:37:11 2022)
Iterat #Fevals   function value  axis ratio  sigma  min&max std  t[m:s]
    1      7 9.031326093199107e+00 1.0e+00 1.95e-01  2e-01  2e-01 0:12.7
Process 0 initial cost: cost = 9.057243475079245, cw = 30.0, num_slice = 0
Process 0 succeeded with cost = 9.030954605585789, cw = 28.0, num_slice = 2
cost = 9.030954605585789, cw = 28.0, num_slice = 2
Traceback (most recent call last):
  File "examples/circuit_simulation.py", line 157, in <module>
    tsk = tn.compile(order, **kwargs)
  File "/home/koova18/simulators/acqdp/acqdp/tensor_network/tensor_network.py", line 113, in compile
    return Compiler(**kwargs.get('compiler_params', {})).compile(self, order)
  File "/home/koova18/simulators/acqdp/acqdp/tensor_network/compiler.py", line 50, in compile
    res = self._generate_template(tn, scheme=scheme, **kwargs)
  File "/home/koova18/simulators/acqdp/acqdp/tensor_network/compiler.py", line 70, in _generate_template
    init_order, final_order = self._order_patch(tn_copy.copy(), order, split,
  File "/home/koova18/simulators/acqdp/acqdp/tensor_network/compiler.py", line 220, in _order_patch
    final_order = self._patch_order(tn_copy, final_order)
  File "/home/koova18/simulators/acqdp/acqdp/tensor_network/compiler.py", line 258, in _patch_order
    res = tree.patch(self.patch_size)
  File "/home/koova18/simulators/acqdp/acqdp/tensor_network/contraction_tree.py", line 281, in patch
    self.merge_nodes(width)
  File "/home/koova18/simulators/acqdp/acqdp/tensor_network/contraction_tree.py", line 178, in merge_nodes
    if len(br[1]) >= len(br[2]):
IndexError: list index out of range

Hello ChienKaiMa,
Thanks for pointing out this issue. The problem might not be directly related to the number of open indices, but is more likely due to a tensor network structure that triggered some corner case in the program.
Could you please provide the file entanglement_30.txt that reproduces this error?
Cupjin

I have difficulties attaching files right here, so I forked the repository and committed the modified code and circuit files in use in https://github.com/ChienKaiMa/acqdp/commit/fce402e48d573372ff3105d6101132abc12030d2

Hello @ChienKaiMa,
I have changed the logic such that the corresponding optimization is not performed in such cases in order not to raise the error.
Please let me know if this helps.
Cupjin


Fix for certain cases where the regex does not match the context data structure properly

If the message itself contains characters like [ and ] the regular expression would incorrectly match the first json datastructure causing the lua parser to break.
To support this kinds of monolog messages this change is needed.
Also added parsing of datetime from monolog messages and added support for severity names.

Nice work @nrocco


fix: fixed functioning of contact us button in footer

closes #1131
👷🏻 Changes made

Fixed the modal component. Modal component can now have dynamic children as per the need.
On clicking the contact us button , a modal opens where user can report a problem. The Endpoint is /user/report.

📸 Screenshots

https://github.com/MilanCommunity/Milan/assets/116940083/50bbb5e4-e922-4b57-9205-7ccee6eaf357
The above recording shows three things-

Proper functioning of contact us button and modal both.
Sucessfull API call to report problem route.
Proper functioning of database, where the report is stored as expected.

Applied changes

Added font-family Inter to headers and Poppins to normal text in modals.
Removed irrelevant text from console, fixes #1141

Before

After

@tamalCodes If there are any other changes please let me know.

@tamalCodes Thanks for merging this pull request.
If any issues need addressing I am up for grabs!