llmq|rpc|test|version: Implement P2P messages QGETDATA <-> QDATA

This PR introduces two new P2P messages and with that it bumps the protocol version to 70219. They will in a follow up PR be used for DKG data sharing between masternodes. Means this PR only contains the implementation of the messages and their tests.
The messages:

QGETDATA - Ask a masternode for DKG data. Can be both or either of the following:

The quorum verification vector a specific quorum
The encrypted DKG contributions from member of the quorum

QDATA - Respond with the requested DKG data.

5e858cf, 269ce38 and 38bde3f Contain the most part of the messages implementation
6b55815 Implements tests
285c9bd Introduces a RPC wrapper around QGETDATA called quorum getdata (I actually only did that to be able to test everything related to the new messages independently in this PR)
The other commits are mostly helper around the implementation.
This PR is based on #3929 #3930 #3937 #3943 #3948

Okay so now it should be ready here.. d8466b4 and 1b7519e  are needed after #3943.
d8466b4 reverts changing the cache value there from non-const to const. Want to rather see it in its own PR? Let me know.
1b7519e Just adjusts cache usage

Okay so now it should be ready here.. d8466b4 and 1b7519e  are needed after #3943.
d8466b4 reverts changing the cache value there from non-const to const. Want to rather see it in its own PR? Let me know.
1b7519e Just adjusts cache usage

Pls see https://github.com/UdjinM6/dash/commits/pr3953 for some suggestions.

Looks good! Will push them with the rebase after #3969 :)
In the meantime, back to draft here one more time 😄

Pls see https://github.com/UdjinM6/dash/commits/pr3953 for some suggestions.

Looks good! Will push them with the rebase after #3969 :)
In the meantime, back to draft here one more time 😄

@PastaPastaPasta The last few commits apply the most suggestions, i referenced the commits where it made sense. Sorry, i didn't drop those lines, i just like them in those cases and for my eyes its better to ready as i told you on the call hehe.

@PastaPastaPasta The last few commits apply the most suggestions, i referenced the commits where it made sense. Sorry, i didn't drop those lines, i just like them in those cases and for my eyes its better to ready as i told you on the call hehe.

@PastaPastaPasta Picked the typo (0b0a7a0) 👍 but whats the point of 3d52131 aka wrapping those two random lines out of the 48 that have more than 80 chars? :D

@PastaPastaPasta Picked the typo (0b0a7a0) 👍 but whats the point of 3d52131 aka wrapping those two random lines out of the 48 that have more than 80 chars? :D

PEP8 format, which we mostly follow, wants all lines wrapped at 80 chars. That's not practical in a lot of situations, but here it is

PEP8 format, which we mostly follow, wants all lines wrapped at 80 chars. That's not practical in a lot of situations, but here it is

PEP8 format, which we mostly follow, wants all lines wrapped at 80 chars. That's not practical in a lot of situations / is annoying to do for EVERY line, but here it is

I got the general idea behind its just that the execution of the idea looks arbitrary because you picked just two random lines out the many which are above 80 chars. But okay, picked it..🙈

PEP8 format, which we mostly follow, wants all lines wrapped at 80 chars. That's not practical in a lot of situations / is annoying to do for EVERY line, but here it is

I got the general idea behind its just that the execution of the idea looks arbitrary because you picked just two random lines out the many which are above 80 chars. But okay, picked it..🙈

Please see 07a906d367fa6a65aae6ad3ffd03026c43a6b4ee
I think I'm emotionally done with it for now

Please see 07a906d367fa6a65aae6ad3ffd03026c43a6b4ee
I think I'm emotionally done with it for now

Please see 07a906d

Picked 👍 Added some more commits to clean it up a bit, see commit messages. (224a98a + be7c66d are just two more unrelated tweaks)

Please see 07a906d

Picked 👍 Added some more commits to clean it up a bit, see commit messages. (224a98a + be7c66d are just two more unrelated tweaks)

Pls see https://github.com/UdjinM6/dash/commit/4bcd660376c64f2296a8eb0b8770220675e82658

Pls see https://github.com/UdjinM6/dash/commit/4bcd660376c64f2296a8eb0b8770220675e82658

@PastaPastaPasta I don't see how this makes anything "too complex".. it just additionally tests a bunch of error codes in one function with mostly the same lines of code.

instead of having small as reasonable, atomic tests

IMO we should rather see p2p_quorum_data.py as the atomic test here like we have many tests in separate files and they are all independent from each other (atomic tests), and not worry too much about "making parts of the tests inside the test atomic" because inside the test file they probably always depend on each other due to using the same nodes/blockchain. Now, the sections inside test_basics() are still as "atomic" as they were before (they still share resources btw so they anyway aren't atomic, are they?) with the difference that they are not longer separated by the name of the function but with a log line. Don't get me wrong, i like to give it a bit more structure in general but i honestly don't see a lot value in splitting them up into multiple functions where each function is just written and called below the other in the same file while they still all dependent on the same resources of the function they are written in i.e. the variables defined in run_test(). It's IMO basically the same effect then just separating them by just a log message with the only difference, that you can navigate into the separate functions which is IMO not a huge benefit in a file with 460 lines which is just an autonomous test for one feature.

Pls see UdjinM6@4bcd660

@UdjinM6 I like that approach in general and i had it like this in the evolution of the test but for some reason it seems to fail to get the correct ID on CI sometimes, see https://gitlab.com/UdjinM6/dash/-/jobs/991707418#L3241 (assert node.mnauth(node_id, protx_hash, operator_pubkey) fails which can obviously only happen if the provided nodeId is incorrect/does not belong to a connected node?. Thats why i ended up with the "directly return the found ID" approach :D If you have any idea how this can happen, tell me!

@PastaPastaPasta I don't see how this makes anything "too complex".. it just additionally tests a bunch of error codes in one function with mostly the same lines of code.

instead of having small as reasonable, atomic tests

IMO we should rather see p2p_quorum_data.py as the atomic test here like we have many tests in separate files and they are all independent from each other (atomic tests), and not worry too much about "making parts of the tests inside the test atomic" because inside the test file they probably always depend on each other due to using the same nodes/blockchain. Now, the sections inside test_basics() are still as "atomic" as they were before (they still share resources btw so they anyway aren't atomic, are they?) with the difference that they are not longer separated by the name of the function but with a log line. Don't get me wrong, i like to give it a bit more structure in general but i honestly don't see a lot value in splitting them up into multiple functions where each function is just written and called below the other in the same file while they still all dependent on the same resources of the function they are written in i.e. the variables defined in run_test(). It's IMO basically the same effect then just separating them by just a log message with the only difference, that you can navigate into the separate functions which is IMO not a huge benefit in a file with 460 lines which is just an autonomous test for one feature.

Pls see UdjinM6@4bcd660

@UdjinM6 I like that approach in general and i had it like this in the evolution of the test but for some reason it seems to fail to get the correct ID on CI sometimes, see https://gitlab.com/UdjinM6/dash/-/jobs/991707418#L3241 (assert node.mnauth(node_id, protx_hash, operator_pubkey) fails which can obviously only happen if the provided nodeId is incorrect/does not belong to a connected node?. Thats why i ended up with the "directly return the found ID" approach :D If you have any idea how this can happen, tell me!

Okay i just saw this one https://gitlab.com/xdustinface/dash/-/jobs/991429505 where it fails the same for be7c66d9ef1b485a90270a064258d9f8ab910dfb so its obviously not related to the refactoring to cc38df2. But i think i at least didn't see this failure before all the recent refactoring.

Okay i just saw this one https://gitlab.com/xdustinface/dash/-/jobs/991429505 where it fails the same for be7c66d9ef1b485a90270a064258d9f8ab910dfb so its obviously not related to the refactoring to cc38df2. But i think i at least didn't see this failure before all the recent refactoring.

Nice, so if #3971 fixes it, this means the issue is that mininode didn't send verack the moment we do the mnauth call which leads to not having fSuccessfullyConnected (in core) set to true for the mininode connection and thats why then doesn't find it in the "fully connected" peers? i.e. be42e23f64e91a75ccf35102fe76d1e5c58c1c4b should also do it?
I suspect the actual issue then to be this change where it initially slept 1s which then was maybe just enough to get the verack sent?

Nice, so if #3971 fixes it, this means the issue is that mininode didn't send verack the moment we do the mnauth call which leads to not having fSuccessfullyConnected (in core) set to true for the mininode connection and thats why then doesn't find it in the "fully connected" peers? i.e. be42e23f64e91a75ccf35102fe76d1e5c58c1c4b should also do it?
I suspect the actual issue then to be this change where it initially slept 1s which then was maybe just enough to get the verack sent?

this means the issue is that mininode didn't send verack the moment we do the mnauth call

Not necessarily, could be that mininnode sent it but core was simply too slow at processing the message queue or busy with smth else. But yeah, 2220d61 would do it too I think 👍

this means the issue is that mininode didn't send verack the moment we do the mnauth call

Not necessarily, could be that mininnode sent it but core was simply too slow at processing the message queue or busy with smth else. But yeah, 2220d61 would do it too I think 👍


OCM-3356 | fix: change the wording for autoscaler params

It almost seems like the 'help' option ('?') doesn't show more information for some parameters.
Changing it into a bit more comprehensive messages.

/cc @sunzhaohua2 @gdbranco @ciaranRoche

/cc @Gregory-Pereira

/retest
seems like an infra problem. checking if it persists

/lgtm

/retest


Update README.MD to reflect the new karma version

The package now specifies version ^3.x.x
Please make sure that your commit messages follow our convention!

I signed it!

Actually, looks like the peer is still not set accordingly. I've tested and at least our build works with v3. Is there a reason you don't support that one?

@hilts-vaughan Nope, was just pending CR at #264. Fixed now.


Visual Studio Code IntelliSense issue with Python

Hi There:
Code Snippet

When I install python interpreter this IntelliSense does not work.

we probably need code snippet to repro the issue and the expected behavior and actual behavior so we know what we are looking for.


Added 4 new notebooks via upload

Added 4 notebooks that demonstrate running spark and third party (scikit-learn) applications on remote HDP cluster from code within the DSXL

A new pull request will be created to reflect more changes together

@vinodhmohan91 let me know when you've got a PR ready for review. thanks again for contributing.


Update docs for 1.1.0 release

Pull Requests:

https://github.com/Senzing/sdk-components-ng/pull/108


Groups

@d34dman Hey, I see that you updated the package with some of the changes I've made from this PR and maybe others. Can you add me as a collaborator? Can you put a license on this?

@rowrowrowrow , with latest changes made by me, do we need this?

Probably not, I realized that groups should be added directly to the filter shortly after using this anyway.


Electron packaging (start creating desktop app releases)

I want to start producing builds early. I can copy a lot of boilerplate/configuration from jspaint.
Electron and Electron Forge both pretend to be way simpler than they are in practice, but what are you gonna do?

[x] Fix the build https://github.com/1j01/tracky-mouse/issues/53
[ ] Fix icons in packaged app. I tried a symlink, but Electron Forge broke. I could make the images folder into an internal "resources" npm package, or I could just copy the needed icons into the app. I don't expect to change them frequently, and it would be nice to have a clean separation of what is required by the app, in order to limit the size of the app.
[ ] Handle Squirrel events properly. Don't require serenade-driver or anything until after exit for installer, since if it errors, it's pretty ugly, and may even leave the installer process running. Exit properly. app.quit() doesn't exit immediately!
[ ] Prevent click at startup, especially since the non-traditional Windows installer installs and runs the app in one click, through some combination of:

[ ] #41
[ ] https://github.com/1j01/tracky-mouse/issues/10
[ ] or a welcome screen
[ ] or SOMETHING

[ ] Establish some sort of release process
[ ] I should make sure the npm package has a README. I've moved it into a folder, so the README is no longer next to the package.json file. Maybe the API.md can become the readme of the library?

Released the first prebuilt version of the desktop app, in v1.1.0


Implementing folder tree

Please search to check for an existing issue (including closed issues, for which the fix may not have yet been released) before opening a new issue: https://github.com/k9mail/k-9/issues?q=is%3Aissue
DONE
Expected behavior
Tell us what should happen: browsing through the folder list when moving a mail is really boring and error-prone on a smartphone. Implementing a folder tree would be really useful and many basic file explorers shows the path to follow: 1st level folders as a list, then select one folder display 2nd level folders within, etc.
Actual behavior
Tell us what happens instead: very, very, very long list of folders when you've fully organized your mailbox!
Steps to reproduce

Environment
K-9 Mail version: NEXT? ;-)
Android version: ALL
Account type (IMAP, POP3, WebDAV/Exchange): IMAP
Thanks in advance!

Duplicate of #630
(This is actually the oldest unfixed feature request (it is issue 17 on the old Google Code tracker)

Thanks Philip!
Actually, there's so many different titles for the same topic that I didn't find this #630... By the way, I understand it was never closed: does it mean you didn't have time for it or is there any technical issue (other than finding the proper library)?
Thanks in advance for your feedback!

Basically I realised it was a larger feature than I expected initially so it got overtaken by other priorities. I use subfolders pretty intensively so I'd love to see it fixed.

Thanks for the quick answer! As I have some Android developers in my neighborhood, I’ll drop them a line to inquire about a possible library to fix the issue… 😉
Cordialement / Best regards,
Jean-Luc GARNIER
Mob: +33 7 86 12 12 71
Skype: jl.garnier
LinkedIn: fr.linkedin.com/in/jlgarnier
De : Philip<EMAIL_ADDRESS>Envoyé : lundi 3 avril 2017 10:06
À : k9mail/k-9<EMAIL_ADDRESS>Cc : jlgarnier<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Objet : Re: [k9mail/k-9] Implementing folder tree (#2473)
Basically I realised it was a larger feature than I expected initially so it got overtaken by other priorities. I use subfolders pretty intensively so I'd love to see it fixed.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/k9mail/k-9/issues/2473#issuecomment-291074832 , or mute the thread https://github.com/notifications/unsubscribe-auth/AZmL-4JDV-C20x25rOGKyBObqgEgqsdfks5rsKhhgaJpZM4Mwg_e .  https://github.com/notifications/beacon/AZmL-3aLF9HT434kg_SpYsqpI-Q3Cdzvks5rsKhhgaJpZM4Mwg_e.gif

L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast.
https://www.avast.com/antivirus

Hi Philip,
Had a quick search within my network regarding the directory chooser issue
and they directed me to this kind of repository:
https://android-arsenal.com/details/1/5336. Did you ever give a try to this
lib (or similar) for Android? Hope you will soon! ;-)
Keep up the good work and have a nice day!
Best regards,
Jean-Luc
Cordialement / Best Regards,
Jean-Luc GARNIER
Mob: +33 7 86 12 12 71
Skype: jl.garnier
LinkedIn: fr.linkedin.com/in/jlgarnier
2017-04-03 10:05 GMT+02:00 Philip<EMAIL_ADDRESS>
Basically I realised it was a larger feature than I expected initially so
it got overtaken by other priorities. I use subfolders pretty intensively
so I'd love to see it fixed.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/k9mail/k-9/issues/2473#issuecomment-291074832, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AZmL-4JDV-C20x25rOGKyBObqgEgqsdfks5rsKhhgaJpZM4Mwg_e
.


MCR Dev Container Not Running Under Podman

Type: Bug

Using podman, open a project and configure the following dev container: mcr.microsoft.com/devcontainers/base:ubuntu-22.04
VSCode will not launch the dev container properly because of permission issues.
Using podman, open a project and configure the following dev container: docker.io/library/ubuntu:22.04
VSCode will properly launch this dev container.

The MCR container is running the "container user" not under the root user (I believe) so you will get an error attempting to install VSCode in the container itself. I think this MCR container is designed to get around Docker's requirement to run as the superuser. Whereas Podman runs as the user and not "root", VSCode doesn't have the required permissions inside the container to do anything under /root.
Wondering if there's something to be done about this so the MCR container runs under Podman?
VS Code version: Code 1.83.0 (e7e037083ff4455cf320e344325dacb480062c3c, 2023-10-03T16:12:16.321Z)
OS version: Windows_NT x64 10.0.19045
Modes:

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-8259U CPU @ 2.30GHz (8 x 2304)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
31.87GB (16.36GB free)

Process Argv
--crash-reporter-id 26fa402c-7467-4284-b94f-2b7a8bf3c955

Screen Reader
no

VM
0%

Noticed that if you add
"remoteUser": "root"

to devcontainer.json, the MCR version seems to work under Podman. That seems like something you wouldn't want to do if you're running under Docker, though as it might revert whatever changes they were intending.


Bug Report: Initiative Deploy-MDFC-Config_20240319 does not set parameters correctly for policy migrateToMdeTvm

Describe the bug
The initiative  Deploy-MDFC-Config_20240319 has one policy migrateToMdeTvm. This policy takes two input parameters:

Effect
Slected Vulnerability Assessment provider

When assigning the initiative, it is not possible to set those parameters, as they are not passed in in the initiative code.
It would be great if those two parameters were exposed by the initiative, so that they can be modified.
Steps to reproduce
Assign initiative Deploy-MDFC-Config_20240319
Screenshots

@steph409 you can't change the provider, which is why it is hardcoded, and this is why we've "defaulted" to DeployIfNotExists. Are you looking to Disable this? (as stated, you can't change the provider).


Validation rules

Please consider incorporating validator.js to take care of string validation instead of re-implementing rules.
I like the validation approach this project is taking, keep up the good work.

There is nothing wrong in using validator.js inside your code, as we support any function you throw into the validation object. Our validators are split from the main library for a reason. You can just not import them at all if you prefer to.
validators: {
  email: {
    isEmail: validator.isEmail
  }
}

We might add a section both in the README and in the docs with some recommendations for 3rd party validation rules.
Thanks!


"Get rid of all 5-star customer feedback"

Really loving juice shop as a beginner!!
After i completed this challenge,
Get rid of all 5-star customer feedback
It started spamming me:
You successfully solved the challenge : Get rid of all 5-star customer feedback
You successfully solved the challenge : Get rid of all 5-star customer feedback
You successfully solved the challenge : Get rid of all 5-star customer feedback
You successfully solved the challenge : Get rid of all 5-star customer feedback
..
.
I had to refresh the page to stop it. Don't think this is intended behaviour. Please look into it. Thanks :)

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/40739769-get-rid-of-all-5-star-customer-feedback?utm_campaign=plugin&utm_content=tracker%2F6283055&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F6283055&utm_medium=issues&utm_source=github).

Sounds familiar (see #246), will look into that! Thanks for reporting!

@Aman-1412, I tried to reproduce this on the current v2.20 (master branch) and on the upcoming version from develop - and I only get the message once. I tried deleting the Feedback via UI and also via API but both ways worked fine for me.
What version did you use? If <v2.20, please update. Else, please tell me how to reproduce this effect.

I am using v2.20 on master branch.
Yeah even i couldn't reproduce it.  I tried to solve the challenge again to try and reproduce it but i only got this message once.
I think i had the ZAP's fuzzer running (dirbuster) when i first faced this. Maybe the fuzzer caused this issue. When I get back home I'll try to do it again.
A side issue: i stopped the juice shop and ran it again to try and reproduce this issue. When i couldn't reproduce it, i wanted to restore my previous progress but i could not.. I had saved the progress in the previous session.. Please tell me where did i mess up(or should i create another issue with this? Not a big problem. I jus liked  to see more green than red on my score-board

If several requests were in progress before the application realized that the Feedback challenge was solved, each request would trigger that solution message. Basically ZAP overpowered/outran the async Javascript backend... 😀
About the session restore: Did you clear cookies in between? There is a cookie called continueCode for that purpose, so if it's deleted you cannot restore.

Okay, so it was zap after all. Thanks
I did not explicitly clear cookies but i did close that tab and opened a new tab in chrome..

That should not make the cookie go away. It's set to 30 days expiration. If that problem persists and you are sure that cookies are not deleted (or prevented in the first place), please open a separate ticket for that one, ok?
I'm closing this one as "impossible to fix because ZAP is just too much of a tool to handle for the poor little Juice Shop".


Feature request: read more rows to infer column type

Description
I don't know how many rows the TP reads before attempting to infer column types, but it is not enough. Type inference is frequently incorrect because the TP did not recognize (for instance) that a blank cell appears in the column, which should render it an option type, or that a decimal number appears further down a column, and so the type should not be int.
Conduct some experiments to come up with a greater number of rows consumed to do type inference, but not so many it impacts performance too much. More rows is better.
Known workarounds
ForceString - not a nice alternative

Please, this is also my issue. Can we get a bit more extended feedback here=
Is it really the number of rows that the TP reads?
Please - at least - clarify how many are they in the current release as it is, before suspending the whole request as an enhancement.
Thank you very much for understanding.

@giuliohome  when I looked, the number of lines was easy to find in the code. IIRC it was something like 25 or 50.
I haven't used this TP in well over a year, so I have no current feedback. My memory is it could be a lot better. That said, even with improvements I have no plans to use it in the future.

Hi @jackfoxy
thank for your reply. It'sstrange, I have a blank after 3 or 4 lines and the field is interpreted a float/double... and it throws an exception on the blank/row
Will double check it again, if I overlooked anything (actually I like my "workaround" anyway...)

@giuliohome I recall other typing issues. You probably found one I experienced. I filed 3 issues, all on the same day, which addressed the most egregious problems I was having. I think it was not long after this I dismantled all the Excel processing and banned Excel file submission in our company. That's how I solved the problem.

@jackfoxy thanks for sharing your experience and feel free to unsubscribe from the issue.
Really, I was writing to the maintainers of this project.


python310Packages.fastcore: 1.5.18 -> 1.5.22

Description of changes
https://github.com/fastai/fastcore/releases/tag/1.5.22

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 188431 run on x86_64-linux 1

5 packages built:

ghdorker
python310Packages.fastcore
python310Packages.ghapi
python39Packages.fastcore
python39Packages.ghapi


Rename space

We currently use locked for the space name. This is not precise enough which means it might be confusing for users.
For notes, we should use locked-fyi/notes. Generally for any app we need to use  locked-fyi/<app>
Changing this would require a "migration". Given the current state of the application with too few users, it is probably not worth migrating... which means there will be data-loss.

Done as of https://github.com/unlock-protocol/locked.fyi/commit/45f9351f40cbce810629a45be8fa25991e6a520d


No Beacon Notifications

Hi,

I follow Windows 10 configuration steps,
I also try the Windows Discover Universal App

But I can't see any iBeacon. My configuration seems ok because I see my mobile in BLE, And my mobile see Beacons.
Any ideas ? or logs ?

I've tested iBeacons mainly with beacons from kontakt.io - these are shown in the sample app, both on a Windows 10 Mobile device as well as on a PC. Does the app discover any other Bluetooth LE devices? Which device are you using to scan for beacons? Did you already try debugging the app and setting a breakpoint to check e.g., the MAC addresses of the discovered devices to find out if the Windows APIs don't deliver any information about the beacon, or if it gets lost in further processing steps by the app?

I use an other BLE Dongle and now it works ! Thanks !


Incompatibility with ConnectedTexturesMod(CTM) and DynamicTrees

I just wanted to let you guys know that DynamicTrees throws and error and crashes on startup (I think it's during the 4th stage of forge load up, "Mod Initialization: Phase 2"  (or something like that)) if I also have  ConnectedTexturesMod(CTM)  installed. It's not really an issue for me cause I don't really need CTM but it might be good to put on the mod page under incompatibilities or something.

To be more clearly here is the problem:
Caused by: java.lang.UnsupportedOperationException

I have the same exact problem now. Its probably because CTM updated because ive never had this issue before and have used both mods this whole time. And it says the CTM  just updated 11/25/19 so maybe they changed something.

Chisel-Team/ConnectedTexturesMod#116


New version for Scala 2.13.2

Would be nice to get this cross-published for newly released Scala 2.13.2. Pretty please!

np, I'll pick this one up

#351 adds the configuration for releasing for 2.13.2. No version is released for 2.13.2 yet, thus re-opening.

Hi @mccartney , seems semanticdb for 2.13.2 is here! Is there anything left to do before rolling out a new release?

I've just kicked off release of 1.4.4, should be available in Maven in some time.
Also - the Github user experience here for releasing is a nightmare. I am confused every time I try to use it. Probably that's the reason there's something wrong with our past 1.4.3. No fancy changelog in https://github.com/sksamuel/scapegoat/releases


fails to triangulate

local DEL = dofile 'delaunay.lua'
local points = {DEL.Point(0,0,0), DEL.Point(200,1,0), DEL.Point(400,0,0), DEL.Point(300,5,0)}
local triangles = DEL.triangulate(unpack(points))
print(#triangles)  -- outputs 0 (wrong)
for _,tri in ipairs(triangles) do print(tri) end
In comparison, here's what GNU Octave reports:
octave:1> x=[0, 200, 400, 300];
octave:2> y=[0, 1, 0, 5];
octave:3> T = delaunay (x, y);
octave:4> T
T =
2   3   1
2   4   1
2   4   3

Hi, @davidm,
As of commit fd8f63b, this is now fixed.
Sorry for the late answer.
Thanks!


Omansh part3

This PR contains all of the part 3 changes in the beginner project for me. I made a new dummy button on a new page /beginner, I added an endpoint to the backend, and I called that endpoint with my button.

@Omanshb screen recording?


x:Load attribute

Is your feature request related to a problem? Please describe.
https://docs.microsoft.com/en-us/windows/uwp/xaml-platform/x-load-attribute
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

https://github.com/AvaloniaUI/Avalonia/issues/1434

A basic implementation would be quite easy to do. We could have something like this:
    public class DeferLoad : Control
    {
        private IControl _control;

        public static readonly StyledProperty<bool> LoadProperty = AvaloniaProperty.Register<DeferLoad, bool>(
            "Load");

        public bool Load
        {
            get => GetValue(LoadProperty);
            set => SetValue(LoadProperty, value);
        }

        [Content, TemplateContent]
        public object DeferredContent { get; set; }

        public IControl Control => _control;

        static DeferLoad()
        {
            LoadProperty.Changed.AddClassHandler<DeferLoad>((c, e) =>
            {
                if (e.NewValue is bool v)
                    c.DoLoad(v);
            });
        }

        protected override Size MeasureOverride(Size availableSize)
            => LayoutHelper.MeasureChild(_control, availableSize, default);

        protected override Size ArrangeOverride(Size finalSize)
            => LayoutHelper.ArrangeChild(_control, finalSize, default);

        private void DoLoad(bool load)
        {
            if((_control != null) == load)
                return;

            if (load)
            {
                _control = TemplateContent.Load(DeferredContent).Control;
                ((ISetLogicalParent)_control).SetParent(this);
                VisualChildren.Add(_control);
                LogicalChildren.Add(_control);
            }
            else
            {
                ((ISetLogicalParent)_control).SetParent(null);
                LogicalChildren.Clear();
                VisualChildren.Remove(_control);
                _control = null;
            }
            InvalidateMeasure();
        }
    }

Usage:
        <CheckBox x:Name="Load">Load</CheckBox>
        <example:DeferLoad Load="{Binding #Load.IsChecked}">
            <Button>Hello I'm deferred content</Button>
        </example:DeferLoad>

Then XAML compiler could rewrite:
<Button x:Load="{Binding LoadButton}" >Test</Button>

into
<DeferredContentContainer>
  <Button x:Load="{Binding LoadButton}" >Test</Button>
</DeferredContentContainer>

which is also kinda easy to do. But we need to actually design the feature first.
It would be really helpful to investigate how exactly this feature is implemented in UWP.
Is placeholder element somehow being replaced with a loaded one or just adds it as its own child?
How does it work with x:Name and fields in codebehind?

FYI: This is heavily used on the Uno Platform for mobile devices (and even desktop due to how slow it is). There was just no way to get acceptable performance otherwise. I really think it's going to be needed for Avalonia as well once mobile support comes online and is more widely used: https://github.com/AvaloniaUI/Avalonia/issues/1602#issuecomment-881805098
I still think #1434 titled 'Conditional XAML' is confusing as that is a different feature of Microsoft XAML. I would vote to keep this issue open tracking x:Load specifically.

Conditional XAML
Uno: XAML conditional prefixes

@kekekeks

How does it work with x:Name and fields in codebehind?

x:Name and x:FieldModifier are transparent to developers in code-behind. These properties are just used by the code generator and 'Name' and the field modifier are set directly in the generated code. You can access controls by name automatically in code-behind without having to Find them first. Personally, I think of the x: namespace as meaning it is handled by code (x: is a separate XAML namespace for the XAML-defined language elements. Fundamentally, UWP doesn't handle these any differently than Avalonia.NameGenerator
For x:Load things are a little more complicated. It's simple enough to use in XAML. The dev just specifies x:Load="False" and the FrameworkElement will not be constructed and added to the visual tree automatically. Instead, in code-behind, the application must use code such as this.FindName(nameof(this.MyGrid)); otherwise, the reference to MyGrid is always null. (MyGrid will be an auto-generated field in the .g.cs file). The logic for constructing a control and adding it to the visual tree when x:Load is false is not handled by auto-generated files. This appears to be handled within FindName itself.

I was thinking about rewriting x:Load to DeferredContentContainer approach and it seems that just it breaks several interactions with the rest of the framework:

Where should attached properties go? Panels like Grid and DockPanel require them to be set on their direct child. Other properties must to be set on the control itself
Selectors like Grid > Button will simply not work if Button was rewritten to <DeferredContentContainer><Button>..., the selector should look like Grid > DeferredContentContainer > Button

So while being a feasible API to provide as is, we can't use it as direct x:Load implementation.
However, from my understanding x:Load requires special support from container to properly hide the placeholder from the user code, i. e. it doesn't seem to be possible to assign x:Load-marked control to a custom property, e. g.
<local:CustomControl x:Name="Parent">
  <local:CustomControl.Control>
    <local:MyButton
      x:Name="HelloWorld"
      x:Load="True"
      Content="ASDASDASD" />
  </local:CustomControl.Control>
</local:CustomControl>

fails with
Windows.UI.Xaml.Markup.XamlParseException: 'The text associated with this error code could not be found.
Failed to assign to property 'App3.CustomControl.Control'. [Line: 22 Position: 11]'

(tested by @maxkatz6 )
I don't think we need that special support for property assignments since we could just set them in deferred way like we do with bindings.
For panels however that special support seems to be provided by UIElementCollection.
The problem is, we don't have separate Items and ItemsSource like WPF/UWP do, so we can do that on collection level.
The way I see it could be done is by creating an special shadow collection that's linked to the actual list and populated by compiler instead of said list. Shadow collection would track the load status of individual elements and push changes to the target list.
The only limitation of that approach I see is that target list has to be essentially owned by XAML and not modified by anything else, which, I suppose, is OK for most cases.
For cases where it's not appropriate, one could use DeferredContentContainer API that we'll provide separately.

Maybe we need to move to having a separate Items and ItemsSource property as WPF/UWP? It'd be a big breaking change, but would also simplify some other parts of the code as well, and would make porting easier.

A basic implementation would be quite easy to do. We could have something like this:
    public class DeferLoad : Control
    {
        private IControl _control;

        public static readonly StyledProperty<bool> LoadProperty = AvaloniaProperty.Register<DeferLoad, bool>(
            "Load");

        public bool Load
        {
            get => GetValue(LoadProperty);
            set => SetValue(LoadProperty, value);
        }

        [Content, TemplateContent]
        public object DeferredContent { get; set; }

        public IControl Control => _control;

        static DeferLoad()
        {
            LoadProperty.Changed.AddClassHandler<DeferLoad>((c, e) =>
            {
                if (e.NewValue is bool v)
                    c.DoLoad(v);
            });
        }

        protected override Size MeasureOverride(Size availableSize)
            => LayoutHelper.MeasureChild(_control, availableSize, default);

        protected override Size ArrangeOverride(Size finalSize)
            => LayoutHelper.ArrangeChild(_control, finalSize, default);

        private void DoLoad(bool load)
        {
            if((_control != null) == load)
                return;

            if (load)
            {
                _control = TemplateContent.Load(DeferredContent).Control;
                ((ISetLogicalParent)_control).SetParent(this);
                VisualChildren.Add(_control);
                LogicalChildren.Add(_control);
            }
            else
            {
                ((ISetLogicalParent)_control).SetParent(null);
                LogicalChildren.Clear();
                VisualChildren.Remove(_control);
                _control = null;
            }
            InvalidateMeasure();
        }
    }

Usage:
        <CheckBox x:Name="Load">Load</CheckBox>
        <example:DeferLoad Load="{Binding #Load.IsChecked}">
            <Button>Hello I'm deferred content</Button>
        </example:DeferLoad>

(you can just copy that class to your app right now, BTW)
Then XAML compiler could rewrite:
<Button x:Load="{Binding LoadButton}" >Test</Button>

into
<DeferredContentContainer>
  <Button x:Load="{Binding LoadButton}" >Test</Button>
</DeferredContentContainer>

which is also kinda easy to do. But we need to actually design the feature first. It would be really helpful to investigate how exactly this feature is implemented in UWP. Is placeholder element somehow being replaced with a loaded one or just adds it as its own child?
How does it work with x:Name and fields in codebehind?

@kekekeks : Hello, This class works well if the condition change but not when the DeferLoad is created (as the DefferedContent is not assigned yet. Is there any workaround for this ?
Tanks :)

You can change the DeferredContent setter to invoke DoLoad if Load is already true.

You can change the DeferredContent setter to invoke DoLoad if Load is already true.

Perfect, thank you !


Implement all standard functions listed in GatewayInterface

I found myself needing to add void() and capture() functions so I could test my project, and then it sort of took off. \Omnipay\Common\GatewayInterface lists functions which should be standard in any gateway, so I just implemented a dummy version of all of them.

Makes sense to me. If we would really want to complete, we should also allow for a redirect response probably though.

Noted, I have a massive backlog of real world work at the moment, will try to clear my github/omnipay backlog early next week.

+1 - Having the refund method on Dummy will be super-useful!

@coatesap comment about the docblocks is correct -- these need to be fixed.
Also I see that some parts of the markup in the class docblock have changed, e.g. the headings removed.  I see no good reason for that.

OK notwithstanding the fact that travis is passing the tests, this PR needs the docblocks fixed before I can merge.

@delatbabel The GatewayInterface says the methods return a RequestInterface.
@jtgrimes I'd really like to see this merged. You OK with me doing a new PR based on this with the docblocks fixed?

@kynx - you bet! I'm sorry I lost track of this PR - if you want to pick it up, that's great!

@jtgrimes Is your fork at https://github.com/jtgrimes/omnipay-dummy now redundant? Can we move back to using https://github.com/thephpleague/omnipay-dummy? (I think so, just would like to confirm).

@rquadling yep - it was merged in and my fork is actually behind the current repo - definitely switch back.


Mmark is deprecated and will be removed in a future release.

mmark needs to be replaced as it's due to be decommed:
Found here:
content/post/math-typesetting.mmark
7:markup: mmark

themes/hugo-theme-chunky-poster/exampleSite/content/post/math-typesetting.mmark
7:markup: mmark

Link: https://gohugo.io//content-management/formats/#list-of-content-formats

Yeah, I think I'll put this on hold for now. I might wait for https://github.com/gohugoio/hugoBasicExample once it removes the content from there and will update it here.

I guess this is still an ongoing discussion at gohugoio/hugoBasicExample#58. The PR contains removal of the mmark content.


Feature Request: Pushable places!

Following from a conversation with Quartzjer, It would be very handy to be able to push a place directly into the places collection. Quartz mention this could be done using the push api, and have a generic push/X type that the places collection listens for?
A proposed format (heavily based on the current places query API):
_id - string - An auto-generated unique identifier for this place.
at - string - The date that this place was created.
lat - number - The latitude.
lng - number - The longitude.
me - boolean - Marked true if this place is something created by you, as opposed to your friends - i.e. is this my checkin or a friend's?.
network - string - The name of the network or source where this place record came from, e.g. myPlacePusher
path - boolean - Marked true if this place record is part of a path of places, such as a GPS breadcrumb path. For example, Google Latitude is a path, Foursquare is not.
title - string - The name of the location for this place (if available).
A few questions or debate points- does each entry need an id from the source, or is the _id enough? Whilst the idea I have in mind might not need it, is it worth having a data attribute, which can contain extra info depending on the source that might be useful?

I really like this idea.
It might be a good idea to add a "type" field that says what type this particular push is.  The type could just be an enumeration of the collections that are currently there (places, contacts, photos, etc).   That way you could have multiple push events of different names with the same type.   Then when each new push endpoint is created, it could announce to the specific collection it's a type of, that that collection should start listening for events from that newly created endpoint.

+1 Really like the sound of that :)

Great stuff, I'm so assigning myself to this :)


Allow user to adjust the number of verses that are displayed

Users should be able to change the number of verses that are displayed in a scripture card using the card settings:
The levels should be:

1 verse
3 verses
1 paragraph
3 paragraphs
1 chapter

@mannycolon does materialUI have a way of showing what 'level' a slider is at? Like text under the slider to inform the user?

@mannycolon does materialUI have a way of showing what 'level' a slider is at? Like text under the slider to inform the user?

Yes, it does @birchamp
See: https://material-ui.com/components/slider/#restricted-values


Update storage bucket link in proxy help message

Description
We tried to auto-update the version in the URL in https://github.com/GoogleCloudPlatform/cloud-sql-proxy/commit/1439eeaf8b503b18c46e995e76aa58d7cb0dec38, but that didn't seem to work.
This issue is for tracking that the automation works as expected.
We should also port this change to AlloyDB Proxy.

I've created a draft PR for the next release https://github.com/GoogleCloudPlatform/cloud-sql-proxy/pull/2147 using the release-please CLI and it shows that cmd/root.go file is updated.
However I need to address the issue of release-please incorrectly updating the IP address:


nyc-config-babel not working (Error: ENOENT)

Expected Behavior
nyc should run.
Observed Behavior
Error:
fs.js:641
  return binding.open(pathModule._makeLong(path), stringToFlags(flags), mode);
                 ^

Error: ENOENT: no such file or directory, open '<project-root>/@istanbuljs/nyc-config-babel'
    at Error (native)
    at Object.fs.openSync (fs.js:641:18)
    at Object.fs.readFileSync (fs.js:509:33)
    at applyExtends (/usr/lib/node_modules/nyc/node_modules/yargs/lib/apply-extends.js:29:35)
    at Object.Yargs.self.config (/usr/lib/node_modules/nyc/node_modules/yargs/yargs.js:308:13)
    at Object.Config.loadConfig (/usr/lib/node_modules/nyc/lib/config-util.js:34:24)
    at Object.<anonymous> (/usr/lib/node_modules/nyc/bin/nyc.js:23:25)
    at Module._compile (module.js:570:32)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)

It seems like the script is missing the node_modules subdirectory.
Forensic Information
package.json
  "devDependencies": {
    "@istanbuljs/nyc-config-babel": "^1.2.2",
    "ava": "^0.19.1",
    "babel": "^6.23.0",
    "babel-eslint": "^7.2.3",
    "babel-plugin-istanbul": "^4.1.4",
    "babel-plugin-syntax-class-properties": "^6.13.0",
    "babel-plugin-transform-class-properties": "^6.24.1",
    "babel-preset-env": "^1.5.1",
    "eslint": "^3.19.0",
    "eslint-config-standard": "^10.2.1",
    "eslint-plugin-import": "^2.3.0",
    "eslint-plugin-node": "^4.2.2",
    "eslint-plugin-promise": "^3.5.0",
    "eslint-plugin-standard": "^3.0.1",
    "nyc": "^11.0.1"
  }

Environment

OS: Ubuntu 14.04
More info: https://gist.github.com/hbarcelos/5ef5f21af7259d9b91b04b0d12594c71

@hbarcelos if possible, could you share the project that's having this problem so that I can debug.

@bcoe unfortunately the project is not open-source, so I cannot share it with you.

@hbarcelos closing this issue for now, because I don't have enough information to reproduce the issue; If you have some time, please provide a minimal reproduction for this issue in a repository you can share, and I'll happily revisit this issue.

I updated from 11.4.1 to 14.1.1 and I started getting this error.
The tests are passing but fails at the end to access .coverage file in my case.
Error: ENOENT: no such file or directory, open '/.coverage/processinfo/401c82b7-f2dd-44d1-bd53-6258e36577e1.json'
401c82b7-f2dd-44d1-bd53-6258e36577e1.json This file is not in side processinfo, its inface in .coverage folder.

@umeshp7 you are experiencing a completely different issue.  Please post your own bug report including all required information.


Update introspectors.py

paginate_by, page_kwarg, and  paginate_by_param are deprecated in DRF 3.1

Please close this pull request I deleted the fork by mistake.
there is better one here #261.


Capitalized Docker and Swarm for consistency in new CLI commands

Mandatory cute animal as per contributing instructions.

Ha thanks! :+1: Ping @dnephin.

hm some weird failures, also this on win2lin;
07:42:20 # github.com/docker/swarmkit/identity
07:42:20 vendor\src\github.com\docker\swarmkit\identity\randomid.go:54: nn.Text undefined (type big.Int has no field or method Text)

LGTM, Thanks!

@thaJeztah I believe win2lin needs to be updated to Go 1.6.x. Is that something we can do? (cc @jhowardmsft)

@thaJeztah  I would be impressed if my changes broke win2lin (or anything really) :P.

Oh its very picky....
On 9 Jun 2016 8:02 p.m., "tiffany jernigan"<EMAIL_ADDRESS>wrote:

@thaJeztah https://github.com/thaJeztah I would be impressed if my
changes broke win2lin (or anything really) :P.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/docker/docker/pull/23395#issuecomment-224994193, or mute
the thread
https://github.com/notifications/unsubscribe/AAdcPP6x6bM2a8SKvOMlxvi5cwaI9A-vks5qKGNYgaJpZM4Ixobx
.

It does need upgrading, but that's not the cause here.
11:05:05 # github.com/docker/swarmkit/identity
11:05:05 vendor\src\github.com\docker\swarmkit\identity\randomid.go:54: nn.Text undefined (type big.Int has no field or method Text)
11:06:31 + ec=1
11:06:31 + set +x
11:06:31 ERROR: Build of binary on Windows failed

@tiffanyfj yes, it would surprise me as well :smile:

@jhowardmsft It actually is because of the Go version. Text was added in go1.6 and this is running go1.5.3.
https://github.com/golang/go/commit/8d701f092d5dba49a79fada561e90cfdb84f2bd1

Ah, I see. I really stacked with things right now. It might have to be a weekend job to get them upgraded.

Oh sorry, needs a rebase now :cry:

@thaJeztah: Rebased

I think win2lin was updated, so restarting again. Fingers crossed :metal:

It needs rebasing again... but swarm has been merged so you want to PR against master now...

ouch, yes. Sorry @tiffanyfj, I think I should close this, because you can't change a PR to be against a different branch once opened :cry:

No worries. I'll make one against master after I check that it still applies. Thanks.


More liberal use of helpers

Short version:
Can we be more liberal with helper methods (e.g.: lower) and mix them into all nodes?
This will allow more invalid sql to be generated, but also allow more forms of valid sql aswell.
Longer form of the same question?
Helper methods (e.g.: lower) are available on some node, but not available on others.
Due to this reason, I am finding myself relying upon these helper methods less and less and coding the more verbose version Arel::Nodes::NamedFunction.new("lower", [...]) throughout my code.
Example:
Arel::Nodes::Grouping.new(...).lower will not work with Arel.
Would like to hear people's thoughts on the matter before I put in too much effort here.
/cc @matthewd thanks

I'm noticing a number of outstanding issues that are asking for implementation of various dsl helpers in places that weren't originally intended.

I don't think we should allow these helpers in nodes where it will generate invalid SQL. If it is going to generate valid SQL I'm fine to include. I guess this is what is implemented right now.


Fix autoreleasing block warning

This is a warning that is enabled by default with Xcode 9

@pixelglow thoughts on this? 🙏

@pixelglow thoughts on this? 🙏

@pixelglow thoughts on this? 🙏


prepare release 2.14.0

Checklist

[X] Commits are signed with Developer Certificate of Origin (DCO)

Smoke tested on OpenShift and vanilla Kubernetes

/lgtm


added: initial contribution guidelines

📝 Description

This PR updates the README file to include detailed instructions on how to run the project locally and provides comprehensive contribution guidelines.

🏗 Changes

Added detailed steps for running the project locally with Hugo.
Included prerequisites for different operating systems.
Provided a comprehensive contribution guide with step-by-step instructions.
Added a note for Windows users to use PowerShell or a Linux terminal.

🔥 Motivation and Context

Help new users and contributors quickly understand how to set up the project and make contributions.

🧪 How to Test

Clone the repository.
Follow the steps in the updated README to set up the project locally.
Verify that the Hugo server runs correctly and the site is accessible at http://localhost:1313.
Ensure that the contribution instructions are clear and complete.

📋 Checklist

[ ] I have performed a self-review of my code.
[ ] I have tested the changes locally.
[ ] I have added relevant documentation (if applicable).

@majidzeno thanks for your addition :raised_hands:
Please rebase to the main branch, then add the new parts to CONTRIBUTING.md and reference that file in the main readme file under the Contribution section.

Thanks @majidzeno :raised_hands:


Fixed #35174 -- Fixed Signal.asend()/asend_robust() crash when all receivers are asynchronous.

Fixed: https://code.djangoproject.com/ticket/35174

@illagrenan Thanks :+1: Welcome aboard :boat:
I added release notes.


Update instrument meta

Updates the meta to add a list of valid inputs/outputs instead of relying on names Spigot came up with. Following Aya's advice.
Meta inconsistency pointed out by Icecapade

### Change input and output for goat horn instruments to match meta
For goat horn instrument, the meta for it links to the spigot java docs where the field names follow the pattern of SEEK, PONDER, DREAM, etc. However, the namespaced keys for them follow the pattern of seek_goat_horn, ponder_goat_horn, dream_goat_horn, etc.
This PR allows the input of either seek or seek_goat_horn and will now have the tag return seek instead of seek_goat_horn.
This is a very minor breaking change as users who check for the tag result will have to go back and change the names slightly. Any inputs will stay the same however. If this is a problem, let me know and we can discuss how to make it right.

I've updated this PR to only change the meta by manually adding a list of all the goat horn instruments (not very many) and making a minor change in the set code (remove repeated line already stored in a variable). Sorry for the trouble!


sre-864:  migrate shipment tracker database

:lock: Prisma Cloud scan details - vulnerabilities :warning:

:white_check_mark: Passed shipment_tracker:latest   Vulnerabilities found. Total: 0, critical: 0, high: 0, medium: 0, low: 0.
No vulnerabilities found :tada:


Merge queued tests and fix AddAppFromType

Breaking change

Proposed change

Type of change

[ ] Dependency upgrade
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (which adds functionality to an existing integration)
[ ] Breaking change (fix/feature causing existing functionality to break)
[ ] Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request:

Checklist

[ ] The code change is tested and works locally.
[ ] Local tests pass. Your PR cannot be merged unless tests pass
[ ] There is no commented out code in this PR.
[ ] I have followed the [development checklist][dev-checklist]
[ ] The code compiles without warnings (code quality chek)
[ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated for www.home-assistant.io

Codecov Report

Merging #592 (8f28f58) into app_model (f697c36) will increase coverage by 0.90%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##           app_model     #592      +/-   ##
=============================================
+ Coverage      85.06%   85.96%   +0.90%
=============================================
  Files            106      111       +5
  Lines           2805     3021     +216
  Branches         305      318      +13
=============================================
+ Hits            2386     2597     +211
+ Misses           288      285       -3
- Partials         131      139       +8

Flag
Coverage Δ

unittests
85.96% <100.00%> (+0.90%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...el/Common/Extensions/ServiceCollectionExtension.cs
100.00% <100.00%> (ø)

...ime/NetDaemon.Runtime/Internal/NetDaemonRuntime.cs
85.00% <100.00%> (ø)

...mon.HassClient/Internal/Net/WebSocketClientImpl.cs
68.42% <0.00%> (-7.90%)
:arrow_down:

...sClient/Internal/Net/WebSocketTransportPipeline.cs
90.43% <0.00%> (-0.87%)
:arrow_down:

...Runtime/Common/Extensions/HostBuilderExtensions.cs
100.00% <0.00%> (ø)

...ntime/NetDaemon.Runtime/Internal/RuntimeService.cs
100.00% <0.00%> (ø)

...time/Common/Extensions/ServiceBuilderExtensions.cs
100.00% <0.00%> (ø)

...time/NetDaemon.Runtime/Internal/AppStateManager.cs
94.80% <0.00%> (ø)

...mon.HassClient/Internal/HomeAssistantConnection.cs
84.76% <0.00%> (+0.95%)
:arrow_up:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f697c36...8f28f58. Read the comment docs.


Relative time on admin page is wrong

It seems the logic surrounding the relative times for the "Created" and "Last used" column is wrong.

In the screenshot above taken today (2024-03-05), notice that it says "1 month ago". Hovering the mouse over the relative time reveals that it was in fact only on 2024-02-29, i.e. less than a week ago

Maybe it just means "last month", which would be correct looking at the February date from March?

Yup, I would agree - the wording should probably say "Last month" instead then though.
I'd argue that counting days is better since "Last month" leaves me not knowing at a glance whether it was 6 days ago or 30 days ago.

Without having taken a deep-dive in the code, I think the issue comes from the use of "selectUnit". Notice the "Caveats" listed here: https://www.npmjs.com/package/@formatjs/intl-utils#caveats (Also notice that the package is deprecated and selectUnit has been removed from the updated package)


feat(proxy-wasm) metrics

This PR adds support for storing metrics in WasmX shared-memory key-value store facility.
The workflow users are expected to perform follows from Proxy-Wasm metrics ABI itself: users define metrics before using them; when a metric is defined a numeric ID is returned which can later be used for reading or updating its respective metric. If the system is out of metrics memory when defining a new metric, the metric definition fails as eviction support hasn't been implemented.
The implemented design, described at [1], allows users to perform most metric updates without synchronizing Nginx workers, i.e. without the aid of locks.
Users can refer to [2] for a description of how metrics are represented in memory and how to estimate the size of the shared-memory used for metrics storage.
Two configuration directives, slab_size and max_metric_name_length, are added to configure the size of the shared-memory zone dedicated to metrics and the maximum length of a metric name, respectively.
[1] docs/adr/005-metrics.md
[2] docs/METRICS.md

@casimiro I'm looking at coverage which looks mostly good except for this branch, I'm wondering how come it isn't covered, since I'm sure we have histogram tests already?

@thibaultcha thank you for the new round of review!
I'm surprised as well with the missing coverage in ngx_proxy_wasm_host.c. I'm pretty sure I saw those lines covered before. I'll investigate that.

I think I looked at everything now and the changeset looks all good. Once the last couple things are addressed I'll do a local merge with the minor stuff style etc which I left out of reviews. Let me know when ready!

@casimiro Before pushing to this branch again, could you rebase it on the latest main for the CodeQL changes, so that the code analysis integration doesn't get confused again (I deleted all old CodeQL results from the CI workflow).

@thibaultcha thank you for the reviews. The PR is ready.


Feature request: Forward ref on NavLink to Link component

Description
Nowadays it's not possible to pass ref to NavLink because it's a functional component and that's ok. The thing is, I want to get a reference to the underlying Link component instance but there's no way, since React doesn't let me use the ref property and the innerRef points to the DOM element below Link (a tag).
Possible solution
React has this forwardRef utility function which could be used in this stateless component to point the ref property to Link. See https://reactjs.org/docs/forwarding-refs.html

That is a 16.3+ only feature, so we can't add it without breaking backwards compatibility for most versions of React. We still support 15+ for now.

@timdorr any possibility for a linkRef property? I don't see how I could workaround this.

You can write your own. It's only a Link wrapped with a Route: https://github.com/ReactTraining/react-router/blob/master/packages/react-router-dom/modules/NavLink.js#L28-L50

Well thought! Thanks :)


Incorrect build failure warning on front page

Front page shows red failing symbol for codeship but this is based on 1.0rc not on master.

@jameshensman is there nothing we can do about this? It is annoying me.

Not an issue anymore


[DOCS] code_of_conduct.md

Working on it
Do assign it to me

Hey @the-amazing-atharva, the CODE_OF_CONDUCT.md file accidentally got removed when I was experimenting with GitHub rules. Can you please add it again?

Sure!


add Azure as a Kubernetes auth provider

Hey, I just made a Pull Request!
This PR adds:

Azure Identity as a K8s auth provider. For more: https://docs.microsoft.com/en-us/azure/active-directory/managed-identities-azure-resources/overview
AKS dashboard formatter

This is how the config would look like:
        - url: https://my-cluster-aks-53f23f22.privatelink.eastus.azmk8s.io
          name: My AKS Cluster
          authProvider: 'azure'
          skipTLSVerify: true
          dashboardApp: aks #optional
          dashboardParameters: #optional
            subscriptionId: MY-SUB-GUID
            resourceGroup: MY-RG-NAME
            clusterName: my-cluster-aks

:heavy_check_mark: Checklist

[X] A changeset describing the change and affected packages. (more info)
[X] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[X] All your commits have a Signed-off-by line in the message. (more info)

@mclarke47 do you mind reviewing it when you get a chance? I'm eager to start using it 😁
All the magic happens inside this DefaultAzureCredential from Microsoft. When Backstage runs on Azure, it'll have get credentials through Azure. When Backstage runs locally, it'll use developers local token (from $HOME) to authenticate.


Import NSRange from the Darwin overlay

This has two factors that are updated;
NSRange.swift had a number of changes to handle String range conversions in the Darwin overlay. This commit imports the latest changes to NSRange in but also makes it mergeable back to the Darwin overlay so that we can keep the same source between the two repositories.
This change requires NSScanner for key functions to be updated to be in parity with their Darwin counterparts. Note: not all of NSScanner was updated (and seems to have more work to be done to make the naming updates be in sync)

@swift-ci please test


Feature request - proper arc support

Right now SVG arcs appear to result in segmented lines, and unfortunately this is what Illustrator is often generating for curved paths. It makes stuff look pretty bad.
(AI2ASS isn't working for me for some obscure reason, which is why I turned to this project instead).

Unfortunately this is not as trivial as one would wish.
SVG2ASS already uses the latter approach to approximate full circles, ellipses and rounded rectangles, as calculating the control points is pretty straightforward in those cases. For arcs with arbitrary sweep angles however the calculations are substantially more involved. I will look into it, but please don't hold your breath, as I cannot promise to get round to implement this anytime soon, or implement it at all.
Meanwhile a potential workaround might comprise to somehow coerce the SVG generator into using Bézier curves instead of elliptical arcs in paths, as these should carry over reasonably well to ASS.

Thanks for the response. I understand that the calculations are very complex - I tried to look into the code and it was very difficult to follow. One thing of interest might be that when I tried to increase the count of the line segments:
     double step = M_PI / ( 0.36 * ( r.x + r.y ) );
+    if (step > fabsf(dt) / 10)
+        step = fabsf(dt) / 10;

it produced much better results:
Before

After

FWIW the file in question can be found here: https://0x0.st/zw2Y.svg
I had to do some other patches related to parsing unknown style attributes and recognition of translate(x y) (without comma) for it to convert, LMK if you'd be interested in a pull request.

Yep, looks way better with limited step size / increased segment count. I actually  thought of something like that before but forgot to mention it in my previous comment. The step calculation has always been questionable to say the least, so I'd say there's no harm in tweaking it further. (Or even make it configurable, I'll give that some thought.)
Please feel free to send me any patches or pull requests you deem worthy. I will happily accept any fixes and sensible improvements, your efforts are certainly appreciated! And don't hesitate to open issues about stuff you'd rather not touch yourself, I'll try my best to help.
(And yes, the code isn't exactly easy to grok even for me not having looked at it for years. It is a toy project that got out of hand - and it shows. Sorry for that.)

FYI: In 53ab26c I added an (experimental) -z command line option to tweak the angular step width. The higher the argument, the coarser the approximation. The default value of 4.0 should yield a result close to that of the previous hard-coded calculation.

This is awesome! Thank you. For me, this feature request can be closed, but I'm not sure if you'd prefer to track it seeing how there's still a TODO in the code.
The patches I wanted to send were actually just a much dumber implementation of your https://github.com/irrwahn/svg2ass/commit/20ac3b035d1aa4350cbfb16dc96cec801607c107 so there's not much I can further do to improve it :)

You're welcome. Thank you for your input and for reporting the bugs we were able to fix in passing. :)
Don't hesitate to let me know if you happen across any further problems, I'm happy to help.
For the time being I'll leave this issue open, as the original request "proper arc support" IMHO remains valid and there is a small but non-zero chance I'll eventually get round to implement the Bézier approximation.

does it work on windows?

It's a simple command line tool with no external dependencies beyond the C library, so I see no compelling reason why it shouldn't be possibly to build and run on Windows, though I never tried myself (and don't intend to).  My best guess would be to build it using either MinGW or Cygwin, but in theory it should also be feasible to build with MSVC, with minor modifications.


Update Gradle version

Gradle Version 2.10.0
Connect to #12

Landed, thank you.

@loay while you are at upgrading Gradle, could you please check loopback-sdk-android too? I think it's running an old version of Gradle too.

@bajtos Will do.


Fix various typos in menu_fr_fr.latin1.vim

The diff generated by GitHub is noisy. I don't understand why...
Fix only 3 minor typos :
formattage > formatage
Enregister > Enregistrer
Difference\ avec > Différence\ avec

The diff generated by GitHub is noisy. I don't understand why...

Didn't you change the encoding of the file from latin1 to utf-8?
It should be latin1 as the filename says.

I performed these changes using GitHub online editor in my broswer (Google Chrome).
GitHub displayed the following warning when I started editing the file: We’ve detected the file encoding as ISO-8859-1. When you commit changes we will transcode it to UTF-8.

I can't find any way to prevent this unexpected encoding change... And the GitHub Desktop application doesn't even work on my computer.
Please find below the changes suggested in menu_fr_fr.latin1.vim :
line 50 :
-menutrans Split\ &Diff\ with...		&Difference\ avec...
+menutrans Split\ &Diff\ with...		&Différence\ avec...
line 124 :
-let g:menutrans_textwidth_dialog = "Entrez la nouvelle largeur du texte\n(0 pour désactiver le formattage)."
+let g:menutrans_textwidth_dialog = "Entrez la nouvelle largeur du texte\n(0 pour désactiver le formatage)."
line 343 :

tmenu ToolBar.SaveSesn			Enregister session courante

tmenu ToolBar.SaveSesn			Enregistrer session courante

Feel free to accept / reject this patch.
With Best Regards,

I'll include the changes from the email.  Thanks!


Idea: Jasonette Builder

I've been thinking abi about json builder for jasonette.
The idea is basically using blockly  custom blocks to generate the json.
Just throwing this out here in case anyone has a better idea or maybe working on it or something similar and maybe get some feedback  before i start (in like 2 weeks)

Cool idea basically!
I'm wondering that not a web version, but only android version, do you think?
If view frames and styles were made as a local file in android or ios, it would be cool! But net info (through href) should be for server-side, I guess.

@kmarima It's early days for Jasonette so I encourage any types of integration.
I think there will be all kinds of cool tech that make total sense for Jasonette, but we won't know until we try!

IMHO node-red might be the best visual tool and it generates json when exporting selected nodes to clipboard.
What is needed is a npm package to add jasonette nodes in node-red.

@gliechtenstein I've stumbled across an example from what react-native has that is very close to what I have in mind with the builder app I started working on:

They use it as a read-only inspection tool, what i have in mind is that overlay also having a set of editing controls for all properties of the jasonette component that was touched, as well as showing the style applied to the component and the json tree its in, like the info displayed by the react-native inspector. This would allow in-place editing of the jasonette json tree in quite a visual way.
So perhaps rather than making the "builder" a module within the jasonette-android repo as I initially did, Jasonette-android could become a aar library that can then be included in other apps. This would be a different approach to the one you've so far taken with the JEM, as this would allow anyone to use jasonette along with any other "addon"  libraries. This is the approach taken by many other libraries for java & android where you have  a core library and then a number of optional libraries that you pull in via maven dependencies in your gradle config.

@maks There are two parts for this proposition:

Turn Jasonette into an AAR library
Use the AAR approach to implement Jasonette Extensions

1. Turn Jasonette into an AAR library
First, as for "Turn Jasonette into an AAR library" => I am totally a fan of this idea, as long as it doesn't complicate the regular experience. I agree it would be really cool if there's an easy way to import Jasonette into any existing app.
I kind of attempted to do something like this here http://docs.jasonette.com/advanced/#integration but as you can see it's not really user friendly and it's only for iOS. It would be great if it's just a matter of including a pod Jasonette to the Podfile (for iOS) or compile 'com.jasonette:jasonette' to the build.gradle file (for Android)
So if you would like to try that I totally support that endeavor.
2. Use the AAR approach to implement Jasonette Extensions
This is a bit tricky. As I discuss here http://docs.jasonette.com/advanced/#extension-vs-integration , each has its own pros and cons. I think an "extension" approach is much more powerful than just an integration into an existing project, because "extension" means you're extending Jasonette, so you can build your entire app using JSON, whereas "integration" means you'll end up writing native code for some parts of your app and use Jasonette for the rest, which is not as ideal as the "extension" approach.
Also, imagine this scenario: you want to quickly integrate google analytics, websockets, QR code, etc. modules altogether into your app. If we take the extension approach, everything is centered around Jasonette and all you need to do is:

Specify these Jasonette extensions
Use them with JSON markup just like the rest of Jasonette

If you were to do this in an "integration" approach, you would be importing Jasonette into your project, where you will have to implement all the google analytics, websockets, and QR code logic on your own, natively, and you won't be able to control them using JSON.
TLDR: Jasonette AAR sounds great! But I think extending Jasonette is more scalable and powerful than integrating Jasonette into existing projects. Hope this makes sense!

Yes you're right @gliechtenstein its good to deal with each part of this separately.

Great! I'll work on this. I want to make this easy too, so yes I want it to be as simple as adding a compile 'com.jasonette:jasonette' on the Android side and sounds like there is very simliar thing with pods for iOS.

Yes, the extension approach is what I had in mind when I think "integration" :-)
Definitely commonly useful functionality I want to see as aars or even standalone classes the way of you have them for JEM, I think both approaches make sense alongside each other.
Actually with "integration" the main use case I see would be existing apps where I'd want to start using Jasonette in 1 or more Activities without committing to having to rewrite the whole existing codebase in Jasonette from scratch.

I think we are in agreement here on both counts, I'll get started building.


Advanced menu handling

More fluent menu handling.

Bot can check for in what menu we currently are, where can we go and where would we go back to.

Can reuse same callback queries for different menus.

Handle 'listen callback queries' properly after a reload.
Made API much easier (using only one decorator per function instead of 3-4).

An unfortunate drawback is that menu ids are now strings, so we need to migrate the database (using Alembic) and drop a came_from_id column.

Finally made handling 'listen messages' properly after a reload.

It's pushin' time.

It's pushin' time.


[Feature Request] Create an optimizer hook for the trainer

Motivation
Optimizers are currently passed as a single object to the optimizer. In some cases, we'd like to have multiple different optimizers for a problem (for instance to update the parameters only every N operations).
Optimizers should be implemented using a hook (for instance _optimizer_hook placed in between _post_loss_hook and _post_optim_hook, and that would receive the loss as input) that would call each optimizer.
Since the loss is a TensorDict of losses, we could even contemplate the possibility of having a backward for each optim hook, and hence each optim hook would do its own backward, optim step and zero_grad over its set of parameters.
We should keep the optimizer in the args of the Trainer.__init__ method as it's convenient for the users to pass it there, but optimizer=None should be supported (then the _optimizer_hook would not see anything and would just be a no-op).
Doc: https://pytorch.org/rl/reference/trainers.html#torchrl-trainers-package

Solved by #716


Discover generated serialization tests

Following #3735 serialization tests were not discovered by cmake, I don't think this was the intended behaviour (travis still builds the tests but doesn't run them, see this build https://travis-ci.org/shogun-toolbox/shogun/jobs/213507345#L5782), this should fix it.

@vigsterkr pls merge


Observability Transport

Goals
The observability solution needs to support the scalable transport and consumption of large quantities of collected data from highly distributed sources. The data then need to be processed and stored by multiple backend solutions allowing for different ways to report and analyze the collected data.
The transmission solution needs to support following key capabilities:

Scale effectively as the number of managed clusters and instrumentation scales
Recover gracefully from failure of the transmission system
Recover gracefully from connectivity failure
Manage and reduce bandwidth consumption, allowing for queuing and compression of data
The solution must use open standard interfaces
Aggregate data within a region or user designated domain and the forward the data to a central location

Major deliverables

Scalable solution to transport data collected by the instrumentation solution (link tbd)
Ability to collect and aggregate data in a region or within a user designated domain
Ability to forward aggregated data to a central location

Acceptance criteria

The deployment of the transmission solution is scaled with the deployment of the instrumentation
The centralized components of the system can be deployed on a cluster of the platform leads choosing

Assumptions
The instrumentation of the cluster will be performed using a solution that is plugable and can support different approaches to the transport of data
User stories
As a  platform lead, I want to be able to collect data from the cluster instrumentation in a scaleable way so that I can move large quantities of observability data as efficiently as possible to a central location

Build a template with otel-collector-k8s deployment into child cluster and start sending metrics, logs and traces to mothership with OTLP.
https://github.com/open-telemetry/opentelemetry-helm-charts/tree/main/charts/opentelemetry-kube-stack

enable node-exporter
enable presets: logsCollection, kubernetesAttributes, kubeletMetrics, kubernetesEvents, clusterMetrics

Mothership should have an OTLP collector to recieve the data and collect local metrics as well. Configure processors to attribute all logs to specific clusters.
Deploy LGTM stack manually with helm on the mothership at first, pipe metrics to storage.

[ ] Clickhouse operator config
[ ] OTEL collector operator config
[ ] Clickhouse deployments
[ ] OTEL collector configs for agent and gateway deployments
[ ] CHProxy config
[ ] Test hosted control plane templates
[ ] Build child cluster template chart

Developing this on our GPU cluster, PoC commit:
https://github.com/Mirantis/ai-research/commit/6baba7465e151ffc7b1b44f2e207115e417451a0

https://github.com/Mirantis/ai-research/tree/main/ai-stack/monitoring

closing this one, will continue work in #488 and #489