Add tests for wildcard hostnames support in CertificatePinner

Part of #1454
@swankjesse PTAL

Excellent. Are the expectations correct for matching through dots? Other than that, LGTM

Sweet, this is good to merge. Unfortunately our tests are now red, so I present you two fun options!

Add another commit to implement this feature, same pull request.
Amend the current commit to add @Ignore tests for the new tests. You can implement at your leisure.

I don't think that merging tests for not implemented feature is good idea :)
I prefer 1st variant, you can close this PR and we'll reopen it when I'll prepare implementation

Works for me. Looking forward to the implementation!

@swankjesse can you please reopen this PR? I don't have access rights for that, or I can create new one  (GitHub suggests me to do so)

Comment to implementation:

Now all tests for CertificatePinner checks "hostname has pinned certificates or not".
According to this, this and RFC 6125 hostname can contain multiple * wildcard symbols, but most of Http Clients support only the complete left-most label (e.g., .example.com),  OkHostnameVerifier: "Asterisk () is only permitted in the left-most domain name label"

So with the rule "Asterisk (*) is only permitted in the left-most domain name label", I was able to implement check algorithm with complexity O(1), it's also possible to use  OkHostnameVerifier#verifyHostname(hostname, pattern) as @swankjesse suggested in #1454 but CertificatePinner#check(hostname) will have complexity O(n) where n is number of pinned hostnames, alsoOkHostnameVerifier#verifyHostname(hostname, pattern) does a lot of unneeded (for CertificatePinner) checks.
Build on Travis failed with message "The forked VM terminated without properly saying goodbye. VM crash or System.exit called" on both of environments, I can build my branch locally without problems..

(our builds are currently flaky; if your new tests pass locally then the red build is probably unrelated.)

Yep, I also merged this PR with current master -> tests pass

I like where this is going. Comments!

I'm eager to merge this, but I have a few more ideas to make it even stronger. If you're getting tired of the back & forth, just say so & I'll merge!

Rebased and squashed into one commit

Thanks!


karma 0.13.16 crashed with IE 11 on windows 10

I've just updated from 0.13.15 where everything was fine to 0.13.16 and run tests. Karma has crashed with IE runner (with chrome and firefox there are no problems):
> karma start --single-run

25 12 2015 10:42:06.907:DEBUG [config]: autoWatch set to false, because of singleRun
25 12 2015 10:42:06.914:DEBUG [plugin]: Loading karma-* from E:\Dropbox\repo\browser-id3-writer\node_modules
25 12 2015 10:42:06.918:DEBUG [plugin]: Loading plugin E:\Dropbox\repo\browser-id3-writer\node_modules/karma-chai.
25 12 2015 10:42:06.920:DEBUG [plugin]: Loading plugin E:\Dropbox\repo\browser-id3-writer\node_modules/karma-chrome-launcher.
25 12 2015 10:42:06.931:DEBUG [plugin]: Loading plugin E:\Dropbox\repo\browser-id3-writer\node_modules/karma-coverage.
25 12 2015 10:42:07.270:DEBUG [plugin]: Loading plugin E:\Dropbox\repo\browser-id3-writer\node_modules/karma-firefox-launcher.
25 12 2015 10:42:07.274:DEBUG [plugin]: Loading plugin E:\Dropbox\repo\browser-id3-writer\node_modules/karma-ie-launcher.
25 12 2015 10:42:07.321:DEBUG [plugin]: Loading plugin E:\Dropbox\repo\browser-id3-writer\node_modules/karma-mocha.
25 12 2015 10:42:07.399:DEBUG [preprocessor.coverage]: Processing "E:/Dropbox/repo/browser-id3-writer/src/browser-id3-writer.js".
25 12 2015 10:42:07.508:INFO [karma]: Karma v0.13.16 server started at http://localhost:9876/
25 12 2015 10:42:07.517:INFO [launcher]: Starting browser IE
25 12 2015 10:42:07.518:DEBUG [temp-dir]: Creating temp dir at C:\Users\12C2~1\AppData\Local\Temp\karma-54524961
25 12 2015 10:42:07.523:DEBUG [launcher]: C:\Program Files\Internet Explorer\iexplore.exe http://localhost:9876/?id=54524961
25 12 2015 10:42:07.858:DEBUG [web-server]: serving: E:\Dropbox\repo\browser-id3-writer\node_modules\karma\static/client.html
25 12 2015 10:42:07.890:DEBUG [web-server]: serving: E:\Dropbox\repo\browser-id3-writer\node_modules\karma\static/karma.js
25 12 2015 10:42:08.021:DEBUG [karma]: A browser has connected on socket SBAFIfzlxXRz6LWaAAAA
25 12 2015 10:42:08.035:DEBUG [web-server]: upgrade /socket.io/?EIO=3&transport=websocket&sid=SBAFIfzlxXRz6LWaAAAA
25 12 2015 10:42:08.082:INFO [IE 11.0.0 (Windows 10 0.0.0)]: Connected on socket SBAFIfzlxXRz6LWaAAAA with id 54524961
25 12 2015 10:42:08.085:DEBUG [launcher]: IE (id 54524961) captured in 0.576 secs
25 12 2015 10:42:08.095:DEBUG [web-server]: serving: E:\Dropbox\repo\browser-id3-writer\node_modules\karma\static/context.html
IE 11.0.0 (Windows 10 0.0.0): Executed 1 of 1 SUCCESS (0.018 secs / 0 secs)
25 12 2015 10:42:08.230:DEBUG [karma]: Run complete, exiting.
25 12 2015 10:42:08.236:DEBUG [launcher]: Disconnecting all browsers
25 12 2015 10:42:08.239:ERROR [karma]: [RangeError: Wrong length!]
RangeError: Wrong length!
    at RangeError (native)
    at strictToLength (E:\Dropbox\repo\browser-id3-writer\node_modules\core-js\modules\_typed-array.js:94:36)
    at E:\Dropbox\repo\browser-id3-writer\node_modules\core-js\modules\_typed-array.js:404:44
    at new Uint8Array (E:\Dropbox\repo\browser-id3-writer\node_modules\core-js\modules\es6.typed.uint8-array.js:3:12)
    at allocate (buffer.js:98:17)
    at new Buffer (buffer.js:49:12)
    at BufferPool.reset (E:\Dropbox\repo\browser-id3-writer\node_modules\ws\lib\BufferPool.js:57:26)
    at Receiver.endPacket (E:\Dropbox\repo\browser-id3-writer\node_modules\ws\lib\Receiver.js:247:68)
    at Receiver.opcodes.1.finish (E:\Dropbox\repo\browser-id3-writer\node_modules\ws\lib\Receiver.js:483:12)
    at Receiver.expectHandler (E:\Dropbox\repo\browser-id3-writer\node_modules\ws\lib\Receiver.js:451:33)
    at Receiver.add (E:\Dropbox\repo\browser-id3-writer\node_modules\ws\lib\Receiver.js:95:24)
    at Socket.realHandler (E:\Dropbox\repo\browser-id3-writer\node_modules\ws\lib\WebSocket.js:800:20)
    at emitOne (events.js:77:13)
    at Socket.emit (events.js:169:7)
    at readableAddChunk (_stream_readable.js:146:16)
    at Socket.Readable.push (_stream_readable.js:110:10)
25 12 2015 10:42:08.253:DEBUG [launcher]: Disconnecting all browsers
25 12 2015 10:42:08.258:DEBUG [coverage]: Writing coverage to E:/Dropbox/repo/browser-id3-writer/coverage
25 12 2015 10:42:08.457:DEBUG [launcher]: Killed extra IE process 3724
25 12 2015 10:42:08.457:DEBUG [launcher]: Process IE exited with code 0
25 12 2015 10:42:08.458:DEBUG [temp-dir]: Cleaning temp dir C:\Users\12C2~1\AppData\Local\Temp\karma-54524961
25 12 2015 10:42:08.462:DEBUG [launcher]: Finished all browsers

npm ERR! Windows_NT 10.0.10586
npm ERR! argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "run" "test"
npm ERR! node v5.3.0
npm ERR! npm  v3.3.12
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>test: `karma start --single-run`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>test script 'karma start --single-run'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the browser-id3-writer package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     karma start --single-run
npm ERR! You can get their info via:
npm ERR!     npm owner ls browser-id3-writer
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     E:\Dropbox\repo\browser-id3-writer\npm-debug.log

the same with Firefox on Mac OS:
25 12 2015 10:38:15.898:ERROR [karma]: [RangeError: Wrong length!]
RangeError: Wrong length!
    at RangeError (native)
    at strictToLength (/Users/lazhcm10348/Projects/lazada/page-manager/node_modules/karma/node_modules/core-js/modules/_typed-array.js:94:36)
    at /Users/lazhcm10348/Projects/lazada/page-manager/node_modules/karma/node_modules/core-js/modules/_typed-array.js:404:44
    at new Uint8Array (/Users/lazhcm10348/Projects/lazada/page-manager/node_modules/karma/node_modules/core-js/modules/es6.typed.uint8-array.js:3:12)
    at allocate (buffer.js:98:17)
    at new Buffer (buffer.js:49:12)
    at BufferPool.reset (/Users/lazhcm10348/Projects/lazada/page-manager/node_modules/ws/lib/BufferPool.js:57:26)
    at Receiver.endPacket (/Users/lazhcm10348/Projects/lazada/page-manager/node_modules/ws/lib/Receiver.js:247:68)
    at Receiver.opcodes.1.finish (/Users/lazhcm10348/Projects/lazada/page-manager/node_modules/ws/lib/Receiver.js:483:12)
    at Receiver.expectHandler (/Users/lazhcm10348/Projects/lazada/page-manager/node_modules/ws/lib/Receiver.js:451:33)
    at Receiver.add (/Users/lazhcm10348/Projects/lazada/page-manager/node_modules/ws/lib/Receiver.js:95:24)
    at Socket.realHandler (/Users/lazhcm10348/Projects/lazada/page-manager/node_modules/ws/lib/WebSocket.js:800:20)
    at emitOne (events.js:77:13)
    at Socket.emit (events.js:169:7)
    at readableAddChunk (_stream_readable.js:146:16)
    at Socket.Readable.push (_stream_readable.js:110:10)
25 12 2015 10:38:15.900:DEBUG [launcher]: Disconnecting all browsers
25 12 2015 10:38:16.033:DEBUG [launcher]: Process Firefox exited with code 0
25 12 2015 10:38:16.033:DEBUG [temp-dir]: Cleaning temp dir /var/folders/81/kv16vyjs3r9gyfc1dp6qhtjc0000gn/T/karma-18684574
25 12 2015 10:38:16.057:DEBUG [launcher]: Finished all browsers

npm ERR! Darwin 15.3.0
npm ERR! argv "/Users/lazhcm10348/.nvm/versions/node/v5.3.0/bin/node" "/Users/lazhcm10348/.nvm/versions/node/v5.3.0/bin/npm" "run" "task" "tdd"
npm ERR! node v5.3.0
npm ERR! npm  v3.5.3
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>task: `babel-node node_modules/.bin/start tasks/ "tdd"`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>task script 'babel-node node_modules/.bin/start tasks/ "tdd"'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the page-manager package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     babel-node node_modules/.bin/start tasks/ "tdd"
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs page-manager
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls page-manager
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/lazhcm10348/Projects/lazada/page-manager/npm-debug.log

npm ERR! Darwin 15.3.0
npm ERR! argv "/Users/lazhcm10348/.nvm/versions/node/v5.3.0/bin/node" "/Users/lazhcm10348/.nvm/versions/node/v5.3.0/bin/npm" "run" "tdd"
npm ERR! node v5.3.0
npm ERR! npm  v3.5.3
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>tdd: `npm run task tdd`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>tdd script 'npm run task tdd'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the page-manager package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     npm run task tdd
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs page-manager
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls page-manager
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/lazhcm10348/Projects/lazada/page-manager/npm-debug.log

It's probably because of upgrading core-js to 2.0.0

core-js 2.0 converts typed arrays for conformity with ES6. By ES6, you will have this error, for example, on new Uint8Array(1.5).

In Firefox 31.0.0 on Linux (Travis CI) also.

I got a same error with Karma 0.13.16 .

@falsandtru see my comment above. This is fixed by #1765 because by ES6 RangeError should be thrown here :) Missed error here - V8 bug.

@zloirock thanks for your response. Excuse me, how can we solve this problem? Won't fix?

@falsandtru rather it's not core-js issue.

Looks like the problem in ws module in BufferPool (Buffer inherited from Uint8Array).

I can't reproduce it. Most likely to Buffer constructor (-> Uint8Array) passed an invalid argument. See this part of spec.

I can't reproduce it.

It error seems caused by coverage processing.
      reporters: ['dots', 'coverage'],
      preprocessors: {
        'dist/*.js': ['coverage']
      },

It error also caused on Firefox and Chrome. Not only IE.
Windows7 x64 latest
Chrome 47.0.2526
Firefox 43.0.0

@falsandtru do you have a repo I can test with?

I got the same problem, while contributing to Angular Material, I also removed my tests (so it isn't a fault from the specs) My previous contributions yesterday worked perfectly, so it seem's to be the Commit https://github.com/karma-runner/karma/commit/6c9e2b17bdc4fbaec8e05fbf534c9a4ca4e20194)

@Dignifiedquire you can test my repo (if you have windows): https://github.com/egoroof/browser-id3-writer
npm install browser-id3-writer
npm run test

@egoroof yeah,
@Dignifiedquire simple repro:
https://github.com/falsandtru/karma-1768

I got the same error too.
Crash only happens when I enable coverage

Filed a PR to ws so this issue gets fixed at the source: https://github.com/websockets/ws/pull/645. Depending on the speed of this getting into a release I will create a release with downgraded core-js in the next days.
Thanks for the help everyone.

@Dignifiedquire thanks!

Also seeing problems.... have to revert to older version of karma unfortunately

@Dignifiedquire's PR is already merged, so now we need to wait for a quick release.

Is it possible to get the issue title updated to reflect the updated info about the bug?  Was not clear what this was when viewing the issue list (I had to find it via SO).  Thanks :heart:

@Dignifiedquire I can confirm that I encounter this issue only when running code coverage reporting after upgrading to 0.13.6 with core-js v2.0.0. Same error stack trace as shown above in the original issue.

+1. I have the same problem https://travis-ci.org/codenautas/tedede/jobs/99987514

Because it creates too many problems for you, I have temporarily removed length validation from Uint8Array in core-js 2.0.2, so you can just update core-js. I will return it when this V8 bug and bugs in all required packages will be fixed.

@zloirock thanks a lot! and sorry for all the issues, I will push a release with that version in the morning.

Should be fixed in [0.13.7] (https://github.com/karma-runner/karma/releases/tag/v0.13.17)

@Dignifiedquire thanks! It is fixed.

Thanks @Dignifiedquire for the quick turnaround!


[Batch mode] Cope with bugs that cause error suppression.

Companion to https://github.com/apple/swift/pull/23735
In batch mode, any diagnostics located in non-primary files are suppressed, with the expectation that they will surface when the containing file is compiled as primary. Although this assumption should hold, it does not always. For example, certain inputs can interact with associated type inferencing to violate it.
This PR tracks the current primary input in the DiagnosticEngine, which passed it down to the DiagnosticConsumer. The FileSpecificDiagnosticConsumer uses this information to output the diagnostic into the appropriate primary's .dia file. It addresses rdar://49303574.

Please test with following pull request:
https://github.com/apple/swift/pull/23735
@swift-ci please test os x platform

Please test with following pull request:
apple/swift#23735
@swift-ci please test linux platform

@swift-ci please test

Please test with following pull request:
apple/swift#23735
@swift-ci please test


Yarn install script is wrong

The value under the installation section for yarn is wrong.
It should be
yarn add @piotr-cz/swr-idb-cache
instead of
yarn add @piotr-cz/@piotr-cz/swr-idb-cache

Thanks, fixed in #7a9f176


Enable jwt in typescript policies

This PR introduces support for JWT in typescript policies.
JWT are passed in the the Authorization: Bearer <TOKEN> header of the request.
A public signature verification must be passed in the CHISEL_JWT_KEY. The key must be a valid RSA PEM key, that is stripped of its header and footer, and all lines concatenated: eg
-----BEGIN PUBLIC KEY-----
kasfgfaksdfjlkajshfasd
fjkhaskldjfhaskljhdfka
-----END PUBLIC KEY-----

becomes:
kasfgfaksdfjlkajshfasdfjkhaskldjfhaskljhdfka

The algorithm being used to sign the keys is RS256.
All of these format and algorithm choices have been made to work out of the box with Clerk. Additional algorithm and key format could be added in the future.
The token can contain arbitrary user data.
If the token is validated, then it is accessible to the policy, in the request context:
claims:
{
    "userId": "marin" ,
    "expiresAt":<PHONE_NUMBER>
}

export default {
    read: (entity, ctx) => {
            if ctx.token.userId == "marin" {
                return Action.Allow;
            }
    }
}

Expiration of the token is verified from rust.

@MarinPostma I am wondering if the need to make the key a string isn't a usability issue? Everywhere else I've seen people just either upload a file, or at least will paste the entire thing.

@glommer this is how clerk does it https://clerk.dev/docs/request-authentication/validate-session-tokens
This API needs refining, let's figure that out later. This is still experimental, and this is part of what needs to be addressed for stabilization

We need to clearly define how users are gonna use this feature, but hiking to secrets seems like the natural way forward for now

ok. If this is how clerk does it (it's the first time I see this in the open), let's do the same, but I'd point to their docs everywhere.

who should review this so we can write an example ?


Hidden wizard steps are focusable

Package
filament/filament
Package Version
v3.2.85
Laravel Version
10.48.12
Livewire Version
v3.5.0
PHP Version
8.1.26
Problem description
When using the Filament Wizard in accessibility mode or when navigating with the keyboard (tabbing), the form fields on the first step tab into the hidden fields of the second step instead of moving to the "Next" button. This behavior disrupts the form-filling process and impacts the accessibility and usability of the wizard.
Note: This issue does not occur in version v3.2.63; the tabbing functionality works as expected in that version.
Expected behavior
When filling out the forms in the first step of the wizard, tabbing should sequentially move through all the form fields and then to the "Next" button. Only after clicking the "Next" button should the focus move to the fields in the second step.
Steps to reproduce

Activate accessibility mode or navigate using the keyboard (tab key).
Fill out any form fields in the first step of the Filament Wizard.
Observe that tabbing skips to the hidden fields in the second step instead of the "Next" button.
Notice that the second step fields are tab-accessible even though they are not visible.

Reproduction repository
https://github.com/izzudin96/filament-a11y
Relevant log output
No response

Donate 💰 to fund this issue

You can donate funding to this issue. We receive the money once the issue is completed & confirmed by you.
100% of the funding will be distributed between the Filament core team to run all aspects of the project.
Thank you in advance for helping us make maintenance sustainable!

Link to wizard: https://github.com/izzudin96/filament-a11y/blob/0c5ca9f54aaed9a945f61300f950858f44763929/app/Filament/Resources/PatientResource.php#L26C12-L27C6

Might this be related to https://github.com/filamentphp/filament/pull/12985 (@sebapastore)?
Could you check if this issue occurs in Filament v3.2.84 too, @izzudin96?

Hi @zepfietje,
Thanks for the reply.
I had a quick look on version 3.2.84 and it seems like it is working as expected.

Thanks for checking, @izzudin96!
This confirms this bug is caused by the changes in https://github.com/filamentphp/filament/pull/12985. Marking this as high priority.
CC @danharrin @sebapastore

I will look into it now!


How to programmatically change modes?

Let's say I have a CM instance with text. User changes text in insert mode. I then update the value in CM editor and want to change the mode from insert to normal mode, how do I do that?
Here's a demo:

I want to change to normal mode after the answer is correct. I'm not sure exactly how to do that. Can I call a method or something on CodeMirror and tell it to change modes?

There is no cm6 style api, but you can use the old cm5 api
import {Vim} from "@replit/codemirror-vim"

var view = new EditorView({...})
Vim.exitInsertMode(view.cm)

or
Vim.handleKey(_view.cm, "<Esc>")

Hmm...I must be missing something. TypeScript says that .cm does not exist on view. What am I doing wrong?

https://codesandbox.io/s/cm6-vim-test-mq5m9?file=/src/index.ts

You are right. cm property exists on the js object, and in typescript can be used with a hack like (view as any).cm.
I am not sure what can we do to extend the EditorView in a way that would not break type system.
Maybe we should export getCm(view: EditorView): CodeMirror|null function similar to https://codemirror.net/6/docs/ref/#search.getSearchQuery

Hooray! That worked. Thank you. I like the idea of having a hook called getCm where you pass in an EditorView.
That sounds nice.
Thank you very much for the two solutions and the fast reply.

fixed in https://github.com/replit/codemirror-vim/commit/1ad745316b6987e0569d46a5d67c0263191d63af

@nightwing when will you publish a new version with these changes? (may I suggest this)

Thanks @jsjoeio! Just published an update to the NPM package with the above commit included. Feel free to upgrade to v0.19.0-beta.7 and let us know if something's not working!

Will do - thank you @sergeichestakov!


Change all 'Nuttx' to 'NuttX;

Summary
Unify the naming convention.
Impact
Testing

@xiaoxiang781216
What do you want to do about the kconfig changes? We need to either update the defconfigs or leave them as is
 ====================================================================================
Configuration/Tool: stm3210e-eval/usbserial,CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
------------------------------------------------------------------------------------
  Cleaning...
  Configuring...
  Disabling CONFIG_ARMV7M_TOOLCHAIN_BUILDROOT
  Enabling CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
  Building NuttX...
  Normalize stm3210e-eval/usbserial
28d27
< CONFIG_PL2303_VENDORSTR="NuttX"
Saving the new configuration file
HEAD detached at pull/2033/merge
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   boards/arm/stm32/stm3210e-eval/configs/usbserial/defconfig

@xiaoxiang781216
What do you want to do about the kconfig changes? We need to either update the defconfigs or leave them as is
 ====================================================================================
Configuration/Tool: stm3210e-eval/usbserial,CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
------------------------------------------------------------------------------------
  Cleaning...
  Configuring...
  Disabling CONFIG_ARMV7M_TOOLCHAIN_BUILDROOT
  Enabling CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
  Building NuttX...
  Normalize stm3210e-eval/usbserial
28d27
< CONFIG_PL2303_VENDORSTR="NuttX"
Saving the new configuration file
HEAD detached at pull/2033/merge
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   boards/arm/stm32/stm3210e-eval/configs/usbserial/defconfig

I remove  CONFIG_PL2303_VENDORSTR from defconfig and use the default value from drivers/usbdev/Kconfig.


TimerRef from TimerWithThread::for_uuid_closures is not cloneable

The TimerRef returned from TimerWithThread::for_uuid_closures() is not cloneable because OneShotClosureState and PeriodicClosureState are not cloneable. Even though TimerRef is:
#[derive(Clone)] // <-----------------
pub struct TimerRef<I, O, P>
where
    I: Hash + Clone + Eq,
    O: OneshotState<Id = I>,
    P: PeriodicState<Id = I>,
{
    work_queue: channel::Sender<TimerMsg<I, O, P>>,
}

A small inconvenience but this means some structuring limitations. For example, TimerRef implements Timer but TimerWithThread does not, so in practice I can't abstract the Timer implementation away using generics and have to keep the TimerWithThread around. Just a minor suggestion :)

Took another look at the impl dont think it's possible since it's holding a closure.

Hmm, actually it's just holding the channel::Sender, no? Which should be cloneable. The rest is just part of the type definition of the messages carried on the channel. But that shouldn't affect whether the TimerRef is cloneable.
I'll try to look into it on the weekend.

Yeah, this is because I derive the Clone implementation, and Rust is very conservative and only implements traits if all generic types also implement it. But I can fix it by just implementing clone manually instead, as long as channel::Sender has the correct Clone implementation (i.e., also ignoring the type of the message).

Thanks!

The fix is merged and released in version 1.3.0


Can the shortcut be customized?

It would be great if the app shortcut can be changed from Alt+Space to something else.

I agree. That's one of the features I've planned for the next version, but I've been distracted with other projects lately, so the development of the new Olden, which is going to be a pretty significant update, is going very slowly.


Repository renaming feature.

@neel1996

Require the backend module explanation.

@neel1996 Can this issue be closed?

@neel1996 Can this issue be closed?


Buy me a coffee should not have text on mobile

The top bar is crowded on mobile. I don't like how 'in your face' the 'buy me a coffee' text is on mobile.


v3 alpha 2 from master or v3-dev?

Issue type:

[ ] Feature request
[x] Bug report
[ ] Documentation

Environment:

AdminLTE Version:  v3.0.0-alpha-2
Operating System:  N/A
Browser (Version):  N/A

Description:

The v3 alpha 2 release seems to be cut from master. It probably should have been from v3-dev branch

ugh why do I keep doing this! Thanks for reporting @jugalthakkar
It's not been fixed!


Problem with multiple permissions

I cannot request more than two permissions in the way suggested in the docs.
Here's my permission request code:
public boolean reqPerms()
{
Permiso.getInstance().requestPermissions(new Permiso.IOnPermissionResult() {
@Override
public void onPermissionResult(Permiso.ResultSet resultSet) {
if (resultSet.isPermissionGranted(Manifest.permission.READ_SMS)){//Some code}
if(resultSet.isPermissionGranted(Manifest.permission.READ_CALL_LOG)){//Some code}
if(resultSet.isPermissionGranted(Manifest.permission.READ_PHONE_STATE)){//Some code}
if(resultSet.isPermissionGranted(Manifest.permission.INTERNET)){//Some code}
if(resultSet.isPermissionGranted(Manifest.permission.ACCESS_FINE_LOCATION)){}
//tv.setText("Permissions granted");
}
@Override
public void onRationaleRequested(Permiso.IOnRationaleProvided callback, String... permissions) {
Permiso.getInstance().showRationaleInDialog("Permissions req", "App won't function without permissions!", null, callback);
}
}, Manifest.permission.READ_SMS, Manifest.permission.READ_PHONE_STATE,Manifest.permission.READ_CALL_LOG,Manifest.permission.INTERNET);
return true;
}

I just tested your snippet and it works fine for me. Have you made sure to declare your permissions in your AndroidManifest.xml? That's a regular thing you have to do with permissions. I'll add that to the readme.

Done.

I'm going to assume this was your issue, as I couldn't reproduce it otherwise with your snippet. Please re-open this if you're still having difficulties!
Thanks!

Hello Greyson
I've fixed my code. I didn't realize that permissions were being grouped.
On Fri, May 6, 2016, 05:23 Greyson Parrelli<EMAIL_ADDRESS>wrote:

Closed #12 https://github.com/greysonp/permiso/issues/12.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/greysonp/permiso/issues/12#event-652110445

Thanks for taking your time to resolve the issue!
On Sat, May 7, 2016, 00:11 Suraj Subraveti<EMAIL_ADDRESS>wrote:

Hello Greyson
I've fixed my code. I didn't realize that permissions were being grouped.
On Fri, May 6, 2016, 05:23 Greyson Parrelli<EMAIL_ADDRESS>wrote:

Closed #12 https://github.com/greysonp/permiso/issues/12.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/greysonp/permiso/issues/12#event-652110445


Bug!!  A geometric part of the mobile terminal will disappear about 100 meters from the ground

When I set the ground geometry, part of the geometry disappears when the camera zooms in to a certain distance；
This is the effect of the official example opened on the mobile terminal
https://sandcastle.cesium.com/gallery/Materials.html

It will trigger when zoomed in to a certain level
all  mobile terminal

@PZD2937 Thanks for opening an issue. I can see that the red rectangle also disappears when zooming in enough on my desktop browser - are you able to replicate the same issue on mobile and on desktop too?

Of course, I can reproduce this problem on all my test mobile terminals, but my PC terminal does not have this problem. My browser version is Google Chrome 93.

@PZD2937 Thanks for opening an issue. I can see that the red rectangle also disappears when zooming in enough on my desktop browser - are you able to replicate the same issue on mobile and on desktop too?

Of course, I can reproduce this problem on all my test mobile terminals, but my PC terminal does not have this problem. My browser version is Google Chrome 93.

excuse me？

Hi @PZD2937, there's no update on this issue yet.
I think this is a duplicate of https://github.com/CesiumGS/cesium/issues/9702. There is more info about this bug in that issue. I'm going to close this issue so we can track it in one place. Thank you!


Provide drag&drop image saving for HTMLField

In the docs you read

Drag & Drop Images
In IE and Firefox based browsers it is possible to drag and drop a picture into the text editor. This image is base64 encoded and lives in the 'src' attribute as a 'data' tag.
We detect this images, encode them and convert them to picture plugins

That's a great feature, but as far as I've seen, if I'm not mistaken, this works only with plugins, that means, if you have a text area in your plugin, you will be able to save dragged&dropped images.
On the other hand this feature is not provided for HTMLField, so if you want to use that in your models, you'll have the same ckeditor window, but saving drag&drop images won't work. It would be nice to have extract_images be involved with HTMLField.

Given how currently the image inclusion works in this plugin (i.e.: by using plugins) it's not currently possible to implement drag and drop in HTMLField.
This will require an entirely different strategy to support images in HTMLField

closed in favour of #285


First-time users may get confused about the need to unpack vulnerabilities from a ZIP archives

Once a ZIP archive is uploaded, its name appears in the UI, along with 3 buttons (download, unpack, and delete). Now, a first-tie user may not understand he/she needs to unpack the archive first, and proceed immediately to Submit or Submit all uploaded, resulting in JSON parser choking on a ZIP header:

There're three possible solutions for this problem

Automatically unpack any ZIP content before attempting to parse JSON (probably unsuitable, since the user needs to see what exactly he/she is uploading)
Hide or disable the Submit... buttons until at least a single JSON is unpacked or selected.
Leave the Submit... buttons enabled, but prompt the user via "You may have forgotten to unpack the content of %s.zip and %s.zip" or smth like this.

Additionally:  archives should be at top of the list and should be not applicable for submitting


fix: field radios showing asterisk for required status

Response to #50

Thanks @d-campbell-bs :)


Integrate with healthchecks.io

Would be a good idea to add integration with healthchecks to monitor the schedules

added good first issue label since this is a relatively easy thing to implement


ARROW-5790: [Python] Raise error when trying to convert 0-dim array in pa.array

https://issues.apache.org/jira/browse/ARROW-5790
In the NumPyConverter constructor, we access the strides of the array with PyArray_STRIDES(arr_)[0], so need to ensure that the array is 1D before passing it there.

CI error is unrelated.


Identify and select a DataDAO that aligns with the project's objectives, establishing collaboration.

Investigate the following and decide it

Option 1: Propose a mechanism to connect to OpenSci (https://github.com/opscientia/society-home)

https://github.com/opscientia/commons-backend/blob/main/README.md#architecture-diagrams
metadata sotred web2
cannot find evaluation,  reputaion part  , maybe there are in the web2 side.

Option 2: Propose a mechanism to connect to Kangaroo Dao (https://github.com/kangaroo-data-dao/kangaroo-data-dao)
Option 3 : Using existing data on IPFS, create a DataDAO for demonstration purposes by extending the following (https://github.com/kozayupapa/fevm-data-dao-kit) (https://datasets.filecoin.io/)

https://github.com/data-preservation-programs/slingshot
Another option is that the data is already accumulated, and the system can simply make a rating on this data set, or search for a rating later that is tied to the data in the CID
Survey of similar services, benchmark

https://lagrangedao.org/dataset

https://docs.lagrangedao.org/lagrange-dao/decentralized-auction-marketplace
https://github.com/lagrangedao

https://github.com/opscientia/society-home

https://github.com/data-preservation-programs/slingshot


OOPS - Operator Overloading [Updated README and removed all cpp files but one]

Related Issue

Issue #491

Proposed Changes

Changes from PR #506:
Updated README file according to instructions
Added only the CPP for binary operator overloading and removed other files (will make seperate PRs for them)
Updated the CPP file to show more descriptive output.

Checklist

[x] ✅ My code follows the code style of this project.
[ ] 📝 My change requires a change to the README.
[x] 🎀 I have updated the README accordingly.
[x] 👀 I have read the CONTRIBUTING document.
[x] ✨ I have added tests to cover my changes.
[x] 🚩 All new and existing tests passed.
[x] 🌟 ed the repo

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Output Screenshots

Screenshot #1

Binary Operator Overloading

YOUR README looks good , mentors will review your PR shortly stay tuned ...

Noted, will update it

Kindly review after updates

Solved conflict, kindly review @miraj0507

@all-contributors please add @alyeyad code ,


Add jshint and editor config

What do you think adding:

.jshintrc
.editorconfig
.jscrc

I think that is a good addition for this repo. Maybe you could use https://github.com/airbnb/javascript this one for .jshintrc?


Subscription not found

When I run quick start hubot,I got this error, what wrong with me?
`
[Fri Jul 01 2016 01:12:03 GMT+0000 (UTC)] INFO Connecting To: <IP_ADDRESS>:3000
[Fri Jul 01 2016 01:12:03 GMT+0000 (UTC)] INFO Successfully connected!
[Fri Jul 01 2016 01:12:03 GMT+0000 (UTC)] INFO GENERAL
[Fri Jul 01 2016 01:12:03 GMT+0000 (UTC)] INFO Logging In
[Fri Jul 01 2016 01:12:03 GMT+0000 (UTC)] INFO Successfully Logged In
[Fri Jul 01 2016 01:12:03 GMT+0000 (UTC)] INFO Looking up Room ID for: GENERAL
[Fri Jul 01 2016 01:12:03 GMT+0000 (UTC)] INFO Joining Room: GENERAL
[Fri Jul 01 2016 01:12:03 GMT+0000 (UTC)] INFO rid:  [ 'GENERAL' ]
[Fri Jul 01 2016 01:12:03 GMT+0000 (UTC)] INFO All rooms joined.
[Fri Jul 01 2016 01:12:03 GMT+0000 (UTC)] INFO Successfully joined room: GENERAL
[Fri Jul 01 2016 01:12:03 GMT+0000 (UTC)] INFO Preparing Meteor Subscriptions..
[Fri Jul 01 2016 01:12:03 GMT+0000 (UTC)] INFO Subscribing to Room:  my_messages
[Fri Jul 01 2016 01:12:03 GMT+0000 (UTC)] ERROR Unable to subscribe: {"error":404,"reason":"Subscription not
found","message":"Subscription not found [404]","errorType":"Meteor.Error"} Reason: Subscription not found
[Fri Jul 01 2016 01:12:03 GMT+0000 (UTC)] ERROR {"error":404,"reason":"Subscription not
found","message":"Subscription not found [404]","errorType":"Meteor.Error"}
[Fri Jul 01 2016 01:12:03 GMT+0000 (UTC)] ERROR Unable to complete setup. See https://github.com/RocketChat/
hubot-rocketchat for more info.
`
Why this subscribe "my_messages", some one can help me

Looks like you grabbed a new version of the adapter.  Please grab version 0.1.4 of the adapter and try again :)

I'm having this issue on 0.1.4 as well. I think its more than just the Adapter version, but a mismatch with current RC version 0.35.0 (or develop branch), due to updates in the stream module.
I think version mismatches are leading to a bunch of issues being reported, because as far as I can tell:

Adapter 0.1.4 safe with RC <= 0.34
Adapter 1.0.0 had issues with all RC versions at time of release <= 0.35.0
Adapter 1.0.1 seems the same, not sure
Adapter #master post-release changes fix issues with RC >= 0.35.0

Need @geekgonecrazy to clarify. Maybe pin a note to the Readme?

Oops, there's actually already a note on readme, but maybe needs some more details about the specific version mismatches and to help anyone who might want to assist fixing the current mess.
Far as I can tell its due to incompatible updates to the streamer package within RC. The adapter uses Asteroid's subscribe method to hook into room subscriptions set up by the RC streamer. The newer versions of the adapter (v1+) don't work with the old streamer (in RC releases) but if you're on RC develop branch, you need the v1+ adapter to work with the updated streamer.
@geekgonecrazy Is that remotely correct??

Confirming the details as discussed on RC demo with @Sing-Li. Here's the error log, running a fresh yo generated hubot with adapter 0.1.4 on RC #develop (post 0.35.0) branch.
[Wed Jul 20 2016 15:41:33 GMT+1000 (AEST)] DEBUG Loading adapter rocketchat
[Wed Jul 20 2016 15:41:33 GMT+1000 (AEST)] INFO Starting Rocketchat adapter version 0.1.4...
[Wed Jul 20 2016 15:41:33 GMT+1000 (AEST)] INFO Once connected to rooms I will respond to the name: test
[Wed Jul 20 2016 15:41:33 GMT+1000 (AEST)] INFO I will also respond to my Rocket.Chat username as an alias: testbot
[Wed Jul 20 2016 15:41:33 GMT+1000 (AEST)] INFO Connecting To: localhost:3000
[Wed Jul 20 2016 15:41:33 GMT+1000 (AEST)] INFO Successfully connected!
[Wed Jul 20 2016 15:41:33 GMT+1000 (AEST)] INFO newsfeed
[Wed Jul 20 2016 15:41:33 GMT+1000 (AEST)] INFO Logging In
[Wed Jul 20 2016 15:41:33 GMT+1000 (AEST)] INFO Successfully Logged In
[Wed Jul 20 2016 15:41:33 GMT+1000 (AEST)] INFO Looking up Room ID for: newsfeed
[Wed Jul 20 2016 15:41:33 GMT+1000 (AEST)] INFO Joining Room: GENERAL
[Wed Jul 20 2016 15:41:33 GMT+1000 (AEST)] INFO rid:  [ 'GENERAL' ]
[Wed Jul 20 2016 15:41:33 GMT+1000 (AEST)] INFO All rooms joined.
[Wed Jul 20 2016 15:41:33 GMT+1000 (AEST)] INFO Successfully joined room: GENERAL
[Wed Jul 20 2016 15:41:33 GMT+1000 (AEST)] INFO Preparing Meteor Subscriptions..
[Wed Jul 20 2016 15:41:33 GMT+1000 (AEST)] INFO Subscribing to Room: GENERAL
[Wed Jul 20 2016 15:41:33 GMT+1000 (AEST)] ERROR Unable to subscribe: {"error":404,"reason":"Subscription not found","message":"Subscription not found [404]","errorType":"Meteor.Error"} Reason: Subscription not found
[Wed Jul 20 2016 15:41:33 GMT+1000 (AEST)] ERROR {"error":404,"reason":"Subscription not found","message":"Subscription not found [404]","errorType":"Meteor.Error"}
[Wed Jul 20 2016 15:41:33 GMT+1000 (AEST)] ERROR Unable to complete setup. See https://github.com/RocketChat/hubot-rocketchat for more info.

By default yoeman uses "hubot-rocketchat": "^1.0.1", which actually works on the current #develop branch.
[Wed Jul 20 2016 15:44:45 GMT+1000 (AEST)] DEBUG Loading adapter rocketchat
[Wed Jul 20 2016 15:44:46 GMT+1000 (AEST)] INFO Starting Rocketchat adapter version 1.0.1...
[Wed Jul 20 2016 15:44:46 GMT+1000 (AEST)] INFO Once connected to rooms I will respond to the name: test
[Wed Jul 20 2016 15:44:46 GMT+1000 (AEST)] INFO I will also respond to my Rocket.Chat username as an alias: testbot
[Wed Jul 20 2016 15:44:46 GMT+1000 (AEST)] INFO Connecting To: localhost:3000
[Wed Jul 20 2016 15:44:46 GMT+1000 (AEST)] INFO Successfully connected!
[Wed Jul 20 2016 15:44:46 GMT+1000 (AEST)] INFO
[Wed Jul 20 2016 15:44:46 GMT+1000 (AEST)] INFO Logging In
[Wed Jul 20 2016 15:44:46 GMT+1000 (AEST)] INFO Successfully Logged In
[Wed Jul 20 2016 15:44:46 GMT+1000 (AEST)] INFO rid:  []
[Wed Jul 20 2016 15:44:46 GMT+1000 (AEST)] INFO All rooms joined.
[Wed Jul 20 2016 15:44:46 GMT+1000 (AEST)] INFO Preparing Meteor Subscriptions..
[Wed Jul 20 2016 15:44:46 GMT+1000 (AEST)] INFO Subscribing to Room: __my_messages__
[Wed Jul 20 2016 15:44:46 GMT+1000 (AEST)] INFO Successfully subscribed to messages
[Wed Jul 20 2016 15:44:46 GMT+1000 (AEST)] INFO Setting up reactive message list...
[Wed Jul 20 2016 15:44:46 GMT+1000 (AEST)] DEBUG Loading scripts from /Volumes/Code/git/timkinnane/test-bot/scripts
[Wed Jul 20 2016 15:44:46 GMT+1000 (AEST)] DEBUG Parsing help for /Volumes/Code/git/timkinnane/test-bot/scripts/example.coffee
[Wed Jul 20 2016 15:44:46 GMT+1000 (AEST)] DEBUG Loading scripts from /Volumes/Code/git/timkinnane/test-bot/src/scripts
[Wed Jul 20 2016 15:44:46 GMT+1000 (AEST)] DEBUG Loading hubot-scripts from /Volumes/Code/git/timkinnane/test-bot/node_modules/hubot-scripts/src/scripts
[Wed Jul 20 2016 15:44:46 GMT+1000 (AEST)] WARNING Loading scripts from hubot-scripts.json is deprecated and will be removed in 3.0 (https://github.com/github/hubot-scripts/issues/1113) in favor of packages for each script.

It successfully joins and responds to commands. However, the debug logs could be improved, e.g. INFO rid:  [] looks like its got an empty array of rooms and INFO Subscribing to Room: __my_messages__ seems misleading as there's no room called _my_messages_, I'm assuming that's the key for the Asteroid subscription.
Interestingly, when I set export LISTEN_ON_ALL_PUBLIC=false the bot reports more accurately: INFO rid:  [ 'GENERAL' ] and INFO Successfully joined room: GENERAL.
It seems like setting LISTEN_ON_ALL_PUBLIC=true overrides the ROCKETCHAT_ROOM list, maybe by design - however that isn't helpful if you've want the bot to join a private room.

Switching back to RC #master 0.35.0 with Hubot 0.1.4 works, so the problem is definitely with changes on #develop since 0.35.0.
FYI, If anyone want to repeat that test, here's the clean slate bot I used.
https://github.com/timkinnane/test-bot

Ok. That explains why there is no mass uproar.  Since 0.35.0 is still 0.1.4 compatible.
We need to get the story straight before 0.36.0 though.   Thanks for your work @timkinnane !

Aaaaand I guess I shouldn't have upgraded to 0.36.0 ;;
I tried -1.0.1, but now instead of the subscription error, any messages just result in this in the log:
[Wed Aug 03 2016 09:16:08 GMT-0700 (PDT)] INFO Message received with ID id

(and no response)
Anyone know if it's safe (db migration-wise) to switch back to using RC 0.35.0?

Oh, correction - messages in channels work (addressed & otherwise), but DMs to the bot don't

I upgraded to 0.36 and neither DMs or channels work.
hubot-3 [Wed Aug 03 2016 18:48:53 GMT-0400 (CLT)] ERROR Unable to subscribe: {"error":404,"reason":"Subscription not found","message":"Subscription not found [404]","errorType":"Meteor.Error"} Reason: Subscription not found
hubot-3 [Wed Aug 03 2016 18:48:53 GMT-0400 (CLT)] ERROR {"error":404,"reason":"Subscription not found","message":"Subscription not found [404]","errorType":"Meteor.Error"}
hubot-3 [Wed Aug 03 2016 18:48:53 GMT-0400 (CLT)] ERROR Unable to complete setup. See https://github.com/RocketChat/hubot-rocketchat for more info.

Any clues? Thanks!.

@chispaa as i noted, hubot-rocketchat 1.0.1 works better, but DMs still don't work

@dbushong how would one use 1.0.1?
I don't see any tags beyond 0.1.4
I'm using docker-compose and an a little annoyed with the breakage running the stable rocke chat image.

@mrplow you would have to define the source in package.json to specify the branch that is ahead of 0.1.4, or even the specific commit on that branch at 1.0.1 - I'm not sure if there's a risk using the head of that branch.
Or you could just stay on RC 0.35.0. That's probably easier and more stable.
I'm quite surprised 0.36.0 was actually released with the hubot incompatibility hang-over remaining.

I tried using the Rocket Chat docker version specified on the commit https://github.com/RocketChat/hubot-rocketchat/commit/195ac6a086e4bd7c6390abb5b6164c10a48aba54 but it's still giving me an error.
Live Guinea Pig (Test server):
Thu Aug 04 2016 15:15:40 GMT+0000 (UTC)] INFO Starting Rocketchat adapter version 0.1.4...
[Thu Aug 04 2016 15:15:40 GMT+0000 (UTC)] INFO Once connected to rooms I will respond to the name: bebot
[Thu Aug 04 2016 15:15:40 GMT+0000 (UTC)] INFO Connecting To: devopshq.org
[Thu Aug 04 2016 15:15:40 GMT+0000 (UTC)] INFO Successfully connected!
[Thu Aug 04 2016 15:15:40 GMT+0000 (UTC)] INFO devops_corner
[Thu Aug 04 2016 15:15:40 GMT+0000 (UTC)] INFO Logging In
[Thu Aug 04 2016 15:15:40 GMT+0000 (UTC)] INFO Successfully Logged In
[Thu Aug 04 2016 15:15:40 GMT+0000 (UTC)] INFO Looking up Room ID for: devops_corner
[Thu Aug 04 2016 15:15:40 GMT+0000 (UTC)] INFO Joining Room: GENERAL
[Thu Aug 04 2016 15:15:40 GMT+0000 (UTC)] INFO rid:  [ 'GENERAL' ]
[Thu Aug 04 2016 15:15:40 GMT+0000 (UTC)] INFO All rooms joined.
[Thu Aug 04 2016 15:15:40 GMT+0000 (UTC)] INFO Successfully joined room: GENERAL
[Thu Aug 04 2016 15:15:40 GMT+0000 (UTC)] INFO Preparing Meteor Subscriptions..
[Thu Aug 04 2016 15:15:40 GMT+0000 (UTC)] INFO Subscribing to Room: GENERAL
[Thu Aug 04 2016 15:15:40 GMT+0000 (UTC)] ERROR Unable to subscribe: {"error":404,"reason":"Subscription not found","message":"Subscription not found [404]","errorType":"Meteor.Error"} Reason: Subscription not found
[Thu Aug 04 2016 15:15:40 GMT+0000 (UTC)] ERROR {"error":404,"reason":"Subscription not found","message":"Subscription not found [404]","errorType":"Meteor.Error"}
[Thu Aug 04 2016 15:15:40 GMT+0000 (UTC)] ERROR Unable to complete setup. See https://github.com/RocketChat/hubot-rocketchat for more info.

The bot seems to be active as it shows a green status in the chatroom...
Just for the record, here is what docker ps -a shows.
$ docker ps -a
CONTAINER ID        IMAGE                                COMMAND                  CREATED             STATUS              PORTS                    NAMES
61ce10336454        rocketchat/hubot-rocketchat:v0.1.4   "/bin/sh -c 'node -e "   15 minutes ago      Up 15 minutes       <IP_ADDRESS>:3001->8080/tcp   rocketchat_hubot_1
48cbb6ee1a9d        rocketchat/rocket.chat:latest        "node main.js"           16 minutes ago      Up 16 minutes       <IP_ADDRESS>:3000->3000/tcp   rocketchat_rocketchat_1
cc0813ad25f2        mongo:3.0                            "/entrypoint.sh mongo"   16 minutes ago      Up 16 minutes       27017/tcp                rocketchat_db_1

I've done some testing and it seems like adapter version 0.1.4 (which is current master) no longer works with Rocket.Chat master 0.36.0.
Therefore you are required to downgrade either Rocket.Chat or the adapter for stability.
Some results testing adapter versions with RC master 0.36.0:
0.1.4 (master)
ERROR {"error":404,"reason":"Subscription not found","message":"Subscription not found [404]","errorType":"Meteor.Error"}

Can connect to RC and appears as online, but doesn't respond because subscription broken.
^1.0.1 (generator default)
[Fri Aug 05 2016 15:29:01 GMT+1000 (AEST)] INFO rid:  []
[Fri Aug 05 2016 15:29:01 GMT+1000 (AEST)] INFO Subscribing to Room: __my_messages__

Works, but has log errors as above. Seems like its not getting room names properly.
Streams branch (current development)
Setting dependency as "hubot-rocketchat": "git://github.com/RocketChat/hubot-rocketchat#streams"
As above, works fine, has log errors.
@Sing-Li @geekgonecrazy - can either of you comment on when/how this will be resolved.
Is the solution to release 1.0.1 as master, so at least both RC master and adapter master work together? Then fix the log errors in next patch?
I'd suggest a prominent warning in the readme, to run v0.1.4 if using RC version <0.35.0

It broke it for us as well.

0.36.0 was not anticipated to have breaking changes for hubot.
@rodrigok   has the "message" subscription been removed/disabled/renamed from 0.36.0 for some reason?    Thanks.

@Sing-Li I believe the issues were identified on RC develop branch before the release.
Is there a process or guideline for releases to ensure stability with corresponding adapter versions? For instances reliant on Hubot compatibility like ours, this is making it quite complicated to stay current and even contributing is becoming challenging, re needing to keep rolling back for testing RC with adaptor and forward for submitting PRs.

@timkinnane  are you saying:

the issue no longer exists with the actual 0.36.0 release

OR

the issues were identified early -- so we should have smoothed out the transition by announcing the required changes beforehand  ?

Thanks for clarifying 😄

The issue definitely exists on 0.36.0 our bot is currently useless.

@Sing-Li Our master and development branch should be working with hubot, we didn't merge the cache branch yet.

@Sing-Li @twhiting I just tried the hubot with our develop branch, it's working

Hmm any idea why i'd be getting this error then? The only thing that changed from a working bot to now is upgrading rocketchat to 0.36.0.
[Tue Aug 09 2016 16:29:13 GMT-0600 (Mountain Daylight Time)] INFO Preparing Meteor Subscriptions..
[Tue Aug 09 2016 16:29:13 GMT-0600 (Mountain Daylight Time)] INFO Subscribing to Room: gFASS3j4A8u85WiHX
[Tue Aug 09 2016 16:29:13 GMT-0600 (Mountain Daylight Time)] ERROR Unable to subscribe: {"error":404,"reason":"Subscription not found","message":"Subscription not found [404]","errorType":"Meteor.Error"} Reason: Subscription not found
[Tue Aug 09 2016 16:29:13 GMT-0600 (Mountain Daylight Time)] ERROR {"error":404,"reason":"Subscription not found","message":"Subscription not found [404]","errorType":"Meteor.Error"}
[Tue Aug 09 2016 16:29:13 GMT-0600 (Mountain Daylight Time)] ERROR Unable to complete setup. See https://github.com/RocketChat/hubot-rocketchat for more info.

The bot won't respond to any commands but still shows as "online"

@twhiting awesome, please let us know if this fixed your issue.

@rodrigok see my update, still having issues. Not sure why.

@twhiting the version you should use is the latest version 1.0.1, not 0.1.4

@Sing-Li, I was responding to your comment...

0.36.0 was not anticipated to have breaking changes for hubot.

That seemed incorrect because the issues were previously identified before 0.36.0. You said yourself, 20 days prior:

We need to get the story straight before 0.36.0

But there was no resolution before 0.36.0 release, it just cemented the current issues.
Perhaps its just a miscommunication of issues with RC vs issues with adapter.
@rodrigok please see my comment detailing issues with 1.0.1. It works better than the 0.1.4 with RC 0.36.0, but there's still some log errors and the 1.0.1 release should probably be made on the master branch of this repo if that's the current best version, no?

@timkinnane which errors do you have with version 1.0.1?

@rodrigok basically everyone was using 0.1.4 with 0.35.0
So with 0.36.0 we need to use 1.0.1 ?   Has improvement/more-stream been merged down with 0.36.0 then?
@timkinnane   we're trying to work out what got merged into core (the hubot adapter MUST match) ... and what gets merged down (unfortunately) is frequently a last minute decision

@Sing-Li As I said before, we didn't merge the improvement/more-stream into develop, we will do it tomorrow (maybe)
The version 1.0.0 was compatible with improvement/more-stream, and you guys reverted the code to be compatible with develop again with the version 1.0.1. Do you remember?

@rodrigok @Sing-Li I'm not using Hubot, but I did base the original functionality of a dotNet port called Rocket.Chat.Net (https://github.com/Silvenga/Rocket.Chat.Net) on it. When I upgraded to RC 0.36.0 my library was found to be incompatible in the same way as Hubot.
What I've experienced:

Subscriptions to stream-messages result in 404's (similar to 0.1.4 behavior).
Subscribing to room information was broken
I upgraded to be inline with 1.0.1 from the Hubot stream branch by
Message type from added to changed
Subscription name changed from stream-messages to stream-room-messages
Use 2nd index of args from the 1st index on the Rocket.Chat messages JSON objects.
Subscribing to all rooms from null to __my_messages__
Sending true instead of the never used "Message Subscription Limit"

It appears, with these changes, that my library can now receive messages from itself via __my_messages__ and stream-room-messages, however, messages sent from other users are not propagated. This behavor is described here: https://github.com/RocketChat/hubot-rocketchat/issues/149

Is there a process or guideline for releases to ensure stability with corresponding adapter versions? For instances reliant on Hubot compatibility like ours, this is making it quite complicated to stay current and even contributing is becoming challenging, re needing to keep rolling back for testing RC with adaptor and forward for submitting PRs.

I'm worried about my continued support of my Rocket.Chat driver if the API breaks on a release without an upgrade path. Although, with that said, having to reverse engineer the protocol and dive into the client/server code is extremely frustrating. MeteorJs makes cross-language integration so very difficult.

@Silvenga Sorry about that, we are in beta so some times we expect changes like that. Now we are in the middle of 2 big changes, the stream package and a new cache layer on the server side. This is very necessary right now to allow deployments with a large amount of users.
We need to create a separated list of methods to be used as API, then we can keep the compatibility while we are changing the main methods to improve things.
We will try to prevent changes like this in the future.

@rodrigok I am trying to understand this:
a)  0.1.4 worked with 0.35.0
b) there is no core changes between 0.35.0 and 0.36.0  [as you repeatedly said, the merge down is yet to come]
c)  BUT 0.1.4 no longer works with 0.36.0
What has changed in core that makes 0.1.4 no longer work with 0.36.0

@rodrigok Version 1.0.1 was the version I had before the upgrade i performed yesterday, was still broken for me.

(as a sidenote, I do not think 1.0.1 is a rollback at all, it is 1.0.0 - @geekgonecrazy please confirm)

I can confirm.  v1.0.1 is not a rollback.
My best advice right now is stick with 0.35.0 of Rocket.Chat and 0.1.4 of the hubot adapter.  Once we get these new changes released on Rocket.Chat server.  Hopefully we can make them in 0.37.0.  Then we can finally be back on the same page.
I apologize guys... We're trying to get things synced back up for everyone.  Turning out to be more difficult then it should be :smile:

Cheers @geekgonecrazy. That's a good solution, I think we'll going to skip 0.36.0 and wait for stability. Maybe this needs a notice to both repo readmes? The #hubot channel description in demo.rocket.chat links to the old message, but its not there anymore.

@geekgonecrazy Has this issue been addressed in 0.37.0? We updated RC from .31 to .36 and our bot doesn't work as described above.
Though we are on super old 0.0.22 hubot-rocketchat adapter. Just having unrelated npm ERR! not a package /tmp/npm-17133-bGAuMrU7/github.com/RocketChat/asteroid.git npm ERR! Error: ENOENT, open '/tmp/npm-17133-bGAuMrU7/github.com/RocketChat/asteroid.git-unpack/package.json' issues trying to run yo now to get a fresh hubot and not sure why.

I'm running 0.37.0 (worked fine with 0.35.0) and can't get it working with 0.1.4, 1.0.1 or 1.0.4. I'm getting this though...
ERROR Unable to Login: {"error":400,"reason":"Unrecognized options for login request","message":"Unrecognized options for login request [400]","errorType":"Meteor.Error"} Reason: Unrecognized options for login request

@inty Are you trying to log hubot in through ldap or the traditional method?

@richardwlu I'm using LDAP.

Same here.. 0.37.1 in use and hubot v0.1.4 adapter is broken with HTTP 404.

Same as @inty - after updating from 0.36 with adapter 1.0.1 to 0.37.1, we got the error 400. Restored from backup for now.

Yeah I can confirm.  Adapter version 0.1.4 does not work with 0.36.0 or 0.37.x currently.  Investigating..

Hi all, is anyone from the RC team investigating this? I see it's officially "unassigned".

I have the same issue with subscriptions. New Docker based install
hubot_1       | [Tue Aug 23 2016 13:36:10 GMT+0000 (UTC)] ERROR Unable to subscribe: {"error":404,"reason":"Subscription not found","message":"Subscription not found [404]","errorType":"Meteor.Error"} Reason: Subscription not found
hubot_1       | [Tue Aug 23 2016 13:36:10 GMT+0000 (UTC)] ERROR {"error":404,"reason":"Subscription not found","message":"Subscription not found [404]","errorType":"Meteor.Error"}
hubot_1       | [Tue Aug 23 2016 13:36:10 GMT+0000 (UTC)] ERROR Unable to complete setup. See https://github.com/RocketChat/hubot-rocketchat for more info.

@antgel officially.  No one is assigned. I'm taking a look though.  :wink:
Can you guys give version 1.0.1 of the adapter a try if you're using 0.37.0 of rocket.chat?  I tried it and it worked

Tried 1.0.1 again, now I'm running 0.37.1 though and I get the same result (400 error).

@inty your particular issue seems to be related to the login.  Can you give me the command you're using to run it?  I think we can help you get it sorted by specifying the right login options.  :smile:

@geekgonecrazy Great to hear! This is blocking our adoption, no bot == no dice. ;)
I believe I tried 1.0.1 and it was the same - others reported above that this combo didn't work, no? I can try again tomorrow if you're 100% sure it works (and if it does, why all the noise here ? :) ).

@antgel I hear that.  Pretty important for chatops.
Note this is with Rocket.Chat version 0.37.0 or 0.37.1 and hubot adapter version 1.0.1.
npm will have the release because we couldn't roll it back.  But Docker will not have 1.0.1 since we were able to yank those images.
If I can get one more person to confirm they have it working, i'm going to go ahead and cut 1.0.2 and npm / docker will both exist.

@geekgonecrazy Here's an excerpt from the script I'm using with sensitive stuff omitted.
#!/bin/bash

export ROCKETCHAT_ROOM='<omitted>'
export ROCKETCHAT_URL=https://rocket.<omitted>/
export ROCKETCHAT_USER=<omitted>
export ROCKETCHAT_PASSWORD=<omitted>
export ROCKETCHAT_AUTH=ldap

./bin/hubot -a rocketchat

Doesn't leave that much room for error? :) And It worked with 0.35 like a said above.

@inty ah ldap! ok its possible something changed Rocket.Chat side between 0.35 and now with ldap.  Looking into it.

@inty found it.  Yes an additional check was added server side for the login.

I upgraded to 1.0.1 to get 0.36 working again, which it did except for direct messaging, which no longer worked.  As of 0.37.1, it still mostly works, but now for some reason the "help" command no longer works (!?) (and direct messaging is still broken)

@inty release cut, and ldap fix is present in v1.0.3
@dbushong are you setting RESPOND_TO_DM=true?

@dbushong if you don't mind could you open a new issue for this, if that doesn't resolve?
I'm going to go ahead and close this issue, as the root issue should now be resolved.

Ah hah, RESPOND_TO_DM=true fixed the DM problem, thanks!  (I didn't read the 1.0.1 docs)
help (both via DM & in channel when addressed) is still broken as of 0.37.1 tho (I upgraded RocketChat and not Hubot this time, and that's when it broke)

@dbushong good deal!  Lets open another issue and try and track down why help isn't working.  Its working on mine.

@geekgonecrazy Thanks, it works now!

I just pulled latest in docker, and it's working here too. Thanks all! :D

Working and also help command 👍

Thanks for testing and reporting back guys!  Sorry about the complications.  I hope to prevent these in the future 👍

Hi All,
Just confirming that the updates work in the containers
Lance
On 24 August 2016 at 17:16, Aaron Ogle<EMAIL_ADDRESS>wrote:

Thanks for testing and reporting back guys! Sorry about the complications.
I hope to prevent these in the future 👍
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/RocketChat/hubot-rocketchat/issues/142#issuecomment-242101329,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAUH8aG8xCSZ-yT-DTKo7oQzKaNX6PFVks5qjGBKgaJpZM4JCvA-
.

👍 Working here as well

Awesome guys!  👍

Will confirm that v1.0.3 of the hubot interface worked for 37.1

just installed latest Rocket chat .038.0 and its not working with hubot  0.1.4
[Mon Sep 05 2016 06:18:23 GMT+0000 (UTC)] INFO Starting Rocketchat adapter version 0.1.4... [Mon Sep 05 2016 06:18:23 GMT+0000 (UTC)] INFO Once connected to rooms I will respond to the name: hihouhou [Mon Sep 05 2016 06:18:23 GMT+0000 (UTC)] INFO I will also respond to my Rocket.Chat username as an alias: bot [Mon Sep 05 2016 06:18:23 GMT+0000 (UTC)] WARNING No services ROCKETCHAT_ROOM provided to Hubot, using GENERAL [Mon Sep 05 2016 06:18:23 GMT+0000 (UTC)] INFO Connecting To: chat.vodeoo.com:3000 [Mon Sep 05 2016 06:18:23 GMT+0000 (UTC)] INFO Successfully connected! [Mon Sep 05 2016 06:18:23 GMT+0000 (UTC)] INFO GENERAL [Mon Sep 05 2016 06:18:23 GMT+0000 (UTC)] INFO Logging In [Mon Sep 05 2016 06:18:23 GMT+0000 (UTC)] INFO Successfully Logged In [Mon Sep 05 2016 06:18:23 GMT+0000 (UTC)] INFO Looking up Room ID for: GENERAL [Mon Sep 05 2016 06:18:23 GMT+0000 (UTC)] INFO Joining Room: GENERAL [Mon Sep 05 2016 06:18:23 GMT+0000 (UTC)] INFO rid:  [ 'GENERAL' ] [Mon Sep 05 2016 06:18:23 GMT+0000 (UTC)] INFO All rooms joined. [Mon Sep 05 2016 06:18:23 GMT+0000 (UTC)] INFO Successfully joined room: GENERAL [Mon Sep 05 2016 06:18:23 GMT+0000 (UTC)] INFO Preparing Meteor Subscriptions.. [Mon Sep 05 2016 06:18:23 GMT+0000 (UTC)] INFO Subscribing to Room: GENERAL [Mon Sep 05 2016 06:18:24 GMT+0000 (UTC)] ERROR Unable to subscribe: {"error":404,"reason":"Subscription not found","message":"Subscription not found [404]","errorType":"Meteor.Error"} Reason: Subscription not found [Mon Sep 05 2016 06:18:24 GMT+0000 (UTC)] ERROR {"error":404,"reason":"Subscription not found","message":"Subscription not found [404]","errorType":"Meteor.Error"} [Mon Sep 05 2016 06:18:24 GMT+0000 (UTC)] ERROR Unable to complete setup. See https://github.com/RocketChat/hubot-rocketchat for more info.

@Hostile as mentioned earlier in this ticket and now in the README.  0.38.0 of Rocket.Chat requires v1.0.3 of the hubot adapter.

@geekgonecrazy the issue still remains. Let me how I can debug to provide more information.
i created and was running v0.39.0, neither hubot v1.0.3 nor v1.0.4 docker image works.
hubot_1       | [Mon Sep 19 2016 06:29:22 GMT+0000 (UTC)] INFO Successfully connected!
hubot_1       | [Mon Sep 19 2016 06:29:22 GMT+0000 (UTC)] INFO GENERAL
hubot_1       | [Mon Sep 19 2016 06:29:22 GMT+0000 (UTC)] INFO Logging In
hubot_1       | [Mon Sep 19 2016 06:29:22 GMT+0000 (UTC)] INFO Successfully Logged In
hubot_1       | [Mon Sep 19 2016 06:29:22 GMT+0000 (UTC)] INFO Looking up Room ID for: GENERAL
hubot_1       | [Mon Sep 19 2016 06:29:22 GMT+0000 (UTC)] INFO Joining Room: GENERAL
hubot_1       | [Mon Sep 19 2016 06:29:22 GMT+0000 (UTC)] INFO rid:  [ 'GENERAL' ]
hubot_1       | [Mon Sep 19 2016 06:29:22 GMT+0000 (UTC)] INFO All rooms joined.
hubot_1       | [Mon Sep 19 2016 06:29:22 GMT+0000 (UTC)] INFO Successfully joined room: GENERAL
hubot_1       | [Mon Sep 19 2016 06:29:22 GMT+0000 (UTC)] INFO Preparing Meteor Subscriptions..
hubot_1       | [Mon Sep 19 2016 06:29:22 GMT+0000 (UTC)] INFO Subscribing to Room: GENERAL
hubot_1       | [Mon Sep 19 2016 06:29:22 GMT+0000 (UTC)] ERROR Unable to subscribe: {"error":404,"reason":"Subscription not found","message":"Subscription not found [404]","errorType":"Meteor.Error"} Reason: Subscription not found
hubot_1       | [Mon Sep 19 2016 06:29:22 GMT+0000 (UTC)] ERROR {"error":404,"reason":"Subscription not found","message":"Subscription not found [404]","errorType":"Meteor.Error"}
hubot_1       | [Mon Sep 19 2016 06:29:22 GMT+0000 (UTC)] ERROR Unable to complete setup. See https://github.com/RocketChat/hubot-rocketchat for more info.

@geekgonecrazy I'm seeing the issue in 0.45 non docker install -
I've used npm install hubot-rocketchat@1 : should i be using a different hubot version?  and how do i upgrade or downgrade?
Thanks
[Sat Nov 05 2016 17:52:58 GMT+1100 (AEDT)] INFO Starting Rocketchat adapter version 0.1.4...
[Sat Nov 05 2016 17:52:58 GMT+1100 (AEDT)] INFO Once connected to rooms I will respond to the name: alfred
[Sat Nov 05 2016 17:52:58 GMT+1100 (AEDT)] WARNING No services ROCKETCHAT_URL provided to Hubot, using localhost:3000
[Sat Nov 05 2016 17:52:58 GMT+1100 (AEDT)] WARNING No services ROCKETCHAT_ROOM provided to Hubot, using GENERAL
[Sat Nov 05 2016 17:52:58 GMT+1100 (AEDT)] INFO Connecting To: localhost:3000
[Sat Nov 05 2016 17:52:58 GMT+1100 (AEDT)] INFO Successfully connected!
[Sat Nov 05 2016 17:52:58 GMT+1100 (AEDT)] INFO GENERAL
[Sat Nov 05 2016 17:52:58 GMT+1100 (AEDT)] INFO Logging In
[Sat Nov 05 2016 17:52:58 GMT+1100 (AEDT)] INFO Successfully Logged In
[Sat Nov 05 2016 17:52:58 GMT+1100 (AEDT)] INFO Looking up Room ID for: GENERAL
[Sat Nov 05 2016 17:52:58 GMT+1100 (AEDT)] INFO Joining Room: GENERAL
[Sat Nov 05 2016 17:52:58 GMT+1100 (AEDT)] INFO rid:  [ 'GENERAL' ]
[Sat Nov 05 2016 17:52:58 GMT+1100 (AEDT)] INFO All rooms joined.
[Sat Nov 05 2016 17:52:58 GMT+1100 (AEDT)] INFO Successfully joined room: GENERAL
[Sat Nov 05 2016 17:52:58 GMT+1100 (AEDT)] INFO Preparing Meteor Subscriptions..
[Sat Nov 05 2016 17:52:58 GMT+1100 (AEDT)] INFO Subscribing to Room: GENERAL
[Sat Nov 05 2016 17:52:58 GMT+1100 (AEDT)] ERROR Unable to subscribe: {"error":404,"reason":"Subscription 'stream-messages' not found","message":"Subscription 'stream-messages' not found [404]","errorType":"Meteor.Error"} Reason: Subscription 'stream-messages' not found
[Sat Nov 05 2016 17:52:58 GMT+1100 (AEDT)] ERROR {"error":404,"reason":"Subscription 'stream-messages' not found","message":"Subscription 'stream-messages' not found [404]","errorType":"Meteor.Error"}
[Sat Nov 05 2016 17:52:58 GMT+1100 (AEDT)] ERROR Unable to complete setup. See https://github.com/RocketChat/hubot-rocketchat for more info.

@daemienb

[Sat Nov 05 2016 17:52:58 GMT+1100 (AEDT)] INFO Starting Rocketchat adapter version 0.1.4...

You're on adapter version 0.1.4 for some reason.  :)


Crash after touch event

Hi, I'm using micropython porting for ESP32 with ili9341, XPT2046.
Describe the bug
After few touches on a text area, system crash
To Reproduce
Here's the code, taken from sample on https://docs.littlevgl.com/en/html/object-types/ta.html:
import lvgl as lv
from ili9341 import ili9341
disp = ili9341(miso=19, mosi=23, clk=18, cs=5, dc=4, rst=22, power=14, backlight=15, mhz=40, factor=4,
               height=240, width=320,rot=ili9341.LANDSCAPE, hybrid=True)
import xpt2046
touch = xpt2046.xpt2046(cs=14,transpose = False,cal_y1 = 3808, cal_x1 = 3664, cal_y0 = 336, cal_x0 = 256)

def event_handler(obj, event):
    print(event)
    if event == lv.EVENT.VALUE_CHANGED:
        print("Value: %s" % obj.get_text())
    elif event == lv.EVENT.LONG_PRESSED_REPEAT:
        # For simple test: Long press the Text are to add the text below
        ta1.add_text("\n\nYou can scroll it if the text is long enough.\n")

ta1 = lv.ta(lv.scr_act())
ta1.set_size(200, 100)
ta1.align(None, lv.ALIGN.CENTER, 0, 0)
ta1.set_cursor_type(lv.CURSOR.BLOCK)
ta1.set_text("A text in a Text Area")     # Set an initial text
ta1.set_event_cb(event_handler)

Expected behavior
//
Screenshots
Following the console output along with crash report:
>>> %Run -c $EDITOR_CONTENT
ILI9341 initialization completed
Enable backlight
Double buffer
>>> Event received: 0
Event received: 1
Event received: 1
Event received: 1
Event received: 1
Event received: 1
Event received: 3
Event received: 6
Event received: 7
Event received: 12
Guru Meditation Error: Core  1 panic'ed (LoadStoreError). Exception was unhandled.
Core 1 register dump:
PC      : 0x40104a19  PS      : 0x00060530  A0      : 0x8011464a  A1      : 0x3ffccf10
A2      : 0x400014bf  A3      : 0x3fff14c0  A4      : 0x00000000  A5      : 0x00000000
A6      : 0x00000000  A7      : 0x00000000  A8      : 0x00000000  A9      : 0x3ffccee0
A10     : 0x00000000  A11     : 0x3ffb00d4  A12     : 0x3f4312d4  A13     : 0x00000023
A14     : 0x00000000  A15     : 0x00000004  SAR     : 0x0000001e  EXCCAUSE: 0x00000003
EXCVADDR: 0x400014bf  LBEG    : 0x4000c46c  LEND    : 0x4000c477  LCOUNT  : 0x00000000

ELF file SHA256:<PHONE_NUMBER>000000000000000000000000000000000000000000000000000000

Backtrace: 0x40104a19:0x3ffccf10 0x40114647:0x3ffccf70 0x4011c9c1:0x3ffccfd0 0x4011e123:0x3ffcd020 0x400f94c3:0x3ffcd040 0x400f9d21:0x3ffcd080 0x40105bda:0x3ffcd0d0 0x40105c90:0x3ffcd0f0 0x4014293b:0x3ffcd110 0x400e306e:0x3ffcd130 0x400df06d:0x3ffcd150 0x400df0b1:0x3ffcd170 0x400dff90:0x3ffcd1a0 0x400e005d:0x3ffcd220 0x400e00ab:0x3ffcd240 0x400f4141:0x3ffcd260 0x401425e2:0x3ffcd280 0x400f3fb0:0x3ffcd2b0 0x4008e26d:0x3ffcd2e0

Rebooting...
ets Jun  8 2016 00:22:57

rst:0xc (SW_CPU_RESET),boot:0x1b (SPI_FAST_FLASH_BOOT)
configsip: 0, SPIWP:0xee
clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
mode:DIO, clock div:2
load:0x3fff0018,len:4
load:0x3fff001c,len:4876
load:0x40078000,len:9652
load:0x40080400,len:6200
entry 0x400806f0
W (314) cpu_start: Chip revision is higher than the one configured in menuconfig. Suggest to upgrade it.
MicroPython v1.9.4-2072-gf89c8c48c-dirty on 2020-01-04; ESP32 module with ESP32
Type "help()" for more information.
>>>

@amirgon

Could be related to #1316?
Are you using rshell ? There's a known issue where soft rest causes crashes on lvgl, and rshell is resetting the board for some operations.
If this is the case, try using the REPL directly, or try using single buffer instead of double buffer on ili9341.
Another question: what is printing "Event received: 1"? I didn't see this in your code, and I'm not familiar with such printing on our side.

Thanks for the replies.
I've tried your suggestions, but crash happens again, that printing is just  to see what event has been reveived:
0: PRESSED
1: PRESSING
2: PRESS_LOST
3: SHORT_CLICKED
4: LONG_PRESSED
5: LONG_PRESSED_REPEAT
6: CLICKED
7: RELEASED
8: DRAG_BEGIN
9: DRAG_END
10: DRAG_THROW_BEGIN
11: KEY
12: FOCUSED
13: DEFOCUSED
14: VALUE_CHANGED
15: INSERT
16: REFRESH
17: APPLY
18: CANCEL
19: DELETE

@gian72 - I tried running your code on my ESP32 device, and it runs without any problem.
I configured the ili9341 and xpt2046 drivers a bit different on my side, to match my hardware (most parameters are the default values declared on ili9341 and xpt2046 drivers):
disp = ili9341(dc=32, cs=33, power=-1, backlight=-1)
touch = xpt2046.xpt2046()

Since I cannot reproduce the problems you see, I can only guess that your problem is related either to your configuration (driver parameters, wiring etc) or to your hardware.
Next step for you is to try to debug it.

Build micropython in DEBUG configuration
Parse the Backtrace line with addr2line. The backtrace can be very helpful
Debug your device with JTAG. Here is how I'm doing it.

I've  tried:
make DEBUG=1 LV_CFLAGS="-DLV_COLOR_DEPTH=16 -DLV_COLOR_16_SWAP=1" BOARD=GENERIC
or
make LV_CFLAGS="-DLV_COLOR_DEPTH=16 -DLV_COLOR_16_SWAP=1 -DDEBUG" BOARD=GENERIC
But I'm not sure the above options change somthing in the produced firmware (size is still the same)

make DEBUG=1 LV_CFLAGS="-DLV_COLOR_DEPTH=16 -DLV_COLOR_16_SWAP=1" BOARD=GENERIC

That one.
Make sure you make clean before you build in DEBUG mode, because incremental build does not take it into account.

Here's the stack trace:
/home/gianpaolo_fresia/esp32/lv_micropython/ports/esp32/../../lib/lv_bindings/lvgl/src/lv_misc/lv_bidi.c:195 (discriminator 1)
/home/gianpaolo_fresia/esp32/lv_micropython/ports/esp32/../../lib/lv_bindings/lvgl/src/lv_objx/lv_label.c:732
/home/gianpaolo_fresia/esp32/lv_micropython/ports/esp32/../../lib/lv_bindings/lvgl/src/lv_objx/lv_ta.c:1879
/home/gianpaolo_fresia/esp32/lv_micropython/ports/esp32/../../lib/lv_bindings/lvgl/src/lv_objx/lv_ta.c:1528
/home/gianpaolo_fresia/esp32/lv_micropython/ports/esp32/../../lib/lv_bindings/lvgl/src/lv_core/lv_indev.c:764
/home/gianpaolo_fresia/esp32/lv_micropython/ports/esp32/../../lib/lv_bindings/lvgl/src/lv_core/lv_indev.c:668
/home/gianpaolo_fresia/esp32/lv_micropython/ports/esp32/../../lib/lv_bindings/lvgl/src/lv_misc/lv_task.c:370 (discriminator 1)
/home/gianpaolo_fresia/esp32/lv_micropython/ports/esp32/../../lib/lv_bindings/lvgl/src/lv_misc/lv_task.c:135
/home/gianpaolo_fresia/esp32/lv_micropython/ports/esp32/../../lib/lv_bindings/driver/esp32/modlvesp32.c:33
/home/gianpaolo_fresia/esp32/lv_micropython/ports/esp32/../../py/objfun.c:70
/home/gianpaolo_fresia/esp32/lv_micropython/ports/esp32/../../py/runtime.c:642
/home/gianpaolo_fresia/esp32/lv_micropython/ports/esp32/../../py/runtime.c:620
/home/gianpaolo_fresia/esp32/lv_micropython/ports/esp32/../../py/runtime_utils.c:33
/home/gianpaolo_fresia/esp32/lv_micropython/ports/esp32/../../py/scheduler.c:72
/home/gianpaolo_fresia/esp32/lv_micropython/ports/esp32/../../py/scheduler.c:59
/home/gianpaolo_fresia/esp32/lv_micropython/ports/esp32/mphalport.c:68
/home/gianpaolo_fresia/esp32/lv_micropython/ports/esp32/../../lib/utils/pyexec.c:369
/home/gianpaolo_fresia/esp32/lv_micropython/ports/esp32/main.c:127

Ok, at that line (lv_bidi.c:195), probably there's a typo:
if (str_out) str_out[len] = '\0';

I've tried to comment that out and that type of crash seems disappered :-)
Even if after some more touch interaction I have this other crash with this message:
MemoryError: memory allocation failed, allocating 65535 bytes

But probably is anouter issue, let me try with other your suggestions :-)

That's interesting.
It crashes on this line:
https://github.com/littlevgl/lvgl/blob/248868fef1f4925fada1aa7591b19e3bc837db51/src/lv_misc/lv_bidi.c#L195
In function:
void lv_bidi_process_paragraph(const char * str_in, char * str_out, uint32_t len, lv_bidi_dir_t base_dir, uint16_t *pos_conv_out, uint16_t pos_conv_len)

called from here:
https://github.com/littlevgl/lvgl/blob/248868fef1f4925fada1aa7591b19e3bc837db51/src/lv_objx/lv_label.c#L729-L732
There is some memory allocation involved here: lv_draw_get_buf should allocate enough ram for bidi_txt, but something goes wrong there.
Perhaps you are out of ram?
Try to print out the return value of lv_draw_get_buf, or print something in LV_DEBUG_ASSERT so you could see if the memory allocation is successful or not.

I've tried to use lv_mem_monitor to retrieve memory available (before and after lv_draw_get_buf), but I can't get valid information (lv_mem_monitor_t  stuct is always all 0)
BTW, disabling bidi (LV_USE_BIDI at 0), the issue disappers.

I've tried to use lv_mem_monitor to retrieve memory available

You can't use it with micropython. When running lvgl with micropython, lvgl uses micropython's gc.
Try gc.mem_free().
Checking the return value of lv_draw_get_buf would be best.

BTW, disabling bidi (LV_USE_BIDI at 0), the issue disappers.

I'm not convinced the problem is related to bidi, even though the crash was in there.
If it's not, it could randomly appear elsewhere.

@amirgon
While reworking the styles I also faced a crash due to bidi that I just wanted to report.
I see two problems here:

uint16_t *pos_conv_buf = (uint16_t*) ((char*)buf + len); can be an odd address. It might a problem for some architectures to read uint16_t from an unaligned address.
len should be len+1 becasue lv_bidi_process_paragraph set the trailing zero immediatelly.

I've fixed these like this.
What do you think?

@kisvegabor

uint16_t *pos_conv_buf = (uint16_t*) ((char*)buf + len); can be an odd address. It might a problem for some architectures to read uint16_t from an unaligned address.

It's true for some architectures, I'm actually not sure about ESP32.
I agree it should be fixed, to be on the safe side.
However, it's not related to the problem above since lv_bidi_process_paragraph was not called from lv_bidi_get_logical_pos in that case. Even if it did, it would cause UNALIGNED ERROR error and not LOADSTORE ERROR (xtensa architecture has different codes for these erros).

2. len should be len+1 becasue lv_bidi_process_paragraph set the trailing zero immediatelly.

I think you are right, but I don't see how this could cause the crash above. When str_out[len] is written to, it mistakenly writes to the first element of pos_conv_buf which comes right after it, but it should not cause a LoadStoreError by itself.

I've fixed these like this.

With multiple temporary buffers, it makes sense allocating two buffers instead of one.
But multiple temporary buffers are not available yet on v.6 so we would need a different fix for v.6.
As I mentioned, I'm not sure that this fix would also fix the problem above, at least I haven't seen how the problems you pointed at could cause a LoadStoreError when executing str_out[len] = '\0', especially when it was called from lv_label_get_letter_on where pos_conv_buf is not used.
Do you think this is related?
Do you have any idea what else could cause this problem?

What I can imagine is the \0 is overwritten by pos_conv_buf and therefore the string looks longer. I'm not sure what are the real consequences (how could it cause LoadStoreError) but it looks evil.
Anyway, IMO it's worth a try to see if it fixes the crash.

It seems that the original problem has been fixed so I'll close this issue.


Allow ability to bypass cache

In some cases I'm polling the status of pods (due to terrible historical reasons I can not use WATCH). It would be awesome if pykube supported a parameter that'll force the query to actually happen and not hit the cache.
Thanks for the nice library!

Could you provide some more detail in to your usage of the library? There are ways of invalidating the internal cache to ensure it queries when you want it to.


[WFLY-19760] - Distributions contain zips of feature packs index at their root

The zip of the WildFly galleon packs's index must not be present at the root of the feature packs but only in the modules tree
Renamed the zip to clarify their content:

wildfly-galleon-pack.zip has been renamed wildfly-galleon-pack-unstable-api-annotation-index.zip
wildfly-ee-feature-pack.zip has been renamed wildfly-ee-galleon-pack-unstable-api-annotation-index.zip

JIRA: https://issues.redhat.com/browse/WFLY-19760

Going to try and include in Beta if CI passes.

Thanks @jmesnil and @kabir


the 'walk' module is not properly included in term2string function

the 'walk' module is not properly included in term2string function.  it needs to be included as
asteroid.walk

in the __str__ handling section of term2string

Also, the term2string function is intended to print out values NOT computations otherwise this function will absorb ALL of asteroid's syntactical constructs.
Part of this bug fix will be cleaning up this function.


Update text-to-speech.md

I added a showcase section.
You can create a page there. Add this in the top of the file:
---
tags:
    - TTS
title: My Example
---

Please keep the title short, and use existing tags.
And btw, you can preview your page in github. But I recommend [cloning the repo locally[(https://tech7fox.github.io/sip-hass-docs/docs/developers/docs) so you can test how it looks.

Please close duplicates or old PR's.


Bug in regex with lookaheads, wrong captures

This is with the latest release 0.1.0.
This example yields wrong results. Python's re package gets it right with the same regex:
let r = fancy_regex::Regex::new(r"\s*(?<=[() ])(@\w+)(\([^)]*\))?\s*").unwrap();
let captures = r.captures(" @another(foo bar)   ").unwrap().unwrap();
assert_eq!(Some("@another"), captures.at(1));
assert_eq!(Some("(foo bar)"), captures.at(2));

The actual value of first group is  @anothe and the second is r(foo bar.

Is it possible to change the google repositories readme with a warning that this crate has moved to a new location?

That's https://github.com/google/fancy-regex/pull/52 , which is waiting on action by someone at Google. I think I just need to find someone personally to ping.


Docs should define the term "chunk"

The word is used in lots of places, e.g.:
https://thanos.io/tip/thanos/design.md/ "Chunk files hold a few hundred MB worth of chunks each."
https://thanos.io/tip/thanos/storage.md/ "This can be used to find chunk with samples in the chunk files."
It would be good to define it, like "a chunk is part of the data structure of Prometheus TSDB, holding up to 120 samples for a single timeseries".

Seems like we can define chunks at one place, and hyperlink the definition wherever it's used. WDYT? @GiedriusS @bboreham

This is actually also a Prometheus TSDB issue.

a chunk is part of the data structure of Prometheus TSDB, holding up to
120 samples for a single timeseries".

But also a chunk .. file - is the file in TSDB block that contains up to
0.5GB worth of chunk entries in binary format.
Anyway, let's document better, thanks! (:
Kind Regards,
Bartek Płotka (@bwplotka)
On Wed, 16 Dec 2020 at 10:19, Biswajit Ghosh<EMAIL_ADDRESS>wrote:

Seems like we can define chunks at one place, and hyperlink the definition
wherever it's used. WDYT? @GiedriusS https://github.com/GiedriusS
@bboreham https://github.com/bboreham
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/thanos-io/thanos/issues/3627#issuecomment-746043185,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABVA3O5JKS23UROWOJZRKITSVCCTNANCNFSM4U4CCREQ
.

Personally I think hyper-linking every time is is used would get annoying.
You could have a "glossary" section in the docs that defines terms.


Signal association connect-disconnect

Hi omab,
There are some signal for association?
Thanks in advance.
Regards.

No, there's no signal (and signals will be deprecated soon), instead you could define your own auth pipeline and add a custom handler that does what you want for associations.

cool. Thanks.
Are you work on these days?

And another things..
Could you explain better 'your own auth pipeline' ?
Thanks another omab.

I'm preparing a detailed doc about it, will be ready soon.

Ok thanks. If you have also only a draft it will be usefully for me now. ;)

Any news?

Sorry, taking more time than expected.

It would be great if you could provide a minimal code example of the pipeline usage for this purpose. Thanks!

how's the progress here? ;)

Pipeline work and docs were implemented already, check docs at http://django-social-auth.readthedocs.org/en/latest/pipeline.html.

Thanks!


npm start run fails - index has no exported member 'ModuleWithProviders'

I followed the quickstart instructions but npm start run fails with the following message
[default] /Project/ngrx-example/node_modules/@ngrx/store/ng2.d.ts:5:23
    Module '"/Project/ngrx-example/node_modules/@angular/core/index"' has no exported member 'ModuleWithProviders'

I tried the rc5 branch and get another error

@MikeRyan52 let me know that this could be caused by an older version of node. I updated to the latest and now I am seeing this

it looks like that webpack issue was a quick bug in the latest beta. I updated modules and now getting Module '"/Users/mike/ngrx-example/node_modules/@angular/core/index"' has no exported member 'ModuleWithProviders'.

Duplicate of #33. I'm unable to reproduce after upgrading to Angular 2 final. If you're still having this issue, I would recommend upgrading to Angular 2 final or trying the steps listed in #33.


Install process needs to be updated for new Shib IdP 4.2+ installs

The changes to the Module system make it so there seems to be a few updates needed to the readme file for shib 4.2+
In a fresh install the External module is disabled by default and needs to be enabled by IDP_HOME/bin/module.sh -e idp.authn.External . The IDP_HOME/conf/authn/external-authn.xml and IDP_HOME/conf/authn/general-authn.xml files appear to no longer exist and setting the context path appears to be done in the IDP_HOME/conf/authn/authn.properties file now
 #### External ####

#idp.authn.External.order = 1000
#idp.authn.External.nonBrowserSupported = false
#idp.authn.External.matchExpression =
# Unset if you plan to return full Java Subject from external source
#idp.authn.External.addDefaultPrincipals = true
# Servlet context-relative path to wherever your implementation lives
idp.authn.External.externalAuthnPath = contextRelative:external.jsp

based on the other configurations present in the properties file this appears to be the new config for supporting both the basic setup and a REFEDS MFA profile in the auth.properties file
 #### External ####

#idp.authn.External.order = 1000
idp.authn.External.nonBrowserSupported = false
idp.authn.External.forcedAuthenticationSupported = true
idp.authn.External.passiveAuthenticationSupported = true
#idp.authn.External.matchExpression =
# Unset if you plan to return full Java Subject from external source
#idp.authn.External.addDefaultPrincipals = true
# Servlet context-relative path to wherever your implementation lives
idp.authn.External.externalAuthnPath = contextRelative:Authn/External
idp.authn.External.supportedPrincipals = \
    saml2/https://refeds.org/profile/mfa, \
    saml2/urn:oasis:names:tc:SAML:2.0:ac:classes:PasswordProtectedTransport

Awesome thanks for the PR! We'll be looking at this shortly and as soon as we're able get a 4.2 version out.

The location of the idp.authn.flows line has also been moved to the authn.properties file as well. The IdP properties file now by default loads all values in conf/**/*.properties, so all configs for shibcas might be better served by being moved to either the authn.properties file or a custom properties file like shibcas.properties in /conf/authn


capitalize classes and other stuff

Doing a bit of a large PR for Mr_Oren.
Please discuss and review.

@KageJittai said no in the discord chat, so I'm closing


Sounds of the items in this mod

they soo global. i mean the sounds of these items can be heard all over the map, regardless of near or far. it's like they're right in your hand, even though a friend has them on the other side of the map

Yeah I'm aware that I have to improve the sounds 😅
I'll try to get them fixed on the next patch!

Hello! Sorry for the inactivity, studies got me occupied last month, during this week I will try to get the patch live.


Rsync killed for thread limit

Running 6 threads but rsync gets killed rarely but consistently.
Two example logs attached.  Code reads that it should only be killed after 20 threads.
rsyncfail.txt
rsyncfail2.txt

Presumably a side effect from:
https://github.com/ArchiveTeam/seesaw-kit/issues/48


点云显示时，选择强度， 会不显示

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

不显示的原因是强度不符合工具显示规范，支持强度0-255值，现在做了兼容支持0-1，你可以更新到最新版本看是否还存在问题，否则检查pcd是否符合要求


[Bug]: battery_plus_platform_interface misses enum case

Platform
Android 12
Plugin
battery_plus
Version
v5.0.1
Flutter SDK
v3.16.2
Steps to reproduce
Use the battery_plus plugin on an Android Emulator with a neutral charging state.
The battery_plus plugin after being updated to version v5.0.1 now contains the charging state "not_charging". see. https://github.com/fluttercommunity/plus_plugins/pull/2275
The corresponding platform interface (battery_plus_platform_interface) in its currrent version 2.0.0 is lacking this enum, leading to an ArgumentError.
File: utils.dart
BatteryState parseBatteryState(String state) {
  switch (state) {
    case 'full':
      return BatteryState.full;
    case 'charging':
      return BatteryState.charging;
    case 'discharging':
      return BatteryState.discharging;
    case 'connected_not_charging':
      return BatteryState.connectedNotCharging;
    case 'unknown':
      return BatteryState.unknown;
    default:
      throw ArgumentError('$state is not a valid BatteryState.');
  }
}

The initial commit contained the fix, this was however reverted by this commit: https://github.com/fluttercommunity/plus_plugins/commit/78f44bf41a7e8349240bacae2dd70598ba22e97a
Please release a hotfix.
Code Sample
No response
Logs
Invalid argument(s): not_charging is not a valid BatteryState.
I/flutter ( 3973): #0      parseBatteryState (package:battery_plus_platform_interface/src/utils.dart:17:7)
I/flutter ( 3973): #1      MethodChannelBattery.batteryState.<anonymous closure> (package:battery_plus_platform_interface/method_channel_battery_plus.dart:43:47)
I/flutter ( 3973): #2      _rootRunUnary (dart:async/zone.dart:1407:47)
I/flutter ( 3973): <asynchronous suspension>
I/flutter ( 3973): #3      BatteryIndicatorProvider._update (package:common/src/feature/battery/provider/battery_indicator_provider.dart:22:21)
I/flutter ( 3973): <asynchronous suspension>

Flutter Doctor
[✓] Flutter (Channel stable, 3.16.3, on macOS 14.0 23A344 darwin-arm64,
    locale en-DE)
    • Flutter version 3.16.3 on channel stable at
      /Users/felix/development/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision b0366e0a3f (7 days ago), 2023-12-05 19:46:39
      -0800
    • Engine revision 54a7145303
    • Dart version 3.2.3
    • DevTools version 2.28.4

[✓] Android toolchain - develop for Android devices (Android SDK version
    34.0.0)
    • Android SDK at /Users/felix/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: /Applications/Android
      Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      17.0.7+0-17.0.7b1000.6-10550314)
    • All Android licenses accepted.

[!] Xcode - develop for iOS and macOS (Xcode 15.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15A507
    ! iOS 17.0 Simulator not installed; this may be necessary for iOS and
      macOS development.
      To download and install the platform, open Xcode, select Xcode >
      Settings > Platforms,
      and click the GET button for the required platform.

      For more information, please visit:
        https://developer.apple.com/documentation/xcode/installing-additi
        onal-simulator-runtimes
    • CocoaPods version 1.13.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google
      Chrome

[✓] Android Studio (version 2023.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      17.0.7+0-17.0.7b1000.6-10550314)

[✓] IntelliJ IDEA Ultimate Edition (version 2020.3.3)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.85.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.78.0

[✓] Connected device (3 available)
    • Android SDK built for arm64 (mobile) • emulator-5554 •
      android-arm64  • Android 10 (API 29) (emulator)
    • macOS (desktop)                      • macos         • darwin-arm64
      • macOS 14.0 23A344 darwin-arm64
    • Chrome (web)                         • chrome        •
      web-javascript • Google Chrome 120.0.6099.71

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

Checklist before submitting a bug

[X] I searched issues in this repository and couldn't find such bug/problem
[X] I Google'd a solution and I couldn't find it
[X] I searched on StackOverflow for a solution and I couldn't find it
[X] I read the README.md file of the plugin
[X] I'm using the latest version of the plugin
[X] All dependencies are up to date with flutter pub upgrade
[X] I did a flutter clean
[X] I tried running the example project

Thanks for reporting. Indeed, there is an issue as not_charging wasn't a proper name that had to be changed to better explain what is the status about. I will release a fix shortly.

Released the fix for this issue in 5.0.2


Add Search for AMI rather than fixed ID

Current method doesn't work.
Implement finding stock Windows 2016 image: http://docs.aws.amazon.com/AWSEC2/latest/WindowsGuide/finding-an-ami.html#finding-an-ami-aws-cli

Fixed.


Add chengliang to OWNERS file.

What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note:

NONE

@apicl: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
9671180b4563aa74e478940e11cd87734bd0a3ab
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@apicl: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
779faaa5461d5043a7fb97df3d20de7a295d4eee
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@apicl: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
779faaa5461d5043a7fb97df3d20de7a295d4eee
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Codecov Report

Merging #1721 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1721      +/-   ##
==========================================
- Coverage   79.83%   79.81%   -0.02%
==========================================
  Files         208      208
  Lines       21072    21072
==========================================
- Hits        16822    16819       -3
- Misses       3758     3761       +3
  Partials      492      492

Impacted Files
Coverage Δ

mixer/adapter/prometheus/server.go
89.83% <0%> (-5.09%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58a96fc...779faaa. Read the comment docs.


Add apple silicon targets

👋  I'm trying add apple silicon targets for FlowRedux and realized this library is a dependency, so we'd need to update to Kotlin 1.5.30 and Coroutines 1.5.2 and enable apple silicon targets here.

Was released as 0.2.1 earlier this month


clearer instruction to disable default argocd instance

What type of PR is this?
/kind documentation
What does this PR do / why we need it:
Specifically mentioning to edit the env resource within the subscriptions.operators.coreos.com.spec.config CRD to add the associated env. var. in order to disable the default argocd  instance launch.
Have you updated the necessary documentation?

[ ] Documentation update is required by this PR.
[x] Documentation has been updated.

Which issue(s) this PR fixes:
Fixes #?
Test acceptance criteria:

[ ] Unit Test
[ ] E2E Test

How to test changes / Special notes to the reviewer:

ok-to-test

/retest

@makeittotop I know it is an old PR but can you rebase this ?

Sure, doing it
On Wed, Sep 4, 2024 at 10:49 AM Saumeya Katyal @.***>
wrote:

@makeittotop https://github.com/makeittotop I know it is an old PR but
can you rebase this ?
—
Reply to this email directly, view it on GitHub
https://github.com/redhat-developer/gitops-operator/pull/412#issuecomment-2329652121,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABFYC7JEN7R53GHOBSCPNWDZU5BY5AVCNFSM6AAAAABNU2NLOWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRZGY2TEMJSGE
.
You are receiving this because you were mentioned.Message ID:
@.***>