Extend bench bucket series with skip chunk test case

Signed-off-by: Ben Ye<EMAIL_ADDRESS>

[ ] I added CHANGELOG entry for this change.
[x] Change is not relevant to the end user.

Changes
This pr fixes and extends the benchmark tests in bucket_test.go with skip chunk option so that we can measure the performance with /api/v1/series queries.

Verification
Did some local benchmarks between current master and https://github.com/thanos-io/thanos/commit/2a7590f69a5ace6014ddcc932788056935f201ba, which is the commit before I introduced https://github.com/thanos-io/thanos/commit/053730c6054517186187b33b36d989069b08ad70.
Results:
➜  thanos git:(change-benchseries-skipchunks) ✗ benchcmp old new2
benchcmp is deprecated in favor of benchstat: https://pkg.go.dev/golang.org/x/perf/cmd/benchstat
benchmark                                                                           old ns/op      new ns/op      delta
BenchmarkBucketSeriesSkipChunks/1000000SeriesWith1Samples/1of1000000-8              374105769      301182970      -19.49%
BenchmarkBucketSeriesSkipChunks/1000000SeriesWith1Samples/10of1000000-8             366452232      309757355      -15.47%
BenchmarkBucketSeriesSkipChunks/1000000SeriesWith1Samples/1000000of1000000-8<PHONE_NUMBER><PHONE_NUMBER>     -11.35%
BenchmarkBucketSeriesSkipChunks/100000SeriesWith100Samples/1of10000000-8            31472869       24470688       -22.25%
BenchmarkBucketSeriesSkipChunks/100000SeriesWith100Samples/100of10000000-8          31160010       25012601       -19.73%
BenchmarkBucketSeriesSkipChunks/100000SeriesWith100Samples/10000000of10000000-8     134128144      117053813      -12.73%
BenchmarkBucketSeriesSkipChunks/1SeriesWith10000000Samples/1of10000000-8            2564966        2696107        +5.11%
BenchmarkBucketSeriesSkipChunks/1SeriesWith10000000Samples/100of10000000-8          2799881        2989642        +6.78%
BenchmarkBucketSeriesSkipChunks/1SeriesWith10000000Samples/10000000of10000000-8     29997992       7483051        -75.05%

➜  thanos git:(change-benchseries-skipchunks) ✗ benchcmp old1 new2
benchcmp is deprecated in favor of benchstat: https://pkg.go.dev/golang.org/x/perf/cmd/benchstat
benchmark                                                                           old ns/op      new ns/op      delta
BenchmarkBucketSeriesSkipChunks/1000000SeriesWith1Samples/1of1000000-8              370824340      301182970      -18.78%
BenchmarkBucketSeriesSkipChunks/1000000SeriesWith1Samples/10of1000000-8             361008121      309757355      -14.20%
BenchmarkBucketSeriesSkipChunks/1000000SeriesWith1Samples/1000000of1000000-8<PHONE_NUMBER><PHONE_NUMBER>     -8.14%
BenchmarkBucketSeriesSkipChunks/100000SeriesWith100Samples/1of10000000-8            31943616       24470688       -23.39%
BenchmarkBucketSeriesSkipChunks/100000SeriesWith100Samples/100of10000000-8          32781041       25012601       -23.70%
BenchmarkBucketSeriesSkipChunks/100000SeriesWith100Samples/10000000of10000000-8     132956005      117053813      -11.96%
BenchmarkBucketSeriesSkipChunks/1SeriesWith10000000Samples/1of10000000-8            3796664        2696107        -28.99%
BenchmarkBucketSeriesSkipChunks/1SeriesWith10000000Samples/100of10000000-8          4202906        2989642        -28.87%
BenchmarkBucketSeriesSkipChunks/1SeriesWith10000000Samples/10000000of10000000-8     30378157       7483051        -75.37%

➜  thanos git:(change-benchseries-skipchunks) ✗ benchcmp old2 new2
benchcmp is deprecated in favor of benchstat: https://pkg.go.dev/golang.org/x/perf/cmd/benchstat
benchmark                                                                           old ns/op      new ns/op      delta
BenchmarkBucketSeriesSkipChunks/1000000SeriesWith1Samples/1of1000000-8              365262896      301182970      -17.54%
BenchmarkBucketSeriesSkipChunks/1000000SeriesWith1Samples/10of1000000-8             365881346      309757355      -15.34%
BenchmarkBucketSeriesSkipChunks/1000000SeriesWith1Samples/1000000of1000000-8<PHONE_NUMBER><PHONE_NUMBER>     -11.65%
BenchmarkBucketSeriesSkipChunks/100000SeriesWith100Samples/1of10000000-8            32594123       24470688       -24.92%
BenchmarkBucketSeriesSkipChunks/100000SeriesWith100Samples/100of10000000-8          33246343       25012601       -24.77%
BenchmarkBucketSeriesSkipChunks/100000SeriesWith100Samples/10000000of10000000-8     132272646      117053813      -11.51%
BenchmarkBucketSeriesSkipChunks/1SeriesWith10000000Samples/1of10000000-8            3441730        2696107        -21.66%
BenchmarkBucketSeriesSkipChunks/1SeriesWith10000000Samples/100of10000000-8          5469016        2989642        -45.33%
BenchmarkBucketSeriesSkipChunks/1SeriesWith10000000Samples/10000000of10000000-8     30291587       7483051        -75.30%

Did a skip chunks benchmark again between the current master and https://github.com/thanos-io/thanos/commit/2a7590f69a5ace6014ddcc932788056935f201ba, that's the result. @bwplotka
➜  thanos git:(test-ind) ✗ scripts/cmp.sh 1 0
Comparing '/home/yeya24/hub/gowork/thanos/scripts/results/BenchmarkBucketSeriesSkipChunks/1/2020-10-28-T11-49-55.bench.out' (c894acae22d34110993fc456a95038db88c6af1a BenchmarkBucketSeriesSkipChunks ./store 2h 2m /home/yeya24/hub/gowork/thanos/scripts/../pkg on core #3) with (new) '/home/yeya24/hub/gowork/thanos/scripts/results/BenchmarkBucketSeriesSkipChunks/0/2020-10-28-T11-16-20.bench.out' (c894acae22d34110993fc456a95038db88c6af1a BenchmarkBucketSeriesSkipChunks ./store 2h 2m /home/yeya24/hub/gowork/thanos/scripts/../pkg on core #3)
name                                                                  old time/op    new time/op    delta
BucketSeriesSkipChunks/1000000SeriesWith1Samples/1of1000000              550ms ± 0%     423ms ± 0%  -23.05%
BucketSeriesSkipChunks/1000000SeriesWith1Samples/10of1000000             553ms ± 0%     496ms ± 0%  -10.34%
BucketSeriesSkipChunks/1000000SeriesWith1Samples/1000000of1000000        4.20s ± 0%     3.39s ± 0%  -19.40%
BucketSeriesSkipChunks/100000SeriesWith100Samples/1of10000000           45.5ms ± 0%    38.6ms ± 0%  -15.16%
BucketSeriesSkipChunks/100000SeriesWith100Samples/100of10000000         44.1ms ± 0%    36.1ms ± 0%  -18.07%
BucketSeriesSkipChunks/100000SeriesWith100Samples/10000000of10000000     328ms ± 0%     276ms ± 0%  -15.92%
BucketSeriesSkipChunks/1SeriesWith10000000Samples/1of10000000           5.14ms ± 0%    4.53ms ± 0%  -11.88%
BucketSeriesSkipChunks/1SeriesWith10000000Samples/100of10000000         5.17ms ± 0%    4.13ms ± 0%  -20.11%
BucketSeriesSkipChunks/1SeriesWith10000000Samples/10000000of10000000    86.2ms ± 0%    16.5ms ± 0%  -80.80%

name                                                                  old alloc/op   new alloc/op   delta
BucketSeriesSkipChunks/1000000SeriesWith1Samples/1of1000000              125MB ± 0%      98MB ± 0%  -21.73%
BucketSeriesSkipChunks/1000000SeriesWith1Samples/10of1000000             125MB ± 0%      98MB ± 0%  -21.69%
BucketSeriesSkipChunks/1000000SeriesWith1Samples/1000000of1000000       1.31GB ± 0%    1.00GB ± 0%  -23.69%
BucketSeriesSkipChunks/100000SeriesWith100Samples/1of10000000           11.2MB ± 0%     8.4MB ± 0%  -24.75%
BucketSeriesSkipChunks/100000SeriesWith100Samples/100of10000000         11.2MB ± 0%     8.4MB ± 0%  -24.41%
BucketSeriesSkipChunks/100000SeriesWith100Samples/10000000of10000000     126MB ± 0%      96MB ± 0%  -23.62%
BucketSeriesSkipChunks/1SeriesWith10000000Samples/1of10000000           5.90MB ± 0%    4.34MB ± 0%  -26.44%
BucketSeriesSkipChunks/1SeriesWith10000000Samples/100of10000000         5.90MB ± 0%    4.34MB ± 0%  -26.44%
BucketSeriesSkipChunks/1SeriesWith10000000Samples/10000000of10000000    38.0MB ± 0%    17.3MB ± 0%  -54.37%

name                                                                  old allocs/op  new allocs/op  delta
BucketSeriesSkipChunks/1000000SeriesWith1Samples/1of1000000              1.51M ± 0%     0.76M ± 0%  -49.68%
BucketSeriesSkipChunks/1000000SeriesWith1Samples/10of1000000             1.51M ± 0%     0.76M ± 0%  -49.68%
BucketSeriesSkipChunks/1000000SeriesWith1Samples/1000000of1000000        12.1M ± 0%      8.0M ± 0%  -33.44%
BucketSeriesSkipChunks/100000SeriesWith100Samples/1of10000000             151k ± 0%       76k ± 0%  -49.66%
BucketSeriesSkipChunks/100000SeriesWith100Samples/100of10000000           151k ± 0%       76k ± 0%  -49.65%
BucketSeriesSkipChunks/100000SeriesWith100Samples/10000000of10000000     1.21M ± 0%     0.80M ± 0%  -33.44%
BucketSeriesSkipChunks/1SeriesWith10000000Samples/1of10000000              231 ± 0%       195 ± 0%  -15.58%
BucketSeriesSkipChunks/1SeriesWith10000000Samples/100of10000000            231 ± 0%       195 ± 0%  -15.58%
BucketSeriesSkipChunks/1SeriesWith10000000Samples/10000000of10000000      170k ± 0%        1k ± 0%  -99.68%

Ready for another round of review.


Move signature verification to dedicated function

Added new file core/signatures.go that contains two functions for verifying message and bitcoin signatures respectively. Verification is delegated to verifyMessageSignature() via closure argument that
captures logic for extracting signatures from contract context. Also, some imports rearrangement due to goimports tool.
Seems to be 150+ lines of code diff, so code review would be very much appreciated.

Coverage remained the same at 60.427% when pulling 2d79ce435c1a0c3af83157a501c949874d65bd82 on yurizhykin:verify-sigs into 06fc23ae7ab68c314db81e4210c1afb363af5267 on OpenBazaar:master.

Forgot to mention: this closes issue #196

Thanks I'll review tomorrow.

@yurizhykin I've got test failures when I run the qa test suite. Looks like signature verification is failing. I'd have to dig a little deeper to find out why

Are there any instructions on how to run QA tests? It's a shame, but I didn't run them, as there was no mention in README and CONTRIBUTE.

I want to hook the test suite to travis but the "offline" tests all fail on travis for some reason, but not on my local computer. I can't figure out why.

I'm currently having a hard time running tests myself, because it all fails with Permission denied error, and it is not obvious why exactly that happens.

hmm maybe you need to chmod +x the file.

No, it turned out, I already had /tmp/openbazaar-go dir owned by root. Now there's another problem:
unknown flag disableexchangerates'`.

So make sure before you run the tests you compile the openbazaar-go binary against your latest code.
I just run go install in the openbazaar-go directory and it puts the binary in $GOPATH/bin/openbazaar-go
So I run the test suite as
./runtests.sh $GOPATH/bin/openbazaar-go /bin/bitcoind

I just realized that openbazaar-go binary that I had in $GOPATH/bin was compiled a month ago, when I started playing around with it, and I've never recompiled it since, so yeah, thatnks, that was it:)

@yurizhykin It looks like you could abstract away the sig extractor as well. Aren't they all basically doing the same thing?

@JustinDrake I've already started yesterday, will finish today's evening. The problem noted by @cpacia is very strange, as Verify() method in both situations accepts same parameters (pubkey, sig and message), but returns different values, so I tried changing verifyMessageSignature() to accept signature instead of extractor closure, though behaviour seems to remain the same. Will continue today.

Coverage remained the same at 60.427% when pulling 89c4af83c92bfd14c8cc10add0df52416212325b on yurizhykin:verify-sigs into 85d4642fe31f3c0a1897810027508a78ef3afe78 on OpenBazaar:master.

Coverage remained the same at 60.427% when pulling a778937baf3f2f3d4a22e4f97f2cdf9ab729d7e1 on yurizhykin:verify-sigs into 85d4642fe31f3c0a1897810027508a78ef3afe78 on OpenBazaar:master.

Finally finished it. Moved out signature extraction as well.

Cool I'll take a look.

I think this LGTM, Thanks!


CSQL_PROXY_ADDRESS requires an IP address but doesn't explicitly state so

Description
When setting CSQL_PROXY_ADDRESS to cloud-sql-proxy I get the error below.
Error: not a valid IP address: "cloud-sql-proxy"

Potential Solution
Given that the word address is used for both domain names and IPs either it would be great to have disambiguation. I can also make a feature request.
Additional Details
No response

@ar-qun can you tell me a bit more about your use case? I'd expect CSQL_PROXY_ADDRESS to be set to either <IP_ADDRESS>, a static IP, or possibly <IP_ADDRESS>.

@enocom I am running Cloud SQL Proxy in GKE as a separate K8s Deployment and I want the pods to be accessible only from the current namespace. There is a low chance that someone will expose the service to the outside but using a domain name would for sure keep the traffic internal. It also might be a bit confusing.

Are you running the Proxy behind a connection pooler? Normally, we recommend running the Proxy as a sidecar (and only listen on localhost) or possibly put it behind a connection pooler (with the proxy also listening only on localhost).
There might still be a use-case here, but the root issue might be how you're using the Proxy.

Not, yet. Currently, Cloud SQL Proxy as single container in a deployment just to try things out. After my trials I will either put Cloud SQL Proxy behind pgbouncer, as is explained in the examples, or switch to the Cloud SQL Language Connectors.

Yes. Typically we expect traffic to and from the Proxy to be bound to localhost (or a pod), where the workload is contained onto a single VM.

Thanks, enocom.
I will follow the the example with PgBouncer then[1].
[2] https://github.com/GoogleCloudPlatform/cloud-sql-proxy/tree/main/examples/k8s-service


Blazor App Tutorial: Failed to load resource: the server responded with a status of 404 () for "name".styles.css

Problem encountered on https://dotnet.microsoft.com/en-us/learn/aspnet/blazor-tutorial/run
Operating System: windows 10
Error:

Page looks nothing like the example. It Looks like this:

I have not touched anything, just running all like the example says on the page mentioned above.

@danroth27 can you help here?

I got something similar, are you using app.UsePathBase()? Seems like their is an issue with the middleware.
I fixed it by adding the following to the App.razor:
<base href="@(typeof(Program).Assembly.GetName().Name)/">

@RiQ4 I believe you're hitting this problem because you have a space in your project name. Can you please try creating a new project without any spaces in the project name?

@quintendc Nope. I wasn't using app.UsePathBase() and the line of code didn't do anything, but thanks for your help.
Issue was fixed with the solution given by @danroth27. Thanks everyone.

For me, deleting the blank space in the name of the app worked.


.setValue is not a function

.setValue is not a function
Issue resolves when removing

this line (.setValue("value")), but you can't retrieve the data anymore.

Is .setDefaultValue(), not .setValue().


Allow using Satellite as manual tts/audio/media output

Please register the satellites to these lists:

It is very useful, also volumn control for the satellite as well

would be insanely useful!

In the meantime you can just install MPD to add a media_player entity to home assistant for this kind of stuff.

In the meantime you can just install MPD on the same device as the satellite to add a media_player entity to home assistant for this kind of stuff.

Just finished installing and configuring MPD, everything works as expected. There's some configuration to be made on alsa config to allow simultaneous access to card, but I figured it out.
I even installed raspotify (to cast Spotify from spotcast or phone) and now I can definitely get rid of my Google Home(s).

Perhaps a bit out of scope to ask here, but do either of you have any tips for the alsa config so both the satellite and wyoming can access the card? Are you using pulseaudio for ducking as well?

Adding more info here. I have followed what others appear to have done regarding using pulseaudio. It is running under my user context - I used pulseaudio --start -D to run it. My service file for the satellite is below:
[Unit]
Description=Wyoming Satellite
Wants=network-online.target
After=network-online.target
Requires=openwakeword.service

[Service]
Environment=PULSE_SERVER=<IP_ADDRESS>
Type=simple
ExecStart=/home/user/wyoming-satellite/script/run \
    --uri 'tcp://<IP_ADDRESS>:10700' \
    --name 'Living room satellite' \
    --awake-wav sounds/awake.wav \
    --done-wav sounds/done.wav \
    --mic-command 'parecord --property=media.role=phone --rate=16000 --channels=1 --format=s16le --raw' \
    --snd-command 'paplay --property=media.role=announce --rate=22050 --channels=1 --format=s16le --raw' \
    --snd-volume-multiplier 0.35 \
    --snd-command-rate 22050 \
    --wake-uri 'tcp://<IP_ADDRESS>:10400' \
    --wake-word-name 'ok_nabu' \
    --debug
WorkingDirectory=/home/user/wyoming-satellite
User=user
Restart=always
RestartSec=1

[Install]
WantedBy=default.target

When I start the service file I get the following error watching the debug:
DEBUG:root:Connecting to mic service: ['parecord', '--property=media.role=phone', '--rate=16000', '--channels=1', '--format=s16le', '--raw']
DEBUG:root:Connecting to snd service: ['paplay', '--property=media.role=announce', '--rate=22050', '--channels=1', '--format=s16le', '--raw']
DEBUG:root:Connecting to wake service: tcp://<IP_ADDRESS>:10400
INFO:root:Connected to services
DEBUG:root:Connected to mic service
DEBUG:root:Connected to wake service
Connection failure: Connection refused
DEBUG:root:Server set:<PHONE_NUMBER>7210
INFO:root:Waiting for wake word
WARNING:root:Mic service disconnected
DEBUG:root:Connected to mic service
Connection failure: Connection refused
WARNING:root:Mic service disconnected

However, when I use the exact same command via the commandline, it all works just fine.
DEBUG:root:Connecting to mic service: ['parecord', '--property=media.role=phone', '--rate=16000', '--channels=1', '--format=s16le', '--raw']
DEBUG:root:Connecting to snd service: ['paplay', '--property=media.role=announce', '--rate=22050', '--channels=1', '--format=s16le', '--raw']
DEBUG:root:Connecting to wake service: tcp://<IP_ADDRESS>:10400
INFO:root:Connected to services
DEBUG:root:Connected to mic service
DEBUG:root:Connected to wake service
DEBUG:root:Server set:<PHONE_NUMBER>4104
INFO:root:Waiting for wake word
DEBUG:root:Streaming audio
DEBUG:root:Connected to snd service
DEBUG:root:Event(type='transcript', data={'text': ' Turn off the kitchen lights.'}, payload=None)
INFO:root:Waiting for wake word
DEBUG:root:Event(type='synthesize', data={'text': 'Turned off the light', 'voice': {'name': 'en_US-hfc_male-medium'}}, payload=None)
DEBUG:root:Connected to snd service

I have not made any changes to any pulseaudio configurations, so have not got around to attempting ducking yet since I want this to work as a systemd service. Can anyone shed any light on what I might be missing here?

Just finished installing and configuring MPD, everything works as expected. There's some configuration to be made on alsa config to allow simultaneous access to card, but I figured it out.
I even installed raspotify (to cast Spotify from spotcast or phone) and now I can definitely get rid of my Google Home(s).

Can you provide details of your alsa config et al, for noobs like us to look at and copy?

Here's my asound.conf for reference.
It's working perfectly in my case, but it's my first time playing with this stuff, so, it may not be optimal. I adapted from other examples found online and some trial and error.
If you are using the 2mic hat you will have to replace the contents of /etc/asound.conf and also /etc/voicecard/asound_2mic.conf, as the first file is replaced at boot by the second.
Make sure the card id is correct for your system.
I disabled the other audio interfaces in mine, so that's why it's 0.
It will probably be 1 in vanilla systems.
# Default control card.
defaults.ctl.card 0

# Default playback card.
# It should usually be the same as defaults.ctl.card.
defaults.pcm.card 0

# Default device on the default card.
# 0 or 1 is usually the correct device number.
defaults.pcm.device 0

# Default subdevice on the default device.
# Should rarely need to be changed.
defaults.pcm.subdevice 0

#defaults.pcm.rate_converter speexrate_medium

# Default input and output.
pcm.!default {
    type asym
    playback.pcm {
        type plug
        slave.pcm dmixer
    }
    capture.pcm {
        type plug
        slave.pcm dsnooper
    }
}

ctl.!default {
    type hw
    card {
        @func refer
        name defaults.ctl.card
    }
}

pcm.dmixer {
    type plug
    slave {
        pcm {
            type softvol
            control {
                name PCM
                card {
                    @func refer
                    name defaults.ctl.card
                }
            }
            slave.pcm {
                type dmix
                ipc_key 47589
                ipc_perm 0666
                ipc_gid 29
                slave {
                    pcm {
                        type hw
                        card {
                            @func refer
                            name defaults.pcm.card
                        }
                        device {
                            @func refer
                            name defaults.pcm.device
                        }
                        subdevice {
                            @func refer
                            name defaults.pcm.subdevice
                        }
                    }
                }
                bindings {
                    0 0
                    1 1
                }
            }
        }
    }
}

pcm.dsnooper {
    type plug
    slave {
        pcm {
            type softvol
            control {
                name Capture
                card {
                    @func refer
                    name defaults.ctl.card
                }
            }
            slave.pcm {
                type dsnoop
                ipc_key 47533
                ipc_perm 0666
                ipc_gid 29
                slave {
                    pcm {
                        type hw
                        card 0
                        device 0
                    }
                }
            }
        }
    }
}

# Playback (RA)Spotify (mono), Output only.
pcm.spotify {
    type route #plug
    ttable {
      # Merge both channels for mono output.
      0.0 0.5
      1.0 0.5
      0.1 0.5
      1.1 0.5
    }
    slave {
        pcm {
            type softvol
            slave.pcm dmixer
            control {
                name spotify
                card {
                    @func refer
                    name defaults.ctl.card
                }
            }
        }
    }
}

# Playback MPD / media player / TTS speaker. Output only.
pcm.mplayer {
    type plug
    slave {
        pcm {
            type softvol
            slave.pcm dmixer
            control {
                name mplayer
                card {
                    @func refer
                    name defaults.ctl.card
                }
            }
        }
    }
}

# Jarvis / Wyoming-Satellite. Output and input.
pcm.jarvis {
    type asym
    capture.pcm {
        type plug
        slave.pcm dsnooper
    }
    playback.pcm {
        type plug
        slave {
            pcm {
                type softvol
                slave.pcm dmixer
                control {
                    name jarvis
                    card {
                        @func refer
                        name defaults.ctl.card
                    }
                }
            }
        }
    }
}

This will create 3 "devices" to be used: jarvis, spotify and mplayer.
So, for satellite, you use -D jarvis.

Is a link or steps available to install mpd that someone could provide. No warranty assumed. 😏

Is a link or steps available to install mpd that someone could provide. No warranty assumed. 😏

also interested, what actually is MPD though?

Is a link or steps available to install mpd that someone could provide. No warranty assumed. 😏

also interested, what actually is MPD though?

https://www.musicpd.org/

also interested, what actually is MPD though?

https://www.musicpd.org/

is there a way to set up to get TTS back to the same satellite when some onther audio souce is playing like browser youtube? By default it throws errors when something else is playing and you start the wake word and ask for command and when the TTS supposed to run with the output then it shows error that the sound device is busy or something..
How do i have satellite running and be able to listen to music and TTS at the same time?


refactor(ast): remove defunct visit_as + visit_args attrs from #[ast] macro

#4371 replaced #[visit_as(...)] and #[visit_args(...)] with #[visit(as(...))] and #[visit(args(...))]. Remove these defunct helper attributes from the #[ast] macro.

#4599  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on  Graphite

Thanks Rez!


fix for issue #34

fix for issue #34.
related: https://github.com/senzingiris/entity-search-web-app/issues/7

Issue number: #34


Add a FlatShape interface to allow manipulating the detected shapes in a unified way

Adding a common interface allows to simplify writing code like this:
private fun <T : FlatShape<T>> T.flip(): T {
    return map { x, y -> 1 - x to y }
}

private fun <T : FlatShape<T>> T.flipIfNeeded(isImageFlipped: Boolean): T {
    if (isImageFlipped) return flip()
    return this
}

Flipping detection results horizontally is used on Android when the front camera is used.

At the same time, this could be done with the when statement, and when is still used when drawing detection results in the Android demo app. So I'm not sure how necessary this is. @ermolenkodev what do you think?

I like it! I think the nice API is the main selling point of this library so this change fits perfectly


Delete org.eclipse.jdt.core.prefs

This file is unnecessary - the preferences are never used in the code itself and there are no special prefs at the time.

LBTM!!!!!!

Are you kidding me?

sry bro idk how to merge im a newbie


Whole Wrapper div is pulled left when using pagination class on boxed

Hello. While using the boxed layout, in the pages i use div class="pagination" the whole wrapper is pulled to the left like 20px. The size in always the same, just is moved to the left some px. Is not a big deal but i would like to fix it...
Thanks!

Hello @gusta21,
Could you provide a screenshot of the issue? According to what you are describing, it could be an issue with not closing the HTML tags properly because the box-layout works fine with the pagination component on my end. Thanks for reporting issues!

Im very sorry. Was just google chrome scrollbar. When page is too large,
scrollbar appears and move the whole thing to the left. I fixed in css,
showing scrollbar ever.
El oct 16, 2015 8:48 p.m., "Abdullah Almsaeed"<EMAIL_ADDRESS>escribió:

Hello @gusta21 https://github.com/gusta21,
Could you provide a screenshot of the issue? According to what you are
describing, it could be an issue with not closing the HTML tags properly
because the box-layout works fine with the pagination component on my end.
Thanks for reporting issues!
—
Reply to this email directly or view it on GitHub
https://github.com/almasaeed2010/AdminLTE/issues/724#issuecomment-148866862
.

No problem :+1:


Refactoring as advised by @zero2one

Not really a lot I can do about the codeclimate check fails I think


Add this week's API links

@charlesbaird-dsa want to put yours on here when you're ready, then we'll merge them together?

Moving to draft, as we'll get Charles' links in with this :+1:


Cannot build when following the development instructions

./build.sh or ./build.cmd to run the complete dockerized build.

This fails:

output
C:\code\.downstream\SQLStreamStore.HAL>docker build .
Sending build context to Docker daemon   1.37MB
Step 1/26 : FROM microsoft/dotnet:2.1.500-sdk-alpine3.7 AS build
 ---> 4d4ac1c1c5f3
Step 2/26 : ARG MYGET_API_KEY
 ---> Running in 7a8b3af2c97c
Removing intermediate container 7a8b3af2c97c
 ---> 178bccc0f5e2
Step 3/26 : WORKDIR /app
 ---> Running in 7c50e1ba317c
Removing intermediate container 7c50e1ba317c
 ---> b630582e1f0b
Step 4/26 : COPY .git ./
 ---> a1c5a8c8705e
Step 5/26 : RUN apk add --no-cache   nodejs   yarn   libcurl &&   dotnet tool install -g minver-cli --version 1.0.0-alpha.15 &&   /root/.dotnet/tools/minver > .version
 ---> Running in b966f3b292a4
fetch http://dl-cdn.alpinelinux.org/alpine/v3.7/main/x86_64/APKINDEX.tar.gz
fetch http://dl-cdn.alpinelinux.org/alpine/v3.7/community/x86_64/APKINDEX.tar.gz
(1/8) Installing libssh2 (1.8.0-r2)
(2/8) Installing libcurl (7.61.1-r1)
(3/8) Installing nodejs-npm (8.9.3-r1)
(4/8) Installing c-ares (1.13.0-r0)
(5/8) Installing http-parser (2.7.1-r1)
(6/8) Installing libuv (1.17.0-r0)
(7/8) Installing nodejs (8.9.3-r1)
(8/8) Installing yarn (1.3.2-r0)
Executing busybox-1.27.2-r11.trigger
OK: 101 MiB in 36 packages
Tools directory '/root/.dotnet/tools' is not currently on the PATH environment variable.
If you are using bash, you can add it to your profile by running the following command:

cat << \EOF >> ~/.bash_profile
# Add .NET Core SDK tools
export PATH="$PATH:/root/.dotnet/tools"
EOF

You can add it to the current session by running the following command:

export PATH="$PATH:/root/.dotnet/tools"

You can invoke the tool using the following command: minver
Tool 'minver-cli' (version '1.0.0-alpha.15') was successfully installed.
MinVer: Using { Commit: b59e533, Tag: '1.0.0-rc.3', Version: 1.0.0-rc.3, Height: 12 }.
Removing intermediate container b966f3b292a4
 ---> f15030cb02ac
Step 6/26 : WORKDIR /app/src
 ---> Running in 0e77f54f9fc3
Removing intermediate container 0e77f54f9fc3
 ---> cd044f20df66
Step 7/26 : COPY ./src/*.sln ./
 ---> 0b0bf2b240ef
Step 8/26 : COPY ./src/*/*.csproj ./
 ---> 64e89d273473
Step 9/26 : RUN for file in $(ls *.csproj); do mkdir -p ./${file%.*}/ && mv $file ./${file%.*}/; done
 ---> Running in ed0b8a596039
Removing intermediate container ed0b8a596039
 ---> 571c8f649110
Step 10/26 : COPY ./NuGet.Config ./
 ---> 2525110e6f97
Step 11/26 : RUN dotnet restore --runtime=alpine.3.7-x64
 ---> Running in 9e222fb70f1c
  Restoring packages for /app/src/SqlStreamStore.HAL.ApplicationServer/SqlStreamStore.HAL.ApplicationServer.csproj...
  Restoring packages for /app/src/LittleHalHost.Example/LittleHalHost.Example.csproj...
  Installing System.Runtime.CompilerServices.Unsafe 4.4.0.
  Installing Microsoft.AspNetCore.Http.Features 2.0.0.
  Installing System.Text.Encodings.Web 4.4.0.
  Installing Microsoft.Extensions.Primitives 2.0.0.
  Installing Microsoft.AspNetCore.Connections.Abstractions 2.1.3.
  Installing System.Collections.NonGeneric 4.0.1.
  Installing Microsoft.AspNetCore.Hosting.Server.Abstractions 2.0.0.
  Installing Microsoft.AspNetCore.Http.Abstractions 2.0.0.
  Installing Microsoft.Extensions.Configuration.Abstractions 2.0.0.
  Installing Microsoft.Extensions.FileProviders.Abstractions 2.0.0.
  Installing Microsoft.Extensions.Hosting.Abstractions 2.0.0.
  Installing Microsoft.Extensions.Options 2.0.0.
  Installing Microsoft.Extensions.Logging.Abstractions 2.0.0.
  Installing Microsoft.Extensions.DependencyInjection.Abstractions 2.0.0.
  Installing Microsoft.AspNetCore.Server.Kestrel.Transport.Abstractions 2.1.3.
  Installing Tavis.UriTemplates 1.1.0.
  Installing System.IO.Pipelines 4.5.1.
  Installing Microsoft.AspNetCore.Server.Kestrel 2.1.3.
  Installing Serilog.Sinks.Console 3.1.1.
  Installing Serilog.AspNetCore 2.1.1.
  Installing Halcyon 2.5.1.
  Installing SqlStreamStore 1.2.0-beta.1.3.
  Installing Microsoft.AspNetCore.Server.Kestrel.Https 2.1.3.
  Installing Microsoft.AspNetCore.Server.Kestrel.Core 2.1.3.
  Installing Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets 2.1.3.
  Installing Serilog.Extensions.Logging 2.0.0.
  Installing Microsoft.Extensions.DependencyInjection 2.0.0.
  Installing Microsoft.Extensions.Logging 2.0.0.
  Installing Microsoft.AspNetCore.Hosting.Abstractions 2.0.0.
  Installing Serilog 2.5.0.
  Installing Microsoft.NETCore.DotNetAppHost 2.1.6.
  Installing System.Threading.Tasks.Extensions 4.5.0.
  Installing Microsoft.NETCore.DotNetHostResolver 2.1.6.
  Installing Npgsql 4.0.2.
  Installing Microsoft.NETCore.DotNetHostPolicy 2.1.6.
  Installing Microsoft.NETCore.Targets 2.0.0.
  Installing Microsoft.NETCore.App 2.1.6.
  Installing SqlStreamStore.MsSql 1.2.0-build00255.
  Installing Microsoft.NETCore.Platforms 2.1.2.
  Installing SqlStreamStore.Postgres 1.2.0-build00255.
  Installing ILLink.Tasks 0.1.5-preview-1841731.
  Installing runtime.linux-musl-x64.Microsoft.NETCore.DotNetAppHost 2.1.0.
  Installing runtime.linux-musl-x64.Microsoft.NETCore.DotNetHostResolver 2.1.0.
  Installing runtime.linux-musl-x64.Microsoft.NETCore.DotNetHostPolicy 2.1.0.
  Installing runtime.linux-musl-x64.Microsoft.NETCore.App 2.1.0.
  Generating MSBuild file /app/src/LittleHalHost.Example/obj/LittleHalHost.Example.csproj.nuget.g.props.
  Generating MSBuild file /app/src/LittleHalHost.Example/obj/LittleHalHost.Example.csproj.nuget.g.targets.
  Restore completed in 7.09 sec for /app/src/LittleHalHost.Example/LittleHalHost.Example.csproj.
  Restoring packages for /app/src/SqlStreamStore.HAL.DevServer/SqlStreamStore.HAL.DevServer.csproj...
  Installing runtime.linux-musl-x64.Microsoft.NETCore.DotNetAppHost 2.1.6.
  Installing runtime.linux-musl-x64.Microsoft.NETCore.DotNetHostResolver 2.1.6.
  Installing runtime.linux-musl-x64.Microsoft.NETCore.DotNetHostPolicy 2.1.6.
  Installing runtime.linux-musl-x64.Microsoft.NETCore.App 2.1.6.
/app/src/SqlStreamStore.HAL.ApplicationServer/SqlStreamStore.HAL.ApplicationServer.csproj : error NU1102: Unable to find package SqlStreamStore with version (>= 1.2.0-build00255) [/app/src/SqlStreamStore.HAL.sln]
/app/src/SqlStreamStore.HAL.ApplicationServer/SqlStreamStore.HAL.ApplicationServer.csproj : error NU1102:   - Found 26 version(s) in nuget.org [ Nearest version: 1.1.3 ] [/app/src/SqlStreamStore.HAL.sln]
/app/src/SqlStreamStore.HAL.ApplicationServer/SqlStreamStore.HAL.ApplicationServer.csproj : error NU1102:   - Found 3 version(s) in sql-stream-store [ Nearest version: 1.2.0-beta.1.3 ] [/app/src/SqlStreamStore.HAL.sln]
/app/src/SqlStreamStore.HAL.ApplicationServer/SqlStreamStore.HAL.ApplicationServer.csproj : error NU1102:   - Found 0 version(s) in dotnet-core [/app/src/SqlStreamStore.HAL.sln]
  Generating MSBuild file /app/src/SqlStreamStore.HAL.ApplicationServer/obj/SqlStreamStore.HAL.ApplicationServer.csproj.nuget.g.props.
  Generating MSBuild file /app/src/SqlStreamStore.HAL.ApplicationServer/obj/SqlStreamStore.HAL.ApplicationServer.csproj.nuget.g.targets.
  Restore failed in 13.98 sec for /app/src/SqlStreamStore.HAL.ApplicationServer/SqlStreamStore.HAL.ApplicationServer.csproj.
  Restoring packages for /app/src/SqlStreamStore.HAL.Tests/SqlStreamStore.HAL.Tests.csproj...
/app/src/SqlStreamStore.HAL.DevServer/SqlStreamStore.HAL.DevServer.csproj : error NU1102: Unable to find package SqlStreamStore with version (>= 1.2.0-build00255) [/app/src/SqlStreamStore.HAL.sln]
/app/src/SqlStreamStore.HAL.DevServer/SqlStreamStore.HAL.DevServer.csproj : error NU1102:   - Found 26 version(s) in nuget.org [ Nearest version: 1.1.3 ] [/app/src/SqlStreamStore.HAL.sln]
/app/src/SqlStreamStore.HAL.DevServer/SqlStreamStore.HAL.DevServer.csproj : error NU1102:   - Found 3 version(s) in sql-stream-store [ Nearest version: 1.2.0-beta.1.3 ] [/app/src/SqlStreamStore.HAL.sln]
/app/src/SqlStreamStore.HAL.DevServer/SqlStreamStore.HAL.DevServer.csproj : error NU1102:   - Found 0 version(s) in dotnet-core [/app/src/SqlStreamStore.HAL.sln]
  Generating MSBuild file /app/src/SqlStreamStore.HAL.DevServer/obj/SqlStreamStore.HAL.DevServer.csproj.nuget.g.props.
  Generating MSBuild file /app/src/SqlStreamStore.HAL.DevServer/obj/SqlStreamStore.HAL.DevServer.csproj.nuget.g.targets.
  Restore failed in 11.23 sec for /app/src/SqlStreamStore.HAL.DevServer/SqlStreamStore.HAL.DevServer.csproj.
  Restoring packages for /app/src/SqlStreamStore.HAL/SqlStreamStore.HAL.csproj...
  Installing System.Buffers 4.4.0.
  Installing System.Numerics.Vectors 4.4.0.
  Installing Microsoft.CSharp 4.4.0.
  Installing LibLog 5.0.2.
  Generating MSBuild file /app/src/SqlStreamStore.HAL/obj/SqlStreamStore.HAL.csproj.nuget.g.props.
  Generating MSBuild file /app/src/SqlStreamStore.HAL/obj/SqlStreamStore.HAL.csproj.nuget.g.targets.
  Restore completed in 1.69 sec for /app/src/SqlStreamStore.HAL/SqlStreamStore.HAL.csproj.
  Installing Microsoft.Win32.Registry 4.0.0.
  Installing System.Threading.ThreadPool 4.0.10.
  Installing System.Collections.Immutable 1.2.0.
  Installing System.ComponentModel.Primitives 4.1.0.
  Installing System.ComponentModel 4.0.1.
  Installing System.Collections.Specialized 4.0.1.
  Installing System.Xml.XPath 4.0.1.
  Installing System.Diagnostics.Process 4.1.0.
  Installing System.Reflection.Metadata 1.3.0.
  Installing System.Diagnostics.TraceSource 4.0.0.
  Installing System.ComponentModel.TypeConverter 4.1.0.
  Installing System.Threading.Thread 4.0.0.
  Installing System.Diagnostics.TextWriterTraceListener 4.0.0.
  Installing System.Runtime.Loader 4.0.0.
  Installing System.Xml.XPath.XmlDocument 4.0.1.
  Installing System.ComponentModel.EventBasedAsync 4.0.11.
  Installing xunit.runner.visualstudio 2.4.0.
  Installing Microsoft.DotNet.PlatformAbstractions 1.0.3.
  Installing Microsoft.AspNetCore.TestHost 2.1.1.
  Installing Shouldly 3.0.0.
  Installing xunit 2.4.0.
  Installing Microsoft.NET.Test.Sdk 15.8.0.
  Installing xunit.abstractions 2.0.2.
  Installing xunit.analyzers 0.10.0.
  Installing xunit.assert 2.4.0.
  Installing xunit.core 2.4.0.
  Installing Microsoft.CodeCoverage 15.8.0.
  Installing Microsoft.TestPlatform.TestHost 15.8.0.
  Installing xunit.extensibility.execution 2.4.0.
  Installing xunit.extensibility.core 2.4.0.
  Installing Microsoft.Extensions.DependencyModel 1.0.3.
  Installing Microsoft.TestPlatform.ObjectModel 15.8.0.
  Generating MSBuild file /app/src/SqlStreamStore.HAL.Tests/obj/SqlStreamStore.HAL.Tests.csproj.nuget.g.props.
  Generating MSBuild file /app/src/SqlStreamStore.HAL.Tests/obj/SqlStreamStore.HAL.Tests.csproj.nuget.g.targets.
  Restore completed in 17.31 sec for /app/src/SqlStreamStore.HAL.Tests/SqlStreamStore.HAL.Tests.csproj.
The command '/bin/sh -c dotnet restore --runtime=alpine.3.7-x64' returned a non-zero code: 1

dotnet run --project build/build.csproj to build without using docker.

This also fails, but I guess it's just a case of stating the prerequisites somewhere:

output
Bullseye: Starting... (default) (parallel)
Bullseye/Clean: Starting...
Bullseye/Init: Starting...
Bullseye/Clean: Succeeded. (7.53 ms)
Working directory: ./docs
cmd /c yarn
'yarn' is not recognized as an internal or external command,
operable program or batch file.
Bullseye/Init: Failed! The process exited with code 1. (28.5 ms)
Bullseye: Failed! (default) (parallel) (54.5 ms)

Unhandled Exception: System.Exception: The process exited with code 1.
   at SimpleExec.ProcessExtensions.Throw(Process process) in C:\projects\simple-exec\SimpleExec\ProcessExtensions.cs:line 36
   at SimpleExec.Command.Run(String name, String args, String workingDirectory, Boolean noEcho) in C:\projects\simple-exec\SimpleExec\Command.cs:line 17
   at Program.Yarn(String workingDirectory, String args) in C:\code\.downstream\SQLStreamStore.HAL\build\Program.cs:line 132
   at Program.<>c.<.cctor>b__14_0() in C:\code\.downstream\SQLStreamStore.HAL\build\Program.cs:line 73
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location where exception was thrown ---
   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot)
--- End of stack trace from previous location where exception was thrown ---
   at Bullseye.Internal.ActionTarget.RunAsync(Boolean dryRun, Boolean parallel, Logger log) in C:\projects\bullseye\Bullseye\Internal\ActionTarget.cs:line 25
   at Bullseye.Internal.ActionTarget.RunAsync(Boolean dryRun, Boolean parallel, Logger log) in C:\projects\bullseye\Bullseye\Internal\ActionTarget.cs:line 31
   at Bullseye.Internal.TargetCollection.RunAsync(String name, List`1 explicitTargets, Boolean skipDependencies, Boolean dryRun, Boolean parallel, ConcurrentDictionary`2 targetsRan, Logger log, Stack`1 targets) in C:\projects\bullseye\Bullseye\Internal\TargetCollection.cs:line 83
   at Bullseye.Internal.TargetCollection.RunAsync(String name, List`1 explicitTargets, Boolean skipDependencies, Boolean dryRun, Boolean parallel, ConcurrentDictionary`2 targetsRan, Logger log, Stack`1 targets) in C:\projects\bullseye\Bullseye\Internal\TargetCollection.cs:line 70
   at Bullseye.Internal.TargetCollection.RunAsync(String name, List`1 explicitTargets, Boolean skipDependencies, Boolean dryRun, Boolean parallel, ConcurrentDictionary`2 targetsRan, Logger log, Stack`1 targets) in C:\projects\bullseye\Bullseye\Internal\TargetCollection.cs:line 70
   at Bullseye.Internal.TargetCollection.RunAsync(String name, List`1 explicitTargets, Boolean skipDependencies, Boolean dryRun, Boolean parallel, ConcurrentDictionary`2 targetsRan, Logger log, Stack`1 targets) in C:\projects\bullseye\Bullseye\Internal\TargetCollection.cs:line 70
   at Bullseye.Internal.TargetCollection.RunAsync(String name, List`1 explicitTargets, Boolean skipDependencies, Boolean dryRun, Boolean parallel, ConcurrentDictionary`2 targetsRan, Logger log, Stack`1 targets) in C:\projects\bullseye\Bullseye\Internal\TargetCollection.cs:line 70
   at Bullseye.Internal.TargetCollection.RunAsync(List`1 names, Boolean skipDependencies, Boolean dryRun, Boolean parallel, Logger log) in C:\projects\bullseye\Bullseye\Internal\TargetCollection.cs:line 34
   at Bullseye.Internal.TargetCollection.RunAsync(List`1 names, Boolean skipDependencies, Boolean dryRun, Boolean parallel, Logger log) in C:\projects\bullseye\Bullseye\Internal\TargetCollection.cs:line 47
   at Bullseye.Internal.TargetCollectionExtensions.RunAsync(TargetCollection targets, List`1 args, IConsole console) in C:\projects\bullseye\Bullseye\Internal\TargetCollectionExtensions.cs:line 171
   at Bullseye.Targets.RunTargets(IEnumerable`1 args) in C:\projects\bullseye\Bullseye\Targets.Sync.cs:line 26
   at Program.Main(String[] args) in C:\code\.downstream\SQLStreamStore.HAL\build\Program.cs:line 70

Looks like a missing myget configuration or reference to a package that is not pinned / no longer available on myget.

Looks like yarn needs to be pulled down. Probably the build script should pull down node / npm / yarn if not found on path - or at least tell you to do so.

I believe this happened when @damianh delisted several packages after migrating to minver. This should have been fixed by #45.

Yep, build.cmd now works. I think the only thing left to do here is list the pre-requisites for the dotnet run method.

Cool. I'll send a PR to enhance the readme when I get home
On Sat, Dec 15, 2018, 16:45 Adam Ralph<EMAIL_ADDRESS>wrote:

Yep, build.cmd now works. I think the only thing left to do here is list
the pre-requisites for the dotnet run method.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/SQLStreamStore/SQLStreamStore.HAL/issues/44#issuecomment-447577413,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAePh8n3s1IrqE2vahj6G-FE6T5nihu4ks5u5RjzgaJpZM4ZKEpp
.

Because of the circular-ish dependency between the SSS.Http and this HAL lib I am considering folding this repo into the main one and mono-release the lot from there. It's either that or I split up the main repo into many small ones and have the acceptance test suite as a library / submodule. Overhead & maintenance wise I think I'd prefer the single repo.
Thoughts?

I'm also annoyed with the circular dependency. One alternative is to have the http tests use a container like everything else. In fact I've started that work already here. Gave up on it for a bit as all the tests are now failing and I have no idea why :\
The advantages of a mono repo are clear, but there are some disadvantages as well. Unless there are breaking API changes, the HAL server and the SSS libs are not going to change at the same rate.

Yeah there is definitely a trade off. The mssql & postgres impl and SSS core API won't change at the same time either. Life is just easier with mono-repo publishing and... I think people will generally update all package refs at the same time. Maybe when things get really settled then independent shipping of libs could be a thing...


Background image on homepage should be optimised

The background image on the homepage is loading too slow. Normally that won't be such a problem, but in this case the layout seems broken until you realise this is in image which is still loading. I'd recommend to optimise the image and if it's still a problem on a slow connection we could show the image once it's loaded with JS.

Yes, at the moment, no images have been optimised/resized. It's on my todo when we start populating with content.

Fixed with #17


Add CRI runtime support

Add a doc for other CRI runtimes, fixes: https://github.com/kubernetes/kubeadm/issues/82
I also suggest do not include service files for these alternative CRI runtimes unless they become GA in next 2 releases. WDYT?

This change is

@chenopis Just fixed nits based on your review :)


How to add adata.layers information for running scvelo?

Hi,
I'm attempting to run scvelo on my scanpy processed 10x data.
Initially I provided the .h5ad file from scanpy as the input file for scvelo but ran into error KeyError: 'unspliced', I'm assuming unspliced data can't be found and also that "adata.layers" doesn't exist in my scanpy processed .h5ad file.
I also attempted providing the unprocessed data directly into scvelo but again came up with the error KeyError: 'unspliced'.
I've attempted adata.layers.keys() which returns odict_keys([]) and scv.pp.show_proportions(adata) which returns Abundance of []: []. (Currently running version 1.3.2 of scanpy and 0.1.11 of scvelo).
My adata file doesn't seem to contain adata.layers information, is there a way to add this information via scanpy?

Please, can you file this in the scvelo repo? Thank you! 🙂


[PaCE] How to get the "slot_values.json" file？

Hello,
When I run the python scripts, the program is clashed with error "Slot_values File is not found." How to get the "slot_values.json" file in the "glossary.py" ？

Hello, you can find the files in the updated repository.
https://github.com/AlibabaResearch/DAMO-ConvAI/blob/main/pace/data/slot_values.json


[kernel] update triton init

📌 Checklist before creating the PR

[ ] I have created an issue for this PR for traceability
[ ] The title follows the standard format: [doc/gemini/tensor/...]: A concise description
[ ] I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge
e.g. fixed #1234, closed #1234, resolved #1234

fixed #4739
📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

update triton kernel init
💥 Checklist before requesting a review

[ ] I have linked my PR to an issue (instruction)
[ ] My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
[ ] I have performed a self-review of my code
[ ] I have added thorough tests.
[ ] I have added docstrings for all the functions/methods I implemented

⭐ Do you enjoy contributing to Colossal-AI?

[ ] 🌝 Yes, I do.
[ ] 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

https://github.com/hpcaitech/ColossalAI/pull/4722 This pull request appears to have resolved the issue.

#4722 This pull request appears to have resolved the issue.

Not yet. When we import colossalai.kernel.triton.xxx, it will raise error if we have not installed triton.


sanity test fn1.1 backcompat

Description
Describe the purpose of and changes within this Pull Request.
Testing
Do any existing tests cover this change? Are new tests needed?
Documentation
Is there any documentation impact for this change?
Installation
Is there any installer impact for this change?

Looks good


Fix g.cwaread to account for serial numbers > 32767

There is a problem in g.cwaread where the sensor serial number is above the signed integer range.
I have a sensor with serial number 32846, and the serial returned in the header is -32690 so it has overflowed.
I have changed it to expect an unsigned integer, as the serial number will never be negative.

Codecov Report

Merging #217 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #217   +/-   ##
=======================================
  Coverage   75.34%   75.34%
=======================================
  Files          63       63
  Lines        7878     7878
=======================================
  Hits         5936     5936
  Misses       1942     1942

Impacted Files
Coverage Δ

R/g.cwaread.R
88.78% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b771415...659556e. Read the comment docs.

thanks Tom, much appreciated!


Use original image instead of re-encoding as max quality JPEG

MediaPicker was using UIImage.AsJPEG() to save the image picked from the camera roll.  This re-encodes the image with maximum JPEG quality, resulting in an approximate doubling of the file size and loss of the original EXIF data.
This PR makes an exact copy of the original file from the asset library unless an edited version of the image exists, in which case it still uses UIImage.AsJPEG() since that is the only way to get the edited version of the image data.
I have tested and confirmed that this fix preserves the original file size and EXIF data for unedited images.

Updated the PR to add support for Unified API


libsfml-*.so.2 symlinks not being created anymore

When building SFML with CMake on Linux (ArchLinux x86_64 in my case), and make installing, the libsfml-*.so.2 symlinks are no longer created. I'm not sure whether this was intentional or not, but currently, it breaks already compiled software that depended on that symlink.

So in a nutshell (and avoid further misunderstanding), is this an issue or not -- in other words, should it be closed or properly tagged?

It depends on our final decision. I'm (still) with binary1248, in which case this could be closed as "not an issue". ;) But we have to discuss it on the forum.

The decision has been made that only two positions (major & minor) get used for the soversion.
So is this still an issue?

Well... CMake would have to be adjusted... again :stuck_out_tongue:.

That I'm aware of, but what about the sym link issue etc.
As a barely Linux user I don't fully understand the issue.

Well... if I remove the ${VERSION_PATCH} from this line, the correct links are created again.
libsfml-system.so -> libsfml-system.so.2.2
libsfml-system.so.2.2 -> libsfml-system.so.2.2.0
libsfml-system.so.2.2.0
There is intentionally no libsfml-system.so.2 because that is reserved for the 2.0/2.1 ABI, which is not compatible with the 2.2 ABI.

With the SOVERSION change in #812 this issue will vanish.


Publish to read-the-docs

[x] Add hooks to publish repository documentation to read-the-docs

Hanna took care of it


Token code not zero-padded to correct length

https://github.com/xarenard/simpleotp/blob/c974078900aeac35676acf9448bef1ce1f5f0e64/lib/otp.js#L76
Hi @xarenard ,
I noticed that tokens that begin with a leading 0 are sometimes not the correct length.
The problem is that the if statement in the referenced line will only add one zero.
If there are two or more leading zeros required, the generated code is not the correct length.
// Sample rfc_6238 test data - should be of length "8"

const testDatas = [
  // ...
  { seconds: 3060, algorithm: 'sha1', expected_token: '00629694' },
  { seconds: 4620, algorithm: 'sha256', expected_token: '00836417' },
  { seconds: 5100, algorithm: 'sha512', expected_token: '00458766' }
]

I can submit a PR if you'd like, but it should just be a matter of updating this if statement to a while loop.

Hi,
Thanks for the feedback.I will have a look. Indeed no need for a PR
Cheers
Xavier

An updated version has been published (version 0.7.7).Let me know if it does solve your issue.

Yes - looks good. Thank you for resolving this so quickly. Much appreciated!


replicating oti_tree_id behaviour

In the nexsons, trees are a subresource of studies, so we uniquely identify a tree using a combination of studyID + treeID. I have the ottreeindex tree table set up with a simple auto-incrementing id column, a tree_label (the treeID from the nexson), a Foreign Key to study_id, plus a Unique constraint on (study_id, tree_label). OTI created a tree property oti_tree_id with form 'studyID_treeID'.
Turns out that the webapp uses oti's find_trees with the oti_tree_id property instead of the phylesystem /study/{STUDY_ID}/tree/{TREE_ID} method for efficiency in cases where it doesn't want the whole tree, but just some metadata about the tree.
I'd like to be consistent about how we use treeIDs throughout the UI and the APIs, but also don't want to force users to download large JSON files to only extract a few fields.

I note that the phylesystem_api /study method has an optional /meta syntax (see phylesystem-api docs) that returns only metadata about a study. So, one option would be to implement the same for tree, i.e. study/{study_id}/tree/{tree_id}/meta to return only metadata about a tree rather than the whole tree.

I don't think that this will be hard to add.
Can you run https://github.com/mtholder/peyotl/blob/master/scripts/phylesystem/ot_phylesystem_list_meta_for_tree.py
(which requires a local copy of phylesystem) passing it a study_id@tree_id arg.  If that script returns the info that you want, then it should be pretty easy to package that as a function in peyotl and make it accessible via the phylesystem-api.
If that script is omitting some data want, let me know.

Awesome! Pinging @jimallman to make sure this would work for the curator / webapp. These are the excluded properties:
u'^ot:rootNodeId',
u'nodeById',
u'edgeBySourceId',
u'^ot:inGroupClade',
u'@xsi:type',
u'^ot:branchLengthTimeUnit',
u'^ot:branchLengthDescription',
u'^ot:tag',
u'^ot:branchLengthMode'

actually. we probably should not exclude ^ot:tag that is easy to change.

TL;DR: I believe the exclusions above are fine, since the current web-app code only uses the find_trees method to add a tree to a collection.
Here's the code that runs when we fetch the current oti results. More specifically, this short block applies when we find a valid tree. To add an entry to the collection, we need these bits of information:

the study's ID (already in hand)
the study's ot:studyPublicationReference
the tree's ID (already in hand)
the tree's @label
the tree's ot:comment (overall description)

Items 4 (or 3, if that's empty) and 2 are combined to build the default display name for the tree in our collection, in the form "TREE_LABEL_OR_ID (STUDY_COMPACT_REF)". For example this tree would be assigned the default name "Fig. 2 BEAST (Dantas, 2016)".
Item 5 (tree description) could be used as the default "description" for this tree in the collection. However, I see that we don't currently provide any way to add or edit this field! So the default description is open for suggestions. Perhaps we'd like to build this from other tree properties in Nexson? For now, the simplest path is to ignore item 5 and use an empty string as the default description; hopefully the user will add reasons for inclusion or other useful text here.
SOMEDAY-MAYBE... If the user wants to "pin" a particular SHA for this tree, we could fetch them all in a separate operation and let the user choose one. Using the current code, this could be done by fetching the entire Nexson study and keeping only the version_history property. Or for more efficiency, we might build a tiny service that returns just a list of ordered SHAs (and commit messages) for a given study.

:thumbsup:


Having some problems after updating else for multi.vsl

I'm receiving this in pd console  when a patch is first loaded that uses multi.vsl
I can set values but the sliders never seam to update.
apologies but that is all I have to go on. I tried to re-install else a few times and the same error appears.
I've been using "Find Externals" to install else if that matters is the version available there updated?
I'm going to try a fresh pd install to see if I may have deleted something by mistake. But I don't see how I could have interrupted the installation process. This is the first time ive see a error that is labeled with [rescale]
This is the object arguments that im using.
[else/multi.vsl 285 40 0 1 12 empty empty empty 255 255 255 0 200 255 0 0 0 0 0 0 holder holder 0 0 0 0 0 0 0 0 0 0 0 0]
Here is the output to console.
[rescale]: improper args  else/rescale -clip 0 0 0 0 ... couldn't create [rescale]: improper args  else/rescale -clip 0 0 0 0 ... couldn't create [rescale]: improper args  else/rescale -clip 0 127 0 125 ... couldn't create [rescale]: improper args  else/rescale -clip 0 127 0 127 ... couldn't create sigmund~ version 0.07 warning: text size ignoring extra argument:   1 warning: text size ignoring extra argument:   1 warning: text size ignoring extra argument:   1 warning: text size ignoring extra argument:   1 warning: text size ignoring extra argument:   1 warning: text size ignoring extra argument:   1 warning: text size ignoring extra argument:   1 [rescale]: improper args  else/rescale -clip 0 0 0 0 ... couldn't create [rescale]: improper args  else/rescale -clip 0 0 0 0 ... couldn't create [rescale]: improper args  else/rescale -clip 0 127 0 125 ... couldn't create [rescale]: improper args  else/rescale -clip 0 127 0 127 ... couldn't create warning: text size ignoring extra argument:   1 warning: text size ignoring extra argument:   1 warning: text size ignoring extra argument:   1 warning: text size ignoring extra argument:   1 warning: text size ignoring extra argument:   1 warning: text size ignoring extra argument:   1 warning: text size ignoring extra argument:   1 set: empty pointer set: empty pointer

looks like -clip is the first argument for rescale and all the examples show it at the end.

yes, -clip needs to come first
this is confusing, seems like you have a broken patch that needs to be updated to the new version of ELSE?

Apologies for the delay on my response. But I fix it everything is fine.


Reconsider exposing the underlying file handle

Thanks for the great package. It has solved quite a few challenges for me. That said, I recently ran into something and I'm in a bit of a bind without having access to the file handle held by the Flock object.
I understand from other conversations in the issues that the main purpose of this library is to support lock-file based locking, rather than locking the file you intend on modifying. That is a great solution when all parties involved in modifying the file agree on the strategy. However, I need to integrate with some software on Windows which does not use that approach: it simply locks the file it intends on modifying. As mentioned elsewhere, windows locking strategy limits what you can do: you can really only operate on the file handle that was used to create the lock.
I get why it's good to keep the interface pure so that users are lead to the lock-file approach. However, this package is the best os-independent golang file locking library I've found; none of the others really measure up to it. It'd be a shame to have to reimplement so much of it just to access its internal file handle.
For now, I've forked the repo until I can come up with a better strategy (I'm under somewhat of a time crunch). That said, if there is interest in actually doing this work, we could consider starting a PR with my commit. Alternatively, I'm willing to work to add other solutions as long as they satisfy my key requirement of being able to perform operations on the os.File underlying the lock.

can we have this? prob we might want to pass the underlying file descriptors for some other use or to some other process to sync. its totally absurd that there's no way to get the underlying info about the lockfile.


Failed to load dynamic library 'libopencv_dart.so': dlopen failed: library "libopencv_dart.so" not found.

Error:
ArgumentError (Invalid argument(s): Failed to load dynamic library 'libopencv_dart.so': dlopen failed: library "libopencv_dart.so" not found)
Win10 x64, Android7(qemu),
Flutter 3.19.0 • channel stable • https://github.com/flutter/flutter.git
Framework • revision bae5e49bc2 (9 weeks ago) • 2024-02-13 17:46:18 -0800
Engine • revision 04817c99c9
Tools • Dart 3.3.0 • DevTools 2.31.1
Where is libopencv_dart.so stored in?

Read README carefully.
https://github.com/rainyl/opencv_dart?tab=readme-ov-file#important

@rainyl the readme is ambiguous. kindly clarify the most required steps to run the sample app as I'm also getting the same error while I've already tried to run the following commands:
dart run opencv_dart:setup android --arch armeabi-v7a
dart run opencv_dart:setup android --arch arm64-v8a

@VishGoria Allright, I have added more detailes in README and example
Releated issues:

https://github.com/rainyl/opencv_dart/issues/24
https://github.com/rainyl/opencv_dart/issues/23
https://github.com/rainyl/opencv_dart/issues/12

@rainyl The commands are only creating empty folders inside the opencv_dart\android\src\main\jniLibs
although the libraries are added in the opencv_dart.caches folder and I've also tried to manually copy the .tar.gz from .caches to the corresponding arch folder in android/jniLibs but still getting the same error. Urgent help required
thanks in advance

@VishGoria paste your command output please, you can also manually extract .tar.gz and copy libopencv_dart.so to corresponding directory

@rainyl The commands are only creating empty folders inside the opencv_dart\android\src\main\jniLibs although the libraries are added in the opencv_dart.caches folder and I've also tried to manually copy the .tar.gz from .caches to the corresponding arch folder in android/jniLibs but still getting the same error. Urgent help required thanks in advance

Apologize for my mistake, It is a bug, will be fixed quickly.

Launching lib/main.dart on iPhone 15 Pro in debug mode...
Running Xcode build...
└─Compiling, linking and signing...                        994ms
Xcode build done.                                            3,7s
Failed to build iOS app
Error (Xcode): Framework 'opencv_dart' not found
Error (Xcode): Linker command failed with exit code 1 (use -v to see invocation)
Could not build the application for the simulator.
Error launching application on iPhone 15 Pro.
A follow the instructions README, but not works,
Macbook air M1

I have no mac M1 so can't test, I suggest you to add -v option to see the logs or setup it manually with -f option and try again.
This package supports universal framewrok but only tested on x86_64 simulators by myself, I don't know whether it works on arm64 simulators.

Using -v for me and setting Enable flutter config --enable-native-assets but everytime that run, shows the same result
➜  dropx flutter config --enable-native-assets
Setting "enable-native-assets" value to "true".
You may need to restart any open editors for them to read new settings.
➜  dropx flutter run -v
[   +3 ms] executing: sw_vers -productName
[  +11 ms] Exit code 0 from: sw_vers -productName
[        ] macOS
[        ] executing: sw_vers -productVersion
[   +8 ms] Exit code 0 from: sw_vers -productVersion
[        ] 14.0
[        ] executing: sw_vers -buildVersion
[  +10 ms] Exit code 0 from: sw_vers -buildVersion
[        ] 23A344
[        ] executing: uname -m
[   +3 ms] Exit code 0 from: uname -m
[        ] arm64
[   +3 ms] executing: sysctl hw.optional.arm64
[   +3 ms] Exit code 0 from: sysctl hw.optional.arm64
[        ] hw.optional.arm64: 1
[  +60 ms] executing: sysctl hw.optional.arm64
[   +7 ms] Exit code 0 from: sysctl hw.optional.arm64
[        ] hw.optional.arm64: 1
[        ] executing: /usr/bin/arch -arm64e xcrun xcodebuild -version
[ +104 ms] Exit code 0 from: /usr/bin/arch -arm64e xcrun xcodebuild -version
[        ] Xcode 15.4
Build version 15F31d
[   +1 ms] executing: /usr/bin/arch -arm64e xcrun xcdevice list --timeout 5
[   +3 ms] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[        ] Artifact Instance of 'LegacyCanvasKitRemover' is not required, skipping update.
[        ] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[  +19 ms] executing: /Users/gustavovisentini/Library/Android/sdk/platform-tools/adb devices -l
[        ] executing: /usr/bin/arch -arm64e xcrun xcdevice list --timeout 2
[        ] /usr/bin/arch -arm64e xcrun simctl list devices booted iOS --json
[        ] executing: /usr/bin/arch -arm64e xcrun simctl list devices booted iOS --json
[   +1 ms] executing: /usr/bin/arch -arm64e xcrun simctl list devices booted
[  +76 ms] Exit code 0 from: /usr/bin/arch -arm64e xcrun simctl list devices booted
[        ] == Devices ==
-- iOS 17.5 --
iPhone 15 Pro (B88196B5-220A-4EFF-B167-D36273068532) (Booted)
[  +26 ms] List of devices attached
[  +66 ms] {
"devices" : {
"com.apple.CoreSimulator.SimRuntime.iOS-17-5" : [
{
"lastBootedAt" : "2024-06-26T14:07:03Z",
"dataPath" : "/Users/gustavovisentini/Library/Developer/CoreSimulator/Devices/B88196B5-220A-4EFF-B167-D36273068532/data",
"dataPathSize" :<PHONE_NUMBER>,
"logPath" : "/Users/gustavovisentini/Library/Logs/CoreSimulator/B88196B5-220A-4EFF-B167-D36273068532",
"udid" : "B88196B5-220A-4EFF-B167-D36273068532",
"isAvailable" : true,
"logPathSize" : 565248,
"deviceTypeIdentifier" : "com.apple.CoreSimulator.SimDeviceType.iPhone-15-Pro",
"state" : "Booted",
"name" : "iPhone 15 Pro"
}
]
}
}
[+2698 ms] [
{
"simulator" : true,
"operatingSystemVersion" : "17.5 (21F79)",
"available" : true,
"platform" : "com.apple.platform.iphonesimulator",
"modelCode" : "iPad16,4",
"identifier" : "0DB5D748-8101-4CFA-8A07-FE53ADC4BF32",
"architecture" : "arm64",
"modelUTI" : "com.apple.ipad-pro-m4-1",
"modelName" : "iPad Pro 11-inch (M4)",
"name" : "iPad Pro 11-inch (M4)",
"ignored" : false
},
{
"simulator" : true,
"operatingSystemVersion" : "17.5 (21F79)",
"available" : true,
"platform" : "com.apple.platform.iphonesimulator",
"modelCode" : "iPhone15,4",
"identifier" : "6C010D3B-1587-4AF3-9522-D52950C3EE12",
"architecture" : "arm64",
"modelUTI" : "com.apple.iphone-15-1",
"modelName" : "iPhone 15",
"name" : "iPhone 15",
"ignored" : false
},
{
"simulator" : true,
"operatingSystemVersion" : "17.5 (21F79)",
"available" : true,
"platform" : "com.apple.platform.iphonesimulator",
"modelCode" : "iPad14,9",
"identifier" : "5740B4B7-04C7-4ACE-865E-2DFA0B018423",
"architecture" : "arm64",
"modelUTI" : "com.apple.ipad-air-m2-1",
"modelName" : "iPad Air 11-inch (M2)",
"name" : "iPad Air 11-inch (M2)",
"ignored" : false
},
{
"simulator" : true,
"operatingSystemVersion" : "17.5 (21F79)",
"available" : true,
"platform" : "com.apple.platform.iphonesimulator",
"modelCode" : "iPad14,11",
"identifier" : "F7B8412F-C327-46B5-AA29-5AB1096852B0",
"architecture" : "arm64",
"modelUTI" : "com.apple.ipad-air-m2-13-1",
"modelName" : "iPad Air 13-inch (M2)",
"name" : "iPad Air 13-inch (M2)",
"ignored" : false
},
{
"simulator" : true,
"operatingSystemVersion" : "17.5 (21F79)",
"available" : true,
"platform" : "com.apple.platform.iphonesimulator",
"modelCode" : "iPhone16,2",
"identifier" : "B6BE2EA6-0E70-425D-A05B-6C399BA82043",
"architecture" : "arm64",
"modelUTI" : "com.apple.iphone-15-pro-max-1",
"modelName" : "iPhone 15 Pro Max",
"name" : "iPhone 15 Pro Max",
"ignored" : false
},
{
"simulator" : true,
"operatingSystemVersion" : "17.5 (21F79)",
"available" : true,
"platform" : "com.apple.platform.iphonesimulator",
"modelCode" : "iPhone16,1",
"identifier" : "B88196B5-220A-4EFF-B167-D36273068532",
"architecture" : "arm64",
"modelUTI" : "com.apple.iphone-15-pro-1",
"modelName" : "iPhone 15 Pro",
"name" : "iPhone 15 Pro",
"ignored" : false
},
{
"simulator" : true,
"operatingSystemVersion" : "17.5 (21F79)",
"available" : true,
"platform" : "com.apple.platform.iphonesimulator",
"modelCode" : "iPad16,6",
"identifier" : "CAAF8FFC-4B61-467B-B115-98691763158B",
"architecture" : "arm64",
"modelUTI" : "com.apple.ipad-pro-m4-13-1",
"modelName" : "iPad Pro 13-inch (M4)",
"name" : "iPad Pro 13-inch (M4)",
"ignored" : false
},
{
"simulator" : true,
"operatingSystemVersion" : "17.5 (21F79)",
"available" : true,
"platform" : "com.apple.platform.iphonesimulator",
"modelCode" : "iPhone15,5",
"identifier" : "64C67F0C-F6D6-4BE1-A798-2506EEE4C672",
"architecture" : "arm64",
"modelUTI" : "com.apple.iphone-15-plus-1",
"modelName" : "iPhone 15 Plus",
"name" : "iPhone 15 Plus",
"ignored" : false
},
{
"simulator" : true,
"operatingSystemVersion" : "17.5 (21F79)",
"available" : true,
"platform" : "com.apple.platform.iphonesimulator",
"modelCode" : "iPad14,1",
"identifier" : "475FDAE1-7317-4B6C-956E-643144A3794E",
"architecture" : "arm64",
"modelUTI" : "com.apple.ipad-mini6-1",
"modelName" : "iPad mini (6th generation)",
"name" : "iPad mini (6th generation)",
"ignored" : false
},
{
"simulator" : true,
"operatingSystemVersion" : "17.5 (21F79)",
"available" : true,
"platform" : "com.apple.platform.iphonesimulator",
"modelCode" : "iPad13,18",
"identifier" : "5B53FE52-2ED1-4F26-8C67-CAC5970EDE34",
"architecture" : "arm64",
"modelUTI" : "com.apple.ipad-10-1",
"modelName" : "iPad (10th generation)",
"name" : "iPad (10th generation)",
"ignored" : false
},
{
"simulator" : true,
"operatingSystemVersion" : "17.5 (21F79)",
"available" : true,
"platform" : "com.apple.platform.iphonesimulator",
"modelCode" : "iPhone14,6",
"identifier" : "100672A0-77C4-4D12-AC10-EBFDCEAFD206",
"architecture" : "arm64",
"modelUTI" : "com.apple.iphone-se3-1",
"modelName" : "iPhone SE (3rd generation)",
"name" : "iPhone SE (3rd generation)",
"ignored" : false
},
{
"ignored" : false,
"modelCode" : "MacBookAir10,1",
"simulator" : false,
"modelName" : "MacBook Air",
"operatingSystemVersion" : "14.0 (23A344)",
"identifier" : "00008103-000A348A2133001E",
"platform" : "com.apple.platform.macosx",
"architecture" : "arm64e",
"interface" : "usb",
"available" : true,
"name" : "My Mac",
"modelUTI" : "com.apple.macbookair-late-2020"
}
]
[   +1 ms] executing: /usr/bin/arch -arm64e xcrun devicectl --version
[  +63 ms] Exit code 0 from: /usr/bin/arch -arm64e xcrun devicectl --version
[        ] 355.28
[   +1 ms] executing: /usr/bin/arch -arm64e xcrun devicectl list devices --timeout 5 --json-output
/var/folders/0x/brqx8sgj01l3bf23q_70k1080000gn/T/flutter_tools.c6C4PE/core_devices.rqVerF/core_device_list.json
[+1063 ms] No devices found.
[        ] {
"info" : {
"arguments" : [
"devicectl",
"list",
"devices",
"--timeout",
"5",
"--json-output",
"/var/folders/0x/brqx8sgj01l3bf23q_70k1080000gn/T/flutter_tools.c6C4PE/core_devices.rqVerF/core_device_list.json"
],
"commandType" : "devicectl.list.devices",
"environment" : {
"TERM" : "xterm-256color"
},
"jsonVersion" : 2,
"outcome" : "success",
"version" : "355.28"
},
"result" : {
"devices" : [
           ]
         }
       }

[   +6 ms] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[   +6 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[   +2 ms] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[  +52 ms] Skipping pub get: version match.
[  +74 ms] Generating /Users/gustavovisentini/Documents/GitHub/dropx/android/app/src/main/java/io/flutter/plugins/GeneratedPluginRegistrant.java
[  +63 ms] "flutter run" took 4.364ms.
[   +5 ms] Package(s) opencv_dart require the native assets feature to be enabled. Enable using flutter config --enable-native-assets.
[        ]
#0      throwToolExit (package:flutter_tools/src/base/common.dart:10:3)
#1      nativeBuildRequired (package:flutter_tools/src/isolated/native_assets/native_assets.dart:255:5)

#2      dryRunNativeAssetsIOS (package:flutter_tools/src/isolated/native_assets/ios/native_assets.dart:26:8)

#3      dryRunNativeAssets (package:flutter_tools/src/isolated/native_assets/native_assets.dart:376:26)

#4      HotRunner.run (package:flutter_tools/src/run_hot.dart:375:26)

#5      RunCommand.runCommand (package:flutter_tools/src/commands/run.dart:833:27)

#6      FlutterCommand.run. (package:flutter_tools/src/runner/flutter_command.dart:1394:27)

#7      AppContext.run. (package:flutter_tools/src/base/context.dart:153:19)

#8      CommandRunner.runCommand (package:args/command_runner.dart:212:13)

#9      FlutterCommandRunner.runCommand. (package:flutter_tools/src/runner/flutter_command_runner.dart:372:9)

#10     AppContext.run. (package:flutter_tools/src/base/context.dart:153:19)

#11     FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:308:5)

#12     run.. (package:flutter_tools/runner.dart:130:9)

#13     AppContext.run. (package:flutter_tools/src/base/context.dart:153:19)

#14     main (package:flutter_tools/executable.dart:93:3)

[ +201 ms] ensureAnalyticsSent: 200ms
[        ] Running 1 shutdown hook
[        ] Shutdown hooks complete
[  +10 ms] exiting with code 1


⚠ Spryr has degraded performance

In 285ef0f, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 7846 ms

Resolved: Spryr performance has improved in 30bd3cf after 7 minutes.


HAWQ-1226. HAWQ core dump due to enable ranger while RPS is down

also include:

fix core dump while RPS not running
fix libcurl write_callback() problem
add libcurl timeout (hard-code 30s now)
fix some compile warnings
fix compile error: add json.h to checkinc.py

@linwen @xunzhang @stanlyxiang @zhangh43 help to review, thanks.

fix core dump while RPS not running
rangerrest.c:435

fix libcurl write_callback() problem
rangerrest.c:374

add libcurl timeout (hard-code 30s now)
rangerrest.c:451

fix some compile warnings

fix compile error: add json.h to checkinc.py

@interma Could you please attach the compile warning message you fixed here?

@xunzhang warning:
be-secure.c:322:1: warning: unused function 'report_commerror' [-Wunused-function]
report_commerror(const char *err_msg)
^
1 warning generated.
rangerrest.c:63:37: warning: 'json_object_object_get' is deprecated [-Wdeprecated-declarations]
struct json_object accessObj = json_object_object_get(response, "access");
^
/usr/local/include/json-c/json_object.h:290:56: note: 'json_object_object_get' has been explicitly marked deprecated here
THIS_FUNCTION_IS_DEPRECATED(extern struct json_object json_object_object_get(struct json_object* obj,
^
rangerrest.c:74:16: warning: 'json_object_object_get' is deprecated [-Wdeprecated-declarations]
jallow = json_object_object_get(jvalue, "allowed");
^
/usr/local/include/json-c/json_object.h:290:56: note: 'json_object_object_get' has been explicitly marked deprecated here
THIS_FUNCTION_IS_DEPRECATED(extern struct json_object* json_object_object_get(struct json_object* obj,
^
rangerrest.c:406:30: warning: format string is not a string literal (potentially insecure) [-Wformat-security]
appendStringInfo(&tname, rps_addr_host);
^~~~~~~~~~~~~
rangerrest.c:406:30: note: treat the string as an argument to avoid this
appendStringInfo(&tname, rps_addr_host);
^
"%s",
3 warnings generated.

Return RANGERCHECK_UNKNOWN has some problem.
check_privilege_from_ranger is call by pg_rangercheck which returns AclResult. But RANGERCHECK_UNKNOWN is belong to RangerACLResult. We need to unify them.

Fixed review problems already.
Tks, guys!

+1

I will open a new PR, closed this.


docs(cosmos-db scaler): Introduce helm-docs for documentation

Implements the same from PR #446 for the external-scaler-azure-cosmos-db.
Related to:

#444

Checklist

[x] I have verified that my change is according to the deprecations & breaking changes policy
[x] Commits are signed with Developer Certificate of Origin (DCO - learn more)
[x] README is updated with new configuration values (if applicable)

Thanks for this awesome contribution ❤  This tool is fascinating
WDYT @kedacore/keda-helm-contributors ?


Applied the result of a git diff

Description
Minor code cleanup and footprint reduction post the first major telemetry milestone in https://github.com/pokt-network/pocket/pull/135.
Type of change
Please mark the options that are relevant.

[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation
[X] Other: Code cleanup

How Has This Been Tested?
I did a docker wipe to start on a clean slate.

[X] make test_all
[X] LocalNet

Checklist

[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have tested my changes using the available tooling
[X] If applicable, I have made corresponding changes to related or global README
[X] If applicable, I have added added new diagrams using mermaid.js
[X] If applicable, I have added tests that prove my fix is effective or that my feature works

@derrandz I messed up https://github.com/pokt-network/pocket/pull/159/files and merged it into PR 158.
I just did a git diff of that PR and applied it to a new branch off of main - which is this PR. PTAL


Update environments-details.md

clear environment information and a extra note

@stasfilin I've reviewed the PR. Let me know if I can publish, or if I should wait for a go ahead.

@katarzyna-koltun-mx yes, we can publish. Thanks!


feat: add basic pydantic support for python models

Description

Classes are inherited from BaseModel
Fields are annotated

Related issue(s)
Resolves #963

Not sure what I should do with black-box testing

Not sure what I should do about black-box test failure

Ignore it, it's part of #905

@all-contributors please add @zaytsevand for code, example, doc, test


The org.springframework.cloud.context.properties.ConfigurationPropertiesRebinder#rebind()  works in wrong result by deleting the cofniguration

the code like this:
@Data
@ToString
@ConfigurationProperties(value = MonitorPluginConfiguration.PREFIX)
public class MonitorPluginConfiguration {
    public static final String PREFIX = "monitor";
    private Map<String, String> plugins;
}

the yaml configuration in nacos:
monitor:
  plugins:
    p1: 1
    p2: 2
    p3: 3
    p4: 4

if i delete the key-value  p4: 4 in the configuration from nacos ，the value for field MonitorPluginConfiguration#plugins will not be deleted.
the changed configuration in nacos after delete the  the key-value  p4: 4
monitor:
  plugins:
    p1: 1
    p2: 2
    p3: 3

I trace the code , i find the method in org.springframework.boot.context.properties.bind.MapBinder#merge，
        @Override
	protected Map<Object, Object> merge(Supplier<Map<Object, Object>> existing, Map<Object, Object> additional) {
		Map<Object, Object> existingMap = getExistingIfPossible(existing);
		if (existingMap == null) {
			return additional;
		}
		try {
			existingMap.putAll(additional);
			return copyIfPossible(existingMap);
		}
		catch (UnsupportedOperationException ex) {
			Map<Object, Object> result = createNewMap(additional.getClass(), existingMap);
			result.putAll(additional);
			return result;
		}
	}

the parmater additional value is {p1=1, p2=2, p3=3}

and the variable existingMap value is {p1=1, p2=2, p3=3, p4=4}

for the code existingMap.putAll(additional), it will save the original value  {p1=1, p2=2, p3=3, p4=4}.
so the result is bad.
I think that it is good to execute existingMap.clear() before  executing the code existingMap.putAll(additional)
The code like this:
        @Override
	protected Map<Object, Object> merge(Supplier<Map<Object, Object>> existing, Map<Object, Object> additional) {
		Map<Object, Object> existingMap = getExistingIfPossible(existing);
		if (existingMap == null) {
			return additional;
		}
		try {
			existingMap.clear(); // add this line
			existingMap.putAll(additional);
			return copyIfPossible(existingMap);
		}
		catch (UnsupportedOperationException ex) {
			Map<Object, Object> result = createNewMap(additional.getClass(), existingMap);
			result.putAll(additional);
			return result;
		}
	}

this issue I have raise at https://github.com/spring-projects/spring-boot/issues/32877, but I got the reply like this

debug tracing like this,

org.springframework.cloud.context.properties.ConfigurationPropertiesRebinder#rebind(),
org.springframework.cloud.context.properties.ConfigurationPropertiesRebinder#rebind(java.lang.String)
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory#initializeBean(java.lang.Object, java.lang.String)
......
the last action org.springframework.boot.context.properties.bind.MapBinder#merge

Here is the issue in Spring Boot https://github.com/spring-projects/spring-boot/issues/32877

As discussed in https://github.com/spring-cloud/spring-cloud-commons/issues/818 there is nothing we can do from a Spring Cloud perspective to address this.  The best we can do is update the documentation to add a note about this limitation when performing a refresh.


🐛 BUG: SvelteKit Still Had Null Body Response Error

What version of Wrangler are you using?
0.0.15
What operating system are you using?
Windows
Describe the Bug
SvelteKit still gets null body response error which was fixed in https://github.com/cloudflare/miniflare/releases/tag/v2.0.0-rc.3, not sure how Wrangler2 incorporates miniflare, is there a pending version update or is this a separate issue?
SETUP
npm init svelte@next my-app
npm i --save-dev @sveltejs/adapter-cloudflare@next
Update svelte.config.js to use adapter.
npm install

LAUNCH
npx wrangler pages dev --proxy 3000 -- npx svelte-kit dev --host
ERROR
When viewing project on _http://localhost:8788/_ page will alternate between rendering correctly and showing this:

BEHAVIOR
When viewing same page with network tab open and disable cache enabled, error does not occur
Output:
[pages:err] GET /: TypeError: Response with null body status cannot have body
    at new Response (E:\Programming\Projects\ArtPageSvelteWrangler\node_modules\undici\lib\fetch\response.js:160:15)
    at new Response (E:\Programming\Projects\ArtPageSvelteWrangler\node_modules\@miniflare\core\src\standards\http.ts:556:13)
    at Object.construct (E:\Programming\Projects\ArtPageSvelteWrangler\node_modules\@miniflare\core\src\plugins\core.ts:69:29)
    at Object.fetch (<script>:5:24)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at EventTarget.[kDispatchFetch] (E:\Programming\Projects\ArtPageSvelteWrangler\node_modules\@miniflare\core\src\standards\event.ts:359:13)
    at Server.<anonymous> (E:\Programming\Projects\ArtPageSvelteWrangler\node_modules\@miniflare\http-server\src\index.ts:167:20)
GET / 500 Internal Server Error (22.61ms)

Thank you for reporting this, and sorry for the trouble! Could you try this with wrangler@alpha? There's a small chance we've already fixed this, but I'm not sure atm.

No trouble at all! All comes with the fun of using new things eh?
Wrangler was updated to 0.0.0-536c7e5 and issue still occurs with same behaviour as above.

Well damn. Alright, we'll figure this out. Thanks again for the report!

Don't know where it is, but this is because somewhere (either in wrangler or in SvelteKit), a Response is being constructed incorrectly.
I've made the mistake myself several times before (usually when cloning an existing Response). This is what you need to do.

Completely untested, but looks like it might be this line in SvelteKit: https://github.com/sveltejs/kit/blob/master/packages/adapter-cloudflare/files/worker.js#L17

Had a quick look at this. It seems that the Worker is returning a 304 - Unmodified response that also has a body, which undici is then complaining about. It might have been that this was also the case (?) but we were using a http client that didn't complain about this?

@GregBrimble - I tried changing that line but still got the error.
From what I can make out it is miniflare that is dispatching the response, but I guess that is just being proxied from svelte?

We've found the issue. The problem is in the Miniflare proxy. @GregBrimble is working on a fix. In the meantime, you can (sort of) workaround this by building the Svelte app and then running the build output via pages directly...
npm run build
npx wrangler pages dev .svelte-kit/cloudflare

Fix here: https://github.com/cloudflare/miniflare/pull/172


Issue with k8s.io/de/docs/setup/

This is a Bug Report

Problem:
Links not working
Proposed Solution:
Page to Update:
https://kubernetes.io/...

/assign
Sent with GitHawk

@Trackhe could you please specify the links?

@gavinfish I thought I had the correct link here with Reported.
I'm sorry it was already some 100 pages ago. if it comes up to me again I report and report it conscientiously this time.


README: add Luke Hinds to Security Committee

Nomination email sent to kubernetes-security-discuss
https://groups.google.com/forum/#!forum/kubernetes-security-discuss
I want to nominate Luke Hinds to join the Product Security Committee as
a full member. He has been an associate member since June 26th 2019
and in that role over the last three months he has helped on a number of
tasks including:

Coordinating CVE-2019-11251 announcement
Writing Kubernetes Security Committee on-boarding guide

Our process for accepting this nomination is lazy consensus and I will
close the round of consensus on Oct 18th, 2019 to leave time for any
comments or question. If the nomination is accepted Luke will take on
the full responsibilities of a Security Committee member and take on a
weekly rotation for<EMAIL_ADDRESS>on-call rotation.

lgtm

/lgtm
/approve

/lgtm


added allargs constructor to entities.

This allows them to be instantiated with values without json. This is useful for testing.
It also makes it easier to switch them to "data" classes if the need ever arises.
Reason: I am trying to use this library in a project, and I can't create the entities to pass to my code for testing purposes.

Codecov Report

Merging #53 into master will decrease coverage by 3.15%.
The diff coverage is 63%.

@@             Coverage Diff              @@
##             master      #53      +/-   ##
============================================
- Coverage     61.29%   58.13%   -3.16%
  Complexity      147      147
============================================
  Files            43       43
  Lines           633      633
  Branches         60       60
============================================
- Hits            388      368      -20
- Misses          231      251      +20
  Partials         14       14

Impacted Files
Coverage Δ
Complexity Δ

...n/java/com/sys1yagi/mastodon4j/api/entity/Error.kt
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...a/com/sys1yagi/mastodon4j/api/entity/Attachment.kt
100% <100%> (ø)
7 <7> (ø)
:arrow_down:

...com/sys1yagi/mastodon4j/api/entity/Relationship.kt
100% <100%> (ø)
7 <7> (ø)
:arrow_down:

...java/com/sys1yagi/mastodon4j/api/entity/Results.kt
100% <100%> (ø)
4 <4> (ø)
:arrow_down:

...java/com/sys1yagi/mastodon4j/api/entity/Context.kt
100% <100%> (ø)
3 <3> (ø)
:arrow_down:

...sys1yagi/mastodon4j/api/entity/auth/AccessToken.kt
100% <100%> (ø)
1 <1> (ø)
:arrow_down:

...ava/com/sys1yagi/mastodon4j/api/entity/Instance.kt
100% <100%> (ø)
6 <6> (ø)
:arrow_down:

.../java/com/sys1yagi/mastodon4j/api/entity/Report.kt
100% <100%> (ø)
3 <3> (ø)
:arrow_down:

...in/java/com/sys1yagi/mastodon4j/api/entity/Card.kt
100% <100%> (ø)
5 <5> (ø)
:arrow_down:

...java/com/sys1yagi/mastodon4j/api/entity/Mention.kt
20% <20%> (-60%)
1 <1> (ø)

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9e87f5...2c14f54. Read the comment docs.

thanks. LGTM

v1.1.0 released 🎊
https://jitpack.io/#sys1yagi/mastodon4j/1.1.0
compile 'com.github.sys1yagi.mastodon4j:mastodon4j:1.1.0'


activate ci file

Add .travis.yml file to root folder in preparation for activating travis CI

merged as no impact on node app or db


Receiving "missing-input-response" in google response

In the validate class, $this->_value is not set in public function isValid($value, $context = null).
protected function _verify() then uses $this->_value to build query string.
This results in an empty value being passed to the google api servers.

I fixed this issue via my pull request.
It was merged into master https://github.com/cgsmith/zf1-recaptcha-2/blob/master/src/Cgsmith/Validate/Recaptcha.php

Closing since it is merged in. Let me know if there are any other issues 👍


Pause when holding an arrow key

When pressing an arrow the animation to move starts immediately - that is great. But when you want to move further and you hold the arrow button there is a significant delay before it starts.
I understand it's a system behavior on how the keypresses are processed. Workaround would be to have our own little game-like loop which triggers the event as long as keyup doesn't happen, like here:
https://stackoverflow.com/questions/11197220/javascript-move-delay-and-multiple-keystrokes
Is this something you've considered?

Yes, great idea! I think this is the first time it's been mentioned, but I agree it would be a nice improvement.
Let me know if you're interested in working on this, and I can help point you to the right part of the code.

Hi, I can try to work on this and submit a pull request!

@iangilman if you can point me to the right part of the code as you suggested, I can try to fix this. Thanks!

@MichaelYogar Great! Apologies for the delayed response… If you're still interested, here's the info…
You'll want to give the viewer an object property to keep track of which keys are pressed. That can be done somewhere in the viewer's constructor:
https://github.com/openseadragon/openseadragon/blob/4ab8cc748188f6c4dc5ad7d23e91945dd0194173/src/viewer.js#L65
Then you can update the "key down" handler to modify the "keys pressed" object:
https://github.com/openseadragon/openseadragon/blob/4ab8cc748188f6c4dc5ad7d23e91945dd0194173/src/viewer.js#L2536
You'll need to make a new "key up" handler and hook it up here:
https://github.com/openseadragon/openseadragon/blob/4ab8cc748188f6c4dc5ad7d23e91945dd0194173/src/viewer.js#L289
Then every time through the update loop you can check the keys and pan the viewer as appropriate:
https://github.com/openseadragon/openseadragon/blob/4ab8cc748188f6c4dc5ad7d23e91945dd0194173/src/viewer.js#L3280
Be sure to honor the functionality that's already built in the "key down" handler. Also note that we may need to adjust the speed once it's happening every frame, so it's not too fast.
As you can see, this is probably more work than a simple "good first issue", though I don't think it requires understanding of the rest of the code, so it is a good introduction to the code base if you're up for it. Let me know if you have additional questions!

@iangilman Hey, thanks for your reply! I'm still interested in doing this for sure. If this is urgent, you might want to assign it to someone else. If not, I can give this a shot around next month because I'm busy now.

Could this be done in the following way, update pressed_key in OnCanvasKeyDown, set pressed_key to null onCanvasKeyUp (if the release key is the same as stored pressed key). And then move all the onCanvasKeyPress switch case statement code to updateOnce.
Regarding, speed we can add a variable that lets us control how many events per second will be detected. This way user has control over how fast the controls work. Do you totally agree with this approach or not

@HamzaTatheer Yes, that seems like a good approach! The pressed key variable should be an object, with each key code being a property key in the object... That way we can keep track of multiple keys down at the same time (so you can hold both W and A to move diagonally).
Also, it would be good to keep track of when the user leaves the window and clean out all of the pressed keys, since we don't get keyup events when our window isn't focused. I think you can get that by watching the blur event on window.

Alright Makes Sense, I want to know that can two people complete this at the same time. How could they collaborate. After forking, What should be the flow

okay I will try to work on this. Seems like a relatively easy task. If I don't complete all of it, Can someone carry on by contributing to the forked repo that I have

@HamzaTatheer Great! And yes; if you start a PR, but can't finish it, or if you link to the branch from here, it can be a starting point for the next person.

Anyone working on this or is there a stalled PR?

Not that I'm aware of. Did you make any progress on this, @HamzaTatheer?


AvP crash when language is not english

Game
Aliens versus Predator
Engine
AvP
Linux Distribution
Archlinux
Luxtorpeda Version
luxtorpeda-git-37.0.0.r292.5cf7383-1
Bug description
Hi!!
In first place, thank you so much, your work is incredible and was a great discover for me.
There is a minor issue with AvP, but neuromancer git is archived and I don't know if he will return:
https://github.com/neuromancer/avp/issues/8
This issue happens only in no-english AvP versions like german (issue reported), spanish (confirmed by me) and maybe in french or italian, I think the problem is with special characters in those languages.
There is a dirty-fix than is comment this Render line in avp_menus.c:
`static void RenderHelpString()
{
	AVPMENU_ELEMENT *elementPtr = &AvPMenus.MenuElements[AvPMenus.CurrentlySelectedElement];

	if(elementPtr->HelpString!=TEXTSTRING_BLANK && AvPMenus.MenusState != MENUSSTATE_INGAMEMENUS)
	{
		RECT area;
		//draw the attached string at the bottom of the screen

		area.left=MENU_LEFTXEDGE;
		area.right=MENU_RIGHTXEDGE;
		area.top=420;
		area.bottom=ScreenDescriptorBlock.SDB_Height;

		//RenderSmallFontString_Wrapped(GetTextString(elementPtr->HelpString),&area,BRIGHTNESS_OF_HIGHLIGHTED_ELEMENT,0,0);

	}
}`

Is possible than you'll send a different avp compiled file with this fix to steam clients than no have english language configured for this game in Steam?
Thank you and go ahead with all project!! Is incredible!!
Steps To Reproduce
Change AvP language in Steam to spanish or german.
Launch game and move to the third menu section, it have a special character in the help section.
Crash!
Expected Behavior
No crash :)
Additional Context
No response
Relevant log output
No response

@cyberconan
Thanks for the report. What does commenting out that line do visually, if anything? Mainly curious for the english version.

Only hides the bottom message in main main, better this than a crash :)

@cyberconan Ah ok, thank you. I'm working on creating a build for testing now. I'll update with my findings soon.

Wonderful @d10sfan ! Thanks!!


Is it possible to hide quick-explorer's address bar from the lower left?

Hello PJ, I have been installing this plugin since I started using OB very early. It is a very convenient and efficient plugin.
Recently I noticed that the new version displays quick-explorer's address bar in the lower leftAt the same time, the top address bar can also be used normally
Which seems redundant. Because I often pay attention to the sidebar, this change seems to visually destroy the “ left-center-right ” visual layout of OB.
So I want to confirm: can I hide the address bar in the lower left ? maybe CSS or anthers.
thanks~

If you have the Style Settings plugin, it will have an option to hide the standalone QE bar.  (It shows up down there by default because you can turn off the tab title bar, and would then have no way to access QE in that case.)

If you have the Style Settings plugin, it will have an option to hide the standalone QE bar. (It shows up down there by default because you can turn off the tab title bar, and would then have no way to access QE in that case.)

Great, perfectly solved my needs
I never knew that the setting UI is in Style Setting. I think this can be put in the homepage  to let more people who have the same confusion know.
thanks~

Second sentence of the very first paragraph of the home page is, "If you want to hide QE's default breadcrumbs, you can turn them off using the Style Settings plugin."


Conda pcl 1.9.1 is not compiled with OMP

The title of this issue is lacking, but the problem seems fairly straightforward. If I create a Conda environment that solves for PCL, pclpy, and other required dependencies for our project (e.g. Cudf / CuPy), PCL 1.9.1 is selected, and it does not appear to implement OpenMP.
Your primary example uses MovingLeastSquaresOMP, but this is not available in Conda with the PCL version selected (i.e. method not available). Before I proceed with a new compilation of 1.9 with OpenMP, I want to ask which version of Conda PCL you are using to expose the OMP methods to the pclpy wrapper.

I can confirm that even by following the Readme directions to a tee to create a specific Conda environment with all necessary requirements, pclpy no longer has access to OMP methods. The error that is consistently thrown is:
AttributeError: module 'pclpy.pcl.surface' has no attribute 'MovingLeastSquaresOMP'
I have both downloaded and compiled PCL-1.9.1 from source separately, verifying that CMake is able to identify and use OpenMP as well as run the pclpy script download_pcl.sh in a Conda environment. In both cases, pclpy's wrapper is unable to surface the OMP methods.
To confirm this problem, I compiled a simple C++ implementation for the same OMP methods, and it works perfectly fine. I would prefer not to have to create a custom Python module for these methods, but it would seem we are left with few options.