reply issue by email

TODOs:

[ ] test code is not finished

view now:

fix #9067

This is not secure and won't work as is since it will let you send an email and post a comment as any user you want since it only checks the from address which can be anything the user wants -- there needs to be unique keys per user that GItea already knows or can calculate in order to verify a message.
Github does this that each issue/pull has a unique ID for each user and that is included in the reply-to address in order to verify a comment (which require sub addressing) like  Reply-To: go-gitea/gitea<EMAIL_ADDRESS>Gitlab has a second option that if you can't create random/unique reply to addresses you can put the unique value in side the "References" header which most mail programs will include in the reply.

This is not secure and won't work as is since it will let you send an email and post a comment as any user you want since it only checks the from address which can be anything the user wants -- there needs to be unique keys per user that GItea already knows or can calculate in order to verify a message.
Github does this that each issue/pull has a unique ID for each user and that is included in the reply-to address in order to verify a comment (which require sub addressing) like  Reply-To: go-gitea/gitea<EMAIL_ADDRESS>Gitlab has a second option that if you can't create random/unique reply to addresses you can put the unique value in side the "References" header which most (but not all) mail programs will include in the reply.

Ok, Thanks. I see, I not use in-reply-to because many mail service not use the message-id set by user, they will generate their's own, but set other heads (for example X-Microsoft-Original-Message-ID).
But I forgot References, maybe it's usefull, for secure, we should generate an uniq password and append it on the email to send and check it when recived emails.
some usefull message in RFC 2822
https://tools.ietf.org/html/rfc2822
When creating a reply to a message, the "In-Reply-To:" and
   "References:" fields of the resultant message are constructed as
   follows:

   The "In-Reply-To:" field will contain the contents of the "Message-
   ID:" field of the message to which this one is a reply (the "parent
   message").  If there is more than one parent message, then the "In-
   Reply-To:" field will contain the contents of all of the parents'
   "Message-ID:" fields.  If there is no "Message-ID:" field in any of
   the parent messages, then the new message will have no "In-Reply-To:"
   field.

   The "References:" field will contain the contents of the parent's
   "References:" field (if any) followed by the contents of the parent's
   "Message-ID:" field (if any).  If the parent message does not contain
   a "References:" field but does have an "In-Reply-To:" field
   containing a single message identifier, then the "References:" field
   will contain the contents of the parent's "In-Reply-To:" field
   followed by the contents of the parent's "Message-ID:" field (if
   any).  If the parent has none of the "References:", "In-Reply-To:",
   or "Message-ID:" fields, then the new message will have no
   "References:" field.

Codecov Report

Merging #13585 (e6ada29) into master (5a991ec) will decrease coverage by 0.18%.
The diff coverage is 14.62%.

@@            Coverage Diff             @@
##           master   #13585      +/-   ##
==========================================
- Coverage   42.21%   42.03%   -0.19%
==========================================
  Files         697      701       +4
  Lines       76563    76977     +414
==========================================
+ Hits        32320    32356      +36
- Misses      38945    39316     +371
- Partials     5298     5305       +7

Impacted Files
Coverage Δ

modules/base/tool.go
64.63% <ø> (ø)

services/imap/cron.go
0.00% <0.00%> (ø)

services/imap/imap.go
0.94% <0.94%> (ø)

services/imap/mail_reciver.go
2.60% <2.60%> (ø)

modules/setting/mail_recive.go
28.57% <28.57%> (ø)

modules/cron/tasks_extended.go
69.23% <66.66%> (-0.25%)
:arrow_down:

models/issue_comment.go
53.63% <76.92%> (+0.91%)
:arrow_up:

services/mailer/mail.go
62.43% <89.47%> (+1.14%)
:arrow_up:

models/issue.go
56.66% <100.00%> (+0.07%)
:arrow_up:

modules/setting/setting.go
46.23% <100.00%> (+0.11%)
:arrow_up:

... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a991ec...e6ada29. Read the comment docs.

Please resolve the conflicts.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@d2163df). Click here to learn what that means.
The diff coverage is 11.08%.

@@           Coverage Diff           @@
##             main   #13585   +/-   ##
=======================================
  Coverage        ?   45.29%
=======================================
  Files           ?      802
  Lines           ?    89344
  Branches        ?        0
=======================================
  Hits            ?    40465
  Misses          ?    42372
  Partials        ?     6507

Impacted Files
Coverage Δ

cmd/hook.go
7.78% <0.00%> (ø)

models/notification.go
64.71% <ø> (ø)

modules/base/tool.go
93.47% <ø> (ø)

services/imap/cron.go
0.00% <0.00%> (ø)

services/imap/imap.go
0.00% <0.00%> (ø)

services/imap/mail_receiver.go
2.65% <2.65%> (ø)

modules/setting/mail_receive.go
28.57% <28.57%> (ø)

models/issue_comment.go
51.98% <46.15%> (ø)

modules/cron/tasks_extended.go
69.92% <66.66%> (ø)

services/mailer/mail.go
62.58% <75.00%> (ø)

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2163df...5589c19. Read the comment docs.

I'm not sure what's the status of this PR, but if subadressing is not available and headers are not preserved, it is always possible to include the token in the title of the email, it is preserved by all clients I guess (at most they will append some texts like "Re")


Account Estimated Value in BTC

Hi,
Is there a way to get the "Estimated Value" for an account?

Hey there,
Unfortunately not. You would have to iterate through all your balances and calculate the estimated amounts yourself. A limitation of the API and not the wrapper.

I see that the PHP lib has that feature.
https://github.com/jaggedsoft/php-binance-api/wiki/1.-Getting-Started
I can add a PR for this. Let me know if you are cool with that.


Add support to show-hide-content.js for form fields with more varied …

…characters (including periods) in their name attribute.
I’m not sure I added the tests in quite the right way — any advice welcome.
Fixes issue #402 https://github.com/alphagov/govuk_frontend_toolkit/issues/402

Could this issue be fixed by just quoting the name attribute reference?
var selector = selectors.radio + '[name="' + escapeElementName($control.attr('name')) + '"][aria-controls]'


Clear Chat button causes reappearing message

Please provide us with the following information:

This issue is for a: (mark with an x)
- [X] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

Start a chat session by clicking on a suggested questions
Get a response for one of the suggested questions
Click the "Clear Chat" button
Click on another suggested question
Observe the old response that was cleared come back, before being replaced by the new response

Any log messages given by the failure

None, only visual

Expected/desired behavior

Cleared messages do not come back

OS and Version?

Windows 7, 8 or 10. Linux (which distribution). macOS (Yosemite? El Capitan? Sierra?)

Reproducible on Windows 11 and Linux (Codespaces) hosts

azd version?

run azd version and copy paste here.
azd version 1.3.0 (commit 6605c5768cb3ab6d9e0e6c2d892c9e8b49e1f720)

Versions

Reproducible on main branch

Mention any other details that might be useful

Thanks! We'll be in touch soon.

Repro Video

I'm able to reproduce the issue with the documentation seen on this issue. Can someone confirm that this is indeed fixed?

No, I cannot replicate. Please upload a video or GIF. Thanks!


Code format for ShardingScaling module

Pull Request Test Coverage Report for Build 1973

18 of 29 (62.07%)  changed or added relevant lines in 17 files are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.06%) to 59.756%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

sharding-scaling/sharding-scaling-mysql/src/main/java/org/apache/shardingsphere/shardingscaling/mysql/binlog/MySQLPasswordEncryptor.java
0
1
0.0%

sharding-scaling/sharding-scaling-postgresql/src/main/java/org/apache/shardingsphere/shardingscaling/postgresql/wal/decode/TestDecodingPlugin.java
6
7
85.71%

sharding-scaling/sharding-scaling-bootstrap/src/main/java/org/apache/shardingsphere/shardingscaling/Bootstrap.java
0
2
0.0%

sharding-scaling/sharding-scaling-postgresql/src/main/java/org/apache/shardingsphere/shardingscaling/postgresql/PostgreSQLJdbcReader.java
0
3
0.0%

sharding-scaling/sharding-scaling-mysql/src/main/java/org/apache/shardingsphere/shardingscaling/mysql/MySQLJdbcReader.java
0
4
0.0%

Files with Coverage Reduction
New Missed Lines
%

sharding-scaling/sharding-scaling-bootstrap/src/main/java/org/apache/shardingsphere/shardingscaling/Bootstrap.java
1
0%

sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java
2
80.0%

Totals

Change from base Build 9974:
0.06%

Covered Lines:
12507

Relevant Lines:
20930

💛  - Coveralls


Remove bower.json

To reduce the maintenance the bower.json will be remove if there isn't any specific requests to keep it.

Will this still allow adding milsymbol to our own project's bower.json with "milsymbol": "0.5.6" for example?

I just wasn't sure if anyone was using bower, or if all just were using npm, but since you are using bower I will keep the file and everything should work as usual.

Thanks! Since you don't have any dependencies on other libraries hopefully the only overhead of keeping bower.json is updating the version number. 😉


implement asynchronous tasks

Resolves #2
Task handlers are now able to return ErrAsynchronousTask to proceed with continuing the task process outside of the original task worker goroutine. At some later time, an associated task goroutine will call the methods task.AsyncProcessor() to specify that the task has finally completed (or failed)
The motivation behind this change is to eliminate the need for blocking goroutines for each task, while the task is being processed asynchronously. However, in order to continue to support task timeouts via context.Context, one goroutine handles watching for task status updates, task timeouts, and asynq shutdown and finishes processing tasks as needed

It is worth noting that the timeout received by the processor is made from 2 things:

a timeout
a deadline

If none are specified the client sets a default timeout.
Deadlines receive a special treatment in that the recoverer periodically checks for dead lines exceeded and retries the corresponding tasks (see recoverer.recover).

From my understanding, timeouts, whether the default or custom, are all converted into deadlines by the time the task is queued
Since we are just concerned with handling the task finishing/cleanup, we shouldn't really need to touch any part of the actual retry mechanism or rely on it for that matter, as far as I can see so far

With that in mind, I am wondering if the asynchronous-isation could be made simpler: I pushed a sketch in branch asynchronous-tasks2 if you want to take a look.
note: this is how the 'timeout' is retrieved when dequeuing:
https://github.com/qluvio/asynq/blob/029717f45eb62661e420694b8283b1fa8e3953ce/internal/rqlite/tasks.go#L648-L659

After reviewing the example code, one issue is that we are not able to control the calls to p.handleFailedMessage, p.handleSucceededMessage, and p.requeue in the case that a timeout is supposed to occur; the async task will presumably proceed to call ResultHandler.Res() and trigger these calls even if a timeout occurs, unless the task happens to constantly check for ctx.Done(), but I don't think we can/should rely on that behavior.
Another issue happens with p.sema, which would needs to be released in every situation, whether ResultHandler works normally or a timeout occurs, so something still needs to actually watch for the timeout, rather than let asynq just restart the task regardless
At least that's from my current understanding of how the processor works; do you suggestions for handling these cases?

Another issue happens with p.sema, which needs to be released in every situation

It would be released immediately after task.h <- resultHandlerFn, but (just realized) there would also be a need to not put msg in the p.finished channel...
And:

yes the handler would need to check for ctx.Done
or rely on a deadline option (as opposed to a timeout option) to have the recoverer handle it (and restart the task).

OK, let's forget about the idea :-)


OOP school library: preserve data

On exit from the app saved data (books, people, and rentals) into JSON files.
On startup of the app loaded all data from files. handled the case when one or more of the files are missing.

Hi @VaheStepanyan100 and @AbdelazizSoliman, please fix the Rubocop linter error 👍🏿


Towards cares upgrade with mingw

This is getting closer but is a work in progress since I haven't successfully built the ruby artifacts yet.
Docker file updates updates mingw/gcc to 6.2.
This still needs some compiler warnings turned off and ability to find openssl headers.
now failing with:
compilation terminated.
Makefile:2523: recipe for target '/tmp/objs/opt/src/core/lib/security/credentials/jwt/jwt_verifier.o' failed
make: *** [/tmp/objs/opt/src/core/lib/security/credentials/jwt/jwt_verifier.o] Error 1
In file included from ./src/core/lib/security/credentials/jwt/jwt_credentials.h:23:0,
                 from src/core/lib/security/credentials/google_default/google_default_credentials.c:31:
./src/core/lib/security/credentials/jwt/json_token.h:23:25: fatal error: openssl/rsa.h: No such file or directory
 #include <openssl/rsa.h>
                         ^
compilation terminated.
Makefile:2523: recipe for target '/tmp/objs/opt/src/core/lib/security/credentials/google_default/google_default_credentials.o' failed
make: *** [/tmp/objs/opt/src/core/lib/security/credentials/google_default/google_default_credentials.o] Error 1
src/core/tsi/ssl_transport_security.c:42:25: fatal error: openssl/bio.h: No such file or directory
 #include <openssl/bio.h>
                         ^
compilation terminated.
Makefile:2523: recipe for target '/tmp/objs/opt/src/core/tsi/ssl_transport_security.o' failed
make: *** [/tmp/objs/opt/src/core/tsi/ssl_transport_security.o] Error 1
third_party/cares/cares/ares_process.c: In function 'socket_recvfrom':
third_party/cares/cares/ares_process.c:339:29: error: conversion to 'int' from 'size_t {aka long long unsigned int}' may alter its value [-Werror=conversion]
    return recvfrom(s, data, data_len, flags, from, from_len);
                             ^~~~~~~~
cc1: all warnings being treated as errors
Makefile:2523: recipe for target '/tmp/objs/opt/third_party/cares/cares/ares_process.o' failed
make: *** [/tmp/objs/opt/third_party/cares/cares/ares_process.o] Error 1
third_party/cares/cares/ares_init.c: In function 'contains_suffix':
third_party/cares/cares/ares_init.c:1339:13: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
     if (len == (end - beg) && !strnicmp(beg, suffix, len))
             ^~
third_party/cares/cares/ares_init.c: In function 'get_SuffixList_Windows':
third_party/cares/cares/ares_init.c:1430:32: error: passing argument 1 of 'next_suffix' from incompatible pointer type [-Werror=incompatible-pointer-types]
       while (len = next_suffix(&pp, len))
                                ^
third_party/cares/cares/ares_init.c:1347:15: note: expected 'const char **' but argument is of type 'char **'
 static size_t next_suffix(const char** list, const size_t advance)
               ^~~~~~~~~~~
third_party/cares/cares/ares_init.c:1430:7: error: suggest parentheses around assignment used as truth value [-Werror=parentheses]
       while (len = next_suffix(&pp, len))

This looks great, thanks for the contribution!


Cannot access my controller

I've been staring and trying stuff for the past hours and cannot find why one of my controllers does not want to be triggered...
Posting this in hope somebody can point me in the right direction.
Controller:
using Chromely.Core.Network;
using CTEPDotNetLib.Transactions.Retail;
using NerdPOS.DTOs;
using NerdPOS.Logic.JSON;
using NerdPOS.Peripherals.Terminals.Worldline;
using NerdPOS.Services;
using System.Linq;
using System.Text.Json;

namespace NerdPOS.Controllers
{
    [ControllerProperty(Name = "TerminalController", Route = "terminalcontroller")]
    public class TerminalController : ChromelyController, IYomaniListener
    {
        private readonly ClientEventsService ClientEventsService;

        private Yomani _instance;
        private Yomani YomaniInterface
        {
            get
            {
                if (_instance == null)
                {
                    _instance = new Yomani(this);
                }

                return _instance;
            }
            set
            {
                _instance = value;
            }
        }

        public TerminalController(ClientEventsService clientEventsService)
        {
            ClientEventsService = clientEventsService;

            RegisterGetRequest("/terminal/start", StartTerminal);
            RegisterGetRequest("/terminal/stop", StopTerminal);
        }

        [HttpGet(Route = "/terminal/start")]
        public ChromelyResponse StartTerminal(ChromelyRequest request)
        {
            YomaniInterface.StartService();
            return new ChromelyResponse() { RequestId = request.Id };
        }

        [HttpGet(Route = "/terminal/stop")]
        public ChromelyResponse StopTerminal(ChromelyRequest request)
        {
            YomaniInterface.StopService();
            return new ChromelyResponse() { RequestId = request.Id };
        }

        [HttpPost(Route = "/terminal/payment")]
        public ChromelyResponse CreateOrder(ChromelyRequest request)
        {
            var payment = ((JsonElement)request.PostData).ToObject<Payment>();

            YomaniInterface.ProcessPayment(YomaniInterface.TerminalIdentifiers.First(), payment);

            return new ChromelyResponse()
            {
                RequestId = request.Id
            };
        }

        public void OnPaymentSuccesfull(SaleResult result)
        {
            /*
                authorized amount: 1
	            authorization code: D44812
	            sale system action identifier: 01020300
            */
            ClientEventsService.SendEvent("terminalPaymentSuccess", new
            {
                amount = result.authorizedAmount(),
                authorizationCode = result.authorizationCode(),
                timestamp = result.timeStamp(),
                actionIdentifier = result.saleSystemActionIdentifier() // TODO we might need to pass this in?
            });
        }

        public void OnPaymentFailed(string code, string description)
        {
            ClientEventsService.SendEvent("terminalPaymentFailed", new
            {
                code, description
            });
        }

        public void OnTerminalListUpdated()
        {
            ClientEventsService.SendEvent("terminalListUpdated", YomaniInterface.TerminalIdentifiers);
        }

        public void OnStatusUpdate(string status)
        {
            ClientEventsService.SendEvent("terminalStatusUpdate", status);
        }
    }
}

Registration:
container.RegisterSingleton(typeof(ChromelyController), Guid.NewGuid().ToString(), typeof(TerminalController));

Calling:
    messageRouterGet(
      "/terminal/start",
      null,
      () => {
        console.log("terminal start sent");
      },
      (...params) => {
        console.log("terminal sent failed", params);
      }
    );

messageRouterGet (little adaptation on the one from the examples):
export function messageRouterGet(url, parameters, callback, onError, mocks) {
  var request = {
    method: "GET",
    url: url,
    parameters: parameters,
    postData: null,
  };

  if (!window.cefQuery) {
    if (callback) callback(mocks);
    return;
  }

  window.cefQuery({
    request: JSON.stringify(request),
    onSuccess: (response) => {
      var jsonData = JSON.parse(response);
      if (jsonData.ReadyState == 4 && jsonData.Status == 200) {
        if (callback) callback(jsonData.Data);
      } else {
        console.log(
          "An error occurs during message routing. With ur:" +
            url +
            ". Response received:" +
            response
        );
      }
    },
    onFailure: (err, msg) => {
      console.error(err, msg);
      if (onError) onError(err, msg);
    },
  });
}

I've been using this setup for multiple controllers for a while now and everything works fine. But this controller does not want to trigger.
I added the RegisterGetRequest calls as a last resort to get them called, but to no avail.
The messageRouterGet is being called correctly, but never returns, no success and no error.
If anyone can help me, That would be amazing!

@Nickman87
Only thing I see is,  you have 5 parameters in messageRouterGet method definition. You are passing 4 parameters.
messageRouterGet(url, parameters, callback, onError, mocks)

Also you have:
 RegisterGetRequest("/terminal/start", StartTerminal);

and
[HttpGet(Route = "/terminal/start")]

You need to pick one. The system will register the first one it encounters. Consequent ones with same url keys will be ignored.

@mattkol thanks for the response.
The double route registration was a last resort try. The method is just never triggered.
The missing parameter of the messageRouterGet should not be an issue, as I even call it with just a single parameter in some places and it works perfectly.
Is there a way to debug the actual registered routes in the Chromely framework?

@Nickman87
Sure you can debug the registered routes - you can see if the route is registered - Routes but if you asked me I won't spend that much time there at the initial stage. You said it works for other controllers, right?
I will suggest you do the following first:

Ensure you are actually calling messageRouterGet method. Put as many console logs as possible and use DevTools to see if you are getting the console messages. If you are sure the ceQuery is being triggered and there is no error in devtools (html/js errors),then you can focus on the controller.
Something like: (not sophisticated, yes, but helps quickly to localize).

export function messageRouterGet(url, parameters, callback, onError, mocks) {
 *****console.log('message 1');

  var request = {
--
  };

  if (!window.cefQuery) {
  }

  *****console.log('message 2');

  window.cefQuery({
    onSuccess: (response) => {
       *****console.log('message 3');
         ---
      }
    },
    onFailure: (err, msg) => {
     *****console.log('message 4');
     --
    },
  });
}

At the controller end - use System.Console.Writeline too .. using breakpoints sometime may not help because of mulithreading.
If you are now sure it is the controller then you can start with simple skeletal controller that works. You can change the url keys  "/terminal/start" to "/terminal/start001" for instance to  make sure it is not being used somewhere else in your app.
Also I am guessing this is React App. If it is start with the demo and work backwards.

I noticed use of "module.export" and "this" in the demo .. cannot remember the details around that - https://github.com/chromelyapps/demo-projects/blob/4dff87d6fbb5c09ef59ca3ffab901bad167dc24a/angular-react-vue/ChromelyReact/reactapp/src/services/Chromely.Service.js#L2


Seldon (edge-bundle) failing in charmed kubernetes deployment

After deploying edge bundle to charmed kubernetes on AWS Seldon-core is failing:

Running
kubectl deploy kubeflow --channel=latest/edge --trust

Container logs:
❯ kubectl logs -f seldon-controller-manager-54cd8dcfc-prvxz -n kubeflow
Defaulted container "seldon-core" out of: seldon-core, juju-pod-init (init)
{"level":"info","ts":1674829552.0947893,"logger":"setup","msg":"Intializing operator"}
{"level":"info","ts":1674829552.1163418,"logger":"setup","msg":"CRD not found - trying to create"}
{"level":"error","ts":1674829552.2253666,"logger":"setup","msg":"unable to initialise operator","error":"the server could not find the requested resource","stacktrace":"github.com/go-logr/zapr.(*zapLogger).Error\n\t/go/pkg/mod/github.com/go-logr/zapr@v0.1.1/zapr.go:128\nmain.main\n\t/workspace/main.go:149\nruntime.main\n\t/usr/local/go/src/runtime/proc.go:203"}

Attaching logs
dump.log
Sledon only logs:
❯ juju debug-log --replay | grep seldon
controller-0: 14:56:45 INFO juju.worker.caasapplicationprovisioner.runner start "seldon-controller-manager"
controller-0: 15:06:24 INFO juju.worker.caasprovisioner started operator for application "seldon-controller-manager"
application-seldon-controller-manager: 15:06:26 INFO juju.cmd running jujud [2.9.34 90e2f047763059f0b8a57941ae0907346464aee8 gc go1.19]
application-seldon-controller-manager: 15:06:26 DEBUG juju.cmd   args: []string{"/var/lib/juju/tools/jujud", "caasoperator", "--application-name=seldon-controller-manager", "--debug"}
application-seldon-controller-manager: 15:06:26 DEBUG juju.agent read agent config, format "2.0"
application-seldon-controller-manager: 15:06:26 INFO juju.worker.upgradesteps upgrade steps for 2.9.34 have already been run.
application-seldon-controller-manager: 15:06:26 INFO juju.cmd.jujud caas operator application-seldon-controller-manager start (2.9.34 [gc])
application-seldon-controller-manager: 15:06:26 DEBUG juju.worker.dependency "clock" manifold worker started at 2023-01-27 14:06:26.196880263 +0000 UTC
application-seldon-controller-manager: 15:06:26 DEBUG juju.worker.dependency "agent" manifold worker started at 2023-01-27 14:06:26.197542092 +0000 UTC
application-seldon-controller-manager: 15:06:26 DEBUG juju.worker.dependency "upgrade-steps-gate" manifold worker started at 2023-01-27 14:06:26.198022058 +0000 UTC
application-seldon-controller-manager: 15:06:26 DEBUG juju.worker.introspection introspection worker listening on "@jujud-application-seldon-controller-manager"
application-seldon-controller-manager: 15:06:26 DEBUG juju.worker.dependency "caas-units-manager" manifold worker started at 2023-01-27 14:06:26.1988468 +0000 UTC
application-seldon-controller-manager: 15:06:26 DEBUG juju.worker.introspection stats worker now serving
application-seldon-controller-manager: 15:06:26 DEBUG juju.worker.apicaller connecting with old password
application-seldon-controller-manager: 15:06:26 DEBUG juju.worker.dependency "api-config-watcher" manifold worker started at 2023-01-27 14:06:26.208160367 +0000 UTC
application-seldon-controller-manager: 15:06:26 DEBUG juju.worker.dependency "upgrade-steps-flag" manifold worker started at 2023-01-27 14:06:26.210204205 +0000 UTC
application-seldon-controller-manager: 15:06:26 DEBUG juju.worker.dependency "migration-fortress" manifold worker started at 2023-01-27 14:06:26.220874831 +0000 UTC
application-seldon-controller-manager: 15:06:26 DEBUG juju.api successfully dialed "wss://<IP_ADDRESS>:17070/model/3ebd7f9f-23d7-4c10-82d4-68a99d6006b4/api"
application-seldon-controller-manager: 15:06:26 INFO juju.api connection established to "wss://<IP_ADDRESS>:17070/model/3ebd7f9f-23d7-4c10-82d4-68a99d6006b4/api"
application-seldon-controller-manager: 15:06:26 INFO juju.worker.apicaller [3ebd7f] "application-seldon-controller-manager" successfully connected to "<IP_ADDRESS>:17070"
application-seldon-controller-manager: 15:06:26 DEBUG juju.api RPC connection died
application-seldon-controller-manager: 15:06:26 DEBUG juju.worker.dependency "api-caller" manifold worker completed successfully
application-seldon-controller-manager: 15:06:26 DEBUG juju.worker.apicaller connecting with old password
application-seldon-controller-manager: 15:06:26 DEBUG juju.api successfully dialed "wss://<IP_ADDRESS>:17070/model/3ebd7f9f-23d7-4c10-82d4-68a99d6006b4/api"
application-seldon-controller-manager: 15:06:26 INFO juju.api connection established to "wss://<IP_ADDRESS>:17070/model/3ebd7f9f-23d7-4c10-82d4-68a99d6006b4/api"
application-seldon-controller-manager: 15:06:26 INFO juju.worker.apicaller [3ebd7f] "application-seldon-controller-manager" successfully connected to "<IP_ADDRESS>:17070"
application-seldon-controller-manager: 15:06:26 DEBUG juju.worker.dependency "api-caller" manifold worker started at 2023-01-27 14:06:26.255014228 +0000 UTC
application-seldon-controller-manager: 15:06:26 DEBUG juju.worker.dependency "caas-units-manager" manifold worker completed successfully
application-seldon-controller-manager: 15:06:26 DEBUG juju.worker.dependency "caas-units-manager" manifold worker started at 2023-01-27 14:06:26.263643616 +0000 UTC
application-seldon-controller-manager: 15:06:26 DEBUG juju.worker.dependency "upgrade-steps-runner" manifold worker started at 2023-01-27 14:06:26.265520702 +0000 UTC
application-seldon-controller-manager: 15:06:26 DEBUG juju.worker.dependency "upgrade-steps-runner" manifold worker completed successfully
application-seldon-controller-manager: 15:06:26 DEBUG juju.worker.dependency "upgrader" manifold worker started at 2023-01-27 14:06:26.267809453 +0000 UTC
application-seldon-controller-manager: 15:06:26 DEBUG juju.worker.dependency "log-sender" manifold worker started at 2023-01-27 14:06:26.267974806 +0000 UTC
application-seldon-controller-manager: 15:06:26 DEBUG juju.worker.dependency "migration-minion" manifold worker started at 2023-01-27 14:06:26.268182889 +0000 UTC
application-seldon-controller-manager: 15:06:26 DEBUG juju.worker.dependency "migration-inactive-flag" manifold worker started at 2023-01-27 14:06:26.27124827 +0000 UTC
application-seldon-controller-manager: 15:06:26 INFO juju.worker.caasupgrader abort check blocked until version event received
application-seldon-controller-manager: 15:06:26 INFO juju.worker.migrationminion migration phase is now: NONE
application-seldon-controller-manager: 15:06:26 DEBUG juju.worker.caasupgrader current agent binary version: 2.9.34
application-seldon-controller-manager: 15:06:26 INFO juju.worker.caasupgrader unblocking abort check
application-seldon-controller-manager: 15:06:26 DEBUG juju.worker.logger initial log config: "<root>=DEBUG"
application-seldon-controller-manager: 15:06:26 DEBUG juju.worker.dependency "proxy-config-updater" manifold worker started at 2023-01-27 14:06:26.284435601 +0000 UTC
application-seldon-controller-manager: 15:06:26 DEBUG juju.worker.dependency "charm-dir" manifold worker started at 2023-01-27 14:06:26.284655444 +0000 UTC
application-seldon-controller-manager: 15:06:26 INFO juju.worker.logger logger worker started
application-seldon-controller-manager: 15:06:26 DEBUG juju.worker.dependency "api-address-updater" manifold worker started at 2023-01-27 14:06:26.284730685 +0000 UTC
application-seldon-controller-manager: 15:06:26 DEBUG juju.worker.dependency "logging-config-updater" manifold worker started at 2023-01-27 14:06:26.284764145 +0000 UTC
application-seldon-controller-manager: 15:06:26 DEBUG juju.worker.dependency "hook-retry-strategy" manifold worker started at 2023-01-27 14:06:26.314754686 +0000 UTC
application-seldon-controller-manager: 15:06:26 DEBUG juju.worker.logger reconfiguring logging from "<root>=DEBUG" to "<root>=INFO"
application-seldon-controller-manager: 15:06:26 WARNING juju.worker.proxyupdater unable to set snap core settings [proxy.http= proxy.https= proxy.store=]: exec: "snap": executable file not found in $PATH, output: ""
application-seldon-controller-manager: 15:06:26 INFO juju.worker.caasoperator.charm downloading ch:amd64/focal/seldon-core-58 from API server
application-seldon-controller-manager: 15:06:26 INFO juju.downloader downloading from ch:amd64/focal/seldon-core-58
application-seldon-controller-manager: 15:06:26 INFO juju.downloader download complete ("ch:amd64/focal/seldon-core-58")
application-seldon-controller-manager: 15:06:26 INFO juju.downloader download verified ("ch:amd64/focal/seldon-core-58")
application-seldon-controller-manager: 15:06:32 INFO juju.worker.caasoperator operator "seldon-controller-manager" started
application-seldon-controller-manager: 15:06:32 INFO juju.worker.caasoperator.runner start "seldon-controller-manager/0"
application-seldon-controller-manager: 15:06:32 INFO juju.worker.leadership seldon-controller-manager/0 promoted to leadership of seldon-controller-manager
application-seldon-controller-manager: 15:06:32 INFO juju.agent.tools ensure jujuc symlinks in /var/lib/juju/tools/unit-seldon-controller-manager-0
application-seldon-controller-manager: 15:06:32 INFO juju.worker.caasoperator.uniter.seldon-controller-manager/0 unit "seldon-controller-manager/0" started
application-seldon-controller-manager: 15:06:32 INFO juju.worker.caasoperator.uniter.seldon-controller-manager/0 resuming charm install
application-seldon-controller-manager: 15:06:32 INFO juju.worker.caasoperator.uniter.seldon-controller-manager/0.charm downloading ch:amd64/focal/seldon-core-58 from API server
application-seldon-controller-manager: 15:06:32 INFO juju.downloader downloading from ch:amd64/focal/seldon-core-58
application-seldon-controller-manager: 15:06:32 INFO juju.downloader download complete ("ch:amd64/focal/seldon-core-58")
application-seldon-controller-manager: 15:06:32 INFO juju.downloader download verified ("ch:amd64/focal/seldon-core-58")
application-seldon-controller-manager: 15:06:39 INFO juju.worker.caasoperator.uniter.seldon-controller-manager/0 hooks are retried true
application-seldon-controller-manager: 15:06:39 INFO juju.worker.caasoperator.uniter.seldon-controller-manager/0 found queued "install" hook
application-seldon-controller-manager: 15:06:40 INFO unit.seldon-controller-manager/0.juju-log Running legacy hooks/install.
application-seldon-controller-manager: 15:06:45 INFO juju.worker.caasoperator.uniter.seldon-controller-manager/0.operation ran "install" hook (via hook dispatching script: dispatch)
application-seldon-controller-manager: 15:06:45 INFO juju.worker.caasoperator.uniter.seldon-controller-manager/0 found queued "leader-elected" hook
application-seldon-controller-manager: 15:06:48 INFO juju.worker.caasoperator.uniter.seldon-controller-manager/0.operation ran "leader-elected" hook (via hook dispatching script: dispatch)
application-seldon-controller-manager: 15:06:55 INFO juju.worker.caasoperator.uniter.seldon-controller-manager/0.operation ran "config-changed" hook (via hook dispatching script: dispatch)
application-seldon-controller-manager: 15:06:55 INFO juju.worker.caasoperator.uniter.seldon-controller-manager/0 found queued "start" hook
application-seldon-controller-manager: 15:06:55 INFO unit.seldon-controller-manager/0.juju-log Running legacy hooks/start.
application-seldon-controller-manager: 15:06:57 INFO juju.worker.caasoperator.uniter.seldon-controller-manager/0.operation ran "start" hook (via hook dispatching script: dispatch)
application-seldon-controller-manager: 15:08:12 INFO juju.worker.caasoperator.uniter.seldon-controller-manager/0.operation ran "config-changed" hook (via hook dispatching script: dispatch)
application-seldon-controller-manager: 15:09:42 INFO juju.worker.caasoperator started pod init on "seldon-controller-manager/0"
application-seldon-controller-manager: 15:11:11 INFO juju.worker.caasoperator.uniter.seldon-controller-manager/0.operation ran "update-status" hook (via hook dispatching script: dispatch)
application-seldon-controller-manager: 15:16:25 INFO juju.worker.caasoperator.uniter.seldon-controller-manager/0.operation ran "update-status" hook (via hook dispatching script: dispatch)
application-seldon-controller-manager: 15:22:16 INFO juju.worker.caasoperator.uniter.seldon-controller-manager/0.operation ran "update-status" hook (via hook dispatching script: dispatch)
application-seldon-controller-manager: 15:27:56 INFO juju.worker.caasoperator.uniter.seldon-controller-manager/0.operation ran "update-status" hook (via hook dispatching script: dispatch)

1.6/stable is working for charmed kubeflow

Hi @misohu, the bundle you are deploying points to a bundle with outdated versions of the charms. Do you mind re-deploying but instead of using latest/edge can you use 1.6/edge or 1.6/stable and share your results?


I assume  It will append the text to the file

I wanted to look in this documentation to verify if my assumption is correct.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: dce19346-9252-ec27-5487-fb395c9cf876
Version Independent ID: a5b53654-73d7-12b3-4ba4-e4d03b2ef4a1
Content: FileIO.WriteTextAsync Method (Windows.Storage) - Windows UWP applications
Content Source: https://cpubwin.visualstudio.com/DefaultCollection/windows-uwp/_git/winrt-api-build?path=%2fwinrt-api-build%2fwindows.storage.fileio.yml&version=GBlive&_a=contents
Product: uwp
Technology: winrt-reference
Git Login: knicholasa
Microsoft Alias: nichola

Ok, I just saw AppendTextAsync so I was probably wrong :)

You got it :) The Work with files doc talks about this in the section on writing text to a file. WriteTextAsync will replace the contents of the file, while AppendTextAsync will append it.

I don't see WriteBytesAsync or WriteBufferAsync. How do I do this if I wanted to append bytes[] to the file.


Commas cause -e to mangle the expression

alexs-air-3:rust alex$ cargo script -e '[1, 2]'
   Compiling expr v0.1.0 (file:///Users/alex/.multirust/toolchains/beta/cargo/.cargo/script-cache/expr-68f9e2ff5dd19fe8)
error: incorrect close delimiter: `}`
 --> /Users/alex/.multirust/toolchains/beta/cargo/.cargo/script-cache/expr-68f9e2ff5dd19fe8/expr.rs:5:4
  |
5 | {[1}
  |    ^
  |
note: unclosed delimiter
 --> /Users/alex/.multirust/toolchains/beta/cargo/.cargo/script-cache/expr-68f9e2ff5dd19fe8/expr.rs:5:2
  |
5 | {[1}
  |  ^

error: aborting due to previous error

error: Could not compile `expr`.

I believe this is clap's fault; you need to call use_delimiter(false) somewhere.

cc https://github.com/kbknapp/clap-rs/issues/655
Setting use_delimiter(false) will fix this, but I'm working to keep this from being an issue in the future as well.

@kbknapp you are quick! I'll submit a PR with the workaround anyway. It does seem like a poor default.

oh, this is the case of the "weird failure" I mentioned over in #35


Update the content of Package.md and README.md file and Fix the icon res issue

Description:
This task is to track the following two tasks for all Standard Libraries.

Update the content of the Package.md and README.md files to have the same content as in the Module.md file.

We need to replace the overview section with the overview section in the Module.md file.

Fix the resolution issue in the icon. Replace the current icon with a high-resolution image.

 We need a patch release to reflect in the BC


TypeChecking - inquiry

If one wanted to add type-checking (something like flow)
Would you recommend to add type-checking in the codeGenerator function? && perhaps define rules - for each Callee?
the-super-tiny-compiler.js
L: 973
function codeGenerator(node) {
...
case 'CallExpression':
      runTypeChecker( node );

Rules
function runTypeChecker( node ) {
     if( node.callee.name === 'subtract') {
       for( let i = 0; i < node.arguments.length; i++) {
         if(node.arguments[i].type !== 'NumberLiteral') {
           throw node.arguments[i].value + ' should be of type Number';
         }
       }
     }
}

I'm actually writing another guide "The super tiny type checker" which will cover this in the future

Also, type checking is generally its own step in the compiler pipeline AFAIK

is there any research I can do? would love to help
if "The super tiny type checker" repo is started :)
Good luck with the move to Sydney


[WIP] Add github.com/go-chi/chi instrumentation

This new module instruments the github.com/go-chi/chi package.

[ ] Comply with OpenTelemetry HTTP semantic conventions
[x] Package documentation
[ ] Exported objects are documented
[ ] Tests and linting are passing
[x] Includes dependabot config
[x] Library added to README.md
[x] CHANGELOG.md updated

Codecov Report

Merging #227 (10fc9be) into main (cdeaa76) will decrease coverage by 0.54%.
The diff coverage is n/a.

:exclamation: Current head 10fc9be differs from pull request most recent head fce44ab. Consider uploading reports for the commit fce44ab to get more accurate results

@@            Coverage Diff             @@
##             main     #227      +/-   ##
==========================================
- Coverage   74.68%   74.14%   -0.55%
==========================================
  Files          38       38
  Lines        1833     1833
==========================================
- Hits         1369     1359      -10
- Misses        422      430       +8
- Partials       42       44       +2

Flag
Coverage Δ

Linux
74.14% <ø> (ø)

Windows
?

macOS
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...n/github.com/lib/pq/splunkpq/internal/connector.go
51.75% <0.00%> (-5.03%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdeaa76...fce44ab. Read the comment docs.


Cannot start project

Hello guys, I cloned this code and run 'npm install' to install library needed to run. After run this command, I run script {start} in package.json. But I have a issue: Error: Cannot find module 'package-json-versionify' from '../video-annotator/timeliner'.. I hope that, I can receive answer from everyone, all comments are valuable. Thanks

same issue here


Maybe add throttling for the "GC" operation while tracing new root futures?

I have noticed there is a TODO in Registery::register:
https://github.com/risingwavelabs/await-tree/blob/334b563fdd4e3b96252f559e0f87149bb4e8b5e0/src/registry.rs#L79-L81
I guess this will make spawning an task become O(m) operation where m is the current running task. Perhaps we can add a new config like gc_throttle_duration: Option<Duration> (default None). Once it become Some, the registry will maintain the coarse instant of last GC, new register callls within this period again won't trigger GC anymore.
I have written a simple bench to test that spawns many background tasks(Even not really usual in real word, this case was usually used to show how coroutines are lighter that threads):
Details

    fn traced_multi_thread(size: usize) {
        let pool = tokio::runtime::Builder::new_multi_thread()
            .enable_time()
            .build()
            .unwrap();
        let futs = (0..size)
            .map(|_| {
                pool.spawn(root!(async {
                    tokio::time::sleep(std::time::Duration::from_millis(100)).await
                }))
            })
            .collect::<Vec<_>>();
        pool.block_on(futures::future::join_all(futs));
    }

Where root is a simple macro registers the current line to the register function. What it did like:
    pub fn root<T>(
        fut: impl Future<Output = T>,
    ) -> impl Future<Output = T> {
        let id = TID.fetch_add(1, SeqCst);
        REG.lock().unwrap().register(id, concat!(file!(), ":", line!(), ",", column!())).instrument(fut)
    }

The result shows comparing to the baseline with 10,000 tasks , there was a 3x performance regression, which is huge I think.
running 2 tests
test bench_async_trace::multi_thread::baseline_multi_thread_10000 ... bench: 101,856,955 ns/iter (+/- 345,245)
test bench_async_trace::multi_thread::traced_multi_thread_10000   ... bench: 308,596,986 ns/iter (+/- 3,973,652)

I haven't do further works now. If somewhere I'm wrong during benching or something else please let me know. If the new option is acceptable I'm glad to do further perfing to test whether the solution is effect and providing a patch.

Fixed in #9


Add inbound security rule image out of date

The "add inbound security rule" image in this article is out of date and doesn't show the current set of options for Azure. This was confusing for one of my students. Please update the picture and associated text.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4b29d46b-5a37-3e56-00a5-98971bce4f6c
Version Independent ID: 87d3401e-dca7-20b1-5544-64f72e83eb54
Content: Open ports to a VM using the Azure portal - Azure Virtual Machines
Content Source: articles/virtual-machines/windows/nsg-quickstart-portal.md
Service: virtual-machines
Sub-service: networking
GitHub Login: @cynthn
Microsoft Alias: cynthn

@jwilliams45-aug Thanks for the feedback! I've filed a PR to update the instructions and screenshots. Should be live early next week. Thanks again!
#please-close


Add Mario Clock application

Mario Clock is a low-res (80x80) watch face with Mario running
through a level. He jumps to hit the bricks, which changes the
time displayed.
Pressing BTN1 will make Mario jump, and extend the display for
a futher 10 seconds.

This looks awesome, thanks! Just merging now.
Should be on https://espruino.github.io/BangleApps/ and banglejs.com/apps next time I do and update


Export types

I want to pass the task object to another function, like so.
import tsk, { TaskFunction } from 'tasuku'

async function scanPage(page: number, task: TaskFunction) {
    .......
    task.setOutput(`Scanning page ${page}...`)
    ........
}

tsk(
    'Scanning page',
    async (task) => {
        await scanPage(1, task)
    }
)

This doesn't work because TaskFunction is not exported.
Great library otherwise though, congrats, I switched from listr2

Thanks @erikKeresztes
Does the solution in https://github.com/privatenumber/tasuku/pull/2 work for you?

Thanks @erikKeresztes
Does the solution in #2 work for you?

Yes, thank you


Fixed #139 - attachment download bugs (based on fixed #121

This pull request fixes #139 and based on pull request #135.

Request closed


"Unexpected Token" for async arrow IIFE

Using eslint 4.1.7 I am getting a syntax error with this code:
(async () => {

}());

Unexpected token at line 3 col 2

This only occurs on arrow functions. (async function () {}()); works fine.

I don't think that input is valid. AsyncArrowFunction is an AssignmentExpression like ArrowFunction and this is a syntax error:
() => {}();

It has to be
(() => {})();

There was a bug in Babel 5.x that allowed the former, but apparently it doesn't extend to async arrows.

hmm, interesting


Adding a stylization of the body cards

My proposal is to put a stylization the panel body respecting the same tone of context. for this you should add a Modified class "color" to paint the body panel.
file: less/mixins/panels.less
  & > .panel-body.color {
    background-color: lighten(@heading-bg-color,15%);
  }

We are no longer accepting new features into Bootstrap v3, so this would have to target Bootstrap v4.
And panels have been replaced by cards in Bootstrap v4 (http://v4-alpha.getbootstrap.com/components/card/ ) so this would have to target Cards instead.
Finally, "color" is a bad class name, it's way too generic. Do you have another naming proposal?

respecting the same tone of context.

I'm not clear on what you mean by this. Could you explain more?

The proposal was to color the panel body (card), however this solution has already been shown in v4 in "background variants", thanks.
Regarding the nomenclature, really, ".color" is generic, but the properties that this rule are assigned are only valid if it was used with the class ".panel-body": .panel.body.color was more to simplify the names of classes as well as another proposal: .btn.warning ,  .btn.alert, etc we would have the class of the element and his modification. This creates a problem in Question performace or support, in practice?

The proposal was to color the panel body (card), however this solution has already been shown in v4 in "background variants", thanks.

So, your feature request is now unnecessary? If yes, then can you close this issue?

We deliberately use e.g. .btn-warning instead of .btn.warning. See http://markdotto.com/2012/02/16/scope-css-classes-with-prefixes/ for the reasoning.

Thanks!


--strip-comments doesn't strip * comments *\

polymer web components has these types of comments all over the place, and I use them as well. I would be nice if vulcanize removed these comments as well.
/**

Use Polymer.PaperCheckedElementBehavior to implement a custom element
that has a checked property similar to Polymer.IronCheckedElementBehavior
and is compatible with having a ripple effect.
@polymerBehavior Polymer.PaperCheckedElementBehavior
*/

Are * \ considered comments?  I always thought it was / */

Yes, that is what I meant. sorry about that.

I would ask that this be considered as well, since:

No html minifiers seem to be able to remove comments inside of script tags.
It is actually causing issues with the web animations library including a reference to a source map, even though the script has been inlined.

it would indeed be a great addition!


Android implementation not performing path-check on Cookies

Hi,
I'm updating an old code base built using the original modernhttpclient library and ran into some strange behaviour when migrating to this updated library. The problem I'm experiencing only happens in the android branch, and manifests as cookies being sent that should not be. I did some debugging and I believe I've found the root cause and a fix/workaround. It looks like the cookie-handling code is inadvertently only using the hostname for cookie matching and not doing any path-matching; this is incorrect behaviour per RFC 6265 and is causing issues in my app.
The root cause appears to be that the native java CookieStore.Get function being leveraged to filter cookies does not do any path-matching, and expects this matching to be done at a higher level. Per the openjdk source:
         //
         // for cookie purpose, the effective uri should only be http://host
         // the path will be taken into account when path-match algorithm applied
         //

There is a corresponding higher-level Get function in the native java CookieManager code that does perform the required path matching (as well as sorting and some other checks), however this code only returns a list of cookie strings with none of the parameters needed to create the OkHttp3 cookie objects used in the code.
As a fix/workaround I have created a simple function to perform path-matching per the RFC, and call this function to check cookie paths before adding them to the cookie collection in the LoadForRequest function. Note that there is actually a native java pathMatches function that performs essentially the same function already present in CookieManager.java, but it is not accessible due to its protection level.
I'll create a pull request shortly with the code.

Awesome.

https://github.com/alexrainman/ModernHttpClient/pull/44 created

Merged. Will be out in next release.


spec: rename record_time to log_time

After discussion, we've formed a consensus that log_time is a better term for
the semantics of this field. The log_time is the time any writer wants to indicate
a message is logged at.
Fixes: #82

non-binary-breaking wording only change


Rewrite workflows to use workload identity federation

This is safer than using service account keys, according to Yggdrasil.
Breaking change.

Godkjent på slack 👍🏼


Readme for Microsoft marketplace

I'm not sure if the text in the README.md (displayed in Github) should be the same as the text displayed in the marketplace, but we have to improve/change it for the marketplace (here we can use the file we want). Something more focused in Conan itself and then the extension.

I agree we need to update README.md, currently it's more focused on developers. I believe we should move it to something like Contributing.md (create contributor's guide) and write entirely new README.md focused on end-users.


Remove isomorphic-git dependency and use a Child proc

We introduce isomorphic-git just for running a git clone command (that's quite a lot of packages). We probably need to replace that with a simple child proc instead

I think we can use scanner.from instead of clone + scanner.cwd
Wdyt @fraxken ? Am i missing something ?

@PierreDemailly No because from require that the spec exist in the registry. The goal is to clone and analyze git projects with no relation to the registry.

Or I'm missing something myself lol

Hi, can you asssign me on that issue please?


Show warning console if version.js file is missing

Motivation
As discussed in #369, we have to give better error message if version.js file is missing in pages/en directory.
The solution was to add warning console if someone ran the version script before creating the versions.js page
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Warning console example if version.js file is not found

Success example if version.js file is found

Run yarn test and it pass all unit test
Related PRs
No

Some suggestion. Instead of just a warning when version.js is missing, will it be better to prompt user if they want to create a default version.js ?  This is more from user experience (UX) perspective.  Showing https://docusaurus.io/docs/en/versioning.html as a reference guide might be useful as well. WDYT?

@endiliey i agree with u, but can u give me the example of how to create a default version.js?
@JoelMarcey @yangshun do u've any comments about this?

Refer to https://docusaurus.io/docs/en/versioning.html, running yarn examples versions create an example pages/en/versions.js
yarn examples versions is actually just running node ../lib/copy-examples.js versions https://github.com/facebook/Docusaurus/blob/aae106c018667a3787726f7744ce14ccb2b68ef1/lib/copy-examples.js#L97-L122

Showing https://docusaurus.io/docs/en/versioning.html as a reference guide is useful and nice to be included in this PR.
For prompting and creating a default version.js, should we separate into a new issue/PR? So, this PR only focuses on a better error message and the new PR focuses only the new functionality to create a default versions.js if not exists.

@endiliey @supasate @JoelMarcey @yangshun
My Suggestion:
No version.js file founded!
You should create your version.js file in pages/en directory.
Please refer to https://docusaurus.io/docs/en/versioning.html

@sujono91 That definitely seems reasonable to me. Much better than what we have now -- which is nothing 😄. We can always do any minor tweaking later, if we want.

@yangshun @JoelMarcey updated

Updated @yangshun @JoelMarcey


Add clipboard sync

I think it might be useful to have this out of the box

@feoh unnamedplus is the system clipboard.

Hi, sorry for the late reply! Yes, unnamedplus is the system clipboard and as such, it allows for nice integration with the system (copying and pasting config files most often). I know some more versed people in VIM do not like it but for me (as a beginner) it helped a lot

Thanks, I do think this is a pretty reasonable default to have for people.

Unnamedplus is a good thing for complete beginners, I get it.
But most neovim users are not new to vim's default behavior.
If you make the switch to neovim, you most likely already work with registers. Most neovim users will come from vscode or intellij vim plugins. There, the system clipboard is not linked to the default yank.
I think unnamedplus should be disabled again. But keep it as a comment for interested users!

I disagree. I think this project has got to maintain clarity of purpose in order to be useful, and my impression of that purpose is to provide an accessible on-ramp for new users to get productive with Neovim in a very short time.
Experienced users can twiddle and tweak as they like, but I can tell you that as a recent-ish new user myself, having the system clipboard Just Work is a really desirable default from where I sit :)


Improve camera positioning for following vehicles

I am using the Steam version on 14 Mar. (or 13 Mar depending on the timezone, you get it)
For example:

From the blue highlights of the parked car on the left, we could see that the 1st-person camera is placed inside the vehicle model. This means I can no longer select anything outside the vehicle, because the raytracing means that it will always hit the vehicle that I am already inside of.

This is really a pain to solve I guess. For now, you could use Vehicle cam offset in the option menu or simply move the camera forward each time to get outside the car. In the future, we might support setting the correct camera position offset for each type of vehicles somehow.

It was a while before I discovered that I could move the camera forward, so I guess it is OK for now.

Added by 9e603a681b49602cb756f96384867b9bd30edd21


cxx::unique_ptr::get() does not check for nullptr before access

Required information
Operating system:
Ubuntu 20.04.3 LTS
Compiler version:
GCC 8.4.0
Observed result or behaviour:
Accessing an empty unique_ptr leads to a crash
Expected result or behaviour:
Accessing an empty unique_ptr shall lead to a fatal error (defined behaviour)
Conditions where it occurred / Performed steps:
Call unique_ptr::get() on empty object

@mossmaurice can we make this a check for debug builds only?
When we refactor the release method to a static method like static T* release(unique_ptr<T>t&& p) clang-tidy would essentially find every occurrence where unique_ptr contains a nullptr.

Okay, then this would qualify to an IOX_DEBUG_ASSERT which @MatthiasKillat wants to implement? Of course only after we can ensure that there actually won't be a nullptr except for moved-from objects


Wilrdcard certs?Ac

According to the README wildcard certs are supported.
But I've just tried this and Chrome (at least) gets an error:
NET::ERR_CERT_COMMON_NAME_INVALID
Subject: *.home.arpa
Issuer: minica root ca 44c4c0
Expires on: 2 May 2024
Current date: 2 Apr 2022

Similar errors appear in a Go project that uses minica here:
WARN[0030] error looking up user endpoint                error="error looking up user<EMAIL_ADDRESS>https://home.arpa/.well-known/salty/salty.json: client.Do fail: Get \"https://home.arpa/.well-known/salty/salty.json\": x509: “*.home.arpa” certificate name does not match input"

What am I missing? I see a PR #45 that adds a -common flag to the cli but I'm not actually sure if this will help?

Not sure never used this tool was just checking it out, but normally *.home.arpa does not cover home.arpa, you would need to specify both in the request. Again not sure if possible here, but that would likely solve the problem.

 This was just a bad invocation on my part 😆

I tried this ./minica --domains '*.home,home' for https://bitwarden.home/. It didn't match. Is there something I should do?

I tried this ./minica --domains '*.home,home' for https://bitwarden.home/. It didn't match. I get NET::ERR_CERT_COMMON_NAME_INVALID Is there something I should do?

Same issue, minica does not support first level wildcard cert, you need use *.bitwarden.home,bitwarden.home as a domain arg

I see a PR https://github.com/jsha/minica/pull/45 that adds a -common flag to the cli but I'm not actually sure if this will help
Yes - it is exactly reason why this PR wait for merging ...


Check the right deployed status

{"caller":"github.com/giantswarm/e2etests/basicapp/legacyresource/resource.go:176","level":"debug","message":"failed to get release status 'DEPLOYED': retrying in 51.652285011s","stack":"release status not matching error: waiting for 'DEPLOYED', current 'deployed'","time":"2020-05-20T12:32:48.360357+00:00"}
{"caller":"github.com/giantswarm/e2etests/basicapp/legacyresource/resource.go:176","level":"debug","message":"failed to get release status 'DEPLOYED': retrying in 1m4.240396564s","stack":"release status not matching error: waiting for 'DEPLOYED', current 'deployed'","time":"2020-05-20T12:33:40.038139+00:00"}
{"caller":"github.com/giantswarm/e2etests/basicapp/legacyresource/resource.go:176","level":"debug","message":"failed to get release status 'DEPLOYED': retrying in 1m21.749486247s","stack":"release status not matching error: waiting for 'DEPLOYED', current 'deployed'","time":"2020-05-20T12:34:44.303024+00:00"}
--- FAIL: TestHelm (686.14s)
    basic_test.go:15: {"kind":"releaseStatusNotMatchingError","annotation":"waiting for 'DEPLOYED', current 'deployed'","stack":[{"file":"/home/circleci/.go_workspace/pkg/mod/github.com/giantswarm/e2etests@v0.3.0/basicapp/legacyresource/resource.go","line":170},{"file":"/home/circleci/.go_workspace/pkg/mod/github.com/giantswarm/backoff@v0.2.0/retry.go","line":23},{"file":"/home/circleci/.go_workspace/pkg/mod/github.com/giantswarm/e2etests@v0.3.0/basicapp/legacyresource/resource.go","line":182},{"file":"/home/circleci/.go_workspace/pkg/mod/github.com/giantswarm/e2etests@v0.3.0/basicapp/basicapp.go","line":102}]}
FAIL
FAIL	github.com/giantswarm/cert-manager-app/integration/test/basic	686.432s
FAIL

Another DEPLOYED vs. deployed

GOing with a ping.


Range finding functionality ('field.gt' et al) works only for Query, not Scan

AWS SDK v2 supports an optional scan_filter on Scan API calls, with the same semantics as query_filter on Query API calls.
Dynamoid offers convenience methods for finding on range fields, such as my_chain.where("rangefield.gt" => 5), but it works only on Query API calls. On Scan, Dynamoid allows this query chain, but it does not translate the ".gt" component, so you end up scanning for a non-existent field.
We need the range finding functionality to be consistent between Query and Scan.

Any update on this?

@afgarcia86 this is supported in the latest master.  A new release will be out soon.


Joining a school and 'my schools' page

A user should be able to 'join' their child's school so that they can easily access the list of projects at that school. The school should ideally be able to set whether their school is public, or whether uses need to request access to the school.
There should then also be a 'my schools' page whicih shows only the projects from the schools which the user has joined

We also then need to add to the projects search page - we need to add all of the user's favourite schools to the 'Schools' dropdown box.


Fixup chinese concept menu abnormal.

Add index files.
Fixup index files. (Remove the content of _index for incorrect layout)
Sync English version folders. (Add the missing folders and _index.md files)
Fixup the format problem of document

@it2911 冲突先解决一下

/hold

/close


BotUtils.PropogateInterrupt is not propagating the interrupt to parent threads

During the Unit Testing it was found that BotUtils.PropogateInterrupt is not really propogating the interrupt.
The reason being, Thread.currentThread().interrupt() is only interrupting itself. While this is not really useful as when caught this current thread is not in either sleeping or waiting more for any reason. The interrupt should be propagated to the parent, as the parent might be waiting for the current thread and multiple other threads to complete.

Corrected this behavior by changing the BotUtils.propogateInterrupt() with this
Thread.currentThread ().getThreadGroup ().interrupt ();


Replace promote_args<typename value_type,...> with return_type<T,...>

Summary:
Simplifies code by changing
boost::math::tools::promote_args<typename scalar_type<T_y>::type, ...>

into
return_type<T_y, ...>

Intended Effect:
Should have no runtime impact whatsoever.
How to Verify:
Compile the corresponding units tests.
Side Effects:
None

Should we change the rest of the math functions while we're going through this effort?

Are there more instances? I didn't find more, but maybe I didn't use the best grep pattern.

I searched for promote_args and it shows up in a lot of places.
Btw, this wasn't meant to be an action solely for you. If we're going down
this path, my inclination is to fix it for all instances. It makes it
easier to follow a pattern when there's only one in the code base.
On Mon, Jan 12, 2015 at 3:43 PM, Joshua Pritikin<EMAIL_ADDRESS>wrote:

Are there more instances? I didn't find more, but maybe I didn't use the
best grep pattern.
—
Reply to this email directly or view it on GitHub
https://github.com/stan-dev/stan/pull/1213#issuecomment-69642255.

Sure, well, I'm in favor of an easier to understand code base. I was mainly worried about fixing the instances of the problem that make it easier to complete issue #1210.

boost::math::tools::promote_args is not a problem per se. It's the combination of boost::math::tools::promote_args and scalar_type/value_type that we should try to eliminate.

In a stunning role reversal, I'm going to play Daniel
and say that as long as we're moving the code in the right
direction, we don't need to fix it all at once.  Let's not delay
this pull request if it's solid and there's something else
depending on it.
Having said that, I agree that consistency is a Very Good Thing.
Daniel (playing himself) has preternatural refactor speed.

Bob

On Jan 12, 2015, at 3:47 PM, Daniel Lee<EMAIL_ADDRESS>wrote:
I searched for promote_args and it shows up in a lot of places.
Btw, this wasn't meant to be an action solely for you. If we're going down
this path, my inclination is to fix it for all instances. It makes it
easier to follow a pattern when there's only one in the code base.
On Mon, Jan 12, 2015 at 3:43 PM, Joshua Pritikin<EMAIL_ADDRESS>wrote:

Are there more instances? I didn't find more, but maybe I didn't use the
best grep pattern.
—
Reply to this email directly or view it on GitHub
https://github.com/stan-dev/stan/pull/1213#issuecomment-69642255.

—
Reply to this email directly or view it on GitHub.

Great. If you don't mind giving it another day, I'm almost done with this
pull request.... I can do a quick sweep and see if I can pick up anything
in the next day. If not, we'll merge after testing.
On Mon, Jan 12, 2015 at 5:59 PM, Bob Carpenter<EMAIL_ADDRESS>wrote:

In a stunning role reversal, I'm going to play Daniel
and say that as long as we're moving the code in the right
direction, we don't need to fix it all at once. Let's not delay
this pull request if it's solid and there's something else
depending on it.
Having said that, I agree that consistency is a Very Good Thing.
Daniel (playing himself) has preternatural refactor speed.

Bob

On Jan 12, 2015, at 3:47 PM, Daniel Lee<EMAIL_ADDRESS>wrote:
I searched for promote_args and it shows up in a lot of places.
Btw, this wasn't meant to be an action solely for you. If we're going
down
this path, my inclination is to fix it for all instances. It makes it
easier to follow a pattern when there's only one in the code base.
On Mon, Jan 12, 2015 at 3:43 PM, Joshua Pritikin <
<EMAIL_ADDRESS>wrote:

Are there more instances? I didn't find more, but maybe I didn't use
the
best grep pattern.
—
Reply to this email directly or view it on GitHub
https://github.com/stan-dev/stan/pull/1213#issuecomment-69642255.

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub
https://github.com/stan-dev/stan/pull/1213#issuecomment-69664193.

@jpritikin, I've added one more commit that removes unused using boost::math::tools::promote_args that weren't in use any more. On the branch, I went and merged the existing fix that I've been working on, then applied the commit, so I'll just wait until that gets in before creating a pull request to your branch.

Sounds good.

What is the status here? Do I need to rebase these changes on the develop branch?

@jpritikin, yes. Mind taking care of it? If you're tied up, I can take care of it.

@syclik Done. Can this go in now?

@jpritikin, I'm going to get the changes onto a branch in stan-dev/stan (so Jenkins can know about it), then get it tested. I'll take a look at the changes.

Jenkins, ok to test.

@jpritikin, there are some cpplint warnings. See: http://d1m1s1b1.stat.columbia.edu:8080/job/Stan Pull Request - CppLint/24/warnings10Result/new/
Some of these are false positives, and not your fault. I'll clean them up before this gets in. Since you're working on a branch, I think I'll have to create a pull request over to your branch for this to work. I'll try to do that later today.

@syclik This is a bit over my head, but I guess that's okay because you will take care of it. Thanks!

This actually passed.
Since the pull request was from a different fork, I needed to pull the
changes into the the main repo, which I forgot to do.
It's been merged.
On Feb 10, 2015 11:30 PM, "Stan buildbot"<EMAIL_ADDRESS>wrote:

Refer to this link for build results (access rights to CI server needed):
http://d1m1s1b1.stat.columbia.edu:8080/job/Stan Pull Request/202/
Build Log
last 20 lines
[...truncated 19 lines...]
Finished Build : #200 of Job : Stan Pull Request - Doc - Reference Manual with status : SUCCESS
Starting build job Stan Pull Request - Tests - Header.
Starting build job Stan Pull Request - Tests - Unit.
Starting build job Stan Pull Request - Tests - Integration.
Starting build job Stan Pull Request - Windows - Tests - Unit.
Finished Build : #189 of Job : Stan Pull Request - Tests - Header with status : SUCCESS
Finished Build : #191 of Job : Stan Pull Request - Tests - Integration with status : SUCCESS
Finished Build : #191 of Job : Stan Pull Request - Tests - Unit with status : SUCCESS
Finished Build : #37 of Job : Stan Pull Request - Windows - Tests - Unit with status : SUCCESS
Starting build job Stan Pull Request - CppLint.
Finished Build : #28 of Job : Stan Pull Request - CppLint with status : SUCCESS
Starting build job Stan Pull Request - Performance.
Finished Build : #27 of Job : Stan Pull Request - Performance with status : SUCCESS
Starting build job Stan Pull Request - Interface - CmdStan.
Finished Build : #7 of Job : Stan Pull Request - Interface - CmdStan with status : FAILURE
Starting build job Stan Pull Request - Distribution Tests.
Finished Build : #132 of Job : Stan Pull Request - Distribution Tests with status : SUCCESS
Warning: you have no plugins providing access control for builds, so falling back to legacy behavior of permitting any downstream builds to be triggered
Setting status of 0c94579368424edffab7b520b83d57e7b7cfd176 to FAILURE with url http://d1m1s1b1.stat.columbia.edu:8080/job/Stan Pull Request/202/ and message: Merged build finished.
Test FAILed.
—
Reply to this email directly or view it on GitHub
https://github.com/stan-dev/stan/pull/1213#issuecomment-73832817.


Syft not created "dependencies" in cyclonedx report

What happened:
Syft not created "dependencies" in cyclonedx report for Go, Rust, Java and etc.
Cargo.lock had "dependencies". View like
[[package]]
name = "yaserde"
version = "0.8.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "4bf52af554a50b866aaad63d7eabd6fca298db3dfe49afd50b7ba5a33dfa0582"
dependencies = [
 "log",
 "xml-rs",
 "yaserde_derive",
]

But output syft doesnt reflect this
What you expected to happen:
Want full cyclonedx report with "dependencies" and "depensOn" included
Steps to reproduce the issue:
syft -o<EMAIL_ADDRESS>Cargo.lock > report.json
Anything else we need to know?:
Environment:
Syft 0.94

Hi @Dungeon1, thanks for the report. I can confirm that the dependencies show up in the syft-json format output, but not the cyclonedx-json or cyclonedx-xml output. I will confirm with the team if this is expected behavior or not and get back to when we are able to look. Thanks again.

@wagoodman  I ran on Cargo.lock like your example.

Cargo.lock had dependencies, but syft not building dependencies with dependsOn.

I was also able reproduce this. It looks like syft is detecting the dependencies (because they show up in o json), but isn't writing them down in cyclonedx-json. Moving to the backlog, thanks for the report!


rbenv/foreman Permission denied @ rb_sysopen - /etc/init/app.conf (Errno::EACCES)

Someone knows how to give rbenv permission to rbenv/foreman export?
thank's
[foreman export] writing: app.conf
/home/ubuntu/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/foreman-0.82.0/lib/foreman/export/base.rb:162:in `initialize': Permission denied @ rb_sysopen - /etc/init/app.conf (Errno::EACCES)
    from /home/ubuntu/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/foreman-0.82.0/lib/foreman/export/base.rb:162:in `open'
    from /home/ubuntu/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/foreman-0.82.0/lib/foreman/export/base.rb:162:in `write_file'
    from /home/ubuntu/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/foreman-0.82.0/lib/foreman/export/base.rb:139:in `write_template'
    from /home/ubuntu/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/foreman-0.82.0/lib/foreman/export/upstart.rb:12:in `export'
    from /home/ubuntu/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/foreman-0.82.0/lib/foreman/cli.rb:61:in `export'
    from /home/ubuntu/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/thor-0.19.1/lib/thor/command.rb:27:in `run'
    from /home/ubuntu/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/thor-0.19.1/lib/thor/invocation.rb:126:in `invoke_command'
    from /home/ubuntu/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/thor-0.19.1/lib/thor.rb:359:in `dispatch'
    from /home/ubuntu/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/thor-0.19.1/lib/thor/base.rb:440:in `start'
    from /home/ubuntu/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/foreman-0.82.0/bin/foreman:7:in `<top (required)>'
    from /home/ubuntu/.rbenv/versions/2.2.2/bin/foreman:23:in `load'
    from /home/ubuntu/.rbenv/versions/2.2.2/bin/foreman:23:in `<main>'

Hello,
For Foreman to be able to write to /etc/init/app.conf, the while either has to be writeable by the user who is running Foreman, or you should use sudo foreman. In any case, this has nothing to do with rbenv.

right, thank you @mislav

what suposed to do... on file or directory... no local or remote server u.u damn im tired... Thanks for your time---


Add records/resources to a pdb/prc

Adds an abstraction over resource attributes which hides the bit manipulation, and adds the ability to insert resources or records (no removal yet). Also fixes a couple bugs related to the compatibility padding between PalmOS versions, and uses cursors more places internally to reduce the amount of required offset tracking.

Amazing, thank you! (And thanks also for being so diligent in writing tests for these changes!)


KAFKA-8558:  Add StreamJoin config object to join

This PR adds StreamJoin to a Streams - Streams join, allowing to separate the naming of the join state stores from the name of the join processor.  See KIP-479 for more details.
For testing some of the existing tests were updated and additional tests added verifying the expected behavior.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

ping @guozhangwang, @mjsax, @vvcephei, @ableegoldman, @cadonna, @abbccdda for reviews.

@mjsax updated this

@mjsax @vvcephei updated this per comments

@mjsax updated this per comments

@bbejeck @fhussonnois This is a follow on to KIP-307 and this PR does not contain any doc updates. Did we update the docs for KIP-307 already? I would just recommend to do a follow up PR, that especially covers the upgrade section.

@mjsax updated this.

Java 11/2.12 , Java 11/2.13 and Java 8/2.11 failed.  All results already cleaned up.
retest this please

Java8 passed. Both Java11 failed -- result are not available any longer. Merging to meet feature freeze deadline.


Publish fails when using ko on Windows.

C:\Users\zcube>ko publish --platform=all github.com/mattmoor/warm-image/cmd/sleeper -L
2020/11/17 22:17:29 Using base gcr.io/distroless/static:nonroot for github.com/mattmoor/warm-image/cmd/sleeper
2020/11/17 22:17:29 No matching credentials were found, falling back on anonymous
2020/11/17 22:17:32 Building github.com/mattmoor/warm-image/cmd/sleeper for linux/amd64
2020/11/17 22:17:40 Building github.com/mattmoor/warm-image/cmd/sleeper for linux/arm64
2020/11/17 22:17:48 Building github.com/mattmoor/warm-image/cmd/sleeper for linux/ppc64le
2020/11/17 22:17:57 Building github.com/mattmoor/warm-image/cmd/sleeper for linux/s390x
2020/11/17 22:18:04 failed to publish images: error publishing ko://github.com/mattmoor/warm-image/cmd/sleeper: repository can only contain the runes `abcdefghijklmnopqrstuvwxyz0123456789_-./`: ko.local\sleeper-ebdb8b8b13d4bbe1d3592de055016d37

Publish fails when using ko on Windows.
I think it's because it uses OS.Seperator. It looks like you need to replace filepath.join with path.join.

I don't have a windows machine to test this on, so I would appreciate your help testing https://github.com/google/ko/pull/247
I'm also curious if specifying a local path to a build target works, e.g. ko publish ./cmd/ko works on linux, but I'm not sure what the windows equivalent to that is (and if it works at all).
We use filepath.Join when producing the filesystem for the resulting image, so that will probably be broken for you as well unless you have a windows base image, and I'm pretty sure there are a number of other issues (cc @tcnghia).
I don't know of a way to tell golang "hey please use filepath for this target GOOS/GOARCH, not the GOOS/GOARCH of my system", but I'll poke around.

#247 works fine. Backslash is now properly replaced with forward slash. Windows supports forward slashes, but Linux does not support backslashes, so I think it is better to unify them with forward slashes.
C:\Users\zcube\go\src\github.com\google\ko\ko publish --platform=linux/amd64 github.com/mattmoor/warm-image/cmd/sleeper -L
2020/11/18 03:07:53 Using base gcr.io/distroless/static:nonroot for github.com/mattmoor/warm-image/cmd/sleeper
2020/11/18 03:07:53 No matching credentials were found, falling back on anonymous
2020/11/18 03:07:55 Building github.com/mattmoor/warm-image/cmd/sleeper for linux/amd64
2020/11/18 03:07:56 Loading ko.local/sleeper-ebdb8b8b13d4bbe1d3592de055016d37:e42fda13bfad5fd545576860d5940a7c41b129a778bb75276d4457ec33c0e71c
2020/11/18 03:07:56 Loaded ko.local/sleeper-ebdb8b8b13d4bbe1d3592de055016d37:e42fda13bfad5fd545576860d5940a7c41b129a778bb75276d4457ec33c0e71c
2020/11/18 03:07:56 Adding tag latest
2020/11/18 03:07:56 Added tag latest
ko.local/sleeper-ebdb8b8b13d4bbe1d3592de055016d37:e42fda13bfad5fd545576860d5940a7c41b129a778bb75276d4457ec33c0e71c

ko.local/sleeper-ebdb8b8b13d4bbe1d3592de055016d37<PHONE_NUMBER>0884a26a1727cce087c73a021329d9e07131df2e1d0027a9524c05   08c831570535        50 years ago        14.8MB
ko.local/sleeper-ebdb8b8b13d4bbe1d3592de055016d37                                e42fda13bfad5fd545576860d5940a7c41b129a778bb75276d4457ec33c0e71c   9d20ce27b0de        50 years ago        14.9MB
ko.local/sleeper-ebdb8b8b13d4bbe1d3592de055016d37                                latest                                                             9d20ce27b0de        50 years ago        14.9MB
...

C:\Users\zcube\go\src\github.com\google>docker run --rm -ti ko.local/sleeper-ebdb8b8b13d4bbe1d3592de055016d37 --help
Usage of /ko-app/sleeper:
  -alsologtostderr
        log to standard error as well as files
  -log_backtrace_at value
        when logging hits line file:N, emit a stack trace
  -log_dir string
        If non-empty, write log files in this directory
  -logtostderr
        log to standard error instead of files
  -mode string
        One of: sleep or copy (default "sleep")
  -stderrthreshold value
        logs at or above this threshold go to stderr
  -to string
        Where to copy this binary
  -v value
        log level for V logs
  -vmodule value
        comma-separated list of pattern=N settings for file-filtered logging

and without local
C:\Users\zcube\go\src\github.com\google>set KO_DOCKER_REPO=reg.zcube.kr/docker
C:\Users\zcube\go\src\github.com\google>C:\Users\zcube\go\src\github.com\google\ko\ko publish --platform=linux/amd64 github.com/mattmoor/warm-image/cmd/sleeper
2020/11/18 03:15:01 Using base gcr.io/distroless/static:nonroot for github.com/mattmoor/warm-image/cmd/sleeper
2020/11/18 03:15:01 No matching credentials were found, falling back on anonymous
2020/11/18 03:15:03 Building github.com/mattmoor/warm-image/cmd/sleeper for linux/amd64
2020/11/18 03:15:04 Publishing reg.zcube.kr/docker/sleeper-ebdb8b8b13d4bbe1d3592de055016d37:latest
2020/11/18 03:15:05 failed to publish images: error publishing ko://github.com/mattmoor/warm-image/cmd/sleeper: HEAD https://reg.zcube.kr/v2/docker/sleeper-ebdb8b8b13d4bbe1d3592de055016d37/blobs/sha256:39e1bf9c1e20c05c5f7518da99343cd96ff7c3f07b1efafc92f220112945d067: unsupported status code 401

It works. The 401 error is because my registry is not ready.
Thanks.

ko publish ./cmd/ko
set KO_DOCKER_REPO=reg.zcube.kr/docker

C:\Users\zcube\go\src\github.com\google\ko>ko publish ./cmd/ko
2020/11/18 03:26:41 Using base gcr.io/distroless/static:nonroot for github.com/google/ko/cmd/ko
2020/11/18 03:26:41 No matching credentials were found, falling back on anonymous
2020/11/18 03:26:43 Building github.com/google/ko/cmd/ko for linux/amd64
2020/11/18 03:26:56 Publishing reg.zcube.kr/docker/ko-099ba5bcefdead87f92606265fb99ac0:latest
2020/11/18 03:26:56 failed to publish images: error publishing ko://github.com/google/ko/cmd/ko: HEAD https://reg.zcube.kr/v2/docker/ko-099ba5bcefdead87f92606265fb99ac0/blobs/sha256:72164b581b02b1eb297b403bcc8fc1bfa245cb52e103a3a525a0835a58ff58e2: unsupported status code 401

Thank you for your help!

C:\Users\zcube\go\src\github.com\google\ko>ko publish ./cmd/ko

Does this break if you use backslash? Maybe not worth fixing but I am just curious.

C:\Users\zcube\go\src\github.com\google\ko>ko publish .\cmd\ko

This fails. What you need to create is the URL path, not the operating system's file path.
C:\Users\zcube\go\src\github.com\google\ko>ko publish ./cmd/ko
2020/11/18 03:55:15 Using base gcr.io/distroless/static:nonroot for github.com/google/ko/cmd/ko
2020/11/18 03:55:15 No matching credentials were found, falling back on anonymous
2020/11/18 03:55:17 Building github.com/google/ko/cmd/ko for linux/amd64
2020/11/18 03:55:21 Publishing reg.zcube.kr/docker/ko-099ba5bcefdead87f92606265fb99ac0:latest
2020/11/18 03:55:21 failed to publish images: error publishing ko://github.com/google/ko/cmd/ko: HEAD https://reg.zcube.kr/v2/docker/ko-099ba5bcefdead87f92606265fb99ac0/blobs/sha256:e59bd8947ac7af2c8f4403b183326986ab554bbc262739cf5d9d596c7c7a3aca: unsupported status code 401

C:\Users\zcube\go\src\github.com\google\ko>ko publish .\cmd\ko
2020/11/18 03:55:26 Using base gcr.io/distroless/static:nonroot for .\cmd\ko
2020/11/18 03:55:26 No matching credentials were found, falling back on anonymous
2020/11/18 03:55:28 Building .\cmd\ko for linux/amd64
2020/11/18 03:55:32 failed to publish images: error publishing ko://.\cmd\ko: repository can only contain the runes `abcdefghijklmnopqrstuvwxyz0123456789_-./`: docker/.\cmd\ko-4f1cdbd9822e4e6955d23ffb7c3b30ac


Top-K and Top-p sampling

Hi, thanks for your great work!
I have a question about the sampling process. When both top-K and top-p are enabled (e.g., https://github.com/allenai/RL4LMs/blob/main/scripts/training/task_configs/common_gen/t5_nlpo.yml#L44-L51), isn't top-p just ignored because the K most likely next words are filtered and the probability mass is redistributed among only those K next words? Please correct me if my understanding is wrong. Thank you!

This top p mask is quite different from typical top-p sampling. This is particular to NLPO algorithm. Before sampling, we generate a top p mask from the mask policy (a copy of policy from previous epochs). Depending on generation kwargs, top k is applied on top of this. For details, you can refer to our paper.


Failed to execute close on AudioContext

after updating google chrome to v90

I also suffer the same issue. However, using vmsg v0.3.6 instead of v0.4.0, solves the issue.

I have related issue "Uncaught (in promise) DOMException: Can't close an AudioContext twice" for V0.4.0
This is the line: https://github.com/Kagami/vmsg/blob/623b2940a37f5a309cd4d13411a0894664131079/vmsg.js#L172
NOTE: locally this was fixed by this:

if (this.audioCtx) this.audioCtx.close();

if (this.audioCtx && this.audioCtx.state != 'closed') this.audioCtx.close();

What do you think?


🗑 Deprecation promotion of toNonZeroInt function in ResultContext to hidden level

📝 Description
We would like to promote the deprecation of the toNonZeroInt function in ResultContext to a hidden level.
🔗 Dependencies
This issue is blocked by the following ones:

[ ] #482

✅ Checklist

[ ] Promote the deprecation of this declaration, update the public API binaries and the unreleased changelog.
[ ] Close this issue as completed and update tracking ones if present.

Another issue for this task will be created when ready.


SWA auth emulator does not handle post_login_redirect_uri=.referrer

Are you accessing the CLI from the default port :4280 ?

[ ] No, I am using a different port number (--port) and accessing the CLI from that port
[x] Yes, I am accessing the CLI from port :4280

Describe the bug
According to documentation, the staticwebapp.config.json supports a .referrer redirect for the auth routes. The .referrer should be replaced by the route the user was attempting to access before the auth redirect.
However, the SWA emulator (and auth emulator page?) treat the redirect path as a plain string. It is not substituted by the expected path.
To Reproduce

Create a static web app. Restrict access using routes in staticwebapp.config.json. Users must be authenticated to access any page.

{ "route": "/*", "allowedRoles": ["authenticated"] }

Provide an auth redirect for any unauthorized response using responseOverrides in staticwebapp.config.json.

"responseOverrides":{"401":{"statusCode":302,"redirect":"/.auth/login/aad?post_login_redirect_uri=.referrer"}}

User loads GET http://localhost:4280/my-application-path?data=x
User is not authenticated and does not meet required allowedRoles.
User is redirected to auth emulator page at http://localhost:4280/.auth/login/aad?post_login_redirect_uri=.referrer $^{10}$
User clicks "Login" in the emulator.
Page is stuck in infinite loading loop. Page does not leave login emulator. SWA is attempting to use the .referrer as a valid application path, instead of replacing it with the actual path. $^{11}$

Expected behavior
10. Emulator should redirect user to authenticate at route http://localhost:4280/.auth/login/aad?post_login_redirect_uri=my-application-path%3Fdata%3Dx instead.
11. After clicking "Login" the emulator redirects the user to GET http://localhost:4280/my-application-path?data=x.
Relevant Logs:
[swa] ------------------- processing route -------------------
[swa] --------------------------------------------------------
[swa] processing /.auth/login/.referrer
...
[swa] - matchingRouteRule:
[swa]   - route: /*
[swa]  - allowedRoles:
[swa]    - 0: authenticated
[swa] checking auth request
[swa]  - auth request detected
[swa] processing auth request
[swa]  - auth returned 404
[swa] checking response overrides for status code 404
[swa]  - no rules found.
[swa] GET http://localhost:4280/404.html - 404
[swa] GET http://localhost:4280/404.html - 404

Desktop (please complete the following information):

OS: Windows
Version 11

My cursory reading of the code leads me to believe that this line of code should be aware of the "=.referrer" behavior defined in the documentation.

Opened a PR with a draft solution to the problem described above ^.

Thanks for your contribution @thsackos!!
We will get your PR reviewed and merged soon!
Keep coding! :)

Hey @thsackos , thanks for your PR, we'll review this and merge the PR as soon as possible.

For me this is not working.  After the emulator login it redirects to /.referrer, which doesn't exist.


Remove combineUrl from the test files

Take a look at https://github.com/mozilla/pdf.js/search?utf8=✓&q=combineUrl for where it is still used. We should replace it with the URL constructor as done in https://github.com/mozilla/pdf.js/pull/7178/files.

We still need to test the combineUrl function or remove that from our code.

Good point. Now that I come to think of it, couldn't we remove it entirely since we have a polyfill for it (at https://github.com/mozilla/pdf.js/blob/68e8f5fff51f2ee7f845a4217b9419b8676df866/src/shared/util.js#L1692)?

@brendandahl already wanted to remove that. Please notice that we shall properly handle if (!url) { case when it is needed.

Hi, This will be my first contribution, is it okay if I take this issue up and work on it?

Hi, This will be my first contribution, is it okay

Sure, please read https://github.com/mozilla/pdf.js/wiki/Contributing

Thank you..

there is a source file having reference to combineUrl - api.js in display. Should I replace that refernece too? Or only the test file references?
If src refernces are to be replaced, Should the function also be removed from util.js? - assuming that it will not be used in the future.

there is a source file having reference to combineUrl - api.js in display. Should I replace that refernece too?

Yes, you can replace that, remove tests and from util.js.


Get Data from SQL Server instead of Inmemory Database

Please provide us with the following information:

This issue is for a: (mark with an x)
- [ ] bug report -> please search issues before submitting
- [ ] feature request
- [x ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

Any log messages given by the failure
Failed to load resource: the server responded with a status of 404 (Not Found)
Actually the url of my .net core api is different from what is called by ngrx-data by default.

Expected/desired behavior
I was using ngrx-data with inmemorydataservice and it was working fine. But now i want to get data from SQL Database using Asp.net Core Apis.

OS and Version?

Windows 10

Versions

Mention any other details that might be useful
How can i change the url of api which is called by ngrx to look like the url of my .net core api?

Thanks! We'll be in touch soon.

Please read the doc on configuring the DefaultDataService here which explains how to set the root configuration property.
Closing because I believe you'll find all you need there. Open a new issue, referencing this one, if you need more help or have a suggestion.
Thanks for trying ngrx-data.


error downloading daprd binary

In Windows 10, trying to perform 'dapr init' in Powershell in administrator mode. Everytime i try dapr init it fails.
PS C:\Users\xxxxx> dapr init
Making the jump to hyperspace...
Container images will be pulled from Docker Hub
Installing runtime version 1.7.4
Downloading binaries and setting up components...
error downloading daprd binary: open C:\Users\xxxxx.dapr\bin/daprd_windows_amd64.zip: Access is denied.
Any suggestions would be much appreciated.

@pravpuru Can you create files manually in C:\Users successfully

@hueifeng Yes, i'm able to create files. To be specific, in C:\Users\MyUserId\

Based on the description for this is the insufficient permissions, you can delete files in this directory?

I'm able to delete any file in the directory. So I'm wondering if the error message is misleading.
I don't see daprd_windows_amd64.zip in the path  C:\Users\xxxxx.dapr\bin after i get this error.

@pravpuru Are you getting this only in 'administrator' mode ? I just tried on my local, seems to be working fine. Can you try dapr uninstall --all then do dapr init.

@pravinpushkar  I've tried that. Still no luck. Doing this worked for me.
Downloaded the daprd_windows_amd64.zip manually and placed the extracted exe in the bin.

@pravpuru Any luck with this? Did you try setting the default home dir to some other folder where you have full permissions and do dapr init
set userprofile=<other directory>
dapr init

@pravpuru Did you get a chance to try above suggestion, basically by setting a different home directory ?


Textual definition update: GO:0039585

TL;DR: PKR is EIF2AK2, not EIF2AK3.
id: GO:0039585
name: PKR-mediated signaling
def: "A series of reactions in which a signal is passed on to downstream proteins within the cell via PKR
 (also known as EIF2AK3), ...
synonym: "EIF2AK3 signal transduction" EXACT []
synonym: "EIF2AK3/PERK signaling" EXACT []

should read:
def: "A series of reactions in which a signal is passed on to downstream proteins within the cell via PKR
 (also known as EIF2AK2), ...
synonym: "EIF2AK2 signal transduction" EXACT []
synonym: "EIF2AK2/PERK signaling" EXACT []

Ref.: https://www.uniprot.org/uniprotkb/P19525/entry#names_and_taxonomy

Oops, make that:
synonym: "EIF2AK2/PRK signaling" EXACT []

Thanks!


wasm-pack.log shouldn't be outputted if no error happened

🐛 Bug description
When running wasm-pack build I get an empty wasm-pack.log file.
🤔 Expected Behavior
I expect to not get any log file if no error occurred and I expect to not get an empty one.
👟 Steps to reproduce
Follow all the steps here: https://github.com/rustwasm/wasm-pack#-quickstart-guide and then run wasm-pack build.
🌍 Your environment
Include the relevant details of your environment.
wasm-pack version: 0.5.1
rustc version: rustc 1.31.0 (abe02cefd 2018-12-04)

Absolutely, I can make a PR :)

I think this issue wont be relevant once #434 is merged. If I interpret that PR correctly? @alexcrichton

Indeed!

cool- i'll work on the merge conflict for that and get it ready for the 0.6.0 release


cgen: return type and var for function(s)

cgen: return type and var for function(s)

Within FortranCTransformation
if kernel.is_function and kernel.result_name is None:
    kernel.result_name = kernel.name

not necessary anymore, since result_name is now set by default if is_function=True