Add Issue/PR template in CommunityHealthFiles

Thanks to this endpoint : https://developer.github.com/v3/repos/community/
We can get some interesting datas.
Type CommunityHealthFiles contain CodeOfConduct, Contributing, License and Readme files, but not issue template and pull requests files. It might be a good idea to include them into CommunityHealthFiles

Thank you, @joan-saum!
Yes, specifically, we could add support for these fields:
    "issue_template": {
      "url": "https://api.github.com/repos/octocat/Hello-World/contents/ISSUE_TEMPLATE",
      "html_url": "https://github.com/octocat/Hello-World/blob/master/ISSUE_TEMPLATE"
    },
    "pull_request_template": {
      "url": "https://api.github.com/repos/octocat/Hello-World/contents/PULL_REQUEST_TEMPLATE",
      "html_url": "https://github.com/octocat/Hello-World/blob/master/PULL_REQUEST_TEMPLATE"
    },

This would be a great PR for any new contributor to this repo or a new Go developer.
All contributions are greatly appreciated!
Feel free to volunteer for any issue, and we can send you an invite to contribute to the repo (which you then accept after you enable two-factor authentication) and the issue can be assigned to you so that others don't attempt to duplicate the work.
Please check out our CONTRIBUTING.md guide to get started.
Thank you!

I'm thinking that we could simply reuse the Metric struct in both cases in the file repos_community_health.go and the Name and Key fields would simply not be populated.

I'm volunteer to handle this issue
I thought the same, simply reuse the Metric struct. It will better way to have a clean and common code.


Add runner for module types which are not java

I'm running PhpStrom 10.
I'm using MarkLogic implementation of XQuery


fix runtime error for UWP

fix for #440.
I was a little quick on #442, it fixed the compile error, but broke all injection (on UWP) at runtime. Sorry.

No problem, thanks


Max Exposure

I have the set the max exposure for every player to .2 so should be 30 lineups with the same player however it does not work for the position of pitcher...still test for other positions

from pydfs_lineup_optimizer import Site, Sport, get_optimizer,CSVLineupExporter

optimizer = get_optimizer(Site.FANDUEL, Sport.BASEBALL)
optimizer.load_players_from_csv("/Users/austi/Desktop/FDMLB6-6-19.csv")
optimizer.restrict_positions_for_opposing_team(['P'], ['C/1B', '2B', '3B','SS','OF','UTIL'])
lineup_generator = optimizer.optimize(150)
lineups = optimizer.optimize(n=150, max_exposure=0.2)
for lineup in lineup_generator:
    print(lineup)
exporter = CSVLineupExporter(optimizer.optimize(150))
exporter.export('result.csv')

In your code you created optimizer with max exposure and set result to lineups variable and then you didn't use it anymore. For other optimize calls that used in export and print you didn't specify max exposure.

from pydfs_lineup_optimizer import Site, Sport, get_optimizer,CSVLineupExporter

optimizer = get_optimizer(Site.FANDUEL, Sport.BASEBALL)
optimizer.load_players_from_csv("/Users/austi/Desktop/FanDuel-MLB-2019-06-10-36043-players-list.csv")
optimizer.restrict_positions_for_opposing_team(['P'], ['C/1B', '2B', '3B','SS','OF','UTIL'])
lineups = optimizer.optimize(n=150, max_exposure=0.2)
lineup_generator = optimizer.optimize(150)
for lineups in lineup_generator:
    print(lineups)
exporter = CSVLineupExporter(optimizer.optimize(150))
exporter.export('result.csv')

Maybe I'm confused on how the program is working. I want to generate 150 different lineups that are as uncorrelated as possible. Is the optimizer just choosing the best 150 lineups instead of generator random lineups. I changed the code but still had the same results.

In the second code sample only filename was changed. If you want to generate 150 lineups with exposure you should change your code to this:
from pydfs_lineup_optimizer import Site, Sport, get_optimizer,CSVLineupExporter

optimizer = get_optimizer(Site.FANDUEL, Sport.BASEBALL)
optimizer.load_players_from_csv("/Users/austi/Desktop/FanDuel-MLB-2019-06-10-36043-players-list.csv")
optimizer.restrict_positions_for_opposing_team(['P'], ['C/1B', '2B', '3B','SS','OF','UTIL'])
lineups = list(optimizer.optimize(n=150, max_exposure=0.2))
for lineup in lineups:
    print(lineup)
exporter = CSVLineupExporter(lineups)
exporter.export('result.csv')

Awesome! Thanks for the help.


Port WorldGuard to Fabric

Describe what you'd like
I read in #29 that with the Claims API in place you are starting looking at porting claims mods such as Towny. Would it be possible to port WorldGuard using the same API or would there be a need for another one?
WorldGuard: https://dev.bukkit.org/projects/worldguard/

Residence 🤘

Residence 🤘

wdym


Add support for the compliance history API

When the governance-policy-database Secret is defined, an OpenShift Route (only on OpenShift) is created to expose the compliance events history API on the hub.
Additionally, if the user sets the complianceHistoryAPIURL custom variable, it will set the --compliance-api-url on the governance-policy-framework container.
Relates:
https://issues.redhat.com/browse/ACM-6870

I understand the port naming better now.  Adding my approval and a hold to consider Justin's comment.
/hold
/lgtm

I don't really like adding klog, I think I still have a bad taste in my mouth from some time when it didn't play well with glog or something else in a dependency. But I also don't really like the quasi-global setupLog thing, so it's hard to say if this is really worse overall...
I'm guessing the main reason for that change was to make it easy for the new reconciler? Remind me where that method gets called by the dependency watcher library, is it possible it gets the same kind of context with a logger embedded in it by controller-runtime so it could use something like this: https://github.com/open-cluster-management-io/config-policy-controller/blob/main/controllers/operatorpolicy_controller.go#L113 ?
Everything else seems fine to me.

It's because we don't use controller-runtime, so zap isn't enabled so setupLog wasn't logging anything. I decided to use klog since that's what the github.com/openshift/library-go/pkg/controller/controllercmd package uses, which is what runs the controller.

/unhold


Latest npm release 9 commits behind current master branch

Whens the ETA for pushing changes to NPM?

Hey @lukeramsden that was only just merged in last night and there is some additional work before release. This should be all finished today.

@bnussey Awesome


Add docs for stunnel cert / key path attributes

Hi @jhmartin
Thanks for sending in this pull request. DNSimple has adopted this cookbook from Heavy Water and I've cleaned up the master branch to get the test suites working correctly again. If you would like to get these changes into master, please rebase against master and we can look at merging this in once again.

Merged in https://github.com/sous-chefs/chef-stunnel/commit/50ec3dcbce270387246a575273547b9dd9a2ba76


I don't like frogs

Obviously birds match the project style much better, I suggest to replace frog with a bird.

I appreciate your suggestion! Birds do seem to fit the style better.

Why did the frog call his insurance company? He had a jump in his car!

whooaa you ask too much

whooaa you ask too much

whooaa you ask too much

but why you need a bird?

but why you need a bird?

but why you need a bird?

but why you need a bird?

but why you need a bird?

but why you need a bird?

but why you need a bird?

but why you need a bird?

but why you need a bird?

hello world!


Better auto-reload capabilities

Closes https://github.com/markdownreveal/markdownreveal/issues/41

Codecov Report

Merging #43 into master will decrease coverage by 1.18%.
The diff coverage is 36.36%.

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
- Coverage   84.67%   83.49%   -1.19%
==========================================
  Files          13       13
  Lines         509      521      +12
  Branches       42       43       +1
==========================================
+ Hits          431      435       +4
- Misses         71       79       +8
  Partials        7        7

Impacted Files
Coverage Δ

markdownreveal/__init__.py
100% <100%> (ø)
:arrow_up:

markdownreveal/commands.py
47% <28.57%> (-0.26%)
:arrow_down:

markdownreveal/convert.py
78.26% <42.85%> (-3.56%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ebc75c...ff7992d. Read the comment docs.


[DEFECT] TopLevelParser.parseRootWithURLs always returns an empty list of URLs on failure

Symptom
The test for failure of parseRootWithURLs expects an empty Seq; the URLs on failure are essential to an ongoing task in the plugin
Expected Behavior
When parseRootWithURLs return Left, the URLs element in the tuples should be populated
Ideally the URLs and the Message.Ats would be grouped together so they can be referenced against each other more accurately
Steps To Reproduce
Option 1: Run test return URLs on failure in TopLevelParserTest
Option 2: Write a java script using TopLevelParser and make it fail with error messages

The behavior of that function is to not return the RPI's top level thing because it could be a string and because the programmer already knows about it. It only returns the URLs of the include statements. If your parse has no includes, you'll get an empty list.

Just needed a clean


Add navigation menu bar

It is currently not possible to drag the application window, a menu bar needs adding at the top to make dragging the window easier.
Documentation on how to do this.
Outstanding questions

Does this need adding to the Figma design?

I don't think this needs to be added to the figma, as the draggable region can be invisible with an arrow cursor to indicate it can be moved. This was in an earlier version, and was forgotten about in the UI overhaul I imagine

Okay, we can add an invisible title/menu bar that can be dragged. We might need an actual visible one, but we can see about that in the future.


806_unreal-tournament-2004-mappackrar_15845290

Add content:

[Unreal MAP_PACK] 062 Dm  Ussr  Deck 17 i
[UT99 MAP_PACK] 087 Mappack W00t Ctf
[UT99 MAP] DM-'A-1on1-RestricteD_A1
[UT99 MAP] DOM-[SOH]-LavaFont
[UT99 MAP_PACK] 806 Unreal Tournament 2004 Mappack
[UT99 MAP_PACK] Cb Map Pack
[UT99 MAP_PACK] MapsClanSOH
[UT99 MAP_PACK] 180   Mw   s Metal Warriors Mappack
[UT99 MAP_PACK] 903 903 Fuenlaboysmappack
[UT99 MAP] DM-GM2-TheJail

Submission log: https://unrealarchive.org/submit/#15845290

Apologies, forgot to remove the digits at the start of some of these files' names.
ut.gamersmafia.com is back after years of being shutdown, so I'm trying to grab everything I can from there right now. Loads of good files in there, though for some reason the files have those numbers.

No problem, we don't rely on the file names for anything, just the contents, so it doesn't matter what they're called :).


Add crism.ro

https://crism.ro/
https://yellowlab.tools/result/gxf479pi8l

Added already via PR, thanks!


current changes will be lost after closing a scene recently saved

Please, remove the warning that says you are going to lose unsaved changes if there arent any new changes since last save....
Its scary... :)

From my tests it looks like currently this popup is showed always when we are trying to close scene with "ctrl+shift+w" (nevermind if we changed something or not) and never when we are closing it from UI with [x] on a tab.


Fix parameter names for path functions

Replace minLevel/maxLevel by minHops/maxHops
Description
The documentation still listed the old parameter names for path functions. This PR changes them
Pull request type
Please check what kind of PR this is:

[x] Fix or improvement of an existing page
[ ] New documentation page, release related

@imilinovic does this PR make sense? (since you worked on the path module)

Thank you @thomas-tran-de for the contribution! 🙏


[v2.7] bump default shell version to v0.1.24-rc1

Issue:

https://github.com/rancher/rancher/issues/43563
Problem

Unicode character support in rancher/shell (terminal) via Web UI.
Solution

Bump rancher/shell to use new version with ENV patched for unicode chars.
Testing

Repro steps on issue are accurate.

🤔  - it passed but the steps had errors: https://github.com/rancher/rancher/actions/runs/8900473578/job/24442116075?pr=45306#step:7:38
@alexandreLamarre @cbron any concerns with those errors even though they didn't fail the workflow?


Avoid duplicate selection of columns.

When the key column of a MappedCollection is also present in the contained entity that column got select twice.
We now check if the column already gets selected before adding it to the selection.
This only works properly if the column names derived for the entity property and the key column match exactly, which might require use of a @Column annotation depending on the used NamingStrategy.
Closes #1073

I applied the review feedback and merged this.


[improve][broker] Replace ConcurrentOpenHashMap with ConcurrentHashMap in Topic classes

Main Issue: #23215
Modifications

Apply the replacements for classes that implement org.apache.pulsar.broker.service.Topic interface.
Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository: https://github.com/BewareMyPower/pulsar/pull/36

Codecov Report
Attention: Patch coverage is 71.05263% with 11 lines in your changes missing coverage. Please review.

Project coverage is 74.63%. Comparing base (bbc6224) to head (dbc8a65).
Report is 593 commits behind head on master.

Files with missing lines
Patch %
Lines

...sar/broker/service/persistent/PersistentTopic.java
72.00%
5 Missing and 2 partials :warning:

...oker/service/nonpersistent/NonPersistentTopic.java
40.00%
3 Missing :warning:

...rg/apache/pulsar/broker/service/BrokerService.java
50.00%
1 Missing :warning:

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #23322      +/-   ##
============================================
+ Coverage     73.57%   74.63%   +1.06%
- Complexity    32624    33891    +1267
============================================
  Files          1877     1936      +59
  Lines        139502   145546    +6044
  Branches      15299    15928     +629
============================================
+ Hits         102638   108632    +5994
+ Misses        28908    28608     -300
- Partials       7956     8306     +350

Flag
Coverage Δ

inttests
27.80% <15.78%> (+3.21%)
:arrow_up:

systests
24.64% <10.52%> (+0.32%)
:arrow_up:

unittests
74.00% <71.05%> (+1.15%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines
Coverage Δ

...pulsar/broker/admin/impl/PersistentTopicsBase.java
69.64% <100.00%> (+4.19%)
:arrow_up:

...rg/apache/pulsar/broker/service/AbstractTopic.java
87.84% <ø> (-0.14%)
:arrow_down:

...n/java/org/apache/pulsar/broker/service/Topic.java
37.50% <ø> (+1.13%)
:arrow_up:

.../persistent/ReplicatedSubscriptionsController.java
70.42% <100.00%> (-2.18%)
:arrow_down:

...istent/ReplicatedSubscriptionsSnapshotBuilder.java
80.85% <100.00%> (-0.40%)
:arrow_down:

...rg/apache/pulsar/broker/service/BrokerService.java
83.16% <50.00%> (+2.38%)
:arrow_up:

...oker/service/nonpersistent/NonPersistentTopic.java
71.54% <40.00%> (+2.08%)
:arrow_up:

...sar/broker/service/persistent/PersistentTopic.java
79.20% <72.00%> (+0.74%)
:arrow_up:

... and 592 files with indirect coverage changes


⚠ ClamAV has degraded performance

In 5a75429, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 71 ms

Resolved: ClamAV performance has improved in 55eb17a after 11 minutes.


_commitPromise is inefficient

There's a problem with _commitPromise; because it changes this.value, it will cause all forms of "caching" for other commits to break. Because of this things like the current until directive implementation are really inefficient.
The until directive does this:
part.setValue(defaultContent);
part.commit();
part.setValue(promise);

Imagine that defaultContent is a Node. Right now, the node is removed from DOM and re-inserted every time the directive is processed, because part.setValue(promise) changes part.value which causes the next part.setValue(defaultContent) to fail to detect that it already rendered this node.
This happens regardless if the Promise is resolved or not.
Essentially, _commitPromise breaks the this.value API by setting it to a value that does not represent the currently rendered value, which then breaks the other commit functions that rely on that API.
It can be solved by using a this.promise-like variable and use that instead of this.value for promises.
I can make a PR for this.

The solution is actually quite awkward, because you need to somehow know if something has been rendered after rendering the promise, and the only reliable way to do that is by checking if this.value has changed. Alternatively, all other commit functions must set this.promise to undefined to make sure the promise is inert when it resolves. Either way

I'm working on a PR for this

I made a PR that fixes the issue with Promises. After looking at issue #272 (Promises for AttributeParts) I realise that it's effectively possible to implement a Directive that wraps Promises, and solves the issue entirely.
So effectively, there is an alternative solution. We can change the render / setValue API to no longer accept Promises, and support Promise rendering through a Directive instead. Something like this:
import {promise} from 'lit-html/directives/promise.js';

const p = Promise.resolve('value');

render(html`<div>${promise(p)}</div>`, document.body);

Downside: less flexibility in rendering, if you throw in a Promise it will render [object Promise].
Upsides: Easier implementation. Fixes the issue for all Part types.

Closed by #555


Feature/branch-permissions

Add the ability to create, get, and delete branch permissions.

Miles, run go fmt over the code like this:
laptop:stash> go fmt
createbranchrestriction_test.go
stash.go
The output are the files reformatted.

looks good to me :+1:

I've reformatted createbranchrestriction_test.go and stash.go.


BLZR PWA not working

When attempting to add the BLZR UI as a PWA, the page is not given the proper PWA attribute. This results in the page being added to the iOS Home Screen as a bookmark, not a PWA as intended.

When attempting to add the BLZR UI as a PWA, the page is not given the proper PWA attribute. This results in the page being added to the iOS Home Screen as a bookmark, not a PWA as intended.

the term PWA wasn't really a thing until 2015-2016, whereas the blazer UI was available originally throughout 2010-2011. the original blazer's code is used just with minor changes to work with yt2009, thus no PWA attributes are present.
on top of that, a web UI from 2010 doesn't meet the PWA requirements, such as being usable offline. as it is, it's compatible with target devices of the time, such as older iOS versions (like 6) or early Android devices.
close if no further questions.

Got it.


Add readme for the meter.

To view the readme: https://github.com/BrightspaceUI/core/tree/majones/US106786/meterReadme

Looks really good Maya!
Not related to the documentation, but I find the 3-digit radial pretty cramped.  I think the size of that text could be reduced slightly without sacrificing readability, but it's obviously Bob's call.  Even in the 2-digit case, the text strikes me pretty heavy.


test lab implementation

as a core use  implementation of n-body simulation from lab
test how it behaves with N particles, where N is:

100
200
500
1000
2000
4000
if perform well  continue till significant freezes

criteria:

simple statistics
relation between N and time for 1 second simulation
verdict is it performs well or not

Same as #9


Code cleanup

@jnchaves Can you post a traceback?

@monokrome There isn't much of a traceback... All I'm seeing logging when I hit a post page is... that was another issue is that ideally the VAlueError stacktrace is also logged locally
Captured:
Captured: (<class 'pyramid.httpexceptions.HTTPNotFound'>, <HTTPNotFound at 0x10ec7ffa0 404 Not Found>, <traceback object at 0x10eca3b00>)

@jnchaves This should be ready to go now! Thanks for reviewing :)


Update title of rate limiting page

Page title didn't correspond to H1, and didn't make much sense.
Also consider to change the description as it's very garbled.

Docs Build status updates of commit 0e7fd05:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/bots/how-to/rate-limit.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/bots/how-to/rate-limit.md
94
4
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.


Creating embeddings without creating a rag collection

I'm getting an error about tokens limit when passing in very long articles or documents with -f. I guess they're sent verbatim to the model? Is there a way to automatically create embeddings from the file in such cases?

No, please use .rag.

Excellent !


Fix tuple error from run.py

This appears to fix https://github.com/alanqrwang/keymorph/issues/13

Thanks for this. In a recent commit I changed affine_augment to return return res[0] if len(res) == 1 else res. Sorry for the mistake and hope everything worked out. Closing this.


Remove superCallShouldBeFirst error

It seems redundant since TS gives an error on any use of this before super, and non-this uses before super should be fine.
Fixes #37371

https://github.com/microsoft/TypeScript/pull/5833#discussion_r50729856 from the original PR of the this error implies that it does make the blanket error redundant.

Wasn't this error due to how our transform for properties works? If you allow any non-this statement before super in a class with property initializers then we could have issues:
// ts
class D {
    constructor(f: number) { }
}

class C extends D {
  x = 1;
  constructor(f: boolean) {
   if (f) { super(1); } else { super(2); }
  }
}

// es2015
"use strict";
class D {
    constructor(f) { }
}
class C extends D {
    constructor(f) {
        this.x = 1; // oops?!
        if (f) {
            super(1);
        }
        else {
            super(2);
        }
    }
}

We would need to completely rewrite our class field emit transforms before we could remove this error.

We can remove this error when target is esnext though, right?

@weswigham esNext + useDefineForClassFields

All right, the change now just removes the error for esnext+useDefineForClassFields.

ping @weswigham @rbuckton to look at the reduced change.


Why CJK will show a red line ?

Steps to Reproduce
Use CJK in drawer,
      drawer: new Drawer(
          child: new ListView.builder(
        padding: new EdgeInsets.all(8.0),
        itemCount: 12,
        itemExtent: 32.0,
        itemBuilder: (BuildContext context, int index) {
          return new ListTile(
            leading: const Icon(Icons.event_seat),
            title: new Text('The seat for the ${index}'),
            subtitle: new Text("${index % 2 == 0 ? '子' : 'Test'} is sub"),
          );
        },
      )),

Logs
Performing hot reload...
Reloaded 1 of 444 libraries in 1,403ms.
CoreSimulatorBridge: Switching to keyboard: zh-Hans
CoreSimulatorBridge: KEYMAP: Failed to determine iOS keyboard layout for language zh-Hans.
CoreSimulatorBridge: Switching to keyboard: zh-Hans
CoreSimulatorBridge: KEYMAP: Failed to determine iOS keyboard layout for language zh-Hans.
CoreSimulatorBridge: Switching to keyboard: zh-Hans
CoreSimulatorBridge: KEYMAP: Failed to determine iOS keyboard layout for language zh-Hans.
CoreSimulatorBridge: Switching to keyboard: zh-Hans
CoreSimulatorBridge: KEYMAP: Failed to determine iOS keyboard layout for language zh-Hans.
CoreSimulatorBridge: Switching to keyboard: zh-Hans
CoreSimulatorBridge: KEYMAP: Failed to determine iOS keyboard layout for language zh-Hans.
CoreSimulatorBridge: Switching to keyboard: zh-Hans
CoreSimulatorBridge: KEYMAP: Failed to determine iOS keyboard layout for language zh-Hans.
CoreSimulatorBridge: Switching to keyboard: zh-Hans
CoreSimulatorBridge: KEYMAP: Failed to determine iOS keyboard layout for language zh-Hans.
CoreSimulatorBridge: Switching to keyboard: zh-Hans
CoreSimulatorBridge: KEYMAP: Failed to determine iOS keyboard layout for language zh-Hans.
CoreSimulatorBridge: Switching to keyboard: zh-Hans
CoreSimulatorBridge: KEYMAP: Failed to determine iOS keyboard layout for language zh-Hans.
$ flutter analyze
Analyzing /Users/wener/temp/flutter/myapp...
No issues found!
Ran in 5.6s

Flutter Doctor
$ flutter doctor
[✓] Flutter (on Mac OS X 10.12.5 16F73, locale en-CN, channel alpha)
    • Flutter at /Users/wener/gits/flutter
    • Framework revision b156a0f054 (8 天前), 2017-08-11 22:01:40 -0700
    • Engine revision fef7d827d6
    • Tools Dart version 1.25.0-dev.9.0

[✓] Android toolchain - develop for Android devices (Android SDK 25.0.3)
    • Android SDK at /usr/local/Cellar/android-sdk/24.4.1
    • Platform android-25, build-tools 25.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_112-release-b06)

[-] iOS toolchain - develop for iOS devices (Xcode 8.3.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 8.3.3, Build version 8E3004b
    • ios-deploy 1.9.1
    ✗ CocoaPods installed but not initialized.
        CocoaPods is used to retrieve the iOS platform side's plugin code that responds to your plugin usage on the Dart side.
        Without resolving iOS dependencies with CocoaPods, plugins will not work on iOS.
        For more info, see https://flutter.io/platform-plugins
      To initialize CocoaPods, run:
        pod setup
      once to finalize CocoaPods' installation.

[✓] Android Studio (version 2.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Java version OpenJDK Runtime Environment (build 1.8.0_112-release-b06)

[✓] IntelliJ IDEA Ultimate Edition (version 2017.2.2)
    • Flutter plugin version 16.0
    • Dart plugin version 172.3757.55

[✓] Connected devices
    • iPhone SE • 38708F50-0901-4020-B737-AA0C8D6C5BDE • ios • iOS 10.3 (simulator)

The red line is because the column is overflowing, maybe because the text is too big.
We need to handle ideographic text better, right now we haven't done anything to support it.

This is an i18n issue so we will look at it soon. I'm hoping to look at this after we land libtxt.

If this fixed, I may use flutter for my next project 🍺

First we need to check if this is still happening (especially with libtxt landing), and if so, we need to check what the cause is.
The Material Typography stuff in theory knows to select different fonts and line heights based on the locale, which may be relevant here.

Problem still exists

@wenerme Thanks for the update.

@jason-simmons is working on adding locale-awareness to our text APIs, once we have that we'll see if that helped. However, I suspect it will not... what's weird in your most recent example is that even the ListTiles without any CJK are overflowing.

This happens in both the current text engine used in Flutter and the older (Blink-based) text engine.
The CJK fallback font has different metrics from the default font.  At a given fontSize the CJK font's glyphs are taller than those of the default font, causing the text to overflow the enclosing UnconstrainedBox.
The CJK text will fit if the fontSize is reduced.

Does it happen when the locale has been changed to a CJK locale? In theory in CJK locales we change the font size for precisely this reason.

The rendering looks the same if a locale is applied.
From what I can tell, setting the locale in HarfBuzz affects glyph selection but does not alter the font size.

Sorry, I meant the locale in the MaterialApp widget. It should change what the default font sizes are for text in material apps.

Hi @wenerme
Trying to reproduce this issue using given code sample on latest dev channel but no red lines

flutter doctor -v
[✓] Flutter (Channel dev, v1.18.0-6.0.pre, on Mac OS X 10.15.4 19E287, locale
    en-GB)
    • Flutter version 1.18.0-6.0.pre at /Users/taha/Code/flutter_dev
    • Framework revision 84c84fb249 (31 hours ago), 2020-04-20 21:35:01 -0400
    • Engine revision 2bde4f0ae4
    • Dart version 2.9.0 (build 2.9.0-1.0.dev a12c36dd97)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/taha/Code/sdk
    • Platform android-29, build-tools 29.0.3
    • ANDROID_HOME = /Users/taha/Code/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_212-release-1586-b4-5784211)
    • All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 11.4.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.4.1, Build version 11E503a
    • CocoaPods version 1.9.1
[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 3.6)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 45.1.1
    • Dart plugin version 192.7761
    • Java version OpenJDK Runtime Environment (build
      1.8.0_212-release-1586-b4-5784211)
[✓] VS Code (version 1.44.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.9.1
[✓] Connected device (4 available)
    • SM M305F   • 32003c30dc19668f • android-arm64  • Android 10 (API 29)
    • macOS      • macOS            • darwin-x64     • Mac OS X 10.15.4 19E287
    • Chrome     • chrome           • web-javascript • Google Chrome
      81.0.4044.113
    • Web Server • web-server       • web-javascript • Flutter Tools
• No issues found!

if you're still experiencing this problem, please create a new issue and provide the information
required in the template.
Thank you


test: Annotate lock deployment with Jenkins $BUILD_URL

test-me-please

Coverage decreased (-0.02%) to 42.611% when pulling d0b5539ef575ecb65d0f170f81df177d3643d953 on pr/errordeveloper/gke-jenkins-build-annotation into 2ff7193bb2301523af39695646ac4eb2a1294f17 on master.

Confirmed that this works fine in our infra, test failures are irrelevant to the change, merging.


multiple separate routes

Any solution to calling a regular array of markers, then another instance on top of the initial map for a route? Ideally an infinite amount of route instances? Maps v3 allows multiple routes on a single map. Just curious if theres a way to do this via Maplace.

There is not a proper way to do that at least for now, but you can cheat a bit the script to work in this way:
http://jsfiddle.net/_tomorro/8gVPk/9/

This will not work anymore as workaround from v0.2.8 due fix #161


Demo constantly says connecting

Hi guys, got everything set up and all seems ok, however in the access url it constantly says connecting and does not connect, in the UI it shows no connected browsers. Any suggestions?

Sorry posted in wrong repo this is for:
https://github.com/versatica/mediasoup-demo


Cleanup workers automatically after a configurable "abandoned" time

There should be a configurable workerAbandonTime setting.
Once a worker is dead for greater than this setting, it should be a candidate for automatic removal from the database.
Other tables that need to be cleaned up (for example the proc def tables) could be cascaded in this cleanup as well.
NOTE:  Issue #7  would have to be completed before this ticket.

Rough time estimate:  1 day

@ztaylor54  That is the current approach, and it's run periodically/automatically via a crobjob.  This cronjob is setup by the mission, and is external to CWS core.  This ticket is about automating it in CWS core, which will be a better approach.

Jira ticket: https://jira.jpl.nasa.gov/browse/CWS-647

Closed in v2.2


cmd/go: "#cgo pkg-config:" comments do not work with gccgo

I don't have a minimal example, but https://launchpadlibrarian.net/211688868/buildlog_ubuntu-wily-arm64.account-polld_0.1%2B15.04.20150410-0ubuntu2~gcc5.1_BUILDING.txt.gz is an example of this happening. http://bazaar.launchpad.net/~ubuntu-push-hackers/account-polld/trunk/view/head:/accounts/accounts.go#L20 is "#cgo pkg-config: glib-2.0 libaccounts-glib libsignon-glib" but the flags are not being passed in the link.
I don't entirely get how this is supposed to work. cgo writes the flags to a file:
$ cat $WORK/launchpad.net/account-polld/accounts/_obj/_cgo_flags
_CGO_LDFLAGS=-g -O2 -laccounts-glib -lsignon-glib -lgio-2.0 -lgobject-2.0 -lglib-2.0
_CGO_CFLAGS=-pthread -I/usr/include/signond -I/usr/include/gio-unix-2.0/ -I/usr/include/glib-2.0 -I/usr/lib/aarch64-linux-gnu/glib-2.0/include -I /tmp/go-build086811367/launchpad.net/account-polld/accounts/_obj/

but afaict nothing ever looks at this file. When *gccgo is false (https://github.com/golang/go/blob/master/src/cmd/cgo/out.go#L42) it also writes out //go:cgo_ldflag comments, which is how this works with the usual compiler but gccgo doesn't use those comments I think.

The pkg-config flags are implemented by cmd/go, not cmd/cgo.
The code does seem to be independent of the compiler toolchain; I don't know why it's not working for gccgo.

Well, pkg-config is called by cmd/go sure, but the way the flags get used seems to be a cgo / cmd/compile / cmd/link collaboration: go calls pkg-config, passes the results to cgo as CGO_LDFLAGS in the environment, cgo writes them as cgo_ldflags comments to one of the .go files it creates, cmd/compile translates those to the "$$ // cgo" section of the .o file, which is read by cmd/link and passed to the external linker. Only the first two bits happen when using gccgo.
I don't know what a fix would look like. The go tool could somehow stuff some record of the flags into the .a of a cgo using package and look for it again when linking? Currently I don't think it actually looks into the lib$name.a files at all but I guess that could change...

Can someone assign this to me please?

I've hit this as well. Any status update?

Not really -- I definitely want to get this fixed for 1.6 but haven't started on it myself, or even thought very hard about how to fix it (the only thing I've thought is to have the go tool put the the flags into the .a file of a package using cgo and reading them out when linking)

Should not this have been fixed by https://codereview.appspot.com/157460043/ ? That's about a year old, so maybe something else broke?

No that fixed the worst of the problems in the area, but this one is different: pkg-config is run when the go package is compiled, but the flags must be used when the executable is linked, which might not be in the same invocation of the go tool.

This would be nice but I don't see this happening for Go 1.6.

Yeah, didn't get to this :/


[6.4.x] BPMSPL-252: [GSS-RFE] Ability to check duplicate of ReleaseId (GroupId, ArtifactId and Version) with existing projects

See https://issues.jboss.org/browse/BPMSPL-252
This is the PR for 6.4.x.

Part of the following ensemble:
https://github.com/droolsjbpm/drools/pull/635
https://github.com/droolsjbpm/guvnor/pull/241
https://github.com/droolsjbpm/kie-wb-common/pull/243
https://github.com/droolsjbpm/drools-wb/pull/122
https://github.com/droolsjbpm/kie-wb-distributions/pull/190
https://github.com/droolsjbpm/kie-docs/pull/41

I need to ensure this PR is JDK1.6 compatible.... will advise when fixed.

Re-wrote the affected code to be JDK1.6 compatible.. OK to review..

6.4.x: e7e207daf8a13b23b2e9134b81ec1aba0e3ebf78


[SPARK-31705][SQL][FOLLOWUP] Avoid the unnecessary CNF computation for full-outer joins

What changes were proposed in this pull request?

To avoid the unnecessary CNF computation for full-outer joins, this PR fixes code for filtering out full-outer joins at the entrance of the rule.
Why are the changes needed?

To mitigate optimizer overhead.
Does this PR introduce any user-facing change?

No.
How was this patch tested?

Existing tests.

cc: @gengliangwang @cloud-fan

Test build #123908 has started for PR 28810 at commit 6cad6c6.

@maropu Thanks for the improvement. Shall we update PushPredicateThroughJoin as well?

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/28531/
Test PASSed.

Yea, sure.

Test build #123917 has started for PR 28810 at commit 7850c2b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/28540/
Test PASSed.

Test build #123923 has started for PR 28810 at commit 1251b68.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/28545/
Test PASSed.

Test build #123908 has finished for PR 28810 at commit 6cad6c6.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123908/
Test FAILed.

retest this please

Test build #123931 has started for PR 28810 at commit 1251b68.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/28553/
Test PASSed.

Test build #123917 has finished for PR 28810 at commit 7850c2b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123917/
Test PASSed.

Test build #123923 has finished for PR 28810 at commit 1251b68.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123923/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123931/
Test PASSed.

retest this please

ping @cloud-fan @gengliangwang

Test build #124081 has started for PR 28810 at commit 1251b68.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/28700/
Test PASSed.

Merged build finished. Test PASSed.

Test build #124081 has finished for PR 28810 at commit 1251b68.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124081/
Test FAILed.

retest this please

Test build #124104 has started for PR 28810 at commit 1251b68.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/28722/
Test PASSed.

Test build #124104 has finished for PR 28810 at commit 1251b68.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124104/
Test FAILed.

Test build #124120 has started for PR 28810 at commit f4497a6.

Thanks, all! Pending, Jenkins.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/28739/
Test PASSed.

Test build #124122 has started for PR 28810 at commit 6dbff0c.

Test build #124122 has finished for PR 28810 at commit 6dbff0c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124122/
Test PASSed.

Merged to master.

Test build #124120 has finished for PR 28810 at commit f4497a6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124120/
Test PASSed.


Media index is always zero

It seems that due to the re-definition of mediaIndex on line 376 the value is not saved to the variable in the outside scope on line 351, causing the returned value to always be 0. Deleting the 'let' keyword seems to fix the issue.

PR 32 was created for this
https://github.com/y252328/Instagram_Download_Button/pull/32


View filters for PDF request options are not working

I am getting pdf with filters which is applied during publishing.
It would be good if you guide me to apply multiple filters
pdf_req_option = TSC.PDFRequestOptions(page_type=TSC.PDFRequestOptions.PageType.A4,orientation=TSC.PDFRequestOptions.Orientation.Landscape)
pdf_req_option.vf("P_Unit","ABCD")
server.workbooks.populate_pdf(workbook,options)

Hi Vignesh,
Did you get any answer or way to do get the pdfs using TSC.

They do not seem to be supported by the respective API endpoint at all but only the "Query View PDF" endpoint. For some reason however they share the same options object which does not properly fit either of them. Also see #1102

Keeping this one open so we can investigate to see if any code/doc changes are needed.


Fix Unify for Stream

@mikearnaldi ready to merge?

@mikearnaldi ready to merge?

think so, unless I missed something

I can confirm it fixes the Unify issue and doesn't break anything in a large codebase


[Rating] Clear value if selected value is clicked

While using the Rating, I faced the challenge that it was not possible to clear the rating without adding a "clear" button. This PR sets the rating value to null if the current rating is clicked.

[x] I have followed (at least) the PR section of the contributing guide.

@oliviertassinari While looking at the code to understand why the value is set to null, rather than zero to reset the rating (given that the defaultChecked input has a value of 0), I noticed that the zero input is never actually rendered.
This is because roundValueToPrecision() always returns a number:
https://github.com/mui-org/material-ui/blob/52e808369f2bde5b21ae30858d829e448b213314/packages/material-ui-lab/src/Rating/Rating.js#L24
https://github.com/mui-org/material-ui/blob/52e808369f2bde5b21ae30858d829e448b213314/packages/material-ui-lab/src/Rating/Rating.js#L162
but the (abstract) equality check is for null:
https://github.com/mui-org/material-ui/blob/52e808369f2bde5b21ae30858d829e448b213314/packages/material-ui-lab/src/Rating/Rating.js#L346
Tangentially related - if the hidden input represents no current rating, should the label say that, rather than "0 Stars"? (Zero starts sounds like the lowest rating, rather than no rating.)
Unrelated - should the disabled rating have a role and aria-label? (And what's the practical distinction between disabled and read-only for rating component?)

@mbrookes Great catch! I have updated the pull request to reflect it.

Unrelated - should the disabled rating have a role and aria-label?

I don't know, I couldn't find any better resource for a11y than https://www.w3.org/WAI/tutorials/forms/custom-controls/.

(And what's the practical distinction between disabled and read-only for rating component?)

Read-only is for presentational rating, e.g. the ones you will see when looking at a review.
Disabled if for forms.

The update looks good.
Regarding the disabled state - at the moment in the docs example we have the legend "Disabled", then a set of presentational SVGs. There's nothing to indicate to a screen reader what it is that's disabled (hence the question about a label). We could make the legend more explicit "Disabled rating input", but I wonder instead if it should have actual disabled radio inputs? (Would that more accurately represent to a screen reader the current state of the component?)

but I wonder instead if it should have actual disabled radio inputs?

Agree.

@ivowork Thanks for the care on the component. It's a good step forward.

Side note, the component popularity relative to the others, position 51:

https://analytics.google.com/analytics/web/#/report/content-pages/a106598593w159022482p160376982/explorer-table.plotKeys=[]&explorer-table.rowCount=500&explorer-table.advFilter=[[0,"analytics.pagePath","BW","~2Fcomponents~2F",0]]&explorer-table-tableMode.selected=data

I'm sorry for bumping such an old PR but this seems like a good place to ask my question so people with the same question will find the answer.
How can you change the rating to zero?


Conjur Operator

Request for a new public Conjur project in CyberArk GitHub
Current project source: https://github.com/guygiat/conjur-operator (private repo)
Current maintainer: Guy Giat, guygiat
Desired project URL: https://github.com/cyberark/conjur-operator (we already have an archived project with the same name so we need to decide what to do)
Brief description of project: Conjur operator for Conjur OSS deployment with OCP support.
Anticipated certification level: Trusted

I created https://github.com/cyberark/conjur-operator for you.
On your first pull request you will see a checklist in the PR description - you can use this to guide you on the steps needed to make the repo public. Please tag me as a reviewer once the project is ready for review, and I can review and make it public.
Please note, that to get this project to Trusted before publishing will require:

Security review
Documentation for standard flows (in GitHub is ok to start)
Feature implementation is largely complete (eg project can gracefully handle most problems that may arise when veering from the happy path of the main use case)
Comprehensive tests
Automated security scans

We can work with you on the items above, but releasing as trusted to start will take time. I'd recommend releasing as Community first and working with us to get the project to Trusted after publishing the code. It can still be useful to end users even at the Community level!


Support hset hget

Is your feature request related to a problem? Please describe.
I have noticed that the current implementation of node-cache-manager lacks support for the hset and hget operations. These operations are crucial for scenarios where a hash-like data structure is needed, and their absence restricts certain use cases
Describe the solution you'd like
I would like to request the addition of hset and hget support in node-cache-manager. This would enhance the functionality of the library by allowing users to efficiently manage and retrieve data using hash keys.
const userId = 1;

const userDetails = {
  name: 'John Doe',
  email<EMAIL_ADDRESS>  // other user details
};

memoryCache.store.hset(userId, 'userDetails', userDetails);

const cachedUserDetails = cache.hget(userId, 'userDetails');

Thank you for considering this feature request!

Thanks @namhihi237 and at this time we are not going to be supporting this as our goal is to support multiple back ends which this could cause issues.


On the shop in the category page, filters are not working.

Terms

[X] Before you openning this issue, i have checked if the issue has already been reported.

Bagisto Version(s) affected
master
Issue Description
On the shop in the category page, filters are not working.
Preconditions

Admin should have at least one category.
Admin should have two or more products in the category.

Steps to reproduce

Go to 'Shop'
Click on the 'Category'
Apply filters
See the error

Expected Result
Filters should work accordingly.
Actual Result
Not showing product not found if any filter is applied. Here
Screenshots
No response
Additional context
No response

@Amitk-webkul Filters are working properly.

All options should available in the product


Fix issue that prevented RVTD content from loading in OneBusAway

Fixes #463 (for real this time)

Add a GPX file for Rogue Valley
Replace a couple id types in fast enumeration loops with the objects' actual type
Genericize App Transport Security settings to allow all domains to load arbitrary content in our app.

Just a little lunch time bug fixing? :+1:

Yup

Thanks @aaronbrethorst, we really appreciate you working on this!! :)

@barbeau - my pleasure :)


[Bug] version 0.12.0 cannot pass UT

What happened
at org.apache.inlong.dataproxy.metrics.TestDataProxyMetricItemSet.testResult(TestDataProxyMetricItemSet.java:168)

What you expected to happen
UT should be passed
How to reproduce
down load and build with mvn package
https://github.com/apache/incubator-inlong/releases/tag/0.12.0-incubating-RC0
Environment
No response
InLong version
0.12.0
InLong Component
InLong DataProxy
Are you willing to submit PR?

[ ] Yes, I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

@luchunliang PTAL


feat: layout of admin && customer

there is some merge conflicts fix it && make sure that you won't do any changes in client  without my approval !!

It seems almost impossible to resolve this merge confict!


Add macos specific options to allow different builds

fix for https://github.com/Blightmud/Blightmud/issues/768

Nice work. Thanks


Working with node-archiver

When I developed my app with webpack, I found that it can't work well with node-archiver, reporting an error as follows:
[1333:1229/113633:ERROR:nw_shell.cc(336)] Error: append: input source must be valid Stream or Buffer instance
    at Archiver.append (file:///Users/cloudy/workspaces/javascript/push_message/bundle.js:22006:25)
    at Object.<anonymous> (file:///Users/cloudy/workspaces/javascript/push_message/bundle.js:963:10)
    at __webpack_require__ (file:///Users/cloudy/workspaces/javascript/push_message/bundle.js:20:30)
    at Object.<anonymous> (file:///Users/cloudy/workspaces/javascript/push_message/bundle.js:47:19)
    at __webpack_require__ (file:///Users/cloudy/workspaces/javascript/push_message/bundle.js:20:30)

It fails on instanceof Stream which returns false.

Can you provide more information? What kind of an application are you trying to build?

Just a simple tool for packing some images into a zip file. I developed this with react.js, nw.js and webpack. Oh, it's a desktop application. For the moment, I solved this problem by adding the node-archiver as an external module.
    externals: {
        "archiver": "archiver"
    },

I inspected the bundle.js just now. Maybe, pasting some code will help.
// my code
archive
  .append(fs.createReadStream(file1), { name: 'file1.txt' })
  .append(fs.createReadStream(file2), { name: 'file2.txt' })
  .finalize();
}

// definition of append
	Archiver.prototype.append = function(source, data) {
        //some codes here...
	  source = util.normalizeInputSource(source);
        //some codes here...
  }

// definition of normalizeInputSource
	var util = module.exports = {};

	util.isStream = function(source) {
	  return source instanceof Stream; // Should have returned true here.
	};

	util.normalizeInputSource = function(source) {
	  if (source === null) {
	    return new Buffer(0);
	  } else if (typeof source === 'string') {
	    return new Buffer(source);
	  } else if (util.isStream(source) && !source._readableState) {
	    var normalized = new PassThrough();
	    source.pipe(normalized);

	    return normalized;
	  }

	  return source;
	};

That's puzzling. Can you figure out the type of source? Why would it be something different when bundled?

I print the type of source and I got an Object. So I try to figure out the prototype of Stream, and noting different. Weird~

The type of source is ReadStream. Its base type is Readable. And the base type of Readable is Stream.

It's hard to say why it's different. Esp. that I print the type of source and I got an Object. sounds strange. Why would it be Object?

Well, maybe I have found the problem. I print the prototype of the Stream exported by require("stream") and the prototype of the Stream in bundle.js. There are some differences between them.

Chances are that I used stream-browserify modules of multiple versions. But more time is needed for the real problem.

Yeah, a difference like that would be enough and would explain why the test fails. You would have to dig deeper to understand where that initial instance comes from.

Hey, @cloudy064 did you find a solution to this?

Hey, I fount a way to fix it, turn your stream obj to PassThrough and use it,  like this:
const source = new PassThrough()   stream.pipe(source)
it works for me!


[BUG] Remove openshift-openstack-infra, openshift-ovirt-infra, openshift-vsphere-infra from the libvirt CRC

General information

OS: Linux
Hypervisor: KVM
Did you run crc setup before starting it (Yes/No)? Yes
Running CRC on: Laptop

CRC version
CodeReady Containers version: 1.14.0+36ad776
OpenShift version: 4.5.4 (embedded in binary)

I was surprised to see 57(!) projects for the simple out of the box CRC for Linux installation. I'm not sure how many are needed, but it's quite clear to me there's no need for OSP, oVirt or vSphere infra there.

@mykaul These are just the namespaces created by installer I think but doesn't contain any resources, I don't see any harm having it there because same will be present in case of real cluster. Also this need to be part of code-ready/snc repo where we create the bundle.

ACK.


Error on shadowed variables

I have encountered these errors like 10 times. It is common.
(let k 5)
...
(let k 7)

there is a common case where shadowing is also intentional. However this can be handled with a simple set instead of let which is a very reasonable concession.


[Gekidou] Sidebar Categories (Database only)

Summary
Introduces Category & CategoryChannel for sidebar categories.
Ticket Link
https://mattermost.atlassian.net/browse/MM-38765
Checklist

[ ] Added or updated unit tests (required for all new features)
[ ] Has UI changes
[ ] Includes text changes and localization file updates
[ ] Have tested against the 5 core themes to ensure consistency between them.

Device Information
This PR was tested on:
Screenshots

Release Note

you are missing the addition of the category_id in the handleChannels and everything related?

We only need the Category >> CategoryChannel >> Channel relationship (from category side) for the sidebar so there's no need to add it there (yet!).

We only need the Category >> CategoryChannel >> Channel relationship (from category side) for the sidebar so there's no need to add it there (yet!).

got it

@avinashlng1080 this is blocking plz review ASAP

I have added the database-related changes from https://github.com/mattermost/mattermost-mobile/pull/5916/commits/eb2528bc85538b3c1db189fe9f872455dc2d2593, and resolved all the feedback other than the transformer/operator tests for category; will add those later.


GCP Module Work

Overall goals:

support same set of functionality as existing AWS module
use consistent variable naming between AWS and GCP wherever possible
support same set of example scenarios as AWS module

Specific tasks:

[x] split subnet into three separate subnets. GCP subnets are regional not AZ so no need for funny business
[x] generate examples using AWS examples as base

[x] proxy
[x] airgap
[x] multi az proxy
[x] multi az airgap

[x] generate tests from examples with terratest or shell script
[x] buildkite build pipeline (will need to get devprod to assist here with init)
[ ] build testing for GCP instances into deployment-automation
[ ] update official Docs to support GCP path

Cut the subnet splitting as

GCP subnets stretch across AZs
firewall rules are tag based


Add command to output cargo config values

Describe the problem you are trying to solve
I'm trying to add feature for cargo-edit, a cargo plugin.
I want to query crate versions from local registry index rather than HTTP API, but I don't want to depend on cargo as a lib (because it's huge). So I have to parse cargo config and get registry index path.
Here is the problem: directory name of registry index looks like {hostname}-{hash}, and part of the hash implement is here, which means I have to introduce the type in cargo, otherwise I can't get the hash.
Describe the solution you'd like
That's would be great if there is a subcommand to output some cargo config values, just like cargo-metadata, but for cargo itself.
With this, I could just read the JSON of the command output, that's would be very helpful.
Image in my mind:
$ cargo config --list --format-version=1
{
    "sources":[
        { "name": "crates-io", "registry": "https://github.com/rust-lang/crates.io-index", "index_path": "/home/dcjanus/.cargo/registry/index/github.com-1ecc6299db9ec823", "replace-with": "rustcc" },
        { "name": "rustcc", "registry": "https://code.aliyun.com/rustcc/crates.io-index.git", "index_path": "/home/dcjanus/.cargo/registry/index/code.aliyun.com-738b7dba08a2a41e" }
    ]
    ...
}

I don't think we ever want to expose the .cargo/registry paths, as these are internal to cargo and not something we want to support for external tools.

cargo config has been implemented on nightly and is tracked in #9301.
Providing access to the index is tracked in #7824 (though as noted there, there are issues with assuming cargo will have access to the whole index).
I'm going to close in favor of those issues.


Staking & UbiquityChef Contract Slither Issue

There's three slither issues coming up still. Two are both cause _deposit calls _updatePools and the contstructor calls _deposit inside a loop. It's not possible to resolve this without a massive refactor of BondingV2 and MasterChefV2
Third is cause I replaced transfer with call for sending Ether, this is the current best practice.

Originally posted by @hashedMae in https://github.com/ubiquity/ubiquity-dollar/commit/5d004fa7cfa9cf259fb67d17d52d439bac61f15e#commitcomment-92608369

I resolved these in #284
Comment was intended as a progress update

@pavlovcik @0xcodercrane Okay to mark this as closed?

yes


some tests in //tensorflow/lite/testing/ fail to build

Please make sure that this is a build/installation issue. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:build_template
System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 18.04.1 LTS
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary): source
TensorFlow version: commit 6583b83dc9393118c60a9c11f15453c650fab89f
Python version: 2.7.15rc1
Installed using virtualenv? pip? conda?: sources
Bazel version (if compiling from source): 0.20.0
GCC/Compiler version (if compiling from source): gcc (Ubuntu 7.3.0-27ubuntu1~18.04) 7.3.0
CUDA/cuDNN version: -
GPU model and memory: -

Describe the problem
Build errors occur in zip tests
Provide the exact sequence of commands / steps that you executed before running into the problem
bazel test -k --verbose_failures --config=opt -- //tensorflow/lite/testing/...
 Devices:
2019-03-14 11:48:24.316342: I tensorflow/compiler/xla/service/service.cc:174]   StreamExecutor device (0): <undefined>, <undefined>
W0314 11:48:24.329004<PHONE_NUMBER>12768 deprecation.py:323] From /root/.cache/bazel/_bazel_root/eee9defa2fa4c4fc557baa005719ebd9/execroot/org_tensorflow/bazel-out/host/bin/tensorflow/lite/testing/generate_examples
.runfiles/org_tensorflow/tensorflow/lite/testing/generate_examples.py:511: remove_training_nodes (from tensorflow.python.framework.graph_util_impl) is deprecated and will be removed in a future version.
Instructions for updating:
Use `tf.compat.v1.graph_util.remove_training_nodes`
/bin/bash: line 1:  8879 Segmentation fault      (core dumped) bazel-out/host/bin/tensorflow/lite/testing/generate_examples --toco bazel-out/host/bin/tensorflow/lite/toco/toco --zip_to_output gather.zip bazel-ou
t/k8-opt/genfiles/tensorflow/lite/testing
ERROR: /local/people/kamil_herba/tensorflow-x86/tensorflow/lite/testing/BUILD:21:2: Couldn't build file tensorflow/lite/testing/gather_toco-flex.zip: Executing genrule //tensorflow/lite/testing:gather_toco-flex.
zip.files failed (Segmentation fault): bash failed: error executing command
  (cd /root/.cache/bazel/_bazel_root/eee9defa2fa4c4fc557baa005719ebd9/execroot/org_tensorflow && \
  exec env - \
    PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin \
    PYTHON_BIN_PATH=/usr/local/bin/python \
    PYTHON_LIB_PATH=/usr/local/lib/python2.7/dist-packages \
    TF_DOWNLOAD_CLANG=0 \
    TF_NEED_CUDA=0 \
    TF_NEED_OPENCL_SYCL=0 \
    TF_NEED_ROCM=0 \

I could replicate this issue in 2.8 version too.

Hi @haozha111 ! Tests are running fine in the 2.9 version.   @herbakamil ! Can we move this issue to closed status now? Thanks!

Hi @haozha111 ! Tests are running fine in the 2.9 version.   @herbakamil ! Can we move this issue to closed status now? Thanks!


doc: fix typo in ms_selection.3

Spotted by Lintian: https://lintian.debian.org/sources/libmseed.

Thanks @paride


Update NodeToClientV_6 → NodeToClientV_8

Issue Number
ADP-672
Overview

LocalStateQuery protocol codec change, allows to acquire tip point.
Replace multiple definitions of NodeToClientVersion.

Comments

Based on PR #2459 branch - merge that first.

bors r+

bors r+

bors r-

bors r-

It doesn't compile yet :sweat_smile:

It doesn't compile yet :sweat_smile:

Oops, it did compile then I removed an import...
bors r+

Oops, it did compile then I removed an import...
bors r+

😅 I was just thinking bors was stuck again 🎉

😅 I was just thinking bors was stuck again 🎉

Looks like a github problem. Usually it says "iohk-bors [bot] added a commit that referenced this pull request: b1a93198bc676e7c241417cb91d94ffec142ce55"

Looks like a github problem. Usually it says "iohk-bors [bot] added a commit that referenced this pull request: b1a93198bc676e7c241417cb91d94ffec142ce55"

It took a while for bors to succeed after both buildkite and hydra had passed

It took a while for bors to succeed after both buildkite and hydra had passed


Fix terminology "Not Privacy Sensitive" vs "Low Privacy-Sensitivity" [Scheme 3]

They seem to mean the same thing. Maybe, just use "Low Privacy-Sensitivity"? Maybe, this is populated from different parts of the codebase. It's probably just relevant for scheme 3 as the other schemes do not include the profiles. But let's make sure.

I actually already fixed this when making the other scheme 3 changes. So we're all set here!

Great! Feel free to close then if there is nothing more to do, @bella-tassone.


Add systemd-setup command

This PR assumes 3 things:

That there is a binary called hyperspace which is not going to be present in most circumstances, since the binary tends to be called hyp instead depending on how you installed it.
npm is on the PATH
systemctl is on the PATH.

These assumptions are too much, this PR reinvents package management, poorly. In a sandboxed scenario, like with Nix, why would the application have access to npm or systemctl? These are not supposed to be runtime dependencies of any application.
In order to actually install services on Linux systems, you need to comply with the package manager of a given distribution. What this does is bypass that and  will ultimately produce a bad experience.

I agree with @MatthewCroughan, systemd services should be handled by the package manager (or the user if they choose to set one up manually). Handling it in the runtime is antithetical to the Linux philosophy, and as above stated this will fall apart when a distribution breaks the built-in assumptions.

I agree at runtime isn't the time to install systemd files. This is a separate script that i created before hyp existed.
What it does is integrate hyperdrive better with a linux user. I think its a good thing to offer any user on linux .service files for their daemon-esque processes. Its just not npms job to assume.
I think most linux distributions package managers do offer a .service file for packages that can be installed and 'systemd enabled', eg databases and such. It rarely enables these packages for you but leaves that to the user, leaving it, even when installed, an opt in feature. This pr definitely doesn't force it on anyone.
I do think that a system package manager installing hyp should offer you a systemd integration. With nix things are a little tricky i feel esp with hyperspace's current three service file requirement.
Systemd is only a launcher and integrating with its network.target just makes sense for hyperspace, if you want max uptime and not forcing you to run the cli every time you want these processes started.
Systemd is also not 'PATH'-aware, and users might have odd nvm-ish installations of npm. This seperate systemd-setup script is just being careful about assuming anything about the configuration and system setup before creating a service file. In the users .config directory.
Now, I'll close this and encourage anybody wanting tighter systemd integration with hyperspace to open a pr with something similar as a seperate command in hyp's toolbox.

I do think that a system package manager installing hyp should offer you a systemd integration. With nix things are a little tricky i feel esp with hyperspace's current three service file requirement.

All of what you've said is correct, but I don't think it will ever make sense to have hyp managing the user's system and modifying files that change the system's behavior. Doing so bypasses the system's state management tools (package manager) and introduces state that is not tracked by anything other than hyp into their system, essentially turning hyp into a state management utility for Linux systems, which is a bad situation and out-of-scope in my view. Either hyp becomes a package manager replacement, or it stays out of it entirely. I do notice that this has only done so in the user's home directory and using a systemd user service, which is much better than most things that modify root, and is perfectly acceptable behavior for most programs, but somehow it just doesn't feel right to do this at all (in my opinion).
The correct way for this to be handled would be for npm to support providing systemd user service files as part of an installation, at the very least; rather than hyp handling it. This would require changes to npm as far as I know.
Nix isn't particularly relevant, I only used it as an example. But it is not difficult to do services there. I will see if I can implement it soon to demonstrate.


Incorrect metadata value displayed

The metadata display repeats the value for a previous label (accession number appears again under bibliography).  The screen shot shows the current version of Mirador vs. an earlier version.  The demo Manifest is http://manifests.britishart.yale.edu/manifest/5009

We are making the assumption that if the value is an array, then it is an array of objects that provide the same value of that label in multiple languages.  That manifest has an array for Bibliography with one string in it.
Before I make the correct fix, this is probably also a question for @azaroth42 since I can't find anything specific one way or the other in the api description.  Is this structure in the manifest valid?

An array of values with no language associated (e.g. where the values are not objects with @value/@language keys) then it's just a set of values.
The structure in the manifest:
{
 "metadata": [
    {
      "label": "Bibliography",
      "value": ["...", "...", "..."]
    }
  ]
}

Is correct.  This is just a case of http://iiif.io/api/presentation/2.0/#repeated-properties, where the property being repeated is value.
The content of those strings is not correct, as according to http://iiif.io/api/presentation/2.0/#property-values-in-html if the value is HTML, then it MUST start with < and end with > but the client should be displaying all of them.
Yes ... the test here is a bit wishy washy to distinguish between a choice based on language and only one should be displayed, and a list where all of the values should be displayed.  The alternative is to always distinguish a choice as a separate resource, which makes it harder to have the strings for the 95% case, and the decision was to be slightly ambiguous.  We could clarify this in http://iiif.io/api/presentation/2.1/#language-of-property-values

Seems reasonable and not questioning the existing spec but why would text with HTML need to start with open bracket and end with close bracket?  What about cases where a string contains simple embedded formatting codes for italics, underline, bold, etc.? Should we start with empty span tag and end with same?
-------- Original message --------
From: Rob Sanderson<EMAIL_ADDRESS>Date:03/22/2016 5:26 PM (GMT-05:00)
To: IIIF/mirador<EMAIL_ADDRESS>Cc:
Subject: Re: [mirador] Incorrect metadata value displayed (#798)
An array of values with no language associated (e.g. where the values are not objects with @value/@languagehttps://github.com/language keys) then it's just a set of values.
The structure in the manifest:
{
"metadata": [
{
"label": "Bibliography",
"value": ["...", "...", "..."]
}
]
}
Is correct. This is just a case of http://iiif.io/api/presentation/2.0/#repeated-properties, where the property being repeated is value.
The content of those strings is not correct, as according to http://iiif.io/api/presentation/2.0/#property-values-in-html if the value is HTML, then it MUST start with < and end with > but the client should be displaying all of them.
Yes ... the test here is a bit wishy washy to distinguish between a choice based on language and only one should be displayed, and a list where all of the values should be displayed. The alternative is to always distinguish a choice as a separate resource, which makes it harder to have the strings for the 95% case, and the decision was to be slightly ambiguous. We could clarify this in http://iiif.io/api/presentation/2.1/#language-of-property-values

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHubhttps://github.com/IIIF/mirador/issues/798#issuecomment-200036440

The requirement to start and end with brackets is to make it clear (or as clear as possible) to distinguish HTML from plain text that might include angle brackets. So the resolution to whether a < is a real < or the beginning of an HTML tag is the test on the first and last characters of the string.

@rsinghal noted the cause but for completeness, tested a manifest with <span> tags -   http://manifests.britishart.yale.edu/manifest/1004 - and behavior was the same.

Thanks @mikeapp.  Mirador definitely doesn't handle this correctly, I just wasn't sure what "correct" is.
For the sake of not going insane in trying to implement this, Mirador will choose one when there are language codes present, or display all if it is an array of string values.  This seems to handle the majority of use cases and I would argue that there needs to be more information in the manifest about how to present it to the user in a meaningful way if neither of those two scenarios are acceptable.
@mikeapp I will also put in the HTML test, which means that the example manifest will not necessarily render the HTML elements correctly, since it doesn't have the < and > characters, as per @azaroth42's original comment.
@azaroth42 A small clarifying question: does http://iiif.io/api/presentation/2.0/#property-values-in-html assume that there is one root node, as in the example, or is http://manifests.britishart.yale.edu/manifest/1004 also valid, in which there is no root span or p tag and a series of span tags?

The content MUST be well-formed XML and therefore must be wrapped in an element such as p or span.

So yes, there must be a single root element.

I suggest a fast fail then.  Perhaps enforce in Mirador 2.1 that properties which might use html formatting fragments inline be minimally wrapped in a (div?) tag. Anything else gets converted to HTML entities at render time.  And I think it makes sense to limit the allowed tags that are not converted to entities both to ensure layout consistency but also to protect against malicious tags.
-------- Original message --------
From: Rob Sanderson<EMAIL_ADDRESS>Date:03/23/2016 6:25 PM (GMT-05:00)
To: IIIF/mirador<EMAIL_ADDRESS>Cc: "Beaudet, David"<EMAIL_ADDRESS>Subject: Re: [mirador] Incorrect metadata value displayed (#798)
The content MUST be well-formed XML and therefore must be wrapped in an element such as p or span.
So yes, there must be a single root element.
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHubhttps://github.com/IIIF/mirador/issues/798#issuecomment-200567507

Yes, I think these are good ideas @beaudet.  The API does indicate that it should remove malicious tags and provides the ability for the client to clean the HTML how it sees fit.
@aeschylus it feels like the scrubbing should happen in Manifest rather than in MetadataView so it can be done once.  What do you think?


[Feature] Make upload file button clear the file input

Is your feature request related to a problem? Please describe.
When a file is successfully uploaded, the file input is not cleared and the old file persists.
Describe the solution you'd like
When the file is uploaded successfully the file input should be cleared.
Describe alternatives you've considered
N/A
Additional context
N/A

if no one is working on this i am thinking start to working on this.

@GDThumar2409 That would be great - assigning you now :)


Npm purl namespace decode error on dir target

Signed-off-by: houdini91<EMAIL_ADDRESS>Seems that when running on a directory target the NPM purls does not split the namespace correctly.
For example a npm package @aws-sdk/credential-provider-ini version 3.41.0
Dir target:
PURL = pkg:npm/<EMAIL_ADDRESS>Image target
PURL = pkg:npm/<EMAIL_ADDRESS>Ps: i also think the @ included in namespace or name be encoded (%40) if i am not mistaken.

@wagoodman @spiffcs
Hi guys.
I am guessing build fails because main is broken?

@kzantow
Hi i read up on packageurl spec.
https://github.com/package-url/purl-spec/blob/master/PURL-SPECIFICATION.rst
It seems the name should be extracted after the last / .
I think better code would be
	lastSepIndex := strings.LastIndex(p.Name, "/")
	if lastSepIndex != -1 {
		namespace = p.Name[:lastSepIndex]
		name = p.Name[lastSepIndex+1:]
	}

PS: the reason i used fields := strings.SplitN(p.Name, "/", 2) in the current code snippet from /home/mikey/scribe/syft/syft/pkg/npm_package_json_metadata.go but i think it should be changed as well.
Any thoughts?

Hi @kzantow
I read a bit on https://github.com/package-url/purl-spec/blob/master/PURL-SPECIFICATION.rst
It seems the name is found after the last \ in the purl.
Should the npm name be parsed in the same manner?

		lastSepIndex := strings.LastIndex(p.Name, "/")
		if lastSepIndex != -1 {
			namespace = p.Name[:lastSepIndex]
			name = p.Name[lastSepIndex+1:]
		}

Instead of
		fields := strings.SplitN(p.Name, "/", 2)
		if len(fields) > 1 {
			namespace = fields[0]
			name = fields[1]
		}

Any thoughts?

PURL-SPECIFICATION.rst It seems the name is found after the last \ in the purl

By this you mean /, I assume?

Should the npm name be parsed in the same manner?

Yeah, agree with this. Even if there any cases more path segments -- something like @org/something/something, I'd think the @org/something should be treated as the namespace.

After reading the PURL spec a bit more, I think we will always want to try splitting the name to namespace/name as you suggested. I think this is perhaps not the right spot to fix the underlying issue, however -- we should not be encoding these differently and need to figure out why this is happening

Ok i get that, what ever you think is best.
This PR was pushed as a simple patch, your may be right there is a underlining problem that needs fixing else where. (you may close this PR if were going a different route).
Here our my thoughts
This PR tackles how syft splits the NPM name read from the package.json.
I am not sure  why  the  directory and image target use different libraries to  parse the name. but they both should do the same thing  at the very least.
(i am not sure if all package managers names need splitting in the same manner but it is a possibility).
https://github.com/anchore/packageurl-go/pull/4(url) Will mitigate some of the encoding issues but i am not sure what parsing issues may arise when providing problematic  name and namespace  to  NewPackageURL in explicit manner.
For example name including a /.

@houdini91 I'm circling back to this -- is it okay to push a couple updates here?

Of course no problem you may commit .
Do you want me to try and rebase the branch?


More than one material

how can import a mesh include More than one material?

Use different mesh sections, so you can put a different material on each section

Closing as this is for an outdated version of the plugin that's no longer supported.
If you experience this or any other issues in the current version, feel free to report again!
Thanks!


Unhandled error: KeyError: u'USD_OMG'

Welcome to Lending Bot on BITFINEX
2017-08-21 18:47:50 Error USD_OMG
Traceback (most recent call last):
File "lendingbot.py", line 94, in
Lending.lend_all()
File "/home/jcarlos/poloniexlendingbot/modules/Lending.py", line 232, in lend_all
usable_currencies += lend_cur(cur, total_lent, lending_balances, ticker)
File "/home/jcarlos/poloniexlendingbot/modules/Lending.py", line 429, in lend_cur
raise msg
KeyError: u'USD_OMG'
Unhandled error, please open a Github issue so we can fix it!

2017-08-22 12:05:29 Error USD_BCH
Traceback (most recent call last):
File "lendingbot.py", line 94, in
Lending.lend_all()
File "D:\Users\poloniexlendingbot\modules
Lending.py", line 232, in lend_all
usable_currencies += lend_cur(cur, total_lent, lending_balances, ticker)
File "D:\Users\poloniexlendingbot\modules
Lending.py", line 429, in lend_cur
raise msg
KeyError: u'USD_BCH'
Unhandled error, please open a Github issue so we can fix it!

had this also (but happened only once)

I guess is the same error reported on Bug #447

Closing it as it is the same bug as reported by eduardo #447


Issue 4 delete a wishlist

Just took a look at this. You are missing one change: writing a test case for deletion in test_models.py. Please get that done, and we shall merge!

Hi, @MingChieh. Thanks for adding that. Just found another issue in test_routes.py. You seem to be invoking WishlistFactory before proceeding to delete it. However, WishlistFactory will not add the wishlist into the database. It merely returns one with fake data. Instead, you should be looking to call _create_wishlists() and pass 1 as the parameter. That would in turn invoke WishlistFactory.
For reference, please check out the sample-accounts repository.
Please fix that, and we're good to merge!


reserved identifier violation

I would like to point out that identifiers like “_ME_MARKET_H_” and “_RH_SERVER_H_” do not fit to the expected naming convention of the C language standard.
Would you like to adjust your selection for unique names?

Thanks for point this out. I will fix this.

建了一个交易所撮合交流群： 862266237


passphraseServerId appears not to be set (or is different to the default)

Description:
When using the maven-gpg-plugin during publishing of an artifact the action fails with:
[INFO] gpg: Sorry, no terminal at all requested - can't get input
[INFO] [INFO] ------------------------------------------------------------------------
[INFO] [INFO] BUILD FAILURE
[INFO] [INFO] ------------------------------------------------------------------------

I've seen issue #91 and the config snippet is included as listed there and in the project's README.
I had to manually set:
                    <passphraseServerId>gpg.passphrase</passphraseServerId>

Which as far as I understand should be the default.
Task version:
v1
Platform:

[x ] Ubuntu
[ ] macOS
[ ] Windows

Runner type:

[ x] Hosted
[ ] Self-hosted

Repro steps:
Use the plugin like this:
            <plugin>
                <groupId>org.apache.maven.plugins</groupId>
                <artifactId>maven-gpg-plugin</artifactId>
                <version>1.6</version>
                <configuration>
                    <!-- Prevent gpg from using pinentry programs -->
                    <gpgArguments>
                        <arg>--pinentry-mode</arg>
                        <arg>loopback</arg>
                    </gpgArguments>
                </configuration>
                <executions>
                    <execution>
                        <id>sign-artifacts</id>
                        <phase>verify</phase>
                        <goals>
                            <goal>sign</goal>
                        </goals>
                    </execution>
                </executions>
            </plugin>

Notice <passphraseServerId>gpg.passphrase</passphraseServerId> is not included.
In a subsequent step run:
      - name: Publish
        run: |
          git config --global user.email<EMAIL_ADDRESS>          git config --global user.name "Hypi Github Action"
          mvn -e -B -DscmCommentPrefix="[skip ci]" -DpushChanges=false release:prepare && \
          mvn -e -B -DscmCommentPrefix="[skip ci]" -DpushChanges=false release:perform -DlocalCheckout=true

Expected behavior:
mvn release:{prepare,perform} should work without having to set passphraseServerId to the default value.
Actual behavior:
passphraseServerId must be set to gpg.passphrase in pom.xml for the release to succeed.

Hello @zcourts. Could you pease provide some more information about the issue ?

If I understood well, you want to specify passphraseServerId in the settings.xml file to skip it in pom.xml ?
Could you please provide some documentation about setting passphraseServerId in settings.xml file, because we're not experts in gpg plugin and maven publishing. For now I can see examples with setting passphraseServerId in pom.xml.

@dmitry-shibanov I'm experiencing the same, but setting passphraseServerId in the pom.xml (see below) does nothing for me. I keep getting gpg: Sorry, no terminal at all requested - can't get input.
                    <plugin>
                        <artifactId>maven-gpg-plugin</artifactId>
                        <configuration>
                            <passphraseServerId>gpg.passphrase</passphraseServerId> <!-- this can be omitted and the outcome is the same -->
                            <gpgArguments>
                                <arg>--pinentry-mode</arg>
                                <arg>loopback</arg>
                            </gpgArguments>
                        </configuration>
                        <executions>
                            <execution>
                                <id>sign-artifacts</id>
                                <phase>verify</phase>
                                <goals>
                                    <goal>sign</goal>
                                </goals>
                            </execution>
                        </executions>
                    </plugin>

Here's my workflow file:
https://github.com/elasticsoftwarefoundation/elasticactors/blob/71f222dfb7280cec42bd22ee7bea79867fa1d9be/.github/workflows/maven-publish.yml

It also happens with the task tag v2

Update: I think that's because you must set settings-path: ${{ github.workspace }} in the action configuration and then pass --settings $GITHUB_WORKSPACE/settings.xml to maven.
It seems the main use-case for this action (a runner shared by multiple projects) is the one least focused on the documentation.

Apparently you also need to specify the key to be used by maven-gpg-plugin with the keyname configuration.
Personally, I ended up just choosing to use the sign-maven-plugin instead of the maven-gpg-plugin

Hello @zcourts , just gentle ping.
Hello @andrebrait. Documentation was updated, could you please take a look at it. If you see any possible improvements, Could you please tell us about it.

Hello everyone. For now I'm closing the issue. If you have additional information, feel free to reopen it.

This got buried in hundreds of notifications.

Its not that I want to set it but that by default it should have a value I believe of ${gpg.keyname} which means in settings.xml I can set gpg.keyname and have that picked up but for some reason this default variable isn't set when run in this action or it is being set to something else therefore I'm unable to set it in settings.xml
I'm not an expert on the plugin myself, normally I've just configured and used it so this was the first time I had to dig into it  https://maven.apache.org/plugins/maven-gpg-plugin/usage.html describes this parameter though not in any useful detail I suspect.

I don't have access to the project at the moment to remind myself what the final resolution was but I think I just provided that element in the config with the variable. No need to re-open there's a workaround and also the alternative sign-maven-plugin mentioned above

Just in case anyone else stumbles across this discussion looking for an answer to gpg: Sorry, no terminal at all requested - can't get input: in my case the problem simply was an outdated maven-gpg-plugin. The README works perfectly well for me now.


Update dataset drawer to render organism from obs

Need
In conjunction with organism moving from uns to obs in the schema 2.0.0 updates, references to organism values should be pulled from obs rather than config. corpora_props.
Approach

Remove config. corpora_props from infoFormat.tsx.
Review possible other references to config. corpora_props.

Definition of Done

organism value is always rendered from obs.
Singleton organism value is displayed in right side bar.
Non-singleton organism value is displayed in left side bar.

Superseded by #89.


223-text-prediction-updated

223-text-prediction-updated

Is this PR good or are there any changes that I need to make in this case?

Great work @dwipddalal! We need just minor changes. Please commit my suggestions as well as fix the notebook for CI to pass. All tests must be green to merge your PR. Run nbqa on your local machine to check the issues below:  Finally, clear your notebooks outputs by running: jupyter nbconvert --clear-output --inplace 223-text-prediction.ipynb

Sure. I shall resolve them as soon as possible.

We need to pass these 18 test cases, right? If so, then I shall read about them in more detail and try to find the error.

Yes. We must find the cause of these errors and fix it.

@dwipddalal I found and fixed the issue. Other errors are related to external packages and will be fixed in another PR.

It's great to hear that. I shall try to remove the other errors.

Thanks for these changes. We have to merge #619 before this to fix CI issues.

So here, first, we shall merge the pr and then focus on fixing the remaining issues? For merging Ig, we shall first need approval from one more reviewer.

Okay.

If the issue of external packages is solved, then shall I once again push the previous commit?

You don't have to do anything related to external packages. But let's wait for the @ryanloney review.

@dwipddalal please review suggested changes and update the name of the directory and .ipynb to include "gpt2"
223-gpt2-text-prediction 223-gpt2-text-prediction.ipynb

Changed both the file name as well as the folder name.

I am guessing the reason for the failure of two test cases is because of some issues with the external packages?

We don't for now. I'm trying to investigate.

It's great to see that all test cases got passed. Now I shall get good sleep.
I tried a lot to find the exact issue but wasn't able to find one.  I would really like to learn the problem that caused the issue, if it's not trouble for you can you please explain it?

It was a random error of CI.

Thanks a lots @adrianboguszewski and @ryanloney  for your help in improving the quality of the notebook. It feels very good to finally get my PR merged into the main branch.


Add TypeScript type define.

import { Middleware } from "koa";
import * as serve from "webpack-serve";

interface Options {
    title?: string;
    theme?: "default" | "dark" | "material";
    template?: string;
    disableWhenValid?: boolean;
}

function waitPage(wsOptions: serve.Options, options?: Options): Middleware;

export = waitPage;

can pull request?

Sure, go ahead.


Update plugin documentation to use donejs add

Was missed in commit 4016324

Coverage remained the same at 96.262% when pulling 67025aef59f74c23fbd993529943fac1127bff51 on leoj3n:patch-2 into 066465b7dedcb76dee8cb14456147b4c40e99891 on donejs:master.

Thanks!


Aligning behavior with other AWS SDKs

As Rusoto continues to mature and gain users, we should keep in mind how much this project differs from other AWS SDKs.
I'd like to set a high level goal of getting Rusoto closer to how other AWS SDKs behave. There are some differences we can't avoid due to Rust and cargo, but we should be move to match how other AWS SDKs behave as much as feasible.
How do others feel? 😄

I see this as a very practical goal that benefits folks already familiar with aws ecosystem potentially making the transition to rust. The more familiar we can make interacting with aws services feel, the less friction organizations will likely run into when experimenting with rust in an professional setting.
I see two items that challenge that adoption that make rusoto fall below standard expectations for aws SDKs. Both I've worked around both in other crates and projects with rusoto but both likely are leave a betaware first impression on organizations toedipping into rust that don't have the luxury of someone that happens to be familiar with both aws service details and rust at the same time.

default retry strategies. I put this first because robustness is not a optional feature for companies relying on api services to make their business run. These are so we'll integrated with other aws SDKs that most engineers don't have to think about them and that is the point.

auto pagination interfaces. Any list-xxx API is going to incur some amount of boilerplate. In most cases it's is exactly the same boiler plate. Engineers used to interacting with aws SDKs are used to eliding over this boiler plate as quality of life enhancement.

Luckily the information for both of these is available into the metadata used to generate the current interfaces in rusoto.
I took an initial stab at autopagination a while back but got a but stuck on using the botocore descriptions to interrogate responses for pagination tokens in a few corner cases. That's solvable but I know think it would be wise to see what the std lib story for async streams will look like. The futures crate had a nice streams API but now that the std lib is evolving is async story, streams maybe unstable territory.
I'd like to look at retries next. Some work here may be more focused in ironing our weak spots in error deserialization. In most many cases, knowing what can be retired depends on knowing what error is returned.


Open source iohub

At this stage I think iohub repository are mostly meeting our organization's requirements, as well as the general expectations for an early-stage open source project. And I propose that we make this repository public once #46 is merged.
Tagging @mattersoflight @AhmetCanSolak @JoOkuma to see if you have any concerns.

We were ready to continue developing in public, but I can't say we're mostly meeting our organization's requirements yet. I will continue to talk with different teams to start them as early adapters.
Small note to @mattersoflight : Please give everyone more time to put their inputs on repository wide decisions. Maybe we were thinking it is time to go open, but not necessarily everyone involved agreed. As a good practice in async communication, let's give everyone at least a 24h before taking any major actions.  We want to be as inclusive as possible, especially now that we are accepting external contributors.

@AhmetCanSolak certainly. What are the remaining requirements?

I will be making separate issues, like #57


500 internal error on 3.3.0 when going to My account page

Hi,
I have similar problem like #12 with this plugin. When I enable "Enable Event notification plugin." option and then go to My account page, I got 500 error. Setting, version of redmine and log entry:
Redmine version

Plugin settings

Log output
Started GET "/my/account" for <IP_ADDRESS> at 2017-03-13 11:50:42 +0100
Processing by MyController#account as HTML
  Current user: canekpet (id=5)
  Rendered users/_preferences.html.erb (6.7ms)
  Rendered plugins/event_notifications/app/views/my/_general_settings.html.erb (13.1ms)
  Rendered plugins/event_notifications/app/views/users/_mail_notifications.html.erb (16.5ms)
  Rendered plugins/event_notifications/app/views/my/_notification_settings.html.erb (16.8ms)
  Rendered common/_tabs.html.erb (31.1ms)
  Rendered plugins/event_notifications/app/views/my/account.html.erb within layouts/base (37.3ms)
Completed 500 Internal Server Error in 48ms (ActiveRecord: 4.8ms)

ActionView::Template::Error (undefined method `events' for #<Member:0x00000004f4e2b0>):
    20:                   else { $( \".event_#{project.id}\" ).hide();$( \".event_#{project.id} input\" ).prop( \"checked\", false );
    21:                   $( \".event_#{project.id} select option\" ).prop( \"selected\", false ); }" }
    22:
    23:           bool_val = @user.notified_events_projects_ids.include?(project.id)
    24:
    25:           hidden_field_tag( 'user[notified_project_ids][]', "#{value}", :id => "hidden_#{project.id}" ) +
    26:           content_tag('label',
  plugins/event_notifications/lib/event_notification/patches/user_patch.rb:32:in `block in notified_events_projects_ids'
  plugins/event_notifications/lib/event_notification/patches/user_patch.rb:32:in `notified_events_projects_ids'
  plugins/event_notifications/app/views/users/_mail_notifications.html.erb:23:in `block (2 levels) in _plugins_event_notifications_app_views_users__mail_notifications_html_erb___2900193790063002793_105395600'
  app/helpers/application_helper.rb:283:in `block in render_project_nested_lists'
  app/helpers/application_helper.rb:268:in `each'
  app/helpers/application_helper.rb:268:in `render_project_nested_lists'
  plugins/event_notifications/app/views/users/_mail_notifications.html.erb:12:in `block in _plugins_event_notifications_app_views_users__mail_notifications_html_erb___2900193790063002793_105395600'
  plugins/event_notifications/app/views/users/_mail_notifications.html.erb:11:in `_plugins_event_notifications_app_views_users__mail_notifications_html_erb___2900193790063002793_105395600'
  plugins/event_notifications/app/views/my/_notification_settings.html.erb:5:in `_plugins_event_notifications_app_views_my__notification_settings_html_erb___2112214551513180492_105439440'
  app/views/common/_tabs.html.erb:17:in `block in _app_views_common__tabs_html_erb__577076020272278905_91737840'
  app/views/common/_tabs.html.erb:16:in `each'
  app/views/common/_tabs.html.erb:16:in `_app_views_common__tabs_html_erb__577076020272278905_91737840'
  app/helpers/application_helper.rb:325:in `render_tabs'
  plugins/event_notifications/app/views/my/account.html.erb:24:in `block in _plugins_event_notifications_app_views_my_account_html_erb__2362432998187246224_94466000'
  app/helpers/application_helper.rb:1051:in `labelled_form_for'
  plugins/event_notifications/app/views/my/account.html.erb:14:in `_plugins_event_notifications_app_views_my_account_html_erb__2362432998187246224_94466000'
  lib/redmine/sudo_mode.rb:63:in `sudo_mode'

Additional notes
Rest of the plugin seems to work without issue - I can disable notification for specific custom fields - this works.

Hi,
I think you have not executed the migration. This will solve the problem.
Thanks,


Fix the initializer and make global variable specified in word2vector example

Fix the initializer
Make global variable explicitly specified
Original modification in #7872 is not for master.

WARNING:tensorflow:From word2vec_basic.py: initialize_all_variables (from tensorflow.python.ops.variables) is deprecated and will be removed after 2017-03-02.
Original version works for me. The referenced issue is not for current version.

The modification will cause the example arise this warning.

Can one of the admins verify this patch?

I signed it!

@tensorflow-jenkins test this please

Looks like the cmake issue is a tool failure. Since it's a py-only change I feel comfortable merging it. Thanks for the fix!