suggested update:  provide a default constructor

Hello!
I have been working on using your lovely smoothing algorithm as part of a larger Teensy-based project that has its own little library.  As such, I need the ability to use responsiveAnalogRead objects as member variables of a class, which means I need a default constructor that doesn't do anything.  I have a version of your code where I just add in a responsiveAnalogRead() constructor that does nothing, and add in a setup(int pin, bool sleepEnable, float snapMultiplier) function to replace what the constructor was previously doing.  This seems to work just fine.
Right now I have both constructor options, but I suppose a different approach (like how bounce2 is different from bounce) would be to have a second version of the library with a different expected initialization process.  Anyway, we have our own copy of your code with my modifications working fine for our project, but I thought you might want to consider a change along these lines for the 'official' version too.  It makes your library usable in an expanded range of contexts.

I would like to “vote” for this issue, but I suggest renaming it “Provide a default constructor”, for two reasons:
1. The lack of a default constructor doesn't prevent these objects to be class members
You can use the provided constructor in the initialization of your class, within an initializer list:
class MyClass {
    public:
        MyClass(int pin) : analog_read(pin, true) {}
    private:
        ResponsiveAnalogRead analog_read;
};

Although a default constructor would for sure make your life easier.
2. The usefulness of a default constructor goes beyond using the objects as class members
For example, one may want to create an array of such objects to be initialized later, in setup():
ResponsiveAnalogRead analog_reads[ANALOG_INPUT_COUNT];

It would also make the API nicer when using an external ADC. Currently, the README suggests explicitly specifying pin number 0, which works but is kind of weird.
It would also avoid issues such as #8, which notes that, when using an external ADC, “the constructor still needs a pin, and messes with the pin mode.”
By the way, the fact that the constructor messes with the pin mode is still relevant. Ideally, the default constructor should not touch the pin mode. This should be left to a begin() or setPin() method.
As a side note, in Arduino land, the method used to initialize an object is conventionally called begin(), rather than setup().

Renamed - my wording was sloppy in the original issue/request, so thanks for pinning things down much more precisely.  Initially I was not sure if Arduino supported initializer lists or not, since I kept reading that you needed to use begin() functions.  But yes, it does.  However, there can still be issues if the constructor involves hardware configuration calls, like in this case.  And, like you said, there are other reasons to want a default constructor anyway.
I have a forked version in which I implemented the change using setup() instead of begin() but I can easily change the name, to be consistent with Arduino conventions (such as they are).  Pull request maybe on the way?  (I'm a casual git user still feeling out the typical protocol... but I think that's the thing to do??).

Yes, pull requests are the usual way to collaborate in GitHub. Make sure you mention the issue in it. Writing “closes #11” in a commit message would automatically close this issue if the pull request is accepted.

Hi @kschaffer  and @edgar-bonet , really sorry I've missed this one. I've begun rewriting this library as the API of the current one is really quite bad, even if the algorithm in it works ok. The new version will not require any arguments to be passed to the constructor, and likely won't even have any contructor parameters at all. I can keep you updated in this thread if you like.

Thanks for the followup.  I would love to know the general timeline you anticipate.  We're depending on this library for a project that we are hoping to publicly "release" (in an amateur, DIY context of course) this summer.  Temporarily, we've just copy-pasted the code into our own repository to use our own version of it (keeping the license intact).  I was going to switch so that we are using my own forked version of your library as a "submodule," so that there is at least some formal github path back to the original.  A far preferable approach would be to use the "official" version as a submodule, so if it's available I'd love to do that.  I also would be happy to contribute some effort to the API upgrade if you just need some basic changes made.

I went ahead and tried a pull request with this change.  I am still not sure I have that set up right... but I would love if we could get this change implemented ASAP, even if there are going to be more involved upgrades soon.   Working with the Arduino library manager and all, it would be so much cleaner if we can use the "official" library rather than asking users to install a custom version.   This change would make that possible, even while we wait for more extensive changes.

Estimated timeframe would be to have a new version by months end. Your PR looks good, I can adjust the docs and republish to platform.io once I can give it a bit of a go. Actually, considering this is a bit of a stop-gap solution I wouldn't mind overloading the constructor to also accept the old constructor arguments too. That way the existing API will continue to work, and I don't have to bump a major library version to indicate breaking changes have taken place.

Hi @kschaffer and @edgar-bonet , this was pulled in and bumped, and is now available https://platformio.org/lib/show/913/ResponsiveAnalogRead. I'll update the readme soon. Let me know if there is anything else and if not I'll close the issue off.


PHOENIX-6372 Add LICENSE and NOTICE files

Change-Id: I65a2809706172bd36203b9f091b7d40c30f171d3

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
4m 39s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

_ Patch Compile Tests _

+1 :green_heart:
shellcheck
0m  0s
There were no new shellcheck issues.

+1 :green_heart:
shelldocs
0m  0s
There were no new shelldocs issues.

-1 :x:
whitespace
0m  0s
The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

_ Other Tests _

+1 :green_heart:
asflicense
0m 11s
The patch does not generate ASF License warnings.

5m 15s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-48/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix-connectors/pull/48

Optional Tests
dupname asflicense shellcheck shelldocs

uname
Linux 25fcb0cdbbd9 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-connectors-personality.sh

git revision
master / e6f5512

whitespace
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-48/1/artifact/yetus-general-check/output/whitespace-eol.txt

Max. process+thread count
47 (vs. ulimit of 30000)

modules
C: . U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-48/1/console

versions
git=2.7.4 maven=3.3.9 shellcheck=0.7.0

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 33s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

_ Patch Compile Tests _

+1 :green_heart:
shellcheck
0m  0s
There were no new shellcheck issues.

+1 :green_heart:
shelldocs
0m  0s
There were no new shelldocs issues.

-1 :x:
whitespace
0m  0s
The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

_ Other Tests _

+1 :green_heart:
asflicense
0m 12s
The patch does not generate ASF License warnings.

1m  7s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-48/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix-connectors/pull/48

Optional Tests
dupname asflicense shellcheck shelldocs

uname
Linux 2d96a13b7ca9 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-connectors-personality.sh

git revision
master / e6f5512

whitespace
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-48/2/artifact/yetus-general-check/output/whitespace-eol.txt

Max. process+thread count
47 (vs. ulimit of 30000)

modules
C: . U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-48/2/console

versions
git=2.7.4 maven=3.3.9 shellcheck=0.7.0

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


[Websocket] Configure frame size to avoid payload splitting.

Before version 2.5 of okhttp-ws, client was passing a Buffer and it was sent as specified by the client.
On version 2.6, the implementation migrated to use RequestBody and ResponseBody. By doing this all payload sent to server are truncated at 2048 (size of the Segment). If the payload is bigger than 2048, then the implementation sends the remaining data as a continuation frame.
According to RFC, there is nothing wrong by splitting the payload into multiple frames.
But in my opinion this splitting is unnecessary and it should have an option to define the max desired frame size to avoid splitting.

We can probably fix this without much hassle.

Your analysis isn't quite correct.
Given a 10000 byte string:
  @Test public void blah() throws IOException {
    String foo = "";
    for (int i = 0; i < 1000; i++) {
      foo += "1234567890";
    }
    client.sendMessage(RequestBody.create(TEXT, foo));

    System.out.println(client2Server.buffer.readByteString(4).hex());
  }

The header of the first frame is 01fe2000 which says that its length is 8192. The largest multiple of complete segments is taken and emitted in this case. Because of how RequestBody works, we can never know which write is the last one, so additional bytes are buffered. In this case, close is called immediately after which flushes the remaining bytes in another frame.
At most you'll see two frames for the fully-buffered case.
In addition to unifying the buffered and streaming model, this behavior has other benefits such as allowing pings and pongs to interleave without having to wait for potentially slow message sources (like the file system).
As you note, the RFC allows this, and it should be completely transparent to the receiver. Are you experiencing a bug or performance anomaly because of this behavior?

@JakeWharton  You are correct. Initially I tested it using a payload of 2835 bytes, the request was divided in one frame of 2048 and the subsequent frame of 787. After your comment, I experimented increasing the payload size and I could verify that the first frame is a multiple of 2048 (Segment size) and "the remaining" is sent as a separated continuation frame.
In my particular case, I faced an issue on the receiver because I have a proprietary protocol on top WebSocket that expect the full message to be self contained in one frame. So treat this ticket as a feature request instead of a bug.
I disagree with this comment :

Because of how RequestBody works, we can never know which write is the last one

The WebSocket implementation could potentially use RequestBody#contentLength() to identify the last write. In case it returns -1, then your statement is correct. But this can still have the problem of slow message sources as you identified. My suggestion is that we could potentially have setSendBufferSize(int) along the same line of thought as Socket#setSendBufferSize(int)

Ideally we could optimize for the buffered case, but Okio makes it hard. I'm not sure that just a known content length should be enough to trigger buffering since you could easily have a known length from a multi-gigabyte file!
We should figure something out for already-buffered types though for your case. Those where you've used a String, byte[], or ByteString and the data is already in memory. Ideally this would work without the need to hand-customize some size.


Extension methods (WarnFormat, WarnException, etc.) can cause Logger to be called with "null" for a message func.

Every log extension method (to a non-disabled logger) that first does a check results in at least one "null" entry being supplied to the underlying Logger delegate. This is in addition to any real call with an actual message to log. (master @ 437197286dbb280a84e59aaee22130abd7c36044)
For example, extension method calls IsWarnEnabled which is the crux of this unexpected side-effect.
        public static void WarnFormat(this ILog logger, string message, params object[] args)
        {
            if (logger.IsWarnEnabled())
            {
                logger.LogFormat(LogLevel.Warn, message, args);
            }
        }

IsWarnEnabled calls LoggerExecutionWrapper.Log (ILog.Log) with a null message
        public static bool IsWarnEnabled(this ILog logger)
        {
            GuardAgainstNullLogger(logger);
            return logger.Log(LogLevel.Warn, null);
        }

And Log calls the Logger delegate with null when not disabled.
        [SuppressMessage("Microsoft.Design", "CA1031:DoNotCatchGeneralExceptionTypes")]
        public bool Log(LogLevel logLevel, Func<string> messageFunc, Exception exception = null, params object[] formatParameters)
        {
            if (_getIsDisabled())
            {
                return false;
            }
            if (messageFunc == null)
            {
                return _logger(logLevel, null);
            }

My expectation: ILog.Log is only called once per any logging call, regardless of it comes from an extension method.

Hmm yeah agreed that this is unexpected. It's a side effect of fitting everything into the one signature. I'll consider expanding the signature for next version to to separate the logging from checking if it's enabled. I really don't want to expand the signature beyond that.
I would argue, however, that one should to mock ILog and just use in memory concrete implementations. I use serilog in my tests and I pretty much never assert on whether something is logged or not.
I'll leave this open pending the updated signature which I'll line up for NetStandard2.0

Documented guidance here. Basically don't mock ILog, use an in-memory sink instead as previously mentioned.
Am considering changing the signature (via separate issue) still however the guidance would remain the same.


fix: [M3-8730] - Remove @mui/system imports

Description 📝

Believe it or not, this helps the pnpm effort 📦

@mui/system is not in our package.json so we should not be importing it
When we are on pnpm, importing @mui/system will not work so we'll either have to install it or remove usage of it. This PR removes it because it seems to help with our TypeScript performance issues

This should hopefully help TypeScript performance 🏎

Seeing 24 second improvement in Github Actions
Seeing 21 second improvement locally on my Intel MacBook Pro

Preview 📷

Runner
Before
After

Intel MacBook Pro

Github Actions

How to test 🧪

Verify the app still works and looks normal 🎨
Verify TypeScript performance is significantly better 🏎

As an Author I have considered 🤔

[ ] 👀 Doing a self review
[ ] ❔ Our contribution guidelines
[ ] 🤏 Splitting feature into small PRs
[ ] ➕ Adding a changeset
[ ] 🧪 Providing/Improving test coverage
[ ] 🔐 Removing all sensitive information from the code and PR description
[ ] 🚩 Using a feature flag to protect the release
[ ] 👣 Providing comprehensive reproduction steps
[ ] 📑 Providing or updating our documentation
[ ] 🕛 Scheduling a pair reviewing session
[ ] 📱 Providing mobile support
[ ] ♿  Providing accessibility support

Thanks for the clean up and great to see the performance improvements!
Noticing at least one regression in dark mode -- the menu icon renders in the light mode color even when in dark mode:

This Branch
Develop

@hkhalil-akamai Fixed in c79402d
Dark mode was inhereting light theme's color so I just had to add a dark mode color to the dark theme. Also not sure why this PR's changes caused this, but It's likely due to using a different method to merge themes

but It's likely due to using a different method to merge themes

it is - and likely to have a few more regressions. I did try to hunt but we know but nothing jumped so we should be good (we also have a sprint cycle to find more if any)


Not necessary to judge the conditions of inline action.

Inline. Inline is guaranteed to execute with the current transaction or unwind; no notification will be communicated regardless of success or failure.

There is no need to inline transfer to yourself if you are the issuer.


Remove unsupported JDK versions on Travis CI

This should get the build passing again.
See this for background:
https://github.com/travis-ci/travis-ci/issues/7884#issuecomment-308451879

I think this has now been fixed here - https://github.com/mojohaus/appassembler/commit/0e83ade098592ea0f6ecbdf3b246230c84b0882b#diff-354f30a63fb0907d4ad57269548329e3
@khmarbaise perhaps one to close?

Yes I see it the same way. So I close this PR...


REQUEST 02: Small "flexible spaces"

Hi, I'm using FF Beta 61.0b6.
At ShadowFoxCSS... is there a way to change the size of the "flexible spaces" in Nav Bar?
I would like small ones.
If not possible, how can I make "separators" for the Nav Bar?
Thanks in advance!

https://www.reddit.com/r/FirefoxCSS/comments/8kt4k1/nav_bar_small_flexible_spaces_or_separators/
r/FirefoxCSS is a great place to get help with non ShadowFox/dark theme specific questions :)

Thanks @overdodactyl.
I read the Wiki link you posted (thank you!). Sorry I didn't read before. Now I understand how to customize padlock color. However, I still don't know how to have both colors, green for HTTPS, and black for HTTP.
It will be great if you can help me.
Thanks a lot!


Add Figma-Design folder

ADDED DESIGN FILE TO THE FORKED REPOSITORY
NAME: FIGMA-DESIGN
by:@parinitapatil
to:@YuriDevAT

If there are any changed do let me know

Wow, amazing job @parinitapatil . The dark mode looks great 🤩
Could you please add the file with the link to the already existing folder figma inside the public folder?

can you guide me how to do that , I am facing problem in that

i have moved the figma folder to the public . if you want to access the link just click ctrl + click

let me know if there's any problem

Very well done, @parinitapatil. Thank you for contributing to the project 🥳


Updating content owners

FYI @KathleenDollard @karelz @Lxiamail @wadepickett
@mcleblanc you should finally stop getting notifications from our repo. If you still do, please let me know.

What are the rules for merging changes? Does it need to be reviewed by someone from docs team? Or is one of us sufficient?

@karelz I believe they're putting together a training for folks being affected by this change. Usually, one approval from a person with write access is required for you to be able to merge. We usually review each others PRs including self-serve areas like F#. We can add more people to the group with write permissions.


Additional optimization to update() without force_add

This avoids invalidating the flags cache with force_add=False.
This gives a ~10% speed-up on the benchmark test_update_force_add that
updates the key ""a.a.a.a.a.a.a.a.a.a.a" (previous benchmark), and a
~50% speed-up on the new (and faster) benchmark that just updates "a".
This commit also fixes an issue with this benchmark, where re-using the
same config across tests was introducing dependencies between tests.
======================
This is the other optimization I had suggested in https://github.com/omry/omegaconf/pull/665#discussion_r608611363
Note: there is still an issue with this benchmark because the large dictconfig is only created once for each test, and re-used across the multiple calls to the function within benchmark(). As a result both the flags cache and the config itself aren't the same between the first call and subsequent calls.
I tried to play with the pedantic mode (https://pytest-benchmark.readthedocs.io/en/latest/pedantic.html) to have a proper setup always providing the same config as input, but I got very surprising timing results. I wasn't sure if there was an issue with my code, my understanding of the pedantic mode, or if these results were actually correct, so I didn't investigate further at this time.

NB: I rebased and pushed a new version which is simpler (always using our own implementation of nullcontext instead of trying to import the one from Python first). This is because the implementation from CPython is in Python anyway (at least in 3.7), so there's no performance benefit in using it.


Different markup state for empty/no errors validation summary between server and client implementations

I'm not sure why there is a need to render empty list element ('HiddenListItem ') in validation summary tag:
https://github.com/aspnet/Mvc/blob/538cd9c19121f8d3171cbfddd5d842cbb756df3e/src/Microsoft.AspNet.Mvc.ViewFeatures/ViewFeatures/DefaultHtmlGenerator.cs#L26
https://github.com/aspnet/Mvc/blob/538cd9c19121f8d3171cbfddd5d842cbb756df3e/src/Microsoft.AspNet.Mvc.ViewFeatures/ViewFeatures/DefaultHtmlGenerator.cs#L703-L707
When there is no errors the resulting html is:

The client side implementation does not care about elements of the list itself, they are always cleared:
https://github.com/aspnet/jquery-validation-unobtrusive/blob/master/jquery.validate.unobtrusive.js#L58-L70
The reason I noticed this is that screen readers/crawlers see that list, even if empty (empty list just adds noise to markup):

It would be better to just not render that empty element on server:

Just a little detail.
Thanks!

@peterblazejewicz looks like your report is a dupe of #2372. Do you agree?

@dougbu
The #2372 seems to be more general discussion about rendering validaiton summary container, not only its content.
I'm not sure, I just point that rendering empty 'li' is kind of pointless from both server and client side implementation and I think removing it will not have side effects, while clearing rendered markup. Just ''
Thanks!

Hmm, the empty
 element exists to avoid warnings about an empty list (
 in this case) and remain compliant with the HTML 4.01 specification.

Hmm, the empty  element exists to avoid warnings about an empty list ( in this case) and remain compliant with the HTML 4.01 specification.
The data attributes are either not compliant with 4.01 (December 1999)
If older specs are to be supported, then I would opt to close this one and I'll join discussion  to #2372.
Thanks!

The data attributes for validation are either not compliant with 4.01 (December 1999)

I'm curious: In what way are additional attributes non-compliant? The spec doesn't limit the attributes services can include.

I'll join discussion to #2372

You're correct this issue is somewhat separate. Let's leave this open so that I can check w/ others whether the 4.01 spec remains interesting. A few people are out this week.

I'm curious: In what way are additional attributes non-compliant? The spec doesn't limit the attributes services can include.

The validation data attributes won't pass W3C 4.01 validators, just like empty UL tags with 'there is no attribute "DATA-VALMSG-SUMMARY' error

Moving to backlog, we will revisit again next time.

An unwanted side effect is when using a strict  Content-Security-Policy: default-src 'self'; frame-ancestors 'none'; style-src 'self'  causes a security violation due to the inline style rendering.

Closing this issue as there was no community involvement for quite a while now.


rstudio/gt

By Joe Cheng @jcheng5 and Barret Schloerke @schloerke
https://github.com/rstudio/gt
Looks awesome. Definitely deserves a mention in your list, right?

The bulk of work was done by Rich Iannone @rich-iannone, the main author of gt.

Nice job!


Track task action types

Previously we haven't been tracking the types of additional task actions, and thus we could confuse tasks with different actions. This could have lead to loading results for tasks that weren't actually produced by the same actions.
Example
someTask {
    if (System.getenv("CI")) {
        doLast {
            // Do something on CI
        }
    } else {
        doLast {
            // Do something else locally
        }
    }
}

The classloaders of the two actions are the same, and therefore the results produced by on CI would be interchangeable with results produced locally.

Stage 2 coverage is (almost completely) green: https://builds.gradle.org/viewQueued.html?itemId=2943524


orderly message,stop master broker,slave broker did not distribute message

What did i do (The steps to reproduce)?
1.send some messages to broker
2.stop one master broker
3.start orderly consumer
What did i see?
the stoped master broker's slave node did not distribute orderly message to consumer
Please tell us about your environment:
Java: 1.8
RocketMQ: 4.2.0
purpose:
I want upgrade rocketmq from 4.2.0 to 4.5.1
My thought is add 1m&1s 4.5.1 broker,recreate all topic,stop V4.2.0's master broker,consumer pull message from V4.2.0 slave broker,stop slave broker when this broker's all message are consumed
Is there any way to avoid this problem?  Or other better way to accomplish upgrade?

@ticsmtc6 RocketMQ MessageListenerOrderly service does not support consumption from slave server, because this may lead messages to out of order.


Lint entire project with the PHP-Stan Linter

Affected Version
Tested on Branch 4.6
Description
It will be hugely beneficial to fix all the linting errors in framework because that means that all other modules will have significantly less linting errors.
I estimate it will take around ten hours to do framework.  It may seem like a lot but lots of them are caused by each other and in many other cases you can do several at the same time with search and replace.
Obviously what is trickier is

timing
branch
etc...

It might be smarter to do it folder by folder.
Steps to Reproduce

Install: https://github.com/sunnysideup/silverstripe-easy-coding-standards
git clone [framework]
checkout your favourite branch
composer install
sslint-stan src/folderA
sslint-stan src/folderB
etc...

Here are all the errors:
https://gist.github.com/sunnysideup/aa01b7f485f1c95583d0ffd1b9681b05

I am super happy to help with this!

Hey @sunnysideup, thanks so much for proposing this! Yes, we absolutely want SilverStripe code to be clean, easy to read, and well documented. We've been aiming for PSR-12 compliance as our coding standard, which is relatively un-opinionated. There has also been discussion around implementing PHPStan.
I had a quick skim read of your gist (again, thanks for putting this together). Errors like "Left side of && is always true." and "Negated boolean expression is always true" may be fixed in any release branch as a bug fix, since it's fixing/simplifying logic. As for whether we'd want to introduce them into our CI toolchain or ongoing processes, we probably need to discuss that at an individual rule level.
Regardless of that, contributions to implement the majority of your detected errors would be greatly appreciated. I would be careful of changing any method signatures/breaking any APIs in the process though.

What branch would I use?
I could maybe do one folder and get some feedback.

That sounds like a good idea! The 4 branch is probably best. Thanks in advance!

I've marked this as an enhancement, but will not consider it a feature request since @sunnysideup is actively planning to implement it 😄

I will help, but I am only keen to do it if I get active support to make it happen.  Sometimes I feel that this can be a bit of a moving target ... if you just do this, we will include it.

I am just experimenting here: https://github.com/silverstripe/silverstripe-framework/pull/9624.  I am using the src/Control folder as experiment.  Let me know how close we are to good enough.

Can someone please check the pull request above and let me know if that is good enough.

Please also review: https://github.com/silverstripe/silverstripe-framework/pull/9625 and let me know if / what linting rules are unacceptable.

PS: are you familiar with #9103, #7899?

see: https://github.com/silverstripe/silverstripe-versioned-admin/pull/202


ESP32-S2 USB CDC not recognized from another device (IDFGH-6014)

Hello,
Development Kit: ESP32-S2-Saola
Module or chip used: ESP32-S2-WROOM
Build System: idf.py
Compiler version: xtensa-esp32s2-elf-gcc
Operating System: Windows 10
Using an IDE?:  I use the TinyUSB drivers. I tested the USB connection through a terminal with the examples tusb_console, tusb_sample_descriptor, tusb_serial_device and they work.
I'm working in a project on MPLAB where there is a USB communication between the ESP32 and a PIC32MX250F256H.
In particular, the ESP32 is configured as CDC USB device and must be plugged into the USB port of the PIC32 to start the communication.
On the other hand the PIC32 should recognize it before communicate.
I'm encountering some problems due to the recognition of my ESP32-S2 as CDC device when I plug it into a USB port of the PIC32.
I think that the problem is due to the Class, Subclass and Protocol settings.
In fact I noticed when I plug the ESP's USB into my PC it's recognized as USB Serial Port with the values:

Class = 0x02
Subclass = 0x02
Protocol= 0x00

When I connect the ESP to the Microchip microcontroller, it detects the ESP with the following values:

Class = 0x0A
Subclass = 0x00
Protocol= 0x00

After that the PIC32MX quits the communication because it doesn't recognize it in the right way.
However I have another CDC device (it's not an ESP32) that works perfectly with this MCU, it has Class = 0x02, Subclass = 0x02, Protocol= 0x01.
Where could be the problem?
Is there a way to change the CDC parameters (class, etc...) of my ESP32-S2?
Regards,
Filippo

Thanks for reporting, you could raise a post on our forum at https://esp32.com


Create unswapescape

Restore caps/escape swap to default.

First things first, CapsLock behavior is not appreciated much less needed.
So, if you feel that you need it (which is probably never), the following describes how to restore it:
In the file ~/dotfiles/_config/openbox/autostart,
67  ## Swap CapsLock to Escape
68 setxkbmap -option caps:swapescape

Comment line 68 and restart, to restore CapsLock / Esc behavior.


fix bug with not showing value of dropdown.

Repro scenario:  1) select value from typeahead
2) select value from dropdown

due to conflicts with other pull request.  I have made this change separately as suggested.


Copying individual sketch from forum adds shape to the map, but not the sketch name to the Sketching tab.

If I copy an individual shape that belongs to a collection in a forum, the shape appears on the map but the name of the shape is not added to the Sketching tab. I have to "hide" the orphaned shape. This same problem does not apply to copying entire collections which appears to work just fine.

This should be fixed. Please reopen if you see again.


Microservices architecture doesn't map to one particular Azure service

The decision tree mentions that if you have a Microservice architecture it is recommended to use a Web Service. This is not necessarily true and statements like these are causing a lot of confusion around Microservices. Microservices, by definition, are a set of services/components, the decision which Azure service (or technology stack) to use should be evaluated based on the needs of each these services/components separately.
I believe the statement could be more accurate if it says:
"Web/API" app? > Use Azure App Service. (similar to the statement to the left on the same decision tree).
Thank you.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f4ad3f0b-32fa-bdf7-d0b3-0e8b8c31ea0d
Version Independent ID: 9a686ba2-a4ea-0dba-c1f5-003e9824a0ee
Content: Review your compute options - Cloud Adoption Framework
Content Source: docs/ready/considerations/compute-options.md
Service: cloud-adoption-framework
Sub-service: ready
GitHub Login: @BrianBlanchard
Microsoft Alias: brblanch

Thanks for reporting - this issue is under review. This is a Microsoft Internal DevOps Bug ID # 429276

I no longer see the issue being raised here. Microservices is no longer in the decision tree. It must have been updated already. I'm closing.


Build html

Enables GitHub workflow to build static HTML and push to latestHTML branch upon merge into master branch. In order for this to work, 2 secrets need to be set:

ACCESS_TOKEN - with write privileges to the repo.
PUBLISH_URL - with URL to trigger pull of latestHTML by remote server to publish.

@ttzeng This PR is in response to program decision to move to publish static HTML rather than through Drupal. Someone with read/merge privileges will need to set up the two secrets above. The first one can be done right away. The second will have to wait until we get the URL when the server is ready.


Deploy system failing: error creating s3 buckets

Describe the bug
Deploy system e2e test has started failing: https://github.com/civiform/cloud-deploy-infra/actions/runs/4793326028/jobs/8525670681 (2 failures so far):
│ Error: error creating S3 bucket ACL for e2e-test-civiform-fileaccesslogs: AccessControlListNotSupported: The bucket does not allow ACLs
│ 	status code: 400, request id: QN21FH24E9GV312Q, host id: NShM8QrPExs/yiUBuOqim4Qy/Y/LgIZA5fKQ8QpWzvOaQ2GYsqX/j1HHSjIDEJj73nvISmP3LIdYlAgvmeRA9BfJDE5TL03e
│
│   with aws_s3_bucket_acl.log_bucket_acl,
│   on filestorage.tf line 94, in resource "aws_s3_bucket_acl" "log_bucket_acl":
│   94: resource "aws_s3_bucket_acl" "log_bucket_acl" {
│
╵
╷
│ Error: error creating S3 bucket ACL for e2e-test-civiform-lb-logs-yxutzwj: AccessControlListNotSupported: The bucket does not allow ACLs
│ 	status code: 400, request id: GEY5SVW7WBYWTYTR, host id: Ytf/TN8EAt2eA41Qho2gYSYVj7QJZZKCpK5wVU86l+r/mAT72Dr+dHiRfECGEGcx/8dlEUlyjIY=
│
│   with module.ecs_fargate_service.module.ecs-alb[0].module.lb_logs_s3[0].aws_s3_bucket_acl.logs,
│   on .terraform/modules/ecs_fargate_service.ecs-alb.lb_logs_s3/main.tf line 26, in resource "aws_s3_bucket_acl" "logs":
│   26: resource "aws_s3_bucket_acl" "logs" {

Still failing, there were no changes to our code in the time this started failing. It may be the result of this AWS change: https://docs.aws.amazon.com/AmazonS3/latest/userguide/about-object-ownership.html

Fixing upstream TF module: https://github.com/cn-terraform/terraform-aws-logs-s3-bucket/pull/14


Add chunkWhile

The chunkWhile method breaks the collection into multiple, smaller
collections based on the evaluation of the given function.

It was added in Laravel 8.x (https://laravel.com/docs/8.x/collections#method-chunkwhile)

This should be on develop branch, right? Or should I open the PR onmaster?

Hey, @sohaibalam67
Thanks for the contributing!
Please have a look at takeWhile and skipWhile and try to apply some of the same logic.

Hey @ecrmnn
I saw takeWhile and skipWhile before implementing this. The logic is different. My implementation is similar to how it is done in Laravel. If you see the spec, this might make sense.

Closing due to inactivity


RSS Changes

Pull Request Test Coverage Report for Build 5d0fa69180496760600ae71c635f29ebed2ddb7a
Details

28 of 43 (65.12%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.3%) to 70.633%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/literature/controllers/rss_controller.ex
24
29
82.76%

lib/literature/migrations/postgres/v08.ex
0
10
0.0%

Totals

Change from base Build 80e7b64fb81c8cf07908afa2b42ddee1ca428fc8:
-0.3%

Covered Lines:
1306

Relevant Lines:
1849

💛  - Coveralls

Pull Request Test Coverage Report for Build 5d0fa69180496760600ae71c635f29ebed2ddb7a
Details

28 of 43 (65.12%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.3%) to 70.633%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/literature/controllers/rss_controller.ex
24
29
82.76%

lib/literature/migrations/postgres/v08.ex
0
10
0.0%

Totals

Change from base Build 80e7b64fb81c8cf07908afa2b42ddee1ca428fc8:
-0.3%

Covered Lines:
1306

Relevant Lines:
1849

💛  - Coveralls


chore(carbon): updating dependencies across packages

Refs #4372
Description
Updating Carbon dependencies.
Changelog
Changed

Carbon dependencies version to React, Styles, Web-components, Services-store, and utilities.

@guilhermelMoraes can you update the snapshot files?

@oliviaflory @wonilsuhibm can you review this change that Percy picked up? I approved the other upstream changes which looked ok to me.

https://percy.io/538fc19a/Carbon-Expressive-Theme/builds/7578601?utm_campaign=538fc19a&utm_content=Carbon-Expressive-Theme&utm_source=github_status_public


Added size option for EKRatingSymbolsContainerView

Goals 🥅
Be able to set a custom size for the Rating Symbol Container View.
For example: if you want to show more than 5 stars in a row, now you can set the Rating Symbol Container View to 30 px (width and height).
Implementation Details ✏
Just adding a size (CGSize) var in EKRatingItemContent and then updating the size in EKRatingSymbolsContainerView.

Thanks for your PR!


[FR] make long press timeout duration customizable

Right now the long press timeout is set to 400ms.
I always felt like something was weird about its behavior and i always was getting unwanted longpress.
Maybe one of 2 things:

wrongly recognized long press. Does a touch move cancel a long press?
too short timeout.

Whatever it is it would be good to be able to customize it.
On android the default is set to 500ms.

Thinking about this and playing with the sdk there is something i dont get. Setting setClickTypeDetection(false) make single click type detection instant. The reason why it is not instant with setClickTypeDetection(true) is because of double click, right? it has nothing to do with longpress ?
I mean in my mind long press gesture should not influence single click detection as it happens on touch up. So i am starting to think, could we have a way to disable double click? should nt it be disabled by default?

I think you are into something here, the click detection functionality likely needs an overhaul. I will look into this post 4.4.0 release.

@mtehver this is fixed in latest version i can customize long click. This PR https://github.com/CartoDB/mobile-sdk/pull/445 add the final touch and allows me to customize double click

Available in 4.4.1. Closing.


Remove snapshot repository

I don't see a snapshot repo declared in the build config for this repo, so I don't think there's any action to take.


support username and password defined in settings.xml

Resolves #256

Hi @jomu78, is there any update on this pr? #266 seems to refer to this very same feature. Thank you!

@cstettler : I have made some changes like mentioned above but I have troubles to get the stuff into a proper unit test. I have tested using the doc project using both Linux and Windows.

Thank you @jomu78, I will have a look the changes asap and will see whether we can add the feature to the integration test suite.

Integration of this PR happens via branch pr/jomu78/encrypted-username-password-in-settings. Thank you @jomu78  for your contribution!


Do Not Remove Outline On Keyboard Focus

Do not remove the outline on buttons when they gain keyboard focus.  This is an accessibility issue since the outline aids users navigating sites with only their keyboard.
Consider using a tool like what-input if you'd like to remove the outline for mouse users while keeping the outline for keyboard users:
https://github.com/ten1seven/what-input

Probably its not a good idea to add JS dependency(what-input) to a CSS library, So, Now library doesn't override outline by default, but in case you want to disable outlines, a helper class(bttn-remove-outline) is added to remove all outlines on a button.

Can I close the issue?

@ganapativs yes, that's a decent compromise, I think.  I appreciate the new accessibility toggle! I would maybe argue that the toggle should be on by default, but I won't harp on it.  Thank you for your work!


Insights not generated for osfanbuff63/discord-bot

Insights were not being generated for one of the workflows in osfanbuff63/discord-bot : https://github.com/osfanbuff63/discord-bot/blob/master/.github/workflows/ci.yml
The issue has been resolved now. Insights URL for latest run:
https://app.stepsecurity.io/github/osfanbuff63/discord-bot/actions/runs/2840505125
@osfanbuff63 - FYI, I observed insights were not being generated for one of your workflows. Have resolved the bug. Should work for future workflow runs.

Closing issue. Feel free to re-open if you see this issue again.

Thanks! I saw that reports hadn't been generated yet, but it was right after the workflow ran and decided to wait, and then I forgot about it so I never thought to report it :P

No problem. Please let me know if you have any suggestions for improving harden-runner. Thanks!


Add Agentic-RAG notebooks with LlamaIndex

TODO

[ ] add gradio demo

no idea why CI failed on Llama_index import, cuz it works fine with my clean environment.

@OpenVINO-dev-contest which python version do you use for testing? I have suspicious that some of packages can be non available for python3.8 (deprecated version, some packages already exclude it from supported)
Could you please try to add it into ignored for python3.8 only?

@OpenVINO-dev-contest which python version do you use for testing? I have suspicious that some of packages can be non available for python3.8 (deprecated version, some packages already exclude it from supported)
Could you please try to add it into ignored for python3.8 only?

Python 3.11


Create FIG announcement on ffiec.cfpb.gov

Update announcement on the HMDA homepage to include the 2020 FIG & quarterly filers guide.
Message: On September 25th, 2019, the Bureau released the 2020 FIG and the Supplemental Guide for Quarterly Filers.

Closed by 28066c4


Use of deprecated service: set_charger_circuit_dynamic_limit

Question

Use of deprecated service: set_charger_circuit_dynamic_limit
This stops working in version 2023.1.0. Please address before upgrading.
I use this service for controlling charging of my Easee Charger... as I understand this message, the service will stop working... so whats the best/supported way of controlling the charing of the Easee Charger going forward?
What version of the integration are you using?
v0.9.46 and HA 2022.10.5
Anything in the logs that might be useful for us?
No response
Additional information
No response

I thought the messare was crystal clear 😉
Please see the last sentence.


Document RenderObject._relayoutBoundary and its invariant; small refactors

Fixes part of #150524.
Recently I was studying RenderObject and related code to understand
how the rendering library tracks which objects need layout, and in
particular just how the concept of "relayout boundary" works.
The [RenderObject._relayoutBoundary] property itself had no docs,
and there were some other areas that I felt could be clearer;
so here's a PR where I add those docs.
In addition to docs, this makes some small pure refactors.  Mostly
those are in order to make clear docs easier to write.  One rename
is to fix a lone straggler from #4425 / #4483.
One key thing I learned, which this documents, is an invariant that
this code maintains on [_relayoutBoundary].  With that invariant in
mind, I found it's possible to simplify that bookkeeping, and to get a
measurable performance improvement as a bonus.  To keep things simple,
though, I'll leave those for follow-up PRs.
For ease of review, the PR is broken into several commits each with
their own commit message.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is test-exempt.
[x] I followed the breaking change policy and added Data Driven Fixes where supported.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Thanks for the review! I just bumped my request for that exemption.

Thanks @LongCatIsLooong for the review! Replied to subthreads above, and pushed a change based on your feedback; PTAL.

However to me it feels a lot easier to think of relayout boudaries as special nodes in the tree that qualify for certain optimizations (i.e. from markNeedsLayout's perspective) rather than a set of invariants that need to be maintained by each node in the render tree (from layout's perspective).

Yeah, I think both of these perspectives are helpful.
The "what are they for" perspective (special nodes that qualify for certain optimizations) is important for thinking about how they should work and how markNeedsLayout should handle them. (And I added a paragraph about that in my changes just now.)
The "what are key facts that are exactly true about how they currently work" (aka invariants) perspective is one I found important when trying to refactor, and to optimize, how they work (#150524). It helps a lot for making sure I haven't missed something — and for noticing when I have, and need to rework something. I also find it helpful even when trying to fully understand the code that works with this data, because these invariants were often important background assumptions in how the code was written.

(Merged from main to pull in #150707 to fix tests.)

test-exempt: code refactor with no semantic change


new API, add get_welcome event

Codecov Report

Merging #152 into master will decrease coverage by 0.07%.
The diff coverage is 90.9%.

@@            Coverage Diff            @@
##           master    #152      +/-   ##
=========================================
- Coverage   88.28%   88.2%   -0.08%
=========================================
  Files          40      40
  Lines        4480    4484       +4
  Branches      546     549       +3
=========================================
  Hits         3955    3955
- Misses        447     449       +2
- Partials       78      80       +2

Impacted Files
Coverage Δ

src/wormhole/cli/cmd_receive.py
85.97% <100%> (+0.79%)
:arrow_up:

src/wormhole/cli/welcome.py
100% <100%> (ø)
:arrow_up:

src/wormhole/_boss.py
100% <100%> (ø)
:arrow_up:

src/wormhole/xfer_util.py
65.45% <83.33%> (ø)
:arrow_up:

src/wormhole/wormhole.py
96.07% <87.87%> (-2.91%)
:arrow_down:

src/wormhole/cli/cmd_send.py
81.16% <88.88%> (+0.08%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d19b585...652c46a. Read the comment docs.


Html is not support

Type: Feature Request
HTML coding is not work
VS Code version: Code 1.74.2 (e8a3071ea4344d9d48ef8a4df2c097372b0c5161, 2022-12-20T10:29:14.590Z)
OS version: Windows_NT x64 10.0.22621
Modes:
Sandboxed: No

Hi @shivsharanyadav9516  This issue is related to VS Code, please file it in https://github.com/microsoft/vscode/issues


[Transparency] Adds statistics support

Closes #10.

:+1: if green

@zamith integration specs are missing

@naps62 Added.

:+1:


[11.x] fix: Model newCollection generics; feat: add HasCollection trait

Hello!
This PR fixes some issues with the Model's newCollection generic (https://github.com/phpstan/phpstan/issues/11354) ---it appears that due to covariant/invariant constraints the method must return only static models.
I also added a HasCollection trait similar to the Has{Builder,Factory} traits that help slim down the models:
// before
class Post extends Model
{
    /** @return PostCollection<array-key, static> */
    public function newCollection(array $models = []): PostCollection
    {
        return new PostCollection($models);
    }
}

// after
class Post extends Model
{
    /** @use HasCollection<PostCollection<array-key, static>> */
    use HasCollection;

    protected static string $collection = PostCollection::class;
}

Thanks!

Looking at your code, you add a trait, but then you aren't doing anything with the trait, it has zero effect, the newCollection is still in Model.

The trait is for use in user land when a custom collection class is used as it better helps with generics/autocomplete/ide support, however, I suppose we could add the trait to the base model like this:
https://phpstan.org/r/0c35c490-55a1-48fa-b407-d58ae52cb499

The trait is for use in user land when a custom collection class is used as it better helps with generics/autocomplete/ide support

if it is just for that, it doesn't slim down anything. I suggest either remove the trait or move generic logic into that trait. leaving Model as was.

The trait is still not doing anything except for extending the original newCollection method. The trait should not have to be part of Model by default. by default Model uses the default Collection class. But only when adding that trait, one should be able to set a specific Collection classname. No code changes in Model, just a new trait.

Thanks @taylorotwell!


[Bash] Use * instead of @ to concatenate

As proposed by static analysis tool:
https://github.com/koalaman/shellcheck/wiki/SC2124

Can one of the admins verify this patch?

Closing these all out. Mind making all these changes in one pull request? It's easier to run through tests that way.


GraphTheory added with Djikstra O(nlogn) implementation

In case you missed them, other changes are still pending. Please read the review above.

Anything else?


Empty context object - using controllerAs syntax

Documentation isn't very clear on how to use or what actually gets bound to the context object.
I'm using controllerAs syntax with ng-model. The input values are being attached to the scope but the context object is still empty.
My goal is to validate that the inputs are not empty.
Edit: Also validation function (in canexit) fires twice.
Edit2: canexit function doesn't fire with wz-finish directive

You set whatever you would like for values in the context object.  For example, lets say step 1 has an exit validation and your step two has an enter validation like so:

    <wizard on-finish="finishedWizard()">
        <wz-step title="Starting" canexit="ctrl.exitValidation">

This is the first step

Here you can use whatever you want. You can use other directives, binding, etc.

            <input type="submit" wz-next value="Continue" />
        </wz-step>
        <wz-step title="Continuing" canenter="enterValidation">

Continuing

You have continued here!

            <input type="submit" wz-next value="Finish Now" />
        </wz-step>

//in your controller
this.exitValidation = function(){
    //where string 'John' is you can insert your ng-model the field is attached to, or anything else
    WizardHandler.wizard().context.firstName = "John";
    return true;
};
this.enterValidation = function(context){
    return context.firstName === "John";
};
```

That is a pretty stripped down example but should give you the idea.  You can set the context object at anytime you'd like `WizardHandler.wizard().context[yourKey] = yourValue` and access it at each exit or enter function via the first argument of that function.

Let me know if that makes sense.

Oh I have to set it explicitly. Thought context grabbed the scope object.

No it needs to be set explicitly, I will try and make this more clear in the documentation.
Thank you.

Is there a way to bind to context directly from template?

I would have to test in some things but you could set it equal to $scope (or this)

TBH I don't really see a point to the context object since the directive isn't using an isolate scope. Its basically just another scope but with less functionality.

It's there as an option, you don't have to use it if you prefer another method.  Thanks for your input


New-RsRestSession Basic Parsing

Do you want to request a feature or report a bug?
bug
What is the current behavior?
When creating a session using New-RsRestSession on an On-Premise Windows server I am receiving the below error:
2021-02-01T17:15:00.0808162Z Failed to create a new session to http://myserver/Reports/api/v2.0/me :  2021-02-01T17:15:00.0810847Z The response content cannot be parsed because the Internet Explorer engine is  2021-02-01T17:15:00.0815552Z not available, or Internet Explorer's first-launch configuration is not  2021-02-01T17:15:00.0817407Z complete. Specify the UseBasicParsing parameter and try again.  2021-02-01T17:15:00.0818562Z At C:\Program Files\WindowsPowerShell\Modules\ReportingServicesTools\<IP_ADDRESS>\Fu 2021-02-01T17:15:00.0822203Z nctions\Utilities\New-RsRestSession.ps1:125 char:9 2021-02-01T17:15:00.0825513Z +         throw (New-Object System.Exception("Failed to create a new se ... 2021-02-01T17:15:00.0828739Z +         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 2021-02-01T17:15:00.0832139Z     + CategoryInfo          : OperationStopped: (:) [], Exception 2021-02-01T17:15:00.0835170Z     + FullyQualifiedErrorId : Failed to create a new session to http://myserver/Reports/api/v2.0/me : The response content cannot be parsed because   2021-02-01T17:15:00.0841804Z    the Internet Explorer engine is not available, or Internet Explorer's fir    2021-02-01T17:15:00.0844339Z  st-launch configuration is not complete. Specify the UseBasicParsing param     2021-02-01T17:15:00.0847080Z eter and try again.
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.
I am invoking my script using a DevOps Release Pipeline using an On-Premise Agent.
The server/user calling the code would have an Internet Explorer configuration that was not set
Calling-code would include the below snippet:
$ReportPortalUri = 'http://myserver/Reports' New-RsRestSession -ReportPortalUri $ReportPortalUri
What is the expected behavior?
A session would be created successfully.
Which versions of Powershell and which OS are affected by this issue? Did this work in previous versions of our scripts?
PS Version: 5.1.14393.3866
OS: MS Windows Server 2016 Standard 10.0.14393 Build 14393
I believe the issue is due to I.E. setup not occurring however I have been unable to get the IE setup to stick on that user (it works when I run locally but not when the Agent runs it). Having the ability to pass the argument -UseBasicParsing that is enabled for the Invoke-WebRequest Function would fix this issue  I believe.

Update: I did find a work-around to this by changing the group policy on the server.
Local Group Policy Editor\Administrative Templates\Windows Components\Internet Explorer
Enable Prevent running First Run wizard:

I experienced this issue as well. Must be another Invoke-WebRequest without -UseBasicParsing that snuck in somewhere. A work-around I found was applying the info from here https://www.geoffchappell.com/notes/windows/ie/firstrun.htm and/or here https://souldodotnet.wordpress.com/2015/11/07/internet-explorer-disable-first-run/
I added something quick and dirty (needs cleanup I'm sure) like this inline in my wrapper script:

$IERegPath = 'HKLM:\Software\Policies\Microsoft\Internet Explorer\Main'
$IERegName = "DisableFirstRunCustomize"
$IERegValue = 1
$IERegCurrent = Get-ItemProperty -Path "${IERegPath}" -Name 'DisableFirstRunCustomize' -ErrorAction SilentlyContinue
$IERegCurrentValue = $IERegCurrent.DisableFirstRunCustomize
if (${IERegCurrentValue} -ne $IERegValue) {
    If (-NOT (Test-Path $IERegPath)) {
        New-Item -Path $IERegPath -Force | Out-Null
    }
    New-ItemProperty -Path $IERegPath -Name $IERegName -Value $IERegValue -PropertyType DWORD -Force
}

Perhaps that could help you in the meantime. 😄


[FormBuilderDateTimePicker] Not reset value when form reset is called

formKey.currentState!.reset();

This behaviour can be achieved via setting the value null of DateTime field manually
formKey.currentState!.fields["organizedOn"]?.didChange(null);

This still an issue?

The reset button on the right-hand side of the FormBuilderDateTimePicker also doesn't work.
The onReset callback is not triggered.

I saw FormBuilderDropdown has an allowClear property.
When the reset button of FormBuilderDropdown is pressed, the hint is shown.
In FormBuilderDateTimePicker, we have the hintText in decoration, but it will never shown.
FormBuilderDateTimePicker(
        name:'name',
        inputType: InputType.date,
        initialDate: DateTime.now(),
        firstDate: DateTime(1900, 1, 1),
        lastDate: DateTime.now(),
        decoration: InputDecoration(
          labelText: title,
          hintText: hint,
        ),
        onChanged: (v){},
      ),

FormBuilderDropdown(
        name:'name',
        decoration: InputDecoration(
          labelText: title,
        ),
        // initialValue: 'Male',
        allowClear: true,
        hint: hint == null ? null : Text(hint!),
        items: [
          DropdownMenuItem(
            value: 1,
            child: Text('1'),
          ),
        ],
        onChanged: (v){},
      ),

The initial issue reported by @VickyBOSS, currently works successful.
In this video can see the behavior
https://user-images.githubusercontent.com/21011641/181862851-3b7b64c8-7812-43a8-b97b-4ccf6b197b01.mp4
I close this issue

I'm a little late, but I discovered that the documentation is somewhat outdated. with the following change suffixIcon will work.


Bug: [CURLRequest] Multiple HTTP 100 return by API

PHP Version
8.1
CodeIgniter4 Version
4.4.2
CodeIgniter4 Installation Method
Composer (using codeigniter4/appstarter)
Which operating systems have you tested for this bug?
Windows, Linux
Which server did you use?
apache
Database
No response
What happened?
When I call API built with a Flask server, this one return these headers:
HTTP/1.1 100 Continue
HTTP/1.1 100 Continue
HTTP/1.1 500 INTERNAL SERVER ERROR
Server: Werkzeug/2.2.3 Python/3.7.16
Date: Tue, 19 Dec 2023 21:30:20 GMT
Content-Type: application/json
Content-Length: 403
Access-Control-Allow-Origin: *
Connection: close
In this case the CURLRequest class doesn't parse correctlly the headers
Steps to Reproduce
Make POST API with Flask 2.2.5 in debug mode and call it via CURLRequest
Expected Output
In this case status code should be 500 not 100
Anything else?
Just change this:
        if (strpos($output, 'HTTP/1.1 100 Continue') === 0) {

By this:
        while (strpos($output, 'HTTP/1.1 100 Continue' . $breakString) === 0) {

at line 392
For others who have the problem, actually I overwrite the class and specially the function send in my project and instanciate it via this function in Config\Service:
public static function curlrequest($options = [], ResponseInterface $response = null, App $config = null, $getShared = false) {
    if ($getShared) {
        return static::getSharedInstance('curlrequest');
    }

    if(empty($config)) {
        $config = config(App::class);
    }
    return new CURLRequest($config, new URI((empty($options['baseURI']) ? null : $options['baseURI'])), $response, $options);
 }

Your fix makes an existing test fail.
How about this?
--- a/system/HTTP/CURLRequest.php
+++ b/system/HTTP/CURLRequest.php
@@ -389,7 +389,7 @@ class CURLRequest extends OutgoingRequest
         // Set the string we want to break our response from
         $breakString = "\r\n\r\n";

-        if (strpos($output, 'HTTP/1.1 100 Continue') === 0) {
+        while (strpos($output, 'HTTP/1.1 100 Continue') === 0) {
             $output = substr($output, strpos($output, $breakString) + 4);
         }

Off topic, I have prepared the reproduction code and set up the server.
But how can I obtain the header information?
HTTP/1.1 100 Continue

HTTP/1.1 100 Continue

HTTP/1.1 500 INTERNAL SERVER ERROR
Server: Werkzeug/2.2.3 Python/3.7.16
Date: Tue, 19 Dec 2023 21:30:20 GMT
Content-Type: application/json
Content-Length: 403
Access-Control-Allow-Origin: *
Connection: close

$ curl -v https://codeigniter.com

@kenjis I've reproduced the issue and the change can work.
I sent the PR #8466

@ping-yee Great!

Ok thanks ! In my case the flask call another api, maybe it's the way to reproduce


Roll Flutter Engine from 280491d4cc21 to d21355297bb3 (4 revisions)

https://github.com/flutter/engine/compare/280491d4cc21...d21355297bb3
2023-06-19<EMAIL_ADDRESS>Roll Skia from d182b694a670 to c90c7dec5c18 (1 revision) (flutter/engine#42979)
2023-06-19<EMAIL_ADDRESS>Roll Dart SDK from b2ec326cc4f3 to 3d07173415e8 (1 revision) (flutter/engine#42978)
2023-06-19<EMAIL_ADDRESS>Roll Skia from 24f2336d87f2 to d182b694a670 (2 revisions) (flutter/engine#42977)
2023-06-19<EMAIL_ADDRESS>Roll Fuchsia Mac SDK from BuzniDS9u_hdghV5f... to gX0QkT_dMBCTbiAHY... (flutter/engine#42976)
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from BuzniDS9u_hd to gX0QkT_dMBCT
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


feat(ref): add ref methods and add hideAvatarFlatList prop

I have added the ability to hide the Avatar Flat List property, because users may want to use a custom block with Avatar buttons.
Also, I have added an opportunity to open and close stories using ref methods.

@caglardurmus


Flatten the tabs to two levels

Currently the menu has three tiers of tabs:

Top level CMS areas
Primary Area Items (3 used by the module)
CSP Specific tabs (4, 3 and 1 depending on the above)

Merge this so either we use the Primary Area Items or CSP Specific tabs as a more SPA based tool.

Merged into develop.


Add @type to secondary section

Without @type developers can not getting started
as web site says.
http://docs.fluentd.org/articles/install-by-gem

Thx!

😍

If secondary plugin type is same with primary's one, @type in <secondary> section can be skipped.
It's default behavior of v0.12 version.

I reverted this patch at #1034.

OK, I see. Thank you for your fix commit about secondary type :)


incorrect path escaping

Given route:
get(paths[String]) { p: Seq[String] =>
      Ok(p.toString)
}

GET /../secret prints "List(secret)"
but
GET /%2E%2E/secret prints "List(.., secret)"
and
GET /%2F/etc/passwd prints "List(/, etc, passwd)"
This can be nasty for unsuspecting people serving files from local disk
finch version:0.22.0

Thanks for the ticket, @scf37!
What happens in version 0.25? Also, which output you think it should yield?


how to close guides？How to not display the guidance process for the second time？

how to close guides？How to not display the guidance process for the second time？

hi @FairyWorld .

how to close guides

Set flag allowUserToCloseModal to true.
The user can then click outside of the modal (ie in the black region) to close the modal.

Please note that (from experience), allowing the user to close the modal will decrease the home screen installation rate.

How to not display the guidance process for the second time？

Ive just added a new flag maxModalDisplayCount .  you can set this to 1 to show the modal at most once, 2 to show the modal at most 2 times, etc
Note again that this will decrease the home screen installation rate.
Thank you.


Allow to override network

This PR provides the ability to override --network argument for the application, proxy and accessory.
Closes #1006.

@djmb I rebased this PR


feat(integration): Create integration package

PR Checklist
Please check if your PR fulfills the following requirements:

[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

In this PR http tests are broken!!!
P.S. In next version we introduce new http package


Delete cache entries only on the workflow branch

I've noticed that the post-action step which automatically cleans up old cache entries accidentally cleans up entries created on other branches. This reduces performance with multiple PRs are being developed concurrently especially in the scenario where a PR deletes the cache entry for the main branch resulting in all new PRs having cache misses until a PR has been merged.
This PR updates the handle_caches.jl script to only delete caches which match the restore key using the same git ref as the executing workflow. This should result in workflows run on the main branch only deleting cache entries on main and PRs only deleting cache entries for that PR.
For more details about cache isolation in regards to branches see: https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows#restrictions-for-accessing-a-cache

I'll hold off on merging until I triple check the non-fork version is working. Also, this may be a nicer way to detect a fork: https://github.com/orgs/community/discussions/25217#discussioncomment-3246904

I think this fixes #98.
Probably good to add 1.0 CI as these actions should probably work back to there, if possible.

I think this fixes #98.
Probably good to add 1.0 CI as these actions should probably work back to there, if possible.

I'll save this for another PR as there are a few additional changes required to get this to work


First go at adding a Test project.

I created updated the project references, created a test project, and added some tests.
Aggragate, Count, Filter, and Foldl have tests.
Count fails while the others pass.

Merged.
This is very good work. Thank you for your contribution.


responseObject is not defined

When following blog article, implementing movies test, responseObject and responseBody are defined in the beforeEach function, but test fails with error, that responseObject is not defined.

in second step, when using the fixtures movies.json test succeeds then


Getting started

Hey, I saw this on Twitter and you caught my attention with the support for fsl and fsy files.
I want to give this a try but I'm pretty clueless when it comes to neovim 😅.
How do I install this plugin?

Nice, figured it out using https://jdhao.github.io/2018/11/15/neovim_configuration_windows/.
This looks amazing!


❓ [Question]: Hi there, got this error hook_attention_weights related to whisper_timestamped. How to fix?

Your Question
I tried running short content automation
line 763, in hook_attention_weights
if w.shape[-2] > 1:
^^^^^^^

Hi there, solve this by downgraded openai-whisper to pip install openai-whisper==20231117


[BUG - Palworld UE4SS v3.0.1 Save Error]

Branch or Release
UE4SS v3.0.1
Game and Engine Version
Palworld / Unreal Engine 4
Describe the bug
Please forgive me ahead of time, I am not an experienced programmer or modder. But I have hosted dedicated servers before on a machine I built myself, so I have some knowledge of these things but nothing compared to what you guys do. I also had some help generating this report so I didn't mess anything up too badly:
Summary:
When using UE4SS to inject mods into Palworld, progress is completely reset upon logging into the game. After extensive testing and configuration adjustments, the issue appears to be rooted in UE4SS’s core interactions with the game rather than specific mods or runtime settings.

Issue Overview:

Problem: Installing UE4SS results in a full progress reset in Palworld. Reverting to a server backup and removing UE4SS allows progress to load normally.
Game: Palworld
UE4SS Version: 3.0.1
UE Version: 5.1

Steps Taken:
Initial Diagnostics:

Installed UE4SS as per documentation, including updated settings and ensuring no outdated files (e.g., xinput1_3.dll) were present.
Verified compatibility with Palworld’s UE version (5.1).
Tested with various mods enabled and disabled.

Testing Process:

Reverted to a pre-UE4SS server backup to ensure a clean test environment.
Logged in without UE4SS to confirm progress loaded correctly.
Installed UE4SS and tested login. Progress reset occurred.
Iterated multiple configurations and tests (see Configuration Changes below).

Configuration Changes:

Disabled All Mods:

Confirmed issue occurs with no mods loaded by editing mods.txt to disable all entries.

Disabled All Hooks:

Adjusted UE4SS-settings.ini to set all hooks to 0 under [Hooks].
Example:HookProcessInternal = 0
HookProcessLocalScriptFunction = 0
HookInitGameState = 0
HookBeginPlay = 0

Disabled Cache:

Set UseCache = 0 and bUseUObjectArrayCache = false to minimize interference.

Minimized Multithreading:

Reduced threads used for signature scanning:SigScannerNumThreads = 1

Enabled Debugging:

Activated external console and full memory dumps for detailed logs.

Observed Behavior:

Without UE4SS: Progress loads normally.
With UE4SS (regardless of mods or hooks): Progress resets completely.
Logs show no errors or warnings directly related to saving or loading progress.

Files and Logs:

Configuration:

UE4SS-settings.ini (final tested version provided).

Logs:

Multiple logs showing UE4SS initialization and runtime behavior (provided).

Save Files:

Save files before and after UE4SS injection show no discernible differences, suggesting the reset occurs during runtime rather than file alteration.

Conclusions:

Root Cause: Likely a compatibility issue between UE4SS’s core engine modifications and Palworld’s save/load system. Palworld may implement save protections or validation mechanisms that conflict with UE4SS.
Eliminated Factors:

Mods, hooks, caching, and multithreading were ruled out as direct causes.

Request for Assistance:
We request the UE4SS community’s assistance in diagnosing and resolving this issue. Specifically:

Compatibility Insights:

Are there known issues with Palworld or similar UE5.1 games?
Are there specific AOB configurations or custom settings that could resolve this?

Potential Workarounds:

Suggestions for disabling or bypassing game-level save validation.

Experimental Features:

Could any recent experimental builds address this issue?

Relevant Documentation and Links:

Installation Guide: UE4SS Installation Guide
Compatibility Fixing: UE4SS Compatibility Guide
Logs and Save Files: Attached.

Thank you in advance for your time and assistance. Let us know if additional data or testing is required!
Screenshots, UE4SS Log, and .dmp file
If applicable, add screenshots to help explain your problem, and upload the log and .dmp files located in the Win64 directory.
Desktop (please complete the following information):

OS: Win 11

Additional context
Add any other context about the problem here.
UE4SS (4).log

The GUI/Console also doesn't work so I cannot provide the dump files.

Same problem here.


cancellation_at or cancellation_date?

Venice::InAppReceipt defines cancellation_at, but I can't find anywhere in the source that sets the data from JSON. Shouldn't it really be cancellation_date?

Ah, #31

Fixed in #31.

Thanks! 👍


Standard Completions aren't ideal for chat agents

I'll just leave this here:
[17] pry(main)> agent.run(question: "hi")
I, [2023-08-09T18:00:53.352403 #626398]  INFO -- : [LangChain.rb] [Langchain::Agent::ReActAgent]: Sending the prompt to the Langchain::LLM::OpenAI LLM
=> "No answer."

😢
Would chat completion for agents be on the roadmap?

Yep, we already have the capability to pursue a conversation (in fact I'm using my own framework for that), but what I'm looking for from Langchain is the ability to use agents for a conversation, so using a Chat endpoint within an Agent interaction is key.

@merefield I think a good approach would be to create a new type of agent, like ConversationalAgent, and use Langchain::ConversationMemory within this class in order to combine persisted messages and use of tools.

Any plans to support tools in conversations soon?

@mengqing Take a look at the Langchain::Assistant class: https://github.com/andreibondarev/langchainrb?tab=readme-ov-file#assistants. It can use tools in conversations.


perf: garbage-collect dead sections

Benchmarks: https://github.com/leanprover/lean4/pull/1689#issuecomment-1268175703

Very interesting, so -dead_strip on linking lake is sufficient to break it. That sounds straightforward enough that one could isolate the failure and report it to LLVM if one was sufficiently motivated...


Unable to restore 1wallet

Hi! I tried to restore my 1wallet after a long time. I tried to import my recovery file and I got the QR code, but after that it asks me to provide old authenticator codes. Unfortunately, I don't have this code in my authenticator app. Is there a way to recover my wallet without the old authenticator code? Thank you!

Hello @adix1141
If you don't have the old authenticator codes, it might be hard to recover your wallet. I'd suggest reaching out to the support team for help.the ticket ID WAL07638
Please see the link below to our dedicated support line:
Onewallet Network DApps Support Ticket Requests.
Click on the live chat icon at the bottom corner of the page to initiate chat with a live support agent.

Hello @adix1141
This will be review by the support team. Visit the live support page to initiate a chat with an agent for further assistance via live agent.
Regards

@adix1141 Dear user
I understand that you have been experiencing some issues and I want to ensure you get the support you need as quickly as possible by using our live chat option.
Support : Support
1.	Access the Live Chat:
•	Navigate to our website’s home page.
•	Look for the chat icon located at the bottom right corner of the screen and start a 💬.


[Feature Request] Allow access to cookie value from other domains

Insomnia Version: 5.16.6
Operating System: Windows 10 64-bit

Details
Currently, there is no way to use a cookie value from a different domain. You are only able to use cookies from the URL of your request.
One of our applications uses javascript from the site with the cookie and provides a different backend service with these cookie values via a header.

I was playing with the plugin system and it would be very beneficial if there was a Cookies model I could add or use. I notice theres a cookie jar but to my knowledge there will only ever be one?

I ended up with a quick non production ready plugin for the mean time.
https://gist.git.labs.bankozarks.com/preston/78a89df1afd0b63b14938298f6d7292e

Hmm, that is quite an interesting use case! I think it should definitely be supported.
I don't have access to view the link you provided, so forgive me if this is the same thing that you did, but it would probably be easy to add an override url parameter to the existing Request => Cookie tag that you provided a screenshot of.
Although, I agree that it would probably also be good to expose some sort of cookie API for plugins to use.

@gschier I have made the gist public.

I still get stuck here

@gschier I have updated the link to the github gist. Sorry about that.
I like the idea of adding it to the request plugin but the verbaige on the plugin description is a little weird since it says current request.

Ya, it would be kind of a "hack" to add it to the current request plugin, now that you mention it.
Yes! I like the Gist you sent. I think an external cookie jar tag makes a lot more sense. I'll add one tomorrow and get it into the next release.


Add job for ocp-power-automation/ocp4-upi-powervm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mkumatag
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

config/jobs/ocp-automation/OWNERS [mkumatag]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/cc @sudeeshjohn

/lgtm

@mkumatag: Updated the job-config configmap in namespace prow at cluster default using the following files:

key ocp4-upi-powervm-presubmit.yaml using file config/jobs/ocp-automation/ocp4-upi-powervm/ocp4-upi-powervm-presubmit.yaml

In response to this:

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


use morfeus to calculate ligand descriptors

Also, offload all the calculated descriptors into a csv file to provide options for loading rather than recalculating.


Extract standalone "iree-tf-import" tool.

Step 1/n of refactoring Python bindings to be based on a pure executable dep for TensorFlow interop.
All tests pass except Vulkan (no GPU on this VM).

Sean - you already reviewed this internally. Just rebased external and merged with incoming changes (lots of renames).


react-sticky for fixed/sticky header not working

I want to use react-sticky to create my header and footer component.
App.js:
class App extends React.Component {
        render() {
            return (

                    <SomeContent />

            );
        }
}

Header.js:
class Header extends React.Component {
    render() {
        return(
            <StickyContainer>
                <Sticky>

Header

                </Sticky>
            </StickyContainer>
        );
    }
}

SomeContent.js:
class SomeContent extends React.Component {
    render() {
        var style = {
            width: '100%',
            height: '1500px',
            border: '1px solid red'
        }
        return(

Lorem

        );
    }
}

The page is displaying App.js including both Header and SomeContent. However if I scroll down, the Header is not sticky/fixed in its position. It moves up like any normal div. Where am I missing? Please help me. Thank you.

In App.js, make the outermost div a StickyContainer instead and it should start to work. A StickyContainer is the area in which a Sticky element becomes fixed

I had the same issue, and @dbarbalato solution solved my problem. Thanks man!

@dbarbalato you the man!


chore: Drop support for Python 3.6

Python 3.6 support ended on 2021-12-23
In order to keep all dependencies updated is needed to drop support of this version in the repository
Ref: https://cordada.aha.io/features/COMPCLDATA-123

Codecov Report
Base: 69.93% // Head: 69.93% // No change to project coverage :thumbsup:

Coverage data is based on head (94b786c) compared to base (8190bb0).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #179   +/-   ##
========================================
  Coverage    69.93%   69.93%
========================================
  Files            9        9
  Lines          296      296
  Branches        37       37
========================================
  Hits           207      207
  Misses          82       82
  Partials         7        7

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Multilanguage not working

Laravel Version: 5.5.*
Voyager Version:1.0.7
PHP Version:
Database Driver & Version:

Description:
I just installed a fresh Laravel with Voyager. Once all is well and i can enter to /admin, i change:
  'multilingual' => [
        /*
         * Set whether or not the multilingual is supported by the BREAD input.
         */
        'enabled' => true,

        /*
         * Select default language
         */
        'default' => 'fr',

        /*
         * Select languages that are supported.
         */
        'locales' => [
            'en','fr',
            //'pt',
        ],
    ],

But the dashboard and pages remains in english
Steps To Reproduce:
Install Laravel with Voyager
Change multilingual in voyager.php

a little precison when i go in english file in published/lang directory and i delete all the file voyager still work fine

Try
config/app.php
return [
    ...
    'locale' => 'fr',
    ....
];

Solution provided here and on Slack


gpu memory

Some modules are dispatched on the CPU or the disk. Make sure you have enough GPU RAM to fit the quantized model. If you want to dispatch the model on the CPU or the disk while keeping these modules in 32-bit, you need to set load_in_8bit_fp32_cpu_offload=True and pass a custom device_map to from_pretrained. Check https://huggingface.co/docs/transformers/main/en/main_classes/quantization#offload-between-cpu-and-gpu for more details.
这个项目需要多少显存能跑的起来？

12G

这个项目需要多少显存能跑的起来？


Publish on conda-forge?

ISSUE TYPE

Feature Idea

SUMMARY
Hi, since ansible is already available on conda-forge, I was wondering whether this package could also be published within conda-forge.
Ref.:

https://anaconda.org/conda-forge/ansible
https://github.com/conda-forge/ansible-feedstock

Raise it against ansible-dev-tools project so we can track it there. Also post some links regarding what it would require from us and how new versions are published there.


README: document debug instance destroy() method

Related to #678, this PR adds a new section "Destroying a debug instance" in the README explaining that dynamically created debug instances must be destroyed in order to avoid a memory leak.
It also does a minor/cosmetic cleanup in the README file.

Coverage remained the same at 87.692% when pulling 36c24c4268685ab9e74fe6096ba14b61c07ab7e3 on ibc:master into 3f4d7247c0f57085c3d8450593b22ecd7ef73886 on visionmedia:master.

Coverage remained the same at 87.692% when pulling 36c24c4268685ab9e74fe6096ba14b61c07ab7e3 on ibc:master into 3f4d7247c0f57085c3d8450593b22ecd7ef73886 on visionmedia:master.

No thanks. #678 is a bug. The readme shouldn't document how to workaround bugs.


Tag 6.6.6 causes confusion

Describe the bug
Tag 6.6.6 exists, but there are newer releases with lower version numbers.
When adding the library as a dependency, you're given this older version by default; see screenshot below.
You need to go dig out the version range in this repo to add the dependency properly. This is undocumented, unexpected, and involves guessing.
SDK Version
N/A
To Reproduce
Add the package https://github.com/WalletConnect/WalletConnectSwiftV2 as a dependency in Xcode.
Expected behavior
You get the newest release by default.
Screenshots

Device (please complete the following information):
N/A
Additional context
N/A

May be was created for some debug purposes. deleted


URL redirect to https

Hi, I see when completing the SAML authentication it redirects to http://<IP_ADDRESS>:35001. Is it possible to redirect it to https://<IP_ADDRESS>:35001?
Thanks!!

In my case I created a new server that uses openvpn under the hood. I wanted to upgrade it to https to add a security layer when authenticating. About the certificate I’m using mkcert to do so, the issue now is that AWS redirects to http. I tried to change the ACS to use https without success.

@sant123 sorry, i still can't get why you think that "https will increase security". We are using HTTP for the localhost URL, only to capture SAML reply and sent it back to AWS as part of OpenVPN auth flow.

For example in public wifi networks like the airport the traffic will not be encrypted. Using https the redirect URL to the SAML entity and the redirect when authentication is success all that data will be hard to decode. That’s why https sounds good to me for this use case.

@sant123 traffic to localhost never leaves your laptop, no matter if its public wifi or whatever else :-/

But the callback from the SAML entity it’s calling localhost with http. The contents in there are not encrypted, so in some way data can be exposed @samm-git don’t you think?
My question is how that can be setup? because the bash file uses ACS::35001 as password but did not find where to specify the protocol. Unless it’s not supported /:

no, it cant be exposed, as only local traffic on specific machines is using HTTP, all traffic which goes over network uses https.

I know the issue is closed, first thanks for this effort.
Regarding:

@sant123 traffic to localhost never leaves your laptop, no matter if its public wifi or whatever else :-/

The issue is not that we care if it is https or http when invoking web request to a localhost callback, the issue is that some of the SAML provider (in this case Google Workspace) does not allow ACS URL to be plain text to begin with, hence we are not able to use Google workspace identities as VPN single singon.
This should be addressed by AWS, on searching I noticed your repo and thought this might have a chance to work with google workspace.
I will try to change the http go lang package to use https to see if that can workout.

@s-ifti my assumption that it would work (and btw, will not be with the official client :)) But for sure it would complain about an untrusted key, however, chrome will allow to override that.
I think problem here is on google side. Using SAML/OIDC with http://localhost:xxxx is common approach for the local authentication, and google should do an exception here IMO.


Add a Rate Us Page

Hello Project Admin
My name is A.A.D.Sailaja. I am a Tech Enthusiastic and i'm looking forward to contribute in open source projects. Here in this project i would like to add a rate us option it will allow the user to rate our website and also he can suggest us to improve if any
Can you please assign me this issue under GSSOC'24 @Abidsyed25

@sailaja-adapa ok

@Abidsyed25 Thank you


Move resolve (and lints) into AST conversion code

This simplifies the AST since we only need variable IDs after resolving, and should make the compiler a bit faster. The lints will be able to react to syntactical properties (so we can lint against code style, etc.).

Resolve is now part of AST conversion, but I'd like to move check.rs there as well. Lints aren't yet moved.


keyword argument for client.configure

Let client.configure use the keyword arguments. Just like the usage of configuration in readme file at line 111.

Nice one, thank you.


Prefix flex-box containers

Prefix flex-box containers ....

The added dependency (react-prefixer) on prefixes 'display' and 'transition', and has only 5 stars. I'd be more comfortable if you added the prefixed CSS properties directly in the style object and removed the dependency.

Any updates on this one?

Not yet found a perfect solution for using flex with inline style property..
Found this package, but Github Repo is GONE.
https://www.npmjs.com/package/react-flex

@fzaninotto
Maybe we can just rely material-ui to do the auto-prefixing?

And<EMAIL_ADDRESS>seems working perfectly for both older and newer versions of Firefox.
https://github.com/callemall/material-ui/pull/5931

Excellent! Since this adds a new dependency, can you PR against the next branch (due to be released next week) instead of the master branch?

Sure, created a PR against the next branch #296


Compare results male v female

Sue would like a comaprison page of male versus female. Ideally the users could choose to compare any two sets of results.

M/F page added.


Notifications for missing elements

Hi,
I was using some elements in my application and noticed that there is no notification when I haven't imported a specific element (thus the entire look of the page looked different from what I expected).
Now I understand that the browser simply ignores the tags that it doesn't recognize but isn't there anyway to notify the user about missing imports?

Closing this issue due to age and the release of version 1 of Polymer - please feel free to re-open if this is incorrect.


propose HIPE: JSON-LD compatibility

Signed-off-by: Daniel Hardman<EMAIL_ADDRESS>

@dhh1128 I think as a community we should chat about what we formally rename the A2A protocol to, personally i think Didcomms is too broad as there could be a variety of different ways two dids could communicate, my preference would be to qualify it further to something like DidMessaging or an even  less general term


Update UpSet to version with scoped css

Fixes #101.

This seems to work properly, but should we independently reapply the style that made the examples listing look better?

Perhaps, but I feel that's a completely separate issue. It was messing with table striping and who knows what else that we would not want to reproduce. I think what's listed in #101 would make it look like it did before, although knowing what was visited may be worth keeping - new examples light up.

Ok. Let's leave it as is for now, then. We may want to just style it independently in any case, which we could do in a separate (low priority) issue.
This PR LGTM.


Work In Progress: Opt-in filename based versioning

Initial concept for re-introducing filename versioning for cache busting.
I am not completely comfortable with where certain things are implemented. I think I'd like to see the logic for version hashing + renaming of files in the CustomTasksPlugin.applyVersioning() instead of inside the Manifest itself.
@JeffreyWay the one question I have from you is: how should people opt-into this? Currently, it can be triggered by putting Config.versionInFilename = true; in the webpack.mix.js file.  Thoughts on that?
EDIT:
In the mean time, adding this plugin should provide the needed support:
https://www.npmjs.com/package/laravel-mix-filename-versioning
code at:
https://github.com/ralphschindler/laravel-mix-filename-versioning

bump @JeffreyWay I am available if you want to converse about this strategy :)

Sorry for the delay in responding. I'd rather keep any additional versioning techniques as a plugin. So what you have is perfect already.


Decrease memory usage in tile_matrix

In the tile_matrix(h, w, mat) function in ordered.jl, the line return repeat(mat, repeat_rows, repeat_cols)[1:h, 1:w] # trim to image dims  is using twice the memory actually required for the returned matrix -- 'repeat' is creating one image in memory, and [1:h, 1:w] appears to be creating a 2nd image in memory. When the [1:h, 1:w] at the end of the line is removed, memory usage drops to half, and mean run time drops by 60%.
A 2nd possible issue is the argument order for this function. If a bang version was created, then the arguments should be (mat, h, w) instead of (h, w, mat).
Below is a listing that covers both of these issues. Aside from using less memory, it has about 20% less median run time.  I couldn't hit the 60% reduction; repeat's codebase is considerably faster than mine, but is also considerably more convoluted. I could not follow it.
`function tile_matrix(mat, h, w)
new = Vector{eltype(mat)}(undef, h*w)
new = reshape(new, h, w)
h_mat, w_mat = size(mat)
for i = 1:w_mat, j = 1:h_mat
	new[j:h_mat:h, i:w_mat:w] .= mat[j,i]
end
return new

end`

Hi Tinkerer-Zlosk,
thanks for your issue! I also took a stab at reducing the allocations:
using BenchmarkTools
using DitherPunk: bayer_matrix

# tile_matrix from 0.2.4
function tile_matrix1(mat, h, w)
    h_mat, w_mat = size(mat)
    repeat_rows = ceil(Int, h / h_mat)
    repeat_cols = ceil(Int, w / w_mat)
    return repeat(mat, repeat_rows, repeat_cols)[1:h, 1:w] # trim to image dims
end

# tile_matrix from 0.2.4 using view
function tile_matrix2(mat, h, w)
    h_mat, w_mat = size(mat)
    repeat_rows = ceil(Int, h / h_mat)
    repeat_cols = ceil(Int, w / w_mat)
    return view(repeat(mat, repeat_rows, repeat_cols), 1:h, 1:w) # trim to image dims
end

# Tinkerer-Zlosk's suggestion
function tile_matrix3(mat, h, w)
    new = Vector{eltype(mat)}(undef, h*w)
    new = reshape(new, h, w)
    h_mat, w_mat = size(mat)

    for i = 1:w_mat, j = 1:h_mat
        new[j:h_mat:h, i:w_mat:w] .= mat[j,i]
    end
    return new
end

# Matrix to be tiled
level = 2
bayer = bayer_matrix(level)
mat = bayer//(2^(2 * level + 2)) # 8×8 Matrix

# Output size
h = 1080
w = 1920

tile_matrix2, the modification of the original with view seems to be the most performant:
julia> @benchmark tile_matrix1(mat, h, w)

BenchmarkTools.Trial:
  memory estimate:  63.28 MiB
  allocs estimate:  4
  --------------
  minimum time:     9.060 ms (0.00% GC)
  median time:      13.206 ms (29.23% GC)
  mean time:        13.626 ms (30.88% GC)
  maximum time:     87.738 ms (87.42% GC)
  --------------
  samples:          367
  evals/sample:     1

julia> @benchmark tile_matrix2(mat, h, w)

BenchmarkTools.Trial:
  memory estimate:  31.64 MiB
  allocs estimate:  3
  --------------
  minimum time:     3.958 ms (0.00% GC)
  median time:      4.873 ms (0.00% GC)
  mean time:        6.200 ms (34.02% GC)
  maximum time:     84.604 ms (93.99% GC)
  --------------
  samples:          805
  evals/sample:     1

julia> @benchmark tile_matrix3(mat, h, w)

BenchmarkTools.Trial:
  memory estimate:  31.64 MiB
  allocs estimate:  4
  --------------
  minimum time:     9.581 ms (0.00% GC)
  median time:      11.371 ms (0.00% GC)
  mean time:        12.339 ms (19.60% GC)
  maximum time:     88.076 ms (86.99% GC)
  --------------
  samples:          405
  evals/sample:     1

I can't believe that I didn't try 'view'! I'm glad you found a better fix
than mine.
Paul (aka Zlosk)
On Wed, May 5, 2021 at 1:28 PM Adrian Hill @.***> wrote:

Hi Tinkerer-Zlosk,
thanks for your issue! I also took a stab at reducing the allocations:
using BenchmarkTools
using DitherPunk: bayer_matrix
tile_matrix from 0.2.4
function tile_matrix1(mat, h, w)
h_mat, w_mat = size(mat)

repeat_rows = ceil(Int, h / h_mat)

repeat_cols = ceil(Int, w / w_mat)

return repeat(mat, repeat_rows, repeat_cols)[1:h, 1:w] # trim to image dims

end
tile_matrix from 0.2.4 using view
function tile_matrix2(mat, h, w)
h_mat, w_mat = size(mat)

repeat_rows = ceil(Int, h / h_mat)

repeat_cols = ceil(Int, w / w_mat)

return view(repeat(mat, repeat_rows, repeat_cols), 1:h, 1:w) # trim to image dims

end
Tinkerer-Zlosk's suggestion
function tile_matrix3(mat, h, w)
new = Vector{eltype(mat)}(undef, h*w)

new = reshape(new, h, w)

h_mat, w_mat = size(mat)

for i = 1:w_mat, j = 1:h_mat

    new[j:h_mat:h, i:w_mat:w] .= mat[j,i]

end

return new

end
Matrix to be tiled
level = 2
bayer = bayer_matrix(level)
mat = bayer//(2^(2 * level + 2)) # 8×8 Matrix
Output size
h = 1080
w = 1920
tile_matrix2, the modification of the original with view seems to be the
most performant:
julia> @benchmark tile_matrix1(mat, h, w)
BenchmarkTools.Trial:
memory estimate:  63.28 MiB
allocs estimate:  4

minimum time:     9.060 ms (0.00% GC)
median time:      13.206 ms (29.23% GC)
mean time:        13.626 ms (30.88% GC)
maximum time:     87.738 ms (87.42% GC)

samples:          367
evals/sample:     1
julia> @benchmark tile_matrix2(mat, h, w)
BenchmarkTools.Trial:
memory estimate:  31.64 MiB
allocs estimate:  3

minimum time:     3.958 ms (0.00% GC)
median time:      4.873 ms (0.00% GC)
mean time:        6.200 ms (34.02% GC)
maximum time:     84.604 ms (93.99% GC)

samples:          805
evals/sample:     1
julia> @benchmark tile_matrix3(mat, h, w)
BenchmarkTools.Trial:
memory estimate:  31.64 MiB
allocs estimate:  4

minimum time:     9.581 ms (0.00% GC)
median time:      11.371 ms (0.00% GC)
mean time:        12.339 ms (19.60% GC)
maximum time:     88.076 ms (86.99% GC)

samples:          405
evals/sample:     1
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/adrhill/DitherPunk.jl/issues/8#issuecomment-832908785,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AT5HSM62JR6JJJZ5P23ZRP3TMGEF5ANCNFSM44B5ET2A
.


Adding InkCanvas component at runtime

Dear amazing inkPainter developper,
I would like to congratulate you on your amazing asset. For my project, I'm importing house at runtime and I wanted to use you asset to paint the walls of the imported 3D model. Unfortunately adding the inkCanvas component with AddComponent<> does not work at runtime because of the custom editor (paintSet object was null). So i added in the "Awake" function the following method base on your code :
private void CreateRuntimeProperty()
{
            Renderer renderer;
            Material[] materials;
            List<bool> `foldOut;`
            var instance = this;
            instance.paintSet = new List<PaintSet>();

            renderer = instance.GetComponent<Renderer>();
            materials = renderer.sharedMaterials;
            foldOut = new List<bool>();

            if (instance.paintSet.Count < materials.Length)
            {
                for (int i = instance.paintSet.Count; i < materials.Length; ++i)
                    instance.paintSet.Add(new PaintSet
                    {
                        mainTextureName = "_MainTex",
                        normalTextureName = "_BumpMap",
                        heightTextureName = "_ParallaxMap",
                        useMainPaint = true,
                        useNormalPaint = false,
                        useHeightPaint = false,
                    });
                foldOut.Clear();
            }

            if (instance.paintSet.Count > materials.Length)
            {
                instance.paintSet.RemoveRange(materials.Length, instance.paintSet.Count - materials.Length);
                foldOut.Clear();
            }

            if (foldOut.Count < instance.paintSet.Count)
                for (int i = foldOut.Count; i < instance.paintSet.Count; ++i)
                    foldOut.Add(true);
}

Thank you for your report.
InkCanvas does not support adding with AddComponent, but it can be added to the runtime with AddInkCanvas method instead.
https://github.com/EsProgram/InkPainter/blob/master/Assets/InkPainter/Script/Extenision/GameObjectExtension.cs