Error Handling for websocket

express provide default error handler and also user add user-defined error handler
such as below form.
function errorHandler(err, req, res, next) {
}
but, if error is occurred during processing web socket req/res
this error can not handled by  express error handler
so, i wondering that how to handle error for websocket?

Wondering the same.

Hi guys,
Thanks a lot for the feedback. I'm sorry that this library currently doesn't play nicely with the standard error handling in express. Fixing this shouldn't require too much effort, so I'll try to get it done before the end of this week.

Thanks, @HenningM! Any updates? If not, do you have any pointers as to how to get it done? Alas, I have been unsuccessful with domains. But if you can recommend something, I could try to get a PR in.

Hi again @arik-so,
Still haven't found time to implement a fix for this. I haven't dug into the details yet, but I have a feeling that this is related to how middlewares are wrapped here: https://github.com/HenningM/express-ws/blob/master/src/wrap-middleware.js#L1.

I appear to witness an immediate Error: socket hang up when I try to connect to a fresh server using express-ws.  I haven't figured out if this is actually express-ws or something else.  Will this ticket address catching that type of socket error?  Or is there something else I can do right now?  (I expected server.on('error', ...) to address this, but so far no luck.)

@HenningM I've created a very simple pull-request that will help if someone accidentally makes a type-o in WS middleware or similar.

The mentioned PR was released with version 3.0.0. Thanks a lot, @kraenhansen!


KAFKA-15373: fix exception thrown in Admin#describeTopics for unknown ID

Throw UnknownTopicIdException instead of InvalidTopicException when no name is found for the topic ID.
Similar to #6124 for describeTopics using a topic name. MockAdminClient already makes use of UnknownTopicIdException for this case.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Hi @jolshan , please take a look at this PR to modify the exception thrown when describing a topic by an unknown topic ID. The CI failures don't appear related to the change.

At first I was confused since the original PR had https://github.com/apache/kafka/blob/2a5fbf28820ddcde5ead605e070391059d5d2e18/core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala#L200
but on closer inspection (the debugger) I see that the future is actually InvalidTopicException and that this test is wrong.
I'm trying to think if there was any rationale for this decision, but after spending 20 minutes or so looking through my notes and old messages I couldn't find one.
The only other concern would be compatibility, but given that the unknown topic ID error is being returned by the server, but the Cluster API doesn't know how to handle it I think this change makes sense.
@ijuma do you have any concerns from the compatibility angle? Given this is an admin API, I don't think changing this error should break anything in a crazy way.

I synced with @ijuma offline. I think it makes sense to return the UnknownTopicId exception since that is what we do for the deleteTopics api and what the server is using.
It is a bit annoying that we can't use the topicError directly and we convert to the cluster object that loses all the detail about the topic IDs and their error responses. But fixing that requires a larger refactor,
For now let's just fix https://github.com/apache/kafka/blob/2a5fbf28820ddcde5ead605e070391059d5d2e18/core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala#L200

Thanks for the feedback @jolshan . If I'm following your comments on the broken test, the assertion
assertThrows(classOf[ExecutionException], () => results.get(nonExistingTopicId).get).getCause.isInstanceOf[UnknownTopicIdException]

must be replaced with:
assertFutureExceptionTypeEquals(results.get(nonExistingTopicId), classOf[UnknownTopicIdException])

Correct?

@MikeEdgar that looks to be right. But please run the test to make sure it works correctly.

@jolshan , I've updated the test and it's passing, but the CI is failing on a seemingly unrelated test.
Gradle Test Run :storage:test > Gradle Test Executor 76 > TransactionsWithTieredStoreTest > testCommitTransactionTimeout(String) > testCommitTransactionTimeout(String).quorum=kraft FAILED

    org.apache.kafka.common.errors.TimeoutException: Timeout expired after 3000ms while awaiting InitProducerId

Sorry for the delay @MikeEdgar. That is a known issue for the test. I will also look at this PR and run the build again.

Hey @MikeEdgar I'm seeing KafkaAdminClientTest.testDescribeTopicByIds failing due to it expecting the old error. Can we update that test?

Thanks @MikeEdgar looks like the test is fixed. I'll run the build again to make sure there aren't any other related tests failing.


Can you add an toggle option?

Hello I would realy like to see toggle option so I don't need to change step of a button based on a feedback from the outlet.

Hello its going?

I added a toggle action to v2.1.0 of the module. Not quite sure when I will release that but it will be in that version or greater


Webpack lazy-loading chunk progress

Request for new feature
Currently Webpack provide a powerfull & easy way to create chunk, very effiscient for code splitting on site and app.
As webpack already know the size of each bundle, it'll be amazing if we could have an easy way to handle the loading progress of the chunk during the runtime to create precise loader animation., here a syntaxe suggestion :
require.ensure([module1,module2], (require,progressCallback)=>{
     //loaded
})

progressCallback = (percent)=>{
    //animation
}

Using the lazy-loading a lot on professional site, I feel providing precise loading time to my user is important, but I'm curious to have other developer as well as the webpack team opinion on it.

It looks like you just deleted/ignored our lovely crafted issue template. It was there for good reasons. Please help us solving your issue by answering the questions asked in this template. I'm closing this. Please open a new issue with filled issue template. Also make sure your issue is not a question. Questions should be posted on Stack Overflow.


missing incomplete and complete lethal terms

MP:0013293, “embryonic lethality prior to tooth bud stage” does not have complete and incomplete children, only other narrower terms…
Should review the other terms here and add incomplete/complete children where missing.
See also:
embryonic lethality prior to organogenesis
The rest of the lethality terms all have the incomplete/complete children

added complete and incomplete children


Running via Fargate Service

I really like the idea of using SSM sessions and haproxy together!
Previously I was using some hand-rolled SSH solution that used tunneling, wasn't great.
I was wondering if instead of using EC2, would it be possible to use Fargate Service?
Would be easier to just use an existing an official haproxy image.
Are the costs much different?
Also, was thinking that maybe with either EC2 or Fargate, it'd be possible to start/stop the service via some sort of CLI, or even detecting the connection? Or maybe even some SSM event?
Not sure, just throwing some ideas out there in case you know more :)

To answer my own question re pricing: https://calculator.aws/#/estimate?id=806c667aa48d9f8fd25768f78e507ee1a6ade255
Smallest Fargate Service will run at ~  9.01 USD per month.

Hi there,
yes we actually already thought about something like that. Less because of the cost perspective, because the current solution is cheaper: https://calculator.aws/#/estimate?id=d67bdffee88a66558f0baff5a71026f708752327 but because we don't have to care about security updates on the ec2 instances, since once started they are normally long running for us.
Also there is this blog post elaborating on the fargate bastion host: https://blog.bruceleeharrison.com/2021/03/02/aws-ecs-fargate-bastion-host/ which I only skimmed over a bit so far.
Another quick win in the costs department could be to use the new t4g.nano instance. Then the instance would only cost 6.08$ in us-east-1. However I'm not sure if it's available in all regions already and if all the software is running on ARM.

I am wondering though if there is a way to trigger ec2 or fargate to start stop based on event. But then I don't know if the SSM will timeout or wait for it to boot.

I think there is no connection possible, because the server where SSM is doesn't exist yet, but I didn't test it myself so far.
All of these event based things should be possible with CloudWatch Events / EventBridge. Maybe you also need a Lambda Function which is triggerd by the CloudWatch Event and starts or stops the instance.

Ok, I looked at the docs and nothing obvious jumps out. Will close the issue for now, as it doesn't seem actionable at this point. But if anything, we can still continue the conversation here. Cheers!


[BUG] Not Showing Properly on buttons

Description
When we hover over the buttons on the entire page it changes the color to gray which is not visible clearly. So i want to edit this.
@mdazfar2 Pls assign me under label gssoc-ext, hacktoberfest-accepted
Screenshots

Any additional information?
No response
What browser are you seeing the problem on?
Firefox, Chrome, Microsoft Edge
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I'm a GSSoC'24-Extd contributor
[X] I'm a Hacktoberfest'24 contributor
[X] I am willing to work on this issue (optional)

Sir i have raise the issue again earlier one i closed pls assign me under labels

Sir can i fix the logo issue in footer ? @mdazfar2

No one raise that issue @mdazfar2


Updated readme to deal with download warning

Description
Updated README to provide steps to deal with the MS Defender Unsafe Warning While downloading. Which previously not letting one download the .exe file.
Conclusion
Let me know if i should make any changes there. TY😄

Fixed the issue https://github.com/SaptarshiSarkar12/Drifty/issues/37


chore(doc): alphabetical order

Description:
Related issue (if exists):

Coverage remained the same at 97.506% when pulling 277bfd4c2cd15913974596eff680f98c632f01f0 on Shyam-Chen:master into a24146f1ad09acd62ea92ee0f8d983d5ab5cf835 on ReactiveX:master.

Thanks @Shyam-Chen! And thanks @sumitarora  for the review as well.


CY-459, CY-461: Add probable source in the ad password change alert and change severity to medium

…

We may further enhance this to use with many more alerts including maybe WinEventLog cleared. This sounds very promising custom command.
But I just realized, this could have been done by mvmap function of eval. But python seems much simpler.

just curious; can we? we need to first apply time condition if it matches then we need to select same index number value but from another field. Also if combine then, we need to separate it in the mvmap so not sure.

We may further enhance this to use with many more alerts including maybe WinEventLog cleared. This sounds very promising custom command.
But I just realized, this could have been done by mvmap function of eval. But python seems much simpler.

just curious; can we? we need to first apply time condition if it matches then we need to select same index number value but from another field. Also if combine then, we need to separate it in the mvmap so not sure.

Here you go:
| eval output=mvmap(input, if(tonumber(mvindex(split(input, "###"), 0))>(_time-300) AND tonumber(mvindex(split(input, "###"), 0))<(_time+300), mvindex(split(input, "###"), 1), null()))


Error when trying Python Script with this library.

Checklist

[X] I'm reporting a broken site support issue
[X I've verified that I'm running youtube-dl version 2021.12.17
[X] I've checked that all provided URLs are alive and playable in a browser
[X I've checked that all URLs and arguments with special characters are properly quoted or escaped
[ ] I've searched the bugtracker for similar bug reports including closed ones
[ ] I've read bugs section in FAQ

Verbose log

[youtube] aA05SEjqrvA: Downloading webpage
ERROR: Unable to extract uploader id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
An error occurred during the download

Description

I apologize for the following information if it does not completely follow what is asked for, this is my very first report in GitHub or anywhere for that matter.
I used a python script with this library and in the past it has worked very well but when I recently tried using it again after a few days of the initial try I got this above error.

Read and follow #30839 as asked. Use the checklist.


[BLOCKING][WIP][jvm-packages] enable predictLeaf/predictContrib/treeLimit in 0.8

missing the test cases

Codecov Report

Merging #3532 into master will increase coverage by 0.02%.
The diff coverage is 57.14%.

@@             Coverage Diff              @@
##             master    #3532      +/-   ##
============================================
+ Coverage     45.63%   45.66%   +0.02%
  Complexity      188      188
============================================
  Files           166      166
  Lines         13221    13280      +59
  Branches        445      455      +10
============================================
+ Hits           6034     6064      +30
- Misses         6983     7002      +19
- Partials        204      214      +10

Impacted Files
Coverage Δ
Complexity Δ

...c/main/scala/ml/dmlc/xgboost4j/scala/Booster.scala
35.71% <0%> (ø)
8 <0> (ø)
:arrow_down:

.../scala/ml/dmlc/xgboost4j/scala/spark/XGBoost.scala
73.59% <100%> (ø)
0 <0> (ø)
:arrow_down:

.../dmlc/xgboost4j/scala/spark/XGBoostRegressor.scala
59.78% <53.12%> (-2.03%)
16 <0> (ø)

...dmlc/xgboost4j/scala/spark/XGBoostClassifier.scala
62% <56.41%> (-1.54%)
18 <0> (ø)

...c/xgboost4j/scala/spark/params/GeneralParams.scala
66.66% <66.66%> (ø)
0 <0> (ø)
:arrow_down:

...c/xgboost4j/scala/spark/params/BoosterParams.scala
58.82% <75%> (+0.28%)
0 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd07c25...ef3316f. Read the comment docs.

@CodingCat Should we shoot for merging this PR before releasing 0.80? If we need to, we can delay 0.80 release a bit.

@yanboliang would you please take a look?

@yanboliang please check the latest update

Looks good, it seams the failure is not relevant.

I fixed the error in the Jenkins build. It should build successfully now.

@hcho3 I merged this and cherry-picked to release_0.80 branch

@CodingCat Okay, I will do a code freeze using this commit. The branch will be re-based against the master at this commit.
As for the doc building, I'm going to place the build script on the CI server. The built doc will be placed to an S3 bucket, which will be then downloaded by ReadTheDocs. Expect a commit by end of today.


Task spinner gets out of sync if process got kill from the outside

VSCode Version: 0.10.12
OS Version: Windows

Steps to Reproduce:

tasks that launches an external process
Start and kill from the outside

The spinner will not start again when you start the process a second time.

Doesn't happen with new 2.0.0 task system anymore. Closing as obsolete.


Cannot Start Postgres DB Container on windows server 2019

Describe the bug
Hi,
I recently setup a VM and i am trying to start the application on it using the build in Docker settings. So far everything is going good, but I am now facing an issue where the Postgres DB Container is not starting. I have attached the Compose Logs here too. If you can help me with this then it would be great.
logs.txt
To Reproduce
Steps to reproduce the behavior:

Setup Docker on Windows Server 2019
Download Compreface 0.6.x
Go to the folder
Run docker-compose up -d.
After that , run docker-compose logs

Expected behavior

Shall Be able to get to Login Screen and create a user.

Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: Windows Server 2019
Browser : Google Chrome
Version Compfreface 0.6.x

Additional context

It Says in the Logs that the connection attempt Failed. Maybe That might help. It does look like the Postgre DB didnt start.

Hi, sorry for the long reply.
I don't have any experience with Windows Server 2019.
CompreFace uses the default image of PostgreSQL, so I recommend finding a tutorial on how to run PostgreSQL in docker on Windows Server 2019. As soon as you will manage to run clean PostgreSQL, I believe the CompreFace version also will work.
Also, to check the Postgres logs, run docker logs compreface-postgres-db.

Hey Bro, No issues... I can understand this might be an issue as Windows Server comes built in with Docker support but for some reason , its not working. Its okay though as I have asked My Infra team to setup a LINUX VM instead.
So yeah, all good for now.


Handshake failed when run istio on virtual machine

This is not really a bug, since i tried same thing on my local vm / k8s  and it wokred.
doc : https://istio.io/latest/docs/setup/install/virtual-machine/
Controlplane network path is  :  istio on vm(pilot-agent & envoy) -> [ eastwest gateway -> istiod ( on k8s )   ]
I always got handshake failure online, from tcpdump grabbed packet  i saw that pilot-agent on vm always tried to handshaked with istiod on k8s with tlsv1 version , but this was tlsv1.3 on my local machine
So i wonder if i can force pilot-agent to use  tlsv1.2+ to do the handshaking with istiod?
Version
istio : 1.12.2
kuberentes : 1.17.4

Additional Information
No response

Log on vm showed:
failed to warm certificate: failed to generate workload certificate: create certificate: rpc error: code = Unavailable desc = connection error: desc = "transport: authentication handshake failed: read tcp vm's ip:6852-> eastwestgatewayip:15012: read: connection reset by peer"

More info : when skip east west gateway and directly connected to istiod's node port, it worked,and package showed that handshake with tlsv1.3 protocol

tls.Config.MinVersion = 1.12 in istio

@hzxuzhonghu  you mean like this?if so then still  no luck for me .
`apiVersion: networking.istio.io/v1beta1
kind: Gateway
metadata:
name: istiod-gateway
namespace: istio-system
spec:
selector:
istio: eastwestgateway
servers:

hosts:

'*'
port:
name: tls-istiod
number: 15012
protocol: tls
tls:
minProtocolVersion: TLSV1_2
mode: PASSTHROUGH

hosts:

'*'
port:
name: tls-istiodwebhook
number: 15017
protocol: tls
tls:
mode: PASSTHROUGH`

This is not istio's problem,tried it on another k8s cluster and it worked

What's the cause


Add cast to string in HtmlRenderer::isCoreFile()

Q
A

Is bugfix?
✔

New feature?
❌

Breaks BC?
❌

Fixed issues
#28

👍


What is the actual default value of MaxResults setting for Presto?

I was tracing our Presto cluster with AWS CloudTrail and it issues a lot of GetPartitions (sometimes hundreds) for a table. We are using AWS Glue.
My first question is where is the MaxResults set to Presto?
https://docs.aws.amazon.com/glue/latest/webapi/API_GetPartitions.html
MaxResults
The maximum number of partitions to return in a single response.
Type: Integer
Valid Range: Minimum value of 1. Maximum value of 1000.
Required: No

Presto has hive.max-partitions-per-scan property (default: 100,000). Does this answer help you?
By the way, you can ask such kind of questions on our community Slack.
https://prestosql.io/slack.html

Presto has hive.max-partitions-per-scan property (default: 100,000). Does this answer help you?

No this is not the answer to my question. I think the MaxResults is not set (null) which results in defaulting to 1.

By the way, you can ask such kind of questions on community Slack. I think you already joined there.
https://prestosql.io/slack.html

Thanks.

@l1x i see you already did deep investigation. Do you think you know enough to propose a fix?

Sending the pull request soon.

As you already know, we haven't yet set MaxResults for Glue Hive metastore. (Sorry, I misunderstood your question)

As you already know, we haven't yet set MaxResults for Glue Hive metastore. (Sorry, I misunderstood your question)

No worries at all. This is an important change form the performance point of view, I am not sure why AWS made it optional. We noticed it during a performance related investigation by accident.


Script is missing Azure PowerShell code

Customers should be able to use their tool of choice to deploy Azure Functions. Now that it is fully supported with Azure PowerShell, the script should have its equivalent in PowerShell.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 588bed2f-cf61-0a79-2496-d7eb8b654776
Version Independent ID: 8f7cad91-9db3-2128-54ef-ab29906f2279
Content: Create a function app with GitHub deployment - Azure CLI
Content Source: articles/azure-functions/scripts/functions-cli-create-function-app-github-continuous.md
Service: azure-functions
GitHub Login: @ggailey777
Microsoft Alias: glenga

Thanks @dcaro for the feedback. We do now have an Azure PowerShell version of this script in the PowerShell samples article here: Create a function app with continuous deployment
#please-close


add DataFrame datatype. :showdataframe

Right now it has only sort in ascending order. Any feature interface advice would be welcomed.

I changed command to showdataframe and added offset and limit
the syntax now is :showdataframe  orderby  [offset ] [limit ]
TutorialD (master/main): :importexample date
TutorialD (master/main): :showdataframe s orderby s# offset 1 limit 2
┌──────────┬────────┬───────────┬───────────────┐
│city::Text│s#::Text│sname::Text│status::Integer│
├──────────┼────────┼───────────┼───────────────┤
│"Paris"   │"S2"    │"Jones"    │10             │
│"Paris"   │"S3"    │"Blake"    │30             │
└──────────┴────────┴───────────┴───────────────┘
TutorialD (master/main): :showdataframe s orderby s# offset 1
┌──────────┬────────┬───────────┬───────────────┐
│city::Text│s#::Text│sname::Text│status::Integer│
├──────────┼────────┼───────────┼───────────────┤
│"Paris"   │"S2"    │"Jones"    │10             │
│"Paris"   │"S3"    │"Blake"    │30             │
│"London"  │"S4"    │"Clark"    │20             │
│"Athens"  │"S5"    │"Adams"    │30             │
└──────────┴────────┴───────────┴───────────────┘
TutorialD (master/main): :showdataframe s orderby s# limit 2
┌──────────┬────────┬───────────┬───────────────┐
│city::Text│s#::Text│sname::Text│status::Integer│
├──────────┼────────┼───────────┼───────────────┤
│"London"  │"S1"    │"Smith"    │20             │
│"Paris"   │"S2"    │"Jones"    │10             │
└──────────┴────────┴───────────┴───────────────┘
TutorialD (master/main): :showdataframe s orderby s#
┌──────────┬────────┬───────────┬───────────────┐
│city::Text│s#::Text│sname::Text│status::Integer│
├──────────┼────────┼───────────┼───────────────┤
│"London"  │"S1"    │"Smith"    │20             │
│"Paris"   │"S2"    │"Jones"    │10             │
│"Paris"   │"S3"    │"Blake"    │30             │
│"London"  │"S4"    │"Clark"    │20             │
│"Athens"  │"S5"    │"Adams"    │30             │
└──────────┴────────┴───────────┴───────────────┘

Add orderby multiple attributes with ASC/DESC order.
:showdataframe relExpr orderby {attrName1 [ASC/DESC], attrName2 ...}
The order is optional.
The default is ASC.
That's it for now.
TutorialD (master/main): :showdataframe s orderby {city, s# DESC}
┌──────────┬────────┬───────────┬───────────────┐
│city::Text│s#::Text│sname::Text│status::Integer│
├──────────┼────────┼───────────┼───────────────┤
│"Athens"  │"S5"    │"Adams"    │30             │
│"London"  │"S4"    │"Clark"    │20             │
│"London"  │"S1"    │"Smith"    │20             │
│"Paris"   │"S3"    │"Blake"    │30             │
│"Paris"   │"S2"    │"Jones"    │10             │
└──────────┴────────┴───────────┴───────────────┘

Regarding ordering for sub-relations, I think it should be possible to specify the ordering within the subrelations' attributes, but not on the sub-relation attribute itself. Ordering on the sub-relation's attribute would probably require allowing the user to run an aggregate query on the sub-relation's attribute which can be done now by adding a function evaluation on the sub-relation to the relational expression and then ordering on that attribute.

I see. I have a picture in mind now. I'll find some other time to implement this. Thanks!

If we are going to have sub-dataframe, it look like we need either a) add DataFrame Atom and AtomType (which kind of ruin the whole Relation structure) or b) create a new DataFrame structure. (a lot of duplicate code)
Or, c) we just remember the path that the command give and find a way to follow the path to change a sub Relation's TupleSet (which violate the name again, but has least amount of refactoring.).
What if we have
data Relation =  Relation Attributes RelationTupleSet |
                 Relation Attributes DataFrameRow (which is just a tuple list)

hmm... it may raise another issue.
Should DBMS offer an order for columns/attributes and cells in a row/atoms in tuples?
It seems b) a whole new structure for DataFrame offers more possibilities.

Thinking in fundamentally, it's just unsortable sets / sortable lists transformation between Relation and DataFrame, including attribute order and atom order in a tuple.
Maybe it can have something to do with semi-iso. Just leave a thought here for reference.

I guess a simple Zipper can be used to implement toDataFrame with sub-DataFrame.
zipTree :: Tree a -> Tree b -> Tree (a,b)
zipTree (Leaf a)     (Leaf b)     = Leaf (a,b)
ZipTree (Node l1 r1) (Node l2 r2) =
    let l = zipTree l1 l2
        r = zipTree r1 r2
    in Node l r

But I can't feel how user will use fromDataFrame and order a DataFrame with sub-DataFrame together in a tutd line.
So in this feature i'll stop here until the need emerges.


XLA Feature request: Support Variables for tfcompile

Is it feasible to extend tfcompile to support training?
Our robotics pipelines sometimes spend significant time in Python side of session.run because networks are small, and need lots of session.run calls since each .run leads to an interaction with robotics simulator (Mujoco)
So you could have have 30k session.run calls where actual computation takes 200 usec, and Python session.run overhead is another 150 usec.
This could be improved if the network was tfcompiled and we didn't have to use session.run, however, this would need tfcompile to be extended to support multiple sets of fetches for the compiled object. IE

network initialization, input: weights, output: None
network forward op: input: observation, output: action
network train op: input: observations, actions output: None
network variable read: input: None, output: weights

cc @tatatodd

+1 if you're going to go as far as tfcompile; consider just using C++ to interface with your training loop.
alternatively, write a TF C++ op wrapper that communicates with a mujoco session via server/client calls; and then your multiple interactions can be subsumied within a tf.while_loop.
another alternative might be to use session.partial_run to avoid the cost of copying data back and forth between python/C++.

Training is in Python because each step interacts with other Python libraries. Mujoco, gym and Universe have  Python bindings. C++ bindings are either not as well tested (people tend to use Mujoco through Python) or missing completely (gym + universe).
Partial run would help if I needed to persist some Tensors between run calls. But here I'm injecting new data each time. I can see how Mujoco C++ op would be more efficient but going down that route seems a bit scary, and would only help with mujoco (and not with gym, universe)

tfcompile will create a C++ binary for you; you'd have to swig-wrap it to make it work with python which is IMO more daunting. I've noticed folks are afraid of writing C++ ops but IMO this is the least painful way to design interfaces with other systems thanks to the static type checking (and with Google's address sanitizer you get the additional benefit of ensuring you're not corrupting memory).
you could probably also try the pywrap to make a python op that interacts with mujoco within a tf.while_loop and is more lightweight than many session.run calls.

I was hoping to avoid SWIG and use ctypes with tfcompiled object. IE something like
import ctypes
network = ctypes.cdll.LoadLibrary("compiled.so")
result = ctypes.c_float()
network.runforward(result)

if you get that to work, please do report back!

Fair enough, though you could write C++ code just to execute the graph (equivalent to what the generated tfcompile shared library would do) and use it in a way similar you described, no? Just that the library is produced by compiling a .cc file that you write instead of being produced by tfcompile.
Anyway, just a suggestion, I am in no way suggesting that this feature request isn't a reasonable one. Just pointing out possible equivalents you can pursue today without the feature.
I will stop derailing this thread now :)

@asimshankar Hm, good point. For your proposed alternative I could also use it through ctypes and compiled.so would be a C++ binary that I created which uses TF C++ API and implements those 4 modes: variable in, forward, train op, variable out
I was assuming that using XLA AOT for this is more efficient because it gets rid of unneeded TF runtime bits.
Implementing this feature would require changes to tfcompile to support Variables and multiple fetch configurations. On other hand it would make XLA AOT compiler more useful/widely applicable.
I'll leave it to XLA maintainers to decide if this feature fits into the XLA vision/design

/cc @tatatodd @hawkinsp

Wrt multiple fetch configurations, an alternative is to compile separate functions, one for each configuration.  The only downside that I see of this strategy is that perhaps lots of generated code is duplicated in each function; i.e. the combined size of the *.o files is larger than strictly necessary.  But it doesn't sound like that would be a big issue.
Supporting Variables is trickier.  In theory we could hoist the variables outside of the "pure graph", and add logic to read/write the variables at the edges.  But it's not clear this is worth doing for the AOT codepath; it's quite a bit of work.  You could always do this manually though, so that you end up with a "pure graph" that can be AOT compiled.

That said there is some experimental support for compiling code that manipulates variables in the JIT use case:
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/compiler/jit/kernels/xla_device_launch_op.cc
(That code only works for ResourceVariables, which will replace Variables at some point in the future.)
Code that reads and writes variables is rewritten into a pure computation that takes the initial values of the variables as inputs and returns updated values as outputs. So most of the code one would need is actually already there.

OK, it seems like some of the performance benefits needed be done with compiled binary that uses C++ TF API, and benchmarking is needed to decide if extra work of adding variables to XLA is justified, will close this for now, will reopen if I come across some concrete numbers.


msal library popup blocked issue after Angular 13 upgrade

🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑
Please file any Angular Framework issues at: https://github.com/angular/angular/issues/new/choose
For the time being, we keep Angular issues in a separate repository.
🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑

Facing issue after angular upgrade 13
Whenever angular application makes sso call to microsoft azure, the popup window got stuck and this issue is occurring. When i clear cookies and cache everytime, i am not facing this issue. But everytime when i need to clear cache to load my application.
Please help in resolving this issue

Hello, we reviewed this issue and determined that it doesn't fall into the bug report or feature request category. This issue tracker is not suitable for support requests, please repost your issue on StackOverflow using tag angular-cli.
If you are wondering why we don't resolve support issues via the issue tracker, please check out this explanation.


Add basic exception handling support for MinGW

This is the exception-handling related part of #190.
It:

Implements __gnu_objc_personality_seh0 which uses _GCC_specific_handler to call __gnustep_objc_personality_v0
As a special case, when compiling on MinGW, renames __gnustep_objc_personality_v0 to __gnustep_objc_personality_v0_internal and implements __gnustep_objc_personality_v0 with the same semantics as __gnu_objc_personality_seh0 (for clang support).  This special case can be removed when clang knows about MinGW support in libobjc and directly invokes __gnu_objc_personality_seh0.

which brings basic try/catch support to objc2 on MinGW. C++ exception interop is still not implemented.
When running the tests, 89% tests passed, with all failures being related to exception interop:

UnexpectedException (Exit code 0xc0000409)
CXXExceptions (Exit code 0xc0000374)
ObjCXXEHInterop (SEGFAULT)
ObjCXXEHInteropTwice (SEGFAULT)
ObjCXXEHInterop_arc (SEGFAULT)

Notable passing tests are ExceptionTest, NestedExceptions, NilException, objc_msgSend and RuntimeTest

@davidchisnall @triplef What do you think?  It wires up domestic Objective C exception handling on MinGW, which I think is a big win.  __gnustep_objc_personality_v0 behaving as __gnustep_objc_personality_seh could be controversion (and I can undo the change), but it could be a short-term fix which can be removed when clang knows about MinGW support in libobjc2.

I think this looks mostly fine, thanks for working on it. Using this model precludes catching MSVC C++ exceptions in MinGW programs, but I presume anyone who opts into using MinGW already chose suffering so that shouldn’t be an issue.
For C++ exception interop to work, we need MinGW’s libstdc++ to expose their C++ personality function as a public symbol. Was there any progress getting them to do this?
I don’t want to make this an officially supported configuration without that because clang throws Objective-C objects as C++ objects in Objective-C++ mode.
The alternative that I proposed is simply to have clang use the C++ personality function and throw functions in MinGW mode. Our type_info subclasses should make that just work with MinGW already.

Thanks @davidchisnall

I presume anyone who opts into using MinGW already chose suffering so that shouldn’t be an issue.

At least in my case, the choice for MinGW wasn't really voluntary, but rather because MinGW is the only environment in which you can compile GNUstep (including the GUI) for Windows.

We need MinGW’s libstdc++ to expose their C++ personality function as a public symbol

There's are multiple MinGW environments. The clang environments use libc++.  Would that simplify things a bit?
Both the libstdc++ in the mingw64 environment and libc++ in the clang64 environment export the __gxx_personality_seh0 symbol.  Does that help?
vagrant@DESKTOP-RNTVKUC UCRT64 ~
# nm -g /mingw64/lib/libstdc++.a | grep "T __gxx_personality_seh0"
0000000000000000 T __gxx_personality_seh0

vagrant@DESKTOP-RNTVKUC UCRT64 ~
# nm -g /clang64/lib/libc++.a | grep "T __gxx_personality_seh0"
0000000000000000 T __gxx_personality_seh0

to have clang use the C++ personality function and throw functions in MinGW mode

Could you elaborate on that a bit more?  This is not familiar territory for me, but perhaps there's a reference implementation
you can point me to?

At least in my case, the choice for MinGW wasn't really voluntary, but rather because MinGW is the only environment in which you can compile GNUstep (including the GUI) for Windows.

It’s a bigger project, but it would be really nice to remove that dependency at some point. Most of GNUstep uses Foundation as an abstraction layer and there aren’t many POSIX dependencies outside of a few classes (e.g. NSFileHandle, NSLock).

Both the libstdc++ in the mingw64 environment and libc++ in the clang64 environment export the __gxx_personality_seh0 symbol. Does that help?

Unfortunately not. This is the adaptor that looks like a Windows EH personality. This then calls a GCC runtime helper function that takes an Itanium personality function as an argument and morphs the Windows unwind info to look like Itanium EH info and calls it. By the time our code is reached, we’ve already had that transformation happen. We need to have access to the function that __gxx_personality_seh0 passes to _GCC_specific_handler.  We forward to the C++ personality function here: https://github.com/gnustep/libobjc2/blob/28bb93cfdc25a1f20da9495d9a0efb0060ece451/eh_personality.c#L613
In libcxxabi, this should be __gxx_personality_imp, which is declared static. I’m not sure if any of the Windows introspection functions would let us find it, but the thing that we really want is to drop the static from the declaration here:
https://github.com/llvm/llvm-project/blob/0871c4beb826feba2d2aaf2c3efbe1fdeba7624a/libcxxabi/src/cxa_personality.cpp#L911C1-L911C29

It would be really nice to remove that dependency at some point

Yes, and I think we're pretty close to being able to make that happen.  You can use MSYS2 as a Bash shell on Windows to invoke the GNUstep build scripts, and have the build scripts invoke the Windows-native Clang compiler (i.e. no MinGW involved).  At the moment, I got stuck because the lld linker does not export symbols for instance variable offsets, but you've provided pointers for that -- thanks.

In libcxxabi, this should be __gxx_personality_imp, which is declared static.

This is probably a long shot, but it looks like at least libc++ exports the __libunwind_seh_personality function.  It looks like this is the opposite of _GCC_specific_handler?  If so, could we do the same as this function -- convert the Itanium unwind info back to Windows unwind info, and then call __gxx_personality_seh0, have it undo that conversion, and finally invoke __gxx_personality_imp?

The thing that we really want is to drop the static from the declaration here

Do you know whether there's a chance of a patch doing that being accepted by the LLVM project?

This is probably a long shot, but it looks like at least libc++ exports the __libunwind_seh_personality function. It looks like this is the opposite of _GCC_specific_handler?

If I'm reading the code right, I think it handles some of the translation, so it probably breaks if you interleave it but it might be worth a try.

Do you know whether there's a chance of a patch doing that being accepted by the LLVM project?

They'd probably want to rename the function, but I don't see a problem with it landing, if we can justify it by wanting other personality functions to be able to delegate to the C++ one.

@davidchisnall I've rewritten this PR a bit, and removed the #ifdef that disabled the call to test_cxx_eh_implementation on MinGW.  Instead, I've disabled support for Objective C++ on MinGW, which results in NO_OBJCXX being set and that entire code path being ignored.
I think that's a more correct way of doing this.  It enables domestic exception support in Objective C but doesn't make a guarantee of C++ interop.
I'll explore the other options we've discussed, starting with finding ways to invoke __gxx_personality_imp.  Would you be willing to accept this PR as is, for now?

@davidchisnall I spent some time looking into this.  It looks like the purpose of test_eh_personality is to extract the values for type_info_offset, exception_struct_size and cxx_exception_class. It needs the exceptionObject and exceptionClass values to do so. Once it has done that, it delegates all work to __gxx_personality_v0.
But looking at _GCC_specific_handler, it appears that you can get this information in the _seh0 variant via (struct _Unwind_Exception *) ms_exc->ExceptionInformation[0].
In that case, could we just extract these values in test_eh_personality on the first call, and have test_eh_personality call __gxx_personality_seh0, without having to worry about _GCC_specific_handler?

The C++ runtime library’s internal structure layout is not public (or stable, it’s changed in a couple of implementations). It isn’t getting these values that’s the problem, it’s setting them.
It may be possible, for MinGW, to move the wrapping one layer up and do it in the function that calls the GCC specific handler adaptor. If the incoming exception is an Objective-C exception and we’re in a C++ frame, we forward directly to the C++ personality function.
That said, the simpler solution is probably to get rid of all of the ifdefs and have a different objc_throw for MinGW that always throws as a C++ exception, and just use the ObjC++ code paths unconditionally for the catch blocks in Clang.

Can you try modifying this line:
https://github.com/llvm/llvm-project/blob/5ed11e767c0c39a3bc8e035588e7a383849d46a8/clang/lib/CodeGen/CGObjCGNU.cpp#L826C3-L826C3
so that we use the C++ being / catch handlers for MinGW, this line:
https://github.com/llvm/llvm-project/blob/5ed11e767c0c39a3bc8e035588e7a383849d46a8/clang/lib/CodeGen/CGException.cpp#L213
and this line:
https://github.com/llvm/llvm-project/blob/5ed11e767c0c39a3bc8e035588e7a383849d46a8/clang/lib/CodeGen/CGException.cpp#L159
So that we use GNU_CPlusPlus_SEH for MingGW, this line:
https://github.com/llvm/llvm-project/blob/5ed11e767c0c39a3bc8e035588e7a383849d46a8/clang/lib/CodeGen/CGObjCGNU.cpp#L2390
So that we use C++ mode unconditionally on MinGW,
and then replace the exception code in libobjc2 with a single definition of objc_throw that looks like this:
static void eh_cleanup(void *exception)
{
   objc_release(*(id*)exception);
}

void objc_throw(id object)
{
    id *exc = (id *)__cxa_allocate_exception(sizeof(id));
    __cxa_throw(exc, & __objc_id_type_info, eh_cleanup);
}

I believe that should be sufficient to make MinGW use C++ exceptions unconditionally for Objective-C[++], which should then avoid needing to change anything.  We can just put those two functions in a separate file and compile that instead of eh_personality for MinGW targets.

@davidchisnall I'll try to test this later today, but is this what you hand in mind:

https://github.com/qmfrederik/libobjc2/commit/822dd6740b0f07be6844d6503afc6f1435e6799f
https://github.com/qmfrederik/llvm-project/commit/acf443c92b1db9c97245227c3f79a498ed1c2ab6

I think that looks about right, yup.

@davidchisnall Looks like I got some first results with https://github.com/gnustep/libobjc2/commit/9e84ba714945ef22e38b59225472644eb0bcead9 - using objc_exception_throw instead of objc_throw, declaring __cxa_throw and marking some additional symbols as public.
The try/catch clause in objc_msgSend.m seems to be working, although the assert assert((TestCls == e) && "Exceptions propagate out of +initialize"); is failing; if I disable that assert the test passes.

Thanks!  Looks like we're getting close.  Propagating out of +initialize requires that they're thrown through C frames with __attribute__((cleanup)).  Can you check whether that works with MinGW with just C and C++ (call C++ -> C -> C++, use __attribute__((cleanup)) in C, check you can throw an exception out)?  It's possible that we need to add an extra compiler flag to the compilation unit that handles initialize.
It's a bit surprising to me that the exception seems to be thrown and code continues executing.

Closing in favor of #267


ES6 Use Destructuring Assignment to Assign Variables from Objects & Use Destructuring Assignment to Assign Variables from Arrays - Example text doesn't match code request, needs clarification

Challenge use-destructuring-assignment-to-assign-variables-from-objects & Challenge use-destructuring-assignment-to-assign-variables-from-arrays has an issue.
I feel like the challenge examples on these two problem sets don't match the code you're required to create.
For Assign Variables from Objects - This one may honestly just need a reminder that strings have a length property that can be accessed similarly to objects, which may make it easier to come up with the answer. However, even knowing that it still confuses me. The example shows you :

const { x : a, y : b, z : c } = voxel // a = 3.6, b = 7.4, c = 6.54

Which could then (with a reminder of string's length property) hint at how to write out the answer....however in the set up code provided, it wants to console log length, which - can you write
{length: length}

? Or do you have to assign length to a new variable, which then the final line you're not meant to change would be incorrect? Or could you simply do  const {length} = greeting  and it would save the value of the length? For being the first challenge on destructuring, I think it's super confusing to be shown an example of an object and then be asked to work with a string, especially since (at least in the beta) I don't think there's anywhere that it talks about how a string has a property that acts similarly to an object. Perhaps I'm misremembering or misunderstanding something, though.
For Assign Variables from Arrays - This example one doesn't seem to match the challenge code at all. The example talks about using commas to get to a certain index in an array so you can assign a value in that manner. But then you're given two variables, neither in an array, and asked to swap their values? It just doesn't seem to match the example you're given.
Both challenge examples are worded well and make some sense as you're reading them...it's just that the problems you're asked to code don't seem to match the examples at all, at least to a beginner's perspective who's never worked with ES6 before and is likely relatively new to JavaScript. Just something I thought I should share in case others had wondered about the same thing. It's entirely possible I just missed something that should have shown me how to solve them and if that's the case I apologize and this can be closed.

They currently haven't written the any correct tests for them yet. Guess we will just have to wait I'm afraid. https://github.com/freeCodeCamp/freeCodeCamp/issues/12698

Agreed, using "length" as a variable is confusing when a built in function is also called length.
The following code worked for me:
const [string1] = greeting;
const len = string1.length;
console.log(len);

const source = [1,2,3,4,5,6,7,8,9,10];
function removeFirstTwo(list) {
  "use strict";
  // change code below this line
  const [x,y,...newlist] = list;
  console.log(newlist);
  // change this
  // change code below this line
  return newlist;
}
const arr = removeFirstTwo(source);
console.log(arr); // should be [3,4,5,6,7,8,9,10]
console.log(source); // should be [1,2,3,4,5,6,7,8,9,10];

This fails the "destructuring was used." test.

const source = [1,2,3,4,5,6,7,8,9,10];
function removeFirstTwo(list) {
  "use strict";
  // change code below this line
  const [,,...arr] = list; // change this
  // change code below this line
  return arr;
}
const arr = removeFirstTwo(source);
console.log(arr); // should be [3,4,5,6,7,8,9,10]
console.log(source); // should be [1,2,3,4,5,6,7,8,9,10];

This also failed the "destructuring was used." test.

const AVG_TEMPERATURES = {
today: 77.5,
tomorrow: 79
};
function getTempOfTmrw(avgTemperatures) {
"use strict";
// change code below this line
const {tomorrow:tempOfTomorrow} = avgTemperatures; // change this line
// change code above this line
return tempOfTomorrow;
}
console.log(getTempOfTmrw(AVG_TEMPERATURES)); // should be 79

`const AVG_TEMPERATURES = {
today: 77.5,
tomorrow: 79
};
function getTempOfTmrw(avgTemperatures) {
"use strict";
// change code below this line
const {tomorrow:tempOfTomorrow} = avgTemperatures; // change this line
// change code above this line
return tempOfTomorrow;
}
console.log(getTempOfTmrw(AVG_TEMPERATURES)); // should be 79`

const AVG_TEMPERATURES = {
today: 77.5,
tomorrow: 79
};

function getTempOfTmrw(avgTemperatures) {
"use strict";
// change code below this line
const {tomorrow:tempOfTomorrow} = avgTemperatures; // change this line
// change code above this line
return tempOfTomorrow;
}
console.log(getTempOfTmrw(AVG_TEMPERATURES)); // should be 79

Hi=)
`const AVG_TEMPERATURES = {
today: 77.5,
tomorrow: 79
};
function getTempOfTmrw(avgTemperatures) {
"use strict";
// change code below this line
const {tomorrow:tempOfTomorrow} = avgTemperatures; // change this line
// change code above this line
return tempOfTomorrow;
}
console.log(getTempOfTmrw(AVG_TEMPERATURES)); // should be 79`

Hi=)
const AVG_TEMPERATURES = {
today: 77.5,
tomorrow: 79
};

function getTempOfTmrw(avgTemperatures) {
"use strict";
// change code below this line
const {tomorrow:tempOfTomorrow} = avgTemperatures; // change this line
// change code above this line
return tempOfTomorrow;
}

console.log(getTempOfTmrw(AVG_TEMPERATURES)); // should be 79

Ah, I see. Thank you.


Update AVD Networking and Connectivity Considerations Page

Describe the summary, scope, and intent of this PR:
Updated references to the AVD Experience estimator page to point to the new page for the round-trip estimator. The Experience Estimator no longer exists, and Microsoft has not provided a better replacement. This page is confusing as it redirects to a page that doesn't necessarily, 'estimate', anything well.

Insert links(s) to any related work item(s) or supporting detail:
https://techcommunity.microsoft.com/discussions/azurevirtualdesktopforum/windows-virtual-desktop-experience-estimator/883154
https://azure.microsoft.com/en-us/services/virtual-desktop/assessment/

AFTER YOUR PR HAS BEEN CREATED, expand this section for tips and additional instructions.
These are common guidelines for contributions across the repos managed by the Cloud Architecture Content Team (CACT). Some repositories may have additional specific requirements that are not listed here.
Guidance for all contributors

Topic
Guidance

Draft PR
If your PR will be a work-in-progress for more than a day or two, select the Convert to draft link in the upper right of the page (under Reviewers) to change it to a draft. For future reference, you can also do this using the Create pull request button drop-down during PR creation.

ms.date metadata
Don't update an article's "ms.date" metadata property unless you've done a full freshness review of the content. A full freshness review includes changes required to correct or improve the full technical accuracy of the article.Don't update "ms.date" if you're doing targeted changes to improve non-technical aspects of the article, such as editorial quality, art improvements, article template alignment, etc.If you've changed any "ms.date" properties for work that wasn't part of full review for freshness, please reset them to their previous value.

Placement and linking
If you're creating a new article or articles, include updates to the related TOC.yml file to propose where the article(s) should be placed. Also consider other places within the document set where it would be beneficial to cross-reference and link to your new article(s).

PR build
After you open your PR, and for each successive commit that you push to your branch, the publishing platform will run validation on the files in your pull request. A summary of the build results for each file will be inserted inline into your pull request, which includes any build suggestions/warnings/errors. PRs cannot be merged until all build errors and most warnings are resolved.

Publishing
Following a successful merge, most repos publish to the live site at least once per (business) day, usually around 10am Pacific.

Additional resources
Learn.Microsoft.Com contributor guide

Additional guidance for private repos and internal contributors

Topic
Guidance

PR size
If your PR is more than ~5 lines of changes, or you'd like for the changes to go through editorial or larger review, open a contribution request at https://aka.ms/Contribution and include a link to the PR in response #8. Once it's processed, you'll be notified of the next steps.

PR title prefix
Select the Edit button to the right of the PR title if you need to revise it. The following prefixes are reserved for specific contribution types:[Quality Check] - maintenance work related to content quality (edit passes, art improvements, template alignment)[LinkFix] - recurring/adhoc PRs to correct link URLs[Pipeline] - new/updated contributor success pipeline content[WIP] - a work-in-progress draft requiring several days/weeks

PR preview
Following successful build of your PR, publishable files will also include Preview URL links to staged previews of your new/updated articles. Be sure to review these for verification of your intended contributions, or to send to other internal contributors for review.

PR sign-off (public repo)
If an article you own is updated in a public repo PR, you are responsible for sign-off. You will be automatically notified via email. The PR will not be merged until you've had a chance to review and sign-off.

PR sign-off (private repo)
After you've completed your proposed changes, addressed build warnings, and completed all review work, you can begin the sign-off process for review and merge:If your PR is in draft mode, remove "[WIP]" from the title and select Ready for review button at the bottom of the PR.Enter "#sign-off" in a new comment. This comment indicates that you're confident the work meets or exceeds Microsoft's standards for publication, and will trigger the review process.Your PR may be selected for initial review by the CACT. Following CACT review, you may receive questions or requests for additional changes. You should have initial feedback from CACT review within a few business days. If you have an urgent request or need to contact the team, please mention @MicrosoftDocs/cloud-architecture-content-team-pr-reviewers in your PR and someone will get back to you. After CACT review is complete, a CACT #sign-off will be added.Final review/merge is done by the PR review team. The PR team may also respond with feedback, categorized as "Blocking" (requires action from you), or "Non-blocking" (to be addressed in a future PR).

Additional resources
Learn.Microsoft.Com internal contributor guideAuthoring templates: architecture-center-pr, well-architected-prTo contact the CACT use e-mail, or @mention our GitHub team in your PR comments using: @MicrosoftDocs/cloud-architecture-content-team-pr-reviewers

@swathibhat1
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

@kyjones03 - to fix the validation issues, can you remove 'https://learn.microsoft.com/en-us'  from the links. they should start with '/azure/'
fyi @MicrosoftDocs/patterns-and-practices-team-pr-reviewers
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Updated patch-1 to remove 'en-us' to fix validation issues.

PnP #sign-off
#remove-label:"do-not-merge"
#label:"ready-to-merge"


allow callbacks to trigger the finishedMsg and end

Callbacks are super handy but they don't have the ability to end the infinity.  That's a difficult limitation.
This shows how I implemented it in my app.  It's maybe not so pretty but it works great!  If you have a better idea on how to do it I'm happy to rework the patch.

Infinite Scroll v3 is out!. It's an all new re-write, so take a look at how to upgrade from v2. With the brand new release, this contribution is no longer applicable.
Thank you for your interest and effort in Infinite Scroll. Sorry I had to pass on this one. 🌈🐻


Automatic Fetch Run Or F5 debug/run button based on application type.

Actually, when create a react application from Visual studio code, we get successfully created the react project within the desired place, But the most difficult issue is we need to run the whole application either by the command(from the terminal) or need to install the appropriate plugin for the same.
Is that possible that whenever the project is rendered or selected it should automatically render the configuration for run/debug?
This feature provided by other editors, but I loved vscode so I think the community should integrate or upgrade this feature. if possible.

This is currently not possible due to the debug architecture on the vscode side. We can not automatically infer what debugger to use etc
However soon the extensions will be able to contribute actions to the debug start view and potentially the angualr extension could  contribute an action there to make this experience better.
Due to that closing this issue


Backend doesn't spawn on first opening

It seems like the backend can't spawn when I reboot my laptop and pc on first opening (ubuntu 16.04 and windows 10). The web socket is right the first time I execute the app but it doesn't show in haskell-do.

Irrelevant with new version, closing


Fix #259: Annotation in did_skl notebook plot.

Closes #259.

self.y_pred_counterfactual was a list within a list with one element.
did_skl.ipynb now runs without errors.

Thanks for this @anevolbap 👍🏻


Evaluation subsets and code for fair comparison.

Hi,
Is it possible to share the evaluation splits and code for fair comparison?
Thanks

Specifically, I saw that this https://dino-vit-features.github.io/sm/assets/pascalco/results.html contains 20 sets from the Pascal-CO dataset. Where can I find the other 20? Thanks :)

The Pascal-CO dataset can be currently found in this link.

Thanks!


Logout functionality fails for sub organizations when using IS as federated IDP in APIM

Describe the issue:
We have configured IS 7.1-M5 as a federated Identity Provider (IDP) for APIM. However, we have observed that the logout functionality is not working correctly for users in sub-organizations. It appears that the logout call is not being properly propagated from the root organization to the sub-organizations, causing inconsistencies in session termination.
How to reproduce:

Setup IS 7.1-M5 as federated IDP for APIM 4.4.0 or any other IS
Create an App using Traditional Web Application option from super org
Create a sub org, switch to that org and create a new user
Add the necessary role to user in order to access the APP
Login to APP using that sub org user and try to logout

Expected behavior:
logout function for sub org users should be worked properly.
Environment information

Product Version: IS 7.x

Optional Fields
Related issues:

Suggested labels:

When reproducing please check with @ShanChathusanda93 since he has context on this

I did some initial analysis on this issue. As mentioned above I was able to reproduce the issue with two IS instances.

The application sends the logout request A to IS1 as expected. This request includes the OPBS cookie which is used to identify the session. With the cookie, IS1 identify the session successfully and invokes the federated IDP to initiate a logout request to IS2 [1] [2]
This logout request to IS2 does not contain the OPBS cookie. Due to this the check [3] fails and IS2 is not calling the organization SSO authenticator to send a logout request to the sub-organization. So request C is never sent
[1] - https://github.com/wso2-extensions/identity-inbound-auth-oauth/blob/v7.0.203/components/org.wso2.carbon.identity.oidc.session/src/main/java/org/wso2/carbon/identity/oidc/session/servlet/OIDCLogoutServlet.java#L739
[2] - https://github.com/wso2/carbon-identity-framework/blob/v7.7.52/components/authentication-framework/org.wso2.carbon.identity.application.authentication.framework/src/main/java/org/wso2/carbon/identity/application/authentication/framework/handler/request/impl/DefaultLogoutRequestHandler.java#L298
[3] - https://github.com/wso2-extensions/identity-inbound-auth-oauth/blob/v7.0.203/components/org.wso2.carbon.identity.oidc.session/src/main/java/org/wso2/carbon/identity/oidc/session/servlet/OIDCLogoutServlet.java#L167


error: XDG_RUNTIME_DIR not set in the environment. in ssh terminal ubuntu 16.04

I tried to run CarlaUE4.sh in a ubuntu16.04 server through ssh terminal, but got
4.24.3-0+++UE4+Release-4.24 518 0
Disabling core dumps.
error: XDG_RUNTIME_DIR not set in the environment.
I also tried the command DISPLAY= ./CarlaUE4.sh, but the error still occurred and carla can not be run. Does anyone know the reason and how to fix it? I've tried to install the ubuntu-desktop through ssh terminal.

Sorry for the late response. Which version of CARLA is this? Is the environment variable SDL_VIDEODRIVER=offscreen ?
Could you try forcing the server to use OpenGL? i.e. ./CarlaUE4.sh -opengl

@germanros1987 Thank you for your reply. I use the version carla:<IP_ADDRESS>, and I've tried other carla version, such as carla:0.9.7 or carla:<IP_ADDRESS>, but the error still occured. I printed the environment variable SDL_VIDEODRIVER by the command
echo $SDL_VIDEODRIVER
but an empty string was returned.
I also tried the command
./CarlaUE4.sh -opengl This time, this XDG_RUNTIME_DIR error was gone, but it seemed that carla server exited and nothing error information was returned:
luban@k8s-deploy-emygwl-1593499612785-dd99fd8db-6lbbd:~/nfs/volume-363-3/zhaoyinuo/carla_<IP_ADDRESS>$ ./CarlaUE4.sh -opengl
4.24.3-0+++UE4+Release-4.24 518 0
Disabling core dumps.
luban@k8s-deploy-emygwl-1593499612785-dd99fd8db-6lbbd:~/nfs/volume-363-3/zhaoyinuo/carla_<IP_ADDRESS>$

Any update on this?
I'm having the same issues running CARLA_0.9.6 on virtual machines. -opengl still give the same error
$ DISPLAY= ./CarlaUE4.sh -opengl
4.22.1-0+++UE4+Release-4.22 517 0
Disabling core dumps.
error: XDG_RUNTIME_DIR not set in the environment.
Signal 11 caught.
Malloc Size=65538 LargeMemoryPoolOffset=65554
CommonUnixCrashHandler: Signal=11
Malloc Size=65535 LargeMemoryPoolOffset=131119
Malloc Size=53392 LargeMemoryPoolOffset=184528
Engine crash handling finished; re-raising signal 11 for the default handler. Good bye.

I'm having the same error on google colab, there

I was receiving this error on ubuntu 20.04 using carla 0.9.12 from docker, but seems like 0.9.13 is working for me so far.


[SPARK-24251][SQL] Add AppendData logical plan.

What changes were proposed in this pull request?
This adds a new logical plan, AppendData, that was proposed in SPARK-23521: Standardize SQL logical plans.

DataFrameWriter uses the new AppendData plan for DataSourceV2 appends
AppendData is resolved if its output columns match the incoming data frame
A new analyzer rule, ResolveOutputColumns, validates data before it is appended. This rule will add safe casts, rename columns, and checks nullability

How was this patch tested?
Existing tests for v2 appends. Will add AppendData tests to validate logical plan analysis.

Test build #90530 has started for PR 21305 at commit a3bf530.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3157/
Test PASSed.

Test build #90530 has finished for PR 21305 at commit a3bf530.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90530/
Test FAILed.

Test build #90535 has started for PR 21305 at commit d2e4c41.

Test build #90535 has finished for PR 21305 at commit d2e4c41.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90535/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/689/
Test PASSed.

@cloud-fan, can you also review this PR for DataSourceV2?
This adds the first of the logical plans proposed in SPIP: Standardize Logical Plans: AppendData. It replaces the current logical node for batch writes and adds schema validation.

Test build #92627 has finished for PR 21305 at commit b906ab1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92627/
Test PASSed.

@cloud-fan, I've updated this with the requested changes. Thanks for looking at it!

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/736/
Test PASSed.

Merged build finished. Test PASSed.

Test build #92693 has started for PR 21305 at commit 487d864.

Test build #92693 has finished for PR 21305 at commit 487d864.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92693/
Test PASSed.

Test build #92723 has started for PR 21305 at commit 222d097.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/755/
Test PASSed.

Test build #92723 has finished for PR 21305 at commit 222d097.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
trait NamedRelation extends LogicalPlan

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92723/
Test PASSed.

@cloud-fan, I've updated this and the tests are passing, so I think it is ready for another look.
I just pushed a comments-only commit to fix the Javadoc for AppendData that @viirya pointed out (thanks!). Since that's only comments, it shouldn't affect test results.
I think there's just one more point under discussion, which is the change from jobId (which isn't one) to jobUUID and dropping the timestamp. I don't think a timestamp helps avoid conflicts because it is astronomically unlikely that UUIDs will collide.

Test build #92761 has started for PR 21305 at commit 65c2670.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/782/
Test PASSed.

Test build #92761 has finished for PR 21305 at commit 65c2670.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92761/
Test FAILed.

Retest this please.

@cloud-fan, I think we can ignore that last test failure because tests are passing on the last commit that made real changes. The latest commit only changed a comment.

Test build #92780 has started for PR 21305 at commit 65c2670.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/796/
Test PASSed.

(The last test failure is a known flaky test I've been working (albeit unsuccessfully so far) to find a solution for.)

Test build #92780 has finished for PR 21305 at commit 65c2670.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92780/
Test PASSed.

Do we have a plan to update the data source v2 write API to support ReplaceData, DeleteData? It seems a simple WriteMode flag is not enough for the write API.

@cloud-fan, yes. There is an open PR, #21308, that adds DeleteSupport. I'm not pushing for that just yet because I think DeleteSupport should be applied to Table after #21306 makes it in.

cool! so WriteSupport will be used for AppendData, CTAS and RTAS? Do we still need the SaveMode after we standardize the DDL/DML logical plans?

Test build #93208 has finished for PR 21305 at commit f041019.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93208/
Test PASSed.

Retest this please.

@cloud-fan, @gatorsmile, is it possible to get this in for 2.4? This validates writes to data source tables so I think it is a good one to have.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1289/
Test PASSed.

Test build #93519 has started for PR 21305 at commit f041019.

Test build #93519 has finished for PR 21305 at commit f041019.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93519/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1364/
Test PASSed.

Merged build finished. Test PASSed.

Test build #93612 has started for PR 21305 at commit 91f2f14.

Test build #93612 has finished for PR 21305 at commit 91f2f14.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93612/
Test PASSed.

@cloud-fan, @gatorsmile, this has been ready for final review for a while. Do you think you'll have some time to look at it?

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1532/
Test PASSed.

Test build #93844 has started for PR 21305 at commit cd5f309.

Test build #93844 has finished for PR 21305 at commit cd5f309.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
trait BarrierTaskContext extends TaskContext
class BarrierTaskInfo(val address: String)
class RDDBarrier[T: ClassTag](rdd: RDD[T])
case class WorkerOffer(
case class Shuffle(child: Expression, randomSeed: Option[Long] = None)
case class ReplicateRows(children: Seq[Expression]) extends Generator with CodegenFallback
trait AnalysisHelper extends QueryPlan[LogicalPlan]
case class Intersect(
case class Except(
case class RandomIndicesGenerator(randomSeed: Long)

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93844/
Test FAILed.

@cloud-fan, I'll look into the test failures tomorrow, but this has been passing tests for weeks so I think it is still safe to review when you have time. We can fix both in parallel so that we can get validated writes in 2.4.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1584/
Test PASSed.

Test build #93908 has started for PR 21305 at commit ac7cb13.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1585/
Test PASSed.

Test build #93909 has started for PR 21305 at commit 922dc16.

Test build #93909 has finished for PR 21305 at commit 922dc16.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93909/
Test FAILed.

Test build #93908 has finished for PR 21305 at commit ac7cb13.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93908/
Test PASSed.

@cloud-fan, I'll fix the conflicts and re-run tests. Yesterday's tests passed after I updated for your feedback. I'd like to try to get this in soon because it is taking so much time to resolve conflicts without any real changes.
FYI @gatorsmile, @bersprockets, @jzhuge

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1679/
Test PASSed.

Test build #94030 has started for PR 21305 at commit 897dc39.

Test build #94030 has finished for PR 21305 at commit 897dc39.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94030/
Test FAILed.

Merged build finished. Test FAILed.

Retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1700/
Test PASSed.

Test build #94060 has started for PR 21305 at commit 897dc39.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1711/
Test PASSed.

Test build #94074 has started for PR 21305 at commit 6aa7f69.

Test build #94060 has finished for PR 21305 at commit 897dc39.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94060/
Test FAILed.

Test build #94074 has finished for PR 21305 at commit 6aa7f69.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94074/
Test FAILed.

Test build #94256 has started for PR 21305 at commit ae0d242.

@cloud-fan, I've added a suite for the DataType.canWrite. I still need to add tests for the analyzer rule to make sure it catches any problems and so to validate that AppendData's resolved check. If you want to look at the canWrite suite in the mean time, I think it's ready for review.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1826/
Test PASSed.

Test build #94257 has started for PR 21305 at commit 618a79d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1827/
Test PASSed.

Test build #94257 has finished for PR 21305 at commit 618a79d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94257/
Test PASSed.

Test build #94256 has finished for PR 21305 at commit ae0d242.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94256/
Test PASSed.

Merged build finished. Test PASSed.

LGTM, can you resolve the conflict and address my concern about filling null for nullable missing fields? I think it's ready to go. thanks!

@cloud-fan, I've rebased and updated with the requested change to disallow missing columns, even if they're optional. Thanks for reviewing!

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1887/
Test PASSed.

Merged build finished. Test PASSed.

Test build #94339 has started for PR 21305 at commit e81790d.

LGTM, pending jenkins

Test build #94339 has finished for PR 21305 at commit e81790d.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94339/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1897/
Test PASSed.

Test build #94352 has started for PR 21305 at commit e81790d.

Test build #94352 has finished for PR 21305 at commit e81790d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94352/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1905/
Test PASSed.

Test build #94364 has started for PR 21305 at commit e81790d.

Test build #94364 has finished for PR 21305 at commit e81790d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94364/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1912/
Test PASSed.

Test build #94373 has started for PR 21305 at commit e81790d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1921/
Test PASSed.

Test build #94384 has started for PR 21305 at commit 42d86e1.

Test build #94373 has finished for PR 21305 at commit e81790d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94373/
Test PASSed.

Test build #94384 has finished for PR 21305 at commit 42d86e1.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
              s\"its class is $
case class Uuid(randomSeed: Option[Long] = None) extends LeafExpression with Stateful
case class InSubquery(values: Seq[Expression], query: ListQuery)
trait ExpressionWithRandomSeed
case class Rand(child: Expression) extends RDG with ExpressionWithRandomSeed
case class Randn(child: Expression) extends RDG with ExpressionWithRandomSeed
case class AliasIdentifier(identifier: String, database: Option[String])

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94384/
Test PASSed.

thanks, merging to master!

Thanks for reviewing, @cloud-fan!


[Bug] Apostrophe in episode Description field is rendered as lsquo in RSS index.xml

Expected behavior
Single-quote (apostrophe) in episode description field should build a valid index.xml.
Actual behavior
Apostrophe in episode description field is rendered as &lsquo which is invalid XML and displays an error in chrome as "Entity 'lsquo' not defined" when visiting the rss url.
See: https://html.spec.whatwg.org/multipage/xhtml.html (entity references for characters in XML documents is unsafe if they are defined in an external file (except for <, >, &, " and ').
See: http://www.drdobbs.com/web-development/elimination-of-text-corruption-in-xml/220300907 (XML parsers recognize only five symbols -- & " ' < >. All other valid character entity references (like — é) are not recognizable by XML parsers)
Reproduction Steps
Create an episode md file. Include a single-quote (apostrophe). View the rendered xml and notice the &lsquo. Visit the rendered index.xml url in chrome and see an error message.
Operating System and Version
Windows 7
Web Browser and Version
chrome windows 64.0.3282.140
Hugo Version
v0.36.1 windows/amd64

@mattstratton this is still a problem for us.. every time we publish an episode our rss breaks and I have to remove the apostrophes. Is this a quick fix for you or should I try to dig into the code and try to fix it? Much Appreciated!

I believe this must be resolved, because we have had episodes of Arrested DevOps recently with apostrophes, and they didn't break :)


Add RGBA support to Caret

tl;dr the rest of the codebase accepts RGBA, but Caret hasn't been updated yet
Other areas of the codebase (shapes, gui, the rest of text) have been updated to accept Tuple[int, int, int, int] for colors. However, Caret has not:
https://github.com/pyglet/pyglet/blob/5bc0f80e0446bc4ebb2b381370802f60320c0d8a/pyglet/text/caret.py#L70-L91
If there's no technical reason blocking it, can we add it?

Sure, that's valid. How about doing it the same way as Shapes, so we can support both RGB and RGBA, not breaking backwards compatibility?


Update owserver.sh

Hopefully a fix for the usb issue. Needs testing, as I only have HA yellow, and can't test on another machine at the moment.
May require a carriage return at the end of the file.

Possible fix for issue #9

Thanks for your contribution. At the moment I am preparing Github action workflow so that we can test PR changes without affecting stable code. I will let you know in few more days.

I have implemented proposed change together with few others.
I also introduced three new repo (stable, beta and edge aka dev)
You can read details here:
https://github.com/lrybak/hassio-owserver/blob/master/CHANGELOG.md
Change can be tested with v0.3.1-rc1 on beta repository


Sample config file

I  came across your project as I have Octopus Agile, GivEnergy battery, Solcast and some Solar panels. It is looking for a config file but I can't find a sample one to fill in so I thought I would ask before making one up. It would be helpful to have some steps for newbies to be able to configure and run in the readme. Thanks for your efforts though it looks like it could be a great help if I can get it to work.

Ahh great - I will try and add one to the README (hopefully tomorrow) - please do ping me if I forget!

So, here's a sample config file (I'll get this added to the README soon)
{
  "ApiKeys": {
    "Octopus": "<octopus API key>",
    "GivEnergy": "<givEnergy API key>",
    "Solcast": "<solcast API key>"
  },
  "IncomingMeter": {
    "MPAN": "<incoming meter MPAN>",
    "TariffName": "AGILE-23-12-06"
  },
  "TestMode": true,
  "OutgoingMeter": {
    "MPAN": "<outgoing meter MPAN>",
    "TariffName": "AGILE-OUTGOING-19-05-13"
  },
  "Battery": {
    "CapacityKwh": 8.2,
    "EfficiencyFactor": 0.92
  },
  "Prediction": {
    "MethodName": "LastNSameDayOfWeek",
    "NumberOfDays": 4
  },
  "SolcastSiteId": "<solcast site ID>",
  "TimeZoneName": "GMT Standard Time"
}

Perfect thanks. On 30 Sep 2024, at 17:10, Matt Whitfield @.***> wrote:
So, here's a sample config file (I'll get this added to the README soon)
{
"ApiKeys": {
"Octopus": "",
"GivEnergy": "",
"Solcast": ""
},
"IncomingMeter": {
"MPAN": "",
"TariffName": "AGILE-23-12-06"
},
"TestMode": true,
"OutgoingMeter": {
"MPAN": "",
"TariffName": "AGILE-OUTGOING-19-05-13"
},
"Battery": {
"CapacityKwh": 8.2,
"EfficiencyFactor": 0.92
},
"Prediction": {
"MethodName": "LastNSameDayOfWeek",
"NumberOfDays": 4
},
"SolcastSiteId": "",
"TimeZoneName": "GMT Standard Time"
}
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>


PageAdmin doesn't re-use get_fieldset_placeholders where appropriate

PageAdmin.get_fieldset_placeholders is used by get_fieldsets only, when it would probably make sense for get_form, change_view, and move_plugin to, as well.
This would facilitate an easy way in which one could subclass PageAdmin and modify the list of placeholders presented, in one place.
In case it's not clear, obviously that would involve unregistering Page from the AdminSite and re-registering the new ModelAdmin.
My rationale is thus: As of 2.2, #690 allows the order of Placeholders to be the order in which they are discovered in templates. This is less than ideal if a child template inherits, say, {% placeholder footer %} from its parent, and then declares {% placeholder content %} - the resulting placeholder list has the footer first, even though it may not be the primary edit section for the page. Allowing everything in the PageAdmin to make use of get_fieldset_placeholders would, I think, allow for custom sorting to restore previous functionality (where sorted() was called) which allowed for specific ordering through undocumented naming conventions (ie: priority items could be prefixed with A/B/C or 1/2/3)

changed and added to pull 1163.


Feature: Implement Internationalization (i18n)

Suggested solution
I propose implementing Internationalization (i18n) to support the French language. This enhancement will enable French users to navigate the app in their preferred language, improving accessibility and user experience.

Thanks @RitaDee. We're going to hold off on this for now as it would be a significant effort, and there's other means to reasonably translate the pages into other languages.


Apply on Kobuki flatform

Hello, I'm the user of Kobuki flatform and trying to use this package to my robot. As a beginner, I couldn't find all the things I need to modify from this package. I have a Hokuyo LRF (UTM-30LX). Could you answer or give me the hint? Thank you

Is this a turtlebot? If so, you can get started quickly using https://github.com/googlecartographer/cartographer_turtlebot.
Otherwise, you can find documentation of how to run our stuff with demos here. The backpack 2d demo is probably closest to what you have, though you might need to disable the IMU.
Closing, since this is not a bug report. If you have specific questions about using Cartographer, please post on the mailing list. If you have questions about ROS, I suggest http://answers.ros.org/questions/.


better abstraction for protocol messages

Instead of representing protocol messages as []byte, represent them as instances of a ProtocolMsg struct, containing a ProtocolTag identifying the message type, and a []byte for the payload.
Introduce ProtocolSender interface, containing a SendProtocolMsg method. This is implemented by LocalConnection and LocalPeer, replacing the former SendTCP/BroadcastTCP methods. In the former case the ProtocolMsg is sent to the peer at the other end of the connection, in the latter case it is sent to all peers the local peer is connected to.

Possible points of contention:

I decided to make LocalPeer implement ProtocolSender. Arguably, SendProtocolMsg is less descriptive than BroadcastTCP, but IMO the uniformity is preferable and there is little scope for confusion.

I am passing ProtocolMsg by value instead of reference. Doing so avoids some type noise. It's a tiny struct, so some copying shouldn't cost a lot, and in any case the tcp communication is not on the performance critical path.

I didn't go the whole hog and switch to representing each message as a separate type. Doesn't seem worth it and would have been a bigger change, including a bump in the protocol version.

There's a lot of Protocol in some code fragments now, e.g. ne.conn.SendProtocolMsg(ProtocolMsg{ProtocolNonce, encodedNonce}). I can't think of a way around that; leaving out Protocol in any of the places there would be prone to clashes, since we'd be left with very generic terms.

"Protocol" doesn't seem a very helpful word; almost everything we deal with is a protocol - UDP, TCP, DNS, etc.  It is the Weave protocol, but adding that word will make things more unwieldy.
How about 'Control' - ControlMsg, SendControlMsg?  However I don't like changing the tags to ControlNonce, ControlUpdate, etc.  Maybe just take the prefix off them - just FragmentationReceived, PMTUVerified, etc.

I don't think there is any confusion what protocol we are talking about here.
As for dropping the prefix; the remainder would be too generic and prone to clashes. Think 'Nonce', 'Update', for example.


Feat/proper exit command

Edited exit message to Goodbye! Exiting PropertyMatch as requested...
3 second delay to display exit message to user.

Unsure how to improve code coverage here, so I will merge it for now.


Clone SceneQueryRunner together with _results

Fixes https://github.com/grafana/grafana/issues/84575
Fixes an issue where the DashboardDS would not get the correct data from the source panels SceneQueryRunner._results because the source panel _results buffer would be empty. This affected the dashboard DS in various scenarios but was observed consistently when creating a new dashboard.
In a new dashboard, if you would create a new panel, it's _results buffer in the query runner would be empty. As soon as you saved the dashboard and refreshed the page the buffer would populate and thus the DashboardDS would also work.
The problem was in SceneQueryRunner cloning where we now emit the data in the clone so it can be picked up by the DashboardDS.

This should also fix https://github.com/grafana/grafana/issues/84573 right?


Remove error context handling from string literal hook

Description
This change removes error context handling call from string literal hook. It seems to be better to have this call in engine so it happens on all code paths. Hook signature is simplified because passing parser state is no longer needed.
Engine PR: https://github.com/babelfish-for-postgresql/postgresql_modified_for_babelfish/pull/397
Issues Resolved
#2693
Test Scenarios Covered
Added the crash reproducer to babel_726 test.
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Signed-off-by: Alex Kasko<EMAIL_ADDRESS>

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.006%) to 73.202%

Files with Coverage Reduction
New Missed Lines
%

contrib/babelfishpg_tds/src/backend/tds/tdscomm.c
3
73.33%

Totals

Change from base Build<PHONE_NUMBER>:
-0.006%

Covered Lines:
42821

Relevant Lines:
58497

💛  - Coveralls


Front-end flow with MSISDN login_hint

Sister issue in OpenGateway: https://github.com/GSMA-Open-Gateway/Open-Gateway-Documents/issues/51
In order to use TelcoFinder with MSISDN the authorisation request must include a login_hint of the MSISDN. Best practice mandates that PII cannot be in the URL, so the request will need to be POST, rather than GET.
Current
sequenceDiagram
participant FE as Device App
participant BE as App BE
participant ExpA as Aggregator
participant TF as Telco Finder
FE-->>+ExpA: [2] GET /authorize?response_type=code&client_id=coolApp&purpose=purpose&redirect_uri=app_callback...
ExpA->>TF: [3] ResolveOperator(IP)
TF->>ExpA: [4] Operator

Proposed
sequenceDiagram
participant FE as Device App
participant BE as App BE
participant ExpA as Aggregator
participant TF as Telco Finder
FE-->>+ExpA: [2] POST /authorize<br>body(?response_type=code&client_id=coolApp&purpose=purpose&redirect_uri=app_callback&login_hint=msisdn...)
ExpA->>TF: [3] ResolveOperator(IP)
TF->>ExpA: [4] Operator

Unfortunately,  I am unable to access the OpenGateway link.

it's the same content - just copied here.

Discussion will happen in the OpenGateway issue :(

As per Yesterday's working group call (04/10), the issue will be discussed in the context of the GSMA technical stream, and anything that needs to be piggybacked into CAMARA will be raised later for everyone in CAMARA to review.


timing function not found

My Package.json is:
{
"name": "crop",
"version": "0.0.1",
"private": true,
"scripts": {
"android": "react-native run-android",
"ios": "react-native run-ios",
"start": "react-native start",
"test": "jest",
"lint": "eslint ."
},
"dependencies": {
"@react-native-community/image-editor": "^2.3.0",
"react": "16.13.1",
"react-native": "0.63.3",
"react-native-gesture-handler": "^1.8.0",
"react-native-reanimated": "^1.13.1",
"react-native-redash": "^15.11.1",
"react-native-simple-image-cropper": "^3.1.0"
},
"devDependencies": {
"@babel/core": "7.12.3",
"@babel/runtime": "7.12.1",
"@react-native-community/eslint-config": "1.1.0",
"babel-jest": "25.5.1",
"eslint": "6.8.0",
"jest": "25.5.4",
"metro-react-native-babel-preset": "0.59.0",
"react-test-renderer": "16.13.1"
},
"jest": {
"preset": "react-native"
}
}
ImageViewer.js at line 99 calls react_native_redash_1.timing function, but this function is not available in react-native-dash. This is the error I am getting:
ERROR    TypeError: react_native_redash_1.timing is not a function. (In 'react_native_redash_1.timing(__assign({
from: _this.scale,
to: minScale
}, timingDefaultParams))', 'react_native_redash_1.timing' is undefined)
This error is located at:
in ImageViewer (created by ImageCropper)
in ImageCropper (at App.js:61)
in RCTView (at View.js:34)
in View (at App.js:60)
in App (at renderApplication.js:45)
in RCTView (at View.js:34)
in View (at AppContainer.js:106)
in RCTView (at View.js:34)
in View (at AppContainer.js:132)
in AppContainer (at renderApplication.js:39)

Same issue here.

It seems to be an error with react-native-redash itself.
https://github.com/barrsan/react-native-simple-image-cropper/blob/53bb5c1144d31df45e374cdbadd687901d2ff66a/src/ImageViewer.tsx#L10
I tried with
import { timing } from 'react-native-redash/src/v1'; but i still got errors.
The easiest solution at the moment is to do an older installation of react-native-redash but I still don't know which version is compatible without throw errors.

Well, I fixed the problem but it looks like this project is abandoned...


Multiplayer

This fixes multiplayer. There are still some issues with wearables and vehicles, but avatars seem to work in all cases.
We need to make sure that the transform send doesn't break single player -- right now it seems to be sending NaN values so all of the objects are snapping to 0,0,0 -- if we fix this then we should pull this PR in to stay in sync.

We need to make sure that the transform send doesn't break single player -- right now it seems to be sending NaN values so all of the objects are snapping to 0,0,0 -- if we fix this then we should pull this PR in to stay in sync.

Needless to say, I think that is a bug which can be fixed. I don't think there is ever a reason to tolerate NaNs for transforms. Let's find where they are generated and fix that.


[RAISE-BP] Check -triton-raise-block-pointer output leads to 2D block ops

Add lit test checking that the raised code is lowered using 2d block load operations.
Closes Issue: #1431

@mfrancepillois can we close this one ?

@mfrancepillois can we close this one ?

@mfrancepillois is off, but our plan was to close this PR once we have implemented the alternative that we discussed offline.


Slider: uncontrolled mode

I'm not sure this is necessary because you can easily achieve this by wrapping the Slider in a component that will only manage the state. So I'm closing this for now but I'm not against the idea.