Adjustments Implementation Guidelines SPS 2025

Contact Details
<EMAIL_ADDRESS>Issue category
Refinement
Issue description
Changes with regard to adjustments to Swiss Payment Standards Implementation in Guidelines for Cash Management and Credit Transfer valid from November 2025
Issue reasoning
Compliance with Swiss Payment Standards as per release
Request
Cash Management - Account API
2.1 Adjustment to "Interest"
New element "Interest" can be introduced to represent an account interest statement.:

Level: Entry
Status: optional
Type: enum
Values: [INTE, WHLD, FCIN, OTHR]

2.2 Adjustments to "Account"
Already in place
2.3 Adjustments to "Status"
Not applicable
Credit Transfer - Payment API
2.1 Adjustment to "Use of address information
Use of address information has been revised. Hybrid structure will be introduced and unstructured address will be removed. In addition, the current "postalAddress" object does not comply to the standard. Therefore, i suggest the following changes:

Unstructured address will be removed
Hybrid structure will be introduced
Current "postalAddress" object does not comply to standards. The following elements could be added:

Department [Dept]
Sub Department [SubDept]
Building Name [BldgNb]
Floor [Flr]
Room [Room]
Town Location Name [TwnLctnNm]
District Name [DstrctNm]
Country Sub Division [CtrySubDvsn]

Impact on Account and Payment API

2.4.1 Adjustment to the element "Name" to 140 characters
For the element "Name", the restriction to 70 characters has been lifted. However, this restriction still applies for the payment type "S" (SEPA)
As the maxLength has already been adjusted on some objects only the following changes are required:

PaymentDebtor: Name is currently 70 und must be changed to 140
Description: Restriction for payment type SEPA is 70 characters

Proposed change
<<<<<<< Section As-Is

    PaymentStructuredOrUnstructuredAddress:
      title: Payment Structured or Unstructured Address
      description: Either structured or unstructured address must be set.
      type: object
      properties:
        structured:
          $ref: '#/components/schemas/PaymentStructuredAddress'
        unstructured:
          $ref: '#/components/schemas/PaymentUnstructuredAddress'

========

>>>>>>> Section To-Be

    accountTransactionInterest:
      title: Account Transaction Interest
      type: string
      description: Represents an account interest statement. Corresponds to the attribute _Intrst_ in SPS/ISO-20022
      enum:
        - INTE
        - WHLD
        - FCIN
        - OTHR

-----------------------------------------------------------------------------------------

    PaymentAddress:
      title: Payment Address
      description: tbd.
      type: object
      properties:
        structured:
          $ref: '#/components/schemas/PaymentAddress'

    PaymentAddress:
      title: Address for Payments
      type: object
      description: Specifies the address details.
      required:
        - townName
        - country
      properties:
        streetName:
          type: string
          maxLength: 70
          description: The street name. Corresponds to the attribute _StrtNm_ in SPS/ISO-20022.
          example: Rue de la gare
        buildingNumber:
          type: string
          maxLength: 16
          description: The building number. Corresponds to the attribute _BldgNb_ in SPS/ISO-20022.
          example: '24'
        postCode:
          type: string
          maxLength: 16
          description: The post code. Corresponds to the attribute _PstCd_ in SPS/ISO-20022.
          example: '2501'
        townName:
          type: string
          maxLength: 35
          description: The town name. Corresponds to the attribute _TwnNm_ in SPS/ISO-20022.
          example: Biel
        country:
          type: string
          maxLength: 2
          description: The counterparty country. Corresponds to the attribute _Ctry_ in SPS/ISO-20022.
          example: CH
        addressLine1:
          type: string
          maxLength: 70
          description: Additional address information, which cannot be supplied in structured elements. Corresponds to the attribute _AdrLine_ in SPS/ISO-20022.
          example: Carribean At Keppel Bay
        addressLine2:
          type: string
          maxLength: 70
          description: Additional address information, which cannot be supplied in structured elements. Corresponds to the attribute _AdrLine_ in SPS/ISO-20022.
          example: 05-66
-----------------------------------------------------------------------------------------

    PaymentDebtor:
      title: Payment Debtor
      type: object
      description: The debtor of a payment.
      required:
        - name
        - postalAddress
      properties:
        name:
          type: string
          maxLength: 140
          description: The name of the debtor of a payment.
          example: Hans Muster

Affected API's
Both
Code of Conduct

[X] I agree to follow this project's Contribution Guidelines

Meeting Notes 12.12.24
Update on following elements:

Element "interest" will be moved to the discussion with respect to harmonization
Unstructured address: One PaymentAddress object will encompass structured and hybrid address. There is no need to implement all additional elements
Thomas W. (bexio) asks if the AdressLine can be represented as array. Dominik will check.
Name in all objects will be extended from 70 to 140 characters.

@simonmeyerm will prepare the Pull Request which will be discussed on next meeting for discussion and approval.


How do I generate segmentation maps?

Great tutorial! I was wondering is there a recommended method to generate the segmentation masks used for stylising?
Thanks!

@AdarshMJ Hi，I wondering that which segmentation tools do you use?


encoding or decoding problem?

If there was a sepecial char, such as copyright symbol (© )，the program gets an error.
No JSON object could be decoded

I'm investigating this issue and I will fix this soon.

Thank you so much. If it's convient, is there any chance to develop a feature to read source text from TXT file and write translation text to another TXT? The simplest one is OK.

I think it's out of scope for googletrans, but I will consider implementing it.

I fixed this issue with the commit above. Please try upgrading to googletrans 2.1.1 where this issue is fixed.

Thank you so much.


Touch zone misplacing in mobile fullscreen

Version

Phaser Version: 3.55.2

Operating system: Windows 10 x64 2004

Browser:

Description

Problem actual only for mobile and fullscreen. Bug was reproduced on Samsung Galaxy M31 and Redmi Note 8t.
Steps to reproduce:

Create graphics and hit area with same sizes.
Put graphics into container.
Enable interactive for graphics with corresponding hit area.

Expected: click zone is equal to graphics.
Result: click zone is displaced a bit.
Bug also reproduces if set interactive for container.
Example Test Code

https://codepen.io/necrokot/pen/QWMEGrx
If bug don't reproduces on codepen you can clone repo and run
npm run serve
to launch local web server.
Additional Information

I tried on my own phone using the codepen and I cannot reproduce this error as described. The click zone seems to be exactly as the graphic indicates.

Tested this on a Samsung Galaxy M32 and it works as I would expect. However, you cannot start fullscreen on 'pointerdown', it has to be on 'pointerup'. Here is the fork I was using to test with (with an added hit counter):
https://codepen.io/photonstorm/pen/KKeQoVM?editors=0010
https://user-images.githubusercontent.com/164476/203306337-1d45cb1b-d0d2-49af-918a-43cdd5d273a9.mp4

Hey,
You can watch any tutorial on YouTube it may help you to solve your problem. You can also try Alight motion app on your iPhone.


Project icons

When you create a new project in Guppy, it asks you to select an icon.
Once the project is created, though, there is no way to update that icon.
For imported projects, it's even worse; you just get a random color and the first letter of the project name.
Ideally you should be able to change icons whenever, as well as upload your own, or choose to automatically use the favicon for the project (especially for imported ones).
This issue should be done, ideally, after #28, so that the new icon functionality can be used in both places.
This issue encloses several tasks:

Add an "UploadProjectIcon component to select an image
Copy that image to a new .guppy directory in the project (I think it has to live in the same directory as the project..?)
Add a way to select the project favicon instead
Add these new functions to the new-project wizard
Add these new functions to the configuration pane in #28

My fork handles that but I cannot easily create a PR since there are tons of merge conflicts. But here is the relevant code for the one who wants to tackle this: https://github.com/skpm/guppy/blob/skpm/src/components/ProjectIconSelection/ProjectIconSelection.js#L25-L46

Is this issue still open? it would be my first time contributing but would like to try!

@syn228 yes, this is still open and no one is working on it.
Great to hear that you like to help. Please have a look at our contribution info and the dev docs here.
So it's all yours. If you're having any questions please let us know. You can also join us on Gitter so we can chat there.
Issue #28 is already on master.  So you can add the uploading component to the ProjectConfigurationModal & the CreateNewProjectWizard.  I would start by adding to ProjectConfigurationModal as this is easier to understand. That dialog is accessible with the gear icon in the UI.
I think this could be an UploadProjectIcon component in the modal that contains a button to display a file dialog. Maybe we can pick a better name as it's not uploading anything. Maybe SelectCustomProjectIcon would be better.
To get an idea how a file dialog can be opened you can have a look at src/components/CreateNewProjectWizard/ProjectPath method updatePath.
The saving of the selected icon will require a new Saga save-project-icon.saga to handle the copying to the .guppy folder.


IRGen: Fix outlining when an opaque type resolves to a fixed size type

rdar://54515130

@swift-ci Please test


feat: add scan target to vulnerabilities

Description
This PR aims to add the target scan field from trivy to the vulnerabilities in the vulnerabilityreport
If I've forgotten anything, I'd love to hear about it
Example

Related issues

Close #106

Checklist

[x] I've read the guidelines for contributing to this repository.
[x] I've added tests that prove my fix is effective or that my feature works.
[ ] I've updated the documentation with the relevant information (if needed).
[ ] I've added usage information (if the PR introduces new options)
[ ] I've included a "before" and "after" example to the description (if the PR is a user interface change).

@mycodeself thank you for the contribution , one comment , could you please update the vulnerability CRD example in docs

@mycodeself Thank you for the contribution.


Implement single playback message box

I heard a call on an old tape that I thought was a cool idea.
The caller is prompted to record the new message (limited to like 30s or something). After they are done recording the new message, they immediately hear playback of the old message. After playback, the old message is deleted and their recording becomes the new message.
I couldn't think of a great name for this right now, but it's like a one-shot anonymous/random voicemail.
The prompt goes something like:
"Please record a message for the next caller, up to 30 seconds. After you have recorded your message, you will hear the previous caller's message and then it will be deleted."
Challenges/Considerations:

Recording can't be too short. Maybe 10s minimum or something?
Recording can't be silence or mostly silence.
Two callers at the same time

Inspiration example at 36:04 on side 1 of this tape: https://archive.org/details/noise-arch_tentacon/tentacon_1.mp3

See also #286

Can't play content from users that hasn't been vetted, this is blocking a few other ides, see #574.

Can't play content from users that hasn't been vetted, this is blocking a few other ides, see #574.

Ah yeah bummer. I forget that we can't have nice things. Well, happy to reopen/reconsider once we have moderation.

The content vetting is implemented for the challenges, and it won't be hard to generalize it to other content.


ci: Support for limited tests run from PR description

Specify the specs we want to run, in a plain code fence, where the first line has to exactly be /test. The remaining lines have to be one spec file per line.
Like this:
/test
cypress/e2e/Regression/ClientSide/Fork/ForkApplication_spec.ts
cypress/e2e/Regression/ClientSide/JSLibrary/Library_spec.ts

It's not possible to run with tags and specs and the same time. This will need a slightly larger effort. But we'll get there.
The status message shows spec files like they are space-separated, and isn't very easy to read. Don't take it too seriously yet, we'll improve.
Globs should also work fine. The spec content, almost directly lands into the --spec argument of Cypress. See docs at https://docs.cypress.io/guides/guides/command-line#cypress-run-spec-lt-spec-gt.
Multiple runners is disabled for this, have to solve it separately. The ci-test-limited.yml also doesn't do multiple runners either.

[!WARNING]
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9803353429
Commit: e99ae387c9a239ae51155af45977c285474cfbaf
Cypress dashboard.
Tags:
Spec: cypress/e2e/Regression/ClientSide/Fork/ForkApplication_spec.ts
cypress/e2e/Regression/ClientSide/JSLibrary/Library_spec.ts
It seems like no tests ran 😔. We are not able to recognize it, please check workflow here.
Fri, 05 Jul 2024 05:20:23 UTC

Summary by CodeRabbit

Chores

Enhanced GitHub Actions workflows to improve test specification handling and reporting.
Refactored tag parsing logic in scripts for more accurate and informative outputs.

@sharat87 I am not sure if I got the message in the PR description correctly. The question is -- we're getting the message that "no tests ran", is that expected because we're only running individual specs right now?
I don't see a problem if this is actually the case, as only power users would use the spec list way of testing and would very likely know that the "no tests ran" message is a consequence of not running tags.

@sharat87 one small thing, can we use less machines based on number of specs to run? we have reduced to only one machine for ci-test-limited. Before it used to be three and majorly only one was required, wasting 2 resources.

Thanks for checking this out folks! ❤
@riodeuno, I should've mentioned this, please ignore the Cypress report part of the PR description. It's not behaving correctly because there's changes in pr-automation.yml that have to be in release branch before the rest of the functionality in this PR can take any affect. I've verified that part before opening this up for review. I can force-merge the changes in just the pr-automation.yml file, and then test this PR here. Then the Cypress report should be more accurate.
@ApekshaBhosale, yes, indeed. This is how ci-test-limited is also operating today. It has no matrix in it, and it only runs on one runner, irrespective of how many spec files we're running. So I kept it to that in this PR. I want to add support for multiple runners for this, in a future PR. But since this aligns with what we have today, I preferred to keep the PR focused just to that.
Let me know what you guys think! 🙏


Strange syntax hiliting in md documents

Prerequisites

[ ] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
When using a javascript code block in a mark-down document, which contains a non-fully formed function (ie with {}), the syntax hiliter does not correctly hilite syntax after the code block closes.
Steps to Reproduce
Place the following in a markdown editor window

function somePrototype( someArgument); // returns somethingElse

this should be hilited
<<<
Expected behavior:
I expect the contents of the javascript code block to not affect the syntax hiliting of the rest of the document.
Actual behavior:
The the syntax colorer seems to stop functioning until another javascript code block is included with curly braces, for example

function somePrototype( someArgument); // returns somethingElse

this should be hilited
{}

now this is hilited correctly
<<<
A picture of the strange behaviour:

Reproduces how often:
100%
Versions
atom --version
Atom    : 1.22.0
Electron: 1.6.15
Chrome  : 56.0.2924.87
Node    : 7.4.0
Mac OS X 10.12.6
Additional Information
Seems to work fine in the HTML MarkDown preview though.

Thanks for taking the time to contribute!  I think this might be a duplicate of or at least similar to issues like https://github.com/atom/language-gfm/issues/171 so you can subscribe there for updates if you'd like.

Because we treat our issues list as the Atom team's backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn't an exact duplicate but is closely related.
For information on how to use GitHub's search feature to find out if something is a duplicate before filing, see the How Can I Contribute? section of the Atom CONTRIBUTING guide.


Fix for Memory Leak. iOS. RNVectorIconsManager

Released errorRef object which is not managed by ARC to fix memory leak

Environment
Xcode 14.3, iOS 16.4
Opened issue
https://github.com/oblador/react-native-vector-icons/issues/1499

Description
Into loadFontWithFileName func we call CTFontManagerRegisterGraphicsFont whitch have parameter with type  CFErrorRef * which is not managed by ARC.

Proposed fix
Proposed fix in RNVectorIconsManager.m:
To avoid memory leak we need to release that errorRef varible after usage.
RCT_EXPORT_METHOD(loadFontWithFileName:(NSString *)fontFileName
                  extension:(NSString *)extension
                  resolver:(RCTPromiseResolveBlock)resolve
                  rejecter:(RCTPromiseRejectBlock)reject)
{
  NSBundle *bundle = [NSBundle bundleForClass:[self class]];
  NSURL *fontURL = [bundle URLForResource:fontFileName withExtension:extension];
  NSData *fontData = [NSData dataWithContentsOfURL:fontURL];

  CGDataProviderRef provider = CGDataProviderCreateWithCFData((CFDataRef)fontData);
  CGFontRef font = CGFontCreateWithDataProvider(provider);

  if (font) {
    CFErrorRef errorRef = NULL;
    if (CTFontManagerRegisterGraphicsFont(font, &errorRef) == NO) {
      NSError *error = (__bridge NSError *)errorRef;
      if (error.code == kCTFontManagerErrorAlreadyRegistered) {
        resolve(nil);
      } else {
        reject(@"font_load_failed", @"Font failed to load", error);
      }
    } else {
      resolve(nil);
    }
    if (errorRef) {
        CFRelease(errorRef);
    }
    CFRelease(font);
  }
  if (provider) {
    CFRelease(provider);
  }
}

Here we add
if (errorRef) {
   CFRelease(errorRef);
}

Reproducible Demo
Test project with memory leak https://github.com/kuserhii/ReactNativeVectorIconMemoryLeak

@oblador This looks reasonable but I don't know enough about swift and couldn't find any docs on who is responsible for the memory release. Can you take a look?


feat(ssg): Ignore Dynamic Route

Resolves https://github.com/honojs/hono/issues/1966
We have added an implementation that excludes certain types of routes - specifically, wildcard, path parameters, and regex-based routing - from the SSG (Static Site Generation) process.
It's important to note that this does not take into account the ssgParams middleware. Depending on the timing of the merge, we can include support for this middleware in this PR if necessary.
Author should do the followings, if applicable

[x] Add tests
[x] Run tests
[x] yarn denoify to generate files for Deno

Let's complete this PR first, and merge it into v4. I left a comment; please take a look.

Hi @watany-dev
I've merged #1960 into v4 now, but the CI fails:
https://github.com/honojs/hono/actions/runs/7553089110/job/20563202188
I think isDynamicRoute causes the mismatch. Could you see it?

@yusukebe
In the short term, revert my commits and it will be cured.
If I fix this, I will need to maintain hono/dev and identify the route where ssgparam is set and do some additional processing. This will take a bit of time.


Feature Request: Restart button

Is your feature request related to a problem? Please describe.
Option to enable Reboot after completed enrollment

Thanks for the Feature Request, @mvught.
Is something like Forced and Dismissible Log Out, Restart or Shut Down Prompts over-kill?
(I'm thinking of just adding these options to Parameter 6: Completion Action.)

Hallo Dan,
It would be nice to precent the enduser with a option to restart after enrollment complete!!!
Also thanks for the hard work you put in this project

Greetings, @mvught and @riddl0rd!
What level of interest do either of you have in testing in-progress, not-for-production code?

@mvught and @riddl0rd:
Will you both please test drive 1.3.1? (Located in the issue-15 branch.)
(As you can imagine, testing forced-restarts is fairly inconvenient.)
Version 1.3.1 (17-Nov-2022)

Added a completionAction function (i.e., Wait, Sleep, Logout, Restart or Shutdown)
Removed jamfDisplayMessage function and reverted dialogCheck function to use osascript (with an enhanced error message)
Swapped blurscreen for moveable in Debug Mode
Replaced "Installing …" with "Updating …" for recon-flavored trigger
Changed "Updating Inventory" to "Computer Inventory" in final listitem
Increased Debug Mode speed

Hi @dan-snelson Tested out 1.3.1 using the default wait completionAction, but after clicking the Quit button the script continues to run and has to be manually terminated. The final output when it hangs is Honoring wait behavior

Thanks for the feedback, @iDrewbs.
Let me double-check and better document what I'm observing.

I’m interested in this feature too, happy to help.
could this be extended to the failure dialog if presented?

Just committed a change; please re-re-try now, @iDrewbs.
Thanks for the offer, @master-vodawagner; please do.
Yes, this change has been added to both successful and failure dialogs.
Currently, a hard-coded wait command has been added here and here.
(To me, if anything fails, the user should be required to manually acknowledge the failure; I'm interested in every one's feedback.)

Made another commit; thanks for all the assistance.

Thanks for the feedback, @jared-a-young.

So, on a successful completion, if you're using Restart for completionActionOption, you'd also like to require user-interaction? (My initial thought is that for this use-case, you'd use Restart Confirm for completionActionOption.)

Good idea on having the button reflect the setting of completionActionOption; I'll take a look.

When capturing an Asset Tag and clicking Quit, ignore the completionActionOption.

When using Restart for completionActionOption via Self Service, a Cocoa error 132001 is observed.

Thanks, both!
Just to expand on this slightly - the restart/logout confirm parameter relies on the user to hit the relevant option in the macOS pop-up dialogue - which they could easily dismiss (I don't trust end users one bit!)
Using just the restart or logout parameter ensures that the action requested is carried out but it would be great if it only did it once the user clicked the button, which displayed the text of what was going to happen next i.e. logout or restart.
I can envisage new employees not paying attention to their macs and then turning back around to see the mac restarting or logged out without expecting that to happen (then contacting us needlessly to say 'hey this just happened, is everything ok?')

1.3.1 RC2

Signficantly enchanced Completion Action options

:white_check_mark: Addresses Issue 15 (thanks, @mvught, @riddl0rd, @iDrewbs and @master-vodawagner)
:man_dancing: Dynamically set button1text based on the value of completionActionOption (thanks, @jared-a-young)
:new: Three new flavors: Shut Down, Restart or Log Out

:rotating_light: Forced: Zero user-interaction

Added brute-force killProcess "Self Service"
Added hack to allow Policy Logs to be shipped to Jamf Pro server

:warning: Attended: Forced, but only after user-interaction (thanks, @owainiorwerth)

Added hack to allow Policy Logs to be shipped to Jamf Pro server

:bust_in_silhouette: Confirm: Displays built-in macOS user-dismissible dialog box

Sleep
Wait (default)

Improved Debug Mode behavior

:bug: DEBUG MODE | now only displayed as infotext (i.e., bottom, left-hand corner)
completionAction informational-only with simple dialog box (thanks, @_____?)
Swapped blurscreen for moveable
General peformance increases

Miscellaneous Improvements

Removed jamfDisplayMessage function and reverted dialogCheck function to use osascript (with an enhanced error message)
Replaced "Installing …" with "Updating …" for recon-flavored trigger
Changed "Updating Inventory" to "Computer Inventory" for recon-flavored listitem
Changed exit code to 1 when user quits "Welcome" screen
Changed welcomeIcon URLs
Add way too many emojis to ChangeLog

I did some testing of the new Completion Action Options in RC2:
CompletionActionOption Feedback:

Wait - When using this option, Button1 text says "Wait" at the end, which could confuse the user thinking they need to wait for something. It would be better to read "Quit" or "Close"
Log Out Confirm - The logout confirmation prompt is triggered before clicking the "Log Out" button. Should this be updated, so the logout confirmation is triggered once the button is clicked?
Restart Confirm - The Restart confirmation prompt is. being triggered before clicking the "Restart" button. Should this be updated, so the Restart confirmation is triggered once the button is clicked?
 Should this be updated, so the Shut Down confirmation is triggered once the button is clicked?
Shut Down Attended - This works as expected. However, the progresstext at the bottom includes "Complete! Please restart..." instead of "Complete Please Shut Down"
Shut Down - This works as expected, however, the progresstext at the bottom includes "Complete! Please Restart...". It should probably indicate something like "Complete! Shutting Down your Mac..."

The remaining options work as expected:

Sleep - This works great
Log Out Attended - This works great.
Log Out - this works great.
Restart Attended - This works great.
Restart - this works great.

Thanks for your thorough testing and detailed feedback, @iDrewbs!
If I haven't warn out my welcome, please test 1.3.1 RC3. (Also paging @mvught, @riddl0rd, @master-vodawagner and @owainiorwerth.)
I previously observed your findings with the "Confirm" flavors, but couldn't replicate them just now on physical hardware running macOS 13.0.1 (22A400) with Jamf Pro 10.42.1.

Just tested all of the new options and everything looks great! All the verbiage matches the CompletionActionOptions perfectly.
The behavior with the "Confirm" flavors may just be a symptom of my test Mac since I have been doing a lot of various testing. I'll try it with a few more, but I don't think it needs to be considered a blocker.
Let me know if I can do any further testing!

Just tested the Restart Confirm option configured within the paramater 6 option in the policy, and it works perfect with macOS 13.0.1.
Also will test out the other triggers in the morning.
Thank you!

Feature Request completed with v1.3.1

Thanks for the feedback, @owainiorwerth.
What behavior are you seeing if your run v1.5.0-rc1 as-is via Terminal?

OK did a fair bit of testing today with different setups but concluded that...
Restart and Log Out Attended work fine if running the script locally (in both Debug True /
or False) - hard coded variables.
Restart and Log Out Attended work fine if manually calling the policy via Self-Service (in both Debug True /
or False) - hard coded variables.
Restart and Log Out Attended don't work if automatically calling the policy, which kicks in at Enrollment Complete in our environment.  It's a simple policy which just calls the script - hard coded variables. The swift dialog pkg is installed at pre-stage enrollment.

Thanks for the additional details, @owainiorwerth.
Please see Implementation Notes; I'm not testing using enrollmentComplete (but right off I can't see why it wouldn't work).
Will you please open a fresh issue? Thanks.


Put 21 at 30% to 22 on production

Signed-off-by: John Molakvoæ (skjnldsv<EMAIL_ADDRESS>

Closing for circles


PHP support

Check for existing issues

[X] Completed

Language
PHP
Tree Sitter parser link
https://github.com/tree-sitter/tree-sitter-php
Language server link
No response
Misc notes
No response

Regarding the LSP: This is basically the goto LSP for PHP https://intelephense.com/
It's freemium and closed source but available here: https://www.npmjs.com/package/intelephense
The reference implementation for VSCode is available here https://github.com/bmewburn/vscode-intelephense/tree/master
Another candidate is the LSP by felix becker. It's open source, but it hasn't been updated in 5 years. Se source is available under https://github.com/felixfbecker/php-language-server
Would love to see PHP language support since it is still one of the core technologies of todays web.

Other LSP options are https://phpactor.readthedocs.io/en/master/usage/language-server.html and https://serenata.gitlab.io/

I'm sorry for spamming this, but i'm also really interested in PHP support. I think the number of reactions doesn't show this issues' importance and figured i just added a message to it.
Think of this as a +1 :)

I want to move to zed for at least some basic testing but it is missing a lot at the moment.  Much I can get along w/o however lack of at least basic php support or a plugin interface to roll my own tools does not allow me to stay for long.  Looks like I am jumping back into vim for another 3-6 months, I will peek in from time to time.

+1 for PHP support, It was actually very surprising to realize there was no support for php out of the gate

I'm shocked there's actually no PHP support. :O

Oh yes, support for Laraval would be wonderful. Just to add my bit, I have used intelephense since the beginning and it's just perfect.
Maybe also built-in support for https://github.com/phpstan/phpstan/? This would also enhance static analysis of PHP code and especially Laravel applications.

bump

Looking forward to using Zed once php is supported !
Long time Sublime Text user here, switched to vscodium some months ago, i would be pleased to get that speed feeling back 😜

I just want to remind people that leaving comments such as +1 or bump will just cause us to lock the thread. We understand that there's an interest in PHP support (like many other languages) and the best way to show interest is up add react with an 👍 on the original issue. Bumping the thread will not make us work faster.
Whenever there's news to share, I'll be the first one to say so. 🙂

Many apologies - I did bump this thread thinking it had been overlooked. I will await your news regarding PHP support!

I am working on this right now, already got syntax highlighting going. :)

@osiewicz please let me know if I can contribute to this anyway.

This just got merged; Stay tuned for tomorrow's Preview release (and next week's stable) y'all. :)

This just got merged; Stay tuned for tomorrow's Preview release (and next week's stable) y'all. :)

How do we configure php intelephense? I need a place to configure my licence keys to it.

I have a little question, how do we configure php intelephense? I need a place to configure my licence keys to it.

Looks like this is done by placing a magic file in a specific spot...
cc: @osiewicz

There used to have the location mentioned in one of support documents, but looks like Support now points to Github issues.
Currently, the best way to set the license key is to save it to $HOME/intelephense/licence.txt.
https://github.com/bmewburn/vscode-intelephense/issues/2592

Even better, thank you @sunilshenoy !

There's a very important problem, zed doesn't recognize variable start with symbol $ when typing, no suggestion list popup.

@xpader there is no need for suggestion list in this case. You can create a license.txt document and paste you license key in it.
E.g

@xpader there is no need for suggestion list in this case. You can create a license.txt document and paste you license key in it.
E.g

Does this actually change something for you? I still miss the premium options..

@RemcoSmitsDev I didn't try again, because Zed can't even prompt PHP variables normally.

@RemcoSmitsDev I didn't try again, because Zed can't even prompt PHP variables normally, I think that's because php variable name not start with the letter, it's start with a symbol $, Zed doesn't take this into account.

Ahh oke, I created a issue for this problem. Can you give it a try for me so I know if other people have the same issue that the premium options do not work after creating the license.txt

@RemcoSmitsDev I tried put my license key into path $HOME/intelephense/licence.txt, real path is /Users/myusername/intelephense/licence.txt and restart Zed, it's not work, php support in zed still no premium features.

@xpader Thanks for testing it for me!
I assume they will look into this, but keep in mind PHP support is not their main focus. So give them some time to look into this and they will deliver.

Hey,
Yeah, as @RemcoSmitsDev said, I will get back to it as soon as I can (which should be once new search UI ships in the following Preview); in the meantime, I wholeheartedly appreciate issues on the matter though!

@osiewicz any updates on this?

Not yet I'm afraid. :/

https://intelephense.com/faq.html notes that the file must be named licence.txt, not license.txt (note the c, rather than the s; this is British spelling vs American spelling).


jenkins trigger for https://github.com/SpiNNakerManchester/SpiNNUtils/pull/284

only fails where spalloc allocation blocked.


feat(build): #188 registry of projects

Add a registry of Makes projects so people
can benefit from aliases

@blaggacao with this people can do $ m f and $ m f@rev instead of the long $ m gitlab:fluidattacks/product. If you want, you can add your projects here too. The benefit of being a pioneer is that pretty much all slots are free!

I've seen that: this is a nice addition. Though I guess for our purposes, we might actually rather enforce repo boundaries "hard" or otherwise populate an internal registry if at all.
The next pressing general issue for me is mimick a mind's decision tree via cli completion:

wanna lint? -> lin<tab>
python? -> p<tab>


Very big bug

Congratulations on the excellent work.

Congratulations on the excellent work.

Thank you! feel free to follow me if you wanna check my other project i do some clone of other social networks if you want


Landing page refactor

Description

Related Issue
#326

Changes Made

Screenshots

Checklist

[ ] I have tagged the issue in this PR.
[ ] I have attached necessary screenshots.
[ ] I have provided a short description of the PR.
[ ] I ran yarn build and build is successful
[ ] My code follows the style guidelines of this project.
[ ] I have added necessary documentation (if applicable)

legendary so far


Fix documentation warnings.

Thanks for the fixes, but what warnings where you seeing ?

I think it might have something to do with having an obj-c project since the warning is coming from the generated iOSDFULibrary-Swift.h file, but is my Xcode screenshot:

Ofcourse! That makes sense, thanks a lot 👍

Will be published in 3.0.3 in few moments.

Released in 3.0.3.


Feature Immportance chart with selected feature names with scores

Hi @cerlymarco ,

How do  I get feature names with scores like this?  (Traditional Xg-Boost)
And what will be the X-axis scoring scale for that?

img-src : https://user-images.githubusercontent.com/42869040/162376574-03869b81-f11e-4d1f-8bea-eddb714d39b0.png
Thanks
Originally posted by @VinayChaudhari1996 in https://github.com/cerlymarco/shap-hypetune/issues/4#issuecomment-1092483163

Hi, u can reproduce this plot in a very straightforward way. Below is a dummy example:
import numpy as np
import pandas as pd
import matplotlib.pyplot as plt
from shaphypetune import BoostRFE
from sklearn.model_selection import train_test_split
from sklearn.datasets import make_classification
from xgboost import *

X, y = make_classification(n_samples=6000, n_features=20, n_classes=2,
                                   n_informative=4, n_redundant=6, random_state=0)

X = pd.DataFrame(X, columns=[f"c{c}" for c in range(X.shape[1])])

X_train, X_valid, y_train, y_valid = train_test_split(X, y, test_size=0.3, shuffle=False)

clf_xgb = XGBClassifier(n_estimators=150, random_state=0, verbosity=0, n_jobs=-1)

model = BoostRFE(clf_xgb, min_features_to_select=1, step=1)
model.fit(X_train, y_train, eval_set=[(X_valid, y_valid)], early_stopping_rounds=6, verbose=0)

selected_features = model.support_
feature_importance = model.estimator_.feature_importances_
sort_idx = feature_importance.argsort()

plt.barh(X.columns[selected_features][sort_idx], feature_importance[sort_idx])
plt.xlabel("Xgboost Feature Importance")

According to XGBOOST DOC, the "x-axis"  represents the feature importance values obtained with  “gain”, “weight”, “cover”, “total_gain” or “total_cover” criteria.
That's all.
If u support the project don't forget to leave a star ;-)

Hey @cerlymarco  Thanks a lot :) , I have a few questions,

Does the X-axis is normalized to (0-1 aggregated scale) for all “gain”, “weight”, “cover”, “total_gain” or “total_cover”?

In default Xg-boost what is the default X-axis scale type, it did not seem to normalize at all?
so what is it is actually?  gain/weight/cover/total_gain/total_cover

I tried this for xgboost before, but for now, I just changed
fit_model_obj.feature_importances_[sorted_idx] TO ---> fit_model_obj.estimator_.feature_importances_[sorted_idx]
Is it the right approach for XG-boost and BORUTA?

Thanks.


getblockheader is not exposed

getblockheader  is an important RPC call that is not exposed. At first glance it looks the same as getblock and dropping the tx array, but there's an important difference:
elsa@winter:~$ bitcoin-cli getblockheader<PHONE_NUMBER>00000000f37fddab6ae59b06d55c9949c4bf35151b7776ff551897
{
  "hash": "000000000000000000f37fddab6ae59b06d55c9949c4bf35151b7776ff551897",
  "confirmations": 100001,
  "height": 329936,
  "version": 2,
  "versionHex": "00000002",
  "merkleroot": "48786f412860f93607fd2b67bfc32d1c905c83da12efd35f5718b38da44b296b",
  "time":<PHONE_NUMBER>,
  "mediantime":<PHONE_NUMBER>,
  "nonce":<PHONE_NUMBER>,
  "bits": "181bc330",
  "difficulty":<PHONE_NUMBER>2.41841,
  "chainwork": "00000000000000000000000000000000000000000002ba5d1b2f3f765cff293c",
  "previousblockhash": "00000000000000000b954ce608c45c9229c3d8e0f8f710e5663e0bb9091d33e1",
  "nextblockhash": "000000000000000000657614104babe20c0f76066c288c0b849504ea11f7af6e"
}
elsa@winter:~$ bitcoin-cli getblock<PHONE_NUMBER>00000000f37fddab6ae59b06d55c9949c4bf35151b7776ff551897
error code: -32603
error message:
Block not available (pruned data)

Does #91 work for you?

Indeed it does, thanks!

Thanks for testing. The issue will be closed when the PR is merged.


[EventRequest] VendEntryEdit.Codeunit.al (codeunit 113 "Vend. Entry-Edit")

Hi MS,
Please help us in migrating our verticalized solution by adding below events in VendEntryEdit.Codeunit.al Table.
Standard Code

Modified Code

Event Signature

Thanks
SUD

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


[Rewrite] Use i18n for localization

Makes sense to have the i18n library do a lot of the work that I would have to do manually.
Not a breaking change, but it would prove difficult to rewrite all the commands again.

Moved to ideas on idea board


Auto formatted python action

Introduce a github action to check python formatting for all PRs being submitted to main, in order to align formatting.

I think this is solving the wrong problem.
Rather than "reformatting" the entire repo, making future diffs unintelligible, I'd rather see a GitHub action that enforces the current format, rather than switching formats entirely.

I think this is solving the wrong problem.
Rather than "reformatting" the entire repo, making future diffs unintelligible, I'd rather see a GitHub action that enforces the current format, rather than switching formats entirely.

@m00sey what is the current format(er)?
If the current format(er) is well known then we can apply a check for it. If it is not well known then if we can transition it to a well known format then it is easy for every PR diff to be well formatted, making a diff highlight only content changes (which is ideal)

I think this is solving the wrong problem.
Rather than "reformatting" the entire repo, making future diffs unintelligible, I'd rather see a GitHub action that enforces the current format, rather than switching formats entirely.

@m00sey I've updated the title, the action only checks the formatting now (enforcing well formatted PRs). It does not try to format it for you any longer. That was discussed on https://github.com/WebOfTrust/keria/pull/271 and I had updated it earlier today when I realized that auto-formatting was overkill.

I think this is solving the wrong problem.
Rather than "reformatting" the entire repo, making future diffs unintelligible, I'd rather see a GitHub action that enforces the current format, rather than switching formats entirely.

@m00sey what is the current format(er)? If the current format(er) is well known then we can apply a check for it. If it is not well known then if we can transition it to a well known format then it is easy for every PR diff to be well formatted, making a diff highlight only content changes (which is ideal)

The current formatting checks are in the CI file:
https://github.com/WebOfTrust/keria/blob/c83904d62b908e5f030bbf7f957d397cd259035f/.github/workflows/python-app-ci.yml#L35
Anything proposed down this route should start here.

I think this is solving the wrong problem.
Rather than "reformatting" the entire repo, making future diffs unintelligible, I'd rather see a GitHub action that enforces the current format, rather than switching formats entirely.

@m00sey what is the current format(er)? If the current format(er) is well known then we can apply a check for it. If it is not well known then if we can transition it to a well known format then it is easy for every PR diff to be well formatted, making a diff highlight only content changes (which is ideal)

The current formatting checks are in the CI file:
https://github.com/WebOfTrust/keria/blob/c83904d62b908e5f030bbf7f957d397cd259035f/.github/workflows/python-app-ci.yml#L35
Anything proposed down this route should start here.
E9: Syntax Errors - These errors occur when there is an issue with the syntax in the Python code, such as a missing colon, unmatched parentheses, or other fundamental syntax mistakes. F63: Problem with Import - This code indicates that there is a problem with an import statement, typically an issue with module-level import. F7: Errors related to function definitions - This includes issues such as missing arguments in function definitions or problems with lambda functions. F82: Unused local variable - This error occurs when a local variable is defined but not used anywhere in the function or code block.
Ignoring: E7: Syntax errors related to tokenization - This error indicates issues during the tokenization process, often related to unmatched parentheses or brackets. F841: Local variable assigned but not used - This occurs when a local variable is assigned a value but is not used in any operations within the code block. E301: Expected 1 blank line, found 0 - This error is raised when there is not a blank line after a function or class definition. E302: Expected 2 blank lines, found 1 - This error occurs when there should be two blank lines before a function or class definition, but there is only one. E303: Too many blank lines (3) - This error occurs when there are more than two consecutive blank lines in the code.
https://flake8.pycqa.org/en/latest/

The enabled rules wouldn't help enforce formatting issues for PRs. It is leveraging the syntax linting checks for flake8, and not providing formatting checks. To help distinguish between linters and formatters this is a decent quick read https://py-vscode.readthedocs.io/en/latest/files/linting.html

Okie - just trying to give you a jumping off point.
You managed to create PRs without mass reformatting previously - https://github.com/WebOfTrust/keria/pull/254/files
Maybe you should just go back to that workflow?

Okie - just trying to give you a jumping off point.
You managed to create PRs without mass reformatting previously - https://github.com/WebOfTrust/keria/pull/254/files
Maybe you should just go back to that workflow?
Seems like that would expedite the merging process.

I'm not sure what you mean. We want to avoid formatting from polluting PRs now and in the future. If we agree on a formatter than that can be easily checked. I have updated this PR to use autopep8 python formatter since @pfeairheller noted he uses PEP in IntelliJ. You can see what the output would look like on the latest formatting check for this PR. I still have no preference of what formatter to use, only that we make formatting simple now and in the future.


Headless launched via jar still shows splash screen?

I was testing the headless launch from jar just to make sure I was giving the right command to a user:
java -Xms256m -Xmx1024m -jar Terasology.jar -headless -homedir=server
But running that on my Win7 desktop still popped up the splashscreen? I would expect not to see it.
#1501 took it out from running from source in a Jenkins run, but this is technically a different launch scenario. Unless maybe #1550 brought it back somehow? Any clues @msteiger ?
Seems low priority, user ran server fine on a hosted machine and I was able to connect :-)

Oh well, I made that on purpose, because I did not see a reason to deactivate it :smile:
It is displayed whenever a graphics environment is available and the splash image is passed as jvm argument (either explicitly or in the MANIFEST.MF entry in the jar file).
Would you rather have it deactivated it when the runtime arg -headless is passed?

Yeah, in part because it never closes :D Or at least I didn't notice it doing so. Seems counter-intuitive anyway since it is a "head" for headless of sorts :-)

Hitching a ride on this issue instead of making a new one - running the game with the -help flag also shows the splash screen, that's probably not desired (it flickers briefly since the help returns very quickly), but unsure how easy it is to distinguish?
Noticed while testing #1575 which also moved the jar so the command is now slightly different when running out of a binary package:
java -jar libs\Terasology.jar -help
On a somewhat related note the new .exes aren't showing the splash screen but that's probably just temporary till @shartte figures it out
There we've also talked a bit about the .exe probably being stuck either as a GUI app or a console app, but not both, leading to a sensible use case where headless is not actually window less - it would make sense in that case to run a log (or even help text) in a tiny basic window. Later that could be turned into a proper server admin tool. So maybe headless showing a splash screen isn't bad if it is part of loading a window anyway.
That scenario is specific to the Windows .exes though. Running via .jar is fine - you can get the logging in the console yet have the game window pop up.

Bumping this rather than making a new issue: splash screen now seems to trigger in any case (other than when no graphics environment is available, I assume). Still a minor issue at most.

The library also contains a pure Java implementation of the splash screen. We could remove the native AWT version altogether and configure it's visibility through Java code. This would also fix this issue here. Will have a look..

Huh, this is a major issue if you want to run a REAL headless server as in my docker image. For this case I would call it a show-stopper.
Revived my rather old little side docker-image just today, and found out that the server isn't able to run due to this issue.

This issue is (should be?) fixed for a long time now. We use our own splash screen implementation now: https://github.com/MovingBlocks/SplashScreen
It checks if a GUI is available and uses a stub implementation if not: https://github.com/MovingBlocks/SplashScreen/blob/master/src/main/java/org/terasology/splash/SplashScreenBuilder.java#L73
@qwc I think that you're having a different issue. According to the log, the world atlas cannot be generated due to a missing AWT implementation. Wild guess: can you verify that the JRE that is used is correct and complete?
@minnesotags has succeeded to install and run a headless server afaik.

@msteiger Oh, then I maybe was mislead through the search for "headless", etc. and my guess was clearly wrong. Sorry about that.
I'm using the openjdk-jre8-headless, same I used before, except the older one was openjdk7, back then.
I'll test with the non-headless, asap.

I guess that makes sense then. Is that headless JRE a custom user made thing? If it excludes the class we use to test for whether you're running in a headed or headless system - then yeah it seems like that would fail :-)
Is that commonly used? I've never heard of it before but then I haven't looked. I understand Java 9 might get more modular from the official side so to say, so eventually we'd probably have to deal with that.
Btw my apologies for never getting back with you on automating the docker build with a ping from our Jenkins. Stuck with crazy work for months, finally been able to put some time in here over the holidays. We actually have upgraded Jenkins + Artifactory now, woo.
I re-investigated another similar hook we could use to publish our test coverage results to a site specialized in that. Only hooked it up for testing (again) but last time around that was my goal to handle at the same time as hooking up the docker piece. So getting close again!
But then if the headless JRE thing gets in the way now I guess we have something else to look at first :-)

Can we close this issue?


Is this not working on windows?

import glob, os
import stempeg
import os.path

train_path = "path_to_train/"
os.chdir(train_path)
for file in glob.glob("*.stem.mp4"):
    file_path = train_path + file
    print(os.path.isfile(file_path))
    S, rate = stempeg.read_stems(file_path)

Even isfile returns true, read_stems throws 'FileNotFoundError: [WinError 2] '

can you give more details? have you tried loading a manual absolute file_path?

can you give me the full error message, please?

also, did you try using the provided example file: https://github.com/faroit/stempeg/blob/master/tests/data/The Easton Ellises - Falcon 69.stem.mp4 or running the unit tests?

@westside did you managed to solve it?

Really sorry for not responding.
I just changed the stem file to the other format.
Thank you.
If I test it, let you know by opening this issue again.

I have this issue on mac. when i tried to   S, rate = stempeg.read_stems(file_path). it shows me that [Errno 2] No such file or directory. even when i tried the sample audio provided above and using the absolute file path

@lvbaouu what version of FFMPEG are you using and how did you install it?

i used  pip install ffmpeg and it is:
pip show FFMPEG
Name: ffmpeg
Version: 1.4
Summary: ffmpeg python package url [https://github.com/jiashaokun/ffmpeg]
Home-page: https://github.com/jiashaokun/ffmpeg
Author: SkeyJIA
Author-email<EMAIL_ADDRESS>License: MIT Licence
Location: /anaconda2/envs/deeplearning/lib/python2.7/site-packages

When I downloaded with anaconda and try, I got the following error with the following code :
`import stempeg
S, rate = stempeg.read_stems("/Users/lzhang22/Downloads/The Easton Ellises - Falcon 69.stem.mp4")

CalledProcessError                        Traceback (most recent call last)
 in ()
----> 1 S, rate = stempeg.read_stems("/Users/lzhang22/Downloads/The Easton Ellises - Falcon 69.stem.mp4")
/anaconda2/envs/deeplearning/lib/python2.7/site-packages/stempeg/read.pyc in read_stems(filename, out_type, stem_id)
89     """
90
---> 91     FFinfo = FFMPEGInfo(filename)
92
93     if stem_id is not None:
/anaconda2/envs/deeplearning/lib/python2.7/site-packages/stempeg/read.pyc in init(self, filename)
17         super(FFMPEGInfo, self).init()
18         self.filename = filename
---> 19         self.json_info = read_info(self.filename)
20
21     @property
/anaconda2/envs/deeplearning/lib/python2.7/site-packages/stempeg/read.pyc in read_info(filename)
53     ]
54
---> 55     out = sp.check_output(cmd)
56     info = json.loads(out.decode('utf-8'))
57     return info
/anaconda2/envs/deeplearning/lib/python2.7/subprocess.pyc in check_output(*popenargs, **kwargs)
221         if cmd is None:
222             cmd = popenargs[0]
--> 223         raise CalledProcessError(retcode, cmd, output=output)
224     return output
225
CalledProcessError: Command '['ffprobe', '/Users/lzhang22/Downloads/The Easton Ellises - Falcon 69.stem.mp4', '-v', 'error', '-print_format', 'json', '-show_format', '-show_streams']' returned non-zero exit status -6`

check if you can run ffprobe /Users/lzhang22/Downloads/The Easton Ellises - Falcon 69.stem.mp4 -v error -print_format json -show_format -show_streams in the command line

no. it gives me the following error:
(deeplearning) LPT-010557-PU:~ lzhang22$ ffprobe /Users/lzhang22/Downloads/The Easton Ellises - Falcon 69.stem.mp4 -v error -print_format json -show_format -show_streams
dyld: Library not loaded: @rpath/libx264.138.dylib
Referenced from: /anaconda2/envs/deeplearning/bin/ffprobe
Reason: image not found
Abort trap: 6

I would recommend starting with a fresh anaconda environment. this doesn't seem like the error is caused by stempeg.

i tried. it still gives me the same error

I just checked on my machine, installing miniconda and ffmpeg4 with conda. Works fine here.
Check if you didn't install ffmpeg with homebrew.
sorry, I can't give support for anaconda or ffmpeg.

it worked on my other computer (but have no storage space the data I want to process) but not the current one. What could have been the issues?


Add the ability to hide filter sidebar

Describe the bug
Add the ability to hide filter sidebar

:tada: This issue has been resolved in version 1.0.0 :tada:
The release is available on:

GitHub release
1.0.0

Your semantic-release bot :package::rocket:


View controllers don't have access to the global variables.

Bug Description
Try creating a view and then accessing a global variable through that. It doesn't work.
Something like this doesn't work. Fix this.
db = DB()
def AsyncView():
    async def get():
        res = db(bla)
        return "Hello, world!"

Steps to Reproduce
No response
Your operating system
None
Your Python version (python --version)
None
Your Robyn version
None
Additional Info
No response

Does this have any news? I am really interested in working with Views. Any idea if making the Instance on the View does make it work?

@Noborita9 , apologies for the late revert. This comment missed my eye.

Any idea if making the Instance on the View does make it work?

What do you mean by this?

He probably means to create "db" from inside the view. But it doesn’t work either.
And functions that are not named by methods will raise an error iirc. Something along a wrong index value when nested functions are being collected.

Perhaps it can be implemented with a decorator like @view_extension that can pass functions other than method handlers.

He probably means to create "db" from inside the view. But it doesn’t work either.
Yeah exactly that

I don't think that will work. I am using this library for this - https://github.com/sansyrox/nestd/blob/main/nestd/init.py#L35
We will have to change something around this line imo.

Yes, that’s where it throw the error. I have had no time to investigate further. :(

No worries. I will get around to it soon 😄


emit an error if generate-ci disagrees with cargo-dist-version

this fixes the worst aspects of #141


Pretty printing ast

Implement pretty_printer module to pretty print derivation tree and AST

Added pretty printer, just needs to be maintained

Closed for now


[teams_discussion] cause clients to retry joining teams

Before this commit, if a client tries to join a full team, it will fail,
then clog the logs with subsequent failed tasks (mostly create_thread).
After this commit, the client will retry joining different teams until
hopefully one is joined.  Only if a team is successfully joined, the
client will continue running subsequent tasks.
Also update docs to clarify the setup procedure and other
responsibilities.

FYI @MichaelRoytman

Alrighty, commets addressed!  I've never used the backoff package before so I'm not really sure how trustworthy its versioning is.

oh, actually i'm seeing a new error related to the handler method:
https://build.testeng.edx.org/job/loadtest-driver/134/console
TypeError: 'classmethod' object is not callable

Ugh, never mind the classmethod bit then. :-( Sorry for the wasted test cycle.

Np, it was a nice try.  Giveup handler back to global scope, with improved docstring.
Giving up looks correct: https://build.testeng.edx.org/job/loadtest-driver/135/console


No way to circumvent quarantine without using Spam Assassin

Context
I was sending some legit test emails from my office account to my private account which is hosted on docker-mailserver. For whatever reason the mail contains a duplicate mime version header which make Amavis uncomfortable. Amavis quarantines the mail.
I would like to override this behaviour and get such emails anyways. That's what the SPAMASSASSIN_SPAM_TO_INBOX environment variable was invented for. But if you have Spam Assassin disabled (ENABLE_SPAMASSASSIN=0) that option is not accounted for.
What is affected by this bug?
Mail delivery. The biggest problem is that the receiver does not notice without looking through the logs.
When does this occur?
Sending emails with duplicate headers like mime version.
Actual Behavior
The email gets quarantined and is not noticed by the receiver.
Expected behavior (i.e. solution)
Allow for overriding this behaviour without having to enable Spam Assassin.
Your Environment
This is on 7.0.0

Forgot to mention: As a workaround one could use the custom amavis.cf or user-patches.cf to change the Amavis configuration (what I did for now).

Thanks for reporting.
Due to missing capacities, you would need to do this yourself. Can you contribute this?

This issue was closed due to one or more of the following reasons:

Age
Contributor inactivity
The issue seems to be resolved

If you think this happened by accident, or feel like this issue was not actually resolved, please feel free to re-open it. If there is an issue you could resolve in the meantime, please open a PR based on the current master branch so we can review it.


Record last commit hash of previous experiment

Automated metadata.yaml creation is added in this PR https://github.com/payu-org/payu/pull/384
If the commit hash of the the last commit in a previous experiment (when the experiment ID last changed) were saved in metadata.yaml it would make it trivially easy to specify the range of commits that constitute an experiment. The refA..refB syntax used for selecting a range of git commits automatically excludes the initial commit, refA in this example.
Otherwise you would need to walk the commit history of metadata.yaml in a repo looking for changes.
Would not be saved if not known (so field would be absent).

Closed in #384


Wrong url in RC1 announcement

The breaking change url points to beta-8 breaking changes. Should point to https://github.com/aspnet/announcements/issues?utf8=✓&q=is%3Aissue+milestone%3A1.0.0-rc1

Where's that url?

Breaking Change section in https://github.com/aspnet/Home/releases/tag/v1.0.0-rc1

@danroth27

Should be fixed now. Thanks for letting us know!


Feature/152086418/search for recipes

What does this PR do?
Enables user to search for recipes by name of ingredients
Description of Task to be completed?

write the API to search for recipes by name or ingredients
consume the API from the backend with react-select

How should this be manually tested?

from terminal, run: git clone https://github.com/SannyTee/More-Recipes.git to clone repository
cd into the cloned repository and run: npm install to install all required dependencies
run npm run start:dev to startup application and open browser at localhost:3000.
create an account or login
type in the search bar to search for a recipe

Any background context you want to provide?
N/A
What are the relevant pivotal tracker stories?
#152086418
Screenshots (if appropriate)

Questions:
N/A

Coverage decreased (-0.7%) to 79.119% when pulling 985e3e75017f4004734e6036c474055b5ca8427f on feature/152086418/search-for-recipes into 8007b0d355193b5c5e8962a843dd996021311305 on develop.


Make allocations of f1_threaded et al. type stable

In GitLab by @ranocha on May 18, 2020, 19:30
Currently, something like
function calc_volume_integral!(dg, ::Val{:split_form}, u_t::Array{Float64, 4},
                               dsplit_transposed::SMatrix)
  # Type alias only for convenience
  A4d = MArray{Tuple{nvariables(dg), nnodes(dg), nnodes(dg), nnodes(dg)}, Float64}
  A3d = MArray{Tuple{nvariables(dg), nnodes(dg), nnodes(dg)}, Float64}

  # Pre-allocate data structures to speed up computation (thread-safe)
  f1_threaded = [A4d(undef) for _ in 1:Threads.nthreads()]
  f2_threaded = [A4d(undef) for _ in 1:Threads.nthreads()]
  f1_diag_threaded = [A3d(undef) for _ in 1:Threads.nthreads()]
  f2_diag_threaded = [A3d(undef) for _ in 1:Threads.nthreads()]

is not type stable. I'm not sure whether (and if so how much) performance is lost here but it might be worth trying to add something like nvariables_val which returns Val(nvariables(...)) in a type-stable way.
You can verify the type instability by running
julia> using Trixi

julia> Trixi.run("examples/parameters_ec.toml")

julia> equations = Trixi.Equations.make_equations("euler")
name = euler, n_vars = 4

julia> mesh = Trixi.generate_mesh();

julia> solver = Trixi.Solvers.make_solver("dg", equations, mesh);

julia> @code_warntype Trixi.Solvers.DgSolver.calc_volume_integral!(solver, Val(:split_form), solver.elements.u_t, solver.dsplit_transposed)

@ranocha Is this still relevant or have we implicitly fixed this by using thread caches everywhere?

You're right :+1:


Error: "extract-text-webpack-plugin" loader is used without the corresponding plugin

I have the following error when running npm run dev.

Error: "extract-text-webpack-plugin" loader is used without the corresponding plugin, refer to https://github.com/webpack/extract-text-webpack-plugin for the usage example  at Object.module.exports.pitch @ ./~/vue-spinner/src/PulseLoader.vue

Windows 7
node v4.4.7
Vue 2

Vue-spinner is not support vue.js 2.0 yet.

Is that right? I am using it right now in Vue 2.0. It works  on MacOS but not on windows. Here is loading button with PulseLoader

I am not using extract-text-webpack-plugin
vue-spinner is working for me on Windows

Windows 10
node v6
Vue 2


KWS training

Hello i was iwondering if training the model using recorded samples from the max microphone will increase the accuracy ?
I mean training the model with same microphone it will be tested on in real life ?
If yes can you provide us with necessary steps to do so ?

Hi,
Yes, it helps.  Please see the attached code. In the main.c, you can send out the samples that are used for inference if #define SEND_MIC_OUT_SERIAL is enabled.
The capture_serial_bin.py script receives serial data and creates  .wav files that can be added to your dataset. Please update the COM port in the script.
kws21_demo_mic_capture.zip

Please update the keywords[NUM_OUTPUT][10] according to your trained keywords.

I tried 0.10.3.
The latest 0.11.0 should probably be fine too.

Thank youu


Download images with mentions

I am want to download all images of a profile with mentions in caption but cannot do it. Can you please help

See https://instaloader.github.io/basic-usage.html#filter-posts.

See https://instaloader.github.io/basic-usage.html#filter-posts.

i did but shows error..can you give the command, for eg i want to download all pics with "@test" mentioned in caption

I wrote that part of the documentation, so I'm afraid I cannot explain it any better than that. Sorry.


Make sure iptables chains are recreated on firewall reload

Signed-off-by: Alessandro Boch<EMAIL_ADDRESS>

LGTM

LGTM.
Is there a consistent way to reproduce the issue & is it possible to possible to write an IT for this ?
(either in libnetwork or docker/docker ? )

@mavenugo
Have firewalld running, start docker daemon, reload firewalld service, verify the docker chains are in the iptables o/p.
I verified the fix in an ubuntu VM with firewalld and in a fedora one, after a firewalld restart the chains are reinstalled (the daemon iptables logs are also very useful in showing what is being probed and then installed).
Please note the other issue, where the rules are sometimes wiped out is still there.
It can happen on system events firewalld reacts on, unrelated to docker.
For this second issue, I am sometime able to reproduce just running some commands on firewalld, like firewalld --debug 10. Unfortuantely I can confirm firewalld signalHandler in iptables does not receive any notification when the rules are wiped out.

@aboch thanks for the clarification.


Deploy on gh pages branch to qhub.dev

@tonyfast I ran the black formatter on a file that I discovered was causing tests to fail and committed it. Had the same issue in #54

Merging this blindly @tonyfast :)


State of 2.1.0

Hi!
Quick question, what would be the state of the current 2.1.0 version?
I am asking this because our software has a dependency on EF6.2. We would like to update to 6.4 so that we can make our applications to run on multiple platforms.
Currently this package is the last dependency that prevents us from doing this. As far we did notice, is that there is already a 2.1.0 version on your development nuget server. Is this package as well ready to be pushed towards the official nuget.org server?
Thanks in advance!
Kind Regards,
Mattletw

What's missing here is a release script similar to the base package. A PR is welcome.

@lbargaoanu My apologies for not responding to this issue. I've just created a PR to implement a similar like CI/Release flow as in the base package.


Vulkan: fixes for texture tests and texture transparency tests

Some of the texture tests have dependency on #1779 and there might be crashes in texture tests because of that. Have tested them with #1779 and they should be fine once that pull request is merged.
With this PR, these are the results of running the framework tests:
Passed:
- BoundingVolumeTests
- CullTests
- RenderConfigTests
- StencilTests
- TextureTests
- TextureTransparencyTests
- PickerTests
- MiscTests

Partial (listing the failed sub-tests):
- RenderTests: testTwoPostEffects
- SceneObjectTests: fails arbitrarily on some tests
- RenderPerfTests: fails with tests having cylinder model; quads pass

Crashes / Not Passsed:
- LightTests
- ShadowTests
- VideoTests
- RenderShaderTests: meshFormatsWithShaderCombinationsTest (depends on lighting)

GearVRF DCO signed off by: Sushant Ojal<EMAIL_ADDRESS>

Needs rebase

@roshanch @apjagdale Please review

Seems good.

looks good to me.

Waiting on #1779.

Texture transparency tests run correctly. Texture tests run individually but some fail randomly when all are run at once. Scene object tests have the same issue. Will do a separate PR for this bug.

Transparency tests passed for me. Ran TextureTests and SceneObjectsTests few times without crashes but not all test cases pass.

Needs rebase also

should be ok now. SceneObject tests, texture tests and texture transparency tests should all run.

Looks good. Planning to merge on Tuesday.


Docker

Issue

closes: #534

Would cd tasks/build && sh ./build.sh also work on Unix as a build command?

I get some strange issues, can someone help me with them?

Would cd tasks/build && sh ./build.sh also work on Unix as a build command? Without sh it doesn't work on Windows.

Yes.

It works!!! :)
Would it be possible to remove the default --binary so one can set a specific binary?

Would it be possible to remove the default --binary so one can set a specific binary? This way we can easily compare build hashes.
One idea: Maybe we can make the script take a git-tag for Voyager and then it pulls the code according to the tag. This could reduce confusion about which commit are we on right now.

How about replacing --binary with --gaia-commit to specify a commit for Gaia and introducing --commit for specifying a Voyager commit?  We shouldn't allow the use of tags because that would open a security hole until we start signing them.

Didn't Greg push for using built binaries? I am OK with --commit for Voyager if that is securer.
Note: I put signing commits on the agenda for next Tuesday. ;)

Yes but we can specify which prebuilt binary to use via the commit.

But you would still build Gaia inside the docker?

But you would still build Gaia inside the docker?

No, I'll download the prebuilt version similar to this:
wget --output-document=/usr/local/bin/gaia \
  https://tendermint-packages.interblock.io/binaries/gaia_linux_amd64/gaia_${commit}

OK it's not that pretty but I don't think we want to spend a lot of time on this.  To build you now specify Gaia and Voyager commits on the command line before other arguments (Gaia's must be a hash and Voyager's can be any Git reference):
yarn run build decb23bed0179244e4f42d697dcd4bf759200a2d 0.4.3 --platform={darwin|win32|linux}

One thing I'm not thrilled about is that we're trusting Interblock and HTTPS with the integrity of Gaia:
wget --output-document=/usr/local/bin/gaia \
  https://tendermint-packages.interblock.io/binaries/gaia_linux_amd64/gaia_$1

Maybe this won't matter when it's all on the same build machine or maybe we want to do something fancy with signing the binaries.
TBD: See if we can add the build step to the CI script.

I didn't knew we have Gaia builds for every commit. That is great!  I am not sure if building Gaia is deterministic.

Sorry, I was unclear.  We don't have Gaia builds for every commit; we have exactly one provided by @greg-szabo.  If he builds another one then we can specify that too.  Originally I was building Gaia in the container and we could have done it for any arbitrary commit but @greg-szabo objected.

Then I suggest we go with --binary first and migrate when we have "Gaia" (or what will follow) on every commit. What do you think?

So you want the user to be able to provide their own arbitrary version of Gaia?  I think that would go in the opposite direction of making the build more deterministic.
Let's get @greg-szabo into this conversation.  Greg, what are your thoughts?

Not an arbitrary Gaia build but a Gaia build that is shareable and has a fixed checksum. The purpose is, that different people on different computers can build Voyager and still create the same hash in the end so we can prove that the builds we ship have no malicious code in it.
For development we can always fall back to the installed Gaia/SDK.

Ah, OK.  That's exactly how it is now in this pull request.

Ok, I was able to get through the conversation. Great work. Some notes for clarity:

interblock.io is ours, I manage the DNS, the certificate, and the website. We don't have to worry about trust there (apart from regular paranoia). Eventually, we could move it to packages.tendermint.com or Nexus/Artifactory for better artifact integrity. (And zip it too.)
I think the --binary option makes sense. It should accept a binary on your local machine (built by the dev or automation). In that case, it's easy for developers to add any random gaia binary for testing. Automation deals with downloading binaries from the repository separately. (So, automation will also have a local version of the binary.) For what it's worth, the whole wget part should not be needed or be done separately outside of the container.
I still don't really get in a lot of cases why we build Docker containers though. The binary could be added as part of a volume so we don't rebuild the container for each and every new binary. I think we're abusing docker in a lot of cases. (Thoughts for a later discussion.)
Automation is coming along well, I should be able to create gaia binaries for the repository quite easily. Eventually, it will be automated for every PR and we can have a manual trigger for any branches that you come up with.
Voyager CI/CD is not that far along, yet. :(

@greg-szabo

I don't think we should trust anything, not even ourselves.
For deterministic builds we need deterministic environments. Docker is the logical solution I guess. Do you have another solution?
Not a problem. If this will get important to use, we will push you and/or help you implement this.

yarn run build --platform=win32 --binary="C:\Users\Fabo\Downloads\gaia-0.5.0-windows-32.exe" doesn't currently work:

Uh, I find it hard to discuss these through a message board. I was under the assumption that the question is about building gaia for voyager versus bringing in a binary that was built earlier. If it's about using Docker vs not using Docker, there are pros and cons for both. I can summarize them, if necessary. Just one note in advance: although Docker helps, it doesn't solve the problem of deterministic builds by itself.
I was also under the assumption that David was writing Dockerfiles, so I thought that's what the team is going with, for Voyager. In this regard, bringing in a pre-built binary is possible and encouraged, because the pre-built binary went through unit-testing and integration testing. (Whereas if you build it, it didn't.)

I think the --binary option makes sense. It should accept a binary on your local machine (built by the dev or automation). In that case, it's easy for developers to add any random gaia binary for testing. Automation deals with downloading binaries from the repository separately. (So, automation will also have a local version of the binary.) For what it's worth, the whole wget part should not be needed or be done separately outside of the container.

I was also under the assumption that David was writing Dockerfiles, so I thought that's what the team is going with, for Voyager. In this regard, bringing in a pre-built gaia binary is possible and encouraged, because the pre-built binary went through unit-testing and integration testing. (Whereas if you build it, it didn't.)

@greg-szabo, I'm confused because these sound contradictory to me.  I had originally designed the build process to allow a random Gaia build but after our conversation I thought you wanted me to download the pre-built binary only.  Are you softening that stance?

I still don't really get in a lot of cases why we build Docker containers though. The binary could be added as part of a volume so we don't rebuild the container for each and every new binary. I think we're abusing docker in a lot of cases. (Thoughts for a later discussion.)

I'm building Voyager in a container to control the build environment.  The image is built only once per Gaia version and reused for every Voyager build.

I thought you wanted me to download the pre-built binary only.
The emphasis is on the pre-built, not on the download. Don't build the gaia binary in your voyager build process, always use a pre-built one. If - in a separate step - you want to build a specific branch, then it should be ok for developer use. (With the addition that those voyager binaries should never be published, since they are untested.) If you want to publish voyager, always download gaia from the binary repository (because those are tested).

I think I didn't understand the question about the -binary parameter, I have no idea what it does in yarn. If it builds a gaia binary, don't use it. If it just points to the (pre-built) gaia binary on your local machine, that should be ok.

The container (image) is built only once per Gaia version and then reused for each Voyager build.

I don't understand why there needs to be a Docker container built for each gaia version. The gaia binary can be fed into a Docker container using the docker volume option. It does not need to be baked into the docker image. I think we (as a team, not just in this case) are abusing Docker compose which slows down automation for no real benefit. Docker is fine to use but most probably you can use the standard yarn image (if there is one) and feed your script and the files necessary through volume. This way you don't need to build any docker images at all.

The emphasis is on the pre-built, not on the download. Don't build the gaia binary in your voyager build process, always use a pre-built one. If - in a separate step - you want to build a specific branch, then it should be ok for developer use. (With the addition that those voyager binaries should never be published, since they are untested.) If you want to publish voyager, always download gaia from the binary repository (because those are tested).

Ah OK, now I understand.  Thanks for explaining it to me.
@faboweb What are the use cases for developers building their own Voyager production applications?  Is there any reason to create a separate process outside of the official build-and-test process of the binary repository?

I think I didn't understand the question about the -binary parameter, I have no idea what it does in yarn. If it builds a gaia binary, don't use it. If it just points to the (pre-built) gaia binary on your local machine, that should be ok.

The --binary parameter is one that we're making up and discussing.  It has nothing to do with Yarn.

I don't understand why there needs to be a Docker container built for each gaia version. The gaia binary can be fed into a Docker container using the docker volume option. It does not need to be baked into the docker image. I think we (as a team, not just in this case) are abusing Docker compose which slows down automation for no real benefit. Docker is fine to use but most probably you can use the standard yarn image (if there is one) and feed your script and the files necessary through volume. This way you don't need to build any docker images at all.

You're right, Gaia could be fed in through a volume.  I was doing it in the image because of two assumptions a) the cost would be low because we won't be changing the Gaia version often and 2) we should take control of it out of the developer's hands because we're trying to to create predictable builds.  After the above discussion about binaries, however, I'm going to remove Gaia from the build process and treat it as an input from the developer.
We can't just use the standard Node.js image because we need to install Wine as well for the Windows builds.

Ok, cool, I like the way this is going. As for the Node+Wine image, I get the point, that needs to be built. To make the process faster and easier, I propose that an docker image like that is managed separately (I can help adding an image like that to the tendermint repo on hub.docker.com). This way the build process is literally going to be docker pull + docker run -v which seems a more streamlined process.
Also, I assume the Node+Wine image doesn't change much, that's why I think it's worth separating it. If that's not the case, then let's discuss further.

Sounds great :)


chore(pre-commit): Remove UTF-8 byte order marker

This change is part of the following stack:

#52

#53

#54

#55 ◀

#56

#57

Change managed by git-spice.


CloudTrace : understanding how things are connected

I have a PubSub pull subscriber running on Cloud Run
I'd like to create a new trace for each message AND see the trace "metrics" like for a HTTP request, especially the duration of the trace

At the moment, I'm using this pieece of code (combination of various findings in .NET and GCP docs + multiple tries + previous issues I created on this github) :
using var activity = new Activity($"Processing Message {message.MessageId}").Start();
try
{
    logger.LogInformation("Type {MessageType} MessageId: {MessageId}", "PubSubMessage", message.MessageId);

    // https://cloud.google.com/pubsub/docs/publish-receive-messages-client-library#c_1
    var data = System.Text.Encoding.UTF8.GetString(message.Data.ToArray());

    logger.LogInformation("Message content: Data: {Data}, Attributes: {Attributes}, MessageId: {MessageId}", data, message.Attributes, message.MessageId);
    await ProcessMessage(data!);

    activity.SetStatus(ActivityStatusCode.Ok);
    return SubscriberClient.Reply.Ack;
}
catch (Exception e)
{
    activity.SetStatus(ActivityStatusCode.Error, e.Message);
    logger.LogError(e.Message);
    return SubscriberClient.Reply.Nack;
}
finally
{
    activity.Stop();
}

The logs are correctly correlated but the trace is not working : I do not have the duration metrics and the  icon is not working

I suppose I need to manually integrate with Cloud Trace API to start a Trace
So I looked here : https://cloud.google.com/dotnet/docs/reference/Google.Cloud.Trace.V2/latest and https://cloud.google.com/dotnet/docs/reference/Google.Cloud.Trace.V2/latest/Google.Cloud.Trace.V2.TraceServiceClient#Google_Cloud_Trace_V2_TraceServiceClient_CreateSpanAsync_Google_Cloud_Trace_V2_Span_System_Threading_CancellationToken_
However, I do not understand how it works
If I call CreateSpanAsync, what do I put in SpanName.FromProjectTraceSpan("[PROJECT]", "[TRACE]", "[SPAN]"),
My understanfing was to use ProjectId, activity.Id, "0000000" => still not showing the trace
Maybe I need to call BatchWriteSpansAsync ? I tried that too but still not showing the trace
=> Can you help or proide pointers ?

First take a look at Distributed Tracing in Cloud Run documentation. A few things to note:

In Cloud Run traces are stored automatically, but at a fixed sample rate of 0.1 traces a second. This rate is not configurable on Cloud Run. After leaving your application running for a long enough time, are you missing all traces or just most of them consistent with the sample rate? Do wait for a bit before checking, it might be that logs and traces are flushing at different times.
Adding extra instrumentation (spans) will let you know metrics of specific code paths in your app, but it won't have an effect on the sample rate (and that's why adding spans is not showing the trace). If you only care about how long took the request overall, then you don't need to add spans.

If you want to trace more than what the Cloud Run sample rate allows, you'll have to store the traces yourself using Google.Cloud.Trace.V1.TraceServiceClient.PatchTracesAsync.
Alternatively you can use Google.Cloud.Diagnostics.Common and Google.Cloud.Diagnostics.AspNetCore3 (works for ASP.NET Core 3 or later) to instrument your code. But please read carefully these notes as they will affect how you need to configure the libraries.

Hi Amanda

In Cloud Run traces are stored automatically

This is true ONLY for HTTP requests
Here, this is a pull subscription, meaning that there is no inconming http requests and so there is no trace => this is why I need to manually create one

Google.Cloud.Trace.V1.TraceServiceClient.PatchTracesAsync.

I dont understand this snippet (am I supposed to start a trace with

please read carefully these notes

Thanks for the pointers, I'll try "one trace per event"

Oh, sorry for missing this was for Pub/Sub. So yes, you will have to instrument the code yourself.
The snippets we currently have are like code templates, they are not complete (we are working on it). On  Google.Cloud.Trace.V1.TraceServiceClient.PatchTracesAsync:

PatchTracesRequest.Traces is a collection of new or existing traces to patch.
And here is a Trace as you would add it to this collection.
You need to extract the trace context from the Pub/Sub message, it won't be set on the current Activity (we'll be working on this in the short to medium term).

If you look at https://github.com/googleapis/google-cloud-dotnet/issues/6367#issuecomment-903852079, step 3 shows you how to extract and parse the trace context from a Pub/Sub message. The rest of that comment, which is the conclusion of that whole thread, explains how to configure and use Google.Cloud.Diagnostics.Common for tracing non-ASP.NET Core contexts (as is Pub/Sub). You can decide to go with Google.Cloud.Diagnostics.Common or use Google.Cloud.Trace.V1 directly.
Let me know if you have more questions, happy to try and help further.

Thank you, I'll try that and reopen if not enough


Get hint information from metadata

Initial conversation
Hints will soon have a separate metadata file that we could require instead of using a regular expression to get the data from the markdown.
The advantages of using the metadata are:

No need for a RegExp that could break any time
We can have a name different than the one in the markdown if needed
We could have a description that is better than the first paragraph of the document

On the other side, because the project is TS we will need to compile or download the packages individually:

Compiling will take about 2-3 minutes
If we decide to download we will probably need another configuration package "all" to make sure we are always downloading everything, read its package.json and then require those packages

If we want to publish changes into the documentation we will be forced to publish a new version to get the changes live

Another thing we need to take into account is what happens with the other resource packages. Should we add some metadata as well so they are all processed equally?
@webhintio/contributors what do you think?

Compiling will take about 2-3 minutes

It is not just compiling, you also need to install dependencies.

If we decide to download we will probably...

This is the option I like the most.

Another thing we need to take into account is what happens with the other resource packages. Should we add some metadata as well so they are all processed equally?

This would be nice if we want to add a landing page with more information and not just the name.

@sarvaje I believe we are already doing this, right?

We're still scraping the raw source code for some of this information (now from meta.ts files instead of markdown). I also favor option 2 where we create a configuration-all, install that, and use require to access the metadata.


Sections don't load for pages?sectionName snippet

Thanks for finding this issue!
It appears per this doc that the com.microsoft.onenotevos.Section's field parentSectionGroup should be com.microsoft.onenotevos.SectionGroup instead of java.lang.String


Support additional log key types

Description

Currently sigstore-go only supports ecdsa p-256 for the log's public key. The public instance currently uses this signature algorithm, but we may see other curves or key types used for private deployments.
Could also be fixed as part of https://github.com/sigstore/sigstore-go/issues/74

Dup of https://github.com/sigstore/sigstore-go/issues/65


stack test fails on Windows

I have an action that fails on Windows  on stack test with a non-informative error.
eo-phi-normalizer> spec.exe: <stdout>: commitBuffer: invalid argument (cannot encode character '\10214')

https://github.com/objectionary/normalizer/actions/runs/8152594586/job/22282343404#step:3:111
I read https://stackoverflow.com/a/63751678.
Setting LC_ALL=C.UTF-8 didn't help.
https://github.com/objectionary/normalizer/pull/98/commits/32501dca718d00b025b02900f1bec3e49e3d6708
I tried debugging it by disabling tests and running tmate right after stack-action.
https://github.com/objectionary/normalizer/pull/98/commits/0637f1cfbda9aadd4e30749c5729fd496a02f33f
- name: Setup tmate session
  uses: mxschmitt/action-tmate@v3

I connected to a windows runner and ran stack.
I got the same error as in previous runs.
I ran chcp.com 65001 as recommended (link).
Then, I ran stack test and it worked.

Are you suggesting we should run chcp.com 65001 automatically if on Windows?
Is this always needed, or only for certain projects / source files? If it's always needed, why is it suddenly failing now, why not in our test suite? If it's only needed for certain projects / source files, what is it that makes it necessary? Is it reasonable to document and require users run that command themselves?
If someone who just does run: stack test would encounter this, which it seems like is the case, then I don't think we can call it a bug in the action. Then, the question becomes how reasonable is it to have the action do things to compensate for it, I guess.

I'm yet to solve this problem. Let's keep this issue open for a week. If I find a solution, I'll share it and then we can decide if it's reasonable to incorporate it into stack-action (and provide an input flag).

So, you use actions/exec. It uses child_process.spawn().
https://github.com/actions/toolkit/blob/b807fc9c541224508f753d1cc8a18c66072c181e/packages/exec/src/toolrunner.ts#L437
Some advice (not a complete solution).
https://stackoverflow.com/a/59635209

I resolved this issue as follows:

Test after stack-action in a bash shell (link).
Add chcp 65001 in Setup.hs when building on Windows (link).
Make the command in Setup.hs single-line (link).

[ ] TODO why didn't a multiline command work?

Run tests in a bash shell with chcp 65001 before stack test (link).
Force stack to run Setup.hs (link). Otherwise, some modules weren't generated by bnfc.

[ ] TODO add option to stack-action that controls running stack clean after restoring dependencies and before stack build.

Use withUtf8 from with-utf8 both in the app (link) and tests (link).

Just curious, does it not work to do:
      - name: Fix for Windows
        if: ${{ runner.os == 'Windows' }}
        run: chcp.com 65001

      - name: Test
        uses: freckle/stack-action@v5
        with:
          stack-build-arguments: --pedantic --prefetch --copy-bins

?

No, it's not enough.
If I don't run chcp.com 65001 (link), alex throws an error (link).

Hmm, I may not be being clear, or maybe I'm confused.
In your earlier links, I thought you were doing:

stack-action with test: false
stack clean
chcp.com 65001
stack test

If I don't run chcp.com 65001...

I'm not suggesting you don't run it, I'm suggesting you run it before stack entirely:

chcp.com 65001
stack-action with test: true

I don't see how build-clean-chcp-test works, but chcp-test wouldn't -- build-clean are kind of offsetting actions in my mind.

Oh I see in your build log now that you indeed did that.
I wonder if the cache-restore undoes it, which is why doing a clean-chcp after works but doing the chcp before doesn't.

Here's a better run.
The code page is 65001 in cmd.exe link.
However, it's not in Setup.hs link.

And here you can see that --reconfigure (link) doesn't force stack to run Setup.hs, so some modules aren't generated and the action fails (link). I'm not sure whether it's intended.

The code page is 65001 in cmd.exe link.
However, it's not in Setup.hs link.

I'll admit I don't know exactly what chcp does, but if it's modifying files and those files are then overwritten by a cache-restore, it would make sense that its effect is undone. It would also make sense that doing a clean and then chcp again would make it work correctly. Do you agree that may be what's happening, or no?
If you set a cache-prefix and tried it that way again but without any caching, I suspect it might work then.

--reconfigure (link) doesn't force stack to run Setup.hs

I don't know anything about this, but I do see that your --reconfigure flag is passed onto stack correctly. So, if this is some kind bug, it's in stack and not stack-action.

it would make sense that its effect is undone

Seems like the active code page is shared at any level in a process.
runneradmin@fv-az521-811 MINGW64 /d/a/normalizer/normalizer
# chcp.com
Active code page: 437

runneradmin@fv-az521-811 MINGW64 /d/a/normalizer/normalizer
# cmd
Microsoft Windows [Version 10.0.20348.2461]
(c) Microsoft Corporation. All rights reserved.

D:\a\normalizer\normalizer>cmd /c cmd /c chcp 65001
Active code page: 65001

D:\a\normalizer\normalizer>chcp
Active code page: 65001

D:\a\normalizer\normalizer>exit

runneradmin@fv-az521-811 MINGW64 /d/a/normalizer/normalizer
# chcp.com
Active code page: 65001

However, I'm not sure stack-action is aware of this code page.

if this is some kind bug, it's in stack

Yes, and it can be solved via stack (link), as I've just found.

However, I'm not sure stack-action is aware of this code page.

It is (link).

However, I'm not sure stack-action is aware of this code page

This sentence confused me. stack-action just runs commands with exec. Are you saying exec may not be "aware"?

 C:\Windows\system32\cmd.exe /c chcp && stack --no-terminal build --test --no-run-tests --dependencies-only --pedantic --prefetch --copy-bins --ghc-options -O2 --reconfigure
 Active code page: 65001
 Error: [S-922]
 No cryptographic hash found for Hackage package BNFC-2.9.5, updating
 Selected mirror https://hackage.haskell.org/
 Downloading root

 Error: [S-922]
        No cryptographic hash found for Hackage package Glob-0.10.2.

Does the "Active code page: 65001" here indicated that avoiding a cache-restore _did_ make it behave correctly? And that this build should've passed if the (unrelated) "No cryptographic hash" error didn't happen?

Yes, I thought exec may be unaware.
Yes, the error is irrelevant.

The error was due to --prefetch.

For some reason, after I've set the code page (link) to 65001, the code page in the Setup.hs script is 437 (link), so I have to set it to 65001 again.
Offtopic: I documented some others weird things about Windows runners (link).

So, stack-action works OK, and I can finally close this issue.

OK, so let me confirm some basic facts:

For some class of windows builds, a chcp needs to be run for the build to succeed
If the chcp is run and then a cache is restored, it's undone (build fails)
If the chcp is run and then a cache is NOT restored, it's NOT undone (build succeeds)
If you add the chcp to your own Setup.hs all is OK, without any stack-action changes needed

?

chcp is necessary for commands that output Unicode. In our case, tests output Unicode (link).
If the chcp is run before stack-action and a cache is restored, tests may not need to build (link) and they succeed.
If the chcp is run before stack-action and then a cache is restored and then stack is run, stack runs with 65001 (link). So, cache restoration doesn't affect the code page.
If I don't add chcp 65001 to my Setup.hs, the code page is 437 (link) and tests fail.
If I add chcp 65001, tests succeed (link) because then, bnfc, alex and happy read and write UTF-8.