Default to utils::view() when no asJSON S3 method exists

R tibble() objects can contain objects that do not have asJSON methods (e.g., difftime objects, units objects, etc.) . In these cases R will return an error when calling the View() function provided by VSCode-R:

Error: No method asJSON S3 class: units

However, the default utils::View() function can still display these datatypes. It would be great if either:

VSCode-R View() function could automatically default to using utils::View() if an asJSON error is encountered, or
The error message returned by VSCode-R View() function could direct users to try using utils::View() to display the dataset.

Thanks for reporting! I could reproduce this with the following code:

df <- data.frame(
  diff = difftime(Sys.time() + 1:2, Sys.time(), units = "s")
)
View(df)

Error: No method asJSON S3 class: difftime
Backtrace:
1: base::stop(..., call. = FALSE)
2: stop("No method asJSON S3 class: ", class(x))
3: .local(x, ...)
4: FUN(X[[i]], ...)
5: FUN(X[[i]], ...)
6: vapply(x, asJSON, character(nrow(x)), collapse = FALSE, complex = complex,
7: .local(x, ...)
8: FUN(X[[i]], ...)
9: FUN(X[[i]], ...)
10: vapply(x, asJSON, character(1), na = na, auto_unbox = auto_unbox,
11: .local(x, ...)
12: asJSON(x, dataframe = dataframe, Date = Date, POSIXt = POSIXt,
13: asJSON(x, dataframe = dataframe, Date = Date, POSIXt = POSIXt,
14: jsonlite::toJSON(x, ...)
15: jsonlite::write_json(data, file, auto_unbox = TRUE)
16: View(df)

Does it work for you if we do either of the following

Use jsonlite::toJSON(..., force = TRUE) to force converting to JSON so that difftime will become numerics but without " secs" in the formatted string representation.
Format the columns that do not implement asJSON method into their string representation.

Yeah, that should work great! The string representation can be unhelpful for certain objects, they become very long strings that can be irritating to navigate in a table---but I think  that's what utils::View() does too, so it certainly would not be a step backwards. I also think a placholder [OBJECT] string would be fine for objects that can't be converted to JSON, users can't expect every R object to be perfectly displayed!

Any updates on this? After a recent update, it seems like you can no longer call utils::View() to get a window outside of vscode.

Any updates on this? After a recent update, it seems like you can no longer call utils::View() to get a window outside of vscode.

We don't use force=TRUE yet.
#818 replaces utils::View() so that tibble::view() could work properly. To get a window outside of vscode, you need to specify the following settings in vscode to disable the vscode data viewer:
"r.session.viewers.viewColumn": {
  "view": "Disable"
}

Still no solution for viewing tibbles that include a difftime column.
d = tibble(a = difftime(Sys.time(), Sys.time() - 853563))
View(d)
## Error: No method asJSON S3 class: difftime

I guess the only thing we could do is use force=TRUE then.


[WIP] Reconnection service graph migration flow

[x] - Using the schema_id contained in the event from the event queue, retrieve the corresponding paginated storage from the blockchain
[x] - Using the retrieved pages, build an import bundle
[x] - Import the bundle into GraphSDK
[x] - Apply graph updates as indicated by the Provider's graph retrieved from the provider
[x] - Export modified graph to an export bundle
[ ] - Write each page in the export bundle to the blockchain
[ ] - If any page update fails on-chain (likely due to a stale content hash), repeat steps https://github.com/AmplicaLabs/reconnection-service/issues/1-3 and https://github.com/AmplicaLabs/reconnection-service/issues/5-6 (should not need to repeat step https://github.com/AmplicaLabs/reconnection-service/pull/4 as GraphSDK retains knowledge of pending updates.
[ ] - If fail to update graph on-chain more than N times, move the queue job to the failed queue.

Closes #22
Closes #21

Hmm, not sure I'm happy about copying all of the scaffolding into this project... but I see the necessity. I'll throw a chore into the backlog to factor it back out and promote the frequency-scenario repo to publish a package instead. No need to do it now, but lets not lose track.
Can we at least trim down the copied scaffolding to only the helpers we actually need? There's a lot of extraneous stuff in there.


vm/vmss create: default on accelerated networking for all VM sizes

Fix #6999

[x] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

[x] I adhere to the Command Guidelines.

@yugangw-msft do you want this for this milestone?

@troydai, if i can, because it is very simple

Closing as we are still in discussion


[iOS] Widget Articles Are in Random Order

Articles are added to Sets and left unordered in the widget encoder. This means that when the widget data is encoded the articles are in a random, inconsistent order each time.

@stuartbreckenridge Would you please not bundle unrelated bug fixes and features into omnibus pull requests? It makes it really hard for me to validate what changed and why.

(This fix is no longer part of the #3778 PR.)


Usage question

In the example case of ...
$hunter->findEmailByDomain('forrester.com', 'Brendan Witcher');
... how would you then access the output via PHP?
{
    "data": {
        "first_name": "brendan",
        "last_name": "witcher",
        "email"<EMAIL_ADDRESS>        "score": 84,
        "domain": "forrester.com",
        "position": null,
        "twitter": null,
        "linkedin_url": null,
        "phone_number": null,
        "company": "Forrester",
        "sources": []
    },
    "meta": {
        "params": {
            "first_name": null,
            "last_name": null,
            "full_name": "Bredan Witcher",
            "domain": "forrester.com",
            "company": null
        }
    }
}

It is a json string so you would need to:
$responsefromcurl = json_encode($data, TRUE); echo $responsefromcurl['data']['first_name']; // gives you first name


NVIDIA India's HPC Peer Communities

I got this email from NVIDIA India a few days ago. It goes like this:

NVIDIA India is launching focused digital communities for HPC practitioners, in areas such as molecular dynamics, CFD, deep learning, etc. The objective is to network, share, learn and discuss issues and challenges facing the Indian HPC segment.
Please note these communities will not be used for NVIDIA marketing or promotion and intends to be technically focused. Please also mention when registering what you think the right digital medium should be (ex: WhatsApp, LinkedIn, Facebook groups, etc).
If interested in receiving an invitation, please email your name, title, organization, business email and mobile number to<EMAIL_ADDRESS>
I remember reading Anirudh Bose's blog post about the HPC cluster at our college
I don't know why I'm raising an issue about this but it might help ML/DL folks get access to high performance machinery or help out people interested in HPC
Should we as a college apply to be a part of this community? I need everyone's opinion as I don't really know much about this subject or this program and it would also be nice if someone could do some research on this program to know whether this would be a good step or not.
@p-society/2019-batch @p-society/2020-batch

Hey this is a cool initiative.Lets think of applying for it and take advantage of perks from NVIDIA. @palash25 can you share the link to the details of program so that we can have a look at the aim of the program ?

@saiamrit I am sorry but I don't have a link only the mail
I tried looking it up but couldn't find anything on their site

@palash25 @saiamrit  My professor at IIT Bhu applied to this scheme last year and got Nvidia Titan Xp.

@p-society/2019-batch @p-society/2020-batch , we should apply for this.

He told me about that few days back. Actually every year professors from different colleges apply to this. Some selected institutes based on the projects gets support from Nvidia

okay cool @ankitjha97 @hdidwania @shivank01 @AbhiRepository lets have a look into it.I guess Ajaya Sir might be having some idea about it because I remember once he had mentioned about NVIDIA offering him some hardware.

@ankitjha97, any reply regarding the Intel application??
Yes, Ajaya Sir can help , but the important thing is we have show good projects that are being carried out in our college.

ping @ayush1999 your thoughts?

This is different than the scheme where NVIDIA provides free GPUs to professors/researchers (https://developer.nvidia.com/academic_gpu_seeding).
About the mail, the objective seems really unclear. Why does it seem they are looking to form a discussion forum/platform, which will most probably help NVIDIA know about the issues and challenges it's target community faces. I don't see enough of how can joining this group help us, as from what I can understand from the mail.

@arijeetsat , no email yet.

If there is no progress on this and if it is not a viable option for us then please someone close this.

It is viable option and still a issue we are keeping an eye on, lets not close it.

Fine then I have assigned you to it. So that you can keep an eye on it and update it when the time comes you can close this :smile:

Hi, just chiming in, the PI needs to have a PhD degree to apply for this. We had thought to get a Nvidia P5000 for Visioneering though this but Ajaya Sir still hasn't got his PhD yet.


Add near zero-copy Import & Export for Arrow BinaryView/Utf8View formats

This change adds support for import/export of BinaryView and StringView from/to Arrow significantly boosting the performance of import and export of strings through the Arrow bridge.
Benchmark results show a gain of 4.3x (non-inline strings) - 18x (inline strings) faster for export and 2.2x (non-inline strings) - 7x (inline strings) faster for import of utf8view strings as compared to utf8 strings.

Hey @pedroerp , do you mind taking a look at this?

@kgpai Looks like the build failed for one of the checks. Not sure if this was due to the change itself. I also see that Conbench performance report found 1 possible regression. Could you help me with these two issues?

Not sure why the fuzzer job failed, I am re-running it.
I am hoping to review this next week. I dont think we need to worry about the conbench results yet.

@pedroerp I updated the PR

Hi @kgpai and @pedroerp, kindly let me know when you get a chance to review the PR again. Thanks!

@pedroerp following up on this! Please review my comments and code change again when you get a chance

Please also rebase or merge in main to fix linux CI.


Rename duplicate $block-grid-maxto$xy-block-grid-max` ...

Allow for both types of block grids.
Closes #10432

Migration note: $block-grid-max was not separated for xy-grid and regular grids. The xy-grid setting has been separated out to $xy-block-grid-max. If you have changed the value of $block-grid-max and are using the xy-grid, you should update $xy-block-grid-max.


Retrieve all defined flags

Hey! We currently can retrieve all flags for a scope (user) using Feature::all() or $user->features()->all. How about retrieving a list of flags that can be used without their status/value?
I am writing an action for Laravel Nova so that staff could toggle the flags, or provide a rich value, if applicable. Of course I can take the keys from the previous method since they all will be same for all the application but perhaps we could introduce a method to retrieve all registered features.
What do you think?
I am open to contributing as well.

Hi @flexchar. In this case, it's best that you send in a PR so we can look at the code involved. Thanks

I don't maintain the codebase of Pennant directly. It's best that you just send in a PR with your idea. If it doesn't work out you can always adopt the code directly or fork the package.

@flexchar, you should be able to use Feature::defined() to retrieve all defined features for a the driver.

Thank you Tim! It actually was it. I put a todo to make a PR for laravel docs to mention it. :)


Add Sidebar hide/show option

Option to always show sidebar.

Responsive layout is added to hide sidebar when window width get smaller.

Merge master branch and fixed some conflicts.


Adding map for response handlers

maybe we need regex-matching for the response handlers or something like startsWith

Seeing this, I think the better solution might be to pass the response handler into the write() and store it on the connection? Let's discuss in the VC.

PR #5 is better - closing this one


add support for zones/:id/activation_check

This would be nice to have:
https://developers.cloudflare.com/api/operations/put-zones-zone_id-activation_check

Do you want to try submitting a PR?

TBH i dont have lots of time to dig into the code but I get this error
Cloudflare::RequestError: https://api.cloudflare.com: PUT /activation_check : No route for that URI

I just copied what was in cache purge which has identical url structure with /:zone_id/
Is there a quick answer you know off top of head with what is missing?
		def purge_cache(**options)
			if options.empty?
				options = DEFAULT_PURGE_CACHE_PARAMETERS
			end

			self.class.post(@resource.with(path: "purge_cache"), options)
		end

		def activation_check
			self.class.put(@resource.with(path: "activation_check"))
		end

https://developers.cloudflare.com/api/operations/put-zones-zone_id-activation_check

I dont know if something was cached or what, but now it appears to work in my PR

No route for that URI looks like a response from Cloudflare, in other words, the request worked, but the response was an error.


References?

Hi, is this DGGS is based on the Sirdeshmukh's master thesis?
PS: I am looking for a DGGS with quadrilateral  cells (equal-area rhombus), to represent cell ID by base16h codes, like here. Other quadrilateral DGG  do not meet the basic requirements, e.g.  S2 Geometry is not equal-area... But Sirdeshmukh's grid looks good.

@ppKrauss, It's a good question.
As noted in README, the primary method is based on Sirdeshmukh's proposed method.
But the implemented structure is a little bit different;

the original one is maximally occupied 32 bits for each axis; x(32), y(32), z(32). But this project used x(32), y(32), z(24).
the maximum (or boundary) value of the coordinates boundary is slightly different. (Maximum (and Minimum) Z value is near 10km~ for making the height (and altitude) length as the same length of the side of the rhombus.
lastly, the projection method algorithm is different; (it's based on geogrid, not Sirdeshmuk's one)


Mailchimp automation doc recover

emmu pers a doc e mailchimp automation

Old Doc
How to install and use Mailchimp Automation plugin for EDD and RCP
Go to the WordPress admin panel and go to the “plugins” menu. Click on the “add new” button on the top and then upload the plugin.
Select the udesly-mailchimp-automation.zip file from the plugin folder and then click on the “install now” button. Wait for the installation and then activate the plugin.

Preliminary Remarks
This plugin allows to create automations for EDD e-commerce platforms, so you have it hooked up to Mailchimp and standard automations working with native WordPress hooks.
Also, a pre-configuration for RCP is available.

Plugin Panel
Automations
This section allows to create and handle all the automations you want to implement between EDD and Mailchip. Take a look here to see how to connect your store to Mailchimp.
Can choose between pre-configurated or custom automations. Pre-configurated ones consists in a list of triggers corresponding to a certain action that the user makes in the store (complete a payment, add to cart, remove from cart, etc.). Also, some triggers for RCP are pre-configurated.
Custom automations permits to insert other hooks made available by WordPress or any other plugin installed.

Settings
Here Mailchimp API and Data center must be inserted. If you have trouble creating your API, take a look at this guide.

Ecommerce
This section contains data necessary to hook EDD to Mailchimp.
The Sync button is very important. By clicking on it, you'll be able to synchronize EDD products and bring them on Mailchimp and create dynamic campaigns.
Abandoned Cart
The plugin registers the carts abandoned by users on EDD and, once a day, sends them to Mailchimp which will do a specific action based on a specific configurations set by the user.
This function can be paused.

done


_id not set on upsert

The PHP manual explains that passing the array('upsert' => true) option to a call to MongoCollection::update() will add an _id value to the array if the object was inserted. This is not support in this library since the $newObj argument on update() is not a reference.

When I tested this it was not adding the _id to the array.


fix: correctly call lsp_format = 'fallback'

This fixes the fallback behavior to use it when no other formatter has been used, instead of checking for filetype formatters as well. I tested it locally and it seems to work without any side-effects.
Please feel free to disregard this if you think a better approach is available or this PR introduces some side-effects that I can't think of.

Thanks for the fix! This does fix the issue, but I went with bde3bee1773c96212b6c49f009e05174f932c23a instead. I think it is a "more correct" way to address the problem

I guess M.will_fallback_lsp is not used any more?

M.will_fallback_lsp is not used anymore. It is preserved to retain backwards compatibility, but we don't call it directly.


Announcing new Lead Maintainer: @vitorgalvao

Making this issue as a marker to announce that @vitorgalvao is officially taking the title of Lead Maintainer for this project.
Anybody who has interacted with Homebrew Cask will understand that this is an easy move to make - this project would not be anywhere near where it is without Vítor's countless hours of hard work.
By taking on this role, Vítor will be able to make decisions and continue to move the project forward, without having to wait on any other slow-to-respond maintainers like that @phinze guy. :wink:
Congratulations @vitorgalvao, this is more than well deserved - it's long overdue! On behalf of the entire community of Homebrew Cask users - thanks for all you do. :green_heart:

Thank you, @phinze!
For anyone reading this issue and wondering what that means in practice, there are many ideas in store, including some functional changes (““To install, drag this icon…” no more!” is still the goal, naturally).
More updates on this should come, perhaps with a link from the README to an always up-to-date document detailing everything, but I’m still thinking if that’s the best (most effective) way. Right now, the priority is to integrate some of the current contributors into the team, that you should be seeing soon.


decode_status() doesn't work

There's a bug in decode_status(). You can't instantiate a List in that way.

Covered by #58


Finish Data.Spine implementation

TODO:

[ ] Deriving Sing in TH
[ ] Complete SpineTagged datatype utils (like https://hackage.haskell.org/package/tagged/docs/Data-Tagged.html)
[ ] HasField TH generation
[x] Fields list per spine (KnownSymbol?)

DSL pivoted from that kind of typing


Fix crash on going through multiple photos

close https://github.com/zhangao0086/DKImagePickerController/issues/592
Fixed crashing on going through multiple photos speedy by cancelling loading.

Thanks for your PR!!!


Fixes to update & watch functionality for TPRs

This PR is a combination of #410 and #439. It will replace those two, but is not ready for merge yet.
Closes #410
Closes #439
Fixes #436
Fixes #406

The functionality herein works properly. After creating a broker with an invalid URL, the controller properly picks it up and updates the status properly:
ENG000656:service-catalog aaronschlesinger$ ks get broker -o yaml test-broker
apiVersion: servicecatalog.k8s.io/v1alpha1
kind: Broker
metadata:
  creationTimestamp: 2017-03-06T18:53:47Z
  name: test-broker
  resourceVersion: "1493"
  selfLink: /apis/servicecatalog.k8s.io/v1alpha1/brokerstest-broker
  uid: 3ae44ce4-029e-11e7-a591-080027d16e09
spec:
  url: http://beefco.de
status:
  conditions:
  - message: Error fetching catalog
    reason: ErrorFetchingCatalog
    status: "False"
    type: Ready

Command decision on this one - we've seen it work and it's behind a feature flag.  I've verified that it works in my cluster and will merge on green.


cache and retry queued messages when internet down in managed client

Describe your question
I used managed client with WebSocket protocol, it is not clear that does this client support caching or queuing messages when the internet is off and tries to send them when the connection is available and also re-connect performed automatically?
Which project is your question related to?

ManagedClient

Does the Managed Client Wiki page answer your questions?

In my case it was resolved by these Nuget packages:
-MQTTnet
-MQTTnet.Extensions.ManagedClient
I wrote a MqttClient like this:
public class MqttClient
    {
        private static IManagedMqttClient client;

        public static async Task ConnectAsync()
        {
            string clientId = Guid.NewGuid().ToString();
            bool mqttSecure = true;

            var messageBuilder = new MqttClientOptionsBuilder()
              .WithClientId(clientId)
              .WithWebSocketServer("wss://chat.mydomain.com/mqtt")
              .WithCleanSession();

            var options = mqttSecure
              ? messageBuilder
                .WithTls()
                .Build()
              : messageBuilder
                .Build();

            var managedOptions = new ManagedMqttClientOptionsBuilder()
              .WithAutoReconnectDelay(TimeSpan.FromSeconds(5))
              .WithClientOptions(options)
              .Build();

            client = new MqttFactory().CreateManagedMqttClient();

            client.UseConnectedHandler(e =>
            {
               //log connected event
                Sentry.SentrySdk.CaptureMessage("Connected successfully with MQTT Brokers.");
            });

            client.UseDisconnectedHandler(e =>
            {
               //log disconnected event
                Sentry.SentrySdk.CaptureMessage("Disconnected from MQTT Brokers.");
            });

            await client.StartAsync(managedOptions);
        }

        public static async Task PublishAsync(string topic, string payload, bool retainFlag = true, int qos = 1) =>
                                await client.PublishAsync(new MqttApplicationMessageBuilder()
                                .WithTopic(topic)
                                .WithPayload(payload)
                                .WithQualityOfServiceLevel((MQTTnet.Protocol.MqttQualityOfServiceLevel)qos)
                                .WithRetainFlag(retainFlag)
                                .Build());

    }

And for connecting and publishing messages:
await MqttClient.ConnectAsync();
await MqttClient.PublishAsync($"topic", "payload body message");

Does the Managed Client Wiki page answer your questions?

Yes, thanks.


Dual can't handle params from the DS Bar

Field 'blah' is not valid for this datasource
where  DS Bar has blah=blip

This bug is down to confusion over the inconsistencies in how params work.
With foo=123, you need to do param('foo') in StroomQL and table expressions but ${foo} in the dashboard search expression terms.
Agreed approach is to deprecate the ${foo} form in expression terms and to use the param('foo') form everywhere for consistency.
Also need some documentation on params.


Forcasts disappeared

I had the custom weather card working well for a few days and all of a sudden the forecasts have seem to have disappeared.

There is no errors at all in the logs and everything else is operating normally.
Any pointers on how to troubleshoot further?

Anything interesting in your logs? What is your geohash? Does it resolve after a reboot?

Nothing in the logs at all. Tried to reboot and still the same.
However, it has resolved itself just now (about 6 hours later). Unsure as to how I could find the cause.
Will resolve the issue. Any pointers for future debugging are appreciated.

If it breaks again, try browsing to these URLS to see if they work, but put your own geohash code in the URL. You can get your geohash code if you enable debug level logging for this component.
https://api.weather.bom.gov.au/v1/locations/r1f3pw/observations
https://api.weather.bom.gov.au/v1/locations/r1f3pw/forecasts/daily
Put this on your config to enable debugging.
logger:
  default: warn
  logs:
    custom_components.bureau_of_meteorology: debug

Thanks for the info. Much appreciated. Will check this next time it happens.
Thanks for the great work on the integration. It's highly useful!

The same issue has been occurring for last days and I managed to locate the root cause of the issue.
When I use my geohash from the debug logs the "forecasts" endpoint actually returns the NULL values.
Question is now how to change the setup as it doesn't seem to be exposed with an edit function anywhere in the UI.

#56 This seems to be related.

@leogaggl I'm not sure #56 is related - in that issue the remainder of the forecast is present, and only the short_text is null. I have verified this is the case in the json provided by the BoM API.

@leogaggl When I have looked at your location URL, it seems fine. When it's not working for you can you please copy/paste the contents of the URL?

@leogaggl
I'm closing this one for now, please comment/reopen if required.

@leogaggl
I'm closing this one for now, please comment/reopen if required.


[python3] Install debug versions of .pyd files

Is your feature request related to a problem? Please describe.
I'm using the python3 port to embed Python into my program via the python DLL. At runtime, apart from the DLL, some more files are necessary, specifially the .py files of the Python standard library as well as the .pyd files of the native modules.
The python3 port installs the .pyd files to <packagedir>/tools/python3/DLLs, from where I can copy them to my application build and install directories. This, however, only works for a release build. In a debug build of my application and the Python interpreter, I cannot load any native modules, since the debug versions of the .pyd files are not available anywhere to copy. The debug version of the interpreter does not load the non-debug .pyd files. The debug versions are named the same as the release versions, but with _d in the name. So for example, the debug version of _ctypes.pyd is _ctypes_d.pyd.
Proposed solution
The debug .pyd files should be installed to some location in the package, for example alongside the non-debug versions or to  <packagedir>/tools/python3/debug/DLLs.
Describe alternatives you've considered
Additional context
It seems that the debug .pyds are not copied over by intent: https://github.com/microsoft/vcpkg/blob/e46521db005de9208c9ed79ef4f96e212cb9a25a/ports/python3/portfile.cmake#L159
I have a locally patched version of the python3 port without this line and this then fully supports my use case.
This only applies to the Windows platform, as far as I'm aware.

Thank you for your issue. Only Release-related files are allowed in the <packagedir>/tools directory of vcpkg. If you need Debug-related files, you can modify them locally.
You can modify it by patching, or by using --overlay-ports.

Hm that's good to know, do you have a source for that? qt5-base definitely installs debug stuff at tools/qt5/debug (that's where I have the suggestion from). Maybe that is also in error though?
In any case, rule notwithstanding, not having the _d.pyd files makes the port pretty much useless for embedding and while everything can be of course solved with overlay ports, I think it makes sense to have the official port file properly support embedding. Maybe there are other solutions that do not conflict with this rule?

Additional context
It seems that the debug .pyds are not copied over by intent: https://github.com/microsoft/vcpkg/blob/e46521db005de9208c9ed79ef4f96e212cb9a25a/ports/python3/portfile.cmake#L159

@BillyONeal
I found that this record was first added by you in https://github.com/microsoft/vcpkg/pull/14891, could you please answer the questions here?

first added by you

I think you mean @Hoikas :)

I suspect that you have already stated the reason...

Thank you for your issue. Only Release-related files are allowed in the /tools directory of vcpkg. If you need Debug-related files, you can modify them locally.
You can modify it by patching, or by using --overlay-ports.

If that restriction has since been relaxed, a pull request to add the debug pyd files would probably be a good idea.

MonicaLiu0311 deleted a comment from BillyONeal yesterday

Hmmm?

So far, no one cited where this rule is written down (and other ports are "violating" it)

This is fallout from what the intent of tools is: to provide some program for another port to consume during their build process, where debug binaries don't actually help anything. We're very explicitly trying to avoid making vcpkg a release deployment (as in, like apt) competitor, because we don't think our model is well suited to that use case, and encouraging folks to build stuff in that direction would only make them have problems with us when we don't add additional functionality in support of that use case.
Python is the mother of all edge cases though, because it doesn't really have good separation between "python the tool we just need to run a build tool like meson" and "authoring extensions that you intend to load somewhere in to python".

In a debug build of my application and the Python interpreter, I cannot load any native modules, since the debug versions of the .pyd files are not available anywhere to copy.

Can you describe what you're doing in more detail here? As in, are you deploying a python.exe with your application or ... ?

MonicaLiu0311 deleted a comment from BillyONeal https://github.com/microsoft/vcpkg/issues/28130#event-8625211521

Hmmm?

Sorry, it was a mistake, the original content was to Ping@ the person who added list(FILTER PYTHON_EXTENSIONS EXCLUDE REGEX [[.*_d\.pyd]])  for the first time.

Sorry, it was a mistake, the original content was to Ping@ the person who added list(FILTER PYTHON_EXTENSIONS EXCLUDE REGEX [[.*_d\.pyd]])  for the first time.

I see 🤷 it happens :)

Can you describe what you're doing in more detail here? As in, are you deploying a python.exe with your application or ... ?

I can take an educated guess as to what the use case is. In your explanation:

Python is the mother of all edge cases though, because it doesn't really have good separation between "python the tool we just need to run a build tool like meson" and "authoring extensions that you intend to load somewhere in to python".

You missed another use case. "Embedding the Python interpreter into your own application (potentially with extensions that you've authored)." This means that you have python included inside your .exe, not that you're redistributing python.exe. In that case, you will need the .pyd files available if the Python code in your application needs to use functionality exposed by Python. For example, you may need _socket.pyd and/or _ssl.py do anything network related. Unfortunately, the Python debug and release libraries are not ABI compatible on Windows, so the debug .pyd files are required.
Python is really one of the very few cases I can think of where we really need control of the entire tool in vcpkg because you can literally have a project that wants to use python.exe to script its build process, build an extension, and embed the interpreter itself inside of the project used by the end user. CMake's FindPython is extraordinarily brittle and explodes in terrible ways when Python components are even slightly mismatched. 😢

I can take an educated guess as to what the use case is. In your explanation:

Seems I was too slow, but this is exactly the use case. It's also written in my first post, though :) "I'm using the python3 port to embed Python into my program via the python DLL. At runtime, apart from the DLL, some more files are necessary, specifially the .py files of the Python standard library as well as the .pyd files of the native modules. [...] In a debug build of my application and the Python interpreter, I cannot load any native modules, since the debug versions of the .pyd files are not available anywhere to copy. The debug version of the interpreter does not load the non-debug .pyd files."

We also need the debug version of the DLLs files. Any idea if this case will be implemented? Probably the path should be:
<packagedir>/debug/tools/python3/DLLs
Thanks,

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 28 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.

Would still appreciate a solution to this. #32297 was opened as a suggestion, it seems.

Thanks @MonicaLiu0311!


oneagent Daemonset pods interfering with aws-vpc-cni node startup

We have dynatrace-operator running in our EKS clusters using the helm chart: https://github.com/Dynatrace/helm-charts/tree/master/dynatrace-operator/chart/default
Recently, when we updated the aws-vpc-cni addon, we noticed that it wasn't able to startup. The reason seemed to be an injected dynatrace library.
Events:
  Type     Reason     Age               From               Message
  ----     ------     ----              ----               -------
  Normal   Scheduled  26s               default-scheduler  Successfully assigned kube-system/aws-node-587pv to ip-*-*-*-*.ap-southeast-2.compute.internal
  Normal   Pulled     25s               kubelet            Container image "602401143452.dkr.ecr.ap-southeast-2.amazonaws.com/amazon-k8s-cni-init:v1.9.3" already present on machine
  Normal   Created    25s               kubelet            Created container aws-vpc-cni-init
  Normal   Started    25s               kubelet            Started container aws-vpc-cni-init
  Normal   Pulled     24s               kubelet            Container image "602401143452.dkr.ecr.ap-southeast-2.amazonaws.com/amazon-k8s-cni:v1.9.3" already present on machine
  Normal   Created    24s               kubelet            Created container aws-node
  Normal   Started    24s               kubelet            Started container aws-node
  Warning  Unhealthy  4s (x2 over 14s)  kubelet            Readiness probe failed: /app/grpc-health-probe: symbol lookup error: /opt/dynatrace/oneagent/agent/bin/current/linux-x86-64/liboneagentproc.so: undefined symbol: __environ

We had to do the following steps to workaround this issue:

Uninstall dynatrace-operator
Delete the oneagent daemonset (because that doesn't happen as part of operator uninstallation)
Wait for the aws-vpc-cni Daemonset to progress
Reinstall dynatrace-operator

This does not manifest for new nodes, because aws-node Pods start (and has to) before any other Pods including oneagent Pods. This only manifests when we update the cni Daemonset.
Versions:
EKS: 1.20
dynatrace-operator: 0.3.0
OneAgent: 1.231.245

Sorry, yes, you are right. It is a oneagent issue and not specifically an operator issue. I imagine oneagent is not hosted on GitHub though. We do have a support ticket open with the same details.
About uninstalling the operator, the document you provided is for operator installed using vanilla k8s manifest (kubectl apply/delete -f). However, we manage it using helm. And the mechanism we know of about uninstalling applications using helm is: helm uninstall dynatrace-operator. We have also noticed that updates to the helm chart recreates activegate StatefulSet and oneagent Daemonset. I'll create a separate issue for that though.

Issue for unexpected chart update and uninstall behaviour: https://github.com/Dynatrace/helm-charts/issues/172

We saw this issue as well, we were able to come to another solution that might be useful. If you go into the dashboard and tell dynatrace not to monitor the namespace of aws-node-* pods, then it will not try to inject on launch of the pods.

Yup, that's the recommendation we got from dynatrace support and that worked for us too

Note for anyone finding this.
Please update your oneagent to v1.237.110 or greater.

also happening for dynatrace:1.47.1001


BoxTree does not consider brackets

Hi, I'm trying to dump out the char boxes of math formula. But I find that box tree generation does not consider the bracket  case. Given a formula (x+y)^3, the exponential term was only attached to ), not the (x+y).  How can get this fix this parsing order. Thx.
0    HBox
1    ├── CharBox                         (
1    ├── GlueBox
1    ├── CharBox                         x
1    ├── GlueBox
1    ├── CharBox                         +
1    ├── GlueBox
1    ├── CharBox                         y
1    ├── GlueBox
1    └── HBox
2        ├── CharBox                       )
2        ├── HBox
3        │   ├── CharBox                  3
3        │   └── StrutBox
2        └── StrutBox

the formula should be written as {(x + y)}^3.


Remove outbound commands, get on blaze master

This gets us working again off blaze master, so we can release that as blaze-0.14.0 before http4s-0.19.0.

This build will fail, but I think it will go green after blaze-0.14.0-M5 hits Maven Central.
I'll be alseep by then, in case someone wants to restart it.


crypto/tls conn sometimes hangs when calling tls.Handshake()

Please answer these questions before submitting your issue. Thanks!

Attempted to connect to a websocket server.
Overtime, if the server goes down or is unreachable, the attempt to reconnect can hang.
Connection hangs indefinitely when I attempt to connect to a websocket server.  It hangs when going through the line below
https://github.com/gorilla/websocket/blob/master/client.go#L331
*note my stack trace points to an older version at line 307 in gorilla
What did you expect to see?
A timeout atleast if the handshake takes too long
What did you see instead?
Hang of the connect.  Stack trace below
goroutine 5177739 [IO wait, 3658 minutes]:
net.runtime_pollWait(0x7fae11ebe220, 0x72, 0x11)
gosrc/src/runtime/netpoll.go:160 +0x59
net.(*pollDesc).wait(0xc4204a2a70, 0x72, 0xc4207250c0, 0xc420010140)
gosrc/src/net/fd_poll_runtime.go:73 +0x38
net.(*pollDesc).waitRead(0xc4204a2a70, 0xec0cc0, 0xc420010140)
gosrc/src/net/fd_poll_runtime.go:78 +0x34
net.(*netFD).Read(0xc4204a2a10, 0xc4201a6000, 0x800, 0x800, 0x0, 0xec0cc0, 0xc420010140)
gosrc/src/net/fd_unix.go:243 +0x1a1
net.(*conn).Read(0xc420426e10, 0xc4201a6000, 0x800, 0x800, 0x0, 0x0, 0x0)
gosrc/src/net/net.go:173 +0x70
crypto/tls.(*block).readFromUntil(0xc4204ca6c0, 0x7fae11ebe308, 0xc420426e10, 0x5, 0xc420426e10, 0x4176ff)
gosrc/src/crypto/tls/conn.go:476 +0x91
crypto/tls.(*Conn).readRecord(0xc420103500, 0x514, 0xc4204cb1a0, 0x30)
gosrc/src/crypto/tls/conn.go:578 +0xc4
crypto/tls.(*clientHandshakeState).readFinished(0xc420725710, 0xc4201035de, 0xc, 0xc, 0x0, 0x0)
gosrc/src/crypto/tls/handshake_client.go:635 +0x50
crypto/tls.(*Conn).clientHandshake(0xc420103500, 0xa62758, 0xc420103608)
gosrc/src/crypto/tls/handshake_client.go:244 +0x10ee
crypto/tls.(*Conn).Handshake(0xc420103500, 0x0, 0x0)
gosrc/src/crypto/tls/conn.go:1260 +0x1b8
stash.teslamotors.com/STST/tools/vendor/github.com/gorilla/websocket.(*Dialer).Dial(0xc420326b90, 0xc4207a3bc0, 0x30, 0xc4207a3b00, 0x0, 0x0, 0x0, 0x0)
go/src/stash.teslamotors.com/STST/tools/vendor/github.com/gorilla/websocket/client.go:307 +0x1380

If the underlying connection has no timeouts (deadlines), then Handshake won't time out.
I'm not sure there's anything to fix here. If you write programs interacting with the network, you have to be pretty defensive about the network being flaky and slow. But opinions on what is slow differ.

@bradfitz there is a dialtimeout of 30seconds, I've created a ticket with in the gorilla project as well to see if it's a bug there.
https://github.com/gorilla/websocket/issues/179

If the DialTimeout is on the underlying TCP dial, that doesn't affect the TLS handshake's Read/Write at all.


404 Errors Under Load

@mattmarcello to fill in details

reproducible with this command:
autocannon  https://api.counterparty.io:14000/v2/addresses/tb1q6c4r68274alzkjchfd3yx4e0ff0e08ktyps/balances
https://www.npmjs.com/package/autocannon

Not reproducible locally? LB issue?

Not a node issue. See https://github.com/UnspendableLabs/infrastructure/issues/41


ISSUE-68 Disable Coverage for framework schemes

Fix for #68. Thanks to @Jur4s shout out.

Coverage remained the same at 99.111% when pulling 7fc916a5ace59374c733b2237dd96a097b3fb44c on issue-68-disable-gather-coverage into 14f04e250fca873c05b3f6350c85e984f02208fc on master.

Coverage remained the same at 99.111% when pulling 1bb61e7361d67884eb5a5a44deaa320434be616d on issue-68-disable-gather-coverage into 14f04e250fca873c05b3f6350c85e984f02208fc on master.


Reproduction for vision models

Thank you for the great work and for releasing the code.
Do you plan to add a support for merging ViT's with TIES? I know I can get the checkpoint from task vectors repo and I can see some code related to ViT in your repo. However, it is incomplete and the configs are also missing. Would you be able to provide the code (and configs) that would allow reproducing vision results? I am especially interested in reproducing Tab. 10 and Tab. 11.
Thanks in advance!

Hi @prateeky2806, can we hope for the code supporting ViTs?


golang-1-darwin package is unused

Feature Request
The golang-1-darwin package is unused and should either be used or, failing that, removed.
Detailed Description
We ostensibly import the golang-1-darwin for the iso9660wrap package, but don't actually use it to build the package.
Context
See the bosh-google-cpi-release for an example of importing and using both the golang-1-darwin and golang-1-linux packages. Although it should be noted that it seems strange to have the packaging script output two binaries and have the job select. I would have thought that it would be easier to have the packaging script select which binary to build and output, and then have the job just use whichever it gets.
Possible Implementation

Use the golang-1-darwin package to build a darwin version of the iso9660wrap package.
Remove the golang-1-darwin package.

Complexity

[x] Low - Simple enhancement or bug fix, no architectural changes or refactoring
[ ] Medium - Change requires some thought, but is relatively isolated
[ ] High - Significant architectural change or large refactor

After chatting with Palermo, maybe instead we should actually use the platform in the packaging script to select between the golang-1-darwin package and the golang-1-linux package for building isowrap9660.

Not stale.

Not stale.

Well that's surprising. I was fully planning to just delete this, because it's clearly not used by the packaging script here: https://github.com/cloudfoundry/bosh-vsphere-cpi-release/blob/master/packages/iso9660wrap/packaging#L4
But then I went and looked at what compile.env.generic actually does, and it totally doesn't use the path the script is in, but uses the platform you are on to assume where the golang package will live!
https://github.com/bosh-packages/golang-release/blob/master/src/1/compile.env.generic
So even though it's calling the script inside of the golang-1-linux package, it will setup the go environment for golang-1-darwin
🤯
This feels like a mistake in the bosh-packages scripts, but at the same time, it almost feels like a terrible feature. It makes the calling side look broken, but at the same time, now the calling side doesn't need to use uname to figure out the platform and call the correct script?

🤯 That is wild!
I can't decide if I like that or not, but its lack of discoverability / clear purpose definitely doesn't help its case in my eyes.

Not stale

Should be "fixed" by https://github.com/cloudfoundry/bosh-vsphere-cpi-release/commit/de1553b7f7ee0cf09119d2683edd3fc4a808a72c.
The packaging script will now directly use the darwin package when doing a create-env on OSX.
This change was actually needed because the generic compile scripts in the golang-release no longer reach out and use a different packaged based on the detected platform.


Record Vocalizations (mix complex vocalizations with exciter)

This is a big story.
We need to record the following:

Dingo yelp
Yell
..


[chip-test, sival] chip_sw_otbn_keymgr

Test point name
chip_sw_otbn_keymgr
Host side component
None
OpenTitanTool infrastructure implemented
None
Silicon Validation (SiVal)
Yes
Emulation Targets

[ ] None
[X] CW310
[ ] Hyperdebug + CW310

Contact person
@GregAC
Checklist
Please fill out this checklist as items are completed. Link to PRs and issues as appropriate.

[ ] Check if existing test covers most or all of this testpoint (if so, either extend said test to cover all points, or skip the next 3 checkboxes)
[ ] Device-side (C) component developed
[ ] Bazel build rules developed
[ ] Host-side component developed
[ ] HJSON test plan updated with test name (so it shows up in the dashboard)
[ ] Test added to dvsim nightly regression (and passing at time of checking)
[ ] For SiVal test cases, test is running relevant FPGA or silicon regression

estimate 1

@HU90m, can we close this issue?


Remove legacy apps

Remove legacy apps, environments and schedules
Move files from client.api.teams.File to client.api.file.File
File documentation removed from api.__init__ docstring pending further work

Intend to close this are redo on the monorepo once the initial Local Apps work in complete (as it will borrow heavily from bits here)

Agreed


Add test case for Position class <testing

A simple testcase for the classes that extend from the Position class.

The code looks fine, but there are asserts grouped together which could easily be split up into separate test methods.

Split them up by a little bit. Groups of asserts aren't necessarily a bad practice.

Looks good!


Context-based stacks

This Pull Request enforces that there's no global stack in Thread anymore, but a stack on every context.
This doesn't grow the stack in one big Vec, but splits it into they individual contexts.
Stacks are kept separate, for security and modularity.

Did some stats with tokay.tok regarding runtime impact - there is none, so it works as good as before and is more modular.


On ubuntu Se wont start

First i wanna thank you for your scripts, 2nd if u could help me to find out whats problem of my server i ll be gratefull
I have run ur script and everything has done
ubuntu version 14.04.03 lts (64bit)
Im not really good with ubuntu as u can guess.
When i start se server it load but at end shut down for an error exception object
here's log:
http://pastebin.com/UZbQJzL5
config file is imported from my computer
Ty for ur attention :3
Sky

i dont think it works if you have planets on your map.. having same problems here

maybe something missing it ?  dunno any library ?

Hey SkyIT.  I just booted up my server from pre-planets, and even with the update (but no new save file, e.g. no planets in there) it works as expected.
Not to discourage you, but space engineers is an alpha game and running a dedicated server on ubuntu is an unsupported platform, so getting this up and running isn't for the faint at heart.  If you are ready to get deeper into resolving your problem, read on.
To diagnose what the problem is, remove all the complexities to your setup:

Create a new save game with only the stock asteroids in it (NO planets)
make sure your sbc and sbs files (the save game XML data) has no mods
turn off drones (its in the sbc file, which you can edit with any text editor)

Now, try and fire up your dedicated server again and see if you get the same error.  If not, add each of those things back in, one at a time, to narrow down which it is.  If you create a save file like above and it still gives you the error, zip up the save file and share a link to that zip as well and I'll test on my ubuntu 14.04.03 LTS server to see if we can narrow down what's causing it.

GOt it  wrong einvorment of wine .. was running 64bit instead of 32
Ty for script


add missing stub in av.sidedata

Requires: #1306

Please check, I am not sure if this fix is correct...

I think #1311 needs to be merged before this can.


Remove legacy autogenerated samples

All the samples under https://github.com/googleapis/java-talent/tree/main/samples/generated were created with an experimental generator. We need to fix the snippets on Cloudsite and then remove these unmaintained and untested samples.
See https://github.com/googleapis/repo-automation-bots/issues/2513

@meltsufin FYI

@eaball35 Could you take a look at this.


Add API key template

What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note:

@manlinl: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.
Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@manlinl: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
e1e0131fab7810551752fa9bccf0183e95db36d5
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm

/retest

/retest all

@manlinl: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
29707c61990ca64c98fdb81bb1a1f94b3b5a55af
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/testall

comment addressed, PTAL.

@douglas-reid Hey Douglas, can yo take a look of the updated PR pls?

/test istio-presubmit


502 error when using non-encoded URLs and no Accept: image/webp

When I try to retrieve an image without modifications using https://<distribution>.cloudfront.net/<s3-key> in Chrome, it is served just fine (in WEBP format), but when I try to do the same thing in Safari, I get an HTTP 502 response with the following body: {"message": "Internal server error"}.
This seems to be related to the Accept request header; when I change it from Chrome's default text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8,application/signed-exchange;v=b3;q=0.9 to text/html,application/xhtml+xml,application/xml;q=0.9,image/apng,*/*;q=0.8,application/signed-exchange;v=b3;q=0.9 (remove the image/webp), I get the same error.
I've tried to disable AutoWebP, but it doesn't make a difference.

@MidnightDesign I'm sorry to hear you had an issue. Can you share more details about the error (CloudWatch Logs) and how I can reproduce the issue? I've tried with simple jpg file on Safari and Chrome, and both worked.

@beomseoklee Thank you for the quick response.
First of all, I just tried it with another image and it worked just fine; with the image/webp header, I get the WEBP file, without it I get the (original) PNG.
But the original image still doesn't work.
In the ServerlessImageHandler-ApiLogs-... log group I get the message <IP_ADDRESS> - - [09/Apr/2020:16:39:47 +0000] "GET /{proxy+} HTTP/1.1" 502 36 5c740d4e-5331-4eba-acd9-0888eac6d08.
In the /aws/lambda/ServerlessImageHandler-ImageHandlerFunction-... log group I get:
START RequestId: 52f3f47c-da84-4e18-a840-6d1b367d4efc Version: $LATEST
2020-04-09T16:44:52.777Z	52f3f47c-da84-4e18-a840-6d1b367d4efc	INFO	{
  resource: '/{proxy+}',
  path: '/keepersport/KS406/KS406-D2.png',
  httpMethod: 'GET',
  headers: {
... (let me know if you need the full message)
2020-04-09T16:44:53.946Z	52f3f47c-da84-4e18-a840-6d1b367d4efc	INFO	ImageRequest {
  requestType: 'Thumbor',
  bucket: '...',
  key: '...',
  edits: {},
  ContentType: 'image/png',
  LastModified: 'Fri, 31 Jan 2020 13:13:30 GMT',
  CacheControl: 'max-age=31536000,public',
  originalImage: <Buffer 89 50 4e 47 0d 0a 1a 0a 00 00 00 0d 49 48 44 52 00 00 09 c4 00 00 09 c4 08 06 00 00 00 2e 73 f5 3d 00 00 00 19 74 45 58 74 53 6f 66 74 77 61 72 65 00 ... 4404676 more bytes>
}
[ERROR] [1586450696093] LAMBDA_RUNTIME Failed to post handler success response. Http response code: 413.
END RequestId: 52f3f47c-da84-4e18-a840-6d1b367d4efc
REPORT RequestId: 52f3f47c-da84-4e18-a840-6d1b367d4efc	Duration: 3321.88 ms	Billed Duration: 3400 ms	Memory Size: 1024 MB	Max Memory Used: 429 MB

@beomseoklee Can you deduce anything from that?

This seems to be somewhat cache-related.
If I request an image first with the image/webp header, then the 502 is returned on subsequent requests without it.
If I request an image first without the header value, subsequent requests work both with and without it.

@MidnightDesign I guess Lambda 413 is related to the payload size.
Would you mind sharing the original image and edits you used?

Here you go: https://d3p0lb6nhbndhk.cloudfront.net/keepersport/KS406/KS406-D2.png
I'm not using any edits in this case. I'm expecting lambda to just forward the original image.

Ping @beomseoklee

@MidnightDesign I'm sorry for the late response. I've tested this one, and I can confirm that this is related to the response body size.
Using WEBP format, the response body size was about 188,068 bytes. However, with pure PNG format, the response body size was about 6,852,680 bytes which is bigger than AWS Lambda's limit.
We are considering how we can dealing with the return image which is bigger than AWS Lambda's limit.
I'm sorry for your inconvenience at this time.

@beomseoklee would the Lambda limit have been an issue added with v5? I've just tried updating from v4 > v5 and had to revert back because we're getting a larger number of HTTP 502 responses with the following body: {"message": "Internal server error"}. In v4 this doesn't happen.

@amcfarlane We fixed wrong webp option in v5. In v4.2, even though you don't choose to use webp automatically, it converted the format to webp. We fixed this issue, and that might cause a bigger image size.

We've released v5.1.0 to mitigate this issue. The new version will throw a proper error message once your images exceed the Lambda limit.


Received 3 IPNs for the same transaction, only one flagged as duplicate

Hi!
I received 3 IPNs for the same transaction with the same data, but only one was flagged as duplicate. They have all the same transaction id and all the same payment status, and are all separated by one minute (3:00 am 3:01 am 3:02 am).
Only one got marked as duplicate so my system ended up processing the same payment twice.

This sounds like a valid issue. The code here looks buggy for the case when you have out-of-order notification of IPNs:
https://github.com/spookylukey/django-paypal/blob/24d914ba7f72c7bcab47445506f54558023c0a0b/paypal/standard/helpers.py#L17-L38
Could you check for your case that there were other IPNs with the same txn_id but different payment_status? Otherwise, we have to look further for the cause.
We should probably be instead checking for duplicate (txn_id, payment_status). I say "probably*, because that would involve trusting that PayPal are doing something sensible with how they send IPNs, or at least documented. Based on experience it's possible that neither are true...

Clearly, the code above checks only if the latest similar IPN has the same payment status. If the latest has a different status but the previous has the same, it doesn't recognize it as duplicate.
So the question is why we make this difference and not just this?:
duplicates = (ipn_obj.__class__._default_manager
    .filter(txn_id=ipn_obj.txn_id)
    .exclude(id=ipn_obj.id)
    .exclude(flag=True)
    .exclude(payment_status=ipn_obj.payment_status)
return duplicates.exists()

Still, it doesn't seem that that's what's going on here. If you look at the picture above, those are the only IPNs with that txn_id and all have the same payment_status. There are no other IPNs. After I ran verify() again (which calls duplicate_txn_id) one that was unflagged (3:01 am) became flagged as duplicate.
So maybe it happened that the first two (3 am and 3:01 am) arrived concurrently?
Here is the picture after running verify again:


Make template flags isPublic, isFeatured, isExtractable editable in ui

Description
This PR add template flags isPublic, isFeatured, isExtractable to ui

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[x] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

own vmware env

@DK101010 did you test this as admin? and also as user? did you try to get weird access right issues, i mean?

@DK101010 did you test this as admin? and also as user? did you try to get weird access right issues, i mean?

 :D

@DK101010 did you test this as admin? and also as user? did you try to get weird access right issues, i mean?

 :D

ok, not sure if a user is allowed the same on template flags as the admin, hence my question. testing will have to prove the pudding

@blueorangutan package

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 1914

@blueorangutan package

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 1918

@blueorangutan package

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1920

@blueorangutan test

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@DK101010 did you test this as admin? and also as user? did you try to get weird access right issues, i mean?

 :D

ok, not sure if a user is allowed the same on template flags as the admin, hence my question. testing will have to prove the pudding

Hmm ... good question. Have no Idea. These flags already existed in the old ui. How was it there?

Trillian test result (tid-2674)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33305 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5771-t2674-kvm-centos7.zip
Smoke tests completed. 86 look OK, 5 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_01_add_primary_storage_disabled_host
Error
0.62
test_primary_storage.py

test_01_primary_storage_nfs
Error
0.12
test_primary_storage.py

ContextSuite context=TestStorageTags>:setup
Error
0.22
test_primary_storage.py

test_01_secure_vm_migration
Error
170.26
test_vm_life_cycle.py

test_02_unsecure_vm_migration
Error
274.57
test_vm_life_cycle.py

test_03_secured_to_nonsecured_vm_migration
Error
147.32
test_vm_life_cycle.py

test_08_migrate_vm
Error
46.94
test_vm_life_cycle.py

test_03_deploy_and_scale_kubernetes_cluster
Failure
32.99
test_kubernetes_clusters.py

test_07_deploy_kubernetes_ha_cluster
Failure
63.78
test_kubernetes_clusters.py

test_08_upgrade_kubernetes_ha_cluster
Failure
44.27
test_kubernetes_clusters.py

test_09_delete_kubernetes_ha_cluster
Failure
0.05
test_kubernetes_clusters.py

ContextSuite context=TestKubernetesCluster>:teardown
Error
86.54
test_kubernetes_clusters.py

test_02_list_snapshots_with_removed_data_store
Error
9.50
test_snapshots.py

test_02_list_snapshots_with_removed_data_store
Error
9.50
test_snapshots.py

test_hostha_enable_ha_when_host_in_maintenance
Error
305.20
test_hostha_kvm.py

@blueorangutan package

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 1951

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1965

@blueorangutan test

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-2696)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31560 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5771-t2696-kvm-centos7.zip
Smoke tests completed. 91 look OK, 0 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File

There exist APIs updateIsoPermissions and updateTemplatePermissions which do pretty much the exact same thing
It is also available in the UI

There exist APIs updateIsoPermissions and updateTemplatePermissions which do pretty much the exact same thing It is also available in the UI

Oh ok, that is new for me. Thanks for the hint. I'll  close the PR.


Obsoletion notice: DNA  repair, DNA incision

Dear all,
The proposal has been made to obsolete the following terms:

GO:0033683 nucleotide-excision repair, DNA incision
GO:0006295 nucleotide-excision repair, DNA incision, 3'-to lesion
GO:0006296 nucleotide-excision repair, DNA incision, 5'-to lesion
GO:1990731 UV-damage excision repair, DNA incision

The reason for obsoletion is that these terms are MFs represented as BPs (definitions start of "A process that results in the endonucleolytic cleavage of the damaged strand of DNA ", and go on to describe the type of lesion/pathway).
There are 35 annotations to these terms. These terms don't have any mappings; and they are not present in any subsets.
Annotations are here: https://github.com/geneontology/go-annotation/issues/4059

Contributor   (Assigned by)
Annotations

CACAO
1

ComplexPortal
2

EcoCyc
1

FlyBase
2

MGI
2

PomBase
1

SGD
6

TAIR
1

UniProt
18

Annotations can be moved to a parent ~(GO:0033683  nucleotide-excision repair, DNA incision)~ GO:0006289 nucleotide-excision repair or GO:0070914 UV-damage excision repair.
You can comment on the ticket here: https://github.com/geneontology/go-ontology/issues/22883
We would like to proceed with the obsoletion on March 4th, 2022. If you We are opening a comment period for this proposed obsoletion. We’d like to proceed and obsolete this term on March 4th, 2022. Unless objections are received by March 4th, 2022, we will assume that you agree to this change.
Thanks, Pascale

uniprot done


Add hints to three front-end-libraries certification projects

Add hints to the front-end-libraries - build a markdown-previewer project

Add hints to the front-end-libraries - build a drum machine

Add hints to the front-end-libraries - build a pomodoro clock

[x] I have read freeCodeCamp's contribution guidelines.

[x] My pull request has a descriptive title (not a vague title like Update index.md)

[x] My pull request targets the master branch of freeCodeCamp.

[x] None of my changes are plagiarized from another source without proper attribution.

[x] My article does not contain shortened URLs or affiliate links.

Should I remove the example code or it would be fine to say that the following code could look like this using vanilla JS?

I think example code should be avoided.  They can always look at the example project for code ideas.


ttsSpeak does not allow to specify (or query) a language

From @GoogleCodeExporter on May 31, 2015 11:28
HTC Desire

2.2 Froyo

I can find no way to make the phone speak in a given language (the language in
which a text is written) or even to know which language is the computer set, so
that I can provide localized sentences to be spoken in the language that is set
up...

as an example, the say_time.py demo in my system reads "September treinta"
instead of either "treinta de septiembre" or "September thirty", depending if
the ttsSpeak would take English or the template for the date was adapted to the
preferred language...

While solving the time problem is more complex, one starting point is to know
(and be able to specify) which language is going to be used by ttsSpeak.

The same applies to the say_weather.py example, where the hl= parameter is
fixed to English and cannot be queried from the phone preferences...

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 30 Sep 2010 at 3:01
Copied from original issue: damonkohler/android-scripting#450

From @GoogleCodeExporter on May 31, 2015 11:28
Hello,

I think this is not an enhancement proposal, this is a bug report.

TTS provides an option: "Always use my settings - Default settings below
override application settings", but it has no effect on SL4A.

It would be nice if this bug was corrected, even without any change in the API.
It would be OK if there were no way to configure languages, but if the default
language set in TTS settings would be used.

Please consider that this is a serious bug for non-native english speaker. I am
currently building a robot and I wish it could speak french, but this is not
possible so far with SL4A.

Thanks,

Original comment by<EMAIL_ADDRESS>on 26 Sep 2011 at 8:15

From @GoogleCodeExporter on May 31, 2015 11:28
Original comment by<EMAIL_ADDRESS>on 6 Nov 2010 at 9:44

Added labels: Type-Enhancement

From @GoogleCodeExporter on May 31, 2015 11:28
Hello again,

I was actually wrong in my previous comment. I was in a confusing situation
where I had eye-free installed on a 1.6 which already natively support TTS.

Still, there is one remaining major problem: there is no way to specify
language (only default language is used) and no way to know which language will
actually be used.

Regards,

Original comment by<EMAIL_ADDRESS>on 27 Sep 2011 at 9:45


need export package.json

when I use this on svelte, i get this warning.
[rollup-plugin-svelte] The following packages did not export their package.json file so we could not check the "svelte" field. If you had difficulties importing svelte components from a package, then please contact the author and ask them to export the package.json file.

get-intrinsic

I think is can be fixed as simple as this
https://github.com/niieani/hashids.js/pull/330

Indeed, you're right. Thanks, will be fixed shortly.

v1.1.1 is published.

thanks a lot. I will update it on my project 👍


[MX-428] - Update fonts, spacing on show page #trivial

The type of this PR is: Upkeep
This PR resolves: MX-428
Description
Follow-up on feedback from https://artsyproduct.atlassian.net/browse/MX-428
Removes spacing in "More Shows" section and also changes hours section to use sans-serif font.
@samchieng
Screenshots

Perfect – ship it!


"Claim" sub-heading in the CLAIM section of the distribution contract could be labeled "fee" for better clarity.

Basically if you go to the Distribution Contract here. https://etherscan.io/address/0x47176B2Af9885dC6C4575d4eFd63895f7Aaa4790#writeProxyContract
The go to "Write as Proxy" the third section is for claiming MOR tokens. It then says the "payableAmount (Ether)" but as far as I know this section is actually for the fee you want to pay to claim. No matter what you enter, the contract claims the entire amount of MOR.
It is not impossible that somebody who doesn't read documentation well might stick a really high amount that they want to claim and then end up paying a really high gas fee they weren't expecting.

Thanks for the note here. I'll ping some of the Smart Contract open source devs on this.


Re-implement watching changes to the operator configmap

Signed-off-by: Josh Pinkney<EMAIL_ADDRESS>What does this PR do?
This PR makes it so that the configmap changes will be picked up while the operator is running
What issues does this PR fix or reference?
https://issues.redhat.com/browse/WTO-111
Is it tested? How?

PR Checklist

[ ] E2E tests pass (when PR is ready, comment /test v7-devworkspaces-operator-e2e, v7-devworkspace-happy-path to trigger)

[ ] v7-devworkspaces-operator-e2e: DevWorkspace e2e test
[ ] v7-devworkspace-happy-path: DevWorkspace e2e test

/test v7-devworkspaces-operator-e2e, v7-devworkspace-happy-path


Trough loop configuration does not update on SCA/HCE input pages

Describe the bug
For the Physical Trough model, the loop configuration representation on the Collectors (SCAs) page does not update to match the "Single Loop Configuration" on the Solar Field page:

Note that the representation on the Receivers (HCEs) page does update correctly:

Reported on SAM forum: https://sam.nrel.gov/forum/forum-general/4526
To Reproduce
Steps to reproduce the behavior:

Create a Physical Trough / Single Owner case.
On the Solar Field page, edit the Single Loop Configuration diagram so that there are at least two SCA types.
Note the representation on the Collectors (SCAs) page.

Operating System and Version
SAM 2023.12.17 for Windows

@taylorbrown75 can you please investigate?


Create dataset loader for IndoNLU WReTe

https://indonlp.github.io/nusa-catalogue/card.html?wrete

#self-assign

Hi @IkhlasulHanif, are you still working on this? I will assume inactivity if there's no reply and will free the assignees. Thanks!

Hi, sorry for the late pulls, currently done and pulling request right now.

No worries @IkhlasulHanif. Just checking. Thank you for contributing and for joining us!


Testbench required for sub_bytes.sv

Description
Add a testbench for sub_bytes.sv to validate it's functionality. Please refer to this for a tutorial on writing a testbench.
Notes:

You are eligible to get brownie points if you report back bugs with the module, add coverage reports, randomized testing and self-assertion tests.

can i get assigned this issue?

can i get assigned if this is still open?


Updated dependencies

Bumped to 0.8.0

@andelf Can you publish the new version on crates.io?

@bvssvni  :) done

@andelf Thanks!


call controller method without being static

Hello,
I was wondering if there is a neath way of calling controllers methods without being static ? (something like Laravel does for example: Route::get('user/{id}', 'UserController@show');
or Symfony:
$collection->add('blog_list', new Route('/blog', array(
'_controller' => 'AppBundle:Blog:list',
)));
How would this look like in Slim?
Thanks Roy

Yes, there is a way, see here

I totally missed that
On Mon, Jan 9, 2017 at 1:15 PM, Matheus Marques<EMAIL_ADDRESS>wrote:

Yes, there is a way, see here
https://www.slimframework.com/docs/objects/router.html#container-resolution
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/slimphp/Slim/issues/2123#issuecomment-271270611, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABPP1dpPDNXONXQdT28Nmx-X9b7pEQrJks5rQiTPgaJpZM4LeGyL
.

--
[image: --]
Roy de Kleijn
[image: http://]about.me/roydekleijn
http://about.me/roydekleijn?promo=email_sig

Closing as resolved!


Fix error NgNvd3 is not a NgModule

FIX #86
index.metadata.json was missing along side index.js
As explained in #86, we had to import module like that :
import { NvD3Module } from 'ng2-nvd3/lib';
But doing so, your module and your component become a part of user code base. Due to my linters/typescript configuration, I have a lot of warnings/errors.
This PR should fix this, I am able to import like this :
import { NvD3Module } from 'ng2-nvd3';

Can this be merged and a new release created? I'm using this library in a book I'm writing and I'd rather not include the hack from https://github.com/krispo/ng2-nvd3/issues/86.

Thanks a lot!

is pan and zoom option available for multi and discrete Bar Charts


Allow HTTP trailer for empty payloads

Purpose

$subject
Add test case

Fixes #21230
Remarks

Related PR https://github.com/wso2/transport-http/pull/404

Check List

[ ] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #21280 into ballerina-1.1.x will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           ballerina-1.1.x   #21280   +/-   ##
================================================
  Coverage            15.21%   15.21%
================================================
  Files                   50       50
  Lines                 1341     1341
  Branches               208      208
================================================
  Hits                   204      204
  Misses                1121     1121
  Partials                16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6db3333...2346324. Read the comment docs.


Python Notebook node nonfunctional

Using a workflow with a 'Read DataFrame' node (which runs successfully) connected directly to a 'Python Notebook' node, the Python Notebook is completely nonfunctional under the Pyspark kernel. The notebook is accessible, but the Pyspark kernel looks like it is constantly busy, and attempting to run a code cell does nothing. Restarting the kernel also fails.
Please see the included log snippets. The jupyter log came from inside the running notebooks container. The console log and the headless jupyter snippet were written to the startup console.
I am running on a Mac
console.log
jupyter_headless.log
jupyter.log

@jaroslaw-osmanski Any direction on how we might further debug/address this is really appreciated. This is a major blocker for us right now, and we're out of ideas on how to isolate the problem.

https://github.com/deepsense-ai/seahorse/pull/51 should solve it.
Quick fix: downgrade tornado to 4.1 on sessionmanager container.

@jaroslaw-osmanski We'll test it today or Monday. Been at a conference.

@jaroslaw-osmanski I can confirm that this is now working after a fresh build. Thanks so much for addressing this!


docs: Follow man-pages(7) suggestions for SYNOPSIS

[man-pages(7)][1] has:

For commands, this shows the syntax of the command and its arguments (including options); boldface is used for as-is text and italics are used to indicate replaceable arguments. Brackets ([]) surround optional arguments, vertical bars (|) separate choices, and ellipses (...) can be repeated.

I've adjusted our SYNOPSIS entries to match that formatting, and generally tried to make them more consistent with the precedent set by the man-pages project.  Outside of the SYNOPSIS entry, I prefer using backticks for literals, although in some places I've left the bolding to keep things visually similar to a nearby SYNOPSIS entry.
I've also simplified a few placeholders, e.g. "containerID" -> "container", because I didn't think the additional bit was providing much additional context.  If there is ambiguity about the representation, it should be addressed in the DESCRIPTION instead of with an "ID" or "Name" suffix.
I've also proposed very similar changes for libpod in projectatomic/libpod#1027.

bot, add author to whitelist

The changes in general LGTM, but I'd rather containerID and imageID insted of container and image.  What to others think?

I'd rather containerID and imageID insted of container and image.

Some of the previous examples were using imageName, not imageID.  But are there other ways to identifiy containers and images (e.g. container names or image hashes)?  If so, do the commands that used to have containerID, etc. only support the ID form?

@wking buildah command should support either the id or the name unless there's a bug running around.    I've preferred documenting only the ID in the synopsis as it's cleaner to document.  Also we've never had issues looking up by id and over the course of development the name hasn't always been hip.  That's my $.02 anywho.

buildah command should support either the id or the name unless there's a bug running around.

In that case, I'd prefer the more general container to the overly-specific containerID.

Also we've never had issues looking up by id and over the course of development the name hasn't always been hip.

It may be too early in the buildah process to be documenting bugs in man pages instead of fixing them.  But if a command is intended to support both container names and IDs, but names may be buggy, that seems like fodder for a BUGS section, not a reason to leave the name support undocumented.

My personal problem with leaving it as "container" is when you look at the output of "buildah containers" which column in a container?  "containerID" is very evident and quick to find.  As  a bonus, it's concise and has always worked.  Similar thinking with images.  My $.02.

"containerID" is very evident and quick to find.

But the CONTAINER NAME column would work too, right?  There doesn't seem to be a column whose name contains "container" that would not work.
To add another option to the container vs. containerID debate, buildah add --help will show CONTAINER-NAME-OR-ID.  Using CAPS there makes sense without the man page's italics availabe, but whatever we settle on here should probably be otherwise consistent.  In order to keep this PR managable, I suggest we punt --help consistency to follow-up-work, but we should consider the list-all-the-possibilities approach for the man pages.
My preferences are (in decreasing order):

container (short & generic)
containerNameOrID (generic)
containerID (too specific, except where names aren't acceptable)

Ok I am going to merge this since the cleanup looks good, and you guys can continue the debate of what to call this in a different PR>

@rh-atomic-bot r+


Fix an error for unrecognized cop or department RSpecRails/HttpStatus when also using rubocop-rails

Fix: https://github.com/rubocop/rubocop-rspec_rails/issues/8

Before submitting the PR make sure the following are checked:

[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[ ] Added tests.
[ ] Updated documentation.
[x] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
[x] The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

If you have created a new cop:

[ ] Added the new cop to config/default.yml.
[ ] The cop is configured as Enabled: pending in config/default.yml.
[ ] The cop is configured as Enabled: true in .rubocop.yml.
[ ] The cop documents examples of good and bad code.
[ ] The tests assert both that bad code is reported and that good code is not reported.
[ ] Set VersionAdded: "<<next>>" in default/config.yml.

If you have modified an existing cop's configuration options:

[ ] Set VersionChanged: "<<next>>" in config/default.yml.

Added workaround. This is probably caused by the fact that rubocop-rails also has a cop name named Rails/HttpStatus. How about this? @rubocop/rubocop-rspec

I updated this PR.

This is another temporary fix, right? We should consider keeping a written TODO list of things to revert in the future.

@bquorning Yes. Indeed it is. Then I will list it in Issues later.

It seems there is an issue with the workaround monkey patch. For more details, please see https://github.com/rubocop/rubocop/pull/12836.


[PROPOSAL] Adopt style guide / lint tools code

What/Why
What are you proposing?
I was trying to add some TypeScript code and started typing camelCase methods. Then I noticed that we have adopted of a Ruby-formatting/style in tools such as https://github.com/opensearch-project/opensearch-api-specification/blob/main/tools/merger/OpenApiMerger.ts with snake_case methods and ClassNames. This was probably intended. I propose we codify this, adopt a specific/default TypeScript style guide, and add a linter for it.
What users have asked for this feature?
Future contributors.
What problems are you trying to solve?
Introduce some rules before someone like myself contributes code that looks different.
What is the developer experience going to be?
CI will fail if contribution doesn't fit the style guide and linter doesn't pass.

I'm bias for spending years writing Ruby code, but I find snake_case for method names a lot more readable, especially on longer names. Even though the tools are written in TypeScript, where CamelCase is the convention, I'd still vote for snake_case.


Fix remaining failing perf IT tests.

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run Java AvroIO Performance Test HDFS

R: @lukecwik

I believe this will address some failures with other runners but still seeing "java.lang.IllegalArgumentException: Class interface org.apache.beam.sdk.testing.TestPipelineOptions missing a property named 'hdfsConfiguration'." when looking at https://ci-beam.apache.org/job/beam_PerformanceTests_ManyFiles_TextIOIT_HDFS/4361/

Run Java PreCommit


Research ERC-1155 support

ERC-1155 provides a more flexible interface to tokens. This may be useful for Scarce Editions

ERC 721 & ERC 1155
EIP-3386: ERC-721 and ERC-1155 to ERC-20 Wrapper
ERC-721 and Other NFT Standards
Open Zeppelin's ERC1155 overview

Moved to Trello


Leakcanary detects memory leak when using the library

I integrated this app in my library and Leakcanary detects a memory leak of linear layout if the app is minimized when welcome screens are open and then resumed back again. It seems the issue is the line:
welcomeScreen = new WelcomeHelper(this, MyWelcomeActivity.class);

We are passing an instance of this to welcome activity but when the base activity lifecycle actions happen, WelcomeHelper still holds the instance to the base activity leading to GC not able to run on it and thus a memory leak.
Please help @stephentuso

Sad.


orgs: Fixup ListPendingOrgInvitations.

The API doesn't take an organization ID, but rather the name.
This is obviously a breaking change to the API -- and I'm unsure how to handle that,
given that it doesn't function as is, compare:
curl -vvv -H "Authorization: token $GITHUB_TOKEN" https://api.github.com/orgs/<id>/invitations
curl -vvv -H "Authorization: token $GITHUB_TOKEN" https://api.github.com/orgs/<name>/invitations

THanks for the PR. This looks like it fixes issue #730, is that right? We already have a PR open for it, see #731, it’s waiting on review.
Your change is nearly identical, which serves as positive validation.

@shurcooL  Indeed!
Apologies for not checking open Issues/PRs -- I'll hang back until #731 lands in master.


Two-factor authentication

Config is defined per-panel, and the implementation is driver based with two default drivers: Google 2FA-compatible apps, and "email code" 2FA

Hi @danharrin. I just realised that requiring 2FA prior to authentication won't work with several third party auth packages (eg. https://github.com/grosv/laravel-passwordless-login). Magic links packages need to log the user in first, so 2FA needs to be checked / enforced via middleware.
I had a quick look at the MFA classes and they seem flexible enough to be used that way, but I just wanted to confirm in case I missed something.

I wouldn't want to change the system to support 2FA after authentication because there is a ton of additional complexity and potential for security issues, so as long as I don't need to do anything that's fine.
Personally if you wanted the experience of these packages, I would suggest you implement a simple custom version that utilises signed URLs to log the user in from their email.

@danharrin Sorry let me clarify. I'm not suggesting the current implementation should change. From what I could tell, all the logic related to verifying 2FA before authentication is in the Login page itself. And the classes in src/MultiFactorAuthentication are completely decoupled from that. Have I got that right? Because if that's the case, devs can build whatever implementation they want using those classes and methods.
Yeah I used to use signed URLs but laravel-magiclink has some nice features like one-time downloads and one-time views. Wouldn't be too hard to build that I guess but the package works really well.

Regardless of whether you're using signed URLs or a package for magic links, you still need be able to use 2FA. Otherwise you're only relying on one factor (email access). AFAIK the only way to do that is by doing the 2FA verification post-auth.


feature request: support for github tags with version numbers (major.normal.minor)

Ionic is a very advanced tool. Thank you. However, I want to ask yet another feature or your opinion about it.
Many of us who use github for their ionic apps need to maintain versions. In cordova version is kept in config.xml and when compiled to android the same version is used in manifest (unfortunately web apps do not have versions as there is no access to cordova functionality). However, many times a smarter way for version control is needed. For example, if we keep our projects in github we would like to have tags associated with versions. And we need to track independent systems for versions (and also compilation of android app could benefit from compiling to app-name-version.apk
I have first attempt to make versioning a more automatic way:
1 I have created a config.placeholder.xml of the form:
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<widget id="something.here" version="VERSION_TAG_PLACEHOLDER" ...

2 Created version file with text: "2.3.10" and
3 Updated gulp file:
var gulp = require('gulp'),
  [.....]
  rename = require('gulp-regex-rename'),
  replace = require('gulp-replace'),
  path = require('path'),
  debug = require('gulp-debug'),
  argv = process.argv;

[....]

gulp.task('version-placeholder', function () {
  var version = fs.readFileSync("./version", "utf8");

  gulp.src(['./*.placeholder.*'])
    .pipe(replace("VERSION_TAG_PLACEHOLDER",version))
    .pipe(rename(/\.placeholder/, ''))
    .pipe(gulp.dest('.'));
});

However this is first step with three major drawbacks:

config.xml is a generated file instead of being source of configuration. If I write "cordova install ...." then config.xml will be autoupdated with no effect to config.placeholder.xml
version is taken from file, but what I really want is supprt for github tags and more specifically releases (which are in a sence generalization of tags).
E.g. use command git tag --sort=v:refname | tail -1 or even better: libraries that support github releases: https://github.com/Aluxian/gulp-github-release
There is yet no command support from ionic cli... I want to be able to do ionic increase [major,normal,minor]

What do you think about such a feature?

Actually, I have checked that everything is already in ionic2: https://github.com/driftyco/ionic/blob/v2.0.0-beta.11/gulpfile.js
Sections semver + github.releases + packageJson could be reused.

OK, I have made something for own usage, if somebody needs it:
var gulp = require('gulp'),
  gulpWatch = require('gulp-watch'),
  del = require('del'),
  runSequence = require('run-sequence'),
  fs = require("fs"),
  rename = require('gulp-regex-rename'),
  replace = require('gulp-replace'),
  path = require('path'),
  debug = require('gulp-debug'),
  argv = process.argv,
  through2 = require('through2');
  bump = require('gulp-cordova-bump'),
  prompt = require('gulp-prompt');

/**
 * Ionic hooks
 * Add ':before' or ':after' to any Ionic project command name to run the specified
 * tasks before or after the command.
 */
gulp.task('serve:before', ['watch']);
gulp.task('emulate:before', ['build']);
gulp.task('deploy:before', ['build']);
gulp.task('build:before', ['build']);
gulp.task('build:after', ['copyDebugApk']);

gulp.task('copyDebugApk', function() {
  var packageJSON = require('./package.json');

  return gulp
    .src('./platforms/android/build/outputs/apk/android-debug.apk')
    .pipe(rename(/android-debug\.apk/, 'my_app_v' + packageJSON.version + '.apk'))
    .pipe(gulp.dest('./build-output'));
});

// we want to 'watch' when livereloading
var shouldWatch = argv.indexOf('-l') > -1 || argv.indexOf('--livereload') > -1;
gulp.task('run:before', [shouldWatch ? 'watch' : 'build']);

/**
 * Ionic Gulp tasks, for more information on each see
 * https://github.com/driftyco/ionic-gulp-tasks
 *
 * Using these will allow you to stay up to date if the default Ionic 2 build
 * changes, but you are of course welcome (and encouraged) to customize your
 * build however you see fit.
 */
var buildBrowserify = require('ionic-gulp-browserify-typescript');
var buildSass = require('ionic-gulp-sass-build');
var copyHTML = require('ionic-gulp-html-copy');
var copyFonts = require('ionic-gulp-fonts-copy');
var copyScripts = require('ionic-gulp-scripts-copy');

var isRelease = argv.indexOf('--release') > -1;

gulp.task('watch', ['clean'], function (done) {
  runSequence(
    ['sass', 'html', 'fonts', 'scripts'],
    function () {
      gulpWatch('app/**/*.scss', function () { gulp.start('sass'); });
      gulpWatch('app/**/*.html', function () { gulp.start('html'); });
      buildBrowserify({ watch: true }).on('end', done);
    }
  );
});

gulp.task('build', ['clean'], function (done) {
  runSequence(
    ['sass', 'html', 'fonts', 'scripts'],
    function () {
      buildBrowserify({
        minify: isRelease,
        browserifyOptions: {
          debug: !isRelease
        },
        uglifyOptions: {
          mangle: false
        }
      }).on('end', done);
    }
  );
});

gulp.task('sass', [], buildSass);
gulp.task('html', [], copyHTML);
gulp.task('fonts', [], copyFonts);
gulp.task('scripts', [], copyScripts);
gulp.task('clean', function () {
  return del('www/build');
});

gulp.task('bump', bump);

gulp.task('test', function() {
  return console.log(process.env.GH_TOKEN);
});

gulp.task('publish.github', function () {
  var GithubApi = require('github')
  var packageJSON = require('./package.json');

  var github = new GithubApi({
    version: '3.0.0'
  });

  github.authenticate({
    type: 'oauth',
    token: process.env.GH_TOKEN
  });

  console.log("***************************************************");
  console.log("Starting to make github release v" + packageJSON.version);
  console.log("***************************************************");

  return gulp.src('package.json')
    .pipe(prompt.prompt({
      type: 'input',
      name: 'msg',
      message: 'Enter massage for the release (' + packageJSON.version + ')?'
    }, function (reply) {
      console.log("***************************************************");
      console.log(reply.msg);
      console.log("***************************************************");
      github.repos.createRelease({
        user: 'MyUser',
        repo: 'MyRepo',
        target_commitish: 'master',
        tag_name: 'v' + packageJSON.version,
        name: packageJSON.version,
        draft: false,
        body: reply.msg
      });
    }));
});

gulp.task('release', ['publish.github']);

The script could benefit from auto apk signing feature (right now I have only debug copy, but work in progress).

I think this is a good option.  A feature like this is something we would like to keep in userland. Thanks for supplying this code for others to use!


Improve header format

Reduce the number of version bits from three to two. For function IDs 63 or greater, append the RLP encoding of the function ID minus 63. This allows function IDs less than 191 (128 + 63) to be encoded in a header of two bytes or fewer.

addressed by https://github.com/esaulpaugh/abiv3/commit/78924dd2e03e0cfe2f73c2f3d0075b276cd8dbad


Contribution of ol3 Torque Layer's implementation to CartoDb

Contribution of Torque Layer's implementation for OpenLayers version 3.17 and above to CartoDb by Bloomberg.

@ashchurova Hi Anna! I'm not from torque team but I've just checked your implementation of torque layer for OpenLayers and I have few questions/points.

You've changed the lib sources and added example/navy_ol.html but you didn't regenerate build files in dist folder, as a result your example is not working right after checkout.

I've built library with your changes and checked that example/navy_ol.html example is working, but unfortunately some of original torque examples are not working anymore. For instance: examples/car.html, examples/data_peek.html and so on. If I missed something, please explain how to bring them back.

Best regards,
Vasyl.

@vasyl-ivanchuk Hi Vasyl, I originally did include build files in the dist folder but was asked by @javisantana to remove them as they are built automatically.. I will try to run the original samples and see why they are not working. My changes shouldn't effected them. I was able to run my torque example with leaflet but it was mine, that was how I was testing my changes.

@ashchurova thanks for such quick response and explanation about the build files. Waiting for the outcome regarding the original samples. Thank you in advance!

@vasyl-ivanchuk it looks like at some point you guys started using d3.js. All original samples are breaking in d3.js. The exception I get is "Invalid or unexpected token" on line 16686 in torque.full.uncompressed. js and the line has the following script:
var Îµ = 1e-6, Îµ2 = Îµ * Îµ, Ï€ = Math.PI, Ï„ = 2 * Ï€, Ï„Îµ = Ï„ - Îµ, halfÏ€ = Ï€ / 2, d3_radians = Ï€ / 180, d3_degrees = 180 / Ï€;
Which would make sense why it is complaining.

@vasyl-ivanchuk I downloaded the latest release of d3.js and the line that causes this issue looks like this:
var ε = 1e-6, ε2 = ε * ε, π = Math.PI, τ = 2 * π, τε = τ - ε, halfπ = π / 2, d3_radians = π / 180, d3_degrees = 180 / π;

@ashchurova yep, it seems that upgrading d3 to the latest version solves the problem. I think we should address this issue as a separate one to someone from development team, because as you've mentioned it is not related to your customization.

@vasyl-ivanchuk sorry, I had missed your comment that you are not on CartoDb development team :).. I have found one issue with my implementation and it is when layer is removed. I will fix it and probably resubmit this pull request...

@vasyl-ivanchuk do you use make file to built it? I have found only this way to build torque.

@ashchurova great news about the improvement you've mentioned! Yes, I use make file to build torque.


reactNativeRouterFlux.Actions.xxx is not a function

Version
Tell us which versions you are using:

react-native-router-flux v3.38.0
react-native v0.43.3

Using Actions with firebase onAuthChanged()
I keep getting the error that

Actions.main() is not a function

however If I call the Actions.main() after a separate  promise function has resolved the Actions workes fine.
export function onAuthChange(user) {
  return (dispatch) => {
    if (!user) {
      dispatch(notAuthed())
    } else {
      Actions.main() // **ERROR IF CALLED HERE**
      // update user in firebase database
      const { uid, displayName, photoURL } = user
      updateUser({
        uid,
        displayName,
        photoURL,
      }).then(() => {
        dispatch(isAuthed(uid))
        // Route change using react-native-router-flux
        Actions.main() // **WORKS FINE HERE**
      })
    }
  }
}

But the issue of calling it after promise resolves is that for a Short time the my intial Scene of Login comes on before the EmployeeList Scene comes into View.
My Route:
<Router>
  <Scene key='login' component={AuthContainer} title='Please Login' />
  <Scene key='LibraryList' component={LibraryListViewContainer} title='Libraries' />
</Router>

+Same here

Encountering something similar.  Is this nested promise solution the best solution you found?  Did you isolate why this was happening?