How to use it on webpack

$(function() {
    let container = $('#container');
    let data = {name: 'chan'};
    let tmpl = $.templates('
{{:name}}
');
    let html = tmpl.render(data);

    container.append(html);
});

The is my code without webpack, it works, when I use webpack I load jsrender moudle like:
let jsrender = require('jsrender');
require("imports?this=>window!jsrender");

$(function() {
    let container = $('#container');
    let data = {name: 'chan'};
    let tmpl = $.templates('
{{:name}}
');
    let html = tmpl.render(data);

    container.append(html);
});

and I got bundle.js:55 Uncaught TypeError: $.templates is not a function, how to make it work?
<EMAIL_ADDRESS><EMAIL_ADDRESS>

You don't need to do require("imports?this=>window!jsrender"); since you have already got the line let jsrender = require('jsrender');. The import loader is an alternative way of doing the same thing...
If jQuery is loaded globally (as a script file) then this will work:
require('jsrender');
$(function() {
    let container = $('#container');
    let data = {name: 'chan'};
    let tmpl = $.templates('
{{:name}}
');
    let html = tmpl.render(data);

    container.append(html);
});

because require('jsrender'); will load JsRender and attach it to the global $ (window.jQuery) as a plugin.
But if you are loading jQuery as a module, with webpack, then window.jQuery is not defined. You need to pass your local copy of jQuery to JsRender, by writing require('jsrender')($);. So you can do it like this:
let $ = require('jquery');
let jsrender = require('jsrender')($);
$(function() {
    let container = $('#container');
    let data = {name: 'chan'};
    let tmpl = $.templates('
{{:name}}
');
    let html = tmpl.render(data);

    container.append(html);
});

See the Browserify documentation: http://www.jsviews.com/#node/browserify@clientscript

I tried require('jsrender'); alone too, still not work, and I load jQuery by webpack.config.js like:
var webpack = require('webpack');

module.exports = {
    entry: './entry.js',
    output: {
        path: __dirname + '/assets/js/build',
        filename: 'bundle.js'
    },
    plugins: [
        new webpack.ProvidePlugin({
            $: "jquery",
            jQuery: "jquery"
        }),
        new webpack.optimize.UglifyJsPlugin({
            compress: {
                warnings: false
            }
        })
    ],
    module: {
        loaders: [
            {test: /\.js$/, exclude: /node_modules/, loader: "babel", query: {presets: ['es2015']}}
        ],
    },
};

therefore the jQuery is auto loaded everytime, but still get the error message

But did you pass $ as a parameter?
You need to get a reference to $ and pass it as a parameter.
require('jsrender')($);

If you use the correct syntax shown above, with the $ passed as parameter, this will work correctly. Closing this issue for now.
Also, there will be additional documentation on using webpack, in the next update.

There is now a topic on webpack: http://www.jsviews.com/#node/webpack

@BorisMoore How can i require(from webpack) imagens on html views?
I try put in the jsrender.views.helpers, but, without success yet.

I don't know how to do that. One way might be to write a  special loader: 'jsrender-loader'.
Another might be to add a build step which writes the rendered template to file (as an html file) then use the html-loader to load that file - at which point the html-loader will be able to do its usual magic of 'requiring' the images, using the usual regex test for .png, .jpg etc. and using whatever loaders or rules you have set up for those paths...
I have not used webpack enough to help much more at this point. But if you do make progress on solving the scenario, I would be very interested to hear, and I could potentially then provide more documentation on jsviews.com based on the results... Let me know...

Should it be possible to use jsrender in webpack without jQuery?
I currently load jsrender from my public js files like so:

And then call the methods in my webpack modules from the window:
window.jsrender.templates(xhr.responseText).render()
This works well.
What I would like to do is to require jsrender from the node_modules which I use in the backend.
const jsr = require('jsrender');
jsr.templates(xhr.responseText).render()

I also tried to just require the jsrender-src from my public directory in the hope that this would bind jsrender to the window object, but this did not work.
require('./jsrender-src');

I fussed it out...
const jsr = require('jsrender')();
Without the empty brackets the module did not execute with Webpack3.

Compared with:

And thereafter I am good to use
document.querySelector('.myTmplContainer').innerHTML = jsr.templates(myTmpl).render();
It might be worth ammending the documentation as this example did not work with Webpack3.

If using JsRender without jQuery, or with jQuery loaded globally (as a script tag) this is done by calling:
var $ = require('jsrender'); // Without jQuery, or if jQuery is loaded globally

I just returned from 3 weeks travelling. Sorry not to be able to  reply until now.
Yes, you are correct. It is actually a documentation error, which I will fix soon. In fact to use webpack to load JsRender without jQuery, you do indeed need to use the syntax:
var jsr = require('jsrender')();
var myTmpl = jsr.templates(...);
var html = myTmpl.render(myData);
...
Thanks for investigating!

Documentation has been updated in commit 89.


Default values of custom type mappings are potentially problematic

Some WinRT types are projected onto built-in types in other languages, such as Windows.Foundation.DateTime is projected to System.DateTimeOffset in C#. However, one issue with this is that the default values of the types are different. This is quite unintuitive and can lead to bugs. For example, I have a FileTimeStamp property in my C++/WinRT component which is a Windows.Foundation.DateTime. I am happy with the default value of the year 1601 for this as it's earlier than any file I will be using, so I initialize it to its default value. I then use the component in my C# app. At some point I want to reset the FileTimeStamp  to its default value. So I do FileTimeStamp   = new DateTimeOffset or FileTimeStamp = default(DateTimeOffset), thinking that I've reset it to the default, but in fact I've reset it to 1AD or something, so then this FileTimeStamp is earlier than it should be, which causes issues.
If no better solution is found, I'd like to propose adding a static default property Windows.Foundation.DateTime.Default or something. This should not involve a call through the ABI boundary and the value should be available at compile time, so it would be no more expensive than new DateTimeOffset(). It should also be documented in the Windows.Foundation.DateTime documentation that you may run into difficulties if relying on default values.
I don't know if this issue arises for any other types. If it does, the same sort of suggestion should be considered.

Yes, that's an impedance for mapped value types.  I like your suggestion, which is probably about the best we can do.  The projection simply doesn't know, in general, when a value type presented to it was constructed by default.  There could be some value types that have unique enough default values that we could safely assume they were default created.  But ideally, we'd have a consistent approach for all types - principle of least surprise.

Each projection (C#/C++) will need to call out differences in WinRT types defaults.

@angelazhangmsft - confirm if we are compatible with NetNative/Netcore3. If so, close

The suggestion above has the drawback of being biased toward C++/WinRT.  That is, the zero-initialized state of a projected C++/WinRT value type determines the default value of the corresponding WinRT type.  Instead of picking a winner, a C# source analyzer could be used to flag default-initialized projected C# value types.

The initialized DateTimeOffset value is consistent across NetCore3, Net5, and UWP/NetNative. {1/1/0001 12:00:00 AM +00:00}

@angelazhangmsft and @AdamBraden - this issue wasn't really about differences between C#/WinRT and .Net Native. It was about differences between the .Net projections and other language projections like C++/WinRT. (So it applies to .Net Native as well but I thought C#/WinRT could improve matters).
@Scottj1s - Perhaps it's best to start by considering the specific case of Windows.Foundation.DateTime - this was mainly what I was thinking about when I posted the issue, then I generalized it but that might have been premature.
In this case a source analyzer won't be able to do anything since you are just initializing an ordinary System.DateTimeOffset. Also, in this case I guess there must be a canonical representation of the date time to pass through the ABI layer (an int64 of ticks since January 1, 1601, I assume). This is mostly explained in docs, although in a slightly confusing way. So in this case it seems that there is a canonical default. In addition to this, I have come across situations where Windows APIs will return this default value for a date in the case where the date is not actually set. (For example, the System.Photo.DateTaken metadata property). Therefore I need to check against this value in some situations. If I was working in C#, then to represent an unset date value I'd use a nullable, but nullables are much less convenient in C++, so it's tempting to use the default value. For these reasons I think it would be nice to expose the default value for DateTime somehow. Although I can see the argument that the default value isn't really designed to represent an 'unset' value.
For the more general case, perhaps you are right and we don't need to do anything. Almost always structs will be zero-initialized and agree on the default. However, I do agree with @AdamBraden  that in the Windows SDK documentation,
Each projection (C#/C++) will need to call out differences in WinRT types defaults. I'm not 100% sure how a source analyzer would work...
By the way, here are some other minor problems that I can see that might arise when using DateTime:

Round-tripping DateTimeOffset through a C++/WinRT component will presumably not preserve the offset.
If I wrote a component in C# and used it from C++/WinRT, then I could pass the component dates in the BC era but the component wouldn't be able to handle them.

@benstevens48 - the source analyzer would require more context than just seeing a default-initialized DateTimeOffset (e.g.).  It would have to observe it being passed to a projected interface, and then possibly alert to the risk of using language-specific default values.  Or see it returned from a projection and compared with a default-initialized value.
Yes, roundtripping is certainly a concern - again, it all goes back to not being able to distinguish between "unset" and a value that equals a language-specific default.

@benstevens48 - the source analyzer would require more context than just seeing a default-initialized DateTimeOffset (e.g.).  It would have to observe it being passed to a projected interface, and then possibly alert to the risk of using language-specific default values.  Or see it returned from a projection and compared with a default-initialized value.
Yes, roundtripping is certainly a concern - again, it all goes back to not being able to distinguish between "unset" and a value that equals a language-specific default.

I've done an analysis on the projected default value of Windows.Foundation.DateTime and System.DateTimeOffset. It looks like the previous behavior raises an exception for the round-tripping scenario, and the different initialized values are consistent in .NETCore3.1/NetNative.
Scenario 1 - what does C++ zero-initialized value look like in C#
Scenario 2 - what does C# zero-initialized value look like in C++
Scenario 3 - roundtrip from C++ back to C#
.NET Core 3.1
Scenario 1: UtcDateTime = {1/1/1601 12:00:00 AM}
Scenario 2: UtcDateTime = {1/1/0001 12:00:00 AM}
Scenario 3:
System.ArgumentException
HResult=0x80070057
Message=Specified argument was out of the range of valid values.
Source=System.Private.CoreLib
StackTrace:
at System.DateTime.ToLocalTime(Boolean throwOnOverflow)
at System.DateTimeOffset.ToLocalTime(Boolean throwOnOverflow)
at System.StubHelpers.DateTimeOffsetMarshaler.ConvertToManaged(DateTimeOffset& managedLocalDTO, DateTimeNative& nativeTicks)
at DefaultValues.Date.get_value()
at UWPCSApp.MainPage..ctor() in C:\Users\angzhang\source\repos\DefaultValues\UWPCSApp\MainPage.xaml.cs:line 35
This exception was originally thrown at this call stack:
[External Code]
UWPCSApp.MainPage.MainPage() in MainPage.xaml.cs
NetNative
Scenario 1: Ticks =<PHONE_NUMBER>00000000
Scenario 2: Ticks = 0
Scenario 3: Ticks = 0
.NET5
Scenario 1: UtcDateTime = {1/1/1601 12:00:00 AM}
Scenario 2: UtcDateTime = {1/1/0001 12:00:00 AM}
Scenario 3:
System.ArgumentOutOfRangeException
HResult=0x80131502
Message=Not a valid Win32 FileTime.
Source=System.Private.CoreLib
StackTrace:
at System.DateTime.ToFileTimeLeapSecondsAware(Int64 ticks)
at System.DateTime.ToFileTimeUtc()
at System.DateTimeOffset.ToFileTime()
at ABI.System.DateTimeOffset.CreateMarshaler(DateTimeOffset value)
at ABI.SimpleMathComponent.ISimpleMathStatics.global::SimpleMathComponent.ISimpleMathStatics.set_value(DateTimeOffset value) in C:\Users\angzhang\source\repos\SimpleMathDemo_build\x64\Debug\SimpleMathProjection\bin\SimpleMathComponent.cs:line 370
at SimpleMathComponent.SimpleMath.set_value(DateTimeOffset value) in C:\Users\angzhang\source\repos\SimpleMathDemo_build\x64\Debug\SimpleMathProjection\bin\SimpleMathComponent.cs:line 87
at ConsoleAppSample.Program.Main(String[] args) in C:\Users\angzhang\source\repos\SimpleMathDemo\ConsoleAppSample\Program.cs:line 13


[WIP] Unifying the entity saving functions in save_inventory_container.rb.

Try to unify save_selector_parts_inventory and
save_node_selector_parts_inventory in
app/models/ems_refresh/save_inventory_container.rb.

@dkorn @moolitayer please review. Thanks!
@miq-bot add_label providers/containers, refactoring

@dkorn @moolitayer it would have been great if we had tests for nodeSelector as well, sadly the vcr yaml doesn't have a pod with that.
Do we have a spec test elsewhere that may be relevant? Any suggestion for @yaacov to add testing for that?
Thanks.

@yaacov I think there should be a way to get unified_save_entity_inventory being called in all cases, so we can drop both save_selector_parts_inventory and save_node_selector_parts_inventory.

@simon3z the function save_child_inventory call "save_#{k}inventory" using the key, we do not have to write all possible "save#{k}_inventory"  functions ?

@simon3z the function save_child_inventory call "save_#{k}inventory" using the key, we do not have to write all possible "save#{k}_inventory" functions ?

So can't you just change :node_selector_parts to :selector_parts and keep only save_selector_parts_inventory? (Removing save_node_selector_parts_inventory)
IIRC there's a catch there (cc @dkorn), it can't be that easy.

@simon3z suggested removing  :node_selector_parts
this may code ambiguity between  :selector_parts of container_service and container_group, is it ok ?

save_node_selector_parts_inventory is romved.
but the name node_selector and node_selector_parts is used to represent ems.container_groups selector_parts in the event and haml files :-(

@yaacov please squash all the patches... the PR should have just 1 patch.

app/models/container_group.rb: change node_selector_parts to selector_parts. Rubocop had issues with the long line.
squashed :-)

I do not know the "real-world" meaning of node_selector vs. selector. The rspec passes, but do this changes have ok "real-world" meaning ?

Please note I'm working on a big overhaul in save_inventory_container in preparation for the disconnect feature.
This is a good effort regardless.
I will post a link once it is ready.

@moolitayer Thanks for the heads up :-)

@simon3z this PR is outdated by @moolitayer, do we need it ?

@yaacov @simon3z Just trying to debug an issue with the bot that seems to have come up with this PR. What caused the bot to add the gem changes label? Also the bot saw this PR referencing this BZ. Did something happen during the rebase that could have caused that?
Thanks

@carbonin Did something happen during the rebase that could have caused that?
During the rebase gems where added, had to run bundle install before running tests.
Sorry for the mess ? @simon3z  I think this PR is outdated, do we need to close it ?

@simon3z don't we need a migration script here? What about the current installations?
How did the tests pass ? did I build new tables in rake test:vmdb:setup ?

Closing PR because

I made it on my master branch, and now want to clean it :-)
@dkorn say node_selectors have different meaning then selectors
It is made redundant by @moolitayer work


Optional parameters not working.

3.8.0 broke optional parameters. For example, with a route defined as:
/:name?

name would be "undefined" (a string) instead of truly undefined.
Also, calling setParamsor setQueryParams without setting a parameter would result an invalid path of a similar reason. In the example above, calling:
FlowRouter.setQueryParams({});

Would result in the router redirecting to /undefined instead of /
I've made PR #494 and added some unit tests. The tests work on my machine but they fail with no useful information here on Github. Is that to be expected?

Fixed.

Can this be added to the doc please ?
It's only suggested here :
var localeGroup = FlowRouter.group({
  prefix: '/:locale?',
  triggersEnter: [localeCheck]
});


Display the absolute address for relative jumps on x86

yaxpeax doesn't have support for doing this natively so just shim it on top.

Excellent, thanks!


Fix TO tests for parameter change

What does this PR do?
Fix TO tests for parameter change
Which TC components are affected by this PR?

[ ] Documentation
[ ] Grove
[ ] Traffic Analytics
[ ] Traffic Monitor
[ ] Traffic Ops
[ ] Traffic Ops ORT
[ ] Traffic Portal
[ ] Traffic Router
[ ] Traffic Stats
[ ] Traffic Vault
[ ] Other _________

What is the best way to verify this PR?
go test
Check all that apply

[x] This PR includes tests
[ ] This PR includes documentation updates
[ ] This PR includes an update to CHANGELOG.md
[ ] This PR includes all required license headers
[x] This PR does NOT fix a serious security flaw. Read more: www.apache.org/security

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2310/
Test PASSed.


Release automation fixup

Remove -Dargument... flag, which was causing a maven error
Add back next dev version arg for release:prepare

I would try the -Darguments just with -ntp.

Ah, will do. Looks like I didn't use the double-quotes correctly here with multiple arguments, likely causing the error. I see an example, like in the accepted answer here, saying that the first double-quote needs to be at the very beginning of the arg. Since the -B should be strictly necessary here, i'll just omit it to avoid dealing with passing multiple parameters.


Stephan/merge order validator

Motivation

Solution

Codecov Report
Base: 100.00% // Head: 64.06% // Decreases project coverage by -35.94% :warning:

Coverage data is based on head (73967fa) compared to base (e99e1e3).
Patch coverage: 0.00% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@             Coverage Diff              @@
##              main     #967       +/-   ##
============================================
- Coverage   100.00%   64.06%   -35.94%
============================================
  Files           47       53        +6
  Lines         2661     2819      +158
  Branches       393      499      +106
============================================
- Hits          2661     1806      -855
- Misses           0      893      +893
- Partials         0      120      +120

Flag
Coverage Δ

foundry
64.06% <0.00%> (-13.75%)
:arrow_down:

production
?

reference
?

Flags with carried forward coverage won't be shown. Click here to find out more.

 Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


optimize quorum read

Now quorum read go through raft and will apply to every follower's store.
1, every follower will apply a read and get the data from store, no need?
2, is it necessary to go though raft?  could the follower  get the newest commitIndex of leader, and wait util the log with the commitIndex applied to follower, then get the data from the store ?

After this PR, a follower skips log applying if the log doesn't have side effect (e.g. Range, read operations in Txn): https://github.com/coreos/etcd/pull/5689
Also, this PR implemented readIndex mechanism: https://github.com/coreos/etcd/pull/6212
With the change, a leader can execute read only requests without appending log entries.

already implemented in 3.1. so closing.


段间距不固定

段间距 不固定， 有的地方段间距是两行，很奇怪，或许latex自动放浮动体的时候，为了使得页面排满，请问该如何调整。

不知道 @sunzhon 咋解决的。我的解决方案是用 \raggedbottom 把空白留在每页最下边。
以下关于 \raggedbottom 的解释为 ChatGPT 生成。
In LaTeX, the command \raggedbottom is used for flexible page formatting. By default, LaTeX documents try to keep the same height for every page (except the last one) and stretches the vertical text spacing in order to achieve this. This can sometimes lead to irregular vertical spaces between lines or paragraphs, which may not always be desirable.
When you use the \raggedbottom command in the preamble of your LaTeX document, you're essentially telling LaTeX not to worry about maintaining the same page height. The text on each page is placed from the top of the page downwards, allowing variable page heights. The blank space, if any, is pushed towards the bottom of the page.


Fix resize bounds check in rootson

Fix small typos (introduced in #349) in the resize bounds checks

👍 looks good thanks

While testing this I also noticed that if I resize the window from the top-right downward past the minimum size, it moves the window around with the mouse. That might be another good bug to look into next.

Unless it's something visible to the naked eye (without actually running any code) I don't think I'll be able to help with that one (because I'm running nvidia proprietary drivers and I can't try wlroots).

@vially You can start wlroots from another compositor (Wayland or X11) if you want to try rootston. ;)

@emersion Thanks for letting me know. I'll try that.


"rustup telemetry" gives a scary error

$ rustup telemetry
thread '<main>' panicked at 'internal error: entered unreachable code', src/rustup-cli/rustup_mode.rs:68
note: Run with `RUST_BACKTRACE=1` for a backtrace.

PR #379 should fix this - I left out the ever important AppSettings::SubcommandRequiredElseHelp


How to show device group (dg) content?

Hi,
I've got list of device groups (DG) with a help of performance.device_group_keys() function.
But can't find how to get details of each defined device group (DG) - I want to know what volumes are part of each device group defined on array.
Any idea how to get it?

Hi Roman,
device groups are not really supported by the API, the only call that I see is https://Unisphere:8443/univmax/restapi/100/replication/devicegroup/{deviceGroupId} GET
The response only gives you basic information about this.
{
"name": "BOH_r2Casc_DG",
"symmetrixId": "000197900256",
"isValid": true,
"isConcurrentRdf": true,
"isCascadedRdf": true,
"numStandards": [
3
],
"standardRdfgs": [
8
],
"standardPairStates": [
"Consistent"
],
"standardHop2PairStates": [
"Synchronized"
],
"numBcvs": [
0
],
"bcvRdfgs": [],
"bcvPairStates": [],
"bcvHop2PairStates": [],
"groupType": "RDF2"
}
We have not done any DG development in PyU4V as it's typically StorageGroup managment within the API.  Sorrry can't be of more help and apologies for the long wait on response.  I missed the notification

Thanks for response Paul.
Despite you don't have any function in PyU4V to get list of volumes from diskgroup it is implemented some how in Unisphere. If you go to Data Protection -> Device Groups, select any of defined device groups then it will be possible to list volume by clicking on number of devices in that group.
Any idea how it's implemented in Unisphere?
I tried to utilize provisioning.get_volume_list() function by specifying filter like {'devicegroup':'BOH_r2Casc_DG'}, but it does not work - I get all volumes on array.

I'll have a look again today and see if there's anything I'm missing
Sent from Outlook for Androidhttps://aka.ms/AAb9ysg
Internal Use - Confidential

From: Roman @.>
Sent: Friday, August 18, 2023 7:00:26 AM
To: dell/PyU4V @.>
Cc: Martin, Paul @.>; Comment @.>
Subject: Re: [dell/PyU4V] How to show device group (dg) content? (Issue #171)
[EXTERNAL EMAIL]
Thanks for response Paul.
Despite you don't have any function in PyU4V to get list of volumes from diskgroup it is implemented some how in Unisphere. If you go to Data Protection -> Device Groups, select any of defined device groups then it will be possible to list volume by clicking on number of devices in that group.
Any idea how it's implemented in Unisphere?
I tried to utilize provisioning.get_volume_list() function by specifying filter like {'devicegroup':'BOH_r2Casc_DG'}, but it does not work - I get all volumes on array.
—
Reply to this email directly, view it on GitHub [github.com]https://urldefense.com/v3/__https://github.com/dell/PyU4V/issues/171*issuecomment-1683394571__;Iw!!LpKI!kjeNwRM4QFQN3FUgH-SPLM5ui5QX5eP7JPOlc3HrkS_bUEFlNQqb6Sdx7bjfxAaQcY0OEiigBqQpBk3dGIvxPNj2$, or unsubscribe [github.com]https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AF7FWPJYL3C4WJ67RP2ONMDXV4AHVANCNFSM6AAAAAA23LJ4BQ__;!!LpKI!kjeNwRM4QFQN3FUgH-SPLM5ui5QX5eP7JPOlc3HrkS_bUEFlNQqb6Sdx7bjfxAaQcY0OEiigBqQpBk3dGEZ0aI3l$.
You are receiving this because you commented.Message ID: @.***>

Roman, there are no additional ways in the API to view contents of Device Groups, they have limited use in the API and the performance details are legacy pre storage group.

Paul, may be it can be implemented in future releases of PyU4V then?

Roman, this needs to be in the API before it's in PyU4V.  PyU4V can make any API call to PowerMax even if it's not coded using the custom API call described in the docs.  You will need to request this through your account team they will open an enhancement.  However I don't expect an enhancement of this nature to make it into the product, Device Groups are not used in Unisphere other than for few legacy operations, which have also moved primarily to storage groups control.  You can always ask.


[ButtonBase] Add a focusVisible action

When a button is focussed using ref.focus() the ripple effect does not start, but this is expected behaviour:
https://material.io/guidelines/components/buttons.html#buttons-raised-buttons
This PR adds a test and fix for this issue.
Closes #3008

import React from 'react';
import Button from 'material-ui/Button';

let sideEffectActions;

function RaisedButtons() {
  return (
    <React.Fragment>
      <Button
        variant="raised"
        action={actions => {
          sideEffectActions = actions;
        }}
      >
        Default
      </Button>
      <Button
        variant="raised"
        color="primary"
        onClick={() => {
          sideEffectActions.focusVisible();
        }}
      >
        Primary
      </Button>
    </React.Fragment>
  );
}

export default RaisedButtons;

Just to clarify, is this changing the behavior so that using ref.focus() will now properly highlight buttons?

Just to clarify, is this changing the behavior so that using ref.focus() will now properly highlight buttons?

@zocheyado No, it shouldn't.

Edit (for example) if a hotkey uses .focus to select the submit button, this would set the button in a focus state now?

This has always been working
import React from "react";
import Button from "material-ui/Button";

let sideEffectNode;

function RaisedButtons() {
  return (
    <React.Fragment>
      <Button
        variant="raised"
        buttonRef={node => {
          sideEffectNode = node;
        }}
      >
        Default
      </Button>
      <Button
        variant="raised"
        color="primary"
        onClick={() => {
          sideEffectNode.focus();
        }}
      >
        Primary
      </Button>
    </React.Fragment>
  );
}

export default RaisedButtons;

https://codesandbox.io/s/k9k938zvj7

Hmm maybe my issue is elsewhere then. I am trying to simulate the tab functionality with a hotkey. I am selecting the element and using ref.focus() and it is properly setting my document.activeElement and I can then press enter if I want to press the button but the visual focus elements are not working. Maybe I need to edit something in my application. Thanks anyway.


Add supplementary forecast

Added supplementary forecast
https://issues.redhat.com/browse/COST-816

Codecov Report

Merging #1778 (a392da2) into master (94d74e0) will increase coverage by 1.00%.
The diff coverage is 42.10%.

@@            Coverage Diff             @@
##           master    #1778      +/-   ##
==========================================
+ Coverage   77.00%   78.00%   +1.00%
==========================================
  Files         295      295
  Lines        4761     5216     +455
  Branches      906     1190     +284
==========================================
+ Hits         3666     4069     +403
- Misses        993     1128     +135
+ Partials      102       19      -83

Impacted Files
Coverage Δ

src/api/forecasts/ocpForecast.ts
66.66% <ø> (ø)

...aryDashboard/ocpSupplementaryDashboardSelectors.ts
50.00% <ø> (ø)

...ntaryDashboard/ocpSupplementaryDashboardActions.ts
32.00% <25.00%> (-3.30%)
:arrow_down:

...pages/dashboard/components/dashboardWidgetBase.tsx
40.93% <33.33%> (-1.51%)
:arrow_down:

...entaryDashboard/ocpSupplementaryDashboardCommon.ts
42.30% <50.00%> (-3.15%)
:arrow_down:

src/api/forecasts/forecast.ts
100.00% <100.00%> (ø)

...ntaryDashboard/ocpSupplementaryDashboardWidgets.ts
100.00% <100.00%> (ø)

src/components/i18n/i18nProvider.tsx
57.14% <0.00%> (-9.53%)
:arrow_down:

src/pages/state/maintenance/maintenanceState.tsx
66.66% <0.00%> (-8.34%)
:arrow_down:

src/store/common.ts
81.81% <0.00%> (-7.08%)
:arrow_down:

... and 101 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94d74e0...a392da2. Read the comment docs.


Update all Makefiles to use C++14.

This is a simple follow-up to #203 that just applies the same changes to the rest of the Makefiles.

I can fix the build, unless you already started working on it.

Sure, feel free---i haven't started looking into it, but I think it should be pretty straightforward to fix.


Please provide one document for Board installation.

In GitLab by @luotian-github on Jun 27, 2017, 17:40
add the get-resource and api-server-k8s_respurce

In GitLab by @yhua123 on Nov 8, 2019, 07:33
#48 and #51 fixed this issue

In GitLab by @sokril on Nov 8, 2019, 08:06
closed

In GitLab by @sokril on Nov 8, 2019, 08:06
assigned to @Robin-Mao


[py2py3] Python3 pyexpat.xmlparser has no attribute returns_unicode

Impact of the bug
WMCore
Describe the bug
Python3 unit tests complain about an attribute that does not exist in the pyexpat.xmlparser python3 library, full traceback in [1].
How to reproduce it
nosetests test/python/WMCore_t/Storage_t/TrivialFileCatalog_t.py

Expected behavior
Find a solution that works both in python2 and python3, consistently. If we have to drop that attribute and deal with byte strings, it should be fine as well. Best approach is yet to be defined.
Additional context and error message
[1]
======================================================================
ERROR: testMultipleRegexMatch (WMCore_t.Storage_t.TrivialFileCatalog_t.TrivialFileCatalogTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/dmwm/wmcore_unittest/WMCore/src/python/WMCore/Storage/TrivialFileCatalog.py", line 214, in readTFC
    node = xmlFileToNode(filename)
  File "/home/dmwm/wmcore_unittest/WMCore/src/python/WMCore/Algorithms/ParseXMLFile.py", line 64, in xmlFileToNode
    expat_parse(open(reportFile, 'r'),
  File "/home/dmwm/wmcore_unittest/WMCore/src/python/WMCore/Algorithms/ParseXMLFile.py", line 79, in expat_parse
    parser.returns_unicode = False
AttributeError: 'pyexpat.xmlparser' object has no attribute 'returns_unicode'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/dmwm/wmcore_unittest/WMCore/test/python/WMCore_t/Storage_t/TrivialFileCatalog_t.py", line 161, in testMultipleRegexMatch
    tfc = readTFC(tfc_file)
  File "/home/dmwm/wmcore_unittest/WMCore/src/python/WMCore/Storage/TrivialFileCatalog.py", line 218, in readTFC
    raise RuntimeError(msg)
RuntimeError: Error reading TrivialFileCatalog: /home/dmwm/wmcore_unittest/WMCore/test/python/WMCore_t/Storage_t/T2_CH_CERNBOX_TrivialFileCatalog.xml
'pyexpat.xmlparser' object has no attribute 'returns_unicode'

It has been apparently fixed by Todor's PR: https://github.com/dmwm/WMCore/pull/10571
I ran these tests a couple of times in the python3 environment and they all pass, including in jenkins report. Closing it.


fixes case sensitivity for SameSite directive

This fix handles case sensitivity for SameSite directive in cookie headers.
Prior to this fix the SameSite values were case sensitive compared with their capitalized names (Lax, Strict, None). This fix allows for case insensitive comparison, allowing values like lax and LAX.
See https://github.com/zendframework/zend-http/issues/206 for more information

@michalbundyra, I processed your feedback. Thank you.

@Xerkus, I processed your feedback.

Please also add a separate test for asserting that SameSite value is canonicalized in setSameSite

@Xerkus all done!

As this was a bugfix, I rebased against master and merged there for a new 2.11.2 release.
Thanks, @wilcol !


CRM Integration sets wrong Modified on filter.

Describe the bug
When setting latestmodifiedon to the IntegrationTableMapping table, the wrong date is set.
When synchronizing to the integration table, the  "Synch. Int. Tbl. Mod. On Fltr." is set, and when synchronizing from the integration table, "Synch. Modified On Filter" field is set. It should be the other way around, otherwise, if you have a sync that only goes in one direction, the filter will be emtpy and you have to loop through all records in the table each synchronization.
To Reproduce

Set up CRM-syncronization with customers with one direction. Start the job que, and you will se that every record is either changed,failed or unchanged.

Expected behavior
Screenshots

Either the index in the onRun or function UpdateTableMappingModifiedOn should be changed.
5. Versions:

AL Language: 4.0.209944
Business Central: 15.1.37881.39299

In Dynamics NAV 2018 version: 11.23572.0 this was not an issue. See screenshots:

Let's get the issue to a team who will fix and backport it, as this repository is only for issues related to the AL compiler in latest developer preview environment for Dynamics 365 Business Central. We suggest that you open a support case or file a bug in Collaborate, to ensure that all Business Central users benefit from your catch as soon as possible.
To open a support case, you can:

Open a support request to CSS through the PartnerSource portal
Contact your Service Account Manager (SAM) in your local subsidiary to understand what is included in your contract as of support incident and PAH (Partner Advisory Hours). Your SAM might also direct you "step by step" how to open a support request or how to get credentials, if this is the first time for you or your company

If you file the bug in Collaborate, remember to include steps to reproduce the issue, and the Business Central build number and country version you're using.
Please also take a minute to read our FAQs https://github.com/Microsoft/AL/wiki/Frequently-Asked-Questions


Substitute ipmi power reset with off and on

Ipmitool power reset often lead to nodes not detecting hard disks.
The manual fix for that is to poweroff the nodes and start again.
This is an attempt to avoid that completely.
This is a copy of the incorrectly branched and closed PR:
https://github.com/SUSE-Cloud/automation/pull/1106

Do not merge label until @vmoravec checks this out on qa2

Closing this PR as it was superseded by https://github.com/SUSE-Cloud/automation/pull/1208/


Add easy way to specify basis contraction scheme  in ano@6s5p3d2f form

It is the only practical way to utilize ANO-RCC basis sets. In future one can introduce aliases like O.ANO-RCC-VDZ for O.ANO-RCC...3s2p which are also there in Molcas.
I choose @ symbol arbitrary as it is not very often used in filenames.

You are right, I assumed general contraction.
Now I tried simply to set optimize=True  when ask for truncation to do "segment contraction -> general contraction".
But it looks like parse_nwchem.optimize_contraction does something else, as there are still two s blocks for H.cc-pvdz.

Truncation should work now for segmented basis sets too.


Laravel Linter

This pull request includes changes and recommendations for crafting your application "The Laravel Way". Feel free to commit any additional changes to the shift-82729 branch.
Before merging, you need to:

Checkout the shift-82729 branch
Review all pull request comments for additional changes
Thoroughly test your application (no tests?, no CI?)

Much of the lint detected may be automatically fixed by running the Laravel Fixer or tasks within the Shift Workbench.

:warning: Shift found uses of the old array() syntax. Laravel adopted the short array syntax [] since it became available in PHP 5.4.

:x: The following configuration files differ from the Laravel defaults. If you are modifying configuration values directly, consider using an environment variable instead to keep these files maintainable. You should compare your configuration files against the latest version and merge any updates.

[ ] config/app.php
[ ] config/auth.php
[ ] config/broadcasting.php
[ ] config/cache.php
[ ] config/database.php
[ ] config/filesystems.php
[ ] config/hashing.php
[ ] config/logging.php
[ ] config/mail.php
[ ] config/queue.php
[ ] config/session.php

:information_source: Starting with Laravel 8, the model property within factories may be removed when your models are stored within a conventional location such as app/Models. Unless your factory is for a model outside of this location, you may remove this property.

:warning: Shift detected Eloquent calls in the following views. You should keep views from interacting directly with your models by passing the necessary data from the controller.

[ ] resources/views/components/line-select.blade.php

:x: Shift found files using the Route methods within your app folder. You should consolidate your routes into one of the default route/api.php or route/web.php route files.

[ ] app/Providers/DuskServiceProvider.php

:information_source: Shift detected controller namespaces being set in your RouteServiceProvider. Laravel 8 began registering routes using static class references instead of namespace prefixes and action strings.

:information_source: As noted, much of the lint detected above can be automatically fixed using the Laravel Fixer. Save yourself time and clean up your codebase quickly with this new Shift.


qt5-qtbase: Add patch to resolve CVE-2024-39936.

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[x] The toolchain has been rebuilt successfully (or no changes were made to it)
[x] The toolchain/worker package manifests are up-to-date
[x] Any updated packages successfully build (or no packages were changed)
[x] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[x] All package sources are available
[x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[x] LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
[x] All source files have up-to-date hashes in the *.signatures.json files
[x] sudo make go-tidy-all and sudo make go-test-coverage pass
[x] Documentation has been updated to match any changes to the build system
[ ] Ready to merge

Summary
Add patch to resolve CVE-2024-39936
Reference: https://www.qt.io/blog/recently-discovered-http2-handling
Change Log

Add patch file

Does this affect the toolchain?
NO
Associated issues
Links to CVEs

https://nvd.nist.gov/vuln/detail/CVE-2024-39936

Test Methodology

Pipeline build id: Local Build

Auto cherry-pick results:

main :white_check_mark: -> https://github.com/microsoft/azurelinux/pull/10129

Auto cherry-pick pipeline run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=620980&view=results


Re-add support for Application and Windows Events

Removed all previous event related code due #5.
Maybe rewriting all the events code from scratch will help fix that, or not and we'll just not include event support.
¯_(ツ)_/¯

Fixed in #5, so this isn't needed to be completed.


Property with getter: This condition will always return 'false'

Bug Report

🔎 Search Terms

getter condition

🕗 Version & Regression Information

This seems like intended behavior (it is sometimes, but not in this case)

⏯ Playground Link
Playground link with relevant code
💻 Code

class Example {
  private get _foo() {
    return Math.random() < 0.5 ? "a" : "b";
  }

  bar() {
    if (this._foo === "a") {
      console.log("got 'a'");
      // this error should not occur:
      if (this._foo === "b") {
        console.log("lucky case, got 'b' too");
      }
    }
  }
}

class Span {
  get end() { return this.start + this.length }
  constructor(public start: number, public length: number) {}
}

const span = new Span(4, 2);

if (span.end == 6) {
  span.length += 1;
  // same here:
  if (span.end == 7) {
    console.log("worked");
  }
}

🙁 Actual behavior
An error occured because TypeScript thinks this._foo/span.end doesn't change until that if-check, but in these examples it does.
🙂 Expected behavior
There shouldn't be such checks with getters.

Another duplicate of #9998.


Hide gnosis connector when not inside a gnosis-safe

Issue https://github.com/snapshot-labs/lock/issues/29
Adds to https://github.com/snapshot-labs/lock/pull/30
Changes proposed in this pull request:

Always hide gnosis-safe connector in the connect modal
Automatically connect with gnosis-safe connector when inside a gnosis-safe iframe
Disable follow button inside gnosis-safe

I just wonder if there's a more specific way to check for the iframe. window.parent === window applies to any iframe i'd guess. Or maybe embedding should be blocked completely for anything but gnosis safe?

Yes unfortunately there current isn't any other way that the gnosis team can provide us. Interesting idea to block the embedding, although I'm not sure if it would improve anything in this case?

I'm not sure if it would improve anything in this case?

Nope, not really.
But this could be interesting: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy/frame-ancestors
In express:
app.use(
  helmet({
    contentSecurityPolicy: {
      directives: {
        frameAncestors: ['gnosis-safe.io']
      }
    },
  })
);


HADOOP-16680. Add MicrosoftGraphGroupsMapping GroupMappingServiceProvider

NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 11s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
1m  6s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
19m 30s
trunk passed

+1 :green_heart:
compile
18m  0s
trunk passed

+1 :green_heart:
checkstyle
2m 41s
trunk passed

+1 :green_heart:
mvnsite
3m 27s
trunk passed

+1 :green_heart:
shadedclient
21m 37s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
2m 25s
trunk passed

+0 :ok:
spotbugs
5m 56s
Used deprecated FindBugs config; considering switching to SpotBugs.

+0 :ok:
findbugs
0m 23s
branch/hadoop-project no findbugs output file (findbugsXml.xml)

+0 :ok:
findbugs
0m 21s
branch/hadoop-tools/hadoop-tools-dist no findbugs output file (findbugsXml.xml)

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 35s
Maven dependency ordering for patch

-1 :x:
mvninstall
2m 29s
hadoop-tools in the patch failed.

-1 :x:
mvninstall
0m 19s
hadoop-tools-dist in the patch failed.

+1 :green_heart:
compile
19m 35s
the patch passed

-1 :x:
javac
19m 35s
root generated 2 new + 1869 unchanged - 0 fixed = 1871 total (was 1869)

-0 :warning:
checkstyle
3m  7s
root: The patch generated 10 new + 0 unchanged - 0 fixed = 10 total (was 0)

+1 :green_heart:
mvnsite
4m 28s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  6s
The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
15m 28s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
3m 19s
the patch passed

+0 :ok:
findbugs
0m 29s
hadoop-project has no data from findbugs

-1 :x:
findbugs
0m 33s
hadoop-msgraph in the patch failed.

-1 :x:
findbugs
6m 12s
hadoop-tools in the patch failed.

+0 :ok:
findbugs
0m 32s
hadoop-tools/hadoop-tools-dist has no data from findbugs

_ Other Tests _

+1 :green_heart:
unit
0m 30s
hadoop-project in the patch passed.

+1 :green_heart:
unit
0m 38s
hadoop-msgraph in the patch passed.

-1 :x:
unit
0m 33s
hadoop-tools in the patch failed.

+1 :green_heart:
unit
0m 31s
hadoop-tools-dist in the patch passed.

-1 :x:
asflicense
0m 55s
The patch generated 3 ASF License warnings.

135m 59s

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1727/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1727

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle

uname
Linux 064379991d46 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / b89fd4d

Default Java
1.8.0_222

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-1727/1/artifact/out/patch-mvninstall-hadoop-tools.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-1727/1/artifact/out/patch-mvninstall-hadoop-tools_hadoop-tools-dist.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-1727/1/artifact/out/diff-compile-javac-root.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1727/1/artifact/out/diff-checkstyle-root.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1727/1/artifact/out/patch-findbugs-hadoop-tools_hadoop-msgraph.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1727/1/artifact/out/patch-findbugs-hadoop-tools.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1727/1/artifact/out/patch-unit-hadoop-tools.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1727/1/testReport/

asflicense
https://builds.apache.org/job/hadoop-multibranch/job/PR-1727/1/artifact/out/patch-asflicense-problems.txt

Max. process+thread count
412 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-tools/hadoop-msgraph hadoop-tools hadoop-tools/hadoop-tools-dist U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1727/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m  1s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
0m 28s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
19m 18s
trunk passed

+1 :green_heart:
compile
18m 15s
trunk passed

+1 :green_heart:
checkstyle
2m 37s
trunk passed

+1 :green_heart:
mvnsite
3m 32s
trunk passed

+1 :green_heart:
shadedclient
20m  1s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
2m 29s
trunk passed

+0 :ok:
spotbugs
5m 39s
Used deprecated FindBugs config; considering switching to SpotBugs.

+0 :ok:
findbugs
0m 30s
branch/hadoop-project no findbugs output file (findbugsXml.xml)

+0 :ok:
findbugs
0m 33s
branch/hadoop-tools/hadoop-tools-dist no findbugs output file (findbugsXml.xml)

-0 :warning:
patch
6m  2s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 25s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m  6s
the patch passed

+1 :green_heart:
compile
17m 38s
the patch passed

-1 :x:
javac
17m 38s
root generated 2 new + 1869 unchanged - 0 fixed = 1871 total (was 1869)

-0 :warning:
checkstyle
2m 39s
root: The patch generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)

+1 :green_heart:
mvnsite
4m  7s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  5s
The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
12m 51s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
3m 15s
the patch passed

+0 :ok:
findbugs
0m 28s
hadoop-project has no data from findbugs

-1 :x:
findbugs
0m 36s
hadoop-msgraph in the patch failed.

+0 :ok:
findbugs
0m 32s
hadoop-tools/hadoop-tools-dist has no data from findbugs

-1 :x:
findbugs
5m 28s
hadoop-tools in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
0m 29s
hadoop-project in the patch passed.

+1 :green_heart:
unit
0m 36s
hadoop-msgraph in the patch passed.

+1 :green_heart:
unit
0m 31s
hadoop-tools-dist in the patch passed.

-1 :x:
unit
62m  2s
hadoop-tools in the patch failed.

-1 :x:
asflicense
0m 55s
The patch generated 2 ASF License warnings.

189m 45s

Reason
Tests

Failed junit tests
hadoop.yarn.sls.appmaster.TestAMSimulator

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1727/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1727

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle

uname
Linux 10a78b067215 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 4c1a128

Default Java
1.8.0_222

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-1727/2/artifact/out/diff-compile-javac-root.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1727/2/artifact/out/diff-checkstyle-root.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1727/2/artifact/out/patch-findbugs-hadoop-tools_hadoop-msgraph.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1727/2/artifact/out/patch-findbugs-hadoop-tools.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1727/2/artifact/out/patch-unit-hadoop-tools.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1727/2/testReport/

asflicense
https://builds.apache.org/job/hadoop-multibranch/job/PR-1727/2/artifact/out/patch-asflicense-problems.txt

Max. process+thread count
1078 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-tools/hadoop-msgraph hadoop-tools/hadoop-tools-dist hadoop-tools U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1727/2/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  8s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
markdownlint
0m  0s
markdownlint was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
0m 26s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
20m  5s
trunk passed

+1 :green_heart:
compile
17m 40s
trunk passed

+1 :green_heart:
checkstyle
2m 47s
trunk passed

+1 :green_heart:
mvnsite
3m 35s
trunk passed

+1 :green_heart:
shadedclient
20m 18s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
2m 28s
trunk passed

+0 :ok:
spotbugs
5m 31s
Used deprecated FindBugs config; considering switching to SpotBugs.

+0 :ok:
findbugs
0m 26s
branch/hadoop-project no findbugs output file (findbugsXml.xml)

+0 :ok:
findbugs
0m 28s
branch/hadoop-tools/hadoop-tools-dist no findbugs output file (findbugsXml.xml)

-0 :warning:
patch
5m 49s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 25s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 12s
the patch passed

+1 :green_heart:
compile
17m  6s
the patch passed

+1 :green_heart:
javac
17m  6s
the patch passed

-0 :warning:
checkstyle
2m 34s
root: The patch generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)

+1 :green_heart:
mvnsite
4m 19s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  5s
The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
12m 43s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
3m 13s
the patch passed

+0 :ok:
findbugs
0m 30s
hadoop-project has no data from findbugs

-1 :x:
findbugs
0m 37s
hadoop-msgraph in the patch failed.

+0 :ok:
findbugs
0m 32s
hadoop-tools/hadoop-tools-dist has no data from findbugs

-1 :x:
findbugs
5m 12s
hadoop-tools in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
0m 30s
hadoop-project in the patch passed.

+1 :green_heart:
unit
0m 39s
hadoop-msgraph in the patch passed.

+1 :green_heart:
unit
0m 33s
hadoop-tools-dist in the patch passed.

-1 :x:
unit
61m 48s
hadoop-tools in the patch failed.

-1 :x:
asflicense
0m 58s
The patch generated 3 ASF License warnings.

188m  3s

Reason
Tests

Failed junit tests
hadoop.yarn.sls.appmaster.TestAMSimulator

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1727/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1727

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml markdownlint findbugs checkstyle

uname
Linux 5a93c75b2645 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 4c1a128

Default Java
1.8.0_222

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1727/3/artifact/out/diff-checkstyle-root.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1727/3/artifact/out/patch-findbugs-hadoop-tools_hadoop-msgraph.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1727/3/artifact/out/patch-findbugs-hadoop-tools.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1727/3/artifact/out/patch-unit-hadoop-tools.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1727/3/testReport/

asflicense
https://builds.apache.org/job/hadoop-multibranch/job/PR-1727/3/artifact/out/patch-asflicense-problems.txt

Max. process+thread count
1092 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-tools/hadoop-msgraph hadoop-tools/hadoop-tools-dist hadoop-tools U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1727/3/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
31m 19s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
markdownlint
0m  0s
markdownlint was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
1m  7s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
18m 10s
trunk passed

+1 :green_heart:
compile
16m 44s
trunk passed

+1 :green_heart:
checkstyle
2m 39s
trunk passed

+1 :green_heart:
mvnsite
3m 29s
trunk passed

+1 :green_heart:
shadedclient
19m 51s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
2m 39s
trunk passed

+0 :ok:
spotbugs
5m 11s
Used deprecated FindBugs config; considering switching to SpotBugs.

+0 :ok:
findbugs
0m 33s
branch/hadoop-project no findbugs output file (findbugsXml.xml)

+0 :ok:
findbugs
0m 33s
branch/hadoop-tools/hadoop-tools-dist no findbugs output file (findbugsXml.xml)

-0 :warning:
patch
5m 31s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 30s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m  8s
the patch passed

+1 :green_heart:
compile
16m 19s
the patch passed

+1 :green_heart:
javac
16m 19s
the patch passed

-0 :warning:
checkstyle
2m 38s
root: The patch generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)

+1 :green_heart:
mvnsite
4m 13s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  5s
The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
12m 41s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
3m 17s
the patch passed

+0 :ok:
findbugs
0m 33s
hadoop-project has no data from findbugs

-1 :x:
findbugs
0m 36s
hadoop-msgraph in the patch failed.

-1 :x:
findbugs
5m  3s
hadoop-tools in the patch failed.

+0 :ok:
findbugs
0m 34s
hadoop-tools/hadoop-tools-dist has no data from findbugs

_ Other Tests _

+1 :green_heart:
unit
0m 32s
hadoop-project in the patch passed.

+1 :green_heart:
unit
0m 39s
hadoop-msgraph in the patch passed.

+1 :green_heart:
unit
60m 16s
hadoop-tools in the patch passed.

+1 :green_heart:
unit
0m 37s
hadoop-tools-dist in the patch passed.

-1 :x:
asflicense
0m 57s
The patch generated 3 ASF License warnings.

213m 28s

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1727/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1727

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml markdownlint findbugs checkstyle

uname
Linux ef5420bd9c9d 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 4c1a128

Default Java
1.8.0_222

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1727/4/artifact/out/diff-checkstyle-root.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1727/4/artifact/out/patch-findbugs-hadoop-tools_hadoop-msgraph.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1727/4/artifact/out/patch-findbugs-hadoop-tools.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1727/4/testReport/

asflicense
https://builds.apache.org/job/hadoop-multibranch/job/PR-1727/4/artifact/out/patch-asflicense-problems.txt

Max. process+thread count
1100 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-tools/hadoop-msgraph hadoop-tools hadoop-tools/hadoop-tools-dist U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1727/4/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 35s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
markdownlint
0m  0s
markdownlint was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
0m 28s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
20m  4s
trunk passed

+1 :green_heart:
compile
20m 14s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
17m 41s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
checkstyle
2m 34s
trunk passed

+1 :green_heart:
mvnsite
3m 38s
trunk passed

+1 :green_heart:
shadedclient
20m 28s
branch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 36s
hadoop-tools in trunk failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.

+1 :green_heart:
javadoc
2m 34s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+0 :ok:
spotbugs
5m 37s
Used deprecated FindBugs config; considering switching to SpotBugs.

+0 :ok:
findbugs
0m 28s
branch/hadoop-project no findbugs output file (findbugsXml.xml)

+0 :ok:
findbugs
0m 30s
branch/hadoop-tools/hadoop-tools-dist no findbugs output file (findbugsXml.xml)

-0 :warning:
patch
5m 55s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

-1 :x:
mvninstall
0m 13s
hadoop-tools in the patch failed.

-1 :x:
mvninstall
0m 11s
hadoop-msgraph in the patch failed.

-1 :x:
mvninstall
0m 16s
hadoop-tools-dist in the patch failed.

-1 :x:
compile
0m 14s
root in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.

-1 :x:
javac
0m 14s
root in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.

-1 :x:
compile
0m 14s
root in the patch failed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09.

-1 :x:
javac
0m 14s
root in the patch failed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09.

-0 :warning:
checkstyle
0m 12s
The patch fails to run checkstyle in root

-1 :x:
mvnsite
0m 13s
hadoop-tools in the patch failed.

-1 :x:
mvnsite
0m 11s
hadoop-msgraph in the patch failed.

-1 :x:
mvnsite
0m 12s
hadoop-tools-dist in the patch failed.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  5s
The patch has no ill-formed XML file.

-1 :x:
shadedclient
0m 17s
patch has errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 13s
hadoop-tools in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.

-1 :x:
javadoc
0m 11s
hadoop-msgraph in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.

-1 :x:
javadoc
0m 13s
hadoop-tools-dist in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.

-1 :x:
javadoc
0m 13s
hadoop-tools in the patch failed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09.

-1 :x:
javadoc
0m 11s
hadoop-msgraph in the patch failed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09.

-1 :x:
javadoc
0m 13s
hadoop-tools-dist in the patch failed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09.

+0 :ok:
findbugs
0m 13s
hadoop-project has no data from findbugs

-1 :x:
findbugs
0m 13s
hadoop-tools in the patch failed.

-1 :x:
findbugs
0m 12s
hadoop-msgraph in the patch failed.

-1 :x:
findbugs
0m 13s
hadoop-tools-dist in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
0m 13s
hadoop-project in the patch passed.

-1 :x:
unit
0m 13s
hadoop-tools in the patch failed.

-1 :x:
unit
0m 11s
hadoop-msgraph in the patch failed.

-1 :x:
unit
0m 13s
hadoop-tools-dist in the patch failed.

+0 :ok:
asflicense
0m 14s
ASF License check generated no output?

99m 52s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1727/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1727

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml markdownlint findbugs checkstyle

uname
Linux 234c8e06a286 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / e756fe35909

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09

javadoc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1727/3/artifact/out/branch-javadoc-hadoop-tools-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

mvninstall
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1727/3/artifact/out/patch-mvninstall-hadoop-tools.txt

mvninstall
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1727/3/artifact/out/patch-mvninstall-hadoop-tools_hadoop-msgraph.txt

mvninstall
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1727/3/artifact/out/patch-mvninstall-hadoop-tools_hadoop-tools-dist.txt

compile
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1727/3/artifact/out/patch-compile-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

javac
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1727/3/artifact/out/patch-compile-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

compile
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1727/3/artifact/out/patch-compile-root-jdkPrivateBuild-1.8.0_252-8u252-b09-1~18.04-b09.txt

javac
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1727/3/artifact/out/patch-compile-root-jdkPrivateBuild-1.8.0_252-8u252-b09-1~18.04-b09.txt

checkstyle
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1727/3/artifact/out/buildtool-patch-checkstyle-root.txt

mvnsite
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1727/3/artifact/out/patch-mvnsite-hadoop-tools.txt

mvnsite
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1727/3/artifact/out/patch-mvnsite-hadoop-tools_hadoop-msgraph.txt

mvnsite
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1727/3/artifact/out/patch-mvnsite-hadoop-tools_hadoop-tools-dist.txt

javadoc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1727/3/artifact/out/patch-javadoc-hadoop-tools-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

javadoc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1727/3/artifact/out/patch-javadoc-hadoop-tools_hadoop-msgraph-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

javadoc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1727/3/artifact/out/patch-javadoc-hadoop-tools_hadoop-tools-dist-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

javadoc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1727/3/artifact/out/patch-javadoc-hadoop-tools-jdkPrivateBuild-1.8.0_252-8u252-b09-1~18.04-b09.txt

javadoc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1727/3/artifact/out/patch-javadoc-hadoop-tools_hadoop-msgraph-jdkPrivateBuild-1.8.0_252-8u252-b09-1~18.04-b09.txt

javadoc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1727/3/artifact/out/patch-javadoc-hadoop-tools_hadoop-tools-dist-jdkPrivateBuild-1.8.0_252-8u252-b09-1~18.04-b09.txt

findbugs
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1727/3/artifact/out/patch-findbugs-hadoop-tools.txt

findbugs
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1727/3/artifact/out/patch-findbugs-hadoop-tools_hadoop-msgraph.txt

findbugs
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1727/3/artifact/out/patch-findbugs-hadoop-tools_hadoop-tools-dist.txt

unit
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1727/3/artifact/out/patch-unit-hadoop-tools.txt

unit
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1727/3/artifact/out/patch-unit-hadoop-tools_hadoop-msgraph.txt

unit
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1727/3/artifact/out/patch-unit-hadoop-tools_hadoop-tools-dist.txt

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1727/3/testReport/

Max. process+thread count
413 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-tools hadoop-tools/hadoop-msgraph hadoop-tools/hadoop-tools-dist U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1727/3/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@goiri looks like some other pom change has broken the merge. Rebase and we can look at it again


Make default displayers actual plugins

Have you read the FAQ and checked for duplicate open issues?
Yes.
Is your feature request related to a problem? Please describe.

Shaka currently has plugin system, i.e. to decide in individual build shall some text parsers be included. However, it doesn't work like that for text diplayers - theoretically they are plugins, but they have strong dependency in core build. In custom build, when someone provides custom displayer there is currently no possibility to exclude default displayers and decrease bundle size.
Describe the solution you'd like

API proposal:

shaka.text.TextEngine:

add factory for default HTML-based displayer and default simple displayer

shaka.extern.TextDisplayer:

add method attachVideo(video: HTMLMediaElement): void
add method attachContainer(container: HTMLElement): void

shaka.text.UITextDisplayer/SimpleTextDisplayer:

remove parameters from constructors
move constructors' logic to new interface methods
exclude displayers from @core

shaka.Player

defaultConfig_():

adjust default config logic for usage of default factories
fallback to dummy displayer implementation if no factories

applyConfig_(), onInitializeMediaSourceEngine_()

call new interface methods during displayer initialization
if methods are not provided, raise a warning about missing API implementation

Describe alternatives you've considered

Forking and removing unneeded dependencies manually.
Additional context

I'm happy to work on that if Shaka team thinks this idea is valuable for the project.

EDIT: as text displayers are exported classes, constructor parameters cannot be easily dropped. I'd mark them as optional and call new methods in a constructor if they're provided.

For me it doesn't add much value, but I understand the purpose. Is anyone in the community interested in this?


[Improve][pom] Formatting pom

Purpose of this pull request

Check list

[ ] Code changed are covered with tests, or it does not need tests for reason:
[ ] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
[ ] If you are contributing the connector code, please check that the following files are updated:

Update change log that in connector document. For more details you can refer to connector-v2
Update plugin-mapping.properties and add new connector information in it
Update the pom file of seatunnel-dist

[ ] Update the release-note.

the error is not related to this pr, can you fix it

Done.


How to create custom MongoDB indexes

I am trying to use ST2 REST API to get executions.

The request is as follows:

curl -s \
  -H 'Content-Type: application/json'
  -H "St2-Api-Key: ${ST2_API_KEY}"\
  -k 'localhost:80/api/v1/executions?offset=0&limit=100&parent=null'

This request takes about 5 to 8 seconds in our environment.

I checked the mongoDB's execution plan and found that the sorting process took a long time.

I created a following index to speed up the sorting process.

db.action_execution_d_b.createIndex({ parent: 1, start_timestamp: -1, 'action.ref': 1 }, { background: true })

The index has improved request speed. However, the created index is automatically deleted.

2024-11-15T03:22:50.069+0900 I ACCESS   [conn965898] Successfully authenticated as principal st2admin on st2 from client xxx.xxx.xxx.xxx:50468
2024-11-15T03:22:50.103+0900 I COMMAND  [conn965898] CMD: dropIndexes st2.action_execution_d_b

Then I have two questions

Is it a specification that user-created index is deleted?
Is there a way to prevent user-created index from being automatically deleted?

Thank you for your response.
I added an index to st2common/models/db/execution.py and the index was created the next day and has been maintained to date!
It seems that ST2 periodically manages the index automatically, but is it possible to reflect changes in the files under models/db/ at any given time?

I remember that the index will be rebuilt when the service is restarted. You can check the source code for this


Open groupplot

Current coverage is 94.43% (diff: 87.50%)

Merging #125 into master will increase coverage by 0.54%

@@             master       #125   diff @@
==========================================
  Files            11         11
  Lines           967       1079   +112
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            908       1019   +111
- Misses           59         60     +1
  Partials          0          0

Powered by Codecov. Last update b72afd4...43cc010


[Stable] Enable deprecation msg for List-based aux.ops

Summary
Partial backport of #759
Details and comments

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

7 of 9 (77.78%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.02%) to 84.732%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

qiskit_nature/settings.py
7
9
77.78%

Files with Coverage Reduction
New Missed Lines
%

qiskit_nature/settings.py
1
86.67%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
9917

Relevant Lines:
11704

💛  - Coveralls


Update fun.js

!holyhandgrenade @someone will act somewhat like !banhammer @somone. If there is no suffix, it instead quotes monty python

As discussed, closing because of the wall-of-text response and, if the text is removed, it would result in a simple !tag command.

As discussed, closing because of the wall-of-text response and, if the text is removed, it would result in a simple !tag command.


fix ci

Changes

It looks like our CI actions got out of date, and started erroring out in the CI workflow
update to the latest, hope that helps

ran into this as well on another project -.-

LGTM!


CS1617: Clarify valid language versions (#20259)

This attempts to fix #20259 which highlighted a misunderstanding with the list of valid language versions for CS1617 since it didn’t specify that the valid language versions depend on the version of .NET that is being used.
Summary
Clarify for CS1617 that the list of valid language versions depends on
the .NET version that is being used to compile the application. Newer
language versions will only be available by .NET versions that came
after the language version was introduced. The displayed list only
shows the versions for the current version of .NET.

@IEvangelist Thank you for your feedback! I’ve updated the PR to incorporate your suggestions. – I’m happy that I can help! 😊


Added constraint strength parameter to manifold constraints

Updated ManifoldConstraints with the constraint strength parameter, gamma_. I don't expect anymore changes to this class for the time being, so I think we can merge it in.

sounds good.


Don't generate nested model interface if it's the only one

The use case is the same as in #358. I've got files which contain a view and queries for that view. Let's say the file is called UserView.sq and the view inside it user_view. Right now I'd get
public interface UserViewModel {
  // create view statement and query strings

  interface User_viewModel {
    // fields
  }
}

I'd like to get:
public interface UserViewModel {
  // fields

  // create view statement and query strings
}

It makes the generated code simpler and you get control over how the model is named. I'm not sure if you'd only want that when there is a view declared in the file or in all cases where all queries in a file share the same model.

working-kotlin branch has diverged significantly from this style so closing for now


Moving docker environment variable to a separate .env file

Moving the configuration properties and environment variables from
docker-compose.yml, to separate rendezvous.env files.
Signed-off-by: Chandrakar, Prateek<EMAIL_ADDRESS>

@prateekcr Please rebase and post.


use istio-system as default namespace

as istio.yaml indicated for mixer deployment config.

Jenkins job istio.github.io/presubmit passed

@douglas-reid I remember you objecting to this change in istio/istio when @andraxylia made a similar change. I haven't kept up. So please comment/approve.

Jenkins job istio.github.io/presubmit passed


strong-mode documentation points to archived repo

The two google links at:
https://github.com/dart-lang/sdk/blob/2c0ba56ea12490d7f355641d2b5169386cbee53c/pkg/analyzer_cli/lib/src/options.dart#L383
https://github.com/dart-lang/sdk/blob/2c0ba56ea12490d7f355641d2b5169386cbee53c/pkg/analyzer_cli/lib/src/options.dart#L389
both point to a Markdown doc that was last updated in 2016 and is in an archived / deprecated repo.
It's unclear whether these are still relevant. https://dart.dev/guides/language/analysis-options#enabling-additional-type-checks suggests that implicit-casts is now deprecated; it's not clear whether the same applies to implicit-dynamic or not. I'm unclear whether they should still be turned on?

@srawlins For status of the options.
I will point out that the analyzer_cli package contains the implementation of the dartanalyzer command, which itself is deprecated and will at some point be removed. I don't know whether that impacts the importance of dealing with the help documentation.

I believe these options are now also fully covered by the strict-casts, strict-inference, and strict-raw-types language modes:
analyzer:
  language:
    strict-casts: true
    strict-inference: true
    strict-raw-types: true

Side note, could we somehow deprecate the strong-mode in analysis_options.md and direct users to the new language modes?

Yes, we can, and probably should, create diagnostic for those cases. We already have one for strong-mode: true, which we believed to be the more common case.

I'm going to close this in favor of https://github.com/dart-lang/sdk/issues/50679 which tracks removing these modes, since the old analyzer_cli referenced here is no longer used.
https://dart.dev/tools/analysis#enabling-additional-type-checks documents the newer language modes.


Plagariasm (checkio.org)

Thought you'd want to know:
https://js.checkio.org/blog/javascript-best-practices-function/

This was a blatant rip off as well https://blog.risingstack.com/javascript-clean-coding-best-practices-node-js-at-scale/.

Thanks for your detective work! It's unfortunate for the contributors that they are not receiving credit by a link back to this repo. I'll leave a kind request for these blogs when I get the chance.

In all honesty, MIT licence doesn't say anything about this. Only that the licence itself should be included in the used code.
In that sense it's fine to use and publish the code as is. As long as they publish it with the same licence. They don't have to link the repo at all. It's nice practice, but under MIT it's not a obligation. If I'm wrong, please ping me, because licensing is hard to understand.

At the end of the day, I'm just happy that people are learning and writing better code. Recognition is nice, but this project has exceeded all of my expectations.
Thanks!


Implement Dex Routing

Use data from liquidity indices (#1778) with the Path (#1777) along with the algorithm from #1776  to construct Paths based on TradingPairs and available LiquidityPositions.
Specify a max-length for routes as a parameter for the routing code
How do we bound the number of edges we consider?

Don’t want a situation where dust positions blow up graph traversal
Based on amount of available liquidity, to exclude dust positions? Heuristics are unclear

Based on details here: https://hackmd.io/jtoiMn0pQnSTZlOi2ig5Wg

#1725 has taken precedence over this, and will likely ship in #1877. This work we'll track on the subsequent sprint.

https://github.com/penumbra-zone/penumbra/pull/1894 is WIP, good candidate to ship in testnet 43 next week.

@erwanor @hdevalence should this be combined with #1724 ?

Yes, now that we're doing routing via simulated execution, we can merge them and close this as not planned.


Square video problem

Hi, i have a problem. I use this code and got 640x640 video but its converted from 1280x720 and thats why images distorted images. Where i am wrong? i tried different codecs but same problem.
(My images res 640x640 )
var proc = new ffmpeg({
            source: './test/' + 0  + '/img%0d.jpg',
            nolog: false
        }).format('mp4')
            .size('640x640')
            .autopad()
            .videoCodec('libx264')

            .videoFilter('zoompan=d=60:');//
        proc.save(path + 'video' + '.mp4', function (retcode, error) {
            console.log('file has been converted succesfully');
        });

Regards

I found setstar filter :)
and resolved problem


Can't delete s3 repo

Detailed Description

I published my repo with "aptly publish snapshot -force-overwrite=true -component=main -distribution=xenial main1.0 s3:repo:"
My graph is as follows
https://cl.ly/2I0j3U3d3B3w
I've tried:
aptly publish drop .xenial
aptly publish drop ./xenial
aptly publish drop s3:repo ./xenial
aptly publish drop s3:repo ./xenial
aptly publish drop main ./xenial
aptly publish drop xenial-main
aptly publish drop aptly publish list -raw
aptly publish drop xenial
aptly publish drop s3:repo:. xenial
aptly publish drop s3:repo:.xenial
aptly publish drop s3:repo:./xenial
aptly publish drop main
aptly publish drop s3:repo:./xenial
aptly publish drop s3:repo:xenial
aptly publish drop s3:repo:./xenial
aptly publish drop .:./xenial
aptly publish drop s3:repo:./xenial
Context

I am currently deleting my repo and starting fresh
Published repositories:

s3:repo:./xenial [armhf] publishes {main: [main1.0]: Snapshot from local repo [main]}

Possible Implementation

Your Environment

aptly version: 1.0.1
macOS

Not using s3, but I believe the correct syntax would be
aptly publish drop xenial s3:repo

Similar to my environment, where it would be:
aptly publish drop local-xenial ubuntu
While the repo has been published to the .../public/ubuntu/ directory as dist local-xenial


flutter doctor reports /user/bin/chromium is not executable - but project runs correctly

I have just installed flutter 2.0. I setup a linux device and activated desktop support.
Running "flutter doctor" I receive an error which says I can find chromium at /usr/bin/chromium
but reports that it is not executable.
However I can run "./chromium" when I am in "/usr/bin" dictory. When I am in my $HOME
directory and execute chromium, it runs correctly.
leemke@penguin:~$ flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 2.0.4, on Linux, locale en_US.UTF-8)
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
[✗] Chrome - develop for the web (Cannot find Chrome executable at /user/bin/chromium)
! /user/bin/chromium is not executable.
[✓] Linux toolchain - develop for Linux desktop
[✓] Android Studio
[✓] Connected device (1 available)
! Doctor found issues in 1 category.
leemke@penguin:~$ flutter devices
2 connected devices:
Google Pixelbook (mobile) • emulator-5554 • android-x64 • Android 9 (API 28)
Linux (desktop)           • linux         • linux-x64   • Linux
leemke@penguin~$
However,
created a new project (p1) ran "dart migrate,,," and "flutter run -d linux"
during initial run it reinstalled android tools v29. Version 30 was already installed
(latest android studio was just installed before installing flutter)
the application ran without a problem.
rerunning "flutter doctor" still report an error that chromium is not executable.

it seems the "flutter doctor" report is in error.

@leemke
try adding to your path export CHROME_EXECUTABLE=/usr/bin/chromium

Closing as duplicate of https://github.com/flutter/flutter/issues/77900.

Sorry. I did not mention it in my first post.
I already have CHROME_EXECUTABLE set to "/usr/bin/chromium". Flutter did not detect
the executable without that setting.

My mistake. I mis-coded the directory for chromium. I defined it as "/user/bin". And I thought I had coded /usr/bin
Thanks for your support


New, non-underwear hat logo artwork

This is the new version of the logo we'd worked on + an update to the README to pull in the new logo.

bot, add author to whitelist

bot, test pull request

Looks like some of the patches are missing a 'Signed-off-by:' in their commit logs.

@mairin You need to do a
git commit -a --amend -s
git push --force
to add your signature to your PRs.

#359 replaced this PR and it has been merged.  I'm going to close this one.  @mairin TYVM for the logo updates!


Update skip link css to hide 1px line - census

PR for #1478 for census branch

 PR #1480 Update skip link css to hide 1px line - census


Support reading the current version from a package.json

Feature Request
Support reading / writing the version from a package.json

Hi @garethjevans ,
Can I try to work on this issue ?
I'am a new to contributing to Jenkins / Jenkins plugins, is it ok for you ?
Is there any code convention to follow (I have read the default contributing) ?
Regards.

@ADI10HERO is it mean that it's ok for me to work on this issue ?

@ADI10HERO is it mean that it's ok for me to work on this issue ?

Hey @philippart-s, yes please, by all means :)
Would you like to:

Get this issue assigned to yourself
Join the gitter channel for this project to chat/discuss your approach

@ADI10HERO can't assign to my self, I think you have the rigth to do the assignment


Only include the required output in ps

On mac, lx includes:
-l Display information associated with the following keywords:
uid, pid, ppid, flags, cpu, pri, nice, vsz=SZ, rss, wchan,
state=S, paddr=ADDR, tty, time, and command=CMD.
On mac, the ps output can be misaligned, e.g. when some VSZ field is
longer than expected.
VSZ and many others of these fields are unnecessary because we're looking
up by name, pid, ppid, or arguments only. Here I select those directly.

Another attempt to fix #62. Only tested on mac.

With the [] in place, I got the following:

See also #64

Seems like the output is not being properly parsed by table-parser

Fixing this required making a fix to table-parser: https://github.com/neekey/table-parser/pull/12

@Empact Hi, you can now use<EMAIL_ADDRESS>Can you try using the new version of table-parser first instead of change the default lx, which might have impact for linux

@neekey rebased and updated dependency 👍

Gotcha, yeah will get to that this weekend.
On Sat, Apr 7, 2018 at 18:18 Neekey<EMAIL_ADDRESS>wrote:

@Empact https://github.com/Empact can you revert the change of var
exeArgs = query.psargs || ['lx']; to see if it works for you?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/neekey/ps/pull/69#issuecomment-379511063, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAAVXng-35exWF_cn6sbCvm2le4n5HW8ks5tmWVLgaJpZM4RMLya
.

@neekey Can confirm that this does not work without the change to ['lx']. The problem is that the ps output becomes misaligned due to poor handling of data on ps's side. The fix works by excluding the columns that are likely to overflow.
Agree we need to test for impact against linux.

FWIW ubuntu man page is consistent with this use: http://manpages.ubuntu.com/manpages/xenial/man1/ps.1.html

@neekey Thoughts on this?


Macro invocation formatting added a trailing comma which shouldn't have been here

Here is the diff.
-sql_function!(add_rss_item,
-              add_rss_item_t,
-              (a: types::Integer,
-               b: types::Timestamptz,
-               c: types::Text,
-               d: types::Text,
-               e: types::Text));
+sql_function!(add_rss_item, add_rss_item_t, (
+    a: types::Integer,
+    b: types::Timestamptz,
+    c: types::Text,
+    d: types::Text,
+    e: types::Text,
+));

This macro doesn't support having a trailing comma so it doesn't compile.

Can confirm with a similar snippet:
-    w.slice_mut(s![.., init_size[1] - ext..init_size[1], ..])
-        .par_map_inplace(|el| *el = 0.);
+    w.slice_mut(s![
+        ..,
+        init_size[1] - ext..init_size[1],
+        ..,
+    ]).par_map_inplace(|el| *el = 0.);


"Valea Presnei" is listed in the drop-down menu

Description:
"Valea Presnei" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Valea Presnei" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Valea Presnei, CĂLĂRAȘI (Gurbănești)".


Make package failed

I am using Carla 0.9.4 and UnreaL Engine 4.21 in Ubuntu 16.0.4. I have built the Unreal engine successfully, but got an error with the command of make package.
ERROR: Cook failed.
(see /home/pci/Library/Logs/Unreal Engine/LocalBuildLogs/Log.txt for full exception trace)
AutomationTool exiting with ExitCode=25 (Error_UnknownCookFailure)
RunUAT ERROR: AutomationTool was unable to run successfully.
Util/BuildTools/Linux.mk:13: recipe for target 'package' failed
make: *** [package] Error 25
Please check the log attached.
Log.txt
Any help will be very appreciated.Thanks~~

Seeing similar errors with make package with CARLA 0.9.7, UE 4.23 (Elvis Dowson's ppc64le fork), Clang8, in Ubuntu 18.04 ppc64le (yes, lots of unsupported things here), but make launch appears to work...  Hopefully, FBX isn't required somewhere in this process (no ppc64le support), but the build.utils target wasn't part of the chain.

Log.WriteException: ==============================================================================
Log.WriteException: ERROR: Cook failed.
Log.WriteException:        (see /home/carla/Library/Logs/Unreal Engine/LocalBuildLogs/Log.txt for full exception trace)
Log.WriteException:
Log.WriteException: CommandletException: Editor terminated with exit code 1 while running Cook for /mnt/workspace/carla/Unreal/CarlaUE4/CarlaUE4.uproject; see log /home/carla/Library/Logs/Unreal Engine/LocalBuildLogs/Cook-2019.12.30-21.00.16.txt
Log.WriteException:   at AutomationTool.CommandUtils.RunCommandlet (Tools.DotNETCommon.FileReference ProjectName, System.String UE4Exe, System.String Commandlet, System.String Parameters, System.String& DestLogFile) [0x0076d] in :0
Log.WriteException:   at AutomationTool.CommandUtils.RunCommandlet (Tools.DotNETCommon.FileReference ProjectName, System.String UE4Exe, System.String Commandlet, System.String Parameters) [0x00001] in :0
Log.WriteException:   at AutomationTool.CommandUtils.CookCommandlet (Tools.DotNETCommon.FileReference ProjectName, System.String UE4Exe, System.String[] Maps, System.String[] Dirs, System.String InternationalizationPreset, System.String[] CulturesToCook, System.String TargetPlatform, System.String Parameters) [0x0013e] in :0
Log.WriteException:   at Project.Cook (AutomationTool.ProjectParams Params) [0x007ba] in :0 Wrapped by AutomationException: Cook failed.
Log.WriteException:   at Project.Cook (AutomationTool.ProjectParams Params) [0x007f7] in :0
Log.WriteException:   at BuildCookRun.DoBuildCookRun (AutomationTool.ProjectParams Params) [0x00074] in :0
Log.WriteException:   at BuildCookRun.ExecuteBuild () [0x00040] in :0
Log.WriteException:   at AutomationTool.BuildCommand.Execute () [0x00001] in :0
Log.WriteException:   at AutomationTool.Automation.Execute (System.Collections.Generic.List1[T] CommandsToExecute, System.Collections.Generic.Dictionary2[TKey,TValue] Commands) [0x0007c] in :0
Log.WriteException:   at AutomationTool.Automation.Process (System.String[] Arguments, UnrealBuildTool.StartupTraceListener StartupListener) [0x00282] in :0
Log.WriteException:   at AutomationTool.Program.MainProc (System.String[] Arguments, UnrealBuildTool.StartupTraceListener StartupListener) [0x00001] in <888f4e38a3204f838c76ac2ccfb9c026>:0
Log.WriteException:   at AutomationTool.Program+<>c__DisplayClass1_0.b__2 () [0x00000] in <888f4e38a3204f838c76ac2ccfb9c026>:0
Log.WriteException:   at AutomationTool.InternalUtils.RunSingleInstance (System.Func`1[TResult] Main) [0x000a0] in :0
Log.WriteException:   at AutomationTool.Program.Main (System.String[] Arguments) [0x0020a] in <888f4e38a3204f838c76ac2ccfb9c026>:0
Log.WriteException: ==============================================================================
Program.Main: AutomationTool exiting with ExitCode=25 (Error_UnknownCookFailure)


Support for spaces in paths on Windows systems added.

/cc https://github.com/Microsoft/TypeScript/issues/6891

Hi @SetTrend, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;


RPC Server Unavailable

Not sure anyone else has seen this, but about 40-50% of the time using the tool to import drivers, it'll fail part way through importing the drivers with an "RPC Server Unavailable" error, having only imported some of the drivers, and to fix it usually requires  a reboot of the computer.
Anyone else seen this or have a fix? I have not been able to rule out any possibles, network, the computer, the MECM instance, etc because I really don't have a place to start as the error message is not very specific.
Thanks!

The specific error code I see is 0x800706BE. Which just seems to be a generic RPC error. It's unclear if it's local RPC that goes unavailable, or the remote RPC.

This is fixed with 7.1.4.


Error UI for Agent Message

Find an okay first-iteration design for the error message in assistant--currently from #1459

@Duncid WDYT?
@spolu FYI

Do you have a list of the errors we may have and their meaning ?
What are the actions to be taken in case of error?

They are exteremly varied and go from our fault to provider fault etc...
Action is retry
The content (error code and error message) is for debugging purpose so it can be hidden by default but accessible if we ask them to show us

slack thread with the related discussion & the agreed on specs


typing con into boxes crashes the game

Describe your bug here.
as the title says, typing con into textboxes crashes the game
this is probably way too minor of a bug to bother fixing but yeah
Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
nope

Idk if this is correct but con is one of those words that windows hates. So naming something con wouldn't work.

^