Accordion Chevron duplicate id attribute

The accordion pulls in an SVG chevron for each child in the accordion.
Each SVG has multiple id attributes which are duplicated for each instance.
Where the id property is not needed it needs to be removed.

Cools, I think this one is pretty straightforward to fix 😊 , feel free to open a PR or I'll do later 💆🏻♂

Fixed and deployed on the above PR ☝


Issue with compiling run_fixed_size.cc

Hi all, I have some issues when trying to run the run_fixed_size.cc

In common.h header file there is a line to include the measurements.h header file. However, the compiler keeps telling me that there is no such file or directory.

#include <symforce/examples/robot_3d_localization/gen/measurements.h>
I then tried to just do #include "./gen/measurements.h" and the above error didn't pop up anymore. However, many more errors popped up as shown below

Has anyone encountered a "TYPE_CHECKING" not defined? I believe it is referenced in the typing.py file and because of the naming convention, the "from typing import *" has some error? I'm not too sure how to resolve the issue.

I would appreciate any help on the above two matters :)

Can you double-check your fmt and spdlog versions? I see fmt::v6.

It was on fmt version 6 yes. I removed and reinstalled using sudo apt-get install libfmt-dev. fmt version is now version 9.1.0 but the issue is still not resolved. Is there an email that I can liaise with on this?

Could you post the console output?

SymForce is not compatible with fmt 6 or fmt 9, we require fmt 8...<9 currently: https://github.com/symforce-org/symforce/blob/main/symforce/opt/CMakeLists.txt#L15
You should build a commit after https://github.com/symforce-org/symforce/commit/f9c21ade57bb920048867d3441efb257e0c7894c if you aren't doing that already (if you're building something after that, I'm confused how the build allowed you to attempt to use fmt 6 at all).  After that commit this should just work, and will use a compatible version of fmt if it's installed, and download it if not

I am currently on python 3.8.10.

I tried to build from source again after cloning the repo. I attempted cmake .. but the below is what I encounter
cmake ..
-- The C compiler identification is GNU 10.4.0
-- The CXX compiler identification is GNU 10.4.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Eigen found at /usr/share/eigen3/cmake
-- Catch2 not found, adding with FetchContent
-- Performing Test HAVE_FLAG__ffile_prefix_map__home_ckengjwe_dso_symforce_build__deps_catch2_src__
-- Performing Test HAVE_FLAG__ffile_prefix_map__home_ckengjwe_dso_symforce_build__deps_catch2_src__ - Success
CMake Error at /usr/local/lib/cmake/fmt/fmt-targets.cmake:95 (message):
The imported target "fmt::fmt" references the file
 "/usr/local/lib/libfmt.a"

but this file does not exist.  Possible reasons include:

The file was deleted, renamed, or moved to another location.

An install or uninstall procedure did not complete successfully.

The installation package was faulty and contained
"/usr/local/lib/cmake/fmt/fmt-targets.cmake"

but not all the files it references.
Call Stack (most recent call first):
/usr/local/lib/cmake/fmt/fmt-config.cmake:27 (include)
symforce/opt/CMakeLists.txt:15 (find_package)
-- Configuring incomplete, errors occurred!

This seems like you've previously installed fmt and removed it but left the old cmake files? Maybe the find_package is using the old FindFmt.cmake and it's looking for the wrong lib. Just a guess.

I managed rebuild somehow and am able to import cc_sym (I was not able to do that before). However, when I tried to compile (I'm not sure if I am doing it correctly) I got the below message:
Starting build...
/usr/bin/cpp -fdiagnostics-color=always -g /home/ckengjwe/dso/symforce/symforce/examples/robot_3d_localization/run_fixed_size.cc -o /home/ckengjwe/dso/symforce/symforce/examples/robot_3d_localization/run_fixed_size
In file included from /usr/local/include/spdlog/common.h:36,
from /usr/local/include/spdlog/spdlog.h:12,
from /home/ckengjwe/dso/symforce/symforce/examples/robot_3d_localization/run_fixed_size.cc:6:
/usr/local/include/spdlog/fmt/fmt.h:22:14: fatal error: spdlog/fmt/bundled/core.h: No such file or directory
22 | #    include <spdlog/fmt/bundled/core.h>
|              ^~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
Build finished with error(s).

The terminal process failed to launch (exit code: -1).
Terminal will be reused by tasks, press any key to close it.

It seems to be finding for core.h from /usr/local/include/spdlog but I have checked and core.h is in
/home/ckengjwe/dso/symforce/build/_deps/spdlog-src/include/spdlog
Somehow the fmt.h file they are using is also from /usr/local/include/spdlog/fmt since it is the default place to search? Is there a way to solve this?

Also in run_fixed_size.h header file, I am getting the below error message:
#include errors detected. Please update your includePath. Squiggles are disabled for this translation unit (/home/ckengjwe/dso/symforce/symforce/benchmarks/robot_3d_localization/robot_3d_localization_benchmark.cc).
and I got the below:

This seems like you have a slightly messed up environment. If you have fmt or spdlog installed system-wide, then find_package will find them first. It is difficult to help debug your build failure through GitHub issues. May I suggest you start a clean build from a clean environment? For example, you could either remove all system-wide installation of fmt/spdlog or you could do it in a conda environment.

When you run cmake you need to enable examples (which is ON by default)
cmake .. -DSYMFORCE_BUILD_EXAMPLES=On


Add an iSCSI target pod

This introduces a new image which can be used to create iSCSI targets backed up by persistent volumes.
In addition the target can seed a OS demo image (qemu demo image or alpine image).

The plan is to create a demo instance by default, once we have support for storage to boot VMs from.
Requires https://github.com/kubevirt/community/issues/6

retest please

@admiyo updated

retest this please

retest this please

:+1: just verified this, it works:
vm spec contains:
        "disks": [
          {
            "type": "network",
            "device": "disk",
            "driver": {
              "name": "qemu",
              "type": "raw"
            },
            "source": {
              "protocol": "iscsi",
              "name": "iqn.2017-01.io.kubevirt:sn.42/1",
              "host": {
                "name": "<IP_ADDRESS>",
                "port": "3260"
              }
            },
	    "target": {
              "dev": "vda"
	    }
          }
        ],

dumpxml contains:
    <disk type='network' device='disk'>
      <driver name='qemu' type='raw'/>
      <source protocol='iscsi' name='iqn.2017-01.io.kubevirt:sn.42/1'>
        <host name='<IP_ADDRESS>' port='3260'/>
      </source>
      <backingStore/>
      <target dev='vda' bus='virtio'/>
      <alias name='virtio-disk0'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/>
    </disk>

iSCSI target says:
Target 1: iqn.2017-01.io.kubevirt:sn.42
    System information:
        Driver: iscsi
        State: ready
    I_T nexus information:
        I_T nexus: 1
            Initiator: iqn.2008-11.org.linux-kvm:4a1b2b32-f956-11e6-a495-5254004d1b3b alias: none   <-- THIS IS QEMU
            Connection: 0
                IP Address: <IP_ADDRESS>

@fabiand Also consider using only CirrOS instead of alpine and the qemu image. It only has 12 MB and has dropbear ssh preconfigured with cirros:cubswin:). You can easily package that inside the container.

The image can be found here: http://download.cirros-cloud.net/0.3.5/cirros-0.3.5-x86_64-disk.img

This definitely needs a functional test before merge.

I'll add them in follow-up patches

Here a few things I would consider too:
Serve all three images always (e.g. on different luns)

Done

Then merge the two yamls into one

Wasn't possible (differnt purposes), but cleaned it up and more useful now.

Move this yaml into the manifests folder

Will do this in a follow-up patch

Make the pod restart behaviour more uniform (if the pod is backed by a persistent volume, always keep changes to all images, otherwise all are reset)

For simplicity the pod is now tuned towards the demo use-case. I fnecessary then we can still polish the persistent case.

Explicitly say that this is for testing only

Done

This definitely needs a functional test before merge.
I'll add them in follow-up patches

I would prefer to see this test here:
A functional test is there which attaches one of the disks to the VM and virt-handler reports the VM as up, I am fine with merging this.
Maybe also only use the CirrOS image (the smallest image which also contains SSH) and add it  to the container. Otherwise it is probably tricky to detect when the pod is really ready to serve the lun ....

Then merge the two yamls into one
Wasn't possible (differnt purposes), but cleaned it up and more useful now.

I guess I was not specific enough, because you exactly did what I had in mind (having one Pod spec at the end)

Move this yaml into the manifests folder
Will do this in a follow-up patch

Why?

For simplicity the pod is now tuned towards the demo use-case. I fnecessary then we can still polish the persistent case.

Correct me if I am wrong: The volumes are now always reset on a pod restart, right? Thats' good enough for me.
After the functional test is there, I am happy to merge it :+1:

This definitely needs a functional test before merge.
I'll add them in follow-up patches
I would prefer to see this test here:
A functional test is there which attaches one of the disks to the VM and virt-handler reports the VM as up, I am fine with merging this.

Yep, that's what I had in mind.
The patches up to now just add the target, without including it. The purpose of this patchset is to provide a working image. And that is achieved.
In a follow-up patch I'll integrate this working pod with the rest of the setup.
Once it is integrated then I have the ability to write an integration test for it.
That is why I provide the integration and test in a separate patch.

Maybe also only use the CirrOS image (the smallest image which also contains SSH) and add it to the container. Otherwise it is probably tricky to detect when the pod is really ready to serve the lun ....

As the images are now part of the docker images, the LUNs are ready whenever the pod is.

    Then merge the two yamls into one
    Wasn't possible (differnt purposes), but cleaned it up and more useful now.

I guess I was not specific enough, because you exactly did what I had in mind (having one Pod spec at the end)

Great :)

    Move this yaml into the manifests folder
    Will do this in a follow-up patch

Why?

See above.

For simplicity the pod is now tuned towards the demo use-case. I fnecessary then we can still polish the persistent case.

Correct me if I am wrong: The volumes are now always reset on a pod restart, right? Thats' good enough for me.

Yep. The images are tied to a container, thus reset on restart.

After the functional test is there, I am happy to merge it 👍

Great.

retest this please

retest this please

retest this please

retest this please

Now with the tests run locally.

retest this please

images/iscsi-demo-target-tgtd/README.md makes reference to a spec file named "iscsi-demo-target-tgtd.yaml" which does not appear to be present.

Merging even if jenkins failed (error:  no space left on device).
after all the last update was just a readme change, and the previous jenkins job passed.


jsx specs not working when upgraded to Sprockets 3.0

We just upgraded to Sprockets 3.0 and everything in our app seems to be working alright, but tests with the extension .js.jsx no longer work from the command line. Booting into the browser they run fine, but from CLI we just get the cryptic "Syntax error: parse error" from phantomjs and:
Finished in 0.00200 seconds
0 examples, 0 failures

Not sure if this is a teaspoon issue, but figured I'd start here. We're using react-rails which adds .js.jsx extensions to the asset pipeline.

We have our matcher configured as:
suite.matcher = 'spec/javascripts/**/*_spec.{js,js.jsx}'

@mockdeep thanks for reporting this bug. I'll try to spend some turkey time looking into it. Do you know if it's specific to .jxs extensions?

@mikepack Sorry, we only use .js and .jsx in our javascripts folder, so not sure if other extensions are a problem. We are using haml in our fixtures, and those seem to be fine.

The reason this is happening is because Teaspoon calls #logical_path on a sprockets asset in order to get a file URL that can be requested from the browser. We assume this returns a .js extension every time, but this is not the case with .js.jsx extensions, in which case it returns a .jsx extension.
This seems like it could be one of two things:

Teaspoon should not use #logical_path but I'm not currently aware of another way to determine the URL for a sprockets asset.
It's upstream in the react-rails asset pipeline integration and they need specify a .js extension for #logical_path.

@mikepack how are other extensions like .coffee handled?

It's mostly handled by sprockets. Sorry, I didn't provide a good resolution for the interim. If you're on Teaspoon 1.1.x, try setting this configuration:
config.suite do |suite|
  suite.js_extensions = [/(\.js)?.coffee/, /(\.js)?.es6/, ".es6.js", ".js.jsx"]
end

Thanks! At first blush it looks like that fixed it for me.

:+1:


crop and crop technology

I think both crop and crop_technology should be cleaned up more. For example, I don't think these belong to crop: yield, crop yield, stock, feed, hectare, seedling, produce.
@bsharpataz: can you please do a pass?

Removed some of the crops. Not sure how to clean up crop_technology ... should I remove it altogether ?

um... idk bc not an SME but maybe something like:
        - pesticide:
            - pesticide
        - harvest:
            - harvesting
 +          - post-harvest
 +          - harvest
        - planting:
          - tillage
          - planting
 +      - systems_sectors:
            - food system
 +          - farmer organization
 +          - department agriculture
 +          - aquaculture sector
            - farming system
 +          - agriculture organization
            - Peoples food system
            - investment agriculture
            - horticulture
            - farming
 +          - cultivation
        - fertility:
            - soil fertility
 +          - fertility

and that leaves
- food product
- rice production

to be fit in somewhere else...?

Makes sense!

On Apr 18, 2018, at 3:53 PM, bsharpataz<EMAIL_ADDRESS>wrote:
um... idk bc not an SME but maybe something like:
    - pesticide:
        - pesticide
    - harvest:
        - harvesting

     - post-harvest

     - harvest
 - planting:
   - tillage
   - planting

 - systems_sectors:
     - food system

     - farmer organization

     - department agriculture

     - aquaculture sector
     - farming system

     - agriculture organization
     - Peoples food system
     - investment agriculture
     - horticulture
     - farming

     - cultivation
 - fertility:
     - soil fertility

     - fertility

and that leaves

food product
rice production

to be fit in somewhere else...?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or mute the thread.

Will open a new pull request. Closing this. Will address the comments in a new set of pull requests...


Add a yield after adding web message listeners

Task/Issue URL: https://app.asana.com/0/488551667048375/1207278694825695/f
Description
Steps to test this PR
Feature 1

[ ]
[ ]

UI changes

Before
After

!(Upload before screenshot)
(Upload after screenshot)

#4529  👈
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CDRussell and the rest of your teammates on  Graphite


Fix for paths without devices

As per the documentation, allow for creating credentials for senders without a device.

Thanks!


use Newest vue-cli build project can't loader the  css style from the .vue file

the App.vue  can loader .but I write components and  import the component  into App.vue.
Visit the website the  is blank . But the App.vue  have style content !
why?

Please move this issue to vue-loader.

thanks


well formatted explanation of why we need linktime security

security is constantly an issue when developing software, especially when that software is used to develop other software (such as a programming language), while it is nearly impossible to fully prevent a malicious entity from causing harm, the ability to minimize that harm greatly protects people's privacy, security, and the reliability of their services.
Here is how a linker attack could work
let's say person A has project A1, this project is of course vale code, meaning that any externs it calls may likely contain C code, often dynamically linked C code, if person B then comes along and decides to set for example LD_PRELOAD to an alternative dynamic library then the C standard, they would then be able to invoke their own functions, that could call vale code, passing in either invalid values, or causing unexpected termination or corruption of data.
potential solutions discussed so far:

randomize vale function names at compile time
while this may work to prevent a know function name from being used to maliciously effect vale code, the C code that gets run could perform a backtrace to find the randomized function names.
ensure that any linked object is hashed by fountain so malicious code can't be inserted
completely statically link (binary size grows a lot, but would make distribution far easier)

i propose either option 3 or option 1 + backtrace disabled for release builds, and it couldn't hurt to for versioning purposes ate least, also maintain a hash of all linked against binaries, I shall make an issue in fountain for this purpose

Well said!
Talking out loud, for my own understanding: so this threat happens Vale project VProj has a dependency EvilC that uses some C code (and is therefore whitelisted in .toml), and the EvilC does something devious to call directly into Vale code. For example, if VProj and CThing both depended on AuthLib, EvilC could cause AuthLib to call back into itself (EvilC), and EvilC could read upwards in the stack, look for a specific AuthLib stack frame's reference to some global data, and modify it. Then, when VProj uses that same AuthLib function, it will be using the global data that EvilC corrupted.
Your proposal makes a lot of sense. Having #3 seems like a safe extra measure, and we can always lift that restriction later if our understanding of the benefits and risks change (or better yet, leave it up to the user).
For #1, we have an extra advantage too.
Some context: A separate threat is if the C code has an array on the stack, and then they do a buffer overrun, overwriting some references in a Vale stack frame, causing accidental memory unsafety, which we're trying to protect against. For this reason, I'm thinking we'll use a separate stack for C code, so they only risk accidentally overwriting non-Vale data. This would unfortunately require some platform-specific assembly in Midas, but seems wise. I haven't designed the specifics yet, I imagine some thread-locals might be involved.
That same mechanism could help against linker attacks; it would prevent them from looking upwards in the stack to find the Vale function addresses.


PR: Support for Binance RPC

@weboluchi I added some comments. The rest is good to me. Once you resolve them, I'll merge your PR

@weboluchi I added some comments. The rest is good to me. Once you resolve them, I'll merge your PR

I have implemented and resolved all comments. Thank you

I have effected these changes

Please check them once again. I see no changes in the PR.

LGTM 🚢

I have effected these changes

Please check them once again. I see no changes in the PR.

Thank you

LGTM 🚢

Ok, thank you

Lets shiiip it!


console proxy client sleep more generic

Description
This PR...

Fixes: #8692

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)
[ ] build/CI

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache @nvazquez , this is purely based on the description in #8692. Any advice on verification?

@blueorangutan package

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✖ el7 ✔ el8 ✖ el9 ✔ debian ✖ suse15. SL-JID 8747

Packaging result [LL]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6211

@blueorangutan test alma9 kvm-alma9

A couple questions, if you don't mind:

Would it make sense from a latency-perspective to only wait 1ms if there's actually no data coming in? If there's a big chunk of data coming in, you might not want to wait 1ms to read ~200 bytes (which appears to be the maximum the NIO readNextBytes method would return)
Why 1ms? Could we raise this to reduce wasted CPU cycles even more? My testing showed the CPU went from 100% to 25%. This might still seem a bit excessive.

A couple questions, if you don't mind:
1. Would it make sense from a latency-perspective to only wait 1ms if there's actually no data coming in? If there's a big chunk of data coming in, you might not want to wait 1ms to read ~200 bytes (which appears to be the maximum the NIO readNextBytes method would return)

2. Why 1ms? Could we raise this to reduce wasted CPU cycles even more? My testing showed the CPU went from 100% to 25%. This might still seem a bit excessive.

valid questions @kohrar , sounds like you are arguing for configurability. This is the simplest solution to the issue in your initial ticket. What you are asking now is a bigger (functional) change however. I would prefer to discuss and implement that separately.


Implementing capability caching

Based on this comment by @jonhoo on #243 this PR adds the ability for Client and Session to cache returned Capabilities.
Future work should try to parse (the optionally sent) Capabilities from untagged responses to EHLO, STARTTLS, and AUTHENTICATE automatically; if none are sent they should be automatically queried.

This change is

I think the last bit here now is https://github.com/jonhoo/rust-imap/pull/255#discussion_r1125573266

Hi @dequbed, I really liked that you were adding support for SASL in #243. Do you have any plans to update this PR? If you're short on time, I would be happy to help getting this (and that one) merged!


required zf version

The required version of zf2 is currently 2.3.
At the moemnt zf2 is at 2.5

module has been updated to utilise ZF 2.5


Some flavors of Markdown code blocks do not render correctly.

Describe the bug
Some flavors of markdown such as Quarto/RMarkdown add on some extra syntactic sugar onto code blocks. The Markdown treesitter parser actually handles them all correctly, so it would be nice if this plugin also supported some of these.

In general, yes. But reproducible with a completely clean environment with only markview.nvim installed.
To Reproduce
Steps to reproduce the behavior:

Install markview.nvim.
Open a markdown document.
Create a code block using one of the syntaxes above
See that it doesn't parse the language properly
Use :InspectTree and see that the language node and info_text nodes are parsed correctly indicating it's valid in the markdown parser

Expected behavior
It to parse nicely
Actual behavior
The language is unable to be parsed
Screenshots

Neovim version
0.10.1
Additional context
Just a simple start to this support could be simply updating the lua pattern that is matched here: https://github.com/OXY2DEV/markview.nvim/blob/main/lua/markview/parser.lua#L211
to "%s*```{*([^%s,}]*)"
With this change the above screenshot looks like this:

It would be nice if it replaced the entire info_string treesitter node rather than just the language text
which leaves the extra parameters dangling at the end, or some way to nicely format them (granted this isn't super necessary)

I will see what I can do


Update mockito-core to 3.11.1

Updates org.mockito:mockito-core from 3.8.0 to 3.11.1.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.mockito", artifactId = "mockito-core" } ]

labels: library-update, semver-minor

Superseded by #275.


Remove browse page from breadcrumbs

The browse index page at /browse currently displays a breadcrumb as “Home > Browse”, thereby linking back to itself. For consistency with breadcrumbs elsewhere on GOV.UK, this commit removes this link, so that the breadcrumb on the index page is simply “Home”.
The decision was taken not to display the breadcrumb as "Home > Browse" when a user clicks on a top-level browse page, because direct visits to the browse index page are very low and most users end up on browse pages from the GOV.UK home page, by clicking a link to go directly to a top level browse page. Therefore, the breadcrumb only changes once a user clicks on a second level browse page link.
Trello: https://trello.com/c/LCUGEogs/47-fix-breadcrumbs-on-browse-pages
With @jackscotti
Before:

After:

@rubenarakelyan is going to update the commit message with some backstory, why we made the choice to make https://www.gov.uk/browse & https://www.gov.uk/browse/births-deaths-marriages have the same breadcrumb.

@tijmenb: I've updated the commit and PR with a description of the reasoning behind not changing the breadcrumb for top level browse pages.


Error: Creating the captive portal failed

I'm trying to make this run on Armbian on an Orange Pi Zero. I used the Raspbian/Debian installation listed in the readme. It installs fine and runs but when it tries to create the access point it returns this:

Is there any way to make it work? Thank you.

@askovi I think this is probably due to a older NetworkManager. Can you please check the version with nmcli -v?

In my case, Problem was "dhcpcd.service".
I solved this problem by sudo systemctl disable dhcpcd.service and reboot.


Update to Swift 3.0

I'm currently starting a project with the VIPER design pattern. I found this ToDoList example really useful. For this reason I updated it to Swift 3.0.
All tests of the NSCalendar extension are still passing

Thank you for taking the time to do this.

I found 1 line that hadn't been updated, and was commented out, and have added a comment for it.
(NSCalendar+CalendarAdditions.swift Line 50)
Other than that, it builds, tests, and runs ok. Thanks for doing that for us!

@JeffGilbert-MM Can we merge this branch if we are done with swift 3 changes ?

It has been merged.


Create an ergonomic way to handle manual data

This issue is related to #52. As I user I wan to be able to add training information to the database, but in the future we might have similar scenarios. Ideally we can do this from the CLI or a better interface.

After a great discussion with @inigomarquinez, seems like the best approach will be to support the bulk introduction of changes from the input collected with the forms that @ruddermann is building.
We can work on a POC as soon as @ruddermann has a basic form.


Update urls-and-ip-address-ranges.md

Adding protocol information to the related topics -https://docs.microsoft.com/en-us/exchange/mailbox-migration/migrating-imap-mailboxes/setting-up-your-imap-server-connection#to-get-the-name-of-your-source-email-server-by-using-outlook-on-the-web

@JohanFreelancer9 Please copy review

Issue#https://github.com/MicrosoftDocs/microsoft-365-docs/issues/3770

@JoeDavies-MSFT  Please merge this PR. Thanks

@yogkumgit @msbemba I am closing this PR. The link you are adding is too specific for the endpoints article.

@yogkumgit @msbemba I am closing this PR. The link you are adding is too specific for the endpoints article.

I have created a New PR #https://github.com/MicrosoftDocs/microsoft-365-docs/pull/3925 with article information to the related topics section.

I have created a New PR #https://github.com/MicrosoftDocs/microsoft-365-docs/pull/3925 with article information to the related topics section.


Expose cookies as esm

Expose cookies esm build.
Added tsup, and config similar to other msw related libraries
Once this was done, there were some bundle related issues, since set-cookie-parser is only released as commonjs.
In order to support this, we bundle that library by moving it into devDependencies instead of declaring it as a dependency. By default, tsup treats all 'dependencies' as external in an esm build, so this is not necessarily standard, but works to ensure that this library is treated as esm compatible.

I'll take a look at ci here when I get some time (probably this weekend)

Huge thanks to you for this titanic work! 👏


broken googleapis.github.io/gax-php/ link found in API documentation

following the AsyncAnnotateFileRequest link under asyncBatchAnnotateFiles in ImageAnnotatorClient's API documentation leads to this 404

Thanks for the report @sirtorry! We actually have a fix for this in https://github.com/GoogleCloudPlatform/google-cloud-php/pull/1076, which should be merged soon.

@sirtorry just a heads up this was fixed in v0.68.0, new documentation should have the correct links.


Problem with F#-compiled binary and --in flag

With an F#-compiled binary (from make -C src or VS) and M.fst containing
(*--build-config
    options: --verify_module M;
    other-files: listTot.fst
--*)
module M

$ fstar M.fst
Verifying module: M
All verification conditions discharged successfully

$ echo -e "#push\n`cat M.fst`\n#end" | fstar.exe --in
listTot.fst(196,45-196,48) : Error
Identifier not found: [fst] (Possible clash with related name at prims.fst(513,0-513,29))

With an OCaml-compiled binary (from make -C src/ocaml-output) the latter succeeds, as expected.

same problem here

I believe this is not a problem anymore. Can someone please confirm before I close ?

I confirm this can be closed.
The issue has become moot because build-config blocks are no longer interpreted.
Regardless, I tried reproducing this using the command-line and interactive modes and they both consistently report the same error, as expected.


Support for file IO?

asio supports io_uring.
It's great if libcoro support async file IO (io_uring on Linux, IOCP on Windows etc.), so that read/write yield thread to another coroutine.

I'm not that familiar with io_uring yet, it seems quite promising but this is definitely a larger task to either:
(a) replace epoll with io_uring -- this solution would mandate a minimum kernel version probably
(b) support both epoll and io_uring - I'm not particularly interested in this approach, I'd rather keep the code simple, I imagine there would be subtle bugs between the two kernel apis and would require a lot of testing and effort to maintain both

Another option might be to have a background thread pool which blocks on the file io requests while maintaining epoll.


build docker multi-architecture

make things work for m1

Codecov Report

Merging #61 (94acc85) into main (c8e2636) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main      #61   +/-   ##
=========================================
  Coverage     11.90%   11.90%
  Complexity       35       35
=========================================
  Files            65       65
  Lines          3326     3326
  Branches        356      356
=========================================
  Hits            396      396
  Misses         2874     2874
  Partials         56       56

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8e2636...94acc85. Read the comment docs.


Bug: Group by path in Libraries is missing path name

Description
It seems to be a problem for the visualisation of the path in libraries when the visualisation is "group by path"
Cf screenshot.
Sorry for my english from France ;-)
Steps To Reproduce
Add local path and unc path to a library
Group by path for the visualisation of the library
Expected behavior
The last folder level should appear in front of the path
Files Version
<IP_ADDRESS>
Windows Version
Édition	Windows 11 Professionnel Version	21H2 Installé le	02/11/2021 Build du système d’exploitation	22000.469 Expérience	Pack d’expérience de fonctionnalités Windows 1000.22000.469.0
Relevant Assets/Logs

Hello, I am Nilüfer Ballı, a 4th year computer engineering student. As part of the software engineering course project, we were asked to do a bug fix on github, if you allow me, I would like to solve this error too.

@nilufer001 did you manage to find a fix?

@nilufer001 sorry for the long delay (just noticed your comment now), are you still interesting in working on this?

Hi. I'm new to contributions. If no one else is working on this I'd like to try. May I?

Yes you can. Make sure to refer to the code guidelines https://files.community/docs/contributing/code-style and open a PR when ready.

Yes you can. Make sure to refer to the code guidelines https://files.community/docs/contributing/code-style and open a PR linking this issue when ready.

Thank you. I just cloned the repo with all the dependencies. I have a question. How do I make a library?

Right click the sidebar > Enable libraries there should be ones from Windows there.

Right click the sidebar > Enable libraries there should be ones from Windows there.

Thank you. Managed to create a custom library but adding a shortcut asks for administrative privileges. How do I overcome that?


ci: always run cargo install cargo-audit

cargo already handles cache if there is one.
This closes #188.
Signed-off-by: tison<EMAIL_ADDRESS>Verified

cache miss: https://github.com/tisonkun/engula/runs/4541804122?check_suite_focus=true
cache hit: https://github.com/tisonkun/engula/runs/4541832408?check_suite_focus=true

cc @mati865 @huachaohuang


How do I create an migration?

I have been trying different things and nothing works. I added a simple domain object
PS C:\Users\punko\Downloads\PoClean\src\Migrators> cd migrators.sqlite
PS C:\Users\punko\Downloads\PoClean\src\Migrators\migrators.sqlite> dotnet ef migrations add NewMigration --project PoClean.Migrators.MSSQL
MSBUILD : error MSB1009: Project file does not exist.
Switch: C:\Users\punko\Downloads\PoClean\src\Migrators\migrators.sqlite\PoClean.Migrators.MSSQL
Unable to retrieve project metadata. Ensure it's an SDK-style project. If you're using a custom BaseIntermediateOutputPath or MSBuildProjectExtensionsPath values, Use the --msbuildprojectextensionspath option.
PS C:\Users\punko\Downloads\PoClean\src\Migrators\migrators.sqlite>

I suggest you look at the documentation of EF

Hello @punkouter24,
Take a look at #433. There I answer the same question with a detailed example.
Kind regards,
Bram

ok the add-migration works... still can't get the scaffold extension to work though

I'm trying Migrators.MSSQL but it still doesn't work when creating, can someone describe it to me?


fix: Updating the Blog url to /blog

Changing the blog url in the footer from blog.zopa.com to zopa.com/blog

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

:tada: This PR is included in version 4.40.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Outline view removes object context from function names in Javascript

Issue Type: Bug
. Create a javascript file with the following contents:
const MyObject = {};
const MyObject.MySubObject = {};
MyObject.MySubObject.myFunction = function(args) {}

Look at the outline, it shows myFunction. In the previous version it showed MyObject.MySubObject.myFunction. I am missing this context information, especially in larger script files where  function names might contain duplicates.

VS Code version: Code 1.24.0 (6a6e02cef0f2122ee1469765b704faf5d0e0d859, 2018-06-06T17:37:01.579Z)
OS version: Linux x64 4.15.0-22-generic

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz (8 x 2525)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: disabled_softwarevideo_decode: unavailable_softwarevideo_encode: enabledvpx_decode: unavailable_softwarewebgl: enabledwebgl2: enabled

Load (avg)
1, 1, 1

Memory (System)
15.49GB (7.71GB free)

Process Argv
/usr/share/code/code --disable-extensions

Screen Reader
no

VM
0%

Extensions disabled

In the previous version it showed MyObject.MySubObject.myFunction.

Do you mean in the quick outline? Can you attach a screen shot of that?


Import a smart contract into the NextJS UI project scaffold

Addresses
#280 #291
This PR adds the the template Add smart contract into the index file of the UI when NextJs is selected as the UI framework in the CLI. Smart contract integrations with Svelte and Nuxt will each follow in separate PRs.

Tested the changes and it all checks out, thanks Yoni! :D Approving
Just want to request that we should add a log statement in the console when the error is thrown related to SnarkyJS and empty keys. When booting Next up, it's a little unfriendly to get an unexplained error message so something directly in the browser will go a long way.

Good suggestions!


Difficult to add a name in another language

When I add or edit an element, the languages suggested to me are English and Zulu (in South Africa).
However if I want to add another language I have to search for it after tapping the globe icon. This list is maybe in order of most common languages, but not for my region so it's very hard to find the right one (there's no option to sort alphabetically either).
If I go to add the tag directly then when I type name:st it tries to autocomplete it, giving me two wrong options. I can't advance to the value box without it changing the key to name:statcan_rbuid.
Suggested solutions

Show the languages of the current country at the top
Sort the languages to somehow prefer languages of the current region (possibly region smaller than country)
Allow sorting the languages alphabetically
Make it possible to add a key without autocompleting it

Another suggested solution:

Add a keyboard input / search bar to the language picker, so that the flow for uncommon languages becomes:

tap the globe icon
enter a few characters of the language name or abbreviation (e.g. st)
pick the right result from the filtered list

Added a search bar in 4.0.


Design System > Elements > Enhancements in file uploader

Design System > Elements > Enhancements in file uploader
https://www.figma.com/design/vziFLZAgMFi8wA5SlikLh5/Raaghu-Design-System?node-id=447-844&node-type=canvas&m=dev
Docs	1] File Uploader development different than design
Default	2] Design should be same as wiframe
3] Four Types of file uploader

Updated the file uploader as per the wireframe:
1)Drop Area - Top Icon
2)Drop Area - Side Icon
3)Drop Area - With Upload Button
Modified the basic file uploader layout since there is no delete option for the selected file.
Assigned this task to Rahul Patil for making color variant changes.

Updated the app shell with 5 new layouts based on the wireframe:
1)Relaxing
2)Top Nav
3)Side Nav
4)Double Nav
5)Left and Right Nav
Additionally, modified the existing basic layout to align with the wireframe and implemented functionality changes.
Assigned this task to Rahul Patil to address responsiveness for the views and fix the dropdown issue in the TopNav layout.

Updated the file uploader as per the wireframe:
1)Drop Area - Top Icon
2)Drop Area - Side Icon
3)Drop Area - With Upload Button
Modified the basic file uploader layout since there is no delete option for the selected file.
Assigned this task to Rahul Patil for making color variant changes.

Closing this task based on Rahul Patil's conversation added a missing point to #962 task.

This bug has dependency on 962 and 1090 , so making it blocked

Fixed on stage

Fixed on stage


Would mmdet support OTA (CVPR2021 paper)?

Describe the feature
Add the code support for OTA (CVPR2021 paper)
Motivation
A clear and concise description of the motivation of the feature.
Ex1. It is inconvenient when [....].
Ex2. There is a recent paper [....], which is very helpful for [....].
The idea behind the paper “OTA: Optimal Transport Assignment for Object Detection” is very interested in object detection.
It can be expected that there will be many methods based on this paper in the future.
So I think mmdet should support this algorithm, so that it can be more convenient for comparison in the future.
Related resources
https://github.com/Megvii-BaseDetection/OTA
Additional context

@4-0-4-notfound There is no plan for the time being, but community PR is welcome.

For now, we support SimOTA used in YOLOX, a simpler and faster version of OTA, you might want to try that.


Multi-server prest

I am executing sql query scripts using prest.
The challenge I have is that I have to run the same query scripts across different databases.
Right now it requires me to spawn a separate server with the toml config pointing to a given database. I am wondering if we can build in the ability to specify the database I want to query in the GET request for executing sql scripts.

cc @fabriziomello  and @sebastianwebber

Hi @kafka-tamura how are you?
Its possible to map your remote tables using posgtres_fdw1?
We can think a way to handle multiple connections in different databases, but the easy way to map the remote tables in the same database as pRest runs.
Please share more details about your environment.
References:

https://www.postgresql.org/docs/current/static/postgres-fdw.html

@sebastianwebber I am good. How are you?
Thanks for the fdw tip. Let me see if I can make that work.

@sebastianwebber,
postgres_fdw could work but it is complicating my application logic because I need to handle schema changes - which is not trivial for my use-case. Plus it is not idiomatic to our application architecture and is going to make maintaining the application difficult. I am settling for multiple prest servers each pointing to the database.


Request for a release

Hello,
I would like to request the submission of a release for the pp project to the opam repository. I'd like to use the couple new helpers that were added, plus it's been a little while since the last release.
Thanks!

Do you want to do the honours? I added you as a maintainer.

Yes! Thank you for appointing me as a maintainer.
Looking back at the unreleased changes, I see #17 which is a breaking change. Does it warrant a major semver increase? In theory I would say yes (a.k.a. releasing pp.2.0.0). That being said I looked via sherlocode, and didn't find a match for the Pp.of_fmt, outside of the test for this library. https://sherlocode.com/?q=Pp.of_fmt
For commits that prepare the changelog, do maintainers push directly to the main branch, or is it better to go via a PR as well?

Looking back at the unreleased changes, I see https://github.com/ocaml-dune/pp/pull/17 which is a breaking change. Does it warrant a major semver increase? In theory I would say yes (a.k.a. releasing pp.2.0.0). That being said I looked via sherlocode, and didn't find a match for the Pp.of_fmt, outside of the test for this library. sherlocode.com?q=Pp.of_fmt

Both are acceptable to me. Pp.of_fmt was not very useful in hindsight as it breaks the purpose of this library which is serialization.

For commits that prepare the changelog, do maintainers push directly to the main branch, or is it better to go via a PR as well?

Whatever you prefer.

Pp.of_fmt was not very useful in hindsight as it breaks the purpose of this library which is serialization.

So far I've used pp in a spirit that matches what the introductory paragraph says in the home page's README, and didn't think about serialization. I'm curious - does Dune use Pp to send errors to ocaml-lsp? Are there other use cases?
I'm inclined to name the release 2.0.0. The focus on serialization could be considered a minor change to the original project motivation, hereby dropping the (unused says sherlocode) Pp.of_fmt feature of "making it easier to migrate code from using Format to using Pp". That sounds fine to me.
I'm going to be on and off the next few days, so I might not get to it right away, but please consider it on my stack and I will get this release done. Thanks!

I'm curious - does Dune use Pp to send errors to ocaml-lsp? Are there other use cases?

Yes, it was introduced exactly for this purpose. No other use cases as far so far as I'm aware. We also introduced a combinator based API because of the general dislike for format strings.

I'm inclined to name the release 2.0.0. The focus on serialization could be considered a minor change to the original project motivation, hereby dropping the (unused says sherlocode) Pp.of_fmt feature of "making it easier to migrate code from using Format to using Pp". That sounds fine to me.

That's OK.

I'm going to be on and off the next few days, so I might not get to it right away, but please consider it on my stack and I will get this release done. Thanks!

Roger.

Merged https://github.com/ocaml/opam-repository/pull/26570


csg_boltzmann: has gromacs units hard-codes

Gromacs units are hard-codes for the Boltzmann inversion of potentials.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 21 Jan 2014 at 4:20

How do I look at the original report?

Not possible as Google Code is gone, but usually all information gets ported.

So do you know what the exact issue is. Is the problem that we support different input files with no way of checking what units are being used when they are read in?

I think the problem basically it that csg_boltzmann assumes Gromacs' units, which isn't a huge problem for e.g. the unit of length as input und output unit are usually the same. However for the energy units this is a pain, so maybe instead of setting the temperature, we should request setting kB*T in the same way as we do in csg_inverse.

I see


[feat] Builtin state mutablity support

Describe the problem
By default, once a state is managed it can't be mutated any more.
As for now, it need us to write some boilerplate code to wrap the state inside a Mutex or a RwLock.
Describe the solution you'd like
Allows users to mutate their state directly, for example:
pub struct MyState(pub u32);

app.manage(MyState(0));
let state = app.state().as_ref();
assert!(state.0 == 0);

app.manage(MyState(state.0 + 1));
assert!(app.state().as_ref().0 == 1);

Alternatives considered
pub trait State: Send + Sync + 'static {}
pub struct StateWrapper<T: State>(RwLock<T>);

pub trait AppExt {
    fn with_app_state<T: State, R>(&self, closure: impl FnOnce(&T) -> R) -> R;
    fn set_app_state<T: State>(&self, state: T);
}

impl<M: tauri::Manager<Runtime>> AppExt for M {
    fn with_app_state<T: State, R>(&self, closure: impl FnOnce(&T) -> R) -> R {
        let wrapper = self.state::<StateWrapper<T>>();
        let state = wrapper.deref().0.read().unwrap();
        closure(state.deref())
    }

    fn set_app_state<T: State>(&self, state: T) {
        if let Some(wrapper) = self.try_state::<StateWrapper<T>>() {
            *wrapper.deref().0.write().unwrap() = state;
        } else {
            self.manage(StateWrapper(RwLock::new(state)));
        }
    }
}

Additional context
No response

I don't think we will add this inside tauri as state needs to be shared across threads and interior mutability can be done in so many different ways and so I think the alternatives you proposed is enough.


Upload Library to Pypi.

This should be available via pypi.
Without an easy dependency option, I would have just lifted the needed code but, it's a bit of a labyrinth in that needed functions are found bouncing around init files etc. Needs to be easier than just writing the functions myself.

You can vendor the code until it's uploaded, just download it and put it in a subfolder of your project. If you don't plan on publishing your project to PyPI yourself, you can alos install it as a Git dependency, with pip or Poetry.

I am sorry, but I have never intended for this package to be uploaded to PyPI. It is a creation of curiosity, without any regard to decent user interfaces and it never got past "work in progress" status. It contains a lot of dubious design decisions, non-optimized code, possibly erroneous code and is generally not something I would upload to PyPI and consider maintaining.
But as said, it should be possible to install directly from the GitHub repo:
pip install git+https://github.com/hbldh/hitherdither.git#egg=hitherdither

I have not tried this myself with this package, but I think it should work.

Yeah, I was hoping for a, maybe slower, easier couple functions. My project is uploaded to pypi but I can't really upload this without taking the namespace and having it registered under my username. Maybe there's way to add version uploading rights but I'm not sure.
Just adding it as a folder would work, though it's seemingly a lot of files for something I'd expect one file implement and I'm not a big fan of functions hiding places like init files. My need for other dithering isn't pressing, but it would be nice to offer them.
It does seem like a bit more streamlined api and fewer randomish files and it would be rather sleek, drop in code which is more what I was looking for.

I would expect to be able import a dither function or a function that accepts a type of dither and have a single drop-in file that would implement that stuff (even non-optimized) and have it do the work. PyDither (https://github.com/Utkarsh-Deshmukh/image-dithering-python) is about right for the API but the imports are cv2 which is basically a non-starter.
I might have to code something up from scratch, I don't really need anything other than a few basic dithers to 1 bit. But, this looks pretty nice and might be worth sprucing up.


[SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

What changes were proposed in this pull request?

At CreateTableLikeCommand, we use the new tblproperties with merge source tblproperties.
Why are the changes needed?

We should retain the useful tblproperties,  e.g. parquet.compression. And hive also retain the tblproperties.
Does this PR introduce any user-facing change?

No.
How was this patch tested?

Add UT.

Test build #123155 has started for PR 28647 at commit 37ba3b3.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27785/
Test PASSed.

One point.
Hive only retain the useful properties through serde class annotation.
Should we remove the properties like transient_lastDdlTime simply?
Or follow the hive process ?
cc @cloud-fan

Test build #123155 has finished for PR 28647 at commit 37ba3b3.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123155/
Test FAILed.

In HiveDDLSuite, exists the code
    assert(targetTable.properties.filterKeys(!metastoreGeneratedProperties.contains(_)).isEmpty,
      "the table properties of source tables should not be copied in the created table")

If use this behavior, we should change the test code.

let's update the doc of CreateTableLikeCommand to make it clear that we copy table properties as well.

I see the enum properties key in HiveDDLSuite.
val metastoreGeneratedProperties = Seq(
      "CreateTime",
      "transient_lastDdlTime",
      "grantTime",
      "lastUpdateTime",
      "last_modified_by",
      "last_modified_time",
      "Owner:",
      "totalNumberFiles",
      "maxFileSize",
      "minFileSize"
    )

Shall we copy the tblproperties without these?

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27877/
Test PASSed.

Test build #123255 has started for PR 28647 at commit b30d62c.

Could you update the SQL doc for the behaivour, too? https://github.com/apache/spark/blame/master/docs/sql-ref-syntax-ddl-create-table-like.md

Test build #123256 has started for PR 28647 at commit 162627a.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27878/
Test PASSed.

Test build #123257 has started for PR 28647 at commit 9eacf1e.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27879/
Test PASSed.

Test build #123255 has finished for PR 28647 at commit b30d62c.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123255/
Test FAILed.

Test build #123256 has finished for PR 28647 at commit 162627a.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123256/
Test FAILed.

Test build #123257 has finished for PR 28647 at commit 9eacf1e.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123257/
Test FAILed.

Test build #123272 has started for PR 28647 at commit 175d0e2.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27894/
Test PASSed.

Test build #123272 has finished for PR 28647 at commit 175d0e2.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123272/
Test FAILed.

Test build #123291 has finished for PR 28647 at commit ed0877e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123291/
Test PASSed.

cc @cloud-fan @viirya @maropu

Test build #123311 has started for PR 28647 at commit 4507e7f.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27933/
Test PASSed.

Test build #123311 has finished for PR 28647 at commit 4507e7f.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123311/
Test FAILed.

@maropu  please help test, thanks.

retest this please

Test build #123314 has started for PR 28647 at commit 4507e7f.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27936/
Test PASSed.

Test build #123314 has finished for PR 28647 at commit 4507e7f.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123314/
Test FAILed.

Test build #123318 has started for PR 28647 at commit bc52948.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27940/
Test PASSed.

Test build #123318 has finished for PR 28647 at commit bc52948.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123318/
Test FAILed.

Test build #123323 has started for PR 28647 at commit 6b523e1.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27945/
Test PASSed.

Test build #123323 has finished for PR 28647 at commit 6b523e1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123323/
Test PASSed.

Looks fine except for one comment.

Test build #123355 has started for PR 28647 at commit 46d7a7b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27976/
Test PASSed.

Test build #123355 has finished for PR 28647 at commit 46d7a7b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123355/
Test PASSed.

Test build #124441 has started for PR 28647 at commit 78ff34f.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/29060/
Test PASSed.

Test build #124441 has finished for PR 28647 at commit 78ff34f.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124441/
Test FAILed.

Seems we only support the v1 catalog for CreateTableLike, don't need check  reserved properties in TableCatalog.
BTW there is a work with CreateTableLike for v2 catalog. SPARK-29563

Test build #124466 has started for PR 28647 at commit 2251181.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/29085/
Test PASSed.

Test build #124466 has finished for PR 28647 at commit 2251181.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124466/
Test FAILed.

@ulysses-you I have a question. Per the syntax the source file format, row format can be different than the target. Say source format was parquet and target is orc, can we copy the parquet specific table properties to the target table ? Like in the pr description we have specified "parquet.compression".  Could this be the reason why we didn't copy these properties before ?

It's a trade-off. In normal copy the redundant properties is little harmful to new table, but not do copy could make a bug. In parquet table case, a source table is compressed with table properties parquet.compression then new table should also have the properties. Otherwise the new table is not compressed.

@ulysses-you Thanks. Do we know the behavior of hive for this case i.e parquet to orc or vice versa ?

Hive use it's own way to copy properties, all useful properties which need to copy are declared at serde class annotation so that Hive needn't copy redundant properties.

Thanks @ulysses-you .
cc @cloud-fan @viirya @maropu - Should we be more restrictive here and only copy properties if target and source format and serde match up ? or its okay as is ?

cc @cloud-fan @viirya @maropu - Should we be more restrictive here and only copy properties if target and source format and serde match up ? or its okay as is ?

Ah, I see. I think the properties are only meaningful if the format is the same with each other. So, IMHO its okay to copy them only if the format is the same.

Test build #124581 has started for PR 28647 at commit 5c63477.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/29202/
Test PASSed.

Test build #124582 has started for PR 28647 at commit 183c209.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/29204/
Test PASSed.

Test build #124581 has finished for PR 28647 at commit 5c63477.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124581/
Test FAILed.

Test build #124582 has finished for PR 28647 at commit 183c209.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124582/
Test FAILed.

Should we be more restrictive here and only copy properties if target and source format and serde match up ?

good idea! +1

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/29253/
Test PASSed.

Test build #124635 has started for PR 28647 at commit 183c209.

Test build #124635 has finished for PR 28647 at commit 183c209.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124635/
Test PASSed.

Changes look good to me.

Test build #124673 has started for PR 28647 at commit fcc8b3b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/29289/
Test PASSed.

Test build #124673 has finished for PR 28647 at commit fcc8b3b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124673/
Test FAILed.

retest this please

Test build #124686 has started for PR 28647 at commit fcc8b3b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/29299/
Test PASSed.

Test build #124686 has finished for PR 28647 at commit fcc8b3b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124686/
Test FAILed.

Test build #124710 has started for PR 28647 at commit 006ec47.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/29321/
Test PASSed.

Can you address the comment https://github.com/apache/spark/pull/28647/files#r446789203 too?

Test build #124710 has finished for PR 28647 at commit 006ec47.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124710/
Test FAILed.

Can you address the comment https://github.com/apache/spark/pull/28647/files#r446789203 too?

Sorry for missed this, I will check it later.

Test build #124739 has started for PR 28647 at commit 7f9f685.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/29351/
Test PASSed.

Test build #124739 has finished for PR 28647 at commit 7f9f685.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124739/
Test FAILed.

Test build #124764 has started for PR 28647 at commit 0a3b1cf.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/29376/
Test PASSed.

Test build #124764 has finished for PR 28647 at commit 0a3b1cf.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124764/
Test FAILed.

Test build #124836 has started for PR 28647 at commit 1e1349f.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/29444/
Test PASSed.

Test build #124836 has finished for PR 28647 at commit 1e1349f.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124836/
Test FAILed.

retest this please

Test build #124906 has started for PR 28647 at commit 1e1349f.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/29512/
Test PASSed.

Test build #124906 has finished for PR 28647 at commit 1e1349f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124906/
Test PASSed.

Test build #125274 has started for PR 28647 at commit 19f398b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/29884/
Test PASSed.

Test build #125274 has finished for PR 28647 at commit 19f398b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125274/
Test FAILed.

Test build #125525 has started for PR 28647 at commit 03966ae.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/30140/
Test PASSed.

Test build #125525 has finished for PR 28647 at commit 03966ae.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125525/
Test FAILed.

I believe this is useful, can we revisit PR ? cc @maropu @cloud-fan @viirya @dilipbiswal

This is reopened to the author (@ulysses-you )'s request.

@ulysses-you . Please rebase your PR regularly to the master to avoid STALE label.

Test build #130531 has started for PR 28647 at commit 03966ae.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35131/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35131/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35131/
Test PASSed.

Test build #130531 has finished for PR 28647 at commit 03966ae.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130531/
Test PASSed.

thank you @dongjoon-hyun

Test build #130535 has started for PR 28647 at commit dc00260.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35135/

Test build #130535 has finished for PR 28647 at commit dc00260.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130535/
Test FAILed.

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35135/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35135/
Test PASSed.

Test build #130760 has started for PR 28647 at commit 2d470fc.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35369/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35369/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35369/
Test PASSed.

Test build #130760 has finished for PR 28647 at commit 2d470fc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130760/
Test PASSed.

cc @maropu @cloud-fan @viirya do you have time to review this thanks !

Test build #131201 has started for PR 28647 at commit 4b55575.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35804/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35804/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35804/
Test PASSed.

Test build #131201 has finished for PR 28647 at commit 4b55575.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds the following public classes (experimental):
 public static class NoOpMergedShuffleFileManager implements MergedShuffleFileManager
public class RemoteBlockPushResolver implements MergedShuffleFileManager
 static class PushBlockStreamCallback implements StreamCallbackWithID
 public static class AppShuffleId
 public static class AppShufflePartitionInfo
trait HasMaxBlockSizeInMB extends Params
    >>> class VectorAccumulatorParam(AccumulatorParam):
            fully qualified classname of key Writable class (e.g. \"org.apache.hadoop.io.Text\")
            fully qualified classname of key Writable class (e.g. \"org.apache.hadoop.io.Text\")
            fully qualified classname of key Writable class (e.g. \"org.apache.hadoop.io.Text\")
            fully qualified classname of key Writable class (e.g. \"org.apache.hadoop.io.Text\")
class HasMaxBlockSizeInMB(Params):
trait SQLConfHelper
class Analyzer(override val catalogManager: CatalogManager)
case class UnresolvedTableOrView(
case class UnresolvedPartitionSpec(
case class ResolvedPartitionSpec(
case class ElementAt(
case class GetArrayItem(
case class GetMapValue(
case class Elt(
trait OffsetWindowFunction extends WindowFunction
class AstBuilder extends SqlBaseBaseVisitor[AnyRef] with SQLConfHelper with Logging
abstract class AbstractSqlParser extends ParserInterface with SQLConfHelper with Logging
class CatalystSqlParser extends AbstractSqlParser
case class AnalyzeTable(
case class AnalyzeColumn(
case class AlterTableAddPartition(
case class AlterTableDropPartition(
case class LoadData(
case class ShowCreateTable(child: LogicalPlan, asSerde: Boolean = false) extends Command
abstract class Rule[TreeType <: TreeNode[_]] extends SQLConfHelper with Logging
 implicit class PartitionSpecsHelper(partSpecs: Seq[PartitionSpec])
class SparkPlanner(val session: SparkSession, val experimentalMethods: ExperimentalMethods)
class SparkSqlParser extends AbstractSqlParser
class SparkSqlAstBuilder extends AstBuilder
case class CoalesceShufflePartitions(session: SparkSession) extends Rule[SparkPlan]
class FindDataSourceTable(sparkSession: SparkSession) extends Rule[LogicalPlan]
class FallBackFileSourceV2(sparkSession: SparkSession) extends Rule[LogicalPlan]
class ResolveSQLOnFile(sparkSession: SparkSession) extends Rule[LogicalPlan]
case class PreprocessTableCreation(sparkSession: SparkSession) extends Rule[LogicalPlan]
case class AlterTableAddPartitionExec(
case class AlterTableDropPartitionExec(
case class DropTableExec(
class V2SessionCatalog(catalog: SessionCatalog)
case class PlanDynamicPruningFilters(sparkSession: SparkSession)
  class HDFSBackedReadStateStore(val version: Long, map: MapType)
trait ReadStateStore
trait StateStore extends ReadStateStore
class WrappedReadStateStore(store: StateStore) extends ReadStateStore
abstract class BaseStateStoreRDD[T: ClassTag, U: ClassTag](
class ReadStateStoreRDD[T: ClassTag, U: ClassTag](
case class PlanSubqueries(sparkSession: SparkSession) extends Rule[SparkPlan]
class VariableSubstitution extends SQLConfHelper
abstract class JdbcDialect extends Serializable with Logging
class ResolveHiveSerdeTable(session: SparkSession) extends Rule[LogicalPlan]
class DetermineTableStats(session: SparkSession) extends Rule[LogicalPlan]

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131201/
Test FAILed.

Test build #131644 has started for PR 28647 at commit c45489a.

Test build #131644 has finished for PR 28647 at commit c45489a.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class ExecutorSource(
  case class GetShufflePushMergerLocations(numMergersNeeded: Int, hostsToFilter: Set[String])
  case class RemoveShufflePushMergerLocation(host: String) extends ToBlockManagerMaster
case class UnresolvedTable(
class SubExprEvaluationRuntime(cacheMaxEntries: Int)
case class ExpressionProxy(
case class ResultProxy(result: Any)
case class CurrentTimeZone() extends LeafExpression with Unevaluable
abstract class LikeAllBase extends UnaryExpression with ImplicitCastInputTypes with NullIntolerant
case class LikeAll(child: Expression, patterns: Seq[UTF8String]) extends LikeAllBase
case class NotLikeAll(child: Expression, patterns: Seq[UTF8String]) extends LikeAllBase
case class ParseUrl(children: Seq[Expression], failOnError: Boolean = SQLConf.get.ansiEnabled)
 implicit class MetadataColumnsHelper(metadata: Array[MetadataColumn])
trait PathFilterStrategy extends Serializable
trait StrategyBuilder
class PathGlobFilter(filePatten: String) extends PathFilterStrategy
abstract class ModifiedDateFilter extends PathFilterStrategy
class ModifiedBeforeFilter(thresholdTime: Long, val timeZoneId: String)
class ModifiedAfterFilter(thresholdTime: Long, val timeZoneId: String)

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131644/

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36245/


add unique id and for to use in form field template

uh this seems like a lot of files I didn't change, should I be committing all of this?
@incuna/frontend

Could you add coverage to .gitignore ? Then these files will disappear

@wytrych done

how often is this updated? Should I release when this is merged?

Not often enough :) Yes it's good to release

thanks :)


Feature request: Analyzer option to keep tokens that could not be transformed

Currently, it looks like unicode characters that cannot be transformed (e.g. by lowercasing or removing accents) are removed when tokenising a string.
It would be handy if there was an analyzer option which allowed these tokens to be preserved instead.
For example, the following AQL:
RETURN TOKENS("㊈ ㊉ ㊊ ㊋ ㊌ ㊍ ㊎ Ḁ ḁ Ḃ ḃ Ḅ ḅ Ḇ ḇ", "text_en")

returns:
["a", "a", "b", "b", "b", "b", "b", "b"]

It would be useful if it was possible to configure an analyzer to return:
["㊈", "㊉", "㊊", "㊋", "㊌", "㊍", "㊎", "a", "a", "b", "b", "b", "b", "b", "b"]

@davechallis is this on 3.5.0?

@aveiros that's right, I've been testing new search view features in 3.5 RC7.

@davechallis consider using delimiter analyzer
<IP_ADDRESS>:8529@_system> a.save('delim', 'delimiter', { delimiter: ' ' })
{
  "name" : "_system::delim",
  "type" : "delimiter",
  "properties" : {
    "delimiter" : " "
  },
  "features" : [ ]
}

<IP_ADDRESS>:8529@_system> db._query("RETURN TOKENS('㊈ ㊉ ㊊ ㊋ ㊌ ㊍ ㊎ Ḁ ḁ Ḃ ḃ Ḅ ḅ Ḇ ḇ', 'delim')")
[object ArangoQueryCursor, count: 1, cached: false, hasMore: false]

[
  [
    "㊈",
    "㊉",
    "㊊",
    "㊋",
    "㊌",
    "㊍",
    "㊎",
    "Ḁ",
    "ḁ",
    "Ḃ",
    "ḃ",
    "Ḅ",
    "ḅ",
    "Ḇ",
    "ḇ"
  ]
]

@gnusi thanks, will take a look into that next week and see if it does the trick.

Hi @davechallis,
Did you have a chance to test the delimiter analyzer?

Hi @maxkernbach,
Sorry, forgot to report back on this.
Unfortunately it doesn't quite solve the issue I was having - ideally I wanted to have the benefits of lowercase and accent removal, but without removing/replacing characters for which there's no replacement.
E.g. given the input:
RETURN TOKENS('foo ba㊌r BÉZ', 'text_en')

I was trying to build an analyzer which would return:
[
    "foo",
    "ba㊌r",
    "bez"
]

Currently (with text_en) this lowercases and removes accents on "bez", but breaks apart the word containing a character with no replacement:
[
"foo",
"ba",
"r",
"bez"
]
With the delimiter analyzer, I don't get the benefits of lowercasing or accent removal, so instead get:
[
"foo",
"ba㊌r",
"BÉZ"
]


⚠ Bofrost.fr has degraded performance

In 446a651, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 979 ms

Resolved: Bofrost.fr performance has improved in e933c32 after 7 minutes.


Data structuring is inefficient?

Hi,
Thank you very much for releasing this code and the model weights. It is a very interesting and valuable project.
I have a question about the dataset structure that is required for validation and inference. Is it the case that for every label, a copy of the corresponding image must be saved? This seems very inefficient for datasets with multiple labels like Totalsegmentator as you would have many copies of a single CT in the different folders for heart, lung, etc.

Hi @joseph-bae ,
How did you organize the dataset structure to run inference? A have a similar case with a dabaset with two labels. I have followed the same structure as done in prepare_data_from_nnUNet.py but the script doesn't find samples inside the test data directory (they are there).
Best,
Sergio

Your observation is right. We are working on a new version of a data structure that only stores the images once.
For now, we recommend to use soft-link instead of copying the images multiple times as a workaround.


Incorrect checksum for signing key

I don't think the way you're doing your checksum is correct. It looks like it's getting the same result as an empty string.
user@host:~$ wget --quiet http://nginx.org/keys/nginx_signing.key -O nginx_signing.key | sha256sum
e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855  -

user@host:~$ echo -ne "" | sha256sum
e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855  -

Here is the result I get when I changed the form of the command.
user@host:~$ wget --quiet http://nginx.org/keys/nginx_signing.key -O nginx_signing.key && sha256sum nginx_signing.key
dcc2ed613d67b277a7e7c87b12907485652286e199c1061fb4b3af91f201be39  nginx_signing.key

Thanks for pointing this out !
Fixed by commit d4666c38cc53df006fca21eab7fb572e26765c9b


feat: instancetype add list

What type of PR is this?
/kind feature

What this PR does / why we need it:
instancetype add list
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?

Please review again @daimaxiaxie @jwcesign


WGS84 coordinate set up

I noticed that the way I set up the arrays for WGS84 goes against my usual standard of the x coordinate going in the first spot in the array y coordinate going in the second. Its reversed with WGS84 so I would need to add switch statements to the code in a number of places to correct this.
It would be easier to just reverse the coordinate set up in WGS84 I'm trying to find out if anyone uses this coordinate system. If no one is using it right now I'm just going to reverse it before it becomes two standardized.

I'm going to do the updates on a separate branch and then add them in unless someone protests.


why  Can't connect to target database?

I use mysql comamnd can connect the database .but use dbdiff ,it  output ✖ Can't connect to target database

yum install php-mysql

it is not working

I use mysql comamnd can connect the database .but use dbdiff ,it output  Can't connect to target database

have u solved the issue if yes , please help me out with this.
I have installed php-mysql

Well, it's pretty old, I don't remember.


Update deps

The cassandra_codec changes are a lot easier to review if you set the diff to ignore whitespace.
While making these changes I noticed that we were completely ignoring failure to parse the csql so I added the bare minimum handling (just logging the failure)
Not sure how best to untokenize the assignment id but assignment.id.iter().map(|x| &x.value).join(".") is my best guess.
I dont think its worth spending too much time thinking about, we probably need to completely replace this stuff with a cassandra specific parser anyway.

cargo deny failing on https://github.com/hsivonen/encoding_rs/issues/75


passing function as data

I pass in a function to the data attribute on tabs like this
<tabs data="tabs()" type="tabs"></tabs>
it renders the tabs but i can not select and i also get this error on the console
Error: [$rootScope:infdig] 10 $digest() iterations reached. Aborting! Watchers fired in the last 5 iterations: [[{"msg":"fn: regularInterceptedExpression","newVal":[{"heading":"Folders",........

It's not really designed to bind the tabs to the result of a function call.  It is calling the function again and again and getting a different result every time that's why it errors out.
the data tag should point to an array on the scope of the controller instead.

Closing due to inactivity.


Provide a way to retrieve different releases from a branch

The storyblok documentation mentions adding a from_release parameter to the url to retrieve a story from a particular release. Can you please provide the same option as part of this plugin.

Can you guys please help with this?

Hi Sharan. Thanks for your input and I am sorry for the late response. I will check this with our dev team and let you know asap.

@samuells Any news on this?

@samuells any update?

Hi Sharan. Thanks for your input and I am sorry for the late response. I will check this with our dev team and let you know asap.

Oh yes. This should answer your question https://www.storyblok.com/faq/how-to-access-an-edited-version-of-a-story-from-a-release ... @sharanrprasad sorry I missed this thread. 🙏🏼

Also from docs of Delivery Api - https://www.storyblok.com/docs/api/content-delivery#core-resources/stories/retrieve-one-story you should be able to add the from_release parameter to payload of the request.

from_release
Access version of specific release by release id

@samuells none of these apis are accessible in the gatsby-source-storyblok config.  If we want to build from the release data we are not able to do so at present.

@samuells none of these apis are accessible in the gatsby-source-storyblok config.  If we want to build from the release data we are not able to do so at present.

I am not sure if I understand correctly. There is not a special API for the releases. All you need to do is to set up the from_release parameter in the request.
Check out the docs where is the sample with the preview.
https://www.storyblok.com/docs/guide/in-depth/content-authoring#releases-app

The content of a release can be accessed from the Content Delivery API using the draft token and appending the parameter from_release with the release id. In the following example, you can see how to get the Story of Home with id 29 in the draft version.

curl -X GET \
'https://api.storyblok.com/v1/cdn/stories/home?from_release=29&version=draft&token=miQeEopSce7bklQFVbBozQtt'

I am not sure if I understand correctly. There is not a special API for the releases. All you need to do is to set up the from_release parameter in the request.
Check out the docs where is the sample with the preview.
https://www.storyblok.com/docs/guide/in-depth/content-authoring#releases-app

The content of a release can be accessed from the Content Delivery API using the draft token and appending the parameter from_release with the release id. In the following example, you can see how to get the Story of Home with id 29 in the draft version.

curl -X GET \
'https://api.storyblok.com/v1/cdn/stories/home?from_release=29&version=draft&token=miQeEopSce7bklQFVbBozQtt'

Closing this issue as it seems @samuells answered this question. Feel free to open it again @sharanrprasad.


CircuitBreaker is a stateful policy

I think the example of the Circuit Breaker with Polly won't work.
The CircuitBreaker is a stateful policy and need to maintain the result of the lasts request to behave correctly. Either the policy has to be moved outside of the registration to be shared or used a Policyregistry as explained in:  https://github.com/App-vNext/Polly/wiki/Polly-and-HttpClientFactory#with-stateful-policies-use-as-selector-not-factory

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ef44bb71-2ee5-bf25-bcd2-1f1eee8b2806
Version Independent ID: 2c497f8a-2576-2c8e-8ebc-a9f8146c3630
Content: Implementing the Circuit Breaker pattern
Content Source: docs/architecture/microservices/implement-resilient-applications/implement-circuit-breaker-pattern.md
Product: dotnet-architecture
Technology: microservices
GitHub Login: @nishanil
Microsoft Alias: nanil

Hi @mingue, thank you for reaching out.
In the mentioned code snippet, the necessary policies for the circuit breaker pattern gets registered with IHttpClientFactory using AddPolicyHandler().  And SetHandlerLifetime() method is used to keep track of how often it needs to keep checking the status of the circuit. You can checkout the working example in here
Please note, IHttpClientFactory is available since .NET Core 2.1 however it's recommend to use the latest ASP.NET Core 3.1 packages from NuGet in your project. You typically also need to reference the extension package Microsoft.Extensions.Http.Polly to use this functionality.
You could also use Polly.CircuitBreaker and AsyncCircuitBreakerPolicy to register necessary policies and configuration to leverage the usage of the circuit Breaker pattern.
For e.g :

private readonly AsyncCircuitBreakerPolicy _circuitBreakerPolicy;

public ProductSvc(IConfiguration configuration, IHttpClientFactory httpClientFactory)
{
    _configuration = configuration;
    _httpClientFactory = httpClientFactory;
    _circuitBreakerPolicy = Policy.Handle<Exception>()
        .CircuitBreakerAsync(1, TimeSpan.FromMinutes(1), onBreak, onReset, onHalfOpen);
}

.....
.....

public async Task<InventoryItem> GetNumberOfAvailableProductStockAsync(int productId)
{
    try
    {
        return await _circuitBreakerPolicy.ExecuteAsync<InventoryItem>(async () =>
        { ...
        ...
        }
    }
    catch (BrokenCircuitException ex)
    {
        Console.WriteLine(ex.Message);
        throw ex;
    }
}
.........
............

For more details, you could also refer Circuit Breaker
Hope this helps !

Hi @mingue , I am closing this issue as of now. If you have any further questions, please feel free to reopen it.
Thank you.


Differentiate natural and experimental drought in SRDB import

Currently, natural drought and experimentally imposed drought (e.g., throughfall diversion) are both coded as "Disturbance"- "Drought" in HISTORY, following this guidance. However, we need to be able to separate the two, as many analyses would want to exclude the latter but not the former. Rather than coding drought treatment as "Disturbance"- "Drought", it should be coded as hist.cat-'Management' & hist.type -'Precipitation diversion'.

I think the easiest way to deal with this is to update manipulation.csv
Which ones, if not all, of these SRDB Manipulation should be changed to "Management" - "Precipitation diversion" ?

[ ]  Drought
[ ] Drought, irrigation
[ ] Rainfall exclusion
[ ] Throughfall exclusion
[ ] Warming, drought

All.

Ok I updated manipulation.csv.
Leaving this open until I redo the import to double checked that worked

@teixeirak, should this happen for all records in ForC or just SRDB?
If SRDB only, it is done and you can close it.


SAMZA-2668: AzureBlobSystemProducer: using TokenCredential throws ResourceNotFound 404 when establishing connection

Symptom: Azure blob system producer fails to authenticate with blob storage using token credential
Cause: the azure service principal used by the samza job can potentially have different roles - some roles can create containers and upload but not not fetch azure account info
Changes: allow failures when trying to validate that the flush threshold size if supported by the account type (standard vs premium)
Tests: Azure sdk classes (BlobServiceAsyncClient) if final and can not be mocked. To add a unit test, the already small method will need to be further divvied up to extract BlobServiceAsyncClient into a single line helper. As this is only a try catch and log change, not adding unit test.
API changes: None
Usage/upgrade instructions: N/A
Backwards compatible: yes

lgtm


Route server went GA Sep 2nd

No need to put the public preview comment in there any longer

@BdennisB : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"

Verified; merging.


Improve page load speed

Even with a very decent internet connection, the page takes a few good seconds to load. A big part of it seems to be all the serialized JSON data in a lot of the columns. You can actually see Chrome drawing it row by row as it's loading.
I've changed it up a little so that all the pricing data is in one big object at the end of the file. This way the browser can load the initial table, display it, and then load the rest of the data.
I've also "compressed" the pricing dictionary by using integers for the keys instead of long strings like "yrTerm1Convertible.partialUpfront" that repeat for each instance type and each region.
Those two together reduced index.html from 16mb to 5.7mb (uncompressed). It also feels like it loads faster because you don't see the row by row rendering.
I hope this is something you'd consider merging, because it would make my life much better. I load this page multiple times a day and the multiple seconds of loading add up especially when I'm in a meeting and just trying to quickly figure out some prices.

Thanks for your contribution, I have limited knowledge on the front-end parts but this seems like a good improvement with relatively few changes.
@powdahound, please have a look at this when you have some free cycles

That looks great! I've tested locally and it seems to work.

Looks great to me too. Thanks for this wonderful improvement!


Datastore Viewer

I'm currently migrating from the Google App Engine development environment to a more discrete environment, using the Client Datastore API to manage data. When developing with App Engine, I would be able to start a "Devserver", which would run my app's war file and provide helpful tooling, like the Datastore Viewer:

Does Google Cloud's Datastore Emulator provide a Datastore Viewer? If not, then this is a feature request :smile:

Hi @mitchhentges thanks for your interest in google-cloud-java!
We are not the maintainers of the emulators but I believe there's no Datastore Viewer in the emulator. @eddavisson can you confirm this? Do you know whether there are any plans to add a viewer?

@mitchhentges: We don't currently have plans to do this, but https://github.com/GoogleCloudPlatform/google-cloud-datastore would be a good place to file the feature request.

Thanks guys, I opened a feature request at https://github.com/GoogleCloudPlatform/google-cloud-datastore/issues/148


Fix memory leak

TBR @devoncarew
This is backed from the 1.9.1 version. I'm going to push this and dogfood for a bit. I would like to have this in the prod server ASAP.

lgtm


[Models] Update models to reflect the correct schemaVersion.

This PR fixes #

Updates the definitions (models/comps/rels) schemaVersion to be depict the construct as well as their version.
Updates the generation logic.

Signed commits

[x] Yes, I signed my commits.

Notes for Reviewers
This PR depends upon the following meshkit PR

@MUzairS15 are these failed checks expected?

I updated to v0.7.46 and included one or two other changes, but need to commit and push.


Implement Zip Code Parser

Acceptance Criteria:

It should be able to detect zip codes with reasonable accuracy (Use best judgement for starters).
External web calls are unacceptable, but python package requirements can be added.
Both generic and specific locations should be detectable (Items on the web interface, for instance).

Done.