YARN-10565. Refactor CS queue initialization to simplify weight mode …

…calculation

Description of PR
How was this patch tested?
For code changes:

[ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 41s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 26s

trunk passed

+1 :green_heart:
compile
1m  7s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
0m 58s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 48s

trunk passed

+1 :green_heart:
mvnsite
1m  2s

trunk passed

+1 :green_heart:
javadoc
0m 52s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 46s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 57s

trunk passed

+1 :green_heart:
shadedclient
21m 11s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 53s

the patch passed

+1 :green_heart:
compile
0m 57s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
0m 57s

the patch passed

+1 :green_heart:
compile
0m 49s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 49s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 39s

the patch passed

+1 :green_heart:
mvnsite
0m 52s

the patch passed

+1 :green_heart:
javadoc
0m 39s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 37s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 55s

the patch passed

+1 :green_heart:
shadedclient
21m  2s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
128m 25s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
hadoop-yarn-server-resourcemanager in the patch passed.

+0 :ok:
asflicense
0m 27s

ASF License check generated no output?

218m 36s

Reason
Tests

Failed junit tests
hadoop.yarn.server.resourcemanager.TestRMRestart

hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesSchedulerActivities

hadoop.yarn.server.resourcemanager.security.TestAMRMTokens

hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesCapacitySched

hadoop.yarn.server.resourcemanager.TestApplicationACLs

hadoop.yarn.server.resourcemanager.TestRMAdminService

hadoop.yarn.server.resourcemanager.TestWorkPreservingRMRestart

hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesCapacitySchedDynamicConfig

hadoop.yarn.server.resourcemanager.TestClientRMService

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4021/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4021

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux d03f93d8fe69 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 11e8ecaa6cf8a9cfd0ec3cdf7bdd4eff4457d799

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4021/1/testReport/

Max. process+thread count
983 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4021/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 48s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 10s

trunk passed

+1 :green_heart:
compile
1m  4s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
0m 59s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 48s

trunk passed

+1 :green_heart:
mvnsite
1m  4s

trunk passed

+1 :green_heart:
javadoc
0m 52s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 46s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 55s

trunk passed

+1 :green_heart:
shadedclient
21m  5s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 54s

the patch passed

+1 :green_heart:
compile
0m 56s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
0m 56s

the patch passed

+1 :green_heart:
compile
0m 50s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 50s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 38s

the patch passed

+1 :green_heart:
mvnsite
0m 53s

the patch passed

+1 :green_heart:
javadoc
0m 40s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 38s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 57s

the patch passed

+1 :green_heart:
shadedclient
20m 45s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
97m 24s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
asflicense
0m 34s

The patch does not generate ASF License warnings.

187m  6s

Reason
Tests

Failed junit tests
hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesSchedulerActivities

hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesCapacitySched

hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesCapacitySchedDynamicConfig

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4021/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4021

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 2c517434d576 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 11e8ecaa6cf8a9cfd0ec3cdf7bdd4eff4457d799

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4021/2/testReport/

Max. process+thread count
958 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4021/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Hi @brumi1024 ,
Patch LGTM.
Would you mind checking the UT failures?

Thank you for the change @brumi1024, committed to trunk.


Is it possible to construct an in-memory database from bytes?

Apologize if this is answered in the documentation somewhere, but I was unable to find it.
I have a static set of data, that I would like to be able to index and query efficiently from short-lived processes. (Rust compiled to wasm at Fastly's compute@edge network)
I would like to be able to create my database once, and embed it into my application binary, perhaps by writing it to a file and using include_bytes! or similar.
I'd then like to map these bytes into gluesql backed by a memory storage.
Is there any way of accomplishing this?

Thanks a lot, currently there's no official import/export support by Store trait or something else.
In the current structure, it is possible to import/export, but in a very.. bothersome way.
Through this PR(https://github.com/gluesql/gluesql/pull/453), I've applied Serde to MemoryStorage, so it would be useful for your use case.

Awesomet! Thanks. I think that'd be enough for my usecase.


feat: Please provide a method to distinguish cordova browser platform by platform.is('browser)

Feature Request
Ionic version:

[x] 4.x
Describe the Feature Request

I am developing a App at cordova browser platform for simulating like a App in real device with cordova plugins. But there is no way to distinguish if the platform is browser by the function platform.is(). So it's really uncomfortable.
Please provide a method to distinguish cordova browser platform by platform.is('browser).
Describe Preferred Solution

I want to check if current platform is cordova browser platform, not android or ios platform.
Describe Alternatives

Related Code

constructor(
private platform: Platform
) {
if (this.platform.is('browser')) ...
}
Additional Context

Hi there,
Thanks for the feature request. Are you able to use this.platform.is('cordova') for your use case?
Thanks!

Thanks, but platform.is('cordova') includes 3 platforms(android, ios, browser)

Thanks for the follow up. What is "browser" in this case? There is no "browser" platform in the Platform Documentation.

https://github.com/apache/cordova-browser

Thanks for the follow up. You should be able to write a function similar to:
isCordovaBrowser() {
  return (
    this.platform.is('cordova') &&
    !this.platform.is('ios') &&
    !this.platform.ios('android')
  )
}

Can you let me know if this example works for your use case?

Sorry it doesn't work because when I test my App on emulated mode at Chrome dev tool like attached image, it returns [cordova, android, mobile, hybrid] by this.platform.platforms().

Thanks for testing that out. I noticed that Cordova exposes the platform it is running. Are you able to check to see if cordova.platformId === 'browser'?

It works!!! Thanks a lot.

Great! I am going to close this as this issue has been resolved.
Thanks for using Ionic!


Pack containers into GitHub CI

These .tar.gzs later will be used by common non-podman capable builders
(copr) to create rpms with the container images.
Signed-off-by: Miguel Angel Ajo<EMAIL_ADDRESS>

/lgtm

/retest

/lgtm

openshift-ci is having some internal difficulties.  will re-run once it's stable again.

/approve prow issues are unrelated to this patch


Game icon

Create a game icon with Blender

Fixed with https://github.com/MrEliptik/godot_twitch_games/commit/637b380b6023513d8f2b7e6de0a3b7def474d726


Switch from rusha to native (node:crypto) sha1 implementation

Problem
Useless rusha usage
Changes
I switch from rusha to native (node:crypto) sha1 implementation
Benchmarks
Node.js
$ node benchmarks/rusha-vs-native.mjs
clk: ~3.99 GHz
cpu: AMD Ryzen 7 7700 8-Core Processor
runtime: node 22.11.0 (x64-linux)

benchmark                   avg (min … max) p75   p99    (min … top 1%)
------------------------------------------- -------------------------------
_hash with rusha              12.10 µs/iter   7.25 µs █
                        (4.66 µs … 1.27 ms) 116.62 µs █▄▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁
_hash with native            547.04 ns/iter 435.45 ns █
                      (370.08 ns … 3.61 µs)   3.58 µs █▃▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁

summary
  _hash with native
   22.12x faster than _hash with rusha

Bun
bun benchmarks/rusha-vs-native.mjs
clk: ~5.04 GHz
cpu: AMD Ryzen 7 7700 8-Core Processor
runtime: bun 1.1.37 (x64-linux)

benchmark                   avg (min … max) p75   p99    (min … top 1%)
------------------------------------------- -------------------------------
_hash with rusha              10.00 µs/iter   4.96 µs  █
                        (2.60 µs … 2.78 ms)  45.85 µs ▂█▂▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁
_hash with native            471.82 ns/iter 420.00 ns █
                    (370.00 ns … 949.79 µs)   1.99 µs █▆▂▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁

summary
  _hash with native
   21.19x faster than _hash with rusha

Release info Sub-libraries affected
Bump level

[ ] Major
[X] Minor
[ ] Patch

Libraries affected

[ ] All of them
[ ] posthog-web
[X] posthog-node
[ ] posthog-react-native

Changelog notes

Swtich from pure javascript (rusha) to native (node:crypto) sha1 implementation

@dmarticus this is used only for feature flags so your call here.

This package don't need to use pure js implementation of this because it target nodejs with native implement which more faster, more secure and etc


Fix link from ansible.md to calico.md

This commit fixes a broken link from ansible.md to calico.md.

ci check this


[Negative number trend] Inconsistency of trend when it comes to negative numbers.

test using baisc zustand implementation with nextjs 14:
 export function CounterDisplay() {
  const { count } = useStore();

  return (
    <div className="flex items-center justify-center rounded-lg p-1 text-2xl">
      <NumberFlow
        willChange
        aria-hidden
        trend={true}
        value={count}
        className="pointer-events-none"
      />
    </div>
  );
}

bug recreation codesandbox demo:  https://codesandbox.io/p/devbox/pk6p4q
The problem I just encountered with the newest package "0.2.5" was the inconsistency of the default trend. It shows correct up or down when the number is increasing or otherwise when the number is positive, however whenever the number is negative the trend seems break.
https://github.com/user-attachments/assets/13dba8c4-83b9-4559-9b56-ecda95374183

Hi 👋, thanks for the sandbox. Here's a forked sandbox that I think is more what you're looking for?
I wasn't sure how to handle this on the library level because I feel like it doesn't generalize, but I'm open to suggestions.

Hi 👋, thanks for the sandbox. Here's a quick fork that I think is more what you're looking for?
I wasn't sure how to handle this on the library level because I feel like it doesn't generalize, but I'm open to suggestions.

I appreciate and 100% love the efficiency you got!
The implementation is very nice and it seems like it's something that the trend should be to me, while I might adjust the direction inversely for negatives for more nature feeling.

Sweet! I'll think about what an API for this could look like and leave this open as a discussion for visibility 👋


Generator throws an error when using inheritance and source/target as pointers

Describe the bug
Generator throws an error when using inheritance and source/target as pointers.
To Reproduce
This generates a correct code
// goverter:converter
type Converter interface {
	// goverter:mapIdentity Base
	Convert(in In) Out
}

type In struct {
	Name string
	Age  int
}

type Out struct {
	Base
	Age int
}

type Base struct {
	Name string
}

But this throws an error
// goverter:converter
type Converter interface {
	// goverter:mapIdentity Base
	Convert(in *In) *Out
}

type In struct {
	Name string
	Age  int
}

type Out struct {
	Base
	Age int
}

type Base struct {
	Name string
}

Error while creating converter method:
    func (mappers.Converter).Convert(in *mappers.In) *mappers.Out

| *mappers.In
|
|     | mappers.In
|     |
|     |
|     |
source*.???
target*.Base
|     | |
|     | | mappers.Base
|     |
|     | mappers.Out
|
| *mappers.Out

Cannot match the target field with the source entry: "Base" does not exist.
exit status 1

Expected behavior
I would expect it to correctly generate a converter, but maybe I'm missing something.

Thanks for your report. The bug is fixed in v0.10.1.


Generalization

Does this method also generalize well to multi-view predictions ? , i.e generating heatmaps from several views and training in this manner to predict directly the 3d poses as in voxel pose (but the data is only synthetic only camera poses known I'm advance but no actual pairs available)

Yes, it is ready to be used in multi-view setting.

from the design of the code it seems like it is only tested on single view , am i right ?


Added Gitter chat

Can't believe there's not a Slack channel yet but babysteps

@jongalloway can you fix @tugberkugurlu's nit?

I'm disappointed to see these rapid changes. I think there should be an RFC style approach to discuss proper communications channels.

What is wrong with telephones? People used to call each other, it was more intimate back then. Millennials!

Merged

Thank you for your contribution @jongalloway !

I am utterly dissapointed that you didn't require @jongalloway to squash, gzip and squeeze his commits into one tiny one! What a mess! unbelievable! :trollface:


Update to depend on memory bug fixed release

Can be found here:
https://github.com/smirarab/sepp-refs/releases

I think I addressed this with #4

Covered in PR #7

We can close this issue now @wasade


Update index.html

Corrected "/api/computer/.." to "/api/wakeup/computer/.." in REST API Usage info text.

Thanks for your contribution to this awesome project :-)


destroy callback or reload function

Issue description:
I haven't found to dynamically add / remove slides.
There is also no reload().
Could you add a reload() or a callback for the destroy function, so we could reinit the slider after added / removed slides?
Tiny-slider version:   2.5.2
Browser name && version:  *
OS name && version:   *

Just add a new method rebuild(), please refer to here.
For dynamically add/remove slides, it's much more complicated. I will consider this feature later.

Thank you! Exactly what I need.
could you deploy the new version on npm?

Hi, I'm having a problem with this rebuild, as I want to rebuild as part of a Wordpress ajax call. The initial carousel code is loading before the child divs are created, creating the 'No slides found' warning.
However, as part of my ajax function that creates the children, whe I call slider.destroy().rebuilt() I get:

Uncaught TypeError: Cannot read property 'destroy' of undefined

So how can I look for the slider first, as I believe this is because I'm trying to call destroy before the carousel is actually created in the first place...

Hey there,
I would like to see a callback for the destroy method, since I want to 'tell' the console after I destroyed the slider .. just to be sure :D


Unused argument

Dear author,
Thanks for developing this interesting tool! I've successfully tested on the demo data, but I got issues running the following command on my own assemblies.
I first tried the following command, but it gives me the unused arguments error.
nahrwhals(ref_fa='./T2T-CHM13v2.fasta',alt_fa='./HG00733.vkk.hap1.fasta',outdir='res',threads=10)

Then I found in your source code, the parameter is asm_fa instead of alt_fa as you used in README.md. Thus, I changed my code as below:
nahrwhals(ref_fa='./T2T-CHM13v2.fasta',asm_fa='./HG00733.vkk.hap1.fasta',outdir='res',threads=10)

However, I still got the unused arguments error.
Looking forward to your reply! Thanks!

Hi Jiadong,
Thx for your patience! I refactored bits and pieces of the code and made a new release. Could I ask you to install the latest version 1.4 and try again? Things should hopefully work now.
best
Wolfy

Hi Wolfy,
I got another error
[1] "No region or regionfile provided. Running whole genome discovery mode."
[1] "No minimap2 index \".mmi\" file of one of the fastas found. Creating one now (takes around 1 minute for a whole human genome assembly.)"
[1] "No minimap2 index \".mmi\" file of one of the fastas found. Creating one now (takes around 1 minute for a whole human genome assembly.)"
Error in scan(file = file, what = what, sep = sep, quote = quote, dec = dec,  :
 line 1 did not have 2 elements
In addition: Warning messages:
1: In read.table(fasta_awk_tmp_file, stringsAsFactors = FALSE) :
 line 2 appears to contain embedded nulls
2: In read.table(fasta_awk_tmp_file, stringsAsFactors = FALSE) :
 line 3 appears to contain embedded nulls
3: In read.table(fasta_awk_tmp_file, stringsAsFactors = FALSE) :
 line 4 appears to contain embedded nulls

Here are the outputs under outdir
drwxrwsr-x 2 jdlin eichlerlab 4096 Apr 16 08:48 minimap_idxs
drwxrwsr-x 3 jdlin eichlerlab 4096 Apr 16 08:49 whole-genome-windows

Hi Jiadong,
I haven't seen this error before, and have not managed to reproduce it. One thing I did notice is that the program is allergic to tabs or spaces in the contignames. Can that explain your error? Otherwise, which OS are you using?
What I would suggest to debug:

can you try if the error persists with another fasta? E.g., throwing hg38 in?
do you get a tmpinfo_deleteme_[number].bed after your error? If so, could you share it?
could you try if nahrwhals::get_fasta_info('./HG00733.vkk.hap1.fasta', 'out.txt') produces an out.txt file?
can you try if the 'targeted' mode is working, by giving e.g. one random 1mbp reference region as input?

Thanks for sticking by! Anything that can help reproduce the error on my end would help a lot!
cheers
Wolfy

Hi,
I used both hg38 and CHM13 with targeted mode. It works and I feel that this is more like a targeted caller.
FYI
I do have a binary output file from get_fasta_info('./HG00733.vkk.hap1.fasta', 'out.txt')
It would be great if this can be applied genome wide.

It is strange when I change to another regions, I get new errors:
[1] "Coordinates provided. Genotyping that region."
[1] "Step 1: Identifying homologous regions in the y assembly"
[1] "Step 2: Computing detailed pairwise alignment"
[1] "Step 3: Segmenting pairwise alignment"
[1] "Step 4: BFS search for mutation chains."
ERROR: LoadError: ArgumentError: Package ArgParse not found in current path.
Run `import Pkg; Pkg.add("ArgParse")` to install the ArgParse package.
Error in count.fields(juliares_path, sep = "\t") :
cannot open the connection


Fix issue with setuptools causing crash

Setuptools causes a crash during regular apt updates / upgrades because the semantic versioning of packages doesn't fit standard now enforced by setuptools above 66. Issue referenced here.
This PR will pin setuptools to any version under 66 until the issue is resolved.

For the record, this issue only occurs with Python 3.8 in Ubuntu 20.04

We should probably split this into _focal vs _jammy salt states then so we can take different approaches. The old powershell or exfat extras has an example.

If we split them now while waiting for an issue to be resolved, we may find more incompatibility issues with future python3 tools if both OSes are using different versions of setuptools.
Since there's no deprecation planned for 65.x for a while, it might be better to keep both OSes at the same version to ensure compatibility while the issue gets resolved.
I can close the PR and make a new one, but I feel like this might be a better short-term approach.


outputs repaired and tests added to prove counts

PR o'clock
Description
I introduced a but (to try and resolve a terraform warning turned error) by reducing the output counts by 1, thinking I had an off by 1 error. This was wrong and I cut off a resource output. I've created tests to verify output length.
Checklist

[x] terraform fmt and terraform validate both work from the root and examples/alb_test_fixture directories (look in CI for an example)
[x] Tests for the changes have been added and passing (for bug fixes/features)
[x] Test results are pasted in this PR (in lieu of CI) - tests in CI but also pasted below
[x] Docs have been added/updated (for bug fixes/features)
[x] Any breaking changes are noted in the description above

Test summary output:
Finished in 1.11 seconds (files took 2.65 seconds to load)
52 examples, 0 failures

       Finished verifying <default-aws> (0m6.27s).
-----> Kitchen is finished. (0m7.42s)

Good to see checklists. This is something I need to add to the rest of our repositories.

Feel free to take and improve on anything I’ve got here in your repos.


TextInput should call blur and focus methods of selectionState

DocumentSelectionState returns anchor and focus offsets only in focused state. So TextInput should set proper state to selectionState when blur and focus.

I'll let @andreicoman11 review this one.

@facebook-github-bot shipit


Improve experience for function arguments

Since the go client doesn't use structs and a functional API instead, editor completions won't be available for some cases, such as:
users, err := client.User.FindOne(|)

When the cursor is in the FindOne method, it may not be clear what the user is supposed to type.
One way to improve the user experience would be to provide go doc comments with examples.

Would we be able to improve this experience through the VS Code plug-in? Cc @carmenberndt

Wouldn't it be the most natural thing to solve this via the programming language and e.g. use a builder?
users, err := client.User.FindOne(User.ByEmail("bla@bla.de"))

@mavilein This is how it works. However, it may not be clear what should go into FindOne, since the argument is an interface. For example, the argument in FindOne may take an interface:
type UserWhereUniqueParams interface {
  userUniqueParams()
}

However, the IDE doesn't know in normal autocompletion what methods in different packages it can suggest to satisfy userUniqueParams. This is because we use an interface and a functions API and not a struct with specific values.
To take your example, how should the IDE know that you can type User in the FindOne (to complete User.ByEmail(...) if the argument is an interface?

Ah i see. Yeah then documents and intuitive namespaces are the way to go i guess.


Support disco diffusion

Disco diffusion shows amazing results. Need to add support for it.

An example disco diffusion config I found on the LAION discord


feature request: rdate time on port 37

Please consider implementing the rdate time protocol on port 37 (tcp &/or udp).
Although NTP is better, rdate is "just good enough" in many situations. Due to its simplicity, it's perfect for most IoT and micro-devices. And being a standard, many legacy devices will support rdate over NTP.
It could also be helpful for folks needing a "just good enough" $20 device with a $12 GPS, $4 ESP32 or ESP-8266 & $4 RTC PCF8523.
very cool. cheers.

Sorry, for some reason I didn't see your message before. I will work on it, looks really simple.
Would you be able to test once it is done and tell me the results?
Thank you!

Hi @markstinson
Just added RDATE support. Please take a look.
Regards,

Cristiano


unable to save features to kmz sometimes

There is an issue with saving features to KMZ that is erratic and only sometimes repeatable.  To reproduce:

Create features as any geometry (line, circle, ellipse, ring)
Save as KMZ

The program will hang sometimes and will need to be shut down via task manager.  This issue was first documented in #299 and was seen/observed by multiple team members on different machines.

please verify pr: https://github.com/Esri/distance-direction-addin-dotnet/pull/399

Waiting for #399 to merge before testing.

@ACueva - Merged, plz kickoff build

Build completed, ready to be tested.

I have verified this fix using build 05-31-2017_1540

I've also tested Lines, Rings, Circles, and Ellipses.  Looks good on the latest build.   I did not get it to crash.


Fail to build from source (FTBFS) using sbuild on Ubuntu: can't use the home path to store NuGet.Config

Hi,
I'm trying to build .Net 6 from source using sbuild in Ubuntu to generate deb packages.
The debian/rules file launches the following command for the building:
.dotnet/dotnet .dotnet/sdk/6.0.100/MSBuild.dll /bl:artifacts/log/Debug/BuildXPlatTasks_0221123733.binlog /flp:v=detailed /p:SkipPortableRuntimeBuild=true /p:LogVerbosity=n /p:MinimalConsoleLogOutput=false /p:ContinueOnPrebuiltBaselineError=true /t:PrepareOfflineLocalTools /v:n tools-local/init-build.proj
and there the path used to look for configuration files is the home path (sbuild-nonexistent), resulting in the following error:
"/<<PKGBUILDDIR>>/tools-local/init-build.proj" (PrepareOfflineLocalTools target) (1) ->
"/<<PKGBUILDDIR>>/tools-local/tasks/Microsoft.DotNet.SourceBuild.Tasks.XPlat/Microsoft.DotNet.SourceBuild.Tasks.XPlat.csproj" (Restore target) (2) ->
"/<<PKGBUILDDIR>>/tools-local/tasks/Microsoft.DotNet.SourceBuild.Tasks.XPlat/Microsoft.DotNet.SourceBuild.Tasks.XPlat.csproj" (_GenerateRestoreGraphProjectEntry target) (2:5) ->
(_GetRestoreSettings target) ->
  /<<PKGBUILDDIR>>/.dotnet/sdk/6.0.100/NuGet.targets(564,5): error : Failed to read NuGet.Config due to unauthorized access. Path: '/sbuild-nonexistent/.nuget/NuGet/NuGet.Config'. [/<<PKGBUILDDIR>>/tools-local/tasks/Microsoft.DotNet.SourceBuild.Tasks.XPlat/Microsoft.DotNet.SourceBuild.Tasks.XPlat.csproj]
/<<PKGBUILDDIR>>/.dotnet/sdk/6.0.100/NuGet.targets(564,5): error :   Access to the path '/sbuild-nonexistent/.nuget/NuGet' is denied. [/<<PKGBUILDDIR>>/tools-local/tasks/Microsoft.DotNet.SourceBuild.Tasks.XPlat/Microsoft.DotNet.SourceBuild.Tasks.XPlat.csproj]
/<<PKGBUILDDIR>>/.dotnet/sdk/6.0.100/NuGet.targets(564,5): error :   Permission denied [/<<PKGBUILDDIR>>/tools-local/tasks/Microsoft.DotNet.SourceBuild.Tasks.XPlat/Microsoft.DotNet.SourceBuild.Tasks.XPlat.csproj]

but sbuild doesn't allow it as per https://lists.debian.org/debian-devel/2016/02/msg00456.html (Thanks @omajid for the link!).
As a workaround, the sbuild-nonexistent folder can be created before call to MSBuild (it works manually but not from the rules file), and is not Debian compliant.
Would it be possible to use a different path than the user's home, e.g. could it be passed as an argument?
Thanks in advance,
Miriam

If there are no known workarounds, that makes this issue more of a blocker for packaging for Debian/Ubuntu, right?

Hi,
I tried exporting the $HOME variable to a temporary folder and then the building progresses, so we have now, yes, a workaround.


How the coordinates of vertebrae centroids are labeled?

Hi，
Thank you for organizing and sharing the data. I am using VerSe'20 data. Can you tell me how the coordinates of vertebrae centroids are labeled? The MICCAI version or the subject-specific version is fine, I want to know how the coordinates of vertebrae centroids are annotated? Or what annotation software is used?

Please refer to #3. We can continue the conversation there.


cmd/compile: inline harder to optimize closure allocation

I'm not sure but sometimes using closure causes unwanted allocations.
Please see https://go-review.googlesource.com/#/c/27211/ and https://go-review.googlesource.com/#/c/27210/.
I also don't know this is fixable or not, sorry.

Note that this is about all the strings.Trim* and bytes.Trim* functions.
It looks like if the compiler could inline the super-trivial single-line makeCutsetFunc, then the escape analysis does work.
This patch makes removes the only allocation from strings.TrimLeft:
diff --git a/src/strings/strings.go b/src/strings/strings.go
index 738c493..7faa447 100644
--- a/src/strings/strings.go
+++ b/src/strings/strings.go
@@ -600,7 +600,7 @@ func TrimLeft(s string, cutset string) string {
        if s == "" || cutset == "" {
                return s
        }
-       return TrimLeftFunc(s, makeCutsetFunc(cutset))
+       return TrimLeftFunc(s, func(r rune) bool { return IndexRune(cutset, r) >= 0 })
 }

where makeCutsetFunc is just:
func makeCutsetFunc(cutset string) func(rune) bool {
        return func(r rune) bool { return IndexRune(cutset, r) >= 0 }
}

I guess that is too "hairy" to be inlined, but it probably should be.
/cc @dr2chase @randall77 @mdempsky @josharian

I started on inlining closures during the last freeze and got stuck. I'll mail some of the finished preliminary work; it's just waiting for me to get to it. Lots to mail, little time.

This is #10292 (which also cites Trim performance improvements) and also #15561 I guess?

True. this is exactly dup.


Addon is broken

Can't create/record any macros. Addon is simply broken. Last official version. Please check: https://youtu.be/0Og0XhVIGVg

Mate if you cant tell me what is broken and which other closed issues you have looked at for a solution, I'm not watching a random video.

Could you please try to read the letters?
"Can't create/record any macros."
There is info in my comment. You can try to read it at realise that some problem exist.
I didn't created this addon and i don't know what exactly place is not working.
So don't need to justify own lazyness instead of watching 2 minute video.
Additional info:
I also thought that the problem is elvui. But disabling of the all addons didn't help.
I click save macros but macros is not saving. Don't know what else specification you need?
Also i can't move the icon to the action bar, but tooltip saying that i can (in new sequence creation menu), so i don't know if it's bug or feature.
Watch the video, there is 4 cases

With elvui default sequence name.
With elvui random sequence name.
Without elvui default sequence name.
Without elvui random sequence name.

The reality of my world is that for the rest of this week I have limited access to my email and that’s it.  I cannot watch your video till sometime next week:  this isn’t personal it’s just a fact of both life and my very limited connectivity at the moment.
From the complete lack of information in your post at this time all I can do is refer you to the common problems with similar descriptions as yours - #713
TimothyLuke

On 15 Dec 2020, at 7:05 am, ruslanzelinskyy<EMAIL_ADDRESS>wrote:

Could you please try to read the letters?
"Can't create/record any macros."
There is info in my comment. You can try to read it at realise that some problem exist.
I didn't created this addon and i don't know what exactly place is not working.
So don't need to justify own lazyness instead of watching 2 minute video.
Additional info:
I also thought that the problem is elvui. But disabling of the all addons didn't help.
I click save macros but macros is not saving. Don't know what else specification you need?
Also i can't move the icon to the action bar, but tooltip saying that i can (in new sequence creation menu), so i don't know if it's bug or feature.
Watch the video, there is 4 cases
With elvui default sequence name.
With elvui random sequence name.
Without elvui default sequence name.
Without elvui random sequence name.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

I watched the video.  He was in combat (hunter whose pet was attacking the dummy).  Perhaps this was the cause?

I finally got to watch the video - your in combat.  GSE cant change/import or save anything while you are in combat.  It all queues up till you get out.


[Feature] Manage existing Database

Hello :)
Is your feature request related to a problem? Please describe.
No
Describe the solution you'd like
I have a MariaDB provided by a DBaaS. I'd like to be able to manage Users, Grants and logical Databases with the operator. I might just be missing the right pieces from the documentation.
Describe alternatives you've considered
Managing the Users Grants and DBs as well in Terraform.
Additional context
We're running EKS on AWS and the DBaaS is a RDS Database. But I believe this issue would apply in any environment.
Environment details:

Kubernetes version: 1.26
mariadb-operator version:  v0.0.19
Install method: helm
Install flavour: recommended

Thank you in advance for any pointers.

Hey @aschaber1 ! Thanks for this suggestion. This is currently not supported but it is definetly interesting 👍🏻
We will need to adapt our SQL resources to add an externalMariaDb field. This will basically replace the current mariaDbRef  that refers to local MariaDB instances provisioned by the mariadb-operator in the same cluster:
apiVersion: mariadb.mmontes.io/v1alpha1
kind: User
metadata:
  name: user
spec:
  externalMariaDb:
    host: mydb.123456789012.us-east-1.rds.amazonaws.com.
    user: admin
    passwordSecretKeyRef:
      name: admin
      key: password
    caSecretKeyRef:
      name: aws-rds-ca
      key: ca.crt
  passwordSecretKeyRef:
    name: user
    key: password
  maxUserConnections: 20

apiVersion: mariadb.mmontes.io/v1alpha1
kind: Grant
metadata:
  name: grant
spec:
  externalMariaDb:
    host: mydb.123456789012.us-east-1.rds.amazonaws.com.
    user: admin
    passwordSecretKeyRef:
      name: admin
      key: password
    caSecretKeyRef:
      name: aws-rds-ca
      key: ca.crt
  privileges:
    - "SELECT"
    - "INSERT"
    - "UPDATE"
  database: "*"
  table: "*"
  username: user
  grantOption: true

apiVersion: mariadb.mmontes.io/v1alpha1
kind: Database
metadata:
  name: data-test
spec:
  externalMariaDb:
    host: mydb.123456789012.us-east-1.rds.amazonaws.com.
    user: admin
    passwordSecretKeyRef:
      name: admin
      key: password
    caSecretKeyRef:
      name: aws-rds-ca
      key: ca.crt
  characterSet: utf8
  collate: utf8_general_ci

As an alternative to password authentication, you may annotate the mariadb-operator serviceaccount to setup IRSA:
apiVersion: v1
kind: ServiceAccount
metadata:
  name: mariadb-operator
  annotations:
    eks.amazonaws.com/role-arn: $(MARIADB_OPERATOR_IAM_ROLE)

This can be achieved by setting serviceAccount.annotations when installing the helm chart:

https://github.com/mariadb-operator/mariadb-operator/blob/main/deploy/charts/mariadb-operator/values.yaml#L45

Does this make sense to you?
This has been labeled with help wanted, contributions and PRs are welcome!

Thank you for your reply.
Im not a dev (long time ago some Java, hence the idea), but I'd like to suggest another approach, keep the mariaDbRef and have two implementations of the interface, one that is managed and one that is external. Cause i don't see the benefit of an additional field just from your examples.
On the other hand thinking about it.. your approach is probably easier to implement, while mine may be easier to use.

Hey there, that's a fair point.
Re-iterating on my previous proposal, we could introduce a new resource, the ExternalMariaDB:
apiVersion: mariadb.mmontes.io/v1alpha1
kind: ExternalMariaDB
metadata:
  name: my-rds-instance
spec:
    host: mydb.123456789012.us-east-1.rds.amazonaws.com.
    user: admin
    passwordSecretKeyRef:
      name: admin
      key: password
    caSecretKeyRef:
      name: aws-rds-ca
      key: ca.crt

and specify it as a reference  via spec.mariaDbRef,  with the difference that we would be providing the kind:
apiVersion: mariadb.mmontes.io/v1alpha1
kind: User
metadata:
  name: user
spec:
  mariaDbRef:
      name: my-rds-instance
      kind: ExternalMariaDB
  passwordSecretKeyRef:
    name: user
    key: password
  maxUserConnections: 20

apiVersion: mariadb.mmontes.io/v1alpha1
kind: Grant
metadata:
  name: grant
spec:
  mariaDbRef:
      name: my-rds-instance
      kind: ExternalMariaDB
  database: "*"
  table: "*"
  username: user
  grantOption: true

apiVersion: mariadb.mmontes.io/v1alpha1
kind: Database
metadata:
  name: data-test
spec:
  mariaDbRef:
      name: my-rds-instance
      kind: ExternalMariaDB
  characterSet: utf8
  collate: utf8_general_ci

This way we have two swappable implementations that can be used in the spec.mariaDbRef, so we can reuse the same reconciliation logic.
What do you think @aschaber1 ?

Yeah, this absolutely looks like a more familiar approach. 👍
Unfortunately I, currently, do not have the skills or capacity to implement this.

I am looking for a way to automate creating Users/Grants/Databases from my manifest for Kubernetes and came across this operator. However I already have a separate Galera Cluster outside of Kubernetes for other databases that I would like to reuse. I was testing to see if I could manage the objects in the external database by utilizing this operator and came across this issue. Seems like there is work needed for this to work properly.
I like the last proposal made by @mmontes11, it is looking much simpler for the end user. With only defining the host/username/password once in a separate CRD that then can be reused in the other objects. The account/connection can work the same as with a cluster-server but the internal connection is made to the external DB instead.
I looked at adding this in code but as I have never worked on CRD:s before this seems a bit massive to start with. Just adding this as a "I also want this" comment.

Thanks a lot for your input @loffa !
Yes, some adaptations need to be made in order to support ExternalMariadb resources. I think it makes total sense to reuse part of the mariadb-operator control plane to manage resources in external instances. This would include the following resources:

User
Grant
Database
SqlJob
Connection

The good thing about relying on a control plane to manage these resources is that they are continuously reconciled, reproducible and fully automated. We will prioritise this item in future releases.

@loffa actually, we should be able to do it for Backup and Restore resources as well.


ClusterProtectionLevel not documented here

Hi,
ClusterProtectionLevel is not documented here. Can you add?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6005a24c-118d-6c56-5525-4616e9102fe0
Version Independent ID: 429e2d0f-d5da-8972-2890-52081eee3330
Content: Change Azure Service Fabric cluster settings
Content Source: articles/service-fabric/service-fabric-cluster-fabric-settings.md
Service: service-fabric
GitHub Login: @aljo-microsoft
Microsoft Alias: aljo

Thanks for the question! We are investigating and will update you shortly.

@aljo-microsoft Please take a look at this issue.

@pisees and @jakaruna-MSFT
Protection Level's are documented where it makes sense:
https://docs.microsoft.com/en-us/azure/service-fabric/service-fabric-reliable-services-secure-communication
https://docs.microsoft.com/en-us/azure/service-fabric/service-fabric-connect-to-secure-cluster
https://docs.microsoft.com/en-us/dotnet/api/system.fabric.protectionlevel?view=azure-dotnet
https://docs.microsoft.com/en-us/azure/service-fabric/service-fabric-reliable-actors-fabrictransportsettings
I.E. Your application implementation choices make sense.
Why would you expect or desire less security than 'EncryptAndSign' protection level at the cluster?
I.E. Wouldn't you always want System Node To Node and Client to Node Communications to be the most secure encrypted an signed?

Sorry, please ignore this response. I was mixing up ClusterProtectionLevel in fabricSettings section; and ClusterCredentialType in security section.
Indeed, I am looking as you way to be sure that communication is the most secure (EncryptAndSign), and in fact, the reason was asking for documentation whether this setting applies to ALL communication within a cluster: actors, reliable services, and any other internal communication.

Thanks indeed, I am looking to have the best security (EncryptAndSign) for all traffic between nodes in a cluster whether from application code (reliable services, or actors); or any internal communication that services fabric does. I assume so, but was not entirely clear that this is the case from documentation. That was the reason asking for more documentation on ClusterProtectionLevel -- to understand for which types of communication it applied.

@pisees  I will close this out for now. If you need additional help please let me know and we can reopen and continue.

I am setting up cluster using ARM Templates. To look for the possible settings I refer the below link.
https://docs.microsoft.com/en-us/azure/service-fabric/service-fabric-cluster-fabric-settings
When it is seen that only one parameter is missing that leads a confusion. What is the intent of hiding the parameter from this document?


restore exception handling #949 #1005

This change restores the exception handling in TabletServerLogger to the way it was before the changes in #1005.  This changes makes TabletServerGivesUpIT pass.

@keith-turner Is this intended to block 1.9.3 or should that be labeled 1.9.4? (In other words, are you voting -1 on the 1.9.3 RC1 for this issue?)

@ctubbsii I voted -1 on 1.9.3 RC1 because of this issue.


Out of date template picture for ADF pipeline

I'm writing this, because I assume the recent pipeline has been enhanced?
This what I see when I select the pipeline template in ADF:

Does this doc need to be updated with this information?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 7a8d324c-cc14-c8f9-8adf-4b9af10f55ce
Version Independent ID: 7a8d324c-cc14-c8f9-8adf-4b9af10f55ce
Content: Copy Dataverse data into Azure SQL - Power Apps
Content Source: powerapps-docs/maker/data-platform/azure-synapse-link-pipelines.md
Service: powerapps
Sub-service: dataverse-maker
GitHub Login: @JasonHQX
Microsoft Alias: matp

Thanks for your comment, @jameswiseman76. This issue has been assigned to the doc author for review.


add resources and important info about the club

1. What type of PR is this? (check all applicable)

[X] ♻ Refactor
[ ] ✨ Feature
[ ] 🐛 Bug Fix
[ ] 👷 Optimization
[ ] 📝 Documentation Update
[ ] 🔖 Release
[ ] 🚩 Other

2. Description

This PR adds more resources to the website's resources page and important info about the club on the club's "Who We Are" section.
3. Relevant Documents, Websites, & Issue Numbers

N/A
4. Mobile & Desktop Screenshots/Recordings

About Page:

Resources Page:

5. Add tests?

[ ] 👍 yes
[X] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

6. Remarks, notes, or any future suggestions?
Really, really happy with the changes. We are marching forward to a more inclusive community.
7. Add to the documentation(s)?

[ ] 📜 readme
[ ] 📜 contributing.md
[ ] 📓 docs
[ ] 📕 storybook
[X] 🙅 no documentation needed

8. Are there any post-deployment tasks we need to perform?
Nope.
9. What gif best describes this PR or how it makes you feel?
So EXCITED!!!!

The message sounds really good as it showcases what we are about! The code looks good, too!


upload files in the app doesn't work....

Summary
(I'm sorry my English skills are not good.)
I looked at the example and made the code exactly as it was. But it doesn't work.

let result = await DocumentPicker.getDocumentAsync({
type:'*/*',
copyToCacheDirectory: false,
});

//const uri = FileSystem.documentDirectory+result.assets[0].name;
setSrc(result.assets[0].uri);

I think setSrc(result.assets[0].uri); is not correct.
What should I do?
(uri returns content://com.android.externalstorage.documents/document/primary%3ADownload%2Ffailing-forward%20(1).epub)
thank you for your response.
What platform(s) does this occur on?
Android
What workflow(s) does this occur on?
Expo Workflow, Bare Workflow
Environment (or package.json)

{
  "name": "epubreader-app",
  "version": "1.0.0",
  "main": "index.js",
  "scripts": {
    "start": "expo start --dev-client",
    "android": "expo run:android",
    "ios": "expo run:ios",
    "web": "expo start --web"
  },
  "dependencies": {
    "@epubjs-react-native/core": "^1.4.6",
    "@epubjs-react-native/expo-file-system": "^1.1.3",
    "@epubjs-react-native/file-system": "^1.1.3",
    "epubjs": "^0.3.93",
    "expo": "~52.0.18",
    "expo-document-picker": "^13.0.1",
    "expo-file-system": "~18.0.5",
    "expo-status-bar": "~2.0.0",
    "invariant": "^2.2.4",
    "react": "18.3.1",
    "react-native": "0.76.5",
    "react-native-config": "^1.5.3",
    "react-native-document-picker": "^9.3.1",
    "react-native-fs": "^2.20.0",
    "react-native-gesture-handler": "~2.20.2",
    "react-native-send-intent": "^1.3.0",
    "react-native-webview": "13.12.5",
    "react-native-zip": "^1.0.0",
    "react-native-zip-archive": "^7.0.1"
  },
  "devDependencies": {
    "@babel/core": "^7.20.0"
  },
  "private": true
}

Your .epub file
any
Minimal reproducible example
No response
I confirm that i have

[X] I looked for a solution to my problem in other open and resolved issues
[X] I checked the examples provided solve my problem
[X] I have verified that my problem is not caused by a third-party library
[X] I cloned the project environment examples and still the problem persists
[X] I'm using the latest available version of the library and its complements

I find solution...
In android,
RNFS.DownloadDirectoryPath + "/" + result.assets[0].name
should be src


Inconsistent navbar highlight

The Bootstrap scrollspy isn't calculating the correct offset position for the active link. This leads to inconsistent results:

Not autoscrolling to the correct position
When scrolling, the highlighted link doesn't show up after that section has been scrolled
When autoscrolling, it contains two active links

Noticed a bug caused by 4b468dbbe07af12b86bf6e4da19cd6e2a7b18cc4
When you click a navbar link, it will stay highlighted until you click somewhere else. I believe this is caused by a focus property. I'll attempt a fix.


Customizable okhttp builder

I'd like to be able to create remoting clients where I change some details about the okhttp client, such as

dispatcher
connection pool
cache

Use case is I will create a lot of clients, most of which will share the same underlying set of hosts but have different URIs.
I'd like all these clients to share the above objects.
I'd also like to configure the cache such that I can make it an on-disk cache, and it needs to be shared in order to enforce a maximum cache size across all clients.
Currently, each new okhttp client (either created directly or through the jaxrs / retrofit2 factories) creates its own new dispatcher and connection pool. This means we can't enforce global limits on the

total number of connections
number of connections per host

via the dispatcher, nor can we reuse existing connections to the same hosts from a different client.
They also don't allow configuring the cache, leaving it as the default, so it's impossible to configure a bounded on-disk cache.

Yep - I'm super happy to do that.
But I still need a configurable cache, which I think is a generally good idea. Any remoting client that hits cacheable endpoints could benefit from that.
It needs to be configurable so I can give it a path on disk.

Closing in favour of #706


New School

Severn School

@aotero08 lib/domains/file: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@aotero08 Please fork SWOT repository, copy file.zip in the root folder of your forked SWOT repository. Then unzip file.zip there with no changes to the directory structure. Then make a new pull request. If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message. I have to close this request without merging. Thank you for your understanding.


Might be some problems in the ActionsURI Document

In this document page:
https://zottmann.dev/obsidian-actions-uri/routes/file/

I'm not sure if it's a typo because when using /vault/get-active I got nothing return..
And if use file/get-active I can get the result, but not like what is said in document:

Instead, I still got the relative path to the vault, rather than the fullpath of file:

Hi @Moyf, thanks for your ticket.

I'm not sure if it's a typo because when using /vault/get-active I got nothing return..

Yes, it's a typo, thanks for reporting it! 😅

And if use file/get-active I can get the result, but not like what is said in document:

Ah, that's a mistake on my end, apologies. result-filepath will return the path starting from the vault's root folder.
Both errors are fixed now!

Thank you for fixing it! <3
By the way, I'm not sure if I missed something - is there any API to directly obtain the absolute path of active file in one step? Or do I have to first get the path of the vault through /vault , and then combine it with the relative path?
(This way requires sending two requests, which can be a bit troublesome 🤔)

It's the latter. Obsidian itself does not return absolute paths, so Actions URI doesn't, either. Most of my own work happens on macOS and iOS, and I almost never need the absolute path for anything. ;)

It's the latter. Obsidian itself does not return absolute paths, so Actions URI doesn't, either. Most of my own work happens on macOS and iOS, and I almost never need the absolute path for anything. ;)

Roger that, thanks!  :D


Provider is not working in root component level

If my root component is App.tsx and am using Provider in this, then my child component useFetch is not taking base url.

Could you make a codesandbox reproducing the bug please

closing this. I am not able to reproduce this.


The “Group By" context menu flashes after clicking "Group By" button when focusing on any view but the RESOURCES

OS: Win10
Build Version: 20240809.1
Visual Studio Code Version: 1.93.0-insider (user setup)
Repro Steps:

Make sure the account signed in and not focused on the RESOURCES view.
Click the "Group By" button.
Check whether to display the “Group By" context menu.

Expect:
The “Group By" context menu can normally display after clicking "Group By" button when focusing on any view.
Actual:
The “Group By" context menu flashes after clicking "Group By" button.

More Info:
This issue doesn't reproduce on VS Code IDE.

Under more info I see that this doesn't reproduce on VS Code desktop.  Which environment are you reproducing this issue on?
Does the issue continue to persist after restarting the application?

@MicroFish91

This issue only repro on VS Code-Insiders IDE.
This issue still repro after restarting the VS Code-Insiders IDE.
This issue also repro on all azure extension icons on WORKSPACE if not focused on WORKSPACE view, such as below:

I can also reproduce this. The workaround is to focus the view prior to clicking a button on the ribbon. I verified that this reproduced on other extensions as well (not just ours) so it seems like something that VS Code rolled out.


Create better default CPACK_GENERATOR

Currently if a package doesn't specify a CPACK_GENERATOR the generated
one is excessive. rocBLAS generates several tarballs which are about
1GB in size each which are not used. This consumes I/O time slowing
the builds as well as using disk. Systems using "deb" files need to
install programs to create "rpm" packages and vice versa. With
generation of debug information these requirements become even more
stringent, for example the standard macros for packaging rpm debug
info require eu-strip to be installed.
If the build environment specifies a PKGTYPE variable and no
CPACK_GENERATOR is specified then set CPACK_GENERATOR based on this
value.
Change-Id: I14dcf59f6681d985f8e9ca25e68b4a3537835800

Why not set CPACK_GENERATOR to the  packages you want when you call cmake?

"Why not set CPACK_GENERATOR to the packages you want when you call cmake?" the code is just about setting a better default.
If CPACK_GENERATOR is set, then it is honored. If it is not set, but PKGTYPE is set then that is used, otherwise use the existing code.
If the calls to cmake were in a central place, where we could add flags to set the packaging type with ease then we wouldn't need to do this. As it is most (all) of the projects which consume rocm-cmake have their own "install" or "install.sh" scripts to invoke cmake, with different conventions (do I use '-k' to set CMAKE_BUILD_TYPE to RelWithDebInfo, or something else or does the script not allow this to be set at all?). Setting the type of packaging desired is something that should be a choice of the build infrastructure, not the project developer.

Why not set CPACK_GENERATOR to the packages you want when you call cmake?

Seems like the code will take care of this. macro checks for  CPACK_GENERATOR is not SET.  This should make the code better if user fail to provide right value. Since some of the packaging step particularly for debug-symbols packaging do not work well without additional tools across OS, this should help to make it work with default set of tools in respective OS. Also this help to speed up the build on our CI that has different build profiles for each OS by avoiding unnecessary packaging step and throwing away that package!

If the calls to cmake were in a central place, where we could add flags to set the packaging type with ease then we wouldn't need to do this.

I see, I thought there was a cmake toolchain that was passed to all projects.

If CPACK_GENERATOR is set, then it is honored. If it is not set, but PKGTYPE is set then that is used, otherwise use the existing code.

If we are going to provide a env variable workaround for our install.sh scripts, I think it should at least be named CPACK_GENERATOR to make clearer what its setting in cmake.

As it is most (all) of the projects which consume rocm-cmake have their own "install" or "install.sh" scripts to invoke cmake, with different conventions (do I use '-k' to set CMAKE_BUILD_TYPE to RelWithDebInfo, or something else or does the script not allow this to be set at all?).

Well not all projects. MIGraphX and MIOpen doesnt, although it uses rbuild, you can pass cmake flags and toolchain files directly to rbuild, or just use rbuild for dependencies and then invoke cmake directly.
However, these custom install.sh scripts should be gotten rid of since you can't pass cmake flags nor toolchain file nor invoke cmake directly.

Seems like the code will take care of this. macro checks for CPACK_GENERATOR is not SET.

Thats not really my question. The question is why do we want to set a PKGTYPE env variable instead of setting the CPACK_GENERATOR variable?

However, these custom install.sh scripts should be gotten rid of since you can't pass cmake flags nor toolchain file nor invoke cmake directly.

I agree with this. Many external users skip the install.sh script and invoke CMake directly. It's fine to have a helper install.sh script for component developers to put their commonly used options in a shared place, but the important interface is actually the direct CMake interface. IMO, invoking CMake directly should be the canonical way to build each library, and it's how the libraries should be built and tested by our tooling. (I'm not sure every stakeholder agrees with me, but that's what I think.)

If we are going to provide a env variable workaround for our install.sh scripts, I think it should at least be named CPACK_GENERATOR to make clearer what its setting in cmake.

The point is to provide a reasonable default. The CI needs to know the packaging type for other purposes, for example todecide which files to archive. You can argue for a different name, but I think that tying the general purpose name to CPACK is wrong.  I suggest if we already need a general purpose variable then we should use it. There are discussions about dropping cpack due to its conformance ( e.g. the packages it produces have non standard names) and performance ( e.g. it doesn't use multiple cores for compression) problems.  I would not be adverse to adding CPACK_GENERATOR as an additional environment variable, although I see this as adding an unneeded extra choice. If we do add CPACK_GENERATOR then the logic should be to use it in preference to PKGTYPE if both are specified.

The problem with PKGTYPE it just seems arbitrary and doesn't have ROCM_ prefix to avoid name conflicts. Since the goal is to set the CPACK_GENERATOR I would prefer the env variable to be named the same.
I dont see how dropping cpack is relevant here.

@pfultz2 The CI already sets PKGTYPE, which is why I proposed it here. Yes of course it is arbitary. Will you approve this PR if I change the code to use ROCM_PKGTYPE and change the CI to match?

There are 2 major reasons for using functions/macros in high level code. One is to reduce typing and errors. The more import one is information hiding. It enables you to have a function like rocm_create_package whose name tells you what it is going to do, but not how it is going to do it. This allows you to change the implementation if you want, which is a very good thing.
Unfortunately the original version  of this didn't set up passing a parameter to specify what kind of package was required. Instead it unconditionally decided to create deb files and if it found a makensis program it would create a windows installer as well. These choices were not something the user could alter. Later code was added to create rpm files if a rpmbuild program was found, and after that code was added to always create zip and tar and only create deb files if dpkg was found.
As there was no parameter for saying what kind of package was requested, the CMakeLists.txt files which called this had no incentive to worry about what kind of packages were being generated, they just took what they were given. Likewise the scripts which called cmake had no incentive to request only particular types of packages. The build environment could of course ensure there were no dpkg or rpmbuild to influence things but this is an excessive need, and doesn't address tarball creating which is handled internally by cpack.
The design, where you look for programs in the build environment and based on that decide what kind of packages to produce makes it seductively easy to start using, it all appears to "just work". However it is fragile. In particular if I have a program rpmbuild on my Ubuntu machine then it will produce rpm files even if I don't want them. Worse still is if the rpmbuild program doesn't work, then the build will fail.
The intent of this patch is to allow an environment variable that will allow the build environment to say what kind of packages are wanted, so a Ubuntu build environment can say that it wants just deb files and not tar, rpm or nsis files. Likewise a CENTOS build environment can ask for just rpm files even if there is a dpkg program in it.
If the callers of rocm_create_package have explicitly asked for some particular type then that is honored, otherwise give the build environment a chance to say what it can provide, otherwise fall back to the existing code.
The reason for not calling the environment variable CPACK_GENERATOR is for information hiding, just as the rocm_create_package wasn't called rocm_create_package_using_cpack to hide the information that it is using cpack. This is particularly relevant as we are considering changing away from cpack.  If we do change to use different tools for packaging then the hope is that we can just rewrite rocm_create_package to use these different tools. Probably at that stage we would add additional parameters to rocm_create_package to specify the type(s) of packages desire, but it still makes sense for the build environment to provide an environment variable to provide a good default. Having it called CPACK_GENERATOR when we are not using cpack and wouldn't be using it to set the CPACK_GENERATOR cmake variable would be confusing. We could start out with this name now and then rename it at that time but we  wouldn't want to have to rewrite all the CMakeLists.txt files which use the function and the scripts which call cmake to handle this internal implementation change.

Should we link this to the OS detection capabilities in rocm-cmake and set the package type appropriately based on OS?

The reason for not calling the environment variable CPACK_GENERATOR is for information hiding, just as the rocm_create_package wasn't called rocm_create_package_using_cpack to hide the information that it is using cpack. This is particularly relevant as we are considering changing away from cpack. If we do change to use different tools for packaging then the hope is that we can just rewrite rocm_create_package to use these different tools. Probably at that stage we would add additional parameters to rocm_create_package to specify the type(s) of packages desire, but it still makes sense for the build environment to provide an environment variable to provide a good default. Having it called CPACK_GENERATOR when we are not using cpack and wouldn't be using it to set the CPACK_GENERATOR cmake variable would be confusing. We could start out with this name now and then rename it at that time but we wouldn't want to have to rewrite all the CMakeLists.txt files which use the function and the scripts which call cmake to handle this internal implementation change.

While I largely agree with up until this point, I don't think this is a very strong argument. The libraries that use rocm-cmake already have places where they interact with cpack. Switching to a different system is going to take more than just swapping out the implementation of rocm_create_package.
Personally, I like your ROCM_PKGTYPE suggestion more than CPACK_PKGTYPE because it makes it very clear to me that the variable is something that we have invented, and that I should be looking through our code to learn more (not the cpack documentation).

Should we link this to the OS detection capabilities in rocm-cmake and set the package type appropriately based on OS?

If I understand the question then I think the answer is "no". I see these as only loosely related. The idea of cmake and related utilities is to provide a cross-platform way of building. Cpack can build a deb file without external tools so could build one on Windows. It can also build a tar file. On the other hand it can't build an rpm without the rpmbuild program.
I think the list of package types to be built is something that the user should set, not the author of the rocBLAS CMakeLists.txt file and not the author of the rocm-cmake ROCMCreatePackage.cmake file although both of them are welcome to provide defaults. If a user wants a tarball then they should get one. If they don't want one then we can save time and disk space by not creating one.
I don't see a way to determine based on the OS to decide if a user wants a tarball. Likewise if the user wants a deb package created or not.

While I largely agree with up until this point, I don't think this is a very strong argument. The libraries that use rocm-cmake already have places where they interact with cpack. Switching to a different system is going to take more than just swapping out the implementation of rocm_create_package.

I agree. I like to imagine I will get to live in an environment where everything is well designed, future requirements are anticipated and there are no bugs. Originally this macro ended with the include of cpack, so it was easier to imagine that all that was needed was to swap out the implementation of rocm_create_package, but those times have passed. The open question is if we can recapture them?

Should we link this to the OS detection capabilities in rocm-cmake and set the package type appropriately based on OS?

No, since we could be cross-compiling.

A different, but related question:
How do you folks feel about defaulting CPACK_DEBIAN_COMPRESSION_TYPE to xz? For large libraries, our DEB packages are ~2.5x the size of our RPMs because the former defaults to gzip and the latter to xz. The installation of xz packages has been supported since Ubuntu 14.04, so I think the only drawback is the time to generate the package, which can be mitigated with multi-threaded compression controlled by CPACK_THREADS


Databinding fails when helper method is called "url"

When an element defines a method:
url: function (name) {
  return 'something/'.concat(name);
}

And the template uses that method for databinding like:
<template>
  <iron-ajax url="[[url('abc')]]">
</template>

The resulting value on iron-ajax will be undefined when the app was built using polybuild whereas it works fine in the non-built version.
Changing url to something else like createUrl solves the issue.

Apparently the url() issues al derived from our server-side parser.


Part 2: Update all remaining Python files with ASF license

This is "part 2" of the Python license header update.  In most cases, I also brought each file into PEP8 compliance.  The files include:
Part 2:
./openwhisk/ansible/callbacks/logformatter.py
./openwhisk/core/actionProxy/actionproxy.py (updated to PEP8)
./openwhisk/core/actionProxy/invoke.py (updated to PEP8)
./openwhisk/core/pythonAction/pythonrunner.py (updated to PEP8)
./openwhisk/core/swift3Action/buildandrecord.py
./openwhisk/core/swift3Action/swift3runner.py
./openwhisk/tests/dat/actions/hello.py
./openwhisk/tests/dat/actions/malformed.py
./openwhisk/tests/dat/actions/niam.py
./openwhisk/tests/dat/actions/stdenv.py
./openwhisk/tests/dat/actions/timedout.py
./openwhisk/tests/dat/actions/unicode.py
./openwhisk/tests/dat/blackbox/badaction/runner.py
./openwhisk/tools/admin/wskprop.py
./openwhisk/tools/admin/wskutil.py
./openwhisk/tools/db/replicateDbs.py
./openwhisk/tools/build/checkLogs.py (updated to PEP8)
./openwhisk/tools/health/monitorUtil.py
./openwhisk/tools/json/validate.py

I appreciate you did this and applied pep8. But I am not a fan of the 79 character limit - I find it silly (it's 2017, we don't print code to read, we have high res monitors, ...) and think longer lines are actually easier to read in some cases.
This project is not a python project - we have a tiny amount of python code.
Can we at least relax the line limit to 127 characters as in the Flake8 linter?
I'm not going to make a bigger deal about it; I'll relunctlantly relent and move on regardless.

Do we need copyright headers on the test assets? (We don't have them for other tests assets, they are small. Do we have to apply/assert copyright over every thing? In other words will you be adding the license header to all the other test assets in the future as well? (This is why we exempt tests from scanCode otherwise).

@rabbah i debated putting headers in test files, but it made sense as long as there was a line of code.  The only oddball was then the "bad comment" test (i.e., "// xxxx"), but why leave just one file out...  perhaps the test will be beefed up to test a bad comment midst actual valid code.

wont you whave to exclude the bad comment test? You can add the license there the test should still pass. But why not exclude this entire tests/dat directory from scanning - there is nothing of value here and these headers just add annoying overhead. It's also inconsistent as I noted there are far more tests in nodejs which have no license headers.
In other words either we should exclude all of tests/dat or apply the policy to all files consistently.

@rabbah currently, scan code only excludes by whole directory (and anything below it).  Am not addressing per-file (as this is a new requirement to me as of this discussion), would be an enhancement going forward.  Hopefully, having a license header in a file or two (where it does not much matter if it has one or not) should not be a showstopper for general license checking for Python.

excludes only by whole directory

so are we keeping the exclusion of tests/dat?

in case it's not clear: my preference is to continue excluding tests/dat from scans and to not put headers in those assets.

@rabbah I would like to have as few directory exclusions as possible (hopefully only "bin") after we add licenses to other files in same subdir.

continue excluding tests/dat

let's continue to exclude this continue excluding tests/dat
I consider this directory a test "fixture" meaning input params for test.
I don't consider them source code that test the product that requires conventions, we could have input files that don't follow convention on purpose to see if openwhisk handles them correctly, can I have a python script that has a line of 400 characters and does openwhisk handle this? well I could create a file in tests/dat.

We can exclude tests/dat, but it seems odd to have to strip out license headers if the tests have IP (very little for sure); however, if you want me to I can (just delete headers for that directory) as I really want to get this merged so I we can actually start scanning Python...

test/dat/*.py have license headers removed in PR now, left any PEP8 changes (incl. docstring adds).

remind me again why can't python scripts be located in /tests/dat/ and have a license header?
Can't we just exclude /tests/dat/ from nay scanning, and we don't care if the scripts have a header or not, if they have one OK if they don't OK also.

remind me again why can't python scripts be located in /tests/dat/ and have a license header?

there's no such restriction - my point is about consistency and that these tests assets dont need it in general.
i think we've belabored the point - since @mrutkows has removed them already i suggest to accept the pr in its current state.

@csantanapr they can both have a license header and be excluded.  The discussion seemed to lean towards why have them at all it seemed to me.  Can we squash/merge if this is going to a longer discussion that has little effect on running code?

My new scanCode.py shows optionally details of excluded files. If we exclude the tests/dat it appears we skip 78 files.  @csantanapr
Scan excluded (79) files:
Excluded file: ./tests/dat/actions/python-zip/main.py
Excluded file: ./tests/dat/actions/initforever.js
Excluded file: ./tests/dat/actions/unicode.js
Excluded file: ./tests/dat/blackbox/badproxy/Dockerfile
Excluded file: ./tests/dat/actions/invalidInput2.json
Excluded file: ./tests/dat/actions/unicode/src/main/java/Unicode.java
Excluded file: ./tests/dat/actions/invalidInput4.json
Excluded file: ./tests/dat/actions/hello.js
Excluded file: ./tests/dat/actions/sort.js
Excluded file: ./tests/dat/actions/invoke.swift
Excluded file: ./tests/dat/actions/malformed.js
Excluded file: ./tests/dat/actions/malformed.py
Excluded file: ./tests/dat/actions/httpGet.swift
Excluded file: ./tests/dat/actions/python.zip
Excluded file: ./tests/dat/actions/echo.json
Excluded file: ./tests/dat/actions/cat.js
Excluded file: ./tests/dat/actions/applicationError.js
Excluded file: ./tests/dat/actions/blackbox.zip
Excluded file: ./tests/dat/actions/hello.swift
Excluded file: ./tests/dat/actions/runexit.js
Excluded file: ./tests/dat/actions/hello.py
Excluded file: ./tests/dat/blackbox/badproxy/build.gradle
Excluded file: ./tests/dat/actions/initexit.js
Excluded file: ./tests/dat/blackbox/badaction/Dockerfile
Excluded file: ./tests/dat/actions/wc.js
Excluded file: ./tests/dat/actions/argCheck.js
Excluded file: ./tests/dat/actions/stdenv.py
Excluded file: ./tests/dat/actions/niam.swift
Excluded file: ./tests/dat/blackbox/badaction/README.md
Excluded file: ./tests/dat/actions/split.js
Excluded file: ./tests/dat/actions/invalidInput1.json
Excluded file: ./tests/dat/actions/zippedaction.zip
Excluded file: ./tests/dat/apigw/testswaggerdoc1
Excluded file: ./tests/dat/actions/helloJava.jar
Excluded file: ./tests/dat/actions/niam.py
Excluded file: ./tests/dat/actions/wcbin.js
Excluded file: ./tests/dat/actions/echo.js
Excluded file: ./tests/dat/actions/timeout.js
Excluded file: ./tests/dat/actions/unicode/build.gradle
Excluded file: ./tests/dat/blackbox/badaction/build.gradle
Excluded file: ./tests/dat/actions/empty.js
Excluded file: ./tests/dat/actions/head.js
Excluded file: ./tests/dat/actions/asyncError.js
Excluded file: ./tests/dat/actions/word_count.json
Excluded file: ./tests/dat/apigw/testswaggerdocinvalid
Excluded file: ./tests/dat/actions/python-zip/greet.py
Excluded file: ./tests/dat/actions/sizedResult.js
Excluded file: ./tests/dat/actions/helloOpenwhiskPackage.js
Excluded file: ./tests/dat/.DS_Store
Excluded file: ./tests/dat/actions/unicode.jar
Excluded file: ./tests/dat/actions/validInput2.json
Excluded file: ./tests/dat/blackbox/badproxy/README.md
Excluded file: ./tests/dat/actions/ping.js
Excluded file: ./tests/dat/actions/validInput1.json
Excluded file: ./tests/dat/actions/helloSwift.zip
Excluded file: ./tests/dat/actions/timedout.jar
Excluded file: ./tests/dat/actions/seq_echo_word_count.json
Excluded file: ./tests/dat/actions/countdown.js
Excluded file: ./tests/dat/actions/niam.js
Excluded file: ./tests/dat/actions/seq_type_2.json
Excluded file: ./tests/dat/apigw/testswaggerdoc2
Excluded file: ./tests/dat/actions/unicode.py
Excluded file: ./tests/dat/actions/issue-1562.js
Excluded file: ./tests/dat/blackbox/badaction/runner.py
Excluded file: ./tests/dat/actions/helloJavaDefaultPackage.jar
Excluded file: ./tests/dat/actions/invalidInput3.json
Excluded file: ./tests/dat/actions/helloPromise.js
Excluded file: ./tests/.tox/bad_multple.go
Excluded file: ./tests/dat/actions/unicode.swift
Excluded file: ./tests/dat/actions/printParams.js
Excluded file: ./tests/dat/actions/helloDeadline.js
Excluded file: ./tests/dat/actions/TimedOut.java
Excluded file: ./tests/dat/actions/openFiles.js
Excluded file: ./tests/dat/actions/helloContext.js
Excluded file: ./tests/dat/actions/dosLogs.js
Excluded file: ./tests/dat/actions/emptyJSONResult.js
Excluded file: ./tests/dat/actions/trigger.swift
Excluded file: ./tests/dat/actions/helloAsync.js
Excluded file: ./tests/dat/actions/timedout.py


Add voucher type to TaxableObject

I want to merge this change because it adds voucher type to TaxableObject
More context: https://linear.app/saleor/issue/SHOPX-325/bug-discounts-field-behaviour-on-calculatetaxes-event-is-inconsistent

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations

Docs

[ ] Link to documentation:

Pull Request Checklist

[ ] Privileged queries and mutations are either absent or guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migrations are either absent or optimized for zero downtime
[ ] The changes are covered by test cases
[ ] All new fields/inputs/mutations have proper labels added (ADDED_IN_X, PREVIEW_FEATURE, etc.)
[ ] All migrations have proper dependencies
[ ] All indexes are added concurrently in migrations
[ ] All RunSql and RunPython migrations have revert option defined

To be reworked, closing this one for now.


chore(main): release 0.2.5

:robot: I have created a release beep boop
0.2.5 (2024-11-24)
Bug Fixes

param name of util function (for linter) (#270) (b840e3b)

Dependency Updates

deps: update all non-major dependencies (#266) (43b9fbc)
deps: update all non-major dependencies (#269) (0e6b008)
deps: update all non-major dependencies to v0.31.3 (#264) (7557f89)
deps: update build digest to 5ffe724 (#263) (112c405)
deps: update build digest to dd09b58 (#267) (57f34c7)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v0.2.5
:sunflower:


challenge fail: 18: bad-txns-joinsplit-requirements-not-met

My secure node‘s status is up,  but chanllenge result is always failed, report error reason: "18: bad-txns-joinsplit-requirements-not-met"
2018-01-27 07:13:07 GMT -- Authenticated. Nice to see you connected again.
2018-01-27 07:13:07 GMT -- Updated server list
2018-01-27 07:13:07 GMT -- Stats: send initial stats.
2018-01-27 07:13:07 GMT -- Down time logged. See server.
2018-01-27 07:13:07 GMT -- Down time logged. See server.
2018-01-27 07:13:07 GMT -- Down time logged. See server.
2018-01-27 07:13:08 GMT -- Cert check: valid=true.  Hostname yczzencash.top matches CN yczzencash.top

I you have not received help from Discord with this you can try stopping zend and restarting with the -rescan flag.
zen-cli stop

wait about 10 seconds
zend -rescan


Chaining stamp calls not working as I expected

Hi.
Am I missing something? Yes, probably.. please tell me.
setUserData is defined in User.methods() and looks like this:
setUserData: function(userData) {
  console.log(userData)
  this.data = userData;
}

Making these two calls separately works fine:
var user = User();
user.setUserData(result);

But chaining them doesn't work. Writes to console, but not to "this.data":
var user = User().setUserData(result);

I suspect that "this" references something else at this stage. But what and why?

I'm not sure what you mean by "doesn't work", but if you mean that user is not a stamp instance, that's because you didn't return this (or anything, for that matter) in your setUserData method.
If it's not this, can you provide more info?

But of course..
I suspected that I'd make a fool out of myself =)
Thank you!

No worries @michaelswe
You're always welcome asking any questions.
Cheers


Change all occurences of Murder.Core.Vector2 into System.Numerics.Vector2

And create all appropriate helpers as extensions.
Using System.Numerics.Vector2 will allow us to use hardware acceleration with vector math and will make things easier to integrate with other libraries.

This project looks awesome! I noticed this because of the "good first issue" tag. I've never contributed to open source before but I've just used C# in my day job for two years. I'll give it a whirl if that's ok.

Sounds great :) Feel free to ask for help here or on the discord if you need


FormRequest SanitizesInput trait adds attribute when they are not present

The sanitizer applies the filter on inputs even if they are not present in the request which breaks the validation logic. There can be a workaround but I think the default behavior should be only applying filters on the present attributes and maybe add an extra filter that fills the nonexistent attributes if needed (e.g. defaul:{value})

I ran into problems with this as well well, example:

We have 5 sanitize filters: "Cats:String, Dogs:Number, Mice:Number, Wolves:Uppercase, Sheep:Lowercase"
On the request we have 3 inputs: "Cats, Dogs, Sheep"
Final result: "Cats, Dogs, Mice(null), Wolves(null), Sheep"

I got around this by removing the newly added inputs.  This happens before they are sent to the validator:
public function validateResolved()
{
    $original_input_keys = $this->keys();
    $this->sanitize();

    $keys_to_remove = $this->except($original_input_keys);
    foreach ($keys_to_remove as $key => $value) {
        $this->offsetUnset($key);
    }

    parent::validateResolved();
}

Has anyone made any progress on this?

I removed the Waavi Sanitizer package and rolled my own solution that was tailored to our specific application.  I did keep the same concept of how model sanitizations are defined as I really liked how it tied in with the validation rules.

Is there any progress with regards to this issue? I strongly believe that filters should only be applied to inputs that have been passed in the request instead of retuning null for inputs that haven't been passed through.


Add the ability to multiplex multiple ApplicationSessions over a single transport

First of all, thank you for creating autobahn-python (and Crossbar).  Autobahn-python is a great library and has been very helpful to our company. As we've been using autobahn-python, we've been investigating how to set ourselves up to be able to scale with increased usage.  We believe we have some good options with being able to increase servers that should take care of most problems.  Additionally, we want to make sure that we are able to fully utilize any servers that we are running.
We currently have the following setup:

Devices open a connection to a python web server.
The web server then uses autobahn-python to create a connection to Crossbar for each device that connects to the web server (using autobahn.asyncio.wamp.ApplicationSession and autobahn.asyncio.websocket.WampWebSocketClientFactory).

Given this model, we expect the number of connections from each python web server to Crossbar to grow to the tens of thousands. Since these are all essentially connections that come from the same place and go to the same place, it feels excessive to need tens of thousands of open TCP connections to maintain the ApplicationSessions.
Thus, this issue is a request to consider adding support for a single transport to be able to support multiple ApplicationSessions.
Digging through the autobahn-python codebase, it looked like the ApplicationSession was pretty well isolated from the underlying transport. It also felt like it is possible to write a version of a transport that manages allowing multiple ApplicationSessions to join the transport.
Are there plans to add support for allowing multiple sessions over a single transport?  Are there any issues or design decisions that would prohibit this request?

@rrueth Are your components written in Python using the Twisted framework? If so you can run multiple ApplicationSession instances in a single Container worker and they will share the connection to the router.
If you are working with asyncio components then this Containers workers do not currently support asyncio but please see https://github.com/crossbario/crossbar/issues/1107 for progress on implementing asyncio Container workers.

@OOPMan thanks for the reference to #1107!  We are using asyncio with uvloop, but I'll look more into containers to understand how they work.

@rrueth Well, Containers currently only support components written using Twisted but as per the link support for asyncio Containers should be coming in the future.

Containers currently only support Twisted components, and containers will also run over multiple connections - they do not use some magic multiplexed transport.
So actually, I think what you guys want are two things:

asyncio container workers
multiplexed WAMP transports

Right?

While I mostly agree that it "feels" wrong to have 10k connections between the same two endpoints, there are also going to be issues when trying to multiplex over a single (TCP) connection for this. So, I'm curious if you've done any testing and if so what actual problems arise?
When multiplexing, you will lose the existing effort that has gone into TCP fair-queuing, backpressure and the like. For example, if one of your clients is really slow, what are the effects on the Web server and/or crossbar and the throughput and latency of the other clients?
It's not at all obvious to me that running say 10k connections over 10k TCP streams is definitely worse than 10k "multiplexed logical streams" over one TCP stream. Certainly I'd expect the separate-stream case to use more memory, but that might be quickly eaten up with buffering or bad experiences for other users. Dividing, say, 1GiB of RAM up between 10k connections gives each one a ton of memory to "waste" (around 100KiB).

@meejah makes some very good points and it seems that I also misunderstood the question somewhat. I'm guessing that Crossbar clustering would prove useful for alleviating concerns in this regard as well?

The most-satisfying answer would be "don't worry, crossbar can support 100k's of connections no problem". That is, implementing better overall horizontal scaling of single realms (as @oopman hints at above).
Currently, you can get some amount of this type of scaling by placing users on different realms -- each realm is operated by its own (sub-) process inside crossbar.

Thanks for the clarification about containers and connections @oberstet.  @meejah, I agree with your assessment that multiplexing sessions over a single connection does not necessarily result in a better experience than using a individual TCP connection for each session. I also agree that I believe that we can horizontally scale both our servers running crossbar and our python servers that connect to crossbar.
We have not run many tests around where our limits are yet with Crossbar (i.e. how much load can we support per python server and per Crossbar server), and we probably won't get be able to for another month or so. I raised this request after chatting with you, @meejah, for a bit in the IRC channel the other day to start a discussion and understand if this was a feasible request, if there was already a solution or something in the works, and what the issues might be with tackling this request. Primarily the request comes from two areas:

Ensuring that we can maximize resource utilization (i.e. maximize the number of devices that can contact a single one of our python servers while minimizing the number of python and Crossbar servers that we need to run).  @meejah, the answer may be that maintaining a 1:1 relationship between sessions and TCP connections is currently the best approach.
We've seen issues before (not with crossbar nor autobahn-python) where we ran into issues with having too many open connections between our python servers and other endpoints (e.g. zookeeper, mysql, redis, etc.).  This isn't the exact same problem here, just related.

Mostly, I wanted to understand our options and where autobahn-python is headed to make sure that we're best suited for handling increasing loads.

@rrueth we are absolutely interested in having good stories around different types of scaling. Having a single logical "crossbar router" that spans many cores and machines is definitely on the roadmap (http://crossbario.com/products/roadmap/).
When you do load-testing we'd also of course be keen to see the results :)
If you are interested in commercial support (e.g. seeing particular features implemented faster) please make contact via http://crossbario.com/company/contact/

Mostly, I wanted to understand our options and where autobahn-python is headed to make sure that we're best suited for handling increasing loads.

Here is the short story:

scaling up (making use of multiple cores) and out (making use of multiple machines) of  app components: we consider this mostly solved in CB already: https://github.com/crossbario/crossbar-examples/tree/master/scaling-microservices
scaling up/out the CB routing core itself: this will come (as part of Crossbar.io Fabric) in two steps: a) introducing a new proxy worker type and b) adding router-to-router messaging
the first line of load-balancing (towards the proxy workers) is either coming from one or more L4 LBs or directly from DNS (round-robin/HA).

Now, the communication between proxy workers and router workers, and between different router workers will need to transport many sessions.
And here, transport many session about one underlying TCP is where I currently think this feature (many sessions over one transport) make most sense, and can be of real benefit.
However, due to the specific additional requirements for communication between proxy-router and router-router, this feature could end up not being part of AB, but CB Fabric only.

where we ran into issues with having too many open connections

Systems that spawn one OS process per incoming client connection will run into issues with large connections numbers obviously. Eg this applies to PostgreSQL. To counter that, there are things like PL/Bounder and PL/Proxy.
Crossbar.io doesn't have that issue. I have tested CB on my notebook with 200k connections. No problem. Of course if those 200k connections will do a lot of messaging, then this will be the limit (CB on a single Xeon core can route calls at roughly 50k routed calls per second).
The messaging rate it much more interesting as a limit for CB rather than connection count.
Given enough RAM and a decent NIC and kernel, you should be able to keep 1M mostly idle connections on a single box.
However, with 1M connections, and only doing WebSocket ping/pong for heartbeating at say once every 10s (eg http://crossbar.io/docs/WebSocket-Options/#production-settings), this already means 100k pings sent and 100k pongs received per second.
Anyways, hope those lines shed some light on the topic ..


move docker files to root

🤷♂

mmm ? isn't it more cluttered like this ?

yea, but I could not get the docker/build-push-action action to work without doing this, pull request welcome

@larshp do you remember what exactly failed ? Or maybe a link to a build log ... I'll try to fix

nah, just try again, I'll give you access to merge PRs if you dont already have it


Textual analysis

Basic textual analysis of the textual data (titles, captions, comments), including:
a) top words
b) top words filtering out stopwords
c) top nouns, adjectives, or verbs

This could reuse the preprocessing with addition of c)


Update global_agent_helper_prompt.md

_@dust in private Slack channels
_assistants search bar

Closing and reopening another with the linting done


fix NineSlice with resolution

Somehow, we didn't use resolution for NineSlicePlane canvas version, and fix is easy. However I dont have fiddle for it, people just reported this problem and solution to me.
Theoretically, that's how it suppose to work.

Thanks @ivanpopelyshev


macsec: add base_iface property

MACsec needs a base_iface to be created. show the base_iface for its parent.

MACsec is not working anymore on github action. The test is panicking when finding the interface created.

Macsec test case passed after my extra patch. The remaining CI failure is caused by ethtool which is unrelated to current PR. I will fix it later.


Uninstall does not clean up all local files

Running the 'uninstall' option from the GUI leaves this directory behind on Windows:
C:\Users\Administrator\AppData\Local\chefdk
This caused breakage when we attempted to uninstall and reinstall, when old settings were still in that directory.  The user should be made aware that they have to delete this if they want a truly 'fresh' install.

Closing this as dupe of #871 as it's effectively the same thing.


CeskaTelevize: Some videos give JSON metadata ERROR: No video formats found

Checklist

[x] I'm reporting a broken site support
[x] I've verified that I'm running youtube-dl version 2021.06.06
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar issues including closed ones

Verbose log

$ youtube-dl --verbose https://www.ceskatelevize.cz/ivysilani/137403-bohousuv-syn/27432006218
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--verbose', 'https://www.ceskatelevize.cz/ivysilani/137403-bohousuv-syn/27432006218']
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, pref UTF-8
[debug] youtube-dl version 2021.06.06
[debug] Python version 3.9.5 (CPython) - Linux-3.18.71-perf+-armv7l-with-libc
[debug] exe versions: none
[debug] Proxy map: {}
[CeskaTelevize]<PHONE_NUMBER>8: Downloading webpage
[CeskaTelevize]<PHONE_NUMBER>8: Downloading JSON metadata
[CeskaTelevize]<PHONE_NUMBER>8: Downloading JSON metadata
[CeskaTelevize]<PHONE_NUMBER>8: Downloading JSON metadata
[CeskaTelevize]<PHONE_NUMBER>8: Downloading JSON metadata
ERROR: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/data/data/com.termux/files/usr/lib/python3.9/site-packages/youtube_dl/YoutubeDL.py", line 815, in wrapper
    return func(self, *args, **kwargs)
  File "/data/data/com.termux/files/usr/lib/python3.9/site-packages/youtube_dl/YoutubeDL.py", line 836, in __extract_info
    ie_result = ie.extract(url)
  File "/data/data/com.termux/files/usr/lib/python3.9/site-packages/youtube_dl/extractor/common.py", line 534, in extract
    ie_result = self._real_extract(url)
  File "/data/data/com.termux/files/usr/lib/python3.9/site-packages/youtube_dl/extractor/ceskatelevize.py", line 201, in _real_extract
    self._sort_formats(e['formats'])
  File "/data/data/com.termux/files/usr/lib/python3.9/site-packages/youtube_dl/extractor/common.py", line 1374, in _sort_formats
    raise ExtractorError('No video formats found')
youtube_dl.utils.ExtractorError: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

Description

Some but not all videos give the above error. For example, the first movie in the series, Bohous, downloaded fine.

DRM protected.


Creating a new criteria fails

Redirects to a 101
http://localhost:3000/en/assignments/2/flexible_criteria/new?id=2

When I didn't have internet, I happened to fix this issue. Where are you on that ? I fixed several bugs in one branch.

This ticket is the same as #436

Sorry for the late reply. I haven't touched its code as I've been busy working on refactoring the functional tests. Nice work if you managed to fix it. I'll move on to another issue.

Are you sure this is fixed? I can't add any criteria at all. Not sure if the bug is meant for uploading/creating entirely new criteria or just adding a single criterion.
When running a local server, adding a flexible criterion gives me a 404 error message in terminal but doesn't actually render the 404 page. :/ Testing rubric gives me a "type error - null".
I went to Assignments -> A1 -> Marking Scheme -> Add Criterion -> Enter name and click save.

I'll be working on this issue

Duplicate of #607. The problem is that an RJS "Sortable not found" error was thrown which is because some drag and drop libraries were not imported