Consider disk space when schedule replica

https://github.com/longhorn/longhorn/issues/4185

Test result based on https://github.com/longhorn/longhorn-tests/pull/1009 - https://ci.longhorn.io/job/private/job/longhorn-tests-regression/1586/

IMO, it's better to add a setting to enable this feature. Not sure if some users would prefer to use up some disks first and reserve some big empty disks for large volumes.

Question: how do users possibly prefer using up some disks first if the disk selection is random from disk candidates?

Currently, users can achieve that by disabling the scheduling for the reserved disk.
Okey, the same thing can be applied even with this PR merged. We can add the setting later.

@c3y1huang in Longhorn v1.4.0 the replicas does not seem to be scheduled on disks with the most usable space.
Eg:
node 1:

disk 1 - usable space 1TB out of 4TB
disk 2 - usable 1 TB out of 4TB
node 2
disk 1 - usable space 1TB out of 4TB
disk 2 - usable 1 TB out of 4TB
disk 3 - usable 1 TB out of 4TB
disk 4 - usable 3 TB out of 4TB
node 3
disk 1 - usable space 1TB out of 4TB
disk 2 - usable 1 TB out of 4TB
disk 3 - usable 1 TB out of 4TB
disk 4 - usable 3 TB out of 4TB

We have one volume, attached to node 3 with replication factor of 2.
After implementing this issue, the master volume should be scheduled on node 3 disk 4, and the replica should be scheduled on node 2 disk 4.
In our case, the replica is scheduled on node 1 disk 2, the node 2 disk 4 remaining unused.
I've tried to manually delete the replica created on node 1 disk 2 but the replica was re-scheduled on the same node and disk.
The algoritmh implemented here should also take into consideration the available disks on another nodes.

@c3y1huang in Longhorn v1.4.0 the replicas does not seem to be scheduled on disks with the most usable space. Eg: node 1:

disk 1 - usable space 1TB out of 4TB
disk 2 - usable 1 TB out of 4TB
node 2
disk 1 - usable space 1TB out of 4TB
disk 2 - usable 1 TB out of 4TB
disk 3 - usable 1 TB out of 4TB
disk 4 - usable 3 TB out of 4TB
node 3
disk 1 - usable space 1TB out of 4TB
disk 2 - usable 1 TB out of 4TB
disk 3 - usable 1 TB out of 4TB
disk 4 - usable 3 TB out of 4TB

We have one volume, attached to node 3 with replication factor of 2. After implementing this issue, the master volume should be scheduled on node 3 disk 4, and the replica should be scheduled on node 2 disk 4.
In our case, the replica is scheduled on node 1 disk 2, the node 2 disk 4 remaining unused.
I've tried to manually delete the replica created on node 1 disk 2 but the replica was re-scheduled on the same node and disk.
The algoritmh implemented here should also take into consideration the available disks on another nodes.

All eligible nodes should be considered as usual, what changes here is to figure out a suitable disk with the most available space for the new replica. Probably need to check why the node has not been selected.
@iosifnicolae2 Could you help provide the support bundle?
/scheduler/replica_scheduler.go#L60-L100
	// get all hosts
	nodesInfo, err := rcs.getNodeInfo()
	if err != nil {
		return nil, nil, err
	}

	nodeCandidates, multiError := rcs.getNodeCandidates(nodesInfo, replica)
	if len(nodeCandidates) == 0 {
		logrus.Errorf("There's no available node for replica %v, size %v", replica.ObjectMeta.Name, replica.Spec.VolumeSize)
		return nil, multiError, nil
	}

	nodeDisksMap := map[string]map[string]struct{}{}
	for _, node := range nodeCandidates {
		disks := map[string]struct{}{}
		for fsid, diskStatus := range node.Status.DiskStatus {
			diskSpec, exists := node.Spec.Disks[fsid]
			if !exists {
				continue
			}
			if !diskSpec.AllowScheduling || diskSpec.EvictionRequested {
				continue
			}
			if types.GetCondition(diskStatus.Conditions, longhorn.DiskConditionTypeSchedulable).Status != longhorn.ConditionStatusTrue {
				continue
			}
			disks[diskStatus.DiskUUID] = struct{}{}
		}
		nodeDisksMap[node.Name] = disks
	}

	diskCandidates, multiError := rcs.getDiskCandidates(nodeCandidates, nodeDisksMap, replicas, volume, true)

	// there's no disk that fit for current replica
	if len(diskCandidates) == 0 {
		logrus.Errorf("There's no available disk for replica %v, size %v", replica.ObjectMeta.Name, replica.Spec.VolumeSize)
		return nil, multiError, nil
	}

	// schedule replica to disk
	rcs.scheduleReplicaToDisk(replica, diskCandidates)

@innobead done. I've sent the support bundle to<EMAIL_ADDRESS>from<EMAIL_ADDRESS>

Thanks, @iosifnicolae2 . @c3y1huang will check.

I've deleted the replica two times from the node under disk pressure and it seems that now was scheduled on another node.
But, as you can see from the support bundle, we have disks which have 90% unused space and dedicated-worker-1 node has only 30% available space.
Also, it might be awesome if we can schedule a cron job for moving replicas as they grow in size on different nodes. In the meantime, we can delete them and they should be recreated on the correct node.
Thank you!

node 1:

disk 1 - usable space 1TB out of 4TB
disk 2 - usable 1 TB out of 4TB
node 2
disk 1 - usable space 1TB out of 4TB
disk 2 - usable 1 TB out of 4TB
disk 3 - usable 1 TB out of 4TB
disk 4 - usable 3 TB out of 4TB
node 3
disk 1 - usable space 1TB out of 4TB
disk 2 - usable 1 TB out of 4TB
disk 3 - usable 1 TB out of 4TB
disk 4 - usable 3 TB out of 4TB

dedicated-master-1
- dedicated-master-1-slow-disk-1: ~10Tb<PHONE_NUMBER>6800b)

dedicated-worker-1
- dedicated-worker-1-fast-disk-1: ~1Tb<PHONE_NUMBER>200b)
- dedicated-worker-1-fast-disk-2: ~1Tb<PHONE_NUMBER>600b)

dedicated-worker-2
- dedicated-worker-2-fast-disk-1: ~3Tb<PHONE_NUMBER>600b)
- dedicated-worker-2-fast-disk-2: ~1Tb<PHONE_NUMBER>200b)
- dedicated-worker-2-fast-disk-3: ~1Tb<PHONE_NUMBER>000b)
- dedicated-worker-2-fast-disk-4: ~1Tb<PHONE_NUMBER>800b)

dedicated-worker-3
- dedicated-worker-3-fast-disk-1: ~1Tb<PHONE_NUMBER>200b)
- dedicated-worker-3-fast-disk-2: ~1Tb<PHONE_NUMBER>600b)
- dedicated-worker-3-fast-disk-3: ~3Tb<PHONE_NUMBER>800b)
- dedicated-worker-3-fast-disk-4: ~1Tb<PHONE_NUMBER>000b)

We have one volume, attached to node 3 with replication factor of 2. After implementing this issue, the master volume should be scheduled on node 3 disk 4, and the replica should be scheduled on node 2 disk 4.

Volume replicas and size on dedicated-worker-3/dedicated-worker-3-fast-disk-3:

- pvc-b52ce958-0ade-4756-8bb3-2bd3bb0b7d87-r-31006b89: ~32Gb<PHONE_NUMBER>0b)
- pvc-dba6627a-3d04-45f4-a721-89791af6ce8d-r-89215524: ~32Gb<PHONE_NUMBER>0b)

In our case, the replica is scheduled on node 1 disk 2, the node 2 disk 4 remaining unused.

Replica scheduled nodes:

- pvc-b52ce958-0ade-4756-8bb3-2bd3bb0b7d87:
  - dedicated-worker-1: dedicated-worker-1-fast-disk-2
  - dedicated-worker-3: dedicated-worker-3-fast-disk-3
- pvc-dba6627a-3d04-45f4-a721-89791af6ce8d:
  - dedicated-worker-1: dedicated-worker-1-fast-disk-1
  - dedicated-worker-3: dedicated-worker-3-fast-disk-3

I've tried to manually delete the replica created on node 1 disk 2 but the replica was re-scheduled on the same node and disk.

> _PVC_="pvc-dba6627a-3d04-45f4-a721-89791af6ce8d"; for name in `k get replica -o wide | grep ${_PVC_} | awk '{print $1}'`; do echo $name: `k get replica/$name -o yaml | grep lastTransitionTime`; done
pvc-dba6627a-3d04-45f4-a721-89791af6ce8d-r-89215524: - lastTransitionTime: "2023-02-08T13:46:29Z"
pvc-dba6627a-3d04-45f4-a721-89791af6ce8d-r-f341e8bd: - lastTransitionTime: "2023-02-02T09:55:46Z"

@iosifnicolae2 , can you help to clarify the below:

Are you having an issue with pvc-b52ce958-0ade-4756-8bb3-2bd3bb0b7d87's replica pvc-b52ce958-0ade-4756-8bb3-2bd3bb0b7d87-r-f0507a9c?
The last transition time is 2023-02-02, is this the last time you've deleted the replica for rescheduling?
The manager has been restarted several times, and the log in the support bundle started from 2023-03-07. If I assumed correctly and the above volume is the one having the issue, there seems to be some outdated information. Are you able to reproduce this issue and send a new support bundle?

@c3y1huang
Obs. the example from https://github.com/longhorn/longhorn-manager/pull/1397#issuecomment-1457876424 is not referring to our production cluster
Answers

No, we had issues with a bigger volume (i think: pvc-85d8f670-2aaf-4714-884c-cb416134f934)
I don't know why we don't have logs for this volume, but I think that I deleted the replica from dedicated-worker-1-fast-disk-2 disk  two days ago on 06.03.2023
hmm, what does it mean that the instance manager was restarted? unfortunetly, we have this disk configuration only in this production cluster so it's not easy to replicate as the problem was solved by deleting the replica two times because after the first delete, the replica was scheduled on the same disk

still, I can't reproduce the issue.. maybe it was a transient problem

Analysis
A. When a new volume is created, Longhorn should allocate replicas on disk with lower "allocated" space AND lower "used" space.

this doesn't seem to happened in our environment because some replicas from dedicated-worker-2-fast-disk-2 should have been scheduled on dedicated-worker-2-fast-disk-1

B. At runtime, the actual used space by volumes can grow unexpectedly (heavy write usage). It would be awesome if replicas are moved automatically on disks with less "used" space. (for now, this is kind of low priority, a temporary workaround would be to manually move the replica on another disk)
The impact of the problem

Some disks will be filled 100% and become unavailable resulting in an OUTAGE.

Feature requests

When deciding where to schedule a replica, take into consideration both, the "allocated" space and "used" space (solving A case)

why taking into consideration only the "used" space is not enough?

because some volumes are used for writing a lot of data (Kafka) and we allocate more space on purpose to reserve more space on disk to accomodate for the high write usage
the "used" space is unpredictable because of the high write volumes

Allow the option to manually move a replica to another disk (solving B case)

Thank you very much for your support!

No, we had issues with a bigger volume (i think: pvc-85d8f670-2aaf-4714-884c-cb416134f934)

# Volume

name: pvc-85d8f670-2aaf-4714-884c-cb416134f934
ownerID: dedicated-worker-2
numberOfReplicas: 2

volumeSize: ~2.6Tb(2684354560000)

# Replicas scheduled nodes:
- dedicated-worker-2: dedicated-worker-2-fast-disk-2
- dedicated-worker-3: dedicated-worker-3-fast-disk-2

Expecting Cluster Nodes' disks availability after deleting replicas.
dedicated-master-1
- dedicated-master-1-slow-disk-1: ~10Tb<PHONE_NUMBER>6800b)

dedicated-worker-1
- dedicated-worker-1-fast-disk-1: ~1Tb<PHONE_NUMBER>200b)
- dedicated-worker-1-fast-disk-2: ~1Tb<PHONE_NUMBER>600b)

dedicated-worker-2
- dedicated-worker-2-fast-disk-1: ~3Tb<PHONE_NUMBER>600b)
- dedicated-worker-2-fast-disk-2: ~4Tb<PHONE_NUMBER>200b+2684354560000b =<PHONE_NUMBER>200b)
- dedicated-worker-2-fast-disk-3: ~1Tb<PHONE_NUMBER>000b)
- dedicated-worker-2-fast-disk-4: ~1Tb<PHONE_NUMBER>800b)

dedicated-worker-3
- dedicated-worker-3-fast-disk-1: ~1Tb<PHONE_NUMBER>200b)
- dedicated-worker-3-fast-disk-2: ~3.72Tb<PHONE_NUMBER>600b+2684354560000b =<PHONE_NUMBER>600b)
- dedicated-worker-3-fast-disk-3: ~3.71Tb<PHONE_NUMBER>800b)
- dedicated-worker-3-fast-disk-4: ~1Tb<PHONE_NUMBER>000b)

After freeing the disk space, dedicated-worker-2/dedicated-worker-2-fast-disk-2, and dedicated-worker-3/dedicated-worker-3-fast-disk-2 still have the most available disk size.

I don't know why we don't have logs for this volume, but I think that I deleted the replica from dedicated-worker-1-fast-disk-2 disk two days ago on 06.03.2023

The support bundle shows the replicas have been on dedicated-worker-2 and dedicated-worker-3 since 2023-02-07.
> k get replica | grep ${_PVC_}
pvc-85d8f670-2aaf-4714-884c-cb416134f934-r-e97e7171   running   dedicated-worker-3   dd195a3e-78c9-4cbd-8f52-da8ac9505ec0   instance-manager-r-8089228093fa41a39c54bd4b290924cb   longhornio/longhorn-engine:v1.4.0   29d
pvc-85d8f670-2aaf-4714-884c-cb416134f934-r-ece18305   running   dedicated-worker-2   a3d7ac97-c1da-4ffe-922e-ba007fade9b9   instance-manager-r-8cbb5c75edfb98fc4210971e72f1112c   longhornio/longhorn-engine:v1.4.0   28d

> for name in `k get replica -o wide | grep ${_PVC_} | awk '{print $1}'`; do echo $name: `k get replica/$name -o yaml | grep lastTransitionTime`; done
pvc-85d8f670-2aaf-4714-884c-cb416134f934-r-e97e7171: - lastTransitionTime: "2023-02-07T08:29:10Z"
pvc-85d8f670-2aaf-4714-884c-cb416134f934-r-ece18305: - lastTransitionTime: "2023-02-07T09:59:45Z"

However, from the support bundle, it appears to be an additional replica that was created on 2023-03-07 and is unable to be scheduled.
pvc-85d8f670-2aaf-4714-884c-cb416134f934-r-ba00a908   stopped

pvc-85d8f670-2aaf-4714-884c-cb416134f934-r-ba00a908: - lastTransitionTime: "2023-03-07T09:49:25Z"

hmm, what does it mean that the instance manager was restarted?

Maybe this is unrelated but seems there are some restarts for the managers.
NAME                                                              READY   STATUS      RESTARTS       AGE
longhorn-manager-2hq8h                                            1/1     Running     4 (34d ago)    56d
longhorn-manager-cj52q                                            1/1     Running     4 (34d ago)    56d
longhorn-manager-gs4gr                                            1/1     Running     6 (29d ago)    56d
longhorn-manager-p6w8r                                            1/1     Running     4 (34d ago)    56d

The manager's log seems to start from 2023-03-07. Not sure if there will be some clues in the previous restarted logs.
> k logs longhorn-manager-p6w8r | head -n 1
Defaulted container "longhorn-manager" out of: longhorn-manager, wait-longhorn-admission-webhook (init)
2023-03-07T12:26:43.553147974+01:00 time="2023-03-07T11:26:43Z" level=error msg="There's no available disk for replica pvc-85d8f670-2aaf-4714-884c-cb416134f934-r-ba00a908, size<PHONE_NUMBER>000"

Feature requests
When deciding where to schedule a replica, take into consideration both, the "allocated" space and "used" space (solving A case)
why taking into consideration only the "used" space is not enough?
because some volumes are used for writing a lot of data (Kafka) and we allocate more space on purpose to reserve more space on disk to accomodate for the high write usage
the "used" space is unpredictable because of the high write volumes
Allow the option to manually move a replica to another disk (solving B case)

Thank you for the input, maybe we can those as the replica scheduler strategies when working on [FEATURE] The replica scheduler may consider more factors


Identity override count retrieval is slow for large numbers of overrides

For instance, for an environment with ~50k overrides, retrieving features with override counters takes 15 to 80 seconds.
Things to explore:

Look into DynamoDB access pattern and ways to optimise it
Cache/store identity counters elsewhere

For now, a valid solution is likely to just add a + next to the icon if there are possibly more identity overrides, using the fact that a next page exists in dynamo.


os.hostname() fails on Linux subsystem for windows

open /proc/sys/kernel/hostname: no such file or directory

To make it compliant with windows we need to remove the os.hostname function and find another solution.
https://github.com/Praqma/git-phlow/blob/master/plugins/gh.go#L143

I'm closing this. We should not attempt to bandaid a solution if we can do a native windows binary.
See #129


Check if subscriptions still working with changes came with meteor 1.5.1

Subscriptions onReady functionality has changes since meteor 1.5.1 (see: https://github.com/meteor/meteor/blob/master/History.md#v151-2017-07-12). Check if this has any impact on our application. Therefore add some series with minutes and observe the behaviour.

The changes regarding to the subscription management should not have any impact on our application since we just set a session variable to true in the callback so it doesn't matter if the callback will be called more than once.


Change content

Change content and format to better suit thoughts blog's needs

For example, change the image and text at the top.


Select keyword does not raise the correct MixedRealityInputAction event

Describe the bug
The "Select" keyword fails to invoke an MixedRealityInputAction. This action is what actually triggers the input handling on buttons or other EyeGazeTarget handlers of the Select action.
Identical to issue #10154 but I am using a post-fix version of MRTK (2.8.2)
Steps to Reproduce
See issue #10154
Expected behavior
See issue #10154
Screenshots
See issue #10154
Your setup (please complete the following information)

Unity Version 2021.3.8f1
MRTK Version 2.8.2
MR OpenXR Plugin 1.5.1
OpenXR Plugin 1.4.2
XR Plugin Management 4.2.0

Target platform (please complete the following information)

HoloLens 2

Additional context
I have verified a fix locally and have submitted a pull request. See my comment on issue #10154 for more information.

@shaynie you've recently looked into the "select" behavior for MRTK3.  Can you help with providing insight on MRTK2?

Hi @bnelligan,
We appreciate your feedback and thank you for reporting this issue.
Microsoft Mixed Reality Toolkit version 2 (MRTK2) is currently in limited support. This means that Microsoft is only fixing high priority security issues. Unfortunately, this issue does not meet the necessary priority and will be closed. If you strongly feel that this issue deserves more attention, please open a new issue and explain why it is important.
Microsoft recommends that all new HoloLens 2 Unity applications use MRTK3 instead of MRTK2.
Please note that MRTK3 was released in August 2023. It features an all new architecture for developing rich mixed reality experiences and has a minimum requirement of Unity 2021.3 LTS. For more information about MRTK3, please visithttps://www.mixedrealitytoolkit.org.
Thank you for your continued support of the Mixed Reality Toolkit!


Join button not working on real android phone.

I have installed sdk example folder on my Android Studio and it's working well. After building apk and install on my real android device join button not working. After clicking on join button it's not open the meeting and redirect on main page.

I got the same.

@gabiborlea i have same problems and here is my logs.
log_jisti_android.txt

In my case, i use proguard-rules.pro in wrong way, make sure you follow this file.
https://raw.githubusercontent.com/gunschu/jitsi_meet/master/jitsi_meet/example/android/app/proguard-rules.pro


i need help! debugging with designated account

i want to use vscode logined account to debug, i can not to change account in webbrower

@wx953999109 - Sometimes, signing out and signing back in can resolve account-related issues. In VSCode, you can sign out by going to the Accounts icon in the Activity Bar and selecting "Sign Out". Then, sign back in with the correct account.

@wx953999109 - Sometimes, signing out and signing back in can resolve account-related issues. In VSCode, you can sign out by going to the Accounts icon in the Activity Bar and selecting "Sign Out". Then, sign back in with the correct account.

Have you tried this? Has it helped you or not?


[RTL] Connect image update signals.

Fixes https://github.com/godotengine/godot/issues/87585
https://github.com/godotengine/godot/assets/7645683/e2320ddd-3aa7-4995-bdc6-7b4e1348b2c1

There's another issue I didn't notice; the size of an ItemImage remains the same, so any size changes do not get updated. The queue_redraw is not enough, it needs some text changes to occur:
https://github.com/godotengine/godot/assets/6501975/433bbd88-8f07-4e56-93b0-4f8beddb881c

Updated to fix size changes as well. Also replaced some nasty "cast raw item pointer to uint64_t" code with safer RIDs.

Can confirm it now works like a charm! :tada:

Thanks!


Fix Light/Dark toggle button

The toggle button is not working as expected in the neeto-editor docs

The toggle is working on some pages and components but while taking as a whole, it's not updating the states.

Thank you for reporting the issue. I shall get this fixed.
UI _t small _t
@AbhayVAshokan _a

I understand the confusion here. The theme icon does not control the global theme of the storybook as a whole. We use the theme to switch to the dark theme for the Editor component.
Take a look at the Image Upload documentation:

By default neetoUI color palette comes with two themes: dark and light. We showcase how neetoEditor looks in the two themes with the theme configuration of storybook.
Closing the issue since there are no further action items. Please do let me know if anything else needs to be clarified.

@AbhayVAshokan Cool!
Sorry for the Misunderstanding


Produce a complete stream/string of Submission Metadata blob

the produced metadata blob should represent a complete metadata for Submission records with no missing field - this is to inform deposit service on what to expect.

with no missing field

Do you mean you'd rather see, for example, myField: null than nothing at all? Or do you mean that everything needs to be filled out by the user/autofill?

for real data, I think omitting empty field is fine, but i'm looking for a sample submission metadata blob so i can give the Deposit service people to help them with coding the parser for such blob.

thanks.

@Rytiggy
i talked to Elliot (who's working on the deposit service) he had some feedback on how the metadata is organized that i thought was logical. he thinks that the publication cross ref related metadata should all be in common section. that would mean ISSN and embargo information goes into "common" section. leaving deposit agreement in "JScholarship" and NLMTA_ID in "nih"
Can we make this change and produce a new blob? ping me if you have concern?

i would like the embargo related stuff to be on the common page.

got it. thanks.


localStorage is null on Chrome/Android sometimes

need to make alt way or storage wrapper
need to test on Safari and mobile Safari

need to test on Safari and mobile Safari

This seems not a considerable problem after 4 days' release and monitoring


Maya: Extract active view as thumbnail when no thumbnail set

Changelog Description
This sets the Maya instance's thumbnail to the current active view if no thumbnail was set yet.
Additional info
It's currently set to only the workfile family for which it makes most sense - but I think it could even be nice for other families as at least a visual hint?
Preview

Testing notes:

Make sure thumbnails are enabled for your studio

Ensure you have AVALON_THUMBNAIL_ROOT set in OpenPype settings

Open Maya
Publish a workfile
Published workfile subset should now have a thumbnail

LGTM


use our fork of github.com/Microsoft/go-winio

There was still a problem after all with the named pipe lib, and CLI commands which call FixVersionClash(). The problem is where FixVersionClash() calls Close() on the socket, while the client transport is still sitting in a read loop. The pipe library returns a scary error, which gets printed out in red:
- ERROR {pipe://\\.\pipe\kbservice\Users\Steve\AppData\Local\Keybase\keybased.sock} Error in transport: msgpack decode error [pos 3]: file has already been closed
Made a fork of microsoft/go-winio with this PR: https://github.com/Microsoft/go-winio/pull/94
Call stacks:
github.com/keybase/client/go/vendor/github.com/Microsoft/go-winio.(*win32File).asyncIo (c:\work\src\github.com\keybase\client\go\vendor\github.com\Microsoft\go-winio\file.go:191)
github.com/keybase/client/go/vendor/github.com/Microsoft/go-winio.(*win32File).Read (c:\work\src\github.com\keybase\client\go\vendor\github.com\Microsoft\go-winio\file.go:224)
bufio.(*Reader).Read (c:\Go\src\bufio\bufio.go:216)
github.com/keybase/client/go/vendor/github.com/keybase/go-framed-msgpack-rpc/rpc.(*lastErrReader).Read (c:\work\src\github.com\keybase\client\go\vendor\github.com\keybase\go-framed-msgpack-rpc\rpc\packetizer.go:23)
github.com/keybase/client/go/vendor/github.com/keybase/go-codec/codec.(*ioDecReader).Read (c:\work\src\github.com\keybase\client\go\vendor\github.com\keybase\go-codec\codec\decode.go:600)
github.com/keybase/client/go/vendor/github.com/keybase/go-codec/codec.(*ioDecReader).ReadByte (c:\work\src\github.com\keybase\client\go\vendor\github.com\keybase\go-codec\codec\decode.go:615)
github.com/keybase/client/go/vendor/github.com/keybase/go-codec/codec.(*ioDecReader).readn1 (c:\work\src\github.com\keybase\client\go\vendor\github.com\keybase\go-codec\codec\decode.go:692)
github.com/keybase/client/go/vendor/github.com/keybase/go-codec/codec.(*msgpackDecDriver).readNextBd (c:\work\src\github.com\keybase\client\go\vendor\github.com\keybase\go-codec\codec\msgpack.go:710)
github.com/keybase/client/go/vendor/github.com/keybase/go-codec/codec.(*msgpackDecDriver).TryDecodeAsNil (c:\work\src\github.com\keybase\client\go\vendor\github.com\keybase\go-codec\codec\msgpack.go:748)
github.com/keybase/client/go/vendor/github.com/keybase/go-codec/codec.(*Decoder).MustDecode (c:\work\src\github.com\keybase\client\go\vendor\github.com\keybase\go-codec\codec\decode.go:2058)
github.com/keybase/client/go/vendor/github.com/keybase/go-codec/codec.(*Decoder).Decode (c:\work\src\github.com\keybase\client\go\vendor\github.com\keybase\go-codec\codec\decode.go:2047)
github.com/keybase/client/go/vendor/github.com/keybase/go-framed-msgpack-rpc/rpc.(*packetHandler).loadNextFrame (c:\work\src\github.com\keybase\client\go\vendor\github.com\keybase\go-framed-msgpack-rpc\rpc\packetizer.go:97)
github.com/keybase/client/go/vendor/github.com/keybase/go-framed-msgpack-rpc/rpc.(*packetHandler).NextFrame (c:\work\src\github.com\keybase\client\go\vendor\github.com\keybase\go-framed-msgpack-rpc\rpc\packetizer.go:64)
github.com/keybase/client/go/vendor/github.com/keybase/go-framed-msgpack-rpc/rpc.(*transport).receiveFramesLoop (c:\work\src\github.com\keybase\client\go\vendor\github.com\keybase\go-framed-msgpack-rpc\rpc\transport.go:155)
runtime.goexit (c:\Go\src\runtime\asm_amd64.s:2361)

github.com/keybase/client/go/vendor/github.com/Microsoft/go-winio.(*win32File).closeHandle (c:\work\src\github.com\keybase\client\go\vendor\github.com\Microsoft\go-winio\file.go:123)
github.com/keybase/client/go/vendor/github.com/Microsoft/go-winio.(*win32File).Close (c:\work\src\github.com\keybase\client\go\vendor\github.com\Microsoft\go-winio\file.go:134)
github.com/keybase/client/go/client.FixVersionClash.func1 (c:\work\src\github.com\keybase\client\go\client\versionfix.go:63)
github.com/keybase/client/go/client.FixVersionClash (c:\work\src\github.com\keybase\client\go\client\versionfix.go:114)
main.configureProcesses (c:\work\src\github.com\keybase\client\go\keybase\main.go:298)
main.mainInner (c:\work\src\github.com\keybase\client\go\keybase\main.go:190)
main.main (c:\work\src\github.com\keybase\client\go\keybase\main.go:75)
runtime.main (c:\Go\src\runtime\proc.go:198)
runtime.goexit (c:\Go\src\runtime\asm_amd64.s:2361)

yeah I forgot to change the imports at first

@zanderz  is #13868 the same issue?  Does2.6.2 have the fix?

Ah, I seem to recall the discussion, we deemed it too big...

I wanted to put it in the hotfix but nobody else seemed to.

Makes sense. We'll wait until the next release.


Problems with marker.infowindow as JS request

Hi, i'm having an issue with marker.infowindow and JS request.
Controller:
def general
   @positions =  Position.where("latitude is NOT NULL AND longitude is NOT NULL").first(5)
   @hash = Gmaps4rails.build_markers(@positions) do |position, marker|

    marker.picture({
              :url      => ActionController::Base.helpers.asset_path( "p.png", type: :image),
              :width    => 12,
              :height   => 12
             })
    marker.title position.address
    marker.lat position.latitude
    marker.lng position.longitude
    marker.infowindow render_to_string(:partial => "/maps/position_detail", :formats => [:html], :locals => { :position => position})
  end
end

general.js.erb
$('#main-content').fadeOut(function() {
  var $main = $(this);
  var tpl   = "<%= j(render(:partial => 'maps/maps_fs',  :formats => [:html])) %>";

  $main.html(tpl).fadeIn(function(){

    var handler = Gmaps.build('Google', {markers:
            {clusterer: {
              gridSize: 100,
              maxZoom: 12
            }}});

    handler.buildMap({ provider: {}, internal: {id: 'map'}}, function(){
      markers = handler.addMarkers(<%= raw @hash.to_json %>);
      handler.bounds.extendWith(markers);
      handler.fitMapToBounds();
    });
  });

  history.pushState({url: '/maps/monit'}, null, '/maps/monit');
});

_maps_fs_html.erb

_position_detail.html.erb

  <%= position.address %>

The thing is that when I make an AJAX request it simple do not work (no any error message at all ...)
Started GET "/maps/general" for <IP_ADDRESS> at 2014-05-23 00:58:00 +0000
Processing by MapsController#general as JS
  User Load (2.2ms)  SELECT `users`.* FROM `users` WHERE `users`.`id` = 25 LIMIT 1
  Position Load (1.4ms)  SELECT `positions`.* FROM `positions` WHERE (latitude is NOT NULL AND longitude is NOT NULL) LIMIT 5
  Rendered maps/_position_detail.html.erb (0.2ms)
  Rendered maps/_position_detail.html.erb (0.2ms)
  Rendered maps/_position_detail.html.erb (0.2ms)
  Rendered maps/_position_detail.html.erb (0.2ms)
  Rendered maps/_position_detail.html.erb (0.2ms)
  Rendered maps/_maps_fs.html.erb (0.1ms)
  Rendered maps/general.js.erb (21.5ms)
Completed 200 OK in 425.4ms (Views: 303.8ms | ActiveRecord: 3.6ms)

but, if i comment the line of marker.infowindow, all works as expected.
Started GET "/maps/general" for <IP_ADDRESS> at 2014-05-23 01:14:35 +0000
Processing by MapsController#general as JS
  User Load (1.6ms)  SELECT `users`.* FROM `users` WHERE `users`.`id` = 25 LIMIT 1
  Position Load (1.2ms)  SELECT `positions`.* FROM `positions` WHERE (latitude is NOT NULL AND longitude is NOT NULL) LIMIT 5
  Rendered maps/_maps_fs.html.erb (0.2ms)
  Rendered maps/general.js.erb (22.3ms)
Completed 200 OK in 427.7ms (Views: 280.1ms | ActiveRecord: 12.6ms)

Any help would be appreciated.
Thanks.
Angel

+1 ,  having same issue and got it fixed with respond_to block. thanks guys


Programming Components, Structure & Keywords

Description 📜
I'll go with the Documentation of the Following Contents below:

I'll go over all of the C programming elements.
I'll go over every structure and keyword used in C programming.

Domain of Contribution 📊

[ x] C/CPP

/assign

Please assign me this task I have almost completed this due to some medical emergency I haven't pushed the code.
@Suvraneel

@Kanishk0412  Okay, sure

Thanks for reopening !!


Fix namespace leak

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Moved from https://github.com/onnx/onnx-mlir/pull/1299

@whitneywhtsang @tungld @etiotto @AlexandreEichenberger   🙏🏼

#1299

Just curious, why do you need a new PR?

@whitneywhtsang - Maybe there was a lag, but the old PR wasn't updated when I push to the remote :(

Can one of the admins verify this patch?

@jenkins-droid test this please

@whitneywhtsang - mind helping me get this in? :)

@AlexandreEichenberger - Im guessing your push triggered CI, and once they finish, I need an approval - what would happen afterwards - do I click a button to get this merged?

Jenkins Linux ppc64le Build #3907 [push] fix namespace leak (#130... started at 21:40

Jenkins Linux s390x Build #4787 [push] fix namespace leak (#130... started at 21:37

Jenkins Linux amd64 Build #4771 [push] fix namespace leak (#130... started at 20:37

Jenkins Linux s390x Build #4787 [push] fix namespace leak (#130... passed after 46 min

Jenkins Linux ppc64le Build #3907 [push] fix namespace leak (#130... passed after 56 min

Jenkins Linux amd64 Build #4771 [push] fix namespace leak (#130... passed after 59 min


[REVIEW] Update README

Adding recent examples and table with links #66

@drobison00 will update the links for Dask-K8s example once we merge the notebooks


Asynchronous actions not returning promises?

From the current documentation on "Asynchronous actions as Promises" I get the impression that the asynchronous actions would return a promise which is resolved when the completed child action is called.
https://github.com/spoike/refluxjs/blob/0b3f14f92a6ae5a969b0a5a738de2434cdae15e9/README.md#asynchronous-actions-as-promises
But that's not the case?
ie. I assumed following would work
var Reflux = require("reflux");

var action = Reflux.createAction({ asyncResult: true });

action.listen(function() {

    setTimeout(this.completed, 1000);

});

action().then(function() {
    console.log("Done!");
});

but it fails with TypeError: Cannot call method 'then' of undefined

That's because you have to call your action with action.triggerPromise() in order to return a Promise. But I agree it is a bit confusing, since you specify the action as a Promise, it should return a Promise automatically...

The documentation specifically says this should work, so that should at least be corrected.

At least add triggerPromise to the README. This had me scratching my head.

#259 is a duplicate of this

I think a promise should only be created when explicitly calling triggerPromise. This behaviour puzzled me, and caused me at least one hour of debugging because the javascript console kept throwing errors at me, that I thought I was catching.
A funny side-effect of this is that the async child actions also return promises, so if you do something like this, it may cause strange effects:
Action.listen(=>
  doAjax().then(Action.completed, Action.failed)
)

Since both 'completed' and 'failed' return new promises, chaining another then to the end will not receive the result from doAjax. Instead it will always be resolved with no arguments.
In my case, my action was implemented like above, I was invoking the action from the view:
Action()

This throws an error in the javascript console if doAjax fails, even though I'm actually handling the 'failed' action. This happens because the invocation of the action creates another promise that is also rejected when handling the original promise. The browser complains because the failure of this second promise is not handled, so we need to do something like this in the view code:
Action().catch(=> console.log("caught error")  // duplicate error handling
Action.triggerAsync()  // do not create promise

It feels strange that I need to care about this when I don't care about the promise! It would be better if I had to explicitly call triggerPromise when I wanted a promise.


Add test fixtures for testing Groovy & JVM bytecode call interceptors

@bot-gradle test RFN

I've triggered the following builds for you:

ReadyForNightly build

@bot-gradle test RFN

I've triggered the following builds for you:

ReadyForNightly build


Clarify guidance on HISTORY.rst entries

This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines

[N/A] The PR has modified HISTORY.rst with an appropriate description of the change (see Modifying change log).

Command Guidelines

[N/A] Each command and parameter has a meaningful description.
[N/A] Each new command has a test.

(see Authoring Command Modules)

Codecov Report

Merging #4336 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4336   +/-   ##
=======================================
  Coverage   69.06%   69.06%
=======================================
  Files         484      484
  Lines       31055    31055
  Branches     4853     4853
=======================================
  Hits        21447    21447
- Misses       8029     8033    +4
+ Partials     1579     1575    -4

Impacted Files
Coverage Δ

...nent/azure/cli/command_modules/component/custom.py
16.26% <0%> (ø)
:arrow_up:

src/azure-cli-core/azure/cli/core/util.py
69.73% <0%> (ø)
:arrow_up:

...li-cloud/azure/cli/command_modules/cloud/custom.py
13.79% <0%> (ø)
:arrow_up:

...dback/azure/cli/command_modules/feedback/custom.py
31.25% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b9bcdd...c5621d2. Read the comment docs.


fix duplicate java memory args on restart

on restart of the container, java memory args are appended multiple times

Thanks!


runtime: Caller can return covervars.go as filename when called from a global variable in test with coverage

What version of Go are you using (go version)?

$ go version
go version go1.21.4 darwin/arm64

Does this issue reproduce with the latest release?
Yes (1.21.4)
It doesn't reproduce with Go 1.20.x.
On the current main branch, it is shadowed by the issue described in https://github.com/golang/go/issues/64520 (but I still opened this separate issue as I'm not sure whether fixing the other one would fix this one, and this one appears in a released version).
It also reproduces on different OS and architectures (eg. linux/amd64)
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE='auto'
GOARCH='arm64'
GOBIN=''
GOCACHE='/Users/pierre.gimalac/Library/Caches/go-build'
GOENV='/Users/pierre.gimalac/Library/Application Support/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='arm64'
GOHOSTOS='darwin'
GOINSECURE=''
GOMODCACHE='/Users/pierre.gimalac/go/pkg/mod'
GONOPROXY='github.com/DataDog'
GONOSUMDB='github.com/DataDog,go.ddbuild.io'
GOOS='darwin'
GOPATH='/Users/pierre.gimalac/go'
GOPRIVATE='github.com/DataDog'
GOPROXY='binaries.ddbuild.io,proxy.golang.org,direct'
GOROOT='/usr/local/go'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/usr/local/go/pkg/tool/darwin_arm64'
GOVCS=''
GOVERSION='go1.21.4'
GCCGO='gccgo'
AR='ar'
CC='clang'
CXX='clang++'
CGO_ENABLED='1'
GOMOD='/tmp/pKsOoeSDXncWwAsv/go.mod'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -ffile-prefix-map=/var/folders/zp/m8h1x16s30g3f656sxsdt7rm0000gp/T/go-build1790875425=/tmp/go-build -gno-record-gcc-switches -fno-common'
uname -v: Darwin Kernel Version 22.6.0: Wed Jul  5 22:22:05 PDT 2023; root:xnu-8796.141.3~6/RELEASE_ARM64_T6000
ProductName:		macOS
ProductVersion:		13.5.2
BuildVersion:		22G91
lldb --version: lldb-14<IP_ADDRESS>
Apple Swift version 5.8.1 (swiftlang-<IP_ADDRESS>.5 clang-14<IP_ADDRESS>.100)

What did you do?

When using Go 1.21, when running test with coverage enabled, runtime.Caller can return covervars.go as caller filename, instead of the actual caller filename.
A minimal reproducible example can be found on https://github.com/pgimalac/gist/tree/go-runtime-caller-filename-covervars-go (I could not reduce it to a single file, but it's rather small as it is).
The example declares a global variable which indirectly calls runtime.Caller, which returns covervars.go instead of the actual filename.
The bug is triggered by running go test ./... -cover, a test which checks that the filename contains package1 will fail.
If this is not considered a bug, the documentation should make it clear that runtime.Caller can return something else when called from a global variable when running in a test with coverage enabled.
What did you expect to see?
runtime.Caller should return <root>/mypackage1/myfile.go.
What did you see instead?
runtime.Caller returns covervars.go.

CC @mdempsky


[WIP] add dynamic type and weight support

Hey this is WIP, to gather feedback.
This add support for weights in addition to bold and enable dynamic type.
Tests won't passe due to dynamic type changing the font size, I'm wondering if this should be toggle-able and a separate property of the MarkupStyleFont.
AppKit part is not updated yet.

I will review ASAP, thanks for your contribution.

We are facing an issue with this "weight support." The proposed solution above is acceptable. Please handle promptly. Thank you. @zhgchgli0718

I have adjusted the tests and the AppKit. If there are no issues, we can proceed with merging and releasing it. Thank you for your contribution.

@zhgchgli0718
CocoaPods Specs cannot find version 1.12.0， Please submit this version.
https://github.com/CocoaPods/Specs/tree/master/Specs/2/5/b/ZMarkupParser

@zhgchgli0718 CocoaPods Specs cannot find version 1.12.0， Please submit this version. https://github.com/CocoaPods/Specs/tree/master/Specs/2/5/b/ZMarkupParser

done, https://github.com/CocoaPods/Specs/tree/master/Specs/2/5/b/ZMarkupParser/1.12.0


SOLR-11535: Fix race condition in singleton-per-collection StateWatcher creation

Having lived with these changes for a bit, I plan to commit this within the next day or two, pending feedback. Proposed CHANGES.txt entry:
* SOLR-11535: Fix race condition in singleton-per-collection StateWatcher creation (Michael Gibney)

I'm inclined to put this under "Bugs". Even though it's a bug that often doesn't often manifest in a visible way, the essence of this issue is that ZkStateReader has been leaking redundant StateWatchers that, once present, re-register themselves in perpetuity as long as the collection is still watched ... which definitely sounds to me like a bug.


A basic legend implementation

This is a basic implementation of a legend for categorical features.  See: http://opengeoscience.github.io/geojs/examples/legend/

:nice: will review this branch tomorrow

LGTM :100:


librabbitmq contains at least one Python 3 syntax error

The version of librabbitmq that this project is using contains at least one Python 3 syntax error.
See: https://github.com/celery/librabbitmq/pull/99
https://travis-ci.org/fossasia/query-server/jobs/275757559#L479
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-build-eiupkwho/librabbitmq/setup.py", line 191
        except Exception, exc:
                        ^
    SyntaxError: invalid syntax

@fossasia-bot fossasia-bot bot added the has-PR label just now

The PR above refers to this issue but it does not fix or resolve this issue.

@mariobehling Please review.

@cclauss Do we need librabbitmq in the first place? Looking at the dependencies, it seems that the import is unnecessary? (contrary to #126)


reduce causes loss of integer arithmetic precision

At least, that's what this example seems to show.
Setup:
def gcd($a; $b):
  # rgcd expects [a,b] as input
  def rgcd:
    if .[1] == 0 then .[0]
    else [.[1], (.[0] % .[1])] | rgcd
    end;
  [$a,$b] | rgcd;

def r($p;$q):
  gcd($p;$q) as $g
  | {n: ($p/$g), d: ($q/$g)} ;

def rprod($a;$b):
   $a as {n: $na, d: $da}
   | $b as {n: $nb, d: $db}
   | r( $na * $nb; $da * $db) ;

def rprod: reduce .[] as $r ( r(1;1); rprod(.; $r));

def pair:
  [{"d":1,"n":32589158477190046000},
   {"d":1,"n":59}];

Test case:
rprod(pair[0]; pair[1]),
(pair | rprod)

Output:
{"d":1,"n":1922760350154212714000}
{"d":1,"n":1.9227603501542128e+21}

You want integer division for %q/%g right? Use def intdiv($x; $y): ($x - $x % $y) / $y;, instead of $x / $y as explained in README.md. Otherwise it changes floats if indivisible.

Sorry for missing that point, and thanks for the fix.  However, here is an example showing that division of an integer by 1 causes a similar discrepancy.
def r($p):
  {n: $p} ;

def rprod($a;$b):
   {n: (($a.n / 1) * $b.n)};

def rprod: reduce .[] as $r ( r(1); rprod(.; $r));

def pair:
  [{"n":32589158477190046000},
   {"n":59}];

rprod(pair[0]; pair[1]),
(pair | rprod)

Output:
{"n":1922760350154212714000}
{"n":1.9227603501542128e+21}

Okay, looks like caused by 1/1 = float64(1.0).

Even if the divisor is 1, I don't expect program using / for division keeping the precision anyway. This operator in jq is floating-point division.

I noticed some incosistency in my opinion. Division on big int is big int when divisible, which is important for intdiv, but int / int is always float. Worth fixing.

I fixed the issue, thanks for reporting.

@itchny - Thanks to this update, gojq is now mentioned several times at rosettacode.org. When you are so inclined, you might like to enter "gojq" in the search box there.
It would however be nice to have an official release that includes this fix so that a specific version of gojq can be mentioned, as is the custom at rosettacode.

First, I appreciate your number of issue reporting greatly. I will tag a new release in coming August, please be patient.


WIP - custom knit: handle xaringan::inf_mr

What problem did you solve?
Solves #796.
Still WIP as need to ensure that the URL regex is appropriate, and needs some tidying of the code.
(If you do not have screenshot) How can I check this pull request?
Knitting the following should work (i.e., progress bar signals completion), and closing the webview should dispose of the process.
---
knit: xaringan::inf_mr
---

# Test

Para.

---

# Next

i'm a little iffy on how broad the url regex should be, because i don't want it to trigger on just any url that might pop up in the output stream


[DRAFT] Minimal PoC of using Sketchapp

Does not work due to:
Module not found: Error: Can't resolve 'fs' in '/Users/x/code/ooni/probe-desktop/node_modules/electron'
resolve 'fs' in '/Users/x/code/ooni/probe-desktop/node_modules/electron'   Parsed request is a module

Related to: https://github.com/ooni/design-system/issues/86

Probably more of a pain than a gain for the moment.
Maybe we can re-evaluate doing this as part of the design-system. Closing this PR.


Auto Installation License Agreement Issue

cant accept the license agreement, am i forgetting to do something?

wrong repo and click the text not the button


Validate input variables before executing commands

If secrets are not properly set and inputs.project_dir, inputs.release_id are somehow empty it leads to attempt to remove the entire root folder / at https://github.com/eaudeweb/drupal-deploy-action/blob/main/action.yml#L65
Add a validation step before executing the action so the required inputs are not empty.

I don't think is valid anymore for 2.x


Sneaker site files added

🛠 Fixes Issue (Number)
#215

👨💻 Changes proposed

✅ Check List (Check all the applicable boxes)

[c] My code doesn't break any part of the project (Zero Octave-Javascript-Projects).
[x] This PR does not contain plagiarized content.
[x] My Addition/Changes works properly and matches the overall repo pattern.
[x] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers

📷 Screenshots

there is some conflict please resolve it

there is some conflict please resolve it

When I raised this PR, there was no conflict with the base branch and it could be merged with no problem, now I dont know why there is a conflict

The conflict is resolved, kindly merge it now

Still there are some conflicts, Please solve it

Why you closed this issue?


Generic comments on alerts

AlertsCenter:

Include generic comments on alert on every state.
Add state on notification.
Bump ui-services to 0.8.12.

Please, @pilhuhn, @mtho11 or @jshaughn review and merge if appropiate.

Merged #579


New authentication flow to resolve #515

This resolves the issue with a new OAuth method largely referencing the work done in librespot https://github.com/librespot-org/librespot/pull/1309. After this username/pass is completely depreciated. I may not have removed all unused references so I'd be happy for reviews and edits.

@Insprill Since this is a big one and high prio, would you have time to look over this and review?

@SO9010 Just to check with another person, does this method work for you from this branch?

By the way, now everyone required is back from holiday we'll hopefully be merging our PR for this. It's currently going through some review. The intention is to publish a librespot-oauth create but when that'll see an actual release, I can't say. I appreciate you might prefer to control your own copy of that code, this is more just a note that the original version is seeing some updates (error handling mostly).

@SO9010 Just to check with another person, does this method work for you from this branch?

I'll try it out tomorrow!

@jacksongoode This works perfectly for me!!!


AnalysisException: Cannot compute LIBRARY_ELEMENT for Instance of 'AssetBasedSource'

I'm getting this when i try to run my watcher.
Future<Null> main(List<String> args) async {
  await watch(<BuildAction>[
    new BuildAction(
        new PartBuilder(<Generator>[
          const JsonSerializableGenerator(),
          const BuiltValueGenerator(),
          new BuiltReduxGenerator(),
        ]),
        'my_app',
        inputs: const <String>['lib/**/*.dart'])
  ], deleteFilesByDefault: true);
}

[SEVERE] Instance of 'PartBuilder' on my_app|lib/actions/actions.dart:
AnalysisException: Cannot compute LIBRARY_ELEMENT for Instance of 'AssetBasedSource'
Caused by Unexpected exception while performing ResolveUnitTypeNamesTask for source built_collection|lib/src/set/built_set.dart
#0      AnalysisTask._safelyPerform (package:analyzer/task/model.dart:333:7)
#1      AnalysisTask.perform (package:analyzer/task/model.dart:220:7)
#2      AnalysisDriver.performWorkItem (package:analyzer/src/task/driver.dart:284:10)
#3      AnalysisDriver.computeResult (package:analyzer/src/task/driver.dart:109:22)
#4      AnalysisContextImpl.computeResult (package:analyzer/src/context/context.dart:730:14)
#5      AnalysisContextImpl.computeLibraryElement (package:analyzer/src/context/context.dart:697:12)
#6      ResolverImpl._performResolve.<anonymous closure>.<anonymous closure> (package:code_transformers/src/resolver_impl.dart:167:25)
#7      MappedListIterable.elementAt (dart:_internal/iterable.dart:413)
#8      ListIterable.toList (dart:_internal/iterable.dart:218)
#9      ResolverImpl._performResolve.<anonymous closure> (package:code_transformers/src/resolver_impl.dart:168:10)
#10     StackZoneSpecification._registerUnaryCallback.<anonymous closure>.<anonymous closure> (package:stack_trace/src/stack_zone_specification.dart:129:26)
#11     StackZoneSpecification._run (package:stack_trace/src/stack_zone_specification.dart:209:15)
#12     StackZoneSpecification._registerUnaryCallback.<anonymous closure> (package:stack_trace/src/stack_zone_specification.dart:129:14)
#13     _rootRunUnary (dart:async/zone.dart:1128)
#14     _CustomZone.runUnary (dart:async/zone.dart:1012)
#15     _FutureListener.handleValue (dart:async/future_impl.dart:129)
#16     _Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:636)
#17     _Future._propagateToListeners (dart:async/future_impl.dart:665)
#18     _Future._completeWithValue (dart:async/future_impl.dart:478)
#19     _Future._asyncComplete.<anonymous closure> (dart:async/future_impl.dart:510)
#20     StackZoneSpecification._run (package:stack_trace/src/stack_zone_specification.dart:209:15)
#21     StackZoneSpecification._registerCallback.<anonymous closure> (package:stack_trace/src/stack_zone_specification.dart:119:48)
#22     _rootRun (dart:async/zone.dart:1120)
#23     _CustomZone.run (dart:async/zone.dart:1001)
#24     _CustomZone.runGuarded (dart:async/zone.dart:901)
#25     _CustomZone.bindCallback.<anonymous closure> (dart:async/zone.dart:926)
#26     _microtaskLoop (dart:async/schedule_microtask.dart:41)
#27     _startMicrotaskLoop (dart:async/schedule_microtask.dart:50)
#28     _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:99)
#29     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:152)

Not sure. Seems like an issue with build resolving types from built_collection.
I tried some test generation with BuiltSet as values in built_values and with BuiltSet as the generic type in ActionDispatcher payloads and ran into no issues.
I was successful using built_redux 7.3.5 on dart 2.0.0-dev.20.0 and 1.24.3 with the following dependencies pinned:
build:
description:
name: build
url: "https://pub.dartlang.org"
source: hosted
version: "0.11.2"
build_runner:
description:
name: build_runner
url: "https://pub.dartlang.org"
source: hosted
version: "0.6.0+1"
built_collection:
description:
name: built_collection
url: "https://pub.dartlang.org"
source: hosted
version: "3.0.4"
built_value:
description:
name: built_value
url: "https://pub.dartlang.org"
source: hosted
version: "5.1.1"
built_value_generator:
description:
name: built_value_generator
url: "https://pub.dartlang.org"
source: hosted
version: "5.1.1"

What are you pinned to for those dependencies?

you are right I was using the example here:
https://github.com/brianegan/flutter_architecture_samples/blob/master/example/built_redux/pubspec.yaml
with this:
flutter_built_redux: ^0.4.0
built_redux: ^7.0.0
built_value: ^4.3.2
built_collection: ^2.0.0
Once I've upgraded everything, it works


❌ Connection error: Session request failed

Hi,
My proxy-cheap proxies run under SOCKS5 protocol and it seems the are not recognized by your bot.
I am receiveing error:
❌ Connection error: Session request failed
2024-11-11T21:38:31.629Z [error]: Connection error {"error":"Session request failed","proxy":{"host":"<IP_ADDRESS>","port":"47258", ( I have removed username and password)
How do you think I could solve this issue?
Thanks a lot.
FERDINANDO

Switch em to http and it'll work


spec: added notice regarding flag parsing

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 69.153%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
204

Relevant Lines:
295

💛  - Coveralls


Remove the word " HI" in home section { akeelcodes}

remove the word " HI" in  the home section

I have assigned you to this issue, Thank you


Prereq install failure with Ubuntu Flash Drive

Hello,
I'm attempting to install the Tuya-Convert on an UBUNTU live Flash drive.  I have attempted this on 20.04 LTS and 18.04.  Same error after the following:
# sudo Apt Update
# sudo Apt Upgrade
(Everything up to date)
# git clone https://github.com/ct-Open-Source/tuya-convert
# cd tuya-convert
# sudo ./install_prereq.sh

And the resulting code:
ubuntu@ubuntu:~/tuya-convert$ sudo ./install_prereq.sh
Ign:1 cdrom://Ubuntu 18.04.3 LTS _Bionic Beaver_ - Release amd64 (20190805) bionic InRelease
Hit:2 cdrom://Ubuntu 18.04.3 LTS _Bionic Beaver_ - Release amd64 (20190805) bionic Release
Hit:3 http://archive.ubuntu.com/ubuntu bionic InRelease
Hit:4 http://archive.ubuntu.com/ubuntu bionic-updates InRelease
Hit:5 http://security.ubuntu.com/ubuntu bionic-security InRelease
Reading package lists... Done
Reading package lists... Done
Building dependency tree
Reading state information... Done
Package dnsmasq is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source
However the following packages replace it:
  dnsmasq-base

Package haveged is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source

Package python3-wheel is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source

E: Package 'dnsmasq' has no installation candidate
E: Unable to locate package hostapd
E: Unable to locate package python3-pip
E: Package 'python3-wheel' has no installation candidate
E: Unable to locate package mosquitto
E: Package 'haveged' has no installation candidate

I've tried new drives, switched to and from Persistence Storage for both version attempts, haven't been able to get past this point.     I'm brand new to Linux, so I imagine I'm missing something.
I've ordered a PI to give it a shot on there, but This should still work....right?  Thanks for your help

sudo Apt Update

Linux is case sensitive, which you might not be used to if you're coming from Windows. They are mostly lowercase.
dnsmasq, haveged, etc, are all present in the current Ubuntu repositories. Running from a live disk is not supported, so if your live disk is having trouble locating these packages, you may need to start the OS normally.

Live disk was the issue. I thought with persistence it would work as I found that others had success with that, but definitely wasn't working.  I achieved success with Ubuntu install LTS 20.04 partitioned alongside windows 10.
Thanks for the fix.
Closing this thread and moving on to Intermediate Firmware errors.


Filter reads before assembly in Mutect. Closes #723.

@takutosato You saw the improvement in sensitivity on DREAM.  HapMap showed the same.  Normal-normal false positives were about the same.  Most of the changes are straightforward.  The stuff about perSampledFilteredReadList is that we used to keep track of filtered reads in order to annotate based on those.  1) I don't think that makes much sense.  2) We can't do that any longer because those reads are filtered before Mutect2Engine see them.
@LeeTL1220 You might be interested in knowing that this improved sensitivity in all the DREAM challenges by about 3%.
@droazen @yfarjoun @ldgauthier HaplotypeCaller has the same comment as Mutect asking whether this change is worthwhile.  Might be worth investigating making the change there, too.

@takutosato My bad for letting this fester with a failing test for a while.  I re-ran the job and it was just a Travis thing.

@davidbenjamin sorry for the delay; it looks good.


Fix build error: Catch up gl_generator API changes

It was always Fallback::All before, but now you can choose one of All and None.
Reference: https://github.com/bjz/gl-rs/commit/368255d830ca991b029a3b324650aaff2d2560cf

Closed by #599


CPE incorrect for xpdf

🐛 Summary
Vendor string used for this xpdf CVE is xpdf.
https://github.com/cisagov/vulnrichment/blob/develop/2024/4xxx/CVE-2024-4568.json#L136
NVD, however uses glyphandcog as the vendor, similar to tukaani for xz.
https://nvd.nist.gov/products/cpe/search/results?namingFormat=2.3&keyword=xpdf
Expected behavior
CPE strings must match NVD, where possible.
Any helpful log output or screenshots
Paste the results here:

Add any screenshots of the problem here.

Possible there are more instances.
Here for example, the vendor used is aio-libs_project, while NVD has aiohttp. https://nvd.nist.gov/products/cpe/search/results?namingFormat=2.3&keyword=aiohttp
https://github.com/cisagov/vulnrichment/blob/5140a8995b4641d58fa9162d3694bd4d9ef681ed/2024/30xxx/CVE-2024-30251.json#L125C48-L125C55

Thanks so much, @prabhu!

Some explanation, which may or may not address the specific instances you noticed (which we will review!).

CPE strings must match NVD, where possible.

Yes, and this is how the process is designed to work. And...

There is the official NVD CPE Dictionary. First choice. However, even that has matching issues, for example, some xpdf entries use xpdfreader as the vendor.

Next, there are a number (84K+) of CPE entries in NVD data that are not in the Dictionary (1.2M+). Second choice (use something that exists).

Last choice is to create new CPE. In this sense, we're following the CPE specification, but publishing CPE-compliant data does not get it added to the Dictionary.

Let's be clear, CPE is an attempt to address the wicked problem that is consistently naming all the software. Neither the CPE specification nor existing CPE data can do this, but it's a start, and an existing data set (or sets). There will be errors, and part of this process is to evaluate how CPE or other software identification systems work in practice.

Thank you for reviewing this issue. From an ADP consumer point of view, 1 and 2 are straight forward. For 3, where a CPE was made up, is there a way to capture this information in the json, to inform the downstream tools?
May be this project would benefit from the new IDs supported by CVE schema 5.1 in the future, so perhaps a roadmap for update could be proposed.

I was randomly browsing the repo and noticed that the CPE information for 2024/34xxx/CVE-2024-34342.json is incorrect.
I don't think https://github.com/wojtekmaj/react-pdf is the same as cpe:2.3:a:pdf.js_viewer_project:pdf.js_viewer::::::wordpress::*.
Also for 2024/34xxx/CVE-2024-34408.json I don't think the CPE should be cpe:2.3:a:tencent:tencent:<IP_ADDRESS>00:::::windows::.
FYI

@serkanozkanssc would you mind opening this as a separate issue?

Actually, having talked about this, I think we need a strategy for a) picking between close but ambiguous CPEs (lol that those exist) and b) taking feedback on evidence-based reasoning as to why the original CPE was incorrect.
In the meantime, this particular XPDF things was updated.


Introduce length_basis

This PR replaces length(basis) with length_basis(model_or_basis) and implements a default fallback to length.  Because of the fall-back this should be fully backward compatible.
This allows having a model have a basis and throughout the assembly one passes around the model rather than the model.basis. It cleans up a few things in ACEpotentials.

I think basis_size might be a slightly clearer name for this concept, but length_basis is also fine.

I'm happy to change the name if you prefer. For context: in ACEpotentials I've now introduced several basis versions of functions such as
energy_basis
forces_basis
virial_basis
length_basis

The attempt here is to be consistent. But it doesn't have to be consistent. In light of the above, if you want me to change that name, let me know and I'll go ahead.

Since the first three return a basis (I assume), but the latter returns a length, I'm not too worried about consistency. From there, basis_size and/or basis_length sound more natural than length_basis.
I would also be tempted to do nothing here and instead require length(model) = length(model.basis).
But any of these are fine with me - you choose.

I'm nervous about length(model) because I can envision that the model length can mean a number of different things.
I'll use basis_size for now. Might be good to not clash with names in other modules - avoid confusion.
Is it ok if I make that change and then merge?

Sounds good, and yes.


Login succeeded but, but user information for "" could not be found when no search bases defined

Affected library

[X] Visus.LdapAuthentication (Just guessing, didn't verify)
[X] Visus.DirectoryAuthentication

Environment

Library version 0.12.0

Summary
When no LdapOptions.SearchBase is defined, the error Login succeeded but, but user information for "<User>" could not be found when no search bases defined is logged. Ran into this issue due to documentation / code misalignment from #13, so my configuration wasn't properly propagated. This should probably error at startup, because I assume having no search bases is always invalid.
What are you doing?
Logging in with valid username and password.
What is the problem?
The login succeeds, user information can't be found because there are no search bases.
What behaviour did you expect?
An error indicating no search bases are defined.
Additional context
This might perhaps be solved/validated with options post configuration.

Options validation is on my list, I haven't made up my mind what should be checked at startup (whether there is a base or whether there is a base that actually exists).

It's been a while since I've actively used an LDAP server, so I can't remember if it's possible (and makes sense) to search without a search base. However, Visus.DirectoryAuthentication will not search at all if no base is defined, so if the intended behavior is to search without a base then there should be some fallback. Then again, you currently can't specify scope either without specifying the search base and you can't have a null search base because it's a dictionary key.
Expanding this rationale should result in cases where the library will currently have to reject the login due to missing information, I guess all those situations should be validated upfront, regardless of the fact that it doesn't mean any of those settings is actually correct. Maybe it makes sense to have sane defaults for Visus.DirectoryAuthentication that will let it use the Active Directory schema, but I don't think that's a valid choice for Visus.LdapAuthentication.
Either way, I'm a happy user of the library, made it pretty easy for me to do LDAP/AD authentication for that specific case where the customer doesn't want to provide AD SSO.

With ADDS, I usually get the default naming context from rootDSE and apply this as fallback, but I need to check whether this is possible with AD Protocols/Novell.

OK, it seems you can search on null, but only to get the root DSE, at least in DirectoryServices.Protocols.

I am not yet decided on whether to generate a validation error or fixing it at runtime to use the default naming context. In the meantime, you could do the latter with the LdapConnectionExtensions.GetDefaultNamingContext extension method.

Version 0.16.0 adds an options validator.


Package made using yarn pack does not contain react-native-live-markdown-parser.js

Error: Failed to initialize Markdown runtime

Turns out that parser is a separate workspace defined in package.json. Most likely that's why parser/react-native-live-markdown-parser.json is not included.
When I remove parser from "workspaces" field in package.json, it works correctly.
Still no clue why it works correctly on CI.

Should be no longer relevant once we merge https://github.com/Expensify/react-native-live-markdown/pull/439

No longer relevant after we merged https://github.com/Expensify/react-native-live-markdown/pull/439


Add documentation for custom Docker networking using the CLI

Nice!
Please:

Make the minor changes
make lint
Confirm the rendered docs look good to you
Merge!

Codecov Report

Merging #1233 into master will decrease coverage by 73.48%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #1233       +/-   ##
===========================================
- Coverage   99.91%   26.42%   -73.49%
===========================================
  Files          31       30        -1
  Lines        2294     2274       -20
  Branches       88       86        -2
===========================================
- Hits         2292      601     -1691
- Misses          1     1662     +1661
- Partials        1       11       +10

Impacted Files
Coverage Δ

tests/test_dcos_e2e/test_node_install.py
0% <0%> (-100%)
:arrow_down:

tests/test_dcos_e2e/test_node.py
0% <0%> (-100%)
:arrow_down:

tests/test_cli/test_dcos_aws/test_cli.py
0% <0%> (-100%)
:arrow_down:

tests/test_dcos_e2e/test_enterprise.py
0% <0%> (-100%)
:arrow_down:

tests/test_dcos_e2e/backends/docker/test_docker.py
0% <0%> (-100%)
:arrow_down:

tests/test_cli/test_dcos_docker/test_cli.py
0% <0%> (-100%)
:arrow_down:

tests/test_dcos_e2e/backends/aws/test_aws.py
0% <0%> (-100%)
:arrow_down:

...est_dcos_e2e/backends/docker/test_distributions.py
0% <0%> (-100%)
:arrow_down:

tests/test_dcos_e2e/test_cluster.py
0% <0%> (-100%)
:arrow_down:

tests/test_cli/test_dcos_vagrant/test_cli.py
0% <0%> (-100%)
:arrow_down:

... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 465dc8f...1bae989. Read the comment docs.


Ask to add the Async version of ISecurityTokenValidator.ValidateToken method

It can be helpful to change the  ISecurityTokenValidator.ValidateToken method to async one and use it in JwtBearerHandler, OpenIdConnectHandler handlers.
I have faced with the lack of async implementing my own validator for JwtBearerHandler.
If you approve this idea I can make a PR with changes.

ISecurityTokenValidator is not implemented in this repo, it's over here:
https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/blob/e6d903b4f8d3c6d7697dc70cd54ae905b18b65fe/src/System.IdentityModel.Tokens.Jwt/ISecurityTokenValidator.cs


[Toast] Issue - Story not available

Description
When I try to run the example, I expected the Toast to be displayed, but instead I get an error.
 SyntaxError: The requested module '/node_modules/.vite/deps/@ark-ui_react.js?t=1713537708271&v=d7e29ef0' does not provide an export named 'Toaster'

Link to Reproduction (or Detailed Explanation)
https://codesandbox.io/p/devbox/dawn-shape-rx2y37?file=%2Fsrc%2FApp.tsx
Steps to Reproduce

Go to https://ark-ui.com/docs/components/toast
Copy paste example.
Compile it.

Ark UI Version
2.2.0
Framework

[X] React
[X] Solid
[ ] Vue

Browser
Chrome 124
Additional Information
Looks like the Docs is outdated.

@Manviel
Thanks mate. We re-wrote the toast api - docs will follow shortly. in the meantime check the code https://github.com/chakra-ui/ark/blob/main/frameworks/react/src/components/toast/examples/basic.tsx


Example Terraform prereqs module

https://github.com/awslabs/autonomous-driving-data-framework/pull/169


Whitelist false positive in issue #80

Adding domain kicksomeadhd.com to whitelist.me file

Uhh @mitchellkrogza solved this with https://github.com/mitchellkrogza/Phishing.Database/commit/e4806997b626fccea5331513bc5247e66443d58e  ....
Closing


Change README.md

Hello @JakeWharton,
I was upgrading the butterknife library from 7.0.1 to 8.4.0 and my Butterknife doesn't work correctly. I searched where the issue is coming. I implemented everything correctly, the code is correct (replace @Bind by @BindView). I put some logs after Butterknife.bind(this) + findViewById() and the butterknife doesn't find the resourceId but the findViewById does it.
I checked my build.gradle and I saw that I copied these follow lines from README.md :
dependencies {
compile 'com.jakewharton:butterknife:8.4.0'
annotationProcessor 'com.jakewharton:butterknife-compiler:8.4.0'
}
Instead of these lines from the website :
dependencies {
compile 'com.jakewharton:butterknife:8.4.0'
apt 'com.jakewharton:butterknife-compiler:8.4.0'
}
With apt 'com.jakewharton:butterknife-compiler:8.4.0' works for me.
Can you correct this ?
Thanks

The README is correct. The website is wrong. I'll update the website. Ensure you're using version 2.2.0 or newer of the Android Gradle plugin.

I noticed something very odd.  I also upgraded from version 7.0.1 to version 8.4.0.  And after the call to Butterknife.bind(this) inside an Activity, if i tried to access one of the views that i setup with a @BindView annotation and called a method on this view, the view was null.  Calling findViewById() would return the actual view.
So then i took a look at how i had dependencies set up.  Initially I had
annotationProcessor 'com.jakewharton:butterknife-compiler:8.4.0'
which seemed to be causing issues.
Then i switched to
apt 'com.jakewharton:butterknife-compiler:8.4.0'
and things started working as expected (views were non-null)
Then i switched back to
annotationProcessor 'com.jakewharton:butterknife-compiler:8.4.0'
and somehow things are now working.
It seems very odd and I am posting this because hopefully if someone else is having the same issue they wont be stuck like i was.


Allow for the HMMs to predict an unknown hidden state

It was decided, that in order to meet the contrains given by the scope of the thesis to omit the ability of the tool to predict a truly "hidden" state.


Additional See Also link

Could I suggest a See Also link for this page to Create FlowFields and FlowFilters: https://docs.microsoft.com/en-us/dynamics365/business-central/dev-itpro/developer/devenv-creating-flowfields-and-flowfilters since the link contains several examples.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 37572c51-ff70-217c-64d4-a28f0a52f93e
Version Independent ID: d79ec18b-2b69-1c50-7138-c2563b371176
Content: Calculation Formulas and the CalcFormula Property - Dynamics NAV
Content Source: dynamics-nav/Calculation-Formulas-and-the-CalcFormula-Property.md
Product: dynamics-nav-2018
GitHub Login: @jswymer

Hello, thanks for your feedback. In general, we do not link between documentation that describes C/AL to documentation for AL in order to not confuse the two. But we do try to port as much reusable documentation as possible. We will put this on our backlog. Thanks.


Enhanced Chat History Search

Confirm this is a feature request for the Python library and not the underlying OpenAI API.

[X] This is a feature request for the Python library

Describe the feature or improvement you're requesting
Problem:
Currently, users are unable to search through their chat history, making it difficult to locate specific information. This necessitates scrolling through the entire conversation history, which can be time-consuming and inefficient.
Proposed Solution:
Implement a search functionality within the chat history, similar to that of WhatsApp. This feature would allow users to quickly and easily find the information they need by simply entering keywords or phrases.
Benefits:
Enhanced User Experience: The ability to search chat history would significantly improve the user experience by making it easier to navigate and locate specific information.
Improved Efficiency: By eliminating the need to manually scroll through entire chat histories, users would save time and effort, leading to increased efficiency.
Reduced Frustration: The ability to quickly find the desired information would reduce frustration and improve overall user satisfaction.
Implementation Details:
The search functionality should be integrated seamlessly into the existing chat interface. Users should be able to access the search bar from any point within the chat history. The search results should be displayed in a clear and organized manner, highlighting the most relevant matches.
If this seems a relevant feature, shall I give this a try?
Additional context
No response

Thanks for the suggestion!
This sounds like an proposal for the underlying OpenAI API and not the Python library, so I'm going to go ahead and close this issue.
Would you mind reposting at community.openai.com?

Thanks for the suggestion!
This sounds like an proposal for the underlying OpenAI API and not the Python library, so I'm going to go ahead and close this issue.
Would you mind reposting at community.openai.com?

Sure


[Snyk] Upgrade org.apache.kafka:connect-api from 3.4.1 to 3.7.0

This PR was automatically created by Snyk using the credentials of a real user.![snyk-top-banner](https://github.com/andygongea/OWASP-Benchmark/assets/818805/c518c423-16fe-447e-b67f-ad5a49b5d123)
Snyk has created this PR to upgrade org.apache.kafka:connect-api from 3.4.1 to 3.7.0.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 7 versions ahead of your current version.

The recommended version was released on 4 months ago.

Issues fixed by the recommended upgrade:

Issue
Score
Exploit Maturity

Denial of Service (DoS)SNYK-JAVA-ORGXERIALSNAPPY-5710960
155
Proof of Concept

Allocation of Resources Without Limits or ThrottlingSNYK-JAVA-ORGXERIALSNAPPY-5918282
155
Proof of Concept

Integer Overflow or WraparoundSNYK-JAVA-ORGXERIALSNAPPY-5710959
155
Proof of Concept

Integer Overflow or WraparoundSNYK-JAVA-ORGXERIALSNAPPY-5710961
155
Proof of Concept

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
This PR was automatically created by Snyk using the credentials of a real user.
Max score is 1000. Note that the real score may have changed since the PR was raised.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:

🧐 View latest project report
📜 Customise PR templates
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

@ali-ince what do we do with this PR? Do we ignore it?

I think we can ignore this, as this is a dependency in provided scope.


Task 1730

Describe pull-request
Two new components. Chips and Messages
Solving issue
Fixes: AB#1730 and AB#1904
How to test

Go to the storybook
check chips, go thru the storie and see if they are correct
check messages, check the stories, and use the controls to se if you can create all variants.

Looks good and works great. It's weird that your commits however seem to remove quotes and add double quotes instead... :)

I will check the settings on my machine. Something is off for sure :D


Remove Modernizr, keep html5shiv (Webpack edition)

Modernizr has been part of the theme for a long time, although it is not used. Since its presence has downsides (reflow on load, increased theme size), we want to remove it.
To keep backward compatibility with older IEs, I've kept html5shiv in this PR so there is less chance of breakage.
This is a rework of #756 after our move to Webpack and friends. Rebasing did not make much sense.
Fixes #724, #525. Related #414. Supersedes #624 and #756

Any particular IE versions you want to see? Microsoft no longer offers free screenshots using Browserstack, that requires a paid account.
They do offer VMs with IE8 and up.

I tried saucelabs, but they dropped IE8 support. IE9 looked as expected though. I tried a demo account on browserstack, but couldn't test IE8. I even tried ie8 through wine to no avail.
I guess I'm not sure how thorough we need to be here then, testing sounds annoying. IE8 only accounts for 0.1% of RTD traffic, which also isn't 100% for projects using this theme.

Perhaps the best way to get feedback on this is to release a dev version of the theme and to wait for user responses or bug reports.

Sounds good.


Change Uop repr to a SortedSet

We were representing Uop with a List to try and avoid needing an Order instance for Identities, however it turned out to be straightforward to implement the latter, so we can now use a SortedSet for Uop which results in better performance and fixing the issue with Cogen.
[ch7021]

@alissapajer The current performance should be quite a bit improved. The semantics of Uop have always been set-like, when it was backed by a list we used an O(n^2) means of maintaining distinct values when merging (so that we only required Eq[A]). Now that we're requiring Order[A], we can use SortedSet which gives us O(n log n) merging.

@wemrysi ah! I didn't realize that we were enforcing set semantics previously with list. That's great!

@wemrysi already merged it, but I meant to ask why the version was breaking. Are the changes not entirely contained within qsu?

@alissapajer They are, but I thought breaking as the affected APIs are still public.


[Bug]: Issue Running Motsu

What happened?
When doing cargo test --lib in the stylus-hello-world repo with a simple motsu example
cargo test --lib
    Finished `test` profile [unoptimized + debuginfo] target(s) in 0.63s
     Running unittests src/lib.rs (target/debug/deps/stylus_hello_world-4e000e6348492506)
dyld[23977]: missing symbol called
error: test failed, to rerun pass `--lib`

Caused by:
  process didn't exit successfully: `/Users/me/Documents/code/rust/arbitrum/stylus-hello-world/target/debug/deps/stylus_hello_world-4e000e6348492506` (signal: 6, SIGABRT: process abort signal)

platform

[ ] linux
[ ] windows
[X] macos

Expected behavior
Expected tests to run properly
Contribution Guidelines

[X] I agree to follow this project's Contribution Guidelines

Hi @rauljordan, and thanks for submitting a bug report!
Which version of motsu are you using?
Also could you provide the full repro steps, or an online example?

hi @0xNeshi this happens in the current main branch of this repo
cd contracts && cargo test --lib finance
    Finished `test` profile [unoptimized + debuginfo] target(s) in 0.33s
     Running unittests src/lib.rs (/Users/me/Documents/code/rust/arbitrum/rust-contracts-stylus/target/debug/deps/openzeppelin_stylus-6547b1d800483b01)
dyld[34581]: missing symbol called
error: test failed, to rerun pass `--lib`

Caused by:
  process didn't exit successfully: `/Users/me/Documents/code/rust/arbitrum/rust-contracts-stylus/target/debug/deps/openzeppelin_stylus-6547b1d800483b01 finance` (signal: 6, SIGABRT: process abort signal)

On rustc 1.83.0-nightly (4ac7bcbaa 2024-09-04), which is defined in the rust-toolchain.toml

@rauljordan go to the root of the project, and run:
cargo test --all-features finance

Let me know if this worked for you

Thanks @0xNeshi this worked. Do you have some pointers on how I can get the same to run in the stylus-hello-world repo? What features need to be set in the Cargo.toml and command to use
[package]
name = "stylus-hello-world"
version = "0.1.9"
edition = "2021"
license = "MIT OR Apache-2.0"
homepage = "https://github.com/OffchainLabs/stylus-hello-world"
repository = "https://github.com/OffchainLabs/stylus-hello-world"
keywords = ["arbitrum", "ethereum", "stylus", "alloy"]
description = "Stylus hello world example"

[dependencies]
alloy-primitives = "=0.7.6"
alloy-sol-types = "=0.7.6"

mini-alloc = "0.4.2"
stylus-sdk = "0.6.0"
hex = "0.4.3"
dotenv = "0.15.0"

[dev-dependencies]
tokio = { version = "1.12.0", features = ["full"] }
ethers = "2.0"
eyre = "0.6.8"
openzeppelin-stylus = { path = "../rust-contracts-stylus/contracts", features = ["std"] }
motsu = { path = "../rust-contracts-stylus/lib/motsu" }
motsu-proc = { path = "../rust-contracts-stylus/lib/motsu-proc" }

[features]
export-abi = ["stylus-sdk/export-abi"]
debug = ["stylus-sdk/debug"]

[[bin]]
name = "stylus-hello-world"
path = "src/main.rs"

[lib]
crate-type = ["lib", "cdylib"]

[profile.release]
codegen-units = 1
strip = true
lto = true
panic = "abort"
opt-level = "s"

@rauljordan you seem to have downloaded motsu and the contracts library locally and linked them manually.
You don't need to do that, to use them you only need to add:
[dependencies]
# ...
openzeppelin-stylus = "0.1.1" # we're releasing 0.2.0 soon!
# if you want the latest contracts, link it like:
# openzeppelin-stylus = { git = "https://github.com/OpenZeppelin/rust-contracts-stylus" }

[dev-dependencies]
# ...
motsu = "0.2.1"

You can now use motsu!

Unrelated to motsu, there seems to be a problem with stylus-hello-world, and by extension with projects generated by Stylus CLI (which clones stylus-hello-world when creating new projects), where they have issues building and running tests, see https://github.com/OffchainLabs/stylus-hello-world/issues/43.
I created a PR to fix this (see https://github.com/OffchainLabs/stylus-hello-world/pull/44), so once it's merged you'll be able to use motsu with no problems!
In the meantime, you can copy/paste the changes from the PR into your project and run motsu immediately!


Cannot find or load main class

After adding Lombok jar from maven i get this error:
Error: Can't find or load main class
/Users/*****/Library/Caches/NetBeans/8.2/executor-snippets/run.xml:53: Java returned: 1
How can i fix this?

You installed the wrong jar file, the correct jar file is lombok-1.16.16


Paper link in README is not working

Hi!
The paper link in the readme points to https://github.com/google/lecam-gan/blob/master, which I assume is a mistake. My first thought was that this was maybe by design since CVPR2021 is in June and so the paper isn't public yet, but then I found it here, so I guess this is not the case.
Thanks for your work btw!

I've updated the ArXiv paper link. Thanks for pointing it out!


Publish to npm

The package should be published to npm, so it can used on a local machine too.
It can also be made compatible with npx, so that running npx p5-notebook (or npx p5nb) starts a server in the local directory and open a new browser tab. It should also serve other type of content such as images.

This should be automated with a GitHub Action workflow.


API docs are outdated

The API docs linked in the Readme seem to be quite outdated, and include the now non-existent embassy-util crate.

#994 makes CI build docs on every push to master.
All crates are now updated, except stm32 ones when CI finishes, probably in a few hours :sweat_smile:


One step costs one minute?

I followed the quick start guide and ran it on my laptop (equipped with an RTX 4070 8G graphics card) via WSL Ubuntu 22.04 and the Gradio demo.
Each step takes approximately one minute. Is this normal or have I made some error?

Can you provide us with the generation details like the input and output size, and how many images are used for conditioning and the size of them? These info are required for us to diagnose your problem as they influence the generation time a lot.

Can you provide us with the generation details like the input and output size, and how many images are used for conditioning and the size of them? These info are required for us to diagnose your problem as they influence the generation time a lot.

I tried the second demo and set both height and width to 512.

Since you have ticked the use_input_image_size_as_output option, the set output size is ignored and the original reference image size 2000×3000 is used. 8G of VRAM is quite low in OmniGen's standard, and I believe that extensive offloading or system RAM fallback happens in the background when you are generating, hence the miserable speed.  You might want to first downsize the image to a reasonable size (like 1024×680) and keep that option on, or untick the option and set the output size lower. To generate at 2000×3000 you might need something beefier.

Since you have ticked the use_input_image_size_as_output option, the set output size is ignored and the original reference image size 2000×3000 is used. 8G of VRAM is quite low in OmniGen's standard, and I believe that extensive offloading or system RAM fallback happens in the background when you are generating, hence the miserable speed. You might want to first downsize the image to a reasonable size (like 1024×680) and keep that option on, or untick the option and set the output size lower. To generate at 2000×3000 you might need something beefier.

Setting both separate_cfg_infer and offload_model to true will significantly enhance the speed. Thanks.


a warning in swift3,please fix it

i used this method:
cache.fetch(key: "funny-games.mp4").onSuccess { data in
// Do something with data
}
it throw a warning:"Result of call to '. onSuccess' is ununsed "
if i used it continue like this ：
cache.fetch(key: "funny-games.mp4").onSuccess { data in
// Do something with data
}.onFailure { (error) in
// Do something with error
}
it told me ：“Result of call to '. onFailure' is ununsed ”
how do I solve this problem?

Sorry if I'm missing something, but for me HanekeSwift won't build at all in Swift 3. Where is the working version?

Never mind my previous comment, I got it to work by having this in my podfile:
pod 'HanekeSwift', :git => 'https://github.com/Haneke/HanekeSwift', :branch => 'feature/swift-3'

@rytonbay  3Q

use the branch feature/swift-3


Custom kontainer-driver is active status while downloading binary

Rancher master 2/18
After I activate the cloud driver, the status of the driver becomes Active immediately while the driver's binary is still downloading. It should show the Downloading status instead of Active.
Reproduce:

Setup a rancher server in you laptop.
Disable the network(Wifi/Lan) and make sure you don't have the internet access.
Active one of the custom cloud drivers(aliyun/tencent/huawei) and you should see the status become Active immediately.

@rmweir to validate

Validated that driver goes to downloading upon activation.
Steps to validate:

Ran rancher
Navigated to drivers
Activated each inactive drive, alternating between menu activate and header active button.
Created a new driver using darwin version of Aliyun driver (https://github.com/rancher/kontainer-engine-driver-aliyun/releases/download/v0.2.4/kontainer-engine-driver-aliyun-darwin).

Results:
Each driver went to 'Downloading' and did not go appear to go to 'Active' first.

Validated that driver goes to downloading upon activation.
Steps to validate:
Ran rancher
Navigated to drivers
Activated each inactive drive, alternating between menu activate and header active button.
Created a new driver using darwin version of Aliyun driver (https://github.com/rancher/kontainer-engine-driver-aliyun/releases/download/v0.2.4/kontainer-engine-driver-aliyun-darwin).
Results:
Behaved as expected. Each driver went to 'Downloading' and did not go appear to go to 'Active' first.