Add Limit Orders Support from Manifest

Pull Request Description
Add support for Agents to be able to create limit orders on Manifest. Implements create market and place limit order. Can consider adding cancel and other features in follow ups.
Changes Made
This PR adds the following changes:

support for manifest limit orders and market creation

Implementation Details

use manifest-sdk

Transaction executed by agent

Example transaction:
Create Market: https://solscan.io/tx/59HgraXSzpmNtDovUfBUErjBwc2ggLtwfaYmrXdwR88HES6pLWHQWobHR85WmR3gHMavoEKLshCyJqx3Y6BZu8ku
Place limit order: https://solscan.io/tx/41d2CGSGdqkxXbuBDJwBniN3E9tN6hW7Tmo7oHQ1N1p5szejYhugKTLHaMNwS6KVp3DhMcTmZpkJMoWwKEpJAuf5
Prompt Used

Checklist

[x] I have tested these changes locally
[ ] I have updated the documentation
[x] I have added a transaction link
[x] I have added the prompt used to test it

hey @DonDuala - please also enter the prompt you used to test It, and the transaction link from that interaction

hey @DonDuala - please also enter the prompt you used to test It, and the transaction link from that interaction

https://solscan.io/tx/59HgraXSzpmNtDovUfBUErjBwc2ggLtwfaYmrXdwR88HES6pLWHQWobHR85WmR3gHMavoEKLshCyJqx3Y6BZu8ku

Limit order prompt and tx

https://solscan.io/tx/41d2CGSGdqkxXbuBDJwBniN3E9tN6hW7Tmo7oHQ1N1p5szejYhugKTLHaMNwS6KVp3DhMcTmZpkJMoWwKEpJAuf5

Limit order prompt and tx  https://solscan.io/tx/41d2CGSGdqkxXbuBDJwBniN3E9tN6hW7Tmo7oHQ1N1p5szejYhugKTLHaMNwS6KVp3DhMcTmZpkJMoWwKEpJAuf5

Can view the market here btw https://app.manifest.trade/market/2Uj8277fkaVBtTU6Wp2GPRbQC86SkSdgQ2mp1Q5N2LHc

@DonDuala looks good

Added cancel and withdraw
Cancel: https://solscan.io/tx/4pRuXVpMzaTC9vARDk45ZuLcJL8vRyAsBV7WUUxXUTePUzaWjpqgVRmCy2KCgFPCqCFaaHUGJ3wAdxCrDqZ1ME5i

Withdraw: https://solscan.io/tx/4pLGEXZnQWR1cZVDapTefAcQvFUvfxqLYtWXK8ewvhibDWM8QaNyXwKcgGfqPu93GBsGcuLW71pFma9F2eeW6AB5

@thearyanag @arihantbansal Think this is good to merge


Auto-Commenting Feature for PR Merged

Fixes Issue
Auto-Commenting Feature for PR Merged #140
Description:
To enhance our communication and acknowledgment process, we're implementing an auto-commenting feature for specific events within our project repository. This feature will automatically generate comments under the following circumstances:
PR Merged: Upon the successful merging of a pull request (PR), an auto-comment will be added to the corresponding issue, indicating that the PR has been merged and expressing gratitude to the contributor for their valuable contribution.
This is the message that should pop up: "[Auto-Comment]: 🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀
Screenshot:

Checklist:
Before submitting your pull request, ensure that you have completed the following tasks:

[x] I have carefully reviewed and adhered to the contributing guidelines before creating this pull request.
[x] I have tested the functionality of the feature before making the pull request.

Btw @A-b-i-r-a-m-i-G-S, I think I need to add something on the project, in your end its working, in this project its not. What did you add to makae it work?

@jfmartinz I didn't add anything extra to make it work. To help understand where the bug is could you share a screenshot of the repository settings for actions (Settings>Actions>General>Workflow permissions)?

It has read n write:

Maybe I need to add something or update this:

@jfmartinz check this out. It might resolve the issue you're facing.
https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository#controlling-changes-from-forks-to-workflows-in-public-repositories


Usage with angular2

Hi, I'm trying to make this work with angular2 but when I change routes to the route with the payment form then to another one and then back again I suddenly end up with multiple payment forms on the same page, any ideas? Example code is here:
https://github.com/ekarlso/angular2-seed

@ekarlso @bolten00 my first thought is the Drop-in is not being torn down before navigating away from the view. Are you calling teardown prior to your route change?
If you are calling teardown then the problem lies elsewhere and we can keep digging.

@kyledetella https://gitlab.com/creator-makerspace/members-ui

I ran git grep braintree in the repo @bolten00 provided, and I couldn't find any instance where teardown was being called.

So, I updated the https://github.com/ekarlso/angular2-seed fork that I have with a teardown that's called upon the Component ngOnDestroy event method, it doesn't seem to help anything with this?

@ekarlso and @bolten00 thanks for the links. It looks like something Angular 2 is doing with ngOnDestroy is interfering with the teardown function. When called inside ngOnDestroy, the teardown process starts, but never finishes.
We're looking into this further, but you could do something like this as temporary workaround until it's fixed:
import {Component} from 'angular2/core';

declare var braintree:any;

var braintreeHasBeenSetup = false;

@Component({
 // component stuff here
})
export class Home {
  ngOnInit() {
    var clientToken = "<YOUR_CLIENT_TOKEN>";

    if (!braintreeHasBeenSetup) {
      braintree.setup(clientToken, "dropin", {
        container: "payment-form",
        onReady: function(int) {
          braintreeHasBeenSetup = true
        }
      })
    }
  }
}

We'll report back here when we have a better fix.

An alternative solution, using CanDeactivate and promises:
import {Component} from 'angular2/core';
import {CanDeactivate} from 'angular2/router';

declare var braintree:any;

@Component({
 // component stuff
})
export class Home implements CanDeactivate {
  integration: any

  ngOnInit() {
    var c = this;

    var clientToken = "<client_token>";

    braintree.setup(clientToken, "dropin", {
      container: "payment-form",
      onReady: function(int) {
        c.integration = int
      }
    })
  }

  routerCanDeactivate() {
    var c = this;

    return new Promise(function(resolve, reject) {
      c.integration.teardown(function () {
        c.integration = null
        resolve()
      })
    })
  }
}


Test suite failing because of mismatched "Translation missing" messages

Description
Attempted to run bundle exec appraisal rake test however rake test was aborted at the 98.43% scan. 314/319. Rails Version 7.0.5
Screenshots/Files

message.txt
####Task
File to look into: gemfiles/rails_7.gemfile.lock

It looks like this is a ripple effect of i18n version 1.14.0 https://github.com/rails/rails/issues/48377


Time synchronisation with the orchestrator is very imprecise

Noticed this problem purely by chance, while running on the same machine as the orchestrator. The measurements are very imprecise, probably due to the way BestHTTP is structured.
I got this message:
stats: seq=2, ts=3227.079, component=OrchestratorController, orchestrator_ntptime_ms=1694040826972, localtime_behind_ms=-106, uncertainty_interval_ms=106

And, indeed, a machine is mathematically behind itself by 106 ms with an uncertainty of 106 ms, but still...

No longer relevant with orchestrator v2.


Improvement suggestion for sum_of_squares

Hi Deepak,
thanks for using numpy_groupies in flox. Out of curiosity I was reading through the codebase and noted that line:
https://github.com/dcherian/flox/blob/227ce041e9b78f8432c62370c9b2c46dd91fa657/flox/aggregate_npg.py#L17
It creates an intermediate array for the squares, which then gets summed up. In this context, this is likely to be a relevant time waster for allocating that intermediate array for the squares, while it could all be done in one go with simply a derived class based on
https://github.com/ml31415/numpy-groupies/blob/c11987005cccea1b3e990aba02ece482f3a00b1d/numpy_groupies/aggregate_numba.py#L240
class SumOfSquares(Sum):
    @staticmethod
    def _inner(ri, val, ret, counter, mean):
        counter[ri] = 0
        ret[ri] += val * val

Should do the trick and should be free of extra array and memory allocation and run in roughly the same time as the plain grouped sum.

Thanks Michael. That looks great.
I definitely need to do a performance pass. I've spent a lot of time trying to match xarray's current behaviour, and work more efficiently with dask, so I mostly skipped the performance aspect  with numpy arrays.


buffer_reference through push constant causing Assert/crash in spirv-reflect

I am trying to use spirv-reflect to find out which members are statically referenced in a push_constant containing multiple buffer_references.  This code is generated from slang, but I've stripped it down to create a minimal repro:
#version 450
#extension GL_EXT_buffer_reference : require
#extension GL_ARB_enhanced_layouts : require
#extension GL_EXT_nonuniform_qualifier : require
#extension GL_KHR_shader_subgroup_arithmetic : require
layout(row_major) uniform;
layout(row_major) buffer;

struct BDAGlobals_t_0
{
    vec4 g_vTest;
    vec4 g_vTest2;
};

layout(buffer_reference, std430, buffer_reference_align = 16) readonly buffer BufferPointer_BDAGlobals_t_0_1
{
    BDAGlobals_t_0 _data;
};

struct GlobalsBDAPushConstant_t_0
{
    BufferPointer_BDAGlobals_t_0_1  g_GlobalsBDAPerStage_0[6];
};

layout(push_constant)
layout(std140) uniform _S2
{
    BufferPointer_BDAGlobals_t_0_1  g_GlobalsBDAPerStage_0[6];
} g_GlobalsBDAPushConstant_0;

struct PS_OUTPUT_0
{
    vec4 vColor_1;
};

layout(location = 0) out vec4 _S149;

void main()
{

    _S149 = g_GlobalsBDAPushConstant_0.g_GlobalsBDAPerStage_0[0]._data.g_vTest;

    return;
}

If you compile this with glslangValidator as follows (or using the attached test.psv):
> glslangValidator -V spirv_reflect_bda.glsl -S frag -o test.spv

Then try to run it through spirv-reflect in a debug build (I'm on main to 3f468129720eded0cef4077302e491036d099856):
> spirv-reflect.exe test.spv
Assertion failed: base_var != 0, file C:\Users\dang\src\SPIRV-Reflect\spirv_reflect.c, line 631

@greg-lunarg had made patches to support reflecting statically referenced members in a buffer_reference, but it appears to be breaking down on this use case.
test.zip

this seems related to https://github.com/KhronosGroup/SPIRV-Reflect/issues/230
I added logic to prevent infinite looping, but seems that causes things to crash once someone tries to use a valid array like g_GlobalsBDAPerStage_0[6];... already started looking into a fix so can add this to it to make sure it works


Setheum Grant Proposal Update

Grant Application Checklist

[x] The application-template.md has been copied, renamed ( "project_name.md") and updated.
[x] A BTC address for the payment of the milestones is provided inside the application.
[x] The software of the project will be released under the Apache license version 2.0 as specified in the terms and conditions.
[x] The total funding amount of the project is below CHF 30k at the time of submission.

Updated the changes of https://github.com/w3f/Open-Grants-Program/pull/70

@JBA-Khalifa Thanks for the updates. I believe this PR is the same as the original proposal, now that you've also updated the original one with some extra commits. If they're indeed the same, please only keep the original one & close this PR, it will help us keep track of things :)


Added Indian Coin Change Problem

Description
Indian coin change problem gives the number of changes to be needed to make that number.
Done in C++
Given proper explanation.
Thanks
Fixes #730
Replace issue_no with the issue number which is fixed in this PR
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] Documentation Update

Checklist:

[x] My code follows the style guidelines(Clean Code) of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have created a helpful and easy to understand README.md
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests/screenshots(if any) that prove my fix is effective or that my feature works

@Shaishav0507 this is similar to https://tutorialspoint.dev/algorithm/greedy-algorithms/greedy-algorithm-to-find-minimum-number-of-coins

@Amit366
Brother if you know code remains same in every site.
Plus this is the code I worte.
No issues if you closed.

It is 60% same and yes I agree that the headers remain same, but even the variables and the function name cannot remain exactly same. @Shaishav0507  and yes we said we won't tolerate plagiarism.

Should I make another PR @Amit366

Should I make another PR @Amit366

With necessary changes of my own

And it's not exactly same .

Yes u can

Ok I'll do that.
Don't close the issue


Top to bottom Notification system

WIP

[x] Bind Configuration to state.  - This will allow us to update things in real time like we do with normal state values, whilst benefiting from the compatibility and ease of use of the config.
[x] Ensure that the config is properly loaded into state when application refreshes.
[x] Add Notification numbers to state. - This adds generic uints to state representing the count of notifications that are "unseen" coming from a given featureset. This does not replace things like the unread indicator because without a very granular layout something like this will be un-needed and overly complex. This is used for things like application badges to represent a global number of things a user should check on in the app. We also shouldn't abuse this by default like most apps, otherwise it becomes meaningless and it's "always red".
[x] Wire Notification actions to make correct internal calls for sounds & alerts.
[x] Update App Badge on Mac to display the count represented in state.ui.notifications.total()
[x] Wire config settings to only notify when the user wants.
[ ] Wire "Request Access" button in Notification Settings to prompt user for permissions to use notifications. There is a prompt similar to this for Apple Ventura Desktop which will be the target for this PR.

[x] Add a global toggle for all notifications - i.e. notifications on or off.
[x] Add button under developer settings to push a test notification in 3 seconds. (to give us time to focus some other app or minimize to test things)

Wire "Request Access" button in Notification Settings to prompt user for permissions to use notifications. There is a prompt similar to this for Apple Ventura Desktop which will be the target for this PR.

Moving this last one to a new issue for now until I can learn more about how to handle this. The rest is ready after conflicts are resolved.

@sdwoodbury @dariusc93 I went ahead and merged in with dev but there are a lot of additions to things that have been moved so I'm not sure if I broke something but signup is not working for me on mac anymore so I likely broke something but if you two could give it a quick glance over it might be obvious.

The Sidebar is so cool lol I did find a few bugs though lemme know if you want any certain ones made into tickets and I'll write em up

Sometimes toggles arent saving when the user logs out and back in again

https://user-images.githubusercontent.com/93608357/216237380-47b957b1-8212-4856-a004-92514db542c6.mov

User can also toggle on and off message/Friends/Settings even if the main notification toggle is off

https://user-images.githubusercontent.com/93608357/216237511-5f2d971b-ae4a-495c-9a53-e0ed9d7fb9dc.mov

This one is pretty weird. There seems to be 2 click areas for the sidebar. The one to the right thats right overtop the border of the sidebar is pretty  small and hard to click

https://user-images.githubusercontent.com/93608357/216237667-ba7ec265-670f-45ae-b601-f2b782c9a946.mov

If you drag the sidebar out enough it will render behind the Uplink Logo. While its behind the logo it will not be clickable

https://user-images.githubusercontent.com/93608357/216237751-360b7af9-1a93-4d02-b376-21319792aeb8.mov

It looks like on every page except for the chat page there is a border that stops the user from dragging the sidebar across the entire screen. I assumed the chat page not having a border was a bug.

https://user-images.githubusercontent.com/93608357/216237922-735f2e7a-440f-4cc3-8aeb-fe9601a20029.mov

I think this could be fixed in the ticket we have to have the user not be able to select the entire screen. When you drag the sidebar when there is text on the screen you will usually highlight all of the text.

https://user-images.githubusercontent.com/93608357/216238104-fead593d-f5f5-4352-9cee-d0facb2609b1.mov

This one is pretty weird. There seems to be 2 click areas for the sidebar. The one to the right thats right overtop the border of the sidebar is pretty small and hard to click
This is because the "background" for the scrollbar is transparent, but what's actually happening is you're moving from the left to the right edge of the scrollbar track. At least that's my hypothesis, it could be checked out with a different theme created with non transparent scrollbars

https://user-images.githubusercontent.com/1770198/216239787-bd1ffbfc-4084-4003-b7cb-2ce9b0aaa5a3.mov

User can also toggle on and off message/Friends/Settings even if the main notification toggle is off

should be resolved

For the rest of the issues that are not related to the notifications itself we should consider moving to a new backlogged ticket, the resizing is just nice extra functionality and the dev logger itself is just for people doing dev work so we can put up with some small bugs or fix it ourselves.

Also experienced some bugs when retesting, after clearing data (and of course cargo update/clean) when user hits enter after creating username app will just close without any panics in terminal
https://user-images.githubusercontent.com/93608357/216390556-1ee394b3-b14e-48cf-b49c-94451c7da56c.mov

@sdwoodbury @dariusc93 I went ahead and merged in with dev but there are a lot of additions to things that have been moved so I'm not sure if I broke something but signup is not working for me on mac anymore so I likely broke something but if you two could give it a quick glance over it might be obvious.

logging in on dev works and logging in in this branch works as of commit dcd5a57fd8e9ec6e07bc8df73c5ac0afc4bf916f, which was before that merge with dev. it might be worth checking out commit dcd5a57fd8e9ec6e07bc8df73c5ac0afc4bf916f, creating a new branch, and trying the merge again.


allow for set number of clusters for k_means

why not use techniques to determine k?

we do but just in case user wants a specific number of clusters


Native support for Radar plots as a LayerSpec object

Would love to see Radar plots being natively supported in the lets-plot library to expand the library's richness.
I believe it would be a good addition to be able to visualize datasets with multivariate features against multiple categories!

See discussion https://github.com/JetBrains/lets-plot/discussions/952

Hi @OSuwaidi , since 4.3.0 radar/spider plots are supported via coord_polar() + "flat" option:

https://nbviewer.org/github/JetBrains/lets-plot/blob/master/docs/f-24a/coord_polar.ipynb
https://nbviewer.org/github/JetBrains/lets-plot-docs/blob/master/source/examples/demo/palmer_penguins.ipynb


CUDA not installed at startup on Ubuntu 16.04

Created a cluster with (abridged) config:

[cluster default]
master_instance_type = m4.xlarge
compute_instance_type = g2.2xlarge
base_os = ubuntu1604
post_install = s3://<PATH_TO_FILE>.sh

NVIDIA driver installed correctly, but CUDA toolkit did not.
No entry exists in /usr/lib, /usr/bin, /usr/local or any other logical location
Nor was nvcc shown as installed, as listed by nvcc -V
However, sudo apt install nvcc worked correctly when run manually in the compute instance.
From issue #140 and #123 I surmise that this is not intended behaviour, as CUDA should be installed upon creation.

Is there an option to specify a variable for CustomChefRunList or can I potentially add this to extraJson:
“nvidia” : {         “enabled” : ‘yes’     }

Seems to be caused by the c++ compiler version, which is incompatible with CUDA 7.5

We don't plan to add native cuda support in cfncluster.

My bad !!! I will take a deep look at this issue tomorrow.

Apologies for delay in looking at this issue (was working on cfncluster new release). As part of cfncluster 1.4.0 we upgrade to cuda9 and nvidia driver. Can you confirm you still see this issue? Note : we are not installing nvcc as part of cookbook

I'm using cfncluster 1.4.1 and I've put the following snippet in my cluster definition:
base_os = ubuntu1604
extra_json : { "nvidia" : { "enabled" : "yes" } }
compute_instance_type = p3.8xlarge
master_instance_type = c5.4xlarge

On the compute nodes, /opt has no traces of CUDA of any sort.  What am I doing wrong?

As part of ParallelCluster 2.5.0 we updated Nvidia drivers and CUDA libraries and introduced tests that verify their setup. I'm going to resolve this one.


feat(gax): x-goog-api-client header formatter

Part of the work for #249

Look at #400 if you are interested in the end game for this.


Update all tools that take an address to instead take a symbol as well

Everything should work like the Decompile Function tool and let python and Java figure out what the LLM wants. It is not reliable to have the LLM input an address all the time.

This is mostly done. I think I need to add a second output function that outputs the most relevant name for an address.

Symbol
Function
Data
Address

Fixed in b17464bf996bed6ee8fe4ed0f528ab2073a05371


lxd init create new btrfs storage pool on disk partition

Required information

Distribution: Ubuntu
Distribution version: 18.04
The output of "lxc info" or if that fails:

Kernel version: 5.0.0-31-generic
LXC version: 3.18
LXD version: 3.18
Storage backend in use: brtfs

Issue description
Initialize lxd via lxd init with new storage pool (btrfs) on disk partition raise error. Example create new btrfs  storage pool on /dev/sda3  raise error, with disk device /dev/sdb it works.
Steps to reproduce

sudo lxd init
Dialog:
Would you like to use LXD clustering? (yes/no) [default=no]:
Do you want to configure a new storage pool? (yes/no) [default=yes]:
Name of the new storage pool [default=default]:
Name of the storage backend to use (btrfs, ceph, dir, lvm, zfs) [default=zfs]: btrfs
Create a new BTRFS pool? (yes/no) [default=yes]:
Would you like to use an existing block device? (yes/no) [default=no]: yes
Path to the existing block device: /dev/sda3
Would you like to connect to a MAAS server? (yes/no) [default=no]:
Would you like to create a new local network bridge? (yes/no) [default=yes]:
What should the new bridge be called? [default=lxdbr0]:
What IPv4 address should be used? (CIDR subnet notation, “auto” or “none”) [default=auto]:
What IPv6 address should be used? (CIDR subnet notation, “auto” or “none”) [default=auto]:
Would you like LXD to be available over the network? (yes/no) [default=no]:
Would you like stale cached images to be updated automatically? (yes/no) [default=yes]
Would you like a YAML "lxd init" preseed to be printed? (yes/no) [default=no]:

Error: Failed to create storage pool 'default': Failed to create the BTRFS pool: btrfs-progs v4.4
See http://btrfs.wiki.kernel.org for more information.

Workaround:
sudo mkfs.btrfs /dev/sda3
sudo mkdir /mnt/lxdpool
sudo mount /dev/sda3 /mnt/lxdpool  or  edit /etc/fstab
sudo lxd init
Would you like to use LXD clustering? (yes/no) [default=no]:
Do you want to configure a new storage pool? (yes/no) [default=yes]:
Name of the new storage pool [default=default]:
Name of the storage backend to use (btrfs, ceph, dir, lvm, zfs) [default=zfs]: btrfs
Create a new BTRFS pool? (yes/no) [default=yes]: no
Name of the existing BTRFS pool or dataset: /mnt/lxdpool
Would you like to connect to a MAAS server? (yes/no) [default=no]:
Would you like to create a new local network bridge? (yes/no) [default=yes]:
What should the new bridge be called? [default=lxdbr0]:
What IPv4 address should be used? (CIDR subnet notation, “auto” or “none”) [default=auto]:
What IPv6 address should be used? (CIDR subnet notation, “auto” or “none”) [default=auto]:
Would you like LXD to be available over the network? (yes/no) [default=no]:
Would you like stale cached images to be updated automatically? (yes/no) [default=yes]
Would you like a YAML "lxd init" preseed to be printed? (yes/no) [default=no]:

When this originally came up before, @stgraber suggested that a likely cause of this error was that there was an existing filesystem or partition on the device that was detected.
@danielecim the specific bug that results in the output of btrfs-progs v4.4 only was fixed here https://github.com/lxc/lxd/pull/6282 so in the future if this occurs again you should see the actual error message.

Just did some testing here, using the same snap and kernel version, a clean block device or partition does work fine, one which is dirty (has an existing label/filesystem) causes a failure.
Prior to the fix we did recently, this would result in an error matching the one in this issue, with the recent fix applied, I now get:
root@edfu:~# lxc storage create btrfs btrfs source=/dev/sdd
Error: Failed to create the BTRFS pool: Failed to run: mkfs.btrfs /dev/sdd -L btrfs: /dev/sdd appears to contain an existing filesystem (btrfs).
Use the -f option to force overwrite. (btrfs-progs v4.4
See http://btrfs.wiki.kernel.org for more information.
)

So it seems likely to be the source of the issue here and even if it's not, the direct error from mkfs.btrfs will now be visible. Closing since we do have a fix in master for this already.


Prisoner Recruitment only allows Tier 4 or lower.

Looking at the code:
if (!IsPrisonerRecruitable(characterAtIndex) || characterAtIndex.Tier > 6)
{
      continue;
}

So Tier 6 shouldn't be recruitable, that's fine but the DefaultPrisonerRecruitmentCalculationModel returns the following:
	public override float[] GetDailyRecruitedPrisoners(MobileParty mainParty)
	{
		return new float[5]
		{
			1f,
			0.5f,
			0.3f,
			0.2f,
			0.1f
		};
	}

Which is the 'probability' that each tier gets recruited.
However Tier 0 isn't a thing (Well it is, applies to Heroes actually) for troops.
So it's an off by one error, just need to replace that list with something like:
	public override float[] GetDailyRecruitedPrisoners(MobileParty mainParty)
	{
		return new float[5]
		{
			1f,
                        1f,
			0.5f,
			0.3f,
			0.2f,
			0.1f
		};
	}

for the mod, (Proper fix is of course just decrement the Tier by 1 in the actual code or use a different structure like a Dictionary to determine this, also the method name is a bit confusing...)

It does look like it should be tier 5 or lower instead of tier 4 or lower.

There's actually an alternative to this instead, looks like this RNG way they have of handling recruitment was a band-aid they slapped on.
The conformity system they have partially implemented looks to be the more intended approach (Given it has UI elements and explaination). Looking into that path may be of value.
I think that should probably be a seperate improvement ticket though.

Can you please explain how this code suggests that Tier 6 prisoners should not be recruitable?


Replace homepage DOI box with a search

Instead of just taking a DOI, allow searching for things like the title and presenting a list when more than 1 result is returned.

Spike: delegate search to Europe PMC

Where will results go? What is the resultant experience? How can it be improved?


Move metrics into stats so it can be used without importing plotting packages

Moving metrics (and a couple metrics helper functions) into stats.

Apologies for all of the pushes/commits. I had a couple adjustments to make, and then I wanted to squash them.

I quite like this idea--makes sense. I also see that it is in direct conflict with my PR, which I also think is a good idea. Would you like me to incorporate these changes into what I've done so these PR's are not in conflict with each other?

The metrics() is indeed a report - that's why it's there. Plus - this is a backward compatibility-breaking change.
A possible alternative to achieve your goal is to use dynamic import inside the reports module and skip the plot-related imports unless plotting is actually required.


Migration in plugin is causing issues

Hi,
We have been using your plugin on one of our live project for over a year now and we now want to update our project to Sylius 1.12.16 and have to update the CMS plugin to the 4.0.9 version. The problem is that in this new version the migration is directly including in the plugin causing issues on our database.
Do you have any idea on how to workaround this issue?

I've manually registered them 'as executed' through the Symfony CLI commands.. but yeah, the migrations here should just detect if certain tables are already present and then silently finish execution.


Create a STL file with XYZ 2D arrays

I need help of how to create a STL file having my X Y Z 2D arrays.
I saw this example but i'm having trouble finding a way out.
https://github.com/WoLpH/numpy-stl/issues/89

This is the problem in my code, where
xInterp, yInterp and zInterp are 2D arrays
Thank you!

This issue has been discussed over email a bit already but I'm not sure how to fully solve it. Here's the code for completeness though :)
import numpy as np

x_all = np.hstack(valorX)
y_all = np.hstack(valorY)
z_all = np.hstack(valorZ)

tris = mtri.Triangulation(x_all, y_all)

data = np.zeros(len(tris.triangles), dtype=mesh.Mesh.dtype)
m = mesh.Mesh(data, remove_empty_areas=False)
m.x[:] = x_all[tris.triangles]
m.y[:] = y_all[tris.triangles]
m.z[:] = z_all[tris.triangles]
m.save('model.stl')

from matplotlib import pyplot
from mpl_toolkits import mplot3d

# Create a new plot
figure = pyplot.figure()
axes = mplot3d.Axes3D(figure)

# Render the cube
axes.add_collection3d(mplot3d.art3d.Poly3DCollection(m.vectors))

# Auto scale to the mesh size
scale = m.points.flatten(-1)
axes.auto_scale_xyz(scale, scale, scale)

# Show the plot to the screen
pyplot.show()


Add Guide

Is it possible to set up a guide? Is it possible to adjust the weight by a specific tag? (conventionally an #minecraft:iron_pickaxe)

There currently isn't support for tags, however I'll look into implementing it, and I agree, I probably should have documented the config file. I'll update the mod page on Modrinth and CurseForge soon.


Raw image installation

Describe the solution you'd like:
[A clear and concise description of what you want to happen.]
The current way of installation needs to storage devices, one for the "ISO" (aka seed image) and one ('disk') for the actual disk to be partitioned, etc.
It should also be possible to install with a single device: directly install on the disk with a 'raw image'. (That would be similar to .qcow or .ova images for VM installs)
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
The recently added "reset" feature could be the starting point for "raw image" installations:
"reset" reboots into the recovery partition. To do so, only the 'boot' and the 'recovery' partitions need to be present. Everything else (the MachineInventory, the 'persistent' partition, etc.) are (re-)created when performing a reset.
A similar approach could be taken by "raw image". The raw image would only contain a "boot" and a "recovery" partition, making it only slightly larger than the current ISO.
The raw image would be dumped to a 'disk' device (ssd for most systems, probably SD-card for Raspberry 🤔 ) and the machine booted from this disk.
It would then go through a similar workflow like "reset" and

download registration info
create MachineInventory
create all other partitions besides 'boot' and 'recovery'

(That would be similar to a full installation workflow, except that boot and recovery are already existing)
Open questions

how to get the initial registration info (aka "livecd-cloud-config.yaml") into the raw image ?

Would it make sense to have a build-raw action in the elemental cli?
This should be parallel to build-iso and we could have the raw image served as we currently serve the iso.
It's also important I think that we do exploit the elemental-register --install argument (instead of --reset), so that when we implement installation status tracking, this will be consistent with iso installs.

Yes, something like build-raw (which would probably share a lot with build-iso) would be ok.
However, we already have (too?) many build steps hardcoded in elemental-cli. And I wonder how to make them more flexible.
Maybe we could start with a post-build implementation, similar to generate-rpi-image 🤔

The benefit of using the elemental-cli is that we can keep the workflow parallel to the iso.
That will also include image channels I guess.
So from the user point of view everything will be the same, they will just be able to download an .iso or a .raw(?) image from the seedimage pod. We should also inject the machine registration config as we do with the iso, so that there is no further action needed. Just dd the image into a disk, boot the machine, and you are done.
It is a lot of changes though. The biggest problem is that I don't think we have an architecture level for the images. Ideally as a user I would like to set the architecture on the MachineRegistration.
This should lead to the generation of either amd64 or aarch64 ISOs, depending on what I configured.
It could be an array, so that images for multiple architectures can be built and offered for download. This could be important if we want to support multi-architecture clusters.
I think that we could start by officially supporting the aarch64 ISO before we implement this issue.

I think that we could start by officially supporting the aarch64 ISO before we implement this issue.

This is actually just waiting for a respective ARM board (Raspberry cannot boot from ISO - and that's the only ARM board we have available 🤷🏻 )

Yeah I guess it will be mostly useless, but at least we can use it for modeling the architecture on the MachineRegistration, otherwise arm artifacts will always be external and will always have a different workflow.
For testing I guess we could just use QEMU.

For comparison, you can see that SLE Micro does ship .iso
https://www.suse.com/download/sle-micro/
So maybe there is a use case out there.
If we model the architecture it should be easy to add more in the future and keep everything consistent.
I would love to see Elemental on mainframes.

As we discussed, I created #948 so that we can first model and implement multi-arch support on the operator/seedimage-builder side.

arm ISOs are possible and IIRC we have (or used to have) the configuration ready in elemental-toolkit to build and test arm ISOs, we never published them because we can't test them in real hardware.

Customer Story supporting such Use Case
In my project we have to flash multiple devices (20+) each time when preparing for production.
Doing so with iso's is quite cumbersome and checking for validity is quite hard, as many things can possibly go wrong.
Flashing raw images to storage (of whichever kind) on multiple devices and checking validity of installation reduces to (dd-ing) with e.g. clonezilla in a pxe-boot environment and comparing checksums.
So this use feature makes our live much easier! <3
Additional thoughts
To unify with the iso installation, maybe it would also be a viable solution to reduce iso installation to be installed to boot and recovery partition even before registering to upstream mgmt cluster.
This way after the "copying" content to partitions the workflow would be the same.
Regarding: "how to get the initial registration info (aka "livecd-cloud-config.yaml") into the raw image ?"
Currently the live-cd-cloud-config is embedded in the iso build process (as an iso-overlay) available in /run/live/...
Maybe it also makes sense to have such config file available (writeable) on the rootfs. (don't know if that's possible for the iso with xorriso easily)
That would enable easy altering of such at runtime, if needed (e.g. reset device and onboard to another mgmt cluster)
With this approach, adding the file to the raw-image also reduces to just mounting the image and copying the yaml downloaded from the registration endpoint.

In rancher/elemental-toolkit#1794 we already defined a process for building disk images. Something we wanted to keep is the possibility to actually build the disk on a non privileged container under certain constraints. Note this means not a single mount is performed during the disk build.
In rancher/elemental-toolkit#1794 a new process independent of installation and ISO build has been created. All three processes already share relevant chunks of code so I think the internal elemental-toolkit API works fine in that regard, we already did great efforts on that direction during last spring and summer.
How to get the initial registration info into the raw image?
Should be possible to include config files in OEM partitions as part of a hook during build disk. This is one of the things that should be prepared within the context of a seedimage in elemental-operator.

The recently added "reset" feature could be the starting point for "raw image" installations:
"reset" reboots into the recovery partition. To do so, only the 'boot' and the 'recovery' partitions need to be present. Everything else (the MachineInventory, the 'persistent' partition, etc.) are (re-)created when performing a reset.
A similar approach could be taken by "raw image". The raw image would only contain a "boot" and a "recovery" partition, making it only slightly larger than the current ISO.

Indeed this is the approach taken by https://github.com/rancher/elemental-toolkit/pull/1794, it creates a disk including a recovery image and then on first boot is instructed to call reset which will in turn do the full deployment with the right partitions and reboot.
However note this comments https://github.com/rancher/elemental-toolkit/pull/1794#issuecomment-1757044517 , some further refactor on how to manage the bootloader configuration is required to actually allow creating disks without the state partition (we currently install the bootloader within the state partition). That would actually take us to the desired goal of having disk images of a similar size of an ISO.


[Help wanted] Command "python setup.py egg_info" failed with error code 1

When running "pip install -r requirements.txt" i get
"Command "python setup.py egg_info" failed with error code 1 in c:\users\magnus\appdata\local\temp\pip-build-06gz2k\pyproj"
The folder pip-build-06gz2k\pyproj\ doesn't exist.
I have obviously installed pip as well as SetupTools.
When going a step further, ignoring the error, i get
"Traceback (most recent call last):
File "pokebot.py", line 15, in
from pgoapi import PGoApi
File "C:\Users\Magnus\Desktop\POGO\pgoapi_init_.py", line 16, in
raise PleaseInstallProtobufVersion3()
pgoapi.exceptions.PleaseInstallProtobufVersion3"
when typing "python pokebot.py -i 0"
And the same when i add --cache, afterwards.
Any help is much appreciated! I obviously know very little about Python so this might just be a noob mistake.

Please upgrade to latest dev branch by running this command:
git reset --hard
git pull -f

Then run this command to upgrade your deps:
pip install --upgrade -r requirements.txt
Please tell me if that solved your issue.

Seems like it worked, thanks! Now i'll just have to figure out how to make this thing run :D

Issue has been resolved.
/closed


Update googletest to fix build errors with newer msvc2017 version

Testing:

https://ci.appveyor.com/project/ingenue/hunter/build/1.0.3044
https://travis-ci.org/ingenue/hunter/builds/317361333?utm_source=github_status&utm_medium=notification

Uploading:

https://ci.appveyor.com/project/ingenue/hunter/build/1.0.3045
https://travis-ci.org/ingenue/hunter/builds/317380709?utm_source=github_status&utm_medium=notification

Released: https://github.com/ruslo/hunter/releases/tag/v0.19.198


Information Retrieval: Making Citing and Acknowledgements Easy

Based on the original ideas in #116, this PR introduces scripts/info.py as a utility to retrieve, save, and inspect all of the citations and acknowledgements for the underlying data.

License field currently unfilled for:

[ ] chandra
[ ] gaia
[ ] jwst
[ ] legacysurvey
[ ] sdss
[ ] vipers

cfa and new PRs need to be checked against info.py to make sure their citations and acknowledgements are stored correctly.


linker: remove asterisk from IRQ/ISR section name macro

Both _IRQ_VECTOR_TABLE_SECTION_NAME and _SW_ISR_TABLE_SECTION_NAME
are defined with asterisk at the end in an attempt to include
all related symbols in the linker script. However, these two
macros are also being used in the source code to specify
the destination sections for variables. Asterisks in the name
results in older GCC (4.x) complaining about those asterisks.
So create new macros for use in linker script, and keep
the names asterisk free.
Fixes #29936
Signed-off-by: Daniel Leung<EMAIL_ADDRESS>

CI complains about no space in _CONCAT(name,*). However, if I add a space before *, the section symbols in linker script becomes name * instead name*, which toolchain cannot really parse correctly.

CI complains about no space in _CONCAT(name,*). However, if I add a space before *, the section symbols in linker script becomes name * instead name*, which toolchain cannot really parse correctly.

@dcpleung
I expect that this change will break ARC MWDT toolchain, so could you please give us some time to verify this before merging.
Thanks!

@dcpleung
I expect that this change will break ARC MWDT toolchain, so could you please give us some time to verify this before merging.
Thanks!

I expect that this change will break ARC MWDT toolchain, so could you please give us some time to verify this before merging.
Thanks!

Does the ARC MWDT toolchain require the section name to have asterisk in the C source code? The macros __sw_isr_table and __irq_vector_table use the section name macros. Then they are being used in arch/common/isr_tables.c to define variables _irq_vector_table[] and _sw_isr_table[]. The asterisks in linker script are usually being used for wildcard matching and not part of section names.

I expect that this change will break ARC MWDT toolchain, so could you please give us some time to verify this before merging.
Thanks!

Does the ARC MWDT toolchain require the section name to have asterisk in the C source code? The macros __sw_isr_table and __irq_vector_table use the section name macros. Then they are being used in arch/common/isr_tables.c to define variables _irq_vector_table[] and _sw_isr_table[]. The asterisks in linker script are usually being used for wildcard matching and not part of section names.

Does the ARC MWDT toolchain require the section name to have asterisk in the C source code?

No we don't need asterisk in the C source code so that should be OK. I've misinterpreted that part of code.
However, I've tested the change and I got build errors with MWDT toolchain:
[ 89%] Generating linker.cmd
In file included from /slowfs/ru20arcjenkins/de02-arcjenkins2/slaves/ru20-gp-hw-linux110/workspace/arcoss_verification/zephyr_verification/sanity_check/zephyr/soc/arc/snps_nsim/linker.ld:31:
In file included from /slowfs/ru20arcjenkins/de02-arcjenkins2/slaves/ru20-gp-hw-linux110/workspace/arcoss_verification/zephyr_verification/sanity_check/zephyr/include/arch/arc/v2/linker.ld:89:
In file included from /slowfs/ru20arcjenkins/de02-arcjenkins2/slaves/ru20-gp-hw-linux110/workspace/arcoss_verification/zephyr_verification/sanity_check/twister-out/nsim_hs/samples/synchronization/sample.kernel.synchronization/zephyr/include/generated/snippets-rom-start.ld:1:
/slowfs/ru20arcjenkins/de02-arcjenkins2/slaves/ru20-gp-hw-linux110/workspace/arcoss_verification/zephyr_verification/sanity_check/zephyr/include/../arch/arc/core/vector_table.ld:11:8: error: pasting formed 'irq_vector_table*', an invalid preprocessing token
KEEP(*(_IRQ_VECTOR_TABLE_SECTION_SYMS))
       ^
/slowfs/ru20arcjenkins/de02-arcjenkins2/slaves/ru20-gp-hw-linux110/workspace/arcoss_verification/zephyr_verification/sanity_check/zephyr/include/linker/sections.h:35:40: note: expanded from macro '_IRQ_VECTOR_TABLE_SECTION_SYMS'
#define _IRQ_VECTOR_TABLE_SECTION_SYMS  _CONCAT(.gnu.linkonce.irq_vector_table,*)
                                        ^
/slowfs/ru20arcjenkins/de02-arcjenkins2/slaves/ru20-gp-hw-linux110/workspace/arcoss_verification/zephyr_verification/sanity_check/zephyr/include/toolchain/common.h:125:23: note: expanded from macro '_CONCAT'
#define _CONCAT(x, y) _DO_CONCAT(x, y)
                      ^
/slowfs/ru20arcjenkins/de02-arcjenkins2/slaves/ru20-gp-hw-linux110/workspace/arcoss_verification/zephyr_verification/sanity_check/zephyr/include/toolchain/common.h:124:28: note: expanded from macro '_DO_CONCAT'
#define _DO_CONCAT(x, y) x ## y
                           ^
In file included from /slowfs/ru20arcjenkins/de02-arcjenkins2/slaves/ru20-gp-hw-linux110/workspace/arcoss_verification/zephyr_verification/sanity_check/zephyr/soc/arc/snps_nsim/linker.ld:31:
In file included from /slowfs/ru20arcjenkins/de02-arcjenkins2/slaves/ru20-gp-hw-linux110/workspace/arcoss_verification/zephyr_verification/sanity_check/zephyr/include/arch/arc/v2/linker.ld:100:
/slowfs/ru20arcjenkins/de02-arcjenkins2/slaves/ru20-gp-hw-linux110/workspace/arcoss_verification/zephyr_verification/sanity_check/zephyr/include/linker/common-rom.ld:29:5: error: pasting formed 'sw_isr_table*', an invalid preprocessing token
                *(_SW_ISR_TABLE_SECTION_SYMS)
                  ^
/slowfs/ru20arcjenkins/de02-arcjenkins2/slaves/ru20-gp-hw-linux110/workspace/arcoss_verification/zephyr_verification/sanity_check/zephyr/include/linker/sections.h:38:36: note: expanded from macro '_SW_ISR_TABLE_SECTION_SYMS'
#define _SW_ISR_TABLE_SECTION_SYMS      _CONCAT(.gnu.linkonce.sw_isr_table,*)
                                        ^
/slowfs/ru20arcjenkins/de02-arcjenkins2/slaves/ru20-gp-hw-linux110/workspace/arcoss_verification/zephyr_verification/sanity_check/zephyr/include/toolchain/common.h:125:23: note: expanded from macro '_CONCAT'
#define _CONCAT(x, y) _DO_CONCAT(x, y)
                      ^
/slowfs/ru20arcjenkins/de02-arcjenkins2/slaves/ru20-gp-hw-linux110/workspace/arcoss_verification/zephyr_verification/sanity_check/zephyr/include/toolchain/common.h:124:28: note: expanded from macro '_DO_CONCAT'
#define _DO_CONCAT(x, y) x ## y
                           ^
2 errors generated.
gmake[2]: *** [zephyr/linker.cmd] Error 1
gmake[1]: *** [zephyr/CMakeFiles/linker_script_target.dir/all] Error 2
gmake: *** [all] Error 2

I'm not sure why do we need _CONCAT macros, as we don't do any de-duplication in current implementation anyway:
#define _IRQ_VECTOR_TABLE_SECTION_NAME	.gnu.linkonce.irq_vector_table
#define _IRQ_VECTOR_TABLE_SECTION_SYMS	_CONCAT(.gnu.linkonce.irq_vector_table,*)

#define _SW_ISR_TABLE_SECTION_NAME	.gnu.linkonce.sw_isr_table
#define _SW_ISR_TABLE_SECTION_SYMS	_CONCAT(.gnu.linkonce.sw_isr_table,*)

Any inside about that? Can we drop the _CONCAT and do something like that?
#define _IRQ_VECTOR_TABLE_SECTION_NAME	.gnu.linkonce.irq_vector_table
#define _IRQ_VECTOR_TABLE_SECTION_SYMS	.gnu.linkonce.irq_vector_table*

#define _SW_ISR_TABLE_SECTION_NAME	.gnu.linkonce.sw_isr_table
#define _SW_ISR_TABLE_SECTION_SYMS	.gnu.linkonce.sw_isr_table*

Does the ARC MWDT toolchain require the section name to have asterisk in the C source code?

No we don't need asterisk in the C source code so that should be OK. I've misinterpreted that part of code.
However, I've tested the change and I got build errors with MWDT toolchain:
[ 89%] Generating linker.cmd
In file included from /slowfs/ru20arcjenkins/de02-arcjenkins2/slaves/ru20-gp-hw-linux110/workspace/arcoss_verification/zephyr_verification/sanity_check/zephyr/soc/arc/snps_nsim/linker.ld:31:
In file included from /slowfs/ru20arcjenkins/de02-arcjenkins2/slaves/ru20-gp-hw-linux110/workspace/arcoss_verification/zephyr_verification/sanity_check/zephyr/include/arch/arc/v2/linker.ld:89:
In file included from /slowfs/ru20arcjenkins/de02-arcjenkins2/slaves/ru20-gp-hw-linux110/workspace/arcoss_verification/zephyr_verification/sanity_check/twister-out/nsim_hs/samples/synchronization/sample.kernel.synchronization/zephyr/include/generated/snippets-rom-start.ld:1:
/slowfs/ru20arcjenkins/de02-arcjenkins2/slaves/ru20-gp-hw-linux110/workspace/arcoss_verification/zephyr_verification/sanity_check/zephyr/include/../arch/arc/core/vector_table.ld:11:8: error: pasting formed 'irq_vector_table*', an invalid preprocessing token
KEEP(*(_IRQ_VECTOR_TABLE_SECTION_SYMS))
       ^
/slowfs/ru20arcjenkins/de02-arcjenkins2/slaves/ru20-gp-hw-linux110/workspace/arcoss_verification/zephyr_verification/sanity_check/zephyr/include/linker/sections.h:35:40: note: expanded from macro '_IRQ_VECTOR_TABLE_SECTION_SYMS'
#define _IRQ_VECTOR_TABLE_SECTION_SYMS  _CONCAT(.gnu.linkonce.irq_vector_table,*)
                                        ^
/slowfs/ru20arcjenkins/de02-arcjenkins2/slaves/ru20-gp-hw-linux110/workspace/arcoss_verification/zephyr_verification/sanity_check/zephyr/include/toolchain/common.h:125:23: note: expanded from macro '_CONCAT'
#define _CONCAT(x, y) _DO_CONCAT(x, y)
                      ^
/slowfs/ru20arcjenkins/de02-arcjenkins2/slaves/ru20-gp-hw-linux110/workspace/arcoss_verification/zephyr_verification/sanity_check/zephyr/include/toolchain/common.h:124:28: note: expanded from macro '_DO_CONCAT'
#define _DO_CONCAT(x, y) x ## y
                           ^
In file included from /slowfs/ru20arcjenkins/de02-arcjenkins2/slaves/ru20-gp-hw-linux110/workspace/arcoss_verification/zephyr_verification/sanity_check/zephyr/soc/arc/snps_nsim/linker.ld:31:
In file included from /slowfs/ru20arcjenkins/de02-arcjenkins2/slaves/ru20-gp-hw-linux110/workspace/arcoss_verification/zephyr_verification/sanity_check/zephyr/include/arch/arc/v2/linker.ld:100:
/slowfs/ru20arcjenkins/de02-arcjenkins2/slaves/ru20-gp-hw-linux110/workspace/arcoss_verification/zephyr_verification/sanity_check/zephyr/include/linker/common-rom.ld:29:5: error: pasting formed 'sw_isr_table*', an invalid preprocessing token
                *(_SW_ISR_TABLE_SECTION_SYMS)
                  ^
/slowfs/ru20arcjenkins/de02-arcjenkins2/slaves/ru20-gp-hw-linux110/workspace/arcoss_verification/zephyr_verification/sanity_check/zephyr/include/linker/sections.h:38:36: note: expanded from macro '_SW_ISR_TABLE_SECTION_SYMS'
#define _SW_ISR_TABLE_SECTION_SYMS      _CONCAT(.gnu.linkonce.sw_isr_table,*)
                                        ^
/slowfs/ru20arcjenkins/de02-arcjenkins2/slaves/ru20-gp-hw-linux110/workspace/arcoss_verification/zephyr_verification/sanity_check/zephyr/include/toolchain/common.h:125:23: note: expanded from macro '_CONCAT'
#define _CONCAT(x, y) _DO_CONCAT(x, y)
                      ^
/slowfs/ru20arcjenkins/de02-arcjenkins2/slaves/ru20-gp-hw-linux110/workspace/arcoss_verification/zephyr_verification/sanity_check/zephyr/include/toolchain/common.h:124:28: note: expanded from macro '_DO_CONCAT'
#define _DO_CONCAT(x, y) x ## y
                           ^
2 errors generated.
gmake[2]: *** [zephyr/linker.cmd] Error 1
gmake[1]: *** [zephyr/CMakeFiles/linker_script_target.dir/all] Error 2
gmake: *** [all] Error 2

I'm not sure why do we need _CONCAT macros, as we don't do any de-duplication in current implementation anyway:
#define _IRQ_VECTOR_TABLE_SECTION_NAME	.gnu.linkonce.irq_vector_table
#define _IRQ_VECTOR_TABLE_SECTION_SYMS	_CONCAT(.gnu.linkonce.irq_vector_table,*)

#define _SW_ISR_TABLE_SECTION_NAME	.gnu.linkonce.sw_isr_table
#define _SW_ISR_TABLE_SECTION_SYMS	_CONCAT(.gnu.linkonce.sw_isr_table,*)

Any inside about that? Can we drop the _CONCAT and do something like that?
#define _IRQ_VECTOR_TABLE_SECTION_NAME	.gnu.linkonce.irq_vector_table
#define _IRQ_VECTOR_TABLE_SECTION_SYMS	.gnu.linkonce.irq_vector_table*

#define _SW_ISR_TABLE_SECTION_NAME	.gnu.linkonce.sw_isr_table
#define _SW_ISR_TABLE_SECTION_SYMS	.gnu.linkonce.sw_isr_table*

Updated to remove _CONCAT(). Hopefully this would work with the MWDT toolchain.

Updated to remove _CONCAT(). Hopefully this would work with the MWDT toolchain.

Now it's working, thanks!

Now it's working, thanks!


Use Snowflake provider to build connection string

This change uses the SnowflakeHook from the airflow.providers.snowflake.hooks.snowflake module to build the connection string.
Great Expectations expects a different configuration structure for a datasource that uses Snowflake and private key authentication. PR #93 does not cover all possible ways a Snowflake connection can be configured in Airflow.
I thought it would be best to optionally rely on the Snowflake provider package and fall back to the existing functionality if the provider package is not available (tho I doubt anyone would use Snowflake without the provider package)
Instead of using the SnowflakeHook, I could duplicate the behaviour from the hook into the GE Operator? It is up to the maintainer imho.
Please let me know if you have any questions/concerns or would like me to change this in any way.

Really appreciate this PR, did have a few specific questions here I'd like addressed before merging. Test coverage looks good, have you tried this in a dev environment?

Thank you for your feedback @denimalpaca . Yes this has been running on our development environments since I opened this PR.


kitchen-tests: remove deprecated openssh options

doesn't fix the current master breakage, but removes the deprecation warnings that'll bit us eventually when they go away...


Microsoft.Network/privateEndpoints/privateDnsZoneGroups/privateDnsZoneConfigs

Describe the noise
Resource type
Microsoft.Network/privateEndpoints/privateDnsZoneGroups/privateDnsZoneConfigs
apiVersion
2020-07-01
Client
Bicep
Relevant ARM Template code (we only need the resource object for the above resourceType and apiVersion, but if it's easier you can include the entire template
resource dnsZone 'Microsoft.Network/privateEndpoints/privateDnsZoneGroups@2020-07-01' = {
  name: 'xxxxxxxxxx'
  properties: {
    privateDnsZoneConfigs: [
      {
        name: 'xxxxxxxxx'
        properties: {
          privateDnsZoneId: resourceId('xxxxxxxx', 'Microsoft.Network/privateDnsZones', 'xxxxxxxxxxx')
        }
      }
    ]
  }
  dependsOn: [
    privateEndpoint
  ]
}

Expected response
I expected no noise since the template has not been modified since the resources were deployed
Current (noisy) response (either include a screenshot of the what-if output, or copy/paste the text)
  ~ Microsoft.Network/privateEndpoints/xxxxxxxxxx/privateDnsZoneGroups/xxxxxxxxxx [2020-07-01]
    ~ properties.privateDnsZoneConfigs: [
      ~ 0:

        - etag:                         "W/"xxxxxxxxxxxxxxxxxxxxxxx""
        - id:                           "/subscriptions/xxxxxxx/resourceGroups/xxxxxx/providers/Microsoft.Network/privateEndpoints/xxxxxx/privateDnsZoneGroups/xxxxxx/privateDnsZoneConfigs/xxxxxxxxx"
        - properties.provisioningState: "Succeeded"
        - type:                         "Microsoft.Network/privateEndpoints/privateDnsZoneGroups/privateDnsZoneConfigs"

      ]

This is happening on the latest api version too:
resource privateDnsZoneGroups 'privateDnsZoneGroups@2021-02-01'
This is creating a lot of noise in the what-if since its all the properties above multiplied by the number of dns zone groups.
We are trying to integrate what-if within devops pipelines so this noise will cause the pipeline to request validation of this 'change' on every run which is not ideal.

I am able to in Bicep add in values for 2 of those properties:
provisioningState: 'Succeeded'
type: 'Microsoft.Network/privateEndpoints/privateDnsZoneGroups/privateDnsZoneConfigs'
but that then means Bicep displays warnings 'property not allowed' but it does remove it from what-if noise.  Not a good option though.

I also have a similar issue, how can we reduce or remove this noise

You cant, i even asked the Microsoft fast track team that question a while ago, cant remember their response now other than they agreed it was an issue and one that could be hard to resolve.
I dont rely on what-if now especially on larger scripts so dont use it now


Error in "cell migration analysis"_module 5 "Evaluating the network"

Hi!
There seems to be an issue in the example Particle tracing-Training MAGIK to trace migrating cells.
In module of Evaluating the network_gnns.get_predictions, we confront an error as below:

TypeError                                 Traceback (most recent call last)
Cell In[13], line 1
----> 1 pred, gt, scores, graph = dt.models.gnns.get_predictions(
2     test_nodesdf, ["centroid"], model, variables
3 )
TypeError: get_predictions() takes 3 positional arguments but 4 were given
Have you noticed this? If yes, is there any solution for this problem?

Hello!
Thanks for reporting this issue. We have updated the example to fix the error.
Feel free to contact us again if the problem persists!


Daily test suite did not pass

https://github.com/voedger/voedger/actions/runs/8811343193

will be fixed in #2283


bug: Add diagnostic information on font load error

I ran into a bug a while back that prevent me from using the plotters library for months. I did finally figure out what was causing it: a file in my font library documented in issue #231. Removing the file fixed my issue, but the opaque problem is sure to ensnare others.
This PR adds a LoadError(Cow<'static, str>) variant to SelectionError enum. It removes Copy because Cow isn't copyable. And now when I run the test suite with the bad file in place, it reports this error, which is far and away more helpful than before.
> RUST_BACKTRACE=1 cargo test --all
...
running 5 tests
test loaders::core_text::test::test_core_text_to_css_font_stretch ... ok
test loaders::core_text::test::test_core_text_to_css_font_weight ... ok
test sources::core_text::test::test_css_to_core_text_font_stretch ... ok
test sources::core_text::test::test_css_to_core_text_font_weight ... ok
test loaders::core_text::test::test_from_core_graphics_font ... FAILED

failures:

---- loaders::core_text::test::test_from_core_graphics_font stdout ----
thread 'loaders::core_text::test::test_from_core_graphics_font' panicked at src/loaders/core_text.rs:940:14:
called `Result::unwrap()` on an `Err` value: LoadError("Parse error on path \"/Users/shane/Library/Fonts/Arial\"")
stack backtrace:
   0: rust_begin_unwind
             at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/panicking.rs:645:5
   1: core::panicking::panic_fmt
             at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/core/src/panicking.rs:72:14
   2: core::result::unwrap_failed
             at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/core/src/result.rs:1649:5
   3: core::result::Result<T,E>::unwrap
             at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/core/src/result.rs:1073:23
   4: font_kit::loaders::core_text::test::test_from_core_graphics_font
             at ./src/loaders/core_text.rs:938:21
   5: font_kit::loaders::core_text::test::test_from_core_graphics_font::{{closure}}
             at ./src/loaders/core_text.rs:937:38
   6: core::ops::function::FnOnce::call_once
             at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/core/src/ops/function.rs:250:5
   7: core::ops::function::FnOnce::call_once
             at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/core/src/ops/function.rs:250:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

failures:
    loaders::core_text::test::test_from_core_graphics_font

test result: FAILED. 4 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.04s

error: test failed, to rerun pass `--lib`

A variant that used String would suffice for this case. I tend to use Cow<'static, str> on errors since many times they can be &'static str.

Can you run cargo fmt on these changes as well?

No problem.


Documentation: Add docs for lower-half of netdriver

Summary
Add docs for lower-half of netdriver
Impact
Documentation
Testing
N/A

@wengzhe Amazing!!! This is the kind of Documentation NuttX needs most! Since we don't have a book like the Developing NuttX Device Driver, this documentation helps to fill the gap!


Help with taking inputs from a a virtual gamepad via lua

Describe your problem here.
I am trying to make mods ported to mobile via lua. Most thjngs works except for the inputs. I tried to find how to apply the values but I dont know how. I have the value im looking for FlxVirtualPad and im trying to edit these lines of code. local kD = getPropertyFromClass('flixel.FlxG', 'keys.pressed.DOWN') or getPropertyFromClass('flixel.FlxG', 'keys.pressed.S') or getPropertyFromClass('flixel.FlxG', 'keys.pressed.K') or 		(gp and (getPropertyFromClass('flixel.FlxG', 'gamepads.lastActive.pressed.DPAD_DOWN') or getPropertyFromClass('flixel.FlxG', 'gamepads.lastActive.pressed.LEFT_STICK_DIGITAL_DOWN')));
(this is from the "a beutiful day" mod)
Are you modding a build from source or with Lua?
Lua
What is your build target?
Neko, HashLink, or other build system
Did you edit anything in this build? If so, mention or summarize your changes.
Complete vanilla except it being the mobile 0.5 port.

Problem solved


Error budget pruning strategy in resource estimator core

Resource estimation takes as input an error budget. This is a triplet of budget contribution to logical errors, rotation synthesis errors, and magic state distillation errors. The user can either specify each of these three values separately or provide a total value that is uniformly distributed among the three parts. So far, RE does not modify these provided values.
This PR implements a pruning strategy for the error budget that will decrease the budget for logical errors and rotation synthesis errors (without affecting the estimation), while increasing the budget for magic state distillation errors in order to reduce the resources required for factories.
For logical errors, we can reduce the budget by finding the largest value that still leads to the same code parameter (e.g., code distance). Similarly, for synthesis errors, we can reduce the budget by finding the largest value that still leads to the same number of magic states. The latter is layout dependent, and therefore a new function is added to the Overhead trait. The function has an empty default implementation, and therefore does not break existing layout implementations.
The strategy needs to be explicitly set for the resource estimation and only works for a resource estimation without any other constraints (e.g., maximum number of qubits or duration), and does not work for frontier based estimation. There is no job parameter yet to enable the behavior.

I only see Rust updates here. Is this intended to be generally available functionality? (i.e. available via the Python API. I assume not for exposure in the simplified VS Code experience). If so, does it need Python (and docs) updates?

I only see Rust updates here. Is this intended to be generally available functionality? (i.e. available via the Python API. I assume not for exposure in the simplified VS Code experience). If so, does it need Python (and docs) updates?

Eventually, this should be accessible via the Python API through job parameter configurations. But I'd like consider other PRs such as #1940, possibly #1689, and maybe other upcoming ones in designing how these configurations should look like rather than deciding ad-hoc for each feature. I suggest to then update Python (and docs) together with the PR that makes these capabilities accessible through job parameters.

Thanks. Makes sense. I browsed the code and tested it with a bunch of our sample scripts and notebooks, all looks good. Approved!


feat(storage): include node id in SST id.

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR aims to provide the SST->node mapping info. It helps meta to

reject invalid SST when updating LSMT (commit_epoch / report_compact_task).
filter out false positive orphan SSTs during vacuum.
See https://github.com/singularity-data/risingwave/issues/4037

Changes:

SST id is changed to 128bit. SST id = | node id | seq id |.
As protobuf doesn't support int128, I add a new prost type SstableId.
Local SSTs use a u64::MAX invalid node id, to be distinguishable from remote SSTs. @wenym1

Checklist

[x] I have written necessary rustdoc comments
[x] I have added necessary unit tests and integration tests
[x] All checks passed in ./risedev check (or alias, ./risedev c)

Documentation
If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.
Types of user-facing changes
Please keep the types that apply to your changes, and remove those that do not apply.

Installation and deployment
Connector (sources & sinks)
SQL commands, functions, and operators
RisingWave cluster configuration changes
Other (please specify in the release note below)

Release note
Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.
Refer to a related PR or issue link (optional)
https://github.com/singularity-data/risingwave/issues/4037

Including node id in SST id is an optional optimization. I'd like to defer it.


fix: change value order for is_active column when using query _create_last_value_statement

Which issue(s) this PR fixes

Fixes None
Additional comments
The function _create_get_sch_latest_status_statement in tdp/dao.py used by the query from the command tdp status show takes the latest_is_active, and until now None meant True for is_active. However, in the order of the query False precedes None so the query will first return a False before a None which is not the expected behavior. Therefore, the order has been changed for the is_active column.
Agreements

[x] I hereby declare this contribution to be licensed under the Apache License Version 2.0, January 2004.
[x] I hereby agree to grant TOSIT a copyright license to use my contributions.

is_active column has been removed


Android - Chat - Composer with edited message opens again after saving changes

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.83-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4631009https://expensify.testrail.io/index.php?/tests/view/4631009
Issue reported by: Applause - Internal Team
Action Performed:

Open the app and log in with an account that has a lot of chats
Open a report that already has some messages
Send a message
Long tap > Edit comment
Change the comment to anything else
Save the changes
Create a thread
Open the tread and edit the parent message

Expected Result:
Composer with with edited message closes, and changes are saved
Actual Result:
The composer with edited message opens up again after saving changes
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/93d0c637-9cc1-443f-b577-fa32f0fd39e6
View all open jobs on GitHub

@garrettmknight  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #vip-vsp

Can't reproduce on 1.4.84-2. Closing.


训练时需要在哪个配置文件上修改数据集路径和选择数据集啊？运行的总是num_samples=0

请问在哪里下载的数据?

训练数据可以在learn2reg challenge官网上下载

I have some confusion about the source of the training, validation, and test data in the article. Could you explain this?


Unable to extend protected nested class

Based on Open CB failure in playframework/playframework - builds logs
Extracted from similar issue: https://github.com/scala/scala3/issues/21599#issuecomment-2367548970  - original issue was based on access to private members and was concluded to be working as expected. This case however involves protected members - these AFAIK are considered as public at the bytecode level
Compiler version
3.6.0-RC1-bin-20240915-ad8c21a-NIGHTLY
Bisect points to e7d479f80a29c6ae21d0755047e563963b87ac82 / #21362
If you're not sure what version you're using, run print scalaVersion from sbt
(if you're running scalac manually, use scalac -version instead).
Minimized code
When creating a fix for playframework I've seen one interesting issue in their Netty integration
// AbstractChannel.java
public abstract class AbstractChannel {
    protected AbstractChannel() {}
    protected abstract AbstractUnsafe newUnsafe();
    protected abstract class AbstractUnsafe {
        public abstract void connect();
    }
}

// test.scala
class Channel extends AbstractChannel() {
  override def newUnsafe(): AbstractChannel#AbstractUnsafe = new AbstractUnsafe {
    override def connect(): Unit = ???
  }
}

Output
Fails with
[error] ./test.scala:2:66
[error] Unable to emit reference to constructor AbstractUnsafe in class AbstractUnsafe, class AbstractUnsafe is not accessible in anonymous class AbstractChannel.this.AbstractUnsafe {...}
[error]   override def newUnsafe(): AbstractChannel#AbstractUnsafe = new AbstractUnsafe {
[error]                                                                  ^^^^^^^^^^^^^^
Error compiling project (Scala 3.6.0-RC1-bin-20240922-22ed2fb-NIGHTLY, JVM (17))

Expectation
Should compile

cc @eed3si9n @hamzaremmal @dwijnand

From the comment

It compiles with --server=false only because it's not actually being compiled - it's not emitting bytecode for Java class

It sounds like at the very least there's a difference between java source parsing and java bytecode parsing.

It sounds like at the very least there's a difference between java source parsing and java bytecode parsing.

Scala CLI currently doesn't support Scala/Java mixed compilation with --server=false.
Refer to:

https://github.com/VirtusLab/scala-cli/issues/3196

So it's unrelated, I think.


Dynamic Quantization

Description
Reduce the size of a model after training so that mentioned layers have weights of type INT8 instead of FP.

Can be closed now, ig. Solved in #75

I need to add the logs for quantization.


fix: bug in forceIP function

I think this is a bug. The first three characters are separated from the host varible ("ws://localhost:9222/..." becomes "alhost:9222/..."), and further call net.ResolveIPAddr returns  an invalid addr.

Thanks - you appear to be correct. The tests didn't catch this because they all use IPs or localhost. Not sure why the tests are failing.

They shouldn't been fail. According to Travis's log, panic is triggered in tests not related to changes.


Failure to push updated codes

Issues pushing changes to the repo
Hi @GemmaTuron, I am having issues uploading codes to my copy of this repo. I forked and cloned it but I have been struggling to push the codes.
Steps taken

[x] Fork the eos5505 repo.
[x] Clone the repo to obtain a copy on my GitHub.
[x] Install git LFS on my local system.
[x] Initialize git LFS.
[ ] It begins with uploading LFS object, then fails

Other attempts
In a bid to identify where the error is occurring from and if it is an issue related to my fork of the repo, I decided to:

[x] I cloned the eos5505 repo directly
[x] Created a new branch
[ ] Push to the new branch, however due to restricted permissions, as expected, I received a fatal: unable to access 'https://github.com/ersilia-os/eos5505.git

[x] Separated the contents of the repo into individual files.
[ ] Attempted to push the files individually to the repo but encountered the same error.
[ ] Attempted with git lfs push --all origin <branch_name>

I am attempting to find a workaround for this. It seems to be  a relatively common issue but all suggestions I have tried have failed.

Hi @pauline-banye
There is no workaround at the moment, I need to manually add the repositories to our github team and give you permits. I've done it for this repo already so this issue should be solved.
But before pushing to ersilia's github, you should test the model in your forked branch, which wouldn't give permit issues

Sorry, update from my part.
Git LFS does not allow commits on public forks for some reason, the best workaround therefore will be to work on branches as we are doing now


What's the meaning of xmin, ymin, xmax and ymax in the .xml file?

OS:
PyQt version:

Technically, it's telling the ingesting algorithm exactly what sections of the photo to look at and then apply the corresponding label to that particular region.
I also use these values (from the XML, pulled into Excel) to determine where I might have label boxes smaller than 32x32 px.

It seems that for xmin, ymin, xmax, and ymax, the x and y coordinates start from 1 - could you confirm this? Many image processing tools and libraries set the upper left corner to be x = 0 and y = 0, labelImg seems to set it to x = 1 and y = 0.


OCPBUGS-23858: OCPBUGS-22599: CVE-2023-45142: bump go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp to v0.46.0

Bump go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp to its latest upstream release.
Bump go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc to satisfy deps. that are not tracked otelhttp's go.mod.

/retest-required

/retest

/retest
The operator itself work, just some CSI driver tests flake. I am curious why.

The e2e-extended test fails with gcloud failed to load. You are running gcloud with Python 3.6, which is no longer supported by gcloud. Install a compatible version of Python 3.8-3.10 and set the CLOUDSDK_PYTHON environment variable to point to it. It's not related to the change, but the test needs to be fixed too.

lgtm since failed case due to unsupported Python 3.6.

/override ci/prow/operator-e2e
We track CI timeouts in https://issues.redhat.com/browse/OCPBUGS-22926?

Updated to 0.46 to fix CVE-2023-47108

rebased

/jira refresh

/jira refresh
/retest-required

Hmm, it seems the PR would fix both OCPBUGS-23858 and OCPBUGS-22599.
But the otelhttp version is still v0.45.0, not v0.46.0.


[WIP] Left/Right Constrained PRFs for use in Celo protocols

This CIP is meant to define the parameters of a new primitive to be used within the Celo ecosystem, left/right constrained PRFs.  This primitive can be used to enable a variety of identity-based encryption schemes and enable more privacy-enhancing subprotocols for Celo.

I need to be able to edit the file in order to assign a CIP number but I think your permissions won't allow me to.
Can you assign CIP number 44 to the preamble and rename the file as cip-0044.md


Request: Split

Can you please add:
Split
{{split}}
Split string by the given character.
Params
string {String}: The string to split.
returns {String} character: Default is an empty string.
Example
Example
{{split "a,b,c" ","}}

Helper
helpers.split = function(str, ch) {
  if (!util.isString(str)) return '';
  if (!util.isString(ch)) ch = ',';
  return str.split(ch);
};

Can do!
The code sample in the issue has brought to mind that I need to make some decisions on how to handle when a non-string is provided to string-based helpers.
The sample code provides a fallback for the text and for the separator.

if the input is not a string, my intuition is to simply return the provided value untouched, rather than falling back to an empty string
the standard JavaScript String.prototype.split() function does not default separator to ',' when separator is not provided. I'm more apt to mimic this behavior rather than provide a default.

Check out the resulting code and let me know if you have any thoughts on this.

Thank you. This works perfectly!


#49 Added Counters.md

#49 Please check if the time complexity is right. Is there a need to add other example or is this enough ?

Use ```python3 for syntax high lighting .
Also remove extra spaces between print statements .
shouldn't be like print<space>()


Fixed typo in MacOS High Sierra version number.

On line 21, fixed a typo: "High Sierra (10.3)" should be "High Sierra (10.13)"

@dansorensen-esd112 : Thanks for your contribution! The author, @andyjlewis, has been notified to review your proposed change.


Better error message when construction fails

This Pull Request has been merged by GitConsensus.
Vote Totals

Yes
No
Abstain
Voters

3
0
0
3

Vote Breakdown

User
Yes
No
Abstain

tedivm
✔

PostCrafter
✔

dragoonreas
✔

Vote Results

Criteria
Result

Has Quorum
True

Has Votes
True


displays the evm trace, rather than python trace

Overview
Currently Ape is not the evm trace very well. Mostly it shows python trace messages.
For now, the only message we get is ERROR: (ContractLogicError) Transaction failed. for most of the traces.

You need to use a provider with tracing capabilities, and yes Ape will do this then.

Pending some package releases, traces will now show for the Web3Provider, ape-foundry's provider, and ape-hardhat's provider.  Let us know if this doesn't cover your needs.


[feat]: Add Node v16.10 cypress browser due to memory issues in 16.11+

Due to https://github.com/facebook/jest/issues/11956 we are having memory issues with the image with Node 16.13
Therefore we would like to use a version with Node 16.10 which should not have the memory issue as described in the link

Have you tried the node-16.14.2-slim base image?


Change addin to support new official binary

The codecov team have deprecated the use of all community maintained applications, the community maintained applications will stop working in Januarry/February, as such this addin needs to be updated to ensure it is compatible with the official binary.
It is uncertain at this time if it will be a breaking change or not.

@AdmiringWorm what are your plans for sourcing the new official binary?
From what we can see, these can be found here:
https://uploader.codecov.io/
Should the Cake.Codecov addin source/download this binary depending on where it is being executed, or did you have a different plan for this?
Getting this out the door is obviously required before a new release of Cake.Recipe is made, since as of tomorrow, its support for Codecov will no longer work 😢

@AdmiringWorm I guess this makes sense.  Addins do tend not to actually download any files, so perhaps that becomes the responsibility of the parent Cake script, or external process to ensure that it is on disk, somewhere, that the addin can find it.

As an example to the contrary, Cake.Gradle has a BootstrapGradle() alias that will download and provide the gradle wrapper 😄

@nils-a or embed and extract the file as I do in Cake.Warp.

@AdmiringWorm I haven't checked, but does the license of the codecov uploader allow for redistribution?

@AdmiringWorm, @gep13 I have created https://www.nuget.org/packages/CodecovUploader/ which bundles the official tool from Codecov in a NuGet. This way, the packages will be auto-updated, and we can keep the (IMHO good) separation of "tool" and "addin".

@nils-a that is awesome, thank you for doing that.
It do look like however that your CI builds fail, and caused the package to be out of date

@AdmiringWorm @nils-a seems like the index URL has changed, no idea why, but the information your script requires can be found here (I think):
https://api.nuget.org/v3/registration5-semver1/codecovuploader/index.json
Rather than at:
https://api.nuget.org/v3-flatcontainer/CodecovUploader/index.json

@AdmiringWorm Thanks for the heads-up. I kind of saw that, but didn't get around to fix it.
Thanks, @gep13, for figuring it out. 🙇♂
The package has been updated and CI is running again. 🚀


bugfix: in case parsing args fails, keep unparsed args

This fix is irrelevant once changes implemented here are merged. For details on how it is fixed look here in lines 398 onward.

Awesome, thanks @Cryaaa ! Btw, you can click on line numbers and then the link changes to this and links to a code line:
https://github.com/haesleinhuepf/napari-assistant/pull/11/files#diff-987fa10f7e7ea9143db221caedde23a5b957cb2887ae56ed2ccb38e7a8b536b8R398


Update donations new to use new theme

Resolves https://github.com/rubyforgood/diaper/issues/1001
Description
Updates the /app/views/donations/_donation_form.html.erb and /app/views/donations/new.html.erb   pages to the New Bootstrap 4 theme
Type of change

Layout

How Has This Been Tested?
Manually and rspec
Screenshots
before:

after:

Awesome! Thanks!


make failed

Hello,
I am trying to install goaccess 1.2 from source but i can not be succeded yet.
I tried with two different server (CentOS 6.9 centos-release-6-9.el6.12.3.x86_64 and CentOS 7 centos-release-7-2.1511.el7.centos.2.10.x86_64) but every time i am stucking on step;
gcc -O2 -DSYSCONFDIR="/usr/local/etc" -Wno-long-long -Wall -W -Wnested-externs -Wformat=2 -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -Wwrite-strings -Wshadow -Wpointer-arith -Wsign-compare -Wbad-function-cast -Winline -Wcast-align -Wextra -Wdeclaration-after-statement -Wno-missing-field-initializers -pthread -rdynamic  -o goaccess src/base64.o src/browsers.o src/color.o src/commons.o src/csv.o src/error.o src/gdashboard.o src/gdns.o src/gholder.o src/gmenu.o src/goaccess.o src/gslist.o src/gstorage.o src/gwsocket.o src/json.o src/opesys.o src/options.o src/output.o src/parser.o src/settings.o src/sha1.o src/sort.o src/ui.o src/util.o src/websocket.o src/xmalloc.o  src/gkhash.o    -lnsl -lncursesw -lpthread
make[1]: Leaving directory /root/goaccess-1.2
I tried with different configurations but i did not be succeded. My latest configuration is;
`Your build configuration:
Prefix         : /usr/local
Package        : goaccess
Version        : 1.2
Dynamic buffer : no
Geolocation    : N/A
Storage method : In-memory Hash Database (Default)
TLS/SSL        : no
Compiler flags :  -pthread
Linker flags   : -lnsl -lncursesw -lpthread
Bugs<EMAIL_ADDRESS>And my error message after make command;
In file included from src/gkhash.c:40:
src/gkhash.h: In function ‘ins_is32’:
src/gkhash.h:43: warning: inlining failed in call to ‘kh_resize_is32’: call is unlikely and code size would grow
src/gkhash.h:43: warning: called from here
src/gkhash.h:43: warning: inlining failed in call to ‘kh_resize_is32’: call is unlikely and code size would grow
src/gkhash.h:43: warning: called from here
src/gkhash.h: In function ‘ht_insert_meta_data’:
src/gkhash.h:53: warning: inlining failed in call to ‘kh_resize_su64’: call is unlikely and code size would grow
src/gkhash.h:53: warning: called from here
src/gkhash.h:53: warning: inlining failed in call to ‘kh_resize_su64’: call is unlikely and code size would grow
src/gkhash.h:53: warning: called from here
src/gkhash.h: In function ‘ht_insert_agent’:
src/gkhash.h:51: warning: inlining failed in call to ‘kh_resize_igsl’: call is unlikely and code size would grow
src/gkhash.h:51: warning: called from here
src/gkhash.h:51: warning: inlining failed in call to ‘kh_resize_igsl’: call is unlikely and code size would grow
src/gkhash.h:51: warning: called from here
src/gkhash.h: In function ‘ht_insert_maxts’:
src/gkhash.h:45: warning: inlining failed in call to ‘kh_resize_iu64’: call is unlikely and code size would grow
src/gkhash.h:45: warning: called from here
src/gkhash.h:45: warning: inlining failed in call to ‘kh_resize_iu64’: call is unlikely and code size would grow
src/gkhash.h:45: warning: called from here
gcc -O2 -DSYSCONFDIR="/usr/local/etc" -Wno-long-long -Wall -W -Wnested-externs -Wformat=2 -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -Wwrite-strings -Wshadow -Wpointer-arith -Wsign-compare -Wbad-function-cast -Winline -Wcast-align -Wextra -Wdeclaration-after-statement -Wno-missing-field-initializers -pthread -rdynamic  -o goaccess src/base64.o src/browsers.o src/color.o src/commons.o src/csv.o src/error.o src/gdashboard.o src/gdns.o src/gholder.o src/gmenu.o src/goaccess.o src/gslist.o src/gstorage.o src/gwsocket.o src/json.o src/opesys.o src/options.o src/output.o src/parser.o src/settings.o src/sha1.o src/sort.o src/ui.o src/util.o src/websocket.o src/xmalloc.o  src/gkhash.o    -lnsl -lncursesw -lpthread
make[1]: Leaving directory `/root/Downloads/goaccess-1.2'
Can you help me about this?

Those are warnings, so build was done...
You need to make
$ make install
I would recommend first doing a test  with
$ mkdir -p /tmp/PKG
$ make install DESTDIR=/tmp/PKG/


Bugfix of job handling

This pr contains the following implementations.

[x] if github actions job status is skipped, exclude this job from validation logic.
[x] Fail early when other jobs have failed: https://github.com/upsidr/merge-gatekeeper/issues/14

Also, you seem to have not included any fix for the verbose error message when the job fails?

Thanks, LGTM - just a quick one though, this won't fix the issue we saw internally with some job being picked up incorrectly for the total number of jobs?

I think the implementation of this link has solved that problem.

Also, you seem to have not included any fix for the verbose error message when the job fails?

if the job fails, we can get failed job name.ref:
https://github.com/upsidr/merge-gatekeeper/blob/bugfix/fix-timing-to-finish-job/internal/validators/status/status.go#L20-L21. but I could not delete CLI usage information. 🙏
So I will try this with another PR.


put_table can not set style, override via css or anything else

I'm trying to render a table with no borders with no success.
Tried using put_table().style('border: none;')
Tried suing css with no success.
How can I control table style using pywebio?
Thanks!

nvm, found a way after inspecting the page elements

please share the way you have found

@config(css_style=''table tr {text-align: centre}")
def index():
put_table(data)


Fix returned simplicies for #110

Hello @sauln, Thank you for submitting the Pull Request !

In the file kmapper/kmapper.py, following are the PEP8 issues :

Line 37:138: W291 trailing whitespace
Line 38:10: W291 trailing whitespace
Line 50:51: W291 trailing whitespace
Line 56:9: E303 too many blank lines (2)
Line 81:313: W291 trailing whitespace
Line 122:17: E722 do not use bare except'
Line 126:9: E722 do not use bare except'
Line 138:1: W293 blank line contains whitespace
Line 278:59: W291 trailing whitespace
Line 350:1: W293 blank line contains whitespace
Line 351:63: W291 trailing whitespace
Line 352:13: E128 continuation line under-indented for visual indent
Line 352:46: W291 trailing whitespace
Line 353:13: E128 continuation line under-indented for visual indent
Line 354:1: W293 blank line contains whitespace
Line 380:1: W293 blank line contains whitespace
Line 384:1: W293 blank line contains whitespace
Line 462:60: W291 trailing whitespace
Line 493:77: W291 trailing whitespace

In the file kmapper/nerve.py, following are the PEP8 issues :

Line 24:5: E303 too many blank lines (2)
Line 37:20: W291 trailing whitespace

In the file test/test_mapper.py, following are the PEP8 issues :

Line 15:1: E302 expected 2 blank lines, found 1
Line 79:1: W293 blank line contains whitespace
Line 119:36: W291 trailing whitespace
Line 120:13: E128 continuation line under-indented for visual indent
Line 159:111: E231 missing whitespace after ','

In the file test/test_nerve.py, following are the PEP8 issues :

Line 33:5: E303 too many blank lines (2)
Line 36:26: E231 missing whitespace after ','
Line 36:28: E231 missing whitespace after ','
Line 36:30: E231 missing whitespace after ','
Line 36:42: E231 missing whitespace after ','
Line 36:44: E231 missing whitespace after ','
Line 36:56: E231 missing whitespace after ','
Line 36:58: E231 missing whitespace after ','

Do see the Hitchhiker's guide to code style

Codecov Report

Merging #111 into master will increase coverage by 0.48%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
+ Coverage   90.27%   90.76%   +0.48%
==========================================
  Files           6        6
  Lines         432      433       +1
  Branches       92       93       +1
==========================================
+ Hits          390      393       +3
+ Misses         28       27       -1
+ Partials       14       13       -1

Impacted Files
Coverage Δ

kmapper/kmapper.py
89.4% <100%> (+0.84%)
:arrow_up:

kmapper/nerve.py
86.36% <100%> (+0.64%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3789bc...545bc9e. Read the comment docs.


Remove the targeting pack archives from publish except for windows x64

Would be interested to know why this didn't surface before servicing builds, but that's a question for later

CC @JunTaoLuo @dougbu

This may work but is likely glossing over a deeper problem.

$(OnlyPackPlatformSpecificPackages) is no longer honoured for the .Ref package. The main problem is at https://github.com/aspnet/AspNetCore/blob/release/3.0/src/Framework/ref/Microsoft.AspNetCore.App.Ref.csproj#L211
Where before $(OnlyPackPlatformSpecificPackages) ensured $(IsPackable) was false for the generic .Ref project and therefore the package wasn't built, the new $(IsTargetingPackPatching) property takes precedence.
@JunTaoLuo @wtgodbe why do both $(IsTargetingPackPatching) and $(IsTargetingPackBuilding) exist? And, if they're both necessary, why aren't both used to set $(IsPackable) earlier in the .Ref project (here)?

@mmitche I recommend changing https://github.com/aspnet/AspNetCore/blob/release/3.0/src/Framework/ref/Microsoft.AspNetCore.App.Ref.csproj#L7-L8 (to include $(IsTargetingPackPatching) in the condition) instead of anything in Publishing .props. Also back out the use of $(IsTargetingPackPatching) at https://github.com/aspnet/AspNetCore/blob/release/3.0/src/Framework/ref/Microsoft.AspNetCore.App.Ref.csproj#L211
We can remove $(IsTargetingPackPatching) later…

IsTargetingPackPatching really means "Is this 3.0.1?", we use it for some special logic in ResolveReferences.targets

@wtgodbe @JunTaoLuo @dougbu I'll leave it to you to decide whether this is okay to take or whether another fix is needed. Merge as desired.

@dougbu I'm confused by your suggestion - IsTargetingPackPatching is just based off of whether or not we're building 3.0.1. Adding it as a condition to https://github.com/aspnet/AspNetCore/blob/release/3.0/src/Framework/ref/Microsoft.AspNetCore.App.Ref.csproj#L7-L8 wouldn't change the behavior

Ah, never mind, I missed the part about https://github.com/aspnet/AspNetCore/blob/602cb1dea59751a1297d674cddf7f0729c23e6ca/Directory.Build.targets#L5. I think all we need to do is back out IsTargetingPackPatching from https://github.com/aspnet/AspNetCore/blob/release/3.0/src/Framework/ref/Microsoft.AspNetCore.App.Ref.csproj#L211, as the IsPackable setting from https://github.com/aspnet/AspNetCore/blob/release/3.0/src/Framework/ref/Microsoft.AspNetCore.App.Ref.csproj#L7-L8 will be overwritten by d.b.t. Does that sound correct?

Does that sound correct?

Yup, glad I wasn't delusional. Let me know if you want me to create another PR for that one-liner. Not sure reusing this PR makes sense.

I've changed this PR to use will's suggestion and run an internal build to test.

thanx @mmitche❕❕


Categorize Item types with optgroups

It'd be great to go with an approach similar to what the Pathfinder 2E devs do with items: sort them into optgroups in the type selection drop-down.

^ Sorry for all that noise, I kept pushing and noticing a simple change I needed to make/merge from my other branch.

No problem, I don't get notifications for all those pushes so no harm done.
Closing this out since I merged your PR


Fixed wait time handling in RedissonSpinLock #5002

This PR fixes  #5002. Please note new test testTryLockAsyncWaitTime - it fails with old implementation and clearly illustrates issue with tryLockAsync. For synchronous  tryLock issue is less noticeable, but I fixed it in order to be consistent with tryLockAsync.

Thank for proposed changes. Please correct all checks.

Fixed, please approve workflow again

Thanks for contribution!


Implement std::error::Error for CobraError in Rust binding

Is your feature request related to a problem? Please describe.
CobraError does not implement the standard std::error::Error trait, which means that the use of the ? syntax in Result returning functions is not available.
Describe the solution you'd like
Implement std::error::Error for CobraError. As the type already implements Display, it may literally be as simple as adding impl std::error::Error for CobraError {}, and relying on the provided functions - possibly a literal one-liner.
Describe alternatives you've considered
It is possible to workaround this by simply mapping the error, but it's a shame to need to, and a pity for a small and otherwise quite ergonomic library (although some more Rust-like changes to the API would be possible).
Additional context
n/a

Hi @kolektiv, thanks for the suggestion. We intended to implement std::error::Error for the error classes in all our bindings but Cobra seemed to have been missing it. I've uploaded a new version of the package with the fix, version 2.0.1.

Thanks folks, it's such a small change, and it's not like it makes a huge difference, but a little bit less noise across multiple codebases - always good! Cheers.


UIMA AS 3

@kp-taylor UIMA-AS has been retired due to lack of maintainers and due to there not being a v3 version. You could have a look at this branch and see if you can revive it with UIMAv3. You might care trying to send a mail to the UIMA developers mailing list just in case any of the past maintainers or contributors might still be there and might give you a pointer, but you shouldn't make starting your work depending on a response.
It would be great if you were to pick up the baton and bring UIMA-AS back to life :)


OZ Audit N5: Delete challenge status when revert

Issue: When the challenged batch is revert, the challenge information corresponding to batchIndex still exists, which will cause the new batch to contain challenge information when it is submitted and cannot be challenged.
Fix:

Delete the corresponding challenge information when revert batch.
Set the revertReqIndex variable when the challenge is completed, and limit the commitBatch,challengeState,proveState and finalizeBatch of batch when the revert is not completed.

should handle "challengerDeposits" when delete the challenge state

should handle "challengerDeposits" when delete the challenge state

Will delete challengerDeposits in other PR.


Spawner machine is not spawning in the compiled game

For some reason the Spawner3D node is not spawning items in the compiled version of the game, only in the editor.

https://github.com/godotengine/godot/issues/77259
Worked around this for now by removing dynamic exported vars.


Scratches Randomly Pixelated

Material Maker version: 0.92 Linux
OS/device including version:, Manjaro Linux 5.7.19, GeForce GTX 1650 Super with nVidia driver 450.66
Issue description: With the Scratches texture pattern, some of the scratches will appear pixelated.  The problem becomes more apparent when you use a lower Width value.  Issue seems to be seed-dependent, as some seeds will generate no pixelation while others will generate a lot.  Most seeds seem to generate at least some pixelation.
Example Screenshot:

Steps to reproduce: Enable 2D Preview, then drop in a Pattern/Scratches node and move it around.  Pixelation will become quickly apparent.

This problem should already be fixed for 0.93.
Could you get a dev build (see "Actions") and tell me if it fixes the problem ? Thanks!

Aye, that particular issue appears to be fixed in 0.93.
I do notice that for low width values (like 0.025), a different kind of pixelation appears, though I guess it may be a shortcoming of the algorithm used.

Hmm pixelation in this case because scratches are thinner than a pixel. A workaround would be to (create and) use an antialiasing node.

@RodZill4 What about adding a "supersampling" mode that doubles the resolution the texture is rendered at then downscales it?
(This wouldn't be a node but a setting in the output node, probably.)

Yeah, some kind of super-sampling setting would be more ideal, especially if you want very thin scratches like I do.

A setting in the output node would not be useful if the scratches node is connected to a buffer. A supersampling setting (that affects all rendered textures including buffers) would also be a bad idea.

Looks like a supersample node is a decent solution:

Now supersample is available, we can close this...


feat: segwit support for bitcoin

RE: https://github.com/ognus/wallet-address-validator/issues/16
This PR takes code developed by Pieter Wuille available at https://github.com/sipa/bech32/tree/master/ref/javascript and implements the segwit support for bitcoin addresses, it also supports backwards compatibility for P2PKH and P2SH Addresses for testnet and prod networks.

@ognus @ulich-trade @sipa please review.

@ognus Could you have a look at this ? This PR is a blocking issue for me.

@deefactorial refactored and published the change to npm as 0.2.0.


Pre-compute root of unity in fr-form

This replaces SCALE2_ROOT_OF_UNITY in uint64s-form with ROOT_OF_UNITY in fr-form. I don't have a strong opinion about this, but I was hoping to simplify this. It should at least be moved outside of the header. I provide updated instructions (scripts) for generating this constant. Had to remove some tests for compute_roots_of_unity though.
I would prefer a C function which uses PRIMITIVE_ROOT_OF_UNITY and generates the root of unity with blst, but there isn't a blst_fr_pow function and it seems quite difficult (maybe impossible) to do so ourselves.

This code has been around since 4844 and has been working nicely. I have a small preference for leaving old code sleep.
If you like this PR, how about you add a small C test that shows that the new value you added is the same value from the uint64 array? Just to show that the new code and the old code (that will be removed) do the same thing.

If you like this PR, how about you add a small C test that shows that the new value you added is the same value from the uint64 array? Just to show that the new code and the old code (that will be removed) do the same thing.

Okay yeah, I'll make that test. I do like this PR.

@asn-d6 Okay this should be ready now. I'm glad we added these tests back, good suggestion.