fix: Don't display a warning if an output folder is specified

As called out in https://github.com/microsoft/sbom-tool/issues/500, the code returns a warning if the manifest output folder is explicitly specified by the -m parameter. Logging a warning for normal and supported operation is bad form. It was causing grief for a team that wanted to control the output location but had a zero-warning policy on their pipeline.
Side note: The default verbosity level for logging (defined at https://github.com/microsoft/sbom-tool/blob/main/src/Microsoft.Sbom.Common/Constants.cs#L16) is Warning, so this message will only be displayed if a non-default verbosity is specified. Presumably a higher verbosity would be the first diagnostic step if a problem were to occur, so this feels unlikely to cause any real-world problems.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 59.69%. Comparing base (09994cd) to head (ada1bf0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #541      +/-   ##
==========================================
- Coverage   59.73%   59.69%   -0.04%
==========================================
  Files         248      248
  Lines        7572     7572
  Branches      900      900
==========================================
- Hits         4523     4520       -3
- Misses       2637     2640       +3
  Partials      412      412

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

I pushed to the wrong branch and messed this one up. Created #542 in its place


Package request: Zipalign

Project description

Metadata

homepage URL:
source URL:
license: mit, bsd, gpl2+ , ...
platforms: unix, linux, darwin, ...

Note for maintainers: Please tag this issue in your PR.

Add a :+1: reaction to issues you find important.

Kindly add the homepage and source url

This is in the android tools already, no?

This is in the android tools already, no?

If it is, a simple message at the top would clarify that, it seems vague.


REC709 vs. BT.1886

Excuse me if my problem is too naive, but I have seen some closed issues where this problem was discussed (so I am not the only one having this issue), but words like display-deferred and scene-deferred are too complicated for me, to completely understand the argumentation.
My problem:
I use avisynth and have a JPEG which is sRGB . This I wanted to convert to REC709 (same primaries, different transfer function). I relied on vapoursynth docu, but soon realized that zimg doesn't match this docu. srgb->linear is OK, but linear->REC709 doesn't match. As I understand zimg uses BT.1886 instead, whatever this is.
I think it would be useful if the real REC709 transfer function could be made available (additional parameter or whatever)

Rec.709 standardizes the process of converting light values (# of photons) to codewords (0-255) for cameras. However, the actual viewing of such images occurs on CRTs with pure-power transfer functions, and is a de facto process not standardized by Rec.709. Rec.1886 merely formalizes the accepted practice for viewing "Rec.709" images, which is with a 2.4 gamma curve.
In other words, to convert images such that they can be viewed on a "Rec.709" devices such as a television, you must map images by Rec.1886. Otherwise, they will not actually look the same on the new display.

Do you say cameras use Rec.1886 standard?
I have a scene taken in sRGB and I want to convert it as if it had been taken by a REC.709 camera. Is that possible with zimg?

No, Displays use Rec 1886.
Cameras might use Rec 709, (but that is unlikely.)
What may help is understanding why you need to convert, e.g. if you have an sRGB image viewed on an sRGB monitor, in a light environment and you want to make that image look 'the same' on a Rec 1886 calibrated monitor in a dim surround?
Typically under those circumstances you are display referred, meaning you care about what it looks like on your displays.
Then in this case you need to ignore the camera equations and just use the monitor equations to first linearise using sRGB monitor gamma of 2.2  (the values now represent something that relates to the light emitting from your sRGB display), then you need to adapt the light so that perceptually you account for the change in the environment you are viewing in, and finally inverse the 1886 display gamma 2.4 to re-encode the values.
The complexity can come from the perceptual adaptation, but as a good first approximation... it turns out that you should adjust the values using a gamma parameter ~1.1 and not by coincidence it so happens that the sRGB monitor spec was designed to account for the difference but going the other way (from dim to light) so in the end if you do 'nothing' you get a reasonable reproduction.
i.e all these gamma numbers end up roughly cancelling out.
so just displaying sRGB authored images on a Rec 1886 calibrated display in a dim environment should give you something that appears similar to the original. If you need better than that then you are in a completely different realm of vision/colour science and this library is not going to help you!
Kevin

Thank you for your answers. I am beginning to understand what display-referred means. However there is also a need for scene-referred. Rec. ITU-R BT.2087 basically describes two methods for color conversion. Just replace BT.709 by sRGB and you have a good description of my problem. Zimg works with BT.1886 EOTF and its inverse. I would like to work with Rec. 709 OETF and its inverse. As this can be regarded as a square root function, I guess FFmpeg can do that.
Still I would have preferred if zimg terms would be more consistent with ITU terms. Zimg says REC.709 but it means BT.1886, and of course the vapoursynth docu, which for transfer functions cites tables from ITU documents (Transfer characteristics (ITU-T H.265 Table E.4) is wrong.
But thank you for this filter, it helped me a lot to get something "similar" to original, but in times of HDR and people doing camera calibrations "similar" is not enough.

I don't disagree (most of my 'day job' is with scene referred imagery). My concern is that there are pretty much no real 'sRGB cameras' or 'Rec 709 cameras' in that they all have creative modifications to their image renderings, so that makes using the respective inverse OETFs inaccurate to recover anything like relative scene referred linear.
I think I still need some more clarity on the "why" to suggest anything further.
As to Zimg, I'm just a user of it, but my understanding is that it was intended for 'video' processing and as such being display focused makes most sense to me. Having the wrong terminology - I imagine this is a function of target audience and familiarity with the terms, unfortunately because Rec 1886 came out years after 709, the use of the term '709' when people actually mean '1886' is quite common, so much so that I spend quite a bit of time attempting to ensure people at work use the appropriate terms, but it is hard to fight the tide when some professional tools also use the wrong term.
Kevin

@george84 I still do not understand why you believe you need to do a "scene-referred" conversion, but this is possible via testapp.exe. You can use the --scene-referred command line flag to see if it produces what you want.

@KevinJW Why for Kevin?
Well I convert pictures taken with DSLR to videos. Having a UHDPremium TV I create HDR video. This works pretty well when I use sRGB jpegs and treat them as REC709 in zscale in FFmpeg. But you never know if you have reached the best quality. I'm not even sure if HDR looks better than SDR on the same TV. Also the TV has about 5 TV settings for different HDR settings. It even makes a difference if you watch at night or at daytime.  So I also worked with 16bit tiffs converted to REC.2020 in ImageMagick. made several tests changing nominal luminance. Ultimately I would also like to experiment with method described in REPORT ITU-R BT.2446-0. So I didn't want to rely on my subjective impression. I assumed there was an exact mathematical solution to follow. When I converted a colorchart I realized that zimg didn't deliver the mathematical values I expected.
@sekrit-twc Why for sekrit-twc?
Rec. ITU-R BT.2087 gives two possible cases for different scenarios. I just wanted to check the case with REC.709 OETF and was astonished when zscale gave different results. As you say I wanted to see what it produces.

@george84 Now that is a completely different scenario, HDR has several interpretations as to what that means with the context of a DSLR, but given your mention of ITU standards I'll assume you are not meaning the stylised imagery generated from various tone mappings etc.
HDR in the ITU usage typically means encoded video in either 'PQ' or 'HLG' in your case being displayed on a UHD Premium display.
You mention 16 bit TIFF files, I assume these were coming from a 'RAW' file (CR2, NEF, etc). These original RAW files would be scene referred linear, and would be suitable as a starting point for encoding as some form of HDR. The sRGB/JPEGs you get out of the camera or a typical use of say Lightroom will already have some form of tone mapping applied and thus not be the best starting point.
Given that is your goal I'm thinking this discussion is a bit off topic and should probably go somewhere else.
Kevin

Yes it goes off topic. It is unfortunate that zscale has these restrictions and uses misleading names as Rec709 and Rec601 for BT.1886. I also assume it is not the real BT.1886 but just a simple power function. In this case it would have been easier if the user could directly specify the gamma for transfer (e.g. 1.8, 2.0, 2.2, 2.35, 2.4). Issue can be closed.

Just a short update. I try to use transfer 470m. In FFMpeg this is not recognized but value 4 works. Is it really 470m?

Your questions and more can be answered from gamma.cpp

Yes it goes off topic. It is unfortunate that zscale has these restrictions and uses misleading names as Rec709 and Rec601 for BT.1886. I also assume it is not the real BT.1886 but just a simple power function. In this case it would have been easier if the user could directly specify the gamma for transfer (e.g. 1.8, 2.0, 2.2, 2.35, 2.4). Issue can be closed.

Huh?  It's not misleading at all.  You said you wanted to test/verify against BT.2087.  Well, that's easily done and zimg matches both cases given in BT.2087 Annex 3 (with the right settings).
BT.2087 itself tells you to use 2.4 (page 3, Note 1).  If you want a different gamma, use Expr().
import vapoursynth as vs
core = vs.get_core()
c = core.std.BlankClip(format=vs.RGB30, color=[914, 64, 64]) # input R’ = 914, G’ = 64, B’ = 64
# c = core.colorbars.ColorBars(format=vs.RGB30, hdr=1, wcg=0)

# BT.2087 Case #1 output R’ = 764, G’ = 343, B’ = 217
c = core.std.SetFrameProp(c, "_ColorRange", intval=1)
c = core.std.SetFrameProp(c, "_Primaries", intval=1)
src = c = core.std.SetFrameProp(c, "_Transfer", intval=1)
c = core.resize.Bicubic(c, primaries_s="2020")
c = core.text.FrameProps(c)

# BT.2087 Case #2 output R’ = 737, G’ = 287, B’ = 173
d = core.resize.Bicubic(src, format=vs.RGBS, range=0, range_in=1)
d = core.std.Expr(d, "x x *") # input must be [0,1] for subblacks
d = core.std.SetFrameProp(d, "_Transfer", intval=8) # linear
d = core.resize.Bicubic(d, primaries_s="2020")
d = core.std.Expr(d, "x sqrt")
d = core.std.SetFrameProp(d, "_Transfer", intval=1)
d = core.resize.Bicubic(d, format=vs.RGB30, range=1)
d = core.text.FrameProps(d)

output = core.std.Interleave([c,d])
output.set_output()

Thank you for this vapoursynth code. When I look at table E-4 in ITU x265
spec.and lookup transfer code value 1 then I find no mention of BT.1886.
This was misleading me. I understand that for a professional this might be
evident as Kevin explained. Maybe I have an old spec. (2013). How is one
supposed to know that transfer code 1 means Bt.1886. By looking at code of
zimg?  Also your code for case #2 needs Expr for doing gamma 2, and it
would be nice if zimg could do it to keep things simple.
I wanted also to use 470m, but how can I know if this is really implemented
according to specs. I see in gamma.cpp that such a transfer function
exists, but there also exist transfer functions with name Rec709 in it,
just they don't get called.
Yes BT.2087 tells to use 2.4,  but only by looking at code of zimg, or
trial and error, can I find out.
Yes its not zimg that's misleading. Because if there is no docu then it
cannot be misleading, it is rather FFmpeg and vapoursynth which are
misleading. I was thinking of opening an issue for FFmpeg, because it
doesn't list all transfer functions, but I got the impression it was too
complicated
ifb<EMAIL_ADDRESS>schrieb am Mo., 19. Aug. 2019, 21:50:

Yes it goes off topic. It is unfortunate that zscale has these
restrictions and uses misleading names as Rec709 and Rec601 for BT.1886. I
also assume it is not the real BT.1886 but just a simple power function. In
this case it would have been easier if the user could directly specify the
gamma for transfer (e.g. 1.8, 2.0, 2.2, 2.35, 2.4). Issue can be closed.
Huh? It's not misleading at all. You said you wanted to test/verify
against BT.2087. Well, that's easily done and zimg matches both cases given
in BT.2087 Annex 3 (with the right settings).
BT.2087 itself tells you to use 2.4 (page 3, Note 1). If you want a
different gamma, use Expr().
import vapoursynth as vs
core = vs.get_core()
c = core.std.BlankClip(format=vs.RGB30, color=[914, 64, 64]) # input R’ = 914, G’ = 64, B’ = 64
c = core.colorbars.ColorBars(format=vs.RGB30, hdr=1, wcg=0)
BT.2087 Case #1 output R’ = 764, G’ = 343, B’ = 217
c = core.std.SetFrameProp(c, "_ColorRange", intval=1)
c = core.std.SetFrameProp(c, "_Primaries", intval=1)
src = c = core.std.SetFrameProp(c, "_Transfer", intval=1)
c = core.resize.Bicubic(c, primaries_s="2020")
c = core.text.FrameProps(c)
BT.2087 Case #2 output R’ = 737, G’ = 287, B’ = 173
d = core.resize.Bicubic(src, format=vs.RGBS, range=0, range_in=1)
d = core.std.Expr(d, "x x *") # input must be [0,1] for subblacks
d = core.std.SetFrameProp(d, "_Transfer", intval=8) # linear
d = core.resize.Bicubic(d, primaries_s="2020")
d = core.std.Expr(d, "x sqrt")
d = core.std.SetFrameProp(d, "_Transfer", intval=1)
d = core.resize.Bicubic(d, format=vs.RGB30, range=1)
d = core.text.FrameProps(d)
output = core.std.Interleave([c,d])
output.set_output()
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sekrit-twc/zimg/issues/111?email_source=notifications&email_token=ACDI434BXQTQLPPPVVI2PVDQFL2PHA5CNFSM4IL7MFZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4UDB5A#issuecomment-522727668,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACDI433J2JEFCIB5YF46LMTQFL2PHANCNFSM4IL7MFZA
.

ifb<EMAIL_ADDRESS>schrieb am Mo., 19. Aug. 2019, 21:50:

Yes it goes off topic. It is unfortunate that zscale has these
restrictions and uses misleading names as Rec709 and Rec601 for BT.1886. I
also assume it is not the real BT.1886 but just a simple power function. In
this case it would have been easier if the user could directly specify the
gamma for transfer (e.g. 1.8, 2.0, 2.2, 2.35, 2.4). Issue can be closed.
Huh? It's not misleading at all. You said you wanted to test/verify
against BT.2087. Well, that's easily done and zimg matches both cases given
in BT.2087 Annex 3 (with the right settings).
BT.2087 itself tells you to use 2.4 (page 3, Note 1). If you want a
different gamma, use Expr().
import vapoursynth as vs
core = vs.get_core()
c = core.std.BlankClip(format=vs.RGB30, color=[914, 64, 64]) # input R’ = 914, G’ = 64, B’ = 64
c = core.colorbars.ColorBars(format=vs.RGB30, hdr=1, wcg=0)
BT.2087 Case #1 output R’ = 764, G’ = 343, B’ = 217
c = core.std.SetFrameProp(c, "_ColorRange", intval=1)
c = core.std.SetFrameProp(c, "_Primaries", intval=1)
src = c = core.std.SetFrameProp(c, "_Transfer", intval=1)
c = core.resize.Bicubic(c, primaries_s="2020")
c = core.text.FrameProps(c)
BT.2087 Case #2 output R’ = 737, G’ = 287, B’ = 173
d = core.resize.Bicubic(src, format=vs.RGBS, range=0, range_in=1)
d = core.std.Expr(d, "x x *") # input must be [0,1] for subblacks
d = core.std.SetFrameProp(d, "_Transfer", intval=8) # linear
d = core.resize.Bicubic(d, primaries_s="2020")
d = core.std.Expr(d, "x sqrt")
d = core.std.SetFrameProp(d, "_Transfer", intval=1)
d = core.resize.Bicubic(d, format=vs.RGB30, range=1)
d = core.text.FrameProps(d)
output = core.std.Interleave([c,d])
output.set_output()
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sekrit-twc/zimg/issues/111?email_source=notifications&email_token=ACDI434BXQTQLPPPVVI2PVDQFL2PHA5CNFSM4IL7MFZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4UDB5A#issuecomment-522727668,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACDI433J2JEFCIB5YF46LMTQFL2PHANCNFSM4IL7MFZA
.

If anything, the confusion is caused simply by the history of the video industry. It is unfortunate that H.264/5 standards list the OETF as though you were meant to use it for conversions. However, that is a topic for the MPEG/ITU codec committees.

How is one supposed to know that transfer code 1 means Bt.1886. By looking at code of
zimg?

By looking at the magic values in E-4 (like you did) or just using the names.  And don't be upset when you don't see BT.1886 listed.  The confusing history has been explained.

Also your code for case #2 needs Expr for doing gamma 2, and it
would be nice if zimg could do it to keep things simple.

Umm, that's what this does:
d = core.std.Expr(d, "x x *")
and un-does:
d = core.std.Expr(d, "x sqrt")
I agree that a simpler way to do this would be preferred, but you're acting like something is wrong when it isn't.  Case #2 is a niche use case, so it's not surprising that it isn't directly supported.


Relocate Cluster Tools button

(Design for Q3, implement for Q4)
In 2.6, with the new UI we added a Cluster Tools button to the bottom of the side nav when exploring a cluster, so users could easily get to the tools section - to help with migrating from the old UI.

Now we're at 2.7, we should figure out where to put cluster tools so that we can remove this item from the side bar.
Suggestion would be a Tools item under the Cluster nav, i.e.

I'd also suggest adding a link to the Cluster Dashboard page:

Suggestion would be to stack the links 'Add cluster badge and install monitoring vertically and to add 'Manage Cluster Tools' in there as well - e.g.

We could take the opportunity to make that header look more visual - we should show the infrastructure provider as well as the k8s provider.

Our first idea, given we keep the Cluster Tools page, would be the following:

Remove the Cluster Tools button
Add a link in Cluster Dashboard (maybe near the title) to the Tools page with a proper label
Change the "Edit Cluster Badge" link to a "Customize Appearance" button.

Xd Prototype

@edenhernandez-suse Design looks good - I think we should proceed with implementing what you propose.

I created a new Spec prototype. Maybe we can include it in the description of this issue.

So, the cluster tools links on the dashboard page and in the side nav are working as expected. However, the Customize Appearence is a label only displayed when the user hovers over the painting brush icon.
https://github.com/rancher/dashboard/assets/70187881/698a0eed-18a5-49b5-9f10-c17e5f62f210

@IsaSih my bad, at some point during our discussions around this we decided to minimise that button to just an icon button with a tooltip, but I never updated the prototype link. It's working as expected.


Add a function to bulk append blocks

Take a list of blocks, pre-populate the previous hash of all but the head. Then insert the entire chunk. Big performance increase


Icons in "Why KWoC?" and many other places not functional

The icons in various items inside "Why KWoC?" are not present.

Fixed


Update v0.21 changelog: confusing note about breaking change to Snowflake transactions

resolves https://github.com/dbt-labs/dbt-core/issues/4732

Going to get all sorts of failing tests, since this is against 0.21.latest :)

@jtcohen6 do we want to update this in the GitHub release notes section as well?

already did!

(Turning off branch protection rules so I can merge in this update to CHANGELOG.md only, then I'll turn them right back on)


update readme

Update to readme to include installing ROS2 dev tools
Add instructions for updating and rebuilding the workspace

I think we should still give the options to people that own a Ubuntu 22.04 machine.


Instapaper Support

I've added Instapaper support. I did test it and am 99% sure it works, but YQL keeps giving me errors at the moment so you will probably want to check it on you side first. There is also the issue of the user name. The only way I could think of getting the starred feed is to have the end of the feed url as the user, which isn't nice.

Does this still work? It seems they shut down RSS updating or something.

It seems to be working for me @etano, have you got your username right?

OH! Now it's going. It seems to take a few minutes for the feed to update.
Sorry!
Ethan
On Mon, Nov 7, 2011 at 11:26 AM, Joshua Hawxwell <
<EMAIL_ADDRESS>
It seems to be working for me @etano, have you got your username right?

Reply to this email directly or view it on GitHub:
https://github.com/christianv/jquery-lifestream/pull/45#issuecomment-2656466

Glad to hear it.

@etano: Glad it turned out fine.
@hawx: Thanks for helping out!


Package Info Update

reformatted README.rst to be compatible when used in Pypi
added additional package information to be shown on Pypi

Coverage remained the same at 100.0% when pulling 7ec6604f472dab2ac891682bdbd7f0f84bd5fb0f on package-information-update into 2ad1d344e295c03277e3bd6aa310d847c31fef7b on master.


add sui web modal example

Sui is a boundless platform to build rich and dynamic on-chain assets from gaming to finance.

Thanks for your PR. Unfortunately we cannot merge it yet. Please have a chat with the Web3Auth Business Team to verify whether we want to document the support for starcoin. Our documentation of different chains generally depend on the community preference and business requirements.
https://web3auth.io/contact-us.html


Python test failure

Howdy,
It seems the python tests haven't been updated and are failing with the current acronym.json file.
When I run the python file I get a test failure:
$ python3 NASA-Acronyms.py
**********************************************************************
File "NASA-Acronyms.py", line 55, in __main__.deAcronym
Failed example:
    deAcronym('ASF')
Expected:
    'Alaska SAR Facility'
Got:
    'Application Services Framework'
**********************************************************************
1 items had failures:
   1 of   7 in __main__.deAcronym
***Test Failed*** 1 failures.

Looks like "Application Services Framework" is the first result for 'ASF'.

Accepted @mbruzek's pull request that fixes this issue.


Json monitoring v2

Pull request for a patch that generates completed_data.json to be picked up by monitoring later on.
Point of contact: Naveen Kashyap
@efajardo

The latest commits implement a jsonMonitor that uses the completed_data.json created in previous commits to aggregate schedd_status and completed_data and store it in influxdb to be picked up by grafana downstream.
Note: the monitor does not work out of the box. the config file in jsonMonitoring/config/config.json needs to be configured. Also, the spec file (for RPM installation/upgrades) needs to be updated to place the logrotate file (jsonMonitoring/logrotate/factory-monitor) in the appropriate location.

Accepted and merged in v3.4
See https://cdcvs.fnal.gov/redmine/issues/20018


client fails to detect some digs

The client keeps track of "digsupply", but gets it wrong in the event that a single transaction digs up two 4.6 outputs that were created in the same transaction.
For example, 2abba6a64b0409fe064b5ca6be712e556e1096659a242b48e16a25db7b97831d outputs 86 and 161 were both first moved as f76339adf1d73901daf9ef8e66fa0a090093fc6b2f56b3fa1960cfb484f97317 inputs 41 and 42. The client only notices input 41, and not input 42.
The dig detection code in CTransaction::FetchInputs() needs to move from the 1st to the 2nd loop over the inputs, since the first loop is only making sure the transactions can be loaded, and skips any 2nd or later inputs from a single transaction.

It appears the first such instance of this happening was in block 17982:
old 17981:   "digsupply" : 6157.49432438,
new 17981:   "digsupply" : 6157.49432438,

old 17982:   "digsupply" : 7599.00197100,
new 17982:   "digsupply" : 7612.81833822,


Build: Missing templates from apps

https://github.com/andrewscwei/generator-vars-django/blob/master/app/templates/tasks/.taskconfig#L111
Templates in project/apps not included in build tasks.

That is intended. This generator expects all templates to be inside ./app/templates directory. If you need it to process templates outside of that directory, you'll have to create/modify your own task :)

OK. Thanks. I adjusted my own build file.
What's the intention of not including them?

The generator started out with Django 1.7 where by default templates were pointing to a single directory.


Pop up an error when clicking 'Manage Access Policies…' action for one QA blob container

Storage Explorer Version: 1.15.0-dev
Build: 20200731.3
Branch: master
Platform/OS: Windows 10/ Linux Ubuntu 18.04
Architecture: ia32/x64
Regression From: Previous release(1.14.2)
Steps to reproduce:

Expand one Non-ADLS Gen2 storage account -> Blob Containers.
Create a new blob container -> Add the blob container to Quick Access.
Click 'Manage Access Policies...' on the context menu of the QA blob container.
Check the result.

Expect Experience:
No error pops up and succeed to save the access policies.
Actual Experience:
An error pops up.

More Info:

This issue also reproduces when clicking 'Get Shared Access Signature…' action.

This issue also reproduces when executing 'Set Public Access Level…' / 'Acquire Lease' / 'Break Lease' actions.

This issue also reproduces when deleting / copying the blob container.

Verified on build 20200801.4. This issue has been fixed. so close it.

Verified on build 20200814.19. This issue reproduces for one emulator blob container under Quick Access. So re-open it.

Verified on build 20200812.2. The QA emulator blob container has been fixed. So close it.


Adding Network.UpdateNetwork and a unit test

Fixes #13
Also created a private helper Network.getFirstNetwork to get rid of some code reuse. @drbild do you think I should unit test this method?

Codecov Report

Merging #14 into master will increase coverage by 1.1%.
The diff coverage is 90.9%.

@@            Coverage Diff            @@
##           master      #14     +/-   ##
=========================================
+ Coverage   55.06%   56.17%   +1.1%
=========================================
  Files           4        4
  Lines         158      162      +4
=========================================
+ Hits           87       91      +4
  Misses         43       43
  Partials       28       28

Impacted Files
Coverage Δ

enf/network.go
64.7% <90.9%> (+4.7%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 555359e...a8498c8. Read the comment docs.


Created mappings for .handlebars and .css

The handlebars library officially supports both .handlebars and .hbs extensions. So mapped the extension to the existing parser for compatability.
Although most folks use either .scss or .less these days .css is still in use, so mapped it to the default parser.

Excellent, thank you!


Lots of errors

Lots of errors upon building. (Total of 154).
Before building, only 2 errors which are below.
https://gyazo.com/fcd353b65329888d3dc5d02a721db12e

Hello,
For the first two errors, uncomment these lines
And as for the rest of the 154 errors, I wouldn't know where to start unless you post a screenshot however if I were to take a guess I'd say that it's mostly sfinae errors meaning you don't have VS2017

the issue is you need to redownload imgui or download the git repo with the recursive flag in the git clone params

@M-Tass
I've uncommented the 2 lines, and the 2 errors are still persisting.
https://i.gyazo.com/c841ef0f11249f0acdd34bb5c1d05f5c.png
https://i.gyazo.com/9010b1368fded81fde233039b07503d7.png
https://i.gyazo.com/490ca737de8d5b07fadd45e494107be4.png
https://i.gyazo.com/ea4e1b645567a7d7bd2e2f051d8e28c7.png
https://i.gyazo.com/db25eaa8c6458463731b2adf30989caf.png

Hello,
Sorry I didn't realize that Imgui was updated with drastic API changes, thus I've uploaded the imgui files which I used to compile the pe

Thank you, I appreciate it!


Python3 - Set paths to what?

Hello,
I've been trying to install this wonderful toolbox for Python3 under Ubuntu 14. Do this is used this cmake command:
cmake -DPYTHON_INCLUDE_DIR=/usr/include/python3.4 -DPYTHON_EXECUTABLE:FILEPATH=/usr/bin/python3 -DPYTHON_PACKAGES_PATH=/usr/local/lib/python3.4/dist-packages -DPythonModular=ON -DCMAKE_INSTALL_PREFIX="$HOME/shogun-install" ..
It seems this was not the best idea, as I now have some files in the "/home/shogun-install" folder, as well as files in "user/local/lib". So I've been trying to set PYTHONPATH and LD_LIBRARY_PATH in the bashrc file to the right locations, but without much luck. It seems pycharm can already detect modshogun, but none of its modules (like RealFeatures, C45ClassifierTree etc.). The paths I currently have set are:
export PYTHONPATH=/usr/local/lib/python3.4/dist-packages:/home/arwilken/shogun/examples/undocumented/python_modular:$PYTHONPATH
export LD_LIBRARY_PATH=/usr/local/lib:$LD_LIBRARY_PATH
Could anyone give me a hint to which files I have to make these paths point?

Ok what files fo you have in /usr/local/lib and what files do you have in that shogun-install directory?
PYTHONPATH should point to the directory that has modshogun.py
LD_LIBRARY_PATH should point to the directory that has modshogun.so

LD_LIBRARY_PATH should point to the directory that has modshogun.so

I think you're mistaken here…  LD_LIBRARY_PATH should point to the dir libshogun.so is located in…

Yeah sorry, libshogun.so

/usr/local/lib contains folders for python2.7 and python3.4, as well as libshogun.so, libshogun.so.15 and libshogun.so.15.1
shogun-install contains the folders include, lib and share. The lib folder has the files libshogun.so, libshogun.so.17 and libshogun.so.17.1. Neither of the two paths seem to work though.

Actually, from your description of the problem it should be a PYTHONPATH issue. Wrong LD_LIBRARY_PATH would lead to undefined reference errors; in your case its modshogun.py that is missed by python.
I'd suggest you with running
PYTHONPATH=... LD_LIBRARY_PATH=... python -c 'import modshogun'
until it finally works. This would be the correct configuration.

No combination of paths worked, instead I got this nice little message for each combination:
Traceback (most recent call last):
File "", line 1, in
File "/usr/local/lib/python3.4/dist-packages/modshogun.py", line 32, in
_modshogun = swig_import_helper()
File "/usr/local/lib/python3.4/dist-packages/modshogun.py", line 28, in swig_import_helper
_mod = imp.load_module('_modshogun', fp, pathname, description)
ImportError: dynamic module does not define init function (init_modshogun)
Am I right to assume that something went wrong during the building process?

@Arnei yeah that's sort of strange. It detects modshogun.py but fails to load libshogun.so. Could it be that libshogun.so for python2.7 is used?
@besser82 do you have any idea?

Hmm, I previously had modshogun installed for python2.7 and the "libshogun.so.15" files seem to be leftovers from that installation. However, the new libshogun.so files produce the same error. I tried to build everything for python3, but maybe I have overlooked something in my cmake command?

@Arnei I'd suggest to remove all leftovers and rebuilding everything from scratch a second time…

Okay, I removed everything shogun related and rebuild it. The same error persists.

@Arnei does it work with other python version?

I think I found my mistake. As usual, it was a typo. Instead of using "python -c 'import modshogun'" I of course have to use "python3 -c 'import modshogun'" to test if it works with python3 >.<. Now everything seems to work fine (except for pycharm giving me wrong error messages, but that doesn't belong here).
Thanks a lot for your help. I definitely learned a thing or two from this.

@Arnei oh, good it is resolved. Thanks for letting us know


Konnectivity daemonset

Allows running konnectivity agents in as daemonset. Enable using:
Values.konnectivityAgent.daemonSet: true

defaults to false - use deployment.
resolves #15

I've created new PR, with squashed commits - #18


Change 64 to 63 in Snappy.decodeLiteral

Motivation:
According to https://github.com/google/snappy/blob/master/format_description.txt#L55 , Snappy.decodeLiteral should handle the cases of 60, 61, 62 and 63. However right now it processes 64 instead of 63. I believe it's a typo since tag >> 2 & 0x3F must be less than 64.
Modifications:
Use the correct value 63.
Result:
Snappy.decodeLiteral handles the correct case.

thanks @windie ! Would you be willing to throw together a unit test for this too?

It's really hard to build a real test case for this issue just using Snappy.decode and Snappy.encode. So I just made encodeLiteral and decodeLiteral package visible to test them directly.

Checking

Updated the test.

Updated using ByteBuf.release().

lgtm, @normanmaurer - ill let you pull in since you took the assignment.

@windie thanks!
Cherry-picked into 4.0 (5466f68f7847ff299fce8f817faa40f9295e2147) and 4.1 (d1ef33b8f419ac8ae591e864df2cdd24b36ef765)


Update onboarding maestro test

Task/Issue URL:
Description
Steps to test this PR
Feature 1

[ ]
[ ]

UI changes

Before
After

!(Upload before screenshot)
(Upload after screenshot)

#5008  👈
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @nalcalag and the rest of your teammates on  Graphite


Add server port config environment variable

Added ability to configure the server listening port via environment variable. If a nonstandard port is mapped in docker (e.g. 20000:19132/udp) then the client will connect to the server however status information is not properly displayed to the client. Explicitly setting the server listening port and doing a direct mapping to the alternate port (e.g. 20000:20000/udp) will allow the client to properly show the server status information. This is useful when running multiple server instances on different ports via docker-compose.

I’m guessing it has something to do with UDP being stateless but packet fu is beyond my pay grade. Regardless, was able to get a docker server set up for my kid running multiple worlds on different ports and everything NATs beautifully. Next going to try to proxy behind a netscaler and use DNS for service selection instead of ports.


@ConfigProperty fails after upgrade from Helidon 1.4.4 to Helidon 2.3.0

I have a service which uses constructor injection - like this
    @Inject     public OperationsService(@ConfigProperty(name = "operations") Config config) {
However this fails after I upgraded to Helidon 2.3.0 (See the error in attached image)

If I debug the config I can see the property in the Config as you can see here

Also note that the unit-test work fine :)
Here is the reproducer project also (Look in run.sh and edit the export line to the path for the sample.yaml file)
reproducer-cdi-configproperty.zip
Environment Details

Helidon Version: 2.3.0
Helidon MP
JDK version: 11
OS: Windows

Can you help me understand why this has started to fail after the upgrade?
Kind regards
Bogedal

@bogedal Unfortunately, you cannot inject an interior node of the config tree in the latest MP according to its spec. You can either inject a single property using @ConfigProperty or map a set of properties with the same prefix using @ConfigProperties. What you can do is inject the complete config tree and extract "operations" out of it, which is what you're doing in your unit test.
Something like:
diff -r orig/reproducer-cdi-configproperty/src/main/java/my/reproducer/domain/OperationsService.java reproducer-cdi-configproperty/src/main/java/my/reproducer/domain/OperationsService.java
3,6c3,4
< import my.reproducer.model.OperationOutput;
< import my.reproducer.model.OperationsResponse;
< import io.helidon.config.Config;
< import io.helidon.config.ConfigValue;
---
> import javax.enterprise.context.ApplicationScoped;
> import javax.inject.Inject;
10a9
> import java.util.Optional;
13,15c12,16
< import javax.enterprise.context.ApplicationScoped;
< import javax.inject.Inject;
< import org.eclipse.microprofile.config.inject.ConfigProperty;
---
>
> import io.helidon.config.Config;
> import io.helidon.config.ConfigValue;
> import my.reproducer.model.OperationOutput;
> import my.reproducer.model.OperationsResponse;
29c30
<     public OperationsService(@ConfigProperty(name = "operations") Config config) {
---
>     public OperationsService(Config config) {
75a77,84
>         Optional<Config> operations = config.asNodeList()
>                 .get()
>                 .stream()
>                 .filter(c -> c.name().equalsIgnoreCase("operations"))
>                 .findFirst();
>
>         assert operations.isPresent();
>
77c86
<         ConfigValue<List<Config>> listConfigValue = config.asNodeList();
---
>         ConfigValue<List<Config>> listConfigValue = operations.get().asNodeList();

@spericas Thanks for investigation and I change my code accordingly.
Must have missed that in the spec.
Do you have a link to that section ?

@spericas Also a side note
This code
@Inject     public OperationsService(Config config) {}
results in an unsatisfied dependency: no bean matches the injection point

@bogedal This worked in 1.4 sort of by accident, it was likely related to how it was implemented together with the Helidon SE support. If you look at the Config spec or the Javadocs for the annotations (such as @ConfigProperty) you will find that injection of interior nodes (variable of type Config) as you were doing in your constructor is not supported.
See https://download.eclipse.org/microprofile/microprofile-config-2.0/microprofile-config-spec-2.0.html#_simple_dependency_injection_example
You may want to check @ConfigProperties and how you can use that to bind properties to a bean.


Add license

So based on https://www.notion.so/sentry/Licensing-b99b3c083e174ed0850c65e313a79a68#878bd72258814bef883a842f49868d15

We use the Business Source License-1.1 with a conversion to Apache-2.0 in 36 months after initial release for the main Sentry repository and all direct sub-projects of it, such as the documentation or Snuba.


Docs: update example from Window signal files_dropped

As mentioned in godot-docs/issues/10318, switching to get_window() may be more appropriated as we are talking about a signal that only exist in Window.
Note: I think that this PR is so small that could be done together with another docs update.
Bugsquad edit: closes https://github.com/godotengine/godot-docs/issues/10318

Thanks!


swagger project edit - cannot get /

I'm completely new to the project and was just following the 5 steps in the README. However step 3 fails.
The server starts and opens my browser at http://<IP_ADDRESS>:34407/#/edit however all I get is a 404 with a Cannot GET / error message.
Maybe there's a step missing in the README?
In case it matters:
$ node --version
v7.7.2
$ npm --version
4.4.1
$ uname -a
Linux perd 4.10.1-1-ARCH #1 SMP PREEMPT Sun Feb 26 21:08:53 UTC 2017 x86_64 GNU/Linux

I was also getting this error becouse I had swagger installed locally as devDependency, but it seems that it also needs swagger-editor package in order to work.

That's it! I installed swagger-edit and it worked. Thanks!

Good spot @splitbrain. Might be better if a sensible error message is shown in this case though, would it be worth re-opening this issue and updating it to something like:
If swagger-editor is not installed, show a sensible error message
WDYT?

I guess we can make a better error message as @dwmkerr suggests.

I just added it with: npm install --save-dev swagger-editor and all work as expected.

I think the correct way to proceed is add swagger-editor as peer dependency.

Given the codebase is auto-generated - why not just add it the the devDependencies? and also to the README that you need to install devDeps?

Also the readme says to install swagger globally, in which case the editor seems to need to be installed globally as well.
Great project guys - thanks for all your contributions!

Installing swagger-editor globally solved it for me.
sudo yarn global add swagger-editor
Tried it as a devDependencies and didn't work. Once the package was installed globally, it worked fine with a new project (swagger project create hello-world)

I installed both swagger and swagger-editor globally but it didn't work. I am trying to install on windows 10 :(


Fix the commands to run client and server side tests and generate Instanbul reports

Yeah, you can add a custom command to the scripts section of the
package.json to run both of them.  As far as coverage goes, I am not sure;
I haven;t looked up how to run istanbul on our Angular tests yet.
On Mon, Jul 4, 2016 at 6:48 AM Josh Sherman<EMAIL_ADDRESS>wrote:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/PennStateSoftwareTest/FinalProjectPennState/issues/154,
or mute the thread
https://github.com/notifications/unsubscribe/AFI0nqS2vI-QRaVMVFWGbR9R_WdWETY3ks5qSQENgaJpZM4JEVzb
.

This would be nice to have for our report out to professor next week, do
you want me or you to figure this out?
On Mon, Jul 4, 2016 at 9:28 AM, nevinsjr<EMAIL_ADDRESS>wrote:

Yeah, you can add a custom command to the scripts section of the
package.json to run both of them. As far as coverage goes, I am not sure;
I haven;t looked up how to run istanbul on our Angular tests yet.
On Mon, Jul 4, 2016 at 6:48 AM Josh Sherman<EMAIL_ADDRESS>wrote:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<
https://github.com/PennStateSoftwareTest/FinalProjectPennState/issues/154
,
or mute the thread
<
https://github.com/notifications/unsubscribe/AFI0nqS2vI-QRaVMVFWGbR9R_WdWETY3ks5qSQENgaJpZM4JEVzb
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/PennStateSoftwareTest/FinalProjectPennState/issues/154#issuecomment-230290809,
or mute the thread
https://github.com/notifications/unsubscribe/AMuN2IpX7CHlOES1WeYQsBP4dyCNvMHWks5qSQp4gaJpZM4JEVzb
.

--
Josh Sherman
www.joshandmariamusic.com

You can take a crack at it if you would like.
On Mon, Jul 4, 2016 at 7:37 AM Josh Sherman<EMAIL_ADDRESS>wrote:

This would be nice to have for our report out to professor next week, do
you want me or you to figure this out?
On Mon, Jul 4, 2016 at 9:28 AM, nevinsjr<EMAIL_ADDRESS>wrote:

Yeah, you can add a custom command to the scripts section of the
package.json to run both of them. As far as coverage goes, I am not sure;
I haven;t looked up how to run istanbul on our Angular tests yet.
On Mon, Jul 4, 2016 at 6:48 AM Josh Sherman<EMAIL_ADDRESS>wrote:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<

https://github.com/PennStateSoftwareTest/FinalProjectPennState/issues/154

,
or mute the thread
<

https://github.com/notifications/unsubscribe/AFI0nqS2vI-QRaVMVFWGbR9R_WdWETY3ks5qSQENgaJpZM4JEVzb

.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<
https://github.com/PennStateSoftwareTest/FinalProjectPennState/issues/154#issuecomment-230290809
,
or mute the thread
<
https://github.com/notifications/unsubscribe/AMuN2IpX7CHlOES1WeYQsBP4dyCNvMHWks5qSQp4gaJpZM4JEVzb
.

--
Josh Sherman
www.joshandmariamusic.com
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/PennStateSoftwareTest/FinalProjectPennState/issues/154#issuecomment-230292622,
or mute the thread
https://github.com/notifications/unsubscribe/AFI0npoinJCnf-n7D2vgD3HijJDj5393ks5qSQybgaJpZM4JEVzb
.

Mina, please add this to the test plan @habibmn09


Sign SCP envelopes and add a Byzantine node test

Requires:

~https://github.com/bpfkorea/agora/pull/545~
~https://github.com/bpfkorea/agora/pull/546~

See also malloc signature issue ~#547~
Blocked by: ~https://github.com/bpfkorea/agora/issues/744~

This is no longer blocked. Comments should be addressed and changes rebased.

Rebased. But I think it will need to be reworked again if #785 is merged first.

Rebased. But I will add another test to it.

This is outdated and will be superseded by schnorr-based signatures.


Encode fails immediately on 2nd pass with "Cannot enlarge memory arrays."

Attempting to encode 10 seconds of a video, the first pass (thread 1) finishes without problems, but then the second pass fails immediately.
Test cases: 720p mp4 (failed, logs attached), 720p mp4 (failed), 360p mp4 (encoded successfully)
Options chosen: 10 second duration, 2 threads, otherwise defaults.
Main log:
[18:49:33] Spawning jobs:
[18:49:33]   2 video thread(s)
[18:49:33]   1 audio thread
[18:49:33] Video 1 started first pass
[18:49:33] Video 2 started first pass
[18:49:33] Audio started
[18:49:41] Audio finished (00:00:07.1)
[18:50:40] Video 1 finished first pass (00:01:06.1)
[18:50:40] Video 1 started second pass
[18:50:44] Fatal error at Video 1: Uncaught abort("Cannot enlarge memory arrays. Either (1) compile with -s TOTAL_MEMORY=X with X higher than the current value 67108864, (2) compile with ALLOW_MEMORY_GROWTH which adjusts the size at runtime but prevents some optimizations, or (3) set Module.TOTAL_MEMORY before the program runs.") at Error
    at Error (native)
    at xa (https://kagami.github.io/webm.js/1527e3d81b.ffmpeg-worker-webm.js:12:141)
    at E (https://kagami.github.io/webm.js/1527e3d81b.ffmpeg-worker-webm.js:25:196)
    at Function.g.Oa [as Rd] (https://kagami.github.io/webm.js/1527e3d81b.ffmpeg-worker-webm.js:35:165)
    at Aa (https://kagami.github.io/webm.js/1527e3d81b.ffmpeg-worker-webm.js:18:24)
    at wNa (https://kagami.github.io/webm.js/1527e3d81b.ffmpeg-worker-webm.js:4838:6988)
    at oHa (https://kagami.github.io/webm.js/1527e3d81b.ffmpeg-worker-webm.js:4827:213617)
    at SKa (https://kagami.github.io/webm.js/1527e3d81b.ffmpeg-worker-webm.js:4824:122774)
    at Array.VKa (https://kagami.github.io/webm.js/1527e3d81b.ffmpeg-worker-webm.js:4824:134263)
    at Object.gRa [as dynCall_vii] (https://kagami.github.io/webm.js/1527e3d81b.ffmpeg-worker-webm.js:4838:121823)
If this abort() is unexpected, build with -s ASSERTIONS=1 which can give more information.

Video 1 Log:
$ ffmpeg -hide_banner -ss 0 -i in.mp4 -t 5 -c:v libvpx -b:v 6489k -speed 4 -auto-alt-ref 1 -lag-in-frames 25 -sn -c:a libopus -b:a 64k -ac 2 -an -pass 1 -f null -
[h264 @ 0x747b40] Warning: not compiled with thread support, using thread emulation
[aac @ 0x74ed30] Warning: not compiled with thread support, using thread emulation
Input #0, mov,mp4,m4a,3gp,3g2,mj2, from 'in.mp4':
  Metadata:
    major_brand     : mp42
    minor_version   : 0
    compatible_brands: isommp42
    creation_time   : 2013-12-23 17:25:06
  Duration: 00:02:04.97, start: 0.000000, bitrate: 1916 kb/s
    Stream #0:0(und): Video: h264 (High) (avc1 / 0x31637661), yuv420p, 1264x720, 1721 kb/s, 23.98 fps, 23.98 tbr, 48k tbn, 47.95 tbc (default)
    Metadata:
      handler_name    : VideoHandler
    Stream #0:1(und): Audio: aac (LC) (mp4a / 0x6134706D), 44100 Hz, stereo, fltp, 191 kb/s (default)
    Metadata:
      creation_time   : 2013-12-23 17:25:06
      handler_name    : IsoMedia File Produced by Google, 5-11-2011
[libvpx @ 0x76cd40] Warning: not compiled with thread support, using thread emulation
[libvpx @ 0x76cd40] v1.4.0
[h264 @ 0x769d20] Warning: not compiled with thread support, using thread emulation
Output #0, null, to 'pipe:':
  Metadata:
    major_brand     : mp42
    minor_version   : 0
    compatible_brands: isommp42
    encoder         : Lavf56.36.100
    Stream #0:0(und): Video: vp8 (libvpx), yuv420p, 1264x720, q=-1--1, pass 1, 6489 kb/s, 23.98 fps, 23.98 tbn, 23.98 tbc (default)
    Metadata:
      handler_name    : VideoHandler
      encoder         : Lavc56.41.100 libvpx
Stream mapping:
  Stream #0:0 -> #0:0 (h264 (native) -> vp8 (libvpx))
Press [q] to stop, [?] for help
frame=    3 fps=0.0 q=0.0 size=N/A time=00:00:00.00 bitrate=N/A
frame=    5 fps=3.9 q=0.0 size=N/A time=00:00:00.00 bitrate=N/A
frame=    7 fps=3.4 q=0.0 size=N/A time=00:00:00.00 bitrate=N/A
frame=    9 fps=3.3 q=0.0 size=N/A time=00:00:00.00 bitrate=N/A

[ ... Cut ... ]

frame=  120 fps=2.0 q=0.0 Lsize=N/A time=00:00:00.00 bitrate=N/A
video:0kB audio:0kB subtitle:0kB other streams:0kB global headers:0kB muxing overhead: unknown
Output file is empty, nothing was encoded
$ ffmpeg -hide_banner -ss 0 -i in.mp4 -t 5 -c:v libvpx -b:v 6489k -speed 1 -auto-alt-ref 1 -lag-in-frames 25 -sn -c:a libopus -b:a 64k -ac 2 -an -pass 2 1.webm
[h264 @ 0x747b20] Warning: not compiled with thread support, using thread emulation
[aac @ 0x74ed10] Warning: not compiled with thread support, using thread emulation
Input #0, mov,mp4,m4a,3gp,3g2,mj2, from 'in.mp4':
  Metadata:
    major_brand     : mp42
    minor_version   : 0
    compatible_brands: isommp42
    creation_time   : 2013-12-23 17:25:06
  Duration: 00:02:04.97, start: 0.000000, bitrate: 1916 kb/s
    Stream #0:0(und): Video: h264 (High) (avc1 / 0x31637661), yuv420p, 1264x720, 1721 kb/s, 23.98 fps, 23.98 tbr, 48k tbn, 47.95 tbc (default)
    Metadata:
      handler_name    : VideoHandler
    Stream #0:1(und): Audio: aac (LC) (mp4a / 0x6134706D), 44100 Hz, stereo, fltp, 191 kb/s (default)
    Metadata:
      creation_time   : 2013-12-23 17:25:06
      handler_name    : IsoMedia File Produced by Google, 5-11-2011
[libvpx @ 0x76d210] Warning: not compiled with thread support, using thread emulation
[libvpx @ 0x76d210] v1.4.0

Video 2 and Audio logs not attached as they seem to be typical (although Video 2 only got 80 frames into the encode)

The offending file: https://www.dropbox.com/s/8d5ua6ub2b1na36/ThisFileIsProblematic.mp4?dl=0

Hi, thanks for the report!
It seems to be (64M - 29M) memory is not enough for h264 decoder with 720p video and libvpx encoder. I currently bumped memory size to 80M, but I hope to fix issues with big files soon.
Could you please test again?

Issue seems to be resolved. Great work!

Btw, it took me 18 minutes to encode the entire video (2min, 720p). Not that bad.


isSorting bool

Hey
Is there a way to get a prop down the row that signals if it's being dragged or not? Would want to do some more advanced stuff than just pass down a style

I have a need to disable stickyHeaderIndices while a row is being dragged. I've solved this for my need with a one-off copy of this component - but I think if I cleaned it up a bit I could submit a PR adding anRowPickedUp and onRowDropped events (except with better names) to the react-native-sortable-listview API - these would tell which row was picked up or dropped so you could then implement your custom logic on top of this component...
@deanmcpherson - would you be willing to accept a PR with these events? If so, do you have property names that you like? Should there be one prop (onRowInteractedWith({rowIndex, state,...}) or two (onRowPickedUp, onRowDropped)?
Thanks
-Cal

Actually - we already have onRowMoved, adding onRowActivated (or a better name) that gets an argument with two properties - 'from' and 'row' - should give us what we need

@CaleyD could you show me how you did this? I need to do some animating on the row component

There are undocumented props available for onMoveStart and onMoveEnd which are called once the drag begins itself that you could use to approximate the desired functionality.  @CaleyD I'd definitely accept a PR with something like onRowStart or onRowSortStart. I think two separate props would be cleaner.

Came to suggest the same thing.
I'm having trouble doing more advanced styling of the active row. I need to adjust the style of a single element within the active row component, not just the container of the row.
An isSorting bool to renderRow would make this a lot simpler.

Is this still an issue @dsernst ?
If you need a boolean passed to the active row, your renderRow function has 5 parameters, the last one being weather or not the row is currently the active row. See here

Thanks for checking in. Because of resource constraints, we're no longer using RN 😕 Mobile web only for now.


markdown can't recognize record type

Does this issue occur when all extensions are disabled?: No

VS Code Version:  1.74.0
OS Version:  Windows 10

Steps to Reproduce:
public record Student(string FirstName, string LastName);
public record Teacher(string FirstName, string LastName);

you can see that markdown doesn't really support record type, so there is no highlight on the keywords such as string, public and record keywords

Looks like the same happens in a normal c# filea:

Upstream issue: https://github.com/dotnet/csharp-tmLanguage/issues/242


Add unit tests for cn.escheduler.common.utils.CollectionUtils

I've analysed your codebase and noticed that cn.escheduler.common.utils.CollectionUtils is not fully tested.
I've written some tests for the methods in this class with the help of Diffblue Cover.
Hopefully, these tests will help you detect any regressions caused by future code changes. If you would find it useful to have additional tests written for this repository, I would be more than happy to look at other classes that you consider important in a subsequent PR.

thank you very much! very good!


Bump harbor version

upstream changelogs
harbor: https://github.com/goharbor/harbor/compare/v2.7.1...v2.9.1
harbor-helm: https://github.com/goharbor/harbor-helm/compare/v1.11.1...v1.13.1
upstream golang source of truth
https://github.com/goharbor/harbor/blob/main/src/go.mod#L3
explanations of changed/removed patches
0001-add-digest-namespace-and-imagepullsecret-support.patch: changed based on the upstream change (chartmuseum, notary removed)
0002-generate-swagger-models-and-restapis.patch: patch is regenerated from "make gen_apis"
0003-security-patch.patch: no longer needed, upstream has patched dependencies
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve

/lgtm


Textured quads

Hi,
Very impressive coding!
Any tips on using Textured quads?
I've compiled mld62 also, but that doesn't run at all for me, but I see you use textures there :)

Off the top of my head:

If you can use textured triangles, you can probably use textured quads too, just add an extra point to your call.
You need to set up texpage stuff in order to use textures.
You should probably use 4-bit CLUT mode just so you can get the extra resolution and some extra tile memory space.

As for mld62, I just built it with gcc 6.1.0 and the text is wrong - I have a fix for that, src/gpu.c, comment out the line that sends 0x000001C0 for the CLUT.
If the only thing you're hearing is music, are you sure your toolchain is set up to handle soft floats?

Thanks for the tips.
I compiled the flite game and it works fine on PCSXR, I'm using the same toolchain.
Only strange thing was sprintf was undefined, so I commented them out

#define sprintf //

On No$PSX, I do just get music from mld62 but now I can see the texture on VRAM viewer and it flashes something on the screen and then disappears.
I get nothing on PCSXR tho.
Thanks for any help.


When there is a commented AssemblyVersion in the AssemblyInfo file, it changes that one, but doesn't change the uncommented one

This is the result after I've run the version updated on an AssemblyInfo.cs file showing that the replacement only occurs on the first occurence in the file even if the line that it changes is commented, and subsequent uncommented AssemblyVersions are left unmodified...
// [assembly: AssemblyVersion("<IP_ADDRESS>")]
[assembly: AssemblyVersion("<IP_ADDRESS>")]
[assembly: AssemblyFileVersion("<IP_ADDRESS>")]

Unfortunately, there is not much that can be done to skip these occurrences. I could add an extra check to exclude the lines that have two slashes at the beginning, but that will not affect multi-line comments or string literals like
string attribute = """[assembly: AssemblyVersion("<IP_ADDRESS>")]""";

Adding a full C# syntax parser into a simple GitHub action also doesn't feel like a good idea.
I will add an error message for the case when there are two or more matching occurrences found in a single file.

Thanks for adding the error message!  I like the idea of checking to exclude lines that begin with the // comment.  I realize that doesn't catch the multi-line, but would certainly solve the bulk of cases and especially those comments that are typical in an AssemblyInfo.cs

Implemented in version 1.6.
Apart from the new error message for duplicate attributes, the action will now require the attributes to appear at the beginning of the line (after trimming whitespace characters). This will allow it to skip commented lines, e.g.
// [assembly: AssemblyVersion("1.2.3")]

but it will also skip attributes when they appear on the same line after another attribute:
[assembly: AssemblyVersion("1.2.3")] [assembly: AssemblyFileVersion("1.2.3")]

(only the first attribute will be processed).
I think this is a reasonable compromise because the first case is much more common than the second one.


feat: upgrade secp256k1 to 0.12.2

This upgrades secp256k1 from 0.10.0 to 0.12.2.
Additionally a warning was fixed that would be an error in swift 6.

Related: https://github.com/horizontalsystems/HsExtensions.Swift/pull/5

Related: https://github.com/horizontalsystems/HdWalletKit.Swift/pull/9

These changes would need to be propagated to BitcoinCore, Hodler and BitcoinKit, probably via .upToNextMinor instead of .upToNextMajor.


Adding testing resources

Adding checks for new Dex playbook so you are able to rerun it with no errors, plus a simple check to verify.yml so you can also rerun it.
Adding testing resources so people without TF access can easily deploy the collection and test

Disconnecting dex-idp from podman network, found an issue with network flapping causing the container to be unreachable after max one attempt, which is why it worked so far in CI but would fail for local development if someone tried to resign/reverify

@SequeI add some notes for this to the read me, otherwise its all good to go.


Make better regex condition

It appears that here, this plugin requires that the test have addExampleInTable inside its body in order to be considered to have its tag extracted. I don't think that most tests will necessarily have that text inside their body.
And here the regex is very restricting - the requirement of "testRailTag":"(${prefixTag}\d+)" does not fit into the semantics of prefixTag (That is, that prefixTag should be the entire regex barring the numerical portion generated by TestRail)
With this change, I would be able to set prefixTag to Test_ID=C and then have the regex match Test_ID=C12345, without the testRailTag portion.

Hi @fionahu-bluescape would be nice if you could add some tests. 😄


How do I switch to desktop mode?

I am using the browser for spotify and when I first lauched the browser it lauched in desktop mode. Now its only launching in  phone mode and will ask alot about spotify premium

I will just post this in the lightning launcher because it might be more relevant over there


Coupon Creation Error

[BuycraftX] Plugin BuycraftX v12.0.8 generated an exception while executing task 94930 java.lang.reflect.UndeclaredThrowableException: null 	at jdk.proxy13.$Proxy86.createCoupon(Unknown Source) ~[BuycraftX.jar:?] 	at net.buycraft.plugin.bukkit.command.CouponSubcommand.lambda$createCoupon$0(CouponSubcommand.java:55) ~[BuycraftX.jar:?] 	at org.bukkit.craftbukkit.v1_17_R1.scheduler.CraftTask.run(CraftTask.java:101) ~[patched_1.17.1.jar:git-Paper-411] 	at org.bukkit.craftbukkit.v1_17_R1.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:57) ~[patched_1.17.1.jar:git-Paper-411] 	at com.destroystokyo.paper.ServerSchedulerReportingWrapper.run(ServerSchedulerReportingWrapper.java:22) ~[patched_1.17.1.jar:git-Paper-411] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?] 	at java.lang.Thread.run(Thread.java:833) ~[?:?] Caused by: java.lang.NoSuchMethodException: java.lang.invoke.MethodHandles$Lookup.<init>(java.lang.Class,int) 	at java.lang.Class.getConstructor0(Class.java:3585) ~[?:?] 	at java.lang.Class.getDeclaredConstructor(Class.java:2754) ~[?:?] 	at net.buycraft.plugin.internal.retrofit2.Platform$Java8.invokeDefaultMethod(Platform.java:102) ~[BuycraftX.jar:?] 	at net.buycraft.plugin.internal.retrofit2.Retrofit$1.invoke(Retrofit.java:145) ~[BuycraftX.jar:?] 	... 8 more``

bumping this as im now facing this issue as well please fix this someone said it has to do with java 17?

Hi there,
Thanks for taking the time to report this issue, I'm sorry it's been slow to get resolved — we're working on it!
We are currently planning a recode of the Buycraft plugin at some point in Q2 of this year, and we would love to know what issues still exist so they can be fixed for the new plugin.
If your issue still exists, please reply here and I'll look into getting them fixed.
Apologies for the issues you have faced!

Hello, any updated ETA for this update?
I'm facing this exact issue on Java 17 and no console commands are working either as well as the API (intended for a custom plugin that creates coupons/gift cards automatically for players).

Hello, any updated ETA for this update?
I'm facing this exact issue on Java 17 and no console commands are working either as well as the API (intended for a custom plugin that creates coupons/gift cards automatically for players).

Hey Skycar! Apologies that you’re facing this same issue, as mentioned above we are in the planning stages with a new plugin.
Please use the dashboard for that functionality for now, and I’ll give you an update once we have our new plugin.

Hi, thanks for the quick response. Is there an approximate timeline in terms of when you expect said new plugin to be completed?

As we are approaching the midpoint of Q2.

Hi, thanks for the quick response. Is there an approximate timeline in terms of when you expect said new plugin to be completed?

I completely understand, we hope to get a beta out in this quarter :)

Ok great. Will this jar be posted on the Tebex website, Spigot or both?

Ok great. Will this jar be posted on the Tebex website, Spigot or both?

Once it’s out officially, we will aim to have it posted everywhere. Stay tuned! :)

How do I get access to the beta? And how long will the beta period last/how much longer until the plugin’s released officially?

How do I get access to the beta? And how long will the beta period last/how much longer until the plugin’s released officially?

that guy is a troll btw lol

Rip lmao. & I hope it is

How do I get access to the beta? And how long will the beta period last/how much longer until the plugin’s released officially?

that guy is a troll btw lol who knows if its being worked on by the actual devs

I’m not a troll, I work at Tebex :)
Long time no speak Disorbs too haha, I joined in October after the acquisition of Analyse.

Hi again,
I'm just following up to let you know that we have now added this bug to our internal tracking system.
Our team is currently working on a number of important projects, including a recode of the Buycraft plugin this quarter. We will keep your bug in mind as we work on this update and will note it in our development roadmap.
Since we have now noted your bug in our internal tracking system, we will be closing this GitHub ticket. However, if you have any further suggestions or feedback, please don't hesitate to open a new ticket and we'll be happy to take a look.
Thanks again for reporting this bug and for your continued support of Tebex.
Best regards,
The Integrations Team.


Make pruning optional for debugging

We recently reworked pruning (#221, #250, #252). It works more reliable now and can reduce computational overhead quite a lot.
However, for debugging, it can be useful to attempt all possible computations.
This can help to identify culprits and identify longest partial solutions in the current design.
I would propose to add a pruning property to the Task container and allow users to call setPruning(false) if they want to do so.

Maybe, instead of defining this property in the top-level task container only, you want to do so at the individual container level?
I also suggest automatically inheriting this property from the parent.

Maybe, instead of defining this property in the top-level task container only, you want to do so at the individual container level?
I also suggest automatically inheriting this property from the parent.

Yes. I don't think we could implement it easily any other way, because the individual stages need to be able to see the flag.
I think there are also unresolved issues with default sources for inheritance though - I seem to recall we don't support them at the moment.

Fixed via #590


Updated Json.Net version

@Eilon @rynowak FYI

Hi @ajaybhargavb, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;


Particle Locations

Hi,

I've been able to run the program on Ubuntu 14.04 with minimal troubles. Now
I'm wondering if I'm actually able to obtain a list of particle locations from
the program, so that I may use these in a further CFD application. I assume it
has something to do with packing.xyzd?

Any help would be much appreciated.

Cheers

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 21 Apr 2015 at 11:40

Hi,
sorry for not replying for a long time (i didn't actually think that people will use it intensively enough to submit issues).
You are right. The packing.xyzd description is here: https://code.google.com/p/packing-generation/#Packing_file_format
It shall be straightforward to read these files in any language.
Best,
Vasili

Hi,
I have also been able to run the program with eclipse+cygwin. However, I am unable to read the generated packing.xyzd and packing_init.xyzd files. Whenever I open these files, they seem like a collection of symbols. My guess is that this issue is related to endianness of the system, but I don't really know how to fix this bug. Any heads in how to solve the problem?
Cheers,
Gloria

Hi Gloria,
I've added the MATLAB script for reading the packings. To make it work, you need to download the entire folder with the scripts. The code for reading the packing is in this file (the function ReadPacking). I think the C++ program always saves the packings in the Little-Endian format (and this MATLAB script also assumed it). Please also note the part about diameter rescaling in the MATLAB script. I realized it was missing from the documentation. I also updated the front page correspondingly. Hope this helps.
Best,
Vasili


Fix the Footer for phones

Describe the bug
The website footer overlaps and looks ugly.
To Reproduce
Just use a phone to access the website or make the browser smaller.
Expected behavior
Footer should not overlap!
Screenshots

Additional context
Add any other context about the problem here.


Included BRANCHID node

Included the item agencyNumber referring to BRANCHID node in the method buildBankAccount

Is BRANCHID always present?

Yes, at least in banks operating in Brazil, is no such requirement.
Always!

Thanks! :)

This is included in 1.0.2


fix(filter bar): Add back work item type filter

@nimishamukherjee fabric8/fabric8-ui:SNAPSHOT-PR-2315-1 is deployed and available for testing at https://fabric8-ui-fabric8-ui-pr-2315-fabric8-planner.badger.fabric8.io

@nimishamukherjee fabric8/fabric8-ui:SNAPSHOT-PR-2315-2 is deployed and available for testing at https://fabric8-ui-fabric8-ui-pr-2315-fabric8-planner.badger.fabric8.io

@nimishamukherjee fabric8/fabric8-ui:SNAPSHOT-PR-2315-3 is deployed and available for testing at https://fabric8-ui-fabric8-ui-pr-2315-fabric8-planner.badger.fabric8.io


Face tracking and landmark detection not accurate.

 So one of the options was to use a face tracker.
Procedure:
I am detecting a face in the first frame, then I create a tracker for the detected face. Then the tracker runs for the next frames until it loses its target. If the target is lost, the old tracker is deleted and a new tracker is created with the output of the face detector.
Problem:
If I apply the landmark detector over the tracker's ROI, then the landmark detection gets pretty innacurate sometimes.
Preview: https://www.youtube.com/watch?v=WozvmF1kaZU&feature=youtu.be
Legend:

Cyan: OpenCV KCF Tracker (and landmark over the tracker's box)
Blue: Dlib's HOG face detector (and landmark over the detected face bounding box)

Models used:

Dlib frontal face detector default model
Dlib 68 shape predictor

Question:
Is the problem of a not well-trained 68-landmark shape predictor? Or the problem is in the tracker?
If neither of both, what would be the problem and what else can I do?

The problem is the initial bounding box becoming too off for the shape
predictor to work correctly.  If you want to do this you should use the
shape predictor to correct the box position on each frame.  You will need
to match the box position that would have been given by dlib's detector.


Req: Include the thumbnail in the archive

As a user, I do not like that restored exports sometimes load in Tabletop Simulator showing a generic '?' instead of the author supplied thumbnail.
Background
Workshop and Saves both consist of a *.json file as well as a like-named *.png thumbnail. As a user, I would like the pak file to include the thumbnail. This relates to #28 as TTS Mod Downloader provides this capability, and we should store thumbnails in the same fashion to ensure compatibility between the two applications.
Path for JSON: mods/workshop/{filename}.json
Path for Thumbnail: Mods/Workshop/Thumbnails/{filename}.png
Separating the thumbnail into a subfolder seems unnecessary to me, but it doesn't it cause any harm doing it this way, and it makes compatibility easier.
We should be able to handle 3 situations gracefully:

pak file contains no thumbnail
-- simply don't restore any thumbnail and log a Warning
pak file contains exactly 1 thumbnail (this is the normal case)
-- restore the thumbnail, renaming if necessary so it matches the name of the json file.
pak file contains multiple thumbnails (this should not be valid)
-- restore the thumbnail that has the same filename as the json, or
-- restore the first thumbnail in the zip, renaming if necessary, and log a Warning

If the above 3 situations are handled, no change to the Meta data should be necessary unless old version of TTS-Manager would do the wrong thing in the presence of a Thumbnails sub folder in the zip. So this should be tested with a meta data version bump if necessary.

So if the doesn't go in a folder, it'll unpack fine with old versions, but (probably) not with TTS-Manager.
If it goes in a folder, it'll unpack fine with old versions, but create a Thumbnails folder in the dest which Tabletop Simulator doesn't read.
Bumping the version in the pak metadata doesn't affect the outcome since there's no assertion to prevent old apps from opening newer pak versions ¯_(ツ)_/¯. so I guess my vote is include the folder, bump the version, and make the app warn if newer versions are used.

you know, we can just parse the json file and I think that tells us everything (and more) than the meta data, anyway.


reading dataview-generated inline links does not work

Hello,
First of all thank you so much for this plugin, I am just starting diving into obsidian and the plugin really adds an indispensable geo dimension which is very valuable.
Where I can indeed make standard geo location links be recognized and have the Interactive Map View follow them, it does not seem to work if I have those links generated by dataview. Here is an example which hopefully would fetch all notes from the "Locations" folder and use their location frontmatter to generate inline geo links which would then be recognized by the Map View. A geo link is successfully generated and I can click on it to open the map, but the Map View is not doing its job
dataviewjs

const query = `
LIST
	"[location](geo:"+file.frontmatter.location[0]+","+file.frontmatter.location[1]+")"
FROM "Locations"

`;

dv.execute(query)

First of all, thank you for the kind words!
To some extent, the fact geo links are generated in the dataviewjs blocks is a bug or an unintended feature :sweat_smile: There is a Markdown post processor that Map View installs and recognizes the link although they are not "truly" present in the file. However, when the main map view transverses your notes, the geolinks are not really there.
To mitigate this, Map View would need to use the Dataview API and execute (then probably cache the results of) these queries. I am not sure what are the performance implications of doing this for a large number of notes when they are searched for geolinks.
Integration with Dataview is something I've been wanting to do for a long time, it's definitely in the roadmap, I just can't point out a timeline yet. (Some developer who's interested in investigating this and can push it forward will surely help!)
BTW, for general knowledge, what is the use case for which you are generating inline geolinks inside a query that seems to take locations from other notes? Seems like you are using the location field of other notes in this query, which Map View can display directly. (And actually, seems like showing them as part of the note with the query, makes an opening to duplicating them many times)

Thanks for the comprehensive answer! My use case is the following (this is my first day using Obsidian so hopefully I will not say silly things)
I created a folder called Location where I aim to create a note for each meaningful location. Each note has its location field with its coordinates. For example, let's say two notes:
Note1: Cafe Alpha
Note: Location Beta
Moving forward, when I am taking notes, I thought about being able to quickly to link to a location by typing something like:
Meeting at [[Cafe Alpha]] which allows use to make use of the auto-complete (i.e. typing [[Caf..]] suggests the Cafe Alpha note which is perfect).
I was then hoping to then add something along the line of the following at the top/bottom of a note - and hopefully a template which is something that I still to dive into -

dataviewjs
const query = `
TABLE without ID
	"["+file.name+"](geo:"+file.frontmatter.location[0]+","+file.frontmatter.location[1]+")"
FROM "Locations"
WHERE regextest(this.file.name, file.inlinks.filename)
`;

dv.execute(query)

...with the hope that this would automatically generate a list of inline geo link(s) which would then be picked up by the Interactive View Map. I am then thinking that I would jsu

Creating a note for each meaningful location is a great way to go (I do that too for very often), with the auto-complete and everything.
However, sounds to me like you can accomplish what you're looking for without DataviewJS. Just create an embedded map as part of your template, use the $filename$ parameter (see here ), with a query similar to the example given there that uses linkedfrom:, and you're good to go.

Glad that we share the same view on having one note for meaningful locations! Yes, you are right, it does pretty much achieve the same result @esm7 , thank you, that's how I will use your amazing plugin for now! Here is still some feedback with the aim of further improving things :)

the embedded map does work and this is great. The interactive Map View on the other hand does not get populated (I presume for the same reason that it does not pick up the dataview-generated geo links) which is a bit of a pity as one might prefer not to have any embedded map in the middle in the note - which is why the side map viewer is such a nice thing to have, nice and discreet for a side-glance.
leveraging the dataview plugin sounds like you might get rid of the hassle of implementing more and more query features as people come up with their own needs, and instead externalise this to dataview.

You are obviously right that there would be some integration to go over though, as introduced on this page:
https://blacksmithgu.github.io/obsidian-dataview/resources/develop-against-dataview/
Again, I just installed Obsidian so please take my feeedback with a grain of salt. On the other hand, thanks again for having set up this plugin, I see it as a must have.

Can you elaborate about your interactive map view not getting populated? Basically the embedded map uses the exact same data flow and code, so if one works the other should work as well. How are you opening the map (i.e. are you possibly opening it with some query that hides some of the markers)?


storefront_ui docker doesn't start up

I tried including the KlarnaCheckout in my project but I'm stuck at a certain point, so I thought let's give your example a good look.
But when trying to docker-compose up, the storefront_ui container crashes after successfully building. Here's its last words:
...
storefront-ui_1   | <s> [webpack.Progress] 100%
storefront-ui_1   |
storefront-ui_1   | Hash: 9f5d9ecbd18cb1aa32f1
storefront-ui_1   | Version: webpack 4.39.0
storefront-ui_1   | Time: 122411ms
storefront-ui_1   | Built at: 08/02/2019 10:41:43 AM
storefront-ui_1   |  46 assets
storefront-ui_1   | Entrypoint app = manifest.9f5d9ecbd18cb1aa32f1.js vendor.9f5d9ecbd18cb1aa32f1.js app.9f5d9ecbd18cb1aa32f1.js
storefront-ui_1   |
storefront-ui_1   | ERROR in ./src/modules/payment-klarna/hooks/beforeRegistration.ts
storefront-ui_1   | Module not found: Error: Can't resolve '@vue-storefront/core/lib/router-manager' in '/var/www/src/modules/payment-klarna/hooks'
storefront-ui_1   |  @ ./src/modules/payment-klarna/hooks/beforeRegistration.ts 2:0-72 19:4-17 21:4-17
storefront-ui_1   |  @ ./src/modules/payment-klarna/index.ts
storefront-ui_1   |  @ ./src/modules/index.ts
storefront-ui_1   |  @ ./core/modules-entry.ts
storefront-ui_1   |  @ ./core/app.ts
storefront-ui_1   |  @ ./core/client-entry.ts
storefront-ui_1   |  @ multi babel-polyfill ./core/client-entry.ts
storefront-ui_1   |
storefront-ui_1   | ERROR in /var/www/src/modules/payment-klarna/hooks/beforeRegistration.ts
storefront-ui_1   | [tsl] ERROR in /var/www/src/modules/payment-klarna/hooks/beforeRegistration.ts(2,31)
storefront-ui_1   |       TS2307: Cannot find module '@vue-storefront/core/lib/router-manager'.
storefront-ui_1   |
storefront-ui_1   | ERROR in /var/www/src/modules/payment-klarna/store/getters.ts
storefront-ui_1   | [tsl] ERROR in /var/www/src/modules/payment-klarna/store/getters.ts(12,37)
storefront-ui_1   |       TS2345: Argument of type '{ name: string; fullPath: any; params: { parentSku: any; slug: any; childSku: any; }; }' is not assignable to parameter of type 'string | Route'.
storefront-ui_1   |   Type '{ name: string; fullPath: any; params: { parentSku: any; slug: any; childSku: any; }; }' is missing the following properties from type 'Route': path, hash, query, matched
storefront-ui_1   | Child html-webpack-plugin for "index.amp.html":
storefront-ui_1   |      1 asset
storefront-ui_1   |     Entrypoint undefined = index.amp.html
storefront-ui_1   | Child html-webpack-plugin for "index.basic.html":
storefront-ui_1   |      1 asset
storefront-ui_1   |     Entrypoint undefined = index.basic.html
storefront-ui_1   | Child html-webpack-plugin for "index.html":
storefront-ui_1   |      1 asset
storefront-ui_1   |     Entrypoint undefined = index.html
storefront-ui_1   | Child html-webpack-plugin for "index.minimal.html":
storefront-ui_1   |      1 asset
storefront-ui_1   |     Entrypoint undefined = index.minimal.html
storefront-ui_1   | error Command failed with exit code 2.
storefront-ui_1   | info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
vsf-payment-klarna_storefront-ui_1 exited with code 1

Any ideas?
PS: Some env info:

tried master@ea1bd082791e9ec6970b3a6fc9cd8977210f04fb
docker-compose version 1.22.0, build f46880fe
Docker version 18.06.1-ce, build e68fc7a
OS: Debian GNU/Linux 8.7 (jessie)

Hey, can you try this?
cd vsf-storefront
git pull origin master
git checkout ea5dcb4217f0c03123eaa898f62a43a5d1455945

It's probably because we've been updating this plugin from our other projects, sorry about that. Please send a PR if it's working

Thanks for the quick reply. Tried it, now .babelrc seems to be missing in the docker
...
Starting vsf-payment-klarna_storefront-ui_1 ... error
...
ERROR: for storefront-ui  Cannot start service storefront-ui: OCI runtime create failed:
  container_linux.go:348: starting container process caused "process_linux.go:402:
    container init caused \"rootfs_linux.go:58:
      mounting "/home/developer/workspace/vsf-payment-klarna/vue-storefront/.babelrc"
      to rootfs "/var/lib/docker/aufs/mnt/bcc5adc910af2801bb559be55ea5be6855cb8bcb8a11cacb8087502de21c5496"
      at "/var/lib/docker/aufs/mnt/bcc5adc910af2801bb559be55ea5be6855cb8bcb8a11cacb8087502de21c5496/var/www/.babelrc"
      caused "not a directory": unknown:

Are you trying to mount a directory onto a file (or vice-versa)? Check if the specified host path exists and is the expected type

ERROR: Encountered errors while bringing up the project.

@marcodisarno woops
In docker-compose.override.yml add - './vue-storefront-api/babel.config.js:/var/www/babel.config.js' under services.api.volumes
and under services.ui.volumes replace - './vue-storefront/.babelrc:/var/www/.babelrc' with - './vue-storefront/babel.config.js:/var/www/babel.config.js'

@benjick the good news is it builds and runs now, thanks for that.
There was a graphql dependency problem with storefront-api that I solved like these ppl on the VSF forums did.
./vue-storefront-api/package.json
"graphql": "^0.10.1" -> "^0.13.1"

Note: had to do it manually, though, because trying to solve this the clean way by updating submodule vue-storefront-api to 0ec68cb2 (where the issue is officially solved) resulted in:
Unexpected Identifier: import http from 'http'

And the bad news is that now I'm stuck with a permanent loadingSpinner on the KlarnaCheckout like the reporter of issue #3
So all of this did not help me integrating vsf-payment-klarna 😭
Still, if you give me permission I will push my (dirty) solution.

Had to apply the following tweaks to make it actually load:

the merchant_urls were missing in the order (getters/order)
added ?cartId={cartId} to API endpoint query (config.klarna.endpoint)

So I tried taking away the shipping options by setting showShippingOptions: false. Still resulted in the same problem:

Searching the web brought forward a [problem the WooCommerce (https://github.com/krokedil/klarna-checkout-for-woocommerce/issues/195) people have]:
They claim that the checkout won't work from a closed/local environment, because Klarna sends a callback to the store that needs to be responded to correctly.
Could that be true?

Hi, we're testing on public and local environments. The message you see you see is not related to KLarna callback.

@marcodisarno please look into https://ngrok.com/, it might help you

Will be fixed in #65

Hi, I had a problem with the building stage, because of babel-eslint. If you will be faced with, use that solution - https://github.com/babel/babel-eslint/issues/681#issuecomment-420663038

Hey. This is fixed now (#65) and this project is in much better shape. Sorry about the delay


Synapse: add Spark driver log retrieval

Is your feature request related to a problem? Please describe.
I'm creating some Python functions to run a Spark job in a Synapse Apache Spark pool and I want to retrieve the logs, but I don't find an option to do it.
Describe the solution you'd like
I would like to have a method in _models.SparkBatchJob that lets me retrieve driver's logs, being able to select whether it is stderr or stdout.
Describe alternatives you've considered
I've used the log_lines property of SparkBatchJob, but it only shows the last few lines of the Livy tab.

@angelpy Thanks for the feedback! Routing this to the right people.


Introduce metadata package

Refactoring Versions and ListCommand class

Introduce metadata module
that has Version, Versions and ListCommand class

Introduce custom Version class
A Version class override semantic_version.Version class
that accept qt versions and tools versions

@ddalcino I'd like to introduce new module metadata that has your improvements and your copyright.
Also I've done several refactoring on it.

Introduce Version class inherited from semantic_version.Version class that accept Qt versions and other tools versions, that has custom parser
Introduce Versions.__format__() method to help output of object values that renamed from pretty_print()
other improvements

Could you, @ddalcino , review for it?

Not sure if you meant to change the behavior of aqt list tools, but fyi it now prints them as a space-separated list on a single line, rather than one tool per line.

Thank you for it. I adjusted it now.


p2p: enable discovery after all local protocols were registered

related: https://github.com/spacemeshos/go-spacemesh/issues/4542
libp2p communicates the set of enabled protocols after completing secure handshake.
if some of the protocols were not registered before completing initial identify protocol round, it will result in errors
as in attached github issue.

bors merge


[Bug]: GenericContainer.waitingFor takes precedence over setWaitStrategy

Module
Core
Testcontainers version
1.19.7
Using the latest Testcontainers version?
Yes
Host OS
MacOs
Host Arch
ARM
Docker version
Docker version 20.10.14, build a224086

What happened?
We were previously using test-containers version 1.17.3.
When we switched to 1.19.7 some of our tests stopped working because the behaviour of GenericContainer.setWaitStrategy changed.
Our Code looked roughly like this:
postgreDBContainer = new PostgreSQLContainer<>(postgresImage).withExposedPorts(5432).withUsername("feature")
				.withPassword("xxx").withDatabaseName("xxx");
		postgreDBContainer.setWaitStrategy(
				new LogMessageWaitStrategy().withRegEx(".*database system is ready to accept connections.*")
						.withTimes(1).withStartupTimeout(Duration.of(60, SECONDS)));

After the upgrade, the waitstrategy provided is no longer used.
I wrote a Test for this that can be copy-pasted into GenericContainerTest.java
    @Test
    public void shouldUseLatestWaitStrategy(){
        try (GenericContainer<?> container = new GenericContainer<>("testcontainers/helloworld:1.1.0")) {

            WaitForExitedState strategy1 = new WaitForExitedState(state -> false);
            WaitForExitedState strategy2 = new WaitForExitedState(state -> true);

            container.waitingFor(strategy1);
            container.setWaitStrategy(strategy2);
            assertThat(container.getWaitStrategy()).isEqualTo(strategy2);
        }
    }

I think the problem is because .waitingFor changes the field in GenericContainer, but setWaitStrategy changes it in GenericContainer.containerDef.
The PostgreSQLContainer-Constructor sets this.waitStrategy. After that it can no longer be changed by calling setWaitStrategy.
Relevant log output
No response
Additional Information
No response

Workaround: use .waitingFor instead of ** setWaitStrategy**.

Seems to be caused by this PR: https://github.com/testcontainers/testcontainers-java/pull/7714


MIL

Library name:MIL
New version number:7
Other information that may be useful (release notes, etc...)

@MilliSamz, we don't have a port named MIL, could you confirm the port name?

@MilliSamz, could you provide us more information? such as the homepage of the library?

@MilliSamz, please reopen this issue and provide us more information if it still be a request for you.


Types!

The original plan was to move typings to DefinitelyTyped, but the current advice is to self-publish:

"There are two main ways you can publish your declaration files to npm:

bundling with your npm package, or
publishing to the @types organization on npm.
If you control the npm package you are publishing declarations for, then the first approach is favored. That way, your declarations and JavaScript always travel together."

This PR moves the typings out of the example project and into the Objection module proper.
To make that all work, the following changes were made:

TypeScript is added as a development dependency so example.ts can be compiled against the definition file
examples/express-ts has ../.. as a dependency to support local development and verification
The typings from examples/express-ts were updated (JsonSchema, for example, is part of the typings), and moved into ./typings/objection.
package.json has a new "types" reference to the Objection type definition file, and the "typings" directory is included in the files directive.
The test and test-travis scripts now call tsc after npm run build and before mocha. On my i3 linux box, this adds less than a second to the test suite (18.5s without tsc, 19s with tsc).

While I was verifying the example code, I fixed a couple defects in the prior typings, and added tests to examples.ts.

There was a bug in the typings for transactions, which expanded the ModelClass in the callback parameters. By forcing the ModelClass to always reference a T extends Model, I was able to change the transaction function signatures to a specific ModelClass, like Person. This wasn't possible before because the signature around Model.extend was too simplistic.

Model.extend didn't do what it should. Now the return value is union type of both the provided subclass as well as Model.

Some return types for QueryBuilder, including Model.$query() and .findById(), exposed the need for optionality. Examples were added to examples.ts.

update and patch methods return the number of rows updated. This wasn't reflected in the typings.

Coverage remained the same at 97.03% when pulling e81d7192b6888c27ec8f8ec0d8e0821528a48929 on mceachen:types into cf68c1beb6bd627457b8aff1fb7c46de8ef92e57 on Vincit:master.

Coverage remained the same at 97.03% when pulling 09c2ce4e5b3c1eba9f6683c50a1f94a19f25d535 on mceachen:types into cf68c1beb6bd627457b8aff1fb7c46de8ef92e57 on Vincit:master.

Coverage remained the same at 97.03% when pulling 83100332ac51cc2d726bc114b5e8fb81f786f019 on mceachen:types into cf68c1beb6bd627457b8aff1fb7c46de8ef92e57 on Vincit:master.

Coverage decreased (-0.02%) to 97.009% when pulling 12f178eaca4552996331e912b457f84fd9f9ac29 on mceachen:types into cf68c1beb6bd627457b8aff1fb7c46de8ef92e57 on Vincit:master.

Coverage remained the same at 97.03% when pulling 690892d60466727b0be7cc9e358f8dfb1c4383de on mceachen:types into cf68c1beb6bd627457b8aff1fb7c46de8ef92e57 on Vincit:master.

Coverage remained the same at 97.03% when pulling 690892d60466727b0be7cc9e358f8dfb1c4383de on mceachen:types into cf68c1beb6bd627457b8aff1fb7c46de8ef92e57 on Vincit:master.

Coverage remained the same at 97.03% when pulling 690892d60466727b0be7cc9e358f8dfb1c4383de on mceachen:types into cf68c1beb6bd627457b8aff1fb7c46de8ef92e57 on Vincit:master.

Coverage remained the same at 97.03% when pulling 582908a6cc228c037fb7097fbfa6d078039a2e25 on mceachen:types into cf68c1beb6bd627457b8aff1fb7c46de8ef92e57 on Vincit:master.

Coverage remained the same at 97.03% when pulling 988cb076a9021c3eb3643073005339df3a03e171 on mceachen:types into cf68c1beb6bd627457b8aff1fb7c46de8ef92e57 on Vincit:master.

Coverage remained the same at 97.03% when pulling 857f6fe4727f161df96ee3d0aa45e0620b1e0e74 on mceachen:types into cf68c1beb6bd627457b8aff1fb7c46de8ef92e57 on Vincit:master.

Coverage remained the same at 97.03% when pulling 61436dd336e63bfb8885fedde234b4d38a240558 on mceachen:types into cf68c1beb6bd627457b8aff1fb7c46de8ef92e57 on Vincit:master.

Looks good to me... I don't see any harm of running tsc when testing, since one can still do any kind javascript changes and test will always pass unless typings file is touched.

Coverage decreased (-0.02%) to 97.009% when pulling dd3a06c3ce10c4fd0bc3acdd4946b9bbe25e6df1 on mceachen:types into cf68c1beb6bd627457b8aff1fb7c46de8ef92e57 on Vincit:master.

Tests are failing with older node versions.

Fantastic job @mceachen by the way! Thank you so much for doing this. I'll be more than happy to merge this as soon as the travis tests are fixed.

I've replaced this PR with #267.

Coverage decreased (-0.04%) to 96.989% when pulling 2f1bee3f82f0261daeb6f4d961b44a890fa48ef1 on mceachen:types into cf68c1beb6bd627457b8aff1fb7c46de8ef92e57 on Vincit:master.

Good catch, I'll make the catch conditional.
On Dec 23, 2016 12:26 PM, "Sami Koskimäki"<EMAIL_ADDRESS>wrote:
@koskimas commented on this pull request.
In build.js
https://github.com/Vincit/objection.js/pull/255#pullrequestreview-14336895
:

@@ -55,4 +55,17 @@ for (var i = 0; i < src.length; ++i) {

fsExtra.ensureDirSync(path.dirname(dst));
fs.writeFileSync(dst, code);
+}
+
+try {

var child_process = require('child_process');
var process = require('process');

// TypeScript requires node > 4:
if (process.version > 'v4') {
// sanity-check the TypeScript definitions:
child_process.execSync(path.join(__dirname, "node_modules",
".bin", "tsc"), { cwd: __dirname });
}
+} catch (e) {
// node is too old, nevermind.
}

Doesn't the execSync throw an exception of tsc fails and it gets caught
here? It seems to me this never fails.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Vincit/objection.js/pull/255#pullrequestreview-14336895,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AANNOY6ibqsHyRYPjZ1HBE0Y-cGNIlOBks5rLC54gaJpZM4LBCoQ
.

Coverage decreased (-0.04%) to 96.989% when pulling 27368e2265189e8a83245aa73e153cb5d02829bf on mceachen:types into cf68c1beb6bd627457b8aff1fb7c46de8ef92e57 on Vincit:master.

Coverage decreased (-0.04%) to 96.989% when pulling 8e98b3ab011e0ce29df5acc88ca0bb763dd2fe7b on mceachen:types into cf68c1beb6bd627457b8aff1fb7c46de8ef92e57 on Vincit:master.

@koskimas if there's anything else I can update to make this PR more acceptable, holler.

@mceachen There appears to be something truly weird going on with this PR. The diff shows changes (my commits) that already exist in the master branch. Am I not getting something obvious here? Why is the diff like that?

Damn.. I just realized that I must have force pushed some stuff to the master and you have different copies of the commits 😬 I should really stop force pushing stuff to master...

Do you want me to make another PR from my diff?

Yes please! Either that or drop my commits from the PR branch.

OK, just made #272.


Training fails when using the left target padding "--left-pad-target True"

❓ Questions and Help
Before asking:

search the issues.
search the docs.

What is your question?
When I train the vanilla Transformer_base and _big models with setting the left-pad-target as True, the fairseq will report an error:
FloatingPointError: Minimum loss scale reached (0.0001). Your loss is probably exploding. Try lowering the learning rate, using gradient clipping or increasing the batch size.
Code
The training script of base model I used is:
python train.py databin/ende/wmt14/ -a transformer --share-all-embeddings --criterion label_smoothed_cross_entropy --label-smoothing 0.1 --lr 1e-3 --lr-scheduler inverse_sqrt --warmup-updates 4000 --optimizer adam --adam-betas '(0.9, 0.98)' --task translation --max-tokens 8192 --update-freq 2 --dropout 0.3 --encoder-layers 6 --encoder-embed-dim 512 --decoder-layers 6 --decoder-embed-dim 512 --fp16 --ddp-backend=no_c10d --max-source-positions 10000 --max-target-positions 10000 --max-update 100000 --seed 1 --save-dir checkpoint/ende/wmt14/ --left-pad-target True

What have you tried?
I also met this issue in big model training and large batch (458k tokens) training.
What's your environment?

fairseq Version (e.g., 1.0 or master): 0.9
PyTorch Version (e.g., 1.0) 1.4
OS (e.g., Linux): Linux
How you installed fairseq (pip, source): source
Build command you used (if compiling from source): pip install --editable $fairseq_path
Python version: 3.7

CC  @NonvolatileMemory

Got the same result.

@alphadl @NonvolatileMemory Have you managed to solve this issue?


[Feature Request] Hotkeyable

Add the ability to show it on a hotkey

Heya! This is already available through included macros.

Just drag the macros out to your macro bar and you'll be able to select a token and just press 1,2 or whatever your prefered setup.