[BUG] Transaction error--invalid key

Describe the Bug
After switching accounts, if I make a transfer immediately, I might sometimes encounter an "invalid key" error.
https://www.flowdiver.io/tx/0f44c2639eb843eafdc87a5e37ad7e277e71ec541c142986ca823af4d841575e
After a restart, the transaction will work normally again.
https://www.flowdiver.io/tx/d77b7641faa0c861d3c50a42d580f2d32c0320ce6e2dff58f28ca19dd6d840c3
Expected experience
The transaction executes normally without any errors.
Steps To Reproduce

Switch account
Send token to other accounts or the account itself
Restart app
Send token again

Environment
-ios 2.1.9(11)

This issue already fixed in ios prod version 2.1.11(5)


Get answers

Is it possible to return answers as well?

Anything on this ?

You can get answer of a question as the corresponding input sentence to this question. If you want more human like answer you can check out this paper: Dynamic Coattention Networks For Question Answering , and here is an implementation of it on GitHub. Hope it helps.

For answers you could use allenNLP


[SPARK-15803][PYSPARK] Support with statement syntax for SparkSession

What changes were proposed in this pull request?
Support with statement syntax for SparkSession in pyspark
How was this patch tested?
Manually verify it. Although I can add unit test for it, it would affect other unit test because the SparkContext is stopped after the with statement.

Test build #60125 has started for PR 13541 at commit 42749d3.

Test build #60125 has finished for PR 13541 at commit 42749d3.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60125/
Test FAILed.

Test build #60126 has started for PR 13541 at commit b35f122.

Test build #60126 has finished for PR 13541 at commit b35f122.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60126/
Test FAILed.

Test build #60270 has started for PR 13541 at commit 7cce183.

Test build #60270 has finished for PR 13541 at commit 7cce183.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60270/
Test FAILed.

It's weird that I can pass the python test in local, but fails on github jenkins. And the error message not clear to me. @davies  Could you help take a look at it ? Thanks. Here's the output from jenkins.
Running PySpark tests
========================================================================
Running PySpark tests. Output is in<EMAIL_ADDRESS>Will test against the following Python executables: ['python2.6', 'python3.4', 'pypy']
Will test the following Python modules: ['pyspark-sql', 'pyspark-mllib', 'pyspark-ml']
/home/jenkins/workspace/SparkPullRequestBuilder@2/python/pyspark/sql/context.py:457: DeprecationWarning: HiveContext is deprecated in Spark 2.0.0. Please use SparkSession.builder.enableHiveSupport().getOrCreate() instead.
  DeprecationWarning)

Running tests...
----------------------------------------------------------------------
...Using Spark's default log4j profile: org/apache/spark/log4j-defaults.properties
Setting default log level to "WARN".
To adjust logging level use sc.setLogLevel(newLevel).
Traceback (most recent call last):
  File "/usr/lib64/python2.6/runpy.py", line 122, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/usr/lib64/python2.6/runpy.py", line 34, in _run_code
    exec code in run_globals
  File<EMAIL_ADDRESS>line 1725, in <module>
    unittest.main(testRunner=xmlrunner.XMLTestRunner(output='target/test-reports'))
  File "/usr/lib/python2.6/site-packages/unittest2/main.py", line 88, in __init__
    self.runTests()
  File "/usr/lib/python2.6/site-packages/unittest2/main.py", line 237, in runTests
    self.result = testRunner.run(self.test)
  File "/usr/lib/python2.6/site-packages/xmlrunner/runner.py", line 59, in run
    test(result)
  File "/usr/lib/python2.6/site-packages/unittest2/suite.py", line 87, in __call__
    return self.run(*args, **kwds)
  File "/usr/lib/python2.6/site-packages/unittest2/suite.py", line 126, in run
    test(result)
  File "/usr/lib/python2.6/site-packages/unittest2/suite.py", line 87, in __call__
    return self.run(*args, **kwds)
  File "/usr/lib/python2.6/site-packages/unittest2/suite.py", line 118, in run
    self._handleClassSetUp(test, result)
  File "/usr/lib/python2.6/site-packages/unittest2/suite.py", line 173, in _handleClassSetUp
    self._addClassOrModuleLevelException(result, e, errorName)
  File "/usr/lib/python2.6/site-packages/unittest2/suite.py", line 215, in _addClassOrModuleLevelException
    result.addError(error, sys.exc_info())
  File "/usr/lib/python2.6/site-packages/xmlrunner/result.py", line 232, in addError
    self._save_output_data()
  File "/usr/lib/python2.6/site-packages/xmlrunner/result.py", line 189, in _save_output_data
    self._stdout_data = sys.stdout.getvalue()
AttributeError: 'file' object has no attribute 'getvalue'

Had test failures in pyspark.sql.tests with python2.6; see logs.
[error] running /home/jenkins/workspace/SparkPullRequestBuilder@2/python/run-tests --modules=pyspark-sql,pyspark-mllib,pyspark-ml --parallelism=4 ; received return code 255
Attempting to post to Github...
 > Post successful.
Build step 'Execute shell' marked build as failure

jenkins retest this please

Test build #60706 has started for PR 13541 at commit 7cce183.

Test build #60706 has finished for PR 13541 at commit 7cce183.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60706/
Test PASSed.

LGTM

Merging this into master and 2.0, thanks!


Code example several problems

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 74c4b4cd-4993-e079-9128-6f1259695a2e
Version Independent ID: 04223a19-0eba-53b4-a069-d58b7a68a88f
Content: Synonyms C# example - Azure Cognitive Search
Content Source: articles/search/search-synonyms-tutorial-sdk.md
Service: cognitive-search
GitHub Login: @HeidiSteen
Microsoft Alias: heidist

@angel-menendez,  Thanks for leveraging Azure docs feedback channel to raise this question.
Could you please share more details about the issue you encountered with the doc/sample to better assist you.

@angel-menendez, Apologies for any frustrating experience! Just following-up, could you please share more details about the issue?

@angel-menendez, Since we have not heard back from you we will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply and we will gladly continue the discussion.


Make function output from locals autoescaped, keep macros safe

Continuing work from @andrewrk from gh-494
Slightly alternative approach, albeit, potentially crazy... Uses a String object to mark the actual string itself as safe. When the escape filter hits a String object, it checks if the input is safe. If it is, just returns the string value and continues on.

Any progress with this? I think this problems is currently the biggest reason why not to choose Swig.


Permissions to delete a pipeline

In the documentation for deleting a pipeline it says
You can delete a pipeline if you're an administrator of the Buildkite organization or in a team that has Full Access to the pipeline. but I've created a pipeline, I'm a member of a team with Full Access to it and in the Pipeline -> Settings -> Pipeline Management section there's only the option to archive it (not to delete it).

Hi @fduran ,
This feature should work and my own testing has verified that I was able to delete a pipeline (via the Delete Pipeline button) as a user with Full Access to the pipeline or as an administrator of the Buildkite organisation.
Is it possible that you were running builds on this pipeline at the time you were attempting to delete it?
If you're continuing to have issues deleting this pipeline, please email<EMAIL_ADDRESS>with further details.

I was able to delete a pipeline (via the Delete Pipeline button) there's no "Delete Pipeline" button for me (only "Archive"), also no builds have been run on this pipeline. I'll email support.


Remove Unused Import Breaking Android API 23+

Importing org.apache.http.cookie.Cookie is breaking builds targeting Android API 23+ since org.apache.http was removed. Fortunately, this import is unused, so it's a simple fix.

Thanks for your contribution.


Accept absolute directories

Closes #52.

Thank you @theofidry

Arf sorry i forgot to submit my review...


Update tabulars_controller.rb

page_count CAN'T be zero in Pagy documentation says default value is 1  ! and also @page .

I think we should get the merged in. Without this change, the tabular page will yield a 500 error if there are no results for the given search query.


Import error on colab with version 1.5.1

I get the following error when simply installing and importing dataclass_array on a colab.
!pip install dataclass-array

import dataclass_array as dca

raises:
[/usr/local/lib/python3.10/dist-packages/dataclass_array/array_dataclass.py](https://localhost:8080/#) in DataclassArray()
    582   # ====== Internal ======
    583
--> 584   @epy.cached_property
    585   def _all_fields_empty(self) -> bool:
    586     """Returns True if the `dataclass_array` is invalid."""

AttributeError: module 'etils.epy' has no attribute 'cached_property'

Not sure what I am missing. Any help would be great. Thanks in advance!

Thank for reporting. Please upgrade to 1.5.2 which fix this issue already.

Oh, I think the issue is that 1.5.2 drop Python 3.10 support, while Colab is still running on 3.10.

Can you try to install dataclass_array from Git directly ?
Looking at the 1.5.2 diff, I think it should still work on 3.10: https://github.com/google-research/dataclass_array/compare/v1.5.1...v1.5.2
If this work, then you can send a cl to change then .toml back to 3.10


UPTIMEKUMA and HEALTHCHECKS should take newline-separated multiple URLs?

Not sure if this is useful, but it's definitely technically possible.

Not planned.


Add option to reduce build times when using ThinLTO and ld64

Internal configurations targeting Darwin employ ThinLTO to
improve compiler performance, however using it on all executable
causes build time to increase with no matching benefit.
To reduce build times in such configurations, we allow some
ancillary targets to opt out of LLVM IR optimizations when linking
ThinLTO with ld64 (e.g. tools used for bootstrapping or debugging the
Swift compiler) -- this behaviour is opt in through a new flag
--swift-tools-ld64-lto-codegen-only-for-supporting-targets.
Addresses rdar://76702687

@swift-ci please smoke test

preset=buildbot_incremental,tools=RA,stdlib=RD,smoketest=macosx,flto
@swift-ci Please test with preset macOS Platform

@swift-ci please smoke test

preset=buildbot_incremental,tools=RA,stdlib=RD,smoketest=macosx,flto
@swift-ci Please test with preset macOS Platform

preset=buildbot_incremental,tools=RA,stdlib=RD,smoketest=macosx,flto
@swift-ci Please test with preset macOS Platform

preset=buildbot_incremental,tools=RA,stdlib=RD,smoketest=macosx,flto
@swift-ci Please test with preset macOS Platform

@swift-ci please smoke test

@swift-ci please python lint

The build for the preset buildbot_incremental,tools=RA,stdlib=RD,smoketest=macosx,flto seems to have issues unrelated to this PR -- Jenkins seems to lose connection to the node while building llvm, probably due to the load caused by building LTO


Feature 1020 set_attrs

After merging the latest version of develop in feature_1020_set_attrs, I ran a regression test in kiowa:/d1/projects/MET/MET_pull_requests/met-9.1_beta2/feature_1020/regression
The only differences should new set_attr output files generated by Grid-Stat.
Please read the last comment on #1020 which explains the change I had to make, replacing set_attr_... bareword entries instead of grouping them together into a set_attrs dictionary.

Hey George, I’m not surprised by the long name behavior you describe. I think I realized that I wasn’t actually checking for that when setting up the long name in Grid-Star matched pairs file. Here’s the issue... each variable can result in multiple output fields in that file. The code constructs the long name to differentiate between them... and it wasn’t immediately obvious to me how to use the user-defined long name in that context... but I could try.

OK George, I update Grid-Stat to include the user-specified long_name string in the NetCDF matched pairs output file from Grid-Stat.

OK, the changes look good to me as far as I can tell. I will let you merge the changes so you can control the differences that will come up from the tests.

Will do. Thanks George.
John
On Wed, Jul 8, 2020 at 1:23 PM George McCabe<EMAIL_ADDRESS>wrote:

OK, the changes look good to me as far as I can tell. I will let you merge
the changes so you can control the differences that will come up from the
tests.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/NCAR/MET/pull/1406#issuecomment-655651860, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AFA4HKAR34Z4KHQASXLUNRTR2STQXANCNFSM4OQIAHWQ
.


Feature/meditor 829 codepipeline

This PR adds two features related to our AWS Deployment Pipeline:

adds a bash script to get the root package.json's version for use in CodeBuild
adds ARG to the two Dockerfiles that didn't have it; we pull images from ECR when building with Docker to prevent a 429 response

This is awesome, so much better than running shell scripts locally!


Greatly expand the documentation around how $ref works

It is really really really really really super opaque, frustrating and annoying to figure out how $ref is supposed to work.
I think I'm too close to my emotions to write clearly and calmly about this, but I started a gist with some of my research notes.  I'd eventually like to incorporate those notes in a cleaned up form into the documentation or README.
Is there an appetite to 👍 on a PR which simply attempts to see if the given $ref key matches any records in ETS before all the canonicalization happens?

@mrallen1 any feedback to report? thanks

I went a bit ahead of the game and merged that branch. If you find smth erroneous, I'll reopen.

Thanks again. I have a new project I'm working on for $DAYJOB so I'll use it there for certain. Any chance you'd tag a new release? ^_^


Automator: update proxy@master in istio/istio@master

Generated by Automator - 2023-11-22T01:58:14+00:00

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
5ceefef2263f5376c2587658450ec28d984800f4
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-ambient


ql undefined in sendMsg(get, QueryForm)

server.js:568 : when receiving a Message an error is raised saying ql is undefined.
Reason is I think: v[ql] should be v["ql"].

I guess you are refering to "set" - and you are right. I pushed a fix to gerrit - please review.


App view never loads up

Really excited about Natal! I'm wondering if perhaps the versioning is out of sync, because I see the name of my app flash briefly, then briefly the instructions from index.io.js, and then a white screen. Just opening this up for now in case there might be an obvious cause, I'll keep debugging in the meantime.

Do you see any runtime errors from Xcode?
Does the compiled ClojureScript look ok in target/out?
Does starting the Ambly REPL with ./start find the simulator device?
You should see that React Native setup screen briefly, followed by a white screen that says "Welcome to [YourAppName]".

Try updating to Natal 0.1.0 (npm up -g natal) and starting a new app (natal init YourAppName).

Any luck with the latest version?


JFoenix tabPane not displayed

Hi everyone,
I'm dealing with a small problem here!
With the last scene Builder, importing the JFoenix library, my JFX Tab Pane are not displayed, i can't even put some other component into them.
Do i need to do someting specific or maybe reimport the library?
Thank you.

Hi, make sure you are using compatible version of JFoenix / scene builder.
there are different jars for Java 8 / 9
Regards,

Product Version
JavaFX Scene Builder 9.0.1
Build Information
Version 9.0.1
Date: 2017-10-17
Java Version: 9+181, Oracle Corporation
and I imported both jar for java 8 and jar for java 9. Java 9 file don't show any files when importing, java 8 import 41 elements. + I've tested it on my PC and on my Mac, same problem. I even tried to import directly from the "search Jar library" from Scene Builder.
Was expecting a bit more than just this.


TFLite: Stable Delegate: how to use stable_delegate with python API

I am using tflite 2.16.1
My target is an aarch64 linux system
I have a tflite stable_delegate .so shared library, and a stable_delegate settings json file called 'stable_delegate_settings.json which I can execute using TFLite benchmark model using the commands
./benchmark_model --graph=model.tflite --stable_delegate_settings_file=stable_delegate_settings.json
this executes the model using stable delegate through the json stable_delegate settings file.
I want to know how can I use this stable_delegate_settings.json file to execute the model via stable delegate using python API.
I am not sure whats the format to execute stable delegate using tflite.load_delegate, since it searches for the .so shared library, not the json settings file.
thanks

Hi @sushreebarsa
any updates on this?
thanks

@suyash-narain
tflite.load_delegate directly searches for the shared library (.so file) and doesn't handle settings files like stable_delegate_settings.json. There's a workaround to achieve your goal using the Python API.
Could you try to Parse the stable_delegate_settings.json file;
Firstly Import the json library:
import json

then Open the stable_delegate_settings.json file:
with open('stable_delegate_settings.json', 'r') as f:
  settings = json.load(f)

Thank you!

Hi @sushreebarsa
thank you for your reply.
So do I need to specify this 'settings' somewhere in my python code, or will the delegate automatically get loaded and execute the tflite model?
since interpreter api loads external shared delegate library .so files using tfltie experimental load_delegate function...
so does it need to be provided this settings variable with loaded json contents?
thanks

@suyash-narain If you're using a custom delegate library with its own settings, follow the TFLite delegate loading documentation to incorporate it. There isn't a well-established workaround to directly use the stable delegate with the Python API for TFLite.
Thank you!

@suyash-narain Have you managed to use Python API to run the stable delegate?

@sushreebarsa How am I supposed to use the stable delegate using Python API if my .json file looks like this:
{
	"stable_delegate_loader_settings": {
		"delegate_path": "/usr/lib/libneuron_stable_delegate.so"
	},
	"neuron_delegate_settings": {
		"execution_priority": NEURON_PRIORITY_HIGH,
		"optimization_hint": NEURON_OPTIMIZATION_NONE,
		"execution_preference": NEURON_FAST_SINGLE_ANSWER,
		"allow_fp16": true,
		"use_ahwb": true
	}
}

Note that libneuron_stable_delegate.so does not contain create and delete sybmols.

Is there any way to make it work? It's just for evaluation purposes so not so well-established method is fine as well.


Dropdown don't cross over the navbar in dashboard page

Description

Gitea Version
latest
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
No response
How are you running Gitea?
build
Database
None

What do you mean by "cross over"? full width?

Correct:

Maybe "cover" is correct?

I think I get your point now. It's like caused by misuse of Fomantic UI layout.

Fixed


Composer dependencies are not correct

When I try to require the package, I am getting this message;
Using version ^9.14 for m4tthumphrey/php-gitlab-api
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Installation request for m4tthumphrey/php-gitlab-api ^9.14 -> satisfiable by m4tthumphrey/php-gitlab-api[9.14.0].
    - m4tthumphrey/php-gitlab-api 9.14.0 requires php-http/client-implementation ^1.0 -> no matching package found.

Potential causes:
 - A typo in the package name
 - The package is not available in a stable-enough version according to your minimum-stability setting
   see <https://getcomposer.org/doc/04-schema.md#minimum-stability> for more details.
 - It's a private package and you forgot to add a custom repository to find it

Read <https://getcomposer.org/doc/articles/troubleshooting.md> for further common problems.

Installation failed, reverting ./composer.json to its original content.

Seems the php-http/client-implementation package is no longer existing. Can you fix this?

Did not read the README well.. when using this require statement, it works fine
composer require m4tthumphrey/php-gitlab-api php-http/guzzle6-adapter:^1.0

But it shouldn't be necessary of course ;-)


HBASE-28010: Prevent connection attribute corruption

In ServerRpcConnection.processOneRpc, it calls processConnectionHeader and then immediately calls callCleanupIfNeeded. The parsing of the ByteBuff into the ConnectionHeader does not copy the bytes. We keep a reference to ConnectionHeader for later use, but since the underlying ByteBuff gets released in callCleanupIfNeeded, later requests can override the memory locations that the ConnectionHeader points at.
In this PR we modified our test to ensure that it failed in the current state on master — enabling the byte buffer resevoir and sending a large enough put caused the ConnectionHeader attributes to disappear. We fixed this by copying the parsed ConnectionHeader's attributes to their own Map, and then making this Map accessible on the RpcCall.
@bbeaudreault

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 24s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
2m 37s
master passed

+1 :green_heart:
compile
2m 24s
master passed

+1 :green_heart:
checkstyle
0m 32s
master passed

+1 :green_heart:
spotless
0m 39s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 23s
master passed

_ Patch Compile Tests _

-1 :x:
mvninstall
1m 10s
root in the patch failed.

-1 :x:
compile
0m 13s
hbase-server in the patch failed.

-0 :warning:
javac
0m 13s
hbase-server in the patch failed.

-0 :warning:
checkstyle
0m 32s
hbase-server: The patch generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

-1 :x:
hadoopcheck
1m 15s
The patch causes 10 errors with Hadoop v3.2.4.

-1 :x:
hadoopcheck
2m 31s
The patch causes 10 errors with Hadoop v3.3.5.

+1 :green_heart:
spotless
0m 38s
patch has no errors when running spotless:check.

-1 :x:
spotbugs
0m 17s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
asflicense
0m  6s
The patch does not generate ASF License warnings.

14m 35s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5366/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5366

JIRA Issue
HBASE-28010

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 16355f6386d5 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / d309e99f0a

Default Java
Eclipse Adoptium-11.0.17+8

mvninstall
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5366/3/artifact/yetus-general-check/output/patch-mvninstall-root.txt

compile
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5366/3/artifact/yetus-general-check/output/patch-compile-hbase-server.txt

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5366/3/artifact/yetus-general-check/output/patch-compile-hbase-server.txt

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5366/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

hadoopcheck
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5366/3/artifact/yetus-general-check/output/patch-javac-3.2.4.txt

hadoopcheck
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5366/3/artifact/yetus-general-check/output/patch-javac-3.3.5.txt

spotbugs
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5366/3/artifact/yetus-general-check/output/patch-spotbugs-hbase-server.txt

Max. process+thread count
79 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5366/3/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 11s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
2m 36s
master passed

+1 :green_heart:
compile
0m 47s
master passed

+1 :green_heart:
shadedjars
4m 42s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 25s
master passed

_ Patch Compile Tests _

-1 :x:
mvninstall
1m 20s
root in the patch failed.

-1 :x:
compile
0m 16s
hbase-server in the patch failed.

-0 :warning:
javac
0m 16s
hbase-server in the patch failed.

-1 :x:
shadedjars
3m 10s
patch has 10 errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 26s
the patch passed

_ Other Tests _

-1 :x:
unit
0m 17s
hbase-server in the patch failed.

14m 50s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5366/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5366

JIRA Issue
HBASE-28010

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux f9c87aa1e136 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / d309e99f0a

Default Java
Eclipse Adoptium-11.0.17+8

mvninstall
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5366/3/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt

compile
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5366/3/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5366/3/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt

shadedjars
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5366/3/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5366/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5366/3/testReport/

Max. process+thread count
76 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5366/3/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@rmdmattingly Looks like the Maps imports are wrong, so the build is failing.

Yep I’ve pushed a fix already

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 25s
Docker mode activated.

Looking better but now there are some unused imports in RpcCall, per checkstyle

🤦I can never keep track of what spotless cleans up and what it leaves behind. Fixing now

Ah ok, it's these imports that are only servicing the javadoc — I can remove those to appease checkstyle, but IMO it makes the javadoc marginally worse. Is that fine?

Interesting. I feel like it's a bug due to the splitting of the @see statement across 2 lines. I notice that it doesn't ding us for Configuration which is also only used in that javadoc. Let's leave it removed for now, as I'm not sure I want to dig into the checkstyle bug just for the sake of the javadoc.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 12s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
2m 37s
master passed

+1 :green_heart:
compile
0m 48s
master passed

+1 :green_heart:
shadedjars
4m 36s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 25s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 38s
the patch passed

+1 :green_heart:
compile
0m 48s
the patch passed

+1 :green_heart:
javac
0m 48s
the patch passed

+1 :green_heart:
shadedjars
4m 43s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 25s
the patch passed

_ Other Tests _

-1 :x:
unit
219m  3s
hbase-server in the patch failed.

240m 45s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5366/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5366

JIRA Issue
HBASE-28010

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 34449a33946c 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 94ed6add06

Default Java
Eclipse Adoptium-11.0.17+8

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5366/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5366/5/testReport/

Max. process+thread count
4977 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5366/5/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 10s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
2m 14s
master passed

+1 :green_heart:
compile
0m 40s
master passed

+1 :green_heart:
shadedjars
4m 32s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 23s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 14s
the patch passed

+1 :green_heart:
compile
0m 39s
the patch passed

+1 :green_heart:
javac
0m 39s
the patch passed

+1 :green_heart:
shadedjars
4m 30s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 24s
the patch passed

_ Other Tests _

-1 :x:
unit
223m 55s
hbase-server in the patch failed.

244m 11s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5366/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5366

JIRA Issue
HBASE-28010

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 0e3056800972 5.4.0-153-generic #170-Ubuntu SMP Fri Jun 16 13:43:31 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 94ed6add06

Default Java
Temurin-1.8.0_352-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5366/5/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5366/5/testReport/

Max. process+thread count
4363 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5366/5/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Test failures don't seem relevant:
[ERROR] Errors:
[ERROR] org.apache.hadoop.hbase.TestZooKeeper.null
[ERROR]   Run 1: TestZooKeeper.after:110->Object.wait:-2 Â» TestTimedOut test timed out after 780 seconds
[ERROR]   Run 2: TestZooKeeper Â»  Appears to be stuck in thread MiniHBaseClusterRegionServer-EventLoopGroup-5-2


Added Ametek 7270 Lockin

Hi,
Changelist:

New instrument driver for the Ametek 7270 DSP Lockin amplifier.
New validator function called modular_range, useful for inputting degrees.

Related new validator called modular_range_bidirectional which accounts for possible negative values, i.e. -1 mod 365 is usually 364 but you may want -1returned instead.

Added validators on all of the Signal Recovery DSP 7265 Lockin amplifier's properties.

Thanks @jmittelstaedt!


How to add a fragment to the form using core components?

When we create a form using core page component (core/fd/components/page/v1/page), it's not possible to add a fragment to the form using core components. We can only add a fragment using OOTB Panel. Could you please tell if it is possible to add a fragment to the form using only core components?
We use AEM 6.5.18, adobe-aem-forms-addon-6.5.18, aem-service-pkg-6.5.18, core.forms.components 1.1.24

This support is added in AEM 6.5.19, core.forms.components 1.1.32


mobile tools: add missing .bazelproject files

Commit Message: Add missing .bazelproject files. This fixes a dev workflow which allows us to run example/test applications from within Android Studio IDE. The addition of the .bazelrpoject was most probably missed in https://github.com/envoyproxy/envoy/pull/24104 as dot files are ignored by default in Envoy repo.
Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

/merge


Controllers mo --> slight change to updateTrainer && insertCurric

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] All new and existing tests passed.

updated without branching/pull request


Web site certificate seems to have expired

The site itself seems to be working fine, however upon loading the website I received a browser-specific warning which said: “This website may be impersonating  “Www.eamon-remastered.com.” I looked into the  details button which showed up after the warning, it looks like everything on my end is ok.

Thanks for letting me know. I renewed the cert and everything should be working again.


Feature/ddw 3 Launch mantis as part of startup

This PR introduces feature for starting and stopping Mantis client from Daedalus main process.
Currently it is implemented so that it can work with local Mantis client in development mode.
To start it use the following command: API=etc MANTIS_PATH={path-to-mantis} npm run dev

Sorry @darko-mijic - title fixed now ;)


Script serialization/deserialization in serde non-human-readable format

close https://github.com/rust-bitcoin/rust-bitcoin/issues/595
At the moment Script for serde non-human-readable format is serialized as bytes of the hex format, doubling the space required
This fix by serializing in bytes if the encoding format is non-human-readable (such as using bincode or serde_cbor)

I expect this is an API breaking change, since data serialized with previous version in binary format will not be deserializable after this PR by the same code deserializing it before

Needs rebase. concept ACK

rebased

Again needs rebase :(

rebased

Merging since all requirements are met and we was not merging it only to wait for a major version


Can we get this request off the startup path, pretty pretty please

Opening a folder when connected to VPN:
(Dev Tools doesn't want to save the profile)
syncWithGallery
I get it, it's a node/electron weirdo bug or something, but pretty pretty please, TPromise.timeout(5000)
btw @bpasero : I also think we do such a request in some other important process (main?) because it also takes 1-2s since I press the Open Folder until the window actually goes blank and loads something...

To my knowledge there is no HTTP request happening from when you picked a folder in the dialog until opening that folder.

Looks like https://github.com/Microsoft/vscode/issues/12087 is related/duplicate.

This is terrible, we might just move it to the shared process... thus not blocking editing... Although that will just make the shared process slow.
Closing as duplicate of #12087.


[nodejs]: require() path in example isn't correct

Related to #1599
The problem is in src/v1beta1/firestore_client.js#L407 and appears in a bunch of other places in the file:
- * var firestore = require('firestore.v1beta1');
+ * var Firestore = require('@google-cloud/firestore');

/cc @landrito @lukesneeringer

Looks like there is a problem in the gapic yaml.
https://github.com/googleapis/googleapis/blob/master/google/firestore/v1beta1/firestore_gapic.yaml#L18
nodejs:
  package_name: firestore.v1beta1

Should be changed to:
nodejs:
  package_name: firestore.v1beta1
  domain_layer_location: google-cloud

how about
nodejs:
  package_name: firestore
  domain_layer_location: google-cloud

?

The .v1beta1 is correct. in that configuration.

Closing this. I made a change upstream that should propogate this change to googleapis/googleapis.


[Feature] Allow user to select which sites Alby has access too using the already provided mechanism for that

Feature description
Allow Alby to only read data on sites when clicked on, not on all sites.
that is, right clicking on the extension -> this can read and change site data -> when you click on the extension
Currently Alby only works when "on all sites" is selected (else you get  unhelpful generic "network error" messages) and I've found some sites don't play well with Alby and why  would I want that anyway?
Describe the solution
I want to be to select which sites Alby has access too and have Alby still work.
Describe alternatives
Not using Alby
Additional context
Using Brave Browser
Are you working on this?
No

thanks for reporting. Which websites don't play nice with Alby? would help to debug this.
The option "when you click on the extension" should work actually (at least I often try this to make sure this option is possible) The only thing is you must reload the page after you initially allowed Alby (after you clicked on the extension) otherwise the website connection can not be established.

and which wallet/account do you have connected in Alby?

Do you still see this error?


Works on some servers, but not others

Just quickly, I have noticed that this fantastic form works on my testing server for the clients I use it for, but when I send the files to their live servers, it's a bit of a 50/50 whether the form actually works.
Is there some kind of server setting dependencies we should be looking out for?
Thank for a great bit of code!
// Rob

@masey9
Webhosts increasingly have their systems set to require the "-f" flag.
So instead of:
mail($emailTo, "=?utf-8?B?".base64_encode($subject)."?=", $body, $headers);
change to:
mail($emailTo, "=?utf-8?B?".base64_encode($subject)."?=", $body, $headers, "-fvalidemailfromaddress@mydomain.com");
Note there is no space between the f and the email address.
<EMAIL_ADDRESS>must (usually) be a valid email hosted on the domain from which the email is being sent.
-f is an additional parameter used by sendmail (the program many servers use to send mail). Basically it's the "from" address. So why set the from address twice?
According to the PHP manual -f sets the X-envelope sender (who is sending the mail), the address specified by -f is a "trusted user" and will be checked against "/etc/mail/trusted-users".
This helps to mitigate against the mail function being abused. It helps to validate that the mail being sent is really from your domain and not simply using a mail function on your domain (in practice the "real" from address will be what is specified by -f as opposed to what you specify in the $from field.)

Thanks for that thorough explanation. I gave it a go, still with no luck.
Could it be that PHPINFO shows that the hosting company have the PHP setting:
mail.add_x_header
...set to "Off"? It's all I can find that would account for why the emails aren't coming through.

About mail.add_x_header: http://php.net/manual/en/mail.configuration.php
Do you by chance have access to the mail log function to find out what might be happening?

Sadly, no. All they did was place this file on the server and basically tell me to work it out.
http://www.kozplumbing.com.au/test_email.php
When you load the page, I do, in fact receive an email so whatever they are doing in the code is obviously working. I'm just not sure how to apply that to your code...?
And if it helps, the test form of yours I am running is here:
http://kozplumbing.com.au/contact/mail-test.php

Make sure that sendmail is working and you should be OK. I had similar issues.

Same as me when I use hostinger It doesn't work

Refatored code. In my tests it worked perfectly in Hotmail, Yahoo, Gmail.


Issue with SoftDeletes not firing delete events

Hi there,
So, in order to use and store a specific date in the deleted_at column, you're not using a delete on the record, which would natively put the current date and time, but a save.
This has a downfall as model events deleting and deleted won't be fired by Laravel.
I changed the way you handle a delete in SoftDeletesModels to run a true delete followed by a save:
    /**
     * @param Model $record
     */
    protected function saveOrRestore(Model $record)
    {
        if ($this->willRestore($record)) {
            $record->restore();
        } else {
            if ($this->willDelete($record)) {
                $key = $this->getSoftDeleteKey($record);
                // save the original date so we can put it back later on
                $deletedAt = $record{$key};
                // delete on the record so that deleting and deleted events get fired
                $record->delete();
                // apply the original soft deleting date back before saving
                $record{$key} = $deletedAt;
            }
            $record->save();
        }
    }

    // ...

    /**
     * @param Model $record
     * @return bool
     */
    protected function willDelete(Model $record)
    {
        if (!$key = $this->getSoftDeleteKey($record)) {
            return false;
        }

        return null === $record->getOriginal($key) && $record->trashed();
    }

But this has other issues:

first we make two calls to the db (delete then save)
second let's say I want to delete a record while not using an adapter, I'm stuck with the current date and time decided by Laravel, same if I want to implement or use a soft delete cascade solution

So I came to the conclusion we're left with 2 solutions to this problem:

accept only true as an option to the deleted-at field and let the framework always put in the current date and time (far from ideal)
overwrite the runSoftDelete method in the Laravel SoftDeletes trait to use the value in the deleted_at column if provided

This last solution is the cleanest and would be my favorite, I'm just not sure how or where to implement it best. What are your thoughts on all this?

Thanks for raising this.
Re this:

second let's say I want to delete a record while not using an adapter, I'm stuck with the current date and time decided by Laravel, same if I want to implement or use a soft delete cascade solution

This is not a problem, because if the model is not deleted via the API it is appropriate that the server (i.e. Laravel) chooses the date/time.
For your two solutions...

accept only true as an option to the deleted-at field and let the framework always put in the current date and time (far from ideal)

This is breaking, plus I don't like that it forces an application-specific choice on the developer... each API should be able to choose how to implement this in their resource, rather than forcing a decision.

overwrite the runSoftDelete method in the Laravel SoftDeletes trait to use the value in the deleted_at column if provided

This isn't a viable solution, because it's not really for this package to override how Laravel works.
Note sure about this, but perhaps the solution is to accept that we need to run both delete() and save()... i.e. not work around the fact that Laravel gives us no choice but to do that. Then if the client has used a date for the delete value, we can fill that after the delete but before the save... i.e. overwrite the server deleted_at date with the date that is provided by the client.

If I’m not mistaken, your proposed solution is precisely what I changed in your SoftDeletesModels. I think it’s the best approach, i don’t see another one.
Overwriting Laravel’s own SoftDelete to handle cascade for exemple should depend on each application implementation and not your library, I agree with you on that.
If what I did in the code above suits you I can make a PR. We could rename the method saveOrRestoreOrDelete to be more precise on what it does.

Ah yes, it is the same as what you've done! So that's good we're both thinking along the same lines!
A PR would be great. I think leave the name of the method as saveOrRestore() because otherwise it will be a breaking change as people could have overloaded the method.

@JeanLucEsser no need for a PR, I've just pushed the fix for this.

Thank you, I’m so sorry i was about to do it but I had to deal with an urgent matter before. Glad you found the time. You rock.

@JeanLucEsser no problem at all, just had a spare moment and as we had effectively written the solution above it was pretty easy to implement. Not sure when I'll tag the next release but should be in the next week or two. Feel free to tie to the develop branch until I do.

@lindyhopchris I have a small tweak to this update that allows the deleting observer to return false and abort the current delete operation. This more closely aligns with native Laravel.
       if ($this->willSoftDelete($model)) {
            $column = $model->getDeletedAtColumn();
            // save the original date so we can put it back later on.
            $deletedAt = $model->{$column};
            // delete the record so that deleting and deleted events get fired.
  +       $response = $model->delete();  <--- capture the response
  +       if ($response !== false){   <-- if everything worked out then update the $deletedAt
                // apply the original date back before saving, so that we keep date provided by the client.
                $model->{$column} = $deletedAt;
  +        }
        }

another solution is to define a flag in the config to enable using the passed datetime for the deleted_at on soft deletes or native laravel now().
I have a feature waiting on this change so any feedback is welcome.
Thanks

@freestyledork can you confirm whether you're proposing this in this repo - i.e. the legacy version of our JSON:API package? Or are you using the current package i.e. laravel-json-api/laravel?
Either way I'd take a PR adding this, ensuring the PR is created in the right repo. FYI if you're using the current package the PR will need to be in the laravel-json-api/eloquent repo.

@lindyhopchris I hesitated to make a new issue in the eloquent repo or this one. Since the code mentioned this issue directly I decided to continue the thread. I am currently using version 2 of the JSON:API package. I will make the pull request for the laravel-json-api/eloquent repo today or tomorrow.
Thanks!


Suggestions for feature improvements

Please confirm the following

☑ I've checked the current issues for duplicate issues.
☑ I've requested a single (only one) feature/change in this issue. It complies with the One Request Per GitHub Issue (ORPGI) rule.
☑ My issue is well-defined and aligns with the goal of the project.

Description
First of all, thank you so much for this wonderful app. It's excellent.
So there are two suggestions from my side

Can we specify a particular time for for Auto Periodic backup
For example 12AM-6AM
Can we choose a particular folder for backing up rather than all images in the phone?
This way I can ignore all the memes, screenshots etc which I don't find useful by backing up

Can we specify a particular time for for Auto Periodic backup
For example 12AM-6AM

It will be bit of a hassle to implement. I don't think it's super important right now, but definitely a good to have.

Can we choose a particular folder for backing up rather than all images in the phone?
This way I can ignore all the memes, screenshots etc which I don't find useful by backing up

This is very helpful. I like it.


Add support for css grid

In response to issue #523 and #44 I have added display grid and display inline grid snippets

Please remove package-lock.json from PR and I’ll merge it

I removed package.json however I did a git pull instead of a git rebase. Is that okay?
Sent with ProtonMail Secure Email.
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Thursday, August 8, 2019 2:54 AM, Sergey Chikuyonok<EMAIL_ADDRESS>wrote:

Please remove package-lock.json from PR and I’ll merge it
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

There’s still package-lock.json in PR. You can close this one and create new PR with snippets only


Proper syntax checking params.adapter

Also change the seq_a position in Trimgalore to be with near the clipping parameters.
Thanks to @MaxUlysse for the help.
Can you test if it works with and without specifying --adapter in the Nextflow command?

Thank you, @gdevailly !
It was ultimately so simple. I just tested and it works perfectly.


One plus 5t not working OTG

It's not working with one plus 5t stock ROM otg enabled.

Have you enabled OTG Storage in Settings?

Yes I have. Still no luck.

Just tried it myself, and everything's working correctly from my OnePlus 5T

Strange. It has started working, once  I connected USB OTG adapter to my phone and cable to switch. Now working perfectly. Thanks.


fix: add dynamic flag max-allowed-trial-instances

Description
Add dynamic flag max-allowed-trial-instances and set default value one.
https://issues.redhat.com/browse/MGDSTRM-8159

Verification Steps
set max-allowed-trial-instances flag value and will bale to create kafka trial instances based on flag value.
If you will try to create kafka trial instances more than flag value , it should return error.

Checklist (Definition of Done)

[ ] All acceptance criteria specified in JIRA have been completed
[ ] Unit and integration tests added that prove the fix is effective or the feature works (tested against emulated and non-emulated OCM environment)
[ ] Documentation added for the feature
[ ] CI and all relevant tests are passing
[ ] Code Review completed
[ ] Verified independently by reviewer
[ ] All PR comments are resolved either by addressing them or creating follow up tasks
[ ] Required metrics/dashboards/alerts have been added (or PR created).
[ ] Required Standard Operating Procedure (SOP) is added.
[ ] JIRA has been created for changes required on the client side

Thank you so much guys for providing your expert feedback and helping me to make this PR better.
I've addressed all feedback. Please let me know in case I'm missing anything.
@machi1990 I tried to use your suggestion to mock SQL query in test but it doesn't work. I'm not able to mock count in SQL query. Please suggest me what is wrong in unit test

Thank you so much guys for providing your expert feedback and helping me to make this PR better. I've addressed all feedback. Please let me know in case I'm missing anything.
@machi1990 I tried to use your suggestion to mock SQL query in test but it doesn't work. I'm not able to mock count in SQL query. Please suggest me what is wrong in unit test

the test setups is still missing a few mocks configuration. Due to that you are getting a Db exception.
I’ll put comments below each setup to say what’s missing and we could sync up tomorrow to talk about them in detail.

A couple of follow-up task

Adding the flag in app-interface
Checking the impact on kas-installer


test: Wait for Istio POD termination before deleting istio-system or cilium

Recently Istio PODs have been lingering in terminating state long
after deletion. It appears that kubelet on k8s2-1.17 is not happy that
istio-system namespace has been deleted. Deletion of the namespace
usually automatically deletes all the PODs in it. It may also be that
the termination fails to complete since the Cilium DS is being deleted
right after the istio-system namespace is deleted.
k8s2 kubelet[3338]: W0225 ... 3338 status_manager.go:546] Failed to update status for pod "istio-citadel-7859cc956c-74474_istio-system(9a0a2875-076b-4670-a9b4-13f92f6c7240)": failed to patch status "... "state":{"terminated":{"exitCode":0,"finishedAt":null,"startedAt":null}}" for pod "istio-system"/"istio-citadel-7859cc956c-74474": namespaces "istio-system" not found

This change is

test-me-please

CI for #10299 seems to be consistently failing due to Istio PODs on k8s2-1.17 not terminating. This should fix that.

Coverage decreased (-0.002%) to 45.51% when pulling 946c2bc739ef2f2c7abb771c06ccf67793e604d2 on pr/jrajahalme/istio-assert-terminating-pods into 43f7824bc3ebccf87a643ef65bc850310196f841 on master.

test-missed-k8s


12273 - Enforce integration tests to use Berkeley Mina Daemon Image

!ci-build-me

We will use a Sandbox instead of the Berkeley Network.


Integration tests leave Heapster instances running and operate on default namespace

All remainings of the test should be deleted after the run and they should have a separate namespace.

Fixed in #563


[Question]: It's possible to user/import un existing VM ?

Is your question not already answered in the FAQ?

[X] I made sure the question is not listed in the FAQ.

Is this a general question and not a technical issue?

[X] I am sure my question is not about a technical issue.

Question
Hi,
A big thanks for this work ! It's great !
One question please : It's possible to use/import un existing VM ?
Thx

@kroese but he can try install system and then copy data.img of created vm and further use it for new containers right?


Question about local persistence

I understand the primary function of RocketData is to cache and internally represent data that is available from another source, like a server.
I'm curious about storing metadata about this cached data that isn't destined for the original backend. For example, lets say I have a list of something, and I want to create (separately, stored only on the local device) a set of bookmarks pointing to those items.
Could I store my bookmarks in RocketData somehow and ensure they stick around? Or perhaps it would be better to use another storage solution to save a list of IDs with the metadata for each ID, and then ask RocketData for the item attached to that ID. Or maybe some other solution I'm not thinking of?

Oh man...I'm really sorry, but I missed this entirely.
Although most of the examples in the docs mention networking (because that's a really common use case), it's not how rocket data is actually set up. For a really high level, it's more similar to Core Data in that it doesn't know anything about the network and instead is just a data store (which you can hook up to the network if you want).
So, you can definitely have storage only for the device. If you want to store all your bookmarks you can simply do:
let dataProvider = CollectionDataProvider<Bookmark>()
let bookmarks: [BookMark] = ...
dataProvider.setData(bookmarks, cacheKey: "bookmarks")

The other thing you mentioned was ensure they stick around. This is up to you. Usually, Rocket Data is recommended to use as a cache instead of a permanent store (an advantage over Core Data), but you're free to do whatever you want. So, when implementing the CacheDelegate, you could:

Always use a permenant store for all data
Something like:

func setCollection(_ collection: [SimpleModel], forKey cacheKey: String, context: Any?) {
    if let collection = collection as? [Bookmark] {
        // save in a permanent store
    } else {
        // save in a cache
    }
}

Interesting. The second part of your answer is probably the part that I was most unsure about.
Thanks!


Recreate streams

When a camera is disconnected during a stream, the system searches for the best device candidates that match the characteristics of the one in use on that stream, and recreates the stream from the ground up (while keeping the same pipeline ID). In the case of more than one stream running, the system discards any other device in the other stream.
To achieve that, the owner of the <VideoAndStreamInformation> was changed from the <PipelineState> (the inner state of each kind of <Pipeline>) to the <Stream>, while we moved part of the <Stream>'s fields to a thread-safe inner state called <StreamState>.
Closes #206
Closes #223
Closes #226
It's working, but it's a draft until I:

[x] Organize the thread communication/end-of-life;
[x] Make the recreated streams use the same ID as the killed one;
[x] Avoid huge logs by reporting at geometrically growing intervals;

Be free to merge once the CI approve.

@patrickelectric added a log to record when the lost timestamps started:
https://github.com/mavlink/mavlink-camera-manager/assets/5920286/fac3b91d-27cd-4c36-970b-5af3720c86bc


Feature requests and bugs based on a practical workflow example

Thanks @liamhuber. Many of the new features are really great. I particularly like the show button and the color flash when a cell is active. I worked a bit with the latest version and tried to build up a simple workflow to build a pyiron table, use this data to make a plot (including using the information from the column names to set the axis labels) and filter relevant projects. It was nice to see that the new capability to add new nodes within the notebook is quit powerful. I have added the example in the example_table notebook and json file in the repository.
When working with pyironflow a missed a few features and observed a few bugs listed below:

deleting a script does not work (clicking on the icon button nothing happens)
it would be nice if pyironflow would remember the last saved json-file and script and open it directly
when loading the json file the input is initialised to the default value, not the one in the saved script (this severely limits the user experience since the same buttons have to be clicked again and again making debugging hard)
it would be nice to get the command to open and run a node in a separate cell of the jupyter notebook. I did it manually via gui.script.nodes[index_of_node] but this is rather cumbersome since the node index has to be obtained by trial and error. For example, the command (or a button) could be placed in the box where the input of the node is controlled.
since scrolling appears to be not working in the output window it would be nice to open the output content in another notebook cell
certain node feature will be commonly requested, e.g. input as combobox with the possibility to add/delete them (e.g. for the pyironTable to add new columns)
I was expecting that gui.load(json_file) would work but got an error message

Thanks for the feedback and the new demo!

deleting a script does not work (clicking on the icon button nothing happens)

I'm not able to reproduce this. I added a safety feature that requires confirming script deletion -- there's a little "pop-up window" right below the main toolbar after clicking the delete button. Maybe you just missed this?
Unfortunately, real "pop-up" windows are not supported in ipwidgets. I could probably do something with colour to make this pseudo-pop-up pop a bit more though?

it would be nice if pyironflow would remember the last saved json-file and script and open it directly

It does! 😄 When you instantiate the gui, use the name of the json-file you want to load (minus the '.json' extension) and it will automatically search for the json.

when loading the json file the input is initialised to the default value, not the one in the saved script (this severely limits the user experience since the same buttons have to be clicked again and again making debugging hard)

Yikes, yep! I suspect this was an unintended side-effect of my patch to get node defaults to actually be used. I don't think it will be too hard to fix, but it's a big enough deal that I'll make a separate issue for it so I don't lose track.

it would be nice to get the command to open and run a node in a separate cell of the jupyter notebook. I did it manually via gui.script.nodes[index_of_node] but this is rather cumbersome since the node index has to be obtained by trial and error. For example, the command (or a button) could be placed in the box where the input of the node is controlled.

This sounds like a reasonable idea to me, but I'll need to think/read a bit about implementation. Definitely adding some sort of "(force) update" button to the nodes is super easy. I currently have no idea how hard/easy it is to use that to trigger action in a new cell. An alternative might be to reroute the stdout to a convenient window inside the gui itself. I'll probably make a separate issue for this and play around with it later as it's (potentially quite) a bit deeper.

since scrolling appears to be not working in the output window it would be nice to open the output content in another notebook cell

I'm not sure what you mean here. When I use it, the output window generated by the "SHOW" button automatically extends the gui.draw() cell as far as needed to show all the output requested, and scrolling the notebook as usually lets me see it. Is your output somehow cut off? Are you using notebook or lab? (I'm using lab and would prefer to be lazy and not support notebook...)
I played around a little a couple weeks ago with a personal project using voila, and I can see that if we want to move in that direction in the future, then the entire gui.draw() output "app" will need to have some fixed maximum size. At that point we'll need to limit the height of the output window and have the scrolling occur inside that window. I anticipate zero problems making that happen, but I'd rather cross that bridge when we get to it -- right now I'm not even convinced this is where the output window will live indefinitely.

*certain node feature will be commonly requested, e.g. input as combobox with the possibility to add/delete them (e.g. for the pyironTable to add new columns)

This is a really nice idea! Right now we only offer access to the base pyiron Node class when people import from ironflow.custom_nodes, but having a bunch of deeper templates in there to draw from would be stellar. I'll start collecting ideas like this for what to add.

I was expecting that gui.load(json_file) would work but got an error message

I can't reproduce this error. I have no problem gui.load('example.json') from either a clean session or a session that's already loaded other stuff.
I do have trouble with the actual gui not updating -- to actually see the effect of the load I need to trigger a refresh from within the GUI, e.g. by creating a new script or whatever. I have an idea for how to get it to update automatically though and will try that.

Thanks for the quick reply, @liamhuber.

Thanks for the feedback and the new demo!

deleting a script does not work (clicking on the icon button nothing happens)

I'm not able to reproduce this. I added a safety feature that requires confirming script deletion -- there's a little "pop-up window" right below the main toolbar after clicking the delete button. Maybe you just missed this?
Unfortunately, real "pop-up" windows are not supported in ipwidgets. I could probably do something with colour to make this pseudo-pop-up pop a bit more though?
Thanks for the explanation. I indeed simply overlooked the confirmation line. It may thus be indeed helpful to highlight it more prominently.

it would be nice if pyironflow would remember the last saved json-file and script and open it directly

It does! 😄 When you instantiate the gui, use the name of the json-file you want to load (minus the '.json' extension) and it will automatically search for the json.
Thanks, this works beautifully. I tried to to get directly to a specific Tab via the instantiation (e.g. script_title='Table') but this did not work. I guess presently script_title only gives a name for a newly instantiated script. It may be helpful to include this additional functionality.

when loading the json file the input is initialised to the default value, not the one in the saved script (this severely limits the user experience since the same buttons have to be clicked again and again making debugging hard)

Yikes, yep! I suspect this was an unintended side-effect of my patch to get node defaults to actually be used. I don't think it will be too hard to fix, but it's a big enough deal that I'll make a separate issue for it so I don't lose track.
EDIT: Patched in #106
Thanks.

it would be nice to get the command to open and run a node in a separate cell of the jupyter notebook. I did it manually via gui.script.nodes[index_of_node] but this is rather cumbersome since the node index has to be obtained by trial and error. For example, the command (or a button) could be placed in the box where the input of the node is controlled.

This sounds like a reasonable idea to me, but I'll need to think/read a bit about implementation. Definitely adding some sort of "(force) update" button to the nodes is super easy. I currently have no idea how hard/easy it is to use that to trigger action in a new cell. An alternative might be to reroute the stdout to a convenient window inside the gui itself. I'll probably make a separate issue for this and play around with it later as it's (potentially quite) a bit deeper.

Having it inside pyironflow would be great.  If opening a new cell turns out to be difficult generating a line (string) that can be copied into a new cell would already help a lot.

since scrolling appears to be not working in the output window it would be nice to open the output content in another notebook cell

I'm not sure what you mean here. When I use it, the output window generated by the "SHOW" button automatically extends the gui.draw() cell as far as needed to show all the output requested, and scrolling the notebook as usually lets me see it. Is your output somehow cut off? Are you using notebook or lab? (I'm using lab and would prefer to be lazy and not support notebook...)

I indeed had scroll bars in the output window in mind. While scrolling the notebook (I use jupyterlab) vertically works it is often necessary to have also a horizontal scroll bar (e.g. for pandas dataframes). It looks like this is known bug in the ipywidgets module and fixed in version 8.0. However, it also looks like nglview requires an ipywidgets version below 8.0. We therefore probably have to live with this issue for a while. As a simple fix I had the idea to have something like gui.output or gui.show_output_window command which I can run in a separate notebook cell.

I played around a little a couple weeks ago with a personal project using voila, and I can see that if we want to move in that direction in the future, then the entire gui.draw() output "app" will need to have some fixed maximum size. At that point we'll need to limit the height of the output window and have the scrolling occur inside that window. I anticipate zero problems making that happen, but I'd rather cross that bridge when we get to it -- right now I'm not even convinced this is where the output window will live indefinitely.

*certain node feature will be commonly requested, e.g. input as combobox with the possibility to add/delete them (e.g. for the pyironTable to add new columns)

This is a really nice idea! Right now we only offer access to the base pyiron Node class when people import from ironflow.custom_nodes, but having a bunch of deeper templates in there to draw from would be stellar. I'll start collecting ideas like this for what to add.

I was expecting that gui.load(json_file) would work but got an error message

I can't reproduce this error. I have no problem gui.load('example.json') from either a clean session or a session that's already loaded other stuff.
I do have trouble with the actual gui not updating -- to actually see the effect of the load I need to trigger a refresh from within the GUI, e.g. by creating a new script or whatever. I have an idea for how to get it to update automatically though and will try that.

I was not able to get this working. When instantiating the gui and running load I do not see the loaded scripts (even if I try to make a refresh).

A few more items/ideas regarding features. I guess it is ok to stick to this issue and do not open a new one.

Programming the nodes with constructs like self.inputs[1] is inconvenient and error prone. It would be nicer to allow constructs with the actual input name, i.e. self.input.alat of self.input['alat']. Being able to provide actual names makes the code much easier to read, avoids errors when introducing new inputs/outputs since it does not require reindexing.

The following point is realted to pyiron, but required to get nice solutions for ironflow:
- It would be good to have for some pyiron constructs an alternative formulation. An example is
    job.calc_md(temperature=300)  # previous

    job.calc = calculator.md(temperature=300)   # alternative

Such a formulation would allow us to easily create generic modules, e.g. for MD that can be used as input for VASP, LAMMPS, etc.
The same applies to job.server etc.

Having [node update stdout] inside pyironflow would be great. If opening a new cell turns out to be difficult generating a line (string) that can be copied into a new cell would already help a lot.

Yeah, that's a good idea for an intermediate step. I added this part of the conversation to #60 so I don't lose track of the idea.

I indeed had scroll bars in the output window in mind. While scrolling the notebook (I use jupyterlab) vertically works it is often necessary to have also a horizontal scroll bar (e.g. for pandas dataframes). It looks like this is known bug in the ipywidgets module and fixed in version 8.0. However, it also looks like nglview requires an ipywidgets version below 8.0. We therefore probably have to live with this issue for a while.

Yeah, it sounds like we're on the same page for what would be nice to have, but indeed the ipywidgets limit is constraining.

As a simple fix I had the idea to have something like gui.output or gui.show_output_window command which I can run in a separate notebook cell.

There is such a simple fix! gui.node_presenter.box will return this object. Even in a new cell, it will update itself automatically when you click SHOW on different nodes too.

I was not able to get this working. When instantiating the gui and running load I do not see the loaded scripts (even if I try to make a refresh).

Hmm, that is tricky then. I think we'll have to look at it in real-time whenever we Zoom again.

A few more items/ideas regarding features. I guess it is ok to stick to this issue and do not open a new one.

Super. Yep. I'll break them up and move them around as needed later, and close this one when everything is either resolved or delegated to another issue.

Programming the nodes with constructs like self.inputs[1] is inconvenient and error prone. It would be nicer to allow constructs with the actual input name, i.e. self.input.alat of self.input['alat']. Being able to provide actual names makes the code much easier to read, avoids errors when introducing new inputs/outputs since it does not require reindexing.

I'm 100% on board with this. Right now the inputs and outputs are just lists, but I should be able to override this with a list-like class that has a modified __getattr__ so it first checks if any of its elements has a label corresponding to the requested key.
In the medium-term this would be better to implement right in ryvencore instead of ironflow, but I'll do it as a proof-of-concept in our overridden node class first. My interactions with Leon Thomm have all been good and productive so far, but I'd rather bring him a working idea. There will also be some delay on this front as there is some disconnect between his latest version of ryvencore and what's available on Conda. After I get experience putting ironflow on conda-forge I'll see if I can help him streamline his release process so we can get his latest ideas in our dependency stack.

The following point is realted to pyiron, but required to get nice solutions for ironflow:
It would be good to have for some pyiron constructs an alternative formulation. An example is

    job.calc_md(temperature=300)  # previous
    job.calc = calculator.md(temperature=300)   # alternative

Such a formulation would allow us to easily create generic modules, e.g. for MD that can be used as input for VASP, LAMMPS, etc.
The same applies to job.server etc.

Yep. I will probably hack-and-slash something to this effect after I get the book-keeping (CI, pypi release, conda-forge release) all sorted out. My current vision is that things like the Lammps node can only ever run a static calculation (or no running of these nodes??) and that they otherwise need to be passed as input to MD, minimimization, NEB, VC-SGC, etc. calculators.
This is thus a little bit different from what you suggest here, something more like:
md = pr.atomistics.calculator.MD('my_md_run')
md.temperature = 300
md.n_steps = 1000

lammps = pr.atomistics.representation.Lammps('lammps_reference')
lammps.structure = pr.atomistics.structure.bulk('Fe').repeat(4)
md.representation = lammps

md.run()

In a perfect world I imagine that the calculator would then see if the representation has native support for this type of calculation, e.g. lammps has calc_md so we would basically just be using the calculator as a wrapper interface for that -- but then if the representation doesn't allow it that the calculator either falls back on a python-coded version of the algorithm, or throws an error (probably when the representation is assigned, so we fail as early as possible).
This is definitely best implemented right in the heart of pyiron, but I think it will be productive to play around with the idea here in ironflow where I'm just making it look like that's what the underlying model is. That will give us some freedom to experiment with different architectures/interfaces without breaking anything anyone else cares about.

Thanks for your quick and very constructive reply @liamhuber. Just a few thoughts regarding the calculator.MD idea. At a first glance it looked to me like your suggested version makes things more complex than what we have now. In the example given by you a single line
 job.calc_md(temperature=300)

would be replaced by 4 lines. In a jupyter notebook version (or general in a python script) I would not like to have it (or at least I would prefer to keep our present single line approach as one possible option). However, for a visual node based approach your pseudo code would work very well. We reduce the number of inputs to the LAMMPS node and make the MD module generic. The workflow would then look like:
structure -> LAMMPS -> MD

Based on this concept we could/should also convert other inputs into the LAMMPS job into nodes. Specifically, we could have the following flow:
  structure -> LAMMPS -> POTENTIAL -> MD -> SERVER

The advantage of this flow would be that the potential module has all the critical information (i.e. LAMMPS and structure). This construct is much cleaner than the original one, since we do not have to test that one input (structure) is there to generate another input (potential). The same applies to SERVER, where the info regarding the queue, number of cores etc. are provided. Our present LAMMPS job could be regarded as a macro node of this workflow, which collects all the input parameters of the inputs of the various nodes in the macro object, i.e., structure, potential etc.
These thoughts also show that for supporting the two very different approaches for workflows (visual node based one vs command like python based one) different code constructs are needed.

One more issue I forgot to mention in the last comment:

We should print not only the input labels in the graphical representation of the node but also the output ones. Actually, it appears the output is printed already but placed right to the dot representing the output. One can see this if one brings another node to the right side of the node, then the printout becomes visible. Thus, the fix should be simply to shift the end of the text to the left side of the output node.

One more issue I forgot to mention in the last comment:

We should print not only the input labels in the graphical representation of the node but also the output ones. Actually, it appears the output is printed already but placed right to the dot representing the output. One can see this if one brings another node to the right side of the node, then the printout becomes visible. Thus, the fix should be simply to shift the end of the text to the left side of the output node.

Absolutely! There is just a bit of finicky front-end stuff that has led me to procrastinate on this: i.e. making sure the text is right-justified, handling truncation when the labels (also input) are too long, and experimenting with new node widths to see which compromise narrowness (for overall node compactness) and width (for fitting long labels) "feels" best.


Improve doc for Python dependencies with C++/DLL components

The Working with Python > Deployment Package page section on "Updating a function with additional dependencies" misses an important point that can confuse users:
Following the instructions to pip install --target ./package on your build environment only works if either...

Your target libraries are pure Python (or any bundled native dependencies are cross-platform), or
Your build environment architecture is similar to the Lambda runtime.

For example (a typical request), I cannot pip install --target ./package Pillow on my Mac, bundle that to a Lambda deployment package and upload it. My Lambda function will give an error message something like:
{
    "errorMessage": "Unable to import module 'lambda_function': Cannot import name '_imaging' from 'PIL' (/var/task/PIL/__init__.py)",
    "errorType": "Runtime.ImportModuleError"
}

...If I'm deep on Python packaging, I might trace that this is because the line from . import _imaging as core buried in the PIL source code will work on my machine (where it resolves _imaging.cpython-38-darwin.so installed in the bundle) but fail on Amazon Linux (because the architecture doesn't match).
If I'm not, it will probably take me a long time to debug as I'll be looking for solutions specific to my library & runtimes!
Please consider adding a caution on this (perhaps mentioning some popular libraries like PIL/Pillow which bundle architecture-specific components), and some discussion on workarounds such as:

Creating the bundle (or at least the packaging part) on a compatible environment e.g. an EC2 instance, Cloud9, a SageMaker Notebook, etc)
Using the AWS SAM CLI on your local machine with the --container option, so that SAM sets up a Docker container with a Lambda-like environment for you and simplifies the process.

Thanks!

This appears to be resolved, see the note now made into a recommendation: here

There is now more guidance on installing and building packages for compatibility here: https://docs.aws.amazon.com/lambda/latest/dg/python-package.html#python-package-native-libraries


Add Poughkeepsie, New York - Dutchess County

To:
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
Subject: Defunding of the PK Police Department
Message
To Poughkeepsie Town Officials:
My name is [Insert Name] and I am a resident of [Neighborhood/City].
Given the historic, social, and political origins of police and policing, in conjunction with the recent nationwide protests reflecting the antiBlack deaths of George Floyd, Breonna Taylor, and Tony McDade I am contacting you because I am demanding you to redirect money away from the Poughkeepsie Police Department and prioritize collective services that will help improve the socio-economic conditions of Poughkeepsie's predominately Black communities.
Subsequently, a majority of teachers are at serious risk of losing their positions as well the youth losing the essential human right to learn and receive a formal education. As such, the Poughkeepsie City School District has stated the following:

The Poughkeepsie City School District is proposing to eliminate 48 positions, including teachers, administrators and support staff, as it attempts to erase a $2.6 million deficit for its 2020-21 budget. The board voted Wednesday to eliminate positions for elementary assistant principals, the Poughkeepsie High School dean of students, the assistant to the superintendent and a position that had yet to be filled for the director of grants and advancement.
Superintendent Eric Rosser said the cuts, most of which have yet to be voted on, are necessary to overcome financial challenges that include decreases in state aid, the loss of building aid, increases in operating costs, and other financial obligations. Some, but not all, of those losses are related to hardships created by the coronavirus pandemic.
He said as the administration continues to finalize its budget he may have to consider more eliminations. School budget votes, which were to take place May 19, were delayed until a date to be determined after June 1.
"Of course in this district we are not looking to take away valuable members of our organization that support student learning, but it is our hope that we would be able to retain our staff members, because each member is in the position to meet the varying needs of our children," Rosser said to the district board of education Wednesday. "Unfortunately, given our budgetary situation we are forced to move in this direction, it is not a good direction that I, as a superintendent, or even as an educator, would recommend. However, when you don't have the ability to meet people's payroll or salary you have to move in the direction of a budget that we will be able to meet the payroll."
When contacted by the Journal, Board President Felicia Watson declined to answer questions regarding the moves, but said "The board awaits the presentation of the final budget that the superintendent will be holistically presenting soon."
The layoffs, if approved, would include 27 teacher positions, 11 administrator positions, and 10 support staff positions, as well as the restructuring of some central office positions. Rosser noted the eliminations do not necessarily mean 48 staff members will be laid off, given some positions are vacant due to retirements and other transitions.
Administrative positions eliminated would include the P-Tech program principal, the PACE (Poughkeepsie Academic and Career Excellence) program principal, the PACE assistant principal, the high school dean of students, five elementary assistant principals, the assistant to the superintendent, and the director of grants and advancement.
The proposed layoffs would result in around $3 million of savings. Rosser said the eliminations are likely to happen given the economic uncertainty amid the pandemic, and the district could see more eliminations as the budget is finalized.
He said more eliminations will be voted on by the board Wednesday, May 6.
When asked by the board at the meeting how the schools will continue to provide services, Rosser did not have an answer.

In addition to the lack of funding in schools, County Executive Marc Molinaro has reported that 2019 was a strong "fiscal" year, in particular response to the COVID-19 pandemic, stating:

"Expenses totaled $471.2 million, while revenue added up to $472.6 million. Additionally, sales tax revenue increased by $9.1 million, a 4.6% increase over 2018. The county also ended the fiscal year with $56.9 million in its general fund balance."
Moreover, "...[r]evenues increased in 2019, even as expenditures also increased in several areas. That included a $7.6 million cost increase to the Dutchess County Sheriff's Employee Association for union contract settlements, positions, employee benefits and debt service.

Ultimately, the allocation of funds that have been attributed to the Poughkeepsie police department in contrast to the funding towards schools, is both erring and telling. I yearn to know what you will do to protect Black lives and prevent further instances of police-state-sanctioned violence, the emotional, social, and educational well-being of Black lives. I am calling to urge you to condemn police brutality, racial profiling, and the use of excessive force by police on oppressed communities.
Sincerely,
[Insert Name]

Thanks so much for bearing with the requests @DerilusP1! This is in the review pipeline now.

on it now


Essential updates and fixes

Fixes invalid downloads in the archives (issue #124)
Increases the font size in chart legends, tick labels, and hover modals
Better integration and consistency of the GDS typeface (issue #90)
Last label in the x-axis is now always displayed for all charts
Increased the font contrast in chart tick labels
Other minor fixes and improvements

 Increase text on graphs to 14px

 Users think the graphs are not updating because of the dates

 Bug: Add style for the h4 tag in Markdown (about page)

 Chart label colours

 Bug: Archive page data is not correct

 Set $govuk-font-family to a different font stack before importing govuk-frontend to override the font stack


NetteForm validation not working

setRequire does not work

I will take a guess that the experienced issue was in FE validation when using the default client-side https://github.com/nepada/autocomplete-input.js and not in BE validation.
That should be fixed by: https://github.com/nepada/autocomplete-input.js/commit/56b4ba5de1294bb2442a1265972675d391ce0134


Added blocks for account form #7268

Coverage remained the same at 68.69% when pulling a0d506e0c4efd647b9dafdf3b77c47dedd7c4f4f on gautampanday:account-block into dc4615135e06efe1e34d859e5166d9e4bcd4e055 on openlabs:develop.


Tensorflow/Keras Endpoint layer does not work with Tensorflow dataset in eager mode

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Google Colab, Mac OS
TensorFlow version:
2.3.1
Python version:
3.6.9

Describe the current behavior
The Endpoint layer pattern described in Tensorflow documents only works with Numpy arrays and it does not work with Tensorflow dataset
Describe the expected behavior
The Endpoint layer is expected to work with Tensorflow dataset as well
Standalone code to reproduce the issue
This code is from Tensorflow documents that works only with Numpy arrays:
import tensorflow as tf
from tensorflow import keras
import numpy as np

class LogisticEndpoint(keras.layers.Layer):
    def __init__(self, name=None):
        super(LogisticEndpoint, self).__init__(name=name)
        self.loss_fn = keras.losses.BinaryCrossentropy(from_logits=True)
        self.accuracy_fn = keras.metrics.BinaryAccuracy()

    def call(self, targets, logits, sample_weights=None):
        # Compute the training-time loss value and add it
        # to the layer using `self.add_loss()`.
        loss = self.loss_fn(targets, logits, sample_weights)
        self.add_loss(loss)

        # Log accuracy as a metric and add it
        # to the layer using `self.add_metric()`.
        acc = self.accuracy_fn(targets, logits, sample_weights)
        self.add_metric(acc, name="accuracy")

        # Return the inference-time prediction tensor (for `.predict()`).
        return tf.nn.softmax(logits)

inputs = keras.Input(shape=(3,), name="inputs")
targets = keras.Input(shape=(10,), name="targets")
logits = keras.layers.Dense(10)(inputs)
predictions = LogisticEndpoint(name="predictions")(logits, targets)

model = keras.Model(inputs=[inputs, targets], outputs=predictions)
model.compile(optimizer="adam")

data = {
    "inputs": np.random.random((3, 3)),
    "targets": np.random.random((3, 10)),
}
model.fit(data)

Experiment 1: Using TF dataset in a dictionary
tf_data = {
    'inputs': tf.data.Dataset.from_tensor_slices(np.random.random((3, 3))),
    'targets': tf.data.Dataset.from_tensor_slices(np.random.random((3, 10)))
}

model.fit(tf_data)

Experiment 2: TF dataset that contains tuples
data = {
    "inputs": np.random.random((3, 3)),
    "targets": np.random.random((3, 10)),
}
tuple_data = []
for i in range(3):
  tuple_data.append((data['inputs'][i, :], data['targets'][i, :]))

dataset = tf.data.Dataset.from_generator(lambda: tuple_data, (tf.float32, tf.float32))

# to show the dataset content
for x in dataset:
  print(x)

model.fit(dataset)

Colab link:
https://colab.research.google.com/drive/1zaAgPZ4U49t2PkIl7qdm348ayt7Z5O-0

Was able to reproduce the issue with TF v2.3 and TF-nightly. Please find the attached gist. Thanks!

@amahendrakar Thanks.
@soroosh-rzh
Can you try with:
input = tf.random.uniform([3, 3])
targets = tf.random.uniform([3, 10])
tf_data = tf.data.Dataset.from_tensor_slices({'inputs': input, 'targets': targets})
tf_data = tf_data.batch(2)
model.fit(tf_data)

@bhack
I tried it, it works! Thanks for the suggestion. The loss is a little bit different from what is gained using numpy but I believe it should be Ok!
Do you have any idea how it might work without dictionary and using tuples as input/outputs? The real use case for me would be multiple inputs/outputs. I mean something close to what I have mentioned in experiment 2.
Thanks

We use our stack overflow space for this kind of support.
Please submit at https://stackoverflow.com/questions/tagged/tensorflow and close this.

Correct. Forgetting what would be my use case, I still think the endpoint pattern is not working without a dictionary as input so that may be a still a bug not a question! Thank you for your reply.

Can you reformulate your code with your bug hypotesis?

@soroosh-rzh,
Can you please respond to the above comment. Thanks!

@bhack @rmothukuru I will reformulate the code and add a comment over my weekend! Please do not close this issue for now. Thanks

@soroosh-rzh,
Can you please respond to the above comment. Thanks!

@soroosh-rzh,
Automatically closing due to lack of recent activity. Please update the issue when new information becomes available, and we will reopen the issue. Thanks!
The issue is resolved by using tf.data.Dataset.from_tensor_slices and tf_data.batch(2) as mentioned in bhack's answer.
Please raise a new issue with your reformulated code. Thanks!

@soroosh-rzh,
Automatically closing due to lack of recent activity. Please update the issue when new information becomes available, and we will reopen the issue. Thanks!
The issue is resolved by using tf.data.Dataset.from_tensor_slices and tf_data.batch(2) as mentioned in bhack's answer.
Please raise a new issue with your reformulated code. Thanks!


attach outbox ID to the client header, and remove sent notification

@patrickxb r?
This removes the separate notification when a message is delivered from the outbox, and instead just decorates all messages with their outbox ID (if any). This way when Electron gets the "newMessage" notification, it can check for OutboxID to know how to render. It takes up more space, but we are talking 8 bytes, and it is the easiest solution I can think of.
@cjb cc

There's a Jenkins failure:
23:28:03 ./sender_test.go:43: undefined: chat1.ChatActivityType_MESSAGE_SENT
23:28:03 ./sender_test.go:44: activity.MessageSent undefined (type chat1.ChatActivity has no field or method MessageSent)

and I tried running this branch, but I never receive an outboxID inside the message.valid.clientHeader (for messages I sent myself).

@mmaxim works for me :thumbsup:


'Introducing the PnP provisioning engine' - Incorrect commands

Category

[x] Content fix
[ ] New article
Related issues: fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?
In the article 'Introducing the PnP provisioning engine', the commands shown all had the "SPO" prefix (e.g., Get-SPOProvisioningTemplate), which is no longer valid. This pull request corrects them to "PnP" (e.g., Get-PnPProvisioningTemplate).
Guidance
Much more useful now!

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/solution-guidance/Introducing-the-PnP-Provisioning-Engine.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Thanks so much, @sympmarc! I hope this type of contribution is contagious. :)


pull request for e2e test at 01/07/2017 11:15:10

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Ended out of nowhere

Issue Type: Bug
Just ended out of nowhere. All collaborators steped away for a break.
Extension version: 1.0.2740
VS Code version: Code 1.49.0 (e790b931385d72cf5669fcefc51cdf65990efa5d, 2020-09-10T17:39:53.251Z)
OS version: Darwin x64 19.4.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4750HQ CPU @ 2.00GHz (8 x 2000)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
4, 3, 3

Memory (System)
16.00GB (0.11GB free)

Process Argv

Screen Reader
no

VM
0%

Thank you for reporting this issue. We're investigating this currently, check back for updates soon.

Thank you for reporting. This is part of an onging sev we're investigating. Please follow #3835 for updates


Sardine kfj

fix packages, just opening PR to run tests.

Closing because again the tests are not running.


Upgrade Scala Maven Plugin to 4.3.0

Fixes the issue with JAVA_HOME resolution described in https://github.com/davidB/scala-maven-plugin/issues/221.
Encountered when building using IntelliJ's maven plugin
Signed-off-by: Gera Shegalov<EMAIL_ADDRESS>

build

build

I don't think it will affect us much since our build is pretty fast, but the maven plugin changed the way it figures out if it needs to rebuild something. The Spark build time increased a lot now that they moved up as well.  Unless of course they have fixed it, they were supposed to be working on alternate solution, don't remember the details off the top of my head but could dig up if needed.

I don't think it will affect us much since our build is pretty fast, but the maven plugin changed the way it figures out if it needs to rebuild something. The Spark build time increased a lot now that they moved up as well.  Unless of course they have fixed it, they were supposed to be working on alternate solution, don't remember the details off the top of my head but could dig up if needed.


Create item class

In this branch I:

Create a new "classes" folder to store our work.
Create the item class
Item class is initialized with private id, private archived, and public published_date
added attr_accessor for genre, author, source, and lablel

CLOSES #1

Hi @tomasesquivelgc,
Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights 🥇
✔ Descriptive PR Title
✔ Descriptive PR Summary
✔ Following Gitflow
✔ Following requirements 🔥


ci: Resync from release-1.15 to downstream release-4.17

Resync from release-1.15 to downstream release-4.17

Checklist:

[ ] Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
[ ] Reviewed the developer guide on Submitting a Pull Request
[ ] Pending release notes updated with breaking and/or notable changes for the next minor release.
[ ] Documentation has been updated, if necessary.
[ ] Unit tests have been added, if necessary.
[ ] Integration tests have been added, if necessary.

Shouldn't have merge conflicts with the resync, need to discuss if #694 caused this...

Will open a new resync PR...