Added path list input support for fuzzing and crawling

./katana -h path

Usage:
  ./katana [flags]

Flags:
   -path string  path or list of paths to use for fuzzing and crawling paths (comma-separated, file)

from what i can tell . we intentionally skipped using retryablehttp in katana . to avoid detections and other cipher fingerprinting etc  . this PR uses retryablehttp . we need to re-evalvate this since this is opposite of current behaviour??

we can add support for forced crawling i.e start crawling with these paths . but not sure it is good idea to include fuzzing support in katana

cc: @ehsandeep  @Mzack9999

from what i can tell . we intentionally skipped using retryablehttp in katana . to avoid detections and other cipher fingerprinting etc . this PR uses retryablehttp . we need to re-evalvate this since this is opposite of current behaviour??

we can add support for forced crawling i.e start crawling with these paths . but not sure it is good idea to include fuzzing support in katana

cc: @ehsandeep @Mzack9999

@tarunKoyalwar we can adapt the PR to make the code changes based on the above inputs.

I don't think we should bring fuzzing and passive sources into katana, the tool is an active crawler. I think the same result can be obtained with something like this:
echo target.host | httpx -path paths.txt | katana

@ehsandeep , as @Mzack9999 mentioned the usecase can be achieved just by using httpx
httpx -list domains.txt -path paths.txt | katana

and this takes care of dead urls. so not sure idea proposed in PR

@faf-xff I'm closing the PR as not planned since this functionality can be covered with faster processing via httpx and output piped to Katana. Please let me know if you think anything is missing. Thanks!


[Feature Request] Buddhist Era for DatePicker/CalendarType

My country uses Buddhist Era year in the calendar. Buddhist Era is familiar to my users. It's easy to recognize.
It would be great if OpenUI5 support Buddhist Era in CalendarType and DatePicker. 🙂
Thank you.

Dear gluons,
The request seems valid. As we don't have the capacity to implement it in the near future a contribution will be welcome.
Regards,
Daniel

Since https://github.com/SAP/openui5/commit/b3b397f85a3195111eebbe51c05d52074fd0eea0, the CalendarType includes "Buddhist".

This is already implemented so I close the issue.


IS_DEFINED function is not documented correctly.

This is only supported when the property value is a primitive type. Primitive types include string, Boolean, numeric, or null. DateTime, object types, and arrays are not supported.

Above is not correct. IS_DEFINED() will work for any property which is defined with a value, regardless of whether it is a primitive, null, or an object.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b746c674-eca7-4a60-86a3-9c7c9d7b343a
Version Independent ID: a782441c-95b9-3f57-26bb-b39c8060e2cb
Content: Azure Digital Twins query language reference - Functions - Azure Digital Twins
Content Source: articles/digital-twins/reference-query-functions.md
Service: digital-twins
GitHub Login: @baanders
Microsoft Alias: baanders

Thanks @johngallardo, I'm replacing that sentence with the following text in this PR:
"This function will work for any property that can be defined with a value (including primitive types, objects, and null)."
I'm going to go ahead and merge the PR with the fix, which will close this issue--but feel free to continue commenting here if you have any edits or additional suggestions, and I'll implement them as well.
Thank you!

@baanders  - I have a slightly bigger cleanup, will send a PR.

Closing my PR without merge so we can work from yours

#please-close


Generators of bounded data structures and the command 'test'

This PR closes #622. Perhaps, it also addresses #191, but I am not sure. What happens here:

Add the operator Apalache!Gen. A call to Gen(n) produces a data structure of the proper type (basically, a tree) whose elements can also be data structures, and the number of elements is bounded by n at every level. For example, Gen(5) of type Set(Int -> Bool) produces a set of up to 5 functions, whose domains have up to 5 integers.
Add the command test <spec> <before> <action> <assertion> to run a quick test for an action in isolation.
Add an example that uses both Gen and test to do something great, see TestGen.tla.

This feature requires a proper documentation and probably a tutorial. I feel that we should experiment with it a bit.

[x] Tests added for any new code
[x] Ran make fmt-fix (or had formatting run automatically on all files edited)
[ ] Documentation added for any new functionality
[x] Entry added to UNRELEASED.md for any new functionality

I will merge this PR. It's only a partial implementation of the feature towards unit-testing of TLA+.


Expose server version tag to be set during build time

What changed?
Expose server version tag to be set during build time

Why?
for https://github.com/uber/cadence/issues/4052
following https://www.digitalocean.com/community/tutorials/using-ldflags-to-set-version-information-for-go-applications

How did you test it?
locally tested:
qlong@~/cadence:
(qlong_version_tag)$make cadence-server
compiling cadence-server with OS: darwin, ARCH: amd64

qlong@~/cadence:
(qlong_version_tag)$
qlong@~/cadence:
(qlong_version_tag)$./cadence-server
NAME:
   cadence - Cadence server

USAGE:
   cadence-server [global options] command [command options] [arguments...]

VERSION:
   development

COMMANDS:
   start,   start cadence server
   help, h  Shows a list of commands or help for one command

GLOBAL OPTIONS:
   --root value, -r value    root directory of execution environment (default: ".") [$CADENCE_ROOT]
   --config value, -c value  config dir is a path relative to root, or an absolute path (default: "config") [$CADENCE_CONFIG_DIR]
   --env value, -e value     runtime environment (default: "development") [$CADENCE_ENVIRONMENT]
   --zone value, --az value  availability zone [$CADENCE_AVAILABILTY_ZONE]
   --help, -h                show help
   --version, -v             print the version
qlong@~/cadence:
(qlong_version_tag)$rm cadence-server
qlong@~/cadence:
(qlong_version_tag)$SERVER_VERSION=0.19.1 make cadence-server
compiling cadence-server with OS: darwin, ARCH: amd64
qlong@~/cadence:
(qlong_version_tag)$./cadence-server
NAME:
   cadence - Cadence server

USAGE:
   cadence-server [global options] command [command options] [arguments...]

VERSION:
   0.19.1

Potential risks
No

Release notes
No

Documentation Changes
No

Pull Request Test Coverage Report for Build 979756b2-a7ea-477e-ad82-988197c49dab

0 of 2 (0.0%)  changed or added relevant lines in 1 file are covered.
122 unchanged lines in 8 files lost coverage.
Overall coverage decreased (-0.06%) to 67.925%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

cmd/server/cadence/cadence.go
0
2
0.0%

Files with Coverage Reduction
New Missed Lines
%

service/history/execution/mutable_state_task_refresher.go
1
75.29%

service/history/task/task.go
1
83.2%

common/task/weightedRoundRobinTaskScheduler.go
2
89.64%

common/types/mapper/thrift/shared.go
2
72.02%

service/history/execution/mutable_state_builder.go
2
69.79%

service/history/task/transfer_standby_task_executor.go
4
90.32%

common/persistence/cassandra/cassandraPersistence.go
21
51.36%

common/persistence/cassandra/cassandraPersistenceUtil.go
89
87.6%

Totals

Change from base Build b5b4de3f-e897-4629-a30c-130a72d78cad:
-0.06%

Covered Lines:
98578

Relevant Lines:
145128

💛  - Coveralls

Is it possible to include the first part of git sha as part of the version as well?
So it will look like "development-XXXXXX" and "0.19.1-XXXXXX"

Is it possible to include the first part of git sha as part of the version as well?
So it will look like "development-XXXXXX" and "0.19.1-XXXXXX"

It's not usual to do that way. How about having another field commit?

@Groxx LMK if you have any other comments


ASP.NET Core 1.1 - Error MSB4041

Build error with project.json not found.

Why closed issue #3311?

@aciechomski  #3311 Seems to be about *.csproj and not project.json

In VS 2017 project.json is depreciated and csproj doesn't work

csproj does work. could you please provide muc more information?
dotnet --info to get started and what error message you get?

Error MSB4041: The default XML namespace of the project must be the MSBuild XML namespace. If the project is authored in the MSBuild 2003 format, please add xmlns="http://schemas.microsoft.com/developer/msbuild/2003" to the  element. If the project has been authored in the old 1.0 or 1.2 format, please convert it to MSBuild 2003 format.

I have exactly the same problem as aciechomski. VSTS throws the above error for ASPNET Core project

Both are the same issue.  The hosted image doesn't have VS2017 yet.  Read my last comment in #3311
You can create a private agent if you're blocked (on azure VM)

@bryanmacfarlane I'm seeing this same behavior running MsBuild in a jenkins script. The build works fine locally in VS2017. Will there be a new BuildTools release which supports VS2017/dotnetcore incoming soon? (Sorry that this isn't a VSTS specific issue; please feel free to point me at the appropriate GitHub repo.)

When is the hosted image going to get VS2017??  This is big drawback in using VS Team Services..  they should be coming out BEFORE everyone else gets it.

It's there.  Read the link above.  It shows up as the "hosted vs2017" queue in your definitions queue picker
Also note this is not a limitation of the vsts build system.  You could hook up any agent on any vm with any tool sets you want.
It is a limitation of the convenience hosted pool machines.  But as I outlined in that link we are improving that with multiple hosted images via multiple queues so we can get images with preview tools earlier.

Unfortunately that is not working.. that host fails at the Build step for me, which is just a VS2017 build of the SLN.

Same issue here, but can't find a workaround at the moment.
Started a new WebAPI project in VS2017 - and got the issue:

The default XML namespace of the project must be the MSBuild XML namespace. If the project is authored in the MSBuild 2003 format

Same issue here!

I have the same problem on a private agent when building a netstandard1.5 csproj project.
The build machine has VS2017 installed.

I changed the agent "Hosted VS2017" inside VSTS. And it worked!

I'm also getting the same error in VS2017 using wix 311
Windows Installer XML Toolset Toolset Harvester version <IP_ADDRESS>07
Copyright (c) .NET Foundation and contributors. All rights reserved.

heat.exe(0,0): error HEAT5305: Failed to load project xxx.csproj: The default XML namespace of the project must be the MSBuild XML namespace. If the project is authored in the MSBuild 2003 format, please add xmlns="http://schemas.microsoft.com/developer/msbuild/2003" to the  element. If the project has been authored in the old 1.0 or 1.2 format, please convert it to MSBuild 2003 format.
Done building project "xxx.wixproj" -- FAILED.

I am having same issue, however I am using Bamboo for deployment activities and not Team Foundation.

I was having this error message while trying to automate build and tests in Appveyor. I could not find so many articles on internet as I would like to. But I managed to fix this Error MSB4041 after reading this post. I had to export site a yaml file at Appveyor, then after tweeking locally this yaml file with image: Visual Studio 2017, I have uploaded it to Github again. Now the automated build and tests are working with dotnet core (.NETCoreApp 1.1):
version: 1.0.{build}
image: Visual Studio 2017
#dotnet_csproj:
  #patch: true
  #file: '**\*.csproj'
  #version: '{version}'
  #package_version: '{version}'

before_build:
- cmd: >-
    dotnet restore

    nuget restore

build:
  publish_nuget: true
  publish_nuget_symbols: true
  include_nuget_references: true
  verbosity: minimal

test_script:
- cmd: dotnet test ./SOLIDPrinciples.XUnitTest/SOLIDPrinciples.XUnitTest.csproj

after_build:
- cmd: dotnet pack ./SOLIDPrinciplesAsyncWebApi/SOLIDPrinciplesAsyncWebApi.csproj --configuration Release

artifacts:
- path: '**/*.nupkg'

attempting to build a barebones .net core console project with jenkins and getting this:

The default XML namespace of the project must be the MSBuild XML namespace. If the project is authored in the MSBuild 2003 format


Conversion Leaving blank csv

I appreciate this add on but when I use it gives me a blank CSV
20230111.csv

Seems like it's an issue with the Source data, some OS format misleadings (like date/time/currency format inconsistancy with NT generated csv file), or Storage issues (write file access, low storage data, etc.).
Try an another test data sources to exclude OS settings reasons.
Unfortunatelly the description or any details of the used internal NT functions are missed.


Check 'reviewer' instead of 'assignee'

Github has added the reviewer field for PR. It would be interesting if the plugin checks this field too.
The question is, what do we do with the assignee field?

Check both fields and merge the counter?
Count assignee and reviewers separately?
Check both fields and count without merging assignee and reviewer?
Just count reviewers?

Close due to inactivity


Teal primary button fails accessibility contrast check

In setting up accessibility specs on Colorado, I ran into a contrast-related failure on primary buttons in teal (.button--primary). Currently the buttons look like this (and have a ratio of 3.44):

The middle button is the one failing our contrast tests at the moment, though suspect at least the smaller button is, as well.
Here's the page that describes the failure we experienced, and has some tools to try things out to improve the contrast: https://dequeuniversity.com/rules/axe/2.3/color-contrast?application=axeAPI

All merged in!


Feat(eos_designs): Support access_group_in/out under network services SVI configuration and SVI profiles natively

Change Summary
Add support for applying ip access-lists to SVIs and SVI profiles in eos_designs network services natively.
Related Issue(s)
Fixes #3448
Component(s) name
arista.avd.eos_designs
Checklist
Repository Checklist

[x] My code has been rebased from devel before I start
[x] I have read the CONTRIBUTING document.
[x] My change requires a change to the documentation and documentation have been updated accordingly.
[x] I have updated molecule CI testing accordingly. (check the box if not applicable)

This is not really addressing the ask in the issue. As noted by the requester, adding the ACLs under the interface works fine with structured config, but what he really wants is to only configure the ACLs themselves on devices with an SVI using that ACL. I suggest to get some inspiration and reuse from #3750 which was merged recently.
This means the global definition of ACLs under ipv4_acls will not configure the ACLs "blindly", but only when referenced on something used by this device.

Invalid PR


[phpcs] Rules error

Bug description
Bug appears in production environment, when I try to upload phpcs report. Error log looks like this:
uwsgi_1         | [13/May/2021 08:57:08] ERROR [dojo.engagement.views:614] argument of type 'NoneType' is not iterable
uwsgi_1         | Traceback (most recent call last):
uwsgi_1         |   File "./dojo/engagement/views.py", line 602, in import_scan_results
uwsgi_1         |     close_old_findings=close_old_findings)
uwsgi_1         |   File "./dojo/importers/importer/importer.py", line 254, in import_scan
uwsgi_1         |     now=now)
uwsgi_1         |   File "./dojo/importers/importer/importer.py", line 88, in process_parsed_findings
uwsgi_1         |     item.save(dedupe_option=False)
uwsgi_1         |   File "./dojo/models.py", line 2150, in save
uwsgi_1         |     do_apply_rules(self, *args, **kwargs)
uwsgi_1         |   File "./dojo/utils.py", line 390, in do_apply_rules
uwsgi_1         |     if rule.match_text in getattr(new_finding, rule.match_field):
uwsgi_1         | TypeError: argument of type 'NoneType' is not iterable

There is no such problem on testing environment with fresh database.
UPD. It is problem with rules framework. When i delete my rules, problem was solved.
Steps to reproduce
Steps to reproduce the behavior:

Get phpcs report file
Try to upload it

Environment information

DefectDojo 1.15.0

what rules did you put in place?

I completely remove them, to make phpcs parser works

thanks for the details @true-hero . Sadly, I don't know very well this part (rules). :/


How do I get values out of a batch?

Hi.
Suppose I have a slice of string objects and I want to batch process them, pacing the result of each function call into a second slice. How would I do that?
Thanks in advance.

One possibility is to have the Processor implementation contain the slice, and the Process method can append to the slice. Keep in mind, though, that Process can be called concurrently so you'll need to have the append operation protected with some kind of synchronization primitives.
Originally I had planned to build support for chaining together multiple processors, by having the processor output the new values. However, it's not implemented right now and I didn't have a plan for retrieving the values directly. This would be a good addition if I can come up with a clean way to do so and have some time to implement it.

@MasterOfBinary Hello. Any idea how to return the result of the Process function can somehow use ps.Output <- lastItem
I am reading messages from kafka and I need to do a commit/ask if the data was processed successfully


os/signal: Notify doesn't catch signals when connecting os.Stdin to a subcommand

In some cases node Docker containers do not exit when you press ^C. I am writing a tool that starts these Docker containers, and want to catch the ^C and kill the program manually. The problem is just that once I connect the subcommands stdin with cmd.Stdin = os.Stdin, I do not get notified of ^C anymore.
I tried to reproduce the Docker behavior with a small Go program by catching signals and ignoring them, but that attempt was unsuccessful. This is why the reproducer is using Docker.
What version of Go are you using (go version)?
go version go1.8.1 darwin/amd64
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/mbertschler/go:/Users/mbertschler/wcd/go"
GORACE=""
GOROOT="/usr/local/Cellar/go/1.8.1/libexec"
GOTOOLDIR="/usr/local/Cellar/go/1.8.1/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/d0/zv0zzgf90r9bds00x6rm_qbr0000gn/T/go-build584631438=/tmp/go-build -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="1"
PKG_CONFIG="pkg-config"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"

What did you do?
https://play.golang.org/p/GQ1YHd2Af-
package main

import (
	"fmt"
	"os"
	"os/exec"
	"os/signal"
)

func main() {
	ForceQuitter()
	Run("docker", "run", "--rm", "-it", "node:latest")
}

func ForceQuitter() {
	c := make(chan os.Signal, 1)
	signal.Notify(c, os.Interrupt)
	go func() {
		<-c
		fmt.Println("[SIGINT force quit]")
		os.Exit(0)
	}()
}

func Run(name string, args ...string) error {
	cmd := exec.Command(name, args...)
	cmd.Stderr = os.Stderr
	cmd.Stdout = os.Stdout
	cmd.Stdin = os.Stdin
	return cmd.Run()
}

What did you expect to see?
$ signalkiller
> [SIGINT force quit]

What did you see instead?
To exit the node prompt you have to press ^C twice, but with this code it should exit immediately after the first one.
$ signalkiller
>
(To exit, press ^C again or type .exit)
>

If I understand correctly, what you want to do here is to capture the interrupt request of the program.
The reason(I think) why you can't capture it is the -it argument. When you use that, the docker process needs to "steal away" all std inputs and outputs to be interactive, so your Go program is not in control anymore.
This isn't an issue with the os/signal package. To prove that, let me show you an example.
Imagine you have this go program that only says hi every 20 milliseconds
// Suppose we build this into a binary "hi"
package main

import (
	"fmt"
	"time"
)

func main() {
	for {
		fmt.Println("HI!")
		time.Sleep(20 * time.Millisecond)
	}
}

Then we modify your program a bit to be:
package main

import (
	"fmt"
	"os"
	"os/exec"
	"os/signal"
)

func main() {
	c := make(chan os.Signal, 1)
	signal.Notify(c, os.Interrupt)
	go func() {
		<-c
		fmt.Println("[SIGINT force quit]")
		os.Exit(0)
	}()
	err := Run()
	fmt.Println(err)
}

func Run() error {
	cmd := exec.Command("./hi")
	cmd.Stderr = os.Stderr
	cmd.Stdout = os.Stdout
	cmd.Stdin = os.Stdin
	return cmd.Run()
}

If you run this, you'll see that os/signal is able to read the interrupt signal and print [SIGINT] force quit] so the package is successfully catching signals when the std inputs and outputs are connected to a subcommand.
In conclusion, the issue seems to be with how the docker run -it command works. What do you think? :)

/cc Mr. Signals @ianlancetaylor

Let's not all start calling me Mr. Signals....

I don't know much about docker, but @matipan 's comment looks plausible to me.  I'm going to close this issue, since it doesn't seem that there is anything we can do to fix it in Go.  @mbertschler please comment if you disagree.


build error under conda on Windows 7

I am trying to use pip to install pyhacrf under conda on Windows 7 and it is giving me the following error. Any help with a work around would be greatly apprecieated.
C:\Users\User\AppData\Local\Continuum\Anaconda>pip install pyhacrf
Collecting pyhacrf
  Using cached pyhacrf-0.0.12.tar.gz
Requirement already satisfied (use --upgrade to upgrade): numpy>=1.9 in c:\users\User\appdata\local\continuum\anaconda\lib\site-p
ackages (from pyhacrf)
Requirement already satisfied (use --upgrade to upgrade): PyLBFGS>=0.1.3 in c:\users\User\appdata\local\continuum\anaconda\lib\si
te-packages (from pyhacrf)
Building wheels for collected packages: pyhacrf
  Running setup.py bdist_wheel for pyhacrf
  Complete output from command C:\Users\User\AppData\Local\Continuum\Anaconda\python.exe -c "import setuptools;__file__='c:\\user
s\\User\\appdata\\local\\temp\\pip-build-rojt7c\\pyhacrf\\setup.py';exec(compile(open(__file__).read().replace('\r\n', '\n'), __f
ile__, 'exec'))" bdist_wheel -d c:\users\User\appdata\local\temp\tmpqnoh1dpip-wheel-:
  running bdist_wheel
  running build
  running build_py
  creating build
  creating build\lib.win-amd64-2.7
  creating build\lib.win-amd64-2.7\pyhacrf
  copying pyhacrf\feature_extraction.py -> build\lib.win-amd64-2.7\pyhacrf
  copying pyhacrf\pyhacrf.py -> build\lib.win-amd64-2.7\pyhacrf
  copying pyhacrf\state_machine.py -> build\lib.win-amd64-2.7\pyhacrf
  copying pyhacrf\__init__.py -> build\lib.win-amd64-2.7\pyhacrf
  running build_ext
  Looking for python27.dll
  building 'pyhacrf.algorithms' extension
  C compiler: gcc -m64 -g -DNDEBUG -DMS_WIN64 -O2 -Wall -Wstrict-prototypes

  creating build\temp.win-amd64-2.7
  creating build\temp.win-amd64-2.7\Release
  creating build\temp.win-amd64-2.7\Release\pyhacrf
  compile options: '-D__MSVCRT_VERSION__=0x0900 -IC:\\Users\\User\\AppData\\Local\\Continuum\\Anaconda\\lib\\site-packages\\numpy
\\core\\include -IC:\Users\User\AppData\Local\Continuum\Anaconda\lib\site-packages\numpy\core\include -IC:\Users\User\AppData\
Local\Continuum\Anaconda\include -IC:\Users\User\AppData\Local\Continuum\Anaconda\PC -c'
  gcc -m64 -g -DNDEBUG -DMS_WIN64 -O2 -Wall -Wstrict-prototypes -D__MSVCRT_VERSION__=0x0900 -IC:\\Users\\User\\AppData\\Local\\Co
ntinuum\\Anaconda\\lib\\site-packages\\numpy\\core\\include -IC:\Users\User\AppData\Local\Continuum\Anaconda\lib\site-packages\nu
mpy\core\include -IC:\Users\User\AppData\Local\Continuum\Anaconda\include -IC:\Users\User\AppData\Local\Continuum\Anaconda\PC
-c pyhacrf/algorithms.c -o build\temp.win-amd64-2.7\Release\pyhacrf\algorithms.o
  Found executable C:\Users\User\AppData\Local\Continuum\Anaconda\Scripts\gcc.bat
  gcc -m64 -g -shared build\temp.win-amd64-2.7\Release\pyhacrf\algorithms.o -LC:\\Users\\User\\AppData\\Local\\Continuum\\Anacond
a\\lib\\site-packages\\numpy\\core\\lib -LC:\Users\User\AppData\Local\Continuum\Anaconda\libs -LC:\Users\User\AppData\Local\Co
ntinuum\Anaconda\PCbuild\amd64 -lnpymath -lpython27 -lmsvcr90 -o build\lib.win-amd64-2.7\pyhacrf\algorithms.pyd
  Warning: .drectve `/manifestdependency:"type='win32' name='Microsoft.VC90.CRT' version='9.0.21022.8' processorArchitecture='amd64'
 publicKeyToken='1fc8b3b9a1e18e3b'" /DEFAULTLIB:"python27.lib" /DEFAULTLIB:"MSVCRT" /DEFAULTLIB:"OLDNAMES" ' unrecognized
  Warning: .drectve `/manifestdependency:"type='win32' name='Microsoft.VC90.CRT' version='9.0.21022.8' processorArchitecture='amd64'
 publicKeyToken='1fc8b3b9a1e18e3b'" /DEFAULTLIB:"python27.lib" /DEFAULTLIB:"MSVCRT" /DEFAULTLIB:"OLDNAMES" ' unrecognized
  C:\\Users\\User\\AppData\\Local\\Continuum\\Anaconda\\lib\\site-packages\\numpy\\core\\lib/npymath.lib(build/temp.win-amd64-2.7
/build/src.win-amd64-2.7/numpy/core/src/npymath/npy_math.obj):(.text+0x2e3): undefined reference to `__imp_modff'
  collect2.exe: error: ld returned 1 exit status
  error: Command "gcc -m64 -g -shared build\temp.win-amd64-2.7\Release\pyhacrf\algorithms.o -LC:\\Users\\User\\AppData\\Local\\Co
ntinuum\\Anaconda\\lib\\site-packages\\numpy\\core\\lib -LC:\Users\User\AppData\Local\Continuum\Anaconda\libs -LC:\Users\User\
AppData\Local\Continuum\Anaconda\PCbuild\amd64 -lnpymath -lpython27 -lmsvcr90 -o build\lib.win-amd64-2.7\pyhacrf\algorithms.pyd" fai
led with exit status 1

  ----------------------------------------
  Failed building wheel for pyhacrf

Reading this it looks like the problem is in /npy_math.obj
  C:\\Users\\User\\AppData\\Local\\Continuum\\Anaconda\\lib\\site-packages\\numpy\\core\\lib/npymath.lib(build/temp.win-amd64-2.7
/build/src.win-amd64-2.7/numpy/core/src/npymath/npy_math.obj):(.text+0x2e3): undefined reference to `__imp_modff'

Can you look for help from conda on this?

This suggests that maybe it's a problem in a missing math library: http://www.pgroup.com/userforum/viewtopic.php?t=4031&sid=35ae77e42eac59d17a3d8a16e2e9e6c7

I'm having difficulties with my windows VM so can't immediately try to reproduce. Do you get the same with Python 3?

On a clean Windows 7 I installed Anaconda-2.3.0-Windows-x86_64, then VCForPython27 and then pip install pyhacrf without any problems :/

Hmm, I didn't know about '''VCForPython27''' until your comment, and I tried installing that, but I'm still getting the same error.
I've tried three or four of the solutions on: http://stackoverflow.com/questions/26140192/microsoft-visual-c-compiler-for-python-2-7, but in every case I am still getting the same error referencing the same gcc command.
I have tried running the pip install command from the Anaconda terminal, the Visual C++ 2008 64-bit Command Prompt, and CMD.exe.
Is it possible that numpy has to be compiled using VCForPython27?

@Shotgunosine it looks like you are using gcc not msvc, no?

@fgregg That's what pip keeps defaulting to. How can I force it to use MSVC?

Well, I would consider it a bug that pyhacrf won't compile under windows with gcc I'm not sure the bug is in pyhacrf.
In general, look at this thread for how to change compilers.

I think the link didn't post correctly?

https://github.com/pypa/pip/issues/18

Alright, going to the directory and manually calling:
'''python setup.py build --compiler=msvc'''
Seems to work, though it produces the following message:
'''No module named msvccompiler in numpy.distutils; trying from distutils'''
I am able to import pyhacrf, but when I try to run the example code, I get the following error:
'''In [17]: model.fit(training_X_extracted,training_y)
Exception ValueError: "Buffer dtype mismatch, expected 'long' but got 'long long'" in 'lbfgs._lowlevel.call_eval' ignored
In [18]: predictions = model.predict(training_X_extracted)
In [19]: print(confusion_matrix(training_y,predictions))
[[0 3]
[0 2]]
In [20]: print(model.predict_proba(training_X_extracted))
[[ 0.5  0.5]
[ 0.5  0.5]
[ 0.5  0.5]
[ 0.5  0.5]
[ 0.5  0.5]]
'''
So it builds and installs, but doesn't seem to be working correctly, maybe an error with the lbfgs installation?

No, I think it may be related to this https://github.com/scikit-learn/scikit-learn/issues/1709

which we would fix in pyhacrf

Cool glad you can compile it. Cannot reproduce the Exception however. @fgregg can you reproduce it?

No, but I don't have a VM for windows handy.
On Mon, Sep 14, 2015 at 9:40 AM, dirko<EMAIL_ADDRESS>wrote:

Cool glad you can compile it. Cannot reproduce the Exception however.
@fgregg https://github.com/fgregg can you reproduce it?
—
Reply to this email directly or view it on GitHub
https://github.com/dirko/pyhacrf/issues/22#issuecomment-140101955.

--
773.888.2718

Ah okay I get the exception when running in the Anaconda IPython console, but not when running Python from the Command Prompt.

I'm glad you've been able to reproduce, I am getting the error both when I call it from python in cmd.exe and in an ipython console, but if you can reproduce it in IPython, hopefully you can track it down.
This is probably obvious to you, but by dropping in some 1/0 to break the fit call at various places I've narrowed it down to this line:
final_betas = optimizer.minimize(_objective_copy_gradient,
                                             x0=self.parameters.flatten(),
                                             progress=None)

In other words, the exception is not thrown if I break the code before I reach that line, but it is if I break right after that line.

Cool thanks @Shotgunosine. It seems that if we (in pyhacrf.py) change the dtype of index_array in _construct_sparse_features to 'int32', and states_to_classes in forward_backward also to int32 that it works. So I guess it has something to do with the default dtypes.
I'll have to investigate a bit further so get a fix that will work everywhere - don't have time today so will look at it again tomorrow.

It seems that it is because different platforms give different meanings to int and long etc.
Although fused types is a way around this in Cython, I'm rather going to specify int64 and float64 everywhere because I've had underflow problems with float32s previously.

Alright, let me know if you'd like me to test a new version after you make changes.

Cool so if you want to try it it is on the consistent-types branch.
(I'm also adding a pull request now)

Assuming I did everything correctly with git and installation, it seems like the changes do prevent the error from appearing, but I am still getting a different result from the example:
In [14]: print(confusion_matrix(training_y,predictions))
[[0 3]
 [2 0]]

In [15]: print(model.predict_proba(training_X_extracted))
[[ 0.94914812  0.05085188]
 [ 0.92397711  0.07602289]
 [ 0.86756034  0.13243966]
 [ 0.05438812  0.94561188]
 [ 0.02641275  0.97358725]]

That's because that code is out of date. You are getting what I'm getting

In that case everything seems to be working. I had to add zip_safe=False to the setup.py because for some reason I was unable to unzip the zipped egg into a temp directory without getting permissions errors. Won't be a problem for people who are installing via pip though.


Add some corrections made in #591

Overview
TL;DR

Correction of spelling/grammar mistakes of Spanish translation, closes #591 . With the exception of normbas>nombras because it was actually meant to be normas (rules).

@dpmex4527 this PR commits your suggested corrections.
@mberasategi I'll merge this in a day or two if we don't hear from @dpmex4527. I may also be able to get a few other Spanish-speaking folks to chime in.

@mberasategi good catch! I meant to suggest normas but it seems like I misspelled it. Oops!

OK @hectorsector and @dpmex4527 , the GitHub Desktop course is now completely translated into Spanish. Some considerations:

I have not been using GitHub Flow to translate these courses that teach GitHub Flow :persevere: , so this pull request is now a mess. Sorry about that! I promise to create a specific branch for future course translations :innocent:
I would say the use of bold, 'apostrophes' and inline-code-style (even some italics if I recall correctly) to signify buttons, menu options, tabs, form fields etc. is not consistent. This would be a huge and boring task, but there it is. The same with capital letters for git commands like pull request or Pull Request, push and Push, etc.

Let me know about the translation, and hope students can see it live soon!

You're on a roll, @mberasategi! 🎉
I brought in the most recent changes from master, and changed the structure around to use improvements we shipped in #593.
@mberasategi @github/services-training could you put some 👀 on this? I can ship with a couple of 👍. It's staged for easier review.

I've checked and links work correctly. I've noticed some typos and
inconsistencies in names while I clicked on everything, will correct those
when I get a moment. Thanks!
El 28 sept. 2017 5:50 a. m., "Hector Alfaro"<EMAIL_ADDRESS>escribió:
You're on a roll, @mberasategi https://github.com/mberasategi! 🎉
I brought in the most recent changes from master, and changed the structure
around to use improvements we shipped in #593
https://github.com/github/training-kit/pull/593.
@mberasategi https://github.com/mberasategi @github/services-training
https://github.com/orgs/github/teams/services-training could you put some
👀 on this? I can ship with a couple of 👍. It's staged
https://hectorsector.github.io/training-kit/ for easier review.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/github/training-kit/pull/595#issuecomment-332720141,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAtGBzdq_4hWAkX-CyMH4xHNQFEXlrBNks5smxeEgaJpZM4PcH8q
.

Done. Someone else :eyes: for language, style etc.!

I've just created a gh-pages in my fork to change the config file and make it available to students while it goes live. Is this OK? Should I do it otherwise?

I've just created a gh-pages in my fork to change the config file and make it available to students while it goes live.

That should work for you! I'm only merging in what we've got on the master branch!

Thanks for the submission, @mberasategi! Apologies that it took me so long to merge it in. I was giving folks some time to review it. 🚢ing!


Qwik 0.1 Beta Iteration planning

Qwik 0.1 Beta
Checklist

[ ] All public APIs documented
[x] Collect and ship all pending breaking changes
[x] Review and split all APIs between stable and alpha
[x] Most used APIs are stable
[ ] Feature freeze
[ ] Plan Roadmap to 1.0
[ ] Doc site big review
[ ] Check minimum requirements (node, npm, yarn, osx, windows...)
[ ] Check not major open issues
[ ] Clean github issues
[ ] Green light from core team
[ ] Green light from community
[ ] Write blog post
[ ] Prepare social media
[ ] Schedule small event
[ ] Verify all starters with all server

[ ] Check actual deployment in all servers (express, cloudflare, netlify)
[ ] Check npm start, npm run dev.ssr, npm run build and npm run lint

Requirements

Follow semver for new features, raising minor.
Next announcement is 1.0-rc0
Clear expectations
Usable for production
Happy path works great (windows, linux, mac)
Breaking changes still possible, but not massive
Like all software, bugs are expected but minor
Cloudflare, netlify, express servers work great

YES!

Possible API changes
Different prefix of useScopedStyles$()
Currently:

useStyles
useScopedStyles

Proposal:

useStyles
useStylesScoped

Benefits, autocompletion in IDEs will help discover the styling apis.
useUserContext()
Name does not reflect what it is, approved renamed to useEnvData()
useWatch, useClientEffect first argument
This two APIs get the tracker as first argument, while useResource$() returns a object.
useResource API is more future proof, and it's the prefered by the core team and community, should we update useWatch and useClientEffect for consistency?
QwikCity
Does not reflect well what it is, approved rename to <RouterOutlet />

useUserContext() renamed to useEnvData() https://github.com/BuilderIO/qwik/commit/13a81d3eaf1920dbc7ef188e92d676ef70dbd90f
<Content/> renamed to <RouterOutlet/> https://github.com/BuilderIO/qwik/commit/34887e79bd1e705a9816c731d979bb77af2363f1

Major public API review: https://github.com/BuilderIO/qwik/pull/916/files

https://github.com/BuilderIO/qwik/pull/912

useScopedStyles() -> useStylesScoped()
useWatch$((track) => {}) -> useWatch$(({track}) => {})
useClientEffect$((track) => {}) -> useClientEffect$(({track}) => {})
useServerMount$(): Resource<> -> useServerMount$(): void
useMount$(): Resource<> -> useMount$(): void

Design decision for <Host>:
https://github.com/BuilderIO/qwik/issues/930

Removing useDocument()?
https://github.com/BuilderIO/qwik/issues/1074
Discussion needed

Qwik is great. I like it very much

We did it! closing issue!

Great job everyone! 👏👏👏


Logger

A learning goal for in creating this API, is also to utilize a logger service in the C#, as a way to ensure proper error handling, and to monitor the expected behavior.
The implementation will probably be with Ilogger interface usually already applied in the solution.

I wasnt aware that this comes of the box in webapi solutions in dotnet, and is very easy to use, dependency inject it into the constructer and define the loglevel for the log messages, and in the appsettings it can be specified which level of logs should be shown.


caniuse.com is broken after search (cache issue)

Once you try searching something errors are thrown during rendering of results and sites becomes unresponsive:
Uncaught TypeError: Cannot read property 'isShown' of undefined
    at s.getShownOldVersionCount (base-browser-view.js:177)
    at s.handleShownChange (feature-support-view.js:259)
    at s.resetShown (feature-support-view.js:197)
    at setViewMode (feature-support-view.js:115)
    at s.makeSupportView (feature-view.js:450)
    at s.renderContents (feature-view.js:88)
    at s.handleLoaded (feature-view.js:49)
    at s.emitEvents (stapes.min.js:2)
    at s.emit (stapes.min.js:2)
    at s.initFullData (feature-model.js:35)

Also, got this one before, shouldn't be related, but why is the site querying my info??:
Failed to load resource: the server responded with a status of 429 ()

Many thanks!
~Y

@Fyrd seems to be fixed after cache clean, you might want to revisit your cache policies, probably some of your JS is being cached longer than the rest, or the HTML.

Good point, I'll look into that!

Yeah, i've had issues several times that were fixed by a cache clean, or just waiting a day :)

@Fyrd great! Keeping this as a reminder, you can close if you wish.

This issue should no longer occur since the recent client side update, so closing.

@Fyrd This has actually started to happen more frequently for me since the update. It might not be the exact same error, but it has the same effect. I can try to collect some error logs if you are interested.

@atjn Ah, sorry to hear that. Curious as to what's going on, so yeah error logs would be great! Have re-opened the issue.

Alright, I have spent some time trying to isolate the error. There are many different ways to make the UI fail, but I found a very reliable way to do it:

Open caniuse.com
Write anything into the search bar, and wait a second to let it process (examples: "avif", "flex", "fghgdfhjdfg")
Delete what's in your search bar, and wait for the UI to show the home screen again
Write a second search term into the search bar (this has to be a term that would return a result, and it has to be different from the first search result; examples: "webp", "css", "es6")
Observe that nothing happens, and that a JS error is logged to your console

This happens in different (modern) versions of Firefox/Chrome with/without devtools open, on a fresh/old version, with/without extra plugins installed. It doesn't seem like the client browser has any effect on whether the error happens or not.
Here are some of the errors i was able to create. They change depending on how you break caniuse and which client you are using:
parts.ts:238 Uncaught TypeError: Cannot read property 'nodeType' of null
    at h._commitText (parts.ts:238)
    at h.commit (parts.ts:201)
    at n.update (template-instance.ts:53)
    at h._commitTemplateResult (parts.ts:254)
    at h.commit (parts.ts:204)
    at a (render.ts:56)
    at Object.Te (search.module.ts:118)
    at Object.n [as publish] (mediator.ts:25)
    at Object.success (search.module.ts:175)
    at XMLHttpRequest.r.onreadystatechange (utils.ts:84)

parts.ts:238 Uncaught TypeError: Cannot read property 'nodeType' of null
    at h._commitText (parts.ts:238)
    at h.commit (parts.ts:201)
    at n.update (template-instance.ts:53)
    at h._commitTemplateResult (parts.ts:254)
    at h.commit (parts.ts:204)
    at a (render.ts:56)
    at Object.Te (search.module.ts:118)
    at Object.n [as publish] (mediator.ts:25)
    at HTMLInputElement.Se (search.module.ts:162)
    at utils.ts:139

dom.ts:58 Uncaught TypeError: Cannot read property 'nextSibling' of null
    at n (dom.ts:58)
    at h.clear (parts.ts:318)
    at h._commitNode (parts.ts:229)
    at h._commitTemplateResult (parts.ts:264)
    at h.commit (parts.ts:204)
    at a (render.ts:56)
    at Object.Te (search.module.ts:118)
    at Object.n [as publish] (mediator.ts:25)
    at Object.success (search.module.ts:175)
    at XMLHttpRequest.r.onreadystatechange (utils.ts:84)

dom.ts:58 Uncaught TypeError: Cannot read property 'nextSibling' of null
    at n (dom.ts:58)
    at h.clear (parts.ts:318)
    at h._commitNode (parts.ts:229)
    at h._commitTemplateResult (parts.ts:264)
    at h.commit (parts.ts:204)
    at a (render.ts:56)
    at Object.Te (search.module.ts:118)
    at Object.n [as publish] (mediator.ts:25)
    at HTMLInputElement.Se (search.module.ts:162)
    at utils.ts:139

Uncaught TypeError: t is null
    _commitText parts.ts:237
    commit parts.ts:201
    update template-instance.ts:53
    _commitTemplateResult parts.ts:254
    commit parts.ts:204
    a render.ts:56
    Te search.module.ts:118
    n mediator.ts:25
    success search.module.ts:175
    onreadystatechange utils.ts:84
    m utils.ts:80
    Se search.module.ts:165
    i utils.ts:139
    setTimeout handler*x/< utils.ts:143
    listen dom.js:57
    Ae search.module.ts:204
    init search.module.ts:254
    <anonymous> index.js:34

Thanks @atjn for finding that issue! I was able to reproduce the bug, turns out it was a lit-element error that got fixed in a recent update, so updating that library appears to have also fixed the issue. Let me know if it fixed it for you as well and I think I'll be able to close this.

@Fyrd awesome! Judging from a quick test, it seems to have solved the issue on my end as well. If I encounter an edge case that isn't fixed, i'll just open a new bug, so feel free to close this one :)


The image file's height is over when the image is big size

Before you submit:

[x] Please search through the existing issues (both open AND closed) to see if your question has already been discussed. Github issue search can be used for this: https://github.com/imgix/luminous/issues?utf8=✓&q=is%3Aissue

Question
The image file's height is over the window's height when the image is big size in google chrome and edge browsers.
Do you have any plans to deal with this?

Hi @Haduki029 👋 thank you for the issue.
It's hard to understand this specific problem without a screenshot or a way to reproduce this issue. Do you think you could provide either of these? Thanks!

Hi @Haduki029 👋 thank you for the issue.
It's hard to understand this specific problem without a screenshot or a way to reproduce this issue. Do you think you could provide either of these? Thanks!

https://honeycomb.liftoff.shop/vertical-poster-print
Clicking on the product image on this page reproduces the issue.
This issue is present in the current (as of 13-8-21) versions of Chrome and Edge (appears to be Webkit/Blink related) under both Mac OS and Windows, but not present in Firefox or Safari under Mac OS.

Thanks for the repro, I can see the issue now.
The right solution here is probably to modernise the way the positioning happens in the Lightbox to use Flexbox. Unfortunately I don't think we will have time to prioritise this work internally for a while, but I will add this to the backlog to see what happens.
Alternatively, a quick fix for your situation would be to set display to block for .lum-lightbox-image-wrapper. As code that would look like this:
.lum-lightbox-image-wrapper {
  display: block !important;
}

I am hesitant to blindly update this library with this change since a) it will probably break in IE, and b) I would need to do some other cross-browser testing.
Let me know how this goes for you. Also, if you would like to submit a PR reworking this positioning to use Flexbox, or updating this CSS and doing some testing in evergreen browsers, I would gladly accept it. Thanks!

Hi, @frederickfogerty
Thank you for fast responsive and your alternatively fix idea.
I will try it and let you know about result.

It worked on Chrome for me @frederickfogerty. Thanks! Depending on how you want it to behave on mobile though, when you click on the image, the image will go to full size. I just removed this from the CSS instead of adding display:block;
.lum-lightbox-inner img{max-width:none;max-height:none}

Not fully sure of the repercussions on other browsers, but it did the job for me

Closing this as there appears to be an adequate answer provided.


update this text file

Description
What does your pull request fix/improve?
Related Issue
If this pull request is related to an issue, state it.
Motivation and Context
What inspired you to to make these improvements? How will your changes improve the project?
Testing Procedure
The commits should be well tested before creating a pull request. How did you test this pull request?
Screenshots(if applicable)
Post the screenshots of your improvements in action.

The title need not be changed. It must be succinct.


Specify nodeSelector for restic DaemonSet

Hi there,
Is it possible to specify a nodeSelector for the Restic DS to use, similar to mig-operator (https://github.com/konveyor/mig-operator/blob/master/roles/migrationcontroller/templates/velero.yml.j2#L190)
On an OpenShift 4.7 cluster with dedicated infrastructure nodes (OpenShift Container Storage), the restic DS fails to fully roll out as it attempts to install on all non-master nodes.

This should be a simple change. Adding as a GA blocker. Any restic/velero customization that MTC supports OADP should support.


add bwrap Apprun

This is a try to create a new Apprun using bwrap and without doing chroot.
It needs bubblewrap to be installed on the machine that will run the AppImage.
It allows all files from the root folder to be visible inside the appimage. For example, vim can now load plugins or run LSP server installed outside the AppImage.
However, if /nix already exist on the computer, it will be replaced inside the bwrap sandbox by the /nix of the AppImage. So it's not meant to be used in nixos or any computer with nix already installed.
I didn't tested, but normally bwrap don't prevent to create user namespaces (related to #10 ), so you should be able to run chromium or any electron apps. However you may still need nixGL for opengl related things.
The apprun is written in bash and can probably be improved, I'm open to suggestions and thank you for your incredible project !

I'll have a proper review later, but for now:

It needs bubblewrap to be installed on the machine that will run the AppImage.

I would consider this a dealbreaker. You might be able to avoid this requirement by bundling bwrap by doing cp ${bubblewrap}/bin/bwrap $out/bwrap.

However, if /nix already exist on the computer, it will be replaced inside the bwrap sandbox by the /nix of the AppImage. So it's not meant to be used in nixos or any computer with nix already installed.

If you bind mount all the individual nix/store/* entries instead of just /nix you might be able to get around this? But you might hit argument count limits.

It needs bubblewrap to be installed on the machine that will run the AppImage.

I would consider this a dealbreaker. You might be able to avoid this requirement by bundling bwrap by doing cp ${bubblewrap}/bin/bwrap $out/bwrap.

Yes I agree. But don't we need to build bubblewrap statically to make it to work ? I just need to verify that bwrap don't need to install any setuid binary on the host. But it should be possible to overcome this requirement. I'll try this later

If you bind mount all the individual nix/store/* entries instead of just /nix you might be able to get around this? But you might hit argument count limits.

Yes it should work but I don't like this idea. The /nix/store can have hundreds of entries so it will probably cause a big performance hit in the best case. The solution for me should be to develop a fuse filesystem just for this usecase.
But honestly I'm not sure it's very interesting to fix this issue... I mean, if the /nix folder already exist, we should probably don't need bwrap at all and do a specific Apprun. Moreover, is there really a usecase of using this project if nix is installed yet on the target machine ?

Ah and I don't know if you looked to https://github.com/DavHau/nix-portable yet ? I didn't looked at the source code for now to make this PR, but they use similar techniques as I know

I just pushed a new commit to include a statically linked bwrap binary in the appimage. It should no longer be necessary to install bubblewrap on the target system. Please report if you experiment any bug.
I did nothing about the hidden nix/store issue in the appimage. You're still unable to run any nix program inside the appimage mount namespace. As stated before, I don't think it's a major issue as to my mind this project targets mainly systems where nix is not installed


Updated IPRiskList and added DomainRiskList

Recorded future has updated their API to V2, and will soon deprecate v1.
The IPRiskList class has been updated to v2, and a new class DomainRiskList, has also been added using the new V2 API

Hi @Jonas337,
thanks !
Couple of things before merging:
Could you add your name to the AUTHORS file ?
Could you also explicitly accept the Apache license ? ("I accept it" in a comment to this PR works :-))

I accept the apache license

Almost there !
Please, could you fix the following PEP8 formatting errors ?
$ flake8 minemeld/ft/recordedfuture.py
minemeld/ft/recordedfuture.py:127:44: W291 trailing whitespace
minemeld/ft/recordedfuture.py:130:61: W291 trailing whitespace
minemeld/ft/recordedfuture.py:131:1: E101 indentation contains mixed spaces and tabs
minemeld/ft/recordedfuture.py:131:1: W191 indentation contains tabs
minemeld/ft/recordedfuture.py:131:4: E131 continuation line unaligned for hanging indent
minemeld/ft/recordedfuture.py:132:1: W293 blank line contains whitespace
minemeld/ft/recordedfuture.py:132:1: E101 indentation contains mixed spaces and tabs
minemeld/ft/recordedfuture.py:159:1: E302 expected 2 blank lines, found 0
minemeld/ft/recordedfuture.py:239:44: W291 trailing whitespace
minemeld/ft/recordedfuture.py:242:65: W291 trailing whitespace
minemeld/ft/recordedfuture.py:243:1: E101 indentation contains mixed spaces and tabs
minemeld/ft/recordedfuture.py:243:1: W191 indentation contains tabs
minemeld/ft/recordedfuture.py:243:4: E131 continuation line unaligned for hanging indent
minemeld/ft/recordedfuture.py:244:1: W293 blank line contains whitespace
minemeld/ft/recordedfuture.py:244:1: E101 indentation contains mixed spaces and tabs
minemeld/ft/recordedfuture.py:272:1: W391 blank line at end of file

You can read here about MineMeld Coding Style (PEP8-ish):
https://github.com/PaloAltoNetworks/minemeld/wiki/Contributing-to-MineMeld#coding-style
Thanks!

Tested this and works. There are some changes to be made, but I will take care of them


Client only components with Vue 3

I wrote a little component that includes third party packages that cannot be rendered server side (midi-player-js and soundfont-player; they are using AudioContext and XMLHttpRequest). Following the docs the best way to solve this problem would be to use dynamic imports. So shouldn't it be enough to just use defineAsyncComponent because Vue wraps the component into a Promise?

<template>
    <MidiPlayer />
</template>

But if I use it like this the server still tries to render the component and throws XMLHttpRequest is not defined when running npm run dev. With a condition on the component to only render it in browser it still failes with AudioContext is not defined since the component gets loaded in SSR even if it's not displayed in the template.

<template>
    <MidiPlayer v-if="isBrowser" />
</template>

So I wrote a litte <ClientOnly> component:
// components/ClientOnly.js
import { h } from 'vue';

const isBrowser = typeof window !== 'undefined';

export default {
    setup(props, { slots }) {
        const slot = slots.default ? slots.default() : [];
        return () => (isBrowser ? h('div', {}, [slot]) : h('div'));
    },
};

This seems to work better but I get an error: Hydration completed but contains mismatches. Is there a way to prevent this from happening?
At the end the best way to do this for me was to add an additional component AsyncMidiPlayer:
// components/AsyncMidiPlayer.js
import { defineAsyncComponent, h } from 'vue';

const isBrowser = typeof window !== 'undefined';

const MidiPlayer = defineAsyncComponent(() => import('./MidiPlayer.vue'));

export default {
    setup(props, context) {
        return () => isBrowser ? h(MidiPlayer, {...props,...context.attrs,}): h('div');
    },
};

And to use it like this:

<template>
    <AsyncMidiPlayer  />
</template>

But since I have multiple components that cannot be interpreted server side I would like to have a better solution than writing a custom wrapper for each of them. I was not able to create a generic version of this because the import source needs to be specific (I ran into The above dynamic import cannot be analyzed by vite.). I'm sure there is a better solution for this. Did anyone find a better solution to this than me? It would be nice to extend the vite-plugin-ssr docs with a working vue 3 example.

I just came up with another idea:
// composables/useClientOnly.js
import { h, defineComponent } from 'vue';

const isBrowser = typeof window !== 'undefined';

export function useClientOnly(asyncComponent) {
    return defineComponent({
        setup(props, context) {
            return () => isBrowser ? h(asyncComponent, { ...props, ...context.attrs }) : h('div');
        }
    });
};

And use it on the page like this:

<template>
    <AsyncMidiPlayer />
</template>

Still I think that this is not the optimal solution for this problem.

I found another issue (https://github.com/egoist/vue-client-only/issues/122) that pointed me to the current ClientOnly component from Nuxt.js version 3:
https://github.com/nuxt/framework/blob/4e9a27257bdfae65403ea73116d8c5508b642f44/packages/nuxt3/src/app/components/client-only.mjs

<template>
    <ClientOnly>
        <MidiPlayer ref="midiPlayer" />
    </ClientOnly>
</template>

In my case it is important that I get access to the component as template ref to call an exposed method. So I really would prefer not to use an async component but instead a regular component in combination with a ClientOnly wrapper. Note that here I also need to use nextTick to get the template reference (see: https://github.com/egoist/vue-client-only/issues/50).
If I run vite build && vite build --ssr && vite-plugin-ssr prerender everything is perfectly fine and works finally as expected. But I still get an error when running node ./server/index.js:
[vite] Error when evaluating SSR module /node_modules/verovio-humdrum/index.js?v=2f51debf:
ReferenceError: __dirname is not defined

Any idea why it works fine with vite build but not with the development server?
This issue also is somewhat related when I tried to get it work with the useClientOnly.js composable that I posted before: https://github.com/vuejs/core/issues/2671

NB: My package.json setup or the vite-plugin-ssr prerender seem to be somewhat relevant for this. I simplified the examples above. But in my current setup I linked a plugin that I'm working on at the same time as file:../../vue-verovio-canvas in package.json:
{
    "dependencies": {
        "vue-verovio-canvas": "file:../../vue-verovio-canvas"
    }
}

Running vite-plugin-ssr prerender I get another error:
vite-plugin-ssr 0.3.59 pre-rendering HTML...
Error: Cannot find module 'verovio-humdrum'

But if I change this dependency to the GitHub repository instead of the local file link everything works just fine again:
{
    "dependencies": {
        "vue-verovio-canvas": "github:WolfgangDrescher/vue-verovio-canvas"
    }
}

The development server is still not running tough and still prints the same error as mentioned before:
[vite] Error when evaluating SSR module /node_modules/verovio-humdrum/index.js?v=2f51debf:
ReferenceError: __dirname is not defined

You mention a lot of issues at once, most(/all?) of them seem to be unrelated to vps.
But I agree a working example would be nice.
One thing you may want to try is import.meta.env.SSR, see https://vitejs.dev/guide/ssr.html#conditional-logic. That should ensure that SSR will not consider your component at all.

I've used the ClientOnly component from vitepress with no issues ClientOnly.ts

https://vitepress.vuejs.org/guide/global-component.html#clientonly
Thanks @DoubleJ-G.
I will update the docs. I'm leaving this open until I do.

A similar issue i found far quicker though was a similar issue for react though.
As such im linking to the PR for better observability.
https://github.com/brillout/vite-plugin-ssr/pull/488
A bit off topic:
I was about to open an issue myself for the lack of documentation. By sheer luck i found this issue though. Guess my search queries about dynamic imports were far off :).
I really enjoy vps a lot, albeit sometimes the documentation is too broad and concrete knowledge is documented on different pages (Especially irt the default Server // vite cli in combination with moving to ES6).
I will try the vitepress component soon. Thanks all involved!

I don't see the lack of documentation: I think https://vite-plugin-ssr.com/client-only-components and https://vite-plugin-ssr.com/dynamic-import covers it.

PR welcome to add a Vue example.

I'm unsure about my ability to provide a PR soon, but the current Statement of
UI Frameworks usually don't execute import() upon SSR (this is, for example, the case with React and Vue).
is untrue, as the code will be loaded in SSR mode. Especially, because the default renderer includes rendering everything to a string.
Using the Client Only Component does fix that issue though, but may make migration of an existing app (using a similar, but inferior Implementation of the renderer) somewhat more painful than these statements may make one believe.
It's by no means challenging.
Which is why, i linked the above issues together for better visibility :)

Updated:

https://vite-plugin-ssr.com/client-only-components
https://vite-plugin-ssr.com/dynamic-import

Better?

<template>
  <q-no-ssr>
        <YaMap />
  </q-no-ssr>
</template>

@KirillOlegovichH Up for creating a full example?

@KirillOlegovichH Up for creating a full example?

Обновил ответ. Пример применим только для Quasar framework 2. Прошу прощение что не уточнил сразу

Closing as it's mostly done. Contribution much welcome for a Vue example.

@yuanoook Added to the docs a7dfce543c899487c49d4e9b5138704271633089.
@WolfgangDrescher What did you end up with? I'm looking for a <ClientOnly> implementation that uses defineAsyncComponent().

Once Nuxt 3 was ready for production I started migrating to it. So I do not have an example for you with defineAsyncComponent, sorry.

Reply to:
I was excited to use this component as it makes so much sense and straight forward. I wrapped my HJ29/vue3-tabs as so:
      <ClientOnly>
        <Tabs v-if="!ssr" v-model="selectedTab">
          <Tab :val="'subject'" :label="'Subject'" :indicator="true"></Tab>
          <Tab :val="'courses'" :label="'Courses'" :indicator="true"></Tab>
        </Tabs>
        <TabPanels v-model="selectedTab" :animate="true">
          <TabPanel :val="'subject'">
            <form @submit.prevent="onSubmit()">

Make subject form

            </form>
          </TabPanel>
          <TabPanel :val="'courses'">

List courses

          </TabPanel>
        </TabPanels>
        <template #placeholder>

This is for SSR/SEO

        </template>
      </ClientOnly>

but unfortunately for some reason, the Tabs component (which reads document) is still run on server side despite the ClientOnly wrapping it which should prevent that from happening. BUT, if I comment out the whole thing and add some static html code to save and render on live reload, then uncomment, save and live reload, it magically works temporarily until you refresh the page. I don't know what's going on and I have no Idea how to debug it.
For now what I did for my vue component is utilize the *page.client.vue way of doing things. But this also presented an issue for me on my createSSRApp where I used vue markRaw. I get this Error: Object.defineProperty called on non-object and I happen to fix it with lodash:
 Page: _.isObject(pageContext.Page) ? markRaw(pageContext.Page) : pageContext.Page,

Pretty sure this is not the optimal/correct way of doing it but for now it works. Though I'm not happy with the warning sign of not having markRaw.
Here is the full context of the code. Need your insights on this:
async function onBeforeRender(pageContext: PageContextServer) {
  const { app, store } = createApp(pageContext);

  let err: unknown;
  // Workaround: renderToString_() swallows errors in production, see https://github.com/vuejs/core/issues/7876
  app.config.errorHandler = err_ => {
    err = err_;
  };

  // Reference: https://vite-plugin-ssr.com/stream
  const stream = renderToNodeStream(app);

  const initialStoreState = store.state.value;

  if (err) throw err;

  return {
    pageContext: {
      initialStoreState,
      stream,
    },
  };
}

import { App, createSSRApp, h, reactive, markRaw } from 'vue';

import { createMongoAbility } from '@casl/ability';
import { unpackRules } from '@casl/ability/extra';
import { abilitiesPlugin as casl } from '@casl/vue';

import { createPinia } from 'pinia';

import { setPageContext } from './usePageContext';
import { PageContext } from './types';

import { GuestLayout, InstructorLayout, StudentLayout } from '#root/layouts/index';
import _ from 'lodash';

export { createApp };

interface AppPageElement extends App<Element> {
  changePage: (pageContext: PageContext) => void;
}

function createApp(pageContext: PageContext) {
  let rootComponentContext: PageContext;
  console.log('TEST mark', pageContext.Page)
  const app = createSSRApp({
    data: () => ({
      Page: _.isObject(pageContext.Page) ? markRaw(pageContext.Page) : pageContext.Page,
      pageProps: markRaw(pageContext.pageProps || {}),
      Layout: markRaw(pageContext.exports.Layout || selectLayout(pageContext)),
    }),
    render() {
      const renderLayoutSlot = () => h(this.Page, this.pageProps || {});
      return h(this.Layout, {}, { default: renderLayoutSlot });
    },
    created() {
      rootComponentContext = this;
    },
  }) as AppPageElement;

  const store = createPinia();
  app.use(store);

  if (pageContext.ability) {
    try {
      const unpackedRules = unpackRules(pageContext.ability);
      const ability = createMongoAbility(unpackedRules as any); // FIXME: lazy bypass
      app.use(casl, ability, {
        useGlobalProperties: true,
      });
    } catch (e) {
      console.error('Failed to unpack ability. Error:\n', e);
    }
  }

  // We use `app.changePage()` to do Client Routing, see `_default.page.client.js`
  Object.assign(app, {
    changePage: (pageContext: PageContext) => {
      Object.assign(pageContextReactive, pageContext);
      rootComponentContext.Page = markRaw(pageContext.Page);
      rootComponentContext.pageProps = markRaw(pageContext.pageProps || {});
    },
  });

  // When doing Client Routing, we mutate pageContext (see usage of `app.changePage()` in `_default.page.client.js`).
  // We therefore use a reactive pageContext.
  const pageContextReactive = reactive(pageContext);

  setPageContext(app, pageContextReactive);

  return { app, store };
}

function selectLayout(pageContext: PageContext) {
  switch (pageContext.user?.role) {
    case 'instructor':
      return InstructorLayout;
    case 'student':
      return StudentLayout;
    default:
      return GuestLayout;
  }
}

I am not sure how to also add what to render on server side for SEO similar to the feature of the ClientOnly component on the #placeholder slot. I tried adding an index.page.server.vue alongside the index.page.client.vue but what it does is that it ignores the .client.vue component entirely and just uses the other one.


Support for weather overlay for a mixed metric/US custom unit household

Hi!
Would it be possible to allow for more weather units to be displayed on the overlay? I like °C, but my partner wants the wind speed in mph. This doesn't seem to be an option.
Better still would be being able to display both °C and °F on the same overlay, but that's not nearly as important as the mph wind speed option.
Thanks!

@chrisjrn sorry for the late reply, this should be possible, I need to rework a bit the weather overlays and will make a note to fit that in.

Seconding the request. Is this going to happen? Thank you.


Add ROSA Benchmark Key Results

Closes #432

@mhajas - ready for a (final?) review. If it is ok now, please merge. Thanks!


RFC: breaking release -- remove JuMP from tests and bump versions

I went for the nuclear option, and dropped Julia 0.6 and JuMP 0.18 testing (although MPB) is still there. Testing MPB requires that we keep JuMP 0.18 which isn't great. Moreover, the MOI solver goes through almost all the same code-paths, so the MINLPTests should comprehensively catch most cases.
Closes #86

Codecov Report

Merging #87 into master will decrease coverage by 4.1%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #87      +/-   ##
=========================================
- Coverage   83.91%   79.8%   -4.11%
=========================================
  Files           5       5
  Lines         858     842      -16
=========================================
- Hits          720     672      -48
- Misses        138     170      +32

Impacted Files
Coverage Δ

src/AmplNLWriter.jl
72.18% <100%> (-6.41%)
:arrow_down:

src/nl_linearity.jl
72.53% <0%> (-10.69%)
:arrow_down:

src/nl_write.jl
89.2% <0%> (-1.51%)
:arrow_down:

src/nl_convert.jl
98.48% <0%> (-0.03%)
:arrow_down:

src/MOI_wrapper.jl
85.14% <0%> (+1.71%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0aaad31...09dcbea. Read the comment docs.

It's actually less breaking that I originally thought it was going to be. I did wonder about removing/deprecating all of the XXXNLSolver functions, and deprecate the exported getxxx functions.


[BEAM-11715] [cherry-pick] Add ValidatesRunner test for translations.pack_combiners

Add an integration test using TestPipeline with packable combiners. Combiner packing will be triggered if and only if the TestPipeline runner enables it.
Cherry-pick of #13851.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @chamikaramj

Run Python_PVR_Flink PreCommit

"Run Python PreCommit" failure is unrelated (Dataflow workers are not available yet)


Failures in the Openzeppelin Contracts repo

Steps to reproduce:

Check out https://github.com/OpenZeppelin/openzeppelin-contracts at the latest master branch
Check out edr/main
Change the hardhat dependency to latest hardat-core version in edr/main`
Run npx hardhat test --grep "Access"

Expected result
The tests pass.
Actual result
13 tests hang and there is one failure:
14 failing

  1) AccessControlEnumerable
       revoking
         roles that are not had can be revoked:

      AssertionError: expected true to be false
      + expected - actual

      -true
      +false

      at Context.<anonymous> (test/access/AccessControl.behavior.js:55:67)

  2) AccessManager
       admin operations
         subject to a delay
           #labelRole
             restrictions
               when the call comes from the manager (msg.sender == manager)
                 when _executionId is in storage for target and selector
                   succeeds:
     Error: Timeout of 40000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/ubuntu/dev/openzeppelin-contracts/test/
access/manager/AccessManager.test.js)
      at listOnTimeout (node:internal/timers:573:17)
      at processTimers (node:internal/timers:514:7)

Definition of done
npx hardhat test passes in the OpenZeppelin contracts repo in EDR mode.

All issues are fixed with https://github.com/NomicFoundation/hardhat/pull/4890


git repo corrupted ? Unable to Install npm chalk package

environment: node 6.9.3
npm 3.10.10
npm ERR! git rev-list -n1 c2ccee1b61a585c5f4fca00da8f79cc1db37048b: fatal: bad object c2ccee1b61a585c5f4fca00da8f79cc1db37048b
npm ERR! git rev-list -n1 c2ccee1b61a585c5f4fca00da8f79cc1db37048b:

Below are a snapshot of my shrinkwrap, chalk is a dependency from boxen
    "boxen": {
      "version": "1.2.0",
      "from"<EMAIL_ADDRESS>      "dev": true,
      "dependencies": {
        "ansi-regex": {
          "version": "3.0.0",
          "from"<EMAIL_ADDRESS>          "dev": true
        },
        "ansi-styles": {
          "version": "3.1.0",
          "from"<EMAIL_ADDRESS>          "dev": true
        },
        "camelcase": {
          "version": "4.1.0",
          "from"<EMAIL_ADDRESS>          "dev": true
        },
        "chalk": {
          "version": "2.0.1",
          "from"<EMAIL_ADDRESS>          "dev": true
        },

when running npm install the above error throw and not able to finish installing the npm package for my app.
tried to upgrade the node to 8.9.1 with npm 5.5.1 got the below error
npm ERR! code 128
npm ERR! Command failed: /usr/bin/git checkout c2ccee1b61a585c5f4fca00da8f79cc1db37048b
npm ERR! fatal: reference is not a tree: c2ccee1b61a585c5f4fca00da8f79cc1db37048b
npm ERR!

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/jonathan/.npm/_logs/2017-11-28T18_37_14_729Z-debug.log

Use https://github.com/npm/npm/issues for npm support ;)


PR: Fix file tests for shortcuts

I broke this test on a previous PR 🙃
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @goanpeca

@ccordoba12 , @dalthviz @impact27 some tests for the are causing a lot of issues on windows CI
Do you know if anyhting changed recently with dependencies? This is definitely not related to the PRs I was doing on the new API, as this PR has nothing to do with it.
spyder/plugins/ipythonconsole/tests/test_ipythonconsole.py::test_get_calltips[arange-signature0-documentation0] PASSED [ 62%]
spyder/plugins/ipythonconsole/tests/test_ipythonconsole.py::test_get_calltips[vectorize-signature1-documentation1] PASSED [ 62%]
Windows fatal exception: access violation

Thread 0x0000113c (most recent call first):
  File "C:\Miniconda\envs\test\lib\site-packages\zmq\sugar\poll.py", line 99 in poll
  File "C:\Miniconda\envs\test\lib\site-packages\jupyter_client\channels.py", line 115 in _poll
  File "C:\Miniconda\envs\test\lib\site-packages\jupyter_client\channels.py", line 153 in run
  File "C:\Miniconda\envs\test\lib\threading.py", line 916 in _bootstrap_inner
  File "C:\Miniconda\envs\test\lib\threading.py", line 884 in _bootstrap

Thread 0x00000640 (most recent call first):
  File "C:\Miniconda\envs\test\lib\selectors.py", line 314 in _select
  File "C:\Miniconda\envs\test\lib\selectors.py", line 323 in select
  File "C:\Miniconda\envs\test\lib\asyncio\base_events.py", line 1415 in _run_once
  File "C:\Miniconda\envs\test\lib\asyncio\base_events.py", line 438 in run_forever
  File "C:\Miniconda\envs\test\lib\site-packages\tornado\platform\asyncio.py", line 149 in start
  File "C:\Miniconda\envs\test\lib\site-packages\jupyter_client\threaded.py", line 187 in run
  File "C:\Miniconda\envs\test\lib\threading.py", line 916 in _bootstrap_inner
  File "C:\Miniconda\envs\test\lib\threading.py", line 884 in _bootstrap

Thread 0x00001eb0 (most recent call first):
  File "C:\Miniconda\envs\test\lib\threading.py", line 295 in wait
  File "C:\Miniconda\envs\test\lib\threading.py", line 551 in wait
  File "C:\Miniconda\envs\test\lib\site-packages\IPython\core\history.py", line 829 in run
  File "C:\Miniconda\envs\test\lib\site-packages\IPython\core\history.py", line 58 in needs_sqlite
  File "<decorator-gen-24>", line 2 in run
  File "C:\Miniconda\envs\test\lib\threading.py", line 916 in _bootstrap_inner
  File "C:\Miniconda\envs\test\lib\threading.py", line 884 in _bootstrap

Thread 0x00001530 (most recent call first):
  File "C:\Miniconda\envs\test\lib\threading.py", line 299 in wait
  File "C:\Miniconda\envs\test\lib\threading.py", line 551 in wait
  File "C:\Miniconda\envs\test\lib\site-packages\jupyter_client\channels.py", line 161 in run
  File "C:\Miniconda\envs\test\lib\threading.py", line 916 in _bootstrap_inner
  File "C:\Miniconda\envs\test\lib\threading.py", line 884 in _bootstrap

Thread 0x00000e9c (most recent call first):
  File "C:\Miniconda\envs\test\lib\selectors.py", line 314 in _select
  File "C:\Miniconda\envs\test\lib\selectors.py", line 323 in select
  File "C:\Miniconda\envs\test\lib\asyncio\base_events.py", line 1415 in _run_once
  File "C:\Miniconda\envs\test\lib\asyncio\base_events.py", line 438 in run_forever
  File "C:\Miniconda\envs\test\lib\site-packages\tornado\platform\asyncio.py", line 149 in start
  File "C:\Miniconda\envs\test\lib\site-packages\jupyter_client\threaded.py", line 187 in run
  File "C:\Miniconda\envs\test\lib\threading.py", line 916 in _bootstrap_inner
  File "C:\Miniconda\envs\test\lib\threading.py", line 884 in _bootstrap

Thread 0x00001e3c (most recent call first):
  File "C:\Miniconda\envs\test\lib\threading.py", line 299 in wait
  File "C:\Miniconda\envs\test\lib\threading.py", line 551 in wait
  File "C:\Miniconda\envs\test\lib\site-packages\jupyter_client\channels.py", line 161 in run
  File "C:\Miniconda\envs\test\lib\threading.py", line 916 in _bootstrap_inner
  File "C:\Miniconda\envs\test\lib\threading.py", line 884 in _bootstrap

Thread 0x00000b94 (most recent call first):
  File "C:\Miniconda\envs\test\lib\selectors.py", line 314 in _select
  File "C:\Miniconda\envs\test\lib\selectors.py", line 323 in select
  File "C:\Miniconda\envs\test\lib\asyncio\base_events.py", line 1415 in _run_once
  File "C:\Miniconda\envs\test\lib\asyncio\base_events.py", line 438 in run_forever
  File "C:\Miniconda\envs\test\lib\site-packages\tornado\platform\asyncio.py", line 149 in start
  File "C:\Miniconda\envs\test\lib\site-packages\jupyter_client\threaded.py", line 187 in run
  File "C:\Miniconda\envs\test\lib\threading.py", line 916 in _bootstrap_inner
  File "C:\Miniconda\envs\test\lib\threading.py", line 884 in _bootstrap

Current thread 0x00001c78 (most recent call first):
  File "C:\Miniconda\envs\test\lib\site-packages\pytestqt\wait_signal.py", line 51 in wait
  File "C:\Miniconda\envs\test\lib\site-packages\pytestqt\qtbot.py", line 444 in wait
  File "C:\Miniconda\envs\test\lib\site-packages\pytestqt\qtbot.py", line 537 in waitUntil
  File "D:\a\1\s\spyder\plugins\ipythonconsole\tests\test_ipythonconsole.py", line 257 in test_get_calltips
  File "C:\Miniconda\envs\test\lib\site-packages\_pytest\python.py", line 174 in pytest_pyfunc_call
  File "C:\Miniconda\envs\test\lib\site-packages\pluggy\callers.py", line 187 in _multicall
  File "C:\Miniconda\envs\test\lib\site-packages\pluggy\manager.py", line 87 in <lambda>
  File "C:\Miniconda\envs\test\lib\site-packages\pluggy\manager.py", line 93 in _hookexec
  File "C:\Miniconda\envs\test\lib\site-packages\pluggy\hooks.py", line 286 in __call__
  File "C:\Miniconda\envs\test\lib\site-packages\_pytest\python.py", line 1464 in runtest
  File "C:\Miniconda\envs\test\lib\site-packages\_pytest\runner.py", line 123 in pytest_runtest_call
  File "C:\Miniconda\envs\test\lib\site-packages\pluggy\callers.py", line 187 in _multicall
  File "C:\Miniconda\envs\test\lib\site-packages\pluggy\manager.py", line 87 in <lambda>
  File "C:\Miniconda\envs\test\lib\site-packages\pluggy\manager.py", line 93 in _hookexec

  File "C:\Miniconda\envs\test\lib\site-packages\pluggy\hooks.py", line 286 in __call__
  File "C:\Miniconda\envs\test\lib\site-packages\_pytest\runner.py", line 198 in <lambda>
  File "C:\Miniconda\envs\test\lib\site-packages\_pytest\runner.py", line 226 in from_call
  File "C:\Miniconda\envs\test\lib\site-packages\_pytest\runner.py", line 198 in call_runtest_hook
  File "C:\Miniconda\envs\test\lib\site-packages\flaky\flaky_pytest_plugin.py", line 129 in call_and_report
  File "C:\Miniconda\envs\test\lib\site-packages\_pytest\runner.py", line 93 in runtestprotocol
  File "C:\Miniconda\envs\test\lib\site-packages\_pytest\runner.py", line 78 in pytest_runtest_protocol
  File "C:\Miniconda\envs\test\lib\site-packages\flaky\flaky_pytest_plugin.py", line 92 in pytest_runtest_protocol
  File "C:\Miniconda\envs\test\lib\site-packages\pluggy\callers.py", line 187 in _multicall
  File "C:\Miniconda\envs\test\lib\site-packages\pluggy\manager.py", line 87 in <lambda>
  File "C:\Miniconda\envs\test\lib\site-packages\pluggy\manager.py", line 93 in _hookexec
  File "C:\Miniconda\envs\test\lib\site-packages\pluggy\hooks.py", line 286 in __call__
  File "C:\Miniconda\envs\test\lib\site-packages\_pytest\main.py", line 271 in pytest_runtestloop
  File "C:\Miniconda\envs\test\lib\site-packages\pluggy\callers.py", line 187 in _multicall
  File "C:\Miniconda\envs\test\lib\site-packages\pluggy\manager.py", line 87 in <lambda>
  File "C:\Miniconda\envs\test\lib\site-packages\pluggy\manager.py", line 93 in _hookexec
  File "C:\Miniconda\envs\test\lib\site-packages\pluggy\hooks.py", line 286 in __call__
  File "C:\Miniconda\envs\test\lib\site-packages\_pytest\main.py", line 250 in _main
  File "C:\Miniconda\envs\test\lib\site-packages\_pytest\main.py", line 206 in wrap_session
  File "C:\Miniconda\envs\test\lib\site-packages\_pytest\main.py", line 243 in pytest_cmdline_main
  File "C:\Miniconda\envs\test\lib\site-packages\pluggy\callers.py", line 187 in _multicall
  File "C:\Miniconda\envs\test\lib\site-packages\pluggy\manager.py", line 87 in <lambda>
  File "C:\Miniconda\envs\test\lib\site-packages\pluggy\manager.py", line 93 in _hookexec
  File "C:\Miniconda\envs\test\lib\site-packages\pluggy\hooks.py", line 286 in __call__
  File "C:\Miniconda\envs\test\lib\site-packages\_pytest\config\__init__.py", line 82 in main
  File "runtests.py", line 58 in main
  File "runtests.py", line 76 in <module>

Any Azure tests are not related to this PR. The circleci passing tests is what got fixed. This is ready to be merged

Hello @goanpeca! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file spyder/plugins/ipythonconsole/plugin.py:

Line 164:9: E265 block comment should start with '# '

Ok, I'll try to fix the tests in this PR.

@ccordoba12 I suggest you just merge this as this is fixing the CircleCI issue that  we do not want to appear on other PRs.
Fixing tests that are not related to this PR should not be fixed in this PR. Please open a new PR.


Replaced the DropdownField component with the RadioInput component.

Description
Figma: https://www.figma.com/file/7TEcX7f6rw3Z0WYR4TpX3R/COVID-Symptom-Study-App-MASTER?node-id=11435%3A882
Notion: https://www.notion.so/joinzoe/017c3de591604a7b89d0b69e3c37b279?v=0133357df3ed42e1bd42c1e0d7afcf45&p=3e759567865e4cee98c12392fb4d076b
Screenshot:

On what platform have you tested the change?

[ ] Android - Emulator
[ ] Android - Physical device
[x] iOS - Emulator
[ ] iOS - Physical device

Screenshots
Please attach screenshots showing the change if relevant
Checklist (for submission)

[ ] Analytics/tracking events have been added (if needed)

Checklist (for reviewers)

[x] Checked against Figma designs (if relevant)
[ ] Checked that data has been successfully saved to the backend (if relevant)

Out of scope and potential follow-up
Are there any related changes that you plan to do in a follow-up PR or voluntarily excluded from the scope?

Suggestions
[1] "Choose one of these options" should not be a selectable option

Suggestions
[1] "Choose one of these options" should not be a selectable option
VaccineDetails Screen

AboutYou Screen (Profile Creation)

[2] Can you change the Text Font or contrast to be darker?

@selvach Good spot with [1]!
About [2] I agree the text is too light. It's a weird one because the color/font-family/font-weight/etc. is exactly the same as in the design on Figma but it still looks more light somehow

More dark font family (regular instead of light) for the text:


Plugin 2.2

In this epic we aim to improve the editing experience of tokens as well as introduce new token types
### Introduce new token types
- [ ] #858
- [ ] https://github.com/tokens-studio/figma-plugin/issues/152
- [ ] https://github.com/tokens-studio/figma-plugin/issues/299
- [ ] #1748
- [ ] https://github.com/tokens-studio/figma-plugin/issues/1295
- [ ] https://github.com/tokens-studio/figma-plugin/issues/613

@esthercheran can you fill out the contents of this issue? Let's not have empty issues.

Closing in favor of https://github.com/tokens-studio/figma-plugin/issues/2679


[DDW-491] Verify HW wallet receiving address - Ledger

This PR introduces Hardware Wallet receiving address verification for Ledger devices.
Todos

[X] Copy update (https://docs.google.com/document/d/1ihb5n6n0wXOovyfuLYniC0cvrTY9MG8pifemGsn2-fs/edit?usp=sharing)

[x] Edge case when sharing address dialog closed and another one is opened. Multiple device listeners trigger and cause errors.

[x] Use str_to_path from utils instead cardano once develop branch is merged

[x] Display the address on the device. Maybe we are using the wrong API call or correct call with incorrect arguments. @tomothespian

[x] Since we are showing address path and staking path, we should display that for all of the wallets (hardware and software) on the Daedalus screen too @a-rukin @tomothespian
https://app.zeplin.io/project/57acfaa7436a750316161a8b/screen/5e440b4b8c02660b9a813555

[x] Update Copy

[x] Do not merge until "Force exporting pub key" improvement is done #2342

[x] Add "Support Request" link

[x] Add missing Japanese translations

[x] Double-check whole verification flow

[x] Update PR screenshots

[x] Apply latest LedgerJS 3.0.0. breaking changes related to showAddress and deriveAddress

[x] Double-check code and prepare testing notes

[x] -  DO NOT MERGE -  FIX from https://github.com/input-output-hk/daedalus/pull/2541 needs to be merged here. included in 4.1.0-FC1 release - DONE

Testing Checklist

Slack QA thread

In-App testing

[ ] Go to wallet receive screen for some Hardware Wallet (only Ledger is supported) and check address verification process. You can test the same steps / cases as is for signing transactions. Instead of "Sign transaction" you will see Address Verification message.
[ ] Address verification is enabled ONLY for Ledger and should not be visible for Trezor or Regular wallets.
[ ] Spending and Staking paths are added to the "Share wallet address" for ALL types of wallets under QR code.

NOTES:

I added screenshots with titles / descriptions in the exact order on how the process is going so please check before you start with testing

There are multiple cases presented:

On the first attempt you will be asked to export the address (with device) and after that address will also show on the device. When you confirm all the actions you will see that the first checkbox is checked in UI. After that, you will be asked to answer a question ( is address true or not). If you select "No, reverify", you will pass through the same process but with one additional option to select (inside answers section), "No, I am sure that address displayed in Daedalus is different from the address displayed on my Ledger device" one. If you select that option new section will appear. This section will ask you to confirm that address is not valid. If you check that the "Submit request" button becomes enabled, it is disabled otherwise.

Important thing is also that both checkboxes on the top "Daedalus verified the address" and "You have verified the address" are disabled and will be checked automatically as you are walking through the process. The first one is checked after you confirm everything in the device and the second one when you choose an option from "Is the address you have verified correctly".

Test Cases
Scenario 1 - Access to share wallet address dialog with device
disconnected
Given that I am on the receive screen from a Ledger X|S device
And the device is not connected
When I click on "Share" for an address on the list
Then I can see a dialog with the address
And it displays an input that asks to connect the device to validate the address

Scenario 2 - Access to share wallet address dialog with the device connected
Given that I am on the receive screen from a Ledger X|S device
And the device is connected and unlocked
And Cardano app is not running
When I click on "Share" for an address on the list
Then I can see a dialog with the address
And it displays an input that asks to run the Cardano app to validate the address

Scenario 3 - Access to share wallet address dialog with Cardano app running
Given that I am on the receive screen from a Ledger X|S device
And the device is connected, unlocked, and running the Cardano app
When I click on "Share" for an address on the list
Then I can see a dialog with the address
And it displays an input that asks to export the public key

Scenario 4 - Export public key
Given that I am on the "share wallet address" dialog from a Ledger X|S device
And the device is connected, unlocked, and running the Cardano app
And Daedalus asks to export the public key
When I export the public key on the device
Then I can see the input now asks to verify the address on the device

Scenario 5 - Verify the Address on the device
Given that I am on the "share wallet address" dialog from a Ledger X|S device
And the device is connected, unlocked, and running the Cardano app
And Daedalus asks to verify the address
When I verify that the address displayed on the device matches the address on Daedalus
Then I can see the input now asks to answer the question below
And the first check below the input is checked
And I can see the question "Is the address you verified correct?"
And I can see two options at the bottom of the dialog to answer it

Scenario 6 - Answer that the address is correct
Given that I am on the "share wallet address" dialog from a Ledger X|S device
And Daedalus asks to answer the question at the bottom
When I click on "Yes"
Then I can see the input is highlighted in green
And the second check below the input is checked
And the other option at the bottom is hidden
And the buttons "Save as image" and "Save as PDF" are displayed
And the input to insert notes for the pdf is displayed

Scenario 7 - Answer that the address is incorrect
Given that I am on the "share wallet address" dialog from a Ledger X|S device
And the device is connected, unlocked, and running the Cardano app
And Daedalus asks to answer the question at the bottom
When I click on "No, reverify"
Then I can see the question and options are hidden
And Daedalus asks to verify the address on the device again

Scenario 8 - Recheck address
Given that I am on the "share wallet address" dialog from a Ledger X|S device
And I have checked that the address was incorrect before
And the device is connected, unlocked, and running the Cardano app
And Daedalus asks to verify the address
When I verify the address on the device
Then I can see the input now asks to answer the question below
And I can see the question "Is the address you verified correct?"
And I can see three options at the bottom of the dialog to answer it

Scenario 9 - Confirm the address is not correct
Given that I am on the "share wallet address" dialog from a Ledger X|S device
And I have checked that the address was incorrect before
And the device is connected, unlocked, and running the Cardano app
And Daedalus asks to verify the address
When I verify the address on the device
And I select the option "No, I am sure" at the bottom
Then I can see the input is highlighted in red
And the other options are hidden
And a checkbox to confirm the address is not correct is displayed
And disabled "Submit request" button is displayed at the bottom

Scenario 10 - Open form to submit a request
Given that I am on the "share wallet address" dialog from a Ledger X|S device
And I have confirmed that the address was incorrect
When I check the option "Yes, I am sure"
And I click the "Submit Request" button
Then the form to submit a request is open in the default browser

Scenario 10 - Reject exporting the Address on the device
Given that I am on the "share wallet address" dialog from a Ledger X|S device
And the device is connected, unlocked, and running the Cardano app
And Daedalus asks to verify the address
When I reject the export of the address on the device
Then I can see the input is highlighted in red
And it indicates that the verification failed

Testing Summary

Screenshots
ENGLISH
1. Start Veifying

2. Answer to the question

2.1. Answer - YES

2.2. Answer - NO, reverify ( State after reverifying)

2.2.1 Answer NO after reverifying

2.2.2 Confirm wrong address

3. Rejected Verification

4. Default Regular and Trezor wallets

JAPANESE
1. Start Veifying

2. Answer to the question

2.1. Answer - YES

2.2. Answer - NO, reverify ( State after reverifying)

2.2.1 Answer NO after reverifying

2.2.2 Confirm wrong address

3. Rejected Verification

4. Default Regular and Trezor wallets

Review Checklist
Basics

[ ] PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
[ ] PR is updated to the most recent version of the target branch (and there are no conflicts)
[ ] PR has a good description that summarizes all changes
[ ] PR has default-sized Daedalus window screenshots or animated GIFs of important UI changes:

[ ] In English
[ ] In Japanese

[ ] CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
[ ] Automated tests: All acceptance and unit tests are passing (yarn test)
[ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
[ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
[ ] There are no flow errors or warnings (yarn flow:test)
[ ] There are no lint errors or warnings (yarn lint)
[ ] There are no prettier errors or warnings (yarn prettier:check)
[ ] There are no missing translations (running yarn manage:translations produces no changes)
[ ] Text changes are proofread and approved (Jane Wild / Amy Reeve)
[ ] Japanese text changes are proofread and approved (Junko Oda)
[ ] UI changes look good in all themes (Alexander Rukin)
[ ] Storybook works and no stories are broken (yarn storybook)
[ ] In case of dependency changes yarn.lock file is updated

Code Quality

[ ] Important parts of the code are properly commented and documented
[ ] Code is properly typed with flow
[ ] React components are split-up enough to avoid unnecessary re-renderings
[ ] Any code that only works in main process is neatly separated from components

Testing

[ ] New feature/change is covered by acceptance tests
[ ] New feature/change is manually tested and approved by QA team
[ ] All existing acceptance tests are still up-to-date
[ ] New feature/change is covered by Daedalus Testing scenario
[ ] All existing Daedalus Testing scenarios are still up-to-date

After Review

[ ] Merge the PR
[ ] Delete the source branch
[ ] Move the ticket to done column on the YouTrack board
[ ] Update Slack QA thread by marking it with a green checkmark

@ManusMcCole can you please test this one? 🙏

@tomothespian please merge latest develop 🙏

@tomislavhoracek I found a few issues when reconnecting the device:
1 - (in macOS) If you validate your address and then unplug the device, when you try to validate any address again (open the dialog, then connect the device), it won't be detected by Daedalus (restarting is required). No error on the console is displayed.
2 - (in Windows) When you export the key on the device, the dialog closes. Check video.
Also, I have a small suggestion and I think this was mentioned before for other dialogs: Can we avoid the dialog closing when clicking outside of it? (Check video) I know it's implemented this way in production, but I think it's a little inconvenient in this case. As the process of verification takes so many steps if you accidentally click outside of the dialog you have to start over.

@gabriela-ponce issues fixed in the scope of 4.1.0-FC1 release
https://github.com/input-output-hk/daedalus/pull/2541

@tomislavhoracek The first issue still reproduces on 17817 (check screenshot) but I think this is related to DDW-670, so not sure if that would be fixed on another task.
I was able to reproduce the second issue in Windows just once but got no video. I'll check that a few more times just to be sure.
Regarding this, is there any confirmation to implement it on this PR?

Also, I have a small suggestion and I think this was mentioned before for other dialogs: Can we avoid the dialog closing when clicking outside of it? (Check video) I know it's implemented this way in production, but I think it's a little inconvenient in this case. As the process of verification takes so many steps if you accidentally click outside of the dialog you have to start over.

@gabriela-ponce Fix is merged into 4.1.0-FC1  release branch. It is still not in develop branch and also not merged in this PR. I will let you know when you can check fix on this PR.

@gabriela-ponce you can test now. Fix is merged!

@tomislavhoracek Looks good to me when tested with Nano X on build 17841. However, I am not sure what has been decided on @gabriela-ponce's suggestion about this "Can we avoid the dialog closing when clicking outside of it? "?

@tomislavhoracek The first issue (HW not detected) no longer reproduces with the mentioned steps, but I'm still running some tests just to be sure.
But I have found the reproduction steps for the second issue (dialog closes after exporting the key):
On Windows and Linux:
1 - Open the "Share wallet" dialog
2 - Connect HW and unlock
3 - Run Cardano app on HW
4 - Export public key
You'll see that the dialog closes. Check this video.
You can switch steps 1 and 2 and it would reproduce (connect and unlock first, open dialog next). The key to reproduce it is to run the Cardano app after opening the dialog.
After that, if you open the dialog again (no changes on the HW), Daedalus would ask to export the key, but nothing would be prompted on the device. It works after a second retry without changes on the HW (Cardano app still running).

@gabriela-ponce Can you write what was the step before the issue, in what state the device was, did you restarted Daedalus, reconnected the device...
Please provide full reproduction steps by following the extended HW testing docs.
@miorsufianiohk you tested only on Mac or...?

@tomislavhoracek I'll try to clarify the steps for this issue:
Platform: macOS Big Sur 11.2.3
Hardware wallet: Ledger Nano S
Firmware version: 1.6.1
Cardano app version: 2.2.1
Given that I have connected and unlocked a Ledger Nano S device
When I open the "Share" dialog on the "Receive" screen for this wallet
And I run the Cardano app
And I export the public key
Then I can see that the dialog closes on Daedalus
And the Ledger device is waiting for commands

No other transactions were made before reproducing the issue, Daedalus was just initialized.
The device can be connected at any stage. So you can connect it before starting Daedalus or after.
The only prerequisite to reproduce the issue is to open the "share" dialog before opening the Cardano app
After you export the public key on the device, the dialog closes and no instructions are visible on the device

You can check the logs here.

@gabriela-ponce thanks.
And step BEFORE you saw an issue was "Wallet Restore" and then you restarted Daedalus or not... what was the previous step?

@tomislavhoracek You can pair the device, close the Cardano app, and follow the steps to reproduce the issue. But also you can pair the device, unplug it, restart Daedalus, plug the device and follow the steps to reproduce the issue, I found no difference for these. Let me know if that's clear or if we can have a meeting to discuss it 👍
Sorry, I pasted the details from another issue. I updated the comment, but just to confirm, it happens in Windows and Linux.

@gabriela-ponce thanks, it is much more clearer now <3