varnish pod crashloopback

Trying to make use of the recently updated varnish template result in a pod crashloopback with the following error:

Error:
--
Sun, Nov 22 2020 8:38:21 am | Message from VCC-compiler:
Sun, Nov 22 2020 8:38:21 am | Backend host '"drupal-wxt-varnish-drupal"' could not be resolved to an IP address:
Sun, Nov 22 2020 8:38:21 am | Name or service not known
Sun, Nov 22 2020 8:38:21 am | (Sorry if that error message is gibberish.)
Sun, Nov 22 2020 8:38:21 am | ('/etc/varnish/default.vcl' Line 4 Pos 11)
Sun, Nov 22 2020 8:38:21 am | .host = "drupal-wxt-varnish-drupal";
Sun, Nov 22 2020 8:38:21 am | ----------###########################-
Sun, Nov 22 2020 8:38:21 am |
Sun, Nov 22 2020 8:38:21 am |
Sun, Nov 22 2020 8:38:21 am | In backend specification starting at:
Sun, Nov 22 2020 8:38:21 am | ('/etc/varnish/default.vcl' Line 3 Pos 1)
Sun, Nov 22 2020 8:38:21 am | backend default {
Sun, Nov 22 2020 8:38:21 am | #######----------
Sun, Nov 22 2020 8:38:21 am |
Sun, Nov 22 2020 8:38:21 am | Running VCC-compiler failed, exited with 2
Sun, Nov 22 2020 8:38:21 am | VCL compilation failed

I think it has to do with the host name it is trying to find. It is looking for drupal-wxt-varnish-drupal but that name does not exist. On the other hand drupal-wxt-varnish does exist.

Also, looking at the template code I am not sure varnish would actually get used as I am not finding code that would reconfigure the ingress to use varnish instead of nginx. Is it possible this just deploy varnish without integrating it in the flow between the user and nginx?

Ah sorry this was pushed half done, and it was supposed to be updated last week from our working internal.
I have just synced it right now in this P.R. and waiting for @zachomedia to approve it :D
https://github.com/drupalwxt/helm-drupal/pull/40/files

Well well well... after digging a bit more in the varnish chart I figured there is a very important value that actually need to be passed within the varnish: section of the helm-drupal char values.yaml... the varnishConfigContent value. After setting it to the appropriate values things appear to deploy properly. The default ingress is still not pointing to varnish so no traffic actually goes through it but it does deploy properly.
I think this value should not have to be provided in the values file and a proper default for helm-drupal should be baked into the chart to make it work out of the box...
Varnish appear to be very much a work in progress?

Ah @bernardmaltais  think you just posted after what I just posted :P
There is a P.R. with all this working just waiting on @zachomedia to approve it
https://github.com/drupalwxt/helm-drupal/pull/40/files
We do also bake all of this into the chart so shouldn't be anything you have to do :D

@sylus Nice. I was wondering about that. This gave me a chance to poke at the bear so to speak to make it growl ;-) I will look forward to the merge for the update. Many thanks!

Is now merged :D
https://github.com/drupalwxt/helm-drupal/pull/40

kind create cluster --config kind.yaml

kind: Cluster
apiVersion: kind.x-k8s.io/v1alpha4
nodes:
- role: control-plane
  # add a mount from /path/to/my/files on the host to /files on the node
  extraMounts:
  - hostPath: /tmp/drupal/shared/drupal-public
    containerPath: /mnt/drupal/drupal-public
  - hostPath: /tmp/drupal/shared/drupal-private
    containerPath: /mnt/drupal/drupal-private

helm install drupal -f values-hostpath-kind.yaml --set varnish.enabled=true .

@sylus That was quick! It does indeed deploy perfectly now! Nice work guys! We are debating internally between building our deployment in Azure App Services using containers or leveraging this great piece of work. Obviously I am for reusing your work as this is the reason you make this open and available with great support.
I have a few questions regarding how to best operate the solution once deployed so I will probably reach out eventually to discuss what you would consider best day two operations practices.

Awesome to hear and yeah Zachary is going to get back to your email soon we did a whole write up aboutsome of the downsides of Azure Web Apps (and why is disabled at our dept since we have a platform team) and Zachary will give you a detailed reply. We could also share our security controls, and concept of operations that we recieved an ATO for our cloud platform with.
In essence Azure Web Apps is okay but you won't really get to much control or useful scaling. However if you are only doing one app then it might makes sense. For us we use our cloud native platform so logging in our Elastic stack using the operator, credentials in vault, and real time metrics in Prometheus / Grafana. Then having everything under Mutual TLS through the Istio service mesh. The value is only really achieved when you have multiple workloads running under it though due to economy of scale and making it an organizational shift to use that workflow. Another big reason is the community we get to work with and ability to jump to any cloud. Also that we are GCEARB endorsed.
https://github.com/canada-ca-terraform-modules/terraform-kubernetes-aks
https://github.com/canada-ca-terraform-modules/terraform-kubernetes-aks-platform

Awesome! This will be very helpful for us. It is nice to stand on the shoulder of a giant ;-)

@bernardmaltais
If you get a chance try out Kind for local dev https://kind.sigs.k8s.io/
I tested varnish myself and worked and showed all the steps here:
https://github.com/drupalwxt/helm-drupal/issues/38#issuecomment-731815239

Closing this out thanks for testing it :D

@bernardmaltais
Remember we do have this here but it doesn't have the pgbouncer and varnish configurations:
https://github.com/drupalwxt/terraform-containers-webapp-azure
Also we have this if you decide to go for Managed Postgresql which our chart supports external dbs:
https://github.com/canada-ca-terraform-modules/terraform-azurerm-postgresql

@bernardmaltais just in case you decide to test the redis integration you will need to run chart version 0.6.6 and point to these images until the next release as we just added the redis library https://github.com/drupalwxt/docker-scaffold/commit/1deda6b47e65a94618801e2e807e7821a3a045d6
drupalwxt/site-wxt:4.0.0-rc1-redis
drupalwxt/site-wxt:40.0-rc1-redis-nginx

@bernardmaltais sorry chart version 0.6.7+


[SPARK-8641][SQL] Native Spark Window functions

This PR removes Hive windows functions from Spark and replaces them with (native) Spark ones. The PR is on par with Hive in terms of features.
This has the following advantages:

Better memory management.
The ability to use spark UDAFs in Window functions.

cc @rxin / @yhuai

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/46246/
Test FAILed.

test this please

Test build #46251 has started for PR 9819 at commit b66ef4d.

Test build #46251 has finished for PR 9819 at commit b66ef4d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):\n  * abstract class ImperativeAggregate extends AggregateFunction with CodegenFallback \n  * trait WindowFunction extends Expression \n  * case class Lead(input: Expression, offset: Expression, default: Expression)\n  * case class Lag(input: Expression, offset: Expression, default: Expression)\n  * abstract class AggregateWindowFunction extends DeclarativeAggregate with WindowFunction \n  * abstract class RowNumberLike extends AggregateWindowFunction \n  * trait SizeBasedWindowFunction extends AggregateWindowFunction \n  * case class RowNumber() extends RowNumberLike \n  * case class CumeDist(n: Expression)\n  * case class NTile(buckets: Expression, n: Expression)\n  * abstract class RankLike extends AggregateWindowFunction \n  * case class Rank(order: Seq[Expression]) extends RankLike \n  * case class DenseRank(order: Seq[Expression]) extends RankLike \n  * case class PercentRank(order: Seq[Expression], n: Expression) extends RankLike\n

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/46251/
Test FAILed.

Test build #46331 has started for PR 9819 at commit 6ebee15.

Test build #46331 has finished for PR 9819 at commit 6ebee15.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):\n  * abstract class ImperativeAggregate extends AggregateFunction with CodegenFallback \n  * trait WindowFunction extends Expression \n  * case class Lead(input: Expression, offset: Expression, default: Expression)\n  * case class Lag(input: Expression, offset: Expression, default: Expression)\n  * abstract class AggregateWindowFunction extends DeclarativeAggregate with WindowFunction \n  * abstract class RowNumberLike extends AggregateWindowFunction \n  * trait SizeBasedWindowFunction extends AggregateWindowFunction \n  * case class RowNumber() extends RowNumberLike \n  * case class CumeDist(n: Expression)\n  * case class NTile(buckets: Expression, n: Expression)\n  * abstract class RankLike extends AggregateWindowFunction \n  * case class Rank(order: Seq[Expression]) extends RankLike \n  * case class DenseRank(order: Seq[Expression]) extends RankLike \n  * case class PercentRank(order: Seq[Expression], n: Expression) extends RankLike\n

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/46331/
Test FAILed.

Test build #46338 has started for PR 9819 at commit b3f5a39.

Test build #46338 has finished for PR 9819 at commit b3f5a39.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):\n  * abstract class ImperativeAggregate extends AggregateFunction with CodegenFallback \n  * trait WindowFunction extends Expression \n  * case class Lead(input: Expression, offset: Expression, default: Expression)\n  * case class Lag(input: Expression, offset: Expression, default: Expression)\n  * abstract class AggregateWindowFunction extends DeclarativeAggregate with WindowFunction \n  * abstract class RowNumberLike extends AggregateWindowFunction \n  * trait SizeBasedWindowFunction extends AggregateWindowFunction \n  * case class RowNumber() extends RowNumberLike \n  * case class CumeDist(n: Expression)\n  * case class NTile(buckets: Expression, n: Expression)\n  * abstract class RankLike extends AggregateWindowFunction \n  * case class Rank(order: Seq[Expression]) extends RankLike \n  * case class DenseRank(order: Seq[Expression]) extends RankLike \n  * case class PercentRank(order: Seq[Expression], n: Expression) extends RankLike\n

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/46338/
Test FAILed.

Test build #46346 has started for PR 9819 at commit e95c42e.

Test build #46346 has finished for PR 9819 at commit e95c42e.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):\n  * abstract class ImperativeAggregate extends AggregateFunction with CodegenFallback \n  * trait WindowFunction extends Expression \n  * case class Lead(input: Expression, offset: Expression, default: Expression)\n  * case class Lag(input: Expression, offset: Expression, default: Expression)\n  * abstract class AggregateWindowFunction extends DeclarativeAggregate with WindowFunction \n  * abstract class RowNumberLike extends AggregateWindowFunction \n  * trait SizeBasedWindowFunction extends AggregateWindowFunction \n  * case class RowNumber() extends RowNumberLike \n  * case class CumeDist(n: Expression)\n  * case class NTile(buckets: Expression, n: Expression)\n  * abstract class RankLike extends AggregateWindowFunction \n  * case class Rank(order: Seq[Expression]) extends RankLike \n  * case class DenseRank(order: Seq[Expression]) extends RankLike \n  * case class PercentRank(order: Seq[Expression], n: Expression) extends RankLike\n

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/46346/
Test PASSed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/46816/
Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/46817/
Test FAILed.

Merged build finished. Test FAILed.

Test build #46820 has started for PR 9819 at commit 31c6fb3.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/46818/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/46819/
Test FAILed.

Merged build finished. Test FAILed.

Test build #46820 has finished for PR 9819 at commit 31c6fb3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/46820/
Test PASSed.

@hvanhovell Thank you for the PR! Just a quick heads up. We will allocate time to review during next week (and the week after if we need more time to work on it).

One quick question. With this PR, is it possible to use any Spark SQL's aggregate function as a window function?

Yes. You can use any Spark aggregate function as a window function. Most Hive UDAFs should also work except for the pivoted ones...

Test build #46998 has started for PR 9819 at commit d7f13a0.

Test build #46998 has finished for PR 9819 at commit d7f13a0.

This patch fails RAT tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):\n  * abstract class ImperativeAggregate extends AggregateFunction with CodegenFallback \n  * trait WindowFunction extends Expression \n  * case class Lead(input: Expression, offset: Expression, default: Expression)\n  * case class Lag(input: Expression, offset: Expression, default: Expression)\n  * abstract class AggregateWindowFunction extends DeclarativeAggregate with WindowFunction \n  * abstract class RowNumberLike extends AggregateWindowFunction \n  * trait SizeBasedWindowFunction extends AggregateWindowFunction \n  * case class RowNumber() extends RowNumberLike \n  * case class CumeDist(n: Expression)\n  * case class NTile(buckets: Expression, n: Expression)\n  * abstract class RankLike extends AggregateWindowFunction \n  * case class Rank(order: Seq[Expression]) extends RankLike \n  * case class DenseRank(order: Seq[Expression]) extends RankLike \n  * case class PercentRank(order: Seq[Expression], n: Expression) extends RankLike\n

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/46998/
Test FAILed.

Merged build finished. Test FAILed.

Test build #47001 has started for PR 9819 at commit b8ff6fb.

Test build #47001 has finished for PR 9819 at commit b8ff6fb.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):\n  * abstract class ImperativeAggregate extends AggregateFunction with CodegenFallback \n  * trait WindowFunction extends Expression \n  * case class Lead(input: Expression, offset: Expression, default: Expression)\n  * case class Lag(input: Expression, offset: Expression, default: Expression)\n  * abstract class AggregateWindowFunction extends DeclarativeAggregate with WindowFunction \n  * abstract class RowNumberLike extends AggregateWindowFunction \n  * trait SizeBasedWindowFunction extends AggregateWindowFunction \n  * case class RowNumber() extends RowNumberLike \n  * case class CumeDist(n: Expression)\n  * case class NTile(buckets: Expression, n: Expression)\n  * abstract class RankLike extends AggregateWindowFunction \n  * case class Rank(order: Seq[Expression]) extends RankLike \n  * case class DenseRank(order: Seq[Expression]) extends RankLike \n  * case class PercentRank(order: Seq[Expression], n: Expression) extends RankLike\n

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47001/
Test PASSed.

@hvanhovell , is there any progress? will this pr be merged into branch-1.6?

@zzcclp this PR is slated for review in the next week or so. It should be in good shape, but I'll leave the verdict to the reviewers.
SPARK 1.6 is currently in its QA cycle and should be up for release soon. Given the time left it is unlikely that this will be a part of 1.6.
Out of curiosity, are you running into problems with the current Hive UDAFs? Care to share?

@hvanhovell , thanks for your replying. Currently, there are some window statistical reports in our requirement, but without hive environment.
Will this pr be merged into 1.6.1 or later?

@zzcclp Just to absolutely (painfully) clear: You can use the Hive based window functions without a Hive installation, you just need to have a version of Spark compiled with Hive.
Since this is not a bug fix but an improvement, it will be part of the SPARK 1.7/2.0 release.

@hvanhovell , thanks

Test build #47428 has started for PR 9819 at commit 5fefcf0.

Test build #47428 has finished for PR 9819 at commit 5fefcf0.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):\n  * abstract class ImperativeAggregate extends AggregateFunction with CodegenFallback \n  * case class UnresolvedWindowExpression(\n  * case class WindowExpression(\n  * case class Lead(input: Expression, offset: Expression, default: Expression)\n  * case class Lag(input: Expression, offset: Expression, default: Expression)\n  * abstract class AggregateWindowFunction extends DeclarativeAggregate with WindowFunction \n  * abstract class RowNumberLike extends AggregateWindowFunction \n  * trait SizeBasedWindowFunction extends AggregateWindowFunction \n  * case class RowNumber() extends RowNumberLike \n  * case class CumeDist(n: Expression)\n  * case class NTile(buckets: Expression, n: Expression)\n  * abstract class RankLike extends AggregateWindowFunction \n  * case class Rank(order: Seq[Expression]) extends RankLike \n  * case class DenseRank(order: Seq[Expression]) extends RankLike \n  * case class PercentRank(order: Seq[Expression], n: Expression) extends RankLike\n

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47428/
Test PASSed.

Merged build finished. Test PASSed.

Test build #47613 has started for PR 9819 at commit ba925fe.

Test build #47613 has finished for PR 9819 at commit ba925fe.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):\n  * abstract class ImperativeAggregate extends AggregateFunction with CodegenFallback \n  * case class UnresolvedWindowExpression(\n  * case class WindowExpression(\n  * case class Lead(input: Expression, offset: Expression, default: Expression)\n  * case class Lag(input: Expression, offset: Expression, default: Expression)\n  * abstract class AggregateWindowFunction extends DeclarativeAggregate with WindowFunction \n  * abstract class RowNumberLike extends AggregateWindowFunction \n  * trait SizeBasedWindowFunction extends AggregateWindowFunction \n  * case class RowNumber() extends RowNumberLike \n  * case class CumeDist() extends RowNumberLike with SizeBasedWindowFunction \n  * case class NTile(buckets: Expression) extends RowNumberLike with SizeBasedWindowFunction \n  * abstract class RankLike extends AggregateWindowFunction \n  * case class Rank(order: Seq[Expression]) extends RankLike \n  * case class DenseRank(order: Seq[Expression]) extends RankLike \n  * case class PercentRank(order: Seq[Expression]) extends RankLike with SizeBasedWindowFunction \n

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47613/
Test PASSed.

Merged build finished. Test PASSed.

@hvanhovell just a quick heads up. I am going to review this PR today. Will post a comment once I finish my review.

Do we have a test case that uses a UDAF as window function?

Can you add scala doc to explain how we evaluate an regular agg function when it is used as a window function? (Maybe I missed it)

@hvanhovell This is very cool! I have finished my review.

LGTM

Test build #47676 has started for PR 9819 at commit b4d9ca9.

Test build #47676 has finished for PR 9819 at commit b4d9ca9.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):\n  * abstract class ImperativeAggregate extends AggregateFunction with CodegenFallback \n  * case class UnresolvedWindowExpression(\n  * case class WindowExpression(\n  * case class Lead(input: Expression, offset: Expression, default: Expression)\n  * case class Lag(input: Expression, offset: Expression, default: Expression)\n  * abstract class AggregateWindowFunction extends DeclarativeAggregate with WindowFunction \n  * abstract class RowNumberLike extends AggregateWindowFunction \n  * trait SizeBasedWindowFunction extends AggregateWindowFunction \n  * case class RowNumber() extends RowNumberLike \n  * case class CumeDist() extends RowNumberLike with SizeBasedWindowFunction \n  * case class NTile(buckets: Expression) extends RowNumberLike with SizeBasedWindowFunction \n  * abstract class RankLike extends AggregateWindowFunction \n  * case class Rank(children: Seq[Expression]) extends RankLike \n  * case class DenseRank(children: Seq[Expression]) extends RankLike \n  * case class PercentRank(children: Seq[Expression]) extends RankLike with SizeBasedWindowFunction \n

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47676/
Test FAILed.

Build failed due to R versioning problem. I'll try again when this is sorted out.

@yhuai I fixed/addressed/improved most of the things you have raised. Two things worth pointing out:
You can find the test for UDAF here: https://github.com/hvanhovell/spark/blob/SPARK-8641-2/sql/core/src/test/scala/org/apache/spark/sql/DataFrameWindowSuite.scala#L240-L294
You can find the documentation on how we evaluate a regular AggregateFunction here: https://github.com/hvanhovell/spark/blob/SPARK-8641-2/sql/core/src/main/scala/org/apache/spark/sql/execution/Window.scala#L705-L712

retest this please

Test build #47685 has started for PR 9819 at commit b4d9ca9.

Test build #47685 has finished for PR 9819 at commit b4d9ca9.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):\n  * abstract class ImperativeAggregate extends AggregateFunction with CodegenFallback \n  * case class UnresolvedWindowExpression(\n  * case class WindowExpression(\n  * case class Lead(input: Expression, offset: Expression, default: Expression)\n  * case class Lag(input: Expression, offset: Expression, default: Expression)\n  * abstract class AggregateWindowFunction extends DeclarativeAggregate with WindowFunction \n  * abstract class RowNumberLike extends AggregateWindowFunction \n  * trait SizeBasedWindowFunction extends AggregateWindowFunction \n  * case class RowNumber() extends RowNumberLike \n  * case class CumeDist() extends RowNumberLike with SizeBasedWindowFunction \n  * case class NTile(buckets: Expression) extends RowNumberLike with SizeBasedWindowFunction \n  * abstract class RankLike extends AggregateWindowFunction \n  * case class Rank(children: Seq[Expression]) extends RankLike \n  * case class DenseRank(children: Seq[Expression]) extends RankLike \n  * case class PercentRank(children: Seq[Expression]) extends RankLike with SizeBasedWindowFunction \n

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47685/
Test PASSed.

Test build #47726 has started for PR 9819 at commit c181c8b.

Test build #47726 has finished for PR 9819 at commit c181c8b.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):\n  * abstract class ImperativeAggregate extends AggregateFunction with CodegenFallback \n  * case class UnresolvedWindowExpression(\n  * case class WindowExpression(\n  * case class Lead(input: Expression, offset: Expression, default: Expression)\n  * case class Lag(input: Expression, offset: Expression, default: Expression)\n  * abstract class AggregateWindowFunction extends DeclarativeAggregate with WindowFunction \n  * abstract class RowNumberLike extends AggregateWindowFunction \n  * trait SizeBasedWindowFunction extends AggregateWindowFunction \n  * case class RowNumber() extends RowNumberLike \n  * case class CumeDist() extends RowNumberLike with SizeBasedWindowFunction \n  * case class NTile(buckets: Expression) extends RowNumberLike with SizeBasedWindowFunction \n  * abstract class RankLike extends AggregateWindowFunction \n  * case class Rank(children: Seq[Expression]) extends RankLike \n  * case class DenseRank(children: Seq[Expression]) extends RankLike \n  * case class PercentRank(children: Seq[Expression]) extends RankLike with SizeBasedWindowFunction \n

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47726/
Test PASSed.

Thank you @hvanhovell ! I am going to merge it. Let's have a follow-up PR to add more docs to those newly added functions. Also, can we add tests like the following?
sql(s"""
           |select  p_mfgr,p_name, p_size,
           |avg(null) over(distribute by p_mfgr sort by p_name) as avg
           |from part
      """.stripMargin).show

    val df = Seq(("a", 1), ("a", 1), ("a", 2), ("a", 2), ("b", 4), ("b", 3), ("b", 2))
      .toDF("key", "value")
    val window = Window.orderBy()
      df.select(
          $"key", $"value",
          sum(lit(null)).over(window)).show

Basically, we test cases using null literals as the argument of a window function (I tested them manually and the results look good).

@yhuai & @davies thanks for the reviews!


Fix top and bottom paddings on send screen (address field)

Top and bottom paddings on plaques should be equal.
Current implementation:

Design:

https://zpl.io/VDLkvWJ

Checked.

Checked.


feat: release v5.21.0

Refactor codebase to include GlobalConfig class
Implement initial OpenAPI file generation for the UI-based add-ons
Update UCC UI to v1.22.0

:tada: This PR is included in version 5.21.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


adapter-static can't build initial project

Describe the bug
Current version of adapter-static broken from 1.0.0-next.24 version
After that update adapter-static failing to build Kit template.
Current Skeleton App not compatible with svelte kit, or svelte kit is not compatible with static adapter.
Reproduction
Create new kit project (npm init svelte@next my-app)
install @sveltejs/adapter-static@next
Add it to svelte.config.js as adapter instead of adapter-auto.
Try to build app.
Logs
Run npm run preview to preview your production build locally.

> Using @sveltejs/adapter-static
> body used already for:
    at consumeBody<EMAIL_ADDRESS>4912:9)
    at Response.text<EMAIL_ADDRESS>s:4877:24)
    at visit (file:///C:/proj/staticAdapterBroken/node_modules/@sveltejs/kit/dist/chunks/index5.js:483:39
)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

System Info
System:
    OS: Windows 10 10.0.19043
    CPU: (8) x64 Intel(R) Core(TM) i5-8350U CPU @ 1.70GHz
    Memory: 13.38 GB / 31.88 GB
  Binaries:
    Node: 16.9.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.15 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 7.22.0 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.19041.1266.0), Chromium (97.0.1072.62)
    Internet Explorer: 11.0.19041.1202
  npmPackages:
    @sveltejs/adapter-auto: next => 1.0.0-next.14
    @sveltejs/adapter-static: ^1.0.0-next.26 => 1.0.0-next.26
    @sveltejs/kit: next => 1.0.0-next.236
    svelte: ^3.44.0 => 3.46.2

Severity
blocking all usage of SvelteKit
Additional Information
Actually I was trying to fix https://github.com/MailCheck-co/mailcheck.site/commit/abecae86f209ffc9abdae02d59611bb406235472, but during debug I disabled everything in project with no luck. Then I tried to create new project, and found that new projects are broken from start.

Repo with reproduction
https://github.com/nosovk/sveltekit-broken-static-adapter

Can conform this is happening for me as well. Dependencies from my package.json: "@sveltejs/adapter-static": "^1.0.0-next.24", "@sveltejs/kit": "^1.0.0-next.236".

also happens with "@sveltejs/adapter-node": "^1.0.0-next.66" if you set
<script context="module">
	export const prerender = true;
	…
</script>

on a routes/ svelte file if there's also a export const load = async ({ fetch }) => {

For the static-adapter I've tested it by removing the export const prerender = true and export const hydrate = false (which were both existing in my project). This does not solve the issues though.

Facing the same problem with my own SvelteKit project I also noticed that the default project also doesn't build.
It was a bit tricky to see which release introduced this bug, but from my experiments it looks like builds start to fail from<EMAIL_ADDRESS>(although that fails with a different error request in handle has been replaced with event).
I arrived at this conclusion by doing the following (which might not be the correct approach..)
npm init<EMAIL_ADDRESS>my-app (builds)
npm i -D @sveltejs/adapter-static@next (builds)
npm install -D<EMAIL_ADDRESS>(builds)
npm install -D<EMAIL_ADDRESS>(fails)

I'm finding a similar issue (though my build is failling silently, just not generating the index.html file. I pinned static-adapter on 1.0.0-next.26,  and tried rolling back kit versions and building until it worked. For me, 1.0.0-next.231 is where it stops working.

I don't entirely understand how this is happening but I've narrowed it down. Basically, node-fetch doesn't allow you to "consume" a response body more than once, i.e. you can't call await response.text() more than once on the same response. That's the immediate cause of the error.
It happens in prerender's visit() method. It calls app.render() which populates the dependencies Map. The values of the map are Response objects. The body of these Response objects is consumed in load_node here. Then, when visit() iterates through the dependencies, it tries to consume the body again here. This fails for the reason described above.
I'm not sure what the right fix would be here because I don't understand the code well enough but I'm pretty sure this is the source of the error.

got this problem too

Unfortunately, I have no clue how to fix it now :(

I'm facing this problem too, it's been an absolute nightmare.
Does anybody know if the team is working on a fix for this?

Reproducible on my end with demo app + adapter-static. According to https://github.com/node-fetch/node-fetch/issues/533#issuecomment-429261523, perhaps we can use .clone() internally for the prerenderer. The issue likely came up when we switch to using the Response object.

The body used already for also happens with the adapter-netlify.
SvelteKit 1.0.0-next.240
Netlify Adapter 1.0.0-next.42

I just got this error as well.
  npmPackages:
    @sveltejs/adapter-static: next => 1.0.0-next.26
    @sveltejs/kit: next => 1.0.0-next.241

I dont know if it helps but before svelte build there is this message:
17:07:24 [vite-plugin-svelte] vite-plugin-svelte was unable to find package.json of the following packages and wasn't able to resolve via their "svelte" field.
If you had difficulties importing svelte components from a package, then please contact the author and ask them to export the package.json file.
- fs

I would contact the author of fs module but i have a weird feeling they wont be interested in my issue :-)

confirmed @russellgoldenberg's observation that pinning dependency to npm i -D<EMAIL_ADDRESS>worked.

Where can one find a list of the versions available for static adapter and kit? @sw-yx suggestions didn't work on my end.

Just tried rolling back versions and it looks like it doesn't work on my end. Tried going back a few months.

@eba8 when you downgrade version remember also to clean npm cache and also write version explicitly in package.json. I got stuck for a while on this process because i forgot about the npm cache one day.

Just ran into this and did what @sw-yx and @pavelloz suggested, and it worked.

Maybe I'm doing this wrong?
I've updated package.json with @sveltejs/adapter-static": "^1.0.0-next.24 and @sveltejs/kit": "^1.0.0-next.231.
Deleted svelte-kit files, build and node modules.
Ran npm cache clean --force
did npm install
npm run build
The error I still get: body used already for

With the help of my amazing friend @octokatherine it's now working.
My mistake was having ^ in the versions.
Package.json with @sveltejs/adapter-static": "1.0.0-next.24 and @sveltejs/kit": "1.0.0-next.231 works

Ah yes, the dirty ^ :-) Its not really freezing if its ^ :-)

I'm using adapter-auto.
Started getting this error from today on the release of 1.0.0-next.292.
Using version 1.0.0-next.291 fixes this problem for me.

I'm having this problem right now. No index.html file is created in build folder using adapter-static 1.0.0-next.29 and svelte/kit next. Using versions @eba8 mentioned works but would like to use latest version.
Is this bug and something that will be fixed or a new way of doing things. Causes my aws-amplify build to fail and caused capacitor build to fail

This problem still exists with<EMAIL_ADDRESS>

Same issue for me 😕


APA102 LoadProhibited when Bluetooth is enabled and data pin 19 is used

Hi @bbulkow, thanks again for a great port and for keeping this port maintained with the latest esp32 fastled improvements. With dual mode bluetooth controller enabled on esp-idf v4.2, trying to run your fastfade on a single APA102 status led throws a LoadProhibited exception if my data pin is GPIO 19. The animation appears to run fine on WS2812B leds using GPIO 19 for data out.
I basically just cloned the master branch, enabled bluetooth and flashed the app. I have no bluetooth-specific code, just the component enabled and set to dual mode.
Steps to reproduce:

Clone fresh master branch
Copy sdkconfig.4-2 over to sdkconfig
In menuconfig, enable dual mode bluetooth
Comment out WS2812B addLeds call and switch with the APA102 example you already had in there, but with GPIO 19 as data.

FastLED.addLeds<APA102, 19, 15>(leds, NUM_LEDS);

Other than this, there are no changes to the main.cpp file. Immediately after "entering app main, call add leds" is logged, the error below is thrown (full application log pasted for context). Is there something about GPIO 19 that I may not understand? I see that it's used as an SPI pin according to this article, but the official datasheet doesn't seem to suggest that GPIO 19 is reserved when BT is in use.
Thanks!
rst:0x1 (POWERON_RESET),boot:0x13 (SPI_FAST_FLASH_BOOT)
configsip: 0, SPIWP:0xee
clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
mode:DIO, clock div:2
load:0x3fff0030,len:4
load:0x3fff0034,len:7412
load:0x40078000,len:14724
ho 0 tail 12 room 4
load:0x40080400,len:4232
0x40080400: _init at ??:?

entry 0x40080690
I (30) boot: ESP-IDF v4.2-dev-2084-g98d5b5dfd 2nd stage bootloader
I (30) boot: compile time 07:36:10
I (31) boot: chip revision: 1
I (35) boot.esp32: SPI Speed      : 40MHz
I (39) boot.esp32: SPI Mode       : DIO
I (44) boot.esp32: SPI Flash Size : 4MB
I (49) boot: Enabling RNG early entropy source...
I (54) boot: Partition Table:
I (58) boot: ## Label            Usage          Type ST Offset   Length
I (65) boot:  0 nvs              WiFi data        01 02 00009000 00006000
I (72) boot:  1 phy_init         RF data          01 01 0000f000 00001000
I (80) boot:  2 factory          factory app      00 00 00010000 00100000
I (87) boot: End of partition table
I (91) esp_image: segment 0: paddr=0x00010020 vaddr=0x3f400020 size=0x063d8 ( 25560) map
I (109) esp_image: segment 1: paddr=0x00016400 vaddr=0x3ffbdb60 size=0x02404 (  9220) load
I (113) esp_image: segment 2: paddr=0x0001880c vaddr=0x40080000 size=0x00404 (  1028) load
0x40080000: _WindowOverflow4 at /Users/drewandre/esp/esp-idf/components/freertos/xtensa/xtensa_vectors.S:1730

I (119) esp_image: segment 3: paddr=0x00018c18 vaddr=0x40080404 size=0x07400 ( 29696) load
I (139) esp_image: segment 4: paddr=0x00020020 vaddr=0x400d0020 size=0x156fc ( 87804) map
0x400d0020: _stext at ??:?

I (170) esp_image: segment 5: paddr=0x00035724 vaddr=0x40087804 size=0x02978 ( 10616) load
0x40087804: multi_heap_assert at /Users/drewandre/esp/esp-idf/components/heap/multi_heap_platform.h:65
 (inlined by) merge_adjacent at /Users/drewandre/esp/esp-idf/components/heap/multi_heap.c:242

I (180) boot: Loaded app from partition at offset 0x10000
I (180) boot: Disabling RNG early entropy source...
I (182) cpu_start: Pro cpu up.
I (186) cpu_start: Application information:
I (191) cpu_start: Project name:     FastLED-idf
I (196) cpu_start: App version:      1
I (200) cpu_start: Compile time:     Sep  2 2020 07:36:07
I (206) cpu_start: ELF file SHA256:  00e68454ee48f8ba...
I (212) cpu_start: ESP-IDF:          v4.2-dev-2084-g98d5b5dfd
I (219) cpu_start: Starting app cpu, entry point is 0x4008174c
0x4008174c: call_start_cpu1 at /Users/drewandre/esp/esp-idf/components/esp32/cpu_start.c:282

I (0) cpu_start: App cpu up.
I (229) heap_init: Initializing. RAM available for dynamic allocation:
I (236) heap_init: At 3FFAE6E0 len 0000F480 (61 KiB): DRAM
I (242) heap_init: At 3FFC0898 len 0001F768 (125 KiB): DRAM
I (248) heap_init: At 3FFE0440 len 00003AE0 (14 KiB): D/IRAM
I (255) heap_init: At 3FFE4350 len 0001BCB0 (111 KiB): D/IRAM
I (261) heap_init: At 4008A17C len 00015E84 (87 KiB): IRAM
I (267) cpu_start: Pro cpu start user code
I (285) spi_flash: detected chip: gd
I (286) spi_flash: flash io: dio
W (286) spi_flash: Detected size(16384k) larger than the size in the binary image header(4096k). Using the size in the binary image header.
I (296) cpu_start: Starting scheduler on PRO CPU.
I (0) cpu_start: Starting scheduler on APP CPU.
 entering app main, call add leds
Guru Meditation Error: Core  0 panic'ed (LoadProhibited). Exception was unhandled.

Core  0 register dump:
PC      : 0x40082af0  PS      : 0x00060630  A0      : 0x800d2f60  A1      : 0x3ffb1eb0
0x40082af0: __pinMode at /Users/drewandre/Downloads/FastLED-idf/build/../components/FastLED-idf/hal/esp32-hal-gpio.c:131

A2      : 0x00000013  A3      : 0x00000002  A4      : 0x00000000  A5      : 0x3ffb3b50
A6      : 0x00000000  A7      : 0x3ffb3b60  A8      : 0x3f404860  A9      : 0x00000000
A10     : 0x00000074  A11     : 0x0a732520  A12     : 0x00060620  A13     : 0x00060623
A14     : 0x00000001  A15     : 0x00000000  SAR     : 0x00000014  EXCCAUSE: 0x0000001c
EXCVADDR: 0x0a732520  LBEG    : 0x400014fd  LEND    : 0x4000150d  LCOUNT  : 0xfffffff7

Backtrace:0x40082aed:0x3ffb1eb0 0x400d2f5d:0x3ffb1ed0 0x400d37c9:0x3ffb1ef0 0x400d3186:0x3ffb1f10 0x400d1907:0x3ffb1f40
0x40082aed: __pinMode at /Users/drewandre/Downloads/FastLED-idf/build/../components/FastLED-idf/hal/esp32-hal-gpio.c:131

0x400d2f5d: APA102Controller<(unsigned char)19, (unsigned char)15, (EOrder)10, 20u>::init() at /Users/drewandre/Downloads/FastLED-idf/build/../components/FastLED-idf/platforms/esp/32/fastpin_esp32.h:27
 (inlined by) ?? at /Users/drewandre/Downloads/FastLED-idf/build/../components/FastLED-idf/fastspi_bitbang.h:39
 (inlined by) APA102Controller<(unsigned char)19, (unsigned char)15, (EOrder)10, 20u>::init() at /Users/drewandre/Downloads/FastLED-idf/build/../components/FastLED-idf/chipsets.h:231

0x400d37c9: CFastLED::addLeds(CLEDController*, CRGB*, int, int) at /Users/drewandre/Downloads/FastLED-idf/build/../components/FastLED-idf/FastLED.cpp:39 (discriminator 4)

0x400d3186: app_main at /Users/drewandre/Downloads/FastLED-idf/build/../components/FastLED-idf/FastLED.h:252
 (inlined by) app_main at /Users/drewandre/Downloads/FastLED-idf/build/../main/main.cpp:272

0x400d1907: main_task at /Users/drewandre/esp/esp-idf/components/esp32/cpu_start.c:589

ELF file SHA256: 00e68454ee48f8ba

Rebooting...

Did you have the same issue with your environment with a WS2811 format string, and with bluetooth disabled?
Thanks for the report, I'll give it a try.

Oh, please notice, you're using the 4.2 SKD with master, which is post 4.2. Don't do that.
When using master, you should generate your own SDKCONFIG based on the master you have. Basically, remove sdkconfig, run menuconfig and set for your chip, and run. Espressif's SDKCONFIG is simply not very stable, it seems they are always adding and removing things.
There's nothing specific in the FastLED config that requires sdkconfig settings (afaik so far :-). I will update the doc to make that more clear.

Hi @bbulkow -- when you suggest trying WS2811 with bluetooth disabled, you're basically asking if the example runs after a fresh clone, right? Because the LED_TYPE is already WS2811 and bluetooth is disabled in the example on the master branch. But to answer your question, yeah it runs out of the box.
I re-generated the sdkconfig from scratch like you suggested. After enabling bluetooth (not even in dual-mode like I previously mentioned, just all default bluetooth configurations), setting the LED type to APA102 and settings it's data pin to 19 (with a clock pin of 15), I get the same error as above even with the (awesome) changes you pushed to master four days ago to address flickering.

Sorry if I was unclear. I was asking if you could try your test case using a fresh sdkconfig. In your description, you've mismatched using the "sdkconfig4.2" with a master tree. Can you do exactly what you did, but instead of using one of the checked in sdkconfig, delete the sdkconfig completely, do an idf.py menuconfig to create a new one, set whatever you want to set, and try again?

Hey @bbulkow, in my comment above I mentioned that I did generate the sdkconfig from scratch like you suggested. I totally blew away all sdkconfig files and re-ran menuconfig to generate a new one. Let me know if I can help debug at all!

Good news is it's reproducing on my machine. Should have an update shortly.

Going to mark this as resolved. Please reopen if problem has not been resolved with today's checkins.


alternative initial split ?

Thanks, very intriguing. After the initial split, the refinement should be unique because there is only one way to split a right-angle triangle into two right-angle triangles by splitting the diagonal. So the resulting mesh can be reproduced given the same input DEM and max. error.
However, there are two options for the initial split. Currently, the diagonal from 0,0 to sizeX, sizeY is used for the initial split (https://github.com/mapbox/martini/blob/master/index.js#L159). Equally valid would be an alternative, initial split: from 0, sizeY to sizeX, 0.
In some cases, the alternative, initial split may lead to a more optimized mesh, eg. fewer triangles and there may be situations where exploring both options would be worth the (doubled) cost. Perhaps this is discussed in the original publication. In most cases, it should not matter much. It may be possible to prove that at most only a few triangles can be saved.
Consider adding an option to choose which initial split to use ? Then a user could explore both if wanted, and choose one.

Looking just at the figures of https://www.cs.ubc.ca/~will/papers/rtin.pdf, there is also the option to divide the initial square into four triangles, using the center as an additional vertex. This would avoid the ambiguity of having two alternatives for the initial split, probably a benefit. That would require a minimum size of 3 rather than 1 which should not have practical consequences.

Since the second split should generate the exact same four triangles for both alternatives, it actually should not matter at all which initial split to choose. So I think I can close this.

yeah, tested in fork. sorry for the noise.

After the second split there should be no difference between the two initial splits. Unless the second split is not necessary which is essentially never the case anyways. Just for completeness.


Missing Check for Updates on Mac ?

@normalser weird, do you have update.channel configured in settings maybe? Is this an unsigned version of Code?

@bpasero Yes, sorry - you are right. I wanted to turn off automatic update in order not to use data via Hot Spot and then only way to do it I guess is to switch channel to none.
Maybe it would make sense to be able to have channel set to default but be able to configure vscode not to do automatic updates - which would require user to manually click "Check for Updates..." Thanks

I suggest a setting labelled update.behavior with the following options (each option progressively includes features of the previous):

none - Completely turns off update system.
manual - Turns off automatic updates in any form, but allows manually checking for updates.
notify - Turns off automatic download of updates, but automatically checks update availability and alerts user for manual download.
download - Downloads the update, but alerts the user for manual installation. (Does not automatically install upon restart.)
install - Downloads and installs the update automatically upon restart.
default - Follow a default behavior, which could be predefined internally as any of the other options (most likely the install option). This option allows Microsoft to change default behavior from version to version, without affecting users who selected a non-default behavior.

This is done:


⚠ Jenkins Plugins Artifactory has degraded performance

In b0334f1, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1344 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 2bcaf71 after 34 minutes.


Remove some new-delete patterns and refine LockManager hash function

Use unique_ptr in LogCollector and LockManager
Use deque in LogCollector
Refine LockManager::hash to prevent string copy
Rewrite Server::cleanupExitedSlaves to remove unused std::list

Thanks all. Merging...


Repackage - Fortinet FortiGate Next-Generation Firewall

Required items, please complete
Change(s):

See guidance below

Reason for Change(s):

See guidance below

Version Updated:

Required only for Detections/Analytic Rule templates
See guidance below

Testing Completed:

See guidance below

/Package


Demonstrator notebook for Flip Flop Index

Please add a demonstrator notebook for Flip Flop Index

This is now done


Add 3 new settings to the modal component: disablePageScrolling, focusElement, focusReturnElement.

Example:
		var modal1 = ui("#modal1").modalControl({
		    transitionDuration: 500,
		    closeFromBackdrop: true,
		    disablePageScrolling: true,
		    focusElement: "#modal1SaveButton",
		    focusReturnElement: "#FirstName"
		});

Completed.


Add regex validation for productCode in schemas

Winget-Create currently does not have any validation for the ProductCode field, which relies on the schema patterns found in the manifest schemas. I've added the regex validation pattern to help validate the productCode input value.
microsoft/winget-create#140
Explanation for regex:
^ indicates the start of a string.
[{]? indicates that '{' character can be optional.
[0-9a-fA-F]{8} indicates that 8 (0-9 or a-f or A-F) hexadecimal values are expected.
– represents the hyphens.
([0-9a-fA-F]{4}-){3} indicates that 4 hexadecimal values and a hyphen are expected and that this pattern is repeated {3} times.
[0-9a-fA-F]{12} indicates that 12 hexadecimal values are expected
[}]? indicates that the ‘}’ character is optional.
$ indicates the ending of the string.
Microsoft Reviewers: Open in CodeFlow

There is no valid regex for ProductCode as we use it.  It is just a string that we match against registry key names.

Adding on to that, ImageMagick.ImageMagick is an example of a package where the ProductCode is not a GUID:
PS C:\Users\easton\Downloads> wingetdev validate .\<IP_ADDRESS>\
Manifest validation failed.
Manifest Error: Schema validation failed.
Error context: <root>[Installers][0][ProductCode] Description: Failed to match regex specified by 'pattern' constraint.
Error context: <root>[Installers][0] Description: Failed to validate against schema associated with property name 'ProductCode'.
Error context: <root>[Installers] Description: Failed to validate item #0 in array.
Error context: <root>[Installers][1][ProductCode] Description: Failed to match regex specified by 'pattern' constraint.
Error context: <root>[Installers][1] Description: Failed to validate against schema associated with property name 'ProductCode'.
Error context: <root>[Installers] Description: Failed to validate item #1 in array.
Error context: <root> Description: Failed to validate against schema associated with property name 'Installers'.
 File: ImageMagick.ImageMagick.installer.yaml

PS C:\Users\easton\Downloads>

Ah okay, my misunderstanding then, I thought the ProductCode had to be in the format of a GUID.


Metal: Minor improvements to shader cache

This PR is just some minor improvements to #96052 to remove an unnecessary allocation and reduce the size of the cache entry. I've also renamed the tracing subsystem name from org.stuartcarnie to org.godotengine for the Metal driver.

Thanks!


Post: "More Tags" section is empty

The "More Tags:" line is empty:

See https://beta.advisory.sg/conversations-with-pearlyn-ong-2/ for the page. This is likely related to https://github.com/AdvisorySG/dawn-advisory-theme/issues/79.

Issue is likely due to the following piece of code in partials/content.hbs:

The check here only ensures that there is more than 1 tag, when it should be checking if there is more than 1 external tag.

Try setting the full list of internal tags as a setting, see https://ghost.org/docs/themes/custom-settings/.


FIX: Message order consistency and MessageMover fix

In https://meta.discourse.org/t/moving-chat-messages-to-a-new-channel-jumbled-them-all-up/227301
we were having issues with moved messages between channels
being jumbled up. During investigations it was found that
the ChatController /messages route ordered messages by ID
but everything else, including the message mover, ordered by
created_at.
This commit makes things consistent by changing the /messages
route to also order by created_at. In addition, the MessageMover
now begins moved message created_at times 5 seconds in the
future, and adds a 0.5s increment in time for each new message
created in the destination channel.
This should make it so the order is always consistent in the UI.

Failure unrelated:
Test Errors
----------------------------------------------
  Test Failed: defaults
    Assertion Failed:
    at Object.eval (unit/lib/chat-window-store-test:8:21)
    at Object.eval (discourse/tests/helpers/qunit-helpers:225:17)
    at processModule (qunit:1192:16)
    at module$1 (qunit:1217:4)
    at discourseModule (discourse/tests/helpers/qunit-helpers:194:25)
    at eval (unit/lib/chat-window-store-test:4:37)
    at obj (discourse-loader:371:31)

Adding 0.5s - can we do order(:created_at, :id) instead? Wouldn't that solve the problem?
Also, creating messages 5 seconds into the future does not sound like a good idea. We don't want to deal with stuff like a unread message separator saying "Tomorrow".

Adding 0.5s - can we do order(:created_at, :id) instead? Wouldn't that solve the problem?

Hmm you may be right, perhaps we can try that as a first pass and do the other part later if needed.

Also, creating messages 5 seconds into the future does not sound like a good idea. We don't want to deal with stuff like a unread message separator saying "Tomorrow".

I get your point but I would think it highly unlikely that this would happen or that anyone would see this. I could just space out the messages by 0.001 seconds :P Anyway, will remove that part for now and just do the order change.

@CvX I have made those changes, can you please take another look :)

Unrelated test failure:
Test Errors
----------------------------------------------
  Test Failed: Chat float open to DM channel with unread messages with sidebar off
    Assertion Failed: failed, expected argument to be truthy, was: false
      Expected: true, Actual: false
    at eval (acceptance/chat-test:924:21)
    at Object.eval (discourse/tests/helpers/qunit-helpers:381:9)
    at processModule (qunit:1192:16)
    at module$1 (qunit:1217:4)
    at acceptance (discourse/tests/helpers/qunit-helpers:377:25)
    at eval (acceptance/chat-test:859:32)
    at obj (discourse-loader:371:31)


LUN-237: Optimize trophy icons

This pull request belongs to an issue on our bugtracker.
You can find it there by looking for an issue with the key which is mentioned in the title of this pull request.
It starts with the keyword LUN.

Tested on android emulator


remove expensify card from bank icons

Details

Originally, we were showing all imported credit cards, bank accounts, and payment cards in the payments page of the app. I made this change in order to update the icon that was being used when an Expensify Card was one of the imported cards.
With this PR from @stitesExpensify, we're no longer showing imported credit cards, we're now only showing bank accounts and payment cards. Bank accounts show the bank logo and payment cards always show the default credit card icon. Because of this, an Expensify/Expensify Card logo will never be needed since Expensify isn't a possible option as an imported bank account.
So this PR effectively reverts what https://github.com/Expensify/App/pull/5216 did since https://github.com/Expensify/App/pull/5212 made it obsolete.
Tests

Open the Payments page on an account that has a at least one bank account or payment card
Make sure the bank accounts/payment cards are showing. A bank should have the bank icon and a payment card should have the credit card icon

QA Steps

Open the Payments page on an account that has a payment card and at least one imported bank account
Make sure the bank accounts are showing with their icon and the payment card is showing with the credit card icon

Tested On
I tested on web as you can see here. There's nothing really to test, since the icon being removed will never actually show.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to production by @Jag96 in version: 1.1.0-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Moved server start log to app.listen callback

This is done in order to ensure that the app is properly initialized and listening, before logging in the console.

Thanks for submitting this! Looks good to me.


[bug 1167192] Copy Jinja2 i18n extension from tower.

I only brought the bits that collapse whitespace in blocks.
r?

This looks awesome. I want to take it through its paces. I'll do that tonight.

I had that one nit. Otherwise this looks ok. I'll test it out now.

Looks good testing-wise. I think I'll just land it and we can deal with the nit later if we feel like it.

thank you!


⚠ Fortnite has degraded performance

In cb39277, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1555 ms

Resolved: Fortnite performance has improved in 57b7238.


Clarification that workloads/components should be targeted by the Build Tools installer needed

The only direct reference to the Build Tools installer is the link to it in the "See also" section. The second link on the page, "Use Command-Line Parameters to Install Visual Studio 2017", refers to the installers for VS. While the syntax and switches of the installer are the same, this can imply that these components can be targeted from the VS installers.
The document could use some modification in a prominent location to make it obvious, especially when landing on the page from an Internet search, that the Build Tools installer should be used to target these components.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1e062363-94e9-f776-650f-a0723ab713a3
Version Independent ID: 9181db12-cbdf-6f95-27f1-833930d6d323
Content: Visual Studio Build Tools 2017 workload and component IDs - Visual Studio
Content Source: docs/install/workload-component-id-vs-build-tools.md
Product: visual-studio-dev15
GitHub Login: @TerryGLee
Microsoft Alias: tglee

@lmf-mx Thanks for your feedback! We'll certainly take this under advisement for either improving this page, or creating a different experience with regard to documenting Build Tools. We'll place this in our backlog catalog for the moment, but will report back soon.

@lmf-mx The document has been adjusted to highlight using the installer.

@lmf-mx We've added information that you requested to the page. We'll close this issue now. Thanks for helping us improve the documentation!


Dashboard: Jira tickets table doesn't show MPF tickets

Dashboard Nightly Regression Report - del doesn't show MFP tickets in Jira Tickets table.
cc. @hursevich @vdelendik

choose proper project to submit specific tickets


feat: Upgrade to RN 77

Hm.
Build fails because TurboReactPackage has been replaced with BaseReactPackage.
Once I replace that in Nitro, Screens and SafeArea, it builds but fails to find PlatformConstants:
- E  'Invariant Violation: TurboModuleRegistry.getEnforcing(...): \'PlatformConstants\' could not be found. Verify that a module by this name is registered in the native binary.', { [Component Stack] name: 'Component Stack' }


Dealing with changes in identifiers over time, adding provenance for local IDs

identifier fields are (rightly) required throughout. However, at the start of a project a Dataset will not yet have a global identifier like a DOI, so implementing systems will need to provide a local identifier with type other. Similarly, if researchers have not yet signed up for an ORCID iD a local id will have to be supplied.
For these to be useful when systems integrate it would be helpful if the provenance of those identifiers could be added. Possibly as another entry in each of the something_id fields, with cardinality 0..1? Tracking the provenance of each identifier individually will enable integrating systems to re-use externally generated identifiers in the document rather than reassign them (for example, if a DMP is constructed from multiple cooperating systems).
As the DMP should be a living document, local ids should probably then be replaced with global ones when they become available (eg. when a DOI is created for a dataset). If an integrating system needs to track these changes and match the ids the record history of the DMP could be used to do so.

➕ for this. We have been thinking about it as well. It would also be nice to supply these system-specific identifiers when they call the API in the event that they do not have the time or resources to update their code to capture things like ORCIDs, etc. (perhaps helping lower the bar to adoption of this standard).
I was originally leaning towards something like:
  {
    "type": "other",
    "provenance": "system_a",
    "identifier": 123
  }

It could also be possible to supply the name of the system in the type attribute:
 {
    "type": "system_a",
    "identifier": 123
  }

If we allow for this, we could do other interesting things as well like providing a callback URL for updates. Something along the lines of the HATEOAS pattern.
For example a researcher creates a DMP in some tool and designates a specific repository. The DMP system sends the DMP maDMP json to the repository system with the callback URL. The repository system (at some point in the future) receives a dataset from the researcher. The repository system could then use that callback URI to send the DMP system the dataset's DOI

I just joined the call earlier on, sorry if I miss some context in the wider project on this ticket...
Question: should identifiers expire? But still be recorded for data provenance?
E.g. have a primary identifier and also previous (unused?) identifiers. Or each identifier to have a timespan (created_date, deleted_date... or created_date, replaced_date, replaced_by). I've just found a similar approach: https://github.com/RDA-DMP-Common/RDA-DMP-Common-Standard/issues/34#issuecomment-637598524

I just joined the call earlier on, sorry if I miss some context in the wider project on this ticket...
Question: should identifiers expire? But still be recorded for data provenance?
E.g. have a primary identifier and also previous (unused?) identifiers. Or each identifier to have a timespan (created_date, deleted_date... or created_date, replaced_date, replaced_by). I've just found a similar approach: https://github.com/RDA-DMP-Common/RDA-DMP-Common-Standard/issues/34#issuecomment-637598524

I think that there is a fundamental issue to be discussed first:
Should the DMP standard attempt to convey "history" or, rather, simply be a mechanism for conveying the current known state of the DMP?
If we decide that we want to convey a historic record of DMP changes too, then we need to model this very carefully, and we need to anticipate a significant growth in complexity. Provenance might need to be recorded for anything that could change (note, not only IDs).
I strongly recommend that we do not assume a need to record revision history, without carefully considering the consequences.


⚠ ClamAV has degraded performance

In f5596e2, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 449 ms

Resolved: ClamAV performance has improved in bdea997.


Added Kubevious to Cluster Administration Addons

Kubevious is an application-centric visualizer for Kubernetes.
Kubevious improves Kubernetes usability by identifying configuration errors, enforcing best practices, time machine, and other capabilities to make configuration more obvious and safe.

I signed it

@kbhawkey, @jimangel, please see the link below for your reference:
https://deploy-preview-22068--kubernetes-io-master-staging.netlify.app/docs/concepts/cluster-administration/addons/

@sftim, thanks for reviewing. I checked the content guide, it says "Docs can link to third-party open source software (OSS) outside the Kubernetes project only if it's necessary for Kubernetes to function." While Kubevious is an OSS project. Its necessity for Kubernetes to function is same as with other two visualization tools (Dashboard and WeaveScope) listed in Visualization & Control

Hi @rubenhak
Can you add some extra detail about how https://kubevious.io/ is necessary for Kubernetes to function? For example: if I have a cluster and remove that tool, what are the symptoms?

Hi @rubenhak
Can you add some extra detail about how https://kubevious.io/ is necessary for Kubernetes to function? For example: if I have a cluster and remove that tool, what are the symptoms?

@sftim, while Kubernetes will continue to operate after removing Kubevious, it would be very hard for Kubernetes operators to manage application deployments and function efficiently.
In that regards it is similar to WeaveScope. While WeaveScope provides visualization of operational state of apps, Kubernetes provides visualization of configuration of apps. WeaveScope and Kubevious are complementing and together provide best experience to Kubernetes.

WeaveScope

There's an open issue to remove links like that - see https://github.com/kubernetes/website/issues/20232

WeaveScope

There's an open issue to remove links like that - see #20232

Understood. Thanks for reviewing.

I'm minded to close this PR. @rubenhak I hope I've explained why this PR falls outside the content guidelines.

@sftim, sure, please do

/close
Proposed change is out of line with website content guide.


[sdl2-image] Bump to 2.6.3

[X] Changes comply with the maintainer guide
[X] SHA512s are updated for each updated download
[X] The "supports" clause reflects platforms that may be fixed by this new version
[X] Any fixed CI baseline entries are removed from that file.
[X] Any patches that are no longer applied are deleted from the port's directory.
[X] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[X] Only one version is added to each modified port's versions file.

Thanks for your update. Now feature sdl2-image[libwebp] build failed with the following error:
-- SDL2_image: Using system libwebp
CMake Error at E:/Lily/sdl2/downloads/tools/cmake-3.25.1-windows/cmake-3.25.1-windows-i386/share/cmake-3.25/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find webp (missing: webp_LIBRARY)
Call Stack (most recent call first):
  E:/Lily/sdl2/downloads/tools/cmake-3.25.1-windows/cmake-3.25.1-windows-i386/share/cmake-3.25/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
  cmake/Findwebp.cmake:17 (find_package_handle_standard_args)
  E:/Lily/sdl2/scripts/buildsystems/vcpkg.cmake:843 (_find_package)
  CMakeLists.txt:610 (find_package)

-- Configuring incomplete, errors occurred!

Could you please also fix it? libwebp updated by PR #29165.

I was able to make it build on Windows by introducing a new patch that removes SDL_image's custom findwebp and instead rely on the config files shipped with libwebp. Is this acceptable ?

The patch
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 438a0aa..4e10733 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -607,7 +607,7 @@ if(SDL2IMAGE_WEBP)
         list(APPEND INSTALL_EXTRA_TARGETS webp)
     else()
         message(STATUS "${PROJECT_NAME}: Using system libwebp")
-        find_package(webp REQUIRED)
+        find_package(WebP CONFIG REQUIRED)
         list(APPEND PC_REQUIRES libwebp)
     endif()
     if(SDL2IMAGE_WEBP_SHARED)
@@ -683,7 +683,6 @@ if(SDL2IMAGE_INSTALL)
             "${CMAKE_CURRENT_BINARY_DIR}/SDL2_imageConfig.cmake"
             "${CMAKE_CURRENT_BINARY_DIR}/SDL2_imageConfigVersion.cmake"
             cmake/Findlibjxl.cmake
-            cmake/Findwebp.cmake
         DESTINATION "${PKG_PREFIX}"
         COMPONENT devel
     )
diff --git a/SDL2_imageConfig.cmake.in b/SDL2_imageConfig.cmake.in
index ae38719..fd5b93e 100644
--- a/SDL2_imageConfig.cmake.in
+++ b/SDL2_imageConfig.cmake.in
@@ -66,8 +66,7 @@ if(SDL2IMAGE_TIF AND NOT SDL2IMAGE_VENDORED AND NOT TARGET TIFF::TIFF)
 endif()

 if(SDL2IMAGE_WEBP AND NOT SDL2IMAGE_VENDORED AND NOT TARGET WebP::webp)
-    list(APPEND webp_ROOT "${CMAKE_CURRENT_LIST_DIR}")
-    find_dependency(webp)
+    find_dependency(WebP)
 endif()

 #FIXME: can't add SDL2IMAGE_SDL2_REQUIRED_VERSION since not all SDL2 installs ship SDL2ConfigVersion.cmake
diff --git a/cmake/Findwebp.cmake b/cmake/Findwebp.cmake
deleted file mode 100644
index 23982dd..0000000
--- a/cmake/Findwebp.cmake
+++ /dev/null
@@ -1,32 +0,0 @@
-include(FindPackageHandleStandardArgs)
-
-find_library(webp_LIBRARY
-    NAMES webp
-)
-
-find_path(webp_INCLUDE_PATH
-    NAMES webp/decode.h
-)
-
-set(webp_COMPILE_OPTIONS "" CACHE STRING "Extra compile options of webp")
-
-set(webp_LINK_LIBRARIES "" CACHE STRING "Extra link libraries of webp")
-
-set(webp_LINK_FLAGS "" CACHE STRING "Extra link flags of webp")
-
-find_package_handle_standard_args(webp
-    REQUIRED_VARS webp_LIBRARY webp_INCLUDE_PATH
-)
-
-if (webp_FOUND)
-    if (NOT TARGET WebP::webp)
-        add_library(WebP::webp UNKNOWN IMPORTED)
-        set_target_properties(WebP::webp PROPERTIES
-            IMPORTED_LOCATION "${webp_LIBRARY}"
-            INTERFACE_INCLUDE_DIRECTORIES "${webp_INCLUDE_PATH}"
-            INTERFACE_COMPILE_OPTIONS "${webp_COMPILE_FLAGS}"
-            INTERFACE_LINK_LIBRARIES "${webp_LINK_LIBRARIES}"
-            INTERFACE_LINK_FLAGS "${webp_LINK_FLAGS}"
-        )
-    endif()
-endif()

I was able to make it build on Windows by introducing a new patch that removes SDL_image's custom findwebp and instead rely on the config files shipped with libwebp. Is this acceptable ?

Thanks for your work. I think here should use find_package(WebP CONFIG REQUIRED) to link libwebp, and is there other way without calling cmake/Findwebp.cmake instead of deleting its contents, deleting contents will make the patch bigger.

I was able to make it build on Windows by introducing a new patch that removes SDL_image's custom findwebp and instead rely on the config files shipped with libwebp. Is this acceptable ?

Thanks for your work. I think here should use find_package(WebP CONFIG REQUIRED) to link libwebp, and is there other way without calling cmake/Findwebp.cmake instead of deleting its contents, deleting contents will make the patch bigger.

In the end the following patch (added in c68c75d) is enough to restore the expected behaviour:

diff --git a/cmake/Findwebp.cmake b/cmake/Findwebp.cmake
index 23982dd..c81c4b9 100644
--- a/cmake/Findwebp.cmake
+++ b/cmake/Findwebp.cmake
@@ -1,7 +1,7 @@
 include(FindPackageHandleStandardArgs)

 find_library(webp_LIBRARY
-    NAMES webp
+    NAMES webp libwebp
 )

 find_path(webp_INCLUDE_PATH

 find_library(webp_LIBRARY
-    NAMES webp
+    NAMES webp libwebp
 )

You could use find_package(webp NAMES WebP CONFIG REQUIRED).

 find_library(webp_LIBRARY
-    NAMES webp
+    NAMES webp libwebp
 )

You could use find_package(webp NAMES WebP CONFIG REQUIRED).

Just to make sure I understand, you would prefer patching the call to find_package in the main CMakeLists (and the call to find_dependency in the generated Config file) as such:
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 438a0aa..5f019fa 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -607,7 +607,7 @@ if(SDL2IMAGE_WEBP)
         list(APPEND INSTALL_EXTRA_TARGETS webp)
     else()
         message(STATUS "${PROJECT_NAME}: Using system libwebp")
-        find_package(webp REQUIRED)
+        find_package(webp NAMES WebP CONFIG REQUIRED)
         list(APPEND PC_REQUIRES libwebp)
     endif()
     if(SDL2IMAGE_WEBP_SHARED)
diff --git a/SDL2_imageConfig.cmake.in b/SDL2_imageConfig.cmake.in
index ae38719..f1cc020 100644
--- a/SDL2_imageConfig.cmake.in
+++ b/SDL2_imageConfig.cmake.in
@@ -67,7 +67,7 @@ endif()

 if(SDL2IMAGE_WEBP AND NOT SDL2IMAGE_VENDORED AND NOT TARGET WebP::webp)
     list(APPEND webp_ROOT "${CMAKE_CURRENT_LIST_DIR}")
-    find_dependency(webp)
+    find_dependency(webp NAMES WebP CONFIG)
 endif()

 #FIXME: can't add SDL2IMAGE_SDL2_REQUIRED_VERSION since not all SDL2 installs ship SDL2ConfigVersion.cmake

Yes, use find_package CONFIG module can use the library provided by vcpkg and it provide the include link.

Yes, use find_package CONFIG module can use the library provided by vcpkg and it provide the include link.

Thank you for the clarification! I have updated the patch in b3a1ac1.


DOC: investigate fit with autodiff gradient

See also https://github.com/ComPWA/tensorwaves/pull/488

Closing this for now and moving to a pure-JAX example fit for an arbitrary sum of Breit–Wigners (credits: Frederike Hanisch) on gitlab.ep1.rub.de/redeboer/breit-wigner-jax-grad-fit.


[yugabyte/yugabyte-db#16929] Add method to implement yugabyted restart

This PR adds the method to restart the yugabyted process inside the YugabyteDB container. There are 3 methods added to facilitate the process related operations:

stopYugabyteDB() - stops the yugabyted process
startYugabyteDB() - starts the yugabyted process
restartYugabyteDB(long) - restarts the yugabyted process with a wait of specified milliseconds between stopping and starting the process.

A test has also been added to ensure that the APIs are functioning as expected, to run the test, use the command:
mvn clean test -Dtest=YugabyteDBDatatypesTest#verifyConsumptionAfterRestart

To achieve this, the following changes have been made:

Container now starts with a command for infinite loop - this ensured that even if we stop the yugabyted process, we do not end up exiting from the container.
Overridden a super function from the YugabyteYSQLContainer in a new class i.e. YugabyteCustomContainer to skip the execution of waitUntilContainerIsReady method which was waiting for a successful JDBC connection, but since we are not starting the yugabyted process in the beginning, we cannot open a connection and will need to skip this method
i. We can remove this overriding once I create a contribution to the upstream container with some flag to skip this method, until then, this custom class will be used.

This PR closes yugabyte/yugabyte-db#16929

Looks good.


Implement deletion on current attached documents

Now deletion is not implemented but the UI is showing icons for deleting attached documents for both the Sponsor and CMO. Deletion should work only for the current attached documents that haven't already been saved in the documentsDSU.
Provided mockup:

Please keep in mind that no documentsDSU should be deleted after it's creation.

@kpratihast any progress on this?

Deletion is not properly working for multiple files upload. For example, chose 4 files and I delete the first one. Will be deleted the first and the third because we are not correctly identifying which file I am deleting and you are iterating through all documents that can be deleted.

after deletion, order cannot be reviewed


Service Fabric Version Dependency

Looking to add the Native package to our .Net Core Web API, dependency says >= SF 3.0.467 and our project is using 3.2.176. Got conflict error below, then did as suggested (install Microsoft.ServiceFabric.Diagnostics.Internal 3.2.176 directly) but now have warnings about versions, am I supposed to just ignore the errors?
Initial Error trying to Add..
Version conflict detected for Microsoft.ServiceFabric.Diagnostics.Internal. Install/reference Microsoft.ServiceFabric.Diagnostics.Internal 3.2.176 directly to project WebAPI to resolve this issue.
WebAPI -> Microsoft.ServiceFabric.Services 3.2.176 -> Microsoft.ServiceFabric.Diagnostics.Internal (= 3.2.176)
WebAPI -> Microsoft.ApplicationInsights.ServiceFabric.Native 2.1.1 -> Microsoft.ServiceFabric.Services.Remoting 3.0.467 -> Microsoft.ServiceFabric.Diagnostics.Internal (= 3.0.467).
Now get Warnings...
Detected package version outside of dependency constraint: Microsoft.ServiceFabric.Services.Remoting 3.0.467 requires Microsoft.ServiceFabric.Services (= 3.0.467) but version Microsoft.ServiceFabric.Services 3.2.176 was resolved.

@AdXone Yes, you can ignore this warning. But I would upgrade the Microsoft.ServiceFabric.Services.Remoting  package 3.2.176, so there should be no warnings.


Setup Travis CI

Indeed, let's try on your side since my permissions doesn't seem sufficient. I think I'll be able to control the build process since I can write to .travis.yml.

A request to install Travis CI has been submitted on the @inbo account.

Request limited to this repository of course.

Works perfectly, thanks!


Feature/support dns members

This is a simple proposed change that will support dns based member entries for RaftClusterMember

@natilivni , please merge it instead of rebase because all rebased commits visible in this PR as a part of it.

@natilivni , please merge it instead of rebase because all rebased commits visible in this PR as a part of it.

I am not sure what happened.  I did a simple merge and it has all the develop commits. I go this to work with a tiny branch on master.  Do you have a branch based on master that I can do a pull request on?  I will abandon this PR in favor of a different one.

I am not sure what happened.  I did a simple merge and it has all the develop commits. I go this to work with a tiny branch on master.  Do you have a branch based on master that I can do a pull request on?  I will abandon this PR in favor of a different one.


Add support for Type Hinting

As now, Type hinting is strongly recommended by the whole Python community and is a huge step ahead while debugging, since that information can be used for static analysis.
The cost to add Type Hinting is minimal, requires small knowledge, and makes the code more robust, secure and readable.
Do you think that fits your project goals? If so, I can be a volunteer to this task.

I think it does, to be honest. Type hinting is something I've been back and forth on actually. For bigger projects, it's basically essentail.
I'm trying to find the best balance though, there is a bit of a learning curve for newer engineers not used to type hinting. Is there some way we can account for this?

Just considered this idea also. Is this an option to create a separate branch similar as it's done with javascript and typescript in some other chainlink repos?

@vsevdrob yes, that would be awesome!!

Is anyone working actively on this issue? I'd like to contribute on this.

@nitul1991 Not sure... But it would be nice to see the first contribution on that theme!


redis-ha persistent volumes

Based off upstream PR 6706 to convert redis-ha into statefulsets but adds persistent volumes.

Manual testing proved upgrades possible.


ETH-Precision Don't Send Fee if no Fee When Saving Moderator Info

This is happening on Dispute payout precision #1838 and ethereum-master latest as of 11-27-19.
When saving a moderator fee, if it's percentage the server kicks back this error invalid profile: percentage moderator fee should not include a fixed fee or should use (FIXED_PLUS_PERCENTAGE) feeType
I'm not sure if this is a server or a desktop issue. It seems like it would be relatively simple to remove the fixedFee object if the type is percentage when saving?
Below is the data being sent.
{
  "moderator": true,
  "moderatorInfo": {
    "fee": {
      "feeType": "PERCENTAGE",
      "fixedFee": {
        "bigAmount": "0",
        "amountCurrency": {
          "code": "USD",
          "divisibility": 2
        }
      },
      "percentage": 50
    },
    "description": "This is just a test account, do not use.",
    "termsAndConditions": "No disputes will be moderated. This is only a test account.",
    "languages": [
      "en-US"
    ]
  }
}

@jjeffryes This is now fixed on the client via c2e0dd97f10d3f4bce69b6a4cf00d9277fab7b78.
However, it's still failing on the server even when we don't send the fixed fee over:
PATCH ob/profile/<peer-id>
{
  "moderator": true,
  "moderatorInfo": {
    "fee": {
      "feeType": "PERCENTAGE",
      "percentage": 0.5
    },
    "description": "Describe the scribe.",
    "termsAndConditions": "The terms are germs.",
    "languages": [
      "en-US"
    ]
  }
}

Can you please log the bug in the ob-go repo? (I would mention that we're using PATCH. I'm not sure if the same behavior also happens on PUT/POST)

Closed, the server version is at https://github.com/OpenBazaar/openbazaar-go/issues/1881


Special Chars occurs an error while compiling with sass

please change from
/// Will only select the child if it’s unique.
to
/// Will only select the child if it is unique.
if i do a npm install and include the _family.scss in my scss file and compile it with gulp/sass, it gives me an error because of bad sign. (US-ASCII) or maybe save it as UTF-8 or something.
thank you.
great project btw.

@vkemeter you have the power to contribute to the code base by fixing whatever you think is broken and submit a pull request for it :)

I will take care of it whileI have time, but if you feel like you want to send a PR, feel free!

@LukyVj would be very nice if you can merge my PR :-)


Where do SafeLinks and SafeAttachments go in the table of applying policies?

Subject describes the need - Safe attachments/Safelinks processing - where in this order do they fall?  Article is absent of information on those policies.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: d4194fdd-c5de-d424-319a-5e83774b36c2
Version Independent ID: 83997ad4-a9bd-146e-5da0-8022458cf3ea
Content: Order and precedence of email protection - Office 365
Content Source: microsoft-365/security/office-365-security/how-policies-and-protections-are-combined.md
Service: microsoft-365-security
Sub-service: mdo
GitHub Login: @chrisda
Microsoft Alias: chrisda

@chrislehr, this issue is fundamentally the same as #8514, but I'll leave it open for now.

I disagree its the same.  HC Phishing is 100% within the "anti spam policies" SafeLinks and SafeAttachments are their own policies.

@chrislehr, the verdicts or the seriousness of the verdicts aren't what I was talking about. The similarity is that both of these issues are saying a feature/verdict is missing from the order of precedence information.

That's fair.  I agree they are similar to that extent.  😄

From: Chris Davis @.>
Sent: Thursday, May 11, 2023 9:32 AM
To: MicrosoftDocs/microsoft-365-docs @.>
Cc: Chris Lehr @.>; Mention @.>
Subject: Re: [MicrosoftDocs/microsoft-365-docs] Where do SafeLinks and SafeAttachments go in the table of applying policies? (Issue #11456)
@chrislehrhttps://github.com/chrislehr, the verdicts or the seriousness of the verdicts aren't what I was talking about. The similarity is that both of these issues are saying a feature/verdict is missing from the order of precedence information.
—
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/microsoft-365-docs/issues/11456#issuecomment-1544310969, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACS7GE3PI7RN5VI5ZG2NRN3XFUIAZANCNFSM6AAAAAAWF4ZIPE.
You are receiving this because you were mentioned.Message ID: @.***>

To make it easier for you to submit feedback on articles on learn.microsoft.com, we're transitioning our feedback system from GitHub Issues to a new experience.
As part of the transition, this GitHub Issue will be moved to a private repository. We're moving Issues to another repository so we can continue working on Issues that were open at the time of the transition. When this Issue is moved, you'll no longer be able to access it.
If you want to provide additional information before this Issue is moved, please update this Issue before December 15th, 2023.
With the new experience, you no longer need to sign in to GitHub to enter and submit your feedback. Instead, you can choose directly on each article's page whether the article was helpful. Then you can then choose one or more reasons for your feedback and optionally provide additional context before you select Submit.
Here's what the new experience looks like.
Note: The new experience is being rolled out across learn.microsoft.com in phases. If you don't see the new experience on an article, please check back later.
First, select whether the article was helpful:

Then, choose at least one reason for your feedback and optionally provide additional details about your feedback:

Article was helpful
Article was unhelpful

Finally, select Submit and you're done!


[Relay] Fix Strided Slice Infer Layout

@zhiics @yongwww @anijain2305 @trevor-m

Thanks @kevinthesun This is merged!


Wrong colors after executing bat

Environment
Windows build number: 10.0.18363.0
Windows Terminal version (if applicable): 0.11.1121.0
Steps to reproduce

Install bat via chocolatey
Create a text file with content that doesn't fit into a screen height
In Windows Terminal push ENTER while the output takes more than the screen height
Open the file created at the second step with the command bat filename
Press q
Now the output has wrong colors that get back to previous colors after a few commands or after the clear command

Expected behavior
Colors should remain the same after executing console utils
Actual behavior
Here is the command prompt before performing anything

The expected bat util output

The bat util output after performing 1-4 steps. Please notice that the ":" in the bottom left corner is now black

The console prompt after performing all described steps

Also, colors remain unchanged if the bat util command is executed right after the clear command

This is, unfortunately, an application bug. bat believes that it understands the windows console API, and it's replacing the active color attributes with ones of its choosing.

(this happens outside of Terminal too:

there's a : there.
)

(THis could be related to #4177 if less is in the picture.)


canGoBack method

I want to create two different components based on the possibility to goBack or not but there is no way to know if a goBack is possible without having to calling it.
Is there a way to do this ?
Thank you

I've had the same use-case. I "solved" it by using the History object. It's undocumented though, and I don't know what it will become in 1.0 (I'm using 0.13.3).
My "back" link looks something like this now:
import {History} from 'react-router';

// ...
renderBackLink() {
  var canGoBack = (History.length > 1);
  var handleClick = (e) => {
    e.preventDefault();
    if (canGoBack) {
      this.goBack();
    } else {
      this.transitionTo('dashboard');
    }
  };
  var text = canGoBack ? 'Back' : 'To dashboard';

  return (
    {text}
  );
}

Thank you @nicolashery,
that's the solution I use for now but it bother me because I can't mock the History.length in test as it is not a function.

Are you using CommonJS? If so, you could try something like proxyquire for mocking?
But anyway, I still worry about using something that's not part of the public API of react-router...

After upgrading to 1.0-beta3, I'm now using canGoBack = (window.history.length > 1) as a check.
Still a hack :( Maybe we need a getLength() method to the History interface. Or a false returned from goBack() as mentioned in https://github.com/rackt/react-router/issues/1551.
I don't see anything mentioned about this in @mjackson's new https://github.com/rackt/history implementation though...

as we use History, maybe it will be worth to open this issue there? @nicolashery

We haven't yet been able to nail down a solid canGo method, here's some history on the topic:
https://github.com/rackt/react-router/pull/1376
https://github.com/rackt/react-router/pull/843
Maybe one day ...

Is there any way now to achieve this?


[BUG] [DEV] New scalable fuel tanks are more than double the mass and capacity that they were previously

Short Description
A 24x24x24 fuel tank now weighs 262kg, which seems insanely dense compared to before. Empty mass of the fuel tank is 88kg or so, which also seems incredibly high. Is this intended behavior? This mostly affects lighter vehicles/cars.
Branch and Version
Latest dev
How to Reproduce (Optional)
Compare any new fuel tank to any old fuel tank of the same size

There was a magic number for the longest time affecting capacity of fuel tanks which has finally been removed, solely because we now have the exact capacity of fuel tanks due to being scalable.


chore(deps): update dependency org.jasig.resourceserver:resource-server-api to 1.3.1

This PR contains the following updates:

Package
Change

org.jasig.resourceserver:resource-server-api
1.0.46 -> 1.3.1

Renovate configuration
:date: Schedule: At any time (no schedule defined).
:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.
:recycle: Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "rebase!".
:no_bell: Ignore: Close this PR and you won't be reminded about this update again.

This PR has been generated by Renovate Bot.

Verified this is API only, uPortal start controls what content is served


fix animus not working if tab was already open

This is due to content-scripts only being appended to the document when the document is first loaded. To avoid this bug, just inject all content needed whenever animus is toggled.


Eslint plugin

Search Terms
Eslint plugin

Problem
Have a eslint-plugin can help to define eslint rules which can be useful for :

mandatoring, in a pipeline build, the typedoc documentation to test developers code.
checking for missing params in the documentation, etc.

Suggested Solution
I suggest eslint-plugin-typedoc for the package name.
A similar tool exists for jsdoc : eslint-plugin-jsdoc

The JSDoc plugin you linked can be used in TypeScript files, and has rules which meet both of your requests, I'd recommend using it - not sure there is benefit to a typedoc specific plugin here.


Add sortable document number field to ra second factor overview.

@rjkip ready for inspection

Inspection complete. Proceed. :computer:

Affirmative


Conditions without operator are evaluated incorrectly

Describe the bug
Right now a condition like [if var] is accepted, but not evaluated correctly. It will treat it as true even when var is set to false.
To Reproduce
Steps to reproduce the behavior:
In the game state:
var _false = false

And in a dialogue:
~ dialogue
This is some dialogue.
- First one [if _false == true]
	This works.
- Second one [if _false]
	This doesn't.

I can't seem to replicate the issue you're having. Can you attach a tiny project that demonstrates it not working?
I tried this:
~ dialogue
# Making sure _false is false
set _false = false
The value of _false is {{_false}}.
- First one [if _false == true]
	# _false is not true so this is disabled
	Should be disabled
- Second one [if _false]
	# _false is not true so this should also be disabled
	Should also be disabled
- Third one [if _false == false]
	# _false is false so this should be the only one enabled
	Should be enabled

But I see what I would expect:


speed regression compared to v0.6

I'm seeing a significant slowdown with FFTW in v0.7 as compared to v0.6. Any idea what is going on? Note: I'm using MKL for my ffts.
Here are the timings for v0.7 .... (I would normally use BenchmarkTools to do the timings but it currently throws an error on v0.7)
julia> using FFTW

julia> FFTW.set_num_threads(8);

julia> m = rand(Float32,16384,16384);

julia> rfft(m); # warmup

julia> @time rfft(m)
  4.607740 seconds (456 allocations: 1.000 GiB, 0.92% gc time)

Here are the timings for v0.6 ....
julia> using FFTW

julia> FFTW.set_num_threads(8);

julia> m = rand(Float32,16384,16384);

julia> rfft(m); # warmup

julia> @time rfft(m)
  1.473979 seconds (426 allocations: 1.000 GiB, 4.71% gc time)

Version info for v0.7
julia> versioninfo()
Julia Version 0.7.0-DEV.1957
Commit c3a3a1c89f* (2017-09-25 23:52 UTC)
Platform Info:
  OS: macOS (x86_64-apple-darwin17.0.0)
  CPU: Intel(R) Core(TM) i7-7920HQ CPU @ 3.10GHz
  WORD_SIZE: 64
  BLAS: libmkl_rt
  LAPACK: libmkl_rt
  LIBM: libopenlibm
  LLVM: libLLVM-3.9.1 (ORCJIT, broadwell)
Environment:
  JULIA_NUM_THREADS = 8

Version info for v0.6
Julia Version 0.6.1-pre.3
Commit 4aa661a0c1* (2017-09-14 17:43 UTC)
Platform Info:
  OS: macOS (x86_64-apple-darwin17.0.0)
  CPU: Intel(R) Core(TM) i7-7920HQ CPU @ 3.10GHz
  WORD_SIZE: 64
  BLAS: libmkl_rt
  LAPACK: libmkl_rt
  LIBM: libopenlibm
  LLVM: libLLVM-3.9.1 (ORCJIT, broadwell)

Weird, I don't see a significant difference on macOS without MKL.
0.6:
julia> using BenchmarkTools

julia> FFTW.set_num_threads(8)

julia> m = rand(Float32,16384,16384);

julia> @benchmark rfft($m)
BenchmarkTools.Trial:
  memory estimate:  1.00 GiB
  allocs estimate:  78
  --------------
  minimum time:     5.126 s (0.19% GC)
  median time:      5.126 s (0.19% GC)
  mean time:        5.126 s (0.19% GC)
  maximum time:     5.126 s (0.19% GC)
  --------------
  samples:          1
  evals/sample:     1

julia> versioninfo()
Julia Version 0.6.0
Commit 903644385b (2017-06-19 13:05 UTC)
Platform Info:
  OS: macOS (x86_64-apple-darwin13.4.0)
  CPU: Intel(R) Core(TM) i7-2820QM CPU @ 2.30GHz
  WORD_SIZE: 64
  BLAS: libopenblas (USE64BITINT DYNAMIC_ARCH NO_AFFINITY Sandybridge)
  LAPACK: libopenblas64_
  LIBM: libopenlibm
  LLVM: libLLVM-3.9.1 (ORCJIT, sandybridge)

Freshly built 0.7 (depwarns edited out for sanity's sake):
julia> using BenchmarkTools, FFTW

julia> FFTW.set_num_threads(8)

julia> m = rand(Float32,16384,16384);

julia> b = @benchmarkable rfft($m)
Benchmark(evals=1, seconds=5.0, samples=10000)

julia> tune!(b);

julia> run(b)
BenchmarkTools.Trial:
  memory estimate:  1.00 GiB
  allocs estimate:  64
  --------------
  minimum time:     5.588 s (0.16% GC)
  median time:      5.588 s (0.16% GC)
  mean time:        5.588 s (0.16% GC)
  maximum time:     5.588 s (0.16% GC)
  --------------
  samples:          1
  evals/sample:     1

julia> versioninfo()
Julia Version 0.7.0-DEV.1999
Commit 38ca429c41* (2017-09-29 15:49 UTC)
Platform Info:
  OS: macOS (x86_64-apple-darwin16.7.0)
  CPU: Intel(R) Core(TM) i7-2820QM CPU @ 2.30GHz
  WORD_SIZE: 64
  BLAS: libopenblas (USE64BITINT DYNAMIC_ARCH NO_AFFINITY Sandybridge)
  LAPACK: libopenblas64_
  LIBM: libopenlibm
  LLVM: libLLVM-3.9.1 (ORCJIT, sandybridge)
Environment:

Can you try again using b = @benchmarkable(rfft($m)); tune!(b); run(b) (the functional equivalent of @benchmark rfft($m))?

Thanks for looking into it so quickly. Here are the timings using your commands. When I get a chance, I'll update v0.7 and compile it without MKL to see if it still makes a difference....
For v0.7 I get
               _
   _       _ _(_)_     |  A fresh approach to technical computing
  (_)     | (_) (_)    |  Documentation: https://docs.julialang.org
   _ _   _| |_  __ _   |  Type "?help" for help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 0.7.0-DEV.1957 (2017-09-25 23:52 UTC)
 _/ |\__'_|_|_|\__'_|  |  Commit c3a3a1c89f* (3 days old master)
|__/                   |  x86_64-apple-darwin17.0.0

julia> using BenchmarkTools, FFTW

julia> FFTW.set_num_threads(8)

julia> m = rand(Float32,16384,16384);

julia> b = @benchmarkable rfft($m)
Benchmark(evals=1, seconds=5.0, samples=10000)

julia> tune!(b);

julia> run(b)
BenchmarkTools.Trial:
  memory estimate:  1.00 GiB
  allocs estimate:  64
  --------------
  minimum time:     4.156 s (0.20% GC)
  median time:      4.179 s (0.59% GC)
  mean time:        4.179 s (0.59% GC)
  maximum time:     4.202 s (0.96% GC)
  --------------
  samples:          2
  evals/sample:     1

For v0.6 I get
_
_       _ _(_)_     |  A fresh approach to technical computing
(_)     | (_) (_)    |  Documentation: https://docs.julialang.org
_ _   _| |_  __ _   |  Type "?help" for help.
| | | | | | |/ _` |  |
| | |_| | | | (_| |  |  Version 0.6.1-pre.3 (2017-09-14 17:43 UTC)
_/ |\__'_|_|_|\__'_|  |  Commit 4aa661a0c1* (15 days old release-0.6)
|__/                   |  x86_64-apple-darwin17.0.0

julia> using BenchmarkTools, FFTW

julia> FFTW.set_num_threads(8)

julia> m = rand(Float32,16384,16384);

julia> b = @benchmarkable rfft($m)
Benchmark(evals=1, seconds=5.0, samples=10000)

julia> tune!(b);

julia> run(b)
BenchmarkTools.Trial:
memory estimate:  1.00 GiB
allocs estimate:  78
--------------
minimum time:     975.974 ms (0.89% GC)
median time:      1.019 s (5.97% GC)
mean time:        1.071 s (5.55% GC)
maximum time:     1.230 s (11.91% GC)
--------------
samples:          5
evals/sample:     1

Ok, it appears to be a problem hooking into MKL. I compiled both v0.6 and v0.7 without MKL and they both give the same timings. I would have speculated that there is a problem with the v0.7 compilation process, but the version info output appears to claim that it is linking to MKL.  Is it possible that setting the threads in v0.7 isn't working right?
One thing to note, since FFTW was moved out of Base, the Make.inc file is a bit different for v0.7.
Here is what it looks like for v0.6
## Settings for various Intel tools
# Set to 1 to use MKL
USE_INTEL_MKL ?= 1
# Set to 1 to use MKL FFT
USE_INTEL_MKL_FFT ?= 1
# Set to 1 to use Intel LIBM
USE_INTEL_LIBM ?= 0
# Set to 1 to enable profiling with Intel VTune Amplifier
USE_INTEL_JITEVENTS ?= 0
# Set to 1 to use Intel C, C++, and FORTRAN compilers
USEICC  ?= 0
USEIFC  ?= 0

For v0.7 it looks like this:
## Settings for various Intel tools
# Set to 1 to use MKL
USE_INTEL_MKL ?= 1
# Set to 1 to use Intel LIBM
USE_INTEL_LIBM ?= 0
# Set to 1 to enable profiling with Intel VTune Amplifier
USE_INTEL_JITEVENTS ?= 0
# Set to 1 to use Intel C, C++, and FORTRAN compilers
USEICC  ?= 0
USEIFC  ?= 0

Yeah, the USE_INTEL_MKL_FFT build option isn't relevant in 0.7 because FFTs were removed from Base.
But looking at the code in this repo I have a feeling that on 0.7 it isn't actually using MKL, so what you're seeing is actually a difference between MKL and plain ol' FFTW. I think I know how to fix it, but I'll need your help testing it.

I think your probably right that FFTW isn't calling MKL for some reason. Not sure how to test this but this may provide some info ... here some of the relevant(?) internal values set by FFTW in v0.7:
julia> FFTW.libfftw
"/Users/ethananderes/.julia/v0.7/FFTW/deps/usr/lib/libfftw3_threads.dylib"

julia> FFTW.libfftwf
"/Users/ethananderes/.julia/v0.7/FFTW/deps/usr/lib/libfftw3f_threads.dylib"

julia> FFTW.libfftwf_name
"libmkl_rt"

julia> FFTW.libfftw_name
"libmkl_rt"

For Julia v0.6 here is what I get
julia> FFTW.libfftw
"libmkl_rt"

julia> FFTW.libfftwf
"libmkl_rt"

julia> FFTW.libfftwf_name
ERROR: UndefVarError: libfftwf_name not defined

julia> FFTW.libfftw_name
ERROR: UndefVarError: libfftw_name not defined

i.e. the first two variables don't seem to be pointing to the same library as in v0.6

Yep, just as I suspected, it isn't using MKL on 0.7. Can you try
Pkg.checkout("FFTW")
Pkg.checkout("FFTW", "aa/mkl")
Pkg.build("FFTW")
;cat ~/.julia/v0.7/FFTW/deps/deps.jl

then rerun the benchmarks?


Added disableColorType prop for chrome

Thought it would be a nice add-on to remove the color type selector in the chrome picker as most of my users don't really care what format the color is in as they will mostly select color with the UI. This adds a prop of disableColorType that defaults to false, and when true renders the following:

Also just to note: My prettier removed the quotes from the styles object keys of default and disableAlpha, as well as reformatted the params, maybe easier to check out the diff disregarding the whitespace: https://github.com/casesandberg/react-color/pull/600/files?w=1

I appreciate your contribution! We don't want to overload specific pickers with custom props to remove elements like this. I would suggest using custom styles to achieve the same effect. We are also working on a few new color pickers in 3.0.0 and have two color pickers planned that have this same effect!