[web] 1Password autofill adds colored box over text field

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce

Flutter channel master
Autofill with 1Password on web

Expected results
The blue box is behind the text (or not there at all)
Actual results
The blue box covers the text
Code sample
Code sample
https://github.com/Rexios80/flutter_autofill_test/blob/master/lib/main.dart

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
Not relevant

Flutter Doctor output
Doctor output
Not relevant

https://github.com/flutter/flutter/issues/87735#issuecomment-1504474946

I can reproduce the bug using the code sample provided in https://github.com/Rexios80/flutter_autofill_test/blob/master/lib/main.dart?rgh-link-date=2023-04-19T10%3A35%3A03Z

flutter doctor -v
[!] Flutter (Channel master, 3.10.0-7.0.pre.45, on macOS 13.3.1 22E261 darwin-arm64, locale en-GB)
    • Flutter version 3.10.0-7.0.pre.45 on channel master at /Users/nexus/dev/sdks/flutters
    ! Warning: `flutter` on your path resolves to /Users/nexus/dev/sdks/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/nexus/dev/sdks/flutters. Consider adding /Users/nexus/dev/sdks/flutters/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/nexus/dev/sdks/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/nexus/dev/sdks/flutters. Consider adding /Users/nexus/dev/sdks/flutters/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision ade9487d68 (8 hours ago), 2023-04-19 01:43:29 -0400
    • Engine revision 8b7cdb02f7
    • Dart version 3.1.0 (build 3.1.0-15.0.dev)
    • DevTools version 2.23.1
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0
    • Java binary at: /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/222.4459.24.2221.9862592/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
    • Xcode at /Applications/Xcode-14.3.0.app/Contents/Developer
    • Build 14E222b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.1)
    • Android Studio at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/221.6008.13.2211.9619390/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)

[✓] Android Studio (version 2022.2)
    • Android Studio at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/222.4459.24.2221.9862592/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] IntelliJ IDEA Ultimate Edition (version 2023.1)
    • IntelliJ at /Users/nexus/Applications/JetBrains Toolbox/IntelliJ IDEA Ultimate.app
    • Flutter plugin version 73.0.4
    • Dart plugin version 231.8109.91

[✓] IntelliJ IDEA Ultimate Edition (version 2023.1)
    • IntelliJ at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/IDEA-U/ch-0/231.8109.175/IntelliJ IDEA.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.77.3)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.62.0

[✓] Connected device (4 available)
    • Dean’s iPad (mobile) • 00008103-000825C811E3401E • ios            • iOS 16.4.1 20E252
    • Nexus (mobile)       • 00008020-001875E83A38002E • ios            • iOS 16.4.1 20E252
    • macOS (desktop)      • macos                     • darwin-arm64   • macOS 13.3.1 22E261 darwin-arm64
    • Chrome (web)         • chrome                    • web-javascript • Google Chrome 112.0.5615.137

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

Thanks for splitting it out of https://github.com/flutter/flutter/issues/87735. It will be easier to track it this way.
Tentatively making it a P4. We can adjust if need be.


The application should allow text selections on calculation results.

Ctrl+C is already supported in the app, but:

not available on tablets/devices without keyboard.
It's not really easy to guess that you can Ctrl+C without selecting the result.
You can't copy an operation in the history
You can't copy a part of a result (to ignore the fractional part of a number for example)
If we allow users to select texts, the application will feel more like a "Desktop app", will be easier to use on a tablet and users will be more prompt to use Ctrl+C to use the result in another app.

Here is a prototype:

This is your friendly Microsoft Issue Bot. I've seen this issue come in and have gone to tell a human about it.

Thanks for the report! Agree that text selection for many of these surfaces would make this clearer.


Automatically mount config files

What this PR does / why we need it:
Awesome job so far on the oauth2-proxy chart !!
This pull request provides ability to easily add configuration files to the oauth2-proxy binary. This was something that was needed because out of the box the oauth2-proxy chart only can do standard authentication against the email domain. However, if one wants to do more advanced group based authentication. This requires a service account. (hence the service account json file option in oauth2-proxy binary) This information can only be provided as a path to the json file.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
This was so that its easy to provide configuration files into the pods.
Special notes for your reviewer:
I can't think of anything.

Reviewing the contributors license agreement.

Thanks @carrodher will get this in.

cc @compleatang

/assign

Closing, will reopen shortly.


Atlassian Data Center 8.0 support

Would you please inform us if you have plans to port the following add-on to Atlassian Data Center 8.0 by or before May 2022?

Is there any intention to certify the add-on for data center? ITs been a while since this question was opened


feat(cli): Add a --with-model arg to generate an example schema

Hello! This is my first time contributing to an open source project that big!
This add a new --with-model params you can give to the CLI to generate a new project with a predefined schema containing a User model.
It should closes #20915.
Tried my best, feel free to tell me if something seems wrong!

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

This is now available in our dev version 5.14.0-dev.21 and will be part of the next official version 5.14.0 scheduled for May, 14th.


[NFR]/Bug Better CFG analyze for Ternary operator

Hey!
https://flow.org/try/#0PQKgBAAgZgNg9gdzCYAoVBLAtgBzgJwBcwAlAUwEMBjYqfOLMAcn0pqYG51CBPHMsABUAFqwoATAKIA7Qhl5gAvGADeqMGFQBfbnwEBlQhUIDlajYVGVxALiFWJMubwA+0gK4wY29FHfSaDDhpMDh+aQBhCi8AdQxpcUQACTgAZ0IACksxW3scp3keAEo7dPx4gHNVdTBWQnd8EIAicTIoCk9iMsqmrh1UKmD0sHTjMjtDMaVVMGzrOw8vMC0uAaHiACNCEOUMmoAeDfdCQmCajWCImAwqAGtFFVGTADo5iTAAfjAMoqUAPlC4SisXiiQQKXSGSeZFeDnEvwWnhgOg0f3OgLI0gOwCOJ2CaKKqCAA
/* @flow */

import React from 'react';

type ThreadEntity = {

}

type State = {
  thread: ThreadEntity|null
}

function openCallWindowHost(thread: ThreadEntity): string {
  return "default string";
}

const state: State = { thread: null };

const letsRenderLol = (
  <button
    onClick={state.thread ? () => openCallWindowHost(state.thread) : null}
  >
    open
  </button>
)

Ternary operator mutate possible values of State type
from ThreadEntity|null to ThreadEntity for positive case and null for negative
Thank

More cases

Hi there! Can yuk please explain what you expect in the code above and what happens? I can read the code, but I’m not sure what about it you think is happening incorrectly.

If the issue is about null being an option on this value even after you checked it with an if, then I think the answer to your quandary will be in the Refinement invalidation section here: https://flow.org/en/docs/lang/refinements/

Yeah, to resolve your issue your onClick should look like this:
onClick={() => state.thread ? openCallWindowHost(state.thread) : null}

The ternary has to be inside the arrow function otherwise the arrow function itself invalidates your refinement. Alternatively you can make a const that references state.thread and pass it to your function:
const thread = state.thread
const onClick = thread ? () => openCallWindowHost(thread) : null
const letsRenderLol = (
  <button onClick={onClick}>open</button>
)

@vkurchatkin why this closed?

thank @jcready

The ternary has to be inside the arrow function otherwise the arrow function itself invalidates your refinement

you are right, but why it's not possible for Flow to support this case? (invalidates refinement when it's really needed, because in my example it's pretty simple anonymous function)

@ovr see @jcready's answer


i ran run create_project.bat and selected the mode,but nothing happened?   where is  the generated project files ? thanks

i ran  create_project.bat and selected the mode,but nothing happened?   where is  the generated project files ? thanks

A udStream.sln should appear beside the create_project.bat, if it didn't, it's possible you haven't got all of the dependencies - try running git submodule update --init --recursive and then run create_project.bat again.

i tried running git submodule update --init --recursive, it download some dependencies.but i run create_project.bat again,still nothing genenated.

Can you run create_project.bat from the command line, does it output any errors?

Error: G:/vaultclient/premake5.lua:60: udSDK not installed correctly. (No UDSDK_HOME environment variable or --udSDK=[PATH] argument!)

I see, you'll need to get a copy of our udSDK and set the environment variable mentioned to that location.

problem solved .thanks


ReplacePathRegex seems not to work in v2.0.0-alpha2

Do you want to request a feature or report a bug?
Bug
What did you do?

switched from traefik 1.7.9 to traefik v2.0.0-alpha2 without changing the configuration
test system is self-build alpine docker image running prometheus

What did you expect to see?
~ $ curl localhost:40700
Found.

What did you see instead?
~ $ curl localhost:40700
404 page not found

Output of traefik version: (What version of Traefik are you using?)
~ $ traefik version
Version:      2.0.0-alpha2
Codename:     faisselle
Go version:   go1.12.1
Built:        2019-03-19T18:44:59Z
OS/Arch:      linux/amd64

What is your environment & configuration (arguments, toml, provider, platform, ...)?
Platform: alpine 3.9

defaultEntryPoints = ["http"]

[entryPoints]
    [entryPoints.http]
    address = ":40700"
    compress = true

  [backends]

    [backends.backend1]
      [backends.backend1.servers.1]
      url = "http://<IP_ADDRESS>:9090"
      weight = 1

  [frontends]

    [frontends.frontend1]
      entryPoints = ["http"]
      backend = "backend1"

    [frontends.frontend1.routes]
      [frontends.frontend1.routes.route0]
        rule = "ReplacePathRegex:^/(.*) /$1"

If applicable, please paste the log output in DEBUG level (--logLevel=DEBUG switch)
~ $ traefik --configFile=/etc/traefik/traefik.toml &
~ $ ERRO[2019-03-21T16:06:25Z]
You haven't specify the sendAnonymousUsage option, it will be enable by default.
ERRO[2019-03-21T16:06:33Z] Error while Peeking first byte: EOF
ps aux
PID   USER     TIME  COMMAND
    1 nobody    0:00 /sbin/tini -- /usr/local/bin/start_processes.sh
    9 nobody    0:00 {start_processes} /bin/sh /usr/local/bin/start_processes.s
   14 nobody    0:04 /opt/prometheus/prometheus --config.file=/etc/prometheus/p
   54 nobody    0:00 /bin/sh
  126 nobody    0:00 sleep 60
  147 nobody    0:01 traefik --configFile=/etc/traefik/traefik.toml
  165 nobody    0:00 ps aux
~ $ curl localhost:ERRO[2019-03-21T16:06:43Z] Error while Peeking first byte: EOF
~ $ curl localhost:40700
404 page not found
~ $ ERRO[2019-03-21T16:06:53Z] Error while Peeking first byte: EOF

Hello, the v1 configuration is not compatible with Traefik v2.
You can find the new configuration inside our documentation https://docs.traefik.io/v2.0
Thank you for your interest, do not hesitate to come on Slack to tell us about the v2.

I probably should have checked the docs first. Only came across the release page in Github and thought, since the release notes do not mention anything i should be good to go.
Thank you for the answer.


Feature Addition: API for traversing DSOM and generating NIFI RecordSchemas from DSOM

In this fork, no code was modified other than 2 added dependencies, and several classes to define an API and test them were added.  These were all in the org.apache.daffodil.dsom package.  Here is a summary of the additions:

An abstract class called AbstractDSOMWalker that traverses DSOM objects. As the DSOM is traversed, various event handlers that are declared abstract in the API are invoked, depending on the DSOM element encountered (Sequence, Element, Choice, etc.).
A concrete implementation of AbstractDSOMWalker called RecordWalker that generates a NIFI RecordSchema as a result of the DSOM traversal.
A helper class called SchemaNode for storing the relevant information about an element in the DSOM.  These are used in the intermediate stages of processing in RecordWalker.
3 Test classes and 3 complete DFDL Schema files for testing the output of RecordWalker.  These use the Scalatest Unit Test framework.

As a result of the above features, 2 new dependencies were also added for Core in project/Dependencies: one for NIFI Records, and another for ScalaTest

@andrewjc2000, with two +1's this is ready to merge. Can you please squash all of your changes into a single commit, update the commit message based on the squashed state of the code, and add the bug number to the end of the commit message? Then this will be good to merge. Thanks for the contribution!


Whitespaces around arguments of functions generated by connecting signals via GUI are inconsistent with the style guide

When a signal is conneced via GUI, a bit of code is automatically inserted into the script of the target node. For example:
func _on_VSlider_value_changed( value ):
    pass # replace with function body

Notice how there are whitespaces around value. This is inconsistent with the automatically generated _process(delta), which doesn't have any whitespaces.
Godot's style guide does mention briefly the use of whitespaces, and style guide is inspired by Python's PEP 8 Style guide, of which does recommend to avoid such spaces.

Fixed by #16934.


Unexpected error when I try to view our open collective page

Describe the bug

I got an unexpected error on https://opencollective.com/do_action-ijebu while I was trying to view our collective page here - https://opencollective.com/do_action-ijebu
To Reproduce

Go to https://opencollective.com/do_action-ijebu
See error

Device

OS: MacIntel
Browser: 5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/76.0.3809.132 Safari/537.36

Technical details

@MaryOJob the origin of the problem was that an update was created with an account you have now deleted. I attached your new account to the update. It should work now.

Thanks @znarf for the assist. I appreciate.


Mercurial prerequisite missing - release 0.9

Hello guys,
I have tried to use release 0.9 and preparation of project ended on:
go<EMAIL_ADDRESS>hg clone -U https://bitbucket.org/ww/goautoneg . in /home/majera/go/pkg/mod/cache/vcs/59c2185b80ea440a7c3b8c5eff3d8abb68c53dea1f20f615370c924c4150b27f: exec: "hg": executable file not found in $PATH
It works fine after Mercurial installation. It would be good if mercurial is mentioned in prerequisites.

@JaroslavMajera Did you add an extra dependency to your operator, becausebitbucket.org/ww/goautoneg is not in the default deps for me. Also, I do not have hg command installed and the default operator compiles for me.

@LiliC I didn't add an extra dependency. I was creating the example operator from docs.

@JaroslavMajera Can you please write down all the steps you took, preferably fill out the below, as I can't reproduce this, thanks!
**What did you do?**
A clear and concise description of the steps you took (or insert a code snippet).

**What did you expect to see?**
A clear and concise description of what you expected to happen (or insert a code snippet).

**What did you see instead? Under which circumstances?**
A clear and concise description of what you expected to happen (or insert a code snippet).

**Environment**
* operator-sdk version:

<!--- Insert operator-sdk release or Git SHA here. -->

* go version:

<!--- Insert the output of `go version` here -->

* Kubernetes version information:

<!--- Insert the output of `kubectl version` here -->

* Kubernetes cluster kind:

* Are you writing your operator in ansible, helm, or go?

**Possible Solution**
<!--- Only if you have suggestions on a fix for the bug -->

**Additional context**
Add any other context about the problem here.

I do not run into this:
operator-sdk version
operator-sdk version: v0.9.0, commit: 560208dc998de497bbf59fea1b63426aec430934

➜  operator-framework operator-sdk new memcached-operator
INFO[0000] Creating new Go operator 'memcached-operator'.
INFO[0000] Created go.mod
INFO[0000] Created tools.go
INFO[0000] Created cmd/manager/main.go
INFO[0000] Created build/Dockerfile
INFO[0000] Created build/bin/entrypoint
INFO[0000] Created build/bin/user_setup
INFO[0000] Created deploy/service_account.yaml
INFO[0000] Created deploy/role.yaml
INFO[0000] Created deploy/role_binding.yaml
INFO[0000] Created deploy/operator.yaml
INFO[0000] Created pkg/apis/apis.go
INFO[0000] Created pkg/controller/controller.go
INFO[0000] Created version/version.go
INFO[0000] Created .gitignore
INFO[0000] Validating project
go: finding github.com/operator-framework/operator-sdk master
INFO[0010] Project validation successful.
INFO[0010] Project creation complete.

And:
➜  memcached-operator hg
zsh: command not found: hg

Can you paste the output of the go.mod and go.sum thanks!

Output of new command:
INFO[0000] Creating new Go operator 'memcached-operator'.
INFO[0000] Created go.mod
INFO[0000] Created tools.go
INFO[0000] Created cmd/manager/main.go
INFO[0000] Created build/Dockerfile
INFO[0000] Created build/bin/entrypoint
INFO[0000] Created build/bin/user_setup
INFO[0000] Created deploy/service_account.yaml
INFO[0000] Created deploy/role.yaml
INFO[0000] Created deploy/role_binding.yaml
INFO[0000] Created deploy/operator.yaml
INFO[0000] Created pkg/apis/apis.go
INFO[0000] Created pkg/controller/controller.go
INFO[0000] Created version/version.go
INFO[0000] Created .gitignore
INFO[0000] Validating project
go: finding github.com/operator-framework/operator-sdk master
go: finding github.com/emicklei/go-restful v2.8.1+incompatible
go: finding github.com/go-openapi/spec v0.18.0
go: finding github.com/googleapis/gnostic v0.2.0
...
go: finding github.com/gogo/protobuf v1.2.0
go<EMAIL_ADDRESS>hg clone -U https://bitbucket.org/ww/goautoneg . in /home/majera/go/pkg/mod/cache/vcs/59c2185b80ea440a7c3b8c5eff3d8abb68c53dea1f20f615370c924c4150b27f: exec: "hg": executable file not found in $PATH
go: finding github.com/go-openapi/runtime v0.0.0-20180920151709-4f900dc2ade9
go: finding github.com/go-openapi/analysis v0.0.0-20180825180245-b006789cd277
go: finding github.com/docker/distribution v2.6.2+incompatible
go: finding github.com/prometheus/procfs v0.0.0-20181204211112-1dc9a6cbc91a
go: finding golang.org/x/sys v0.0.0-20181116152217-5ac8a444bdc5
go: error loading module requirements
Error: failed to exec []string{"go", "build", "./..."}: exit status 1
go.mod:
`module memcached-operator
require (
github.com/NYTimes/gziphandler v1.0.1 // indirect
github.com/operator-framework/operator-sdk v0.0.0-20190715204459-936584d47ff9
github.com/spf13/pflag v1.0.3
k8s.io/api v0.0.0-20190612125737-db0771252981
k8s.io/apimachinery v0.0.0-20190612125636-6a5db36e93ad
k8s.io/client-go v11.0.0+incompatible
k8s.io/kube-openapi v0.0.0-20190603182131-db7b694dc208 // indirect
sigs.k8s.io/controller-runtime v0.1.12
sigs.k8s.io/controller-tools v0.1.10
)
// Pinned to kubernetes-1.13.4
replace (
k8s.io/api => k8s.io/api v0.0.0-20190222213804-5cb15d344471
k8s.io/apiextensions-apiserver => k8s.io/apiextensions-apiserver v0.0.0-20190228180357-d002e88f6236
k8s.io/apimachinery => k8s.io/apimachinery v0.0.0-20190221213512-86fb29eff628
k8s.io/client-go => k8s.io/client-go v0.0.0-20190228174230-b40b2a5939e4
)
replace (
github.com/coreos/prometheus-operator => github.com/coreos/prometheus-operator v0.29.0
k8s.io/kube-state-metrics => k8s.io/kube-state-metrics v1.6.0
sigs.k8s.io/controller-runtime => sigs.k8s.io/controller-runtime v0.1.12
sigs.k8s.io/controller-tools => sigs.k8s.io/controller-tools v0.1.11-0.20190411181648-9d55346c2bde
)
replace github.com/operator-framework/operator-sdk => github.com/operator-framework/operator-sdk v0.9.0
`
go.sum:
go.sum.log

hmm maybe this was due to me already having this dependency locally.
cc @estroz any ideas ^

@LiliC @JaroslavMajera you can reproduce this error by running the following:
# dnf remove mercurial -y
$ go clean -modcache
$ operator-sdk new test-project
INFO[0000] Creating new Go operator 'hg-operator'.
INFO[0000] Created go.mod
INFO[0000] Created tools.go
INFO[0000] Created cmd/manager/main.go
INFO[0000] Created build/Dockerfile
INFO[0000] Created build/bin/entrypoint
INFO[0000] Created build/bin/user_setup
INFO[0000] Created deploy/service_account.yaml
INFO[0000] Created deploy/role.yaml
INFO[0000] Created deploy/role_binding.yaml
INFO[0000] Created deploy/operator.yaml
INFO[0000] Created pkg/apis/apis.go
INFO[0000] Created pkg/controller/controller.go
INFO[0000] Created version/version.go
INFO[0000] Created .gitignore
INFO[0000] Validating project
go: finding github.com/operator-framework/operator-sdk master
go: finding github.com/operator-framework/operator-sdk v0.9.0
...
go<EMAIL_ADDRESS>hg clone -U https://bitbucket.org/ww/goautoneg . in /home/estroz/go/pkg/mod/cache/vcs/59c2185b80ea440a7c3b8c5eff3d8abb68c53dea1f20f615370c924c4150b27f: exec: "hg": executable file not found in $PATH

I will update the release notes and guides with the mercurial dependency required for v0.9.0.

Thanks for reporting this @JaroslavMajera!


Support Paging

laik commented on Feb 25, 2016
As a user I would like to listen on a key and receive only a subset of values at a time.
Sorting needs to be determined.

Introduce LVTS: LVTS guarantees everything later than itself up to RVTS has been synced.
LVTS and RVTS starts out the same, then as more historical data is needed, we make an advance call asking for n number of items before LVTS. LVTS is moved to the lowest VTS of the items returned.
Client SDKs are in charge of keeping track of LVTS/RVTS, and passing along the request for historical items.

Due the scope of the implementation we have decided on, this will not be finished during this sprint


How to stream error ?

Hi,
We have a use case when we want to send an error on a highland stream, and catch it on the side in the err parameter, using a copied StreamError works correctly, otherwise it doesn't. For example:
function StreamError(err) {
    this.__HighlandStreamError__ = true;
    this.error = err;
}

var stream = getStreamSomeWhere();

stream.end(new StreamError('something went wrong');
stream.pull(function(err, data) {
// err = 'something went wrong', like expected
});

Is there other why to achieve the same result without using a fake StreamError ?

Why are you using write anyway? If you have a node stream, then emit an error event and use the node stream constructor. If you don't then use the push from the generator constructor.

Also, your code sample doesn't make sense. Highland#end doesn't take an argument. If stream isn't a highland stream, why does pull exist?

You are right, I didn't wrote the full details, stream is a TCP socket.
The first message I am sending on the stream is something like(side A):
{service: 'db', cmd: 'get-big-data'}

On the receiving side(side B), I need to check if a command called 'get-bid-data' exist, if not - send back an error, here comes the tricky part, I want the error to be in the err parameter of pull (or consume for that matter) of side A.
Am I doing something completely off ?

From your comments in #200, I think you can use map and throw the error without having to implement a whole consume.
Something like this?
_(requests).map(function (req) {
    if (commandExists(req.db, req.cmd)) {
        // do command.
        return result;
    }
    else {
        throw new Error("Command " + req.cmd + " does not exist.");
    }
}).errors(function (err) {
    // send error through the wire.
}).each(function (res) {
    // send result through the wire
});

Yeah it works, I am catching errors on highland stream, and send a special packet over the wire.


added investigation report to solve issue 1

Resolves #1
This PR addresses the investigation into creating a service to synchronize the World ID merkle tree, a task previously handled exclusively by the signup-sequencer. The investigation report included in this PR outlines:
-[x] The current process of merkle tree synchronization by the signup-sequencer
-[x] Potential approaches for creating a separate service for this task
-[x] Advantages and challenges of implementing a new synchronization service
-[x] Recommendations for next steps in development
This investigation provides a foundation for future implementation work to improve the scalability and efficiency of the World ID merkle tree synchronization process.

@Ugo-X Great work, thank you!

@Ugo-X I have created a follow-up issue, let me know if you want to work on it:
https://github.com/dragan2234/worldcoin-scroll-bridge/issues/9


Rename the master branch to main

This PR is against a branch called main
Internally all docs/CI/etc is updated
The default branch of the repo is now main
All active PRs have been updated to retarget main

Closes #1914

I'm gonna go ahead and merge so others can rebase, I'll fix up anything if it's broken on CI


TypeError: Cannot read properties of undefined (reading 'config') when turning on experimental.asyncContext option

It works fine in development mode, but when deployed in all three cf vercel-edge nodejs targets it causes problems, and I finally managed to locate the error in the local nodejs target.

!globalThis.app.config.server.experimental?.asyncContext) throw new Error("AsyncLocalStorage was not enabled. Use the `server.experimental.asyncContext: true` option in your app configuration to enable it. Or, pass the instance of HTTPEvent that you have as the first argument to the function."

Among other things, the runtimeConfig, dev other options in solid-start do not generate accessible properties at runtime after configuration.

rel #233

Can you make a github repo that reproduces this. I can try deploying it to vercel-edge

Sorry @nksaraf , I took the time to look into it, and there is a global scope reference to getEvent.  That was my mistake.


Label PVCs for consistency groups

Adding label "ramendr.openshift.io/consistency-group" to PVCs if consistency group is enable in DRPC.

/lgtm
I will add a for loop to add the cg label in cephfs PVCs in func labelPVCsForCG once this pr was merged


Icons are not rendering correctly

I was wondering do I need a specific font for the icons to be loaded.

As the name of the plugin implies, it requires termicons as listed in the requirements section of the readme.

Yes, I have installed the font and it works in my kitty terminal.
However instead of just linking the web url into requirements it would be better if it's included as a dedicated step for installation in the docs.
Also I have noticed something, in gnome-terminal when I tying to change the font termicons is not listed in the font list although it is listed in the system font selection. I wonder why.

@bdemon245 I'd rather not maintain the install instructions across two repos, thus the link to the source termicons repo.
I don't use linux, so sadly I'm not much help for you with gnome-terminal. If you figure it out, definitely let me know!


Xml Error on 'dnu restore'

Trying to run 'dnu restore' on this sample app (Ubuntu 15.04) gives me the following output:
GET https://api.nuget.org/v3-flatcontainer/system.collections/4.0.11-beta-23409/system.collections.4.0.11-beta-23409.nupkg
CACHE https://api.nuget.org/v3-flatcontainer/system.runtime.extensions/index.json
System.Xml.XmlException: Document element did not appear.  Line 1, position 1.
  at Mono.Xml2.XmlTextReader.Read () [0x00000] in <filename unknown>:0
  at System.Xml.XmlTextReader.Read () [0x00000] in <filename unknown>:0
  at Mono.Xml.XmlFilterReader.Read () [0x00000] in <filename unknown>:0
  at Mono.Xml.XmlFilterReader.Read () [0x00000] in <filename unknown>:0
  at System.Xml.Linq.XDocument.ReadContent (System.Xml.XmlReader reader, LoadOptions options) [0x00000] in <filename unknown>:0
  at System.Xml.Linq.XDocument.LoadCore (System.Xml.XmlReader reader, LoadOptions options) [0x00000] in <filename unknown>:0
  at System.Xml.Linq.XDocument.Load (System.Xml.XmlReader reader, LoadOptions options) [0x00000] in <filename unknown>:0
  at System.Xml.Linq.XDocument.Load (System.Xml.XmlReader reader) [0x00000] in <filename unknown>:0
  at NuGet.XmlUtility.LoadSafe (System.IO.Stream input, Boolean ignoreWhiteSpace) [0x00000] in <filename unknown>:0
  at NuGet.Manifest.ReadFrom (System.IO.Stream stream, IPropertyProvider propertyProvider, Boolean validateSchema) [0x00000] in <filename unknown>:0
  at NuGet.Manifest.ReadFrom (System.IO.Stream stream, Boolean validateSchema) [0x00000] in <filename unknown>:0
  at NuGet.LocalPackage.ReadManifest (System.IO.Stream manifestStream) [0x00000] in <filename unknown>:0
  at NuGet.UnzippedPackage.EnsureManifest () [0x00000] in <filename unknown>:0
  at NuGet.UnzippedPackage..ctor (IFileSystem fileSystem, System.String manifestPath) [0x00000] in <filename unknown>:0
  at NuGet.PackageInfo.get_Package () [0x00000] in <filename unknown>:0
  at Microsoft.Dnx.Runtime.NuGetDependencyResolver+<GetDependencies>d__4.MoveNext () [0x00000] in <filename unknown>:0
  at System.Collections.Generic.List`1[Microsoft.Dnx.Runtime.LibraryDependency].InsertRange (Int32 index, IEnumerable`1 collection) [0x00000] in <filename unknown>:0
  at System.Collections.Generic.List`1[Microsoft.Dnx.Runtime.LibraryDependency].AddRange (IEnumerable`1 collection) [0x00000] in <filename unknown>:0
  at Microsoft.Dnx.Tooling.RestoreOperations+<CreateGraphNode>d__2.MoveNext () [0x00000] in <filename unknown>:0
--- End of stack trace from previous location where exception was thrown ---
  at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x00000] in <filename unknown>:0
  at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Threading.Tasks.Task task) [0x00000] in <filename unknown>:0
  at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Threading.Tasks.Task task) [0x00000] in <filename unknown>:0
  at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd (System.Threading.Tasks.Task task) [0x00000] in <filename unknown>:0
  at System.Runtime.CompilerServices.TaskAwaiter`1[Microsoft.Dnx.Tooling.GraphNode].GetResult () [0x00000] in <filename unknown>:0
  at Microsoft.Dnx.Tooling.RestoreOperations+<CreateGraphNode>d__2.MoveNext () [0x00000] in <filename unknown>:0
--- End of stack trace from previous location where exception was thrown ---
  at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x00000] in <filename unknown>:0
  at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Threading.Tasks.Task task) [0x00000] in <filename unknown>:0
  at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Threading.Tasks.Task task) [0x00000] in <filename unknown>:0
  at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd (System.Threading.Tasks.Task task) [0x00000] in <filename unknown>:0
  at System.Runtime.CompilerServices.TaskAwaiter`1[Microsoft.Dnx.Tooling.GraphNode].GetResult () [0x00000] in <filename unknown>:0
  at Microsoft.Dnx.Tooling.RestoreOperations+<CreateGraphNode>d__2.MoveNext () [0x00000] in <filename unknown>:0
--- End of stack trace from previous location where exception was thrown ---
  at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x00000] in <filename unknown>:0
  at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Threading.Tasks.Task task) [0x00000] in <filename unknown>:0
  at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Threading.Tasks.Task task) [0x00000] in <filename unknown>:0
  at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd (System.Threading.Tasks.Task task) [0x00000] in <filename unknown>:0
  at System.Runtime.CompilerServices.TaskAwaiter`1[Microsoft.Dnx.Tooling.GraphNode].GetResult () [0x00000] in <filename unknown>:0
  at Microsoft.Dnx.Tooling.RestoreOperations+<CreateGraphNode>d__2.MoveNext () [0x00000] in <filename unknown>:0
--- End of stack trace from previous location where exception was thrown ---
  at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x00000] in <filename unknown>:0
  at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Threading.Tasks.Task task) [0x00000] in <filename unknown>:0
  at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Threading.Tasks.Task task) [0x00000] in <filename unknown>:0
  at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd (System.Threading.Tasks.Task task) [0x00000] in <filename unknown>:0
  at System.Runtime.CompilerServices.TaskAwaiter`1[Microsoft.Dnx.Tooling.GraphNode].GetResult () [0x00000] in <filename unknown>:0
  at Microsoft.Dnx.Tooling.RestoreCommand+<CreateGraphNode>d__71.MoveNext () [0x00000] in <filename unknown>:0
--- End of stack trace from previous location where exception was thrown ---
  at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x00000] in <filename unknown>:0
  at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Threading.Tasks.Task task) [0x00000] in <filename unknown>:0
  at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Threading.Tasks.Task task) [0x00000] in <filename unknown>:0
  at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd (System.Threading.Tasks.Task task) [0x00000] in <filename unknown>:0
  at System.Runtime.CompilerServices.TaskAwaiter`1[Microsoft.Dnx.Tooling.RestoreCommand+TargetContext[]].GetResult () [0x00000] in <filename unknown>:0
  at Microsoft.Dnx.Tooling.RestoreCommand+<RestoreForProject>d__69.MoveNext () [0x00000] in <filename unknown>:0
--- End of stack trace from previous location where exception was thrown ---
  at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x00000] in <filename unknown>:0
  at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Threading.Tasks.Task task) [0x00000] in <filename unknown>:0
  at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Threading.Tasks.Task task) [0x00000] in <filename unknown>:0
  at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd (System.Threading.Tasks.Task task) [0x00000] in <filename unknown>:0
  at System.Runtime.CompilerServices.TaskAwaiter`1[System.Boolean].GetResult () [0x00000] in <filename unknown>:0
  at Microsoft.Dnx.Tooling.RestoreCommand+<>c__DisplayClass68_0+<<Execute>b__2>d.MoveNext () [0x00000] in <filename unknown>:0
--- End of stack trace from previous location where exception was thrown ---
  at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x00000] in <filename unknown>:0
  at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Threading.Tasks.Task task) [0x00000] in <filename unknown>:0
  at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Threading.Tasks.Task task) [0x00000] in <filename unknown>:0
  at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd (System.Threading.Tasks.Task task) [0x00000] in <filename unknown>:0
  at System.Runtime.CompilerServices.TaskAwaiter.GetResult () [0x00000] in <filename unknown>:0
  at Microsoft.Dnx.Tooling.RestoreCommand+<Execute>d__68.MoveNext () [0x00000] in <filename unknown>:0
----------

I am having the same issue. Any luck on working around it or sourcing a fix?

@juvaly as per #1055, I've found that deleting the contents of %userprofile%.dnx\packages worked for me.

This issue is being closed because it has not been updated in 3 months.
We apologize if this causes any inconvenience. We ask that if you are still encountering this issue, please log a new issue with updated information and we will investigate.


⚠ Minecraft has degraded performance

In 8b32aea, Minecraft (https://www.minecraft.net) experienced degraded performance:

HTTP code: 200
Response time: 1099 ms

Resolved: Minecraft performance has improved in 9db5e01.


Makefile failed during lane evaluation

The error message is as above and i have already installed opencv successfully.

did you fix this? I found uncommenting opencv_imgcodecs in the Makefile:
LIBRARIES += opencv_core opencv_highgui opencv_imgproc opencv_imgcodecs
fixed this issue


SRA download as fastq.gz

Hello
Would it be possible that the downloading process generate fastq.gz files instead of fastq ?
I know that there is an option that can delete later those files but in the mean time it can take a lot of space...
Also, as it is my first run of Finder for my project, I prefer to keep intermediate files until it will be completed.
But for my project I have 165 SRA libraries... So I have ended up with 990 Go of fastq files.

Hello @blavetn,
Thank you for your interest in finder. That's a good suggestion. I will implement it and let you know once it's done.
Thank you.


OpenSSL violates RFC 5246, section 7.4.4 certificate_authorities size

We have stumbled upon this rather obscure issue when we investigated a mutual auth issue in company-internal CAs:
At our company a global CA certstore is maintained, for Java's JSSE (cacerts) as well as Schannel.  This truststore public CAs maintained by Microsoft/Oracle as well as our company's ones. The files (JKS, PEM) are about one megabyte large.
We tried to perform mutual auth from Java side (1.8.0_172) on the server and failed with:
main, handling exception: java.lang.RuntimeException: Field length overflow, the field length (72207) should be less than 65536
%% Invalidated:  [Session-1, TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256]
main, SEND TLSv1.2 ALERT:  fatal, description = internal_error
main, WRITE: TLSv1.2 Alert, length = 2
main, called closeSocket()
main, IOException in getSession():  javax.net.ssl.SSLException: java.lang.RuntimeException: Field length overflow, the field length (72207) should be less than 65536

After a bit of investigation we came to the conclusion that
  struct {
      ClientCertificateType certificate_types<1..2^8-1>;
      SignatureAndHashAlgorithm
        supported_signature_algorithms<2^16-1>;
      DistinguishedName certificate_authorities<0..2^16-1>;
  } CertificateRequest;

is violated in terms of DN size and Java terminated the handshake. So we wanted to try with OpenSSL via mod_ssl on Apache Web Server: Apache/2.4.33 (FreeBSD) OpenSSL/1.0.2o. Both have been installed from ports.
Converted the JKS file in question to PEM format:
$ grep -c "BEGIN CERTIFICATE" cert.pem
669

and hooked that into HTTPd:
SSLCACertificateFile /tmp/cert.pem
SSLVerifyClient require
SSLVerifyDepth 5

We then tried OpenSSL from command line with:
echo -ne 'GET /~osipovmi/tls-auth/phpinfo.php HTTP/1.1\r\nHost: hostname\r\n\r\n'  | openssl s_client -connect hostname:443 -CAfile /etc/ssl/cert.pem -ign_eof -prexit -msg

in midair we see:
<<< TLS 1.2 Handshake [length 10fcf], CertificateRequest
    0d 01 0f cb 03 01 02 40 00 1e 06 01 06 02 06 03
    05 01 05 02 05 03 04 01 04 02 04 03 03 01 03 02
    03 03 02 01 02 02 02 03 0f a5 00 13 30 11 31 0f
    30 0d 06 03 55 04 03 13 06 44 2d 52 20 43 41 00
    1b 30 19 31 17 30 15 06 03 55 04 03 13 0e 41 42
    ...
    20 4c 31 42 00 79 30 77 31 0b 30 09 06 03 55 04
    06 13 02 44 45 31 0f 30 0d 06 03 55 04 08 0c 06
    42 61 79 65 72 6e 31 11 30 0f 06 03 55 04 07 0c
    08 4d 75 65 6e 63 68 65 6e 31 10 30 0e 06 03 55
    04 0a 0c 07 53 69 65 6d 65 6e 73 31 11 30 0f 06
    03 55 04 05 13 08 5a 30 30 33 52 48 35 53 31 1f
    30 1d 06 03 55 04 03 0c 16 4d 6f 62 69 6c 69 74
    79 20 53 54 43 20 50 50 4b 49 20 4c 69 76 65
>>> ??? [length 0005]
    15 03 03 00 1a
>>> TLS 1.2 Alert [length 0002], fatal decode_error
    02 32

0x10fcf = 69 583. This is more that the allowed 2^16-1. I can see huge encrypted handshake messages in Wireshark. Using Firefox (ESR 52.8.0 on Windows 7) as a TLS client gives me:
SSL hat eine nicht wohlgeformte Handshake-Nachricht "Zertifikat-Anfrage" empfangen. Fehlercode: SSL_ERROR_RX_MALFORMED_CERT_REQUEST

So Firefox does check on the max length as does OpenSSL with s_client.
I consider this as a bug in the server-side of OpenSSL not checking the size of the encoded DN buffer going out to the client. Can you confirm? Do you need more data from me? I can send pcaps or full logs privately.

@bagder have you stumbled upon this in a similar fashion? This can be, of course, reproduced with curl:
<= Recv SSL data, 5 bytes (0x5)
0000: .....
== Info: TLSv1.2 (IN), TLS handshake, Request CERT (13):
<= Recv SSL data, 69583 bytes (0x10fcf)
0000<EMAIL_ADDRESS>CA.
0040: .0.1.0...U....ABLE Root CA 1..0.1.0...U....SI1.0...U....ACNLB.'0
...
10e80: G0E..U...>CPS CONTAINS IMPORTANT LIMITATIONS OF WARRANTIES AND L
10ec0: IABILITY1907..U...0www.entrust.net/CPS is incorporated by refere
10f00: nce1.0...U....(c) 2008 Entrust, Inc.1.0,..U...%Entrust Certifica
10f40: tion Authority - L1B.y0w1.0...U....DE1.0...U....Bayern1.0...U...
10f80: .Muenchen1.0...U....Siemens1.0...U....Z003RH5S1.0...U....Mobilit
10fc0: y STC PPKI Live
=> Send SSL data, 5 bytes (0x5)
0000: .....
== Info: TLSv1.2 (OUT), TLS alert, Server hello (2):
=> Send SSL data, 2 bytes (0x2)
0000: .2
== Info: OpenSSL SSL_read: error:1408709F:SSL routines:ssl3_get_certificate_request:length mismatch, errno 0
== Info: Closing connection 0
curl: (56) OpenSSL SSL_read: error:1408709F:SSL routines:ssl3_get_certificate_request:length mismatch, errno 0

OpenSSL is liberal in what it accepts.  It is hard to see that this is a bug, but more like a configuration error.

So you are telling that is intentionally does not adhere to the RFC with the upper limit of certificate_authorities<0..2^16-1> although other clients will reject it?
This isn't about accepting, this is return/write from OpenSSL server code.

The length listed in the original report, 0x10fcf, is not the length of the certificate_authorities list. It's the length of the overall message. That one is not bounded by 2^16-1. Rather, the certificate_authorities list is. There, it is not syntactically possible to express a certificate_authorities list larger than 2^16-1. That syntax in TLS also specifies the number of bytes in the byte length, so certificate_authorities has a two byte length. You need to reconsider your design if you're trying to send 1MB of certificate names.
Finally, however, I think this is solidly an OpenSSL bug. OpenSSL's encoder is trying to encode a large length into two bytes that doesn't fit and, rather than noticing the error, it just truncates the length to fit. (Here it's reporting a length of 0x0fa5.) The receiver is then rightfully complaining it is not a valid CertificateRequest. This comes from everything being serialized with pointer arithmetic and macros like s2n and l2n3. This has been fixed on the master branch, but it looks like both 1.0.2 and 1.1.0 still use the macros.
In the likely case, it produces something unparseable. If adversarially misconfigured, one can imagine worse consequences on other messages (here, the problematic field is last, so it's fine) under a threat model that allows some attacker-supplied configuration. In so far as one can frame this as OpenSSL being "liberal in what it accepts", this is another demonstration of how problematic the idea can be. Postel's Law has no place in a security library.

I agree, I misunderstood the original report.

ping @mattcaswell (who's away for a couple of days)

@davidben

The length listed in the original report, 0x10fcf, is not the length of the certificate_authorities list. It's the length of the overall message. That one is not bounded by 2^16-1. Rather, the certificate_authorities list is.

So how do I determine  the size of the certificate_authorities? I doubt that someone else in the message has a huge impact on the size.

You need to reconsider your design if you're trying to send 1MB of certificate names.

This is way out of my control. The company is too large (350 000 employees). Of course, I will raise this, but I don't want to maintain my own CA store and sync periodicly.

"liberal in what [configuration?] it accepts"

I am aware of this principal and expect OpenSSL to be conversative in what it sends.
@richsalz Thanks for reconsidering.
@markt-asf This might be interesting for you and tcnative.

This is way out of my control. The company is too large (350 000 employees). Of course, I will raise this, but I don't want to maintain my own CA store and sync periodicly.

Alas, this detail of the protocol is outside of everyone's control at this point.  Any OpenSSL fix here would amount to failing the connection on the server, rather than the client, so it still wouldn't work for you. (Silently truncating the CA list is, of course, not reasonable.) A fix would entail adding a new version or extension to TLS and then getting it into all clients and servers.
I've definitely seen servers that send humongous CertificateRequests, but they've always been mistakes. You are supposed to advertise the CAs that you'd accept certificates from. That means you don't want the global trust store for the Web PKI; those CAs presumably aren't issuing certificates for your employees. Indeed you wouldn't want to accept arbitrary ones for security reasons.
Rather, it's more likely that some internal CA at your company is issuing these, or perhaps you've partnered with some CA to manage this for you. You would then only need to include that root in CertificateRequest, not the entire trust store.

@davidben

Alas, this detail of the protocol is outside of everyone's control at this point.  Any OpenSSL fix here would amount to failing the connection on the server, rather than the client, so it still wouldn't work for you. (Silently truncating the CA list is, of course, not reasonable.) A fix would entail adding a new version or extension to TLS and then getting it into all clients and servers.

I don't expect anymore to derive from the RFC at all. In fact, I expect the opposite, OpenSSL to fail from the server if it sees that the DN list exceeds a two-byte length.

I've definitely seen servers that send humongous CertificateRequests, but they've always been mistakes. You are supposed to advertise the CAs that you'd accept certificates from. That means you don't want the global trust store for the Web PKI; those CAs presumably aren't issuing certificates for your employees. Indeed you wouldn't want to accept arbitrary ones for security reasons.
Rather, it's more likely that some internal CA at your company is issuing these, or perhaps you've partnered with some CA to manage this for you. You would then only need to include that root in CertificateRequest, not the entire trust store.

While I need to strip down the CA, granted, and raise it with our contractor, Atos, I still claim that OpenSSL operates outside of the spec.

I still claim that OpenSSL operates outside of the spec.

Agreed (for 1.1.0 and 1.0.2)
Fix in #6628 and #6629. It would be helpful if you could validate this patch.
The s2n and family macros are a nightmare, so I find it very unsurprising that we get it wrong here. The two patches in #6628 and #6629 just fix up the immediate issue. There is already a long term solution in 1.1.1 which is to use the WPACKET for constructing these packets instead - and this is the reason that 1.1.1 (aka master) is unaffected by this bug.

@mattcaswell Great, thanks for the patch. Will compile from master tomorrow and test with openssl s_server.

Patch was merged, so I'm closing this.


Nginx-Rtmp Will not relay or forward video streams....

What I am trying to accomplish is having nginx  relay/forward incoming rtmp to defined applications.
So I have an Ubuntu 16.04 server with the following:

nginx version: nginx/1.14.0
rtmp module
LXD v2.21 (2 containers of Ubuntu 16.04 and Media Server apps)

The nginx.conf file is:
#user  nobody;
worker_processes  2;
error_log  logs/error.log;
error_log  logs/error.log  notice;
error_log  logs/error.log  info;
error_log  logs/debug.log  debug;
#pid        logs/nginx.pid;
events {
worker_connections  1024;
}
rtmp {
server {
listen 1935;
ping 30s;
ping_timeout 10s;
chunk_size 4096;
    application LPC2 {
        live on;
        record off;
        push rtmp://<IP_ADDRESS>:1935;

    }
    application LPC1 {
        live on;
        record off;
        push rtmp://<IP_ADDRESS>:1935;

    }
    }
}

LPC1 and LPC2 = LXD containers with Media Server apps running.
Using OBS to generate valid streaming rtmp as such: rtmp://"nginx-rtmp server IP":1935/LPC1
the rtmp is routed to LPC1 and .ts video segments are generated by the Media Server.
Using OBS to generate valid streaming rtmp as such: rtmp://"nginx-rtmp server IP":1935/LPC2
the rtmp is routed to LPC1? I would think it should be routed to LPC2?
Shutting down LPC1 and using OBS to generate valid streaming rtmp as such: rtmp://"nginx-rtmp server IP":1935/LPC2 OBS responds with "Failed to connect to server".
Unless the nginx.conf is wrong, I think this might be a bug?
Or any suggestions to get this to work?
Thanks,
Ray

try using a different port for the LPC2 application


Installation Error

Following the install instruction and following error occurred. How can I resolve this?
Thank you
$ python setup.py build_ext --inplace
Traceback (most recent call last):
  File "/home/miniconda3/envs/biogpt/lib/python3.10/site-packages/torch/__init__.py", line 172, in _load_global_deps
    ctypes.CDLL(lib_path, mode=ctypes.RTLD_GLOBAL)
  File "/home/miniconda3/envs/biogpt/lib/python3.10/ctypes/__init__.py", line 374, in __init__
    self._handle = _dlopen(self._name, mode)
OSError: /home/miniconda3/envs/biogpt/lib/python3.10/site-packages/torch/lib/../../nvidia/cublas/lib/libcublas.so.11: symbol cublasLtGetStatusString, version libcublasLt.so.11 not defined in file libcublasLt.so.11 with link time reference

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/fairseq/setup.py", line 87, in <module>
    from torch.utils import cpp_extension
  File "/home/miniconda3/envs/biogpt/lib/python3.10/site-packages/torch/__init__.py", line 217, in <module>
    _load_global_deps()
  File "/home/miniconda3/envs/biogpt/lib/python3.10/site-packages/torch/__init__.py", line 178, in _load_global_deps
    _preload_cuda_deps()
  File "/home/miniconda3/envs/biogpt/lib/python3.10/site-packages/torch/__init__.py", line 158, in _preload_cuda_deps
    ctypes.CDLL(cublas_path)
  File "/home/miniconda3/envs/biogpt/lib/python3.10/ctypes/__init__.py", line 374, in __init__
    self._handle = _dlopen(self._name, mode)
OSError: /home/miniconda3/envs/biogpt/lib/python3.10/site-packages/nvidia/cublas/lib/libcublas.so.11: symbol cublasLtGetStatusString, version libcublasLt.so.11 not defined in file libcublasLt.so.11 with link time reference

I don't have the same problem, but the below looks to help you.
https://stackoverflow.com/questions/74394695/how-does-one-fix-when-torch-cant-find-cuda-error-version-libcublaslt-so-11-no


Fixed 'exec' definition in .d.ts.  I don't understand the comment in the...

... .d.ts about it not being implementable due to overloads.  It is modeled quite easily.

@nikeee could you review this PR?

So I missed that it returns ChildProcess in synchronous mode, but I'm missing your broader point.  It looks like exec() either returns ChildProcess in the overloads with a callback or ExecReturnValue, but none of the overloads return both, so a Union type is not necessary.
Also, it appears that your info may be old because TypeScript 1.4.1 is allowing me to have a different return type for each overload, and it is working perfectly in the tests file.  Perhaps part of the Union type work was to make varying overload return types be implicitly Union under the covers?  I'll push an update to this change replacing void with ChildProcess and adding another test.

either returns ChildProcess in the overloads with a callback or ExecReturnValue, but none of the overloads return both

Isn't this the whole point of the union feature?
From the  TS1.4 release post:

Union types are a powerful way to express a value that can be one of several types. For example, you might have an API for executing a program that takes a command-line as either a string or a string[].

If the constant value overloads support different return types, then this is the way it should be implemented.

Sounds good let me know if the latest version of the code looks good to you.  And thanks for catching that void return type error.

PR updated.  Let me know if you think this looks done, @nikeee, and thanks for helping me fix those issues.

This looks nice to me. Thanks for improving the definition!

@vvakame you can accept this pull request now, as nikeee has signed off.
Thanks!

@nikeee thanks!
@altano thanks mate!


feat: add extension registry

Adds /registry.json, which dfx extension install will use to locate extension.json.
Part of https://dfinity.atlassian.net/browse/SDK-1796

The term registry in the context of ICP is associated with the Registry canister (and things around that).
This feature seems to be unrelated to the Registry canister, so I think the naming might be confusing.
Any chance we could re-negotiate the name?

This feature seems to be unrelated to the Registry canister, so I think the naming might be confusing.
Any chance we could re-negotiate the name?

Hi @aterga.
IMO, "registry" is the most accurate term for its purpose. Could you come up with any alternatives?

This repo (dfx-extensions) is sort of a backend service to support the CLI tool dfx extension install.
Only very few people (SDK team, developers who build dfx extensions) in the community should be aware of this repo.
The majority of ICP community recognize "registry" as the Registry canister while a small group knows this "registry.json" file. So I don't think the potential "confusion" is a big issue. If it is desired, we can add some explanation in the README of this repo.
P.S. Currently, this repo serves as the home of the nns and sns extensions. As we are expecting more extensions from the community, we plan to make this repo a central registry of dfx extensions. Once it is in place (this PR merged) , the nns and sns extensions can be moved to their own repos. Then we can decouple the "dfx extension framework" and the individual extensions. NNS team won't have to keep an eye on this repo.

This feature seems to be unrelated to the Registry canister, so I think the naming might be confusing.
Any chance we could re-negotiate the name?

IMO, "registry" is the most accurate term for its purpose. Could you come up with any alternatives?

How about "catalog"? (I'd be fine with any other synonym that doesn't collide with existing IC concepts).

This repo (dfx-extensions) is sort of a backend service to support the CLI tool dfx extension install. Only very few people (SDK team, developers who build dfx extensions) in the community should be aware of this repo.

One could argue that this si a public repo and thus we don't know if many people will stumble upon this while googling, e.g., "dfx registry" (while trying to find, e.g., how to install or interact with the Registry canister using DFX).
To be clear, what you're doing in the PR makes sense to me, it's just the naming that I think is suboptimal. Given that this repo, as you say, isn't currently used by many people, maybe renaming isn't going to be too difficult?

How about "catalog"?

Sounds good to me. However, I believe Eric should make the final decision.


[BUG] Geolocate doesn't provide error message for unknown command

Expected
Catch unknown command and display clear error message to the user
Actual

Actually, this bug is only in dev, it does work in prod.


ref #286 add a deprecation warning when using asciidoctor-pdf

$ asciidoctor-pdf doc.adoc
WARN: `asciidoctor-pdf` is deprecated and will be removed in a future version, please use `asciidoctor-web-pdf` instead

$ asciidoctor-web-pdf doc.adoc

What do you think? Is that explicit enough? I don't want to explain the "why" in the message to keep it short but we might add a reference to the GitHub issue?
ref #286
//cc @djencks

I don't think it should be depreciated.  I think that it is still useful and can still be used as long as people know the limitations

I don't think it should be depreciated. I think that it is still useful and can still be used as long as people know the limitations

Thanks for your feedback @dsisnero
Using the same binary name has proven to be confusing for a couple of users.
Moreover, the installation can fail when you have already installed asciidoctor-pdf (Ruby) globally and you want to install asciidoctor-pdf (Node.js) globally using npm.
I think it gives a bad user experience especially when users are not familiar with all the concepts: PATH precedence, nvm, npm, user space, system space...
Please note that as a replacement you will be able to use asciidoctor-web-pdf. It will not produce any warning and will work exactly the same. Is using asciidoctor-web-pdf instead of asciidoctor-pdf a big issue for you? If so, could you please make a strong case to keep asciidoctor-pdf?
Thanks!


Update Compress Function

Update compress function to handle images that are already compressed

Compare size of image compressed to the b specified by the user against the original image size. If compressed is smaller, return compressed.
Otherwise, compare size of the image compressed to b = 1 against the original image size. If the image compressed to b=1 is still bigger than original, tell user the image cannot be compressed any more. Else, tell the user to choose a smaller b.

done


Backend and Frontend need shared state communication

Describe the Feature / Enhancement
Any API calls on the backend that need authentication will need some way for users to authenticate their queries. We need to do some research to find the best options for creating, managing, and destroying authentication state with users across the two platforms (frontend and backend) and languages/frameworks (TS + Next.js on Frontend, Python + Django on Backend).
This will need to tie into the backend SSO-based authentication system that associates users with an SSO account (#8).
Additional Details and Resources
This will probably need to have some adjustments made so that the functionality works both in development and in the Docker-based production environments, given that any cookies used are tied to a given domain.
Correct Project Selected

[X] This issue is linked to the appropriate project.

Labels

[X] This issue has appropriate labels.

This was solved in #8 with cookie-based auth.


Scrolling while dragging nodes causes the node to jump (#3197 duplicate)

What platform were you using when you found the bug?

React Flow version: 11.11.4
Browser and version: Chrome, 130.0.6723.92
OS and version: Win10 22H2

Live code example
https://stackblitz.com/edit/vitejs-vite-cserbh?file=src%2FApp.tsx
Describe the Bug
https://github.com/user-attachments/assets/28c6ecd6-d211-4cad-8f1a-42ac1c7618ba
Steps to reproduce the bug or issue

Open the example in stackblitz
Select a node
Start scrolling the canvas

Expected behavior
node doesn't move when scrolling
Screenshots or Videos
No response
Additional context
No response

Interesting. This only seems to happen when the flow is less than 100% of the height. Definitely a bug! Thanks for reporting.
related to #3197

This is fixed in the newest release 12.3.5.


[Bug]: Problem converting pdf to doc.

The Problem
When converting PDF to Word, the document is converted line by line and depending on the document, it breaks the lines leaving some words spaced.
Some words are getting spaced, for example: Google  “Go ogle”
Version of Stirling-PDF
0.26.0
Last Working Version of Stirling-PDF
No response
Page Where the Problem Occurred
No response
Docker Configuration
No response
Relevant Log Output
No response
Additional Information
No response
Browsers Affected
Other
No Duplicate of the Issue

[X] I have verified that there are no existing issues raised related to my problem.

I also can't add a line after converting.
I can only edit lines that already have something.

This is a known bug with libreoffice conversion the 3rd party application we use for conversions
Nothing we can do our side sorry!


Fix cases where filter button didn't work well

Owner resource not well identified due to missing namespace aggregation
In element panel, need to provide nodeType to get filter

@jpinsonneau another small fix here ...

/approve


Configure Azure Pipelines

This pipeline configuration builds the application and produces a build for the Release configuration.

bad request sorry.


HERITAGE-265 Integrate Frequency/Tag Visualisation

Ticket URL: HERITAGE-265
About these changes
Adds tag frequency chart to search results page under Tag view.
How to check these changes
This can be found at /search/catalogue/?group=community&views=tag
Before assigning to reviewer, please make sure you have

[x] Checked things thoroughly before handing over to reviewer
[x] Checked PR title starts with ticket number as per project conventions to help us keep track of changes
[x] Ensured that PR includes only commits relevant to the ticket
[x] Waited for all CI jobs to pass before requesting a review
[ ] Added/updated tests and documentation where relevant

Merging PR guidance
Follow docs\developer-guide\contributing.md
Deployment guidance
Follow docs\infra\environments.md

approving FE code changes


Cli - search no longer supports VSRs

Currently can search CVEs, but having the ability to search VSRs again would be handy.

Let's open this up on the roadmap board


test issue

lorem ipsum dolor sit amet

@bioportal_agent requests:

remove synonym "Gus deficiency" from MONDO_0009662, comments: I don't think this is correct

This request comes from BioPortal user: jvendetti

@bioportal_agent requests:

remove synonym "Gus deficiency" from MONDO_0009662, comments: I don't think this is correct

This request comes from BioPortal user: jvendetti

@bioportal_agent requests:
MONDO (ID and label)
PSMNSW (MONDO_0013494)
Synonym to be added
Broad
Synonym subtype: i.e., broad/exact/narrow/related

sleep walking disorder

sleepwalking disorder

sleep walking

somnambulism

Database cross reference for the synonym such as PubMed ID (in the format PMID:XXXXXX) or a cross-reference to another ontology, like OMIM or Orphanet.

SCTID:804955009

OMOP:377535

Your nano-attribution (ORCID)
If you don't have an ORCID, you can sign up for one here
https://orcid.org/0000-0002-8169-9049
This request comes from BioPortal user: jvendetti


chi example don't work because wrong url pattern

I create a simple demo like /user/info/{uid}, it works fine with gin example, but the chi example always return 404 not found, I dig around and found URIParser.GetEndpointPath would convert endpoint from /user/info/{uid} to /user/info/:uid, which adapted by colon style gin router, but failed in brace style router by chi.
I had to add a convert function after config parsed to change the endpoint url back to brace style and it finally works, any good idea besides this one?
var reg = regexp.MustCompile(`:\w+`)

func convert(cfg config.ServiceConfig) {
	for _, e := range cfg.Endpoints {
		if !strings.Contains(e.Endpoint, ":") {
			continue
		}
		e.Endpoint = reg.ReplaceAllStringFunc(e.Endpoint, func(s string) string {
			return "{" + s[1:] + "}"
		})
	}
}

there is a package var for selecting the var style: https://github.com/devopsfaith/krakend-examples/blob/master/gorilla/main.go#L25


Unpin aiohttp dependency

Oh, poetry lock wanted an update too

Are you behind your pc already or should I do this in a few minutes

On it now :)

@joostlek Will this do or do we have to bump /unpin the package itself in the lockfile?

This is fine!

Like the requirements itself is just saying, any version >= 3.0.0 is fine.
When installing the lib directly via poetry it will install the lock one, if installed via pip it will just pick a version >= 3.

Here you go, do you pick this up at Core?
https://github.com/homewizard/python-homewizard-energy/releases/tag/v4.2.2
Should be available in a few minutes on PyPi


migrate project to netstandard2.0

Migrated all the projects and build to netstandard 2.0
Had to remove support for sqllocaldb.
Maybe, it would be handy to extract sqllocaldb instances and tools to build script (using preinstalled sqllocaldb.exe utility). And database instance for tests can be feed using external settings file.
NOTE: still not really going to work in linux, due to SqlServer dependency and 'integrated security'.
to run load tests it's best to
cd src\LoadTest
dotnet publish -c Release -r win10-x64 -f netcoreapp2.0
.\bin\Release\netcoreapp2.0\win10-x64\LoadTests.exe

Anyway, please review.

This actually works fine. Dual targeting is a PITA so will merge it sooner rather than later.

Merged https://github.com/SQLStreamStore/SQLStreamStore/commit/eb5298cca01907f11c5846cbbc48a5ca69c00485 Thanks for PR @mihasic


Add PWM Output

This pull request adds PWM output functionality to WipperSnapper.
Feature

Adds a new component, ws_pwm, to WipperSnapper for PWM output

Used to drive new components on Adafruit IO such as the Pizeo Buzzer and Servo

Adds new helper functions getChannel() and getInactiveChannel() to ws_ledc component.

Adds resolution to attachPin call.

Stability and refactoring

Refactors buildWSTopics() to check for malloc failures immediately after allocating topic strings.
Adds ESP32-x reset reason to serial output for enhanced debug output
Adds new function, generateDeviceUID(), which generates device UID. This functionality was previously within buildWSTopics().
Moves the ledc servo driver to new ledc/drivers folder

Testing notes:

PWM should be tested w/ ESP32, ESP32-S2, ESP8266, SAMD
Since there were changes to the ESP32-specific LEDC driver, both Servo and PWM should both be tested on ESP32

Tested on ESP32, ESP8266


Capture screenshot of lazy-loaded content

Did anyone tried to capture a screenshot of website with lazy loaded content on it ?
I mean, usually lazy loaded images are showing once you scroll over it, so I used function Input.synthesizeScrollGesture, which is used for scrolling over whole webpage.
But obviously it didn't work ...

probably need to wait some extra time..
you can also listen to network activity and wait for that to quiet down. You can use Page.lifecycleEvent for that and listen for networkidle.

@michaelknave if you know what you are waiting for, you can also use a MutationObserver, see this wiki.

@paulirish It is not connected with the network activity, the content just appears when you scroll over it. So obviously, if don't scroll down, it's not there. So some extra time does not work.
@cyrus-and Generally I don't know what I am waiting for. I f I want to make screenshots of thousands pages...

@michaelknave

So obviously, if don't scroll down, it's not there. So some extra time does not work.

Obviously, some extra time after the synthetic scroll.

Generally I don't know what I am waiting for.

That wiki uses a selector to match the newly created elements, it should let you be as generic as you want. You may need to use it in a loop or change it a bit to support repeated events.
Can you provide a real world use case or a simple example so I can try to reproduce this?


can't expand more level empty dir, such as "subdir1/subdir2/"

such as , menu->add node->"subdir1/subdir2/"
then, I just can expand to "subdir1/subdir2/", can add new node to it , can move it . But I can't add new node to "subdir1/". In another word , I can't expand the "subdir1".
May have another command that I don't know? I have use the nerdtree plugin for 4years.

Does anyone know what this "collapse directories with single children to one line" feature is called? Because I would love to be able to disable it, it breaks half of the features I use the most.

@enali, @infracanophile, update your local copy of NERDTree. I merged pull request #558 last night, which might address your issue. Specifically, look at the NERDTreeCascadeSingleChildDir and NERDTreeCascadeOpenSingleChildDir options, the first of which was added with the pull request.

Closing due to inactivity.


Inter-peer latency, jitter and bandwidth monitoring

Both overlays include heartbeats between peers; we could leverage this mechanism to measure latency and jitter. Assuming clocks are synchronised, this could be as simple as including a high resolution timestamp in the UDP heartbeat request payload and then gossiping a sliding window of historic measurements so that any peer can be asked for an overall view of the network via a REST API (if clocks are not synchronised we could measure RTT instead, however a) the response comes over the TCP control channel and may introduce additional latency due to buffering and b) it would not reveal asymmetric latency issues).
On the bandwidth side, we can either accrue this directly with sleeve or sample the OVS datapath counters depending on which overlay is in use - we would then gossip that information around too so that it is generally available as before.
Both sets of information could be used by Scope to visualise and compare performance both within cloud providers and across the public internet.

Assuming clocks are synchronised

This is a poor assumption, particularly on VMs.

This is a poor assumption, particularly on VMs.

I don't doubt your assertion, but I am shocked by it - ensuring NTP is installed and working is sysadmin 101 as far as I'm concerned :)

There is interest in this topic. Could we expose the metrics via Net's Prometheus monitoring?

Technically, exposing via Prometheus is easy.
However Prometheus does not like dealing with metrics of very high cardinality - there are N^2 possible latencies between N peers. So needs some thought on that front.


web: better client/server differentiation

Would be nice to be able to clearly differentiate between the parts of the span

closing this due to (most sincere) lack of activity


Add RECAST hello world

Add https://gitlab.cern.ch/recast-atlas/examples/helloworld as a Snakemake rule.

Also do something that is actually ATLAS-like with https://gitlab.cern.ch/recast-atlas/examples/atlas-recast-example-with-auth


chore: add gateway federation manager

Possible backport candidate if it doesn't get into 0.4.0-rc.0 since having a huge structural divergence between master and release will make emergency fix backports much harder.

Possible backport candidate if it doesn't get into 0.4.0-rc.0

Last-minute submission before the release cut? 👀 Would love to not have to backport


bad screen on windows

I run new-cloned KitchenSink on windows 10 64 bits, with
Kivy-Garden-0.1.5
kivy-2.2.1
kivy-deps.angle-0.3.3
kivy-deps.glew-0.3.1
kivy-deps.sdl2-0.6.0
kivymd-1.1.1
pypiwin32-223

on the main page, I use mouse wheel to scroll down, but I get this image with unneeded black block

Use KivyMD fron master branch


fix: use bytes objects throughout Tests class

A fix for #742
This fix works in both Python 2.7 and Python 3.8. It could use some testing in other versions of Python and on Windows however (assuming it's meant to work on Windows).
This fixes the issue by avoiding utf-8, rather than just getting Python to not crash on the invalid byte. The latter is actually simpler, but I don't think there's a way that works on both Python 2 and 3.

https://github.com/wren-lang/wren/issues/742#issuecomment-608584513
I was too fast, this is already fixed.


Zombies breaking door

When i place them infront of oak doors they dont break down the doors...kinda would like this as it would allow players to have monsters interact with blocks around them

What difficulty are you on? Zombies can only break doors on Hard/Hardcore.

hard.  Still not working even double checked

I've been testing, and I found that the ability to break doors is controlled by an NBT tag CanBreakDoors. If set to 1, it allows the zombie to break doors. I've set up a command block mechanism to check if it's possible for a zombie with CanBreakDoors to be spawned, and I'll report back with what happened.

Thank you, if i could get the code for that it would be awesome because from it i'm hoping to find a way to implement them for breaking blocks or irondoors etc :+1:

CanBreakDoors only works for wooden door blocks. You can't use it to have other blocks broken.

@Cleardragonf In order to allow you zombies to break iron doors you have to write your own AI-class/overwrite the existing AI-class.
If you have access to minecrafts decompiled sources then have a look at net.minecraft.entity.ai.EntityAIBreakDoor.

Closing this as its a non-API issue.


Go 1.7 changes

kami still works of course, but I'd like to support the now-standard context library.

[x] Add support for function signatures with context instead of x/net/context
[x] Have middleware update *http.Request's context

I think if I'm careful with build tags we can have support for both without any breaking changes.

Done, please see #25 for advice if this breaks your build. It should be easy to fix any problems.


Fix Markdown linter issues in lang/dart.md

Description

Fix Markdown linter issues in lang/dart.md introduced in #56.

Notes for Reviewers:

Ready to merge.
Signed commits

[x] Yes, I am a Member of DEVSTRONS'

Discord id (eg: DEVSTRONS'#0238):
Panquesito7#3723

@Panquesito7 update dart.md

@Panquesito7 & @chandan0000: Thanks for your contribution! :partying_face:


[Doc Issue][Update hyperlink for 'link unfurling (including stage view)]

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/m365-apps/overview.md
92
8
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/m365-apps/overview.md
92
8
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/m365-apps/overview.md
92
8
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/m365-apps/overview.md
92
8
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/TOC.yml
99
6
link
:white_check_mark:

msteams-platform/apps-in-teams-meetings/build-apps-for-teams-meeting-stage.md
90
14
link
:white_check_mark:

msteams-platform/apps-in-teams-meetings/build-tabs-for-meeting.md
92
19
link
:white_check_mark:

msteams-platform/apps-in-teams-meetings/teams-live-share-tutorial.md
92
17
link
:white_check_mark:

msteams-platform/concepts/build-and-test/share-in-meeting.md
92
14
link
:white_check_mark:

msteams-platform/concepts/design/design-teams-app-advanced-ui-components.md
91
4
link
:white_check_mark:

msteams-platform/concepts/design/overview-analytics.md
89
51
link
:white_check_mark:

msteams-platform/concepts/design/strategize-measure.md
90
31
link
:white_check_mark:

msteams-platform/get-started/glossary.md
96
27
link
:white_check_mark:

msteams-platform/m365-apps/extend-m365-teams-message-extension.md
94
15
link
:white_check_mark:

msteams-platform/m365-apps/overview.md
92
8
link
:white_check_mark:

msteams-platform/overview-explore.md
97
2
link
:white_check_mark:

msteams-platform/sbs-meetings-stage-view.yml
85
10
link
:white_check_mark:

msteams-platform/tabs/tabs-link-unfurling.md
93
6
link
:white_check_mark:

msteams-platform/task-modules-and-cards/cards/cards-format.md
96
8
link
:white_check_mark:

msteams-platform/whats-new.md
93
35
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.


Investigate / review Recycler usage

This issue is to track the investigation and review of our Recycler usage.
The Recycler was introduced as a light-weight object pool, to reduce GC pressure. We use it in various places, like pooling ByteBuf objects (not the actual memory, just the container), write tasks (When you call write(...) from outside the EventLoop) and many more.
This usage gave us a lot of trouble in the past and also users a hard time when they ended up with a lot of objects in the Reycler due writing to fast etc.
After talking with @Scottmitch we were wondering if most of our usage even make sense, as collecting short-lived objects is very fast and also "cheap" on the JDK these days.  Even worse it may hurt GC performance when running longer as we may have more objects ended up in the "old space" of the GC.
Places that come into my mind for those short-lived object that are currently using the Recycler are:

ByteBuf
AbstractChannelContext.WriteTask
ChannelOutboundBuffer.Entry

We should investigate if we may want to remove the Recycler usage for these or remove it completely.
@cconroy for example reported that he not saw any performance differences when disable the recycler via the system property.
@nmittler @Scottmitch @trustin @cconroy @buchgr @ejona86 @belliottsmith WDYT ?

also @nitsanw @NiteshKant @mosesn

It is difficult to evaluate performance without workloads, which workloads do you test with? Since this is a GC optimization it is likely to only impact applications where the Netty garbage dominates, I don't know if these usecases are core to Netty.
As a prototype/deprecation approach perhaps start by putting it behind an option so that you can easily compare the impact.

Two thoughts:

The live times of instances of the beforementioned types is usually closely tied to the duration of requests. Usually it's a few hundred micros to millis from request to response, while usually young GCs are triggered every few hundred millis to seconds. So usually those objects should die between young GCs and thus be free to collect. I am saying usually, but obviously this is completely application dependent.
However, if an application fits that description, then the question is what percentage of allocations (in bytes) per unit of time are those objects? Roughly, if you allocate N% more bytes per unit of time, then the time between young GCs will be N% shorter. The beforementioned objects might die, but lifetime of other objects might be affected and thus impact application performance negatively. Again, completely depends on your application. It might make sense to measure this allocation rate in a few "typical" Netty applications and the smaller that N is, the higher your confidence that it will not negatively impact other Netty applications.
It seems the sweet spot for the recycler are short-lived objects that make up a significant percentage of allocations per unit of time in applications that don't trigger full collections. If you changed the recycler to also allocate objects off heap, then those objects should not negatively affect full GCs.

FYI, we have tried to use the recycler for short-lived objects in gRPC and had worse results and made similar observations https://github.com/grpc/grpc-java/pull/2240.

@buchgr @nitsanw I mean at smallest and safest change we could just disable the recycler by default and let users enable it when needed. Once we are sure there is no bad impact we could remove it completely.

Disabling by default seems reasonable to me.  I'll see if we can see what our stuff looks like when it's disabled.

I have to concede I was never quite sure of the value of the recycler in some places it is used.  For some of the larger objects (e.g. lists that may contain many elements), perhaps, but for very small objects...
But I recall complaints about the amount of garbage created by the recycler itself, which is a small fraction of the garbage it saved.  So I suspect there may be some unhappy campers.  I'm also not sure in what way GC characteristics have changed materially since the recycler was introduced - besides G1, GC has been fairly behaviourally consistent in Java for a long time now.
This may also be seen as a retrograde step in comparison to e.g. log4j, which has recently gone garbage free.  But IMO garbage freedom should probably be achieved by updating the API so callers supply any dynamic allocation whose lifetime they determine, and that is a whole other can of worms.
It does seem reasonable to me to disable it, and see if people complain.  The majority of users probably do not derive any benefit for the status quo.  Probably worth putting some big red flashing message in NEWS.txt, so there's nobody too taken by surprise.

@belliottsmith yeah I think I would like to at least keep it for the List stuff in the codecs but thats it I think for now :)

I've done some experiments in the past with recyclers. Disabling them completely (for all the use-cases) degraded GC times for us. I wonder if it actually makes some sense for one of its tree use cases. I'd put my money on ChannelOutboundBuffer.Entry.
Anyways, these experiments were done before we fixed out main GC problem so it might makes sense to do that again.

@vkostyukov do you think you could wrote some canary with it disabled (via the system property) and report back ?

@normanmaurer I'm happy to do that. Will run a couple of our Integ tests (an internal tool to test Finagle topologies) with recyclers disabled today or tomorrow.

@vkostyukov thanks buddy!

@normanmaurer

@buchgr @nitsanw I mean at smallest and safest change we could just disable the recycler by default and let users enable it when needed. Once we are sure there is no bad impact we could remove it completely.

Yes, that seems like a good idea, and remove it eventually if there is no outcry from users. Is there overhead to having the recycler disabled?

@buchgr no overhead compared with the recycler enabled. The only "overhead" you see is when you compare it with how it would be without an recycler implementation at all. Basically we could safe one field / object reference per object that supports the recycler.

Let me close this for now as we saw the perf impact was really bad for Twitter :(


Add automated tests for navigation bar

This is the first PR for the automated UI tests. It adds tests for the navigation bar as well as some helper functions.

Looks nice, and not too complicated.
When I run it, I get multiple errors with
Error: ENOENT: no such file or directory, open './tests/hars/get_dev_login.undefined.har'

that's because I didn't think that through to the end  - it takes the REACT_SCIPER_ADMIN which I guess isn't set/different for you
I'll change that :woman_facepalming:

that's because I didn't think that through to the end - it takes the REACT_SCIPER_ADMIN which I guess isn't set/different for you
I'll change that 🤦♀

Does it use the SCIPER authentication? Or the dev-login?

Does it use the SCIPER authentication? Or the dev-login?
dev-login, once w/ an admin user and once w/ a non-admin one

you need to have at least the FRONT_END_URL/REACT_APP_SCIPER_ADMIN variables set

FRONT_END_URL=localhost:3000 npx playwright test

you need to have at least the FRONT_END_URL/REACT_APP_SCIPER_ADMIN variables set

FRONT_END_URL=localhost:3000 npx playwright test

Can you please update the README.md with a line that is easily copy/pastable? I don't know which SCIPER_ADMIN I have to set...

Does my running frontend need to be configured for your admin-sciper? Currently I set the admin to 100100 with the ./scripts/run_local.sh script.

no, it is now hard-coded... locally the tests pass for me, I'll check that
I cannot install the webkit dependencies on my machine at all, so I cannot confirm whether the tests pass specifically for webkit though

Does my running frontend need to be configured for your admin-sciper? Currently I set the admin to 100100 with the ./scripts/run_local.sh script.

no, it is now hard-coded... locally the tests pass for me, I'll check that

confirmed that the tests pass w/ an instance that has as admin sciper XXX and the (different) hard-coded 123456 sciper for the tests
can you check that you are on the latest head?


bolt plan apply{} blocks fail when a user's homedir is on NFS with root squash enabled.

Describe the Bug
I've created a relatively simple blan with an apply block to create a user & group on a server.  When I attempt to run bolt plan run  against a node I receive a permission denied on my home directory.
error snippet:
The task failed with exit code 1:
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/module_tool/tar/gnu.rb:8:in chdir': Permission denied @ dir_chdir - /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/module_tool/tar/gnu.rb:8:in chdir': Permission denied @ dir_chdir - /home/mlanghor (Errno::EACCES)
from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/module_tool/tar/gnu.rb:8:in unpack'         from /tmp/a03a2d62-e790-4715-ac49-87a646bc809b/apply_catalog.rb:42:in block in '
from /opt/puppetlabs/puppet/lib/ruby/2.4.0/tempfile.rb:295:in open'         from /tmp/a03a2d62-e790-4715-ac49-87a646bc809b/apply_catalog.rb:40:in '
On the remote server, my directory /home/mlanghor is an NFS mounted home directory, on which the NFS server has root squash enabled.  Therefore the root user cannot see or access files in my home directory.
I get similar issues with Puppet's exec resources if/when I run puppet agent when I'm in my home directory, though without exec resources it will run ok.
My full bolt command line I was attempting to run:  bolt plan run caiso_unix_utils::add_springboot_workspace nodes=server1 user=blah uid=20000 port_prefix=400 --modulepath=./ --run-as root --sudo-password
Expected Behavior
when I run the bolt plan with --run-as root, it should not use my home directory and should execute successfully.
Steps to Reproduce
Have a remote system using an NFS mount for user's home, with root squash enabled (so root cannot access your home directory).  Also homedir is set to 0750 permissions
Environment

1.33.0
CentOS 7.6 as a intiating client
RHEL 7.6 as the target node.

Solution

When running with a temporary directory over SSH or local transport (calling with_tempdir) we should cd into the specified tmpdir before executing.

This seems like it might be coming from https://github.com/puppetlabs/bolt/blob/master/libexec/apply_catalog.rb#L42

A workaround for this issue is to install minitar on the target systems. /opt/puppetlabs/puppet/bin/gem install minitar. That implementation doesn't involve this Dir.chdir { ... } pattern that requires it be able to cd back to its current working directory.


Add a list of all plugins in the plugin panel

Reduce the difficulty of plugin installation
Currently, plugins can only be installed via the command line.
Describe the solution you'd like
All plugins are displayed in the background plugin panel and can support the operation buttons for installing and upgrading plugins.

@LinkinStars It seems to be a bit difficult with the go language.

@LinkinStars
If it is a binary package, you must install go, nodejs, and pnpm when using the plugin. The document is https://answer.apache.org/docs/plugins#build.
Can the command line in Golang be executed to repackage and start the service?


Pagination won't go over page 1000

The backoffice doesn't allow to go over 10K documents

Looks like ES limit before scroll

Hello,
Yes this is a limitation from ES, without scroll you can't paginate all documents.
But, if we implement the scroll, you can only reach the next page from the current one.
We believe that nobody needs to see more than 1000 pages of results. The user will filter his search or order it before clicking 1000 times on a page ;)

This may be worth a little text (box, pill, tooltip...) explaining what @AnthonySendra just wrote.

I agree that the use case of going beyond 1,000 pages seems weird, the user should have filtered his search.
Although, we could also befenit from ES's search_after feature which allows to break this hard limit without using scrolls that "freeze" the result set.
https://www.elastic.co/guide/en/elasticsearch/reference/master/search-request-search-after.html
For this, we need to always have a sorting method, which is always the case (either user-specified or the default _uid sort).


subctl operations which deploy images should allow them to be overridden

What would you like to be added:
An option to override images used by operations such as verify, benchmark etc. similar to --image-override with subctl join.
Why is this needed:
Images can be overridden with subctl join, but this sets up overrides through the Submariner CR. In some contexts this isn’t sufficient (e.g. the images aren’t appropriate when running subctl after the deployment, or the user needs to use different images than those specified by the Submariner CR) and further overrides need to be specified for operations such as subctl verify.

Needs a backport to release-0.14


Madison/new apis

A few suggestions, plus the updates to tests once you change the return format on the server.

Looks good!


Removed Manifest.toml & updated compat

Not completely sure, but I think the tests fail because OPENAI_API_KEY isn't set for my fork

Yeah, that's definitely what's happening. Kind of a bummer, I'll have to figure out a different way to do CI.

Yeah it does work if I add my OPENAI_API_KEY as a repository secret for my fork. I think that's just how it has to be though, right? Each user needs their own key, I had it set locally, but not on GitHub for CI initiated by the PR. The tests should pass just fine once merged here.

Agreed, I tested your fork locally and checked the docs to make sure that's what was happening. Everything looks good to me!


Display tweaking

Add instructions for VM display params tweaking to README.md.
Tweaks to document:

Change screen resolution with Grub kernel entry
Configure aspect ratio lock (Is it even possible?)

With the new modules structure and drive-utils, implemented in #5, it is now possible to automate the the Grub configuration tweaking. This will allow to use one-line CLI command to set the desired screen resolution.