[2.29] Release updates

[ ] Blog
[ ] Screenshots https://github.com/corona-warn-app/cwa-website/pull/3174

[ ] new screenshots
[ ] new release introduction
[ ] release date

[ ] Privacy notice https://github.com/corona-warn-app/cwa-website/pull/3173

[ ] add new docs (3)
[ ] release date

[ ] FAQ/Glossary

[ ] FAQ updates/new articles ?

[ ] appToWebLinks.json:

[x] "appVersionLast": "2.29" https://github.com/corona-warn-app/cwa-website/pull/3172/commits/03c2093b0678147a3732570ee1d2c202853bcf52
[ ] new links to be added ?

[ ] Sitemap

[ ] Blog 2.29:  release date, DE/EN title
[x] Screenshots 2.28 EN https://github.com/corona-warn-app/cwa-website/pull/3172/commits/6f5dacf4cff495ebe643465748776961a79e254d DE https://github.com/corona-warn-app/cwa-website/pull/3172/commits/9b5d289baa02fae2230158f10fc06e9a01ab3b26

[ ] Gulpfile: iOS 2.29.0, Android 2.29.0 https://github.com/corona-warn-app/cwa-website/pull/3172/commits/9a3670ea84eaa853c737c7b62087c13cb389a283

Internal Tracking ID: EXPOSUREAPP-14193

Android has apparently moved from a 2.29 release to Release 3.0.x including the introduction of SRS for reporting infections and removal of the TAN hotline. This will have a significant impact on the website assuming that this version is released.

iOS has also moved to release/3.0.x, which is their default branch.

@MikeMcC399
The roll out began today at 16:30


Egork/project.toml

@soldni Brought to my attention new suggest way of configuring setuptools using pyproject.toml file
In this PR I am proposing following changes:

pyproject.toml instead of setup.py, we still keeping minimal setup.py for backward compatibility (timo).
move mmda source code and ai2_internals down into src folder for less of the confusion.

I


When deleting an aid package which is saved as draft, the quantity is not returned to the total quantity required after deletion. Cannot create the aid package after that.

[ ] When deleting an aid package which is saved as draft, the quantity is not returned to the total quantity required.

Steps to reproduce:

Create aid package as draft
Delete the package
Try to create a package.

@anjula-sack @udda1996 any updates on this?

@anjula-sack @udda1996 any updates on this?

This needs to be handled from the backend. @udda1996 can you take a look again?


How to upload a folder

How might I approach uploading a folder? Would I have to zip up the folder and then upload the zip file?

Correct, you would have to archive the directory. Note that you do not need to apply any compression as YouBit already does this. It would cause no harm though if you did.

Thanks!


Cluster folder wiping on reboots

When re-pulling the image and restarting the container via docker compose, the cluster folder gets wiped.
Additionally, when i upload items to the obelisk, even searching the folders when connected to the container i cannot see where they go, they are not in the cluster folder and i could not find them anywhere else.
I have no issue with the other folders, i'm able to configure the game.ini and GameUserSettings.ini files just fine and they do not get affected by this. however the cluster folder gets entirely wiped each restart.
Here is my docker-compose.yaml file:
version: '2.4'

services:
  asaserver:
    build: .
    image: acekorneya/asa_server:latest
    container_name: asa_island_pvp
    restart: unless-stopped
    environment:
      - PUID=1000
      - PGID=1000
      - BATTLEEYE=TRUE
      - RCON_ENABLED=TRUE
      - DISPLAY_POK_MONITOR_MESSAGE=TRUE
      - MAP_NAME=TheIsland
      - SESSION_NAME=Vertyco PvP (Slightly Boosted)
      - SERVER_ADMIN_PASSWORD=placeholder
      - ASA_PORT=7787
      - RCON_PORT=27040
      - MAX_PLAYERS=100
      - CLUSTER_ID=pvpcluster
      - UPDATE_SERVER=TRUE
      - CHECK_FOR_UPDATE_INTERVAL=24
      - RESTART_NOTICE_MINUTES=30
      - MOD_IDS=
      - CUSTOM_SERVER_ARGS=-ServerRCONOutputTribeLogs -NoTransferFromFiltering
      - ENABLE_MOTD=TRUE
      - MOTD=<RichColor Color="0,1,0,1">Servers running since November 29, 2023</>\n<RichColor Color="1,0,1,1">Exp x4 - Weight x3.5 - Gather x3 - Taming x7.5 - Breeding 90x</>\n\n<RichColor Color="1,0.65,0,1">Join the Discord for events and shop</>\n<RichColor Color="1,0,0,1">discord.gg/</><RichColor Color="0,1,0,1">vertyco</>
      - MOTD_DURATION=60
    ports:
      - "7787:7787/tcp"
      - "7787:7787/udp"
      - "27040:27040/tcp"
    volumes:
      - "/home/vert/pvp/game:/usr/games/.wine/drive_c/POK/Steam/steamapps/common/ARK Survival Ascended Dedicated Server/ShooterGame"
      - "/home/vert/pvp/server:/usr/games/.wine/drive_c/POK/Steam/steamapps/common/ARK Survival Ascended Dedicated Server"
      - "/home/vert/pvp/cluster:/usr/games/.wine/drive_c/POK/Steam/steamapps/common/ShooterGame"
    mem_limit: 16G

Am i just doing something wrong?
Extra Context

I set the PUID and PGID to the user i sign in with "vert"
I've already created the folders used in the volume bindings and confirmed that they are working when i place test files in them and then connect to the container to check.
I'm running it on a VM in proxmox, so the cpu type is set to "Host" as instructed
I'm running the docker-compose.yaml file from portainer

Yeah you are correct the reason being that server transfers are not working currently as is blocked by the devs

Ahhh okay thought I was just missing something dumb lol, thank you for the quick response!


Add support for stingray?

This PR explores adding to_stingray() and from_stingray() methods to our LightCurve object to enable easy access to features of that package!
To do: find a good example use case for these methods to add as part of an interoperability tutorial?

I incorporated @mirca's feedback and checked that the unit tests pass. I'm going to merge this for now as an experimental feature!


Fix multi-density image desired size

Fix https://github.com/fusetools/fuselibs-public/issues/775, where the desired size of a multi-density image source was calculated wrong.
This PR contains:

[x] Changelog
[ ] Documentation
[ ] Tests

@Tapped Or point me to a minimal exampe and I can probably come up with the unit test.

@mortoray Yeah, I was thinking about the same, however I'm not sure how your testing framework works in Fuselibs, but please give me some hint.

A minimal example can be found in the ticket https://github.com/fusetools/fuselibs-public/issues/775

I'll hijack your branch to create some MultiDensityImageSource tests. It appears we have no automated tests for this! :(

@Tapped Please review my minimal test and see if you agree that I'm testing the correct sizes.

Seems right :)


Upstream - Retry upload because of error permission denied

What happened?
I get the following error from the printLogs when I am trying to execute devspace dev with my devspace setup created by running devspace init and selecting helm.
Upstream - Retry upload because of error: upload archive: upload send: rpc error: code = Unknown desc = untar all: decompress: error creating /app/dapr: mkdir /app/dapr: permission denied
I have successfully deployed and worked on my application by deploying it via kubectl before but now I want to use helm.
What did you expect to happen instead?
I don't know if this is expected and I am missing something to resolve it, but at least I would like to be able to have the sync working.. I need to somehow grant the sync process root access or something.
How can we reproduce the bug? (as minimally and precisely as possible)
Use the following yaml file, the same Dockerfile if that really is necessary, init devspace using some helm chart, run devspace dev.
My devspace.yaml:
version: v2beta1
name: availableintegrationsgwgit

# This is a list of `pipelines` that DevSpace can execute (you can define your own)
pipelines:
  # This is the pipeline for the main command: `devspace dev` (or `devspace run-pipeline dev`)
  dev:
    run: |-
      run_dependencies --all       # 1. Deploy any projects this project needs (see "dependencies")
      create_deployments --all     # 2. Deploy Helm charts and manifests specfied as "deployments"
      start_dev app                # 3. Start dev mode "app" (see "dev" section)
  # You can run this pipeline via `devspace deploy` (or `devspace run-pipeline deploy`)
  deploy:
    run: |-
      run_dependencies --all                            # 1. Deploy any projects this project needs (see "dependencies")
      build_images --all -t $(git describe --always)    # 2. Build, tag (git commit hash) and push all images (see "images")
      create_deployments --all                          # 3. Deploy Helm charts and manifests specfied as "deployments"

# This is a list of `images` that DevSpace can build for this project
# We recommend to skip image building during development (devspace dev) as much as possible

images:
  app:
    image: ghcr.io/blikk-software/app-integrations:1.0.0
    dockerfile: ./Dockerfile

# This is a list of `deployments` that DevSpace can create for this project
deployments:
  app:
    # This deployment uses `helm` but you can also define `kubectl` deployments or kustomizations
    helm:
      # We are deploying this project with the Helm chart you provided
      chart:
        name: ./charts
      # Under `values` we can define the values for this Helm chart used during `helm install/upgrade`
      # You may also use `valuesFiles` to load values from files, e.g. valuesFiles: ["values.yaml"]
      values:
        ingress:
          enabled: true
          host: localhost
      displayOutput: true

# This is a list of `dev` containers that are based on the containers created by your deployments
dev:
  app:
    # Search for the container that runs this image
    imageSelector: ghcr.io/blikk-software/app-integrations:1.0.0
    # Replace the container image with this dev-optimized image (allows to skip image building during development)
    devImage: ghcr.io/loft-sh/devspace-containers/go:1.18-alpine
    # Sync files between the local filesystem and the development container
    sync:
      - path: ./
        printLogs: true
        excludePaths:
          - .git/
          - .github/
          - .vscode/
          - .postman/
          - charts/
          - postman/
          - httprequests/
          - coverage.out
          - .air.toml
    # Open a terminal and use the following command to start it
    terminal:
      command: ./devspace_start.sh
    # Inject a lightweight SSH server into the container (so your IDE can connect to the remote dev env)
    ssh:
      enabled: true
    # Make the following commands from my local machine available inside the dev container
    proxyCommands:
      - command: devspace
      - command: kubectl
      - command: helm
      - command: git
    # Forward the following ports to be able access your application via localhost
    ports:
      - port: "8080"
    # Open the following URLs once they return an HTTP status code other than 502 or 503
    open:
      - url: http://localhost:8080

# Use the `commands` section to define repeatable dev workflows for this project
commands:
  migrate-db:
    command: |-
      echo 'This is a cross-platform, shared command that can be used to codify any kind of dev task.'
      echo 'Anyone using this project can invoke it via "devspace run migrate-db"'

# Define dependencies to other projects with a devspace.yaml
# dependencies:
#   api:
#     git: https://...  # Git-based dependencies
#     tag: v1.0.0
#   ui:
#     path: ./ui        # Path-based dependencies (for monorepos)

Local Environment:

DevSpace Version: 6.1.1
Operating System: mac
ARCH of the OS: Apple M1 ARM
Kubernetes Cluster:
Cloud Provider: kind
Kubernetes Version:

Client Version: v1.25.0
Kustomize Version: v4.5.7
Server Version: v1.24.0
Anything else we need to know?
As far as I know the root level images configuration entry is not relevant in the case of devspace dev, but I do not understand how the dev.app.imageSelector entry works and why it is needed since I only want to use my current directory and two way sync it to the deployed container. But I know that my Dockerfile that is used in the dev.app.imageSelector image is creating a user and giving it permissions to the files and then in the deploy stage of the Dockerfile that user is non existent.
# syntax=docker/dockerfile:1

##
## Build
##
FROM golang:1.18-alpine AS build

WORKDIR /app
RUN adduser -u 5678 --disabled-password --gecos "" appuser && chown -R appuser /app

COPY go.mod ./
COPY go.sum ./
RUN go mod download
COPY . .

EXPOSE 8080
ENTRYPOINT ["./integrations"]

The problem in this case is that the devImage allows only root user to write into /app.
I will send a PR for the https://github.com/loft-sh/devspace-containers to make /app writeable by any user, so this issue can be assigned to me.

Is there any progress with using non-root users?
Having the same issues with a nodejs dockerfile

@unnsteinngardars I think in your case, the image used is a result of the final build target, and the chown used in the build target no longer applies.
Since you already have a build target, I might suggesting using that as your devImage. This would allow you to chown or chmod /app as needed.
For example:
images:
  app:
    image: ghcr.io/blikk-software/app-integrations:1.0.0
    dockerfile: ./Dockerfile
  app-dev:
    image: ghcr.io/blikk-software/app-integrations:1.0.0-dev
    dockerfile: ./Dockerfile
    target: build

dev:
  app:
    imageSelector: ghcr.io/blikk-software/app-integrations:1.0.0
    devImage: ghcr.io/blikk-software/app-integrations:1.0.0-dev


Woocommerce v4.3.1

Is this plugin working well with latest Woocommerce version 4.3.1?

Yes, it's working.


Search by Publisher (Developer)

Make it possible to enter the publisher into the forms to get information from all their published apps.
Example URLs:
Android: https://play.google.com/store/apps/developer?id=ioki
iOS: https://apps.apple.com/de/developer/ioki-gmbh/id1489448276
The user enters ioki for Android and ioki-gmbh/id1489448276 for iOS.
We will

Fetch the apps on that sites
Use those apps to get the information out it them

Unfortunately we have to redirect to the "See more" URL to get all apps..

For ios:
Check #34. After it is implemented it might work.
For android:
Check the Readme of https://github.com/n0madic/google-play-scraper
It seems to work just out of the box 🤓


How we can use Kata-runtime as default container runtime in k8s cluster

whenever I'm trying to make kata-runtime as default runtime for the k8s cluster, it's not coming up, kubelete service is showing error Kubemaster(master Node) not found.
I'm using the below steps to set up to make kata-runtime as the default container runtime.
https://github.com/kata-containers/documentation/blob/master/install/installing-with-kata-doc-to-script.md.
whenever I removed katacontainers.conf from docker.service.d and restart the docker & kubelete service the cluster came with no issue so the issue is somewhere in making kata-runtime as the default container runtime.
root@kubemaster:/etc/systemd/system/docker.service.d# cat kata-containers.conf
[Service]
ExecStart=
ExecStart=/usr/bin/dockerd -D --add-runtime kata-runtime=/usr/bin/kata-runtime --default-runtime=kata-runtime
root@kubemaster:/etc/systemd/system/docker.service.d#

For help, you can post your question on the Kubernetes Slack or the Discuss Kubernetes forum.
Stack Overflow is another option.
For help specifically with Kata Containers, you can read https://katacontainers.io/community/ and follow the advice there.
GitHub is not the right place for Kubernetes support requests @ravvy00 - this issue list tracks feature requests and defects that relate to the Kubernetes documentation.
/triage support

/close


DSA <IP_ADDRESS> LINKED LIST- Operations on Linked List - Insertion

Description
Description
Explain and implement insertion in the linked list.
Do not use ASSIGN command
Task

[ ] Documentation

Note

While requesting the issue to be assigned, please mention your NAME & BATCH NUMBER.
Mention the type of contribution you want to make.
Kindly refer to the Issue Guidelines.
Do not use the assign command for this issue. Follow the above procedure.
In case you see that the issue has already been assigned, try to request a different task within the same issue.
Changes should be made inside the DSA/directory & DSA branch.
Name of the file should be the same as the issue.
This issue is only for 'GWOC' contributors of the 'DSA' Domain.

Domain
DSA
Type of Contribution
Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

Domain
DSA
Type of Contribution
Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

Domain
DSA
Type of Contribution
Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

so mam I won't be getting any other issues apart from this now?

@goelesha If @thatSophisticatedMess18 is not working on this issue I am happy to Work on this issue.
Please assign me this issue.
Name: Pranshu Kashyap
Batch: DSA Batch -5
Type of Contribution: Documentation (Code C++)

@pranshukas please read the above message carefully, I have already done the documentation for the issue please find some other issue to work on

@goelesha please review my PR........

@goelesha I have worked on the changes you asked for, Please review my PR and merge it


Try to onboard package(s) of FAS user music for Fedora downstream automation

Followup of #2227

[ ] check whether the maintainer already uses Packit, if yes, contact them and ask about the feedback, offer help with setting up Packit for their other packages

If no:

[x] contact the maintainer, introduce Packit downstream automation and ask if you could create a PR with Packit config for one of their packages (you can ask whether they have access to the upstream repos or would be interested in having the config only in dist-git)

use the mail template (adjust it if needed)

After an agreement:

[ ] check this spreadsheet for the list of packages and choose one (ideally with pending release to rebase, having Git upstream, easy to configure),

the spreadsheet should be updated accordingly, make sure that the package was not onboarded already (there is overlap of the packages since they can have multiple maintainers)

[ ] create a Packit configuration setting up the Fedora downstream automation (for syncing start with one branch to not spam)
[ ] optionally test the syncing locally (see comment)
[ ] create a PR, try to do a test run (/packit pull-from-upstream --with-pr-config) and communicate further with the maintainer the follow-up steps (e.g. create issues if some functionality is missing, setup on more of their packages)

Part of #2204 epic

I've created a user card to track blockers: https://github.com/packit/user/issues/17
@majamassarini , can you please send the user response with the state of their issues:

https://github.com/packit/packit-service/issues/2343
Linking of the upstream release from dist-git PR is done.
Link source diff (e.g. https://github.com/mozman/ezdxf/compare/v1.1.2...v1.1.3). -> Ask for creating a new issue (and link it to https://github.com/packit/user/issues/17)


Ensure User-Agent is set in all request headers and UTF-8 encoding is used

This PR is a "just in case" fix for the User-Agent potentially not being set in requests, including a test for it. It also ensures the UTF-8 charset is used, since it appears to be an unresolved bug in org.apache.http.client.methods.RequestBuilder constructors.

Codecov Report

Merging #394 (e0f191f) into main (65a6ce3) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #394      +/-   ##
============================================
- Coverage     90.43%   90.43%   -0.01%
+ Complexity     1594     1593       -1
============================================
  Files           279      279
  Lines          4559     4556       -3
  Branches        197      195       -2
============================================
- Hits           4123     4120       -3
  Misses          355      355
  Partials         81       81

Impacted Files
Coverage Δ

...rc/main/java/com/vonage/client/AbstractMethod.java
76.66% <100.00%> (-2.75%)
:arrow_down:

src/main/java/com/vonage/client/HttpWrapper.java
100.00% <100.00%> (ø)


Is Large file share enabled by default either for standard storage account or premium storage account no matter with which redundancy option is set

I want to confirm with you team that
Is Large file share enabled by default either for standard storage account or premium storage account no matter with which redundancy option is set ?
If yes, may I know when this feature is enabled by default ?
I checked wiki and public documents, I didn't find any information about when the large file share enabled by default for standard storage account no matter with which redundancy option is set.
Can you update these information in the public document please ?
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 0b25d351-c396-c89f-bdfe-a77b5cb59255
Version Independent ID: dee72534-f8c3-1fe3-dc31-fe6cd5b5040d
Content: Azure Files geo-redundancy for large file shares
Content Source: articles/storage/files/geo-redundant-storage-for-large-file-shares.md
Service: azure-file-storage
GitHub Login: @khdownie
Microsoft Alias: kendownie

Hi, I just realized the large fileshare / 100 TiB option was enabled on all (really all) of our fileshares. It was on default 5 TiB until recently.

@v-zhanyeshi @murdibb Azure Files has offered 100 TiB standard SMB shares for years with locally redundant storage (LRS) and zone-redundant storage (ZRS). However, geo-redundant file shares had a 5 TiB capacity limit and were sometimes throttled due to IO operations per second (IOPS) and throughput limits. Now, geo-redundant standard SMB file shares support up to 100 TiB capacity with improved IOPS and throughput limits. We are working on updating the documentation for this and it should be complete by next week.

@v-zhanyeshi
Thank you for bringing this to our attention.
I've delegated this to content author, who will review it and offer their insightful opinions.

@v-zhanyeshi @murdibb Azure Files has offered 100 TiB standard SMB shares for years with locally redundant storage (LRS) and zone-redundant storage (ZRS). However, geo-redundant file shares had a 5 TiB capacity limit and were sometimes throttled due to IO operations per second (IOPS) and throughput limits. Now, all standard SMB file shares that are georedundant (new and existing) support up to 100 TiB capacity with improved IOPS and throughput limits. We are working on updating the documentation for this and it should be complete by next week.

Thank you for your response!
Does this mean, that all existing fileshares are also automatically updated to 100 TiB, meaning, you in theory remove the 5 TiB option now?
All related options are greyed out.
Probably need to be changed on the Azure Portal UI.
Not that we complain for the more IOPS and throughput we now get, dont’t get me wrong :)
Have a nice day!

@murdibb that's correct. In all Azure regions except China, all storage accounts are now LFS enabled. As you note, the LFS property will still show up in the portal, but it will be enabled by default and grayed out. We're leaving it in the portal for now so customers don't think it's been removed/not enabled.

The documentation has been updated.
#please-close


[Question] uploading assets fails

My repo:
https://github.com/nofishonfriday/pamplejuce
yml file:
https://github.com/nofishonfriday/pamplejuce/blob/main/.github/workflows/cmake_ctest.yml
Step 'Upload Assets' ends with 'not include valid file':
https://github.com/nofishonfriday/pamplejuce/runs/7159178490?check_suite_focus=true
Yet I can see the generated artifacts:
https://github.com/nofishonfriday/pamplejuce/actions/runs/2600074670
What goes wrong here?
(I'm pretty new to GitHub actions, so might well be the error is on my side.)
Thanks.

similar report here as well #247


[AERIE-1764] Return more information about errors.

Tickets addressed: AERIE-1764
Review: By commit
Merge strategy: Merge (no squash)

Description
Just a tiny change to return more information about the errors and the error object to the user. It makes it easier to debug and allows our users to understand the errors they receive from the worker.
https://hasura.io/docs/latest/actions/action-handlers/#returning-an-error-response
Verification
Manually created errors to see how they show up in Hasura
Documentation
none
Future work
none

I like this change, but I don't think we should be using this mechanism for operations we know are fallible. So this is a good change to have in addition to correcting our responses to be fallible with error fields.

I like this change, but I don't think we should be using this mechanism for operations we know are fallible. So this is a good change to have in addition to correcting our responses to be fallible with error fields.

Hi Dylan I don't think I follow your statement. Are you saying we should not default to this catch-all error reporting and do a more specific error reporting in each endpoint?

I like this change, but I don't think we should be using this mechanism for operations we know are fallible. So this is a good change to have in addition to correcting our responses to be fallible with error fields.

Hi Dylan I don't think I follow your statement. Are you saying we should not default to this catch-all error reporting and do a more specific error reporting in each endpoint?

Lee Byron - the creator of GraphQL - has specifically stated on multiple occasions that the error mechanisms for GraphQL are NOT intended for known error modes and those should be managed in the return types specifically. Here's a decent article on it https://productionreadygraphql.com/2020-08-01-guide-to-graphql-errors
Basically, the "caught errors" should only be used for exceptional errors, not business-logic-defined errors.

I like this change, but I don't think we should be using this mechanism for operations we know are fallible. So this is a good change to have in addition to correcting our responses to be fallible with error fields.

Hi Dylan I don't think I follow your statement. Are you saying we should not default to this catch-all error reporting and do a more specific error reporting in each endpoint?

Lee Byron - the creator of GraphQL - has specifically stated on multiple occasions that the error mechanisms for GraphQL are NOT intended for known error modes and those should be managed in the return types specifically. Here's a decent article on it https://productionreadygraphql.com/2020-08-01-guide-to-graphql-errors
Basically, the "caught errors" should only be used for exceptional errors, not business-logic-defined errors.

According to the article you linked, unless we're actually using this to report something like the constraints check failed, this looks like the correct place to report errors such as exceptions/timeouts/unavailable services.

I like this change, but I don't think we should be using this mechanism for operations we know are fallible. So this is a good change to have in addition to correcting our responses to be fallible with error fields.

Hi Dylan I don't think I follow your statement. Are you saying we should not default to this catch-all error reporting and do a more specific error reporting in each endpoint?

Lee Byron - the creator of GraphQL - has specifically stated on multiple occasions that the error mechanisms for GraphQL are NOT intended for known error modes and those should be managed in the return types specifically. Here's a decent article on it https://productionreadygraphql.com/2020-08-01-guide-to-graphql-errors
Basically, the "caught errors" should only be used for exceptional errors, not business-logic-defined errors.

According to the article you linked, unless we're actually using this to report something like the constraints check failed, this looks like the correct place to report errors such as exceptions/timeouts/unavailable services.

Yes, but not for things like "Hey you have some type errors in your sequence and we weren't able to convert it to season"

I like this change, but I don't think we should be using this mechanism for operations we know are fallible. So this is a good change to have in addition to correcting our responses to be fallible with error fields.

Hi Dylan I don't think I follow your statement. Are you saying we should not default to this catch-all error reporting and do a more specific error reporting in each endpoint?

Lee Byron - the creator of GraphQL - has specifically stated on multiple occasions that the error mechanisms for GraphQL are NOT intended for known error modes and those should be managed in the return types specifically. Here's a decent article on it https://productionreadygraphql.com/2020-08-01-guide-to-graphql-errors
Basically, the "caught errors" should only be used for exceptional errors, not business-logic-defined errors.

According to the article you linked, unless we're actually using this to report something like the constraints check failed, this looks like the correct place to report errors such as exceptions/timeouts/unavailable services.

Yes, but not for things like "Hey you have some type errors in your sequence and we weren't able to convert it to seqjson"

For my understanding wont. ..(err.cause ? { cause: err.cause } : {}), return the cause for the sequence generation failure from aerie-ts-user-code-runner Unless you want to capture any errors outside of aerie-ts-user-code-runner which should show up under message: err.message

I like this change, but I don't think we should be using this mechanism for operations we know are fallible. So this is a good change to have in addition to correcting our responses to be fallible with error fields.

Hi Dylan I don't think I follow your statement. Are you saying we should not default to this catch-all error reporting and do a more specific error reporting in each endpoint?

Lee Byron - the creator of GraphQL - has specifically stated on multiple occasions that the error mechanisms for GraphQL are NOT intended for known error modes and those should be managed in the return types specifically. Here's a decent article on it https://productionreadygraphql.com/2020-08-01-guide-to-graphql-errors
Basically, the "caught errors" should only be used for exceptional errors, not business-logic-defined errors.

According to the article you linked, unless we're actually using this to report something like the constraints check failed, this looks like the correct place to report errors such as exceptions/timeouts/unavailable services.

Yes, but not for things like "Hey you have some type errors in your sequence and we weren't able to convert it to seqjson"

For my understanding wont. ..(err.cause ? { cause: err.cause } : {}), return the cause for the sequence generation failure from aerie-ts-user-code-runner Unless you want to capture any errors outside of aerie-ts-user-code-runner which should show up under message: err.message

Because we are throwing

@goetzrrGit Does this conform to the Hasura GQL error reporting format? I'm having trouble telling if it is from the TS diff but I haven't looked too deep.

@pcrosemurgy Yes, this does conform to what Hasura suggests. There is going to be tickets to catch fallible errors so we don't have to use this catch-all in the PR too often.

Going to merge as we are moving forward with the failable Hasura action in Dylan's PR. This one will be used to catch anything that isn't failable.


Gitlab notebook url

waiting for @leafty to test with #201 before merging

IMHO the environment API is a good intermediate layer so we have a flexibility to change the final notebook URL. There are many potentially moving parts - jupyterhub subdomain vs. path prefix, service name, etc. Also note that UI only depends on GitLab for now. If we want to avoid using environment API, we should add an explicit configuration option for JupyterHub to UI.

@jirikuncar I think it needs to be the latter (a Jupyterhub path option to the UI) -- as it is now, you can't launch a notebook if you are attaching to e.g. a gitlab that we don't control. If you construct the paths independently of the gitlab CI environment, this would work out of the box.


The Verida Connect modal is not cleaned from the DOM and can even be added multiple times

The Verida Connect modal is injected in the DOM when a connection is triggered. Whether the connection goes through or not, the elements are not cleaned from the DOM. If a connection is triggered again, the modal is added again.
There is no apparent conflict but it's not optimised and clean.

Fixed with https://github.com/verida/verida-js/commit/9c78f295643382995f4d382003873086f25668fe
Prevents duplicate DOM entries, but does leave the existing DOM entry there as it won't do any harm.


test for single frame video

https://github.com/mgjeong/rust-by-examples/assets/29028820/f68afa3b-4ddb-4c4a-a10f-ff79df578cb4


Add PR help message functionality and update dependencies

User description

Implement PRHelpMessage class to provide AI-powered assistance for pull requests.
Add methods for similarity search using local, S3, and Pinecone databases.
Update requirements.txt to include new dependencies for langchain and chromadb.
Modify configuration.toml to include force_local_db setting for PR help.
Update aiohttp and openai package versions.

PR Type
Enhancement

Description

Implemented AI-powered PR help functionality in the PRHelpMessage class
Added methods for similarity search using local, S3, and Pinecone databases
Improved error handling and logging throughout the PR help process
Updated PR help message generation to support different Git providers
Added 'force_local_db' configuration option in configuration.toml
Updated aiohttp and openai package versions in requirements.txt
Added new dependencies for langchain, chromadb, and related packages to support AI-powered functionality

Changes walkthrough 📝
Relevant filesEnhancement

pr_help_message.pyImplement AI-powered PR help functionality

pr_agent/tools/pr_help_message.py
Implemented PRHelpMessage class with AI-powered assistance for pull requests  Added methods for similarity search using local, S3, and Pinecone databases  Improved error handling and logging  Updated PR help message generation for different Git providers

+340/-96

Configuration changes

configuration.tomlAdd force_local_db configuration option

pr_agent/settings/configuration.toml

Added 'force_local_db' option to pr_help section

+1/-0

Dependencies

requirements.txtUpdate dependencies and add new packages

requirements.txt
Updated aiohttp and openai package versions  Added new dependencies for langchain, chromadb, and related packages

+8/-2

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

/help "how to change the code suggestion to be commitable ?"

/help "how to change the code suggestion to be commitable ?"

/help "how to use pr-agent with self hosted llm"

can i use pr-agent with llama.cpp

/improve

/review

/analyze


React to enter press when nothing is selected

I have following values available for autosuggest:

value 1
value 2
value 3

Now, without doing any selection with arrows or mouse, I want to type "value 1" and hit enter. Currently, I can't seem to get any callback on this. Am I missing something?

@samuliheljo Could you please describe what are you trying to achieve? What's your use case? What do you expect to happen when you press Enter?

Sure.
Firstly, thanks for great component. For the most part it has worked perfectly for us.
So the case is that we are using autosuggest to find addresses that are stored on a server. It seems that some users just type their needed address to input field (e.g. "Mainroad 1") and press enter without actually selecting that specific value from autocomplete dropdown even when it is visible in dropdown. Now, what happens is that user types "Mainroad 1", hits enter, and nothing happens.
What should happen when enter is pressed? It depends on the situation, but preferably "something". That "something" is what I want to implement.
We have a working version where we use React ref callback function to catch autosuggest mount to dom something like this:
<Autosuggest
      ref={this.handleAutoSuggestMount}

Then we find autosuggest input field through it's ref and attach keyup event listener to input like so:
handleAutoSuggestMount(autoSuggestComponent) {
  input = autoSuggestComponent.refs.input.getDOMNode()
  input.addEventListener('keyup', () => {...})
  ...
}

This way we can do some "extra stuff" when we notice the given situation occurs. This, however, feels quite dirty.
So:

Am I thinking this somehow backwards, is there easier way to react to enter press when nothing is selected, but still visible in dropdown?
If not, any plans on adding support for it?

To give an extra example for "something"

User types "Mainroad" and hits enter
We want to search for "the first address that exist on Mainroad", and select coordinates for it

This way user can find at least some location on Mainroad easily

@samuliheljo Thanks for the explanation!
Will this work?
onFormSubmit() {
  // do your stuff
}

<form onSubmit={onFormSubmit}>
  <Autosuggest ... />
</form>

Yes, it does. Cheers! Closing this issue.

What about if you want the first suggestion to be selected on enter? How do you get the data from the provided suggestions to pass to react-router?

@JamieDixon Could you elaborate?

Type Pinapple into the field.
Your Auto Suggest information only returns Apples.
User is looking for pineapples, so presses enter or hits a search button.
User should be taken to a search page with query pineapple.
The other use case is I want hitting enter to take the first suggestion and navigate to that. form onSubmit can handle the first case but not the second because I can't communicate back up to see what the first suggestion was to grab it's url to submit.

@JamieDixon You supply suggestions to Autosuggest, so why can't you know the first suggestion? Another way to hook up to Enter is to add inputProps.onKeyDown, and check for event.key === 'Enter', if that helps.

I think you're referencing me @jamiedixon but meaning to refer to @jwilkinson :)


Reversible Solvers

Hey Patrick,
Here's an implementation of Reversible Solvers! This includes:

make any AbstractRungeKutta method in diffrax algebraically reversible - see diffrax.Reversible
backpropagate through the solve in constant memory and get exact gradients (up to floating point errors) - see diffrax.ReversibleAdjoint

Main details I should highlight here:

The current implementation relies on the _SolverState type of AbstractRungeKutta methods. Specifically, as the reversible method switches between evaluating the vector field at y and z, we ensure the fsal is correct by evaluating the vector field outside of the base Runge Kutta step. In principle this is unnecessary but required to fit with the behaviour of AbstractRungeKutta solvers; any ideas for how to avoid this?

To backpropagate through the reversible solve we require knowledge of the ts that the solver visited. As this is not known a priori for adaptive step sizes, I've added a (teeny weeny) bit of infrastructure to the State in _integrate.py. This allows us to save the ts that the solver stepped to which we make available to ReversibleAdjoint as a residual. The added State follows exactly the implementation of saving dense_ts and is only triggered when adjoint=ReversibleAdjoint.

Best,
Sam

Thanks very much for the review and suggestions!
I'll reply to individual comments inline but here is an overview:

I really like the idea for removing Reversible from the public API and just making the adjoint auto-wrap the original solver. It feels very JAX-like, as we just augment the forward-trace so that we can backpropagate with improved properties. This has been added.

Can now use any AbstractSolver, apart from solvers that are already algebraically reversible (raises a ValueError if passed).

Add functionality for SaveAt(steps=True).

Improved docs so that people know what they can use ReversibleAdjoint with (any solver, ODEs/CDEs/SDEs, adaptive time steps).

Improved tests


Support console groups in debug output

Use the new vscode js debugger

Copy the example from https://developer.mozilla.org/en-US/docs/Web/API/Console/group

The output should look like this, on both sessions, but it only works on the parent:

Feature request. @jramsay FYI.

Seems to work


Show OS distribution stats in the UI

Where to show the stats?
Option (a) is in the sidebar after "Downloads Counts", option (b) is to put a link in the sidebar "Advanced Stats" that goes to a separate page where we put all the project stats there.
My only concern with option (a) is that the sidebar might end up being too long in the future, and that if in the future we want to (say) display graphs or stuff like that, then we'll have to do something like option (b). But, maybe we can start with option (a) and move stuff around once we need to?
How to show the OS stats?
Option (a) is the raw numbers, option (b) is computing the share. So, option (a) would look something like:
OS Distribution
400 downloads from Linux
200 downloads from Mac OS
100 downloads from Windows
300 downloads from Other
And option (b) would look something like:
OS Distribution
40% downloads from Linux
20% downloads from Mac
10% downloads from Windows
30% downloads from Other
I don't have any strong opinion here, I think option (a) or (b) would work fine.

@spderosso Thank you for your detailed suggestion, and sorry for the slow response!
For context: The folks working on Warehouse have now gotten limited funding to concentrate on improving and deploying it, and have kicked off work towards our development roadmap -- the most urgent task is to improve Warehouse to the point where we can redirect pypi.python.org to pypi.org so the site is more sustainable and reliable.
Since this feature, like #699, isn't something that the legacy site has, I've moved it to a future milestone, indicating that the core maintainer team isn't going to work on it till after we've finished shutting down the legacy site. And if I understand correctly, there may be technical or policy difficulties in sniffing out what OS users are using, and in properly indicating that sometimes the sample size is really small or temporally discontinuous in important ways (e.g., if it turns out that most historical data does not have the attributes we'd need to measure). But I'm interested in hearing more about how this could work!
Thanks and sorry again for the wait.

Possibly related: #787.

Closing for now, as we don't have live statistics feedback from BigQuery, but the data is there for those that want it.


Allow numbers override function

This exposes percentNumberKey which allows us to pass in custom numbers override function if we need to.

Number key modifiers are a bit too complicated to override in that way, because they contain math that depends on the key codes.
If someone wishes to override them, this will now be possible in the latest update (f56b355e39fe2e7f09563f903f2d73a53ae44f58).
You would need to pass enableNumbers: false as an option, and write a custom key function similar to:
videojs('vidId').ready(function() {
  this.hotkeys({
    enableNumbers: false,
    customKeys: {
      numbersKey: {
        key: function(event) {
          // Override number keys
          return ((event.which > 47 && event.which < 59) || (event.which > 95 && event.which < 106));
        },
        handler: function(player, options, event) {
          // Do not handle if enableModifiersForNumbers set to false and keys are Ctrl, Cmd or Alt
          if (options.enableModifiersForNumbers || !(event.metaKey || event.ctrlKey || event.altKey)) {
            var sub = 48;
            if (event.which > 95) {
              sub = 96;
            }
            var number = event.which - sub;
            player.currentTime(player.duration() * number * 0.1);
          }
        }
      }
    }
  });
});

hey @ctd1500, thanks for your suggestion above. I have another question then - not sure if i should create an issue for this question or not, but lemme know if you'd prefer it that way.
Is there a way to toggle the option values for an existing hotkeys instance? There are some occasion when I have to enable / disable the number keys (and actually for other keys as well), and it seems like I can't do it with the same instance.
Another way would be, destroy the hotkey instance and reinitialize it with other option values each time i need to change it. Though I am not sure how to do the destroying part.
Please let me know if you have any suggestion.
Thanks!


Makefile build target broken

The manual installation steps in the readme fail on the make step.
$ make
GOPATH="/Users/x/code/pick:/Users/x/code/pick/vendor" go get github.com/rogpeppe/godeps
GOPATH="/Users/x/code/pick:/Users/x/code/pick/vendor" /Users/x/code/pick/vendor/bin/godeps -u dependencies.tsv
/bin/sh: /Users/x/code/pick/vendor/bin/godeps: No such file or directory
make: *** [goget] Error 127

cc: @leonklingele

test: goget
	GOPATH=$(GOPATH) go test -v $(FOLDERS)

We should be able to achieve the same functionality with go test -v ./...

I'm sorry! Fixed with https://github.com/bndw/pick/pull/30

Regarding go tests: What's the problem with the way it is in Makefile?

Both methods will certainly work; my suggestion simply uses the go tool directly rather than also using find.

Your command will also run the unit tests from all vendor/ packages, which should avoided IMO.

Good point


chore: add Cilium images for v1.12.0-rc3

Add v1.12.0-rc3 images for cilium, cilium-operator,
and cilium-operator-generic.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Add latest Cilium images.
Requirements:

[x] uses conventional commit messages

Special notes for your reviewer:
cilium/operator-generic is a new image that we started publishing recently.
Release note:
Add v1.12.0-rc3 images for cilium, cilium-operator, and cilium-operator-generic.

cilium 1.12.0 GA'd today, so going to use that instead. will open another PR once the images are ready


Fly WireGuard peers

We launch some external machines that would like to participate in the Fly mesh, is it possible to manage WG peers via this Terraform provider? Not sure if this is something currently supported by the undoc'd internal API, but would be awesome.

It must be possible in the API, since fly wireguard <list|create|remove> is doing it somehow, but this provider has no resource or data source(s)  for that.
I'd also like it though 👍🏻.

Also it doesn't seem possible through the CLI currently to provide a public part of an extant key to use, it insists on generating a keypair?
This would be good to have anyway, but I think especially so in a Terraform context, since the (non-Fly) peer may quite likely already have a WireGuard interface that you want to add the Fly app to.


An unexpected error occurred:

I got an error running the plugin in the bash:
[root@web ~]# /usr/local/psa/var/modules/letsencrypt/venv/bin/letsencrypt
An unexpected error occurred:
ContextualVersionConflict: (cryptography 1.1 (/usr/local/psa/var/modules/letsencrypt/venv.7nNoz/lib/python2.7/site-packages), Requirement.parse('cryptography>=1.3'), set(['PyOpenSSL']))
Please see the logfile 'letsencrypt.log' for more details.
[root@web ~]#
Using Plesk in a browser it Looks like:
Error: Let's Encrypt SSL certificate installation failed: Failed letsencrypt execution: Traceback (most recent call last):
File "/usr/local/psa/var/modules/letsencrypt/venv/bin/letsencrypt", line 11, in <module>
sys.exit(main())
File "/usr/local/psa/var/modules/letsencrypt/venv.7nNoz/lib/python2.7/site-packages/letsencrypt/cli.py", line 1950, in main
plugins = plugins_disco.PluginsRegistry.find_all()
File "/usr/local/psa/var/modules/letsencrypt/venv.7nNoz/lib/python2.7/site-packages/letsencrypt/plugins/disco.py", line 168, in find_all
plugin_ep = PluginEntryPoint(entry_point)
File "/usr/local/psa/var/modules/letsencrypt/venv.7nNoz/lib/python2.7/site-packages/letsencrypt/plugins/disco.py", line 31, in init
self.plugin_cls = entry_point.load()
File "/usr/local/psa/var/modules/letsencrypt/venv.7nNoz/lib/python2.7/site-packages/pkg_resources/init.py", line 2201, in load
self.require(*args, **kwargs)
File "/usr/local/psa/var/modules/letsencrypt/venv.7nNoz/lib/python2.7/site-packages/pkg_resources/init.py", line 2218, in require
items = working_set.resolve(reqs, env, installer)
File "/usr/local/psa/var/modules/letsencrypt/venv.7nNoz/lib/python2.7/site-packages/pkg_resources/init.py", line 835, in resolve
raise VersionConflict(dist, req).with_context(dependent_req)
ContextualVersionConflict: (cryptography 1.1 (/usr/local/psa/var/modules/letsencrypt/venv.7nNoz/lib/python2.7/site-packages), Requirement.parse('cryptography>=1.3'), set(['PyOpenSSL']))
I use plesk 12.5.30 with CENTOS 7. According to
https://community.letsencrypt.org/t/plesk-12-5-debian-7-9-error-by-create-a-ssl/12809
other People using Debian and Ubuntu had the same problem.

pls see https://github.com/plesk/letsencrypt-plesk/issues/86

We updated cffi to 1.5.2 and cryptography to 1.3.1, you need to reinstall the extension, or re-run /usr/local/psa/admin/bin/modules/letsencrypt/le-installer


When rebuilding Terrain Editor docker for terrain tools resets it's position to where it starts on first use.

I can't seem to get the terrain editor docker to stay where I want it after I rebuild the terrain. It saves it's position in my custom layout so it will go back when I select my layout, but it always pops back to where it started default when I rebuild the terrain. Is there something I'm missing or would that be a bug? This is with Godot 4.3, on windows 10, with an NVidia RTX 2060.

Oh that's interesting!
I never realized we could move the tab haha!
I might have something to do to handle this!
I'll check that!

@GeminiSquishGames After some tests, It seems like if I want to support this, I'll have to add this panel always open, even if no Terrain node is selected.

I don't know yet if I like that or not! I'm still thinking about this.
I love the fact that we can move the panel, but I hate the fact that it's always there, as soon as the plugin is enabled 🫤

Hmm, I see what you mean. You could do the add_control_to_bottom_panel instead of using docks for your controls. That's where the Visual Shader node editor and Animation editor are by default, I don't remember the conversion from GDscript to C# for editor tools off the top of my head, but you should also be able to put the dock anywhere with the right CONSTANT position iirc. I think docks are just always open, it's like that for the Git version control plugin too. It just always exists if the plugin is active and becomes active when it's created. I have to close plugin docks if I don't need them or tuck them somewhere else in my personal layout.

The thing is, if I put it at the bottom, you won't be able to move it, it will have to remain there, since it's not a "dock".🫤
I think at this point, I'll have to decide if I want to have the empty panel or not.
It's not too bad I think but yeah!
Also, I already use the _handles, it does nothing for this 😟
I made a pull request here, in case you want to try it : https://github.com/spimort/TerraBrush/pull/141

It doesn't have to be empty maybe? You could have it have one ui scene to
handle instancing the terrain node and other pre-settings, perhaps.  The
file system dock can go either way now since 4.3, dock or bottom, but I do
not know what that method is or if it is exposed to the EditorPlugin class
ATM.
It not being a dock would be why you'd put it at the bottom, it wouldn't
need to be moved as the other docks wouldn't be in it's way or vice versa,
and I doubt that I would need to use any other bottom panel things when
editing the terrain, but I probably would use docks like the inspector and
node hierarchy.
Either way works as long as it doesn't move from where the user wants it
when they rebuild the terrain, which is often. 😓 Thank you so much for
looking into it though!
On Sun, Sep 22, 2024 at 12:52 AM spimort @.***> wrote:

The thing is, if I put it at the bottom, you won't be able to move it, it
will have to remain there, since it's not a "dock".🫤
I think at this point, I'll have to decide if I want to have the empty
panel or not.
It's not too bad I think but yeah!
Also, I already use the _handles, it does nothing for this 😟
I made a pull request here, in case you want to try it : #141
https://github.com/spimort/TerraBrush/pull/141
—
Reply to this email directly, view it on GitHub
https://github.com/spimort/TerraBrush/issues/140#issuecomment-2365482469,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABHE6AFVNE5AHZPEWUMU5ALZXZLKFAVCNFSM6AAAAABORCWLVWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRVGQ4DENBWHE
.
You are receiving this because you were mentioned.Message ID:
@.***>

Sounds good! I think that what I could do is to add a setting for it, so it can be turned on/off.
The setting would be to keep the dock alive or not.
And probably defaulted to true.
It will break how people use it right now but I think it's for the best. And they could turn it off if needed.
I'll try that probably this week.

I did push the modification to main 🙂 I'll close the issue for now, if you have other problems with it, feel free to open another one!

In version 0.8.6Alpha


[Xcodeproj] Generating clibs targets 2

Replaces #205
Generated for project with 20 deps - everything works.
Please review.

@mxcl It works beautifully here with https://github.com/Zewo/Zewo, which has 34 dependencies and 3 of them are C libs.

@swift-ci Please test

@mxcl I fixed test case, please test again.

@swift-ci please test

@swift-ci Please test

/Users/buildnode/jenkins/workspace/swift-package-manager-PR-osx/swift/stdlib/public/SDK/WatchKit/WatchKit.swift:38:5: error: value of type 'WKInterfaceController' has no member 'present'

WatchKit?

Ok, build succeed. The problem, as I understand, was with main swift codebase.


Small Edits

@mucaho:
I have made a few small edits to your CraftyJS progress bar. Namely, I edited the README and example web page. If you don't like my edits please tell me, but otherwise please merge.
:smiley:

Thanks!

You're welcome : )


[Frontend] [Tensorflow] ReadVariableOp operator

The ReadVariableOp gets eliminated when you freeze the TensorFlow graph and is not needed for the inference.
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/python/framework/graph_util_impl.py#L464
If we find a ReadVariableOp in a TF graph, we error out and ask for a frozen graph.
TODO -
Another approach is to freeze the unfrozen graph in from_tensorflow API itself.

Created the PR on upstream hence closing this one. https://github.com/apache/incubator-tvm/pull/4952


Uploader policy update (DFCT0010069)

What does this PR do and why?
Describe in detail what your merge request does and why.
This PR updates policy methods for a user with uploader access level to be able to create a sample, modify a sample (create/remove files, update sample metadata), and read projects
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other pull requests.

How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.

Start up irida next
Login as any user
Create a project and a group
Add bot accounts to both with an UPLOADER access level. Copy down the tokens
Generate new tokens for both bot accounts and set the Expiration to an earlier date. Copy down the token
Use Postman to test out the graphql queries
In Postman click the icon/button next to Untitled Request and select Graphql
In the URL input, type in http://localhost:3000/api/graphql
Click on the authorization tab. Here you can run the query/mutation with the bot accounts using their email and the tokens as the password. Make sure to try out all the queries/mutations using the valid and expired tokens for each bot account. Verify the bot account with the UPLOADER access level can query/mutate if they have a valid token, otherwise they should not be able to.
Take a look in the test/graphql/ directory for all the queries and mutations and to see how the data is passed in to each query and mutation.

PR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

[X] I have evaluated the PR acceptance checklist for this PR.

Overall looks great!
Can you make a separate error message for attempting to use an expired token? Right now the error returned is Unable to access object while accessing the API in guest mode, which doesn't make much sense for this case.

I added that error message in PR 620. At that stage, the token would have already failed authentication and when that happens the User is placed in guest mode. The same thing happens if the User attempts to use the API without a token. So when the error is thrown there is no context of having an expired token as it wont be set. So long ways around to saying that we can't change this error message, as it is can be thrown when accessing specific API endpoints that require authorization while attempting to use an expired token or while not providing any token at all.


Reconcile arguments for hyperparameters in ml_* functions with Spark

...and make sure we're exposing all the available arguments.

RF https://github.com/rstudio/sparklyr/issues/377


Inceptionev/2020 06 17 sample data

adding sample data from test

This was generated from a pure unmodified pull from master at the SHA listed on the data flies.  The pinch_valve.cpp file was changed later and got accidentally swept up in the commit, and was then reverted.  There should only be test data files in this PR.

In order to be a little less confusing (actually remove any and all change from pinch_valve.cpp from git history), could you combine those commits into one before merging (use the "squash and merge" button instead of "rebase and merge")?


Update rand and rand_distr

Doesn't seem to break anything.

Thank you, this has now been done in another PR


Fix some broken links on README.md

This patch fixes some broken links on README.md page.

Link to eds.proto.html.
Link to xds protocol longer explanation page.

Signed-off-by: Dhi Aurrahman<EMAIL_ADDRESS>

@dio Merging this. Thanks for the PR.


Adds links to other client libraries projects

Checklist

[X] All acceptance criteria are met.
[X] Commits in this PR are minimal and have descriptive commit messages.

Link back in 064c19c87e4819f48d794ec219fe430d9e002988

@nicolasmondada You can branch off from this branch as well, no need to wait for it to merge :)

Sorry, apparently Kay had already made the same changes in her docs, which I've just migrated to. I've applied @nicolasmondada's PR and created a new one with succeeding CI in #323.


Invariant Violation: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: object

I'm trying to use Reactjs.NET .
I use typescript & webpack.
I have a simple tsx file like this:

import * as React from "react";

export default class Hello extends React.Component<any, any> {
	render() {
		return
Hello world !

	}
}

tsconfig.json:
{
	"compileOnSave": true,

	"compilerOptions": {
		"sourceMap": true,
		"target": "es5",
		"module": "commonjs",
		"declaration": false,
		"noImplicitAny": false,
		"removeComments": true,
		"experimentalDecorators": true,
		"noLib": false,
		"jsx": "preserve"

	},

	"exclude": [
		"node_modules",
		"static"
	]
}

I stepped forward through this guide.
webpack.config.js
var path = require('path');

module.exports = {
	context: path.join(__dirname, 'scripts'),
	entry: {
		server: './server'
	},
	output: {
		path: path.join(__dirname, 'build'),
		filename: '[name].bundle.js'
	},
	module: {
		loaders: [
      // Transform JSX in .jsx files
      { test: /\.jsx$/, loader: 'jsx-loader?harmony' },
			 {
			 	test: /\.tsx?$/,
			 	exclude: /(node_modules|bower_components)/,
			 	loader: 'ts-loader'
			 }
		],
	},
	resolve: {
		// Allow require('./blah') to require blah.jsx
		extensions: ['', '.js', '.jsx']
	},
	externals: {
		// Use external version of React (from CDN for client-side, or
		// bundled with ReactJS.NET for server-side)

	}
};

After doing all the steps. I encouter to this error:
Error while rendering "Components.Hello" to "app": Invariant Violation: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: object.
   at invariant (Script Document [2]:104:16) ->    throw error;
   at instantiateReactComponent (Script Document [2]:5747:103)
   at Script Document [2]:19548:32
   at Mixin.perform (Script Document [2]:3788:21)
   at renderToStringImpl (Script Document [2]:19544:25)
   at renderToString (Script Document [2]:19574:11)
   at Script Document [6] [temp]:1:16
Line: 104
Column:16

changing ts config to get js files instead of jsx, but still no luck !
I also changed module system to amd and others ...
what have I missed !?

I change my index.js file from
module.exports = {
	// All the components you'd like to render server-side
	Hello: require('./Hello')

};

to
module.exports = {
	// All the components you'd like to render server-side
	Hello: require('./Hello').Hello

};

And It worked.


Fix overflow issue in naturalsize with np.int32 input

Fixes #217
Changes proposed in this pull request:

Change the order of operations of the return statement in the naturalsize function to ensure all intermediate calculations stay float to prevent overflow issues.

Thank you!


Using teletraan as the puppet replacement

Can we use teletraan to deploy some files (configurations) as what puppet does? Does teletraan have no limitation on the format of things it deploy?

Teletraan can be used to deploy anything in tar.gz file format, it could be just a bundle of files!


btrfs: #ifdef for build version

We removed it, because upstream removed it. But now it will be coming
back, so work with it either way.
ping @lsm5 @tianon
ref:

https://github.com/docker/docker/pull/11417
https://github.com/tianon/docker-overlay/issues/38#issuecomment-86105345

Signed-off-by: Vincent Batts<EMAIL_ADDRESS>

@tianon fixed and cleaned up the other one too. PTAL

:heart_eyes: amaze
LGTM :+1:

should this be in 1.6.0, also LGTM

if it were in docker 1.6.0 then docker would not skip a version of
providing as much information as is available
On Wed, Mar 25, 2015 at 2:25 PM, Jessie Frazelle<EMAIL_ADDRESS>wrote:

should this be in 1.6.0, also LGTM
—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/pull/11753#issuecomment-86159167.

its been added to the bump branch :)
On Wed, Mar 25, 2015 at 11:27 AM, Vincent Batts<EMAIL_ADDRESS>wrote:

if it were in docker 1.6.0 then docker would not skip a version of
providing as much information as is available
On Wed, Mar 25, 2015 at 2:25 PM, Jessie Frazelle<EMAIL_ADDRESS>
wrote:

should this be in 1.6.0, also LGTM
—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/pull/11753#issuecomment-86159167.

—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/pull/11753#issuecomment-86159679.


Add an option to support plain TCP

The input lumberjack allow us to disable SSL and the output should expose similar option.

Elastic recommends logstash/lumberjack out to logstash/beats input.
The logstash/lumberjack input is deprecated.
Why does logstash/lumberjack out require ssl_cert? (It fails if that field is not efined)
The logstash beats/input does have an ssl_cert and ssl_key and ssl_verify:: none
A filebeat to logstash/beats input does not need an ssl_cert.
In my case, there is trouble distributing the lumberjack.crt (poor PKI infa).


Mended typos in README.md

Mainly just a test for github forking.
Figured the first headline in a project should try to stay typo free.

Looks good, thanks!


workers no longer copied to _workers: issue tracker

this tracks issues related to 6c6fa22f3290b5f4372ba10ea2e4a552c4401741

if there  are no issues this can be closed;-)


Valhalla instance not starting after builder finishes

Hi,
I am trying to set up the operator and instances, and get stuck after building has completed.
The last log message of the builder is:
[INFO] Finished with 87683 nodes
and I would expect a Valhalla pod to start up afterwards, but nothing happens.
Running kubectl get all -n valhalla-system returns the following, showing no indication of a Valhalla pod attempting to start up:
> kubectl get all -n valhalla-system
NAME                                              READY   STATUS    RESTARTS   AGE
pod/valhalla-builder-gv98m                        1/1     Running   0          5m12s
pod/valhalla-controller-manager-775677bc4-zlr9b   2/2     Running   0          6m22s

NAME                                                  TYPE        CLUSTER-IP    EXTERNAL-IP   PORT(S)    AGE
service/valhalla-controller-manager-metrics-service   ClusterIP   <IP_ADDRESS>   <none>        8443/TCP   6m23s

NAME                                          READY   UP-TO-DATE   AVAILABLE   AGE
deployment.apps/valhalla-controller-manager   1/1     1            1           6m23s

NAME                                                    DESIRED   CURRENT   READY   AGE
replicaset.apps/valhalla-controller-manager-775677bc4   1         1         1       6m23s

NAME                         COMPLETIONS   DURATION   AGE
job.batch/valhalla-builder   0/1           5m12s      5m12s
>

I am running the latest version of the operator (1.4.0), on Azure Kubernets Service (AKS) version 1.25.6.
The StorageClass I am using is "Azure File CSI standard" with retain policy and "ReadWriteMany".
Neither the operator nor the builder are showing any errors.
Is there anything I can do to solve this or debug the issue?

Let's move the discussion to #81, closing this one.


Make PrimaryKey option work with Java and Kotlin

Since Java and Kotlin use annotation to define PrimaryKey in model, I had updated the appendAttributes() to support these language.

Will merge it as soon as possible.
Thanks for your contribution.


remove PartialEq from GdalError

[x] I agree to follow the project's code of conduct.
[x] I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

bors r+


Runs DB integration tests on github action

Describe your changes and why you are making these changes
This PR runs the DB integration tests on Github Actions when there are relevant changes.
Test:

Tested this out by triggering a DB integration test action with a temporary change. See results here.

Related issue number (if any)
ENG 1428
Loom demo (if any)
Checklist before requesting a review

[x] I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
[x] I have performed a self-review of my code.
[ ] I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
[ ] If this is a new feature, I have added unit tests and integration tests.
[ ] I have run the integration tests locally and they are passing.
[x] I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
[ ] All features on the UI continue to work correctly.
[x] Added one of the following CI labels:

run_integration_test: Runs integration tests
skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

I think the link just leads to the Fast Integration Test runs. I don't think I see the DB integration test run.

@eunice-chan Updated the link


PoE for the camera - only 48V passive, or will 802.3af work?

Looking up the part number for the PoE injector (tp-dcdc-2usb-48), it appears that it outputs Passive PoE, not active.
Is there any information on the PoE requirements of the camera?  I'm curious if it will also work with standard (active) PoE.
Once I get my hands on one of the cameras, I suppose it's easy enough to test -- the injector/switch won't send power if the device isn't requesting it, after all!  :)  But figures it doesn't hurt to ask, and once an answer is known, to get it documented somewhere.

I just tested this out - and can confirm that standards-complaint 802.3at switch won't power the camera. Need Passive POE.
This can be closed.


deepsource issues

Fixes Issue. Ex: Fixes #20
Description
JS-0105(3 lines) : Class methods should utilize this
JS-0331(2 lines) : Found explicit type declarations
Screenshots

Please review the compilation. It has failed.
On the other hand, I had not noticed the description of the issue “JS-0105”, does it really make sense in this case?

i do understand the error with using static but im not entirely sure about the correct solution. would it be okay if it just push J-0331?

i do understand the error with using static but im not entirely sure about the correct solution. would it be okay if it just push J-0331?

Yes, I'm not sure what the solution would be either.
Let's leave it at that, it's fine.
Thanks @weshaan 👍


Fix Python broken proactive example to use CONFIG instead of SETTINGS

Proposed Changes
The example didn't work because SETTINGS variable didn't exist in the current context (used to in previous versions of repo).
Updated the example to use CONFIG instead. Also changed app_id to uppercase APP_ID because that's what's defined in the config.

@tracyboehrer hi! this is a tiny followup to your latest commit in the python sample. please review :)


Support for specifying HTTP headers in scrape configs

Proposal
Yes, I know that there are 3 separate closed issues regarding this feature. However I have a use-case, which adds some extra icing to this cake:
The official advice to add extra headers to a scrape request is to use a small proxy server, which handles this task.
My problem is, that in a complex dockerized environment when the proxy server becomes unavailable for some unfortunate reasons, Prometheus gladly reports that the backend service is down.  (The "up" metrics became 0 if the scraper can't access the target URL, which in this case the proxy url and not the "real" one.) Thus one cannot check the availability of the target service, just the availability of the target service AND the proxy service together.
IMHO adding headers to a request is neither requires a huge programming effort, nor it is a cpu-consuming runtime taks.
The scraper config already has username/password setting capability, which uses standard Authorization header, so technically speaking it is already there in the source code...
I think using a workaround as the official solution and maintaining a separate proxy server and keeping its config in sync with the prometheus config just because prometheus lacks this arbitrary header setting feature is a bit messy practice, violates the KISS and SSOT system design paradigms.

https://github.com/prometheus/prometheus/issues/1724

There is an open PR for this in prometheus common but no real interest. Please share your feedback on the pr

https://github.com/prometheus/common/pull/416

Thanks, actually, because you referenced #416 here, this issue automatically appeared on the timeline of #416, so I think I have nothing left to do. :)
I just add some additional related issues I found meanwhile:
https://discuss.prometheus.io/t/http-host-header-in-scrape-target/1214
https://github.com/prometheus/prometheus/pull/13009
(These two are closely related to each other as well, they both about setting the "Host" header, which is a fairly common problem.)

My Prometheus 2.53.1 have a http_headers field with null value. I don't see anything in source code or documentation about it. Anybody know how-to use it (possibility)?
My current scrape configuration is:
- job_name: prometheus
  scheme: https
  http_headers: null         <----- what is this?
  relabel_configs:
  - regex: __address__
    replacement: nb_fqdn
    action: labelmap
  - source_labels: [__address__]
    regex: ^(.*)(.example.local)$
    target_label: __address__
    replacement: $1.observability.example.com
    action: replace

What I want, is remove DNS dependency. From HTTP SD we already have IP address and 'Host' header to make a proper HTTP query. Something like
- job_name: prometheus
  scheme: https
  relabel_configs:
  - regex: __address__
    replacement: nb_fqdn
    action: labelmap
  - source_labels: [__address__]
    regex: ^(.*)(.example.local)$
    target_label: __http_header_host__
    replacement: $1.observability.example.com
    action: replace
  - source_labels: [__meta_netbox_primary_ip]
    regex: (.*)
    target_label: __address__
    replacement: $1
    action: replace

a http_headers field with null value

Perhaps fixed by https://github.com/prometheus/common/pull/655.
@k0ste please open a new issue for your separate request about relabeling.

I think I have nothing left to do.

@gviczai can this issue be closed then?

Thank you, it works for me (http_headers).
@k0ste here is an example:
  - job_name: 'my-job'
    scheme: https
    metrics_path: '/metrics'
    http_headers:
      my-custom-header:
        values:
          - 'my-header-value'
    static_configs:
    - targets:
      - 'myservice.com:443'


Add russian language to layouts.

Add russian language to layouts.

Coverage remained the same at 5.0% when pulling 2e5a4781c6706148c6aed3ad1d0e45c714ce6a35 on vvxcoder:master into a50a2e218d30e1edc06e0db1c930ac62afd1ae47 on icebob:master.


Are Amap tools(e.g. Amap.MouseTool)  available?

If they are, Could you add a demo to explain how to use them?
Anyway, thank for sharing your code. it helps a lot.

@noob9527 Sure, you can use it after (ready) events emitted. Here is an example:
import { Component, OnInit } from '@angular/core';

declare const AMap: any;

@Component({
  selector: 'app-demo',
  template: '<ngx-amap class="demo-map" (ready)="onMapReady($event)"></ngx-amap>'
})
export class DemoComponent implements OnInit {

  constructor() { }

  ngOnInit() {
  }

  onMapReady(map: any) {
    map.plugin(['AMap.MouseTool'], () => {
      let mouseTool = new AMap.MouseTool(map);
      mouseTool.rectZoomIn({
        strokeStyle: 'dashed',
        strokeColor: '#FF33FF',
        fillColor: '#FF99FF',
        fillOpacity: 0.5,
        strokeOpacity: 1,
        strokeWeight: 2
      });
    });
  }
}

thanks for replying,
I've already written a service to make use of it. see #14


Provide a way to disable cipher suites filtering

Expected behavior
There should be a way to have client side SslContext work against any website, regardless of security.
Actual behavior
Supported ciphers are filtered against a hard coded whitelist (SslUtils#DEFAULT_CIPHER_SUITES).
I wonder if the whitelist way is a good thing. Wouldn't it filter out modern ciphers that would be introduced in JDK updates? Properly maintaining this blacklist would require Netty core devs to frequently update it. Wouldn't a blacklist work better: ban ciphers that are known as unsecure?
Then, my core issue is that there's no way to disable this security. On the client side, sometimes security is not the top most priority and users just want things to work, all the more as they do work with all the other user agents around (browsers, curl, Apache HttpComponents). Typical examples are load tests and web crawlers.
Steps to reproduce
For example, it's not possible to connect to "https://www.gretalr.com" with a JdkSslHandler while it's possible with any other user agent I know of (reported against AHC as https://github.com/AsyncHttpClient/async-http-client/issues/1510).
Minimal yet complete reproducer code (or URL to code)
EventLoopGroup eventLoopGroup = new NioEventLoopGroup();
final SslContext sslContext = SslContextBuilder.forClient().build();
final CountDownLatch latch = new CountDownLatch(1);

Bootstrap b = new Bootstrap()
        .group(eventLoopGroup)
        .channel(NioSocketChannel.class)
        .handler(new ChannelInitializer<NioSocketChannel>() {
          @Override
          protected void initChannel(NioSocketChannel nioSocketChannel) {
            SSLEngine sslEngine = sslContext.newEngine(nioSocketChannel.alloc(), "www.gretalr.com", 443);
            SslHandler sslHandler = new SslHandler(sslEngine);
            sslHandler.handshakeFuture().addListener(whenHandshaked -> {
              if (whenHandshaked.isSuccess()) {
                System.out.println("All good");
              } else {
                whenHandshaked.cause().printStackTrace();
              }
              latch.countDown();
            });
            nioSocketChannel.pipeline().addLast(sslHandler);
          }
        });
Channel channel = b.connect("www.gretalr.com", 443).sync().channel();
latch.await();
channel.close();
eventLoopGroup.shutdownGracefully();

Note: I can connect fine if I create the SSLEngine from  a javax.net.ssl.SSLContext instead.
Netty version
4.1.20.Final
JVM version (e.g. java -version)
1.8.0_152
OS version (e.g. uname -a)
not relevant

So actually, a way better way to implement this would be to have a CipherSuiteFilter that, on contrary to IdentityCipherSuiteFilter, falls back to supportedCiphers instead of defaultCiphers when ciphers is null (ie when user didn't explicitly pass a set of ciphers).
It would be more convenient than having users duplicate Netty code for computing supportedCiphers for both JDK and OpenSSL providers and explicitly pass them.
@normanmaurer Does it make sense? Should I do a PR for this? Or am I wrong?

Yes this should be achievable via a CipherSuiteFilter. I don't think we should change the current behavior of IdentityCipherSuiteFilter, but what about creation of a new filter with this new behavior?

Yes, that's exactly what I meant. Sorry if I wasn't clear...

Sure. It doesn't have to be part of Netty, but if you think it is useful for others then feel free to submit a PR.

Will do later tonight

Fixed by https://github.com/netty/netty/pull/7691


Converting existing angular project to ssr

@rijine  please fill the PR information about what it's exactly your problem and how the community can help you


Thanks for this interesting feed back, always a pleasure to read constructive comment ! :)


Wrapping long lines of code

Heya,
Thanks for the work on code-prettify!  Is there a way to instruct that long lines of code should be wrapped?
In this long line example you can see it does not...

you can do that using css
pre.prettyprint {
	white-space: pre-wrap;
}

Works a treat; thanks!


Checksum release archives

Is your feature request related to a problem? Please describe.
For now it is necessary to compute manually the sha256 for each release. For instance when updating a spack recipe.
Describe the solution you'd like
Produce the checksum at release step (for example using a github actions like this one: https://github.com/wangzuo/action-release-checksums)
Describe alternatives you've considered
compute manually shasum -a 256 fesapi-2.xxx at each new release
Additional context
n.a.

I do not really like to rely on non official github actions but I agree with the request.
If I can easily do it by myself (is it not jsut one command down the road?), this would be awesome. I'll look at it when time permits.

I just manually added some checksums to <IP_ADDRESS> to check if this fullfills your need : https://github.com/F2I-Consulting/fesapi/releases/tag/v<IP_ADDRESS>

is it not jsut one command down the road?

Yes it should.
It is ok for me. Could it be done for fespp too ?
Thank you @philippeVerney

Could it be done for fespp too ?

DONE https://github.com/F2I-Consulting/fespp/releases/tag/v3.2.0

Very interesting and related discussion : https://github.com/orgs/community/discussions/46034
I don' think it changes our plan but it is clearly important to have it in mind.

Thanks @philippeVerney, the blog post is also interesting.


[Minecraft Forge]

Hello folks,
I do not get ahead because I hang on one thing in my project for a relatively long time.
I want to create an event which gets fired when I dismount from my horse.
My "HorseEvent"-Class:
`public class HorseEvent extends EntityEvent {
/*
 * EntityHorse being used for the event
 * examples: mounting/dismounting , feeding , giving a saddle
 */
public final EntityHorse entity;

/**
 * Creates a new event for an EntityHorse.
 *
 * @param entityHorse The EntityHorse for this event
 */
public HorseEvent ( EntityHorse entityHorse ) {

	super ( entityHorse );
	this.entity = entityHorse;

}

}`
My "HorseDismountEvent"-Class:
`/**

Event that is fired whenever a player dismounts his horse.
*/
@Cancelable
public class HorseDismountEvent extends HorseEvent {
/*

The player dismounting the horse.
*/
public final EntityPlayer player;

/**

Creates a new event for EntityHorse dismounted by a player.

@param entityHorse The EntityHorse being dismounted.

@param player The Player dismounting the horse.
*/
public HorseDismountEvent ( EntityHorse entityHorse , EntityPlayer player ) {
super ( entityHorse );
this.player = player;
System.out.println( "Calling HorseDismountEvent" );
ItemTossEvent event;

}

}`
My concrete problem is that I don't know how to call the events and how to test if I dismount from the horse. I don't know either how to register this event.
For example:
The Forge-Class "ItemTossEvent":
`/**

Event that is fired whenever a player tosses (Q) an item or drag-n-drops a

stack of items outside the inventory GUI screens. Canceling the event will

stop the items from entering the world, but will not prevent them being

removed from the inventory - and thus removed from the system.
*/
@Cancelable
public class ItemTossEvent extends ItemEvent
{
/**

The player tossing the item.
*/
public final EntityPlayer player;

/**

Creates a new event for EntityItems tossed by a player.

@param entityItem The EntityItem being tossed.
@param player The player tossing the item.
*/
public ItemTossEvent(EntityItem entityItem, EntityPlayer player)
{
super(entityItem);
this.player = player;
}
}`

This class got no code which tests if the player tosses his item and I don't understand why this is working...
The Forge-Class "ItemEvent":
`/**

Base class for all EntityItem events. Contains a reference to the

EntityItem of interest. For most EntityItem events, there's little to no

additional useful data from the firing method that isn't already contained

within the EntityItem instance.
/
public class ItemEvent extends EntityEvent
{
/*

The relevant EntityItem for this event, already cast for you.
*/
public final EntityItem entityItem;

/**

Creates a new event for an EntityItem.

@param itemEntity The EntityItem for this event
*/
public ItemEvent(EntityItem itemEntity)
{
super(itemEntity);
this.entityItem = itemEntity;
}
}`

Thanks in advance, Lyras ;)
PS: S0rry f0r my b4d 3nglish

Either I'm too stupid to use the functions or they are incorrect.

Please explain the relevance to this project.

Öhm...
I don't know what to say.

I just clicked the "New Issue"-Button because I need help xP

Sorry, wrong project so I can't help you.


Relevant paper

Hi,
Thank you for organizing and sharing such valuable resources! I would like to recommend a paper titled Chain of Preference Optimization: Improving Chain-of-Thought Reasoning in LLMs for inclusion.   In this paper, we perform reasoning using the Tree of Thought (ToT) approach and distill these reasoning processes into the LLM's Chain of Thought (CoT). This method serves as a form of self-reflection & self-improvement , effectively improving the model's ability to handle complex reasoning tasks.
I hope you might consider adding this paper to your list of recommendations. Thank you!

merged


Fancyzones does not work with applications downloaded from the Microsoft Store.

Microsoft PowerToys version
v0.59.0
Running as admin

[ ] Yes

Area(s) with issue?
FancyZones
Steps to reproduce
You only need to use fancyzones with any application such as Whatsapp, Spotify or ToDo and it does not detect them. All of them must be downloaded from the Microsoft Store
✔ Expected Behavior
Dock the application to the window
❌ Actual Behavior
Does not do anything, fancyzones does not detect the type of application.
Other Software
No response

/bugreport

sorry, I uninstalled v59 and went back to v58 which did not have this error.

Another quick question then. Do you have "Show this window on all desktops" enabled on those apps?
/needinfo

Another quick question then. Do you have "Show this window on all desktops" enabled on those apps? /needinfo

yes, is that why it is not docking?

Another quick question then. Do you have "Show this window on all desktops" enabled on those apps? /needinfo

yes, is that why it is not docking?

Must be that. Simply unchecked it and Fancy Zones started working for the app. Checked it again and it stopped.

Found that code, introduced in v0.59.0
https://github.com/microsoft/PowerToys/blob/65df14036cd8c0c71dd3d08b2baac03fd4288d02/src/modules/fancyzones/FancyZonesLib/FancyZonesWindowProcessing.h#L22-L36

Another quick question then. Do you have "Show this window on all desktops" enabled on those apps? /needinfo

yes, is that why it is not docking?

Must be that. Simply unchecked it and Fancy Zones started working for the app. Checked it again and it stopped.

Another quick question then. Do you have "Show this window on all desktops" enabled on those apps? /needinfo

yes, is that why it is not docking?

Must be that. Simply unchecked it and Fancy Zones started working for the app. Checked it again and it stopped.

Another quick question then. Do you have "Show this window on all desktops" enabled on those apps? /needinfo

yes, is that why it is not docking?

Must be that. Simply unchecked it and Fancy Zones started working for the app. Checked it again and it stopped.

I would like to support you to check if it works, but I uninstalled v59 and I have to ask for support to the IT department to reinstall by policies, because I only have the company's PC. Anyway I need to use the "Show this window on all desktops" option, so I can't go back to v59. 😅

/dup of https://github.com/microsoft/PowerToys/issues/18657


Update to new version of fontdb

Sorry, but I do not accept dependency bump patches. And I had no plans in updating resvg anytime soon. Do you need a new resvg release with the new fontdb?

Do you need a new resvg release with the new fontdb?

Yes :)

Ok, I will make one soon.

Thank you!


Error when requesting for a lot of Array data on a single query.

When performing a select query on a database with big arrays, the channel created to receive the query results get a capacity overflow.
This is so because it eventually fails to read correctly the size of the array. It looks like the pointer is not correctly placed when reading arrays. (Fixing the size for a quick test returns the array values with 0's at the beginning, so all the values are shifted).
@Protryon

Could you give more details on how to reproduce? I.e. how many rows, how many arrays, what query?

This has been fixed.


Nitin/metadata config read

Config.rb and metadata.rb or metadata.json reader and http change for noauth support in http

These commits will also need to be updated with DCO signoff.  You can amend them with git flag -s or --signoff to do this automatically.


Fix checking if newline is needed before else in let-else statement

Fixes #5901

@rhysd I haven't had a chance to review this yet, but I wanted to see how your changes handle this case:
fn issue5901() {
    #[cfg(target_os = "linux")]
    // some comment between attr and let-else
    let Some(x) = foo() else { return; };
}

fn issue5901() {
    #[cfg(target_os = "linux")]
    /* some comment between attr and let-else */
    let Some(x) = foo() else { return; };
}

Thank you for the point. I'll try to add new test.

I confirmed that this fix didn't work for the comment between the attributes and let-else statement. I'll have a look whether it can be fixed.
 fn main() {
     #[cfg(target_os = "linux")]
     // this is test
-    let x = 42 else { todo!() };
+    let x = 42
+    else {
+        todo!()
+    };
 }

@rhysd thanks for taking a look 🙏🏼. Before you keep working on this I also want to point out that any change needs to be version gated since let-else support was released as stable and we can't break our formatting guarantees.

@ytmimi Thanks for the information. I'll check the documentation. And also, I may find a way to strip things before let correctly. I'll update this branch once I add more tests and the version gate.

@ytmimi I force-pushed the fix. I added more tests and v1 version gate as well. Is there any place to add tests for v1 formatting? Currently only v2 formatting is tested.

You should create a let_else_v2.rs test for this. See the Create test cases section of the Contributing guide for details on how to add configuration values to tests via comments.

@ytmimi Thank you for your review comments. I updated this branch to resolve them.

Preferred Version::Two to Version::One
Added test cases for both v1 and v2 formatting
Fixed calculating available space stripping things before let

@ytmimi Thank you for your review comments again. I addressed them.

Simplified checking if the else block can be single-lined
Preferred todo!() expression to return; statement
Imported more v1 test cases into let_else_v2.rs

As a last step I want to run our diff-check job, It should pass since the changes are version gated, but I still want to go through this process.


Unmarshal now supports a struct instead of only slice

Unmarshaling now works with a single struct as well. We used a slice before because in a previous specification it was possible to send multiple objects to the server.
However, we will clean up the marshalling in ticket #111
This resolves ticket #113 and also keeps in mind #112. From a clients perspective it would still be required to unmarshal into a slice because a server can send multiple objects inside a json.
For now both is supported. If there are multiple objects in a json and the target is a struct, the first entry will be unmarshalled into it, and the rest is ignored. After #111 we should check that too and output an error.

Hm, the travis build error seems weird.. The tests work only for tip and 1.4 version. But this makes no sense:
3.33s$ ginkgo -r --randomizeAllSpecs --randomizeSuites --failOnPending --trace --race --progress
Failed to run test suite!
	fork/exec /tmp/ginkgo230951662/jsonapi.test: no such file or directory
Ginkgo ran 1 suite in 3.310503106s
Test Suite Failed

ginkgo recently updated master, and changed exactly this behaviour. This error message is the bug I got before with symlink folders.

ok, rebased it on master. ginkgo dropped support for go older than 1.4

@wwwdata can I ask a clarification? Does the embedded struct need to satisfy UnmarshalIdentifier too?
I can correctly marshal a struct similar to this (StructA) and its embedded struct (StructB), but I get "could not set field 'StructB' map [...] had wrong type" error when unmarshalling:
type StructA struct {
	ID    string `json:"-"`
	Field1 string `jsonapi:"name=field-one"`
	FieldB StructB `jsonapi:"name=b-field"`
}

func (t StructA) GetID() string {
	return t.ID
}

func (t *StructA) SetID(id string) error {
	t.ID = id
	return nil
}

type StructB struct {
	A bool `jsonapi:"name=ba-field"`
	B bool `jsonapi:"name=bb-field"`
	C bool `jsonapi:"name=bc-field"`
}

I don't want to set StructB as a relation, shouldn't this be ok to embed my second struct like this?
Thanks,
al.

hm you want to have an "embedded" object without a relationship. I don't know if this is working with api2go. The jsonapi.org standard discourages you from doing so. Nothing get's embedded, everything has reference IDs. If you want to load a referenced struct within one request, it is in the included array.
Marshalling should just work, yes. Unmarshalling will not work because we do a lot of custom type-switching stuff. But maybe if we improve unmarshaling with #111 it will just work too. But apart form that, this is not how you make a clean api with the jsonapi standard.

@wwwdata thanks. Since jsonapi tells "Attributes may contain any valid JSON value." (http://jsonapi.org/format/#document-resource-object-attributes) I thought I could do embed such an object without the need of a reference. Will better read jsonapi specs, thanks ;)

you can always ask questions like that on the gitter channel. It's much easier to help you there! ;-) thx for using api2go!


Update documentation to include information about Event Grid subscriptions to $logs file creation

When $logs container log files are created do they trigger events such as BlobCreated for consumption by event grid and azure functions?
Reacting to and reading log files in real time once they are created would be possible if they did, but so far I cannot get event grid to fire for log file creation through the BlobCreated event with a filter of /blobServices/default/containers/$logs/. Can this be confirmed and the documentation updated to document whether or not this is possible, and how it might be done.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 30ebd39b-ae34-4988-5694-09acd19693e8
Version Independent ID: c36c476f-a7c3-1f68-7ef6-1a7e3664bbe1
Content: Azure Storage Analytics logging
Content Source: articles/storage/common/storage-analytics-logging.md
Service: storage
Sub-service: common
GitHub Login: @normesta
Microsoft Alias: normesta

Also see Azure/azure-functions-eventgrid-extension#40 for a related discussion.

@AGBrown Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

Thanks @AGBrown ! Sorry - the $logs container is not integrated with Event Grid. I've added a not to that article to clarify that. That change should appear live shortly. Thanks for raising the issue.

#please-close


"fishy" theme: Shorten path .foo to .f, not .

When the current path is /home/user/.config/doublecmd the prompt now reads /h/u/.c/doublecmd, not /h/u/./doublecmd as was the case. This matches what the Fish shell does.
Enclose the Perl snippet in single quotes instead of double quotes.

I've pushed a fix for the $HOME problem. See my comment on the outdated diff above for details.

:+1:


rkt: get name from ImageManifest

Currently we are relying on an optional field in the PodManifest to get
the images name and version when running rkt list because, since one
has been able to remove referenced images, there was no guarantee that
the ImageManifest in the cas would be available.
However, little did we know, there is a copy of the ImageManifest of the
pod in the pod's appinfo directory. This commit makes use of that.
Should close #1659.

Oh yeah. It even has tests. :)

LGTM

Good found @blixtra ! I will make the same change in the api service :)

LGTM except small nit

LGTM except a small nit. Also it would be helpful to have something like func (p *pod) GetImageManifestForApp() so the code can be reusable.

I've added a function func (p *pod) GetAppsImageManifests() which returns a map with key of type ACName and a value of ImageManifest. This fits in better with the other pod methods.

LGTM

@yifan-gu I'll have a look.


Deleting a Data Element greater then 1 level deep throughs and error

Describe the bug
Deleting a Data Element greater then 1 level deep throughs and error.
When the delete is completed and successful the redirect appears to fail and shows the page not found screen

Cannot reproduce


Enable DNSSEC on segs.io

For increased DNS security, configure DNSSEC on the nameservers and with the registrar. I figured this would be good to do after #12.

DNSSEC has been successfully enabled on segs.io post transfer (#12).


Nominate a bunch

A bit noisy due to our old disagreement: ts > js from day zero

I have to add new stuff such as validating and topping up accounts. Will merge this to prevent it from getting to big. Hopefully you are fine with my changes @shawntabrizi


Replace swagger-based QA client with fetch calls

Why was this change made?
Fixes #3262
This commit replaces the swagger-based QA client. Why?

the API specification is incomplete;
it's not clear there is a plan in place to keep the specification up to date; and
we only use a fraction of the QA API in the Sinopia editor

In short, it's to pay down technical debt. This commit otherwise retains the same interface for interacting with the QA API, returning a promise that resolves to the HTTP response.
How was this change tested?
CI
Which documentation and/or configurations were updated?
None

I'm quite against the lack of a shared and validatable contract about this API that is maintained by two entities.  I've recently worked with Lynette to get the API matching the swagger spec they are publishing. I think we should continue to use it.

@jcoyne 💬

I'm quite against the lack of a shared and validatable contract about this API that is maintained by two entities. I've recently worked with Lynette to get the API matching the swagger spec they are publishing. I think we should continue to use it.

After chatting with @justinlittman this morning, it seems the fetch-based approach is preferred at this time. Maybe a stand-up discussion is warranted.