Additional spaces appear between words in the main view

Newsboat version (copy the output of newsboat -v or the first line of git show):
newsboat 2.21.0 - https://newsboat.org/
Copyright (C) 2006-2015 Andreas Krennmair
Copyright (C) 2015-2020 Alexander Batischev
Copyright (C) 2006-2017 Newsbeuter contributors
Copyright (C) 2017-2020 Newsboat contributors
Newsboat is free software licensed under the MIT License. (Type `newsboat -vv' to see the full text.)
It bundles:

JSON for Modern C++ library, licensed under the MIT License: https://github.com/nlohmann/json
optional-lite library, licensed under the Boost Software License: https://github.com/martinmoene/optional-lite
expected-lite library, licensed under the Boost Software License: https://github.com/martinmoene/expected-lite

newsboat 2.21.0
System: Linux 5.4.67-1-MANJARO (x86_64)
Compiler: g++ 10.2.0
ncurses: ncurses 6.2.20200212 (compiled with 6.2)
libcurl: libcurl/7.72.0 OpenSSL/1.1.1h zlib/1.2.11 zstd/1.4.5 libidn2/2.3.0 libpsl/0.21.1 (+libidn2/2.3.0) libssh2/1.9.0 nghttp2/1.41.0 (compiled with 7.72.0)
SQLite: 3.33.0 (compiled with 3.33.0)
libxml2: compiled with 2.9.10
Config file (copy from ~/.newsboat/config or ~/.config/newsboat/config):
I do not have config files.

Steps to reproduce the issue:

Fetch feeds from ArXiv query api (atom format).

In the main view, some additional spaces appear between words.
(https://i.imgur.com/NeuDUBx.png)

They do not show in the abstract view.

Other info you think is relevant:
In the database, SELECT title from rss_item also gives the additional spaces.

Hi, thanks for a good report! Can you please give me a few ArXiv URLs where you're seeing this?
Also, what's an "abstract view"? Do you mean the web page corresponding to the article?

Sure. For example, https://arxiv.org/abs/2010.03900v1
By "abstract view" I mean the view entered by clicking Return, showing the detail of the article.
Sorry I don't know the correct name for this.
Actually, I just found the source of the additional spaces.

Fetch the xml file from say http://export.arxiv.org/api/query?search_query=cat:cond-mat.stat-mech&start=0&max_results=100&sortBy=lastUpdatedDate&sortOrder=descending
Open the file by an text editor.
I saw the additional spaces are from a newline and two spaces in the title field.
So I guess this behavior may be generated from parsing?

Thank you.

Thanks!

I guess this behavior may be generated from parsing?

Kind of. XML parser returns what it finds, and it's up to the application to decide what to do about it. Since the <title> tags don't have type attribute, we treat them as text, which implies we're free to do whatever we want to the whitespace (RFC 4287 §3.1.1). So we do something in the "item view" (what you called "abstract view"), but do nothing in the "item list".
I admit I'm baffled by the difference in behaviour. ItemListFormAction::item2formatted_line doesn't look too different from ItemViewFormAction::prepare; both of them use the same functions to format strings.
I reproduced with r2.21-52-g52da, and here's a copy of the feed so I can still reproduce later.

Great! Thanks for clarifying this.
Will this behavior be changed in the future?

I'll know when I figure out what causes it :)

I'll know when I figure out what causes it :)

Thank you!

I admit I'm baffled by the difference in behaviour. ItemListFormAction::item2formatted_line doesn't look too different from ItemViewFormAction::prepare; both of them use the same functions to format strings.

The "ItemView" uses utils::consolidate_whitespace() to remove duplicate spaces.
This can be seen in the following gdb backtrace:

The "ItemList" does not call any such function when formatting the article titles.

Ah. Thanks for figuring that out! I think we can call utils::consolidate_whitespace() from the ItemList then.


Brightness/gamma options

I noticed some users of the mod taking advantage of an edge-case where entering freecam while the player is in water causes a similar effect to Night Vision.
I'm not sure if #66 would have fixed this, but it might be useful to have a more official way of doing something similar.
This might be somewhat redundant, TBH.  I'd imagine most freecam users are aware of other mods that can control brightness. Even Mini HUD has a max-gamma toggle IIRC. But perhaps it'd be useful to be able to configure the brightness while in freecam mode separately from normal brightness?
Any thoughts on whether this is useful and how you'd expect it to work would be appreciated 👍

Done


[Command Consistency] Rules based Command Table analysis

Related to item #733. We already have a command table dump. It would be very useful if we analyzed the command table against certain rules that we want to enforce, or at least be alerted if there is an inconsistency. Some items might include:

name type arguments without completers
arguments in creates that have id_part=name and also have a completer
arguments missing help
arguments that use hard coded choice lists instead of reflecting on enums
arguments or commands missing help text

This would help greatly as we get into the polish stage, relying on the rules to identify inconsistencies instead of the manual and error prone process of reviewing packages.

Cleaning u old issues, reopen if this is still active.


Stop speaking after a one word

Briefly summarize your issue:
Everything is fine, until i test it, when alexa speaking she stop after a word, sometime she say complete word.
What is the expected behavior?
Speak complete answer
What behavior are you observing?
Stop speaking after one (few) word, the status always changing very fast, Alexa is currently idle! to Connecting, is that normal ?
Provide the steps to reproduce the issue, if applicable:
1. Launch the SampleApp
2. Wait for Authorization
3. Authorization is successful
   4)type t Enter
   5)Get Listening... message back on console
   6) Say question (what's time is it?)
   7) Immediately alexa stop speaking

Tell us about your environment:
Mac OS High Sierra
What version of the AVS Device SDK are you using?
  <1.12.1>

Tell us what hardware you're using:

[* ] Desktop / Laptop
[ ] Raspberry Pi
[ ] Other - tell us more:

Tell us about your OS (Type & version):

[ ] Linux
[* ] MacOS
[ ] Raspbian Stretch
[ ] Raspbian Jessy
[ ] Other - tell us more:

sorry, my bad
it's because i run more than one instance


Registered resources are being GC:ed

Hello,
I've discovered an issue where registered resources can be garbage collected if some time occurs between when they are being registered and Snapshot is taken.
For example:
Core.getGlobalContext().register(new Resource() {
    @Override
    public void beforeCheckpoint(Context<? extends Resource> context) throws Exception {
        System.out.println("beforeCheckpoint() invoked");
    }

    @Override
    public void afterRestore(Context<? extends Resource> context) throws Exception {
        System.out.println("afterCheckpoint() invoked");

    }
});

//try force gc
for (int i = 0; i < 10; i++) {
    System.gc();
}

try {
    Thread.sleep(10000);
} catch (InterruptedException e) {
    throw new RuntimeException(e);
}

//try force gc
for (int i = 0; i < 10; i++) {
    System.gc();
}

My assumption is that the WeakHashMap in ResourceWrapper will release the references since the strongRef is only set in the beforeCheckpoint method

Hello,
That's indeed correct that before checkpoint CRaC maintains only weak references to the resources. So CRaC itself does not prevent a registered object to be GCed. This was done intentionally to avoid the additional burden of deregistering Resources before losing all explicit links in user code.
In this case, if you want to be sure the Resource is notified, you can create a local variable that will prevent the Resource to be GCed.
In this case, org.crac is consistent with JDKs CRaC API. https://crac.github.io/openjdk-builds/javadoc/api/java.base/jdk/crac/package-summary.html
If you know a better solution that won't also require explicit Resource deregistration, please let me know.

Hello,
That's indeed correct that before checkpoint CRaC maintains only weak references to the resources. So CRaC itself does not prevent a registered object to be GCed. This was done intentionally to avoid the additional burden of deregistering Resources before losing all explicit links in user code.
In this case, if you want to be sure the Resource is notified, you can create a local variable that will prevent the Resource to be GCed.
In this case, org.crac is consistent with JDKs CRaC API. https://crac.github.io/openjdk-builds/javadoc/api/java.base/jdk/crac/package-summary.html
If you know a better solution that won't also require explicit Resource deregistration, please let me know.

Hey Anton, thanks for your reply.
I understand the concept but i think the current behavior is a bit risky as it "might" work or not work depending on what you do in between your registration and your checkpointing.
This can introduce issues where users will have a hard time finding the root cause as the behavior is nondeterministic. For example, it might work fine in tests where lots of dependencies are mocked but in a production environment a GC sweep might have cleared the resource.
I recon this will occur mostly if we register anonymous classes. We can force only anonymous classes to always be strong in  the ResourceWrapper, but that doesn't solve the deregistration you want to avoid.
Shouldn't deregistration be offered tho? Doesn't it offer more control versus weak references?
If i compare this to for example JavaScript event listeners in the browser: Regardless if they are anonymous functions or strong references it's up to the user to register/unregister them and thus the behavior is deterministic.

I suggest to update Context.register() javadoc a bit to explicitly mention that Context only holds a WeakRefernce. This doc already tells the same, but probably not as visible in an IDE


[desk_webview_window] The example program exits after a few seconds.

Description
The example program always exits after a few seconds. The console log says:
[ +749 ms] flutter: args: []
[+4598 ms] flutter: url: https://example.com/
[ +134 ms] flutter: args: [web_view_title_bar, 0]
[+7847 ms] flutter: evaluateJavaScript: null
[   +1 ms] flutter: evaluateJavaScript: {"name":"test","user_agent":"Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36 Edg/108.0.1462.54WebviewExample/1.0.0"}
[        ] flutter: evaluateJavaScript: 2
[   +4 ms] flutter: evaluateJavaScript: null
[        ] flutter: evaluateJavaScript: 2
[        ] flutter: evaluateJavaScript: "test"
[  +87 ms] Service protocol connection closed.
[        ] Lost connection to device.
[   +1 ms] DevFS: Deleting filesystem on the device (file:///C:/Users/ADMINI~1/AppData/Local/Temp/example3b6517d0/example/)
[ +266 ms] Ignored error while cleaning up DevFS: TimeoutException after 0:00:00.250000: Future not completed

Environment

Flutter Version: [v3.3.5]
OS: [Windows 10]
plugin: [desk_webview_window: 0.1.6]
IDE: VS Code

duplicated of https://github.com/MixinNetwork/flutter-plugins/issues/148
crashed by flutter engine. already fixed in flutter master channel.


Log source Instance Group: Install log agent button is not installing the required log agent to the machines and not able to proceed further

Describe the bug
while i try to add an instance group in log source and try to select the listed instances and click install agent, nothing is happening and the instances are not turning online. It stays offline and not able to proceed from there.
Expected Behavior
Install agent should install the agent on the machines and turn online to proceed
Current Behavior
Install agent is not installing the agent on ec2 machines
Reproduction Steps

Click instance groups under log sources
select instances and click "Install Agent"

Possible Solution
No response
Additional Information/Context
No response
Solution Version
(SO8025) - Centralized Logging with OpenSearch Solution. Template version workshop_v2.1.1
AWS Region. e.g., us-east-1
No response
Other information
Following the workshop "https://catalog.workshops.aws/centralized-logging-with-opensearch/en-US/ingest-logs-from-ec2"
please reach out to me on my alias<EMAIL_ADDRESS>

Thanks for your feedback, we are aware of this issue, reproducing now

Hi, base on test, this issue has been resolved. Please have a try again.
If you find this issue still exists, please reopen this one, thx.


Identify list of assay-agnostic file or metadata QA/QC checks that should be performed on all file or metadata of a given type.

Coordinate with @ilan-gold wrt images, some aspects of which are not assay-specific.
Is there a general test we can apply to fastq files, and if so, do we want to bother?
Is it sufficient to test compressed files for consistency?  What's the time cost of scanning large files at ingest time?
OME-TIFF validation is one of the subjects discussed with @ilan-gold


Show namespace and other names of definitions

Overview
Add the namespace of a definition along with a list of other names when
they exist. Construct these values from the list of names when decoding
the Definition JSON response.

Implementation notes / Loose ends

Currently definitions are always fetched by hash which in the screenshot resulted in the weird difference between clicking on + and getting plus, there's a separate effort to fetch definitions by name when possible.
Slightly related to the above; @runarorama could the backend use the bestName as the name of the term/type instead of an FQN?
To select the namespace, I pick the first name one that includes the suffix name, and chop off the suffix.
This doesn't seem like the perfect way to do this and perhaps this is something we can do on the backend instead to have a complete alignment of bestName and the associated namespace. What do you think @runarorama ?
I think my FQN module should likely be changed to a more general Names module that deals with FQNs, suffix names and namespaces in a more structured way; I could definitely benefit some pairing on a design for that.

(All of the items below should be handled separately from this PR)

@runarorama Got a few questions for you on this one when you have a moment :)


Use PHPDoc to typehint VultrClient properties

Description
Adds PHPDoc property typehints on the VultrClient class.  This doesn't affect any behavior but helps the IDE typehint what properties are available.
As a side note - if you required ^8.1 instead of ^8.0 you could use public readonly properties to accomplish the task a little cleaner/more type-safe (4ac77f8ff8f3ac78b280c53f6c33535104a10c56 - although not proposing this now as readonly properties were only added in 8.1)
Checklist:

[X] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[X] Have you linted your code locally prior to submission?
[X] Have you successfully ran tests with your changes locally?

@iggyvolz Thank you for your submission! We fully intend on getting everything up to standard with phpdoc. Just haven't gone through and done it all yet, as when I do work on this its mostly been completing the library itself, I do a little documentation as I go but not much yet. Once this gets towards a final release candidate you should see more of these quality of life things.
Again thank you for your submission and we will merge this in.

As a side note - if you required ^8.1 instead of ^8.0 you could use public readonly properties to accomplish the task a little cleaner/more type-safe (https://github.com/vultr/vultr-php/commit/4ac77f8ff8f3ac78b280c53f6c33535104a10c56 - although not proposing this now as readonly properties were only added in 8.1)

This is something we have contemplated with before moving on with the MAP method. The reasoning is because we wanna make this library usable to as many people as possible.
We have contemplated on supporting php7.4 in this endeavor but currently we will be sticking with 8.0+ support.
However, as the library matures the MAP method may be more clunky than its worth so moving this to private properties and having them statically typed is probably the way to go moving forward.
Thank you for taking interest in the project. Good luck have fun!


Fallback onto global .gitconfig if no user name/email specified

Summary of the new feature/enhancement
I have a multiroot (read: multi git repo) project and set the user name and email in my ~/.gitconfig, but I'm still getting this error You have selected profile UUU, but the repo RRR is not using user details from this profile. Do you want to apply the user dertails from profile UUU?
Proposed technical implementation details (optional)
The "current" user should be assess based on git config -l, thus, when running in a repo that does not have a user name/email configured, the global user should be used instead. And if it matches, this extension should not report the error

The way I am thinking of implementing this is when the user first opens a repo, if the repo does not have user config details, I will fall back to see if global .gitconfig has user details defined. If yes, I will create a profile with those details in the settings (if no other profiles have those details) and select it in the status bar (in a warning state). The reason to add it as a separate "Global" profile is to list it in a picker, allowing the user to pick it for other repositories.


Fix bin range default check.

Hi @olavolav ,
this PR contains a small fix for the evaluation of defaults for the bins_min and bins_max arguments. I noticed that, when explicitly setting them to 0, the histograms fallback to the min/max of the input series.
I changed the checks to explicitly check for None, to avoid 0 being mistakenly interpreted as "ranges not provided".

Perfect thank you!


migration to swift 3

please let me know of any feedback! Just ran through Xcode 8, migration tool.

There already is a Swift 3 branch here: https://github.com/suzuki-0000/SKPhotoBrowser/tree/swift3

@ArtisOracle thanks pull request. @madsb did for it and its already created.
please use it like
pod 'SKPhotoBrowser', :git => 'https://github.com/suzuki-0000/SKPhotoBrowser.git', :branch => 'swift3'

it's already done here


can't appear what i see in instruction

System Information (please complete the following information):

Model Builder or CLI Version:
Visual Studio Version (if applicable):

Describe the bug

On which page of the tutorial did you run into an issue (URL):
Clear description of the problem:

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

@ddaa12 Sorry you've run into this problem. Are you saying you don't see the "Add machine learning" in the right click menu?

Are you following the instructions here? Did you enable the feature?
Model Builder does not work on VB projects. If you are using a VB project you won't see the option to add machine learning.

@ddaa12 I don't have enough information to help solve this. Please look at our troubleshooting section for help and re-open if none of those work.
Thanks!


Change movie to Tutorial

Hello this  is my Trial please tell me  okay thanks.bye for now

Hello Alaa
You need to work on the last update for Ring
Your Ring branch is behind the current branch
And this commit include modifications to many files that are not related to the expected update
Greetings,
Mahmoud


Add list of critical services

I have a branch going to automatically generate stats on which services have tests, and make a line chart over time. I'm having a lot of fun with that so I'll keep at it.
Meanwhile, here is my list of critical services, for #1358.

Messages

:book:

:sparkles: Thanks for your contribution to Shields, @paulmelnikow!

  Generated by :no_entry_sign: dangerJS

Looks good, Is this list based on coverage or just a test file existing?

These don't have coverage or tests necessarily… yet… they are just services that in my subjective judgement are important. Hopefully this will guide the tests we prioritize.


Scope of submission "My mailbox"

Hello Microsoft Support team,
I am just going through the Microsoft Learn Extend Microsoft 365 – Fundamental learning path. On page Understand registration for Actionable Messages in Outlook, the scopes of the submission differ from the official documentation on Microsoft Docs. Microsoft Learn mentions an additional scope "My Mailbox".

My Mailbox
With this scope, the solution is only allowed to send to the user's mailbox that created the registration. This scope is typically used in the early stages of development, allowing the developer to test the Actionable Message in their own mailbox.
This scope requires no additional information, and is auto-approved.

Which source of information may needs to be updated? Microsoft Learn or Microsoft Docs?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b2eaf591-7ab8-e405-3366-94b46146be71
Version Independent ID: 2783a865-1195-02ed-e9c7-f5e40c6f9d56
Content: Actionable messages via email developer dashboard guide - Outlook Developer
Content Source: docs/actionable-messages/email-dev-dashboard.md
Product: outlook
Technology: o365-connectors
GitHub Login: @jasonjoh
Microsoft Alias: jasonjoh

The Learn article is outdated. The My Mailbox scope was removed as not needed. The Test Users scope can handle the same scenario. I'll send a pull request to the Learn docs to remove this.

I've updated the source for Learn. That should reflect on the site in the next few days.


Connection silently dropped when using Slack RTM API.

If you connect to Slack RTM API, as long as you don't write a message to the socket everything is fine. But the moment you write a message the connection is dropped and no callback gets called. You can check that the connection is effectively dropped because messages from Slack are no longer received and the connection status of the Slack bot appears as disconnected.
Here is an example project that reproduces the issue. It has an alternative implementation using https://github.com/daltoniam/Starscream to prove that this is an issue with this library.

Client frame masking was added in 1.0.2. Try updating to that version and let me know if it works 👍

This was fixed with PR you merged minutes ago. Thanks!


Nikto quick fix

Fixes nikto issue reported in https://github.com/DefectDojo/django-DefectDojo/issues/3268
The regex probably needs rework. This PR is to get a working nikto parser before the next release.

The flake8 may/will actually fail because of the regex (which sometimes work).

probably caused by this value in the problematic report:
<iplink><![CDATA[http://:/favicon.ico]]></iplink>
maybe include that in the unit tests xml file so if we refactor it in the future, we'll see if it still works with this (stupid) url?

I am actually not seeing any unit tests for nikto.

hmm no unit tests, then we should merge. Usually I try to but the data causing the bug in the unit test which then proves that it is fixed. and stays fixed.


[SPARK-35983][SQL] Allow from_json/to_json for map types where value types are day-time intervals

What changes were proposed in this pull request?

This PR fixes two issues. One is that to_json doesn't support map types where value types are day-time interval types like:
spark-sql> select to_json(map('a', interval '1 2:3:4' day to second));
21/07/06 14:53:58 ERROR SparkSQLDriver: Failed in [select to_json(map('a', interval '1 2:3:4' day to second))]
java.lang.RuntimeException: Failed to convert value<PHONE_NUMBER>0 (class of class java.lang.Long) with the type of DayTimeIntervalType(0,3) to JSON.

The other issue is that even if the issue of to_json is resolved, from_json doesn't support to convert day-time interval string to JSON. So the result of following query will be null.
spark-sql> select from_json(to_json(map('a', interval '1 2:3:4' day to second)), 'a interval day to second');
{"a":null}

Why are the changes needed?

There should be no reason why day-time intervals cannot used as map value types.
CalendarIntervalTypes can do it.
Does this PR introduce any user-facing change?

No.
How was this patch tested?

New tests.

Test build #140682 has started for PR 33225 at commit 96a5d61.

cc: @MaxGekk

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45193/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45193/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45193/

Test build #140682 has finished for PR 33225 at commit 96a5d61.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140682/


GraphQL Schema

Design the GraphQL Schema required for all the API interactions in Litmus Portal

Closing in favour of these PRs https://github.com/litmuschaos/litmus/pulls?page=1&q=is%3Apr+gql


Hebrew translation NPSP

NPSP should be translated into Hebrew. Tal Frankfurt is working on this.

NPSP Translations - https://powerofus.force.com/s/article/NPSP-and-Translation#ariaid-title3


Add support for dark theme via css

See repo https://www.antoniopelusi.com/posts/keyholder-desktop/

https://github.com/antoniopelusi/JavaFX-Dark-Theme


DO NOT MERGE: Pull request to hold feat/menu gameplay impact review

As @tabarra requested review of @GoatG33k's gameplay logic, here's a draft PR so I can use GitHub's review UI to apply inline comments.
Note that my review here primarily applies to gameplay code, i.e. the scripts/menu/ directory.

(Note: this PR was automatically marked as "merged" by GitHub)


[VS2017] MM_store_ps is undefined

So Line 227 in Vector.hpp is undefined however if I comment it out it will build but not run. I have installed DirectX SDK and I am using 2017 Visual studio so is it something that needs 2013/2012 to build? or am I being dumb?

It's probably something related to VS2017 as I've never seen that problem before.
I use VS 2015, but the project should work on older versions as well (provided you do some changes on the project settings).

thanks. Downloading VS 2015 now

Add #include <intrin.h> to Vector.hpp in VS2017.

including header emmintrin.h to Vector.hpp will fix this problem

The full release of visual studio 2017 has now fixed this problem. Thanks for all suggestions though, I kind of went out of the scene for a while.


[SPARK-44316][BUILD] Upgrade Jersey to 2.40

What changes were proposed in this pull request?
The pr aims to upgrade Jersey from 2.36 to 2.40.
Why are the changes needed?
1.This version adapts to ASM9.5, which is also used by Spark currently
Adopt ASM 9.5
2.Also fix some bugs, eg:
Fix possible NPE in netty client
Get media type fix
3.Security vulnerability fix:
CVE for dependency jackson-databind
4.Full Release Notes:
https://github.com/eclipse-ee4j/jersey/releases/tag/2.40
https://github.com/eclipse-ee4j/jersey/releases/tag/2.39
https://github.com/eclipse-ee4j/jersey/releases/tag/2.38
https://github.com/eclipse-ee4j/jersey/releases/tag/2.37
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.

Merged to master for Apache Spark 3.5.0.


Creating volume attachments

Description
Added helper method to be used by Server Profile and Server Profile Template to attach Volumes.
The method can create a Volume and attach it or just attach a already created Volume, just based on the information of volume_attachments property of oneview_server_profile resource or oneview_server_profile_template resource.
The tests about volume attachments are shared by oneview_server_profile and oneview_server_profile_template.
Issues Resolved
#309
Check List

[x] New functionality includes testing.

[x] All tests pass ($ rake test).
[ ] New resources and/or actions have are included in the matchers.rb and matchers_spec.

[x] New functionality has been documented in the README if applicable.

[x] New functionality has been thoroughly documented in examples (please include helpful comments).

[x] Changes documented in the CHANGELOG.

ok!
@tmiotto can you review, please?


Connecting multiple clients to Spitfire

I've managed to get a single javascript client connected to Spitfire. To get this to work I've followed a few samples, in all of these samples code such as this is present.
      Spitfire.OnDataChannelOpen += DataChannelOpen;
      Spitfire.OnDataChannelClose += SpitfireOnOnDataChannelClose;
      Spitfire.OnBufferAmountChange += SpitfireOnOnBufferAmountChange;
      Spitfire.OnDataMessage += HandleMessage;
      Spitfire.OnIceStateChange += IceStateChange;
      Spitfire.OnSuccessAnswer += OnSuccessAnswer;
      Spitfire.OnIceCandidate += SpitfireOnOnIceCandidate;

      //Gives your newly created peer connection the remote clients SDP
      Spitfire.SetOfferRequest(sdp);

      // .. //
      HandleMessage(string label, DataMessage msg)

The first part (when setting up event listeners) could be general for having multiple clients connected, but the line Spitfire.SetOfferRequest(sdp); seems to indicate that each instance of Spitfire can only handle one client.
Do I need to create a Spitfire instance for every client? Or how should I add multiple connections to one "peer" (the server).

Also, if its just one session per Spitfire instance, why do I need to provide a range of ports, wouldn't it be better to just set one port for each instance then?


Block type search functionality for LLM agentic interactions

A common LLM use case is probably 'find all samples containing data of type X' so to facilitate LLM API interactions, I suggest adding 'block_ids' or similar in the return to get_items() which outputs a list of block ids ['xrd', 'raman', ...]

This is a limitation of the underlying server API atm, but we can add it quite easily. I'll transfer the issue there and get something out soon.


Changing order of source blocks changes which gems are loaded from which source

When I have a Gemfile that looks like this:
source 'https://rubygems.org' do
  ruby '2.4.1'
  gem 'rails', '~> 5.1.2'
end

source "https://artifactory.umn.edu/artifactory/api/gems/asr-rubygems/" do
  gem "lastpassify"
end

Bundler tries to load minitest (sub-requirement of rails) from the second source server:
Gem::RemoteFetcher::FetchError: too many connection resets
<EMAIL_ADDRESS>
But, if I change the order of the two source statements, so the Gemfile looks like this:
source "https://artifactory.umn.edu/artifactory/api/gems/asr-rubygems/" do
  gem "lastpassify"
end

source 'https://rubygems.org' do
  ruby '2.4.1'
  gem 'rails', '~> 5.1.2'
end

...everything installs correctly, with minitest loading from rubygems.org
repro script.
Note that I am using our internal artifactory server as a source for one of the two gems, which would need to be changed to make this work for anyone outside our organization.

All I get is
Could not fetch specs from
https://artifactory.umn.edu/artifactory/api/gems/asr-rubygems/

ping @isen0011

This will be fixed in Bundler 2 by https://github.com/bundler/bundler/pull/5985, so I'm going to close this out. Thanks for reporting it!


⚠ gorzdrav.org has degraded performance

In 2458d90, gorzdrav.org (https://gorzdrav.org) experienced degraded performance:

HTTP code: 200
Response time: 3725 ms

Resolved: gorzdrav.org performance has improved in b30299a.


Slicing multiple data layers or band channels with different spatial resolutions

Is your feature request related to a problem?
To enable chipping/batching datasets with different spatial resolutions, each dataset (either an xarray.DataArray or xarray.Dataset) currently needs to be sliced separately in xbatcher v0.1.0. The key limitation is that xbatcher assumes every xarray.DataArray 'layer' to have the same resolution, and xbatcher.BatchGenerator would use xarray's .isel method to index and slice along the specified dimensions.
https://github.com/xarray-contrib/xbatcher/blob/72ce00f2b5c9af71f102c5e6543cef5a78e15e35/xbatcher/generators.py#L41-L43
However, this is not always the case, for example:

Sentinel-2's optical bands can be 10m, 20m or 60m in spatial resolution (unfortunately, people usually resample the 20m and 60m bands to 10m just to make it 'easy' to do chipping)
For super-resolution tasks, where a low spatial resolution image is passed through a model to produce a high spatial resolution image, there would be a need to create low resolution chips mapped to high resolution chips (e.g. https://github.com/carbonplan/cmip6-downscaling)

Describe the solution you'd like
Ideally, there would be:

A way to store multi-resolution datasets in a single datacube-like structure, while having each layer stacked in the same geographical (or n-dimensional space). This is something datatree might be able to handle, i.e. have each data layer with a different resolution be on a separate node of the datatree.

---- Sentinel-2 10m bands
|---            20m bands
|---            60m bands

From the multi-resolution data object, xbatcher would then need to have a way of slicing these multi-resolution datasets. Maybe DataTree.isel could work?

Describe alternatives you've considered
Keep xbatcher to be focused on xarray.DataArray and xarray.Dataset only (and not bring in xarray.DataTree). Users would then need to implement their own way of slicing multi-resolution datasets themselves in an ad-hoc way.
Additional context
There was some discussion before at https://github.com/microsoft/torchgeo/issues/279 about sampling in pixel/image units or coordinate reference system (CRS) units. If working with multi-resolution datasets though, sampling in pixel/images would require some math (e.g. 20 pixels for a 500m resolution grid would be 10 pixels for a 1000m resolution grid). The CRS based indexing method however, would require something like https://corteva.github.io/rioxarray/stable/rioxarray.html#rioxarray.raster_dataset.RasterDataset.clip_box.
Other references:

https://docs.xarray.dev/en/stable/generated/xarray.DataArray.interp.html

I just wanted to throw out Satpy's Scene.crop as an example of something very similar to this request. The meat of the logic is here:
https://github.com/pytroll/satpy/blob/a4417c69e77159413360860019c0d4e902694a30/satpy/scene.py#L712-L743
Basically Satpy uses the pyresample library's AreaDefinition and SwathDefinition objects to define the region/bounds and CRS of the data. These objects have the necessary logic to say "I have this lon/lat (or x/y) bounding box, what are the slicing indexes for your Area". We take care to grab the coarsest resolution AreaDefinition as our base reference for what the slices should be and then do the necessary arithmetic to the indexes to make them work for the finer resolutions. This way even if the bounding box/sub-region would result in tighter (more accurate) slices for the finer resolutions alone, we make all the resolutions cover the same geographic area so calculations can be done between the resolutions (i.e. our result is never half a coarse pixel).
This logic makes sense for most satellite-base sensors we work with (GOES-R ABI, VIIRS, etc). Other sensors like MODIS don't follow this nice even alignment of the pixels, but that is typically ignored for most of the imagery work we do:
https://www.icare.univ-lille.fr/modis-geolocation/

This is not an area I have all that much experience in but after carefully reading this issue, I have a straw man proposal to offer. Before I get to my proposal, I'll offer a few bits of perspective that may be useful to ground the discussion here.

As @weiji14 makes clear, the existing batch generator in Xbatcher is really built around the assumption that xobj.isel is sufficient for selecting batches. This works because DataArrays and Datasets do a fairly good job at enforcing alignment. I think there is clearly value in this approach and we should keep it.
Multi-resolution datasets (or more generally datasets that don't align to a single datasets coordinate system) should also be supported by Xbatcher when connected to Datatree objects but we will need some specific/opinionated adapters to make this work.

My thought is that to build a new batch generator class that works with DataTree objects but uses one part of the datatree as its reference for batching the others. I think could be quite similar to the concept @djhoese introduced with Satpy's scene.crop method.
Imagine if you had a class like this
class BboxBatchGenerator:
    def __init__(self, dt: DataTree, ref: str, input_dims, ...):
        ...

    def __iter__(self) -> Iterator[dt.Datatree]:
        ...

gen = BboxBatchGenerator(dt, ref='10m')

Under the hood, you may imagine using the existing Xbatcher generator for the reference dataset (e.g. 10m) then using a more complex selection method (e.g. .sel) to extract batches from subsequent datasets (e.g. 20m and 60m).
Underlying my proposal here is that I think we should be open to developing additional generators in Xbatcher. Today we have just BatchGenerator but supporting additional data models (e.g. datatree) or more complex batch indexing may necessitate new generators.

Just noting that there's a PR on upstreaming datatree into xarray at https://github.com/pydata/xarray/pull/7418. If/When that PR is merged and an new xarray release made, any code depending on datatree should use from xarray import DataTree instead of from datatree import DataTree.

Under the hood, you may imagine using the existing Xbatcher generator for the reference dataset (e.g. 10m) then using a more complex selection method (e.g. .sel) to extract batches from subsequent datasets (e.g. 20m and 60m).
Underlying my proposal here is that I think we should be open to developing additional generators in Xbatcher. Today we have just BatchGenerator but supporting additional data models (e.g. datatree) or more complex batch indexing may necessitate new generators.

The BboxBatchGenerator proposal sounds like a good plan. The current BatchGenerator is overloaded with many options, and from a user perspective, it might be cleaner to have a separate, dedicated class to handle multi-resolution DataTree objects.
From a developer/maintainer perspective, should this new BboxBatchGenerator be subclassed from BatchGenerator? Or will this just make generators.py way too complicated? Trying to think ahead on what's ideal if we'll have multiple ???BatchGenerators that each approach chip sampling a little differently.

Thanks @maxrjones for pointing me to that satpy <-> datatree integration thread at https://github.com/pytroll/satpy/issues/2352 started by @djhoese. If that design proposal goes ahead, it sounds like we might be able to let satpy handle the multi-resolution data fusion/stacking part into an xarray.DataTree structure, and let xbatcher focus on just the batch generation/slicing/cropping part. Or if we can find a way to integrate satpy and xbatcher more closely, @djhoese's suggestion of using Satpy's Scene.crop at https://github.com/xarray-contrib/xbatcher/issues/93#issuecomment-1243025054 might well something we can wrap around in BboxBatchGenerator (at least for the 2D case).
I'll have some time this week to experiment on how xbatcher might work with datatree, will open a PR once I get something working.

@weiji14 have you arrived at some function approach yet? Did datatree help you here?
For my use case, I am willing to resample all datasets to a resolution with a common divisor so that we can implement simpler/faster index logic with .isel instead of .sel (which would be much slower afaik).

Since datatree will be upstreamed to xarray (see https://github.com/pydata/xarray/issues/8572), it might be that things will get easier soon, but I don't know when. For your use case though, check out the datatree_slice_generator function I've implemented in the proof-of-concept PR at https://github.com/xarray-contrib/xbatcher/pull/171, it also relies on .isel, and might be good enough for basic use.

Since datatree will be upstreamed to xarray (see https://github.com/pydata/xarray/issues/8572), it might be that things will get easier soon, but I don't know when. For your use case though, check out the datatree_slice_generator function I've implemented in the proof-of-concept PR at https://github.com/xarray-contrib/xbatcher/pull/171, it also relies on .isel, and might be good enough for basic use.

Awesome, I'll take a look! Being able to support multiple resolutions both in space and time with this datatree approach is likely going to be the approach we take, but I have found the for loop/generator approach in xbatcher has been a bit slow and before I have actually relied on numpys as_strided using a map_block approach. However, chunks are likely not going to spatially align between different resolution datasets, so I'll have to think that through and implement a map_slices on coords approach.


[Feature Request]:  Button is not present in newsletter section

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
Button is not present in newsletter section
Use Case
Button is not present in newsletter section
Benefits
Button is not present in newsletter section
Add ScreenShots

Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[ ] I'm a SSOC'24 contributor
[X] I have starred the repository

@Damini2004 I really can't understand the issue ?? can u make it more clear 7 understandable

@apu52  Subscribe button is not present besides input field so its required to be present their.

Assign this issue to me. @apu52


add offset for query eth num and deeper block num

For ethereum modification, it is recommended to submit to deeper/frontier


Use vim.fn.shellescape() to escape the Nextest test filters

Revert "Merge pull request #52 from ErezAmihud/bugfix/windows-running-with-filter"

Use vim.fn.shellescape() to escape the Nextest test filters
This should be compatible with all shells on macOS, Linux, and Windows.
Fixes #53. Closes #54.

@ErezAmihud @realeinherjar can you test this branch on Windows and Fish respectively to confirm it resolves the issues you ran into? I'm hoping this is an actually cross-platform approach...

Yes #55 works!! :)

Awesome, thanks both of you for testing!


Write a Kotlin program to calculate the combination of n objects taken r at a time

Description
Write a Kotlin program to calculate the combination of n objects taken r at a time
Combination is a selection of objects from a group such that (unlike permutations) the order of selection does not matter. The number of combinations on n objects taken r at a time is given by the formula n!/(r!(n-r)!) = n(n-1)(n-2)...(n-r+1)/r!
Input  : 5, 2
Output : 10

How to contribute

Save the solution in program/CalculateTheCombinationOfNObjectsTakenRAtATime.kt file
Add CalculateTheCombinationOfNObjectsTakenRAtATime.kt file in calculate-the-combination-of-n-objects-taken-r-at-a-time folder

!assign

Hey @rahmat-dev,
This issue has been assigned to you for more than 15 days.
We are unassigning you from this issue.
If you are still interested in contributing to this issue, please get auto-assigned on the issue by commenting !assign again.
Thanks for your contributions :)

!assign


error occurred when run tt_split.py

Reading data
Train/test split
Number of trials: 20
Number of subjects: 4
Number of images: 4
Cleaning data
Traceback (most recent call last):
File "/data/dcyan/gazeNet/utils_lib/data_prep/tt_split.py", line 210, in
_data = np.load(d['fpath'])
File "/data/dcyan/anaconda3/envs/gazeNet/lib/python2.7/site-packages/numpy/lib/npyio.py", line 384, in load
fid = open(file, "rb")
IOError: [Errno 2] No such file or directory: '../../etdata/lund2013_npy/TH38_img_Europe_labelled_RA.npy'

Check issue #2. Might it be this is something that solves your problem?

Check issue #2. Might it be this is something that solves your problem?

Unable to solve it. After debugging for a long time, maybe your part of the code changed. Maybe could you please help upload the processed data "data.unpaired_clean.pkl" and "data.val_clean.pkl"

Hi there!
I'm experiencing the exact same problem and I'm unfortunately unable to debug this myself. Could you maybe look into that or upload the processed data like YanDongchao suggested?
Many thanks!

Hi there!
I'm experiencing the exact same problem and I'm unfortunately unable to debug this myself. Could you maybe look into that or upload the processed data like YanDongchao suggested?
Many thanks!

Hi!
I had the same problem but was able to run it after debugging. I was able to run it with Python 3.5 with minor changes to make it compatible from Python 2.7. The problem that the script has is with the path of the dataset, the original one is in line 133  fdir_mat = 'EyeMovementDetectorEvaluation/annotated_data/images' but in the repository the path has changed to EyeMovementDetectorEvaluation/annotated_data/originally uploaded data/images you have to change that line. To make it work correctly I have followed the following steps, I hope this helps you.
git clone https://github.com/r-zemblys/gazeNet.git
cd gazeNet
mkdir etdata
cd etdata
git clone https://github.com/richardandersson/EyeMovementDetectorEvaluation.git
cd ../utils_lib/data_prep

Now you need to change in line 133 from fdir_mat = 'EyeMovementDetectorEvaluation/annotated_data/images' to  fdir_mat = 'EyeMovementDetectorEvaluation/annotated_data/originally uploaded data/images'. If you run it in Python 3 you need to adapt the code.
Now you can run the script
 python tt_split.py --root=../../etdata

by changing the root path the script will store the files in the etdata folder and running it directly in the data_prep folder avoids the ETData module loading problem.
Finally, if you get an error in line 272 change it to
data_copy = data.copy()
for part in data_copy.keys():

PS: If after an error you run the code again it is important that you remove the gazeNet_data and lund2013_npy folders from the etdata folder or the script will throw an error.


npm start throw unhandled error event

I have followed the instruction. But when I do
npm start
it returns like this:

@0.0.1 start /home/albert/www/albertsamuel.me
node server.js --env=dev
events.js:141
throw er; // Unhandled 'error' event
^
Error: listen EADDRINUSE <IP_ADDRESS>:8000
at Object.exports._errnoException (util.js:907:11)
at exports._exceptionWithHostPort (util.js:930:20)
at Server._listen2 (net.js:1250:14)
at listen (net.js:1286:10)
at net.js:1395:9
at GetAddrInfoReqWrap.asyncCallback [as callback] (dns.js:64:16)
at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:83:10)
npm ERR! Linux 4.4.0-36-generic
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "start"
npm ERR! node v4.5.0
npm ERR! npm  v2.15.9
npm ERR! code ELIFECYCLE
npm ERR! @0.0.1 start: node server.js --env=dev
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the @0.0.1 start script 'node server.js --env=dev'.
npm ERR! This is most likely a problem with the  package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node server.js --env=dev
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!
npm ERR!     npm owner ls
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     /home/albert/www/albertsamuel.me/npm-debug.log

It seems there is an error in server.js file.

I have found that the problem is port 8000 is busy.
Seems that there is some process occupied that port, obviously this is not yeoman's issue.
Sorry about that.


Collect execution stats for PostgresSqlJdbcClient

Collect execution stats for PostgresSqlJdbcClient

I think we can do this by adding a binding annotation and provider
@Provides
@Singleton
@ForMetadataFactory
public static JdbcClient createJdbcClientWithStats(JdbcClient client)
{
    return new StatisticsAwareJdbcClient(client);
}

Then do
@Inject
public JdbcMetadataFactory(@ForMetadataFactory JdbcClient jdbcClient, JdbcMetadataConfig config)
{
    ...
}

@electrum Thanks to your comment, I enabled this for all connectors.
Here is an example output for postgresql connector (captured with presto-cli/target/presto-cli-314-SNAPSHOT-executable.jar --server http://<IP_ADDRESS>:52280 --execute 'select * from jmx.current."iprestosql.plugin.jdbc:name=postgresql,type=jdbcclient";' --output-format JSON | jq . ): https://gist.github.com/kokosing/41a958909b20262cba1c667ac0840fb5

btw, worth to notice:
  "getcolumns.time.alltime.avg": 10.671700698381878,
  "getcolumns.time.alltime.count": 1545,
  "getcolumns.time.alltime.max": 35.289265,

The "Do not call ..." commit message title is too long

Add ConnectorObjectNameGeneratorModule for this, so that the names are exported with a base name of presto.plugin.mysql (or similar) like we do for others.
I'm not sure why we have multiple copies of that. It can probably live in presto-plugin-toolkit, but we can clean that up later.

@electrum ping


[8.x] Adds datetime parsing to Request instance

What?
Allows to conveniently retrieve an input from the Request as a Carbon object (or DateTimeInterface). It uses the Date facade behind the scenes.
public function post(Requets $request)
{
    // ...

    $post->publish_at = $request->date('publish_at')->addHour()->startOfHour();

    $post->save();

    return back();
}

Why?
Because you can quickly get a lot of Carbon or Date calls to parse the date from the request, specially from different keys.
// Before
if ($date = $request->input('when')) {
    $date = Carbon::parse($datetime);
}

// After
$date = $request->date('when');

It supports for custom formats (otherwise it will try to parse it).
$timestamp = $request->date('when', 'U');

And also supports timezoning.
$timestamp = $request->date('when', 'U', 'America/Santiago');

Since the input can be null, it's easier to create defaults:
$now = $request->date('when', 'U') ?? now();

BC?
No, only additive.

This example is not very accurate:
if ($datetime = $request->input('when')) {
    $datetime = Carbon::parse($datetime);
}

It can already be written like this:
$datetime = Carbon::make($request->input('when'));

... which does not seem very bad.

This example is not very accurate:
if ($datetime = $request->input('when')) {
    $datetime = Carbon::parse($datetime);
}

It can already be written like this:
$datetime = Carbon::make($request->input('when'));

... which does not seem too bad to me.

Same case for collect(). Also, you're accounting the input is not null.

Same case for collect().

I'm not sure what you mean by this?

Also, you're accounting the input is not null.

That's not true. Carbon::make(null) returns null. It's different from Carbon::parse().

Just reworked it to return null if the datetime is invalid.

I like the idea as I needed this many times, but you should probably take care of few stuff.
First, not sure why the use of Date facade, when DateTime and/or Carbon classes are sufficient for this, IMHO. Also, Carbon throws an InvalidFormatException, which I think is more expressive than just catching all invalid argument exceptions. Likewise, createFromFormat will return false on failure, so this should also be taken care of as the typehint of your date() method is Carbon or null.

First, not sure why the use of Date facade when DateTime and/or Carbon classes are sufficient for this, IMHO

The developer may be using another library. Otherwise, the Date facade wouldn't exists. I'm just using what is available. Even $model->freshTimestamp() uses the Date facade behind the scenes.

Also, Carbon throws an InvalidFormatException, which I think is more expressive than just catching all invalid argument exceptions.

Same case as above. InvalidFormatException is exclusive to the Carbon library, as far as I know. Can't catch what doesn't exists, if it doesn't.

Likewise, createFromFormat will return false on failure, so this should also be taken care of as the typehint of your date() method is Carbon or null.

I would back to my original idea: if the format or the value to be formatted is invalid, throw an exception. It will return null only if the input is null or doesn't exists.

I would back to my original idea: if the format or the value to be formatted is invalid, throw an exception. It will return null only if the input is null or doesn't exists.

Yeah okay makes sense, if it can't be parsed by Carbon then should throw an exception just like Carbon would.

I would back to my original idea: if the format or the value to be formatted is invalid, throw an exception. It will return null only if the input is null or doesn't exists.

@DarkGhostHunter  I agree that this should be the behavior.

It's ready.

It's ready for review.

👍

I like the datetime parsing but I wish the function handled defaults better when the input isn't null.
// Old
$startDate = Carbon::parse(Request::input('from', Carbon::now()->subYears(5)))->format('Ymd');
$endDate = Carbon::parse(Request::input('to', $lastTradeDate))->format('Ymd');

// New
$startDate = Request::date('from', 'Ymd') ?? Carbon::now()->subYears(5)->format('Ymd');
$endDate = Request::date('to', 'Ymd') ?? Carbon::parse($lastTradeDate)->format('Ymd');

// Expected?
$startDate = Request::date('from', ['Ymd'], Carbon::now()->subYears(5));
$endDate = Request::date('to', ['Ymd', 'America/Santiago'], $lastTradeDate);
$otherDate = Request::date('other', ['Ymd', 'America/Santiago']);

I like this but I wish the function handled defaults better sans coalescing when the input isn't null so one could benefit more from the parsing upfront and I think the timezone is not needed in most cases so it could be optional in an array and use the param space for the default.
// Old
$startDate = Carbon::parse(Request::input('from', Carbon::now()->subYears(5)))->format('Ymd');
$endDate = Carbon::parse(Request::input('to', $lastTradeDate))->format('Ymd');

// New
$startDate = Request::date('from', 'Ymd') ?? Carbon::now()->subYears(5)->format('Ymd');
$endDate = Request::date('to', 'Ymd') ?? Carbon::parse($lastTradeDate)->format('Ymd');

// Expected?
$startDate = Request::date('from', ['Ymd'], Carbon::now()->subYears(5));
$endDate = Request::date('to', ['Ymd', 'America/Santiago'], $lastTradeDate);
$otherDate = Request::date('other', ['Ymd', 'America/Santiago']);
$anotherDate = Request::date('another', 'Ymd');


Disable more ign tool functionality on windows

This is needed to fix downstream colcon builds on windows.

Oh I just saw this PR, pushed a different fix in https://github.com/ignitionrobotics/ign-plugin/pull/38
I think we don't want to disable all of loader/src, right?

Oh I just saw this PR, pushed a different fix in #38
I think we don't want to disable all of loader/src, right?

the only thing in loader/src/CMakeLists.txt is adding the cmd subdirectory, so I just thought disabling it at the root would be more visible, but I'm fine with #38


ElNotification: define types for ElNotification close and closeAll.

Please make sure these boxes are checked before submitting your PR, thank you!

[x] Make sure you follow Element's contributing guide (中文 | English | Español | Français).
[x] Make sure you are merging your commits to dev branch.
[x] Add some descriptions and refer relative issues for you PR.

I already change code.Thanks for your review.

Wait，I still Can't see closeAll function in notification.d.ts at dev branch. Do I have something wrong ?
link:https://github.com/ElemeFE/element/blob/dev/types/notification.d.ts

declare module 'element-ui/types/notification' {
interface ElNotification {
/** Close the notification by id /
close(id: string, onClose?: Function): void
/* Close all notification */
closeAll(): void
}
}


Is it possible to add vendor directory?

Feature Request
Is your feature request related to a problem? Please describe:

Describe the feature you'd like:

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Optimization:

We've recently removed the vendor directory as cleanup (#122). Unless there's a strong reason, we don't intend to bring them back.


Text format is lost on event description

If you enter a multiline text as a description formatting is lost in event card display

Closed by https://github.com/kalisio/kCore/issues/117


Event name in calendar view

Is it possible to get event name in rectangular box instead of circle in calendar view.  Also how can I get day view in week box aligned horizontally to each other than  to each other as currently it's showing diagonally.
In the day view suppose you have 20 events to display and multiple event start time and end time class with each Other for example one event start at 9am and end at 6pm whereas other event start at 3pm and end at 11pm and you have 20 events like this than your day view doesn't have enough space to accommodate all hence the view is messed up.

Was this issue ever resolved?

now, It wasn't resolved. :(


I2C redirect twice freezes the micro:bit

With this example CODAL programme with the latest code in main, the second uBit.i2c.redirect() freezes the micro:bit (the "hi" message never scrolls):
#include "MicroBit.h"

MicroBit uBit;

int main() {
    uBit.init();

    uBit.i2c.redirect(uBit.io.P0, uBit.io.P1);
    uBit.i2c.redirect(uBit.io.P1, uBit.io.P0);  // <- This line causes the issue

    while (true) {
        uBit.display.scroll("hi");
        uBit.sleep(1000);
    }
}

Most interestingly, if BLE is enabled (just using the codal.ble.json file instead of codal.json) it throws a 020 out-of-memory error.

Thanks @microbit-carlos. Strange - I definitely tested that one! must be a regression... I'll look at it.

Thanks @microbit-carlos
I've now investigated this. The title of this issue is a bit misleading. In general case, the redirect() operation did operate correctly multiple times. However, there is an edge case where the redirect() code was getting itself into an infinitely deep recursive loop in conditions where a pin was being redirected to a peripheral to which it was already attached.
i.e. the following code would be fine, but the example above would not:
uBit.i2c.redirect(uBit.io.P0, uBit.io.P1);
uBit.i2c.redirect(uBit.io.P2 uBit.io.P3);
uBit.i2c.redirect(uBit.io.P0, uBit.io.P1);
uBit.i2c.redirect(uBit.io.P2 uBit.io.P3);

I've tracked this down to the NRF52Pin::disconnect() function.
It's now patched in master to address this issue:
https://github.com/lancaster-university/codal-core/commit/ca19454c022d5d27ee6810900b91c50e0dcbaf28
https://github.com/lancaster-university/codal-nrf52/commit/5fa1d16d6de6bd2848ae776e3039ce6bcad4e3e1

Damien has tested this and confirmed it's fixed 🎉

https://github.com/microbit-foundation/micropython-microbit-v2/issues/112#issuecomment-1548794240


Missing Facebook and Google+ buttons

Can't see anymore the buttons for Facebook and Google+ if selected

Not sure what you mean, I can still see both of them. Do a hard refresh maybe?

Ok, they doesn't work only if Adblock Plus for chrome is enabled

Huh, that's weird! I wonder how they block those…


Compatibility with KIRBY 2.2.1

We found this issue using the new kirby version:
Fatal error: Class 'Snippet' not found in …/site/fields/subpagelist/subpagelist.php on line 74
Will there be an update for 2.2.1?

Yes, there will be an update and I hope I can release it until tomorrow ;-)

Please checkout the develop branch to get the latest version of the plugin. It should work with Kirby 2.2. It would be nice if you could let me know if everything works as expected. After some more testing I will merge it to the master branch.
Greetings, Flo.

Thanks for the update. The new version in the dev-branch works fine except the title »Seiten/Page«.

thanks @flokosiol for the fix!


Revise risks, barriers

Could probably have more here, but at least up-to-date
severs link between impact barriers and management risks, which should not be confused

Very good.


stop audio when leaving current page

Hello,
this is a potential fix for this issue: https://github.com/flogy/gatsby-mdx-tts/issues/15
It simply stops the audio playback on unmount.

Perfect, thank you for your pull request!


DM-2 missing data

DM-2 missing some data.
Core landing: OCISLY
Dragon serial: C206
Dragon crew: 2 (launch['crew'])
https://reddit.com/r/spacex/comments/fjf6rr/dm2_launch_campaign_thread/

Mostly updated. Crew info was a bit of an afterthought back in v3, and will only be available in v4, which should be live before this launch.


Replace scrapers functionality with tasks using prometheus.scrape

as a user
when i create and configure a scraper
then i would like a task created to actually scrape the data
so now that flux has the prometheus.scrape endpoint, we can replace the existing scraper functionality with Flux tasks.
Example Flux:
import "experimental/prometheus"

option task = {name: "Flux Scrape Data", every: 5s}

prometheus.scrape(url: "http://localhost:9999/metrics")
	|> map(fn: (r) =>
		({r with scrape_interval: string(v: task.every)}))
	|> to(bucket: "flux_scrape_data", org: "influxdata")

and updated template dashboard:
influxdb_2.0_oss_metrics_update.json.zip

@SnoozeThis https://github.com/influxdata/influxdb/issues/15445

I would wait until https://github.com/influxdata/influxdb/issues/15445 is closed and then add a comment. But an error occurred while snoozing: You can't block an issue on itself.

(https://snoozeth.is/GeqRPsE4D28) I will wait until https://github.com/influxdata/flux/issues/2076 is closed and then add a comment.

Resolved.


[BEAM-10567] Cherrypick #12765: Add LICENSE for pbr

(cherry picked from commit d48a4d6294a0a5db5ceae3ba79376abe412d0103)
This is impacting tests and building for the release branch.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run Python2_PVR_Flink PreCommit


Add GitHub Action to lint and test Python code

Test results: https://github.com/cclauss/baduk-id/actions
% pytest
============================= test session starts ==============================
platform linux -- Python 3.10.6, pytest-7.3.1, pluggy-1.0.0
rootdir: /home/runner/work/baduk-id/baduk-id
collected 7 items

tests/test_baduk_id.py .......                                           [100%]

============================== 7 passed in 0.23s ===============================

Great idea!
This is the first time I've heard of ruff - without a config file, is it actually checking anything?

https://beta.ruff.rs/docs/configuration says:

If left unspecified, Ruff's default configuration is equivalent to:

Some rules should really be ignored but with --select=ALL...
% ruff --exit-zero --select=ALL --statistics --target-version=py37 . | sort -k 2
 3	A001  	[ ] Variable `id` is shadowing a python builtin
 3	A002  	[ ] Argument `id` is shadowing a python builtin
15	ANN001	[ ] Missing type annotation for function argument `board`
 7	ANN101	[ ] Missing type annotation for `self` in method
16	ANN201	[ ] Missing return type annotation for public function `C`
 2	D100  	[ ] Missing docstring in public module
 2	D101  	[ ] Missing docstring in public class
 7	D102  	[ ] Missing docstring in public method
 9	D103  	[ ] Missing docstring in public function
 2	D104  	[ ] Missing docstring in public package
 1	EM102 	[ ] Exception must not use an f-string literal, assign to variable first
 7	ERA001	[*] Found commented-out code
 1	I001  	[*] Import block is un-sorted or un-formatted
 1	N802  	[ ] Function name `C` should be lowercase
 9	PT009 	[*] Use a regular `assert` instead of unittest-style `assertEqual`
 1	TRY003	[ ] Avoid specifying long messages outside the exception class
 1	W293  	[*] Blank line contains whitespace

Oh cool, I was kind of surprised it passed without changes, but the ALL output makes sense.  I'll take a look!


The processor properties field names aren't correct

Built with maven 3.3.9 and JDK 8.0.650.17, GeoEvent processor SDK from 10.3.1 install.

Funny thing is that I also saw that today when I am review it for 10.4.0.  I will put in a change in the next couple of days.  If you want it now, change every com.esri.geoevent.processor.serviceareacalculator-processor in ServiceAreaCalculatorDefinition.java to com.esri.geoevent.processor.service-area-calculator-processor, and then recompile.


Colors customization for arktype theme

Request a feature
the purple in the errors

is it possible to change that?
if not, could we have an option to do that?
🤷 Motivation
The library is awesome, the theme is awesome too
just wanted to tweak some things in the theme :)
💡 Solution

Thank you for the kind words 😊
I don't support customizations yet at a settings level, but you can override these in your own settings.json, e.g.:
  "workbench.colorCustomizations": {
    "errorForeground": "#bb3e3e",
    "errorLens.errorBackground": "#bb3e3e18",
    "errorLens.errorForeground": "#bb3e3ea0"
  },

To see the full list of settings from the theme, you can look at the theme file:
https://github.com/arktypeio/arktype/blob/bf85e7dec809169a7749c8e7af9003230e09b98f/ark/dark/arkdark.json
You should be able to override any of the other settings the same way.
If you'd like to contribute a built-in setting option to configure those core colors via theme variables, I haven't looked into how to do that yet, but would be happy to accept a PR!


Make track/id go straight to tab/id, skip best/id step

Done so now there is one fewer redirect request, but it is still slow since it must run

spotify api call
search to find named match
db/ug pull, to get the highest rated
db/ug pull to get actual tab


Some small style fixes

Fixes some style issues raised by SonarCloud

@matmair please fix conflicts here :)

@SchrodingersGat merge is in!


chore: update google-cloud-datastore from 1.107.1 to 2.2.1

Updates com.google.cloud:google-cloud-datastore from 1.107.1 to 2.2.1.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.google.cloud", artifactId = "google-cloud-datastore" } ]

labels: library-update, early-semver-major, semver-spec-major

Superseded by #126.


🐞 [Bug]: zmount tests are failing on the grid tests workflow

Is there an existing issue for this?

[X] I have searched the existing issues

which package/s did you face the problem with?
Dashboard
What happened?
The zmount tests are keep failing.
Steps To Reproduce
No response
which network/s did you face the problem on?
Dev
version
dev branch
Twin ID/s
No response
Node ID/s
No response
Farm ID/s
No response
Contract ID/s
No response
Relevant screenshots/screen records
https://github.com/threefoldtech/tfgrid-sdk-ts/runs/31240774792#r0s30
Relevant log output
.

@ramezsaeed please check if this test related issue or not.

@ramezsaeed please check if this test related issue or not.

I checked the tests, and all its doing is just calling the zmount module function and asserting the result, so the changes are coming from the module, not the tests.

Work in Progress (WIP):
checking jest returns values

Work Completed:
Refactor test cases

Work Completed:
Add function to get random number to validate z-mount size

Work Completed:
Add random ranges to check the min, max, and valid sizes.

verified and tests are now passing and working  fine

testcase


Logout failed from MVC4 Client + IdSrv4 Core App

Hi, I'm trying to build IdSrv4 Core app with ASP.NET MVC 4.5.2 CLient. I have successfully authenticated application but when i'm trying to Logout, it just showing logout uri in browser like- http://localhost:5000/account/logout?logoutId=8cf84cf3a3e34bbda15d4613ae5b48ea
In MVC Clients controller's logout action, added "Request.GetOwinContext().Authentication.SignOut();", in startup
if (n.ProtocolMessage.RequestType == OpenIdConnectRequestType.LogoutRequest)
{
var idTokenHint = n.OwinContext.Authentication.User.FindFirst("id_token").Value;
n.ProtocolMessage.IdTokenHint = idTokenHint;
}
i got the idTokenHint but I'm not able to Logout from application .
Thanks..

check the logs

I have checked the log it is showing "No endpoint entry found for request path: /account/logout"

Please check below Logs, It is giving error "Antiforgery token validation failed. The required antiforgery header value "RequestVerificationToken" is not present." is this the reason for not getting logout from application.

This sounds like UI issues from custom code. Do our out of the box UI samples work?

Thanks :)

If application on standby for 5 mins then i try to logout i got idtokenhint null and because of I'm not able to logout. I have added id_token in claims from SecurityTokenValidated. also tried using Request.GetOwinContext().Authentication.SignOut(new AuthenticationProperties { RedirectUri = ConfigHelper.GetConfigValue("MVCRedirectUrl") });
Please check logs-
2017-06-21 14:56:58.531 +05:30 [Information] Request starting HTTP/1.1 GET http://localhost:5000/connect/endsession?post_logout_redirect_uri=https%3a%2f%2flocalhost%3a44338%2fsignin-oidc
2017-06-21 14:56:58.570 +05:30 [Information] HttpContext.User merged via AutomaticAuthentication from authenticationScheme: "Identity.Application".
2017-06-21 14:56:58.573 +05:30 [Information] AuthenticationScheme: "Identity.Application" was successfully authenticated.
2017-06-21 14:56:58.576 +05:30 [Debug] Request path "/connect/endsession" matched to endpoint type EndSession
2017-06-21 14:56:58.577 +05:30 [Debug] Mapping found for endpoint: EndSession, creating handler: "IdentityServer4.Endpoints.EndSessionEndpoint"
2017-06-21 14:56:58.608 +05:30 [Information] Invoking IdentityServer endpoint: "IdentityServer4.Endpoints.EndSessionEndpoint" for "/connect/endsession"
2017-06-21 14:56:58.620 +05:30 [Information] AuthenticationScheme: "Identity.Application" was successfully authenticated.
2017-06-21 14:56:58.622 +05:30 [Debug] Processing signout request for "1638B9A0-6412-4862-B540-3770B91587B6"
2017-06-21 14:56:58.645 +05:30 [Debug] Start end session request validation
2017-06-21 14:56:58.690 +05:30 [Information] End session request validation success
"{
  \"SubjectId\": \"unknown\",
  \"Raw\": {
    \"post_logout_redirect_uri\": \"https://localhost:44338/signin-oidc\"
  }
}"
2017-06-21 14:56:58.692 +05:30 [Debug] Success validating end session request from null
2017-06-21 14:56:58.692 +05:30 [Verbose] Invoking result: "IdentityServer4.Endpoints.Results.EndSessionResult"
2017-06-21 14:56:58.722 +05:30 [Verbose] Purging stale cookie: "LogoutMessage.8b2d827386456146648f390d0d19d0f1"
2017-06-21 14:56:58.728 +05:30 [Verbose] Protecting message: "{\"Id\":\"aa398f779db35d033235a226d1505b22\",\"Created\":636336340186951786,\"Data\":{\"Parameters\":[{\"Key\":\"post_logout_redirect_uri\",\"Values\":[\"https://localhost:44338/signin-oidc\"]}],\"ShowSignoutPrompt\":true}}"
2017-06-21 14:56:58.732 +05:30 [Information] AuthenticationScheme: "Identity.Application" was successfully authenticated.
2017-06-21 14:56:58.736 +05:30 [Information] Request finished in 204.6141ms 302
2017-06-21 14:56:58.738 +05:30 [Information] Request starting HTTP/1.1 GET http://localhost:5000/account/logout?logoutId=aa398f779db35d033235a226d1505b22
2017-06-21 14:56:58.739 +05:30 [Information] HttpContext.User merged via AutomaticAuthentication from authenticationScheme: "Identity.Application".
2017-06-21 14:56:58.741 +05:30 [Information] AuthenticationScheme: "Identity.Application" was successfully authenticated.
2017-06-21 14:56:58.742 +05:30 [Verbose] No endpoint entry found for request path: "/account/logout"
2017-06-21 14:56:58.757 +05:30 [Information] Authorization was successful for user<EMAIL_ADDRESS>2017-06-21 14:56:58.851 +05:30 [Information] Executing action method "IdentityServer.Controllers.AccountController.LogOut (IdentityServer)" with arguments (["aa398f779db35d033235a226d1505b22"]) - ModelState is Valid
2017-06-21 14:57:00.024 +05:30 [Information] AuthenticationScheme: "Identity.Application" was successfully authenticated.
2017-06-21 14:57:00.035 +05:30 [Information] AuthenticationScheme: "Identity.Application" signed out.
2017-06-21 14:57:00.037 +05:30 [Information] AuthenticationScheme: "Identity.External" signed out.
2017-06-21 14:57:00.039 +05:30 [Information] AuthenticationScheme: "Identity.TwoFactorUserId" signed out.
2017-06-21 14:57:00.041 +05:30 [Information] User logged out.
2017-06-21 14:57:00.048 +05:30 [Information] AuthenticationScheme: "Identity.Application" was successfully authenticated.
2017-06-21 14:57:00.050 +05:30 [Information] AuthenticationScheme: "Identity.Application" was successfully authenticated.
2017-06-21 14:57:00.051 +05:30 [Information] AuthenticationScheme: "Identity.Application" was successfully authenticated.
2017-06-21 14:57:00.169 +05:30 [Information] Executed action "IdentityServer.Controllers.AccountController.LogOut (IdentityServer)" in 1424.6126ms
2017-06-21 14:57:00.510 +05:30 [Error] An unhandled exception has occurred while executing the request
System.ArgumentException: Value cannot be null or empty.
Parameter name: url
   at Microsoft.AspNetCore.Mvc.ControllerBase.Redirect(String url)
   at IdentityServer.Controllers.AccountController.<LogOut>d__11.MoveNext() in E:\Source\GP.RentalManager\Development\Sprint 0\Security\IdentityServer\src\IdentityServer\Controllers\AccountController.cs:line 153
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.<InvokeActionMethodAsync>d__27.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.<InvokeNextActionFilterAsync>d__25.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()


Move yield of metrics chunk after generation chunk

Move yield of metrics chunk after generation chunk

when using mistral and streaming is enabled,the final chunk includes a stop_reason. There is nothing to say this final chunk doesn't also include some generated text. The existing implementation would result in that final chunk never getting sent back
this update moves the yield of the metrics chunk after the generation chunk
also included a change to include invocation metrics for cohere models

Closes #215

@3coins, Need urgent help here as there is issue with the production deployment GenAI Chatbot for Government e market place. (https://github.com/ihmaws)has done deep dive on the issue and suggested few resolution. Can you look and please accept the PR.
Regards
Sanjay Tiwary

@ihmaws
One of integration tests is failing, can you verify if this passes for you, otherwise, update it.
======================================================= FAILURES ========================================================
__________________________________________________ test_bedrock_invoke __________________________________________________

chat = ChatBedrock(client=<botocore.client.BedrockRuntime object at 0x121fccd90>, region_name='us-west-2', model_id='anthropic.claude-3-sonnet-20240229-v1:0', model_kwargs={'temperature': 0})

    @pytest.mark.scheduled
    def test_bedrock_invoke(chat: ChatBedrock) -> None:
        """Test invoke tokens from ChatBedrock."""
        result = chat.invoke("I'm Pickle Rick", config=dict(tags=["foo"]))
        assert isinstance(result.content, str)
        assert "usage" in result.additional_kwargs
>       assert result.additional_kwargs["usage"]["prompt_tokens"] == 12
E       assert 13 == 12

tests/integration_tests/chat_models/test_bedrock.py:240: AssertionError

Use this to verify:
poetry run pytest tests/integration_tests/chat_models/test_bedrock.py -k "test_bedrock_invoke"

@ihmaws One of integration tests is failing, can you verify if this passes for you, otherwise, update it.

Interesting, I'm not seeing that test failure. Let me try and have a look. Can you also run the test one more time and confirm you've got the latest code?

Interesting, I'm not seeing that test failure. Let me try and have a look. Can you also run the test one more time and confirm you've got the latest code?

Let me try pulling in latest.


Manual installation

Is it possible to install it manually, without cocoapods?

Of course, you can always just copy the source files into your project dir.


Session Token Extensions

When a session token is in use, we should extend the time it is valid for. For example, if we have 24 hour session tokens, each time the token is used, refresh the time window to 24 hours from the time of that request.
This allows us to bring down the allowable time session tokens are valid for as well. Instead of 24 hours, make it 8 hours.
This may already be done in the core api, but I am filing this to make sure it gets taken care of.

This was incorrectly filed on the CLI repository.

Fixed via #16


Slight performance improvement for hpx::copy and hpx::move et.al.

this improves the detection of contiguous trivially copyable sequences
for which copy and move can fall back to memcpy
flyby: adding traits::is_contiguous_iterator
flyby: modernize transfer algorithm implementations

The sequential version gives me about 40% speedup when copying vector<>s of trivially copyable types.

Looks good to me! My only question is: would we be better off actually using memcpy for trivially copyable types (apologies if I missed it in these changes)?

We do use memmove here: https://github.com/STEllAR-GROUP/hpx/pull/5375/files#diff-f3ce576e728f2a80f45976bad564e6f3bcc59596662509a07a05f370c9b5db1dR91. We did use it before, just the detection logic was flawed. That is what this PR fixes, actually - I should have been more concise when describing the changes.


Code / comment cleanup and JSHint fixes.

I found quite a few instances where the code does just as good, or better a job at describing what it does than its corresponding comment. In many instances the comment is just noise. In some cases, variables were renamed to give them better meaning rather than relying on a comment to do the same thing.
JSHint violations were also fixed as part of this PR.
I also added a TODO to fix an issue where a callback isn't actually defined and commented out the call. If the code actually went down that path then there'd be a runtime error. Referenced in #4.
Happy to discuss these changes since changes like these can be somewhat subjective.
This also includes commits from #3.

Pardon the rather ironic misspelling in the branch name :P.


Implementation of dirty check for entity

#170

@dsnipe overall i am happy with the implementation
@jodosha love to hear your opinion on merging this feature or not

@joneslee85 done with fixes
will use #174 when merged

@joneslee85 I did rebase from master and used persisted? for checking
btw, did you seen my thoughts about timestamps realisation? What do you think?

@dsnipe @joneslee85 Thanks for taking care of this. My opinion is that we're recreating AM/AR in Lotus::Model. While I find dirty tracking, timestamps, #persisted? useful features I'd not enable them by default.
I'd consider a different approach that consist in different modules like Lotus::Entity::DirtyTracking. These modules can be plugged in where needed.
Because this approach would be verbose, we can have a single module to include Lotus::Entity::Persistence, which will inject the extra features. We already use this technique with Lotus::Helpers.
Likewise, this can be noisy too. My last suggestion is to introduce Lotus::Model::Configuration#prepare_entities, as a single place where to inject code for all the entities. We already use this for Controller and View.
The bottom line is: keep entities as simple as possible. This will guarantee speed for the default scenario. When more features are needed, devs can plug-in one module in one place and they are all set.
@dsnipe Can you please rework this as a module to inject after Lotus::Entity? Thank you very much for your effort.

@jodosha I had the same feeling about AM/AR, now I starting understand difference and your main idea. Thanks for the good explanation.
I'll create new module Lotus::Entity::DirtyTracking, which can be included by developers in configuration block in future, if they need it. Now I using persisted? method. As I understand it will be in separate module, so better not depend on it?

Now I using persisted? method. As I understand it will be in separate module, so better not depend on it?

Yes. You can safely check for .id truthiness. (if book.id instead of if book.persisted?).

@jodosha, @joneslee85
finished with module
can you review it? forgot to make rebase before push, will do it after review with fixes ;)

@dsnipe can you please rebase?

@joneslee85 done

@dsnipe you have a lot of tests failing, can you take a look?

@AlfonsoUceda yep, was bad rebase.
Now all green :)

:+1:

:+1:

@dsnipe Thank you, just merged :+1:


[iOS] add transintion to settingScreen

Issue

close #501

Overview (Required)

I applied the transition to SettingScreen only FavoritesScreen.
Regarding MediaSceen and HomeScreen, I'm going to implement other pull requests.

Links

Screenshot

Before
After

@Tech-Nayuta
Is it possible to add transition from HomeScreen & MediaScreen as well in this PR?
I think it's not gonna be big PR by adding HomeScreen & MediaScreen diffs.

@Tech-Nayuta
Is it possible to add transition from HomeScreen & MediaScreen as well in this PR?
I think it's not gonna be a big PR by adding HomeScreen & MediaScreen diffs.

OK. I'm going to setting transition from these as well.👍

@Tech-Nayuta
Please fix conflicts 🙏

@Tech-Nayuta
This branch seems to be broken. Please fix this.

I made a new pull request and branch.
Please check #538 !

I made a new branch and pull request.
Please check here. #539


Feature: GRBL control of microscope illumination

GRBL has support for 'spindles'. It would be nice to have support for this, for switching the microscope's lamp on and off.
Some GRBL builds have "variable speed spindle" support: with these, the lamp brightness could be varied.
My use case is to reduce the amount of hardware needed for my microscope setup and tidy it up.
Running everything off the same 12V supply as the RAMPS board and motors would be very convenient, especially as the RAMPS boards (being 3D printer boards) have two high-current switch outputs (normally used for the extruder and bed heater).
This could be as simple as turning the lamp on when Pyuscope starts, and turning it off when it exits. Brightness control (if needed) could be added later.

FYI there is a related test here: https://github.com/Labsmore/pyuscope-kitchen/blob/main/script/pick_place.py

Related ticket: https://github.com/Labsmore/pyuscope/issues/322

@philpem are you up to try this vs the new instrument subsystem plugin interface? Basically do this:

Create a script PoC that can turn the lamp on / off
Integrate that script as an instrument plugin

Sample that can actuate the spindle: https://github.com/Labsmore/pyuscope-kitchen/blob/main/script/pick_place.py
Once you test it, add an entry like this to your .pyuscope file:
    "instruments": {
        "illuminator": {
            "tab_name": "Illuminator",
            "visible": true,
            "plugin_path": "/home/mcmaster/doc/ext/pyuscope/uscope/script/test/instrument_simple.py",
        },
    },

Other: I'm not sure how graceful shutdown is if you close the whole window. But can test this out and improve it if its problematic

I believe this is done per above, but haven't heard back. Closing ticket, let me know if you need more info

Done using uscope/script/instrument/grbl_pwm.py

Hi John - sorry for the lack of response on this. I found out that my build of GRBL needs a little bit of work to turn on/off the outputs. I expect if you're sending the right G-code it'll just work. I need to find time to fix up GRBL but that's definitely a me-problem :D


Automatic notification on new organization user

When a new organization user is created, new notification is created (and an email is sent).
Open questions:

Both in organization signup and organization settings page? @saleiva
Can't this be disabled? I don't think that this should be broadcasted, for example, at universities. It's likely to be disabled by default, IMHO. @saleiva
What information does the notification contain? @saleiva
Design needed @saleiva

cc @xavijam

Notifications about account activation and charge codes are per user, not broadcasted to the whole organization.
cc @asimcox for clarifying the points about the content of notifications and emails themselves

yep. This has nothing to do with the notifications. Notifications are always broadcasted

Hi Gang - few comments:
UI Notifications - pls reference the client business and functional requirements in this client-facing BCG Repo ticket 60 and the Associated Design ticket.
To clarify, there are two types of UI Notifications:

Automated Notifications
@noguerol is correct. Automated notifications about "charge codes, account activation, account disabled, account extension' will only appear in a particular user's dashboard. (see ticket for all notification states/scenarios)

Manual Notifications (created and sent by the Admin)
These notifications will get broadcasted across the entire organization, depending on the group that Admin selected: All; Builder; Viewer.

Email Notifications - pls reference the client business and functional requirements in this client-facing BCG Repo ticket 57
let me know if you have more questions!

After talking to @asimcox , it's clear that manual notifications, the ones that are handled in this milestone (https://github.com/CartoDB/cartodb/milestone/136), do not trigger emails. Only "automatic notifications" do.

So, recapping:

Both in organization signup and organization settings page? I don't get this question
Can't this be disabled? No
What information does the notification contain? manual notifications are custom text with limited amount of characters (TBD by @CartoDB/design) and automated notifications are predefined, with copywriting provided by @asimcox
Design needed --> emails are handled by @CartoDB/solutions so I assume also their templates

The document says "(it) will send email notifications (...) When a new account is activated.". There's no such "account activation" within CARTO, so I assume that it's the same than "when a new organization account is created. You can create organizations accounts in two ways: organization settings (by the owner) and organization signup page (/signup), by the user. So, if a mail is meant to be sent on user creation, we should know in which of those scenarios. Pinging @danicarrion , as email notifications are on their side.
Ok.
My question was about the email, which I hadn't seen.
Ok (this also answers 3).


Plans are now cached before being processed.

Description
Persisted plans are now cached before being processed (wrapped in a Subquery plan node and, optionally, by an alias). This wrapping is posponed to look-up time.
Testing

Acceptance tests

:+1:

+1


Add slides

Can you move this into the DroneImageStitch folder? FYI, github is acting up today and not letting me accept the pull request right now.

I think it's merged now.  The slides are in the folder.

Oh, you mean move the Metashape folder into the DroneImageStitch folder?

Yes, so all the drone stuff is in the same folder.


Spectral_smooth does not work

Dear developer:
Recently, I tried smoothing my raw data cube in velocity axis with a Gaussian keneral using the function cube.spectral_smooth. However, I always received a error message. Below, I list my scripts and the associated error message after the code runs. Please help me out on how to solve this problem. Thank you very much in advance.
cube = sc.read('t13_reg1.fits')
fwhm_factor = np.sqrt(8*np.log(2))
current_resolution = 0.26569 * u.km/u.s
target_resolution = 0.5 * u.km/u.s
pixel_scale = 0.26569 * u.km/u.s
gaussian_width = ((target_resolution2 - current_resolution2)**0.5 /
pixel_scale / fwhm_factor)
kernel = Gaussian1DKernel(gaussian_width)
new_cube = cube.spectral_smooth(kernel)
---error message---
---> 10 new_cube = cube.spectral_smooth(kernel)
~/anaconda3/lib/python3.6/site-packages/spectral_cube/spectral_cube.py in spectral_smooth(self, kernel, convolve, verbose, use_memmap, num_cores, **kwargs)
2949                                                      use_memmap=use_memmap,
2950                                                      verbose=verbose,
-> 2951                                                      **kwargs)
2952
2953     def spectral_interpolate(self, spectral_grid,
~/anaconda3/lib/python3.6/site-packages/spectral_cube/spectral_cube.py in apply_function_parallel_spectral(self, function, num_cores, verbose, use_memmap, parallel, **kwargs)
2882                                                   verbose=verbose,
2883                                                   num_cores=num_cores,
-> 2884                                                   **kwargs
2885                                                  )
2886
~/anaconda3/lib/python3.6/site-packages/spectral_cube/spectral_cube.py in _apply_function_parallel_base(self, iteration_data, function, applicator, num_cores, verbose, use_memmap, parallel, memmap_dir, update_function, **kwargs)
2762
2763             for arg in iteration_data:
-> 2764                 applicator(arg, outcube, function, **kwargs)
2765                 pbu()
2766
~/anaconda3/lib/python3.6/site-packages/spectral_cube/spectral_cube.py in _apply_spectral_function(arguments, outcube, function, **kwargs)
108
109     if np.any(includemask):
--> 110         outcube[:,jj,ii] = function(spec, **kwargs)
111     else:
112         outcube[:,jj,ii] = spec
~/anaconda3/lib/python3.6/site-packages/astropy/nddata/decorators.py in wrapper(data, *args, **kwargs)
244                                   AstropyUserWarning)
245
--> 246             result = func(data, *args, **kwargs)
247
248             if unpack and repack:
~/anaconda3/lib/python3.6/site-packages/astropy/convolution/convolve.py in convolve(array, kernel, boundary, fill_value, nan_treatment, normalize_kernel, mask, preserve_nan, normalization_zero_tol)
336     if normalize_kernel:
337         if not nan_interpolate:
--> 338             result /= kernel_sum
339     else:
340         if nan_interpolate:
~/anaconda3/lib/python3.6/site-packages/astropy/units/quantity.py in array_ufunc(self, function, method, *inputs, **kwargs)
473             return result
474
--> 475         return self._result_as_quantity(result, unit, out)
476
477     def _result_as_quantity(self, result, unit, out):
~/anaconda3/lib/python3.6/site-packages/astropy/units/quantity.py in _result_as_quantity(self, result, unit, out)
512         # the output is of the correct Quantity subclass, as it was passed
513         # through check_output.
--> 514         out._set_unit(unit)
515         return out
516
AttributeError: 'numpy.ndarray' object has no attribute '_set_unit'

@hongliliu -- Can you try changing the second last line to kernel = Gaussian1DKernel(gaussian_width.value) and see if that works?

@hongliliu -- Can you try changing the second last line to kernel = Gaussian1DKernel(gaussian_width.value) and see if that works?

It works now following your suggestion. Thank you very much for your kind help.

This issue also came up in #514, but it wasn't fixed by #507.

Addressed in #578


Content Creator: Currency Input Plugin

As a content creator I want an Input Plugins for currency so that I can build forms with currency-input use cases.
Feature: Currency Text Input
  As a developer
  I want a currency Input Plugin
  So that I can build forms with currency-input use cases.

  Scenario: Currency input
    Given that a user may need to enter currency into a form
      And that currencies are limited to two decimal places
      And that currency can come in any number of types such as Euros or dollars
    When creating a form that requires a currency input
    Then I will need an Input Plugin which allows the selection of currency type
      And currency types will be selected from configurable options
      And also allows the forcing of a single currency type
      And limits the entry of a number to two decimal places
      And requires that data to be a number

[x] Currency Text Inputs / Currency input

blocked by:
https://github.com/punchcard-cms/eslint-config-punchcard/issues/17

Currency plugin complete and live


add steps bar for js

Describe the project you want to add with tech stack
simple stepsbar for progress
Expected behavior
next and previous button to steps up and down
Screenshots (optional)

Additional context (optional )

Closing due to inactivity


Add more modal class blocks

Description
As discussed 😉
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] I updated the documentation (see here)
[x] I agree that this code will be published under the MIT license

I have no time ATM 😄
And that mean we should check for AdminLTE migration conflict,
which is not my case in any project 💀


Image responsive not working with as expected

When I use a link of outside inside my blog with high resolution then the image goes out of range is there any solution regarding this which I'm missing?
Thanks

Actually I came up with a solution but I don’t know if it is best approach but it working for me right now.
For Image I check HTML and find that the  tag was inside
so I just did
p img{
  max-width:100%;
  height:auto;
}

if I have done
img{
  max-width:100%;
  height:auto;
}

then that will select all the images which may or may needed so I just select the markdown image.


title and description by string id

Add hability to set title and description with String resource id
Examples:
.setTitle(R.string.spotligt_target_title);
.setDescription(R.string.spotligt_target_description);
With this, i dont need to use this:
SimpleTarget targetHints = new SimpleTarget.Builder(this)
.setTitle(getString(R.string.spotligt_target_title))
.setDescription(getString(R.string.spotligt_target_description))

Thank you for the PR, but unfortunately, SimpleTarget was removed at the version of 2.0.0.


Only return results for models with fields from smart_selects

Closes #201.

Coverage increased (+2.02%) to 89.52% when pulling 051ea42c6be9468daa08679531f3ea6419591e29 on blag:opt-in-models into b97d095dba30dda55ee7f053e7f5bb4eaa8b48bb on digi604:master.

Coverage increased (+2.02%) to 89.52% when pulling 11305e54c32d67a5680c416d4ccd77b587e97b34 on blag:opt-in-models into b97d095dba30dda55ee7f053e7f5bb4eaa8b48bb on digi604:master.


Try to split up some functions and remove the unnecessary for loop

Adding cla: yes label, as the PR author is a googler at the time of this PR was created.


Drop support for node < 6

node 4 is reaching EOL later this April and along with it we can also reasonably get rid of transpiling

Pull Request Test Coverage Report for Build 265

7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.0%) to 96.552%

Totals

Change from base Build 257:
1.0%

Covered Lines:
79

Relevant Lines:
79

💛  - Coveralls


python312Packages.google-cloud-netapp: 0.3.13 -> 0.3.14

Changelog: https://github.com/googleapis/google-cloud-python/blob/google-cloud-netapp-v0.3.14/packages/google-cloud-netapp/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 342659 run on x86_64-linux 1

4 packages built:

python311Packages.google-cloud-netapp
python311Packages.google-cloud-netapp.dist
python312Packages.google-cloud-netapp
python312Packages.google-cloud-netapp.dist


Can't recognize words

hi there, i have a problem with this package, package didn't recognize some english n-words like vagina for example, I'm new to node.js and javascript, what i nedd to do?

hi @sayhitorose , this package only detects Persian words, it means you can't use this package for english swear words and i don't have any program to enhance this package.


Fix: Reference GenesisCloud in docs

The docs have been written, just the reference has been forgotten.

Also the providers have been sorted alphabetically.