multicluster tests setup secrets first

This change makes it so we:

setup primaries
install "base" (CRDs, service account, etc.) to remote clusters
create secrets
actually install istio on remote clusters

Step 4 fails when using JWT auth, the ingress will never come-up because the control plane can't validate the claims since it doesn't have kube config yet.
Another hack that would work for tests is constantly retrying the remote secret creation alongside the remote installs.
The change in this PR itself is a hack and we should discuss how to guide users for installing with JWT auth enabled.

@stevenctl: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
2f95681b052b8bfcfe098d453b79c17598192446
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
ef3f0d9d82c0071bd8737677c895c928d904f94f
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
ef3f0d9d82c0071bd8737677c895c928d904f94f
link
/test unit-tests_istio

integ-multicluster-k8s-tests_istio
ef3f0d9d82c0071bd8737677c895c928d904f94f
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
ef3f0d9d82c0071bd8737677c895c928d904f94f
link
/test unit-tests_istio

integ-multicluster-k8s-tests_istio
ef3f0d9d82c0071bd8737677c895c928d904f94f
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
fc7131691768d943d7237833853228fb4587bb4f
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
fc7131691768d943d7237833853228fb4587bb4f
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
fc7131691768d943d7237833853228fb4587bb4f
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
fc7131691768d943d7237833853228fb4587bb4f
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
fc7131691768d943d7237833853228fb4587bb4f
link
/test integ-multicluster-k8s-tests_istio

unit-tests_istio
97a640005ba3db2dfbbd6c56dc3d0f8a96951205
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
97a640005ba3db2dfbbd6c56dc3d0f8a96951205
link
/test unit-tests_istio

integ-multicluster-k8s-tests_istio
97a640005ba3db2dfbbd6c56dc3d0f8a96951205
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

maybe create-remote-secret can just create the service account?
On Wed, Sep 2, 2020 at 3:18 PM Steven Landow<EMAIL_ADDRESS>wrote:

@stevenctl commented on this pull request.
In pkg/test/framework/components/istio/operator.go
https://github.com/istio/istio/pull/27010#discussion_r482529910:

@@ -251,23 +251,24 @@ func deploy(ctx resource.Context, env *kube.Environment, cfg Config) (Instance,
}
}

// Deploy Istio to remote clusters

// Deploy base to remote clusters so create remote secret won't fail (need service account)

As of today with JWT auth enabled yes. We need a better way to do things.
Is there a better istioctl command for setting up just the reader service
account? That's the only thing that prevents us from running
create-remote-secret before installing.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/27010#discussion_r482529910, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXOEGTEHDRCSN3ASFW3SD3AB5ANCNFSM4QTYUSEQ
.

@stevenctl: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
bc902025fef8946a0bca392beb6fb1f8fc5391c7
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
dd859e2806888be7e888fc3531680051dfd3cece
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
37340a5205a9196b800cd85536b4ea47485fe0d3
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
37340a5205a9196b800cd85536b4ea47485fe0d3
link
/test integ-multicluster-k8s-tests_istio

analyze-tests_istio
ac41d3c259dcffa909c75f5a78794aab89fe42be
link
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
37340a5205a9196b800cd85536b4ea47485fe0d3
link
/test integ-multicluster-k8s-tests_istio

analyze-tests_istio
ac41d3c259dcffa909c75f5a78794aab89fe42be
link
/test analyze-tests_istio

lint_istio
f8c1208f83bd43e667216772dea83a12b03497bd
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
37340a5205a9196b800cd85536b4ea47485fe0d3
link
/test integ-multicluster-k8s-tests_istio

analyze-tests_istio
ac41d3c259dcffa909c75f5a78794aab89fe42be
link
/test analyze-tests_istio

lint_istio
f8c1208f83bd43e667216772dea83a12b03497bd
link
/test lint_istio

gencheck_istio
f8c1208f83bd43e667216772dea83a12b03497bd
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
f8c1208f83bd43e667216772dea83a12b03497bd
link
/test lint_istio

gencheck_istio
f8c1208f83bd43e667216772dea83a12b03497bd
link
/test gencheck_istio

integ-multicluster-k8s-tests_istio
f8c1208f83bd43e667216772dea83a12b03497bd
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
f8c1208f83bd43e667216772dea83a12b03497bd
link
/test gencheck_istio

integ-multicluster-k8s-tests_istio
f8c1208f83bd43e667216772dea83a12b03497bd
link
/test integ-multicluster-k8s-tests_istio

lint_istio
0e05a37aa1770d51084f389072676c33e689dd3d
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
f8c1208f83bd43e667216772dea83a12b03497bd
link
/test integ-multicluster-k8s-tests_istio

lint_istio
0e05a37aa1770d51084f389072676c33e689dd3d
link
/test lint_istio

gencheck_istio
0e05a37aa1770d51084f389072676c33e689dd3d
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
0e05a37aa1770d51084f389072676c33e689dd3d
link
/test lint_istio

gencheck_istio
0e05a37aa1770d51084f389072676c33e689dd3d
link
/test gencheck_istio

integ-multicluster-k8s-tests_istio
0e05a37aa1770d51084f389072676c33e689dd3d
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
0e05a37aa1770d51084f389072676c33e689dd3d
link
/test gencheck_istio

integ-multicluster-k8s-tests_istio
0e05a37aa1770d51084f389072676c33e689dd3d
link
/test integ-multicluster-k8s-tests_istio

lint_istio
c9b1264ec266fd27ef77bfd815970914d2bd6631
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
0e05a37aa1770d51084f389072676c33e689dd3d
link
/test integ-multicluster-k8s-tests_istio

lint_istio
c9b1264ec266fd27ef77bfd815970914d2bd6631
link
/test lint_istio

gencheck_istio
c9b1264ec266fd27ef77bfd815970914d2bd6631
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
c9b1264ec266fd27ef77bfd815970914d2bd6631
link
/test lint_istio

gencheck_istio
5977318c900b54820ff8c7d708e74cbdcaf824f2
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
5977318c900b54820ff8c7d708e74cbdcaf824f2
link
/test gencheck_istio

lint_istio
5977318c900b54820ff8c7d708e74cbdcaf824f2
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
5977318c900b54820ff8c7d708e74cbdcaf824f2
link
/test lint_istio

gencheck_istio
cd0b298674296bd33d4ab362b84648728c885efb
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
cd0b298674296bd33d4ab362b84648728c885efb
link
/test gencheck_istio

lint_istio
cd0b298674296bd33d4ab362b84648728c885efb
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
cd0b298674296bd33d4ab362b84648728c885efb
link
/test lint_istio

gencheck_istio
c350f9b3b57407aa8fe2dba91f37c5d3583e331a
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
c350f9b3b57407aa8fe2dba91f37c5d3583e331a
link
/test gencheck_istio

unit-tests_istio
c350f9b3b57407aa8fe2dba91f37c5d3583e331a
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
c350f9b3b57407aa8fe2dba91f37c5d3583e331a
link
/test gencheck_istio

unit-tests_istio
c350f9b3b57407aa8fe2dba91f37c5d3583e331a
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
c350f9b3b57407aa8fe2dba91f37c5d3583e331a
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
c350f9b3b57407aa8fe2dba91f37c5d3583e331a
link
/test gencheck_istio

unit-tests_istio
c350f9b3b57407aa8fe2dba91f37c5d3583e331a
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
c350f9b3b57407aa8fe2dba91f37c5d3583e331a
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
c350f9b3b57407aa8fe2dba91f37c5d3583e331a
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
c350f9b3b57407aa8fe2dba91f37c5d3583e331a
link
/test gencheck_istio

unit-tests_istio
c350f9b3b57407aa8fe2dba91f37c5d3583e331a
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
c350f9b3b57407aa8fe2dba91f37c5d3583e331a
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
c350f9b3b57407aa8fe2dba91f37c5d3583e331a
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c350f9b3b57407aa8fe2dba91f37c5d3583e331a
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
c350f9b3b57407aa8fe2dba91f37c5d3583e331a
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
c350f9b3b57407aa8fe2dba91f37c5d3583e331a
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
c350f9b3b57407aa8fe2dba91f37c5d3583e331a
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c350f9b3b57407aa8fe2dba91f37c5d3583e331a
link
/test integ-multicluster-k8s-tests_istio

gencheck_istio
efa7a3638a96fe612a2cf0ce3573498a2a0fb886
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

cc @rshriram - patched https://github.com/istio/istio/pull/26995 and it passes.

@googlebot I consent.

@stevenctl thank you so much for all the fixes


[Feature]:  Footer Enhancement

Description
For better user experience we have to add some styling to  the footer sectiom.
Suggested Solution
Footer section enhancement
Alternatives
No response
Additional Context
No response

@Damini2004 will be able to join a community meet and explain about your idea?

@Bhanu-code Yes

@Damini2004 please join our discord server community from readme or DM me in GSSoC discord server

@Damini2004 please join our discord server community from readme or DM me in GSSoC discord server

Didn't get the server sir and the link is also expired ?


Improve Portuguese translation

Sorry, I missed this PR. Merged now.
http://waifu2x.udp.jp/index.pt.html


Update Deploy Docs

Update the deployment documentation now that we have AWS deploys. Did some slight rearranging. Namely:

Put all the information about the GCP Cloud Runner deploy into one page
Removed all the WIP deployment pages and created a single page with associated issues to track interest in other deployment option guides.
Created an overview page for deployment and deployment philosophy

:shipit:


How to completely disable cookies?

I've been trying to figure out how to complete disable cookies for a chromedp instance that is NOT running a profile, but there's not a lot of information online about this. Can you please instruct me on the proper method to disable cookies? Thank you

Maybe the chrome command line option --blink-settings=cookieEnabled=false is what you want. Please give it a try.
package main

import (
    "context"
    "log"
    "os"

    "github.com/chromedp/chromedp"
)

func main() {
    opts := append(chromedp.DefaultExecAllocatorOptions[:],
        chromedp.Flag("blink-settings", "cookieEnabled=false"),
    )
    ctx, cancel := chromedp.NewExecAllocator(context.Background(), opts...)
    defer cancel()

    ctx, cancel = chromedp.NewContext(ctx)
    defer cancel()

    var res []byte
    err := chromedp.Run(ctx,
        chromedp.Navigate(`https://twitter.com/`),
        chromedp.FullScreenshot(&res, 100),
    )
    if err != nil {
        log.Fatal(err)
    }

    os.WriteFile("screenshot.png", res, 0644)
}

The available blink-settings can be found here: https://source.chromium.org/chromium/chromium/src/+/09372ea8ec2ab6363ccad6a4847a1c9da560b29d:out/Debug/gen/third_party/blink/renderer/core/settings_macros.h;l=1535
This answer is modified from https://stackoverflow.com/a/73809820/1369400

That's great! I didn't realize the blink engine controlled so much. Incidently, I needed to disable javascript too, so that answers my question 200%. Thank you very much, you're the best!

After further investigation, it appears javascript and cookies are both still enabled
I am using https://www.whatismybrowser.com/detect/is-javascript-enabled and https://www.whatismybrowser.com/detect/are-cookies-enabled to test and both are reporting "Yes"
Here's what my allacator options are:
testOptions := []chromedp.ExecAllocatorOption{
	chromedp.UserDataDir(cwd + "/chrome"),
	chromedp.Flag("profile-directory", "amazon"),
	chromedp.WindowSize(rand.Intn(700-500)+500, rand.Intn(700-500)+500),
	chromedp.NoDefaultBrowserCheck,
	chromedp.UserAgent(randomUserAgent),
	chromedp.Flag("enable-automation", false),
	chromedp.Flag("blink-settings", "imagesEnabled=false"),
	chromedp.Flag("blink-settings", "cookieEnabled=false"),
	chromedp.Flag("blink-settings", "scriptEnabled=false"),
	chromedp.Flag("blink-settings", "disableReadingFromCanvas=false"),
}

Do you see anything I could be doing wrong?

chromedp.Flag("blink-settings", "disableReadingFromCanvas=false") will overwrite all the previous blink-settings. Should do it like this:
chromedp.Flag("blink-settings", "imagesEnabled=false,cookieEnabled=false,scriptEnabled=false,disableReadingFromCanvas=false")

Ah, that makes sense. I didn't realize it would overwrite, thank you


fix: Only distribute ES module

Abandoning because it's not as easy as I thought.
https://jestjs.io/docs/ecmascript-modules


Merge NLog 4.7.9 to dev

Doing the merge in 2 steps. First the actual changes.

I had the same idea :)

-> https://github.com/NLog/NLog/pull/4359


Provide ownership based sandbox

A pool for concurrent transactional tests.

When started, the pool is in automatic mode, which means using
the repository will automatically check connections out as with
any other pool. The only difference is that connections are not
checked back in automatically but by explicitly calling checkin/2.
The mode/2 function can be used to change the pool mode to
:manual. In this case, each connection must be explicitly
checked out before use. This is useful when paired with
checkout/2 which by default wraps the connection in a transaction.
This means developers have a safe mechanism for running concurrent
tests against the database.
Example
The first step is to configure your database to use the
Ecto.Adapters.SQL.Sandbox pool. You set those options in your
config/config.exs:
config :my_app, Repo,
  pool: Ecto.Adapters.SQL.Sandbox

Since you don't want those options in your production database, we
typically recommend to create a config/test.exs and add the
following to the bottom of your config/config.exs file:
import_config "config/#{Mix.env}.exs"

Now with the test database properly configured, you can write
transactional tests:
# At the end of your test_helper.exs
# Set the pool mode to manual for explicitly checkouts
Ecto.Adapters.SQL.Sandbox.mode(TestRepo, :manual)

defmodule PostTest do
  # Once the model is manual, tests can also be async
  use ExUnit.Case, async: true

  setup do
    # Explicitly get a connection before each test
    :ok = Ecto.Adapters.SQL.Sandbox.checkout(TestRepo)
  end

  test "create comment" do
    # Use the repository as usual
    assert %Post{} = TestRepo.insert!(%Post{})
  end
end

Is this setup suitable for integration tests? I followed the instructions but in my test, where access to db performed somewhere in the app, when I connect with test websocket client, I get: RuntimeError{message: "cannot find ownership process for #PID<0.399.0>. This may happen if you have not explicitly checked out or the checked out process crashed"} Also this might be worth including into sample app, it took a while until I found this.

@youroff It should be possible but you need some extra work. For example, you can pass the owner pid as a parameter:
self |> :erlang.pid_to_list |> List.to_string |> Base.url_encode64

Then in your socket you will need to do:
pid = encoded |> Base.url_decode64! |> String._to_list |> :erlang.list_to_pid
Ecto.Adapters.SQL.Sandbox.allow(Repo, pid, self())

We need to make this easier and test-only but I am not sure yet how.

I'm not sure that I understand who's the owner here. Is this a main app process? Or Supervisor, that runs Database pool? Or process where test is performing?  The owner process is the test that checks out the connection from the sandbox. In this case, it is the test process. The one running your test. Once the request starts, you need to tell it which connection to use, that's why you get the error. So one approach right now is to use what I proposed above, which is to encode the test process pid somehow into the parameters sent to the websocket and decode it there for testing purposes. We are investigating simpler solutions.

@josevalim ah, I see now. The need of polluting app code with test-related snippets looks hacky, but bearable. Are there other scenarios of Sandbox usage? I assume if there's manual, then there might be :auto or something, in case if I'm ok with sync test suite for integration? Or I can't mix async and sync tests?

Yes, your tests would need to be sync. The issue with :auto is that you don't have a transaction, so they will pollute the DB. I have opened an issue to support shared mode, which is a mixture of auto and manual: #1223

Oh, very cool. Thank you, the solution you proposed totally worked. And thanks a lot for Elixir itself, it is absolutely awesome!

I've got another issue. In dev mode with pool: Ecto.Adapters.SQL.Sandbox in config, sometimes I see this error:
18:29:17.983 [error] Postgrex.Protocol (#PID<0.420.0>) disconnected: ** (DBConnection.Error) client timeout
Is this config for tests only, so shouldn't it go to test.exs from the beginning? Or I have something unrelated?

It is test only. :)

Yeah, right, my bad :) But config example is really misleading, probably worth mentioning that it goes to test.exs. Now it's reading as if it stays at the top and the rest of configs per dev go to sub-files.

I've got another issue. In dev mode with pool: Ecto.Adapters.SQL.Sandbox in config, sometimes I see this error:
18:29:17.983 [error] Postgrex.Protocol (#PID<0.420.0>) disconnected: ** (DBConnection.Error) client timeout
Is this config for tests only, so shouldn't it go to test.exs from the beginning? Or I have something unrelated?

This is a bug in DBConnection's ownership pool I will open an issue there. Thank you for the report.

@youroff I have pushed shared mode that will make your scenario much easier with the downside of not allowing concurrent tests. You can read a direct comparison of those modes here: https://github.com/elixir-lang/ecto/commit/dc9c2f940511999bcb5ca1d6c47ee8ef7f5fde61#diff-75c3d8c8b421ecc99c1ef78229abeb6aR54

Awesome, thank you @josevalim! :+1: :+1: :+1:

I've got another issue. In dev mode with pool: Ecto.Adapters.SQL.Sandbox in config, sometimes I see this error:
18:29:17.983 [error] Postgrex.Protocol (#PID<0.420.0>) disconnected: ** (DBConnection.Error) client timeout
Is this config for tests only, so shouldn't it go to test.exs from the beginning? Or I have something unrelated?

In DBConnection master the ownership pool (the base of Sandbox) supports setting ownership_timeout: :infinity which will allow using the Sandbox from shell/dev.

@fishcakez So, should I use Sandbox outside of test env? I think I still don't understand what is Sandbox, could you point at docs or sources where this abstraction is introduced?

@youroff with @fishcakez's commit, now you can use it for dev. The best way to read more about it is in the docs I have linked earlier.


Support Backing up Mods/etc Folders

This could be done adding something like this in the configuration file:
java:
    - name: <container name>
      extras:
        - <folder path>
      worlds:
        - <world path>

The result would be a series of zip files. So if I had a container called “minecraft_server” and the world was “Yosemite”, the result would be:
minecraft_server.extras.Timestamp.zip
Yosemite.Timestamp.zip
Inside the extras zip would be each folder that was listed in the extras part of the configuration.

Would need to ivestigate how this interacts with the trimming logic. It should be fine, but it would at least need to identify the extras as a proper bucket to trim.

 Enable Backup of extra folders


docs: edit budget_with_farming.md demo text

changes for grammar and consistent audience "you"
see the Technical content style guidance for Farming
most of the changes here tightened up language, provide consistency, changed audience to "you"
good job! I did not run the demo, so I verify only the language

Description

closes: #XXXX
Tasks

[ ]

References

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Appropriate labels applied
[ ] Targeted PR against correct branch
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards.
[ ] Wrote unit and integration
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
[ ] Added relevant godoc comments.
[ ] Re-reviewed Files changed in the Github PR explorer
[ ] Review Codecov Report in the comment section below once CI passes

thank you @kogisin make any changes required and commit at will, great improvements!


Parsing issue when city name is not provided and province is included in the address

The address i was testing is 322-b boul rene-levesque, a12s3d, canada.
if city isn't provided then the street name (rene-levesque) is considered as the city:

322-b boul rene-levesque, qc, a12s3d, canada
Result:
{
"house_number": "322-b",
"road": "boul",
"city": "rene-levesque",
"state": "qc",
"postcode": "a12s3d",
"country": "canada"
}

However, if the city name is included in the address then it is tokenized correctly:

322-b boul rene-levesque,montreal, qc, a12s3d, canada
Result:
{
"house_number": "322-b",
"road": "boul rene-levesque",
"city": "montreal",
"state": "qc",
"postcode": "a12s3d",
"country": "canada"
}

Just wondering how this scenario is handled in the parser. Thanks

Wrote about this in #178, but in the v1.0 release we were a bit overzealous in requiring city to be listed on all training examples. One aspect of the machine learning model we use, the Conditional Random Field, is that there are transition weights between each pair of labels, so the parser in this case gets very confident that if it sees state (and especially the token "QC" labeled as state), the previous token must be city, even if it's not a known place name.
This causes a few issues in edge case-y situations in the US and Canada, but generally helps performance in the rest of the world. There are two reasons why, one technical and one human:

Many major cities around the world are part of an eponymous district, state, and even country in cases like Singapore or Luxembourg. When we create the training data from OSM data, we first reverse geocode to every OSM polygon, including all administrative levels, but to format that address as a training example, we want to essentially mimic how a human would write it. So we have a set of configs which specify how likely each component should be in a given country or language. In the US, for example, we would usually see city+state, whereas state_district and country are more rare. If we never drop the city tag (when it's available), we can encourage the parser to prefer city when it sees the place name by itself. Dropping the city tag in the training data would create examples like the one above with "QC", but it would also create examples where, say, "New York" is listed in the exact same address meaning either state or city depending on a coin flip, with no real contextual way to disambiguate.

In some countries we don't have complete training data, partially because, as I've said in the 1.0 blog post, the mapping community is not all that representative of the diversity of the world. The question of where and what gets mapped often reflects the the people doing the mapping and their values. If we don't have every place name in some countries as part of OSM, the transition weights may still be able to help get the correct parse on structure alone.

The solution is to simply to have a very small but non-zero probability of city dropout in the US and Canada, which has been added for the v1.1 training data. The release is delayed a bit at present because OSM has grown too large to create the training set on a single machine, so I've had to develop some distributed Spark-based methods for point-in-polygon testing to do the reverse geocoding piece across multiple machines, and there's some refactoring associated with that as well.
This and similar parses should work well when v1.1 is out.

Great. Thanks for the quick response and sorry i missed the already existing issue. Good luck finishing the refactoring for v1.1


Colour cleanup

After using less, we should introduce variables, and be consistent with colours

[] colours
[] variables for button height

Fixed across various PRs, we now have the variables.less file with colours and line heights which are widely used.


Website update: install path location

Dan, the website isn't updated w/ appropriate path to dashdoodler.yml file.
Change:
conda env create --file install/dashdoodler.yml

To:
conda env create --file environment/dashdoodler.yml

Thanks


[Communication] - Log MS-CV headers

All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] Please open PR in Draft mode if it is:

Work in progress or not intended to be merged.
Encountering multiple pipeline failures and working on fixes.

[ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[ ] I have read the contribution guidelines.
[ ] The pull request does not introduce breaking changes.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
[ ] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:
Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

[ ] Include updated management metadata.
[ ] Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.

If the check fails at the Verify Code Generation step, please ensure:

Do not modify any code in generated folders.
Do not selectively include/remove generated files in the PR.
Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.

Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:
  `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`

Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

/azp run net - communication - tests

Spoke to @pavelprystinka about this change and the problem is that because PhoneNumberClientOptions is autogenerated, we are not able to directly add custom code to it. Pavel has requested the feature of easily extending the *ClientOptions constructor with the autorest team. However as a temporary workaround, I've just created a class that extends PhoneNumberClientOptions.


New INSTALL prerequisites

It would probably be useful to include this in the README so that people can quickly get the necessary libraries before installing tfutils:
pip install pymongo h5py tqdm gitpython

feel free to commit that
On Thu, Jan 26, 2017 at 4:29 PM Harry Bleyan<EMAIL_ADDRESS>wrote:

It would probably be useful to include this in the README so that people
can quickly get the necessary libraries before installing tfutils:
pip install pymongo h5py tqdm gitpython
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/neuroailab/tfutils/issues/46, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOHixvwmc4P7NpCvbGTKd0jFoyPYQBkks5rWTpLgaJpZM4LvUEE
.

Just updated setup.py, hopefully that fixes the issue. Not sure if it's necessary to list requirements explicitly in the README.


can maftools summary the base transform of each gene, like the following excel

the table contains the ref and alt base in each column, will maftools creat such a function.
thanks  a  lot

Hi,
This seems quite straight forward that can be done with couple of melt and cast functions. If it is really helpful, then I can implement it. I will let you know..

really helpful，thanks  a lot

Hi,
I have implemented this feature in the devel branch. Could you please test it and let me know ?
See ?refAltMat for details.
BiocManager::install(pkgs = "poisonalien/maftools@devel")

# example MAF
laml.maf <- system.file("extdata", "tcga_laml.maf.gz", package = "maftools")
laml <- read.maf(maf = laml.maf)

# usage
refAltMat(m = laml) # generate whole matrix
refAltMat(m = laml, genes = 'DNMT3A') #Restrict output to DNMT3A gene
refAltMat(m = laml, tsb = 'TCGA-AB-2987') #Restrict output to the sample TCGA-AB-2987


Remove the need for curly brackets surrounding destructured parameter in high order function passed to Array#map

Suggestion
Remove the need for curly brackets surrounding destructured parameter in high order function passed to Array#map
🔍 Search Terms

high order array methods map foreach destructure tuple remove parentheses
✅ Viability Checklist

My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion

When calling high order array methods (Array#map, for example), sometimes (most of the time for me) we only need to access the current element of the array and have no need to access the index or the whole array (2nd and 3rd parameters on the function that is provided to map).
When accessing only the current element in the array, one can leave out the parentheses that surround the parameter in the function. E.g:
let arr = [1,2,3,4,5];
//with 3 parameters, curved braces are needed. Makes sense
arr.map((cur,i,arr)=>/* return something */)

//with 1 parameter, curved braces are optional. Makes sense
arr.map(cur=>/* return something */)

However, if this is an array of tuples and we destructure the current element,
typescript forces the parameter to be surrounded by brackets.
In my view, this is unnecessary and removing it would allow code to be more readable
let arr:[number,number][] = [[1,2],[3,4],[4,5],[6,7]];
//current behaviour
arr.map(([n1,n2])=>/* return something */)

//suggested behaviour
arr.map([n1,n2]=>/* return something */)

I suggest applying this only to tuples and arrays.
I say this because objects might cause problems because of the curly brackets,
which are needed for destructuring.
📃 Motivating Example

Using Array#map I was iterating through an array of tuples, performing an operation between the first element and the second and returning the result.
tupleArr.map(([t1,t2])=>/* return somevalue */)

I noticed that the ( ) around the destructured parameter were unecessary (in terms of readability).
Removing them seems intuitive and natural.
💻 Use Cases

I think the code would be more readable if the parentheses were not obligatory to surround the destructured parameter.
So imo, ideally:
arr.map([a,b]=>/*do something*/);

Using the curly brackets is ok, but I think this a small improvement that would make people's lives beter.
Thank you for your time, if anything in this issue is inadequate, pls let me know. This is the first issue I submit on github, so I would love feedback.

That wouldn't be valid JavaScript anymore. So TypeScript would have to emit different JS, which (I'm pretty sure of it) is out of scope for TypeScript.


Import only what is needed for lodash and d3 [DO NOT MERGE]

This is for converting our * star imports of lodash and d3 into more targeted named imports.
re: #3948

Currently a work in progress.. I've only done actions and lodash so far.

Putting the pause on this for now.. It's a big several day long mess that resulted in:

bundle size did not shrink at all (maybe even got bigger)
tests fail now for mysterious reasons, but seems to be something with d3.event
require lodash for build scripts and lodash-es for the bundle (ugh)
treeshaking seems to be a lie
rollup bugs with name mangling?  (d3 exports event, we import as d3_event, rollup renames it back to event which conflicts with  window.event??)

Need a break from this.. 😞

I restored the global d3 for now so that the tests would be happy, and figured out how to get rollup to resolve the d3 dependencies on node4/npm2.  This returns things to a mergeable state.
There is still some ugly stuff here but I'm going to merge as-is and open follow-on issues for cleanup, since I don't want this huge bunch of work to go stale.


Fix improper usage in refactoring ns-policy

A simple fix for imporper usage during code refactoring. The cause of the issue can refer to the following PRs: #5371 #12078
No doc is required.

/pulsarbot run-failure-checks

@merlimat - PTAL

LGTM. I see that the isProducersExceeded method in this class has the same logic that you're updating here. Should we fix that one too?

@michaeljmarshall Yes, thank you for your reminder, but I prefer to open another issue later to discuss about isProducersExceeded. That involves some other issues.

@wuzhanpeng - are you able to rebase your changes here? When I approved this previously, I wasn't a committer. I am now, so I can merge this if we get it into a good place.

Closed as stale and conflict. Please rebase and resubmit the patch if it's still relevant.

When I approved this previously, I wasn't a committer. I am now, so I can merge this if we get it into a good place.

@michaeljmarshall I often rebase for the patch stale if I can nudge it forward. As a committer your can push to the PR branch as long as the author checks "allow edits from maintainers" (by default). Also, you may supersede the patch with your own while keep the original author in "Co-authored-by" footeer.
For this specific PR, https://github.com/apache/pulsar/pull/12158#discussion_r826926441 can be an effective request change :)


Moving to Circle 2.0

Q
A

Fixed tickets
n/a

License
MIT

This PR is ready, test failures are out of the scope of these changes.
docker login steps (which require authentication details) are up to you @cordoval:
docker login -u coder20078 -p $DOCKER_HUB_PASSWORD -e<EMAIL_ADDRESS>docker tag -f gush coder20078/gush
docker push coder20078/gush
WARNING! Using --password via the CLI is insecure. Use --password-stdin.
Error response from daemon: login attempt to https://gmail.com/v2/ failed with status: 404 Not Found
Exited with code 1

Thank you in advance.


use same docker image for build and run stage

This PR updates the Dockerfile to use the same node base image for built and run stage.
For this an Dockerfile ARG is defined and used in both places to ensure that when updating the image it is consistent for both stages.

🎉  thanks!


[BUG] pygwalker bug report: retrieving specs when app URL has path

Describe the bug
It looks like Pygwalker cannot read specs when the app's url is composed of a host + path. Writting seems fine though.
For example, I have an app deployed with the following URL structure:
ORIGIN/PATHNAME
This URL structure comes from corporate constraints within the company I work for.
I have taken a look at "pygwalkjer-app.iife.js", which I believe is generated by "communication.tsx", and I see this:
i=/${e}/${A}
I believe this should be updated to i=${window.parent.document.location.href}/${e}/${A}
To Reproduce
Steps to reproduce the behavior:

Deploy your Streamlit app with the following URL structure: i=/${e}/${A}
Use the following Python code

StreamlitRenderer(dataset=df, spec=PATH_TO_SPEC, spec_io_mode="rw")

Try load your Pygwalker chart
The page gets stuck on "Loading Graphic- Walker UI..."

Screenshots
If applicable, add screenshots to help explain your problem.
Versions

pygwalker version: <IP_ADDRESS>
python version: 3.11
browser: Google Chrome

Additional context
I have opened a PR to address this issue: https://github.com/Kanaries/pygwalker/pull/563

Hi @thomasbs17 .
I urgently released a pre-release version to solve this bug, pip install pygwalker==<IP_ADDRESS>a0.
Looking forward to your feedback.

Hi @longxiaofei , I can confirm that my issue is resolved using version <IP_ADDRESS>a0.
Thank you so much for the amazing turnaround and, overall, for the great package!


Design updates for all the components.

All the components need to be updated for a better user experience and design.

AutoComplete
Avatar
Badge
Button
Card
Carousel
Checkbox
CheckboxGroup
Chip
Drawer
Menu
Modal
MultiSelect
Navbar
Pagination
Popover
Preloader
ProgressBar
RadioButtonGroup
Select
Slider
Snackbar
Table
TextInput
Toggle
Tooltip

:tada: This issue has been resolved in version 1.0.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Documentation is missing the NPS configuration Info

The docs here on this page https://docs.microsoft.com/en-us/azure/active-directory/authentication/howto-mfa-nps-extension for using the NPS extension for Azure MFA is missing the actual NPC configuration.  Many people trying to configure this Extension for using Azure MFA do not know NPS and do not know how the NPS policy should be configured or the Radius client entry should be configured in the NPS management console to make this extension work.  Please give some basic NPS configuration guidance to make this extension work.  The NPS configuration is KEY to making use of this extension and the current docs do not give any guidance at all on configuring the NPS policy and client on the NPS management console.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a61a7e9a-44bf-7bdc-f810-87e2fd6792e1
Version Independent ID: 71d11105-b83e-952e-d107-1ff9a7c8d107
Content: Use existing NPS servers to provide Azure MFA capabilities - Azure Active Directory
Content Source: articles/active-directory/authentication/howto-mfa-nps-extension.md
Service: active-directory
Sub-service: authentication
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

Any update on this?

Any Updates?


Reported test run durations are affected by freezegun

Just tried this out for the first time and the reported runtimes for my suite as well as some of the tests are wildly wrong.
The suite ran in about 15 minutes.

The tests which have the huge runtimes are all using Freezegun to mess with the clock https://github.com/spulec/freezegun which feels like it's probably related.
Freezegun has its own ignore system, unsure if that's the best fix for this or if the test collector should automatically handle libraries like this.

I've confirmed it's definitely an interaction with freezegun. Adding the following to conftest resolved it.
import freezegun

freezegun.configure(extend_ignore_list=['buildkite_test_collector'])

Thanks for raising this, don't think we can reasonably support such behaviour automatically for all time mocking tools.
Going to close this issue based on the fact that the ignore list fix works around it.
See https://github.com/spulec/freezegun?tab=readme-ov-file#ignore-packages for more details.


SBT signaling standard

hi,
I came across your Guild Pin product and thought it was really cool. I‘m the author of https://eips.ethereum.org/EIPS/eip-5192 and we suggest to implement events for locking and unlocking tokens, as well as a locked function to get the status of a token‘s lock.
From what I can tell, your implementation reverts on all transferring functions, which is also what we suggest doing in the standard.
Although our standard allows unlocking tokens again, you don‘t have to implement that.
Our main idea is that by emitting the Lock and Unlock events and through the interface identifier, we can let wallets know when a token is soulbound, such that they can hide the transfer button, and inform the user about non-transferability.
E.g. OpenSea added partial support for this and the more people we can convince of adding these two events and the view function, the more the value if SBTs can grow 🤞
Hope I could sell you on this standard! It‘s far from perfect, but it could help grow the space a little!

happy to answer any questions or even help implementing! Just text me
best,
Tim

Hey @TimDaub, thanks for introducing me to this (and for the eip itself ofc)!
I've implemented it in #10, could you review it please?


Join Sign

Can you put a Join Sign ? Instead of typing /match
By the way . your my idol ^_^

Okay, it will be a bit easy I think but, there is a lot a thing to finish before and I will just enjoy a bit my holidays and then I will work. But thanks and nice idea :)

Have already programmed that should i make an pull request?

@Minifixio :) okay enjoy your vacation
@robske110 . please ? Make a pull request . i just need that now :)

I am skiing currently, I will be able to make a pull request this evening (maybe, if i am not sleeping as soon as i am at home)

Oh, and you can test my implementation of the sign on this server:
robskebueba.no-ip.biz:3114
(Goto PvP and Klick the signs)

@Robske110 . Ok

@Robske110. Make a Pull Request please

Maybe I would be able to do this this evening

Sorry, was busy made an pull request for better kit management now
Sign is coming up but i have to clean up that code...

TapToDo do the magic,  (fixed). :+1:

Well TapToDo Helps xD

i tried taptodo It doesn't work :/


Commands are not automatically created in shim

I use bundle install to install  asciidoctor-pdf-cjk-kai_gen_gothic-install from github.
My Gemfile looks like this:
source 'https://rubygems.org'

gem 'rubyzip', '2.3.2'
gem 'ffi', '1.16.3'
gem 'rake'
gem 'asciidoctor', '2.0.12'

gem 'json'
gem 'awesome_print'

gem 'ttfunk', '1.5.1'
gem 'asciidoctor-fb2'
gem 'asciidoctor-epub3', '1.5.0.alpha.11'
gem 'asciidoctor-pdf', '1.5.0.alpha.16'
gem 'asciidoctor-pdf-cjk', '~> 0.1.3'
gem 'asciidoctor-pdf-cjk-kai_gen_gothic', github: 'Sherry520/asciidoctor-pdf-cjk-kai_gen_gothic'

gem 'coderay'
gem 'pygments.rb'
gem 'thread_safe'
gem 'epubcheck-ruby'
gem 'html-proofer'

When I run bundle install, things look good:

But it didn't work, I have tried the method mentioned in Understanding-binstubs :

It looks like this command does not exist in shim:

Environment
$ gem env
RubyGems Environment:
  - RUBYGEMS VERSION: 3.1.6
  - RUBY VERSION: 2.7.8 (2023-03-30 patchlevel 225) [x86_64-linux]
  - INSTALLATION DIRECTORY: /home/gyh/.rbenv/versions/2.7.8/lib/ruby/gems/2.7.0
  - USER INSTALLATION DIRECTORY: /home/gyh/.gem/ruby/2.7.0
  - RUBY EXECUTABLE: /home/gyh/.rbenv/versions/2.7.8/bin/ruby
  - GIT EXECUTABLE: /usr/bin/git
  - EXECUTABLE DIRECTORY: /home/gyh/.rbenv/versions/2.7.8/bin
  - SPEC CACHE DIRECTORY: /home/gyh/.gem/specs
  - SYSTEM CONFIGURATION DIRECTORY: /home/gyh/.rbenv/versions/2.7.8/etc
  - RUBYGEMS PLATFORMS:
    - ruby
    - x86_64-linux
  - GEM PATHS:
     - /home/gyh/.rbenv/versions/2.7.8/lib/ruby/gems/2.7.0
     - /home/gyh/.gem/ruby/2.7.0
  - GEM CONFIGURATION:
     - :update_sources => true
     - :verbose => true
     - :backtrace => false
     - :bulk_threshold => 1000
  - REMOTE SOURCES:
     - https://rubygems.org/
  - SHELL PATH:
     - /home/gyh/.rbenv/versions/2.7.8/bin
     - /home/gyh/.rbenv/libexec
     - /home/gyh/.rbenv/plugins/ruby-build/bin
     - /home/gyh/.rbenv/shims
     - /home/gyh/.rbenv/bin
     - /home/gyh/software/docx2txt-1.4
     - /home/gyh/.local/bin
     - /home/gyh/software/admixture_linux-1.3.0
     - /home/gyh/software/spack/bin
     - /home/gyh/software/PopLDdecay-3.42/bin
     - /home/gyh/software/meme/bin
     - /home/gyh/software/meme/libexec/meme-5.5.5
     - /home/gyh/software/openmpi/bin
     - /home/gyh/software/plink_linux_x86_64
     - /home/gyh/perl5/bin
     - /home/gyh/.rbenv/shims
     - /home/gyh/.rbenv/bin
     - /home/gyh/.local/bin
     - /home/gyh/bin
     - /home/gyh/software/docx2txt-1.4
     - /home/gyh/.local/bin
     - /home/gyh/software/admixture_linux-1.3.0
     - /home/gyh/software/spack/bin
     - /home/gyh/miniconda3/condabin
     - /home/gyh/software/PopLDdecay-3.42/bin
     - /home/gyh/software/meme/bin
     - /home/gyh/software/meme/libexec/meme-5.5.5
     - /home/gyh/software/openmpi/bin
     - /home/gyh/software/plink_linux_x86_64
     - /home/gyh/perl5/bin
     - /usr/local/Modules/bin
     - /usr/local/sbin
     - /usr/local/bin
     - /usr/sbin
     - /usr/bin
     - /sbin
     - /bin
     - /usr/games
     - /usr/local/games
     - /usr/lib/wsl/lib
     - ....(more not list)

Updating bundler to 2.4.22 worked fine, but it was difficult to enable the default use of the new version of bundler, and it somehow succeeded. Can you test if there is a problem with bundler2.1.4? Can you change the default configuration and use bundler2.4.22 for ruby2.7.8?

Hi, when you install gems using bundle install, rbenv won't generally know about their executables nor add them to rbenv shims. Let me explain.
Using plain RubyGems and not Bundler, when you do gem install asciidoctor (I've abbreviated the name of the gem for the sake of readability), RubyGems will by default place the asciidoctor executable alongside the ruby executable for that Ruby version and rbenv will pick that up and generate an asciidoctor shim in ~/.rbenv/shims/ascidooctor. Thus, a gem gets installed "globally" for that specific Ruby version that was active at the time gem install ran.
However, when you do bundle install in a project that uses the "asciidoctor" gem, those gems are only installed in the project directory that contains the Gemfile, and no gem binstubs are ever generated. After running bundle install, there is no asciidoctor executable in that Ruby version nor in the directory of the project that contains the Gemfile. Instead, to run executables of gems that are in your current bundle, you need to use bundle exec <command>.
However, constantly writing bundle exec asciidoctor… would quickly get tedious. So, making gem binstubs easily accessible to your project can be useful. To generate gem binstubs, you've already discovered that you need to run the bundle binstubs command, but you have tried to run asciidoctor command too quickly afterwards. You see, the asciidoctor binstub was generated, but it wasn't in the PATH and thus you can't run it just by typing its name. It was placed in the local ./bin directory by default, which is not in PATH, and therefore you can only activate it by executing bin/asciidoctor instead.
To make it easier for yourself, you could add ./bin to your global PATH so you don't have to prefix your executables with relative paths, but plenty of developers will warn you that this practice applied globally to your system could be dangerous because someone could exploit that via malicious executables placed in bin/ directories. Personally, I use the direnv tool to only add ./bin directories of projects to PATH that I have explicitly allow-listed.

Closing because it sounds like you solved your problem and because of my explanation in thread.


GetTransaction does not correctly propagate the output of getrawtransaction calls.

It turns out that the GetTransaction method added to lightwalletd is horribly broken, because it does not correctly propagate the output of the getrawtransaction JSON-RPC method.
It says here "optionally includes the block height" (which runs into the gRPC problem that this gets aliased with the genesis block height 0 making the transactions look mined), but below says "block height if mined, or -1" (implying to users of the RPC that -1 means "unmined").
Meanwhile, getrawtransaction actually returns:

A non-negative height for transactions mined in blocks in the current main chain.
-1 for transactions mined in blocks that are not in the main chain (i.e. conflicted).
Omitted for unmined transactions in the mempool.

This is further muddied by the fact that the Go parser is parsing the height field as an int, which is machine-dependent (and thus could differ from zcashd), and also I don't know how it handles omitted values (because it isn't to my knowledge a nullable type). So the unmined transactions might be getting their height fields coerced to some default in Go (0?) rather than being set as optional in the returned Protobuf (aka 0) - this needs further investigation.
RawTransaction was then further misused by the addition of the GetMempoolStream RPC. Transactions in the mempool should never be associated with the latest block height; if any height is associated with them, it should be the "mempool height" which is latest_height + 1 (which is the height at which the consensus rules are applied to the mempool transactions). So that RPC is broken as well.
This is going to be Not Fun™ to fix.
Originally posted by @str4d in https://github.com/zcash/librustzcash/pull/1473#discussion_r1701063435

So the unmined transactions might be getting their height fields coerced to some default in Go (0?) rather than being set as optional in the returned Protobuf (aka 0) - this needs further investigation

I looked into this using the debugger, and what happens is, the Go library function json.Unmarshal() deserializes the getrawtransaction 1 (1 for verbose) reply into an instance of:
	ZcashdRpcReplyGetrawtransaction struct {
		Hex    string
		Height int
	}

and since the "height" member is missing in the zcashd RPC reply for mempool transactions, it is set to zero. (I'm not sure if json.Unmarshal() is doing that or the Go language, it doesn't matter.) So it has nothing to do with protobuf (which really is getting a zero to serialize as part of the reply).

So it has nothing to do with protobuf (which really is getting a zero to serialize as part of the reply).

That's correct, in terms of the deserialization from the zcashd output. With respect to the protobuf part of this, the protobuf height field should really have been defined as int64, not uint64, but it's a bit late to change that now, so instead we are defining the field as an unsigned value that contains the twos-complement int64 representation, and as such the maximum value represents the -1 value returned from zcashd. Internally, clients should perform the conversion to a signed integer and check the sentinel cases before otherwise operating on the value.
Even though protobuf defines optional fields, it is not possible to test whether a value for the field was set or not, you can only test against the default value (which could be a valid value in the domain.) The only reason we're okay here is that we assume that wallets will never be querying for the genesis block's coinbase transaction, for which a height 0 is a valid value in the domain.


Update the [ESP32] Camera Suite app for the SDK version 0.97 f7

Hello!
Your [ESP32] Camera Suite app version 1.7 fails to build with the SDK version 0.97.0-rc f7. Please update the app in your repository and create a new pull request to the catalog repository with the updated manifest file.

IMPORTANT: Don’t forget to update the app version and commit version in the manifest file.

View logs
Flipper Team

v1.7 only supports F0 v0.98-rc+ since the new UART updates. There are no plans to make v1.7 work with 0.97.0-rc f7, I don't believe it's possible at this point. Closing. Thank you
See https://github.com/flipperdevices/flipper-application-catalog/pull/303

v1.7 only supports F0 v0.98-rc+ since the new UART updates. There are no plans to make v1.7 work with 0.97.0-rc f7, I don't believe it's possible at this point. Closing. Thank you
See https://github.com/flipperdevices/flipper-application-catalog/pull/303


Poor performance with single physics object (Firefox?)

Hi,
I'm getting pretty choppy performance using Firefox with a very simple implementation of matter to simulate one object.
Either this is an issue with Firefox (?) or perhaps my code which I'll add below. I really didn't think that one physics object would lag the page like it does.
// --- matter.js ---
// Initialize world
let Engine = Matter.Engine,
Render = Matter.Render,
World = Matter.World,
Vertices = Matter.Vertices,
Bodies = Matter.Bodies;

let engine = Engine.create(),
    world = engine.world;

// Setup when init() is called from a button press
function init() {
    let width = window.innerWidth;
    let height = Math.max(
        document.body.scrollHeight, document.documentElement.scrollHeight,
        document.body.offsetHeight, document.documentElement.offsetHeight,
        document.body.clientHeight, document.documentElement.clientHeight
    );

    let wrapper = document.querySelector('.wrapper-medium'),
        text = document.querySelector('p'),
        pic = document.getElementById('trigger');

    let wrapperBounds = wrapper.getBoundingClientRect(),
        textBounds = text.getBoundingClientRect(),
        picBounds = pic.getBoundingClientRect();

    let wrapWidth = wrapperBounds.width,
        textTop = textBounds.top + (575 / 2) + window.scrollY,
        picMiddle = (picBounds.bottom + picBounds.top) / 2;

    let picRatioX = pic.clientWidth/pic.naturalWidth,
        picRatioY = pic.clientHeight/pic.naturalHeight;

    // Some random force
    let xforce = (Math.random() * 8) - 4,
        yforce = (Math.random() * 8) - 4;

    engine.events = {};
    World.clear(engine.world);
    Engine.clear(engine);

    engine = Engine.create();

    let render = Render.create({
        element: document.querySelector('#matter'),
        engine: engine,
        options: {
            wireframes: false,
            background: 'transparent',
            width: width,
            height: height
        }
    });

    // Custom object
    let facePath = Vertices.fromPath('387 30 202 11 92 63 67 259 169 472 250 489 347 440 440 136');
    Vertices.scale(facePath, picRatioX, picRatioY);

    let face = Bodies.fromVertices(width / 2, picMiddle, facePath,
    {
        density: 0.0025,
        restitution: 0.75,
        friction: 0.75,
        force: { x: xforce, y: yforce },
        render: {
            sprite: {
                texture: '../assets/images/profile-small.png', // set texture here
                xScale: picRatioX,
                yScale: picRatioY,
            }
        }
    }
    );

    // Add objects
    World.add(engine.world, [
        Bodies.rectangle(width / 2, height + 50, width, 100, {
            isStatic: true
        }),
        Bodies.rectangle(width / 2, -50 - window.scrollY, width, 100, {
            isStatic: true
        }),
        Bodies.rectangle(-50, height / 2, 100, height, {
            isStatic: true
        }),
        Bodies.rectangle(width + 50, height / 2, 100, height, {
            isStatic: true
        }),
        Bodies.rectangle(width / 2, textTop, wrapWidth, 575, {
            isStatic: true,
            friction: 0.75,
            render: {
            visible: false
            }
        }),
        face,
    ]);
    Engine.run(engine);
    Render.run(render);
}

Firefox tends to have worse performance than Chrome for this, but it shouldn't be that bad. Does it have the same problem even just in wireframe mode (without sprites)?
Also it looks like your canvas is scaled to the screen with width = window.innerWidth, it could be possible that your screen resolution is causing some issues?

Yes, I'm on a retina screen. Is there a way to simply rescale the canvas (split by half) if the detected resolution is above a certain point?

You do it upon creating the render
Render.create({options:{width: 300, height:200}}

I think technically it already will be half retina by default, but as @bouraqadi mentioned you can just pass some options to set the size as needed to make it smaller, then in CSS you can set the canvas to a larger size, or 100% etc.

Hmm, I think it's passable. I do have one more question - concerning sleep detection. It seems that Chrome is detecting a sleep state when an object comes to rest while Firefox is not? Any thoughts on this?

Hi Liam, firstly thank you for such an awesome library! 👍  Not sure whether to open a new issue or revisit this one, but we're having issues with performance in Firefox. I've made a codepen and turned on debug mode:
In Chrome and Safari the fps stays at 60 but Firefox seems to really struggle, sometimes almost dropping to half that as the number of bodies increases. I tested it in wireframe mode as per your suggestion above and sure enough Firefox behaved. So I guess my question is is there a particular reason why Firefox struggles when using sprites?

@tommers-walker sorry I'd missed this earlier - interested to know if you did get to the bottom of it?
The way sprites work is pretty straightforward, just drawing an image to canvas in the usual way, so it could just be that Firefox has trouble with that so not sure if there's something I can fix.
If it is just a browser limitation then you may need to look into alternatives like pixi.js which use WebGL and GPU instancing and might be better (but I'm not sure).


Pod fails to launch with 'pod has unbound PersistentVolumeClaims'

What did you do?
I ran a helm install timescale timescale/timescaledb-single -f timescale-values.yaml where timescale values are here. When I did this, I got an error in the timescale pod where its stuck with 'pod has unbound PersistentVolumeClaims'.
Did you expect to see some different?
Yes, pod should launch without issue.
Environment
Ubuntu server 22.04 with a 1.8TB LVM mounted on /home/warren/storage-mount
** Which helm chart and what version are you using? **
> helm search repo timescale
NAME                           	CHART VERSION	APP VERSION	DESCRIPTION
timescale/timescaledb-multinode	0.8.0        	           	TimescaleDB Multinode Deployment.
timescale/timescaledb-single   	0.23.0       	           	TimescaleDB HA Deployment.
timescale/avalanche            	0.6.0        	           	A Helm chart run avalanche for benchmarking Pro...
timescale/promscale            	14.4.2       	0.16.0     	Promscale Connector deployment
timescale/tobs                 	17.21.0      	           	A Helm chart for tobs, The Observability Stack ...

** What is in your values.yaml ? **
Its the same as the default with the exception being a different mount path and data volume sizes. See this gist.
** Kubernetes version information: **
Client Version: version.Info{Major:"1", Minor:"25", GitVersion:"v1.25.4", GitCommit:"872a965c6c6526caa949f0c6ac028ef7aff3fb78", GitTreeState:"clean", BuildDate:"2022-11-09T13:36:36Z", GoVersion:"go1.19.3", Compiler:"gc", Platform:"linux/amd64"}
Kustomize Version: v4.5.7
Server Version: version.Info{Major:"1", Minor:"24", GitVersion:"v1.24.7+rke2r1", GitCommit:"e6f35974b08862a23e7f4aad8e5d7f7f2de26c15", GitTreeState:"clean", BuildDate:"2022-10-13T18:58:02Z", GoVersion:"go1.18.7b7", Compiler:"gc", Platform:"linux/amd64"}

** Kubernetes cluster kind: **
Rancher RKE2

** Kubernetes cluster kind: **
Rancher RKE2

The issue states you are using both Kind and RKE?  Which are you using to bootstrap the cluster?  Are you saying you're using Docker from Rancher Desktop and then using Kind to standup a local cluster, or are you using RKE from Rancher Desktop?
Can you post a values.yaml of just your changes?


fast-url-parser is not actively maintained and has bugs

Describe the bug
puny-code was deprecated in node.js 21.5.0 which is used as dependency of fast-url-parser in your project. Since fast-url-parser is not actively maintained it should be replaced by alternative.
To Reproduce Steps to reproduce the behavior:
Run any project with your package as a dependency mainly @graphql/tools

Expected behavior
no warnings should be shown.
Environment:

OS: Windows
package-name...: fast-url-parser
NodeJS: 21.5.0

Additional context

Could you be more specific? Which bugs do they have? Where do we use it in graphql-tools and how do you get affected?

They have punycode in their project as a dependency which was deprecated in Node.js so all the project with fasturl as internal dependency show deprecation warning. It should be corrected but the project maintainers don not maintain the fasturl project now. I was using project with graphql/tools as dependency and then I found that this project uses fast-url as dependency.

I understand so it is not the bugs but punycode warning.
We have removed punycode indirect dependency with our fork with this PR;
https://github.com/ardatan/whatwg-node/pull/990
Could you make sure you are using the latest packages?

Closing the issue due to the lack of response.


[GHA][LBT] Fix regex in parsing commit message

Motivation
There is an issue with the regex parser in the current LBT workflow Actions.  The original regex used \w and missed the "-".
Test Plan
Canary with parent commit and verify parsing issue https://github.com/sausagee/libra/runs/465949511?check_suite_focus=true
Canary with this commit and verify no issue https://github.com/sausagee/libra/runs/465950770?check_suite_focus=true

@bors-libra delegate+

:v: @sausagee can now approve this pull request

@bors-libra r=andll

:pushpin: Commit e7908b7 has been approved by andll

:hourglass: Testing commit e7908b749aedfef8b8cac4261724f870833818b4 with merge cf7a95af5e2c4fb96e0a0073102f32481669bf7a...

@bors-libra r-

:sunny: Test successful - checks-circle_commit_workflow
State: approved= try=False

@bors-libra  r+

:pushpin: Commit e7908b7 has been approved by runtian-zhou

@bors-libra r=runtian-zhou

:bulb: This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: #2686

:pushpin: Commit e7908b7 has been approved by runtian-zhou

@bors-libra retry

:hourglass: Testing commit e7908b749aedfef8b8cac4261724f870833818b4 with merge d5269a41647fe77e133625f42d0c51c8651bf57f...

:broken_heart: Test failed - checks-circle_commit_workflow

:sunny: Test successful - checks-circle_commit_workflow
Approved by: runtian-zhou
Pushing d5269a41647fe77e133625f42d0c51c8651bf57f to master...


make SamsaGlyph.prototype.svg dynamically sized and responsive

update SamsaGlyph.prototype.svg function so the exported SVG's width and height is set dynamically with font.unitsPerEm
this helps with fonts with non-standard canvas size.
use viewBox instead of width and height to make the svg responsive

@Lorp  scaled by 1000/unitsPerEm by a group makes sense to me, in that case, the SVG width height should be hardcoded 1000. However I don't see the group being scaled when I call the glyph.decompose(tuple).svg(). I made a simplified Codepen to demostrade my issue. My test font unitsPerEm is 240, and the icon is rendered based on the unitsPerEm inside the 1000 by 1000 svg
https://codepen.io/wentin/pen/eYeEZww?editors=1011

The svg() method has an optional style argument. Try supplying {transform: "scale(${1/font.unitsPerEm})"}.
SamsaGlyph.prototype.svg = function (style={}) {
...


Binance: Add Currency (Question)

Hi all,
I want trade with altcoins but there are not all are implemented, so how can I add a Currency? I tried using createCurrency method in Currency class but is private
Thanks

Currency.getInstance & Currency.getInstanceNoCreate

getInstance & Currency.getInstanceNoCreate
/** Returns the Currency instance for the given currency code only if one already exists. */
I want to create a new Currency that not exists, for example MATIC

Currency matic = Currency.getInstance("MATIC");  // no obvious, but that will do it

You are right, thank u

You can also add the currencies to XChange via a pull request if you'd like to.


Store, use and restore any existing onPreRenderLayer function

Fixes #7150
This change fixes the reported issue by

Storing any existing onPreRenderLayer function
Calling that function as well as performing the function provided by the outliner
Restoring the old function when the outliner is deactivated

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

yep I agree with @Maksims here completely.

While I cannot disagree about with the comment about only having a single callback being the real issue here that would be a breaking change so how do we solve this issue?

Let me add events in addition to existing callbacks over the next few days. This way people that depend on callbacks can keep using them. And we'll also have events, and switch internal code / scripts to use those.

Thank you @mvaligursky, that would be much appreciated.


Adding JCSMP client channel reconnect properties.

Added following 4 properties that control auto reconnect behaviour:

ConnectRetries
ReconnectRetries
ConnectRetriesPerHost
ReconnectRetriesWaitInMillis

Suggestions have been completed in 2 commits. In 2nd commit I reworded the description for the reconnect properties. Also, there was a copy and paste error on the license txt in the SolaceJavaProperties.java file from the original author, so I fixed that as well.

Thanks Dishant.


cherry-pick support decimal256 for parquet reader

Proposed changes
pick pr: https://github.com/apache/doris/pull/41526

run buildall


[BUG] Product item not properly given when customer has full inventory

(2.2.0-BETA)
A mod on our server just sent me video footage of the following scenario.
Customer's inventory is full. One of the slots is 2 diamonds. The cost of the trade he's attempting to perform is 1 diamond. When clicking the sign, nothing happens as expected - no space. The customer then drops 1 diamond, so they now only have 1 diamond in their inventory. The trade "goes through" - the diamond is taken from their inventory, arrives in the chest, an item is taken from the chest, but no item is delivered to the customer's inventory.
There appears to be a check that ensures that the player would have inventory space once the diamond is taken, but perhaps there is an issue with the order of the transaction.

This is already fixed for the next version, thank you for the report!

Ah, good to know. Sorry if it was a duplicate - I looked through the closed issues but didn't seem to find anything that matched.


Index database keys from int to long

replaced DataSourceArray.java with DataSourceLongArray.java to avoid the type casting from long to int and back (which may cause problems in the future)
added functionality for automatic conversion when using a database from an old kernel version
minor cleanup: removed unused flushDangerously method and clone method

let's evaluate the impact before we merge.


Make absolutely sure we don't need integrated management of digitization requests?

@caseyedavis12 : Could you give us a solid confirmation that email for digitization requests is sufficient? ... In particular, talking with Drew, it sounds like the system we have on OV right now was in some sense a grant deliverable, and I just want to be sure no one asks us down the road where that feature is. Thanks.

:+1: for styling as a button

If you all think it is a good idea, we could create a static page describing the costs associated with requesting digitization and transcripts.

I like the idea of a landing page with a more verbose explanation. But I'm not sure if it would work as a static page (like an About page). It would need to receive the record ID as a parameter, and then add that param to any mailto link we provide.

Actually, a separate page doesn't scare me that much. Or maybe a modal on the same page?
Let's get feedback from Mike (regarding the longer email) before we go too far towards designing this.
(We should also try to keep this in our minds as a nice to have, and not something that would block release.)

This is the current automatically sent digitizing email for people requesting stuff on OV:
Hello,
Thank you for your interest in the digitization of WGBH Open Vault artifact <TITLE AND URL OF ARTIFACT HERE>

With Open Vault, we've added the ability to
request digitization of transcripts, audio or video.  If you agree to the pay
the digitization fee and we're able to (rights pending), WGBH will make
available the digitized audio, video and/or transcript for public access on the
Open Vault website.

If you would like to pay for the cost of digitizing, or would like more information, please email<EMAIL_ADDRESS>and we will then provide you
with a more accurate estimation of what the cost will be.

If you wish to withdraw your request for digitization of this asset,
you may do so via your profile page on Open Vault.  If we receive no
response from you for more information regarding your requests within 30 days, the requests will be
withdrawn from your profile.

If you wish for information about licensing footage from a WGBH program please contact
WGBH Stock Footage Sales at<EMAIL_ADDRESS>or<PHONE_NUMBER>.

If you wish to view WGBH material that is not available on Open Vault, you may schedule an appointment to visit the WGBH Media Library and Archives department in Boston, Massachusetts by emailing<EMAIL_ADDRESS>
Thank you for your interest in WGBH Open Vault.  Please let us know if you
have any questions.

WGBH Media Library and Archives
<EMAIL_ADDRESS>One Guest St.
Boston, MA 02135

The current system of having users login and us being able to manage the digitization requests and status was not a grant deliverable.
Using the contact us link on a non-digitized page as a catch all for requests about an asset should be fine.  It's really no different to how I'm interacting with users already.

@muraszko: I agree, let's stick with the current process.

modal with email links is merged. Closing this.


CoE Core Components for Teams... pagination errors

Describe the bug
When attempting to turn on / run the CLEANUP - Admin | Sync Template v3 (Check Deleted) Flow, we received a pagination error.  We had to edit EVERY list action in the flow in order to save it.  This was for a client who is still on the Flow Plan 2 / Power Apps plan 2

Component (please tell us which flow or app you are experiencing issues with):

Solution [e.g. Core, Nurture]  Core (Teams)
Version [e.g. 1.29] 1.992
App or Flow [e.g. Sync Template (v2)] CLEANUP - Admin | Sync Template v3 (Check Deleted)

To Reproduce
Steps to reproduce the behavior:

Go to '...'  Attempt to turn on
Click on '....'
Scroll down to '....'
See error

Expected behavior
The Flow should allow a threshold of 100000
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

We have moved to a new dedicated repository for the CoE Starter Kit, and issues here will no longer receive attention. Please raise your issues here from now on:
https://github.com/microsoft/coe-starter-kit/issues


Process only increasing block numbers

📝 Summary
Instead of processing anything that comes from the CL we only process increasing block numbers.
💡 Motivation and Context
I've seen some really crazy sequences from the CL (eg: repeated block numbers, going back) and the builder is not really suited right now to build simultaneous blocks (the good one and some trash).

✅ I have completed the following steps:

[X] Run make lint
[X] Run make test
[ ] Added tests (if applicable)

I am not sure about this one, in particular rejecting "the same block number".
IIRC CL sends 2 events per slot so it can be the case that the second one is actually "correct".
Also, is this place in the code is actually a problem? The way it works is that it just sends all events to the builder and then builder only builds on the events that have parent hash that reth hash synced. So it kind of sorted out already, even thought not directly.

I think we can have any parent (it's just a historic block) but the real failure occurs on the root hash which, from what I undestand, can only be computed on the head. But we don't do root hash until we bid and that's too close to the slot start.
That added to the fact that I think the simulations are not really working for multiple parallel block building might hurt the good block.
Also, I was aiming to remove noisy logs.
That said, all of this comes from looking logs (it's not that easy to reproduce) so if you feel this is too risky I can leave it out.

I think its too risky but without good argument, just on the feel level.
Also, we do wait for the parent header to be correct before even starting the block building. Maybe we can make that check harder to pass for events that we can't even build on.


Paper matching setup: check the SAC assignments are deployed when running the AC setup

Validate that SAC assignments edges when setting up the AC matching setup.
The steps could be:

Check if compute conflicts is enabled
Check if the venue has SAC enabled
Check if there are at least one SAC Assignment edge
If result is empty then throw an exception that should be shown in the paper matching status comment

You can use the ICML conference test to test this. The only issue that I can see if that SAC assignments must be deployed before enabling the AC bidding because we run this for bidding too.
Another option is to check if there are SAC proposed assignments then there should be SAC assignments too. This means if they ran the matching but they haven't deployed anything yet then we should throw the error, thoughts @celestemartinez ?

@melisabok the way this is worded, it looks like this should not be done in the preprocess function right, but right before SAC conflicts are transferred to ACs?

it would be great to do it in the preprocess function.
If it is too expensive, we can throw an error in the matching setup and post the error as a comment.


Add pprof endpoints if enabled in configuration

To help troubleshoot future leaks in production.

I guess that's better than rebuilding... Ok will test it. The GET feels a bit awkward compared to using mux handler, but that's definitely a nit. Let me test that.

I guess that's better than rebuilding... Ok will test it. The GET feels a bit awkward compared to using mux handler, but that's definitely a nit. Let me test that.

The method (GET) pattern is new in 1.21 i think it was. Docs: https://pkg.go.dev/net/http#ServeMux


Reduced padding between contact name and message bubble

Added horizontalTitleGap for each skin
#2119

@tneotia I can fix that as well. The horizontal tile spacing was indeed too large compared to iMessage, so regardless it fixes something

OK thanks, I would just check and make sure that compared to google messages and samsung messages the spacing isn't off. We don't want to use the iMessage spacing difference for the other 2 skins if they are different

Closed because I suck at git and don't know how to revert the files. Going to create another branch and do new PR


[Cloudit] Update Cloudit API version to v5.0

클라우드잇 API 버전 변경 (v4.0 -> v5.0)

resolving conflicts

resolving conflicts