[Question] Failed to determine k3s control plane endpoint IP or port for Linux node type

Describe scenario
Hi, I'm trying to deploy AKS EE in my laptop( Windows 10 Enterprise 19045.3803).
I use New-AksEdgeDeployment -JsonConfigFilePath .\aksedge-config.json command in PowerShell 5.1 in the offline way.
Everything seems to be going well, but when it comes to AksEdge - copying Kubeconfig into the host. step, it throw an exception:
- Warning: Could not determine proper endpoint IP for the node's cluster
- Failed to determine k3s control plane endpoint IP or port for Linux node type(s) (AksEdge.psm1: line 5735)
I have posted the installation log and my  aksedge-config.json

Checking host for required features
Checking the status of 'Microsoft-Hyper-V'
Checking the status of 'Microsoft-Hyper-V-Management-PowerShell'
Checking the status of 'Microsoft-Hyper-V-Hypervisor'
Checking the status of 'OpenSSH.Client*'
Checking power management settings of the Host
Checking HNS version of the Host
Checking OpenSSH version of the Host
Checking Nested Virtualization of the Host

[01/11/2024 17:57:03] All required host features are installed
[01/11/2024 17:57:03] Attention - Azure Arc properties are specified. These will not be used. The cluster currently needs to be connected in a separate step after deployment via Connect-AksEdgeArc
[01/11/2024 17:57:03] Validating AksEdge network parameters...
[01/11/2024 17:57:03] *** 0 errors found in the deployment configuration.
[01/11/2024 17:57:16] Checking the required certificates for offline installation...
[01/11/2024 17:57:16] Verifying Host Requirements for Linux node(s)

Verifying host requirements for selected configuration (77.5 GB disk size, 16884 MB memory, 8 CPUs)

[01/11/2024 17:57:16] Verifying Host OS can support requested configuration
[01/11/2024 17:57:16] Verifying required storage, RAM and number of cores are available                                                                                - Drive 'C:' has 213 GB free

A minimum of 77 GB disk space is required on drive 'C:'
Host has 43789 MB free memory
A minimum of 16884 MB memory is required
Host has 16 CPU cores
A minimum of 8 CPU cores is required
Verifying certificate requirements for AKS-EE
Starting Internet Disabled Deployment

[01/11/2024 17:57:17] AksEdge - deploying a new Linux single machine k3s cluster
[01/11/2024 17:58:27] Creating single machine cluster hcs network                                                                                - AksEdge - private network carved:                                                                                Name  : ip4PrefixLength                                                                                Value : 24
Name  : LinuxVmIp4Address
Value : <IP_ADDRESS>
Name  : ServiceIPRangeStart
Value : <IP_ADDRESS>
Name  : ip4GatewayAddress
Value : <IP_ADDRESS>
Name  : ip4Subnet
Value : <IP_ADDRESS>
Name  : WindowsVmIp4Address
Value : <IP_ADDRESS>
Name  : ServiceIPRangeEnd
Value : <IP_ADDRESS>
[01/11/2024 17:58:28] Deploying AKS Edge Essentials - K3s
[01/11/2024 17:58:28] Step 1: Preparing host for AKS Edge Essentials - K3s
[01/11/2024 17:58:28] Enabling Microsoft Update. This will allow AKS Edge Essentials - K3s to receive updates.

Microsoft Update is enabled.

[01/11/2024 17:58:28] Checking for virtual switch with name 'aksedgesw-int'

The virtual switch 'aksedgesw-int' of type 'Internal' is present

[01/11/2024 17:58:29] Associating wssdagent service with nodectl
[01/11/2024 17:59:03] Creating vnet (name: aksedgesw-int)

Skipping DNS, not searching for DNS server

[01/11/2024 17:59:03] Deploying AKS Edge Essentials - K3s
[01/11/2024 17:59:03] Step 1: Skipped host preparation
[01/11/2024 17:59:03] Step 2: Verifying AKS Edge Essentials - K3s installation
[01/11/2024 17:59:03] Verifying installation

Verifying whether Hyper-V is enabled and functional
Hyper-V core services are active
Verifying expected Windows host binaries
Verifying expected Linux VM image
Testing for ssh key
Testing for wssdagent service
Testing if wssdagent is running
Testing if container resource is provisioned
Testing if vnet resource 'aksedgesw-int' is provisioned

[01/11/2024 17:59:18] Step 3: Runtime configuration complete. Creating virtual machine
[01/11/2024 17:59:18] Extracting Linux VHD
[01/11/2024 17:59:24] Setting dynamically expanding virtual hard disk maximum size to 90.4 GB

Creating storage vhd (file: AzureIoTEdgeForLinux-v1-ledge)
Creating vnic (name: cnsl71t97g3-ledgeInterface)
Instantiating virtual machine (name: cnsl71t97g3-ledge)
Virtual machine successfuly instantiated

[01/11/2024 17:59:52] Virtual machine created successfully.
[01/11/2024 18:00:04] Successfully created virtual machine
[01/11/2024 18:00:04] Virtual machine hostname: cnsl71t97g3-ledge
[01/11/2024 18:00:04] Testing SSH connection...
[01/11/2024 18:00:59] ...successfully connected to the Linux VM
[01/11/2024 18:00:59] Querying IP and MAC addresses from virtual machine (cnsl71t97g3-ledge)

Virtual machine MAC: 00:15:5d:7b:1e:ec
Virtual machine IP : <IP_ADDRESS> retrieved directly from virtual machine
Please check your DNS configuration to ensure Internet connectivity. Refer to https://aka.ms/aks-edge/dns for more details.

[01/11/2024 18:01:00] Deployment successful
[01/11/2024 18:01:00] Initializing kubernetes runtime in Linux node.

Waiting for Kubernetes node (cnsl71t97g3-ledge) to reach condition Ready, time remaining = 300 seconds
Kubernetes node (cnsl71t97g3-ledge) reached condition Ready

**[01/11/2024 18:01:42] AksEdge - copying Kubeconfig into the host.

Warning: Could not determine proper endpoint IP for the node's cluster

[01/11/2024 18:01:43] Exception Caught!!!

Failed to determine k3s control plane endpoint IP or port for Linux node type(s) (AksEdge.psm1: line 5735)

[01/11/2024 18:01:43] Exception Caught!!!

Failed to determine k3s control plane endpoint IP or port for Linux node type(s) (AksEdge.psm1: line 5735)**

aksedge-config.json
{
"Arc": {
"ClientId": null,
"ClientSecret": null,
"ClusterName": null,
"Location": null,
"ResourceGroupName": null,
"SubscriptionId": null,
"TenantId": null
},
"DeploymentType": "SingleMachineCluster",
"Init": {
"ServiceIPRangeSize": 1
},
"Machines": [
{
"LinuxNode": {
"CpuCount": 8,
"DataSizeInGB": 68,
"MemoryInMB": 16384,
"SecondaryNetworks": [
{
"Ip4Address": null,
"Ip4GatewayAddress": null,
"Ip4PrefixLength": null,
"VMSwitchName": null
}
],
"TimeoutSeconds": 300,
"TpmPassthrough": false
}
}
],
"Network": {
"InternetDisabled": true,
"Ip4AddressPrefix": "<IP_ADDRESS>/24",
"NetworkPlugin": "flannel",
"Proxy": {
"Http": null,
"Https": null,
"No": "localhost,<IP_ADDRESS>/8,<IP_ADDRESS>/16,<IP_ADDRESS>/16,<IP_ADDRESS>/16,<IP_ADDRESS>/16,<IP_ADDRESS>/12,<IP_ADDRESS>/16,.svc"
},
"SkipAddressFreeCheck": true,
"SkipDnsCheck": false
},
"SchemaVersion": "1.9",
"User": {
"AcceptEula": true,
"AcceptOptionalTelemetry": true,
"VolumeLicense": {
"EnrollmentID": null,
"PartNumber": null
}
},
"Version": "1.0"
}

Any solution on this one?
I got the same issue which failed to copy the Kubeconfig, the cmd Get-AksEdgeKubeConfig returns the same error
[05/15/2024 09:29:30] AksEdge - copying Kubeconfig into the host.

 - Warning: Could not determine proper endpoint IP for the node's cluster

[05/15/2024 09:29:32] Exception Caught!!!

 - Failed to determine k3s control plane endpoint IP or port for Linux node type(s) (AksEdge.psm1: line 5829)

[05/15/2024 09:29:32] Exception Caught!!!

 - Failed to determine k3s control plane endpoint IP or port for Linux node type(s) (AksEdge.psm1: line 5829)

Any solution on this one? I got the same issue which failed to copy the Kubeconfig, the cmd Get-AksEdgeKubeConfig returns the same error
[05/15/2024 09:29:30] AksEdge - copying Kubeconfig into the host.

 - Warning: Could not determine proper endpoint IP for the node's cluster

[05/15/2024 09:29:32] Exception Caught!!!

 - Failed to determine k3s control plane endpoint IP or port for Linux node type(s) (AksEdge.psm1: line 5829)

[05/15/2024 09:29:32] Exception Caught!!!

 - Failed to determine k3s control plane endpoint IP or port for Linux node type(s) (AksEdge.psm1: line 5829)

Seems like this issue only exists in k3s, when I switched to use k8s, I can config sucessfully.

Is there any update to this? I am getting same error it happened after rebooting machine.

Quick update - Actively working on this, sincere apologies for the delay.

I was able to find a fix/workaround.


Is there interest in a Docker-based setup?

Hey 👋 A while ago I opened https://github.com/rails/rails/pull/40216. It added an alternative development environment based on Docker. It got closed with the reason that they're not interested in maintaining that in the official repository.
Would it be of interested here? I'd be happy to port it over and maintain it for what it's worth. 🙂

Hi @kevinsjoberg, I've built something similar in the past and recently updated it. Is this something you wanted to build? https://github.com/meinac/rails-dev-docker-compose

Hi @kevinsjoberg, I've built something similar in the past and recently updated it. Is this something you wanted to build? https://github.com/meinac/rails-dev-docker-compose

@meinac tks!
for mac M1 users: we need use mariadb instead of mysql, because mysql docker image still not working in arm =/

I'm setting up rails-dev-box on a new M1 Macbook, and it seems like VirtualBox won't run on a non-AMD64 architecture.
This was easy to get around using the solution detailed here (I used Ubuntu 20.4 instead of 18.4, which ships with a more recent Ruby version): https://dev.to/taybenlor/running-vagrant-on-an-m1-apple-silicon-using-docker-3fh4
But unless there's an easy way to run VirtualBox on an M1 Mac, I think rails-dev-box needs to provide an alternate/universal dev environment. Migrating to Docker might make sense at this juncture.

I believe my Docker setup still works for all use cases. I could give it some love if there's an interest. 🙂

Both @meinac and @kevinsjoberg's projects feel like good starting points.
A few considerations:

Should services like memcached and redis live inside the rails container, or be defined separately in docker-compose.yml? Note that activesupport/test/cache/stores/redis_cache_store_test.rb expects a redis endpoint of redis://localhost:6379/0, whereas a standard docker setup might use redis://redis:6379/0

Should the rails container run on alpine or debian/bullseye? For debian, I think the current list of dependencies would be:

autoconf
default-mysql-client
ffmpeg
git
imagemagick
libncurses5-dev
libtool
libxml2
libxml2-dev
libxslt1-dev
libvips
memcached (or libmemcached-tools if running memcached as a separate service)
mupdf-tools
mupdf
nodejs
poppler-utils
postgresql-client
rabbitmq-server
redis (or redis-tools if running redis as a separate service)
sqlite3
yarn

Lastly, another approach here: https://github.com/yahonda/multipass-rails-dev-box

Closing this issue because Rails provides Docker based Rails development environment. https://github.com/rails/rails-dev-box/issues/179#issuecomment-1887380114


Wrong percent-encoding for reserved URI character

As defined in the RFC (https://tools.ietf.org/html/rfc3986#section-2.2) the character Apostrophe "'" is a reserved character and therfore should not be percent-encoded when sending a http request.
I went into an issue sending a request with the following path: /api/Things('1234')
because It was encoded into /api/Things(%271234%27) which cannot be handled by the backend.
 So encoding the Apostrophe is definetly a bug.
Btw the http.request method does not percent-encode the Apostrophe.

I just ran into this as well. the request module is using node's url module to parse the input url. if you pass in an object for the uri/url parameter, it won't do that. So you can parse the url on your end and then replace the encoded apostrophes
    uri = require('url').parse url
    uri.pathname = uri.pathname.replace '%27', "'"
    uri.path = uri.path.replace '%27', "'"
    uri.href = uri.href.replace '%27', "'"
    request {uri: uri}, (err, resp, body) ->


fix(actions) - expose correct variable name for branch name

This pull request

[x] fixes envvar name exposed if workflow was triggered via workflow_run event (github/pull-request/add-label-based-on-branch-name)

Thank you, @jaymecd!


[Bug] Model compilation with CUTLASS on Jetson Orin AGX

🐛 Bug
When compiling a model on jetson orin agx (probably applies to jetson orin nano), there is an issue with on model conversion when compiling CUTLASS kernels. The code is breaking somewhere between 9bf5723945ca6016a50eedffae295390b7c11ac6 and 5dc809efb894640c494066b0c07ff0a69b8ee481.
To Reproduce
Steps to reproduce the behavior:

Checkout (5dc809efb894640c494066b0c07ff0a69b8ee481)
Compile with the flags from here
Install tvm python wheel
Run build.py for a model (tried with llama-2-7b-chat-hf) python3 build.py --artifact-path <path_to_models> --model Llama-2-7b-chat-hf --quantization q4f16_1 --max-seq-len 4096 --target cuda --use-cuda-graph --use-flash-attn-mqa --use-cache 0

Result:
Traceback (most recent call last):
  File "build.py", line 4, in <module>
    main()
  File "/tmp/mlc_llm/build.py", line 43, in main
    core.build_model_from_args(parsed_args)
  File "/tmp/mlc_llm/core.py", line 903, in build_model_from_args
    mod = mod_transform_before_build(mod, param_manager, args, model_config)
  File "/tmp/mlc_llm/core.py", line 635, in mod_transform_before_build
    mod = tvm.transform.Sequential(
  File "/usr/local/lib/python3.8/dist-packages/tvm/ir/transform.py", line 238, in __call__
    return _ffi_transform_api.RunPass(self, mod)
  File "tvm/_ffi/_cython/./packed_func.pxi", line 332, in tvm._ffi._cy3.core.PackedFuncBase.__call__
  File "tvm/_ffi/_cython/./packed_func.pxi", line 263, in tvm._ffi._cy3.core.FuncCall
  File "tvm/_ffi/_cython/./packed_func.pxi", line 252, in tvm._ffi._cy3.core.FuncCall3
  File "tvm/_ffi/_cython/./base.pxi", line 182, in tvm._ffi._cy3.core.CHECK_CALL
  File "/usr/local/lib/python3.8/dist-packages/tvm/_ffi/base.py", line 481, in raise_last_ffi_error
    raise py_err
  File "tvm/_ffi/_cython/./packed_func.pxi", line 56, in tvm._ffi._cy3.core.tvm_callback
  File "/usr/local/lib/python3.8/dist-packages/tvm/contrib/cutlass/build.py", line 1050, in compile_cutlass_module
    c_source_module.export_library(lib_path, workspace_dir=tmp_dir, **compile_options)
  File "/usr/local/lib/python3.8/dist-packages/tvm/runtime/module.py", line 624, in export_library
    return fcompile(file_name, files, **kwargs)
  File "/usr/local/lib/python3.8/dist-packages/tvm/contrib/cc.py", line 87, in create_shared
    _linux_compile(output, objects, options, cc, compile_shared=True)
  File "/usr/local/lib/python3.8/dist-packages/tvm/contrib/cc.py", line 303, in _linux_compile
    raise RuntimeError(msg)
RuntimeError: Compilation error:

# ... some warning and notes on redefinitions of LOG and DCHECK ...

./tmp/lib0.cu(78): error: identifier "$" is undefined

./tmp/lib0.cu(78): error: too few arguments for class template "AttentionKernel"

./tmp/lib0.cu(78): error: expected a ";"

./tmp/lib0.cu(85): warning: parsing restarts here after previous syntax error

./tmp/lib0.cu(87): error: name followed by "::" must be a class or namespace name

./tmp/lib0.cu(87): error: a class or namespace qualified name is required

./tmp/lib0.cu(87): error: global-scope qualifier (leading "::") is not allowed

./tmp/lib0.cu(87): error: expected a ";"

./tmp/lib0.cu(88): error: identifier "p" is undefined

./tmp/lib0.cu(92): error: name followed by "::" must be a class or namespace name

./tmp/lib0.cu(94): error: name followed by "::" must be a class or namespace name

./tmp/lib0.cu(95): error: identifier "$" is undefined

./tmp/lib0.cu(95): error: expected a ")"

./tmp/lib0.cu(96): error: expected a ")"

./tmp/lib0.cu(145): error: cannot deduce "auto" type

./tmp/lib0.cu(146): error: name followed by "::" must be a class or namespace name

./tmp/lib0.cu(146): error: a class or namespace qualified name is required

./tmp/lib0.cu(146): error: expected a ")"

./tmp/lib0.cu(148): warning: variable "once" was declared but never referenced

./tmp/lib0.cu(155): error: name followed by "::" must be a class or namespace name

./tmp/lib0.cu(251): error: identifier "$" is undefined

./tmp/lib0.cu(251): error: too few arguments for class template "AttentionKernel"

./tmp/lib0.cu(251): error: expected a ";"

./tmp/lib0.cu(258): warning: parsing restarts here after previous syntax error

./tmp/lib0.cu(260): error: name followed by "::" must be a class or namespace name

./tmp/lib0.cu(260): error: a class or namespace qualified name is required

./tmp/lib0.cu(260): error: global-scope qualifier (leading "::") is not allowed

./tmp/lib0.cu(260): error: expected a ";"

./tmp/lib0.cu(261): error: identifier "p" is undefined

./tmp/lib0.cu(265): error: name followed by "::" must be a class or namespace name

./tmp/lib0.cu(267): error: name followed by "::" must be a class or namespace name

./tmp/lib0.cu(268): error: identifier "$" is undefined

./tmp/lib0.cu(268): error: expected a ")"

./tmp/lib0.cu(269): error: expected a ")"

./tmp/lib0.cu(318): error: cannot deduce "auto" type

./tmp/lib0.cu(319): error: name followed by "::" must be a class or namespace name

./tmp/lib0.cu(319): error: a class or namespace qualified name is required

./tmp/lib0.cu(319): error: expected a ")"

./tmp/lib0.cu(321): warning: variable "once" was declared but never referenced

./tmp/lib0.cu(328): error: name followed by "::" must be a class or namespace name

36 errors detected in the compilation of "./tmp/lib0.cu".

Command line: nvcc -shared -o ./tmp/cutlass.o ./tmp/lib0.cu -c -DCUTLASS_ENABLE_TENSOR_CORE_MMA=1 -gencode=arch=compute_80,code=[sm_80,compute_80] -DNDEBUG -Xcompiler=-fPIC -Xcompiler=-Wconversion -Xcompiler=-fno-strict-aliasing -Xcompiler=-fvisibility=hidden -O3 -std=c++17 -I/usr/local/lib/python3.8/dist-packages/tvm/contrib/cutlass/../../3rdparty/cutlass/include -I/usr/local/lib/python3.8/dist-packages/tvm/contrib/cutlass/../../3rdparty/cutlass/tools/util/include -I/usr/local/lib/python3.8/dist-packages/tvm/contrib/cutlass/../../3rdparty/cutlass/examples/41_fused_multi_head_attention -I/usr/local/lib/python3.8/dist-packages/tvm/contrib/cutlass/../../3rdparty/cutlass/../cutlass_fpA_intB_gemm -t 12 -I/tmp/mlc-llm3rdparty/tvm/include -I/tmp/mlc-llm3rdparty/tvm/3rdparty/dlpack/include -I/tmp/mlc-llm3rdparty/tvm/3rdparty/dmlc-core/include

Expected behavior
Expected behaviour is that the model compiles with the appropriate cutlass kernels compiled for the .so library.
Environment

Platform (e.g. WebGPU/Vulkan/IOS/Android/CUDA): CUDA
Operating system (e.g. Ubuntu/Windows/MacOS/...): Linux (5.10.104-tegra)
Device (e.g. iPhone 12 Pro, PC+RTX 3090, ...)

Additional context

maybe the link could help you.
https://www.jetson-ai-lab.com/tutorial_llava.html


Add option for filtering duplicate reads

Closes #948

@achevali Back to you.  Unless there is a good reason to keep the flag like it is, I would invert it.  I think it's less confusing and more readable that way.

Once comments are addressed and you've squashed, feel free to merge when tests pass.


Include LICENSE file in wheels

Although not strictly required by the license, having a copy of the license file is preferred by some groups such as Linux distros that repackage the software.  This makes sure the license is included in the wheels.  See the wheel documentation here for more information.

Coverage decreased (-0.5%) to 85.874% when pulling 7364bf9900a58d52740f887551c3c0a7f2f8b753 on toddrme2178:patch-1 into c20a588a3561f294524ce6caba80c332bbdda07e on quantopian:master.

Thanks @toddrme2178!


[FLINK-11297][docs] Add a doc link of jobmanager ha details.

Add a doc link of jobmanager ha details. This is a document change so no test needed to add.

I'm merging this change


VS2017 RC - Glitch - Wrong colorization?

I'm seeing this as well.

Fixed long ago, was related to optional arguments.


chore: move max_capacity selection to BouncerConfig

This change is

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.04%. Comparing base (693da0e) to head (88838be).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1941   +/-   ##
=======================================
  Coverage   78.04%   78.04%
=======================================
  Files          61       61
  Lines        8759     8760    +1
  Branches     8759     8760    +1
=======================================
+ Hits         6836     6837    +1
  Misses       1485     1485
  Partials      438      438

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Implemented Binary Search Tree Algorithm

@frextrite could you explain me in more details how can i do this?

@frextrite If its possible could you do it with yourself and just merge the pr?

@frextrite I changed name from --amend as you wanted

Right on track! Merging.


Time buffer for expiration of cached DAT

It may happen at edge cases that a cached DAT, which has not expired at code execution time and sending of an IDS-Message, is expired directly after, during transmission of the message, and thus at the time of the recipient of the DAT at the other Connector.
For this an additional time buffer can be added into the cached-DAT-expiration-check, so that a new DAT is requested not if directly expired but only valid for a short period of time remaining.
https://github.com/International-Data-Spaces-Association/IDS-Messaging-Services/blob/047cb0dd11d188aba95df82544b5c0a709adae44/core/src/main/java/de/fraunhofer/ids/messaging/core/daps/TokenProviderService.java#L226
Could be e.g. changed to:
final var expired = expiration == null || expiration.before(Date.from(Instant.now().plusSeconds(5)));
Which adds a time buffer of 5 sec, so if the cached DAT expires in the next 5 seconds of code execution, a new DAT will be requested instead.
Note:
Time buffer must be set in coordination with the general validity-duration of an issued DAT. In the above example, if a DAT is generally valid for only 5 seconds after issuance, a new DAT would always be requested and the cached DAT would never be used. However, in current DAPS-demo-cases, the validity of an issued DAT is one hour.

There is a way that does not depend on the validity period of the DAT.
Straight from the JWT RFC:

The "exp" (expiration time) claim identifies the expiration time on
or after which the JWT MUST NOT be accepted for processing.  The
processing of the "exp" claim requires that the current date/time
MUST be before the expiration date/time listed in the "exp" claim.
Implementers MAY provide for some small leeway, usually no more than
a few minutes, to account for clock skew.  Its value MUST be a number
containing a NumericDate value.  Use of this claim is OPTIONAL.

As a side effect, this should also cover the edge cases you are talking about :)


Incomplete Responses During High Load Stress Test

I've been conducting a stress test on your serving system to evaluate its performance under high load. However, I've encountered an issue where the response length of each request becomes progressively shorter as the load increases. This results in incomplete responses being returned by the system.
My setup is having one request arrives every 0.5 second.
Is there any parameter I need to adjust to avoid this happen?
Thanks!

Please share how to reproduce the issue and what is expected to observe.

Yes, I tried to serve Llama-2 13B on A40 with 46GB.
After I start triton server. I start multiple clients, each with one prompt. There is 0.5s between two client process, like this script (I skip the tokenizer_dir and other model parameter)

iterations=100
# Loop for the specified number of iterations
for ((i = 1; i <= $iterations; i++)); do
    # Run the Python script with the specified arguments
    python3 inflight_batcher_llm/client/inflight_batcher_llm_client.py \
    --request-output-len 1024 \
    --text "What is the average lifespan of a Llama?" \
    --request_id $i
    sleep 0.5
done

The response is good initially, but become shorted when more requests jump in.
Here is the logging.
{
    "timstamp": "2023-12-13 23:09:45.649551",
    "request_id": "7",
    "input": "What is the average lifespan of a Llama?",
    "response": "\n\nThe average lifespan of a llama is 15 to 25 years, with some individuals living up to 30 years or more. Factors such as breed, living conditions, and health can affect a llama's lifespan.",
    "output_len": 58
}
{
    "timstamp": "2023-12-13 23:09:47.531393",
    "request_id": "8",
    "input": "What is the average lifespan of a Llama?",
    "response": "\n\nThe average lifespan of a llama is 15 to 25 years, with some individuals living up to 30 years or more. Factors such as breed, living conditions, and health can affect a llama's lifespan.",
    "output_len": 58
}
{
    "timstamp": "2023-12-13 23:09:48.672811",
    "request_id": "9",
    "input": "What is the average lifespan of a Llama?",
    "response": "\n\nThe average lifespan of a llama is 15 to 25 years, with some individuals living up to 30 years or more. Factors such as breed, living conditions, and health can affect a llama's lifespan.",
    "output_len": 58
}
{
    "timstamp": "2023-12-13 23:09:49.771779",
    "request_id": "10",
    "input": "What is the average lifespan of a Llama?",
    "response": "\n\nThe average lifespan of a llama is 15 to 25 years, with some individuals living up to 30 years or more. Factors such as breed, living conditions, and health can affect a llama's lifespan.",
    "output_len": 58
}
{
    "timstamp": "2023-12-13 23:09:50.031199",
    "request_id": "11",
    "input": "What is the average lifespan of a Llama?",
    "response": "\n\nThe average lifespan of a llama is 15 to 25 years, with some individuals living up to 30 years or more. Factors such as breed, living conditions, and health can affect a llama's lifespan.",
    "output_len": 58
}
{
    "timstamp": "2023-12-13 23:09:51.193665",
    "request_id": "16",
    "input": "What is the average lifespan of a Llama?",
    "response": "\n\nThe average lifespan of a llama",
    "output_len": 11
}
{
    "timstamp": "2023-12-13 23:09:51.210134",
    "request_id": "15",
    "input": "What is the average lifespan of a Llama?",
    "response": "\n\nThe average lifespan of a llama is ",
    "output_len": 13
}
{
    "timstamp": "2023-12-13 23:09:51.210171",
    "request_id": "13",
    "input": "What is the average lifespan of a Llama?",
    "response": "\n\nThe average lifespan of a llama is 15 to",
    "output_len": 16
}
{
    "timstamp": "2023-12-13 23:09:51.216022",
    "request_id": "12",
    "input": "What is the average lifespan of a Llama?",
    "response": "\n\nThe average lifespan of a llama is 15 to 25 years, with some individuals living up to 30 years or more. Fact",
    "output_len": 35
}
{
    "timstamp": "2023-12-13 23:09:51.259440",
    "request_id": "17",
    "input": "What is the average lifespan of a Llama?",
    "response": "\n\nThe average lifespan of",
    "output_len": 8
}
{
    "timstamp": "2023-12-13 23:09:51.305968",
    "request_id": "14",
    "input": "What is the average lifespan of a Llama?",
    "response": "\n\nThe average lifespan of a llama is 1",
    "output_len": 14
}
{
    "timstamp": "2023-12-13 23:09:51.324125",
    "request_id": "18",
    "input": "What is the average lifespan of a Llama?",
    "response": "\n",
    "output_len": 1
}
{
    "timstamp": "2023-12-13 23:09:51.840256",
    "request_id": "19",
    "input": "What is the average lifespan of a Llama?",
    "response": "\n",
    "output_len": 1
}

@AmberLJC Do you still have the problem? If not, we will close it soon.


Conmon can only handle one attach session at a time

Description
Spawned from https://github.com/projectatomic/libpod/issues/580
Right now, conmon can only handle a single attach session at a time. If a new attach request comes in over the attach socket, the current session is overwritten and stops receiving output.
There is, as best I can tell, no fundamental reason for this - conmon simply doesn't have logic for handling multiple open attach FDs. This would probably complicate the callback logic for cleaning up closed connections, but otherwise it does not look too difficult.
Easiest reproducer is probably podman instead of CRI-O (the podman run/podman attach combo in the linked issue), though I imagine you can use crictl attach in two terminals to get two attach sessions against the same container.

@giuseppe Can you look into this?

PR here:
https://github.com/kubernetes-incubator/cri-o/pull/1483

@giuseppe Thanks.


http2: no cached connection was available - infinite loop

What version of Go are you using (go version)?
go version go1.7.4 linux/amd64

Same behavior on 1.7
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/sajal/go"
GORACE=""
GOROOT="/usr/local/go"
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build245028891=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"

What did you do?
We are doing something custom with the http package, this issue might not be relevant for common use cases...
Our issue: turbobytes/pulse#5
Example reproduce code: https://gist.github.com/sajal/1e052792023b0a8ff04eba77deeab487
GODEBUG=http2debug=1 go run pilse-5.go --ssl --host="www.cloudflare.com" --endpoint="[2400:cb00:2048:1::c629:d7a2]"
GODEBUG=http2debug=1 run pilse-5.go --ssl --host="dyn.com" --endpoint="[2600:2001:0:3::106]"

First one fails(h2 enabled website), second one works(non-h2 site).
We are using http package along with the awesome httptrace to run some custom tests, to get timing information.
Our terminology :-

host : This is value of the Host request header as well as the ServerName for TLS handshake when accessing over https
endpoint : This is the server we connect to, can be a hostname, IPv4 or IPv6
path: The path being accessed.

The above issue only happens if :-

The website is being accessed using explicit IPv6 endpoint and not a hostname.
The website supports h2

What did you expect to see?
A successful http response. Or at least some err. At worst timeouts being honored.
What did you see instead?
Infinite loop of following messages, and client not respecting timeouts configured.
2016/12/08 23:54:02 https://[2400:cb00:2048:1::c629:d7a2]/
2016/12/08 23:54:02 http2: Transport failed to get client conn for [[2400:cb00:2048:1::c629:d7a2]]:443: http2: no cached connection was available
2016/12/08 23:54:02 0 ConnectStart:  tcp [2400:cb00:2048:1::c629:d7a2]:443
2016/12/08 23:54:02 61 ConnectDone:  tcp [2400:cb00:2048:1::c629:d7a2]:443 <nil>
2016/12/08 23:54:02 http2: Transport creating client conn 0xc420082000 to [2400:cb00:2048:1::c629:d7a2]:443
2016/12/08 23:54:02 http2: Transport failed to get client conn for [[2400:cb00:2048:1::c629:d7a2]]:443: http2: no cached connection was available
2016/12/08 23:54:02 459 ConnectStart:  tcp [2400:cb00:2048:1::c629:d7a2]:443
2016/12/08 23:54:02 http2: Transport received SETTINGS len=18, settings: MAX_CONCURRENT_STREAMS=128, INITIAL_WINDOW_SIZE=65536, MAX_FRAME_SIZE=16777215
2016/12/08 23:54:02 http2: Transport received WINDOW_UPDATE len=4 (conn) incr=2147418112
2016/12/08 23:54:02 509 ConnectDone:  tcp [2400:cb00:2048:1::c629:d7a2]:443 <nil>
2016/12/08 23:54:02 http2: Transport received SETTINGS flags=ACK len=0
2016/12/08 23:54:03 http2: Transport failed to get client conn for [[2400:cb00:2048:1::c629:d7a2]]:443: http2: no cached connection was available
2016/12/08 23:54:03 707 ConnectStart:  tcp [2400:cb00:2048:1::c629:d7a2]:443
2016/12/08 23:54:03 758 ConnectDone:  tcp [2400:cb00:2048:1::c629:d7a2]:443 <nil>
2016/12/08 23:54:03 http2: Transport failed to get client conn for [[2400:cb00:2048:1::c629:d7a2]]:443: http2: no cached connection was available
2016/12/08 23:54:03 954 ConnectStart:  tcp [2400:cb00:2048:1::c629:d7a2]:443
2016/12/08 23:54:03 1008 ConnectDone:  tcp [2400:cb00:2048:1::c629:d7a2]:443 <nil>
2016/12/08 23:54:03 http2: Transport failed to get client conn for [[2400:cb00:2048:1::c629:d7a2]]:443: http2: no cached connection was available
2016/12/08 23:54:03 1209 ConnectStart:  tcp [2400:cb00:2048:1::c629:d7a2]:443
2016/12/08 23:54:03 1257 ConnectDone:  tcp [2400:cb00:2048:1::c629:d7a2]:443 <nil>
2016/12/08 23:54:03 http2: Transport failed to get client conn for [[2400:cb00:2048:1::c629:d7a2]]:443: http2: no cached connection was available
2016/12/08 23:54:03 1442 ConnectStart:  tcp [2400:cb00:2048:1::c629:d7a2]:443
2016/12/08 23:54:03 1494 ConnectDone:  tcp [2400:cb00:2048:1::c629:d7a2]:443 <nil>
2016/12/08 23:54:04 http2: Transport failed to get client conn for [[2400:cb00:2048:1::c629:d7a2]]:443: http2: no cached connection was available

And goes on like this for what seems like forever...
PS: I think the custom Resolver in tip might help me do what I'm doing in a more elegant manner. I have yet to try it out.

I have a hunch this is from https://golang.org/src/net/http/h2_bundle.go#L5143
https://play.golang.org/p/I4HIN5LMC4
net.JoinHostPort("[2400:cb00:2048:1::c629:d7a2]", "443") returns [[2400:cb00:2048:1::c629:d7a2]]:443 instead of [2400:cb00:2048:1::c629:d7a2]:443 which could be the cause of this issue?

Thanks. Looks like authorityAddr does have a problem. Sending a fix now.
There are a few unrelated suspicious things in your https://gist.github.com/sajal/1e052792023b0a8ff04eba77deeab487 code, but we can address those separately.

Thanks @bradfitz . Would appreciate feedback in the gist :)


[question] What is the recommended best practice for Pipenv and apps on Pypi?

Throughout my learning about Pipenv, I have found various viewpoints about how one should handle applications that are supposed to be on Pypi (such as CLI apps). My initial thoughts are that one should get their dependencies from their Pipfile to their setup.py (because I want pip installs that are deterministic), but unfortunately, this is met with a "Do not do this.". I also understand why; The setup.py should only depend on setuptools and wheel; A dependency on Pipenv would not work.
That same thread later has a message from Kenneth Reitz which claims:

If I've explained this well enough, you can see that its just supposed to be the other way around.
You put your dependencies in install_requires, you put you package in the Pipfile, and then you get and environment, with a Pipfile.lock for reproducibility (as it will resolve and respect your package dependencies).

Ok..., so I should run a pipenv install -e ., and still place dependencies in my install_requires. I get reproducible builds with my Pipfile.lock, but..., what about pip? How do I get deterministic pip installs for a package without necessarily having to pin package versions AND not dependending on pipenv?
Looking at the repository for pipenv itself, I can't seem to find anything useful, as this package specifies its dependencies in setup.py (and nothing in packages of the Pipfile, not even an install of the current package through -e .). It's also evident that pipenv hasn't pinned package versions in your setup.py either, so the problems pipenv can solve aren't being solved for dependencies in this project.
Another idea: Given the new pyproject.toml, can I specify pipenv in the build requirements, and then import it into my project to add its dependencies to the setup.py?
Yes, I've read things like https://caremad.io/posts/2013/07/setup-vs-requirement/, but that doesn't necessarily help me, because it focuses on getting requirements.txt from setup.py, not the other way around, which would get me what I want.
Essentially, I want a way for pip install my_cli_package to get dependencies from the Pipfile.lock for that current package somehow. It's possible that my current way of thinking is completely wrong, and if it is, I would appreciate some clarification as to what I really should be aiming for (which is why I'm looking for the current best practice).
Thanks!

I mentioned this somewhere else, but can’t find my own comment at the moment, so I’m going to reiterate it briefly.
setup.py is not actually the only way to install packages (as you might already be aware, given the mention of pyproject.toml), just the default way. PEP 517 defines an interface for build systems to work with pip, and you can use build system declarations to replace setuptools (which uses setup.py) with another tool to specify how your package should be installed. Flit is currently the most prominent alternative.
“How can I install dependencies in Pipfile.lock from setup.py” is, therefore, a misled question. You can’t, and  the real question should be “how can I declare my package to use Pipfile.lock as my dependency specification” instead. The answer is simple—you need an alternative build system that works that way, and declare you package to use it in pyproject.toml.
So how can you that build system I mentioned? You can’t, because it does not exist. See, Pipfile and Pipenv are not tightly-coupled; the former is a specification, and you can freely build libraries to interface with it. Pipenv, however, is only a tool that uses the specification, to handle application dependencies. It does not handle packaging Python libraries. And no-one has built a tool to do what you want—yet, until you build it. PEP 517 isn’t very difficult to implement, and Flit already figured out most of the things, so you can just ~copy-paste~ take inspiration from it.
Or, to put it short: Pipenv doesn’t do what you want, and likely won’t ever. Do it yourself.


do_mark_all_as_read: Split up the work into batches.

Going with an approach kind of like in https://github.com/zulip/zulip/pull/22988. At first I tried moving the work into deferred_work queue, but it gave a janky experience in the webapp, since it meant the client got success response immediately and upon it, reloads (but the messages are still being handled in the worker). Removing the reload upon response is not a sufficient solution either, because the reload is important to properly refresh the state. So the way webapp behaves upon clicking "mark all as read" would have to be reworked somehow i think.
So I went with just batching what happens in do_mark_all_messages_as_read + upon timeout of the request (502), reload the client just like in case of success. Looping to repeat requests like in #22988  doesn't make sense to me, because the reload is important for a non-janky experience. So this solution here is far from ideal, but at least an improvement i think.
Fixes #15403.

Pushed again with some changes to use timeout and return a distinct response code. Tested in dev environment manually to check that it generally indeed marks messages as read, times out when expected, and that the client reloads, as implemented, upon timeout.

Yeah I think that's the right design: A background worker that does periodic send_event calls to notify clients of updated state.

Fully agreed on this needing a queue worker to be truly, properly handled - but as noted, that's kind of more complicated because it needs also to cooperate well with the webapp for reasonable user-facing behavior of the app while things are getting processed in the worker. Shall we just open an issue as a follow-up to this?
The JsonableError with code approach makes sense to me too, so pushed with that. One caveat is that this pushes us to make this response be an "error" rather than a "success", while having a 2xx response which is somewhat unusual and e.g. requires adding an explicit exception for this case in openapi.py. I think that's still reasonable, but just noting that in case you had something else in mind here.

@timabbott @alexmv  Pushed with the approach discussed in https://chat.zulip.org/#narrow/stream/378-api-design/topic/Introducing.20206.20.22Partial.20Success.22.20response
As for the setting - yeah, I'm not sure if making this customizable via a setting is needed - since this is a lot like the markdown timeout, it appears in one place, it's easy to find and tweak in the codebase and seems pretty unlikely for server admins to want to be tweaking it :thinking:

I don't think a setting is essential; the reason I wanted one was mainly that this is a timeout that you absolutely need to change if you're reducing the nginx timeout; but I think git grep timeout is a fine way to find things of that form that need adjusting given that it's not a pattern we use widely right now.

Merged after a bit of work on the documentation and changing the batch_size to 2000; 10000 might be longer than we want to do in a single transaction on some hardware.
There's substantial further improvement that seems possible in this code path; can you open issues/PRs for these ideas?

The frontend logic isn't actually using this to do retries; so I'm sure the actual UX isn't great.
If we wanted it to feel like progress is being made, which probably would help the user experience of "Is this working?" considerably, we could send update_message_flags at the end of each batch.
I suspect that the other code paths through which we adjust message flags could use the same select_for_update approach this is using.

I think only the first is probably significant for the 6.0 release (I'm not sure we get the actual UX improvement desired here without it!), but they might still be worth working on while this is fresh; I'll leave that up to you.

@timabbott

I suspect that the other code paths through which we adjust message flags could use the same select_for_update approach this is using.

Hmm, do_update_message_flags already does it UserMessage.select_for_update_query().filter(...) so I think this may be fine already :thinking:


proposal: encoding/gob: remove panic on nil pointer values in EncodeValue

Proposal Details
Remove the intentional panic that was previously encountered when EncodeValue was passed nil values.
Previously, we panicked so as to maintain logical cohesion, like one would encounter when dereferencing a nil pointer in Go code. However, that makes for a not-great developer experience, thus this change instead returns an error that users can inspect.
This is based on #31664, and requested to be revised into a proposal in CL 554415.

CC @robpike


Clean up markdown-lint issues for Key Vault

Resolves #24069

API change check
API changes are not detected in this pull request.

/check-enforcer override

Systemic failure not caused by this PR. Overriding. A simple docs change that does not introduced any additional lints.


Add changelog entries for quint conversions

Preparation for a release so i can add integration tests to the quint
side.
Going forward, I'll be sure to add these entries as each fragment is
added.

[x] Entries added to ./unreleased/ for any new functionality

Codecov Report

Merging #2463 (4d0f4b2) into main (830f96e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2463   +/-   ##
=======================================
  Coverage   78.34%   78.34%
=======================================
  Files         441      441
  Lines       15388    15388
  Branches     2476     2439   -37
=======================================
  Hits        12056    12056
  Misses       3332     3332

Impacted Files
Coverage Δ

.../forsyte/apalache/tla/pp/ConstSimplifierBase.scala
96.93% <0.00%> (-1.03%)
:arrow_down:

...he/io/annotations/parser/CommentPreprocessor.scala
96.70% <0.00%> (+1.09%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


new fst releases available

this pull request is automated and triggered by new fst releases

@aarppe, please decide whether to merge this. The tests have not finished yet, but assuming they all pass, this should be okay to merge, and will not break... much!
If things are broken on the production website, we can go back to this pull request and revert it! That's all it takes to undo the damage!

@aarppe DO NOT MERGE THIS. It broke everything!

lol I'll try to investigate what happened

I was in meetings, so I did not approve not merge, which was fortunate, it seems.
Nevertheless, obviously needs investigating.

@Madoshakalaka I think this is caused by a bug in fst-lookup... 😩

@eddieantonio uhuhu I'll let you have a look first then?

@aarppe might try a simpler FST with less non-Cree stuff.

I left out the proper names and abbreviations from the catenation of the LEXC source, leaving otherwise the compilation script the same and adding FOMA compilation at the end. Direct conversion with hfst-fst2fst of the HFST descriptive analyzer to FOMA format results in abort, but the following scheme seems to work:
hfst-fst2fst -b -F -i crk-gen-norm-dict.hfst -o crk-gen-norm-dict.fomabin

hfst-fst2fst -b -F -i crk-orth.hfst -o crk-orth.fomabin

foma -e"load crk-gen-norm-dict.fomabin" -e"define M" -e"load crk-orth.fomabin" -e"invert net" -e"define O" -e"regex [ M .o. O ];" -e"save stack crk-anl-desc-dict.fomabin" -s

Testing with a few examples, we seem to get results we expect:
flookup -q crk-anl-desc-dict.fomabin
nepat
nipayan
meyonipat
nepat	IC+nipâw+V+AI+Cnj+Prs+3Sg

nipayan	pê-ayâw+V+AI+Ind+Prs+1Sg
nipayan	nipâw+V+AI+Cnj+Prs+2Sg
nipayan	nipâw+V+AI+Cnj+Prs+1Sg

meyonipat	IC+PV/miyo+nipâw+V+AI+Cnj+Prs+3Sg

That hfst-fst2fst produces an imperfect FST is something that we ought to bring to the attention of the Helsinki folks.  Nevertheless, the HFST and FOMA FSTs seem to work, so I can't easily judge if there's something disagreeable in the source code.
Regardless, I don't know if this works with the python FST lookup code.
Getting the new FST working is important as it fixes some key errors in the affixation implemented last week (Atticus is working in the remaining issues, namely unspecified actors for VAIs and VTIs) as well as incorporates all of Arok's new dictionary entries.

I'm closing this PR, as making a new build script seems to be a something we should figure out in UAlbertaALTLab/plains-cree-fsts, and within Giella. The FSTs uploaded in this pull request will simply not work :/


[SPARK-48127][INFRA] Fix dev/scalastyle to check hadoop-cloud and jvm-profiler modules

What changes were proposed in this pull request?
This PR aims to fix dev/scalastyle to check hadoop-cloud and jam-profiler modules.
Also, the detected scalastyle issues are fixed.
Why are the changes needed?
To prevent future scalastyle issues.
Scala style violation was introduced here, but we missed because we didn't check all optional modules.

https://github.com/apache/spark/pull/46022

jvm-profiler module was added newly at Apache Spark 4.0.0 but we missed to add this to dev/scalastyle. Note that there was no scala style issues in that module at that time.

#44021

hadoop-cloud module was added at Apache Spark 2.3.0.

#17834

Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs with newly revised dev/scalastyle.
Was this patch authored or co-authored using generative AI tooling?
No.

cc @panbingkun and @gengliangwang

All tests passed.

Could you review this PR, @viirya ?

Good catch!

Thank you, @viirya !

late LGTM.


indicate unit in nc4 files

This adds a variable to RC files that allows specifying the units in the vertical grid (either pressure levels, hPa or 1 for channel like entries).
Colin: can you git this a try? Let me know pls.

Okay, I see that hPa for conventional observations is the default.

Closes #10


[NCL 6583] Implement ProjectDetailPage

Hi @DnsZhou could you please advise me on the best way to create unit tests for this page? My naive way is not working properly.

Hi @DnsZhou I added the unit tests. Could you please have a look whether it is okay now? Thank you.

Fix object props: const flexDirection: FlexProps['direction'] = { default: 'column' }; (outside of component)
KeyValueTable to accept also components
JIRA for eslint warning
ActionHeader for more or zero buttons

Hi Kubo, it Looks good from my side, and verified it in my local environment. You can reach Martin to see if there is anyting else that needs to be changed. Thx.


Update client3:akka-http-backend, ... to 3.3.14

Updates

com.softwaremill.sttp.client3:akka-http-backend
com.softwaremill.sttp.client3:core

from 3.3.13 to 3.3.14.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.softwaremill.sttp.client3" } ]

labels: library-update, semver-patch

Superseded by #917.


Image loading not working in Storybook v5

Describe the bug
Unable to import media assets by importing (or requiring) them.
To Reproduce
Steps to reproduce the behavior:

Create a story with the following code:

import * as React from "react"
import { storiesOf } from "@storybook/react"

import imageFile from './header-background.png'

const image = {
  src: imageFile,
  alt: 'my image',
};

storiesOf("Header", module)
  .add('with an image', () => (
    <img src={image.src} alt={image.alt} />
  ))

Run Storybook

Expected behavior
I expect SB to load and show the image.
System:

OS: MacOS
Device: Macbook Pro 2015
Framework: react
Version: "@storybook/react": "^5.0.1"

Other info:
I am using Gatsby.

Closing this as a dupe to #5941


'forin' will be bypassed when there is a fake if

var obj = {},
    key,
    someLogic;
/* jshint forin: true */
for (s in obj) {
    if (someLogic) {
        // code here
    }
}

jshint will happy and complain nothing about hasOwnProperty

function noStinkinProtoProps(o, p) {
return Object.prototype.hasOwnProperty.call(o, p);
};
var obj = {}, key;
for (key in obj) {
if (noStinkinProtoProps(obj, key)) {
// code here
}
}

thank you for your response. You are right, but what I mean is the if logic has nothing business about
hasOwnProperty.
That would be very complicate to check this.
I had update to the latest version, and it could work perfect if the logic statement start with !.
Thank you for your effort.


Redirect without Connection: close

Spark's response.redirect() sends a Connection: close header. Why?
The problem with that (besides breaking http keep alive) is that at least Chrome does a redirect too early when it encouters Connection: close, meaning that the redirected request comes in before previous request's after() handlers have completed. This poses problems for post-and-redirect pattern, because the redirect may come before the DB commit of the post request, resulting in a 404 response.
I suggest removing Connection: close from redirect method.

Not sure if fixed. Closing this because we need to clean up. @angryziber please create a new issue if this is still a problem.

Spark still closing connect when redirect.


Datetimepicker closing modals on which the input field recide

This is a great plugin. I found a problem when the datetimepicker is triggered on a modal with a form, it closes the existing form and loads the picker rather than open over it like the material date picker does.

skipHide: true, is not updated in the installation file. I am able to get it if I clone the file. Kindly provide new version for installation with the following change.

I have the same error , i have a form inside a modal ,when i put datetimepicker  and click in the field, the modal close , how can i solve this problem, I not understand the last @NiroopGR comment.

https://github.com/logbon72/angular-material-datetimepicker/pull/27/commits/4b3ea0ad14b2b7bd531cd6622a904554b35bfd0b

@NiroopGR yep, you're right, the problem with the cancel button still persists with this solution, then I'm still waiting for a solution.

the datetimepicker is using $mdDialog, thats why it's closing other modals, in angular-material you cannot have more than one opened $mdDialog

bower this
"angular-materialDatetimepicker": "https://github.com/logbon72/angular-material-datetimepicker.git#46091900cbd0291504297e7b89cd901848de4c94",

still doesn't work after bowering

Fixed in recent update


Implementation of monero_wallet_light

This pull request introduces a new class, monero_wallet_light, which is designed to facilitate the connection and interaction with Monero light wallet servers. The  monero_wallet_light class provides essential functionalities such as:

Connecting to a light wallet server to fetch wallet data without needing the full blockchain.
Synchronizing wallet balances and transactions in a lightweight manner.
Sending transactions through the light wallet server.
Querying necessary blockchain information from the server.
The purpose of this implementation is to improve the user experience for devices with limited resources, such as mobile devices, by offloading blockchain-heavy operations to remote light wallet servers.

Closes #58

Getting this warnings on the build:
/Users/woodser/git/monero-java/external/monero-cpp/src/wallet/monero_wallet_light.cpp:1368:11: warning: logical not is only applied to the left hand side of this comparison [-Wlogical-not-parentheses]
      if (!kv.first == account_index) continue;
          ^         ~~
/Users/woodser/git/monero-java/external/monero-cpp/src/wallet/monero_wallet_light.cpp:1368:11: note: add parentheses after the '!' to evaluate the comparison first
      if (!kv.first == account_index) continue;
          ^
           (                        )
/Users/woodser/git/monero-java/external/monero-cpp/src/wallet/monero_wallet_light.cpp:1368:11: note: add parentheses around left hand side expression to silence this warning
      if (!kv.first == account_index) continue;
          ^
          (        )


Making SuperEditor work in a CustomScrollView

I'm working on figuring out what it will take to make SuperEditor work in a CustomScrollView.
I separated all keyboard handling from gesture handling.
Within the gesture interactor, I added behavior to check for an ancestor Scrollable. If there is an ancestor Scrollable then the gesture interactor bases all of its position and auto-scrolling behaviors on the ancestor.
https://user-images.githubusercontent.com/7259036/139408329-e944e718-7299-48c7-ad2f-add597414a88.mov

@brian-superlist I checked in the repo you linked and the sliver demo in there seems like it's still showing the image. I tried commenting out everything in the SliverAppBar on my end and everything still works OK.
Can you link to the specific files that reproduce the issue so that I can copy them over to my repo and quickly try them out?

@brian-superlist nevermind. You were talking about removing the image in the document, not the app bar. Now I see the layout issue.

@brian-superlist I think I've fixed the layout issue. I think it might be a bug in IntrinsicHeight so I adjusted the editor layout to avoid needing that. Remove the IntrinsicHeight widget and see if things work for you now.
I also moved the task and chat demo over to this PR. Can you let me know which slivers you're using to take up available space when they can, and then shrink to zero when there is no available space? I'll update the task and chat demo to use a CustomScrollView in a similar fashion.

Can you let me know which slivers you're using to take up available space when they can, and then shrink to zero when there is no available space? I'll update the task and chat demo to use a CustomScrollView in a similar fashion.

Sure thing, you can see a demo & SliverStickToBottom class here:
https://github.com/brian-superlist/super_editor/blob/use-cases/super_editor/example/lib/demos/header_footer_use_case.dart
https://github.com/brian-superlist/super_editor/blob/use-cases/super_editor/example/lib/demos/sliver_stick_to_bottom.dart

@miguelcmedeiros - I'm gonna merge this PR so that I can begin the mobile work.
I updated the PR to include 2 versions of the task+chat UI - one with a custom RenderBox and one with a bottom docked Sliver in a CustomScrollView. Both of them seem to work equally well, which provides initial validation for this approach. Please give this is a try in Superlist whenever you can, and then file any issues that you find.


[Feat]: Website Icon

Feature Description
Want to add a Icon for this site
Provide a detailed description of the feature
There's no icon for this site, want to add a cool icon which is relevant to this site.
Put here any screenshots or videos (optional)

By submitting this issue, you agree to

[X] I agree to follow this project's Code of Conduct
[X] I’ve read all the issues in the issue section, and this feature has not been proposed yet.

Other Information

[X] I'm a GSSoC '24 Extended contributor
[X] I'm a Hacktoberfest '24 contributor
[X] I am willing to work on this feature (optional)

@maniyaom Kindly Look into the issue and assign me under gssoc and hacktoberfest label....


Missing error code on null alloc

Fixes #5841

Are these fixes from the "missed pcgrep" pattern you posted earlier?

Merged to master, thanks.


[Request] Config to disable Hemp seed drops

I'm currently building a pack which includes both Immersive Engineering and BetterWithMods.  However both mods add hemp seed and hemp crop (among other things).
I'd like to be able to use just IE's hemp and disable BWM's for balance/aesthetic reasons.  I was able to make it compatible with BTW's stone mill thanks to oredict support.  As far as I know however, there's no way to disable seed drops.
A config to disable seed drops for BTW hemp would be much appreciated.

This seems scantly related to #22, wherein "config" was mentioned in every single comment but no configs were ever done 👍

Thank you.  :)


This fixes the PDF build on my laptop

And I wonder whether it also fixes the build on the CI.

It does indeed. I'm not sure what kind of siunitx magic you have going on your laptop, @richford, but I'm going to go ahead and merge this 😄


Explore impact of ambigious usage of Ensembl and Gnomad based coordinates for indels

It has been noticed in the past (upon mapping GWAS Catalog curated associations), that coordinates of indel in Ensembl and GnomAD different by 1 position. (more info here: https://www.biostars.org/p/84686/). This affects indels only. This discrepancy causes that indels from GWAS Catalog could not be resolved against GnomAD variant reference, leading to there's no indels in the production genetics portal.
Tasks:

[ ] Find out how the GWAS Catalog summary stats look like?
[ ] Check indels' position and alleleles, are the alleles contain '-'?
[ ] Is the marked position match with GnomAD position?

Based on what we find we need to find out how to unify the indel representation in gentropy.

Based on a discussion with @addramir and @d0choa, we agreed that changing the coordinates of the variant annotation table is too disruptive with a wide series of negative consequences in variant data harmonisation and ingestion. So it has been decided that we revert:

[ ] The variant annotation coordinates should remain unchanged.
[ ] To make sure we can normalise curated GWAS Catalog associations to Gnomad, we have to termoporarlity update coordinates, and afterwards these coordiates should be reverted to their original form.

The datasets that need to be re-generated:

[ ] GnomAD4 based variant annotation
[ ] GWAS Catalog curation ingestion

QC Variant annotation
Link to QC notebook: here
Conclusions:

The reference for variant annotation in the configuration point to a dataset based on GnomAD3.
The gnomad3VariantId column is dropped. Good.
Could verify that the same indel variant in the old and the new show different in position:

New data
-RECORD 0---------------------------
 variantId       | 10-41776411-C-CT
 chromosome      | 10
 position        | 41776411
 referenceAllele | C
 alternateAllele | CT

Old data:
-RECORD 0----------------------------
 variantId        | 10_41776412_C_CT
 chromosome       | 10
 position         | 41776412
 referenceAllele  | C
 alternateAllele  | CT
 gnomad3VariantId | 10-41776411-C-CT

QC LD-index

The size of the LD index doesn't change.
The coordinates of indels in the LD index is changed:

Old ld-index:
+-----------------+
|variantId        |
+-----------------+
|6_100124716_CA_C |
|6_100124716_C_CA |
|6_100124715_C_A  |
|6_100124716_C_CAA|
+-----------------+

New ld-index:
+-----------------+
|variantId        |
+-----------------+
|6_100124715_C_CA |
|6_100124715_C_CAA|
|6_100124715_C_A  |
|6_100124715_CA_C |
+-----------------+

It might be my misunderstanding but mentioning just in case. The variantId in the new data pasted above has hyphens instead of underscores. That would not play well with everything else.

It might be my misunderstanding but mentioning just in case. The variantId in the new data pasted above has hyphens instead of underscores. That would not play well with everything else.

Yes, you are right! I just renamed the column from gnomad3VariantId to variantId. Applying the fix.

Fix applied, code pushed to branch. DAG is re-run, saved here: gs://genetics_etl_python_playground/output/python_etl/parquet/XX.XX/variant_annotation
Sample:
-RECORD 0----------------------------------
 variantId          | 10_41776397_C_G
 chromosome         | 10
 position           | 41776397
 chromosomeB37      | 10
 positionB37        | 42463812
 referenceAllele    | C
 alternateAllele    | G
 rsIds              | [rs1427850406]
 alleleType         | snv
 alleleFrequencies  | [{afr_adj, 0.0}, ...
 vep                | {intergenic_varia...
 inSilicoPredictors | {{1.028, -0.05497...
only showing top 1 row


Add doc alias to recip for inv

The F32 struct has an inv implementation that calculates the reciprocal. In the standard library, this function is referred to as recip, so I added a #[doc(alias = "recip")] to it in order to improve visibility.

I also added a note that this function performs an inverse based on an IEEE 754 float layout assumption.

Looks like this isn't allowed under the current MSRV.
We can potentially bump MSRV. Not sure when it was introduced.

@tarcieri Just checked, it was added in Rust 1.48.0 from Novemver 2020 (see here). recip itself is from 1.10.0, ... not that that matters. :)
Current MSRV was 1.47.0, so I bumped it by one minor. Seems excessive just for one alias, so I'm not sure if that's what you want just for this one. It probably makes more sense in light of other PRs.

(Removed the MSRV bump since #108 went higher anyway.)


Support for Python 3.12

This is a pyzmq bug

[X] This is a pyzmq-specific bug, not an issue of zmq socket behavior. Don't worry if you're not sure! We'll figure it out together.

What pyzmq version?
26.2.0
What libzmq version?
N/A
Python version (and how it was installed)
3.12.5 installed via Homebrew
OS
macOS 14.6.1
What happened?
See https://github.com/microsoft/azuredatastudio/issues/25327 for details.
Code to reproduce bug
No response
Traceback, if applicable
No response
More info
No response

pyzmq has wheels for arm macs up to and including the upcoming Python 3.13. What version of pyzmq are you trying to install, and what is the output? There is no such information for macs in the linked issue, which is mostly about Windows, so there aren't any useful details there.
In the linked issue, all I see is someone trying to install pyzmq 24.0.1, which is too old for Python 3.12. Make sure you are installing pyzmq>=25.1.1 for 3.12 support.
This works (arm mac, 14.6.1):
> brew install<EMAIL_ADDRESS>> /opt/homebrew/bin/python3.12 -m venv /tmp/testenv
> /tmp/testenv/bin/pip install pyzmq
Collecting pyzmq
  Downloading pyzmq-26.2.0-cp312-cp312-macosx_10_15_universal2.whl.metadata (6.2 kB)
Downloading pyzmq-26.2.0-cp312-cp312-macosx_10_15_universal2.whl (1.3 MB)
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 1.3/1.3 MB 31.9 MB/s eta 0:00:00
Installing collected packages: pyzmq
Successfully installed pyzmq-26.2.0

If you're getting a different pyzmq version, check what package is pinning it down, because that's the source of the problem, not pyzmq.

In the linked issue, all I see is someone trying to install pyzmq 24.0.1, which is too old for Python 3.12. Make sure you are installing pyzmq>=25.1.1 for 3.12 support.

Thank you very much, I think this is the issue!


Tweak Callable's documentation

Follow up to many of my documentation PRs, this one is unfortunately not as detailed, as I hoped it to be.
I do not have enough knowledge of Callable to document it with confidence for the time being. Still, some outdated and misleading terms have been removed, so that's an upgrade. Wish I could've done something more with the verbosity that make Callable look more complicated than it actually is, but it is what it is for now.

Clarify that Callable is a Variant type, not an Object.
Add GDScript lambda function example.
Update outdated description of is_custom and is_valid.
Some tweaks all around.

If you find some more misleading or very confusing terminology, as always, you may use this PR as a "catch-all" to propose further suggestions before it gets merged.

One thing I think the documentation needs is mentioning how/whether lambdas capture local variables and what the value of self is (the Callable? or is it passed through?).
But I would have to experiment first to learn how it works.

Yeah, the lambda introduction I have written was very succinct because I would've rather given true information rather than misleading information. It totally needs to be expanded. I'm not even sure if it's appropriate to call them lambda functions, 'cause they, by all means, are just Callables, although everywhere I've looked called them this way, even in GDScript and update reports.
It's also technically not true that they are not associated with any Object but I digress

This PR is fairly accurate and can be used as inspiration for the description: https://github.com/godotengine/godot-docs/pull/6276

May be worth a second look

Thank you, merged! 🎉


Release Artifact Instructions

Add a shell script with the (very rough) steps that will produce the non-pip release artifacts.

One day I will need to properly set up GitHub actions or a sane build process...


Update data.json

Hacktoberfest! 🎊🎈
🎉 Have you read the Contributing Guidelines? 🤔
Yes
📝 Description
Find Maximum
Fixes #304 🔧

✅ Checklist

[ ] I've read the contribution guidelines. 📚
[ ] I've checked the issue list before deciding what to submit. 🔍
[ ] I've edited the README.md and linked to my code. 📄

🔗 Related Issues or Pull Requests
(Write your answer here.)

Hi there!
I am the Mentor of this project .
Although this repo is not part of Hacktoberfest 2024, we have some great alternatives for you. Welcome to SkillShow, a repository focused on skill enhancement!
Guidelines:
Please adhere to the existing guidelines.
No additional rules, thanks!
Check it out here: SkillShow.
Note: Start by creating an issue. Once it’s assigned to you, feel free to open a pull request (PR). Directly opening a PR will lead to an invalid label.
Looking forward to your contributions!


spyder crashes upon launch

I run macOS10.15.7 (19H15). I updated anaconda for macOS on 4 Dec 2020.
I got a problem described below. Next I deleted anaconda, downloaded, and reinstalled it, and said
$ conda update --all
Those steps did not cure the problem.
Problem Description
Summary: spyder won't launch from Terminal. Anaconda Launcher also offers to launch Spyder, but after a delay fails to do so with no visible error message.
What steps reproduce the problem?
Even when I just say
$ spyder --reset
(or try to launch spyder), I get the error below.
What is the expected output? What do you see instead?
In Terminal,
/Users/pcn/opt/anaconda3/bin/pythonw: line 3: /Users/pcn/opt/anaconda3/python.app/Contents/MacOS/python: No such file or directory
First comments:
So I looked at the file anaconda3/bin/pythonw
which is just 3 lines:
#!/bin/bash
export PYTHONEXECUTABLE=/Users/pcn/opt/anaconda3/bin/python
/Users/pcn/opt/anaconda3/python.app/Contents/MacOS/python "$@"
Indeed, saying
$ ls anaconda3/python.app/Contents/
shows that there is no folder called MacOS/. In fact there is only one entry, a folder called lib/ which contains a folder called python3.8.
Versions
I run macOS10.15.7 (19H15). I updated anaconda for macOS on 4 Dec 2020.
I can't ask Spyder its version because it won't launch. It is the one supplied by anaconda on 4 Dec 2020.
Thanks Phil Nelson

Hi @NelsonUpenn thanks for reporting this.
Can you try opening your terminal and running
conda install -f python.app

Ms Gomez
Thank you for your immediate reply:

On Dec 4, 2020, at 3:18 PM, Juanita Gomez<EMAIL_ADDRESS>wrote:
Hi @NelsonUpenn thanks for reporting this.
Can you try opening your terminal and running
conda install -f python.app

** This was successful. I can now launch Spyder 4.1.5 (below).
Philip Nelson

Spyder version: 4.1.5 None
Python version: 3.8.5 64-bit
Qt version: 5.9.7
PyQt5 version: 5.9.2
Operating System: Darwin 19.6.0

You're welcome. I'm glad it worked!


Add RayJob training example using pytorch resnet image classifier

Why are these changes needed?
Add an example RayJob based on the Finetuning a Pytorch Image Classifier with Ray Train example.
This example will be referenced for user guides that demonstrate distributed checkpointing with GCSFuse.
Also updates the existing pytorch text classifier with an example using GCSFuse.
Related issue number

Checks

[ ] I've made sure the tests are passing.
Testing Strategy

[ ] Unit tests
[ ] Manual tests
[ ] This PR is not tested :(

I prefer not to update files under pytorch-text-classifier/. If we update the YAML/Python files, users will fail to follow the original documentation, which does not focus on checkpointing.

I removed changes in the pytorch-text-classifier sample. I wanted to have an example of it where it uses a shared filesystem, but I guess we can keep those two examples separate

The CI failure is not related to this PR. Merge.


Package Manager: Allow additional feeds

A developer can connect to:

[x] A public feed by URL (filter packages by tag)
[x] A private feed by URL (no filtering of packages)
[x] A folder on your local machine by file path (no filtering of packages)
[x] A folder on a shared drive by file path (no filtering of packages)

This work is included in #5557

This work is included in #5557


fix(types): make sql.ids(...) & sql.join(...) arguments readonly

sql.join and sql.ids don't mutate their arguments, so those arguments should be readonly, so that readonly arrays can be passed in without TS complaining.

Thanks!


How to hide rotation button from toolbar?

Hi,
I didn't find a way to remove the rotate button from the toolbar.
Thanks!

You can set toolbarButtonOptions in CropToolbarConfig like below
config.cropToolbarConfig.toolbarButtonOptions = [.horizontallyFlip, .reset, .ratio]


Return UUID as array

The UUID related calls return a fixed sized array. It might make sense to return arrays of those instead of vectors.
I don't have a strong opinion on that, I just thought I bring it up, while I'm working with those function calls. In my code, where I use the uuid_khr(), I convert it into an array, so I thought It would be nice if it was already an array.

Related to this (let me know if I should open a separate issue). It would be great if cl3::ffi::cl_ext::CL_UUID_SIZE_KHR could be re-exported into opencl3, so that I can create such a fixed sized array without importing cl3.

Hi Volker, my opinion on the UUID related calls is that they are just defined in an extension at the moment and it's possible to access the data using the device functions as you have done.
It may be nice to convert UUIDs to arrays now. However, it may be even nicer to convert them into UUIDs from the uuid crate. Or, in the future, when 128 bit integers are likely to be available in rust it wouldn't be so nice. So I'd rather not make that change at the moment.
I'm happy for cl3::ffi::cl_ext::CL_UUID_SIZE_KHR to be into opencl3. Would you like to submit a PR?


added support for PromiseLike

Extends Promise apis to use PromiseLike instead.
Uses Promise.resolve to convert PromiseLike into a Promise.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/resolve
The Promise.resolve() static method "resolves" a given value to a Promise. If the value is a promise, that promise is returned; if the value is a thenable, Promise.resolve() will call the then() method with two callbacks it prepared

What's the point of resolve, can't we simply call then? also please don't use Merge Commits, it is safer to rebase the branch


Can we have an option to pull in androidmanifest chunk from project folder

I found that the manifest is populated here
https://github.com/godotengine/godot/blob/master/platform/android/SCsub
But I am not that experienced to do this.
Because many android modules like googleplay services require custom properties in manifest file, this should ease the process I think.

You can put AndroidManifestChunk.xml file in your module.
It will be merged when making templates.
Here is an example module for Google Play Service module for godot.
https://github.com/ranmaru90/Play-Game-Services-Android-Module-for-Godot

Yes, I know that. But the problem is that the project specific ids and such things are bound to the module. So every project require different export templates to be created. I was looking for simplifying things here.
For eg: If our most projects require only google iap, admod, gpg. Then we can create one export template and we can use that for all projects. We only need to change the app id in the manifest, which resides in the project folder.

I think that the above file is for creating export templates but the real export is done in this file
https://github.com/godotengine/godot/blob/master/platform/android/export/export.cpp
I am thinking like this.
The module already has a chunk xml but inside the module creator can have a $$CUSTOM_XML_CHUNK$$ string and the export should replace this string with the string that is defined in a file in the project folder.
Anyway the export.cpp file is too complicated for me.

I'm not familiar with android export process. Can anyone confirm about the absence of feature?

Is this covered by the new Android export system? See Custom builds for Android in the documentation.

Yes, you can customize any part of the AndroidManifest from your project folder now.


[Sprint: 47] XD-2892 Adding Pivotal HD 3.0 as a distro

(depends on changes in PR 1567)

LGTM, Rebasing

Merged


Update get_refs.py to include cell typing references

Following on https://github.com/AlexsLemonade/scpca-nf/pull/398, and when cell typing is actually incorporated into the workflow, we will need to make sure those get downloaded for users who might need to run without access to the internet.
There are at least two thoughts I have about this that may turn this into a slightly larger issue or force some reconsideration of how we handled training references, and might argue again for a json file with the references in it.
The first is that in the reference_paths.config file we use two levels of params references, which I had previously avoided to allow easier parsing of the file within get_refs.py. Specifically, we use params.celltype_ref_dir, which saves some typing but means we would have to parse that specifically when getting references: https://github.com/AlexsLemonade/scpca-nf/blob/bd905535bb6e2dd81ae2f1861ae799e9d26607c7/config/reference_paths.config#L9C1-L16C72
The solution I would propose there is to remove that variable and simply define all of the subpaths with reference to params.ref_dir, e.g.:
// output from save_singler_refs() process
singler_references_dir = "${params.ref_dir}/celltype/singler_references"

However, this raises another question/problem, which is that singler_references is a directory, and the download script can not list directories (for AWS security reasons, a logged in user can't run ls on a prefix, or at least we don't have that set up). So we need to define every file either in the get_refs.py script or in a json file (or other reference file) that the script can read. Since these files are likely to change more often, I favor the json option. This leads me to think that the workflow that creates the cell typing references maybe should also output a json file of the paths to the references that it uses/creates? If that is done, then get_refs.py can discover them more easily.
One thought is that this json file could live at ${params.ref_dir}/celltype/celltype_refs.json, which would allow it to be updated outside of the workflow itself, though I might be less enamored with that overall.

Can we close this in favor of #560

Hah, yes!


Nullpointer bugifx

@rebuy-de/it-mobile

:+1:

Do you need anyone to look further at this?

:+1:

:+1:


API Access Key availability

API Access Key allows to avoid issues with dynamic IP's. Also it helps to avoid IPv6 bug in API IP lists.

@itspriddle I collected all the pull reqs and sent it to @timrogers, you can decide if you want to merge.


Replace HttpRequest.UserAgent

Get Request.Headers["User-Agent"].ToString() instead, though it probably makes sense to do that in an extension method that we add to the project.

This is available from the Microsoft.AspNetCore.SystemWebAdapters package


Automated cherry pick of #366: add ucloud operations

Cherry pick of #366 on release/2.9.0.
#366: add ucloud operations

/cc @yousong

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.9.0@242c6cd). Click here to learn what that means.
The diff coverage is 0%.

@@               Coverage Diff               @@
##             release/2.9.0    #709   +/-   ##
===============================================
  Coverage                 ?   7.33%
===============================================
  Files                    ?     347
  Lines                    ?   55681
  Branches                 ?       0
===============================================
  Hits                     ?    4083
  Misses                   ?   51219
  Partials                 ?     379

Flag
Coverage Δ

#aFlag
7.33% <0%> (?)

Impacted Files
Coverage Δ

pkg/util/ucloud/client.go
20.93% <ø> (ø)

pkg/compute/models/guests.go
0.67% <ø> (ø)

pkg/mcclient/options/servers.go
0% <ø> (ø)

pkg/compute/models/vpcs.go
2.04% <0%> (ø)

pkg/util/ucloud/ufile.go
0% <0%> (ø)

pkg/util/ucloud/disk.go
0% <0%> (ø)

pkg/compute/guestdrivers/ucloud.go
29.41% <0%> (ø)

pkg/compute/models/networks.go
0.83% <0%> (ø)

pkg/util/ucloud/snapshot.go
0% <0%> (ø)

pkg/util/ucloud/vpc.go
0% <0%> (ø)

... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 242c6cd...ecddd50. Read the comment docs.

/approve
/lgtm


llmq: Some refactoring in CChainLocksHandler::ProcessNewChainLock

cc1b476 really made me think if it actually makes any sense to have both (!bestChainLock.IsNull() && clsig.nHeight <= bestChainLock.nHeight) and InternalHasConflictingChainLock here at all (#3978 is a side effect of that 🙂 ) cause it seems like InternalHasConflictingChainLock will always be false in this combination, no?

Ping 👀  Any thoughts on dropping InternalHasConflictingChainLock part instead of cc1b476?

@UdjinM6 Sorry for the late reply, i was just too deep into other stuff the last week and i just didn't find time in my mind to think about this and #3978 🙈 But i agree, it makes sense to drop it 👍 Added a51875f900085e1898fcd85865f09f303c8b0770 instead of cc1b476!

Can you explain a51875f900085e1898fcd85865f09f303c8b0770 more? why are we dropping that?

why are we dropping that?

See https://github.com/dashpay/dash/pull/3976#issuecomment-772129953
https://github.com/dashpay/dash/blob/a51875f900085e1898fcd85865f09f303c8b0770/src/llmq/quorums_chainlocks.cpp#L634 will always trigger in this case because we already make sure before that its higher than best chainlock height https://github.com/dashpay/dash/blob/a51875f900085e1898fcd85865f09f303c8b0770/src/llmq/quorums_chainlocks.cpp#L120


[BUG] Brew packages are displayed +1

Describe the bug
The total number of homebrew packages including casks, bottles and formulae is also displayed +1. For example if I have 4 packages, they are displayed as 5.
To Reproduce
Steps to reproduce the behavior:

Install macchina in macOS
Install homebrew
Install some homebrew packages
Use the macchina program

Expected behavior
The total amount of packages should display the actual count
Screenshots

macchina --doctor output

System Information
You don't have to provide this information if you're not comfortable doing so, but it'll help us solve the issue a lot faster.

Distribution: none
Desktop Environment: Aqua (not an option but whatever)
Operating System: macOS
Terminal: macOS terminal
Macchina's version: 6.1.5

Can you show me the output of homebrew list | wc -l?

Can you show me the output of brew list | wc -l?

Actually I used a different command which also shows bottles (dependencies) which I assumed it was also counting

I just actually self solved the problem. There seems to also be a .keepme file along the packages

Hmm, I thought we ignored any ".keepme"s.
This is an easy fix :)
I'll also subtract the result by one.

Ok although imo the more correct solution fix would be to also check if the .keepme is there first

Also unrelated but I just noticed it isn't showing anything from cargo

Moving this to libmacchina


Don't allow to use a safe which is incompatible to the current version of pick

A pick version consists of three parts. E.g.:
1.2.3
_ 1: major version
  _ 2: minor version
    _ 3: patch version

If a safe is using a newer major/minor version than pick, reject the safe.
This makes sure you can't accidentally "destroy" a safe (e.g. losing an
account's history) by trying to use the safe with an older version of pick.

Not checking the patch version requires being very careful when choosing an upcoming release's version:
You have to make sure to increase the minor version once something in the safe layout is changed.
What do you think: Should we also compare the patch version?

Interesting idea. I am not opposed to formalizing a methodology around versioning, i.e. patch versions never contain safe schema changes.
Another alternative would be to use an upgrader pattern, where we provide an upgrade func for each version, build a pipeline of upgrade funcs, and run a safe through them at load-time to upgrade the safe. The benefit to this approach is increased backward compatibility.

Another alternative would be to use an upgrader pattern, where we provide an upgrade func for each

We can't use an upgrader if pick version < safe version. We'd need to downgrade the safe, which doesn't make sense.

Updated.


Default route fix in v3-push and v3-zdt-push

Does this PR modify CLI v6 or v7?
v6
What Need Does It Address?
Fixes a bug which caused v3-push and v3-zdt-push to map the default route to the app regardless of if there are already routes mapped. This behavior was not present in cf push.
Description of the Change
CreateAndMapDefaultRoute in the pushaction layer checks to see if routes have already been mapped to the app before creating and mapping the default route. If there are already routes, the default create and map action does not take place.
Applicable Issues
https://www.pivotaltracker.com/story/show/161832651
Other Relevant Parties
@matt-royal @zrob

@Gerg @mkenyon FYI

Merged. Just as a heads up, there was one (very minor) go fmt change that was missing; we made the change locally after verifying the PR.


Package request: stacer

Project description
System optimization and monitoring tool.

Metadata

homepage URL: https://github.com/oguzhaninan/Stacer
source URL: https://github.com/oguzhaninan/Stacer
license: mit, bsd, gpl2+ , ...
platforms: unix, linux, darwin, ...

It seems like the project was abandoned https://github.com/oguzhaninan/Stacer/commit/a44d0565a05c996b1058f950f1d308e1964c8320

Stacer is in nixpkgs already - https://search.nixos.org/packages?channel=unstable&from=0&size=50&sort=relevance&type=packages&query=stacer


docs/store: Document binaryindex-header usage and characteristics.

It would be nice to do before release.
AC:

Explain how to use index-header for end-user.
Explain characteristics (low baseline usage, but query spikes are expected)
Note that it is still experimental.

cc @metalmatze @squat @brancz

We're still releasing this as an experimental feature, I think this is mostly required for when we make it default, but I agree. I think the original design is nice but maybe to detailed for the end user, so I do agree. How about we start a new section in the docs "Operational Guide"? I quite like this in etcd's op-guide section, where various aspects from alerting to expected/unexpected behaviors are documented from an operational perspective. What do you think?

Agree, I think Operational Guide sounds like good place for this content. We already have something like Troubleshooting.md that we should put there as well. Thanks 👍

I suggest an additional warning about open fd limits with this option.
Our store nodes are each responsible for 7989 blocks in GCS and, until now, we have run store under systemd with a LimitNOFILE=4096. Enabling this flag meant an index header for each block and an open file for each block, resulting in our process_open_fds for thanos store going from 11 to the limit very quickly.
Somehow, store came online but seemed to be unresponsive to StoreAPI queries until we raised the LimitNOFILE to 16384 and restarted.  Our process_open_fds then stabilized at ~8000, or 11 + num of blocks returned for the node.
In hindsight the change documented here suggests that it will result in more open files, but I didn't immediately make the link between mmaped files and a ulimit setting for the process. Maybe a reminder to check ulimit would be helpful for others.

Still valid.

AC:

Document ulimit impact
Explain how index-header is obtained (not kept in compactor)
Explain the characteristics

Potentially in compactor.md

There's the PR #2668 open.


Fix issue templates

The current one is outdated and not working, so users don't see the placeholder.

Change to use a similar format to dotnet/core without any templates since we don't want people filing issues here

Perhaps make the .NET Framework choice the first one?


Add github actions for CI (#297)

This PR adds Github Actions support to the project, related issue is #297.

Removed azure-pipelines.yml and the badge from README.md.
If there are any references to azure that I omitted, let me know.

Cool, btw what do you think about a new patch release?

Done


Request to be able to rename tabs groups to something meaningful.

I've found your extension browsing for a tab managers/grouper and it Tab-Manager-v2 seem very good and simple at the same time, also it is very responsive.
But what I'd like is to be able to rename tabs groups to something meaningful than only the number of tabs in the header of the group.
Here's a quick mockup:

If you need more informations just ask me.
Best Regards :octocat:

To add a title is not hard. But it seems not very intuitive to manage.

You have to manually type the title.
The title will be lost if you accidentally close the window.
It's also a mess if you open some tabs not related to the current group.

Any idea for the above situations?

@xcv58 commented on 26 sept. 2018 à 23:34 UTC−4:

To add a title is not hard. But it seems not very intuitive to manage.

You have to manually type the title.

Only the first time we name it, after name should be saved in a DB and tagged to the tabs group until l the groupe is empty.

The title will be lost if you accidentally close the window.

Not if the name is saved in a DB and tagged to the tab group.

It's also a mess if you open some tabs not related to the current group.

Not really because I keep all my session clean with name like "Programming project XYZ", Movies, Android Stuff, etc...   So when I work on a project I just open the right tab group. 😊

I second this request! I was using Panorama View tab manager in Firefox and that allowed for naming of groups which was nice. It has a nice visual map of all windows and tabs you can pull up via hotkey as well.
Thanks for your work on this - will keep an eye out for updates.

I will try to implement this in https://github.com/xcv58/Tab-Manager-v2/issues/1821

Will implement in #2352


Marker cluster icons unavailables

I need to render a GMap with clustered markers. My code is:
$map = new Map();
$map->setStylesheetOption('width', '100%');
$map->setStylesheetOption('height', '450px');
$map->setMapOptions([
      'mapTypeId' => MapTypeId::ROADMAP,
      'zoom' => 10,
]);

foreach ($companies as $company) {
    $coordinates = new Coordinate($company->getLat(), $company->getLng());
    $marker = new Marker(
          $coordinates,
          Animation::DROP,
          new Icon($this->ah->getUrl('img/kinder-marker.png'))
    );
    $map->getOverlayManager()->getMarkerCluster()->addMarker($marker);
}

$map->getOverlayManager()->getMarkerCluster()->setType(MarkerClusterType::MARKER_CLUSTERER);

Everything works well, but my map doesn't show cluster icons. My web console output is:
Failed to load resource: the server responded with a status of 404 (Not Found)
http://myapp.dev/app_dev.php/images/m1.png

What can I do?

Hey @davidromani !
I just check quickly in the code which is responsible to render the marker cluster (https://github.com/egeloen/ivory-google-map/blob/master/src/Helper/Renderer/Overlay/MarkerClustererRenderer.php) and I don't see anything specific to assets/images management. I need to give it a try more deeply but for now, I don't know why the cluster icon cannot be resolved...
As a workaround, there is probably an option which allow to customize the cluster icon on the cluster manager.

@egeloen can you type me a hint about how to implement the workarround?

Use assets instead of getPath
Le 3 févr. 2017 16:10, "David Romaní"<EMAIL_ADDRESS>a écrit :

I need to reneder a GMap with clustered markers. My code is:
$map = new Map();$map->setStylesheetOption('width', '100%');$map->setStylesheetOption('height', '450px');$map->setMapOptions([      'mapTypeId' => MapTypeId::ROADMAP,      'zoom' => 10,]);foreach ($companies as $company) {    $coordinates = new Coordinate($company->getLat(), $company->getLng());    $marker = new Marker(          $coordinates,          Animation::DROP,          new Icon($this->ah->getUrl('img/kinder-marker.png'))    );    $map->getOverlayManager()->getMarkerCluster()->addMarker($marker);}$map->getOverlayManager()->getMarkerCluster()->setType(MarkerClusterType::MARKER_CLUSTERER);
Everything works well, but my map doesn't shows cluster icons. My web
console output is:
Failed to load resource: the server responded with a status of 404 (Not Found)http://myapp.dev/app_dev.php/images/m1.png
What can I do?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/egeloen/IvoryGoogleMapBundle/issues/193, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AIRLP86QHuTT_Bor2YlfSPLqwIp7CVlOks5rY0NngaJpZM4L2bqQ
.

Hum maybe I don't have understand well your issue... Are you talking about the marker clusterer icon (eg the icon which groups markers) or a single marker icon (eg img/kinder-marker.png) ?

I'm talking about the marker clusterer icon. My custom marker icon works well.

Ok, so, after re-reading the marker clusterer doc, it seems the library has evolved and I need to fix something here...
Aaccording to this README, you can use the following javascript:
// Init map and markers
var options = {
    imagePath: 'images/m'
};

var markerCluster = new MarkerClusterer(map, markers, options);

So, you can use the imagePath marker clusterer option in order to customize the image path:
$map->getOverlayManager()->getMarkerCluster()->setOption('imagePath', '/path/to/your/asset')

The available assets are here: https://github.com/googlemaps/js-marker-clusterer/tree/gh-pages/images

@egeloen thanks, it works!

Reopening as there is somethinng to patch as it does not work natively... The current issue is the marker clusterer library  takes the predicate you will download the library and integrate it to your app (with the assets) whereas the ivory google map only loads the marker clusterer library (javascript) without the assets...
I see two solutions:

Let it as it is and document the issue which explain to download assets locally and configure them or rely on online assets by using https://github.com/googlemaps/js-marker-clusterer/tree/gh-pages/images as imagePath).
Automatically configure the online assets by using https://github.com/googlemaps/js-marker-clusterer/tree/gh-pages/images as imagePath and document that by default it relies on github assets and let user choose it he wants to download the assets or not (but it works natively)

Personally, I prefer the second solution as it would make it working by default.

I will fix it with the second option since we already rely on github assets: https://github.com/egeloen/ivory-google-map/blob/master/src/Helper/Renderer/Overlay/MarkerClustererRenderer.php#L87


Sourcestone

Core Section

[X] I have searched for this issue on this repository
[X] This bug persist and I need help

Environment
Singleplayer/Local | NO LAN
Modpack Version
0.9a
Description
Sourcestone has no valid recipe. Per our conversation on Reddit, I am putting this in to remind you.. Thanks.
Procedure
Attempted to find recipe in JNI. None exists.
Attempted to use default recipe. Non-functional.
Additional things
No further data.

fixed on 595ed30.a and 595ed30.b

sended on Curseforge pending


[WIP] Restore tests on emulated platforms

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

You can recreate the failure locally with:
python build-locally.py --debug

# then, eventually
${PREFIX}/bin/python -c "import PySide6.Qt3DAnimation"

Likely need to install a CDT or something..... but i can't seem to fix it...

Thanks for the tip, I was not aware of the --debug switch.
However, I get a cannot excute binary file error when I try to run python.
I did:
$ (base) python build-locally.py linux_aarch64_python3.10.____cpython --debug
[conda@1f40b73b9780 work]$ cd /home/conda/feedstock_root/build_artifacts/debug_1692601628181/work/
[conda@1f40b73b9780 work]$ source build_env_setup.sh
[conda@1f40b73b9780 work]$ ${PREFIX}/bin/python -c "import PySide6.Qt3DAnimation"

you might need to install qemu-binfmt-static or some similar package for your linux distro on your host.


structures don't have the same sequence type

I ran  python train.py --problem=mnist --save_path=./mnist.
And got the following error. I have no idea what is wrong with it, can anyboby help?
Traceback (most recent call last):
File "/Users/ylfzr/Documents/Projects/learning-to-learn-master/train.py", line 117, in
tf.app.run()
File "/Users/ylfzr/anaconda/lib/python2.7/site-packages/tensorflow/python/platform/app.py", line 48, in run
_sys.exit(main(_sys.argv[:1] + flags_passthrough))
File "/Users/ylfzr/Documents/Projects/learning-to-learn-master/train.py", line 70, in main
second_derivatives=FLAGS.second_derivatives)
File "/Users/ylfzr/Documents/Projects/learning-to-learn-master/meta.py", line 401, in meta_minimize
info = self.meta_loss(make_loss, len_unroll, **kwargs)
File "/Users/ylfzr/Documents/Projects/learning-to-learn-master/meta.py", line 360, in meta_loss
name="unroll")
File "/Users/ylfzr/anaconda/lib/python2.7/site-packages/tensorflow/python/ops/control_flow_ops.py", line 2775, in while_loop
result = context.BuildLoop(cond, body, loop_vars, shape_invariants)
File "/Users/ylfzr/anaconda/lib/python2.7/site-packages/tensorflow/python/ops/control_flow_ops.py", line 2604, in BuildLoop
pred, body, original_loop_vars, loop_vars, shape_invariants)
File "/Users/ylfzr/anaconda/lib/python2.7/site-packages/tensorflow/python/ops/control_flow_ops.py", line 2561, in _BuildLoop
nest.assert_same_structure(list(packed_vars_for_body), list(body_result))
File "/Users/ylfzr/anaconda/lib/python2.7/site-packages/tensorflow/python/util/nest.py", line 200, in assert_same_structure
_recursive_assert_same_structure(nest1, nest2, check_types)
File "/Users/ylfzr/anaconda/lib/python2.7/site-packages/tensorflow/python/util/nest.py", line 173, in _recursive_assert_same_structure
_recursive_assert_same_structure(n1, n2, check_types)
File "/Users/ylfzr/anaconda/lib/python2.7/site-packages/tensorflow/python/util/nest.py", line 173, in _recursive_assert_same_structure
_recursive_assert_same_structure(n1, n2, check_types)
File "/Users/ylfzr/anaconda/lib/python2.7/site-packages/tensorflow/python/util/nest.py", line 173, in _recursive_assert_same_structure
_recursive_assert_same_structure(n1, n2, check_types)
File "/Users/ylfzr/anaconda/lib/python2.7/site-packages/tensorflow/python/util/nest.py", line 173, in _recursive_assert_same_structure
_recursive_assert_same_structure(n1, n2, check_types)
File "/Users/ylfzr/anaconda/lib/python2.7/site-packages/tensorflow/python/util/nest.py", line 159, in _recursive_assert_same_structure
% (type_nest1, type_nest2))
TypeError: The two structures don't have the same sequence type. First structure has type <type 'tuple'>, while second structure has type <class 'sonnet.python.modules.gated_rnn.LSTMState'>.
Macos 10.12.6
tensorflow version used:  1.3.0

I had the same problem today. Will be interested if you find how to fix it!

I had the same problem today, on ubuntu 16.04 and tensorflow 1.4.0

Encountering the same problem with Centos, kind of hoping for a solution.

I had the same problem. I solved it by using these versions of tensorflow and sonnet. dm-sonnet  requires tensorflow 1.5 , see -> https://github.com/deepmind/sonnet .
pip uninstall tensorflow
pip uninstall dm-sonnet
pip install tensorflow==1.5.0
pip install dm-sonnet==1.7
I hope this helps,
Federico

same problem here - even though I have tensorflow 1.7. Does it have to be version 1.5? Has anyone tried/figured out a way around this? Thanks.

having the same problem even change to tf 1.5.0. Did anyone figure out any possible solutions to this problem yet? Thank you.

@mily33 's method works with tf1.4.1 on Mac and Ubuntu. Thanks!

had similar problems, @mily33 solved the issues. would it be possible to have a PR to fix this on the main repo?

It works like a charm! Thanks @mily33

@mily33 Thanks a lot for solving the problem