Installing gstreamer doesn't work

This is what I see when I attempt to install:
david@DAVENG-PC2 - C:\Users\david\dev
λ python -m pip install kivy.deps.gstreamer --extra-index-url https://kivy.org/downloads/packages/simple/
Collecting kivy.deps.gstreamer
  Could not find a version that satisfies the requirement kivy.deps.gstreamer (from versions: )
No matching distribution found for kivy.deps.gstreamer

sdl2 and glew installed just fine, I'm not sure what could be causing gstreamer to fail.
Relevant details about my environment:

Python 3.4.3 64-bit
Windows 10

Temporarily download it from here and install manually. I should work soon :)

Is 'kivy.deps.gstreamer-0.1.7-cp34-cp34m-win_amd64.whl' the one I want to use? I get a different error when trying to install that directly:
david@DAVENG-PC2 - C:\Users\david
λ python -m pip install "C:\Users\david\dev\kivy.deps.gstreamer-0.1.7-cp34-cp34m-win_amd64.whl"
kivy.deps.gstreamer-0.1.7-cp34-cp34m-win_amd64.whl is not a supported wheel on this platform.

Is your python an official version or you compiled from source? Also try to change cp34m to none.

This issue should be fixed, please try with installing again with the original commands.

@KeyWeeUsr There was no 'none' file for 0.1.7 but I tried 0.1.6 and got the same error:
david@DAVENG-PC2 - C:\Users\david
λ python -m pip install "C:\Users\david\dev\kivy.deps.gstreamer-0.1.6-cp34-none-win_amd64.whl"
kivy.deps.gstreamer-0.1.6-cp34-none-win_amd64.whl is not a supported wheel on this platform.

@dessant Tried the original command again, same result. :(

@KeyWeeUsr Also, yes, this is an official installation.

You might need to upgrade pip if it's a fresh installation of python or if pip is just too old:
python -m pip install --upgrade pip

If that doesn't work, I have no idea what then.

I'm getting the same error with py3.4 32bit.

Same for py2.7 32bit

@matham, thoughts?

Works through Drive though, so as I suggested, the redirect might be an issue (too) 😋

That part is fixed, they are hosted on the server.
https://kivy.org/downloads/packages/simple/kivy.deps.gstreamer/

Apologies, looks like I had a user account environment PATH set for python 2.7 32-bit and a system environment path set for python 3.4 64-bit. The 2.7 was overriding the 3.4 hence the "not supported on this platform" message. The original link works as well.
Sorry again for the confusion. This can be closed.


[VL][1.2] Branch 1.2 fix spill hang use new velox

Just run ci

JUST PICK 2 PR AND USE VELOX BRANCH 08-08 FOR TEST

Run Gluten Clickhouse CI


Generate a jazzy.yaml file

We need to generate a jazzy.yaml config file to permit generation of docs from the Swift docstrings. See:
https://azure.github.io/azure-sdk/ios_documentation.html#swift-docstrings
ping @bsiegel as he did most of the docs generation for azure-sdk-for-ios

Yep, check out https://github.com/Azure/azure-sdk-for-ios/tree/master/.jazzy and https://github.com/Azure/azure-sdk-for-ios/blob/master/Scripts/build_api_docs.sh


Setup pre-commit check and fix all existing issues

What this PR does / why we need it:
We should merge this first before new PRs so we can follow the same styles and best practices Using pre-commit to enforce this. Run pre-commit run --files $(find ftlib test -name '*.py' -print0 | tr '\0' ' ') to automatically fix all the issues detected by pre-commit hooks.
Which issue(s) this PR is related to (optional, link to 3rd issue(s)):
Fixes #
Reference to #

Special notes for your reviewer:
/cc @your-reviewer

Release note:

NONE

/assign @ddysher @gaocegege @zw0610 @pendoragon

LGTM, defer to @zw0610

/lgtm


[Feature Request] Other Format Support & Directory Listing

Not sure if this is out of the scope of the project, but I figure I should ask.
It would be absolutely amazing to be able to use your reader as a full reader, not just for pdf's. This is a limiting factor imo. It would be nice to at minimum have epub and archive support.
My second request was to have a directory view on launch, or basically a favorited directory where you can see all your books in that directory. Would be easier than browsing all the way to the directory each time. However I'm unsure if this was avoided purposely for a security reason, which would be understandable. But if possible, it would be nice.

My second request was to have a directory view on launch, or basically a favorited directory where you can see all your books in that directory. Would be easier than browsing all the way to the directory each time. However I'm unsure if this was avoided purposely for a security reason, which would be understandable. But if possible, it would be nice.

We have to use the system UI to access files in the profile's home directory since we don't use the deprecated Storage permission. It would be possible to request persistent access to a directory from the user via the system UI, but we don't really want to make our own file access interface based on that.
I'd suggest opening the directory in the OS Files app and browsing there, and opening them from there in the PDF Viewer app.

This could be done with something like https://github.com/futurepress/epub.js/ but it probably makes more sense as a separate app with a partially shared codebase. It would be a lot more difficult to maintain it as one app. We're already struggling to find the development resources to maintain and improve this app due to being more focused on many other things. Ideally, we could find someone heavily interested in working on this and also in making a separate epub app based on it.

I've filed https://github.com/GrapheneOS/os_issue_tracker/issues/381 to track the creation of an epub viewer based on this app. It's going to need to wait until after planned overhauls of this app and we'll need to find someone interested in working on it. I need to reach out to the person who was helping me with this app to see if they're still interested in working on it. Once progress is made, maybe they'd be interested in working on that too. Also possible we can find other people interested in working on this.
I don't think we want to make any kind of file manager interface in the app though, and I don't see a better way of delegating to the system file management UI than what we're already doing.


Event GDB

Is your feature request related to a problem? Please describe.
Create a schema that will serve as a framework to handle the nearly limitless different features all-hazards teams may be asked to capture.
Describe the solution you'd like
Create flexible schema
Describe alternatives you've considered
Creating schema from scratch at every incident.
Additional context

[x] Compare template database to current NWCG and USAR databases for best practices
[ ] Create script for creating categories/domains from Excel document #14
[ ] Export schema as xml for creation/versioning
[ ] When complete create py code for mapping columns (in case we change them in the future) that downstream code can use to reference.

@t-mahon @BWS90 -- Here is my most recent go at the event GDB. I have attached zips of both the gdb and the xml that is used to create the gdb (quite a smooth process actually). Take a look and let me know what I missed. I think this will be a good enough start to get some of the tools moving in the right direction. Please pass updates to me or update the xml document on this branch.
test_event_gdb.gdb.zip
event_gdb_schema.xml.zip

The current state of affairs is below:
Event GDB Issues
Domains
AGP

AlterDomain tool works as advertised

Limited to file GDB

AGOL

Requires updating the service definition
There appears to be a tool inside the solution deployment plugin that updates domains on a hosted FS
I have been unable to access the tool outside the task viewer
Once domains are updated, current layers in AGP do not pick up the new domains
Even adding data to new map after update does not pull new domains

Mobile

Domains are supported almost entirely across the mobile app portfolio

Subtypes

Unable to symbolize by field other than field used to create subtype

Contingent Values
AGP

Works great

AGOL

Doesn't seem to have full support
Unable to edit contingent values on hosted FS from either AGP or AGOL

Mobile

Works with QC/S123 as you can set the attributes manually

Requires extra setup overhead

Promised support by Field Maps by spring 2022


Allow specification of a custom Node Resource Group

While I was at it, I also implemented this one.
Fixes #9

Merge to edit


idf.py menuconfig hangs on mesh examples (IDFGH-5994)

Environment

Development Kit: ESP32-Wrover-Kit
Module or chip used:  ESP32-WROOM-32
IDF version (run git describe --tags to find it): v4.3.1
Build System: idf.py
Compiler version (run xtensa-esp32-elf-gcc --version to find it): 8.4.0
Operating System: Linux
Using an IDE?: No
Power Supply: USB

Problem Description
When running idf.py menuconfig, the menu opens up but it just hangs. I have tried on master, v4.2, v4.1, v4.0, and v3.3, and they all have the same issue.
Expected Behavior
Should be able to navigate through the menu and make config changes.
Actual Behavior
Hangs upon opening.
Steps to reproduce

git checkout v4.3.1
cd examples/mesh/internal_communication
idf.py menuconfig

Could you please try to run idf.py fullclean before idf.py menuconfig. Please share also the full intput of idf.py menuconfig (before CTRL+C and the trace).


Merges Main into Next

Merges main changes into next

The google-cloud plugin tests need to adapt to runFlow being gone on this branch, and then I think this works.


Mp/multikey

Foundations for multikey support: use key view instead of users/client to resolve requestor
ping @opscode/lob @manderson26

This has been updated as follows:

use new chef_authn  w/ multikey support
limit keys checked to non-expired.
squash and cleanup

Has a dependency on:
https://github.com/opscode/enterprise-chef-server-schema/pull/20

I figured out why the tests aren't passing, but I am not clear enough on the changes here to know why this is, but basically, a client is making a request in the test and its hitting authorized_by_org_membership_check.
This function checks if (State#base_state.requestor)#chef_requestor.type is equal to <<"client">>, and if it is, it skips checking if the agent is a member of the org. However, (State#base_state.requestor)#chef_requestor.type is undefined after these changes (for clients at least, I suspect for users too though). I verified this via printing it and setting the check in line 348 to check for undefined and all the tests passed.
Need to fix this branch to it properly sets (State#base_state.requestor)#chef_requestor.type or update the code that uses it.


Add missing transform-box property.

Fixes #45.

Actually it does not seem to be enough.
The following test still fails:
#[test]
fn test_54() {
    let style = style_test! {
        .errorSign {
            transform-box: fill-box;
            transform-origin: center;
        }
    };
    assert_eq!(
        style,
        ".errorSign.test{transform-box: fill-box;transform-origin: center;}"
    );
}

Replacing with PR with a test.


Update PULL_REQUEST_TEMPLATE to include an API spec change in the checklist.

Coming from https://github.com/opensearch-project/opensearch-api-specification/issues/387, update PR template to include a checkbox that requests that all API changes be documented in the OpenAPI spec used to generate clients.

Build should be fixed by https://github.com/opensearch-project/opensearch-oci-object-storage/pull/62

@dblock could you rebase please? thank you

@dblock Eh, I'm not sure about this PR. I dislike unnecessary boilerplate, and it strikes me as unlikely that a repository plugin would ever need to implement a user-facing API that would require a change to the specification.

@andrross If you don't think this plugin will ever implement a REST API then we can just close it. Your call!

Can any current maintainers please merge this?
@samuel-oci @anasalkouz @VachaShah?


scaffold raises IsADirectoryError on Linux

Resolved by ploomber/ploomber#323

Fixed at 500cc0f73d8fe178943a622c4f277e1c592c9c3e (0.2.4 release)


Add arbitrary labels to data in collector and transformation stanzas

Is your feature request related to a problem? Please describe.
It should be possible in any collector or transformation to set an arbitrary tag for use later in the pipeline to describe what has happened to data.
Describe the solution you'd like
For all collectors and transformations, a simple declaration of a tag name and value would be ideal. For the purposes of this feature request, I'd call them "arbitrary tags" or "atags" for short. Something like:
{
"atags": {
"specialstringnameimadeup": "Frobozz",
"asamplevalue": 24  }
}
Tags could be numeric or strings. Any number of key/value sets are supported. (maximum length?) If there is something already in the "atags" field with that exact name in the message before it was collected by this instance, the new value should overwrite it.
Describe alternatives you've considered
Port ID or IP address is a weak way of identifying what has happened to a packet; I hate keeping those matrix mappings somewhere - it makes life exceptionally difficult.
Additional context
The methods applied to any data packet should be able to be identified by something upstream from that source. Tagging seems like the most natural way to do it.  I would like to know further down the chain what has happened to this data, or where it came from, and adding arbitrary tags seems like the way to do this.

Hi John,
As always, your feature requests are really valuable to enhance this tool.
I will review how to implement properly your request and come back to you with updates.
Thank you for your contributions
Denis

Looks like  you did this in the pipeline branch, so ... excellent!  It does appear to work, and I've done some preliminary testing with simple tag names.

A specific pull request will be come with tests and cleanup.
I realize that I haven't implemented exactly what is asked there. In the pipeline branch, I implemented a list instead of a dict.
{ "atags": [ "specialstringnameimadeup: Frobozz", "asamplevalue": 24 ] }
instead of
{
"atags": {
"specialstringnameimadeup": "Frobozz",
"asamplevalue": 24 }
}

If the ordering is not important I can switch to dict as requested.

The matching of any to key:value label has been added to the pipeline branch (in a generic way)
It is not yet production-ready, but it should work.
If the key is a list, you need to provide the index or use '*' to search on each item in the list."
atags.tags.*: google
  - name: match-tag
    dnsmessage:
      matching:
        include:
          atags.tags.*: google
      drop-policy: "unmatched"
    routes: [ outputfile, console ]

Amazing - will try out tomorrow!  Does it support regular expressions?

Amazing - will try out tomorrow! Does it support regular expressions?

yes and also match-source


search example should be updated

all search examples in https://github.com/boostorg/algorithm/blob/develop/example/search_example.cpp
should be updated with
ba::boyer_moore_search ( haystack.begin (), haystack.end (), needle1.begin (), needle1.end ()) != std::make_pair(haystack.end(), haystack.end()) instead of haystack.end() alone.

Updated on develop in 9093abb

Merged to release.


Towny + LuckPerms issue

There is a weird issue with towny, that sometimes a user doesnt get their permissions from townyperms, and I have to run /lp sync to make it work, is there a way to fix this permanently?
I changed this sync-minutes: 3 to the luckperms config to see if it works, havent tested it yet, as the issue is random, I  never had this issue before with PermissionsEx.
the only changed i have made in my lp config.yml are
split storage: enabled: true
use-server-uuid-cache: true
I'm using LuckPerms 4.1.63 and towny  <IP_ADDRESS> spigot 1.12.2

Just to be sure, please update to the latest build. You're almost 200 builds out of date https://ci.lucko.me/job/LuckPerms/

Good chance this has been fixed already, so as merj said, please try updating first :)

This error is back in Towny <IP_ADDRESS>, Spigot 1.13.2, LuckyPerm version 4.3.38.

Update: With luckyperm version 4.3.47, it's the same

LuckPerms*

Thank you very much for this correction that was so necessary

Thank you very much for this correction that was so necessary

I mean you call it LuckyPerms 🤷♂

Open a new issue with all of the information you have please. :)


Memory leak patch

In theory this should patch at least some of the memory leaks we have been seeing. I got it to compile on windows but for some reason some of the other modules had errors when I downloaded the code and so I was not able to properly run the tests even though it built.
Hope this helps, and thank you guys for all you have done!

I'm sorry but this change nothing apart from modifying the code structure in the ser.rs source file and adding AI generated comments.


When there is a new import, set PackageLockingMode=SOFT for it and its dependencies

Purpose
$ subject
Fixes https://github.com/ballerina-platform/ballerina-lang/issues/42467
Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[ ] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

This change is no longer valid with the new design changes to sticky/ dependency resolution.


impl Mul for Gt x Gt

implement Mul trait for Gt x Gt.
Since the Fq12 field, i.e. Gt -> 0 is a private field, its not possible to multiply two instances of Gt

Closing this PR since it was not needed


Error: "data did not match any variant of untagged enum PackageMaintainers at line 2361 column 7"

Saw your flake on FlakeHub and thought I would give it a go. I added it to my config and tried running:
nix2sbom --current-system

and I got the following error:
[00:00:00.000] (7f28fe0877c0) INFO   Getting the derivations from the current system.
[00:00:01.197] (7f28fe0877c0) INFO   Found 10375 derivations
[00:00:01.197] (7f28fe0877c0) INFO   Getting the metadata for packages in the Nix store
Error: "data did not match any variant of untagged enum PackageMaintainers at line 2361 column 7"

I tried some more things and got the same or similar looking errors:
╭─mcamp on butler in ~/code/campground-nvim on master🔥
╰─🚧 nix2sbom -f .#
[00:00:00.000] (7fc8d82b47c0) INFO   Getting the derivations from file .#.
[00:00:02.779] (7fc8d82b47c0) INFO   Found 4344 derivations
[00:00:02.779] (7fc8d82b47c0) INFO   Getting the metadata for packages in the Nix store
Error: "data did not match any variant of untagged enum PackageMaintainers at line 2361 column 7"
╭─mcamp on butler in ~/code/campground-nvim on master🔥
╰─🚧 cd ../vault-secrets
╭─mcamp on butler in ~/code/vault-secrets on main✔
╰─🚧 nix2sbom -f .#
[00:00:00.000] (7f0a885e47c0) INFO   Getting the derivations from file .#.
[00:00:00.448] (7f0a885e47c0) INFO   Found 654 derivations
[00:00:00.448] (7f0a885e47c0) INFO   Getting the metadata for packages in the Nix store
Error: "data did not match any variant of untagged enum PackageMaintainers at line 2361 column 7"

campground-nvim and vault-secrets are flakes of mine, the nvim one is based on nixvim and the other is a simple shell script flake I was playing with the other night.
I very well might be doing something dumb, because I only marginally know what I'm doing. So if I am way out in left field let me know..

@usmcamp0811 thanks for reporting the issue!
This step is fetching the metadata for the packages in your store, which explains why I wasn't able to reproduce locally.
You can generate the metadata information for your Nix store with the following command:
nix-env -q -a --meta --json '.*' > packages-metadata.json

You can then call nix2sbom with the --metadata-path option to use a pre-generated metadata, for example:
nix2sbom -f .# --metadata-path packages-metadata.json

If you could do the following two commands and send me the derivation that is located at line 2361 (or whatever line it will be once you try again), that would help me troubleshooting faster. Thanks a lot!

I tried running those commands and got:
╭─mcamp on butler in /config on nixos🔥
╰─🚧 nix-env -q -a --meta --json '.*' > packages-metadata.json
╭─mcamp on butler in /config on nixos🔥
╰─🚧 nix2sbom -f .# --metadata-path packages-metadata.json
[00:00:00.000] (7fc99ef0f7c0) INFO   Getting the derivations from file .#.
Error: Custom { kind: UnexpectedEof, error: Error("EOF while parsing a value", line: 1, column: 0) }
╭─mcamp on butler in /config on nixos🔥
╰─🚧 nix2sbom -f .# --metadata-path /config/packages-metadata.json
[00:00:00.000] (7f40b6af07c0) INFO   Getting the derivations from file .#.
Error: Custom { kind: UnexpectedEof, error: Error("EOF while parsing a value", line: 1, column: 0) }
╭─mcamp on butler in /config on nixos🔥
╰─🚧 nix2sbom -f .#butler --metadata-path /config/packages-metadata.json
[00:00:00.000] (7fec1f50b7c0) INFO   Getting the derivations from file .#butler.
Error: Custom { kind: UnexpectedEof, error: Error("EOF while parsing a value", line: 1, column: 0) }

I dunno about uploading that packages-metadata.json its 128MB. If you need it I can figure a place to put it.

@usmcamp0811 thanks for the snippet! I was able to capture the bug in a unit test and provide a fix in https://github.com/louib/nix2sbom/pull/24.
I'm not sure why you were getting the UnexpectedEof errors when trying to use the --metadata-path path option :thinking: I tried reproducing locally but didn't get that error.

@usmcamp0811 please give it another shot with version louib/nix2sbom/0.1.106+rev-db34541fdf1017060bfaefa60c3b8867c7518aa6, which should be available from Flakehub now.

@usmcamp0811 I'm going to close this one, let me know if you run into the issue again.


Please document the pagefile resource

What is automatic_managed and system_managed?

This is now documented to the README.
system_managed - configures whether the system manages the pagefile size. [true, false]
automatic_managed - all of the settings are managed by the system. If this is set to true, other settings will be ignored. [true, false], default: false


Implement Exception handler in file sender/receiver

Do not exit_with_msg at

Invalid filename
File cannot open

send_file, receive_file function need to be fixed.


Worse performance with DiverseBlock for Cifar10, ResNet18

Hello.
Thank you for your interesting work, and code.
I tried using your Diverseblock in ResNet18 (according to your instructions, replacing conv+bn with diverse blocks). My code is based on https://github.com/kuangliu/pytorch-cifar. The accuracy drops from 95.4% to 95.1%. Do you have any ideas for why this is?
Thank you.

Hi,
It may be due to the overfitting. The baseline of 95.4% on CIFAR10 is pretty high, suggesting that the model fits the data pretty well. With DBB, it may overfit. You may change the weight decay or use dropout.


Prepare for the 0.46 release

Summary
This commit prepares the 0.46.0 release, this involves 2 steps first changing all the version numbers to 0.46.0 from 0.45.x and secondly updating the release notes to prepare them for publishing.
There are some larger than normal changes to the release notes made in this PR. Because of the nature of how 0.46 was developed in parallel to 0.45.x, the merge commits used to sync changes from stable/0.45 to stable/0.46 cause reno to be unable to determine which tag a release note is associated with reliably. To ensure reno is able to determine all the 0.46.0 release notes go together this commit squashes all the applicable release notes into a single new file (along with adding a prelude). As part of this process the release notes were edited for consistency and accuracy. Some other changes to note are:

The release note about the deprecation of qobj input to UnitarySimulatorPy was removed as it's been subsumed by the deprecation of UnitarySimulatorPy
The release note about the removal of the deprecated clifford_decompose and cnotdihedral_decompose was removed and those functions were restored as breaking API changes were not allowed in this release. Similarly the qiskit.synthesis.Quaternion path was restored.
Bumped the cibuildwheel version used to build wheels to v2.16.5 which is needed to fix compatibility with newer powershell releases now that the Github actions windows images bumped the powershell version installed.

Details and comments
TODO:

[x] Wait for last PRs to merge and then rebase on top
[x] Finish going through release notes and updating.

One comment is that the CI artifact I used to check the rendered notes didn't seem to catch this new file, the prelude didn't show up and they were labeled as 0.45.0-34:

This is an artifact of the release_notes.rst pointing to the branch stable/0.46:
https://github.com/Qiskit/qiskit/pull/11697/files#diff-d778557532960c8ff205506cdecb469236ec50ca060b2da4c0b9843533a43f1a
it will render the release notes from whatever your local branch with that name is

I think this is ready for review so we can tag 0.46.0 once it's merged. The only open question is if we need to do anything related to: https://github.com/Qiskit/qiskit/issues/11512#issuecomment-1921274930

I pushed up a commit that adds a timeline into all the decorators.  There's other use of DeprecationWarning where I added a timeline, but not all - just too much.


Negative arrival times

This is what my card looks like after following the install. Has anyone else reported similar?

I've seen something similar but only for a few seconds. If the list of arrivals is out of date, then the custom card code will calculate a negative number of minutes until arrival (time of arrival - now). I notice this when I wake a wall mounted tablet up with motion, and it renders the card with old data for a second or two before it loads new data.
I think I need to filter any arrivals that are in the past in the render() function of the custom card. Perhaps I should display a loading indicator instead of the content if the list of arrivals looks like it is out of date.
If what you see doesn't refresh with up-to-date info within a few seconds, perhaps you have another problem too.  I don't suppose you configured the "refresh interval" setting to a very long value? It defaults to 30 seconds.

Actually, I just encountered a similar problem. The addon has stopped updating the HS sensor entities. Restarting the addon resolved the issue. I'll look into the reasons for this, but can you confirm if it's the same for you?

Restarting the add on corrects the times for me. I left the refresh at the default. Great addon BTW.

I believe this bug has happened to me once, and while investigating it I confirmed that the main server process (the TFI-GTFS python server) was running fine, and could be queried for stops. The problem seemed to be in the addon's run.sh bash script, which is responsible for polling the server process for upcoming arrivals and writing the results into HA entities. I suspect that something crashed the infinite loop in the update_sensors() function in that bash script. I've added some addition logging to my local version and will look more closely if it happens again.

I think I caught this bug red-handed, so to speak. It took 2 weeks for it to happen again. Here's some log output from the add-on at the point that it occurs. The Updated sensor.tfi_gtfs_stop_NNNN stuff is additional debug output I added. The problem occurs when these messages stop being output, near the top of the log snippet below. It seems to have been precipitated by the python app not handling an unexpected response from the TFI server. Pasting here for my own reference. I'll work on fixing this as soon as I have time.
Until then, a restart of the add-on resolves the problem.
DEBUG:root:Live feed updated.
Updated sensor.tfi_gtfs_stop_2189
Updated sensor.tfi_gtfs_stop_1409
ERROR:server:Exception on /api/v1/arrivals [GET]
Traceback (most recent call last):
  File "/usr/lib/python3.11/site-packages/flask/app.py", line 2190, in wsgi_app
    response = self.full_dispatch_request()
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/flask/app.py", line 1486, in full_dispatch_request
    rv = self.handle_user_exception(e)
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/flask_cors/extension.py", line 176, in wrapped_function
    return cors_after_request(app.make_response(f(*args, **kwargs)))
                                                ^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/flask/app.py", line 1484, in full_dispatch_request
    rv = self.dispatch_request()
         ^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/flask/app.py", line 1469, in dispatch_request
    return self.ensure_sync(self.view_functions[rule.endpoint])(**view_args)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/server.py", line 154, in decorated_function
    response_data = func(*args, **kwargs)
                    ^^^^^^^^^^^^^^^^^^^^^
  File "/app/server.py", line 282, in arrivals
    'arrivals': gtfs.get_scheduled_arrivals(stop_number, now, datetime.timedelta(minutes=args.minutes))
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/gtfs.py", line 470, in get_scheduled_arrivals
    agency_name = self.store.get('agency', route_info['agency'])
                                           ~~~~~~~~~~^^^^^^^^^^
TypeError: 'NoneType' object is not subscriptable
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/usr/lib/python3.11/json/__init__.py", line 293, in load
    return loads(fp.read(),
           ^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/json/__init__.py", line 346, in loads
    return _default_decoder.decode(s)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/json/decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
DEBUG:root:Updating from live feed.
DEBUG:root:Got 899 trip updates, 6618 unrecognised trips, 320 added trips, 0 cancelled trips
DEBUG:root:Live feed updated.

I think this should be fixed now, after this commit, which guards against unrecognised routes being present in the live data feed, which could cause calls to the server to return a 500 error, which would cause the bash loop in the addon run.sh to crash. The error was so intermittent that I'm going to leave this open for a bit until I feel more confident that it doesn't reoccur.


feat: Allow step restart on workflow retry. Closes #2334

This allows retryStrategy to contain restartOnWorkflowRetry, in which case the entire node (and therefore all descendent nodes) will be restarted if they haven't all already succeeded and the workflow is retried.
See: #2334 for more info
Checklist:

[X] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
[X] The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
[X] I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
[X] Optional. I've added My organization is added to the USERS.md.
[X] I've signed the CLA and required builds are green.

@sarabala1979 I think this is your area of expertise?

@sarabala1979 hi, any feedback on this?

but a user triggering a retry wouldn't know what to pass in to be fully restarted

If a user would tag a certain template as restartOnWorkflowRetry, wouldn't they be able to specify that same template when using argo retry? After all, we're not implementing automatic Workflow retries in this PR (#1578), so some user intervention/third-party scripting is still required to restart the Workflow. Why can't the user/script be able to supply which steps to be retried with argo retry?

I do think this information best belongs with the workflow, which means storing at least that in the workflow template. But I don't think that's very invasive.

Let me gather some more opinions with the team and get back to you. Could be that you're right and I'm a bit too stringent 🙂

Let me gather some more opinions with the team and get back to you.

Hi @mark9white. The team agreed that we won't want to support this sort of labeling on the Workflow spec. This feature is still very much desired, but we'll have to find a way to specify which nodes to restart fully on the client-side.

Thanks for following up with the team. I could make this work by providing the ability to specify nodes to restart by templateName - would that be ok?
Doing this is not ideal for Argo users - has the team had any thoughts to providing first-class support for triggering asynchronous jobs from Argo without using polling? An example would be triggered a Spark job (eg directly or using something like Amazon EMR) where you would have one step trigger it and then a suspend step that waits for the job completion.

I have just modified the PR so the retry command takes in a --reset-nodes-field-selector parameter.

I have just modified the PR so the retry command takes in a --reset-nodes-field-selector parameter.

Thanks @mark9white! I'll take another look.

Doing this is not ideal for Argo users

Do you mean using the --reset-nodes-field-selector  approach? Would you mind explain a bit why?

I have just modified the PR so the retry command takes in a --reset-nodes-field-selector parameter.

Thanks @mark9white! I'll take another look.

Doing this is not ideal for Argo users

Do you mean using the --reset-nodes-field-selector  approach? Would you mind explain a bit why?

Because the person running 'retry' needs to know what selector to pass in to effectively retry the given workflow.

@simster7 I've applied the feedback.

Hey @mark9white. Could you resolve the conflicts here please?

Done!
On Thu, 9 Apr 2020 at 02:32, Simon Behar<EMAIL_ADDRESS>wrote:

Hey @mark9white https://github.com/mark9white. Could you resolve the
conflicts here please?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/argoproj/argo/pull/2431#issuecomment-611278219, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AABO7LSDUJXOVW6A7VFMT33RLUQTPANCNFSM4LHE2LVA
.

Actually there is an issue in the e2e tests, which I'm looking into.

I've retriggered the build as it failed on TestLogProblems (which is unrelated and looks to be flakey).

I'm still seeing TestLogProblems failing, but I don't think related to this PR.


Python3 unicode support

Every API call in the python bindings calls cstr when going to C code and pyNativeStr when returning. Because these functions use "charmap" encoding, emojis can't be used for anything from the python API (e.g. comments, background progress, bv.find_next_text). Can it either be hardcoded to utf8 or have it be a setting that defaults to charmap?

So the answer for this is to define pynativestr differently for python2 and python3. Python3 should use utf8, while python2 uses an actually for loop to decode the bytes.

I should actually further say that this isn't true... The following snippet generates a UnicodeDecodeError:
for i in range(256):
   b = i.to_bytes(1, "big")
   b.decode("utf8")

So just utf8 isn't the right encoding either.
Anyways, I'll be pushing a fix for this later today.

Of course, some bytes indicate that it's a multi-byte character. It's not meant for converting bytes in the binary, it's for displaying user defined things mostly

Should be fixed in 1.1.1768-dev.


Mis-applied tardiff

Found an example of tars that don't diff and patch correctly
$ curl -O https://fishsoup.net/misc/ubi8-8.0-129.tar.gz
$ curl -O https://fishsoup.net/misc/ubi8-8.0-154.tar.gz
$ tar-diff ubi8-8.0-129.tar.gz ubi8-8.0-154.tar.gz ubi8 .tardiff
$ mkdir ubi8-8.0-129
$ tar -C ubi8-8.0-129 -xf ubi8-8.0-129.tar.gz
$ tar-patch ubi8.tardiff ubi8-8.0-129 ubi8-8.0-154-reconstructed.tar
$ zcat  ubi8-8.0-154.tar.gz | sha256sum
25311323356d6a4a125dd592d8827054a9d14ef8e161ea2c073571a087346013
$ sha256sum ubi8-8.0-154-reconstructed.tar
6d25ba633a6297a61b001d3340bc92b6dd1938b0caf8c56686885402071822f2

The reconstructed tar file has the right number of bytes
It unpacks into a file system tree with the right files, and the right size and permissions
The contents of two files are wrong:

usr/lib64/python3.6/__pycache__/_pydecimal.cpython-36.pyc
usr/lib64/python3.6/__pycache__/gettext.cpython-36.pyc

If you repack the tarballs with GNU tar or libarchive's bsdtar, the problem doesn't occur

All a bit mysterious! :-)

This is fixed in master, i think it was https://github.com/containers/tar-diff/commit/55be8aea7c7c9cb8698334af11a7d18707c7b197


support upload in command prompt ?

Does cryptletter support uploading messages via curl in command line mode?

Unfortunately not.
Since cryptletter encrypts messages on the client side, it would require to prepare the payload in a very specific way, before sending it out with curl.
It should be possible to implement those client mechanics in the cli, for example:
# NOTE: Proposal, this does not work
echo "Secret message" | cryptletter message:post -e https://remote-cryptletter-instance.example.com

Sounds like a solid feature, I'll add it to the roadmap.


Make more consistent with Nuclide, switch to mucomplete.

Also includes some improvements so that it works better on cygwin.


Is type xlib_vc2_array_t still needed?

We check for differences in our schemas between a clean installation and an upgrade.
I noticed that the xlib_vc2_array_t type was missing in a clean instalation.
I found a xlib_vc2_array_t.sql that creates that type but that script isn't called in the patch.sql or user_install.sql.
It is not dropped as well in those scripts.
Do we still need that xlib_vc2_array_t type

No, it is not, it is old and no longer used. You are correct. I have removed it for 2.9.0.
Thank you.


preparation to get rid of jxcore specific utils

The most breaking changes are in tools/android/* and tasker/android.js. I general tasker/android.js was rewritten into promises.

This change is

@yaronyg @andrew-aladev @chapko please review only file logger.js

I think it's to to start reviewing this PR.

Reviewed 9 of 15 files at r1, 6 of 9 files at r2.
Review status: 15 of 19 files reviewed at latest revision, 8 unresolved discussions.

logger.js, line 12 at r2 (raw file):

const util = require('util');
const format = util.format;

const { format } = require('util');

logger.js, line 14 at r2 (raw file):

const format = util.format;

function Logger(options) {

Since you're using ES next, you can rewrite it with class syntax

logger.js, line 23 at r2 (raw file):

  const filePath = this._filePath;
  if (filePath) {
    const message = format.apply(null, messages) + '\n';

Use spread operator:
format(...messages)

logger.js, line 35 at r2 (raw file):

  const now = new Date().toISOString()
    .replace(/T/, ' ')
    .replace(/.[^.]+$/, '');

I suggest something like:
new Date().toISOString().replace(/[TZ]/, ' ').trim();

Milliseconds are important in the logs.

logger.js, line 42 at r2 (raw file):

Logger.prototype.error = function() {
  this._log(console.error, chalk.red, Array.from(arguments));

You can use rest syntax here:
error (...messages) {
  this._log(console.error, chalk.red, messages);
}

builder/virtual.js, line 332 at r2 (raw file):

        if (job.target != 'all') {
          if (job.target == 'ios') {
            execSync('cd ' + __dirname + '; rm -rf ' + prPath + '/build_android');

It reminds me of little bobby tables :)

internal/tester.js, line 10 at r2 (raw file):

var db = require('./../db_actions');
var fs = require('fs');
var git = require('./../hook/git_actions');

'./' is just extraneous here, require('../hook/git_actions') should be enough.

tasker/run_.sh, line 11 at r2 (raw file):

OUTPUT() {
  echo -e "${RED_COLOR}$BASH_COMMAND CI FAILED - sign_ios.sh failure${NORMAL_COLOR}"

how "sing_ios.sh" is related to this script?

Comments from Reviewable

Review status: 11 of 18 files reviewed at latest revision, 8 unresolved discussions.

logger.js, line 12 at r2 (raw file):
Previously, chapko (Eugene Chapko) wrote…
const { format } = require('util');

Done.

logger.js, line 23 at r2 (raw file):
Previously, chapko (Eugene Chapko) wrote…
Use spread operator:
format(...messages)

Done.

logger.js, line 35 at r2 (raw file):
Previously, chapko (Eugene Chapko) wrote…
I suggest something like:
new Date().toISOString().replace(/[TZ]/, ' ').trim();

Milliseconds are important in the logs.

Done.

internal/tester.js, line 10 at r2 (raw file):
Previously, chapko (Eugene Chapko) wrote…
'./' is just extraneous here, require('../hook/git_actions') should be enough.

Done.

tasker/run_.sh, line 11 at r2 (raw file):
Previously, chapko (Eugene Chapko) wrote…
how "sing_ios.sh" is related to this script?

Done.

Comments from Reviewable

Review status: 11 of 18 files reviewed at latest revision, 10 unresolved discussions.

db_actions.js, line 1 at r4 (raw file):

//  Copyright (C) Microsoft. All rights reserved.

As you're fixing issues in this file it would be good to add missing ';' in line 22,line 30 and line 39

db_actions.js, line 9 at r4 (raw file):

var fs = require('fs');
var local = new loki('config.json');

Shouldn't we first declare loki with require and later instantiate it?

Comments from Reviewable

db_actions.js, line 1 at r4 (raw file):
Previously, jareksl (Jarosław Słota) wrote…
As you're fixing issues in this file it would be good to add missing ';' in line 22,line 30 and line 39

Please also remove two not used functions find() and remove() lines 66 and 82

Comments from Reviewable

Reviewed 8 of 15 files at r1, 7 of 9 files at r2, 3 of 3 files at r4.
Review status: all files reviewed at latest revision, 12 unresolved discussions.

tasker/android.js, line 33 at r4 (raw file):

  return adb.installApp(apkPath, appId, deviceId)
    .then(() => adb.listPackages(deviceId))

NB: Since you are running this in real Node why not use the await syntax? It's SOOO much nicer!

tasker/android.js, line 101 at r4 (raw file):

}

// TODO: see original implementation

NB: What original implementation?

Comments from Reviewable

Review status: 16 of 18 files reviewed at latest revision, 12 unresolved discussions.

db_actions.js, line 1 at r4 (raw file):
Previously, jareksl (Jarosław Słota) wrote…
Please also remove two not used functions find() and remove() lines 66 and 82

Done.

db_actions.js, line 9 at r4 (raw file):
Previously, jareksl (Jarosław Słota) wrote…
Shouldn't we first declare loki with require and later instantiate it?

Done.

tasker/android.js, line 33 at r4 (raw file):
Previously, yaronyg (Yaron Y Goland) wrote…
NB: Since you are running this in real Node why not use the await syntax? It's SOOO much nicer!

I absolutely agree. I was initially using Promises when I didn't expect that I would use node.

tasker/android.js, line 101 at r4 (raw file):
Previously, yaronyg (Yaron Y Goland) wrote…
NB: What original implementation?

This's unnecessary TODO I forgot to remove.

Comments from Reviewable

Reviewed 1 of 9 files at r2.
Review status: 16 of 18 files reviewed at latest revision, 12 unresolved discussions.

Comments from Reviewable

Review status: 16 of 18 files reviewed at latest revision, 13 unresolved discussions.

tasker/android.js, line 216 at r5 (raw file):

    .then((devices) => {
      if (serverDir && serverDir.length) {
        return exec(`curl <IP_ADDRESS>:8060/droid=${devices.length}`)

We need to make sure that before the test app is started the coordination server is running (in case it is needed). You can check the following issue for details: https://github.com/thaliproject/CI/issues/97.
Branch master_97_rework contains a temporary solution which introduces a timeout. We need to fix this here. In worst case it could be timeout as well but the best option would be to wait till coordination server is started. The server starts after this call but it takes some time as it includes npm install. We need some mechanism in ____.js so that we can ask the server if the coordination server has been started. Then we may continue.

Comments from Reviewable

Review status: 16 of 18 files reviewed at latest revision, 13 unresolved discussions.

tasker/android.js, line 216 at r5 (raw file):
Previously, czyzm wrote…
We need to make sure that before the test app is started the coordination server is running (in case it is needed). You can check the following issue for details: https://github.com/thaliproject/CI/issues/97.
Branch master_97_rework contains a temporary solution which introduces a timeout. We need to fix this here. In worst case it could be timeout as well but the best option would be to wait till coordination server is started. The server starts after this call but it takes some time as it includes npm install. We need some mechanism in ____.js so that we can ask the server if the coordination server has been started. Then we may continue.

what if we just add ping with retries and concrete timeout ?

Comments from Reviewable

Reviewed 1 of 15 files at r1, 2 of 9 files at r2, 1 of 2 files at r5.
Review status: 17 of 18 files reviewed at latest revision, 23 unresolved discussions.

db_actions.js, line 23 at r5 (raw file):

  console.log('Creating config.json');
  local.addCollection('config');
  // local.getCollection('config').insert({name: "GithubUser", username: "obastemur", password: ""})

NB: Leaving a commented code is usually not good,  we have version control to handle such cases. I'd prefer to remove it from here.

builder/virtual.js, line 330 at r5 (raw file):

        }

        if (job.target != 'all') {

The == and != operators do type coercion and should not be used. Please fix this issue in all places in this file

hook/git_actions.js, line 12 at r5 (raw file):

var reporting = require('../reporting/report');
var tester = require('./../internal/tester');
var virtual = require('./../builder/virtual')

Please add missing semicolon.

hook/git_actions.js, line 154 at r5 (raw file):

      createIssue(user, repo, "mobile_test.json is missing", "Skipped testing branch `" + branch + "`. There was no mobile_test.json file");
      logger.info("skipped testing branch", branch, "on", user + "/" + repo, "(no mobile_test.json found)");
      return;

The return statement is not needed here. You can also leave it and get rid of succeeding "else" leaving the content, which would simplify the code a bit by removing one intent.

hook/git_request.js, line 25 at r5 (raw file):

  if (json.pull_request) { // pull request
    if (json.action != 'opened' &&

The != operators do type coercion and should not be used. Use !== instead.

hook/git_request.js, line 60 at r5 (raw file):

    }

    if (!repo_name || repo_name.indexOf('thaliproject/') != 0 &&

We can get rid of the second part of the if statement:
repo_name.indexOf('thaliproject/') != 0 &&
repo_name.indexOf('obastemur/') != 0
Most probably it was used by Iz for testing purposes

hook/git_request.js, line 62 at r5 (raw file):

    if (!repo_name || repo_name.indexOf('thaliproject/') != 0 &&
      repo_name.indexOf('obastemur/') != 0) {
      if (pr && pr.state && pr.state != 'open') {

Why not simply check for negative and log it? like:
if (!pr || !pr.state || pr.state === 'open') {
logger.error('BAD REQUEST from repo', repo_name);
}
Additionally this statement could be combined with the one from the line 54

hook/git_request.js, line 78 at r5 (raw file):

  } else if (json.hook && (typeof json.hook_id !== 'undefined')) { // new web hook
    var hook_id = json.hook_id;
    var repo_name = json.repository.full_name;

Variables repo_name, branch and user are declared again here. Better would be to declare all variables at the beginning of the file.  Vars don't have block scope, so defining variables in blocks can be confusing.

internal/tester.js, line 223 at r5 (raw file):

        if (fs.existsSync(name + "/result_.json")) {
          try {
            var res = JSON.parse(fs.readFileSync(name + "/result_.json") + "");

Variable res is declared again

internal/tester.js, line 226 at r5 (raw file):

            for(var o in res) {
              if (res.hasOwnProperty(o)) {
                var str = res[o];

Variables str and fname are declared again. The same for variable o. They should be declared once at the beginning of the file.

Comments from Reviewable

@jareksl Please note that CI has a lot of crappy code, which was introduced before we took the project. This's definitely MUST be fixed. But I think that this should not be the focus of this PR review. At least because this PR will last forever and fixing warnings / bad code isn't the goal of this PR.
I think that code cleanup should be another PR.

Review status: 17 of 18 files reviewed at latest revision, 23 unresolved discussions.

db_actions.js, line 1 at r4 (raw file):
Previously, larryonoff (larryonoff) wrote…
Done.

@ja

Comments from Reviewable

Review status: 17 of 18 files reviewed at latest revision, 23 unresolved discussions.

tasker/android.js, line 216 at r5 (raw file):
Previously, larryonoff (larryonoff) wrote…
what if we just add ping with retries and concrete timeout ?

No need to handle it. Fixed by https://github.com/thaliproject/Thali_CordovaPlugin/pull/1712

Comments from Reviewable

I agree, I have just reported issues to not forget about them, I'll create separate issue to refactor the CI code

Review status: 17 of 18 files reviewed at latest revision, 23 unresolved discussions.

Comments from Reviewable

Review status: 17 of 18 files reviewed at latest revision, 23 unresolved discussions.

tasker/android.js, line 216 at r5 (raw file):
Previously, czyzm wrote…
No need to handle it. Fixed by https://github.com/thaliproject/Thali_CordovaPlugin/pull/1712

this's very good!

Comments from Reviewable

The issue #99 is meant to be used for code cleanup.

Reviewed 6 of 15 files at r1, 4 of 9 files at r2, 3 of 3 files at r4, 1 of 2 files at r5.
Review status: all files reviewed at latest revision, 24 unresolved discussions.

tools/android/adb.js, line 15 at r5 (raw file):

    this._logger = logger;
  }
};

NB: not needed semicolon

Comments from Reviewable

We need to adapt CI infrastructure for those changes. The main change is installing node on RaspberryPI modules. This needs to wait for now.


Codify lint toolchain, Mk.II

Re-implement https://github.com/linera-io/linera-protocol/pull/1251 without using working-directory, which is apparently forbidden in combination with uses.

@Twey We're still missing tests


Prever MiB and GiB when applicable

Closes https://github.com/zenithdb/zenith/issues/531
Had left a couple stray GB and MB mentions that are not obvious from the context, but I think we've spent enough time on this already.
I've also noticed how many MB and GB mentions are there in vendor/postgres and now thing that I've rushed with the message 🙂
As an alternative, I propose to close the PR and issue and leave things as they are, for consistency.

I've also noticed how many MB and GB mentions are there in vendor/postgres and now thing that I've rushed with the message slightly_smiling_face

Oh yeah, PostgreSQL consistently uses MB to mean 1024*1024. I'm sure that's why it got that way in zenith codebase too :-). See discussions at https://www.postgresql.org/message-id/flat/20160730001838.GA22405%40momjian.us#ef946043c336d66e717e0e6e96639f92.

As an alternative, I propose to close the PR and issue and leave things as they are, for consistency.

I would be happy to just close this and maybe add a note somewhere in the docs or comments about it. I'm curious to hear what others who are not so deep in the PostgreSQL bubble think, though :-).


ErrorScrub message in setHibernatingCondition to remove AWS request_id.

Scrub condition message to exclude the request id:
- lastProbeTime: "2021-08-04T19:45:34Z"
    lastTransitionTime: "2021-08-04T14:48:13Z"
    message: "Failed to start machines: AuthFailure: AWS was not able to validate
      the provided access credentials\n\tstatus code: 401, request id: 5cf337cf-c70d-4a8a-87e0-4a08d3cca2f0"
    reason: FailedToStart
    status: "True"
    type: Hibernating

/lgtm


easyaudiosync: 1.1.1 -> 1.1.2

Updated to the latest available version.
Removed also unneeded patches.
Changelog: https://github.com/complexlogic/EasyAudioSync/compare/v1.1.1...v1.1.2
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 352924

x86_64-linux

:white_check_mark: 1 package built:

easyaudiosync


raise ValueError on zero pooled std for power calculations

raise ValueError on zero pooled std for power calculations

Coverage increased (+0.02%) to 91.092% when pulling 288095ef3984bc2aa4242bb329cf372663d84c14 on gbordyugov:zero-variances-power-bug into de08313c430ad97860276cc55c912721fb435ca8 on zalando:master.

Coverage increased (+0.02%) to 91.092% when pulling 288095ef3984bc2aa4242bb329cf372663d84c14 on gbordyugov:zero-variances-power-bug into de08313c430ad97860276cc55c912721fb435ca8 on zalando:master.

👍


ViewportTexture doesn't work within PointLight2D

Godot version
v4.1.dev.custom_build [c1128e911]
System information
Windows 11, Nvidia 3070, any renderer
Issue description
I want to use a ViewportTexture as a PointLight2D's texture, so I can create dynamic lights, but in most scenarios, the texture won't show at all.
Scenario 1: immediately after ViewportTexture added as PointLight2D texture (works fine in editor)

Scenario 2: project reloaded (light texture disappears)

Scenario 3: in-game (no light texture shown)

Steps to reproduce

Create a SubViewport with anything in it (e.g. a simple Sprite2D)
Create a PointLight2D
Add a ViewportTexture (referencing the SubViewport created in step 1) as the PointLight2D's texture
Try running the game (nothing shows for the light)
(optional) try adding an identical ViewportTexture as a texture on another node (e.g. Sprite2D) - it works fine.

Minimal reproduction project
viewportlight2d.zip

This is the same core issue as https://github.com/godotengine/godot/issues/74352 https://github.com/godotengine/godot/issues/73400
PointLight2D copies texture to an atlas so that multiple lights can be used within the same draw call. The downside is that updating the textures requires a copy to the atlas each time the texture is updated. We avoided implementing that as it would be really bad for performance in most cases, but from the other issues you can see that it is very demanded. So we may have to support updating PointLight2D textures dynamically eventually and let users decide if the performance hit is worth it.

I used git bisect and the commit that broke the ViewportTexture for PointLight2Ds is: 84d734da0e4dc4f0076c61a7178d8ad7b9f3b616
I also need dynamic lights and would welcome a solution to this problem.

I got a workaround working as long as only one PointLight2D uses the ViewportTexture.
# Called every frame. 'delta' is the elapsed time since the previous frame.
func _process(delta):
	texture=null
	texture=subViewport.get_texture()
	pass

As soon as you try to use the same trick on a second light, both lights will stop working.
You can try it out with this Godot 4.0.2 example project:
WorkaroundLightPoint2DViewportTexture.zip

When behavior like this is purposefully broken, it would be hugely helpful to show at least a hint in the editor when setting a viewport texture that it wont work. Like others that have posted into the various bug threads before me, I've wasted hours trying to understand why this didn't work.

When behavior like this is purposefully broken, it would be hugely helpful to show at least a hint in the editor when setting a viewport texture that it wont work. Like others that have posted into the various bug threads before me, I've wasted hours trying to understand why this didn't work.

Yes agreed. I spent quite a lot of time before stumbling across this. to be clear: you cannot update PointLight2D textures once they've been loaded into this atlas. Adding a note about in the docs would be great:
https://docs.godotengine.org/en/stable/classes/class_pointlight2d.html#class-pointlight2d-property-texture
I'd do it myself but am afraid I would mess up the terminology or details.
My fix was to change the texture, duplicate my PointLight2D node, then remove the old node. Seems to be working well. As this is something that only happens occasionally in my project.

Closing in favor of:

https://github.com/godotengine/godot-proposals/issues/9855

As this is a feature not a bug, thank you for reporting

I got a workaround working as long as only one PointLight2D uses the ViewportTexture.
# Called every frame. 'delta' is the elapsed time since the previous frame.
func _process(delta):
	texture=null
	texture=subViewport.get_texture()
	pass

As soon as you try to use the same trick on a second light, both lights will stop working. You can try it out with this Godot 4.0.2 example project: WorkaroundLightPoint2DViewportTexture.zip

You can do that to have it in multiple ones :
	await RenderingServer.frame_post_draw 	var viewport_texture : ViewportTexture = get_texture() 	var image: Image = viewport_texture.get_image() 	var image_texture := ImageTexture.create_from_image(image)
And her you use image_texture where you want

Please comment on the issue above this has been closed in favour of it and the focus should be on:

https://github.com/godotengine/godot-proposals/issues/9855


Perturbation solutions getting stuck when rapidly evaluated

This seems to occur with a @btime as well as with calls to FiniteDifferences, such as when called with test_rrule etc.
Currently going through to see if concurrency issues are at play:

[x] Caching
[x] Deep copy of the module/module_wrapper
[ ] Globals and closures
[x] GeneralizedSylvester
[x] RecursiveFactorization's lu
[x] General LAPack threading
[x] lyap in matrixequations
[ ] Container has Module

Happens without any actual calculations.  Compiler failing in some odd way?

Cracked.  Some sort of compiler bug with globals.   Will add MWE later.


A11y_Model Builder_Add Data_Focus Order : Focus is shifting to the data source radio button directly at down and then with shift tab focus is moving to link at top.

GitHubTags:
#A11yMAS; #A11yTCS; #A11ySev2; #DesktopApp; #Visual Studio Client; #SH-ModelBuilder-Win32-Jun2022; #Win32; #WCAG2.4.3; #FocusOrder; #Keyboard;
Environment Details:
Application Name: Model Builder
Windows Version: Windows 11 22H2 OS Builder 25145.1011
Visual Studio: Microsoft Visual Studio Enterprise 2022 (64-bit) - Preview Version 17.3.0 Preview 2.0
Repro Steps:

Install Visual studio and open Visual studio
Navigate to C# project name and right click on it
Navigate to "Add" button and press enter
Navigate to "Machine learning model" and press enter
"Add new item" popup will open
Navigate to "Add" button and press enter
"Select scenario" popup will open and select "Forecasting" scenario
"Select training environment" page will open then select "Next step"
"Add Data" page will appear.
Check whether the focus is shifting to the data source radio button directly at down and then with shift tab focus is moving to link at top.

Actual Result:
Focus is shifting to the data source radio button directly at down and then with shift tab focus is moving to link at top.
Note:
Similar issue is observed with "Train Data".
Expected Result:
Focus should shift to the control at the top first (top link) and then to the bottom controls (Data source radio buttons), focus order should be top to bottom and left to right.

@romalpani Can you help me here? I think we set the focus to the first interactable element. Is this correct? Have I understood the bug correctly?

Hi Becca!
According to accessibility guidelines, the focus should go to the first interactable element.
https://devdivdesignguide.azurewebsites.net/general-guidelines/designing-for-everyone/#focus
In this case, it would be the hyperlink. But I think, we had decided to bring focus directly to the "environment" selection area because that gets customers to achieve their task faster (one less tab key press).
So, I am going to check with the design team if there are other places we do a similar thing, to confirm our approach.

After discussing with the design team, here's what I think we should do to resolve the bug.

Bring focus to the first interactable element - in this case, the hyperlink (and I believe all other steps of the wizard too).
Reasons

It is a more predictable interaction flow for sighted keyboard and screen reader users.
Having to move back (shift-tab) to access the hyperlink does seem counter-intuitive.
It is easier to build a mental model with a simpler flow, and eventually, customers will tab right past the hyperlink when they don't need it.

Great - will do. Thanks for the help here Rohan!!

@manaswita-chougule  Please verify this on build <IP_ADDRESS>1902 available from the Marketplace https://marketplace.visualstudio.com/items?itemName=MLNET.ModelBuilder2022

@manaswita-chougule What is the ETA on validation of these bugs? Our SLA is next week so I'd like to make sure we have reaction time if there is a regression. Thanks!

Verified the issue in below environment:
Microsoft Visual Studio Enterprise 2022 (64-bit) - Preview
Version 17.4.0 Preview 1.0
The issue is fixed, hence closing the bug. Please find below attachment for reference.


-Z is not respected if failure occurs during "Uploading Report" step

Background
According to the documentation, -Z should do the following:

Exit with 1 if not successful. Default will Exit with 0

However, during the "Uploading Report" step, it is possible to get back a 402 PAYMENT REQUIRED response that looks like the following:
HTTP 402
Sorry, but this team has no private repository credits left.

When that occurs, the codecov script still exits with a code of 0 instead of 1 even when -Z is defined.
Problematic Code
Here's a link to the relevant lines of logic, where you can see the script exits with 0 before it has a chance to respect the ${exit_with} variable that is set via the -Z argument.
exit 0
exit ${exit_with}

Suggestion
Update the codecov script to check for a 4XX status after it checks for a 5XX status. If it is found, exit the script using the ${exit_with} variable. I imagine it would go from this:
elif [ "${status:0:1}" = "5" ];
then
  say "    ${e}->${x} Sleeping for 30s and trying again..."
  sleep 30

else
  say "    ${g}${res}${x}"
  exit 0
  exit ${exit_with}
fi

... to something like this...
elif [ "${status:0:1}" = "5" ];
then
  say "    ${e}->${x} Sleeping for 30s and trying again..."
  sleep 30

elif [ "${status:0:1}" = "4" ];
then
  say "    ${g}${res}${x}"
  exit ${exit_with}

else
  say "    ${g}${res}${x}"
  exit 0
fi

I believe this has been fixed now, let me know if this is not true.


Check-in the v4 notice and themes link in the docs

Fixes #18332.
CC: @mdo for review

Nice, thanks!


Dependency issues for NodeJS v8 support

With the release of a new @azure/core-rest-pipeline v1.10.3 and its dependence on @azure/core-util v.1.3.0 I'm experiencing issues in my NodeJS v8.9.0 environment. The new version of core-util utilizes globalThis, which came with the release of node 12, and it results in the following error:
const uuidFunction = typeof ((_a = globalThis === null || globalThis === void 0 ? void 0 : globalThis.crypto) === null || _a === void 0 ? void 0 : _a.randomUUID) === "function"
                     ^
ReferenceError: globalThis is not defined

I hit this issue as well on Node 10. Downgrading to 2.4.0 worked for me (I was only looking for the dependency updates).

Same issue. According to azure console the version is v14.20.0

Locking @azure/core-util to 1.2.0 using npm overrides is a workaround for us.

Locking down the dependency version for now, we will look into removing this dependency entirely if possible, will be releasing a new version of this package later today.


Pause and Stop functions don't work

Hey,
When a video is playing, and by pressing a button I launch a function which calls video.pause() or video.close(), nothing happens.
Video appears and plays well but won't pause or stop...
I'm on Ubuntu with the latest pip version of your package.
Here is my code:
...

# Init the video
self.video = TkinterVideo(master=self, scaled=True)
self.video.load("test.mp4")
self.video.play()
self.video.pack(expand=True, fill="both")

# Init the button to go to the next video normally...
self.button = customtkinter.CTkButton(self, text="Next")
self.button.configure(command=self.step_2)
self.button.pack()

def step_2(self):
  self.video.pause()
  ...

Thank you very much in advance for any help,
Leon

Hi @LeonPupier Would you mind showing a screen recording and a minimal reproducible example, I am on Ubuntu as well, and it works as expected for me.

Okkaayy I just got it.
Actually everything works fine, but I would like my video to loop once it reaches the end so I put a tkinter loop like this:
def loop(self):
    # Replay the video if it's the end
    if self.video.is_paused():
        self.video.play()

    # Loop method
    self.after(10, self.loop)

So she doesn't care about the pause AND the stop sign...
Is there a better technique?

Hi sorry for the late reply please upgrade the library and use the example: https://github.com/PaulleDemon/tkVideoPlayer/blob/master/examples/loop_example.py


added datePart()

A few things here:

The actual purpose: added a datePart() that strips out hours, minutes, seconds, and milliseconds
Some simple tests
I added the node modules required to build to devDependencies in package.json. That made it a lot easier to get it building. I hope I didn't misunderstand something.
I couldn't build as-is because of file name case sensitivity, so I renamed en-GB.js to en-gb.js.

sod()/eod() sounds reasonable to me. I'll resubmit the changes. with only
the src files.
On Wed, Jan 11, 2012 at 12:30 PM, Tim Wood <
<EMAIL_ADDRESS>
wrote:

datePart is a pretty unspecific name. How about eod and sod (end of
day and start of day)?
I couldn't automatically merge the change, so would you mind submitting a
new pull request with only the source, not the built files. I think that is
where github is unable to automatically merge. So just the files below are
necessary.
moment.js
sitesrc/js/unit-tests.js
sitesrc/docs.jade
Thanks!
Oh, I committed the filename change and the dev dependancies also, thanks
for that!

Reply to this email directly or view it on GitHub:
https://github.com/timrwood/moment/pull/124#issuecomment-3450183


feat: added ssz for BeaconBlock

Motivation

Description
Added SSZ for BeaconBlock

Closes #68

Hi @Godspower-Eze . Good work! We want to test the spec test to make sure everything is working fine. Can you enable the test by removing this line? https://github.com/lambdaclass/lambda_ethereum_consensus/blob/main/test/spec/runners/ssz_static.ex#L10

Done


Full disk encryption?

One of the security features of chromeos was full disk encryption. Breath comes preinstalled, so there is no option to enable full disk encryption, because there is no installer.
Is that even possible with the chromebooks stock firmware?

It should be possible to encrypt disk, I will talk with the maintainer for future milestone, actually I will do only pr for audio and pipewire compatibility (and issue/stability fixing). But you can give an eye on the source code to provide a pr that will add this.

Well it's not full disk encryption but maybe it will help you. I was able to use LUKS to encrypt home folder, following this guides. It works quite nice, home is on separate partition which is encrypted and you have to enter passphrase during boot.

https://www.howtogeek.com/442101/how-to-move-your-linux-home-directory-to-another-hard-drive/
https://askubuntu.com/questions/1335006/what-is-the-recommended-method-to-encrypt-the-home-directory-in-ubuntu-21-04/1335327#1335327

I'm on kernel: 5.10.112 and I had to load kernel module dm-crypt:
sudo modprobe dm-crypt

and add it to /etc/modules so it will load after reboot:
sudo nano /etc/modules


rymcu analysis

User behavior analysis and collection system
-1. Is it allowed to collect information
-2 PV information collection
-2.1 IP
-2.2 and so on

@aeet


There is no middleware created by adapter-node

Describe the bug
The readme in adapter-node linked from the svelte kit docs says:

The adapter exports a middleware (req, res, next) => {} that's compatible with Express / Connect / Polka. Additionally, it also exports a reference server implementation using this middleware with a plain Node HTTP server.
But you can use your favorite server framework to combine it with other middleware and server logic. You can import kitMiddleware, your ready-to-use SvelteKit bundle as middleware, from ./build/middlewares.js.

But I cannot find any middleware created by the adapter. I only have an index.js file in the build directory (besides the assets).
Is this an issue with the readme or with some configuration? Is there a way to get a middleware from adapter-node?
Reproduction
Repo: https://github.com/bdadam/svelte-kit-adapter-node-reproduction
The generated dist directory is also pushed to the repository.
Logs
No response
System Info
npx envinfo --system --binaries --browsers --npmPackages "{svelte,@sveltejs/*,vite}"

  System:
    OS: Linux 5.4 Ubuntu 20.04.3 LTS (Focal Fossa)
    Shell: 5.0.17 - /bin/bash
  Binaries:
    Node: 16.8.0 - ~/.volta/tools/image/node/16.8.0/bin/node
    Yarn: 1.22.10 - ~/.volta/tools/image/yarn/1.22.10/bin/yarn
    npm: 7.21.0 - ~/.volta/tools/image/node/16.8.0/bin/npm
  npmPackages:
    @sveltejs/adapter-node: ^1.0.0-next.43 => 1.0.0-next.43
    @sveltejs/kit: next => 1.0.0-next.160
    svelte: ^3.34.0 => 3.42.4

Severity
serious, but I can work around it
Additional Information
No response

You're right, it seems like the latest version 1.0.0-next.43 doesn't even include these functionality yet, i looked into the source code. Maybe there was no new release since this feature came out?

#2051 should have had a changeset, but it didn't, so it was never released. cc @benmccann

ah, thanks for catching that. released now

Thank you all for the quick reaction and the fix. I can confirm that it works now as described in the readme. Thank you. :)


Grappling gun being unusable after execution attempt

Description
Attempting to execute your self, with the grappling gun uses up its ammo, making it unusable indefinitely.
Reproduction
Attempt to execute with a grappling gun
Additional context
This was tested as a borg, taking out the module, and re-inserting it fixed nothing

lmfao


Pass whole job object to error_notifier?

Hi @chanks —
We use Que across all our apps at Icelab (and it is great, thank you!), and in my current project I am trying to do some manual integration of Que with an error tracking service. By manual, I mean: rather than simply using their gem's out-of-the-box Que integration (which is all monkey patching), I want to add some extra methods to our app's own base job class (which inherits from Que::Job, and from which all our other application jobs inherit) to expose the various pieces of information that the error tracker will want to receive, and then use these methods inside the Que.error_notifier proc to determine whether to submit the error, and if so, what information to send along with it.
The hitch is that the full job object is not currently passed to the Que.error_notifier proc. Instead, the job's #que_attrs are sent as the job argument.
Would you consider a PR which changes this argument to be the full job object? I want to check with you before starting the work.

Hi Tim, thanks for asking - the issue is that an error might occur before the job can be instantiated (for example, if a job class is renamed and the constantization of an old class name fails, or if somebody overrides the initialize() method and something goes wrong), and the error handler still needs to work in that case. One option would be to yield the instantiated job if it's present or the attributes if it's not, but that pushes some complexity to everyone's handler procs, and requires them to either handle both possible inputs or risk silently losing errors :disappointed:
It seems to me that there are a few other ways you could implement this - you could implement this logic in the error handler proc itself, or encapsulate it in a new class that the error handler proc can use. Or, if it really makes the most sense to keep it in your Que::Job subclass, there's nothing stopping you from instantiating the job class yourself, though you'll probably want to be a little defensive about it (I haven't tested this, I'm just spitballing):
Que.error_notifier = proc do |error, attrs|
  job_class =
    begin
      attrs[:job_class].constantize
    rescue NameError
    end

  if job_class
    instance = job_class.new(job_attrs)
    # do things...
  else
    # fall back to the old behavior
  end
end

Do any of these seem like reasonable solutions to your problem? Another thing I'd add is that at this level of complexity in the notifier, I think it'd make sense to add unit tests for it.

Thanks for the reply Chris, I hadn't thought about those potential issues instantiating the job. Your spitballed solution looks like something I could work with. I'll give it a go!


Add more geeksays

Add a translation #1
Add a quote #5

@swapagarwal feel free to review this one, cheers :beers:


Vsphere: list snapshot by description

Change Overview
Add alternative way to list snapshots in Fcd provider by using description field
Pull request type
Please check the type of change your PR introduces:

[x] :construction: Work in Progress
[ ] :rainbow: Refactoring (no functional changes, no api changes)
[ ] :hamster: Trivial/Minor
[ ] :bug: Bugfix
[ ] :sunflower: Feature
[ ] :world_map: Documentation
[ ] :robot: Test

Issues
Test Plan

[x] :muscle: Manual
[ ] :zap: Unit test
[ ] :green_heart: E2E

Code change LGTM. @carlbraganza @bathina2 PTAL and see if it's mergeable. Thanks.


Artillery testing

Adds smoke and load testing for Appstore using the npm Artillery package.
Usage

Install using make install.artillery. Automatically installs as a dependency of make install.
Smoke/load tests can be run using make test.artillery. These tests will also be run using the appstore-chart with helm test and configured via Helm values.

Environment

ARTILLERY_ENVIRONMENT=smoke|load and ARTILLERY_TARGET=<appstore_url>should be set when using make test.artillery
When running load tests, ARTILLERY_DURATION=<seconds_to_run> and ARTILLERY_ARRIVAL_RATE=<arrivals_per_second> should also be set to specify load duration and intensity.
If any required env configuration is unset when running the command, it will convey an appropriate error message.

Design
Smoke vs load tests
Smoke tests are somewhat analogous to regular unit tests. It will simulate a single user and ensure that important functionalities of the site are working properly. Essentially, the smoke testing aspect ensures that Appstore is still deploying properly after making changes and that everything is still in order.
Load tests will simulate a large amount of users simultaneously, not only to ensure that key functionalities are working (as is done with smoke tests), but also to ensure that Appstore is able to handle a somewhat "realistic" flow of traffic without buckling (e.g. timing out, erroring, etc.).
The tests are designed such that both smoke and load testing follows the same workflow. The only difference is that when load testing is enabled, many users will be instantiated rather than just one.
Tests
The current flow of the tests is as follows:

Log in using a random testing account.

Note that currently, if testing locally rather than through helm, then test users will need to be created by setting CREATE_TEST_USERS=true and TEST_USERS_PATH=artillery-tests/payloads before running Appstore with make start.

Retrieve the currently running apps on the account.
Retrieve apps that can be created by the user for the current deployment of Appstore.
Choose a random one of these apps, and create it with minimum resources.
Confirm that the new app was created for the user.
Delete the new app, and confirm it was deleted.
Log out of the account.

A couple of current drawbacks presented by this test design:

Users never actually interact with the instantiated apps. They simply spawn them, confirm they are created, wait, and then delete them.
Similarly, since apps are deleted relatively quickly to keep testing at least somewhat concise, the total number of apps running at any given time isn't as high as it would naturally be if, for example, 100 students all began instances of Jupyter and used them throughout a lecture.

Related changes
Some changes apart from the artillery testing itself were adde in order for the tests to work.

Node/npm/curl added to the Docker container. Curl is used to ensure that the correct version of Node is installed (see Dockerfile).
Numerous changes to the Makefile for running Artillery.
The API endpoint POST /api/v1/instances/, which creates a new app, now returns the sid of the created app.

This would not normally be necessary, since you could infer the created app by looking at the apps before it was created and after, but due to limitations of Artillery, it is possible that numerous virtual users can end up logging in to the same account at once at create apps at the same time.

This all looks good, but I think we also need like a quick README somewhere letting developers know how to set up load/smoke testing, including all the env vars that need to be set. I know the Makefile will alert the runner if they don't set those vars but it'd be kinda confusing to not know what those vars' names are, especially if you know vars like that have to be set but just don't know what they are and have to dig to find them.

This all looks good, but I think we also need like a quick README somewhere letting developers know how to set up load/smoke testing, including all the env vars that need to be set. I know the Makefile will alert the runner if they don't set those vars but it'd be kinda confusing to not know what those vars' names are, especially if you know vars like that have to be set but just don't know what they are and have to dig to find them.

I missed this. Yes, I think that's definitely important to have in the readme.


scripts/function_decl3.rhai error

11: print(f(100, 5, 2, 9, 6, 32));
          ^ Variable not found: KEY (line 6, position 29) in call to function f @ '\\?\C:\Users\vadim\Desktop\Rust\rhai\scripts\function_decl3.rhai'

what does line 14 of scripts/loop.rhai
export x as foo;

does? commenting it makes no difference

ah, I get it, this is used in 'module.rhai'

scripts/primes.rhai
line 24: i += p;
this does nothing (commenting it changes nothing), looks like values from for loops are well... values, not mutable references

scripts/primes.rhai
line 24: i += p;
this does nothing (commenting it changes nothing), looks like values from for loops are well... values, not mutable references

Ah yes.for variables are values. You're right this line has no use. It was a left over from the previous version where there was no stepped range and this was a while loop.
Now the stepping is done in the range iterator itself

11: print(f(100, 5, 2, 9, 6, 32));
          ^ Variable not found: KEY (line 6, position 29) in call to function f @ '\\?\C:\Users\vadim\Desktop\Rust\rhai\scripts\function_decl3.rhai'

I can't get this error... Which version are you using? I see it should be the master since there is an automatic global module.

Oh, you are right, I am sorry. I had like a couple days old git repo, started exploring its scripts and finding kid-mistakes (like misplaced ``) I reported some of them here, but then I've thought "wait, nobody really didn't fix this before?" checked the repo again and saw, that errors were fixed, but the reported part remained in the issue.

I'll continue testing now with the latest version, but I was kinda dissapointed of looking how the scripts from the source repo contain obvious errors (even they get fixed later) why they were uploaded without testing?

Just not having enough test coverage, I think that's the reason.  Rhai's standard library has a large number of functions and methods, and it takes a long time to write complete tests for every single one of them...
Notice that I said test coverage, not tests.  There is a test with insert, just not with zero position.  This is a perfect case of not adequate test coverage - the tests do not cover all possible inputs groups.
Fixing this probably requires a systematic revision of all the tests - right now they are quite ad hoc.

oh, wait, scripts/function_decl3.rhai still does not work error is:
11: print(f(100, 5, 2, 9, 6, 32));
          ^ Module not found: 'global' (line 6, position 29) in call to function f @ '\\?\C:\Users\vadim\Desktop\Rust\rhai\scripts\function_decl3.rhai'

Strange...I get no such error...
Did you use rhai-run to run the script?

I use rhai-run
yep, that's strange.
I think that I'm using the latest one.
do our scripts are the same? mine has that
global::

thing in it.

Double check: if I just pull a repo with
git clone [repo_addr.git]

(and then git pull to update it when new things merged)
do I get the 'latest'?
or I need to explicitly mention the branch?

do our scripts are the same? mine has that

Yes, it is the latest addition.  It is called an "automatic global module".  Essentially it captures all the constants declared at root level into a module called global.
So you can refer to global constants within functions.
But the error message you got indicates that the global module is not recognized, and that indicates probably an older version.

Just git clone should automatically get you the latest.
git pull will update you to the latest.
Are you running via cargo run --bin rhai-run or just running the installed version (which may be an older version)?

Ok, I get it now, I will update things and check once again. (this issue probably will be closed)

after update it works.


Is it supported java runtime？

Search before asking

[X] I had searched in the issues and found no similar issues.

Feature Request

Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

There is currently no plan


reuse session

Coverage decreased (-0.6%) to 98.999% when pulling a509caa0046d5ada8d481c04f6357e13f72f3475 on reuse into ce2b7756a31ff7ac324fa1c624b8da1685152879 on master.


Static method to retrieve DashTools logged in the config file

It will be helpful to have access to the different DashTools that have been onboarded on a given user's machine without having to create an instance of the Analytics class. Certain tools may want to know if they have already been added to the config file first because creating the instance would log them into the config file.

Closing as this is no longer necessary, the package will need confirmation before sending events that the consent message has been shown.


Griefing near 1554, 20, 9950

Discovered by neverguy.  debug.txt logs do not list who placed lava here.  Need to use rollback feature to determine who did this, then clean it up.
1554, 20, 9950

The rollback command did not know who griefed it.   sssmit and sysadmin manually cleaned it up.


chore: release main

:robot: I have created a release beep boop
core: 1.1.0
1.1.0 (2023-07-11)
Features

core: Add getAge function (8e3a3c5)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/bag-of-tricks/baggie/releases/tag/core-v1.1.0 :sunflower:


improve bloom lab

show metagraph

Major improvements.  Adding a note about metagraph.

Actually, meta graph seems to be apoc only, so doesn't work in Aura.  Nevermind.


CIF-827 - Fix NPE in product model for getDescription

Description
Fixed NullPointerException that might occur when calling getDescription for a product or product variant.
Caused by: java.lang.NullPointerException: null
	at com.adobe.cq.commerce.core.components.internal.models.v1.product.ProductImpl.getDescription(ProductImpl.java:122) [com.adobe.cq.commerce.components.core:0.0.1.SNAPSHOT]

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] I have signed the Adobe Open Source CLA.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[X] I have added tests to cover my changes and the overall coverage did not decrease.
[X] All unit tests pass on CircleCi.
[X] I ran all tests locally and they pass.

Codecov Report

Merging #5 into master will increase coverage by 0.61%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #5      +/-   ##
=========================================
+ Coverage     48.38%   49%   +0.61%
- Complexity      101   104       +3
=========================================
  Files            17    17
  Lines           496   500       +4
  Branches         27    28       +1
=========================================
+ Hits            240   245       +5
+ Misses          244   243       -1
  Partials         12    12

Impacted Files
Coverage Δ
Complexity Δ

...onents/internal/models/v1/product/ProductImpl.java
37.08% <100%> (+2.39%)
20 <3> (+3)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 194281d...9445f4f. Read the comment docs.


Add properties to the images we provide

This change adds property flags to the image we provide which will
ensure all of the images for distros that may run customer workloads
are operating at the highest level of performance possible.
Signed-off-by: Kevin Carter<EMAIL_ADDRESS>

The benchmarks  I did with customer workload has shown no benefit for virtio-scsi over virtio-blk. I had better latency with virtio-blk over virtio-scsi. Also multiqueueing should only be turned on when file handles are increased for qemu, someting we usually forget....

@BjoernT I can update this to use the virtio-blk driver by default. Is there a file descriptor limit we should set on compute hosts by default ?

From a RH errata I found that you should at least configure 2048 file handles but from running ceph we know that at least 32k are needed and I would like to use the same initial limit

done.

recheck_cit_artifact

the artifact build process is busted. We're working elsewhere to fix this.


Editor: Add button (and keyboard shortcut) for invoking bean-format

This adds a Format button next to the Save button to run the current editor content through bean-format. The keyboard shortcut is cmd+d.  It does not save the file.

Is the styling OK?

The styling is ok. If we add more buttons we might have to rethink the layout of the top bar, but so far I guess it's fine.
This currently introduces some breakage.

This currently introduces some breakage.

Do you mean Travis CI?

Do you mean Travis CI?

Yes. The scraper tries to access /source/format/ which throws an error as it only allows POST.
Maybe we should start grouping these interfaces for the JS-code under some common endpoint like /api/ (saving/loading the source file could also go there).

I fixed the scraping-issues, but flake8 is doing something strange: Checking all the pip-dependencies, and only in one of the two Travis CI runs (see above). It also does this locally when I run tox, but not when I run only flake8. @yagebu Do you have any idea why this is suddenly happening?

@aumayr: No idea why this is happening. Maybe the way that tox sets up the environment confuses flake8. Anyway I also noticed this (and added a workaround in d974a3da1cf170d0398f1c563a7693db0e216b35).


⚠ Account has degraded performance

In 2a69695, Account (https://account.wrk.com/health) experienced degraded performance:

HTTP code: 200
Response time: 262 ms

Resolved: Account performance has improved in 5c9b505.


self.saved_searching_ternimal_state = self.root_state_tensor.clone()[self.lego_indices.view(-1), :].view(self.num_envs, 108, 13) RuntimeError: shape '[1, 108, 13]' is invalid for input of size 1716

Hi,
When I try to train each sub-task by 'python train_rlgames.py --task=BlockAssemblyOrient --num_envs=1024'.
An error has occurred：
"self.saved_searching_ternimal_state = self.root_state_tensor.clone()[self.lego_indices.view(-1), :].view(self.num_envs, 108, 13)
RuntimeError: shape '[1, 108, 13]' is invalid for input of size 1716."
How can I solve it?
Thanks!

Hi @xiaobai0906 ,
This error is due to the environment dimension of the search terminal state you saved is different from the orient task. It seems that you are using one environment's searching_ternimal_state, and you are running 1024 environments' orient, so you also need to use the corresponding 1024-dimensional searching_ternimal_state.
Hope this can help you.


feat(autocmd): add autocmds to remember folds like vscode

I don't think it's a good idea to include this in core.
At some point I enabled something like this in my config, but it had issues and also potentially slows down opening files.
Besides, when you use sessions, this is a non-issue, since sessions already store folds as well.
I suggest you to post this in https://github.com/LazyVim/LazyVim/discussions/categories/recipes
Thank you


Does not install on IntelliJ IDEA 2021.2

the installation from IDEA says that only version 201.*   is supported
IDEA is already up to version 212 !!!

It works when installing from the ZIP only

Seems to be a known problem when updating intellij.
You need to remove the plugin, restart, then add it back again.
See https://github.com/kotest/kotest-intellij-plugin/issues/133