H2 Links

My question / suggestion is:
I would like an option, perhaps by site, that would allow me to see links for <h2 /> as well.
The URL (if applicable) pertaining to my problem is:
https://wol.jw.org/en/wol/d/r1/lp-e/1102021693
https://www.jw.org/en/library/books/scriptures-for-christian-living/preaching-good-news
Each of the questions on this page is <h2 /> with an id, but your extension doesn't seem to work here.
UPDATE:
It seems that it only works on the right-click menu, not using the nice little inline icon. Close if this is a no-op for you.

It should work for all headers, h1 through h6. I can see them in Edge.. maybe it's the browser you're using?

I should haven mentioned that I'm in Firefox using your extension.

Sorry it took months to respond! I lost sight of this..
I'm not sure what to make of it though, since it's working for me on that page, in Firefox. I'm not sure what you mean by the right-click option though, since this addon doesn't have that... it only adds an inline icon.


Add possibility to request cardinality estimates for TPF and brTPF

This issue is the TPF and brTPF specific version of #58. That is, the implementation for #58 has extended FederationAccessManager with a performCardinalityRequest method for SPARQL endpoints, and the purpose of this issue here is to do the same for TPF servers and brTPF servers. An implementation idea is to simply do the given TPF/brTPF request and, then, extract the cardinality estimate from the metadata of the response to this request.

Half of this issue is addressed by commit https://github.com/LiUSemWeb/HeFQUIN/commit/1b6b4c80bdf9ce0bba662e5b0711a4f98efc8409 -- namely, the extension of FederationAccessManager with method to issue cardinality requests to TPF/brTPF servers. What remains is to implement the extraction of the cardinality estimate from the metadata of TPF responses.

After completing the implementation for this issue (i.e., after implementing the extraction of the cardinality estimate from the metadata of TPF/brTPF responses), for this feature to actually work, we also need to address #17 and #18.


Multiple files or folders?

Is it possible to pass an array of files or folders to hound.watch? It seems to throw an error. Is there a recommended way to watch multiple src's?

I'm currently working on it.


request: create a new "distribution" with different root

The WSL system seems to create a '/' and associated Linux directories at a certain position in the NTFS file system - when you install a "distribution".
What would be super-duper-great is to expand the system just a little, and allow me to create a .... "container" ? "shadow-distribution" ? from a particular distribution.
Thus I could have two "debian 9" based distributions. They show up in the distribution list, I guess, because I'll want to launch them at different times for different purposes. Let's say one has Python 3.6 installed, one has python 3.5 installed, because I have some different dev tools....
This seems, from the outside, like it should be easy. You already have the ability to manage parallel distributions, they already must have different "root mappings". Just allow me to create them simply.
You know, like containers and virtual machines. This is so terribly useful, because Linux has "DLL Hell" like no one's business and it's great to be able to uplevel a package or two ( or downlevel it ) and get some work done for a few days, and blow it away.
If you can manage this, I can really stop using Docker which doesn't have great integration with Windows.
Thanks!

#1856


Twitter avatar doesn't work on Mobile Safari.

See enclosed image.

On mobile twitter redirects from their root domain to mobile.twitter.com and the URI we use to fetch the profile picture does not exist there.
Needs some more investigation to see if there are any alternative methods to fetch the Twitter avatar on mobile.

I noticed that the Twitter avatars are even broken on desktop now, we'll have to look into fixing both of these issues.

Twitter support has been fixed in v3.2.0 using a separate server side service to locate the correct avatar. You can find more information on usage here.


[Wave Collect] New Resources to Publish: Approve & Pay

Publish Date May 9 (or prior)
Related External Resource GH: https://github.com/Expensify/Expensify/issues/361145
Draft of HelpSite article: https://docs.google.com/document/d/1OzXcDpaZGsP3o07H_a5HUOuxdBTVp3kQXI4gnKbZwn8/edit?usp=sharing
External Resources
Publish under Expenses & Payments category

[ ] Approve & Pay Expenses

Issue OwnerCurrent Issue Owner: @ren-jones
Issue OwnerCurrent Issue Owner: @ren-jones

I'm ready to be assigned!

Still finalising the draft!


Needs to mock padchat-manager inside puppet-padchat

I would like to know how to mock the private property padchat-manager inside puppet-padchat. And I would like to only mock one method on padchat-manager, which is the WXGetContactPayload.
Do you know any way to do this?

It's very easy.
Please see my PR, and feel free to let me know if you have any questions.

Close this issue since the problem is solved.


adding init in the scripts dir since python3.7 requires that for …

…directories to be recognized as modules. it wasn't enforced in 3.6, but since 3.7 it is

Please sign CLA so that I can merge your PR

Please sign CLA so that I can merge your PR

pretty sure I already did, I don't know why it hasn't updated

Can you reply "@googlebot I signed it!" here?

Please sign CLA so that I can merge your PR


feat: Add a hidden way to access Fluent's stdout/stderr

Requested by @PyPablo
We cannot expose this as a full feature due to the limitations mentioned in #3436. Exposing a hidden way to access Fluent's stdout/stderr.
import subprocess
import ansys.fluent.core as pyfluent
pyfluent.LAUNCH_FLUENT_STDOUT = subprocess.PIPE
solver = pyfluent.launch_fluent()

for line in iter(solver._process.stdout.readline, b''):
    decoded_line = line.decode('utf-8')
    print(decoded_line, end='')
    if decoded_line.startswith("Cleanup script file"):  # Any other termination condition, e.g. break after 10 lines
        break

Note that, this doesn't work in ui_mode="gui" as mentioned in #3436.

Hi @mkundu1 thanks a lot! If this something the user can access through a protected method in launch_fluent?
i.e.
session.__stdout
returns the str or whatever?
Also, is there any possibility to capture the return from the very beginning, i.e. what is printed out in the .trn file? Obviously one can read and parse the .trn file, but it is not as clean (and maybe not so obvious) than a built-in method

Hi @mkundu1 thanks a lot! If this something the user can access through a protected method in launch_fluent? i.e. session.__stdout
returns the str or whatever?
Also, is there any possibility to capture the return from the very beginning, i.e. what is printed out in the .trn file? Obviously one can read and parse the .trn file, but it is not as clean (and maybe not so obvious) than a built-in method

Yes, the example code in the PR description above will print from the begining of the Fluent output till the line "Cleanup script file ..". The stdout is a buffer which will keep being populated as long as Fluent is running. The above code is a standard pattern to read from a buffer.

@mkundu1 We can track the license error at least in non GUI mode right ?


Setup API

[ ] Install grape
[ ] Install roar
[ ] Remove unnecessary rails stuff

closing this issue to move the discussion to trello on this card


Tags stopped working after upgrade to 4.4

Before upgrade
I used rails_semantic_logger with tags for logging request id, and session id. I had in my logging initialzier and it worked adding tags with these ids:
  config.log_tags = [
      #:host,
      #:remote_ip,
      lambda { |request| "#{request.uuid}"[0..32] },
      lambda { |request| "#{request.cookie_jar["_session_id"]}" },
  ]

Sample log row:
2019-04-07 13:54:03.563661 I [25929:puma 001] [["a2eb2610-9db1-475b-8d0a-547dc514d", "7713d31653d81aa6d9fe1882c282cc95"]] (499.8ms) DebugController -- Completed #show -- { :controller => "DebugController", :action => "show", :format => "*/*", :method => "GET", :path => "/debug", :status => 200, :view_runtime => 463.81, :rendered_format => :js, :variant => [], :db_runtime => 32.32, :status_message => "OK" }

Environment:

rails 5.0.4
ruby 2.4.2
semantic_logger 4.2.0
rails_semantic_loggger 4.1.3

After upgrade
Recently I upgraded my enviroment to newer versions of rails and gems (specific versions below) I can't setup automatic tags logging. I tried some combinations with named_tags like this:
  config.log_tags = {
      host:       :host,
      ip:         :remote_ip,
      request_id: :request_id,
      session_id: -> request { request.cookie_jar['_session_id'] }
  }

But it simply doesn't work:
2019-04-07 14:19:04.131479 I [23455:puma 001] (394.2ms) DebugController -- Completed #show -- { :controller => "DebugController", :action => "show", :format => "*/*", :method => "GET", :path => "/debug", :status => 200, :view_runtime => 384.13, :db_runtime => 6.99, :status_message => "OK" }

Environment:

rails 5.1.7
ruby 2.4.2
semantic_logger 4.2.0
rails_semantic_loggger 4.4.1

I added a sample app with this issue:
https://github.com/camaeel/logger-error

Same problem on ruby 2.6.2 and newest rails 5.2.3.

Semantic logger from version 4.3 or 4.4 needs setting config.log_tags earlier. It need to be set in config/[ENV_NAME].rb or application.rb. Initializer in config/initializers/*.rb is too late as loggers for Rails & Rack are initialzied before.


Training speed

Hello,
Thank you so much for sharing this amazing work!
I try to train the model with the NYU dataset. The paper says about 21 mins per epoch for 8 A100 GPUs.
Say, I am using a single A100 GPU with batch-size 32, and in my case, it seems stuck in the following step for ever... Meanwhile, I can run the evaluation without issue. I don't know what the problem could be and I would appreciate any help/hint!
with torch.no_grad():
        # convert the input image to latent space and scale.

        latents = self.encoder_vq.encode(x).mode().detach() * self.config.model.params.scale_factor

P.S., The evaluation results match with the paper well except for sq_rel.
    d1         d2         d3    abs_rel     sq_rel       rmse   rmse_log      log10      silog
0.9776     0.9973     0.9995     0.0599     0.0194     0.2187     0.0773     0.0259     5.7549

Again, thanks for the great work!

Hi @yongmayer, thanks for appreciating our work. So we used a per device batch size of 4 resulting in a total batch size of 32 with 8 GPUs. The speed issue is probably because you are using a per device batch size of 32 instead of 4. Could you try once with a batch size of 4 (with a single GPU ie. you current setup) and let me know if it works?

Thank you so much! That works!
I have another question if you don't mind asking. How should I understand the diffusion process in EcoDepth?
From line 96 in EcoDepth/depth/models/model.py (EcoDepthEncoder.forward), I see it uses the Unet from stable diffusion, but cannot see how the forward diffusion process. Am I understanding it wrong? I am new to the diffusion-based depth estimation, and I would appreciate your kind explanation a lot!
Again, thank you!


Intermittent 'InvalidInputException' while updating policy

Unable to update policy sometimes. We get 400 error code InvalidInputException. The policy body is valid and it gets updated successfully once we delete the current policies (by updating the parameters in parameter store) and re add them with the same policy.
Note: This happens intermittently and when the policy_manifest.json is updated and a new/updated file is placed in the S3 bucket.
Details:
We wanted to enable 'remediationEnabled' option for one of the policy. We updated the policy_manifest.json file accordingly and uploaded it to the bucket. To trigger the Policy manager lambda function we updated the SSM parameters (ous and regions). The lambda function was triggered however it couldn't update the policy and failed in the putPolicy operation:

Expected behavior
The solution should update the policy without the mentioned error. As a workaround we're deleting policies and re adding them with the new policy changes.
Please complete the following information about the solution:

[x] Version: [e.g. v2.0.0]

To get the version of the solution, you can look at the description of the created CloudFormation stack. For example, "(SO0134) - The AWS CloudFormation template for deployment of the AWS Firewall Manager Automations for AWS Organizations. Version v2.0.0". You can also find the version from releases

[x] Region: [e.g. us-east-1]
[ ] Was the solution modified from the version published on this repository?
[ ] If the answer to the previous question was yes, are the changes available on GitHub?
[ ] Have you checked your service quotas for the services this solution uses?
[x] Were there any errors in the CloudWatch Logs? How to enable debug mode?

Screenshots
If applicable, add screenshots to help explain your problem (please DO NOT include sensitive information).

Thanks for submitting the issue. It seems an InvalidInputException. What was the input values for the putPolicy api call? Since this is intermittent issue, have you noticed anything different when the issue occurred?

Close the issue due to inactivity


Occasionally face textures glitch and show entire skin for a moment

it's not noticeable until i look in f5 and i am not the only one who can see it, the video below shows what i mean
https://user-images.githubusercontent.com/131782673/234301065-2bf401cb-1259-4efe-ba6d-4675e9bc1a9b.mp4

There is no video only sound.

There is no video only sound.

https://streamable.com/vy4qx5

It may be an issue with the Essential mod, try it without it, or you have cubes under your model showing through, check it in the Editor.


Templates not part of this repository

Modifying a template could be a recurrent task to improve the message, by adding or removing things, according to the needs of each area / region.
By having the templates as part of the code of this repository, it makes very complicate to modify them. Especially for non developers volunteers.
I propose something different, like the application points to an external site that contains the text of the template.

I get your point and it's a fair point.
I could check if I can integrate it in https://crowdin.com/project/osm-welcome-tool
That would already make it easier to be adapted by non developers.


Breakpoints aren't getting hit in MEAN app after update to 0.10.5 from 0.10.3

Updated on two machines and on both machines breakpoints are no longer getting hit, despite Code appearing to be attached to the process.
Runing process via "nodemon --debug ./bin/www", then attaching via "Attach" in VS Code.
Debugging via "Launch" works fine and breakpoints are hit.
OS: Windows 10

@igorvaschuk which nodejs version?

@igorvaschuk I've installed MEAN and created a first app with "mean init yourNewApp". Since I'm unfamiliar with MEAN could you please guide me how to create an app that lives in ./bin/www so that I can reproduce the problem.
BTW, I could not reproduce the attach problem with an express app.

I was also getting this when running on Ubuntu. I was trying to attach to a standard expressjs app and it would not hit any of the break point. If I used Launch it worked fine.

@igorvaschuk @gclifford could you please try to use a non-default debug port for the express app, e.g. something like "node --debug=5555 bin/www" and then modify the launch config in VSCode to the same port. In my experiments I've seen a problem with the standard 5858 debug port.

I'm noticing that I'm having problems lately hitting breakpoints in VSCode for my node project as well. Somewhat recently nodemon was added to the mix via gulp-nodemon where gulp was already used for launching the debug mode of the app. I'm guessing that there may be something with how nodemon works which is causing problems for VSCode. Not sure where or if this can be addressed.
Possible realated issues:

https://github.com/remy/nodemon/issues/546
https://github.com/JacksonGariety/gulp-nodemon/issues/92
https://github.com/JacksonGariety/gulp-nodemon/issues/85

@weinand I've tried your advice with the debug port but it didn't seem to help in my case.

@weinand I am not experiencing this anymore. I am wondering if there was a difference between the TypeScript code and sourceMaps and the debugger got confused.

:+1:! This is really vital
As Ward Bell stated in the comment on John Papa's blog on debugging in VS Code: "Whether client or server side. Auto-refresh as we do with nodemon should be part of the solution."
I switched over from Visual Studio NTVS to Visual Studio Code because of the terrible stalling of the UI in VS 2015 while editing typescript. VS Code is a lot more workable, but live debugging is now still not possible.

@bartvanderwal I suggest that you file a separate issue for your feature request because this issue is a bug.

Thanks for the quick reply @weinand, but actually it IS working now. Somewhat. At least I won't post an issue.
In case this might help anyone It's working with below settings in Current VS Code version (e.g. v0.10.6) on Windows 10. But it'll probably work on Mac too (I might check later).
/.vscode/launch.json
{
	"configurations": [{
		"name": "Launch",
		"outDir": null

	},{
		"name": "Attach",
		"type": "node",
		"request": "attach",
		"port": 5858
	}]
}

For completeness I'm running Nodemon using grunt with below settings, but the equivalent command line should do the same.
/Gruntfile.js
nodemon : {
	dev : {
	script : 'launcher.js'
	},
	options : {
		ignore : ['node_modules/**', 'Gruntfile.js'],
                nodeArgs: ['--debug'],
		env : { PORT : '4123'
		}
	}
}

I guess the debug port 5858 is the default since it's not specified here (but it is in launch.json above.)

If breakpoints in your startup code are not hit in "attach" mode, but they work in "launch" mode please try to start your target with the "--debug-brk" option instead of the "--debug" option.
The "--debug-brk" option makes sure that the target stops on entry and that VS Code gets a chance to  properly register the breakpoints. When starting with "--debug" only, the debugger runs over the startup code before VS Code has a chance to register the breakpoints.
In "launch" mode it is not necessary to set stopOnEntry to true in order to get the breakpoint in startup code hit because VS Code behind the scenes always launches the debugger with "--debug-brk" (but hides the break on entry to the user).

@bartvanderwal I've created this feature-request for the automatic reattach:  https://github.com/Microsoft/vscode/issues/2103

That looks great @weinand! I'll try it out shortly.

I have found one weird workaround with node --debug (default port) and node-inspector.
Same-module breakpoints in vscode begin working as expected after setting and hitting just one breakpoint using node-inspector in that module. Breakpoints set by vscode in other modules fail to hit until node-inspector first hits a breakpoint in the same module.

My Express 4 application is experiencing a similar issue.
It runs on a Debian 8 box, Node.js version is 4.3.0 and VS Code 0.10.8 runs on Windows 7. I start it with:
node --debug-brk server/server.js
VS Code breaks at the first line. Next every breakpoints in server/server.js are correctly handled by VS Code. But all the breakpoints ouside this file will never stop.
On VS Code Debug view, server/server.js is marked as "content streamed from server" but not on Exporer view. By the way its breakpoints are only visible in the Debug view. It seems that only this file is processed by VS Code.
On the other hand, Node Inspector works like a charm:
node-debug --web-host=<IP_ADDRESS> server/server.js

VS Code has been updates to v0.10.10 but there is still the same behaviour.
After reflection, I figured out that VS Code was not able to map remote files to those of the Explorer view. I investigated the vscode-debug-node project and I have found the localRoot and remoteRoot parameters of attach configuration:
https://github.com/Microsoft/vscode-node-debug/blob/master/src/node/nodeDebug.ts#L146
And there is a short description about them on January release page, below "Remote Debugging":
https://code.visualstudio.com/updates/vJanuary#_nodejs-debugging
These 2 parameters fix the issue. Here is a launch.json configuration sample:
{
    "name": "Attach to my.remote.linux.box",
    "type": "node",
    "request": "attach",
    "address": "my.remote.linux.box",
    "port": 5858,
    "localRoot": "${workspaceRoot}",
    "remoteRoot": "/path/to/project/root/on/remote/host"
}

I hope this can help.

Since there are so many issues discussed here and many issues have been addressed, I no longer have a clear view what problem is still open. Please open new items for everything that is still not working.


Add extensions to replace free functions

Prefer methods and properties to free functions.
Swift API Design Guidelines

Let's keep the free functions in place, but add extensions to types (which should call the free functions).
Update:*

[x] extension on NSManagedObjectContext for delete
[x] extension on NSManagedObjectContext for fetch
[x] move resetStack to CoreDataStack

If submitting a pull request, please do 1 function at a time. (1 per PR) 😄

Let's keep the free functions in place, but add extensions to types (which should call the free functions).

If the objective is to keep the free functions for background compatibility, maybe it's the free functions that should call the extensions methods 🤔
And do you want the implementation of the library to still use the free function or the extension methods?

Hey @Liquidsoul

If the objective is to keep the free functions for background compatibility....

Yes, originally the goal was to make this change backward compatible, but I've decided against that since #60 has been completed — which is a breaking change. 😄
So, this task is set for the 4.0.0 release too, which will be breaking (from the current 3.0.0).

And do you want the implementation of the library to still use the free function or the extension methods?

I think it would be best to have 1 way to do things. For example:
// OLD - remove this
saveContext(context)

// NEW - add this
context.save()

So we'll remove the free functions and replace them with extensions.

Here's what I'm thinking:

extension on NSManagedObjectContext

save
fetch
delete

move resetStack to CoreDataStackFactory
let's leave entity() alone for now

😄

👍 for 1 PR for each.
I do not know if it will be possible to extend NSManagedObjectContext with a custom save() because save() throws already exist on the object and we're using it in saveContext() 😅
It will be interesting to look into this 😁

Where do you want the extensions to be?
CoreDataFunctions.swift does not fit anymore.
What do you think of using a file named NSManagedObjectContext+JSQCoreDataKit.swift?
Maybe we can find an better name that +JSQCoreDataKit but I cannot come up with something else right now 🤔

let's leave entity() alone for now

Damn! That was the first I did yesterday evening 😅 I'll keep it for later then 😉

I do not know if it will be possible to extend NSManagedObjectContext with a custom save() because save() throws already exist

Haha. Derp. I wasn't thinking. I suppose let's leave saveContext() as-is for now. 😊

Where do you want the extensions to be?

How about, CoreDataExtensions.swift ? 😄

Damn! That was the first I did yesterday evening

Ha. Where did you put this? I guess on NSEntityDescription ? You know what, entity() may not be necessary with Swift 3.0 and the "Great API Transformation". Let's hold off for now and see what happens in Swift 3.

How about, CoreDataExtensions.swift ? 😄

👍

Ha. Where did you put this? I guess on NSEntityDescription ?

Yup 😉

You know what, entity() may not be necessary with Swift 3.0 and the "Great API Transformation". Let's hold off for now and see what happens in Swift 3.

Let's leave it alone then 😃

I've just submitted the last modification for the fetch function here #78.
As I told you, I already did the entity one. You can see the modification there a19ca1e3f6ec8a5266cd83eab9b9d14b79456ef2 and if you change your mind about integrating the change, I can create a pull request 😉

Closing. Complete as of 	2683bdb.

@Liquidsoul
FYI, see #87


Logger compression broken

It apparently creates empty archives on shutdown. I will check more and see if it occurs earlier too.

Nevermind, it was some broken permissions on my side


Avoid category type for high-cardinality id3 col when creating parquet data

[x] Closes #11

Data is already up in S3 (added link in README). This is a fix to the scripts, to generate the data using LocalCluster and update the test accordingly. I don't think there is a major review to do, just a sanity check before hitting the green button.


Feature/center infinite false

I am currently working on a feature where I need the carousel to function like this:

center mode, infinite false, no empty placeholder
when user interacts with the carousel - click on next - set infinite true

In the current implementation there is a bug: if you set the initialSlide in the settings, it will break the arrow functionality for the first clicks on "next" - internally the slider starts targetSlide at 0, although the targetSlide should be populated from initialSlide - if provided.
Thank you,
Vlad

Tested with my production site. Everything is Ok

@akiran can you please take a look and trigger a travis CI rebuild as the last one failed due to node-sass?
Best
Vlad


fix: LSDV-4532: Audio v3 visual data is offset to sound playback

PR fulfills these requirements

[X] Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
[-] Tests for the changes have been added/updated (for bug fixes/features)
[X] Docs have been added/updated (for bug fixes/features)
[X] Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
[X] Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

[ ] Product design
[X] Frontend

Describe the reason for change
To support larger duration audio files > 5 hours.
The audio v3 performance branch was out of sync when playing back audio, and what was visually rendered in the wave. As a result the code had to be reverted to the previous state of audio v3, which removed all performance improvements.
What does this fix?
Fixes an offset issue with the underlying decoder lib in use. The Audio was always off by 1 second to the playback source. Also changed the point at which the audio media source begins loading, and when to pause audio on disconnecting the source to ensure playback is as immediate as possible.
I now removed the initial loading deduplication from the Audio view which was based on annotation store properties being set, in favor of the natural cache of the decoders. It is now redundant and will cause more inconsistencies like sometimes not loading the waveform on fresh reloads of the page in quickview.
What is the new behavior?
Reintroduces the audio v3 performance improvements, without the audio delay.
Decoding
Audio files are now decoded using an FFMPEG based decoding library using Web Assembly. This decoding process is performed in chunks of 30 minute durations on the file, and the process itself happens from a WebWorker off the main thread. Every source file is run through an AudioDecoder (handles the decoding process between WebWorker and the FFMPEG lib) instance via the AudioDecoderPool (manages AudioDecoder instances via a Proxy), which allows reuse of the same decoder for sources in multiple tag cases and deduplication of work for same requests that happen within the same time period. This ensures the least amount of memory is retained between workloads, while optimizing for the common use cases in LabelStudio. It also continues to ensure memory is freed between decoding to ensure no memory leaks occur by marking it for removal, which will destroy and cleanup any instance(s) not in use after a 1 second grace period.
Rendering
Audio data is rendered now within a time frame (time slicing with generators and requestAnimationFrame), and yields back to the remainder of processes on the main thread to ensure that in worst case scenarios it does not freeze the UI. The reason for this particular change is to allow far zoomed out renders to be able to quickly cancel out stale, potentially longer running renders allowing only the most fresh to complete. This enables a more freely useable x-axis zoom, y-axis zoom and resize of the entire interface due to window/container resize at lower zoom levels.
In addition to the time slicing, an alternative approach is used to render the very large data points (large duration, zoom level is zoomed far out). It reuses the currently drawn buffer canvas and shifts it over by the movement direction, rendering the small slice of data that is now in view. This stabilizes the worst case scenarios and produces ~60fps on massive amounts of data (tested with ~200 million data points).
What is the current behavior?
Decoding
Audio files are currently decoded using the web audio api decodeAudioData. This has many usage implications on any file that is > 20 minutes on most hardware, as the underlying implementation does not throw errors, and instead crashes the browser with usage that would cause the api itself to throw an exception. Memory usage is erratic and it is impossible to control when or if it garbage collects any previous decodes. It is also impossible to chunk decode, and all decoding happens on the main thread as it is not possible to use this api from a WebWorker.
Rendering
Audio data was rendered using no time slicing techniques, and would be overwhelmed by larger or more frequent requests. It uses a similar sampling technique which does produce good results, but is not enough to stabilize performance past ~10 million data points.
What libraries were added/updated?
https://www.npmjs.com/package/audio-file-decoder v2.3.0
Does this change affect performance?
Yes. Vastly improves performance, but more importantly stabilizes and removes uncontrolled crashes from happening.
Does this change affect security?
No
What alternative approaches were there?

FFMPEG wasm directly https://github.com/ffmpegwasm/ffmpeg.wasm.
Decode the waveform data on the server using tools like https://github.com/bbc/audiowaveform, and load and render that on the client.

What feature flags were used to cover this change?
ff_front_dev_2715_audio_3_280722_short

Does this PR introduce a breaking change?
(check only one)

[ ] Yes, and covered entirely by feature flag(s)
[ ] Yes, and covered partially by feature flag(s)
[x] No
[ ] Not sure (briefly explain the situation below)

What level of testing was included in the change?
(check all that apply)

[-] e2e (reusing current tests)
[ ] integration
[ ] unit

Which logical domain(s) does this change affect?
Audio v3 (codename AudioUltra)

Codecov Report
Base: 9.41% // Head: 9.41% // No change to project coverage :thumbsup:

Coverage data is based on head (4562339) compared to base (d84c38e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1166   +/-   ##
======================================
  Coverage    9.41%   9.41%
======================================
  Files         109     109
  Lines        7786    7786
  Branches     1953    1953
======================================
  Hits          733     733
  Misses       5908    5908
  Partials     1145    1145

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

about breaking changes — looks like it introduced such change already and was reverted :)
so I'd check at least "Not sure" with explanations


Further Python 3 compatibility work

The next chunk of compatibility work following #225.

I checked out the Master; built and installed under Python 3.4.3; ran an interactive session in IPython 3.1.0-dev using the WMS protocol .. example PNG image and all object attributes succeeded.

cc @kwilcox
@takluyver thanks much for these contributions.  I'm wondering whether we should turn on Python 3 testing in .travis.yml and / or update tox.ini ?

I ran the tests earlier, and there were still a bunch of failures on python
3, so you probably don't want to turn it on just yet. I will see how easy
it is to get things passing.


Molecule tests (on scigility branch)

README moved to https://github.com/hortonworks/ansible-hortonworks/pull/175
In case the newly done upstream PR does not get merged soon, we can merge this PR to our master

fyi @alexandruanghel , this is great IMO (way also to get a flexible HDP cluster deployed, in docker, on your own notebook/PC) .. just need to rebase to upstream 👍

This PR is no longer required, since my upstream PR #175 got merged to master (and is now also in our fork's master)


Added city property

Added city property for messages produced in ORDERS.NEW topic.
Cities are chosen at random from the list related to the region.

I'll start by considering this hypothetically - as a general connector change.
And then, look at this through the lens of the role of this connector as a part of EA demos.

As a general change...
In it's current form, the PR adds a new required field.
This is acceptable as a forwards-compatible change.
If you were using schema registries...
You would handle this change by updating the producer first (in this case, update the Kafka Connect connector).
Then you would have a choice:
option a) Ignore - Consumers would be able to carry on as before, fetching the new schema to use as the writer, but continuing to ignore the new field as they still use the old schema as the reader.

benefit: Consumers can read the old messages and the new messages
downside: Consumers don't get the new field, so it's sort of pointless to be producing it

option b) Migrate - Consumers update to use the new schema for both writer and reader

benefit: Consumers get to read the new property
downside: Consumers can't read older messages any more - trying to consume older messages produced before the new schema will cause errors

If you're not using a schema registry...
Any change is always a breaking change, so consumers wouldn't be able to handle it.

If you leave the consumer with the old schema, they'll only be able to read the old messages and will break with the new messages.
If you update the consumer with the new schema, they'll only be able to read the new messages and will break with the old messages.

If the PR was updated...
The PR could be updated to make the new field optional, and include a default value. This would make it a fully-compatible change.
If you were using schema registries...
You could handle this change by updating the producer first (in this case, update the Kafka Connect connector). And then you'd be free to update consumers whenever you want. Before you update the consumer, it wouldn't know about the new field. After you update it, it would know about the new field. Consumers could still read old messages produced with the old schema, because it would be able to use the default value where needed.
If you're not using a schema registry...
Any change is always a breaking change, so consumers wouldn't be able to handle it.

If you leave the consumer with the old schema, they'll only be able to read the old messages and will break with the new messages.
If you update the consumer with the new schema, they'll only be able to read the new messages and will break with the old messages.

so looking at this as a general change, I would request that the field be made optional.

As a part of the EA demo
In reality, this isn't a general purpose connector so much as a component of demos - where we know how it is being used.
Most of the use of this topic is from clients that don't integrate with the schema registry (e.g. https://ibm.github.io/event-automation/tutorials/guided/tutorial-1 ) so regardless of whether we improve the PR to make it a more compatible change, we will still break those users.
As a result, I think this means we need to consider this change in that broader context, and have the following options:
option 1) Close the PR - if we don't feel this new field is so essential to justify the disruption it will cause, then it's simplest to just close the PR.
option 2) Start a new topic for this new format data - e.g. change the topic to ORDERS.V2 - and make the corresponding changes to everywhere that refers to the topic name (e.g. https://github.com/IBM/event-automation-demo/blob/main/eem-seed/eem-03-ORDERS.NEW.json#L19 is one of likely over a dozen places that would need updates). I'd ask you to have those changes ready before we merge this PR.
option 3) Update tutorials based on this topic that tell people to delete the existing topic before applying this update - this would let them keep the topic name the same, but introduce a manual step. I'd ask you to have those documentation changes ready before we merge this PR.
With that context, @sreckoj what would you like to do?

I am closing this PR because we decided to use ORDERS.ONLINE instead ORDERS.NEW

Closing as ORDERS.ONLINE already contains city property


[0.3.1] Cannot upgrade armv6l (wrong architecture)

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
1: use existing 0.3.0 install on a RPi 1B
2: Install version 0.3.1
Expected behavior
'Normal install'
Screenshots
Log:
dpkg: error processing archive v4l2rtspserver-0.3.1-Linux-armv6l-.deb (--install):  package architecture (armv6l) does not match system (armhf)
By-the-way: armhf install but segfaulted.
Desktop (please complete the following information):

OS:
Linux 5.10.92+ #1514 Mon Jan 17 17:35:21 GMT 2022 armv6l GNU/Linux

Hi,
armhf is armv7, armv6 package architechture is wrongly build.
Best Regards,
Michel.

Ok thanks. Is a new build be expected?

I am checking it, the 0.3.2 should be ok.

Great!

It works with 0.3.3
Thanks


NEW Add new SilverStripeVersionProvider to provider module versions

Issue: #6880
This PR adds a new service provider for gathering module versions from the composer lock file, and replaces the logic in LeftAndMain::CMSVersion.
Example configuration to add modules:
SilverStripeVersionProvider:
  modules:
    silverstripe/framework: Framework
    silverstripe/somemodule: Some Module

The getVersion method would return Framework: 3.7.0, Some Module: 1.2.3 for example.
The CMS (see PR) can block the framework version from being displayed in favour of the CMS. Exaple CMS: 3.7.0 instead of Framework: 3.7.0, CMS: 3.7.0 - assumption being that in 99% of cases the CMS and framework versions will be identical. This will also allow CWP to add its version to the tooltip as well, e.g. SilverStripe: 3.7.0, CWP recipe: 1.7.0 for example.

It's worth mentioning that LeftAndMain::CMSVersion used to try and fall back to loading the silverstripe_version file if a composer lock doesn't exist and get the version from that. I didn't port this change over because the file is currently empty, so it wouldn't result in different behaviour from 3.7.x onwards - and most installs would be with composer now.

Related PR for CMS: https://github.com/silverstripe/silverstripe-cms/pull/1881

Yeah, maybe I'll rewrite a little and use the caching to mock it

I'll move the "load composer lock contents" logic to another method then just mock that

@dhensby test added


Simple pagination for map vault and cleanup

Changes 'more' button into working like a 'next page' button (unloads previous map cards on click) to prevent rising memory and cpu usage.
Makes sure all code in MapVaultController is called from correct thread
Removes redundant constant MAX_SEARCH_RESULTS

Continues #1104
Fixes #1319
This should make nothing worse, should reduce memory usage dramatically, fix some bugs and pepare for proper pagination UI. So its not really a quickfix anymore even if i put that in the branch name. Sorry^^

Also did you rename the button to "load next" maybe because "load more" sounds like it louds more instead of replacing current one with those up next

'Load next' is kinda missing the subject imo (which next?). 'Load more' seems more intuitive for non-technical users to me (becuase in that case the subject is obvious: Load more maps).
Maybe 'load next page'? But id still argue, that 'page' is kind of a dev/technical/non-intuitive term.

Well whatever more is not tat bad either

I still want to add tests btw, just had to fix tests in Eclipse first^^

Tests added. I have to say i really like Mockito.

While we are at it: Is this comment
https://github.com/FAForever/downlords-faf-client/pull/1320/files#diff-5817aa64094c1068a332e4f37f011d87R54
still relevant? Its seems to me that Elide has fully implemented this, but the getXXX methods are still used. So whats the status on that?

@Brutus5000 is most into elide he might know.

I think this is just Travis having this issue again.

Not travis it is some of our tests

rebased

I have no clue what that comment is supposed to mean. The underlying API calls are very different I don't see any harmonization potential.

Well this would be the next steep I guess

I'm not improving this. The current state is a loss of functionality and user experience until there is a back button.

ok

I'm not approving this. The current state is a loss of functionality and user experience until there is a back button.

The current state is that people's vault crashes when they go for the second or third 'more' click. So i would not say that it is a loss of functionality, its more of a trade (going back a page is not really helpful if you cannot go forward more than 2 patches without a crash).

We can still add the previous button should be really easy i think

If you add a previous button, you need to split the more button from the front page showroom to stay a 'more' button there but become a 'next' button on the actual pages (because the showroom is not the first page of anything). Sure, still easy, but his PR was meant as a kind of important bugfix for vault crashes (which btw are only reproducable in the actual officially distributed client release), not a UI change.
If we want a 'proper' pagination UI, there are more things that should also be touched/changed. Showing the current search on all pagination pages, direct links to intermediate pages, ect...

@Brutus5000 better now?


Update 2017-04-19-an-unofficial-response-to-an-empirical-analysis-of-…

…linkability.md
Replaced two instances of "deductible" with "deducible".

I fixed a few grammar mistakes and took some more community suggestions.


Added more terms to Core Concepts

As per https://github.com/fluxcd/website/issues/760, the Core Concepts page is already positioned at the top of the docs, before Get Started.
This PR aims to ensure the user has only 1 glossary to refer to, instead of 2 on different pages, and they get to learn about all the basic terminologies.

I know I suggested this change originally, but I am afraid the glossary and the core concepts are not the same. There are some cross purposes at play here, the original intent of the e2e page was to create a single page where you could go to read everything about how Flux works all at once. I think this is the right change for the e2e page, but I'm not sure it's right to go there.
Also I feel compelled to reorganize these terms and put them in alphabetical order, but the core concepts page is not in alphabetical order.
https://deploy-preview-1723--fluxcd.netlify.app/flux/concepts/#service
There's also a typo in the translation here, one of the headings has ** still appended to it

@kingdonb I can go ahead and make the following changes if we are good to go with it:

Rearrange glossary in alphabetical order
Remove the **
Fix the typo

However, before I do that, I want to share that I understand why the glossary was kept separate from the core concepts. Having that said, don't you think all the terminologies should be discussed under the same page instead of maintaining two different pages? What are your thoughts?

I think we should have one page for terms. I'm good to merge this and iterate once we fix the typo 👍

Sorry, I brought up alphabetical order because the glossary was in alphabetic order, but the Core Concepts is not a glossary, it begins with the most important concept and proceeds vaguely chronologically through Kustomization which is the end.
I don't know if the glossary adding to the core concepts is going to make things too populated too early. One of the features of the Core Concepts page currently is it does not have very many ideas on it, only the ones that are most central to Flux.

Note of the added things are core concepts of Flux.


Locks every time the main program is opened

Thank you very much for providing the screen lock function!
In use I found that when the lock is complete, kill the main program, and then open it again, the "locked" state is invalid. Hope to help fix it, thanks!
My suggestion is: can it be locked every time the main program is opened? This can provide a little more protection for our data.
Thanks again!
非常感谢您提供屏幕锁定的功能！
在使用中我发现，当锁定完成后，杀死主程序，然后再次打开时，“锁定”状态失效了。希望帮忙修复一下，谢谢！
我的建议是：能否在每次打开主程序的时候都锁定一次？这样能对我们的数据多了一点点的保护。
再次感谢！

Problem cannot be reproduced


Write a privacy policy

Since we're collecting user data, we'll need a privacy policy.
We should include:

What we do with feedback provided via Doorbell (especially where an email is provided, since that counts as personally identifiable data)
What data we collect via Google (and a note that it's all anonymised!) see #112
Links to third-party privacy policities (ie, Doorbell and Google)

Reference:
https://www.privacypolicies.com/blog/privacy-policies-legally-required/#Privacy_Laws_In_The_Eu
Good example to follow: https://www.gov.uk/help/privacy-notice (we could go simpler than this!)

I've committed a privacy policy now - a slightly stripped-down version of the gov.uk policy.  It could probably do with a wee bit of stlying, mainly because our CSS doesn't really do any rendering of lists. So assigning to @sarahmonster if that's ok? :)


⚠ Bofrost.lu has degraded performance

In 52ad9d2, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 884 ms

Resolved: Bofrost.lu performance has improved in 82e2b35 after 6 minutes.


Collisions in floats

https://news.ycombinator.com/item?id=14519567

These collisions are now resisted.


Update jtreg jar

Close #213
Signed-off-by: Sophia Guo<EMAIL_ADDRESS>

Convert to draft as this may need to cooperate with PR in other repos and rerun some jenkins build.

Yes, @karianna. Naming to be consistent with jtreg releases. https://github.com/openjdk/jtreg/releases

test.dependency on all Jenkins need to be relaunched after this PR

https://ci.adoptopenjdk.net/job/test.getDependency/1105

https://openj9-jenkins.osuosl.org/job/test.getDependency/34/


[CARBONDATA-2025] Unify all path construction through CarbonTablePath static method

Refactory CarbonTablePath:

Remove CarbonStorePath and use CarbonTablePath only.
Make CarbonTablePath an utility without object creation, it can avoid creating object before using it, thus code is cleaner and GC is less.

[X] Any interfaces changed?

[X] Any backward compatibility impacted?

[X] Document update required?

[X] Testing done
Run all test

[X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
NA

retest this please

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/3384/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2147/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2150/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/3387/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2154/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/3392/

LGTM

Merged into carbonstore branch


Updated Codeacademy's Rails Auth link

The previous link gave 404 error.
Update with newer working link.

Thanks!


[FLINK-27485][Documentation][Build] Fix the documentation build pipeline

What is the purpose of the change

Fix the currently broken documentation build pipeline

Brief change log

Use different Git command (which is supported by the installed Git version on the Docker image)
Upgrading Hugo and making sure that this is added to the PATH by extracting it to /usr/local/bin

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

@flinkbot run azure


Select tools path relative to the current devenv.exe

Fixes #1011
Change how many tools are found, finding them relative to devenv.exe (rather than a program files directory).

Change the async powershell call to actually shutdown powershell on cancelation.

@quoctruong, @redborian
PTAL


Added solution for Add Two Numbers

Hacktoberfest! 🎊🎈
🎉 Have you read the Contributing Guidelines? 🤔
Yes, I have read the Contributing Guidelines
📝 Description
Added question.md which provides a detailed description of the "Add Two Numbers" problem and also solution.dart to the "Add Two Numbers" problem which contains an implementation of my solution to this problem in dart programming language
Fixes #151  🔧

✅ Checklist

[✅] I've read the contribution guidelines. 📚
[✅]I've checked the issue list before deciding what to submit. 🔍
[✅] I've edited the README.md and linked to my code. 📄

Hi there!
Although this repo is not part of Hacktoberfest 2024, we have some great alternatives for you. Welcome to SkillShow, a repository focused on skill enhancement!
Guidelines:

Please adhere to the existing guidelines.
No additional rules, thanks!
Check it out here: SkillShow.

Note: Start by creating an issue. Once it’s assigned to you, feel free to open a pull request (PR). Directly opening a PR will lead to an invalid label.
Looking forward to your contributions!


Feat/struct

decode packet to struct
encode struct to packet
conformity struct and primitive
redefine ProtoCodec
update YomoCodec for struct
closes #20 #21 #22 #23 #24 #25 #26 #27

support for  struct codec
closes #20 #21 #22 #23 #24 #25 #26 #27


Contact us Page

🖥 Frontend Issue
Description

contact us page having major contact details
Steps to Reproduce

Go to '...'
Click on '...'
See error '...'

[X] Yes
[ ] No

make proper issue with giving complete details @Premkolte

make proper issue with giving complete details @Premkolte

Ok, I'll keep it in mind next time.
@dhairyagothi


Mouse Drag Support

I would love to be able to set one of the buttons on the screen edge to emulate multi-monitor setup. I use rkvm this for work and it's so great. TY for this project.

Glad you like rkvm! Can you please describe the use case in detail? What do you mean by one of the buttons?


Fixed variable name in modifyconstraint!

This PR fixes the variable not found error when modifyconstraint!-ing a VectorAffineFunction constraint with a MultirowChange. This simply changes fund to func, after which the function works correctly.

On a similar note, I think that constraints.jl#L649 is also typoed, with modifyconstraint instead of modifyconstraint!. I haven't checked that one, however.

The implementation of transformconstraint! is incorrect indeed. It will in fact never be called since the type of newdom will never be the same set type than cref by definition of transformconstraint!

@ulfworsoe I have merged it since https://github.com/JuliaOpt/MathOptInterfaceMosek.jl/pull/36 requires the change of this PR


Why we need different setting for different benchmark?

Thanks for such wonderful work and release the corresponding code, datasets and model.
I do not understand why we need different setting for different benchmark? just as the readme
'''
Models have inference options that can be set via environment variables. For the longest6 model you need to set export UNCERTAINTY_THRESHOLD=0.33, for the LAV model export STOP_CONTROL=1 and for the leaderboard model export DIRECT=0
'''
Does it mean for different benchmark, we use the different method, furthermore, dose it mean the method which work well on Longest6 do not work so well on LAV? What are the meaning and difference between these setting?
Thank you!

Maybe you should check out the appendix.
As for STOP_CONTROL=1:
LAV is the only benchmark that considers stop sign infractions, so this feature makes no sense for the other 2 benchmarks hence it is turned off by default and you need to turn it on for LAV.
The impact of the stop controller is discussed in Table 11.
As for UNCERTAINTY_THRESHOLD=0.33
Table 14 investigates the impact of this threshold for the LAV benchmark.
Since it doesn't matter much at that benchmark I left it at the default of 0.5.
For the longest6 this threshold does make a few (~3-4) DS difference,  due to the dense traffic, hence I tuned it to 0.33.
Even if you leave it to the default value you will still get a state-of-art result, but the instructions above are to reproduce the results in the paper.
As for DIRECT=0
In principle the code supports models with both path + target speed (direct=1) and waypoints (direct=0) as output representation (though i did not end up using that feature), hence you need to pick which one you want to use during inference.
As discussed in C.6. CARLA Leaderboard the model there is a TF++ Waypoint which is indeed different to the other TF++ (which use path + target speed as output.
You need to set DIRECT to 0 otherwise the inference code will crash, because path+ target speed are not trained for this model.

dose it mean the method which work well on Longest6 do not work so well on LAV?

Not really, the difference is only in the controller. You can also use STOP_CONTROL=1 on longest6, it just would not do anything.

Yes this is correct.
Both are also different models one trained with path + target speed as output representation and one with waypoints.
The leaderboard show 2 more results because they were not finished when I put the paper on ArXiv.
Will include them in the paper once I finished the camera ready version for ICCV.


[pb3CtuNX] Adds convert.paths.toTree to deprecate old convert.toTree

Cherry picked from https://github.com/neo4j-contrib/neo4j-apoc-procedures/pull/4044
What
Adds a new method convert.paths.toTree that deprecates convert.toTree.
Closes #3996, #3997
Why
There were several problems with the old method. For paths:
v1 -> v2 -> v3
v2 -> v2 //self-loop

it was outputting:
v1 -> v2 -> v2
v2 -> v2

instead of:
v1 -> v2 -> v2
         -> v3

This PR adds a new method that:

Fixes the behaviour for cyclic paths.
Fixes the behaviour for bidirectional paths.
Fixes the properties filter for both of the method when the nodes have several labels.

/spotlessApply

/generateLicensesFiles

/generateLicenses


fetchIfNeededInBackgroundWithBlock : [Error]: Object not found. (Code: 101, Version: 1.14.1)

So I have spent the day trying to track this down.
History, moving from Parse to Parse Server (latest version of all)
I have a website that creates a record (Search) and attaches a couple of images to it (SearchPicture) for which it creates a relationship (Parse.Object.extend("SearchPicture")).
This works perfect in Parse.
On the iOS end, we load up the Search, and loop through its relationships to SearchPictures and use fetchIfNeededInBackgroundWithBlock.
Moving it to Parse Server, I get  [Error]: Object not found. (Code: 101, Version: 1.14.1), I can see the ID of the record it is trying to find (gq5h0xddGA) and I can see the record in Mongo :
_{ "_id" : "gq5h0xddGA", "searchPictureImage" : "4992d20cad4f3d8c90804efa42f6475a_Screen Shot 2016-07-15 at 13.41.23.png", "_created_at" : ISODate("2016-07-21T13:31:18.592Z"), "updated_at" : ISODate("2016-07-21T13:31:18.592Z") }
If I just query the table normally (SearchPicture) in iOS it works fine and  fetchIfNeededInBackgroundWithBlock is successful.
So it seems to be the link between Search and SearchPicture that causes fetchIfNeededInBackgroundWithBlock to fail

I would say this is related to #https://github.com/ParsePlatform/Parse-SDK-iOS-OSX/issues/986

"If I just query the table normally (SearchPicture) in iOS it works fine and fetchIfNeededInBackgroundWithBlock is successful."
If you query table SearchPicture directly, why would you need to do fetchIfNeeded? Isn't it already the object you wanted from Search (ie the relationship you were looking to watch)

Good points well made Acegreen, of course fetchIfNeededInBackgroundWithBlock works normally, sorry I have not used parse for sometime, picking up a old project.  I will see if call it twice fixes the issue

Calling it multiply times does not help.  I am using local storage and I did try fetchInBackgroundWithBlock

fetchIfNeededInBackgroundWithBlock in that case is not needed at all. If you use that work around, you are going to find them in your query and you have them. fetchIfNeededInBackgroundWithBlock is neccessary in the original issue because you are quering the Search objects and they have relationships that might not have been included in your query (includeKey..) and thats why you need to fetch them.
Another point just for FYI, if you know you will always need SearchPicture when you query Search objects then include it in your query and you will not need to fetch or you won't need to do your workaround.
searchQuery.includeKey("SearchPictures")

Now searchQuery.includeKey("SearchPictures") is a good idea, thank you mate, that could fix my issue

Yea it will not really fix the fundamental problem in fetchIfNeededInBackgroundWithBlock but it might be an option in your case if you know you will always want it in your query.

Hmm maybe  query.includeKey("searchPictures") is broken to, so my object comes back like
<Search: 0x7a5550c0, objectId: WezgvgpQFI, localId: (null)> {
searchDetails = "Age:sdfsdf\nHeight:sdfsdf\nCurrent Clothing:sdfsdf\nLast know Location:sdfsdf\nRadio Channel: sdfdsf";
searchId = "Search 1";
searchInitialSearch = "<PFGeoPoint: 0x7ce5b6a0, latitude: 51.518678, longitude: -0.631800>";
searchPictures =     (
);
searchTitle = dfdsfds;
}])
However mongo says
{ "_id" : "WezgvgpQFI", "searchPictures" : [ { "__type" : "Pointer", "className" : "searchPictures", "objectId" : "gq5h0xddGA" } ], "searchInitialSearch" : [ -0.6317996978759766, 51.51867760878029 ], "searchTitle" : "dfdsfds", "searchDetails" : "Age:sdfsdf\nHeight:sdfsdf\nCurrent Clothing:sdfsdf\nLast know Location:sdfsdf\nRadio Channel: sdfdsf", "searchId" : "Search 1", "_created_at" : ISODate("2016-07-21T13:31:26.821Z"), "_updated_at" : ISODate("2016-07-21T13:31:26.821Z") }

its not broken, just missing fields which is expected when you spit it out. try just using it as you normally would.

I do try using it and its empty, which I know it is not

Appears to not work in Android either... I feel this seems very odd

So trying to debug this using curl
curl -X GET
-H "X-Parse-Application-Id: lowlands"
-H "X-Parse-REST-API-Key: ABCDEFG123456"
http://localhost:1337/parse/classes/Search/WezgvgpQFI
_{"objectId":"WezgvgpQFI","searchPictures":[{"__type":"Pointer","className":"searchPictures","objectId":"gq5h0xddGA"}],"searchInitialSearch":{"_type":"GeoPoint","latitude":51.51867760878029,"longitude":-0.6317996978759766},"searchTitle":"dfdsfds","searchDetails":"Age:sdfsdf\nHeight:sdfsdf\nCurrent Clothing:sdfsdf\nLast know Location:sdfsdf\nRadio Channel: sdfdsf","searchId":"Search 1","createdAt":"2016-07-21T13:31:26.821Z","updatedAt":"2016-07-21T13:31:26.821Z"}burfies1-MacBook:LowlandRescueWeb burfies1$
But if I do
curl -X GET
-H "X-Parse-Application-Id: lowlands"
-H "X-Parse-REST-API-Key: ABCDEFG123456"
--data-urlencode 'include=searchPictures'
http://localhost:1337/parse/classes/Search/WezgvgpQFI
{"objectId":"WezgvgpQFI","searchPictures":[],"searchInitialSearch":{"__type":"GeoPoint","latitude":51.51867760878029,"longitude":-0.6317996978759766},"searchTitle":"dfdsfds","searchDetails":"Age:sdfsdf\nHeight:sdfsdf\nCurrent Clothing:sdfsdf\nLast know Location:sdfsdf\nRadio Channel: sdfdsf","searchId":"Search 1","createdAt":"2016-07-21T13:31:26.821Z","updatedAt":"2016-07-21T13:31:26.821Z"}burfies1-MacBook:LowlandRescueWeb burfies1$

So more than ever I am convinced this is a bug.  I have re-written the code to actually just get the objectID from the relationship then manually retrieve the record and it works fine.
New code
let searchPictures : [PFObject] = Search.sharedInstance.selectedPerson["searchPictures"] as! [PFObject]
        for searchPicture : PFObject in searchPictures {

            var query = PFQuery(className:"SearchPicture")
            query.getObjectInBackgroundWithId(searchPicture.objectId!) {
                (searchPicture: PFObject?, error: NSError?) -> Void in
                if error == nil && searchPicture != nil {

                        let file : PFFile = searchPicture!["searchPictureImage"] as! PFFile

                        file.getDataInBackgroundWithBlock({ (data, error) -> Void in

                            if error == nil {
                                if let image = UIImage(data: data!) {
                                    Search.sharedInstance.missingPersonPhotosArray.append(image)

                                    if Search.sharedInstance.missingPersonPhotosArray.count > 0 {
                                        // Add 1st image to missing person page
                                        dispatch_async(dispatch_get_main_queue()) {
                                            self.missingPersonMainImage.image = Search.sharedInstance.missingPersonPhotosArray.first
                                            self.spinner.stopAnimating()
                                            self.spinner.hidden = true
                                        }
                                    }
                                } else {
                                    self.spinner.stopAnimating()
                                    self.spinner.hidden = true
                                }
                            } else {
                                self.spinner.stopAnimating()
                                self.spinner.hidden = true
                            }

                        })

                } else {
                    self.spinner.stopAnimating()
                    print(error)
                }
            }

Old code
let searchPictures : [PFObject] = Search.sharedInstance.selectedPerson["searchPictures"] as! [PFObject]
        for searchPicture : PFObject in searchPictures {

            searchPicture.fetchIfNeededInBackgroundWithBlock({ (Object, error) -> Void in
                print (error)
            if error == nil {
                let file : PFFile = searchPicture["searchPictureImage"] as! PFFile

                file.getDataInBackgroundWithBlock({ (data, error) -> Void in

                    if error == nil {
                        if let image = UIImage(data: data!) {
                            Search.sharedInstance.missingPersonPhotosArray.append(image)

                            if Search.sharedInstance.missingPersonPhotosArray.count > 0 {
                                // Add 1st image to missing person page
                                dispatch_async(dispatch_get_main_queue()) {
                                    self.missingPersonMainImage.image = Search.sharedInstance.missingPersonPhotosArray.first
                                    self.spinner.stopAnimating()
                                    self.spinner.hidden = true
                                }
                            }
                        } else {
                            self.spinner.stopAnimating()
                            self.spinner.hidden = true
                        }
                    } else {
                        self.spinner.stopAnimating()
                        self.spinner.hidden = true
                    }

                })

            } else {
                self.spinner.stopAnimating()
            }

            })

running a query for every object is super inefficient. if you are going to manually grab them, then at least do one query and whereKey:ContainedIn and give it an array of searchPictures


Usage with CDS instance

"Microsoft Teams integration is not supported on Common Data Service only environment without model-driven apps."
Does this mean MS Teams does support CDS environments that have model-driven apps? What kind of model driven apps are required?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8882c54d-281c-31fa-be77-e05f74029c91
Version Independent ID: 67733d0b-0185-f50c-e485-0322a635a8e9
Content: Integrate model-driven apps in Dynamics 365 with Microsoft Teams
Content Source: ce/teams-integration/teams-integration.md
Service: crm-online
GitHub Login: @mduelae
Microsoft Alias: mkaur

@canhacungvui the guidance have been updated.
Microsoft Teams integration is not supported on Common Data Service environment.
Thanks,
Mints


Enhancement: Update repository

Summary

We want Ruff
We want sphinx
We want to use our custom starlite sphinx theme
Remove meta files in favor of community health files

Basic Example
No response
Drawbacks and Impact
No response
Unresolved questions
No response

Remove meta files in favor of community health files

I removed the CoC file - I think that''s it? If you want to make any changes, just PR.


Support streaming compguesswhat dataset

Support streaming compguesswhat dataset.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


AndroidX conversion + Dialog support

Changes

converted the project to android x
made extended views extend app compat views for proper view styling on all versions
added asPopup to the builder => this mode supports dialogs as well now and will simply use an android PopupWindow

Info
I added support for dialogs not by using the WindowManager (which I saw you already tried in the open issues) but by simply using a PopupWindow which will retrieve the window token from the view itself and this seems to work fine as long as you adjust the top offset to remove the status bar height...
For dialogs, you must find the correct window position and adjust position accordingly as well, which I implemented as well now.
So far, this looks quite good now, but I do corrections after the calculations instead of before, just because it's easier for me now... This could be improved though...
And there seems to be a very small offset in dialogs - I don't know to fix them yet, but it works at least and is accurate enough...

why do you need android x? that will restrict everything to API 28

It restricts the target API only, you still can build with lower APIs if you want to without problems...
I see a lot of big libraries already only providing new features for android x and I personally use it in all my projects already, so this is my personal solution I'm just sharing with you...
If you don't want android x you can take the popup idea out of it and merge this one only into your branch, if you prefer this, should take you about a minute, my changes are quite small, they only show a solution that works with dialogs as well...
Imho, there is no reason to not already migrate to android x, people using app compat can still use the 1.3.15 version as long as they want...

actually you're right.
but can you also do the conversion in the demo app to androidx and update to gradle 3.2.1 and 4.10.1 wrapper?
I'd like to see the build not failing

Saw a lot of open pull requests so I did not do this. But if you like the PR I will do this tomorrow as well.

Migration finished and also fixed all travis issues.
PS: is there a gradle task that automatically corrects the format so that the checkstyle tasks succeed? I could not find one but I know that this is possible because I've seen this already, but I'm not familiar with checkstyle so I can't add this (if it is not yet existing)


Scroll lock on API docs in Safari

After browsing the API docs for a few days using Safari, I noticed a reocurring pattern: After going back in browser history, the scrolling is often locked and I need to reload the page before I can scroll anywhere.
Haven't tried it with another browser though. Any ideas?

Seems to me that I've seen that in the past (probably with safari on MacOS Yosemite).  But I haven't been able to recreate it right now when I'm trying it in Opera on MacOS.

Safari on El Capitan also has this problem

It also happens on Chrome, seems to be an issue with WebKit. Not that the issue is WebKit, but we are doing something wrong... I don't know if it's some JS or CSS fault.

Hmm.  I do very little work on web pages, but sometimes I have used iCab on MacOS when I am debugging web pages.  It has a little "smiley face" checker, which shows a smile if the page is good and a frown if iCab notes some mistakes on the page.  If you click on the frowning-face iCab will tell you what it thinks is wrong with the page.  There are times when this has been very useful to me.  However I'm not sure that the author (Alexander Clauss) has been updating it for the latest in CSS, etc.  iCab is at:
http://www.icab.de/
and while it does show a few warnings on the web pages for the Crystal API's, they don't seem to be all that bad.  Certainly nothing that seems tied to scrolling.  If you click on some "[View source]" page (which opens a page on github), then iCab lists many more warnings for those pages.  But those open in a separate window or tab, so I don't see how any errors there would cause scroll-lock errors back on the API-doc pages.

I wonder if this is a problem with "swiping" or just scrolling down in general. When this happens, can you still click in the page and use the arrow keys to scroll? If so then this would seem like a problem with the browser not recognizing scrolling swipe gestures.

Is this still an issue? It's not reproducible with macOS Mojave.

I don’t know. I don’t own a working Mac these days.

Seems to be fixed so far. Closing for now. Thanks @Maroo-b and @paddor.


Java: Allow explicit zero multiplication in java/evaluation-to-constant.

Fixes https://github.com/Semmle/ql/issues/2440.
Looking over the lgtm.com results for this, they generally appear intentional, which makes them FPs.

LGTM, modulo release note.


Seeding to Heroku Fails

very inexperienced at rails.
after deploying looking to see with data. looks like this is the issue
https://stackoverflow.com/questions/23437830/undefined-method-attr-accessible
is there a work around?
instance here: https://adopt-a-vb.herokuapp.com/
➜  vb_storm_data git:(master) ✗ heroku run bundle exec rake db:seed
Running bundle exec rake db:seed on ⬢ adopt-a-vb... up, run.8957 (Hobby)
[SKYLIGHT] [0.10.6] authentication token required; disabling Skylight agent
  ActiveRecord::SchemaMigration Load (1.0ms)  SELECT "schema_migrations".* FROM "schema_migrations"
rake aborted!
NoMethodError: undefined method `attr_accessible' for #<Class:0x00000006917ac0>
Did you mean?  attr_accessor
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-<IP_ADDRESS>/lib/active_record/dynamic_matchers.rb:26:in `method_missing'
/app/db/seeds.rb:6:in `<class:Thing>'
/app/db/seeds.rb:5:in `<top (required)>'
/app/vendor/bundle/ruby/2.3.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:268:in `load'
/app/vendor/bundle/ruby/2.3.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:268:in `block in load'
/app/vendor/bundle/ruby/2.3.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:240:in `load_dependency'
/app/vendor/bundle/ruby/2.3.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:268:in `load'
/app/vendor/bundle/ruby/2.3.0/gems/railties-<IP_ADDRESS>/lib/rails/engine.rb:547:in `load_seed'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-<IP_ADDRESS>/lib/active_record/tasks/database_tasks.rb:251:in `load_seed'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-<IP_ADDRESS>/lib/active_record/railties/databases.rake:183:in `block (2 levels) in <top (required)>'
/app/vendor/bundle/ruby/2.3.0/gems/rake-11.3.0/exe/rake:27:in `<top (required)>'
/app/vendor/bundle/ruby/2.3.0/gems/bundler-1.15.2/lib/bundler/cli/exec.rb:74:in `load'
/app/vendor/bundle/ruby/2.3.0/gems/bundler-1.15.2/lib/bundler/cli/exec.rb:74:in `kernel_load'
/app/vendor/bundle/ruby/2.3.0/gems/bundler-1.15.2/lib/bundler/cli/exec.rb:27:in `run'
/app/vendor/bundle/ruby/2.3.0/gems/bundler-1.15.2/lib/bundler/cli.rb:360:in `exec'
/app/vendor/bundle/ruby/2.3.0/gems/bundler-1.15.2/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
/app/vendor/bundle/ruby/2.3.0/gems/bundler-1.15.2/lib/bundler/vendor/thor/lib/thor/invocation.rb:126:in `invoke_command'
/app/vendor/bundle/ruby/2.3.0/gems/bundler-1.15.2/lib/bundler/vendor/thor/lib/thor.rb:369:in `dispatch'
/app/vendor/bundle/ruby/2.3.0/gems/bundler-1.15.2/lib/bundler/cli.rb:20:in `dispatch'
/app/vendor/bundle/ruby/2.3.0/gems/bundler-1.15.2/lib/bundler/vendor/thor/lib/thor/base.rb:444:in `start'
/app/vendor/bundle/ruby/2.3.0/gems/bundler-1.15.2/lib/bundler/cli.rb:10:in `start'
/app/vendor/bundle/ruby/2.3.0/gems/bundler-1.15.2/exe/bundle:30:in `block in <top (required)>'
/app/vendor/bundle/ruby/2.3.0/gems/bundler-1.15.2/lib/bundler/friendly_errors.rb:121:in `with_friendly_errors'
/app/vendor/bundle/ruby/2.3.0/gems/bundler-1.15.2/exe/bundle:22:in `<top (required)>'
/app/bin/bundle:3:in `load'
/app/bin/bundle:3:in `<main>'
Tasks: TOP => db:seed
(See full trace by running task with --trace)

human error.
when i ran
git pull upstream master -s recursive -X ours
it had something inline and uncommited that left the old attr prerails 4 in the seed file.


Quality Model weights

The current version is showing the assessment in the nodes with weigths.
This view should show:

[x] non weighted values in nodes, the node should show the current assessment
[x] the weights shown in the arrows should be represented as percentage

Now in Quality Model view, all nodes are shown without weight applied (current assessment). The edges between metric and factor have the corresponding percentage represented on it, and the edges between factors and strategic indicators have no label because the calculation used in this case is a normal average.


Build the docker image for linux/arm/v6

Home assistant wants to use this project to improve the camera experience by offering WebRTC for any camera stream instead to high latency HLS stream type.
For this we need to build this project also for linux/arm/v6
HA PR: https://github.com/home-assistant/core/pull/124410

Thanks. I don't remember why I didn't do it at the start. Maybe I wasn't sure if it was going to work well on such an old architecture.

Looks like we have a problem
https://github.com/AlexxIT/go2rtc/actions/runs/10957913078/job/30427035992
There is no ngrok for arm/v6.
I don't mind skipping it for this build, but I don't know the best way to write a Docker file.

https://github.com/AlexxIT/go2rtc/releases/tag/v1.9.5


Update typo

You have made small typo in package.

 That's what happens if you duplicate code bases, because your internal used version of it has some minor adaptions which are not needed by everyone :) Thanks for your help!


Facebook identity provider requires additional settings

I found the instructions provided on this page to be somewhat incomplete. After following them I got the following error message when I tried to log in with a Facebook account:

Feature Unavailable: Facebook login is currently unavailable for this app since we are updating additional details for this app. Please Try again

I had to complete two additional steps in my Facebook application before it would work:

Complete the business verification process under App settings->Basic.
Under App Review->Permissions and Features I had to enable advanced access for the 'public_profile' permission (and complete a data protection form)

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: aeb73901-3320-4d53-767c-bfd03b3b0354
Version Independent ID: 404e18f1-d6da-5654-3e68-8e888e11433e
Content: Set up sign-up and sign-in with a Facebook account - Azure AD B2C
Content Source: articles/active-directory-b2c/identity-provider-facebook.md
Service: active-directory
Sub-service: b2c
GitHub Login: @garrodonnell
Microsoft Alias: godonnell

@RichardDavies
Thanks for your feedback! We will investigate and update as appropriate.

@RichardDavies
Thank you for bringing this to our attention. I've assigned this issue to the content author @garrodonnell, who will investigate and update as appropriate.

@garrodonnell
Please review it and update as appropriate.

@RichardDavies did you have to complete app review just for FB Login? I'm just trying to use the pure Login support and pull public_profile, but I'm receiving this error when logging in:
Invalid Scopes: email. This message is only shown to developers.
But I don't have email even setup:

I'm wondering if this a result that B2C is asking explicitly for scope of email. I'm not sure why it's doing that as I don't have that property set.
onmicrosoft.com%2foauth2%2fauthresp&response_type=code&scope=email&prompt=login&state=StateProperties%

@aherrick Yes, I had to complete app review just for Facebook login. As I mentioned earlier, I also had to enable advanced access to public_profile permission shown in your screenshot. For scope, I used scope=opened when initiating the login at /authorize endpoint.

Hi @RichardDavies, thanks for providing this feedback. I'll look into this and update the docs.


Include script to create Pegnet chains

Currently if the Pegnet daemon is started and the OPR chain(s) does not exist a error is occurs and the daemon exits:
FATA[0032] An error in OPR was encountered               caller="pegnet/opr/grading.go:147" error="Missing Chain Head"

For those testing on a fresh local Factom network it would be helpful if the Pegnet project either included a script in initialization to create the chains, or just automatically created them. Otherwise the user has to manually create them via CLI or other means.

The reference branch & PR for this issue is https://github.com/pegnet/pegnet/pull/134

Isn't go run initialization/main.go what you are looking for?

Thanks, this solved my issue @PaulBernier


[Performance] Improve horqrux sampling

Increase speed of horqrux sampling:
New:
In [3]: %timeit sample(RX(20,'theta'),backend='horqrux')
45.3 ms ± 187 μs per loop (mean ± std. dev. of 7 runs, 10 loops each)
Old:
In [2]: %timeit sample(RX(20,'theta'),backend='horqrux')
4.28 s ± 25.5 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

@atiyo do you see a nice way to do this even better?

Looks good to me.
Only thing that comes to mind is trying to optimise that dictionary comprehension into something Jax native. e.g. vmapping that as well
But maybe that's a bottleneck at all, in which case it looks good as is to me.


Initial Luigi after team code review

:+1: looks good. I'll merge this in so we can iterate on it.


⚠ ClamAV has degraded performance

In 03f4322, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 78 ms

Resolved: ClamAV performance has improved in d0e511b.


Fix typo in README

Thanks!
Just to let you know this Omnipay gateway is now superseded by the official PayPal gateway - https://github.com/thephpleague/omnipay-paypal
When we've started the library they didn't have support for PayPal REST API, but now they do.


Add edit page button in reviews dashboard.

A quick addition of an "Edit Page" button for the user to be able to access the admin edit of a page in review from the review dashboard.
Very handy and it has been raised a few times by some users 😄

Thanks @patillacode!


Add pypi and conda badges.

i18nice recipe has been accepted in the conda-forge conda channel. :tada:
This pull request adds pypi and conda badges to the readme.
Thanks for considering it.
Closes #31.

Thanks for your efforts in making this package available for more users.
The PR itself is fine, but the linked anaconda.org page shows blank description, is that ok?

I didn't add the optional field "description" in the recipe... my bad.
Some packages have a detailed description, some other just a copy of the summary, some nothing at all.
Would it be ok if I add a basic description in the next release?

Is it possible to sync the description with the README (like on PyPI)?

mmmhh ... I can only find text in the yaml field "description", not a link to a file. So, unless I copy the whole readme in the description field (which I don't think is a good idea) I guess this wasn't planned...

I see. Then you can put something like "See the repository for detailed description" there.

@Krutyi-4el I have updated i18nice on conda-forge and added a description as previously discussed. I hope this was what you had in mind.

@cmarmo nice, thank you!


Refactoring examples into working code

Currently, the examples only show the commands needed to use uvgRTP. The examples themselves don't work when run and I think it would be a better demonstration if they could actually be run and they would do something. This would also enable their usage in automated testing.

I've started working on this issue. You can follow the progress here: https://github.com/ultravideo/uvgRTP/tree/example_improvements

I have to say that I disagree with this change wholeheartedly. The point of the example was exactly that, showcasing the API, not to provide full-fledged, end-to-end example applications.
The idea I had was to provide more like a collection of very simple, read-only like example codes that users of uvgRTP could then incorporate into their own code. Now there is a lot of "unnecessary" churn to provide more application-type examples which I think is the wrong direction from end-user perspective. From a CI perspective it may be warranted by at least I did not enjoy reading some of them because now there's a lot of "unnecessary boilerplate".
Now the example codes look more like LIVE555's example code which I think are not that good either.

@altonen Which part of the example modification do you disagree? I've tried to do the following for the code:

Define values at the beginning. This is what they taught me in coding class and I think it makes the code more readable and easy to change. With the improvements, user does not have to check the API to figure out what each number does.
Fix bugs. For example one cannot use RTCP if the RTP uses consecutive ports. There were also memory leaks. I think we want to show the users how to avoid those in our examples.
Check return values. Isn't user supposed to check the return values? Shouldn't we teach them to check them?
Make them functional. If I understood, this is the controversial part? There was some talk about adding command line parsing to examples, but I agree that this might make the examples too complicated (on the other hand, uvgRTP having a CLI might not be a bad idea). What I did was just remove infinite loops and make the examples end at some point. This did not take many code lines. There was one situation where there was just generic wait and as we discussed with testing, this does not result in a constant rate stream or any stream that makes sense in reality. I wanted to preserve the code logic so I fixed it to send at constant rate. These could maybe be implemented to send as fast as possibly, but I'm not a fan of bad code in examples.

The point about LIVE555 confuses me. Their examples don't particularly look like functional code since they select a random address to stream to. Also, I find the LIVE555 confusing because of their API, not so much because of the examples.
The branch is not yet near finish. Your comment about comprehension is something I am thinking as well and maybe something more could be done to highlight the API functions. My plan for example improvements is to merge them at the same time with C++ API and use it in the examples for simpler code (no memory management).

If I'm honest, I think defining the values at the beginning doesn't improve clarity that much but that's just a matter of taste. I'm not sure which bugs you're referring to but obviously those should be fixed. Checking return values is good practice, absolutely, but I intentionally left them out to make the code more readable. The whole API is Doxygen-documented, including return values and possible errors conditions, and it's easily available here on Github.
Obviously I don't know the details of internal discussions so my comment may not make sense from that point of view but let us consider, for example, srtp_user.cc. When I wrote that example code, my point was to show the difference between user-managed keys and ZRTP-managed keys, i.e., which lines are different (very few). Now, from my point of view, there is a lot of unnecessary code, if the point of the code is to highlight the differences. I think showing how to stream at constant 30 FPS is good for sending.cc but for any other example it doesn't add much value but makes the code just more verbose.
I'm not saying this is necessarily a bad direction but the direction I chose was done intentionally, and I'm saddened to see it change. I hope I'm incorrect and that this new way of showing how to use uvgRTP is better for the end-user.

You are looking at a work in progress, details like having too many code lines in srtp_user example are easy to fix and would have likely been fixed without this conversation. From my point of view, I did realize your intention and wanted to keep it as much as possible while also making the example such that user could also press the run button without a crash. I have seen people at least try to build the examples and using them as a basis for their code. Taking that into consideration, I think a better starting point would be something functional.

Merged the branch and also added a small tutorial. Also moved the examples to root, since they are what interest new users the most.


Add LeetCode 905. Sort Array By Parity

Problem Link

Hi!
I'd like to do that!

Please assign this issue to me!

Hey Tahanima, would like to solve this problem in java, if you could assign me.
Thanks :)


feat(remix-dev): support root route as a folder

Closes: #7033

[x] Docs
[x] Tests

Testing Strategy: added new integration test

I rebased.


Escape parameter choice pipes

The parameters' choices are separated by pipes | which markdown is interpreting as column end tags.
This change escapes those pipes to correctly format the parameter choices and description as part of the table.

Thank you!


Merge markers in documentation

Hey,
I've spotted a few merge markers in some documentation examples :

https://github.com/zurb/foundation/blob/master/doc/includes/dropdown_buttons/examples_dropdown_button_basic.html
https://github.com/zurb/foundation/blob/master/doc/includes/dropdown_buttons/examples_dropdown_button_intro.html

I'm probably going to submit a PR soon

All good now, thanks!


Feature Request: Implement derive_vars_crit()

Feature Idea
Implement derive_vars_crit() which derives the variables CRITy, CRITyFL, and CRITyFLN (for a specific value of y). The derivation of these variables is very simple. However, there are some requirements which many programmers and specs authors are not aware of. For example, that the derivation must rely on variables from the current records only and the relation of the values of CRITy and CRITyFL (e.g., if CRITyFL is set to "Y" or "N", CRITy must be populated for all records with the same value).
The function should cover all use cases of the CRIT variables. I.e., if a CRIT variable can not be derived with the function, the derivation is not ADaM compliant.
Relevant Input
No response
Relevant Output
No response
Reproducible Example/Pseudo Code
adxx <- adxx %>% derive_vars_crit(
  crit_nr = 1,
  condition = AVAL > 50,
  description = paste(PARAM, "> 50"),   # CRITy is set to the specified value
  values_yn = FALSE,                    # should values "Y", "N", and NA be used?
  create_numeric_flag = TRUE            # should CRITyFLN be created?
)

I think this looks useful!
Do we want to use _flag at the end to keep in line with other flag related functions?
Also, we have the hy's law vignette which discusses Crit flags - maybe opportunity to update with this function?
https://pharmaverse.github.io/admiral/articles/hys_law.html
What do you think @pharmaverse/admiral and @pharmaverse/admiral_comm?  Any takers?   I think this could be a fun one to implement for those eager to do some function building for admiral!!

Do we want to use _flag at the end to keep in line with other flag related functions?

Yes, seems reasonable to me.

Looks reasonable to me as well, thanks for the suggestion @bundfussr.
Just for general awareness, in admiralophtha we have derive_var_bcvacrtixfl() - see here for reference. But to be honest I wouldn't mind absorbing its functionality inside a new {admiral} function and then either superseding it or turning it into a wrapper for the {admiral} function.
On another note, could we couple this effort with a similar function for AVALCATx?

On another note, could we couple this effort with a similar function for AVALCATx?

@manciniedoardo , what do you have in mind? Should it derive AVALCATx only or also similar variables like CHGCATy or AGEGRy? What is expected as input?

On another note, could we couple this effort with a similar function for AVALCATx?

@manciniedoardo , what do you have in mind? Should it derive AVALCATx only or also similar variables like CHGCATy or AGEGRy? What is expected as input?

Actually it was just a passing thought, I haven't looked in the IG yet to see if AVALCAT/CHGCAT have as stringent guidelines. My thought was that if yes, maybe we could also develop derive_var_avalcat() and similar.

AVALCATy has a restriction that it can only be derived using values of AVAL or AVALC.  CHGCATy is under a similar restriction- it can only be derived using values of CHG.  AGEGRy should only be derived based on values of age, but which age variable is used is up to the producer, since multiple age variables are possible in ADSL.

AVALCATy has a restriction that it can only be derived using values of AVAL or AVALC. CHGCATy is under a similar restriction- it can only be derived using values of CHG. AGEGRy should only be derived based on values of age, but which age variable is used is up to the producer, since multiple age variables are possible in ADSL.

Thanks @nbrucken17 - if that is all maybe this is not a good idea, as you may just as well derive them inside a mutate statement!

While updating the Roche templates I noticed that the numeric flag created by derive_vars_crit_flag() is of type double. Should it be integer?
@bms63 , @manciniedoardo , @millerg23 , what do you think?

While updating the Roche templates I noticed that the numeric flag created by derive_vars_crit_flag() is of type double. Should it be integer?
@bms63 , @manciniedoardo , @millerg23 , what do you think?

I would have thought it should be type integer.
https://www.cdisc.org/kb/examples/adam-basic-data-structure-bds-using-crit-80283859

I think it should be integer.  This is nice when comparing to a production dataset done in SAS
The derive_var_obs_number does the same thing actually.  I always have to do an as.integer so compare is clean - not a big deal - but maybe another update?


"find -L . -type l" doesn't find dangling symlinks

Other find implementations match dangling symlinks with this command, because after following them they're still symlinks, but toybox find doesn't.

Fixed by 0b2cfcb.


merge from arlac77/npm-package-template-esm-only

package.json

chore(package<EMAIL_ADDRESS>chore(scripts): cover@#overwrite c8 -x 'tests/**/*.mjs' --temp-directory build/tmp ava && c8 report -r lcov -o build/coverage --temp-directory build/tmp

:tada: This PR is included in version 4.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fix minor typos

I've been reading through a lot of Beam code, and have been collecting typos and "easy" mistakes.  It seems like a good moment to submit them.
None of these are urgent.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

R: @kennknowles Can you take a look?

I think Kenn is away for a few days. Not sure who would be a good person to take a look instead, maybe @pabloem?

Run Java PreCommit

Run Python_PVR_Flink PreCommit

Run Java PreCommit

Heh -- one of the typo fixes triggered an error-prone rule with assertEquals and the order of expected/actual.  Fixed: that should be the only code change in the PR and it's trivial.
R: @pabloem Can you take a look?

Thanks Ryan!