bestvideo[height<=1080][vcodec=h264][ext=mp4] download 720p when 1080p is available

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm reporting a bug unrelated to a specific site
[X] I've verified that I'm running yt-dlp version 2023.07.06 (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Provide a description that is worded well enough to be understood
I'm trying to download a video in max 1080 res h.264 vcodec. When I list the formats:
tzvc@mba ~/dev/% yt-dlp -vU --list-formats "https://www.youtube.com/watch?v=LQ5wYYzvOp0"
[debug] Command-line config: ['-vU', '--list-formats', 'https://www.youtube.com/watch?v=LQ5wYYzvOp0']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8 (No ANSI), screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>[392389b7d] (zip)
[debug] Python 3.10.10 (CPython arm64 64bit) - macOS-13.3-arm64-arm-64bit (OpenSSL 1.1.1s  1 Nov 2022)
[debug] exe versions: ffmpeg 6.0 (setts), ffprobe 6.0
[debug] Optional libraries: certifi-2023.07.22, no_Cryptodome-None, sqlite3-2.6.0
[debug] Proxy map: {}
[debug] Loaded 1786 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Available version<EMAIL_ADDRESS>Current version<EMAIL_ADDRESS>Current Build Hash: 91cad9f121c1f6f0a81b747415c46ecba0ff331ed38cc6433040b4ac7b6e15ca
[debug] Downloading _update_spec from https://github.com/yt-dlp/yt-dlp/releases/latest/download/_update_spec
Updating to<EMAIL_ADDRESS>...
ERROR: Unable to write to /usr/local/bin/yt-dlp; Try running as administrator
[youtube] Extracting URL: https://www.youtube.com/watch?v=LQ5wYYzvOp0
[youtube] LQ5wYYzvOp0: Downloading webpage
WARNING: [youtube] unable to extract initial player response; please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
[youtube] LQ5wYYzvOp0: Downloading android player API JSON
[youtube] LQ5wYYzvOp0: Downloading iframe API JS
[youtube] LQ5wYYzvOp0: Downloading player 16f9263d
[youtube] LQ5wYYzvOp0: Downloading web player API JSON
WARNING: [youtube] unable to extract yt initial data; please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
[youtube] LQ5wYYzvOp0: Downloading initial data API JSON
[debug] Sort order given by extractor: quality, res, fps, hdr:12, source, vcodec:vp9.2, channels, acodec, lang, proto
[debug] Formats sorted by: hasvid, ie_pref, quality, res, fps, hdr:12(7), source, vcodec:vp9.2(10), channels, acodec, lang, proto, filesize, fs_approx, tbr, vbr, abr, asr, vext, aext, hasaud, id
[info] Available formats for LQ5wYYzvOp0:
ID  EXT   RESOLUTION FPS CH │   FILESIZE   TBR PROTO │ VCODEC        VBR ACODEC      ABR ASR MORE INFO
────────────────────────────────────────────────────────────────────────────────────────────────────────────────
sb2 mhtml 48x27        0    │                  mhtml │ images                                storyboard
sb1 mhtml 80x45        0    │                  mhtml │ images                                storyboard
sb0 mhtml 160x90       0    │                  mhtml │ images                                storyboard
599 m4a   audio only      2 │    4.03MiB   31k dash  │ audio only        mp4a.40.5   31k 22k ultralow, m4a_dash
600 webm  audio only      2 │    4.41MiB   34k dash  │ audio only        opus        34k 48k ultralow, webm_dash
139 m4a   audio only      2 │    6.38MiB   49k dash  │ audio only        mp4a.40.5   49k 22k low, m4a_dash
249 webm  audio only      2 │    6.44MiB   49k dash  │ audio only        opus        49k 48k low, webm_dash
250 webm  audio only      2 │    7.68MiB   59k dash  │ audio only        opus        59k 48k low, webm_dash
140 m4a   audio only      2 │   16.93MiB  129k dash  │ audio only        mp4a.40.2  129k 44k medium, m4a_dash
251 webm  audio only      2 │   15.30MiB  117k dash  │ audio only        opus       117k 48k medium, webm_dash
17  3gp   176x144      8  1 │   10.21MiB   78k https │ mp4v.20.3     78k mp4a.40.2    0k 22k 144p
597 mp4   256x144     15    │    4.20MiB   32k dash  │ avc1.4d400b   32k video only          144p, mp4_dash
598 webm  256x144     15    │    3.10MiB   24k dash  │ vp9           24k video only          144p, webm_dash
160 mp4   256x144     30    │    5.72MiB   44k dash  │ avc1.4d400c   44k video only          144p, mp4_dash
278 webm  256x144     30    │    8.73MiB   67k dash  │ vp9           67k video only          144p, webm_dash
133 mp4   426x240     30    │   11.43MiB   87k dash  │ avc1.4d4015   87k video only          240p, mp4_dash
242 webm  426x240     30    │   12.86MiB   98k dash  │ vp9           98k video only          240p, webm_dash
134 mp4   640x360     30    │   20.69MiB  158k dash  │ avc1.4d401e  158k video only          360p, mp4_dash
18  mp4   640x360     30  2 │   56.64MiB  433k https │ avc1.42001E  433k mp4a.40.2    0k 44k 360p
243 webm  640x360     30    │   27.71MiB  212k dash  │ vp9          212k video only          360p, webm_dash
135 mp4   854x480     30    │   33.04MiB  253k dash  │ avc1.4d401f  253k video only          480p, mp4_dash
244 webm  854x480     30    │   40.94MiB  313k dash  │ vp9          313k video only          480p, webm_dash
22  mp4   1280x720    30  2 │ ~ 73.84MiB  551k https │ avc1.64001F  551k mp4a.40.2    0k 44k 720p
136 mp4   1280x720    30    │   55.24MiB  422k dash  │ avc1.4d401f  422k video only          720p, mp4_dash
247 webm  1280x720    30    │   68.12MiB  521k dash  │ vp9          521k video only          720p, webm_dash
137 mp4   1920x1080   30    │  178.22MiB 1363k dash  │ avc1.640028 1363k video only          1080p, mp4_dash
248 webm  1920x1080   30    │  124.18MiB  950k dash  │ vp9          950k video only          1080p, webm_dash

But when I then run my command:
yt-dlp -vU -f "bestvideo[height<=1080][vcodec=h264][ext=mp4]+bestaudio[ext=m4a]/best[height<=1080][ext=mp4]" "https://www.youtube.com/watch?v=LQ5wYYzvOp0"

the wrong format is selected (22 instead of 137)
tzvc@mba ~/dev/% yt-dlp -vU -f "bestvideo[height<=1080][vcodec=h264][ext=mp4]+bestaudio[ext=m4a]/best[height<=1080][ext=mp4]" "https://www.youtube.com/watch?v=LQ5wYYzvOp0"
[debug] Command-line config: ['-vU', '-f', 'bestvideo[height<=1080][vcodec=h264][ext=mp4]+bestaudio[ext=m4a]/best[height<=1080][ext=mp4]', 'https://www.youtube.com/watch?v=LQ5wYYzvOp0']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8 (No ANSI), screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>[392389b7d] (zip)
[debug] Python 3.10.10 (CPython arm64 64bit) - macOS-13.3-arm64-arm-64bit (OpenSSL 1.1.1s  1 Nov 2022)
[debug] exe versions: ffmpeg 6.0 (setts), ffprobe 6.0
[debug] Optional libraries: certifi-2023.07.22, no_Cryptodome-None, sqlite3-2.6.0
[debug] Proxy map: {}
[debug] Loaded 1786 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Available version<EMAIL_ADDRESS>Current version<EMAIL_ADDRESS>Current Build Hash: 91cad9f121c1f6f0a81b747415c46ecba0ff331ed38cc6433040b4ac7b6e15ca
[debug] Downloading _update_spec from https://github.com/yt-dlp/yt-dlp/releases/latest/download/_update_spec
Updating to<EMAIL_ADDRESS>...
ERROR: Unable to write to /usr/local/bin/yt-dlp; Try running as administrator
[youtube] Extracting URL: https://www.youtube.com/watch?v=LQ5wYYzvOp0
[youtube] LQ5wYYzvOp0: Downloading webpage
WARNING: [youtube] unable to extract initial player response; please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
[youtube] LQ5wYYzvOp0: Downloading android player API JSON
[youtube] LQ5wYYzvOp0: Downloading iframe API JS
[youtube] LQ5wYYzvOp0: Downloading player 0a835141
[youtube] LQ5wYYzvOp0: Downloading web player API JSON
WARNING: [youtube] unable to extract yt initial data; please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
[youtube] LQ5wYYzvOp0: Downloading initial data API JSON
[debug] Sort order given by extractor: quality, res, fps, hdr:12, source, vcodec:vp9.2, channels, acodec, lang, proto
[debug] Formats sorted by: hasvid, ie_pref, quality, res, fps, hdr:12(7), source, vcodec:vp9.2(10), channels, acodec, lang, proto, filesize, fs_approx, tbr, vbr, abr, asr, vext, aext, hasaud, id
[info] LQ5wYYzvOp0: Downloading 1 format(s): 22
[debug] Invoking http downloader on "https://rr4---sn-cv0tb0xn-jqbl.googlevideo.com/videoplayback?expire=1693497263&ei=T2PwZOrCDrGixN8P16qfuAE&ip=2001%3A861%3A3d44%3Ab4b0%3Acc14%3Af8ba%3A3870%3A9c5f&id=o-ALUV3FmfbAlufMltqoWOU3i9u5CLvjOHb8GUfXsv1YFg&itag=22&source=youtube&requiressl=yes&mh=h7&mm=31%2C29&mn=sn-cv0tb0xn-jqbl%2Csn-25ge7nzz&ms=au%2Crdu&mv=m&mvi=4&pl=49&initcwndbps=1922500&spc=UWF9f2fLh9OerdsS77TNWUXr5zi6XVdt44b06W1XtA&vprv=1&svpuc=1&mime=video%2Fmp4&cnr=14&ratebypass=yes&dur=1096.794&lmt=1693024286595587&mt=1693475347&fvip=3&fexp=24007246&c=ANDROID&txp=4432434&sparams=expire%2Cei%2Cip%2Cid%2Citag%2Csource%2Crequiressl%2Cspc%2Cvprv%2Csvpuc%2Cmime%2Ccnr%2Cratebypass%2Cdur%2Clmt&sig=AOq0QJ8wRQIgF-YlkmVzka94KgOlRM0dy5_ig5FvHruMfG1EGSuTeYgCIQDuJh20IB3sqFWyZwWRxmOeqq5uP9f5F48TlmPg57QhvA%3D%3D&lsparams=mh%2Cmm%2Cmn%2Cms%2Cmv%2Cmvi%2Cpl%2Cinitcwndbps&lsig=AG3C_xAwRQIgF7GhhNXv4vQ2qgWUe17TzH8SFnsyJDS2XvKYzc_dLEQCIQDHi1vj-8fhWeu92K7vZOT04gDApg9O9Y2yhQRx1yO2Qg%3D%3D"

Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[X] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
[debug] Command-line config: ['-vU', '-f', 'bestvideo[height<=1080][vcodec=h264][ext=mp4]+bestaudio[ext=m4a]/best[height<=1080][ext=mp4]', 'https://www.youtube.com/watch?v=LQ5wYYzvOp0']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8 (No ANSI), screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>[392389b7d] (zip)
[debug] Python 3.10.10 (CPython arm64 64bit) - macOS-13.3-arm64-arm-64bit (OpenSSL 1.1.1s  1 Nov 2022)
[debug] exe versions: ffmpeg 6.0 (setts), ffprobe 6.0
[debug] Optional libraries: certifi-2023.07.22, no_Cryptodome-None, sqlite3-2.6.0
[debug] Proxy map: {}
[debug] Loaded 1786 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Available version<EMAIL_ADDRESS>Current version<EMAIL_ADDRESS>Current Build Hash: 91cad9f121c1f6f0a81b747415c46ecba0ff331ed38cc6433040b4ac7b6e15ca
[debug] Downloading _update_spec from https://github.com/yt-dlp/yt-dlp/releases/latest/download/_update_spec
Updating to<EMAIL_ADDRESS>...
ERROR: Unable to write to /usr/local/bin/yt-dlp; Try running as administrator
[youtube] Extracting URL: https://www.youtube.com/watch?v=LQ5wYYzvOp0
[youtube] LQ5wYYzvOp0: Downloading webpage
WARNING: [youtube] unable to extract initial player response; please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
[youtube] LQ5wYYzvOp0: Downloading android player API JSON
[youtube] LQ5wYYzvOp0: Downloading iframe API JS
[youtube] LQ5wYYzvOp0: Downloading player 0a835141
[youtube] LQ5wYYzvOp0: Downloading web player API JSON
WARNING: [youtube] unable to extract yt initial data; please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
[youtube] LQ5wYYzvOp0: Downloading initial data API JSON
[debug] Sort order given by extractor: quality, res, fps, hdr:12, source, vcodec:vp9.2, channels, acodec, lang, proto
[debug] Formats sorted by: hasvid, ie_pref, quality, res, fps, hdr:12(7), source, vcodec:vp9.2(10), channels, acodec, lang, proto, filesize, fs_approx, tbr, vbr, abr, asr, vext, aext, hasaud, id
[info] LQ5wYYzvOp0: Downloading 1 format(s): 22
[debug] Invoking http downloader on "https://rr4---sn-cv0tb0xn-jqbl.googlevideo.com/videoplayback?expire=1693497263&ei=T2PwZOrCDrGixN8P16qfuAE&ip=2001%3A861%3A3d44%3Ab4b0%3Acc14%3Af8ba%3A3870%3A9c5f&id=o-ALUV3FmfbAlufMltqoWOU3i9u5CLvjOHb8GUfXsv1YFg&itag=22&source=youtube&requiressl=yes&mh=h7&mm=31%2C29&mn=sn-cv0tb0xn-jqbl%2Csn-25ge7nzz&ms=au%2Crdu&mv=m&mvi=4&pl=49&initcwndbps=1922500&spc=UWF9f2fLh9OerdsS77TNWUXr5zi6XVdt44b06W1XtA&vprv=1&svpuc=1&mime=video%2Fmp4&cnr=14&ratebypass=yes&dur=1096.794&lmt=1693024286595587&mt=1693475347&fvip=3&fexp=24007246&c=ANDROID&txp=4432434&sparams=expire%2Cei%2Cip%2Cid%2Citag%2Csource%2Crequiressl%2Cspc%2Cvprv%2Csvpuc%2Cmime%2Ccnr%2Cratebypass%2Cdur%2Clmt&sig=AOq0QJ8wRQIgF-YlkmVzka94KgOlRM0dy5_ig5FvHruMfG1EGSuTeYgCIQDuJh20IB3sqFWyZwWRxmOeqq5uP9f5F48TlmPg57QhvA%3D%3D&lsparams=mh%2Cmm%2Cmn%2Cms%2Cmv%2Cmvi%2Cpl%2Cinitcwndbps&lsig=AG3C_xAwRQIgF7GhhNXv4vQ2qgWUe17TzH8SFnsyJDS2XvKYzc_dLEQCIQDHi1vj-8fhWeu92K7vZOT04gDApg9O9Y2yhQRx1yO2Qg%3D%3D"

[vcodec=h264]

This is the problem. In format filtering, the = operator looks for an exact match. The 1080p h264 format's video codec is labeled as avc1.640028 by youtube, so no exact match is found.
You could change your vcodec filter to [vcodec^=avc] or [vcodec~='^(avc|h264)']
Or you could ditch the -f arg altogether and use format sorting instead:
-S vcodec:h264,res:1080,acodec:m4a
(IMO this is the better, simpler solution since -S can smartly match vcodec / doesn't require an exact match)

you can just use
yt-dlp  -S res:1080,ext:mp4:m4a --recode mp4


Snippets break by exiting select mode when lsp_signature shows

The commit 7a1845e8b5fc68dc5ea2a1a7d2d2b04395b6b190 caused this behavior.
What happens is then a snippet (like the lsp function call snippet) is expanded, select mode is entered on the parameters.
When lsp_signature opens because we are in a function, it causes the mode to go back to insert mode, which exits the current node in the snippet. Jumping forwards and back in snippets still work, but each time the signature appears, the selected node is lost and you are placed in insert mode, which means you manually have to delete and type the placeholder text
Setup
  local lsp_signature = require "lsp_signature"
lsp_signature.setup {}

...

function on_attach()
  lsp_signature.on_attach {
    bind = true,
    max_height = 5,
    max_width = 20,
    hint_enable = false,
    -- hint_scheme = "String",
    zindex = 1,
    handler_opts = {
      border = border, -- double, single, shadow, none
    },
  }
end

Actual behavior
actual.webm
Expected
expected.webm
The issue occurs for rust-analyzer, sumneko_lua, and user snippets which expand to a function.
Removing the call to the lsp_signature.on_attach solves it.

It seems that updating all plugins solved the issue, but neither LuaSnip nor lsp_signature was updated.
You can close this issue as it seems solved, though by what is unclear, and I do not know exactly everything that went into the plugin update. If anyone else stumbles upon this it can reopen


Use of commas to separate different gene isoforms

Hi, currently for the AIRR fields v_call, d_call, j_call sometimes calls several gene isoforms (e.g. IGKV1-33*01, IGKV1-33*02) and these multiple isoforms are currently separated by commas. If you then output the AIRR table in CSV format, the column order is screwed up by these comma separated isoforms. Could you perhaps use a different separator for multiple isoforms to not get this problem?

OK thanks. Basically I outputted the sadie pandas dataframe to csv and then read it in later using a csv reader (not into pandas). The quotation marks seem to disappear in this case and the two isoforms are considered separate columns.


Kb spacy

Hi Kaspar!
All good, but there's a few broken links/exercises:

4b-Intro-to-NLP: typo: "a pipelines"
4c-Intro-to-NLP: "First let's have a look at our data here." --> The link is broken, it points to an old tsv.
4c-Intro-to-NLP: In the last exercise, I think you need to change SentenceCtxt to TextSnippet (both in the exercise and the solution).
4d-Intro-to-NLP: Better remove the "Disambiguation" both in the title and the content of the first cell, since it's not covered?
4d-Intro-to-NLP: The exercise is using the animacy dataset but only the bl books dataset has been loaded. So maybe better to change the exercise to apply the function to the text column of the clean_blbooks_df dataframe?

Hi Mariona!
Thanks so much for these detailed suggestions! I should have fixed these in the latest commit, but will double check :-)

Tried to improve these notebooks a bit more. I hope it's ready to merge :-)

Thanks! Merged!


docs: make image dimension more noticeable

@chcomley
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


[misc] replace black with ruff format and lint, run autofixes

See #1008 and #1002

Replaces black and nbQA with ruff format and linter
Runs autofixes with new configurations
Opts for minimal manual fixes and instead for per-file ignores and noqa flags
Changes target-version to py38 for the main package and notebooks, py311 for tools

Just reviewed the edits and this looks clean - and passes tests.  I think safe to mark as ready for review.  I'll do a quick offline check and then submit a review.

CC, FYI only:   @atolopko-czi @mlin @pablo-gar


cmd/trace: trace shows blank page on chrome

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
1.10
Does this issue reproduce with the latest release?
no
What operating system and processor architecture are you using (go env)?
ubuntu / amd64
What did you do?
run 'go tool trace m.trace'
What did you expect to see?
full view on the browser of trace
What did you see instead?
empty page on google chrome and firefox and got this error in the console Uncaught ReferenceError: tr is not defined

This error typically comes from the incompatible browser; only Chrome is supported. Can you confirm this issue with the latest stable version of Chrome? What version do you use?

The fact that firefox doesn't work is explicitly documented:

Note that while the various profiles available when launching 'go tool
trace' work on every browser, the trace viewer itself (the 'view trace'
page) comes from the Chrome/Chromium project and is only actively tested on
that browser.

Chrome, on the other hand, should work.

We could check if tracing tool is available in the browser, and give an explicit error message to the user if it is not. That blank page was very confusing for me too the first time I tried to use it.

my chrome version
Version 66.0.3359.139 (Official Build) (64-bit)
it's the latest
@AlekSi
cc @ALTree

It works for me. Can you please provide a small self-contained example demonstrating the problem?

Are you sure that m.trace is not empty? Can you attach it?

i recently  run a windows 10 vm and setup golang,google chrome and the file works will ,
it can help me for now , but i need it to run on my ubuntu machine

CC: @hyangah @heschik

@tarekbadrshalaan
Can you check if trace_viewer_lean.html is available from your $GOROOT/misc/trace directory?
$ ls go env GOROOT/misc/trace

@tarekbadrshalaan I don't see how that's possible... print post here the output of go env.

~$go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/tarek/.cache/go-build"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/tarek/Program/GO_Lang/GOPATH"
GORACE=""
GOROOT="/usr/lib/go-1.10"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go-1.10/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build795570521=/tmp/go-build -gno-record-gcc-switches"

What does ls /usr/lib/go-1.10 print?
Did you install Go from your OS package manager?

output of ls /usr/lib/go-1.10
bin  doc  favicon.ico.gz  pkg  src  test  VERSION
here how i installed go on Ubuntu
sudo add-apt-repository ppa:longsleep/golang-backports
sudo apt-get update
sudo apt-get install golang-go
echo "export GOPATH=/home/tarek/Program/GO_Lang/GOPATH" >> .bashrc
echo "export PATH=$GOPATH/bin:$PATH" >> .bashrc

Please try installing the official distribution per the instructions at https://golang.org/doc/install and see if you can still reproduce the problem.

ok it's working now with go installation from the official distribution on ubuntu/chrome
thank you
@bcmills
@ALTree
@hyangah
@AlekSi

fedora 29 has a separate rpm for "misc":
dnf install golang-misc

I got this problem recently.
What version of Go are you using (go version)?
1.13.8 (brew install go)
Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
darwin / amd64
What did you do?
run 'go tool trace trace.out'
What did you expect to see?
full view on the browser after clicking "View trace"
What did you see instead?
empty page on google chrome(v80.0.3987.100  64 bit) and got this error in the console:
Uncaught ReferenceError: tr is not defined
at onResult (trace?start=0&end=1009904:59)
at trace?start=0&end=1009904:43
output of 'ls $GOROOT/misc/trace' is:
README.md
trace_viewer_full.html
(GOROOT="/usr/local/Cellar/go/1.13.8/libexec")

https://github.com/golang/go/issues/34374

Hello. I also got this problem.
What version of Go are you using (go version)?
1.13.6 (dnf install golang)
$ dnf info golang
Last metadata expiration check: 1:54:47 ago on Fri 21 Feb 2020 06:41:40 AM CET.
Installed Packages
Name         : golang
Version      : 1.13.6
Release      : 1.fc31
Architecture : x86_64
Size         : 7.8 M
Source       : golang-1.13.6-1.fc31.src.rpm
Repository   : @System
From repo    : updates
Summary      : The Go Programming Language
URL          : http://golang.org/
License      : BSD and Public Domain
Description  : The Go Programming Language.

Does this issue reproduce with the latest release?
yes (from fedora repos that is)
What operating system and processor architecture are you using (go env)?
linux / amd64 (fedora 31)
What did you do?
run a unittest writing trace to file, then running go tool trace trace.out and firefox automatically opens. I clicked on "View Trace".
What did you expect to see?
the contents of "view trace" for my unittest.
What did you see instead?
nothing, an empty, white page in firefox (Mozilla Firefox 71.0)
In the firefox console I get:
ReferenceError: tr is not definedtrace:59:5
    onResult http://<IP_ADDRESS>:33971/trace:59
    onreadystatechange http://<IP_ADDRESS>:33971/trace:43

It seems I am also missing the misc folder:
$ go env GOROOT
/usr/lib/golang

$ stat /usr/lib/golang/misc
stat: cannot stat '/usr/lib/golang/misc': No such file or directory

I removed the golang package dnf remove -y golang and installed it from https://golang.org/doc/install using go1.13.8.linux-amd64.tar.gz. Now I have the misc folder:
$ go env GOROOT
/usr/local/go

$ stat `go env GOROOT`/misc
  File: /usr/local/go/misc
...

However, this doesn't fix the problem with an empty page in Firefox. When I launch the trace I get the same empty page with the same error message in the console. I see from @hyangah in https://github.com/golang/go/issues/34374#issuecomment-589261866 that it is not yet fixed in any stable download.

I get this too with:
Ubuntu 16.04 LTS (64-bit)
Chrome version 80.0.3987.122 (Official Build) (64-bit)
Go v1.14

The fix is in the tip and waiting for feedback so it can be included in the patch release of go1.14. Please try the version (the easiest is https://godoc.org/golang.org/dl/gotip and gotip tool trace ...

Tested gotip tool trace with chrome 80.0.3987.87 and firefox 73 on ubuntu focal (which will be ubuntu 20.04) and I confirm that the UI is now correctly loading.

I'm using go1.14 linux/amd64 and the issue is still there.

Tested gotip tool trace with chrome 80.0.3987.87 and firefox 73 on ubuntu focal (which will be ubuntu 20.04) and I confirm that the UI is now correctly loading.
@didrocks What's your golang version?

Tested gotip tool trace with chrome 80.0.3987.87 and firefox 73 on ubuntu focal (which will be ubuntu 20.04) and I confirm that the UI is now correctly loading.
@didrocks What's your golang version?

go version devel +b8f54e5 Fri Feb 28 09:29:22 2020 +0000 linux/amd64

Tested gotip tool trace with chrome 80.0.3987.87 and firefox 73 on ubuntu focal (which will be ubuntu 20.04) and I confirm that the UI is now correctly loading.
@didrocks What's your golang version?

go version devel +b8f54e5 Fri Feb 28 09:29:22 2020 +0000 linux/amd64

Thank you very much.
I tried gotip on Macos and Centos. gotip works on Macos, but failed on Centos when I called gotip download.
It complains:

Updating the go development tree...
HEAD is now at 26154f3... cmd/compile: use NEG/NEGW pseudo-instructions on riscv64
error: unknown switch `i'
usage: git clean [-d] [-f] [-n] [-q] [-e ] [-x | -X] [--] ...
-q, --quiet           do not print names of files removed
-n, --dry-run         dry run
-f, --force           force
-d                    remove whole directories
-e, --exclude
add  to ignore rules
-x                    remove ignored files, too
-X                    remove only ignored files
gotip: failed to cleanup git repository: exit status 129

Do you hava any suggestion?

The fix is in the tip and waiting for feedback so it can be included in the patch release of go1.14. Please try the version (the easiest is https://godoc.org/golang.org/dl/gotip and gotip tool trace ...

I tried gotip on centos. There is something wrong with gotip download:

Updating the go development tree...
HEAD is now at 26154f3... cmd/compile: use NEG/NEGW pseudo-instructions on riscv64
error: unknown switch `i'
usage: git clean [-d] [-f] [-n] [-q] [-e ] [-x | -X] [--] ...
-q, --quiet do not print names of files removed
-n, --dry-run dry run
-f, --force force
-d remove whole directories
-e, --exclude
add to ignore rules
-x remove ignored files, too
-X remove only ignored files
gotip: failed to cleanup git repository: exit status 129

Do you have any solution about how to fix this?

Please file a separate bug to track the gotip issue. cc @FiloSottile
If gotip doesn't work, an alternative is to build from the source. The instruction is https://golang.org/doc/install/source
I think the minor version release will be available soon and include the fix. But I don't know the concrete timeline yet  cc @andybons

It is OK on Macos:
go 1.14.4
firefox 77.0.1 (64 bit)

Marking as resolved based on https://github.com/golang/go/issues/25151#issuecomment-592598214


Example update WIP - needs windows testing, likely broken until fixed

Description
Fixes #

Added yourNewMethodName() that allows ...
Compatibility

OS
Implemented

iOS
✅❌

Android
✅❌

Windows
✅❌

Checklist

[ ] I have tested this on a device/simulator for each compatible OS
[ ] I added the documentation in README.md
[ ] I updated the typings files (privateTypes.ts, types.ts)
[ ] I added a sample use of the API (example/App.js)

I ran command npx react-native run-windows --arch x64 in react-native-device-info/example folder and example started on my Windows 10.

Secret MacBookPro user or is something wrong :laughing: :thinking:  - thanks very much for checking

This one is actually close to working (or stated differently: I think it actually is working), I just haven't had time to run it through a last check on all platforms. Hopefully soon

Superceded by #1390 which does work! Just waiting on it to finish CI


Unique constraint violation on 2nd auth attempt

Bug report
Describe the bug
The first time a user uses OAuth (github/gmail) to login it works, the second throws an error.  Digging into it seems to error on a constraint on email.   Like it is doing an insert instead of an upsert.  Attached below are the relevant logs.
Log ID
63e4e3e0-2f71-4671-a15f-772909e96277

Log Timestamp (UTC)
2023-02-01T18:05:14.488Z

Log Event Message
current transaction is aborted, commands ignored until end of transaction block

Log Metadata
[
  {
    "file": "/var/log/postgresql/postgresql.csv",
    "host": "db-gtxuwfqqizavtqcjehwl",
    "metadata": [],
    "parsed": [
      {
        "application_name": null,
        "backend_type": "client backend",
        "command_tag": "DEALLOCATE",
        "connection_from": "<IP_ADDRESS>:40538",
        "context": null,
        "database_name": "postgres",
        "detail": null,
        "error_severity": "ERROR",
        "hint": null,
        "internal_query": null,
        "internal_query_pos": null,
        "leader_pid": null,
        "location": null,
        "process_id": 26670,
        "query": "deallocate \"pgx_31\"",
        "query_id": 0,
        "query_pos": null,
        "session_id": "63d2e7b1.682e",
        "session_line_num": 16,
        "session_start_time": "2023-01-26 20:50:57 UTC",
        "sql_state_code": "25P02",
        "timestamp": "2023-02-01 18:05:14.488 UTC",
        "transaction_id": 1383,
        "user_name": "supabase_auth_admin",
        "virtual_transaction_id": "9/0"
      }
    ],
    "parsed_from": null,
    "project": "gtxuwfqqizavtqcjehwl",
    "source_type": "file"
  }
]

Log ID
c9209fe8-8a7a-41f7-bddb-dd2fdb7847c9

Log Timestamp (UTC)
2023-02-01T18:05:14.487Z

Log Event Message
duplicate key value violates unique constraint "users_email_partial_key"

Log Metadata
[
  {
    "file": "/var/log/postgresql/postgresql.csv",
    "host": "db-gtxuwfqqizavtqcjehwl",
    "metadata": [],
    "parsed": [
      {
        "application_name": null,
        "backend_type": "client backend",
        "command_tag": "INSERT",
        "connection_from": "<IP_ADDRESS>:40538",
        "context": null,
        "database_name": "postgres",
        "detail": "Key<EMAIL_ADDRESS>already exists.",
        "error_severity": "ERROR",
        "hint": null,
        "internal_query": null,
        "internal_query_pos": null,
        "leader_pid": null,
        "location": null,
        "process_id": 26670,
        "query": "INSERT INTO \"users\" (\"aud\", \"banned_until\", \"confirmation_sent_at\", \"confirmation_token\", \"created_at\", \"email\", \"email_change\", \"email_change_confirm_status\", \"email_change_sent_at\", \"email_change_token_current\", \"email_change_token_new\", \"email_confirmed_at\", \"encrypted_password\", \"id\", \"instance_id\", \"invited_at\", \"is_sso_user\", \"last_sign_in_at\", \"phone\", \"phone_change\", \"phone_change_sent_at\", \"phone_change_token\", \"phone_confirmed_at\", \"raw_app_meta_data\", \"raw_user_meta_data\", \"reauthentication_sent_at\", \"reauthentication_token\", \"recovery_sent_at\", \"recovery_token\", \"role\", \"updated_at\") VALUES ($1, $2, $3, $4, $5, $6, $7, $8, $9, $10, $11, $12, $13, $14, $15, $16, $17, $18, $19, $20, $21, $22, $23, $24, $25, $26, $27, $28, $29, $30, $31)",
        "query_id":<PHONE_NUMBER>777285000,
        "query_pos": null,
        "session_id": "63d2e7b1.682e",
        "session_line_num": 15,
        "session_start_time": "2023-01-26 20:50:57 UTC",
        "sql_state_code": "23505",
        "timestamp": "2023-02-01 18:05:14.487 UTC",
        "transaction_id": 1383,
        "user_name": "supabase_auth_admin",
        "virtual_transaction_id": "9/23490"
      }
    ],
    "parsed_from": null,
    "project": "gtxuwfqqizavtqcjehwl",
    "source_type": "file"
  }
]

To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:

Go to [https://jspears.github.io/authbug] (https://jspears.github.io/authbug) source
Click on 'login github'
Click Logout
Click login 'github'

See error
https://jspears.github.io/authbug/?error=server_error&error_description=Database+error+saving+new+user?error=server_error&error_description=Database+error+saving+new+user
Expected behavior
No Error
Screenshots

System information

OS: macOS
Browser chrome,safari, firefox
Version of supabase-js: @supabase/supabase-js": "^2.7.0"
Version of Node.js: N/A

Additional context
I had an auth trigger, that I thought might have caused this error, but I removed it and it still happens.  I also tried a 'clean' supabase instance and it did not seem reproduce.
From the schema it says
COMMENT ON INDEX auth.users_email_partial_key IS 'Auth: A partial unique index that applies only when is_sso_user is false';
I tried changing auth.is_user_sso to true/false/default, this did not fix the problem.
Add any other context about the problem here.

any update on this? this is so annoying

@kangmingtay could this be related to this fix https://github.com/supabase/gotrue/pull/990?

appears to be fixed

@bigp34ch if you are still running into any issues, please feel free to open a support ticket through https://app.supabase.com/support/new and we'll definitely look into it!


Element queries integration

As discussed on gitter, I think glamor(ous) would be a great match for element queries (via eqcss). I'm not sure whether this is more about glamor than glamorous (upon further consideration I'm thinking it's likely the former) but since I mentioned it on the glamorous gitter, I'm filing it here for discussion.

In a nutshell, element queries provide two things on top of regular CSS:

They allow writing conditions that match against specific properties of a single element (foregoing the need for JS for behaviour like "hide this element if the container is smaller than N px"); but with a lot more checks than just width and height.

Since they behave similarly to media queries, they can define arbitrary CSS rules that only take effect when the element query matches (just like media queries which can define CSS rules that only take effect when the media query matches).

Additionally element queries define semantics for referencing the element matched by the query in selectors.
The former is pretty useful to reduce DOM boilerplate by itself, but the latter is the real killer because it means you can write CSS like (stupid example, I know) this:
@element .cls-xyz {
  body {
    background-color: red;
  }
}

(in plain English: "if an element with the class name cls-xyz is present on the page, set the background-color of the body element to red.)
This eliminates a lot of headaches for all kinds of cross-cutting styling concerns that involve elements that are neither direct siblings nor descendants of one another.

The EQCSS library basically acts as a runtime that applies the element queries by watching for changes to the DOM. It can either parse the existing stylesheets by calling EQCSS.load() or can be fed new element queries at runtime like this (example from eqcss-parse):
EQCSS.register([{
  selector: 'input',
  conditions: [{
    measure: 'max-characters',
    value: '3',
    unit: null
  }],
  style: 'html {background: lime;}'
}]);

So implementing element queries in glamor(ous) should be as easy as intercepting element queries and passing them to EQCSS.register instead of dumping them in the stylesheet the generated CSS would normally be written to.
I think it would be possible to build a proof of concept by patching glamor(ous) directly but I'm drowning in work at the moment so I have to leave this as an exercise for the reader right now.

Is this at all in scope for glamor(ous)? I think it suits the idea of css-in-js nicely (even though EQCSS often feels more like js-in-css).
/cc @tomhodgins

Feel free to ask me anything about the EQCSS-side of this equation, I'm less familiar with Glamorous so I can only see how the connection could be made from the EQCSS direction. If Glamorous can produce equivalent JS objects in the same format that eqcss-parse returns then you may not even need to use EQCSS syntax at all.
Assuming you're working with CSS in JS and eventually that CSS will get output to the page, here are the possible handoff points I can see:

your JS directly produces objects EQCSS.js can load as JS (same format output as eqcss-parse)
your JS includes EQCSS syntax strings that can be parsed in advance and loaded as JS
your JS outputs EQCSS syntax to HTML (as style, link, or script) to be found and parsed by EQCSS.js after the page loads

To me it sounds like either 1. or 2. are what you're aiming for here

Actually, this feels like a problem that would be solved by glamor more than glamorous. Maybe @threepointone, @donaldpipowitch, or @ChristopherBiscardi could pitch in with thoughts.

maybe something worth exploring in a plugin?

@ChristopherBiscardi If I understand it correctly, a possible plugin would be to do something like this?
function eqcss({selector, style}) {
  if (selector.startsWith('@element ')) {
    EQCSS.process(`${selector} { ${style} }`);
  }
  return {selector, style};
}

This seems straightforward enough but if I understand the plugin system correctly the style wouldn't benefit from things like auto-prefixing?

Hmmm... I think you'd still get that, but I'm not sure 🤔 Maybe try it out: https://help.glamorous.rocks

Here's a proof of concept:
https://codesandbox.io/s/g5ZgWRGPk
Note that the contained style doesn't get processed by glamor, though. I guess they'd need to be run through the entire plugin stack manually again (which shouldn't cause any trouble but I'm not sure whether there's an API for that).

Cool! Someone who knows glamor plugins better than I do could probably help with the autoprefixing stuff I imagine 🤔
At this point I think that I'm going to close this issue (as it seems out of scope for glamorous), but feel free to keep chatting about a solution. I hope that we can make this plugin a package that people can use and we could add it to the glamorous website under "Integrations" :)


Added how-to videos to landing page

Preview Link

Click to demo updates
Description

This PR replaces the images in the How do I use the Health Equity Tracker? of the landing page with videos.
-The user is able to stop the video by right clicking.
Motivation and Context

Closes #1809
How has this been tested?

Tested locally
Screenshots (if appropriate):
https://user-images.githubusercontent.com/72993442/193684638-80450daf-c7be-4ae9-84b1-5aa18bd7622a.mov
Types of changes

New feature (non-breaking change which adds functionality or content)

This is great, and awesome the user can enable the controls and pause the animations. A while ago I brought in this hook that detects if the user has selected "prefers reduced motion" which is used by some people who get nauseous / sick from animated motion. It'd be great to use this hook, and if it returns true to not set the "autoplay" attribute
https://github.com/SatcherInstitute/health-equity-tracker/blob/main/frontend/src/utils/hooks/usePrefersReducedMotion.tsx


Missing personFields parameter

Hello,
I am trying to execute this:
        $client = new \Google_Client();
        $client->setAccessToken($acess_token);
        $people_service = new \Google_Service_People($client);
        $optParams = array(
            'pageSize' => 10,
            'personFields'=>'emailAddresses'
        );
        $results = $people_service->people_connections->listPeopleConnections('people/me', $optParams);

And i got the error:
Google_Exception in Resource.php line 147:
(list) unknown parameter: 'personFields'
Adding the parameter personFields in the Google_Service People class constructor has resolved the problem.

Due to a change of canonical name of the people:v1 API, the People client is not being updated. Please switch from using the People client to the PeopleService client, which has the field you are looking for.

Specifically, see here:
https://github.com/google/google-api-php-client-services/blob/7991a72f5ba77d3648f440caa29e26e118629f02/src/Google/Service/PeopleService.php#L300

Ok! Thanks!


feat(repo_config): added support for multiple branches per single repo

The purpose of this pull request is effectively enable support for multiple branches per single repository.
Let's use below repoConfig for example:
repoConfig:
  - provider: github
    repo: dinghy
    branch: main
  - provider: github
    repo: dinghy
    branch: test

Up until now fetching repository configuration - check method GetRepoConfig - utilized just two attributes: provider and repo. If we had configuration like the one above, search would return the first config that matched those two attributes. As the slice of is ordered, GetRepoConfig would always return first configuration without taking branch into consideration. Even though two branches are configured per single repository, we would always use just one.
I aimed at changing aforementioned behavior to actually support multiple branches per the same repository. To achieve that I added branch into the mix of attributes that are used to find expected configuration.

Coverage increased (+0.05%) to 53.788% when pulling 87ed246986e8c5f009d7896eaa5b31f01359b2f2 on feat/support_mutliple_branches_per_repo into f695642bddaf9aa34ac0eb2463236df872a40299 on master.


TextInput scrollEnabled prop existing crashes on iOS when multiline is false

[x] Review the documentation: https://facebook.github.io/react-native
[x] Search for existing issues: https://github.com/facebook/react-native/issues
[x] Use the latest React Native release: https://github.com/facebook/react-native/releases

Environment
React Native Environment Info:
System:
OS: Linux 4.15 Ubuntu 18.04.1 LTS (Bionic Beaver)
CPU: (6) x64 AMD FX(tm)-6300 Six-Core Processor
Memory: 4.52 GB / 31.32 GB
Shell: 4.4.19 - /bin/bash
Binaries:
Node: 11.6.0 - ~/.nvm/versions/node/v11.6.0/bin/node
npm: 5.7.1 - ~/.nvm/versions/node/v11.6.0/bin/npm
SDKs:
Android SDK:
API Levels: 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28
Build Tools: 19.1.0, 20.0.0, 21.1.2, 22.0.1, 23.0.1, 23.0.2, 23.0.3, 24.0.0, 24.0.1, 24.0.2, 24.0.3, 25.0.0, 25.0.1, 25.0.2, 25.0.3, 26.0.1, 26.0.2, 27.0.3
System Images: android-19 | Google APIs Intel x86 Atom, android-21 | Google APIs Intel x86 Atom_64, android-25 | Google APIs Intel x86 Atom, android-27 | Google APIs Intel x86 Atom
npmPackages:
react: 16.6.3 => 16.6.3
react-native: ^0.57.8 => 0.57.8
npmGlobalPackages:
react-native-cli: 2.0.1
Description
On iOS, the application will crash if a scrollEnabled={false || anyValue} if the multiline prop is anything but true. I am attempting to do a <TextInput multiline={multilineEnabled} scrollEnabled={multilineEnabled}/> but this crashes the app when multiline isn't enabled, forcing me to do a workaround using property spreading. This is a bug and should be fixed. The presence of a prop, no matter what the value, should not crash the app.
This was previously reported here, and marked as stale (like MANY of the other ignored / unresolved issues in this community): https://github.com/facebook/react-native/issues/21339
Reproducible Demo
On iOS, all you need to do is run a simple vanilla app with the following JSX and the app will crash:
<TextInput multiline={false} scrollEnabled={false}/>

Why was this closed? It is still very much an issue. Using the latest react-native version.

@th317erd Hi, this issue fixed in 9ff43ab. It may works in next release.

Ah, awesome. Thank you!


Add GitHub tags

Thanks for resolving #4.
Could you also add a GitHub tag for the current release. https://github.com/d-e-s-o/serde_variant/tags

Fair point. Done.


Error building with Gordon

Hello,
I am trying to deploy my flask-ask app using Gordon. I keep getting this error:
Error building lambda ''!
cmd: pip install --install-option="--prefix=" -r requirements.txt -q -t /Users/Dominic/.gordon/tmpENe3wl

/Library/Python/2.7/site-packages/pip/commands/install.py:194: UserWarning: Disabling all use of wheels due to the use of --build-options / --global-options / --install-options.
  cmdoptions.check_install_build_global(options)
Command "/usr/bin/python -u -c "import setuptools, tokenize;__file__='/private/var/folders/dt/yt36_qnn7sj8zq99btd89lqc0000gn/T/pip-build-7hIB5s/cryptography/setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" install --record /var/folders/dt/yt36_qnn7sj8zq99btd89lqc0000gn/T/pip-9lsFfP-record/install-record.txt --single-version-externally-managed --compile --prefix= --home=/var/folders/dt/yt36_qnn7sj8zq99btd89lqc0000gn/T/tmp51gqak" failed with error code 1 in /private/var/folders/dt/yt36_qnn7sj8zq99btd89lqc0000gn/T/pip-build-7hIB5s/cryptography/

I tried adding packaging==16.8 to requirements.txt as suggested on other cryptography related issues but that did not work.
Thanks!

flask-ask won't work with straight lambda. you'd have to use zappa


Update push aur

Current dependencies on/for this PR:

main

PR #557   👈

This comment was auto-generated by Graphite.


Maximizing the window [No full screen mode] should be enabled

The application currently has 2 modes default size pane and full screen mode. It will be better if the window size can be maximized without full screen mode.

I think it is a more of OSX issue, you can use BetterTouchTool.
How do other applications behave ?


[9.x] Deprecated message fix

Deprecated message on Str::length. Check is null than return 0;

👎 here. You are not allowed to call Str::length with null value. You MUST pass through only strings.

Yeah but currently is allowed.

Now i changed to allowed only string type

You should cast the $value to string,

Yeah this one solution. But is it not better when people get a execption? With the "new" php verions, is it allowed to set fixed types in the function parameters, for situations like this.


Don't upload texture if locked using TEXTURELOCK_READ

The API docs suggest that you can call texture.lock() with a mode of either TEXTURELOCK_READ or TEXTURELOCK_WRITE, but in this option doesn't do anything.
This is a small change so that a lock that's opened with TEXTURELOCK_READ will not call texture.upload() when unlocked. It also uses the mode to check the state, instead of overloading texture._lockedLevel for this purpose.
I also have some related questions about how we should handle mip updates via API - please see #6004

TBH the team had internally mumbled wanting to completely rewrite the texture API, but this is often a pipe-dream. Breaking backwards compatibility is very painful for us and our users.
I love this PR and the issue you created with explanation. It is well thought out and a clear improvement to the API - thanks so much!

related to #4237

Ha, I actually forgot about this! I guess this API has been on my mind for a while 😄

Made some changes to assertions, now you can only have one lock in place at a time. If those changes look good, feel free to merge.
I'll probably follow up (soon-ish) with a PR that implements my proposal in #6004; it may be easier to consider/discuss when you see a concrete implementation.


Please merge resolution for Issue #55 (Kaltura)

I commented out the Kaltura dep and remove the Equella Kaltura code.  I will be placing the Equella Kaltura code in a separate repo owned by 'equella' once I work with Drew on the repo permissions issue.
Codebase compiles and runs.

Is this an issue ticket for merging the pull request?


Misc. Cleanups

Jenkins Build Summary
Built from this commit
Built at 20180330 - 04:44:04
Test Results

Build Type
Log
Result
Status

docs
logfile
1 cases, 0 failed, t: 2s
PASS :white_check_mark:

clang.debug.unity
logfile
1012 cases, 0 failed, t: 243s
PASS :white_check_mark:

msvc.debug
logfile
1008 cases, 0 failed, t: 556s
PASS :white_check_mark:

coverage
logfile
1012 cases, 0 failed, t: 605s
PASS :white_check_mark:

clang.debug.nounity
logfile
no test results, t: 112s
FAIL :red_circle:

clang.debug.unity, PARALLEL_TESTS=false
logfile
1012 cases, 0 failed, t: 471s
PASS :white_check_mark:

gcc.debug.nounity
logfile
no test results, t: 118s
FAIL :red_circle:

msvc.debug, PROJECT_NAME=rippled_classic
console
no test results, t: n/a
FAIL :red_circle:

gcc.debug.unity
logfile
1012 cases, 0 failed, t: 236s
PASS :white_check_mark:

clang.release.unity
logfile
1011 cases, 0 failed, t: 322s
PASS :white_check_mark:

gcc.release.unity
logfile
1011 cases, 0 failed, t: 344s
PASS :white_check_mark:

msvc.release
logfile
1007 cases, 0 failed, t: 497s
PASS :white_check_mark:

gcc.debug.unity -Dstatic=true
logfile
1012 cases, 0 failed, t: 236s
PASS :white_check_mark:

While you're at it:
https://github.com/ripple/rippled/blob/develop/src/ripple/unity/hyperleveldb.h
https://github.com/ripple/rippled/blob/develop/src/ripple/unity/leveldb.h

CancelTicket.cpp and CreateTicket.cpp need to include #include <ripple/protocol/TxFlags.h> for the non-unity build.

https://github.com/ripple/rippled/blob/develop/src/ripple/unity/beastobjc.mm
https://github.com/ripple/rippled/blob/develop/src/ripple/beast/core/mac_SystemStats.mm
https://github.com/ripple/rippled/blob/develop/src/ripple/beast/core/core.unity.mm

https://github.com/ripple/rippled/blob/35fa20a110e3d43ffc1e9e664fc9017b6f2747ae/src/ripple/protocol/digest.h#L125-L133
Replacing hash functions from OpenSSL? These are hopefully as fast and standard as can be already...
Also OpenSSL and BoringSSL (probably LibreSSL too, haven't checked there) now also natively support ed25519, so you might be able to drop another whole library from your code base. :-)

We compile with RIPPLE_USE_OPENSSL, so we use the OpenSSL versions. But Beast had its own implementations (for other purposes) so it was easy to offer a common interface for both. Hence that block of code.
It's cool that OpenSSL has Ed25519 support, but I ran a quick check and it seems horribly slow compared to the current library; and, honestly, I find the API that it exposes to be horrible.

So the else part is already dead code and can't even compile. RIPPLE_USE_OPENSSL is only used in this single place in the code, so it probably can be removed alltogether.


Fix black error.

After https://github.com/jazzband/django-auditlog/commit/ffd8bb1e85fe7ed80d85062e4d5932f28065b84c we have black error

Nice catch !


Typescript shows disabled prop does not exists but still works displaying disabled color

Package

[ ] lucide
[ ] lucide-angular
[ ] lucide-flutter
[ ] lucide-preact
[X] lucide-react
[ ] lucide-react-native
[ ] lucide-solid
[ ] lucide-svelte
[ ] lucide-vue
[ ] lucide-vue-next
[ ] Figma plugin
[ ] source/main
[ ] other/not relevant

Version
0.358.0
Can you reproduce this in the latest version?

[X] Yes
[ ] No

Browser

[X] Chrome/Chromium
[ ] Firefox
[ ] Safari
[ ] Edge
[ ] iOS Safari
[ ] Opera
[ ] Other/not relevant

Operating system

[ ] Windows
[ ] Linux
[X] macOS
[ ] Other/not relevant

Description
Typescript shows disabled prop does not exists but still works displaying disabled color
Steps to reproduce
Code:
<ZoomIn className="anticon" disabled={scale === 50} onClick={onZoomIn} size={20} />

Error:
Type '{ className: string; disabled: boolean; onClick: () => void; size: number; }' is not assignable to type 'IntrinsicAttributes & LucideProps'.
  Property 'disabled' does not exist on type 'IntrinsicAttributes & LucideProps'.

Checklist

[X] I have searched if someone has submitted a similar issue before and there weren't any. (Please make sure to also search closed issues, as this issue might already have been resolved.)

What do you mean by "disabled color"?

Isnt only these props + any SVG props? Disabled is not listed.

What do you mean by "disabled color"?

@karsa-mistmere the 2 left ones have "disabled color" which is less bright than the rightest one.

What do you mean by "disabled color"?

@karsa-mistmere the 2 left ones have "disabled color" which is less bright than the rightest one.

Sorry, what I really meant is can you check what CSS declarations set this so called "disabled color", because Lucide has no such styling.

thanks for the question, I checked and it's a css in our stylesheet that does the job. sorry for the trouble, closing this now.

thanks for the question, I checked and it's a css in our stylesheet that does the job. sorry for the trouble, closing this now.

Yeah, I had a hunch it might have been that.
Be aware though, that disabled is not a valid property on <svg> elements: https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute#d
(That's why you get the error.)


Removed sleep mode

Coverage decreased (-0.9%) to 89.57% when pulling 221ae9ab1b11d62566331930532cd08694f841bd on dev_revert_sleep into<PHONE_NUMBER>e6f8bb53d29a8856bf499b4ecdb339 on revert_sleep.

Coverage decreased (-0.9%) to 89.57% when pulling 9a55cba25106e3cae832217721a0c3304611382f on dev_revert_sleep into<PHONE_NUMBER>e6f8bb53d29a8856bf499b4ecdb339 on revert_sleep.

Coverage decreased (-0.9%) to 89.57% when pulling eaec44bb7e969ac268ac51b7f2aaed951ccdd8a4 on dev_revert_sleep into<PHONE_NUMBER>e6f8bb53d29a8856bf499b4ecdb339 on revert_sleep.

Coverage decreased (-0.4%) to 90.065% when pulling dd79fa36c8d2e4ed59de7681804f46abb3292ae5 on dev_revert_sleep into<PHONE_NUMBER>e6f8bb53d29a8856bf499b4ecdb339 on revert_sleep.


Configure Azure Pipelines

This pipeline configuration builds the application and produces a build for the Release configuration.

Test


Identity4  /Connect/token request is slow.

I have setup Identity Server 4 with Entity Framework.
Identity4 Server for method (/connect/token) taking around 12 seconds to load for the first time and then taking around 4-5 seconds after that.
Please suggest on this.

Sorry, it's hard to tell.

I have tried to a disable the AllowOfflineAccess as it will not generate the refresh token thus reducing  the response time, but it hasn't reduced the time significantly it just made a time difference of 3 seconds.
Please let me know if there is any way to reduce the time significantly.


Set SOURCEKITLSP_FORCE_NON_DARWIN_LOGGER for parallel test execution

Set SOURCEKITLSP_FORCE_NON_DARWIN_LOGGER to 1 so we generate a log to stderr if parallel test execution fails, which helps diagnose the issue.

@swift-ci Please test


[wip] First stab at "new" middleware handling.

So I guess this PR converts only SessionMiddleware as a POC, but if we were going to move forward with this we'd probably want to convert all the built-in middleware?

I think this style of "function wrapper" middleware is simpler, easier to write, and easier to reason about correctly than the current middleware (where you can never be sure which of your middleware methods will actually be called, and thus e.g. we can't implement a reliable TransactionMiddleware). So in general I am +1 on this change. (I think adding a few draft docs to this PR might help make the nature and benefits of functional middleware a lot clearer to those who weren't part of our DUTH sprint discussions :-) ).
The part I'm not quite happy with yet is the transition plan. Currently in this PR, middlewares are all treated as "old-style" unless they are all "new-style" (though I don't understand how the detection of that in this PR is supposed to work). This is because we can't intersperse old-style and new-style middleware in a single ordered list and get the correct semantics for both. I think this upgrade mechanism is too subtle and error-prone (no way to easily tell by looking at your MIDDLEWARE_CLASSES setting whether all those middleware are new-style or not -- you'd have to go manually inspect each one).
I'd also really like to see the ability for new-style middleware to simply be a function, not a class with a __call__ method that is implicitly instantiated at startup time. This means that the setting name MIDDLEWARE_CLASSES would become misleading. Also, I don't see any good way to autodetect the difference between the two in a single setting list, since people could have existing old-style middleware implemented as a factory function that they expect to be called at startup time.
For these reasons, I think a better and more explicit upgrade plan would be to introduce a new setting, MIDDLEWARE, and deprecate (maybe on a very slow deprecation path) MIDDLEWARE_CLASSES. If MIDDLEWARE is set, it should be a list of exclusively new-style middleware, and MIDDLEWARE_CLASSES is ignored. Otherwise MIDDLEWARE_CLASSES is handled the same as today.
The next big question is how to handle view middleware and template-response middleware. The other three kinds of middleware (request, response, and exception) can all be easily replaced by new-style middleware (request middleware is what you do in the top half of your new-style function, before calling up the chain to get the response; exception middleware can be implemented by wrapping that call in try/except, and response middleware is whatever you do in the bottom half, after getting the response.) But template-response and view middleware also have their uses, and aren't inherently replaced by new-style middleware.
I think the simplest and clearest option here is to also introduce a VIEW_MIDDLEWARE setting, which is a list of simple functions that behave the same as process_view does today, and TEMPLATE_RESPONSE_MIDDLEWARE, a list of simple functions that behave the same as process_template_response does today. I think that in practice it's rare to find a single middleware that implements both process_view or process_template_response and other methods, so I think in most cases this separation in settings actually makes it clearer what hooks are operating at various points in the cycle than it is today, where you have no idea (without deeper inspection) where a given piece of middleware might be hooking in.
I also think that really these latter two aren't middleware at all (they don't wrap anything, they just hook in at a certain point in the request/response cycle), so perhaps something like VIEW_HOOK and TEMPLATE_RESPONSE_HOOK would be better names?
The biggest downside to all this, of course, is that it's another big breaking change (not immediately breaking, but requiring update at some point), and there's been some sense that maybe we've had too many of those recently. Something like MiddlewareMixin could ease the upgrade somewhat. Another option is not to deprecate old-style MIDDLEWARE_CLASSES at all, and just let the two coexist indefinitely.

So I guess this PR converts only SessionMiddleware as a POC, but if we were going to move forward with this we'd probably want to convert all the built-in middleware?

Yes, that was just to see into how many issues I'd run :D

Regarding your novel; I don't really care -- adding three new settings strikes me as somewhat ugly, but I agree that the resulting functions would be nicer than those abnormities of middleware classes. That said you seem to be missing one minor important point of the classes: their call to the constructor allows them to perform "performance intensitive" tasks or to disable them during startup. How would that work with functions?
That said, I'll happily implement what you/(technical board) decides, in the end I think we just need a decision on how to continue…

Yeah, good point about where to put initialization code. I think this is probably something that should be discussed on -developers. I'll think it through a bit more and then post something there about the options. I'll try to keep the novels on the mailing list instead of on GitHub :-)

@carljm Did that email got lost in my inbox or did you never get around it?

The latter. I'll write it today.

Actually, strike that. I don't think two days before Christmas is probably the best time, on average, to get people's attention on a complex issue on -developers. I'll do it after the new year.

I'm working on writing up some API options here in the form of a DEP.

Closing in favour of #5949


Create a Contact us Form (with Black and White Color theme)

Hey @RIKI-05 Can I work on this issue?

hi I would like to work on this

@Tusharjain123 @prateek565 please go ahead

HEY @RIKI-05  IS THIS OKAY ?

@prateek565 it was supposed to be a different page...thanks for trying tho

I can do it in a separate page if you want . when we click on contact us it will show


FIX: store source uris in list and not Python 3 map object

In Python 2 map would generate a list, in Python 3 this is no longer true - downstream a job with source_uris set to a Python 3 map object cannot be json-serialized.
This fix keeps the source_uris in a json-serializable list in both Python 2 and 3.

Could you please open a JIRA and set the title of this PR to [AIRFLOW-XXX] title format, where XXX is the JIRA number?

I wish I could - Apache Jira has been giving me a HTTP 500 all morning. Let's see when that comes back to life.
In the meantime, do you happen to know why the tests are run against Python 2.7 on Travis?
In can see syntax errors coming from gunicorn (yield from ...).

All tests are run on py2 and py3. You need to make your changes compatible with both.
Please make sure to adhere to the commit guidelines (no FIX prefix plz)

@waltherg I think the gunicorn syntax error is just a warning (https://github.com/benoitc/gunicorn/issues/788) and won't cause the build to fail (eg https://travis-ci.org/apache/incubator-airflow/jobs/153691508)

@bolkedebruin Apologies I hadn't noticed the Python 3 runs in Travis. The one line I updated is Python 2 and 3 compatible - list comprehension works in both. I already updated the prefix of the title to follow the guidelines. Is there another prefix I missed?
@zodiac thank you for pointing this out - it must just be a warning. It looks as if I am getting import errors (https://travis-ci.org/apache/incubator-airflow/jobs/153346613#L1990) in all test configurations.

@waltherg the commit reads "FIX: xxxx". It does not start with an imperative in addition it is too long (over 50 characters), a better message would be "[AIRFLOW-447] Store source URIs in Python 3 compatible list". Please read the commit guidelines and see other PRs for examples, we use these messages to create a changelog on release. A proper formatted commit message is thus essential otherwise we have to do all that work at the end.
Furthermore can you do an empty commit to trigger the build again? I would like to see the tests pass before merging.

@bolkedebruin thank you for elaborating - you are correct I had not fully read the contribution guidelines. Apologies for that.
I hope the new PR I opened over here will work:
https://github.com/apache/incubator-airflow/pull/1754


⚠ ClamAV has degraded performance

In 3d55e57, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 199 ms

Resolved: ClamAV performance has improved in 48da7a0.


until

fixes #1690
English is not my native, and so I'm not sure what is clear description for this function.

For the description, I suggest something like this:
Takes a predicate, a transformation function, and an initial value, and returns a value of the same type as the initial value. It does so by applying the transformation until the predicate is satisfied, at which point it returns the satisfactory value.

This is great.  Thank you.
I like David's description, except that I would substitute "Accepts" for "Takes".  I always wonder where functions are taking things and if thievery is involved.  :smile:
I don't know if a additional sentence is in order warning about the possibility of infinite loops.  I know it's possible in other Ramda functions, but this one seems more likely.

Does it need anything else?

:herb:  I'm happy with this, unless someone wants to do some bikeshedding on the name.

gotta squash the commits then, please

Thanks, @iofjuupasli!


Add missing SEND-BINARY-MESSAGE function.

You had exported the SEND-BINARY-MESSAGE symbol along with SEND-TEXT-MESSAGE, but the (trivial) implementation was missing.
You might also consider using CHECK-TYPE for those two functions, though I add that in this branch.

Open another pull request for the CHECK-TYPE fix. Thanks!


Add a Partial Download input box

Hello!!
First of all lovely work, I was tinkering with it and I found that it does the job amazingly, thank you for the GUI!
I was thinking if it would be possible to add a text input box to be able to use the argument --download-sections from ty-dlp.
If possible the time range specification that the documentation shows: e.g. --download-sections "*10:15-15:00".
If this box is left empty it would do the regular full video download and ignore such parameters.
It would be very handy for some of my use cases!
Thank you Kannagi!!

thanks for liking :)
I will try to test the usage of this argument, and think of a place to put the textbox (or UI)

I have released a new version.
Supported --download-sections
If you are interested, you can test it :)

It works amazing, thank you for the work!!


Update GitHub actions to versions that use node20 as default runtime

The original intent was to update GitHub actions to versions that use node20 as default runtime, because there were warnings in the action runs. After the changes done here, only technote-space/toc-generator@v4 still receives a warning, because it seems not maintained and there is no Node.js 20 support yet.
But, updating codecov/codecov-action to v4 also required us to supply a token, because CodeCov started requesting it. See HPC-9542 for details.

The real reason was that codecov/codecov-action started requiring us to supply a token in v4. See HPC-9542 for details. I have edited the first comment to clarify the original intent and also how we needed this token.


Updated dependencies

Probably a good idea to document which Node versions this is compatible with.
Off hand, its at at least 14, ideally 16.


Add missing getauxval for Linux uClibc targets

This should fix the following error when building Rust std on Linux uClibc targets.
error[E0425]: cannot find function `getauxval` in crate `libc`
   --> /home/operutka/.rustup/toolchains/nightly-2024-06-05-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/sys/pal/unix/stack_overflow.rs:237:47
    |
237 |         let dynamic_sigstksz = unsafe { libc::getauxval(AT_MINSIGSTKSZ) };
    |                                               ^^^^^^^^^ not found in `libc`

@JohnTitor the pull request has been removed from the merge queue due to some unrelated problems in the CI pipeline. Is there anything I can do to fix this?

Sorry! It has been fixed now.

Hmm, I wonder what we should do for uclibc targets which do not include getauxval?  It's optional in some (all?) versions of uclibc, and for those of us working with unchangeable uclibc configurations, this means that we can't build rust without patching libc to include an implementation of getauxval.
Of course, that's not the fault of this PR; I only raise it here because the audience might have some thoughts.
One possibility: I could try to set up a cfg switch, similar to the which_freebsd() function from build.rs, which might be able to detect an older uclibc without a getauxval implementation and provide its own.
OTOH I know we don't really want implementation in this crate.  Not sure where an alternative spot would be, though.

@skrap I've also had to deal with this. The problem is that Rust std can't be built without getauxval, so removing (or feature-gating) it here doesn't really help. Right now I use a feature flag in my app that can enable an empty getauxval implementation. Something like:
#[cfg(feature = "fake-getauxval")]
#[no_mangle]
extern "C" fn getauxval(_: c_ulong) -> c_ulong {
    0
}

But, as you suggested, detecting it in build.rs and supplying an empty implementation if it isn't provided by the C library would be probably a better option.
I think the question is if Rust std should really depend on this function or if it can detect that the function isn't available. The libc crate could then export it only if it's actually available and Rust std wouldn't require it unless it's available. But that's probably a question for people more deeply involved in the libc and Rust std projects then I am :)


chore: fixing hopefully fixing the cypress tugboat tests

Signed-off-by: blam<EMAIL_ADDRESS>Hey, I just made a Pull Request!

:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[ ] All your commits have a Signed-off-by line in the message. (more info)

Tugboat has finished building the preview for this pull request!
Link:

https://pr6357-ni4krdbkgrmdo0ddkrdr352zjvegug4o.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/60e4260657072d6fa6ec3f83


Revert np.int to int dtype to eliminate deprecation warnings.

Fixes the np.int warnings I mention in #1

Thanks for this!


Expose JSDoc tags through the language service

Expose JSDoc tags through the language service
The main motivation behind this PR is to fix UWP API documentation behavior in Dev15, which rely on a custom JSDoc tag (@xmldoc), and was broken between 2.0 and 2.1.
The behavior of getDocumentationComment() was changed by https://github.com/Microsoft/TypeScript/pull/10671  to not include JSDoc tags anymore. I added them back as a new property.
Note the "tags" property I added to these calls will only expose the unknown tags (i.e. things that are not specially handled like @returns, @param etc) ... I couldn't think of a justification to expose the known tags too (well, also I wouldn't have been able to do so without making more significant changes to the parser which I want to avoid at the moment).
Fixes #11956
You might be interested @sandersn  @vladima

Hi @minestarks, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Mine Yalcinalp). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;


Windows: Fix a longstanding TODO

Signed-off-by: John Howard<EMAIL_ADDRESS>Just noticed in the code when I was talking to @duglin offline. Absolutely no need for the no-op UID/GID remapping call on Windows. Simply removing it.

https://github.com/docker/docker/pull/28499/files#diff-010226ebaaeeb61428008a57958bcf75R22  may pull it back in :-)


Minor typo fixes

Oops, I was to blame for the test failures. I've already fixed. Could you rebase the PR? Thanks!


Calling setOperationClass crashes the App

Team,
We are using SDWebImage 3.7.2, We want to use a class derived from SDWebImageDownloaderOperation to perform image downloads. So in order to do this we written following code where we are changing the Operation Class used by Image Downloader.
SDWebImageDownloader *manager = [SDWebImageManager sharedManager].imageDownloader;
[manager setOperationClass:[TestSavoDownloadOperation class]];

But this crashes our app with the following information in the debug window.
2015-05-26 15:39:14.871 SAVO[1364:60b] -[SDWebImageDownloader setOperationClass:]: unrecognized selector sent to instance 0x15589460
2015-05-26 15:39:14.874 SAVO[1364:60b] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[SDWebImageDownloader setOperationClass:]: unrecognized selector sent to instance 0x15589460'
Any idea why this is happening.
Thanks in Advance
Amber Aggarwal

Is your TestSavoDownloadOperation a subclass of SDWebImageDownloader?
Does your custom subclass override this:
- (id)initWithRequest:(NSURLRequest *)request
              options:(SDWebImageDownloaderOptions)options
             progress:(SDWebImageDownloaderProgressBlock)progressBlock
            completed:(SDWebImageDownloaderCompletedBlock)completedBlock
            cancelled:(SDWebImageNoParamsBlock)cancelBlock

TestSavoDownloadOperation is derived from SDWebImageDownloaderOperation.

just tried that using a custom subclass and its working fine.
SDWebImageDownloader *manager = [SDWebImageDownloader sharedDownloader];
[manager setOperationClass:[TestImageDownloaderOperation class]];

TestImageDownloaderOperation.h file
#import <SDWebImage/SDWebImageDownloaderOperation.h>
@interface TestImageDownloaderOperation : SDWebImageDownloaderOperation
@end

TestImageDownloaderOperation.m file
#import "TestImageDownloaderOperation.h"

@implementation TestImageDownloaderOperation

-(id)initWithRequest:(NSURLRequest *)request options:(SDWebImageDownloaderOptions)options progress:(SDWebImageDownloaderProgressBlock)progressBlock completed:(SDWebImageDownloaderCompletedBlock)completedBlock cancelled:(SDWebImageNoParamsBlock)cancelBlock{
 // your own custom code
}

- (void)done {
    NSLog(@"111");
}
@end


Fix issues with state restoration and vs mode selection

should close the following issues
#149 & #148

add logo in both places
in the Intro:

In the header

@LTLA we need a better one for the header ?


Grid broken in FF at certain zoom level

Because we're using * border-box rule, and border-box is still a little buggy in various browser implementations, An Example of Pure Responsive Grids (above the mountain scenery) breaks at a certain zoom level.
So this is a note to myself to apply content-box to the example to fix this corner case.

Tries this out locally, I'm zooming in to a large size and not seeing any obvious issues.

Tries this out locally, I'm zooming in to a large size and not seeing any obvious issues.

Fairly certain display: flex is more robust in this regard.


compatibly of java

Hello @lnicolet
Please make java compatible so we can use this library in java code for search in recycler view.
Thanks.

Can you be more specific? I tried using the library in a Java project and it's working without any problem.
What error are you encoring? Any logs/errors?

how can i use your search layout edittext with this code, i try to find this code.
means addTextChangedListener, there is no any option please provide some snippet code.
thanks
//adding a TextChangedListener
//to call a method whenever there is some change on the EditText
editTextSearch.addTextChangedListener(new TextWatcher() {
@Override
public void beforeTextChanged(CharSequence charSequence, int i, int i1, int i2) {
        }

        @Override
        public void onTextChanged(CharSequence charSequence, int i, int i1, int i2) {

        }

        @Override
        public void afterTextChanged(Editable editable) {
            //after the change calling the method and passing the search input
            filter(editable.toString());
        }
    });

Ok thanks, i use this i can use this in my java code as well, but it have some error my be please see.

you see in both image unnecessary space between recycler view and search layout how to solve that ,
i need my recycler view according to your example.
my xml coding

<com.nicolettilu.hiddensearchwithrecyclerview.HiddenSearchWithRecyclerView
    android:layout_width="match_parent"
    android:layout_height="wrap_content"
    app:filterWhileTyping="true"
    app:hideAtScroll="true"
    app:scrollToBottomBeforeHide="false"
    app:scrollToTopBeforeShow="false"
    app:visibleAtInit="false">

    <android.support.v7.widget.RecyclerView
        android:id="@+id/recycler_view"
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        android:clipToPadding="false"
        android:scrollbars="vertical" />

</com.nicolettilu.hiddensearchwithrecyclerview.HiddenSearchWithRecyclerView>

@lnicolet
i have solution with your comment, because i don't check in my code once.
Thanks
i close that issue with this solution, that i generate.


Adding xnd packages: libndtypes, ndtypes, libxnd, xnd, libgumath, gumath

Motivation for this change
Packages that have hopes of being a future replacement for numpy.
Things done
libgumath: init at unstable-2018-11-27
libxnd: 0.2.0dev3 -> unstable-2018-11-27
libndtypes: 0.2.0dev3 -> unstable-2018-11-27
pythonPackages.ndtypes: init at unstable-2018-11-27
pythonPackages.xnd: init at unstable-2018-11-27
pythonPackages.gumath: init at unstable-2018-11-27

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

@GrahamcOfBorg build libgumath libndtypes libxnd python3Packages.ndtypes python3Packages.xnd python3Packages.gumath

Success on x86_64-linux (full log)
Attempted: libgumath, libndtypes, libxnd, python3Packages.ndtypes, python3Packages.xnd, python3Packages.gumath
Partial log (click to expand)
----------------------------------------------------------------------
Ran 27 tests in 0.699s

OK
/nix/store/df4ql8n6gdjraghpp9vygbbzd9myryl9-libgumath
/nix/store/cazw6yrna32wxjnkwj2y8y2vf2qicz56-libndtypes-unstable-2018-11-27
/nix/store/x6dxch2fzmxvdsjps3jaa8drvm5qh73v-libxnd-unstable-2018-11-27
/nix/store/6klflvz69zm2d55qw0j2swflhnwv4a5i-python3.7-ndtypes-unstable-2018-11-27
/nix/store/ydk0pxg393lpl8a67ra1kvkiyfzbknz1-python3.7-xnd-unstable-2018-11-27
/nix/store/6fvzhmgimh9vnkmqxb5f203hhzxh4jbg-python3.7-gumath-unstable-2018-11-27

Failure on aarch64-linux (full log)
Attempted: libgumath, libndtypes, libxnd, python3Packages.ndtypes, python3Packages.xnd, python3Packages.gumath
Partial log (click to expand)
  File "python/test_gumath.py", line 392, in test_acos_opt
    self.assertEqual(y, b)
AssertionError: xnd([1.5707963267948966, 1.47062890563333[101 chars]t64') != [1.5707963267948966, 1.4706289056333368, [85 chars]None]

----------------------------------------------------------------------
Ran 27 tests in 2.594s

FAILED (failures=1)
builder for '/nix/store/dypkzap71wlwf2zj2q90xxpv6wv0pg69-python3.7-gumath-unstable-2018-11-27.drv' failed with exit code 1
error: build of '/nix/store/dypkzap71wlwf2zj2q90xxpv6wv0pg69-python3.7-gumath-unstable-2018-11-27.drv' failed

Looks like aarch64 fails due to roundoff error. Ready for review

Success on aarch64-linux (full log)
Attempted: libgumath, libndtypes, libxnd
Partial log (click to expand)
/nix/store/x3ddag1pvws60agwhqz4cc485vpl2h4p-libgumath
/nix/store/h6vzha4pl9iyfk9z0xak72x00fj4h7dp-libndtypes-unstable-2018-11-27
/nix/store/kmiv3n1cncxynmd5rsmv03y8kk3d6y11-libxnd-unstable-2018-11-27

Success on x86_64-linux (full log)
Attempted: libgumath, libndtypes, libxnd
Partial log (click to expand)
/nix/store/df4ql8n6gdjraghpp9vygbbzd9myryl9-libgumath
/nix/store/cazw6yrna32wxjnkwj2y8y2vf2qicz56-libndtypes-unstable-2018-11-27
/nix/store/x6dxch2fzmxvdsjps3jaa8drvm5qh73v-libxnd-unstable-2018-11-27

I am one of the developers behind xnd and it is a fast moving project right now so I wanted to include the latest "stable" release. But everything works in this relase.

Bump. Changes made and ready for merge.

@GrahamcOfBorg build python3Packages.gumath

gumath depends on all the new packages thus if it builds all deps build.

I really like having this in Nixpkgs, thanks.

@GrahamcOfBorg build python3Packages.gumath

Fixed ready for merge

Right now they inherit the meta from their c compiled libraries they are based on. Are you suggesting a python decryption for the package?

Right - I had missed the meta inherit. Thanks!


Create Helm-based Azure Arc GitOps flow for GKE

Description
Create Helm-based Azure Arc GitOps flow for GKE
Implementation Requirements

Parameterize deployment wherever possible
Detailed README & instructions
Reference in the main README

Supporting Docs
https://docs.microsoft.com/en-us/azure/azure-arc/kubernetes/use-gitops-with-helm

Completed
https://github.com/microsoft/azure_arc/blob/master/azure_arc_k8s_jumpstart/docs/gke_gitops_helm.md


Check for govendor version in Makefile

Some developers use Homebrew to install govendor. This version is however outdated and will not work, so let's add a simple version check to the Makefile so that we can alert peope when the version is wrong

The tip version of govendor supports has the -v flag, while the 1.0.8 version does not. Unfortunately, as both return v1.0.8 from the govendor -version command, there is no way to check this in the Makefile


what's the diff 1.1.1b vs 1.0.2f

ndk : android-ndk-r14b
i use 1.1.1b build dynamic lib, work fine.  1.0.2f or 1.0.2o build dynamic lib, program will crash

OpenSSL 1.0.2 and 1.1.1 are not binary compatible - and there are very significant differences between the two library versions. You will need to use code specifically compiled for the version in question.


Less optimistic concurrency exception and auditing

To prevent concurrency problems I split my json document over multiple tables, but for viewing purposes I always need all the different parts. For editing purposes the document will be updated by a background process potentially causing a concurrency problem for the user on the frond end ( i know this could be solved with websockets, etc)
For auditing purposes I want to store the JSON DIFF result in an update trigger.
Proposal:

add an optional concurrency pattern named "MergeOrThrow"  (or whatever) configured at table level.
the update function in postgres is changed in
. create json diff object from the new data and the current data in the table
. check version, if version is equal (or no version supplied) just update the table. if version is not equal try to execute a json merge with original data and the json diff object. if no conflicts update the field else throw a concurrency exception
. insert the json diff object into an audit table

The auditing action can of course be made optional so you can activate this for some tables.
plv8 will be required and some helpers methods for the json diff and merge actions
The json merge helper method can also be used to support json Patch commands.

I just don't see this happening or getting enough usage to justify being in Marten core, and there's been no updates in 18 mos.  I'm closing.


Create issues for migrating featurizer components to 3.0

SpacyFeaturizer
MitieFeaturizer
RegexFeaturizer
LexicalSyntacticFeaturizer
CountVectorsFeaturizer
ConveRTFeaturizer
LanguageModelFeaturizer

SpacyFeaturizer
MitieFeaturizer
RegexFeaturizer
LexicalSyntacticFeaturizer
CountVectorsFeaturizer
ConveRTFeaturizer
LanguageModelFeaturizer


Cannot Resolve symbol 'showNextMonth()'

My issue is the same as mention here Using buttons instead of horizontal scrolling #8. I am using compactCalendarView.showNextMonth() but it is not resolving. I want to show next and previous month on button click. Library version I am using is: 3.0.0

.scrollLeft()

.scrollRight()


Document how to ingest from IETF Mailman 2

IETF has switched to Mailman 2 for its mailing list archives.
This makes the URL-based scraper ineffective for mailing lists that are active after 2022.
We need better documentation on how to use BigBang with the new mailing list archive.
The quickest route is

log in to the IETF archives and download the mboxes
ingest from the mboxes

There may be a way to get the mbox directly through HTTP with a valid username/password, which would certaintly make a collect-mail script work more easily.
<EMAIL_ADDRESS>

There is already a Mailmain 2 ingestor that pulls data into a MongoDB database in the glasgow-IPL ietfdata package.
We might wrap/use this:
https://github.com/glasgow-ipl/ietfdata/blob/cc78853f3dc8435c1cbe2711e38ead32354eec17/ietfdata/mailarchive2.py


[CVP-3990] Update Operator sdk version to 1.33.0

$subject

Image references need to be updated in scorecard-basic-config.yml as well, I think.


Measure coverage for Core package only

This change is

Pull Request Test Coverage Report for Build 678

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+17.3%) to 74.819%

Totals

Change from base Build 671:
17.3%

Covered Lines:
1242

Relevant Lines:
1660

💛  - Coveralls


Support GraphiteReporter configuration from app.config

Hello guys!
Now I have to configure GraphiteReporter from app.config inside my project, becauase Metrics.Net supports only CSVReporter configuration.
Here is an attempt to do GraphiteReporter configuration inside Metrics.Net as it's done for CSVReporter.

:+1:

@PaulParau have you had a chance to look into this PR?

@slawwan not yet, I'll look into it as soon as I can though.

Hey, I got a change to look at this PR (sorry it took so long), and I think we should move the logic contained in the ConfigureGraphiteReporter method to a new extension method in GraphiteExtensions (e.g. WithGraphiteFromConfig()). This decouples the core configuration (MetricsConfig) from the Graphite-specific configuration and is necessary for the Graphite reporter to be separated into its own project later on (which we plan to do).
Let me know your thoughts on this. I can make the change myself after accepting the PR, it's trivial.

I've moved configuration code to GraphiteExtensions. But now I have some doubts about logging on else branches in new method. Please, look at my solution. If you have any ideas how to make it better, I not mind.

Here's what I think: I'd rather throw an exception instead of logging errors/warnings. Since you're explicitly calling WithGraphiteFromConfig(), it means that you expect the values to be present in the config file and to be correct (i.e. valid URI & interval). If this is not the case, it means that your application is misconfigured and you don't want configuration to proceed.
Let me know what you think.

I agree wih idea "throw an exception instead of logging"
I like the idea to disable reporter by empty settings. I need to control it from config, like CsvConfig. We use this logic in our application for graphite reporter.

So, there is new version:
`private static void WithGraphiteFromConfig(this MetricsReports reports)
{
var graphiteMetricsUri = ConfigurationManager.AppSettings["Metrics.Graphite.Uri"];
var graphiteMetricsInterval = ConfigurationManager.AppSettings["Metrics.Graphite.Interval.Seconds"];
if (!string.IsNullOrEmpty(graphiteMetricsUri) && !string.IsNullOrEmpty(graphiteMetricsInterval))
{
    Uri uri;
    if (!Uri.TryCreate(graphiteMetricsUri, UriKind.Absolute, out uri))
    {
        throw new Exception("Invalid Metrics Configuration: Metrics.Graphite.Uri must be a valid absolute URI");
    }
    int seconds;
    if (!int.TryParse(graphiteMetricsInterval, out seconds) || seconds <= 0)
    {
        throw new Exception("Invalid Metrics Configuration: Metrics.Graphite.Interval.Seconds Seconds must be an integer > 0");
    }
    reports.WithGraphite(uri, TimeSpan.FromSeconds(seconds));
}

}`

When I initially merged this (v0.4.2-pre), I made it so an exception was thrown if the config keys were missing.
What you're saying makes sense, so I've modified it now: if any of the config keys are missing, the reporter is disabled (I've also logged this to decrease the chances of the reporter being disabled by mistake). You can have a look here.
Thanks for all your help!


Trying to get a String representation of a file URL to use on a subprocess command line is frustrating.

I know of two options that seem likely to do the right thing across platforms:
extension URL {
  var fileSystemRepresentation: String {
     self.withUnsafeFileSystemRepresentation { String(cString: $0!) }
   }
}

import System
extension URL {
  var fileSystemRepresentation: String { FilePath(self)!.string }
}

It's unclear which, if either of these, actually does the right thing on a platform like Windows, where the .path property of a URL is not in native format.  Both are far too indirect.

IMO the first one is the one to prefer. The second one is going to re-parse the path string, whereas the first one only will do the URL representation conversion.

Thanks Saleem.  To be 100% clear for Foundation maintainers, Saleem's answer does not solve the issue I'm reporting, which is about a missing API and documentation.


Allow the total to be zero.

For review @sirupsen @fw42 @eapache @disaacs
@fw42 suggested allowing Progressrus to accept a total of zero as a better alternative than my original proposal to avoid passing zero into Progressrus.
I've made that change here, modifying percentage to return 1.0 if the total is zero.

LGTM

:+1:

LGTM

Pushed as progressrus 0.1.1


Add a reference for which types can cross the wasm ABI boundary

In a new reference.md document, we should have a table documenting all the types that wasm-bindgen can send/receive across the wasm ABI boundary, like this:

Type
T parameter
&T parameter
&mut T parameter
T return value

u32
Yes
Yes
Yes
Yes

str
No
Yes
Yes
No

| Type | `T` parameter | `&T` parameter | `&mut T` parameter | `T` return value |
|:---:|:---:|:---:|:---:|:---:|
| `u32` | Yes | Yes | Yes | Yes |
| `str` | No | Yes | Yes | No |

Etc.
For folks who want to help fill this table in, to figure out what is supported in what positions:

FromWasmAbi corresponds to T parameter
RefFromWasmAbi corresponds to &T parameter
RefMutFromWasmAbi corresponds to &mut T parameter
IntoWasmAbi corresponds to T return values (reference return values are not supported yet)

See src/convert.rs for details.
This is a great way to dive into the wasm-bindgen codebase! We also don't have to do everything at once, and can fill this table out in multiple PRs -- it is ok if a PR does not completely document everything (as long as the things it does document aren't wrong).

I have a question about this macro usage:
vectors! {
    u8 i8 u16 i16 u32 i32 u64 i64 f32 f64
}

Does the macro implement the traits for each type in there or for vectors of type T ie. u8, i8 etc.?

@jannikkeye ah so with the vectors! macro each type in there expands to implementations of:

IntoWasmAbi for Box<[T]> - you can pass Box<[T]> and Vec<T> to JS
FromWasmAbi for Box<[T]> - you can take Box<[T]> and Vec<T> as an argument from JS
IntoWasmAbi for &[T] - you can pass &[T] to JS
IntoWasmAbi for &mut [T] - you can pass &mut [T] to JS
RefFromWasmAbi for [T] - you can take &[T] as an argument from JS
RefMutFromWasmAbi for [T] - you can take &mut [T] as an argument from JS

For str the bare type isn't workable from you can take and pass &str to JS, but I believe you're right in that &mut str is a mistake, that's not supported just yet.

@alexcrichton thank you for the clarification. I will start working on this later today, as I think it will be helpful to everyone starting out with warm-bindgen.

Done with https://github.com/rustwasm/wasm-bindgen/pull/383, yay!


Update CMake.gitignore

The cmake generate a ProjectName_autogen folders. For more information see Cmake documentation

@53jk1 You approve this PR but i can not merge this.

I'm not a collaborator.

Any news about this merge ?

No reactions of maintainers ...


Icons

I upgraded to Ver 2.3 but I don't know how to put the icons introduced in this version.
(I don't see where to select the icons).

New system icons replace the uninformative channel switch (see #73 for details). You don't need to do anything.

Sorry but I don't understand.
I have only one camera with one channel, and no icon is shown.
I added a 2nd channel and no icon shown.
Then I added a 2nd camera and no icon is shown.
The icons should appear automatically or the user can select which icon to show?

Then I didn’t understand you, and the documentation is not clear enough. The camera icon isn't really an icon, it's just an emoji. In the "camera name" field you can select any suitable emoji from the set available on your device. I'll try to add some notice to the description.

Aahh... Ok !   Now I understand.


Cloudflare captcha challenge presented (but it isn't a captcha)

Version number
Run pip show cfscrape and paste the output below:
Name: cfscrape
Version: 2.0.7
Summary: A simple Python module to bypass Cloudflare's anti-bot page. See https://github.com/Anorov/cloudflare-scrape for more information.
Home-page: https://github.com/Anorov/cloudflare-scrape
Author: Anorov
Author-email<EMAIL_ADDRESS>License: UNKNOWN
Location: c:\program files\python37\lib\site-packages
Requires: requests
Required-by:

Code snippet experiencing the issue
import cfscrape, sys, traceback

try:
	url = sys.argv[1]
	websitename = sys.argv[2]
	filename = 'cf_bypass.txt'

	if "http://" not in url and "https://" not in url:
		url = "http://" + url

	if websitename != "":
		filename = "cf_bypass-" + websitename + ".txt"

	scraper = cfscrape.create_scraper()
	print(scraper.get(url).content)
except Exception as e:
	traceback.print_exc()

Complete exception and traceback
(If the problem doesn't involve an exception being raised, leave this blank)
Traceback (most recent call last):
  File "cf_bypass.py", line 17, in <module>
  File "site-packages\requests\sessions.py", line 546, in get
  File "cfscrape\__init__.py", line 128, in request
  File "cfscrape\__init__.py", line 194, in solve_cf_challenge
  File "cfscrape\__init__.py", line 124, in request
  File "cfscrape\__init__.py", line 147, in handle_captcha_challenge
cfscrape.CloudflareCaptchaError: Cloudflare captcha challenge presented for oneshotscans.com (cfscrape cannot solve captchas)

URL of the Cloudflare-protected page
https://oneshotscans.com/comics/the-great-ruler/1/109
URL of Pastebin/Gist with HTML source of protected page
Additional Info:
Python: 3.7.4
PyInstaller: 3.5.0
Node.js: 12.8.0
I use PyInstaller for the script. In most cases it works fine, it's just some websites that don't work.

Hi @SDXC,
I ran your snippet.
Snippet
import cfscrape, sys, traceback

try:
	url = sys.argv[1]
	websitename = sys.argv[2]
	filename = 'cf_bypass.txt'

	if "http://" not in url and "https://" not in url:
		url = "http://" + url

	if websitename != "":
		filename = "cf_bypass-" + websitename + ".txt"

	scraper = cfscrape.create_scraper()
	print(scraper.get(url).content)
except Exception as e:
	traceback.print_exc()

python issue-279.py 'https://oneshotscans.com/comics/the-great-ruler/1/109' oneshotscans

Works just fine without pyinstaller.
If it does happen to be a CAPTCHA, consider these notes (For a different project, mind you): https://github.com/codemanki/cloudscraper#recaptcha
I've yet to PR a docs update for cfscrape but you could try that or the following to see if it helps:
import cfscrape
cfscrape.DEFAULT_CIPHERS += ':!AESCCM:!DHE:!ARIA'

Cheers

Hi @pro-src
You know what, with the additional ciphers it worked in the PyInstaller compiled script as well.
Really, thank you!
But it's funny that the behavior is so different between interpreter and compiled bin...


Add behat features checking empty project states

See #169 and #234
Need to check on Windows to see if these fail there. Work as expected on Ubuntu.

@padraic you may want to rebase instead of merging (with -Xtheirs to avoid stupid conflicts)

Looks like there's a weird error on AppVeyor...

@theofidry It's #232 being pending, so it's not actually building for other PRs.

Oh, I guess you can merge this one then :)