Example using delay or yield in class instantiated in task

It would be great if you can add an example on how to use a non blocking delay in a other class than the Task itself.
I am now doing it like the example below (based on the Simple.ino example), but it requires changing the scheduler to make delay & yield public
class PrintManager  {
  protected:
    Task* _task;
  public:
    PrintManager(Task* task) {
      _task = task;
    }

    void print() {
        Serial.println("Print Loop Start");
        _task->delay(4000);
        Serial.println("Print Loop End");
        _task->delay(4000);
    }
};

class PrintTask : public Task {
public:
    PrintTask() : Task(), printManager((Task *) this){};

protected:
    PrintManager printManager;
    void loop()  {
        printManager.print();
    }
} print_task;

Thanks!

Hi,
This is not something I have ever thought of doing. Off the top of my head, I would probably pass the delay function through as a param, rather than the task, would this work for you?

Hi,
I am currently using with a modified version of NTPclient  to do a non-blocking wait for an update from a NTP server, but I expect there are many more libraries that have internal delays.
What would passing the function look like? It should still set delay_time and delay_ms of the task in order to have shouldRun run correctly, right?

Hi,
It would look something like this:
typedef void (*delayFunc)(unsigned long ms);

class PrintManager  {
  protected:
    delayFunc _delay;
  public:
    PrintManager(delayFunc delay) {
      _delay = delay;
    }

    void print() {
        Serial.println("Print Loop Start");
        _delay(4000);
        Serial.println("Print Loop End");
        _delay(4000);
    }
};

class PrintTask : public Task {
public:
    PrintTask() : Task(), printManager(this->delay){};

protected:
    PrintManager printManager;
    void loop()  {
        printManager.print();
    }
} print_task;

I havnt tried the code, but it is around there somewhere.

Thanks, I will try it out!

I tried another approach which would not require passing a function or object:
I added the static function
void SchedulerClass::delay(unsigned long ms) {
	 current->delay(ms);
 }

to Scheduler. My thinking was that I could then call it the Non-Task object (e.g. PrintManager) as
Scheduler.Delay(4000)
or
SchedulerClass::Delay(4000)
Which would then call the Delay function in the Task that is currently running
However, this gives a niece big crash as soon as current->delay calls the underlying cont_yield(&context); in Task class. Do you have any idea why?

It entirely depends on how this is done. It would be very difficult to say without being able to map its exact flow.

I'd also like to call delay and yield without passing those functions all the way down. I just tried it and it seems to work fine.

However, this gives a niece big crash as soon as current->delay calls the underlying cont_yield(&context); in Task class.

did you also happen to define yield as a class method?, if you did, make sure to also change yield(); to ::yield(); inside void SchedulerClass::begin() {}. Otherwise that yield refers to the class method, and then it crashes


[DOCU-668] Apache OpenWhisk plugin add datatypes; cleanup

https://konghq.atlassian.net/browse/DOCU-668 part of epic https://konghq.atlassian.net/browse/DOCU-301
Schema link:
https://github.com/Kong/kong-plugin-openwhisk/blob/master/kong/plugins/openwhisk/schema.lua
Direct review link:
https://deploy-preview-2870--kongdocs.netlify.app/hub/kong-inc/openwhisk/

Thank you @murillopaula and @HCloward for the review and approvals


Change the model converter to generate schema with kebab as default

This could partially address #245.  It doesn't catch it but it makes it harder for the mismatch to occur.   This PR should ideally have a test.   Perhaps remove the TimeSeriesExtents annotation   @JsonNaming(PropertyNamingStrategies.KebabCaseStrategy.class)  and verify that it still JsonV2 serializes as "earliest-time" and then also pull the schema and verify that the schema contains "earliest-time".  Just a thought.

that test sounds obnoxious. honestly i might not be too difficult to right a generic processor that checks for camelCase in the elements. Something like the checkstyle matcher for names.


Can't parse certain project files

Someone using a tool I wrote, which in turn calls into Buildalyzer, reported this exception:
Unhandled Exception: System.Xml.XmlException: System does not support 'Windows-1252' encoding. Line 1, position 31. ---> System.ArgumentException: 'Windows-1252' is not a supported encoding name. For information on defining a custom encoding, see the documentation for the Encoding.RegisterProvider method. Parameter name: name
at System.Globalization.EncodingTable.internalGetCodePageFromName(String name)
at System.Globalization.EncodingTable.GetCodePageFromName(String name)
at System.Text.Encoding.GetEncoding(String name)
at System.Xml.XmlTextReaderImpl.CheckEncoding(String newEncodingName)
--- End of inner exception stack trace ---
at System.Xml.XmlTextReaderImpl.Throw(Exception e)
at System.Xml.XmlTextReaderImpl.Throw(String res, String[] args, Exception innerException)
at System.Xml.XmlTextReaderImpl.Throw(String res, String arg, Exception innerException)
at System.Xml.XmlTextReaderImpl.CheckEncoding(String newEncodingName)
at System.Xml.XmlTextReaderImpl.ParseXmlDeclaration(Boolean isTextDecl)
at System.Xml.XmlTextReaderImpl.Read()
at System.Xml.Linq.XDocument.Load(XmlReader reader, LoadOptions options)
at System.Xml.Linq.XDocument.Load(String uri, LoadOptions options)
at Buildalyzer.AnalyzerManager.GetProject(String projectFilePath)

Buildalyzer 1.0.0 was released to NuGet last night. Can you please try it out when you get the chance and let me know the status of this issue?
FYI - the Buildalyzer 1.0.0 API has changed significantly. Revised documentation is forthcoming, but I wanted to get the release out there ASAP. Hopefully you'll be able to figure out the differences, but if not the source code of the tests is a good place to look or wait until better docs are out next week.

I just published Buildalyzer 2.0 which runs MSBuild out-of-process (as opposed to the old way of running it via MSBuild APIs). In general, if you can build it Buildalyzer should now be able to build it. Given how drastically different this new technique is, I'm closing all existing bug reports.
Please try the new version and if you're still having problems, please open a new issue.


ARROW-17258: [C++] Separate VisitTypeInline for types that can exist as a Scalar

The original function seemed to already imply it only worked at the scalar type level. I've seen this function used to switch on the DataType of Datum when selecting the implementation of a kernel, so I don't think adding a second version is necessary. Maybe a rename, but I guess "type" when by itself doesn't include array types, but the type of the scalar or of the individual values that make up the array.


Conform error cases to ErrorType

This is provided by the stdlib, it makes sense for us to conform to it.
As per discussion in #56

:+1:


Range value types are not associated with V when querying by score

closes #88

There are some tests here (probably enough?): https://github.com/gvolpe/fs2-redis/blob/master/modules/tests/src/test/scala/com/github/gvolpe/fs2redis/Fs2TestScenarios.scala#L116

I'd say if you didn't add a new test after this change, someone could revert it by accident and you wouldn't know :p

Good point, I'm being lazy :smile:


[2.3.1] Generate and Send Email

Issue Details
Description
This sub issue is for me to generate a list of Clarifications and Queries to the client to get a better understanding of the Client's requirements and ensure that our deliverables align with their expectations.
Goals
Have a draft email with a list of clarifications and queries to be asked. Afterwards, have the draft email  checked by my group mates before sending it out to the Client.
Success or Completion Criteria

[x] Draft Email
[x] Sent Email to the Client.

Allocated Time
2 Days
Start Date: 11/09/23, 0900
End Date: 13/09/23, 2359

Summary of email drafted
CLARIFICATIONS:

System Configurations for IT Admins:

IT admins can create empty accounts for staff members.
They have control over the Manager's dashboard view.
IT admins can modify all deadlines.

Notification System:

Notification emails will be sent to assigned staff members after Manager's weekly assignments, before Sunday.

Assignment Rejections:

Manager receives notification emails if staff members reject job assignments.

Manager's Adjustment:

The Manager can swap assigned staff members with those in a backup pool.

Staff Assignment Rejections:

Staff can only reject shifts from notification email receipt until the day before the shift.

QUERIES:

Concerns about staff availability, both Full-time and Part-timers.
Question regarding whether the system requires seamless connectivity island-wide.
Inquiry about specific industry standards or regulations our system should adhere to.

Issue Comments
Description
Reviewed drafted email together with group mates before sending out email to client
Changes to success or completion criteria? y/n (if y, describe)
n
Start Date: 11/09/23, 0900
End Date: 13/09/23, 2359


Box2d label with Draw

Similar to https://github.com/eto-ai/rikai/pull/632, but extend Draw instead of using a list.
It can have a sugar
.... @ {"color": "green", "width": 10}

which list hasn't.
part of https://github.com/eto-ai/rikai/issues/550

I want to set up the font size for text labels, but I found it complex, made it an independent issue.
https://github.com/eto-ai/rikai/issues/655


Getting Render Library Name and "pivotOptions"

Hey Nicolas,
I am attempting to implement and on off switch for the UI interface. Im hitting bit of a road block when trying to store the specific renderer, as for pivotUI it seems to take the renderName and loop through all the render options to find a match to the library (C3, D3 etc). Obviously this wont work with pivot as need to know the specific render library to call pivot. Im looking to store data from PivotUIOptions, then parse what I need to render in pivot(), then since I already have the previous state before calling pivot easy to go back to pivotUI.

And... i figured it out.


Implement a global feedback in the app

This component will be placed between the header and todo component

Create a SET_FEEDBACK action in todo reducer and accept the following props:

severity (enum: warning, info, success, error)
text (string)

This should be done after this ticket
Create an Alert component - #11

PR: #15


New feature

Idea for a new display: have a chronological order of the papers' network.
e.g. http://bl.ocks.org/robschmuecker/7880033
or    https://bl.ocks.org/mbostock/4063570

First, I think this could be a good idea.
The main issue for me would be that the graph won't be full-forward as some citations are posterior of the publicaion of the article, thus lowering the readability.

True for the 0 threshold display. However it may be interesting for a huge number of papers and a well set threshold so that you can easily trace back the origin of the work.

No matter the threshold. I have a paper A my database which cites a paper B. However A was published before B.
But I agree to a certain extent that it would be a nice feature. This can be resolved with colors and gradients or other modalities intead of the graph shape


Vulkan setup

https://vulkan-tutorial.com/Drawing_a_triangle/Setup/Base_code
setup vulkan base code

instance done

physical device, queue family done

done in https://github.com/v4vendeta/horizon/commit/45ae1f17402c32362953f00471c7b1d29f85daaa


Misc fixes for dependency verification

Context
See commits

@melix I assume you mean 6.2 RC1?

Woot, yes

@ljacomet would you mind taking a quick look at this? If it passes I'd like to merge asap in order to build a new nightly and update the wrapper to stabilize builds.


Unable to write files to drive Z in Wine

This is specifically an issue when using mp3tag, wherein I can't write any tags to files. This didn't happen with wine-portable-executable, and I can assume this has to do with Conty being perceived as drive Z under the new setup. Is there a way to work around this?

You can work around this by adding a new drive in your Wine prefix. For example if your mp3 files are in your home directory, add a new drive linked to $HOME.
cd ~/.wine/dosdevices
ln -s $HOME "k:"


Added Repetier-Server sensor platform

Description:
Adding Repetier-Server sensor for each device in your Repetier-Server
Example entry for configuration.yaml (if applicable):
# Example configuration.yaml entry
sensor:
  - platform: repetier
    url: http://IP_ADDRESS
    port: PORT
    api_key: YOUR_API_KEY

Checklist:

[ x ] The code change is tested and works locally.
[ x ] Local tests pass with tox. Your PR cannot be merged unless tests pass
[ x ] There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

[ x ] Documentation added/updated in home-assistant.io

Hi @MTrab,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

I'm not quite sure what to do. It failed on coverage/coveralls, but can't figure out what part of the code is the problem?!

@MTrab did you write tests for your code? If not you should add your files to .coveragerc. Have a look here.

@GidoHakvoort thank you - I had completely missed that part.

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
[ ] New dependencies are only imported inside functions that use them ([example][ex-import]).
[ ] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[x] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

Hmm - can't mark this ready for review?!
Is that intentional or have I done something wrong?
This is my first Github pull request ever, so I'm not sure how this normally works.

@MTrab Someone was automatically assigned to mine.


UI - strata hotel application

Issue:

bcgov/entity/issues/

Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

Temporary Url for review: https://strr-platform-dev--pr-274-nevq2lox.web.app

Temporary Url for review: https://strr-platform-dev--pr-274-nevq2lox.web.app

Temporary Url for review: https://strr-platform-dev--pr-274-nevq2lox.web.app


AzurestackStorage SDK update for container migration and unsupported feature removal

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] I have read the contribution guidelines.
[x] The pull request does not introduce breaking changes.

General Guidelines

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[x] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[x] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as a link to the swagger spec, used to generate the code.
[x] The project.json and AssemblyInfo.cs files have been updated with the new version of the SDK.

Can one of the admins verify this patch?

Hi @cheguv, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (cheguv). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@azuresdkci add to whitelist

@eridai @cheguv requested review from you. Once you approve this can be merged.


Implement Kitura-JWT

Hi!
How to contribute to this issue?
Is it a separate module from separate repository?

@lolgear Hi there!!!
The development for this package is being done internally. We will publicize it once it is finished.


Program using RemoteSyslog5424Appender doesn't shut down unless log.Logger.Repository.Shutdown() called

This simple console program:
namespace ConsoleApplication1
{
 class Program
 {
	static void Main(string[] args)
	{
	 XmlConfigurator.Configure();

	 var log = LogManager.GetLogger(typeof(Program));
	 log.Debug("Pre-Hello world");
	 log.Info("Hello world");
	 log.Error("Eek!");

	 //log.Logger.Repository.Shutdown();
	}
 }
}

fails to shutdown unless //log.Logger.Repository.Shutdown(); is uncommented.
A manual call to log.Logger.Repository.Shutdown(); shouldn't be necessary

@mrdavidlaing, I've tried to set Background=true as @ewilde suggested, but there are some ramifications. With this property set the application always shuts down successfully, but it doesn't send any data unless you call log.Logger.Repository.Shutdown() explicitly. log4net is using AppDomain.ProcessExit event to close appenders before exiting, but total time for processing is limited to just 2 seconds by runtime, and this time is not enough to flush data to the server.


TextField cursor is misplaced when scrolled

When TextView contains a long text and text is scrolled, cursor gets misplaced when tapping on text.
In case of long tap text selected correctly, but in case of single tap, cursor jumps forward.
Here is the sample code:
@override
Widget build(BuildContext context) {
  return Material(
    color: Colors.red,
    child: Center(
      child: TextField()
    )
  );
}

Flutter doctor -v
[✓] Flutter (Channel stable, v1.2.1, on Linux, locale en_US.UTF-8)
    • Flutter version 1.2.1 at /home/artem/Development/flutter
    • Framework revision 8661d8aecd (3 weeks ago), 2019-02-14 19:19:53 -0800
    • Engine revision 3757390fa4
    • Dart version 2.1.2 (build 2.1.2-dev.0.0 0a7dcf17eb)

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /home/artem/Development/android-sdk
    • Android NDK location not configured (optional; useful for native profiling
      support)
    • Platform android-28, build-tools 28.0.3
    • Java binary at: /home/artem/Development/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_152-release-1248-b01)
    • All Android licenses accepted.

[✓] Android Studio (version 3.3)
    • Android Studio at /home/artem/Development/android-studio
    • Flutter plugin version 33.3.1
    • Dart plugin version 182.5215
    • Java version OpenJDK Runtime Environment (build
      1.8.0_152-release-1248-b01)

[✓] VS Code (version 1.31.1)
    • VS Code at /usr/share/code
    • Flutter extension version 2.22.3

[✓] Connected device (2 available)
    • Nexus 5  • 07e3ff7c0de4bdf7 • android-arm • Android 6.0.1 (API 23)
    • Nexus 10 • R32D103X89Y      • android-arm • Android 4.4.4 (API 19)

• No issues found!

Here is the complete widget code:
import 'package:flutter/material.dart';

class AppExperimentalWidget extends StatefulWidget {

  @override
  State<StatefulWidget> createState() {
    return AppExperimentalWidgetState();
  }

}

class AppExperimentalWidgetState extends State {

  TextEditingController _controller;

  @override
  void initState() {
    super.initState();

    _controller = TextEditingController(text: "Very long text. Very long text. Very long text. Very long text. Very long text. Very long text. Very long text.");
  }

  @override
  void dispose() {
    _controller.dispose();

    super.dispose();
  }

  @override
  Widget build(BuildContext context) {
    return Material(
      color: Colors.white,
      child: Center(
        child: TextField(
          controller: _controller
        )
      )
    );
  }

}

Any updates on this?
The problem described above is not reproducible in Flutter 1.0.0. So had to switch back to Flutter 1.0.0 for app release.
Moreover, looks like text entering is broken in Flutter 1.2.1 - when new route page is opened with TextField and the TextField contains pre-entered text, pressing on any key on keyboard except a space results in text duplication. For example, if TextView contains "Test" text, pressing key "a" results in "TestTesta" text. It happens for the first key press only.

Hi @33-Elephants
Testing your code sample, this issue couldn't reproduced by me  on latest
Flutter 1.12.13+hotfix.8 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 0b8abb4724 (2 weeks ago) • 2020-02-11 11:44:36 -0800
Engine • revision e1e6ced81d
Tools • Dart 2.7.0

If you're still experiencing this issue, please create a new issue and provide necessary details
Thank you


fix: articles/app-service-mobile/app-service-mobile-android-how-to-use-client-library.md

Add missing and correct existing code fences

@nschonni : Thanks for your contribution! The author, @conceptdev, has been notified to review your proposed change.

@nschonni : Thanks for your contribution! The author, @conceptdev, has been notified to review your proposed change.

#sign-off


fix fixtures_url from france.py

remove "/fr" from fixtures_url to allow French league 1 prediction

note that if you already created a French league 1 the value is store in database so modifying fixtures_url will not fix the error. To solve error once you modify or merge this, you would need to delete leagues from database and recreate them


[Feature request] Block preview picture on some Lora/Checkpoints

Please, add checkbox "block picture preview" in "View Info" for some LORAs/Checkpoints.
If we can edit notes personally for some LORA, then we should be able to set flag - "don't show preview" for that LORA/Checkpoint
"View Info" really cool feature, but some LORAs/Checkpoints has too hot NSFW previews :)

I've added a setting for max NSFW level


Dev

moving things so that page is the source of assets to avoid doubling of files
adding simple scrollspy
adding info for licensing

this is still wip but @zdroid would you like to have a quick look at the scrollspy? anything you'd change?

Codecov Report

Merging #15 into master will decrease coverage by 1.46%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
- Coverage   47.61%   46.15%   -1.47%
==========================================
  Files           5        5
  Lines         126      130       +4
==========================================
  Hits           60       60
- Misses         66       70       +4

Impacted Files
Coverage Δ

src/PkgPage.jl
100.00% <ø> (ø)

src/instantiate.jl
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e156cb6...acf1fe5. Read the comment docs.

Scrollspy is looking good. :smile: I edited a few minor things in readme and added Codecov badge.
Note: It may be a better approach to handle all those npm dependencies by adding package.json and package-lock.json.


[Backend Config I]: Add helper for finding candidate Datasets in-memory

Opening in Draft
First of many PRs breaking #475 into bite-size pieces with unit tests
This piece in particular differs in a couple small ways related to debugging on DynamicTable columns
Still needs some more tests on files opened via append mode as well as some 'combination' examples with timestamps and indexed columns. Also maybe columns added to a table explicitly as VectorData, etc... (should work in principle but hey that's what tests are for)

Replaced by #567


Fixed ImGui include files

Describe the issue
Pulling and updating the latest changes of the ImGui submodule will throw errors on building the application. This is because the include directory path for ImGui example files have changed.
PR impact
List of related issues/PRs this will solve:

Impact
Issue/PR

Issues this solves
None

Other PRs this solves
None

Proposed fix
Updated the ImGui submodule and renamed the include paths in ImGuiBuild.cpp and ImGuiLayer.cpp file.
Additional Context
I have tested this on my machine and it's working. Needs testing on another machine though.

We're not updating the submodule yet.


Pasting text from Word creates empty paragraph at the top

Hi!
I've found another issue connected with pasting functionality. When you paste from Word, the text gets an additional empty paragraph that can't be removed with backspace, nor selected (however, it can be removed when selecting everything via CTRL+A). What's good, it triggers onChange and hides placeholder, but it shouldn't paste a fragment that can't be removed.
Please take a look at GIF showing this:

Under editor, I'm showing the HTML returned by editor on onChange event to see what's going on.
Cheers!

Hi!
This issue will be fix with #297
Thank you always.

The 2.28.1 version has been updated.
If this issue has not been resolved, please reopen this issue.
Thank you.


add build_command option

Attempt to generalize the build_book.yaml so that it can handle sphinx sites as well as jupyterbook.

Will merge this for testing and fix it if I broke something.


Diffuse radiation

Description of the issue
We want to define the diffuse component of solar radiation. This is is derived from #1031, and #1067
Ideas of solution
This will be a subcasss of solar radiation (....ocurrent -> process -> radaition -> solar radiation)
Suggested definition: "Diffuse radiation is radiation that has been scattered by gas molecules in the atmosphere and by particles such as cloud droplets and aerosols."
This definition has been taken vom the cfconventions (cfconvetions.org): diffuse_downwelling_shortwave_flux_in_air.
http://cfconventions.org/Data/cf-standard-names/current/build/cf-standard-name-table.html
Workflow checklist

[x] I discussed the issue with someone else than me before working on a solution
[x] I already read the latest version of the workflow for this repository
[x] The goal of this ontology is clear to me

I am aware that

[x] every entry in the ontology should have a definition
[x] classes should arise from concepts rather than from words

This issue hast been moved to a joined issue on solar radiation components #1076

This issue hast been moved to a joined issue on solar radiation components #1076


howto documents use old CLI name sx

As a consequence of renaming the CLI name to rdfsx (yay!), the howto documents should be updated to use the new command.

Thanks for reminding it...I have just updated the How-to guides


Format of the benchmarking output on console

The Linux perf tool has a nice readable format for output and we can adopt the same, at least for the quick mode it directly applies:
interceptor:~$ perf stat ls

 Performance counter stats for 'ls':

          1.265128      task-clock (msec)         #    0.703 CPUs utilized
                 4      context-switches          #    0.003 M/sec
                 0      cpu-migrations            #    0.000 K/sec
                97      page-faults               #    0.077 M/sec
         2,006,759      cycles                    #    1.586 GHz
   <not supported>      stalled-cycles-frontend
   <not supported>      stalled-cycles-backend
         1,332,533      instructions              #    0.66  insns per cycle
           273,542      branches                  #  216.217 M/sec
     <not counted>      branch-misses

       0.001799526 seconds time elapsed

being in control of display improvement is one of the reason for forking, so I'm all for being creative in this area.


[SPARK-8019] [SPARKR] Support SparkR spawning worker R processes with a command other then Rscript

This is a simple change to add a new environment variable
"spark.sparkr.r.command" that specifies the command that SparkR will
use when creating an R engine process.  If this is not specified,
"Rscript" will be used by default.
I did not add any documentation, since I couldn't find any place where
environment variables (such as "spark.sparkr.use.daemon") are
documented.
I also did not add a unit test.  The only test that would work
generally would be one starting SparkR with
sparkR.init(sparkEnvir=list(spark.sparkr.r.command="Rscript")), just
using the default value.  I think that this is a low-risk change.
Likely committers: @shivaram

Can one of the admins verify this patch?

Jenkins, ok to test

Merged build triggered.

Merged build started.

Test build #33916 has started for   PR 6557 at commit 7eac142.

Test build #33916 has finished for   PR 6557 at commit 7eac142.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Thanks @msannell for the change.
@davies -- In python we use an environment variable PYSPARK_PYTHON to do this. Any reason we should use an environment variable instead of an option ?

Test build #866 has started for   PR 6557 at commit 7eac142.

SparkConf is the consistent way to manage configurations, we are moving away from environment variables since Spark 1.0, but still keep compatibility for old environment variables.
Sometimes, environment variables will be easy to use than SparkConf, for example, we can switch the version of Python in a single line:
PYSPARK_PYTHON=pypy pypy xxx.py

@JoshRosen may knows more about PYSPARK_PYTHON

Test build #866 has finished for   PR 6557 at commit 7eac142.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Jenkins, retest this please

Merged build triggered.

Merged build started.

Test build #33925 has started for   PR 6557 at commit 7eac142.

So we already have a SPARKR_DRIVER_R which we use to build commands in Spark Submit on the driver side. I think we should unify these but I need to check if we can use an env variable everywhere or if we can use the config variable at both places

In my work, I haven't used spark-submit: I start R (or TERR), and
access SparkR from there.
Note that SPARKR_DRIVER_R defaults to "R", whereas my proposed
variable would default to "Rscript", which is a slightly different
application.  I agree that it would be nice to find a way to unify
these.

Test build #33925 has finished for   PR 6557 at commit 7eac142.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

@davies @shivaram any updates on this?

LGTM. We can document this later.

OK merging into master.

Was this officially documented ?

This is updated by #9179

Thanks!


Copyright violations

/user/settings/ssh page says
Need help? Check out our guide to generating SSH keys or troubleshoot common SSH Problems.
Where "our guide" is GitHub's guide. And this text, along with the links, is directly taken from github. This is beyond re-creation of GitHub's look and feel, this is a direct violation of copyrights. I have seen other instances of this.
UI needs a clean up.

Good catch! We shall change to ...GitHub's guide...

Also, on the create new issue page, Content with Markdown link sends to github's markdown page, which is not exactly compatible with gogs.

@raichu true.

I've seen a few others, but I can't remember exactly where.
Well I should just post others when I come across them.

@raichu haha, no worries.

Need help? Check out our guide to generating SSH keys or troubleshoot common SSH Problems.

Fix in develop branch, test on https://try.gogs.io/user/settings/ssh

See my post above

Also, on the create new issue page, Content with Markdown link sends to github's markdown page, which is not exactly compatible with gogs.

GitHub: "Great repository names are short and memorable."
Gogs: "Great repository names are short and unique."
OMG these are just endless I give up.
Hell, did you just copy-pasted everything from GitHub including HTML and CSS?
I know that it is kind of Chinese culture to rip off things, but you have to remember that this is illegal in US.

We have consider your comments, and have contacted to GitHub and waiting for the response.

@raichu, the last part of your comment is unacceptable on a github issue, given the policy and agreement you had in hand when subscribing to github. I urge you to edit it and let the "Chinese culture" out of the discussion.

Any concrete suggestions to solve the crisis?

Sure @linquize, but i don't think there any kind of crisis :)
I will be glad to help translate / correct Gogs. I'm a native french speaker, and i'm not that bad at English.
I strongly disagree on @raichu comment regarding that "Usually it's either crappy English", i find myself very pleased with Gogs user experience, but I will be very happy to help re-formulate sentences in a Gogs-owned terminology.
Anyone to point me to a list of translation files so i can reformulate and then duplicate + translate to french?

@hickscorp Thanks, Gogs has been 100% translated to French according to https://crowdin.com/project/gogs , and are you on https://gitter.im/gogits/gogs ? That's an easier place to discuss sort of things.

@Unknwon I am. But we're always out of sync :)

@hickscorp Care to mention which term are you talking about exactly?
And in case you don't know, in US, there is freedom of speech. Speaking up public truth is not against any law.
The laws in US protects freedom of speech, and laws trump and terms of service.

@hickscorp Care to mention which term are you talking about exactly?
And in case you don't know, there is freedom of speech in US. Speaking up public truth is not against any law.
The laws in the US protects freedom of speech, and laws trump any terms of service.

@raichu, please read this c omic:

@Calinou, please read this article, it must be even funnier for you:
https://en.wikipedia.org/wiki/Copyright_law_of_the_United_States

@raichu if you don't really know how to read (And even if you're pointing me to a Wikipedia article... Well. Really? Wikipedia?!), and if you're confused between the Shanzhai phenomenon and the actual Chinese culture, then i will just say that i'm not really interested in talking to people of your kind.
Us law protects freedom of speech, and if you're proud to be claiming that Chinese culture is about rip off and scam, i'm very happy that you're surrounded by people of your kind as well, so you can have this kind of discussion freely.
However, when you sign up on github, there is a chart that you agree on reading and fully understanding. More generally, it's about the "netiquette".
It might be very hard for you to make the difference between those two, as for instance you seem to think that i'm not familiar with US law... In fact i might have lived on the US soil for quite a longer time span that you did. You just don't know, as you probably don't know what Chinese culture is all about. As long as you refer to your ideas with terms that are not confusing a majority to be defined by within the an isolated definition of a minority, i'm fine with you-being-free-to-say whatever idiotic things pleases you. Your original post wasn't like that, and the difference is a whole world to a lot of people.
[edit]Thanks for your edit on your original post. You are now referring to a term that doesn't confuses a majority to be within a minority.[/edit]

@hickscorp You hear what you want to hear.
And that's fine.
You're just nitpicking, and it's not without a purpose. And that's also fine.
It is a culture, and it is in China.  Anyone who's not nitpicking would have understood what I'm referring to.
And that's not the kind of person that I am though. In fact, after your personal "assault" on me, one can very well question your "netiquette".
Yep, I don't know if you're Count Chocula or ghost of Lincoln. I have no idea who you are. And same goes for you. You don't know who I am.
But what I know for certain is, what's going on here. It is not fair or legal to damage GitHub by ripping off from it. There shouldn't be a "Shanzhai GitHub", especially not here at GitHub.

Any concrete suggestions to solve the crisis?

@linquize
How about this for a start?
Get rid of everything you ripped off, do your own thing and work honest abiding laws.

@raichu Duly noted.

[...] In fact, after your personal "assault" on me [...]
I'm sorry if it looked personal. The way you initially formulated your sentence was really no way to discuss a copyright thing.

[...] one can very well question your "netiquette" [...]
And i encourage you to do so if you think it's important.

[...] You don't know who I am.
Let's keep it this way then :)

But what I know for certain is, what's going on here. It is not fair or legal to damage GitHub by ripping off from it. There shouldn't be a "Shanzhai GitHub", especially not here at GitHub.
As you seem to think that my objective on this "personnal assaut" was to raise a "smoke screen", then i'd be very happy to begin a fresh discussion about this very last claim.

IMO, there is no plagia here on this project. I checked the JS / CSS files from Gogs, and didn't notice any obvious copy-paste as you see, to mention. Also, it's obvious to me (And i've been following this project for quite a while now) that the team behind it is responsive and is solving the bugs as they appear. Also, the very core of Gogs is written in Go, and that's really not the way Github works internally (Correct me if i'm wrong, Github used to be RoR, and moved to Erlang + some NodeJS).
Visually, Gog's web UI is lightyears behind github's one (@Gogs maintainers: really not trying to disgrace Gogs here, just merely an attempt of proving that the magnitudes of both projects are quite different). There is no realtime event propagation, and it really looks completely different to me. It vaguely resembles Gitbucket, Gitlab etc. They all do, because their scope is very similar with each other. But there is no copyright on this.

IMO, there is no plagia here on this project.

You are proven wrong by the literal rip offs (including the href part) I pointed out in my earlier posts.
I don't know about the total extent of this, whether it includes JS/CSS/etc , which is why I stated it as a question.

You are proven wrong by the literal rip offs (including the href part) I pointed out in my earlier posts.

IMO it's quite the opposite. They kept the HREF as a reference to an external source of information, while really "ripping it off" would have been to take the target page "as is" and include it into Gogs source code.
Your thoughts?

Are you intentionally being thick?
https://github.com/settings/ssh:

Need help? Check out our guide to generating SSH keys or troubleshoot common SSH Problems

/user/settings/ssh page says

Need help? Check out our guide to generating SSH keys or troubleshoot common SSH Problems.

Are you intentionally being thick?

No, i really didn't see this. The idea would be to reformulate all the sentences present in Gogs, because making it appear like a mere copy pasting of another project would not be cool.
I actually endorsed this task, which will be my first contribution to the project.

Great, because things are quite uncool right now.
Assuming that this is done until the next release, you may also want to cease the distribution of earlier versions, because they are violating copyright laws.
You may or may not need to clean to the git history from these tainted bits, you should better consult with github on this. Hopefully, they'll be lenient with the devs of this project and not press charges.

@raichu Good pointers, thanks.

As GitHub hasn't responded or has ignored my e-mail for 5 months, I consider this issue should be closed now and keep an eye on this in the future.

A link to Github saying it is a link to Github as it is coded now is not a copyright infringement as far as I know. Even when it said our guide when it were a link to Github (not a rip off of github's content served from your own server) I doubt it were a copyright infringement but just a mistake.
And if gogs has some sentences that looks just the same than in github when talking about same topic is not a copyright infringement either. Well I suppose github has not copyright on english language, does they? It is pretty normal two people finish using even the same exact sentence to word same idea.
Don't know what this person thinks is copyright law but the following example is absurd.

GitHub: "Great repository names are short and memorable."
Gogs: "Great repository names are short and unique."
Wow, that makes everything's OK then.

Yes, that's totally OK.
And even if it were the same sentence as far as it is not the whole UI (or a large portion) with just the same look&feel and with the same sentences it should not be a problem.
About the other things talked about make no sense. That patriotism feelings are out of place in my opinion.
I'm sure github people are common sense people and if they have any problem with this project they will contact.

@manfer thanks for the comments.

@manfer
Some strings are literally copied (in more than one instance). The one I mentioned in the first post is just one example of those.

About the other things talked about make no sense. That patriotism feelings are out of place in my opinion.

Have fun explaining this at the court.
In case you're not aware, yes, even a single sentence can and is protected by US copyright law. Your definition of "making sense" or "should not be a problem" is irrelevant. You're confusing the court with philosophy club. See that tiny "© 2015 GitHub, Inc." below? That's what matters.

https://help.github.com/articles/github-terms-of-service/  F4 is what we should look at


Add convolution algorithms to resolution.Instrument

Algorithms to convolute S(q,w) functions with resolution are necessary. Original ResLib library includes two methods: 4D general convolution and the faster single mode approximation (3D). In both methods a fixed and Monte Carlo method are available.
First priority will be for the general 4D convolution with both Monte Carlo and fixed methods.

Addressed by 59d2d57873b42d04e01887fc6ac347e56ed94e0b


Consider adding visibility options next to objects in scenegraph

Considering adding a way to toggle visibility of objects in the scene graph.

Fixed, an active checkbox exists for each GO but it was not working.


fix docker image tagging

Summary
Fix the docker image tagging in CI.
Details
Currently wikmd is not following the semver standard for git tags. This causes the metadata-action to silently fail and an empty docker tag is generated. This empty tag is passed on all the way down to docker run which then fails.
With this change, the CI will create docker tags base on,

pr number e.g. linbreux/wikmd:pr-5
git tag e.g. linbreux/wikmd:v1.6
main branch -> linbreux/wikmd:edge

Checks

[ ] In case of new feature, add short overview in docs/<corresponding file>
[ ] Tested changes

Thanks for solving this!

I got an error while testing:
Run docker run -d --name wikmd -p 5000:5000 linbreux/wikmd:v1.6.1
  docker run -d --name wikmd -p 5000:5000 linbreux/wikmd:v1.6.1
  linbreux/wikmd:latest
  shell: /usr/bin/bash -e {0}
73d[2](https://github.com/Linbreux/wikmd/runs/6808444904?check_suite_focus=true#step:6:2)cd70ee877fa0[3](https://github.com/Linbreux/wikmd/runs/6808444904?check_suite_focus=true#step:6:3)8b6e877c2759d2eadb68d7ebe06225a0e66a2af9b7ca190
/home/runner/work/_temp/b40e9331-9d6d-464d-bf04-42381bbc0b10.sh: line 2: linbreux/wikmd:latest: No such file or directory
Error: Process completed with exit code 12[7](https://github.com/Linbreux/wikmd/runs/6808444904?check_suite_focus=true#step:6:8).

Hey, sorry about that. It seems that the needs.build.outputs.wikmd_tag contains both tags and that doesn't play well with docker run of course. Not sure how to fix that but I'll try to give it a look :+1:

@artivis Use ${{ steps.meta.outputs.version }} instead of ${{ steps.meta.outputs.tags }}

Hey, the issue has been solved in https://github.com/Linbreux/wikmd/pull/47.


drivers: timers: systick: Enforce a barrier in _timer_cycle_get_32.

This fix was missed out in the timer rework.
This patch was taken from 36365e38ba3f2cfb810235e4b1b2f7145c813cfd
and re applied.
The code assumes that when the systick counter hits zero,
the timer interrupt will be taken before the loop can
read the LOAD/VAL registers, but this is not architecturally
guaranteed, and so the code can see a post-reload SysTick->VAL
and a pre-reload clock_accumulated_count, which causes it to
return an incorrectly small cycle count. By adding a ISB we
overcome this issue.
Signed-off-by: Adithya Baglody<EMAIL_ADDRESS>

Codecov Report

Merging #11524 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #11524   +/-   ##
=======================================
  Coverage   48.38%   48.38%
=======================================
  Files         270      270
  Lines       42088    42088
  Branches    10133    10133
=======================================
  Hits        20366    20366
  Misses      17645    17645
  Partials     4077     4077

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06fa2e6...8257f8b. Read the comment docs.

I'm still not seeing the problem.  Can you walk me through an execution line-by-line showing what values get read from what registers, and when the interrupts happen?  At least as I see it, the code is invariant with respect to when the interrupt occurs.  We detect the rollover condition and repeat as part of the loop construction, and if the timer didn't roll over it doesn't matter whether or not the interrupt occurred.  What am I missing?

(I should add that my -1 is pretty mild.  This is at worst a harmless pipeline flush and isn't going to hurt anything meaningful.)

I actually don't see the issue anymore. But it was quite strange that I was able to re-evaluate the interrupts when I called a ISB(), when under spinlock().
Since i am not able to reproduce the issue I am closing this PR.


Please support non-GTK/GNOME-family options in the non-xdg-utils fallbacks

If you're going to support gvfs-open and gnome-open to solve #2 in situations where xdg-utils hasn't been installed and $BROWSER is unset, then I suggest adding the following two things to your fallback chain:

kioclient exec <URL> (KDE's equivalent to gvfs-open)
x-www-browser <URL> (This should go at the end of the fallback chain. On Debian-family systems (eg. Ubuntu, Mint), it invokes whatever browser is configured as default at the system-wide level and, as it's maintained by the package manager, it's guaranteed to be present and valid as long as at least one browser is installed... even if that means falling bact to lynx or links in a terminal.)

Also, if you want to be a little bit smarter in mixed installations, check whether the XDG_CURRENT_DESKTOP environment variable says KDE to determine whether kioclient exec <URL> should come before or after the g... ones in the precedence order.

If you're receptive to these changes, I wouldn't mind taking a shot at them myself.
(I just finished patching dialog-rs to support KDialog with precedence relative to Zenity depending on whether XDG_CURRENT_DESKTOP is KDE.)

That'd be great, thanks

OK. I'll try to fit it in today.
Also, I'm curious why you chose to explicitly whitelist Linux and supported BSDs, rather than specifying something like this:
#[cfg(all(unix, not(target_os = "macos")))]

After all, things like xdg-open, KDE, and GNOME do work on platforms like Solaris.

Was easier/safer for me to be explicit about it, as I didn't have those (unix but non-macos non-linux) platforms easily available to test.

Was easier/safer for me to be explicit about it, as I didn't have those (unix but non-macos non-linux) platforms easily available to test.

I appreciate your intent, but artificially limiting the portability of a project based not on the supported APIs, but based on what you've directly tested with is not the way to do it.
Here are two other examples which illicit ill-will when others did them:

Linux ports of games like Runner 2 artificially limiting proper behaviour of their gamepad input to controllers that actually report being genuine Microsoft controllers. (ie. Needlessly re-creating the XInput limitation that resulted in x360ce.)
Websites detecting based on browser name rather than supported features. (I believe Google caught some flak for doing that with YouTube to the detriment of Microsoft Edge.)

Feel free to make a big sign saying that you only officially support platforms X, Y, and Z, but don't definitively lock out platforms just because you can't prove they work.

I feel you may be over extending the ill-will analogy here, as this project is MIT/Apache licensed, and people are free to derive works from this, and thus modify it in whatever way they deem right for their use (this being a library and not an application). Moreover, I've not blocked out any PR that extends the number of platforms supported.
I've largely run with the intent of minimising bad surprises, and so will continue to be specific about the platforms that are supported, while relying on people like yourself to extend/validate the supported platforms. I hope you can understand it, even if you disagree.

I agree that the degree is certainly different, but it just rubs me the wrong way to see that, after the UNIX ecosystem learned "feature detection, not platform detection" (Good old GNU Autotools. ./configure && make && make install), and web developers had to re-learn that lesson, people are still making that same mistake.
On a niche platform, manpower to investigate problems will already be in shorter supply, so it's unfair to them to put up artificial hurdles. I'd compare it to the motivation difference between proper open-source and "e-mail me if you want the source code".
To be honest, I feel strongly enough about this that, once I have something that I'm ready to share, I may start maintaining friendly/upstream-following fork for my projects to depend on. (I'd still send all other patches up to you... I'd just maintain a fork which adds that cfg change on top of whatever you release, upload it to crates.io, and let my projects depend on that instead to ensure you don't risk becoming the one guaranteed obstacle to my creations working on niche POSIX platforms.)

I'm a fan of GNU Autotools but this is not one of those scenarios. In a typical autotools setup, it'll lead to a compile time failure if there are any missed rules/pragmas for the underlying platform. In this scenario, I'm invoking a local command, which means that compile time would pass, but it'll be a runtime failure, which can be bad for non-technical users.
That, coupled with the fact that one can just set the BROWSER env variable in niche unix platforms, should suffice. However, to enable that open_on_unix_using_browser_env should be configured for all unix family, which I agree should be done, and should cater to the scenario you're describing.

Except that the whole point of xdg-open is to be what you're trying to "reinvent badly". In a situation like this, it's the platform's responsibility to ensure that it's either functional or missing.

The idea here isn't to reinvent xdg-open 😄- it has it's own place.
xdg-open is a script, and as such is closer to a user tool, which specifically focusses on opening the default web browser, or a bunch of fallbacks, to open a url.
webbrowser-rs is a library whose objective is to expose simple APIs (thus developer centric, not user centric) to open any browser they want, with default as one of the options. For the default option, it uses xdg-open.
What my take away from this thread has been that xdg-open may be available in more environments than what I've included, even if not guaranteed to be there. I think it's probably worthwhile to include xdg-open under a #[cfg(all(unix, not(target_os = "macos"), not(target_os = "android")))].

What my take away from this thread has been that xdg-open may be available in more environments than what I've included, even if not guaranteed to be there.

Yeah. They've put a lot of effort into writing xdg-open as a highly portable shell script for that reason. POSIX requires that a Bourne-compatible shell exist at /bin/sh and the intent is that it should be usable on any OS where #!/bin/sh executes it in a Bourne shell.

I think it's probably worthwhile to include xdg-open under a #[cfg(all(unix, not(target_os = "macos"), not(target_os = "android")))].

Good catch with android. I'm so used to thinking about how Google intended the POSIX APIs to be an unimportant implementation detail from the applications' perspective that I forgot that, as a non-Java language, Rust would see Android as unix.
Also, there's actually a BSD you're currently ruling out with your existing approach. target_os = "dragonfly" was forked from FreeBSD 4.8 due to disagreements over what algorithms should be used for certain things in the kernel and they still continue to share code back and forth.


SQL Theming

Before:

After:

Can we get a little darker shading on the alternate rows? Maybe throwing in a tiny bit of blue (or green)? Just something to make the alternate rows stand out a bit more.

Not really, the colors I'm using to theme Perfetto aren't defined by me.  They are Theia's themed and defined colors.  In high contrast the alternate rows actually do show up a bit more blue.  We could also at some point add in our own Theia theme at some point as well.

OK. Not a big deal.

The "Show debug track" button seems to open a "pop-up" which is controlled by SCSS files that don't seem to be showing up in the final CSS causing the pop-up to look bad. @martin-fleck-at do you know why this file isn't being added?  Also using the "popup" that appears also seems to cause an error to be thrown (at least it did for me), so I'm wondering what value it adds.

The "Show debug track" button seems to open a "pop-up" which is controlled by SCSS files that don't seem to be showing up in the final CSS causing the pop-up to look bad. @martin-fleck-at do you know why this file isn't being added? Also using the "popup" that appears also seems to cause an error to be thrown (at least it did for me), so I'm wondering what value it adds.

https://github.com/android-graphics/sokatoa/issues/709

Query results look great in light mode, including the alternate-row shading. So that's great!

However, the query input field, itself, looks like it's stuck in dark mode:

Is that something we should address?

However, the query input field, itself, looks like it's stuck in dark mode:

Is that something we should address?

I think the intention by the Perfetto team was to make that section look like a terminal window.

I think the intention by the Perfetto team was to make that section look like a terminal window. For instance if you type in it your text will be green

Thanks, @ALevansSamsung , I think you must be correct. It's so incongruous in the UI, to me a baffling design decision. Let's park it with the black group headers.


Null fields aren't included on JsonInclude.Include.ALWAYS

I'm trying to force null fields to be written. When I tried it with a newly constructed object mapper, it works fine. But the object mapper used in the message body writer doesn't write them out.
I'm configuring the ObjectMapper in the run method of my application subclass:
env.getObjectMapper().setSerializationInclusion(JsonInclude.Include.ALWAYS);

Can you provide a reproducible test? I tested the object mapper created by dropwizard and it was able to serialize null fields to null without setting JsonInclude.Include.ALWAYS. I also confirmed it working in ResourceTestRule

I went looking for the code that was having a problem and it's been changed. So I wrote a quick project to demonstrate the problem.
dropwizard-serialization-test.zip
Here's the data classes:
@Value
public class InnerDataClass {
    private int x, y;
}

@JsonInclude(ALWAYS)
@Value
public class DataClass {
    private String field1;
    private InnerDataClass field2;
}

with a couple of simple GETs:
@GET
    @Produces(MediaType.APPLICATION_JSON)
    public List<DataClass> doThings() {
        List<DataClass> list = new ArrayList<>();
        list.add(new DataClass("a", null));
        list.add(new DataClass(null, new InnerDataClass(0, 1)));
        return list;
    }

    @GET
    @Produces(MediaType.TEXT_PLAIN)
    @SneakyThrows
    public String doThingsWithString() {
        List<DataClass> list = new ArrayList<>();
        list.add(new DataClass("a", null));
        list.add(new DataClass(null, new InnerDataClass(0, 1)));
        return new ObjectMapper().writeValueAsString(list);
    }

Here's the results:
$ curl localhost:8080/ -H 'Accept: application/json'
[{"field1":"a"},{"field1":null,"field2":{"x":0,"y":1}}]
━━━━━━━━━━━━━━━━━━━━
$ curl localhost:8080/ -H 'Accept: text/plain'
[{"field1":"a","field2":null},{"field1":null,"field2":{"x":0,"y":1}}]

hi @toadzky, I was a bit curious about your issue - so I downloaded your project, took a look and I've a possible suspect - as when I removed the lombok from picture I got the same results from both endpoints:
$ curl localhost:8080/ -H 'Accept: text/plain'

[{"field1":"a","field2":null},{"field1":null,"field2":{"x":0,"y":1}}]

$ curl localhost:8080/ -H 'Accept: application/json'

[{"field1":"a","field2":null},{"field1":null,"field2":{"x":0,"y":1}}]

BTW, @JsonInclude(ALWAYS) is not needed (as @nickbabcock already wrote), as it's the default one.

Haha, I just did the same exact thing that @patrox did and arrived at the same conclusion that it is the combination with lombok that is the problem.

@toadzky - I took a step further and found something which might help you, as I imaging that removing lombok for you might be not acceptable:
https://github.com/paradoxical-io/jackson-lombok
Please give it a try and let us know.

I tried it with and without lombok and got inconsistent results, so I didn't mention lombok as a possible cause. In this case, Lombok generates getters correctly, and the manually created object mapper works as expected, but the built in one does not.
As for the link @patrox provided, the project is misnamed IMO because it doesn't have anything to do with Lombok specifically, it has to do with the @ConstructorProperties annotation, which is a standard JavaEE annotation. Jackson 2.7+ support @ConstructorProperties by default, and is only relevant in PARSING, not serializing.

OK, looks like the url which I posted has been a dead-end, but I've been able to pinpoint what exactly is wrong in this scenario.
Seems like there is an interference between Jackson AfterBurner module and Lombok (which is not so surprising, given the fact that both are messing with the Java bytecode).
I've found it out by looking up how the internal ObjectMapper used for Jackson in Dropwizard is configured:
https://github.com/dropwizard/dropwizard/blob/master/dropwizard-jackson/src/main/java/io/dropwizard/jackson/Jackson.java#L58
When I tried to serialize a Lombok annotated class using ObjectMapper with AfterburnerModule, it indeed was skipping the null fields, once I removed the AfterburnerModule, the null fields were included.
Besides, I've also found this past issue: https://github.com/dropwizard/dropwizard/issues/1111, describing how the set-up a customized ObjectMapper, in case if some of the pre-registered modules are not needed.

It looks like I should open a ticket with Jackson's Afterburner module. Thanks.

Awesome job triaging the problem. Closing the issue because it's kinda out of our hands


CodeLense buttons do not display anymore

Just realized that codelens buttons to execute a test or a group have all disappeared.
The codeLens option in the settings is still enabled
Tried to reinstall the extention but no luck.
using version 1.0.1
Any idea why ?

Yeah, sorry ! was fixed with 1.0.2


SketchUp 2021 does not run from vscode via run task

I'm running into a vscode / sketchup issue.
If I try to use run task... from vscode sketchup does not start at all.
If I run skippy sketchup:debug 2021 on the command line, sketchup 2021 does open (but breakpoints do not work).
This public GitHub repo is based on your VSCode Project for SketchUp Extension project -- I have done very little to it yet.
I have installed the latest SketchUp Ruby API Debugger on my Mac.

Can you provide the output of these two commands please?
skippy -v

skippy sketchup:list

Can you provide the output of these two commands please?
skippy -v

skippy sketchup:list

Certainly.
% skippy -v
Skippy version 0.4.2.a

% skippy sketchup:list
Known SketchUp versions:
  SketchUp 2017   64bit
  SketchUp 2021   64bit   (debugger)

macOS Catalina, Version 10.15.7
% uname -rsv
Darwin 19.6.0 Darwin Kernel Version 19.6.0: Tue Nov 10 00:10:30 PST 2020; root:xnu-6153.141.10~1/RELEASE_X86_64

Certainly.
% skippy -v
Skippy version 0.4.2.a

% skippy sketchup:list
Known SketchUp versions:
  SketchUp 2017   64bit
  SketchUp 2021   64bit   (debugger)

macOS Catalina, Version 10.15.7
% uname -rsv
Darwin 19.6.0 Darwin Kernel Version 19.6.0: Tue Nov 10 00:10:30 PST 2020; root:xnu-6153.141.10~1/RELEASE_X86_64

If I run skippy sketchup:debug 2021 on the command line, sketchup 2021 does open (but breakpoints do not work).

That will only start SketchUp with the debugger listening. You also have to attach the debugger from the Run (Formerly Debug) tab in VSCode with the "Listen for rdebug" selected.

If I run skippy sketchup:debug 2021 on the command line, sketchup 2021 does open (but breakpoints do not work).

That will only start SketchUp with the debugger listening. You also have to attach the debugger from the Run (Formerly Debug) tab in VSCode with the "Listen for rdebug" selected.

hm... I was trying to use skippy to launch SketchUp on my mac, but I'm running into errors. I need to sort that out first.

hm... I was trying to use skippy to launch SketchUp on my mac, but I'm running into errors. I need to sort that out first.

Ok, got my dev environment corrected.
I also observe that using the tasks from tasks.json doesn't launch SketchUp. I have to look closer that what's going on there.
However, if I start from the terminal, skippy sketchup:debug 2021 and then attach the debugger I will hit the breakpoints I set. Did you attach the debugger after launching SketchUp in debug mode?

Ok, got my dev environment corrected.
I also observe that using the tasks from tasks.json doesn't launch SketchUp. I have to look closer that what's going on there.
However, if I start from the terminal, skippy sketchup:debug 2021 and then attach the debugger I will hit the breakpoints I set. Did you attach the debugger after launching SketchUp in debug mode?

For the sake of testing I also tried to launch another SketchUp version, this time one I didn't have the debugger installed to:

This indicates that skippy is at least starting, but it the fails to launch SketchUp. I don't understand why though, since executing the same command directly in the terminal works fine while via VSCode it fails. Maybe some kind of permission change in Catalina?

For the sake of testing I also tried to launch another SketchUp version, this time one I didn't have the debugger installed to:

This indicates that skippy is at least starting, but it the fails to launch SketchUp. I don't understand why though, since executing the same command directly in the terminal works fine while via VSCode it fails. Maybe some kind of permission change in Catalina?

While we figure this out, a workaround is to use a task that starts SU directly:
{
  // See https://go.microsoft.com/fwlink/?LinkId=733558
  // for the documentation about the tasks.json format
  "version": "2.0.0",
  "tasks": [
    {
      "label": "open SU",
      "type": "shell",
      "command": "open",
      "args": [
        "-a",
        "/Applications/SketchUp 2021/SketchUp.app",
        "--args",
        "-rdebug",
        "ide port=7000",
      ],
      "runOptions": {
        "reevaluateOnRerun": false
      },
      "problemMatcher": [],
      "isBackground": false,
    },
    {
      "label": "Launch SketchUp in Ruby Debug mode",
      "type": "shell",
      "command": "skippy",
      "args": [
        "sketchup:debug",
        "${input:sketchupVersion}"
      ],
      "runOptions": {
        "reevaluateOnRerun": false
      },
      "problemMatcher": [],
      "isBackground": false,
    }
  ],
  "inputs": [
    {
      "id": "sketchupVersion",
      "type": "pickString",
      "description": "SketchUp Version",
      "options": [
        "2021",
        "2020",
        "2019",
        "2018",
        "2017"
      ],
      "default": "2021"
    }
  ]
}

While we figure this out, a workaround is to use a task that starts SU directly:
{
  // See https://go.microsoft.com/fwlink/?LinkId=733558
  // for the documentation about the tasks.json format
  "version": "2.0.0",
  "tasks": [
    {
      "label": "open SU",
      "type": "shell",
      "command": "open",
      "args": [
        "-a",
        "/Applications/SketchUp 2021/SketchUp.app",
        "--args",
        "-rdebug",
        "ide port=7000",
      ],
      "runOptions": {
        "reevaluateOnRerun": false
      },
      "problemMatcher": [],
      "isBackground": false,
    },
    {
      "label": "Launch SketchUp in Ruby Debug mode",
      "type": "shell",
      "command": "skippy",
      "args": [
        "sketchup:debug",
        "${input:sketchupVersion}"
      ],
      "runOptions": {
        "reevaluateOnRerun": false
      },
      "problemMatcher": [],
      "isBackground": false,
    }
  ],
  "inputs": [
    {
      "id": "sketchupVersion",
      "type": "pickString",
      "description": "SketchUp Version",
      "options": [
        "2021",
        "2020",
        "2019",
        "2018",
        "2017"
      ],
      "default": "2021"
    }
  ]
}

Yep -- that seems to start sketchup.  I've not gotten breakpoints to work yet, but I can now start sketchup when I run the task. I admit, this is my first time trying to develop in Sketchup via Visual Code, so maybe I'm missing something very basic.
I was assuming it would be enough for me to set a breakpoint, and run the method, either from the extension drop-down, or from the ruby console, but it doesn't break on the breakpoints that I've set.

Yep -- that seems to start sketchup.  I've not gotten breakpoints to work yet, but I can now start sketchup when I run the task. I admit, this is my first time trying to develop in Sketchup via Visual Code, so maybe I'm missing something very basic.
I was assuming it would be enough for me to set a breakpoint, and run the method, either from the extension drop-down, or from the ruby console, but it doesn't break on the breakpoints that I've set.

Because the debugging is a remote sessions (since it's running inside SU and not VSCode) we first need to launch SU with the debug command line args to enable the debugger. Then once SU has started you need to attach the debugger (From the Run) tab in VSCode).
Then your breakpoints should trigger when you execute the code with the breakpoint.
Did you attach the debugger after launching SU in your testing?

I suspect at this point I'm just doing something wrong because I'm new to this environment.  After I run the task, I do see the following in the TERMINAL output window:
> Executing task: open -a '/Applications/SketchUp 2021/SketchUp.app' --args -rdebug 'ide port=7000' <

And SU opens, and I can load a model, etc.  In VSCode, I do see the Start Debugging option under Run.  But once I do that I now see an error message in the DEBUG CONSOLE in VSCode:
Debugger error: Client: Error: connect ECONNREFUSED <IP_ADDRESS>:7000

When looking at my process list:
habermeier-macbookpro2% ps aux | grep -i sketc
habermeier       56184   0.0  0.3  4668252  49524   ??    S    12:13PM   0:16.09 /Applications/SketchUp 2021/SketchUp.app/Contents/MacOS/SketchUp -rdebug ide port=7000

I see that it appears SketchUp was run with -rdebug ide port=7000, which appears to be what we want, but when I look at all open TCP sockets for the SU processes running, I don't see an open 7000 port that would be listening for connections:
habermeier-macbookpro2% lsof -P -p 56184,56181 -a -i TCP
COMMAND    PID       USER   FD   TYPE             DEVICE SIZE/OFF NODE NAME
SketchUp 56181 habermeier   65u  IPv4 0xd1cff2513ea4a1fb      0t0  TCP macbook-pro.localdomain:63185->lax17s34-in-f19.1e100.net:80 (CLOSED)
SketchUp 56181 habermeier   69u  IPv4 0xd1cff2513bcef45b      0t0  TCP macbook-pro.localdomain:63187->ec2-35-155-205-123.us-west-2.compute.amazonaws.com:443 (CLOSED)
SketchUp 56181 habermeier   77u  IPv4 0xd1cff2513ea47a7b      0t0  TCP macbook-pro.localdomain:63188->server-13-227-73-55.sfo20.r.cloudfront.net:443 (CLOSED)
SketchUp 56181 habermeier   78u  IPv4 0xd1cff251434e7a7b      0t0  TCP macbook-pro.localdomain:63189->lax17s34-in-f19.1e100.net:80 (CLOSED)

Implying that the Sketchup is ignoring the -rdebug command? or something... so, yeah... still no debugging for me!

Any firewall or anything that could be blocking the ports?

well... unless I'm getting the commands wrong, I was looking for what processes have an open TCP port 7000... and came up with nothing.  Ie: no process is listening on that port.  A firewall might prevent a connection from getting made, but it would not prevent the a process from starting and listening on that port, right?
I am running this on a corporate Mac, so, there could be something going on from a security perspective, but again -- I'm seeing 2 processes when sketchup starts.  The first one: PID: 56181 looks like it's the entry-point / shell that subsequently forks a new process with PID: 56184.  I might have expected PID 56181 to pass some argument down to 56184 with the debugging port number, but I'm speculating...
I looked at /Users/habermeier/Library/Application Support/SketchUp 2021/WebCache/debug.log which is kinda busy, but didn't see anything that jumped out at me straight up.
Is there more information I can look up about -rdebug 'ide port=7000'?  Seems like something is going wrong somewhere with that....

Is there more information I can look up about -rdebug 'ide port=7000'? Seems like something is going wrong somewhere with that....

We have the source code here. You could try building it and set a break point to see what happens when it initializes.
https://github.com/SketchUp/sketchup-ruby-debugger
I'm more familiar with Windows, so I'm not sure exactly what to suggest. I don't see anything in your setup that raises any flags.
On Windows I would have suggested using ProcessExplorer to inspect whether the Ruby Debugger DLL is in fact loaded. Any are familiar with similar tool for mac?


.then() not called on some object type?

I have this code which use kurento-client library and I have the below code.
However, the .then() is not called at all if I resolve using _kurentoClient object but this have no problem at all with other objects.
getKurentoClient()
        .then(function (kurentoClient) {
            console.log('connect to kurento');
            // setup conference io
            conference(kurentoClient, socketio);
            presenter(kurentoClient, socketio);
        })
        .catch(function (error) {
            console.log(error);
        });

function getKurentoClient() {
    return new Promise(function (resolve, reject) {
        kurento(argv.ws_uri, function (error, _kurentoClient) {
            if (error) {
                var message = 'Coult not find media server at address ' + argv.ws_uri;
                reject(message + ". Exiting with error " + error);
            }

            // kurentoClient = _kurentoClient;
            resolve(_kurentoClient);
        });
    });
}

Here is the screenshot for properties on _kurentoClient

It would be awesome of you if you could upload a reproducing sample to GitHub and help isolate the issue further. The object looks like it tried to implement the promise API (it has a then) but it does so poorly - so bluebird waits for its then to resolve.
Can you try doing delete _kurentoClient.then  and see if it starts working because of that?

yeah after delete _kurentoClient.then it is start working.

@sainttail this is not a bluebird specific issue then, when promises resolve other promises or things with then (aka thenables, like _kurentoClient in this case) - they have to wait for it to call then itself.
This is called assimilation. Basically, your then would be called after _kurentoClient has itself resolved. If you want to resolve with something that's a promise but don't want to resole it (usually, you do) you should wrap it in an object, for example resolve({_kurentoClient}) and then .then(({_kurentoClient})  => {.... Or in ES5 notation resolve({_kurentoClient:_kurentoClient}) and similarly in the handler.
Thanks for the report.

To add a note, I guess that this commit fixes this problem, right?


use Django<1.9 rather than Django>=1.8.0 in base.txt.

Coverage remained the same at 96.178% when pulling 0036a479de860a1e4bf1cb02883ecbd2cb3ac350 on ramiro:bugfix/dont-user-django-newer-than-18 into 5141ed0bd0ffbdf98d09e5c8a24845d18c166cd8 on jlmadurga:master.


chore: Add a README file for the playground

What it solves
As the playground is starting to grow, this PR:

creates a new README file for the playground
adds new steps to install and build the project before runing the scripts
ads a description for each script

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+6.1%) to 81.053%

Totals

Change from base Build<PHONE_NUMBER>:
6.1%

Covered Lines:
55

Relevant Lines:
63

💛  - Coveralls


WIP: Eliminate some EVP_PKEY_size() uses

The documentation for EVP_DigestSign() and EVP_DigestSignFinal() says this about EVP_PKEY_size():

The use of EVP_PKEY_size() with these functions is discouraged because some signature operations may have a signature length which depends on the parameters set. As a result EVP_PKEY_size() would have to return a value which indicates the maximum possible signature for any set of parameters.

And yet, we use it together with those functions in our code.  This PR tries to eliminate those uses.

This is in WIP because I haven't dared touch the libssl code:
$ git grep EVP_PKEY_size ssl
ssl/statem/statem_clnt.c:        maxsig = EVP_PKEY_size(pkey);
ssl/statem/statem_lib.c:    siglen = EVP_PKEY_size(pkey);
ssl/statem/statem_lib.c:    j = EVP_PKEY_size(pkey);
ssl/statem/statem_srvr.c:        siglen = EVP_PKEY_size(pkey);
ssl/statem/statem_srvr.c:    if (EVP_PKEY_size(rsa) < RSA_PKCS1_PADDING_SIZE

@mattcaswell, would you mind having a look at that?

@mattcaswell, would you mind having a look at that?

  Thanks :-)

Travis error not relevant

Final review?

Travis failure not relevant.  Final review?

And now there is a merge conflict.

Yay...


fix: no FOUC and broken layout caused by CSS

Codecov Report

Merging #58 (150fa62) into master (0707006) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
+ Coverage   93.22%   93.32%   +0.10%
==========================================
  Files          15       15
  Lines        1180     1198      +18
==========================================
+ Hits         1100     1118      +18
  Misses         80       80

Impacted Files
Coverage Δ

packages/editor-base/index.js
96.47% <100.00%> (+0.23%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0707006...150fa62. Read the comment docs.


docs: Missing step to include _fanOutTopCards inside acquireCard in Klondike tutorial

What could be improved

After following Klondike tutorial upto step 4. gameplay, I noticed that the cards in wastePile is not panned out after clicking stockPile, rather the three cards are all stacked on top of each other as before. After checking the provided code at the bottom of the page I noticed the document has missing information to incude _fanOutTopCards(); at the end of acquireCard() function.
Maybe adding a code snippet to show that _fanOutTopCards() also needed to be added here:
https://github.com/flame-engine/flame/blob/fa9665a566ac95869891199ff3eb449acf7c5005/doc/tutorials/klondike/step4.md?plain=1#L751-L760
Why should this be improved

This would result the code bases the same as the expected outcome provided on the website, so the new users can easily follow the tutorial.
Any risks?

No
More information

It looks that the _fanOutTopCards() is only included in the functions below:

removeCard()
returnCard()

and the tutorial I followed is from the main branch.

Sounds reasonable, right @IanWadham?
Do you want to provide a PR with the fix @qmffkem? :)

haha 😅 I feel like i'm keep stumbling myself all again.
Here in line from 117-119 already mentioned that I need to include the function at the end of the acquireCard() function,
https://github.com/flame-engine/flame/blob/fa9665a566ac95869891199ff3eb449acf7c5005/doc/tutorials/klondike/step4.md?plain=1#L117-L119
But I totally missed reading this section and focused reading the bottom section where the code block associated to ADT exist and looked for a problem..
Sorry for confusion @spydon and @IanWadham 😅


feat: add options.getChildBindings()

Related suggestion issue: https://github.com/pinojs/hapi-pino/issues/86
This PR adds an optional options.getChildBindings(request) => Pino.Bindings function to the hapi-pino options object.
This allows you to customize the bindings being passed into logger.child(), which was previously hardcoded to always be { req: request }
If omitted, it keeps the old behavior of { req: request }
    const plugin = {
      plugin: Pino,
      options: {
        stream: stream,
        level: 'info',
        getChildBindings: (req) => ({ custom: true })
      }
    }

    await server.register(plugin)

Coverage decreased (-0.02%) to 98.86% when pulling b356e284722e2fa52e931a39bec383e14a674c09 on devshackio:feat-getChildBindings into 45ecfec80cccdb273ce77a74ee2539ae730fd1d8 on pinojs:master.


attrs 23.1.0

Current package info

Channel
Downloads
Version
Platforms
License

defaults

Changelog:
License:
Requirements:
Actions:
1.

Linter check found the following problems:
The following problems have been found:
ERROR: clone/recipe/meta.yaml:1: patch_must_be_in_build: patch must be in build when source/patches is set.
ERROR: clone/recipe/meta.yaml:23: missing_wheel: For pypi packages, wheel should be present in the host section
Errors were found

Linter check found the following problems:
The following problems have been found:
ERROR: clone/recipe/meta.yaml:26: missing_wheel: For pypi packages, wheel should be present in the host section
Errors were found

Linter check found the following problems:
The following problems have been found:
ERROR: clone/recipe/meta.yaml:26: missing_wheel: For pypi packages, wheel should be present in the host section
Errors were found


UI: add option to see the Prompt history per session

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the feature you'd like
A clear and concise description of what you want to happen.
Additional context
Add any other context or screenshots about the feature request here.

@subha-aws thanks for reaching out. We will add this feature request to our backlog.


deploy huggingface space

Can this project be deployed on Hugging Face Space for easy access and experience by everyone?

I would love to! We were waiting on a few changes to the audio streaming, but I think they were released already. Next week we could make this happen, wdyt @eustlb ?

Sure thing, the latest Gradio release does make streaming audio possible, and we already have examples of spaces that do this. Let’s definitely plan to implement this next week, it’ll be a great feature to demonstrate in upcoming demos.

Theoretically, a standalone HF endpoint could be made of this repo that could work with a locally (low resource) running gradio by inserting that HF endpoint?

I'm working on this since yesterday :)


Question: Does kendo grid support to select by property name

Hello,
I'm trying to select row in a kendo grid using the property value equals some value. Can you please help on how i can do that?
Thanks.

Please check Table component. As KendoGrid inherits Table, the approaches are similar.
Here is a sample, for case when you need to find rows by cell value:
using Atata;
using Atata.KendoUI;

namespace SampleApp.UITests
{
    using _ = SamplePage;

    public class SamplePage : Page<_>
    {
        public KendoGrid<ItemRow, _> Grid { get; private set; }

        public class ItemRow : KendoGridRow<_>
        {
            public Text<_> Name { get; private set; }

            public Number<_> Amount { get; private set; }

            // etc...
        }
    }
}

And in test method:
Go.To<SamplePage>().
    Grid.Rows[x => x.Name == "Item 1"].Amount.Should.Equal(5);

Is it what you were looking for?

I tried using the same approach, but it always says no such element exception.
The grid contains around 12 rows and i'm trying to select a row based on cell value.
.SearchResults.Rows[x=> x.FullName== "XXXX, XXX"]
OpenQA.Selenium.NoSuchElementException : Unable to locate element: Full Name
Context element:
Tag: tr
Location: {X=242,Y=713}
Size: {Width=1208, Height=34}
Text: XXXX XXXXX XXXX, XXX
The exception text shows only the row data and not the column name , column text.

I see. By default cell is searched by grid column header. In your case it was looking for "Full Name" column header. If you have different name you can try:
public class ItemRow : KendoGridRow<_>
{
    [FindByColumnHeader("Custom Fullname")]
    public Text<_> FullName { get; private set; }
}

Or you can also use FindByColumnIndex passing the column index:
public class ItemRow : KendoGridRow<_>
{
    [FindByColumnIndex(0)]
    public Text<_> FullName { get; private set; }
}

Awesome!!! FindByColumnHeader worked like charm. Thanks for the quick replies.


Locale from jsx/tsx files

It seems to me from reading the file loader.js inside nextra that jsx files, such as no.en.jsx, are allowed. But even though No appears on the navigation sidebar, clicking it leads to 404 (since the route is   no). If however only no.jsx is created Nextjs takes over and it renders correctly.
I don't know what the real intention here is. It seems to me if a file ends with jsx or tsx then the locale problem is perhaps treated directly by some logic inside the file itself (instead of having different files with essentially the same logic, layout etc.)? In that case would it be better to remove jsx as currently done inside loader.js?
On the other hand, if something such as no.en.jsx is indeed what's wanted then some fix should be done, and tsx should be allowed also. I've played a bit with the code and here's
the branch:
https://github.com/gr-qft/nextra/tree/fix/jsx-tsx-files
Please let me know.

Use md/mdx files instead


ec2_vpc_routetable produces "expected params[:internet_gateway_ids][0] to be a string" error

Whenever I use the ec2_vpc_routetable function I receive the error:
Debug: Prefetching v2 resources for ec2_vpc_routetable
Debug: Storing state
Debug: Stored state in 0.01 seconds
Debug: Using settings: adding file resource 'rrddir': 'File[/var/lib/puppet/rrd]{:path=>"/var/lib/puppet/rrd", :mode=>"750", :owner=>"puppet", :group=>"puppet", :ensure=>:directory, :loglevel=>:debug, :links=>:follow, :backup=>false}'
Debug: Finishing transaction 29631360
Debug: Received report to process from xxx.compute.internal
Debug: Processing report from xxx.compute.internal with processor Puppet::Reports::Store
Error: Could not run: Puppet detected a problem with the information returned from AWS
when looking up ec2_vpc_routetable in ap-southeast-2. The specific error was:

expected params[:internet_gateway_ids][0] to be a string

Rather than report on ec2_vpc_routetable resources in an inconsistent state we have exited.
This could be because some other process is modifying AWS at the same time.

Have tried a number of different class names,etc. and always end up receiving this error. Any idea what might be causing it and how to fix it.

Do you see this when running puppet resource or when running against a manifest? If the latter would you be able to post a gist of your manifest?
This might be the module being too heavy on the validation for the specific param.

I had the same problem. It's triggered when a route table includes a route to a NAT instance. Here's a partial response from aws ec2 describe-route-tables showing a NAT route, which lacks the expected GatewayId property:
...
  {
      "GatewayId": "local",
      "DestinationCidrBlock": "<IP_ADDRESS>/8",
      "State": "active",
      "Origin": "CreateRouteTable"
  },
  {
      "Origin": "CreateRoute",
      "DestinationCidrBlock": "<IP_ADDRESS>/0",
      "InstanceId": "i-abcd1234",
      "NetworkInterfaceId": "eni-abcd1234",
      "State": "active",
      "InstanceOwnerId": "954578106580"
  }
...

Here's my quick and dirty patch to avoid the exception: https://github.com/rfletcher/puppetlabs-aws/commit/0b96095a5c8e1756cd07a20df129a899a7c30149

I had the same problem. It's triggered when a route table includes a route to a NAT instance. Here's a partial response from aws ec2 describe-route-tables showing a NAT route, which lacks the expected GatewayId property:
...
  {
      "GatewayId": "local",
      "DestinationCidrBlock": "<IP_ADDRESS>/8",
      "State": "active",
      "Origin": "CreateRouteTable"
  },
  {
      "Origin": "CreateRoute",
      "DestinationCidrBlock": "<IP_ADDRESS>/0",
      "InstanceId": "i-abcd1234",
      "NetworkInterfaceId": "eni-abcd1234",
      "State": "active",
      "InstanceOwnerId": "01234567890"
  }
...

Here's my quick and dirty patch to avoid the exception: https://github.com/rfletcher/puppetlabs-aws/commit/0b96095a5c8e1756cd07a20df129a899a7c30149

rfletcher - Thanks. Your patch did the trick and got rid of the error.
I've hit another problem, but I'll create a new issue for it if I can't find any other issues that have been raised against it.

I'll keep this open until we get chance to fix in the main codebase. Thanks for the discussion and report, much appreciated.

+1

+1

+1

The patch from @rfletcher works for me. @rfletcher are you going to do a PR or should I? I don't want to take credit for this fix but would like to see it in the upstream soon.

@daveseff Did you try the fix in PR #190? That's already been merged. (The error message was the same there, but I don't recall if that change resolved this issue.)

Thanks. I was working on a system that has been up for a while so it may not have had that PR fix yet. I think we're all good now.

@lynxdigital @rfletcher @daveseff I'm doing some house cleaning. I believe this was fixed by #190. Can I close this issue?


About training details

Dear author:
Regarding the training details, I have the following questions?

How many image data are used to train emoji? I saw only 13 images in data/emoji/train and logs in the training. Will you also train with these data?
Is the training process completely end-to-end? And do I need to set other configurations in the yaml file in config in order to train with better results? Did you follow the training in the yaml file?
I run CUDA_VISIBLE_DEVICES=1 python run.py -c configs/emoji.yaml， and I have trained 2100 epochs so far, and the loss does not seem to decrease practically.

Epoch 02177: val_loss  was not in top 1
Epoch 2178: 100%|█| 13/13 [00:11<00:00,  1.10it/s, loss=3.677, v_num=110, Reconstruction_Loss=3.67, KLD=0, aux_loss=0, other losses=0beta:  0.0
learning rate:  0.0001

Epoch 02178: val_loss  was not in top 1
Epoch 2179: 100%|█| 13/13 [00:13<00:00,  1.03s/it, loss=3.731, v_num=110, Reconstruction_Loss=3.59, KLD=0, aux_loss=0, other losses=0beta:  0.0
learning rate:  0.0001

Epoch 02179: val_loss  was not in top 1
Epoch 2180: 100%|█| 13/13 [00:13<00:00,  1.01s/it, loss=3.689, v_num=110, Reconstruction_Loss=3.56, KLD=0, aux_loss=0, other losses=0beta:  0.0
learning rate:  0.0001

Epoch 02180: val_loss  was not in top 1
Epoch 2181: 100%|█| 13/13 [00:12<00:00,  1.00it/s, loss=3.693, v_num=110, Reconstruction_Loss=3.33, KLD=0, aux_loss=0, other losses=0beta:  0.0
learning rate:  0.0001

reconstruction

Is this result normal? Is this due to the small training data set? Or yaml file configuration?

Hey @DYF-AI
i) Yes there are only a few images in the emojis dataset.
ii) Yes the training process is end-to-end. Could try training by setting https://github.com/preddy5/Im2Vec/blob/master/configs/emoji.yaml#L13 to 0
iii) Also it looks like you only have 2 curves can you recheck if https://github.com/preddy5/Im2Vec/blob/master/models/vector_vae_nlayers.py#L44 has 4 colors and 4 colors correspond to the ones in the dataset. No the results should look better. Refer to https://github.com/preddy5/Im2Vec/tree/master/logs/VectorVAEnLayers/version_110 for an example training run.

Thank you very much for your reply, your suggestion is very effective：
ii) Yes the training process is end-to-end. Could try training by setting https://github.com/preddy5/Im2Vec/blob/master/configs/emoji.yaml#L13 to 0

This is the result of 185 epochs, which is much better than before，thank...

Hey, Dear Author
Epoch 401: 100%|██████████████| 13/13 [00:07<00:00,  1.83it/s, loss=0.170, v_num=110, Reconstruction_Loss=0.0777, KLD=0, aux_loss=0, other losses=0]beta:  0.0
learning rate:  0.00029936846961918924
I have another question. I saw KLD=0, aux_loss=0, other losses=0 during training. Do these losses need to be turned on during training? In other words, will the result be better after turning it on?

Hey @DYF-AI
KLD is the KL divergence loss like in a VAE
aux_loss is for the auxiliary network we discussed in the main paper.
other losses is the loss term to encourage minimal surface area for the curves.
using other_losses term after 500 epoch will improve the results a tiny bit, KLD and aux should not affect your results.

Okay, thank you very much for your reply, this is a very interesting and meaningful project, thanks. I want to use path-to-path to generate fonts based on this project...

@DYF-AI you are welcome. All the best with the project :)


Remove use of cssText in react-focus-guards

Description
createFocusGuard creates a <span>, then applies CSS to it using cssText. This violates Content-Security-Policy unless style-src: 'unsafe-inline' is permitted. Setting the individual properties is acceptable under a strict CSP.

@iliana I'd like to include this in the next release. Do you mind running yarn version check --interactive so everything is versioned correctly and captured in the changelog?

I'm not familiar with yarn, so I'm not sure why this doesn't work:
$ yarn version check --interactive
Usage Error: Your current branch contains multiple versioning files; this isn't supported:
- /Users/iliana/git/primitives/.yarn/versions/19bdd400.yml
- /Users/iliana/git/primitives/.yarn/versions/2ab74363.yml
- /Users/iliana/git/primitives/.yarn/versions/41451f5a.yml
- /Users/iliana/git/primitives/.yarn/versions/5793010b.yml
- /Users/iliana/git/primitives/.yarn/versions/8a3bd6ee.yml
- /Users/iliana/git/primitives/.yarn/versions/96c502e7.yml
- /Users/iliana/git/primitives/.yarn/versions/a0df87d9.yml
- /Users/iliana/git/primitives/.yarn/versions/a54ad5a9.yml
- /Users/iliana/git/primitives/.yarn/versions/c80771b8.yml
- /Users/iliana/git/primitives/.yarn/versions/cc138cf5.yml
- /Users/iliana/git/primitives/.yarn/versions/cccc0adb.yml
- /Users/iliana/git/primitives/.yarn/versions/dc4b1017.yml
- /Users/iliana/git/primitives/.yarn/versions/ded3a040.yml
- /Users/iliana/git/primitives/.yarn/versions/e97b6ff3.yml
- /Users/iliana/git/primitives/.yarn/versions/eb020608.yml
- /Users/iliana/git/primitives/.yarn/versions/f24f9512.yml
- /Users/iliana/git/primitives/.yarn/versions/f4333956.yml
- /Users/iliana/git/primitives/.yarn/versions/fad3e42d.yml

It seems like my yarn version is correct per the value in package.json:
$ yarn --version
4.1.0

Evidently the merge from main caused the issue, yarn doesn't seem to be able to handle that. I rebased instead.


Emoji Request: Test issue please ignore

Scratch Username: test
Official Emoji Name: test
Unicode codepoint: test
Link to emoji (On cubeupload or assets): test

Sorry, was just testing github rest api and grep and needed this issue

please keep this issue open, i will close it when I finish testing

I'm assuming this test is done now?


[HxGrid] Add support for load more pagination

HxGrid supports only classic pagination and infinite scrolling. Is it possible to add support for "load more" pagination?

Note:

it works well together - Pagionation and LoadMore (like Alza.cz, czc.cz, etc.)
I do not expect Pager and LoadMore to be used at one in production (line 250 in HxGrid.razor.cs could be reverted)
LoadMoreTemplate uses context to provide access to method to load more data (despite our discussion, @hakenr)
LoadMoreContext solves well current requirement: to be able to render grids in "repeater" way - to use context is much easier over @ ref + this does not block using LoadMoreAsync on HxGrid (which is also there as internal), thanks @alexax578.
think: If we never use pager with load more, we can load any number of aditional items, they do not need to be aligned with page size (not implemented but slightly required by JN)

FYI, @Allegon

TODOs before release:

[ ] LoadMore button configurability (LoadMoreButtonSettings? LoadMoreButtonText?) @hakenr after discussion with @crdo
[ ] visual tuning of the default UX (button text (dot? no dots?), button justification?, button size?, button color?, ...) @crdo
[ ] add to documentation - basic demo + short description
[ ] naming of the GridLoadMoreTemplateContext.LoadMoreAsync() method. Should it be HandleLoadMoreClick?
[ ] co-existence with pager (do we want separate modes? do we want a parameter to be able to enable/disable pager for LoadMore mode?)
[ ] configurable number of items to load (I'm OK not to support custom number of items, but if there is a chance we will have to add this later, we should adjust the API accordingly. E.g. GridUserState.LoadMorePagesCount vs. LoadMoreItemsCount, etc.)

TODOs any later:

[ ] add documentation (demo) for customizability (LoadMoreTemplate, button settings, ...)

(I will probably create a pre-release now, just to be able to play it with in our projects. cc @alexax578 @Allegon @Arnnes)

naming of the GridLoadMoreTemplateContext.LoadMoreAsync() method. Should it be HandleLoadMoreClick?

From my perspective: No.

co-existence with pager (do we want separate modes? do we want a parameter to be able to enable/disable pager for LoadMore mode?)

I don't think so. Even the Load More can co-existence with pager now (due to the inspiration), I am not keen on seeing it.

configurable number of items to load (I'm OK not to support custom number of items, but if there is a chance we will have to add this later, we should adjust the API accordingly. E.g. GridUserState.LoadMorePagesCount vs. LoadMoreItemsCount, etc.)

Good point, lets do it this way.

This commit has a minor change, when no paging is used, the GridDataProviderRequest.Count property is null now, previously it was zero (by mistake).
GridDataProviderRequest.Count property type was NOT changed, it was and still is Nullable<int>.

@crdo The demo is ready in HxGrid_Demo_LoadMore.razor (BTW: On my way to consolidate the demos with help of IDemoDataService.)
Can you please try to align the button to the center in the demo (just by using the .razor file, no external CSS). I just want to see how complicated it is to do so to help me decide whether it is easy and we can leave it as is or if it implies some complicated CSS/HTML (in such case I would suggest to go for some additional API support for such customization).
Thank you!

@hakenr If you think there would be a need for one of styling in a specific .razor file instead of a global rule we would have to create LoadMoreCssClass.


Add IDs to CHCs

This PR adds IDs to CHCs emitted by the parser. This helps us correlate CHCs processed through separate tools more easily.

Fixes #105.


Remove public visibility of program cache from bank

Problem
Public visibility of Bank::loaded_programs_cache is making it difficult to encapsulate cache within SVM API boundary.
Summary of Changes
Remove public visibility and provide necessary accessors from bank.
Fixes #

Codecov Report
Attention: Patch coverage is 81.81818% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 81.9%. Comparing base (87a0071) to head (095fe5b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master     #279     +/-   ##
=========================================
- Coverage    81.9%    81.9%   -0.1%
=========================================
  Files         837      837
  Lines      226793   226804     +11
=========================================
- Hits       185830   185825      -5
- Misses      40963    40979     +16


Add support for better file download urls with HTTP Range requests + …

…streaming
curl -H "range: bytes=0-3,-2" http://<IP_ADDRESS>:3000/file/2/hello.txt

Fixes #34
Fixes #8
Fixes #9

I don't believe this issue should close #34

I agree.. reedited to mention #30 thanks @jkeck

:shakes-fist: autocomplete, ugh.


feat: set extra parameter

https://dash.applovin.com/documentation/mediation/android/getting-started/data-passing#unified-identifiers
https://dash.applovin.com/documentation/mediation/ios/getting-started/data-passing#unified-identifiers

@amondnet, let me handle my comments about your PR.   Your changes are fine, but we have some internal coding conventions.  I'll submit another PR based on your PR.

@amondnet, merged your PR.   Thanks!!!