ENTRY_CREATE event not always emitted after renaming subfolder - WatchService

What are you trying to do?
The ENTRY_CREATE event (java.nio.file.WatchService) is not always emitted when creating subfolder in the watched directory, renaming it and copying file there.
This weird behaviour was observed in the project which is using Sprint Integration library:
https://github.com/pziobron/spring-integration-create-notification-bug
and initially the bug has been reported for that Spring library here:
https://github.com/spring-projects/spring-integration/issues/9146
However, it turned out this is related to the JDK, not to that library...
This is only reproducible on Mac (reproduced for Temurin-17.0.9+9 and Temurin-17.0.11+9).
I've tried to reproduce it also on MAC using the different version of JDK:
IMPLEMENTOR="Oracle Corporation"
JAVA_VERSION="<IP_ADDRESS>"
JAVA_VERSION_DATE="2022-08-18"
but it is working fine....
Expected behaviour:
The ENTRY_CREATE should be always emitted when renaming the subfolder of the watched directory and copying file there.
I haven't managed to reproduce it on Windows.
Observed behaviour:
To Reproduce

Configure FileReadingMessageSource in the following way:
FileReadingMessageSource messageSource = new FileReadingMessageSource();
messageSource.setDirectory(new File(inputDirectory));
messageSource.setUseWatchService(true);
messageSource.setWatchEvents(CREATE, MODIFY, DELETE);

Configure a simple flow that simply deletes the file

Prepare a file with minimum size of 17 KB (test.zip)

Configure logger for org.srpingframework.integration.file package (DEBUG level)

Execute the following command in the shell inside the watched directory:
mkdir b1; sleep 2; mv b1 b2; sleep 3; cp /Users/patryk.ziobron/sandbox/test/test.zip b2/; sleep 2; mkdir b3; sleep 2; mv b3 b4; sleep 3; cp /Users/patryk.ziobron/sandbox/test/test.zip b4/; sleep 2; mkdir b5; sleep 2; mv b5 b6; sleep 3; cp /Users/patryk.ziobron/sandbox/test/test.zip b6/; sleep 2; mkdir b7; sleep 2; mv b7 b8; sleep 3; cp /Users/patryk.ziobron/sandbox/test/test.zip b8/; sleep 2;

The ENTRY_CREATE is not emitted for all files (in the example below, it is only emitted for b4 folder and missing for b2, b6 and b8):
2024-05-17 10:44:08.150 [main] DEBUG o.s.i.file.FileReadingMessageSource - registering: /Users/patryk.ziobron/sandbox/input for file events 2024-05-17 10:44:11.178 [scheduling-1] DEBUG o.s.i.file.FileReadingMessageSource - Watch event [ENTRY_CREATE] for file [/Users/patryk.ziobron/sandbox/input/b1] 2024-05-17 10:44:11.179 [scheduling-1] DEBUG o.s.i.file.FileReadingMessageSource - registering: /Users/patryk.ziobron/sandbox/input/b1 for file events 2024-05-17 10:44:13.167 [scheduling-1] DEBUG o.s.i.file.FileReadingMessageSource - Watch event [ENTRY_CREATE] for file [/Users/patryk.ziobron/sandbox/input/b2] 2024-05-17 10:44:13.168 [scheduling-1] DEBUG o.s.i.file.FileReadingMessageSource - registering: /Users/patryk.ziobron/sandbox/input/b2 for file events 2024-05-17 10:44:13.169 [scheduling-1] DEBUG o.s.i.file.FileReadingMessageSource - Watch event [ENTRY_DELETE] for file [/Users/patryk.ziobron/sandbox/input/b1] 2024-05-17 10:44:17.171 [scheduling-1] DEBUG o.s.i.file.FileReadingMessageSource - Watch event [ENTRY_MODIFY] for file [/Users/patryk.ziobron/sandbox/input/b2] 2024-05-17 10:44:19.167 [scheduling-1] DEBUG o.s.i.file.FileReadingMessageSource - Watch event [ENTRY_CREATE] for file [/Users/patryk.ziobron/sandbox/input/b3] 2024-05-17 10:44:19.167 [scheduling-1] DEBUG o.s.i.file.FileReadingMessageSource - registering: /Users/patryk.ziobron/sandbox/input/b3 for file events 2024-05-17 10:44:21.164 [scheduling-1] DEBUG o.s.i.file.FileReadingMessageSource - Watch event [ENTRY_CREATE] for file [/Users/patryk.ziobron/sandbox/input/b4] 2024-05-17 10:44:21.164 [scheduling-1] DEBUG o.s.i.file.FileReadingMessageSource - registering: /Users/patryk.ziobron/sandbox/input/b4 for file events 2024-05-17 10:44:21.165 [scheduling-1] DEBUG o.s.i.file.FileReadingMessageSource - Watch event [ENTRY_DELETE] for file [/Users/patryk.ziobron/sandbox/input/b3] 2024-05-17 10:44:23.170 [scheduling-1] DEBUG o.s.i.file.FileReadingMessageSource - Watch event [ENTRY_MODIFY] for file [/Users/patryk.ziobron/sandbox/input/b4] 2024-05-17 10:44:24.170 [scheduling-1] DEBUG o.s.i.file.FileReadingMessageSource - Watch event [ENTRY_CREATE] for file [/Users/patryk.ziobron/sandbox/input/b4/test.zip] 2024-05-17 10:44:24.171 [scheduling-1] DEBUG o.s.i.file.FileReadingMessageSource - Added to queue: [/Users/patryk.ziobron/sandbox/input/b4/test.zip] 2024-05-17 10:44:24.177 [Thread_5] INFO  o.s.i.handler.LoggingHandler - GenericMessage [payload=/Users/patryk.ziobron/sandbox/input/b4/test.zip, headers={sourceCountry=global, feedName=reuters, file_name=test.zip, targetPath=data, file_originalFile=/Users/patryk.ziobron/sandbox/input/b4/test.zip, source=Global_Relay, priority=5, file_relativePath=b4/test.zip, uncompress=true, sieve=true, id=ed14f9ab-335f-b547-58db-0aa4b735dac5, decrypt=false, sourcePath=/Users/patryk.ziobron/sandbox/input, remoteFeedName=reuters, timestamp=1715935464177}] 2024-05-17 10:44:25.172 [scheduling-1] DEBUG o.s.i.file.FileReadingMessageSource - Watch event [ENTRY_CREATE] for file [/Users/patryk.ziobron/sandbox/input/b5] 2024-05-17 10:44:25.172 [scheduling-1] DEBUG o.s.i.file.FileReadingMessageSource - registering: /Users/patryk.ziobron/sandbox/input/b5 for file events 2024-05-17 10:44:25.172 [scheduling-1] DEBUG o.s.i.file.FileReadingMessageSource - Watch event [ENTRY_MODIFY] for file [/Users/patryk.ziobron/sandbox/input/b4] 2024-05-17 10:44:26.172 [scheduling-1] DEBUG o.s.i.file.FileReadingMessageSource - Watch event [ENTRY_DELETE] for file [/Users/patryk.ziobron/sandbox/input/b4/test.zip] 2024-05-17 10:44:27.168 [scheduling-1] DEBUG o.s.i.file.FileReadingMessageSource - Watch event [ENTRY_CREATE] for file [/Users/patryk.ziobron/sandbox/input/b6] 2024-05-17 10:44:27.168 [scheduling-1] DEBUG o.s.i.file.FileReadingMessageSource - registering: /Users/patryk.ziobron/sandbox/input/b6 for file events 2024-05-17 10:44:27.169 [scheduling-1] DEBUG o.s.i.file.FileReadingMessageSource - Watch event [ENTRY_DELETE] for file [/Users/patryk.ziobron/sandbox/input/b5] 2024-05-17 10:44:31.166 [scheduling-1] DEBUG o.s.i.file.FileReadingMessageSource - Watch event [ENTRY_MODIFY] for file [/Users/patryk.ziobron/sandbox/input/b6] 2024-05-17 10:44:33.166 [scheduling-1] DEBUG o.s.i.file.FileReadingMessageSource - Watch event [ENTRY_CREATE] for file [/Users/patryk.ziobron/sandbox/input/b7] 2024-05-17 10:44:33.166 [scheduling-1] DEBUG o.s.i.file.FileReadingMessageSource - registering: /Users/patryk.ziobron/sandbox/input/b7 for file events 2024-05-17 10:44:35.169 [scheduling-1] DEBUG o.s.i.file.FileReadingMessageSource - Watch event [ENTRY_CREATE] for file [/Users/patryk.ziobron/sandbox/input/b8] 2024-05-17 10:44:35.169 [scheduling-1] DEBUG o.s.i.file.FileReadingMessageSource - registering: /Users/patryk.ziobron/sandbox/input/b8 for file events 2024-05-17 10:44:35.169 [scheduling-1] DEBUG o.s.i.file.FileReadingMessageSource - Watch event [ENTRY_DELETE] for file [/Users/patryk.ziobron/sandbox/input/b7] 2024-05-17 10:44:39.168 [scheduling-1] DEBUG o.s.i.file.FileReadingMessageSource - Watch event [ENTRY_MODIFY] for file [/Users/patryk.ziobron/sandbox/input/b8]

It seems the subfolders b2, b6 and b8 are not registered properly as when executing the following command (copying different file to these subfolders):
cp /Users/patryk.ziobron/sandbox/test/test2.zip b2/ cp /Users/patryk.ziobron/sandbox/test/test2.zip b4/ cp /Users/patryk.ziobron/sandbox/test/test2.zip b6/ cp /Users/patryk.ziobron/sandbox/test/test2.zip b8/

The ENTRY_CREATE and ENTRY_DELETE are only emitted for the b4 subfolder:
2024-05-17 11:22:51.107 [scheduling-1] DEBUG o.s.i.file.FileReadingMessageSource - Watch event [ENTRY_MODIFY] for file [/Users/patryk.ziobron/sandbox/input/b2] 2024-05-17 11:23:06.107 [scheduling-1] DEBUG o.s.i.file.FileReadingMessageSource - Watch event [ENTRY_CREATE] for file [/Users/patryk.ziobron/sandbox/input/b4/test2.zip] 2024-05-17 11:23:06.108 [scheduling-1] DEBUG o.s.i.file.FileReadingMessageSource - Added to queue: [/Users/patryk.ziobron/sandbox/input/b4/test2.zip] 2024-05-17 11:23:06.111 [Thread_25] INFO  o.s.i.handler.LoggingHandler - GenericMessage [payload=/Users/patryk.ziobron/sandbox/input/b4/test2.zip, headers={sourceCountry=global, feedName=reuters, file_name=test2.zip, targetPath=data, file_originalFile=/Users/patryk.ziobron/sandbox/input/b4/test2.zip, source=Global_Relay, priority=5, file_relativePath=b4/test2.zip, uncompress=true, sieve=true, id=5ecc527e-1188-a57e-6afd-571d2ba75431, decrypt=false, sourcePath=/Users/patryk.ziobron/sandbox/input, remoteFeedName=reuters, timestamp=1715937786111}] 2024-05-17 11:23:07.108 [scheduling-1] DEBUG o.s.i.file.FileReadingMessageSource - Watch event [ENTRY_MODIFY] for file [/Users/patryk.ziobron/sandbox/input/b4] 2024-05-17 11:23:08.104 [scheduling-1] DEBUG o.s.i.file.FileReadingMessageSource - Watch event [ENTRY_DELETE] for file [/Users/patryk.ziobron/sandbox/input/b4/test2.zip] 2024-05-17 11:23:13.106 [scheduling-1] DEBUG o.s.i.file.FileReadingMessageSource - Watch event [ENTRY_MODIFY] for file [/Users/patryk.ziobron/sandbox/input/b6] 2024-05-17 11:23:21.109 [scheduling-1] DEBUG o.s.i.file.FileReadingMessageSource - Watch event [ENTRY_MODIFY] for file [/Users/patryk.ziobron/sandbox/input/b8]

Everything works fine if the sleep is removed from command above (point 5)

Any other comments:
Sample project
https://github.com/pziobron/spring-integration-create-notification-bug

This is run against Oracle jdk?  Even if not, osunds more like an issue for OpenJDK itself, not temurin build script: https://bugs.openjdk.org/

FYI: I've managed to reproduce this issue for the latest Oracle JDK 17 on Mac (17.0.11+7-LTS-207).
I've reported a bug for Oracle.
The issue is not reproducible on Windows and Linux Red Hat Enterprise.
Thus, it seems that the issue is related to the Mac-OS only...
I’ve also found this issue in the Java tracking system: https://bugs.openjdk.org/browse/JDK-8293067
"WatchService on MacOS is still implemented by the generic PollingWatchService, which continuously re-scans the directory consuming CPU, introduces large latencies to the generated WatchEvent's, and misses changes that occur faster than the re-scan interval"
It seems that explains everything now.
To sum up, the WatchService is not reliable on Mac at the moment !

FYI: Oracle has officially confirmed the bug I've reported is valid, link: http://bugs.java.com/bugdatabase/view_bug?bug_id=JDK-8332530

It seems the link above doesn't work properly for others, here is the direct JIRA link: https://bugs.openjdk.org/browse/JDK-8332530


Alfred Workflow Incomptaible With Alfred v3.8.5 [970]

Hey -- Love your work.
Got the scripts working with some tweaking -- but I was very curious how you rigged up the Alfred workflow.
Let me know what version Alfred your workflow is compatible with -- Would love to test out this integration.

Glad you are liking the work 😄.

I was very curious how you rigged up the Alfred workflow.

As I mentioned in the Readme's Get the Workflow in Alfred section you basically dump the repository into your blank workflow. I'm not sure if that was what you were asking for?

Let me know what version Alfred your workflow is compatible with

As I mentioned in the Readme's Setup, this workflow requires Alfred 3+. I'm currently running on the latest Alfred 4 with no issues as well.

@thejohnnyxu just noticed the title of this lol (Alfred Workflow Incompatible With Alfred v3.8.5 [970]).
What is the situation that you are seeing? Like I mentioned I'm using version 4, so I'm not 100% sure what might be the issues. I don't think I'm using anything specific to v4 though, although I could be wrong.

It shows "Workflow incompatible", I also use v3.8.5. Hope support with v3, would be very helpful :)

To be honest I don't really have the bandwidth to investigate how to make this work with 3.x, as I've moved on to using Alfred 4.x.
I'll be making a change to the README to mention that this is for Alfred 4.x until someone can confirm it works in 3.x again.
Sorry about this, as this is likely not the resolution you were hoping for.


twitter is linked twice on profiles

See for example:

Ah, that's because if there is no website we fall back to using their twitter url. I've just added JS foundation website in the DB and it fixed it for them (but it's still a bug to be fixed).

I had just figured the same out with another profile.  Cool will close it then.


The CreateMultiDatacenterCluster e2e test should deploy multiple Cassandra pods in each DC

Initially CreateMultiDatacenterCluster created a K8ssandraCluster that consisted of 2 CassandraDatacenters with 3 C* nodes per DC and a Stargate instance per DC. The GHA workflow creates two kind clusters with 3 worker nodes per cluster. #65 changed the test by reducing the number of C* nodes per DC down to one. I believe the change was made due to port conflicts. Both the Cassandra and Stargate pods are configured with host networking. With 3 worker nodes, the Stargate pod was going to be co-located with a C* pod.
I want to change the test back to have 3 C* nodes per DC. We can try to run a 4th worker node in each cluster and configure Stargate so it scheduled on a dedicated worker node.
If the limited cpu/memory resources in the GHA runner make this difficult to do, then we need to make changes to the e2e tests. We could add another test that deploys the 6 node C* cluster without Stargate. For CreateMultiDatacenterCluster  we could disable host networking on Stargate and limit the verification we do for it. I have some confidence though that we can get things working by adding the 4th worker node to each cluster.
┆Issue is synchronized with this Jira Task by Unito
┆Fix Versions: k8ssandra-2.0.0-alpha
┆Issue Number: K8SSAND-861
┆Priority: Medium

Closed by #94


WSA is the best thing that has ever happened to windows.

Is your feature request related to a problem? Please describe
...
Describe the solution you'd like
...
Describe alternatives you've considered
WSA is the flagship feature of Windows 11. By adding functionalities like that and improving the ecosystem, you can at least compete with MacOS. Almost everything in the Windows system is implemented terribly, but WSA is one of those things that works well, and Microsoft wants to destroy it and roll back Windows 11 to the reputation of Vista.
Please specify the version of Windows Subsystem for Android
whyyy

I think so

WSA is indeed working really well and most useful as it is. Hopefully they will pick it up again.

True, it is one of the best things that has ever happened to Windows!!

I think WSA is important to Windows on arm,considering the performance of Snapdragon X Elite.

It is absolute foolishness and shortsightedness from Satya Nadella and his cohorts in the executive chair to ax WSA.
Let me spell it out as Satya has been lacking in the logic department lately with the blunder of Copilot+ to answer for.
Windows 11 lacks a mobile app library in the Microsoft Store. Microsoft excels in the triple E--embrace, extend, extinguish.
You are doing the polar opposite by axing this. Really.
Apparently, 2nd generation Snapdragon X next year brings further efficiency improvements to enable smaller and more passive designs. With it, you are going to release an 11" Surface Pro, and competitors will likely be bringing smaller tablets as well... without a competent app library to entice users.
Software trumps hardware always. Look at NVIDIA. Look at Tesla.
No one buys a tablet, especially smaller ones where touch comes first and foremost, without tablet-optimized, touch-friendly apps.
The beauty of WSA is it enables users to have tablet-optimized, touch-friendly apps from Android.
You are literally embracing and extending Android while having a super power Android never can do: bringing full Windows program support.
DeX and Stage Manager can never dream of this cornucopia of app compatibility.
Never mind you stupidly got rid of Windows 10's Tablet Mode, which us users can thankfully still bring back with https://github.com/valinet/ExplorerPatcher.
Never mind you can justify keeping Windows Subsystem for Linux without it bringing a revenue flow. Axing WSA because the Amazon Appstore partnership failed is throwing the baby out with the bathwater.
You are looking at your very advantage over Android, macOS, iPadOS, and iOS, and casting it aside.
 WSA is the way forward to stay ahead and is your upper hand to keep an ace up your sleeve.

@hifihedgehog well said! WSA could've been one of the core pillars of Windows especially with the new ARM chips. It's mind-blowing and emulators don't even come close. The fact that you cannot easily differentiate between a native and a WSA app says how good it was in terms of support and everything.
After shutting it down they are planning to release it in China only with Tencent partnership. If Amazon has failed why not just have something like APKMirror to get the apps or leave the storefront to us.  WSA could've been one of the core pillars of Windows especially with the new ARM chips. It's mind-blowing and emulators don't even come close. The fact that you cannot easily differentiate between a native and a WSA app says how good it was in terms of support and everything.
After shutting it down they are planning to release it in China only with Tencent partnership. If Amazon has failed why not just have something like APKMirror to get the apps or leave the storefront to us.

I think Tencent is not using WSA. They use Android 12 and Intel bridge. I need to turn off VM platform to use it. The APPs can not act like native Windows APPs.I can't use ADB to connect it.

@hifihedgehog well said! WSA could've been one of the core pillars of Windows especially with the new ARM chips. It's mind-blowing and emulators don't even come close. The fact that you cannot easily differentiate between a native and a WSA app says how good it was in terms of support and everything.
After shutting it down they are planning to release it in China only with Tencent partnership. If Amazon has failed why not just have something like APKMirror to get the apps or leave the storefront to us.

I think Tencent is not using WSA. They use Android 12 and Intel bridge. I need to turn off VM platform to use it. The APPs can not act like native Windows APPs.I can't use ADB to connect it.

You are talking about the old version. The new version is waiting to be released in the Windows Store, and the kernel that should be used is wsa

Thank you for informing that.


Add contributing section to documentation

First attempt at documenting a sane PR review process, mostly cribbed from the Kubernetes one.
What type of PR is this?
/kind documentation
What this PR does / why we need it:
This commit adds a contributing section to our documentation section which gives would-be developers and reviewers some guidance and setting of expectations.
Which issue(s) this PR fixes:
Fixes #419
NONE

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: yankcrime
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: alenkacz
If they are not already assigned, you can assign the PR to them by writing /assign @alenkacz in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: alenkacz, yankcrime
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [alenkacz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Looks great! Thank you for the Prow updates!
/approve
/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: alenkacz, jbarrick-mesosphere, yankcrime
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [alenkacz,jbarrick-mesosphere]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Linking To Documentation

Adding a repository website link to the documentation (in the side-bar to the right) could help increase the usability of the repository.
Furthermore, the introduction to Triton on OpenAi's research page had a dead link to the documentation by referencing the branch master instead of main

Thanks for the suggestion.  I added a link to the documentation in the side bar to the right.

Furthermore, the introduction to Triton on OpenAi's research page had a dead link to the documentation by referencing the branch master instead of main

I'm not sure wym, because the link given is to the documentation?  Copy-paste error?

Sure, if you look at the OpenAI research page, there is a link to the documentation on read the docs. However, this link is:
https://triton-lang.org/master/index.html
Given the change of branch name from master to main, the link on the website is broken.
https://triton-lang.org/master/index.html
Because of this, the link to the docs on the announcement for Triton 404s.
Hope that clears up the confusion. Also, I am beyond impressed by the responsiveness.

The OAI Research page is updated now.  Thanks again for bringing this to our attention!!


Needs to be added to spectrafit example juypter notebook

https://github.com/raman-noodles/raman-spectra-decomp-analysis/blob/8c624e4b7e46165dd67ff1b2906c780c339052cc/ramandecompy/spectrafit.py#L322

Done.


Support class Property Annotation

The ability to ignore a property, override the column name, when using the Insert(object) and Update(object) overloads.
class Entry {

   [Ignore]
   public string Type {get; set;}

   [Column("user_name")]
   public string UserName {get; set;}
}

Insert()

I already make couple of test I solved on my local I just need to upload it to prod but the name of the attributes will be SqlKataIgnoreAttribute and SqlKataColumn

@ahmad-moussawi I dont even know how to add a pull request what should I do?

hello?

@mota57 thanks!, but I think keeping the attributes name shorter (Column and Ignore) could be much simpler for developers.
and please add some unit tests, check this https://github.com/sqlkata/querybuilder/blob/master/QueryBuilder.Tests/InsertTests.cs to get an idea.
From your side you have to create a new branch on your local git something like
git checkout -b annotations

Do your changes then commit and push back to the remote repo,
or you can follow a simpler approach mentioned here https://help.github.com/en/desktop/contributing-to-projects/creating-a-pull-request

I am trying to push it and I can't because I dont have permission.

@mota57 fork this project. commit to the fork project. then, on  github "New pull request".

@ahmad-moussawi ready.

@ahmad-moussawi FWIW I think [Ignore] and [Column] are too generic; another developer will see those and not have a clue they are provided by SqlKata.
Specifically in the case of "Ignore" I think it would be sufficient if the provided column list didn't include the properties we wanted to ignore. For example I have a class with 3 properties but only 2 are written to the table. If I provide a column list with the 2 properties I want to write and then the object (or list of objects for "insert many") it should ignore the missing ones by default. Then we don't need decorators all over the classes, nor to throw an exception as is currently done in that case.

@Mota57 I suggest using System.ComponentModel.DataAnnotations.Schema.Column instead of creating a new attribute that does the same thing with the same name. Aside from reducing code, this would allow you to use only the same annotation for sqlkata and dapper mapping.

The suggestion should be for the owner of the repository for @ahmad-moussawi

Any news on this? Is it not supported for selects and is this intended? What is the proposed workaround?


Add documentation with sphinx

We do not provide any documentation in our project. Please see how to create one with sphinx!

Documentation with Sphinx added in: be20a92b39cf7b71978a4a6c7437a08313b9e640.
I have also improved the readme with a Documentation section.
Closed in: 33daa912bf364c92dfab81173bca3455a7d6be6f.


Emmet and ProGuard

Hello!
I just noticed one thing, when you use proguard for release build all interfaces which will be used with emmet.createSender(...) should be marked as "-keep class ..." in proguard rules.
without it nothing works.

i am figure out the real problem! its Gson!
i fix my release build with adding this lines in proguard configs:
# Explicitly preserve all serialization members. The Serializable interface
# is only a marker interface, so it wouldn't save them.
-keepclassmembers class * implements java.io.Serializable {
    static final long serialVersionUID;
    private static final java.io.ObjectStreamField[] serialPersistentFields;
    private void writeObject(java.io.ObjectOutputStream);
    private void readObject(java.io.ObjectInputStream);
    java.lang.Object writeReplace();
    java.lang.Object readResolve();
}

-keep public class * {
    public protected *;
}

##---------------Begin: proguard configuration for Gson  ----------
# Gson uses generic type information stored in a class file when working with fields. Proguard
# removes such information by default, so configure it to keep all of it.
-keepattributes Signature

# For using GSON @Expose annotation
-keepattributes *Annotation*

# Gson specific classes
-keep class sun.misc.Unsafe { *; }
#-keep class com.google.gson.stream.** { *; }

# Application classes that will be serialized/deserialized over Gson
-keep class com.google.gson.examples.android.model.** { *; }

##---------------End: proguard configuration for Gson  ----------

great :)
Man I gave you the write access on the repo, you can modify the current
Readme & code. I'll send it to jcenter next ;)

ok, I know about write access. I just want to discuss the problem) I will commit some another changes soon.

I never used Proguard :/ so I trust you in this point bro' :)
2015-06-05 10:39 GMT+02:00 Andrey Kulikov<EMAIL_ADDRESS>
ok, I know about write access. I just want to discuss the problem) I will
commit some another changes soon.
—
Reply to this email directly or view it on GitHub
https://github.com/florent37/Wear-Emmet/issues/11#issuecomment-109204124
.


feature: Eyeliner integration

Did you check the docs?

[X] I have read all the flash.nvim docs

Is your feature request related to a problem? Please describe.
The character search does not work with eyeliner. One or the other plugin breaks (it seems depending on the order that they are loaded? - i.e I tried uninstalling and reinstalling each and got different results depending on the order).
Describe the solution you'd like
I think having the initial highlighting similar to eyeliner would make this mode fantastic. Most of the time I want to go to a specific word when using f/t and eyeliner does a great job of this. The continued search that this plugin offers could also be fairly useful so if they could play nicely together that would be amazing (either by integrating this feature into flash or figuring out some way of making them work together).
Describe alternatives you've considered
I guess the alternative would be to disable this feature in flash or uninstall eyeliner. These options work as expected afaik.
Additional context
No response

You won't be able to use both at the same time, since both plugins override the same keymaps.
I'm also not interested in adding eyeliner functionality to flash.

I'm also not interested in adding eyeliner functionality to flash.

I'm currently working on implementing this for my own config - would you be interested in a PR, or are you not interested in including the feature at all?

Depends on what exactly it would do :)
Never used that plugin.
But I assume it would only do something when you havent typed a char yet? so right after f for example?

But I assume it would only do something when you havent typed a char yet? so right after f for example?

Yes, it gives optimal jump locations for words in the chosen direction, highlighting locations that can be jumped to with a single char or a repeat of a single char. My implementation is a bit messy so far and I'm not quite sure how it would fit in with the plugin overall, but here's what it looks like:

If people are looking to do this, with the latest changes in eyeliner, it is possible to call its "highlight" method just before the flash behaviour is executed.
I used https://github.com/anuvyklack/keymap-amend.nvim to "extend" the mappings in my config:
{
  'folke/flash.nvim',
  opts = {
    modes = {
      char = {
        enabled = true,
      },
    },
  },
  config = function(_, opts)
    require('flash').setup(opts)
    local keymap = vim.keymap
    keymap.amend = require 'keymap-amend'
    local Eyeliner = require 'eyeliner'

    for key, forward in pairs { f = true, F = false, t = true, T = false } do
      keymap.amend({ 'n', 'o', 'x' }, key, function(original)
        Eyeliner.highlight { forward = forward }
        original()
      end)
    end
  end,
}


Can I fix multi-parts at a time?

Hello, and thanks for your log2seq, a meaningful toolkit for log analysis.I wonder if i can fix multi-parts and then split the log using seperators,for instance,
for log:
REQ: curl -g -i -X GET http://controller:9696/v2.0/floatingips.json?fixed_ip_address=<IP_ADDRESS>&port_id=5c0e6ba6-6964-4417-ab47-b002c187f081 -H "User-Agent: python-neutronclient" -H "Accept: application/json" -H "X-Auth-Token: {SHA1}8e6966d0b6ba20646b9fe7329e7aeeb022549330" _http_log_request /usr/lib/python2.7/site-packages/keystoneauth1/session.py:248
i want to fix the content surrounded by ",and fix the content like "2.7" and the seperate the log using space and dot.
i tried but failed.Could you please help me to find a way to figure out the problem?
Thank you

Thank you for your report, @Jiacheng188. This tool is designed for people like you!
Unfortunately, the previous version of log2seq has a bug for messages including multiple parenthesis pairs.
This bug is fixed after v0.2.3.
Now I succeeded to parse your sample log by the following code:
from log2seq.statement import *

text = 'REQ: curl -g -i -X GET http://controller:9696/v2.0/floatingips.json?fixed_ip_address=<IP_ADDRESS>&port_id=5c0e6ba6-6964-4417-ab47-b002c187f081 -H "User-Agent: python-neutronclient" -H "Accept: application/json" -H "X-Auth-Token: {SHA1}8e6966d0b6ba20646b9fe7329e7aeeb022549330" _http_log_request /usr/lib/python2.7/site-packages/keystoneauth1/session.py:248'

pattern_url = r"http(s)?://[a-z0-9.:_=&?/-]+"
pattern_abs_path = r"/([a-z0-9.]+/)+[a-z0-9.]+"

statement_rules = [
    FixParenthesis(['"', '"']),
    FixParenthesis(['"', '"']),
    FixParenthesis(['"', '"']),
    Split(" "),
    Fix(pattern_url),
    Split(":"),
    Fix(pattern_abs_path),
    Split("."),
]

statement_parser = StatementParser(statement_rules)
print(statement_parser.process_line(text)[0])

This code will output:
['REQ', 'curl', '-g', '-i', '-X', 'GET', 'http://controller:9696/v2.0/floatingips.json?fixed_ip_address=<IP_ADDRESS>&port_id=5c0e6ba6-6964-4417-ab47-b002c187f081', '-H', 'User-Agent: python-neutronclient', '-H', 'Accept: application/json', '-H', 'X-Auth-Token: {SHA1}8e6966d0b6ba20646b9fe7329e7aeeb022549330', '_http_log_request', '/usr/lib/python2.7/site-packages/keystoneauth1/session.py', '248']
We need to add multiple FixParenthesis in the rules in this case.
Currently, FixParenthesis does not support recursive search (may be supported in the future).

Thank you for your timely reply！Looking forward to the future version 😁


CAMEL-19973 - Camel-AWS components: Revisit description - ECS Component

Description

Target

[x] I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

[ ] If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

[x] I checked that each commit in the pull request has a meaningful subject line and body.

[x] I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

/component-test aws


display correct transaction detail values

If you made a contract change, make sure to complete the checklist below before merging it in master.
Refer to our documentation for more details about contract security best practices.
Contract change checklist:

[ ] Code reviewed by 2 reviewers. See template and example.
[ ] Unit tests pass
[ ] Slither tests pass with no warning
[ ] Echidna tests pass if PR includes changes to OUSD contract (not automated, run manually on local)

Oh also forgot to say @punk1004  you got the hang of the code base fairly quickly props for that 👍

Closing since there hasn't been any activity in the last 30 days...


Customizing the checkbox - info needed

Hello,
Adding a checkbox is relatively easy - but how can one customize the checkbox programmatically?
For example, when the checkbox is checked, how do I change the background color?
How do I vertically center the accompanying text of a checkbox?
There seems to be NO straightforward explanation of how this can be programmatically customized.
Thank you in advance.
Uttam

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a7d0ca3a-00fd-3e20-0eac-314abee33c73
Version Independent ID: cde4f1bf-659c-3cf3-b861-5cbe87581a98
Content: CheckBox - Xamarin
Content Source: docs/android/user-interface/controls/buttons/check-box.md
Product: xamarin
GitHub Login: @conceptdev
Microsoft Alias: crdun

@u0107 thanks for your feedback. We do not currently have any information specifically about styling the checkbox control. Perhaps this page about the Material theme can help?


React to Auth/Options changes

Not a huge change to startup
Thoughts? @divega

One bit of smell is the static defaults I moved to IdentityCookieOptions, those strings are what we default the AuthenticationSchemes to for the cookie middleware we configure.  Those are then copied to the options, so we have mutable strings.  Its just a bit wonky.

Something doesn't feel quite right but it is hard for me to explain it. It might be that I just need to understand how it works :smile: Can we go over it on a whiteboard?

Closing and will resubmit with new iteration


Locking Root Step in Flow

I'm wondering if there's a way to "lock" the root step in the flow so that you can't add a step to the top of it. I might be missing something but not sure how to define available positions for steps.

// prevents you from dropping this step above a root step
  canDrop(dropEvent: NgFlowchart.DropTarget): boolean {
    if (!dropEvent.step.parent && dropEvent.position === 'ABOVE') {
      return false;
    }
    return true;
  }


Some cyrillic showing as null

Description
Some of the friends who write to me have they're named as "null". I tried with one group and it worked it showed it as it should. I couldn't see a logic behind it or at least for now.
Steps to Reproduce

Most of the people who I have with Cyrlic names are null

Expected behavior:
See his real name.
Actual behavior:
See "null" and the message
Versions
Run, and copy-paste the results, of the following:

npm -v -> 6.7.0
node -v -> v11.12.0
messer -v -> 0.5.0

Also, please include the OS and what version of the OS you're running.
MacOS Mojave v 10.14.3

Hey 👋 Messer 0.5.1 has just been published with a bunch of bug fixes - install it and give it a whirl 🤘. If you’re still experiencing this issue, please comment below with your symptoms and we'll keep the ticket open. Thanks for supporting Messer 💬

Hey @tomquirk , how can I update?

should just be able to run npm install -g messer again, check you've got 0.5.1 or 0.5.2 installed with messer --v


Fix incorrect link to User Manual

Fixes #23785

@bot-gradle cancel

Error occurs when cancelling build, please contact administrator.

@bot-gradle clean

Duplicates

#23786


Suppor for list elements

Hi, I really like the way the editor is simple, light -weight.
I'm just wondering why doesn't this have a provision for list elements and what does it takes to add list elements to the same?
Thanks
Sujeet

@sujeetbuddiga Block elements are not allowed in this editor. The paragraph element is also generated automatically by replacing two empty line break into

. This rich text editor was created to be used on public form, especially for a chat-like form, so we only support inline modifier like bold, italic and link for simplicity.

thanks for the response @tovic
is it scoped out? or not yet kind of state?

Scoped out, sorry. Let me give you a simple example. In your text editor you have this:
asdf

asdf
asdf

So you get this output:

asdf

asdf
asdf

Then you decided to have a list feature, so you end up having this:
asdf

asdf

asdf

asdf
asdf

So you will end-up with this:

asdf

asdf

asdf

asdf
asdf

Yeah, I understand.
Thanks for responding patiently :D


How to perform an in and out animation

Hello, I love this package. I have been able to animate in but I don't know how to animate out i.e. when a widget is about to be unmounted. Any help is appreciated thanks.

Voting for this feature.
Currently I added Curves.easeInOut on the effects to get the animation on mount and unmount, but more control for complex animations would be great.
Btw, awesome package.

I believe this is a duplicate of #29 - please feel free to reopen with more info if not.


resourceQuota annotation is incorrectly set on projects and leads to ResourceQuota not being created

Setup

Rancher version: v2.6.3-rc11
Browser type & version:

Describe the bug

When creating a project with Resource Quotas and then creating a namespace in it, the ResourceQuota resource never appears on the downstream cluster and Rancher complains about the quota value:
[ERROR] error syncing 'n3': handler namespace-auth: quantities must match the regular expression '^([+-]?[0-9.]+)([eEinumkKMGTP]*[-+]?[0-9]*)$', handler resourceQuotaSyncController: quantities must match the regular expression '^([+-]?[0-9.]+)([eEinumkKMGTP]*[-+]?[0-9]*)$', requeuing

It's because the field.cattle.io/resourceQuota annotation has a space after the value, or between the value and the units: field.cattle.io/resourceQuota: "{\"limit\":{\"limitsMemory\":\"1024 Mi\"}}"
To Reproduce

Create a project. Go to the Resource Quotas tab and add any resource. A resource like ConfigMaps has no units, while a resource like CPU Limits has a unit like m.
Create a namespace in the project.

Result
Namespace is created, but no ResourceQuota is created.
Expected Result

ResourceQuota is created in the namespace.
Screenshots

The values on the Project are set correctly:

Additional context

Detailed Description

Context

Fix is available using the dashboard v2.6.3-patch1-rc1 release. Until there's an RC of Rancher this can be tested by

Bring up Rancher 2.6.3 and log in to the Dashboard
Global Settings --> Advanced Settings
i.  Set ui-dashboard-index to https://releases.rancher.com/dashboard/v2.6.3-patch1-rc1/index.html
ii. Set ui-offline-preferred to Remote
Refresh the browser

rancher/dashboard#4704 Should be verified when this is tested

Verified on 2.6.3-patch1-rc1

Created a project with the resource quotas CPU Limits, Memory limits, configmaps set to the values 1000, 1000, 2
Verified the quotas are updated in the namespace and the yaml the annotations are updated:

    field.cattle.io/resourceQuota: '{"limit":{"configMaps":"70","limitsCpu":"1000m","limitsMemory":"1000Mi"}}'

Verified by creating a workload in the namespace with the limits for CPU and memory set to 1001 and the deployment failed with the error
Error creating: pods "test3-55fbf45ff8-jdf99" is forbidden: exceeded quota: default-skxr8, requested: limits.cpu=1001m, used: limits.cpu=1, limited: limits.cpu=1

For a more detailed issue and workaround here:
When I set a new Project test-with-quota with a new namespace test configured with resourceQuota and containerDefaultResourceLimit:

the containerDefaultResourcceLimit does not apply to test

Error will be generated in Rancher log:

2022/01/21 17:24:48 [ERROR] error syncing 'test': handler namespace-auth: quantities must match the regular expression '^([+-]?[0-9.]+)([eEinumkKMGTP]*[-+]?[0-9]*), handler resourceQuotaSyncController: quantities must match the regular expression '^([+-]?[0-9.]+)([eEinumkKMGTP]*[-+]?[0-9]*)

As the above log seems weird, so I tried to figure out what happened and I examine the annotation of test and found out this:

It seems like the value for resourceQuota accidentally added a space for separating the unit and the number
So I went to check Rancher configuration for the project but there's no space in the config

...
  namespaceDefaultResourceQuota:
    limit:
      limitsCpu: 100m
      limitsMemory: 100Mi
      requestsCpu: 100m
      requestsMemory: 100Mi
  resourceQuota:
    limit:
      limitsCpu: 1000m
      limitsMemory: 1000Mi
      requestsCpu: 1000m
      requestsMemory: 1000Mi
    usedLimit:
      limitsCpu: 100m
      limitsMemory: 100Mi
      requestsCpu: 100m
      requestsMemory: 100Mi
...

Last and the most exciting part you would like to know is that I make my resourceQuota works with a workaround:

apiVersion: v1
kind: Namespace
metadata:
  name: test
  annotations:
    cattle.io/status: >-
      {"Conditions":[{"Type":"ResourceQuotaValidated","Status":"True","Message":"","LastUpdateTime":"2022-01-21T17:39:10Z"},{"Type":"ResourceQuotaInit","Status":"True","Message":"","LastUpdateTime":"2022-01-21T17:39:10Z"},{"Type":"InitialRolesPopulated","Status":"True","Message":"","LastUpdateTime":"2022-01-21T17:39:10Z"}]}
    field.cattle.io/containerDefaultResourceLimit: '{}'
    field.cattle.io/projectId: c-cbshr:p-vshjm
    field.cattle.io/resourceQuota: >-
      {"limit":{"limitsCpu":"100 m","limitsMemory":"100 Mi","requestsCpu":"100
      m","requestsMemory":"100 Mi"}}
    lifecycle.cattle.io/create.namespace-auth: 'true'
#    key: string
  creationTimestamp: '2022-01-21T17:17:58Z'
  finalizers:
    - controller.cattle.io/namespace-auth
#    - string
  labels:
    field.cattle.io/projectId: p-vshjm
#    key: string
  resourceVersion: '41255763'
  uid: c50a51e6-fcd9-4e35-883e-e40e1ffe007b
  fields:
    - test
    - Active
    - 21m
spec:
  finalizers:
    - kubernetes
#    - string
__clone: true

change     field.cattle.io/resourceQuota: >-       {"limit":{"limitsCpu":"100 m","limitsMemory":"100 Mi","requestsCpu":"100       m","requestsMemory":"100 Mi"}}
to field.cattle.io/resourceQuota:{"limit":{"limitsCpu":"100m","limitsMemory":"100Mi","requestsCpu":"100m","requestsMemory":"100Mi"}}
And then verify with the above comment 😄

@gisyrus Thank you a detailed description. @richard-cox provided a fix for the same and from my comment, I was able to validate that it works on the rancher version v2.6.3-patch1-rc1.
More validations:

Created a downstream rke1 cluster with 2 nodes
Created a project with the following resource quotas set:

- Verified the quota limits were set on the namespaces as well

Verified the set quotas are applied on the namespace by setting more than the required limits while creating a few workloads.

Release notes should inform user that on upgrade any effected resources will need to be updated for the fix to apply.

@richard-cox I validated this by upgrading rancher from 2.6.3 to 2.6.3-patch1-rc2 on an HA server.

I noticed that if a project with resource quotas set was created in 2.6.3 - Project1 and a namespace ns1 was added we hit this error

2022/01/24 23:13:02 [ERROR] error syncing 'postupgns': handler namespace-auth: quantities must match the regular expression '^([+-]?[0-9.]+)([eEinumkKMGTP]*[-+]?[0-9]*) handler resourceQuotaSyncController: quantities must match the regular expression '^([+-]?[0-9.]+)([eEinumkKMGTP]*[-+]?[0-9]*

This was the yaml set for the namespace

    field.cattle.io/resourceQuota: '{"limit":{"configMaps":"5 ","limitsCpu":"500 m","limitsMemory":"1023
      Mi","pods":"4 ","requestsCpu":"500 m"}}'

Now, if we upgrade the rancher server to 2.6.3-patch1-rc2, and create a namespace in that same project, we still see the same error.
if we add a new project with resource quota set post upgarde, and add a namespace with the resource quota, the error is not seen.
This is not the case on a fresh installed 2.6.3-patch1-rc2 but seen only on an upgraded version of rancher from 2.6.3 --> 2.6.3-patch1-rc2

It looks like the error seen on upgrade is due to the namespace from pre-upgrade (with invalid limits) still existing. This causes other namespaces to fail syncing downstream causing the error log. I've updated the release notice to include instructions on how to resolve this (either remove the bad namespace, fix the limits in the namespace or remove the namespace from the project) - https://github.com/rancher/dashboard/issues/4804#issuecomment-1020231339

Verified on 2.6.3-patch1-rc2 upgraded from 2.6.3
The errors 2022/01/25 21:04:39 [ERROR] error syncing 'anupamatest': handler namespace-auth: quantities must match the regular expression '^([+-]?[0-9.]+)([eEinumkKMGTP]*[-+]?[0-9]*), handler resourceQuotaSyncController: quantities must match the regular expression '^([+-]?[0-9.]+)([eEinumkKMGTP]*[-+]?[0-9]*), requeuing
can be eliminated for the new namespaces that were created post upgrade in the same project with :
Workaround1:

Delete the namespace that was created pre rancher upgarde.
In my setup, I deleted the namespaces that was created in 2.6.3 after upgrading the rancher server to 2.6.3-patch1-rc2 that had a regex issue for the resource limits set field.cattle.io/resourceQuota: '{"limit":{"configMaps":"5","limitsCpu":"500m","limitsMemory":"1023Mi","pods":"5","requestsCpu":"500 m","requestsMemory":"1024Mi"}}'
By removing the namespace above, the errors seen for other namespaces that were created in that project post upgrade of rancher were resolved.

Workaround2:

Edit the namespace that was created pre-rancher upgrade
In my setup, edited the namespace that was created in 2.6.3 and by re-saving the values for the resource quotas, the original error where the resource quotas had an incorrect regex was resolved.
The errors seen for the other namespaces created in the same project as the namespace above can be resolved as well.

~Release notes should inform user that on upgrade any effected resources will need to be updated for the fix to apply.~
The following comment should accompany this issue in the release notes: On upgrade any namespaces created with limits should either be deleted or edited again (which will correct the invalid limits). Failure to do so will result in limits failing to apply to all other namespaces in the same project.
@btat What's the best way to ensure the above makes it into the release notes?

The best way is to just ensure the release note label is affixed to the issue (and the milestone set). Additionally, you may ping us on Slack to add things if need be (if last minute things come up). Thanks for checking!


Request

from Discord #Random
polakowo — Today at 9:54 AM
If you know any simple way to call IB and fetch data, I can create a data instance for that process, I'm not familiar with IB tbh
May not be a bad idea to do something like this, would probably make more people aware your awesome project.

Yes, I had the idea too to add a class in VBT. Actually my class IBData(RemoteData) in orders/models already use the right class from VBT. But IB does not use REST request but socker connection, which makes it from the start quite different from the other brokers out there. So I need a kwargs and give it an already created instance of myIB from ib_insync... In addition, in IB one tickers can lead to different products, which is not the way VBT normally works. So right now, it is not good enough to be merged in VBT. But basically, I use the same logic.

Ic. Thanks for providing more detail

I still need to spend more effort on this point. It is feasible. I am reading again VBT code, and my "myIB" can be passed as client. I will give it a try when I find some time.

For info, I am working on it.

Hum, an issue is if I use the same logic as let's say TVData, it connects and disconnects for every downloaded symbol :(

Could we ask him to add an option like keepOpen=true
Sent from Outlook for iOShttps://aka.ms/o0ukef

From: psemdel @.>
Sent: Saturday, December 31, 2022 12:34:16 PM
To: psemdel/py-trading-bot @.>
Cc: ben1628 @.>; State change @.>
Subject: Re: [psemdel/py-trading-bot] Request (Issue #8)
Hum, an issue is if I use the same logic as let's say TVData, it connects and disconnects for every downloaded symbol :(
—
Reply to this email directly, view it on GitHubhttps://github.com/psemdel/py-trading-bot/issues/8#issuecomment-1368256382, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHJERBTITZQFP27V4KE742TWQBVBRANCNFSM6AAAAAATKPY6ZI.
You are receiving this because you modified the open/close state.Message ID: @.***>

Ok, I created a branch here and a branch by vbt. I tested it yesterday and it works. It is quite a big change, but it is definitely a progress. We can wait for the merge from IB side to use it, otherwise, it is also possible to copy the code in the bot. Anyhow, I will beta test it, most probably there are still things to improve.

Wow that’s great I will take a look, looks like the next release is around the corner
Sent from Outlook for iOShttps://aka.ms/o0ukef

From: psemdel @.>
Sent: Thursday, January 5, 2023 3:49:11 PM
To: psemdel/py-trading-bot @.>
Cc: ben1628 @.>; State change @.>
Subject: Re: [psemdel/py-trading-bot] Request (Issue #8)
Ok, I created a branch here and a branch by vbt. I tested it yesterday and it works. It is quite a big change, but it is definitely a progress. We can wait for the merge from IB side to use it, otherwise, it is also possible to copy the code in the bot. Anyhow, I will beta test it, most probably there are still things to improve.
—
Reply to this email directly, view it on GitHubhttps://github.com/psemdel/py-trading-bot/issues/8#issuecomment-1372729021, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHJERBWJ377J3ODUT72AMXLWQ4XUPANCNFSM6AAAAAATKPY6ZI.
You are receiving this because you modified the open/close state.Message ID: @.***>

The branch IBhandling_moved_to_vbt contains the change, as polakowo cannot test IB. But basically it is the same, we just have to move the code there, when he is ready. The hint about beta testing remains valid.

Can you update your code to corresponding vectorbt pro 1.9.0, thanks.


CDVBackgroundGeoLocation locatinManager failed

More often than not I keep getting this error thrown the Xcode logs:
CDVBackgroundGeoLocation locationManager failed: Error Domain=kCLEerrorDomain Code=0 "(null)"
This happens when the app is in the background and when it happens it failed to send the geolocation. I'm very new iOS dev and any help would be much appreciated. I am testing on an iPad mini running 9.2.1

Yes, that is ugly. Need to take look at it.

Just turn debug notifications with debug:false option. You should do it anyway in production


Question: How to scan against the GIT ecosystem?

The OSV.dev database contains CVEs published through Github advisories in the Git ecosystem. When trying to scan dependencies of a project in this ecosystem, the scanning fails with { "code": 3, "message": "Invalid ecosystem" }.
Is this because of "GIT" not being a well-supported ecosystem by definition of the Open Source Vulnerability format? Is there a way to mitigate this?
Minimal working example
osv-scanner --lockfile=osv-scanner:mwe.json

where mwe.json contains
{
  "results": [
    {
      "packages": [
        {
          "package": {
            "ecosystem": "GIT",
            "name": "github.com/typo3/typo3",
            "version": "v10.0.0"
          }
        }
      ]
    }
  ]
}

This should result in the reporting of (at least) CVE-2024-34537.
$ osv-scanner --version
osv-scanner version: 1.9.0
commit: 1386406b64edd4544696183f273139ef9298f5df
built at: 2024-10-02T05:22:27Z

For completeness, using purl instead does not solve the problem because then the package is filtered out as a "local" package. Here is the mwe for that:
{
  "results": [
    {
      "packages": [
        {
          "package": {
            "purl"<EMAIL_ADDRESS>          }
        }
      ]
    }
  ]
}

I think it is related to this discussion in the osv.dev repo and I will follow up there.


merger master into release for C# Extension 1.3 release

@gregg-miskelly @caslan @wesrupert @rajkumar42

:+1:

👍


Implement a two-stage deserialization to speed up checked file loads

Checked files are loaded in two ways in FStar.CheckedFiles.fs:

through load_checked_file which checks versions, integrity and hashes. It also returns the parse tree stored in the checked file.
through load_checked_file_with_tc_result which reloads a checked file but gives access to the direct dependencies and the typechecked results. This is a second stage after load_checked_file has run.

At present the checked file consist of a single tuple object that contains 5 fields. Loading the value parses and constructs all 5 fields even if they are subsequently not used.
This PR alters the checked file format to save two objects which correspond to the two stages for load_checked_file and load_checked_file_with_tc_results. This allows us to read only the necessary data in the first stage rather than parsing all 5 fields.
I have implemented this within the constraint that all the values live in a single file and that there is minimal disturbance to the existing code. So in the second stage we re-read the first stage items. This inefficiency isn't presently large as the first stage items (version no, digest, parse tree) are generally much smaller than those read in the second stage (direct dependencies, typechecked results).
Benchmarking of the change on Linux with an OCaml build (with --admit_smt_queries true) for examples/micro-benchmarks and ulib (building each file again, all other ulib files present):
                 baseline                   New 2stage checked files
                 total   user    system     total   user    system
micro-benchmarks 81.57   74.8    6.147      70.74   66.38   3.912
ulib             588.5   553.3   32.6       511.8   490     20.26

I am observing a reduction of 25% of the time spent doing dependency analysis.
This halves the time spent verifying a file like Negotiation.fsti where the time is dominated by loading checked files.
This is a great performance improvement.


Azure Container Registry Naming

Hello,
while we're extending our infrastructure with the naming module we stumbled across the Azure Container Registry Naming. Me personally the cr would have been fine but for the Azure CLI its called acr and therefore it is not really convenient to use and also confusing. Is it possible to change this?
container_registry = {
      name        = substr(join("", compact([local.prefix_safe, "cr", local.suffix_safe])), 0, 63)
      name_unique = substr(join("", compact([local.prefix_safe, "cr", local.suffix_unique_safe])), 0, 63)
      dashes      = false
      slug        = "cr" => "acr"
      min_length  = 1
      max_length  = 63
      scope       = "resourceGroup"
      regex       = "^[a-zA-Z0-9]+$"
    }

Example Articles:

https://docs.microsoft.com/en-us/azure/container-registry/container-registry-best-practices#manage-registry-size
https://docs.microsoft.com/en-us/azure/container-registry/

https://github.com/Azure/terraform-azurerm-naming/pull/23

As said in the PR it makes senseto do this change and since the module still in preview the change it is welcome
Thank yoiu for your contibution


动画能否重复播放

[x] I have searched the issues of this repository and believe that this is not a duplicate.

What problem does this feature solve?
图标动画只能执行一次
What does the proposed API look like?
<animate repeatCount="indefinite" />

可以。 参考这个 demo，https://g2-v3.antv.vision/en/examples/gallery/line#line8

往 G 的图形属性中设置 repeat: true

没有在这个demo里看到repeat的效果
代码里貌似也没对repeat的处理


Create shriyadindi-9.md

@aslams2020 level2 label was assigned for this

readme comes under documentations

@aslams2020 okay, but he assigned the level2 label

GSSoC guidelines comes first.


chore: cleanup

This does some devtooling cleanups:

use fs.rm instead of fs.rmdir because fs.rmdir logs a deprecation warning.
lock file maintenance, all dependencies in lock-file are updated to latest valid version
update eslint config, to fix unsupported typescript warning when eslint runs.
Instead of FORCE_COLOR=0 environment variable use chalk.level=0 so that the tests work when not run through npm
Remove ava rule in renovate config, as we do not use ava here anymore.
Increase test timeout to 30s

I feel like you're the king of maintenance ✨

I ❤ maintenance.


colmap is changed

now colmap updated so need modification in bundle.cc
for example,
colmap/camera/models.h isn't in that directory but in colmap/sensor/models.h
because of that pyceres build error i currently can't build pixel-perfect-sfm :(

Thank you so much for your consideration and fast reply :) have a nice day!!
2023년 9월 20일 (수) 오전 12:07, Paul-Edouard Sarlin @.***>님이
작성:

Currently pixsfm requires COLMAP 3.8 and is not compatible with HEAD. From
its README:
pixsfm requires [...] COLMAP 3.8 installed from source
https://colmap.github.io/install.html#build-from-source
[...]
install COLMAP following colmap.github.io/install.html#build-from-source,
tag 3.8
So does pyceres.
—
Reply to this email directly, view it on GitHub
https://github.com/cvg/pyceres/issues/24#issuecomment-1725836172, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/BBFHKE65IEH3BR6QPE3DF5TX3GYL3ANCNFSM6AAAAAA46JXZJU
.
You are receiving this because you authored the thread.Message ID:
@.***>

I use colmap 3.8, and replace
#include <colmap/camera/models.h>
#include <colmap/geometry/projection.h>
with
#include <colmap/src/base/camera_models.h>
#include <colmap/src/base/projection.h>
And after changing, I can "pip install -e ." the pyceres-1.0.

PyCeres now tracks the HEAD of COLMAP. PixSfM has not yet been updated.


[Failed Test] policies_spec.js

Running:  plugins/index-management-dashboards-plugin/policies_spec.js                    (8 of 17)

  Policies
    can be created
      ✓ successfully (20543ms)
      ✓ with an alias action using the visual editor (11212ms)
    can be edited
      ✓ successfully (11403ms)
      1) with more aliases
    can be deleted
      ✓ successfully (6512ms)
    can be searched
      ✓ successfully (9114ms)
    can be viewed
      ✓ successfully (3509ms)

  6 passing (2m)
  1 failing

  1) Policies
       can be edited
         with more aliases:
     AssertionError: Timed out retrying after 60000ms: Expected to find content: 'alias3' within the element: <div.euiComboBox> but never did.
      at eval (http://localhost:5601/__cypress/tests?p=cypress/integration/plugins/index-management-dashboards-plugin/policies_spec.js:487:63)
  at Array.forEach (<anonymous>)
      at Context.eval (http://localhost:5601/__cypress/tests?p=cypress/integration/plugins/index-management-dashboards-plugin/policies_spec.js:486:25)

  (Results)

  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ Tests:        7                                                                                │
  │ Passing:      6                                                                                │
  │ Failing:      1                                                                                │
  │ Pending:      0                                                                                │
  │ Skipped:      0                                                                                │
  │ Screenshots:  1                                                                                │
  │ Video:        true                                                                             │
  │ Duration:     2 minutes, 11 seconds                                                            │
  │ Spec Ran:     plugins/index-management-dashboards-plugin/policies_spec.js                      │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘

https://github.com/opensearch-project/index-management-dashboards-plugin/actions/runs/6117128934/job/16603304492
https://github.com/opensearch-project/index-management-dashboards-plugin/actions/runs/6278254496/job/17051607555
https://github.com/opensearch-project/index-management-dashboards-plugin/actions/runs/6383883900/job/17325398343
https://github.com/opensearch-project/index-management-dashboards-plugin/actions/runs/6713125910/job/18244083343
https://github.com/opensearch-project/index-management-dashboards-plugin/actions/runs/6714280704/job/18247266546?pr=909

If you're having trouble troubleshooting this failing cypress test, feel free to reach out to me.

Hi @bowenlan-amzn
Could you please assign this issue to me?
KC


Fixed types

This added @protected to  Signal._, since Signal._ is used within subclass.
https://www.typescriptlang.org/docs/handbook/jsdoc-supported-types.html#property-modifiers

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
231

Relevant Lines:
231

💛  - Coveralls

this ruins value which is the only field that matters ... see https://github.com/WebReflection/usignal/blob/main/types/index.d.ts#L7-L17
why do you think this is relevant or needed?

I am sorry. I may understand problem correctly. The problem is these lines. Computed and Reactive have value property. Signal  does not have value property.  It have _ propery. I do not know how to resolve it by using JSDoc annotations.
https://github.com/WebReflection/usignal/blob/15c07e14250c4b35181cda0688201125c809ff75/esm/index.js#L117-L119
https://github.com/WebReflection/usignal/blob/15c07e14250c4b35181cda0688201125c809ff75/esm/index.js#L228-L230
I can only come up with the following solution.
Stopping generating index.d.ts  by tsc -p .. Creating index.d.ts by manualy.

that's what the sed command does ... so I am generatig index.d.ts and patching after, and it seems to work well.

Thank you for reply. I think your current method is correct.


npx prisma migrate reset: Must use import to load ES Module

Bug description
Hello,
Today I updated prisma and @prisma/client packages in my project from 2.22.1 to 2.26.0
But now i meet an error when i run npx prisma migrate reset
Before it works like a charm but now it throw an error
migrations/
  └─<PHONE_NUMBER>4413_create_user_role_company_tables/
    └─ migration.sql
  └─<PHONE_NUMBER>2538_create_bakery_table/
    └─ migration.sql
  └─<PHONE_NUMBER>0436_create_pharmacy_table/
    └─ migration.sql
  └─<PHONE_NUMBER>2937_create_campaign_table/
    └─ migration.sql
  └─<PHONE_NUMBER>4758_create_search_delivery_tables/
    └─ migration.sql

✔ Generated Prisma Client (2.26.0) to ./node_modules/@prisma/client in 298ms
Running seed from "prisma/seed.js" ...
Result:
internal/modules/cjs/loader.js:1080
      throw new ERR_REQUIRE_ESM(filename, parentPath, packageJsonPath);
      ^

Error [ERR_REQUIRE_ESM]: Must use import to load ES Module: /Sites/api/prisma/seed.js
require() of ES modules is not supported.
require() of /Sites/api/prisma/seed.js from /Sites/api/[eval] is an ES module file as it is a .js file whose nearest parent package.json contains "type": "module" which defines all .js files in that package scope as ES modules.
Instead rename seed.js to end in .cjs, change the requiring code to use import(), or remove "type": "module" from /Sites/api/package.json.

Error: Command failed with exit code 1: node -e "
console.info('Result:')

const __seed = require('./prisma/seed.js')
const __keys = Object.keys(__seed)

async function runSeed() {
  // Execute "seed" named export or default export
  if (__keys && __keys.length) {
    if (__keys.indexOf('seed') !== -1) {
      return __seed.seed()
    } else if (__keys.indexOf('default') !== -1) {
      return __seed.default()
    }
  }
}

runSeed()
  .then(function (result) {
    if (result) {
      console.log(result)
    }
  })
  .catch(function (e) {
    console.error('Error from seed:')
    throw e
  })

Thanks for your reply
How to reproduce

Expected behavior
No response
Prisma information

Environment & setup

OS: Mac OS
Database: MySQL
Node.js version: v14.16.1

Prisma Version
2.26.0

Hi @benjaminviaud , thanks for reporting the problem. We are seeing problems with seed scripts because of different module systems and import setups with node, and I think it's going to be hard to fix. One thing that I always come back to would be a prisma:seed script in your package.json that migrate would just start as a separate process. Do you think that would work for your use case?

Hello @tomhoule,
Thanks for your reply.
Your solution throw the same error.
If I compare two build scripts
2.22.1
....
if (detected.js) {
    console.info(`Running ${chalk_12.default.bold(`node "${detected.js}"`)} ...`);
    return await execa_12.default("node", [`"${detected.js}"`], {
      shell: true,
      stdio: "inherit"
    });
  }

....

2.26.0
....
 if (detected.js) {
    console.info(`Running seed from ${chalk_12.default.bold(`"${detected.js}"`)} ...`);
    return await execa_12.default("node", [`-e "${getSeedScript("JS", detected.js)}"`], {
      shell: true,
      stdio: "inherit"
    });
  }
...

getSeedScript function (2.26.0)
function getSeedScript(type, seedFilepath) {
    let script = `
console.info('Result:')

const __seed = require('./${seedFilepath}')
const __keys = Object.keys(__seed)

async function runSeed() {
  // Execute "seed" named export or default export
  if (__keys && __keys.length) {
    if (__keys.indexOf('seed') !== -1) {
      return __seed.seed()
    } else if (__keys.indexOf('default') !== -1) {
      return __seed.default()
    }
  }
}

runSeed()
  .then(function (result) {
    if (result) {
      console.log(result)
    }
  })
  .catch(function (e) {
    console.error('Error from seed:')
    throw e
  })
`;
    if (type === "TS") {
      script = `
// @ts-ignore
declare const require: any

${script}

export {}
`;
    }
    return script;
  }

I understand why you use getSeedScript for  "An export named seed"
but why for "Seeding your database with Javascript"
When I try to remove the getSeedScript function call in 2.26.0 it works fine.
The getSeedScript function call is not useful in case we use "Seeding your database with Javascript"
Thanks for your reply

Seeding is getting reworked so this might be already fixed: #8146

I'm also having issues running the Seed script directly:
Environment variables loaded from .env
Prisma schema loaded from prisma/schema.prisma
Running seed from prisma/seed.ts ...
/Users/chenriques/Documents/proj/[eval].ts:66
export {};
^^^^^^

SyntaxError: Unexpected token 'export'
    at new Script (node:vm:100:7)
    at exec (/Users/chenriques/Documents/proj/node_modules/ts-node/src/repl.ts:251:18)
    at /Users/chenriques/Documents/proj/node_modules/ts-node/src/repl.ts:243:27
    at Array.reduce (<anonymous>)
    at _eval (/Users/chenriques/Documents/proj/node_modules/ts-node/src/repl.ts:242:18)
    at Object.evalCode (/Users/chenriques/Documents/proj/node_modules/ts-node/src/repl.ts:109:12)
    at evalAndExitOnTsError (/Users/chenriques/Documents/proj/node_modules/ts-node/src/bin.ts:457:26)
    at main (/Users/chenriques/Documents/proj/node_modules/ts-node/src/bin.ts:334:7)
    at Object.<anonymous> (/Users/chenriques/Documents/proj/node_modules/ts-node/src/bin.ts:477:3)
    at Module._compile (node:internal/modules/cjs/loader:1101:14)
Error: Command failed with exit code 1: ts-node --eval "
// @ts-ignore
declare const require: any

console.info('Result:')

const __seed = require('./prisma/seed.ts')
const __keys = Object.keys(__seed)

async function runSeed() {
  // Execute "seed" named export or default export
  if (__keys && __keys.length) {
    if (__keys.indexOf('seed') !== -1) {
      return __seed.seed()
    } else if (__keys.indexOf('default') !== -1) {
      return __seed.default()
    }
  }
}

runSeed()
  .then(function (result) {
    if (result) {
      console.log(result)
    }
  })
  .catch(function (e) {
    console.error('Error from seed:')
    throw e
  })

export {}

This was working before (not sure what was the last working version), and now it breaks running db seed.

🗒 We heard the feedback and we are planning a redesign of db seed (currently planned to be released early September)
How it will work is that a prisma.seed property in the package.json of your project will be required if you want to use prisma db seed.
This property is where you will be able to put any command you want to execute your seed script.
More info/details & how to try it out now in:
https://github.com/prisma/prisma/issues/8732

The redesign of db seed was released with Prisma 3. Please try it, this problem should be gone.


Running viewer without an dicom-server?

Hi,
Not sure if OHIF is really right for me, but i'll try anyways: I want to use the viewer without any sort of dicom-server or anything like that. I just want the user to be able to click a button to open the default OS file selector, select a dicom-file and view it in the viewer. An alternative is that the viewer loads with a pre selected file from an url. Can that be done? And if so, what documentation should i look for?
I have read about the standalone viewer etc, but i'm not sure if it can do what i want...
Thanks!

@pieper Thanks! Will check it out.
@dannyrb I'm building a web based application were dicom files sometimes will be attached to database entries, and i want the user to be able to view the image directly in the app, instead of downloading it and viewing it in an external program.

I was wondering how about adding support of viewing zip archives like the one exported from orthanc contain dicomdir or maybe with additional metadata file like the standalone viewer.
I think there is a user on the support group that shows a good working modefied wadoimageloader with the name of archiveimageloader that can load images from zip archives, maybe it would be useful to use it without much modification to the viewer

This may be of some benefit to you if your data isn't coming from a traditional PACS:
https://github.com/OHIF/Viewers/issues/733

Hi,
I've noticed that the dicom files are server through the configuration within a json file. I am looking for the same but we have all the dicom files zipped up with the below folder structure within our filesystem on centos. This file system path is accessible to the public through the url:
/[FileSystemPath]/MRI/dsr_24/T1w/run_2/raw/folder.zip
.zip contains all the .dcm files.
So can I use OHIF Viewer to open the dIcom files by directly referring to the url as
http://hostname:3000?url=hostname/FileSystemPath/UnzippedFolderContainingDicoms
or is it necessary to create a json in a definite format to include all these dicom files path?
Appreciate any suggestions on these that would help us decide if OHIF is right for us.
Thanks

@vnarepalepu, you may want to create a new issue.
We don't often revisit closed issues; open issues are kind of a running "todo list" for us.
Unfortunately you can't just point the app at a publicly accessible folder of DICOMs.
You can use our drag-n-drop local viewing functionality:

https://viewer.ohif.org/local

Or you can create JSON/schema the viewer can use in lieu of a public DICOMWeb instance. However, all files would still need to be accessible using web requests; the browser does not have permission to access files on the local system unless initiated by the user (file input, drag-n-drop, etc)
I don't know your requirements, but standing up a local PACS may be to your benefit. There are ready made docker images that simplify things quite a bit.

Thanks @dannyrb. Sorry about commenting here on closed ones. I did create a new issue #939 and did/was not getting a response.


Enable support for Java 11

GraalSqueak works on Java 8 and Java 11, we should ship jars for both of them soon.

The next release will come with components for Java 11.


Why not just Enter instead of Shift-Enter?

In the majority of cases, cells in notebooks are single-line. The one exception is the rich text editor. We could operate like a chat client and bind "enter" to new cell, and "shift-enter" to newline, because newline is relatively rare.

Yeah, I had thought about this and wasn't sure what would be most intuitive. I went with Shift-Enter because

it's the idiom that Jupyter notebooks use
it makes the rich text and formal cells behave in a uniform way

I'm open to being persuaded to go in the other direction though.

I think it would be a bit frustrating to have to remember to use shift-enter in rich text cells, now that I think about it. But I think nobody would complain if enter in other cells added a new cell, in addition to shift-enter.

Ok, I like that. It maintains consistency while making it easier to get out of formal cells.

Are we definitely sure that we don't want to allow big complicated multi-line names for, say, entities?

I doubt we want to allow multi-line names for entities because they'll be awkward to display in other parts of the UI, such as tab completion drop-downs (#22). I do think we'll to eventually allow entities that have their own pages/notebooks will additional description a la discourse graphs, but I don't think that affects the reasoning here.

Closing since I think we're happy with Shift-Enter for now.


feat: gitcoin allo integration

Adds a gitcoin allo integration and showcase a flaw in the gitcoin Allo-v2 (code still WIP not prod).
Test not added to CI since it is built on a flawed contract, but to showcase the possibility.
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

[ ] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
[ ] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
[ ] Every change is related to the PR description.
[ ] I have linked this pull request to relevant issues (if any exist).

The docker image for l1 contracts need to include the allo for ci to execute nicely.

Does not test anything new from the POV of the rollup, mainly build as a small showcase.


Project Prototyping

Start coding a prototype of the project using flask/python.
To do:

Frontend (Flask website)
API (Python scripts)
Backend (Database)

Started researching how we can use PyMongo to connect a flask app to a MongoDB server.
Link to a youtube tutorial
'https://www.youtube.com/watch?time_continue=155&v=3ZS7LEH_XBg&feature=emb_title'

Added prototype of Flask website

Basic prototype has been completed. We can now continue adding on to this prototype until we have a finished product.

Flask frontend, has work to be done.
Facial recognition API partially integrated with Flask.
Backend MongoDB partially integrated with Flask.


nextpnr error (XC7K325) : "ERROR: Cell 'ODDR_2' cannot be bound to bel 'OLOGIC_X0Y147/OUTFF' since it is already bound to cell 'ODDR_3'"

I tried  processing the litex generated  output (with demo based tweaks on generated .xdc file), however it can't generate the bitstream(vivado can process the same w/o error). Here is the error (project source xc7k325t-veriscv-nextpnr.zip ):
Info: Annotating ports with timing budgets for target frequency 50.00 MHz
Info: Checksum: 0x40513b0e
Info: Device utilisation:
Info: 	          SLICE_LUTX: 32144/407600     7%
Info: 	           SLICE_FFX: 18140/407600     4%
Info: 	              CARRY4:   985/50950     1%
Info: 	          PSEUDO_GND:     1/86505     0%
Info: 	          PSEUDO_VCC:     1/86505     0%
Info: 	               HARD0:     0/ 3660     0%
Info: 	   RAMB18E1_RAMB18E1:    41/  890     4%
Info: 	   FIFO18E1_FIFO18E1:     0/  445     0%
Info: 	RAMBFIFO36E1_RAMBFIFO36E1:     0/  445     0%
Info: 	   RAMB36E1_RAMB36E1:    16/  445     3%
Info: 	     DSP48E1_DSP48E1:    16/  840     1%
Info: 	                 PAD:    71/ 1460     4%
Info: 	       IOB33M_OUTBUF:     0/  168     0%
Info: 	       IOB33S_OUTBUF:     0/  168     0%
Info: 	        IOB33_OUTBUF:    16/  350     4%
Info: 	     IOB33M_INBUF_EN:     0/  168     0%
Info: 	     IOB33S_INBUF_EN:     0/  168     0%
Info: 	      IOB33_INBUF_EN:    13/  350     3%
Info: 	IOB33M_TERM_OVERRIDE:     0/  168     0%
Info: 	IOB33S_TERM_OVERRIDE:     0/  168     0%
Info: 	 IOB33_TERM_OVERRIDE:     0/  350     0%
Info: 	       PULL_OR_KEEP1:     0/  980     0%
Info: 	   IDELAYE2_IDELAYE2:    16/  500     3%
Info: 	        OLOGICE3_TFF:     0/  350     0%
Info: 	      OLOGICE3_OUTFF:     8/  350     2%
Info: 	       OLOGICE3_MISR:     0/  350     0%
Info: 	 OSERDESE2_OSERDESE2:    44/  500     8%
Info: 	        ILOGICE3_IFF:     4/  350     1%
Info: 	ILOGICE3_ZHOLD_DELAY:     0/  350     0%
Info: 	 ISERDESE2_ISERDESE2:    16/  500     3%
Info: 	         BUFIO_BUFIO:     0/   40     0%
Info: 	IDELAYCTRL_IDELAYCTRL:     1/   10    10%
Info: 	            BUFGCTRL:     7/   32    21%
Info: 	           SELMUX2_1:    37/154550     0%
Info: 	           BUFG_BUFG:     0/   32     0%
Info: 	       BUFHCE_BUFHCE:     0/  168     0%
Info: 	 PLLE2_ADV_PLLE2_ADV:     1/   10    10%
Info: 	            INVERTER:     3/  240     1%
Info: 	              BUFFER:     0/  480     0%
Info: 	        ILOGICE2_IFF:     0/  500     0%
Info: 	       OLOGICE2_MISR:     0/  500     0%
Info: 	      OLOGICE2_OUTFF:     0/  500     0%
Info: 	        OLOGICE2_TFF:     0/  500     0%
Info: 	   IOB18_INBUF_DCIEN:    16/  150    10%
Info: 	  IOB18_OUTBUF_DCIEN:    41/  150    27%
Info: 	 IOB18_TERM_OVERRIDE:     0/  150     0%
Info: 	  IOB18S_INBUF_DCIEN:     0/   72     0%
Info: 	 IOB18S_OUTBUF_DCIEN:     3/   72     4%
Info: 	IOB18S_TERM_OVERRIDE:     0/   72     0%
Info: 	  IOB18M_INBUF_DCIEN:     2/   72     2%
Info: 	 IOB18M_OUTBUF_DCIEN:     3/   72     4%
Info: 	IOB18M_TERM_OVERRIDE:     0/   72     0%
Info: 	IDELAYE2_FINEDELAY_IDELAYE2_FINEDELAY:     0/  150     0%
Info: 	   ODELAYE2_ODELAYE2:     0/  150     0%
ERROR: Cell 'ODDR_2' cannot be bound to bel 'OLOGIC_X0Y147/OUTFF' since it is already bound to cell 'ODDR_3'
0 warnings, 1 error
make: *** [Makefile:41: qmtech_kintex.fasm] Error 255

Your verilog says the Cells (=Instances)  ODDR_2 and ODDR_3 are bound to these signals:

Yes, the OE signal should be bound to OLOGIC_X0Y147/TFF, not OUTFF.
Will look into this.

I just committed a fix on this branch:
https://github.com/openXC7/nextpnr-xilinx/tree/issue4-oddr-tristate
Can you build nextpnr-xilinx from source to test?
Note: You use jtagbone in your design, which uses the BSCANE2 primitive, which is currently unsupported.

ERROR: Unable to place cell 'STARTUPE2', no BELs remaining to implement cell type 'STARTUPE2'
0 warnings, 1 error
make: *** [Makefile:41: qmtech_kintex.fasm] Error 255

Anything I missed?

STARTUPE2 is also not supported yet.

Which means you cannot use this class from LiteSPI yet.

STARTUPE2 support is planned, but not at top priority at the moment, because I am working on GTP at the moment.

Thank you!


Question about the ground station setup. Does it still use the EZ-WifiBroadcast as backend?

Is there possibility to use the wfb-ng as groundsatiton base?
I thik it just got support for android devices with powerful encoding abilities!

wfb-ng-based projects like openipc expect h264 or h265 stream, esp32 can send mjpeg only.
You still can use the same ground station hardware but with esp32-cam-fpv groundstation software.


Merge branch-listEvents-V1.2 with master

Closes #37

Codecov Report
Base: 72.15% // Head: 70.78% // Decreases project coverage by -1.37% :warning:

Coverage data is based on head (0949718) compared to base (01d8573).
Patch coverage: 4.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #54      +/-   ##
============================================
- Coverage     72.15%   70.78%   -1.38%
  Complexity      399      399
============================================
  Files            70       72       +2
  Lines          1232     1256      +24
  Branches        125      128       +3
============================================
  Hits            889      889
- Misses          311      334      +23
- Partials         32       33       +1

Impacted Files
Coverage Δ

...eedu/address/logic/commands/ListEventsCommand.java
0.00% <0.00%> (ø)

.../seedu/address/logic/parser/AddressBookParser.java
88.88% <0.00%> (-11.12%)
:arrow_down:

src/main/java/seedu/address/ui/EventCard.java
0.00% <0.00%> (ø)

...rc/main/java/seedu/address/ui/PersonListPanel.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/model/Model.java
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

LGTM! No issues with last two commits


support for data files

The possiblity of data files that can be used by a program
Probably something that should be given thought to as to how to create a general solution.
use case should be added to this enhancement issue.
 This is copied from slack: Jonny suggested to be able to add data files in the project (e.g. Text file) and we would automatically pre-populate the filesystem with those files when flashing the device.

Please file this feature request in PXT.


Fix panic in AssertJSONMatchesPattern

Came across a panic in pulumi-tls.
  panic: runtime error: index out of range [1] with length 1 [recovered]
  	panic: runtime error: index out of range [1] with length 1

Simple bug fix - when matching an array against the pattern, if the array lengths don't match we're done. No need to compare elements. Alternatively we could compare elements but check for out-of-bounds/missing elements, but this should be good enough for now I think.

Hmm, that was convoluted to add tests. Looks like this is due to the code logic being entwined with the testing.T ?

Are we certain discussing this simple change further has a ROI? Go does not make testing test helpers easy, since you insisted on testing this is the most straightforward way I can do this.  Are there alternatives you are suggesting?

I think the benefit we should be looking for is raising the quality bar. We already know there was an unseen flaw so should take the opportunity to add a rigorous set of tests that form a specification of behaviour and edge cases which seems to be missing in the first place, rather than reactively adding a single special case test.
The follow-up question is if it's worth refactoring to make the testing easier, or add a bit more test harness as you've opted for here.
This probably isn't the most critical piece of code ever, but we need to start raising the bar somewhere.

The follow-up question is if it's worth refactoring to make the testing easier

Not really, no.

or add a bit more test harness as you've opted for here.

Generally not been seeing any correctness issues with this code. This one is not a correctness issue but an annoyance - the test correctly fails but panics instead of failing gracefully.

we need to start raising the bar somewhere.

In my book the place to start is in end-user facing and impactful code.


The destructor of pdf should be virtual

In my environment with OSX, this destructor cause EXC_BAD_INSTRUCTION.
So I think it should be virtual.

Additional Information
I had a following warning from compiler.
####################
warning: deleting object of abstract class type ’xxx ’
which has non-virtual destructor will cause undefined behaviour
####################
So I think,this lead to EXC_BAD_INSTRUCTION.
I tried creating a similar sample which only performs delete with abstract class, and the same error occurred.


[SR-8617] Index explicit types in enum cases

Similar to https://github.com/apple/swift/pull/19938, explicitly defining a type in enum patterns such as if case Foo.bar = x {} was resulting in the type portion not being indexed. This is somewhat common if you have an enum inside a nested type, so this checks the existence of an explicit parent and walks it as well.
Resolves SR-8617.

@swift-ci please smoke test


Update to svd2rust 0.16-based PACs

This was surprisingly easy! (assuming it actually works on hardware...)
Marking as a draft, since it includes a patch section in the root Cargo.toml to use the git versions of the PACs. That commit should be reverted once the PAC updates are released.

Note, for the nrf91 part of this, we are blocked by https://github.com/themadinventor/nrf91-rs/issues/3.

The nRF52 PACs are now at 0.9.0, which is generated by svd2rust 0.16 or 0.17 (they should be compatible). I don't have access to fix the nrf91 crate though.

This was finished in https://github.com/nrf-rs/nrf52-hal/pull/134


Text-embeddings

In order to know which slides are related to each other and group slides by content, it might be useful to explore text-embeddings. To minimize costs, I propose to try mxbai-embed-large and ollama-python.
We could reuse infrastructure developed in #8 to turn PDFs into images, then images into text, and text into embeddings. The embedding could then be explored interactively using a notebook similar to this one.

Thanks! I am working on it. I just wanted to add that in the example notebook the code for the stackview.sliceplot is somehow not working correctly as you don't actually see the plot! But it worked after i tried it myself, so it should work actually.

Don't worry about the interactive plot. This doesn't render on the github website :-)

Don't worry about the interactive plot. This doesn't render on the github website :-)

Alright! I also tried to do it in the Notebook I downloaded but still I can't really select the data points like it is supposed to be. I only can draw a circle but the data points are not chosen as a selection afterwards.. Have you ever encountered that problem?

That's the plan right now. @haesleinhuepf Feel free to say if you would change anything. Otherwise I would work on that! I already have some kind of prototype notebook for this workflow!

[ ] image-text dict (.json) should not be saved for each pdf , but rather one dict for all pdfs (check if it is already existing when saving the dict and just 'append' data if it does)

[ ] load dict and create embedding for the texts in it (inspired from here)

[ ] mxbai-embedding

[ ] UMAP

[ ] create pd Dataframe for all data

[ ] interactively plot all images (load them from the dict) and their corresponding umap representation


Remove or make less prominent legacy contributing guide

There is a link to an outdated contributing guide here: https://github.com/apache/superset/blob/master/docs/docs/contributing/contributing.mdx?plain=1#L22
It is likely the first link to a contributing guide a user see's when following the link specified in CONTRIBUTING.md.
This guide leads users down the likely painful path of trying to set up a developer environment without docker compose, as I have just experienced.
This link should be removed, moved to a less prominent position and/or a warning added with a link to the relevant up to date page which is available in the side bar menu.

Thanks for pointing this out.  Just to be clear, you are saying the problem is the link to https://preset.io/blog/tutorial-contributing-code-to-apache-superset/ because that blog post is obsolete - correct me if that's not right.
An easy fix would be to remove that link.  I wonder if that content would have been better off as part of the official docs, where it would be easier to keep updated.  I'm fine with removing that link, but will also ping @mistercrunch and @rusackas as people who have thoughts about developer docs and the Preset blog.

Fine by me to remove it. I opened a PR to do so.
In a perfect world, we'd have the bandwidth to go back and change all our old blog posts to keep them fresh and current, but that's more than a full time job at this point, so we're probably better off treating them as time capsules, like so many blogs do. If anything, it's probably time for a NEW blog post on the topic!

Thanks both.


Update to Swift 3.0

This pull request includes all the gesture projects and the SpriteKit project

Thanks! 👍


Add Helm value for specifying the provider name

And render app: cluster-<provider> label instead of app: cluster label.
Towards https://github.com/giantswarm/roadmap/issues/3047
What does this PR do?

Add Helm value for specifying the provider name.
Render app: cluster-<provider> label instead of app: cluster label.

What is the effect of this change to users?
When deploying a WC, app: cluster-<provider> is unmodified.
Any background context you can provide?
Cluster upgrade tests are failing in https://github.com/giantswarm/cluster-aws/pull/460, because we have ClusterResourceSet that has app: cluster-aws in the selector.
Changing app: cluster-aws to app: cluster in Cluster resources breaks the ClusterResourceSet's selector. OTOH we cannot change ClusterResourceSet's selector because it is immutable.
So the fastest fix here, and that maybe even makes sense long-term, is to render app: cluster-<provider> label in the cluster chart. It may make sense even as a long-term permanent change (not just a fix for this) because cluster-<provider> is the app that we are actually deploying, while cluster is the subchart.
Should this change be mentioned in the release notes?

[x] CHANGELOG.md has been updated (if it exists)

Wouldn't this make it weird? The CRs would contain labels like
    app: cluster-aws
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/version: 0.1.0
    helm.sh/chart: cluster-0.1.0

The app label and helm.sh/chart wouldn't mention the same chart/app. Also 0.1.0 is not the version of what's specified in the app label.
If I think about the purpose of the clusterSelector field on the ClusterResourceSet CR, I believe the best would be to only select clusters based on their name (and maybe watch-filter, I'm not sure if that's still required).
spec:
  clusterSelector:
    matchLabels:
      cluster.x-k8s.io/cluster-name: t-lhqb2d2zh9dd9hn659
      cluster.x-k8s.io/watch-filter: capi

Wouldn't this make it weird? The CRs would contain labels like
app: cluster-aws
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/version: 0.1.0
helm.sh/chart: cluster-0.1.0
The app label and helm.sh/chart wouldn't mention the same chart/app. Also 0.1.0 is not the version of what's specified in the app label.

Yeah, well, yes and no IMO 😄
These two being different is weird because there is name of one app, but version from the other app (and only cluster-aws here is deployed as the app).
app: cluster-aws
app.kubernetes.io/version: 0.1.0

So here we should have both from cluster-aws like this:
app: "cluster-aws"
app.kubernetes.io/version: 0.50.0

I don't know if parent chart can pass its version to a subchart, I did not found a way (setting it in some random Helm value would be weird and error prone), so we can maybe just not set app.kubernetes.io/version at all.
Then, chart label being different is fine I would say, because now we really have multiple charts, and resources really come from different charts, so it could be even helpful to see which chart is rendering the resource.
helm.sh/chart: cluster-0.1.0

If I think about the purpose of the clusterSelector field on the ClusterResourceSet CR, I believe the best would be to only select clusters based on their name

Yeah, agreed there, I would maybe add organisation name to the cluster name. Just not sure how we can change that selector in ClusterResourceSet, because the selector is immutable. Maybe by deleting ClusterResourceSet first (in a pre-install hook?) and then let Helm redeploy it with new selector labels. So from what I see, we either find a way to do this and have new simpler selector labels, or we set app: cluster-aws label in cluster chart so it's backward compatible.

So current idea for making this better:

We fix selector labels like described above
We add a Helm pre-upgrade hook that deletes ClusterResourceSets, so that Helm can install ClusterResourceSets with new label selectors

And we can maybe completely ditch these two labels:
app: cluster-aws
app.kubernetes.io/version: 0.1.0

And maybe just set
app.kubernetes.io/part-of: cluster-aws

Which is recommended here https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/#labels:

The name of a higher level application this one is part of

and maybe watch-filter, I'm not sure if that's still required

I guess we can leave it in common labels for now, just in case, but I don't think we need it in the selector labels there.

And maybe just set
app.kubernetes.io/part-of: cluster-aws

Or set
app.kubernetes.io/name: cluster-aws
app.kubernetes.io/component: cluster

Maybe it's not worth changing ClusterResourceSets selector and mess with that, as they will go away once we upgrade to 1.25 and PSPs are removed.

Maybe it's not worth changing ClusterResourceSets selector and mess with that, as they will go away once we upgrade to 1.25 and PSPs are removed.

Right, good point, so at least for now we keep app: cluster-aws label.
I will also remove the label app.kubernetes.io/version that has cluster chart version (we will still have helm.sh/chart: cluster-0.1.0) and remove the weirdness there.
And set these two labels:
app.kubernetes.io/name: cluster-aws
app.kubernetes.io/component: cluster

app.kubernetes.io/component sounds more correct than app.kubernetes.io/part-of.

Isn't there a possibility to get the labels from the parent chart?

I checked the Helm labels guidelines here https://helm.sh/docs/chart_best_practices/labels/
According to Helm guidelines it would be something like this (different than what I wrote above):
    app.kubernetes.io/name: "cluster"
    app.kubernetes.io/version: "0.1.0"
    app.kubernetes.io/part-of: "cluster-aws"
    app.kubernetes.io/instance: "awesome"
    app.kubernetes.io/managed-by: "Helm"

So all labels are about the cluster chart (the one that is rendering the resource), and app.kubernetes.io/part-of is the only one pointing to the parent chart.

So I would go with these Helm guidelines, as they are a bit more specific/precise than the Kubernetes "general" labels guidelines here.
And we keep this with a comment:
    # app label is deprecated and it will be removed after upgrading to Kubernetes 1.25
    app: "cluster-aws"

I really like the idea of going with Helm best practices, they sound good! Do they fit our needs?

I really like the idea of going with Helm best practices, they sound good! Do they fit our needs?

Yeah, well at least they do no get in our way.
In order to fix the issue we need this part:
    # app label is deprecated and it will be removed after upgrading to Kubernetes 1.25
    app: "cluster-aws"

The rest would be to follow Helm guidelines and it is not causing any issues here.
It would be just a bit weird initially as we would have these two together:
    # app: "cluster-aws" label is deprecated and it will be removed after upgrading to Kubernetes 1.25
    app: "cluster-aws"
    app.kubernetes.io/name: "cluster"

But some deprecation message like that should clarify it.

Hm, I'm fine with that. Just take care of selector labels, they normally are immutable. But if I see correctly, there are no such labels in the chart.

Just take care of selector labels, they normally are immutable. But if I see correctly, there are no such labels in the chart.

Yeah, this is what prompted this PR initially.
Using cluster chart in cluster-aws is failing because the existing ClusterResourceSet already has a selector with app: cluster-aws, and in the cluster chart we are currently setting app: cluster and because of that ClusterResourceSet does not see the resources anymore with its selector, so we're fixing that here in the PR by changing app: cluster back to app: cluster-aws.