en-GB locale causes timestamps to be written with a ,

Reported by xpac in the Slack, when used with en-GB.UTF-8 locale we are writing , in the timestamp instead of a .. This isn't valid JSON and is causing the CLI to error.

Just adding, the _value field has the same issue.

Was able to reproduce on ubuntu:
First, the setup:
cribl@ubuntu18_4:~/appscope$ locale -a
C
C.UTF-8
en_US.utf8
POSIX
cribl@ubuntu18_4:~/appscope$ sudo locale-gen de
Generating locales (this might take a while)...
  de_AT.UTF-8... done
  de_BE.UTF-8... done
  de_CH.UTF-8... done
  de_DE.UTF-8... done
  de_IT.UTF-8... done
  de_LI.UTF-8... done
  de_LU.UTF-8... done
Generation complete.
cribl@ubuntu18_4:~/appscope$ locale -a
C
C.UTF-8
de_AT.utf8
de_BE.utf8
de_CH.utf8
de_DE.utf8
de_IT.utf8
de_LI.utf8
de_LU.utf8
en_US.utf8
POSIX
cribl@ubuntu18_4:~/appscope$ LC_ALL=de_DE.utf8 date +%A
Donnerstag

Then repro'ing:
LC_ALL=de_DE.utf8 LD_PRELOAD=lib/linux/libscope.so SCOPE_EVENT_DEST=file://stdout whoami

Then after the fix:
{"type":"evt","body":{"sourcetype":"console","id":"ubuntu18_4-whoami-whoami","_time":1612468169.632,"source":"stdout","host":"ubuntu18_4","proc":"whoami","cmd":"whoami","pid":87701,"_channel":"656602535889526","data":"cribl"}}

I did verify that the fix applies correctly to the _value field too, btw.


Added APM instructions

Added Java SE and Tomcat instructions for AppDynamics and Dynatrace.
Handing this to @rloutlaw for review.

@JasonFreeberg : Thanks for your contribution! The author, @rloutlaw, has been notified to review your proposed change.

@JasonFreeberg @rloutlaw Microsoft authors and contributors need to make content contributions through the private repository so the content can be staged and validated by the current validation rules.
After you review staging and fix all validation issues, you can add the sign-off comment to let PR reviewers know that the updates are ready to be merged.
Read about authors working in the public repo for more information.
If you need help getting set up to work in the private repo, see Set up Git repository locally for documentation.
We'll close this PR. Thank you


As a hardware developer, I want to create a reliable electronic system that can efficiently power and control the robot's hardware components.

Acceptance Criteria:

The electronic system must provide stable power to all components.
The system must facilitate communication between the robot's sensors, actuators, and processing units.

Todo list:

[x] #13
[x] #14

All items were implemented.


Interactive data science environment runs in a temp directory by default

Environment data

VS Code version: 1.29.1
Extension version (available under the Extensions sidebar): 2018.10.1
OS and version: MacOS 10.14.1
Python version (& distribution if applicable, e.g. Anaconda): Anaconda, 3.6
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): N/A
Relevant/affected Python packages and their versions: N/A

Actual behavior
If I open a notebook, I expect my working directory to be the notebook directory, so I can load up others files in that directory using paths starting with "./". However, it appears the working directory is a temporary directory (e.g. /private/var/folders/gq/1zp9x1h125j7w4_gbb4kryv00000gn/T)
Expected  behavior
Working directory should be notebook directory by default.
Steps to reproduce:

Run:
#%%
!pwd

Comment on our blog post, we might consider always defaulting to workspace root, even when the file is saved:
Hello,

great stuff, we’re loving it in our data science team !
However, the server starts in the file folder and not in the opened folder.
Hope it will come soon, it’s frustrating !

But keep up this good work 🙂

I think this is going to remain this way for now. We need a notebook file. We generate one in your temp folder. The current directory should still work though. We pass %cd to the kernel before every execute.

Hmm. Jupyter doesn't have this problem with a temp notebook though. Maybe there's something we can pass as the current directory.

Oh jupyter writes out a temp file to the current folder. That seems really bad for us since the user isn't necessarily generating a notebook

Yeah I think we should just fix the cd for a temp python file to be the workspace, everything else should be the file directory (otherwise relative output in that file won't match working python code)
Example:
F:\Foo\SubDir\MyFile.py
pd.read_csv("..\Data.csv")
If the user opens workspace at F:\Foo, then this file doesn't work.

@rchiodo the feedback from the user above suggests that they expected it to do:
F:\Foo\SubDir\MyFile.py
pd.read_csv("Data.csv")

Which would also be consistent with the behavior of "run python file in terminal", and debugging.
E.g. given a folder structure of:
newcode
  - subdir
     - myfile.py

With newcode open as the workspace root, and if you F5 on myfile.py or run myfile.py in the terminal, you will see it run out of newcode:
C:\dev\newcode>python c:/dev/newcode/subdir/myfile.py
C:\dev\newcode

C:\dev\newcode>

Myfile.py just prints os.getcwd()

So I think what you're saying is that when running a python file, the current directory is always set to the workspace root (and not where the file is)? What about in a multi-root scenario?

Okay that should be an easy fix. Instead of cd to the file directory at the beginning of the execute, we cd to the workspace root of the file, or the first root if the file doesn't exist.
Thanks @qubitron

@ronglums even for this case we run the file in whatever the current workspace root is, e.g. I opened this file outside of the current workspace:
C:\dev\hello5>python c:/dev/hello3/hello.py
Hello world!

Not saying it's necessarily the correct behavior, but in absent of strong feedback being consistent is a good default choice.

Let’s be consistent with what Jupyter does (I think that is based on file
location but I’m not sure). That way an imported noteboook should just work.
BTW made it to LAX. Will get to Auckland eventually.
On Tue, Nov 20, 2018 at 5:34 PM Dan Taylor<EMAIL_ADDRESS>wrote:

@ronglums https://github.com/ronglums even for this case we run the
file in whatever the current workspace root is, e.g. I opened this file
outside of the current workspace:
C:\dev\hello5>python c:/dev/hello3/hello.py
Hello world!
Not saying it's necessarily the correct behavior, but in absent of strong
feedback being consistent is a good default choice.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode-python/issues/3407#issuecomment-440495506,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AConiDZB25OnKVxSiYLxZa6isEcqGMs3ks5uxK2ggaJpZM4YqIEW
.

Comment on our blog post, we might consider always defaulting to workspace root, even when the file is saved:
Hello,

great stuff, we’re loving it in our data science team !
However, the server starts in the file folder and not in the opened folder.
Hope it will come soon, it’s frustrating !

But keep up this good work 🙂

Hello there, that's my post on the blog !
yeah, I wasn't clear.
The question is  indeed the mismatch between jupyter behaviour (workdir is file dir) and python (workdir  is folder dir), which is inconsistent.
@qubitron pointed the python behaviour. I think it's the logic one as it would not hinder interactive code and promote good py packaging practice.
Maybe a feature request (as a user setting) more than a bug ?


Update qemu: 7.2.0 -> 8.0.0

What this PR does / why we need it:
At the moment, make rpm-deps fails with Error: Package qemu-img-17:7.2.0-14.el9 does not exist
Considering that 7.2.0 version is not present in c9s/packages - I thought it would make sense to update.
Special notes for your reviewer:

The c9s rebase MR is gitlab/qemu-kvm/#100
Libvirt was recently rebased to 9.5.0 but I'm not sure we should update it already. What do you think @andreabolognani ?

Release note:

QEMU updated to 8.0.0

/approve
/hold
Please, unhold when the CI is green

/retest-required

@victortoso we usually update all virtualization packages at the same time to roughly match what's going to be in the upcoming RHEL release, as that gives us better confidence that the various components have been tested together.
In this specific case, I would wait for libvirt 9.5.0 to be available from mirrors and include that in the update. The build has already happened, but IIRC it might take up to a couple of weeks to actually show up on the various mirrors...
If QEMU 7.2.0 no longer being available from mirrors is a blocking issue, we can perform the update in two steps, but otherwise I would do everything in one go.

@victortoso @andreabolognani maybe instead of jumping to 8.x.x we could check if there is a more recent version for 7.2.x? If the updating isn't working anymore it is an issue

jfyi, this is not a blocker to me. I can easily workaround it.

/hold
until we clarify how to upgrade

I don't see an intermediate version. andreabolognani do you know what regular centos stream users should expect? I mean right now they are getting a newer QEMU version independently from what KubeVirt does

@alicefr unfortunately there's no good answer to this in the context of CentOS Stream. It's a rolling release, and newer packages replace the older ones as time goes on.
For KubeVirt specifically, the fact that all packages that make their way to the WORKSPACE are mirrored to a separate cloud storage is a partial mitigation, meaning that building KubeVirt is not affected by this. Some development workflows still are.

jfyi, this is not a blocker to me. I can easily workaround it.

@victortoso if you have a workaround, my preference would be to wait until libvirt 9.5.0 can be found on mirrors, and then do a big-bang refresh of the entire virtualization stack. I can take care of that in a week or so.

@victortoso if you have a workaround, my preference would be to wait until libvirt 9.5.0 can be found on mirrors, and then do a big-bang refresh of the entire virtualization stack. I can take care of that in a week or so.

That's fine by me. I'll close this one when you do the bulk update but If you happen to not have the time, let me know.

I see at least some koji builds for 9.5 Is libvirt 9.5 available now in centos stream?

Not yet, unfortunately :(
There was some issue with the build system and the 9.5.0-1 build couldn't make it all the way through the process. The maintainer has submitted a 9.5.0-2 build and that's looking a lot better already, but it's going to be at least a few days before it makes it into a CentOS Stream 9 compose.
I'm tracking this pretty closely though, and as soon as a 9.5.0 build is available I'll prepare a PR updating the entire virt stack.

Quick update. The package maintainer for libvirt let me know that we're unfortunately not likely to get a usable 9.5.0 build until early August :(

ok, given that we branche 1.0 and since we see that tests seem to work fine, I would vote for updating this PR once agian to use latest RPM packages and merge it as is and follow up later. We still have some months before we do the next release. @andreabolognani what do you think?

I've updated the branch for now. I had to update edk2 because, like QEMU, the current version is not longer in c9s repos. Because I updated edk2,  libvirt had to be updated to solve the conflict libvirt-daemon-driver-qemu-0:9.0.0-3.el9 conflicts with edk2-aarch64-0:20230524-2.el9.

/retest

/lgtm

Hm. This looks like we need to modify a little bit more:
Unexpected Warning event received: testvmi-btpl8,c1d26c79-ff43-44e6-98a0-184fec965bc0: server error. command SyncVMI failed: "LibvirtError(Code=67, Domain=10, Message='unsupported configuration: itco model of watchdog is part of the machine and cannot have any address set.')"

Hm. This looks like we need to modify a little bit more:
Unexpected Warning event received: testvmi-btpl8,c1d26c79-ff43-44e6-98a0-184fec965bc0: server error. command SyncVMI failed: "LibvirtError(Code=67, Domain=10, Message='unsupported configuration: itco model of watchdog is part of the machine and cannot have any address set.')"

This is fixed here https://github.com/kubevirt/kubevirt/pull/10137

@rmohr if there is nothing being blocked on virt packages being at the current versions I would personally prefer waiting and updating everything in one go once libvirt 9.5.0 is available.  But if the 1-2 weeks wait that's currently expected is too long, then feel free to go ahead with this PR and I'll take care of doing another update as a follow-up.

/retest
So, just to clarify, this is not a blocker for me but I understand that anyone needing to update/add packages might hit this issue. If we want to move forward with this PR, I'd suggest having Vasiliy #10137 first to solve the underlying problem with watchdog. Up to you all.

/retest
/unhold

I think that takes a little bit too long to justify not being able to easily update packages on main during development.
@andreabolognani thanks for tracking this either way!
I think if we would do proper CVE tracking, we would also have to update on the release branches ...

@rmohr should unhold https://github.com/kubevirt/kubevirt/pull/10137 as well? The tests here are going to fail without it

@rmohr should unhold #10137 as well? The tests here are going to fail without it

Right. Done. :+1:

Both 1.26-sig-compute and 1.27-sig-compute are failing at:
 05:18:13: [sig-compute]Configurations VirtualMachineInstance definition [rfe_id:2262][crit:medium][vendor:cnv-qe@redhat.com][level:component]with EFI bootloader method [It] [Serial][test_id:4437]should enable EFI secure boot [sig-compute]
05:18:13: tests/vmi_configuration_test.go:656

I'll investigate

With current main branch
$ k create -f examples/vmi-secureboot.yaml
$ ./cluster-up/virtctl.sh console vmi-secureboot

[fedora@vmi-secureboot ~]$ dmesg | grep -i secureboot
[    0.000000] secureboot: Secure boot enabled
[    0.016676] secureboot: Secure boot enabled
[fedora@vmi-secureboot ~]$ sudo mokutil --sb-state
SecureBoot enabled

With this branch
$ k create -f examples/vmi-secureboot.yaml
$ ./cluster-up/virtctl.sh console vmi-secureboot

[fedora@vmi-secureboot ~]$ dmesg | grep -i secureboot
[    0.000000] secureboot: Secure boot disabled
[    0.016197] secureboot: Secure boot disabled
[fedora@vmi-secureboot ~]$ sudo mokutil --sb-state
SecureBoot disabled
Platform is in Setup Mode

Happy that we have functional tests. Some behavior changed that we might need to adapt/fix. I'm trying to understand what was it. cc @andreabolognani, in case you have a clue.

Oh we ran into that recently: https://gitlab.com/libvirt/libvirt/-/issues/500

/hold
let's stop CI for now.

Perhaps the best solution is to adapt to newer firmware selection?

Switching to feature-based firmware autoselection would almost certainly be the right move in the long run.
I think I tried looking into how much work that would be a while ago, but I remember being deterred by the fact that IIRC the path to the directory containing firmware files was passed around as an argument to virt-handler, which made me concerned about the potential ramifications.
Anyway, I'm currently working on libvirt patches that will address the issue, and I'm targeting them at RHEL 9.3 so they will be included in a future 9.5.0 build. However, I'm afraid such a build won't be available for a while longer...

Switching to feature-based firmware autoselection would almost certainly be the right move in the long run.

Okay, I'll start looking into it now. Also, I just saw that libvirt-9.5.0-5.el9.x86_64.rpm was included in c9s.

I just saw that libvirt-9.5.0-5.el9.x86_64.rpm was included in c9s.

Yup, I just noticed that too. At this point, it makes sense to incorporate that change into this PR and get everything in at the same time.

At this point, it makes sense to incorporate that change into this PR and get everything in at the same time.

Okay. The change to firmware autoselection can actually drop/change a bit more code but I added the bare minimal to see if we can get CI green first. I need to double check what chances it brings to configuration related to SEV, if any.

I need to double check what changes it brings to configuration related to SEV, if any.

@victortoso, FYI: SEV test job is not set as mandatory as of now. You can trigger it explicitly via
/test pull-kubevirt-e2e-k8s-1.26-sev

I need to double check what changes it brings to configuration related to SEV, if any.

@victortoso, FYI: SEV test job is not set as mandatory as of now. You can trigger it explicitly via
/test pull-kubevirt-e2e-k8s-1.26-sev

The SEV node is not available at the moment - I am checking with AMD on the status of it.

@andreabolognani, CI seems happy so far. Are you aware of any further issues related to moving from legacy uefi template to firmware autoselection? If not, autoselection seems to simplify a lot and I can work on doing some cleanups around EFI vars that we might not need anymore (in this PR or in a follow up).
The interesting commit is https://github.com/kubevirt/kubevirt/pull/10050/commits/274bdef1fca478ddb6a6c56eacb2ed0c23c2cb99

The SEV node is available again.
/test pull-kubevirt-e2e-k8s-1.26-sev

@victortoso I've taken a look at how KubeVirt currently implements firmware selection and tried to figure out whether switching to libvirt firmware autoselection would cause problems. I'll leave my thoughts here, in no particular order.

You're using
<os firmware='efi'>
  <loader secure='yes/no'/>
</os>

to request that Secure Boot is enabled/disabled, which is... Fine. The current recommendations, however, involve enabling/disabling specific firmware features, such as
<os firmware='efi'>
  <firmware>
    <feature enabled='yes/no' name='enrolled-keys'/>
  </firmware>
</os>

Thanks to a bunch of compatibility code in libvirt, the end result is roughly the same, but if we're moving to firmware autoselection it would make sense to adopt the best practices.
I say roughly the same, because the secure attribute maps more accurately to the secure-boot firmware feature, which is however not necessarily the one you really want to control when you talk about enabling/disabling Secure Boot support. Some additional information about the topic can be found here. The takeaway is that enrolled-keys=no results in selecting OVMF_CODE.secboot.fd but keeping the Secure Boot feature disabled, while secure-boot=no results in selecting OVMF_CODE.fd which doesn't contain Secure Boot support at all.
It might be useful to compare this with your laptop's firmware settings. Turning off Secure Boot in the menu will obviously not result in a different EFI build, one with no Secure Boot support in it, being flashed on the spot :) Secure Boot support will still be present, but not active. This is the behavior you get with enrolled-keys=no.

Non-default firmware images, such as those needed on aarch64 and for SEV VMs, haven't been touched. We obviously need to ensure that those configurations keep working.

Currently the admission webhook has specific code that ensures that the SMM feature has been enabled when Secure Boot is requested, but firmware autoselection will automatically enable SMM in that case so the code should be dropped. Users will have one less think to consider when building the VM YAML, yay!

Speaking of the SEV use case, we're currently manually adding a symlink to OVMF_CODE.cc.fd via Bazel. With firmware autoselection, that's no longer needed or indeed desirable.

One thing that concerns me quite a bit is what happens to the NVRAM store between boots. The firmware autoselection process is driven by the contents and priority of JSON firmware descriptor files available on the system, and that can change between OS releases: as a concrete example, the latest build of edk2 has been changed so that, on aarch64, qcow2 firmware images are preferred to raw images.
libvirt will do its best to preserve the behavior of existing guests, but in the case of KubeVirt the VM is effectively defined from scratch before every single boot, at least based on my understanding. So libvirt could pick raw firmware for one boot, qcow2 firmware for the next, and suddenly the existing NVRAM store can no longer be parsed and the VM doesn't start.
Is the NVRAM store even preserved across boots? I've tried creating an EFI-enabled VMI and the directory where the files are stored was backed by an emptyDir, so it would seem that the NVRAM store gets thrown out every time? That would avoid the issue I was talking about, but also feels problematic for other reasons. What about the TPM's state, if one is configured? Is that also reset every single time?

Removing the check on the path of the NVRAM store is probably not a good idea. Even with autoselection enabled, we still want to make sure that libvirt generates the path we expect. Since that information is added at VM define time, however, the check will have to be moved from a unit test to a functional test.

The OSFirmwareBios constant doesn't serve any purpose AFAICT.

I'm sure I've missed a bunch of stuff. I'll add it when it pops back into my head :)

@victortoso @andreabolognani Do we need anything else here? Can we separate the auto selection from the PR?

@victortoso @andreabolognani Do we need anything else here? Can we separate the auto selection from the PR?

At the moment, updating libvirt without firmware auto selection would break secureboot see this comment. Although I haven't tested, this patch series should fix the problem and they were reviewed but not merged yet.
Not sure what the best course of action is:

Don't change to auto selection and wait to libvirt get the fixes in c9s (I'd guess two weeks or more)
Update to firmware auto selection with this PR (might take some days to get it right)
Don't update firmware auto selection with this PR (we drop this change for now) and do it in a different PR, breaking secureboot in the meanwhile.

I'd vote for 1 while doing the firmware auto selection in a different PR. If we get auto selection before the libvirt fixes, we should be able to move forward with updating rpms anyway.

At the moment, updating libvirt without firmware auto selection would break secureboot see this comment. Although I haven't tested, this patch series should fix the problem and they were reviewed but not merged yet.

It's been merged upstream now, and I've already prepared a backport targeting CentOS Stream 9.

Not sure what the best course of action is:

Don't change to auto selection and wait to libvirt get the fixes in c9s (I'd guess two weeks or more)
Update to firmware auto selection with this PR (might take some days to get it right)
Don't update firmware auto selection with this PR (we drop this change for now) and do it in a different PR, breaking secureboot in the meanwhile.

I'd vote for 1 while doing the firmware auto selection in a different PR. If we get auto selection before the libvirt fixes, we should be able to move forward with updating rpms anyway.

Option 1 would be my preferred one as well, as it's the one that carries the least risk of introducing regressions in KubeVirt. It will require a bit more patience than option 2 though. Option 3 is a complete no-go as far as I'm concerned.
I think investigating the switch to firmware autoselection in a separate PR in the meantime would be great.

Thanks @victortoso @andreabolognani,
I would be for the 1st option as well. Do we have any ETA?

I would be for the 1st option as well. Do we have any ETA?

From the time we have a c9s build, I'd guess 2 weeks or so.

I think investigating the switch to firmware autoselection in a separate PR in the meantime would be great.

I'll start now, thanks for the comment!

If we get auto selection before the libvirt fixes, we should be able to move forward with updating rpms anyway.

Discussed quite a bit offline with @andreabolognani Today. One thing important to mention is that we should really introduce firmware autoselection after updating libvirt here, that is, waiting till the libvirt build reaches centos stream 9.
I'll still be working on the firmware autoselection but the point is we shouldn't try to rush it.

Hey, @victortoso looks like the new Libvirt build that include the EFI fix available in at https://kojihub.stream.centos.org/koji/buildinfo?buildID=36654
Is it possible to use it?

Hey, victortoso looks like the new Libvirt build that include the EFI fix (libvirt-9.5.0-6.el9)available in at https://kojihub.stream.centos.org/koji/buildinfo?buildID=36654
https://kojihub.stream.centos.org/kojifiles/packages/libvirt/9.5.0/6.el9/
Is it possible to use it?

Is there yum metadata available for that location? If not, bazeldnf will not be able to consume it.
Either way, it might not be a great idea to pick up builds that have not yet gone through the usual testing.

It might not be a great idea to pick up builds that have not yet gone through the usual testing.

I agree. Just a little longer and the rpms will be available for us to consume it.

@ormergi the libvirt-9.5.0-6.el9 build which contains the fixes has passed verification yesterday, so it should show up in an internal compose soon. Hopefully within a day or two?
Then there's an additional delay before packages reach the CentOS Stream mirrors. This could take a few more days, in the worst case scenario even a week or longer I think. Unfortunately I don't have much visibility into how often these batch processes are run
tl;dr we're not quite there yet I'm afraid, but at least progress is being made. I'm sorry for the continued pain this situation is causing, but there's really nothing I can do to speed things along :(

libvirt-9.5.0-6 is now available in centos stream. I'll be updating this PR shortly.

@victortoso looks good overall, but you're also going to want
diff --git a/hack/rpm-deps.sh b/hack/rpm-deps.sh
index 74a372428..fecbdf820 100755
--- a/hack/rpm-deps.sh
+++ b/hack/rpm-deps.sh
@@ -10,10 +10,10 @@ LIBVIRT_VERSION=${LIBVIRT_VERSION:-0:9.5.0-6.el9}
 QEMU_VERSION=${QEMU_VERSION:-17:8.0.0-13.el9}
 SEABIOS_VERSION=${SEABIOS_VERSION:-0:1.16.1-1.el9}
 EDK2_VERSION=${EDK2_VERSION:-0:20230524-3.el9}
-LIBGUESTFS_VERSION=${LIBGUESTFS_VERSION:-1:1.48.4-4.el9}
-GUESTFSTOOLS_VERSION=${GUESTFSTOOLS_VERSION:-0:1.48.2-8.el9}
+LIBGUESTFS_VERSION=${LIBGUESTFS_VERSION:-1:1.50.1-6.el9}
+GUESTFSTOOLS_VERSION=${GUESTFSTOOLS_VERSION:-0:1.50.1-3.el9}
 PASST_VERSION=${PASST_VERSION:-0:0^20230818.g0af928e-4.el9}
-VIRTIOFSD_VERSION=${VIRTIOFSD_VERSION:-0:1.5.0-1.el9}
+VIRTIOFSD_VERSION=${VIRTIOFSD_VERSION:-0:1.7.2-1.el9}
 SWTPM_VERSION=${SWTPM_VERSION:-0:0.8.0-1.el9}
 SINGLE_ARCH=${SINGLE_ARCH:-""}
 BASESYSTEM=${BASESYSTEM:-"centos-stream-release"}

to fully bring the virtualization stack up to date.
I've noticed that this adds a number of new dependencies, specifically adobe-source-code-pro-fonts which looks a bit out of place. I haven't spent time figuring out which package exactly drags this in, and whether we can avoid it.
Only tangentially related, but we also need
diff --git a/hack/rpm-deps.sh b/hack/rpm-deps.sh
index 74a372428..96e0fe16e 100755
--- a/hack/rpm-deps.sh
+++ b/hack/rpm-deps.sh
@@ -261,6 +261,8 @@ if [ -z "${SINGLE_ARCH}" ] || [ "${SINGLE_ARCH}" == "x86_64" ]; then
         --name pr-helper_x86_64 \
         --basesystem ${BASESYSTEM} \
         ${bazeldnf_repos} \
+        $centos_main \
+        $centos_extra \
         $pr_helper

     # remove all RPMs which are no longer referenced by a rpmtree
@@ -362,6 +364,8 @@ if [ -z "${SINGLE_ARCH}" ] || [ "${SINGLE_ARCH}" == "aarch64" ]; then
         --name pr-helper_aarch64 --arch aarch64 \
         --basesystem ${BASESYSTEM} \
         ${bazeldnf_repos} \
+        $centos_main \
+        $centos_extra \
         $pr_helper

     # remove all RPMs which are no longer referenced by a rpmtree

to avoid dependency flipping for the pr-helper image. This gets rid of the full version of coreutils (we want coreutils-single instead) and a couple glibc-langpack-* packages. You can either have this change as a fix early in your series, or I can take care of it separately as a follow-up.
Additional nits:

having the specific make rpm-deps error listed in each commit message is IMO unnecessary. The more generic note that you have in the libvirt commit is more than enough;
in the release notes section of the PR description, the bit about firmware autoselection doesn't apply to the current version and so it should be dropped;
again in the release notes, please spell libvirt without a capital letter ;)

@andreabolognani thanks for the quick review. I've added passt, libguestfs, guestfs-tools and virtiofsd. Double checked the change you suggested for pr-helper. All looks fine from my POV.

I've noticed that this adds a number of new dependencies, specifically adobe-source-code-pro-fonts which looks a bit out of place. I haven't spent time figuring out which package exactly drags this in, and whether we can avoid it.

I'll start looking at it now. I'd say we can reduce any extra dependency as a follow up.

I'll start looking at it now. I'd say we can reduce any extra dependency as a follow up.

Agreed, the amount of additional disk space because of the extra packages is relatively small and it only affects the guestfs image anyway, so it's not affecting every VM. This update is long overdue, so let's not delay it any further unless doing so is absolutely necessary.
/lgtm

/retest-required
13:30:15: Summarizing 1 Failure:
13:30:15:   [FAIL] [Serial][sig-compute]InfrastructuredownwardMetrics [It] [test_id:6535]should be published to a vmi and periodically updated [sig-compute]
13:30:15:   tests/infrastructure/downward-metrics.go:53

....

12:16:32:   [FAILED] Expected success, but got an error:
12:16:32:       <*errors.errorString | 0xc003494090>:
12:16:32:       send to spawned process command reached the timeout 9.974840705s
12:16:32:       {
12:16:32:           s: "send to spawned process command reached the timeout 9.974840705s",
12:16:32:       }

/retest-required
17:21:13: Summarizing 1 Failure:
17:21:13:   [FAIL] [Serial][sig-compute]InfrastructuredownwardMetrics [It] [test_id:6535]should be published to a vmi and periodically updated [sig-compute]
17:21:13:   tests/infrastructure/downward-metrics.go:53

....

16:07:36:   [FAILED] Expected success, but got an error:
16:07:36:       <*errors.errorString | 0xc005160000>:
16:07:36:       send to spawned process command reached the timeout 9.979019564s
16:07:36:       {
16:07:36:           s: "send to spawned process command reached the timeout 9.979019564s",
16:07:36:       }

@alicefr, @xpivarc and @rmohr, I think this is ready for another look/unhold?
No problems with secureboot. All the virt stack is up to date with latest centos stream 9.

/approve
/unhold
Thanks for following up on this over such a long time. 🎉

/test pull-kubevirt-e2e-k8s-1.28-sig-compute

Let's also run the SEV test job
/test pull-kubevirt-e2e-k8s-1.26-sev

Thanks @victortoso @andreabolognani !!!

I'll just point out something that I hadn't noticed until now, because it got sort of drowned in the make rpm-deps noise: with this update, the legacy monolithic libvirtd daemon is no longer included in the virt-launcher image!
KubeVirt had already switched to the modular virtqemud last year with https://github.com/kubevirt/kubevirt/pull/8619, but up until now the libvirt RPM packages were not flexible enough to accomodate a libvirtd-less deployment. Well, now they are :)
As part of this move virtproxyd and virtlockd, which KubeVirt never used, are gone too. All in all, a nice cleanup :)


Enable fatal warnings for IR, tools, partest and library

Review by @sjrd

That's all.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/2291/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/2972/
Test PASSed.

Updated

LGTM

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/2293/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/2974/
Test PASSed.

OK apparently this protected branch stuff is a bit too extreme. It won't let me merge, even though we have a green build, because since then there have been commits on master. So it wants a rebase. With the notorious speed and reliability of our CI, this is not going to fly. I'll disable it.


I wanna make a PR, but I need an extern package

Hi there, I found a way to use the Windows Accent Color in Avalonia, but that needs Microsoft.Win32.Registry, this way detect the OS, if the OS is windows uses the Accent Color, else uses the Avalonia Default Accent Color.
I see the avalonia dependecies tree and it's a bit complex, where should be the package?
For the way to use win accent color, see AccentColorTest

You should be able to use PInvoke to read value from regedit.
Also it should be possible to use WinRT API through MicroCom to get accent color from UISetting (and probably even subscribe on its changes).
But regedit solution is enough for first implementation as for me.

You should be able to use PInvoke to read value from regedit.
Also it should be possible to use WinRT API through MicroCom to get accent color from UISetting (and probably even subscribe on its changes).
But regedit solution is enough for first implementation as for me.

good idea, but, how can I use pinvoke to get regedit value?

good idea, but, how can I use pinvoke to get regedit value?

https://social.msdn.microsoft.com/Forums/vstudio/en-US/4b2075bf-bba3-45fa-941c-a145fac56e13/registry-class-using-pinvoke?forum=csharpgeneral

https://social.msdn.microsoft.com/Forums/vstudio/en-US/4b2075bf-bba3-45fa-941c-a145fac56e13/registry-class-using-pinvoke?forum=csharpgeneral

I think the best way would be to create a service for accent colors on Avalonia.Visuals for example and implementing it in Avalonia.Win32, and binding it here:
https://github.com/AvaloniaUI/Avalonia/blob/87a8e22f62cd231a9f9c273d364e59fa93e10ed2/src/Windows/Avalonia.Win32/Win32Platform.cs#L105
It shouldn't be a problem to install the registry package in that project. Also in the future it would be easy to add other platforms, implementing that service.

I think the best way would be to create a service for accent colors on Avalonia.Visuals for example and implementing it in Avalonia.Win32, and binding it here:
https://github.com/AvaloniaUI/Avalonia/blob/87a8e22f62cd231a9f9c273d364e59fa93e10ed2/src/Windows/Avalonia.Win32/Win32Platform.cs#L105
It shouldn't be a problem to install the registry package in that project. Also in the future it would be easy to add other platforms, implementing that service.

Yes, Avalonia.Win32... and that way we can do something on OSX to read accent colour there too.

Yes, Avalonia.Win32... and that way we can do something on OSX to read accent colour there too.

well, I'll find another way to do it, It's very interesting the way wrote by @jp2masa

well, I'll find another way to do it, It's very interesting the way wrote by @jp2masa

Btw you should be able to detect accent color changes by listening to WM_SETTINGCHANGE

Btw you should be able to detect accent color changes by listening to WM_SETTINGCHANGE

I found a way to do it, AccentColors.cs#L50; this code works well with Avalonia, that does not have some dependency, it's perfect

I found a way to do it, AccentColors.cs#L50; this code works well with Avalonia, that does not have some dependency, it's perfect

WORKS WELL, JUST SEE THIS

in few I'm going to publish the PR :DDDDD

WORKS WELL, JUST SEE THIS

in few I'm going to publish the PR :DDDDD


no longer able to open IX-Select when used in a region that gets hidden and shown again

Prerequisites

[X] I have not leaked any internal company information.
[X] I have not posted internal links or code snippets.

What happened?
We are using an IX-Select to set a specific View Setting.
It is used inside one of our regions that the user is able to display on a button click and hide again on clicking the close-icon:

When first opening it, selecting a value from the Select works just fine, but once we close the region, open it again and try selecting something, the Dropdown is no longer expanding and we are no longer able to select a value.
This was not occurring in IX 2.0 before and happened just after we updated to 2.1 (2.1.1)
What type of frontend frameware are you seeing the problem on?
Angular
Which version of iX do you use?
v2.1.1
Code to produce this issue.
<ix-select [value]="selectedItem" data-test-id="selectControl">
    <ix-select-item
      *ngFor="let item of filterTileSelectionList"
      [label]="item.label"
      [value]="item.value"
      (itemClick)="selectItemClick(item)"
      [attr.data-test-id]="item.value"
    >
    </ix-select-item>
  </ix-select>

Short Update from my side:
Using IX 2.0 has almost the same behaviour as 2.1:
On closing a Region where the Select is used in Version 2.0, the Dropdown will no longer disappear on opening again, whilst on 2.1, as stated above, the dropdown is no longer opening 😄
For 2.0 console errors look like this:

2.1 doesn't provide any console errors, as I am not even able to interact in any way with the select anymore it seems 😄

Fixed in  #1192


Use default profile and switch country-specific profiles into a feature flag

Changes:

Splitting each module's code into org.niis.* and fi.dvv.* packages for common and Finland-specific features respectively.
Switch application.properties into yaml format for:

Clarity in properties structure
Better support with docker/k8s based environments and usage.

Switching from fi profile to the new xroad-catalog.country.fi.enabled feature flag for both collector and lister modules
Loading Finland-specific features based on the new xroad-catalog.country.fi.enabled feature flag.
Using application.yaml as a common/base configuration file with all default configurations
Using dev profile configuration for local development (to run service from IDE)
Using test profile configuration for tests only
Removing sshtest profile but keeping/updating the documentation
Adding application-fi.sample.yaml and application-production.sample.yaml sample profiles
Using persistence module only for entities and repositories by:

Splitting services from persistence module into either collector or lister modules
Persistence module no longer can run as an application
Persistence module no longer can be used to apply database changes as liquibase is already configured

Grouping properties into different logical groups
Removing unused properties
Adding new configuration section in each module's README.md with all configurations related to the the module

Refs: XRDCAT-8

Since the Java package names are being updated, fi.vrk.* should be updated to fi.dvv.*. Nowadays, the Finnish Digital Agency uses the dvv.fi domain while vrk.fi is their old domain.

@raits , the configurations section in both READMEs for collector and lister services are updated as per your comments (moving reasonably defaulted values to proper optional sections).
And the configurations section in the installation guide is now updated by:

Splitting collector from lister service
Reference READMEs configurations sections (instead of repeating the configurations parameters list)
Added specific instructions for how to enable Finland-specific features (in both services)

And also, added ToC for READMEs and installation guide to help clarifying how the documents are structured


Updated workshop date and time zone

Should we write the workshop date in the homepage too?

Looks good- thank you for these updates.
Updating the home page is fine with me too- it's just a matter of whether you want to do it.


Incorrect stringmessage snippet structure

Description:
The stringmessage snippet currently has an extra closing curly brace } and a comma , at the end of the description field, causing parsing errors in VS Code.
Expected Behavior:
The snippet should correctly generate the following JSON structure:
"testArbBlock": "test",
"@testArbBlock": {
  "description": "Test arb block"
}

Actual Behavior:
The current snippet generates invalid JSON due to the extra } and ,.
"testArbBlock": "test",
"@testArbBlock": {
   "description": "Test arb block",
   }
},

Steps to Reproduce:

Install the relevant VS Code extension.
Trigger the stringmessage snippet.
Fill in the required fields.
Observe the generated JSON output.

Proposed Solution:
Remove the extra } and the comma , from the description field in the snippet's body. The corrected snippet should look like this:
"stringmessage": {
   "prefix": "string",
   "body": [
      "\"${1:id}\": \"$2\",",
      "\"@${1:id}\": {",
      "  \"description\": \"${1/([a-z]+)(?=[A-Z])|([A-Z])(?=[A-Z])|([A-Z][a-z]+)(?=$)|([A-Z][a-z]+)|([a-z]+)(?=$)/${1:/capitalize}${1:+ }$2${2:+ }${3:/downcase}${4:/downcase}${4:+ }${5:/downcase}/g}\"",
      "},"
   ],
   "description": "A simple ARB string message"
}

Thanks for filing this! Feel free to submit a PR as well ;)

Thanks for the reply! I've submitted a PR with the proposed solution :)


Requires PHPUnit when symfony/debug-bundle is installed

Title. Calls Symfony\Bundle\DebugBundle\Tests\DependencyInjection\DebugExtensionTest which requires PHPUnit (which isn't stated anywhere)

is this intended behaviour (seems strange to call a test case from a working app)
can this be noted somewhere so others dont run into the same problem

fixed in 2.0.9


Add an option to separate library backup from library downloads

Describe your suggested feature
I would like if there was an option to separate the backup of the library and the downloads, like it was in tachiyomi 0.14.x and lower.
Other details
Not as a default, but an option
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an official extension, I should be opening an issue in the extensions repository.
[X] I have updated the app to version 0.15.3.
[X] I will fill out all of the requested information in this form.

If I understand correctly. You have 2 folders inside that folder that's you choose while initial setup/in settings - downloads and local. downloads for downloads, local for library.

Sorry, I guess I wrote it poorly. I meant to choose a different directory for both of them since I don't want to backup my downloads and want to move my library backup to different directory that has other backups, synced with syncthing


Use metadata.google.internal

Using the full hostname rather than requiring the resolv.conf domain configuration is required for our setup.

I signed it!

#69 replaces this


Added Suduko Solver in C++

Have you read the Contributing Guidelines on Pull Requests?
(Yes)
Description
(Suduko Solver added in C++)
Checklist

[Y] I've read the contribution guidelines.
[Y] I've checked the issue list before deciding what to submit.
[Y] I've edited the README.md and link to my code.

Related Issues or Pull Requests
(Issue #1500 is solved here)

@YASH01009  please resolve the conflicts

LGTM


Tianjin Airlines A320-200 Quanyang Spring Livery

Good work bro I'm glad that I have a fan what likes you:)


[Question] Linkis-eureka debugging instructions

Before asking

[X] I have read the How to ask for help (我已阅读如何寻求帮助指引文档).

Your environment

Linkis version used: 1.1.2
Environment name and version:

cdh-5.14.2
hdp-3.1.5
hive-2.1.1
spark-3.2.1
scala-2.12.2
jdk 1.8.0_121
....

Describe your questions
Linkis-eureka debugging instructions
Linkis-eureka调试说明
Eureka service list

eg:
Some logs info or acctch file

linkis-xxx.log:

<!--日志文字贴到这里-->

log file:

linkis-xxx.log

If you need to debug the eureka program, you need to do some configuration first, as shown below

application-eureka.yml needs to remove some annotation configurations. The normal startup configuration is as follows:
Debug documentation can refer to: https://linkis.apache.org/zh-CN/docs/latest/development/linkis-debug-in-mac


Fix Micro server handler

The handler was not returning httpRunQuery's Promise, causing micro to send empty responses and leaving Node with unhandled Promise rejections when that Promise tried to write headers.
I also used return and throw instead of manipulating the response directly.  This allows wrapping middleware to intercept responses if desired.

Good idea.  I've added microrouter to the test to demonstrate a more realistic app configuration.  This also reveals the underlying issue.  If you copy this version of the test into the latest release many tests will fail.

And now I'm going to go PR all and custom route helpers into microrouter.. lol

Not really sure why the build failed.. it doesn't appear related to these changes.  The node 6 build passed but the node 4 and 7 builds failed with nodejs: not found.

I'm tempted to touch one of the files to get Travis to re-run.  Anyone able to do that without a new commit?

Hi @spicydonuts I've restarted the CI jobs in question. Let's hope they pass this time! 🙂

Success! 🎉

Is there anything blocking this merge?  I fixed the merge conflict that's appeared in the meantime.

Hey @spicydonuts, thanks for the reminder, I'll take another look today!

is this released? 😛

@luisrudge yes


File Structures

hello, In main file i cannot find checkpoints/: experiment folders, organized by unique exp identifier

i want try the digit-set to train


Cesar sgw 276 implement bitfi support

Ticket: https://constellationnetwork.atlassian.net/browse/SGW-276

Everything looks good!
Just one question: Don't we need to update the MigrationController file since we're updating the vault shape adding bitfi?
PS: There're conflicts that should be resolved 😄

I will resolve the conflicts. No there does not need to be a migration controller, since the changes to the state shape introduce a key "bitfi" in the wallet shape with no existing data that needs to be migrated over to the new shape.


keepachangelog version update

Description of changes:
Updating keepachangelog's hyperlinked version to the latest - https://keepachangelog.com/en/1.0.0/
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Cool thanks!


Traefik forward authentication

Is it possible to use Loginsrv as forward auth proxy with traefik (https://docs.traefik.io/configuration/entrypoints/#forward-authentication)?

Did you try using loginsrv with Httpupstream?
Ref: https://github.com/tarent/loginsrv#httpupstream

I believe what @ppoloskov (and I) are interested is the reverse of what you are referring to @magikstm. IE let traefik delegate the authentication to loginsrv.
Perhaps looking into this https://github.com/tarent/loginsrv#get-login could be the way forward?
Are there any examples for loginsrv as upstream authenticator for any proxy (not specifically traefik) that can be shared here?
ATM I do not have time to dig into this / setup a test environment hence the questions rather than an answer.

Hello @LinusT,
the "GET /login" endpoint might not be a solution for your problem. But I think it could be easily turned into an endpoint that behaves as expected by the traefik middleware.
A better solution would be to use the JWT tokens issued by loginsrv and check them either in a custom traefik middleware or in the services.
I will close this issue. If you want to  suggest any improvements, please reopen the issue! So that we can discuss your suggestions.


Bug with "overwrite=True" in the write(). Error: _filename not defined

Looks like the private variable was omitted from PdfAnnotator class.
I believe it needs to be included roughly here (lines 84-87 annotator.py):
84        self._pdf = PDF(file_or_reader)
85        self._scale = self._expand_scale(scale)
86        self._dimensions = {}
87        self._compress = compress

Thanks, it works


Webview resources not loading - ERR_UNKNOWN_URL_SCHEME (vscode-insiders) (AGAIN)

This bug was first reported in #100879 & #100918, was fixed in Visual Studio Code Insiders 9b620b2, then reintroduced in the latest Visual Studio Code Insiders release (information below).
Please fix this immediately - it has already fatally affected all Visual Studio Code Insiders users of all extensions that use Webviews (including my own) for 2.5 days just to get it fixed the first time, now it's broken again within 12 hours of it being fixed!

Version: 1.47.0-insider (user setup)
Commit: 6c235c723cb2d8defb840f732eac620f54aa8b9d
Date: 2020-06-26T06:20:06.931Z
Electron: 8.3.3
Chrome: 80.0.3987.165
Node.js: 12.13.0
V8: 8.0.426.27-electron.0
OS: Windows_NT x64 10.0.18362

I'm the author of the Git Graph extension. This bug is affecting all Git Graph users that use Visual Studio Code Insiders, as well as every other extension I'm aware of that loads resources (e.g. CSS, JS) in Webview's (more specifically, resources loaded by Webview.asWebviewUri). I can replicate bug on Windows & Mac, I've had reports of this from many users.
Steps to Reproduce:

Install an extension that uses a Webview (Git Graph for the following steps)
Open Visual Studio Code in a Git repository.
Click the "Git Graph" Status Bar Item
Observe that the CSS & JS resources aren't loaded:

If you run the Visual Studio Code command "Open Webview Developer Tools", the following errors can be seen:

Does this issue occur when all extensions are disabled?: No (Because it only affects extensions that use Webview's)
The resolution of this issue is being tracked for Git Graph users here.

Looping in @mjbvz

@mjbvz the issue seems to happen only with the packaged build, OSS works fine.
If you check window.location.href in the webview devtools for OSS it will print the correct uri vscode-webview://.... , but in the packaged build its chrome-error://chromewebdata which is the error page chromium loads when the top level navigated file is not found, the net::ERR_UNKNOWN_URL_SCHEME are just a side effect of loading subresources in an elevated permission page.
The root issue is the path to the entry virtual document is incorrect in packaged build.

Thanks @deepak1556. From that I believe I was able to trace the issue to having spaces (or other special uri characters) in your install path. I'll queue up another insiders build for testing

Thanks @mjbvz & @deepak1556 for getting this resolved!
Webviews are now working again in Visual Studio Code Insiders:

Version: 1.47.0-insider (user setup)
Commit: 9bf6af04dcb5c2e531cedca83cd188939ca1b0db
Date: 2020-06-26T18:55:07.038Z
Electron: 8.3.3
Chrome: 80.0.3987.165
Node.js: 12.13.0
V8: 8.0.426.27-electron.0
OS: Windows_NT x64 10.0.18362

Sorry for the breaking. We've been rewriting parts of the webview implementation this iteration and this has caused a lot of interesting bugs
We do have webview test that try loading resources so I'll investigate why this wasn't caught before the release


anyone else have this error?  "python3: can't open file '/public/source/share/zcs/v20210402_1//ISO_anno_combine.py': [Errno 2] No such file or directory"

did you edit the config file of TransAnnot.config. You can replace your install dictionary of parameter 'the TAGET_DIR='


[WIP]Add screenshots path from takeScreenshot\takeElementScreenshot actions into report (closes #2216)

@testcafe-build-bot retest

/cc @arubtsov Please, take a look

@testcafe-build-bot retest

@testcafe-build-bot retest

please review

@testcafe-build-bot retest

@testcafe-build-bot retest

review please

@testcafe-build-bot retest

@testcafe-build-bot retest


Feat: adds support to leaflet as a node module

Overview
Adds support for using Leaflet as a Node Module in the <Maps /> and <MapPopUp /> components.
Testing instructions
import L from 'leaflet';
import Maps from 'wri-api-components/dist/map';

Maps.L = L;

**Use Maps...**

Checklist before submitting
[x] Title: Don't forget to make it clear for everyone, even for people that don't know about the feature/bug.
[x] Meaningful commits and code rebased on develop.
[ ] Update the changelog (see below)

Mmmmmm, I think we agree to use leaflet as an external library. How is this affecting you? Why do you need to have Leaflet as an npm module? We need to talk.


State is not very type safe

As i stated in my other issue [#5] I'm very much enjoying using this library. Thanks again!
I would love to have some more type safety around state.  If state were instead a generic type then I could fill that in with the state type for my app and run into these errors at compile time.

Glad to hear you're enjoying the library!
In buck we've also struggled with the lack of type safety in state, I think changing it to be a generic type provided by the app would be a great change. I expect making that change would parameterize all the places that would need to be parameterized to support the user specifying the error type as well.

New version of superconsole has no State: d586d6f7f366c5e0eb3c84d73da221c12097520b.
API changed. Now SuperConsole::new(..) no longer grabs the component to render. Instead, super_console.render(..) takes the component reference. And that component can grab whatever it wants.
Like this:
let super_console = SuperConsole::new();

for i in 0..100 {
  super_console.render(&MyComponent {
    counter: i,
  });
}


Menus feature

The purpose of this feature is so that menus throughout a Raytha site need not be hardcoded into templates. They can be generated dynamically and managed through a UI similar to WordPress.
Task:
"Navigation Menus" should be added to the left side navigation of the admin panel and only accessible if the logged in administrator belongs to a role with the "Manage Content Types" permission. Route should be /raytha/menus
The data model should be:
Menu:

Id
Label
Developer Name
IsMainMenu
List of Menu Items

We should be able to "Set as main menu" similar to what we do with home page.

The list of menu items should be a nav item on the right side following our pattern:

Edit menu
Menu items
Delete menu

MenuItem:

Id
Label
Url (can be a relative url)
IsDisabled
OpenInNewTab
CssClassName
Ordinal

It should follow the same pattern as a content type settings where you can add a menu item or reorder the menu items.

You cannot delete the main menu. There should always be 1 main menu.
Two built-in liquid functions should be added to Templates functionality.

get_main_menu()
get_menu(developerName)

The function should pull the respective menu and generate a tree structure (use recursion) to create an object that can be used to render the necessary HTML for the template creator.
The render object should render as:

Id
Label
DeveloperName
IsMainMenu
MenuItems

And this MenuItems should be the top-level menu items rendered as:

Id
Label
Url
IsDisabled
OpenInNewTab
CSS Class Name
Ordinal
IsFirstItem
IsLastItem
MenuItems

We need to update the:

InitialSetup - Create the first menu, set it as main menu, and add the first two items, Home and About.
DefaultTemplate should make use of get_main_menu() in its template to render the nav.
Templates > Insert Variable > the render models for Menu and MenuItem needs to appear here.
REST API / SWAGGER - new section called Navigation Menus.

GET Requests only:

/raytha/api/v1/menus
/raytha/api/v1/menus/{developerName}
/raytha/api/v1/menus/{developerName}/menu-items
/raytha/api/v1/menus/{developerName}/menu-items/{menuItemId}

Released with v1.3.0


dyld: Symbol not found (objC+Swift)

Ok, so anyone know what this could be? I've been messing with this for hours now.
It's a obj-c project. It compiles alright and starts up in the simulator showing the launch-screen, but right after that I get the following crash:
dyld: Symbol not found: __TMaCs18_DropWhileSequence
Referenced from: [...]/Frameworks/AudioKit.framework/AudioKit
Expected in: [...]/Frameworks/libswiftCore.dylib
in [...]/Frameworks/AudioKit.framework/AudioKit

Updated Xcode with Swift 3.1, solved the problem.


AttributeError: 'NoneType' object has no attribute 'Batch'

The attached script leads to the above error message. I am using pyglet version 2.0.dev0 and trimesh version 3.3.6
test_trimesh.py.txt

It looks like trimesh will need a small change to work with pyglet 2.0. Namely, it is explicitly disabling the shadow_window, which should no longer be done unless a Window/context will be explicitly created. That will be a simple change.
However, even with that change in trimesh, pyglet 2.0 needs a little more work on the default shaders before it's ready for use.

The current situation using

trimesh.version
'3.7.0'

git/pyglet/pyglet/graphics/init.py", line 499, in _get_domain
domain = domain_map[key]
KeyError: (('v3f/static', 'n3f/static', 'c4B/static'), 4, True, 3)
and finally
git/pyglet/pyglet/graphics/vertexattribute.py", line 291, in init
assert self.location != -1, "'{0}' attribute not found in Shader".format(self.name)
AssertionError: 'normals' attribute not found in Shader

Closing this for now, since pyglet 2.0 is not yet finalized. Trimesh will need some small changes made to work, but it might not make sense to tackle those now until the API is set for pyglet 2.0.
Lets follow up on this once pyglet 2.0 betas are ready.


[Task]: Upgrade Jackson Version to secure 2.13.3

What needs to happen?
Current version of Jackson needs upgrading from 2.13.0 due to vulnerabilities.
Upgrade to 2.13.3.
Issue Priority
Priority: 2
Issue Component
Component: dependencies

Will take this on


Helm install camunda 8 with keycloak CrashLoopBackOff error

I have error message from keycloak pod  when try run helm to install camunda 8 from the helm chart.
below is some of the print out from the pods detail. do you have any advice what is issue ?
helm install
kubectl get pods command result
NAME                                                          READY   STATUS                    RESTARTS           AGE
camunda8-keycloak-0                                   0/1     CrashLoopBackOff   6 (3m52s ago)   27m
kubect describe pods command result.
Events:
Type       Reason          Age                        From                        Message
Warning  Unhealthy  19m (x53 over 28m)    kubelet            Readiness probe failed: Get "http://<IP_ADDRESS>:8080/auth/realms/master": dial tcp <IP_ADDRESS>:8080: connect: connection refused
Warning  BackOff    4m15s (x40 over 24m)  kubelet            Back-off restarting failed container
I am follow below article and using Mac Docker Desktop Kubenetes.
https://docs.camunda.io/docs/self-managed/platform-deployment/kubernetes-helm/#installing-the-camunda-helm-chart-locally-using-kind

Hey @simonqiang could you please share the values file you're using? Does this issue persist or did it resolve after some crashes ? Because it might be expected since keycloak depends on PostgreSQL which needs to start first.

hey @Zelldon, indeed you are right. for the some reason the PostgreSQL is not yet started. not enough cpu core to up all the pods. thanks for the reply.

Thanks for the response so I will close this. Feel free to reopen if you still see issues


[1.7.10]Rockets Glitching

My rocket(s) sometimes glitch to/from planets and wastes all the fuel they have because of this.

Is there a way to replicate this issue reliably?

Is this still a issue? Please comment if it is and i will reopen if if you are unable? We are closing old issues to see what is still relevant and needs to be fixed.


Mistake in "Your first Flutter app" documentation "semanticsLabel" property for Text is not working

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce
In: https://github.com/flutter/codelabs/blob/main/namer/step_05_f_accessibility/lib/main.dart#L82
"semanticsLabel" property for Text is not working  and is not seperating the two words
Expected results
the 2 words should have a space in between
Actual results
The words are together
Code sample
The Broken Code
class BigCard extends StatelessWidget {
  const BigCard({
    super.key,
    required this.pair,
  });

  final WordPair pair;

  @override
  Widget build(BuildContext context) {
    final theme = Theme.of(context);
    final style = theme.textTheme.displayMedium!.copyWith(
      color: theme.colorScheme.onPrimary,
    );

    return Card(
      color: theme.colorScheme.primary,
      child: Padding(
        padding: const EdgeInsets.all(20),
        child: Text(
          pair.asLowerCase,
          style: style,
          semanticsLabel: "${pair.first} ${pair.second}",
        ),
      ),
    );
  }
}

The Working Code
class BigCard extends StatelessWidget {
  const BigCard({
    super.key,
    required this.pair,
  });

  final WordPair pair;

  @override
  Widget build(BuildContext context) {
    final theme = Theme.of(context);
    final style = theme.textTheme.displayMedium!.copyWith(
      color: theme.colorScheme.onPrimary,
    );

    return Card(
      color: theme.colorScheme.primary,
      child: Padding(
        padding: const EdgeInsets.all(20),
        child: Text("${pair.first} ${pair.second}", style: style),
      ),
    );
  }
}

Screenshots or Video

Screenshots / Video demonstration
![image](https://github.com/flutter/flutter/assets/27162229/c9e7ad46-b1f2-4a6f-b717-dc7431714077)

Logs
Logs
Restarted application in 211ms.
Restarted application in 394ms.
Restarted application in 170ms.
Restarted application in 143ms.
Restarted application in 255ms.

Flutter Doctor output
Doctor output
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.10.6, on Microsoft Windows [Version 10.0.22621.1992], locale en-AU)
[✓] Windows Version (Installed version of Windows is version 10 or higher)
[✗] Android toolchain - develop for Android devices
    ✗ Unable to locate Android SDK.
      Install Android Studio from: https://developer.android.com/studio/index.html
      On first launch it will assist you in installing the Android SDK components.
      (or visit https://flutter.dev/docs/get-started/install/windows#android-setup for detailed instructions).
      If the Android SDK has been installed to a custom location, please use
      `flutter config --android-sdk` to update to that location.

[✓] Chrome - develop for the web
[✗] Visual Studio - develop for Windows
    ✗ Visual Studio not installed; this is necessary for Windows development.
      Download at https://visualstudio.microsoft.com/downloads/.
      Please install the "Desktop development with C++" workload, including all of its default components
[!] Android Studio (not installed)
[✓] VS Code, 64-bit edition (version 1.79.2)
[✓] Connected device (3 available)
[✓] Network resources

! Doctor found issues in 3 categories.

Hi @sayandaw, there is no issue here. The semanticLabel is for screen readers to pronounce the words for those who may be visual/hearing impaired. It does not affect the display of the word.
Coming to the word, that is the way the word pair is designed to work. They're not supposed to have spaces between them. WordPair generates a "compound" word. You can find out more about this in  https://en.wikipedia.org/wiki/Compound_(linguistics)
This is also stated in the introduction of the codelab.
The application generates cool-sounding names, such as "newstay", "lightstream", "mainbrake", or "graypine". The user can ask for the next name, favorite the current one, and review the list of favorited names on a separate page. The app is responsive to different screen sizes.

Closing from here as there is not issue with the codelab in this regard.


#788 refactored TkFallback

#788

refactored TkFallback to reduce duplication

Job #908 is now in scope, role is REV

Codecov Report

Merging #908 into master will increase coverage by 0.1%.
The diff coverage is 54.54%.

@@             Coverage Diff             @@
##             master     #908     +/-   ##
===========================================
+ Coverage      74.1%   74.21%   +0.1%
  Complexity      959      959
===========================================
  Files           220      220
  Lines          4731     4723      -8
  Branches        372      373      +1
===========================================
- Hits           3506     3505      -1
+ Misses         1071     1063      -8
- Partials        154      155      +1

Impacted Files
Coverage Δ
Complexity Δ

...ain/java/org/takes/facets/fallback/TkFallback.java
55.88% <54.54%> (+5.88%)
6 <2> (+1)
:arrow_up:

src/main/java/org/takes/http/MainRemote.java
54.09% <0%> (-1.64%)
6% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a4efc7...f691e0b. Read the comment docs.

@krzyk thanks

@rultor merge

@rultor merge

@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@paulodamaso Done! FYI, the full log is here (took me 19min)

Job gh:yegor256/takes#908 is not assigned, can't get performer

The job #908 is now out of scope

@krzyk OK :+1:


StopwatchDateTime is not monotonic

Sometimes StopwatchDateTime.UtcNow may return a value < the previous one.

Fixed in https://github.com/Anonymous87549236/HighResolutionDateTime/releases/tag/<IP_ADDRESS> .


Opt-in to postMessage notifications when fastest updates the cached content

The toolbox.fastest strategy provides a convenient way of returning a previously cached Response immediately, while at the same time fetch()ing a potentially newer copy from the network.
However, if the network request did result in an updated copy being retrieved, the page that requested the resource does not currently receive any notification that there's a newer Response available.
We can add in a new option that would allow developers to opt-in to using ServiceWorkerClient.postMessage() to trigger an event handler on the controlled page, letting it know that the cached entry is out of date.

@jeffposnick how do you see developers using this callback? Trigger a notification asking the user to perform a refresh?
Would this follow a similar pattern for when a new service worker has been installed and waiting for activation?
Any proposals for what the API could look like?

A scenario where this would come in handy would be when revisiting a previously accessed article. Most of the time the cached copy would remain the same. On the off chance there's an important edit that was made after it was initially published, it could be useful to notify the reader (via a toast or a similar mechanism—really up to the site) that they should reload to see the latest edits. It's definitely analogous to what you can already do with App Shell updates by listening for service worker lifecycle events.
It could be something that you opt-into via our standard options object, though it would only apply to routes that use the fastest strategy.
Config:
toolbox.router.get(/articles/, toolbox.fastest, {
  cache: {
    name: 'articles',
    maxEntries: 10
  },
  notifyOnFastestUpdate: true
});

Controlled page:
navigator.serviceWorker.addEventListener('message', function(event) {
  // event.data.type === 'fastest-update'
  // event.data.url === 'https://example.com/articles/abc.json'
});

Looks super nice to me, only tweak would be to the name: 'notifyOnFastestUpdate' maybe something like 'notifyOnCacheUpdate' so it's obvious that it's only triggered when the cache is actually altered (If we can make that distinction).

Definitely like the idea of adding the feature. I would make the type of the message something like cache-updated so that we can use this feature with other handlers we might write in the future.
We might also want to (optionally) do some check to make sure that we only notify if the version from the network is actually different from the version in the cache.
For the purpose of playing devil's advocate, and for provoking discussion, I'm going to describe two alternative APIs
The simplest thing that could possibly work.
No options or configuration. Every time fastest updates the cache we postMessage all controlled window clients to let them know. It has the advantage of simplicity.
It also solves an admittedly very low priority problem when you have more than one open window client. Say that client A fetches a resource with fastest while offline. The resource comes from the cache and the network request fails, so there is no update ping. Later, client B fetches the resource while online. When the network fetch succeeds, BOTH clients will be notified.
For disadvantages, I'm not sure. It would depend on how heavyweight the process is. If you're not checking that the resource really changed then I think it's probably negligible, in which case why not?
Decouple from routing
Instead of having it as part of the route, have an API to subscribe to notifications when certain resources change in the cache. This would also work across all clients. I don't really think this approach adds anything, but I wanted to throw it out as a thought :)
In the same scenario as above, you could also notify when the cacheFirst and networkFirst handlers update the cache. Again, this only has a benefit for multiple client situations. Client A loads something with cacheFirst with an empty cache, or networkFirst, while offline and gets either no data or stale data. Later, client B loads the same resource and gets a network response. Client A can then be notified and get the fresh data.

FYI, I'm going to work on this soon, as the need has come up again.
Based on the previous comments, I'm thinking that notifyOnCacheUpdate for the name, and you have to explicitly opt-in.
The one wrinkle is that for the specific use case I'm focusing on, the message should only be sent iff the previously cached entry and the new entry from the network are actually different (with some degree of certainty). Comparing response bodies is way too heavyweight, so I'm hoping I can get away with comparing Content-Length, falling back to Last-Modified (if present) and then ETag (if present).


precision=16 doesn't work

my code is here:
https://www.kaggle.com/code/lezilv/digit-recognition-pytorch
I've tried update to 1.6.3 and torch==1.11.0
whether or not turn on/off precision=16, the epoch time is same.
any one can tell me what's happened
cc @carmocca @justusschock @awaelchli @akihironitta @rohitgr7

Hi @lg2578
The mixed precision does not guarantee you a speed up always, but often times it reduces the memory footprint.
I'm not sure what you expected or what you have read about it, but we would need more information about your issue. Otherwise the issue will be closed. If you have general questions about how to use mixed precision, you can go to Discussions and post your question there.

Also note, that not all GPUs do support mixed precision training at all. Specifically, the older P100 which you apparently get on kaggle don't

Also note, that not all GPUs do support mixed precision training at all. Specifically, the older P100 which you apparently get on kaggle don't

thanks very much.


IVC Circuit (Part 3): Vertical layout with MultiRow Env

This PR:

Creates vertical layout using MultiRowReadCap.
Outlines main strategy, but with missing smaller bits.
Illustrates gadget composition

Note: it's a POC PR with many parts not written up to the actual spec (notably, hashes are not in the sponge mode yet). The main point was to show how multi-line communication is possible, to allow working on sub-gadgets concurrently later (e.g. it shows how we get data to feed into the hashes).
Previous PRs:

https://github.com/o1-labs/proof-systems/pull/2139
https://github.com/o1-labs/proof-systems/pull/2140

:tada: feel free to merge my PRs when you approve them @fabrizio-m :)


Update block class

Fix: #63
Sadly it would also mean dropping 1.38 support because MW 1.38 does not support the DatabaseBlock class.
It is added since 1.39.

Thanks. MW 1.38 is EOL, so I'm happy to bump up the requirement in the master branch at least.


test: make every download restricted - LESQ-1065

Description
Music year: {owa_music_year}

Previously only the lesson downloads from account-security-68rkee were geo-restricted behind a featureflag. This PR makes all download pages geo-restricted if you have "isRegionAuthorised": false and are using the featureflag.

How to test

Go to https://deploy-preview-2774--oak-web-application.netlify.thenational.academy
Go to any downloads page (feature flag enabled) if you have "isRegionAuthorised": false in clerk you should see the
Sorry, downloads for this lesson are not available in your country page

Screenshots
https://github.com/user-attachments/assets/2dfdaefa-faa0-4a6c-b51c-ef6dea6c1d75
Checklist

[ ] Added or updated tests where appropriate
[ ] Manually tested across browsers / devices
[ ] Considered impact on accessibility
[ ] Design sign-off
[ ] Approved by product owner
[ ] Does this PR update a package with a breaking change

@JBR90 nice - just checking I noticed that I can still get to the download section for Specialist and therapies lessons. Are they included in this work?

@JBR90 nice - just checking I noticed that I can still get to the download section for Specialist and therapies lessons. Are they included in this work?

They should have been, just pushing up a change to fix that now.

:tada: This PR is included in version 1.557.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Demo needed

Please add the web demo!

@norasotanext Thank you. It's a good suggestion. Let me see what we can do.


Enhancement: Run php-cs-fixer on Travis

This PR

[x] requires fabpot/php-cs-fixer
[x] adds a simple configuration, effectively checking PSR-2 compliance
[x] performs a dry-run of php-cs-fixer on Travis to break the build
[x] disables PSR-0 fixer (see https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/1329)
[x] runs php-cs-fixer to fix issues

Follows #198.
Related to #234.
Related to #235.

Thanks @localheinz


Fix name overflow in "Cooperation Offer" card in "Accept new cooperation" modal window

Users are allowed a maximum of 30 characters for both first and last names.
Users with long first and last names experience price and status spilling outside of the "Cooperation Offer" card.

Cannot reproduce it in production, I think you can close the issue.


Publish to the PowerShell Gallery

Hey, cool module!  I think people would find this pretty helpful.  Would you publish this to the PowerShell Gallery?  All you need is to create a module manifest (PowerBash.psd) with New-ModuleManifest, create an account on powershellgallery.com and then use the Publish-Module command.  You'll need the NuGet API key that you'll find in your user account once you register.  Let me know if you have any questions about how to do that.

Done.  I put PromptEd up too.


Add Semantic Versioning Documentation to Project.

We just want to document in the project semantic versioning.

closed

addding lavbel


Update for x22 Pumps to Display Reservoir Status HUD

Update to allow x22 pumps to display the Reservoir Status in the HUD.  Added PumpModel.swift Extension, Updated Logic and Tested Values and Display.

I also added the x22 BIoB value from the Chart Decay

That's not bolus IOB, that's net IOB.

The first commit looks good, but the second one is displaying incorrect data. Please resubmit with just the reservoir change.

I pulled the Net IOB Code out.   Especially if the plan is to move away from text cells in future.  Thanks again for the knowledge share.

Awesome, thanks! I can squash the the multiple commits into one, single commit. Just be aware that you'll need to re-merge from Loop/dev into your own fork because the commit hash will change.


menu swapper: quetzal whistle custom shift swap not working

Type
Incorrect behavior
Operating System
Windows
OS Version
10.0.19045.4170
Bug description
Menu entry swapper custom shift swap does not produce swaps for certain entries. I only have a perfected quetzal whistle, but I assume the behavior is similar across all tiers (basic, enhanced, perfected).
Swapping to "use" works, but not the other options.
Screenshots or videos
https://github.com/runelite/runelite/assets/50101641/e9c0071a-4fc7-4c14-ae71-72ef191c7cac
RuneLite version
RuneLite v<IP_ADDRESS>
Launcher v2.7.1
OSRS rev 221
Logs
client.log

Cannot replicate, I menu swapped my whistle as soon as I got it. Here are my settings if you want to figure out the conflicting setting.

Details

Just for clarification, the "Swap left click" works as expected, while "Swap shift click" does not seem to work.

Yes I understood from the video

I also cannot reproduce this. I only have an enhanced whistle, but am finding that shift swaps are working fine for me.


[V2V] Fix allowing address to be blank for the ConversionHost model, and update spec.

Apparently adding :presence => false to the address validation for the ConversionHost model wasn't good enough due to some AR precedence issue, and my spec didn't catch it because it already skipped the validation if the underlying resource didn't return an address.
So, this explicitly skips the check if the address is blank, and updates the spec to make sure that it will return at least one address.
I validated that without this change, the spec will now fail.
Followup to: https://github.com/ManageIQ/manageiq/pull/18610
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1695797

@miq-bot add_label hammer/yes

@miq-bot add_label bug

@miq-bot add_label transformation

@miq-bot assign_reviewer @agrare

@miq-bot add_reviewer @agrare

Hammer backport details:
$ git log -1
commit 716845cb5a0b57fe9ea29c80f8083657a2a892c9
Author: Adam Grare<EMAIL_ADDRESS>Date:   Fri Apr 26 08:00:14 2019 -0400

    Merge pull request #18690 from djberg96/fix_conversion_host_address_validation

    [V2V] Fix allowing address to be blank for the ConversionHost model, and update spec.

    (cherry picked from commit afe8714e54164b619dbd3b8436f9e67b73f3a06f)

    https://bugzilla.redhat.com/show_bug.cgi?id=1696437


"autoCommmit" spelling mistake in JdbcTransaction class

the word "Commmit" must be changed to "Commit".

Good catch :-)
I have set 3.5 as the target milestone because 1) it may not be an urgent issue and 2) it could break existing subclasses.

will u plz describe the complete problem

Closing as a duplicate of #941 .


Couldn't take translations with mcamara/laravel-localization

i get all translated element in fallback correctly but if i change the language with mcamara/laravel-localization, translatable give me back always the fallback locale. There is any to do to solve this problem without insert {'name:lang'} for each element.
edit: if i check the language with App::getLocale() it give me back correct locale
Thanks you

sorry it's my fault


React Example project is not working

What version of OpenTelemetry are you using?
"@opentelemetry/context-zone": "^0.25.0",
"@opentelemetry/core": "^0.25.0",
"@opentelemetry/exporter-collector": "^0.25.0",
"@opentelemetry/plugin-react-load": "^0.23.0",
"@opentelemetry/sdk-trace-base": "^0.25.0",
"@opentelemetry/sdk-trace-web": "^0.25.0",
"react": "^16.13.1",
"react-dom": "^16.13.1",
"react-router-dom": "^5.2.0",
"react-scripts": "^3.4.1",
"reactstrap": "^8.5.1"
What version of Node are you using?
v16.10.0
What did you do?

I tried to clone the repo (https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/examples/react-load/react)  and followed the instructions in the README and got the website running however I do not see any auto-instrumentation happening.
What did you expect to see?
I am a beginner and new to this concept. All that I am trying to check is to get the open-telemetry auto-instrumentation working on my NextJs project, finding it very hard.. Requesting a help !
Also tried to install the following package on my nextjs project, even that breaks. (https://www.npmjs.com/package/@opentelemetry/plugin-react-load)

Thanks in advance.

anybody any luck ?

I only have been using Opentelemtry tracing on the server-side only with Next.js

I have the same issue. just follow this sample with nextjs
https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/examples/react-load/react/


docs: consider breaking out the CLI installations into a separate page

    Personally I would also break out the CLI installations into a separate page

Originally posted by @sympatheticmoose in https://github.com/weaveworks/weave-gitops/issues/3039#issuecomment-1324887551

In #3039 I said:

If anyone would like to take a crack at breaking out the CLI installations, sure that WFM. I just wasn't sure about it as it'd be a separate flow for WG vs WGE, right?

Closing this as nobody has context on what was actually wanted. If someone wants to reopen with crystal clear detail on outcomes, please go ahead


Support for RSocketWebSocketClient on nodeJS clients

(following facebook internal discussion with @lexs)
RSocketWebSocketClient currently relies on WebSocket, which is natively available in browsers. However in nodeJS, there is no native implementation of websockets, so they must be explicitly imported. Attempting to use this client as is in nodeJS throws a "WebSocket not defined" error.
I've updated the RSocketWebSocketClient constructor so that it now accepts a function, wsCreator, that takes url and options (similar to the WebSocket constructor), and returns a WebSocket object. This allows the user to pass any websocket constructor they want to RSocketWebSocketClient; for example, a nodeJS client can use ws.
My change to the RSocketWebSocketClient constructor also allows one to pass headers to  wsCreator, through the options argument. This is a necessary change for some nodeJS clients to work correctly, though it is not currently possible, since the call to the WebSocket constructor only extracts url from options.
I don't have much experience with Flow, so any feedback would be great, particularly on typing things correctly. I'm opening this pull request to get the ball rolling.

I wonder if instead of wsCreator being a function (string) => typeof WebSocket, we can just assume wsCreator is a WebSocket-like constructor? So passing in {wsConstructor: WebSocket} would work, as would {wsConstructor: require('ws-shim-for-my-platform').WebSocket} for other platforms. Basically calling let ws = new (options.wsConstructor === null ? global.WebSocket : options.wsConstructor)(string_url).
(string) => typeof WebSocket imo doesn't seem more helpful than a constructor since we still assume whatever value is returned has the interface of a WebSocket.

@tcr Yeah that sounds fine to me, and results in slightly nicer code.

@tcr That said, the node ws.WebSocket takes more arguments than global.WebSocket does, which makes it a bit hard to pass the additional params.
I'll merge this now to unblock, but just submit a new PR if you want to change it.


[Phaser 3.50] Phaser.Time is undefined in Phaser.Time.Clock#addEvent

Version

Phaser Version: 3.50.0-beta.5

Operating system: Windows 10

Browser: chrome and firefox

Description
if you import phaser with webpack
Phaser.Time is undefined in method Phaser.Time.Clock#addEvent
Example Test Code
import Phaser from "phaser";
import logoImg from "./assets/logo.png";

var config = {
  type: Phaser.AUTO,
  parent: "phaser-example",
  width: 800,
  height: 600,
  scene: {
    preload: preload,
    create: create,
  },
};

var game = new Phaser.Game(config);

function preload() {
  this.load.image("logo", logoImg);
}

function create() {
  var logo = this.add.image(400, 150, "logo");

  var _this = this;

  this.time.addEvent({
    delay: 10000,
    callback: function () {
      _this.tweens.add({
        targets: logo,
        y: 450,
        duration: 2000,
        ease: "Power2",
        yoyo: true,
        loop: -1,
      });
    },
  });
}

Additional Information
most likely Phaser.Time.TimerEvent should be TimerEvent in "phaser\src\time\Clock.js"

What's the actual error? Because Phaser.Time is a perfectly valid namespace and is exported properly. Phaser.Time.TimerEvent is also a valid data type, as it too is exposed correctly.

Uncaught ReferenceError: Phaser is not defined
addEvent phaser.js:190649
create index.js:26
create phaser.js:83985
loadComplete phaser.js:83897
emit phaser.js:2707
loadComplete phaser.js:181444
fileProcessComplete phaser.js:181410
onProcessComplete phaser.js:4719
onload phaser.js:14309
Well in my own project it was "Phaser.Time is undefined" but in the test where i use https://github.com/photonstorm/phaser3-project-template and   "phaser": "^3.50.0-beta.4" it is "Uncaught ReferenceError: Phaser is not defined" seems is miss read


Shrub docs

Docs will be rendered inside the Sail editor and editable, but no further integration needed than this.

Trent finishes up chat/DMs; if work is done, start documenting
Yun continues work on tasks; ^^^
third example: diary

Step 1: lightning back-end tutorial for diary, tasks, chat
Step 2: lightning front-end tutorial for ^^^

counter with very introductory explanations (and maybe comments)

Counter

[ ] Backend
[ ] Backend Docs
[ ] Frontend
[ ] Frontend Docs

Diary

[ ] Backend
[ ] Backend Docs
[ ] Frontend
[ ] Frontend Docs

Tasks

[ ] Backend
[ ] Backend Docs
[ ] Frontend
[ ] Frontend Docs

Messenger

[ ] Backend
[ ] Backend Docs
[ ] Frontend
[ ] Frontend Docs

After completing all of the above, we'll merge in their individual branches, and then write a docs "app" for the UX. Will keep the docs in the fil directory for now, and we can always pull them wherever they need to go if the UX implementation requires it.


fix Fix thrift BackendService thread local is not initialized, memtracker init fail

Proposed changes
Issue Number: close #xxx
Problem summary
#0  0x000056186e4c1f88 in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_assign(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) ()
#1  0x000056186878c3bc in assign (__str=..., this=0x7fa1fd46af78) at /var/local/ldb-toolchain/include/c++/11/bits/basic_string.h:1342
#2  operator= (__str=..., this=0x7fa1fd46af78) at /var/local/ldb-toolchain/include/c++/11/bits/basic_string.h:667
#3  doris::MemTracker::MemTracker (this=0x7fa1fd46af40, label=..., profile=<optimized out>, parent=<optimized out>) at /root/doris/doris/be/src/runtime/memory/mem_tracker.cpp:66
#4  0x0000561868642171 in construct<doris::MemTracker, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > (__p=0x7fa1fd46af40, this=<optimized out>) at /var/local/ldb-toolchain/include/c++/11/ext/new_allocator.h:154
#5  construct<doris::MemTracker, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > (__p=0x7fa1fd46af40, __a=...) at /var/local/ldb-toolchain/include/c++/11/bits/alloc_traits.h:512
#6  _Sp_counted_ptr_inplace<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > (__a=..., this=0x7fa1fd46af30) at /var/local/ldb-toolchain/include/c++/11/bits/shared_ptr_base.h:519
#7  __shared_count<doris::MemTracker, std::allocator<doris::MemTracker>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > (__a=..., __p=<optimized out>, this=<optimized out>)
    at /var/local/ldb-toolchain/include/c++/11/bits/shared_ptr_base.h:650
#8  __shared_ptr<std::allocator<doris::MemTracker>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > (__tag=..., this=<optimized out>) at /var/local/ldb-toolchain/include/c++/11/bits/shared_ptr_base.h:1337
#9  shared_ptr<std::allocator<doris::MemTracker>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > (__tag=..., this=<optimized out>) at /var/local/ldb-toolchain/include/c++/11/bits/shared_ptr.h:409
#10 allocate_shared<doris::MemTracker, std::allocator<doris::MemTracker>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > (__a=...) at /var/local/ldb-toolchain/include/c++/11/bits/shared_ptr.h:861
#11 make_shared<doris::MemTracker, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > () at /var/local/ldb-toolchain/include/c++/11/bits/shared_ptr.h:877
#12 init_scanner_mem_trackers (this=0x7fa1fd53f000) at /root/doris/doris/be/src/runtime/runtime_state.h:81
#13 doris::PlanFragmentExecutor::prepare (this=this@entry=0x7fa1fd52d070, request=..., fragments_ctx=0x7fa1fd589000) at /root/doris/doris/be/src/runtime/plan_fragment_executor.cpp:102
#14 0x000056186861b37d in doris::FragmentExecState::prepare (this=this@entry=0x7fa1fd52d000, params=...) at /root/doris/doris/be/src/runtime/fragment_mgr.cpp:229
#15 0x00005618686227f2 in doris::FragmentMgr::exec_plan_fragment(doris::TExecPlanFragmentParams const&, std::function<void (doris::PlanFragmentExecutor*)>) (this=this@entry=0x7fa2134d9000, params=..., cb=...) at /root/doris/doris/be/src/runtime/fragment_mgr.cpp:711
#16 0x0000561868625391 in doris::FragmentMgr::exec_plan_fragment (this=this@entry=0x7fa2134d9000, params=...) at /var/local/ldb-toolchain/include/c++/11/tuple:746
#17 0x0000561868628f32 in doris::FragmentMgr::exec_external_plan_fragment (this=0x7fa2134d9000, params=..., fragment_instance_id=..., selected_columns=selected_columns@entry=0x7fa0980da190) at /root/doris/doris/be/src/runtime/fragment_mgr.cpp:993
#18 0x000056186879d055 in doris::BackendService::open_scanner (this=0x7fa1facf84a0, result_=..., params=...) at /root/doris/doris/be/src/runtime/exec_env.h:147
#19 0x0000561868984fd1 in doris::BackendServiceProcessor::process_open_scanner (this=0x7fa1fc7934c0, seqid=1, iprot=<optimized out>, oprot=0x7fa1fce761c0, callContext=<optimized out>) at /var/local/ldb-toolchain/include/c++/11/bits/shared_ptr_base.h:1290
#20 0x0000561868987bc2 in doris::BackendServiceProcessor::dispatchCall (this=0x7fa1fc7934c0, iprot=0x7fa1fce76180, oprot=0x7fa1fce761c0, fname=..., seqid=1, callContext=0x7fa1fd47bbc0) at /root/doris/doris/gensrc/build/gen_cpp/BackendService.cpp:5002

Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[x] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[x] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[x] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[x] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[x] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.61 seconds
load time: 451 seconds
storage size:<PHONE_NUMBER>9 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221125105807_clickbench_pr_53104.html


[530] Fix Azure database name suffix issue

Trello card URL
https://trello.com/c/fVBiyDuu
Changes in this PR:
Fix database name suffix logic

 Deploy application


Create a logo

Also use for favicon?

LMK if you'd like to get in touch with the author of electrs logo. ;)


client.reply_message error

I encountered an error while testing basic.py from examples.
Screenshot of the error (cant copy from my terminal):

I need it, please fix it.


No spaces in directory (or file) names

It would be useful to not uses spaces in directory names.   For example, sample-encodings/MEI 3.0 should be renamed to sample-encodings/MEI-3.0.  Notice that sample-encodings avoids the space, but MEI 3.0 does not, so there is currently some inconsistency in the naming of directories.
This is also true of the Musical features directory:  sample-encodings/MEI 3.0/Musical features/snippets which should instead be sample-encodings/MEI-3.0/Musical-features/snippets and preferably make the "M" lower case:  sample-encodings/MEI-3.0/musical-features/snippets (less important for MEI, although mei is somewhat better as well).
In other words, file/directory names should be POSIX compliant for cross-platform compatibility, and that means only use these characters in filenames:
ABCDEFGHIJKLMNOPQRSTUVWXYZ
abcdefghijklmnopqrstuvwxyz
0123456789._-

From section 3.276 (Portable Filename Character Set) of the Open Group Base Specification:
http://opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_276

Closed by 315c1c7

Looks great!


fix(GUI): ignore UNABLE_TO_VERIFY_LEAF_SIGNATURE HTTP issues

This error may get thrown when fetching the list of S3 packages when the
user is behind a proxy tht causes the SSL certificate to incorrectly not
be trusted.
See: https://github.com/atom/apm/issues/103
See: https://github.com/resin-io/etcher/issues/1465
Change-Type: patch
Changelog-Entry: Fix UNABLE_TO_VERIFY_LEAF_SIGNATURE error at startup.
Signed-off-by: Juan Cruz Viotti<EMAIL_ADDRESS>

I'm getting 404 on that page, but would that solve the issue anyways? Correct me if I'm wrong, but the issue is that the user is behind a proxy, which modifies the certificate chain of the remote certificate such that the proxy servers acts like the internal certificate authority.
Even if we do have the common root certs, we'd need the proxy certificate to workaround the issue.
This does mean users behind such an "unconfigured" proxy will be unable to receive update notifications though, but what options do we have?

Oh, messed up a char in the link somehow, here's the correct one: https://git.daplie.com/Daplie/node-ssl-root-cas

Even if we do have the common root certs, we'd need the proxy certificate to workaround the issue.
This does mean users behind such an "unconfigured" proxy will be unable to receive update notifications though, but what options do we have?

I think usually the proxies have some cert with a root CA from that package (thinking about it, Electron should actually already have all of those since it's Chromium), but in case it's completely unconfigured, or uses a self-signed one, we're out of luck I believe. Unless we'd do non-strict TLS just for the notifications, which I don't think is a good idea.

Like the one described in https://github.com/atom/apm/issues/103 should we maybe have a (manual) config option for those users that are behind such a proxy who want to turn off strict SSL?
Will this problem also affect the success-banner page?

Looks like we can add a setting to disable strict SSL and use that to set the strictSSL request option. We also can also integrate https://git.daplie.com/Daplie/node-ssl-root-cas. Which one should we do? I'm happy to give this root CAs module a go before falling back to disabling SSL, but should we always use it, or only some cases? If so, in which?

Sounds like @jhermsmeier knows more about SSL than me, so I'll defer to his knowledge...
And I was suggesting adding an option for a user to explicitly set (if they're behind one of these proxies), not always automatically disabling strictSSL. (apologies if I misunderstood your comment @jviotti )

Yeah, I meant adding a setting that when enabled, it will set strictSSL to false. Let's wait for @jhermsmeier 's opinion.

I think it'd be best to only include the other root CAs; with that we'd at least lower the number of proxies where SSL fails. But I don't see update notifications as important enough to disable strictSSL – and considering that you've already been MITMed on the S3 bucket @jviotti, having the option to disable it is probably a really bad idea.

I think it'd be best to only include the other root CAs

Before doing that, we should verify that they aren't automatically included in all Electron apps anyway? Earlier you said ... Electron should actually already have all of those ....

But I don't see update notifications as important enough to disable strictSSL

As I already asked, will this also affect the success-banner page ?


Added option for autogenerate of buttons

Fixed:
Added option for auto-generation of buttons.

There were the following issues with your Pull Request

Commit: adadad2a6fefcf9ceee4ac1caa05efb592890a4c
Your commit message body contains a line that is longer than 72 characters
Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/thestonefox/SteamVR_Unity_Toolkit

This message was auto-generated by https://gitcop.com

Completed with https://github.com/thestonefox/VRTK/commit/0c3678d812545afbc56a2221e4746a349cacfd36


Set wsktool to use swift:default as the kind

wsktool is set to use swift:3 as the default kind.  Change this to swift:default

merged


feat(v2): @docusaurus/init package

Motivation
Close #1601

Not a good idea for user to install whole core package just to init, so lets separate it into separate package like CRA
No longer silently install for ez debugging
Less dependencies on core

The right way to test this out as npm package is to actually release alpha.20 and try it out.
Others

Fix other bug on theme/Layout regarding metaimage
Some TS deps typing

Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
At root, after installing, compile typescript and mimic running the init command
https://asciinema.org/a/vcInXTcBCChXyIexXPmIAx4HI

Deploy preview for docusaurus-preview failed.
Built with commit 3c0a507476f6d980b33c3b996f5a91aea4fd6839
https://app.netlify.com/sites/docusaurus-preview/deploys/5d2a038a52998800079eb4db

Deploy preview for docusaurus-preview failed.
Built with commit 2411afa04abbfdd18e4cf80fda82248e29ab803d
https://app.netlify.com/sites/docusaurus-preview/deploys/5d2a044e4c65460008e04224

Can we do a @docusaurus/cli package instead and move the commands there? Idk if our architecture permits that at the moment but it'll be good if we can do that.

I actually thought of that too but after some thought i realize that this approach has a very superior advantage: super fast and separated concern. This is also an approach used by CRA.
The thing with having CLI (which i believe can be installed globally like gatsby-cli) and being separated from core is that it can sometimes lead to subtle bugs in behavior and functionality if the version of the globally installed executable does not match the version of core.
Another thing is that if we move the init to docusaurus/cli, it means that the init templates wlll live inside that package. More installation time for all user that doesnt want to init
.
Here's what i suggest:
lets try this out first, since at least this is better than having to install whole core just to init new project.
then, lets create an issue and try to see if docusaurus/cli is worth it. im hoping to get people more experienced with cli stuff to contribute for this part

just the src/pages and src/themes docs stuff and we should be good to go for alpha 20
oh and pls help to add to our tasklist on the CLI in case i forget. gotta sleep