Fix combobox minimize

Details

Adding history router with type drawer to only when on mobile. On web or desktop size we don't need the drawer to toggle.
Fixed Issues

$ https://github.com/Expensify/App/issues/8841
Tests

Click on one chat first
Minimize the window as much as possible
Maximize the window
Click another chat
Minimize window
Verify that the report screen is showing when minimizing the window

[x] Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[ ] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] Any functional components have the displayName property
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose and it is

[x] If a new CSS style is added I verified that:

[x] A similar style doesn’t already exist
[x] The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

PR Reviewer Checklist

[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn’t already exist
[ ] The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

QA Steps

Click on one chat first
Minimize the window as much as possible
Maximize the window
Click another chat
Minimize window
Verify that the report screen is showing when minimizing the window

[x] Verify that no errors appear in the JS console

Screenshots

Web

https://user-images.githubusercontent.com/25520267/177384055-514a3fb7-d4d3-4ef1-b614-9951d5cdb93a.mp4
Mobile Web

https://user-images.githubusercontent.com/25520267/177385809-8c276067-d666-49e0-add8-31bba804957b.mp4
https://user-images.githubusercontent.com/25520267/177385870-316f8d8a-08dd-4950-a213-acf159a8ede6.mp4
Desktop

https://user-images.githubusercontent.com/25520267/177386129-b1ff6179-0296-4e9b-a2fe-6e60a56c1dac.mp4
iOS

https://user-images.githubusercontent.com/25520267/177600273-8eadde99-7836-4196-9aec-a2d14b313e69.mov
Android

@Santhosh-Sellavel Can you help me to test on Android native? I can't run the android on my local. Thanks!

@aldo-expensify @Santhosh-Sellavel updated!

@Santhosh-Sellavel Can you help me to test on Android native? I can't run the android on my local. Thanks!

What issue you are facing in the local?

@mollfpr
We have a breakage here
Steps:

Open the app in the expanded window.
Click any chat
Minimize the window
Click back from the chat header
Try to switch to a different chat but it's not working.

https://user-images.githubusercontent.com/85645967/179294812-4fd8eb7c-fb78-4c62-9ac5-2a5113097ef1.mov
cc: @aldo-expensify

@Santhosh-Sellavel I tried to reproduce the problem you see, but didn't happen to me. Does it always happen to you? or sometimes? can you check if you don't have the same problem in main?

I pulled from main and made the changes.

@Santhosh-Sellavel I'm unable to produce the above issue.

Reviewing again now.

PR Reviewer Checklist

[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] Any functional components have the displayName property
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn’t already exist
[x] The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

thanks for reviewing again @Santhosh-Sellavel !

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

I do wish that a broader conversation would have been started about this PR and solution. Almost every issue dealing with react-navigation was put on hold a while back while so we could look at longer term more holistic solutions. This one still made it through somehow...
@Santhosh-Sellavel please recall these posts (maybe you have not seen them)
https://expensify.slack.com/archives/C02NK2DQWUX/p1652908236507109
https://expensify.slack.com/archives/C02NK2DQWUX/p1653333895007009
@aldo-expensify I'm not sure what I could have done differently here and not casting any blame for accepting this solution. Maybe I could have been more proactive here or there is some way to lock the file so it won't be edited anymore.

🚀 Deployed to staging by @aldo-expensify in version: 1.1.87-0 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
failure ❌

🍎 iOS 🍎
failure ❌

🕸 web 🕸
failure ❌

🚀 Deployed to production by @yuwenmemon in version: 1.1.87-9 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Pusher made an alternative

I find it to be more reliable than reverb though I am sure in time reverb will surpass it

https://github.com/LlmLaraHub/larallama/actions/runs/9783983434
The docs are https://docs.larallama.io/local.html#pusher-or-reverb


Checklist support

Description
Love Marimo and am excited to follow the progress!
When I'm writing markdown, I love to make checklists:

[ ] They help me track progress
[ ] They are fun
[ ] They are a key part of work planning.

The fact that checklists aren't well supported in Marimo has me reverting back to vscode and Markdown when I'm doing certain kinds of work.
Suggested solution
Here in Github, when I have the first item and press enter, the text for a second item appears.
I'm not sure what the ideal support for markdown checklists might be in Marimo, but at a minimum it would be nice if

The next item were autogenerated when you press enter after writing the current item
The rendered markdown looked like a checkbox appropriately either filled or unfilled.

Additionally, it would be nice to have a hot key to toggle a checkmark while editing the markdown.
Alternative
No response
Additional context
No response

thanks for the request. i've added it https://github.com/marimo-team/marimo/pull/3151, it was super easy given its an extension of a dependency we already bring in

So cool 😎 thank you!


Graphical Glitch In-Game

Describe the bug
Graphical glitches while in-game. Look at the screenshot for the issue.
Screenshots

System Information (please complete the following information):

macOS: 13.4 Ventura beta
Device: MacbookPro 16inch 2021
CPU: Apple M1 Pro
RAM: 16 GB RAM

Additional context
I have used different wine versions on the app and tried the workaround 3 and turning of AC patch. The graphical issue still persists. The issue is same with the previous versions as well.
Logs (if any)
game_1680289837424.log

Try to check integrity in launcher setting

yes that fixes things


MultiZONEMD and Signed Digest Tests Fail

The digest tests are based on the [zone examples of the RFC proposal]. However, two of them (MultiZONEMD, SignedZone) fail (this is, the computed digest is different than the example digest). We need to check deeply why they fail. This could be related to problems with sorting or wire formatting.
I also checked other implementations cited on the RFC draft (one in C by the authors, and one in Python). I could not acheive to obtain the same ZONEMD between all the implementations in some zones. Fruther testing is needed to understand the reasons of the differences.

The RFC Proposal changed yesterday and excluded apex ZONEMD RRs from the digest, so the test now passes!
SignedZone test was not passing because of NSEC records: the packer in miekg/dns library assumes a clean buffer to pack RRs. Now we clean the buffer at each iteration.


add label alignment settings

Added defaultLabelAlignment and setup labels.def to support labelAlignment setting - left, right, center, top, bottom and inside as options.  Not sure I have the "inside" option working well - I want it to put the label inside the node if the node is large enough to hold it, otherwise align it right".
Not sure if there are better ways to do this, so feedback welcome - just learning...

@alfredopacino - there's 'center', which will display the label centered on the node (it'll spill outside of the node if there isn't enough space). Is that what you were looking for?

FWIW I took the code that @1tylermitchell shared and modified it to include label alignment on hovers. The only example I have is private/can't be shared, but the diff is here: https://github.com/jasontschool/sigma.js/commit/f6468b8302462d78bf0007c3c4ce7efc9dbd0212
It's been refactored a bit from 1tylermitchell's pull request, but the original functionality should still all be present. The diff is by no means ready for a pull request (there are outdated TODOs throughout, not to mention linting issues), which is why I've commented here rather than submit a request. Please feel free to incorporate and/or adapt the hover code if you'd like, just please give credit where due.
Disclaimer: The label hover outlines are personal preference for 'top'/'bottom'/'center' since there's no precedent for those (unlike 'left' and 'right'). Please feel free to modify those as desired!

actually the 'center' option is what i was talking about!
thanks :)


fix: Color is distorted in FluentDesignTheme

🐛 Bug Report
When setting a color via FluentDesignTheme it seems to be oddly distorted for certain colors.
💻 Repro or Code Sample
Create a new project via dotnet new fluentblazor -o Fluent and add the following line:
<FluentDesignTheme OfficeColor="OfficeColor.PowerBI" Mode="DesignThemeModes.Light" />

to the App.razor file
🤔 Expected Behavior
The resuling color should be like it is described in the documentation (https://fluent2.microsoft.design/color#brand-colors):
.
😯 Current Behavior
The color looks like this:

🔦 Context
I would like to use a bright yellow as the primary color in my application, but cannot seem to get it to work (I also tried deliberately using a "lighter" yellow to see if I can get a more acceptable output color but nothing seems to work :(.
🌍 Your Environment

Windows 11, PC
Mozilla Firefox & Google Chrome
.NET 8.0.2 and Fluent UI Blazor library Version 4.4.1

Then the problem is maybe that there is no way to adjust any of the settings in a way to allow a yellow primary color (e.g. by changing the text color to be black instead of white and achieving the necessary contrast that way) maybe?

Also interestingly enough if I try to explore the color options with https://color.fast.design/ and use (FFFF00) I don't get that ugly brown color.

Also interestingly enough if I try to explore the color options with https://color.fast.design/ and use (FFFF00) I don't get that ugly brown color.

As explained in the comment I linked earlier, that one is using an earlier version of the color system

I'm confused first you say the docs you linked are for Fluent 2 and the web components I'm using are still using Fluent 1 (presumable older than Fluent 2).

The link you are mentioning is for Fluent 2. At the moment (because we are using the Fluent UI Web Components implementation) we are still at Fluent 1

Then your saying that the link refers to an earlier version of the color system?

As explained in the comment I linked earlier, that one is using an earlier version of the color system

So either https://color.fast.design/ uses a version previous to Fluent 1 or I'm misunderstanding something.

Then the problem is maybe that there is no way to adjust any of the settings in a way to allow a yellow primary color (e.g. by changing the text color to be black instead of white and achieving the necessary contrast that way) maybe?
Not for the accent color used in the components, no. Sorry but that is just how the system works at the moment.

Ok just to be clear: which version of Fluent is https://color.fast.design/ using?

You linked to Fluent 2 docs, but we  are not using Fluent 2 yet. We use the Fluent UI Web Components implementation which still uses Fluent 1 Design System.
Fluent 1 uses the Adaptive Color System which you can see in action here https://fluent-components.azurewebsites.net/?path=/docs/design-system-color-explorer--page (from the comment on the other issue I linked to). color.fast.design is not using Fluent at all. It is using an older version of the Adaptive Color System.
Soryy. Hope that makes it more clear. I know it is confusing to have all those version and tems intermingled but it is out of our hands and control...

Oh ok, yeah it really is a bit confusing, but I get that that is out of your control. Thanks for the explanation and the quick replys!

So essentially the Fluent 1 color system does not really look great with light accent colors :(.


Please allow an option to skip X samples at the beginning and end

When viewing results we will often find that some of the initial data and tail data has outliers which are uninteresting for that specific analysis. This usually isn't known apriori - it's usually discovered after a scenario is run and we look at the data. It would be great to have an option to exclude X (samples or time-blocks) from the beginning and the ending of the samples.

Added warmup and cooldown arguments to NetPerfVis. These parameters only have effect on ctsTraffic and latte, since these are the only two whose raw data consists of individual, chronologically ordered samples.


Exception while parsing display data

Description
hi,
I try to controll my windows pc from home assistant via system bridge.
I can access the api on the raspberry pi running home assistant via curl.
After adding the integration in home assistant it initializes and after some time it shows the following error:
Timed out waiting for  ().
The system bridge logs don't show anything suspicious.
The home assistant logs (shown below) show an acception with the following details:
pydantic.error_wrappers.ValidationError: 2 validation errors for Display
When accessing http://:9170/api/data/display?apiKey= I get the following result:
{"last_updated":{}}
I don't know if this is the expected behaviour because this is an desktop machine connected to a KVM switch that (depending on the state of the KVM switch) might not have a display connected.
On the other hand I don't need the display information. It would be great if I could somehow disable modules.
I hope you can help me
Kind regards
Clemens
What Platform / OS are you running?
Windows
What version are you running?
3.5.0
Anything in the logs or a references that might be useful?
2022-11-12 09:01:13.951 ERROR (MainThread) [homeassistant.components.unifi] Error connecting to the UniFi Network at unifi.bergmann.click: Error requesting data from unifi.bergmann.click: Cannot connect to host unifi.bergmann.click:443 ssl:True [SSLCertVerificationError: (1, "[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: Hostname mismatch, certificate is not valid for 'unifi.bergmann.click'. (_ssl.c:1123)")]
2022-11-12 09:01:55.278 WARNING (MainThread) [homeassistant.components.mqtt.light.schema_json] Invalid color mode received for entity light.lampe_eg_kueche
2022-11-12 09:02:00.888 ERROR (MainThread) [homeassistant] Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/srv/homeassistant/lib/python3.9/site-packages/homeassistant/components/system_bridge/coordinator.py", line 150, in _listen_for_data
    await self.websocket_client.listen(callback=self.async_handle_module)
  File "/srv/homeassistant/lib/python3.9/site-packages/systembridgeconnector/websocket_client.py", line 492, in listen
    await self.listen_for_messages(callback=_callback_message)
  File "/srv/homeassistant/lib/python3.9/site-packages/systembridgeconnector/websocket_client.py", line 507, in listen_for_messages
    await callback(message)
  File "/srv/homeassistant/lib/python3.9/site-packages/systembridgeconnector/websocket_client.py", line 480, in _callback_message
    model(**message[EVENT_DATA]),
  File "/srv/homeassistant/lib/python3.9/site-packages/pydantic/main.py", line 331, in __init__
    __doc__ = ''  # Null out the Representation docstring
pydantic.error_wrappers.ValidationError: 2 validation errors for Display
displays
  field required (type=value_error.missing)
last_updated -> displays
  field required (type=value_error.missing)

Additional information
No response

Ane additional hint might be that I start the backend as a windows task on system boot.
This is so that I don't have to log on to control the pc.
The task command is python -m systembridgebackend --no-gui

I should have looked into the closed issues.
This is a duplicate of #2098


TravisCI Failure

TravisCI tests fail because C extensions aren't compiling. Not sure how to fix this. Potentially why ReadtheDocs isn't working either.
References
https://github.com/rwhitt2049/simple-cython-example (although this doesn't work either as is. need to build off this maybe?)

Looks like it was an issue with the server. It's now compiling.

C extension tests are failing.


API Questions

Am trying to implement the new API, have some questions:

/info/current_state returns a '#/components/schemas/CeremonyStatus' but should return a transcript imo
info/status and info/current_state require authWithEth while contribute, abort and try_contribute do not?
Caller should pass a participant when calling abort, where do we get this from?
Caller should pass ParticipantQueueStatus when calling try_contribute where do we get this from?
CeremonyStatus is not specified
The lifecycle.md says optional data should be retrieved using /ceremony/status while the yml only defines /info/status, same with auth and login

Oh and the lifecycle.md talks about jwt while the yaml only talks about authWithEth

@gswirski is the spec up to date? I can help with updating the documentation to the latest version of the API.

The OpenAPI definition, as mentioned on the call, is completely wrong.

/info/current_state returns a '#/components/schemas/CeremonyStatus' but should return a transcript imo

You are correct, /info/current_state returns the transcript

info/status and info/current_state require authWithEth while contribute, abort and try_contribute do not?

/info endpoints don't require any authentication. /try_contribute, /contribute, /abort require authentication bearer token (session id).

Caller should pass a participant when calling abort, where do we get this from?

No need to pass any additional data, just session id in the Authorization header. This endpoint is currently not implemented.

Caller should pass ParticipantQueueStatus when calling try_contribute where do we get this from?

No need to pass any additional data.

CeremonyStatus is not specified

Can be deleted from the OpenAPI file.

The lifecycle.md says optional data should be retrieved using /ceremony/status while the yml only defines /info/status, same with auth and login

That's a mistake. It should be /info/status, not /ceremony/status.

Oh and the lifecycle.md talks about jwt while the yaml only talks about authWithEth

I haven't found a single mention of JWT here: https://github.com/ethereum/kzg-ceremony-specs/blob/master/docs/participant/lifecycle.md In general, we only depend on the session id passed in the authorization header. There are no JWTs anymore.

I can help with updating the documentation to the latest version of the API.

Please do. The reference implementation (https://github.com/ethereum/kzg-ceremony-sequencer) is the source of truth at the moment.
In general, the reference implementation (https://github.com/ethereum/kzg-ceremony-sequencer) is the source of truth.

Still some issue with the doc

No jwt claim anymore, the spec mentions them still
Method is not specified so I foolishly tried to GET the lobby/try_contribute instead of POST which returned 405 (also not specified)

late version of API updated.

Close as completed

Hello transfer crypto to my account


How to check version of asciidoctor-iso

How to check version of asciidoctor-iso from comand line?
How to work with different versions from comand line?

We have not implemented versioning in ISO; but we should.
Different versioning would involve importing different versions of the gem; I'll document that.

Thankyou. This project is excellent.

Have realised version reporting in the metanorma script:
metanorma -t iso -v

Now returns: "Asciidoctor::ISO 0.8.1/IsoDoc 0.7.1"


hi ,how to remove the orange bar ,I have attached the screen shot  please ?

Before submitting issues ...

Make sure you are using XLPagerTabStrip latest release or master branch version.
Make sure your Xcode version is the latest stable one.
Check if the issue was already reported or fixed. We add labels to each issue in order to easily find related issues. If you found a match add a brief comment "I have the same problem" or "+1".

Please do not use the issue tracker for personal support requests. Stack Overflow is a better place for that where a wider community can help you!

When submitting issues, please provide the following information to help maintainers to fix the problem faster:

Environment: XLPagerTabStrip, Xcode and iOS version you are using.
In case of reporting errors, provide Xcode console output of stack trace or code compilation error.
Any other additional detail such as example code that you think it would be useful to understand, reproduce and solve the problem.

I have found an solution please give it to clear that issues.
buttonBarView.backgroundColor   =   .clear


Make conhost history deduplication case-sensitive

The legacy console used to use case-sensitive history deduplication and
this change reverts the logic to restore ye olde history functionality.
This commit additionally changes the other remaining std::equal plus
std::towlower check into a CompareStringOrdinal call,
just because that's what MSDN suggests to use in such situations.
PR Checklist

[x] Closes #4186
[x] I work here
[x] Tests added/passed

Validation Steps Performed

Enter test /v
Enter test /V
Browsing through the history yields both items ✅

In addition to what it says in the title, it changes history lookup. Conhostv1 uses case insensitive lookup on the up arrow.

Isn't that the same? From what I can tell, conhost stores commands already deduplicated in a buffer and the function I modified is used to ensure this deduplication. So basically "history deduplication" and "history lookup" should be the same I think...
Should I make it so that this change only affects "Conhostv2" / the non-legacy conhost?

Isn't that the same?

Sorry, I totally misinterpreted what history lookup was happening where. This is fine -- Conhostv1 uses case-sensitive lookup on F8 (I thought it was Up Arrow), and Conhostv2 doesn't. This change makes it so that Conhostv2 does use case-sensitive lookup on F8


Is there a way to add edit button to each row?

Hello, using v7, so far so great!
I would like to achieve an editable table, when each row has an editing button, when clicked, then the row becomes available for editing.
So far I added an edit button, with onClick action, which returns row id but I am not sure how to change that row into editing cells
Is that possible?
thanks Ales

You can include Actions as mentioned below in column data. You will be passing array of options to actions.
class UserContainer extends React.Component {
    constructor(props) {
        super(props);
        this.state = {
            columns: [{
                            id:'Actions',
                            Header:
Actions
,
                            accessor: d => d.actions,
                            Cell: props => this.displayActionItems(props),
                            sortable: false,
                        }];

componentDidMount() {
let updateState ={...this.state};
updateState.actions = ['Edit', 'Delete'];
this.setState(updatedState); }

displayActionItems = props => {
        return (

                    this.updateUswe(event, props)}>{props.value[0]}
                 this.openDeletePopup(event, props)}> {props.value[1]}

        );
    }

Please let me know if you are still not clear about above code.

Please take a look at the editable table example in the examples directory. 😁
Tanner Linsley
On Dec 3, 2019, 5:33 AM -0700, Prathamesh Phuke<EMAIL_ADDRESS>wrote:

yeah I did, but it is not exactly what I wanted to achieve :)

I think a good way to get help here is to have a codesandbox that others can look at and tweak. What's not quite right about the existing example?

I think you should add an accurate example for the editable row in documentation,
generally, React Table is great but really hard to use as you see reviews on openbase
@tannerlinsley


Expand chain support of impact page

https://app.glodollar.org/impact/glodollar.eth currently shows holdings of $170 whilst app.glodollar.org shows it holds $198.79 - probably some chain is missing

Hi @gglucass  after taking some investigations, I discovered that there is sort of a typo in the home page, where the baseBalance is fetched from an optimism chain Id, i will drop a video demonstration below

Hi @gglucass after taking some investigations, I discovered that there is sort of a typo in the home page, where the baseBalance is fetched from an optimism chain Id, i will drop a video demonstration below

https://github.com/user-attachments/assets/6b31a269-41fd-4ac4-9421-fee9bd320df2

@gglucass  if you check the balances, the baseBalance is not actually the baseBalance rather getting it from the optimism chain instead
the screenshot above is the output of the result after changing the optimismId into the baseId, therefore matching it with the
impact page

if you confirm this, I would also add the remaining chains that are leftout in the impact page
(optimism, base and arbitrum)

if you confirm this, I would also add the remaining chains that are leftout in the impact page
(optimism, base and arbitrum)

Confirming this issue. Great if you add the remaining chains :-)
Apologies for the slow response here, am at a conference.

Sure! no problem

@gglucass confirmed yet ?

@gglucass confirmed yet ?

O sorry for being unclear. With my earlier message I meant that I confirmed the issue!


NIFI-4196 - Expose AWS proxy authentication settings

Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[X] Has your PR been rebased against the latest commit within the target branch (typically master)?

[X] Is your initial contribution a single, squashed commit?

For code changes:

[X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[X] Have you written or updated unit tests to verify your changes?
[X] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[X] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[X] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[X] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[X] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

Please note the displayName settings were not added as most of the AWS related processors lack these

Hey @trixpan, regarding .displayName and .name, I tend to think that we should use both for new properties in a processor, even though it is not the case for legacy properties.
Besides, some tests are now failing:
Failed tests:
  TestDeleteS3Object.testGetPropertyDescriptors:144 size should be eq expected:<20> but was:<22>
  TestFetchS3Object.testGetPropertyDescriptors:181 size should be eq expected:<14> but was:<16>
  TestListS3.testGetPropertyDescriptors:197 size should be eq expected:<15> but was:<17>
  TestPutS3Object.testGetPropertyDescriptors:153 size should be eq expected:<28> but was:<30>

hopefully fixed

Thanks @trixpan, what about my comment on displayName? I know this is kind of cosmetic but when using proper name, it makes things easier when moving templates from one environment to another and that values should be changed in the process.

How can these be tested?

in https://github.com/apache/nifi/pull/2588 I have done this as well, but only in my processor ( scope ).  I would like to see this land.  What can be done to move this forward?

@trixpan can you de-conflict?

@trixpan Similar to #2018, I took the liberty of taking over this PR into #2704. By cherry-picking your commits into my branch, so that we can respect your work and, when mine is merged, this PR will be closed properly.
I've rebased with the latest master, check unit tests and expand the proxy supports to other AWS processors, such as DynamoDB, Kinesis and Lambda there.
@trixpan @ottobackwards @pvillard31 Please keep reviewing these stuffs at #2704. It's ready for finalizing review process. Thanks!


How to enable server certificate verification on the Nodejs BigQuery client for Mutual TLS ?

We are using Nodejs BigQuery client in our product. How do we enable server certificate verification in the BigQuery client?
We want to enable client-side verification of server certificates with our CA bundle.
We've explored the options of BigQuery but couldn't find any.
In the case of other cloud providers we have found a way to pass the CA bundle in the options where the client verifies.
Example for AWS
const nodeOptions = {
    httpsAgent: new https.Agent({
        rejectUnauthorized: true,
        ca: caBundle,
        maxVersion
    }),
};

const requestHandler =  new NodeHttpHandler(nodeOptions);
const athena = new AthenaClient({ credentials, region : 'us-east-1', requestHandler });

In the above example, If rejectUnauthorized is true the server will reject any connection which is not authorized with the list of supplied CAs.

hey @Ruthwik, I haven't tested the set up here yet, but requests on the the BigQuery Node SDK can be modified by adding interceptors. Under the hood we use the teeny-request library and provides a pool attribute that can be used to customize the Agent.
const bigqueryClient = new BigQuery({});
const interceptor = {
  request: (opts) => {
    opts.pool = {
      rejectUnauthorized: true,
      ca: caBundle,
      maxVersion,
    }
    return opts
  },
}
bigqueryClient.interceptors.unshift(interceptor); // add as first interceptor

Thanks for the reply.
How do we provide similar options for clients ex: KeyManagementServiceClient ?

@Ruthwik have you managed to get this working ? Can this issue be closed ?

@alvarowolfx  Yes, it worked thanks. I've raised a separate issue for KeyManagementServiceClient


fix: Button variant validation

Description
Button Variant field in Button's property pane was not getting validated properly.
This was causing some errors at runtime.
Fixes #7625
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Manually tested.

Create a button, change the button variant to js convertible and type any random value.
Change the button color to custom.
If we do the above steps in release, you will see the runtime error.
After this change, this doesn't cause any issue.

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:white_circle: Total coverage has not changed
No changes to code coverage between the base branch and the head branch

@aswathkk was the bug really because of the typo? Can this be avoided with any tests?

Yes @somangshu
The validations are not working properly, which caused this issue.
We have plans to write Jest Tests to avoid these kind of issues #7678

@aswathkk there is a high chance of missing a use case, Please add the relevant tests case here it self!

@somangshu I agree and that's why we planned to create Jest tests.
Can we do it separately since I'm not that familiar with Jest tests and it will take a bit longer time for me to write tests? Meanwhile, this PR is going to fix the problem for the affected users.

@aswathkk this is exactly what we dont want to do. However I will make an exception here. We need to make sure we take up the JEST test ASAP

@aswathkk please merge the latest release. Also seems like this uses the old value which got changed in the button widget enhancement. Please confirm and make changes accordingly

@vivekverma2312 @aswathkk i see that the button has too many discrepancies, the variants are shown as something but the actual option in the JS convertible field is different (old value), these values need to be the same such that the user does not get confused, We need to make the same change for other widgets and make sure that the old widgets dont break. Let me know if a discussion is required around this
cc @riodeuno

@aswathkk Tested Deploy preview and validation is working fine for button, icon, menu and form widgets. Currently it's showing SOLID, OUTLINE & GHOST Once #7793 is fixed expecting to show the current validation options.


[SPARK-16303][DOCS][EXAMPLES][WIP] Updated SQL programming guide and examples

What changes were proposed in this pull request?

Hard-coded Spark SQL sample snippets were moved into source files under examples sub-project.
Removed the inconsistency between Scala and Java Spark SQL examples
Scala and Java Spark SQL examples were updated

How was this patch tested?
The work is still in progress. All involved examples were tested manually. An additional round of testing will be done after the code review.

Can one of the admins verify this patch?

@liancheng could you, please, review this PR?

test this please

add to whitelist

Test build #62092 has started for PR 14119 at commit 95f0f41.

Test build #62092 has finished for PR 14119 at commit 95f0f41.

This patch fails RAT tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62092/
Test FAILed.

Since you've added JavaSparkSqlExample.scala, we can remove JavaSparkSQL.scala now. (I guess that file was from my original WIP branch?)

This looks pretty good! Only found a few minor issues. Thanks for working on it!

Can we add actual stdout output after each .show() call?

Test build #62192 has started for PR 14119 at commit 7451fc7.

Summary of the updates

JavaSparkSQL.java file was removed. I kept it initially since the file itself was quite old (2+ years) and it was present in your original WIP branch alongside the new file. But I can confirm that the new file covers the same functionality and more. No need to keep the old one, agree with you.
Apache header in JavaSqlDataSourceExample.java was added.
$-notation instead of df.col("...") in Scala examples.
col("...") instead of df.col("...") in Java examples.
Blank lines before {% include_example programmatic_schema ... } were added. However, everything was rendered fine locally even without them.
2 space indentation for chained method calls. My fault, sorry.
Actual outputs for all show() calls were added.
Tested manually and via ./dev/run-tests.

Open questions

Shall I add blank lines before each {% include_example ... } or only before those two examples?
I pointed to a wrong location that exceeded the length limit. It is exactly the same functionality but in Java. So, 113 and 117 lines of the JavaSqlDataSourceExample.java file. In my view, it would make sense to keep them as they are now for the better looking documentation.

Test build #62192 has finished for PR 14119 at commit 7451fc7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62192/
Test PASSed.

LGTM, I've merged this to master and branch-2.0. Thanks for working on this!
I only observed one weird rendering caused by the blank lines before {% include_example %}, maybe my local Jekyll version is too low. I think it's fine to leave other lines as is. The exceeded lines should be OK.
Could you please remove the WIP tag from the PR title? (I've removed it manually while merging this PR.)


Add sanity test script

What is the goal of your sanity test script?  To run all of the benchmarks with the provided config files?  If so, I've created a script for that and can contribute it back if that would be helpful.
Matt

@mattsinc Hi Matt, this is exactly what I need. But I have already added one in the tools folder. You can check it out.
If you have additional functionality, please let me know.
Thanks very much for mentioning it though!
Shi

I didn't realize one was there ... darn, I wouldn't have spent the time writing one then.  It looks like your script has similar functionality to mine.  Mine takes an input arg for debuginfo to allow the user the option of quiet runs, but otherwise what you've added should do the same thing as mine.
What is the warmup flag?  I have not seen that documented anywhere, or used anywhere?
Matt

@mattsinc
I just added that script today. So it wasn't a waste of time for you after all. :)
The warmup flag is only useful if you added warm up phase in the benchmark. The only benchmark that uses this flag is test_alexnet. You can find it in the code.
Shi

I added the usage of "warmup" flag in the document.
Shi

Got it, thanks.
Matt


ISSUE #166 RSS parser ignores item's pubDate

Converts RSS timestamp format to w3c format
Use pubDate of item in new SiteMapURL creation

Hi @MichealKum - thanks for the patch, looks good (nice unit tests, too). One question...is the set of date format parsers you created based on an RSS spec, or just what you've seen out in the wild? Wondering if we'll get a pull request in the future for additional date formats :)

Hi @kkrugler , accordingly to the RFC 822 (RSS use this standart for pubDate field) the date-time field should have the format as following: [ day "," ] date time. It also says that a year should be a two-digit-year, but RSS files which I saw also use four digits. Moreover if you parse date with two-digit-year using yyyy then you will get 0017 for 17 instead of 2017. That is why there are these four formats.

Thanks @MichealKum! I've merged. I'll also go add a line to CHANGES.txt (which I should have noted in my review, sorry) about your contribution.

@kkrugler great. By the way: why don't you squash changes during merge? I think it is better to have one commit on master for each PR.

Hi @MichealKum - yes, normally I squash...I forgot that you added a second commit.


Add March 2023 monthly update.

Here is source gist : https://gist.github.com/kgpai/00e9dc77ee18caad99a8d442e4cceace


labels showing unexpectedly

Hello thanks for the cool library. I am having an issue though. Sometimes the float label shows itself by default when the edit text is empty. There doesn't seem to be any rhyme or reason to it. Sometimes it shows and sometimes it doesn't.
Here is snapshot of the xml file I'm using and a screenshot. As you can see sometimes the label shows and sometimes it doesn't. The only difference I see between the views in the xml file is the input type but setting them all to the same thing has no effect. Any idea whats going on?
 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
    android:orientation="vertical" android:layout_width="match_parent"
    android:layout_height="wrap_content">

    <TextView
        android:text="@string/title_payment_method"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content" />

    <com.iangclifton.android.floatlabel.FloatLabel
        android:id="@+id/name_on_card"
        android:hint="@string/name_on_card"
        android:inputType="textPersonName|textCapWords"
        android:layout_marginTop="@dimen/activity_vertical_margin"
        android:layout_width="match_parent"
        android:layout_height="wrap_content" />

    <com.iangclifton.android.floatlabel.FloatLabel
        android:id="@+id/card_number"
        android:hint="@string/card_number"
        android:inputType="number"
        android:layout_marginTop="@dimen/activity_vertical_margin"
        android:layout_width="match_parent"
        android:layout_height="wrap_content" />

    <com.iangclifton.android.floatlabel.FloatLabel
        android:id="@+id/security_code"
        android:hint="@string/security_code"
        android:inputType="text"
        android:layout_marginTop="@dimen/activity_vertical_margin"
        android:layout_width="match_parent"
        android:layout_height="wrap_content" />

    <com.iangclifton.android.floatlabel.FloatLabel
        android:id="@+id/exp_date"
        android:hint="@string/exp_date"
        android:inputType="text"
        android:layout_marginTop="@dimen/activity_vertical_margin"
        android:layout_width="match_parent"
        android:layout_height="wrap_content" />

I don't see anything that should be causing the inconsistent behavior.  Do you see the same issue on other devices or with fewer instances of the FloatLabel?

I'm using FloatLabel all over the place and it only happens here on this
screen. I found it has something to do with the android:id.
If I remove the id from the two labels acting up the issue goes away. Also
just changing the name of the id fixed it.
On Mar 4, 2015 9:56 PM, "Ian G. Clifton"<EMAIL_ADDRESS>wrote:

I don't see anything that should be causing the inconsistent behavior. Do
you see the same issue on other devices or with fewer instances of the
FloatLabel?
—
Reply to this email directly or view it on GitHub
https://github.com/IanGClifton/AndroidFloatLabel/issues/20#issuecomment-77302249
.

Definitely a strange issue.  I wonder if the build tools didn't properly update the ID references?

Nope I have confirmed that isn't the reason. Switching the id back and the issue resurfaced. Looks like it is caused by a matching ID in a different Transition Scene hosted in the activity but not visible at the same time.

I'm having difficulty reproducing this.  I've tried with two scenes.  Each scene had two FloatLabels (R.id.name and R.id.color).  In the first scene I included text in the color FloatLabel but not the name.  I did the opposite in the second scene.  Toggling between the scenes works correctly with labels showing how they should (though the invisible labels temporarily appear before fading out).  Changing either field manually and changing scenes also seems to work.  Any idea what else is different?

I am using this Transitions Everywhere library https://github.com/andkulikov/transitions-everywhere
I will try to rip out the business stuff and upload an example.

Thanks, I appreciate it!

Okay here is a zip with a project that reproduces the issue. Just open the app and press the 'Add Payment Method' button.  Issue happens 100% of the time on my GS5 running lollipop. I haven't had a chance to test other devices.
https://drive.google.com/file/d/0B9BQRk_YVoNrdDVqVVduY3dnY0k/view?usp=sharing

Thanks for the code sample.  I've pulled it down and can confirm I'm seeing the issue.  I'll see if I can track it down now.

Looks like it's something with the way the Transitions Everywhere library is setting up the views.  I further cut down the code to just a few views and the built in Scene handling works fine in Android (tested on 5.0), but the library shows the hint and label at the same time.  I'll dig in some more and see if I can figure out what the difference is between how the library is working and how the native code works.

So are you saying that using the framework transition api (just changing the package name) actually resolves the issue as well?  If that is the case I would be inclined to open a bug there as well.

Yeah, if you switch to android.transition.TransitionManager and android.transition.Scene, it works fine.  From what I can tell, the TransitionsEverywhere API is not respecting the alpha value of the label.  I can see mLabel.setAlpha(0) getting called in the FloatLabel.init() method, so the label shouldn't show, but the TransitionsEverywhere library is resetting it to 1.0.

This is great info. I'll pass this along. Sounds like this bug is invalid
here.
On Mar 9, 2015 10:42 PM, "Ian G. Clifton"<EMAIL_ADDRESS>wrote:

Yeah, if you switch to android.transition.TransitionManager and
android.transition.Scene, it works fine. From what I can tell, the
TransitionsEverywhere API is not respecting the alpha value of the label. I
can see mLabel.setAlpha(0) getting called in the FloatLabel.init() method,
so the label shouldn't show, but the TransitionsEverywhere library is
resetting it to 1.0.
—
Reply to this email directly or view it on GitHub
https://github.com/IanGClifton/AndroidFloatLabel/issues/20#issuecomment-77991059
.

Thanks, I'll close this one out.


Preparation for v2 release

I continue to not have a strong preference between this implementation and moving the v2 folder contents to the root directory but I thought I'd give implementing one of them a go to see what it looked like. I also switched the module path to follow the standard for repos in k8s sigs.
Resolves #157

/assign @mhbauer

I also do not have a strong opinion if we should move the content to root dir or move go.mod inside the /v2 package.
One thing that I want to know is what needs to be done if we want to have e.g. v3 version?
If we will use the  "major version subdirectory strategy", we need to create a v3 pkg and copy content there? or rename the package from v2 to v3? as having multiple versions on master can be strange for me and maintain that e.g. for the same commit you can create a release with tag v3.0.0 and v2.0.0 as you still have two folders on the master 🤔
and when all things will be moved to root dir then we can only change the version in go.mod from v2 to v3? like one line change? or it's more complicated?

I think your assessment of the "major version subdirectory strategy" is correct in that if we wanted to bump to v3 we would then have both v2 and v3 on master which seems weird to me.
On the other hand switching to everything at the root dir would mean that if we bumped to v3 then we would also need to maintain a v2 branch for if changes needed to be made there, that said that is more of a normal flow.

PR with the alternative implementation: #162

I'm going to close this as #162 was merged and this was a different possible route.


Update Character “elder-prescilla-oakborn”

Automatically generated by Netlify CMS

👷 Deploy Preview for dynamic-cheesecake-5fbd8b processing.

Name
Link

🔨 Latest commit
2a4eda35ed203ed9ffabdca1553d7b5a8a2570bd

🔍 Latest deploy log
https://app.netlify.com/sites/dynamic-cheesecake-5fbd8b/deploys/63372d13c114a30008a0cc62


Fix tests: drop python 2.7 support and tests

The docs build is still failing, but the rest of the tests pass


deadlock error

Problem
If I use multiline detection, it works but I get deadlock; recursive locking errors in fluentd logs
(concat plugin is used as part of Splunk connect for Kubernetes https://github.com/splunk/splunk-connect-for-kubernetes)
Steps to replicate
Log:
2019-03-18 06:06:48.859  INFO [manage-xxx-service,,,] [<IP_ADDRESS>] 1 --- [-15276-thread-1] o.a.k.clients.consumer.ConsumerConfig    : ConsumerConfig values:
        auto.commit.interval.ms = 5000
        auto.offset.reset = latest
        bootstrap.servers = [my-kafka-service:9092]
        check.crcs = true

Config:
      <filter tail.containers.var.log.containers.*.log>
        @type concat
        key log
        timeout_label @SPLUNK
        stream_identity_key stream
        multiline_start_regexp /^\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}.\d{3}/
        flush_interval 5s
      </filter>

Expected Behavior
It works (multi line appears as a single event in Splunk) but I see many errors in fluentd logs. I believe 1 error every 5 second for every log file:
2019-03-18 05:13:54 +0000 [warn]: #0 dump an error event: error_class=ThreadError error="deadlock; recursive locking" location="/usr/local/bundle/gems/fluent-plugin-concat-2.3.0/lib/fluent/plugin/filter_concat.rb:144:in `synchronize'" tag="tail.containers.var.log.containers.manage-xxx-service-85855985fc-pgl6g_yyy_manage-incident-service-0ee1814dcd3596c96e0bf6c0a2e65a9437cf1b282a95daf41fbd6e8933df1f8f.log" time=

Your environment

Kubernetes
Splunk connect for kubernetes

See original ticket https://github.com/splunk/splunk-connect-for-kubernetes/issues/111

Which version of Fluentd and Ruby do you use?
Do you see the same errors without k8s?

Hey Okkez!
Dockerfile for the images used is here:
https://github.com/splunk/fluent-plugin-splunk-hec/blob/master/docker/Dockerfile
We use Ruby 2.5.1-slim & fluentd 1.4.0 in our latest build. Don’t believe we saw this in fluentd 1.2.x which we used in the previous version of our images.

anything further I can help collect to assist with this?

@matthewmodestino Thanks.
I want the reproducible scenario to debug this issue.
I don't have any idea to resolve this issue...

Have you had the chance to test the plugin against fluent 1.4?
What is your preferred testing method?
If I provide steps using our docker container, is that ok? Or do you prefer testing some other way?

I have tested this plugin using very simple configuration and logs with Fluentd 1.4.x.
I like bare metal environment for debugging.
But reproducible steps using docker containers are also OK.

Hi @okkez,
Apologies for the delay.
I have pushed test configs to my repo, that I hope will make it easy for you to have a look at this.
I used docker desktop, but technically these configs should be able to run anywhere.
git clone https://github.com/matthewmodestino/container_workshop.git
Or just grab the splunk_docker and fluent_docker folders from the repo.
bring up the Splunk contianer so fluentd has a backend to send to:
docker-compose -f 1so_hec.yaml -f 1so_hec.yaml up -d
give it a minute to start up.
The deploy the fluentd container:
docker-compose -f fluent_hec.yaml up -d
The fluentd folder has the config directory that contains the configuration files and is mounted into the container when it runs.
The output.conf file contains the following concat plugin config:
<filter tail.containers.**>
    @type concat
    key log
    timeout_label @SPLUNK
    stream_identity_key stream
    multiline_start_regexp /^\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}/
    flush_interval 5s
  </filter>

You should end up with:
docker ps -a
CONTAINER ID        IMAGE                      COMMAND                  CREATED             STATUS                             PORTS                                                                                NAMES
dca738a36569        splunk/fluentd-hec:1.1.0   "/fluentd/entrypoint…"   4 seconds ago       Up 3 seconds                                                                                fluent-hec
36ce93169d2d        splunk/splunk:latest       "/sbin/entrypoint.sh…"   26 seconds ago      Up 24 seconds (health: starting)   4001/tcp, 8065/tcp, 8191/tcp, 9887/tcp, 9997/tcp, <IP_ADDRESS>:9999->8000/tcp, <IP_ADDRESS>:9088->8088/tcp, <IP_ADDRESS>:9089->8089/tcp   so1

check the logs of the fluentd container:
docker logs -f dca738a36569
at the very top of the log we dump the running configs and versions:
2019-05-21 17:16:35 +0000 [info]: starting fluentd-1.4.0 pid=6 ruby="2.5.1"
2019-05-21 17:16:35 +0000 [info]: spawn command to main:  cmdline=["/usr/local/bin/ruby", "-Eascii-8bit:ascii-8bit", "/usr/local/bundle/bin/fluentd", "-c", "/fluentd/etc/fluent.conf", "--under-supervisor"]
2019-05-21 17:16:35 +0000 [info]: gem 'fluent-plugin-concat' version '2.3.0'
2019-05-21 17:16:35 +0000 [info]: gem 'fluent-plugin-jq' version '0.5.1'
2019-05-21 17:16:35 +0000 [info]: gem 'fluent-plugin-prometheus' version '1.3.0'
2019-05-21 17:16:35 +0000 [info]: gem 'fluent-plugin-splunk-hec' version '1.1.0'
2019-05-21 17:16:35 +0000 [info]: gem 'fluent-plugin-systemd' version '1.0.2'
2019-05-21 17:16:35 +0000 [info]: gem 'fluentd' version '1.4.0'
2019-05-21 17:16:35 +0000 [info]: adding filter in @SPLUNK pattern="tail.containers.**" type="jq_transformer"
2019-05-21 17:16:35 +0000 [info]: adding filter in @SPLUNK pattern="tail.containers.**" type="concat"
2019-05-21 17:16:35 +0000 [info]: adding filter in @SPLUNK pattern="tail.config.**" type="jq_transformer"
2019-05-21 17:16:35 +0000 [info]: adding match in @SPLUNK pattern="**" type="splunk_hec"

and you should see that the logs we picked up from the fluentd pod itself start triggering the concat rule and spitting errors:
2019-05-21 17:18:53 +0000 [info]: #0 Timeout flush: tail.containers.var.lib.docker.containers.dca738a36569ceb04fa6c21bc0cf39a4fbd95ab661e140cedc4c5b423f8cddc0.dca738a36569ceb04fa6c21bc0cf39a4fbd95ab661e140cedc4c5b423f8cddc0-json.log:stdout
2019-05-21 17:18:58 +0000 [warn]: #0 dump an error event: error_class=ThreadError error="deadlock; recursive locking" location="/usr/local/bundle/gems/fluent-plugin-concat-2.3.0/lib/fluent/plugin/filter_concat.rb:144:in `synchronize'" tag="tail.containers.var.lib.docker.containers.dca738a36569ceb04fa6c21bc0cf39a4fbd95ab661e140cedc4c5b423f8cddc0.dca738a36569ceb04fa6c21bc0cf39a4fbd95ab661e140cedc4c5b423f8cddc0-json.log" time=2019-05-21 17:18:58.562890167 +0000 record={"log"=>"2019-05-21 17:18:53 +0000 [info]: #0 Timeout flush: tail.containers.var.lib.docker.containers.dca738a36569ceb04fa6c21bc0cf39a4fbd95ab661e140cedc4c5b423f8cddc0.dca738a36569ceb04fa6c21bc0cf39a4fbd95ab661e140cedc4c5b423f8cddc0-json.log:stdout\n", "stream"=>"stdout", "source"=>"/var/lib/docker/containers/dca738a36569ceb04fa6c21bc0cf39a4fbd95ab661e140cedc4c5b423f8cddc0/dca738a36569ceb04fa6c21bc0cf39a4fbd95ab661e140cedc4c5b423f8cddc0-json.log", "container_id"=>"dca738a36569"}

Let me know if there is something specific you would like me to check in the fluentd container itself.
to clean up these resources:
from within your fluentd_docker folder:
docker-compose -f fluent_hec.yaml down
then from within your splunk_docker folder:
docker-compose -f 1so_hec.yaml down
Clean up docker volumes:
docker volume prune

Sorry for the delay. I missed the issue.
Try following diff:
diff --git a/fluentd_docker/config/output.conf b/fluentd_docker/config/output.conf
index 9029af3..531748f 100644
--- a/fluentd_docker/config/output.conf
+++ b/fluentd_docker/config/output.conf
@@ -1,10 +1,9 @@
-
- # extract index fields and sourcetype for container logs
+
+  # extract index fields and sourcetype for container logs
   <filter tail.containers.**>
     @type jq_transformer
     jq '.record | .container_id = (.source | capture("(?<container_id>[0-9a-f]{12})") | .container_id)'
   </filter>
-
   <filter tail.containers.**>
     @type concat
     key log
@@ -13,14 +12,26 @@
     multiline_start_regexp /^\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}/
     flush_interval 5s
   </filter>
+  <match>
+    @type relabel
+    @label @SPLUNK
+  </match>
+

- # = filters for docker config =
+
+  # = filters for docker config =
   <filter tail.config.**>
     @type jq_transformer
     jq ".record.sourcetype = \"docker:config\" | .record"
   </filter>
-
- # = output =
+  <match>
+    @type relabel
+    @label @SPLUNK
+  </match>
+
+
+
+  # = output =
   <match **>
     @type splunk_hec
     protocol https
diff --git a/fluentd_docker/config/source.containers.conf b/fluentd_docker/config/source.containers.conf
index 636c6ac..af4a05d 100644
--- a/fluentd_docker/config/source.containers.conf
+++ b/fluentd_docker/config/source.containers.conf
@@ -18,7 +18,7 @@
 <source>
   @id containers.log
   @type tail
-  @label @SPLUNK
+  @label @TRANSFORM1
   tag tail.containers.*
   path /var/lib/docker/containers/*/*-json.log
   pos_file /var/log/splunk-fluentd-containers.log.pos
diff --git a/fluentd_docker/config/source.docker.conf b/fluentd_docker/config/source.docker.conf
index e1c5246..43f43fe 100644
--- a/fluentd_docker/config/source.docker.conf
+++ b/fluentd_docker/config/source.docker.conf
@@ -2,7 +2,7 @@
 <source>
   @id config.v2
   @type tail
-  @label @SPLUNK
+  @label @TRANSFORM2
   tag tail.config.*
   path /var/lib/docker/containers/*/config.v2.json
   pos_file /var/log/splunk-fluentd-docker-config.log.pos

In the original configuration, concat plugin configuration includes timeout_label @SPLUNK that will re-emit the event to .
At this time, re-emitted events via timeout and emitted events via normal flow will conflict and it will cause deadlock which is reported in this issue.
In the above diff, I set the proper label to apply the appropriate filter per <source>.
We should apply concat filter once.

Thanks so much for checking. I will review and advise.

I can also confirm that avoiding reemission to the current label fixes the problem. The use case here is with Docker's partial_message, concatenating logs that were split up by standard Docker buffering.
If anyone is interested this is my current configuration snippet, working well in docker-ce 18.06.1, fluentd 1.7.0 and fluent-plugin-concat 2.4.0:
<source>
  @type forward
  # Some Docker logs can be split to 16 KB chunks, concat them first
  @label @CONCAT_PARTIAL
  port 24224
  bind <IP_ADDRESS>
</source>

  <filter **>
    @type concat
    key log
    stream_identity_key container_id
    partial_key partial_message
    partial_value true
    keep_partial_key false
    separator ""
    use_first_timestamp true
    flush_interval 5
    timeout_label @START
  </filter>

  # Send all logs to @START label, whether the concat attempt timed out or succeeded
  <match **>
    @type relabel
    @label @START
  </match>

# the rest of log processing pipeline

@peter-slovak I have a partial log that gets truncated into four separated log and the partial log does not always get created, in fact it share the same field ("log") with the other normal size log under 16k.  How does the "partial_key log" determine when the parial log ends to append the partial logs?
  <filter **>
    @type concat
    key log
    stream_identity_key container_id
    partial_key partial_message
    partial_value true
    keep_partial_key false
    separator ""
    use_first_timestamp true
    flush_interval 5
    timeout_label @START
  </filter>

Thanks.

@bamb00 As I understand it, Docker flags partial logs in its internal structure and then exposes that flag to a particular logging driver/plugin. In case of fluentd, the flag makes it into the partial_message log attribute.
Since these logs are line-oriented, as soon as we encounter an \n in the log, we know it's the last chunk. See https://github.com/moby/moby/issues/34620#issuecomment-325912345 for a more detailed explanation by people that know a lot more about this :)


npm 1.0.97 installation failing on SunOS 5.10

I am getting the following output when trying to install npm on SunOS with node 0.4.5
[jill@fhemuwal ~]$ curl http://npmjs.org/install.sh | sh
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  6366  100  6366    0     0  84283      0 --:--:-- --:--:-- --:--:--  124k
tar=/opt/local/bin/tar
version:
tar (GNU tar) 1.25
Copyright (C) 2010 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by John Gilmore and Jay Fenlason.
fetching: http://registry.npmjs.org/npm/-/npm-1.0.97.tgz
npm-install-4127.sh: test: argument expected
It failed

Any ideas on what might be wrong?
Thanks

Can you run it in debug mode, like this?
curl http://npmjs.org/install.sh | npm_debug=1 bash

Just did it. The last bit of the output shows:
npm ERR! Error: Spawn disabled for securtity reasons
npm ERR!     at ChildProcess.spawn (child_process.js:243:28)
npm ERR!     at Object.spawn (child_process.js:31:15)
npm ERR!     at spawn (/tmp/npm.6957/package/lib/utils/exec.js:103:22)
npm ERR!     at /tmp/npm.6957/package/lib/utils/tar.js:86:15
npm ERR!     at /tmp/npm.6957/package/lib/utils/mkdir-p.js:45:32
npm ERR!     at Array.forEach (native)
npm ERR!     at cb (/tmp/npm.6957/package/lib/utils/mkdir-p.js:45:9)
npm ERR!     at /tmp/npm.6957/package/lib/utils/mkdir-p.js:83:50
npm ERR!     at cb (/tmp/npm.6957/package/node_modules/graceful-fs/graceful-fs.js:36:9)
npm ERR! Report this *entire* log at:
npm ERR!     <http://github.com/isaacs/npm/issues>
npm ERR! or email it to:
npm ERR<EMAIL_ADDRESS>npm ERR!
npm ERR! System SunOS 5.11
npm ERR! command "/opt/local/bin/node" "/tmp/npm.6957/package/cli.js" "install" "-gf"
npm ERR! cwd /tmp/npm.6957/package
npm ERR! node -v v0.4.5
npm ERR! npm -v 1.0.97
npm verb exit [ 1, true ]
npm ERR!
npm ERR! Additional logging details can be found in:
npm ERR!     /tmp/npm.6957/package/npm-debug.log
npm not ok
+ ret=1
+ '[' 1 -ne 0 ']'
+ echo 'It failed'
It failed
+ exit 1

Ok.  So... you'll never get npm to work until you get a version of node that isn't crippled.  Who decided that child_process.spawn is a security problem?
I'd recommend building node from source, and never going back to wherever you got that hobbled node install from.

Alright, that makes sense. Unfortunately it is already our own build
for Solaris and have no idea why it is crippled. In any case, thanks
for your help!
On Fri, Oct 14, 2011 at 6:49 PM, Isaac Z. Schlueter
<EMAIL_ADDRESS>wrote:

Ok.  So... you'll never get npm to work until you get a version of node that isn't crippled.  Who decided that child_process.spawn is a security problem?
I'd recommend building node from source, and never going back to wherever you got that hobbled node install from.
--
Reply to this email directly or view it on GitHub:
https://github.com/isaacs/npm/issues/1553#issuecomment-2408739

The confusing thing about that error is that it's really not a security risk at all.  I mean, you can run bash scripts, so it's not like you're unable to run child processes in other programs (bash, etc.), and running untrusted node programs can cause all kinds of mischief just by using fs and such.  So, really, I don't know what crippling child_process.spawn actually buys you, security-wise.

These are special binaries for the cloud9 shared run environment - where 1000s of devs connect to simultaneously. Hence the security concern.

@javruben Right, but what can a person do with child_process.spawn that is worse than what they can do with fs.write?
Security should be done at the os level, by running their node scripts as a user with strictly limited privileges, perhaps in a chroot or a zone.

We've secured it on the os level. But allowing someone to run binary executables allows script kiddies and others to easily run rootkits and such. Soon when we have a smart machine around each running process this won't be needed anymore.

How would the script kiddies install a rootkit?  Writing a script file is one thing, but they'd still have to get it to run with elevated perms in the first place before it could be used to execute other commands with elevated permissions.
I'm still unconvinced that any vulnerability is actually prevented by blocking child_process.spawn, which is not still possible using only fs.write.  Furthermore, if you allow login shells, then they can already do anything that node's child_process.spawn can do just from bash.

Hi Guys,
This is just a mixup. Sergi accidentally used our shared-env solaris binary of node, which i have patched to be 'more' secure for people running code. We have done a number of things to make it harder to try binary kernel exploits. For this reason we also don't provide a real-shell but a semi-faked one. I can explain more about our set-up and security offline.


Skip dance x86

Clear prefix env var if x86 so we can skip the scripts/ bins dance when we don't need to do it.

We need to allow for 64->32 bit x86 builds, so rejecting.


made put route, added image input, cancel button

checkout my changes plz

wow good job dude 🐧 🍬 🍜


exiv2: 0.28.0 -> 0.28.1

Description of changes
https://github.com/Exiv2/exiv2/blob/v0.28.1/doc/ChangeLog
Fixes CVE-2023-44398 (High).
https://github.com/Exiv2/exiv2/issues/2762 is now fixed upstream, so make checkPhase run unconditionally again.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Just add "-DCMAKE_INSTALL_DATADIR=${placeholder "dev"}/share" to cmakeFlags.

@ofborg build photoqt

@ofborg build digikam

Yes, this PR needs to provide patches for digikam, kphotoalbum and photoqt.

https://invent.kde.org/graphics/digikam/-/commit/f5ea91a7f6c1926815ec68f3e0176d6c15b83051 could probably help.

No more regression on x86_64-linux.

Result of nixpkgs-review pr 266341 run on aarch64-darwin 1

38 packages marked as broken and skipped:

cataract
cataract-unstable
entangle
gimp-with-plugins
gnome.nautilus-python
gnome.nautilus-python.dev
gnome.nautilus-python.devdoc
gnome.nautilus-python.doc
kphotoalbum
krename
latte-dock
libsForQt5.arianna
libsForQt5.bismuth
libsForQt5.krohnkite
libsForQt5.kwin-dynamic-workspaces
libsForQt5.kwin-tiling
libsForQt5.kzones
libsForQt5.parachute
lightly-boehs
lightly-qt
nordic
nordic.sddm
plasma5Packages.arianna
plasma5Packages.bismuth
plasma5Packages.krohnkite
plasma5Packages.kwin-dynamic-workspaces
plasma5Packages.kwin-tiling
plasma5Packages.kzones
plasma5Packages.parachute
python310Packages.py3exiv2
python310Packages.py3exiv2.dist
python311Packages.py3exiv2
python311Packages.py3exiv2.dist
toppler
variety
variety.dist
vimiv-qt
vimiv-qt.dist

29 packages built:

darktable
exiv2
exiv2.dev
exiv2.doc
exiv2.lib
exiv2.man
gegl
gegl.dev
gegl.devdoc
gexiv2
gexiv2.dev
gexiv2.devdoc
gimp (gimpPlugins.gimp)
gimp.dev (gimpPlugins.gimp.dev)
gimpPlugins.gmic
gnunet
gnunet-gtk
gpscorrelate
gramps
gramps.dist
libextractor
libsForQt5.kfilemetadata (plasma5Packages.kfilemetadata)
libsForQt5.kfilemetadata.bin (plasma5Packages.kfilemetadata.bin)
libsForQt5.kfilemetadata.dev (plasma5Packages.kfilemetadata.dev)
merkaartor
nomacs
photoqt
tracker-miners
viking


Guideline for repeated code block in Jupyter notebook

Something brought up by @samanthalh -- When one is developing notebook for users and find oneself in a situation where one needs to copy and paste the same code with slight variations (e.g., plotting results of subsequent tweakreg runs on the same dataset), is it better to:

Brute force copy and paste; OR
Write a function of the repeated code and then call it with different inputs where they vary?

Brute force way is more tedious and provides clarity and possibly is resistant to out-of-order cell runs in some cases. A function might be more elegant and reduce future maintenance but user needs to scroll up to see what happens in the function, and the cell with the function needs to be run before all the other stuff.
Is a guide line for such a thing within scope of this document?

It's a common quandary. My preference would be to define each function in a cell of its own with if it's more than a few lines long, since otherwise all that repeated code can just obfuscate the examples being communicated in the later cells. As a matter of style, I'd suggest these be collected in their own section early in the notebook, and descriptions of what they do in separate markdown cells.


Current YC's should be queried, even if there are no locked-in.

The method GetYieldCurveReportParametersAsync should query all the current YC's even if the locked-in is not present, as it is the case in the VFA-valuation approach. The current version of the query returns no YC's if the locked-in is absent.
FYI: @dcolleoni


The LEDDisplay does not handle negative values

It displays invalid input instead of negative numbers

Closed in https://github.com/plotly/dash-daq/pull/52.


Remove println

Using AsyncServiceClient in Osedax and noticed that it was using println instead of a logger.

Current coverage is 80.28%

Merging #296 into master will not affect coverage as of 4c1469d

@@            master    #296   diff @@
======================================
  Files           70      70
  Stmts         3530    3530
  Branches       450     450
  Methods
======================================
  Hit           2834    2834
  Partial          0       0
  Missed         696     696

Review entire Coverage Diff as of 4c1469d

Powered by Codecov. Updated on successful CI builds.

Like it!

These lines can be removed altogether.  I actually did this in my open PR.

:+1:


Go to Definition is readonly - is this expected

Azure Data Studio Version:
Version: 1.8.0-insider (system setup)
Commit: 3e8f25d8642c9560f6296d97bde2b164aedf25df
Date: 2019-05-27T07:46:13.508Z
VS Code 1.33.1
Electron: 3.1.8
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 10.0.17763

Steps to Reproduce:
From todays insiders build and dev build I am noticing that Go to definition is opening a readonly editor where as Peek definition is still editable. This is a new behavior. Is this expected?
Peek

Go To

This is likely a dupe of #5684 which is from something in the latest VSCode merge. I'm investigating currently - although maybe @anthonydresser has an idea of what's wrong.
(It appears to be something with how editor input is assigned, the Editor code will set it to readonly if the Input is anything but UntitledEditorInput but with the latest changes the input is a FileEditorInput. I'm not sure what this was like before though so it's possible this is expected and something else to blame).

Probably an option we need to add when we open the editor.


[docs] update link and description about hypercrx in README & INSTALLATION

update link and description about hypercrx in README & INSTALLATION

/approve


Invalid cluster "c1"

Which clusters panel is this on?
c1
Describe the bug
When I try run "composer install", makes error "Invalid cluster "ci

Run "composer install --ignore-platform-req=ext-gmp"

this should no longer be an issue, however this repository is no longer maintained, check https://github.com/coalaura/opfw-admin


Select component's required="true" property doesn't produce the * mark

Describe the bug
Select component's required="true" property doesn't produce the * mark
To Reproduce
See the example code.
Example:
<dxc-select label="Power Type" required="true" margin="xxsmall">
</dxc-select>

Expected behavior
An astric mark is expected to appear in UI.

The issue has been fixed and it is available in the next version.
Here is an example:
https://codesandbox.io/s/required-select-c3qcq
It will also be available in the next release.

This fix has been included in the release 3.0.2
<EMAIL_ADDRESS>


Let's make a push to master-stable with this new format

Patch notes since last master-stable push:

updating the welcome/quick start stuff with Yash findings

chrome bullet points

@karelhala @kruai @iphands can we re-review?


Update typescript to 5.3.2

2 breaking errors:

server/graphql/v2/object/AccountingCategory.ts:35:1 - error TS2303: Circular definition of import alias 'GraphQLAccountingCategory'.

export default GraphQLAccountingCategory;

server/graphql/v2/object/Expense.ts:534:10 - error TS2303: Circular definition of import alias 'GraphQLExpense'.

export { GraphQLExpense };

Solve in https://github.com/opencollective/opencollective-api/pull/9728


bclm loses persistence when battery loses power

M1 mac on 14.6. Sorry if this issue is mostly duplicate.
Core issue is: if the laptop "hibernates" due to a flat battery, then is turned on, the charge limit is reset to 100%. On the other hand, "persistance" works fine: if the laptop is restarted, the correct bclm value is written (sorry, I haven't tested in a while, but that is my recollection). Is that because launch agents are not triggered when exiting from hibernation?

See discussion in #54.

Ran into this again today. This is NOT the same issue, and this issue is not resolved.
The laptop runs out of battery and enters hibernation mode, upon of-which exit the BCLM value is not "persisted". The laptop does not spend more than a few minutes in the powered-off "hibernation" state; this issue is distinct from #54.
From what I understand, BCLM persistence uses a launchagent, so when the laptop is restarted or powered on, it will write the new value. However, when the laptop exits hibernation mode, instead of starting all launch processes again, the state is restored from the sleepimage: the BCLM value isn't written. (This is my hypothesis, I haven't read the source code or the Apple docs)
So the solution to this issue would be to either find a way to run a script on exit from hibernation; to run a script on the relevant battery event (I haven't read the docs); or to run a health-check daemon.


[Issue #246.1][Try #2] GUI: Add First Operator (regex)

Added Regex Operator -> Added Regex Panel in Menu
Added Delete Button
Added first Javascript interactions with flowchart.js ('createOperator' and 'deleteSelected')

Did a F2F review.  After making a few changes made by @kishore-narendran please go ahead to do the merge.


Remove curl dependency and modernize apt usage

This change uses the apt::key defined type to add the dotdeb key,
thereby removing the exec and dependency on curl.

Thanks


[Investigate] - launching modules elevated, not the runner

Can we detect if applications are running elevated and suggest PT needs to be relaunched elevated if they want to interact?  This would keep us in more secure state.
Background:
Since PowerToys itself is a process, it can only do things at or below the same 'privilege'.  If PowerShell or Terminal is launched as an admin and PT isn't, PT can't interact with those windows.
Why:

There is no need for having PowerRename elevated when FancyZone would have to be
Addresses concerns in #942

this seems like it is exzactly the same issue the windows terminal has run into.
i highly advice that you work together on this problem and sav allot of time.
they seem to have a good idea on how to fix this.
i find this is an extremely necessary feature for both apps.

Hi @NicTanghe
in PowerToys, we are refactoring the code to make each module a standalone application, so it will be easier to run each application at the required elevation level.

But won't all windows in fancy zones not either be a security loophole or not be be usable for most terminal commands ?

I'm not sure I understand the first question.
FZ doesn't receive arbitrary input from outside, so it doesn't expose a surface to be attacked.

In 0.18 we will do work to make this possible, but it will require more work before being possible to run SG or FZ as standalone apps. Moving to 0.19 even if more likely it will be in 0.20.

We have now the ability to launch modules non-elevated when the runner is elevated.
The initial idea of launching the modules elevated from a non-elevated runner would cause each elevated module to prompt the UAC, that is not a good user experience.
Right now, when PT runs elevated at startup, it doesn't need to prompt the UAC, that would change if the runner will not run elevated and the modules will run elevated.

@crutkas
as I explained in the previous comment, this approach has drawbacks.
I think we should close this issue and only consider the other way around: launch modules non-elevated when the runner is elevated.


Reuse config wizard forms for adding a system

Progress towards https://github.com/ethyca/fides/issues/1034
Code Changes
Most of this is refactoring DescribeSystemForm.tsx, PrivacyDeclarationForm.tsx, ReviewSystemForm, and SuccessPage such that they can be used on other pages and are less tied to the config wizard.

[x] Refactor forms to use our tooltip prop. We originally didn't do this when the designs were different, but now the designs look like they just use the regular chakra tooltip, so I refactored them all.
[x] Give the forms an onSuccess prop instead of making them always advance the config wizard (so that our new form can advance its own stuff instead)
[x] Give the forms a systemKey prop instead of always getting the system from the config wizard slice
[x] Add validation schemas via Yup so we can better render when fields are required (better errors)
[x] Remove some anys
[x] Pull out the accordion that shows finished privacy declarations into its own component (PrivacyDeclarationAccordion), to be reused between PrivacyDeclarationForm and ReviewSystemForm
[x] Add loading states
[x] Fix the way some of the forms look (misaligned components)
[x] Cypress tests

Then there's only a few changes to plop these into the new ManualSystemFlow component:

[x] Render the config wizard forms based on the current step
[x] Hold the existing system we are working on in state

Steps to Confirm

[ ] Visit /system, click "Create new system", then "Manually generate a system"
[ ] Go through the flow and create a system with privacy declarations

Pre-Merge Checklist

[x] All CI Pipelines Succeeded
Documentation Updated:

[ ] documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
[ ] documentation issue created (tag docs-team to complete issue separately)

[ ] Issue Requirements are Met
[ ] Relevant Follow-Up Issues Created
[x] Update CHANGELOG.md

Description Of Changes
This doesn't do everything I would have liked to do for https://github.com/ethyca/fides/issues/1034. The big missing thing is all of the additional system fields that we want to be able to fill in through this view that we didn't need in the config wizard. Then there are other quality of life things:

Although the buttons are clickable to go back in the process, they don't render with the proper values if a system is already half-made
The form claims that the systems aren't registered until the end, though really they get created/updated with each step. Is this what we want?

In any case, this PR was already getting too big, so calling it here and will continue work in another PR!
https://user-images.githubusercontent.com/24641006/190244726-ed770cd8-0b3b-4ba0-be55-e12966e81930.mov
Error messages upon touching a required field but not filling it in

One more refactoring change I just snuck in to match the designs more:
previously:

now:


Add Windows support

Hi @alecbcs @hyprspace, nice project!
This PR adds Windows support to Hyprspace. Water library requires OpenVPN tap driver to be installed and so we too.
Related issue #2
Examples
example.yaml
interface:
  name: Ethernet 3
...

Start commands
hyprspace up example -f -c example.yaml

Closed in favor of #65

Hey @dukzcry! Apologies for the delay on reviewing this PR and getting back to you! Your work here looks great! I'll followup in #65.


[rancher/charts] assumeOwnershipOfCRDs fails when the ConfigMap is too big

What kind of request is this (question/bug/enhancement/feature request):
feature request
Steps to reproduce (least amount of steps as possible):
Pick any chart that is using assumeOwnershipOfCRDs (only rancher-monitoring at the moment) and add over 1mb to the CRD directory. Then try running the scripts and installing the chart that comes out of it.
Result:
On trying to install the CRD chart, Helm will produce something like:
Fri, Nov 6 2020 3:55:58 pm | helm upgrade --history-max=5 --install=true --namespace=cattle-monitoring-system --timeout=10m0s --values=/home/shell/helm/values-rancher-monitoring-crd-11.0.000.yaml --version=11.0.000 --wait=true rancher-monitoring-crd /home/shell/helm/rancher-monitoring-crd-11.0.000.tgz
Fri, Nov 6 2020 3:56:00 pm | checking 4 resources for changes
Fri, Nov 6 2020 3:56:00 pm | Looks like there are no changes for ServiceAccount "rancher-monitoring-crd-manager"
Fri, Nov 6 2020 3:56:00 pm | error updating the resource "rancher-monitoring-crd-manifest":
Fri, Nov 6 2020 3:56:00 pm | cannot patch "rancher-monitoring-crd-manifest" with kind ConfigMap: ConfigMap "rancher-monitoring-crd-manifest" is invalid: []: Too long: must have at most 1048576 bytes
Fri, Nov 6 2020 3:56:00 pm | Looks like there are no changes for ClusterRole "rancher-monitoring-crd-manager"
Fri, Nov 6 2020 3:56:00 pm | Looks like there are no changes for ClusterRoleBinding "rancher-monitoring-crd-manager"
Fri, Nov 6 2020 3:56:01 pm | Error: UPGRADE FAILED: cannot patch "rancher-monitoring-crd-manifest" with kind ConfigMap: ConfigMap "rancher-monitoring-crd-manifest" is invalid: []: Too long: must have at most 1048576 bytes

Other details that may be helpful:
Encountered this as part of the rebase here https://github.com/rancher/charts/pull/836.
For testing, I think we should just see if the new monitoring chart is capable of being installed as this feature request will block https://github.com/rancher/rancher/issues/29871.

Didn't seem to be required to deploy onto https://github.com/rancher/rancher/issues/29871 so I'm closing out this issue.


Update docs for font stacks

Related PR

I like it. But can we do a git rename instead of just renaming so it maintains history?

@joshuaogle For some reason GitHub is not picking up on git mv for me…

Oops, I did mean git mv. You may need to rename it back the regular way and then do it. I'd like to maintain that, but :+1:

@joshuaogle Man, I tried it all (reverting back and force pushing back here, new commit, rebasing and squashing) but mv is just not working for me. It shows as renamed locally, but not here on GitHub. :cry:


ant: use upstream launcher script

Let's use Ant's upstream launcher script. It handles far more edge-cases than ours.
Instead of writing our own, let's simply hard-code values into the launcher that are known in advance.
One small step towards #353512. Closes #4105, because a path to the JRE is one of the things we now explicitly set. Something similar first attempted by @linsui in #266313.

Things done

Built on platform(s)

[ ] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I'm not sure if using substituteInPlace is a good idea.
(${VAR} and $VAR mean the same thing, but only one of them is replaced).
I would probably either use wrapProgram $out/lib/ant/bin --set ANT_HOME "..." or just put export ANT_HOME="..." after the shebang in the script.
Here's the unsubsituted launcher script for easier viewing: https://gist.github.com/TomaSajt/485fc88337e768e2d065cc61eb0c4560

I'm not sure if using substituteInPlace is a good idea. (${VAR} and $VAR mean the same thing, but only one of them is replaced).

Good call; we shouldn't make assumptions about what style of variable substitution the script uses.

I would probably either use wrapProgram $out/lib/ant/bin --set ANT_HOME "..." or just put export ANT_HOME="..." after the shebang in the script.

I elected to do the latter (wrapping a wrapper feels off); this now uses sed to set variables immediately after the shebang.

I've modified the patch to use echo and vanilla Bash variable substitution instead of a complicated sed invocation; hopefully it's easier to read now.

Marking as WIP. Most dependents fail to build with this message:
Error: Could not find or load main class org.apache.tools.ant.launch.Launcher

This PR is blocked by #360019.

No, it shouldn't be.

The rebuild amount doesn't justify staging.

The rebuild amount doesn't justify staging.
OfBorg's rebuild count isn't accurate. It's approximately 800 cumulative rebuilds (a few weeks ago; not much has changed since then): https://github.com/NixOS/nixpkgs/pull/357162#issuecomment-2487717647

CI failures look unrelated.

Rebased onto common ancestor of master and staging, with the hope that CI will succeed.