Investigate RKE-CI test failure

Investigate why RKE-CI test is failing.
On 07/07/22 failed after 2 retries:
Attempt 1: https://github.com/epinio/epinio/runs/7226603004?check_suite_focus=true#step:12:92
Attempt 2: https://github.com/epinio/epinio/runs/7227173872?check_suite_focus=true#step:12:119
Here error seems a timeout:
STEP: Installing MetalLB 07/07/22 03:45:58.643
STEP: Checking LoadBalancer IP 07/07/22 03:46:25.97
<< End Captured GinkgoWriter Output
Timed out after 240.000s.
  Expected
      <string>: traefik   LoadBalancer   <IP_ADDRESS>   <pending>   80:31055/TCP,443:32142/TCP   4m28s
  not to contain substring
      <string>: <pending>

Note: On 07/06/22 it had 1 failure but passed after 2nd attempt
Attempt 1: https://github.com/epinio/epinio/runs/7207945462?check_suite_focus=true#step:12:244
Attempt 2: https://github.com/epinio/epinio/runs/7209599092?check_suite_focus=true
Here the error was:
failed to create new app image: connect to repo store "index.docker.io/paketobuildpacks/run:full-cnb": Get "https://auth.docker.io/token?scope=repository%!A(MISSING)paketobuildpacks%!F(MISSING)run%!A(MISSING)pull&service=registry.docker.io": EOF

Today error seems to be different: https://github.com/epinio/epinio/runs/7246759009?check_suite_focus=true#step:12:144
Release "metallb" does not exist. Installing it now.
  Error: execution error at (metallb/templates/deprecated_configInline.yaml:2:4): Starting from v0.13.0 configInline is no longer supported. Please see https://metallb.universe.tf/#backward-compatibility
  Unexpected error:
      <*exec.ExitError | 0xc0007bf520>: {
          ProcessState: {
              pid: 2280,
              status: 256,
              rusage: {
                  Utime: {Sec: 0, Usec: 456488},
                  Stime: {Sec: 0, Usec: 188919},
                  Maxrss: 51812,
                  Ixrss: 0,
                  Idrss: 0,
                  Isrss: 0,
                  Minflt: 27[98](https://github.com/epinio/epinio/runs/7246759009?check_suite_focus=true#step:12:99),
                  Majflt: 0,
                  Nswap: 0,
                  Inblock: 0,
                  Oublock: [101](https://github.com/epinio/epinio/runs/7246759009?check_suite_focus=true#step:12:102)6,
                  Msgsnd: 0,
                  Msgrcv: 0,
                  Nsignals: 0,
                  Nvcsw: 2765,
                  Nivcsw: 209,
              },
          },
          Stderr: nil,
      }
      exit status 1
  occurred
In [It] at: /home/sles/actions-runner/_work/epinio/epinio/acceptance/install/scenario3_test.go:84

I am not sure if it is needed an update on the test in regards to configInline

I investigated this a bit more.
In the release notes 0.13.3 from https://metallb.universe.tf/release-notes/ they force the failure of helm release if the a configInline file is provided: https://github.com/metallb/metallb/pull/1485. Since we have a file like that failure is expected and we need to substitute it.
In our case the file seems to be located here: /epinio/assets/tests/values-metallb-rke.yml
configInline:
  address-pools:
  - name: default
    protocol: layer2
    addresses:
    - @IP_RANGE@

Now, about what to do, I am not sure yet but this is what I have come so far in terms of possible paths of solutions:
Path 1:
The error redirect to this page (https://metallb.universe.tf/#backward-compatibility) but I am not sure I find anything useful there. If I understand correctly it is showing a way of backcompatiblity via configmap. If what it implies is that we use and old way, I found this link on v.0.7.3 on how to configure a an sample MetaLB configuration in example-layer2-config.yaml:
apiVersion: v1
kind: ConfigMap
metadata:
  namespace: metallb-system
  name: config
data:
  config: |
    address-pools:
    - name: my-ip-space
      protocol: layer2
      addresses:
      - <IP_ADDRESS>-<IP_ADDRESS>

Path 2
On the most recent version MetalLB v.0.13.3 they show the following advanced L2 configuration. I am not sure if the path is adapting somehow our data to this: https://metallb.universe.tf/configuration/_advanced_l2_configuration/)
apiVersion: metallb.io/v1beta1
kind: L2Advertisement
metadata:
  name: example
spec:
  ipAddressPools:
  - second-pool
  nodeSelectors:
  - matchLabels:
      kubernetes.io/hostname: NodeC

@andreas-kupries , could you please help me out / give a bit of guidance here?
Thanks

I turned out to be wrong.
After a nice conversation with @enrichman and @andreas-kupries what seems to be needed is explained in https://metallb.universe.tf/#backward-compatibility:

In order to use the tool the container must be ran mapping the path with the source file config.yaml to /var/input, and it will generate a resources.yaml file containing the resources mapped to the yaml.
docker run -d -v $(pwd):/var/input quay.io/metallb/configmaptocrs -source config.yaml

I applied this locally using:
➜  tests git:(main) ✗ docker run -d -v $(pwd):/var/input quay.io/metallb/configmaptocrs -source values-metallb-rke.yml
97a5835e9366ed95b9d8ff8ad1516621afb4976129e9a73fdf9bc9ef2bd3030d

However, the resources.yaml file created is empty:

Does anybody know if this correct? If not I will try it in a PR
Thanks

Looking at assets/tests/values-metallb-rke.yml again I see that while it looks like yaml, it does not look like a full kubernetes resource.  Looking further ...

out, err = proc.RunW("helm", "upgrade", "--install", "--wait", "-n", "metallb",
"--create-namespace", "metallb", "metallb/metallb", "-f",
testenv.TestAssetPath("values-metallb-rke.yml"))

is the using place (one of them) ... This file serves as a values.yaml for the metallb helm chart.
Our thought wrt docker run to convert are completely wrong.
Apologies.
Reread https://metallb.universe.tf/#backward-compatibility ... I am also unable to find any reference to the configInLine on that page. I will ask on the MetalLB PR disabling configinline about that.

Thank you very much @andreas-kupries for keep helping here and for all the input, even if we are wrong.
Let's wait then a bit until further response.

thank you @andreas-kupries ,
I will try then what you comment above and will redirect the test towards resources.yaml just created. Definitively trying with a real ip helped to create the file.

I will comment here once I have the results

I updated the ticket title and initial content after the scope is clear.

Quick status: after a bit of tweaking, it seems the issue with the configInline may be fixed as commented in the PR; however seems to fail on later steps. I will continue taking a look.

Finally, it seems fixed in the pr: #1637


Window query should include windows without AX reference

For yabai to actually manage windows, we need to use the accessibility API to request an operation to be performed.
This AX reference can only be created when the window is located on a visible space. If yabai is launched while a user session is in progress, one must visit all spaces manually for yabai to report information about those windows in queries.
Yabai can detect these windows and retrieve a subset of the information to include in window query results, instead of ignoring them completely. However they will not be valid operands for commands that take a <window_sel> argument.

Fixed in v7.0.0.


Thanks for the report @masakulaYOU. I believe this depends on the direction the mouse is dragged. If you drag up, the camera behavior behaves as expected. If you move it to either side, the behavior show in the gif above occurs.


add protein preediction task for ipex

Hi @echarlaix . I want to add an example of protein prediction to show users how to apply ipex optimization on a loaded remote model. I choose protst model, which is a SOTA model for protein prediction. Would you please help to review and merge it? Thx!

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Hi @jiqing-feng !
The example seems to introduce a lot of task and model implementation specific code for which the demand is low (45 downloads in a month).
To demonstrate that ipex works on arbitrary remote modeling code, it would be better to target an architecture which is not natively integrated in transformers but has a lot of demand like ChatGLM for example.
I think It would also make more sense to add this example in ipex examples https://github.com/intel/intel-extension-for-pytorch/tree/main/examples/cpu/inference/python since the only use of optimum-intel here is jit_trace which is just a utility function.

Agreed with @IlyasMoutawwakil, I don't think optimum-intel is the most adapted place for this example

Thanks, I will try another way : )


Unify function to retrieve attributes in templates

Currently several functions are used to fetch attributes from templates that depend on the type of the property: getString, getNumber, and getBool.
We should unify them to a single one, e.g.: "get".

Depends on https://github.com/flexiant/digger/issues/1


chore(cdc,dm): add prow OWNERS files to controal approving for critial files

What problem does this PR solve?

Issue Number: close #10895
What is changed and how it works?
add delicate approvers for these files:

CDC component:

pkg/cmd/util/changefeed.toml
cdc/api/v2/*.go but execlude go test files.

DM component:

dm/master/config.go
dm/worker/config.go
dm/config/task.go
dm/config/source_config.go

Check List
Tests

No code

Questions
Will it cause performance regression or break compatibility?
No
Do you need to update user documentation, design documentation or monitoring documentation?
No
Release note
None

/hold
Wait for the merging decide.

/cc @kevin-xianliu @BenMeadowcroft @yudongusa @easonn7

/cc @kevin-xianliu @BenMeadowcroft @yudongusa @easonn7 @flowbehappy  @Benjamin2037

/cc lance6716 sdojjy

/unhold

/retest

@wuhuizuo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
Test name	Commit	Details	Required	Rerun command
pull-engine-integration-test	e456600 link	unknown	/test engine-integration-test
Full PR test history. Your PR dashboard.

Flaky case!


Adding json directives for Amazon Managed Services.

Adding in the json models for the AMS cli.

Codecov Report

Merging #1611 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1611   +/-   ##
========================================
  Coverage    91.96%   91.96%
========================================
  Files           51       51
  Lines         9287     9287
========================================
  Hits          8541     8541
  Misses         746      746

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a20591a...b98f23f. Read the comment docs.


Can't add or style elements of main content

Hello, I had set it up and run npm install, I need to know how to add elements like in the kitchen-sink page to the content area of a page. I added  the code from kitchen-sink.php to a wordpress page but it was not working as expected (I don't really have any idea how to implement this properly). Well, the motionUI works but it doesn't inherit the style from the kitchen sink. I used the kitchen-sink template but only the default elements are working. Thanks!

I also have a problem with the style of sidebar widgets, footer widgets. I don't know if I have a clean installation but the default page templates work fine (front, kitchen sink etc). Does the content area have no style by default, same with widgets? Am I missing something?

When you say main content area of the page, do you mean in the content editor inside Wordpress?

@nitrokevin yes sir :)

What directory were you in when you ran npm install?

Main directory, is there a file to edit the style of content area? like
widget-areas.php
On Friday, 26 February 2016, Chuck<EMAIL_ADDRESS>wrote:

What directory were you in when you ran npm install?
—
Reply to this email directly or view it on GitHub
https://github.com/olefredrik/FoundationPress/issues/736#issuecomment-188860100
.

Styling takes place in the assets/scss folder.
Most things can be changed in the _settings.scss file.

Thanks for the quick reply.. So how do we add the components like the orbit for example? Do I have to copy and paste the code from the kitchen sink?

That should work.
Lines 381-422 in page-templates/kitchen-sink.php file is for Orbit.

Yes it is working, the orbit is moving its content.. The design of
content is what I am not sure of.. It's still kind of messy, I don't know
if it should be inhirited by default like in the kitchen sink page when it
is selected. For every page template I tried there is no design in the
content area.. If I have to edit the style which file to edit then?
On Friday, 26 February 2016, Chuck<EMAIL_ADDRESS>wrote:

That should work.
Lines 381-422 in page-templates/kitchen-sink.php
https://github.com/olefredrik/FoundationPress/blob/master/page-templates/kitchen-sink.php#L381
file is for Orbit.
—
Reply to this email directly or view it on GitHub
https://github.com/olefredrik/FoundationPress/issues/736#issuecomment-188895357
.

The styling for Orbit is in the /assets/scss/global/_settings.scss on line 390.

Doesn't the default style work like the demo page? After I installed the theme the style works fine for demo pages. But not in the content area so I doubt if I have a clean installation. That's what I need to confirm before messing with the design.
For example the orbit's bullets in my content area are horizontal while in the demo they are vertical. But they are clickable and working fine.

Here is the styling used on the demo pages. /assets/scss/templates

In the Readme file for this repo, he lists which files are used for styling. Here

Didn't realize you edited the above post.
You could open your page and the kitchen sink page in different tabs of your browser. Then inspect elements (such as the orbit buttons), compare the differences and make changes accordingly.

Oh, so I have a clean installation? and I just have to edit the style so it won't be messy?

Yep, that's the idea behind a starter theme.
Style it how you want it to look.

I think you are saying there is no styling, can you share a screen shot

Ok here's the screenshots, they are both on the same page (with kitchen-sink page template), on top of the page there's a working orbit with a nice default style of foundation.

I'm guessing that the problem is you're trying to do this from the content editor, which may be adding <p> tags around the bullets, making them show up on separate lines.
I wouldn't recommend putting components that involve a lot of markup through the content editor. It can be a nightmare to deal with. Can you hardcode the Orbit slider into the page template instead? If the client needs to change the images you can make a "theme options" page where they can select the images in the slider.

Yes that's what I'm doing.. I just want to know how to add
elements properly on the content area but I don't add codes I wrote, I copy
and paste codes from the kitchen sink php file for the orbit and they have
different output.. So I wonder why..
To simplify my questions, I ran npm install and I got a lot of warnings..
Then I ran npm run build without errors. I don't know if things are working
properly because I'm new to this. Based on what I have said and my
screenshots, do I have a clean installation?
If not then why my components have different result from the demo? I have
tried styling the widget-area and it works but how about the content of the
page? how to add style to those components I will put into it? Do I have to
write my own custom shortcodes to add components for the content area or
there's another ready-made options? You know what guys I really appreciate
your help.. I think I'm getting closer to what I want to achieve here..
Thanks!
On Friday, 26 February 2016, Colin Marshall<EMAIL_ADDRESS>wrote:

I'm guessing that the problem is you're trying to do this from the content
editor, which may be adding  tags around the bullets, making them show
up on separate lines.
I wouldn't recommend putting components that involve a lot of markup
through the content editor. It can be a nightmare to deal with. Can you
hardcode the Orbit slider into the page template instead? If the client
needs to change the images you can make a "theme options" page where they
can select the images in the slider.
—
Reply to this email directly or view it on GitHub
https://github.com/olefredrik/FoundationPress/issues/736#issuecomment-189080143
.

Warnings are usually fine when it comes to npm install. It doesn't sound like you are having build errors.
Like I said, your problem is that you're not going to have consistent results if you put components with a lot of markup in the content editor. Shortcodes are one route, but I'm not sure what's out there for Foundation 6. We're working on shortcodes for FoundationPress, but haven't gotten around to Orbit shortcodes yet. The other route is to put the code in a page template, which is pretty simple and easy, but you'll need to add theme options if you want the client to be able to change images in the slider through the dashboard without having to touch code.

If you search Wordpress plugins there is one for foundation shortcodes not sure how upto date it is but you could try it
Sent from my iPhone

On 26 Feb 2016, at 03:24, wakatoyee<EMAIL_ADDRESS>wrote:
Yes that's what I'm doing.. I just want to know how to add
elements properly on the content area but I don't add codes I wrote, I copy
and paste codes from the kitchen sink php file for the orbit and they have
different output.. So I wonder why..
To simplify my questions, I ran npm install and I got a lot of warnings..
Then I ran npm run build without errors. I don't know if things are working
properly because I'm new to this. Based on what I have said and my
screenshots, do I have a clean installation?
If not then why my components have different result from the demo? I have
tried styling the widget-area and it works but how about the content of the
page? how to add style to those components I will put into it? Do I have to
write my own custom shortcodes to add components for the content area or
there's another ready-made options? You know what guys I really appreciate
your help.. I think I'm getting closer to what I want to achieve here..
Thanks!
On Friday, 26 February 2016, Colin Marshall<EMAIL_ADDRESS>wrote:

I'm guessing that the problem is you're trying to do this from the content
editor, which may be adding  tags around the bullets, making them show
up on separate lines.
I wouldn't recommend putting components that involve a lot of markup
through the content editor. It can be a nightmare to deal with. Can you
hardcode the Orbit slider into the page template instead? If the client
needs to change the images you can make a "theme options" page where they
can select the images in the slider.
—
Reply to this email directly or view it on GitHub
https://github.com/olefredrik/FoundationPress/issues/736#issuecomment-189080143
.

—
Reply to this email directly or view it on GitHub.

I would suggest that you use Advanced Custom Fields (ACF), which is a lifesaver plugin which I believe is essential for all WP theme development. With ACF you can easily add a carousel widget to your templates and let editors drag and drop images, captions and whatnot, without having to deal with short codes or even worse, code. You will need the core ACF plugin, the repeater field add-on and some very basic coding knowledge to get this to work.

Hi ole, I haven't had the chance to close it.. I still don't have an idea
how to design the content
On Monday, 7 March 2016, Ole Fredrik Lie<EMAIL_ADDRESS>wrote:

Closed #736 https://github.com/olefredrik/FoundationPress/issues/736.
—
Reply to this email directly or view it on GitHub
https://github.com/olefredrik/FoundationPress/issues/736#event-580014295
.

I haven't touched it again either, but I will definitely use it, thumbs up
for this!! thank you.
On Monday, 7 March 2016, miko anahaw<EMAIL_ADDRESS>wrote:

Hi ole, I haven't had the chance to close it.. I still don't have an idea
how to design the content
On Monday, 7 March 2016, Ole Fredrik Lie<EMAIL_ADDRESS><javascript:_e(%7B%7D,'cvml','notifications@github.com');>> wrote:

Closed #736 https://github.com/olefredrik/FoundationPress/issues/736.
—
Reply to this email directly or view it on GitHub
https://github.com/olefredrik/FoundationPress/issues/736#event-580014295
.

Hi,
There are several ways to add content areas containing the Foundation UI components. As I said, I would recommend checking out ACF.
I've read this thread a couple of times, and it' s still not clear to me what the issue is. If you believe you've found a bug in FoundationPress, please file a new issue and follow the guidelines in the new issue template. If you have general questions that are not related to a bug, please use the Gitter chat or Foundation forum.

got it thanks
On Monday, 7 March 2016, Ole Fredrik Lie<EMAIL_ADDRESS>wrote:

Hi,
There are several ways to add content areas containing the Foundation UI
components. As I said, I would recommend checking out ACF.
I've read this thread a couple of times, and it' s still not clear to me
what the issue is. If you believe you've found a bug in FoundationPress,
please file a new issue
https://github.com/olefredrik/FoundationPress/issues/new and follow the
guidelines in the new issue template. If you have general questions that
are not related to a bug, please use the Gitter chat
https://gitter.im/olefredrik/foundationpress or Foundation forum
http://foundation.zurb.com/forum/.
—
Reply to this email directly or view it on GitHub
https://github.com/olefredrik/FoundationPress/issues/736#issuecomment-193232969
.


ocp deployment failure on gcp: failed API check during the deployement.

BUG REPORT INFO
Environment

Cloud provider:  GCP

OS details :
Linux 3.10.0-693.17.1.el7.x86_64 x86_64
NAME="Red Hat Enterprise Linux Server"
VERSION="7.5 (Maipo)"
ID="rhel"
ID_LIKE="fedora"
VARIANT="Server"
VARIANT_ID="server"
VERSION_ID="7.5"
PRETTY_NAME="Red Hat Enterprise Linux"
ANSI_COLOR="0;31"
CPE_NAME="cpe:/o:redhat:enterprise_linux:7.5:beta:server"
HOME_URL="https://www.redhat.com/"
BUG_REPORT_URL="https://bugzilla.redhat.com/"

REDHAT_BUGZILLA_PRODUCT="Red Hat Enterprise Linux 7"
REDHAT_BUGZILLA_PRODUCT_VERSION=7.5
REDHAT_SUPPORT_PRODUCT="Red Hat Enterprise Linux"
REDHAT_SUPPORT_PRODUCT_VERSION="7.5 Beta"

Version of Ansible:
ansible <IP_ADDRESS>
config file = /etc/ansible/ansible.cfg
configured module search path = [u'/home/joe/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
ansible python module location = /usr/lib/python2.7/site-packages/ansible
executable location = /usr/bin/ansible
python version = 2.7.5 (default, Dec  8 2017, 16:39:59) [GCC 4.8.5 20150623 (Red Hat 4.8.5-25)]

Command used to invoke ansible:  ocp-on-gce
Output of ansible run:

fatal: [ocp-a1-master-ktcd]: FAILED! => {"attempts": 120, "changed": false, "cmd": ["curl", "--silent", "--tlsv1.2", "--cacert", "/etc/origin/master/ca-bundle.crt", "https://internal.master.sbox.jlab.ovh/healthz/ready"], "delta": "0:00:00.019442", "end": "2018-02-26 09:33:23.423800", "msg": "non-zero return code", "rc": 6, "start": "2018-02-26 09:33:23.404358", "stderr": "", "stderr_lines": [], "stdout": "", "stdout_lines": []}

Anything else do we need to know:
I am using a rhel 7.4 for the infrastructure.
During the installtion, the new records for the master api (internal) were not resolved. So, the curl check  for the api is failed.
I am deploying OCP 3.7 (3.7.23)
I see the records for the Cloud-DNS were created but, can't be resolved.

nslookup internal.master.sbox.jlab.ovh
Server:		<IP_ADDRESS>
Address:	<IP_ADDRESS>#53
** server can't find internal.master.sbox.jlab.ovh: NXDOMAIN
nslookup jlab.ovh
Server:		<IP_ADDRESS>
Address:	<IP_ADDRESS>#53
Non-authoritative answer:
Name:	jlab.ovh
Address: <IP_ADDRESS>
any thoughts about this ?
Regards,

I think this is related to the dns propagation between the third party and google dns domains.
I don't have the issue anymore.

Closing per previous comment.


Failed to load in safari

https://github.com/Ju99ernaut/grapesjs-component-code-editor/blob/61025da5256ad2d52edbf745edf177acf14645d3/src/code-editor/index.js#L140
I tried using
.split(/(?:}\n)/g)

Does this ok for a PR?

A PR would be welcome.

Hi @Ju99ernaut, sorry for commenting on a closed issue, but seems that it still not working

I'm not sure if this was fixed, I don't have safari so I was waiting for a PR


Fix missing $REQUIRE_SLES11 for Storage-only deploys

Signed-off-by: Tim Serong<EMAIL_ADDRESS>

I can't believe I missed this in the last commit :-/

Is there a reason why the sles_11 repos are not needed for SES?

If you do an SES-only deploy, with SES 1.0+ you only deploy SLE 12 nodes, which themselves have no need for the SLE 11 repos, so I thought it made sense to remove the hard requirement.
(The admin node itself probably still wants them, for updates to it, though)

Ok, thanks for the explanation. :+1:

+1


Bug Fix: Retrieving photos directly in client side not showing.

What is the feature?

Add delay in retrieving photos form Google to avoid QUERY_LIMIT.
Photos displaying are implemented in Frontend.

How to test?

Go to homepage and search to place details and place nearby page.
Cannot know does it work until deployed. because it was a problem with Google API restriction which urls are thirepose.com

Codecov Report

Merging #105 (cb5324d) into beta (4c2b611) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             beta     #105   +/-   ##
=======================================
  Coverage   69.71%   69.71%
=======================================
  Files          25       25
  Lines        1027     1027
  Branches      135      135
=======================================
  Hits          716      716
  Misses        286      286
  Partials       25       25

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c2b611...cb5324d. Read the comment docs.


About the sharpening training trick?

Hi there.
Could you mind sharing the detailed sharpening trick when training the Real-ESRGAN+ model? Or, any hint on this trick?
Thanks.

+1

+1

As far as I understood it, they are applying unsharp-masking to the ground truth image to effectively create a sharpened image set.


Add RDAP for .nl

2023-01-31: https://www.sidn.nl/en/news-and-blogs/full-rdap-service-soon-mandatory-for-generic-top-level-domains

Because we act as the technical operator of the .amsterdam and .politie domains – gTLDs that do fall under ICANN's auspices – we introduced preliminary RDAP services for the 2 zones 3 years ago. For the .nl domain, RDAP beta is now available at rdap.sidn.nl.

This is done.


Indicate git commit that is currently running

E.g. on the landing page, in some corner, just say "frontscope 4b8dc4" or something like that in small print.

In fact, the commit is planned to go into the URL for alpha, so marking the milestone accordingly.

Specifically, the plan for this issue is just to rely on the commit showing up in the URL.


Add e2e testing

Codecov Report

Merging #51 (9e30cf5) into main (b54e3d0) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #51   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            5         5
  Lines          296       296
=========================================
  Hits           296       296

Flag
Coverage Δ

unittests
100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b54e3d0...9e30cf5. Read the comment docs.


Test Server: Selecting multiple images from query results is very slow

Might be related to the load order. If you have a query with multiple results and want to load multiple images, using the tick boxes is very slow as the images start loading in as you select them. It would be much faster if you could select all the images from the query results and then load them it would be much faster, even if you had to wait after they are all selected.
Support info:
Fri May 29 2020 11:01:24 GMT 0100 (British Summer Time)
Chrome 81.0.4044.138 [1381,756]
https://v2a.virtualflybrain.org/org.geppetto.frontend/geppetto?id=VFB_00101567&i=VFB_00101567,VFB_00102275
+ Buffered 18000 tiles
+ Buffered 18000 tiles
+ Buffered 18000 tiles
+ Buffered 18000 tiles
+ Buffered 18000 tiles
+ Buffered 18000 tiles
+ Buffered 18000 tiles
+ Buffered 18000 tiles
+ Buffered 18000 tiles
+ Buffered 18000 tiles

@ddelpiano The loading spinner (on the tickbox) has disappeared at some point?


[web]: DropdownButtonFormField is not updated

Hi!
I have a DropdownButtonFormField that displays a value of a Consumer:
Consumer<CalendarDataSource>(
builder: (context, calendarDataSource, _) => DropdownButtonFormField<int>(
     value: calendarDataSource.stepsInMinutes,
     onChanged: (int minutes) {
          calendarDataSource.stepsInMinutes = minutes;
     },

If "calendarDataSource.stepsInMinutes" is changed, it runs "notifyListener()":
this.stepsInMinutes = json["blocksize"];
print("Steps loaded: $stepsInMinutes");
notifyListeners();

Using log output I can see in the console that the value was correctly set, after initState has finished. Then "build" was called again:
initState finished
build
Steps loaded: 30
build
However "DropdownButtonFormField" still shows the old value (60) until I scroll down (so that the DropdownButtonFormField moves out of the screen at the top of the screen) and then scroll up again (so that DropdownButtonFormField becomes visible from the top again). Then DropdownButtonFormField displays the correct value (30).
flutter doctor output:
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel beta, v1.17.0-3.2.pre, on Linux, locale en_US.UTF-8)
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
[✓] Chrome - develop for the web
[✓] Android Studio (version 3.6)
[✓] Connected device (2 available)
• No issues found!

Hi @dg76
This platform is not meant for assistance on personal code. Please see https://flutter.dev/community for resources and asking questions like this, you may also get some help if you post it on Stack Overflow. Closing, as this isn't an issue with Flutter itself,
if you disagree please write in the comments and I will reopen it
Thank you

Hi @TahaTesser,
why do you think this is "assistance" on personal code? This is a bug in flutter for web! The same code works fine when I run it as an app. Can you please tell me which part was unclear so that I can tell you more about it?

Hi @TahaTesser,
the bug in flutter for web is that the DropdownButtonFormField is not updated. If I run the same code as an app instead of in the browser, I can see that the content of the DropdownButtonFormField correctly changed from 60 to 30 after "notifyListeners" has been called.
Do you agree that this has to be a bug in flutter for web?

I can see now how my post was misunderstandable. Should I post it again as a new issue to make it more clear?

Sorry, I think I understand now that my code was wrong, DropdownButtonFormField has its own internal value and does not react to changes of "value". That it worked in the app was probably a side effect of something else being updated. You can keep this issue closed. Sorry for wasting your time!


Reorder sections

I found it weird that the "contact us" and "sharing" stuff was within the "List of pledging companies" section... I moved both of those below the section instead. Here's what it looks like now:

Our concern was that as the pledgee list grows, contact us gets too far down; also, we wanted share to be an easy call to action before the list.

Our concern was that as the pledgee list grows, contact us gets too far down; also, we wanted share to be an easy call to action before the list.

If/when that becomes a problem, we could make it a collapsible list?

Makes sense!


Remove repeating arguments processing in IncrementalBuilder creation

Fixes #4039.

@forki Yep, a pleasant way to fix anything. I cannot say it was actually broken anyways. :)


Update switch.json

Correct structure:
"properties": {
    "properties": {

Examples from other definitions:

https://github.com/wintercms/vscode-extension/blob/b6fa839f57438a7a40dedf82f367fcd95262538d/schema/fields/types/balloon-selector.json#L10-L11
https://github.com/wintercms/vscode-extension/blob/b6fa839f57438a7a40dedf82f367fcd95262538d/schema/fields/types/checkboxlist.json#L10-L11

Also removed an unnecessary single quote from:
"title": "'On' label'",

@WebVPF is this a mistake?

@AIC-BV I've added a description.
before:
{
},
"properties": {
        "on": {

after:
{
},
"properties": {
    "properties": {
        "on": {

Oh I see! 🫣
Nice 🥳

Thanks for the work you're putting into this, @WebVPF - much appreciated! :)


Allow custom CLI flags to be passed

Describe the feature
I recently found that a CLI flag --dapr-listen-addresses is not supported by dapr sidekick. I think it would be useful to allow custom flags to be specified to work around delays in implementing configuration options. Maybe options.Sidekick.AdditionalArguments?
I logged the specific --dapr-listen-addresses issue as #55.
Release Note

RELEASE NOTE:

I don't know how I missed CustomArguments, never mind!

No worries Liam, thanks for your interest in Sidekick!


Fix demo Podfile to pin eDistantObject to 0.9.0

Resolves https://github.com/google/EarlGrey/issues/1192

Thanks @adamhowardprice


Make sessiontracker use thread-safe constructs

This makes the session tracker use thread-safe constructs for storing and accessing the session ID to users and the PID to Remote User Login maps.
To do this, I created a generic map structure that locks it's contents with a mutex for safe concurrent access.
In order to test this further, Added more thorough testing and documentation to TestSessionTracker_AuditdEvent_ExistingSession_Ended which seemed like a relevant function to verify.
Since the session tracker can now be parallelized, the TestSessionTracker_AuditdEvent_NoSessionID test was marked and modified as such.

Making the map thread safe looks good. The only thing that might cause issues as the code base grows is modifications to the *user. If two go routines are trying to modify the same *user there may be side effects. The assumption currently is the sessiontracker code gets called in a synchronous manner from the for/select statement in auditd.go
Good comments on the common genericsyncmap iterate func.


Integrate INA226 with PX4

Describe problem solved by the proposed pull request
Support for the INA226 I2C power monitor was added in #11755. This PR changes that driver to publish as a battery_status uORB topic instead of a separate power_monitor topic.
This is marked as a draft because it depends upon #12551
Test data / coverage
The INA226 was connected to a Pixhawk 4, and the listener command was used to verify that the correct information is published. Next, 2 INA226's were connected to the Pixhawk 4: One to I2C A, and one to UART & I2C B. The driver was started for each port, with different battery configuration parameters. This was again checked using listener.

@ItsTimmy After some advice here from you. We don't have any standalone docs on any power monitors/power modules - though we do have some as part of vehicle build logs and mentioning how to power a vehicle in the flight controller assembly quickstarts.
So:

"do we need to add information about power module/monitor" peripherals as a sub topic of http://docs.px4.io/master/en/peripherals/?

I'm guessing this might cover information like what controllers it can work with, whether it provides both voltage and current, or just voltage. What else it provides. Ratings for systems it can be used with etc etc (advice hoped for!)

Ideally each module and/or driver should have docs, which generate to here: https://dev.px4.io/master/en/middleware/modules_driver.html  - Worth doing that for this driver?

@hamishwillee

Yes, I think it is worthwhile to have information about peripherals. For example, the INA226 board I am using can only be plugged into the Pixhawk 4 through a Skynode, which is not immediately obvious without documentation. Also, the specifications (measurement capabilities and maximum ratings) would be good to have written down.

Yes, I think it is worth documenting this driver. I can do that today!

Just a reminder ^^^ https://github.com/PX4/Firmware/pull/12673#issuecomment-520275805

@hamishwillee Who should I talk to about documenting the capabilities of different hardware?

Open question for anyone who has an idea: How should this module be started? Right now it must be started manually, with the command ina226 start -b 1 -t 1 pr ina226 start -b 2 -t 2. But on boards where this power module is the default, it should start automatically.

But on boards where this power module is the default, it should start automatically.

Parameter?

Who should I talk to about documenting the capabilities of different hardware?

Me.
We've started adding power module docs under here: http://docs.px4.io/master/en/power_module/
Early days, but so far the "evolving standard" is that a power module has specs/limits, screenshots, purchase links, wiring diagrams (or links to). Probably should also include links to module docs like the ones you created for this too, and instructions on "how to enable driver".
Very happy to get your thoughts on what else might be needed.

@julianoes I have removed the commented code. @dinomani has tested it in flight


cant open gui

when i press key to open gui it dosent open or do anything

how did u get it to work?


fix #1078

closes #1078
@whoburg, ready for review

@mjburton11, this is merged now, you can get the solution array from an autosweep


feat: assign a version number at compile time

Use compile time assignment capabilities to set the version number to avoid changing the code every time a new version is released
#187

@jakezhu9 request to your review


ReactImageView: Image source "null" doesn't exist

VideoPlayer keeps on throwing console.warn saying that ReactImageView: Image source "null" doesn't exist.
It does so when

poster prop is not used
poster props contains link

When i pass string "test", it says ReactImageView: Image source "test" doesn't exist.
However, the poster is displayed correctly.

@Michota nice catch, I'll be looking into it, however I think it's an issue with react-native-video since we didn't implement the poster ourselves, but it's implemented inside react-native-video

When I use the <Video/> from react-native-video it does not throw a warn.

@Michota We also encountered this issue, but it seems fixed. The only thing that we did was to update react-native-video to latest.
Can you tell me what version are you using? Does it still reproduce on the latest version?


Does not support dynamic type

Larastan Version: v0.2.4
--level used: default

Description:
Parameter #1 ...$patterns of method Illuminate\Http\Request::is() expects Illuminate\Http\dynamic, string given.

I have this helper function:
/**
 * Check if navigation item active.
 *
 * @param  string $path
 * @param  bool   $wildcard
 * @return string
 */
function isNavItemActive($path, $wildcard = false)
{
    if ($wildcard) {
        $path .= '*';
    }

    return request()->is($path) ? 'true' : 'false';
}

Laravel code where the issue was found:
/**
 * Determine if the current request URI matches a pattern.
 *
 * @param  dynamic  $patterns
 * @return bool
 */
public function is(...$patterns)
{
    foreach ($patterns as $pattern) {
        if (Str::is($pattern, $this->decodedPath())) {
            return true;
        }
    }

    return false;
}

BTW: This will be possible to solve in a clean way in PHPStan 0.10.3 with PHPStan\PhpDoc\TypeNodeResolverExtension.

Laravel is the ONLY PHP basecode that uses dynamic instead of mixed. IMHO that must be fixed there, not supporting it.

@deleugpn is correct that this is a Laravel issue, rather than Laravel magic...
It's fine though ,it's in the process of being fixed, this was merged 4 days ago :) https://github.com/laravel/framework/pull/26164

@phh Could you try with laravel master?

Have not gotten the error since I posted this issues, so closing.

Sorry to reopen old issue, but since it's related I thought it might be better than to open a new one.
 133    Function cache invoked with 1 parameter, 0 required.
 160    Function cache invoked with 2 parameters, 0 required.

There is a dynamic definition for the cache helper
 * @param  dynamic  key|key,default|data,expiration|null

 * @return mixed|\Illuminate\Cache\CacheManager

Which side would be the best place to fix something liket his?

Please consider opening a new issue.
https://github.com/laravel/framework/blob/db794ceea6734cc90286e04a8a2a48e5b4cd4130/src/Illuminate/Foundation/helpers.php#L225-L235


Fix description how to start examples without docker

I tried the instructions in the README.md to start the examples without docker, and the url http://localhost:8080/webpack-dev-server/ doesn't work when the example start.
It works though with http://localhost:8080/.
I suggest anyway to only use docker, and make sure the examples can be run with the published version in npm, and optionally with the repository itself for development purposes

I am also noticing that the examples pages are not working properly. There are crashes happening.

This is no longer needed given 6.0.0 removes the docker example. We could put it in somehow. Feel free to open another ticket there.
6.0.0 is released on npm beta tag now. See the changelog here. We also have a new demo page. Feel free to try it:
https://tomchentw.github.io/react-google-maps/


Translationunittests

Working Base Unit tests as well as moved complete validation rules ready for ajax on this branch.

Not merged in due to being behind dev


Document that concatenation is enabled by default

I recently tried to add new webpack.optimize.ModuleConcatenationPlugin(); to my webpack build and was very surprised that it had no effect. [It took me a while](new webpack.optimize.ModuleConcatenationPlugin()
https://github.com/aurelia/webpack-plugin/issues/153#issuecomment-420376814) to realize that it is auto-enabled by default in production.
I’ve added a corresponding note to prevent others from making the same mistake.

@rluba Friendly ping

@montogeek Thanks for the ping. I’ve updated the wording.

@EugeneHlushko Please take another look

Thanks!


Adding a variable for minio-service endpoint

The issue resolved by this Pull Request:
Resolves https://github.com/opendatahub-io/data-science-pipelines-operator/issues/375
Description of your changes:

Replacing hardcode references to minio-service endpoints with an environment variable.
Testing instructions

Build an image with changes in this PR. This is the image I built with these changes: quay.io/rhn_support_ddalvi/data-science-pipelines-operator:minio-revised
Deploy DSPO and create a DSPA instance
Make sure minio pod comes up correctly
Create a run using the default pipeline to make sure it goes through correctly.

Checklist

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-479
An OCP cluster where you are logged in as cluster admin is required.
To use this image run the following:
cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/479/head
git checkout -b pullrequest 89fb58911d701a1ff99da72cfbe74b5ab85aebd2
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-479"

More instructions here on how to deploy and test a Data Science Pipelines Application.

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-479

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-479


tsc --init --target es2015 generates es6 tsconfig.json

Bug Report
When running tsc --init --target es2015, the generated target is es6.
{
  "compilerOptions": {
    /* Visit https://aka.ms/tsconfig.json to read more about this file */

    /* Basic Options */
    // "incremental": true,                         /* Enable incremental compilation */
    "target": "es6"                                 /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', 'ES2018', 'ES2019', 'ES2020', or 'ESNEXT'. */
}

This is unfortunate as the generated file looks as if it was having an invalid option.
🔎 Search Terms
tsc init es2015 es6
🕗 Version & Regression Information
I'm using tsc 4.2.4, and replicated with tsc 4.4.0-dev.20210518

I was unable to test this on prior versions because I don't think this is an actual regression. I found b871b5353c8a9ca6dedd6bc84706fd75ed86bae4, and I suspect that this is a left-over.

🙁 Actual behavior
{
  "compilerOptions": {
    "target": "es6"                                 /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', 'ES2018', 'ES2019', 'ES2020', or 'ESNEXT'. */
}

🙂 Expected behavior
{
  "compilerOptions": {
    "target": "es2015"                                 /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', 'ES2018', 'ES2019', 'ES2020', or 'ESNEXT'. */
}

These are interchangeable and it doesn't matter which you put here. Would be OK with a PR if it's not too complicated.


PP-10863 Appropriate attributes for 2FA OTP inputs

For inputs where we expect the user to provide a second-factor authentication one-time password (security code), consistently use type="text", inputmode="numeric" and pattern="[0+9]+" (as recommended by the GOV.UK Design System for non-decimal numbers), along with autocomplete="one-time-code".
Previously we used autocomplete="off" in some places. Switching to autocomplete="one-time-code" may cause browsers to suggest old OTPs where they did not before but this is a fairly minor issue.

Closing in favour of #3901.


feat: 🎸 register custom claim type

Description
Adds necessary changes to be able to register a CustomClaim
Fixes bug with not being able to revoke claim issued by the same did.
JIRA Link
https://polymesh.atlassian.net/browse/DA-895
Checklist

[x] Updated the Readme.md (if required) ?

:tada: This PR is included in version 23.0.0-alpha.21 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


fn: clean docker retry logic and legacy code

Cleanup of docker retry error handling logic. The code
is likely due to older less stable docker versions. Instead,
we would like to expose any underlying issues and fix them
as necessary.
Examination of logs/events from last 3-4 weeks do not
show any occurrence of retries/errors and on the contrary
causing more issues (eg. retry of docker-pull if 5xx)

Thanks for making these changes.  I'm inclined to take them, since I think it lets us remove a number of cases that were causing us to send a lot of traffic to registry servers when we encountered an error.  I realize that this may not be entirely appealing to @rdallman, however it appears that docker has become a bit more reliable.  We spent a bunch of time digging through our own logs and only saw 500s and timeouts in response to other upstream errors.  IOW, not from dockerd and not from problems on the host.  This does mean that we have the potential to re-introduce problems that were fixed by the retry logic.  That said, I think @skinowski and I would volunteer to chase these down individually as they re-appear.

Risk here is we might need to reintroduce some of this code back. But I think it's good to start from blank slate especially if we are agreeing to chase issues down operationally.

i found the opposite approach to be more appealing, specifically since it ends up in user errors, for when errors that shouldn't be retried come up to whitelist them to not - cognitively, the exact same burden commitment. wholesale getting rid of this seems not ideal and making it more conservative seems reasonable, but hey, what do i know, i only dealt with customers after running billions of containers with this code... we're only in LA, we're playing a probability game with docker errors and when customers actually go prod the probabilities will show... y'all have fun

we'll work on 'we' usage meanwhile

@rdallman The probabilities is precisely why it makes sense to track down the errors that necessitated retries in the past.  As a general rule, adding retries to the code just causes it to run slower and paper over existing problems.  If engineers can find the cases that shouldn't be occurring, and get them fixed then both our product and the upstream container technology become more reliable.  If instead the code continues to simply retry, then there's no forward progress on making docker or the product more stable.  If in this process, analysis turns up a case where a retry is warranted then you can have the satisfaction of saying that you told me so.

2 years of logs man, anything in the code that has an exception is from that. it's not about you and me buddy. i know i'm not up to your human standards, and i'm deeply sorry that you have to interact with me.

As reference, although the workloads are different, k8s or docker-client do not have retries.


ARROW-173 Support PyArrow 12.0

I put the changelog entry in https://github.com/mongodb-labs/mongo-arrow/pull/161 to avoid conflicts.


Allow separate decoders

Summary
Closes #589.
Allows one to specify separate decoders for interim and final results.
Details and comments
Fixes #

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

-1 of 18 (94.44%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.6%) to 64.313%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

qiskit_ibm_runtime/runtime_job.py
9
10
90.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.6%

Covered Lines:
3406

Relevant Lines:
5296

💛  - Coveralls


Vale sometimes fails to run, complaining of non-existent files

Description

@stacimc and I have both run into this issue in different ways. Here is Staci's example output of the error:
docker run --rm -v $PWD/..:/src:rw,Z --workdir=/src openverse-vale:local . --glob='!*{_build,_static,venv,.venv,.nuxt,.pnpm-store,node_modules,test-results,storebook-static,.ruff-cache,projects/proposals,changelogs/api,changelogs/frontend,changelogs/catalog,changelogs/ingestion_server}*'
stat venv/bin/python: no such file or directory
error: Recipe `run` failed on line 64 with exit code 2

I had the same error mode, but the file was src/static/node_modules/sharp (I'd created a node_modules folder in frontend/src/static when working on #3724). I was able to resolve the issue for me locally by deleting that directory, and didn't think anything much of it because I'd done something rather unusual, and I didn't think it would affect normal usage. However, it appears to indeed affect normal usage, as now Staci is running into the same problem.
Something tricky about it, however, is that we can't easily tell where the file causing the issue is, because Vale's message cuts off the first directory!
Reproduction

Not sure how to reproduce at the moment. I tried recreating the issue I had locally, but wasn't able to reproduce it.
Additional context
Marked high because it interrupts local development workflows.

I'll attempt to look at this this week. I want to learn more about how Vale works anyway; perhaps in my stumbling around I'll trigger this issue :laughing:

I hope you can discover the cause. I have a feeling it will be a bug in Vale we can open an issue for as well as something to do with docker bind mounts and symlinks to files outside the bind mount scope (which Docker cannot traverse).
If you haven't tried it yet, I'd suggest creating a symlink to something outside the Openverse directory. It might be able to reproduce the issue.

I didn't get to spend quite as much time on this as I would have liked, but I can confirm that it's easily reproducible using an approach similar to @sarayourfriend's initial problem:
# Copy a directory with symlinks into somewhere it doesn't belong
cp -r node_modules frontend/src/static
# Run vale
bash -c 'just .vale/run'
# Output
stat frontend/src/static/node_modules/@openverse/eslint-plugin: no such file or directory
error: Recipe `run` failed on line 64 with exit code 2

Next, I installed a Vale 2.30.0 binary locally and converted our justfile, dockerized vale config into a command I could run locally, for easier debugging (I also had to vale sync to install proselint):
vale --output=line --minAlertLevel=suggestion --config=./.vale.ini --ext=.md --glob='!*{_build,_static,venv,.venv,.nuxt,.pnpm-store,node_modules,test-results,storebook-static,.ruff-cache,projects/proposals,changelogs/api,changelogs/frontend,changelogs/catalog,changelogs/ingestion_server}*' .

From here, I was able to reproduce the error with the local binary:
❯ vale --output=line --minAlertLevel=suggestion --config=./.vale/.vale.ini --ext=.md --glob='!*{_build,_static,venv,.venv,.nuxt,.pnpm-store,node_modules,test-results,storebook-static,.ruff-cache,projects/proposals,changelogs/api,changelogs/frontend,changelogs/catalog,changelogs/ingestion_server}*' .
stat frontend/src/static/node_modules/@openverse/eslint-plugin: no such file or directory

I confirmed that this is a broken symlink:
❯ ls -la frontend/src/static/node_modules/@openverse
total 56
drwxr-xr-x  2 zack zack  4096 Mar  1 16:53 .
drwxr-xr-x 68 zack zack 49152 Mar  1 16:53 ..
lrwxrwxrwx  1 zack zack    28 Mar  1 16:53 eslint-plugin -> ../../packages/eslint-plugin

Next, I tested Vale 3.x to see if the problem would magically go away. It didn't. :smile:
Finally, I tried to isolate the problem file with different glob patterns. I got the same original error every time regardless of what pattern I used or if a --glob flag was present at all!
Sadly, I had to stop here! I want to look into the actual code more, starting here:
https://github.com/errata-ai/vale/blob/3d92f00671a22bd9616f3b4242ca8f5a793c29b9/internal/glob/glob.go

Success! Taking an approach of building a list of files for the input of Vale, rather than using their globbing, worked well! For example:
openverse on  refactor/combine-related-media [$!?] via ⬢ v18.19.1 via 🐍 v3.11.2 on ☁  (us-east-2)
❯ vale --output=line --minAlertLevel=suggestion --config=./.vale/.vale.ini $(find . -type f | grep -vE '_build|_static|venv|.venv|.nuxt|.pnpm-store|node_modules|test-results|storebook-static|.ruff-cache|projects/proposals|changelogs/api|changelogs/frontend|changelogs/catalog|changelogs/ingestion_server')

frontend/README.md:3:1:Openverse.TermCasing:Incorrect casing. Use 'Openverse' instead of 'OpenVerse'. # <-- This is an edit I made so I could confirm there's a Vale output

So essentially, if we update our Justfile with a step to build a file list to pass to Vale (unless the user has explicitly passed files, in which case we should use those), we should be able to prevent this problem.


add a cron-like systemd::timer interface

I'm looking at converting my cron resources into a systemd::timer but the interface to that resources is rather unwieldy. It assumes prior and rather intricate knowledge of the format of systemd unit files and makes the cron resource look extremely intuitive and fun in comparison (which is not a compliment).
I think there's room for "cron-like" timer interface. We're not talking about reinventing the wheel here, probably just a little template will do. An interface such as:
define systemd::unit::job(
    $command,
    $user => root,
    $interval => # [...] that is of course the hard part
) {

    systemd::timer { $name:
        # ....
    }
}

Wikimedia operations people actually did this in their own systemd module which, strangely, is not related to this module but shares a lot of the interfaces, see their systemd::timer::job resource. It does a lot more than just create a timer though: it includes things like logging, monitoring and so on, probably not something we want to merge as-is just now. I mostly cite it as an example of how things could be done.
It makes conversions much easier, here's a patch of one conversion. I particularly like the > /dev/null 2>&1 removal, personally. :)
I mostly open this to get feedback, I'm likely going to implement this on our side anyway, but I figured it could be useful for folks here if I send it as a PR instead of just our secret sauce. See our internal ticket as well.

@anarcat I think its a good idea.
Indeed95% of cron jobs are

run X
daily, weekly or   every 2 minutes.
run as user Y
Maybe some random component.

Maybe this should be an interface in https://github.com/voxpupuli/puppet-cron -probably not.

I did write systemd::timer a while back, but what you're suggesting sounds like adding a systemd::manage_unit style layer on top. That sounds useful to me.
As reference: this was the original reason I wanted the systemd::timer resource: https://github.com/theforeman/puppet-puppet/blob/master/manifests/agent/service/systemd.pp. As you can see, https://github.com/theforeman/puppet-puppet/blob/b08528470b9a95ba659f308ca2cafc6bec084c37/templates/agent/systemd.puppet-run.timer.erb#L8 isn't really a complete implementation of the cron spec.
Perhaps it makes sense to write a cron2timer() function and leave it up to the end user to combine the two?

Maybe this should be an interface in https://github.com/voxpupuli/puppet-cron -probably not.

i would rather not. i would like to eventually remove that module if we stop using cron altogether, and putting the shim there would make that difficult.
thinking about this more: i think we should have a straight out compatibility shim in there. and yes, systemd doesn't provide the exact same interface, but we can let the user shoot themselves in the foot there, i think.
i would do a systemd::timer::cron define that would match the cron interface and shove that in a OnCalendar thing and call it a day, to be honest. that would sweep a lot under the rug (like syntax differences between OnCalendar and cron, email notifications and so on), but that's things i expect people would handle during the conversion. we could even have docstrings pointing out those caveats...

I did create a MR as a proposal. I have been maintaining and using https://github.com/TheMeier/themeier-systemd_cron for years. This is an adaption of this module to fit inside puppet-systemd and make mine obsoletet :smile:


reinstall-packages-from-version is wanted

reinstall-packages-from-version is wanted
switching node version needs reinstallation of all packages in the most case

Totally agree. Coming from NVM on the Mac this is a must have 👍

This won't be added, but there is a proposal for a way to accomplish this at the discretion of the developer.
Why Not?
NVM4W and nvm have a similar name (a retrospective mistake on my part), and both are capable of switching versions. That's where the similarities end (NVM4W is philosophically more aligned with n). nvm for macOS enforces a workflow on the developer. NVM4W provides a more minimalistic approach, focusing on node version management, not npm management. NVM4W leaves workflow customization to the end user... because a) it's not hard, and b) it's very opinionated.
The statement "switching node version needs reinstallation of all packages in most cases" is unsubstantiated. This doesn't mean it's not true, but there aren't any stats to back this claim. There are plenty of use cases where this is not the case, such as developing original modules with forward/backwards compatibility.
Third, automating this process, either forcibly or by default, has a number of unintended consequences in a Windows environment. See the Roaming Profiles use case for an example.
Even if this were a non-default optional command, it still strays from node version management into npm management. This is an entirely different problem (and a much bigger problem).
How will this be accomplished if no feature is added to NVM4W?
There's a proposal to add hooks (similar to git-commit hooks). This would be an optional feature allowing developers to do whatever they want in a shell script/batch file. So, providing a hook like nvm-postinstall could easily accomplish this. This approach allows developers who want to reinstall packages to do so, without forcing this on people who don't.
That said, I recognize there are very popular approaches to managing the overall node environment. Using the hooks approach, I'm hoping to maintain a user-contributed repo of popular hook scripts.
All of this stuff will be coming in the next version, under a distinct new name, and it will be cross-platform. I have no ETA, as this falls to number 2 in my priority list, behind release of Fenix 3.0.0.


Add an RFC for enumeration type safety.

Rendered: https://github.com/wanda-phi/rfcs/blob/enum-type-safety/text/0031-enumeration-type-safety.md
Original issue: amaranth-lang/amaranth#778

We have discussed this RFC on the 2023-11-27 weekly meeting. The disposition was to merge.


Release notes: remove duplicate item, correct Marathon release notes link

About https://dcos.io/releases/1.7.0/:

The point "Distributed DNS Server to enable highly available DNS deployment for service discovery and service availability" is listed under two sections, "Improved DC/OS installation" as well as "DC/OS Networking". It must be removed from "Improved DC/OS installation".

The link to Marathon release notes needs to be updated.
It's currently https://github.com/mesosphere/marathon/releases/edit/v1.0.0-RC1, note the edit. It should probably be https://github.com/mesosphere/marathon/releases. @aquamatthias please confirm.

Fix is awaiting merge: https://github.com/dcos/dcos-website/pull/668

the marathon link is merged. was there another one for the duplicate item, @joel-hamill ?

@karlkfi @jgehrcke I don't see any duplicate bullet for Distributed DNS. https://dcos.io/releases/1.7.0/

@joel-hamill the duplicate item has been covered by beautiful @adam-mesos in https://github.com/dcos/dcos-website/pull/665 :)

Great. Closing this out then


Fix #412: Add a Python types stub file. Update to Py03 v0.21.2

Fix for #412

Add a types stub file for the Python package
Update and migrate to Py03 0.21.2

All the test files now lint correctly with Pylance in VSCode. 🎉

👍 Thanks for this, that's amazing!
I reorganized your commits and started the build but this looks good to merge when the CI will be ok with it.

Great! Thanks for the merge. I think the doc strings leave some room for improvement, but good enough for now.


contract batch send transaction

Codecov Report

Merging #184 into master will decrease coverage by 0.47%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##             master     #184      +/-   ##
============================================
- Coverage     87.39%   86.91%   -0.48%
- Complexity      729      731       +2
============================================
  Files            47       47
  Lines          1594     1597       +3
============================================
- Hits           1393     1388       -5
- Misses          201      209       +8

Impacted Files
Coverage Δ
Complexity Δ

src/Contract.php
75.63% <66.66%> (-0.30%)
160.00 <2.00> (+2.00)
:arrow_down:

src/Validators/FilterValidator.php
92.59% <0.00%> (-7.41%)
22.00% <0.00%> (ø%)

src/Validators/ShhFilterValidator.php
88.23% <0.00%> (-5.89%)
12.00% <0.00%> (ø%)

src/RequestManagers/HttpRequestManager.php
75.67% <0.00%> (-3.28%)
12.00% <0.00%> (ø%)

src/Methods/EthMethod.php
85.36% <0.00%> (-2.44%)
22.00% <0.00%> (ø%)

src/Utils.php
93.84% <0.00%> (-0.52%)
86.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d69ce96...a47544b. Read the comment docs.


[Snyk] Upgrade @aws-sdk/client-s3 from 3.427.0 to 3.431.0

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade @aws-sdk/client-s3 from 3.427.0 to 3.431.0.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 4 versions ahead of your current version.
The recommended version was released 21 days ago, on 2023-10-18.

Release notes

Package name: @aws-sdk/client-s3

3.431.0 - 2023-10-183.431.0(2023-10-18)
Chores

codegen for awsExpectUnion (#5376) (ba28b4f2)
deps-dev:  bump aws-crt to ^1.18.1 (#5377) (54bc478c)

Documentation Changes

client-cloud9:  Update to imageId parameter behavior and dates updated. (37282cba)
client-dynamodb:  Updating descriptions for several APIs. (2320e504)

New Features

clients:  update client endpoints as of 2023-10-18 (f985cbf0)
client-kendra:  Changes for a new feature in Amazon Kendra's Query API to Collapse/Expand query results (92b6b265)
client-rds:  This release adds support for upgrading the storage file system configuration on the DB instance using a blue/green deployment or a read replica. (dbac71a6)
client-wisdom:  This release adds an max limit of 25 recommendation ids for NotifyRecommendationsReceived API. (12f6be4f)

Tests

middleware-host-header:  add test for :authority header in integ test (#5374) (3f121a1a)

For list of updated packages, view updated-packages.md in assets-3.431.0.zip

3.430.0 - 2023-10-173.430.0(2023-10-17)
Chores

core:  add awsExpectUnion function (#5367) (51f316ea)
codegen:  codegen sync (#5371) (9fa7bfe2)

Documentation Changes

client-ecs:  Documentation only updates to address Amazon ECS tickets. (9a3a3f69)

New Features

clients:  update client endpoints as of 2023-10-17 (13c7b744)
client-route53-recovery-cluster:  Adds Owner field to ListRoutingControls API. (375efbf1)
client-route53-recovery-control-config:  Adds permissions for GetResourcePolicy to support returning details about AWS Resource Access Manager resource policies for shared resources. (81747e43)
client-application-discovery-service:  This release introduces three new APIs: StartBatchDeleteConfigurationTask, DescribeBatchDeleteConfigurationTask, and BatchDeleteAgents. (c5617b08)
client-kafka:  AWS Managed Streaming for Kafka is launching MSK Replicator, a new feature that enables customers to reliably replicate data across Amazon MSK clusters in same or different AWS regions. You can now use SDK to create, list, describe, delete, update, and manage tags of MSK Replicators. (db53ab12)
client-global-accelerator:  Fixed error where ListCustomRoutingEndpointGroups did not have a paginator (7d309f30)
client-guardduty:  Add domainWithSuffix finding field to dnsRequestAction (f1a4256c)
client-codepipeline:  Add retryMode ALL_ACTIONS to RetryStageExecution API that retries a failed stage starting from first action in the stage (9d179e84)

For list of updated packages, view updated-packages.md in assets-3.430.0.zip

3.429.0 - 2023-10-163.429.0(2023-10-16)
Chores

core:  add core package (#5351) (c3613783)
codegen:  update smithy commit to closed enums (#5356) (7d312220)

Documentation Changes

client-transfer:  Documentation updates for AWS Transfer Family (83809a24)

New Features

clients:  update client endpoints as of 2023-10-16 (d71d1991)
client-entityresolution:  This launch expands our matching techniques to include provider-based matching to help customer match, link, and enhance records with minimal data movement. With data service providers, we have removed the need for customers to build bespoke integrations,. (ba8b3ef5)
client-mediapackagev2:  This release allows customers to manage MediaPackage v2 resource using CloudFormation. (8a890095)
client-redshift:  Added support for managing credentials of provisioned cluster admin using AWS Secrets Manager. (81f66cb1)
client-sesv2:  This release provides enhanced visibility into your SES identity verification status. This will offer you more actionable insights, enabling you to promptly address any verification-related issues. (95a88278)
client-redshift-serverless:  Added support for managing credentials of serverless namespace admin using AWS Secrets Manager. (00b6795c)
client-opensearch:  This release allows customers to list and associate optional plugin packages with compatible Amazon OpenSearch Service clusters for enhanced functionality. (90dcb197)
client-cloudformation:  SDK and documentation updates for UpdateReplacePolicy (c1fd48ee)
client-drs:  Updated exsiting API to allow AWS Elastic Disaster Recovery support of launching recovery into existing EC2 instances. (d861f676)
client-xray:  This releases enhances GetTraceSummaries API to support new TimeRangeType Service to query trace summaries by segment end time. (8da8457b)
client-managedblockchain-query:  This release introduces two new APIs: GetAssetContract and ListAssetContracts. This release also adds support for Bitcoin Testnet. (6dc7cd7a)

Bug Fixes

middleware-host-header:  populate :authority pseudo-header with authority section of target URI (#5369) (242a32c5)
lib-dynamodb:  backwards compat for undefined columns (#5365) (65d5b36f)

Tests

middleware-eventstream:  fix integ test typing (#5370) (a7ebbf9a)
client-s3:  update S3.ispec.ts (#5343) (f05d9c61)
middleware-sdk-s3:  increase timeout in E2E test (#5353) (5a816f94)
lib-dynamodb:  use consistent read in e2e tests (#5352) (fc15e055)

For list of updated packages, view updated-packages.md in assets-3.429.0.zip

3.428.0 - 2023-10-123.428.0(2023-10-12)
Chores

read service specific endpoints from env/config (#5350) (39126a49)
update bug-report.yml (#5314) (d0978841)
middleware-flexible-checksums:  split FlexibleChecksumsMiddlewareConfig into request/response (#5344) (78a50c93)
util-endpoints:  remove utility to read service specific endpoints (#5341) (bde7d54c)
clients:  support reading ini subsections and get entire config in configSelector (#5330) (1ccfce17)

Documentation Changes

client-pricing:  Documentation updates for Price List (ec57e773)
client-elastic-load-balancing-v2:  This release enables routing policies with Availability Zone affinity for Network Load Balancers. (8368f0f6)
client-workspaces:  Updated the CreateWorkspaces action documentation to clarify that the PCoIP protocol is only available for Windows bundles. (8153a417)
lib-dynamodb:  fix import path for api extractor compatibility (#5336) (7477787e)
update README.md in smithy-aws-typescript (#5316) (7cac08f9)

New Features

clients:  update client endpoints as of 2023-10-12 (34763390)
client-sagemaker:  Amazon SageMaker Canvas adds KendraSettings and DirectDeploySettings support for CanvasAppSettings (685916ce)
client-auditmanager:  This release introduces a new limit to the awsAccounts parameter. When you create or update an assessment, there is now a limit of 200 AWS accounts that can be specified in the assessment scope. (af417648)
client-ivs-realtime:  Update GetParticipant to return additional metadata. (4adb6260)
client-controltower:  Added new EnabledControl resource details to ListEnabledControls API and added new GetEnabledControl API. (784c6fb6)
client-rekognition:  Amazon Rekognition introduces support for Custom Moderation. This allows the enhancement of accuracy for detect moderation labels operations by creating custom adapters tuned on customer data. (87763f3b)
client-textract:  This release adds 9 new APIs for adapter and adapter version management, 3 new APIs for tagging, and updates AnalyzeDocument and StartDocumentAnalysis API parameters for using adapters. (4ce1e296)
client-location:  This release adds endpoint updates for all AWS Location resource operations. (f71b2162)
client-lambda:  Adds support for Lambda functions to access Dual-Stack subnets over IPv6, via an opt-in flag in CreateFunction and UpdateFunctionConfiguration APIs (2bb63a02)
client-auto-scaling:  Update the NotificationMetadata field to only allow visible ascii characters. Add paginators to DescribeInstanceRefreshes, DescribeLoadBalancers, and DescribeLoadBalancerTargetGroups (67270850)
client-machine-learning:  This release marks Password field as sensitive (4d5eac69)
client-inspector2:  Add MacOs ec2 platform support (2964c2f7)
client-rds:  This release adds support for adding a dedicated log volume to open-source RDS instances. (634a9831)
client-customer-profiles:  Adds sensitive trait to various shapes in Customer Profiles Calculated Attribute API model. (73c92296)
client-glue:  Extending version control support to GitLab and Bitbucket from AWSGlue (b683df3c)
client-config-service:  Add enums for resource types supported by Config (1cdcf430)
client-transcribe:  This release is to enable m4a format to customers (8c24c288)
client-ec2:  This release adds Ubuntu Pro as a supported platform for On-Demand Capacity Reservations and adds support for setting an Amazon Machine Image (AMI) to disabled state. Disabling the AMI makes it private if it was previously shared, and prevents new EC2 instance launches from it. (9c57ae32)

Bug Fixes

middleware-flexible-checksums:  skip checksum validation for s3 whole-object multipart GET (#5345) (6a6a75e6)
lib-dynamodb:  add e2e suite and bug fixes for lib-dynamodb (#5306) (2fe0a883)

Tests

lib-dynamodb:

add timestamp to table name in e2e tests (#5347) (e64bc583)
increase e2e timeout for lib-dynamodb (#5337) (931e3491)

middleware-flexible-checksums:  flexibleChecksumsResponseMiddleware.spec.ts (#5342) (e1db7b10)
add more randomness to bucketNames (#5332) (178aea91)

For list of updated packages, view updated-packages.md in assets-3.428.0.zip

3.427.0 - 2023-10-06 Read more

    from @aws-sdk/client-s3 GitHub release notes

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

pickup manually later -- merge conflict.


Can't get the button to work on S20

Hi,
I have flashed with 1.01pOTA and the switch works fine from HASS but i can't manually turn on / off from the button on the switch itself, have you experienced that ?

Don't have one here too test but will have soon. I'll let you know

Thank you, that would be cool to know, i would have guessed somebody else would have seen this problem if it was there as well known problem so either the HW is different or i did something wrong (which is hard to believe coz i didn't touch the code other than the configs.)

Hey I have a question for you. I now have one here to test. How do you get them open LOL :D

@KmanOz there is a screw underneath the small label on the back of it and then you pry it open.

Looks like this has been a while - however works fine for the S20 I have just flashed with the v1.01pOTA


Fixed issues where output was being discarded or blocking

IO::eof? blocks until the pipe is written to, so shouldn't be used (http://ruby-doc.org/core-2.2.3/IO.html#method-i-eof) - same goes for IO::gets,
Instead we use read_nonblock for each process' pipe and watch for Errno::EOFError. We only want to output complete lines, so that is accounted for using buffers.

Can i know when would this problem be resolved in prod version of foreman? Or, if there is any alternative to run the tasks with ruby gem, would appreciate that suggestion as well.

If you're using bundler then you can use my fork by specifying a git repo (hash syntax with git as the key and the https URL as the value) after the gem name in the Gemfile.

Can I ask how this bug manifests? I don't fully understand the explanation above.
I am investigating the fact that log output when running "rails server" doesn't output everything directly in Foreman's output.

Sorry. I found https://github.com/ddollar/foreman/wiki/Missing-Output now.

Sorry for the long delay but I'm trying to get foreman back into shape with maintenance. Please rebase your PR and reopen it once you do. Thank you!

@ddollar can you make this patch to land in the main codebase? On Windows, this is still an issue.


Add npm stats badge

Parker brought up a good point that we don't link the README back to npmjs:
https://github.com/patcon/hubot-github-repo-event-notifier/pull/10
cc: @parkr

Is this still necessary?

Prob not :)


ARROW-8513: [Python] Expose Take with Table input in Python

Hi @gramirezespinoza, would you mind creating an Apache JIRA account (free and fast) so that I can assign the issue to you? https://issues.apache.org/jira/secure/Signup!default.jspa Thanks!

Hey, I did open a JIRA account. My username is gire. I'm one of the watchers in the issue ARROW-8513.


ambiguous default pesto options for MCMC

when generating default pesto options the fields .MCMC.nsimu_warmup and  .MCMC.nsimu_run are empty but do indeed have default values (according to documentation)

Due to new Sampling routines, this will soon be obsolete.

issues should only be closed when they are fixed in the master branch and at no point before that. If, for any reason, the commit does not end up in the master branch is and never will be fixed. This is why you use the "fixed #43" in the commit such that you do not forget to close the issue later on.

@paulstapor This issue is resolved now?

currently having a look, gimme a moment


Write different implementations of IThreadPool and benchmark it

[ ] Implement good TestAndSet spinlock

Write different implementations IThreadPool

[ ] IntusiveList with std::mutex
[ ] IntusiveList with spinlock
[ ] IntusiveList with std::mutex per thread
[ ] IntusiveList with spinlock per thread
[ ] Michael Scott queue
[ ] Michael Scott queue per thread
[ ] Lock-free MPSC queue with std::mutex for consumers
[ ] Lock-free MPSC queue with spinlock for consumers
[ ] Lock-free MPSC queue per thread
[ ] Lock-free MPSC queue with std::mutex and per-thread SPSC queue for consumers
[ ] Lock-free MPSC queue with spinlock and per-thread SPSC queue for consumers
[ ] Lock-free deque
[ ] Lock-free deque per thread

And whatever else you can invent

[ ] Benchmark their

P.S. per thread means you should use work-stealing or work-distribution

https://tokio.rs/blog/2019-10-scheduler
https://zig.news/kprotty/resource-efficient-thread-pools-with-zig-3291
https://www.youtube.com/watch?v=-K11rY57K7k

https://github.com/tokio-rs/tokio/blob/master/tokio/src/runtime/thread_pool/park.rs


Possible mistake on the version number

After new release was published, I tried to update the package but neither yarn nor npm knows the new version.
I looked for the git tags in github but didn't find it. Then I looked at npm's version list and got this:

2.0.1 (2 hours ago)
2.1.0 (8 months ago)

As yarn and npm use/understand semver, they don't see 2.0.2 as a new version after 2.1.0. I think the version number should be 2.1.1.

@zackify Is there a mistake on the version number?
Originally posted by @mindsers in https://github.com/leoasis/graphql-tag.macro/pull/10#issuecomment-523760148

I wasn’t aware that a 2.1.0 was released and yet the package.json on master said 2.0.0. I’ll have to do a new release tomorrow. Sorry about that. As you can tell this isn’t my repo but I got added as a collaborator a while ago haha

No problem!  I just write the problem here to be solved at some point and we don't forget about it. 😃
As a workaround until it's solved, we can (force) install the package at the version 2.0.1 specifically.
yarn add<EMAIL_ADDRESS>

@zackify Hi! Is there anything new about this?

Happy to get a PR that includes this change! Should be an easy one :)

@leoasis a PR for what? It seems the needed code is already on master.

Hi - same comment here. Any chance this can be pushed out?


errors on python 3.5 for lead_acid notebook

https://travis-ci.org/pybamm-team/PyBaMM/jobs/531078575
need to check the jacobian

closing this as we have dropped 3.5


Update FAQ.md

typo word "consesus" => "consensus"

What issue does this pull request resolve?
What changes did you make?
Is there anything that requires more attention while reviewing?

Cool, thanks


feat: add mdx example

This example showcases the mdx integration of remix -- the custom component support was taken from here though it doesn't seem to actually work.
Related: https://github.com/remix-run/remix/pull/4273

I'm going to close this, as this isn't (as you said yourself) actually working


Create form to create issues in github

Create a entry form so that non-github users can log issues with missing content/desirable features:
https://miro.com/app/board/o9J_lRkatHo=/?moveToWidget=3074457355746547705&cot=14

These guys might have a cool solution for connecting an external link to a github issue. https://sybil.org/#/delegates/uniswap
Might be a 1st step.


Tabs: previousTab() method returns wrong Tab component

Ionic version:
[ ] 1.x
[x] 2.x
I'm submitting a ...
[x] bug report
[ ] feature request
[ ] support request
Current behavior:
The previousTab() method from the Tabs component returns the incorrect Tab when called. Currently, it returns the tab that came before the correct one, or null.
Expected behavior:
It should always return the most recent Tab component in the selection history that meets the relevant criteria (not hidden, not disabled).
Steps to reproduce:

Clone this repo: https://github.com/jsayol/ionic-issue-9999.git
Change tabs and watch the information logged out to the console

Related code:
The problem seems to be when looping over _selectHistory:
for (var i = this._selectHistory.length - 2; i >= 0; i--) {

should be:
for (var i = this._selectHistory.length - 1; i >= 0; i--) {

Other information:
I'm preparing a PR, I want to make sure to update the tests to catch this.
Ionic info:
Your system information:

Cordova CLI: 6.4.0
Ionic Framework Version: 2.0.0-rc.5
Ionic CLI Version: 2.1.18
Ionic App Lib Version: 2.1.7
Ionic App Scripts Version: 1.0.0
ios-deploy version: Not installed
ios-sim version: Not installed
OS: Linux 4.8
Node Version: v7.4.0
Xcode version: Not installed

I just updated the ionic-issue-9999 repo above to also log what the correct output should be.

I probably see consequences of this same issue in form of deeplink URL is updated not with the current tab but previous one.
E.g. if I have a page with 3 tabs (tab1, tab2, tab3):

Open page, tab1 selected by default, URL: #/page/tab1 (correct)
Click tab2, URL: #/page/tab1 (should be #/page/tab2)
Click tab3, URL: #/page/tab2 (should be #/page/tab3)
Click tab1, URL: #/page/tab3 (should be #/page/tab1)
etc.

Ah, wait, the problem is not in previousTab(). The ionChange event for the Tabs component is emiting before adding the new tab into the history array, and should emit after.

To recap: this is only an issue if previousTab() is used from within an ionChange event handler for the Tabs component.
Emiting on ionChange after adding the new page to the history array solves the problem but only if the history array has not been trimmed (previousTab(false)) . If trimming has been set to true (the default) then there's still an issue.
I'm off to bed so I'll keep looking into it tomorrow.

@jsayol @brandyscarney I also see tab url issues in RC5. In RC4 was working properly.

@brandyscarney  @adamdbradley I see, that this issue was removed from 2.0.0-rc6 milestone and just want to make sure, that you are aware that without fixing it deeplinker/url for tabs will be broken, as described by @astec in his comment. I had to go back to RC4, until this is fixed.

@manucorporat @brandyscarney  @adamdbradley It seems, that url issue is covered by #10032 and PR #10067 (thanks to @jackfengji).

can you check this out?
https://github.com/driftyco/ionic/pull/10078

@manucorporat @jsayol Tested, but no change, still not working as expected :-(

@lleevvyy  what is not expected?
I still think if we have 3 views in the history: [A, B, C]
previousTab() should return B

@manucorporat To be honest I didn't check how previousTab() works, but I checked how url is changing on tab change, and the issue that url is inappropriate is still there, that is url is for previous tab not the current/selected one.

Ah right right! I was suggesting to merge both PRs in order to fix all the known issues around previousTab, including the URL.

@manucorporat So, yes, when both PRs are merged, then everything is ok :-) Thanks.

Merged and fixed!


deliver Item NBT Tag

Quests version: 3.5.9-b586
Server version: spigot 1.12.2
I encountered an error when creating "items-to-deliver" stages with items using NBT Tag Hide flag, unbreakable
Creating a successful stage but when delivering the item, the NPC does not receive it
img: https://imgur.com/a/FbVOA6N
I tried to set the data value to 0 but it still doesn't work (this I don't want, because I use custom texture packs so the data value is very important, I'm not allowed to change them)
item: https://pastebin.com/yp9xFcqq

If the data/durability value isn't the issue, then it must another item attribute, as the "not a required item" message only occurs when the item in hand doesn't match the one on file exactly. They must be identical down to the same lore and ItemFlags.
I'll see if I can update the plugin soon to be more specific about what doesn't match.

It can't be another item, because I hold that item and load the item in hand, then reload the plugin and take quests
The item I had earlier was still in hand and delivered to npc, so it can't be different.

okay, hope it will be fixed. <3

@trungbmt I've just added a feature in 90511df08fff7d1a494d1468d6427aa0bc694630 that should show the player the reason if an item doesn't match when trying to deliver it. Please update to the following build (once available) and let me know what the Quests says that the reason is:
http://ci.ac3-servers.eu/job/Quests/589/

It has shown the difference about
data
item flags
unknown
But obviously the item I delivered to npc is the item that I loaded the item in hand.
You can see video:
https://vimeo.com/309242426

From your video are the following strings:

The difference is '<data'.
The difference is 'item flags'.
The difference is 'unknown'.`

The first line about '<data' and the last about 'unknown' are both errors on my part which I'll fix later, so ignore that. However, the plugin thinks that your item flags do not match up. Will investigate soon.

okay, i will wait

thank you


Site not working

Describe the bug
It's giving the following error

Application error: a client-side exception has occurred (see the browser console for more information).

Screenshots

Desktop (please complete the following information):

OS: Windows
Browser: Microsoft Edge
Version: 103.0.1264.37

Hi there @swapn652. Sorry you had to encounter this issue.
It seems that the error was due to the Tweet's link.
Could you please tell how you got the tweet's link.

This issue is now fixed.
Thanks again @swapn652 for pointing out the issue.


Downgrade to python 3.11

We're seeing this error: https://github.com/python/cpython/issues/120788
In some runs, so this commit downgrades Python to 3.11, as all reports of that bug seem to be from 3.12.

Can't seem to be able to tag Rowan in to review this, weirdly.


Change password generator URL

The old one is not valid anymore. It returns bfnt.io’s server IP address could not be found. (on chromium based browsers). I replaced it with passwordsgenerator.net.

Nice catch, thank you!
I added a bit.ly link with safe defaults to ensure people don't face any issue.


Trying to install openlane locally

hi ,
triying to install openlane locally , but seems stuck. No idea why the issue is happening.
Collecting kiwisolver>=1.0.1
Using cached kiwisolver-1.3.2-cp38-cp38-manylinux_2_5_x86_64.manylinux1_x86_64.whl (1.2 MB)
Collecting setuptools-scm>=4
Using cached setuptools_scm-6.3.2-py3-none-any.whl (33 kB)
Collecting fonttools>=4.22.0
Using cached fonttools-4.28.3-py3-none-any.whl (884 kB)
Collecting MarkupSafe>=0.23
Using cached MarkupSafe-2.0.1-cp38-cp38-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_12_x86_64.manylinux2010_x86_64.whl (30 kB)
Collecting pytz>=2017.3
Using cached pytz-2021.3-py2.py3-none-any.whl (503 kB)
Collecting six>=1.5
Using cached six-1.16.0-py2.py3-none-any.whl (11 kB)
Requirement already satisfied: setuptools in ./venv/lib/python3.8/site-packages (from setuptools-scm>=4->matplotlib->-r ./dependencies/python/run_time.txt (line 3)) (44.0.0)
Collecting tomli>=1.0.0
Using cached tomli-1.2.2-py3-none-any.whl (12 kB)
Installing collected packages: pyparsing, tomli, six, packaging, setuptools-scm, pytz, python-dateutil, pillow, numpy, MarkupSafe, kiwisolver, fonttools, cycler, XlsxWriter, pyyaml, pandas, matplotlib, jinja2, install, click
Successfully installed MarkupSafe-2.0.1 XlsxWriter-3.0.2 click-8.0.3 cycler-0.11.0 fonttools-4.28.3 install-1.3.5 jinja2-2.11.3 kiwisolver-1.3.2 matplotlib-3.5.0 numpy-1.21.4 packaging-21.3 pandas-1.3.4 pillow-8.4.0 pyparsing-3.0.6 python-dateutil-2.8.2 pytz-2021.3 pyyaml-6.0 setuptools-scm-6.3.2 six-1.16.0 tomli-1.2.2
Installing dependencies...
Installing cvc...
HEAD is now at d172016 Update README.md
bash: line 1: y/venv/bin/activate: No such file or directory
Traceback (most recent call last):
File "./env.py", line 538, in
main()
File "./env.py", line 535, in main
commandsargs[0]
File "./env.py", line 418, in local_install
installer.run()
File "./env.py", line 404, in run
install()
File "./env.py", line 47, in exit
raise exc_value
File "./env.py", line 404, in run
install()
File "./env.py", line 382, in install
f.write(tool.version_string)
File "./env.py", line 47, in exit
raise exc_value
File "./env.py", line 373, in install
subprocess.run([
File "./env.py", line 47, in exit
raise exc_value
File "./env.py", line 373, in install
subprocess.run([
File "./env.py", line 47, in exit
raise exc_value
File "./env.py", line 373, in install
subprocess.run([
File "/usr/lib/python3.8/subprocess.py", line 516, in run
raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['bash', '-c', '                                    set -e\n                                    source y/venv/bin/activate\n                                    autoreconf -i\n./configure --disable-nls --prefix=$PREFIX\nmake clean\nmake -j$(nproc) $READLINE_CXXFLAGS\nmake install\n\n                                ']' returned non-zero exit status 1.

command run is  "
python3 ./env.py local-install

The whole issue was trying to install in local directory named 'y' ....
Closing


Moving tickets between rakudo and problem-solving repos is impossible

It used to be that feature requests and proposed language changes were filed in rakudo/rakudo, but now we have this repo. However, because of the github limitation, it's not possible to move tickets between different orgs.
Is there any good reason for https://github.com/rakudo/rakudo/ and https://github.com/MoarVM/MoarVM repos to be in separate orgs?
Also, there are some inconsistencies. For example:

https://github.com/perl6/rakudo.org (rakudo website in perl6 org), but
https://github.com/MoarVM/moarvm.org (moar website in MoarVM org)

Wouldn't it be easier to move everything into perl6 org?
Note that CLA restriction can be kept in place, and it can be implemented with Teams github feature.

Ping @jnthn :)

I would prefer they be kept separate.  At least in the original design, MoarVM and NQP have been intended to support more than just Perl 6 and Rakudo.  I don't know @jnthn 's intentions in this area, but I still think rakudo, nqp, and moarvm make more sense as separate repos and projects with separate issue queues.
My $0.02,
Pm

@pmichaud but why do they need to be in separate github organizations?

Because they may end up with different committer lists, adminstrator roles, etc.
In general I've always wanted to avoid the sense that Rakudo or Perl 6 in any way "own" NQP and/or MoarVM; putting them all into one GitHub account somewhat defeats that purpose.  If we end up with other languages or systems based on these tools, the tools should have their own identities.
Pm

Because they may end up with different committer lists, adminstrator roles, etc.

This can be done with Teams, at least to some extent.

putting them all into one GitHub account somewhat defeats that purpose

I don't see how it matters for that purpose.

I agree with @pmichaud on things retaining their identities. Some other things:

The namespacing organizations offer feels useful; it's easy to see which repos go with MoarVM, Rakudo, etc. We could replicate it with some kind of prefix, but that feels messy.
I think separate organizations also convey, to a degree, the fact that the various projects are managed in somewhat different ways and have rather different commit policies. For example, the Perl 6 org is very liberal, Rakudo is guarded by CLA + other contributors are happy with the commit bit being given out (we never really formalized the second part of that), and MoarVM's policy is "whoever jnthn feels comfortable having a commit bit". :-)
Keeping Rakudo and MoarVM as distinct organizations helps maintain the perspective that they're not the official Perl 6 compiler and runtime respectively. Having them under a perl6 org would dilute that.

it's easy to see which repos go with MoarVM, Rakudo

It's not like there are many repos. Rakudo org only has rakudo and star, and I see no problem with star being perl6/rakudo-star. Moar org has some forks, I'm not sure how I feel about those.

I think separate organizations also convey, to a degree, the fact that the various projects are managed in somewhat different ways and have rather different commit policies.

Having IMO annoyingly different policies is not a great thing.

Keeping Rakudo and MoarVM as distinct organizations helps maintain the perspective that they're not the official Perl 6 compiler and runtime respectively. Having them under a perl6 org would dilute that.

So perl 6 has no official compiler? That's a weird thing to say, especially given that you can download rakudo straight from https://perl6.org/downloads/.

Ah, and as another consideration, I have little appetite for the churn of moving stuff, and the impact it will have on all downstream things that rely on repository URLs and so forth. Folks seem to reliably underestimate the amount of downstream costs changing the locations of stuff will have. For example, Rakudo's installation layout changes are costing me time/money to deal with. I'm not grumbling much because I think it's worth paying that for relocatable installs. I don't see myself being convinced that the cost of moving stuff around is worth the win this issue seeks.

So perl 6 has no official compiler?

Correct, as realized by the language being defined by its test suite, not a single implementation.

So perl 6 has no official compiler?

Correct, as realized by the language being defined by its test suite, not a single implementation.

And just to amplify @jnthn 's point a bit... "No official or reference compiler for Perl 6" is one of the foundational principles for the language. Perl 6 is defined by its test suite, not by an implementation.  That's a big reason why we call the compiler "Rakudo" and not "Perl 6".
There was also a time in the not-too-long-ago past when perl6.org/downloads (or its equivalent) offered links to multiple Perl 6 implementations, including Rakudo.  Rakudo might be the most complete implementation, but we should never treat it as the "official" or "master" implementation.
Pm

There was a more recent discussion about moving rakudo/rakudo (log) and about the CLA (log and more).
Also, here's a question about perl6/doc→rakudo/rakudo transfers.

I'm not interested in this ticket anymore and I've never seen anybody else raise that concern.


list (non-tight) spacing requires blank line between list elements

Description
Description
List have the settable option spacing which specifies the spacing between list elements of non-tight lists. Judging by the  it seems to be canonical to not separate each list elements with a blank line. Yet, list spacing is not applied unless two list elements are separated by a blank line.
Example
#set list(spacing: 1cm, tight: false)
- 1
- 2
- 3
- 4

#set list(spacing: 1cm, tight: false)

- 1

- 2
- 3
- 4

(tested on the main branch on commit 2f810899)
Expected behaviour
This seems inconsistent to me. Either you need to separate all list elements by a blank line for the custom spacing to apply, or none. Needing to separate one or more seems weird to me. I would have expected the spacing to be applied in the first example as well (the one with no separating blank lines).
What are your thoughts on this?
Reproduction URL
No response
Operating system
macOS
Typst version

[X] I am using the latest version of Typst

The idea is that a tight list (no blank lines) has exactly the normal line spacing while a wide (non-tight) list has custom spacing. But it has caused quite a lot of confusion, so I'm open to changing how list spacing and tight/non-tight works.

The idea is that a tight list (no blank lines) has exactly the normal line spacing while a wide (non-tight) list has custom spacing. But it has caused quite a lot of confusion, so I'm open to changing how list spacing and tight/non-tight works.

We could just apply the "auto" spacing to all lists (regardless of separating blank lines), unless set otherwise. Thereby, one would lose the ability to have both tight and non-tight lists simultaneously without using #set in between. I am not sure if this feature is even used too often, however.
If we choose to keep both tight and wide (non-tight) lists, I would at least advocate for forcing blank lines in between each list element of wide lists. I find this to be more consistent.

I'm not sure whether tightness really depends on the document or rather on the specific list. I tend to use tight lists if the items are words, phrases or short sentences and wide lists if the items are one or even multiple paragraphs.