Add field injection to SoftAssertionsExtension

Here is an implementation of #1970. It depends on #1977.
@joel-costigliola , I know you asked for two separate PRs. I found this a bit unworkable as the functionality changes for SoftAssertionsExtension depended on the API change. However, I at least added them as two separate commits in this PR so that you can still review them separately if you wish - I hope that's ok. If you still really want separate PRs, I'll see what I can do (it's more work, that's all).
Check List:

Fixes #1970
Unit tests : YES
Javadoc with a code example (on API only) : NOT YET - I anticipate possible changes to the implementation as part of the review process that might alter the API; prefer to wait for that process to finish before proceeding.

Feature divergence from SoftlyExtension
Some of the features of the proposed field injection diverge from the implementation in SoftlyExtension. The intent is for these divergences to be seen as enhancements, but I'm open to other opinions. :smile:

PER_CLASS lifecycle support: Unlike SoftlyExtension (which uses the instance creation callback to construct the soft assertions instance), this implementation uses the BeforeEachCallback hook to do the injection. This means that the restriction on test class lifecycle in SoftlyExtension to prohibit use with PER_CLASS lifecycle semantics can be (and has been) lifted.
Unlike SoftlyExtension, multiple SoftAssertionsProvider instances are supported. Errors from the multiple providers will be aggregated, in-order, into the same base error collector class, so that when the extension asserts after the test has run it will contain all assertion failures registered against all soft assertions providers in the order that they were executed. The same is true if you mix parameter injection with field injection. This is, I think, a big improvement over what we've had up until now, courtesy of the AssertionErrorCollector abstraction and the use of the delegate feature.
SoftAssertionsExtension will refuse to inject into a field that is private, final or static. This follows a policy set by the Jupiter implementation. However, strictly it is a departure from SoftlyExtension which allowed injection on final or private fields.

Most of the changes are backwards compatible. Those that aren't I'm not too concerned about, as SoftlyAssertion, is still marked as beta.
Known issues/for discussion

PER_CLASS will not mix well with CONCURRENT execution mode. At the moment there is no check. I have raised junit-team/junit5/issues/2396 to discuss this. Failing any progress on that point (and for earlier versions of JUnit), there is an alternative I can look at to try and do this kind of sanity check.
Pending the above issue, it may also be possible to allow injection into a ThreadLocal<? extends SoftAssertion> instance if you are combining PER_CLASS and CONCURRENT.
With the current implementation, if you annotate a nested class with SoftAssertionsExtension, it will also try and inject into all of the enclosing instances if they have a SoftAssertionsProvider field present. This is true even if the enclosing types are not annotated with SoftAssertionsExtension. This was necessary to make the test class (which I ported from `SoftlyExtension
The current implementation is technically a breaking change, as any existing classes that use the extension and have a SoftAssertionsProvider field will suddenly find the extension attempting to inject into it whereas before it didn't. Worse, in cases where you may have marked the field as static, final or private, the test will suddenly start to fail with a complaint about this. I'm not sure how widespread these usage patterns are to know whether or not this is a major concern. If it is, there are a couple of possible workarounds:
** Don't attempt to set the field if it is not null. This approach will not work with PER_CLASS functionality though.
** Require an annotation on the field to flag it as being for injection. This is the approach we settled on in osgi-test and it seems to work well (eg, to inject a BundleContext instance using the BundleContextExtension, it is necessary to annotate it with @InjectBundleContext) - allowing people to mix their own soft assertions fields with ones intended for injection. It is a little more verbose on the usage side, however.
AssertionErrorCollector.getDelegate() currently returns Optional<AssertionErrorCollector>, not sure if it would be better to return AssertionErrorCollector.
Should SoftlyExtension be deprecated in favour of this new functionality?

The current implementation is technically a breaking change, as any existing classes that use the extension and have a SoftAssertionsProvider field will suddenly find the extension attempting to inject into it whereas before it didn't. Worse, in cases where you may have marked the field as static, final or private, the test will suddenly start to fail with a complaint about this. I'm not sure how widespread these usage patterns are to know whether or not this is a major concern.

Ironic that the first push of this PR tripped up on this very issue! I promise that I did not intentionally set out to make an example out of myself on this point...

I'll look into the this PR and the other soft assertions related issues this week end as I'm quite busy during the week.

PER_CLASS lifecycle support: Unlike SoftlyExtension (which uses the instance creation callback to construct the soft assertions instance), this implementation uses the BeforeEachCallback hook to do the injection. This means that the restriction on test class lifecycle in SoftlyExtension to prohibit use with PER_CLASS lifecycle semantics can be (and has been) lifted.

nice!

Unlike SoftlyExtension, multiple SoftAssertionsProvider instances are supported. Errors from the multiple providers will be aggregated, in-order, into the same base error collector class, so that when the extension asserts after the test has run it will contain all assertion failures registered against all soft assertions providers in the order that they were executed. The same is true if you mix parameter injection with field injection. This is, I think, a big improvement over what we've had up until now, courtesy of the AssertionErrorCollector abstraction and the use of the delegate feature.

I agree this is an improvement.

SoftAssertionsExtension will refuse to inject into a field that is private, final or static. This follows a policy set by the Jupiter implementation. However, strictly it is a departure from SoftlyExtension which allowed injection on final or private fields.

It would be better to relax that and at least allows initializing private fields, this is quite common when using annotation, ex mockito.

PER_CLASS will not mix well with CONCURRENT execution mode. At the moment there is no check. I have raised junit-team/junit5/issues/2396 to discuss this. Failing any progress on that point (and for earlier versions of JUnit), there is an alternative I can look at to try and do this kind of sanity check.

If the alternative is too hacky, I'm happy with documenting the limitation if the JUnit issue is fixed in 3.8 (which seems to be likely).

Pending the above issue, it may also be possible to allow injection into a ThreadLocal<? extends SoftAssertion> instance if you are combining PER_CLASS and CONCURRENT.

That's a natural solution, would you use a ThreadLocal<? extends SoftAssertion> for all cases or only for PER_CLASS and CONCURRENT?

With the current implementation, if you annotate a nested class with SoftAssertionsExtension, it will also try and inject into all of the enclosing instances if they have a SoftAssertionsProvider field present. This is true even if the enclosing types are not annotated with SoftAssertionsExtension. This was necessary to make the test class (which I ported from SoftlyExtension)

I think that's ok since it seems to me that's a pretty uncommon case, we will document it.

The current implementation is technically a breaking change, as any existing classes that use the extension and have a SoftAssertionsProvider field will suddenly find the extension attempting to inject into it whereas before it didn't. Worse, in cases where you may have marked the field as static, final or private, the test will suddenly start to fail with a complaint about this. I'm not sure how widespread these usage patterns are to know whether or not this is a major concern. If it is, there are a couple of possible workarounds:
** Don't attempt to set the field if it is not null. This approach will not work with PER_CLASS functionality though.
** Require an annotation on the field to flag it as being for injection. This is the approach we settled on in osgi-test and it seems to work well (eg, to inject a BundleContext instance using the BundleContextExtension, it is necessary to annotate it with @InjectBundleContext) - allowing people to mix their own soft assertions fields with ones intended for injection. It is a little more verbose on the usage side, however.

I prefer having an annotation on the field, as this is a common practice (ex mockito @Mock annotation) I don't feel it is too much too ask.

AssertionErrorCollector.getDelegate() currently returns Optional, not sure if it would be better to return AssertionErrorCollector.

I'll look at this when I'll start the code review.

Should SoftlyExtension be deprecated in favour of this new functionality?

yes!

SoftAssertionsExtension will refuse to inject into a field that is private, final or static. This follows a policy set by the Jupiter implementation. However, strictly it is a departure from SoftlyExtension which allowed injection on final or private fields.

It would be better to relax that and at least allows initializing private fields, this is quite common when using annotation, ex mockito.

👍 I agree that having the annotation means that we don't have to be as strict on private. In osgi-test, for now we have kept the restriction on private because we took the approach that it's easier to fix without breaking backwards compatibility if we later find out we've been too restrictive than it is if we find out we've been too permissive.

PER_CLASS will not mix well with CONCURRENT execution mode. At the moment there is no check. I have raised junit-team/junit5/issues/2396 to discuss this. Failing any progress on that point (and for earlier versions of JUnit), there is an alternative I can look at to try and do this kind of sanity check.

If the alternative is too hacky, I'm happy with documenting the limitation if the JUnit issue is fixed in 3.8 (which seems to be likely).

Good to know. I think I'll be able to come up with something not too hacky though.

Pending the above issue, it may also be possible to allow injection into a ThreadLocal<? extends SoftAssertion> instance if you are combining PER_CLASS and CONCURRENT.

That's a natural solution, would you use a ThreadLocal<? extends SoftAssertion> for all cases or only for PER_CLASS and CONCURRENT?

I think that the extension should be flexible and adapt to the type that the field has been declared by the developer as much a possible. I think I would support both ThreadLocal<? extends SoftAssertionsProvider> and ? extends SoftAssertionsProvider, but with the following sanity checks:

My latest push implemented something like the above, but I've been thinking about it and I might be able to find a way to hide the ThreadLocal functionality behind the AssertionErrorCollector and make it completely transparent to the user. If I can figure out a way to do this I'll make another push.

I'm in the process of making significant changes to this PR so that it will transparently support PER_CLASS/CONCURRENT. This will make some of the above remaining unresolved comments redundant, but I'll try and incorporate those that are still relevant.

Sure, let me know when the PR is ready for another review.

Ok, assuming that the build passes, this is now ready for another round.
The big change here (as I noted) is that I hid away the thread localisation logic in the extension itself. If the extension is invoked in a PER_CLASS/CONCURRENT context, then it will handle this automatically without the user of the extension needing to be aware of it.
The magic happens courtesy of the custom ThreadLocalErrorCollector, which is used as an intermediate delegate in that case and delegates to an instance of AssertionErrorCollector that is specific to the thread context that it is invoked from.
Let me know if you have any additional concerns or comments (I know the examples and doc still need to come).

Integrated thank you so much @kriegfrj for this contribution!


Fixing Linting Issues

Fixes #46
To Do

[x] add npm script for lint --fix command
[x] run npm run lint:fix
[ ] resolve remaining 63 warnings
[ ] enable warnings as errors in lint config

The remaining 48 lint warnings violate these rules:

@typescript-eslint/no-explicit-any
@typescript-eslint/explicit-module-boundary-types
@typescript-eslint/ban-types

Forgive me, I don't typescript and have no idea what is going on...

GitHub Selfies

Here are the docs where we can get more insight into the rules that are in violation:
https://github.com/typescript-eslint/typescript-eslint/tree/master/packages/eslint-plugin/docs/rules

@typescript-eslint/no-explicit-any
Using the any type defeats the purpose of using TypeScript. When any is used, all compiler type checks around that value are ignored. If a type is truly unknown, we should use the unknown type for type safety. See Unknown basic type
@typescript-eslint/explicit-module-boundary-types
Explicit types for function return values and arguments make it clear to any calling code what is the module boundary's input and output. (e.g. function AnswerToLife() { return 42 } vs. function AnswerToLife(): number { return 42 })
@typescript-eslint/ban-types
Some built-in types have aliases, some types are considered dangerous or harmful. It's often a good idea to ban certain types to help with consistency and safety.
Default banned types:  upper-case primitive types (i.e. Boolean vs boolean), Function, Object or {}, and object

@parithon that helped a bit. Thanks. I was better able to understand what the issue was.

@NotMyself can you ping me when you're ready for a review of this one.

@MichaelJolley will do.


MF-525 - Add pagination response to the readers

What does this do?
Adds pagination response for every reader.
Which issue(s) does this PR fix/relate to?
Resolves #525.
List any changes that modify/break current functionality
Readers response has now pagination metadata.
Have you included tests for your changes?
Yes, I've updated existing tests.
Did you document any new/modified functionality?
I've updated swagger docs.

Codecov Report

Merging #729 into master will decrease coverage by 0.25%.
The diff coverage is 75.51%.

@@            Coverage Diff             @@
##           master     #729      +/-   ##
==========================================
- Coverage   85.32%   85.07%   -0.26%
==========================================
  Files          64       64
  Lines        3993     4059      +66
==========================================
+ Hits         3407     3453      +46
- Misses        399      409      +10
- Partials      187      197      +10

Impacted Files
Coverage Δ

readers/cassandra/init.go
100% <ø> (ø)
:arrow_up:

readers/api/endpoint.go
100% <100%> (ø)
:arrow_up:

readers/api/responses.go
100% <100%> (ø)
:arrow_up:

readers/mongodb/messages.go
86.44% <53.84%> (-5.56%)
:arrow_down:

readers/influxdb/messages.go
79.46% <66.66%> (-6.44%)
:arrow_down:

readers/cassandra/messages.go
87.87% <86.11%> (-3.79%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04281f2...ebef808. Read the comment docs.


"CompareReadOnly = false" is not working as expected.

I had a compare logic like this for comparing all settable instance properties.
private static CompareLogic _compareLogic = new CompareLogic(new ComparisonConfig()
        {
            CompareFields = false,
            CompareReadOnly = false,
            CompareStaticFields = false,
            CompareStaticProperties = false,
            MaxStructDepth = 5,
        });

however, some getter is triggered during the comparation.

maybe properties with CanWrite == false should be filtered in ExcludeLogic.ShouldExcludeMember?

Thanks for reporting this issue.

Fixed and deployed to NuGet


Add support for named parameters in Native SQL

Instead of
val sql = """
        select name from t_employee
        where department_id = ?
        order by id
    """

it will be nice to have
val sql = """
        select name from t_employee
        where department_id = :department_id
        order by id
    """

https://www.codejava.net/frameworks/spring/spring-namedparameterjdbctemplate-examples

Sorry, I'll close this issue because I don't think we should provide more features for native SQLs.
Although Ktorm provides supports for native SQLs, we don’t encourage people to use it. Once native SQL is used, we will lose the benefits of the strong typed DSL.

If someone wants to use only native SQL there are already solutions for this.
Most people which is looking into this library want to use strong typed DSL.
Usually native SQL will be used only when some feature is not available in the library, in this case named parameters in native SQL will be much better than placeholders.


Hot Replacement (Stateless) Containers

Hello!
Currently, the container installs itself when starting. This should be actually done during the image build step, not when running the container.
The Problem
The setup right now, does not allow to quickly switch environment variables because they are only read when setting up the container. Any other reconfiguration of the container that is not doable during runtime ( change exposed ports, add labels for docker reverse proxy, set volumes) has to trigger the reinstallation of strapi.

(Source: https://robin.io/blog/stateless-vs-stateful-containers-1/)
The Solution
To make a docker app stateless, it has to consider its lifecycle. I already talked about that here: https://github.com/strapi/strapi/issues/1763
If all initial dependencies required for the runtime are managed during docker build, and additional packages can be installed during runtime - by using a volume - the startup time can be cut down to virtually zero.
I work around this problem right now, by installing all plugins in build.
This works, if you check in a project created by strapi init.
I let plugins and admin panel only be downloaded when needed and uploads is embedded as volume.
Thus I have the following files in my .gitignore file:
**/build
admin
/plugins
uploads
documentation/

This is the dockerfile:
FROM strapi/strapi

WORKDIR /usr/src/api/app

# Copy from strapi initialized project root
COPY package* ./

RUN npm install

RUN ln -s node_modules/strapi-admin admin

RUN strapi install content-manager
RUN strapi install content-type-builder
RUN strapi install email
RUN strapi install graphql
RUN strapi install settings-manager
RUN strapi install upload
RUN strapi install users-permissions

COPY public ./public

WORKDIR ./public
RUN npm install
RUN npm run build

# Cleanup and overwrite of plugin data

WORKDIR /usr/src/api/app
COPY server.js ./
COPY api ./api
COPY User.settings.json ./plugins/users-permissions/models

COPY config ./config
COPY ./favicon.ico ./favicon.ico

EXPOSE 1337

ENV NODE_ENV production

CMD "npm start"

Problems
There are a few changes required to make this work. Installing the plugins as part of the build cycle is not optimal. Ideally you would have a strapi.json (like package.json) or something like that, to tell what plugins need to be installed. This should be a volume and can be used to deal with consecutive installs.
Plugins - in the best case - should also be stateless and not require something like a User json to be copied to some plugin folder.
Conclusion
The deployment mechanisms of strapi and docker are a bit different. For Docker it doesn't make sense to have three environments configured. At least from a DB connection point of view. Instead it would make sense to define connections to other containers (DB) as environemt variables that are either saved to the configuration or read during runtime.
Please let me know what you think, and what your experience is.

HI,
We just released a full rebuild of our docker image 🎉
We are closing the issues and open PRs to start fresh.
If you feel like something is missing or want to add things feel free to open new PRs ! 💯


kapitainsky.RcloneBrowser version 1.8.0

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Well there does not seem to be any fix so closing the PR


Make TimeOfDay comparable

From a strict modeling perspective, it doesn't make sense for TimeOfDay to be comparable when you think about time on a 24 hour clock.  Since two hours after 23:00 is 01:00, then who's to say that 23:00 is the greater value?
However, in the real world, I think that there will be many scenarios that will require comparison.  For example, expressing a LINQ or OData query.  For these usages, it will not be easy to use the TimeOfDay.IsBetween method.
Also, the general intention is that TimeOfDay would map closely to SQL Server's time data type, which is comparable in the context of the WHERE or ORDER BY clause of a SQL query.
In other words, TimeOfDay should be comparable, but when comparing it should be expressly comparing the magnitude of the time, rather than its position on a clock.

t1 < t2 would be equivalent to t1.IsBetween(new TimeOfDay(0,0), t2)
t1 > t2 would be equivalent to t1.IsBetween(t2, new TimeOfDay(0,0))

Completed in 24324f1f0970bf75abf9701eb3dde4db02e2a574


Clean up: consortium

MINOR changes:

improved instructions

MAJOR changes:
none
SPECIAL ATTENTION:
none

Just a note, won't it be more appropriate to have a consortium members property? As by definition consortium is association of multiple organisations or peoples.
P.S. Maybe I should move this to a issue so we can deal with it latter.

Just a note, won't it be more appropriate to have a consortium members property? As by definition consortium is association of multiple organisations or peoples.
P.S. Maybe I should move this to a issue so we can deal with it latter.

This has actually been part of the schema in its original draft (see original issue https://github.com/HumanBrainProject/openMINDS_core/issues/360 and PR https://github.com/HumanBrainProject/openMINDS_core/pull/367). The issue with the members list has been discussed in the PR. The rough summery is that the maintenance of the members of a consortium will be too much work, and @apdavison suggested to rather handle this relationship via "affiliations".


Remove tokenizer for openai chat completions

As per the discussion with @haileyschoelkopf in discord.

@haileyschoelkopf i am not quite sure I fully understand what the Reorderer does, so am not quite sure how to change the reordering function.

You got it right! The reorder is meant to sort from high to low in token length, so that for local models, runtime estimates are overestimates since they run the slowest requests first. It's no longer really needed to be its own class so cleaning it up a bit is on our todo list.


Ability to delete rooms.

A fairly common request is the ability to "delete a room".
In practice, this could mean someone with sufficient power marking with room with a tombstone with metadata requesting all participating servers drop the room from their DB.  However, this would vandalise everyone else's copy of the room.
Perhaps a better bet would be to support room garbage collection, such that if everyone on your local server has hit 'leave' and 'forget' on their copy of the room, the room is actually removed from the server.

https://matrix.org/docs/spec/client_server/unstable.html#post-matrix-client-r0-rooms-roomid-forget already says:

If all users on a homeserver forget a room, the room is eligible for deletion from that homeserver.

so this sounds like an implementation detail which synapse doesn't support?

true. i guess i'm more trying to work out what use case something like https://twitter.com/cartocalypse/status/1095322661322977281 is asking for.

I suppose coming from a UI perspective we don't really have the endpoint for this, in which case a dedicated /delete enpoint makes sense (using the behaviour you've described).

Using a synapse for a workplace server, this would make usability significantly easier. In particular for short-term rooms, a room administrator should be able to close a room. Equivalent to kicking everyone and waiting for garbage collection.

Any update on this? Seems like it would be a fairly common thing to do.

There is this PR: https://github.com/matrix-org/synapse/pull/7613

@hannojg this is just for server admins though, it would be nice if this could be extended to room admins as well (so e.g. random people creating personal rooms on matrix.org can remove them again if they want to).

See
Possibbility to clear whole chat to remove all messages / destroy chat room
in https://github.com/vector-im/riot-web/issues/14401
If you want, I can copy and recreate this issue here?

I mean there is a difference for private chats and public rooms. That issue is mostly concerned with private chats I think, I am thinking of public rooms I created but then all room admins decide the room is no longer to be kept (e.g. because it moved elsewhere) and want to actually delete it, beyond just removing the messages.
Basically, history clearing seems related, but not necessarily the same thing. Although I guess both could be solved by allowing the room owners (!= just server admins) to delete a room entirely with all its history and contents.

Fine, created https://github.com/matrix-org/matrix-doc/issues/2686.

@hannojg this is just for server admins though, it would be nice if this could be extended to room admins as well (so e.g. random people creating personal rooms on matrix.org can remove them again if they want to).

For clarity: when @ell1e said "this is just for server admins", I think they were referring to matrix-org/synapse#7613. That PR adds an API for use by server admins. This issue (#1882) covers the usecase of room admins deciding that a room should be deleted.

@richvdh sorry, yes. that is exactly what I meant, I apologize for my unclear use of "this" that was somewhat confusing in retrospect

I wanted to delete my room and recreate it but I can't, so now the new room has to have a different alias. This is unfortunate since I already left the original room, hoping that would delete it if nobody else was present and now I can't get back in to change the alias in order to give it to my new room.

@silvernode contacting the homeserver maintainers and asking them if they can remove the room should work. That's how we did.

@silvernode contacting the homeserver maintainers and asking them if they can remove the room should work. That's how we did.

I can try sending an email to matrix.org i suppose. Thanks for the reply.

Relevant. While I was figuring out what was what, I already had several rooms of corpses with occupied names. It's too bad that such a basic function as removal was not implemented.


Disallow start and end hyphens in URL regex

URLs such as abc-.com and -abc.com were being treated as valid URLs, when in fact domain labels can't start or end in a hyphen.
Fixed Issues
$ https://github.com/Expensify/App/issues/17591
Tests

Enter an invalid URL starting or ending in a hyphen (e.g. abc-.com) in a message and send
The message should not be hyperlinked

QA
Same as above.

I have read the CLA Document and I hereby sign the CLA

recheck

recheck


Some small travis enchanments

Current coverage is 16.37% (diff: 100%)

Merging #144 into devel will not change coverage

@@              devel       #144   diff @@
==========================================
  Files           735        735
  Lines         26373      26373
  Methods           0          0
  Messages          0          0
  Branches       2802       2802
==========================================
  Hits           4319       4319
  Misses        21754      21754
  Partials        300        300

Powered by Codecov. Last update b58ceae...1b0de4b


Merry Christmas

Let's see just how badly this fails
And no, if I was serious I wouldn't be doing this on Christmas day. Even if it is a nice break from the washing up.
Closes #
Changes proposed in this pull request:

...

Lots to do before this will work, so closing for now to keep our PR section clean.

Lots to do before this will work, so closing for now to keep our PR section clean.


modified_beam_search with decoder output cached.

At each decoding step, if one hyp emits a blank, then the output embedding of predictor network can be cached for next step decoding.

Thanks!
Do you have any numbers to show how the cache affects the decoding speed?


chore: add community tools

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Custom Properties do not work with Fuze Search

Describe the bug
For some whatever reason it just does not search in the custom properties
To Reproduce
<select name="country" id="country" class="form-select" placeholder="All Countries" type="dropdown">
	<option value="" selected="selected">All Countries</option>
	<option data-custom-properties="Afghanistan, Afganistan, Afghanistan, Afghanistan, Afghanistan, Afghanistan, Afghanistan" value="1">Afghanistan</option>
	<option data-custom-properties="Albania, Albania, Albania, Albania, Albania, Albanien, Albania" value="2">Albania</option>
	<option data-custom-properties="Germany, Germania, Germany, Germania, Germany, Deutschland, Germany" value="79">Germany</option>
</select>

js ---
const element = document.getElementById('country');

const choicesOptions = {
	allowHTML: true,
	searchFields: ['data-customProperties'],
	fuseOptions: {
		shouldSort: true,
		matchAllTokens: true,
		findAllMatches: true,
		ignoreLocation: true,
		threshold: 0.4,
		includeScore: true,
		distance: 100,
		maxPatternLength: 32,
		minMatchCharLength: 1,
	},
	classNames: {
		containerInner: element.classList.toString(),
	},
}

const choices = new Choices(element, choicesOptions);

Expected behavior
When i search for Deutschland, the Germany option should appear for me to select !
**Desktop **

OS: Windows 10
Browser Chrome
Version Latest version

I managed to fix this but after 2 days of debugging.
After i fixed this, it was the time to add an image in there so i had to rewrite the code and actually not adding the options from the HTML, it must use the json data, so i did that the images worked, but when I begin to search, all the images were loaded each time a new character added to the search. typing a character frezed my browser for 5 seconds with 300 options LOL.
Im back to select2 :(


Support Babel 7

Closes #75
Replacement for #80
Note: this is a breaking change because of the dropped support for ember-cli-babel@6

It looks like something is introducing both decorators and decorators-legacy again... 😡

Closing; I think it's going to be easier to start over on the new, simplified version instead.

Hey, thanks for your work on this.  I was curious to see how this worked in our app, and while everything builds, components throw an error:
An element descriptor's .kind property must be either "method" or "field", but a decorator created an element descriptor with .kind "undefined"

If this isn't related to your work here, then please disregard.  Just wanted to bring it up in case it was helpful.

Yeah, I'm going to work on that error!
The problem is that @ember-decorators/babel-transforms now uses the stage-2 decorators proposal, and this repo currently targets the stage-1 proposal. If your'e using babel-transforms@3 then you'll see that error!
I'm working on a total re-write of this addon at #83, which will include making the decorator work with the stage-2 decorator proposal and Babel 7.


Dependency between userspace and memory protection features

Describe the bug
On this file: https://github.com/zephyrproject-rtos/zephyr/blob/master/include/app_memory/mem_domain.h#L30
It should be CONFIG_USERSPACE instead of CONFIG_MEMORY_PROTECTION.
This issue force to enable CONFIG_MEMORY_PROTECTION  to use userspace feature whereas they shouldn't be dependent (Kconfig and CMakeLists files going this way).

@nashif Can you assign it to me please, I will add the fix in this PR: https://github.com/zephyrproject-rtos/zephyr/pull/27063

#29811

Is it possible to have permissions for modifying "linked pull requests", "assignee", "label" of my own PR / issue ?


Users/torivara/virtual network gateways update

Change
Virtual Network Gateway with ExpressRoute type will not work if Public IP is set as zonal and gateway is set as regional. This means that the default settings will fail in some cases because PIP is zonal and gateway is not. Only tested with Express Route Gateway.
The proposed change is an update to the default value of publicIpZones and a conditional setting of zones on the automatically created pip.
Maybe this module should also support already existing pip-resources?
Type of Change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

Checklist

[x] I'm sure there are no other open Pull Requests for the same update/change
[ ] My corresponding pipelines / checks run clean and green without any errors or warnings
[x] My code follows the style guidelines of this project
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation (readme)
[x] I did format my code

Resolved a conflcit for you


[Issue]: Picklist Formatting in Treasury Report

Why is this issue important?
Treasury portal is not accepting picklist values that include the number of the picklist selection, so we need the treasury report we generate to reflect this.
Current State
Several picklist fields include values that reflect a numbered list (i.e. "7. Other") and the treasury report reflects the full value. However, when uploaded to treasury portal, this will generate an error and partners need to manually change the selection to remove the number, period, and space at the beginning and submit the value as "Other".
Expected State
The treasury report needs to have all picklist values that have a number list display the value without the appended number(s), period, and space.
Picklist fields with numbered values:
Project_Status__c
Technology_Type_Planned__c
Technology_Type_Actual__c
Type_of_Investment__c
Implementation Plan
The following functions need to be added...
Relevant Code Snippets
No response

Note - discuss whether it's a better approach to update the picklist values in the workbook and upload validation or just update the treasury report to remove the number, period, and spaces at the front of picklist values.

confirmed with Aditya - these can be updated in the treasury report only and no input template update needed.


HI EVERYONE PRO im new to powershell.. i done everything but still have error.. anyone can guide?

Try
. \chia_plotter.ps1
Or add the folder with the script to your path environment variable.


Make this vscode independent

Would it be possible to make this a vscode independent language server, so that any editor supporting LSP could take advantage of it?

I tried using the server with another client and it worked fine, apart from it only started when the extension of the file was .js. Could this check be removed perhaps?

@mpickering could you be a little bit more specific which check you mean.
The thing that we need to generalize is the language registration in the document selector to make this work for languages different than JS / TS
		let documentSelector: DocumentSelector = [
			{ scheme: 'file', language: 'typescript', exclusive: true } as any,
			{ scheme: 'file', language: 'javascript', exclusive: true } as any
		];

I don't know the precise way to achieve this but it seems the server should start when there is a lsif.json file regardless of the language? So I had to modify the two places you indicated and also the activationEvents attribute.
https://github.com/mpickering/vscode-lsif-extension/commit/82f4352b2271eac81681e3657bf81c1a879dd727

I see your point. One way to achieve this is to bundle the source code as well and use a FS provider to serve them.

I tried a couple of changes to generalize the language registration, and it works in a proof-of-concept:

Use workspaceContains activation event to look for an lsif.json file
Register documentSelector for * language

Would be great to have this as other language servers add support for LSIF, and use this extension to test their changes.
The commit is available for a review here: https://github.com/arjun27/vscode-lsif-extension/commit/40002758d13bb70ed76fd54f36142a98d7b11fac

I worked on a new extension model which basically does the following:

the dump will contain the file content as well
the extensions servers the file content from the dump
will add its own file schema (lsif). This has the big advantage that the extension is full language agnositic and will work wth dumps for every language (C#, TS, ...) out of the box.

I will push the changes in the next couple of days. Still need to do some cleanup


How to receive data from NFC devices

I'm trying to use one device to share a message to another device over p2p.
In the description of the repo, it says I can use this plugin to "receive data from NFC devices".
What function do I call to do this? I went through all the available functions and could only find the function nfc.share, which sends a message over p2p, but doesn't seem to receive one.

Use nfc.addNdefListener to receive messages. A NDEF message sent from a peer works like reading a NFC tag.


fix deepgram and playht has white noise from begining of cache audio

@davehorton pls merge this PR, it's working fine

@xquanluu does this change require any changes in the streaming tts modules?  Or is it standalone?


VLAZ: Watch meathousegourmet.com

VLAZ requests the watch of the watch_keyword meathousegourmet\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

meathousegourmet\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by cigien in Charcoal HQ


First bug

Upon using method "Mouse.Hit/target" in Blox Fruit (executor: script-ware)

Cannot click or use any special moves
Once the script is disabled I can use click but not my special moves

Here's a video showcasing the bug
https://streamable.com/y1n72s

This bug of averiias not working on blox fruits started happening after the latest update of averiias it worked fine before , can you do a version of the old script to be available for us? it s less complicated , and another suggestion could please add an option to aim at the legs of the character too? it would be helpful.

mouse.hit should work now, if it doesnt contact me on discord ave#6717


Support for react-dnd v16?

React-dnd v16 was released a couple weeks ago with support for React 18 https://github.com/react-dnd/react-dnd/releases/tag/v16.0.0. I've been using it with this library and so far it seems to work OK. However, this package says it is invalid.
One issue I've had, for anyone on Next.js v12: using next-transpile-modules was not enough to compile react-dnd and react-dnd-scrolling. I had to either add this to my next.config or stick with react-dnd v15, and I don't know why:

module.exports = {
   ...
   experimental: {
      esmExternals: 'loose'
   }
};

@mattcasey can you try<EMAIL_ADDRESS>

Works now, thanks @ttt43ttt


Add workflow for building and publishing module

Based on @matsest request in #1
Downloading dependencies, building the module and publishing using GitHub Workflow add transparency on the process (and reduces manual boring work).

More or less working now :)
Sorry for spamming you in all failed releases @matsest


Enable multiline model threshold preference

Gives the user the ability to specify their multiline vs. singleline preference via multilineModelThreshold prop.
// Multiline model threshold. 0-1, higher = more single line, lower = more multiline,
// 0.0 = only_multiline, default is 0.5

CC = @pavanchitta @mraheja

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Borders

Could you add bright borders to icons with dark backgrounds? It is hard to see them with macOS dark theme.

Could you add bright borders to icons with dark backgrounds? It is hard to see them with macOS dark theme.

Hi, can you provide an example? (es: screenshot)

Here - right icon stands out better, especially when you work with monitors that  have low contrast

@andynameistaken I'll try this weekend and see what I can do.


Is this project alive?

It's got bugs up the wazoo

Problems should have been fixed now, please test & reopen if there are still issues.


no-deprecated: module level

detect @deprecated in the first doc comment in the body and if found, report entire import as deprecated.

Is this a special rule or global behavior? Personally I’m interested in not allowing arbitrary comments to affect the semantics of how a module is linted :-)


”Tansa” is listed in the drop-down menu

Description:
"Tansa" is listed in the drop-down menu alongside its corresponding county and commune, according to the law.
Precondition:
The website is up an running.

Step 1
Type "Tansa" in the search bar.

Expected results
The location is listed in the drop-down menu as "Comuna Tansa, IAȘI".


Testimonials ReCreated

fixes #153
https://github.com/user-attachments/assets/8c4a5f5f-8894-4eef-b577-b30370aa44ed

@vaishnav-3 make the transistion smoother add automatic scrolling of cards and make it square that looked better

Ok, i will work on that


Unable to rsync if ssh root-login has been disabled

Hi,
Thanks for making a great plugin. We have however run into a small issue when trying to run duplicates of our prod-setup with Vagrant. Please see devopsgroup-io/vagrant-hostmanager#210 for a detailed explaination, as more or less the same issue exists there.
Would it be possible to use some other mechanism for authentication once provisioning is done and root-login has been disabled?

Christopher,
Ultimately, I'm just calling to the rsync system already in Vagrant core and I don't really want to change that if I can help it, so it might be worth opening an issue on Vagrant core.

Thank you for the feedback. I'll see if they have any ideas.


NetImGui thinks it's connected when it isn't

Describe the bug
I noticed that ImGui wasn't drawing in my application, and eventually tracked it down to NetImGui return "true" for IsDrawingRemote.  It seems that this only returns "true" if the API thinks it's connected.
To Reproduce
Steps to reproduce the behavior:

Launch application
Turn on an imgui menu
Notice that it isn't drawing
Inspect logs which are printing result if "IsDrawingRemote" - it's true, even though the server isn't turned on.

Expected behavior
IsDrawingRemote() only returns true when the server is connected and is drawing.
Screenshots
no screen shot
Desktop (please complete the following information):

OS: windows 10

Additional context
The thing I can't explain is that this only happens in a 'release' build of my app, not in debug.  I've checked netstat and i can see my app listening on port 8889 but no connection has been established (in both the working case and broken case).  I'm using a release version of NetImGui in both cases, so I'm not sure what's going on.  When I do connect the remote server, I see my imgui drawing (in both the broken case and working case).
Is there something I can do further to debug this or provide more information?

Thanks. If this doesn't happen in debug but happen in debug, my first guess would be that there's a variable that's missing a proper init (debug zero out variable by default, not release).
I currently m unable to investigate this month, but I will take a look when I get my PC back. It should not be too long to fix.
If you wish to investigate it yourself, you can always check what variables are used to return IsDrawingRemote, and see which one might be missing a init after instantiation.
This is after you have called init on NetImgui library, right?

Hi,
Thanks for the quick response.
I think it must be something in my setup.  I wrote a C binding and it must be mangling the return type somehow (not sure why).  The debugger says that netimgui is returning false (as expected), but for some reason on the other side my code sees it as "true".
I'll close the bug, as this is clearly in my code.

I never tested the library under c. You might need to add the C calling convention code to the API header.
Something along these lines (needs to be tested).
ifdef __cplusplus
extern "C" {
#endif

// normal API function declarations here

#ifdef __cplusplus
}
#endif


Move common/colors.go into pkg/color

This change is

test-me-please

test-me-please

Since we use this in so few places, would it be simpler to remove it outright?

Remove the colors from CLI?!  :scream:

Remove the colors from the CLI?! 😱

The alternative is to go all out, and use it everywhere!!!! (you could have green for the ready state, yellow for regenerating, orange for waiting-for-identity)... We can even stick the output into the CEPs so when you dump to console the yaml has colour :P

test-me-please

test-me-please

The alternative is to go all out, and use it everywhere!!!!

I'm waiting for pkg/emoji to appear


language evolution: "optional" should be a keyword

"@optional" being a mere annotation presents difficulties, obstacles, problems, and roadblocks for compiler developers.
If it were a keyword, then it would be clear that skipping it is non-optional, pun fully intended.
This would be a backwards-incompatible change, of course.  Furthermore, dropping support for "@optional" would be even more backwards-incompatible.  Therefor, I propose a multi-stage solution...

language version 'n': add "optional" to the spec., make it mean the same thing as "@optional", make the Open Source compiler warn when old-fashioned "@optional" is found (e.g. WARNING: this syntax is deprecated...  please alter your code to use the new-in-P4₂₃ keyword "optional".　　Support for "@optional" will be removed in the next language version.) and recommend that other P4 compilers with support for language version 'n' do the same.
language version "n+1": remove support for "@optional" from the spec., make it clear to all developers of P4 compilers that  when their compiler "sees" "@optional" when in {language version "n+1" mode} it should error out with a clear error message telling the user what is wrong with the P4 code and what (s)he could do about it (i.e.: either replace "@optional" with "optional" everywhere in the P4 code, or... compile in an older mode, e.g. P4₁₆, if still supported by the respective compiler).

Unfortunately, optional is already a match_kind in V1Model architecture. So if we add it as a keyword (and don't do something special in the front-end) we would break one of the most widely used architectures.

In hindsight, it seems like using the word optional for both @optional annotation and the name of a match_kind might not have been a great idea, but perhaps that is water under the bridge now?
Perhaps @Abe149's two-step plan could use some syntax other than adding the prefix optional as the replacement of @optional?

Does anyone still feel strongly about this? If not, should we close it?

Given the silence, I'm going to mark this as closed.


fix(client/electron): ssconf:// links break when adding the key through browser in Electron clients.

This is due to a bug in removing trailing slash that removes all of the slashes of the URL.
For example:
ssconf://cool.url.com/a/b/c would become ssconf://cool.url.comabc which effectively breaks the dynamic server config URL.
This issue needs to be fixed since it broke the functionality of ssconf:// links entered from browser.
Changed substr to substring since substr was deprecated.

Shortened the title to pass the check.

Thank you for your contribution @khantzawhein!
Ideally we pull this logic out into a utility function so we can properly test it. We can do that in a future PR. I'll merge this.


Implement User Limit for Active URLs

Description
Limiting Active URLs per User: To prevent potential misuse and ensure fair distribution of resources, we might consider imposing a cap on the number of active URLs a user can generate and maintain simultaneously.
Screenshots
No response
Additional information
No response

Great idea!
I will assign you to it 💯

If this issue is still open can i try working on this ?

@shlomots
Are you still working on it?

Can someone check if this issue is still relevant?

Hi everyone,
I'm open to work on this, I just need more explanation about this feature

@origranot Can you help @essofyany with it?

Hi everyone, I'm open to work on this, I just need more explanation about this feature

We would like to limit users to create only up to X number of links.
But I think this issue is blocked by: https://github.com/origranot/reduced.to/issues/640.

Hey @origranot , I can take the issue.
is there a certain limit on which we want to impose?

Hey @origranot , I can take the issue.
is there a certain limit on which we want to impose?

Awesome!
We can start with 10 active links at all time.
Also it would be great if we can show the limits in the settings page.


checkperiod only trigger once?

I tried following code, but seems only show "A:1 is expired", "A:2" never be show
var myCache = new node_cache( { stdTTL: 50, checkperiod: 20 } );
myCache.set("A:1", Code, 10);
myCache.set("A:2", Code, 25);
myCache.on("expired", function( key, value ){
console.log(key + " is expired");
// ... do something ...
});
How can make it run the expired check by interval?

probably your script will just end before your defined ttl's expire.
i use .unref() to prevent node-cache from blocking your script to exit.
So if your script ends teh process will stopped.
You can just run your own timeout like this example:
var node_cache = require("node-cache");
var myCache = new node_cache( { stdTTL: 50, checkperiod: 2 } );
myCache.set("A:1", 123, 5);
myCache.set("A:2", 456, 10);

myCache.on("expired", function( key, value ){
  console.log(key + " is expired");
  // ... do something ...
});
console.log( "waiting ... " );

// add a timeout to prevent the script to exit
setTimeout( function(  ){
  console.log( "exit" );
}, 15000 )

See working example here: https://runkit.com/mpneuried/58576ddb558ed60013d25574

Yes, I put the code to runkit is work well, but it is doesn't work on my 2 linux machine, Do you try the code on real machine?
Ubuntu 14.04 x64
node-cache 4.1.0

i tested some environments with docker.
The only case i found your problem is ubuntu:14.04 with node v0.10.25.
Which Node version do you use?
-------------
Docker Test (FROM node:0.10)
-------------
Node Version: v0.10.48

waiting ...
A:1 is expired
A:2 is expired
exit

-------------
Docker Test (FROM node:0.12)
-------------
Node Version: v0.12.17

waiting ...
A:1 is expired
A:2 is expired
exit

-------------
Docker Test (FROM node:4.2)
-------------
Node Version: v4.2.6

waiting ...
A:1 is expired
A:2 is expired
exit

-------------
Docker Test (FROM node:5.0)
-------------
Node Version: v5.0.0

waiting ...
A:1 is expired
A:2 is expired
exit

-------------
Docker Test (FROM node:5.4)
-------------
Node Version: v5.4.1

waiting ...
A:1 is expired
A:2 is expired
exit

-------------
Docker Test (FROM node:argon)
-------------
Node Version: v4.7.0

waiting ...
A:1 is expired
A:2 is expired
exit

-------------
Docker Test (FROM node:latest)
-------------
Node Version: v7.2.1

waiting ...
A:1 is expired
A:2 is expired
exit

-------------
Docker Test (FROM mhart/alpine-node-auto:4)
-------------
Node Version: v4.7.0

waiting ...
A:1 is expired
A:2 is expired
exit

-------------
Docker Test (FROM mhart/alpine-node-auto:6)
-------------
Node Version: v6.9.2

waiting ...
A:1 is expired
A:2 is expired
exit

-------------
Docker Test (FROM mhart/alpine-node-auto:7)
-------------
Node Version: v7.2.1

waiting ...
A:1 is expired
A:2 is expired
exit

-------------
Docker Test (FROM ubuntu:14.04)
-------------
Node Version: v0.10.25

waiting ...
exit

-------------
Docker Test (FROM ubuntu:14.04)
-------------
Node Version: v4.7.0

waiting ...
A:1 is expired
A:2 is expired
exit

-------------
Docker Test (FROM ubuntu:16.04)
-------------
Node Version: v4.2.6

waiting ...
A:1 is expired
A:2 is expired
exit

-------------
Docker Test (FROM ubuntu:16.10)
-------------
Node Version: v4.2.6

waiting ...
A:1 is expired
A:2 is expired
exit

I tried update nodejs to v6.9.2, it is work well, but it is not default for Ubuntu apt-get install, so I look into the code of node-cache, the checkTimeout without parameters, so default parameter will be 0 on nodejs 0.10.25, cause startPeriod = 0 on 2nd time, it is will not create timeout again when trigger once
NodeCache.prototype._checkData = function(startPeriod) {
this.checkTimeout = setTimeout(this._checkData, this.options.checkperiod * 1000);

change to
NodeCache.prototype._checkData = function(startPeriod) {
this.checkTimeout = setTimeout(this._checkData, this.options.checkperiod * 1000, startPeriod);

it is work well on nodejs 0.10.25
I guess nodejs 6.9.2 timeout event will bring current parameter into, but maybe we should specified it

I added your fix to 4.1.1 and tested it against a bunch of versions and environments.
Thanks


Fixed avx512 batch for int16 selection

Fixes #320 for real

So the split does what we were hoping wrt duplication?

The split simply extracts the higher and the lower parts, without changing anything.
However, every comparison intrinsics operating on batches of X bits integers returns a mask where contiguous blocks of X bits are set to the same value and I think it is reasonable to assume that any function returning a mask should have similar behavior.


Hex literal

Its often convenient to declare some large byte string that is not in the ascii range, this allows a 0x... literal declaration for bytes
const bytes bignum = 0xffffffffffffffffffffffffffffffff

needs docs

I have always used byte escapes for this "\xDE\xAD\xBE\xEF". I thought raw bytes usage wouldn't be common enough to warrant special handling of this but both you & @pbennett want this. I'm ok with this. It's probably easier to read if you know some particular hex byte sequences.
Would you plan to add all of these formats though? https://developer.algorand.org/docs/get-details/dapps/avm/teal/specification/#constants-and-pseudo-ops
Also do we want to support this format for int too? e.g const int TOTAL_SUPPLY = 0xffffffffffffffff

Would you plan to add all of these formats though? https://developer.algorand.org/docs/get-details/dapps/avm/teal/specification/#constants-and-pseudo-ops

Not unless there is a very good reason, hex ought to be enough to get bytes in a const

Also do we want to support this format for int too? e.g const int TOTAL_SUPPLY = 0xffffffffffffffff

Maybe yes but probably no since an actual integer can be used. I think that notation is more suited for the bigint proposed in #56

I have always used byte escapes for this "\xDE\xAD\xBE\xEF". I thought raw bytes usage wouldn't be common enough to warrant special handling of this but both you & @pbennett want this. I'm ok with this. It's probably easier to read if you know some particular hex byte sequences.

Does Tealish actually support this??  It definitely isn't documented if it does.  I still prefer the explicit hex over \xFF per-byte escaping though - particularly for blobs of bytecode where I have it now.


Authenticate through aws cognito

My issue is similar with this: https://github.com/domaindrivendev/Swashbuckle.AspNetCore/issues/1128
I tried to use the configuration in above issue.  Adding extension of "id_token" does not solve the problem. I can get access token and id token from the redirect url. The flow works perfectly. But how can I use returned id_token instead of access_token?
 var securityScheme = new OpenApiSecurityScheme
                {
                    Type = SecuritySchemeType.OAuth2,
                    Reference = new OpenApiReference { Type = ReferenceType.SecurityScheme, Id = "oauth2" },
                    In = ParameterLocation.Header,
                    Extensions = new Dictionary<string, IOpenApiExtension>
                    {
                        { "x-tokenName", new OpenApiString("id_token") }
                    },
                    Flows = new OpenApiOAuthFlows
                    {
                        Implicit = new OpenApiOAuthFlow
                        {
                            AuthorizationUrl = new Uri(configuration["AppSettings:Cognito:AuthorizationUrl"]),
                            Scopes = new Dictionary<string, string>
                            {
                                {"openid", "OpenId" },
                                {"profile", "User Profile" },
                                {"email", "User Email" },

                            }
                        },

                    }
                };
  c.AddSecurityDefinition("oauth2", securityScheme);

                c.AddSecurityRequirement(new OpenApiSecurityRequirement()
                {
                    {securityScheme, new string[] {} }
                });

I am having the exact same issue, id_token is not being used.

Closing as external.


⚠ Bofrost.fr has degraded performance

In f8436cc, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1082 ms

Resolved: Bofrost.fr performance has improved in 2f0899b after 13 minutes.


Feature Request - Prometheus Integration

Is your feature request related to a problem? Please describe.
N/A
Describe the solution you'd like
Please reference https://discuss.opendistrocommunity.dev/t/feature-request-prometheus-integration/4073
A somewhat popular use-case for Elasticsearch, and other time-series data stores, is long term metric storage of metrics gathered by Prometheus.
See “Prometheus Integrations” for some examples: https://prometheus.io/docs/operating/integrations/
In particular, Elastic supports gathering Prometheus-gathered metrics via the remote_write feature in metricbeat: https://www.elastic.co/guide/en/beats/metricbeat/current/metricbeat-metricset-prometheus-remote_write.html
That said - many of the aforementioned solution patterns do not support remote_read, nor do they have a way to continue to query the data using PromQL, the Prometheus querying language.
I would like to request three features to promote OpenDistro as a premiere datastore for Prometheus collected metrics.
Feature 1:
Add native support for PromQL and the querying api.
This feature could likely be largely cloned from Prometheus source code - which is licensed under the Apache License 2.0 license. There would likely need to be adjustments to accommodate index schemas, security features, and obviously using Elasticsearch as the datastore instead of the normal Prometheus database.
Feature 2:
As part of the Feature 1, you would likely need to create a Prometheus remote_read adapter.
It would be beneficial to the community if this adapter were made more generic, and separately available, thus allowing generic Prometheus to use OpenDistro via the remote_read adapter.
This should help better promote OpenDistro among the Prometheus community and should help drive adoption of OpenDistro as a long term metric store.
Feature 3:
While there are a number of ways data could get pipelined to OpenDistro from the Prometheus ecosystem (eg. the metricbeat method described above), to really push OpenDistro ahead, it should directly support ingestion of metrics via Prometheus’s remote_write mechanism.
Describe alternatives you've considered
N/A
Additional context
N/A

Thanks @ryn9 We are looking into this requirement and will get back to you once we have updates.

Many thanks. I look forward to hearing from you.

@vrphanse is there any more details you would like to help provide clarity for this request?

sorry to ask again - @vrphanse is there any more details you would like to help provide clarity for this request?

Here is how bitnami handle it
https://github.com/bitnami/charts/tree/master/bitnami/elasticsearch

Here is how bitnami handle it
https://github.com/bitnami/charts/tree/master/bitnami/elasticsearch

Forgive me - I do not see how what was shared here applies ...

they have metric part. You can just roll yours just like it. If Open distro works like elasticsearch, it should work. I am using eck and they don't have metric part either. And bitnami's exporter works perfectly with eck.


Using the alias-domains option results in error

This is my deploy step:
- name: Deploy to Vercel
  uses: amondnet/vercel-action@v25
  with:
    vercel-token: ${{ secrets.VERCEL_TOKEN }}
    vercel-org-id: ${{ secrets.VERCEL_ORG_ID }}
    vercel-project-id: ${{ secrets.VERCEL_PROJECT_ID }}
    scope: ${{ secrets.VERCEL_ORG_SLUG }}
    github-token: ${{ secrets.GITHUB_TOKEN }}
    vercel-args: 'deploy ./apps/my-app/dist/'
    alias-domains: {{BRANCH}}.${{ secrets.VERCEL_PROJECT_URL }}

However, the alias command apparently is called too soon:

How can I alias after deploying?

My bad, I was using subdomains as alias
{{BRANCH}}.${{ secrets.VERCEL_PROJECT_URL }}

Instead, this works
{{BRANCH}}-${{ secrets.VERCEL_PROJECT_URL }}


ctrl+[ doesn't acts as "esc" in vim mode

Describe the bug
If I enable vim keybindings in Marimo, then I can't use ctrl+[ as an alias for esc. However, it should technically be supported: https://vim.fandom.com/wiki/Avoid_the_escape_key
Environment
{
"marimo": "0.8.7",
"OS": "Linux",
"OS Version": "<IP_ADDRESS>-microsoft-standard-WSL2",
"Processor": "x86_64",
"Python Version": "3.12.4",
"Binaries": {
"Browser": "--",
"Node": "v20.16.0"
},
"Requirements": {
"click": "8.1.7",
"importlib-resources": "6.4.4",
"jedi": "0.19.1",
"markdown": "3.7",
"pymdown-extensions": "10.9",
"pygments": "2.18.0",
"tomlkit": "0.13.2",
"uvicorn": "0.30.6",
"starlette": "0.38.4",
"websockets": "12.0",
"typing-extensions": "4.12.2",
"ruff": "0.6.3"
}
}
Code to reproduce
n/a 😉
So I'm going to use this space to say - I friggin' love Marimo, thank you so much for the work you're doing here 🙏 😍

Duplicate of https://github.com/marimo-team/marimo/issues/558
I was unable to repro on mac (my dev setup) so I couldn't get a proper fix in. We can take another look, though.


remove missing imports warning

❯ checking dependencies in R code ... WARNING
  '::' or ':::' import not declared from: ‘htmlwidgets’

0 errors ✔ | 1 warning ✖ | 0 notes ✔
Error: R CMD check found WARNINGs
Execution halted
The terminal process "Rscript '-e', 'devtools::check(error_on = 'warning')'" terminated with exit code: 1.


[pem] Support creating JWT-signing keys (.p8 files) in pem

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I have read the Contribution Guidelines

Issue Description
Re-opening #7848 -- @ohayon there are so many benefits to using the new P8 format over the old one, please consider implementing

Hey @vbresults, thanks for bringing up this feature request again, this sounds very interesting. I haven't used the new system myself, so I don't know too much details about it. You don't have to renew the key every year, right? So it's a one-time task for an app, instead of a yearly one? Why do you want to automate it? Do you have a high number of apps, that would need to be setup (including push) automatically using fastlane?
This will give us a better understanding of the uses of the feature 👍 Thanks

@KrauseFx Yes to all, quite a high and growing number of apps, spread across different accounts, and not far away from hitting the 100 mark (:

This would be useful for us too. We have some people putting apps together with fastlane / Jenkins that never need to touch the dev centre :)

@ohayon Any progress on this?

Can this issue be closed since https://github.com/fastlane/fastlane/pull/9560 has landed? (Thanks for the PR @snatchev!)

@ide it's just hit spaceship, not PEM yet though?

Ah ok, I didn't realize it wasn't wired up to pem yet.

@ide @vbresults we had some thinking to do where this functionality belongs, and if pem was the right tool for it. We decided that, at least for now, it should go in pem. I am hoping to have it wired up soon.
In the meantime, you may be able to automate some work by using spaceship directly.
$ bundle exec fastlane spaceship
after you login...
key = Spaceship::Portal::Key.create(name: 'My New Push Key', apns: true)
File.write('push-jwt.p8', key.download)

NOTE: keys can be downloaded only once from the developer portal. If you lose it, you must re-create the key. You can only have 2 keys provisioned at any given time.


Switching away and back to a tab causes folding to be lost and reanalysed

Environment data
latest of everything
dotnet --info output: 6.0.200
VS Code version: 1.65.0
C# Extension version: 1.24.1
linux ubuntu
OmniSharp log
n/a
Steps to reproduce

Open a cs file, wait for folding to appear
Switch to different tab
Switch to original tab

Expected  behavior
Folding info to still exist in the original document. To be able to use the folding triangles (in the gutter).
Actual behavior
The document's folding info is gone. Any blocks that were folded remain folded, but the folding marks in the gutter are gone. It take some time for the document to be reanalysed - sometimes a loooong time - and only then it becomes usable again.
In older versions it used to be that when a document was fully loaded, switching to a different tab and then switching back, did not cause anything to be lost. The document was only loaded once.

Cannot reproduce with current release.


Installation fails on Ubuntu 16.04 and Ubuntu 18.04

Followed the installation instructions for manual installation from here - https://docs.microsoft.com/en-us/powershell/scripting/setup/installing-powershell-core-on-linux?view=powershell-6#ubuntu-1804
Installation fails with the following error
install errors: dpkg: dependency problems prevent configuration of powershell:

powershell depends on liblttng-ust0; however:

Package liblttng-ust0 is not installed.

dpkg: error processing package powershell (--install):

dependency problems - leaving unconfigured

Errors were encountered while processing:

powershell

failed to run commands: exit status 1

Failed to install package; install status Failed

Even though installation fails, PowerShell Core is installed on the machine. This behavior repros on both Ubuntu 16.04 and ubuntu 18.04

@SteveL-MSFT This was using an Amazon Linux EC2 VM. Please let me know if you need more information,

@datenteiler Running sudo apt -f install doesn't fix it.   It uninstalls the package.
Output of sudo apt -f install
Reading package lists... Done
Building dependency tree
Reading state information... Done
Correcting dependencies... Done
The following packages will be REMOVED:
  powershell
0 upgraded, 0 newly installed, 1 to remove and 0 not upgraded.
1 not fully installed or removed.
After this operation, 158 MB disk space will be freed.
Do you want to continue? [Y/n] Y
(Reading database ... 51834 files and directories currently installed.)
Removing powershell (6.1.1-1.ubuntu.16.04) ...
Processing triggers for man-db (2.7.5-1) ...

@Indhukrishna best I can find, only Amazon Linux 2 supports .NET Core and PSCore6 (https://aws.amazon.com/about-aws/whats-new/2018/03/announcing--net-core-ami-for-amazon-ec2/).  I don't know the differences between Amazon Linux and Amazon Linux 2.

Solution: sudo add-apt-repository universe

I saw this issue recently when trying to download v7.0.0-rc.2 with Ubuntu 18.04 on WSL. Seem to have fixed the issue after running the following:
sudo apt-get update
# install the requirements
sudo apt-get install -y \
        less \
        locales \
        ca-certificates \
        libicu63 \
        libssl1.1 \
        libc6 \
        libgcc1 \
        libgssapi-krb5-2 \
        liblttng-ust0 \
        libstdc++6 \
        zlib1g \
        curl


Update test instructions to dkpy2

@tcr3dr Tests docs updated. Only problem is that nosetests dronekit.test.sitl and nosetests dronekit.test.unitgive me result Ran 0 tests in 0.000s in Vagrant. Tests ran in Windows environment as expected.
Can you advise?

not sure about the vagrant part, but tests run fine here locally.
lgtm


Prompt users to create a new PR after pushing to a new branch

As a user, I would like to see a prompt on the home page or repository page to create a new PR if I recently pushed to a new branch for which no PR exists yet so that I save clicking on the "new PR" button on the repo page.
This could be done purely through the db without any git calls since we already have all the data in the action table.
I think we can always assume the user has the rights to create a PR if they have the right to push to a new branch in that repo, so no need to check that.
We would just need another check if the repo pushed to is a fork to check with the head repo if a PR exists there and not in the fork repo.

This is duplicated with #311

I'm working on this.

Let's close #311 .


:wheelchair: provide user friendly error messages

A more user friendly message could help user realize that they have not gotten any installed yet. So they should be able skip them or retry.
https://github.com/chenjiandongx/pyecharts/issues/105, https://github.com/chenjiandongx/pyecharts/issues/102

I'm not sure of the state of this repo, happy to see fixes come in though.

The updated behavior is:

if jupyter is installed, nbextensions will be installed
otherwise, no installation and no exception, hence the whole setup won't abort.
User need to specify '-v' upon installation to see the added user friendly message. due to this reason here:  https://github.com/pypa/pip/issues/2933

SGTM - I can publish this later. I don't have auth to from here.

Thanks for the update and quick response. A lot of open source users are facing the same issue but we have provide a workaround. I look forward to your next release.

✔ This is published as 0.3.1

I think pyecharts users will be made very happy by your release too.


Amazon MTurk

Thanks for this great implementation!
Is it possible to use it in Amazon MTurk?

@simonMadec Yes, it should be possible. Everything is implemented in Javascript. Just need to make sure workers understand the task.

@kyamagu Or do you know any self contained javascript code for image segmentation which i can directly use on mturk. I can use labelme for license issues. I currently use vgg but dont know how to port it to aws


derive(Debug) enum fixes

fix: Add Debug to derived traits on Rust side even if one of the variants has data to hopefully avoid confusing the developer
fix: don't generate Debug functions in C header and Swift if any variants have data to avoid confusing the developer with undefined symbol build errors

Previously, this would cause a "undefined symbol" build error and cause the error not to implement Debug trait from Rust:
#[swift_bridge::bridge]
mod ffi {
    #[derive(Debug)]
    enum DeriveDebugEnum {
        Variant(String),
    }
}

When generating C headers and Swift, there was no check to ensure that the enum has no variants with data, but this check was added when generated Rust tokens. This causes undefined symbol if a variant has data since C and Swift thinks the method exists, but it actually doesn't.
This PR fixes the undefined symbol error and also makes the enum implement Debug, even if only from Rust.

Hey, thanks for working on this.
Mind updating your PR to more clearly explain the problem and how this PR solves the problem, as well as to include an example bridge module that illustrates what this PR enables?
Thanks!

Added!

@chinedufn sorry to bother you, any chance of this being merged?

Can we add some tests?

What tests need to be added?

@junepark678 You could add my branch as a dependency to use it early. I'll sync up the branch

Is there anyone interested in picking up this PR? I am not actively working on anything that depends on swift-bridge and finishing this up seems like a lot for something that was intended to be a quick fix for a bug.
As for the error message, it's just ld or the Swift compiler saying it can't find a symbol that some swift code needed.

@chinedufn
https://github.com/chinedufn/swift-bridge/pull/209#issuecomment-2290199332
May I take over this PR if no one addresses this by next week?

Absolutely, feel free. Thanks.


BUGFIX: Hide help button

Explanation of Bugfix/Feature/Enhancement:
Fixed bug that prevented the help button from being hidden when feature is first turned on (tried calling hide() when the element didn't exist on the page yet). Stored user’s visibility preference in local storage so setting can be saved between sessions.
Fixes https://forum.youneedabudget.com/discussion/53381/hide-help-button-option-not-working-for-me

@joshmadewell - Part of the challenge here is that I need to distinguish between true / false / null. I need a null response to indicate that the local storage item doesn't exist, so that I can add it, because when this feature gets first turned on, I'd like to set the value to true. I don't want simply a true/false response, because then I can't distinguish between a "false" from someone who has the button enabled, and a "false" from someone who just turned on the feature and likely wants it hidden by default.
I'll remove the check for an undefined variable, as I agree that isn't necessary, but I think I need to keep the saved setting value as a string rather than as a boolean unless I also want to change how the getToolkitStorageKey() works with booleans.

I'll go ahead and merge this for now. If we want to change that in the future we absolutely can.


Cursor jumps to time in date time picker

Bug Report
Description
When using select date/ time button and typing in a date, the cursor jumps from month to time or day to time. This is if drop your cursor in the field without clearing the whole date.
https://engineering.cerner.com/terra-ui/components/terra-date-time-picker/date-time-picker/date-time-picker
Steps to Reproduce

Open https://engineering.cerner.com/terra-ui/components/terra-date-time-picker/date-time-picker/date-time-picker
Highlight the date or month
Enter a new date or month
The cursor jumps to the time field

Additional Context / Screenshots

https://cernerprod.sharepoint.com/sites/TerraTimelineIncubator/Shared Documents/General/Screen Recording 2020-06-30 at 08.07.17.mov
Expected Behavior
After you entered the new date or month, the cursor should remain where it is
Possible Solution

Environment

Date Time Picker 4.4.40
Browser Name and Version: Safari
Node/npm Version: [e.g. Node 8/npm 5]
Webpack Version:
Operating System and version (desktop or mobile):

@ Mentions

@gerard-isdell There is logic that automatically moves the focus to the time input once the date input has a valid date. If the date input does not have a complete and valid date, the focus would stay in the date input. The purpose of this is to guide the user to enter the date followed by the time without having to manually move.
This is similar to how the time input would jump the focus from the hour input to the minute input once the hour is completed.

@gerard-isdell we do want the cursor to jump as you're entering the field as a convenience; however, right now I do know that things get a little weird with an existing date and updating the month (it'll jump to the time at that point rather than allowing you to update the date as well). We believe this scenario will be fixed when we address https://github.com/cerner/terra-framework/issues/468 which is currently being worked on. It will then jump from field to field automatically (month to date to time). Will that address your concerns?
cc @neilpfeiffer @benbcai

Thanks @gerard-isdell, as @benbcai commented, this is technically performing as designed, but based on your video, I can see why this isn't performing as you might expect.
The current date-picker uses only a single input, so once a fully complete and valid date is detected, in the combined date-time-picker it auto-jumps to the time-input. Which appears to work fine for an empty date input, that only after a full month, day, and year are added it is complete, with year being last to then jump to the time-input. But is odd when only adjusting a month or day in an already complete date.
We have plans to update this internal construction of the date-input section to 3 distinct inputs: one for month, one for day, and one for year -- https://github.com/cerner/terra-framework/issues/468  -- which our time-input is currently constructed in this way and advances between the hours to minutes to seconds. After the separation, we would expect the interaction in your video to change, that after completing a valid month to auto-advance to the day input (assuming for month/day/year localized date format).

Thanks @neilpfeiffer @benbcai - that all sounds fine.

@gerard-isdell if that's the case, I'll close this as a duplicate of #468


Work Around: redmine 2.6 return invalid structure for empty custom field...

...s with multiple values
Known issue: Under the condition:

issue is newly created
custom_field is multi-field
custom_field is set to an empty list or null

Then:

the return structure has "multiple" set
but the value is the empty string

I modified the unittest, to test handling of multi-value custom fields. To do this I modified the test, to check a third custom value (so the redmine instance, this is tested against needs to be modified).
See comment in testCustomFields for the new field.
The unittest not only covers the new work around, but also introduces tests that were requested for pull request #54.

I'll repush (the commit missed changes to the custom field definition test)


Partial Loader Not Interpolating Values On First Page Load

Subject of the issue
I'm making use of the translate directive, partial loader, loader cache, and the gulp-ng-lang2js tool. When I navigate to a page for the first time, the IDs are not interpolated. If leave the page and come back, they will be interpolated. Translation IDs will also be interpolated if I go directly to the page by URL.
This is what my configuration looks like:
$translateProvider
        .useLoader('$translatePartialLoader', {
          urlTemplate: 'i18n/{part}/lang/{lang}.json'
        })
        .useSanitizeValueStrategy('sanitize')
        .fallbackLanguage('en')
        .preferredLanguage('en')
        .useLoaderCache('$translationCache')
        .forceAsyncReload(true);

angular.module("myApp")
  .run(["$rootScope", "$translate",
    function($rootScope, $translate) {
      $rootScope.$on('$translatePartialLoaderStructureChanged',
        function() {
          $translate.refresh();
        });
    }
  ]);

I have pulled $translationCache into my controller and found it does indeed contain the cached table on first load. I am calling $translatePartialLoader.addPart() in the controller. I watch the network tab in Chrome Devtools and verified that no call is made to the server to get the translation table.
Essentially what I am finding is that $translatePartialLoader.addPart() MUST be called before loading the controller and not within the controller, even though I have already cached the translation table.
What is going on?
Your environment

version of angular-translate ^2.12.1
version of angular 1.5.8
which browser and its version Chrome 54.0.2840.90

Steps to reproduce
Working on a Plunker
Expected behaviour
The ID's should be interpolated on first load.
Actual behaviour
The IDs are not interpolated on first load, but are interpolated when returning to the page.

+1!

Hey Naimikan, here's a workaround I found in another issues thread. It's a bit awkward but seems to be working. Basically we now rely on adding translation in the resolve config option of a route declaration. Since $translate.refresh() returns a promise, we can delay loading a page until we confirm the translations have resolved.
It is also recommended that you create a helper service to reduce boilerplate:
(function() {
  "use strict";

  angular.module("app")
  .factory("translationResolver", ["$translatePartialLoader", "$translate",
      function($translatePartialLoader, $translate) {
        return function() {
          angular.forEach(arguments, function(translationKey) {
            $translatePartialLoader.addPart(translationKey);
          });
          return $translate.refresh();
        };
      }
  ]);
})();

Your route declaration will look like this:
  angular
    .module("app")
    .config(["$routeProvider", function($routeProvider) {
      $routeProvider.when("/app/my-page", {
        template: '<my-page></my-page,
        resolve: {
          translations: ["translationResolver",
              function(translationResolver) {
                return translationResolver('i18n/my-page');
              }]
        }
      });

The problem here is that the promise for the language is not reassigned during refresh, so $translate incorrectly reports that the translations are loaded for the table that the partial loader is updating. I have a fix and will post it as soon as I figure out why I don't have permission to push to the repository:

The fix I made for this also causes a regression where the translate cloak directive will not decloak on the first load of a particular part. This is due to a problem in the way the promises from loadAsync are handled in refresh. The $q.all promise resolves after all of the handlers on the individual promise queues, which will always cause determineTranslation to have a cache miss on the first call to $translate after a part is added, this first call being the one from the translate-cloak directive. The fix is to just add the translations call (to update the global table) to each promise queue individually before the q.all promise is established. I'll include this as well with the other fix I mentioned previously. I think I now have two for translate-cloak, two for refresh, and one for the partial loader that together make them behave sanely together. I'll be sure to post them soon; bug me if I don't!

Fix here: https://github.com/angular-translate/angular-translate/pull/1688


How to terminate when the robot falls

I want to terminate when the robot falls out of the box. So I added
    if (gc_[2]<1.0){         return true;     }
in the function
 bool isTerminalState(float& terminalReward) final {
in Environment.hpp, but this doesn't work. And even if I replaced this whole function with return true or return false, it didn't end.
How should I implement this? Thank you.

It shouldn't end. It should reset.


Added withPropChangeHandler

I added a new helper called withPropChangeHandler, which can be used for reflecting to the changes of specified props, including mount and unmount.
My intention to add this was to eliminate the need of component classes, when we need them only for loading and unloading resources based on props (e.g. react router params). When the component does not get remounted, but only the props change I have to include the componentWillReceiveProps method too to handle the transition between pages, which adds unnecessary complexity.
With this helper the transitions can be solved with one function which loads and unloads resources based on the presence and content of the specified props.

Codecov Report

Merging #555 into master will increase coverage by 0.19%.
The diff coverage is 93.33%.

@@            Coverage Diff             @@
##           master     #555      +/-   ##
==========================================
+ Coverage   88.37%   88.57%   +0.19%
==========================================
  Files          49       50       +1
  Lines         370      385      +15
==========================================
+ Hits          327      341      +14
- Misses         43       44       +1

Impacted Files
Coverage Δ

src/packages/recompose/withPropChangeHandler.js
93.33% <93.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c4ac2e...7717661. Read the comment docs.

Thank you. BTW it was better to use search before. Similar helper was proposed a lot of times in the past, and as I remember even at prev week. We decided to not accept it before and having that nothing has changed accept it now.

the same problems as here https://github.com/acdlite/recompose/issues/545#issuecomment-340469880


UNRESPONSIVE extension host with Drizzle, Kysely and a Big Schema

Describe the bug
A clear and concise description of what the bug is.
I am using Drizzle and Kysely together. I have a database schema with nearly 200 tables. I do not define any relation between Drizzle and Kysely. I have select a query with more than 5 inner join tables. When I make some changes to my select, the vs code stops working properly. The windows out put is here.
2024-09-11 14:05:10.822 [info] UNRESPONSIVE extension host: starting to profile NOW
2024-09-11 14:05:15.888 [warning] UNRESPONSIVE extension host: 'yoavbls.pretty-ts-errors' took 100% of 5003.334ms, saved PROFILE here: 'file:///var/folders/7x/rxw2srxn4jzfp15n_f8th2gh0000gn/T/exthost-acaf0e.cpuprofile'
2024-09-11 14:05:48.905 [error] Error: Aborted onWillSaveTextDocument-event after 1750ms
    at vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1873:13070
2024-09-11 14:05:53.950 [error] Error: Aborted onWillSaveTextDocument-event after 1750ms
    at vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1873:13070
2024-09-11 14:06:21.965 [info] Extension host (LocalProcess pid: 38659) is responsive.

Expected behavior
A clear and concise description of what you expected to happen.
Works fine.
Original error
If this bug is related to an error that is not formatting well, please
attach the original error in a code block:

Type 'number' is not assignable to type 'string'.ts(2322)

Screenshots
If applicable, add screenshots to help explain your problem.

Thanks for the report. Do you still happen to have the original cpuprofile file? If so please attach it.
The window output & the screenshot might help a lot, because I'm still not sure why the onDiagnostics task is being run in that context. But it seems this is the first issue where the stack trace is similar to another performance issue.


Custom Rules to test against Terraform templates

Hi,
Is it possible write to custom rules to test Terraform files.
Regards,
TechGirl-3

Hi @TechGirl-3 ,
Thanks for reaching out.
By custom rules, im guessing you mean you'd like to write your own gherkins that are not currently in the list of supported matchers?
Clarity is really a purpose built extension on top of https://github.com/cucumber/godog . What this allows us to do is to author our own gherkins, and using the clarity cli (indirectly the godog cli) compile a new binary which includes any new matchers you might desire.
You could also fork the repo, add any new gherkins you'd like, and contribute them back in the form of a PR. I'd be happy to accept them :)
-John


RegisterVitalRouterDisposable does not work if there are several "LifetimeScope" and only one is unloaded.

Here is a link to the commit where I am trying to fix this problem. But I think this is not quite the right solution and there is a problem either in VContrainer or in VitalRouter:
https://github.com/TricksterCat/VitalRouter/commit/7c9bd3eed5cde5358690874373834d8586f3d889#diff-e6cf9fb743e76a189b28764332fd80d38ee3967789d078231a9ccfa972d134c9R219

Ah ok. thanks for the report.
This is probably a VContainer issue. I'm fixing it here now.
https://github.com/hadashiA/VContainer/pull/728

I've released a fix for the RegisterDisposeCallback in VContainer.
I'd be happy if you could check it out. Thanks.
https://github.com/hadashiA/VContainer/releases/tag/1.16.6

Didn't help.
My current approximate scope structure:

AppScope
SharedScope
2.1 MetaScope
2.2 SharedCoreScope
2.2.1 Core1Scope
2.2.2 Core2Scope

When I load the game, scenes from Scope are loaded sequentially. So, when entering the meta part of the game, the player can go to one of the core minigames. In the process, the scene containing "MetaScope" is unloaded, and first "SharedCoreScope" is loaded, and then "Core1Scope" or "Core2Scope".
But when unloading a scene from "MetaScope", "VitalRouter.VContainer.RoutingDisposable" is not called. But if inside the VitalRouter.VContainer.VContainerExtensions.RegisterVitalRouter method I call "container.Resolve();" at the end of RegisterBuildCallback, it will work when unloading the scene containing Scope.

This fix also works for my case:
static void RegisterVitalRouterDisposable(this IContainerBuilder builder, RoutingBuilder routing)
{
    builder.Register(container => new RoutingDisposable(container, routing.MapRoutesInfos), Lifetime.Scoped);
    builder.RegisterBuildCallback(container => container.Resolve<RoutingDisposable>()); //add line
}


New version with pagination

Hi
When will there be a new version with pagination?

Pagination has been merged into master quite recently in #1277, so when a new version is released it will be included.


Document the process to update the db diagram

Thanks to the documentation effort, this repo is much more accessible than in the past. Thanks @frgfm :)
We now have a diagram from dbdiagram.io describing our database in the README : https://github.com/pyronear/pyro-api#how-is-the-database-organized
In order to ensure that it is updated over time as changes are made to the repo, it would be cool to have the process describing the production of a new diagram following changes to the api (how to pass from the code in the repo to this diagram without having to rewrite everything on dbdiagram.io ?)
Could you describe this process ?
Maybe we could add a section to CONTRIBUTING.md like "Documenting updates in schema" ?
Thanks a lot,
Happy to discuss it :)
PS: At the very least, you can quickly explain the process here and someone will be able to produce a clean doc update.

Quite simply, I have a pseudocode that lead to this graph in dbdiagram that I update :)
Happy to put it somewhere in the repo if that can help :+1:
Or show an example code/visualization so that people can do it on their own


Run Title and Publish Test Attachments Changes

Description: The PublishTestResults Task's xplat implementation is currently different from windows implementation. Users choice of Run Title and option to not publish result files do not exist in the current xplat implementation.
Solution: Changes have been made for Junit, xunit and nunit to honor users choice of run ttitle and user can now opt out of publishing test attachments.
https://github.com/Microsoft/vso-agent-tasks/pull/954
https://github.com/Microsoft/vso-agent/pull/168
Testing: Manual for now. Appropriate unit tests will be added if required.

approved with suggestions


Table size....

Can we indicate the number of rows and columns in the table in the details view somewhere.  Its very hard to figure out what you have without this information.

moved to wishlist


Review-by-schedule page

Closing this for now, added basic ability to see which scores are entered in e67b93d


Make response headers case insensitive

Configuration:

PDF.js version: v2.12.313 (latest)

Steps to reproduce the problem:

Try doing Range-Requests with lower-case headers won't work

What is the expected behaviour? (add screenshot)

To work properly with lower-case headers

What went wrong? (add screenshot)

Using case-insensitive headers such as accept-ranges does not work as expected.

I am currently using Starlette (Python library)  to send the PDF using Range requests but PDF.js does not correctly detect when the headers are lower-cased. If the headers are case-sensitive using PascalCase everything works as expected  (https://github.com/encode/starlette/issues/1454)
Headers should be case insensitive
According to RFC 7230 (HTTP/1.1):

Each header field consists of a case-insensitive field name
followed by a colon (":"), optional leading whitespace, the field
value, and optional trailing whitespace.

https://www.rfc-editor.org/rfc/rfc7230#section-3.2
Also, RFC 7540 (HTTP/2):

Just as in HTTP/1.x, header field names are strings of ASCII
characters that are compared in a case-insensitive fashion.

https://www.rfc-editor.org/rfc/rfc7540#section-8.1.2

Using case-insensitive headers such as accept-ranges does not work as expected.

That should already work, given that we're using the https://developer.mozilla.org/en-US/docs/Web/API/Headers/get and https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/getResponseHeader methods which are both documented as being case-insensitive.
In my quick testing, using both Mozilla Firefox and Google Chrome, those methods are indeed case-insensitive; however you've not said anything what browser(s) you're using.

I am currently using Starlette (Python library) to send the PDF using Range requests but PDF.js does not correctly detect when the headers are lower-cased.

Unfortunately we don't know anything about that library here, and generally we also cannot really provide help with Python code either (since this is a JavaScript library).

As-is this unfortunately doesn't really seem actionable; please note https://github.com/mozilla/pdf.js/blob/master/.github/CONTRIBUTING.md (emphasis mine):

If you are developing a custom solution, first check the examples at https://github.com/mozilla/pdf.js#learning and search existing issues. If this does not help, please prepare a short well-documented example that demonstrates the problem and make it accessible online on your website, JS Bin, GitHub, etc. before opening a new issue or contacting us in the Matrix room -- keep in mind that just code snippets won't help us troubleshoot the problem.

@Snuffleupagus Thank you for your fast response.
After what you said I tried to find what was causing this to fail and it was because of the development default CORS configuration. It was overriding my Access-Control-Expose-Headers and this was causing to fail everything. Thank you very much!


config.define does not replace variables in esm dependencies in node_modules

Describe the bug
I'm working on a Vite project which consists of a Vite plugin and corresponding browser code for the client project to import. I'm using config.define in the plugin to provide some basic global variables for the components such as __PROD__.
I've run into an issue where the global variables defined in config.define are not being replaced for library code during development, this is only a problem for development for variables which need replacing in dependencies, build is working correctly as are replacements in the client project itself.
The project is distributed as a javascript esm dependency so there is a dist/browser/index.js file in the module. I'm sure this is a bug because if I modify the extension of this file from .js to .ts (dist/browser/index.js -> dist/browser/index.ts) within the node_modules folder and update the package.json accordingly, the constants are correctly replaced by the define step and everything works, without changing a single line of code.
I'm assuming dependencies from node_modules which are already esm and .js are skipping some steps in the Vite transform and it's not hitting the define plugin, whereas when I change the extension to .ts it's treated as a typescript file and is hitting those steps.
This only happens in dev and is not a problem for build, this is also SSR and I'm reasonably closely following the dev server example from the docs, so the requests are going through vite.ssrLoadModule.
Reproduction
No repo as this bug only affects node_modules, without publishing the package I'm not sure how to repro it.
System Info
System:
    OS: macOS 11.4
    CPU: (8) arm64 Apple M1
    Memory: 84.78 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.13.0 - ~/.nvm/versions/node/v16.13.0/bin/node
    Yarn: 1.22.10 - /usr/local/bin/yarn
    npm: 8.1.0 - ~/.nvm/versions/node/v16.13.0/bin/npm
  Browsers:
    Chrome: 96.0.4664.110
    Firefox: 95.0.2
    Safari: 14.1.1
  npmPackages:
    vite: ^2.7.6 => 2.7.6

Used Package Manager
pnpm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/vue-next instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

We currently do pass define to esbuild during pre-bundling, which will bundle the dependencies. You can provide a repro with the packages by creating a local package, and npm install ./that-local-package to showcase the issue.


Problems with import mamba-ssm

import mamba-ssm
Traceback (most recent call last):
File "", line 1, in
File "/mnt/mount/data/ytj/anaconda3/envs/pytorch/lib/python3.10/site-packages/mamba_ssm/init.py", line 3, in
from mamba_ssm.ops.selective_scan_interface import selective_scan_fn, mamba_inner_fn
File "/mnt/mount/data/ytj/anaconda3/envs/pytorch/lib/python3.10/site-packages/mamba_ssm/ops/selective_scan_interface.py", line 11, in
import selective_scan_cuda
ImportError: /mnt/mount/data/ytj/anaconda3/envs/pytorch/lib/python3.10/site-packages/selective_scan_cuda.cpython-310-x86_64-linux-gnu.so: undefined symbol: _ZN2at4_ops10zeros_like4callERKNS_6TensorEN3c108optionalINS5_10ScalarTypeEEENS6_INS5_6LayoutEEENS6_INS5_6DeviceEEENS6_IbEENS6_INS5_12MemoryFormatEEE

same problem. In a nividia container... works well on the previous version of the mamba code.

Downgrade to torch 2.2.2 works for me.


Javadocs are not buildable

Javadocs are not buildable.
Running mvn javadoc:javadoc produces 2 errors (and more than 100 warnings).

Sorry, I pushed my changes before you, but yours look better so I would accept them.

This issue can be kept open to remind us to improve the quality of javadocs.


Fixes "When creating a task of type TEST it should also add the tag TASK"

Fixes issue #27

@gilesv Please let me know if this is sufficient or if there's a better way to do this 😃