chore: promote algorithm W to master

@rockstar are you able to address @jsternberg's question?

I know we already did the work to ensure goreleaser would work, but did we integrate that work into the release process?

I'm not sure, but we definitely can't make macOS binaries right now with the work we did. I guess I'm not sure what the delta is in the release process, as my assumption was that the work we were doing was behind a shared protocol with influxdb.


Improve HeapToStack optimisation pass

This pass needs to run multiple times during optimisation to exploit the transformations realised by the standard LLVM passes and catch as much allocations as possible. We also need to erase replaced instructions manually or they will stay in the program.

One of the Travis CI OSX runs had a segfault while running the stdlib tests.  Hopefully that's not indicative of a problem with this commit.  I'm going to run all of the builds again to see if it reproduces.

The remaining Travis failure is a problem with Travis infrastructure - I'm merging.


Change parameters of difficulty adjustment alrgorithm

The goal was to improve current DAA performance and get less swings in difficulty and more consistent block time.
Simulation results using difficulty_adjustment_simulation can be found here:
block time simulation.xlsx
Setting from master gives result represented on sheet sma_5
The accepted setting is located on sheet sma_100_1_per_1000

Simulation results using difficulty_adjustment_simulation can be found here: block time simulation.xlsx Setting from master gives result represented on sheet sma_5 The accepted setting is located on sheet sma_100_1_per_1000

Would be interesting to see how these react to a "shock" increase (say doubling) in block production rate. How long does it take for the difficulty to get close to double?

Would be interesting to see how these react to a "shock" increase (say doubling) in block production rate. How long does it take for the difficulty to get close to double?

tbh it's hard to analyse such things using a spreadsheet. I will try to learn how to work with Mathematica during the weekend and hope it will help. What I can say now is that it takes a while.


using isapprox(a,b) function in julia instead of rolling our own

The julia implementation of fft had an approximate function we created ourselves, but there was no reason to do so when the isapprox(a,b) function exists

I personally like the Unicode syntax in Julia a ≈ b, but I am probably in the minority.

I'll be honest, I just don't want to have to change text editors to put in the LaTeX. The unicode-ness of Julia also makes it less readable in my opinion... But I know people who absolutely love unicode

I understand, also with isapprox you can set the tolerance value, which you cannot do with the unicode.


Hard code BNT on poolROI

As discussed @ashachaf this update would consistently send BNT into poolROI in order to achieve consistent APR's per pool.

@yudilevi this is the change proposed.

do not merge this.


Fix 2677 - to support CloudFlare FlexibleSSL

Adresses #2677 since that one couldn't be merged as-is (revision operation has been moved to its own repo)

A new inspection was created.

The inspection completed: No new issues


Make it possible to divide the configuration in several files.

I have the same <Skip*> settings for several different assemblies.
Today I have to copy everything. Would be nice with some kind of
<Include file="skip_specs.xml" />.

Otherwise:
Great product!

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 12 Dec 2008 at 11:18

Closed via #103


feat[CL]: add MsgCreateConcentratedPool

Closes: #3245
What is the purpose of the change
Implementation of MsgCreateConcentratedPool and required wiring
Brief Changelog
(for example:)

The metadata is stored in the blob store on job creation time as a persistent artifact
Deployments RPC transmits only the blob storage reference
Daemons retrieve the RPC data from the blob cache

@p0mvn addressed most of your comments with a few followups!

@czarcas7ic thanks, replied to the remaining unresolved discussions

@p0mvn all concerns addressed!

@p0mvn I got rid of the internal model package but for some reason proto check is failing on this as well as the go test. Is this normal?

@czarcas7ic I think there might be an import that is still referencing the old package

@p0mvn Just double checked and there isnt :/

I think that its a false error. It was passing before, and the changes I made dont effect this..

Yeah, I reverted back to a point where it was passing and it still fails, so I think its something to do with CI

Closing in favor of https://github.com/osmosis-labs/osmosis/pull/3687


Process killed when live-reload quarkus Java application

Bug Description
I used mirrord to start a quarkus Java application in dev mode for live reloading of the application in development. And I use VSCode in devcontainer for my local development workspace. After a while of implementing, my VSCode freezes and the Java process is killed, along with the agent
Command to start quarkus Java application
mirrord -f .mirrord/mirrord.json mvn quarkus:dev
Mirrord configuration
{
    "target": {
        "namespace": "dev",
        "path": {
            "deployment": "service-ext-deployment-dev"
        }
    },
    "feature": {
      "env": true,
      "fs": "read",
      "network": true
    },
    "internal_proxy": {
      "log_destination": "/tmp/internal_proxy.log",
      "log_level": "mirrord=trace"
    }
  }

launch.json for attaching the local debugger
{
            "type": "java",
            "request": "attach",
            "hostName": "localhost",
            "name": "Attach Debugger",
            "port": 5005,
            "projectName": "service"
}

The trace log is large so I attached it below
internal_proxy.log
Steps to Reproduce

Use VSCode IDE
Run Quarkus dev mode in VSCode
Place breakpoint
Live-reload Quarkus by modifying source

Backtrace
No response
Relevant Logs
No response
Your operating system and version
java GraalVM CE 21.0.2+13.1 (build 21.0.2+13-jvmci-23.1-b30)
Local process
java
Local process version
java 17 grralvm
Additional Info
However, if I start a new bash session using mirrord
mirrord -f .mirrord/mirrord.json bash
Then run the quarkus Java application in dev mode
mvn quarkus:dev
Then the above issue never happens, the performance is better, VSCode does not freeze and the Java process is not killed

Thanks for reporting this! This seems to happen because of idle_timeout. The internal proxy component (part that runs on your machine) aggregates "layer" (the part that loads into your local process) connections. When there are no connections for a said duration, it cleans up. I assume the issue is that sometimes the reload time > idle_timeout which means that until the new connection is established the internal proxy already dies.
You can control that timeout by setting
"internal_proxy": {"idle_timeout": 10}

The timeout is in seconds, and by default it is 5 seconds. Can you try increasing it and seeing if it happens again?

Actually I increased the idle_timeout to a much higher value to 1200 (20 minutes) but the issue can still be reproduced. It usually happens if I have a compilation error in my VSCode IDE when writing some code. I use autosave feature of VSCode and the IDE compile the code everytime the file is save.
Also, the performance is greatly impact, slower, compare to using mirrord exec bash in the terminal. So I guess because the Quarkus Application is executed by using launch configuration in VSCode, so the application is executed by mirrord from a process that VSCode created. VSCode can control mirrord from its spawned process, hence it can kill mirrord execution.
I haven't tried with manul saving (manual compilation) in VSCode but I doubt it will work, since there is less synchronization happening.

Can you attach the same log as above with the new idle timeout please?

Sure, this is the trace log
internal_proxy.log
And the configuration is
}
  "internal_proxy": {
        "log_destination": "/tmp/internal_proxy.log",
        "log_level": "mirrord=trace",
        "idle_timeout": 3600
   }
 }

I see it fails on accessing /workspace because it tries to read it from remote.
Can you try to add it to local path?
{
  "feature": {
    "fs": {
      "mode": "read",
      "local": ["/workspace.+"]
    }
  }
}

I tried with the above configuration, Quarkus process did not get killed this time but the performance of VSCode is much slower or freeze for code completion, suggestion, compare to not using that configuration. Sometimes the VSCode debugger is even terminated while I write some code.
Increasing the memory of Java language server helped with the slowing / freezing of VSCode (not entirely) but I don't need to do that if I use mirrord to open a new shell and run Quarkus in development mode within that shell.
Do you think using the mirrord VSCode extension can help with this issue ?

It could be that we're attached to the debugger as well, making it a bit slower.
I'd try to use the extension to see if it helps.

Hey @vanduc2514 , did using the extension help here?


Initialisation of Rubix cache fails on coordinator if cache directory is not present

Initialisation of Rubix cache fails on coordinator if cache directory is not present. This happens even if split scheduling is disabled for coordinator.
Snippet from logs:
2020-04-20T14:01:44.470Z        ERROR   pool-51-thread-1        com.qubole.rubix.bookkeeper.BookKeeperServer    Could not start BookKeeper daemon. Exception:
com.qubole.rubix.bookkeeper.exception.BookKeeperInitializationException: java.io.FileNotFoundException: None of the cache parent directories exists
        at com.qubole.rubix.bookkeeper.BookKeeper.setupCacheDirectory(BookKeeper.java:149)
        at com.qubole.rubix.bookkeeper.BookKeeper.<init>(BookKeeper.java:134)
        at com.qubole.rubix.bookkeeper.CoordinatorBookKeeper.<init>(CoordinatorBookKeeper.java:68)
        at com.qubole.rubix.bookkeeper.CoordinatorBookKeeper.<init>(CoordinatorBookKeeper.java:62)
        at com.qubole.rubix.bookkeeper.BookKeeperServer.setupServer(BookKeeperServer.java:119)
        at com.qubole.rubix.bookkeeper.BookKeeperServer.startServer(BookKeeperServer.java:89)
        at io.prestosql.plugin.hive.rubix.RubixInitializer.lambda$initializeRubix$2(RubixInitializer.java:97)
        at com.google.common.util.concurrent.AbstractTransformFuture$TransformFuture.doTransform(AbstractTransformFuture.java:233)
        at com.google.common.util.concurrent.AbstractTransformFuture$TransformFuture.doTransform(AbstractTransformFuture.java:223)
        at com.google.common.util.concurrent.AbstractTransformFuture.run(AbstractTransformFuture.java:110)
        at com.google.common.util.concurrent.MoreExecutors$5$1.run(MoreExecutors.java:992)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
        at java.base/java.lang.Thread.run(Thread.java:834)
Caused by: java.io.FileNotFoundException: None of the cache parent directories exists
        at com.qubole.rubix.spi.CacheUtil.createCacheDirectories(CacheUtil.java:77)
        at com.qubole.rubix.bookkeeper.BookKeeper.setupCacheDirectory(BookKeeper.java:146)
        ... 13 more

An easy solution to this is to create the /data directory on the coordinator in our AMI even though it won't be used. Of of course modify the Rubix code so it doesn't depend upon it.

@stagraqubole is Rubix expected to ever write something to caching directory on coordinator if splits scheduling for coordinator is disabled? Some metadata maybe? Or is it safe to not have cache directory at all?

It looks like currently Rubix itself will always require cache directory, no matter if it is on master or not. For now I propose a Presto only workaround. During Rubix initialization on coordinator, if node-scheduler.include-coordinator=false we check if directory configured as cache is present and accessible. If so we continue. If it does not exist we fallback to temporary directory. WDYT?

Right, rubix expects cache location to be mounted on all nodes. The workaround lgtm.
Separately we can add this kind of mode natively in rubix where we add assertions if we ever break the assumption of cache usage in coordinator at runtime. We will need a rubix version upgrade once #3494 is fixed, i will try to make this change part of that release.

Separately we can add this kind of mode natively in rubix where we add assertions if we ever break the assumption of cache usage in coordinator at runtime

Makes sense I will create an issue for that and send PR

Right, rubix expects cache location to be mounted on all nodes. The workaround lgtm.
Separately we can add this kind of mode natively in rubix where we add assertions if we ever break the assumption of cache usage in coordinator at runtime. We will need a rubix version upgrade once #3494 is fixed, i will try to make this change part of that release.

@stagraqubole, https://github.com/qubole/rubix/pull/365 is an attempt to address that, though I am not sure if that is how it should look like. In that PR I initialize Bookkeeper with stubbed internal cache implementations, which would throw if someone tries to add anything to them.
But why do we need Bookkeeper at all on master node in such case. Is it needed for anything more than heartbits? Please comment on PR :)

Yes, apart from heartbeat there is not other use of bookkeeper on master. Client/Presto will never talk to bookkeeper on master.

Would there ever be a scenario where data is written to the coordinator cache dir? I can't seem to reproduce it but I had an instance last week where that happened. If it's not possible, maybe I was imaging things...

@tnatssb any chance node-scheduler.include-coordinator=true was set?

It was not. It was a standard CFT deployment. I’ll try to get time to test
again this week. It was strange for sure.
On Thu, Apr 30, 2020 at 7:35 AM Shubham Tagra<EMAIL_ADDRESS>wrote:

@tnatssb https://github.com/tnatssb any chance
node-scheduler.include-coordinator=true was set?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/prestosql/presto/issues/3488#issuecomment-621777947,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMS3EZUJZ52XZMR463Q7AYDRPFO73ANCNFSM4MMTVAJA
.


Reorganise DemoComponentFactory

The class DemoComponentFactory is massively complex. Refactor it so that each type-specific code is in a separate builder, there are proper component factories that can optionally provide validators.
The mess of that class became apparent while working on #241 - this ticket can be done as part of that branch.

now the demo app is full enterprise, with content builders, interfaces and things 🙄 but it should be easier to showcase new components, should there ever come any


Contract tests are not running with correct configuration in Gradle

Describe the bug
The verification phase doesn't pick the application.yml under src/test/resources and falls back to the default applicaiton.yml causing test failures in Gradle build. But it works perfectly with maven build - it picks the application.yml under src/test/resources
console output of contract verificationtest test when run from maven. Note that it is using Database: jdbc:h2:mem:testdb (H2 2.1) from test applicaton.yml
      .   ____          _            __ _ _
     /\\ / ___'_ __ _ _(_)_ __  __ _ \ \ \ \
    ( ( )\___ | '_ | '_| | '_ \/ _` | \ \ \ \
     \\/  ___)| |_)| | | | | || (_| |  ) ) ) )
      '  |____| .__|_| |_|_| |_\__, | / / / /
     =========|_|==============|___/=/_/_/_/
     :: Spring Boot ::                (v2.7.5)

    2022-11-05 16:39:05.560  INFO 56393 --- [           main] c.c.d.springcontractdemo.GreetingTest    : Starting GreetingTest using Java 15.0.1 on **** with PID 56393 (started by **** in /Users/SpringContractDemo)
    2022-11-05 16:39:05.561  INFO 56393 --- [           main] c.c.d.springcontractdemo.GreetingTest    : No active profile set, falling back to 1 default profile: "default"
    2022-11-05 16:39:05.939  INFO 56393 --- [           main] .s.d.r.c.RepositoryConfigurationDelegate : Bootstrapping Spring Data JPA repositories in DEFAULT mode.
    2022-11-05 16:39:05.943  INFO 56393 --- [           main] .s.d.r.c.RepositoryConfigurationDelegate : Finished Spring Data repository scanning in 2 ms. Found 0 JPA repository interfaces.
    2022-11-05 16:39:06.427  INFO 56393 --- [           main] o.s.b.w.embedded.tomcat.TomcatWebServer  : Tomcat initialized with port(s): 0 (http)
    2022-11-05 16:39:06.443  INFO 56393 --- [           main] o.apache.catalina.core.StandardService   : Starting service [Tomcat]
    2022-11-05 16:39:06.443  INFO 56393 --- [           main] org.apache.catalina.core.StandardEngine  : Starting Servlet engine: [Apache Tomcat/9.0.68]
    2022-11-05 16:39:06.734  INFO 56393 --- [           main] o.a.c.c.C.[Tomcat].[localhost].[/]       : Initializing Spring embedded WebApplicationContext
    2022-11-05 16:39:06.734  INFO 56393 --- [           main] w.s.c.ServletWebServerApplicationContext : Root WebApplicationContext: initialization completed in 1168 ms
    2022-11-05 16:39:06.996  INFO 56393 --- [           main] com.zaxxer.hikari.HikariDataSource       : HikariPool-2 - Starting...
    2022-11-05 16:39:06.998  INFO 56393 --- [           main] com.zaxxer.hikari.HikariDataSource       : HikariPool-2 - Start completed.
    **2022-11-05 16:39:06.998  INFO 56393 --- [           main] o.f.c.i.database.base.BaseDatabaseType   : Database: jdbc:h2:mem:testdb (H2 2.1)**
    2022-11-05 16:39:07.008  INFO 56393 --- [           main] o.f.core.internal.command.DbValidate     : Successfully validated 2 migrations (execution time 00:00.004s)
    2022-11-05 16:39:07.015  INFO 56393 --- [           main] o.f.core.internal.command.DbMigrate      : Current version of schema "greeting": 1.0
    2022-11-05 16:39:07.016  INFO 56393 --- [           main] o.f.core.internal.command.DbMigrate      : Schema "greeting" is up to date. No migration necessary.
    2022-11-05 16:39:07.059  INFO 56393 --- [           main] o.hibernate.jpa.internal.util.LogHelper  : HHH000204: Processing PersistenceUnitInfo [name: default]
    2022-11-05 16:39:07.066  INFO 56393 --- [           main] org.hibernate.dialect.Dialect            : HHH000400: Using dialect: org.hibernate.dialect.H2Dialect
    2022-11-05 16:39:07.113  INFO 56393 --- [           main] o.h.e.t.j.p.i.JtaPlatformInitiator       : HHH000490: Using JtaPlatform implementation: [org.hibernate.engine.transaction.jta.platform.internal.NoJtaPlatform]
    2022-11-05 16:39:07.114  INFO 56393 --- [           main] j.LocalContainerEntityManagerFactoryBean : Initialized JPA EntityManagerFactory for persistence unit 'default'
    2022-11-05 16:39:07.209  WARN 56393 --- [           main] JpaBaseConfiguration$JpaWebConfiguration : spring.jpa.open-in-view is enabled by default. Therefore, database queries may be performed during view rendering. Explicitly configure spring.jpa.open-in-view to disable this warning
    2022-11-05 16:39:07.650  INFO 56393 --- [           main] o.a.c.c.C.[Tomcat].[localhost].[/]       : Initializing Spring TestDispatcherServlet ''
    2022-11-05 16:39:07.650  INFO 56393 --- [           main] o.s.t.web.servlet.TestDispatcherServlet  : Initializing Servlet ''
    2022-11-05 16:39:07.651  INFO 56393 --- [           main] o.s.t.web.servlet.TestDispatcherServlet  : Completed initialization in 0 ms
    2022-11-05 16:39:08.171  INFO 56393 --- [           main] o.s.b.w.embedded.tomcat.TomcatWebServer  : Tomcat started on port(s): 52976 (http) with context path ''
    2022-11-05 16:39:08.184  INFO 56393 --- [           main] c.c.d.springcontractdemo.GreetingTest    : Started GreetingTest in 2.693 seconds (JVM running for 11.731)
    2022-11-05 16:39:08.800  INFO 56393 --- [           main] o.a.c.c.C.[Tomcat].[localhost].[/]       : Initializing Spring TestDispatcherServlet ''
    2022-11-05 16:39:08.800  INFO 56393 --- [           main] o.s.t.web.servlet.TestDispatcherServlet  : Initializing Servlet ''
    2022-11-05 16:39:08.801  INFO 56393 --- [           main] o.s.t.web.servlet.TestDispatcherServlet  : Completed initialization in 1 ms
    [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.972 s - in com.contract.demo.springcontractdemo.GreetingTest
    2022-11-05 16:39:09.471  INFO 56393 --- [ionShutdownHook] j.LocalContainerEntityManagerFactoryBean : Closing JPA EntityManagerFactory for persistence unit 'default'
    2022-11-05 16:39:09.473  INFO 56393 --- [ionShutdownHook] com.zaxxer.hikari.HikariDataSource       : HikariPool-1 - Shutdown initiated...
    2022-11-05 16:39:09.475  INFO 56393 --- [ionShutdownHook] com.zaxxer.hikari.HikariDataSource       : HikariPool-1 - Shutdown completed.
    2022-11-05 16:39:12.505  INFO 56393 --- [ionShutdownHook] j.LocalContainerEntityManagerFactoryBean : Closing JPA EntityManagerFactory for persistence unit 'default'
    2022-11-05 16:39:12.506  INFO 56393 --- [ionShutdownHook] com.zaxxer.hikari.HikariDataSource       : HikariPool-2 - Shutdown initiated...
    2022-11-05 16:39:12.511  INFO 56393 --- [ionShutdownHook] com.zaxxer.hikari.HikariDataSource       : HikariPool-2 - Shutdown completed.

console output of contract verificationtest test when run from gradle. Note that it is not using Database: jdbc:h2:mem:testdb (H2 2.1) instead using Database: jdbc:h2:mem:prod-db (H2 2.1) from main applicaton.yml
      .   ____          _            __ _ _
     /\\ / ___'_ __ _ _(_)_ __  __ _ \ \ \ \
    ( ( )\___ | '_ | '_| | '_ \/ _` | \ \ \ \
     \\/  ___)| |_)| | | | | || (_| |  ) ) ) )
      '  |____| .__|_| |_|_| |_\__, | / / / /
     =========|_|==============|___/=/_/_/_/
     :: Spring Boot ::                (v2.7.5)

    2022-11-05 16:43:33.157  INFO 56936 --- [    Test worker] c.c.d.springcontractdemo.GreetingTest    : Starting GreetingTest using Java 15.0.1 on **** with PID 56936 (started by **** in /Users/SpringContractDemo)
    2022-11-05 16:43:33.159  INFO 56936 --- [    Test worker] c.c.d.springcontractdemo.GreetingTest    : No active profile set, falling back to 1 default profile: "default"
    2022-11-05 16:43:34.754  INFO 56936 --- [    Test worker] .s.d.r.c.RepositoryConfigurationDelegate : Bootstrapping Spring Data JPA repositories in DEFAULT mode.
    2022-11-05 16:43:34.776  INFO 56936 --- [    Test worker] .s.d.r.c.RepositoryConfigurationDelegate : Finished Spring Data repository scanning in 10 ms. Found 0 JPA repository interfaces.
    2022-11-05 16:43:36.163  INFO 56936 --- [    Test worker] o.s.b.w.embedded.tomcat.TomcatWebServer  : Tomcat initialized with port(s): 0 (http)
    2022-11-05 16:43:36.185  INFO 56936 --- [    Test worker] o.apache.catalina.core.StandardService   : Starting service [Tomcat]
    2022-11-05 16:43:36.185  INFO 56936 --- [    Test worker] org.apache.catalina.core.StandardEngine  : Starting Servlet engine: [Apache Tomcat/9.0.68]
    2022-11-05 16:43:36.437  INFO 56936 --- [    Test worker] o.a.c.c.C.[Tomcat].[localhost].[/]       : Initializing Spring embedded WebApplicationContext
    2022-11-05 16:43:36.437  INFO 56936 --- [    Test worker] w.s.c.ServletWebServerApplicationContext : Root WebApplicationContext: initialization completed in 2760 ms
    2022-11-05 16:43:36.954  INFO 56936 --- [    Test worker] o.f.c.internal.license.VersionPrinter    : Flyway Community Edition 9.6.0 by Redgate
    2022-11-05 16:43:36.955  INFO 56936 --- [    Test worker] o.f.c.internal.license.VersionPrinter    : See what's new here: https://flywaydb.org/documentation/learnmore/releaseNotes#9.6.0
    2022-11-05 16:43:36.955  INFO 56936 --- [    Test worker] o.f.c.internal.license.VersionPrinter    :
    2022-11-05 16:43:36.968  INFO 56936 --- [    Test worker] com.zaxxer.hikari.HikariDataSource       : HikariPool-1 - Starting...
    2022-11-05 16:43:37.360  INFO 56936 --- [    Test worker] com.zaxxer.hikari.HikariDataSource       : HikariPool-1 - Start completed.
    **2022-11-05 16:43:37.378  INFO 56936 --- [    Test worker] o.f.c.i.database.base.BaseDatabaseType   : Database: jdbc:h2:mem:prod-db (H2 2.1)**
    2022-11-05 16:43:37.506  INFO 56936 --- [    Test worker] o.f.core.internal.database.base.Schema   : Creating schema "greeting" ...
    2022-11-05 16:43:37.513  INFO 56936 --- [    Test worker] o.f.c.i.s.JdbcTableSchemaHistory         : Creating Schema History table "greeting"."flyway_schema_history" ...
    2022-11-05 16:43:37.572  INFO 56936 --- [    Test worker] o.f.core.internal.command.DbMigrate      : Current version of schema "greeting": null
    2022-11-05 16:43:37.578  INFO 56936 --- [    Test worker] o.f.core.internal.command.DbMigrate      : Migrating schema "greeting" to version "1.0 - InitialSchema"
    2022-11-05 16:43:37.588  INFO 56936 --- [    Test worker] o.f.core.internal.command.DbMigrate      : Successfully applied 1 migration to schema "greeting", now at version v1.0 (execution time 00:00.022s)
    2022-11-05 16:43:37.861  INFO 56936 --- [    Test worker] o.hibernate.jpa.internal.util.LogHelper  : HHH000204: Processing PersistenceUnitInfo [name: default]
    2022-11-05 16:43:37.949  INFO 56936 --- [    Test worker] org.hibernate.Version                    : HHH000412: Hibernate ORM core version 5.6.12.Final
    2022-11-05 16:43:38.237  INFO 56936 --- [    Test worker] o.hibernate.annotations.common.Version   : HCANN000001: Hibernate Commons Annotations {5.1.2.Final}
    2022-11-05 16:43:38.537  INFO 56936 --- [    Test worker] org.hibernate.dialect.Dialect            : HHH000400: Using dialect: org.hibernate.dialect.H2Dialect
    2022-11-05 16:43:38.817  INFO 56936 --- [    Test worker] o.h.e.t.j.p.i.JtaPlatformInitiator       : HHH000490: Using JtaPlatform implementation: [org.hibernate.engine.transaction.jta.platform.internal.NoJtaPlatform]
    2022-11-05 16:43:38.838  INFO 56936 --- [    Test worker] j.LocalContainerEntityManagerFactoryBean : Initialized JPA EntityManagerFactory for persistence unit 'default'
    2022-11-05 16:43:38.990  WARN 56936 --- [    Test worker] JpaBaseConfiguration$JpaWebConfiguration : spring.jpa.open-in-view is enabled by default. Therefore, database queries may be performed during view rendering. Explicitly configure spring.jpa.open-in-view to disable this warning
    2022-11-05 16:43:40.098  INFO 56936 --- [    Test worker] o.a.c.c.C.[Tomcat].[localhost].[/]       : Initializing Spring TestDispatcherServlet ''
    2022-11-05 16:43:40.099  INFO 56936 --- [    Test worker] o.s.t.web.servlet.TestDispatcherServlet  : Initializing Servlet ''
    2022-11-05 16:43:40.100  INFO 56936 --- [    Test worker] o.s.t.web.servlet.TestDispatcherServlet  : Completed initialization in 1 ms
    2022-11-05 16:43:40.665  INFO 56936 --- [    Test worker] o.s.b.w.embedded.tomcat.TomcatWebServer  : Tomcat started on port(s): 53028 (http) with context path ''
    2022-11-05 16:43:40.691  INFO 56936 --- [    Test worker] c.c.d.springcontractdemo.GreetingTest    : Started GreetingTest in 8.164 seconds (JVM running for 10.333)

Sample
https://github.com/hegdevishwa/SCC-GradleDemo

I'm not sure if this is an issue with the Spring Cloud Contract plugin for Gradle or something else, but it's definitely behaving differently in different build setup.

This doesn't have to do with Spring Cloud Contract I think. Does the problem persist if you remove the contract dependency from the classpath?

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.


Possible to use connection Get-AutomationConnection  instead of Get-AutomationPSCredential?

Is it possible to perform a refresh by referencing the automation connection instead of the Get-AutomationPSCredential -Name "ServicePrincipal"?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 83c04a51-5c8e-73b3-cb07-0c72691a5cdb
Version Independent ID: baf30ca3-524a-455a-2dbe-c229e74faa94
Content: Refresh Azure Analysis Services models with Azure Automation
Content Source: articles/analysis-services/analysis-services-refresh-azure-automation.md
Service: analysis-services
GitHub Login: @ChrisLound
Microsoft Alias: chlound

@JoshFlory You cannot "Get-AutomationConnection" instead of "Get-AutomationPSCredentials".
Reason: An Automation credential asset holds an object, which contains security credentials such as a username and password. Runbooks and DSC configurations may use cmdlets that accept a PSCredential object for authentication, or they may extract the username and password of the PSCredential object to provide to some application or service requiring authentication. The properties for a credential are stored securely in Azure Automation and can be accessed in the runbook or DSC configuration with the Get-AutomationPSCredential activity.
You need to use "Get-AutomationPSCredential -Name "ServicePrincipal"", to perform the Azure Analysis Services model refresh using a PowerShell Runbook.

@JoshFlory  We will now proceed to close this thread. If there are further questions regarding this matter, please comment and we will gladly continue the discussion.


updating release instructions to include LTS suffix

Changes

The Pipelines release name pattern is cat breed followed by any famous robot. We are now asking release managers to add a suffix to the release name such that its easy to identify which release is LTS v/s which one is not.
Fixes: https://github.com/tektoncd/pipeline/issues/6275
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[ ] Has Docs included if any changes are user facing
[ ] Has Tests included if any functionality added or changed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including
functionality, content, code)
[x] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[x] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
[ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes
NONE

/lgtm


Consider support for vaadin-router

It would be nice to have support for client-side navigation using vaadin-router.

Can you detail this requirement a little bit more?

Vaadin router is a component that intercepts anchor link clicks and instantiate web components for those demanded urls completely client side (without creating server requests).
Maybe a special mode for AppLayout could be configured, so it could be possible to create applications that with the first request creates the whole skeleton app with the AppLayout, and after that it can run like in an "offline" mode.
In this way it could be possible to create PWAs that after showing the menu for the first time, then they could show error pages for destinations that needs server side interaction, but show cached content for help pages, etc.

I'm closing this ticket, given that it's possible to use this approach without actually using the server-side addon


Add dask/ml.py to pytest exclude list

Follow up from https://github.com/dask/dask/pull/6384 "Add dask.ml module" - the file dask/ml.py needs to be in the pytest exclude list.
The problem we see is a pytest collection error in cases when dask_ml is not installed and the pytest --doctest-modules flag is set. One case where this happens is immediately after following the Dask contributing guide instructions. Following them as written leads to a pytest collection error (observed on Linux and Mac), and this PR fixes that.

[ ] Closes #xxxx
[x] Tests added / passed
[x] Passes pre-commit run --all-files

I suspect this hasn't come up much until now because not many people use the --doctest-modules flag in pytest, but I am a little confused about why the CI doctest check didn't pick it up?

Ah, that makes sense.

Would you mind also removing the --ignore-glob "dask/ml.py" option in our doctest CI?

Sure, done that now.


What's the difference behind by using ReadItemAsync and ReadItemStreamAsync?

Hello we noticed there are two method by reading an item either with ReadItemAsync or ReadItemStreamAsync, but which one should we use in development scenario?
Basically we're looping a list of item and based on each item's id, partition key, read the corresponding object from cosmos db collection, then perform update/insert based on different business scenario. Which one here would provide us with better performance?
Thank you very much for your advice!

ReadItemAsync reads and deserializes your JSON into a strongly typed C# object. If you are modifying documents as part of your backend business logic then this makes the most sense to use.
ReadItemStreamAsync gives you a stream of the JSON document. If you have an endpoint that allows an user to access a document (without backend modifications), you can avoid the double serialization hit (from stream to C# object back to stream) by forwarding the stream directly. It's also useful if you want to modify the underlying JSON before deserializing it into your business logic models (ie data migration/versioning).
Reading a stream and deserializing into your own C# object will likely be the same performance as ReadItemAsync (assuming you're using the standard JSON.NET). The new .NET Core 3 SDK may be more performant but maybe the cosmos sdk will provide an easy switch to use that?

@mark-manticore , thank you very much for your explanation and that makes a lot of sense!


Simplify ConfigWrapperStack.push context manager

Change Summary
A tiny and slightly opinionated refactoring of some code that felt harder to read than needed.
Related issue number
None
Checklist

[x] The pull request title is a good summary of the changes - it will be used in the changelog
[x] Unit tests for the changes exist
[x] Tests pass on CI
[x] Documentation reflects the changes where applicable
[x] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

please review


Update MemoryCache.cs

Codecov Report
Attention: Patch coverage is 91.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 91.07%. Comparing base (ae08690) to head (a03f782).

Files
Patch %
Lines

FastCache.InMemory/Drivers/MemoryCache.cs
91.66%
0 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   91.04%   91.07%   +0.03%
==========================================
  Files          23       23
  Lines         480      493      +13
  Branches       87       90       +3
==========================================
+ Hits          437      449      +12
  Misses         21       21
- Partials       22       23       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Reduce overestimation of 'longestAddress' for minUTxOVal calculation

[ ] I have ...


Magnet file added to Transmission as paused even with "addpaused = no"

One of my flexget tasks uses thetvdb_lookup and content_filename to get the right path and filename for an Anime show. After the torrent magnetizes and the file gets renamed, the torrent stays as paused in Transmission. The other task I have doesn't use thetvdb_lookup or content_filename and starts downloading as soon as the torrent magnetizes.
Here is my config.yml for the problematic task:
templates:
  torrent:
    transmission:
      host: localhost
      port: 9091
      username: ******
      password: ******
      main_file_only: yes
      include_subs: yes
      magnetization_timeout: 90
      addpaused: no
  tv:
    template: torrent
    series:
      settings:
        all:
          quality: 720p+
          specials: no
tasks:
  sutorrents:
    template: tv
    thetvdb_lookup: yes
    rss:
      url: http://latorrent.com/anime/?rss=1
      link: torrent:magnetURI
    set:
      path: /media/samsung/Shows/{{tvdb_series_name}}/Season {{tvdb_season}}/
      content_filename: "{{ tvdb_series_name }} - {{ tvdb_season }}x{{ tvdb_episode|pad(2) }}"
    series:
      all:
        - Naruto Shippuuden:
            from_group: DeadFish

And here is what flexget --debug execute spits out for the task in question:
2015-12-03 13:12 DEBUG    series        sutorrents      adding release <SeriesParser(data=[DeadFish] Naruto Shippuuden - 440 [720p][AAC].mp4,name=Naruto Shippuuden,id=440,season=0,episode=440,quality=720p aac,proper=0,status=OK)> into episode
2015-12-03 13:12 DEBUG    series        sutorrents      -> added <Release(id=None,quality=720p aac,downloaded=None,proper_count=0,title=[DeadFish] Naruto Shippuuden - 440 [720p][AAC].mp4)>
2015-12-03 13:12 DEBUG    series        sutorrents      Naruto Shippuuden episode type totals: {u'sequence': 1}
2015-12-03 13:12 VERBOSE  series        sutorrents      identified by is currently on `auto` for Naruto Shippuuden. Multiple id types may be accepted until it locks in on the appropriate type.
2015-12-03 13:12 DEBUG    series        sutorrents      identified_by set to 'auto' based on series history
2015-12-03 13:12 DEBUG    series        sutorrents      start with episodes: [u'[DeadFish] Naruto Shippuuden - 440 [720p][AAC].mp4']
2015-12-03 13:12 DEBUG    series        sutorrents      current episodes: [u'[DeadFish] Naruto Shippuuden - 440 [720p][AAC].mp4']
2015-12-03 13:12 DEBUG    series        sutorrents      quality req: 720p+
2015-12-03 13:12 DEBUG    series        sutorrents      -------------------- process_propers -->
2015-12-03 13:12 DEBUG    series        sutorrents      propers - downloaded qualities: {}
2015-12-03 13:12 DEBUG    series        sutorrents      continuing w. episodes: [u'[DeadFish] Naruto Shippuuden - 440 [720p][AAC].mp4']
2015-12-03 13:12 DEBUG    series        sutorrents      best episode is: [DeadFish] Naruto Shippuuden - 440 [720p][AAC].mp4
2015-12-03 13:12 DEBUG    series        sutorrents      -------------------- episode tracking -->
2015-12-03 13:12 DEBUG    series        sutorrents      get_latest_release returning None, no downloaded episodes found for: Naruto Shippuuden
2015-12-03 13:12 DEBUG    series        sutorrents      latest download: None
2015-12-03 13:12 DEBUG    series        sutorrents      current: <Episode(id=124,identifier=440,season=0,number=440)>
2015-12-03 13:12 VERBOSE  task          sutorrents      ACCEPTED: `[DeadFish] Naruto Shippuuden - 440 [720p][AAC].mp4` by series plugin because matches quality
2015-12-03 13:12 DEBUG    urlrewriter   sutorrents      Checking 1 entries
2015-12-03 13:12 DEBUG    download      sutorrents      Accepting magnet url for [DeadFish] Naruto Shippuuden - 440 [720p][AAC].mp4
2015-12-03 13:12 VERBOSE  details       sutorrents      Summary - Accepted: 1 (Rejected: 0 Undecided: 24 Failed: 0)
2015-12-03 13:12 DEBUG    transmission  sutorrents      Successfully connected to transmission.
2015-12-03 13:12 DEBUG    api_tvdb      sutorrents      Looking up tvdb information for {u'tvdb_id': None, u'name': u'Naruto Shippuuden'}
2015-12-03 13:12 DEBUG    api_tvdb      sutorrents      Series <name=Naruto Shippuuden,tvdb_id=None> not found in cache, looking up from tvdb.
2015-12-03 13:12 DEBUG    requests      sutorrents      Fetching http://www.thetvdb.com/api/GetSeries.php?seriesname=Naruto%20Shippuuden&language=en
2015-12-03 13:12 DEBUG    requests      sutorrents      Fetching http://www.thetvdb.com/api/4D297D8CFDE0E105/mirrors.xml
2015-12-03 13:12 DEBUG    requests      sutorrents      Fetching http://thetvdb.com/api/4D297D8CFDE0E105/series/79824/en.xml
2015-12-03 13:12 DEBUG    api_tvdb      sutorrents      Looking up tvdb information for {u'tvdb_id': 79824, u'name': u'Naruto Shippuuden'}
2015-12-03 13:12 DEBUG    api_tvdb      sutorrents      Series <name=Naruto Shippuuden,tvdb_id=79824> information restored from cache.
2015-12-03 13:12 DEBUG    api_tvdb      sutorrents      Episode Naruto Shippuden.440 not found in cache, looking up from tvdb.
2015-12-03 13:12 DEBUG    requests      sutorrents      Fetching http://thetvdb.com/api/4D297D8CFDE0E105/series/79824/absolute/440/en.xml
2015-12-03 13:12 INFO     transmission  sutorrents      "[DeadFish] Naruto Shippuuden - 440 [720p][AAC].mp4" torrent added to transmission
2015-12-03 13:12 DEBUG    transmission  sutorrents      Waiting 90 seconds for "[DeadFish] Naruto Shippuuden - 440 [720p][AAC].mp4" to magnetize
2015-12-03 13:13 DEBUG    transmission  sutorrents      File [DeadFish] Naruto Shippuuden - 440 [720p][AAC].mp4 renamed to Naruto Shippuden - 17x79.mp4
2015-12-03 13:13 DEBUG    transmission  sutorrents      Downloading 1 of 1 files in torrent.
2015-12-03 13:13 DEBUG    series        sutorrents      on_task_learn
2015-12-03 13:13 DEBUG    series        sutorrents      marking 1 releases as downloaded for <Entry(title=[DeadFish] Naruto Shippuuden - 440 [720p][AAC].mp4,state=accepted)>
2015-12-03 13:13 DEBUG    seen          sutorrents      Learned '52BA27A861C974EDD5B96DCBB8E22BBBFA893318' (field: torrent_info_hash)
2015-12-03 13:13 DEBUG    seen          sutorrents      Learned '[DeadFish] Naruto Shippuuden - 440 [720p][AAC].mp4' (field: title)
2015-12-03 13:13 DEBUG    seen          sutorrents      Learned 'magnet:?xt=urn:btih:52BA27A861C974EDD5B96DCBB8E22BBBFA893318&dn=deadfish+naruto+shippuuden+440+720p+aac+mp4&tr=udp%3A%2F%2Ftracker.publicbt.com%2Fannounce&tr=udp%3A%2F%2Fglotorrents.pw%3A6969%2Fannounce' (field: url)
2015-12-03 13:13 DEBUG    util.simple_persistence sutorrents      Flushing simple persistence for task sutorrents to db.
2015-12-03 13:13 DEBUG    task_queue                    task queue shut down
2015-12-03 13:13 INFO     ipc.rpyc                      server has terminated
2015-12-03 13:13 INFO     ipc.rpyc                      listener closed
2015-12-03 13:13 DEBUG    util.simple_persistence                 Flushing simple persistence for task None to db.
2015-12-03 13:13 DEBUG    manager                       Shutting down

Is this a limitation or something I haven't setup properly?

Nothing in that debug from what I can tell is wrong. So I'm not exactly sure what the issue is.

Anything I can do to help debugging the issue? I can reproduce it consistently.

I'm using the latest version of Flexget and transmissionrpc:
$ flexget -V
1.2.399
You are on the latest release.
$ pip show transmissionrpc
---
Metadata-Version: 1.1
Name: transmissionrpc
Version: 0.11

I don't personally use transmission myself. I've looked through the code a few times but not familiar with it. Will check it out if I can.

Couple of questions:
What is the default state for adding torrents to your client? Do they start automatically or are they added paused?
Second, you say that the torrent "stays" paused. By default Magnet links are added in an unpaused state because they have to magnetize before rename. So does the magnet add in an unpaused state THEN pause, or is it added in a paused state from the start?

Default is adding the torrents in the unpaused state. Magnet links are never paused.

I'm running Flexget and Transmission on a Raspberry Pi 2.
The Magnet link gets added unpaused. As soon as it magnetizes and gets renamed, it also gets paused.
The other task I have (which doesn't rename) has never displayed this problem.

this is my test:
tasks:
  testt1:
    disable:
      - seen
      - seen_info_hash
    thetvdb_lookup: yes
    mock:
      - { title: 'The.Big.Bang.Theory.S09E11.HDTV.x264-LOL[ettv]', url: 'magnet:?xt=urn:btih:DCC70364B791CB6CEBAADA04C4093C220D8257EE&dn=The+Big+Bang+Theory+S09E11+HDTV+x264-LOL%5Bettv%5D&tr=udp%3A%2F%2Ftracker.glotorrents.com%3A6969%2Fannounce&tr=udp%3A%2F%2Fglotorrents.pw%3A6969%2Fannounce&tr=http%3A%2F%2Ftracker.trackerfix.com%2Fannounce&tr=udp%3A%2F%2Feddie4.nl%3A6969%2Fannounce&tr=udp%3A%2F%2F9.rarbg.to%3A2710%2Fannounce&tr=udp%3A%2F%2F9.rarbg.me%3A2710%2Fannounce&tr=udp%3A%2F%2Ftracker.aletorrenty.pl%3A2710%2Fannounce&tr=udp%3A%2F%2Ftracker.opentrackr.org%3A1337%2Fannounce&tr=http%3A%2F%2Ftracker.tfile.me%2Fannounce&tr=http%3A%2F%2Fexplodie.org%3A6969%2Fannounce&tr=udp%3A%2F%2Fp4p.arenabg.com%3A1337&tr=http%3A%2F%2Fbigfoot1942.sektori.org%3A6969%2Fannounce&tr=udp%3A%2F%2Fopen.demonii.com%3A1337%2Fannounce&tr=udp%3A%2F%2Ftracker.openbittorrent.com%3A80%2Fannounce&tr=udp%3A%2F%2Ftracker.trackerfix.com%3A80%2Fannounce&tr=udp%3A%2F%2Ftracker.coppersurfer.tk%3A6969%2Fannounce' }
    all_series:
      tracking: backfill
    accept_all: yes
    transmission:
      host: <IP_ADDRESS>
      port: 9092
      addpaused: no
      main_file_only: yes
      include_subs: yes
      magnetization_timeout: 90
      path: C:\Storage\Videos\Stage\series
      content_filename: "{{ tvdb_series_name }} - {{ tvdb_season }}x{{ tvdb_episode|pad(2) }}"

output:
2015-12-27 13:40 VERBOSE  task_queue                    There are 1 tasks to execute. Shutdown will commence when they have completed.
2015-12-27 13:40 VERBOSE  details       testt1          Produced 1 entries.
2015-12-27 13:40 VERBOSE  task          testt1          ACCEPTED: `The.Big.Bang.Theory.S09E11.HDTV.x264-LOL[ettv]` by series plugin because choosing best available quality
2015-12-27 13:40 VERBOSE  details       testt1          Summary - Accepted: 1 (Rejected: 0 Undecided: 0 Failed: 0)
2015-12-27 13:40 INFO     api_tvdb      testt1          Setting all series to expire
2015-12-27 13:40 VERBOSE  api_tvdb      testt1          Data for The Big Bang Theory has expired, refreshing from tvdb
2015-12-27 13:40 INFO     transmission  testt1          "The.Big.Bang.Theory.S09E11.HDTV.x264-LOL[ettv]" torrent added to transmission

the torrent is added and downloaded immediatley and stay unpaused, as intended behaviour.
oh and the file gets renamed too, The Big Bang Theory - 9x11.mp4.part.
can you try your config on a different machine?
(transmission v2.84 on Windows 7 here)

Hi there, I added a 3 second sleep right before starting the torrent in plugin_transmission.py and the problem has completely disappeared.
As I mentioned, I'm running Flexget and Transmission on a Raspberry Pi 2 and the target disk is an external USB drive which is in power-save mode most of the time.
My hypothesis is that cli.start_torrent(r.id) gets called before the USB drive has waken up and the file has been renamed. Does it make sense at all? If so, why would the renaming operation not be synchronous?
The following is the patch I'm running. I understand this is not the correct solution but I'd appreciate your feedback before I create a proper PR.
diff --git a/flexget/plugins/plugin_transmission.py b/flexget/plugins/plugin_transmission.py
index efd81dc..f30e378 100644
--- a/flexget/plugins/plugin_transmission.py
+++ b/flexget/plugins/plugin_transmission.py
@@ -588,6 +588,8 @@ class PluginTransmission(TransmissionBase):
                 # prevents downloading data before we set what files we want
                 if ('paused' in options['post'] and options['post']['paused'] == False or
                    'paused' not in options['post'] and cli.get_session().start_added_torrents == True):
+                        from time import sleep
+                        sleep(3)
                         cli.start_torrent(r.id)

             except TransmissionError as e:

Regards

In that form it would be a mandatory pause for everybody - only needed by you for now.
I think you can add something in your task to wake up your drive instead, for example the exec plugin - perhaps on_output/for_accepted - to do something like write a dummy file on that drive.
and the sleep plugin could help too.

I've been trying the exec plugin writing to a dummy file on for_accepted but I suspect that gets executed after the magnet link gets added so it doesn't help.
I agree my test patch would add delay even when not needed (and so I stated in my previous comment). However I think this race condition should not happen in any hardware configuration and that's why I was asking for some leads from you guys.
rename_torrent_path  has a timeout param which defaults to None. Am I right in assuming that would always make it wait for renaming operation to finish?

I've been trying the exec plugin writing to a dummy file on for_accepted but I suspect that gets executed after the magnet link gets added so it doesn't help.
I agree my test patch would add delay even when not needed (and so I stated in my previous comment). However I think this race condition should not happen in any hardware configuration and that's why I was asking for some leads from you guys.
rename_torrent_path has a timeout param which defaults to None. Am I right in assuming that would always make it wait for renaming operation to finish?

I've been trying the exec plugin writing to a dummy file on for_accepted but I suspect that gets executed after the magnet link gets added so it doesn't help.

and what about on_start / on_input / on_filter?

rename_torrent_path has a timeout param which defaults to None. Am I right in assuming that would always make it wait for renaming operation to finish?

I don't think so, looks like they just pass it to the http_handler object in client.py.

and what about on_start / on_input / on_filter?

That would wake the hard drive up every single time flexget gets executed, which I'd like to avoid.

That would wake the hard drive up every single time flexget gets executed

I think you can try something like:
on_filter:
  for_accepted: if {{dunno}} do whatever

it should run before the output phase.

fixed along #705

This issue didn't get fixed with the patch for #705 as the issue is exactly the opposite.

not for me, I've tried again this test and everything works as intended.


[Feature][Ready for Review] Filter by a relationship field's object id

Purpose
Addresses JIRA [OSF-5330]
Add ability to filter by a relationship field's object id. This is required for incorporating the API v2 comments routes into the commenting feature in development.
E.g. /v2/nodes/node_id/comments/?filter[target]=target_id
Changes

Update filters.py to handle RelationshipField and TargetField
Make comment target a filterable field
Test that filtering by target works

I included comment filtering in this PR so that there could be something to test this filtering with.
Note to QA: Right now, you can only filter by target=node_id, since the node comments endpoint only lists top-level comments on the node. With the commenting feature, this endpoint will return all comments and users will also be able to filter by target comment and file.

Hi @samanehsan ... JIRA ticket # for this? Thanks -

Writing it up now @lbanner!

Please update documentation to include this new query param (here and maybe here )
Pass complete, no bugs found :100:
For QA purposes, it may be worth noting in the PR that you can currently only filter by node_id due to the way comment lists are handled by the node endpoint.

Thanks for updating the description and docs.
CR complete, passing it off to @sloria.

Looks good!


Update links to MSAL Java samples

Update links for MSAL Java samples to point to our new centralized sample repo (https://github.com/Azure-Samples/ms-identity-msal-java-samples) and remove some links to older web API samples to avoid confusion with our newer web API samples.

@Avery-Dunn : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Avery-Dunn Thanks for the edit! Unfortunately, we need you to move your commit over to the private repo (azure-docs-pr) where all MSFT FTEs should be making their contributions.
The easiest way to submit quick edits like this in the private azure-docs-pr repo is by installing the SpineEdit plugin for Chromium-based browsers. All it does is add the -pr for you when you click the Edit button on an article on docs.microsoft.com and takes you to edit page directly.
https://github.com/craigshoemaker/spineedit
Trust me - it's the way to go. 🙂
I'm going to close this PR out but do let me know if you need any assistance in moving your edits over.
Thanks!
#please-close


JRuby compatibility

Hi @craiglittle,
We're migrating an app using biz to JRuby and we saw that JRuby doesn't work with these BIG_BANG and HEAT_DEATH values.
Do we really need such huge values ?
Here, for BIG_BANG, I used the default values used in Ruby when creating a new date via Date.new: -4712 and it's opposite value for HEAT_DEATH.
What do you think about this change ?

squash into a single commit

Done but I messed up a bit I think.

Yeah, it looks pretty messed at the moment. I'd suggest resetting your branch to the tip of master and applying your changes again since there aren't that many.

Done here #5


Update CodeMirror

For #12031.
Several tests fail, but most of them do fail on master, too, so I suppose it's not my fault.
 There was a slight behavior change in codemirror/CodeMirror@1fae53703cf4099d4f4855ef18dd14d60514c82f which makes these tests fail.
This change could theoretically affect inline editors, but in my manual testing I didn't face any issues.
For more reference on this change, see https://github.com/codemirror/CodeMirror/issues/3699.
Fixes #11905, #11683, and a whole lot more.

@MarcelGerber++ :+1:

Thanks @MarcelGerber :+1:

Tagging @swmitra

@MarcelGerber I know these tests failed before your update. But do you think we can fix them in this PR to make sure we are not introducing regressions? It would awesome to have peace of mind.

It would be nice to explicitly call out which version of CodeMirror we are updating to. :)

@MarcelGerber I found the particular change in CodeMirror that is causing this regression.  I am going to dig in a little bit more to see if I can find the reason why the change was made. The question is whether or not that is the correct behavior in CodeMirror.
https://github.com/codemirror/CodeMirror/commit/1fae53703cf4099d4f4855ef18dd14d60514c82f?diff=unified

Well, this thread has the history of why the change of was made.  https://github.com/codemirror/CodeMirror/issues/3658

@MarcelGerber I found what we have to change on our side. The changes in codemirror actually seem to make things more consistent in behavior.  I am still running tests.
https://github.com/adobe/brackets/blob/master/src/editor/Editor.js#L1507
That line would change to {line: to - 1, ch: 0}.  We don't need to figure out the length anymore; CodeMirror will take the while line.

@MarcelGerber - BTW - if you want to see a visual of the behavior:

go to https://codemirror.net/index.html
open the browser console. We are going to execute the following commands
visibleRange1 = editor.markText({line: 0, ch: 0}, {line: 4, ch: 0}, {collapsed: true, inclusiveLeft: true, inclusiveRight: true, clearWhenEmpty: false});
visibleRange2 = editor.markText({line: 5, ch: 0}, {line: 8, ch: 0}, {collapsed: true, inclusiveLeft: true, inclusiveRight: true, clearWhenEmpty: false});
Select anything spanning multiple lines. e.g  editor.setSelection({line: 0, ch: 0}, {line: 8, ch: 0});
Now clear both markers to see the selected text.  visibleRange1.clear() and visibleRange2.clear()
Checkout the selected range. editor.doc.sel

That selects the whole line regardless of what's around, which is the behavior we want when we are hiding lines as the unit test does.

I found an odd behavior in CodeMirror that is causing our particular unit test failures.  I have provided information over on the CodeMirror side.

@MarcelGerber I think the issue is fixed in the latest code mirror.  https://github.com/codemirror/CodeMirror/releases/tag/5.13.0.  Gotta bring it down and test it.

Now is exit a new version of Code Mirror https://github.com/codemirror/CodeMirror/releases/tag/5.13.2

Thanks for pointing that out!
I've updated to the latest version and now these tests, after being re-enabled pass again.

@MarcelGerber CodeMirror had a couple of changes around ranges that fixed the issue :)

I pull your branch. I am running today with it and things go well, we can merge?

Surely we can!
I've just now squashed the commit to get them down to only 2.

things seem to work ok. I will merge now so that more people can get to test this update early.  Thank you @MarcelGerber !!


Replace AjaxModalExtensionUtil with UrlModalPlugin

1. Why is this change necessary?
The AjaxModalExtensionUtil is added event handlers to everything its selector matches globally everytime it is instantiated. This leads to some bugs when using the CookieManager or custom invokes of the AjaxModalExtensionUtil.
2. What does this change do, exactly?

Deprecate AjaxModalExtensionUtil and stops using it
Use the UrlModalPlugin instead
Add docs how to do modals properly

3. Describe each step to reproduce the issue or behaviour.

Visit shopwaredemo.store
Open the cookie configuration
Close the cookie configuration
Open a modal like the contact form (misconfigured on shopwaredemo.store)
See it open twice

4. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[x] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Hi @JoshuaBehrens , I've read through this but have a few questions, would you be willing to explain your approach here a bit? :slightly_smiling_face: Since you're changing the core anyway, wouldn't it be easier to repair the existing solution instead of replacing it completely? As far as I can tell, both should do the same thing, the existing one just registers too many listeners, right?

You are right. I could just change the way it registers events. But the existing one is not a plugin. A plugin is already able to handle duplicate registration. The existing class is just providing some static functions. Having it part of the plugin system it is far easier to add functionalities with third party plugins.

Alright, thanks for the clarification, I didn't quite realise that this is now a plugin :+1:

Aaaand a rebase is out as well :)

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-12535
Please use this issue to track the state of your pull request.

@JoshuaBehrens , so I forgot to set a label... Would you mind updating this PR with the changelog etc.? 😄

@JoshuaBehrens , so I forgot to set a label... Would you mind updating this PR with the changelog etc.? 😄

Hello, we're closing this pull request due to inactivity. If this change is still important to you, feel free to create a new pull request.
For more information about our contribution guidelines, see https://docs.shopware.com/en/shopware-platform-dev-en/contribution/contribution-guideline.

Hello, we're closing this pull request due to inactivity. If this change is still important to you, feel free to create a new pull request.
For more information about our contribution guidelines, see https://docs.shopware.com/en/shopware-platform-dev-en/contribution/contribution-guideline.


Set default vehicle restrictions for roads

Describe your idea
The ability to set default vehicle restrictions for different roads.
The restrictions set by the player would automatically apply to the road when placed.
Screenshots?
https://imgur.com/a/MxPGOCb
Notes or questions?
This would be really useful when building large pedestrian areas.

Duplicate of #275


Short solution needed: "How to change keyboard layout in CLI" (ubuntu)

Please help us write most modern and shortest code solution for this issue:
How to change keyboard layout in CLI (technology: ubuntu)
Fast way
Just write the code solution in the comments.
Prefered way

Create pull request with a new code file inside inbox folder.
Don't forget to use comments to make solution explained.
Link to this issue in comments of pull request.

How to change keyboard layout in CLI


:sparkles: Release 2.2.0

Closes #244
Closes #246
Closes #247
Closes #251

Closing this. See https://github.com/SnailyCAD/snaily-cadv4


Lens correction

Is there a way to apply lens correction for streams coming from Oculus Quest / Go?  With a recorded MP4 video file I can use ffmpeg like this to fix up lens distortion:
ffmpeg -i input.mp4 -vf 'lenscorrection=k2=0.1:k1=-0.4' -r 24 output.mp4
Is it possible for the output of scrcpy to be corrected in realtime?

Just realised that the lens correction makes it a bit skinny.  Aspect ratio should be 1:1 so I now use:
ffmpeg -i input.mp4 -vf 'lenscorrection=k2=0.1:k1=-0.4,scale=1024x1024' -r 24 output.mp4

I have been wishing for the same thing.  There isn't anything you can do about scrcpy by itself.  However in OBS there is a Lens Distortion Filter you can youtube "How To REMOVE GO PRO FISHEYE LENS In OBS - Fisheye Correction Filter" (not sure if links are allowed but googleable and youtubeable search parameters).  I downloaded this recently and tested with -0.15 "power" and under OBS for both recording and streaming and attached this to scrcpy itself was able to get it pretty dialied in (flat) for 720p.

https://user-images.githubusercontent.com/76272525/102704720-0c3a6280-424d-11eb-8a6e-7fe9398253f0.mp4
The effect needs to be dialed in a bit more then -0.15 but it gets ya pretty close.  This was using the filter i mentioned.
OBS: Open Broadcaster Software, and the fisheye filter ... had to compress the hell outa it to upload here, so sorry, no audio.

Just realised that the lens correction makes it a bit skinny. Aspect ratio should be 1:1 so I now use: ffmpeg -i input.mp4 -vf 'lenscorrection=k2=0.1:k1=-0.4,scale=1024x1024' -r 24 output.mp4
this is after using scrcpy with this parameter to make sure I only get one lens view: scrcpy -c 1440:1600:0:0 -m 1600

Can I ask how you came up with the values to supply to the lenscorrection parameter?

Can I ask how you came up with the values to supply to the lenscorrection parameter?

i have a feeling its a lot of guess and check, i remember trying this kind of thing a while ago and i had no good method for finding the right parameters other than guess and check.
tools like GIMP can help get a starting point for guessing the lens params but from there if you want to do the correction in realtime, you need to pipe the video directly into FFPLAY.
i think i made a gist on this on how i went about doing it with the quest 3 but i haven't touched it in a while, i remember one of the TODOs in it was "fix lens distortion" because i still didn't have a great method for determining it.
i guess this is a excuse to go out there and see if i can do this properly for once.


add flag for generalizing batch matmul ops

https://github.com/iree-org/iree/pull/17877

Make sure to rebase and drop the flag added by me before: https://github.com/nod-ai/sdxl-scripts/commit/5ed406e01d4d8d9410f5ea929e1538cff76740a6


Tag for version 2.12 is missing

Hello,
I think a few weeks ago it was possible to get version 2.12 from master branch.
Also OpenFOAM (https://develop.openfoam.com/Development/ThirdParty-common/-/blob/master/SOURCES.txt) are reference to version 2.12.
Where is the version 2.12 sources to download?

Hey,
you can find it here algo2.iti.kit.edu/schulz/software_releases/KaHIP_2.12.tar.gz
Best
Christian
p.s. sorry there is no tag for 2.12

of course, but why no tag in git repository for version 2.12?

why I will an tag?
I build container images for openfoam and some other applications.

Hi Thomas,
the functionality that you are using through OpenFOAM is unchanged in the current release (and master branch), why don't you just use the new master branch if you got KaHIP from there before or from the new release tag?
Best
Christian

I used the master branch a few month ago, as it pointed to v2.12.
Actually I have got an build issue (linking error to KaHIP).
And with my mind / thinking a "major version change" has changing's there are not compatible for code that offical use a older version.
Git is a version managment software. Why do you not use this capability?
Tag an offical release, ... opening an maintenance branch, ... and so on
So, one of many build/link errors (mostly looks the same) with actually master branch
(I know the build issues are problems of OpenFOAM, but to tag an 2.12 version here is your problem)
/usr/bin/ld: /opt/OpenFOAM/OpenFOAM-latest/ThirdParty/platforms/linux64GccDPInt32/lib/libkahip.so: undefined reference to `nested_dissection::ordering() const'
/usr/bin/ld: /opt/OpenFOAM/OpenFOAM-latest/ThirdParty/platforms/linux64GccDPInt32/lib/libkahip.so: undefined reference to `nested_dissection::perform_nested_dissection(PartitionConfig&)'
/usr/bin/ld: /opt/OpenFOAM/OpenFOAM-latest/ThirdParty/platforms/linux64GccDPInt32/lib/libkahip.so: undefined reference to `nested_dissection::nested_dissection(graph_access*)'
/usr/bin/ld: /opt/OpenFOAM/OpenFOAM-latest/ThirdParty/platforms/linux64GccDPInt32/lib/libkahip.so: undefined reference to `mapping_algorithms::construct_a_mapping(PartitionConfig&, graph_access&, matrix&, std::vector<unsigned int, std::allocator<unsigned int> >&)'
/usr/bin/ld: /opt/OpenFOAM/OpenFOAM-latest/ThirdParty/platforms/linux64GccDPInt32/lib/libkahip.so: undefined reference to `mapping_algorithms::mapping_algorithms()'
/usr/bin/ld: /opt/OpenFOAM/OpenFOAM-latest/ThirdParty/platforms/linux64GccDPInt32/lib/libkahip.so: undefined reference to `mapping_algorithms::~mapping_algorithms()'

Hi Thomas,
thanks for the input, will fix the linking errors tomorrow.
Meanwhile, you can also use github to pull 2.10 from here https://github.com/KaHIP/KaHIP/tree/357bebb13e0384b80a191eb3af0dbed2cde536db
Best
Christian

Thanks for your fast reply's (really fast).

I just had a look, I am actually not building libkahip.so myself  ...
I am building the shared library libinterface.so and the static one libinterface.a (the static one is rename to libkahip.a in deploy, the shared one is not copied atm when using the build bash script). Both of them contain the mapping and node ordering symbols. Not sure where this is coming from, but you should link against libinterface.so. Could you tell me which OpenFOAM repo/version you are using so I can have a look?
Best
Christian
p.s. regarding the tag, i will see how i can create a release tag from an old commit, but this may take a day or two

Okay, there is now a release tag for v2.12.
All the best
Christian

I use OpenFOAM from openfoam.com. OpenFOAM++ in the past.
OF_GIT_URL="https://develop.openfoam.com/Development/openfoam.git"
OF_TP_GIT_URL="https://develop.openfoam.com/Development/ThirdParty-common.git"

The v2006 version naming for kahip is "kahip-$Version".
I use ubuntu:20.04 (I had my self, why do not use centos:8 :D That makes some dependices simpler ).
Link to my buildah script

And thank you much for the tag.
I test it tommorw evening.
Climbing with the my wife has a higher priority in the next 24 hours ;-)

Your taged "2.12" version does also not work :(
Seems the symbols does not exist

The taged version "2.12" in git repository is different to the offical release tar archive.
Also build error in taged 2.12 git version

...
/usr/bin/ld: /opt/OpenFOAM/OpenFOAM-latest/ThirdParty/platforms/linux64GccDPInt32/lib/libkahip.so: undefined reference to `nested_dissection::ordering() const'
/usr/bin/ld: /opt/OpenFOAM/OpenFOAM-latest/ThirdParty/platforms/linux64GccDPInt32/lib/libkahip.so: undefined reference to `nested_dissection::perform_nested_dissection(PartitionConfig&)'
/usr/bin/ld: /opt/OpenFOAM/OpenFOAM-latest/ThirdParty/platforms/linux64GccDPInt32/lib/libkahip.so: undefined reference to `nested_dissection::nested_dissection(graph_access*)'
/usr/bin/ld: /opt/OpenFOAM/OpenFOAM-latest/ThirdParty/platforms/linux64GccDPInt32/lib/libkahip.so: undefined reference to `mapping_algorithms::construct_a_mapping(PartitionConfig&, graph_access&, matrix&, std::vector<unsigned int, std::allocator<unsigned int> >&)'
/usr/bin/ld: /opt/OpenFOAM/OpenFOAM-latest/ThirdParty/platforms/linux64GccDPInt32/lib/libkahip.so: undefined reference to `mapping_algorithms::mapping_algorithms()'
/usr/bin/ld: /opt/OpenFOAM/OpenFOAM-latest/ThirdParty/platforms/linux64GccDPInt32/lib/libkahip.so: undefined reference to `mapping_algorithms::~mapping_algorithms()'
collect2: error: ld returned 1 exit status

...
/usr/bin/ld: /opt/OpenFOAM/OpenFOAM-latest/ThirdParty/platforms/linux64GccDPInt32/lib/libkahip.so: undefined reference to `nested_dissection::ordering() const'
/usr/bin/ld: /opt/OpenFOAM/OpenFOAM-latest/ThirdParty/platforms/linux64GccDPInt32/lib/libkahip.so: undefined reference to `nested_dissection::perform_nested_dissection(PartitionConfig&)'
/usr/bin/ld: /opt/OpenFOAM/OpenFOAM-latest/ThirdParty/platforms/linux64GccDPInt32/lib/libkahip.so: undefined reference to `nested_dissection::nested_dissection(graph_access*)'
/usr/bin/ld: /opt/OpenFOAM/OpenFOAM-latest/ThirdParty/platforms/linux64GccDPInt32/lib/libkahip.so: undefined reference to `mapping_algorithms::construct_a_mapping(PartitionConfig&, graph_access&, matrix&, std::vector<unsigned int, std::allocator<unsigned int> >&)'
/usr/bin/ld: /opt/OpenFOAM/OpenFOAM-latest/ThirdParty/platforms/linux64GccDPInt32/lib/libkahip.so: undefined reference to `mapping_algorithms::mapping_algorithms()'
/usr/bin/ld: /opt/OpenFOAM/OpenFOAM-latest/ThirdParty/platforms/linux64GccDPInt32/lib/libkahip.so: undefined reference to `mapping_algorithms::~mapping_algorithms()'
collect2: error: ld returned 1 exit status
make[2]: *** [/opt/OpenFOAM/OpenFOAM-latest/wmake/makefiles/general:150: /opt/OpenFOAM/OpenFOAM-latest/platforms/linux64GccDPInt32Opt/bin/snappyHexMesh] Error 1
make[1]: *** [/opt/OpenFOAM/OpenFOAM-latest/wmake/makefiles/apps:29: generation] Err

...
/usr/bin/ld: /opt/OpenFOAM/OpenFOAM-latest/ThirdParty/platforms/linux64GccDPInt32/lib/libkahip.so: undefined reference to `nested_dissection::ordering() const'
/usr/bin/ld: /opt/OpenFOAM/OpenFOAM-latest/ThirdParty/platforms/linux64GccDPInt32/lib/libkahip.so: undefined reference to `nested_dissection::perform_nested_dissection(PartitionConfig&)'
/usr/bin/ld: /opt/OpenFOAM/OpenFOAM-latest/ThirdParty/platforms/linux64GccDPInt32/lib/libkahip.so: undefined reference to `nested_dissection::nested_dissection(graph_access*)'
/usr/bin/ld: /opt/OpenFOAM/OpenFOAM-latest/ThirdParty/platforms/linux64GccDPInt32/lib/libkahip.so: undefined reference to `mapping_algorithms::construct_a_mapping(PartitionConfig&, graph_access&, matrix&, std::vector<unsigned int, std::allocator<unsigned int> >&)'
/usr/bin/ld: /opt/OpenFOAM/OpenFOAM-latest/ThirdParty/platforms/linux64GccDPInt32/lib/libkahip.so: undefined reference to `mapping_algorithms::mapping_algorithms()'
/usr/bin/ld: /opt/OpenFOAM/OpenFOAM-latest/ThirdParty/platforms/linux64GccDPInt32/lib/libkahip.so: undefined reference to `mapping_algorithms::~mapping_algorithms()'
collect2: error: ld returned 1 exit status

Is that a problem with the SCons scripts?
In the offical release there are one bash compile.sh and SConstruct + Sconscript in the root directory.

Are you using the correct kahip interface? The symbols you are missing are symbols that have been added with the last release. They are also contained in the interface of that tag. So i am not sure if the problem is ok this side.
Best
Christian

Hey, if I'm not mistaken, the exact v2.12 version bundled with OpenFOAM is ad07d2d (not 5c275e1)
ad07d2d still includes the scons scripts, so it's probably worth getting this right

Thanks Daniel!
v2.12 is now pointing to that commit.
Thomas: can you check if you still have any problems?

Did you at some point call make install and are now linking and including the wrong files?

Hallo Christian und Daniel,
zur erst bitte ich um Verständnis für die deutlich verstätete Antwort, welche sich Aufgrund einer kirchlichen Hochzeit in den Bergen, unter einem Kreuz im Freiem.


Use the Lucide sprite instead of injecting individual SVGs onto the page

Hey there @allmarkedup 👋 it's me again 😄
A co-worker noticed the Primer Lookbook instance loading quite slowly and discovered there are ~600 SVGs on many of our pages. It looks like Lookbook copies the SVG source onto the page for every icon, which the co-worker surmised is leading to long render times on the server. I noticed Lookbook comes with a sprite that includes all the Lucide icons in the img/ directory, so I thought maybe we could just use that instead?
I tried replacing the SVG source with a <use> element, and it seems to work nicely. Page render times seem to be a little speedier too, although I won't know how much impact it has on Primer's Lookbook instance until we deploy to prod.
Let me know what you think 😄

Hey @camertron, thanks for this!
So funnily enough, this is exactly how Lookbook used to serve icons - that is why that sprite is there :) But I wasn't too happy about sending a 300+kb sprite over the wire when the UI only used a handful of different icons, so I switched to inlining the SVGs instead.
However... I suspect what I hadn't accounted for is that for apps with large amounts of previews will have a lot of nav items, each of which contains a few icons which if they are all inlined could definitely start making the size of the DOM quite chunky. I've just 'viewed-source' on the Primer Lookbook UI and it's definitely pretty huge which will for sure affect performance of page updates.
As the sprite will get cached but the inlined SVGs won't I guess it does make sense to go back to this way of doing things, especially to benefit the larger Lookbook installs. And to be honest at some point in the future I'm sure it wouldn't be too difficult to generate a custom sprite with just the subset of icons that Lookbook actually uses.
I'm not sure it will make a_huge_ difference to performance but every little helps. I'll also try to have a think about other ways that performance could be improved for larger installs too, it's not something I've put a lot of time into up until now if I'm honest.
I'll give this a test and unless I run into any issues I'll merge it in and get it out in the next release. Thank you!

All looking good @camertron 👍
I'm going to merge this in now and when I have a chance I'll try to have a play with putting together a build task for a custom sprite with just the icons that are actually used in the UI.
Thanks for the PR and let me know if you think it makes any difference to the UI sluggishness. I've got a few other ideas for improving performance that I'm going to have a think about too, if I get anything concrete together I'll let you know :)

Awesome, thank you!


ReferenceError: mermaid is not defined

Describe the bug 描述你遇到的错误
when i use mermaid in my posts, ReferenceError: mermaid is not defined

Mermaid should be supported out of the box without any further configuration. And it seems to work correctly on the demo site. Can you provide more information? Does refreshing the page help? Does the HTML include the script tag for Mermaid? Or if you can provide a demo site with its source files that reproduces this issue will be very helpful.

thanks, i saw this error when i build my blog at localhost.
it works well after i published to server

thanks, i saw this error when i build my blog at localhost.
it works well after i published to server


Game not being detected unless started from EldenRingFpsUnlockAndMore

the patcher keeps saying "waiting for game" when starting the game from steam or the start_protected_game.exe (not actual EAC exe)

The directions say to start it from EldenRingFpsUnlockAndMore. That's probably why.

I managed to fix my issue by using a different method to disable eac. The method is explained on this mod's page: https://github.com/soupstream/EldenRingStutterFix
You may also have to set read-only so the file doesn't get deleted.


Loader breaks the teal header on Services Listing

On iOS, the loader breaks the teal header in the Services Listing page when the page is loading. The loader should be just below the header block because it is the services that are loading and not the whole page.

Rationale:
Visual cohesion and also to indicate to the user that it is the services that are loading and not the entire page
Difficulty, impact:
|--(technical difficulty)--| -- SHOULD do -- |

Acceptance Criteria:

[ ] Loader is below the teal header block on the Services Listing and no longer breaks the header block when services are loading

*** Comments from @tomy-pg :
I could not stop the spinner from breaking the header on iOS.
After discussion with @cherrielam she requested to make the background of the spinner teal and have the colour of the spinner be white.
Acceptance Criteria:
On iOS

[ ] spinner is coloured white
[ ] background for spinner is teal

Steps for QA:
On IOS:

Go to topics and press Find related services near me

[ ] Ensure that the spinner is coloured white and its  background colour is teal.

Issue #940 addresses this.


SquareLine Studio Howto/support?

Hi, is SquareLine Studio supported with this board, 5"
Any examples?

Sure, just transplant it

HI:
There are examples of default LVGL that can be supported, including IDF and Arduino versions
江西优奕视界光电有限公司
深圳市优奕视界有限公司
研发部-钟祥林
手机：18688799333
@.***
江西地址：江西省赣州市兴国县经济开发区南区光电产业园
深圳地址：深圳市宝安区西乡街道固戍航城大道U8智造产业园U6栋
网址： www.chinasunyee.com        专业 敬业 创新 明志
专注与类工控触摸显示一体化解决方案及智能人机交互

From: gpena208777
Date: 2024-09-05 09:02
To: VIEWESMART/ESP32-Arduino
CC: Subscribed
Subject: [VIEWESMART/ESP32-Arduino] SquareLine Studio Howto/support? (Issue #1)
Hi, is SquareLine Studio supported with this board, 5"
Any examples?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

The following file has a 404 error, and is referenced several times for set up instructions.
VIEWESMART/ESP32-Arduino/tree/main/examples)
/README.md/

The following file has a 404 error, and is referenced several times for set up instructions.
VIEWESMART/ESP32-Arduino/tree/main/examples) /README.md/

Hello, I am very glad to receive your information. I have checked your problem and it shows that everything is normal. It would be better if you could provide us with more detailed information, so that we can solve your problem faster and improve our mistakes.

the same thing, the examples don’t work, something is always missing, there are always errors. Is there a display configuration for the TFT_ESPI library?

the same thing, the examples don’t work, something is always missing, there are always errors. Is there a display configuration for the TFT_ESPI library?

hi：
I reply to your e-mail.

Где можно скачать проект который был изначально загружен на дисплей? 12:57, 26 сентября 2024 г., VIEWESMART @.***>:
the same thing, the examples don’t work, something is always missing, there are always errors. Is there a display configuration for the TFT_ESPI library?
hi：
I reply to your e-mail.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>
-- Отправлено из мобильного приложения Яндекс Почты


cv::Mat to k4a_image_t transform

Can I convert the image from CV ::mat to k4a::image?
Whether to use the k4a_image_create_from_buffer() or other?

//c++ code
//k4a::image img
if (img.get_format()==K4A_IMAGE_FORMAT_COLOR_BGRA32){
//convert the image from k4a::image to CV ::mat
cv::Mat cImg = cv::Mat(img.get_height_pixels(), img.get_width_pixels(), CV_8UC4, img.get_buffer());
//convert the image from CV ::mat to k4a::image
memcpy(img.get_buffer(), &cImg.ptr<cv::Vec4b>(0)[0], cImg.rows*cImg.cols  *sizeof(cv::Vec4b));
}

//c++ code
//k4a::image img
if (img.get_format()==K4A_IMAGE_FORMAT_COLOR_BGRA32){
//convert the image from k4a::image to CV ::mat
cv::Mat cImg = cv::Mat(img.get_height_pixels(), img.get_width_pixels(), CV_8UC4, img.get_buffer());
//convert the image from CV ::mat to k4a::image
memcpy(img.get_buffer(), &cImg.ptr<cv::Vec4b>(0)[0], cImg.rows*cImg.cols  *sizeof(cv::Vec4b));
}

thank you for your answering !
I have solved this problem by:
cv::Mat depth = cv::imread(name_depth, IMREAD_UNCHANGED);
depthImage = k4a::image::create_from_buffer(K4A_IMAGE_FORMAT_DEPTH16,1024,1024,1024 * 2,
depth.data,1024 * 1024 * 2,NULL,NULL);

Hey guys,
Thank you for your code samples!
For my program I also need to convert a BRGA Color Image from cv::Mat to k4a_image_t. Unfourtunately I'm a total beginner regarding C++ and can't get my function to work It throws an Access violation, so I'm probably doing something wrong regarding the creation of the k4a_image buffer. Can anybody help out a newbie?

k4a_image_t AzureKinectCapture::opencv_to_k4a_image(const cv::Mat cImg)
{

	k4a_image_t newImage = NULL;

	k4a_image_create(K4A_IMAGE_FORMAT_COLOR_BGRA32, cImg.cols, cImg.rows, cImg.cols * 4 * (int)sizeof(uint8_t), &newImage);

	memcpy(k4a_image_get_buffer(newImage), &cImg.ptr<cv::Vec4b>(0)[0], cImg.rows * cImg.cols * sizeof(cv::Vec4b));

	return newImage;

}

It is possible you are reading a normal RGB image. It has only 3 channels unlike Kinect which gives us an empty 4th channel. That is why you cannot copy it as a block. You need to insert these gaps.
You can convert the format of your opencv Mat from BGR to BGRA using openCV's cvtColor and then call the above function

Hi Shravya,
thank your for your answer! I just checked my code and the OpenCV-Mat I created and, was created with 4 channels:
cv::Mat cImg = cv::Mat(k4a_image_get_height_pixels(colorImage), k4a_image_get_width_pixels(colorImage), CV_8UC4, k4a_image_get_buffer(colorImage));
I solved the problem by not putting the code lines for converting the CV-Mat to k4a_image inside it's own function but instead putting them inside the same function where I created the CV Mat. It somehow works out then.
If anybody is interested, you can check out the working code here: https://github.com/MarekKowalski/LiveScan3D/blob/AzureKinect/src/LiveScanClient/azureKinectCapture.cpp


extend integration test to test a project with a service in the project root directory

As a:
spk tester
I want:
a integration test that tests a project with a service in the project root directory
So that:
I can be sure changes do not break workflows for that use case
Acceptance Criteria:

[ ] integration test that tests a project with a service in the project root directory

Additional context:
https://github.com/microsoft/bedrock/issues/1191 was a bug surfaced that should have been caught if there existed an IT.
https://github.com/microsoft/bedrock/issues/859 - epic for tracking Integration Test coverage
Does this require updates to documentation?:
No

Looks like coverage was extended by this ticket: https://github.com/microsoft/bedrock/issues/859 and PR: https://github.com/CatalystCode/spk/pull/258
Was the single application test integrated into validations.sh? @andrebriggs

@mtarng we have the https://github.com/CatalystCode/spk/blob/master/tests/single-app-repo-validation.sh file that we can integrate into validation.sh.
Our spk setup code also verifies this behavior.


Get Element States keyword in presenter mode

Describe the bug
When in presenter mode, the keyword Get Element States does not return state detached for element, which is detached. It will raise timeout error instead.
To Reproduce
Steps to reproduce the behavior:
*** Settings ***
Library     Browser    enable_presenter_mode=False

*** Test Cases ***
Test
    New Browser    headless=False
    New Page
    Go To    https://robotframework.org/
    ${state_visible_element}    Get Element States    //h1[@class='title']    evaluate    visible in value
    ${state_detached_element}    Get Element States    //h1[@class='wrong_title']    evaluate    detached in value

Expected behavior
When presenter mode is not active, the code works just fine. When I set presenter mode as active, the first Get Element State works (the element is there), but the second one doesn't. The element is not there, but it should return detached instead of the error message.
Desktop (please complete the following information):

OS: Windows 10, build 19044.1706
Browser: Chromium
Version: 102.0.5005.40 (Developer Build) (64-bit)

Could it be that this is not expected behavior after all?
I've got keyword which uses Get Element States to get boolen value for hidden state (quite similar as example in Browser library keyword documentation) and it works just fine in presenter mode with Browser library v.12.1.0 but does not work with any later library versions.

Will be fixed with #2109


Multiple Instances

Hi, is it possible to open more instances??
Thanks

Longer answer: it's possible to add the option to support multiple instances, but it depends on what do you need it for.
Simultaneously working with multiple lists? Sounds interesting, yet it's seems possible without multi-instancing (just enable opening multiple windows and catching sign out event to close them all).
Multiaccounting? Not sure, all the instances share one cache and cookie storage, so it's potentially breaking. And if we still consider doing that, it's still possible with just multiple windows.
I'm curious about other possible use cases of the subject.