[chat] Fix coati-sft-Instruction Tuning

📌 Checklist before creating the PR

[ ] I have created an issue for this PR for traceability
[x] The title follows the standard format: [doc/gemini/tensor/...]: A concise description
[x] I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge
e.g. fixed #1234, closed #1234, resolved #1234

📝 What does this PR do?

Fix coati-sft-Instruction Tuning (applications/Chat/coati/dataset/sft_dataset.py)

Multiple unnecessary copy.deepcopy leads to slow tokenizer
Use tokenizer.eos_token instead of the fixed <|endoftext|>
Fix input_ids
Fix wrong attribute name self.prompts
Fix NameError: name 'data_collator' is not defined (applications/Chat/examples/train_sft.py line 114)

Fix: log when is_rank_0 (applications/Chat/coati/trainer/sft.py)

💥 Checklist before requesting a review

[ ] I have linked my PR to an issue (instruction)
[ ] My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
[x] I have performed a self-review of my code
[ ] I have added thorough tests.
[ ] I have added docstrings for all the functions/methods I implemented

⭐ Do you enjoy contributing to Colossal-AI?

[x] 🌝 Yes, I do.
[ ] 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@NicholasCao good work, thanks a lot for your contribution

Hello, I trained a model yesterday without those changes. What are the consequences of these?
Is the tokenizer wrong in the old code? Where the self.input_ids wrong?

@allaccs If your args.dataset == 'yizhongw/self_instruct', there are no errors.
Otherwise, make sure the tokenizer you use satisfies  tokenizer.eos_token == <|endoftext|>.
The rest are some efficiency or redundancy issues that do not cause any errors.

@allaccs如果您的args.dataset != 'yizhongw/self_instruct'，则没有错误。 否则，请确保您使用的分词器满足 tokenizer.eos_token == '<|endoftext|>'. 剩下的就是一些不会导致任何错误的效率或者冗余问题。

acctually, 'yizhongw/self_instruct' is a community contirbutred, and we put it here tempory, and we will remove it to community exampple


Compile applications locally

It shouldn't be horribly difficult to run the build process locally as part of a GitHub Action/CircleCI (CI provider X) build.
Heroku has docker build images available to use on dockerhub

heroku/heroku:20-build / heroku/heroku:18-build

The Buildpack API is fairly well documented (there are some specifics around caching that would probably need to be clarified/investigated, think the cache is per app, not per-buildpack)
However the high-level would be:

Fetch all the environment variables for an application
Dump them into a folder, filename is the variable name, contents are the contents
Overwrite some build specific env vars that Heroku provides (like the git SHA and stuff)
Clone all the buildpacks
Clone the source code (or fetch it somehow else)
Mount source + buildpacks into the docker image
Run the buildpacks in order (bin/detect, bin/compile, bin/release)
Need to support export scripts as well being created by buildpacks.

Think this means exec'ing the export script after a buildpack is done to make stuff available available for other buildpacks down the chain.

Tar up the result (?)
That's it?

This would mean fully detaching the build process from Heroku's infrastructure itself (apart from fetching the list of buildpacks, config vars, application features, and stack) which might be nice and remove the need for a "ghost"/"compile" application being managed and synchronised.

Another thing to support is pinning buildpacks (https://github.com/owner/repo#ref)
For official buildpacks it doesn't look like Heroku exposes a programmatically (or non-programmatically) available list of versions their buildpacks are running in prod 🤔
Might need to keep a list of shorthand's -> versions somewhere so they can be pulled in, unless there's some internal API/bucket that they upload to


failed to edit cheatsheet: fork/exec /usr/bin/editor: permission denied

A description of the problem
I am using Ubuntu 22.04 and just installed cheat via snap.  Upon trying to edit a cheatsheet, I get the following error:
foo@asdf:~$ cheat -e yt-dlp
failed to edit cheatsheet: fork/exec /usr/bin/editor: permission denied

I am semi-sure this is caused by snap restricting the rights of the packages it installs.  I do not have the error above when using the downloaded binaries
cheat version info
foo@asdf:~$ cheat -v
4.4.0

Hi @YueRen
your assumption is correct. What editor are you using?
The snap supports vim and nano.

@bernermic The error seems to be editor-independent
I remember trying to change editor: /usr/bin/editor to editor: emacs in .config/cheat/conf.yml to no avail.


Exposed toplevel status as a property for spatial and canvasitem

Addresses #10453

Since it was last updated in February, I'd recommend rebasing this pull request. Or, if unavailable, mentioning in the related Issue that someone else should handle the PR.

We actually discussed this in a live Q&A today, exposing this as a property makes sense. It needs a rebase before it can be merged.
Might be worth mentioning in the docs how child nodes of a "toplevel" node behave if they are not toplevel themselves (see #24154).

uhhh - oops. This is why you don't work on stuff so late in the night I guess. Really don't feel like fixing this PR.
Closing and just created a new one - #42448


5/26/22 Unable to find game files

Current patch released Tuesday 5/25/22 for MCD causes unable to decrypt pak files with this editor. Keep up the good work.

i heard it's up for his patrons, but i don't know the time between early patron release and public release

So where it's his patreon? xD

I'm new to GitHub not sure how to Patron someone, but I'd be willing to throw him a few bones to access it now

Essentially i'm just waiting for the update build to go public

Latest version has been released.


Double check the regex in the generator

See the comment here: https://github.com/rough-stuff/rough/pull/174

https://glitch.com/edit/#!/plausible-slime-roof
it doesn't cause any bugs by the looks of it but does mean we can do this, not that anyone would ever want to 👀  (see that the regex isn't a regex so if you put it in the path, it'll get replace in its entirety)
i guess the original intent was just to trim whitespace so M     10 10 becomes M 10 10.
suggest you change it to replace(/\s+/g, ' ')


Add EDDTableFromParquet reader?

This needs more investigation. If already available integrations (jdbc) can read we should document that. Otherwise it may be worth a new dataset type to support parquet.
Discussed in https://github.com/ERDDAP/erddap/discussions/194

Originally posted by MathewBiddle August 30, 2024
I'm continually seeing more and more groups using the Parquet Data File format (https://parquet.apache.org/docs/). Looking through the docs, I see there is an apache/parquet-java package (https://github.com/apache/parquet-java) which could lend itself to the java backend of ERDDAP. I'm curious if others have explored Parquet more in depth and if there is a need for ERDDAP to have the capacity to read from that format.
I haven't seen any discussion on the topic yet.
https://github.com/search?q=org%3AERDDAP parquet&type=code
https://groups.google.com/g/erddap/search?q=parquet

🥳


CARLA with CarSim Plugin

I am trying to put CarSim unreal plugin into CARLA. But there are some questions.

CarSim work as CarSimPawn class in unreal engine. But CARLA use carla.carlawheeledvehicle class in unreal engine. I think there are two way to approach this:
a. Try to make a CarSimVehicleFactory, put CarSimPawn into it and spawn it from python client.
The difficulty is I don't know how to build a custom blueprint factory. Is there any tutorials about that?
b. Try to make CarSimPawn inherit from carlawheeledvehicle.
I have no idea about how to do this. CarSimPawn has it's own movement component, cannot be replaced easily from carlawheeledvehicle.

Please give me some ideas about how to solve this problem.

@jackycstw we are currently trying to integrate CarSim with CARLA. We don't have good answers to your questions yet (we are not using the UE4 plugin). Once our integration is further developed we will happily provide more details.

@germanros1987
Thanks for your help.
Actually, I solved this problem myself last week. The key point is make CarSim's pawn inherit from Carla's class.

Would you care to share more details with us?

@germanros1987  I have projects on this issue so I can't share it in this moment. I think I can share it after the project finished.

Any update on this. I am curious to know how @jackycstw has do the integration of carla and carsim both


Documentation Step 1 "TODO"

Step 1 to actually download the application is not completed. Users must navigate to releases on github to download the app but this is not obvious.

Fixed in branch bugfix/documentation_issues


Bug Fixes for AWS Multi-Master & Multi-AZ

This change fixes #193

ETCD clustering.
Improve Multi-AZ az selection for multi master and nodes.
simplify the AZ assignment process.

EXAMPLES:
To launch a multi-master kube:
specify "kube_master_count": 5, to tell supergiant how many masters need to be used.
To launch multi-master + multi-az:
specify "kube_master_count": 5, to tell supergiant how many masters need to be used.
specify "multi_az": true, to tell supergiant to install supergiant across all available az. (Will work with single master as well.)
For specific control over az deployment.
specify "kube_master_count": 5, to tell supergiant how many masters need to be used.
specify an array of az for which supergiant is to install.
Use the public_subnet_ip_range option. (if this option is not set, supergiant will default to either single az, or full multi az.)
            "public_subnet_ip_range": [
            {
                "ip_range": "<IP_ADDRESS>/24",
                "subnet_id": "",
                "zone": "us-east-1b"
            },
            {
                "ip_range": "<IP_ADDRESS>/24",
                "subnet_id": "",
                "zone": "us-east-1c"
            }
        ]

Amazing work! Works like a charm here!
The only error I got has to do with the bucket name which can't contain uppercase characters in Ireland. I will make a separate issue for this.

Nice! Instructions are great, as a part of the PR.
@gopherstein, I saw your note about adding to docs. Sounds perfect.


Feature request: Open Source for Recent Permission Errors from CloudTrail

As discussed previously, the "Recent permission errors" add on is not part of the open source yet. Would be very helpful to have that included.

This is now supported via Event Bus, but documentation is needed.
TLDR: funnel all of your cloudtrail events to a single account using Event Bus rules. On a given account, set up a rule to send AccessDenied messages to an SNS topic. Create an SQS queue and a subscription to the SNS topic, then give ConsoleMe permission to that queue, and configure ConsoleMe to use that queue to determine cloudtrial denies.


The picture is not fully visible in dark theme

The picture is not fully visible in dark theme

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1bc48620-03dc-7d0e-5e30-2e70fd114028
Version Independent ID: 6142280a-a27b-aaf6-43ef-b91f7ae44084
Content: What is Continuous Integration? - Azure DevOps
Content Source: https://mseng.visualstudio.com/DefaultCollection/TechnicalContent/_git/devops-learn-pr?path=%2fdocs%2fwhat-is-continuous-integration.md&version=GBlive&_a=contents
Service: unspecified
GitHub Login: @samgu
Microsoft Alias: samgu

@slavizh I'm going to close all of these except for https://github.com/MicrosoftDocs/vsts-docs/issues/716 which I'll keep open until we have a fix. Thanks for reporting these.

This is fixed and should be live in a day or two, thank you.


APIV1Ping return 'nil' change to []byte 'Pong'

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[v ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Code cleanup/refactoring
[ ] Documentation update
[ ] This change requires a documentation update
[ ] CI system update
[ ] Test Coverage update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Below is just an example and you can delete it when you contribute.
Example
1. Describe the reproduction procedures freely.
2. Or list up the test description like:
  - [v] Execution of Container
  - [ ] Execution on top of Native
  - [ ] Execution on top of Android

Test Configuration:

OS type & version: Ubuntu 20.04
Hardware: x86-64 (e.g., x86, x86-64, arm, arm64)
Toolchain: Docker v20.10 & Go v1.16
Edge Orchestration Release: v1.1.x

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

코드 잘 작성해주셨네요. Description을 간략하게라도 작성해주시면 좋을 듯 해요! lfedge에 PR 올려주세요!


Add reference docs for mc du

Summary
We should add reference for the mc du command. We often reference it for support cases where users want to know the immediate real data usage and distribution of a bucket or prefix, vs waiting for the Scanner to walk those paths.
Goals

[ ] Add the mc du reference page to docs
[ ] Update the mc reference index page to include mc du

Non-Goals
Anything else on usage outside of a reference context

Lost the final commit due to network outage. It's in https://github.com/minio/docs/pull/789 instead.


Support hikari data-source-properties in ContainerDatabaseDriver

I tried to use test containers with hikari data-source-properties in Spring Boot like this:
spring:
  datasource:
    driver-class-name: org.testcontainers.jdbc.ContainerDatabaseDriver
    url: jdbc:tc:mysql:5.7.22://testcontainers/hi_perf_java_pers #?rewriteBatchedStatements=true&profileSQL=true&logger=com.mysql.cj.log.Slf4JLogger
    hikari:
      data-source-properties:
        rewriteBatchedStatements: true
        profileSQL: true
        logger: com.mysql.cj.log.Slf4JLogger

But datasource properties are ignored by connect method inside ContainerDatabaseDriver (info parameter in method connect).
Workaround so far is to include properties directly into connection string (commented part in url #?rewriteBatched...).
MySQL driver is doing it in this way:
/**
     * Builds a connection URL cache map key based on the connection string itself plus the string representation of the given connection properties.
     *
     * @param connString
     *            the connection string
     * @param info
     *            the connection arguments map
     * @return a connection string cache map key
     */
    private static String buildConnectionStringCacheKey(String connString, Properties info) {
        StringBuilder sbKey = new StringBuilder(connString);
        sbKey.append("\u00A7"); // Section sign.
        sbKey.append(
                info == null ? null : info.stringPropertyNames().stream().map(k -> k + "=" + info.getProperty(k)).collect(Collectors.joining(", ", "{", "}")));
        return sbKey.toString();
    }

You are right, I changed the phrasing of the title to make this more into a feature request.
Would this a Hikari specific feature?

AFAIK this is JDBC feature.

I don't think there is a way to set generic properties on a JDBC connection, could you point me to the documentation?
Also this is a Spring-Boot-Hikari specific thing IMO, so maybe we should check in the Spring-Boot code what happens with the Hikari object etc.

smth like this?
Properties props = new Properties();
props.setProperty("user", "dbuser");
props.setProperty("password", "dbpassword");
props.setProperty(OracleConnection.CONNECTION_PROPERTY_THIN_NET_CONNECT_TIMEOUT, "2000");
Connection con = DriverManager.getConnection("", props);

Oh you are right, great.
We should be able to use this somehow:
https://docs.oracle.com/javase/8/docs/api/java/sql/DriverManager.html#getConnection-java.lang.String-java.util.Properties-

Hi,
I would like to contribute and fix this issue. But I'm not sure on the fix.
Can we agree that the modification here is to actually use info param from this method:
https://github.com/testcontainers/testcontainers-java/blob/0044218c722c174d1968c5a5e933edb5efb5ceca/modules/jdbc/src/main/java/org/testcontainers/jdbc/ContainerDatabaseDriver.java#L64
into that call :
https://github.com/testcontainers/testcontainers-java/blob/0044218c722c174d1968c5a5e933edb5efb5ceca/modules/jdbc/src/main/java/org/testcontainers/jdbc/ContainerDatabaseDriver.java#L124
which means updating this method signature (or adding a new one) to accept Properties info and merge username and password to it:
https://github.com/testcontainers/testcontainers-java/blob/0044218c722c174d1968c5a5e933edb5efb5ceca/modules/jdbc/src/main/java/org/testcontainers/containers/JdbcDatabaseContainer.java#L185-L188
Am I right?
Do you know how could I test this ?

Any progress on this?

Hi @kiview,
We have a similar requirement and based on my understand this would be a simple fix to ContainerDatabaseDriver.java. Here is the summary of the proposed changes:

Reuse MySQL buildConnectionStringCacheKey() method to create the connection URL, based on URL + JDBC properties:

private static String buildConnectionStringCacheKey(String connString, Properties info) {
        StringBuilder sbKey = new StringBuilder(connString);
        sbKey.append("\u00A7"); // Section sign.
        sbKey.append(
                info == null ? null : info.stringPropertyNames().stream().map(k -> k + "=" + info.getProperty(k)).collect(Collectors.joining(", ", "{", "}")));
        return sbKey.toString();
}

Update the following line of code in ContainerDatabaseDriver.connect(String url, final Properties info) to get the updated URL:

// New changes to build connection string based on (URL + connection properties) instead of just using the URL
final String cacheUrl = buildConnectionStringCacheKey(url, info);
ConnectionUrl connectionUrl = ConnectionUrl.newInstance(cacheUrl);

Since JDBC connection will get established based on cacheUrl newly created JDBC object will have all the user provided properties.

Let me know your thoughts and if you are fine with this approach I can work on the changes and send in a PR shortly. Thanks.

Hi,
I'm willing to work on this issue.

Hi, can you give me a chance to crack this?


Feature: Adding contributors section to the README.md file.

There is no Contributors section in readme file .
As we know Contributions are what make the open-source community such an amazing place to learn, inspire, and create.
The Contributors section in a README.md file is important as it acknowledges and gives credit to those who have contributed to a project, fosters community and collaboration, adds transparency and accountability, and helps document the project's history for current and future maintainers. It also serves as a form of recognition, motivating contributors to continue their efforts.

@picklelo  Kindly assign me this issue, I want to work on it. Thank You!

@kalyani2003 that sounds great, assigned you!


AND-6971 merge baymax branch with master

Verified that @nyjalusc has signed the CLA. Thanks for the pull request!

+1


Missing code from docs/single-thread-swank.md

The file single-thread-swank.md contains the following line:

Create a ~/.swank.lisp file (if you dont already have one) and add the following code:

but then no code follows.

Fixed on 5d1b9c08264d0c82bbf01ba0a480cd5fca758137


Add endpoint to list all downstream nodes from a given node

This endpoint will be useful when users want to know what downstream metrics/transforms/dimensions will be affected if a given source or transform node is modified. It can also be used for discoverability purposes, i.e., finding all metrics that use a source node.

Turns out there's actually a better way to do this with a recursive CTE.


release beta

currently contains slate update and ts strict type fix.
both need more testing though and are on beta

:tada: This PR is included in version 4.11.0 :tada:
The release is available on:

v4.11.0
GitHub release

Your semantic-release bot :package::rocket:


cannot create a db table

when i am about to create a new db table ,it always throw an exception like Cannot choose from an empty sequence

Please provide a full code example where you are getting this error.

Closing this issue since there is no response from the original issue creator.


Replace existing image with the newly selected one.

Hi all,
I want to allow users upload one image at a time and also, when user selects/uploads a new image, if there is any previously selected image present, then that should get replaced with the new one. Is there any way to achieve that?
Thanks in advance.

Hi @Gunner17,
Sure you can do that. By the way set maxNumber = 1, when the user uploads the first image, use onImageUpload function, then latter uploading times, use () => onImageUpdate(0) to replace on the first one.
Hope it is helpful for you!

You can try with the image uploaded latest with this snippet: imageList[imageList.length - 1]?.data_url


audit upgrade; direct rule selection; add tests

If @niallo concurs, I would be okay with moving to MIT license to be in line with the strider packages.

How are you using this lib?

Glad to merge this, is it a breaking change?


15 Hz Limit

I am on a K7 5820K with a GTX980
However i seem to get a rather slow update of 15 Hz
Output from kinect2_bridge seems to be fine
[OpenCLDepthPacketProcessor] avg. time: 2.58556ms -> ~386.764Hz
[OpenCLDepthPacketProcessor] avg. time: 2.60462ms -> ~383.933Hz
[TurboJpegRgbPacketProcessor] avg. time: 22.4375ms -> ~44.5682Hz
[OpenCLDepthPacketProcessor] avg. time: 2.59951ms -> ~384.688Hz
[OpenCLDepthPacketProcessor] avg. time: 2.61145ms -> ~382.929Hz
[TurboJpegRgbPacketProcessor] avg. time: 22.5549ms -> ~44.3363Hz
[OpenCLDepthPacketProcessor] avg. time: 2.61456ms -> ~382.473Hz

But when subscribing to topics i get.
➜  workspace git:(master) ✗ rostopic hz /kinect2_head/depth/image
subscribed to [/kinect2_head/depth/image]
average rate: 15.000
        min: 0.057s max: 0.076s std dev: 0.00460s window: 75
average rate: 15.012
        min: 0.056s max: 0.076s std dev: 0.00473s window: 90
average rate: 14.993
        min: 0.056s max: 0.076s std dev: 0.00459s window: 105
average rate: 15.002
        min: 0.056s max: 0.076s std dev: 0.00460s window: 120
average rate: 15.005
        min: 0.056s max: 0.076s std dev: 0.00469s window: 135
Caverage rate: 14.999
        min: 0.056s max: 0.076s std dev: 0.00477s window: 147

Any ideas ?

This also seems to be the case on my Mac Book pro and a secondary computer (15 FPS). Seems like i am missing something obvious.

Just to be sure, you are running rostopic hz on the same machine, right?
I experienced the same behavior randomly, but it is not reproducible. Sometimes it sticks to 15 hz and then it is again 30. I don't know where the problem comes from, but I guess it's libusb, which is just receiving 15 fps. Could you check how many fps kinect2_bridge receives? I just added fps infos to the output in commit 4ef189d2d655bf8308516121cf2792f8c26cb8dc.
If kinect2_bridge just receives 15 fps, then you should open an issue on libfreenect2.

Yes all the test are run locally.
That is funny i am only able to repouce it on my macbook now. Stationary computer is back at 30 Hz. Only difference being my computer had been set to sleep in between. Yesterday restarting diddent fix it.
Output from my Macbook Pro
[DepthPacketStreamParser::handleNewData] not all subsequences received 0
[DepthPacketStreamParser::handleNewData] not all subsequences received 1022
[DepthRegistrationOpenCL::listDevice]  devices:
  0: GeForce GT 750M (GPU)[NVIDIA Corporation]
[DepthRegistrationOpenCL::init]  selected device: GeForce GT 750M (GPU)[NVIDIA Corporation]
[DepthRegistrationOpenCL::listDevice]  devices:
  0: GeForce GT 750M (GPU)[NVIDIA Corporation]
[DepthRegistrationOpenCL::init]  selected device: GeForce GT 750M (GPU)[NVIDIA Corporation]
[DepthPacketStreamParser::handleNewData] image data too short!
[DepthPacketStreamParser::handleNewData] not all subsequences received 1011
[DepthPacketStreamParser::handleNewData] image data too short!
[DepthPacketStreamParser::handleNewData] not all subsequences received 999
[DepthPacketStreamParser::handleNewData] not all subsequences received 831
set process thread priority to: 19
set process thread priority to: 19
set process thread priority to: 19
set process thread priority to: 19
set process thread priority to: 19
set process thread priority to: 19
starting main loop
set process thread priority to: 19
set process thread priority to: 19
[kinect2_bridge] avg. time: 0.0719461 -> ~13.8993 Hz
[OpenCLDepthPacketProcessor] avg. time: 7.83431ms -> ~127.644Hz
[kinect2_bridge] avg. time: 0.0667598 -> ~14.9791 Hz
[OpenCLDepthPacketProcessor] avg. time: 6.92005ms -> ~144.508Hz
[TurboJpegRgbPacketProcessor] avg. time: 21.7866ms -> ~45.8997Hz
[kinect2_bridge] avg. time: 0.066664 -> ~15.0006 Hz
[OpenCLDepthPacketProcessor] avg. time: 6.91995ms -> ~144.51Hz
[kinect2_bridge] avg. time: 0.0665985 -> ~15.0153 Hz
[OpenCLDepthPacketProcessor] avg. time: 7.04432ms -> ~141.958Hz
[TurboJpegRgbPacketProcessor] avg. time: 23.1661ms -> ~43.1666Hz
[kinect2_bridge] avg. time: 0.0667096 -> ~14.9903 Hz
[DepthPacketStreamParser::handleNewData] image data too short!
[DepthPacketStreamParser::handleNewData] not all subsequences received 1019
[OpenCLDepthPacketProcessor] avg. time: 6.96358ms -> ~143.604Hz
[kinect2_bridge] avg. time: 0.0666067 -> ~15.0135 Hz
[DepthPacketStreamParser::handleNewData] image data too short!
[DepthPacketStreamParser::handleNewData] image data too short!
[DepthPacketStreamParser::handleNewData] not all subsequences received 1020
[OpenCLDepthPacketProcessor] avg. time: 7.0089ms -> ~142.676Hz
[DepthPacketStreamParser::handleNewData] image data too short!
[DepthPacketStreamParser::handleNewData] not all subsequences received 1015
[TurboJpegRgbPacketProcessor] avg. time: 23.7497ms -> ~42.1058Hz
[kinect2_bridge] avg. time: 0.0665758 -> ~15.0205 Hz
[OpenCLDepthPacketProcessor] avg. time: 6.85674ms -> ~145.842Hz
[kinect2_bridge] avg. time: 0.0667502 -> ~14.9812 Hz
[OpenCLDepthPacketProcessor] avg. time: 6.98812ms -> ~143.1Hz
[TurboJpegRgbPacketProcessor] avg. time: 23.6253ms -> ~42.3274Hz
[kinect2_bridge] avg. time: 0.0666197 -> ~15.0106 Hz
[OpenCLDepthPacketProcessor] avg. time: 7.04442ms -> ~141.956Hz
[kinect2_bridge] avg. time: 0.0668577 -> ~14.9571 Hz
[OpenCLDepthPacketProcessor] avg. time: 6.84096ms -> ~146.178Hz
[kinect2_bridge] avg. time: 0.0664569 -> ~15.0474 Hz
[TurboJpegRgbPacketProcessor] avg. time: 21.6179ms -> ~46.258Hz

You may want to open an issue on libfreenect2.

Sure should it be on the official one or on your branch?

On the official.

I think with the last commit de5360f5f31aba4601c62a0f5f84342c03c2cf14 to the devel branch this issue is fixed.

Yes .. it is running here. Closing issue now.


[3.6.3] tsc --watch extremely slow (regular tsc compiles fine).

For my codebase, compilation with --watch is extremely slow and sometimes results in the out-of-memory segfault. Compilation w/o --watch take 4s.
Can be reproduced in this repo: https://github.com/bryntum/chronograph/ (publicly available, branch quark_master, revision c58bc18120021423c730c9c2287058066157b8fa).
I found a similar issue, #34119 and tried few recommendations from it. Notably, tried to enable
        "declaration"               : true,
        "emitDeclarationOnly"       : true,

which produced 251 compilation errors. W/o those options all compiles fine.
It seems the incremental compilation uses some different data structures, than normal compilation. Or, may be, the serialization format is incorrect.

This probably explains the fact, that my IDE (PhpStorm) very often goes into "broken" state, with false errors.  See the screenshot - the npx tsc produces no errors, however, IDE thinks there's plenty of errors. I believe this is because IDE uses incremental compilation, which, as we saw, behaves differently from normal compilation.

This is a major usability hit - I basically had to revert to plain command line compilation, instead of using IDE facilities, which would bring me immediately to the source line with error.
I believe this issue should receive priority as having an incremental compilation that produces different results from normal compilation beats the purpose of the former. Basically the whole feature is broken and all recent claims in the TS changelog, about supporting faster builds are not correct.

I also tried the following:

upgraded to 3.7.2
cleaned up all compilation errors, by using the interface mixin form in many places (see #32770, #31426, #29872 if you are curious)
According to #32770 there are some "valid" circularity errors, which are not handled properly in 3.6.x, so those should be cleaned up by this change
project compiled fine in 4.8s
enabled declarations again

        "declaration"               : true,
        "emitDeclarationOnly"       : true,

and get 251 errors, most of them like:

src/replica/Replica.ts:54:37 - error TS4020: 'extends' clause of exported class 'MinimalReplica' has or is using private name 'UnsafeProposedOrPreviousValueOfSymbol'.

54 export class MinimalReplica extends Replica(MinimalChronoGraph) {}
                                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/replica/Replica.ts:54:37 - error TS4020: 'extends' clause of exported class 'MinimalReplica' has or is using private name 'WriteSeveralSymbol'.

54 export class MinimalReplica extends Replica(MinimalChronoGraph) {}

conclusion: incremental compilation only works partially

@sheetalkamat Do you know if it's possible to do the --watch build without declaration emit and serialization? Even theoretically, if it can be implemented in TypeScript. It's notoriously slow to do the emit phase. In my 600k LOC project just running tsc without emit takes ~15-30 seconds. Running it with --watch takes 20-60 minutes, 99% of that time is taken by transformTime/printTime/Emit time. Incremental builds don't help this. Editing a file can result in a recompilation to take another 20 minutes depending on which file is edited.
I don't think it's intended for the --watch --noEmit incremental builds to be slower than just running tsc with --noEmit.
Would be great if Typescript could move away from emitting serialized declarations for the dependency graph and rely on something else instead. Could it be possible to rely on webpack somehow? I'm not sure. I just need an input from someone who knows the insides of Typescript.

@grumd we use d.ts emit to determine if the shape of the file has changed to figure out if we need to emit and re-query semantic diagnostics only the changed file or its dependency graph. While this cannot be change, created #41219 which could help where you pass a new flag to say dont generate .d.ts file to determine change in shape of the file and assume that all changes affect the whole dependency tree rather than being local change.
This might help you because the perf is not going to be worse than running tsc again but could be faster depending on file you are changing which could result in smaller subset of files to refresh. Obviously incremental local change to file is going be  slower than without this flag in watch/incremental mode.

@sheetalkamat How does ts-server work in this regard? Recompilation in ts-server seems to be very fast in my project (when running typechecking in VSCode), but "tsc --watch" is very slow, and "tsc" is okay-ish, but slower than VSCode TS recompilation. I guess ts-server somehow recompiles fast without emitting d.ts?

We've done a lot of changes in the watch space since this was last looked at. Please open a new issue with concrete repo steps if you're still hitting this. Thanks!


Remove batching on unittest thread, use historical data to inform batching

This should help guarantee that the unittest thread is not unintentionally on the critical path of completion time - in my case, this improved test duration by 8 seconds - 126 seconds down to 118 seconds. This may help with perf issues you were seeing, @andy-ms ?

@andy-ms I've also now added a feature where the data for the runtime of prior test runs is used to inform the packing of batches for future sort runs. I have not witnessed more than a second of difference in the end times of worker threads; so at this point, any remaining differences in completion time would have to be harness overhead (or additional runtime caused by the addition of more tests).

Merge conflict 🔼

@andy-ms rebased and resolved.

This doesn't seem to have changed the time for me. I measured 2min 45s, compared to 2min 48s in #18462 and 2min 24s before any of this. @weswigham Could you run a comparison between c522f37 and d1c4754 on your machine?


Added an argo rollouts page to gitops

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description

Please describe your changes: __________________________________
Jira/GitHub Issue numbers (if any): https://harness.atlassian.net/browse/CDS-99204
Preview links/images (Internal contributors only): __________________

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[ ] Successful preview build.
[ ] Code owner review.
[ ] No merge conflicts.
[ ] Release notes/new features docs: Feature/version released to at least one prod environment.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6698357cf1f07d44c871e3c4--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://669841d5a5669c4faf12ea41--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66984681ca8d4c54294d89d0--harness-developer.netlify.app


Chart display bug (edge effect)

From backlog item:354
Scrumwise Status:To do
If you reduce the number of zero crossing down to low number less than  five you will observe that default curve on the Operator (time domain) chart appears to become unbalance around zero.  The number of points displayed left of the centre point appears less than the number of points right of the centre point giving the illusion that you have unbalance time operator.  However if you fix the low left and right values via Display Options dialog you will observe that the first point is just not being displayed on the chart automatically.
This relates to task #2551

Minor code changes have been made.
Tested by importing from a survey with inline/xline step of 2.
Horizons had steps of 2_2, 2_4, 2_6 and 4_6.
NOTE: On re-export of horizons from petrel to opendtect, extra 'null' values are inserted as petrel uses the same 'survey' lattice for all horizons rather than a separate lattice for each.


Unsupported bilibili url for iframe.html: www.bilibili.com/video/av56077628

Bilibili has at least two types of id, they are prefixed with av and bv:

bilibili.com/video/av56077628
bilibili.com/video/BV1az411q79A

Currently, we are using the bvid in our iframe.html:
https://github.com/wechaty/wechaty.js.org/blob/a27cda4cc90d013f21b99ce279330abcec0ee42e/jekyll/_includes/iframe.html#L24
In order to support av prefix id, we need to enhance code at here.
@univerone

It seems works:

https://github.com/wechaty/wechaty.js.org/blob/master/jekyll/_posts/2019-06-21-three-step-get-girlfriend.md

## 视频教程

{% include iframe.html src="//www.bilibili.com/video/av56077628" %}

Blog post: https://wechaty.js.org/2019/06/21/three-step-get-girlfriend/


ingress-shim catch-22

Because the Slack channel is closed I post my problem here.
I try to deploy a service with certificates using the ingress-shim, but the way I see it there is a kind of catch-22 situation. I deploy the Ingress for the service with a cluster-issuer annotation. It has a proper TLS section etc (let's say it is for example.com). So DNS points example.com to the IP address of the created load balancer. But for the ACME protocol a different ingress is created which tries to hijack the /.well-known path of the service. This is impossible because that 2nd ingress get's a totally different IP address of course, so the verification will always yield a 404.
So I thought I would try with the in-place edit functionality, but then the ingress is not created because there is no valid certificate yet.
I don't see how the ingress-shim can work for an initial deploy, or am I overlooking something?

So I finally found this: https://github.com/jetstack/cert-manager/pull/1392
Can anyone shine a light on when 0.7 will be released?

v0.7 will be released later today 😄
You can try out the beta release for now: https://hub.helm.sh/charts/jetstack/cert-manager


Adjust minimum confirmations for CCTS transactions

Just keep in mind that any confirmation reduction beneath the MaxReorgLength of the source chain runs the risk of creating "free money" on the target chain if the source chain is rewound after the spend to the target chain.

@quantumagi yes that is true but this will require a reorg of 50+ blocks on the source chain which we have never encountered.
@StratisIain can chime in here as he proposed these values.

It does introduce constraints on faster block times in the future, as that would go together with bigger reorgs. At that time we should remember to increase these values. Do we need an activation height for these changes?

The activation height will have to be compared against the height of the deposit transaction. Also it would require a 2 x BIP9, one for Cirrus and one for Strax - assuming the confirmations of both are being changed. The BIP9s may kick in at different heights.
I would suggest only changing it for Strax => Cirrus as the block production time is the longest for it.
Maybe we can get @zeptin's opinion as well - he's usually pretty good with this kind of thing. My own viewpoint is that this is definitely a consensus thing as it should affect the validity of transactions being produced - e.g. there is a sense in which a CCTS can be found in a block "too early" due to the deposit not having "cleared" yet, right? Even if there is no such explicit check it would be difficult to untangle how this may implicitly be enforced, so best to assume such a rule exists (or could exist)- even if
not now.
I am using BIP9/Activation height interchangeably. It can be either.

Hi @quantumagi I'm busy doing the activation height work now 👍

Replaced by #974


Mixins watchers not triggered when watching same property

Version
3.1.1
Reproduction link
https://codesandbox.io/s/friendly-burnell-n27xm?file=/src/components/HelloWorld.vue
SFC Playground Clicking the button should display 3 times the change like in 3.0.11
Steps to reproduce

Component and mixins to watch the same property (in this case, vue router $route)
Click each of the router link to trigger the watchers

What is expected?
In 3.0.11, component and all its mixin watchers triggered

What is actually happening?
In 3.1.1, only the component watcher got triggered

I added an SFC playground without the router. It seems like the mixins watchers are being overridden instead of merged together so only the Component watcher is kept

https://github.com/vuejs/vue-next/commit/e2ca67b59a4de57a9bce8d3394263ba493a35a39#diff-07826ed1d9f7699d925ee15d9212e2879af5320b155c0c878fc2dcba71b3e564L110-L113
This seems to be intentional.

e2ca67b#diff-07826ed1d9f7699d925ee15d9212e2879af5320b155c0c878fc2dcba71b3e564L110-L113
This seems to be intentional.

Yes, I saw these comment too. But I still think maybe we need triggered all watch in mixins. So I open a PR to fix it.
Maybe we can discuss this behavior, and if we really don't need this feature, I will close that PR.

IIRC we haven’t planned this breaking change for watchers in mixins for Vue 3. Maybe we should keep the old behavior?

e2ca67b#diff-07826ed1d9f7699d925ee15d9212e2879af5320b155c0c878fc2dcba71b3e564L110-L113
This seems to be intentional.

I also agree this breaking change is not intentional, the code commit specifically to align Vue 2 merge behaviors but fall short on the watch merging on same property.
From the SFC playground created by @posva, it works until Vue 3.1.0-beta7
It also works on Vue 2.x which I recreate the minimal reproduction below:
https://codesandbox.io/s/competent-bardeen-sidl3?file=/src/App.vue


Use pyspinel package

This PR partially solves #961.

Codecov Report

Merging #1678 into master will increase coverage by 0.72%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1678      +/-   ##
==========================================
+ Coverage   66.18%   66.91%   +0.72%
==========================================
  Files         170      171       +1
  Lines       21248    20925     -323
  Branches     2609     2559      -50
==========================================
- Hits        14064    14001      -63
+ Misses       6272     6051     -221
+ Partials      912      873      -39

Impacted Files
Coverage Δ

src/core/net/ip6.hpp
66.66% <0%> (-22.23%)
:arrow_down:

src/ncp/ncp_base.cpp
19.98% <0%> (-7.38%)
:arrow_down:

src/core/crypto/aes_ccm.cpp
79% <0%> (-1%)
:arrow_down:

examples/apps/ncp/main.c
100% <0%> (ø)

src/core/thread/network_data_leader_ftd.cpp
69.01% <0%> (+0.23%)
:arrow_up:

src/core/thread/mle.cpp
81.86% <0%> (+0.28%)
:arrow_up:

src/core/thread/mesh_forwarder.cpp
78.35% <0%> (+0.36%)
:arrow_up:

examples/platforms/posix/radio.c
78.42% <0%> (+0.41%)
:arrow_up:

src/core/thread/network_data_leader.cpp
84.95% <0%> (+0.48%)
:arrow_up:

src/core/net/ip6.cpp
54.71% <0%> (+0.7%)
:arrow_up:

... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1eabda6...ac76f4f. Read the comment docs.

@nibanks I think there might be an issue with running certification tests on Windows after merging these changes since pyspinel is expected to be installed. Could you please help me to figure out what needs to be modified (if anything) in the AppVeyor configuration?

@wbober We don't currently run the cert tests on Windows in AppVeyor, so that should be fine for now. I would appreciate it if you update the Wiki instructions here for installing the new package.


Issues with docker-release

docker-release of tdlib.native is missing some files?
i have created a new asp.net8 app with tdlib.native, and created a container
changes to the default dockerfile:
FROM mcr.microsoft.com/dotnet/sdk:8.0 -jammy
and the added dotnet build -r linux-x64
my modifications to the dockerfile do not make a difference to the outcome - i just wanted to mention them
when i try to start the container, i get the message:
System.DllNotFoundException: Unable to load shared library 'tdjson' or one of its dependencies. In order to help diagnose loading problems, consider using a tool like strace. If you're using glibc, consider setting the LD_DEBUG environment variable:
/app/tdjson.so: cannot open shared object file: No such file or directory
/usr/share/dotnet/shared/Microsoft.NETCore.App/8.0.1/tdjson.so: cannot open shared object file: No such file or directory
libssl.so.1.1: cannot open shared object file: No such file or directory
/usr/share/dotnet/shared/Microsoft.NETCore.App/8.0.1/libtdjson.so: cannot open shared object file: No such file or directory
/app/tdjson: cannot open shared object file: No such file or directory
/usr/share/dotnet/shared/Microsoft.NETCore.App/8.0.1/tdjson: cannot open shared object file: No such file or directory
/app/libtdjson: cannot open shared object file: No such file or directory
/usr/share/dotnet/shared/Microsoft.NETCore.App/8.0.1/libtdjson: cannot open shared object file: No such file or directory
   at TdLib.Bindings.LinuxBindings.td_json_client_create()
   at TdLib.Bindings.LinuxBindings.ClientCreate()
   at TdLib.TdJsonClient..ctor(ITdLibBindings bindings)
   at TdLib.TdClient..ctor(ITdLibBindings bindings)
   at TdLib.TdClient..ctor()

within the dockerfile, the are all 12 current files from the current release, what am i missing?
the version 1.8.21 is used:
<PackageReference Include="TDLib" Version="1.8.21" />
<PackageReference Include="tdlib.native" Version="1.8.21" />

Please be more specific and provide the exact steps to reproduce the issue. So far the instructions are unclear.

changes to the default dockerfile:
FROM mcr.microsoft.com/dotnet/sdk:8.0 -jammy

I don't understand what is "the default dockerfile" (did not find any default template, dotnet new dockerfile complains that there's no such template), and the syntax you use doesn't seem to be correct (a space before -jammy, like it is an option to the image? never seen anything like this before).

hi, the space was just so i could mark the changed part as bold, sry
here is my full dockerfile:
FROM mcr.microsoft.com/dotnet/aspnet:8.0-jammy AS base

USER app
WORKDIR /app
EXPOSE 8080

FROM mcr.microsoft.com/dotnet/sdk:8.0-jammy AS build
WORKDIR /src
COPY ["nuget.config", "."]
COPY ["sample-app/sample-app.csproj", "app/"]
RUN dotnet restore "sample-app/sample-app.csproj"
COPY . .
WORKDIR "/src/app"
RUN dotnet build "sample-app.csproj" -c Release -o /app/build

FROM build AS publish
RUN dotnet publish "sample-app.csproj" -c Release -r linux-x64 -o /app/publish /p:UseAppHost=false

FROM base AS final
WORKDIR /app
COPY --from=publish /app/publish .
ENTRYPOINT ["dotnet", "sample-app.dll"]

And the application code?

here is a sample-application
https://github.com/simonmau/tdlib-sample-app

Ok, so it looks like "jammy" means Ubuntu 22.04, while we still build against Ubuntu 20.04.
20.04 has libsslv1.1, while 22.04 has libssl.so.3 or something like that.
I am not sure how to proceed. 20.04 is still supported (and thus I believe we should support it as well), but I would like to create a version compatible with 22.04 as well. But with the recent changes in the RID graph treatment, I have no idea how to do that.

This is a duplicate of #66.

I am not sure how to proceed. 20.04 is still supported (and thus I believe we should support it as well), but I would like to create a version compatible with 22.04 as well.

Perhaps you can link openssl statically (into a shared library), by using the -DOPENSSL_USE_STATIC_LIBS=TRUE option.

To be honest, static linking of an SSL library doesn't sound like a good idea. As an option[^1] — maybe, but by default, I'd prefer the artifacts to depend on whatever is installed on the system.
[^1]: And I'm not too interested in adding even more build flavors for now.


Samsung.easy migration <IP_ADDRESS> 2ae54e14 8ca9 485e 80a9 ec56af246c1a

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-pkgs/pull/115391&drop=dogfoodAlpha

Hello @upintheairsheep,
Please verify the manifest file is compliant with the package manager 1.0 manifest specification, 1.1 manifest specification, 1.2 manifest specification, or 1.4 manifest specification.
Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version.

Note: The path and "PackageIdentifier" are case sensitive.

Be sure to use a tool like VSCode to make sure the manifest YAML syntax is correct. You can also validate your manifest using the winget validate command.
For details on the specific error, see the details link below in the build pipeline.

Template: msftbot/validationError/manifest/content

This may require a folder move.

Manifest: The manifest file path must match PackageIdentifier and PackageVersion properties from manifest. actual 'manifests\s\Saung\EasyMigration\<IP_ADDRESS>', expected 'manifests\s\Saung\EasyMigration\1.0'


TST: sparse.linalg: propack: add test against example provided with PROPACK

Reference issue
gh-9
What does this implement/fix?
Adds a unit test against example problem/data provided with PROPACK
Additional information

Single-precision results don't match the output provided with propack super closely. It's mostly a good SVD (i.e. u@np.diag(s)@vt is close to the original matrix) but there are a few elements of that comparison that don't match as well as we might expect (e.g. worst relative error is 0.00312401)
The data files are large. Can you include them in the zip folder?
I can't easily read the format for the complex examples
This should be all set to parametrize over irl True/False

The data files are large. Can you include them in the zip folder?

That's a good question -- it seems like adding test data as zip files is something that's okay, but given the experience with Boost, maybe we should unzip the PROPACK sources?

Probably. Yeah, maybe like SuperLU.

.gitignore indicates that I should just commit the source and rely on git's built-in compression. Fine. I guess I should just revert.

Good to merge?

I guess. I hate these files showing in the diff though.


WIP: Enable parsing of attributes inside a match block

We allow invalid inner attributes to be parsed, e.g. inner attributes that are
not directly after the opening brace of the match block.
Instead we run validation on MatchArmList to allow better reporting of errors.
This fixes #845 and works towards #759

I think I agree that we should just parse inner and outer attributes in all contexts and make error reporting a job of a validator.
However, I am not sure that we should simultaneously expand the set of places where we allow attributes at all and switch to all attributes parsing.
Let's start with just adding parsing of outer attributes to match arms :)

Changed to using outer_attributes for the match arms. Now we should properly parse inner_attributes at the beginning of a match block and then outer_attributes for each match arm.

Let's remove the validators from the PR to keep it strictly about syntax?

bors r+
thanks!

@vipentti just to be clear, I like the validators thing, and I think we probably should come back to it some time soon! It's just that it is not 100% clear to me if they are indeed a better fit than just handling attributes directly in the parser, and I am not ready to dive into validators design right now :)

Sounds good! Actually thinking about it, it would probably be simpler to handle attributes and errors related to them in the parser at least on some level.


Consider uploading to Stackage

This package is not on Stackage, so projects that build with stack cannot use it as a dependency. Please consider updating stackage/build-constraints.yaml to include this package.

Pull request made to stackage/build-constraints.yaml.

Great, thanks!

Closed with the merge of https://github.com/fpco/stackage/pull/1701


Create locality table

Context

Currently, information about localities is constrained to the agencies table
I ran the numbers on how many distinct rows we have in agencies versus how many distinct county_fips/state_iso/municipality combinations, and came to:

23448 agencies
13656 distinct county_fips, state_iso, municipality combinations

Normalization would help simplify this situation and reduce the amount of redundant data present.

Requirements

Create new locality table
Update agencies logic so that, when an agency has a locality not yet present in the localities table, that locality is added, and the reference updated.
Update variable column permissions logic for agencies to account for the change in column nomenclature.

Tests

Add tests that, when a new locality is added, it properly populates the localities table, and a foreign key to that entry exists in the relevant agencies row

Docs

Ensure that agencies column permission table is properly updated

Open questions

None at this time.

Closed in favor of #450


Error getting config

Got an error message affter run npm start
$ npm start

><EMAIL_ADDRESS>start /home/hf/Documents/nodeshift_starters/nodejs-configmap-redhat
> node .

[winston] Attempt to write logs with no transports {"level":"error","message":"Error getting configThe \"path\" argument must be one of type string, Buffer, or URL. Received type undefined","stack":"TypeError [ERR_INVALID_ARG_TYPE]: The \"path\" argument must be one of type string, Buffer, or URL. Received type undefined\n    at readFile (fs.js:302:10)\n    at internal/util.js:286:30\n    at new Promise (<anonymous>)\n    at readFile (internal/util.js:285:12)\n    at retrieveConfigfMap (/home/hf/Documents/nodeshift_starters/nodejs-configmap-redhat/app.js:90:10)\n    at Timeout._onTimeout (/home/hf/Documents/nodeshift_starters/nodejs-configmap-redhat/app.js:63:3)\n    at listOnTimeout (internal/timers.js:531:17)\n    at processTimers (internal/timers.js:475:7)"}

similar
https://github.com/nodeshift-starters/nodejs-configmap/issues/90#issuecomment-513176631


Mention autocomplete bug fixes

Summary
Fixes bugs in autocomplete
submitted on behalf of @jarredwitt
Ticket Link
PLT-5532
via @jarredwitt

@enahum changes made


Reworked the bayesian optimisation module with scikit-optimise

PR checklist:

[x] Tested by creator locally
[x] Tested by creator on remote App
[ ] Tested by reviewer locally
[x] Tested by reviewer on remote App
[x] Conforms with the agreed upon code pattern

Implements #188
Note: This module requires scikit-optimization installed in the exec env, so in the config file of this module the minRefineryVersion is set to 1.8.1. Due to this reason, it cannot be tested right now. I am creating the PR, but let's not merge it yet :)

@JWittmeyer  and I have tested this on refinery, and seems to work for us. @LeonardPuettmannKern you can also test this, maybe Jens can show you how

@JWittmeyer and I have tested this on refinery, and seems to work for us. @LeonardPuettmannKern you can also test this, maybe Jens can show you how

Sure thing:

Basically copy code from code_snipped.md paste and replace everything necessary by hand (since bricks integrator doesn't have it)
Also here the link to the project I tested it in (dev server)

Tested it out and it works fine. @divyanshu404 we should maybe just also add that it might take a couple of minutes to run this in the readme? Apart from this, it works nicely.

Yep, it's done :)


Added setup.py to make the library pip installable

@elceef Any reason for not merging this? It'd be nice to just be able to run pip install dnstwist.

It's work in progress now.

+1, without this it is very difficult to deploy dnstwist and use it as a python library

It's done. You can run pip install dnstwist now.


[BUG] - DropdownTrigger and PopoverTrigger pass onClick to Button causing console warning

NextUI Version
2.6.8
Describe the bug
Button's onClick is deprecated but DropdownTrigger and maybe PopoverTrigger are passing an onClick prop to their one child, usually a Button. This causes the deprecation warning to be logged even though no direct Button instances are using onClick.
Your Example Website or App
No response
Steps to Reproduce the Bug or Issue

Set up a dropdown with Button as trigger
Observe console

Expected behavior
I expect no warnings.
Screenshots or Videos

Ignore the exact error, that's because the warn assumes process and Vite doesn't surface that. https://github.com/nextui-org/nextui/blob/afe0b527ce2dcd1f511b601fcba700fd2d12fcd6/packages/utilities/shared-utils/src/console.ts#L11
Stack shows error comes from deprecation check here: https://github.com/nextui-org/nextui/blob/afe0b527ce2dcd1f511b601fcba700fd2d12fcd6/packages/hooks/use-aria-button/src/index.ts#L108
Operating System Version
macOS
Browser
Chrome

For "process is not defined" issue, it has been fixed in canary and will be available in the next bug fix release.
To the original issue, another example would be using a polymorphic button. The onClick is passed from the Button component internally. We need to handle this case to avoid confusion (since users don't actually use onClick in their code).


improvements to validator for ieeg data type

I tested the validator against the BIDS-examples and compared it to the draft specification (google doc).
I propose that changes go as pull requests via you into the INCF/bids-validator repository.

I should have mentioned that I have tested it only against ieeg_motorMiller2007, not against ieeg_visual

I have now also tested it against ieeg_visual, all was fine.

thanks for the updates - I've gone into the spec and resolved the points that these fixes resolved.


Support of curve secp256k1

I'd like to bring HPKE to web3 ecosystem. The curve secp256k1 is native on ethereum.
There's some existing js implementation of curve secp256k1 like secp256k1.
I believe that this curve is capable of KEM in HPKE.
I'm asking for your opinion of adding support of secp256k1. Then I can start to work and submit a pr to this repo.

@lightsing thanks for considering using my library.

I believe that this curve is capable of KEM in HPKE.

I agree with you but all of the HPKE KEM algorithms must be standardized in IETF and registered to the HPKE IANA registry because the 2-byte HPKE KEM id space does not have any user-defined space.

I'm asking for your opinion of adding support of secp256k1. Then I can start to work and submit a pr to this repo.

At first, I'd like to know whether you or your team have plan to propose the new HPKE KEM using secp256k1 to IETF (such as DHKEM(secp256k1, HKDF-SHA256)). If you have it, your PR would be welcome. I will also be happy to help.
If you don't have the plan, I'd like to know the reason why you want to use not secp256r1 but secp256k1 in a bit more details. I know secp256k1 is used widely in blockchain domain but it's not for e2e encryption but for signing. I think you can use secp256r1 on the web3 world too.
Anyway, if the reason is clear to me, I think it is feasible for secp256k1 to be standardized in IETF and I can consider accepting your PR.

Thanks for your clarification.

HPKE KEM algorithms must be standardized in IETF and registered to the HPKE IANA registry

I don't know this before. Thanks for the information.
In the previous design draft we choose ECIES. However, after doing more background investigation, we found HPKE is better.
In our design, the public key is retrived by using ec recover of a on chain signature. Cuz the signature needs to be verified by other smart contracts, using different curve like secp256r1 means the contract needs to implement the verify algorithms which would cause increasing in gas cost comparing to calling precompiled contract of ecRecover.
We want to reuse the ethereum cryptography infrastructure. There might be some workaround to use standard HPKE. It would be best solution if HPKE supports secp256k1 natively.

Thanks for explaining the background of your request.
Okay.
If we add the note "experimental" to the secp256k1 KEM, it should be no problem to add it to the library.
So please feel free to send me the PR. I will review it.
In addition, note that this library has been developed for various JS runtimes as many as possible using Deno development tools.
For making a PR, all you have to do is 1) install Deno and 2) make sure all tests pass with the following commands (See hpke-js/deno.json for details):
# tests for deno
deno task test
# tests for node.js
deno task dnt

Tests on the web browsers are executed as the github action triggered by a pull request.
Sorry for the lack of documentation. If you have any questions, please do not hesitate to ask.

May I ask more backgrounds question?

Would the 2-byte HPKE KEM id encoded in the "sealed" message? If not, it's possible to construct a CipherSuite using a KdfInterface implemenation?
Why all dependencies are bundled into bundles? Won't it be hard to manage and get security updates?

Would the 2-byte HPKE KEM id encoded in the "sealed" message?

No. But the kem_id is used both in the KEM process and the KDF process to derive a key.

Why all dependencies are bundled into bundles? Won't it be hard to manage and get security updates?

I've been thinking it's a problem too and I have to remove the bundles as soon as possible. This was the only way to deploy the hpke-js package that runs on node.js, deno, and web browsers. If the stablelib components in the bundles become pure ESM modules, I can remove the bundles.

I purpose a refactor to :

decouple KdfContext to seperated class like HkdfSha256Kdf & HkdfSha384Kdf & HkdfSha512Kdf
decouple KemContext to a free combination of KemPrimitives and KdfInterface
provide a freely way to construct CipherSuite from external implementation of KemContext and KdfInterface

KEM, KDF, and AEAD are not as loosely coupled as you might think; KdfContext contains information on KEM and AEAD for the internal process, and the KDF contained in KEM is determined by the KEM ID.
I will consider your suggestion, but please give me some time. I can at least understand your request to pass KemContext from the outside. I will consider it.

FYI: Remove bundles on #111.

@lightsing I've implemented DHKEM(secp256k1, HKDF-SHA256) experimentally and released it as v0.17.0. Could you try to use it and give me some feedback?

it works as expected, thanks!


"Search in files" multiple times

I like the search-icon in left side. Its fast access.

I wish when a "search in files" is filled up, its possible to add a second (or more) "search in files" without overriding recent search. I must search for a keyword A and get a long list of files to check. Now i detect I need more informations for analysis. So I must search with another keyword B to compare data that found with keyword A before. But thats impossible, because I can only start one "search in files" and not multiple times.
So I would like for a option that search-icon can create a new additional search and select like explorer with title-bar the one I need and add a new one.

https://github.com/Microsoft/vscode/issues/16488

@roblourens
That is not the same request? #16488 want mutliple search patterns for a single search result. SO I understood. I want mutliple independent searches. Each search-formular with a own list of results.

I think you are asking for the same thing - keeping track of multiple independent searches simultaneously.


fix: allow use of the Eloquent Attribute and enum casts

Adds in the ability to use the Attribute casts from Laravel 8.50 up

It looks like the hasAttributeSetMutator() method was introduced in Laravel 8. Jetstream FileMaker currently supports Laravel 7, where this method does not exist.
I think a good solution to keep the compatibility with the older versions and make sure we use new features in newwer versions of Laravel would be to rework this setAttribute method to call parent::setAttribute and then do our custom stuff after that. The only parts that would need to be included in our custom implementation after the parent call would be the bits at the end and the handling of the date in the date casting.
Do you want to rework this to follow this pattern?

Will look at this to rework to that pattern


GL.cs (non-gen) documentation

Summary of the PR
Documentation for the GL.cs (non-gen) class, providing remarks where necessary and direct links to the relevant Khronos documentation for the wrapped method.
Related issues, Discord discussions, or proposals
As far as I know, there's not a way to document the (generated) GL.gen.cs. I'm willing to document all of the members within that generated file, awaiting the relevant functionality for documenting generated .cs files.
Remark: It's possible my code-cleanup has interfered with the Silk.NET code styling conventions, and if so I'm willing to also make the necessary modifications to ensure that code style is maintained.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

For future reference: most big work like this is being done against 2.0. I'll do my best to port this over once merged.

For future reference: most big work like this is being done against 2.0. I'll do my best to port this over once merged.

Sure thing, I'll do any future work in the 2.0 branch.

Thanks for the contribution!


Openpype settings project Kitsu

Changelog Description
Documentation for : OpenPype Settings --> Project --> Kitsu

documentation was moved to it's own repo https://github.com/ynput/ayon-documentation


How i can get an image from TiffIfd

How I can get an image  from TiffIfd and then show it in browser?

see getContext("2d")

Any better answers out there than the above? Surprised there isnt a more straightforward example in the readme. I did see https://github.com/image-js/tiff/issues/45#issuecomment-1569764200 but that requires the image-js library, is that unavoidable?


verifyFetch.ts fails to parse body when a Request Object is used to fetch rather than a URL

Thanks for the fix on 0.0.2, here's another one!
The following test fails due as RequestInit is not used, rather an instance of Request is passed through which results in a body of  "" after setup.
Deno.test('Reproducing Failure to parse JSON in verifyMatch.ts when using a Request Object in fetch.',
  async () => {
    denock({
      method: "GET",
      protocol: "https",
      host: "jsonplaceholder.typicode.com",
      path: "/todos",
      responseBody: { test: "6" },
      replyStatus: 200,
    });

    const url = "https://jsonplaceholder.typicode.com/todos";
    const request = new Request(url, { method: "GET" })
    const response = await fetch(request);

    const body = await response.json();
    const status = response.status;

    assertEquals(body, { test: "6" });
    assertEquals(status, 200);
  },
);

Thanks for having spotted this one. This is fixed in 0.0.4


How do you submit and dismiss a custom dialog?

I cant seem to find a way for this in $mdEditDialog.show(). The .small() and .large() seem to have built-n save, dismiss, and getInput methods in the documentation but i cant seem to find any in .show()

The implementation is completely up to you when you create a custom dialog. You can use the controller for the small and large presets as a starting point.
['$element', '$q', 'save', '$scope', function ($element, $q, save, $scope) {
  function update() {
    if($scope.editDialog.$invalid) {
      return $q.reject();
    }

    if(angular.isFunction(save)) {
      return $q.when(save($scope.editDialog.input));
    }

    return $q.resolve();
  }

  this.dismiss = function () {
    $element.remove();
  };

  this.getInput = function () {
    return $scope.editDialog.input;
  };

  $scope.dismiss = this.dismiss;

  $scope.submit = function () {
    update().then(function () {
      $scope.dismiss();
    });
  };
}]

Hello @daniel-nagy, how can i bind other logic when dialog is dismissed, doesn't matter whether it is called by 'ESC' key or click on another element ?


traffic

Can you set the panel so that it calculates the traffic together and calculates 30 GB for upload and download, not separately?

Hmm, ok i will add that option in next upcoming version.

closing this as fixed (0.1.7 Alpha release)


vtctld2: Topology Browser

@pkulsh @dsslater - Whoever gets to it first, please review.
This is a port of the topo browser to the new Angular 2 vtctld UI.

This change is

Review status: 0 of 16 files reviewed at latest revision, 1 unresolved discussion, some commit checks broke.

web/vtctld2/src/app/topo/topo-browser.component.ts, line 84 [r6] (raw file):

      error => this.node = { Error: error });
  }
}

LGTM

Comments from Reviewable


feat(blob): Move to multi-bucket by default

BREAKING CHANGE: Some methods responses and types have been updated following a
migration Vercel did to make Vercel Blob more robust and closer to the S3 API.
Namely:

the urls generated by Vercel Blob have moved from:
public.blob.vercel-storage.com/zyzoioy8txfs14xe/somefile-NoOVGDVcqSPc7VYCUAGnTzLTG2qEM2.txt
to
zyzoioy8txfs14xe.blob.vercel-storage.com/somefile-NoOVGDVcqSPc7VYCUAGnTzLTG2qEM2.txt.
This change has been done transparently: all previous blob urls are
redirected to the new domain.
.put() no more sends back size and uploadedAt, use .head() to get this
information. Refer to the PutBlobResult type.
.list() no more sends back contentType and contentDisposition on the
blobs property. Refer to the ListBlobResult type.
.del() response is always null, no other metadata is sent. del()
doesn't inform you if the delete was succesful. If the file was here prior to
a del() call, then it's now deleted. Use head() when necessary.
BlobResult type has been splitted to PutBlobResult for put() and
HeadBlobResult for head(). Use them accordingly.

We've also reworked our README to better surface the browser-upload and
serverl-upload methods.

Tests should work once we merge the API PR: we're failing at a CORS issue (x-api-version is not yet allowed)


Favicon split method

I'll preface this with I'm running a Mac, had a bugger of a time setting up the pre-reqs, and have an unusual talent for breaking things in wonderful ways!
I'm getting an undefined method `split' for nil:NilClass error every time I try and put in a link. I can open the Link page fine for the first time, it's when I  hit the save button that it complains.
Here's the error
  src="https://www.google.com/s2/favicons?domain=<%= URI.parse(link.links_url).host.split('.').last(2).join('.') %>"                        alt="favicon"                        class="fa-2x text-light"                       onerror="this.alt=''; this.style.display='none'; this.nextElementSibling.style.display='inline-block';">
I've never used Rails before, but my quick google says this might be a possible solution.

Hey I just saw this. I'll write better docs soon and this is pretty early days. It isn't great if you haven't worked with Rails before for now.

I attempted this (and failed) on a livestream last night haha. I fixed the problem that was causing it and will try again. Here it is (watch in 2x) and if you follow along with the new setup guide/developer guide it should all work.
I think the default credentials are in the docs.


Add the original mouse event as parameter in onMove()

The new signature is now onMove(evt, originalEvent).
This is to allow having access to the mouse position during onMove.

thx.


feat/expose state and key as properties in DMEnvWrapper

add state and key as properties in DMEnvWrapper class https://github.com/instadeepai/jumanji/issues/27

Could we please implement a test in the TestJumanjiEnvironmentToDeepMindEnv class of wrappers_test.py for getting and setting the key and state attributes?

Thank you for your contribution! Looks good to me :rocket:
It seems that you have not installed the pre-commit hooks, and hence the changes will probably not pass the linters (black at least). I can also see that tests are not executed on the pipeline for some reason (probably not your fault). Let me look into this!

Is there anybody working on this? Otherwise, I'll be closing the PR for now.


✨😮Updating all SIG pages for Fall 2024

Description

We have a ton of new SIGs! Let's get them on the website!
Issues

Checklist

[x] I've labeled the PR appropriately.
[x] I've have built the website and verified that my changes work.
[x] I've linked the appropriate issues and related PRs.

i forget that i have write access to this repo sometimes... i applied my suggestions myself :D


[BUG] bug title Use escheduler-1.1.0 to schedule the hive task. Stopping the workflow will lock the table

Use escheduler-1.1.0 to schedule the hive task. Stopping the workflow will lock the table. You need to manually delete the record of the lock table in hive metadata. Is there any way to avoid this problem? Thank you.
使用escheduler-1.1.0版本调度hive任务，停止工作流会锁表

is there some exception info ? or how to reproduce this situation?

By the way, 1.1.0 is not apache version, maybe you can consider update the version

Run the instance on easysscheduler version 1.1.0. The instance is still running. Click Cancel to lock the table without obvious error

Please let me know how to smoothly upgrade easysscheduler scheduling system and switch without affecting existing tasks. Thank you.

you can backup your database first, when there is no job running, you can update.
please refer: https://dolphinscheduler.apache.org/zh-cn/docs/1.2.1/user_doc/upgrade.html
do more test on the test/dev environment before  updating the production


Allow setting incident type via parameter

Incident type should be set via parameter but is optional

Did you allow for replacement variables in the type - so taking it from the alert data?

It is a given for all text fields


'Placeholder' is not assignable to parameter of type 'string | ((match: string, ...args: readonly any[]) => string)' in replace

const greet = R.replace('{name}', R.__, 'Hello, {name}!');
greet('Alice'); //=> 'Hello, Alice!'
This is example in docs

It's a typescript issue. Not all functions are correctly typed to support currying and placeholders. It's been like that since we migrated the community-defined and supported types from @types/ramda over to here
R.replace is one example where it's typed for general currying, but not for use with the placeholder, and that needs to get fixed
@shamshiyevulugbek I'll try and get this looked at later this week


Is this project still alive?

I just found out about this project, got very excited, but then realized there has been very little activity. What is the status?

Yep, there are a number of articles in the works. :)

Oh great! Just to clarify, it is possible to use this framework on your own website even if you don't intend on publishing on distill.pub?
(I just realized you are the person behind http://colah.github.io, I really enjoyed your “Visual Information Theory” post :)  )

Unfortunately we don't currently provide a license for this code but we hope to update that with a future release.


HashMap<_, u32> is Record not Map

Hi, I have something similar to the rust code below. What I'm seeing at runtime compared to the typeshare generated types don't match up. Is this supported? is there an annotation that needs to be used for this? or a bug?
#[derive(Hash, Serialize)]
#[typeshare]
#[serde(tag = "type", content = "index")]
pub enum Foo {
  Bar,
  Bing,
  Bang(u32),
}

#[derive(Serialize)]
#[typeshare]
pub struct FooParent {
  foos: HashMap<Foo, u32>;
}

wasm-bindgen returns
export interface FooParent {
  foos: Map<Foo, number>
};

typeshare returns
export interface FooParent {
  foos: Record<Foo, number>;
}

By using serialized_as = "Map<Foo, u32>")
#[derive(Serialize)]
#[typeshare]
pub struct FooParent {
  #[typeshare(serialized_as = "Map<Foo, u32>")]
  foos: HashMap<Foo, u32>;
}

The types can be generated like
export interface FooParent {
  foos: Map<Foo, number>
};

serialized_as is a good solution to the problem if you need Map. typeshare is primarily written with JSON serialization in mind. A JSON object is defined as Record<K, V> in TypeScript. Map refers to the Map class.

@kjvalencik Thanks for the reply. I was also looking into the option of serializing as an object, by stringifying the complex key type, but I couldn't get that to work as in the serializer it needed the key to have a  static &str life time. Maybe there is a way to do it, but I couldn't work it out...
However the Map type is just as useful to me in the code so I went back to changing typeshare and got it working like the above. I guess I have 2 questions:

Should the Typeshare's result match up with the default behaviour of Bindgen?
How would I generate a Record<K, V> from a HashMap?

Should the Typeshare's result match up with the default behaviour of Bindgen?
The defaults align with JSON instead of wasm-bindgen. The default matches what serde_json + JSON.parse produces.

How would I generate a Record<K, V> from a HashMap?

Configure serde_wasm_bindgen to use .serialize_maps_as_objects(true).

Thanks @kjvalencik I'll give that a try. Happy to close this down!


Apply and enforce checkstyle for code style

We gotta put an end to odd formatting.
Need code formatter templates added to the project for IntelliJ and Eclipse, and a checkstyle config added to assert during the build that we're in compliance, and document in the README how to apply the formatter templates.

Will likely require a mass format to get all code to be in compliance so let's coordinate when that hits the repo with other work being done to avoid messing up PRs and merging.

Very good point, @ALRubinger. I probably brought some confusion with the default Eclipse formatter, so having some common settings and use Checkstyle to keep the code aligned will be much welcomed !

@gastaldi added the .editorconfig stuff, so he can be responsible for enforcing it in the Maven build :)


Multi user project.

Hi
where should i put my identity codes that doesn't ruin architecture?

Still haven't found a concrete solution for that too. These architecture frameworks are interesting but the authors don't understand that real world examples should be provided so that they can be useful for people. Using Identity and isolating it 100% from domain is a headache. Try to check this and this.

Hi where should i put my identity codes that doesn't ruin architecture?

Still haven't found a concrete solution for that too. These architecture frameworks are interesting but the authors don't understand that real world examples should be provided so that they can be useful for people. Using Identity and isolating it 100% from domain is a headache. Try to check this and this.

This is a solution template. If you want to see a reference application that uses similar, check out the eShopOnWeb app here:
https://github.com/dotnet-architecture/eShopOnWeb
Read the associated (free) eBook, too:
https://ardalis.com/architecture-ebook/

That said, it is my intention to extend this template to support identity, since it's a very common requirement. The biggest thing that's prevented me from doing so is that typically there's a big difference between how you should do auth for a forms/views based app (MVC or Razor Pages) and an API app (Controllers or Web API endpoints or Minimal APIs). The former typically uses cookies; the latter tokens. Combining both in one app can be troublesome, so typically I try to split the APIs from the Pages.

This is a solution template. If you want to see a reference application that uses similar, check out the eShopOnWeb app here:
https://github.com/dotnet-architecture/eShopOnWeb
Read the associated (free) eBook, too: https://ardalis.com/architecture-ebook/

I know that application but the integration with Identity does not address real world usages. This architecture needs a full example of how to use Identity fully isolated and working with a custom User entity in Domain layer. Real world web applications that require Authorization and Authentication must store additional user information and also manage that information, manage users and their roles. Extending the Identity tables directly would solve the problem, but I believe that custom user properties should not be tight to .Net Identity and it's tables ensuring future scalability.
This article follows this principle but is not following Clean Architecture so a couple of things might not work.
Jason Taylor's approach seems one of the few that tries to tackle this Identity isolation problem with success, but unfortunately, it does not address custom user information so making all work and isolating Identity was an "easy task" despite the fact that using this code
using CleanArchitecture.Application.Common.Models;

namespace CleanArchitecture.Application.Common.Interfaces;

public interface IIdentityService
{
    Task<string> GetUserNameAsync(string userId);

    Task<bool> IsInRoleAsync(string userId, string role);

    Task<bool> AuthorizeAsync(string userId, string policyName);

    Task<(Result Result, string UserId)> CreateUserAsync(string userName, string password);

    Task<Result> DeleteUserAsync(string userId);
}

brings some issues that I'm not sure it's the right way to go since it cuts out Identity features. I'm talking about that CreateUserAsync that had to use a crippled custom made Result object instead of using the original IdentityResult object that offers an IEnumerable of IdentityError. Since you can't have Identity in Application layer, we have an issue here. Dead end? 😕 Also, that same method can't receive a ApplicationUser parameter and I'm not sure if it that solution is the right way to go. With a custom user, it could be necessary to have a method with many parameters:
Task<(Result Result, string UserId)> CreateUserAsync(string userName, string password, string jobPosition, DateTime birthday, string photo, ...);
In this case, my alternative is to make this method receive a UserProfile object:
Task<(Result result, string UserId)> CreateUserAsync(UserProfile userProfile);
In the implementation I then have:
public async Task<(ApplicationResult result, int userId)> CreateUserAsync(UserProfile userProfile)
        {
            var user = new ApplicationUser
            {
                UserName = userProfile.Username,
                Email = userProfile.Email,
                UserProfile = userProfile,
            };

            var result = await _userManager.CreateAsync(user, userProfile.Password);

UserProfile is inserted automatically by EF into the UserProfile table in database. Is this the right path? Should I override UserStore instead, and keep using the original CreateUserAsync method from UserManager and ditch this IdentityUserService approach?
Jason's approach also does not address the best way to work with Identity and a custom User class (UserProfile) and how and where should we make sure syncing works when creating and deleting a Identity user + it's user profile dependency.
@ardalis please take no offense on my quest. I love the architecture, your valuable contribution to the community 🙌   but I just wish someone would take this matter by the horns 😃 since Microsoft won't likely do it.
I already have a working solution with User Profile (UsersProfile table) linked to Identity Users (AspNetUsers) but I'm stuck in some required decisions on how to proceed. If I send you the project, do you think you could take a look and maybe help me solve this? You are far more experienced than me on these kind of architecture issues.
Once again, sorry for taking it out on you but this is driving me crazy. I really would love to have Clean Architecture implemented the right way.
Thank you!


Multi-Armed Bandit

This PR enables bandit models by bringing the following new features:

a class for modeling binary targets
a multi-armed bandit surrogate
a Thompson sampling acquisition function
a beta prior
and the necessary torch infrastructure, such sampler for torch's beta distribution

@AdrianSosic @julianStreibel is this already ready for review or do the two of you want to do a first round of review first?

Hi @julianStreibel, @AVHopp, @Scienfitz. In principle, this PR is now ready for the broader review (though #338 still needs to be merged first, which I plan to do next).
There a few open things / design choices, which I'll highlight by adding comments to the respective code section in minute. However, there's one larger issue which I decided to delay to a follow-up PR, namely: @julianStreibel created some very cool GIF animations that I'd love to have in our doc. But I'd like to do so without messing up the size of our git repo and introducing additional technical debt (see points below). That's why I removed the corresponding code in one of the latest commits and stripped down the example to a first bare minimum version, to make it ready for PR review and speed up the integration of the new bandit models.
To include the GIFs in a follow-up PR, we can build upon @julianStreibel's code that I've temporarily deleted, but we need to fix:

Right now, the produced GIFs are HUGE. That is, there would roughly 120MB added, which is definitely too much, especially given the fact we'll need to update them from time to time. Either, we can shrink the size somehow, or we need to think about a different approach of hosting these things.
With some of the latest changes to our docs pipeline, files are no longer written to the correct locations. This is something that needs to fixed outside the scope of this PR but definitely caused some friction when @julianStreibel and I exchanged.
The code for creating the GIFs and applying our styles was put on top of code architecture that was not yet ideal (e.g. the handling of fallback styles). If we kept it that way, this PR would add even more technical debt, which I'd like to avoid. First, we should clean up the style handling to accommodate for the necessary changes.
The example currently uses a manual DOE loop. In the current minimal setting, this is sort of acceptable, but when tracking more quantities required for the GIFs, things become really messy and hence suboptimal for an example. I'd like to keep it clean by reusing our simulation capabilities in combination with custom hooks (which additionally makes up a nice hook example) but the overdue refactoring of the simulation package blocks me from doing so.

the target branch for this PR is not main but dev/surrogates, which however is in the process of being completed/merged. Is this intended?

the target branch for this PR is not main but dev/surrogates, which however is in the process of being completed/merged. Is this intended?

No, that was done by @julianStreibel, probably because the two of haven't talked about where this is supposed to go. Have change it now. Once the dev branch is merged, I'll rebase


chore(deps): update dependency org.springframework:spring-tx to 5.1.4.release

This PR contains the following updates:

Package
Change

org.springframework:spring-tx
4.3.21.RELEASE -> 5.1.4.RELEASE

Renovate configuration
:date: Schedule: At any time (no schedule defined).
:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.
:recycle: Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "rebase!".
:no_bell: Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Renovate Ignore Notification
As this PR has been closed unmerged, Renovate will now ignore this update (5.1.4.RELEASE). You will still receive a PR once a newer version is released, so if you wish to permanently ignore this dependency, please add it to the ignoreDeps array of your renovate config.
If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.


How to update when instantiating using npm module?

import rangesliderJs from 'rangeslider-js'

rangesliderJs.create(document.getElementById('slider1'), {min:0, max: 1, value: 0.5, step: 0.1})

Using the above I cannot find any method of accessing the usual method of updating:
$('input[type="range"]').rangeslider('update', true);

Anyone know how this is done?

This can be ignored. I was looking at two different repos with similar names.


Conversion of Set to List for BrokerMetadata Collection

Set is unordered and doesn't allow for duplicates.
List is ordered and allows for duplicates.
Converting Set -> List for O(1) runtime complexity in lieu of O(n) caused by the usage of List.
Set -> List should be safe in this case since the Set contains non-duplicated values.
TopicFactory interface declares the following member functions. Changing this method to return List could break the backward compatibility
Set<Integer> getBlackListedBrokers(String zkUrl);
Signed-off-by: Andrew Choi<EMAIL_ADDRESS>

@sutambe
chose set -> list conversion since TopicFactory interface declares the following member functions. Changing this method to return List could break the backward compatibility..
Set<Integer> getBlackListedBrokers(String zkUrl);


refactor: Move loader-agnostic error types from container-utils to telemetry-utils

This is part of an effort to remove the container-utils package. The objective is to move the error types in that package to telemetry-interfaces. This PR moves all of the loader-agnostic types to their new home.
The moved members are re-exported from telemetry-interfaces to maintain backwards compatibility, but are marked as deprecated. Repo-internal imports have been updated to import from telemetry-interfaces, and now-unneeded dependencies on container-utils have been removed.

Note for reviewers: this PR currently leaves 2 API members remaining in container-utils: DataProcessingError (class) and extractSafePropertiesFromMessage (function). These depend on concepts in the protocol-definitions package, which telemetry-utils cannot see. If we can come to a resolution to this question in this PR, that would be great. But I'm also happy to do that in a separate PR.

Requires #16868 be merged before this PR can be merged.


Convert the doc format to Markdown

closes #2691
closes #2564
it's in process.

Coverage increased (+0.08%) to 87.396% when pulling b0e58e56ba2bea271befffcea61e09870f2d5e01 on awxiaoxian2020:markdown into ee2e2d8e820d329b35af5efae8938040d77cbbfc on mybatis:master.

Hi @awxiaoxian2020 ,
Just to let you know that maven-site-plugin can handle multiple different formats (i.e. XDOC and Markdown) at the same time.
So, for example, if you are working on configuration first, it is OK to have a file structure as follows.
├── ja
│   ├── markdown
│   │   └── configuration.md
│   ├── resources
│   │   └── css
│   │       └── site.css
│   └── xdoc
│       ├── dynamic-sql.xml
│       ├── getting-started.xml
│       ├── index.xml
│       ├── java-api.xml
│       ├── logging.xml
│       ├── sqlmap-xml.xml
│       └── statement-builders.xml

If you want to convert all files in one PR, that is OK, but it'll take us longer to review and increase the chance of conflict with other contributors work.

@harawata It seems that we lost the skin...

@awxiaoxian2020 ,
I don't know much about site generation.
You should take a look at the doc files in the mybatis-spring project.
They were converted to markdown a while ago.
https://github.com/mybatis/spring/tree/master/src/site

@awxiaoxian2020 , I don't know much about site generation. You should take a look at the doc files in the mybatis-spring project. They were converted to markdown a while ago. https://github.com/mybatis/spring/tree/master/src/site

Thanks for your suggestions! I found I didn't download the mybatis-parent on my local machine when I build the site...the skin is defined in the parent site.xml.

@awxiaoxian2020 You may have to include that now with this effort.  The other uses velocity and it inherits it from the parent automatically via maven.

close for clean commit.  this PR is superseded by #2784.


HollowAnnouncementWatcher should implement an interface

Currently, the HollowClient constructor accepts an instance of HollowAnnouncementWatcher.  Because HollowAnnouncementWatcher is an abstract class that unconditionally constructs an internal Executors.newFixedThreadPool instance, this does not scale to deployments where there are hundreds or thousands of HollowClient instances in a single VM.
While it would be ideal if HollowAnnouncementWatcher were merely an interface, like HollowBlobRetriever and other types passed to the HollowClient constructor, that would be a breaking change for existing code.
Maybe introduce a new interface type, have HollowAnnouncementWatcher implement that type, and have the HollowClient accept that type.  That would preserve compatibility for existing clients, while allowing alternative implementations.
EDIT: For context, the use case is multi-tenancy, where each tenant (possibly thousands) has their own data model instances with independent namespaces, snapshots, and delta chains.

+1