SparklinesLines doesn't re-render if 'color' prop changes

I put up a simple demo to reproduce the issue here: http://www.webpackbin.com/N1tuFIpfZ
If I have something like this:
<Sparklines data={this.props.data}>
    <SparklinesLine color={this.props.color} />
</Sparklines>

// where data = [1,2,1,2,1]
//           color = "blue"

and i update this.props.color, but I don't update this.props.data - then SparklinesLine does not re-render and the color doesn't change.
If i change the data and the color, they both update correctly.
I believe this issue is similar to the other few that are open regarding the shouldComponentUpdate function in Sparklines component.

If you go to the demo above and run, the color is changed but the Sparkline doesn't update. If you change the data prop inside the code - you will see that it updates both the data and the color correctly.

If I set this to always return true, everything updates as expected: https://github.com/borisyankov/react-sparklines/blob/master/src/Sparklines.js#L42

OK - I can confirm that using the master branch react-sparklines@borisyankov/react-sparklines does fix the issue.
It looks like all that needs to happen is a new release be built and published.
Let me know if I can help or provide any other info.


fix data race issue

Please provide a description of this PR:
ref: https://github.com/istio/istio/issues/34115
the root cause is the go routinue blocked by the serve function and is executed after the tests completed. add a waitgroup to sync the goroutine
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[X] Security
[X] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Please check any characteristics that apply to this pull request.

[ ] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

@williamaronli: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
7ef0f24fdac48b92e41db7574fa9966e9492291d
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
7ef0f24fdac48b92e41db7574fa9966e9492291d
link
/test release-notes_istio

unit-tests_istio
7ef0f24fdac48b92e41db7574fa9966e9492291d
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
4836c5501c4b8b6c7cfbc690b73e5402c5e45116
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/rerun

/retest

/cherrypick release-1.11

@howardjohn: new pull request created: #34787

In response to this:

/cherrypick release-1.11

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


KMS 8 update content route translation

Coverage decreased (-0.07%) to 49.12% when pulling ea1807d10307b283165a6aa1ae8a428d7a920eea on KMS-8_update_content_route_translation into 6ed564cc3e310aa97b92e1f746df003f20856d1f on master.

Looks good for me :+1:


espi: auto enable the ESPI SAF XEC based on the device tree

The SAF XEC driver for eSPI was not enabled by default so sample code for espi was failing. This commit changes the behavior to match current scheme of enabling the drivers based on the status of required device tree nodes.
Signed-off-by: Michał Barnaś<EMAIL_ADDRESS>

fyi @rgundi

tagged as hotfix as this was causing a build breakage on main


[docs] Add AppBar demos with exapandable & primary search fields

I have added a demo in the appbar section in the docs, illustrating an appbar with an expandable search field.
Closes #12651

A benchmark:

Regarding #12651, should we focus on an "primary" search in the app bar rather than a "secondary" search?

@oliviertassinari I am working on an example, with a primary search bar in Appbar, I am going to add it in the demo within this PR.

I have added a new demo for primary search in AppBar.
Is it okay if we have 2 demo's in the AppBar? @oliviertassinari

Sweet, that look better :).

when is this going to be available?

@daiky00 In the next release.

@mbrookes Should the appbar with primary search field be responsive as well? So for e.g, when it goes to 'sm' view the search bar becomes a search icon only? Your thoughts?

App Bar with search field
@mbrookes Is this the right way to go for this? 😅

@adeelibr Good improvement - but the title is hidden prematurely, and AppBar with primary still overflows at the smallest browser width. One more iteration and we should be there!

@mbrookes is this better now? 😅

Yes, better 👍 , but one of the demos still overflows its container:

@mbrookes apologize for the late reply, I have been busy with my job lately. I made the adjustments as instructed, kindly do have a look at it. :) 😅

No need to apologize - thanks for working on it!
This looks good to me unless @oliviertassinari has any other comments.

I'm doing a second iteration, let's try to simplify the demo even more :).

There are so many awesome examples in this PR, but the final docs have very limited sample.
No example to show the full size search currently.
Is ther a reason we went with that?


Greenkeeper/ts node 5.0.1

:tada: This PR is included in version 2.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


create secret tls

I am trying to install ambassador and enable https.
I'm using this command that does work in command line, but since I want to use in azure-pipelines.yml and I need to use this task
to accomplish (since this task encapsulates, user, account, etc).
kubectl create secret tls tls-cert --cert=cert.pem --key=key.pem
How can I do it?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: dcbb25d1-a706-e8fc-61e4-d5b86aa54f47
Version Independent ID: 5634d9dd-fd92-761c-24b8-5e32ed6c6c35
Content: Kubectl task - Azure Pipelines & TFS
Content Source: docs/pipelines/tasks/deploy/kubernetes.md
Product: devops
Technology: devops-cicd
GitHub Login: @azooinmyluggage
Microsoft Alias: atulmal

I already saw that kubectl create secret tls tls-cert --cert=cert.pem --key=key.pem, it is a special syntax and by doing a generic command it works.
      - task: Kubernetes@1
        displayName: kubectl create secret for certificates
        inputs:
          connectionType: Azure Resource Manager
          azureSubscriptionEndpoint: xxx
          azureResourceGroup: xxx
          kubernetesCluster: xxx
          command: create
          arguments: secret tls tls-cert --cert=$(System.DefaultWorkingDirectory)/xxx.crt --key=$(System.DefaultWorkingDirectory)/xxx.key

Thanks for your question. It looks like you're working through an issue with your scenario or implementation, rather than an issue with the documentation. Here are a couple of options where you might consider asking your question:

Azure DevOps on Stack Overflow
Azure DevOps Support Bot

I am closing this issue now.  You are welcome to @ mention me for any followup.
We hope to hear from you again.


personal_menu: Add theme switcher to personal menu popover.

This PR introduces a theme switcher feature within the personal
menu popover. The implementation begins with the development of a
tab picker, which has the following features:

Utilization of radio buttons to emulate the tab picker.
Radio input buttons provides the native way in HTML to select one
value out of a set.

Support for both horizontal (default) and vertical orientations.
Vertical orientation can be achieved by appending the
.tab-picker-vertical class.

Respects the prefers-reduced-motion option set by the user.
Disables the sliding tab animation to improve accessibility.

Additionally, the theme switcher component incorporates error handling
mechanisms. In the event of a server/network error, the tab slider
reverts to the previous theme option after a delay of 500ms. This
behavior visually communicates the occurrence of an error to the user,
improving the UX.
Fixes: #22803.

Screenshots and screen captures:

Description
Screenshot/Screencast

theme-switcher-light-theme

theme-switcher-dark-theme

theme-switcher-demo

theme-switcher-prefers-reduced-motion

theme-switcher-tooltip

theme-switcher-keyboard-navigation

theme-switcher-on-error

theme-switcher-with-5-tabs (demo)

theme-switcher-vertical (demo)

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[x] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

This lgtm, gonna test-deploy on chat.zulip.org for feedback.

Pushed changes for the active state of the tab buttons (Reference).
Updated tab switcher on active (clicked):
https://github.com/zulip/zulip/assets/82862779/d8f4e3ab-7129-4dd3-b1d4-0370ced32ad6
Note: This only applies when animations are turned on. For prefers-reduced-motion, the interaction remains the same.

Merged, thanks @sayamsamal!


Fix routing and update request alike with the requirement

Codecov Report

Merging #5 (8f087fb) into main (b7ca3ac) will decrease coverage by 1.18%.
The diff coverage is 96.00%.

@@             Coverage Diff              @@
##               main       #5      +/-   ##
============================================
- Coverage     94.18%   93.00%   -1.19%
- Complexity       27       32       +5
============================================
  Files            13       14       +1
  Lines            86      100      +14
============================================
+ Hits             81       93      +12
- Misses            5        7       +2

Flag
Coverage Δ

tests
93.00% <96.00%> (-1.19%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

app/Rules/ObjectOrString.php
50.00% <50.00%> (ø)

app/Helpers/CustomResponse.php
100.00% <100.00%> (ø)

app/Http/Controllers/HashController.php
80.95% <100.00%> (+0.95%)
:arrow_up:

app/Http/Requests/HashMapRequest.php
100.00% <100.00%> (ø)

app/Http/Resources/HashMapResources.php
100.00% <100.00%> (ø)

app/Rules/OnlyOneJsonAllow.php
100.00% <100.00%> (ø)

app/Services/HashMapService.php
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7ca3ac...8f087fb. Read the comment docs.


Dev

cabal entry for calculating statistical result from dictionaries
working bench
better efficiency for storing statistical results

Needs to remove statistics, with a note of previous benchmark results and rename variables in WordTree :

isReal => exists
inser => insert
listToTree => fromList
mapToTree => fromMap


MinSDK15

Is there a reason for this?  I'm currently using minSDK14 and don't really want to add flavors based on SDK int yet (my app is targeted towards older devices).

Nope there isn't a reason, however currently there might be a few issues
when setting OnClickHandlers on API <21. I'm planning to sort this out next
week and at the same time I will lower the minSDK to 14 (I didn't think
there were many devices on SDK 14 - 4.0 as many went straight to 4.0.4)
Maybe check back next Wednesday?
On Fri, 30 Dec 2016, 2:40 pm easycheese<EMAIL_ADDRESS>wrote:

Is there a reason for this? I'm currently using minSDK14 and don't really
want to add flavors based on SDK int yet (my app is targeted towards older
devices).
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/daniel-stoneuk/material-about-library/issues/5, or mute
the thread
https://github.com/notifications/unsubscribe-auth/APIE1fMUOHMRatTfHdKsCN5e-8sbUAGxks5rNQnAgaJpZM4LYMOn
.

Lowered, check back soon for an update to the library

Great thanks!


Finish Task 2, integrating GitHub and Zenodo

Development here: https://github.com/OpenScienceMOOC/Module-5-Open-Research-Software-and-Open-Source/blob/master/content_development/Task_2.Rmd

The first draft of this task has now been completed, and is open for more feedback!

Second draft done. The end Zenodo bit is very tricky as Zenodo gets complicated and I feel you need to let people know what site they should be working on: GitHub, Zenodo.
Obviously pics will help here as with GitHub's version.
There are obviously things that are not too good in the Zenodo system. But hey.
I would suggest another proof and handing to a couple of newbies to see if the instructions work.

Yes, I think images will help a lot here. Will get around to adding them shortly.

Some nice work here - kudos!
As another pro tip, adding your preferred citation to your README.md further lowers the barrier to other people citing your work. If you're using the GitHub to Zenodo integration this is really easy as you can use their "Cite As" widget to create different styles (or just copy the default).
If you think this would be a good thing to add, I'll do a PR.

Hi @Protohedgehog - if it's the pro tip which is:

Copy the URL for the DOI into the README file for your GitHub repo to make cross-linking even easier, as well as present a clear highlighted DOI badge for users to see and make use of your DOI. You only need to do this once with your first release DOI as it acts as a 'concept DOI' and is linked to all subsequent release DOIs.

then not entirely. What I'm suggesting is that you put in the README.md a little section which says (something like):
Citing this software
If you've used our software in your research, please use the following citation:
Jon Tennant. (2018, July 30). Foundations for Open Scholarship Strategy Development: First formal release (Version 1.2). Zenodo. http://doi.org/10.5281/zenodo.1323437

I get you! But..and it might just be me..isn't this for the Open Scholarship Strategy? Or are you just using this as an example for this MOOC module..? I'm sensing crossed streams, but if you mean create a citation like this for each module, that will definitely be done at some point in the very near future! We could even make the first release for this module, like, now.. :)

Crossed streams :-)
What I meant was that in general, as part of open scholarship I think if you write software you should:

Use a code repository
Deposit your code and get a DOI
Make it as easy as possible for people to understand how to cite your software

The first part of Step 3 is making sure you put the DOI for the software you've just deposited in Zenodo in your README, but an additional step is to either put the "human-readable" version (I used your Open Scholarship Strategy as an example, but basically for whichever software you've deposited) in your README, particularly for researchers who are not as familiar with using DOIs to create citations in their preferred styles.
This is because I think open scholarship will only thrive if we acknowledge that our research builds on other people's work, and the current way that we do this is through citations. So making it easy for others to cite your software isn't just something selfish to help you (although that's a plus), it's also helping to show the interconnectedness and value around having an open community.

But yes, I also think it's worth having a preferred citation for each module as well so that people can cite your MOOC materials as well :-D

AHA! OK, I totally get you now. Awesome idea, sorry for being so slow. Have done this now for the strategy: https://github.com/Open-Scholarship-Strategy/site#citing-this-software and will make this as a separate protip for Task 2 here in a second. Thanks for taking the time to explain this for me :)
And great re. the MOOC, I'll make a first release for this module after making the edits! Exciting :)


Added Flashcards component by Mahmoud Ektefaie

This pull request adds a set of interactive Flashcards component to the collection. It includes styling for the component. The component is created by Mahmoud Ektefaie (GitHub: https://github.com/mektefaie) and it is inspired by teachings of Jonas Schmedtmann's in the Ultimate React course on Udemy.

i am getting an error at the last step. please advise as I am quite new to Git/GitHub.
Thank you for your step-by-step instructions.

 i am getting an error at the last step. please advise as I am quite new to Git/GitHub. Thank you for your step-by-step instructions.

So, see let me explain the issue:
Your remote branch that is the repo on github has different code this means code on your computer and the github is different. To solve this issue:
using git pull origin main
This will bring your repo latest chnages to your local machine. And then you can start working. Now once you have done thing apply what I told you above in my previous reply.  Let me know if this fixes.

i don't understand why, because i took your suggestions to heart and i changed the JSON settings in VSCode and turned quotes to "double-quotes" and added ";" to all statements. Under my GitHub repo, I also see double-quotes.

i don't understand why, because i took your suggestions to heart and i changed the JSON settings in VSCode and turned quotes to "double-quotes" and added ";" to all statements. Under my GitHub repo, I also see double-quotes.

Yes. it is fixed now.


Make getIssueFullPattern() concurrency save - bugfix #16415 (#16155, #16185)

Run processors on whole of text (#16155) #16185
This PR makes the function concurrent save. Fix the mention in PR #16185 and merge https://github.com/go-gitea/gitea/commit/5ff807acdebdd75960418060f465bb8ba79e96a6
Fixes #16415

@Dexus can you please target master first and then we will backport stuff if merged?

see #16417

I'm glad it's fixed, even if it's a pity that you're deprived of your own contribution.

That's not my point at all. Find it only a pity and wanted to put it also so to the expression.
So you can also show strangers that they should stay "outside".
Everything else would not have been the problem.
Anyway, thanks that it was addressed.

@Dexus as per https://github.com/go-gitea/gitea/pull/16417#discussion_r668840389 I think you can have the cance to a pull now ;)
just use sync.Once to init it on first call to the func


Review for Eddie

I tried creating my own testimonial folder, but I felt like I was not doing it like Eddie was in today's video. So, I created a testimonial file to add to Eddie's profile. I'm open to feedback.

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] My change requires changes to the documentation.
[x] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.


Daily Stats plugin has stopped working

Hi, the Daily stats plugin I am using, stopped working after the last update. Can no longer count words in folder notes. For normal notes, everything works fine. Can you do something about it or tell me how I can revert to the old version? Thanks

can you reproduce this in new(sandbox) vault? for old version, you can remove plugin and manually install the old version from GitHub Release


Fix broken links from shaypal5 to python-cachier

Work by @louismartin + some additional changes piggybacking by me. :)

Codecov Report

Merging #103 (eaf13d6) into master (2854226) will increase coverage by 0.00%.
The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files

@@           Coverage Diff           @@
##           master     #103   +/-   ##
=======================================
  Coverage   97.82%   97.83%
=======================================
  Files           5        5
  Lines         460      461    +1
  Branches       74       74
=======================================
+ Hits          450      451    +1
  Misses          6        6
  Partials        4        4

Impacted Files
Coverage Δ

cachier/base_core.py
100.00% <ø> (ø)

cachier/core.py
95.86% <ø> (ø)

cachier/mongo_core.py
97.01% <ø> (ø)

cachier/pickle_core.py
98.44% <100.00%> (+<0.01%)
:arrow_up:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2854226...eaf13d6. Read the comment docs.

Ok, done!


After a reboot flynn does not start.

I am runing 64bit Ubunty 16.04 with flynn nightly ( stable one has exactly the same problem)
After every reboot a single node flynn is not able to start.
when I run flynn-host ps it reporting only two services running
flynnmaster-e6e5d4f1-a2c2-4f56-9631-8633a55b3661  running  48 seconds ago  discoverd       app
flynnmaster-09aa2dee-7896-46c7-9edf-5d552a7f4c86  running  48 seconds ago  flannel         app
the collect-debug-info have 401 error.
Dashboard does not work for http not https
I did run the flynn-host log for first instnace of controller and i got this result:
panic: dial tcp <IP_ADDRESS>:5432: getsockopt: connection timed out [recovered]
panic: dial tcp <IP_ADDRESS>:5432: getsockopt: connection timed out
goroutine 1 [running]:
github.com/flynn/flynn/pkg/shutdown.(*handler).exit(0xc420067650, 0x0, 0x0, 0x0, 0x8a9a20, 0xc42007f4a0)
/go/src/github.com/flynn/flynn/pkg/shutdown/handler.go:69 +0x1d8
github.com/flynn/flynn/pkg/shutdown.Exit()
/go/src/github.com/flynn/flynn/pkg/shutdown/handler.go:40 +0x6a
panic(0x8a9a20, 0xc42007f4a0)
/usr/local/go/src/runtime/panic.go:491 +0x283
github.com/flynn/flynn/pkg/postgres.Wait(0xc42007ee10, 0x0, 0xa)
/go/src/github.com/flynn/flynn/pkg/postgres/postgres.go:83 +0x785
main.main()
/go/src/github.com/flynn/flynn/controller/controller.go:61 +0x10e
I have checkd that firewall is deactivated.

Flynn is unmaintained and our infrastructure will shut down on June 1, 2021. See the README for details.


Creation of codons file for MNPs script

Hi,
Thank you for providing the code for merging MNPs. I wanted to create codons file myself, however I am missing some steps. I am missing the step for creation of: GRCh38_ucsc_refseq_good_transcripts.noALT.bed which is required for awk script. Could you provide steps how to create it, if I want to use different reference than GRCh38?
Thanks,
Luka.

Hi Luka,
Thank you for your interest in our project and for bringing this issue to our attention. We've added some additional directions to the merge_mnp/README file that should solve this issue. We've also updated the awk script so that it is compatible with the most recent output from the UCSC table browser. Please feel free to reopen (or comment on) this issue if you still have questions.
Best,
Don

Dear development team,
could it be that you gave the wrong script name in the merge_mnp/README?
In the README it says
cat  | awk -f mnp_with_codons-create_codon_file.awk > codons.txt
however, I can only find merge_by_codon-preprocess_codon_file.awk in your directory. However, using this file seems to lead to correct results when applying on the UCSC table output.
Best regards, Barbara


Merge Cypress to Smavo

Closes

User facing changelog

Additional details

How has the user experience changed?

PR Tasks

[ ] Have tests been added/updated?
[ ] Has the original issue or this PR been tagged with a release in ZenHub?
[ ] Has a PR for user-facing changes been opened in cypress-documentation?
[ ] Have API changes been updated in the type definitions?
[ ] Have new configuration options been added to the cypress.schema.json?

Solicitud de extracción al día 27/01/2022 - 22:20pm


Make DBTrieLoader receive the current root on constructor

Make the DBTrieLoader receive the current root on instantiation in a similar way to the database wrappers we use inside the module (i.e. with new(root) and empty() methods).
See: https://github.com/paradigmxyz/reth/pull/1515#discussion_r1132454953

No longer relevant (DBTrieLoader doesn't exist)


Use Mutex.synchronize instead of Thread.exclusive

Fixes #34

No problem! Let me know if you push a release out with this so I can get our production listeners updated, thanks for the quick merge 👍

Yeah, I was just about to say v1.0.11 has been tagged and pushed to RubyGems!


Can't create new account on (test) pypi.org, username invalid

I'm trying to create an account on https://test.pypi.org/ , to familiarize myself with the process of uploading a package.
No matter what I enter as username, mail or password, it is never successfully created, and I get the error message shown above, that my username is invalid and it may only contain letters, numbers, dots, hyphen, underscores and it has to begin and end with either a letter or a number. I may please choose a different username.
My username is within the described constraints. (same result for only letters, for example)

Hi @MaximilianHauser, sorry you're having trouble. It doesn't look like you've put anything in the "Username" field, just the "Name" field, which should be your name, like Maximilian Hauser.

I didn't look at the thing properly, as autocomplete filled out the form, putting my email in the username field, my brain registered the field as the repeat your email address field. Fields are empty, because I removed the email in paint.
My brain was mushy. Sorry for taking up your time.


Behaviour of the show -qr flag

The gopass show command has a -qr flag that displays a QR code on the terminal to allow one to easily copy a password from its password store to its mobile phone using it.
##Expected behaviour
If the -qr flag is set, it should print a QR code containing the first secret value, but it should display the rest of the entry like gopass show would.
The -o flag should prevent it from displaying the rest of the entry, just like it does with the regular show command.
The -f flag should force it to display all the entry below the QR code, including the password on the first line.
The -c and -C flags should do exactly as they usually do but with the secret printed in both case as a QR code on top of being copied. Notice the -c flag should in theory copy the password to the clipboard without displaying the rest of the entry, while the -C flag should copy the password, and display the rest of the entry.
NB: It is not clear to me if these should copy the password or copy the QR code. I'm not sure the QR code is using characters that can be usefully pasted into another display than a terminal (it's using unicode escapes to display it, no?)
This is coming from #1488.

Thanks for filing this issue.
Not sure if this is something I want to do before we have properly documented all the flags.
Your suggestions sound good to me, so we should implement it as you described.
I don't think -c should copy the qr code, but the password itself.


Table output unavailable on Tableau Prep

About You:
Name: Yotam Steinberg
Your question:
Hi,
I'm trying to create a table output in Tableau Prep and I can not select my DB even though my JDBC connector is approved by Tableau.
Thanks,
Yotam

Hi Yotam,
Unfortunately, this functionality is currently not supported for plugin connectors.
Thanks & Regards,
Vasanthi Neelagiri
Product Manager, Tableau

Hello,
Any update regarding this issue?
I have a customer who wants to use my plugin connector and Tableau Prep to output to the table.
Thanks,
Yotam


Task is not available after installation

I just installed this extension on my on-prem ADS 2019.1 instance, but it's not showing up in the list of available tasks for my pipeline.
Is there something more I need to do? There doesn't appear to be any special configuration needed under the extension management page.

Hi @InteXX ,
I am very sorry for the long time to respond. Is this still an issue?

No problem. It's not as though there's a shortage of things to do around here ;-)
Yes, the problem still manifests.
The extension is installed:

...but no tasks are displayed for it:

You might have some ideas on how to get it working.

Hi there,
do you have access to your Azure DevOps admins panel, the url should be sth like this:
https://dev.azure.com/{ORGANIZATION}/_settings/extensions?tab=installed
In the past I´ve seen that the extension is still listed under "Requested" and needs to be accepted by an administrator.

I reinstalled the extension from the marketplace and it's showing up now. Not sure what went wrong the first time.


Swift3

Converted to Swift3

Good job! Please update RippleEffectView/RippleEffectView.swift (you updated it in demo project only), and remove team from Project file. Thanks.

@mbalex99 can you please check my comment and update the pull request?

Yes I'll do it this morning sorry was away for vacation
Sent from my iPhone

On Nov 29, 2016, at 3:05 AM, Alex Sergeev<EMAIL_ADDRESS>wrote:
@mbalex99 can you please check my comment and update the pull request?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Hi @mbalex99, I'll wait till weekend and if you have no time to fix it then I have to close the request.

Okay I did a big fix. You should get a better pull request sometime
tomorrow.
On Wed, Dec 7, 2016 at 6:43 AM Alex Sergeev<EMAIL_ADDRESS>wrote:

Hi @mbalex99 https://github.com/mbalex99, I'll wait till weekend and if
you have no time to fix it then I have to close the request.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/alsedi/RippleEffectView/pull/2#issuecomment-265464571,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACFSMZ0DcDpcRQ8x35fH3rEjcc7n3ZD8ks5rFsYUgaJpZM4K3JYg
.

--
Maximilian Alexander
<EMAIL_ADDRESS>www.maxofeden.com

Thanks!


FEAT: Glaive-coder

Is your feature request related to a problem? Please describe
https://huggingface.co/glaiveai/glaive-coder-7b

#490


fix: Fix self.algorithms data type

Requires list data type

jwt.decode() method  in PyJWT  requires a list data type.
def decode(
        self,
        jwt: str,
        key: str = "",
        algorithms: Optional[List[str]] = None,
        options: Optional[Dict] = None,
        **kwargs,
    ) -> Dict[str, Any]:

@fuh uhhhh, sure!
Though digging into the source dependencies, the signature suggests it could be [Any | None].
def _verify_signature(
        self,
        signing_input,
        header,
        signature,
        key="",
        algorithms=None,
    )

But yeah, let's go ahead and change it to a list.
Though you might want to test things out using $CASDOOR_PYTHON_SDK/src/tests/test_oauth.py,
you should set up your own Casdoor instance to test it.
This repo is lack of maintenance, if you see anything suspicious, we might be able to try to work through it :)

@fuh @ffyuanda is this PR ready to merge?

@hsluoyz LGTM

@fuh can you also fix this? https://github.com/casdoor/casdoor-python-sdk/issues/10

@fuh can you resolve the conflicts?

@Steve0x2a can you make a PR to fix it?


[DO NOT MERGE] Testing release automation for template-second

[azure-template-second-cpp] Update to 1.0.0-beta.30

OSX check is not reporting status. Closing and reopening to hopefully re-trigger CI.

@JonLiu1993 -- This PR is to validate some publishing automation I'm improving for the Azure SDK and we don't plan to merge it. However, part of how I assess the success of the automation is by ensuring that the vcpkg CI is green. I see that the OSX job is stuck and has been stuck in a queued state for a long time. Is there a way to get osx validation to start?

@danieljurek ,Currently the pr on CI is stuck in x64-osx verification, please wait for the CI problem to be located


Find a suitable testing website/API

We need something on the web, which returns static results we can then check in tests.
For now we will be using http://www.jsontest.com/, but it's quota is not big.
We need a replacement for that.

50


[Identity] Fix Identity ManagedIdentityCredential flaky unit test

Fixes #15978

Closing in favour of https://github.com/Azure/azure-sdk-for-js/pull/15999


Two suggestions: screenshots, and table-of-features

I suggest two things:
(1) add screenshots, no matter how incomplete it is so far, ideally of some simple website, and then perhaps also at some later point a more complicated web site
(2) for attracting devs, I'd recommend a table of implemented (and missing) features. That way people can quickly look at what needs work and can invest a little bit of time perhaps when they see amount of work required for this or that feature
Just two suggestions! Please feel free to ignore this or close it at any moment in time for any reason.

Yep already was thinking of this. Added the todo list. At the moment there is nothing you can take screenshots of, except raw html code.


Removed bypass security and added sanitizatier

:nut_and_bolt: Description: What code changed, and why?
Signed-off-by: AadeshNichite<EMAIL_ADDRESS>
Removed bypass security and added sanitizatier
:chains: Related Resources
https://chefio.atlassian.net/browse/CHEF-4439
:+1: Definition of Done
:athletic_shoe: How to Build and Test the Change
:white_check_mark: Checklist
All PRs must tick these:

[ ] I have read the CONTRIBUTING document.
[ ] All commits signed-off for the Developer Certification of Origin.

With occasional exceptions, all PRs from Progress employees must tick these:

[ ] Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
[ ] Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
[ ] Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
[ ] Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
[ ] Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

[ ] Tests added/updated? (all new code needs new tests)
[ ] Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.
:camera: Screenshots, if applicable

Raised Same PR for 'Secuirty-fixes' branch.


NTR: Updating Ascension (TEST)

Test issue: How to update ascensions. Source: http://data.iita.org/pages/tools

Great! you succeeded creating an issue for term creation request  in AgrO


[Not for merge] Fix att_rate.

I'm fine to merge this and keep that code working even though we're not really using it.


Add sidecar for postgres migration container

Run openfga migrate when running with postgres persistency

Can we do it with initContainers? I tried to solve it like this:
    spec:
      containers:
        - image: openfga/openfga
          name: openfga
          ports:
            - containerPort: 3000
              name: playground
            - containerPort: 8080
              name: http
            - containerPort: 8081
              name: grpc
          envFrom:
            - configMapRef:
                name: openfga-configs
            - secretRef:
                name: openfga-secrets
          readinessProbe:
            httpGet:
              path: healthz
              port: http
      initContainers:
        - image: openfga/openfga
          name: migrations
          command: ["migrate"]
          envFrom:
            - configMapRef:
                name: openfga-configs
            - secretRef:
                name: openfga-secrets

Though it didn't work somehow. 😄 I do not have much expertise in kubernetes.

Hi @neeraj-ec, my apologies for the late answer. Actually we can do it with initContainers. However, I'm having a second thought of adding a job, it might be more appropriate than executing migrations every time a pod is created. It will save time & resources cost.
If you want to implement it, I'd be happy to review your PR.


Remove StatusCode::CREATED for DefaultController::new

We should use a generic S: ResponseCode for the DefaultController trait.

Released in version 0.26.0


clarify the wording about JPA and ORM

JPA is a specification that certain ORMs adhere to (e.g. Hibernate
or EclipseLink). These ORMs typically also provide their own public
APIs that can be accessed directly. So the relationship between
the JPA and ORM terms is nuanced: they are not quite the same,
but they are not completely unrelated either. This commit tries
to improve the wording in this area.
Also there are some other small fixes in the CRUD mission docs.

LGTM. Merging.

Merged:https://github.com/openshiftio/appdev-documentation/commit/b60b459df8f7a1f7bbf1b6df98458cfa05569e41


TECH-472: Update BB Digital Registry - DELETE /data////delete

Update BB Digital Registry - DELETE /data/registryname/versionnumber/ID/delete
Ticket:
https://govstack-global.atlassian.net/browse/TECH-472

@ingmarvali could you please review this ticket?


Handle keys that look like integers

I had to flatten and then unflatten json which had arrays and also some keys of the form "0", "1" (strings with numbers).   I hacked on the code a bit disambiguate arrays from these keys by adding a "@", but the way I did it breaks backward compatibility.  Here it is for reference:
https://github.com/yzadik/flatten/commit/3302f142aebb90d93c581c7b00f6f3406a423b6d

idk if this issue is related to the #48 issue referenced but, I am also observing this issue. I think the root of the problem is because of the way list indexes are flat packed.
# Original dict A
{'foo': ['a', 'b', 'c']}

is flat packed as:
# Flat dict A
'foo_0': 'a',
'foo_1': 'b',
'foo_2': 'c',

Which is identical to the way the following dict would also be packed:
# Original dict B
{
    'foo': {
        '0': 'a',
        '1': 'b',
        '2': 'c',
    }
}

Which again is flat packed as:
# Flat dict A
'foo_0': 'a',
'foo_1': 'b',
'foo_2': 'c',

and so both of these flat packed formats are unpacked into the same structure (NOT desired, as you can see we started with 2 very different JSONs/dicts)
Maybe this could be solved by changing how list item indexes are flat packed? I have seen other libraries use this format foo[0]: 'a' for list indexes, leaving the foo_0': 'a' format unambiguously a dict only format representing the key 'foo' which itself has a nested dict with the key '0'.
Though the above approach creates another bug if implemented because then what do you do if the original dict looks like this?
{
    'IAmJustAKeyName[0]': 'Not a list item'
}

^ This may be an acceptable bug until someone figures out how to fix that edge case though as I think mixing up list indexes and keys named just '' is a much more common problem than unintentionally casting a key named 'foo[0]' to a list item.


Nit on windows

The compiler still does not work on Windows, it might be cool for the v1

@BlackMinou good luck with that.
Also, the first step should be to add a Windows infra to Jenkins.
Again©, good luck with that.

doc: https://wiki.haskell.org/Windows
ping @xymus

I just installed Nit on Windows 10 using Cygwin. It is surprisingly easy but somewhat limited, here are my notes.

Install cygwin with the default packages and the following:
make ccache pkgconfig libisl10 libcloog-isl libgc-devel

Then, from the cygwin command line, clone the Nit repo as usual:
git clone https://github.com/nitlang/nit.git
It will complain about the "very bad name" tests files. They cannot be represented on a Windows FS. Ignore this message, all other thousands of files should have unpacked successfully.

From the nit folder, run make, it will most likely not work on the first time. Here is how to fix each error:

If it complains about \r in git-gen-version.sh, run:
dos2unix src/git-gen-version.sh
and run make again.

If there is heap size errors, enlarge the heap of nitc.exe with:
peflags --cygwin-heap 4096 c_src/nitc.exe
and run make again.
You may have to apply this command to all the bootstrap stages: c_src/nitc.exe, src/nitc_0.exe, bin/nitc.exe.

When you finally have a bin/nitc.exe, compile and execute hello_world with:
bin/nitc.exe examples/hello_world.nit
./hello_world.exe

To distribute a program outside of the cygwin environment, copy the cygwin and libgc DDLs with the executable. More DLLs may be needed for programs using native libraries, but for hello_world.exe and nitc.exe only the following libraries are needed:

/bin/cyggc-1.dll /bin/cygwin1.dll

More work is needed to actually develop Nit programs under a Windows environment. Simple programs like hello_world and Fibonacci work well outside of cygwin. However the compiler still expects UNIX-like paths and can't find nit_dir.

Additional notes:

nitc reports all annotations as unknown, I'm not sure if they are applied but it hasn't caused any problems yet.
I didn't find libunwind for cygwin, but I didn't search much either.
Cygwin offers a somewhat limited set of libraries. So I haven't yet been able to compile game and nitcorn apps with this approach, but I haven't tried very hard. The missing libraries can probably be compiled from source.
For a better and long term support of Windows for Nit, we should try using mingw/msys.

I kept looking into cygwin and managed to run gamnit games (OpenGL ES 2.0 with SDL 1.2). It's slow... but it works and it could be a starting point for other attempts.

Install additional cygwin libs:
libGLESv2-devel libEGL-devel libSDL-devel libSDL-image-devel libSDL-ttf-devel xinit

Compile as usual with make, let's use Asteronits in contrib/asteronits.

Run in a X server with:
xinit -e bin/asteronits.exe

I tried the steps of @xymus ; its work.
So I copy-pasted to http://nitlanguage.org/windows.html (please review and improve it)
I also ran the tests manually (ie tests/, examples/ and lib/*/examples )
What worked: most of the things, including FFI, nitcorn, regexps, curl, threads and asteronits.
What did not work:

opengles1 (so no mnit games)
lib/socket/socket_c.nit (compilation error because missing FFI C symbols like AF_IPX)

libunwind-dev is'nt available yet?

libunwind-dev is not mandoatory. (the message seems a bit scary and misleading)


Realtime colors updating is not working

MacOS, desktop app.
Screencast

I see there's something wrong with the real time edit. I'm going to fix the issue quickly.

I improved a bit the real-time edit responsiveness. Could you tell me if the result is acceptable? I need more investigations on improving performances.

Tested it. I can confirm it is way better now, but sometimes still have issues with real-time updating. But technically it is usable and working just fine.
Can you provide some info on my another request? For additional lightness. Are you going to implement it?

From: Aurélien Grimaud @.>
Sent: Tuesday, March 29, 2022 19:47
To: inVoltag/figma-ui-color-palette @.>
Cc: Oleksandr Horpeniuk @.>; Author @.>
Subject: Re: [inVoltag/figma-ui-color-palette] Realtime colors updating is not working (Issue #2)
CAUTION: This email originated outside of Intellias. Please do not click any links or open attachments unless you recognize the sender and know the content is safe. Thank you.
I improved a bit the real-time edit responsiveness. Could you tell me if the result is acceptable? I need more investigations on improving performances.
—
Reply to this email directly, view it on GitHubhttps://github.com/inVoltag/figma-ui-color-palette/issues/2#issuecomment-1082117660, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AYOFIK5HWKGXLXI2VVNNA33VCMX2JANCNFSM5R2VJR3Q.
You are receiving this because you authored the thread.Message ID: @.***>

Understood, I keep this performance issue in mind.
Concerning your request, could you open another issue? I'm working on it.


Enable sidebar when clicked on "Save"

Really loving the sidebar toggling feature which gives enlarged view to map bigger and longer features.
Can we enable sidebar by default when Save button is clicked so that the mapper will be be shown changeset comment details before uploading ? (this reduces confusion on what is the next step specially for new mappers).

Oh yeah - good suggestion!


Add proper testing for the compile matcher

The bad_dep_host is a now-redundant test.

Coverage increased (+0.7%) to 90.809% when pulling f64bae460e68e1ccbe654b2f89177bd0d4fa995e on DavidS:add-compile-testing into fb27c533e2664057fba4b73d0bd902a946abfce0 on rodjek:master.

Coverage increased (+0.7%) to 90.809% when pulling b519b1ac9e2c77deb723ed9632aabdf6ae281eb4 on DavidS:add-compile-testing into fb27c533e2664057fba4b73d0bd902a946abfce0 on rodjek:master.

Coverage increased (+0.7%) to 90.814% when pulling fe5022709f9b559bc7426b134ab2cd2d4f7f5899 on DavidS:add-compile-testing into fb27c533e2664057fba4b73d0bd902a946abfce0 on rodjek:master.

Coverage increased (+0.7%) to 90.814% when pulling 0c648145898b8012e88861d95d7ec034849b56cd on DavidS:add-compile-testing into fb27c533e2664057fba4b73d0bd902a946abfce0 on rodjek:master.

Coverage increased (+0.7%) to 90.814% when pulling 66ab522eba3c9ff40d8ddaa7770e989239e4b710 on DavidS:add-compile-testing into fb27c533e2664057fba4b73d0bd902a946abfce0 on rodjek:master.

Coverage increased (+0.7%) to 90.818% when pulling 6f171319cf51035bb3e7e06941fb84e13ea28734 on DavidS:add-compile-testing into fb27c533e2664057fba4b73d0bd902a946abfce0 on rodjek:master.


util to dedup dependencies

Describe the feature
Follow up of: https://github.com/nuxt/cli/pull/573#issuecomment-2506061673
nypm should support dedupe.
Package manager support
npm
npm should have build in dedupe https://docs.npmjs.com/cli/v10/commands/npm-dedupe
pnpm
https://pnpm.io/cli/dedupe
yarn
https://yarnpkg.com/cli/dedupe
bun
planned: https://github.com/oven-sh/bun/issues/8594#issuecomment-2195796840
deno
?
Additional information

[X] Would you be willing to help implement this feature?

For the first step, I think we can throw an error from util / cli this way nuxi can fallback to a warning or prompt for alternatives.
In next step I like to introduce a util for upgrading deps with different options but that might take longer.

For the first step, I think we can throw an error from util / cli this way nuxi can fallback to a warning or prompt for alternatives.
In next step I like to introduce a util for upgrading deps with different options but that might take longer.

so i should start or wait for the upgrading? :)

Feel free to start it will unblock nuxi :)

Feel free to start it will unblock nuxi :)

i have added it. i hope it fits like this


New package: gmsh v0.1.1

Registering package: gmsh
Repository: https://github.com/koehlerson/gmsh.jl
Created by: @koehlerson
Version: v0.1.1
Commit: 5f1085d6bd8c68c52774799878ebd08e25d33cd9
Git reference: master

@koehlerson There is already a registered package called Gmsh.jl, you can't register a package with the same case-insensitive name.  Note that this would make the register unusable on case-insensitive file systems, which are very common on Windows and macOS systems.

@koehlerson There is already a registered package called Gmsh.jl, you can't register a package with the same case-insensitive name.  Note that this would make the register unusable on case-insensitive file systems, which are very common on Windows and macOS systems.


In mv command, there should be en error if destination directory not present.

Node version (or tell us if you're using electron or some other framework):
node version: v18.17.1
ShellJS version (the most recent version/Github branch you see the bug on):
ShellJS version: 0.8.5
Operating system:
Ubuntu 23.04
Description of the bug:
In mv command if the destination directory does not exist, the stderr should have the error message.
Example ShellJS command to reproduce the error:
On linux shell, there is an error message.
$ touch test-file.txt
$ mv test-file.txt /path/doesnot/exist/
mv: cannot move 'test-file.txt' to '/path/doesnot/exist/': No such file or directory

Javascript:
const shell = require('shelljs')
var resp = shell.mv('./test-file.txt', '/path/doesnot/exist/')
console.log(resp.stderr)
// null

I agree, this should ideally return an error. Some comments about this:

mv test-file.txt does-not-exist/ should throw an error because does-not-exist/ must be interpreted as a folder (due to the trialing slash). This is the case which is broken in shelljs: the behavior is actually correct (it does not copy the file), but it needs to print an error message about the issue.
mv test-directory does-not-exist/ should not throw an error; test-directory is a directory, so it will be renamed to a directory named does-not-exist. This case works as expected in shelljs.
mv test-file.txt other-test-file.txt does-not-exist is supposed to throw an error; if there are 3 arguments, then the last argument must be a folder which already exists. This case works as expected in shelljs.


Use tybalt cli to run unit tests in example

We tried this once here: https://github.com/doug-wade/tybalt/pull/432


Run the Tests not working

Describe your problem and how to reproduce it:
Hi all. The 'Run the Tests' button doesn't appear to be working. I have entered Hello World but when I click the Run the Tests button, I get the '// running tests' message. I tried to clear the cache but this does not seem to have worked. Does anyone have any suggestions? Thanks and all the best.
Add a Link to the page with the problem:
https://learn.freecodecamp.org/responsive-web-design/basic-html-and-html5/say-hello-to-html-elements/
Tell us about your browser and operating system:

Browser Name: Microsoft Edge
Browser Version: 42.17134.1.0
Operating System: Windows

If possible, add a screenshot here (you can drag and drop, png, jpg, gif, etc. in this box):

@mccoymap could you put a screenshot of your code?

Hi @mccoymap,
Thanks for opening this issue.
We currently do not support Edge. Please use Chrome or Firefox.

Thanks guys! All working in Chrome as you suggested. All the best


How to run formatter-astyle?

I just downloaded and installed formatter-astyle for Atom, but I cannot figure out how to actually use it to format a file. Perhaps you could add a line to the documentation to either 1) tell us what the default key-binding is, or 2) how to create a key-binding, or 3) which menu we can find the formatting under. Thanks!

I'll see to improve the docs.
the reason there is no doc is that this package is an extension of the formatter.
It provides the keybindings and shortcuts:
'atom-text-editor':
  'alt-ctrl-l': 'formatter:format-code'
  'alt-cmd-l': 'formatter:format-code'

Ok - that makes sense - Thanks!
Aside:  On Ubuntu, alt-ctrl-l is set to lock the computer, so I think that I'll need to change either the key bindings in Ubuntu or in formatter so that I can use both.

It provides the keybindings and shortcuts:

i think it would make sense to mention the short-cuts anyway. I was also trying to figure out how to actually run the formatting...


[BUG] d435i not working using USB 2.0

Issue description:
D435i camera is not working on USB 2.0 - it's detected, but app crash when tries to start the capture stream. D415 is working fine with the same stream configs. Lowering stream settings to 640x480 does not help. Disabling the color stream helps.
Environment:

Application version: 0.2.2
Device: ASUS ZenFone AR V570KL
OS: Android 7
Camera: D435i camera
Camera firmware: <IP_ADDRESS>

Steps to reproduce:

Run the app
Connect the camera
Allow camera connection
App crash

Additional context
Looks like camera requires additional bandwidth for the hid devices (IMU), so it has not enough for the base streams (depth+color).

Added a number of checks to disable color stream if pipeline is not started. Now d435i at least will produce pointcloud (but white color) using USB 2.0 connection.


ccrewrite removes non-Contract method call, resulting in NullReferenceException

Somewhat ironically, Code Contracts has introduced a null reference exception into my code by removing a function call.
The repro case is simple: When ccrewrite removes calls to Contract methods (e.g. in ReleaseRequires mode), it will also remove any semi-inlined methods.
Code:
using System;
using System.Diagnostics.Contracts;

namespace ContractsInlining
{
	class Program
	{
		static void Main(string[] args)
		{
			object thing = null;
			var didTheThing = TryDoThing(out thing);
			Contract.Assume(didTheThing);
			Console.WriteLine("The thing: {0}", thing.ToString());
		}

		static bool TryDoThing(out object value)
		{
			value = new object();
			return true;
		}
	}
}

IL of Main:
.method private hidebysig static
	void Main (
		string[] args
	) cil managed
{
	// Method begins at RVA 0x2048
	// Code size 42 (0x2a)
	.maxstack 4
	.entrypoint
	.locals init (
		[0] object thing,
		[1] bool didTheThing
	)

	IL_0000: nop
	IL_0001: ldnull
	IL_0002: stloc.0
	IL_0003: ldloca.s thing
	IL_0005: call bool ContractsInlining.Program::TryDoThing(object&)
	IL_000a: stloc.1
	IL_000b: ldloc.1
	IL_000c: ldnull
	IL_000d: ldstr "didTheThing"
	IL_0012: call void System.Diagnostics.Contracts.__ContractsRuntime::Assume(bool, string, string)
	IL_0017: nop
	IL_0018: ldstr "The thing: {0}"
	IL_001d: ldloc.0
	IL_001e: callvirt instance string [mscorlib]System.Object::ToString()
	IL_0023: call void [mscorlib]System.Console::WriteLine(string, object)
	IL_0028: nop
	IL_0029: ret
} // end of method Program::Main

IL of Main with compiler optimizations:
.method private hidebysig static
	void Main (
		string[] args
	) cil managed
{
	// Method begins at RVA 0x2048
	// Code size 37 (0x25)
	.maxstack 4
	.entrypoint
	.locals init (
		[0] object thing
	)

	IL_0000: ldnull
	IL_0001: stloc.0
	IL_0002: ldloca.s thing
	IL_0004: call bool ContractsInlining.Program::TryDoThing(object&)
	IL_0009: ldnull
	IL_000a: ldstr "out thing"
	IL_000f: call void System.Diagnostics.Contracts.__ContractsRuntime::Assume(bool, string, string)
	IL_0014: ldstr "The thing: {0}"
	IL_0019: ldloc.0
	IL_001a: callvirt instance string [mscorlib]System.Object::ToString()
	IL_001f: call void [mscorlib]System.Console::WriteLine(string, object)
	IL_0024: ret
} // end of method Program::Main

As you can see, instead of storing the result of TryDoThing and re-loading it, it leaves it on the expression stack. This is equivalent to Contract.Assume(TryDoThing(out thing), null, "didTheThing").
IL of Main with compiler optimizations, ReleaseRequires and Public Surface Contracts only:
.method private hidebysig static
	void Main (
		string[] args
	) cil managed
{
	// Method begins at RVA 0x2048
	// Code size 19 (0x13)
	.maxstack 4
	.entrypoint
	.locals init (
		[0] object thing
	)

	IL_0000: ldnull
	IL_0001: stloc.0
	IL_0002: ldstr "The thing: {0}"
	IL_0007: ldloc.0
	IL_0008: callvirt instance string [mscorlib]System.Object::ToString()
	IL_000d: call void [mscorlib]System.Console::WriteLine(string, object)
	IL_0012: ret
} // end of method Program::Main

Both the call to Contract.Assume and the call to TryDoThing have been eliminated by ccrewrite. This results in a NullReferenceException at runtime.
This happens in both VS2013 and VS2015. IL above is from 2015.

I have the same problem. In my case, the rewriting works well in VS2013, but has improperly eliminated some non-contract code in VS2015. If I can ask, this should be handled as one of the highest priorities.

@yaakov-h This is a very interesting bug.
Consider following code:
Contract.Assume(SomeMethod());

What ccrewrite should do in this case?
Currently, ccrewrite will remove Assume as well as SomeMethod() method call. This behavior is consistent with Debug.Assert behavior.
Now, switching back to the original example:
var result = SomeMethod();
Contract.Assume(result);

In Debug build there would be a local variable and ccrewrite can understand this and leave SomeMethod call. But turning optimization on this code would be transformed by C# compiler to the first example.
So from ccrewrite perspective there is no way to distinguish those cases at all...
So current proposal sounds like this to me: Let ccrewrite leave all the expressions evaluated as a first argument on evaluation stack.
I do agree that in some cases this could be very beneficial, but I do believe that it could be not what other people want from the ccrewrite.
Consider following code:
Contract.Assume(CheckSomeHeavyweightState());

This check would be removed right now and for some users this could be exactly what they need (and this is exactly what is required for few of my projects).
It means that proposed change would be a breaking change and not everyone will agree that new behavior is desirable.
P.S. I do believe we need to do something with this issue, but I'm not sure that simple approach (just not remove the call to Contract.Assert) is a best way to solve it.

BTW, as far as I remeber, ccrewrite has very weird bug, that ccrewrite will never remove complex expressions.
Consider following:
Contract.Assume(Foo());

In this case, Foo method invocation would be removed for None or Pre/Post modes.
But in this case:
Contract.Assume(Foo() || Boo());

In this case call to Contract.Assume would be removed, but invocation expressions will be in the evaluation stack.
This definitely a bug that could be very hard to tackle. For instance, you can avoid NRE in you code simply by changing your code to: Contract.Assume(didTheThing || false);.

@ZbynekZ Maybe you've faced #191 issue. Could you confirm, please, that you're facing current issue that I believe is by design (unfortunately).

@yaakov-h ok, It seems that this behaviour needs to be changed to proposed one.

@SergeyTeplyakov I think my case is #242 and not #191. The only difference I can tell was that in my case, it has worked correctly up to VS2013, and appeared in VS2015 Release builds, but I think there might be some explanation for it that we just do not know at the moment. Besides this, everything else is practically identical, and it is VS2015 that concerns me now, and with that we are all seeing the same.
I have read the analysis and it makes sense. Unfortunately, there is probably no "good" solution based just on IL, if the source code that should in end behave differently compiles to the same IL.
I think that therefore we need to look at this form the practical point of view: If we simply allow the current behavior of the rewriter and claim it as "standard", lots of code that will appear correct will end up being rewritten to incorrect code, and it would be (at least in case of my large projects) very difficult if not impossible to scan all the code for places where this danger appears, and make sure to work around it somehow.
If, on the other hand, we go with the proposal "Let ccrewrite leave all the expressions evaluated as a first argument on evaluation stack.", all code will behave correctly, and when writing new code, the developer will not have to always think about whether some of his statements are not going to disappear. The only negative thing that can happen is that an argument to Assume or Assert will get evaluated when it "should not". That may be sub-optimal because a) it has some side effect, or b) is heavy to compute. The side effect thing I think should not be an issue at all, because that's not how contracts should be written, and in the Debug build that same thing would be called anyway, so it makes even less sense to claim that the same side effect would be undesirable in Release build. The heavy-weight computation of a contract condition might be a problem sometimes, but is relatively rare, and as such I think can be avoided with extra conditional directive - I think that this is something the developer can keep an eye on, much easier than trying to figure out whether a statement that is not in any Assert or Assume would be subject to removal.

@SergeyTeplyakov Maybe just to sum up my argument: I think it is far better to end up with a program that has some extra code that is just evaluating a contract condition (without actually enforcing it), rather than end up with a program that has pieces of code removed, where the actual scope of the removed piece depends on an implementation detail of a compiler, and as such it is generally unpredictable.

@SergeyTeplyakov thanks for looking into this, I'll try that workaround.
@ZbynekZ this issue (#242) occurs in both 2013 and 2015. If your problem only occurs in 2015, this may not be your problem.

@yaakov-h, @ZbynekZ I think that current behavior needs to be changed to proposed one.
The reason for that is simple: VS2015 is doing much more optimization that VS2013.
Consider following code:
var hashSet = new HashSet<int>();
bool b = hashSet.Add(42);
Debug.Assert(b);

In VS2013 even with Release mode local b would be in the resulting IL and the code would behave correctly even when asserts are disabled. But in VS2015 in Release mode the local would be removed and the hashSet would not have 42 in it!

@yaakov-h My proposed workaround will not work, because C# compiler is smart enough to entirely remove || false.
ccrewrite would preserve complex expressions (I do believe this is a bug, but anyway) but you need more complex non-constant expression.

@SergeyTeplyakov The code you posted regarding the hashset adds 42 to the HashSet in all cases that I could test - Debug, Release, Debug with optimizations, and Release without optimizations.
Debug.Assert(hashSet.Add(42)); however, only adds 42 to the HashSet in Debug builds.
This makes me think that Roslyn is smart enough to tell the difference between what is and isn't part of the Debug.Assert expression - assumedly, because it uses the code, not the generated IL.
Here's the IL output of Release with optimizations from VS2015 (Update 1 RC):
		IL_0000: newobj instance void class [System.Core]System.Collections.Generic.HashSet`1<int32>::.ctor()
		IL_0005: stloc.0
		IL_0006: ldloc.0
		IL_0007: ldc.i4.s 42
		IL_0009: callvirt instance bool class [System.Core]System.Collections.Generic.HashSet`1<int32>::Add(!0)
		IL_000e: pop

I assume there's no way to match this behaviour when IL is the input, as is the case with Code Contracts?

@yaakov-h Sorry, I've copy-pasted wrong code. I meant Contract.Assert not Debug.Assert.
Debug.Assert is conditionally compiled, so the method invocation would be removed in compile time if no DEBUG symbol is defined.

@SergeyTeplyakov That's what I thought, though Roslyn seems a bit more selective about what it removes and what it keeps.
So with Contracts interrogating the IL, is the only way an all-or-nothing approach (keep all expressions inside Contract.Assume/Assert/etc., or remove them all), or is there any avenue that could be used to determine whether a variable was optimized out?
I don't like the idea of leaving potentially expensive checks in, but I can't see any other way.

@yaakov-h Unfortunately I don't have any ideas, how to distinguish between those two cases.
The only way to think about it: not to remove (or warn) if non-pure method was put into Contract.Assume and warn or just not to remove this call. In this case the behavior would be consistent. The only problem with this approach - there is no simple way to tell whether expression is Pure or not (there is no way to tell if some arbitrary method is Pure if no attributes were added to it).
I don't like the idea of leaving checks on the stack, but I can't see other options right now as well...

@SergeyTeplyakov Good point on using [Pure]. I'd also suggest, if possible, to strip out expressions with no assignment or function calls. That way, Contract.Assume(foo != null) would also disappear, but Contract.Assume(Foo() != null) would still result in Foo being called, unless marked as [Pure].

@yaakov-h I'm thinking about long-term and short-term fixes for this issue. I really hope to release new version very soon, and maybe for this version I'll just fix this stuff to leave all expressions on the evaluation stack and will create an work item to fix this properly... What do you think?

@SergeyTeplyakov Sounds like a decent short-term fix, as long as there's still a long-term one in the works.

Agreed with the recent proposals. If the rewriter manages to remove stuff that it identifies as "pure" - be it for the presence of [Pure} attribute, or other simple cases (foo != null) - then even better so.

We ran into this issue as well.  A couple of options:

Provide overloads for Contract.Assert and friends which take a Func or Expression<Func>, and deprecate the old interfaces.  That'd be optimiser-proof (and future-proof), and upgrading to the new API is as simple as globally replacing "Contract.Assert(" with "Contract.Assert(()=>".  As a special bonus, ccrewrite wouldn't even need to elide the calls.

Possible backward compatibility hack: read the IL debug info from the PDB and elide the code that constructs the argument if it appears after the Contract.Assert and before the start of the next statement; spew warnings wherever the PDB info is unavailable or ambiguous.  Even if this works (which is debatable), it's probably pretty poor form and would probably break in the future (no, I don't like it either).

Most likely I'll be implementing option 1 until we have something better :)

Also ran into this issue.
I like the pure approach.


how to manage ghidra settings when moving to new version

Hi,
Do you plan or is there a way to manage this ? for example, when we upgrade the version, the settings are auto copied or something like this.

When you install and launch a new version of Ghidra, it should use the settings from your previous version (stored in the ~/.ghidra directory).  However, a breaking change was made in 9.1 that made it impossible to find the previous installation.  It should work for future versions of Ghidra though.  To test it, you can go into the Ghidra/application.properties file of your 9.1 installation, increment the application.version property, and the settings should carry over on the next launch.  The first entries of the application log should indicate what settings it's using.


Search Results component should relax Guess Total limit

Is your feature request related to a problem? Please describe.
ASC enforces a hard limit of 2000 on guess total. However, sometimes more are needed. It would be good to relax this limit allowing for larger limits - keeping the actual used guess total value configurable.
Describe the solution you'd like
Allow any value to be configured for guess total.
Describe alternatives you've considered
Pagination or results.
Additional context
See https://github.com/Adobe-Marketing-Cloud/asset-share-commons/pull/553
... The checkbox technically doesn't add much. We can just let ppl set whatever value and warn them that large values can impact performance.

See https://github.com/adobe/asset-share-commons/pull/557#issuecomment-937800846


test(#177): booking room dusk tests

IMPORTANT: Always create an issue before a PR and provide enough information so that others can review

Explain the details for making this change.
What existing problem does the pull request solve?

Test plan (required)
Demonstrate the code is solid.  Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.

Closing issues
List all issues this PR resolves

closes #XXXX

Pre-Merge checklist
Complete these items before requesting reviews

[ ] Static Analysis Rules Validated
[ ] All commits follow naming conventions

Sub-tasks Checklist

[ ] UI Implementation
[ ] UI Test
[ ] Backend Implementation
[ ] Backend Tests
[ ] Integration Tests
[ ] System Tests
[ ] Documentation

@jonathanp16 I was having similar issues on my dusk tests. Make sure you rebuild the FE assets on your local so they match the main branch.

@jonathanp16 I was having similar issues on my dusk tests. Make sure you rebuild the FE assets on your local so they match the main branch.

Was wondering what the issue was... thanks for the heads up @EvanDime


Allow multiple tracks when using --combine-files

When the video has more than one track, --combine-files output only the first, which causes this error as displayed below.
auto-editor example.mp4 example2.mp4 --combine-files --keep-tracks-separate --edit audio:stream=1

Error! Audio stream '1' does not exist.

This is now fixed in master. Will eventually put into release.


Leverage secret file for authentication

Hi @Lirt
I notice that "--no-secret" is used when installing plugin which means the users have to declare all the variables in deployment or daemonset or something like that. It's fine in local but sort of inappropriate in production I suppose. For example, I have to declare these variables below in deployment.yaml to ensure authentication is passed.

Have you ever considered creating a secret file for authentication?
Besides, the "openstack" is not yet presented in supported provider lists of velero official doc. Would you like to add openstack into the doc for the convenience of others as well?
Would you like to give me any suggestions on how to deal with those OS variables if no secret file used?

I suppose there are two parts of modification if using secret file on velero side:

Add openstack credentials file in pkg/install/daemonset.go and pkg/install/deployment.go. The value should be /credentials/cloud. The aws credentials file is described as below:

The cloud-credentials secret exists in the Velero server's namespace

The cloud-credentials secret has a single key, cloud, whose value is the contents of the credentials-velero file

The credentials-velero file is formatted properly and has the correct values:

[default]
aws_access_key_id=<your AWS access key ID>
aws_secret_access_key=<your AWS secret access key>
The cloud-credentials secret is defined as a volume for the Velero deployment

The cloud-credentials secret is being mounted into the Velero server pod at /credentials

Add openstack related information into site/docs/master/supported-providers.md

Nevertheless, it's just my thoughts and I believe I'm not 100% correct obviously because I'm not expert on this part. Could you please share your opinion or recommendation? Thanks.

Hello,
regarding the secret, Kubernetes can safely inject environment variables. You need to create secret with variables specified as you did and load it using envFrom.
So if you run kubectl explain deployment.spec.template.spec.containers.envFrom you can see documentation about it.
In the yaml it looks like this (I can give you full example later when I have time):
       containers:
       - name: my-container
         envFrom:
         - secretRef:
             name: my-swift-secret

I personally install velero and also the plugin using helm chart https://github.com/vmware-tanzu/helm-charts/tree/main/charts/velero.
I can give you full example if you want or include it in documentation. Maybe it would be useful for everyone.

Regarding using file as an authentication, gophercloud as library offered only authenticating using environment variables or reading RC file. Now I found out that there is also function in utils (different library) to read credentials from file in clouds.yaml format.
I can implement this, but in the end you will create the secret file in a simliar kubernetes way as I described above:

Create secret with clouds.yaml contents.
Create volume of type secret referring to the secret.
VolumeMount it to the plugin container.

So I think there is no security benefit from it.

Here is values.yaml file I use when installing from helm chart. Setting credentials.extraSecretRef to secret velero-credentials makes it to load it. The secret must be created beforehand of course and it is up to you how to install it (gitops, flux, argocd, vault, manually).
---
deployRestic: false
serviceAccount:
  server:
    create: true
    name: velero
credentials:
  extraSecretRef: "velero-credentials"
configuration:
  provider: swift
  backupStorageLocation:
    bucket: "velero-backup-for-my-cluster"
schedules:
  caas-full-backup:
    schedule: '0 * * * *'
    template:
      excludedNamespaces: null
      excludedResources: null
      hooks:
        resources: null
      includeClusterResources: null
      includedNamespaces:
      - '*'
      includedResources: null
      labelSelector: null
      storageLocation: ""
      ttl: 168h0m0s
metrics:
  serviceMonitor:
    enabled: false
initContainers:
- name: velero-plugin-swift
  image: lirt/velero-plugin-swift:v0.1.1
  imagePullPolicy: IfNotPresent
  volumeMounts:
  - mountPath: /target
    name: plugins
snapshotsEnabled: false
backupsEnabled: true

Regarding making plugin community official I was interested but I need to improve quality control -> implement more tests and prepare local dev environment (still WIP).

Hi @Lirt
Thanks for your time on this. Basically, I'm doing as exaclty what you just mentioned. Here is my partial values.yaml and I'm going to set all the credentials to the secretContents value via envFrom.
credentials:
  useSecret: true
  secretContents: {}

# Whether to create backupstoragelocation crd, if false => do not create a default backup location
backupsEnabled: true
# Whether to create volumesnapshotlocation crd, if false => disable snapshot feature
snapshotsEnabled: false

Here is my partial secret.yaml. Actually, I'm working on the multi cloud and basically I don't intend to change the format of secret file. The question is if I use envFrom to load the secret, the variables in OS are going to be like "cloud: OS_AUTH_URL=xx, OS_USERNAME=xx" and it is definitely can't be recognized by velero. Is there any approach to load the value of cloud only instead of the whole data content? I'm not sure if I make myself clear, If not, sorry for my weak expression and knowledge and feel free ask me anytime.
apiVersion: v1
data:
  cloud: **
kind: Secret
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"v1","data":{"cloud":"**"},"kind":"Secret","metadata":{"annotations":{},"labels":{"app.kubernetes.io/name":"velero","name":"velero","namespace":"default"},"type":"Opaque"}
  creationTimestamp: "2021-01-14T05:41:20Z"
  labels:
    app.kubernetes.io/name: velero
  name: velero
  namespace: default
type: Opaque

BTW, It is how I use envFrom to load secret.

{{- if eq $provider "swift" }}
          envFrom:
            - secretRef:
                name: velero

Kubernetes doesn't have function for extracting specific content from file/secret as far as I know.
I think you need to extract the cloud part you want for each cloud (for example if you have multiple Swifts and you want to use the one in that cloud) and put it into separate secret (that's not a big issue to have one more secret). If you only use one Swift, just extract its cloud part and create that secret for velero.
If there was functionality like this with multi-cloud clouds.yaml file the plugin would also need to know which one of those clouds does user want to use for the backup. So there would need to be additional variable and logic.
I think Velero cannot benefit from having multiple clouds in its config. There is always only one place where to store the cluster backups or snapshots (it's designed like that). Also for snapshots it is technically impossible, because you always must do snapshot of volume in the same locality as where the volume is.

Okay. Currently, we have aws, azure providers, etc. And they retrieve credentials from /credentials/cloud. Perhaps I need reform the structure of secret.yaml to adapt with swift. Thanks anyway and I'll close this ticket. Appreciate it.

Ah you mean multiple environment setup. I misunderstood a bit. I can include auth via file later on but the priority is now for block storage implementation. Hope you will find solution for now.

Hi @Lirt
Sorry for not making myself clear. There are indeed multiple cloud environment from my side. Besides, I'd like to ask what do you mean by including auth via file? You mean you're going to use /credentials/cloud as well instead of loading OS variables in deployment by our own? If so, I'll make a workaround for this for now and adapt the new code in the future. Obviously, block storage is prior for now and I hope you can make further progress on this. Thanks again.

Yes, to look for cloud config using standard openstack and velreo paths or custom path.
The block storage support was released today.

That's awesome! Thanks.

Hi @Lirt ,
Sorry to trouble you again. I'd like to confirm if the plugin supports retrieving secrets from /credentials/cloud. Based on aforementioned circumstance, I'm enabling multi-environment setup and looking for a uniform pattern to retrieve secrets from  /credentials/cloud. Thanks.
BTW, I'd like to give you an sample of deployment.yaml for your reference.
env:
            - name: VELERO_SCRATCH_DIR
              value: /scratch
            - name: VELERO_NAMESPACE
              valueFrom:
                fieldRef:
                  apiVersion: v1
                  fieldPath: metadata.namespace
            - name: LD_LIBRARY_PATH
              value: /plugins
          {{- if .Values.credentials.useSecret }}
            {{- if eq $provider "aws" }}
            - name: AWS_SHARED_CREDENTIALS_FILE
              value: /credentials/cloud
            {{- else if eq $provider "azure" }}
            - name: AZURE_CREDENTIALS_FILE
              value: /credentials/cloud
            {{- else if eq $provider "alibabacloud" }}
            - name: ALIBABA_CLOUD_CREDENTIALS_FILE
              value: /credentials/cloud
            {{- else if eq $provider "openstack" }}
            - name: OPENSTACK_CREDENTIALS_FILE
              value: /credentials/cloud
            {{- end }}
          {{- end }}

Just in case you missed the message, I'm going to reopen this issue. If any inappropriate, please let me know. Thanks. :)


BRIDGE: move from cloud APIs to evpn-gw APIs

Except for docker-compose, there is no conflict with #76 which is going to be a correct configuration going forward
Signed-off-by: Boris Glimcher<EMAIL_ADDRESS>

as agreed with @mardim91 on slack, merging this now.
It is initial implementation and needs more tests and fixes.
Merge will allow other people to contribute as well
After #76 is merged, this can properly be tested and fixed as needed


simplify pop code

In the spirit of https://github.com/purescript/purescript-maps/pull/103

Thanks!


No feedback when you miss a question or give wrong answer

When you click the check your answer button to pass the comprehension checks after each lecture video of the upcoming FSD cert, if you miss a question no feedback is given.
If you give a wrong answer you need to scroll up to see the feedback. In both cases, it would be useful to provide a simple message right above the check your answer button saying something like `You have unanswered questions and/or incorrect answers."

Hmm is it possible to trigger a banner flash from that component?


Overlapped com and pro label in the graph

Limit them!

depends on #73

commit 38046136cc0268a1c181f291d0303384978497bd
Author: Vektor Dewanto<EMAIL_ADDRESS>Date:   Wed Jan 25 07:52:32 2017 +0700
truncate node label text


DCC suggested a change to ITI-103 transaction name

DCC suggest to modify definition to
"Obtain metadata about a Authorization Server, such as endpoint locations and signing key material."

Duplicate to #55

Duplicate to #55


kernel selection

VS Code Version:  1.74.3 (Universal)
OS Version: MacOS 13.1

This a new problem and I do not know why it happens. When I launch vscode I do not have kernel as usual (I use Jupyter notebook). I don't know what's happened ????
when I click on "select kernel" I have an empty data that appears in the menu
Thx for your help


New release?

Hi, it's me again! I was wondering if you could push the changes to crates.io? As something like 0.3.1 or 0.4.0, that would be great! I don't know how to help with that.

Sure, I can make a release.

It's now release as v0.3.1


Ability to set a seed (or maybe a System.Random instance)?

Hi there. I'm strongly considering using this library for probability distributions in my own game. However, I need to be able to set the initial seed for all distributions; I can't rely on UnityEngine.Random except for that initial seed. Is it possible to explicitly provide a seed (or a System.Random instance) for each generator to use?

Hi! All the distributions support Func as an iid source. You can use it to get such a functionality.
I'll think about a better solution but not before the first release.

Interesting. I'll take a closer look and see if that'll let me do what I need. If not, I'll get back to you with further questions. Thank you!

Also, I maybe have a better solution. You can create your own IContinuousGenerator. For example, https://github.com/ZorPastaman/Random-Generators/blob/master/Runtime/ContinuousDistributions/UniformDistributions/UnityDistribution/Generators/UnityGenerator.cs. and its provider https://github.com/ZorPastaman/Random-Generators/blob/master/Runtime/ContinuousDistributions/UniformDistributions/UnityDistribution/GeneratorProviders/UnityGeneratorProvider.cs.
In this case you get all you need and default Unity serialization.

Hi again. In this commit https://github.com/ZorPastaman/Random-Generators/commit/19609c161095985be69ba54de0c7fb26ce261251 I added a wrapper for System.Random. You can use it directly or as a depended generator for other distributions.

Beautiful, thank you! If I have any problems I'll be sure to reach out.

Ah, looking at it there's just one thing. Is it possible you could allow us to modify the SharpGeneratorProvider seed (or the underlying System.Random) at runtime?

Do you mean SharpGenerator or exactly SharpGeneratorProvider?
It's pretty easy to add such a functionality to SharpGenerator but such a modification in SharpGeneratorProvider is wrong ideologically.

I don't know. How about this; why don't I describe my use case and then you can suggest something within your library that fits it? I'll do so in another thread.


Add acceptance tests to the CI

There are some acceptance testing. They still need to be converted and added to the CI

https://github.com/cucumber/demo-formatter/pull/5


Check the software usage to get the pose of the trackers without the headsets

Following https://github.com/ami-iit/yarp-openvr-trackers/issues/10, we are able use openVR to obtain the trackers poses without the headset. However, the current version of the software (https://github.com/ami-iit/yarp-openvr-trackers/releases/tag/v0.0.1), doesn't support it yet.
In this issue, we highlight the difference in behavior when eliminating the headset.
In detail, following #10, then launching
yarpdev --device transformServer --ROS::enable_ros_publisher 0 --ROS::enable_ros_subscriber 0

then
yarp-openvr-trackers

Streams these error messages
[ERROR] The state of the output of device LHR-87B324E3 is not ok

Which seems to be coming from https://github.com/ami-iit/yarp-openvr-trackers/blob/cd153dbb2c9a6c5056cf13bd74865c7b14850f1a/src/OpenVRTrackersDriver.cpp#L317-L322

Some observations

When we launch yarp-openvr-trackers it detects a device called /hmd/Null Serial Number, which seems to be the dummy driver we enable to bypass the headset. It also detects the trackers when they are connected.
The identified tracker is considered of the unsupported type, seeing this message

[INFO] The device xxxxxx has unsupported type

Which seems to be coming from https://github.com/ami-iit/yarp-openvr-trackers/blob/cd153dbb2c9a6c5056cf13bd74865c7b14850f1a/src/OpenVRTrackersDriver.cpp#L203-L206
But it seems only a warning.

Commenting out the checks in https://github.com/ami-iit/yarp-openvr-trackers/blob/cd153dbb2c9a6c5056cf13bd74865c7b14850f1a/src/OpenVRTrackersDriver.cpp#L317-L322 and in https://github.com/ami-iit/yarp-openvr-trackers/blob/cd153dbb2c9a6c5056cf13bd74865c7b14850f1a/src/OpenVRTrackersDriver.cpp#L324-L328 doesn't solve the issue. The streamed pose of the tracker seems frozen, probably it took the first value and then refused to take other values.
Actually, looking at the documentation of the method GetControllerStateWithPose, it seems that the pose is updated when the last button event occurred, so it was probably waiting for a button to be pressed (Maybe it considers the tracker as a controller).
It seems that the correct method is GetDeviceToAbsoluteTrackingPose, (I didn't see then the issue #8 😄).

After the modification in #12, the device can work without the headset, but I had to change the line
https://github.com/ami-iit/yarp-openvr-trackers/blob/e6694adeb30d18f279fabd06fd867d76b44b3415/src/OpenVRTrackersDriver.h#L59-L60
From Seated to Standing. Not sure if updating it upstream will affect other use cases.


Clicking on a "..." menu again after opening doesn't close the menu

Issue Type: Bug
Prior to the new menu work (which I love btw), if you clicked on the "..." icon again after opening the menu it would close it. That doesn't work anymore, the menu just stays visible.
/cc @sbatten
VS Code version: Code - Insiders 1.29.0-insider (d7ac6e838f51a03f7d417b4758f5fb075878d615, 2018-11-01T06:20:59.729Z)
OS version: Windows_NT x64 10.0.18267

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz (8 x 4008)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: enabledvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
31.93GB (19.76GB free)

Process Argv
C:\Users\Eric\code\codestream\vscode-codestream\codestream.code-workspace

Screen Reader
no

VM
0%

Let's add it!

code changes in PR. moving to December to merge in debt week.


Default for Web API Feature Toggle

Summary
In 4.1.0 a feature toggle was introduced to enable/disable the Web API.  There's a config setting under System Setup > General Setup > Application Settings in the configuration pages to enable or disable the API.  However when "Use Default" is checked the UI defaults to showing the "Enable API" checkbox as checked, implying the API is enabled.  It is disabled, and will give a 404 error.
This is misleading, as the implicantion is that when a setting called "Enable API" is checked (i.e. turned on) that the API should be enabled.  Having the default be the API is off, and the UI show the checkbox as checked is bad user/developer experience.
If I uncheck "Use Default", the API is enabled when the checkbox is checked, and disabled when not as expected.  It's only when "Use Default" is checked, that the setting is forced to be on, but the API is actually disabled.
It seems like this only occurs in the "prod" environment.  In the "dev" environment it seems to work as expected.
Steps to reproduce
Do a clean install of 4.1.0 or later.  Look at the configuration page, note that "Enable API" setting is checked (but the checkbox is disabled), and "Use Default" is also checked.  Make an API request.
Actual Result
The API request will 404 because the API is disabled.  Even though it appears enabled in the UI.
Expected Result
The API request will 200 because the API is enabled as the UI suggests it should be.
Details about your environment

OroPlatform version: 4.1.0 (or later)
PHP version: 7.3.13 (but shouldn't be PHP version specific)
Database (MySQL, PostgreSQL) version: N/A

Hi @jimohalloran,
Have you installed an application with the demo data?

I've just installed the oro/platform-application:4.1.0 without the demo data. By default the checkbox is unchecked:

It could be the specific browser issue, I checked in Chrome or the application cache issue.
Please note, the system configuration is environment-sensitive. When you change the setting in a prod env it will not affect dev env without clearing the cache.

So I've done a little more digging.  I usually access my development OroCRM in the dev environment.  I'm willing to trade a bit of page load time for the convenience of not manually loading translation files, etc.  My API client was using the prod environment.  Whenever I changed a config setting, I would do a complete cache flush (more on this in a bit) before I used the API.  So I don[t think this is an issue of config settings not propagating between environments due to cache.
When I clear cache, I stop the queue worker, websockets server and cron jobs.  rm -rf var/cache/*, bin/console cache:warmup --env prod, bin/console cache:warmup --env dev and start the queue worker, etc again.  This is all scripted, so everything stops, clears and starts reliably.  There shouldn't be any possibility of cached data surviving in any form after this clear.
Your screenshot is interesting, because when the "Use Default" checkbox is checked, I was seeing the "Enable API" checkbox checked also.  I'm also using Chrome.  My database is the same one I've been developing this site on for the last 6 months, started live as a 3.1 install, which was upgraded to 4.0.x, and now 4.1.0.  All migrations have been run, and demo data was not loaded.  I'd expect with respect to this setting a clean install without demo data would replicate this issue, as I was not even aware of this parameter until today.
To respond to this ticket tonight, I've fired up my dev environment again, and once again checked "Use Default".  Then I cleared cache as per the process described above.  If I log into the "dev" environment, I can see "Enable API" is checked.  But if I log into the "prod" environment, it isn't.  See screenshot:

So it seems as though the default is different in each environment?  I've done some searches on OroApiBundle and I can't find any code that would change the default depending on environment.  So this seems very odd.  However, it does seem as though the API honours this default depending on the environment you use for the API, which would explain why I couldn't repro this issue in the dev environment earlier.  It also explains why when I look at the configuration page in dev environment but call the API in prod it's disabled but appears like it should be enabled.
Is the default being different in dev vs prod environments by design?  It's not very intuitive.  I would never have expected that the default config values could be different based on the environment I'm viewing.  Is this the way it is meant to be?  And if so, how is it implemented?  I'd be curious to see the code so I know what to look out for in future.

Is the default being different in dev vs prod environments by design?

This is the bug. I'm able to reproduce it locally.
Internal ticket id #BAP-19989
For now, as a workaround, please do not use "Use Default" for this option and define the value explicitly for both environments.

The behavior has been fixed (see: https://github.com/oroinc/orocommerce-application/commit/01d57c42e8af8d3dda9d84d53f8677722d12364f). It will be available with the next 4.1 patch release.
Thank you for your contribution!


MSIAppServiceTokenCredentials doesn't support single user-assigned managed identities

Package Version: _______
nodejs
nodejs version: 3.0.3
Describe the bug
Azure supports two types of managed identities: system-assigned and user-assigned. Currently, MSIAppServiceTokenCredentials doesn't support user-assigned identities.
To Reproduce
Steps to reproduce the behavior:
1.
Create node.js function app, assign only one user-assigned identity
const msRestNodeAuth = require("@azure/ms-rest-nodeauth");
const creds = await msRestNodeAuth.loginWithAppServiceMSI();
Expected behavior
creds return successfully
Screenshots
Exception: Error: Invalid token response, did not find tokenType. Response body is: {"statusCode":400,"message":"Unable to load requested managed identity.","correlationId":"d7e4de93-374a-428f-b6c9-21d9c42966f5"}
Stack: Error: Invalid token response, did not find tokenType. Response body is: {"statusCode":400,"message":"Unable to load requested managed identity.","correlationId":"d7e4de93-374a-428f-b6c9-21d9c42966f5"}
at MSIAppServiceTokenCredentials. (/home/site/wwwroot/node_modules/@azure/ms-rest-nodeauth/dist/lib/credentials/msiAppServiceTokenCredentials.js:70:23)
at Generator.next ()
at fulfilled (/home/site/wwwroot/node_modules/@azure/ms-rest-nodeauth/dist/lib/credentials/msiAppServiceTokenCredentials.js:6:58)
at processTicksAndRejections (internal/process/task_queues.js:97:5)
Additional context
This maybe a bug in backend MSI agent where it should return token when only one user-assigned identity is available. However don't know if the backend MSI agent is open source or how to create issue for that.
Note that this is similar to https://github.com/Azure/ms-rest-nodeauth/issues/79, but when there is only one user-assigned identity so the client id should not be needed.
Even though the doc says "If omitted, the system-assigned identity is used." it is not user friendly as the code will need to know what is the only client id and not consistent with vmMSI where it can get token without problem.
creds = await msRestNodeAuth.loginWithVmMSI();

This was fixed by this pull request https://github.com/Azure/ms-rest-nodeauth/pull/85 as far as my tests can confirm. A new version will be released this week.

I'll be closing this for now! Please let us know if we've missed something, @wuzhuoqing