Failed to create any VectorStore - Error building Component Astra DB / Chroma DB

Bug Description
I am trying to create a VectorStore for RAG, but I cannot create any vectorstore. I have tried both Astra DB and Chroma DB and none of them works for me.
I am currently installing Langflow in my machine and using a conda environment. I have ensured the terminal to have sudo permission before I ran python -m pip install langflow -U to install Langflow.
Reproduction
I am using the GUI, so I will provide screenshots instead of code snippets.
Astra DB:

This is the error message for Astra DB:
Error building Component Astra DB:

Error initializing AstraDBVectorStore: HTTPConnectionPool(host='localhost', port=8080): Max retries exceeded with url: / (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x74b3266a0a60>: Failed to establish a new connection: [Errno 111] Connection refused'))

Traceback (most recent call last):
  File "/home/ubuntu/.local/lib/python3.10/site-packages/urllib3/connection.py", line 198, in _new_conn
    sock = connection.create_connection(
  File "/home/ubuntu/.local/lib/python3.10/site-packages/urllib3/util/connection.py", line 85, in create_connection
    raise err
  File "/home/ubuntu/.local/lib/python3.10/site-packages/urllib3/util/connection.py", line 73, in create_connection
    sock.connect(sa)
ConnectionRefusedError: [Errno 111] Connection refused

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/ubuntu/.local/lib/python3.10/site-packages/urllib3/connectionpool.py", line 793, in urlopen
    response = self._make_request(
  File "/home/ubuntu/.local/lib/python3.10/site-packages/urllib3/connectionpool.py", line 496, in _make_request
    conn.request(
  File "/home/ubuntu/.local/lib/python3.10/site-packages/urllib3/connection.py", line 400, in request
    self.endheaders()
  File "/home/ubuntu/anaconda3/envs/langflow-env/lib/python3.10/http/client.py", line 1278, in endheaders
    self._send_output(message_body, encode_chunked=encode_chunked)
  File "/home/ubuntu/anaconda3/envs/langflow-env/lib/python3.10/http/client.py", line 1038, in _send_output
    self.send(msg)
  File "/home/ubuntu/anaconda3/envs/langflow-env/lib/python3.10/http/client.py", line 976, in send
    self.connect()
  File "/home/ubuntu/.local/lib/python3.10/site-packages/urllib3/connection.py", line 238, in connect
    self.sock = self._new_conn()
  File "/home/ubuntu/.local/lib/python3.10/site-packages/urllib3/connection.py", line 213, in _new_conn
    raise NewConnectionError(
urllib3.exceptions.NewConnectionError: <urllib3.connection.HTTPConnection object at 0x74b3266a0a60>: Failed to establish a new connection: [Errno 111] Connection refused

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/ubuntu/anaconda3/envs/langflow-env/lib/python3.10/site-packages/requests/adapters.py", line 667, in send
    resp = conn.urlopen(
  File "/home/ubuntu/.local/lib/python3.10/site-packages/urllib3/connectionpool.py", line 847, in urlopen
    retries = retries.increment(
  File "/home/ubuntu/.local/lib/python3.10/site-packages/urllib3/util/retry.py", line 515, in increment
    raise MaxRetryError(_pool, url, reason) from reason  # type: ignore[arg-type]
urllib3.exceptions.MaxRetryError: HTTPConnectionPool(host='localhost', port=8080): Max retries exceeded with url: / (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x74b3266a0a60>: Failed to establish a new connection: [Errno 111] Connection refused'))

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<string>", line 221, in build_vector_store
  File "/home/ubuntu/anaconda3/envs/langflow-env/lib/python3.10/site-packages/langchain_astradb/vectorstores.py", line 435, in __init__
    embedding_dimension_m = self._get_embedding_dimension()
  File "/home/ubuntu/anaconda3/envs/langflow-env/lib/python3.10/site-packages/langchain_astradb/vectorstores.py", line 471, in _get_embedding_dimension
    self._get_safe_embedding().embed_query(
  File "/home/ubuntu/anaconda3/envs/langflow-env/lib/python3.10/site-packages/langchain_community/embeddings/huggingface.py", line 465, in embed_query
    return self.embed_documents([text])[0]
  File "/home/ubuntu/anaconda3/envs/langflow-env/lib/python3.10/site-packages/langchain_community/embeddings/huggingface.py", line 446, in embed_documents
    response = requests.post(
  File "/home/ubuntu/anaconda3/envs/langflow-env/lib/python3.10/site-packages/requests/api.py", line 115, in post
    return request("post", url, data=data, json=json, **kwargs)
  File "/home/ubuntu/anaconda3/envs/langflow-env/lib/python3.10/site-packages/requests/api.py", line 59, in request
    return session.request(method=method, url=url, **kwargs)
  File "/home/ubuntu/anaconda3/envs/langflow-env/lib/python3.10/site-packages/requests/sessions.py", line 589, in request
    resp = self.send(prep, **send_kwargs)
  File "/home/ubuntu/anaconda3/envs/langflow-env/lib/python3.10/site-packages/requests/sessions.py", line 703, in send
    r = adapter.send(request, **kwargs)
  File "/home/ubuntu/anaconda3/envs/langflow-env/lib/python3.10/site-packages/requests/adapters.py", line 700, in send
    raise ConnectionError(e, request=request)
requests.exceptions.ConnectionError: HTTPConnectionPool(host='localhost', port=8080): Max retries exceeded with url: / (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x74b3266a0a60>: Failed to establish a new connection: [Errno 111] Connection refused'))

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/ubuntu/anaconda3/envs/langflow-env/lib/python3.10/site-packages/langflow/graph/vertex/base.py", line 694, in _build_results
    result = await initialize.loading.get_instance_results(
  File "/home/ubuntu/anaconda3/envs/langflow-env/lib/python3.10/site-packages/langflow/interface/initialize/loading.py", line 64, in get_instance_results
    return await build_component(params=custom_params, custom_component=custom_component)
  File "/home/ubuntu/anaconda3/envs/langflow-env/lib/python3.10/site-packages/langflow/interface/initialize/loading.py", line 151, in build_component
    build_results, artifacts = await custom_component.build_results()
  File "/home/ubuntu/anaconda3/envs/langflow-env/lib/python3.10/site-packages/langflow/custom/custom_component/component.py", line 617, in build_results
    return await self._build_with_tracing()
  File "/home/ubuntu/anaconda3/envs/langflow-env/lib/python3.10/site-packages/langflow/custom/custom_component/component.py", line 605, in _build_with_tracing
    _results, _artifacts = await self._build_results()
  File "/home/ubuntu/anaconda3/envs/langflow-env/lib/python3.10/site-packages/langflow/custom/custom_component/component.py", line 640, in _build_results
    result = method()
  File "/home/ubuntu/anaconda3/envs/langflow-env/lib/python3.10/site-packages/langflow/base/vectorstores/model.py", line 132, in build_base_retriever
    vector_store = self.build_vector_store()
  File "/home/ubuntu/anaconda3/envs/langflow-env/lib/python3.10/site-packages/langflow/base/vectorstores/model.py", line 25, in check_cached
    result = f(self, *args, **kwargs)
  File "<string>", line 223, in build_vector_store
ValueError: Error initializing AstraDBVectorStore: HTTPConnectionPool(host='localhost', port=8080): Max retries exceeded with url: / (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x74b3266a0a60>: Failed to establish a new connection: [Errno 111] Connection refused'))

Chroma DB:

This is the error message for Chroma DB
Error building Component Chroma DB:

HTTPConnectionPool(host='localhost', port=8080): Max retries exceeded with url: / (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x74b3266c27d0>: Failed to establish a new connection: [Errno 111] Connection refused'))

Traceback (most recent call last):
  File "/home/ubuntu/.local/lib/python3.10/site-packages/urllib3/connection.py", line 198, in _new_conn
    sock = connection.create_connection(
  File "/home/ubuntu/.local/lib/python3.10/site-packages/urllib3/util/connection.py", line 85, in create_connection
    raise err
  File "/home/ubuntu/.local/lib/python3.10/site-packages/urllib3/util/connection.py", line 73, in create_connection
    sock.connect(sa)
ConnectionRefusedError: [Errno 111] Connection refused

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/ubuntu/.local/lib/python3.10/site-packages/urllib3/connectionpool.py", line 793, in urlopen
    response = self._make_request(
  File "/home/ubuntu/.local/lib/python3.10/site-packages/urllib3/connectionpool.py", line 496, in _make_request
    conn.request(
  File "/home/ubuntu/.local/lib/python3.10/site-packages/urllib3/connection.py", line 400, in request
    self.endheaders()
  File "/home/ubuntu/anaconda3/envs/langflow-env/lib/python3.10/http/client.py", line 1278, in endheaders
    self._send_output(message_body, encode_chunked=encode_chunked)
  File "/home/ubuntu/anaconda3/envs/langflow-env/lib/python3.10/http/client.py", line 1038, in _send_output
    self.send(msg)
  File "/home/ubuntu/anaconda3/envs/langflow-env/lib/python3.10/http/client.py", line 976, in send
    self.connect()
  File "/home/ubuntu/.local/lib/python3.10/site-packages/urllib3/connection.py", line 238, in connect
    self.sock = self._new_conn()
  File "/home/ubuntu/.local/lib/python3.10/site-packages/urllib3/connection.py", line 213, in _new_conn
    raise NewConnectionError(
urllib3.exceptions.NewConnectionError: <urllib3.connection.HTTPConnection object at 0x74b3266c27d0>: Failed to establish a new connection: [Errno 111] Connection refused

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/ubuntu/anaconda3/envs/langflow-env/lib/python3.10/site-packages/requests/adapters.py", line 667, in send
    resp = conn.urlopen(
  File "/home/ubuntu/.local/lib/python3.10/site-packages/urllib3/connectionpool.py", line 847, in urlopen
    retries = retries.increment(
  File "/home/ubuntu/.local/lib/python3.10/site-packages/urllib3/util/retry.py", line 515, in increment
    raise MaxRetryError(_pool, url, reason) from reason  # type: ignore[arg-type]
urllib3.exceptions.MaxRetryError: HTTPConnectionPool(host='localhost', port=8080): Max retries exceeded with url: / (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x74b3266c27d0>: Failed to establish a new connection: [Errno 111] Connection refused'))

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/ubuntu/anaconda3/envs/langflow-env/lib/python3.10/site-packages/langflow/graph/vertex/base.py", line 694, in _build_results
    result = await initialize.loading.get_instance_results(
  File "/home/ubuntu/anaconda3/envs/langflow-env/lib/python3.10/site-packages/langflow/interface/initialize/loading.py", line 64, in get_instance_results
    return await build_component(params=custom_params, custom_component=custom_component)
  File "/home/ubuntu/anaconda3/envs/langflow-env/lib/python3.10/site-packages/langflow/interface/initialize/loading.py", line 151, in build_component
    build_results, artifacts = await custom_component.build_results()
  File "/home/ubuntu/anaconda3/envs/langflow-env/lib/python3.10/site-packages/langflow/custom/custom_component/component.py", line 617, in build_results
    return await self._build_with_tracing()
  File "/home/ubuntu/anaconda3/envs/langflow-env/lib/python3.10/site-packages/langflow/custom/custom_component/component.py", line 605, in _build_with_tracing
    _results, _artifacts = await self._build_results()
  File "/home/ubuntu/anaconda3/envs/langflow-env/lib/python3.10/site-packages/langflow/custom/custom_component/component.py", line 640, in _build_results
    result = method()
  File "/home/ubuntu/anaconda3/envs/langflow-env/lib/python3.10/site-packages/langflow/base/vectorstores/model.py", line 132, in build_base_retriever
    vector_store = self.build_vector_store()
  File "/home/ubuntu/anaconda3/envs/langflow-env/lib/python3.10/site-packages/langflow/base/vectorstores/model.py", line 25, in check_cached
    result = f(self, *args, **kwargs)
  File "<string>", line 139, in build_vector_store
  File "<string>", line 170, in _add_documents_to_vector_store
  File "/home/ubuntu/anaconda3/envs/langflow-env/lib/python3.10/site-packages/langchain_core/vectorstores/base.py", line 282, in add_documents
    return self.add_texts(texts, metadatas, **kwargs)
  File "/home/ubuntu/anaconda3/envs/langflow-env/lib/python3.10/site-packages/langchain_chroma/vectorstores.py", line 508, in add_texts
    embeddings = self._embedding_function.embed_documents(texts)
  File "/home/ubuntu/anaconda3/envs/langflow-env/lib/python3.10/site-packages/langchain_community/embeddings/huggingface.py", line 446, in embed_documents
    response = requests.post(
  File "/home/ubuntu/anaconda3/envs/langflow-env/lib/python3.10/site-packages/requests/api.py", line 115, in post
    return request("post", url, data=data, json=json, **kwargs)
  File "/home/ubuntu/anaconda3/envs/langflow-env/lib/python3.10/site-packages/requests/api.py", line 59, in request
    return session.request(method=method, url=url, **kwargs)
  File "/home/ubuntu/anaconda3/envs/langflow-env/lib/python3.10/site-packages/requests/sessions.py", line 589, in request
    resp = self.send(prep, **send_kwargs)
  File "/home/ubuntu/anaconda3/envs/langflow-env/lib/python3.10/site-packages/requests/sessions.py", line 703, in send
    r = adapter.send(request, **kwargs)
  File "/home/ubuntu/anaconda3/envs/langflow-env/lib/python3.10/site-packages/requests/adapters.py", line 700, in send
    raise ConnectionError(e, request=request)
requests.exceptions.ConnectionError: HTTPConnectionPool(host='localhost', port=8080): Max retries exceeded with url: / (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x74b3266c27d0>: Failed to establish a new connection: [Errno 111] Connection refused'))

Expected behavior
I would expect the vectorstores to be successfully created for both Astra DB and Chroma DB.
Who can help?
No response
Operating System
Ubuntu 22.04
Langflow Version
1.0.18
Python Version
3.10
Screenshot
No response
Flow File
No response

Thank you for your message. We were experiencing some issues with PyTorch dependencies when working with Hugging Face local embeddings. To resolve this, we have implemented support using Hugging Face’s text embeddings inference. This approach is straightforward to integrate into production environments. For optimal performance, please refer to this guide on running Hugging Face Embeddings locally on CPU.
This update reflects an enhancement in how we interact with Hugging Face embeddings, offering a more efficient and streamlined approach compared to prior implementations.
Additionally, we addressed a similar issue in PR #3758  and Issue #3595

Hi @oschan77  ,
In addition to the Hugging Face support I mentioned earlier, I would also recommend exploring the AstraVectorize component, which supports NVIDIA embeddings as well as several other providers. You can find more details here:

AstraVectorize Component Overview
Embedding Generation with Astra DB Serverless

The AstraVectorize component provides a flexible and scalable solution for embedding generation, leveraging the power of NVIDIA embeddings and other integrations. This can be a great alternative for your Langflow deployments, especially if you are looking for enhanced performance and support for various embedding providers.
Feel free to explore these resources and see if they fit your needs. If you have any more questions or need further assistance, just let me know!

Hi @edwinjosechittilappilly ,
Thank you for your responses. I'd like to confirm whether my Langflow design is functional and can be used in the future. It seems the main issue stems from the current lack of support for Huggingface Embeddings in Langflow.
For my specific use case, Huggingface models and embeddings aren't essential. Given this context, is there a straightforward method to implement RAG using Langflow? Please note that I don't have access to OpenAI API keys.
As an alternative, I'm considering using Ollama models and embeddings. Are these well-supported in the current version of Langflow? I appreciate your guidance on these matters.

Yes we do Support Ollama model and  Embeddings components.
Also feel free to explore AstraVectorize for embeddings if you are using AstraDB as Vector Database.
Hope this helps.

Hi @edwinjosechittilappilly
Should I use AstraVectorize for embeddings if I use AstraDB as the Vector Database, even though I'm using the Ollama model? Or do you mean that both options are feasible? Thanks.

Both are feasible.

Currently Closing this issue. Feel free to reopen if you face any further issues.

I am facing this issue and still cant find a clear solution to this

Hi @edwinjosechittilappilly I am facing this issue and still cant find a clear solution to this. I am using huggingface embeddings, and the chunking is fine, but the problem is when the vector_store is created. It gives this error: Error building Component Chroma DB: HTTPConnectionPool(host='localhost', port=8080): Max retries exceeded with url: / (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x000002C6A7FF6A80>: Failed to establish a new connection: [WinError 10061] No connection could be made because the target machine actively refused it'))

Facing same issue

@umais2005 and @kavinkumarbaskar1, if you are using local models, please ensure that you are using the updated component of the Huggingface embeddings and that the Huggingface Text embeddings Inference https://huggingface.co/docs/text-embeddings-inference/en/local_cpu is running locally.
You can also replace the local host URL with the serverless API from Huggingface and use it with the HF token.
If you encounter any further issues, please reopen this issue.

Hey, I fixed this issue for chromaDB.  Here are the commands to run in terminal pip install chromadb chroma run --host localhost --port 8080 --path ./my_chroma_data
@umais2005  Yeah, it is working with chromadb, but AstraDB is not working. Anyway, thanks for the reply it really helped ☺.


Android: search should handle no stories found

Just change "loading..." to "No stories found for 'pizza'."

Also, once I hit a "null" bug, I can't continue to search.

Actually, it's not a null stories bug at all. It's searching for anything with a space in it.

Hmm, looks like our HTTP lib isn't escaping out queries quite right.  Let me forcibly encode these and see if it helps.

Also, once I hit a "null" bug, I can't continue to search.

 Can you give detailed steps to reproduce this?

Fixed the issue with special chars.
What should the exact wording of the custom zero-stories message be?  Are there any other circumstances in the app where a custom zero-stories message should be used?

Nah, don't worry about the custom message. No stories works just fine. Thanks for fixing the space bug! I'm going to release it as 7.0.1 immediately so I can blog it.

(immediately as in as soon as I get the PR for the fix).

Fixed in #869


Saw some code - removed it to make it more secure!

:-1 as removing code is doing work. Please don’t accept this pr


Merge pull request #2 from dotnet/main

[pull] main from dotnet:main
Summary
Describe your changes here.
Fixes #Issue_Number (if available)

Ignore this, it wasn't meant to be opened.


Docker compose for everything except webapp

To work on the result pages you have to:

You have to make sure the webservice and webapp have the public key and private key respectivly for trusted job submissions.
Then you have bring up the services:

bartender webservice, with haddock3 cli installed
bartender database
haddock3 webapp
haddock3 webapp database

Create tables in the databases with their respective migration scripts.
Submit haddock3 job and wait for it to complete. So you have result data to work with
Then you are ready to start working on the results pages.

It would be nice if step 1..3 could be done in a docker compose environment
It would also be nice if any create users and completed jobs would survive when docker compose is shutdown and back up.

Step 4 can be replaced by uploading a run tarball or linking a job (bartender link).


Add Katakana codepage 1

Here's the Katakana code page (codepage 1). This was made by Epson; lines 3-6 are similar to Shift-JIS but the rest is original.
    katakana:
        - "▁▂▃▄▅▆▇█▏▎▍▌▋▊▉┼"
        - "┴┬┤├¯─│▕┌┐└┘╭╮╰╯"
        - " ｡｢｣､･ｦｧｨｩｪｫｬｭｮｯ"
        - "ｰｱｲｳｴｵｶｷｸｹｺｻｼｽｾｿ"
        - "ﾀﾁﾂﾃﾄﾅﾆﾇﾈﾉﾊﾋﾌﾍﾎﾏ"
        - "ﾐﾑﾒﾓﾔﾕﾖﾗﾘﾙﾚﾛﾜﾝﾞﾟ"
        - "═╞╪╡◢◣◥◤♠♥♦♣●○╱╲"
        - "╳円年月日時分秒〒市区町村人▓\u00A0"

I've done a bit of digging and this charset seems to have originally come from NEC's PC-8000 computer from 1979.
https://en.wikipedia.org/wiki/PC-8000_series
The last 8 chars appear to have been introduced in the Fujitsu FM-7 circa 1982.
https://en.wikipedia.org/wiki/FM-7
https://twitter.com/kumokosi/status/1459688336533057536
So it doesn't seem to be an Epson-specific invention. You see these half-width katakana forms a lot in legacy mainframe banking systems in Japan for example, so I imagine encoding is probably widely in-use.


Add test cases for parity with manual sanity test

Current sanity test is a manual process which contains a few steps. To reduce this effort, we want to write test cases to automate these. It involves the following sub issues:

https://github.com/opensearch-project/opensearch-dashboards-functional-test/issues/13
https://github.com/opensearch-project/opensearch-dashboards-functional-test/issues/12
https://github.com/opensearch-project/opensearch-dashboards-functional-test/issues/11
https://github.com/opensearch-project/opensearch-dashboards-functional-test/issues/10

finished


Add support for enums and nested classes

@miloszpp please take a look :)

Sorry but I'm no longer up to date with this code. @cchantep ?

@miloszpp if there's no current maintainer then I think we could consider take ownership of the project

@cchantep please take a look at the fixes, some open questions still remain

@cchantep approve? ;)

@cchantep fixes pushed as 4th round of fixes commit

@cchantep approve&merge this one as well? ;)

@cchantep @miloszpp long time no see, can we merge this one?


[Bug]: Section Scheme "class is invalid" for valid classes

Please confirm that you have:

[x] Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
[x] Reproduced the issue in the latest CLI version.

In which of these areas are you experiencing a problem?
Theme
Expected behavior
Should accept any valid class
Actual behavior
The Shopify CLI rejects the section file when I include a class with certain special characters like [ or ] and likely others with the error message "Invalid schema: class is invalid". In this case I'm using the class tw-z-[110] because I'm using Tailwind CSS which uses these and other special characters for classes. Although this isn't super common outside of Tailwind, classes containing these special characters are valid and shouldn't be rejected.
Verbose output
╭─ error ─────────────────────────────────────────────────────────────────────╮
│                                                                             │
│  Failed to upload file "sections/nav.liquid" to remote theme.               │
│                                                                             │
│                                                                             │
│                                                                             │
│  - Invalid schema: class is invalid                                         │
│                                                                             │
╰─────────────────────────────────────────────────────────────────────────────╯

Reproduction steps

Have the Shopify CLI running in dev mode
Create a section schema that has the "class" field and enter a class containing [ or ] and save

Operating System
Ubuntu 20.04.6 LTS on WLS 2 on Windows 11
Shopify CLI version (check your project's package.json if you're not sure)
3.69.4
Shell
No response
Node version (run node -v if you're not sure)
No response
What language and version are you using in your application?
No response

@lucyxiang that makes sense but then where should this be reported to? I don't know where else would be appropriate to report it

Hi @JasonHassold, this is a duplicate of https://github.com/Shopify/cli/issues/2003 and https://github.com/Shopify/cli/issues/3184.
We know about this internally but do not have a solution at the moment. Please see this comment. I will be closing the issue as it is not relevant to the Shopify CLI


Play back: Ability to show the step's bubble (with description & progress bar) above the line

Often the step's bubble looks intrusive, cutting in between the code and making it more difficult to follow.
Especially at the beginning of functions, types, blocks... it could help to show the step's bubble (with the description & progress bar) before the related code.
Please add that as a per-step bool option. If set to show the bubble above the source line, then please move the little triangle pointer/arrow from the top left of the progress bar to its bottom left.
Also, consider a configurable default value of this, a toggle button in the CODEBAR tree view section, and optionally in the status bar. And even a toggle in the step's bubble/progress bar itself.

It often makes difficult to read the code when those steps are in the middle.


[Docs]Readme Enhancement

Current State:
A little improvement in Readme markdown
Desired State:
In Readme markdown, there is one link that is not hyperlinked it will be great if that link got hyperlinked and some more improvement in readme markdown
Contributor Resources

Meshery documentation site
Meshery documentation source
Instructions for contributing to documentation

@warunicorn19
plz assign this issue to me


Make CommentForest iterable

I'm wondering if it would be a good idea to add an __iter__ method to CommentForest. This would probably deprecate the list method in favor of the Python built-in function of the same name, and in fact it could (if I'm not mistaken) work about the same as that method, except that it would yield comments as they're popped from the queue instead of returning a whole list.

The reason for the list method is that Comment forests are already iterable, but they are not an iterator. So you can do:
for top_level_comment in submission.comments:
print(top_level_comment)
You cannot, however, do next(submission.comments) just like you cannot do that with a list (next([1, 2])). But because it's list-like you can get a specific index submission.comments[0]. Defining __getitem__ is what makes it iterable, in this case: https://github.com/praw-dev/praw/blob/8612b12284f20693aedcfd86f9a8cf2550e8f27e/praw/models/comment_forest.py#L32
More information on iterators at: https://www.python.org/dev/peps/pep-0234/
Specifically:

An object can be iterated over with "for" if it implements __iter__() or __getitem__().


Reorganize container creation, add helper and improve logging

Here are various improvements to debug the CI. Please only approve but do not merge because docker hub needs to be re-configured before doing the merge to properly rebuild the container images.

Coverage decreased (-5.9%) to 62.908% when pulling b487bf5272985bb605d0d28d173ea85eefcf0619 on tyll:container_spec into ad9e212a9c956e084cf70c3ac3574f69703ed845 on nmstate:master.

For the first commit, the automation/docker_*.sh scripts have been deleted instead of moved.

Not sure what you mean. They are shown as deleted and also git does not track whether a file was moved or deleted but decides this just on the file contents AFAIK.

Reviewed "containers: Unify container names".
I still do not understand why two files appear as deleted here (there is no counterpart file that was added instead).

The files already exist in the the target directory for building the container images that are defined there.

Updated and rebased


Remove format and parse methods from Java

Remove format and parse methods
Remove path templates
Remove VALIDATION setting from resource name treatment

Current coverage is 83.30% (diff: 61.53%)

Merging #820 into master will decrease coverage by <.01%

@@             master       #820   diff @@
==========================================
  Files           315        315
  Lines         12024      11981    -43
  Methods           0          0
  Messages          0          0
  Branches       1581       1576     -5
==========================================
- Hits          10018       9981    -37
+ Misses         1577       1576     -1
+ Partials        429        424     -5

Powered by Codecov. Last update 1640179...6fb961e


Do not fail on clean when no .k8s-cluster found

This change is

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


The caret character is not read by rancher-compose

Rancher Version:
v1.1.2
Docker Version:
1.12.1
OS and where are the hosts located? (cloud, bare metal, etc):
Ubuntu 14.04.4 LTS Virtual box
Setup Details: (single node rancher vs. HA rancher, internal DB vs. external DB)
Single node rancher
Environment Type: (Cattle/Kubernetes/Swarm/Mesos)
Cattle
Rancher Compose Version
v0.8.6
Steps to Reproduce:

Setup rancher and rancher agent
Add the following config to default value for logstash filter question in rancher-compose.yml
Logstash rancher:

   label: "Logstash filters"
       type: "multiline"
       required: true
       default: |
          mutate {
            gsub => [
              "extra_tags","^\[","",
              "extra_tags","\]$",""]

            add_tag => "GSub"
          }

Try to bring up the container with "rancher-compose up" using CLI
Results:
It throws the following error:
FATA[0000] Failed to read project: Invalid interpolation format for "questions" option in service ".catalog"
ERRO[0000] Failed to open project dev-logging: Invalid interpolation format for "questions" option in service ".catalog":
Expected:
To be parsed correctly and put in logstash.
Interesting sidenote: This filter config works perfectly well if you copy and paste it into the rancher GUI. But you cannot give it as default value for the question and then do a "rancher-compose up" from CLI.
Also, this issue goes away if you remove the caret(^) from the filter. I am not exactly sure why this is occuring. I have tested the YAML for lint and it shows me that is a perfectly valid yaml.

rancher-compose v0.12.5 still fails to parse it.

With the release of Rancher 2.0, development on v1.6 is only limited to critical bug fixes and security patches.


Developing Extensions - How to get component to display in viewer

I'm trying to develop my own extension with the viewer but I'm having a hard time grasping the basic framework and steps needed to accomplish this.
Right now I created the button in the toolbar and the corresponding action for it.
What I don't understand is how to get my new component I created to display in the vieweronce I click on the toolbar button.
Here's my code so far
import React from 'react';
import SeriesMarker from './SeriesMarker';

export default {
  id: 'hello world!',

  getViewportModule() {
    return <SeriesMarker />;
  },

  getToolbarModule() {
    return {
      definitions: [
        {
          id: 'series-marker',
          label: '🎉 Marker 🎉',
          icon: 'exclamation-triangle',
          type: 'command',
          commandName: 'exampleActionDef',
        },
      ],
      defaultContext: 'VIEWER',
    };
  },
  getCommandsModule({ servicesManager }) {
    return commandsModule({ servicesManager });
  },
};

const commandsModule = ({ servicesManager }) => {
  const actions = {
    exampleAction: ({ viewports, param1 }) => {
      console.log(`There are ${viewports.length} viewports`);
      console.log(`param1's value is: ${param1}`);
    },
  };

  const definitions = {
    exampleActionDef: {
      commandFn: actions.exampleAction,
      storeContexts: ['viewports'],
      options: { param1: 'hello world' },
    },
  };
  return { actions, definitions };
};

There is new extension development video coming up.
Meanwhile look at this page https://docs.ohif.org/development/ohif-cli/#cli-installation


Clean up pipelines associated with old / merged branches

I'm wondering what approach we should take here.
A few possible approaches:

pipelines-as-code has a cleanup policy that simply keeps n number of pipelines. See https://github.com/openshift-pipelines/pipelines-as-code/blob/main/docs/guide.md#pipelineruns-cleanups
the Jenkins webhook proxy in ODS core is intended to listen for pr:deleted and pr:merged events, and if one of those is received, it deletes the related Jenkins pipeline. It also has a list of "protected" branches that will not get deleted even if a "deletion" event is received for them.

I am not sure how complicated we want to make it for ODS pipeline. The main goal of pipeline pruning is - at least in my eyes - twofold: to avoid the UI to become too crowded, and to reduce the number of resources in the K8s cluster. With that in mind, keeping n number of pipelines could be a viable option until we need something better. But maybe there is a smart solution that isn't complicated?
Ideas @gerardcl @kuebler @henninggross @renedupont @stitakis?

How difficult do you think would it be to mirror the behaviour of the jenkins webook proxy? For me, it makes sense how the jenkins webhook proxy handles it.
IMO just keeping n number does not take into account how fine granular a team creates branches. Team A might create 10 branches a day while Team B only 1 per week. So the preferred n for Team A and B might differ. I know that might be only a very theoretically case, but I know you like nitpicking 😄.

IMHO I would for now just try to keep the list automatically cleaned up and see if it is really required to have specific actions per events like in the jenkins webhook. At the end the goal is to have the list to not be inifinite and basically one is interested on the latest ones and current on active mode...(and if required to recover an old  one it is also possible anyhow) I don't see the need on only deleting in case of events indeed (might even not always work as per experiences).
The trick is to me though on deciding what would be a nice default value (as per @renedupont nitpicking escenario :) )

I have a new idea how to approach this. Let's see if you like it :)
The main idea is to keep n branches per environment. All branches mapped to one environment end up in one "bucket". All remaining branches (not mapped to an env) end up in one bucket as well. Then we keep n branches per bucket.
Additionally I would offer a second configuration parameter, a "removal delay". For example, this could be set to 48 hours, and that would have the effect that no branch is cleaned up before 48 hours pass.
Both knobs work well together, should be relative simple to implement and do not require to listen for the webhook events like the Jenkins webhook cleanup. I think it also provides what one wants: access to recent pipeline runs, plus access to the n last pipeline runs that deployed into an env (e.g. last 5 deployments into prod).
@renedupont it addresses your "nitpick" somewhat I believe: since n is not global, many dev branches do not affect pipeline runs that deploy into QA/PROD. It doesn't fully address the different amount of, say, feature branches. But maybe the "removal delay" is good enough for that problem?
Thoughts? :)

Not sure if I understand. How is a branch mapped to an environment? Isn't it often like this:
prod env -> 1 branch (master)
test and/or qa env -> a couple release branches
dev -> dev branch and millions of feature branches
That way only the dev env "bucket" would mainly be of interest. Or do you mean something else regarding environment?

@renedupont The cleanup would actually remove PipelineRun resources.
Example:
prod env -> 1 branch (master)
test and/or qa env -> release/*
dev -> *
Also, let's say we keep only 5 pipeline run, and we have the following situation:

6 pipeline runs deploying into prod
5 pipeline runs across release/* branches. E.g. there might be release/1.0.0 (3 pipeline runs), release/2.0.0 (2 pipeline runs) and release/3.0.0 (4 pipeline runs).
many pipeline runs for different branches all deploying to dev

When cleanup kicks in, we would remove:

the oldest pipeline run into prod (keeping 5 runs overall for PROD)
no pipeline run for release/3.0.0, 1 pipeline run for release/2.0.0, and all pipeline runs, including the pipeline itself, for release/1.0.0 (keeping 5 runs overall for QA)
and similar for dev: keep the 5 latest pipeline runs, and delete the rest. All pipelines which end up with 0 runs after this, get removed, keeping 5 runs overall for DEV.

Does that help?

Also see updates in v1.6 of OpenShift Pipelines: https://docs.openshift.com/container-platform/4.9/cicd/pipelines/op-release-notes.html#new-features-1-6_op-release-notes

One issue I realized with my proposal in the meantime is that it depends on the ods.yaml within a branch. Which means that if you modify the branch mapping in one branch, you automatically trigger cleanup based on that ... which may not be what we want.

I've had some more thoughts on this as it is in the critical path towards resolving #394.
I do not consider my proposal above ideal anymore, as cleanup would depend on state in a branch, which might lead to unwanted side effects, plus the logic wasn't as simple as I'd like it to be.
I have since realized that all pipeline runs target a certain stage, which is either dev, qa or prod. Even branches not mapped to an environment have a stage set (dev). We can use this to simplify the proposal, and just keep n pipeline runs per stage. For this to work, we need to apply a new label to each pipeline run which identifies the stage (e.g. org.opendevstack.pipeline/stage=qa). When cleanup is triggered, we simply remove the oldest pipeline runs per stage until we have only n pipeline runs left.
In addition, I would also keep the "removal delay" described above (so that all pipeline runs are there for at least 48 hours or so).
This strategy should lead to rather aggressive cleanup for the dev stage (which should contain pipeline runs for feature branches and integrated branches) and quite conservative cleanup for qa/prod, which is inline with what I'd like to achieve.
@ManuelFeller @gerardcl You've assigned this issue to yourself. Could you review my proposal? Also - not sure if you intended to implement it. If so, please let me know if you need pointers to get started and when you would be able to get to it. Otherwise I would take this over since I think it is best to solve the issue here before working in #394.

hi @michaelsauter , we did not met yet so we did not check proposals so far.
I see your point and I agree with latest proposal, so far looks good.
Since I will focus on other topics in the short-term feel free to jump to it so we do not block this. Also, feel free to pull me in when you jump into developing this, I am happy to be an extra two eyes 👀

Hi @michaelsauter. I see it pretty similar if we do not want to make things too complex. The approach with "have n runs per environment but keep them at least 48 hours) sounds like a good and not too complex solution. 👍

@gerardcl @ManuelFeller Thanks for the feedback! I am going to assign this to myself now ...


ERROR: The "getBabelLoader" helper has been deprecated as of v2.0. You can use customize-cra plugins in replacement - https://github.com/arackaf/customize-cra#available-plugins

I know about https://github.com/timarney/react-app-rewired/issues/348 .
The code is still broken, I'm still getting an error.
New CRA project.
package.json:
{
  "name": "project1",
  "version": "0.1.0",
  "private": true,
  "dependencies": {
    "react": "^16.8.6",
    "react-dom": "^16.8.6",
    "react-scripts": "3.0.1"
  },
  "scripts": {
    "start": "BROWSER=false react-app-rewired start",
    "build": "react-app-rewired build",
    "test": "react-app-rewired test",
    "eject": "react-scripts eject"
  },
  "eslintConfig": {
    "extends": "react-app"
  },
  "browserslist": {
    "production": [
      ">0.2%",
      "not dead",
      "not op_mini all"
    ],
    "development": [
      "last 1 chrome version",
      "last 1 firefox version",
      "last 1 safari version"
    ]
  },
  "devDependencies": {
    "customize-cra": "^0.2.12",
    "react-app-rewire-eslint": "^0.2.3",
    "react-app-rewired": "^2.1.3"
  }
}

What is the contents of your config-overrides.js file?

config-overrides.js:
const rewireEslint = require('react-app-rewire-eslint')

module.exports = function override(config, env) {
  config = rewireEslint(config, env)

  return config
}

The react-app-rewire-eslint plugin was written for react-app-rewired 1.x using Webpack 3. It has not been updated (nor is it intended to be updated) for Webpack 4. This means it is not compatible with react-app-rewired versions 2.0 and above.
The section you quoted in the heading of this issue actually tells you exactly what you need to do in order to get this functionality. You need to use/import the plugin from customise-cra instead of from the old react-app-rewire-eslint package.
const { override, useEslintRc } = require('customize-cra');
const path = require('path');

module.exports = override(
  useEslintRc(path.resolve(__dirname, '.eslintrc'))
);

Hi @dawnmist, how can I use my react-app-rewired configuration with customize-cra configuration?
Right now I have this configuration in my config-overrides.js file:
module.exports = (config, env) => {   config.optimization.runtimeChunk = false;   config.optimization.splitChunks = {     cacheGroups: {       default: false,     },   };   return config; };
But now I want to use customize-cra as well. How can I do it? Thanks for your help.

I fixed it using the function disableChunk in my config:
const { override, useEslintRc, disableChunk } = require('customize-cra');
const path = require('path');

module.exports = override(
  useEslintRc(path.resolve(__dirname, '../../.eslintrc.json')),
  disableChunk()
);

@jasondiazg In future, you'll get better responses about how to use customize-cra from the team at customize-cra. Customize-cra has been written by another team who kindly stepped in to maintain new rewires for react-app-rewired after the move by CRA to use webpack 4, and as a result the best people to ask about how to use customize-cra is the team who wrote and maintain it. :)
For future reference, if you need to create a custom function for customize-cra that they didn't have an override function for you could wrap it as follows (based on their pre-written overrides):
const myCustomFunc = () => (config) => {
  // do stuff with config...
  return config;
};

module.exports = override(myCustomFunc());


The file you've selected is not currently supported

Connect SDK Sampler -> Connecting to an Samsung 65" , beaming the photo works but when trying to display the test video (Blender Open Movie Project) the TV displays "The file you've selected is not currently supported".
2015-03-12 09:34:17.295 Connect SDK Sampler[1476:431935] writing as default Blender Open Movie Project to the key videoDescription
2015-03-12 09:34:17.295 Connect SDK Sampler[1476:431935] writing as default http://ec2-54-201-108-205.us-west-2.compute.amazonaws.com/samples/media/video.mp4 to the key videoPath
2015-03-12 09:34:17.296 Connect SDK Sampler[1476:431935] writing as default http://ec2-54-201-108-205.us-west-2.compute.amazonaws.com/samples/media/videoIcon.jpg to the key videoThumbPath
2015-03-12 09:34:17.296 Connect SDK Sampler[1476:431935] writing as default video/mp4 to the key videoMimeType
Verbose log:
[DEBUG] Did connect
[DEBUG] Did start background task
[DEBUG] Did open connection on socket 14
[DEBUG] Did open connection on socket 15
[DEBUG] Connection received 636 bytes on socket 13
[DEBUG] Connection received 636 bytes on socket 14
[DEBUG] Connection on socket 14 preflighting request "NOTIFY /smp_27_" with 636 bytes body
[DEBUG] Connection on socket 13 preflighting request "NOTIFY /smp_27_" with 636 bytes body
[DEBUG] Connection on socket 14 processing request "NOTIFY /smp_27_" with 636 bytes body
[DEBUG] Connection on socket 13 processing request "NOTIFY /smp_27_" with 636 bytes body
[DEBUG] Connection received 636 bytes on socket 15
[DEBUG] Connection on socket 15 preflighting request "NOTIFY /smp_27_" with 636 bytes body
[DEBUG] Connection on socket 15 processing request "NOTIFY /smp_27_" with 636 bytes body
[DEBUG] Connection sent 122 bytes on socket 14
[DEBUG] Did close connection on socket 14
[VERBOSE] [<IP_ADDRESS>:49291] <IP_ADDRESS>:57023 200 "NOTIFY /smp_27_" (636 | 122)
[DEBUG] Connection sent 122 bytes on socket 13
[DEBUG] Did close connection on socket 13
[VERBOSE] [<IP_ADDRESS>:49291] <IP_ADDRESS>:57022 200 "NOTIFY /smp_27_" (636 | 122)
[DEBUG] Connection sent 122 bytes on socket 15
[DEBUG] Did close connection on socket 15
[VERBOSE] [<IP_ADDRESS>:49291] <IP_ADDRESS>:57024 200 "NOTIFY /smp_27_" (636 | 122)
[DEBUG] Did open connection on socket 13
[DEBUG] Did open connection on socket 14
[DEBUG] Did open connection on socket 15
[DEBUG] Connection received 773 bytes on socket 13
[DEBUG] Connection on socket 13 preflighting request "NOTIFY /smp_27_" with 773 bytes body
[DEBUG] Connection received 773 bytes on socket 15
[DEBUG] Connection on socket 13 processing request "NOTIFY /smp_27_" with 773 bytes body
[DEBUG] Connection on socket 15 preflighting request "NOTIFY /smp_27_" with 773 bytes body
[DEBUG] Connection on socket 15 processing request "NOTIFY /smp_27_" with 773 bytes body
[DEBUG] Connection received 773 bytes on socket 14
[DEBUG] Connection on socket 14 preflighting request "NOTIFY /smp_27_" with 773 bytes body
[DEBUG] Connection on socket 14 processing request "NOTIFY /smp_27_" with 773 bytes body
[DEBUG] Connection sent 122 bytes on socket 13
[DEBUG] Connection sent 122 bytes on socket 15
[DEBUG] Did close connection on socket 13
[DEBUG] Did close connection on socket 15
[VERBOSE] [<IP_ADDRESS>:49291] <IP_ADDRESS>:57025 200 "NOTIFY /smp_27_" (773 | 122)
[VERBOSE] [<IP_ADDRESS>:49291] <IP_ADDRESS>:57027 200 "NOTIFY /smp_27_" (773 | 122)
[DEBUG] Connection sent 122 bytes on socket 14
[DEBUG] Did close connection on socket 14
[VERBOSE] [<IP_ADDRESS>:49291] <IP_ADDRESS>:57026 200 "NOTIFY /smp_27_" (773 | 122)
[DEBUG] Did disconnect
[DEBUG] Did end background task
Any ideas? Did the mimetype change?

@kentdome, we have the same issue with a couple of our Samsung TVs. It returns no error, but doesn't actually play the video and displays the message. Apparently, different models support different codecs. The mime-type hasn't changed, the video didn't work before either.

Closing now. @kentdome, please comment if you have any ideas.


Redesign Footer for Better Experience

Description
The footer section of the website is not looking good. As a footer, it should stand differently. Also, there is a lot of padding in the footer section. I want to redesign the footer and remove such extra padding in it. If the issue looks good, then please assign it to me for GSSoC'22.
Screenshots
Below is the footer image of the current theme -

Design I would like to implement in the footer -

@Shubham29012001 Go for it!


Actions runs cli

Closes #1479

lakectl actions runs list lakefs://repo1
lakectl actions runs list lakefs://repo1@master
lakectl actions runs show lakefs://repo1 runID1
lakectl cat-hook-output lakefs://repo1 runID1 hookRunID1 (hidden)

Codecov Report

Merging #1506 (c691251) into master (539053d) will decrease coverage by 0.16%.
The diff coverage is 1.38%.

@@            Coverage Diff             @@
##           master    #1506      +/-   ##
==========================================
- Coverage   38.76%   38.59%   -0.17%
==========================================
  Files         167      167
  Lines       13470    13495      +25
==========================================
- Hits         5221     5208      -13
- Misses       7497     7533      +36
- Partials      752      754       +2

Impacted Files
Coverage Δ

api/client.go
4.46% <0.00%> (-0.38%)
:arrow_down:

api/controller.go
32.51% <0.00%> (-0.42%)
:arrow_down:

auth/setup.go
0.00% <0.00%> (ø)

config/config.go
41.21% <ø> (+7.88%)
:arrow_up:

actions/service.go
56.61% <50.00%> (ø)

pyramid/tier_fs.go
56.76% <0.00%> (-5.68%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 539053d...c691251. Read the comment docs.


Azure DevOps code coverage

Code coverage for Azure DevOps

Can this be done without using DotNetCLI task?

Idk, why?

What's the point in having DevOps tell us our code coverage is 33% ?
It's likely not testing any inbound Update handling code from our Integ test suite as it can't see Telegram interactions.
Moreover, we don't have the workforce to improve code coverage anyway...
So I'm considering closing this PR.


Z-Stack 3.0 for CC2530

Please, can you provide instructions for building Z-Stack 3.0 for CC2530?

Available now: https://github.com/Koenkk/Z-Stack-firmware/tree/master/coordinator/Z-Stack_3.0.x/bin can you let me know if it works?

Thank you so much for your incredible work ! It works fine but sometimes I need to restart my CC2530 board in order to made it work. However I have a problem with zigbee green power devices, their didn't appears ... I thought that Zigbee 3.0 is compatible with Zigbee green power.

Yes it is, but some additional things are needed to support this (green power commissioning).

Great reactivity thank you !


Added SingleLineFunctionDeclarationFixer

Partially closes #1976
cc @javiereguiluz, you wrote the coding standard about that, what do you think?

red Travis

OK, i lost why SingleLineFunctionDeclarationFixer would be touching comments :D

Because I missed ; for abstract methods. Don't ask me more, I don't know! :D

Test fixed. :+1:

Should be OK now.

your test cases are invalid,
for ref:
https://3v4l.org/8rSD6

your test cases are invalid,

@SpacePossum Fixed.

Tests are green! Tests are green! Oh yes!!! :green_heart:

Fixing the spacing before the function token is very nice, it is also PSR2. After is indeed a SF rule only.
Would be hard to tweak the FunctionDeclarationFixer to the fixing of the space before the function token and do the arguments inline optionally (i.e. by config)?

IMHO, fixing spaces on function declaration and make it single lined are two very different things, isn't it?

IMHO, fixing spaces on function declaration and make it single lined are two very different things, isn't it?

Make it single lined is fixing spaces isn't it ;)
Don't know what others think, but I think it should be merged into the existing fixer.

Make it single lined is fixing spaces isn't it ;)

I think we can say that for many other fixers. It should not be merged IMHO.
For me this PR and #1979 are ready to merge.
If @keradus want same thing as you, then right, I'll do it. :wink:

About single line whitespaces - big :+1: for incorporate changes into FunctionDeclarationFixer.
About making arguments from multiline to singleline - I'm fine with new fixer doing only that (so not touching other whitespaces , eg in function_____foo(){}) or configuration option.

function_declaration is PSR-2 and this one not. I'm not sure the fixer I proposed should be merged on this one...

ref https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/1980#issuecomment-226112953
most of the fixer is PSR2.
the only non-PSR2 thing is making multiline arguments singleline, but as @SpacePossum said, it should be an option.
We already moved out of direction that fixer is PSR2 or not. Some usage of it may be PSR2, some Symfony, and some completely user specific.

Well.
How I'm supposed to do that on 1.x? Because the preset depends of the namespace of the fixer here.

On 1.x you could put it in @PSR-2 ruleset and leave an option to configure, then we could add configuration for @Symfony ruleset on 2.x line.

any news here ?

any news here ?

@Soullivaneuh ?

ping @Soullivaneuh

any news here ?

Time is my enemy nowadays.
@keradus Should I rename the fixer to FunctionDefinitionFixer as done in #2155 for classes?

we already have function_declaration rule. probably nowadays you need to combine both of them
to get this PR merged, first thing would be to rebase it on master


0.51.0

https://github.com/Hacker0x01/react-datepicker/releases/tag/v0.51.0
Can we get a better explanation of what is in this release?

It's was fixing all changes that didn't got merged into 0.50 because of a bug in the release script. See 0.50 for relevant changes.


fix: browser autocomplete in FluentCombobox

🐛 Bug Report
Currently in FluentCombobox you can define autocomplete behaviour using ComboboxAutocomplete.Both, ComboboxAutocomplete.Inline or ComboboxAutocomplete.List. However browser autocomplete cannot be customised like you can with a FluentTextField.
Normally autocomplete doesn't show up for comboboxes, however when you bind the FluentCombobox to a property of an object (and maybe in other situations) the browser autocomplete kicks in.
💻 Repro or Code Sample
@page "/"

<PageTitle>Home</PageTitle>

<EditForm Model=DataObject OnSubmit=Submit FormName="Form">
    <FluentCombobox Id="combobox"
                    Label="Value:"
                    Items=@Content
                    @bind-Value=DataObject.Value
                    Autocomplete=ComboboxAutocomplete.Both
                    TOption=string
                    Required=true />
    <FluentButton Type=ButtonType.Submit>Submit</FluentButton>
</EditForm>

@code{
    record Data
    {
        public string? Value { get; set; }
    }

    [SupplyParameterFromForm]
    private Data DataObject { get; set; } = new();

    public List<string> Content { get; set; } = ["Value 1", "Value 2", "Value 3"];

    private void Submit() { }
}

🤔 Expected Behavior
Either no autocomplete, or the option to explicitly set the autocomplete field, like on a FluentTextField.
😯 Current Behavior

This is the generated input element of the combobox. As you can see it has no autocomplete field, so the browser decides.
<input aria-haspopup="listbox" class="selected-value" part="selected-value" role="combobox" type="text" aria-controls="" aria-disabled="false" aria-expanded="false" aria-label="Value:">

💁 Possible Solution
Add autocomplete="off" to the generated <input> or allow it to be set using a new property on FluentCombobox.
🔦 Context

🌍 Your Environment

OS & Device: Windows 11
Browser: Google Chrome
.NET and Fluent UI Blazor library Version: 8.0.1 and 4.4.2-preview.24058.32

Will be fixed with PR mentioned above.


Port logging capabilities documentation

Needs to be moved from the original plugin README
Might consider moving the docs to asciidoc as is done for gradlex-org/build-parameters

Closing this as the porting has been done in #92, which will be merged when we release(d)


Mast: Watch shoppingwithdeals.com

Mast requests the watch of the watch_keyword shoppingwithdeals\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

shoppingwithdeals\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Daniil in Charcoal HQ


Minor text and image changes to Alert page

Updated copy and better quality images

Tugboat has finished building the preview for this pull request!
Link:

https://pr156-iwryvtnutz2wfx9qzjzmfoz5lro5pmtq.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/60d61d12462cdfa5098e7a34

Tugboat has finished building the preview for this pull request!
Link:

https://pr156-iwryvtnutz2wfx9qzjzmfoz5lro5pmtq.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/60d61d12462cdfa5098e7a34

Tugboat has finished building the preview for this pull request!
Link:

https://pr156-iwryvtnutz2wfx9qzjzmfoz5lro5pmtq.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/60d61d12462cdfa5098e7a34

Tugboat has finished building the preview for this pull request!
Link:

https://pr156-iwryvtnutz2wfx9qzjzmfoz5lro5pmtq.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/60d61d12462cdfa5098e7a34

Looks great @coreyvickery


Add auth/failure route

Context
In very edge cases, DSI will send an auth/failure request to our app with a message.
We need to handle this gracefully so we redirect the user to the sign in page, sign him our if they are signed in and display a message.
We also send a request to Sentry.
Changes proposed in this pull request
New route and sessions controller method
Guidance to review
Go to /auth/failure
Screenshots
https://github.com/DFE-Digital/itt-mentor-services/assets/11318084/aab876cd-eeb5-47fa-b11e-6010d87bd9ae

 Add auth/failure route for DSI

Based on this design history, https://github.com/DFE-Digital/bat-design-history/pull/1165, I think we might want to redirect to an error page. Maybe this page: app/images/claim-funding-for-mentors/service-error-pages/problem-with-the-service.png? What do you think?


Provide support for streaming data to external files

As mentioned in #638, the documentation alludes to the fact that it should be possible to stream data to external files (see here):

An ASDF writer may stream a table to disk, when the size of the table is not known at the outset. Using exploded form simplifies this, since a standalone file containing a single table can be iteratively appended to without worrying about any blocks that may follow it.

However, this is not possible with the current API. There shouldn't be any changes necessary in the standard itself or in the file format, but we ought to provide an API for this. Also, from a reading perspective, this shouldn't be any different from the existing case of "exploded" arrays.

I have been trying to work my way around this, however no success so far. My use case, I have a large gzipped csv that I would like to split into multiple leafs in an asdf tree. My idea was to use a single stream, write to file, then open a new Stream, etc..
import smart_open
import asdf
import numpy as np

with smart_open.open('output/test_5.asdf', 'wb') as fout:
    asdf_file = asdf.AsdfFile()

    asdf_file.tree[idx] = asdf.Stream([7], dtype=np.float64)
    asdf_file.write_to(fout)
    idx = 0
    while True:
        if idx > 5:
            break

        data = np.random.random((7,1000))
        fout.write(data)

        idx += 1
        asdf_file.tree[idx] = asdf.Stream([7], dtype=np.float64)
        asdf_file.write_to(fout)
        print(idx)

But it seems to keep all data, but overwrite the branch label.
with asdf.open('output/test_5.asdf') as af:
    print(af.tree)
    print(af.tree[6].shape)

which returns
{'asdf_library': {'author': 'Space Telescope Science Institute', 'homepage': 'http://github.com/spacetelescope/asdf', 'name': 'asdf', 'version': '2.3.3'}, 'history': {'extensions': [<asdf.tags.core.ExtensionMetadata object at 0x7f94b757c9b0>]}, 6: <array (unloaded) shape: ['*', 7] dtype: float64>}

(6093, 7)

Btw, I am using smart_open because the goal is to be using this with data from AWS S3

I'll see if I can find time early next week to take a look at this. Thanks.

@perrygreenfield Thanks for your fast reply, any form of streamed writing into splits would be of great help!

I think I am missing some background on this issue. If you could clarify what you are trying to do in a little more detail it would help me check into this. So when you say you want to save parts of the csv file into different ASDF leaves do you want to do this simultaneously (in parallel) or sequentially? If in parallel do you know the size of each leaf before you start? It might be good to understand the constraints (e.g., the csv file is too large to fit uncompressed in memory) that requires the multiple streams.

A gzipped larger than memory csv (uncompressed it definitely is)
because it is gzipped I can not write in parallel, but must write sequential

What I do not really understand is, when opening an asdf file all leaves are lazy loaded, which invites for larger-than-memory files. However, beyond the single stream there seems to be no way of writing a larger-than-memory file, which leaves the tree promise out of reach for many use cases?


Access to clean PNG through api URL

Is it possible to access the clean PNG picture through a URL for a specific event?
By the way, it seems that the snapshot is done using the sub stream, the one used for detection, and not the main stream, the one used for recording. So the quality of the snapshot isn't that good. Hopefully, it can be better with the PNG picture.

You can use the /clips/ directory API to get it.
And yes it uses the detect stream, there are many reasons why using the main stream is difficult and won't work as well for event snapshots. In the next version there will be an api to pull a snapshot from the recordings

Okay, could you please guide me through on which url to use exactly to get the PNG picture?
Mathieu

From: Nicolas Mowen @.>
Sent: Saturday, May 27, 2023 1:37:24 PM
To: blakeblackshear/frigate-hass-addons @.>
Cc: flouck @.>; Author @.>
Subject: Re: [blakeblackshear/frigate-hass-addons] Access to clean PNG through api URL (Issue #120)
You can use the /clips/ directory API to get it.
And yes it uses the detect stream, there are many reasons why using the main stream is difficult and won't work as well for event snapshots. In the next version there will be an api to pull a snapshot from the recordings
—
Reply to this email directly, view it on GitHubhttps://github.com/blakeblackshear/frigate-hass-addons/issues/120#issuecomment-1565364814, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOK7FD3KOYDT7NQ76PBYNY3XIHRPJANCNFSM6AAAAAAYRBRGX4.
You are receiving this because you authored the thread.Message ID: @.***>

It is http://frigate_ip:5000/clips/{camera_name}-{event_id}-clean.png

What about for external url? I use something like that to get the snapshot.
https://xxx.duckdns.org:8123/api/frigate/notifications/{event-id}/snapshot.jpg

De : Nicolas Mowen @.>
Envoyé : samedi 27 mai 2023, 13:56
À : blakeblackshear/frigate-hass-addons @.>
Cc : flouck @.>; Author @.>
Objet : Re: [blakeblackshear/frigate-hass-addons] Access to clean PNG through api URL (Issue #120)
It is http://frigate_ip:5000/clips/{camera_name}-{event_id}-clean.png
—
Reply to this email directly, view it on GitHubhttps://github.com/blakeblackshear/frigate-hass-addons/issues/120#issuecomment-1565370802, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOK7FD5GNTVRQ3B5MGZIDIDXIHTWJANCNFSM6AAAAAAYRBRGX4.
You are receiving this because you authored the thread.Message ID: @.***>

That is the home assistant api with the frigate integration, I don't think it exposes the clip url

Did you find a proper way to get png like this way:
GET /api/<camera_name>/latest.jpg[?h=300]
Sadly my other device can use only png :(


[TB] Review Contribution Guide for both project repos

Problem/Concern
Review content of CONTRIBUTE.md
Review inline comments for missing data.

link to problem content

Proposed Solution
Update any/all missing data / comtent.

Need to identify communication channels.

This is complete.


fix: duplicate callbacks in vite-node HMR

When using vite-node HMR, the callbacks registered with:
if (import.meta.hot) {
  import.meta.hot.on("vite:beforeFullReload", () => {
    console.log("full reload");
    server.close();
  });
}

are duplicated/accumulated on each reload (logs below after 4 saves):
> vite-node --watch src/index.ts

listening on port 4000
full reload
listening on port 4000
full reload
full reload
listening on port 4000
full reload
full reload
full reload
listening on port 4000
full reload
full reload
full reload
full reload
listening on port 4000

This change ensures that if for the same event, two callbacks are identical, the old one is replaced with the new one.
We can't use reference identity check unfortunately as the identity of the callback change between reloads, hence the usage of .toString().

Maybe it's better to remove callbacks when a module is invalidated? This doesn't seem very stable.

Sure, whatever works best. I don't have much knowledge about the internals of vite/vite-node. How should I do that?

I don't have much knowledge about the internals of vite/vite-node.

So do I. I assume it should be possible to detect what module added a listener and remove it if it was invalidated.

So do I. I assume it should be possible to detect what module added a listener and remove it if it was invalidated.

I think we can also just safely clear all "vite:onBeforeReload" listeners, because it assumes that everything will be reloaded


How do we do this on windows

I am using windows 10 but there aren't any instructions for this. Please help me as i am an amateur in programming

You can emulate a linux terminal using cygwin on windows
Through cygwin you can install all the tools you need to compile your os
Give it a try https://www.cygwin.com/

You can use WSL (Windows Subsystem for Linux) to run any linux commands you need. Windows files will be available in the directory /mnt/driveletter You can use the cat command in the READMEs with small modification. osimage should have the file extension .vfd You can then open this VFD with Virtualbox and boot the system

I know this is late, but I use WSL to run NASM and other compilers, then I have qemu installed on the windows side of things.

I would just run a Ubuntu image in qemu for the full experience.

You can use mingw. with a few minor adjustments it works

I highly recommend using WSL2. It has been a life saver.


New version: QuantEcon v1.1.1

Registering package: QuantEcon
Repository: https://github.com/QuantEcon/QuantEcon.jl
Created by: @sglyon
Git reference: register/QuantEcon/v1.1.1
Version: v1.1.1
Commit: ef6aa1708e176935de380fdb11edb08562ec55f0
Reviewed by: @sglyon
Reference: https://github.com/QuantEcon/QuantEcon.jl/commit/ef6aa1708e176935de380fdb11edb08562ec55f0#commitcomment-33563540

please do not merge -- version number is incorrect


Pushing origin of the customer

Hello
I easily managed to use this module inside Magento 2 to push orders information to Google Analytics.
However there is still a thing I don't know how to do: how to push the customer original location (the website he cames from).
I know how to get this information, but not how to use this module to push it to Google?
Regards

If you meant the referral website, there is the Document Referrer parameter.

As per documentation, you set it like this before sending the hit:
$analytics->setDocumentReferrer('http://example.com/referrer.html');

Thanks you. It seems to works perfectly.


configurable 'icon' displayed for hotSpots

It would be very useful for me if I could specify an (optional, of course) icon for the hotspots.
For my use case, I'm using this for a real estate website, and it would be nice to have something beyond the 'up arrow' to go from space to space.  I could imagine, for instance, wanting a 'down arrow' to indicate going to a lower level in the property.  Or, I might want use something other than an 'up arrow' in general, such as one of those little 360 ovals that you see these days.  I can't even imagine all of the possibilities, of course.
I can see that they are currently svg files that are compiled in the css file, and if it makes things considerably easier I'd be happy to compile my own svg files in, but it seems a much more generic way would be to have the images defined in the config.json file and then each hotspot could specify which image/icon is to be displayed for the hotspot.
Any interest in something like this?

It's something I've thought about. I would need to change the hot spot positioning logic first, to not use hard-coded sizes.

Hey Matt, I was interested in this feature too. I'm currently running pannellum-2.2.1 on my test server, so far I gotta save I <3 it

Matthew, such great work on this.... here's another vote for custom hotspot icons!

Assuming the size of the icon is the same, could it work by adding a option to overwrite the default .class to a different one and then having each image be in a different .svg file with only that icon?
Just until you get around to un-hardcoding the sizes.

The icons could be centered using CSS by their own center (not upper left corner, e.g. using CSS transform).
Then the icon can have any width/height (and shape) and still be at the right place.

I added this in 81c506e842c3540530e08aaccb09f67a67dd4ab3. There's now a cssClass parameter for hot spots that specifies the CSS class that should be used for the hot spot. There's also a createTooltipFunc that's used for creating the tooltip and a createTooltipArgs that specifies arguments that should be passed to the tooltip function, in addition to the hot spot div, which is the first argument.
Here's a very rough example:
<!DOCTYPE HTML>

    <meta charset="utf-8">
    <title>Test Example</title>
    <link rel="stylesheet" href="../src/css/pannellum.css"/>


Enables strictNullChecks to breadcrumbs.ts, outlineModel.ts, breadcrumbbsModel.ts

This PR enables strictNullChecks to breadcrumbs.ts, outlineModel.ts and breadcrumbsModel.ts as per https://github.com/Microsoft/vscode/issues/60565
Most of it consisted of straightforward | undefined or if (...) additions. The one tricky bit is that subclasses of TreeElement were being clever in restricting their allowed parent classes, but that could technically be incorrect (e.g. if we later added code to reparent TreeElement subtrees).

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: rudi-c sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


tailscale: fix tailscale ssh

Closes #310950
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

We should revert the combination PR rather than shipping an un-reviewed PR as a patch - We clearly don't have enough testing infrastructure in place here, and repeatedly breaking folks networking and security boundary software is painfully invasive.

(Reviewed the patch and there's technically also a slight regression).

(Reviewed the patch and there's technically also a slight regression).

That was easy to fix by using the same method the tailscaled uses to detect if it should start the cli https://github.com/tailscale/tailscale/pull/5193/files

We should revert the combination PR rather than shipping an un-reviewed PR as a patch - We clearly don't have enough testing infrastructure in place here, and repeatedly breaking folks networking and security boundary software is painfully invasive.

"We" as in tailscale. I took this from their upstream documentation https://tailscale.com/kb/1207/small-tailscale and since there were no hints at all, I assumed this is straightforward and easy to use to reduce unnecessary binary size.
I think we understand the problem at hand pretty well and I have looked at all other usages of os.Executable() and there should not be affected by this, so a revert would create a noisy history.

We: Nixpkgs - There have been several ways that we've broken the tailscale package and module lately - including this. We should move back to a stable point and then only start making changes if they're going to be well tested first.

Well, the other breakage was because a years old commit got reverted and that PR shouldn't have been merged in the first place and didn't receive a proper review from a maintainer.
We cannot realistically test everything, hence we always need to rely a bit on nixos-unstable to discover some issues.
I think we should just merge this and move forward and then we are at the stable point again.

I agree that not every tailscale feature can be realistically tested every PR.
It could be argued that tailscale ssh should have been tested but it can also be equally argued that nixos-unstable has no formal stability guarantees and by having any integration testing via headscale is ahead of other distributions.
If this issue when using ts_include_cli, and symlinking as described in the official tailscale docs, is not exclusive to the nix built copy due to our wrapping, this request for more extensive testing could also be applied to tailscale rather than unpaid volunteers.

In order to focus on how we (as the nixpkgs maintainers for tailscale) can improve going forwards rather than focusing on past negatives here are some proposals:

we could look to extend headscale integration tests to further tailscale features
we could leave non-version-bump changes open longer for people who are interested in testing

duration to be determined, could have exceptions
I still think faster merging of updates should be fine, extension of headscale integration testing should assist, we could pick a duration but it must be quicker than non-version-bump changes IMO

people concerned with the stability of tailscale could join in testing these PRs and post their experiences

PRs being open longer allows for more opertunity
individuals could be informal testers or officially sign up as maintainers
a method of notifying these individuals (including informal testers) would potentially be necessary

We will not catch all issues but these could help. I welcome thoughts on these proposals or additional ideas.


Adding tests to increase coverage

Pull Request Test Coverage Report for Build 720440628

12 of 13 (92.31%)  changed or added relevant lines in 2 files are covered.
7 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.7%) to 91.862%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

spock/backend/attr/payload.py
0
1
0.0%

Files with Coverage Reduction
New Missed Lines
%

spock/utils.py
7
86.17%

Totals

Change from base Build 720221594:
0.7%

Covered Lines:
824

Relevant Lines:
897

💛  - Coveralls


styling the plot using mplstyle file

Syle of the plots may be further adjusted by mplstyle file.
Should be easy to implemented. sumo has something similar.
Note that mplstyle file does changes globally, so caution is needed for interactive sessions (notebooks etc.)

This should be used only for the CLI as loading mplstyle changes global settings in an interactive python session which is not ideal.

This would be quite a useful feature!

Closing this issue as now implemented 🙌


BUG: Prevent the scheduler stopping early if a coroutine exits before yielding a non-join trigger

Fixes gh-637

Hmm, this seems to work correctly, but unfortunately the approach uses up the recursion stack, and hits the limit way too quickly


update integration test to latest gaia

closes #579

Codecov Report

Merging #589 (75f07b6) into main (ffe9c33) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #589   +/-   ##
=======================================
  Coverage   10.34%   10.34%
=======================================
  Files          55       55
  Lines        7770     7770
=======================================
  Hits          804      804
  Misses       6908     6908
  Partials       58       58

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffe9c33...75f07b6. Read the comment docs.


llama.cpp / llamafile api  server with api_base ?

is it possible to use this setup:
I have an external llama.cpp  (or llamafile) server  running in a docker co nt.  -> http://localhost:8000/v1
can I use litellm? or openai compatible ?
llm = LLM(path="myLLM", api_base="http://localhost:8001/v1", api_key="None")
will this work?

Yes this is possible. I believe you'd just need to prefix the path with openai.
 llm = LLM(path="openai/myLLM", api_base="http://localhost:8001/v1", api_key="None")


Update comment for GraphQLMiddlewareOptions

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 95.816%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1607

Relevant Lines:
1641

💛  - Coveralls


Header is not set for subscription

Hi.
I set the header through set headers, and I could see that it is set for graphql query, mutations (POST request).  But, with the same session/window, if I try a subscription request, header is not set. If I don't validate the request at server (don't check Auth header), then everything works. That indicates, subscription query from altair is fine except no header set (as i also see through chrome dev tools panel)
thanks.
bsr.

Thanks for reporting this! I'd look into it as soon as I can.

Just hit this issue myself trying to subscribe to an AWS AppSync API protected with an API_KEY.
Was hoping that Altair would handle it, as graphql-playground couldn't either.

@0xdevalias Thanks for the contextual information.

@bsr203 How are you using subscriptions with headers?

@bsr203 From the conversation here, https://github.com/apollographql/graphql-subscriptions/blob/master/.designs/authorization.md, It appears you can't set the header in the initial request. Unless I'm missing something.

@imolorhe thanks for the link. Sorry that I guessed it should work with initial POST request. I will look into any of the option which can be implemented outside the HTTP header can be done in my case. thanks again.

My understanding of that is that it depends on where you’re needing to make the request from. But that the standard browser API’s on their own don’t support custom headers for it, so would probably give more headaches down the line.
Given that reason, I’m kind of confused/surprised why AppSync went that way.. I guess since it probably makes use of ApiGateway, and that’s just how it used Auth, so they shoehorned it in..
Get Outlook for iOShttps://aka.ms/o0ukef

From: bsr203<EMAIL_ADDRESS>Sent: Friday, October 12, 2018 1:56 am
To: imolorhe/altair
Cc: 0xdevalias; Mention
Subject: Re: [imolorhe/altair] Header is not set for subscription (#416)
@imolorhehttps://github.com/imolorhe thanks for the link. Sorry that I guessed it should work with initial POST request. I will look into any of the option which can be implemented outside the HTTP header can be done in my case. thanks again.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/imolorhe/altair/issues/416#issuecomment-428983317, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAuA40Px6dcsxRC1Frb4tEg4kWmp06bnks5uj1wcgaJpZM4XTwUY.

For AppSync, the simplest way would be to use the SDK and have a simple UI or similar way to say ‘this is an AppSync api’, and plug in the appropriate config.
I put together a PoC repo to manually play with it since none of these tools work:

https://github.com/0xdevalias/poc-aws-appsync

Has notes on how to implement/etc. But basically the main chunk of code is just:

https://github.com/0xdevalias/poc-aws-appsync/blob/master/src/index.js#L7,L63

Get Outlook for iOShttps://aka.ms/o0ukef

From: Samuel<EMAIL_ADDRESS>Sent: Friday, October 12, 2018 8:26 pm
To: imolorhe/altair
Cc: 0xdevalias; Mention
Subject: Re: [imolorhe/altair] Header is not set for subscription (#416)
@0xdevaliashttps://github.com/0xdevalias I'm concerned about implementing this if there is no standard (or near standard) way of handling the authentication. It seems the authentication is handled differently as decided by the developers and the authentication mechanism available to them. If this were to be implemented, what exactly would need to be implemented?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/imolorhe/altair/issues/416#issuecomment-429264007, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAuA4y872mf1f1l6IS_kYnXXJvLzy9M-ks5ukGBTgaJpZM4XTwUY.

.

Implementing this with the approach defined by apollo graphql subscriptions for the SubscriptionServer, using the onConnect callback to validate the subscription connection request as implemented here.
This is one of a number of approaches used by various libraries but this has the best chance of being the de-facto approach for authentication across GraphQL websocket subscriptions.


Changed default port from 17001 to 18001

17001 interferes with hardcoded value in hm9000_analyzer:
https://github.com/axelaris/cf-release/blob/master/jobs/hm9000/templates/hm9000_analyzer_ctl#L25

Hi @axelaris
One generally does not colocate the gorouter with the hm9000.  If you are doing this, you can set the router.debug_addr property to some value other than the default in your manifest.

Hi @Amit-PivotalLabs
thank you for a reply.
Yes, I can add the router.debug_addr property to my stub file, but in fact, it will not be imported into the manifest by standard generate_deployment_manifest script:
https://github.com/cloudfoundry/cf-release/blob/master/templates/cf-jobs.yml#L704-L719
So, basically I have two options here: patch cf-jobs.yml to add a merge statement for router.debug_addr or patch the spec file to change the default value.
I believe changing default is better ;-)

Hey @axelaris
I'd recommend not changing the default.  It's a backwards incompatible change for people expecting the debug address to be on the 17001 port, not a huge deal, but I don't see a strong reason to break that compatibility.  Also, router and hm9k are independent, and developers working on one should not have to be worrying about what ports they put their services on and if it might clash with some service of some totally separate project.  BOSH gives you the flexibility to override the port in the case that you're doing something unconventional like colocating everything, so I'd prefer not to change the default port.
If you'd like to submit a PR to make that property spiff-able, we can probably merge it.
Cheers,
Amit

Hi @Amit-PivotalLabs,
would do you like me to add router.debug_addr to https://github.com/cloudfoundry/cf-release/pull/833 or I have to create a separate PR?

Yes please.
Closing in favour of adding the desired change to cloudfoundry/cf-release#833.


Cherry pick Add full data validation for ArrayData::try_new()

Semi-manual cherry-pick of 5806d297

Originally appeared in https://github.com/apache/arrow-rs/pull/921: Add full data validation for ArrayData::try_new()

There were some conflicts I needed to handle manually (mostly related to f16 support which was added on master)

Codecov Report

Merging #1007 (2f43802) into active_release (686ac18) will increase coverage by 0.01%.
The diff coverage is 87.45%.

@@                Coverage Diff                 @@
##           active_release    #1007      +/-   ##
==================================================
+ Coverage           82.35%   82.37%   +0.01%
==================================================
  Files                 168      168
  Lines               48834    49103     +269
==================================================
+ Hits                40219    40449     +230
- Misses               8615     8654      +39

Impacted Files
Coverage Δ

arrow/src/array/data.rs
82.04% <86.32%> (+1.32%)
:arrow_up:

arrow/src/array/array_binary.rs
93.55% <100.00%> (+0.13%)
:arrow_up:

arrow/src/array/array_dictionary.rs
88.75% <100.00%> (+0.28%)
:arrow_up:

arrow/src/array/array_string.rs
97.08% <100.00%> (-0.83%)
:arrow_down:

arrow/src/datatypes/field.rs
53.37% <0.00%> (-0.31%)
:arrow_down:

parquet/src/encodings/encoding.rs
93.52% <0.00%> (-0.20%)
:arrow_down:

arrow/src/array/transform/mod.rs
85.20% <0.00%> (-0.14%)
:arrow_down:

parquet_derive/src/parquet_field.rs
66.43% <0.00%> (+0.22%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 686ac18...2f43802. Read the comment docs.


Planbot (whatever that means?)

yay planbot code w/ Emlyn aka code for Emlyn cause Alex wont tell Emlyn how Planhub works

@em-p what?

@em-p This is not an issue... closing.

rude

:P

@nywillb I think you mean :stuck_out_tongue:


Ability to modify request using query string

Request can be modified using _request- query string. E.g. _request-1_2=/suppliers__["100"] this will update first (1) and second (2) request. In the request /suppliers will be assigned ["100"] value.


Optimize rendering

The cube component is super sub-optimal. It recomputes everything in every frame.
To optimize, let's consider when data should be changed.

The vertex and index list can be reused in all frames. This can use VAO.
The color (each vertex) should be changed between moves. This can also use VAO.
The rotation matrix should be updated in every frame because the rotation angle is changing.

done.


Pytype attribute generics tracker

Pytype currently doesn't support Generic types class attributes:
class Foo:
  bar: T

As a workaround we use Any for the attribute instead. This workaround should be reverted once the functionality is implemented

@jheek  -- Is there a public bug we can reference tracking the current limitation in pytype?

@jheek is this still relevant?

Yes we are still using this workaround


GraphiQL Docs color issues

[x] Search is white

[ ] Code in docs is green-on-white + docs color (grey) is hard to read

[ ] clickable links are hard to read (blue on dark green) | also: grey during hover is hard to read

Did some improvements with https://github.com/digitallyinduced/ihp/pull/1392/commits/294ca422d1a0752d1df602670cbf7be63062186d but not everything is fixed yet


Improve expression parsing error messages

It turns out people have very poor graphite queries that fail to parse.  Figuring out where the missing comma needs to go is tedious at the moment.  Make this easier.

Should this be closed?

Yes.


[Bug]: thermostat temperature increase/decrease is only by 0,5 degree

The problem
Thermostat feature allowing only to increase/decrease temperature by 0,5 degreee.
What version of Tech Controllers integration has the issue?
v2.1.0
What version of Home Assistant Core has the issue?
doesnt matter
What was the last working version of Tech Controller integration?
No response
Diagnostics information
No response
Anything in the logs that might be useful for us?
No response
Additional information
No response

Fixed by https://github.com/mariusz-ostoja-swierczynski/tech-controllers/pull/72


Reimplement two_qubit_decompose.num_basis_gates in rust

This PR does two things

Reimplement
https://github.com/Qiskit/qiskit/blob/9843fbfe7bf96f7acdda3cc5da3bea0028377efe/qiskit/quantum_info/synthesis/two_qubit_decompose.py#L1412-L1414
in rust

I looked at profiling with @mtreinish. It shows that a not-insignificant fraction of CPU time is spent here

At the same time, introduce a dependency on the linear algebra library faer. We are looking for a linear library to call from rust. faer is one of several options. A big advantage of faer is that it is pure rust so it incurs no additional build/package/distribute burden. The author prioritizes performance and some benchmarks look good. The project was started, or at least became public, less than a year ago.
This PR uses faer compute a determinant and eigenvalues of a 4x4 unitary matrix.

Todo:

Done make weyl_coordinates return correct values. Or at least agree with current Python implementation.
Done make num_basis_get return the correct values. It is currently broken. I just got the code to compile, and have not debugged. Five tests fail if you do tox -epy -- test.python.quantum_info.test_synthesis. No other python tests fail.
Done Currently this PR copies numpy complex matrices element by element to faer matrices. This should not be required. The author of faer told me that a version of faer that supports efficient conversion should be released tomorrow. To be clear, the version released tomorrow should support reading numpy arrays without copying.
Release notes, formatting, etc. will be done after the above is straightened out.
There are some inefficiencies and inelegant things in this PR as stands. We may want to correct these now, or put this off till later.

Existing tests pass. Here is a benchmark:
from qiskit.providers.fake_provider import FakeVigo
from qiskit.quantum_info.synthesis.two_qubit_decompose import TwoQubitBasisDecomposer
from qiskit.circuit.library import CXGate
from qiskit.transpiler.passes.synthesis.unitary_synthesis import _choose_euler_basis
from qiskit.quantum_info import random_unitary

backend = FakeVigo()
conf = backend.configuration()
basis = conf.basis_gates

basis_fidelity = 1.0
euler_basis = _choose_euler_basis(basis)
pulse_optimize = None
gate = CXGate()

def make_twoq_decomposer():
    backup_optimizer = TwoQubitBasisDecomposer(
        gate,
        basis_fidelity=basis_fidelity,
        euler_basis=euler_basis,
        pulse_optimize=pulse_optimize,
    )
    return backup_optimizer

u = random_unitary(4)
decomp = make_twoq_decomposer()

Then
In [2]: %timeit decomp.old_num_basis_gates(u)
96.3 µs ± 838 ns per loop (mean ± std. dev. of 7 runs, 10,000 loops each)

In [3]: %timeit decomp.num_basis_gates(u)
7.91 µs ± 48.5 ns per loop (mean ± std. dev. of 7 runs, 100,000 loops each)

Some of the matrices encountered in the test suite trigger a bug (or bugs) in faer.
https://github.com/sarah-ek/faer-rs/issues/78

Calculating eigenvalues of 4 x 4 matrices is faster with faer. Here eigvals is from numpy, and eigenvalues is a Python interface (in this PR) to the faer routine.
In [16]: u = random_unitary(4).to_matrix()

In [17]: %timeit eigenvalues(u)  # faer
3.83 µs ± 24.3 ns per loop (mean ± std. dev. of 7 runs, 100,000 loops each)

In [18]: %timeit eigvals(u)  # numpy
12.5 µs ± 65.4 ns per loop (mean ± std. dev. of 7 runs, 100,000 loops each)

In [19]: 12.5 / 3.83
Out[19]: 3.2637075718015667

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

129 of 146 (88.36%)  changed or added relevant lines in 4 files are covered.
26 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.02%) to 87.056%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

crates/accelerate/src/two_qubit_decompose.rs
113
119
94.96%

crates/accelerate/src/utils.rs
11
22
50.0%

Files with Coverage Reduction
New Missed Lines
%

crates/qasm2/src/lex.rs
4
91.67%

qiskit/quantum_info/synthesis/two_qubit_decompose.py
4
96.16%

crates/qasm2/src/parse.rs
18
96.67%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
74141

Relevant Lines:
85165

💛  - Coveralls

(Not a review, since Matt's doing that, just commenting on faer.)
I'm ok with trying it, largely for the reasons Matt gave, just a bit apprehensive because of the youth of the project and worries about stability of its interface. The author's seemed very receptive to improvements and comments, which is great for us being able to give back when/if we need to, but if part of that is that the interface isn't stable, we might end up investing a significant amount of work re-working our use to use a new patch we submitted.
I think it's worth trying for a bit, especially since we're not immediately going to build reams of code on top of it - if it turns out to be unstable or the project stales, it's not going to be tricky to switch out right now.


Switch LB algorithm to LEAST_REQUEST on older versions

Bug Description
following this:
https://github.com/istio/istio/pull/37220/files
i would like to be able to change the load balancing method on earlier versions, is it possible? (through istio operator or envoyfilters?
Version
$ istioctl version
client version: 1.15.0
control plane version: 1.9.0
data plane version: 1.9.0 (65 proxies)

Additional Information
No response

https://istio.io/latest/docs/reference/config/networking/destination-rule/#LoadBalancerSettings
We won't do anything else for old versions. Please upgrade, using 1.9.0 is a very unsafe idea...


Passing uuid to logger.

#31

Do not merge this branch I save it only because of screenshots. All functional of this branch already implemented in #19.


send_custom_email: Order by delivery_email if necessary.

If we .distinct("delivery_email") then we must also .order_by("delivery_email"); adc987dc43f6 added the .order_by call, which broke the newsletter codepath, since it did not contain the delivery_email in the ordering fields.
Add an override to pass down the order_by override when needed.

Folding this into #28435 since they conflict and I have another change to stack as well.


pull request for e2e test at 11/19/2016 06:56:05

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


WIP: Fix mac build warnings

All warnings are good to go besides the deprecate sem_init which will be fixed in the mac debugger support ticket


Support merging of files added in subdirectories that do not yet exist in our branch.

Manual testing reveals that Kinetic Merge hangs when it attempts to merge a branch that has added files located in subdirectories that don't yet exists in our branch. This causes some rather hokey code in the Scala process library to propagate an exception right up out of a thread spawned for the process, causing the thread to die quitely and leaving Kinetic Merge as a whole hanging in wait states.
This probably a good opportunity to revisit the spike where OS-Lib was tried out. I think that can cope with manipulating paths that don't yet exist even as prefixes. While I was not convinced as to whether the spike made the code more readable overall - there were good and bad points, I think this may be the decider.
So let's revisit that spike work as part of this...

Fixed in commit SHA: 685fc6b6f2a981ef6d8ab784d62ab655f377006c.

Delivered in Git commit SHA: 0496c15550cda63f47192898e5a0555bef0f65b8. Using os-lib for the implementation, although the integration tests for the application shell still use the mash of Java IO, NIO and Scala's process abstraction - didn't want to cut over both the SUT and the tests at the same time.


Job fail when copy to final destination (Replot)

Version 1.0.55
I encounter the below issue when replot is done with madmax, and the file was trying to copy to destination folder but it failed.
No error is recorded in the log.

The consequences is that, the failed copy file continue to sit in TMP drive (plotting drive), piling up and TMP drive will run out of space, then job is stopped.
Is it possible to add "Final Drive" column in All Runs tab, so we can have a better idea whether this happen to single drive or random drive?
or if it possible to return the copy fail error in the log?

Are you looking at the log file for the plot or the PSCP log file? If it did fail to copy it should have recorded the error that caused it to fail. I will add more info to the all runs tab including the "Final Drive" column you suggested.

Please see the plot log below.

As for PCSP log, not sure there is no log recorded.

So strange. I think a lot people don't have the PSCP log file being created. I will have to look into this. In the next update I plan to have the copy process be logged to the plot log file  as well. I think I will have it retry to copy if it fails as well.

Thank you!


[L5] getenv() doesn't return .env values on FreeBSD

We've seen the problem that getenv() used in the env() helper function doesn't return the values from the .env file even if the are available via $_ENV. We noticed that on a FreeBSD machine.
Solution in Illuminate/Foundation/helpers.php:628

$value = getenv($key);

$value = $_ENV[$key];

An "isset($_ENV[$key]) check should be done before.

Could you please take this up with dotenv since that's who we're using under the hood. Thank you. :)

Nope, the fix was for the Laravel code

No, I'm saying this needs fixing at the source. Some hack on top isn't good enough.

getenv() is an internal PHP function that calls the getenv() C function from stdlib. If the FreeBSD stdlib implementation has additional checks to prevent overriding what getenv() returns, the dotenv project will not be able to fix anything.
The only way to make this work is by using the $_ENV superglobal.

Ping @taylorotwell. Not my call on what to do.

@aimeos : it never worked on any Linux - at least I tried on Ubuntu and Fedora. I believe ENV vars get placed inside $_SERVER instead of $_ENV in some environments - but I managed to get mine using PHP-FPM's config and typing everything inside like:
[senisecti]
listen = /var/run/php5-fpm-senisecti.sock
listen.owner = senisecti
listen.group = www-data
listen.mode = 0660
user = senisecti
group = www-data
pm = ondemand
pm.max_children = 50
...
php_flag[display_errors] = off
php_admin_flag[log_errors] = on
php_admin_value[max_file_uploads] = 20
php_admin_value[memory_limit] = 128M
...
env[APP_ENV]=staging
... goes on and on ...