Mark Installed Packages To Not Upgrade

Mark Installed Packages To Not Upgrade
In a lot of enterprise environments there are controls that exist to force certain versions of things like Microsoft Office. Winget is cool in that it will do a check of installed apps that it didn't install and try to update them, that should definitely stay, but I have the issue where office will fail to install because the enterprise forces updates on a semi annual schedule instead of latest.
Proposed technical implementation details (optional)
Be able to do a "winget list", find the Microsoft.Office entry or whatever it may be -> winget flag --ignore-upgrade Microsoft.Office
That way it allows winget to work in tandem with enterprise applications such as SCCM or InTune, without competing.

Probably a dupe of (or at least very related to) #476.

Duplicate of #476


plot_embeddings with image_sprites from uri

To produce:
from docarray import DocumentArray, Document
import torchvision

def preproc(d: Document):
    return (d.load_uri_to_image_tensor()
             .set_image_tensor_shape((200, 200))
             .set_image_tensor_normalization()
             .set_image_tensor_channel_axis(-1, 0))

left_da = DocumentArray.from_files('left/*.jpg')

left_da.apply(preproc)

model = torchvision.models.resnet50(pretrained=True)
left_da.embed(model)

left_da.plot_embeddings(image_sprites=True)

Error:
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
Input In [1], in <module>
     14 model = torchvision.models.resnet50(pretrained=True)
     15 left_da.embed(model)
---> 17 left_da.plot_embeddings(image_sprites=True)

File ~/workplaces/docarray-env/docarray/docarray/array/mixins/plot.py:152, in PlotMixin.plot_embeddings(self, title, path, image_sprites, min_image_size, channel_axis, start_server, host, port)
    140     if len(self) > max_docs:
    141         warnings.warn(
    142             f'''
    143             {self!r} has more than {max_docs} elements, which is the maximum number of image sprites can support.
   (...)
    149             '''
    150         )
--> 152     self.plot_image_sprites(
    153         os.path.join(path, sprite_fn),
    154         canvas_size=canvas_size,
    155         min_size=min_image_size,
    156         channel_axis=channel_axis,
    157     )
    159 self.save_embeddings_csv(os.path.join(path, emb_fn), delimiter='\t')
    161 _exclude_fields = ('embedding', 'tensor', 'scores')

File ~/workplaces/docarray-env/docarray/docarray/array/mixins/plot.py:331, in PlotMixin.plot_image_sprites(self, output, canvas_size, min_size, channel_axis)
    329 row_id = floor(img_id / img_per_row)
    330 col_id = img_id % img_per_row
--> 331 sprite_img[
    332     (row_id * img_size) : ((row_id + 1) * img_size),
    333     (col_id * img_size) : ((col_id + 1) * img_size),
    334 ] = _d.tensor
    336 img_id += 1
    337 if img_id >= max_num_img:

ValueError: could not broadcast input array from shape (16,16,200) into shape (16,16,3)

Suggested fix:
passing use_uri flag to plot_embeddings to allow visualizing the dots using uri attribute. I would be happy to raise a PR for this.

the broadcast issue can be resolved by checking the channel axis using channel_axis=0 but this will not visualize the original images.

the broadcast issue can be resolved by checking the channel axis using channel_axis=0 but this will not visualize the original images.

maybe u can transform the axis back before plotting? I guess the stacking is only needed at embedding time

maybe u can transform the axis back before plotting? I guess the stacking is only needed at embedding time

Changing the axis will work , however , it would be nice to have an option to show the original images when projecting embeddings without processing them again.

More than the original, you expect plot_embeddings to force some axis as the channel one?

More than the original, you expect plot_embeddings to force some axis as the channel one?

just a flag to force loading from uri and setting the channel axis:
https://github.com/jina-ai/docarray/blob/79c13a09980c97c9b4fcf9857566ff2a46c95c83/docarray/array/mixins/plot.py#L321
if use_uri or _d.content_type != 'tensor':
    _d.load_uri_to_image_tensor()
    channel_axis = -1

another possible approach for this problem. As the applied preproc function is only for model inference. Can we pass the prepoc function to  . embed():
def preproc(d: Document)
    ....
    return d

da.embed(model, preproc_fn=preproc)

Then, the output (copy of the origin DA) of preproc can then be fed into the model for inference, and will not change the value of origin DA.
With this change, the user can choose which method to use regarding context. If the user wants to store the updates, then apply preproc before .embed(). If the user don't want keep the updates, then apply the preproc within the .embed()

@abduhbm make sense solved in #66 roll out soon

Thanks all for your support.


[SQL Migration] Implement URI handler

In this PR, we implement an URI handler for the sql-migration extension, which supports one path (/start) which allows the user to launch the migration wizard directly without having to manually navigate to the "Migrate to Azure SQL" button in the UI. Additionally, with optional parameters, the user can provide an arbitrary list of databases (or specify that they'd like all databases) which will be pre-selected on step 1 of the migration wizard.
Sample URIs:

azuredatastudio://Microsoft.sql-migration/start

Launches the migration wizard, as if the user were to manually click the "Migrate to Azure SQL" button in the extension UI

azuredatastudio://Microsoft.sql-migration/start?databases=AdventureWorks,AdventureWorks2

Launches the migration wizard, skipping the page which asks the user whether or not they want to start a new session, and goes directly to step 1 of the wizard with the databases AdventureWorks and AdventureWorks2 automatically selected.

azuredatastudio://Microsoft.sql-migration/start?databases=__all

Launches the migration wizard, skipping directly to step 1 of the wizard, with all databases automatically selected.

WIP:

support adding a new connection via URI

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 42.338%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
28337

Relevant Lines:
62439

💛  - Coveralls

@raymondroc are you still working on this PR?  If not, please close and reopen again once work resumes.  Thanks!

Closing older PR without recent activity.  Please reopen if working on this area again.


Installation and setup instructions

Update the readme to have some getting started instructions

npm install
tailwind configuration
explain factor classes
explain scale options
show how to disable dynamic mode

#18 Updates the readme

wana work on this..

wana work on this..

Hello there i have opened #18 so you could give any suggestions if you have there?

Hey, @TerrySmithDC can you please assign this issue to me. I can fix this.

Hey, @TerrySmithDC can you please assign this issue to me. I can fix this.

Hello there i have already opened the PR at #18 if you have any suggestions could you send them there

Sorry @creater-shikha and @Ritika457 I missed the requests, however Megatank did open the PR first. I've all ready accepted @Megatank58 's PR however meaningful edits are still welcome!

Closing this one as there is now a readme, I'll make a new readme update ticket to leave open, feel free to make PRs there if you find types, grammar issues, want to add better use cases etc.


Cleanup cluster state on startup

currently right after starting the crc VM, when checking the state of pods, some of them could appear as properly running while it's just left-over state from the previous VM run which is not properly cleaned up on shutdown. We should clean this up when starting up the VM before starting the kubelet. This probably involves changing some values in etcd (?)

Still relevant... what would be possible?
At the moment we try to remove pods and have them recreated, but still references to the initial run exist.

this is something we can't fix until manually change the etcd data, #wontfix


Dump full rancher + k3s logs if rancher/k3s fail

https://github.com/rancher/rancher/issues/36483
Signed-off-by: Chris Kim<EMAIL_ADDRESS>

This should help debug https://github.com/rancher/rancher/issues/36791


Relational Query: Support niladic functions

I need support for things like [t].[GeometryColumn].STX in SQL as part of #1100. Can also be used for CURRENT_TIMESTAMP, etc.
I tried to write some unit tests, but the cost of unit testing DefaultQuerySqlGenerator is much higher than I'm willing to pay right now considering I have functional tests that use this already passing in my spatial branch.
Part of #9022
cc @pmiddleton

Looks good to me.
I have a pr ready which adds this and extends to dbfunctions.  That part needs the ability to run standalone functions in order to be useful.  That ability is part of the TVF pr.
Sorry @bricelam I should have submitted this half of my pr so you didn't have to implement this.
Cc @divega

Feel free to submit a PR! I'd happily take it over mine.


Replace defer unlocks with explicit ones

Apparently defer is not free: https://github.com/golang/go/issues/14939

Defer is certainly not free. I agree on several of the simple replacements but especially in those functions with multiple return points, defer is safer to use.
Could you elaborate why exactly these locks (we are using defer in a ton more places)? Could you measure any performance improvements with this change?

No particular reason to choosing these locks, just changed at part of the code I happen to look at

go question: is it  required to unlock before panic() call?

reverted to defer in multi-return funcs

panic() just crashes the application so no need to unlock anything. In this use case defer is generally interesting to finish of storage writes or similar so we don't leave anything corrupted after crashing.

@beorn7 your call.
I generally agree with all the un-defering done here. All these methods have a small scope and this could accumulate to a decent improvement given they are called for millions of chunks.

The linked issue sounds like the defer slowness will be solved in Go1.8.
I'd be fine to do the "manual" defer in proven hot spots of the code, but not in general. Also, every occurrence should be marked is "this is done for performance reasons and should be reverted to idiomatic use once https://github.com/golang/go/issues/14939 is fixed".
I could imagine that pin and unpin are a very hot spot, but I'm not sure for every occurrence in this PR.
WRT the unlock in case of panic: People start to use the storage package independently. They might want to recover from a panic (at least for test purposes), so not unlocking in case of a panic is only acceptable if the panic only happens due to an internal programming error.
WRT naked returns: Does that have a performance impact, too? (I would hope not.) Our style guide is very restrictive about naked returns. They should in general be avoided.

updated: no naked returns

Do we have benchmarks covering this area which show an improvement now?

It would be easy to look at a CPU profiling output to see the percentage spent in any of these functions.
For pin and unpin, I would believe a relevant impact even without looking. (Those are called thousands of times per second.) Also, those functions are super short and easy. No panic/unlock problem, no problem with the unlock being "below the fold". No additional variable assignment.
I'd like to see a provable effect for the others, especially given that the problem will go away with Go1.8, most likely, and we have to revert the changes then.

I finally indulged into a bit of profiling.
WRT pin/unpin: I picked our busiest server in terms of pinning (performing whopping 130k pins/sec!). Still, the profiling resulted in only 0.66% in unpin and 0.14% in pin.
I checked all the other modified functions, too,  The only one that matters (more than 1% of CPU time spent) at all is seriesMap.get (which has a huge share of CPU time, around 25%). I'm not sure how much of that time is just spent because of lock contention. But it's the only code where the defer hack at least has the potential of making a dent.
(I could imagine some of the simpler functions don't show up so much in the profiling because they were inlined by the compiler, but that would also unroll the defer, so it would solve our problem as a byproduct.)
Conclusion: Since this is anyway only a temporary workaround, could you just change seriesMap.get and add a comment that this is just a work-around until the defer slowness is solved (best to add a link to the bug).
Thanks.

doesn't worth  it. @beorn7, out of curiosity, would you be able to publish cpu profile from that busy server?

For seriesMap.get, it might well be worth it. To shortcut the change, I have created https://github.com/prometheus/prometheus/pull/2021.


BPFProgramTypeIsSupported(bpf.BPFProgTypeSocketFilter) returns true

Hello,
Function BPFProgramTypeIsSupported returns true for socket related program type BPFProgramTypeIsSupported but looking inside the module code I can't see such a possibility to attach socket program to a socket. I missed something or it's a bug?
module version: github.com/aquasecurity/libbpfgo v0.4.5-libbpf-1.0.1

@MaciekLeks This function is use for check features of the host Linux kernel, not for check libbpfgo.


[Autocomplete] Reset form state on each request for applications that reuse the Symfony application between requests

Q
A

Bug fix?
yes

New feature?
no

Issues

License
MIT

Hi there, in ux-autocomplete there is an WrappedEntityTypeAutocompleter::getForm which on first call saves form instance in WrappedEntityTypeAutocompleter $form property, it has method setOptions which is called on each request in EntityAutocompleteController, in PHP-FPM everything will work as expected where container is created on each request, but with Swoole or similar where container is not created on each request rather only first request on first EntityAutocompleteController request everything is also fine, but on second request WrappedEntityTypeAutocompleter  will have an instance of form from previous request which is fine but the call of setOptions in controller will throw exception.
So in Swoole on second and next requests $this->form already contains an instance of form from previous request because DI Container is not created on each request as in PHP-FPM (Container is created only once) and exception is thrown. So, Symfony have an kernel.reset / kernel.terminate event which probably can be used here to reset $this->form in WrappedEntityTypeAutocompleter because they are fired after request is completed.

Thank you @dotdevio for this PR!
Could you maybe add a test?
Also.. I'd see this more as a feature than a bug, as swoole (or similar runners) compatibility was not something supported before..  what do you think ?

Thank you @dotdevio for this PR!
Could you maybe add a test?
Also.. I'd see this more as a feature than a bug, as swoole (or similar runners) compatibility was not something supported before.. what do you think ?

This is not a feature because Symfony supports multiple runtimes and this bug will be not only in Swoole but any other runtime like FrankenPHP, RoadRunner etc. Service state shoud reset in this case for sure, no BC breaks on PHP-FPM. I would like add a test but i dont see how i can test here and i dont found any tests for WrappedEntityTypeAutocompleter. Actually there is noothing to break the app, just unsetting variable on kernel.reset event.

Ok! Thank you for the fix @dotdevio :)

This fixes https://github.com/symfony/ux/issues/1649

Perfect, thanks @dotdevio!


Simple changes to make this library support i18n use cases

Describe the feature
I have used many components from shadcn-svelte, and my project has multiple languages one of them is arabic which is RTL, the way shadcn is built is really good, I always change some small stuff to make it work even in RTL, these changes are very tiny and the ui always ends up looking the exact same so I was wondering while I don't expect shadcn/ui to have this, this isn't a whole new feature is just using different tailwind classes
change 1:
replacing every space-x and space-y with gap
not only is this just more clean, it's also stable now https://caniuse.com/?search=gap
change 2:
the harder pill to swallow is changing all (mr, ml, pr, pl) to (me, ms. pe, ps) 🙂
I know change 2 is not the norm but these are the only two changes that consistently make the website look the same, support RTL for i18n use cases and make this library perfect

I have not tried that yet 🤔, because I just switch all of them and keep using "me-2" afterward but give me some time and I'll give it a try

Thank you, @azezsan! That would be my only concern. I hope that eventually, tailwind will only support me, ms, etc... to force the hands a bit.

@huntabyte Okay so, twMerge does support some of our use cases but not fully, for example, text-start and text-end will be overridden by any text-left or text-right, it always checks which one came last
but it doesn't do it for ms or me because it doesn't know your intentions there are 2 possible scenarios while the text thingy had one if it were to override ms with ml in LTR, in RTL ms became more like mr instead of ml
but I came up with a solution for this problem, we can modify twMerge behavior to signal to twMerge that we favor the LTR side because the theory is the ui is broken in RTL anyways here is how it would look like
`import { type ClassValue, clsx } from "clsx";
import { extendTailwindMerge } from "tailwind-merge";
import { cubicOut } from "svelte/easing";
import type { TransitionConfig } from "svelte/transition";
const anyValue = () => true
const twMerge = extendTailwindMerge({
extend: {
classGroups: {
px: [{ "ps": [anyValue]}, { "pe": [anyValue]}],
mx: [{ "ms": [anyValue]}, { "me": [anyValue]}],
pl: [{ "ps": [anyValue]}],
pr: [{ "pe": [anyValue]}],
ml: [{ "ms": [anyValue]}],
mr: [{ "me": [anyValue]}],
}
}
});
export function cn(...inputs: ClassValue[]) {
return twMerge(clsx(inputs));
}
`
ps in LTR simply means left, so if some English LTR consumer would use this library it will behave normally fulfilling the test case you mentioned,
so now in our default classes, we have "me-2" and the consumer of the component passes "mr-4", it will override "me-2"
but if he doesn't continue using ps pe ms etc... it will break if he tries to switch to RTL as it should but work the exact same in LTR
as for the RTL consumer, it will work for him right away but he has to continue using ps pe ms etc..., but pl pr ml etc... might not behave as expected only in shadcn classes but the idea here is the UI in RTL never worked to begin with
I added mx, px to override pe, ps, ms, me if they came last since it behaves the same in left and right

Awesome! Maybe this is something worth adding to the docs under an "Internationalization" section or similar? Showcasing how one could set this up in their projects

Hmm.. I don't like that we have to add that piece of code for all consumers and having to change everything to ps pe ms etc..., it might annoy some consumers who don't care about i18n and it's deviating from shadcn-ui, maybe changing space-x, space-y to gap and text to text-start, text end, makes sense and twMerge handles it well by default
for ps pe ms etc... it could be something in the docs under "Internationalization"?

Does gap work with elements that are just block instead of a flex or grid?

no it doesn't, flex and grid only

Sad to see this closed, would be awesome to have RTL support out of the box!
@azezsan What prompted you to close?

Sad to see this closed, would be awesome to have RTL support out of the box!
@azezsan What prompted you to close?

there is just many minor inconveniences for users and maintainers that it's kind of annoying to deal with if the majority of users don't care and don't want to use ms. me and would prefer using ml, mr
the best suggestion I could come up with is having a option when using the cli to switch to i18n mode and it will switch everything to ms, me etc.. if the user choose but again that's not part of shadcn and will be extra work for maintainers

Hmm, I see your point. In an ideal world people would primarily use logical css, but the majority is probably not concerned with RTL and don't bother.
I guess the ones that do need RTL support have to customise their components by hand then.
Thanks for your effort anyway :)


[docs] Update infinite-queries.md typos

Fix minor typos on infinite-queries.md file

edit: I can push up additional commits for other markdown files (for typos) if you'd like to have a larger PR for minor doc fixes. I'm reading through the docs right now.

:tada: This PR is included in version 3.13.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Implement better force update behavior that ignores no-ops

Today force update will typically report lots of changed snapshots even if they did not actually change. Additionally it generates pending snapshot files for inline snapshots which result in absolutely no changes. This changes the behavior to compare the serialized contents to the current ones and only write a change if there is one.
Fixes #333

Thanks!
I almost wonder whether force update should be default True now, given that they're not that volatile (no line numbers now). Or even whether a False option is that helpful.
We'll try making it default True in PRQL at the next insta release and see how that goes.


Update occursIndex to skip absent elements

The occursIndex function should return the current index of the element in the infoset. Daffodil was using the current array position as this value. When the emptyElementParsePolicy is set to treatAsAbsent, empty elements are not included in the final infoset and therefore the current array position may not match the index in the final infoset.
This change introduces a new variable in the parser and unparser states for tracking the current occusIndex value which is not incremented when an absent element is seen.
DAFFODIL-2791

I wonder if it would be worth moving checks that aren't specific to OS and JDK versions into their own "lint" job inside main.yml? It must be discouraging to make a change to a PR and see 3 out of 6 matrix jobs fail across the board.

Yeah, I think that is a better long-term solution. At that time it would also be nice to see if we can have the tests run in a docker container with all the dependencies and configurations installed and ready-to-go. A bonus to that is having a image you can use locally that is the same one used in the CI build.

I wonder if it would be worth moving checks that aren't specific to OS and JDK versions into their own "lint" job inside main.yml?

Agreed. It would also make the OS/JDK jobs finish 1-2 minutes quicker. Not a huge difference, but the quicker tests finish the better. The new job could also be configured to always run all checks even if one fails.

At that time it would also be nice to see if we can have the tests run in a docker container with all the dependencies and configurations installed and ready-to-go.

I wouldn't want to have to maintain multiple docker images for CI tests. We already have 7 different OS/JDK combinations we have. Though I agree that a dev container could be useful. Though, most of the dependency work is handled by sbt which is straightforward to install. I think the only deps it doesn't handle is gcc and MiniXML dep, which I think most distros already provide.
Whatever is decided can all be done as a separate PR though.

I wouldn't want to have to maintain multiple docker images for CI tests. We already have 7 different OS/JDK combinations we have.

We only need one for linux and latest and greatest JDK. It could be used for that build and for the lint check. The other combos could be done as it is now. It might be faster for CI to download the image than to install the dependencies and there is a chance that the CI could cache the image.


docs: Remove outdated comment

db659da enables shared libraries by default on Windows and Darwin, but it didn't
update the docs.

The comment is absolutely correct, Windows does not support static libraries currently, and Darwin no longer supports static linking.


Update the docs

Describe the bug
Problem
While following the shadcn/ui documentation to create a new project, I encountered an error when running the command:
bunx --bun create-next-app@latest my-app --typescript --tailwind --eslint
Result: error: Script not found "create-next-app@latest"
The error seems to be related to the use of the create-next-app command, which is not recognized by Bun. According to the official Bun documentation, the correct command is create next-app. I believe the shadcn/ui documentation should be fixed to prevent other users from facing the same issue.
Suggested Solution
Update the documentation to use the correct command as per the official Bun documentation:
bunx --bun create next-app@latest my-app --typescript --tailwind --eslint
Affected component/components
All
How to reproduce

Follow the shadcn/ui documentation.
Run the provided command to create a new project with Bun.
Observe the resulting error.

Codesandbox/StackBlitz link
No response
Logs
No response
System Info
Windows

Before submitting

[X] I've made research efforts and searched the documentation
[X] I've searched for existing issues

Hey @thiagodebugs,
I encountered the same issue with the error: Script not found "create-next-app@latest". However, I managed to resolve it by using the following command in Windows:
bun x --bun create next-app@latest my-app --typescript --tailwind --eslint

For me, the key was to use bun x instead of bunx when installing all the ShadCN components.
I hope this helps!


Warning: Authentication with username / password is expected to cease to function on or after December 2021. Please re-authenticate using newest method. See README for more info.

Describe The Bug:
I upgraded to HOOBS 4 and the plugin no longer works. The
To Reproduce:
Installing the plugin doesn't ask for authentication, login, or password
Expected behavior:
I would like to
Environment:

Plugin version: 1.8.4
Node.js Version:
NPM Version:
Homebridge Version:
Operating System: Raspbian

Homebridge Config:

Paste the relevant section of your homebridge config.json here

Screenshots:

Logs:

Link to logs
Paste Homebridge Logs here
10/10/2021, 11:03:35 AMSimplisafe3 BridgeLoaded plugin 'homebridge-simplisafe3'
10/10/2021, 11:03:35 AMSimplisafe3 BridgeLoading 1 platforms...
10/10/2021, 11:03:35 AMSimplisafe3 BridgeHome AlarmSpecifying account number: 00169889
10/10/2021, 11:03:35 AMSimplisafe3 BridgeHome AlarmWARNINGWarning: Authentication with username / password is expected to cease to function on or after December 2021. Please re-authenticate using newest method. See README for more info.
10/10/2021, 11:03:35 AMSimplisafe3 BridgeHome AlarmAttempting to login with username / password.
10/10/2021, 11:03:35 AMSimplisafe3 BridgeHome AlarmFound 0 cached accessories being configured
10/10/2021, 11:03:36 AMSimplisafe3 BridgeBridge is running on port 51876.
10/10/2021, 11:03:36 AMSimplisafe3 BridgeHome AlarmUsername / password login failed.
10/10/2021, 11:03:36 AMSimplisafe3 BridgeHome AlarmERRORSee the plugin README for more information on authenticating with SimpliSafe.
10/10/2021, 11:03:36 AMSimplisafe3 BridgeHome AlarmERRORInitial accessories refresh failed with error: Error: Not authenticated with SimpliSafe.
    at /var/lib/hoobs/simplisafe3bridge/node_modules/homebridge-simplisafe3/index.js:103:56
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
10/10/2021, 11:10:14 AMRoomba Stv BridgeRoombaBattery status requested
10/10/2021, 11:10:14 AMRoomba Stv BridgeRoombaRunning status requested

<!-- Click the "Preview" tab before you submit to ensure the formatting is correct. -->

Hi @jussin5150 , this plugin does not explicitly support HOOBS, it is built with homebridge. From your screenshots it looks like HOOBS doesnt show the button(s) to authenticate with the new method which means you will have to use the command line tool. As for username / password, that should be in your config.
Please see the readme for relevant info, let us know if youre still having trouble.

I'm not sure how to use the command line tool. Can you help me with that?
Justin
On Sun, Oct 10, 2021 at 11:19 AM Michael Shamoon @.***>
wrote:

Hi @jussin5150 https://github.com/jussin5150 , this plugin does not
explicitly support HOOBS, it is built with homebridge. From your
screenshots it looks like HOOBS doesnt show the button(s) to authenticate
with the new method which means you will have to use the command line tool.
As for username / password, that should be in your config.
Please see the readme for relevant info
https://github.com/homebridge-simplisafe3/homebridge-simplisafe3#simplisafe-authentication,
let us know if youre still having trouble.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/homebridge-simplisafe3/homebridge-simplisafe3/issues/247#issuecomment-939510419,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQVUVRIVJ3OEKDBOA45GEBDUGG4KFANCNFSM5FWT7J7A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Please see the link I posted, the readme. Perhaps you can reach out to HOOBS if you need help? Or you can always switch to homebridge =)


BitBucket Support

If I set the IssueTracker to BitBucket I am unable to create ReleaseNotes. The Issue #57 has been closed and merged but if I download your solution the files are not in the GitReleaseNotes project.

Okay found them in the GitTools.IssueTrackers project. But BitBucket seems to be missing there.

@GeertvanHorrik did the bitbucket support get removed at some point?

Not sure, I thought I implemented it, maybe on a separate branch. Will check.

I think we are confused with JIRA. We have been working on support for JIRA, not BitBucket for what I can remember (although both from Atlassian).

https://github.com/GitTools/GitReleaseNotes/commit/58d0b6f937375ea761c444602574156b528fe9f1
We added it, but it seems to be gone now.

The source code is still there in the repo but not referenced in the solution. But since all the IssueTrackers got moved to a separate repo I suppose it has to be re-implemented there?

Opened an Issue on the correct repo and closing this one...
https://github.com/GitTools/GitTools.IssueTrackers/issues/7


fltk: do not propagate fontconfig

On Linux and FreeBSD, giada depends directly on fontconfig. Currently, this is incorrectly propagated via the FLTK dependency.
This is being done as part of #357462, to incrementally move towards a better FLTK derivation.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/4865

i know nothing about fltk but looks lgtm


Broken inventory icons as of update 1.08

Since the 1.08 update, this is causing some items to have the wrong icon in the inventory screen.

fixed!


A couple of errors

Hi,
Just been looking through the code for this and I noticed 2 things:

search.js line 117 is missing item.seach_omit != "true" &&

feed.json line 47, I'm pretty sure it should read:
        "seach_omit": "{{ page.search_omit }}"
instead of:
        "seach_omit": "{{ post.search_omit }}"
(page vs. post)
Thanks
Edit: oh, and re. 1 notice the typo 'seach' should be 'search' on this line and corrected everywhere in feed.json

Have proposed typo fix in #8 and not sure if this is the reason for me still seeing results despite the presence of search_omit: true in front matter.

As far as I can remember, results weren't omitted for me either, see 1 above. Things work fine for me now with that change in place.

Fixed with #8


When you make a single html change gulp reports that all html files have changed

Here's my ionic info:

Thanks for opening the issue. It seems that issue has been resolved. I am going to close this issue but please feel free to reopen another issue if this occurs again.


Syntax highlighting on array stops after 47 items on single line

I have an array with many numbers on a single line, after 47 numbers the syntax highlighting stops.

After the end of the array, normal syntax colouring continues as expected.
Atom v1.2.4 - Windows 7 x64
Theme is Monokai For One Dark, but the issue appears on the default Atom themes as well.

Atom currently does not syntax highlight long lines for performance reasons - please see #1667 for more details.


Fix fuzz code.

link: https://github.com/uutils/diffutils/issues/7

@oSoMoN is that ok with you? thanks

I suppose it doesn't matter much, but the most common case would be with stop_early=false.
Note that I also addressed this regression in a commit in a separate PR (https://github.com/uutils/diffutils/pull/28/commits/44a356e7c6dfca66b632e8f68c580a9b32f9d3c3), but feel free to merge this first as I'm afk for a few more days.
-------- Message d'origine --------
Le 26/03/2024 23:23, Sylvestre Ledru  a écrit :

@.***(https://github.com/oSoMoN) is that ok with you? thanks
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

sorry but i took @oSoMoN as he was the first :)

sorry but i took @oSoMoN as he was the first :)

no problem. Thank you.


Add an example configuration and update README

Pull Request Test Coverage Report for Build<PHONE_NUMBER>0
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.07%) to 58.895%

Totals

Change from base Build<PHONE_NUMBER>9:
0.07%

Covered Lines:
1791

Relevant Lines:
3041

💛  - Coveralls


spaCy - BPE Alignment sometimes faulty, raises index errors

Hi, thanks for the corpus creating scripts. They're very helpful.
I got an index error with BPE/spacy tokenization as shown below:
Extracting embeddings into /felicity/workspace/exbert/server/data/mt/deepak/embeddings/embeddings.hdf5
['deep', '##ak', 'i', 'don', '’', 't', 'feel', 'like', 'doing', 'my', 'meditation', 'today', '.']
['deepak', 'i', 'do', 'n’t', 'feel', 'like', 'doing', 'my', 'meditation', 'today', '.']
11
0
Deepak I don’t feel like doing my meditation today.
Traceback (most recent call last):
  File "/felicity/workspace/exbert/server/data/processing/create_corpus.py", line 19, in <module>
    create_hdf5.main(unique_sent_pckl, args.outdir, args.force)
  File "/felicity/workspace/exbert/server/data/processing/create_hdf5.py", line 221, in main
    sentences_to_hdf5(embedding_extractor, str(embedding_outpath), sentences, clear_file=force)
  File "/felicity/workspace/exbert/server/data/processing/create_hdf5.py", line 179, in sentences_to_hdf5
    b_pos = combine_tokens_meta(b_tokens, s_tokens, s_pos)
  File "/felicity/workspace/exbert/server/utils/token_processing.py", line 121, in combine_tokens_meta
    meta_list.append(spacy_meta[j])
IndexError: list index out of range

In IndexError designed to raise under certain circumstances? If not how can I solve it?
Thank you very much.
Originally posted by @felicitywang in https://github.com/bhoov/exbert/issues/4#issuecomment-544828248

Looking at the two tokenized lists, it looks like the contraction don't messes up the alignment. spaCy has a bunch of built in exception words for tokenization that make it very difficult to align to the way BPE tokenizes words.
I will be working on this, but in the meantime, consider writing a script that filters the corpus of these exceptions

Thanks for the quick response. Temporarily solved by removing all sentences with "'".


Quite slow incremental build performance

Bug Report
Ionic version:

[x] 4.x
Current behavior:
Curently it takes about 3-7 seconds (depending on CPU) to see the updated code after it is changed. I have a xps15 with a i7 8750H.

Expected behavior:
As a developer, it is important to see as close to instant feedback ideally of how stuff looks like, would make the Ionic developer experience much better / be a big + for the project. Not too sure if Ionic can improve the webpack process or if we need to wait for angular to use bazel for instance.
Steps to reproduce:
Just follow the ionic beta documentation, setup an ionic 4.x.x project with the following command :
ionic start myApp tabs --type=angular

Other information:

Ionic info:

Ionic:

   ionic (Ionic CLI)             : 4.6.0 (C:\Users\romai\AppData\Roaming\npm\node_modules\ionic)
   Ionic Framework               : @ionic/angular 4.0.0-rc.0
   @angular-devkit/build-angular : 0.10.7
   @angular-devkit/schematics    : 0.7.5
   @angular/cli                  : 7.2.0-beta.2
   @ionic/angular-toolkit        : 1.2.2 (C:\Users\romai\ideaProjects\gitalye\node_modules\@ionic\angular-toolkit)

Cordova:

   cordova (Cordova CLI) : 8.0.0
   Cordova Platforms     : android 7.0.0
   Cordova Plugins       : cordova-plugin-ionic-keyboard 2.1.2, cordova-plugin-ionic-webview 2.0.1, (and 6 other plugins)

System:

   NodeJS : v11.6.0 (C:\Program Files\nodejs\node.exe)
   npm    : 6.5.0
   OS     : Windows 10

I can confirm. I need (for a small-medium-sized project) 9 to 16 seconds to build with Ionic. But I think Angular can be optimized, too

I meant incremental build, the one that happens when you run ionic serve, and you change a line, I clarified my first post.

I mean that, too ;) The initial build takes longer for me ;)

What I meant is not 4 seconds for a simple change, but less than 300-500 ms would be a juicy target.

Yeah, but this is not the task of Ionic, this is a task for Angular ;)

Thanks for the issue! ionic serve runs ng serve directly which is an Angular command.
As of Ionic 4, Ionic no longer ships with custom Angular build tools. This means any build issues you experience should be considered Angular build issues and should be brought up with the Angular team.

Angular Issues
Angular CLI Issues

I'm going to close this as I do not think it is an Ionic issue. Thanks!


Small highlighting issues

Comment is not highlighted if it appears in line after any numeric constant:

Only first numeric constant in line is highlighted:

I am using last version of plugin builded from source

Thanx for reporting this. I'll look into it.

Fixed bug: after constant no syntax highlighting. Versions after 1.4.0 will have this fix.


Invalid bootstrap progress after uploading app to Apache web hosting

Progress bar in localhost:

Progress bar in web hosting:

Everything is on 100%.
This is the code:
<progressbar class="progress-striped"
[value]="object.current_hp"
[max]="object.max_hp"
[type]="type">
{{object.current_hp/object.max_hp | percent:'1.0-1'}} HP ({{object.current_hp}}/{{object.max_hp}})</progressbar>

What's wrong? feels like the [max] is not initalized or something..

I am not sure that problem is in progressbar


(refactor) cmd refactor

Thanks @ccoVeille
Will commit suggestions and fix based on comments.

I'm glad you find my review useful


ReactiveResilience4j event consumer not working

Hi,
I am using Spring Cloud Gateway and has created a below bean.
    @Bean
    @RefreshScope
    public Customizer<ReactiveResilience4JCircuitBreakerFactory> hgwCircuitBreaker(){
        return factory -> {
            routeCircuitBreakers.forEach((id,name) ->{

                factory.configure(builder -> builder.circuitBreakerConfig(CircuitBreakerConfig.ofDefaults()).build()
                                .setCircuitBreakerConfig(CircuitBreakerConfig.custom().minimumNumberOfCalls(10).failureRateThreshold(20).build())
                        , id);
                if(name.getSelectAttribute() != ""){
                    HashMap<String, CBFilterCfg> cbFilters = name.getCbFilters();
                    if(!cbFilters.isEmpty()) {
                        cbFilters.forEach((filterId, cbFilterCfg) -> {
                            factory.configure(builder -> builder.circuitBreakerConfig(CircuitBreakerConfig.ofDefaults()).build()
                                            .setCircuitBreakerConfig(CircuitBreakerConfig.custom().minimumNumberOfCalls(1).failureRateThreshold(1).build())
                                    , id + "-" + cbFilterCfg.getAttributeValue());

                        });
                    }
                }

            });

            Customizer.once(circuitBreaker -> {
                circuitBreaker.getEventPublisher()
                        .onEvent(event -> LOGGER.info(Logger.EVENT_SUCCESS, event.getCircuitBreakerName()+" : "+event));
            }, CircuitBreaker::getName);

        };
    }

But I am not seeing any log related to any event in Circuit Breaker. Do I need to create a consumer somewhere so that it can start logging the events?
Thanks!!!

Can you provide a complete, minimal, verifiable sample that reproduces the problem? It should be available as a GitHub (or similar) project or attached to this issue as a zip file.

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.


Swift 4.1 Issues

UIResponder issues in swift 4.1 when using 2.3.3 version. What is the pod version for Swift 4.1 .
Swift 4.0 has 2.3.3 , swift 4.2 has 2.3.4 , Please see attachment

Hello @shravanik18,
Could you try using v2.3.9 ? Do you still have the problem after installing this version of the pod?
Btw, which version of Xcode are you using?

Xcode Version is - 9.4.1

Yes facing the same issue.Please help for the same
Xcode version is - 9.3

same problem

Getting the same issue. Used to work before. Gives me the same issue with older version too. Using xcode 10

Hello everyone,
Version 2.3.2 should be the last one supporting Swift 4.1.
Can you try pod 'DropDown', '~> 2.3.2' and confirm that is fixes your issue?
Thanks!

I upgraded to swift 4.2  and the it works now. Thanks for your help

@shravanik18 @ismailtosun Have you tried the comment above? Can you confirm it solves the issue?

@kevin-hirsch
Upgrading to  'DropDown', '~> 2.3.2' still gives same error.

Hello @Vaibhavi107 👋
Normally, doing pod 'DropDown', '~> 2.3.2' is installing 2.3.x
What you should do is pod 'DropDown', '2.3.2'

@kevin-hirsch
Thanks alot. It Works perfectly fine. :)

Great 🤗

@anilsutariya remove ~> , pod 'DropDown', '2.3.2'

@Monochrome4   So what pod i can use for dropdown

@anilsutariya I mean use pod 'DropDown', '2.3.2', remove the ~> in pod 'DropDown', '~> 2.3.2'

@Monochrome4  Let i try and do.

Upgrading to 'DropDown', ' 2.3.2' still gives same error.

swift 4.1
xcode 9.4.1

@Monochrome4  same error getting if remove ~>.


3D image visualization?

Hi
Thanks for the wonderful explanation. I would like to know how you created those 3D images ,are they particular slice ,so represented in 2D or you used tool?
If there is any python script to visualize 3D volumes then please guide,it will be great help
Thanks
Sagar

You can use ITK Snap for viewing the .mha files. The images are downloaded from BRATS data set and each image comes with 4 modalities and each is having 155 slices in axial view(Please see  README.md).


Error value when edit "time" of dly/rvb in bpm

If you select bpm mode for time of Delay/Reverb etc settings - you can't type bpm value, because it still wait ms value

In fact it's not in ms either. It simply asks for value from 0 to 100 like the rest of the sliders. I'll fix it in the next release.


implement / deploy Kubernetes based chaos

Allow for the deployment of a Kubernetes / pod level chaos solution.
Implementation should include documenting available tests as well as implementing knobs to enable/disable tests.

[x] Implement Pod level chaos testing
[x] Implement latency injection istio fabrikate HDL
[x] Implement Fabrikate component for chaos stack
[x] Add Documentation for fabrikate component

Implement Pod Level Chaos

fabrikate HLD is available at https://github.com/munishm/fabrikate-kubemonkey

[x] Implement Pod level chaos testing
[x] Implement latency injection istio fabrikate HDL
[x] Implement Fabrikate component for chaos stack
[ ] Add Documentation for fabrikate component

https://github.com/munishm/fabrikate-istiochaos

While https://github.com/munishm/fabrikate-kubemonkey wraps https://github.com/asobti/kube-monkey, it feels like a bit more documentation could be added ... maybe include an example config not just additional config options.

@evanlouie pls take a look

Closing since the individual work items are done


How different languages work?

Could README include instructions how different languages work? I seem to always get finnish version even if try to build for different language using .env file with
VUE_APP_I18N_LOCALE=en
Or is there some method to change language?

Thanks for the suggestion. Fixed in the version 3.0.36: The default language is now defined correctly in the .env file. Also, the README contains instructions for language usage.

Thank you, I tested the language attribute and it works as expected.


CSS Formatter

Hello VS Code crew
I see VS Code can formatting html, json, js, but can't do it with css, scss. It is possible to make it native too?
Of course i know there is a lot of add-ons in marketplace, but if you support html or js formatter, maybe it a good idea to support css, scss too ?
It always better to have native functions. Add-ons often fail

Try https://marketplace.visualstudio.com/items?itemName=esbenp.prettier-vscode.


[boost-locale] Enable arm64-windows

boost-locale:arm64-windows needs boost-thread:arm64-windows

Hi @tony979, could you also bump the CONTROL version?

The Version is bumped from 1.69.0 to 1.69.0-1

@tony979, I'm so sorry about this. It's my mistake.

This PR passes the CI build. Thanks @tony979!


Make an option to allow some special locations with small checks to be visible with reduced view

Some locations that don't have any checks are still important to keep in mind (especially in RSL).
An option to allow these special locations to be always displayed (even if we mask checks already done) would help in keeping notes of those.
These locations are :

Dampe's Hut (for Light Arrows hint in RSL and other misc hints) -> you cannot collect this hint as child
--> currently in the House list, if accepted this could be its own Interior
Sleeping Talon House -> you cannot initiate the trade without pocket cucoo
Granny's Potion Shop -> (if expensive merchants is off) you cannot initiate the trade without odd potion
Mask Shop -> you need to swap masks several times to do the checks

Thanks for the suggestion! This is on my list after the refactor. I'm looking at two implementations:

Option to show secondary locations tied to a "real" location. The secondaries would be hidden after all linked primaries are checked, and they would not count towards check total.
Global location search to filter the view for matching locations. This is more for things like Great Fairy Fountains that can be difficult to route currently if they are spread out in the UI.

Dampe's Hut will be included with hint tracking (#5) when that is implemented.

This is way better than my suggestion, seems awesome
Also really good to know it will come. Right now, my best friend is CTRL-F (hence why i made this suggestion, it's hard to find hidden things)

Glad to know Hint Tracking is on todo ; friends still have trouble with some gossip stone locations sometimes.

For now this was included in #46 as a new "Show Helpful Extra Checks" option in the Tracker Settings menu. It also includes bean planting, unshuffled trade events, setting scarecrow's song, and saving Epona.
I'm leaving this open to make sure this is complete for the rewrite.

There is a new "Show Unshuffled Locations" tracker setting that lets you always show certain categories of locations, including trade quest turn ins. There is a separate Show Hints option for the gossip stones, and each stone can be assigned a hint that automatically colors regions. Blue is WOTH, Green plus an item in the title bar is Path, Grey is Foolish.


Chore: deprecate and delete approllout related code

Signed-off-by: wangyike<EMAIL_ADDRESS>Description of your changes

Fixes #2260
I have:

[ ] Read and followed KubeVela's contribution process.
[ ] Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
[ ] Run make reviewable to ensure this PR is ready for review.
[ ] Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Have test compatibility of this pr manually.


Improve API docs based on Best practices

Description:
For instance, a client should be kept open throughout the entitreity of the application, this can be indicated as a note in both Module/Package md as well as function description.
Likewise all recommendations must be indicated from the API docs, https://stackoverflow.com/collectives/wso2/articles/74843098/guidelines-and-best-practices-for-ballerina-sql-client-usages

This should be fixed in both 3.x and master branch.
@kalaiyarasiganeshalingam Could you send the fixes for one module first, once its approved we can add it to all other connectors.

Closing this issue as all DB docs were updated.


XHCI over EHCI for better performance as well as aarch64 support

Update to use a more friendly version USB that works with aarch64
Notes:
https://qemu-project.gitlab.io/qemu/system/devices/usb.html
XHCI controller support
QEMU has XHCI host adapter support. The XHCI hardware design is much more virtualization-friendly when compared to EHCI and UHCI, thus XHCI emulation uses less resources (especially CPU). So if your guest supports XHCI (which should be the case for any operating system released around 2010 or later) we recommend using

Signed-off-by: Jason W. Ehrlich<EMAIL_ADDRESS>

Resolves https://github.com/lima-vm/lima/issues/499


CAPI Patch: Bottlerocket parse and set provider-id for Kubelet args

Description of changes:
Metal workflows do not have cloud-provider to set the provider id on a node spec. Kubelet needs to be passed this field in order for kubelet to set this on the node spec. This is used by machine controllers on CAPI to mark a node as completely bootstrapped.
/hold
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/unhold

/approve


fix(material/datepicker): fix disabled style for datepicker in a legacy form field

Reproduction StackBlitz
This affects the toggle in the completely disabled and popup disabled variants when using the legacy Form field component with Datepicker.

Disabled Datepicker in legacy Form field using<EMAIL_ADDRESS>
Disabled Datepicker in legacy Form field with this bugfix.
Fixes #26152.

Thanks, people will be using versions 15 and 16 for a while so it is still relevant.

We weren't able to land this due to presubmit failures, and at this point the legacy components have been deleted, so closing this PR


Re-order steps on CI

Problem
Currently fmt and linting happens before building and running unit tests.
Solution
We should run the build first and make sure the code compiles, then run unit tests and in the end run clippy and fmt.

/bounty 15$

/attempt #394
I'll take this up, thank you

/attempt #394

Seems kind of odd to want to spend all the time and energy on building and testing if a simple comma out of place is going to bring the whole CI step down at the end, but what do I know? 😅

Now I am having second thoughts about this LOL.

fmt and linting should happen first

I think we can do this in parallel also since they aren't related.

Update 1
Linting and Testing can be parallized and the developer can be informed about it independently.

Based on the comments https://twitter.com/tusharmath/status/1708813317404520529
I think it's wise to do it in parallel.


Update components of Lokomotive

Update following components and terraform providers

Done
Component
Current Version
Latest Version
PR

calico
v3.15.0
v3.15.1

etcd
v3.4.9
v3.4.10

cert-manager
v0.15.1
v0.16.1

external-dns
2.21.2
3.2.6

metallb
v0.8.3-2-gf653773b
v0.9.3

rook
v1.3.2
v1.4.0

aws-ebs-csi-driver
0.5.0
v0.6.0

velero
2.7.0
2.12.13

cluster-autoscaler
1.14.6
1.18.1

Done
TF Provider
Current Version
Latest Version
PR

Packet
2.7.3
v3.0.0

AWS
2.48.0
v3.1.0

Azure
1.35.0
v2.22.0

TLS
2.0
v2.2.0

Local
1.2
v1.4.0

Null
2.1
v2.1.2

CT
0.5.0
v0.6.1

Matchbox
0.3
v0.4.1

I think we should divide this issue, because updating all at the same time would be difficult. Creating sub-issues would be nice, what do you think?

@knrt10 feel free to create those issues for tracking purposes. But I feel some components update work is very trivial that creating issue for them will just be additional overhead.

Cool, I think done column will come to use for this then.

Linked some issues and PRs in the table.

Divide and Conquer.
This task has progressing nicely. Kudos :tada:

As MetalLB is part of the v0.4.0 milestone and it's a last component to update, I'll close this issue. Good work everyone :boom:


Update tsan-suppressions.txt

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.
Description
This pull request fixes grammatical errors in the documentation to improve readability and clarity.
Changes made:

Corrected grammatical errors

These changes do not affect any functional parts of the project, and they only enhance the documentation.
Please review and let me know if any further improvements are needed. Thank you!
fixes issue #32574

This is an internal data file, not intended to be publicly consumed. The PR doesn't fix any actual grammatical errors.


Auto tuning v3

Adding auto tuning of block sizes feature, which is made to be more general and potentially could be easily extended.
Added AutoTuner object which takes Operator and at_report_dir_path as parameters.
Now when auto tuning runs, Propagator replaces all block sizes with variables and appends them as parameters to the function. This saves us recompiling on each auto tune run (problem we had with ISAT)
Added tests and auto tuning example file.
Updated README.md
Added info function to logger as @FabioLuporini suggested
Changed cache blocking logic, which is as follows:
cache_blocking and block_sizes have to be either single bool/int instances which will block all dims or lists of same size as spacial domain explicitly specifying which dims to block and which block sizes to use.
To use auto tuning results pass at_report argument to Operator.

@navjotk @FabioLuporini @mlange05 Inviting comments!
Particulary whether decide_block_sizes function in propagator is not to complex.

So is the "default behaviour" back to blocking all dimensions?

if you pass single block size value, yes. it blocks all dimensions. Should I change it?

Not saying you should. Just commenting on the fact that the last cache blocking related PR made that the default behaviour and this one seems to be going back to the previous default behaviour. Do we have a definite answer now on what we want the default behaviour to be? (I don't - but I think we should resolve this before changing it again)

Very good job.
One minor thing, one major thing, and one observation for the future.
Minor 1: these lines are too long, seriously, they make the code unreadable. We should really make them shorter than at least 90 (PEP says 80 !), by using more variables, being more pythonic or simply by splitting them over multiple lines
Major: the autotune option has made the Propagator code even more chaotic than it already was, because of all those if then else which basically change the behaviour depending on whether we are autotuning or not. I think this a symptom that we should rather have a different Propagator class, or maybe extend the existing one.
Observation for the future: we will have to unpick this template-based method of generating code. Let's keep this in mind.

I echo @FabioLuporini's concerns that this is way too invasive to the Propagator and Operator. Do we really have to change the behaviour that much for auto-tuning, and can we not generalise most of this stuff to get rid of all the if auto_tune: pieces? Conceptually, the Propagator in particular should have very little to no awareness of auto-tuning and just be invoked repeatedly by the auto-tuner, no?

I don't see how's it is that invasive for Operator as it only uses auto_tune flag in apply function to intercept the compiled function and its args. Does not even save auto_tune as a var.
For Propagator however, i think decide_block_sizes function could potentially be less complex,
however I think all if auto_tune statemens in generate_loops_blocking are necessary, because we need to replace most loop limit variables with strings that allow calculation of block size on spot. Thats pretty much the only place where Propagator does need to know about auto_tuning.
Alternative could be to write a different method for generating loops which would get called if auto tuning. This would allow us to eliminate 3-4 out of 5 if auto_tune statements in Propagator, however it the code for generating blocked loop would be almost duplicated.

Also @FabioLuporini about the lines, im more than happy to shorten them howerver if it really bothers you I think we should include this rule in our PEP 8 evaluation, as I just try to make sure lines are bellow 120 as with current rule

@sheino I agree we should add the PEP 8 rule
what I meant by "unpicking" is that we are copy-pasting code at the moment more than writing an actual compiler.
As for the rest, I still think we are not doing enough object oriented programming here. If we had a separate class, we could for example just overwrite that generate_loops_something method, or perhaps split it into smaller (private) methods and then overwriting them accordingly. All the branches would eventually disappear.
What happens for example if we wanted a Propagator that generates code for GPUs ? or that applies some other magic ? I think we need a proper hierarchy and it seems quite quick to do

@navjotk @FabioLuporini @mlange05 inviting comments again as I updated the logic in response to previous comments and discussion on slack

I've added some small comments but nothing too serious
Lines must be below 90, this should be fixed. I'm gonna file an issue now, we must update the pep8 rule
gj !

this has been around for a while, but it looks like we're pretty close to merge. Let's do it quickly!

Can we add to acoustic_example how we would use it in addition to the test?

Sure, do you want it to be simple and just commented out as we dont want to run auto tuning every time we want to test acoustic or controlled by significant amount of flags


Mobile sidebar unable to scroll; "Sign out" too close to hamburger menu

On mobile, after toggling the hamburger menu, the "sidebar" cannot be scrolled.
Also, having a destructive action (sign out) next to the action item (menu button) is... strange. Maybe these buttons can instead go right inside the sidebar? I couldn't find an easy way to do that.

Move hamburger menu to left?

peter told me to do this :)

^^^ that reopen/close is my fault for not noticing this issue was mentioned in #381 , not fixed in #381 ... long week 😓

@peterkos Is this good to close?

^Oops

Yep!


[nrfconnect] add support for nRF5340

Problem
No support for nRF5340 SoC in nRF Connect SDK platform.
Summary of Changes
Add support for nRF5340 SoC.
Internal implementation notes:

nRF Connect SDK version currently needs to point to https://github.com/e-rk/sdk-nrf/tree/multiprotocol-rpmsg until it is merged to master.
nRF5340 due to some speed limitation of CC312 uses different RNG driver, for now, thus a new proj has been created
DTS for nRF5340 had to be adjusted, also in lightning-app since PWM needs compatible entry.
DTS files moved to "boards" folder, so that are fetched automatically.

I guess we don't need to update the Pigweed-app?

I haven't found a need for it now. But, do you think we should add complementary support there? It should be quick..

I guess we don't need to update the Pigweed-app?

I haven't found a need for it now. But, do you think we should add complementary support there? It should be quick..

I haven't found a need for it now. But, do you think we should add complementary support there? It should be quick..

No, it's fine by me. I just asked if it was deliberate.

I haven't found a need for it now. But, do you think we should add complementary support there? It should be quick..

No, it's fine by me. I just asked if it was deliberate.


[New Theme Request] Nginx Proxy Manager

I love these themes and I’m using the dark theme for everything I can.
Having the themes available for Nginx Proxy Manager too would be awesome!
https://github.com/jlesage/docker-nginx-proxy-manager

There are instructions for npm in the wiki. https://github.com/gilbN/theme.park/wiki/Setup#nginx-proxy-manager

Maybe I didn’t express myself right.. I meant a theme for NPM itself.. :)

This would be awesome!

This would be awesome!

+1!

Oh, yes please :D

Agreed, has to happen lol seems great

develop.theme-park.dev has a theme available now

Merged to master


enable http2 support

acording to https://www.python-httpx.org/http2/ http/2 may be faster then http/1 that is curently used...
Benchmarks needed to prove this

On further thought it's possible the server is still using http/1 because it isn't setup for http2. Really I'm not sure why http/1 gets used even when http2=True. So that would need to be figured out.

good feedback i will make apropriate changes and this would be handy for testing (of course i have simple docker compose as well)

@sanders41  due magnitude of changes i started from scrach by focepushing
Checklist

[x]  Add a boolean http2 parameter to the AsyncClient init that defaults to False.
[x] Set the http2 argument on HttpxAsyncClient based on the http2 parameter instead of hard coding it as True
[x] Notify the meilisearch server in the request that http2 is being used -https://www.meilisearch.com/docs/guides/security/http2_ssl
[x] Add tests to make sure it is working (example below)
[x] Add the same features to the Client

to make it work and improve code i did following things that were not requested but probably welcomed

added ujson and orjson to dev dependencies so things work out of box for next contributor
did same for decorator as for client/asyncclient
modifed all test to use ssl  (since they would fail)
in case you want to keep python 3.9 just hard reset to cd588cd668787e75d56f75097108708b1b516ca9 and things will work

why was python 3.9 removed
new dev  dependecy: truststore suports only 3.10
alternatives require this dependency only for python 3.10 and do dirty verify false for python 3.9
i am not againts just disabliing ssl since it is KISS solution
also in case it does not work on CI/CD comit cd588cd668787e75d56f75097108708b1b516ca9 will work since i tested it with act  localy next commit does not work

@sanders41 made few last minute changes now it should work

@07pepa this looks good now, I just have one question I want to verify. With this
@pytest.fixture(scope="session")
def ssl_verify(request, http2_enabled):
    if has_truststore:  # truststore is installed
        if http2_enabled:
            # http2 needs ssl so best to use truststore to make things work with mkcert
            return truststore.SSLContext(ssl.PROTOCOL_TLS_CLIENT) if http2_enabled else True
        return True  # recommended default
    else:  # truststore isn't installed
        if sys.version_info >= (3, 10):  # should be available in 3.10+
            warning("truststore not installed, your environment may be broken run uv sync")
        # without truststore we can't verify the ssl (and when http2 is enabled, verification must be disabled)
        return not http2_enabled

Python 3.9 will always run the tests as http/1 since it can't install trust store so we might as well remove it from the http/2 tests because it is testing the same as as http/1.
Is that correct, or did I miss something?

they can run http2 tests, but they do not verify certificates (that could be done also for all version elsewhere)
so as side effect on 3.10+ versions  --http2 also verifies runing meilisearch with custom certificates and overiding ssl context
it could be simplified by just not verifiing certificates.


Rendering breaks on windows

Probably because not shipping the right font.

Yup, font issue.
Fixed with this commit - https://github.com/flarepen/flare-app/commit/7760d36a5b41794461dbc23e9151c6d920774bd8


Custom attributes not passed along recordError on iOS

I wanted to pass along a custom message attribute with recordError. This works fine on Android but not on iOS (tested with both iOS simulator and a real iOS phone). The message column is empty for iOS.

Also I don't understand why ExceptionName is different for iOS/Android and why some columns (e.g. Is Fatal is empty for iOS).
Also Mobile Dart Errors does not seem to be written for Android, is that correct?
FROM `Mobile Dart Errors` SELECT * SINCE 1 day ago

NewrelicMobile.instance.recordError(
      errorObject,
      stackTrace,
      attributes: {
        'message': 'Additional message',
      },
      isFatal: false,
    );

@akaegi thank you for reporting the issue, we will release fix in next release.

FYI: I've set newEventSystemEnabled: true in my newrelic Config, not sure if that's anything to do with the issue.

@akaegi we fixed the issue on our side, we will release it soon.


fix: updated provider version

Description
updated provider version
issue : https://github.ibm.com/GoldenEye/issues/issues/6747
Release required?

[ ] No release
[ ] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

:tada: This PR is included in version 1.6.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Marker Colors for Android and iOS are not equal

First I would like to thanks the google map team for an excellent plugin.
Works perfect for both Android and iOS.
Minor snag (version 0.5.7): Marker Colors for Android and iOS are not equal.
My app has a legend table that is correct for Android but not for iOS.
The URL below shows the miss match.
https://github.com/StephanCassel/Aviator-Tracker/blob/master/flutter_google_map_color2.png

I can reproduce this on latest version fo the maps plugin.


can not download files, need help adding custom routes

I have published the views using php artisan vendor:publish --tag=lfm_view
But when i use these views such as in views/vendor/laravel-filemanager/index.blade.php , my download and rename menu for every file is not enabled.
As far as i am understanding, i have to add custom route with /custom_url?type=Files. But  adding custom route documentation is quite vague. Can anyone explain what i should do to add the custom route to work with this package?

Copy the routes in /vendor/unisharp/laravel-filemanager/src/routes.php, and paste them to your routes file.

The following error is shown if i paste the routes file.

(1/1) ReflectionException
Class App\Http\Controllers\Unisharp\Laravelfilemanager\controllers\LfmController does not exist
in Container.php (line 729)
at ReflectionClass->__construct('App\Http\Controllers\Unisharp\Laravelfilemanager\controllers\LfmController')
in Container.php (line 729)
at Container->build('App\Http\Controllers\Unisharp\Laravelfilemanager\controllers\LfmController')
in Container.php (line 608)
at Container->resolve('App\Http\Controllers\Unisharp\Laravelfilemanager\controllers\LfmController')
in Container.php (line 575)
at Container->make('App\Http\Controllers\Unisharp\Laravelfilemanager\controllers\LfmController')
in Application.php (line 728)
at Application->make('App\Http\Controllers\Unisharp\Laravelfilemanager\controllers\LfmController')
in Route.php (line 217)
at Route->getController()
in Route.php (line 747)
at Route->controllerMiddleware()
in Route.php (line 708)
at Route->gatherMiddleware()
in Router.php (line 587)
at Router->gatherRouteMiddleware(object(Route))
in Router.php (line 567)
at Router->runRouteWithinStack(object(Route), object(Request))
in Router.php (line 535)
at Router->dispatchToRoute(object(Request))
in Router.php (line 513)
at Router->dispatch(object(Request))
in Kernel.php (line 176)
at Kernel->Illuminate\Foundation\Http{closure}(object(Request))
in Pipeline.php (line 30)
at Pipeline->Illuminate\Routing{closure}(object(Request))
in TransformsRequest.php (line 30)
at TransformsRequest->handle(object(Request), object(Closure))
in Pipeline.php (line 148)
at Pipeline->Illuminate\Pipeline{closure}(object(Request))
in Pipeline.php (line 53)
at Pipeline->Illuminate\Routing{closure}(object(Request))
in TransformsRequest.php (line 30)
at TransformsRequest->handle(object(Request), object(Closure))
in Pipeline.php (line 148)
at Pipeline->Illuminate\Pipeline{closure}(object(Request))
in Pipeline.php (line 53)
at Pipeline->Illuminate\Routing{closure}(object(Request))
in ValidatePostSize.php (line 27)
at ValidatePostSize->handle(object(Request), object(Closure))
in Pipeline.php (line 148)
at Pipeline->Illuminate\Pipeline{closure}(object(Request))
in Pipeline.php (line 53)
at Pipeline->Illuminate\Routing{closure}(object(Request))
in CheckForMaintenanceMode.php (line 46)
at CheckForMaintenanceMode->handle(object(Request), object(Closure))
in Pipeline.php (line 148)
at Pipeline->Illuminate\Pipeline{closure}(object(Request))
in Pipeline.php (line 53)
at Pipeline->Illuminate\Routing{closure}(object(Request))
in Pipeline.php (line 102)
at Pipeline->then(object(Closure))
in Kernel.php (line 151)
at Kernel->sendRequestThroughRouter(object(Request))
in Kernel.php (line 116)
at Kernel->handle(object(Request))
in index.php (line 54)
at require_once('C:\xampp\htdocs\cse391\onlineTsr\public\index.php')
in server.php (line 21)

You have namespace error in this line :

Class App\Http\Controllers\Unisharp\Laravelfilemanager\controllers\LfmController does not exist

how can i fix this namspace error?

@bmabir17 You should change it to \Unisharp\Laravelfilemanager\controllers\LfmController.

00

0


Add codeowners

This PR adds code owners as lined out in:
https://github.blog/2017-07-06-introducing-code-owners/
https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

Nice addition thanks @matmair


[CP] [Impeller] Retain embolden/skew font properties when rendering text glyphs

issue_link
https://github.com/flutter/flutter/issues/119489
Commit Hash
https://github.com/flutter/engine/commit/4fdbb0a366e76920f62d23ce220456e1c5a255ab
Target
stable
pr_link
https://github.com/flutter/engine/pull/39424
Impacted Users
Impeller users
Impact Description
Font properties were not retained properly when rendering the glyph atlas, causing text to look wonky.
Workaround
There is no workaround
Risk
low
Test Coverage
yes
Validation Steps
Ensure text with these properties set looks correct.

cc @bdero @jonahwilliams @chinmaygarde

I included https://github.com/flutter/engine/pull/39383 in this CP as well since it looks like these are supposed to go together.

LGTM


Adding a phone login sends a /v// link but this route was removed

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Add phone login
Get text message
See link has /v/<accountID>/<validateCode> syntax
Tap it and brought to app but nothing happens (route doesn't exist)

Expected Result:

Validate code is passed to validateLogin() and the secondary login gets added ? cc @NikkiWines

Actual Result:
Nothing happens
Workaround:
They can't add a phone login
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number:
Reproducible in staging?: Yes
Reproducible in production?: Yes
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:
View all open jobs on GitHub

hmmm is the problem that the app should not be opening that link at all? Or what is the expected behavior when the app opens it?

hmmm is the problem that the app should not be opening that link at all

We send you a link and it opens the app, but does not validate your secondary login. Because the link we send has no corresponding route so it is like a very basic deep link that does nothing but open the app. The expected behavior is that your secondary login will get automatically validated.

I'll add the validate route back, then we should make sure this flow is added to the regression testing suite.

Alternatively, we could do that in oldDot, that already should have a page for that, no?

AFAIK the design that was implemented was to have the user return to NewDot - so unsure if we should change that. But maybe @NikkiWines has thoughts on this.

The original implementation had the user routed back to NewDot if they initiated adding the secondary login from NewDot - I don't think we should change it so they're routed to OldDot. Seems like a weird flow for them to go through


Additions to commbench cause segfaults on many platforms

Original issue: https://charm.cs.illinois.edu/redmine/issues/183

Mostly SMP builds, but some single-threaded builds as well. cf. autobuild.

Original author: Yanhua Sun
Original date: 2013-04-13 16:41:23

It is caused by cpv variable not initialized. I checked in  a fix and tested on net smp. It worked.

Original date: 2013-04-13 16:43:08

Will close when autobuild passes these tomorrow.


Nightfox.nvim not compiling

Hi, I'm using Neovim 0.8 via AstroVim. I used to use 'Carbonfox' theme and I never had problems with it. However, I updated some things and now Carbonfox theme throws the error shown in the image below. I tried this with other themes included here like Nightfox or Duskfox and this error persists. Now, and this is the important thing, I know you could blame AstroVim for not recognizing it or being missconfigured. However, it works perfectly with any other theme I have been testing, like oxocarbon or catppuccin, among others. In other words, this only happens with Nightfox's themes.

I suspect the error comes from the functions inside the red rectangle.
I really, really love Carbonfox and just wanted to report his issue.
Cheers

It looks like the failure looks like it is coming from nvim-notify, saying that strings can't have new lines. I redid the logging for nightfox let me know if your get the same error.

Hi,
Thanks for your quick reply. And now it's working!

Solved and thank you!
P.S.: I still find Carbonfox the best theme ever.


32bits things

You'll need manually run workflow on actions to run build

Thanks mays, I tried to change it but it always said "hxcpp is out of date", I don't know what you did but it works


Add parameter to control which module to generate code into

Current dependencies on/for this PR:

master

PR #3   👈

This stack of pull requests is managed by Graphite.


Support sourcemap headers

When using hidden sourcemaps (devtool: hidden-source-map) Sentry requires a HTTP header ("sourcemap") to be sent with each request. This way the sourcemaps can be referenced even without a sourcemap comment.
I have updated the plugin to support this functionality. I've had some errors with jest, which is why i updated jest as well. Also updated webpack to the now stable 2.2.1 and bumped the version of this plugin to reflect the change.

I admit I'm a bit confused by this PR. Is there a use case for using devtool: hidden-source-map with Sentry? I've found that Sentry's file/sourcemap matching is works fine, provided you name them correctly.  This is what the defaultTransform option is for - renaming the sourcemap file to match the file as it is served.
This seems like a lot of unnecessary complexity for little to no gain.

Thanks for taking a look at the pr!
The use case here is for hidden sourcemaps. Since sourcemaps by default contain the entire sourcecode of the app it's not always great to ship them with your app. When you delete them afterwards you have that dangling comment left. Sentry supports this since it's still nice to have proper stack traces from production apps.
I was also quite puzzled that the plutonium did not support this. I feel the complexity is OK to take on considering that it now support all devtool configurations (and sentry features).
This also takes away the need to worry about naming your sourcemaps in a sentry specific way since it will just use your existing config and work.

I understand that hidden sourcemaps are useful for not putting your sourcemap out publicly.
However I've never had a problem deleting the sourcemap afterwards and leaving the dangling comment. There's no extra request for the sourcemap unless you have dev tools open. I think it's fine to only support a specific devtool configuration because that's what you would configure webpack with anyway (i.e. without the plugin). You probably shouldn't need to worry about renaming the sourcemap file name with the default configuration (as it uses ~/).
My problem with the complexity is that I have to maintain it, and so I'm reluctant to over complicate things.

I'll happily help maintain the project as contributor or member 😄 Of course if you don't feel comfortable with this that's fine as well i'll just maintain a fork then.
Of course it's possible to set webpack up in a way that this plugin works (it is a great plugin after all!) - for the user this is just a lot of work. They need to understand Sentry's naming requirements, might have to change other tools dealing with sourcemaps etc. I feel there is an immediate benefit in not having to worry about this. (Just add the plugin, fill in Sentry config and it works!)
If they just want to upload some files based on a filter (which is pretty much what it does as "dumb" uploader) they could just use sentry-cli after webpack.

You're of course welcome to maintain a fork. The intention of the plugin is to be just a "dumb" uploader that integrates better into a webpack workflow. I'm afraid still don't really understand what use case is enabled by this PR that isn't possible with the current version.
I think that you shouldn't need to understand Sentry's naming requirements to get it set up, unless you're doing something with the compilation after webpack has run, in which case I don't know how a plugin could possible know how to handle that. The defaultTransform option is there if you are serving files from a particular location (i.e. I use it serve from a Rails app, so we set the defaultTransform to return ~/assets). I'm also not aware of changes to other sourcemap tools.
This discussion has raised a good point that the plugin could handle removal of sourcemaps after they're uploaded, so I've created https://github.com/40thieves/webpack-sentry-plugin/issues/12.

@Kamshak I would love to have this functionality so that warnings do not show up when opening devtools. Why wouldn't you want this merged @40thieves? All I want is to delete the source mapping url in the output after this finishes. Is that not possible yet?

You can use my fork here: https://github.com/Kamshak/webpack2-sentry-plugin

I think I made my thoughts pretty clear above. I have not seen any use case in which hidden-source-map is unsupported or difficult to set up. I actually deployed a production app on Friday that uses it with no issues.

oh gotcha, so I can do hidden sourcemap and it will not show in the devtools, got it

Webpack's docs on devtool are pretty good

Yeah I knew about it but for some reason thought it would mes up sentry's reporting without the line in each file.

@40thieves I'm pretty certain that using the hidden dev tool never uses your sourcemaps on sentry since there's no source mapping url. I tried using hidden source map for a few days and no errors were unminified.

I have not seen any use case in which hidden-source-map is unsupported or difficult to set up.

@40thieves is there a misunderstanding here?  devtool: hidden-source-map simply does not work without this PR. If you upload js without the sourcemap comment to sentry you need to provide a header instead. That was this PR does. The whole point of it.
You can work around it by not using hidden-source-map and removing the mapping (which is the solution implemented in #12). But it is not mentioned in the docs and there is no error either. If you use devtool: hidden-source-map which is well supported in webpack with this plugin it just silently fails because sentry doesn't use the filename for mapping.

I don't really know what to say here. hidden-source-map definitely does work. I know because I have been running it in production for several months.
More to the point, the plugin replicates the process described in the official Sentry documentation about uploading source maps: https://docs.sentry.io/clients/javascript/sourcemaps/#uploading-source-maps-to-sentry. Try running the curl commands yourself.
If it's not working for you try checking your config. But to be honest I don't have a lot of time for this and I don't really feel like doing support for this any more.

The docs are unfortunately off, if you check the official implementation you will find it does the same thing: https://github.com/getsentry/sentry-cli/blob/fc2430ae8faea1ac22766fe59e2c981fefa5063d/src/sourcemaputils.rs#L379
I've tried using the plugin as is with devtool: hidden-source-map but it did not work for me (no mapping of errors). I checked all options and upon verifying that everything was uploaded correctly. I then emailed Armin of the sentry team who wrote the official cli tool to ask about this. He confirmed that you need either a comment mapping the minified js to the source map (as webpack does with devtool: sourcemap or a header when uploading the file. (Gist of correspondence: https://gist.github.com/Kamshak/8f6ad2f6c91cabbe15ad7ac04b1efc81). It started working instantly with the header, same config otherwise. This was in March.
Please take a few minutes to test this as it's really not working like that. Are comments perhaps generated in your case? Are we talking about the same thing at all (because earlier you mentioned you keep the comment intact and simply delete the corresponding map before deployment, which is however different than hidden-srouce-map)?

I'm not saying that using headers doesn't work. I'm sure it does.
However Sentry also supports matching the source path to the source map path. That is what this plugin does. It is described on that docs page. Unless Sentry breaks something I think sticking to the simpler solution is better. The plugin seems to work fine for me (the reason I wrote it in the first place) and for other people. You are the only person reporting this.
I'm pretty sure we're talking about the same thing. I'm using hidden-source-map. I've checked that no comments are generated.
I'm not interested in continuing arguing about this. If it doesn't work for you, please maintain your fork.

The problem with this is I have to use the ~/ path and not the full URL.
This is because the same code base I have runs on multiple domains with
minor env changes. So I'm pretty sure this is why it doesn't work for me.
If you're not willing to support other use cases, we could just fork this
to an org. I just don't get what's wrong with using pr's from others that
aren't tailored to your use case. This pr doesn't break anything, just adds
a feature some of us need :) no hard feeling though if this is all you want
it to do. Just might have to fork it into an org though.
On Wed, Apr 12, 2017 at 15:19 Alasdair Smith<EMAIL_ADDRESS>wrote:

I'm not saying that using headers doesn't work. I'm sure it does.
However Sentry also supports matching the source path to the source map
path. That is what this plugin does. It is described on that docs page.
Unless Sentry breaks something I think sticking to the simpler solution is
better. The plugin seems to work fine for me (the reason I wrote it in the
first place) and for other people. You are the only person reporting this.
I'm pretty sure we're talking about the same thing. I'm using
hidden-source-map. I've checked that no comments are generated.
I'm not interested in continuing arguing about this. If it doesn't work
for you, please maintain your fork.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/40thieves/webpack-sentry-plugin/pull/10#issuecomment-293680377,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAbacOXfH2PwTHPbEknu9bec_S97-EgCks5rvSPSgaJpZM4MfGWK
.

I feel like I've repeated myself several times in this thread. Frankly, this is becoming pretty frustrating for me.
I have little time to do OSS. I have to consider this when I accept PRs because any code that I accept becomes a maintenance burden on me. This week I've had a couple of hours, most of which I've spent double and triple checking that the plugin works how I thought. I feel like I've given up a fair bit of my time effectively doing free support for you.
I'd like to put this thread to bed now. I feel like I've laid out my reasoning pretty clearly. I'm sorry that the plugin doesn't work for you but there's nothing stopping you from using the fork or forking it yourself.


Added Sort feature

Solves issue #24

@srinivasu619 Hey, thank you for your PR! I really appreciate your effort. I'm closing this here in favor of #29. Hope I can find more issues and you may contribute again!

@marcuspoehls That's fine. I will try to contribute to another issue :smile:

@srinivasu619 Thank you!


gps: Adaptively clean dirty git repos

What does this do / why do we need it?
Instead of forcing the user to clean up dirty git repositories, we can
take at least basic steps to doing it ourselves - or, if we detect
problems, instructing the user to fix it.
The overhead introduced here is a git status call, which will be
non-negligible on larger repos, but it's probably worth it for the
resilient behavior.
Eventually, once we get to #534, we'll want to issue a warning when we undertake a cleanup.
This needs tests. Also, let's delay merging this until after the next release so that it can percolate on tip for a while.
Might want to also refactor maybeGitSource.try() to do this check earlier, and os.RemoveAll() then try again if it doesn't work.
What should your reviewer look out for in this PR?
Possible failure modes. It'd be great if this attempt at making things better didn't inadvertently make things worse!
Do you need help or clarification on anything?
Which issue(s) does this PR fix?
fixes #1016
fixes #618

uggghhh, appveyor.
@jmank88 care to have a look over this before i merge? note that this'll also disrupt #1250 a bit.

ugh. windows failures. really?

Results of some testing I could do on Windows:
Windows Version: Windows 10 Fall creators update (Build 1709)
Go version: 1.8.5 and 1.9.2 (Tested on both)
Go Env variables: Default. Changed no environment variable explicitly.
1. go get github.com/golang/dep

2. cd into $GOPATH/src/github.com/golang/dep/internal/gps

3. git pull https://github.com/sdboyer/dep.git git-autorecover

4. go test -run=TestGitSourceAdaptiveCleanup

C:\Users\Kanishk\go\src\github.com\golang\dep\internal\gps>go test -run=TestGitSourceAdaptiveCleanup
PASS
ok      github.com/golang/dep/internal/gps      14.452s

5. git checkout 7e96bb29245f7ff4b8bc96aea4cc657e1684f0f6

C:\Users\Kanishk\go\src\github.com\golang\dep\internal\gps>go test -run=TestGitSourceAdaptiveCleanup
PASS
ok      github.com/golang/dep/internal/gps      15.017s

Result: The test case passed for both the git-autorecover branch and the 7e96bb29245f7ff4b8bc96aea4cc657e1684f0f6 commit for both Go 1.8 and 1.9

so yeah, i don't know why that error occurred on appveyor earlier (and i can't reproduce because the parallelism is killing it - i have to get rid of that tonight) but this appears to work on windows. which is tony-the-tiger-level grrrrrrreat news


feat: add border color option

feature: add border color options

Great! This is a feature that's been missing for a long time...


does this support in page or hash links?

i.e.
chapter4

Yes. Hash urls are fully supported.

are they not supported when using history=true by chance? i have:
routes: {
'/': 'home',
'#chapter4': 'chapter4', // not sure if this is necessary i'm really expecting home to be called with a hash parameter of some kind
}
home: function(path, params) {
//...
}
chapter4: function(path, params) {
// ...
}
and if i click the link from my first question the home function is called with path={"": undefined} params=undefined, and if i dump my state object state.path="/"
i'm using<EMAIL_ADDRESS>from npm

Yes, you're mixing concepts here, it's undefined behavior. If you want to use pushState browser history it really only understands paths. Including hash or query params in the route definition really doesn't make sense.

fair enough. then is it either possible to tell react-mini-router to ignore my hash links, or is there any conceptual reason why the hash couldn't be retained and passed into the route functions so i could deal with the hash myself?
e.g. : chapter4: function(path, params, hash) // perhaps hash is a bad naming choice here
if the later doesn't break anything conceptually i'd happily submit a pull request for your review.

If you're using pushState is there something you need to capture in the hash that you couldn't via query param? usually if you're using browser pushState there's no need for the hash in the url.

back when i learned html (like 20 years ago so my knowledge is way out of date) there were two things that could happen when you clicked on a link:

it goes to a different page: link
it scrolls the browser to a location within the current page: link

so with react-mini-router all the type 1 links work fine, but all of the type 2 links are broken because react-mini-router is (i believe) intercepting them, dropping the "#inpage", and calling the route (so taking me to the correct page, but dropping the info needed to scroll).
maybe it's a well known thing (that i just don't know) that in a single page app type 2 links are just not done and you have to use some other tag like <button> with an onclick handler and scroll the page yourself?


Do not load nor compile NIF on Unix

I haven't tested on Windows, so I may have broken stuff. :D

This looks good to me! I haven't setup CI for this repo, but I'll check it on my local machine. There seems to be no issues.

It's now okay to go. Thanks for the PR! 😄


Deleted Django's default permissions.

See #1643. New database build required, not only migrate an old one.
Still open: Permissions of Django apps auth, contentypes and session. @ostcar Any idea how to get rid of them?

You could create a signal, that delets the permissions :)
Or we create a filter in the permission list view that does not return the django permission to the rest api.
Why is it needed to create a new database? It should be possible to create a migration file, that delets the old permission from the database.

Ok. Please merge this. The filter is something extra. Creating an extra migrations file only for the development (we will renew any migration file before final release) can be done by anyone who wants to do this.


EvoSuite and Randoop Tests should have Assertions

Is your feature request related to a problem? Please describe.
When generating ctd-amplified tests, the related EvoSuite and Randoop generated tests should also include assertions.  This will allow for more appropriate validation of regression tests runs.
Describe alternatives you've considered
Currently, I've had to run three different generate paths, in order to have appropriate generated assertions, one each for evosuite, randoop, and ctd-amplified.

@michaelrowe01 Randoop tests are not included in the ctd-amplified test suite, so they don't need assertions. If you run the command generate randoop, the test cases will contain assertions. Hence the above issue refers only to evosuite tests included in  ctd-amplified test suite.


Incorrect behavior on click by the prev button

Incorrect behavior on click by the prev button. Bug is reproduced when options loop and slidesOnScreen are used.

Fixed by #26