Needs two clicks to play in Safari 13.0.5 with preloaded peaks.

Wavesurfer.js version(s): 3.3.1
Browser and operating system version(s): Safari 13.0.5 / MacOS 10.14.6
Code needed to reproduce the issue:
var wavesurfer = WaveSurfer.create({
    container: waveformElement,
    barWidth: 1,
    barGap: 2
  });

wavesurfer.load(url, peaks.data);

playPauseButton.click(function(e) {
   wavesurfer.playPause();
});

Use behaviour needed to reproduce the issue:
In Safari, when clicking the play/pause button the first time, it loads the file but doesn't start to play. It works only when pressing a second time.
I tried to use the backend: 'MediaElement instead for Safari, but even with preload='none' file is being downloaded on page load. I need to have the file loaded on click and not earlier as I have a lot of instances in the page.
Seems to be an AudioContext issue with Safari, but the wavesurfer.playPause(); on click should take care of this.
It works fine in Chrome and Firefox.

@thijstriemstra thanks for updating the issue. Is there any workaround in the meantime?

create the audioContext when the user presses a btn, and pass that to wavesurfer.js at startup using the audioContext option.

@thijstriemstra my instances of wavesurfer.js are rendered at page load to display waveforms. So I can't pass an audioContext if the instance is already created correct?
What I'm wondering is when clicking the play/pause button the first time that calls wavesurfer.playPause(); wavesurfer.js is creating the audioContext and so should make it work.
I did a quick demo that create an audioContext and play a file on click and it works fine in Safari: https://codepen.io/octavez/pen/RwPKyqM
So that looks like it's an issue with wavesurfer.js more than Safari.

I also ran into this today in Safari 13.1 and wavesurfer 3.3.1


[FEA] Support batched full join

Is your feature request related to a problem? Please describe.
Currently full joins require holding the entire left and right table at once so the libcudf full join API can be called.  Requiring the entire tables to be present will often trigger GPU OOM errors, especially if the join explodes.
Describe the solution you'd like
To avoid this, the full join must be implemented in a batched fashion rather than a one-shot approach, but that means we can no longer rely on the libcudf full join API to implement it.  Instead we can implement a full join as a left outer join + right anti join.  For example, we could perform the following steps:

Build a cudf::hash_table with the entire right table
For each batch of the streamed left table, generate the left outer join gather maps
Emit the batch corresponding to the gather maps
Filter the right table's gather map to remove any invalid indices (e.g.: -1 to indicate no corresponding row) and cache it.
After all of the streamed left table batches have been processed, this completes the left outer join portion of the full join.
Now on to the steps to generate the right anti join without re-processing the left table again:
Concatenate all the cached and filtered right table gather maps
Remove all duplicates from the concatenated right gather map
Generate the gather map complement of the concatenated and filtered right gather map
Emit the batches corresponding to the right gather map complement using invalid entries for the left table
That completes the right anti join, and together all the emitted batches form the result of the full join

Almost all the tools necessary to implement the above approach are present in cudf.  A few pieces are missing:

[ ] https://github.com/rapidsai/cudf/issues/9114 tracks adding the ability to generate gather map complements.
[X] https://github.com/rapidsai/cudf/issues/9115 tracks adding Java bindings for cudf::drop_duplicates.

Moving to the backlog based on discussion about this issue.

@jlowe I think we no longer need to have drop_duplicates since the upcoming gather map complement doesn't require the input to be unique.

Based on my comment at https://github.com/rapidsai/cudf/issues/9114#issuecomment-992536580 I think we can implement this without cudf changes.  Copying the text of the updated proposed algorithm below:
Instead of tracking gather maps, we can use a BOOL8 column, the same size as the right table, to track which columns have not been hit. The algorithm would work like this:

Create a BOOL8 column, let's call it the tracking mask, which is the same size as the right table and initialized to all TRUE
For each batch of the left table:

Perform a left outer join with the right table to produce gather maps
Filter the right table gather map to remove any invalid indices and then use the result as a scatter map to scatter a BOOL8 FALSE scalar into the tracking mask.
Use the original gather maps from the left outer join on the left and right table to produce an output batch

After all batches of the left table have been processed, use the tracking mask to filter the right table via apply_boolean_mask.
Combine the filtered right table with null columns for the corresponding left table to emit a batch of all rows in the right table that did not match any rows in the left table. At that point we've emitted batches that comprise a left outer join along with a batch for all rows in the right that didn't match any in the left, and together that forms the result of the full join.

With this approach we can avoid the complication of concatenating, de-duplicating, and complementing gather maps.


Bucket access AWS region related problem

Describe the bug
If nimbella is deployed in AWS in a generic region (for example eu-south-1) you get an error
An error occurred (IllegalLocationConstraintException) when calling the PutObject operation: The eu-south-1 location constraint is incompatible for the region specific endpoint this request was sent to.

To Reproduce
Steps to reproduce the behavior:

Install nimbella in AWS in another region (for example EKSItaly is in eu-south-1)
Run this code:

def main(arg):
    try:
        bucket = nimbella.storage()
        filename = "test.txt"
        file = bucket.file(filename)
        file.save('Expected %s contents' % filename, 'text/plain')
        return { "ok": True}
    except Exception as e:
        return { "error": str(e) }

Expected behavior
ok: True
Screenshots
If applicable, add screenshots to help explain your problem.
Extra informations:
This is what the __NIM_STORAGE_KEY looks like (stripped down of credentials)
NIM_STORAGE_KEY="{\"provider\":\"@nimbella/storage-s3\",\"region\":\"eu-south-1\",\"endpoint\":\"\",\"weburl\":\"https://iogw-eksitaly.nimbella.io\",\"cloudfrontId\":\"XXXX\",\"iamUser\":\"app-buckets-iogw-Y0avZmVH\",\"policyArn\":\"arn:aws:iam::332320267357:policy/app-buckets-iogw-Y0avZmVH\",\"credentials\":{\"accessKeyId\":\"XXX\",\"secretAccessKey\":\"jXXX"}}"

Thanks for finding this @sciabarra. Will have a look...

Check PR#12 for a fix

Having a look at this again.... I appreciate the fix in https://github.com/nimbella/nimbella-sdk-python/pull/12 but before merging I want to replicate the issue preventing the more obvious fix ("pass region") and see if I can fix it. Otherwise - we'll go with what you have... Won't spend too much time on it.

Thanks James - I too am hoping we can fix this issue more directly rather than through the env var. 👍

The issue can be easily replicated deploying in a region non us-east as looks like buckets in that regions are special and does not require the region parameters.
The issue can be fixed without the env vars changing the api and passing the region to the Session object. However honestly I tried and it did not work...

I think I've managed to fix this at the source - see https://github.com/nimbella/nimbella-sdk-python/pull/13
@sciabarra does this work for you? I've tried with the credentials you gave me and had no issues.
Here's the test file I used locally
import nimbella

bucket = nimbella.storage()
filename = "test.txt"
file = bucket.file(filename)
file.save('Expected %s contents' % filename, 'text/plain')

with the __OW_NAMESPACE, __OW_API_HOST and __NIM_STORAGE_KEY env variables set to the parameters you gave me.

I need to rebuild EKS with your PR to test - will do


please respect unicode strings you are given

esprima.parse('a = "привет"') clearly preserves unicode strings in the format supplied
{ type: 'Program',
  body:
   [ { type: 'ExpressionStatement',
       expression:
        { type: 'AssignmentExpression',
          operator: '=',
          left: { type: 'Identifier', name: 'a' },
          right: { type: 'Literal', value: 'привет', raw: '"привет"' } } } ] }

esgen(esprima.parse('a = "привет"')) clearly does not
a = '\u043F\u0440\u0438\u0432\u0435\u0442';

Technically these js-strings are equivalent, but why forego readability?

Use verbatim: "raw" in your escodegen options if you want the literal representation preserved.

thank you!
Does fix the unicode representation, but wraps the expression in a redundant set of parens:
a = ('привет');
PS I have to ask though, why mangle the string literal in the first place?

It's not getting mangled. Those are the same strings. We only have the raw representation and the value. We can render the value using only Unicode escapes if we want, but we can't print all characters in a string literal safely. So I think we only print non-control ASCII characters and escape all others.

can't say I follow. What does render safely mean? Escodegen received both raw and value from the outside world, so someone somewhere both rendered and read them safely. AST is fair game, but I don't understand why it would need to mess with the value. (if you squint a little you might even say that escodegen is breaking its own type-signature by messing with values instead of AST nodes).
More generally here's where I'm coming from. I think escodegen is often used in projects that are required to consume and produce human-readable code, which, seeing how the world writes in more than one language, may on occasion include some unicode. Present behaviour is unexpected to say the least, because it presents itself to a customer as something completely baffling. At the minimum it seems like the wrong default.

:+1:

@vkz

What does render safely mean?

We can't have " in "-delimited strings. We can't have a carriage return or a paragraph separator. To avoid these characters, we can just Unicode escape everything. It's the same string. If you really want to avoid Unicode escapes, use {format: {escapeless: true}} as your escodegen options. But the only way to use the same escapes that you used in your original code is to use the {verbatim: "raw"} option.

right. Chance of us agreeing on the matter seems to be dwindling with each message, so let's not prolong the agony. If I may I'll leave you with these observations:
You already have the string representation in hand and it's clearly not broken, why fear then? Not saying you're wrong especially with security in the mix, but it is the wrong default.

But the only way to use the same escapes that you used in your original code

I'm using Russian not escapes just like other people could've used Japanese, Hindi, etc.

But you very well could have used escapes. See the following program for example.
("\0 \x00 \u0000 0 \x30 \u0030");

There are many ways I could have escaped that string but I chose that way. Preserving this requires the verbatim option. Are you getting it now?

var esprima = require("esprima"),
    esgen = require("escodegen").generate,
    uglify = require("uglify-js");

var exhibit1 = '"\0 \x00 \u0000 0 \x30 \u0030"',
    ast1 = esprima.parse(exhibit1),
    exhibit2 = "'привет'",
    ast2 = esprima.parse(exhibit2);

esgen(ast1);
uglify.AST_Node.from_mozilla_ast(ast1).print_to_string();

esgen(ast2);
uglify.AST_Node.from_mozilla_ast(ast2).print_to_string();

every time uglify-js does this horribly unsafe thing a puppy dies.
Having lost several hours of my life debugging this safe behaviour I feel some friendly trolling is warranted here. There'll be many a poor sobs down the road tripping over this, I'm sure.
NB: Esprima and Escodegen have saved me countless hours, I use them daily and I am absolutely grateful to their authors and maintainers for keeping them open source and providing support.


JSON to YOLO

Hi, I'm creating a new Pull Request which can convert the entire AU-AIR Annotation JSON File to YOLO Format. This will make the whole process very efficient
Please feel free to review the PR script

Hi
Can you please share the annotation file? Unfortunately, I cannot download it from google drive for some reason.

Hi Can you please share the annotation file? Unfortunately, I cannot download it from google drive for some reason.

Hey I had a Repo created over here - https://github.com/souvik0306/AU-AIR-Object-Detection
It has the annotation file and all the required code. Hope that helps!

Great news! Thank you for your help! I will try to use it.


Update/Add Platform Toolset v143 for windows-latest

Tool name
Platform Toolset v143
Tool license
no idea
Add or update?

[X] Add
[ ] Update

Desired version
v143
Approximate size
No response
Brief description of tool
VS2022 was just released, but it is not supported on windows-latest. I can't use windows-2022 either, since that is missing other tools. Platform Toolset v143 would be sufficient for building thru MSBuild.
URL for tool's homepage
https://visualstudio.microsoft.com/vs/
Provide a basic test case to validate the tool's functionality.
No response
Virtual environments affected

[ ] Ubuntu 18.04
[ ] Ubuntu 20.04
[ ] macOS 10.15
[ ] macOS 11
[ ] Windows Server 2016
[X] Windows Server 2019
[X] Windows Server 2022

Can this tool be installed during the build?
That's not what has been done in previous images.

Tool installation time in runtime
No response
Are you willing to submit a PR?
No

Hello @aardappel. Thank you for your request. We've prepared the PR to add Microsoft.VisualStudio.ComponentGroup.UWP.VC to VS2022 (v143). Unfortunately, VS2019 doesn't support v143.

@aardappel what tools prevent you from using windows-2022?

Well he says that the file which is a system admin is locking him out of the PC database so that is why he is unable to login

On 12-Nov-2021, at 4:37 PM, Mikhail Timofeev @.***> wrote:
@aardappel https://github.com/aardappel what tools prevent you from using windows-2022?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/actions/virtual-environments/issues/4468#issuecomment-967016300, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT42EICWZCQJ7TS4MK46RHLULTYNXANCNFSM5HY2XIWQ.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Not exactly sure why, but I got this with the 2022 image:
Run<EMAIL_ADDRESS>C:\ProgramData\Chocolatey\bin\vswhere.exe -products * -requires Microsoft.Component.MSBuild -property installationPath -latest
Error: Unable to find MSBuild.

see run: https://github.com/aardappel/lobster/runs/4170461751?check_suite_focus=true

Hello @aardappel. I've tried to reproduce the issue, but step - name: Add msbuild to PATH was successful.

@aardappel you error was related to the preview version of the Visual Studio 2022, it is fixed in 1.0.3 version of the task https://github.com/microsoft/setup-msbuild/releases/tag/v1.0.3
But since the stable VS version was released you can continue using 1.0.2 without any issues — it should work now as @dibir-magomedsaygitov just checked

Thanks, with 1.0.3 this now builds with windows-2022!


DRILL-4215: Transfer ownership in TransferPair

Only commit 79bbfcb is part of this PR. But since the other commits haven't been merged to master, they are also showing up in this PR.

@StevenMPhillips, can you close?

Got merged.


Fix typos

@rthery I'm taking a look through your fork branches mentioned in #42 and opening PRs where appropriate to try and get some of your helpful work on this project merged in. Hope this is OK!
I'm helping out with maintenance now, so I can action these when they're ready to merge.

@robinnorth No problem at all, feel free to merge what you want. IIRC I tried to have branches for each things, to make it easier to merge if needed ;)
Let me know if you have questions on some stuff!

@rthery thank you! Your separate branches are indeed very helpful. This particular branch has a merge conflict, would you like to rebase it on master so I can merge? If not, I'll take care of it soon. Cheers!

No problem, I resolved the conflict, although I just realized you mentioned rebasing but I merged instead out of habit, I hope it's ok!

Thank you @rthery, that's great!


Update to use latest HL2SS APi

Update HL2SS submodule to latest commit, which changes the image payload call slightly.

Closing in favor of #208


Can I run the rest assured test using junit ?

Basically this is for reporting and I want the runner to give me a json report, which I can send through my JSON parser to get a nice looking HTML report

ok? Does this have anything to do with REST Assured?

Thats what I am asking. If I can run using junit, I can do this in JUNIT. But I am not able to run the example tests using junit from command line

You can use JUnit or TestNG or another test library. How to configure these libraries are out of scope of the rest assured project.


Error-handling middlewares behaviour : docs vs. execution

I'm trying to grasp the error-handling behaviour of Express.js through the docs, which state that If you pass anything to the next() function (except the string 'route'), Express regards the current request as being an error and will skip any remaining non-error handling routing and middleware functions.
const express = require('express');
const bodyParser = require('body-parser');

const app = express();

app.use(bodyParser.json());
app.use(bodyParser.urlencoded({ extended: true }));

app.use(express.static('public'));

const checkThing1 = (req,res,next) =>{
  console.log('checkThing1')
  next('This is an error !')
}

const checkThing2 = (err,req,res,next) =>{
  if(err) console.log("Error2 is ", err)
  console.log('checkThing2')
  next()
}

const checkThing3 = (err,req,res,next) =>{
  if(err) console.log("Error3 is ", err)
  console.log('checkThing3')
  next()
}

const checkThing4 = (req,res,next) =>{
  console.log('checkThing4')
  next()
}

const checkThing5 = (req,res,next) =>{
  console.log('checkThing5')
  next()
}

app.get('/',[checkThing1,checkThing2,checkThing3,checkThing4,checkThing5], (req, res) => {
  console.log('Route => "/"')
});

app.listen(3000, () => console.log('server started'));

Output :
checkThing1
Error2 is  This is an error !
checkThing2
checkThing4
checkThing5
Route => "/"

You can run the code here : https://repl.it/@younesherlock/BitterInvolvedDowngrade
It seems that when Express meets a next('someRrrorMessage'), it considers that the current request is an error, so itskips all non error-handling middlewares until the closest error-handling middleware; then it executes it, and then continues executing the other non error handling middlewares remaining in the chain.
I just think it's just not very clear in the docs  and I'd like to know if this understanding is correct ? Are there others aspects that aren't covered here ? Can you please clarify ?

@younesherlock Is the confusion you’re having around why middleware after the error handling one are getting run when you encounter an error?  It’s generally best practice to put error handling middleware after all other middleware to avoid this.
If this wasn’t clear from the docs, a PR would certainly be welcome adding clarification.

Since the question was answered and no response to @ryhinchey I'm going to close this out. And to add some more clarity: the error handler checkThing2 in the example called next() without an error, re-entering into the non-error flow. This is allowed as an error middleware can determine an error is recoverable and recover back into the flow.


[Suggestion] Able to disable particles when wearing a full set

What the title says. I want to be able to disable the resistance particles when wearing a full set but I also want my particles in my settings to still be on. Maybe add an option in the config file to disable it or disable it in general.
Version I am using
1.5
Fabric, loader version: 0.14.22
1.20.1

soon in version 1.6


Missing example/usage for options for realHover in the ReadMe

Current behaviour
The user wants to change options for realHover but they can't find any examples in the ReadMe/Documentation showing how to do that. Instead, the user needs to google for an example or needs to trial and error through their code.
Expected behaviour
The options for realHover have an example showing how to implement these options for realHover
ToDo
Add an example/usage (I can do that as I have been through the current behaviour and found a solution)

:tada: This issue has been resolved in version 1.6.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


cache.json & distributions.yml have wrong permissions in global mode

In global mode, cache is not readable by users.
While sudo is required for mutations, being able to read cache & distributions unprivileged in global mode is a must.
total 136
drwxr-xr-x  2 root root   4096 May  6 13:57 .
drwxr-xr-x 17 root root   4096 May  6 13:57 ..
-rw-r-----  1 root root 127172 May  6 13:57 cache.json

fixed in v0.19.3


chore: bump roughjs version

This fixes 2 bugs that affect excalidraw:
https://github.com/rough-stuff/rough/issues/199
https://github.com/rough-stuff/rough/issues/197
fix https://github.com/excalidraw/excalidraw/issues/4378

Thanks for the fixes and bump @pshihn ❤


125819 Fix h2 heading

125819 Fix h2 heading: explore our projects
Modified h1 and h2 heading default font sizes (and tailwind text-* classes) to reflect design here
Test Instructions

Go to homepage and see that "Explore our Projects" heading reflects design

Definition of Done

[x] Update CHANGELOG

A pull request preview is being generated. Hold tight!

Check out a preview of your pull request here: https://alphasite-appservice-dev-pr-preview-1401868363.azurewebsites.net

A pull request preview is being generated. Hold tight!

Check out a preview of your pull request here: https://alphasite-appservice-dev-pr-preview-1401868363.azurewebsites.net

A pull request preview is being generated. Hold tight!

Check out a preview of your pull request here: https://alphasite-appservice-dev-pr-preview-1401868363.azurewebsites.net

A pull request preview is being generated. Hold tight!

Check out a preview of your pull request here: https://alphasite-appservice-dev-pr-preview-1401868363.azurewebsites.net

A pull request preview is being generated. Hold tight!

Check out a preview of your pull request here: https://alphasite-appservice-dev-pr-preview-1401868363.azurewebsites.net


Beta5 introduces error with System.Buffers

Hello All,
I'm currently building an application that's targeting a few different framework versions, including .net 4.5.2. (we're stuck with this for a little while on that project).
We are getting this odd build issue when targetting version beta0005 of SixLabors.ImageSharp, which references SicLabors.Core version beta0006.
The issue is that when running under .net 4.5.2 (this may happen elsewhere too), we get the following error:
Exception has been thrown by the target of an invocation. There was an error trying to auto-sign the label file. The type initializer for 'SixLabors.ImageSharp.Configuration' threw an exception. Could not load file or assembly 'System.Buffers, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)
The version being loaded of System.Buffers is <IP_ADDRESS> and not <IP_ADDRESS>, which is why things fail. If we copy <IP_ADDRESS> back in, everything seems to work just fine again.
I reverted back to beta4 (which uses beta5 of core), and things are working again, everything is pointing back to the right versions.
Any idea why this is happening?
Thanks!

What format is your csproj? The old package.config format or the new SDK  style?
If it's the old style, I would recommend using the new style and adding the following lines to the project file.
    <RestoreProjectStyle>PackageReference</RestoreProjectStyle>
    <AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>

We may want to downgrade to System.Buffers to v4.4.0 to reduce the need for binding redirects. The library ecosystem never adopted v4.5.0.
PR coming.

Sorry for the late reply, I'm using the new style csproj.

@ericdunn Did we resolve the conflict in Beta6?

I'll have a look at this tomorrow and will let you know!
Thanks!
Eric.

The problem now is that because of
https://github.com/SixLabors/Core/commit/7443aefea06e04a1d0a7bac10b5e6026adb16de4
upping the min version to netstandard1.3 (.net 4.5.2 would be netstandard1.2), I can't install the package :/

I'm afraid you'll just have to update. 1.3 is our minimum, it all gets too complicated to build otherwise.


Fail to load TheBloke/tulu-2-dpo-70B-AWQ on A800*2: TimeoutError: result expired

Thanks for your great work!
I am trying to load the AWQ model of Tulu-2-dpo-70B, here is my command line input:
CUDA_VISIBLE_DEVICES=0,1 python -m sglang.launch_server --model-path TheBloke/tulu-2-dpo-70B-AWQ --tokenizer-path TheBloke/tulu-2-dpo-70B-AWQ --port 30000 --mem-fraction-static 0.5 --tp-size 2
And it took me over 20 min to load the checkpoint into GPU memory, and I finally get the error:
server started on [<IP_ADDRESS>]:10011
accepted ('<IP_ADDRESS>', 51884) with fd 6
welcome ('<IP_ADDRESS>', 51884)
accepted ('<IP_ADDRESS>', 40934) with fd 6
welcome ('<IP_ADDRESS>', 40934)
Rank 1: load weight begin.
quant_config: AWQConfig(weight_bits=4, group_size=128, zero_point=True)
Rank 0: load weight begin.
quant_config: AWQConfig(weight_bits=4, group_size=128, zero_point=True)
Rank 1: load weight end.
router init state: Traceback (most recent call last):
  File "/home/share/likai/sglang/python/sglang/srt/managers/router/manager.py", line 68, in start_router_process
    model_client = ModelRpcClient(server_args, port_args)
  File "/home/share/likai/sglang/python/sglang/srt/managers/router/model_rpc.py", line 521, in __init__
    rets = [obtain(x) for x in executor.map(init_model, range(tp_size))]
  File "/home/share/likai/sglang/python/sglang/srt/managers/router/model_rpc.py", line 521, in <listcomp>
    rets = [obtain(x) for x in executor.map(init_model, range(tp_size))]
  File "/home/likai/.conda/envs/powerinfer/lib/python3.10/concurrent/futures/_base.py", line 608, in result_iterator
    yield fs.pop().result()
  File "/home/likai/.conda/envs/powerinfer/lib/python3.10/concurrent/futures/_base.py", line 445, in result
    return self.__get_result()
  File "/home/likai/.conda/envs/powerinfer/lib/python3.10/concurrent/futures/_base.py", line 390, in __get_result
    raise self._exception
  File "/home/likai/.conda/envs/powerinfer/lib/python3.10/concurrent/futures/thread.py", line 52, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/home/share/likai/sglang/python/sglang/srt/managers/router/model_rpc.py", line 519, in init_model
    return self.model_servers[i].init_model(i, server_args, port_args)
  File "/home/likai/.conda/envs/powerinfer/lib/python3.10/site-packages/rpyc/core/netref.py", line 240, in __call__
    return syncreq(_self, consts.HANDLE_CALL, args, kwargs)
  File "/home/likai/.conda/envs/powerinfer/lib/python3.10/site-packages/rpyc/core/netref.py", line 63, in syncreq
    return conn.sync_request(handler, proxy, *args)
  File "/home/likai/.conda/envs/powerinfer/lib/python3.10/site-packages/rpyc/core/protocol.py", line 718, in sync_request
    return _async_res.value
  File "/home/likai/.conda/envs/powerinfer/lib/python3.10/site-packages/rpyc/core/async_.py", line 106, in value
    self.wait()
  File "/home/likai/.conda/envs/powerinfer/lib/python3.10/site-packages/rpyc/core/async_.py", line 55, in wait
    raise AsyncResultTimeout("result expired")
TimeoutError: result expired
detoken init state: init ok

Could you please help me check it? Thank you so much.

Could you try to run the command again? The first time it may require downloading which can take a lot of time.

Could you try to run the command again? The first time it may require downloading which can take a lot of time.

I updated sglang to the latest version and ran it again.
Get the similar output on 2 V100 GPUs. Probably not because of the model downloading issue, since the model was already downloaded.
My input:

Then it get stuck on finish loading weight on Rank 0 for like 20 mins
output:
```server started on [<IP_ADDRESS>]:10004
server started on [<IP_ADDRESS>]:10005
accepted ('<IP_ADDRESS>', 60712) with fd 25
welcome ('<IP_ADDRESS>', 60712)
accepted ('<IP_ADDRESS>', 40380) with fd 25
welcome ('<IP_ADDRESS>', 40380)
Rank 1: load weight begin.
quant_config: AWQConfig(weight_bits=4, group_size=128, zero_point=True)
Rank 0: load weight begin.
quant_config: AWQConfig(weight_bits=4, group_size=128, zero_point=True)
INFO 02-19 15:51:07 weight_utils.py:164] Using model weights format ['*.safetensors']
INFO 02-19 15:51:07 weight_utils.py:164] Using model weights format ['*.safetensors']
Rank 1: load weight end.
router init state: Traceback (most recent call last):
  File "/home/data2/likai/sglang/python/sglang/srt/managers/router/manager.py", line 68, in start_router_process
    model_client = ModelRpcClient(server_args, port_args)
  File "/home/data2/likai/sglang/python/sglang/srt/managers/router/model_rpc.py", line 628, in __init__
    rets = [obtain(x) for x in executor.map(init_model, range(tp_size))]
  File "/home/data2/likai/sglang/python/sglang/srt/managers/router/model_rpc.py", line 628, in <listcomp>
    rets = [obtain(x) for x in executor.map(init_model, range(tp_size))]
  File "/home/likai/.conda/envs/sglang/lib/python3.10/concurrent/futures/_base.py", line 608, in result_iterator
    yield fs.pop().result()
  File "/home/likai/.conda/envs/sglang/lib/python3.10/concurrent/futures/_base.py", line 445, in result
    return self.__get_result()
  File "/home/likai/.conda/envs/sglang/lib/python3.10/concurrent/futures/_base.py", line 390, in __get_result
    raise self._exception
  File "/home/likai/.conda/envs/sglang/lib/python3.10/concurrent/futures/thread.py", line 52, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/home/data2/likai/sglang/python/sglang/srt/managers/router/model_rpc.py", line 626, in init_model
    return self.model_servers[i].init_model(i, server_args, port_args)
  File "/home/likai/.conda/envs/sglang/lib/python3.10/site-packages/rpyc/core/netref.py", line 240, in __call__
    return syncreq(_self, consts.HANDLE_CALL, args, kwargs)
  File "/home/likai/.conda/envs/sglang/lib/python3.10/site-packages/rpyc/core/netref.py", line 63, in syncreq
    return conn.sync_request(handler, proxy, *args)
  File "/home/likai/.conda/envs/sglang/lib/python3.10/site-packages/rpyc/core/protocol.py", line 718, in sync_request
    return _async_res.value
  File "/home/likai/.conda/envs/sglang/lib/python3.10/site-packages/rpyc/core/async_.py", line 106, in value
    self.wait()
  File "/home/likai/.conda/envs/sglang/lib/python3.10/site-packages/rpyc/core/async_.py", line 55, in wait
    raise AsyncResultTimeout("result expired")
TimeoutError: result expired


add json decode error import

What kind of change does this PR introduce?
Bug fix
What is the current behavior?
JSONDecodeError is used but wasn't imported
What is the new behavior?
JSONDecodeError is imported
Additional context
Add any other context or screenshots.

Missed this - thanks @silentworks


[Mysql] az mysql flexible-server import create: Adding support for operation progress textual bar for az mysql flexible-server import create command for import from storage

flexible-server import command for import from storage
Related command

az mysql flexible-server import create
Description

Adding support for operation progress textual bar for az mysql flexible-server import create command for import from storage.
Current behavior:
Currently only Running is shown when the import is in progress.
This change behavior:
After this change for import create command for data-source azure-blob, the different status and ETA will be visible to user when import is in progress.

Testing Guide

Tested in dogfood.
az mysql flexible-server import create -g rishabhkumar-group --name rishtestcli3112 --location northeurope --data-source-type azure_blob --data-source "https://rishpercona.blob.core.windows.net/mysqlvm-57-1tb" --data-source-backup-dir data --version 5.7 --storage-size 2048 --% --data-source-sas-token  "${sasToken}"
History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

Thank you for your contribution! We will review the pull request and get back to you soon.

Please fix CI issues.

Please fix CI issues.

Done


[ENH] daily dev snapshot release on pypi

scikit-learn has daily dev snapshot releases on pypi, see here:
https://github.com/alan-turing-institute/sktime/issues/3037#issuecomment-1188214203
Might be useful to also do this, so the development version install gets more accessible?
Should be possible vie adding a GitHub action.
Opinions, @lmmentel, @freddyaboulton?
I'd be in favour.
Thanks for pointing this out, @celestinoxp!

More details about scikit-learn develop installation: https://scikit-learn.org/stable/developers/advanced_installation.html#installing-nightly-builds

Does PyPI support a dev environment? I see that sklearn uses pypi.anaconda.org which suggest a "clone" or self-hosted pypi server.

@lmmentel Yea I think your can host your own pypi server!
But I don’t think that’s needed. If the goal is to install the latest sktime with pip, those interested can install the main branch via GitHub the url with pip.
This should work since sktime does not have compiled extensions anymore. This article explains how to do it:
https://simonwillison.net/2022/Apr/24/pip-install-github/

I think that solves it @freddyaboulton, maybe we only need to update the docs on how to install the latest from main with pip to close this?

Other suggestion is use "--pre". Somethig like pycaret, to install latest version can use this command: pip install --pre pycaret.
Question: It is possible use "--pre" to latest version on github, and normal pip without "--pre" to latest stable version?
example:

sktime 0.13.0 --------> pip install sktime
sktime 0.13.1-dev ---> pip install --pre sktime

Using pre flag would require to publish a tagged Prerelease version to pypi, installing from main seems way simpler.

ups looks like I made a mistake...
installing from source is simple:
pip install https://github.com/alan-turing-institute/sktime/archive/refs/heads/main.zip
It's simple. Thank you all

So... should we do this, or is all fine as is?

Agree with @lmmentel 's suggestion. I think we can add a sentence here showing how to install from github via url and then close:

ok, anyone want to add that sentence? 😄


libswoc: Replace IpMap in ControlMatcher.

No, we can't remove IpMap yet. I tried that and it ended up being a very large PR. As I'm constantly told to do, I'm breaking it down into specific uses of IpMap and fixing those.


Something for #62

Here's a failing example so far ...
Reproduce with:
     $ python examples/example_blueprint.py

Nice, I'll merge this and then work to fix it. thanks

Cool, thanks!


Question: Recommended storage limits

I couldn't find anything on this other than this comment saying there are no enforced limits. Given there are no set limits, what is the recommended value size limit, maximum number of keys and overall database limit? Like most, I use etcd for configuration, which is currently less than 10KB. How would etcd deal with 1K keys totalling 1MB? 1M keys at 1GB?

The recommended value size is < 1MB. As @xiang90 says, etcd targets at 'a consistent data store that serves small value', so we don't expect users will put large value into etcd.
the overall database limit is < 25MB. This is restricted by memory usage overhead(#2662, #2657) and slow snapshot recovery now. We are working hard at https://github.com/coreos/etcd/issues/2647 to improve this.

Thanks for the info @yichengq and keep up the good work :+1:

@yichengq
What are "recommended value size" and "overall database limit" for etcdv3 current release (v3.1.1)?
Please let me know if I should open a new issue for this.

What are "recommended value size" and "overall database limit" for etcdv3 current release (v3.1.1)?

I want to know this too

What are "recommended value size" and "overall database limit" for etcdv3 current release (v3.1.1)?

I want to know this too

https://coreos.com/etcd/docs/latest/dev-guide/limit.html


Store Scope in effect

Fixes #1

Continuing the discussion from https://github.com/TristanCacqueray/ki-effectful/issues/1#issuecomment-1214475944 , could we use localStaticRep to create nested scope (as demonstrated in https://github.com/TristanCacqueray/ki-effectful/commit/9f440bd1bb35b6ce24e984cfea7cade7ff6e248e ). That seems to compile and pass the tests, but is it safe?
It sounds important to enable creating new scope through the StructuredConcurrency effect (without using IOE), but perhaps this should be considered as an extra effect?

Oh, yes, that work! Totally forgot about localStaticRep... Note this is only safe since we cloned the environment before. I will change that in the PR.

That's great, thank you! I'll add the missing api, e.g. forkWith, and I think we can publish this shortly to hackage.


Fix Kitsu API docs link

kitsu17 was a temporary apiary page - its now just kitsu.
Also fixed the HTTPS column as it has always been HTTPS-only

Travis failure is due to Steam's API currently 500ing

Thanks!


Support cutomising TLS configuration

Add -tls_config command line option to allow specifying either "intermediate" or "modern" TLS configuration based on recommendations at https://wiki.mozilla.org/Security/Server_Side_TLS, allowing for disabling of older TLS versions.
CurveP384 is not included in CurvePreferences as there is no optimized implementation in Go.
Default configuration is unchanged, so if no -tls_config parameter is specified existing behavior is maintained.
I recognize this is somewhat unnecessary, given that there's no real risk from using TLS 1.0 for speed tests, but this helps tick boxes in corporate security compliance checklists.

This change is

Pull Request Test Coverage Report for Build 1443

5 of 31 (16.13%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-1.0%) to 80.737%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

ndt-server.go
5
31
16.13%

Totals

Change from base Build 1441:
-1.0%

Covered Lines:
1731

Relevant Lines:
2144

💛  - Coveralls

The build "failure" is due to exceeding docker hub rate limits when creating the image:
anyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit

Hi @nosnilmot, thank you for your contribution!
Do I understand correctly that this change is mostly for users who are deploying their own instance of ndt-server?
I agree with allowing users to tick boxes on corporate security compliance checklists, but I would propose implementing it as a simple -tls1.3 flag to enforce TLS 1.3 where needed and leaving the choice to the crypto/tls library otherwise.
When using TLS 1.3:

the list of CipherSuites isn't configurable. The available options are:

	// TLS 1.3 cipher suites.
	TLS_AES_128_GCM_SHA256       uint16 = 0x1301
	TLS_AES_256_GCM_SHA384       uint16 = 0x1302
	TLS_CHACHA20_POLY1305_SHA256 uint16 = 0x1303

    // CipherSuites is a list of supported cipher suites for TLS versions up to
    // TLS 1.2. If CipherSuites is nil, a default list of secure cipher suites
    // is used, with a preference order based on hardware performance. The
    // default cipher suites might change over Go versions. Note that TLS 1.3
    // ciphersuites are not configurable.

the preference order is based on hardware performance. For instance, since Go1.16 the server won't use AES if the client does not signal a preference for it or the server itself doesn't have hardware support, which is the case for, e.g., ARMv7 CPUs without cryptographic extensions. By specifying a custom list, these automatisms are lost.

CurveP384 is enabled, but it also comes after both X25519 and CurveP256 in the preference list (defaultCurvePreference on line 978) meaning - if I understand correctly - it will only be used as a last resort.

As a general rule, we would like to take advantage of Go's crypto/tls library when it comes to determining which suite to use, as they are in a better position to assess which algorithms have better support/performance to be used preferentially at a given point in the library's development.
It's also true that, as you mentioned, the NDT5 and ndt7 protocols just send a stream of random bytes so there isn't anything confidential. The main reasons for using TLS are simulating a real-world condition (where most of the traffic is encrypted, nowadays) and preventing middleboxes from compressing the data in case a client doesn't randomize the message properly during the upload measurement.
Would a -tls1.3 command-line flag as proposed above fit your use case? Or perhaps -tls.version which could be 1.2 or 1.3 and set the MinVersion field of tls.Config accordingly?

Hi @robertodauria, thanks for the feedback.

Do I understand correctly that this change is mostly for users who are deploying their own instance of ndt-server?

Yes, that's correct, sorry for not being explicit about this originally. I assume public servers want to have the broadest possible client support, at least in the short term.

When using TLS 1.3:

Snip lots of useful info. Good to see the cipher suite selection pretty much matches what I wanted anyway.

As a general rule, we would like to take advantage of Go's crypto/tls library when it comes to determining which suite to use, as they are in a better position to assess which algorithms have better support/performance to be used preferentially at a given point in the library's development.

On cipher suite selection I agree, after this education.

It's also true that, as you mentioned, the NDT5 and ndt7 protocols just send a stream of random bytes so there isn't anything confidential. The main reasons for using TLS are simulating a real-world condition (where most of the traffic is encrypted, nowadays) and preventing middleboxes from compressing the data in case a client doesn't randomize the message properly during the upload measurement.

Understood.

Would a -tls1.3 command-line flag as proposed above fit your use case? Or perhaps -tls.version which could be 1.2 or 1.3 and set the MinVersion field of tls.Config accordingly?

I'm not sure we can jump straight to 1.3 across the board yet, so would prefer the flexibility to specify minimum of either 1.2 or 1.3.
I think with these changes this PR might fit your suggestions?

change flag from "-tls_config" to "-tls.version"
change values from "intermediate, modern" to "1.2, 1.3"
remove specification of preferred curves and cipher suites

If you agree, can you let me know if you prefer those changes as an additional commit to this branch/PR, or if you prefer them to be rebased and force-pushed (or in a new PR)?

change flag from "-tls_config" to "-tls.version"
change values from "intermediate, modern" to "1.2, 1.3"
remove specification of preferred curves and cipher suites

If you agree, can you let me know if you prefer those changes as an additional commit to this branch/PR, or if you prefer them to be rebased and force-pushed (or in a new PR)?

Either adding new commits on top of this PR or creating a new one entirely (+ referencing this one for visibility into the discussion) sounds good to me. I like the -tls.version=(1.2|1.3) flag. Thanks! :)

I pushed the agreed changes in https://github.com/m-lab/ndt-server/pull/333/commits/db61651fd896dfb60c3880f2257d4a6342027392 is there anything else you want from me to be able to merge this?


Scatter plot implementation for bokeh

Two dimensional bokeh scatter plot for pixiedust.

@chetnawarade : implementation looks good, but you have a reference to histogramDisplay in the __init.py file but the file doesn't exist in the branch.

Correct histogramDisplay is leftover. histogramDisplay.py is local to my branch and not ready.

removed from .histogramDisplay import * line from init.py, committed to plotting-tools branch. If build passes, I will try to update/merge with this PR or open new. New to github, still learning nuances.

Looks like merging PR should bring in removal of line from .histogramDisplay import * in init.py to your branch @DTAIEB.


Better Debug Bar placement

I love the fact that the debug bar can be floating on top regardless of what tab I have open on the side. But I would like if the text editor could have a extra space like it does for the Find and Replace box when its floating on top of the editor. I find myself dragging it around quite a lot when I have file with longer first and second lines. especially opening none formatted .json or log files for debugging reasons.
Example with extra space as seen with the Find and Replace bar

this is the way it looks now.

I also just realized that the same thing happens when the find and replace window is open. The first line only adjusts for the find window and not far enough for the replace one


TODO's post clinic

Just a few ideas as followup for @virdi from the Clinic

consider having them create their own repo in their GitHub account so they'll have push access
reorder the "git clone" step to be before step 3

I can help, and @betolink too :)

creating a very detailed, beginner-friendly, step-by-step git setup section to be followed along by just copy/paste and clicking on links

The clinic section looks good, we can create another issue if we need further enhancements


Check if there's a network request already in flight

Make sure not to fire off additional requests if there's already one in-flight. I chose to reflect this on the element through the read-only busy attribute.
Fixes #75

This probably needs a failing test before the fix commit.

Seems reasonable. Is it instead better to use AbortControllers to close previous requests, so that we always use the latest request?

Yeah, I think we could. I wanted to avoid doing multiple requests altogether though since I thought that was an error in itself.

Seems reasonable. Is it instead better to use AbortControllers to close previous requests, so that we always use the latest request?

Yeah, I think we could. I wanted to avoid doing multiple requests altogether though since I thought that was an error in itself.

I was gonna do this but then we still emit the event twice because #getData still fetches data from the WeakMap and we happily emit the event.


getaddrinfo ENOTFOUND building errror for On-Prem TFS2015

Followed the On Prem Server guide verbatim
https://github.com/Microsoft/vso-agent/blob/master/docs/onprem.md

./run.sh
Enter alternate username > Glenn Wester
Enter alternate password >
Enter server url > http://desktop-o5d5tlk.local:8080/tfs/
Enter agent name (enter sets Glenns-MacBook.local)  > previewMacbook1
Enter agent pool name (enter sets default)  >
Enter force basic (enter is false)  > true
successful connect as undefined
Retrieved agent pool: Default (1)

I am able to get the agent to connect correctly and it shows in the 'Agent Pools' in green as a connected agent, however when I try to build a Xamarin.iOS app I get the following error:
##[Error] 2016-03-02T18:10:28.080Z: getaddrinfo ENOTFOUND desktop-o5d5tlk desktop-o5d5tlk:8080
When I specify '.local' in Enter server url > http://desktop-o5d5tlk.local:8080/tfs/, this is not showing in the two listed domains in the error line above. From my Mac I cannot connect using desktop-o5d5tlk:8080, it must be desktop-o5d5tlk.local:8080 but it seems that being ignored during building.

Can you supply some context around that single error line?  Is it when it's rnning the xamarin task or before it runs the xamarin task?  Does it get code and then fail in the xamarin task?  Trying to figure out if I should route to who owns the xamarin task.
The other possibility is it's failing when it's trying to download the tasks up front (before get code).  If that's the issue, then it's likely due to something that was already fixed in the preview 0.5.x version of the agent.  Notice how you connect to the queue using .local but the url it can't connect to does not have .local.  The reason is the server sends the url it knows itself by (admin console notification url) in the job message.  The fix in the 0.5.x agent was to use the hostname from the url you connected to (linux/OSX agent owns how it knows the server by) and the path from the url sent from the server in the job message.
While you could change the notification url in the admin console to have .local - that wouldn't be a good idea because then you couldn't use some mail links etc... from the server or windows boxes.  This is the reason we made that change in the 0.5.x agent.

got the same problem.
working with a ubuntu against TFS 2015 repository
it seems that although you define  in Enter server url > "http://tfs2015.local:8080/tfs, it does not add it when it gets the path from tfs.
when it connects to tfs and gets all params for setup
it will not be taken .
In my log i see "type":"TfsVersionControl","url":"http://tfs2015:8080/tfs/TFS2015-TEST/",
and then  getaddrinfo ENOTFOUND tfs2015 tfs2015:8080.
IMHO , i have a feeling that MS has not fully understood and tested the linux environment and its VSO agent . I would love to be mistaken.

This is actually well understood.  We also test and self-host (agent runs the builds that builds itself) on many Linux variants and OSX daily.
There was a bug fix in the agent to handle this case.  What version of the agent do you have?

Dupe of https://github.com/Microsoft/vso-agent/issues/190

I got it to work finally. added the local network in conf file
here is what i did:
added in /etc/resolve.conf this line
domain  .local
and in /etc/network/interfaces
dns-search .local
got the sources from TFS directly onto ubuntu now,
have a issue now with :
Forbidden(403) - Access denied: {user} does not have write permissions for orchestration plan
Permissions of {user} are properly defined in the Agent Pool
Thanks Bryan, your comments are helpful

@csternbu "Forbidden(403) - Access denied: {user} does not have write permissions for orchestration plan" - this shouldn't be a problem. can be ignored or while configuring the agent choose "force basic = false"


Compose collectAsState : Type 'State<>' has no method 'getValue(Nothing?, KProperty<*>)' and thus it cannot serve as a delegate

I'm getting this compilation error while accessing a state in a composable:
e: /compose/impl/src/main/java/com/impl/sheet/SheetComposable.kt: (18, 18): Type 'State<SheetState>' has no method 'getValue(Nothing?, KProperty<*>)' and thus it cannot serve as a delegate

The code :
class SheetState(
    val foo: String,
)

class SheetViewModel(
    initialState: SheetState
) : MavericksViewModel<SheetState>(initialState)

@Composable
fun Sheet() {
    val viewModel: SheetViewModel = mavericksViewModel()
    val state by viewModel.collectAsState() // Type 'State<SheetState>' has no method 'getValue(Nothing?, KProperty<*>)' and thus it cannot serve as a delegate
    Sheet(state)
}

@Preview
@Composable
fun Sheet(state: SheetState) {
    ...
}

Using Mavericks 2.6.1 - Compose 1.1.1 - Kotlin 1.6.10
Any idea what's happening?

@eboudrant You're missing an import. This is a generic Compose tooling issue.
https://stackoverflow.com/questions/63875411/type-statelistuser-has-no-method-getvaluenothing-kproperty-and-t


'moby build -hyperkit' doesn't work

I was excited to try a moby build -hyperkit 😁
I was upset to see it ignored and qemu was used instead 😕
I was even more confused to see that the hyperkit bool is completely ignored https://github.com/moby/tool/blob/master/cmd/moby/linuxkit.go#L129 😖
It'd be nicer to warn the user if it isn't supported or perhaps drop the flag until such time as it's implemented.

It did work for a while, but now needs support for multiple disks in the
hyperkit Go API to make it work.
On 2 Jun 2017 21:17, "Dave Tucker"<EMAIL_ADDRESS>wrote:

I was excited to try a moby build -hyperkit 😁
I was upset to see it ignored and qemu was used instead 😕
I was even more confused to see that the hyperkit bool is completely
ignored https://github.com/moby/tool/blob/master/cmd/moby/linuxkit.go#L129
😖
It'd be nicer to warn the user if it isn't supported or perhaps drop the
flag until such time as it's implemented.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/moby/tool/issues/68, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAdcPA_VCt5y8d4k1PDzvFUW_OOCg-Wlks5sAG3vgaJpZM4NuvFT
.


CC0001: Conflicting with Intellicode

Bug
Conflicting with Intellicode.
Code
//the code that reproduces the bug
KeyValuePair<HttpStatusCode, string> identityUserId = appCreate.FirstOrDefault(x => x.Key == HttpStatusCode.Continue);

Current output after fix applied (if it is a code fix bug):
codecracker

intellicode

//code fixed incorrectly
KeyValuePair<HttpStatusCode, string> identityUserId = appCreate.FirstOrDefault(x => x.Key == HttpStatusCode.Continue);

Expected output after fix applied (if it is a code fix bug):
same code without analysis
// Expected output after fix applied (if it is a code fix bug):
KeyValuePair<HttpStatusCode, string> identityUserId = appCreate.FirstOrDefault(x => x.Key == HttpStatusCode.Continue);

ok @giggio


Decorations from multiple extensions interfering with each other

Version: 1.43.0-insider (user setup)
Commit: e6a45f4242ebddb7aa9a229f85555e8a3bd987e2
Date: 2020-02-21T05:42:20.536Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.17763
Decorations from multiple extensions seems to be interfering with each other. In the example below, I create a decoration that append text in red at the cursor location. However, with the GitLens  extension enabled side-by-side, the decoration is being moved by the GitLens extension.
Code:
import * as vscode from "vscode";

export function activate(context: vscode.ExtensionContext) {
  const decorationType = vscode.window.createTextEditorDecorationType({});
  const updateDecoration = () => {
    const activeEditor = vscode.window.activeTextEditor;
    if (activeEditor) {
      const decorationOptions = [
        {
          range: new vscode.Range(
            activeEditor.selection.active,
            activeEditor.selection.active
          ),
          renderOptions: {
            after: {
              contentText: "text",
              color: "red"
            }
          }
        }
      ];
      activeEditor.setDecorations(decorationType, decorationOptions);
    }
  };

  vscode.workspace.onDidChangeTextDocument(event => {
    updateDecoration();
  });
}

export function deactivate() {}

Behavior:

Does this issue occur when all extensions are disabled?: No

/findDuplicates

Duplicate of #33852

/duplicate of #33852


[FLINK-29988] Using lower case fields in hive catalog

Hive metastore only supports lower case table name and fields, we should convert them to lower case in HiveCatalog

Hi @JingsongLi  I try to fix this issue and get some problems
Current I convert the database, table and fields names to lower case in HiveCatalog, but there will be problems when we submit a flink job to write data.
We we submit a flink job with INSERT TableName SELECT ..., it creates sink table with TableName and try to read schema from the file system. It doesn't know whether the table is in hive metastore, and can't get the table from HiveCatalog.
Maybe we should convert all the database, table names to lower case, not limited to HiveCatalog, what do you think? Hope to hear from you, THX :)

After discussed with @JingsongLi , I'll create another issue to throw exception when user use HiveCatalog and create table with upper case table and column name. We will fix this issue when we find a better way for HiveCatalog. So I close this PR first


FIX: moved rule 942101 to PL2

according to #2922
@lifeforms

Oops, we forgot to move the rule from the PL3 section to the PL2 section of the file @M4tteoP Good luck emphazer caught it!

Ouch! Yet another thing that I will remember! Thanks for taking care of it @emphazer @lifeforms! 🙏


Unable to change service from type=NodePort to type=ClusterIP with kubectl

Is this a BUG REPORT or FEATURE REQUEST? (choose one):
/kind bug
Kubernetes version (use kubectl version):
$ kubectl version
Client Version: version.Info{Major:"1", Minor:"8", GitVersion:"v1.8.6", GitCommit:"6260bb08c46c31eea6cb538b34a9ceb3e406689c", GitTreeState:"clean", BuildDate:"2017-12-21T06:34:11Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"10+", GitVersion:"v1.10.0-alpha.1.930+0d1986ad8219bf-dirty", GitCommit:"0d1986ad8219bf1a64fc657eac407cc84d3ad647", GitTreeState:"dirty", BuildDate:"2018-01-17T03:10:36Z", GoVersion:"go1.9.2", Compiler:"gc", Platform:"linux/amd64"}

What happened:

Create a service with type=ClusterIP. Let's say kube-dns:

apiVersion: v1
kind: Service
metadata:
  labels:
    addonmanager.kubernetes.io/mode: Reconcile
    k8s-app: kube-dns
    kubernetes.io/cluster-service: "true"
    kubernetes.io/name: KubeDNS
  name: kube-dns
  namespace: kube-system
spec:
  clusterIP: <IP_ADDRESS>
  ports:
  - name: dns
    port: 53
    protocol: UDP
    targetPort: 53
  - name: dns-tcp
    port: 53
    protocol: TCP
    targetPort: 53
  selector:
    k8s-app: kube-dns
  type: ClusterIP

Edit type from ClusterIP to NodePort, and now we have:

apiVersion: v1
kind: Service
metadata:
  labels:
    addonmanager.kubernetes.io/mode: Reconcile
    k8s-app: kube-dns
    kubernetes.io/cluster-service: "true"
    kubernetes.io/name: KubeDNS
  name: kube-dns
  namespace: kube-system
spec:
  clusterIP: <IP_ADDRESS>
  ports:
  - name: dns
    nodePort: 31716
    port: 53
    protocol: UDP
    targetPort: 53
  - name: dns-tcp
    nodePort: 30492
    port: 53
    protocol: TCP
    targetPort: 53
  selector:
    k8s-app: kube-dns
  type: NodePort

Edit type from NodePort to ClusterIP with all the auto-allocated nodePorts removed, and we hit this error:

# services "kube-dns" was not valid:
# * spec.ports[1].nodePort: Forbidden: may not be used when `type` is 'ClusterIP'

Try to use kubectl apply -f with a similar kube-dns yaml (type=ClusterIP with all nodePorts removed) and hit the same error:

$ kubectl apply -f kube-dns.yaml
The Service "kube-dns" is invalid: spec.ports[1].nodePort: Forbidden: may not be used when `type` is 'ClusterIP'

What you expected to happen:
Users should be able to modify service type from NodePort  to CluserIP.
Anything else we need to know:
Is this a regression? There was a similar bug before (https://github.com/kubernetes/kubernetes/issues/42282), which was fixed.
@mengqiy @kubernetes/sig-cli-bugs

I've just run into this issue, is there a workaround?

kubectl replace can be the workaround.

Hitting similar issue. Any workaround which doesn't delete service ?

@Vikash082 Does kubectl replace work for you?

Just came across this issue so definitely not stale.

kubectl replace worked for me
Note: it requires specifying the clusterIP field to be the same IP as the allocated ClusterIP of this service

Not fixed:
$ kubectl replace -f grav-deployment.yml
deployment.apps/grav replaced
The Service "grav-service" is invalid: spec.clusterIP: Invalid value: "": field is immutable
$ kubectl delete -f grav-deployment.yml
deployment.apps "grav" deleted
service "grav-service" deleted
$ kubectl apply -f grav-deployment.yml
deployment.apps/grav created
service/grav-service created

Dup of kubernetes/kubernetes#66390, which has been fixed in kubernetes/kubernetes#66602.
Please try using kubectl apply -f test-service.yaml   --force.
/close
Please reopen if needed.

The Service "ingress-nginx" is invalid:
* spec.ports[0].nodePort: Forbidden: may not be used when `type` is 'ClusterIP'
* spec.ports[1].nodePort: Forbidden: may not be used when `type` is 'ClusterIP'

Should we update the error message?

is there a workaround for this that does not require the use of --force?

@mpgarate Have you tried kubectl replace?
Ref https://github.com/kubernetes/kubectl/issues/221#issuecomment-409399714.

I ran into this message with kubectl replace:
The Service ... is invalid: spec.clusterIP: Invalid value: "": field is immutable
I suspect this is because I do not have the ip address hard-coded as mentioned in comment 221. In my case is is not practical to do that for every service, and instead I am using a NodePort type as a workaround.

@mpgarate Agreed that hardcoding the IP for every service on creation is not practical. But it may be doable to simply copy over the randomly allocated clusterIP when you try to update the service (e.g. via kubectl replace)?

use edit service, and
comment out the # nodePort: 30492
save it

use edit service, and
comment out the # nodePort: 30492
change to ClusterIP
save it

I use helm and this help me fix the issue:
spec:
  type: {{ .Values.service.type }}
  ports:
    - port: {{ .Values.service.externalPort }}
{{ if (eq .Values.service.type "ClusterIP") }}
      nodePort: null
{{ end }}
      targetPort: {{ .Values.service.internalPort }}
      protocol: TCP
      name: {{ .Values.service.name }}

nodePort: null definitely works declaratively. Thanks @aserrallerios.

nodePort: null definitely works declaratively. Thanks @aserrallerios.

The following worked for me kubectl patch svc my-service --type='json' -p '[{"op":"replace","path":"/spec/type","value":"ClusterIP"},{"op":"replace","path":"/spec/ports/0/nodePort","value":null}]'.

I encountered the same bug, is it a bug?has it been fixed?

Check for indentations too. In my case its the issue :p


feat(docs): add how to submit bug reports and various methods of contributing to the freeCodeCamp

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #XXXXX

Mainly just providing additional information to the repo that already existed on the website.
This makes it easier for users to find and navigate without having to bounce back and forth between github and the freecodecamp site.

Thanks for your work.
The contributing guidelines are intentionally in a singular location for various logistical reasons including out localization efforts of the guidelines themselves. We are opinionated on where these are to be kept - because GitHub is only one of the community platforms we use.


Freezing on android api 21

Hi,
Can anyone confirm?
I'm freezing on emulator android api 21.
Thank you.

Is there any more information you can provide for this issue?

I tested your demo from the repository. The demo is working fine.
Layout of the demo is simple:
<FrameLayout>

	<android.support.v7.widget.RecyclerView />

</FrameLayout>

Layout of my project:
<android.support.v4.widget.DrawerLayout>

	<android.support.design.widget.CoordinatorLayout>

		<android.support.design.widget.AppBarLayout/>

			<android.support.constraint.ConstraintLayout
				app:layout_behavior="@string/appbar_scrolling_view_behavior">

				<android.support.v4.widget.SwipeRefreshLayout>

					<ViewPager>

						<FrameLayout>

							<!--This is Sticky Headers-->
							<android.support.v7.widget.RecyclerView/>

						</FrameLayout>

					</ViewPager>

				</android.support.v4.widget.SwipeRefreshLayout>

			</android.support.constraint.ConstraintLayout

	</android.support.design.widget.CoordinatorLayout>

</android.support.v4.widget.DrawerLayout>

May be a problem in appbar_scrolling_view_behavior ?


Fatal error on NMT reset when CANopen node is not using EMCY module

Describe the bug
Fatal error on NMT reset when CANopen node is not using EMCY module
To Reproduce
Steps to reproduce :
-> No EMCY table in specs (NULL)
-> NMT master sends reset
Reason :
Even if we don't have EMCY table, CONmtReset function will call COEmcyReset which will point on a NULL pointer.
Expected behavior
Either: explain, that EMCY is mandatory. We need to adjust Quickstart example to eliminate confusion.
Or: enhance the implementation of EMCY module to allow a node without EMCY
CANopen Stack (please complete the following information):

Device: any
OS: any
Version 4.1.4

Additional context
n/a

I think both expected behaviors would be good:

improving quickstart example and description to show we should do it (with EMCY)
allow disabling EMCY in case of very tiny nodes where no error is possible ;-)


when i adding  more then 5 ML submenu it getting overflow error

https://codeapprun.io/jayamurugan/widget/wvuTJgFpXS

i con't able to scroll it and view the menu and its sub menus.
i try to fix it with listview widget . but no result

This is the same issue i faced

same here, any solution?

Issue has been resolved, will push it at my earliest conv. !

thank you 👍
On Wed, Sep 9, 2020 at 12:57 AM RetroPortal Studio<EMAIL_ADDRESS>wrote:

Issue has been resolved, will push it at my earliest conv. !
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/retroportalstudio/multilevel_drawer/issues/8#issuecomment-689393287,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQQB5YHXNGAWOAAVHL52H4LSE4YPRANCNFSM4PUVBQYA
.

source code link pls
On Mon, Sep 14, 2020 at 6:09 AM Jayamurugan J<EMAIL_ADDRESS>wrote:

thank you 👍
On Wed, Sep 9, 2020 at 12:57 AM RetroPortal Studio <
<EMAIL_ADDRESS>wrote:

Issue has been resolved, will push it at my earliest conv. !
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/retroportalstudio/multilevel_drawer/issues/8#issuecomment-689393287,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQQB5YHXNGAWOAAVHL52H4LSE4YPRANCNFSM4PUVBQYA
.

[image: image.png]i
i was added 6 submenu item but i only able to see 3. con't able to
scroll and view it.
On Mon, Sep 14, 2020 at 6:11 AM Jayamurugan J<EMAIL_ADDRESS>wrote:

source code link pls
On Mon, Sep 14, 2020 at 6:09 AM Jayamurugan J<EMAIL_ADDRESS>wrote:

thank you 👍
On Wed, Sep 9, 2020 at 12:57 AM RetroPortal Studio <
<EMAIL_ADDRESS>wrote:

Issue has been resolved, will push it at my earliest conv. !
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/retroportalstudio/multilevel_drawer/issues/8#issuecomment-689393287,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQQB5YHXNGAWOAAVHL52H4LSE4YPRANCNFSM4PUVBQYA
.

Can we please get the fix pushed to Github and pub.dev?

i face the same issue , how can i solve it please

Was anyone able to solve this issue??

Anyone with a fix??

hello... its 2021... but here in the future, i havent recieved any fix.. please anyone with a fix,, otherwise you have a good code but make it scrollable please

Is there an alternative to this package coz seems like there is no fix.. And my client wants to see the app!

Apologies for the delay! Multilevel Drawer Version 2.0.0 has been pushed to GitHub with some major upgrades and migration to null safety. Few other fixes on the way. Thanks

Apologies for the delay! Multilevel Drawer Version 2.0.0 has been pushed to GitHub with some major upgrades and migration to null safety. Few other fixes on the way. Thanks

Thanks for the update! Works fine!

Closing


Rename urls to url param, misc fixes.

Add support for convenience usage of create() and verify() (that is, being able to just call create(url) vs create({url}).
Add 'coming soon' errors if either create() or verify() is called without data

@msporny - I rebased this PR on latest master.

(Rebased on latest master)


some typos in chapter 4 (clock)

commit ID： 5d4b310

Page 66

There should be a space between Setting and PLL .

Page 69

is no used --> is not used

dfac1f49314c6c1d0f784ee664504a56e5cb003f
fix this, thanks

Thanks, verified.


Add dom-elements-no-danger-with-children to recommended configuration

This rule will be added by #719. Since React already issues a warning for this, I think it makes sense to enable this rule in the recommended configuration.
I'm adding this to the 7.0.0 milestone so we don't forget to do this for our next major version bump.

SGTM


Do you need to enforce wallet account to use single address mode when using our app?

Hey @alessandrokonrad, I hope you're having a great day!
We implemented Lucid into our Dapp and were wondering if we need to enforce the single address mode on for example Eternl.
Problem is: for users with wallet accounts that have multiple addresses we can't load the correct amount of tokens or ADA they're holding (because they're split into multiple addresses). This is not only a problem for loading the number of tokens but also for sending a transaction.
Loading the wallet with Lucid just returns a single address and that's it (it doesn't load all addresses from the wallet account). Is there any other known way to do this, or we're simply limited and need to enforce that users use the single address mode to be able to use our Dapp?

Hey, Lucid should give you the entire utxo set of all addresses with lucid.wallet.getUtxos(). It queries them directly from the wallet via the dApp connector. Lucid doesn't limit you to single address wallets no. But yes Lucid shows you only a single "primary" address for receiving change and other things.

Thanks a lot for the fast response @alessandrokonrad! You doing great work which is a massive help for the project I'm working on. Just got everything working with the mentioned approach - will close this issue now.

What I thought would be possible is sending all tokens to the primary address and executing the final tx (with all 1000 tokens) from the primary address. But this would result in multiple messages the user has to sign and would be a horrible UX. There must be some other way right?

Just found it - function collectFrom. This thread is a nice monologue lol.


Design: Include Map and Live Call Indicator for Phone

Problem
Phone call volunteers need mapping feedback regarding the location of a case as they enter it, and they need to easily return to a call if they navigate away from it.
Solution

Add a map to the phone intake form so the phone volunteers can see the location of the survivor.
During a live call, add some sort of indicator at the top of the screen (e.g. a pulsing, red phone). If the user navigates away from the phone module, they may return to the live call by clicking on the phone.
See screenshot below.

Screenshot
https://projects.invisionapp.com/share/RMVERRLDJ76#/screens/390947360_PhoneCall_Notes_Copy

Completed or not needed


Error in Hoeffding-Bentkus bound

Hello,
I think there might be an error in the computation of the Hoeffding-Bentkus bound:
In bounds.py in the function hoeffding_plus(mu, x, n), line 11, shouldn't the np.maximum be replaced by np.minimum? As it is know, if mu>=x, Hoeffding_plus returns 0. Therefore, whenever mu>muhat in line 19, hoeffding_mu will be zero. But this seems odd, as mu should be the upper confidence bound and in general be larger than muhat, right? Also in your paper https://arxiv.org/pdf/2101.02703.pdf it seems the other way around in Propositions 3,4.
Best,
Andi

For an easier look at the code which you mentioned:
https://github.com/aangelopoulos/im2im-uq/blob/3b5a5833a6d3a6faacd3f818d8072a8b99116cea/core/calibration/bounds.py#L9-L11
https://github.com/aangelopoulos/im2im-uq/blob/3b5a5833a6d3a6faacd3f818d8072a8b99116cea/core/calibration/bounds.py#L16-L26

Thanks for the quick response.

based on what you wrote earlier, you might have meant hoeffding_plus (line 19),
Yes, sorry, I meant line 19 and I meant hoeffding_plus, not bentkus_plus. I'm sorry, not exactly helping to confuse things when trying to point out a possible error.

it is not super obvious to me that, in this case, bentkus_plus (line 20) would be zero.

Note that h1(y, mu)=0 whenever y=mu, because log(1)=0.
Therefore if mu>muhat, then np.maximum(mu,muhat)=mu and therefore in line 19 hoeffding_plus(mu, muhat, n)= -nh1(np.maximum(mu,muhat),mu)  =  -nh1(mu,mu) = 0

PS: Shall I update the original Issue to correct this error causing a misunderstanding?

Yes, I think this would help when the authors read the issue.

Done :)

Regarding the issue which you point out, my external perspective is that both cases (minimum or maximum) should work thanks to:

However, the inequality with the max does not bring much information, as hoeffding_plus() will return 0 whenever x < mu, which should be the case.
So using the min would make more sense to me.

The problem is, with the maximum, the code piece will either not yield any additional benefit because of what you pointed out:

the inequality becomes  , which is not super interesting.

But if $t>R(\lambda)$, the code will use the Hoeffding inequality in a setting where it is not allowed according to Proposition 3. I think the point of the minimum/maximum was exactly to take care of the case when Proposition 3 does not apply and the authors might have just confused min with max.

Let us wait for inputs from the original author though.

Haha yeah!

I think the point of the minimum/maximum was exactly to take care of the case when Proposition 3 does not apply and the authors might have just confused min with max.

That would make sense. 👍

Hey @woctezuma and @habring, thanks so much for the input. You are totally right :)
It was a typo. Sorry about that! It can sometimes be a bit of a tongue-twister implementing these bounds...
I'll fix it immediately. And thanks for your wonderful discussion, it helped me remember all the relevant details.


Fix random runes and curves errors

Description
Fix random runes and curves errors
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] Code quality improvements

How to test
Run it and see that things work.
Checklist
Please delete options that are not relevant.

[x] I have tested this code
[ ] I have updated the documentation

Pull Request Test Coverage Report for Build 6967

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 34.151%

Totals

Change from base Build 6965:
0.0%

Covered Lines:
2339

Relevant Lines:
6363

💛  - Coveralls

Playground does not correctly load the library that is indicated as selected when the page is refreshed.

Might be a longstanding issue, not sure. Anyway, fixed.


feat(consensus): add sync sender to context to broadcast on decision

This is optional since outside of testing mode sync should be its own component of the node.

This change is

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#414
#413  👈
#412
#409
#406
#404
#389 : 1 other dependent PR (#403 )
#387
#386
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @matan-starkware and the rest of your teammates on  Graphite

Merge activity

Aug 15, 9:56 AM EDT: @matan-starkware started a stack merge that includes this pull request via Graphite.


Is there support for Form::model?

I guess this is on Laravel Collective HTML, but I'm not sure if it exists on the old Illuminate implementation, as there's no mention on this in the readme.

As far as i see for me 5.1 with collectives Form::model works.


Add support for Vipps eCom partner requests

To be able to support Vipps eCom partner to be able to make payments on behalf of merchants the Merchant-Serial-Number header needs to be included in the requests.
This is now included in all the implemented requests for ecom. However this breaks backwards compability on the "getPayment" function, since this did not have access to the MSN

@torfjor Can this be merged ?


models exported as DAE are missing material info

Missing material info such as texture names means I will have to go through hundereds of models and manually assign textures to every material

Same


Use of "self" prevents late-static binding

This is my use-case: I am writing a simple adapter by extending the Money class and then adding a few extra methods.
Taking my extended class to be MyMoney, I then try to create an instance:
$myMoney = MyMoney::GBP(999);

The problem is, this returns an instance of Money\Money and not MyMoney. The use of self when creating new instances is what enforces this. If static were used instead, then an instance of my extended class would be created instead (this being late static binding).
I realise I could write an adapter that took an injected instance of Money\Money instead, and might still do that, but thought I would raise this issue anyway, just in case it is something overlooked rather than a deliberate decision (you may have good reasons for doing it this way).

I can still do this now and get the correct class:
$amount = new MyMoney(999, new \Money\Currency('GBP'));

but this gives me a different class:
$amount = MyMoney::GBP(999);

Here is my adapter:
https://github.com/academe/SagePay-Integration/blob/master/src/Money/Money.php
It is very simple, and can be used as an alternative to the built-in Amount class here:
https://github.com/academe/SagePay-Integration/blob/master/src/Money/Amount.php
since they both share the same interface.

This is kind of how I see it working for OmniPay: if someone wants to write a built-in money handler, then great, but so long as it is class that has an interface that OmniPay expeacts, then any third-party package can be used instead. We don't have to argue about which one, since they can all be supported through an adapter.

@judgej Money 3.0 is final. So you cannot extend it any more. This removes the need for late static binding.

@judgej If you want to build a bridge (for Omnipay or else) you use composition rather than inheritance.
<?php
use Money\Money;

class MoneyOmnipayBridge implements AmountInterface {

private $amount;

public function __construct (Money $money) {
  $this->amount = $money;
}

public function getAmount() {
  return $this->amount->getAmount();
}

public function getCurrencyCode() {
  return $this->amount->getCurrency()->getCode();
}

}

I have bad news for you then: Money class will be final as of 3.0. Although I see your use-case, I think it would be better to use encapsulation and create a wrapper around money. Adds complication, but for the sake of interface implementation I am not sure making it non-final makes sense.

closed by comments and examples of @sagikazarmark and @frederikbosch.

np - I'll change it my end. My gateway is all new and experimental, so nothing there is fixed in stone yet.


docs: adding AWS LEX specific configuration notes

Description

GitHub Issues

Coverage remained the same at 58.572% when pulling<PHONE_NUMBER>2e5cd3f84187de95ffe3d3e60378d0 on jnoortheen:master into 13e22ca9c4ae2f4f0c8d39e8aadf9a8ca928749d on Miserlou:master.

@Miserlou it will be good to have this merged as this helps setting up lex events correctly. Do I need to rerun the checks.


Is this maintained?

After receiving (so far) little support from the official discord notification channel, I've switched to this for Discord notifications as I need webhook support. Pleased to announce that implementing it just now in Laravel 8 on PHP 7.4 works lovely - but is it maintained for the long term?

Hi there! Yes, I'm maintaining it for the long term. Most releases are dependency and security updates though.


Popup that says Orbot not installed

Description
When trying to connect to my lnd node via tor a popup appears which states that Orbot is not installed even though it is.
Expected Behavior
Connect to LND Node via tor with orbot in vpn mode.
Actual Behavior
Popup with the above message. When canceling the popup there seems to be an endless "loading loop"
Possible Fix
It worked with the release before. So there where probably some changes.
Your Environment

Orbot Version: Latest from F-Droid Guardian Project Official Releases Source (16.3.0-RC-1-tor-<IP_ADDRESS>(Tor <IP_ADDRESS>-openssl1.1.1g)
Zap version: 0.3.4-beta
Android version: Android 11(Graphene OS)
Device: Pixel 3a
LND Version: 0.11.1

Hi,
Thanks for the report.
Did you just update Zap, or did you change anything else like updating lnd or your android version?
I didn't change anything regarding handling with tor in the last update. The only thing that might have an effect is that I increased the target sdk to 30.
Right now I am still running lnd v0.10.4
Hopefully I will find time on the weekend to update and investigate the issue.

I recently updated all three.
Graphene OS release for Android 11 was maybe 2-3 weeks ago.
A few days ago I updated to lnd v0.11.1
A connection to Electrum hidden service still works(if that helps)
Let me know if I can help anyhow.

Hi,
I was able to track it down. It was actually a combination of the Zap update and the Android update.
Increasing the target SDK to 30 caused the new package visiblity restrictions of Android 11 to kick in on Android 11 devices.
So the app can't see that Orbot is already installed on these devices.
I have fixed this now and will make a new release in the coming days.
Thanks again for the report!

I just did a release, google play will update soon and if you do it manually, on github it is already available.


props with default values are not added to component data

If I don't explicitly add them to the component element attribute

the whole idea of props is to pass data through attributes by setting a value

then why the option of setting a default value on props configuration?

@thelinuxlich take it the next way - props are "attributes", "data" is "default data or data fetched from external places", and all them are proxied to the Vue instance. So, it's "by design".

ok, but no one explained yet what is the purpose of the default value on props.

@thelinuxlich user the source, Luke :) The default value for props is literally a default value. For example, the next code:
Vue.component 'cat', {
  props: {
    name: {default:  'Tom'}
  }
}

and
So if you'll later use <cat> component - it's instance will have name = 'Tom'. And if you'll use <cat name="Bob">, it will have name="Bob". Please note, that these values are not mapped to data property - only to the Vue instance itself. There would be just no point in that. Also, Props always overwrite "data" keys.
Use the source, Luke! :)

You described the desired behavior, if cat is missing the name attribute, it should default to "Tom", but that is not happening

http://jsfiddle.net/alchen/rjqt2x91/11/
It's working as far as I can tell. Can you provide an example that doesn't work?

Please make sure to provide a repro.

I encountered the same problem.
I narrowed it down: props and data can't be used together and data wins
var vm = new Vue(
  el: document.createElement('div'),
  props:
    'c':
      default: 1
  data: ->
    "b": 2
  )
console.log vm.c # undefined
console.log vm.b # 2

I think they should be usable together

@paulpflug upgrade to latest version please? They do work together in 0.12.7.

Fixed via 145fed71f92bebab6b14b6c5bbe584c6aecaca25

no it doesn't ^^

@paulpflug yyx990803/vue/dev/dist/vue.js is not latest dev.

The following example is a bit verbose but unless data is set in the parent I cannot pass the prop, but if I set data, then the prop default is useless:
http://jsbin.com/xaperuleji/edit?html,js,output
What am I missing?

Hi guys, does this works for object type prop?
  props:     job:       type: Object       default: ->         quantity:           type: Number           default: 1
My 'job' property is a raw object without quantity property, so I'm expecting it should be set by this configuration.

Hi @ben-joostens,
have you figured out how to work around this issue. I have the same problem and cannot wrap my head around it :(


Ignore Warning?

Ignore Warning?

Would be nice to show a different icon for errors and for warnings.


types: add typings and type tests for unist-util-visit

related to: https://github.com/unifiedjs/unified/issues/65
resolves #15

/cc @Rokt33r

Btw, as this uses unist-util-visit-parents, and that also needs typings, which’ll get a major release, should we add types there first?

unist-util-visit-parents [...], should we add types there first?

Good point, I'm not sure how much reuse there will be, it would probably be safer to release there before releasing here.

They are very similar, so most of these typings can move there, and then I’m hoping we can reuse most of parent’s typings here!

They are very similar, so most of these typings can move there, and then I’m hoping we can reuse most of parent’s typings here!

They are very similar, only the visitor type changes between them.
The challenge is making the typing generic enough to support both, without loosing type safety.
An ideal scenario could look something like the below:
// TypeScript Version: 3.5

import {Node, Parent} from 'unist'
import {Test} from 'unist-util-is'

interface VisitorType {
  withAncestors: <N extends Node>(node: N, ancestors: Node[]) => void
  withIndexAndParent: <N extends Node>(node: N, index: number, parent: Node) => void
}

type ValueOf<T> = T[keyof T];

declare const visitConstructor = <V extends ValueOf<VisitorType>>() => <N extends Node>(
  tree: Node,
  test: Test<N> | Array<Test<any>>,
  visitor: V<N>,
  reverse?: boolean
) => void

export = visitConstructor<VisitorType['withAncestors']>()

Where there is a visitConstructor the builds the different types of visit functions, binding the visitor generic to the callback type that adopters will pass in.
The issue is with V<N> passing the generic Node type to the generic Visitor type.
Which currently triggers error
Type 'V' is not generic

Another possibility would be https://github.com/microsoft/TypeScript/issues/10571
declare const visit = <V extends ValueOf<VisitorType>, N extends Node>(
  tree: Node,
  test: Test<N> | Array<Test<any>>,
  visitor: V<N>,
  reverse?: boolean
) => void

export = visit<VisitorType['withAncestors'], _>

but this isn't fully implemented yet, and would likely run into a similar issue passing a generic to a generic.

Do folks have other ideas for reuse of the function? :thought_balloon:

Another idea
interface VisitorType<N extends Node> {
  withAncestors: (node: N, ancestors: Node[]) => void
  withIndexAndParent: (node: N, index: number, parent: Node) => void
}

declare function visitConstructor<V extends keyof VisitorType<any>>(): <
  N extends Node
>(
  tree: Node,
  test: Test<N> | Array<Test<any>>,
  visitor: VisitorType<N>[V],
  reverse?: boolean
) => void

export = visitConstructor<'withAncestors'>()

results in The expression of an export assignment must be an identifier or qualified name in an ambient context

@ChristianMurphy @wooorm Sorry for my late answer. I don't think we can share the types that much. IMHO, the things we could share are actions, visit.EXIT, visit.CONTINUE and visit.SKIP. It feels like we just make too much complicated.

Opened https://github.com/syntax-tree/unist-util-visit-parents/pull/7 with typings for parent.
@wooorm does this module also support returning actions from the visitor function?

@ChristianMurphy Yes, they work the same, the difference is only in the visitor signature!

Good to know, let's hold merging this until syntax-tree/unist-util-visit-parents#7 is merged, so we can leverage the action typings.

Support for actions has been added to the typings.

<EMAIL_ADDRESS>is out!

Thanks @wooorm :bow:
Updated to use the official release.


add initial tests for inletsoperator_app

Description
Add initial tests per follow up comment https://github.com/alexellis/arkade/pull/367#pullrequestreview-637506447
Motivation and Context

[ ] I have raised an issue to propose this change (required)

How Has This Been Tested?

Fetch this PR and then build it locally with make build.
Have an inlet license
Create the token for the provider
install the inletsoperator with the following command

./arkade install inlets-operator --license-file inlet-license --token-file my-token --provider hetzner --region hel1

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I've read the CONTRIBUTION guide
[x] I have signed-off my commits with git commit -s
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

[ ] I have tested this on arm, or have added code to prevent deployment

How Has This Been Tested?

Only part that's missing now.
Please do a quick end to end test with a couple of provider options. You can just install into Kind/K3d without checking that the tunnel is created and a fake access token.
Name:	Tester
Email<EMAIL_ADDRESS>Expires in: 2 days, on: 14 May 2021
Products: [inlets-pro]

Note: use text under the line
---
eyJhbGciOiJFUzI1NiIsInR5cCI6IkpXVCJ9.eyJuYW1lIjoiVGVzdGVyIiwiZW1haWxfYWRkcmVzcyI6ImNvbnRhY3RAb3BlbmZhYXMuY29tIiwicHJvZHVjdHMiOlsiaW5sZXRzLXBybyJdLCJhdWQiOiJqd3QtbGljZW5zZSIsImV4cCI6MTYyMDk5MTU3OSwianRpIjoiODA4MSIsImlhdCI6MTYyMDgxODc3OSwiaXNzIjoiand0LWxpY2Vuc2UiLCJzdWIiOiJUZXN0ZXIifQ.u3n0lyu7LHIzgpPigw3gk_pY8vgWsdxpAyxOMD3LXZFNl6ISX549AOjyC-iFy79DEYVMuKYzoeTQ7-5pz2eHeQ

How Has This Been Tested?

Only part that's missing now.
Please do a quick end to end test with a couple of provider options. You can just install into Kind/K3d without checking that the tunnel is created and a fake access token.
Name:	Tester
Email<EMAIL_ADDRESS>Expires in: 2 days, on: 14 May 2021
Products: [inlets-pro]

Note: use text under the line
---
eyJhbGciOiJFUzI1NiIsInR5cCI6IkpXVCJ9.eyJuYW1lIjoiVGVzdGVyIiwiZW1haWxfYWRkcmVzcyI6ImNvbnRhY3RAb3BlbmZhYXMuY29tIiwicHJvZHVjdHMiOlsiaW5sZXRzLXBybyJdLCJhdWQiOiJqd3QtbGljZW5zZSIsImV4cCI6MTYyMDk5MTU3OSwianRpIjoiODA4MSIsImlhdCI6MTYyMDgxODc3OSwiaXNzIjoiand0LWxpY2Vuc2UiLCJzdWIiOiJUZXN0ZXIifQ.u3n0lyu7LHIzgpPigw3gk_pY8vgWsdxpAyxOMD3LXZFNl6ISX549AOjyC-iFy79DEYVMuKYzoeTQ7-5pz2eHeQ

i will have time more in the end of week/weekend to test this out

@alexellis tested and works fine with hetzner and tried as well with digitalocean


Amazon Prime Home Page Clone

Description
Hii I'm a GSSoc22 contributor and I'm willing to make a pull request in this repository on my project which is Amazon Prime Home Page Clone
The idea behind this project
This is a very mini project which looks similar to the famous OTT streaming website Amazon Prime.
Please refer to the images below:

Code of Conduct

[X] I follow Contributing Guidelines of this project.

@Rayman-Sodhi Please Check my PR regarding this issue
Thank you sir

@SupriyaGembali you can't make a PR without assigning
What to do now @Rayman-Sodhi

Sorry for the inconvenience sir can i close it and reopen it again sir @gurjeetsinghvirdee @Rayman-Sodhi ?

Leave it, don't do from next time

ok sir Thank you

hey, @SupriyaGembali this website clone has been found to be under plagiarised content by the team.If you have any proof of it being genuine kindly share the proof ,otherwise this will be labeled invalid


Make tests run in PropertyT (ResourceT IO)

Changelog
- description: |
    Make tests run in `PropertyT (ResourceT IO)`
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
   - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context
Due to recent changes in hedgehog-extras-<IP_ADDRESS>, we need to have ResourceT in the monad stack for proper workspace cleanup workarounds. This PR adapts codebase for the new version of hedgehog-extras.
Checklist

[ ] Commit sequence broadly makes sense and commits have useful messages
[ ] New tests are added if needed and existing tests are updated. See Running tests for more details
[ ] Self-reviewed the diff

Force merging since hydra gets stuck and does not report statuses back.


microshift: use GPT partition table

Microsoft Hyper-V "gen2" virtual machines require a GPT partition table for their disk images.
The openshift bundle we generate has such a partition table, but not the microshift bundle.
We most likely need to make some changes to microshift/scripts/image-builder/config/kickstart.ks.template to achieve this.

^^^ Interesting, as I am testing with Microshift. Would be VERY helpful if this can be resolved.

This was fixed by https://github.com/crc-org/snc/pull/802


Anyone can help me... Please read this issue. Something wrong...

This Github repository fails to give proper attribution to the theme(s) that it copies/derives from.
As this project appears to be (at least in part) a derivative work of the Academic theme, please keep the original Academic license and copyright notice packaged in your distribution, as per Academic's MIT license. You had the license file, with copyright notice, packaged until recently when you defaced the Academic license/copyright.
Also, Hugo Themes Site enable you to properly attribute original work that a project is partially based on by editing themes.toml. For example,
[original]
  name = "Academic"
  homepage = "https://sourcethemes.com/academic/"
  repo = "https://github.com/gcushen/hugo-academic/"

Please kindly revert your defacement to Academic's license and copyright notice.

This theme is not the modification of academic theme. It was my mistake to include your name in the LICENSE.md file. So I changed it. Your project and mind is totally different.And you didn't contribute for this theme at all. Why are you saying that?

If you refuse to comply with Academic's MIT license then we will consider escalating this.
The MIT license requires that you include Academic's license and copyright notice and revert your attempts to deface it. If you have a problem understanding the MIT license then I suggest you seek legal advice.

Hey.. you know that the code base is totally different. That was a mistake that I included your name in README.MD file.

I'm glad that you were inspired by the Academic Page Builder for Hugo.
You appear to claim to have changed significant parts of the code and only have small parts of the Academic codebase remaining. All I am asking is for you to attribute the code that you copied and respect the MIT license by including the copyright notice in the MIT license that you also copied. You were complying with the license until recently, when you choose to remove Academic's copyright notice. Why is it so difficult to revert the defacement to the license and include any other additional copyright notices for yourself and any of the other themes which you mentioned you copied code from.

I made this project from zero bases. Not forked from your project. I don't mind mentioning the code I referenced, but I created this project from scratch and I own it, and I think my name should be in the license and not others.

It does not matter if you copied code from other themes by forking or by other methods.
What matters is that you properly attribute all the code that you copied and include the copyright notices of those themes. If you need clarification of the MIT license, then you can seek legal advice.

I'll delete all the parts that are related to the Academic theme. Then, everything should be fine?

@gcushen Can you point me to the portions of code that should I fix?

@gcushen There is no more code left that I copied from your theme. If you find anything that from your code, just tell me. I'll remove it from my theme. thanks


update to Xcode 9.4

Hi,There are two problems come up when update to Xcode 9.4.
Layers.swift has one error :Type of expression is ambiguous without more context
conv = MPSCNNConvolution(device: device,
                             convolutionDescriptor: desc,
                             kernelWeights: weights.pointer,
                             biasTerms: biases?.pointer,
                             flags: .none)

and in file LayerHelpers.swift has the same error in the following line.
  let layer = MPSCNNConvolution(device: device,
                                convolutionDescriptor: desc,
                                kernelWeights: weightsData.pointer,
                                biasTerms: biasData?.pointer,
                                flags: .none)

Are you using the latest version of Forge? (Note that this project is no longer being supported by me.)

Yes,I’m using the latest version of Forge in my project. And I run Forge in Xcode 9.4 there was no error occurred.But in my project ,it still showing errors about ‘ MPSCNNConvolution’ as 'Type of expression is ambiguous without more context'.
Thanks.

You need to add the bridging header to your project as well as the header it includes.