[SMALLFIX] fixing a possible resource leak in AbstractClient

in the previous logic, if beforeDisconnect() invokes any RPC, additional connection is be created and the first one is never be closed

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/10008/
Test PASSed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/10014/Failed Tests: 1org.alluxio:alluxio-tests: 1alluxio.master.FileSystemMasterClientIntegrationTest.openCloseTest
Test FAILed.

Jenkins, test this please

+1 LGTM

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/10016/Failed Tests: 1org.alluxio:alluxio-tests: 1alluxio.master.FileSystemMasterClientIntegrationTest.openCloseTest
Test FAILed.


Remove AppVeyor

Most of the ReadMe changes are dead white space at the end of lines.
View without white space changes: https://github.com/winstonjs/winston/pull/1975/files?diff=unified&w=1
We need someone to disable AppVeyor so it doesn't erroneously fail builds.

Do I need to disable Appveyor in the repo settings or from the Appveyor site or?  Let me know and I’ll give it a try (I think it’s my fault it’s there in the first place).
That being said — The reason we added that in the first place was so that we could run the tests on windows, which sometimes behaved a little different than on Linux. Does GitHub actions support testing on multiple platforms?  Should we still care, or hope that the ecosystem has matured enough that platform discrepancies shouldn’t be a concern?

Do I need to disable Appveyor in the repo settings or from the Appveyor site or?

Yes, you need to tell AppVeyor to ignore this project so it stop it marking builds as failed. The last one failed because the appveyor.yml doesn't exist which is the desired state.

@fearphage I think I have deleted the project from AppVeyor, hopefully we're good now?

@DABH Looks like it didn't work. I merged to master and still see AppVeyor:

We should stop merging PRs until we get this fixed. They will all fail now.

Hmm I thought I did but might need to email @indexzero , I’ll do that…

This is reported done by @indexzero.

Confirmed in several issues (#1986) and on master.


Add "or mounted resinOS image"

in https://docs.resin.io/tools/cli/#config-inject-60-file-62-
(e.g. SD-Card or mounted resinOS image) instead of (e.g. SD card)

Fixed in 6.12.7


Monaco Editor Again

Hi,
Is there any news regarding embedding the monaco editor ina custom HTML page?
I read several posts here and I would like to get an update.
Please pardon me If this question has been answered before.
Thank you.

I am working on it, but I need to clean up quite some code before publishing the API, as my hope is to keep it as stable as possible. The file at https://github.com/Microsoft/vscode/blob/master/build/lib/monaco-editor.d.ts is generated from our sources and our sources need to be in a good shape before releasing it.

Is there anyway I can help? (I would need some basic instructions how to setup though)

this can probably be closed now:  https://github.com/Microsoft/monaco-editor

@blendsdk Sorry for going dark on this, I needed to get the basics working before asking for outside help. Anything would be appreciated, from trying it out in different browsers and creating issues, to making PRs to fix those issues, but probably at this stage I think more use-cases would be useful (https://github.com/Microsoft/monaco-editor-samples) and https://github.com/Microsoft/monaco-editor/blob/master/website/playground/playground.mdoc
Otherwise, yeah, the editor is now on npm :)


Understand paths in -open in bcc-flags

E.g. "-open ReScriptJs.Js" is not recognised
while "-open ReScriptJs", "-open Js" is

CC @zth

The semantics of "-open ReScriptJs", "-open Js" is not the same as "-open ReScriptJs.Js". To be accurate, this should be taken into account.
So this issue is not completely fixed yet.

This is now fixed.


adding openrc covalent service

[ ] I have added the tests to cover my changes.
[ ] I have updated the documentation and CHANGELOG accordingly.
[ ] I have read the CONTRIBUTING document.

The purpose of this PR is to help us identify how a systemd service will be implemented.  Note the changes around environment variables, how the service is started/stopped, how paths and variables are modified, etc.  Here I provided the equivalent for OpenRC, likely not useful for most users.


Click on error icons in status bar should toggle error list

Click on the error icons in the status bar - notice error list poping up.
Click on the error icons again - I would expect the error list hides, thus the error icons in status bar behave as a toggle - similar to how the debug console icon behaves in the debug viewlet.
Just my expectation.
@stevencl feedback welcome

@isidorn I do not know what is desired behavior here... but I expect to see problems view showing errors and warnings when I click on the errors icons in the status bar.
This was the same behavior before with the command pallette. I know that command pallette is not togglable where as panels are.


Default bandwidth parameters on links between edge routers

From UI feedback session of 6 April 2017 (dasumikawa):
Does it make sense to have a default bandwidth setting for the links between edge routers?  (Pipe parameters dialog seen when clicking on a link in the scratchpad graph)

closing webui issue


Add supported engines

Since last update all old Nodes (0.10, 0.12) could broke after updating

not applicable


[cleanup] Remove extraneous debug logs

Signed-off-by: Pranav Singh<EMAIL_ADDRESS>This PR removes unwanted debug logs.
Notes for Reviewers
This PR fixes #
Signed commits

[ ] Yes, I signed my commits.

Codecov Report
Base: 16.75% // Head: 12.51% // Decreases project coverage by -4.23% :warning:

Coverage data is based on head (5a600a3) compared to base (8355023).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6668      +/-   ##
==========================================
- Coverage   16.75%   12.51%   -4.24%
==========================================
  Files         115      115
  Lines       11239    11239
==========================================
- Hits         1883     1407     -476
- Misses       8881     9518     +637
+ Partials      475      314     -161

Flag
Coverage Δ

gointegrationtests
?

unittests
12.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

mesheryctl/internal/cli/root/system/start.go
1.70% <0.00%> (-57.03%)
:arrow_down:

mesheryctl/internal/cli/root/system/status.go
1.12% <0.00%> (-53.94%)
:arrow_down:

mesheryctl/internal/cli/root/system/update.go
1.17% <0.00%> (-47.06%)
:arrow_down:

mesheryctl/internal/cli/root/system/restart.go
1.88% <0.00%> (-45.29%)
:arrow_down:

mesheryctl/internal/cli/root/system/stop.go
2.22% <0.00%> (-41.49%)
:arrow_down:

mesheryctl/internal/cli/root/root.go
24.24% <0.00%> (-40.91%)
:arrow_down:

mesheryctl/internal/cli/root/system/logs.go
3.26% <0.00%> (-36.96%)
:arrow_down:

mesheryctl/internal/cli/root/version.go
0.00% <0.00%> (-32.95%)
:arrow_down:

mesheryctl/internal/cli/root/system/check.go
1.03% <0.00%> (-23.03%)
:arrow_down:

mesheryctl/internal/cli/root/error.go
0.00% <0.00%> (-20.00%)
:arrow_down:

... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Code of the paper

Could you provide the code of this paper. Very nice work in ICML.

I also hope the code will be available soon.
Thanks.

Could you provide the code of this paper “Knowledge-Grounded Self-Rationalization via Extractive and Natural Language Explanations”?  It is a very nice work in ICML.


Remove template dependency from istio parent chart

nodeaffinity template is defined on  istio chart, in case you need to install this chart as a separate one will not work because of this dependency. I'm unsure if without those node affinity rules may break something for kiali, I guess this is just to be consistent with Istio deployment.

@ivanmp91 Have you tested the code locally, whether the kiali chart can be deployed independently?

@ivanmp91: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Section - Blue Background

Implemented by https://github.com/aemsites/jet2holidays-portugal/pull/75


since mixing tabs and spaces can generate troubles in some editors, I've...

... removed the tabs

Thanks for sending that in!


Pull the source schema + interface into its own file

This is how I'm proposing to refactor the case model, moving sub-schemas into their own files -- LMK what you think.

@attwad going to merge so I can keep working on this refactor but please leave comments when you're back online and I can make adjustments!

 Refactor dataserver model into classes, add tests


Changed HashSet<> to HashSet due to Eclipse (4.6.0M5) complaint

Says "Type mismatch: cannot convert from HashSet to Set" without
this.

This can probably be fixed by casting it to Set, rather than just Set

I don't think this is valid for a PR, let alone an issue we are causing. If anything, it sounds very much that Eclipse has a bug with generic type inference in the milestone that will likely be fixed in the next milestone release. Note that I'm even more inclined closing this as Milestone 5 isn't even an actual release. It's as much of a change required if any other IDE erroneously threw a compile error on this line when the traditional JDK compiler builds this just fine (and almost every other compiler).

sure, you got it: https://bugs.eclipse.org/bugs/show_bug.cgi?id=490001
But what would it hurt you to just insert a  there anyway??

Keep in mind IDEA uses the standard Java compiler javac so it's actually the Eclipse compiler that is broken if that doesn't work


channelWritabilityChanged called multiple times

Expected behavior
When we have slow consumers, the channelWritabilityChanged method will be called.  Upon inspecting the channel writable state, we can check to see if we are going into a writable -> non-writable (aka slow consumer), or non-writable -> writable (aka coming out of a slow consumer back into normal) state.
Actual behavior
What we're seeing is that netty sometimes calls the channelWritabilityChanged multiple times when the channel itself is writable.  i.e. our assumption is that it channelWritabilityChanged will go from writable -> non-writable and vice-versa.  What we have observed is that when channelWritabilityChanged is invoked, it can sometimes be writable -> writable.
Steps to reproduce

Setup a client and server socket
From the server socket, flood the channel with messages to induce slow consumer.
The channelWritabilityChanged method is called from the same thread (EventLoop thread), however upon checking the channel it can sometimes be writable multiple times one after the other, i.e. no interleaving non-writeable state

Minimal yet complete reproducer code (or URL to code)
Unfortunately our code is wired in quite tight into this at the moment so will be difficult to give a reproducer
Netty version
4.1.20
JVM version (e.g. java -version)
Oracle 1.8.0_111, Zing 1.8.0-zing_<IP_ADDRESS>
OS version (e.g. uname -a)
Linux server-name 2.6.32-696.10.1.el6.x86_64 #1 SMP Tue Aug 22 18:51:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
MacOS High Sierra

I suspect this is a matter of the channel become writable again before we were able to fire the event. That said these events are harmless

Hi Norman thanks.  Ok if this is expected, I'll need to manage the state of the connection outside of netty.  From our applications perspective, we listen to these events to perform certain logic, dropping events, blocking threads whilst flushing data, etc.  Are these events something that I can rely on to perform this 'critical' logic? Or are these events supposed to be only used for more informational purposes?

@scottsue just to clarify it may be that you see multiple notifications for the same writability state (kind of like spurious wakeups) but you should never be NOT notified. So I would say there may be false-positives but never be any missed events. So I think these events should still be useful for your use case ?

Thanks @normanmaurer for the clarification


Run succeed but not found in background process list

I have a code which is collecting data.
When I run your code, I got the PID but I dont get the data.
So, I check the background process with terminal and I found nothing with the same PID.
When I run manually with "php collect.php" command, my code run normally and I get the data.
Is there anything I miss?
Thanks.
This is my code.

$process = new BackgroundProcess("php /var/www/html/project_name/public/assets/collect.php");
$process->run();

echo sprintf('Crunching numbers in process %d', $process->getPid());
while ($process->isRunning()) {
        echo '.';
        sleep(1);
}
echo "\nDone.\n";

What if you set full path to php, like /usr/bin/php?
$process = new BackgroundProcess("/usr/bin/php /var/www/html/project_name/public/assets/collect.php");
You can find out where php is running whereis php

I tried to put full path php too. (/usr/bin/php or /usr/share/php)
But still doesnt work and only return PID as output.
shell_exec() enabled in php.ini too.

Use that PID and run in console using that PID:
Let's say PID is 3270
ps aux |grep 3270
What is the output?

PID is 11140.
This is the output.

root     11222  0.0  0.0  11740   936 pts/1    S+   04:46   0:00 grep --color=auto 11140

It's not running then at all. Well, let's see what the dev is going to say. It's hard to tell without being at the PC.

S means interruptible sleep (waiting for an event to complete). It should have to be R right?

Yes,
PROCESS STATE CODES
       Here are the different values that the s, stat and state output
       specifiers (header "STAT" or "S") will display to describe the state of
       a process.
       D    Uninterruptible sleep (usually IO)
       R    Running or runnable (on run queue)
       S    Interruptible sleep (waiting for an event to complete)
       T    Stopped, either by a job control signal or because it is being
            traced.
       W    paging (not valid since the 2.6.xx kernel)
       X    dead (should never be seen)
       Z    Defunct ("zombie") process, terminated but not reaped by its
            parent.

       For BSD formats and when the stat keyword is used, additional
       characters may be displayed:
       <    high-priority (not nice to other users)
       N    low-priority (nice to other users)
       L    has pages locked into memory (for real-time and custom IO)
       s    is a session leader
       l    is multi-threaded (using CLONE_THREAD, like NPTL pthreads do)
       +    is in the foreground process group

That output is simply piped grep command.

To avoid that output and have the output being empty, in case there is no processes found, you could try ps aux | grep -v grep | grep nameOfProcess

what is the nameOfProcess?
command? or PID?

You can use any PID/NameOfProgram

Are you sure that the collect.php is still running when you execute ps aus | grep PID?

What do you mean by "I got the PID but I dont get the data"? BackgroundProcess pipes on purpose all output of the command to /dev/null (that is, it ignores the output) because BP should continue to run even if the parent process (the process that runs the BP code) finishes.
If you want to process the output of the command you either need to use some kind of IPC (inter-process communication) or something like Symfony\Process.

What I you mean by "I got the PID but I dont get the data". I run the code in the documentation and I get the PID. Does PID mean the code is succeed?
FYI, My collect.php is collecting data from twitter. it will be created json files.
in this problem, the code does not create json files, which means it does not run.

Ah, ok. When you try console, you're running your code as root. When you do it using PHP, you don't run it as root most likely but like virtual server owner. At first, try deleting that file which is created after running collect.php. I think the file can't be written in this case, as previously was created by root user.

If you get the PID it means that the process started to run. You an pass an output file as argument to run() that stores the output of your command.
$process->run('log.txt');

Check the content of log.txtand see if an PHP error occurred.

@qooob : there is no files created after running collect.php. So, I assume the process is not running. I changed folder permission to 0777.
@florianeckerstorfer : yes there is an error in my files. thanks. I need to fix it first and try again.

PHP Warning:  require_once(../../lib/fennb/phirehose/lib/Phirehose.php): failed to open stream: No such file or directory in /var/www/html/project_name/public/assets/collect.php on line 2
PHP Fatal error:  require_once(): Failed opening required '../../lib/fennb/phirehose/lib/Phirehose.php' (include_path='.:/usr/share/php:/usr/share/pear') in /var/www/html/project_name/public/assets/collect.php on line 2

Its running now after I can see what is the problem with PHP error.
Thanks.


httpForward requires templates

Thank you for the quick reply on my previous issue/request...
Now I am trying to set this expectation and using the docker version of mockserver
    "httpRequest": {
        "path": "/some/path"
    },
    "httpForward": {
        "host": "host/path",
        "port": 443,
        "scheme": "HTTPS"
    }

I am using mockserver-client-node to set these two properties in my expectation, but I keep getting this error back: (edited paths below)
2018-02-01 19:29:53,653 ERROR o.m.m.HttpStateHandler Exception processing { mockserver    |   "method" : "PUT", mockserver    |   "path" : "/expectation", mockserver    |   "headers" : { mockserver    |     "Content-Type" : [ "application/json; charset=utf-8" ], mockserver    |     "Host" : [ "localhost:1080" ], mockserver    |     "Connection" : [ "close" ], mockserver    |     "content-length" : [ "278" ] mockserver    |   }, mockserver    |   "keepAlive" : false, mockserver    |   "secure" : false, mockserver    |   "body" : { mockserver    |     "type" : "STRING", mockserver    |     "string" : "{\"httpRequest\":{\"path\":\"/path/tomatch\"},\"httpForward\":{\"host\":\"host.com\",\"port\":443,\"scheme\":\"HTTPS\"},\"httpResponse\":{\"headers\":[{\"name\":\"Content-Type\",\"values\":[\"application/json; charset=utf-8\"]},{\"name\":\"Cache-Control\",\"values\":[\"no-cache, no-store\"]}]}}", mockserver    |     "contentType" : "text/plain; charset=utf-8" mockserver    |   } mockserver    | } mockserver    | java.lang.IllegalArgumentException: 1 error: mockserver    |  - oneOf of the following must be specified "httpResponseTemplate" "httpForwardTemplate" "httpClassCallback" "httpError" "httpObjectCallback" mockserver    | 	at org.mockserver.client.serialization.ExpectationSerializer.deserializeArray(ExpectationSerializer.java:110) ~[mockserver-netty-jar-with-dependencies.jar:na] mockserver    | 	at org.mockserver.mock.HttpStateHandler.handle(HttpStateHandler.java:218) ~[mockserver-netty-jar-with-dependencies.jar:na] mockserver    |           "type" : "string"
Thanks for any help, seems like I am doing everything correctly based on the examples, but I am missing something I guess..

The problem is caused by providing both httpForward and httpResponse, however, each expectation only has a single action.
The expectation you submitted is as follows:
{
    "httpRequest": {
        "path": "/path/tomatch"
    },
    "httpForward": {
        "host": "host.com",
        "port": 443,
        "scheme": "HTTPS"
    },
    "httpResponse": {
        "headers": [
            {
                "name": "Content-Type",
                "values": [
                    "application/json; charset=utf-8"
                ]
            },
            {
                "name": "Cache-Control",
                "values": [
                    "no-cache, no-store"
                ]
            }
        ]
    }
}

Clearly the error message returned was confusing and was not pointing you in the correct direction.  So I have fixed the error so in future it will be as follows:
1 error:
 - oneOf of the following must be specified ["httpForward", "httpResponseTemplate",
 "httpResponseObjectCallback", "httpResponseClassCallback", "httpResponse",
"httpForwardTemplate", "httpForwardObjectCallback", "httpForwardClassCallback",
"httpOverrideForwardedRequest", "httpError"] but 2 found


unable to setup up integration

Version of the custom_component
V3.12.1
Describe the bug
i am having a bug trying to setup the integration. i am running docker HA 2023.4.6, tesla custom integration with HACS latest version both. this was working and it stopped, i though the refresh token had died so i generated a new one and tried again.
i am getting this error in the logs. i am using the teslatoken app for androi
Debug log

Logger: homeassistant.config_entries
Source: custom_components/tesla_custom/init.py:164
Integration: Tesla Custom Integration (documentation, issues)
First occurred: 18:49:27 (1 occurrences)
Last logged: 18:49:27

Error setting up entry<EMAIL_ADDRESS>for tesla_custom
Traceback (most recent call last):
File "/usr/local/lib/python3.10/site-packages/anyio/streams/tls.py", line 130, in _call_sslobject_method
result = func(*args)
File "/usr/local/lib/python3.10/ssl.py", line 917, in read
v = self._sslobj.read(len)
ssl.SSLWantReadError: The operation did not complete (read) (_ssl.c:2548)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/config_entries.py", line 383, in async_setup
result = await component.async_setup_entry(hass, self)
File "/config/custom_components/tesla_custom/init.py", line 164, in async_setup_entry
result = await controller.connect(
File "/usr/local/lib/python3.10/site-packages/teslajsonpy/controller.py", line 197, in connect
self._product_list = await self.get_product_list()
File "/usr/local/lib/python3.10/site-packages/teslajsonpy/controller.py", line 291, in get_product_list
return (await self.api("PRODUCT_LIST"))["response"]
File "/usr/local/lib/python3.10/site-packages/teslajsonpy/controller.py", line 1336, in api
return await self.__post_with_retries("", method=method, data=kwargs, url=uri)
File "/usr/local/lib/python3.10/site-packages/tenacity/_asyncio.py", line 88, in async_wrapped
return await fn(*args, **kwargs)
File "/usr/local/lib/python3.10/site-packages/tenacity/_asyncio.py", line 47, in call
do = self.iter(retry_state=retry_state)
File "/usr/local/lib/python3.10/site-packages/tenacity/init.py", line 314, in iter
return fut.result()
File "/usr/local/lib/python3.10/concurrent/futures/_base.py", line 451, in result
return self.__get_result()
File "/usr/local/lib/python3.10/concurrent/futures/_base.py", line 403, in __get_result
raise self._exception
File "/usr/local/lib/python3.10/site-packages/tenacity/_asyncio.py", line 50, in call
result = await fn(*args, **kwargs)
File "/usr/local/lib/python3.10/site-packages/teslajsonpy/controller.py", line 1346, in __post_with_retries
return await self.__connection.post(command, method=method, data=data, url=url)
File "/usr/local/lib/python3.10/site-packages/teslajsonpy/connection.py", line 125, in post
auth = await self.refresh_access_token(refresh_token=self.refresh_token)
File "/usr/local/lib/python3.10/site-packages/teslajsonpy/connection.py", line 553, in refresh_access_token
auth = await self.websession.post(
File "/usr/local/lib/python3.10/site-packages/httpx/_client.py", line 1848, in post
return await self.request(
File "/usr/local/lib/python3.10/site-packages/httpx/_client.py", line 1533, in request
return await self.send(request, auth=auth, follow_redirects=follow_redirects)
File "/usr/local/lib/python3.10/site-packages/httpx/_client.py", line 1620, in send
response = await self._send_handling_auth(
File "/usr/local/lib/python3.10/site-packages/httpx/_client.py", line 1648, in _send_handling_auth
response = await self._send_handling_redirects(
File "/usr/local/lib/python3.10/site-packages/httpx/_client.py", line 1685, in _send_handling_redirects
response = await self._send_single_request(request)
File "/usr/local/lib/python3.10/site-packages/httpx/_client.py", line 1722, in _send_single_request
response = await transport.handle_async_request(request)
File "/usr/local/lib/python3.10/site-packages/httpx/_transports/default.py", line 353, in handle_async_request
resp = await self._pool.handle_async_request(req)
File "/usr/local/lib/python3.10/site-packages/httpcore/_async/connection_pool.py", line 253, in handle_async_request
raise exc
File "/usr/local/lib/python3.10/site-packages/httpcore/_async/connection_pool.py", line 237, in handle_async_request
response = await connection.handle_async_request(request)
File "/usr/local/lib/python3.10/site-packages/httpcore/_async/connection.py", line 90, in handle_async_request
return await self._connection.handle_async_request(request)
File "/usr/local/lib/python3.10/site-packages/httpcore/_async/http11.py", line 112, in handle_async_request
raise exc
File "/usr/local/lib/python3.10/site-packages/httpcore/_async/http11.py", line 91, in handle_async_request
) = await self._receive_response_headers(**kwargs)
File "/usr/local/lib/python3.10/site-packages/httpcore/_async/http11.py", line 155, in _receive_response_headers
event = await self._receive_event(timeout=timeout)
File "/usr/local/lib/python3.10/site-packages/httpcore/_async/http11.py", line 191, in _receive_event
data = await self._network_stream.read(
File "/usr/local/lib/python3.10/site-packages/httpcore/backends/asyncio.py", line 34, in read
return await self._stream.receive(max_bytes=max_bytes)
File "/usr/local/lib/python3.10/site-packages/anyio/streams/tls.py", line 195, in receive
data = await self._call_sslobject_method(self._ssl_object.read, max_bytes)
File "/usr/local/lib/python3.10/site-packages/anyio/streams/tls.py", line 137, in _call_sslobject_method
data = await self.transport_stream.receive()
File "/usr/local/lib/python3.10/site-packages/anyio/_backends/_asyncio.py", line 1265, in receive
await self._protocol.read_event.wait()
File "/usr/local/lib/python3.10/asyncio/locks.py", line 214, in wait
await fut
asyncio.exceptions.CancelledError```
.

There's something wrong at the SSL layer on your machine. We have no control over this as it's outside of our code. The docker image may need to have some packages updated.

Yes i figured it out host was using a VPN and that blocked the SSL


[Math] clamp function

This PR adds a Math\clamp($num, $min, $max) function that limits a number to a given range.

Pull Request Test Coverage Report for Build 492991768

6 of 6 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.0008%) to 99.71%

Totals

Change from base Build 492121968:
0.0008%

Covered Lines:
2060

Relevant Lines:
2066

💛  - Coveralls

Pull Request Test Coverage Report for Build 492991768

6 of 6 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.0008%) to 99.71%

Totals

Change from base Build 492121968:
0.0008%

Covered Lines:
2060

Relevant Lines:
2066

💛  - Coveralls


directory discrepency in onss_1.1_full.img

Hi! Great project! The build was really fun, hope I didn't mess it up. 😜So I wrote 'onss_1.1_full.img' to a 64GB card and tried to follow the instructions in the firmware installation section of the make guide. It tells me:

Next, navigate to the firmware directory and run the install command:
$ cd /home/pi/open-nsynth-super-master/firmware/src
$ make install

Problem is I can't find the directory 'open-nsynth-super-master' anywhere on the card. I found 'open-nsynth-super' -- which leads down the same hierarchy of directories -- but when I 'make install' from there, I get an error: "could not intialize the debug port."
Any thoughts? Thanks in advance!!

In the lite image the directory was also /home/pi/open-nsynth-super/firmware/src
The -master would only be relevant if you were downloading the source files on a fresh image as that is what the guide seems to be based on.
A problem may be that you must run make before make install?
$ cd /home/pi/open-nsynth-super/firmware/src
$ make
$ make install

@KyleWerle thanks so much for your reply. I tried running "make" and I get:

make: Nothing to be done for 'all'.

I tried the lite build this time and still got after I tried "make install":

Error: Could not initialize the debug port
TargetName: stm32f0x.cpu
Type: cortex_m
Endian: little
TapName: stm32f0x.cpu
State: unkown
adapter speed: 1001 kHz
Info: SWD DPIDR 00000000
Error: Could not initialize the debug port
Error: Target not examined, will not halt after reset!
TARGET: stm32f0x.cpu - Not halted
in procedure 'reset' called at file 'openocd.cfg", line 22
in procedure 'ocd_bouncer'
Makefile:40: recipe for target 'install' failed
make: *** [install] Error 1

Any thoughts? A few notes:
I see a lightning bolt in the upper right-hand corner of the screen. I'm using a pi 3 specific power adapter. Could that cause such an issue?
Also, should the OLED light up at all when plugged into HDMI before firmware install? It does not, does that mean something is screwy or does it need the firmware and hardware controllers to work?
Thanks again!

The STM firmware is what connects all the controls and oled screen to the rPi. To utilize all of those you will need to write the STM firmware.
It sounds like you are having a connection issue between the STM board and your rPi. Possibly double check the board? Is it the correct STM chip? Solder bridges? There are 2 STM chips that should be compatible.

Thanks @KyleWerle! I reflowed the ICs and Pi socket. Still no luck. Time to sit down and have a really close look at everything! Thanks again for the advice.

Good luck!

 After another reflow and some fastidious cleaning I was able to write the firmware. Seems to be working okay now...

I'm at the same step now and having difficulty with the make process as well.  I'm also using the lite image. I was able to successfully run make, when invoking make install I receive an error:
_BCM2835 GPIO nums: swclk = 25, swdio = 24
BCM2835 GPIO config: srst = 23
srst_only separate srst_gates_jtag srst_push_pull connect_deassert_srst
srst_only separate srst_nogate srst_push_pull connect_deassert_srst
adapter_nsrst_delay: 100
adapter_nsrst_assert_width: 100
Info: BCM2835 GPIO JTAG/SWD bitbang driver
Info: SWD only mode enabled (specify tck, tms, tdi and tdo gpios to add JTAG mode)
**Error: An adapter speed is not selected in the init script. Insert a call to adapter_khz or jtag_rclk to proceed.
Makefile:40: recipe for target 'install' failed
make: *** [install] Error 1**_
So, after some Googling, I added the line into the openocd.cfg file...
adapter_khz 1001
From looking at the post above and seeing that 1001kHz was the selected adapter speed.  But still, no dice... It's now exiting with:
_BCM2835 GPIO nums: swclk = 25, swdio = 24
BCM2835 GPIO config: srst = 23
srst_only separate srst_gates_jtag srst_push_pull connect_deassert_srst
srst_only separate srst_nogate srst_push_pull connect_deassert_srst
adapter_nsrst_delay: 100
adapter_nsrst_assert_width: 100
Info: BCM2835 GPIO JTAG/SWD bitbang driver
Info: SWD only mode enabled (specify tck, tms, tdi and tdo gpios to add JTAG mode)
Info: clock speed 1001 kHz
Error: BUG: current_target out of bounds
Makefile:40: recipe for target 'install' failed
make: *** [install] Error 255_
Long story short, would someone on this thread who had a successful firmware flash care to show me what the openocd.cfg file looked like?  To my eyes it looks like it's simply not the right *.cfg that I'm using as the TargetName: stm32f0x.cpu isn't being found??

I'm wondering if this is any way related to the fact that I had to use a mirror site for installing openocd yesterday.... The version I am using is Open On-Chip Debugger 0.10.0 -- Could someone confirm which version of openocd ended up working?

Resolved this issue, reference the first problem with openocd repo being down: https://github.com/googlecreativelab/open-nsynth-super/issues/22
Once re-installing openocd from the secondary source within the makefile, I was able to execute 'make install' and received the same error code as @panfriedcharlie ...
Then after inspecting the PCB I found that the STM chip pin 1 is not located to the upper-left when facing text on the IC. Instead, it is registered with the indentation. After rotating the chip on the board I was able to flash the firmware.
I'm all set!

@SarahHopeB I ~almost~ had that same issue. I second-guessed myself and zoomed waaay in on the build photos to check the dot orientations.  Glad you were able to solve the problem!

I ended up lining the dot / orientation marker on all the parts with the very small extra line on the silkscreen for the ICs.

That's a great idea. I would also add a larger diode cathode band to the
opti-isolator midi circuit.  I had swapped the orientation initially due to
my squinty eyes...
On Mon, Apr 9, 2018 at 9:04 AM Kyle Werle<EMAIL_ADDRESS>wrote:

I ended up lining the dot / orientation marker on all the parts with the
very small extra line on the silkscreen for the ICs.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/googlecreativelab/open-nsynth-super/issues/16#issuecomment-379804485,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AkUhSE7nqkOHv8-bw1w85j9w4zbquAbsks5tm4Z8gaJpZM4TBS04
.

We just need open source telescopic retinal enhancements and we'd be good.

Hey. So I used this image and it is asking for a login and password.  Any ideas?

Asking for login/password at which step?
On Mon, Apr 16, 2018 at 11:14 PM USERxUNKNOWN<EMAIL_ADDRESS>wrote:

Hey. So I used this image and it is asking for a login and password. Any
ideas?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/googlecreativelab/open-nsynth-super/issues/16#issuecomment-381858693,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AkUhSN9BDgG497NC2tzDLiHdJrXM9WrCks5tpYhIgaJpZM4TBS04
.

The default user is pi , and the password is raspberry.


[WIP] Presets

This will add a preset section to the preferences, as well as support presets in the various views and functions of PicoTorrent.

As soon as this is implemented, I think I'll try using PicoTorrent as my primary torrent client. I'm curious about whether its SOCKS5 implementation is airtight (as opposed to qBittorrent, which apparently leaks).

Both PicoTorrent and qBittorrent builds on Rasterbar-libtorrent and
depends on it for the proxy layer.
I’m unsure which version of libtorrent that qBittorrent is running, but
PicoTorrent runs a fairly recent master branch version and should be
quite up to date.
I don’t know the extent of the information leak, but it may be reported
at libtorrent and it may have already been fixed, and if it was fixed
before we took a version then we would also have that fix.
Lots of questions to answer, but I’ll look it up later tonight!
On Fri, Apr 27, 2018, at 13:53, Guillaume wrote:

As soon as this is implemented, I think I'll try using PicoTorrent as
my primary torrent client. I'm curious about whether its SOCKS5
implementation is airtight (as opposed to qBittorrent, which
apparently leaks).> — You are receiving this because you authored the thread. Reply to
this email directly, view it on GitHub[1], or mute the thread[2].>

Links:

https://github.com/picotorrent/picotorrent/pull/545#issuecomment-384948246
https://github.com/notifications/unsubscribe-auth/ABbDcAPv7ZyLAtajsim6zPSKY_x_c_1Kks5tswaqgaJpZM4SlfRd


need way to discover default value for optional argument

the title says it all - can you put the default value into the intellisense?

Related to #50

It would be nice if a function with optional parameters that are actually filled in JS could still be represented in some way in Blocks.

Since 1e5fd39f5e7b0c0ca16fa819412732d68887bc24 we now have support to add the default value (from jsdoc) into the intellisense auto completion.
However, we currently don't insert optional parameters.
If we wanted to add optional parameters we risk most of them not converting back into blocks. Thoughts?

Don't add the optional arguments. They are optional for a reason and meant for more advanced users.

In the screenshot above we don't show the default value of interval. The value is provided in the //% annotations (//% parts="ledmatrix" interval.defl=150 shim=basic::showString). Maybe it's possible to instead of:
function showString(text: string, interval?: number)

say in the tooltip:
function showString(text: string, interval: number = 150)

Closing old issues. If this is still an issue please reopen.


fix(#minor);Added position value at close for snapshot

At close of position snapshot takes value before it goes to zero. Allows for profit and loss calculations.

simplified the field to realisedpnl @corerouter pointed out the smartcontract emits this field and we can simply take it from there. Thank you!

simplified the field to realisedpnl @corerouter pointed out the smartcontract emits this field and we can simply take it from there. Thank you!

Looks good for me. Just leave a comment for the realisedpnlUSD type. Thanks!

Can you help me understand the difference between balanceUSD and colalteralBalanceUSD?

collateralBalanceUSD is the collateral value the user inputed. balanceUSD is the notional value of the entire position (collateral+leverage).


Open links in OSM notes in new tab

For example notes from StreetComplete often have a linked image. These links should be opened in a new tab instead of the current one.

Can you please assign this issue to me? I will change the target associated with this linked image so that it opens in a blank tab.

I've been looking into this briefly but I can't find where link tags are constructed. I'm guessing there's some sort of user-input parsing library that's being used to clean any comment data, that also detects and wraps links? Maybe this is coming from the API. I think you might need to use a CSS selector and manually append a target=_blank attr for any link tags pointing away from OSM domains.
Any ideas? :)

Okay, so I've gone on the assumption and written a helper function to preprocess any comments for links, adding target=_blank attribute to any which point to 'external domains'.
At the moment, I'm considering any link whose hostname does not include "osm.org" or "openstreetmap.org" as an external domain.
There are 3 things to note with this:

There may be more domains than just these two I've considered so far
A domain such as foosm.org would be considered non-external, due to containing "osm.org" in the host
I don't have a way of differentiating between within-map and within-site links, such as user profile vs. map node. It would probably be preferable to open a within-site but out-of-map link in a new tab. I'd need a full list of all endpoints of either category, based on how I'm implementing it now.

Here's a preview: https://www.youtube.com/watch?v=MFpImKkY9gA

Here's what I've written for it (wary of making a PR just yet):

// This is all in note_comments.js
mainEnter
    .append('div')
    .attr('class', 'comment-text')
    .html((d) => preprocessLinkTags(d.html));

/**
 * Add target="_blank" to any comment links pointing away from the site
 * That is, any link with domain other than those in ignoredDomains.
 */
function preprocessLinkTags(commentTextHtml) {
    if (typeof commentTextHtml !== 'string') return commentTextHtml;
    try {
        const template = document.createElement('template');
        const trimmedCommentTextHtml = commentTextHtml.trim();
        template.innerHTML = trimmedCommentTextHtml;

        const links = Array.from(template.content.querySelectorAll('a'));
        const ignoredDomains = ['openstreetmap.org', 'osm.org']; // Possibly more?

        // Filter links based on their hostname not including domains in ignoredDomains
        links
            .filter((link) => {
                const hostname = new URL(link).hostname;

                // Find if any ignoredDomains are found in the hostname (e.g. "api06.dev.osm.org" will be matched)
                return ignoredDomains.findIndex(d => hostname.includes(d)) === -1;
            })
            .forEach((link) => link.setAttribute('target', '_blank'));

        return template.content.firstChild.innerHTML;
    } catch (error) {
        // Bail without changing if something goes wrong
        return commentTextHtml;
    }
}

You could use d3 to select all the a elements in the comment-text div and add the attribute to them all like so:
mainEnter
  .append('div')
    .attr('class', 'comment-text')
    .html((d) => preprocessLinkTags(d.html))
  .selectAll('a')
    .attr('rel', 'noopener')
    .attr('target', '_blank');

You could use d3 to select all the a elements in the comment-text div and add the attribute to them all like so:

Ah! I'm super unfamiliar with d3. I'll still want to filter which tags open, something like:
    mainEnter
      .append('div')
        .attr('class', 'comment-text')
        .html((d) => d.html)
      .selectAll('a')
        .filter(isExternalLink)
        .attr('rel', 'noopener')
        .attr('rel', 'nofollow')
        .attr('target', '_blank');

To answer your question about where the links are actually generated I had a look.
Looks like the note information returned by the API is being parsed here: https://github.com/openstreetmap/iD/blob/248b29983d273aa28877c47729af936644044481/modules/services/osm.js#L328-L367
Which involves the parseComments function in the same file on L150. However, that all just seems to be parsing the json response and not doing anything with the note content. The parsed properties are all fed into the osmNote object constructor in https://github.com/openstreetmap/iD/blob/248b29983d273aa28877c47729af936644044481/modules/osm/note.js#L25-L44 which again doesn't seem to be doing anything with the contents. So I think the content must be coming in pre-linked from the API.

Ah! I'm super unfamiliar with d3. I'll still want to filter which tags open, something like:
Does this look reasonable?

Hey, yes that looks good to me! I'm not the most well versed in d3 myself, but have played with it enough to know when it can make life easier 😄

Hey, yes that looks good to me! I'm not the most well versed in d3 myself, but have played with it enough to know when it can make life easier 😄

Great, I'll give a test and see how it goes with this new format. Thanks so much for all this!

I've made a pull request (#7893) for this based on previous discussion. Solution now uses a much simpler function for determining internal links, and provided d3 functions.

Done by @JeeZeh in #7893.


Use BoxLayout instead of FloatLayout

Is your feature request related to a problem? Please describe.
Just came across FrostedGlass today and assumed it would be trivially possible to put widgets into the FrostedLayout. I see, however, that FrostedLayout is (as of very recently) based on FloatLayout. I do feel bad for saying this right after #1 was closed.
The problem with using FloatLayout, from what I can tell :
- The FrostedGlass needs to be of a predetermined size or sized to fill available space. It's not easy to make it scale to fit the contents.
- Children need to manually positioned / sized so that it can fit into the FrostedGlass
Describe the solution you'd like
If you were to base FrostedLayout on a BoxLayout, then children can be trivially added to the BoxLayout to build a complex layout which can also push out the size of the FloatLayout to contain the children. If you really did want a FloatLayout in some context, such a Layout can be added to the FrostedLayout(BoxLayout) and used as normally. It would also be possible to insert a  RelativeLayout inside the BoyLayout instead, to get a Float-like arrangement of children which remains confined to the area of the FrostedGlass
As an example, this is how I make BoxLayouts have colors:
https://github.com/chintal/ebs-iot-linuxnode/blob/108eb20c67430c8b7d74b9dd75903304309e75c3/ebs/iot/linuxnode/widgets/colors.py#L77

Hi @chintal!
Considering that the FrostedGlass  widget tries to provide a standardized way to organize its children, changing its base class to BoxLayout would interfere with its own organization as the frosted glass effect is added to the FrostedGlass container as a child widget. Also, for non-adaptive uses, this would require most users to have to add a child layout like FloatLayout or RelativeLayout to FrostedGlass, just to avoid automatically arranging the BoxLayout-based FrostedGlass into columns and rows.
But nothing prevents you from binding the size of the child widget to the parent size (FrostedGlass) and getting the result you expect!
Below is an example using kvlang, but you can also do this on the python side binding the sizes:
Image:
    id: background_image
    source: 'bg_example.png'
    size_hint: (1., 1.)
    allow_stretch: True
    pos_hint: {'center_x': 0.5,'center_y': 0.5}

FrostedGlass:
    id: fg
    background: background_image
    pos_hint: {'center_x': 0.5,'center_y': 0.5}
     size_hint: (None, None)
    blur_size: 20
    saturation: 1.2
    luminosity: 1.5
    overlay_color: "#76FF0300"
    noise_opacity: 0.12
    border_radius:  dp(10), dp(10), dp(10), dp(10)
    outline_color: "#76FF03"
    outline_width: 1

    BoxLayout:
        pos_hint: {'center_x': 0.5,'center_y': 0.5}
        size_hint: None, None
        size: self.minimum_size
        opacity: 0.65
        on_size:
            fg.size = self.size #  bind to id
            self.parent.size = self.size  # bind to parent (exact size)
            self.parent.size = list(map(lambda x: x + dp(30), self.size))  # for extra spacing

        Button:
            size_hint: None, None
            size: 50, 100
        Button:
            size_hint: None, None
            size: 50, 200
        Button:
            size_hint: None, None
            size: 50, 300
        Button:
            size_hint: None, None
            size: 50, 100

Result:


Changed IndexOOB to ArrayIndexOOB

This is slightly more precise : https://stackoverflow.com/questions/34266174/difference-between-arrayindexoutofboundsexception-and-indexoutofboundsexception

Coverage remained the same at 89.251% when pulling dd1ef6b1b5558f02f32b4fe9727c2f9c17529a1e on MartensCedric:patch-1 into 5c3971765186c596659dd81793c2b6a01cabf6aa on apache:master.

-1: Probably a sood idea but not in this form. Most (if not all) of Commons IO uses IndexOutOfBoundsException for this type of failure, so if you want to make such a change, it should be done consistently throughout the code, not in just one random location. Currently I see 10 locations that throw  IndexOutOfBoundsException.

Closing: No reply since my February 16 comment.


Various iNaturalist updates

Fixes

Fixes #3631 by @rwidom
Description

This PR fixes a number of aspects of the iNaturalist ingestion, with the hope that we should be able to turn it back on in production after this!

Addresses the issue in #3631 by pointing to a "latest" version of the COL data. This link doesn't include a build/date/version number, and so shouldn't need updating down the line.
Fixed an issue where the media type was not provided when running various common.sql methods directly.
Updated the iNaturalist schemas, which had changed since the last time this was successfully run.
Use the minimum photo ID when creating the initial ranges, rather than starting from 0

It seems it had been a minute since we've gotten iNaturalist running :sweat_smile: There were quite a few changes, but I think I've covered them all and added references to documentation for where to look if they change again.
Testing Instructions

Due to our use of parameters over variables for defining when to skip the removal of the source data, this is a little tricky

Enable the iNaturalist DAG, then disable it. A DAG run should start, immediately mark the entire DAG as failed.
Trigger a new run of the DAG, and uncheck sql_rm_source_data_after_ingesting in the parameter settings before running
Let the DAG execute and ingest data! It won't be a whole lot of images (and the initial download of the COL data is about 600MB so be advised it will take time!)

Checklist

[x] My pull request has a descriptive title (not a vague title likeUpdate index.md).
[x] My pull request targets the default branch of the repository (main) or a parent feature branch.
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[x] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no visible errors.
[ ] I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat have you modified AIRFLOW_CONN_AWS_DEFAULT in your local .env, maybe from testing something else? Can you reset it to the default from env.template:

Thank you, @stacimc, I think resetting the local .env fixed the issue.
Next up, an error in the load_catalog_of_liefe_names 😆
2024-03-07, 20:12:07 +03] {inaturalist.py:232} INFO - /var/workflow_output/COL_archive.zip exists, so no Catalog of Life download.
[2024-03-07, 20:12:07 +03] {taskinstance.py:2728} ERROR - Task failed with exception
Traceback (most recent call last):
  File "/home/airflow/.local/lib/python3.10/site-packages/airflow/models/taskinstance.py", line 439, in _execute_task
    result = _execute_callable(context=context, **execute_callable_kwargs)
  File "/home/airflow/.local/lib/python3.10/site-packages/airflow/models/taskinstance.py", line 414, in _execute_callable
    return execute_callable(context=context, **execute_callable_kwargs)
  File "/home/airflow/.local/lib/python3.10/site-packages/airflow/operators/python.py", line 200, in execute
    return_value = self.execute_callable()
  File "/home/airflow/.local/lib/python3.10/site-packages/airflow/operators/python.py", line 217, in execute_callable
    return self.python_callable(*self.op_args, **self.op_kwargs)
  File "/opt/airflow/catalog/dags/providers/provider_api_scripts/inaturalist.py", line 257, in load_catalog_of_life_names
    with zipfile.ZipFile(OUTPUT_DIR / local_zip_file) as z:
  File "/usr/local/lib/python3.10/zipfile.py", line 1269, in __init__
    self._RealGetContents()
  File "/usr/local/lib/python3.10/zipfile.py", line 1336, in _RealGetContents
    raise BadZipFile("File is not a zip file")

@obulat are you copying the COL file into the container? 😮 or just running the DAG?

Just running the DAG... Where is the COL file supposed to be? I tried looking inside the catalog container, but couldn't find anything inside that folder

@obulat I also received that error when I first tried. My guess was that it had something to do with not stopping the first, automatic dagrun in time and getting into a weird failure state. I wiped my local catalog and then retried it, setting the default for sql_rm_source_data_after_ingesting to False here instead so you can just turn the DAG on and test immediately.

@obulat I also received that error when I first tried. My guess was that it had something to do with not stopping the first, automatic dagrun in time and getting into a weird failure state. I wiped my local catalog and then retried it, setting the default for sql_rm_source_data_after_ingesting to False here instead so you can just turn the DAG on and test immediately.

Thank you, @stacimc! I also didn't stop the first DAG run before it went on to load_catalog_of_life_names step, so it c I added a check for validity of the zip file that deletes the COL file if it's not valid:
        zpath = OUTPUT_DIR / local_zip_file
        if zpath.exists():
            try:
                zipfile.ZipFile(zpath)
            except zipfile.BadZipFile:
                logger.info("COL file is corrupt, so deleting it.")
                zpath.unlink()

I also had an error in the s3 steps. Turns out, I didn't have the AWS variables set in the root .env file. That was the reason why my load_to_s3 container always had an error in it.
After I added the variables, the whole DAG ran smoothly.

@AetherUnbound, do you think the error I had with the COL zip file can ever happen in production?

It definitely should not! iNaturalist, like our other provider DAGs, has "max active runs" set to 1. The only reason this happened locally was because we triggered a manual run, which overrides some of these rules and caused the race condition you mentioned. #3847 should help with this scenario in the future because we can just enable the DAG and let the scheduled workflow run instead of having to trigger it with a parameter.
Thanks for the reviews, and the assistance troubleshooting @stacimc!


UPSTREAM: : Fix OWNERS_ALIASES

Add aliases: section to fix owners checks.
@openshift/storage

/label qe-approved
/label docs-approved
/label px-approved


chore: fix linting an npm run commit

Fixed linting to use the tsconfig.json file and fixed the hook for run commit

Warnings

:warning:

Changes were made to package.json, but not to package-lock.json.Perhaps you need to run npm install?

Messages

:book:

:white_check_mark: All tests are passing
Nice one! All 22 tests are passing.

Dependencies with modified semantic versioning:

appcd-subprocess - from ^3.0.0 to ^1.3.0
fs-extra - from ^8.1.0 to ^8.0.1
libnpm - from ^3.0.1 to ^2.0.1
semver - from ^6.3.0 to ^6.0.0
titaniumlib - from ^2.0.1 to ^1.3.1
@commitlint/cli - from ^8.2.0 to ^7.6.1
@commitlint/config-conventional - from ^8.2.0 to ^7.6.0
@seadub/danger-plugin-junit - from ^0.1.2 to ^0.1.1
@types/chai - from ^4.2.3 to ^4.1.7
@types/fs-extra - from ^8.0.0 to ^7.0.0
@types/got - from ^9.6.7 to ^9.4.4
@types/mocha - from ^5.2.7 to ^5.2.6
@types/node - from ^8.10.54 to ^8.10.48
@types/semver - from ^6.0.2 to ^6.0.0
@types/sinon - from ^7.0.13 to ^7.0.11
commitizen - from ^4.0.3 to ^3.1.1
cz-conventional-changelog - from ^3.0.2 to ^2.1.0
danger - from ^9.2.1 to ^7.1.4
husky - from ^3.0.5 to ^2.3.0
lint-staged - from ^9.4.0 to ^8.1.7
mocha - from ^6.2.0 to ^6.1.4
mocha-jenkins-reporter - from ^0.4.2 to ^0.4.1
mock-fs - from ^4.10.1 to ^4.10.0
nock - from ^11.3.5 to ^10.0.6
sinon - from ^7.5.0 to ^7.3.2
standard-version - from ^7.0.0 to ^6.0.1
ts-node - from ^8.4.1 to ^8.1.0
tslint - from ^5.20.0 to ^5.16.0
typescript - from ^3.6.3 to ^3.4.5

New dependencies added: @types/nock.
@types/nock
Author: Unknown
Description: Stub TypeScript definitions entry for nock, which provides its own types definitions
Homepage: http://npmjs.com/package/@types/nock

Createdover 3 years agoLast Updated22 days agoLicenseMITMaintainers1Releases28Direct Dependenciesnock

README
This is a stub types definition for nock (https://github.com/nock/nock).
nock provides its own type definitions, so you don't need @types/nock installed!

  Generated by :no_entry_sign: dangerJS against 3f1c3a4b838ba5d2dab9186451c9087d0661e1a0


[Issue-2] - fix for x or z variables highlighting differently.

Issue Link
proposed fix: create separate value rules that differentiate between numbers defined with a bit length e.g. 8'hFF, and those without e.g. 1234. allow xXzZ only when highlighting the right-hand-component of the number

Seems to work for me. Thank you!


Restore the ability to run unit tests individually

Add add to Makefile, possibly.

This can still be done with pytest . I must have been drunk.


Adding /proc/timer_list to the masked paths list

/proc/timer_list seems to leak information about the host. Here is
an example from a busybox container running on docker+kubernetes.
cat /proc/timer_list | grep -i -e kube
, hrtimer_wakeup, S:01, futex_wait_queue_me, kubelet/2497
, hrtimer_wakeup, S:01, futex_wait_queue_me, kube-proxy/3478
, hrtimer_wakeup, S:01, futex_wait_queue_me, kube-proxy/3470
, hrtimer_wakeup, S:01, futex_wait_queue_me, kubelet/2499

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "mask-timer_list" git@github.com:dims/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "mask-timer_list" git@github.com:dims/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

ping @justincormack

LGTM

LGTM

Btw they are removing timer_list entirely woohoo!!!
http://www.openwall.com/lists/kernel-hardening/2017/02/08/26

LGTM
On 9 Feb 2017 01:39, "Jess Frazelle"<EMAIL_ADDRESS>wrote:

Btw they are removing timer_list entirely woohoo!!!
http://www.openwall.com/lists/kernel-hardening/2017/02/08/26
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/docker/docker/pull/25630#issuecomment-278520592, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAdcPJ8MC4T2bLNnAMNaU0hCF3K6MZU8ks5ram5KgaJpZM4JidHr
.

@jessfraz wonderful!


Remove unecessary to_numpy.

Not sure why it was needed at some point, but it seems to be fine now? Opening this PR to check this.

Ooops did not hit enter here, maybe that was to avoid things like this:

and then having to explain that scikit-learn accepts pandas dataframes but in most cases discards column information.

This probably something that we can pass under silence. It takes the Series and it output predictions :)


lua go library ioutil changed in versions.

lua api changed in versions.
I have looked at the history and on 1st oct 2017 commit 46ced98 the lua call was changed from ioutil to io/ioutil which is causing the problem between versions. eg 1.3.3 and future versions.
case "ioutil":
return ImportIoUtil()

case "io/ioutil":
return importIoUtil()

Could be a problem with plugins.
I will just check micro version and load the correct binding for filemanager plugin, unless you are going to change it back before next micro editor release.

Oops sorry it's unfortunate I forgot to change it to io/ioutil before releasing 1.3.3. I think I'll add support for importing with both ioutil and io/ioutil.


Allow unlinked pages

I'm wanting to have unlinked pages in the .root file that begin with "_" so they do not appear on the nav, but can still be referenced.

Believe it or not, you can edit navigation manually in site.yml, but that's an excellent and intuitive feature request.

Awesome, good to know :+1:


fix(budimanjojo/talhelper): add windows support

https://github.com/budimanjojo/talhelper
Check List

[X] Read CONTRIBUTING.md

[X] Read OSS Contribution Guide

[X] All commits are signed

This repository enables Require signed commits, so all commits must be signed

[X] Avoid force push
[X] Do only one thing in one Pull Request
[ ] Execute cmdx s to scaffold code
[ ] Install and execute the package and confirm if the package works well

Talhelper supports Windows, this change enables Windows support

Thank you for your contribution!

The original code looks stale, so let me re-scaffold it by cmdx s.

01e1102 Re-scaffolded.
cmdx s -B budimanjojo/talhelper

🎉 https://github.com/aquaproj/aqua-registry/releases/tag/v4.285.1

@suzuki-shunsuke when you re-scaffolded, you removed windows support


After the source partition data is sent to the destination partition, it is distributed randomly. I expect that the source partition data of no. 1 will be sent to no. 1 partition of no. 1 destination

After the source partition data is sent to the destination partition, it is distributed randomly. I expect that the source partition data of no. 1 will be sent to no. 1 partition of no. 1 destination

According to what rules is the data written to the corresponding destination partition?Which file is the corresponding code?

In datastream metadata, you can set system.destination.identityPartitioningEnabled = true.
By doing that, you will enable the same partition mapping from source to destination.
The codes are in the following file: KafkaMirrorMakerDatastreamMetadata.java
and KafkaMirrorMakerConnectorTask.translate()

Give me a specific example for system.destination.identityPartitioningEnabled  ,thanks

I set it to go like this : destination.identityPartitioningEnabled  =true ,but have no effect


Non-Routine Adjustments

From the Weekly CalTRACK Update:

At a general level, CalTRACK methods shy away from stipulating methods for non-routine adjustments, as these tend to demand substantial additional effort and may require additional data that would run contrary to the premise of using CalTRACK methods in the first place.

My understanding is that NRAs are quite common in Commercial Building EE, so I don't understand why they wouldn't be considered for residential buildings in P4P programs.
A recent example is a home with flooding damage, which ran pumps and fans continuously for several weeks. Since this was continuous use, the additional electric load is easily quantified and documented with smart meter data, resulting in an incremental amount of kWhs above "normal use" during a specific period.
Why wouldn't CalTRACK methods allow for this case, and others that can be similarly quantified?
I believe we could develop simple protocols (proof of NRA, quantification of NRA, limited time period of NRA, etc.) which would allow for inclusion of more buildings in P4P programs, instead of adopting an approach that may exclude more buildings than necessary -- to the detriment of the aggregators and overall claimed savings.

This is a policy decision. In commercial P4P, with few assets, it makes more sense to do NRAs. CalTRACK 1.0 took up this issue and allowed for projects with +/- 50% savings to be flagged for review and removed from a portfolio. Doing commercial-style NRAs on residential buildings would be really expensive relative to the savings that are happening and sort of antithetical to the premise of residential P4P. In practice, NRA's tend to be highly litigated and it usually has very little to do with methods.

As a program sponsor/designer I agree with McGee's recommendation. I'm anticipating NRAs will be a negotiated program rule with our P4P participants prior to the launch of our pilot, with the likely outcome that a tbd range of outlier projects will be removed from performance based cohorts, as opposed to performing NRAs on each and every project with unusual usage events.

What is the method that will be used to make determinations on outliers? Would a Mean Absolute Deviation (MAD) be a good choice?

I need to support Steve's request for a more refined approach to NRAs. Simply dropping projects from aggregator cohorts is a fairly blunt-instrument adjustment strategy. It may be acceptable for programs with short performance periods because the frequency of NRAs would presumably be low enough to ignore. But I'm aware of at least one program sponsor that is contemplating a performance period of 3-5 years. In that scenario, dropping projects with non-routine events could result in substantial attrition to an aggregator's portfolio, with several unwelcome consequences:

Strands the aggregator's investment in those projects
Introduces risk to an aggregators's portfolio that is hard to quantify, thereby increasing the cost of insuring the portfolio and/or treating it as a business asset for financing purposes
Sets P4P energy efficiency programs in opposition to other public benefit programs that systematically trigger non-routine events (e.g., distributed PV, electric vehicle charging)

It would be helpful to have some standardized approaches to adjusting for the most important non-routine events without getting into the weeds of adjusting for every little thing.

This issue will likely be taken up by the GRID working group. Closing for now.


Can't find any devices

Hi,
There are 0 entiteties and devices. Am i doing something wrong?
thanks

same here

How did you install? Which "version" (commit) are you running?

Got mine configured now as well - seeing the same issue.
Running HA Supervised, Integration on commit #ebb01e5

@TheFitzZZ  could you please attach logs @osks It looks like the same problem like #12 and #10

Sorry for not thinking of that:
Logger: homeassistant.config_entries
Source: custom_components/gardena_smart_system/init.py:92
First occurred: 15:49:03 (1 occurrences)
Last logged: 15:49:03
Error setting up entry for gardena_smart_system
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 217, in async_setup
    hass, self
  File "/config/custom_components/gardena_smart_system/__init__.py", line 51, in async_setup_entry
    await hass.async_add_executor_job(gardena_system.start)
  File "/usr/local/lib/python3.7/concurrent/futures/thread.py", line 57, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/config/custom_components/gardena_smart_system/__init__.py", line 92, in start
    raise Exception("No locations found")
Exception: No locations found

Logger: gardena.smart_system
Source: custom_components/gardena_smart_system/__init__.py:88
First occurred: 16:05:14 (1 occurrences)
Last logged: 16:05:14

403 : {'message': 'Forbidden'}

@dueltschi @TheFitzZZ Please Check this -> https://github.com/py-smart-gardena/hass-gardena-smart-system/issues/5#issuecomment-636923978

Will wait a day or two and report back :-)

same here. Will report back in a few days. Thanks Guys!

Maybe on of you would you agree to send me your creds and API key by mail (from my profile) so i can debug more deeply ?
(you can change them before and will be able to change them afterwards)
Grm

Gardena is currently having issues with its API.
We need to let them sole their issue as it si probably related !

Guys, for everyone who wants to integrate Gardena Smart System into Home Assistant. There is an alternative way of doing this.
Go to "Configuration / Einstellungen" then to "Integrations / Integrationen", click the "+" in the bottom right corner, Search for "HomeKit Controller", Click on it and then choose from the drop down menu the Gardena Smart System. Enter the HomeKit code, printed on the back of the Gardena Smart Gateway - et voilà the Gardena Bridge including all Switches and Sensors is now available in Home Assistant.
From there, if you're an iOS User, you can expose those devices to the HA HomeBridge.

@grm What's the advantage of using the Py integration over the HomeKit  Controller method?

I never used homekit, I will try to find out how this works, but I can already tell :

advantage : to be independant from an apple product (i do not know if we have to create an account on apple and do we need to use their servers and by doing so, we augment the point of failures)
this product may be vendor locked, and apple decide what can be done through their API and decide to stop an integration because they have their own (like on ios store)
other advantage : independance from another third party tools and decision to start gaining money on something like that

I may have to dig deeper on homekit in order to have a better insight, but these are my first impressions. And on your sides, do you see any advantage/inconvenient of each solutions ?

@TheFitzZZ @Johnyyy85 please check this solution for the issue and give us a feedback if it works -> https://github.com/py-smart-gardena/hass-gardena-smart-system/issues/5#issuecomment-638851191

Awesome, works, thanks!

@grm there are two sides of HoneKit.
The HomeKit-Controller can connect devices that have native HomeKit Integration. That’s how you import devices into Home Assistant. You don’t need a Apple device for that.
The HomeKit Bridge will expose all devices, entities, automations etc to Apple HoneKit. To access HomeKit itself then, you need e.g.  an iPhone
So my assumption would be including Gardena Bridge through HomeKit-Controller (!) should work for everyone.
The HomeKit Bridge is just something for Apple Users...
Do you want to take a look on it? I could document it ...

I have both installed. The HomeKit part actually exposes a little less information, as the garden sensor is lacking soil temp and battery information. Smart irrigation seems to be identical, since it's only exposing the valve control. Don't have the smart version of the mower so don't know about that :-)
Also changing the duration of the irrigation isn't possible, which is quite useful for automation. My current HomeKit based automation needs to close and re-open to get more than the standard 20 mins :-).

@TheFitzZZ Thanks for your feedback. I don’t have the irrigation, just the water control and sensors. I can automate it quite well and the water control can be activated for as long as you want or as short as you want. Is this different with the irrigation control?
@grm here is a article which will give you better understanding
https://www.home-assistant.io/integrations/homekit_controller/

For me it's just a switch, and it reports a 20 min timeout when enabled. Maybe just a difference between the two systems :-) Can work around it easily so I don't mind.

@TheFitzZZ Okay. ;-)


Wrong location of footnotes in bidirectional text

Description
When a footnote appears directly after a text flow in a different direction to the surrounding text, the footnote number will attach the the inner text and appear on the wrong side of it, at least in most cases where the inner text is semantically considered as a distinct flow from the outer one (for example in quotations).
Examples:
English text ואז עברית#footnote[With an English footnote]

Generates:

This second example is perhaps much more motivating for why this behaviour should not be the default:
טקסט בעברית שמציג מספר כמו 123#footnote[והערת שוליים אחריו]

Reproduction URL
No response
Operating system
No response
Typst version

[X] I am using the latest version of Typst

I now realise my workaround of show footnote: it => "\u{200f}" + it breaks down annoyingly at the very edge of a line, allowing the footnote to fall down into the next line.


Clarify location of config file

Originally, we discussed to have a command line option (e.g. -c) to provide a config file. That was not implemented.
However, it is currently unclear where the config file is when it is installed
a) directly from GitHub (in the venv as described)
b) via pip
Please clarify that in the README.

Hi @tschmidtb51,
It's already in the readme, both a) and b) install the config file inside the site-package
https://github.com/csaf-tools/CVRF-CSAF-Converter/blob/main/README.md#config

@sustefil
Sorry, I might be missing something here:

What does the ... refer to?
When cloned from GitHub and installed in the venv: Where is the folder site-packages/? Maybe having a path that starts with $ROOT_DIR could help...
When installing from PyPI: Where is the folder site-packages/?

BTW: I guess "Convertor" in the last sentence of the linked section in the Readme should actually be a "Converter"...

Fixed the readme to be more explicit
https://github.com/csaf-tools/CVRF-CSAF-Converter/blob/main/README.md#config

@tschmidtb51 can be closed?

@sustefil: Yes. Please do not forget to mention issue numbers in commits. It makes the life and reviewing much easier. Thanks!


docs: fix broken link to Prism includeLangs.js default list of languages

Pre-flight checklist

[x] I have read the Contributing Guidelines on pull requests.
[ ] If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
[ ] If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation
I found a broken link, and I am making a pull request to fix it.
Test Plan
Just click on the new link.
Here is the broken link and here is the new corresponding link .
Test links
Not needed as this is just a docs change.
Related issues/PRs
None

fix https://github.com/facebook/docusaurus/issues/8910


Add Kalculator from SpaceDock

This pull request was automatically generated by SpaceDock on behalf of hashashin, to add Kalculator to CKAN.
Please direct questions about this pull request to hashashin.

Seems like this wasn't previously indexed.

@plague006 go ahead :+1: . I've also notes and image viewer.
Thanks.


[Feature] Change editable in react

Is your feature request related to a problem? Please describe.
I use React and I want to set it editable without rebuilding the editor.
Describe the solution you'd like
useEffect(() => {
    if (editorRef.current) {
      const editor = editorRef.current.get();
      if (editor) {
        editor.action((ctx) => {
          ctx.set(editorViewOptionsCtx, { editable: () => editable });
        });
      }
    }
  }, [editable]);

I already tried this, but it doesn't work. Is there another way to set it editable programatically?

@Saul-Mirone @danieldaeschle Any way you can post the sandbox again, since its inaccessible?

I couldn't access the sandbox either, but the way I managed to it was:
const editableRef = React.useRef(editable);
const { get } = useEditor((root) =>
    Editor.make()
      .config(nord)
      .config(async (ctx) => {
        ctx.set(rootCtx, root);
        ctx.set(editorViewOptionsCtx, { editable: () => editableRef.current });
      }));

useEffect(() => {
    editableRef.current = editable;
 }, [editable])


ReferenceError: Invalid left-hand side in assignment

First of all,
Above every library I have encountered in the Node realm, this is by far one of my favorites. async/await, pagination, promises. This is a really helpful library. Thank you.
Maybe I'm doing it wrong but I am getting ReferenceError: Invalid left-hand side in assignment trying to get all users.
      await res = res.next;
      ^^^^^^^^^

index.js:
const {users} = require('./lib');

console.log(users());

and lib.js
const TSheetsApi = require('tsheetsapi');

const tapi = new TSheetsApi({
    bearerToken : 'XXXX'
});

async function users() {

    let res = await tapi.users().list();

    while(res.next){
      console.log(res.data)
      await res = res.next;
    }
}

module.exports.users = users;

I believe I have the async keyword in the wrong place but I cannot for the life of me find the proper documentation on while loops for this kind of code execution.
Thank you for very much. Your hard work does not go unnoticed.
Node version: 8.7.0
NPM version:  5.4.2

Hi @naknode,
thank you for your support.
A small test hints to a small syntax error in the await expression in your loop:
res = await res.next

instead of:
await res = res.next

I hope this fixes your issue!

Hey @comppaz , that's interesting. Never saw it like that.
My res query returned null for res.next so the while never looped. Maybe it's because it only returns if next has more listings to return? I had 25.
Anyway, my new index.js is:
const { users } = require('./lib');

async function init() {
    const getUsers = await users();
    console.log(getUsers);
}

init();

and my new lib.js is:
const TSheetsApi = require('tsheetsapi');

const tapi = new TSheetsApi({
    bearerToken : 'XXXXXXXXXXXXXXX'
});

function users() {
    return new Promise( async (resolve, reject) => {
        let res = await tapi.users().list();

        if (res.data) {
            resolve(res.data);
        } else {
            reject(`No results.`);
        }
    });
}

module.exports.users = users;

which seems to work fine and return all datasets. Anyway, thank you! I had forgotten res.next was a method I could attach await next too. It  all makes sense now regardless.

I see your problem, unfortunately there is an error in our README.
If you call:
let res = await tapi.users().list();

then res.data will already contain the first page of results.
Thus, this adapted version should work (untested - that's how we use this library in production):
const TSheetsApi = require('tsheetsapi');

const tapi = new TSheetsApi({
    bearerToken : 'XXXX'
});

async function users() {

    let res = await tapi.users().list();

    while(res && res.data.length >0){
      console.log(res.data)
      res = await res.next;
    }
}

module.exports.users = users;

I'll adapt the README accordingly!

Awesome. Thanks @comppaz
I see you're also just providing the body in doRequest():
          const entries = body['results'][endpoint];

          let result = [];

          for(let key in entries){

            if(!entries.hasOwnProperty(key)) continue;

            result.push(entries[key]);

          }

          resolve([result, body["more"]]);

I have a use-case that makes me need body['supplemental_data']. Would you like me to submit a PR to make this more extensible? This PR would come with README changes as well.

You're right, supplemental data wasn't included into the response.
I just pushed a new commit (and version) that includes the supplemental data - version 2.0.7 should be available through NPM soon :-)

Good deal, thanks for all of your hard work!
On Thu, Oct 19, 2017 at 2:57 AM, Antonio Maiolo<EMAIL_ADDRESS>wrote:

You're right, supplemental data wasn't included into the response.
I just pushed a new commit (and version) that includes the supplemental
data - version 2.0.7 should be available through NPM soon :-)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/territory-webguerillas/node-tsheetsapi/issues/1#issuecomment-337829462,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAlngNvLVxrplw7W2rcFgWLdr2ULnV8-ks5stwECgaJpZM4P86EB
.

Thanks for your support! If you find any further issues, let me know.


Update nl.po

Fixed spelling of tenses of borrowed verb "crash" in Dutch translation

Resolved via crowdin.

Resolved via crowdin.


Terraform version 4 upgrade - s3 resource changes

Description:
See first error in #605, made changes as suggested by terraform version 4 upgrade.

Will this affect existing infrastructure at all in the testing account?

See here for another solution. Both that solution and the one listed in this PR are for local testing, but should not affect the testing account as the setup is already done. As long as terraform destroy is not ran in terraform/setup it should be okay. However I do think because of that this PR doesn't need to be merged; this should be added to documentation in some form though

Closing this PR, but still note that this needs to be documented

Closing this PR, but still note that this needs to be documented

Please create an relevant issue, so we keep track of it, if that sounds good :-)


Changing minimap size and position

How do I change the minimap size and position?

see #127 for resizing
changing the position should work similarly, you could try e.g.
.radar {
    width: 25%;
    tranform: translate(10px, 20px);
}


NTR - fixes criteria for generating navigation page seo urls

1. Why is this change necessary?
See Issue #2656
2. What does this change do, exactly?

Fixes criteria for creating navigation page seo urls.

3. Describe each step to reproduce the issue or behaviour.
See Issue #2656
4. Please link to the relevant issues (if any).
#2656
5. Checklist

[ ] I have written tests and verified that they fail without my change
[ ] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[ ] I have read the contribution requirements and fulfil them.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hey,
I will close this as it is inactive for a while. Feel free to create a new one when you have updated it.


The first image is treated differently than the following

hi,
I trained yolo with a custom dataset. When I tried to use this package, only the first image after startup was correctly classified. This image was also displayed smaller. All following pictures were enlarged and no longer correctly classified.

Hi,
can you please check which viewer you are using, i.e. image_view/use_darknet is true or false? Please try both options here. In addition, you can check if the darknet_ros topics are published.
Please send me your yaml, .cfg and .weights file.
Best,
Marko

hi Marko,
thanks for the reply.
image_view/use_darknet is true or false --> same error for both
darknet_ros topics are published --> yes darknet_ros topics are published, first msg with found object all following topics with zero objects
Here the files:
weights and cfg
config.zip
testimage.jpg.zip
bagfile for test (ros indigo)
Best,
Tobias

Hi Tobias
I have a similar bug with this darknet_ros package. I trained a network for 1 class and then tried to run it. Everything built correctly but I did not see any output at all. I tried with each viewer, the topics are published, but still no output.
If I test my network with the YOLO detection framework from the developers at pjreddie.com/darknet/yolo/, then it works.
Cristi

Hi Cristi,
I couldn't find the error.
this ros yolo version works for me link
Best
Tobias


feat(storagenode): store only the latest commit context for every commit

What this PR does
This patch adds a new approach to storing a commit context, only the latest commit context. It does
not remove the previous method to keep tests succeeding; we will remove it later.
Which issue(s) this PR resolves
Updates #125

Codecov Report
Base: 62.85% // Head: 63.13% // Increases project coverage by +0.27% :tada:

Coverage data is based on head (ecf3a12) compared to base (0a14ab5).
Patch coverage: 84.74% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #162      +/-   ##
==========================================
+ Coverage   62.85%   63.13%   +0.27%
==========================================
  Files         126      126
  Lines       17061    17120      +59
==========================================
+ Hits        10723    10808      +85
+ Misses       5781     5761      -20
+ Partials      557      551       -6

Impacted Files
Coverage Δ

internal/storage/storage.go
82.71% <46.15%> (-2.37%)
:arrow_down:

internal/storage/encode.go
98.05% <95.55%> (-1.95%)
:arrow_down:

internal/storage/commit_batch.go
100.00% <100.00%> (ø)

internal/metarepos/raft_metadata_repository.go
71.93% <0.00%> (+0.26%)
:arrow_up:

...metarepos/dummy_storagenode_client_factory_impl.go
63.88% <0.00%> (+1.38%)
:arrow_up:

internal/metarepos/storage.go
81.37% <0.00%> (+1.71%)
:arrow_up:

internal/storagenode/replication_server.go
83.00% <0.00%> (+6.00%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Add rander layers to mesh library items

Proposed solution to these:
https://github.com/godotengine/godot/issues/40245
https://github.com/godotengine/godot-proposals/discussions/5438
Allow changing render layers on a per-item basis on a mesh_library and change grid_map to take render layers into account. Baked meshes don't support render layers.

+1 for this feature, it will be really useful

Any updates on this?


Explicitly add symfony/debug as a requirement

The code: https://github.com/silexphp/Silex/blob/master/src/Silex/ExceptionHandler.php#L37 uses symfony/debug classes directly. However it is currently only installed by inference from symfony/http-kernel when not installing the development dependencies.
If you do a composer update --prefer-stable --prefer-lowest from outside of silex it will grab the 2.6 version of symfony/debug which does not include the getHtml method on DebugExceptionHandler and thus everything fails.
This was discovered in: graze/silex-trailing-slash-handler#9

I've just tested and (today) it installs symfony/debug 2.8.0. So, upstream was probably fixed at some point.


Add manual pipeline execution to Pipelines guide

Maybe add it to Triggering Pipelines, or add a step to Managing Piplines that mentioned manual execution and refers to triggering, or whatever.

Fixed in #1002


On some iOS devices (example: iphone 12 pro max) when app is installed via deep link, the deep_link_value is undefined

Report
On some iOS devices (example: iphone 12 pro max) when app is installed via link, deep deep_link_value inside onInstallConversionData is undefined.
Plugin Version
6.6.1
On what Platform are you having the issue?
iOS
These are the lines which I've added in my AppDelegate.m file:
- (BOOL)application:(UIApplication *)app
            openURL:(NSURL *)url
            options:(NSDictionary<UIApplicationOpenURLOptionsKey,id> *)options
{
  [[AppsFlyerAttribution shared] handleOpenUrl:url options:options];
  [[RNFBDynamicLinksAppDelegateInterceptor sharedInstance] application:app openURL:url options:options];
  if ([[FBSDKApplicationDelegate sharedInstance] application:app openURL:url options:options]) {
    return YES;
  }

  if ([RCTLinkingManager application:app openURL:url options:options]) {
    return YES;
  }

  return NO;
}

// Universal Links
- (BOOL)application:(UIApplication *)application continueUserActivity:(nonnull NSUserActivity *)userActivity restorationHandler:(nonnull void (^)(NSArray<id<UIUserActivityRestoring>> * _Nullable))restorationHandler {
  [[AppsFlyerAttribution shared] continueUserActivity:userActivity restorationHandler:restorationHandler];
  [[RNFBDynamicLinksAppDelegateInterceptor sharedInstance] application:application continueUserActivity:userActivity restorationHandler:restorationHandler];
  return [RCTLinkingManager application:application
                   continueUserActivity:userActivity
                     restorationHandler:restorationHandler];
}

Also I see this in logs:
[AppsFlyerSDK] [com.appsflyer.serial] [DDL] Calling didResolveDeepLink with: {"af_sub4":null,"click_http_referrer":null,"af_sub1":null,"click_event":{"request_ip_version":"IP_V4","match_message":"No pre-install link matched for this device."},"af_sub3":null,"deep_link_value":null,"campaign":null,"match_type":null,"af_sub5":null,"media_source":null,"campaign_id":null,"af_sub2":null}

same here

same here

@pjc0247 you need to write their tech support, they're not communicating here (don't understand why).


Set the execution permissions to new script

Coverage decreased (-0.1%) to 45.446% when pulling 821e1cb3de9253de0768c528a18d0e40ea3cee24 on version-update-aleksi into 2a882dfcb92e26cfff49f8ee7edf53510675cf79 on master.

Coverage decreased (-0.1%) to 45.446% when pulling 87c9b36702e9fed9c509ba23f7a9c15c44bdc47a on version-update-aleksi into 2a882dfcb92e26cfff49f8ee7edf53510675cf79 on master.

LGTM


SizeSensor throws TypeError when child has style

If you create a child with a style (even an empty one) like this:
    render() {
        return (
            <SizeSensor onSize={this.onResize}>
                <div style={{}}>
                    {this.props.children}
                </div>
            </SizeSensor>
        );
    }

SizeSensor throws the error below. Removing the style attribute fixes the issue.
react-dom.development.js:20266 Uncaught TypeError: Cannot assign to read only property 'position' of object '#<Object>'
    at SizeSensor.webpackHotUpdate../node_modules/libreact/lib/SizeSensor/index.js.SizeSensor.render (index.js:68)
    at finishClassComponent (react-dom.development.js:14695)
    at updateClassComponent (react-dom.development.js:14650)
    at beginWork (react-dom.development.js:15598)
    at performUnitOfWork (react-dom.development.js:19266)
    at workLoop (react-dom.development.js:19306)
    at renderRoot (react-dom.development.js:19389)
    at performWorkOnRoot (react-dom.development.js:20296)
    at performWork (react-dom.development.js:20208)
    at performSyncWork (react-dom.development.js:20182)

@Ghirigoro Thanks, for reporting this. It must because of this line:
https://github.com/streamich/libreact/blob/master/src/SizeSensor/index.ts#L85
React in development mode makes style object read-only, but on that line the .position property is mutated.

@streamich Yeah. I was just looking at the source and changing that line to use a clone of the style property resolved the issue.


Add a flag to allow testRegex pattern in jest config

Is your feature request related to a problem? Please describe.
My org uses testRegex in the jest.config instead of testMatch and since both cannot exist simultaneously, we have to modify the config before running the reassure tests.
Describe the solution you'd like
I would want to be able to add a --testRegex flag to the reassure measure command to be able to use testRegex instead of testMatch
Describe alternatives you've considered
I'm open to suggestions for a better solution.

I am considering adding a feature where reassure would foward all passed options to underlying jest bin. It seams that would solve your issue

Thanks for the update. Will try implementing TEST_RUNNER_ARGS.

This issue has been resolved in Reassure v1.2.0 🎉


[WIP] Add means of comment formatting to sway-fmt-v2

Opening up for visibility. This is highly WIP.
Related to #2224 and #2122.
To Do

[x] Handle comments inside a code block
[ ] Implement a way for getting a range to search in the comment map for a specific item in different placement scenarios (a way to get the right range to search in the comment map for comments before/after/next to a given item span)
[x] Improve tests
[ ] Using the utils created in the previous steps simply push the comments to the right places as they are. (This can also be a separate PR)

This needs couple more touches but at the current status it can format the following code piece:
contract;

// This is a comment.
struct Foo {
    barasdd: u64,
    baz: bool,
}

        // This is the second comment.
struct Foo2 {
    barasdd: u64,
    baz: bool,
}

to
contract;

// This is a comment.
struct Foo {
    barasdd: u64,
    baz: bool,
}
// This is the second comment.
struct Foo2 {
    barasdd: u64,
    baz: bool,
}

Currently, it cannot handle the inside code-block comment correctly (although they are correctly placed in the comment map). I should have that shortly and after some final clean-ups, this will be ready to go.

For now, we might want to preserve the whitespace "gap" between comments and their preceding/following items too. We might be better off thinking about how to format comments and the whitespace gaps between comments and surrounding items in future PRs, as there is probably a lot to consider when trying to re-arrange or format comments.
People do all kinds of stuff in comments like diagrams, post-fix on the same line, prefix to the line above, etc.
Could be good to keep some gross examples in mind, or even some as tests to check that we don't accidentally remove them or break them. I'm imagining stuff like:
// The following items are all related to the foo bar baz. Blah blah blah.

// This is a Foobar.
struct Foobar {
    a: A, // A is a A.
    b: B, // TODO: We should change this to a C.
    /// D is important and pub.
    /// blah blah.
    /// -----
    /// | D |
    /// -----
    pub d: D,
}

// This is a foo function.
fn foo(
    bar: Bar, // this is a bar
    baz: Baz, // this is a baz
    // Qux is a little more complicated.
    // So I'm writing multiline on top to describe why.
    // Blah blah blah
    qux: Qux,
) -> /* TODO: Result<Foobar> */ Result<Barfoo> {
}

As I started to explore how I can insert the comments to relevant places without formatting them, I realized that it is going to be somewhat tricky. I am thinking to have a separate PR for the actual comment insert operation and keep this one for only providing the means of comment formatting which will complete these 2 todos in #2122:

[ ] Implement Ord for Span as mentioned above. If unsuitable for sway-types due to paths, use our own Span type with conversions implemented. Edit: after taking another look at Span I think we don't want to use it directly. Instead we should use our own span (i.e. a simple byte range) and handle one file at a time.
[ ] Use CommentedTokenStream to collect a map of spans -> comments in sway-fmt-v2.

Would that make sense @mitchmindtree or should I keep going on this one until we have the complete formatting implemented?
Also once you are available another brainstorming session about actually inserting the comments would be great for me because as I started to dive deeper into actually inserting them, I started to have some concerns regarding the comments inside some code-block. (I feel like I need some sort of mapping between the spans of items before formatting to after formatting, I can do that by re-parsing the formatted code and adding comments in a separate pass after I constructed while traversing the AST (that contains formatted code spans) but I feel like there could be a better approach for this)


legion python failed when import torch

If import torch in the python script, I get the lots of warnings/errors like this:
0 - 7fffc87bf700] {4}{gpu}: duplicate registration of function _ZN6thrust8cuda_cub3cub11EmptyKernelIvEEvv
[0 - 7fffc87bf700] {4}{gpu}: duplicate registration of function _ZN6thrust8cuda_cub3cub11EmptyKernelIvEEvv
[0 - 7fffc87bf700] {4}{gpu}: duplicate registration of function Z8gen_mtgpI17curandStateMtgp32jiXadL_Z15__curand_noargsIS0_EjPT_iEE10rng_configIS0_EEvS3_PT0_mmT1
[0 - 7fffc87bf700] {4}{gpu}: duplicate registration of function Z8gen_mtgpI17curandStateMtgp32jiXadL_Z15__curand_noargsIS0_EjPT_iEE10rng_configIS0_EEvS3_PT0_mmT1
[0 - 7fffc87bf700] {4}{gpu}: duplicate registration of function Z8gen_mtgpI17curandStateMtgp32jiXadL_Z15__curand_noargsIS0_EjPT_iEE10rng_configIS0_EEvS3_PT0_mmT1
[0 - 7fffc87bf700] {5}{gpu}: ERROR: The binary was compiled for the wrong GPU architecture. Update the ‘GPU_ARCH’ flag at the to
It works with the cpu only pytorch or native python interpreter.
I installed the pytorch by pip3 install torch torchvision

@eddy16112 any chance you could get this to reproduce in a docker container?  If not, I'll try on my side.

@streichler I do not have a docker installed on the remote machine I am using. You should be able to reproduce the bug with test/python_binding like this:

USE_CUDA=1
pip3 install torch torchvision
put import torch in the python_binding.py
I also did export GPU_ARCH=pascal to improve the compiling speed on my machine.

Let me know if you can not reproduce the bug, and then I will install the docker.


he traducido los comentarios en html al español

desde Honda - Colombia

[ ] I have read freeCodeCamp's contribution guidelines.
[ ] My pull request has a descriptive title (not a vague title like Update index.md)
[ ] My pull request targets the master branch of freeCodeCamp.
[ ] None of my changes are plagiarized from another source without proper attribution.
[ ] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Thank you for opening this pull request.
This is a standard message notifying you that we’ve reviewed your pull request and have decided not to merge it.
Reason: You haven’t indicated that you have fulfilled with our PR requirements.
We would welcome future pull requests from you.
Thank you and happy coding!