Convert HashMap to dict

First off, thanks for the awesome package.
I have a static Java method that returns a HashMap<String, String> instance. I want to know if there's a simpler way to convert it to a dict that I may be missing:
hashmap_result = jpype.JClass('MyClass').methodThatReturnsHashMap(x)
result = dict(hashmap_result)  # doesn't work!
result = {k: hashmap_result[k] for k in hashmap_result}  # works OK

Hmm.  It appears to work for me...
import jpype
import jpype.imports
jpype.startJVM()
import java
hm = java.util.HashMap()
hm.put("A","1")
hm.put("B","2")
u = dict(hm)
print(hm) #  Prints the Java hash map
print(u)    #  Prints a Python dict with same contents


[parsi] new port

[x] Changes comply with the maintainer guide.
[x] The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
[x] Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
[x] The versioning scheme in vcpkg.json matches what upstream says.
[x] The license declaration in vcpkg.json matches what upstream says.
[x] The installed as the "copyright" file matches what upstream says.
[x] The source code of the component installed comes from an authoritative source.
[x] The generated "usage text" is accurate. See adding-usage for context.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is in the new port's versions file.
[x] Only one version is added to each modified port's versions file.

Putting the issue link here just to make these two (PR and issue) related: https://github.com/microsoft/vcpkg/issues/39416

Tested usage successfully by parsi:x64-windows:
parsi provides CMake targets:

  find_package(parsi CONFIG REQUIRED)
  target_link_libraries(main PRIVATE parsi::parsi)

Tagging vcpkg-team-review for a second opinion on the name 'parsi'.
It doesn't appear on Repology or in search results for 'parsi c++', but that search matches nothing else either, so I think confusion is unlikely, so I'm inclined to merge this as is.
@cthulhu-irl Note that we would always accept the form 'github-org-name', in this case cthulhu-irl-parsi.
Thanks for the new port!

Thanks for the new port!


Spawn waist xsensmt standalone and attach to the nws

This PR fixes #355
With these changes the xsensmt device of the waist is spawn standalone and then attached by its nws(multipleanalogsensorsserver) and by its deprecated nws(analogServer).
Please review code.

Today thanks to @HosameldinMohamed I was able to tests these changes on iRonCub, I found some small issues that I fixed on all the robot. I think it is ready for merging

Merging anyway.
Possible kinks can be fixed later.

Merging anyway. Possible kinks can be fixed later.

It seems fine! It is probably relevant for people mantaining copies/forks of this configuration files, that they may want to get aligned: @gabrielenava @HosameldinMohamed @S-Dafarra @GiulioRomualdi @isorrentino .


radio check method broken if documented markup is used

Out test/dev markup does not match our documentation, so our radio methods are failing if the documented markup is used. I believe this only affects 3.7.0-3.7.1. Previously releases should not be affected.
This works:

          <input class="sr-only" name="radio1" type="radio" value="" id="radio1">
          Custom radio unchecked on page load

https://github.com/ExactTarget/fuelux/blob/master/index.html#L725
This does NOT work:

    <input class="sr-only" name="radioEx1" type="radio" value="option1">
    Browser-independent radio unchecked on page load

http://getfuelux.com/javascript.html#radio
The plan is to release an update to the code that allows the documented markup to work.

We need to change documentation to put data-initialize on the label.  We should not support data-initialization on multiple tags


Add support for environment variables as a source without code modification

Is is possible to add support for sourcing environment variables, like the old j2 tool was doing?
Right now I have to modify my code to force it to use environment variables, which was not the case with the j2 tool.

This has existed for a while.


[MERGE January 26] Publish student-finance-forms changes

Closing: will need to redo after style changes due to Smartdown bump.


Small typo  channel:manage_redemptions -> channel:manage:redemptions

Thanks for you work !

Thanks for spotting this! Please rebase onto support/4.3 and then change the PR target on GitHub too.

Sorry I don't know how to do that ... I did a new PR.


Authoriziation

Thanks for the readme update,  Once I pulled the files into my CLR I was able to create the calls and run the samples.  Now I am making a call to a third party to retrieve Json formatted data. In Postman I send the string with Basic Auth entering my username and password.  The  authorization header is automatically generated on the send to allow the access.
Do you have an API_Consumer proc that uses the auth in a header or
how would I handle constructing a get request requiring basic authentication sent in the header. Where each request requires the username and password in a header.
Thanks for the additional help

Hey, I will take a look to it at night, and I'll update the code. I think that actually we just can send credentials in Post method as JsonBody.
Is that a public service that I can test?

I really do appreciate your quick response and help but Unfortunately this is not something we can use for test  since it is a private service that we have purchased and contains sensitive data.

From: Geraldo Diaz<EMAIL_ADDRESS>Sent: Wednesday, May 1, 2019 12:16 PM
To: geral2/SQL-APIConsumer
Cc: deansterdean; Author
Subject: Re: [geral2/SQL-APIConsumer] Authoriziation (#11)
Hey, I will take a look to it at night, and I'll update the code. I think that actually we just can send credentials in Post method as JsonBody.
Is that a public service that I can test?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgeral2%2FSQL-APIConsumer%2Fissues%2F11%23issuecomment-488329630&data=02|01||5a314074a1e04059007908d6ce507013|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636923242198737305&sdata=AAPm8PwK6AY2KqsGezYctVzU7qGI32uWN%2FJPSET90%2Bc%3D&reserved=0, or mute the threadhttps://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAL5OT256NBGJPUKU4BIHRRTPTG67VANCNFSM4HJULWEQ&data=02|01||5a314074a1e04059007908d6ce507013|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636923242198747313&sdata=CBoorKs0i%2FUFJHoksE1WPGtAXoL7UQNk5yPkZ5SiQP4%3D&reserved=0.

Don't worry I will create an API to try to reproduce this scenario. I will let you know tonight.

@deansterdean before doing anything could you please try this:
 DECLARE @Credentials AS VARCHAR(MAX)

    SET @Credentials = CONCAT('Basic ','user:pass')

    EXEC [dbo].[APICaller_GETAuth]
         @URL	  = 'http://localhost:5000/api/values'
       , @Token  = @Credentials

This was already covered on bug #2. Instead of sending token send the Basic Auth, like this:
DECLARE @Credentials AS VARCHAR(MAX)

    SET @Credentials = CONCAT('Basic ','user:pass')

    EXEC [dbo].[APICaller_GETAuth]
         @URL	  = 'http://localhost:5000/api/values'
       , @Token  = @Credentials


check if the selector returned anything before using it

https://github.com/mhsjlw/flying-squid/blob/master/src/lib/plugins/tp.js#L17

done in 9366c1b9a77a94ef61418e6e92596bbd623fc536

Need to check both entities_from and entity_to, not just one.

yes, I did that fix in 47c75671c44460a667ccdf536ec471503d8e6dd9


Revert user input

Fix for https://github.com/ng2-ui/ng2-auto-complete/issues/155

revertValue is somewhat confusing to me. How about accept-user-input with default value true;

Defaulting accept-user-input to true makes sense.  revertValue was intended to be private and not part of the API.  It is only used if accept-user-input is false and it stores the value that was present when the user started editing.  That way if the directive decides to reject the user input, it can wind back (revert) to that value.


Adding target attribute to nuspec file elements

On OS X pack-module.ps1 is including the content of custom/docs/exports/internal in the top level of the generated .nupkg rather than maintaining the directory structure.
Based on https://docs.microsoft.com/en-us/nuget/reference/nuspec#including-assembly-files a target attribute is required to ensure the correct structure is achieved

Apologies, I didn't think to double check Windows. If you want I can look at making the change OS specific?

I'm getting the same file listing when generating the package under Windows, OS X and Ubuntu with the latest change

/azp run


Exclude ostrich from zipkin-query-service

Inside the zipkin-query-service shadowJar, we get a /static/ folder with assets from ostrich. These resources clash with zipkin-ui assets, that are also in /static/. (After #1035 is merged).
We need to find some way to exclude ostrich from our project - is anybody up for that task?

To kill an ostrich.. This is what you seek?


GitHub registry.yaml cache paths inconsistent

/kind bug
What happened:
When initializing a new ksonnet app, an initial registry cache for incubator is created with the following path:
$ tree .ksonnet/
.ksonnet/
└── registries
    └── incubator
        └── 40285d8a14f1ac5787e405e1023cf0c07f6aa28c.yaml

Running a subsequent registry command, e.g. ks describe incubator, will create a cache with a different path:
$ ks registry describe incubator
...

$ tree .ksonnet/
.ksonnet/
└── registries
    ├── 40285d8a14f1ac5787e405e1023cf0c07f6aa28c.yaml
    └── incubator
        └── 40285d8a14f1ac5787e405e1023cf0c07f6aa28c.yaml

What you expected to happen:
Regisry cache paths should be consistent between app initialization and subsequent registry operations.
How to reproduce it (as minimally and precisely as possible):
ks init example && cd example
ks registry describe incubator
tree .ksonnet/

Anything else we need to know?:
Environment:

ksonnet version (use ks version): 0.11.0
Kubernetes version (use kubectl version): version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.0", GitCommit:"fc32d2f3698e36b93322a3465f63a14e9f0eaead", GitTreeState:"clean", BuildDate:"2018-03-26T16:44:10Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/amd64"}

No longer reproduces.


Compile Report without layout from C/SIDE delivered using ClickOnce

When trying to compile any report without a layout I receive the following error:

Tested only on domain-joined environment (on a container running with gMSA).

Obviously, there is missing the folder ReportLayout. If I copy it manually into the folder I can compile the reports.

@freddydk There is a problem with web.config included in the ReportLayout folder. This makes the ClickOnce package useless (cannot be downloaded).


[RFC] Distinguish model, booster and runtime when performing IO operations.

Background
I will use Python package as the example for below discussion, but it should be equally applicable to other language bindings.  Right now when XGBoost saves it's "model", it saves the tree_model or linear_model, plus some attributes like max_delta_step and predictor, which are not strictly related to the "model" itself.  Take neural network as an example, the "model" should be its weight and structure, and should has nothing to do with objective function or optimizer.  Such boundary also exists in XGBoost, where the concept of model needs to be restricted to trees or linear weights only.  I believe this is how the current IO interface was designed.
But now we have some more complicated situations, like the Booster is used in pickle, transferred between workers for distributed learning, used as checkpoing for model recovery etc.  In some of these scenarios, optimizer(or the term used in XGBoost, tree_method) and some objective parameters are crucial components in the saved file (or memory buffer, you know what I mean).  So with time we added lots of training parameters into the output file, and some more are coming with the excellent work by @chenqin for better rabit recovery procedures.
Also, there are generic parameters that define the runtime configuration, like gpu_id, nthread and verbosity, these are even less correlated to the concept of "model".  Saving them to disk is not really making sense.  But it's sometime necessary to serialize them in distributed setting.  For instance, right now the distributed monitor actually doesn't work as expected in distributed environment due to the fact that verbosity is lost in transferred booster.
Proposal
I proposed saving the "complete snapshot" of XGBoost before while trying to introduce the json serialization format, which should mitigate the above issues.  But as described, most of those parameters are not strictly related to the concept of "model", when user is only trying to save the resulting model and use it for prediction or want to share it over internet, those parameters are not only useless, but also adds additional complexity.  So here I suggest we split the model IO into two different logics, one for the model itself, like trees, while the other for a complete closure.  In normal model IO, like Booster.save_model, we output only the trees and strictly related parameters like num_features.  When users want to continue training or other operations on saved model, they need to set the parameters again.  While for transferring model between workers, or doing model checkpoint with pickle, we save the "complete snapshot".
Problem
I'm not an expert of distributed computation, so my thoughts could be naive.  Looking forward to your feedbacks.

@hcho3 @RAMitchell @CodingCat @chenqin

I don’t have any strong opinion on this, but I am actually not aware of that we are adding training parameters to booster directly
Before we materialize the proposal here if we want, can we stop doing that? It is breaking compatibility of boosters across versions
For xgb-spark, the way I handled this is keeping everything in spark layer,
If you have special requirement for the bindings you work on, gpu, dask (and if we are adding anything related to rabit to xgboost params, we should definitely say no), then have your own param system

@CodingCat See IO logic here:
https://github.com/dmlc/xgboost/blob/c89bcc4de5368b3f8a7fa170d8348287dab44caf/src/learner.cc#L329
https://github.com/dmlc/xgboost/blob/c89bcc4de5368b3f8a7fa170d8348287dab44caf/src/learner.cc#L342
and many more in the Save and Load.  Also changes in #4808 . It's quite a headache.

@CodingCat I traced down some of those commits by git blame.  Right now I don't have a better solution to work with these parameters.  Are you suggesting that we should make a copy of all parameters in language bindings?

my idea is that (forget about my comments on gpu, it’s different with dask, spark, etc.)
(1) we should keep what is output from that code you referred is general to all bindings
(2) each binding must have some special requirement, e.g. spark needs to decide whether to cache input dataset. All of such params should not go to the booster serialized form
(3) to interact with “core” params in xgb, yes, you kind of need to have a way to pass param from your binding’s param system to “core” xgb params

we should keep what is output from that code you referred is general to all bindings

Definitely.
The problem is, whether do we split model IO into two separated code path, one saves the model (trees) only, while the other saves all those core parameters to meet the requirements of distributed setting.

I am actually not aware of that we are adding training parameters to booster directly

I mean I am unaware that we are adding new params to that, ( yes, I know we have already bunch of params there....)

The problem is, whether do we split model IO into two separated code path, one saves the model (trees) only, while the other saves all those core parameters to meet the requirements of distributed setting.

For this, my personal suggestion,
(1) scope how many special parameters (for dask, spark, rabit, etc) which already added in, and see if we can clean up
(2) stop adding more
(3) to minimize the workload and changes on model format, keep all remaining parameters after a potential cleanup in (1) and ensure that all of things there are general to all bindings (e.g. everyone needs a max_delta_step, but not everyone needs a rabit thing or a spark thing etc.)

I recall both R and Python has some assumption how sequential IO performed in C++ layer.
The challenge of clean up are

parameters some times get overwritten based on run-time environment
parameters were stored with booster without clear section and offset information

We might consider adding a header section where all bindings can fetch certain sections payload starts from offsets in meta
https://en.wikipedia.org/wiki/Executable_and_Linkable_Format

@CodingCat

scope how many special parameters (for dask, spark, rabit, etc) which already added in, and see if we can clean up

We don't have any binding specific parameter in C++ code.  No need to worry about that. ;-)
Let me clarify a little bit more.  I want to split up the interface into two separated io logics.  One saves "trees" and the other saves everything like "core parameters along with trees".
  It can not be used to recover training without providing appropriate parameters again, since it's just the model, no max_delta_step, predictor, no gpu_id etc, only the trained trees.
The other one saves everything, including predictor, max_delta_step, objective=softmax and of course, trees.  It can be used for model recovery since it contains all information needed to carry out training.  But normally you don't share this one on the internet...

@chenqin I'm definitely going to JSON for this.  If binary model is preferred, I would go with binary JSON.  Search the term "bson".

One extra benefit of doing this is, we only need to keep model compatibility for the bare tree model.  Since that's the format actually saved to disk.  For the "save everything option", it should only be used in model recovery or debugging, we can keep it internal and never concern its compatibility.

@trivialfis +1 for the proposal. I introduced SAVED_PARAM_ hack a while ago to preserve the state of predictor param. Your new proposal will reduce the complexity of IO logic while enabling "complete snapshot", thus killing two birds with one stone.
@CodingCat I don't think the proposal has anything to do with binding-specific parameters. Even when we only look at C++ code, the current mix of model and training parameter presents an issue.

+1 from me too. One situation I've encountered in the past had to do with model management or "provenance". The situation is I find a model artifact I've trained in the past that is somehow useful still, but can't be sure about how it was trained.
These days I'll usually dump the entire training parameter dictionary to a JSON file so in the future I can make sense of context around the model artifact. I think this proposal would help with that situation too,which I think is becoming common in ML pipelines.

+1 put additional information to make snapshot self contained. One possible application we might consider is debug retrain model degregation by loading snapshot of previous snapshot and compare how tree were shaped. side by side with new dataset and new trees.

Working on it.  Might take some time due to the massive changes.


Remove the YAML metadata driver from the documentation

I don't know if this should be merged right away, but the code was removed in #5932.

Related: https://github.com/doctrine/DoctrineBundle/issues/776#issuecomment-363812362


Cannot resolve all parameters for 'NgFileSelect'

Hi,
I am facing an issue when using ng2-uploader:
EXCEPTION: Error: Uncaught (in promise): Cannot resolve all parameters for 'NgFileSelect'(?). Make sure that all the parameters are decorated with Inject or have valid type annotations and that 'NgFileSelect' is decorated with Injectable.
Please let me know how to resolve this issue.

Hi,
After switching from SystemJS to Webpack, I have the same issue, anyone have a solution to fix that?

Duplicate issue, see : https://github.com/jkuri/ng2-uploader/issues/16


How do you install the contrib packages?

I've looked everywhere, but I can't seem to find how to install the trigram and fuzzy contrib packages. I am currently using Ubuntu 11.10 and Postgres 9.1.3 (recently updated), but I can't figure out where exactly I am supposed to type 'CREATE EXTENSION' or 'gmake install.'
These are the comments I made while I was trying to figure it out, but I don't think it works still.
#1. go here http://www.cyberciti.biz/faq/linux-installing-postgresql-database-server/
#2. enter '$ su - postgres'
#3. password is either just enter, or you can define pword by 'sudo passwd postgres'
#4. '$ psql template1'
#5. 'CREATE EXTENSION pg_trgm'
#6. 'CREATE EXTENSION fuzzystrmatch'
cd /usr/share/postgresql/9.1/extension

For some reason the contrib package migration is not working on heroku. Does someone have a solution for this?

I'm having the same problems as everyone else. I performed a migration and schema.rb update but I still get
ActiveRecord::StatementInvalid: PG::UndefinedFunction: ERROR:  function pg_search_dmetaphone(text) does not exist

@nodox Does you schema have these at the top:
enable_extension "plpgsql"
enable_extension "pg_trgm"
enable_extension "fuzzystrmatch"
I run into this problem every time I use pg_search and quite honestly I never know what fixes it. Possibly try to do:
bundle exec rake db:schema:load
bundle exec rake db:structure:load
Otherwise I've also solved it by doing this:
http://stackoverflow.com/questions/40956518/pg-search-dmetaphone-not-working-after-installing-contrib-package/40956519#40956519

@Babbz75 Thanks for the response. I got it working using the last comment on issue #175
Here is what steps I did specifically:

db/schema.rb -> Added these lines manually. Not sure if it'll get overridden later.

ActiveRecord::Schema.define(version: xxx) do

  # These are extensions that must be enabled in order to support this database
  enable_extension "plpgsql"
  enable_extension "pg_trgm"
  enable_extension "fuzzystrmatch"

Created a migration to enable the extensions in postgres

class InstallPgPackages < ActiveRecord::Migration[5.0]
  def up
    execute "CREATE EXTENSION IF NOT EXISTS pg_trgm"
    execute "CREATE EXTENSION IF NOT EXISTS fuzzystrmatch"
  end

  def down
    execute "DROP EXTENSION IF EXISTS pg_trgm"
    execute "DROP EXTENSION IF EXISTS fuzzystrmatch"
  end
end

Created this migration which might be redundant to step 1

class AddPGExtensions < ActiveRecord::Migration[5.0]
  def change
    enable_extension "pg_trgm"
    enable_extension "fuzzystrmatch"
  end
end

Ran rails g pg_search:migration:dmetaphone to get

class AddPgSearchDmetaphoneSupportFunctions < ActiveRecord::Migration
  def self.up
    say_with_time("Adding support functions for pg_search :dmetaphone") do
      execute <<-'SQL'
CREATE OR REPLACE FUNCTION pg_search_dmetaphone(text) RETURNS text LANGUAGE SQL IMMUTABLE STRICT AS $function$
  SELECT array_to_string(ARRAY(SELECT dmetaphone(unnest(regexp_split_to_array($1, E'\\s+')))), ' ')
$function$;
      SQL
    end
  end

  def self.down
    say_with_time("Dropping support functions for pg_search :dmetaphone") do
      execute <<-'SQL'
DROP FUNCTION pg_search_dmetaphone(text);
      SQL
    end
  end
end

Reload rails server and pg server (as a counter measure)

Here's our documentation for installing PostgreSQL extensions.


#0: Increase timeout to 50 mins for single card model perf pipelines

Ticket
Didn't make a ticket - just a quick timeout bump to account for llm increasing in runtime
Problem description
We're frequently taking more than 35 mins for the llm step, where the current timeout is 40min.
What's changed
40 > 50
Checklist

[ ] Post commit CI passes
[ ] Model regression CI testing passes (if applicable)
[ ] New/Existing tests provide coverage for changes

@mtairum @esmalTT @skhorasganiTT Any reason we're pushing such high timeouts for single card model perf? Does this mean our e2e time is increasing?

Fast dispatch uses the slower, functional-only VMs (which we have dozens of, obviously) so that would make sense.
I'm ok bumping timeout, but have you been keeping track of how long the e2e test has been running at all? This is a little concerning that we seem to be hitting a timeout that we haven't changed in a long time.

For Falcon7b, single-chip model perf runs take ~12 min. No recently added tests or e2e perf regressions as far as I am aware.

I've looked at recent logs for the perf pipeline and seems that Mistral perf test fails often, but that doesn't get picked up in the test (still shows green 😔
I'm investigating these and will add a fix to the ongoing PR we have for Mistral.

Sounds good thanks guys
@esmalTT @kpaigwar anything to add for mamba?

Sounds good thanks guys
@esmalTT @kpaigwar anything to add for mamba?

@tt-rkim Looks good to me. We did add some extra demo test cases last week, which would have increased the total pipeline time a bit.


Initial targetY not actually applied

Hi. I might have found an issue. It seems the config.targetY initially set is not what is actually used when the code runs. See this example:
https://editor.p5js.org/JuanIrache/sketches/JH9XXXwCK
(I'm sharing it in the p5js editor because codesandbox is very unstable when running this, but you can try it thereif you prefer)
https://codesandbox.io/s/p5js-webxr-looking-glass-tfddd4
I'm importing the library as a tag in index.html and setting the config like in the provided examples, including.
config.targetY = 0;
Then when run the page and enter VR, the cube is not centered but near the top margin. If you reset the targetY from the UI to be zero (it already looks like zero, but try it), the cube goes to the center as expected.
Edit: Interestingly, if you remove the config.targetY = 0; line entirely, the target is centered! (I will comment that line for now, uncomment it to reproduce the problem)

interesting, thanks for providing the link I'll take a look at it! It looks like this is only affecting the version available via the

This will be fixed in the next release of the library 👍🏻

This was fixed a while ago, forgot to close 😅


Branch filtering with DITA Maps and metadata keys [DOT 2.x develop branch]

If in the example uploaded for:
https://github.com/dita-ot/dita-ot/issues/1992
in the flowers.ditamap you add this:
  <keydef keys="product" audience="expert">
    <topicmeta><keywords><keyword>Expert Product</keyword></keywords></topicmeta>
  </keydef>

  <keydef keys="product" audience="novice">
    <topicmeta><keywords><keyword>Novice Product</keyword></keywords></topicmeta>
  </keydef>

and in the index.dita you use the title like this:
  <title>Index <ph keyref="product"/></title>

then publish to XHTML there will be an error reported:
 [DOTJ045I] The key "product" is defined more than once in the same map file. The reference href="null" is ignored.

and in the generated content both the TOC and the XHTML topics will have the "expert" value for the title.

Both flowers.ditamap references are in the same key scope, thus they share the same (implicit root) key scope and expert will take precedence because it's first in document order.

The "product" key is set on two keydefs but with different @audience attribute values.
So if filtering would be done before gathering the key then the "product" key would have distinct values depending on each branch.
Is there another way in which I could express this?

Branch filtering is done before key processing, since branch filtering can change key scope names. I think you want
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE map PUBLIC "-//OASIS//DTD DITA 1.3 Map//EN" "map.dtd">
<map>
  <title>DITA Topic Map</title>
  <topicref href="flowers.ditamap" format="ditamap" keyscope="expert">
    <ditavalref href="expert.ditaval"/>
  </topicref>
  <topicref href="flowers.ditamap" format="ditamap" keyscope="novice">
    <ditavalref href="novice.ditaval"/>
  </topicref>
</map>

This way the two index.dita renditions will be processed in different key scopes and the effective key definitions are different.

Thanks J.
I updated your latest changes, your proposes workaround work. Indeed probably my first impression was that once you define a branch you also have some kind of anonymous keyscope for it.

I would expect the <dvrKeyscopePrefix> or <dvrKeyscopeSuffix> elements to work here too -- you could do:
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE map PUBLIC "-//OASIS//DTD DITA 1.3 Map//EN" "map.dtd">
<map>
  <title>DITA Topic Map</title>
  <topicref href="flowers.ditamap" format="ditamap">
    <ditavalref href="expert.ditaval">
       <ditavalmeta><dvrKeyscopePrefix>expert</dvrKeyscopePrefix></ditavalmeta>
    </ditavalref>
    <ditavalref href="novice.ditaval">
       <ditavalmeta><dvrKeyscopePrefix>novice</dvrKeyscopePrefix></ditavalmeta>
     </ditavalref>
  </topicref>
</map>

There is no existing scope name on the branch, so the "prefix" becomes the scope name. It might look a bit more logical if you added a simple scope value on the topicref as well, but I don't think it's necessary.

I would not expect the prefix/suffix to actually create scopes. This means for consistency <dvrResourePrefix>expert</dvrResourcePrefix> should create a resource expert from a <topichead> inside the branch, and IMO that's really not what users would expect.

@jelovirt has convinced me -- if you want to create a scope there, use @keyscope; if you want different scopes, also add the prefix or suffix metadata. Otherwise, there's no way to tweak the name of nested scopes without also creating one on the parent. [Also chatted a bit with Chris Nitchie, inventor of the key scope, who agrees with that.]

So @raducoravu I think to do what you originally wanted, you could use the map @jelovirt included, or you could do something like this - adding some value for @keyscope on the map reference:
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE map PUBLIC "-//OASIS//DTD DITA 1.3 Map//EN" "map.dtd">
<map>
  <title>DITA Topic Map</title>
  <topicref href="flowers.ditamap" format="ditamap" keyscope="value">
    <ditavalref href="expert.ditaval">
       <ditavalmeta><dvrKeyscopePrefix>expert</dvrKeyscopePrefix></ditavalmeta>
    </ditavalref>
    <ditavalref href="novice.ditaval">
       <ditavalmeta><dvrKeyscopePrefix>novice</dvrKeyscopePrefix></ditavalmeta>
     </ditavalref>
  </topicref>
</map>

I agree: the keyscope must be specified on the topicref that contains the ditavalref, otherwise there is no keyscope, even if a prefix or suffix is specified.
It should go without saying, but if @keyscope is specified and no prefix or suffix is specified, then you end up with two peer keyscopes with the same scope name. In that case, the qualified keys from the first keyscope take precedence over those from the second.
So in general, it would be user error to specify a @keyscope attribute and not specify a prefix or suffix for each implicit copy.

Right, thanks.


Move logic in ./tool/build_sdk.sh to the SDK build process

It's a bit brittle to require such a step before committing.

another benefit is we can delete the checked in ".sum" binary file and the JS files too.

this was done :D


Use window.top.location instead of window.location when embedded in iframe?

see https://github.com/openstreetmap/openstreetmap-website/issues/1518
The issue here is that on openstreetmap.org, iD is running in an iframe.  We detect the host using this line of code.
window.location.origin + window.location.pathname
writes "https://www.openstreetmap.org/id" into the changeset host tag.
When embedded, we could do:
window.top.location.origin + window.top.location.pathname
to get "http://www.openstreetmap.org/edit" in the changeset host tag.

Perhaps id should check if all needed libraries are loaded and abort gracefully with a message in the body. This could contain a link to the osm main page.

You said

You're right that window.location when embedded in an iframe is not the true location.

But in a way that is the true location. /edit can give multiple editors depending on the user preference.
Perhaps under this URL there could be id version 5 under a iframe /iD and a version 10 under /id10
Putting /edit in the tag would not differ both. But the version tag would...
But still we had the problem with old URLs in the DB right now

#2449 describes more why we have a host tag.  It's mostly so we can see which site is using iD so that we can track down mapping and translation issues caused by people running old versions.
In practice, people are not running multiple versions of iD in multiple iframes, and I think for usability purposes it is better to record a URL that people can actually visit.

For the current stored (many) urls IMHO we should have a solution. So i am not really sure if changing the url in the future is really needed

For the current stored (many) urls IMHO we should have a solution. So i am not really sure if changing the url in the future is really needed

Just because there is existing stored changeset tags that point to the invalid url doesn't mean we can't fix the problem.  If anybody really cares, somebody could run a SQL update to change all the old values.


Is llum needed with laravel 5.5 and package discovery?

Create new major version for Laravel 5.5 above without dependency on acacha/llum?

Used in
https://github.com/acacha/adminlte-laravel-installer/blob/master/src/Console/SocialCommand.php
https://github.com/acacha/llum/blob/master/src/config/packages.php
Support autodiscover on acacha/laravel-social package: https://github.com/acacha/laravel-social
https://github.com/acacha/laravel-social/issues/12

https://github.com/acacha/llum/issues/36

Tasks:

BaseCommand no needed no more
SocialCommand only require acacha social package (add support firt for discover in https://github.com/acacha/laravel-social)
No llum option no needed
Remove dependency on composer.json

Done


consider reading FromService attribute data (not attribute -> no dependency of assembly)

Current:
public await Task<Foo> GetFoo([Service]MyRepo repo) {
  ..
}

Expected:
ASP.NET FromServiceAttribute also works (so 2 way):
public await Task<Foo> GetFoo([FromService]MyRepo repo) {
  ..
}

Why:
Not sure why [Service] was invented overall, [FromService] tells more  (from) and is know to all ASP.NET devs. So considering attribute data (not attribute) of FromService to work, will make migration for GQL <-> EP back and forth easy.

currently, my code has no revolvers, not attributes from gql, except [Service]. Data loader is fine - its unique concept. I know there are some GQL attributes like GqlDeprecated, not sure if usual Deprecated is supported? I mean keeping old attributes to work will make much value for me.

I have added it ... will be in the next preview go 11.1


Use other icons, especially for folders.

What feature or improvement do you think would benefit Files?
Files uses the icons provided by Windows for the displayed elements (drives, folders, files, ...).
Advantages:

These icons are known to everyone.
We take advantage of future Windows improvements.
Disadvantages:
This limits our unique visual identity.
The visual identity may change according to Windows versions (including in the future).

We can use other icons for elements (drives, folders, ..., but not files because there are too many variants). There are already free packs. This should be an option to show windows icons.
We can also modify the color of the folders (not always yellow). This is how it is with Linux (Dolphin or Nautilus). It looks nice.
Requirements

Move the generation of icons in several implementations of an interface.
Generate folder icon from svg by changing colors.

Files Version
Version : <IP_ADDRESS> OS Version: 10.0.22621.963
Windows Version
Windows 11 22621.674
Comments

This works in theory but

it'll break support for displaying custom thumbnails
won't support folder previews

See #6142

An alternative approach would be to

detect when a file has a custom thumbnail (is there an API for this?)
generate our own folder previews

That being said, I'm pretty happy with the thumbnails provided in Windows and I'm not convinced this improves the file browsing experience.

I would say changing the folder color would be a useful addition

Especially tose yellow folders, Can we change the color in the future. I wanna set it blue, which looks like iPadOS' file manager

What about enabling folder previews? I had it enabled in default file explorer but haven't been able to figure out how to do it in files yet

Couple of thoughts

custom icons wouldn't display previews of the folders contents, this would be a downgrade from the current expereince.
should you be able to change colors on individual folders?


  Everything seems to work well until the system tries to create an order.  I am using the following test algo:
from catalyst import run_algorithm
from catalyst.api import order, order_target_percent, record, symbol
import pandas as pd

def initialize(context):
    context.asset = symbol('btc_usd')

def handle_data(context, data):
    order(context.asset, .001)
    record(btc=data.current(context.asset, 'price'))

run_algorithm(
    initialize=initialize,
    capital_base=300,
    handle_data=handle_data,
    exchange_name='gdax',
    live=True,
    algo_namespace='live_testing',
    base_currency='usd',
    simulate_orders=False
)

What did you expect to happen?
Using this algo, I expected to purchase .001 btc in my gdax account (and then I would stop the algo)

What happened instead?
I get the error at the bottom about create_order() having trouble with the 'symbol' argument:

(catalyst) C:\catalyst\alogs>catalyst live -f live_testing.py -x gdax --base-currency usd -n live_testing --capital-base 300
Running in paper trading mode.
[2018-04-08 22:16:52.835988] WARNING: run_algo: Catalyst is currently in ALPHA. It is going through rapid development and it is subject to errors. Please use carefully. We encourage you to report any issue on GitHub: https://github.com/enigmampc/catalyst/issues
[2018-04-08 22:16:52.835988] INFO: run_algo: Catalyst version 0.5.8
[2018-04-08 22:16:55.837188] INFO: run_algo: running algo in paper-trading mode
[2018-04-08 22:16:56.160975] WARNING: run_algo: Catalyst is currently in ALPHA. It is going through rapid development and it is subject to errors. Please use carefully. We encourage you to report any issue on GitHub: https://github.com/enigmampc/catalyst/issues
[2018-04-08 22:16:56.160975] INFO: run_algo: Catalyst version 0.5.8
[2018-04-08 22:16:59.161860] INFO: run_algo: running algo in live-trading mode
[2018-04-08 22:17:04.946564] INFO: exchange_algorithm: portfolio balances, cash: 341.3832, positions: 0.0
Traceback (most recent call last):
File "c:\catalyst\miniconda\envs\catalyst\lib\runpy.py", line 193, in run_module_as_main
"main", mod_spec)
File "c:\catalyst\miniconda\envs\catalyst\lib\runpy.py", line 85, in run_code
exec(code, run_globals)
File "C:\catalyst\miniconda\envs\catalyst\Scripts\catalyst.exe_main.py", line 9, in
File "c:\catalyst\miniconda\envs\catalyst\lib\site-packages\click\core.py", line 722, in call
return self.main(*args, **kwargs)
File "c:\catalyst\miniconda\envs\catalyst\lib\site-packages\click\core.py", line 697, in main
rv = self.invoke(ctx)
File "c:\catalyst\miniconda\envs\catalyst\lib\site-packages\click\core.py", line 1066, in invoke
return process_result(sub_ctx.command.invoke(sub_ctx))
File "c:\catalyst\miniconda\envs\catalyst\lib\site-packages\click\core.py", line 895, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "c:\catalyst\miniconda\envs\catalyst\lib\site-packages\click\core.py", line 535, in invoke
return callback(*args, **kwargs)
File "c:\catalyst\miniconda\envs\catalyst\lib\site-packages\catalyst_main.py", line 104, in _
return f(*args, **kwargs)
File "c:\catalyst\miniconda\envs\catalyst\lib\site-packages\click\decorators.py", line 17, in new_func
return f(get_current_context(), *args, **kwargs)
File "c:\catalyst\miniconda\envs\catalyst\lib\site-packages\catalyst_main.py", line 497, in live
stats_output=None,
File "c:\catalyst\miniconda\envs\catalyst\lib\site-packages\catalyst\utils\run_algo.py", line 338, in run
'script': algotext,
File "c:\catalyst\miniconda\envs\catalyst\lib\site-packages\catalyst\exchange\exchange_algorithm.py", line 423, in init
super(ExchangeTradingAlgorithmLive, self).init(*args, **kwargs)
File "c:\catalyst\miniconda\envs\catalyst\lib\site-packages\catalyst\exchange\exchange_algorithm.py", line 68, in init
super(ExchangeTradingAlgorithmBase, self).init(*args, **kwargs)
File "c:\catalyst\miniconda\envs\catalyst\lib\site-packages\catalyst\algorithm.py", line 376, in init
exec(code, self.namespace)
File "live_testing.py", line 23, in
simulate_orders=False
File "c:\catalyst\miniconda\envs\catalyst\lib\site-packages\catalyst\utils\run_algo.py", line 560, in run_algorithm
stats_output=stats_output
File "c:\catalyst\miniconda\envs\catalyst\lib\site-packages\catalyst\utils\run_algo.py", line 342, in _run
overwrite_sim_params=False,
File "c:\catalyst\miniconda\envs\catalyst\lib\site-packages\catalyst\exchange\exchange_algorithm.py", line 330, in run
data, overwrite_sim_params
File "c:\catalyst\miniconda\envs\catalyst\lib\site-packages\catalyst\algorithm.py", line 724, in run
for perf in self.get_generator():
File "c:\catalyst\miniconda\envs\catalyst\lib\site-packages\catalyst\gens\tradesimulation.py", line 224, in transform
for capital_change_packet in every_bar(dt):
File "c:\catalyst\miniconda\envs\catalyst\lib\site-packages\catalyst\gens\tradesimulation.py", line 137, in every_bar
handle_data(algo, current_data, dt_to_use)
File "c:\catalyst\miniconda\envs\catalyst\lib\site-packages\catalyst\utils\events.py", line 216, in handle_data
dt,
File "c:\catalyst\miniconda\envs\catalyst\lib\site-packages\catalyst\utils\events.py", line 235, in handle_data
self.callback(context, data)
File "c:\catalyst\miniconda\envs\catalyst\lib\site-packages\catalyst\exchange\exchange_algorithm.py", line 865, in handle_data
self.handle_data(self, data)
File "live_testing.py", line 12, in handle_data
order(context.asset, .001)
File "c:\catalyst\miniconda\envs\catalyst\lib\site-packages\catalyst\utils\api_support.py", line 57, in wrapped
return getattr(algo_instance, f.name)(*args, **kwargs)
File "c:\catalyst\miniconda\envs\catalyst\lib\site-packages\catalyst\utils\api_support.py", line 126, in wrapped_method
return method(self, *args, **kwargs)
File "c:\catalyst\miniconda\envs\catalyst\lib\site-packages\catalyst\algorithm.py", line 1462, in order
return self.blotter.order(asset, amount, style)
File "c:\catalyst\miniconda\envs\catalyst\lib\site-packages\catalyst\exchange\exchange_blotter.py", line 169, in order
if amount == 0:
File "c:\catalyst\miniconda\envs\catalyst\lib\site-packages\catalyst\exchange\exchange_blotter.py", line 185, in order
args=(asset, amount, style),
File "c:\catalyst\miniconda\envs\catalyst\lib\site-packages\redo_init.py", line 162, in retry
return action(*args, **kwargs)
File "c:\catalyst\miniconda\envs\catalyst\lib\site-packages\catalyst\exchange\exchange_blotter.py", line 163, in exchange_order
asset, amount, style
File "c:\catalyst\miniconda\envs\catalyst\lib\site-packages\catalyst\exchange\exchange.py", line 841, in order
return self.create_order(asset, amount, is_buy, style)
File "c:\catalyst\miniconda\envs\catalyst\lib\site-packages\catalyst\exchange\ccxt\ccxt_exchange.py", line 785, in create_order
price=price
TypeError: create_order() got an unexpected keyword argument 'symbol'

Here is how you can reproduce this issue on your machine:
Reproduction Steps

Use algo above
Run algo with this command: catalyst live -f live_testing.py -x gdax --base-currency usd -n live_testing --capital-base 300

What steps have you taken to resolve this already?
I have tried using different symbol naming structures such as "BTC/USD", "btcusd", etc.
Thank you!!  I am new to Catalyst - just learning.
Sincerely,
Roman Parker

Hi, Thanks for noting this out. for some reason the name of the symbol argument in create_order on CCXT (the api library, catalyst is using) was named market, specifically for GDAX. I opened an issue on ccxt and it was fixed. we will add this to our next release.

Excellent, thanks!

btw, if you upgrade ccxt to the latest version (pip install ccxt --upgrade), you will be able to run it properly.

Avishai, I did the update and it connected and executed the trades perfectly.  Thanks!


/help roomban: Add duration of ban

Will Reopen this when know for sure how long room bans are gonna last.


[WIP] Blog post: API Streaming

TODO: write a blog post about the API Streaming feature tracked by https://github.com/kubernetes/enhancements/issues/3157

Hi @p0lyn0mial, as it is in early stages, can you add a description of your raised PR.

Hello, I'm Yigit, from the 1.31 Release comms team. I'm reaching out with a reminder that the blog ready for review deadline is July 26, 2024. Please let me know how we can help!

Hi @p0lyn0mial, Is it ok to close this placeholder PR, as the KEP will miss the 1.31 release? https://github.com/kubernetes/enhancements/issues/3157#issuecomment-2238463474

Hi @p0lyn0mial, Is it ok to close this placeholder PR, as the KEP will miss the 1.31 release? https://github.com/kubernetes/enhancements/issues/3157#issuecomment-2238463474

yes, let's close it.
/close


Set max characters

Set max characters in the modeler or based on domain model

Unfortunately there is no way to find out what the maximum characters of a string is, if this is set in the domain model. We will implement a wordcount plugin to set this manually


Update openssl{,-sys} dependencies

Could you please update the dependencies on the openssl and openssl-sys crates in Cargo.lock to at least 0.9.4? Previous versions of those crates aren't compatible with LibreSSL.

Turns out libgit2-sys-0.6.2 isn't compatible with libressl either; updating to 0.6.6 should do the trick.

The request stems from https://bugs.gentoo.org/show_bug.cgi?id=604044. Effectively what @atlaua is looking for is a 0.15.1 tarball from crates.io that has an updated Cargo.lock.

Gentoo's packaging requires us to follow what the Cargo.lock has in it due to not allowing network access during the compilation phase. I've discussed this item in other tickets a whole bunch and have put it in practice. Our policy is https://wiki.gentoo.org/wiki/Project:Rust and I mentioned to @atlaua that this is likely unlikely to happen until the next release.
@atlaua My suggestion would be to open a PR where Cargo is built against libressl using Travis and/or the upstream depends of Cargo are tested that way.

I don't see how this is a gentoo-specific problem. Everyone building cargo will use the crate versions specified in Cargo.lock, right? (Unless they explicitly run "cargo update", of course). Hence, Cargo.lock should be updated if it references buggy crate versions.
And in the case you expect everyone building cargo to run "cargo update" beforehand: What's the point of shipping Cargo.lock in the git repo at all?
@cardoe Setting up a travis build to test libressl compatibility certainly sounds like a good idea to me. But I've absolutely zero experience with travis, so I probably won't be able to come up with an PR to realize this.

Sounds fine to me! Want to send a PR?

Sure, here you go: #3520 and #3521

By the way, care to enlighten me why Cargo.lock is included in the git repo at all? Isn't this just asking for trouble?

See http://doc.crates.io/guide.html#cargotoml-vs-cargolock and http://doc.crates.io/faq.html#why-do-binaries-have-cargolock-in-version-control-but-not-libraries for more info.

Thanks @cardoe, I wasn't aware this is officially recommended. (It still seems weird to me, anyway; surely every distro maintainer and security researcher would agree that hardwiring the exact versions of dependencies is a baaad idea.)

I believe we've since done this, so closing.


Avoided update CatalogDatabaseCache on the fly.

In distributed version, it is not safe to update cached CatalogRelationSchema on the fly, while some storage blocks still have reference to the existing schema.
So, disable updates in the cache for now.

@zuyu: So what happens when the catalog changes?

I have one refactoring suggestion for better performance and echoing @pateljm's question on catalog changes.

@pateljm @hbdeshmukh As noted in #110, we does not support schema changes.
When we support schema changes, we may want to have a version number in CatalogRelationSchema to indicate whether we need to update CatalogDatabaseCache.
If the changed schema has been cached, a naive way is to flush all the blocks belonged to the schema to the disk, before we reset the schema. There are certain scheduling optimization could be done as well, i.e., postpone the schema changes unless no queries are using it.

@hbdeshmukh I've refactored using fine-grained locks to update CatalogRelationSchemas. Please take a look. Thanks!

Looks good, merging.


a few mistakes with app

1/ the likes on your app is 1 more than what YouTube says
2/If a comment has more than 1k likes, it doesn't show as any likes
3/If I search for multiple words, it comes out empty. I also tried with "" , but nothing comes up

you can search for phrases using "extended search" though it doesn't highlight the phrase

I've encountered the same issue. Is it because YT represents comments with thousands of likes as "k" (e.g. 1100 likes = 1.1k, 25000 = 25k, etc.)?

yeah that's what I thought, when it see's a k , the app doesn't show the likes.

thank you
issue 1 and 2 is great.
regarding issue 3
using this video as example
https://www.youtube.com/watch?v=Nl_eJ-zdLrA
and search for "kind of clever"
produces the right comment, but as you can see It's also trying to highlight words beginning with "of" and "cle"
It picked up "circlejerk" for cle.
I would love if it could highlight only the term  "kind of clever" and nothing else. otherwise extension is great thanks

I would love if it could highlight only the term "kind of clever" and nothing else. otherwise extension is great thanks

About the search and filter buttons, I anticipated a lot of behavior inconsistency. However, they are quite obvious if you inspect the code directly. This leads me to believe they were intentionally designed this way. I think only the original author can answer this question...
Regardless, I'll try to adjust the search results in a more reasonable way. Thanks for your example.

If you go to https://github.com/sonigy/YCS/issues/56#issuecomment-2143792541
and at the bottom it says
"This form of advanced searching allows you to fine-tune results.
White space acts as an AND operator, while a single pipe (|) character acts as an OR operator. To escape white space, use double quote ex. ="scheme language" for exact match."
Maybe this is the reason why he kept the search this way?
I'll leave it up to you to see what you want to do with it. :)

is extended search working like original author listed on his github? looks like a cool advance search.
right now I can't understand the difference.
also here https://www.youtube.com/watch?v=vukiveN_Ag8
if you search "ram"
it brings up words like "parameters" "frame"
so I tried extended search
typed
=ram
for exact search, empty
then I tried
^ram
(prefix-exact-match)
and nothing. seems the original author wanted more control over search but it's not working even for basic search

is extended search working like original author listed on his github? looks like a cool advance search. right now I can't understand the difference.

I haven't made any changes to the extended search functionality, so it should operate as it did before.
The confusion may arise from the term "item" in the description. Here, "item" refers to the entire text chunk rather than a single word. Therefore, you should consider the whole comment as an item.

So, in the case of the transcript in your example video above, the correct way to search for the word ram is to use " ram " or '" ram " (to avoid matching fuzzy results).

Text searching in the extension is conducted via Fuse.js with the options below (useExtendedSearch is set to true when extended search is enabled):
{
  "isCaseSensitive": false,
  "findAllMatches": false,
  "includeMatches": false,
  "includeScore": true,
  "ignoreLocation": true,
  "useExtendedSearch": false,
  "minMatchCharLength": 1,
  "shouldSort": true,
  "threshold": 0.15,
  "distance": 100000
}

thanks it's much better.


Can't this info be centered？

Can't this info be centered？
Forge version：1.20.1-Forge-47.1.28

Not quite sure what you mean. It is centered around the x/y position.

ok


Add authentication

We'll be using auth0 to add authentication to the application.
At this stage user management will be done through the auth0 interface with no need to setup a user management page.
All the public routes that need to be protected are in app/routes.
The readme has to be updated to include information on how to setup and add users to auth0.
The authentication needs to be added to the frontend as well and is tracked in https://github.com/WorldBank-Transport/rra-frontend/issues/121

To ensure that the application continues to work in offline mode I propose we include an option to disable authentication altogether (since auth0 is an online service). When working offline authentication in not likely to be needed.
Any other suggestions?
@olafveerman


Updated MacOS install note & formatting

Added to the install note for MacOS on the M1, as Homebrew changed their default install directory for Apple Silicon (paths referenced further below are from an x64 installation). Also demoted the old version paragraphs to paragraph 3, nested under the "Previous Version" paragraph 2.

@davrax : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@David-Engel  - Can you review the proposed changes?
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
Thanks!
#label:"aq-pr-triaged"

@davrax : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@davrax : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

Thanks. Due to the upcoming Build conference, all merging and publishing is on hold until the morning of May 24.
This PR is ready for merge on 5/24.


Some typing errors in strings (Form1.cs)

I've found some typing errors in strings in Form1.cs
I'm not so familiar with github yet, but I started a pull request and hope this works. :)

for some reason it shows the whole file as changed (every line).. so i'm not sure what was changed..
looks like this issue,
https://stackoverflow.com/questions/19593909/git-diff-sees-whole-file-as-changed-when-its-not
are you using commandline git, or sourcetree, github desktop?

Oh, I see ... my fault, I just uploaded the single file manually via browser. I guess that (maybe) only works for new files. I closed the pull request and I will see if it helps to use one of the tools you mentioned.

Looks like the second try worked. What I haven't found in the files were e.g. the names of the tabs.
Maybe you'd like to change "Unity's" to "Unitys" or "Unity Versions"
and in Settings: "Explorer context menu:  Install / Uninstall" (consistency)
and "Check for Updates" ?
Yeah ... nitpicking by a non-coder.  :)

ok, looks fine now thanks! (ill merge it sometime this week)

this is now live, https://github.com/unitycoder/UnityLauncher/releases


DSC/PowerShellGroup incorrect group inDesiredState

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest version
[X] Search the existing issues.

Steps to reproduce
When all the resources in a PowerShellGroup are in the desired state, the group's inDesired state property is false. Looking at the code, I think it is because dsc compares the desiredState with actualState, but in the case of a PowerShellGroup the results are always going to be a single element with InDesiredState or an array of with the resources InDesiredState. Maybe dsc has to special case this group's result.
Expected behavior
Group's inDesiredState should be true if all its resource are in the desired state.

Actual behavior
PS D:\Dev\DSC> dsc resource test -r DSC/PowerShellGroup -i '{ "resources": [ { "name": "test", "type": "xE2ETestResource/E2EFileResource", "properties": { "path": "D:\\Dev\\DscV3\\testv3.txt", "content": "test" } } ] }'
  2023-11-21T21:59:55.212660Z  INFO dsc_lib::dscresources::command_resource: Invoking test DSC/PowerShellGroup using pwsh
    at D:\Dev\DSC\dsc_lib\src\dscresources\command_resource.rs:232

desiredState:
  resources:
  - name: test
    type: xE2ETestResource/E2EFileResource
    properties:
      path: D:\Dev\DscV3\testv3.txt
      content: test
actualState:
  InDesiredState: false
inDesiredState: false
differingProperties:
- resources
PS D:\Dev\DSC> dsc resource set -r DSC/PowerShellGroup -i '{ "resources": [ { "name": "test", "type": "xE2ETestResource/E2EFileResource", "properties": { "path": "D:\\Dev\\DscV3\\testv3.txt", "content": "test" } } ] }'
  2023-11-21T22:00:40.620243Z  INFO dsc_lib::dscresources::command_resource: Getting current state for set by invoking get DSC/PowerShellGroup using pwsh
    at D:\Dev\DSC\dsc_lib\src\dscresources\command_resource.rs:132

  2023-11-21T22:00:49.253187Z  INFO dsc_lib::dscresources::command_resource: Invoking set DSC/PowerShellGroup using pwsh
    at D:\Dev\DSC\dsc_lib\src\dscresources\command_resource.rs:145

beforeState:
  Path: D:\Dev\DscV3\testv3.txt
  Ensure: Present
  Content: ''
afterState:
  RebootRequired: false
changedProperties:
- RebootRequired
PS D:\Dev\DSC> dsc resource test -r DSC/PowerShellGroup -i '{ "resources": [ { "name": "test", "type": "xE2ETestResource/E2EFileResource", "properties": { "path": "D:\\Dev\\DscV3\\testv3.txt", "content": "test" } } ] }'
  2023-11-21T22:01:11.628882Z  INFO dsc_lib::dscresources::command_resource: Invoking test DSC/PowerShellGroup using pwsh
    at D:\Dev\DSC\dsc_lib\src\dscresources\command_resource.rs:232

desiredState:
  resources:
  - name: test
    type: xE2ETestResource/E2EFileResource
    properties:
      path: D:\Dev\DscV3\testv3.txt
      content: test
actualState:
  InDesiredState: true
inDesiredState: false
differingProperties:
- resources

Error details
No response
Environment data
PS D:\Dev\DSC> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      7.3.3
PSEdition                      Core
GitCommitId                    7.3.3
OS                             Microsoft Windows 10.0.25999
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Version
v3.0.0-alpha.4
Visuals
No response

It might make sense for test to only look at inDesiredState to determine state


Chromium doesn't support login by puppeteer to Google account anymore

I tried to run headless: false and saw the following error:

Having the same issue.


[#98272378] Create environment specific jenkins views

Create different jobs for deploying ci and demo in jenkins
What
Create CI and Demo specific views in jenkins
How to review this PR
I have written this PR in the following context:

I would like to be able to view each environments jobs separately without other environments cluttering my view

How to test this PR
A vagrant box has been provided for local testing, simply just:
vagrant up

Then browse to https://localhost:8443
You should see the following views there:

ci-view - Continuous Integration Environment Jobs
demo-view - Demo Environment Jobs

Who should review this PR

A Lazy Lemur, if a suitably relaxed primate can not be found then a member of the core team can step in.

The views are being created correctly, merging.


To help others out

You need to add an empty images folder to the app folder i.e.
..app/images
Also in Migrations.sol in the contracts folder add a ; at the end of line 8 so it reads:
if (msg.sender == owner) _;
Also add: pragma solidity ^0.4.2; to the start of Conference.sol and Migrations.sol
And now one that had me stumped change line 19  (it will be line 18) unless you add the pragma line to:
function  buyTicket() payable public {
That is add the payable modifier to the buyTicket() function. if you don't it will throw invalid jump!
And truffle test will fail.
Still having issues with the refund function specifically
the recipient.send(amount); line.

➤ Shawn Cicoria commented:
that last issue is if (! recipient.send(amount) ) throw;


Please tag version of gsplat==0.1.8

There are important fix by @jb-ye , so the version is 0.1.8

But, When I installed gsplat for first time by installing nerfstudio
git clone https://github.com/nerfstudio-project/nerfstudio
cd nerfstudio/
pip install -e .

I get gsplat==0.1.7 which I know when I ran pip list.

So please fix gsplat to version 0.1.8 since the gsplat==0.1.7 has problem which reduce quality significantly

Proof the reduction of quality of gsplat==0.1.7, it already fixed in 0.1.8. But I dont get gsplat==0.1.8 when I installed nerfstudio.

The way to fix it is installed manually compile from sourcegsplat by run this command pip install git+https://github.com/nerfstudio-project/gsplat.git

Closed as gsplat==0.1.8 already released


add template for pull requests, contribution expectations to developer's guide

Addresses #172.

 Otherwise I will do merge (without moving PR commits).
Thanks for sharing the reference to https://sethrobertson.github.io/GitBestPractices/. It is excellent and now my favorite introduction to Git best practices.

The cause was the presence of tabs in 98bd53af718c2899418a89bc715fc5d40a0a500e, before I shortened the lines in 38b94a9e24399fbe92c6a7becb81bc5d3f8ab808. I made invisible characters visible in the editor I'm using and replaced the tabs with spaces in b2aaf54874b9b919922fed2bd2d24e3adf368415.
Following the last commit, I have a slight preference for rebasing onto branch master.

I just tested the process of opening a new pull request, and thanks to the work of @johnyf here, the following message appears:

Please review the guidelines for contributing to this repository.

where "guidelines for contributing" links to https://github.com/tulip-control/tulip-control/blob/master/CONTRIBUTING.md


Create Demo deck

Deck for showcase/demo 07/06/2020: https://docs.google.com/presentation/d/13_OTFK65FW6LNo365nCGpVU-xzGY7hPUrxhwUSedmDQ/edit#slide=id.g8af6954c9b_0_399
Deck Narrative flow
Progress

Brief recap of the MVP usecase
Demo of sending an email when disability claim is submitted- (narrative) Qaysar & Phil + pair
Infrastructure - Marisa (different steps of the pipeline)
What’s next
Refining email content and design - Qaysar & Todd
Design piece - Todd
Moving this to VA infrastructure (talk about terraform) - Filip and dev team

Narrative: why did we did terraform and the reason we took the route
CI/CD, AWS account
And what’s next; strategy - Qaysar, Kennedy, and Anu

What is our thinking and approach
Next in pipeline/ roadmap (VBA "Payment Schedule", VAOS HSRM community appointment scheduling)

Action Items:

[ ] Confirm environment - Dev or review instance - Filip
[ ] Schedule dry and time to review deck with Clarice (Thursday) - Anu

Added a link to the outline of the deck. I've started adding details, as well as assigned folks to review the slides and add any other data to slides


There's a typo in the documentation of "scipy.optimize.rosen"

https://github.com/scipy/scipy/blob/fcdc3d7b7c1b950d874ac3e890cccde3e2de1c6c/scipy/optimize/optimize.py#L160
Should be
sum(100.0*(x[1:] - x[:-1]**2.0)**2.0 + (1 - x[:-1])**2.0 )

@sam1902 thanks for taking the time to report it. Care to send a PR ?

https://github.com/scipy/scipy/blob/dbf668065ed784e4dbbbce44db9d436b62f2b556/scipy/optimize/optimize.py#L171
The typo is fixed in maintenance/1.2.x
Should I still send a PR ?

Oh I thought you were looking at the master branch. Then no, we don't need to modify anything further since 1.2.x is branched out from the current master. I'll find the PR that fixed and mark this as a duplicate. Thanks anyways for your help though.

Duplicate of #6161


Can't resolve '@babel/runtime-corejs2/core-js/array/is-array' in '/snapshot/frontend/node_modules/next-server/dist/lib'

Hi there, have you had an idea of this?
https://github.com/zeit/pkg/issues/694
Thanks
Carlos Vieira

Please don't bring pkg issues from their repo

sorry you are right


⚠ Turnos 24x7 has degraded performance

In e76ec80, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 1087 ms

Resolved: Turnos 24x7 performance has improved in ee5f354.


Filtering Part of Speech

Is your feature request related to a problem? Please describe.
A new wordClass param should be handled by the backend that allows users to search for keywords that are only the specified wordClass.
Describe the solution you'd like

Handle a new param called wordClass that's expected to take in one of the WordClass.js values (for example, NNC or CJN) and filter word results
Create tests to make sure that this functionality works as expected

Describe alternatives you've considered
N/A
Additional context
N/A

Just started working on this


fix(requirements): Fix for issue #4

The following patch in requirements.txt file allows to fix the encountered bug with flask-restx extensions. It will installs latest version but maybe extra checks needs to be performed.

See my comment on #5


Search: doesn't return any results

Version: 3.2.8 beta
URL:
https://www.beta.patricbrc.org/view/FeatureList/?keyword("fig|573.3197.peg.4497")
User ID: KPNs_4_Houston
fig|573.3197.peg.4497
To clarify, the search does not work when you have "all types" selected in
the drop down, but it does when you ask for the specific type, which is
strange.

This works on alpha now, please verify.

This works on alpha now, please verify.

fixed, verified on alpha.


crash hls m3u8

thank you for helping me
Is it possible modify problem crash hls m3u8 and add output from utl http://<IP_ADDRESS>:1935/app/ch1.ts
ffplay http://<IP_ADDRESS>:1935/app/ch1..m3u8
Failed to open segment 447 of playlist 0/0
[http @ 0x7fa920564f80] Opening 'http://<IP_ADDRESS>:1935/app/ch1..m3u8' for reading
[hls @ 0x7fa920000cc0] Skip ('#EXT-X-VERSION:3')B sq= 0B f=0/0
[hls @ 0x7fa920000cc0] Skip ('#EXT-X-ALLOW-CACHE:NO')
[http @ 0x7fa9204c6c80] Opening 'http://<IP_ADDRESS>:1935/app/ch1./1700845766982990.ts' for reading
[hls @ 0x7fa920000cc0] Opening 'http://<IP_ADDRESS>:1935/app/ch1./1700845770966107.ts' for reading
[mpegts @ 0x7fa920007940] PES packet size mismatchsq= 0B f=0/0
[mpegts @ 0x7fa920007940] Packet corrupt (stream = 0, dts = 160362000).
[h264 @ 0x7fa920195580] cabac decode of qscale diff failed at 2 14
[h264 @ 0x7fa920195580] error while decoding MB 2 14, bytestream 534
and in vlc problem crash hls m3u8

not http://<IP_ADDRESS>:1935/app/ch1..m3u8
instead http://<IP_ADDRESS>:1935/app/ch1.m3u8


changed ISC to MIT

Changed ISC to "MIT" for pull request

I am closing it as it was already fixed by an earlier pull request.
Thank you for the help, and I hope to see more contributions from you 👍


Interface metering and source of truth for gas left

In runevm there are two sources of truth for the remaining gas during a transaction. One stored by the host, and one by parity's interpreter.
This would be no problem if runevm were to meter everything and only do a consumeGas at the end to let the host know how much gas it has spent. But some hosts (e.g. hera) meter EEI methods themselves, which means the gas costs stored by the interpreter and the host diverges.
I was wondering what others think about these alternatives, and whether there are better approaches I'm not seeing:

Disable interface metering in hosts (e.g. add a flag to hera for this), add the methods mentioned in https://github.com/ewasm/design/issues/138 to the EEI, and do complete metering in runevm.
Keep interface metering in hosts and to keep the gas costs in sync (necessary for e.g. EIP150):

do a consumeGas after instructions which don't call an EEI method
do a getGasLeft after instructions which do call an EEI method

Hera has an option to disable metering entirely. That was meant to be used with evm2wasm or runevm. In that case everything should be metered by runevm.

Probably the best approach is to also make it optional in runevm for now.


Beginning of CircleSnail animation is choppy

Hi there,
Great work on this package. We're using the CircleSnail component. The beginning of the animation is choppy and at some point it becomes smooth. Unfortunately, we're playing the animation for only showing the component for 1.5 seconds and during that time, the animation never gets smooth. Is there anything we can do to fix this issue?
Here's my code:
<CircleSnail
  direction="clockwise"
  duration={500}
  spinDuration={2000}
  color={Colors.white}
  size={27}
  indeterminate
  thickness={2}
/>

This is an animated gif of the 1.5 second spinner:

For comparison, I saved an animated gif of the 10 second spinner with the choppiness at the beginning and then getting smooth after about 1.5 second:

I figured out the issue. I have BE requests running the background which slow down the animation. Still not sure how to solve it though.

@zeckdude Hello! Did you solve this?

No :(
It's still slow. I tried to use shouldComponentUpdate to limit the amount of re-renders, but it's still choppy.

adding key={1} to View that wrapper of CircleSnail, this stop reRender.


Add Power Support ppc64le

Added power support for the travis.yml file with ppc64le. This is part of the Ubuntu distribution for ppc64le. This helps us simplify testing later when distributions are re-building and re-releasing.

Coverage remained the same at 100.0% when pulling 5a5da0d14cc7c9113ca8b51248cf7f675121150d on nagesh4193:develop into aa7eca7fcfc5566df7825dd730a8f61bafe91695 on WoLpH:develop.

Coverage remained the same at 100.0% when pulling 5a5da0d14cc7c9113ca8b51248cf7f675121150d on nagesh4193:develop into aa7eca7fcfc5566df7825dd730a8f61bafe91695 on WoLpH:develop.

The pull request looks great. Thank you for the work :)


Typo in rml:referenceFormulation ql:JSONPath;

Hi,
When we convert to RML file, after the source at rml:referenceFormulation we have
rml:referenceFormulation ql:JSONpath;
where p is small in ql:JSONpath
Please fix it to ql"JSONPath because P has to be capital.
Thanks

solved


Support Altherma 3 R W

Hello,
I have the Daikin Altherma 3 R W Model, EHBX and ERGA.
Maybe you can support it? Or which existing configuration comes close to it?
It's a simple split-device only for underfloor heating.

I updated the file names. It should be better for finding the right definition now:
Altherma(ERGA E EHV-EHB-EHVZ E_EJ series 04-08kW).h


No option to get output transcriptions in any popular subtitle format

Hi,
Thank you for making whisper available. It's a great tool.
After reading this article https://simonwillison.net/2022/Sep/30/action-transcription/ I decided to give whisper a go.
It worked remarkably well.
Although, there's no way to get the output transcription in srt or vtt format.

SubRip srt https://en.wikipedia.org/wiki/.srt
WebVTT vtt https://en.wikipedia.org/wiki/WebVTT

whisper does support both formats -> https://github.com/openai/whisper/blob/0b1ba3d46ebf7fe6f953acfd8cad62a4f851b49f/whisper/transcribe.py#L306-L312
It'd be great to have it, so the users could generate timed transcriptions (subtitles) for the videos they'd like to watch.
Here's an example scenario describing the use case:
Given I have an audio track file in any language supported by whisper
When I run the model with an argument to generate timed transcription in "(srt|vtt)" format
And I GET the prediction via API
Then I should see the transcription and additional timed transcription in "(srt|vtt)" format

Thanks

cc @kevin01881 @ronyfadel who have asked about this functionality.
@chenxwh may be able to add support for this, but this is an open-source project so any of you should feel free to fork this repo, implement the changes to add support for subtitle output, and open a PR here.

The subtitle downloading option was included in my initial implementation, but was suggested by Andreas and Ben not to include in the openai/whisper Demo. I have pushed it to another demo here: https://replicate.com/cjwbw/whisper-downloadable-subtitles

Awesome! Any chance there'll be an update sometime that would timestamp the
subtitles?
Op ma 3 okt. 2022 23:02 schreef Chenxi @.***>:

The subtitle downloading option was included in my initial implementation,
but was suggested by Andreas and Ben not to include in the openai/whisper
Demo. I have pushed it to another demo here:
https://replicate.com/cjwbw/whisper-downloadable-subtitles
—
Reply to this email directly, view it on GitHub
https://github.com/chenxwh/cog-whisper/issues/1#issuecomment-1266044811,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A2MEFMI7S4DRUW2L4Q5ZM73WBNCVJANCNFSM6AAAAAAQ2LZPLU
.
You are receiving this because you were mentioned.Message ID:
@.***>

Awesome! Any chance there'll be an update sometime that would timestamp the subtitles? Op ma 3 okt. 2022 23:02 schreef Chenxi @.>:
…
The subtitle downloading option was included in my initial implementation, but was suggested by Andreas and Ben not to include in the openai/whisper Demo. I have pushed it to another demo here: https://replicate.com/cjwbw/whisper-downloadable-subtitles — Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2MEFMI7S4DRUW2L4Q5ZM73WBNCVJANCNFSM6AAAAAAQ2LZPLU . You are receiving this because you were mentioned.Message ID: @.>

.srt file is already with timestamp?

@chenxwh you're correct, I downloaded the txt instead of the SRT, D'OH!
Hahah. Thanks, awesome!!
Op ma 3 okt. 2022 23:06 schreef Chenxi @.***>:

Awesome! Any chance there'll be an update sometime that would timestamp
the subtitles? Op ma 3 okt. 2022 23:02 schreef Chenxi @.
>: … <#m_-7600736660076738685_> The subtitle downloading option was
included in my initial implementation, but was suggested by Andreas and Ben
not to include in the openai/whisper Demo. I have pushed it to another demo
here: https://replicate.com/cjwbw/whisper-downloadable-subtitles
https://replicate.com/cjwbw/whisper-downloadable-subtitles — Reply to
this email directly, view it on GitHub <#1 (comment)
https://github.com/chenxwh/cog-whisper/issues/1#issuecomment-1266044811>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A2MEFMI7S4DRUW2L4Q5ZM73WBNCVJANCNFSM6AAAAAAQ2LZPLU
https://github.com/notifications/unsubscribe-auth/A2MEFMI7S4DRUW2L4Q5ZM73WBNCVJANCNFSM6AAAAAAQ2LZPLU
. You are receiving this because you were mentioned.Message ID: @.>
.srt file is already with timestamp?
—
Reply to this email directly, view it on GitHub
https://github.com/chenxwh/cog-whisper/issues/1#issuecomment-1266049174,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A2MEFMNOWGCNLE5VGFF3JTTWBNDFXANCNFSM6AAAAAAQ2LZPLU
.
You are receiving this because you were mentioned.Message ID:
@.***>

Thanks @chenxwh for the new demo. I just gave it a go and it worked nicely.
Although the timestamps are in incorrect format: 0:02:16.612 --> 0:02:19.376 instead of 00:02:16,612 --> 00:02:19,376
Some media players will simply refuse to use such subtitles.

Thanks @chenxwh for the new demo. I just gave it a go and it worked nicely. Although the timestamps are in incorrect format: 0:02:16.612 --> 0:02:19.376 instead of 00:02:16,612 --> 00:02:19,376 Some media players will simply refuse to use such subtitles.

It's been fixed in https://github.com/openai/whisper/pull/197 :muscle: :muscle: :muscle:


Fix warning about main queue setup override in RN 0.59

In React Native 0.59 you get a warning when starting the app, like in the screenshot here:

This pull request removes that warning.

How about android?

Is this also happening on Android? I don't have a working Android install yet.

In RN 0.59.0+, I can’t build the app for android

My app is working with react native 0.58.6

Okay, I can't help you with that since I don't have experience with getting this to work on Android. But that has nothing to do with this pull request, so can you make a separate issue for that with more details?


Show Timer in Summary Page to inform students how much time they have left in a review

Is your feature request related to a problem?

Student cannot see how long a review will take (how long they can submit complaints)
Describe the solution you'd like

A timer would be nice to inform the students how much time is left in the review, so that they know how long they can submit complaints. Should be always visible when scrolling through the exam, maybe solve it similar to the exam with a sticky bar at the top of the summary

I think it would be enough to make sure the review start and end date is displayed on the summary page including a tag "Review is open" in case the now is between review start and review end

@SimonEntholzer can you please implement this?


Cargo check fails with internal error

The error looks like this:
λ cargo check --all --verbose
error: dep-info not in an understood format: /home/matklad/projects/fall/target/debug/.fingerprint/fall_gen-1d7df0cac95e3081/dep-bin-gen-1d7df0cac95e3081

Removing .target directory fixes the error. I don't think I understand what caused the error originally.

Do you have the original source code I could poke around with? I wonder if something got corrupted by accident...

No, I originally expected that this was due to upgrade from 1.17.0 to 1.18.0, so I deleted target and tried compiling with 17 and then switching to 18, but everything worked fine then, and I was unable to reproduce the error at all :(

I just had the good luck to run into this.
❯ cargo test --verbose
error: dep-info not in an understood format: /Users/marcin/Dropbox/Work/maidsafe/safe_client_libs/target/debug/.fingerprint/safe_authenticator-151ddd9151afa849/dep-lib-safe_authenticator

The contents of the dep-lib-safe_authenticator file:
src/lib.rs


Paging improvements

There is Previous/Next button, but not First / Last and no indication which page one is at .

I've added the simple one (just current page and the whole number of pages). If we need something more advanced (e.g. the ability to select particular page), we can add it as well.


Rename backend "native" to "win32", update the license file

Current coverage is 94.57% (diff: 100%)

Merging #228 into UIA will not change coverage

@@                UIA       #228   diff @@
==========================================
  Files            47         47
  Lines         18933      18933
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits          17906      17906
  Misses         1027       1027
  Partials          0          0

Powered by Codecov. Last update 8fa519b...be78101


Enter Full-screen using mouse, too

I use Vimium (this is a browser plugin) and it maps f to a particular task. Thus, there's no way for me to go full-screen without disabling this plugin. I suggest making the [ Fullscreen:  Press F ] text a clickable button.

Same issue, Shortcuts must be usable with a mouse too. I use vimium too.

Thanks for the feedback. I'll need to give this some thought to decide how best to deliver this kind of support but I do understand the issue. I'll update this thread when I know more.

I support this issue.
Your slides are beautiful on a phone, but there is no way to make them full screen.
A fullscreen button would not only be great for Vimium, but for smartphones as well.

I've been thinking about this and would like to request some additional feedback from everyone.
Vimium users, imagine I provided a link or menu to allow you enable Fullscreen mode. How would you then exit from a full screen mode if you are navigating solely by mouse? Keep in mind that in Fullscreen mode there can be no links or menus to help you exit Fullscreen mode. So basically, how would you expect to mimic the hitting of the Escape key using only your mouse? I haven't used Vimium so I may well be missing something simple but I'd like to know if we go down this path that it is not a cul-de-sac.
Same question for smartphone users. What is the equivalent of hitting the Escape key when viewing on a smartphone? Again keep in mind that in Fullscreen mode, by definition there can be no links or menus to help you exit Fullscreen mode.  So I'm trying to understand how you might exit from Fullscreen mode if I provided a way to enter that mode on mobile.
In a traditional desktop browser, exiting Fullscreen mode is always availble using the Escape key.

How about html5 full-screen feature? Its works with links and on mobile phone too

With Vimium one exits fullscreen with Esc. Phones are the whole other story, this issue is not about them, it's about desktop keymap being the only way to do things.
You might also consider another clickable element in fullscreen mode to appear when the mouse activity is registered.

Mobile phones will be in this case because links are clickable on phones too. Also, mobile phones never stucks in fullscreen mode. Back button always works as esc key.  In this case, we need only fullscreen link on shortcut label. It's will be ok for all of us. There are too many websites uses fullscreen feature on mobile phones and web browsers. And they also have a link for fullscreen.
Besides, I think it's possible to handle enter-exit fullscreen when double tapped on screen with mouse or touch.

Keyboard shortcuts: fullscreen, overview, and blackout are now all exposed as links in the main presentation window. Open any presentation and the links should appear in the bottom-left corner of the window.
While I have been able to test this in my own browser I have not been able to test with a mouse or using Vimium. So I would appreciate feedback from everybody once you have had a chance to test out this new functionality. Thanks.

Fullscreen - Overview - Blackout trio now works, however it'd nice if Help in the right bottom corner is made clickable too.
Otherwise, I consider this to be worked out and you can close the issue anytime.


Not working in $this->resource()

Hello And Thanks For Your Cool Ext...
When Im Trying To Go To Resource Controller The Extensions Does'nt Work .
I Tried it out of Route Group , Without Middleware or Any Extra Methods But Still Nothing Happend .
By the Way Im Using
Manjaro Linux 17.1.7
And
Vscode 1.25.1
Thanks .

Thanks for reporting this. Unfortunately I don't have time to look into this issue. Any help would be appreciated.

hmm is this still an issue or it is already fixed? should this be closed?


TensorFlowSharp 1.12 for Unity.

Hi,
I am trying to run a graph model created over tensorflow 1.12 for image classification. But I guess I am not able to do because the ml-agent tensorflowsharp unity package  I have supports 1.7. Is there any Tensorflowsharp package with  the latest tensorflow support. Please can you provide the link for the same.
Thanks
Sreeraj

me too :)

Can anyone update information on the availability of Tensorflowsharp 1.12.0

TF 1.12 works for me.
Just replace libtensorflow.dll with that from tf 1.12

@Keyang How did you integrate TensorFlowSharp with Unity. I get an error saying that TensorFlow namespace could not be found. Do I have to import the .dll file into assets?


Dummy PR for feedback on solution proposal

What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
What is the link to the Apache JIRA
(Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HDDS-XXXX. Fix a typo in YYY.)
Please replace this section with the link to the Apache JIRA)
How was this patch tested?
(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)

Failed checks are not related to this change.


Call allTenants() on a relationship

I would like to setup a relationship that returns allTenants() for a relationship. Is there a way to do that?
public function holidays() {
    // Correctly returns tenant scoped Holidays
    return $this->hasMany('Holidays');
}

public function allHolidays() {
    // Want all holidays not scoped
    return $this->hasMany('Holidays')->allTenants();
    // Fails as allTenants() needs to be called statically
}

Also tried
public function allHolidays() {
    // Want all holidays not scoped
    Holidays::allTenants();
    return $this->hasMany('Holidays');
    // No error but holidays are still scoped
}

I don't want to Tenant::disable() as I do still want everything else scoped.

You can do:
public function allHolidays()
{
    return $this->hasMany('Holidays')->withoutGlobalScope('tenant_id');
}


Usercard info displayed in mentions, depending on the channel you were mentioned in

What should be added?
Usercard information, such as Subage and Followage displayed in the mentions tab depending on which channel they mentioned you in.
A clear and concise description of the requested feature.
An addition that would display the users information in the channel that they mentioned you in, via the mentions tab, like this
 instead of just showing basic information like followers and account creation date.
Why should it be added?
I think it would be useful so that you don't have to go to the specific channel and do a /usercard command to fetch specific information, it isn't something that is too important, but I just think it would be a cool addition.

While doing some testing I noticed that whenever a usercard is opened from /mentions a bad API call is made, which appears to be caused by trying to fetch sub/follow information with "/mentions" as the channel.
This is maybe something that could be fixed by adding the suggested functionality, or just fixed on its own.


Use msbuild for smoke tests in test suite

The dotnet test may not work always.
Run some (basic usage) smoke test with msbuild directly (like test suite msbuild run )

done with #68


Increased memory usage after 2.0.1 bump on Android Gradle builds

Last friday our CI suddenly started failing with Java heap space and it took a couple of days to figure out what was the cause.
After a lot of investigation it turns out that, because we were using the action as datadog/test-visibility-github-action@v2 our CI instances started pulling in 2.0.1 when it was released and apparently that adds so much memory overhead to the gradle daemon process that it suddenly didn't have enough RAM to execute the build.
Maybe this is expected because the javaagent is now added to more processes but I would not expect a monitoring tool to add that much overhead that a process which usually runs at ~9GB of RAM would start throwing OOM errors.
It's a bit of a mystery overall and hard to reproduce, but reverting back to 2.0.0 completely fixed the issue for us so it may be worth an further investigation.
Please let me know if I can help you in any way with the investigation

Would it be possible for you to create a support issue with Datadog and share the logs there?
If not, it'd be helpful to see the contents of GRADLE_OPTS and JAVA_TOOL_OPTIONS environment variables before the Datadog config action and before the action that runs your tests. Also, if possible, the contents of the gradle.properties file of your project, in particular org.gradle.jvmargs, if specified.

Hi @remcomokveld, thank you for sharing the logs. Does your project happen to contain a gradle.properties file? If yes, does the file contain a org.gradle.jvmargs property?

Hi @remcomokveld, my hypothesis is that you have a max heap size for the Gradle Daemon process configured with the org.gradle.jvmargs setting. There was a bug in the tracer instrumentation logic that caused org.gradle.jvmargs to be overwritten, which in your case would mean resetting max heap size back to its default value, which could be the cause of the OOM errors you were seeing.
A new version of the Test Visibility action has been released today (v2.1.1), which should fix the org.gradle.jvmargs problem. Would you be willing to try it out and let me know if that fixes your problem? Thanks!

Yeah we are setting a max heap size of 6gb in the project gradle properties and override that to a higher value on CI machines. If those value were overridden to not setting a max and thus using Gradle's default of 512MB I'm surprised our builds got as far as they did. We did attempt to read the org.gradle.jvmargs from inside Gradle though and it was reporting the values that we were setting. Will try out the new version, thanks!


add TTL info

Description
Add info about the cache and TTL.
fixes https://github.com/terraform-ibm-modules/terraform-ibm-cbr/issues/291
Release required?

[x] No release
[ ] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

/run pipeline

/run pipeline

:tada: This PR is included in version 1.18.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[docker] Added clang-format-3.8 to docker

The version of clang-format used in CI is 3.8 which is much older than
most of our machines that run newer linux distros. With this update, one
can build our docker image with clang-format-3.8 and stay consistent
with the CI. IMO this is better than installing multiple packages in our
native machines.
Docker instructions are provided here.
With this change, you can run git clang-format inside the docker to stay in sync with CI.
Signed-off-by: Srikrishna Iyer<EMAIL_ADDRESS>

Oh, Nice.
I don't have a way to check docker, but 3.8.0 is the correct version of clang-format to be using.


sap*preconfigure: linting fixes

sap*preconfigure: linting fixes
Address ansible-lint errors from PR #537 for Issue #499

Unable to append original contributor @itdose2023 to the reviewers list. As linting fixes are minor, merging without approval. Please defer to PR listed above.


Upgrade to opencsv 4.0

@jimmoores this PR was failing originally, but I've fixed it now

Sorry, for some reason I missed this PR.


[Breaking change]: New TimeSpan.From overloads which take integers

Description
https://github.com/dotnet/runtime/pull/98633
Version
.NET 9 RC 1
Previous behavior
Before .NET 9 there was a version with one float parameter
New behavior
Now the following F# code throws an overload error: TimeSpan.FromMinutes(20)

error FS0041: A unique overload for method 'FromMinutes' could not be determined based on type information prior to this program point. A type annotation may be needed.Known type of argument: intCandidates: - TimeSpan.FromMinutes(minutes: int64) : TimeSpan - TimeSpan.FromMinutes(minutes: int64, ?seconds: int64, ?milliseconds: int64, ?microseconds: int64) : TimeSpan - TimeSpan.FromMinutes(value: float) : TimeSpan

Type of breaking change

[ ] Binary incompatible: Existing binaries might encounter a breaking change in behavior, such as failure to load or execute, and if so, require recompilation.
[X] Source incompatible: When recompiled using the new SDK or component or to target the new runtime, existing source code might require source changes to compile successfully.
[ ] Behavioral change: Existing binaries might behave differently at run time.

Reason for change
https://github.com/dotnet/runtime/issues/93890
Recommended action
Specify the compiler what type of argument is being used so that the appropriate overload is selected
Feature area
Core .NET libraries
Affected APIs
No response

Hello, @bartonjs
When a new API is designed, does it take into account that .NET <> C#?
https://github.com/dotnet/runtime/issues/93890#issuecomment-1777761585


gh-2559 added hasTrait, its handler and corresponding tests

Related Issue

Resolve #2559

Codecov Report

Merging #2561 (8e95605) into develop (4ccb03f) will increase coverage by 6.76%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #2561      +/-   ##
=============================================
+ Coverage      66.69%   73.46%   +6.76%
+ Complexity      2522      228    -2294
=============================================
  Files            995       19     -976
  Lines          32457      731   -31726
  Branches        3936       57    -3879
=============================================
- Hits           21647      537   -21110
+ Misses          9114      145    -8969
+ Partials        1696       49    -1647

Impacted Files
Coverage Δ

.../src/main/java/uk/gov/gchq/gaffer/store/Store.java

.../uk/gov/gchq/gaffer/rest/GafferWebApplication.java

...redicate/user/FederatedGraphReadUserPredicate.java

...chq/gaffer/parquetstore/query/ParquetEdgeSeed.java

...r/javardd/GetJavaRDDOfElementsInRangesHandler.java

...on/handler/utilities/RetrieveElementsFromFile.java

...v/gchq/gaffer/operation/function/FromEntityId.java

...gaffer/store/operation/add/AddSchemaToLibrary.java

.../serialisation/implementation/MultiSerialiser.java

...operation/handler/named/NamedOperationHandler.java

... and 966 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 296c453...8e95605. Read the comment docs.