HBASE-28563 Closing ZooKeeper in ZKMainServer

HBASE-28563

Add close to HACK_UNTIL_ZOOKEEPER_1897_ZooKeeperMain
Close the ZooKeeper when a timeout occurs

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 54s
master passed

+1 :green_heart:
compile
0m 35s
master passed

+1 :green_heart:
shadedjars
5m 17s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 32s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 44s
the patch passed

+1 :green_heart:
compile
0m 35s
the patch passed

+1 :green_heart:
javac
0m 35s
the patch passed

+1 :green_heart:
shadedjars
5m 16s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 30s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 36s
hbase-client in the patch passed.

+1 :green_heart:
unit
0m 42s
hbase-zookeeper in the patch passed.

22m 54s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5869/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5869

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux c128173d4163 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 3d66866f41

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5869/1/testReport/

Max. process+thread count
308 (vs. ulimit of 30000)

modules
C: hbase-client hbase-zookeeper U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5869/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 27s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 38s
master passed

+1 :green_heart:
compile
0m 28s
master passed

+1 :green_heart:
shadedjars
5m 41s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 24s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 25s
the patch passed

+1 :green_heart:
compile
0m 28s
the patch passed

+1 :green_heart:
javac
0m 28s
the patch passed

+1 :green_heart:
shadedjars
5m 59s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 32s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 43s
hbase-client in the patch passed.

+1 :green_heart:
unit
0m 45s
hbase-zookeeper in the patch passed.

23m 11s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5869/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5869

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux ed1f1e66ad70 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 3d66866f41

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5869/1/testReport/

Max. process+thread count
286 (vs. ulimit of 30000)

modules
C: hbase-client hbase-zookeeper U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5869/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 26s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 16s
master passed

+1 :green_heart:
compile
0m 34s
master passed

+1 :green_heart:
shadedjars
5m 46s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 28s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 59s
the patch passed

+1 :green_heart:
compile
0m 34s
the patch passed

+1 :green_heart:
javac
0m 34s
the patch passed

+1 :green_heart:
shadedjars
5m 44s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 26s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 34s
hbase-client in the patch passed.

+1 :green_heart:
unit
0m 39s
hbase-zookeeper in the patch passed.

24m  7s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5869/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5869

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 4b3b157d5dab 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 3d66866f41

Default Java
Eclipse Adoptium-17.0.10+7

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5869/1/testReport/

Max. process+thread count
327 (vs. ulimit of 30000)

modules
C: hbase-client hbase-zookeeper U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5869/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 55s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 57s
master passed

+1 :green_heart:
compile
1m  4s
master passed

+1 :green_heart:
checkstyle
0m 27s
master passed

+1 :green_heart:
spotless
0m 44s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m  9s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 45s
the patch passed

+1 :green_heart:
compile
1m  2s
the patch passed

+1 :green_heart:
javac
1m  2s
the patch passed

+1 :green_heart:
checkstyle
0m 25s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
4m 57s
Patch does not cause any errors with Hadoop 3.3.6.

-1 :x:
spotless
0m 20s
patch has 31 errors when running spotless:check, run spotless:apply to fix.

+1 :green_heart:
spotbugs
1m 22s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 20s
The patch does not generate ASF License warnings.

25m 11s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5869/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5869

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux a22ffb18a0df 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 3d66866f41

Default Java
Eclipse Adoptium-11.0.17+8

spotless
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5869/1/artifact/yetus-general-check/output/patch-spotless.txt

Max. process+thread count
77 (vs. ulimit of 30000)

modules
C: hbase-client hbase-zookeeper U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5869/1/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 28s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 28s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 41s
master passed

+1 :green_heart:
compile
0m 28s
master passed

+1 :green_heart:
shadedjars
5m 41s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 24s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 26s
the patch passed

+1 :green_heart:
compile
0m 30s
the patch passed

+1 :green_heart:
javac
0m 30s
the patch passed

+1 :green_heart:
shadedjars
5m 38s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 23s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 25s
hbase-client in the patch passed.

+1 :green_heart:
unit
0m 35s
hbase-zookeeper in the patch passed.

22m 20s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5869/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5869

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 249e0d5ef70c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 3d66866f41

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5869/2/testReport/

Max. process+thread count
305 (vs. ulimit of 30000)

modules
C: hbase-client hbase-zookeeper U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5869/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 12s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 48s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 49s
master passed

+1 :green_heart:
compile
0m 36s
master passed

+1 :green_heart:
shadedjars
5m 19s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 30s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 48s
the patch passed

+1 :green_heart:
compile
0m 35s
the patch passed

+1 :green_heart:
javac
0m 35s
the patch passed

+1 :green_heart:
shadedjars
5m 16s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 30s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 35s
hbase-client in the patch passed.

+1 :green_heart:
unit
0m 42s
hbase-zookeeper in the patch passed.

23m  0s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5869/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5869

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 57e71f5a6d0a 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 3d66866f41

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5869/2/testReport/

Max. process+thread count
320 (vs. ulimit of 30000)

modules
C: hbase-client hbase-zookeeper U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5869/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 14s
master passed

+1 :green_heart:
compile
0m 33s
master passed

+1 :green_heart:
shadedjars
5m 48s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 28s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 57s
the patch passed

+1 :green_heart:
compile
0m 33s
the patch passed

+1 :green_heart:
javac
0m 33s
the patch passed

+1 :green_heart:
shadedjars
5m 42s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 27s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 34s
hbase-client in the patch passed.

+1 :green_heart:
unit
0m 38s
hbase-zookeeper in the patch passed.

24m  4s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5869/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5869

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 2382726bc42c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 3d66866f41

Default Java
Eclipse Adoptium-17.0.10+7

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5869/2/testReport/

Max. process+thread count
322 (vs. ulimit of 30000)

modules
C: hbase-client hbase-zookeeper U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5869/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 37s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 57s
master passed

+1 :green_heart:
compile
1m  1s
master passed

+1 :green_heart:
checkstyle
0m 27s
master passed

+1 :green_heart:
spotless
0m 44s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m  8s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 45s
the patch passed

+1 :green_heart:
compile
1m  1s
the patch passed

+1 :green_heart:
javac
1m  1s
the patch passed

+1 :green_heart:
checkstyle
0m 25s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
4m 57s
Patch does not cause any errors with Hadoop 3.3.6.

-1 :x:
spotless
0m 19s
patch has 31 errors when running spotless:check, run spotless:apply to fix.

+1 :green_heart:
spotbugs
1m 21s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 20s
The patch does not generate ASF License warnings.

24m 47s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5869/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5869

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 32bae234205c 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 3d66866f41

Default Java
Eclipse Adoptium-11.0.17+8

spotless
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5869/2/artifact/yetus-general-check/output/patch-spotless.txt

Max. process+thread count
78 (vs. ulimit of 30000)

modules
C: hbase-client hbase-zookeeper U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5869/2/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 26s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 36s
master passed

+1 :green_heart:
compile
0m 28s
master passed

+1 :green_heart:
shadedjars
5m 39s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 24s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 25s
the patch passed

+1 :green_heart:
compile
0m 31s
the patch passed

+1 :green_heart:
javac
0m 31s
the patch passed

+1 :green_heart:
shadedjars
5m 39s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 23s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 24s
hbase-client in the patch passed.

+1 :green_heart:
unit
0m 35s
hbase-zookeeper in the patch passed.

22m  8s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5869/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5869

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 3ebe0294df92 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 917f2f1ec0

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5869/3/testReport/

Max. process+thread count
300 (vs. ulimit of 30000)

modules
C: hbase-client hbase-zookeeper U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5869/3/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 12s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 14s
master passed

+1 :green_heart:
compile
0m 40s
master passed

+1 :green_heart:
shadedjars
5m 36s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 31s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 48s
the patch passed

+1 :green_heart:
compile
0m 35s
the patch passed

+1 :green_heart:
javac
0m 35s
the patch passed

+1 :green_heart:
shadedjars
5m 17s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 29s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 37s
hbase-client in the patch passed.

+1 :green_heart:
unit
0m 41s
hbase-zookeeper in the patch passed.

23m 29s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5869/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5869

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 06c42f1a8042 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 917f2f1ec0

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5869/3/testReport/

Max. process+thread count
303 (vs. ulimit of 30000)

modules
C: hbase-client hbase-zookeeper U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5869/3/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 24s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 59s
master passed

+1 :green_heart:
compile
0m 33s
master passed

+1 :green_heart:
shadedjars
5m 43s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 26s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m  0s
the patch passed

+1 :green_heart:
compile
0m 34s
the patch passed

+1 :green_heart:
javac
0m 34s
the patch passed

+1 :green_heart:
shadedjars
5m 46s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 26s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 35s
hbase-client in the patch passed.

+1 :green_heart:
unit
0m 38s
hbase-zookeeper in the patch passed.

23m 47s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5869/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5869

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 6051f8cbb066 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 917f2f1ec0

Default Java
Eclipse Adoptium-17.0.10+7

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5869/3/testReport/

Max. process+thread count
305 (vs. ulimit of 30000)

modules
C: hbase-client hbase-zookeeper U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5869/3/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 52s
master passed

+1 :green_heart:
compile
1m  0s
master passed

+1 :green_heart:
checkstyle
0m 26s
master passed

+1 :green_heart:
spotless
0m 42s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m  7s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 44s
the patch passed

+1 :green_heart:
compile
1m  1s
the patch passed

+1 :green_heart:
javac
1m  1s
the patch passed

+1 :green_heart:
checkstyle
0m 26s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
4m 50s
Patch does not cause any errors with Hadoop 3.3.6.

-1 :x:
spotless
0m 20s
patch has 38 errors when running spotless:check, run spotless:apply to fix.

+1 :green_heart:
spotbugs
1m 24s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 17s
The patch does not generate ASF License warnings.

24m 34s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5869/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5869

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 79ee14a980e0 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 917f2f1ec0

Default Java
Eclipse Adoptium-11.0.17+8

spotless
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5869/3/artifact/yetus-general-check/output/patch-spotless.txt

Max. process+thread count
79 (vs. ulimit of 30000)

modules
C: hbase-client hbase-zookeeper U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5869/3/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 25s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
2m 20s
master passed

+1 :green_heart:
compile
0m 11s
master passed

+1 :green_heart:
shadedjars
5m 34s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 10s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 22s
the patch passed

+1 :green_heart:
compile
0m 11s
the patch passed

+1 :green_heart:
javac
0m 11s
the patch passed

+1 :green_heart:
shadedjars
5m 33s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 10s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 35s
hbase-zookeeper in the patch passed.

18m 19s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5869/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5869

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 003118d2173d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / bcd6205f9d

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5869/4/testReport/

Max. process+thread count
270 (vs. ulimit of 30000)

modules
C: hbase-zookeeper U: hbase-zookeeper

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5869/4/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 12s
Docker mode activated.


Spelling error on Kivy Home Page

See: https://groups.google.com/g/kivy-users/c/arqQgnW89JQ/m/4ES4bB9-CAAJ

Change to "maintained"

This should transferred to kivy/kivy-website, but I dont have the power. @ElliotGarbus, do you want to close and reraise there?

posted to kivy website repository


Document timeout and interval for Retryables

Currently there's no explicit documentation for setting the timeout and interval on Retryables in the manual, but only in the JavaDoc.
The most common use cases and default setting should be documented in the manual.

See #234


Example to send image to AI over API to get image description

Can be enhanced with several images
!! The API key needs to be set locally in an .env file
Works on my machine

No Unittests, we write actual good code here lmao


What is the difference between flutter plugin and flutter module?

I am new to flutter plugin development, I have read  Developing packages & plugins and Writing a good Flutter plugin, but I am confused as a beginner, I have developed Flutter Application based on webview_flutter and a JavaScript library to work offline. I want to extend it as a module or a plugin.
Webview renders some stuff.
JavaScript library is being attached from assets.
I am not calling any Platform API directly from my code but my code depends on another plugin.
How do I proceed this? As a plugin or as a module?

Answered on https://stackoverflow.com/questions/54731733/what-is-the-difference-between-flutter-plugin-and-flutter-module/54733856#54733856


Question: Is this some form of reward engineering?

This would break in environments that return the state as more/less than 4 values for unpacking.

If not essential can we just remove this?
If it's essential, would someone explain why and/or reference the paper for this?
This seems specific to CartPole. I wasn't sure if the implementation's goal was to only solve CartPole.

r1 = (env.x_threshold - abs(x)) / env.x_threshold - 0.8
r2 = (env.theta_threshold_radians - abs(theta)) / env.theta_threshold_radians - 0.5
reward = r1 + r2

@WorksWellWithOthers This is indeed a form of reward engineering and is specific to CartPole to turn the returned state into a numeric reward.  Other environments would not need this specifically, and potentially would return a distinct reward already.


Update FileUploadController.java

Fixed  Stream Close #22

Resolved via https://github.com/spring-guides/gs-uploading-files/commit/bc402eea88422278b51e3a4735be5ac371eab286


Initial attempt by Gabriel Rojas Bowe

Used a slightly different approach for outputting the results and added functionality to stop main.py from looping infinitely

Still needs some work, but definite improvement here.


feat: implement catalog/schema/table commands on the service

FlightSQL has a set of commands to interrogate the server for information about the available catalogs, db schemas, tables, and table types. This change implements those four commands in terms of a datafusion context.

FWIW I also added commands to the flight_sql_client CLI in https://github.com/apache/arrow-rs/pull/6332 that makes it easy to invoke these new methods.

Clippy seems to have a small nit. Can you still fix that?


python312Packages.yalexs-ble: 2.4.2 -> 2.4.3

Diff: https://github.com/bdraco/yalexs-ble/compare/refs/tags/v2.4.2...v2.4.3
Changelog: https://github.com/bdraco/yalexs-ble/blob/v2.4.3/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 322696 run on x86_64-linux 1

6 packages built:

home-assistant-component-tests.august
home-assistant-component-tests.yalexs_ble
python311Packages.yalexs-ble
python311Packages.yalexs-ble.dist
python312Packages.yalexs-ble
python312Packages.yalexs-ble.dist


Update to use template files

Pull Request (PR) description

Update appveyor.yml to use the default template.
Added default template files .codecov.yml, .gitattributes, and .gitignore, and
.vscode folder.

This Pull Request (PR) fixes the following issues

Task list

[x] Added an entry under the Unreleased section of the change log in the README.md.
Entry should say what was changed, and how that affects users (if applicable).
[ ] Resource documentation added/updated in README.md.
[ ] Resource parameter descriptions added/updated in README.md, schema.mof
and comment-based help.
[ ] Comment-based help added/updated.
[ ] Localization strings added/updated in all localization files as appropriate.
[ ] Examples appropriately added/updated.
[ ] Unit tests added/updated. See DSC Resource Testing Guidelines.
[ ] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
[ ] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is

Codecov Report

:exclamation: No coverage uploaded for pull request base (dev@3679392). Click here to learn what that means.
The diff coverage is n/a.

@@         Coverage Diff         @@
##             dev   #10   +/-   ##
===================================
  Coverage       ?    1%
===================================
  Files          ?     4
  Lines          ?   298
  Branches       ?     0
===================================
  Hits           ?     3
  Misses         ?   295
  Partials       ?     0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3679392...5846cf5. Read the comment docs.


Fixes for plex connection

I labelled it as breaking change as users will definitely need to start over to ensure a smooth transition.
However, I don't see this as an issue, as I guess for most people it seems to not work at all at the moment.
The myplexaccount.ping() function seems to be all that is required for the refresh of the token
https://github.com/pkkid/python-plexapi/pull/1271

@marcelveldt Can you double check the new update, I added the GDM discovery.


sessions on k8s : url http://lighter.spark:8080 should be configurable

Hi,
Thanks for sharing.
There is a configuration issue using session from REST in k8s.
One url is hard-coded and shoud not.
See https://github.com/exacaster/lighter/blob/99f5235e6103837262d20da2ed3555ab4b6ab70a/server/src/main/resources/application.yml
url: http://lighter.spark:8080
This should be user defined and the value should be the name of the service that was created by the user at installation.
For example:
url: http://spark-lighter-svc.ns-spark.svc.cluster.local:80

Hey, you can override it with ‘LIGHTER_URL’ environment variable, it is dicumende here: https://github.com/exacaster/lighter/blob/master/docs/configuration.md#global-properties . The hardcoded value, you have mentuoned is the default value for this priperty.

Thanks for the quick answer, my mistake !


Performance drop emulating ARM

Let's have a look at the following comparison, running qemu-2.5  vs usercorn/unicorn on ARM:
$ time qemu-arm busybox-armv5l sha512sum ~/redox-harddrive.raw
real    0m40.549s
user    0m40.280s
sys     0m0.160

vs
$ time ./usercorn busybox-armv5l sha512sum ~/redox-harddrive.raw
real    1m33.913s
user    1m33.780s
sys     0m0.860s

Now, the busybox-x86_64 equivalent looks like this:
real    0m38.001s     0m38.745s
user    0m37.820s     0m38.920s
sys     0m0.110s      0m0.570s

in favour of qemu, but virtually equal.
The first instance looks like a bug in usercorn (unless ARM emulation used to be that bad in qemu-2.2), while the second compels me to ask:
are the unicorn's homepage claims about performance benefits from jitting actually real?

Interesting tests. We're on an old version of qemu which could be related. Can you test against qemu 2.2?
Either way, Unicorn is literally using the qemu JIT, so this is just a regression of some kind.

On Mar 29, 2016, at 2:21 PM, petevine<EMAIL_ADDRESS>wrote:
Let's have a look at the following comparison, running usercorn/unicorn on ARM:
$ time qemu-arm busybox-armv5l sha512sum ~/redox-harddrive.raw
real    0m40.549s
user    0m40.280s
sys     0m0.160
vs
$ time ./usercorn busybox-armv5l sha512sum ~/redox-harddrive.raw
real    1m33.913s
user    1m33.780s
sys     0m0.860s
Now, the x86_64 equivalent looks like this:
real    0m38.001s     0m38.745s
user    0m37.820s    0m38.920s
sys     0m0.110s       0m0.570s
in favour of qemu, but virtually equal.
The first instance looks like a bug in usercorn while the second compels me to ask:
** are the unicorn's homepage claims about performance benefits from jitting actually real? **
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub

Ah, ok; I must have misremembered what the page used to say. I'll build qemu-arm 2.2.1 and see if there's any difference.

There it is:
$ time ./qemu-arm-2.2.1 busybox-armv5l sha512sum ~/redox-harddrive.raw
real    0m40.742s
user    0m39.170s
sys     0m0.280s

Well, the x86 and ARM syscall handlers are about the same, so it's still probably a Unicorn problem.

I just checked and arm traps don't seem to be called during the loop, so I doubt it's Usercorn's fault.
sha256sum performs about the same between armv5l and x86_64, but sha512sum is much slower on armv5l under Usercorn for me. My guess is our emulated ARM CPU has different feature flags set than qemu which give it a performance regression.

A lucky find then! Had I chosen sha256 we'd never have known! :)
I initially wanted to use bzip2 but that didn't work for a different reason (that I thought could be a case of WIP)
BTW, if you're looking for an ARM testing platform, look at Mini M8S TV Box from gearbest - if it could be made to run Linux that would be a hit.

So, do the latest additions make it possible to create a useful upstream report yet?

need to figure out the slow part before that's useful. record/replay would make this possible but save doesn't make it easy (because it needs to make syscalls)

Right, I'm going to close this issue then. Let me know if you need some native testing.


TypeError: Cannot set property 'raw' of null in get-acme-urls.js:33

Node.js v6.3.1, Windows 8.1<EMAIL_ADDRESS>fresh install:
node_modules\.bin\letsencrypt.cmd certonly --agree-tos --email<EMAIL_ADDRESS>--standalone --domains example.org --config-dir .

D:\myFolder\node_modules\le-acme-core\lib\get-acme-urls.js:33
          err.raw = data;
                  ^

TypeError: Cannot set property 'raw' of null
    at Request._callback (D:\myFolder\node_modules\le-acme-core\lib\get-acme-urls.js:33:19)
    at Request.self.callback (D:\myFolder\node_modules\request\request.js:187:22)
    at emitTwo (events.js:106:13)
    at Request.emit (events.js:191:7)
    at Request.<anonymous> (D:\myFolder\node_modules\request\request.js:1044:10)
    at emitOne (events.js:96:13)
    at Request.emit (events.js:188:7)
    at IncomingMessage.<anonymous> (D:\myFolder\node_modules\request\request.js:965:12)
    at emitNone (events.js:91:20)
    at IncomingMessage.emit (events.js:185:7)
    at endReadableNT (_stream_readable.js:975:12)
    at _combinedTickCallback (internal/process/next_tick.js:74:11)
    at process._tickCallback (internal/process/next_tick.js:98:9)

Sorry! :cry:

The error you brought up was actually in le-acme-core, but I'm guessing the reason you experienced it was that you didn't pass the server argument or passed an mistyped url (or perhaps copied from a mistyped example).
Either way, rm -rf node_modules/*le*; npm install and try again. At the very least you'll get a more accurate error message this time which should show the offending server url.

From there I can better help you fix whatever the "real" problem is.

Man, you have a big amount of different repositories! ;-)
Now the error message is much more descriptive:
node_modules\.bin\letsencrypt.cmd certonly --agree-tos --email<EMAIL_ADDRESS>--standalone --domains example.org --config-dir .

[Error]: letsencrypt-cli
SyntaxError: Unexpected token p in JSON at position 4
    at Object.parse (native)
    at Request._callback (D:\myfolder\node_modules\le-acme-core\lib\get-acme-urls.js:31:23)
    at Request.self.callback (D:\myfolder\node_modules\request\request.js:187:22)
    at emitTwo (events.js:106:13)
    at Request.emit (events.js:191:7)
    at Request.<anonymous> (D:\myfolder\node_modules\request\request.js:1044:10)
    at emitOne (events.js:96:13)
    at Request.emit (events.js:188:7)
    at IncomingMessage.<anonymous> (D:\myfolder\node_modules\request\request.js:965:12)
    at emitNone (events.js:91:20)
    at IncomingMessage.emit (events.js:185:7)
    at endReadableNT (_stream_readable.js:975:12)
    at _combinedTickCallback (internal/process/next_tick.js:74:11)
    at process._tickCallback (internal/process/next_tick.js:98:9)

response data:
404 page not found

acmeDiscoveryUrl:https://acme-v01.api.letsencrypt.org/directory)

There must be a typo somewhere. if i add --server https://acme-v01.api.letsencrypt.org/directory then I'm getting the next error message :sunglasses:

Should be --server https://acme-v01.api.letsencrypt.org

Opps, I was wrong! You were right.

'https://acme-v01.api.letsencrypt.org/directory'
'https://acme-staging.api.letsencrypt.org/directory'

Hmmm... well that 404 page not found is pretty clear as to why it's breaking for you, but it's not down for me.
My best guess is that the server assigned to your area is down for maintenance. I get emails a few times a week from them saying "xyz will be down for maintenance from xx pm to yy pm on zz day"
Check to see if the url works for you just by clicking on it.

Uh-oh... https://acme-v01.api.letsencrypt.org/directory)
Notice the trailing )? Is that a typo that you made? Or is there a rouge ')' somehow being added in the code?

I just did a quick scan and I'm pretty sure you've got a typo on your end because I see where the argument is being passed in letsencrypt-cli to node-letsencrypt to le-acme-core and it seems to just go along without any intervention (as expected). I'll also be running some tests shortly with the new version of letsencrypt-express, so I'll know for sure when I do that.
Sorry for the hundred million messages.

Also, thanks for all of your bug reports and your patience. The past few days I've been pushing a lot of code and I'm glad you're running windows and had an old version of node and all these other things that happen to be finding bugs that I didn't find on my own :-)

:-)
Okay, so you README.MD says:
Want to use the live server?

remove the --server https://acme-staging.api.letsencrypt.org/directory
or change it to --server https://acme-v01.api.letsencrypt.org/directory

I did this: node_modules\.bin\letsencrypt.cmd certonly --agree-tos --email<EMAIL_ADDRESS>--standalone --domains example.org --config-dir . (private values changed, of course)
I get the ) when I don't add the -- server param at all. Somewhere default setting seems to be wrong. I also tried to locate the issue, but had no success.
If I add the server param, then it continues with another error. I post this soon.

Oops! I forgot to re-enable port forwarding. If I add --server then it works! I get my certs! yay! :smile:
However, the default server gives me the provided error!

Cool beans!
Is that port-forwarding on your home router?
Think you could help with https://github.com/Daplie/holepunch? There's some low-hanging fruit right now where the array of network interfaces isn't in the right format. Easy console.log / forEach / obj[key] type stuff.
https://github.com/Daplie/holepunch/issues/4
https://github.com/Daplie/holepunch/issues/2

Jep. Home-Router (FRITZ!Box).
What should I do?

Also: v2.1.2 now requires the --server argument (and the default was actually where the typo was, so I just removed it)

@JohannesHoppe Take a look at the issues, run the code, do some console.log, make a PR for the fix.


Added index.d.ts for tsx(typescript)

make each chart interfaces.

LineChart
ProgressChart
BarChart
StackedBarChart
PieChart
ContributionGraph

I have confirmed that each sample in README.md works in my local environment on tsx file.

now available in v3

thank you for reviewing and approving.
I am looking forward to v3.


Fails with 2 transform streams and lot of data

Below code will fail with error RangeError: Maximum call stack size exceeded.
Node version: 0.10.37
Failed code:
'use strict';

var TransformStream = require('stream').Transform,
	util = require('util'),
	duplexer = require('duplexer2');

var MyTransformStream = function() {
	TransformStream.call(this);
};
util.inherits(MyTransformStream, TransformStream);

MyTransformStream.prototype._transform = function(chunk, encoding, callback) {
	callback(null, chunk);
};

var firstStream = new MyTransformStream(),
	secondStream = new MyTransformStream();

firstStream.pipe(secondStream);

var duplexStream = duplexer({
	bubbleErrors: false
}, firstStream, secondStream);

for (var i = 0; i < 3000; i++) {
	duplexStream.write(i.toString());
}

same for me with nodejs 0.10.42:
(node) warning: Recursive process.nextTick detected. This will break in the next version of node. Please use setImmediate for recursive deferral.
(node) warning: Recursive process.nextTick detected. This will break in the next version of node. Please use setImmediate for recursive deferral.
....
RangeError: Maximum call stack size exceeded

it crashes whole process.
It works without error on higher versions of node (i've tried 0,12 and 5.5).

this error doesn't happen starting at node 0.12. so i suggest you upgrade your node versions, 0.10 is quite old

nodejs 0.10 still widely used across different environments (e.g. it's default in openshift service, ubuntu lts, centos, etc). readable-stream used in this lib supports nodejs 0.10 correctly and i think duplexer2 should do so.

@okv Deleted your meaningless cross-posted comment.

@shinnn sorry for that, but why you did not remove @juliangruber cross-posted comment?
@shinnn anyway, what about 0.10 support? Is it supported by deplexer2?

@okv However I, and probably other maintainers, don't have enough interest and time to add a workaround for Node v0.10, we don't decline awesome pull requests to fix the v0.10-specific problem.

why you did not remove @juliangruber cross-posted comment?

Ah, sorry I didn't notice that. Now deleted both.

@shinnn looks like that bug related to readable stream. Is readable stream supposed to work with 0.10? it's goal (support stream 2 and 3 for earlier versions of node including 0.10) of readable stream, isn't it?

Is readable stream supposed to work with 0.10?

https://github.com/nodejs/readable-stream/issues/new

'use strict';

var TransformStream = require('stream').Transform,
    util = require('util'),
    duplexer = require('duplexer2');

var MyTransformStream = function() {
  TransformStream.call(this);
};
util.inherits(MyTransformStream, TransformStream);

MyTransformStream.prototype._transform = function(chunk, encoding, callback) {
  callback(null, chunk);
};

var writable = new MyTransformStream(),
    readable = new MyTransformStream();

writable.pipe(readable);

var duplexStream = duplexer({
  bubbleErrors: false
}, writable, readable);

for (var i = 0; i < 3000; i++) {
  duplexStream.write(i.toString());
}

I made two small changes to your code - I renamed firstStream to writable, and secondStream to readable. Why are you piping your writable stream into your readable stream?

@deoxxa this is just example of how to get this error, not actual usage. Found out that this error happens because of readable-stream, added issue there: https://github.com/nodejs/readable-stream/issues/187

FYI: linked readable stream issue fixed in 2.0.6, but duplexer 2 (with readable stream 2.0.6) still fails with same error.


Support the .sigstore bundle extension

Is your feature request related to a problem? Please describe.
The scorecard GH action is detecting that my last 5 releases don't have signed artifacts, though they do have .sigstore bundles.
Describe the solution you'd like
The .sigstore extension should flag a signed artifact.
Describe alternatives you've considered
Can't think of any 😅
Additional context

https://github.com/sigstore/sigstore-python/issues/251

Good catch. Done in https://github.com/ossf/scorecard/pull/3773/files


Reverse scale on radar / polar area

Added reverse option into scale.radialLinear
With reverse axis will be label of radar center drawn
Fixed getting of minimum (null value was reseting - line 98)
Added examples of scale setting into samples (for testing of reverse axis suffice change false to true)

Looks good @honza889 thanks for contributing!

Thanks for fast merging. Just a question, is in plan support MSIE 8 in Chart.js 2.0?

@honza889 right now we support IE8. @tannerlinsley @derekperkins and I are thinking of removing that requirement since it's 6 years old and hasn't been updated in 4.5 years.


[Dev] Brings back storybooks for dev #trivial

I assume during debugging the latest react native update storybooks were removed and then not replaced afterwards, see discussion at https://github.com/artsy/emission/pull/570/files#r120094031
As I was touching it, I updated us to the latest stable release of storybooks too. 👍
Tested on Device?

[ ] @orta n/a
[ ] @mennenia

How to get set up with this PR?

To run on your computer:
git fetch origin pull/585/head:orta-585-checkout
git checkout orta-585-checkout
yarn install
cd example; pod install; cd ..
open -a Simulator
yarn start

Then run xcrun simctl launch booted net.artsy.Emission once a the simulator has finished booting
To run inside Eigen (prod or beta) or Emission (beta): Shake the phone to get the Admin menu.
If you see "Use Staging React Env"  - click that and restart, then follow the next step.
Click on "Choose an RN build"  - then pick the one that says: "X,Y,Z"
Note: this is a TODO for PRs, currently  you can only do it on master commits.

:+1: good spot!


close #28

add log level config, update config for only load config file once

Coverage increased (+1.5%) to 52.394% when pulling f8689cc16924e3d57f6e265e769a683d094eee47 on chhsiao90:loglevel into 3a9bc992944ee39a8e59c914817b37263d08e8fe on mike820324:master.

Thanks bro, I will check it out later.

I may need to postpone this merge request since there are some points that I need to discuss with you.
The following are my thoughts.
First, the current config file should be used only by the proxy process. As for the viewer process, it should be the viewer itself to handle the configurations. Since one day we may separate the viewer into another repos(reduce the dependencies of this project or using another programming language).
Second, in this implementation,  you separate log config by  module.
My concern is that when this project becomes bigger , isn't the configuration of this part will also becomes larger and finally too complicate to config. Sort of breaking the initial goal of this PR, isn't it ;)
What I think is that the log level part should only be config in one place, and all the proxy process will follow the log level.

First, the current config file should be used only by the proxy process. As for the viewer process, it should be the viewer itself to handle the configurations. Since one day we may separate the viewer into another repos(reduce the dependencies of this project or using another programming language).

But currently, viewer still in the same project, so it still need config.
So I think it doesn't matter that it used the same config now.

My concern is that when this project becomes bigger , isn't the configuration of this part will also becomes larger and finally too complicate to config. Sort of breaking the initial goal of this PR, isn't it ;)
What I think is that the log level part should only be config in one place, and all the proxy process will follow the log level.

We could just config the custom log as we need.
If we hadn't set up a custom logger, it will used root logger.
So I think the complexity is opt to us.

BTW, I follow the https://github.com/waffleio/waffle.io/wiki/Recommended-Workflow-Using-Pull-Requests-&-Automatic-Work-Tracking to set up waffle flow.
I think there is some point:

We create branch with the pattern: 21-xxxxxx or xxxxxx-#21 to connect the branch to issue 21 and it will also update issue status to In Progress automatically
I think ready means ready to be work on, and should be before In Progress
I moved Pull Request Label to Review Column(Including Collaborator and Contributor), that mean any pull request had title "close #num" will connect to specific issue and update the issue status to Review.

Please take a look and give me feedback if any, thank you.

Looks great, let's follow this pattern. And I will add this to the Issue #6 documentation too.

We could just config logger that need to config without config all logger.
If we hadn't set up a custom logger for some module, it will used root logger.
So I think the complexity is opt to us.

So what you mean is that we can just config the logger_root, and the other logger type will just follow the logger_root settings if we didn't config them?

So what you mean is that we can just config the logger_root, and the other logger type will just follow the logger_root settings if we didn't config them?

That's right!

OK, then this PR may ready to go.

One more things, just curious about the logger section and handler section.
The keys field of the above sections is for other subsections?
ex.
[logger]
keys=root,proxy,http,viewer
[logger_root]
...
[logger_proxy]
...
[logger_http]
...

Is it the native support for ConfigParser, looks pretty cool.

One more things, just curious about the logger section and handler section.
The keys field of the above sections is for other subsections?

I think it's logging.config implementation.
But as I know, logging.config use ConfigParser to load the config.
So maybe ConfigParser provide some convenient api to handle this situation.

Okay, I now understand that this config file will be feed to logging.config.fileConfig so when we call getlogger, we can get the proper logger type.
Now it make more sense to me why the config layout is looking like this.


[Bug/Question]

The mapping you give in example is a bit suspicious ?
Normally the nmap j gj should give an error because that results in infinite recursive mapping.
Am I missing something here ?

The only thing you may be missing is that this is the CodeMirror Vim implementation, not Vim. Many things are not working the way you'd expect. I'm personally happy with the Vim basics working in Obsidian, and slowly improving things where I can using this plugin :)

I see ! thanks for the comment, maybe I will look into CodeMirror for these implementations then ! Close this issue here.


Dramatically improve performance by threading the server

Resolve #10

Codecov Report

Merging #24 (e42a212) into main (86c27f9) will increase coverage by 0.08%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
+ Coverage   76.76%   76.85%   +0.08%
==========================================
  Files          12       12
  Lines         538      540       +2
==========================================
+ Hits          413      415       +2
  Misses        125      125


mat-menu disappears after opening on mobile Safari

Bug, feature request, or proposal:
Bug
What is the expected behavior?
Menus open and stay open until dismissed
What is the current behavior?
Menus open for a split second and then disappear
What are the steps to reproduce?
This is only on 7.0.0-beta.0, I need a starter stackblitz for that version. Any basic menu should reproduce it.
What is the use-case or motivation for changing an existing behavior?
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
7.0.0-beta.0
Is there anything else we should know?
The issue goes away if you use lazy rendering, ie. ng-template with matMenuContent.

I wasn't able to reproduce it against our demo app on a device running iOS 11. You can fork this Stackblitz which is running the 7.0 beta. https://stackblitz.com/edit/angular-92bnjh-lzasmw

Thanks for the starter. You're right, I couldn't reproduce it at first with the example from the docs. A menu with enough items to need a scroll bar does the trick though:
https://stackblitz.com/edit/angular-92bnjh-8nxizv
Breaks on my iPhone 7 on iOS11, let me know if it's not broken for you and I'll dig deeper.

...just found #11677, I guess mine's a duplicate?

Iphone 5s chrome/safari same problem

Can anyone provide a reproduction?

Can anyone provide a reproduction?

Sorry for the late response. I already posted a demo app that reproduces it. It looks like the "preview" function of stackblitz blows up on safari, so here's a direct link to the app that you can click from an iOS device: https://angular-92bnjh-8nxizv.stackblitz.io
As I said, it's on iOS11, it doesn't appear to be an issue on iOS12 (just released on the 17th). Angular Material supports the most recent two versions though, so it should be fixed. Thanks.

I think it may have less to do with the iOS version and more to do with the animation. I believe somebody else posted a similar issue where they said that it's not an issue in Material 7.0 since we use a much simpler animation.

I tested the same link on two devices, one running iOS11 and the other iOS12. It worked on 12 and not 11. You gave me the starter stackblitz which uses Material 7. So I guess this is a different issue?

I'm mostly guessing since I unable to reproduce it on my iOS11 device.

I was also successful at reproducing it in an iPhone 6s simulator running iOS 11.1.

And also in an iPhone 6s simulator running iOS 11.4. Can you try either of those?

problem is in OS not navigator "for me", all navigators run right, repeat "for me" in windows and android, but in Iphone does not work.

any update!
same issue only in latest safari browser

Same issue here. Looks like it always works on the third click.

Hi this is a common issue plaguing iOS. you want a running app to reproduce this ?

Also it looks that happens with menus positioned closed to the edges of the screen

Hi, same happens for my app. On the third click the menu stays open.
The bug only happens on iOs Phone, be it the installed app or the safari, simulators can't reproduce the problem.
My Project main Dependencies:

This is happening for me also and can be repoduced in the simulator.
iOS 12.4
iPhone 5s
Need to click 3 times to keep the menu open.
On angular / material 10.x


Changing labels in frontend

Configure canvas —> Preview
Map
Select basemap —> Change
basemap
options —> Edit

Frontend tests were OK :+1: (details)

@javisantana could you check it? should it be tested in staging?

I think this does not need staging :es:


What is the bin file in 'Resources' directory?

I want to use this to detect body in my custom picture. but after I drag it into the Resources directory and change a little bit here:
let fname = "test.jpg"
It seems the app didn't respond and can not detect where the body is.
I noticed there are two bin files(hadou.bin and person1.bin). Should I generate a bin file first for my custom picture?

It is not necessary to create a bin file.
Is there a check in Target-Membership?

 Thank you for your explanation.


chore: Update deploy_build_artifact.yaml permissions and artifact path

Summary by Sourcery
This pull request updates the deploy_build_artifact.yaml workflow by adding a 'workflow_dispatch' trigger, adjusting the artifact path in the 'upload-artifact' step, and modifying the 'publish release' step to include the bundle path in the artifacts.

CI:

Added 'workflow_dispatch' trigger to the deploy_build_artifact.yaml workflow.

Deployment:

Updated artifact path in the 'upload-artifact' step to only include 'dist/*'.
Modified 'publish release' step to include the bundle path in the artifacts.

This is an experiment review for experiment improve_review_guide
Run ID: improve_review_guide/run_2024-08-06T18-06-29_v1-21-0-70-g56484f776-dirty
The benchmark review for this pull request can be found at https://github.com/sourcery-ai-experiments/pydantic_tfl_api/pull/8.
This pull request was cloned from https://github.com/sourcery-ai-experiments/pydantic_tfl_api/pull/1. (Note: the URL is not a link to avoid triggering a notification on the original pull request.)

Experiment configuration
review_config:
  # User configuration for the review
  # - benchmark - use the user config from the benchmark reviews
  # - <value> - use the value directly
  user_review_config:
    enable_ai_review: true
    enable_rule_comments: false

    enable_complexity_comments: false
    enable_security_comments: false
    enable_tests_comments: false
    enable_comment_suggestions: false
    enable_functionality_review: false

    enable_pull_request_summary: false
    enable_review_guide: true

    enable_approvals: false

  ai_review_config:
    # The model responses to use for the experiment
    # - benchmark - use the model responses from the benchmark reviews
    # - llm - call the language model to generate responses
    model_responses:
      comments_model: benchmark
      comment_area_model: benchmark
      comment_validation_model: benchmark
      comment_suggestion_model: benchmark
      complexity_model: benchmark
      docstrings_model: benchmark
      functionality_model: benchmark
      security_model: benchmark
      tests_model: benchmark
      pull_request_summary_model: benchmark
      review_guide_model: llm

# The pull request dataset to run the experiment on
pull_request_dataset:
  # open-source PRs
- https://github.com/sourcery-ai-experiments/gpt-crawler/pull/1
- https://github.com/sourcery-ai-experiments/graphviz2drawio/pull/1
- https://github.com/sourcery-ai-experiments/graphviz2drawio/pull/2
- https://github.com/sourcery-ai-experiments/iptux/pull/5
- https://github.com/sourcery-ai-experiments/iptux/pull/6
- https://github.com/sourcery-ai-experiments/kalima/pull/3
- https://github.com/sourcery-ai-experiments/PED/pull/3
- https://github.com/sourcery-ai-experiments/pydantic_tfl_api/pull/1
- https://github.com/sourcery-ai-experiments/pydantic_tfl_api/pull/2
- https://github.com/sourcery-ai-experiments/Trenova/pull/11
  # Sourcery PRs
- https://github.com/sourcery-ai/core/pull/4055
- https://github.com/sourcery-ai/core/pull/4263
- https://github.com/sourcery-ai/core/pull/4352
- https://github.com/sourcery-ai/core/pull/4364
- https://github.com/sourcery-ai/core/pull/4366
- https://github.com/sourcery-ai/core/pull/4390
- https://github.com/sourcery-ai/core/pull/4402
- https://github.com/sourcery-ai/core/pull/4445
- https://github.com/sourcery-ai/core/pull/4462
- https://github.com/sourcery-ai/core/pull/4463

review_comment_labels: []

# Benchmark reviews generated by running
#   python -m scripts.experiment benchmark <experiment_name>
benchmark_reviews:
- dataset_pull_request: https://github.com/sourcery-ai-experiments/gpt-crawler/pull/1
  review_pull_request: https://github.com/sourcery-ai-experiments/gpt-crawler/pull/5
- dataset_pull_request: https://github.com/sourcery-ai-experiments/graphviz2drawio/pull/1
  review_pull_request: https://github.com/sourcery-ai-experiments/graphviz2drawio/pull/14
- dataset_pull_request: https://github.com/sourcery-ai-experiments/graphviz2drawio/pull/2
  review_pull_request: https://github.com/sourcery-ai-experiments/graphviz2drawio/pull/13
- dataset_pull_request: https://github.com/sourcery-ai-experiments/iptux/pull/5
  review_pull_request: https://github.com/sourcery-ai-experiments/iptux/pull/22
- dataset_pull_request: https://github.com/sourcery-ai-experiments/iptux/pull/6
  review_pull_request: https://github.com/sourcery-ai-experiments/iptux/pull/23
- dataset_pull_request: https://github.com/sourcery-ai-experiments/kalima/pull/3
  review_pull_request: https://github.com/sourcery-ai-experiments/kalima/pull/11
- dataset_pull_request: https://github.com/sourcery-ai-experiments/PED/pull/3
  review_pull_request: https://github.com/sourcery-ai-experiments/PED/pull/7
- dataset_pull_request: https://github.com/sourcery-ai-experiments/pydantic_tfl_api/pull/1
  review_pull_request: https://github.com/sourcery-ai-experiments/pydantic_tfl_api/pull/8
- dataset_pull_request: https://github.com/sourcery-ai-experiments/pydantic_tfl_api/pull/2
  review_pull_request: https://github.com/sourcery-ai-experiments/pydantic_tfl_api/pull/9
- dataset_pull_request: https://github.com/sourcery-ai-experiments/Trenova/pull/11
  review_pull_request: https://github.com/sourcery-ai-experiments/Trenova/pull/14
- dataset_pull_request: https://github.com/sourcery-ai/core/pull/4055
  review_pull_request: https://github.com/sourcery-ai-experiments/core/pull/207
- dataset_pull_request: https://github.com/sourcery-ai/core/pull/4263
  review_pull_request: https://github.com/sourcery-ai-experiments/core/pull/208
- dataset_pull_request: https://github.com/sourcery-ai/core/pull/4352
  review_pull_request: https://github.com/sourcery-ai-experiments/core/pull/209
- dataset_pull_request: https://github.com/sourcery-ai/core/pull/4364
  review_pull_request: https://github.com/sourcery-ai-experiments/core/pull/210
- dataset_pull_request: https://github.com/sourcery-ai/core/pull/4366
  review_pull_request: https://github.com/sourcery-ai-experiments/core/pull/211
- dataset_pull_request: https://github.com/sourcery-ai/core/pull/4390
  review_pull_request: https://github.com/sourcery-ai-experiments/core/pull/212
- dataset_pull_request: https://github.com/sourcery-ai/core/pull/4402
  review_pull_request: https://github.com/sourcery-ai-experiments/core/pull/213
- dataset_pull_request: https://github.com/sourcery-ai/core/pull/4445
  review_pull_request: https://github.com/sourcery-ai-experiments/core/pull/214
- dataset_pull_request: https://github.com/sourcery-ai/core/pull/4462
  review_pull_request: https://github.com/sourcery-ai-experiments/core/pull/215
- dataset_pull_request: https://github.com/sourcery-ai/core/pull/4463
  review_pull_request: https://github.com/sourcery-ai-experiments/core/pull/216


Musl tests plus fcntl/ioctl plus windows posix support

Depends on PR #1930

Only file unique to this pr is host/windows/posix.c

bors try

bors r-


UNFILED: move fts to after pipeline stuff

Fixed in Duke's PR here: https://github.com/RapturePlatform/Rapture/pull/125/files


Smart splitting without duplication execution of tests

This PR fixes the issue https://github.com/linkedin/bluepill/issues/352 and introduces smart splitting of test bundles based on test execution time estimates.
@ob, Please review.

Thanks, @nanwang1101 and @vaibhav-shah for the comments. I will incorporate the comments and split the Smart Splitting feature into a separate PR, to keep things simple.


Get associated PR from push event

Hi, thank you so much for this GitHub Action. It's looks awesome!
There is one thing I wish it could do: Get the associated PR from a push event.
Because, when pushing onto an existing PR, it doesn't create/update a test report PR comment.

If I understand correctly, this should be supported. Probably a question of how and when you run the action. We're using it for PRs on swup/swup where it definitely updates the existing PR comment after pushing to it. You might look into the workflow file over there to see if the setup is different than yours.


Fix ref-counting bug in health check client.

This fixes a crash seen internally where the health check client was unreffing the SubchannelCall object before all of the callbacks on the call had returned.
Prior to this PR, the code was having each callback hold a ref to the HealthCheckClient::CallState object, which in turn was holding a ref to the SubchannelCall object.  However, when we cancelled the call, we unreffed the SubchannelCall object as soon as the cancellation batch's on_complete callback ran.  This caused a crash when the recv_trailing_metadata_ready callback didn't return until after the cancellation batch's on_complete callback.
To fix this, I have changed the CallState object to tie its refcounting to that of the underlying SubchannelCall.  Each callback holds a ref to the underlying subchannel call, and the after-destruction callback from the subchannel call then destroys the CallState object.
The only down-side to this approach is that the ref to the SubchannelCall held by the CallState object is now a raw pointer instead of a RefCountedPtr<>, because we need that pointer to stay alive until after the last callback returns, so that the callbacks can unref it.  This is unfortunate, but there were already a bunch of callbacks tracking refs manually here, so it's not really introducing a new problem.
And we'll be able to make this problem go away once we build the new closure API, so I think we can live with it in the short term.

Known issues: #19004 #18416 #18840 #15464

Delayed follow-up: is there a test that reproduces the original condition that triggered this bug and that shows that the situation is now resolved? If not, can such a test situation be extracted and added?

There is a test internally that reproduces this (which is how the problem was found).  Unfortunately, I don't see an easy way to trigger the problem directly in a test, because we can't control the timing of the callbacks from a test.  (If this was going to be triggered externally, I would have expected that it would be caught by client_channel_stress_test, but we haven't seen this failure there.)

Does the internal test reproduce it deterministically and is it run as part of an internal presubmit?

Unfortunately, no.  The one I found to reproduce it wasn't even checked in yet.  There were also several reports of a problem in production, but I couldn't boil them down to a simple reproducible test case.
I'm not terribly happy with not having a test for this, but I didn't see a way to create one without doing a lot more work than I have time for right now. :(

I was thinking about this further last night, and I realized that the reason client_channel_stress_test wasn't catching this is that it doesn't enable client-side health checking!  I'm going to change it to do that -- even if I can't guarantee that it would have caught this particular bug, it will certainly increase our test coverage of the health-checking client code, which seems like a win.


Condense project files into a single JSON file

The project currently consists of a collection of INI files containing project settings.
Condense these into a single JSON file.
Update the program to use the JSON file instead of the separate INI files.

The files in question are:
ff1rom/ff1asm - the project file
values - values used globally across editors
strings - lists of strings used globally across editors
editorsettings - per-editor settings
dialogue - settings for each sprite's dialogue
std.tbl - standard table mapping file
dte.tbl -dual tile encoding table mapping file
pal - binary file containing palette colors


Attributes showing up wrong/weird.

Item attributes, such as base crit & life steal, aren't displayed correctly.
Example: My vampiric sword has "31% Base Life Steal", but it shows me "31% Base Hit  Enemies per Swing". The sword DOES actually apply lifesteal on hit though.
Every item shows something weird like this, even newly acquired/reforged ones.
If I socket gems they show what they're supposed to be correctly.
I am playing on a server that I host, and my friend doesn't have this issue. The mod's version is matched between client/server.
Let me know if I can provide further information.

Here's the list of mods I have:
modlist.txt
Here's a couple of examples:

Couldn't really tell you what's wrong.  Sounds like either your registry is corrupted beyond belief (which would cause other issues) or you have a resource pack mangling the translations.

Couldn't really tell you what's wrong. Sounds like either your registry is corrupted beyond belief (which would cause other issues) or you have a resource pack mangling the translations.

I have disabled all the resource packs I got, which only leaves "Default", "Mod Resources", and a "Supplementaries Generated..." (I can't see the full name).
I have tried every order and that didn't seem to be the issue.
As for the corrupted registry, I have no idea what that is and how to go about it, and I am not experiencing any other issues whatsoever. Would making a new instance and reinstalling all the mods again fix it? If not I'd appreciate a quick guide on how to go about this registry issue so I can test this theory.
Thanks.

I'm not necessarily certain how you can inspect registry corruption, as it is typically hidden from the user.

I'm not necessarily certain how you can inspect registry corruption, as it is typically hidden from the user.

What registry are we talking about here?
Windows reg? If so I could figure out something on my own.
Does Minecraft have a reg? If so, where is it? Can I get my friend to just send me their game folder and it'll work?
Thanks.

We would.be talking about the internal minecraft attribute registry.
You could try cloning your friend's instance, that may resolve it

Thank you, I will try that.
I'll post the results once we do, if you're interested.

It appears the cause was multiple mods.
I could only single out Reblurred in the new instance, but removing it in my original instance doesn't change anything.
Most of them were aesthetic mods anyway so I just stopped trying to add any, as I really don't feel like it's worth my time hunting down the ones causing it.


New issue

I write the telegram bot using this module and it shows the following mistake:
wikipedia.exceptions.WikipediaException: An unknown error occured: "Search request is longer than the maximum allowed length. (1825 > 300)". Please report it on GitHub!

You have reported this issue twice on this repo, here and at https://github.com/goldsmith/Wikipedia/issues/248.  Please close this issue.


Readme example to get_csr incorrect.

Chef::Exceptions::ValidationFailed
Option action must be equal to one of: nothing, import, generate_csr, dump_csr!  You passed :get_csr.

@vivekbhatia14 , thanks for catching that. Just created PR #18 to fix the docs.


Altering View Model with a Filter

@Eilon @rynowak @davidfowl
i have 3 classes A,B and C.
A and B class for Viewmodel those will be send from an action with separate views depending in query
but in HttpPost action will only have class C as a parameter.
using automapper and filter i want to convert the sending viewmodel class into class C before model binding.
which filter can help me to achieve that
how can i do that

@himadrinath I think what you want to implement for this is a custom model binder that understands the conventions of your application and binds things in the appropriate manner.


Pzz 39

fixes #39 adds basic readthedocs documentation

Just to clarify: Do we have to provide the build readthedocs files in our repo?
Furthermore, how we will deal with Readme.md in future? Is it a separate document which we'll curate for Github or do we need to sync content with readthedocs stuff?

the build files are not necessary, i can do make clean and then push the branch again. shall i?
readme.md is a separate document and does not affect the readthedocs documentation. To edit readthedocs you need to change the files in the docs/source folder.

Yes, if it's not necessary to have the build folder in our repo then please clean it before.

Done!

+1

:+1:

:+1:

👍

+1


Review config structure

Notes

Canonical (DMG) config for client, kube server, applications/bot/frame modules, etc.
Canonical URNs for DMG (incl. DIDs)
List of canonical ports
Well-known endpoints (e.g., .well-known/dx/config.json)

We should really be using the term “signaling” over “signal”. Mykola pls determine if that’s a practical change otherwise don’t.
Second, .well-known should be endpoints for returning metadata file — not actual service endpoints. This is a much bigger change. E.g., each KUBE “web service” should have a corresponding well-known definition, that might have information about it’s service endpoints (we don’t need to do this now). However, the signaling server’s endpoint should nto be .well-klnown/dx/signal
I propose:
All .well-known/dx are “KUBE (web) services” (https://en.wikipedia.org/wiki/Well-known_URI) have “endpoints” (which are URIs by type); NOTE: these services may expose different APIs e.g., /ux, different ports, methods, etc.
The signaling server may also require more information later (https://meetrix.io/blog/webrtc/how-to-setup-a-signaling-server.html)
so:
services
  # https://developer.mozilla.org/en-US/docs/Web/API/WebRTC_API/Signaling_and_video_calling
  signaling
    server:
      - url: wss://kube.dxos.org:7100 # TODO.

  # https://developer.mozilla.org/en-US/docs/Web/API/WebRTC_API/Protocols
  ice:
    - urls: turn:kube.dxos.org:3478
      username: dxos

NOTE: In my view urls should be uris but is so commonly used we should keep it.
I also encourage adding canonical reference links (W3C specs or MDN) comments if they are particularly helpful.

also to think about config file location ~/.kube (which collides with kubernetes) maybe it should be ~/.config/dx/kube ?


Updated import dependency in the Readme.md instead of being copied fr…

…om the example

Thanks @tlambrou 👍


Stop reading from stdin after programmatic API finishes

Fixes #252 by explicitly calling .pause() on the input stream after all commands have finished. This seems to be the only way to fix the problem, and there doesn't seem to be a way to reset the process.stdin state completely to the state before concurrently ran (see NodeJS docs).
Refactored some parts of the code in order to make this change more drop-in:

Added BaseHandler class that all handlers extend from
Add onFinish to BaseHandler which runs after all commands have finished
Add FakeHandler to tests that extend BaseHandler instead of ad-hoc handler objects in concurrently.spec.js
Use an actual Readable in input-handler tests instead of EventEmitter

The CLI has not changed in this PR, but the programmatic API now has two new options:

handleInput: an alias for the old inputStream: process.stdin. Just thought this would be nice, since 99% of the time, inputStream is set to process.stdin
pauseInputStreamOnFinish: Some people might have a use-case where they want to read from process.stdin further after running concurrently programmatically. In this rare instance, they'd have to explicitly set this option to false, or explicitly call process.stdin.resume() afterwards. I can't imagine this being a common use-case, so I think this explicitness is a good trade-off.

Repro steps

Write start.js as specified in #252, except replace require('concurrently') with require('.'). Put this file in the root of the repo.
node start.js + Ctrl-C should no longer hang / wait for Ctrl-D

@kimmobrunfeldt It seems like Node 8 reached EOL on Jan 1. Can we remove Node 8 from the CI pipeline? Apparently Promise.finally() was added in Node 10

@kimmobrunfeldt It seems like Node 8 reached EOL on Jan 1. Can we remove Node 8 from the CI pipeline? Apparently Promise.finally() was added in Node 10

Hey @brandonchinn178 👋
I've maintaining the package more than Kimmo actually -- I've bumped the minimum version to 10 on master.
Can you rebase and try again?

Hey @brandonchinn178 👋
I've maintaining the package more than Kimmo actually -- I've bumped the minimum version to 10 on master.
Can you rebase and try again?

@gustavohenke any progress on this?

@gustavohenke How's that?


Add Apache 2.0 License

This pull request adds an Apache 2.0 License to the repository. Fixes https://github.com/alexnguyenn/surface-code-generator/issues/4.

Thank you for the suggestion!


Add infinity scroll

Have an idea, what it should be not infinity scroll, but component, what can use scroll to control the data inside

Very basic implementation merged. Fully examples && and documentation will be in next issues


Preserve client IP

Add the feature to preserve client IP

This would be extremely helpful as it would allow you to filter by whitelisted, VPN-only IPs :)

That is, at the moment, not possible if  Overlay network is used. Docker is working on this issue and this ticket is more of a reminder to myself to add it to the proxy as soon as Docker releases the fix.

You need to use workaround right now: http://stackoverflow.com/questions/39854682/log-clients-real-ip-address-in-docker-swarm-1-12-when-accessing-a-service
--publish mode=host,target=80,published=80 \
--publish mode=host,target=443,published=443 \

You must be aware that with this you won't be able to run more than 1 docker-flow-proxy replica on the same node, so I run that with --mode global anyway.

@vfarcic Is https://github.com/moby/moby/issues/25526 the issue to follow for Docker's fix?

@joelchen That's the one.

Preserving client ip with overlay (or to be more accurate - ingress) is not possible but we should still have an option to restrict IPs from accessing certain services. Like morsik pointed out, you can publish docker-flow-proxy to host and then you have the correct client ip.

I'll close this issue since there does not seem to be anything we can do from DFP side. Publishing DFP to host is a workaround. Docker folks are unlikely to change how ingress network works.

You need to use workaround right now: http://stackoverflow.com/questions/39854682/log-clients-real-ip-address-in-docker-swarm-1-12-when-accessing-a-service
--publish mode=host,target=80,published=80 \
--publish mode=host,target=443,published=443 \

You must be aware that with this you won't be able to run more than 1 docker-flow-proxy replica on the same node, so I run that with --mode global anyway.

I am running also the proxy in mode global but I would like to agregate the stats from all haproxy instance. I am currently running a haproxy exporter to scrape the stats and send them to prometheus but with this recent change to global mode I will need to instance the exporters also in global mode and perform then an agregation of the stats. Do you know if there is an easier way to agregate the stats from the different haproxy?

I don't think there's an easier way to do that @Jacq


global variables at startup form DB

How to load the data from the database to the global variables at startup?
I would like to add a file in the 'config' directory, through the 'model' to get the data, assign to the global variable.

Hi @Wizzercn, please try posting support questions like this on our Google Group or Stackoverflow, or try our live Gitter chat room.  In this case it would be good if you could rephrase your question with a bit more detail about what you're trying to accomplish.  Sounds like you may just need to use the bootstrap script.


Refactor as custom select + Select2 4.1 compatibility

Close: #19, #49, #51, #60, #61

Add compatibility with Select2 4.1
Uses Bootstrap's custom-select implementation for uniformity
Use SVG background image for clear button
Add some lints to improve code readability
Use the same Browserlist configuration as Bootstrap 4.6
Add SCSS variables for easier customization #51
Add support for feedback validation icons

Fixes the following existing issues:

Missing input focus in single select dropdown
Fix input color in single select dropdown
Fix cursor pointer when hovering on search input in disabled select
Fix disabled color #60

Waiting for the proper branch to pushing against
Please help me testing
Screenshots

@tagliala
I have tested your reimplementation. I like it, but there seems to be a bug with an empty multiselect.
Have a look at the following screenshot:

@tagliala
I just figured out the issue.
I am sorry - It does not have anything to do with your code/css.
I had a custom-fix for an issue in my CSS, which is described here: Placeholder being cut off?
This is hopefully not necessary anymore. After removing this, the reported issue disappeared of course.
I am sorry and thank you for the support.

Hi @NordicAT, don't worry, you're welcome.
So we can say that this PR also fixes #77 ?

May it be the case, that the font-family of the placeholder-text differs from a Single-Select to a Multi-Select?

I can confirm an issue with font-family. It is being stripped out from the dist css and I should fix a rule. I'm investigating

@NordicAT fixed, thanks

I can confirm, that the font-family issue is fixed with the latest CSS - Thank you! :thumbsup:
I believe there is something wrong with Multi-Select.
The screenshot below shows a Multi-Select from the original Select2-docs:

Items that have been already selected have a grey background in the list.
First issue:
When looking on the same situation with your/our CSS for BS4 the background is way too light in my opinion. It may be, that my monitor has too less contrast, but I can hardly see a difference between selected and not selected items:

It must not be as dark as in the original Select2 CSS.
Second issue:
As in the screenshot above I see a light-grey background on selected items in the list.
If I hoover over those items, they lose their light-grey background. I have to reopen the list to bring it back.
I hope this issues are not in my environment only ...

When looking on the same situation with your/our CSS for BS4 the background is way too light in my opinion

Agreed. Let me check how bootstrap deals with this

As in the screenshot above I see a light-grey background on selected items in the list.

Replicated. It is also an issue at https://ttskch.github.io/select2-bootstrap4-theme/

@NordicAT fixed both

@tagliala
Wow - Thank you very much! :relaxed:
I can confirm that both issues are fixed.
Just a small cosmetic one:
When activating a Multi-Select by clicking on it, the select-box gets a blue outer-glow:

When activating a Single-Select by clicking on it, the select-box does not get a blue outer-glow.

It gets glowing after an item has been selected.
I may be wrong, but for me this does not seem consistent.
Looking at the Bootstrap-Docs the Select is glowing when activating:
https://getbootstrap.com/docs/4.6/components/forms/

@NordicAT done.
I've added the focus style to the properly focused input element, as in the default Select2

I just use basic features of Select2 and for me it is working fine now.
There is nothing to complain about.
Thank you very much for your effort! :heart: :ok_hand:
Hope there will be an official release soon ...

Hi!
Thanks for updating Select2 Bootsrtap4 Theme!
Does updated (in development) select2-bootstrap4-theme theme is compatible with form validation with jQuery validation updated (Bootstrap v4.6 custom select) design?
I guess it should, but want to be on the safe side.
(Did not see any examples in your screenshots.)
Probably - with single select - it should be ok.
Yet on multiple select close button may conflict with satus (valid/invalid field) icon.

Does updated (in development) select2-bootstrap4-theme theme is compatible with form validation with jQuery validation updated (Bootstrap v4.6 custom select) design?

Is the previous version of this theme compatible with that plugin?
Is Select2 4.1 rc0 with the default theme compatible with that plugin?

If the answer is yes to both, could you please create a fiddle and check that this update didn't break things?

1

Is the previous version of this theme compatible with that plugin?

I think it is partly compatible (when validating border is green/red but no success/error icon is displayed)
2

Is Select2 4.1 rc0 with the default theme compatible with that plugin?

Sadly, i can not find info about support of jQuery validation with Select2 v4.
Issues on GItHub with this keyword seem to be 5 years old and reference older version of Select2.
3
As this issue reads "Refactor as custom select + Select2 4.1 compatibility" i hope
that changes to markup (based on Bootstrap v4.6 custom-select) allows to display
icons indicating validations success/fail icons additionally to field border.

As this issue reads "Refactor as custom select + Select2 4.1 compatibility" i hope
that changes to markup (based on Bootstrap v4.6 custom-select) allows to display
icons indicating validations success/fail icons additionally to field border.

I can fix this

@Rikijs

with focus:

Will add custom variables and commit

Looks good!
Perhaps, there should be a litte more spacing between field clear icon and  validation status success/error icon.

@Rikijs done

Great!
Just a litle typo in updated image of different states.
It is saying "Invalid example" 2 times.

Question: Is it currently posible to change color of all select2 borders in one go in one place?
Default is to light for my current project and overriding seams to planed in this isssue.

Question: Is it currently posible to change color of all select2 borders in one go in one place?

The only variable used for border color should be $select2-bootstrap4-border-color. Danger and Success are inherited from bootstrap

Yet overriding in CSS (using 1.5.2 version) overrides success/error states. (I might be overriding not efficiently.)

If you need to override via CSS, you should preserve the order of rules and css specificity

I've fixed a couple of issues with validation focus and validation icons are now supported also in select multiple

I've fixed a couple of issues with validation focus and validation icons are now supported also in select multiple

That is great news!

@tagliala please share your estimate when release/tag could be made?

This is not my repository, apologies

I've been using your branch @tagliala and following this PR for changes. Appreciate the work! Have you considered publishing your changes to npm under @tabliala/select2-bootstrap4-theme?

I apologize for the negligence.

@tagliala
Hi, I was trying to create a Bootstrap Horizontal form with Select2 selects.
It looks like this:

There seems to be a problem in Smartphone-size:

I have created the following JSFiddle using a strapped-down sample-code to reproduce the issue:
https://jsfiddle.net/612pmajt/3/
I am not sure about the problem-source. It may not be the fault of the select2-bootstrap4-theme.
I can't exclude my own code. Could you please have a short look?
Thank you

This theme does not support Bootstrap 5

@tagliala
I am sorry this was a mistake when adding the resources to the JSFiddle.
Here is the updated one with 4.6 CSS & JS: https://jsfiddle.net/5we3zL0t/

I've got the issue, but I don't know if 100% should be forced in the CSS
Please add  width: $(this).data('width') ? $(this).data('width') : $(this).hasClass('w-100') ? '100%' : 'style', to the initializer
Ref: https://github.com/ttskch/select2-bootstrap4-theme/blob/master/docs/script.js#L5

@tagliala
Working fine - Thank you very much! :ok_hand:
I just recognized that this may not be an big issue for the end-user, because on page load it is displayed OK.

@tagliala Could you please assess what is stil missing to finish this pull request?

@Rikijs since this is not backward compatible, it needs another branch on this repo to push against

@tagliala @ttskch What else is needed to get this merged/released? Can I help in any way?

@tagliala Does this version still support 4.0.x as well, or only 4.1?


a11y: fix project tree roles and aria

Description
This improves aria for the Project Tree control.
Includes the following changes:

Remove redundant aria-label causing two elements in the chain to have the same name
Remove redundant tabIndex and move keyboard handler to the place where the keyboard event happens
Make aria-labels to follow the rule: visible content goes first in the label

Task Item

VSTS 70524

Screenshots
#minor

Coverage remained the same at 55.883% when pulling 1a9f51b6f67272c0ef3918fc95b8bc8ba20bf4f3 on OEvgeny:a11y/project-tree-2 into f5b059af5047d8b7c9498adf3195339b6c0fe582 on microsoft:main.


SDK 1.19 'MicrosoftCognitiveServicesSpeech/SPXSpeechApi.h' file not found build on build on Any iOS Device(arm 64)

build on Any iOS Device(arm 64),
Showing All Messages
xxx/one-app/NativePluginProjects/iOS/NativeAudioPlugin/AudioPlugin/AudioPlugin/AudioRecorder.h:7:9: 'MicrosoftCognitiveServicesSpeech/SPXSpeechApi.h' file not found
build on simulator is OK

@FanChen2016 Thanks for the report, we will investigate. In 1.19.0 we have changed to xcframework. Are you using existing project with Speech SDK and when you moved to the latest Speech SDK, you are seeing this error ?

are seeing

Yes,  seeing this error when moved to the latest Speech SDK.

@jhakulin Yes, seeing this error when moved to the latest Speech SDK.

@FanChen2016 Thanks for the report, we will investigate. In 1.19.0 we have changed to xcframework. Are you using existing project with Speech SDK and when you moved to the latest Speech SDK, you are seeing this error ?

Yes, seeing this error when moved to the latest Speech SDK.

You can try out adding the following in your Podfile. I had a similar issue.
target 'Runner' do
  use_frameworks!
  use_modular_headers!

  $static_framework = ['NativeAudioPlugin']

  pre_install do |installer|
    Pod::Installer::Xcode::TargetValidator.send(:define_method, :verify_no_static_framework_transitive_dependencies) {}
    installer.pod_targets.each do |pod|
      if $static_framework.include?(pod.name)
        def pod.build_type;
          Pod::BuildType.static_library
        end
      end
    end
  end
end

@FanChen2016 In the meantime we are investigating a proper fix, could you let me know if importing the Speech SDK in your swift app code where you use Speech SDK APIs would help to your issue ?
import MicrosoftCognitiveServicesSpeech

If this does not help, could you try to add use_modular_headers! in your Podfile and see if that helps.
target 'YourApp' do
    use_modular_headers!
end

@FanChen2016 We need to update the SpeechSDK Cocoapod to exclude the armv7, that should resolve this issue.
As a workaround, you can exclude the armv7 from Any iOS Device by doing following

pod install, which will install MicrosoftCognitiveServicesSpeech-iOS (1.19.0)
Exclude armv7 architecture by adding line below into MicrosoftCognitiveServicesSpeech-iOS.debug/release.xcconfig files under your app project Pods/Target Support Files/MicrosoftCognitiveServicesSpeech-iOS directory and Pods-<YourApp>.debug/release.xcconfig files under Pods/Target Support Files/Pods-<YourApp> directory. When I tested this workaround with https://github.com/Azure-Samples/cognitive-services-speech-sdk/tree/master/quickstart/swift/ios/from-microphone quickstart, I needed to update 4 xcconfig files in total.

EXCLUDED_ARCHS[sdk=iphoneos*] = armv7

We will target to push new Cocoapod during this week.

thanks.

From the 1.20 release notes:
iOS: Compiling your Speech SDK application on any iOS Device when using CocoaPods is now fixed (GitHub issue 1320)

@gyuri-fluttech Unfortunately, there seems to be still a problem even with the fix made in 1.20.0. We made change in podspec to exclude armv7 and i386, but seems that does not work populate as excluded architectures atleast in all Xcode versions correctly. Based on the limited documentation what I can find, the correct fix for this would be to include armv7 flavor into xcframework package so that nothing needs to be excluded. We may consider that in future releases.

@jhakulin , thanks for the update. I can confirm that it is still there in 1.20.0 .

I add
post_install do |installer|
  installer.pods_project.targets.each do |target|
    target.build_configurations.each do |config|
      config.build_settings['ARCHS'] = "arm64 x86_64"
    end
  end
end

to the Podfile. I can successfully archive it.

MicrosoftCognitiveServicesSpeech-iOS (1.20.0)
Xcode 13.2.1
OS: macOS 12.2.1
Hardware ARM (M1)

@gyuri-fluttech Just for your information, we will add armv7 support in 1.21.0 release which should fix the issue also. ETA mid April.

Fix has been included in 1.21.0 Speech SDK for iOS, closing the item.

Speech SDK 1.21 was release. See release notes: https://docs.microsoft.com/azure/cognitive-services/speech-service/releasenotes?tabs=speech-sdk#speech-sdk-1210-april-2022-release


Fix for issue #592

In addition a messagebox was added when the config name and category are the same. Before, the program crashed.

Thank you


RUSTSEC-2021-0119

It seems as if you guys use an older version of wayland-rs that itself uses an older version of nix
I have looked into it and have tried to upgrade the version of wayland-rs used in this crate but some types went missing and this requires a bit more work than I expected,
Would you guys accept to merge an alpha version of a crate (v0.30.0-alpha3) ?

Hey!
I would be willing to accept an alpha version as long as you are willing to do the changes that are required when it moves over from non-alpha (hopefully it's just a matter of updating the version)

Unfortunately, it's not ;/