snakemake-tibanna run not finding rule

@johanneskoester Do you mind taking a quick look at this issue? You may find the problem more easily. https://github.com/4dn-dcic/tibanna/issues/256

Hi @johanneskoester ,
I have posted several comments in 4dn-dcic/tibanna#256. Please let me know if you have any suggestions. Thank you!
Best,

I just ran into the same problem, it looks like the snakemake target includes the S3 bucket as a prefix but the Snakefile does not have this prefix, so snakemake cant figure it out which rules produces this output.
example:
rule a:  output: a.txt
ends up being submitted to tibanna as snakemake $S3_BUCKET/a.txt
but there's no rule that produces $S3_BUCKET/a.txt

I think I figured out.
there are 2 issues that can cause this rule not found error.
First, is that I think snakemake is assuming a bucket subdir is always present. if I try to use --default-remote-prefix=BUCKET it gives the error, but with --default-remote-prefix=BUCKET/dir it works.
Second, is that you can't mix rules that depend on the default prefix with rules that use explict S3.remote, that is you can either write:
rule a: output: "a.txt"; rule b: input: "a.txt" or
rule a: output: S3.remote("BUCKET/dir/a.txt"); rule b: input: S3.remote("BUCKET/dir/a.txt")
but you can't mix both styles, which is a bummer because rule all downloads the inputs to the local host if you are using the default prefix.


(#723) Add docs for C4BAE Jenkins jobs update

Description Of Changes
Adds documentation on how to update the included Jenkins jobs in the Chocolatey for Business Azure Environment via the internalization and deployment of the chocolatey-licensed-Jenkins-jobs package.
Motivation and Context
These jobs had been using the choco list command when they should have been using choco search. Chocolatey CLI v2.0.0 enforces the list command only returning local packages and so the jobs need to be updated.
This will happen for new deployments of the C4B Azure Environment, but this docs addition covers how to update existing deployments.
Testing

[X] I have previewed these changes using the Docker Container or another method before submitting this pull request.

Change Types Made

[ ] Minor documentation fix (typos etc.).
[X] Major documentation change (refactoring, reformatting or adding documentation to existing page).
[ ] New documentation page added.
[ ] The change I have made should have a video added, and I have raised an issue for this.

Issue #

Change Checklist

[ ] Requires a change to menu structure (top or left hand side)/
[ ] Menu structure has been updated

Related Issue
Fixes #723

@Windos thanks for getting this added!


[BEAM-12475] Ensure the BundleProcessor.getId() is null before calling reset.

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

cc: @chamikaramj

Run Java KafkaIO Performance Test

Run Java KafkaIO Performance Test

Without this there is a big performance regression for streaming pipelines where bundleprocessor reuse is critical.

Shouldn't this be in ProcessBundleHandler?

R: @lukecwik

LGTM


chore(deal-ticket): 4743 preserve estimate position cache in deal ticket

Related issues 🔗
Issue: #4743
Description ℹ
Since we can't easily cache in apollo EstimatePositionQuery (no-cache policy, no explicitly id, changing variables) we can as workaround preserve old results in case when current one is undefined
Demo 📺

Technical 👨🔧

Discussed with @macqbat this morning and he doesnt think the suggestion from Matt can work ... I want to delay unti @mattrussell36 is in to progress this so have said we should move ahead with the current implementation and revisit later if it is a problem.


Remove the '°' character for hsl on color2cssString function. Its invalid!

In the browser, due to that character, degree, the final string output is totally invalid. For now, I have used a string replace method to have it wiped out.
Thank you kindly!

Sure, I'll do it. Thank you!

@allocenx Fixed! :)


Merkle Tree Logs

Idea: if we where to use merkle tree logs, then it would be possible to securely replicate a portion of a feed.
The messages would still contain a link to the previous message, but the messages would also be hashed into a binary tree. Then I can request the 5th message, this would point to the hash of the  first 4 messages (since 32 is a power of 2)
it would be
hash(
  hash(hash(msgs[0]) + hash(msgs[1])) +
  hash(hash(msgs[2]) + hash(msgs[3]))
)

Then, if I requested message 1 later, I could verify it was consistent with what I was given last time.
Currently we use only use a singly linked list. This is simple, but can only be used to verify that messages are part of a log if you have the entire log.
I suspect that this would be very useful on the edges of the network. Maybe you want to retrive a reply that a friend of a friend of a friend made? If you did this for everyone on reddit it would be too much resources - but if you got a few messages from them, it would still be highly secure, because you would be able to prove those messages where part of the same tree, using just a few extra hashes...
This would mean rewriting most of the validation code.

@dominictarr hi, @pfraze directed me to this discussion, just want to point you towards a datastructure proposal i vizualised to explain it to myself and others.
https://github.com/krl/notes/wiki/append-only-finger-tree
i think something like this could work very well for logs

So, if the new message does not refer to the prior message, but to the last root hash.
Validation would then be to take the previous known hash, apply the append operations, and see if all the messages refer to the right roots along the way.

@krl can you do a sparse verification? like if I have the 1st, and 100th message, and then i get a 50th message can i verify that it's actually in that chain without pulling down everything?

yes, you can have a merkle-proof that message nr 50 actually is contained in the root-hash of nr 100. you would just have to ask for uncles leading to root-hash 100 for message 50.
Also note, in this scheme, with 100 messages, you would have message 1 and 100 directly in the root node.

hello, anyone have progress on this topic? I am highly interested and want to contribute.

@carloslfu that is great! This would be a pretty difficult thing to add because you are getting right into the heart of ssb. It can be done, but we'd need a strategy. It's important to get a useful, usable result in the short/medium term - what are you hoping to achive? lets figure out a way to get there!

oh wow cool issue.

but then you would be able to request the latest message, the first message, and then any message in the middle and prove that it was part of that log.

from my perspective (still keen to hear from @carloslfu), it seems this helps solve two problems at the moment:

out-of-order messages (being able to request a specific message from a log that you aren't following),
initial syncs (starting from the latest so you get immediate content without the lag)
partial syncs (maybe you don't even need to fetch every message from my log if we just met).

/cc @mmckegg

Hi @dominictarr and @ahdinosaur I am hoping to achive more faster inital syncs and partial syncs. Also would be nice as @ahdinosaur says to have out-of-order messages. For now I am learning about the protocol and reading the code. I will experimenting and doing some proofs of concept  as soon as possible.

For future travelers, here is a more recent, somewhat detailed discussion on merkle trees: https://viewer.scuttlebot.io/%25L9m5nHRqpXM4Zkha1ENTk5wNOXQMduve8Hc9%2BF0RLZI%3D.sha256


Coverage with running godog with go test ?

Hi
Is it possible to get the coverage running godog with go test ?
I tried with the sample, the tests were executed but got a warning and a 0.0% in coverage

/go/src/github.com/DATA-DOG/godog/examples/godogs# go test -v -cover
... 3
1 scenarios (1 passed)
3 steps (3 passed)
356.725µs
Randomized with seed:<PHONE_NUMBER>518706237
testing: warning: no tests to run
PASS
coverage: 0.0% of statements

well, maybe you need to have at least one go test, because godog currently takes into account all coverage when run with go test

hmm i tried the official example in
https://github.com/DATA-DOG/godog/tree/master/examples/godogs
it should work if i understand ? anyone has the same problem ?

it has no standard go tests, try godog itself:
cd $GOPATH/github.com/DATA-DOG/godog
go test -cover
go test -v -cover

You should see different coverage percentage, because -v runs different formatter which is not widely covered with unit tests.
What I mentioned in the first message, is that you must have at least one standard go test func in order to have coverage report.


MultithreadFix: slight FPS boost via multithread improvements

As mentioned at #44, this removes D3DCREATE_MULTITHREADED safety flag for a slight FPS improvement, and adds some fixes for deadlocks caused by flag being removed.
A MultithreadFix option is added to [DISPLAY] section of INI to toggle it, haven't added GUI stuff for the setting yet though.
This seems to boost FPS by +40-60 for me when running with framelimiter removed, so hopefully will help with FPS drops when playing normally too.
Haven't tested it that much yet though, would appreciate anyone giving it a try! If you get any crashes/hangs please let me know. (maybe create a CrashDumps folder next to bio4.exe first before testing it)
You can grab release build from https://github.com/nipkownix/re4_tweaks/suites/7489522135/artifacts/307461430 - just make sure to edit dinput8.ini and set MultithreadFix to true first.

Latest test build here:
https://github.com/nipkownix/re4_tweaks/suites/7489522135/artifacts/307461430

Been testing this a bit more lately and haven't had any weird stuff happen so far.
Looks like we're not getting much more people interested in testing as well, sadly.
I'll probably rebase this onto current master (after the trainer merge) and send a test build to albert. Hopefully he can have some of his testers play with it as well, so we can merge it soon.
A new release approaches :p

Rebased onto latest master, build will be up shortly.
For me this lets r101 go from ~220FPS when looking at village, up to ~250-260FPS
While moving camera to the side (copying the radio call anim) went from ~800FPS to ~950FPS.
Not as big an improvement as dxvk, but still an improvement overall, maybe if it tests as stable enough we could let it be the default for d3d9 users.

Many thanks once again!


Add support for multiple client addresses

New feature as requested in issue #8

Support added in version 6.0.0 commit c2fc302cc1a84023ecd1c05ce7c67c99e6351bf8

Can confirm, the new changes work

Have just discovered a problem with how the adress incrementation works when the first address is a IPv6 adress which may lead to a adress exaustion with the IPv4 adresses
peer: [redacted]=
  preshared key: (hidden)
  allowed ips: [my public prefix]::2/128, fded:bd70:e03e:15::2/128, <IP_ADDRESS>/32

peer: [redacted]=
  preshared key: (hidden)
  allowed ips: [my public prefix]::3/128, fded:bd70:e03e:15::3/128, <IP_ADDRESS>/32

peer: [redacted]=
  preshared key: (hidden)
  allowed ips: [my public prefix]::4/128, fded:bd70:e03e:15::4/128, <IP_ADDRESS>/32

peer: [redacted]=
  preshared key: (hidden)
  allowed ips: [my public prefix]::5/128, fded:bd70:e03e:15::5/128, <IP_ADDRESS>/32

peer: [redacted]=
  preshared key: (hidden)
  allowed ips: [my public prefix]::6/128, fded:bd70:e03e:15::6/128, <IP_ADDRESS>/32

peer: [redacted]=
  preshared key: (hidden)
  allowed ips: [my public prefix]::7/128, fded:bd70:e03e:15::7/128, <IP_ADDRESS>/32

peer: [redacted]=
  preshared key: (hidden)
  allowed ips: [my public prefix]::8/128, fded:bd70:e03e:15::8/128, <IP_ADDRESS>/32

peer: [redacted]=
  preshared key: (hidden)
  allowed ips: [my public prefix]::10/128, fded:bd70:e03e:15::10/128, <IP_ADDRESS>/32

peer: [redacted]=
  preshared key: (hidden)
  allowed ips: [my public prefix]::20/128, fded:bd70:e03e:15::20/128, <IP_ADDRESS>/32

peer: [redacted]=
  preshared key: (hidden)
  allowed ips: [my public prefix]::40/128, fded:bd70:e03e:15::40/128, <IP_ADDRESS>/32

peer: [redacted]=
  preshared key: (hidden)
  allowed ips: [my public prefix]::80/128, fded:bd70:e03e:15::80/128, <IP_ADDRESS>/32

Hmm ...  that does look odd ... sorry - will work on it.

Sorry about that - can you please test version 6.2.0 - should be fixed now.

Closing as complete  by commit 3c926064cb3d9464f2ac0a0e1d5258d49243841c
Let me know if anything else crops up and thanks again for letting me know.

:+1: Just tested the changes and they worked :tada: :D

Awesome!! THanks for all your help.


[21.05] libressl_3_2: add patch for CVE-2021-41581

Motivation for this change
https://nvd.nist.gov/vuln/detail/CVE-2021-41581
This introduces a patch added to master in #139545.
I'm not sure what to do about libressl_3_1 here, because I'm fairly sure the vulnerable code just doesn't exist in 3.1, only introduced in https://github.com/openbsd/src/commit/d27446ede9e6006e354c72686f0ad11f1219b733. But I'd say I'm only 99% certain there so I'm not sure we should just decide it's not vulnerable based on me and my opinion. Even if we did, people with automated scanning tools would pick 3.1.5 up as "vulnerable" as the various CVE databases don't consider this vulnerability to have a "start version".
libressl_3_1 doesn't actually appear to be used by anything in 21.05 currently, so I would probably be able to mark it as knownVulnerabilities without affecting any other packages.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 142029 run on x86_64-linux 1

3 packages blacklisted:

tests.nixos-functions.nixos-test
tests.nixos-functions.nixosTest-test
tests.trivial

18 packages failed to build:

disnix
disnixos
dydisnix
foundationdb (foundationdb61)
foundationdb51
foundationdb52
foundationdb60
mydumper
opensmtpd
python38Packages.foundationdb51
python38Packages.foundationdb52
python38Packages.foundationdb60
python38Packages.foundationdb61
python39Packages.foundationdb51
python39Packages.foundationdb52
python39Packages.foundationdb60
python39Packages.foundationdb61
wasm-pack

10 packages built:

acme-client
catgirl
dysnomia
libressl (libressl_3_2)
lispPackages.nyxt
netcat
nyxt
openntpd (openntpd_nixos)
pounce
twa


feat: add logout function

add logout function for CLI

Reference: issue #594
Current queries:

api_key is currently defined as a String type, which means I've had to set the API key in the logout function as an empty string. This technically works, but I'm wondering if it's more correct to set it as None?

Nice! While it does work, I think your hunch is correct, it would be better to not just set it to an empty string. I'm thinking we could either change the set_api_key function to take an Option<ApiKey>, or we could add a new method, something like clear_api_key. I'm not quite sure what I would prefer :smile: Maybe you can try it out and see what feels best?

Nice! While it does work, I think your hunch is correct, it would be better to not just set it to an empty string. I'm thinking we could either change the set_api_key function to take an Option<ApiKey>, or we could add a new method, something like clear_api_key. I'm not quite sure what I would prefer 😄 Maybe you can try it out and see what feels best?

I decided to add a clear_api_key function in the end since I think that makes more sense for the purpose of modularity, in case we need to use it anywhere else.


Added periods to data simulation.

Can now choose between day, week, month and year.

Closing due to refactor of code, and new implementation of date.


Support latest version of pyarrow.

Pyarrow has recently updated to 0.11.1, which doesn't have BitUtil::BitNotSet.
Which was removed in https://github.com/apache/arrow/pull/2355.
Use !BitUtil::GetBit instead, as suggested in PR above.

Thanks, merging. CI is broken due to other issues. We have quite a bit of maintenance work to do.


dataset

You need to download the notMNIST dataset from here.
could you send me the notMNIST dataset, please? I don't find it on the Internet.

how to adress this problem?


[5.6] Tightenco/Collect should not be replaced anymore

It's now under on its own namespace to co-live with Illuminate\Collection. And this is preventing us to require it.

👍 Thanks Antonio!

Shouldn't we use "tighten/collect":"<5.6.0" since it still would conflict with those version.
PR to 5.5 as well?

I love this fixed thanks! @antonioribeiro

@crynobone Great question. I really wish we could backport the alias, because it's really not version specific. But you're right; older versions will still have this same issue.
And yah, I do think it should apply to multiple versions.
@antonioribeiro would you be up for making the requested changes?

@mattstauffer, already done:
https://github.com/laravel/framework/pull/23152 - 5.5
https://github.com/laravel/framework/pull/23153 - 5.6
@crynobone, thank you.

Note: the namespace change happened in tightenco/collect 5.5.33, that's why it's <5.5.33, after that there's no need to replace collect anymore.

@antonioribeiro One more thing, https://github.com/laravel/framework/blob/5.6/src/Illuminate/Support/composer.json#L24

Done, @crynobone:
https://github.com/illuminate/support/pull/61
https://github.com/illuminate/support/pull/62


feat: list marketplace item versions

What this PR is for?
Add miactl marketplace list-versions command to list versions of a specific marketplace item.

Manca la doc


Docker Image Push Action

In auth-middleware, I already have a job setup that will build and public the Docker image. However, I would like to create a reusable action around that functionality that not only encapsulates everything that job does, but will also dynamically publish a new latest and staging tagged image on respective runs.
Luckily, the docker/build-push-action allows for multi-tag publishing, so I will just need to put together the CSV list of tags to push.
One thing to keep in mind when putting together this action is that docker/build-push-action will freshly checkout the repo by default. It does allow for a context input to be provided to override this default behavior and should be extended to my custom wrapper workflow. In general, a lot of the inputs available to docker/build-push-action could be useful to allow for.

Note for auth-middleware in general, is that the deployment status updates should and could be moved to an "always" run job that will determine if any of the previous jobs failed and update the deployment status accordingly. Example here.

Closed by:

#18
#19


Document behavior change in static placeholders

Summary
After the upgrade to version 3.5, in the structure mode, plugins in static placeholders are no longer displayed.
Expected behaviour

Actual behaviour

Environment

Python version: 2.7.9
Django version: 1.11.10
django CMS version: 3.5.0

It should be possible to click on a title of a static placeholder to expand things.

Oh, thanks!  It needs pointer cursor at least.

Closing as documentation has been added and no response since 2018.


XML Editor behaves incorrectly when using tabs and indent_size other than 1

Problem
If indent_style = tab and indent_size = 2 (or anything other than 1) the XML editor behaves incorrectly. The tabs will (correctly) be the width specified by indent_size but indentation will be done with a number of tabs equal to the indent_size instead of just a single tab. (The reason 1 works is because it will use only one tab which will be only one unit wide. It looks ugly but technically behaves correctly.)
Steps to reproduce

Have this plugin installed (of course)
Use indent_style = tab and any indent_size bigger than 1
Format any XML file

Notes
I believe the issue is on this line. The problem is due to an oddity of the XML editor. The "indentation size" option is not how many units the indentation is, it is how many of the indentation character (see here) to use. (Why they have it set up like this is beyond me. It seems silly. I can't imagine anyone ever wanting to use multiple tabs to represent a single level of indentation.)
The simplest solution would be something like below.
@Override
public void visitIndentStyle(final ConfigProperty<IndentStyleOption> property) {
	// ...
	setPreference("org.eclipse.wst.xml.core", "indentationChar", spacesForTabs ? "space" : "tab");
	// add this conditional to set size to 1 is using tabs
	if (!spacesForTabs) {
		setPreference("org.eclipse.wst.xml.core", "indentationSize", "1");
	}
	// ...
}

@Override
public void visitIndentSize(final ConfigProperty<Integer> property) {
	// ...
	// add this conditional to only set indent size when using spaces
	if (<using spaces>) { // Not sure how to get that property here though...
		setPreference("org.eclipse.wst.xml.core", "indentationSize", indentSizeString);
	}
	// ...
}

The only issue is not having access to the ConfigProperty for IndentStyleOption inside visitIndentSize. An alternative would be to make sure visitIndentStyle is called after visitIndentSize so it can override  if it is needed, but I don't know how easy that would be with this code base, I haven't looked too far into it.

Thanks for the feedback. I think your analysis and proposal are sound. The following two enhancements will be required:

Add a method to EditorFileConfig to get a property by name:

public class EditorFileConfig {
    // ...
    public ConfigProperty getConfigProperty(String name) {
        // ...
    }
}

Make the visitor implementation stateful so it holds the EditorFileConfig instance and can use the above method to apply your suggested logic. For example line 44 of EditorConfigEditorActivationHandler would change to:

configProperty.accept(new EditocConfigVisitor(fileEditorConfig));

With these changes, your logic above can be implemented in the new visitor as:
public void visitIndentSize(final ConfigProperty<Integer> property) {
    // ...
    if (IndentStyleOption.SPACES.equals(this.fileEditorConfig.getConfigProperty("INDENT_STYLE").getValue())) {
        setPreference("org.eclipse.wst.xml.core", "indentationSize", indentSizeString);
    }
    // ...
}

You would also need to do null checking and write some automated tests.

In the case where the indent style is tabs then you will probably want to actually clear the value of the XML editor indent size.

I'm going to start taking a stab at this but I may have some questions since I've never done anything with Eclipse plugins. I think most of it should be pretty straight forward though.

@ncjones is this going to be merged one day? :)

@victornoel you are welcome to pick up the code from where I left off (or start fresh). I have stopped working on this a long time ago since I stopped using this plugin.

Thanks @JacksonBailey, I'm more worried about @ncjones answer to the question though ;)

@victornoel this change was being driven by @JacksonBailey. I believe the changes are in PR #42 which I commented on but the requested changes were never made. If you are really keen then you can pick up that branch and get it working. Sorry I don't have time or incentive to work on this myself.

@ncjones no problem if you don't have the time, I mostly wanted to know if you were available to merge and release new version. In that case I will take a look at it this week-end :)

@ncjones I hope you get the time to review #47, merge it and release a new version of your plugin :)

I did no excessive testing, but my .editorconfig with [*.{groovy,java,kt,xml}] and 4 spaces didn't have any effect on pom.xml files in eclipse (but worked correctly with java files)

@SebastianDietrich / @victornoel I no longer use Eclipse, if you're both saying this is no longer an issue let me know and I will close this issue. I just wanted to make sure.

I can confirm that it works with eclipse 2021-12 (latest) on *.xml files

Closing. 🎉 We did it folks! 😆


🍒[cxx-interop][SwiftToCxx] Do not crash while trying to expose a macro to C++

This fixes a compiler crash that happened when emitting a Clang header for a Swift module that declares multiple macros with the same base name and different argument names.
Swift macros are not currently designed to be exposed to C++. This teaches the compiler to explicitly mark them as unavailable in C++.
rdar://117969472 / resolves https://github.com/apple/swift/issues/69656 (cherry picked from commit f42609b7bd0c2b519bebe83756002fcebf747f8a)

@swift-ci please test


Support binary mode for CloudEvents

In what area(s)?

/area runtime
Describe the feature
Support CloudEvents binary mode so that payloads for message brokers can more easily work with non-json payload types and dapr can more easily work with non-dapr systems.
For example, if you produce a Kafka message in Avro or Protobuf format, you will want to be able to use the message seamlessly with tools like ksql and confluent connectors.
As it stands right now with dapr, this is not possible. Dapr will encode the message and wrap it in a json data structure. In order to work with other systems, the data needs to be decoded and unwrapped.
About CloudEvents Binary Mode
Most CloudEvents specs support the idea of "binary mode." In this mode, the payload is left in binary and attributes or headers are used for the "envelope."
Some examples of this:

Kafka binary mode uses headers for envelope data and leave payload as raw message content: https://github.com/cloudevents/spec/blob/v1.0.2/cloudevents/bindings/kafka-protocol-binding.md#32-binary-content-mode
AMQP binary mode uses message properties for envelope data: https://github.com/cloudevents/spec/blob/v1.0.2/cloudevents/bindings/amqp-protocol-binding.md#31-binary-content-mode

Some protocols only support structured content mode. For example NATS(https://github.com/cloudevents/spec/blob/v1.0.2/cloudevents/bindings/nats-protocol-binding.md) only supports structured content mode.
Possible solutions

Support binaryMode=true metadata. Individual pubsub implementations in components-contrib would need to adopt if support is allowed according to standard
Automatically detect content type of message and use binary mode. This seems less ideal because I can imagine some people would want to use "binaryMode" even for json payloads just to make it easier and not wrap the payloads.

Release Note
RELEASE NOTE: ADD Support for binary mode in CloudEvents

I saw this defect got closed. Does this issue fix in any recent release?
I was trying to publish CloudEvent of Mode Binary from a non-dapr systems. Unfortunately, I am not able to read the header information. Any suggestion is most welcome.

@dipankaj I think the maintainers might have lost interest or are too busy.
https://github.com/dapr/components-contrib/pull/1715 was the first step
The approach I designed works. The 2 PRs, if accepted would allow for using dapr with binary mode.

Thanks, @vangheem, I am sure there will be many like me eagerly waiting for this to merge. This will help to integrate non-dapr systems with dapr one.

Maintainers have not lost interest. We'll be engaging this effort for 1.9.

@yaron2, what is the release date for 1.9?

Hi @vangheem, @yaron2 ,
Any update on this, please? I am eagerly waiting to incorporate Cloud Even binary mode in my project.

We got too busy with many other things. We still have interest in supporting this.

Thanks, @artursouza for tagging this requirement for the v1.10 milestone. As mentioned by @yaron2, I was expecting this to be a release candidate for 1.9. I am worried my business can wait for that long. Will it be possible to prioritize it for v1.9, please?

@yaron2 @artursouza, can you please share the release calendar?

@yaron2 any idea when would be 1.9 release ?

I was wondering same: Why defaulting to Structured CloudEvent ?
Looking at some demos: https://docs.dapr.io/developing-applications/building-blocks/pubsub/pubsub-cloudevents/#example
I see structured CE usage like:
curl -v -X POST http://localhost:3501/v1.0/publish/orderpubsub/orders -H "Content-Type: application/cloudevents+json" -d '{"specversion" : "1.0", "type" : "com.dapr.cloudevent.sent", "source" : "testcloudeventspubsub", "subject" : "Cloud Events Test", "id" : "someCloudEventId", "time" : "2021-08-02T09:00:00Z", "datacontenttype" : "application/cloudevents+json", "data" : {"orderId": "100"}}'

For some transports, like Kafka, with structured CE there may be issues: For instance with binary we can have "Tombstone Records" (null record values), while with structured the value would never be empty
Also: https://github.com/cloudevents/spec/blob/main/cloudevents/spec.md#message
The above states another benefit of using binary content mode over structured content mode as it is less obstructive and therefore compatible with systems that do not understand CloudEvents.
(Part of why I came here is that I do see in Dapr Pub/Sub docs a different guidance on CloudEvents vs Non-Cloudevents)
Also, I think the JSON parsing w/ structured CE is slow? while binary avoids it.
For binary the metadata (including your dapr extensions) are just headers, and the data, is just the regular payload.
See the "ported" curl
curl -v -X POST \
    -H "Content-Type: application/json" \
    -H "ce-specversion: 1.0"  \
    -H "ce-type: com.dapr.cloudevent.sent"  \
    -H "ce-source: testcloudeventspubsub"  \
    -H "ce-subject: Cloud Events Test"  \
    -H "ce-time: 2021-08-02T09:00:00Z"  \
    -H "ce-id: someCloudEventId"  \
    -d '{"orderId": "101"}' \
    http://localhost:3501/v1.0/publish/orderpubsub/orders

@matzew Looks like maintainers might have lost interest in this. Milestones are changing all the times :(

@matzew Looks like maintainers might have lost interest in this. Milestones are changing all the times :(

We have interest in adding this, but it would need to be a community contribution. We have other things taking over in priority.


Fixed comment typo in hardware.py

Fixed a minor typo in hardware.py file.
From "loosing" to "losing".
Loosing has a different meaning than losing, hence the change.

Thanks !


LocationClient cannot be resolved error

My cordova project already uses google play services. When I tried to import this plugin am getting following error in eclipse
Description	Resource	Path	Location	Type
LocationClient cannot be resolved to a type	GoogleMaps.java	/MeDine/src/plugin/google/maps	line 118	Java Problem

Probably you are missing "com.google.playservices" plugin.
https://github.com/wf9a5m75/google-play-services

I have google play services. But I have the latest version of the library. That version removed location client class completely

Even though, this plugin specifies the previous version on my repository.
On Mon, Jan 5, 2015, 11:29 PM oneto018<EMAIL_ADDRESS>wrote:

I have google play services. But I have the latest version of the library.
That version removed location client class completely
—
Reply to this email directly or view it on GitHub
https://github.com/wf9a5m75/phonegap-googlemaps-plugin/issues/345#issuecomment-68834693
.

yes it does. but I am already using google play services library for a new function. I can't use both version of the library in same project. And google play services is being updated to devices very often. So even if the app compiles properly with older version of the library , it would crash or not work in new version of the phones. Anyway fixing this issue properly will solve that https://github.com/wf9a5m75/phonegap-googlemaps-plugin/issues/158. until that this plugin would be unusable in newer devices

FusedLocationProviderApi did not work properly on some devices, the api never response, even if I set the timeout. So I enrolled back to LocationClient class.

I think to get this thing work on all os is to check which one (fused location provider or locationclient)  and conditionally execute . But I haven't got any clue how that would be possible. Anyway hopefully in near future it would become more clear. Thank you for response

I'll keep in mind, and test it in near future.

@oneto018
I updated the plugin code for Google Play Services v22. It's available on the test branch.
Check it out.
$> cordova plugin add https://github.com/wf9a5m75/phonegap-googlemaps-plugin#test --variable API_KEY_FOR_ANDROID=...

I will check the v22 release. Downgrading to v19 broke everything.

v22 is here.
https://github.com/wf9a5m75/google-play-services/tree/v22
$> cordova plugin rm com.google.playservices
$> cordova plugin add https://github.com/wf9a5m75/google-play-services#v22


name property of ks.Series([1,2,3]) is '0' not None

Just notice a Series behaviour in a WIP PR,
>>> s1 = ks.Series([1,2,3])
>>> s1.name
'0'

is this designed on purpose? i think in pandas this should be None.

I think it was because:
>>> pd.DataFrame([1,2,3])
   0
0  1
1  2
2  3

However, for series, yes. I think we should fix. Maybe we should add an internal field name that's matched to None .. ?
cc @ueshin

closed since it's resolved in #1712 .


NaN (ra, dec) pairs in CCDs tables

There are some rows in the current DR8 CCDs tables with NaN values in both the RA and DEC columns. These may turn out to correspond to garbage frames.

Closing and moving over to the legacypipe product https://github.com/legacysurvey/legacypipe/issues/330


[FEAT REQ] false to disable keymap(s)

This way, you can set your own keymaps instead of NeoComposer doing it for you. You can disable keymaps you don't need.
Example:
require("NeoComposer").setup({
  keymaps = {
    play_macro = false,
    yank_macro = false,
    stop_macro = false,
    toggle_record = false,
  },
})

-- OR
require("NeoComposer").setup({
  keymaps = false
})

Good idea. Although I would have to leave the play_macro keymap because the lualine functionality depends on knowing the keymap.


Ensure to show the archived report footer for admins and announce rooms

Details

The findLast method returns undefined if the report action is not found and that in turn is not changed with the default prop value in the Archived  report footer.
Lets return null early if the archived room has no closed report action.
Fixed Issues

$ https://github.com/Expensify/App/issues/16324
Tests

Create a workspace
Send a message in the admins room
Delete the workspace
Verify the admins chat is showing the archived message footer instead of composer
Verify the announce room does the same
Sign out and sign back in and confirm the footer is still showing.

[ ] Verify that no errors appear in the JS console

Offline tests

Same as tests
QA Steps

Same as tests.

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

@sobitneupane @marcochavezf One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Reviewing

Getting following console error unrelated to this PR:

Nice thanks, that error should be resolved here https://expensify.slack.com/archives/C01GTK53T8Q/p1679985774068529?thread_ts=1679665614.690159&cid=C01GTK53T8Q

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@0xmiroslav thanks for that, I was considering this approach too but then I have changed to return early to make sure we dont filter, sort and then search for the closed report action if there is none.
I like updating Onyx to handle the undefined better.

🚀 Deployed to staging by https://github.com/marcochavezf in version: 1.2.91-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Allow @observer decorator for stateless functional components as properties

We have a lot of react components, composed with custom render methods, instead of render components. For example:
class SomeComponent extends React.Component {
  renderHead() {
    // render head here
  }
  renderFoot() {
    // render foot here
  }
  render() {
    return (

        {this.renderHead()}
        {this.renderFoot()}

    );
  }
}

I found that mobx's observer could be used to improve performance of rendering that components, without huge refactorings: just decorate render methods by observer, change arguments list to single argument object and replace method calls to component instantiation:
@observer
class SomeComponent extends React.Component {
  @observer
  renderHead() {
    // render head here
  }
  @observer
  renderFoot() {
    // render foot here
  }
  render() {
    return (

        <this.renderHead />
        <this.renderFoot />

    );
  }
}

It was very naive, because this example isn't works at all. this.renderHead refers to undefined after decorating it to observer. The only working example i've found is to use observer as a function, not as decorator:
@observer
class SomeComponent extends React.Component {
  renderHead = observer(() => {
    // render head here
  })
  renderFoot = observer(() => {
    // render foot here
  })
  render() {
    return (

        <this.renderHead />
        <this.renderFoot />

    );
  }
}

So, mu question is: is it a bug or expected behaviour? Should observer used as decorator on class methods?

@Strate, basically, you are using your renderHead and renderFoot as a stateless components, so applying observable() may help, but not as a decorator, it is not intended to be used like this.
PS: To me it's seems more logical to declare those components outside the class.

@andykog that components are not completely stateless, because they has access to this, which helps to reduce boilerplate with bypassing props from parent to child.

@Strate, using this doesn't make them statefull. They don't have own state. And “stateless functional component” is the official term. I think the way you are using it not very obvious. I would at least pass this as a prop. But thats not the topic of current issue. You can use observable(statelessFunctionalComponent), not decorator.

@andykog okay :)
I just want to suggest to allow use observer as a decorator on class method, because there is at least one use-case :)

Ok, then I changed the title :-)

To me using stateless components like this is still seems like a bad practice, so I'm not sure we should encourage that.

It is already allowed, but with observer() signature.

@Strate, Yes, observer() creates you observer component, and you can place it anywhere, even in class property, but I don't like this idea, so I wouldn't make @observer a class property decorator that will serve only for that single purpose. You are also allowed to use classes like this by the way:
@observer
class SomeComponent extends Component {

  child = observer(class extends Component {
    render() { return null; }
  });

  render() {
    const Child = this.child;
    return <Child />
  }
}

I think doing like child = observable(props => rendering) is not like really bad, but it is a bit weird because of the following; each SomeComponent get's its own, bound versions of those components. That is ok-ish, but what is trickier is that these fields are initialized during the construction of the SomeComponent instance. That is quite expensive as not all instantiated components will be mounted (if I remember correctly the reconciler works on instances and not on elements).
I agree with @andykog that stylewise not nesting components is nicer (I never saw that anywhere although I think that should work indeed from a technical perspective.

So I guess, this feature won't be implemented. @Strate, feel free to reopen if you have additional arguments/propositions


fix: integration tests SHELL-1543

Fixes SHELL-1543

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


I want more charts

system environment: win 10 64-bit
way to install: pip install
python version:3.7
superset version:1.01
I want more charts,like Mixed Line and Bar,Stacked Horizontal Bar...but superset charts haven't.How to add Mixed Line and Bar,Stacked Horizontal Bar?

Hi @winterliebe if you're fluent with frontend engineering, you can add custom viz plugins. The community is in the process of migrating to Echarts, which will eventually unlock more charts (https://echarts.apache.org/examples/en/index.html).
Here's some places to get started for building custom viz plugins:

https://superset.apache.org/docs/installation/building-custom-viz-plugins
https://medium.com/nmc-techblog/apache-superset-manage-custom-viz-plugins-in-production-9fde1a708e55

Hi all,
If I'm not wrong, horizontal bar chart is something that is missing from the current version of Superset (1.0.1 I mean).
And I think it would add value. Sometimes, an horizontal bar chart is more pleasant to read than a vertical one :)

our composed chart supports horizontal bar chart, but it is only designated for non temporal X-Axis columns
https://github.com/nielsen-oss/superset-viz-plugins/tree/master/plugins/plugin-chart-composed
you can try it out from the storybook: https://5fec4c81935a8c002151e85f-qigjnxoxyc.chromatic.com/?path=/story/plugins-composed-chart--bars

Hello @srinify . Is there a place where we can follow the progress of the echarts migration?

For those interested, there's a 2021-2022 roadmap here: https://docs.google.com/spreadsheets/d/1V82lxvWeWJK48o8S0OkeTnlL409DbtZSa9qTzdSHx6I/edit#gid=0


Improve etl dashboard

Some small improvements of the ETL dashboard I thought of, as I was using it to update the climate namespace:

Add a "Details list" with more details about steps selected in the Steps table (e.g. list of updateable dependencies).
Add more parameters on how to run the ETL.
Minor speed-up of the code.

@lucasrodes there's no need for a thorough code review, but you can simply run it, to check that the changes make sense, thanks!

Hi @lucasrodes thanks for the suggestions! I've made the background color of the buttons in the tutorial transparent, which should work for both light and dark layouts.
The issue with analytics is not related to the dashboard. You need to run make refresh.pageviews in your grapher to fetch analytics. This is a bit annoying, but it's a grapher issue.
I agree that the Details list can get very long, which is inconvenient. Let's improve it in a separate PR!


Override getMessage in UnexpectedStatus

Before this change, standard approaches to logging errors would result
in something that looked like org.http4s.client.UnexpectedStatus: null, which is not the most helpful error message in the world. I don't
have strong opinions on what this message should look like and I'm happy
to change it, but I think that it should include the status (at least
its code) in some form.

Current coverage is 59.64% (diff: 100%)

Merging #662 into master will increase coverage by 0.51%

@@             master       #662   diff @@
==========================================
  Files           198        198
  Lines          4341       4342     +1
  Methods        4038       4042     +4
  Messages          0          0
  Branches        301        298     -3
==========================================
+ Hits           2567       2590    +23
+ Misses         1774       1752    -22
  Partials          0          0

Powered by Codecov. Last update b6d2861...de5c562

👍   I'm going to cherry-pick this so it's on release-0.14.x, too.

Fixed via cherry-pick.  Thanks!


bug: cannot connect to outside resources

Bug Report
Ionic version:

[x] 4.x
Current behavior:

after launching the app with $ ionic cordova run android --device --livereload at the very top I am getting the error:

GET https://fonts.googleapis.com/css?family=Montserrat net::ERR_INTERNET_DISCONNECTED

this is the same with any other outside resource such as the socketio server
Expected behavior:

to be able to fetch the fonts/other outside resources
Steps to reproduce:

Related code:
<!DOCTYPE html>
<html lang="en">
  <head>
    <meta charset="utf-8" />
    <title>App</title>

    <base href="/" />
    <meta
      name="viewport"
      content="viewport-fit=cover, width=device-width, initial-scale=1.0, minimum-scale=1.0, maximum-scale=1.0, user-scalable=no"
    />

    <meta name="format-detection" content="telephone=no" />
    <meta name="msapplication-tap-highlight" content="no" />

    <link rel="icon" type="image/png" href="assets/icon/favicon.png" />
    <link href="https://fonts.googleapis.com/css?family=Montserrat" rel="stylesheet" />
    <link href="https://fonts.googleapis.com/css?family=Clicker+Script" rel="stylesheet" />

    <!-- add to homescreen for ios -->
    <meta name="apple-mobile-web-app-capable" content="yes" />
    <meta name="apple-mobile-web-app-status-bar-style" content="black" />
  </head>
  <body>
    <app-root></app-root>
  </body>
</html>

in the config.xml I have it allowed:
    <allow-navigation href="*" />
    <allow-intent href="http://*/*" />
    <allow-intent href="https://*/*" />
    <allow-intent href="tel:*" />
    <allow-intent href="sms:*" />
    <allow-intent href="mailto:*" />
    <allow-intent href="geo:*" />

insert short code snippets here

Other information:

Ionic info:

   Ionic CLI                     : 5.4.13 (/Users/me/.config/yarn/global/node_modules/ionic)
   Ionic Framework               : @ionic/angular 4.11.7
   @angular-devkit/build-angular : 0.801.2
   @angular-devkit/schematics    : 8.3.21
   @angular/cli                  : 8.3.21
   @ionic/angular-toolkit        : 2.1.1

Cordova:

   Cordova CLI       : 9.0.0<EMAIL_ADDRESS>   Cordova Platforms : ios 5.1.1
   Cordova Plugins   : cordova-plugin-ionic-keyboard 2.2.0, cordova-plugin-ionic-webview 4.1.3, (and 13 other plugins)

Utility:

   cordova-res : 0.8.1
   native-run  : 0.3.0

System:

   ios-sim : 8.0.2
   NodeJS  : v13.5.0 (/usr/local/Cellar/node/13.5.0/bin/node)
   npm     : 6.13.4
   OS      : macOS Mojave
   Xcode   : Xcode 11.3 Build version 11C29

See: https://stackoverflow.com/questions/59306640/http-get-working-but-not-working-in-buildrelease-debug-in-ionic-4/59310320#59310320

thanks for the info. That might be the issue, however, in the path suggested<root>/resources/anroid/xml/network_security_config.xml I don't have the xml file so I am trying to find another way

Just run this > ionic cordova run android

I was able to do it by placing the code directly within the config.xml file. Thanks


Primary key in model using a missing column

Hi Prisma Team! Prisma Migrate just crashed.
Command
db pull
Versions

Name
Version

Platform
darwin-arm64

Node
v16.13.1

Prisma CLI
4.1.0

Engine
8d8414deb360336e4698a65aa45a1fbaf1ce13d8

Error
Error: [libs/datamodel/connectors/dml/src/model.rs:494:29] Hi there! We've been seeing this error in our error reporting backend, but cannot reproduce it in our own tests. The problem is that we have a primary key in the model `CUSTOMER_BRAND_LINK` that uses the column `DATE_UPDATED` which we for some reason don't have in our internal representation. If you see this, could you please file an issue to https://github.com/prisma/prisma so we can discuss about fixing this. -- Your friendly prisma developers.

If I can help you guys with this I will. We have a DATE_UPDATED column in another table called CUSTOMER_BRAND_LINK_META and this error suggests it was expecting to find it on CUSTOMER_BRAND_LINK. I see another missing column issue (#14462) where the column is on another table Product_Category_Mapping but is expected on Product. I'm just guessing that it's something to do with searching for table names or underscores.

DATE_UPDATE is also not a primary key on the table. It is however used in an index.

Bug confirmed, it's been reported here as well.

Hi, I have tried reproducing this issue here but I haven't had luck so far. Would please share a SQL dump of your database, and your schema.prisma file? We understand you may not feel comfortable sharing this private info in public, so another option would be sending those files privately to<EMAIL_ADDRESS>We can also sign NDAs if necessary.
Moreover, could you please describe how the database was created and/or update? For instance, did you start from an existing SQL database that you introspected and maybe later modified via prisma?

I am looking forward to trying out the new version! I'm sorry I couldn't offer more info to help with this. I had a major family emergency and had to drop everything.

4.2.0 is out already, so let us know if you had the time to play with it and this indeed helps and fixes the problem 🚀


Add pagination component

A draft PR for a new contribution: a pagination component.
It's based partly on this one in the MoJ Pattern Library and partly on this one in the GOV.UK Component Library - but it takes into account guidance in the Home Office Design System, feedback in the GOV.UK Design System backlog and conversations with @adamsilver and @gregtyler (esp. this issue in moj-frontend). Guidance for the component is being developed in this branch of govuk-design-system.
Preview this component in the GOV.UK Design System

Decisions still to make

[ ] Elipses or dots?
[ ] Allow html in links?
[ ] What should the default for previous/next links be?

Design decisions
The design is an attempt to balance 3 competing needs:

consistent spacing of numbers
conservation of horizontal space
large enough targets

To do this...
The number elements have a minimum width and height of 45px, to meet WCAG target size criteria. They also have horizontal padding applied (based on the perceived padding that a single-digit element has, due to the min-width setting). This is so that digits wider than 45px still receive the padding users expect.
The elipses characters are given negative margins, so that the numbers are evenly spaced, and horizontal space is conserved.
Finally, at mobile resolutions all but the first, last, current, previous and next characters are shown, again, to conserve horizontal space.

Hi,
We’ve also been working on a pagination pattern at HMRC and were close to publishing. It makes more sense for it to be in the main design system though, so we’ve paused for now.
Here’s the draft HMRC pattern: https://github.com/hmrc/design-patterns/issues/172
Our main driver for taking on the pattern was to share accessibility improvements we’d made to pre-existing patterns shared by other departments. We also wanted to centralise the logic for link list truncation so this wouldn’t be redeveloped by separate teams.
We’re happy to discuss (our front-end dev is Tim Bryan, and Adam Liptrot has been looking at this from an accessibility perspective). Our main question though, is when do you think the Design System pattern will be published? If it’s unlikely to be soon, we might still publish the HMRC version. But if it is soon, we’ll probably not publish and remove the HMRC pattern from our backlog.
Best, Jon

Prototype here superseded by production PR for pagination: https://github.com/alphagov/govuk-frontend/pull/2610 closing this PR.


Update getting_started.org

Seems like the words are in the wrong order - see here: https://github.com/d12frosted/homebrew-emacs-plus

For reference, the flag only changed recently as part of https://github.com/d12frosted/homebrew-emacs-plus/commit/c9a41a3abc88edd792bf282a7e3ee0637af19b5f

Appears to be a duplicate of https://github.com/hlissner/doom-emacs/pull/3518.


Parsing issue

i could puzzle something together from the API, but i’d just like to run a script on my source package which then does it all.
how did you fill the website? is there a crawler?

thanks! yes, my package destiny (huh? by “undefined”?) has only its old 1.x version on there instead of the already released 2.x

@flying-sheep okay good to know! We're planning to revise the package parsing logic and can use your package as one of the use-cases. I'll keep you posted.

@ludov04 when the new parser is up, could you manually add this package to the work queue to see if it fixes it?

@flying-sheep The new version of your package is on RDocumentation with the correct author and collaborators

great, thank you!


Remove redundant version tags in pom.xml

For artifacts managed by pom-scijava, we don't need to specify a <version> tag. It's sufficient to set to set a version <property> to override the version if necessary.
Also remove duplicate (optional) dependency imagej-ui-swing, as it is listed as dependency already.

In addition to this PR, I tried cleaning up the dependencies by running mvn dependency:analyze, which gives the following output:
[INFO] --- maven-dependency-plugin:3.1.1:analyze (default-cli) @ sciview ---
[WARNING] Used undeclared dependencies found:
[WARNING]    org.scijava:scijava-table:jar:0.4.0:compile
[WARNING]    com.google.guava:guava:jar:21.0:compile
[WARNING]    net.imglib2:imglib2-realtransform:jar:2.2.1:compile
[WARNING]    com.github.skalarproduktraum:jogl-minimal:jar:992c9ad:compile
[WARNING]    org.slf4j:slf4j-api:jar:1.7.26:compile
[WARNING]    sc.fiji:bigdataviewer-vistools:jar:1.0.0-beta-20:compile
[WARNING]    sc.fiji:bigdataviewer-core:jar:9.0.5:compile
[WARNING]    org.jetbrains.kotlin:kotlin-stdlib:jar:1.4-M1:compile
[WARNING]    net.imglib2:imglib2-algorithm:jar:0.11.1:compile
[WARNING] Unused declared dependencies found:
[WARNING]    net.clearcontrol:coremem:jar:0.4.6:compile
[WARNING]    org.jogamp.jogl:jogl-all:jar:2.3.2:compile
[WARNING]    org.scijava:scijava-ui-awt:jar:0.1.7:compile
[WARNING]    org.scijava:scijava-search:jar:0.7.0:compile
[WARNING]    net.imagej:imagej-mesh-io:jar:0.1.2:compile
[WARNING]    org.scijava:scripting-jython:jar:0.4.2:compile
[WARNING]    net.imagej:imagej-ui-swing:jar:0.23.2:compile
[WARNING]    net.imagej:imagej-legacy:jar:39befb3:compile
[WARNING]    org.apache.commons:commons-math3:jar:3.6.1:compile
[WARNING]    org.jetbrains.kotlinx:kotlinx-coroutines-core:jar:1.3.5-1.4-M1:compile
[WARNING]    org.scijava:scijava-plugins-commands:jar:0.2.3:runtime
[WARNING]    net.imagej:imagej-plugins-commands:jar:0.8.1:runtime
[WARNING]    ch.qos.logback:logback-classic:jar:1.2.3:runtime
[WARNING]    sc.fiji:spim_data:jar:2.2.4:compile

Is it safe to remove all these dependencies, or is maven telling lies here?

Is it safe to remove all these dependencies, or is maven telling lies here?

@skalarproduktraum If they can be removed, awesome. But if needed at runtime (but not compile time), it would be great to change them to runtime scope.

Thanks for doing this! However I am a bit unsure what "Used undeclared" and "Unused declared" mean specifically, could you explain @imagejan? A few of the unused declared look like transitive dependencies from scenery.

I'm sure there's a documentation about maven-dependency-plugin somewhere, but in short, here's how I understood it:

Used undeclared:
There are classes from this dependency imported somewhere in the source code, but the POM doesn't declare this dependency explicitly (only implicitly via transitive dependencies).
Unused declared:
No classes from this declared dependency are ever used in the source code (but classes of transitive dependencies might be, of course).

So in most cases, we should replace those unused declared by the more specific used undeclared dependencies.


T06.09-Solution-EditTextPreference

My solution

PR is requesting we merge changes from later lesson branches into earlier lesson branches.
We will not be doing this as these branches are set-up this way on purpose for the course.


Add support for explicit inner joins

Currently Quill only supports explicit outer joins. This pull request adds inner join support, thereby allowing the mixing of explicit inner and outer joins just as one would do in plain sql.
Beyond filling in missing functionality the rationale for this PR is that Applicative/implicit join filtering is limited to the where clause. In some cases it is beneficial at the sql level to bind joined tables with a concrete value in the on clause. For some relational databases this allows a form of pre-filtering before where clause conditions are applied.

Current coverage is 96.89%

Merging #112 into master will decrease coverage by -0.34% as of 224116d

Powered by Codecov. Updated on successful CI builds.

Thank you for the contribution! I was unsure that explicit Inner joins were necessary and was trying to avoid adding to ways of defining the same thing, but your motivation is reasonable.
I'm traveling today and will probably review it tomorrow.

We're going to need both explicit and implicit joins in order to maximize Quill functionality wrt to hand written sql, so while the functionality of explicit joins seems to replicate that of applicative/implicit joins, they don't; explicit joins are strictly speaking not the same and are more powerful given the ability to bind value(s) within the on clause pre-where clause filtering.
Having both options is a win-win, IMO ;-)
PR fails code coverage in RenameProperties.scala for some reason (maybe was already failing before this PR?)

@godenji Yeah, I think the coverage report is wrong!
Thanks again for the contribution. I'm merging the pull request now and there should be a snapshot version published to maven central when the build on master finishes.

@fwbrasil great, more coming ;-)


Status of the project?

No commits since last year's November, would be cool to atleast see an archival/unmaintained message :+1:

Following up on this project as there has not been any updates in nearly a year.
Will BetterViewer continue to be updated?  Will the extension be updated to incorporate manifest v3 requirements by Google?
Thanks!

Hello everyone,
I deeply apologize for the lack of updates on BetterViewer. Due to commitments in my studies and work, I've been unable to dedicate time to the project recently. However, I believe in the potential of this extension and its community.
I encourage anyone interested to contribute to the project.
Thank you for your understanding and support.


Consumer Group Offsets

How would I go about connecting to an existing consumer group and fetching the current offset of each topic in the group? Is that feature not possible yet?

i have the same request and didn't find anything in the doc :(


allow write strings to file

http://play.crystal-lang.org/#/r/ja5

http://play.crystal-lang.org/#/r/ja6

little unexpected, thanks


my solution to RubyRefresher

My first Ruby challenge and first pull request ever; Yay! :) Please review.

@ciaochow Good stuff! Keep up the good work.


Omitting column names for INSERT statement gives error

Given a table:
CREATE TABLE status
(
  id integer,
  name varchar(100) NOT NULL,
  PRIMARY KEY(id)
);

the following INSERT query is valid in PostgreSQL:
INSERT INTO status VALUES (1, 'initial state');

Therefore I expect the following definition to be recognized by sqlc:
-- InsertStatus :exec
INSERT INTO status VALUES ($1, $2);

But sqlc gives me the following error:
queries.sql:2:1: INSERT has more expressions than target columns

For such an INSERT query I would expect the generated query function to take the Status struct as argument instead of generating an additional InsertStatusParams struct.
The same is true, if I define an INSERT query, which lists all columns of the target table.

Related discussion: #587

This is fixed in v1.23.0 by enabling the database-backed query analyzer. We added a test case for this issue so it won’t break in the future.
You can play around with the working example on the playground

Hello! It isa bit weird that no matter if the fields are nullable or not, the generated code generates only pgx nullable types. Makes it a bit annoying to work with


UX: Make environments switchable via a dropdown on the left-hand side menu

Current behavior:
As a Portainer admin, when I want to switch environments, I have to press the home navigation button and then select my environment from the list.
Desired behavior:
The selected environment badge (that has an X button for clearing) is transformed into a drop-down menu, This way I can easily switch to another environment without having to load the home page first.
I am attaching a screenshot with clarification below.
portainer-fix.png

@isaric
I wanted to follow up on this request.  Can you provide more information as to what a drop down would solve for you?
Thanks!

@tamarahenson It would reduce the number of actions a user needs to take in order to switch to another environment. In addition, the application would make one request less to the backend.

@isaric
I wanted to follow up on this.  The request is currently being reviewed and discussed by Product.  I do not have yet have a timeline or release.
Thanks!


Pull Request for Object Storage Configuration

Prior to the CLC WordPress MVP go live we are adding documentation on how to manually configure CenturyLink Object Storage.
We are requesting a pull prior to go live to ensure formatting is correct on CTL's website.

There's nothing in this PR... but the original commit looks like it's using HTML syntax. It's preferable if the kb docs were written in markdown syntax.

I'd not done this before, I think I forgot to select the branch my teammate created. I submitted again.
I had edited his HTML earlier to markdown syntax

Thank you for the feedback. I have updated the header variable "contentishtml" and also edited the html img syntax to markdown.
Please let me know if I should resubmit a pull request or if the pending pull is still valide
Bill


Something went wrong on itch-setup

Something went wrong
itch-setup, v1.18.0, built on Apr 10 2019 @ 08:29:17, ref 57838bc373361f2c8938336674247f869999e862
HTTP file not found on server
htfs.Open (initial request)
github.com/itchio/itch-setup/vendor/github.com/itchio/wharf/pwr.(*ArchiveHealer).heal
C:/Multi-Runner/builds/58469115/0/itchio/itch-setup/src/github.com/itchio/itch-setup/vendor/github.com/itchio/wharf/pwr/archive_healer.go:253
github.com/itchio/itch-setup/vendor/github.com/itchio/wharf/pwr.(*ArchiveHealer).Do.func3
C:/Multi-Runner/builds/58469115/0/itchio/itch-setup/src/github.com/itchio/itch-setup/vendor/github.com/itchio/wharf/pwr/archive_healer.go:102
runtime.goexit
C:/Go/src/runtime/asm_amd64.s:1337
github.com/itchio/itch-setup/vendor/github.com/itchio/wharf/pwr.(*ArchiveHealer).Do
C:/Multi-Runner/builds/58469115/0/itchio/itch-setup/src/github.com/itchio/itch-setup/vendor/github.com/itchio/wharf/pwr/archive_healer.go:209
github.com/itchio/itch-setup/vendor/github.com/itchio/wharf/pwr.(*ValidatorContext).Validate.func5
C:/Multi-Runner/builds/58469115/0/itchio/itch-setup/src/github.com/itchio/itch-setup/vendor/github.com/itchio/wharf/pwr/validator.go:138
runtime.goexit
C:/Go/src/runtime/asm_amd64.s:1337
while installing
Error during warm-up

That issue was fixed (server-side) a few days ago, it should work for you now.


add seed + autoupdate duration

Added seed (by default 0, which randomizes the seed every time)
Duration maximum value gets auto-updated whenever you switch between 768p and 384p (31 and 16, respectively). Note that the default value is always set to 16 since the 31 frame option might require too much resources for certain machines while 16 works fine.

Here's what it looks like:

Thank you for the commit!


Can the left and right page slide handoff function be provided？

RT

Do you mean switch tab using swipe?

@sjvc yeah

This project is a hobby, so I don't have enough free time to add all your requests. But, as this project is open source, anyone can add their own features.


adding title and body

This will address #1 by exposing the body and title specification for the post.

Awesome, thank you :)

okay, merging! Give it a try, and let me know if it works for you.

I will as soon as I found out how to push to a repo from a github action :)

Hmm, I'm not sure I would be okay doing that (why I did a PR, so it can be reviewed first), but I don't understand your use case entirely! Either way, here is a good place for inspiration and learning :point_right:  https://github.com/sdras/awesome-actions

Yeah I've seen that list :)
My use case is that I want to generate a release branch from my commits, following the semantic release approach. According to the docs (and a couple actions) it should be possible but it isn't. Seems to be a bug, though...

You can just create an action that fires on pushes to master, and then makes a commit to your release branch. If you are having a hard time with actions, this is fairly straight forward to trigger with standard CI like CircleCI.

Yeah getting it to start is not the issue. Getting it to push to the remote branch without freaking out about the workflow file is the issue :)
https://github.com/JonasJurczok/semantic-release-kotlin/runs/81626425

Read the error message closely:
 ! [remote rejected] prepare-release -> prepare-release (refusing to allow an integration to create .github/main.workflow)

You aren't allowed to create a new github action (the main.workflow file) so just try removing that from the branch you are going to push first.

Yeah but.. I have no changes there.
And if I remove the file I cannot really merge the branch back without removing the workflows itself :)

That's the rule, and it's a good one at that - imagine if someone could pro grammatically spawn off new workflows? That's a huge security risk.
If your branch is a release, you don't need to have the GitHub actions file there. You shouldn't need to merge the release branch back to master either, if you are doing this possibly rethink your workflow. The release branch doesn't need to run actions. If this is a deal breaker for you, then you need to use a different CI.

I totally understand that this is a security risk.
My point is that I'm not modifying the file. It is exactly the same as in the master branch.
And I need to merge it back because I change version information in my pom.xml (java maven project). Not having that in the checked out code makes development so much harder.

If you don't agree with the functionality, you should take it up with GitHub. Good luck!

Note that you aren't just pushing a file already there, you are creating a new branch. One workaround could be to create the branch (a fork of the main one) first, and then the file truly won't be updated and maybe the push would work.


Radix4transpose

This PR replaces the existing radix4 shuffler with a much faster one. This is used in both scalar and sse versions.
With this shuffler, there is no need to use mixer radix for long ffts, since radix4 is now the fastest also there.

Some benchmarks:
 name                           ssemaster.txt ns/iter  shuffle3.txt ns/iter  diff ns/iter   diff %  speedup
 comparison_1024_f32_avx        3,516                  3,554                           38    1.08%   x 0.99
 comparison_1024_f32_scalar     11,863                 11,444                        -419   -3.53%   x 1.04
 comparison_1024_f32_sse        4,748                  4,329                         -419   -8.82%   x 1.10
 comparison_1024_f64_avx        6,694                  6,705                           11    0.16%   x 1.00
 comparison_1024_f64_scalar     12,907                 11,598                      -1,309  -10.14%   x 1.11
 comparison_1024_f64_sse        7,098                  6,597                         -501   -7.06%   x 1.08
 comparison_1048576_f32_avx     10,522,391             10,443,218                 -79,173   -0.75%   x 1.01
 comparison_1048576_f32_scalar  38,279,344             28,881,287              -9,398,057  -24.55%   x 1.33
 comparison_1048576_f32_sse     22,898,489             15,517,580              -7,380,909  -32.23%   x 1.48
 comparison_1048576_f64_avx     21,338,388             21,540,819                 202,431    0.95%   x 0.99
 comparison_1048576_f64_scalar  46,383,935             33,824,908             -12,559,027  -27.08%   x 1.37
 comparison_1048576_f64_sse     35,616,363             26,804,115              -8,812,248  -24.74%   x 1.33
 comparison_128_f32_avx         264                    265                              1    0.38%   x 1.00
 comparison_128_f32_scalar      1,019                  952                            -67   -6.58%   x 1.07
 comparison_128_f32_sse         483                    435                            -48   -9.94%   x 1.11
 comparison_128_f64_avx         497                    497                              0    0.00%   x 1.00
 comparison_128_f64_scalar      1,026                  924                           -102   -9.94%   x 1.11
 comparison_128_f64_sse         677                    619                            -58   -8.57%   x 1.09
 comparison_131072_f32_avx      872,902                867,899                     -5,003   -0.57%   x 1.01
 comparison_131072_f32_scalar   3,262,661              2,454,181                 -808,480  -24.78%   x 1.33
 comparison_131072_f32_sse      1,759,649              1,000,127                 -759,522  -43.16%   x 1.76
 comparison_131072_f64_avx      1,870,426              1,850,530                  -19,896   -1.06%   x 1.01
 comparison_131072_f64_scalar   4,149,141              2,591,379               -1,557,762  -37.54%   x 1.60
 comparison_131072_f64_sse      3,056,976              1,900,025               -1,156,951  -37.85%   x 1.61
 comparison_16384_f32_avx       84,024                 84,428                         404    0.48%   x 1.00
 comparison_16384_f32_scalar    285,802                272,488                    -13,314   -4.66%   x 1.05
 comparison_16384_f32_sse       124,170                105,655                    -18,515  -14.91%   x 1.18
 comparison_16384_f64_avx       162,794                162,441                       -353   -0.22%   x 1.00
 comparison_16384_f64_scalar    321,184                270,310                    -50,874  -15.84%   x 1.19
 comparison_16384_f64_sse       218,459                162,794                    -55,665  -25.48%   x 1.34
 comparison_16_f32_avx          28                     28                               0    0.00%   x 1.00
 comparison_16_f32_scalar       64                     64                               0    0.00%   x 1.00
 comparison_16_f32_sse          28                     28                               0    0.00%   x 1.00
 comparison_16_f64_avx          40                     40                               0    0.00%   x 1.00
 comparison_16_f64_scalar       73                     73                               0    0.00%   x 1.00
 comparison_16_f64_sse          35                     35                               0    0.00%   x 1.00
 comparison_2048_f32_avx        7,661                  7,657                           -4   -0.05%   x 1.00
 comparison_2048_f32_scalar     24,920                 23,314                      -1,606   -6.44%   x 1.07
 comparison_2048_f32_sse        10,073                 9,475                         -598   -5.94%   x 1.06
 comparison_2048_f64_avx        14,772                 14,728                         -44   -0.30%   x 1.00
 comparison_2048_f64_scalar     24,601                 22,899                      -1,702   -6.92%   x 1.07
 comparison_2048_f64_sse        16,355                 15,184                      -1,171   -7.16%   x 1.08
 comparison_2097152_f32_avx     22,609,778             22,664,408                  54,630    0.24%   x 1.00
 comparison_2097152_f32_scalar  73,162,331             59,709,194             -13,453,137  -18.39%   x 1.23
 comparison_2097152_f32_sse     41,557,387             30,963,549             -10,593,838  -25.49%   x 1.34
 comparison_2097152_f64_avx     45,138,272             45,913,447                 775,175    1.72%   x 0.98
 comparison_2097152_f64_scalar  90,659,091             68,996,011             -21,663,080  -23.90%   x 1.31
 comparison_2097152_f64_sse     69,575,004             54,153,014             -15,421,990  -22.17%   x 1.28
 comparison_256_f32_avx         610                    609                             -1   -0.16%   x 1.00
 comparison_256_f32_scalar      2,433                  2,374                          -59   -2.42%   x 1.02
 comparison_256_f32_sse         1,012                  925                            -87   -8.60%   x 1.09
 comparison_256_f64_avx         1,145                  1,143                           -2   -0.17%   x 1.00
 comparison_256_f64_scalar      2,548                  2,431                         -117   -4.59%   x 1.05
 comparison_256_f64_sse         1,486                  1,333                         -153  -10.30%   x 1.11
 comparison_262144_f32_avx      2,042,095              2,029,662                  -12,433   -0.61%   x 1.01
 comparison_262144_f32_scalar   7,451,675              5,711,926               -1,739,749  -23.35%   x 1.30
 comparison_262144_f32_sse      4,346,880              2,396,249               -1,950,631  -44.87%   x 1.81
 comparison_262144_f64_avx      4,421,528              4,370,191                  -51,337   -1.16%   x 1.01
 comparison_262144_f64_scalar   9,873,397              6,621,145               -3,252,252  -32.94%   x 1.49
 comparison_262144_f64_sse      7,666,797              4,808,513               -2,858,284  -37.28%   x 1.59
 comparison_32768_f32_avx       183,781                183,455                       -326   -0.18%   x 1.00
 comparison_32768_f32_scalar    625,570                531,540                    -94,030  -15.03%   x 1.18
 comparison_32768_f32_sse       312,205                216,104                    -96,101  -30.78%   x 1.44
 comparison_32768_f64_avx       351,878                349,048                     -2,830   -0.80%   x 1.01
 comparison_32768_f64_scalar    648,500                520,147                   -128,353  -19.79%   x 1.25
 comparison_32768_f64_sse       520,322                349,817                   -170,505  -32.77%   x 1.49
 comparison_32_f32_avx          49                     49                               0    0.00%   x 1.00
 comparison_32_f32_scalar       203                    210                              7    3.45%   x 0.97
 comparison_32_f32_sse          62                     61                              -1   -1.61%   x 1.02
 comparison_32_f64_avx          86                     86                               0    0.00%   x 1.00
 comparison_32_f64_scalar       253                    248                             -5   -1.98%   x 1.02
 comparison_32_f64_sse          87                     86                              -1   -1.15%   x 1.01
 comparison_4096_f32_avx        17,130                 17,131                           1    0.01%   x 1.00
 comparison_4096_f32_scalar     57,099                 55,497                      -1,602   -2.81%   x 1.03
 comparison_4096_f32_sse        22,677                 20,953                      -1,724   -7.60%   x 1.08
 comparison_4096_f64_avx        32,276                 32,423                         147    0.46%   x 1.00
 comparison_4096_f64_scalar     61,171                 57,162                      -4,009   -6.55%   x 1.07
 comparison_4096_f64_sse        38,601                 33,220                      -5,381  -13.94%   x 1.16
 comparison_4194304_f32_avx     50,147,302             49,896,337                -250,965   -0.50%   x 1.01
 comparison_4194304_f32_scalar  149,265,311            122,997,725            -26,267,586  -17.60%   x 1.21
 comparison_4194304_f32_sse     84,047,146             66,723,913             -17,323,233  -20.61%   x 1.26
 comparison_4194304_f64_avx     97,944,284             97,464,023                -480,261   -0.49%   x 1.00
 comparison_4194304_f64_scalar  181,137,523            145,911,273            -35,226,250  -19.45%   x 1.24
 comparison_4194304_f64_sse     139,186,231            117,722,424            -21,463,807  -15.42%   x 1.18
 comparison_512_f32_avx         1,427                  1,433                            6    0.42%   x 1.00
 comparison_512_f32_scalar      5,146                  4,791                         -355   -6.90%   x 1.07
 comparison_512_f32_sse         2,151                  2,014                         -137   -6.37%   x 1.07
 comparison_512_f64_avx         2,644                  2,643                           -1   -0.04%   x 1.00
 comparison_512_f64_scalar      5,045                  4,613                         -432   -8.56%   x 1.09
 comparison_512_f64_sse         3,297                  3,038                         -259   -7.86%   x 1.09
 comparison_524288_f32_avx      5,024,911              4,931,672                  -93,239   -1.86%   x 1.02
 comparison_524288_f32_scalar   17,650,125             12,551,145              -5,098,980  -28.89%   x 1.41
 comparison_524288_f32_sse      10,323,094             5,992,939               -4,330,155  -41.95%   x 1.72
 comparison_524288_f64_avx      9,876,186              9,842,582                  -33,604   -0.34%   x 1.00
 comparison_524288_f64_scalar   22,213,054             15,443,078              -6,769,976  -30.48%   x 1.44
 comparison_524288_f64_sse      17,052,260             12,672,885              -4,379,375  -25.68%   x 1.35
 comparison_64_f32_avx          111                    111                              0    0.00%   x 1.00
 comparison_64_f32_scalar       500                    476                            -24   -4.80%   x 1.05
 comparison_64_f32_sse          216                    203                            -13   -6.02%   x 1.06
 comparison_64_f64_avx          215                    214                             -1   -0.47%   x 1.00
 comparison_64_f64_scalar       545                    505                            -40   -7.34%   x 1.08
 comparison_64_f64_sse          324                    270                            -54  -16.67%   x 1.20
 comparison_65536_f32_avx       407,134                405,538                     -1,596   -0.39%   x 1.00
 comparison_65536_f32_scalar    1,559,862              1,215,512                 -344,350  -22.08%   x 1.28
 comparison_65536_f32_sse       804,025                469,507                   -334,518  -41.61%   x 1.71
 comparison_65536_f64_avx       805,536                797,754                     -7,782   -0.97%   x 1.01
 comparison_65536_f64_scalar    1,580,538              1,225,158                 -355,380  -22.48%   x 1.29
 comparison_65536_f64_sse       1,107,748              769,153                   -338,595  -30.57%   x 1.44
 comparison_8192_f32_avx        39,312                 39,305                          -7   -0.02%   x 1.00
 comparison_8192_f32_scalar     119,185                113,274                     -5,911   -4.96%   x 1.05
 comparison_8192_f32_sse        55,407                 45,401                     -10,006  -18.06%   x 1.22
 comparison_8192_f64_avx        75,821                 75,730                         -91   -0.12%   x 1.00
 comparison_8192_f64_scalar     118,454                109,677                     -8,777   -7.41%   x 1.08
 comparison_8192_f64_sse        91,694                 73,250                     -18,444  -20.11%   x 1.25

Comparison to the current recursive shuffler:

I love how much code this deletes, and I think the average reader will be able to understand "a transpose with some unusual quirks about the column indexes" much better than "journey into the depths of recursion".

I wonder if AVX could use something like this. How hard do you think it owuld be to make a version of this that does its column reversals as a gather-oriented, instead of as a scatter? The reason I ask is because AVX literally has a gather instruction, but not a scatter. If this could be reoriented to gather instead of scatter, we could adapt a version of this for AVX.
I wonder if an Radix8 version of this new algorithm performs well? I tried radix8 with the recursive version and wasn't satisfied with it, but maybe this will do the trick.
We don't have to address any of this in this PR, I'm just writing out the ideas this is giving me.

Don't know if this would give any benefit in the avx code, but I'll think about it and take a look!
Radix8 could be very interesting. It wouldn't take very long to write one to test.

Nevermind, after looking at the code a little more thoroughly, this is already gather-oriented


Add all-contributors

@all-contributors add @AnandChowdhary for code, docs, design

@all-contributors add @reallinfo for design


Validate that headers contain legal bytes

Fixes #554

This looks good to me. I guess I get to wait for Travis to pass though.
...
...
...
It still isn't done...
(I did tell Nico that I was impressed y'all got your build down to 25 minutes.)


Random nulls on aliased innerJoin

I have this stream:
    final monsterStatsNormal = alias(db.monsterStats, 'monster_stats_normal');
    final monsterStatsElite = alias(db.monsterStats, 'monster_stats_elite');
    return select(activeMonster).join(
      [
        innerJoin(db.monster, db.monster.id.equalsExp(activeMonster.id)),
        innerJoin(monsterStatsNormal, and(and(
          monsterStatsNormal.monsterId.equalsExp(db.monster.id),
          monsterStatsNormal.scenarioLevelId.equalsExp(activeMonster.scenarioLevelId)),
          monsterStatsNormal.type.equals('normal'),
        )),
        innerJoin(monsterStatsElite, and(and(
          monsterStatsElite.monsterId.equalsExp(db.monster.id),
          monsterStatsElite.scenarioLevelId.equalsExp(activeMonster.scenarioLevelId)),
          monsterStatsElite.type.equals('elite'),
        )),
      ]
    ).watch().map((rows) {
      return rows.map((row) {
        row.rawData.data.forEach((key, value) {
          print('$key: $value');
        });
        return ActiveMonsterInfo(
          row.readTable(activeMonster),
          row.readTable(db.monster),
          row.readTable(monsterStatsNormal),
          row.readTable(monsterStatsElite),
        );
      }).toList();
    });

The row.readTable(monsterStatsNormal) and row.readTable(monsterStatsElite) will randomly return a null value.
However
        row.rawData.data.forEach((key, value) {
          print('$key: $value');
        });

will print out all columns correctly.
Its actually not that random. 1st time I press hot reload i'll get data, 2nd time null, 3rd time data etc

Ha, this one was interesting, thanks for the report! All the tables are mapped correctly, this is due to how moor caches streams. The rows instance will survive hot reloads as the last query is still cached, but the alias method creates a new table every time, so we can't get the old instance.
Fixed by making tables override hashCode and equals, this will be part of 1.6 which will be released soon.
I couldn't reproduce the effect that it works every second time - I think this was another minor bug that will also be fixed in 1.6

Just gave it a test and its working! Thanks

@simolus3 I can create another issue for this but seems related. My app is watching a couple of streams (both single and multi) and it works great, but when I do a hot reload, any db updates don't get propagated to the streams. When I do a 2nd hot reload it starts working again.

Just to be sure - is this still happening when on the beta branch? Can you try to put
dependency_overrides:
  moor:
    git:
      url: https://github.com/simolus3/moor.git
      ref: beta
      path: moor/

in your pubspec, run flutter packages upgrade and then flutter clean?

Yep.
moor:
    dependency: "direct overridden"
    description:
      path: "moor/"
      ref: beta
      resolved-ref: f0e5ed9a8785d174c86adf51481a99f06f406f2d
      url: "https://github.com/simolus3/moor.git"
    source: git
    version: "1.5.1+1"

Steps:

I'm watching a list.
Update an item in the list
It updates
Hot reload
Update an item in the list
Doesn't update
Hot reload
Item updates

Not sure if this is helpful, but I ran into similar issues with my custom sqflite/stream cache implementation when the stream was removed from the cache while inert listeners were still holding a reference to it. Something like:
var stream = getMyQueryStream();
var stream2 = getMyQueryStream();
await stream.first; // listens and cancels - stream is now removed from cache and won't receive updates
stream2.listen(...) // will never receive updates

I solved it with something like this

@Mike278 Thanks! I forked this and merged the latest changes and it works great

Good idea @Mike278, I've went for a very similar approach to fix this in moor at 3407c8e90ee98e0f05e44a572250391c045363e6


Allow text inscriptions on homepage

The homepage doesn't show text inscriptions because we didn't have a good looking preview card. We should figure out how to make a nice preview card with text and allow them on the homepage again.

#1058


cannot have folder statistics after upgrade ! (worked fine before  ..)

Preflight Checklist

[X] I have installed the latest version of Storage Explorer.
[X] I have checked existing resources, including the troubleshooting guide and the release notes.
[X] I have searched for similar issues.

Storage Explorer Version
1.31.2
Regression From
1.26.1
Architecture
i86
Storage Explorer Build Number
94
Platform
All
OS Version
Windows 2019 Version 1809 OS BUIld 17763.4974
Bug Description
After successfull connection to  a storage account ( we can browse )
The usage of the folder Statistics button on a Blob containers lead to an error
Strangely it was working fine and a message made me aware that there was a new version after upgrading I get the error doinf the same thing..
Also the previous version was 32 bits on x64 architecture  .. the new one is  both  64 bits ..
Steps to Reproduce

Expand the storage account -> Blob Containers.
Open a blob container -> Click 'Folder Statistics' on the toolbar.
Check whether there is a successful activity log.

Actual Experience
it runs for seconds withoud doing anything and finish with the following error
Failed to inspect '', error: {
"name": "RestError",
"message": "Value for one of the query parameters specified in the request URI is invalid.\nRequestId:184263be-501e-003b-5c5c-077488000000\nTime:2023-10-25T15:59:06.9262458Z",
"stack": "RestError: Value for one of the query parameters specified in the request URI is invalid.\nRequestId:184263be-501e-003b-5c5c-077488000000\nTime:2023-10-25T15:59:06.9262458Z\n    at handleErrorResponse (C:\Program Files\Microsoft Azure Storage Explorer\resources\app\node_modules\@storage-explorer\blob-extension\dist\src\index.js:2:412653)\n    at C:\Program Files\Microsoft Azure Storage Explorer\resources\app\node_modules\@storage-explorer\blob-extension\dist\src\index.js:2:413337\n    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)\n    at async StorageRetryPolicy.attemptSendRequest (C:\Program Files\Microsoft Azure Storage Explorer\resources\app\node_modules\@storage-explorer\blob-extension\dist\src\index.js:2:1076967)\n    at async BlobApiVersionRequestPolicy.sendRequest (C:\Program Files\Microsoft Azure Storage Explorer\resources\app\node_modules\@storage-explorer\blob-extension\dist\src\index.js:2:70658)\n    at async StorageClientContext.sendOperationRequest (C:\Program Files\Microsoft Azure Storage Explorer\resources\app\node_modules\@storage-explorer\blob-extension\dist\src\index.js:2:451439)\n    at async ContainerClient.listBlobFlatSegment (C:\Program Files\Microsoft Azure Storage Explorer\resources\app\node_modules\@storage-explorer\blob-extension\dist\src\index.js:2:1223099)",
"code": "InvalidQueryParameterValue",
"statusCode": 400,
"request": {
"streamResponseStatusCodes": {},
"url": "https://stnnprdsap1opentextacrw.blob.core.windows.net/sap-a3?comp=list&maxresults=25&restype=container&include=deleted,metadata,snapshots",
"method": "GET",
"headers": {
"_headersMap": {
"x-ms-version": {
"name": "x-ms-version",
"value": "2017-04-17"
},
"accept": {
"name": "Accept",
"value": "application/xml"
},
"user-agent": {
"name": "User-Agent",
"value": "Microsoft Azure Storage Explorer/1.31.2 (win32) azsdk-js-storageblob/12.12.0 (NODE-VERSION v18.15.0; Windows_NT 10.0.17763)"
Expected Experience
successfull activty log :-)
Additional Context
No response

@denistarkett Did you enable targeting Azure Stack? In the error log the API version is 2017-04-17. If so, could you please disable it? The latest Storage Explorer targets a much more recent API version and sends HTTP headers not supported in the old API version.

ok , I just click on the submenu "Edit" , change "Target Azure Stack APIs" , it changes something ( not clearly explained) and ask to restart and then it works again .. so in a way thanks ! :-)
I'm not sure if it is the button to enable/disable .. ( not visible either way )


Code sample error

There is an error in the AZ CLI code sample. See current code sample screenshot below.

The 'create' command is missing, a \ after the resource group name is missing.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 677a101b-1c07-ae9e-51bb-77b751c07cd2
Version Independent ID: 21660968-dbbb-39bd-4ee2-0300640a24e8
Content: Configure immutability policies for containers - Azure Storage
Content Source: articles/storage/blobs/immutable-policy-configure-container-scope.md
Service: storage
Sub-service: blobs
GitHub Login: @tamram
Microsoft Alias: tamram

Thanks for reporting this. I have created a PR to fix this and the changes should go live later today.


CFP: Exclude k8s check from health probe result

Cilium Feature Proposal
Thanks for taking time to make a feature proposal for Cilium! If you have usage questions, please try the slack channel and see the FAQ first.
Is your proposed feature related to a problem?
Our clusters are very big, i.e. 5k nodes, 100k pods. cilium agents introduce very heavy traffic to api server for listing service, endpoints, identities, etc.  Our API server has configured flow schema to restrict request from cilium agent.
So sometimes the requests from cilium agent are blocked, most of the time it should not be a problem, the controller will retry.  However the health check will be blocked as well, and if the failed health check exceed the threshold, liveness probe will kill the container.  Then the cilium agent enter the much heavier initialization phase which need relist lots of resources,  and takes other cilium agent down.  Finally it triggers a cascade failure and majority of the cilium agents will down.
Describe the feature you'd like
So we want to have the option to exclude the k8s check from liveness probe.
(Optional) Describe your proposed solution

add a new option ExcludeK8sFromHealthProbeResult, default false to keep the same behavior as before.
when ExcludeK8sFromHealthProbeResult is set true and k8s health check fail,  cilium status will show k8s not available, but cilium status --brief still show OK so liveness probe will not kill the container.

Hi, @minosniugang Can we solve the problem by adjusting parameters related to livenessProbe, such as timeoutSeconds?

this is the workaround we do today, but it will hide other problems which may be more critical

@minosniugang this seems a more specific use case of https://github.com/cilium/cilium/issues/25288, would you like to give a go for https://github.com/cilium/cilium/issues/25288?

25288  is asking improvement in kvstore health check, not related to this one.
One idea you suggest there is to allow user customize the health check scope through url parameters.  So we need identify the list of sub-systems that user can use in include / exclude. The challenge is the sub-system list is dynamic and rely on configurations.  In status code today we only check the enabled sub-system, but if user can define the sub-system explicitly in health check monitor, how to handle the conflict with configuration gracefully? e.g. if user use kvstore, not k8s crd. Then the health check include k8s, what should we do?