Fix for loader in clr-button   Issue #1681

Signed-off-by: Govinda Alwani<EMAIL_ADDRESS>

@govi2010: This I believe is the one of the right approaches to solve the spinner issue. Could you please add unit tests and then we can review this PR? Please refer to loading-button.spec.ts https://github.com/vmware/clarity/blob/master/src/clarity-angular/button/button-loading/loading-button.spec.ts for more details. Also you need to run npm run clang:format & npm run tslint:fix before submitting a PR to make sure the code is formatted correctly.
Thanks for the contribution!

Ok I will update code by morning
On Nov 13, 2017 9:50 PM, "Aditya Bhandari"<EMAIL_ADDRESS>wrote:

@govi2010 https://github.com/govi2010: This I believe is the one of the
right approaches to solve the spinner issue. Could you please add unit
tests and then we can review this PR? Please refer to
loading-button.spec.ts https://github.com/vmware/clarity/blob/master/src/
clarity-angular/button/button-loading/loading-button.spec.ts for more
details. Also you need to run npm run clang:format & npm run tslint:fix
before submitting a PR to make sure the code is formatted correctly.
Thanks for the contribution!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/vmware/clarity/pull/1685#issuecomment-343971894, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AIXpX1z8RiOHqgI_QVMApLleM5eU1_4uks5s2GxZgaJpZM4QZuzw
.

@adityarb88  I have update code. But i don't understand why this is failing. Also i don't know testing framework or how to write it.

@adityarb88 do you need anything on this?

Your tests fail because there is a problem with the directives exported by ClrButtonGroupModule. One of them appears to be undefined. You should investigate this to fix the unit tests, when it's fixed I think this PR will be good to go.

Closing this PR because it hasn't been updated and the tests are failing. Duplicate PR which fixes the tests here: #2022
Thanks for the contribution @govi2010

@adityarb88  Sorry, I couldn't get time to work on this. Thanks for completing those test. I really don't know about writing test files.


Update x-bind-markup-extension.md

This change is to add a missing apostrophe required in the word it's.

@rjpond : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@rjpond Thanks for submitting this typo fix.


[Snyk] Upgrade i18next from 22.4.15 to 22.5.1

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade i18next from 22.4.15 to 22.5.1.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 2 versions ahead of your current version.
The recommended version was released 25 days ago, on 2023-06-06.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Address in #129


patch 1

workflows

rename main to ci
add CodeQL workflow.

chore

fix jest imports (available global)

deps

bump to latest
add @types/jest instead of @jest/globals

warning
1 issue was detected with this workflow: Please specify an on.push hook so that Code Scanning can compare pull requests against the state of the base branch.


[WFLY-11406] Use new ClassFactory API to fix JDK12 issues.

https://issues.jboss.org/browse/WFLY-11406

Please review @bstansberry

This is not sufficient proposal pull request. It needs to be reworked.

@ropalka I believe a new jboss-invocation minor is necessary. Ability to pass the a ClassFactory impl into the ProxyFactory. I suppose via ProxyConfiguration.
I say minor because that's an API change.


incremental checkin for ios Guide

There was an error while validating job 29954bdd-c511-4f5d-9074-754244f9050f Message:
Result status: Failed
There was a problem accessing Github repository 'https://github.com/Microsoft/cordova-docs.git'.
Details:Microsoft.LightweightJobEngine.Core.Language.ContextCommandBase+ContextCommandException:
Result status: Failed
There was a problem accessing Github repository 'https://github.com/Microsoft/cordova-docs.git'.
---> System.AggregateException: One or more errors occurred. ---> System.ArgumentException: Error clonning repository ---> LibGit2Sharp.NotFoundException: Branch 244 not found. Available branches: origin/master
at Microsoft.DPS.Services.LibGit2SharpSourceControlProvider.GetBranch(Repository repo, String name)
at Microsoft.DPS.Services.LibGit2SharpSourceControlProvider.<>c__DisplayClass30.<>c__DisplayClass34.b__29(KeyValuePair2 branch)    at System.Collections.Generic.List1.ForEach(Action1 action)    at Microsoft.DPS.Services.LibGit2SharpSourceControlProvider.<>c__DisplayClass30.<CloneRepository>b__28()    at Microsoft.Practices.EnterpriseLibrary.TransientFaultHandling.RetryPolicy.<>c__DisplayClass1.<ExecuteAction>b__0()    at Microsoft.Practices.EnterpriseLibrary.TransientFaultHandling.RetryPolicy.ExecuteAction[TResult](Func1 func)
at Microsoft.Practices.EnterpriseLibrary.TransientFaultHandling.RetryPolicy.ExecuteAction(Action action)
at Microsoft.DPS.Services.LibGit2SharpSourceControlProvider.CloneRepository(String url, IDictionary2 branches)    --- End of inner exception stack trace ---    at Microsoft.DPS.Services.LibGit2SharpSourceControlProvider.CloneRepository(String url, IDictionary2 branches)
at Microsoft.DPS.Services.LibGit2SharpSourceControlProvider.CloneRepository()
at Microsoft.DPS.Services.LibGit2SharpSourceControlProvider.GetVersionAsync(String path)
at Microsoft.DPS.Commands.IdentifyDocumentsToPublish.CheckExternalServicesCommand.Do(IDictionary2 context)    --- End of inner exception stack trace ---    --- End of inner exception stack trace ---    at Microsoft.LightweightJobEngine.Core.Language.ContextCommandBase.ThrowIfErrorsLogged()    at Microsoft.DPS.Commands.IdentifyDocumentsToPublish.CheckExternalServicesCommand.Do(IDictionary2 context)
at Microsoft.LightweightJobEngine.Core.Language.JobWorkflow1.RunCommands(Guid jobId, IDictionary2 context, CancellationTokenSource cancelSignal)


Remove limitations people don't like

Thinks like:

machines/items needing power to work
crafting recipes using items that are hard to get
enchanting costing levels
magnet needing to be in special slots
...

...


Don't include server_devel_repo in proxy vm

What does this PR change?
Recently we experience issues onboarding our Proxy in 4.2.
It seems related to this salt state https://github.com/SUSE/spacewalk/blob/Manager-4.2/susemanager-utils/susemanager-sls/salt/packages/init.sls#L2-L10 and having the server_devel_repo as repository in the proxy.
By removing this repo, the apply states works and this error is not shown anymore:
2021-09-27T11:45:47.638637+00:00 localhost systemd[1]: Started /usr/bin/zypper --non-interactive --no-refresh install --auto-agree-with-licenses --name sle-module-suse-manager-retail-branch-server-release sle-module-suse-manager-server-release.
2021-09-27T11:45:48.340157+00:00 localhost salt-minion[25376]: [ERROR   ] Command 'systemd-run' failed with return code: 4
2021-09-27T11:45:48.340354+00:00 localhost salt-minion[25376]: [ERROR   ] stdout: Loading repository data...
2021-09-27T11:45:48.340413+00:00 localhost salt-minion[25376]: Reading installed packages...
2021-09-27T11:45:48.340461+00:00 localhost salt-minion[25376]: Resolving package dependencies...
2021-09-27T11:45:48.340516+00:00 localhost salt-minion[25376]: 2 Problems:
2021-09-27T11:45:48.340586+00:00 localhost salt-minion[25376]: Problem: nothing provides 'product(sle-module-web-scripting) >= 15.3' needed by the to be installed product:sle-module-suse-manager-server-4.2-0.x86_64
2021-09-27T11:45:48.340705+00:00 localhost salt-minion[25376]: message repeated 2 times: [ Problem: nothing provides 'product(sle-module-web-scripting) >= 15.3' needed by the to be installed product:sle-module-suse-manager-server-4.2-0.x86_64]
2021-09-27T11:45:48.340749+00:00 localhost salt-minion[25376]:  Solution 1: do not install product:sle-module-suse-manager-server-4.2-0.x86_64
2021-09-27T11:45:48.340793+00:00 localhost salt-minion[25376]:  Solution 2: break sle-module-suse-manager-server-release-4.2-420.8.7.develHead.x86_64 by ignoring some of its dependencies

I'm not at all convinced of removing this repository, as we are not sure about other necessary packages inside this repository.
I would like the approval from @mcalmer to follow this approach and give an attempt to that solution.
For now, I will make a run using this branch.

https://ci.suse.de/view/Manager/view/Manager-4.2/job/manager-4.2-dev-acceptance-tests-PRV/514/

That's just the pool where all packages are building, common for proxy and server.

@juliogonzalez What do you mean by common for proxy and server? I only touch the file salt/repos/proxy.sls this is also used for the server at some point? :thinking:

@juliogonzalez What do you mean by common for proxy and server? I only touch the file salt/repos/proxy.sls this is also used for the server at some point? thinking

Talk to @mcalmer again, he was explaining it at Slack.
See also https://github.com/SUSE/spacewalk/wiki/OBS-repositories-and-packages,-and-more#projects-contents and https://github.com/SUSE/spacewalk/wiki/OBS-repositories-and-packages,-and-more#repository-examples

@juliogonzalez @mcalmer hmmm I think we could have a hidden problem if we define twice the same repos, as we do in the example lines I shared, but if you are very confident with this, then just omit my question :D

Didn't follow the conversation on Slack, so as I said, I not approving or asking for changes for the PR, as I am lacking context. But seems you were tracking this with @mcalmer, so if he approves, that should be enough.

I created an issue in sumaform https://github.com/uyuni-project/sumaform/issues/959 to solve my question here. Which is related to my changes here, but not related with the reason why I proposed those changes.

I changed proxy.sls to use the devel repos specific for "proxy" and not the global devel repo which hold all packages for Server, Proxy and RTBS in one repo. That repo create the mess as it also include the server and rtbs products.

Why the proxy tries to install the server product?

Why the proxy tries to install the server product?

Because it is available. We have a SUMA state which install all available products. This is required for subscription matching.
Otherwise users can add a channel and only install the software, but not the product. This would lead into wrong results as we match against products.

Btw. it worked, as the test run brought us one step forward. I would merge it.

I will merge this and we can move to the next failure

The title is still wrong, as s/Devel:/Galaxy:/Manager:/X.Y/SLE_15_SPX/ is not a server repo, as I told above, but @meaksh just found one reason for having it: salt
Salt is NOT part of the images generated by the product definition, as it should come from SLE. So the way of making it available for server and proxy was adding that repository.

In other words: without this repository, the proxy (and maybe the server) are not testing the package will be submitting as part of the next MU (and I think it happens the same with other packages such as node_exporter, basically for all packages that are part of SLE and not SUSE Manager)

In other words: without this repository, the proxy (and maybe the server) are not testing the package will be submitting as part of the next MU (and I think it happens the same with other packages such as node_exporter, basically for all packages that are part of SLE and not SUSE Manager)

As I said in the description, and several times in the chats... "I'm not at all convinced of removing this repository, as we are not sure about other necessary packages inside this repository." :)
But I will let @mcalmer continue with this discussion, see if you guys solve it, and I will go back to my cave to my other refactors ;)


Adds JavaDoc and Doxygen docs

JavaDocs are now grabbed from the documentation repo instead of wpilib, and cpp is added for the first time.

How is this actually presented to the user? How can the see them?

The hovers in eclipse read from the javadocs one for Java. C++ doesn't have anything yet, but I'm going to add a button to eclipse as a separate pr. For now you can manually navigate to it and open the HTML file


Fix: Unordered Track Models are constrained to those linked to the TransactionQueryset

TP-1082 Unordered Track Models are constrained to those linked to the TransactionQueryset
Why
At the moment common.models.transactions.TransactionQueryset.unordered_tracked_model returns any and all models in the database.
This is unintended and the filter condition transaction__in=self applied later in ordered_tracked_model should be moved to this method instead.
What
Move the  filter condition transaction__in=self to the unordered method

Codecov Report

Merging #438 (f52a12b) into master (cdac3f8) will not change coverage.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##           master     #438   +/-   ##
=======================================
  Coverage   91.92%   91.92%
=======================================
  Files         283      283
  Lines       17105    17105
  Branches     1396     1396
=======================================
  Hits        15723    15723
  Misses       1118     1118
  Partials      264      264

Impacted Files
Coverage Δ

common/models/transactions.py
87.25% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdac3f8...f52a12b. Read the comment docs.

👍
Ideally should have a test, OTOH I should have written it in the first place 😬

oh yes i'll add it now actually before merge!


Add avro error when sending avro records failed

Purpose

Returning a ProducerError when sending avro records fails due to AvroRuntimeException.

Fixes #21964
Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #21966 into stage will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            stage   #21966   +/-   ##
=======================================
  Coverage   14.59%   14.59%
=======================================
  Files          51       51
  Lines        1411     1411
  Branches      219      219
=======================================
  Hits          206      206
  Misses       1189     1189
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 102275b...25fd625. Read the comment docs.


fix: Adjsut new My Collection event owner type

Description
Adjsut new My Collection event owner type.

:rocket: PR was released in v4.91.0 :rocket:


Unable to login and acquireTokenSilent for Microsoft Personal Accounts with ARM Scope

Core Library
MSAL.js v2 (@azure/msal-browser)
Core Library Version
2.14.2
Wrapper Library
MSAL React (@azure/msal-react)
Wrapper Library Version
1.0.0
Description
Login or acquireTokenSilent using Microsoft Personal Account with ARM scope is failing with error "invalid_scope", the same request is working fine with organization accounts.
The login URL is "https://login.microsoftonline.com/common/".
Error Message
error=invalid_scope&
error_description=The+provided+value+for+the+input+parameter+'scope'+is+not+valid.+The+scope+
'User.Read+Application.Read.All+User.ReadBasic.All+https://management.core.windows.net/user_impersonation+openid+profile+offline_access'+
does+not+exist
Msal Logs
No response
MSAL Configuration
{
    auth: {
      clientId: "clientId",
      authority: "https://login.microsoftonline.com/common/",
      redirectUri: window.location.origin,
      postLogoutRedirectUri: window.location.origin,
    },
    cache: {
        cacheLocation: "sessionStorage",
        storeAuthStateInCookie: isIE || isEdge || isFirefox
    }
}

Relevant Code Snippets
const loginRequest = {
    scopes: ["User.Read", "Application.Read.All", "User.ReadBasic.All"],
    extraScopesToConsent: ["https://management.core.windows.net/user_impersonation"],
    extraQueryParameters: getQueryParamsDict()
};

this.context.instance.loginRedirect({...loginRequest, prompt: "select_account"})

Reproduction Steps
const loginRequest = {
scopes: ["User.Read", "Application.Read.All", "User.ReadBasic.All"],
extraScopesToConsent: ["https://management.core.windows.net/user_impersonation"],
extraQueryParameters: getQueryParamsDict()
};
this.context.instance.loginRedirect({...loginRequest, prompt: "select_account"})
Expected Behavior
Able to successfully login or acquireTokenSilent using Microsoft Personal Account with ARM scope
Identity Provider
Azure AD / MSA
Browsers Affected (Select all that apply)
Chrome, Edge
Regression
No response
Source
Internal (Microsoft)

@ChaithanyaGK In order to use ARM scopes with MSA accounts, you need to use https://login.microsoftonline.com/organizations instead of /common, and then enable MSA passthrough. Please try that and let us know if that works.

@jasonnutter Thanks for the reply. Could you please share any documentation around enabling MSA passthrough.

Resolved offline using instructions provided above, closing.


fix: missing generated folder

Hadn't added .gitkeep, generated folder was not present in template

This is good quick fix, but CLI should handle that itself.


Make Responsive the default Sizing

Given the breadth of form factors available on the market, we should think about making Responsive the default Sizing rather than Fixed. We would need an upgrader for old projects that assume the current default of Fixed to be explicitly set to Fixed. If Sizing is Responsive, we need to think about whether we remove the explicit setting so that the user gets the default (which would be Responsive). One concern is that this could break projects being imported into App Inventor clones that don't take up this change.

I agree that we should make responsive the default.   I didn't do this initially, since I thought it would be easier for kids deigning for a single device to use fixed.   But as Evan says, the multiplicity of devices changes this.
But as Evan says, we need to be careful about breaking projects.

+1 about this.
At least everytime when Im making a app that uses Canvas, i need to switch it to responsive, and it provides a higher quality of displaying

Recently we added a alwaysSend field to @DesignerProperty to cope with different defaults in earlier versions of the companion. If someone tackles this, that field should be set to true for this property until such time as all allowed companion versions have responsive as the default.

@ewpatton I can look into this. So, if I understand correctly, the upgrader should handle setting the default value to responsive too, is that correct?

@lightingft Yes, it is conceptually very similar to the other change you worked on with the BarcodeScanner component.

Fixed by #1644 and is pending a component release


Include all literature from 01_BA_Raffi to my thesis bib

[ ] add all literature
[ ] edit that it is correct in the bib --> also links

All sources gerade auch in ordner speichern und auf cloud laden


Add a type field to message to distinguish between 'message_received' and 'postback'

Apropo to issue #447

See also PR #448 although the two are almost identical!
I think that I like my approach of reusing facebook_postback vs. postback for that type, but I also like that you've added a type field to non-postback messages, saves a null-check in client code.

I agree re-naming convention. Personally I have an aversion to fields that require a null check.
From what I can tell receiveMessage() is only called twice - on message_received and on facebook_postback. Thus adding type on both of them resolves the issue.

This may be over-engineering at this point, but maybe they should both be string constants?

I like to use string constants for stuff like this in my own projects, but it's not a common approach in JS land generally.

So are we in agreement on the solution here? Do we still need two PRs?

No, I've closed the other one, let's get this one merged 😀

Sounds good to me. Got any info on the frequency of merges here?

Looking at the number of open PRs and issues, not high! But I'll mention it in the Slack channel.

In the doc changes you have “type will be set to postback” when it should say facebook_postback.
BTW talking with the Howdy guys now about getting some open PRs merged.

@ianp changed. Good catch.

This looks good to merge now.

Thank you guys! Sorry it took longer than it should have. Merged!!


Add env variable for node mapping validation to be loose to shortname, instead of fqdn

resolves #465
Opening a PR as a suggested interim workaround of issue #465.  Please add thoughts and considerations, this is mostly to get discussion going—
Suggested env variable name would be akin to existing SKIP_MOUNT_UNMOUNT.  This one would be called: SHORTNAME_NODE_MAPPING and value would either be "yes" or "no".  Default would be "no", so there is no behavior change.  This env variable need not be exposed or supported, beyond the limited workaround here.

Hi @dunnevan, Thanks for the PR. Changes looks good to me.
I have one query : Are we sure that Admin short name which is used to create node mapping is always there in the filesystem mount node list(FQDN) reported by rest api ?

Hi @dunnevan, Thanks for the PR. Changes looks good to me.
I have one query : Are we sure that Admin short name which is used to create node mapping is always there in the filesystem mount node list(FQDN) reported by rest api ?

No, I've heard that GUI does some of it's own name resolution.  If so this may not work.  It needs to be tested before being accepted.
With that said, it would work if REST API is returning as mmlscluster or mmlsmount would return


llvmPackages_git: 18.1.0-rc3 -> 18.1.0-rc4

Description of changes
This PR bumps llvmPackages_git to 18.1.0-rc4, also known as 18.1.0 (so the latter has a bug). The next bump would be to 19.0.0-unstable-2024-0x-xx, depending on whether anyone (or I) has time.
https://github.com/llvm/llvm-project/compare/llvmorg-18.1.0-rc3...llvmorg-18.1.0-rc4
If someone wants to do an llvmPackages_18: init, please:

copy the expression on staging to llvmPackages_18,
bump to the latest release (18.1.1),
add support for 18.1.0 in spirv-llvm-translator (#295139), then,
do an llvmPackages_18.libclc: init.

Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg build pkgsStatic.llvmPackages_git.clang

@ofborg build pkgsCross.wasi32.llvmPackages_git.libcxx

This still builds on aarch64-darwin, the x86_64-darwin build will be run overnight.

Done on x86_64-darwin.


schematic

Fatal error: Allowed memory size of 268435456 bytes exhausted (tried to allocate
4096 bytes) in phar:///root/Sm/PocketMine-MP.phar/src/pocketmine/block/BlockFac
tory.php on line 400
[05:48:49] [Server thread/CRITICAL]: Could not execute asynchronous task Schemat
icLoadTask: Task crashed

Your schematics file is too big. Try disable memory limit in pocketmine.yml


would it make sense to have a "polygon contains polygon" method?

ie. all the points in the 2nd polygon's array are contained in the 1st polygon
or is it so straigthforward there's no point in adding it?

Hmm. I’d probably suggest implementing boolean geometry operations (intersection ∩ and union ∪) and then use that. A polygon A contains another polygon B if A∪B = A. The Turf library has implementations of these operations, ported from the JavaScript Topology Suite which is a programmatic translation of the Java Topology Suite.

thanks for the suggestion! that does appear to do what I was after. curious, why did you write d3-polygon instead of using turf, simpler api?

No immediate plans to implement these topological operations, so I am closing this request.


Deleting stash should refresh the stash view

New to neogit, looks awesome so far, thx!
Is your feature request related to a problem? Please describe.
When deleting a stash with x while I have opened "diff view on the right" for the given stash, the - now deleted - stash stays in the view, although my cursor is now on another item. Pressing enter to open (the current one) closes the window with the old first, so I need to open it again then.
Describe the solution you'd like
Having the "autorefresh" would simplify the flow of walking through old stashes & deleting them vastly; one would just:

open one stash
delete it on the left with x
look for - now updated - view of another stash
delete it again, ...

Also, maybe highlighting the currently opened stash would be helpful as well.
Maybe this is implemented in some auto-refresh way? I could not find...

I've added some visual indication of which item you're currently viewing. No auto-updating, but it's a start :)


fix: locale regex

The locale regex only pulls up two letters ro and it seems it's not a valid locale.
This update fixes it to pick up ro-RO.

Error
An I18n::InvalidLocale occurred in projects#index:
2020-08-25T16:30:09.593225+00:00 app[web.1]:
2020-08-25T16:30:09.593226+00:00 app[web.1]: "ro" is not a valid locale
2020-08-25T16:30:09.593226+00:00 app[web.1]: app/controllers/application_controller.rb:118:in `switch_locale'
2020-08-25T16:30:09.593226+00:00 app[web.1]:
2020-08-25T16:30:09.593227+00:00 app[web.1]:
2020-08-25T16:30:09.593227+00:00 app[web.1]: -------------------------------
2020-08-25T16:30:09.593228+00:00 app[web.1]: Request:
2020-08-25T16:30:09.593228+00:00 app[web.1]: -------------------------------
2020-08-25T16:30:09.593228+00:00 app[web.1]:
2020-08-25T16:30:09.593229+00:00 app[web.1]: * URL        : https://www.helpwithblackequity.com/favicon.ico
2020-08-25T16:30:09.593229+00:00 app[web.1]: * HTTP Method: GET
2020-08-25T16:30:09.593230+00:00 app[web.1]: * IP address : <IP_ADDRESS>
2020-08-25T16:30:09.593230+00:00 app[web.1]: * Parameters : {"controller"=>"projects", "action"=>"index", "category_slug"=>"favicon", "format"=>"ico"}
2020-08-25T16:30:09.593231+00:00 app[web.1]: * Timestamp  : 2020-08-25 09:30:09 -0700
2020-08-25T16:30:09.593231+00:00 app[web.1]: * Server : 1ccec1b7-2aa6-4158-8f90-a2c27bc8b6dd
2020-08-25T16:30:09.593231+00:00 app[web.1]: * Rails root : /app
2020-08-25T16:30:09.593232+00:00 app[web.1]: * Process: 4
2020-08-25T16:30:09.593232+00:00 app[web.1]:
2020-08-25T16:30:09.593232+00:00 app[web.1]: -------------------------------
2020-08-25T16:30:09.593233+00:00 app[web.1]: Session:
2020-08-25T16:30:09.593233+00:00 app[web.1]: -------------------------------
2020-08-25T16:30:09.593233+00:00 app[web.1]:
2020-08-25T16:30:09.593234+00:00 app[web.1]: * session id: [FILTERED]
2020-08-25T16:30:09.593234+00:00 app[web.1]: * data: {}
2020-08-25T16:30:09.593234+00:00 app[web.1]:
2020-08-25T16:30:09.593235+00:00 app[web.1]: -------------------------------
2020-08-25T16:30:09.593235+00:00 app[web.1]: Environment:
2020-08-25T16:30:09.593235+00:00 app[web.1]: -------------------------------
2020-08-25T16:30:09.593235+00:00 app[web.1]:
2020-08-25T16:30:09.593236+00:00 app[web.1]: * GATEWAY_INTERFACE                                       : CGI/1.2
2020-08-25T16:30:09.593236+00:00 app[web.1]: * HTTP_ACCEPT                                             : image/webp,image/apng,image/*,*/*;q=0.8
2020-08-25T16:30:09.593237+00:00 app[web.1]: * HTTP_ACCEPT_ENCODING                                    : gzip, deflate, br
2020-08-25T16:30:09.593237+00:00 app[web.1]: * HTTP_ACCEPT_LANGUAGE                                    : ro-RO,ro;q=0.9,en-US;q=0.8,en;q=0.7

This may not fix it. Looking into it.

Done. It's going to fallback to default locale if the detected one is invalid.

Hey @adrianthedev thanks so much for looking into this and making a PR 🙏
Looking at your code, it looks like if we get a locale of "ro-RO" in the headers, then we will default to a locale of "en" (ie our default locale).
This would mean browsers in Romania (local "ro-RO") would see English rather than Romanian if they come to our site. It also means we are working on the assumption that "ro-RO" is an erroneous locale when when in fact it is not.
Rather than raising an error and defaulting to English what do you think about fixing the regex that picks up the locale so that it is more forgiving? Specifically this line: request.env['HTTP_ACCEPT_LANGUAGE'].scan(/^[a-z]{2}/).first
Atm this line only picks up the first two letters in the headers, but we could change it to pick up all the expected locales.
Thoughts? Happy to discuss :)

I tried picking up the full ro-RO value but that doesn't really work by itself. It seems we need to use :en or :es, the available locales.
You can tweak the regex like that no worries, but that isn't a fix by itself. The fix is to fallback to something known, IMHO.
BTW, the app is still broken atm. It's possible that users in the US can't access it because they have a browser locale different than en or es. I would push a fix ASAP.

Ah of course we don't have all the locales 🤦 my bad! Defaulting to the available :en/:es locales makes perfect sense 👍
I'll push the change now, cheers @adrianthedev


Data Quality Vocabulary terms - initial start

These are a list of terms from ISO25012, ISO19157 and NSW OEH to describe the quality of datasets.

I must of missed them too.

@DavidCrosswellGSQ I have split into 3 separate files and done some matching between ISO19157 and ISO25012.


hello

workflow job
:x: Exit Code 128
$ run-ci merge master

+ gitfetch origin master
From github.com:suzuki-shunsuke/example-run-ci-circleci
 * branch            master     -> FETCH_HEAD
+ gitmerge --no-edit origin/master
fatal: empty ident name (for <>) not allowed
exit status 128

workflow job
:x: Exit Code 3
$ run-ci merge master

No help topic for 'merge'


Go to directory in "Explorer" side bar for "Go to Definition" on package names in imports.

(see the first bullet under "e2e/tests/conftest.py" in https://github.com/microsoft/vscode-python/issues/5963#issuecomment-501029802)
Given the following files:
project/
    spam/
        eggs/
            __init__.py
            mod.py
        ham/
            mod.py
        mod.py  # defines a class named "Data"

current behavior
For from spam.mod import Data, "Go to Definition" (after right-clicking) for "Data" works as expected, going to the class definition in the other file.  For "mod" it also works (since that is a module).  However, for "spam" it acts as though you right-clicked on "mod".
For from spam.eggs import mod (has a __init__.py), it works for "mod" (opens the file).  However, for both "spam" and "eggs" it says "no definition found".
For from spam.ham import mod (no __init__.py), it behaves the same as from spam.eggs import mod
desired behavior
For packages, highlight and open the directory in the "Explorer" side bar:

"spam" in from spam.mod import Data
"spam" and "eggs" in from spam.eggs import mod
"spam" and "ham" in from spam.ham import mod

I think we need to make it clear, for this is to be done we'll need to make both LS and extension changes to support this.
Agreed, leave open for @luabud to decide.
Been open for 3 months now, should be something that can be fixed in the next design meeting.

Thanks for the suggestion 👍 but we decided not to move forward with this idea for now.


Adjustment suggestions to GroupBy generics

Hi,
I noticed a slight discomfort in using generics while grouping.
GSum<T extends Number & Comparable<T>>  could be just GSum<T extends Number>
GAvg<T extends Number & Comparable<T>>  could be just GAvg<T extends Number>
GMin<T extends Comparable<T>> should beGMin<T extends Comparable<? super T>>
GMax<T extends Comparable<T>> should be GMax<T extends Comparable<? super T>>
The latter ones would actually be useful for me because I have to dumb down the generics in order to get things working (or typecast the date as java.util.Date)
GroupExpression<java.sql.Date, java.sql.Date> min = GroupBy.min((DatePath) date)

@TuomasKiviaho We are currently preparing to switch to a different package structure for the 4.0 release so it might be easier to do this change after that.


Check for missing maven dependencies

Merely adding a dependency on scifio-bf-compat may not be sufficient to get the Bio-Formats bridge working.
Could be missing some dependencies here..

The issue is that scifio-bf-compat does not depend on formats-gpl. Actually, I think this is good. It means we can license scifio-bf-compat as BSD rather than GPL; see #17 for details.


Information about the error location is lost

Hello, Paul!
If you run the following console application by using the latest version of Jurassic (5a8822c):
using System;

using Jurassic;
using Jurassic.Library;

namespace TestJurassicJavaScriptException
{
    class Program
    {
        static void Main(string[] args)
        {
            var engine = new ScriptEngine();
            var source = new StringScriptSource(@"var $variable1 = 611;
var _variable2 = 711;
var variable3 = 678;

$variable1 + -variable2 - variable3;",
            "variables.js");

            try
            {
                int result = engine.Evaluate<int>(source);
                Console.WriteLine("Result: {0}", result);
            }
            catch (JavaScriptException e)
            {
                Console.WriteLine("During working of JavaScript engine an error occurred.");
                Console.WriteLine();
                Console.WriteLine("Message: {0}", e.Message);
                Console.WriteLine("Name: {0}", e.Name);
                Console.WriteLine("Source path: {0}", e.SourcePath ?? "null");
                Console.WriteLine("Line number: {0}", e.LineNumber);

                var errorValue = e.ErrorObject as ErrorInstance;
                if (errorValue != null)
                {
                    Console.WriteLine("Stack: {0}", errorValue.Stack);
                }
            }

            Console.ReadLine();
        }
    }
}

Then you will see that information about the error location is lost.
Current version (5a8822c):
Message: ReferenceError: variable2 is not defined.
Name: ReferenceError
Source path: null
Line number: 0
Stack: ReferenceError: variable2 is not defined.

Previous version (14b9886):
Message: ReferenceError: variable2 is not defined
Name: ReferenceError
Source path: variables.js
Line number: 5
Stack: ReferenceError: variable2 is not defined
    at variables.js:5

Thanks for raising this, I rewrote pretty much the entirety of how variables work as part of supporting 'let'. I guess I shouldn't be surprised that I broke something :-)

Fixed in commit a515cc10deb34514b970c177557329e9df4897c0

Thanks!


Native image build of tests/integration/jpa fails because of org.glassfish.hk2.utilities.CleanerFactory.commonCleaner initialization

Build fails with following error:
Error: Detected a java.lang.ref.Cleaner object in the image heap which uses a daemon thread that invokes cleaning actions, but threads running in the image generator are no longer running at image runtime.  To see how this object got instantiated use --trace-object-instantiation=java.lang.ref.Cleaner. The object was probably created by a class initializer and is reachable from a static field. You can request class initialization at image runtime by using the option --initialize-at-run-time=<class-name>. Or you can write your own initialization methods and call them explicitly from your main entry point.
Detailed message:
Trace: Object was reached by
  trying to constant fold static field org.glassfish.hk2.utilities.CleanerFactory.commonCleaner
    at org.glassfish.hk2.utilities.CleanerFactory.create(CleanerFactory.java:53)
  parsing method org.glassfish.hk2.utilities.CleanerFactory.create(CleanerFactory.java:53) reachable via the parsing context
    at static root method.(Unknown Source)

And the hk2-utils are dependency of webserver
[INFO] |  +- io.helidon.webserver:helidon-webserver-jersey:jar:3.2.9-SNAPSHOT:compile
[INFO] |  |  +- io.helidon.jersey:helidon-jersey-server:jar:3.2.9-SNAPSHOT:compile
[INFO] |  |  |  \- org.glassfish.jersey.core:jersey-server:jar:3.0.14:compile
[INFO] |  |  |     \- jakarta.validation:jakarta.validation-api:jar:3.0.0:compile
[INFO] |  |  +- io.netty:netty-buffer:jar:4.1.108.Final:compile
[INFO] |  |  +- io.helidon.jersey:helidon-jersey-client:jar:3.2.9-SNAPSHOT:compile
[INFO] |  |  |  \- org.glassfish.jersey.core:jersey-client:jar:3.0.14:compile
[INFO] |  |  \- org.glassfish.jersey.inject:jersey-hk2:jar:3.0.14:compile
[INFO] |  |     +- org.glassfish.jersey.core:jersey-common:jar:3.0.14:compile
[INFO] |  |     |  \- org.glassfish.hk2:osgi-resource-locator:jar:1.0.3:compile
[INFO] |  |     +- org.glassfish.hk2:hk2-locator:jar:3.0.6:compile
[INFO] |  |     |  +- org.glassfish.hk2.external:aopalliance-repackaged:jar:3.0.6:compile
[INFO] |  |     |  +- org.glassfish.hk2:hk2-api:jar:3.0.6:compile
[INFO] |  |     |  \- org.glassfish.hk2:hk2-utils:jar:3.0.6:compile

Fix is simple, add -initialize-at-run-time=org.glassfish.hk2.utilities.CleanerFactory into native image properties.


chore: bump @nuxtjs/sitemap version

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type

[ ] Bugfix
[ ] Feature
[x] Refactoring

Context

[x] Related #9107

Currently, this is the root cause of the renovate throw error. try to run this command on main branch:
npx nuxi upgrade -f && NITRO_PRESET=cloudflare_pages pnpm nuxi build

now, try to run that command again in this branch
Did your issue had any of the "$" label on it?

[x] My DOT address: Payout

Thanks!
pay 30 usd

😍 Perfect, I’ve sent the payout
💵 $30 @ 6.55 USD/DOT ~ 4.58 $DOT
🧗 1xjvRADwdJcnmUCLWerEHR4iGCT5EBTm4D4fzLLg4LcAC9p
🔗 0x0146f636c2de2f02ef9f5997674a1d8daf5006b1b36be1f186b46e81281e6885
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues


virtualmachinesnapshot-validator error

/kind bug
What happened:
I'm trying to create a snapshot of a VM, but when i try to create it i get this error:
Error from server: error when creating "snap.yml": admission webhook "virtualmachinesnapshot-validator.snapshot.kubevirt.io" denied the request: snapshot feature gate not enabled

i followed this guide:  https://github.com/kubevirt/kubevirt/blob/main/docs/snapshot-restore.md
I enabled the feature gates in the kubevirt deploy and in the /etc/kubenetes/manifiset/* files
Anything else we need to know?:
snap.yml file:
apiVersion: snapshot.kubevirt.io/v1alpha1
kind: VirtualMachineSnapshot
metadata:
  name: snap-1
spec:
  source:
    apiGroup: kubevirt.io
    kind: VirtualMachine
    name: testvm

Environment:

KubeVirt version (use virtctl version): v0.43.0
Kubernetes version (use kubectl version): v1.21.3
VM or VMI specifications:

apiVersion: kubevirt.io/v1
kind: VirtualMachine
metadata:
  name: testvm
spec:
  running: false
  template:
    metadata:
      labels:
        kubevirt.io/size: small
        kubevirt.io/domain: testvm
    spec:
      domain:
        devices:
          disks:
            - name: containerdisk
              disk:
                bus: virtio
            - name: cloudinitdisk
              disk:
                bus: virtio
          interfaces:
          - name: default
            masquerade: {}
        resources:
          requests:
            memory: 64M
      networks:
      - name: default
        pod: {}
      volumes:
        - name: containerdisk
          containerDisk:
            image: quay.io/kubevirt/cirros-container-disk-demo
        - name: cloudinitdisk
          cloudInitNoCloud:
            userDataBase64: SGkuXG4=

Cloud provider or hardware configuration: GCP
OS (e.g. from /etc/os-release): Debian 10
Kernel (e.g. uname -a): 4.19.0-17-cloud-amd64

Seems like feature gate is not enabled. Please try below command.
kubectl patch -n kubevirt kubevirt kubevirt -p '{"spec": {"configuration": { "developerConfiguration": { "featureGates": [ "Snapshot" ] }}}}' -o json --type merge

Also if you face any issue regarding feature gates please refer user-guide

Seems like feature gate is not enabled. Please enable using below command.
kubectl patch -n kubevirt kubevirt kubevirt -p '{"spec": {"configuration": { "developerConfiguration": { "featureGates": [ "Snapshot" ] }}}}' -o json --type merge

Also if you face any issue regarding feature gates please refer user-guide

Could you please run
kubectl describe kubevirt.kubevirt.io/kubevirt -n kubevirt

and share the output

Of course:
    Name:         kubevirt
Namespace:    kubevirt
Labels:       <none>
Annotations:  kubevirt.io/latest-observed-api-version: v1
              kubevirt.io/storage-observed-api-version: v1alpha3
API Version:  kubevirt.io/v1
Kind:         KubeVirt
Metadata:
  Creation Timestamp:  2021-08-04T10:31:30Z
  Finalizers:
    foregroundDeleteKubeVirt
  Generation:  3
  Managed Fields:
    API Version:  kubevirt.io/v1
    Fields Type:  FieldsV1
    fieldsV1:
      f:spec:
        .:
        f:certificateRotateStrategy:
        f:configuration:
          .:
          f:developerConfiguration:
        f:customizeComponents:
        f:imagePullPolicy:
        f:workloadUpdateStrategy:
    Manager:      kubectl-create
    Operation:    Update
    Time:         2021-08-04T10:31:30Z
    API Version:  kubevirt.io/v1alpha3
    Fields Type:  FieldsV1
    fieldsV1:
      f:metadata:
        f:annotations:
          .:
          f:kubevirt.io/latest-observed-api-version:
          f:kubevirt.io/storage-observed-api-version:
        f:finalizers:
      f:status:
        .:
        f:conditions:
        f:generations:
        f:observedDeploymentConfig:
        f:observedDeploymentID:
        f:observedKubeVirtRegistry:
        f:observedKubeVirtVersion:
        f:operatorVersion:
        f:phase:
        f:targetDeploymentConfig:
        f:targetDeploymentID:
        f:targetKubeVirtRegistry:
        f:targetKubeVirtVersion:
    Manager:      virt-operator
    Operation:    Update
    Time:         2021-08-04T11:06:58Z
    API Version:  kubevirt.io/v1alpha3
    Fields Type:  FieldsV1
    fieldsV1:
      f:status:
        f:outdatedVirtualMachineInstanceWorkloads:
    Manager:      virt-controller
    Operation:    Update
    Time:         2021-08-04T11:07:03Z
    API Version:  kubevirt.io/v1
    Fields Type:  FieldsV1
    fieldsV1:
      f:spec:
        f:configuration:
          f:developerConfiguration:
            f:featureGates:
    Manager:         kubectl-patch
    Operation:       Update
    Time:            2021-09-07T13:38:10Z
  Resource Version:  7273439
  UID:               6a244605-d232-4df7-afce-50be2e9a71f4
Spec:
  Certificate Rotate Strategy:
  Configuration:
    Developer Configuration:
      Feature Gates:
        Snapshot
  Customize Components:
  Image Pull Policy:  IfNotPresent
  Workload Update Strategy:
Status:
  Conditions:
    Last Probe Time:       2021-09-09T08:33:21Z
    Last Transition Time:  2021-09-09T08:33:21Z
    Message:               All components are ready.
    Reason:                AllComponentsReady
    Status:                True
    Type:                  Available
    Last Probe Time:       2021-09-09T08:33:21Z
    Last Transition Time:  2021-09-09T08:33:21Z
    Message:               All components are ready.
    Reason:                AllComponentsReady
    Status:                False
    Type:                  Progressing
    Last Probe Time:       2021-09-09T08:33:21Z
    Last Transition Time:  2021-09-09T08:33:21Z
    Message:               All components are ready.
    Reason:                AllComponentsReady
    Status:                False
    Type:                  Degraded
    Last Probe Time:       2021-08-04T11:06:58Z
    Last Transition Time:  <nil>
    Message:               All resources were created.
     Adding @mhenriks who worked on the documentation.

Hi @23r096  I tried to reproduce the bug with your config but it seems to work. During some attempts, I realized that if you put Snapshot  (with white space at the end) it seems that Feature Gate is enabled but the snapshot procedure fails as you described. I can't be sure that's the case for you. Could you give feedback if the problem persists?


WifiManager json and md file updated as per code

Documentation enhancement for WifiManager Plugin

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Can one of the admins verify this patch?

The changes are merged in different PR. So closing it.


Potential Issue (from versioning) for unmatched instances

Code:
import numpy as np
import cc3d

pred = np.zeros((10, 35, 35))
gt   = np.zeros((10, 35, 35))

pred[0, 1:20, 1:20] = 1
gt[0, 1:20, 1:20] = 1

pred[0, 25:30, 25:27] = 1
gt[0, 25:30, 25:30] = 1

# connected components
pred_arr = cc3d.connected_components(pred, connectivity=26)
ref_arr = cc3d.connected_components(gt, connectivity=26)

# unsigned np arrays
pred_arr = pred.astype(np.uint8)
ref_arr = gt.astype(np.uint8)

from panoptica import NaiveThresholdMatching, Panoptica_Evaluator, UnmatchedInstancePair

sample = UnmatchedInstancePair(pred_arr, ref_arr)

evaluator = Panoptica_Evaluator(
    expected_input=UnmatchedInstancePair,
    instance_matcher=NaiveThresholdMatching(),
)
result = evaluator.evaluate(sample, verbose=True)['ungrouped']
print(result)

Output:
-- Got UnmatchedInstancePair, will match instances
-- Got MatchedInstancePair, will evaluate instances
Metric sq_cldsc: Metric.clDSC could not be found, have you set it in eval_metrics during evaluation?
Metric sq_cldsc_std: Metric.clDSC could not be found, have you set it in eval_metrics during evaluation?
Metric pq_cldsc: Requested metric sq_cldsc that could not be computed
(<panoptica.panoptica_result.PanopticaResult object at 0x7e6416f0ab00>, {'MatchedInstanceMap': <panoptica.utils.processing_pair.MatchedInstancePair object at 0x7e63ede25600>})
/usr/local/lib/python3.10/dist-packages/panoptica/metrics/relative_volume_difference.py:69: RuntimeWarning: overflow encountered in scalar subtract
  rvd = float(prediction_mask - reference_mask) / reference_mask

Colab Link: https://colab.research.google.com/drive/1DyWa7GBfBoh-dV0PXm6hf1sIg4G-F_5I?usp=sharing

Yes, this is a error we are already aware of, and it is actually already fixed in the new development branch (not yet merged into main)
Stay tuned, will be soon fixed on main branch and release version.

Thank you!


Istio SNI is giving validation error when I use it in virtual service as SNI host

Bug Description
I want to use SNI generated from istio in my virtual service but it gives me validation error in networking.istio.io/v1beta1, no error if I use networking.istio.io/v1alpha3
Validation error with v1beta1
Error from server: error when creating "vs.yaml": admission webhook "rev.validation.istio.io" denied the request: configuration is invalid: domain name "outbound_.5000_._.helloworld.echo-7-25457.svc.cluster.local" invalid (label "outbound_" invalid)

My VS:
apiVersion: networking.istio.io/v1beta1
kind: VirtualService
metadata:
  labels:
    istio.io/rev: stable
  name: vs-test
  namespace: echo-7-25457
spec:
  exportTo:
  - .
  gateways:
  - echo-7-25457/ew-gw
  hosts:
  - helloworld.echo-7-25457.svc.cluster.local
  tls:
  - match:
    - port: 15443
      sniHosts:
      - outbound_.5000_._.helloworld.echo-7-25457.svc.cluster.local
    route:
    - destination:
        host: helloworld.echo-7-25457.svc.cluster.local
        port:
          number: 5000
      weight: 100

Relevant code https://github.com/istio/istio/blame/master/pkg/config/validation/validation.go#L2689-L2706
Version
v15.2

Additional Information
No response

@howardjohn any thoughts?
Thanks!

this is WAI, it needs to match hosts

Okay, one question, though, what would I need to do if I have to use SNI created by istio?
which looks like outbound_.5000_._.helloworld.echo-7-25457.svc.cluster.local

can you put that in hosts?
On Wed, Dec 21, 2022, 7:53 PM Shivanshu Raj Shrivastava <
@.***> wrote:

Okay, one question, though, what would I need to do if I have to use SNI
created by istio?
which looks like
outbound_.5000_._.helloworld.echo-7-25457.svc.cluster.local
—
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/42537#issuecomment-1362380017, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXKVFUNKCU5VVDHTCITWOPGB5ANCNFSM6AAAAAATFUDVOM
.
You are receiving this because you were mentioned.Message ID:
@.***>

Yes, I'm able to use this in the host, but my request is not going through; anyways, as you mentioned that this is WAI, I'll close this issue.


Ignoring erl_first_files for dependencies

rebar3 seems to ignore the erl_first_files parameter for dependencies. To test, create a new project and include the following dependencies in rebar.config (in theory any dependency with erl_first_files should work, but I have consistently replicated with the following):
{deps, [
        {uaparser, {git, "https://github.com/chitika/uaparser.git", {branch, "master"}}}
    ]}.

Attempting to compile should reveal the problem (for the dependency listed here, uaparser_utils is expected to be compiled first, but is unavailable for the ct_expand parse_transform used in other modules).
Example:
root@wheezyd:~/test# ~/bin/rebar3 compile
===> Verifying dependencies...
===> Fetching uaparser ({git,"https://github.com/chitika/uaparser.git",
                                    {branch,"master"}})
===> Fetching jiffy ({git,"https://github.com/davisp/jiffy.git",
                                 {tag,"0.10.1"}})
===> Plugin rebar_gdb_plugin not available. It will not be used.
===> Fetching parse_trans ({git,
                                      "https://github.com/esl/parse_trans.git",
                                      {tag,"2.8"}})
===> Fetching edown ({git,"git://github.com/esl/edown.git","HEAD"})
===> WARNING: It is recommended to use {branch, Name}, {tag, Tag} or {ref, Ref}, otherwise updating the dep may not work as expected.
===> Compiling edown
===> Compiling parse_trans
===> Compiling jiffy
===> Compiling uaparser
===> Compiling /root/test/_build/default/lib/uaparser/src/uaparser_browser.erl failed:
/root/test/_build/default/lib/uaparser/src/uaparser_browser.erl:52: {undef,[{uaparser_utils,load_browsers,[],[]},
        {erl_eval,do_apply,6,[{file,"erl_eval.erl"},{line,657}]},
        {ct_expand,xform_fun,6,
                   [{file,"/root/test/_build/default/lib/parse_trans/src/ct_expand.erl"},
                    {line,100}]},
        {parse_trans,apply_F,5,
                     [{file,"/root/test/_build/default/lib/parse_trans/src/parse_trans.erl"},
                      {line,847}]},
        {parse_trans,this_form_df,4,
                     [{file,"/root/test/_build/default/lib/parse_trans/src/parse_trans.erl"},
                      {line,839}]},
        {parse_trans,mapfoldl,3,
                     [{file,"/root/test/_build/default/lib/parse_trans/src/parse_trans.erl"},
                      {line,879}]},
        {parse_trans,mapfoldl,3,
                     [{file,"/root/test/_build/default/lib/parse_trans/src/parse_trans.erl"},
                      {line,885}]},
        {parse_trans,enter_subtrees,5,
                     [{file,"/root/test/_build/default/lib/parse_trans/src/parse_trans.erl"},
                      {line,818}]}]}

Should be fixed now.


added ability to configure the number of threads to keep in the pool and updated default thread pool count

By default, the specified default number of threads (3) are used when
constructing the ThreadPoolExecutor object. However, this commit adds
a BackgroundThreadPoster constructor that takes an integer argument
used to override the default thread count value.

Hi,
I intentionally designed ThreadPoster to be as simple as possible. Adding another constructor is a major step up in the complexity, especially given the fact that most developers don't understand the nuances of thread pools configuration.
Now, we can think about some alternative approach which doesn't make the "immediate" lib's API more complex, but I just can't imagine a use case in Android which would be practically sensitive to this configuration. So, could you describe why you need this feature in detail?

I see the point of wanting to maintain simplicity, however, here's my sales pitch.
When doing any sort of multi threaded work, there are a number of considerations you have to make. There are good topics on the matter so I wont go into a long rant, but here is my tldr;
Thread creation in Java is not free. It takes time and introduces latency. This why Thread Pools exists in the first place. If you know you'll be using more than the 3 default threads, it makes sense to be able to customize it. I've also updated the default thread pool count to equal Runtime.getRuntime().availableProcessors();. On mobile devices this wont necessarily equal the number of physical cores, since certain cores might be shut down due to power saving mechanisms. I'd be curious to hear your reasoning for picking 3 as the default.
Finally, in many cases it makes sense to have a higher thread pool count than available cores if you know each task will spend a significant amount of time waiting.
Brian Goetz recommends the following formulate in his book "Java Concurrency in Practice".
 Number of threads = Number of Available Cores * (1 + Wait time / Service time
I'm not sure I always agree with the formulate, but it shows the need for the ability to configure the thread pool count.
If you want to strictly adhere to simplicity and force the default value, then that's your prerogative. This PR is my suggestion on how to improve the library.

ThreadPoster is a library for Android development. Therefore, I can't imagine any practically significant benefit to changing the number of core threads. Yes, threads creation isn't free, but it's a negligible overhead for most (all?) Android apps because, unlike some bakends, Android apps don't usually utilize hundreds of threads for prolonged periods and they are not sensitive to increase in latency of few milliseconds.
I set the number of core threads to 3 because it doesn't really matter what number will be there. It can be 1 or 10 and no practical Android app I can think about will be affected.

As I said earlier, I'm open to consider this feature if you need it for a real-world use case that can't be implemented without it. However, if your concern is mostly theoretical, I prefer to avoid additional complexity.

Totally fair assessment. It just hurts my OCD to spin up three threads in a thread pool when I only need one.

Please note that you spin up core threads just once. So, worst case scenario, it adds a negligible amount of time to app's startup and consumes several tens of kB of device's memory. All of that is not worth developers' time thinking about, let alone optimizing IMO.
I'll close this PR for now.


COE toolkit upgradation issue

Describe the bug
A clear and concise description of what the bug is.
Component (please tell us which flow or app you are experiencing issues with):

Solution [e.g. Core, Nurture]
Version [e.g. 1.29]
App or Flow [e.g. Sync Template (v2)]

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

I want to know what is the correct method to update COE toolkit in our environment.
In our environment, we have recently upgraded COE toolkit and now we have both V2 and V3 flows. I am now confused on which flow should run to get correct data. Should both version of flows run or only one of them should run?
Please let me know.

Hello. In the past, you used to make copies of flows to make install easier, but with the creation of the Connection References product feature, you no longer need to do this. This is likely how you ended up with v2 and v3.
You should disable and delete the old v2 flows, and you can keep the v3 flows in place now, making installing udpates in the future easier

Closing out items without further action items


networking: Turn off multicast snooping on integration bridge

Multicast snooping may be turned on the bridge depending on the
distro kernel config. Disable this explicitly to avoid kernel issues
related to multicast timer expiration.
Fixes #229
Signed-off-by: Archana Shinde<EMAIL_ADDRESS>

Coverage increased (+0.02%) to 67.07% when pulling 7dd546e45dc152cf9ddff36c24e1766bd0e5b954 on amshinde:igmp-snooping into 01c872512aff76d2aa46e7481a46051ba18bcb2b on containers:master.

cc @mcastelino

LGTM

@amshinde I am totally fine with this change. But wouldn't be clearer to use this function from the netlink package instead:
func (h *Handle) BridgeSetMcastSnoop(link Link, on bool) error

Link: https://godoc.org/github.com/vishvananda/netlink#Handle.BridgeSetMcastSnoop

@sboeuf Using that function is just a matter of convenience. Plus the createLink function is a generic function and it should be able to handle both true/false values for multicast snooping for bridges.

Well I think it will help to understand the code easily. When you look at the code, you can see the sequence:
// Create the bridge
bridgeLink, err := createLink(netHandle, netPair.Name, &netlink.Bridge{})
if err != nil {
	return fmt.Errorf("Could not create bridge: %s", err)
}

// Disable multicast snooping
if err := netHandle.BridgeSetMcastSnoop(bridgeLink, false); err != nil {
	return fmt.Errorf("Could not disable the multicast snooping on the bridge: %s", err)
}

I'd rather have the createLink function support all possible attributes present on a link/bridge while creating the link, rather than have extra calls to set attributes later on.

Ok fine.
LGTM


Make PERF_TRIALS configurable from the command line

This is left as a TODO comment in perf.hpp. I'm putting it up here for better visibility.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/7360044-make-perf_trials-configurable-from-the-command-line?utm_campaign=plugin&utm_content=tracker%2F402515&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F402515&utm_medium=issues&utm_source=github).

It's done, see https://github.com/boostorg/compute/commit/dcddaae8d2bef698ff267ea6e32d90dd9bcf37e5. If you still would like benchmarks to be more flexible, rename this issue or better just open a new one.


Queued emails can now have to_user == null, meaning send to webmaster.

This removes a sanity check from rake email:send which caused it to silently throw away emails with null recipient.  This used to make sense... sorta... at least as a way to reduce junk error messages.  But now that all emails, including those to webmaster, are queued, it means that recipient can legitimately be null (that means the recipient is webmaster).  The obvious solution was simply to remove the sanity check.  Hopefully this doesn't create a whole mess of cronjob error messages!
@nimmolo and @JoeCohen -- The problem here, I believe, is that rake tasks are not unit tested.  The seemingly obvious solution is to move the guts of lib/tasks/email.rb into app/models/queued_email.rb so that it can be unit tested properly.  Then the only thing in lib/tasks/email.rb is QueuedEmail.send_emails and really doesn't matter that it's not tested.  Does that sound like a plan?

coverage: 94.441%. remained the same
when pulling 7ea099d98af8f5e62231608e0b1e1b52b4453350 on fix_webmaster_emails
into 476318e326bd91bc2ee24beb8d6fb16580b5c767 on main.

That sounds like a plan to me.

Agreed.  Moving the contents of rake tasks in proper objects that can be unit tested is the right thing.  I also note that there are a bunch of rubocop violations that can be cleaned up quickly by just running rubocop -A lib/tasks/email.rake.

@pellaea. A big thanks for fixing this.
I think it is worth getting the fix out now, as the bug makes some
emails disappear.
I agree with moving rake tasks to testable objects.

On Mon, Dec 11, 2023 at 6:17 AM Nathan Wilson @.***>
wrote:

Is it worth getting the fix out before doing the refactor and test writing
which might take a bit of time?
—
Reply to this email directly, view it on GitHub
https://github.com/MushroomObserver/mushroom-observer/pull/1705#issuecomment-1850170522,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAALDFFS6SNXCJXBXMBT26DYI4IXDAVCNFSM6AAAAABAOWBQ62VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJQGE3TANJSGI
.
You are receiving this because you were mentioned.Message ID:
@.***>

It broke some after Tue, Aug 15, 6:35 PM (PDT). (That was the timestamp on
the last merge request we actually received.)
On Mon, Dec 11, 2023 at 6:21 AM Jason Hollinger @.***>
wrote:

Yeah, moving the code and doing the rubocop fixes is probably within the
scope of time I have available, but definitely not writing tests, too. So
I'll just push this out now.
I'll also take a minute to check the logs to see how many comments we've
missed. Someone said this stopped working sometime in August?
On Mon, Dec 11, 2023 at 9:17 AM Nathan Wilson @.***>
wrote:

Is it worth getting the fix out before doing the refactor and test
writing
which might take a bit of time?
—
Reply to this email directly, view it on GitHub
<
https://github.com/MushroomObserver/mushroom-observer/pull/1705#issuecomment-1850170522>,

or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AAYTNNPUBWMUBGDIMZTV47DYI4IXFAVCNFSM6AAAAABAOWBQ62VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJQGE3TANJSGI>

.
You are receiving this because you authored the thread.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
https://github.com/MushroomObserver/mushroom-observer/pull/1705#issuecomment-1850177978,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAALDFB2AF5NEASE47ZS4KLYI4JGLAVCNFSM6AAAAABAOWBQ62VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJQGE3TOOJXHA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Pushing out quick fix, will address rubocop and tests etc. later.


Branch stable/0.16 is failing

Trying to build stable/0.16 at commit 4cbb2e02d03cad19563f1e399c2f57d26ab36ede failed.
More info at: https://travis-ci.com/Qiskit/qiskit-terra/jobs/474466255

Failure is from CI on a PR to the stable branch, not on the stable branch.


Too many redirection on the page clears session resulting in session variables been flushed.

Building a project mainly based on session and where I am at a development mode, I have seen that works very well when I try to give a fresh login. But when I try to refresh pages around 5 times or so, it get flooded with error messages telling "Trying to get property of non-object" which means My session variables are flushed.

can ajax solve my problem?

No, it's likely to cause it.


404 at /css/bootstrap.css

I found a broken link : https://docs.docker.com/css/bootstrap.css

Was that URL referenced somewhere? Or did you arrive there from the web inspector?

closing, as this went stale


[ST] Add new system test for certificate reload

This PR adds system test for feature added in https://github.com/strimzi/drain-cleaner/pull/66

/azp run build

/azp run drain-cleaner


USGS-RFEM6 Response Spectrum Link

Description
The main purpose of this web application is to read the data from USGS Web Service acc. to user input, visualize this data and send the requested response spectrum data to RFEM6. This is requested by our USA branch office members.
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update

How Has This Been Tested?

[ ] Unit Tests
[x] Attached examples

Test Configuration:

RFEM / RSTAB version: 6.02.0041
Python version: 3.10

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

HowTo.md file has added. Unfortunately if I add relative path, there is an error in the Website. So I left it without change.

Fixed.


Name ending with a number are not well detected

export const MyComponent2: FC = () => {
  // ..
}

This was detected as invalid.

Thanks!

Thanks for the report btw!


Make java-test output more useful

Currently it appears that the output from java-test (or just running the tests manually) is a ton of Gradle build output, but nothing at all that actually indicates that any tests ran. I'm not sure if we can do anything about making the former less chatty, but for the latter it sounds like maybe we can enable logging like what I think of as normal unit test logging (Google Test, XCTest, etc.) by doing something like (untested; just based on quick searching online) in the example gradle files:
test {
    testLogging {
        events "started" "passed", "skipped", "failed"
    }
}

Not having auditability of what ran is a significant issue since I've found a number of cases in the past several months via log inspection where we weren't actually running the tests we though we were (not Java unit tests specifically, just in general across the repo). If the logs don't have anything we can compare against what we think is running, then we just won't know if we're accidentally not running something.
/cc @blasten @bparrishMines

a ton of Gradle build output

It looks like it's more verbose than the corresponding output from firebase-test-lab; maybe the issue is that we're passing --info?


Android 11

Hi,
just wanted to drop a comment that on my Motorola g30  with Android 11 neither the sample App, nor the E4 realtime app from the Appstore can make a connection. It works fine with my other Android 10 device. Unfortunately that is not the device I am tasked to develop my App for.
Can you give me a hint on how I can maybe send some useful Log-file from Android Studio, or is there anything else I can do to help to get the sdk working with android 11?

Is there any response to this thread here? I'm having the same issue on my end. Thanks


MWPW-137755 Fix RTL text issue -how-to ordered lists

Fixing how to ordered lists for RTL language pages.
Resolves: MWPW-137755
Test URLs:

Before: https://main--milo--adobecom.hlx.live/mena_ar/drafts/doreswam/how-to?martech=off
After: https://mwpw-137755--milo--puruadobe.hlx.live/mena_ar/drafts/doreswam/how-to?martech=off

Please note that the Lighthouse score is low because of the region selector modal. This is just an example page in Milo for RTL language fix of how to block, https://main--milo--adobecom.hlx.live/mena_ar/drafts/doreswam/how-to?martech=off
DC page where the fix is required --> https://www.stage.adobe.com/mena_ar/acrobat/online/ppt-to-pdf.html?milolibs=mwpw-137755--milo--puruadobe.

@JFernandezAdobe please verify the fix and approve.

@JFernandezAdobe please verify the fix and approve.

The fix is looking good in DC pages. I left a comment in MWPW-137755.

@ryanmparrish need your approval on this, since you are the code owner, please. :)


Existential crisis?

I've had a good time using this package. But then I stumbled upon this tweet:
Someone mentioned about reducers à la ReasonReact:

useReducer is awesome but I just feel like we miss a way to easily trigger side effects and re-dispatch actions within reducers à la ReasonReact :)

Dan Abramov then replied:

There are unclear questions about how that would work in concurrent mode.

I'm wondering if that's the case 🤔

AFAIK it should work. the main question was about commit cancellation, but as we create a new ref in order to store side-effects (https://github.com/bloodyowl/reason-react-update/blob/5dc1ac815b93afa9037d8455da6b883f89c162dd/src/ReactUpdate.re#L29), React should be able to go back to its previous state without trouble.
we'll reopen this issue if we start to see bugs when concurrent mode becomes the default in React.


Allow passing a group name to State.limit_hosts

To reduce all the with state.limit_hosts(inventory.get_group('this_group')):....

Closed @ https://github.com/Fizzadar/pyinfra/commit/1f6253e2e394d33924ce4f3dc8c552a547011708


Defer script loading.

Triggered by https://github.com/ethereum/solidity-portal/issues/21

Do we currently have a test deployment of PRs?

No, we don't @chriseth - I asked about this several months ago but nobody found that it was important.


Add basic example of a custom update loop

There currently aren't any examples of how to do this aside from the actual implementations in schedule_runner and the bevy_winit create, and quite a few people have asked about it on the discord.
This adds a basic example that reads input from stdin and updates the app once for each line.

Might a bevy::app::Events be a more appropriate way to present the user input?

What app do you use? Do you have a WhatsApp number?
Or a server on Discord?
On Fri, Nov 6, 2020 at 8:29 PM Plecra<EMAIL_ADDRESS>wrote:

Might a bevy::app::Events be a more appropriate way to present the user
input?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/bevyengine/bevy/pull/799#issuecomment-723141572, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AHGK5TFGJV5KNJIARKOX7FTSOQI65ANCNFSM4TMQO5XQ
.

--
Raza Amir

@Plecra I think for a more serious implementation events might be better, but i kind of like the minimalism of this example
I dig this. I think its good to go after a rebase (sorry about that ... i accidentally broke builds on the master branch. but its fixed now).


Create extract PSD sequence for TvPaint

Changelog Description
Create a PSD extractor for TvPaint in order to publish PSD sequences.

Similar comments to https://github.com/ynput/OpenPype/pull/4639 . The PSD extraction logic must be explicit and not bounded to current render layer/pass logic. The usage is different and should be explicitly created.


fix: active enviroment not updated after rename when there is single enviroment

Description
minor fix for when there is single environment and user renames it, active environment is not updated to the renamed environment which causes error when user tries to update or delete the active environment.
Contribution Checklist:

[x] The pull request only addresses one issue or adds one feature.
[x] The pull request does not introduce any breaking changes
[x] I have added screenshots or gifs to help explain the change if applicable.
[x] I have read the contribution guidelines.
[ ] Create an issue and link to the pull request.

before:
https://github.com/user-attachments/assets/3da6d45b-88fa-436d-9b3e-817ee38ff58e
after:
https://github.com/user-attachments/assets/b8d4d9cd-fe4b-48f4-b0b7-7884cee9b79c

Merged!
Thanks @therealrinku

Hey @therealrinku, this PR fixes the environment issue, but it has also introduced a new bug.
https://github.com/user-attachments/assets/3eaa4abf-8655-4a57-89ce-514ee904a33c


⚠ Adam Brand Music has degraded performance

In ddf3f7d, Adam Brand Music (https://adambrandmusic.com) experienced degraded performance:

HTTP code: 200
Response time: 7631 ms

Resolved: Adam Brand Music performance has improved in 881178c after 7 minutes.


Upgrade org.junit:* to >= 5.1.0

We need to upgrade to the latest version of JUnit: JUnit 5.
In order for JUnit 5 to be compatible with older versions, they have created the org.junit.jupiter package to avoid collisions.
Make sure that:

The project still builds
The tests are still passing

The version is controlled via the strongbox-parent/pom.xml.
The tests can be executed using:
mvn clean install -Dintegration.tests
These must all be passing successfully.

This task has been picked up by @SevastyanDark.


MOREE RANKS

I suggest adding the ability to create unlimited ranks.  I need a lot more than 53. Is it possible to add multipage?  Or use the PlaceholderAPI to make the ranks in their own DeluxeMenus and not depend on the menu available in the plugin.
But the main request is to make an unlimited number of ranks

Done.


Texture import srgb detection regression

Godot version:
3.1.1 Stable (works) and 3.2 Beta 6 (broken)
OS/device including version:
Manjaro Linux x86_64
Issue description:
I have image assets (png) which Gimp's metadata viewer says is in in srgb colorspace.

In 3.0.x and 3.1.x it is imported correctly but when reimported in 3.2 Beta 6 (this is also present in all 3.2 builds I've tried including 3.1 Alpha 1) the image is washed out. Once the Srgb import setting is changed from Detect to Enable and the texture is reimported it is displayed correctly.
3.1.1 Stable

3.2 Beta 6 and the texture reimported with same settings

Once Srgb is set to Enable and the texture reimported it displays correctly in 3.2 Beta 6

Steps to reproduce:
See above explanation and reproduction project below
Minimal reproduction project:
TextureSrgb.zip

Does Godot even make use of the image metadata? I thought it was only using sRGB if the texture is detected to be used in 3D. 2D rendering in Godot doesn't make use of sRGB.

@Calinou that's what I thought as well, but it's worth checking into. It may check for sRGB metadata to ensure that the conversion isn't applied twice.

Tried in 3.2.4 beta2, this is how the texture looks with sRGB detect or disabled

And this is enabled

Not sure if it's better or worse...

This was fixed by #40242 in 3.2.3-stable.

This was fixed by #40242 in 3.2.3-stable.


Differential clock

I am trying to build a base example for VC707 board. My first issue is that I have a differential clock input clk_p clk_n. Which is the cleanest way to integrate with Chips-2.0?

Hi,
Probably the best option is to create a wrapper in vhdl or verilog, that
instances the Chips output. You can instance an IBUFGDS in the wrapper to
convert the clock to single ended. This wrapper
https://github.com/dawsonjon/Chips-Demo/blob/master/source/atlys.vhd is
for a Spartan 6 card, so it will need some modifications, but it might be a
good starting point, it has gigabit ethernet (GMII) and UART interfaces.
Good luck with your project. Let me know if you have any other questions.
Jon
On 8 October 2015 at 15:30, Michele Renda<EMAIL_ADDRESS>wrote:

I am trying to build a base example for VC707 board. My first issue is
that I have a differential clock input clk_p clk_n. Which is the cleanest
way to integrate with Chips-2.0?
—
Reply to this email directly or view it on GitHub
https://github.com/dawsonjon/Chips-2.0/issues/35.

Indeed I learned a bit more about the Chips-2.0 and it was very simply solved adding a VHDL instance:
ibufgds_inst :	IBUFGDS		port map (I => clk_p, IB => clk_n, O => s_clk);
Thank you very much


Restore a column deleted by mistake through django-simple-history

Hi,
If I delete a column in the table by mistake, I hope to restore it through django-simple-history. If the data in the record table is also deleted synchronously, the data deleted by mistake cannot be recovered.

DSH doesn't support deleted columns. Only deleted rows.


Fix websocket malformed packet bug

Hi @mochi-co 👋🏻  Today I've spent some time with a colleague @svanharmelen, trying to understand the problem and search for the root cause.
We concluded that the problem is not with the client, as we tried to send the same amount of messages to Mosquitto (and also increased the test to 100.000 messages) which didn't give us any issues.
Next we looked at the websocket package that is used in your package and to rule things out we swapped it out for https://godoc.org/nhooyr.io/websocket. Funny enough this solved the issue, but as we were not convinced it's a bug in the Gorilla package and we didn't understand the root cause yet, we continued our search in listeners/websocket.go.
In there, we noticed in the Read method that you ended with a bufio.Read call and when looking up the documentation, we noticed that a single Read call does not guarantee to get all data up to the EOF.
When we swapped to using Gorrila's ReadMessage method, we found out the problem was gone. In that message ioutil.ReadAll is being called on the net.Conn reader.
However, since ioutil.ReadAll creates a new buffer, and then keeps increasing it's size as need, that might impact performance. Thus we came up with a slightly more convoluted solution which looks like the following:
	var n, br int
	for {
		br, err = r.Read(p[n:])
		n += br
		if err != nil {
			if err == io.EOF {
				err = nil
			}
			return n, err
		}
	}

P.S. Following community best practices, we also removed the naked returns from the Read and Write methods on wsConn, but let us know if you want that to be reverted...
Fixes #115

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 15 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.2%) to 98.171%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

listeners/websocket.go
0
15
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
4991

Relevant Lines:
5084

💛  - Coveralls

Just a quick note to say I have seen this and it’s wonderful work, I will check it for consistency this evening and hopefully merge for a v2.0.5 release.


Make smartagent/signalfx-forwarder compatible with k8s_tagger processor

This commit copies the source/reporter client IP from SFX span metadata
to Otel Resource as an attribute. This allows the k8s_tagger processor
to correctly identify k8s pods when they send data to
smartagent/signalfx-forwarder receiver.

There are no unit tests that make sure that the source/reporter client IP from SFX span metadata is copied
to Otel Resource as an attribute?

Thanks for testing @dmitryax. Fixed and added tests.

There are no unit tests that make sure that the source/reporter client IP from SFX span metadata is copied
to Otel Resource as an attribute?

Have added/updated tests. Was waiting for Dmitri to config this fixes the issue.

Also please add a line to Changelog


cargo install fails

Installing via cargo (cargo install vanity_gpg) (vanity_gpg v0.3.0, not the latest version) result in an error: error[E0432]: unresolved import 'clap::Clap'
Installing directly from the repo (version 0.3.1) works fine: cargo install --git https://github.com/RedL0tus/VanityGPG.git
I think that the cargo package must be updated to the latest version.

I've just published v0.3.2, please check it out. It should work fine now.

LOL it's actually fixed first in v0.3.1, but I forgot to publish that to crates.io 🤣

It now installs fine. Thank you!


Encoding Problem after building/compiling

after building a PL/SQL-Package in the database via the atom-build plugin i got some encoding issues.
For example ü, ö, ä turns into a ¿
Im not really sure, but i think that issues didn't exist in earlier versions.
Note: I set the default Encoding of atom to Windows 1252.
Edit: database encoding: WE8ISO8859P1
selected via:
select * from database_properties
where PROPERTY_NAME in ('NLS_CHARACTERSET')

Can confirm this problem.

Hmm, the character encoding and how it's displayed is not handled by build at all. Everything that is output from the command will be put as is in a div.
Can you create a minimal .atom-build.yml file which echoes the characters that doesn't work?

Bump @braintuts

Closing as inactive. Please re-open if you wish to pursue this further.


Comparators on simulation level

Steps to reproduce
I created a simulation as follows:
simulation = price_index_cube.setup_simulation(
    "Distance Simulation", base_scenario="1 km", replace=[m["Distance Threshold"]]
)

lvl["Distance Simulation"].comparator = tt.comparator.ASC

simulation.scenarios["5 km"] = 5
simulation.scenarios["15 km"] = 15
simulation.scenarios["10 km"] = 10
simulation.scenarios["20 km"] = 20

The comparator doesn't affect the ordering of the scenarios:

How can I achieve the ordering of 1km, 5km, 10km etc...?
Environment

atoti: 0.4.1
Python: 3.8.3
Operating System: win32

Currently I have to set it up as:
simulation = price_index_cube.setup_simulation(
    "Distance Simulation", base_scenario="01 km", replace=[m["Distance Threshold"]]
)

simulation.scenarios["05 km"] = 5
simulation.scenarios["15 km"] = 15
simulation.scenarios["10 km"] = 10
simulation.scenarios["20 km"] = 20

This is because the type of your simulation levels are strings, so alphabetically, "20 km" comes before "5 km"
you can use the first_members comparator to obtain the order you want:
lvl["Distance Simulation"].comparator = tt.comparator.first_members(
    ["1 km", "5 km", "10 km", "15 km", "20 km"]
)


Add log to file flag for server

On Windows, system services don't have stdout/stderr sent anywhere.  This coupled with recent packaging changes should enable advanced users to run ollama as a system service.
I'll leave this in draft until I have a chance to validate it actually works.

Turns out this isn't necessary if we use tools like nssm to wrap it.


[FEATURE] maybe we should add some decomposition to the generated code?

maybe we should add some decomposition to the generated code?
for example, in addition to the default export, also export each model and texture separately, by name.

This would be an incredible feature, especially when using with typescript.

sounds interesting. so you mean something like this?
export function Arms() {
  const { nodes, material } = useGLTF("model.glb")
  return ...
}

export function Legs() {
  const { nodes, material } = useGLTF("model.glb")
  return ...
}

export default function Model() {
  return (
    <group>
      <Arms />
      <Legs />

just not sure about the specifics and if it's doable. lots of questions come to mind. for instance, names can easily break javascript conventions.

Yes exactly. I can imagine there are lots of edge cases around doing this properly but it would be great to be able to run an exported scene from blender through gltfjsx and then selectively import objects into the scene (and get type errors if something has been changed).

you can edit the main component though and make its parts conditional, isn't that enough? either way, you can make a pr and then we can review it. there is zero chance that i will have the time for that right now.

@drcmda I'm doing that for now, if I find I encounter wanting to do this regularly I'll make a PR. Thanks for your work on this.

so you mean something like this?

exactly =)

one more concern would be how to treat n levels of nesting. if it's all about exposing "nodes" then each would just contain the mesh with the linked up geometry and material, but groups and their positioning would be lost in the named export. but yeah, make a flag and wire it into the code - i would probably accept it.


Hard coded action url

Why exactly do we have a hard coded value here? Should be taken from endpoints and not env
https://github.com/botfront/botfront/blob/faee3d91ac56df7e2046f1b4f95ba80bdc6ab274/botfront/imports/api/endpoints/endpoints.docker-compose.js#L11

This is the hard-coded default to populate endpoints.

And it IS in the endpoints and should be taken from there

@pheel, can this one be closed?

@pheel??

@pheel??


(some) Listeners don't work

Please provide as much details as possible... The more info provided the better
Description
I don't get the meetingEnded (nor meetingStarted) to work on IOS. SDKInitialized and meetingJoined works fine.
React Native version:
System:
OS: macOS 10.15.4
CPU: (8) x64 Intel(R) Core(TM) i7-6820HQ CPU @ 2.70GHz
Memory: 910.90 MB / 16.00 GB
Shell: 5.7.1 - /bin/zsh
Binaries:
Node: 14.3.0 - ~/.nvm/versions/node/v14.3.0/bin/node
Yarn: 1.22.4 - /usr/local/bin/yarn
npm: 6.14.5 - ~/.nvm/versions/node/v14.3.0/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
Managers:
CocoaPods: 1.9.1 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: iOS 13.5, DriverKit 19.0, macOS 10.15, tvOS 13.4, watchOS 6.2
Android SDK:
API Levels: 28, 29
Build Tools: 28.0.3, 29.0.0, 29.0.2, 29.0.3
System Images: android-28 | Intel x86 Atom_64, android-28 | Google Play Intel x86 Atom, android-29 | Google APIs Intel x86 Atom
Android NDK: Not Found
IDEs:
Android Studio: 4.0 AI-193.69<IP_ADDRESS>14223
Xcode: 11.5/11E608c - /usr/bin/xcodebuild
Languages:
Java: 1.8.0_252 - /usr/bin/javac
Python: 2.7.16 - /usr/bin/python
npmPackages:
@react-native-community/cli: Not Found
react: 16.11.0 => 16.11.0
react-native: 0.62.2 => 0.62.2
npmGlobalPackages:
react-native: Not Found
Steps To Reproduce

Create listener for meetingEnded that logs the result
Create, start and end a meeting

Expected Results
That the result appears in my log

I was also facing similar issues in Android bt startmeeting and joinMeeting returns promise. You can track results returned in promise.

Solution for android
open this file
<EMAIL_ADDRESS>comment the line no 234
//meetingPromise = null
RNZoomUsBridgeModule.java
@Override
public void onMeetingStatusChanged(MeetingStatus meetingStatus, int errorCode, int internalErrorCode) {
Log.i(TAG, "onMeetingStatusChanged, meetingStatus=" + meetingStatus + ", errorCode=" + errorCode + ", internalErrorCode=" + internalErrorCode);
    if (meetingPromise == null) {
    return;
    }

    WritableMap params = Arguments.createMap();

    if(meetingStatus == MeetingStatus.MEETING_STATUS_FAILED) {
    meetingPromise.reject(
            "ERR_ZOOM_MEETING",
            "Error: " + errorCode + ", internalErrorCode=" + internalErrorCode
    );
    meetingPromise = null;
    } else if (meetingStatus == MeetingStatus.MEETING_STATUS_DISCONNECTING) {

    sendEvent(reactContext, "meetingEnded", params);
       meetingPromise = null;
    } else if (meetingStatus == MeetingStatus.MEETING_STATUS_INMEETING) {

    sendEvent(reactContext, "meetingStarted", params);
    meetingPromise.resolve("Connected to zoom meeting");
    // meetingPromise = null;     <- this line

    } else {
    params.putString("eventProperty", "onMeetingStatusChanged, meetingStatus=" + meetingStatus + ", errorCode=" + errorCode + ", internalErrorCode=" + internalErrorCode);
    sendEvent(reactContext, "meetingStatusChanged", params);
    }
}

save the file
then clean your android build
i.e cd android ./gradlew clean
cd..
close metro bundler
close remote debugger (if open)
react-native run-android
now when you leave the meeting "meetingEnded" listner will trigger

Still same issue - meetingEnded listeners is not working in android