Provide an option in ExtensionTask to "only cross compile"

Background
When rake cross native gem RUBY_CC_VERSION=.... is used to create gems with pre-compiled binaries  for different platforms and ruby versions, all of the binaries are placed under a <gem lib directory>/<ruby version> directory. However, a "native" binary for the current ruby platform and version is also created, and it is placed in <gem lib directory>.
E.g., in the grpc-1.8.7-x86_64 gem, precompiled binaries are found in these locations:
./grpc-1.8.7-x86_64-linux/src/ruby/lib/grpc/2.2/grpc_c.so
./grpc-1.8.7-x86_64-linux/src/ruby/lib/grpc/2.4/grpc_c.so
./grpc-1.8.7-x86_64-linux/src/ruby/lib/grpc/2.0/grpc_c.so
./grpc-1.8.7-x86_64-linux/src/ruby/lib/grpc/grpc_c.so`
./grpc-1.8.7-x86_64-linux/src/ruby/lib/grpc/2.3/grpc_c.so
./grpc-1.8.7-x86_64-linux/src/ruby/lib/grpc/2.1/grpc_c.so

and the /grpc-1.8.7-x86_64-linux/src/ruby/lib/grpc/grpc_c.so binary is the "extra" "native" binary that I'm talking about here. The grpc binary loading process loads the binary under the directory of the current ruby version if it exists, and falls back to lib/grpc/grpc_c.so if it doesn't (the only time this is the case is for packages that were fetched and built from source).
Normally, having that extra lib/grpc/grpc_c.so in the package would not be a problem, since it's not even used anyways. But it turns out to interfere with certain software that doesn't know that it isn't used, because it's dynamically linked to the libruby.so.2.4 in the ruby 2.4.3 installation of rake-compiler-dock's Dockerfile and thus not portable (ldd thinks it's broken).
Suggestion
rake-compiler could provide an option on the ExtensionTask called, e.g., only_cross_compile (which defaults to false). If only_cross_compile was set, then rake-compiler would not generate the "extra" "native" binary, and it would only generate cross-compiled binaries under ruby version-specific directories.
E.g., binaries in the grpc-1.8.7-x86_64 gem would then only be found in these locations:
./grpc-1.8.7-x86_64-linux/src/ruby/lib/grpc/2.2/grpc_c.so
./grpc-1.8.7-x86_64-linux/src/ruby/lib/grpc/2.4/grpc_c.so
./grpc-1.8.7-x86_64-linux/src/ruby/lib/grpc/2.0/grpc_c.so
./grpc-1.8.7-x86_64-linux/src/ruby/lib/grpc/2.3/grpc_c.so
./grpc-1.8.7-x86_64-linux/src/ruby/lib/grpc/2.1/grpc_c.so

This might also be at least somewhat helpful to reduce package size as well.
I have an example patch in this commit.
I'd be happy to create a PR for this too.

Umm. It isn't occurred in Rronga. You can confirm by gem unpack https://rubygems.org/downloads/rroonga-7.1.1-x64-mingw32.gem .
Can you show full command lines to reproduce this?

It isn't occurred in Rronga

I see... this is interesting but I'm not sure what the cause is yet.

Can you show full command lines to reproduce this?

This is far from a minimal repro but the steps to reproduce using the grpc package build is:
# from a machine which has a RUBY_PLATFORM of x86_64-linux:
git clone https://github.com/grpc/grpc.git --recursive
cd grpc
bundle install
bundle exec rake gem:native # this will take a while, removing ruby versions and platforms from the cross-compilation matrix can speed it up.
cd pkg
gem unpack grpc-*-x86_64-linux.gem
# when inspecting the unpacked gem, grpc_c.so files can be found under version-specific directories like src/ruby/lib/grpc/2.5/grpc_c.so, but there will also be the undesired
src/ruby/lib/grpc/grpc_c.so file.

please let me know if there are any problems with this repro.

Thanks. I can reproduce this case.
How about this patch?
diff --git a/Rakefile b/Rakefile
index 1eac37dc55..dfeb063b0e 100755
--- a/Rakefile
+++ b/Rakefile
@@ -23,6 +23,7 @@ end

 # Add the extension compiler task
 Rake::ExtensionTask.new('grpc_c', spec) do |ext|
+  ext.no_native = true
   ext.source_pattern = '**/*.{c,h}'
   ext.ext_dir = File.join('src', 'ruby', 'ext', 'grpc')
   ext.lib_dir = File.join('src', 'ruby', 'lib', 'grpc')

You may like this patch:
diff --git a/Rakefile b/Rakefile
index 1eac37dc55..c79db2c61d 100755
--- a/Rakefile
+++ b/Rakefile
@@ -23,6 +23,7 @@ end

 # Add the extension compiler task
 Rake::ExtensionTask.new('grpc_c', spec) do |ext|
+  ext.no_native = true
   ext.source_pattern = '**/*.{c,h}'
   ext.ext_dir = File.join('src', 'ruby', 'ext', 'grpc')
   ext.lib_dir = File.join('src', 'ruby', 'lib', 'grpc')
@@ -32,12 +33,15 @@ Rake::ExtensionTask.new('grpc_c', spec) do |ext|
     'x86_64-linux', 'x86-linux',
     'universal-darwin'
   ]
-  ext.cross_compiling do |spec|
-    spec.files = %w( etc/roots.pem grpc_c.32.ruby grpc_c.64.ruby )
-    spec.files += Dir.glob('src/ruby/bin/**/*')
-    spec.files += Dir.glob('src/ruby/ext/**/*')
-    spec.files += Dir.glob('src/ruby/lib/**/*')
-    spec.files += Dir.glob('src/ruby/pb/**/*')
+  ext.cross_compiling do |cross_spec|
+    cross_spec.files -= %w( Makefile .yardopts )
+    cross_spec.files += %w( grpc_c.32.ruby grpc_c.64.ruby )
+    cross_spec.files += Dir.glob('src/ruby/bin/**/*')
+    cross_spec.files += Dir.glob('src/ruby/ext/**/*')
+    cross_spec.files -= Dir.glob('src/boringssl/**/*')
+    cross_spec.files -= Dir.glob('src/core/**/*')
+    cross_spec.files -= Dir.glob('include/**/*')
+    cross_spec.files -= Dir.glob('third_party/**/*')
   end
 end

@kou thanks a lot for looking into this. Indeed the first patch seems to work for me, and it also seems to reduce package size significantly by leaving out all of the source files.
BTW, the second patch seems to also work. But if I'm correct, that will effectively cause the same files to be copied into the cross-compiled gem package as are copied in currently (do I have a misunderstanding here?).

BTW, the second patch seems to also work. But if I'm correct, that will effectively cause the same files to be copied into the cross-compiled gem package as are copied in currently (do I have a misunderstanding here?).

I'm sorry but I can't understand what you say. (I'm not a native English speaker...)
The second patch just reduces the same logic in Rakefile and grpc.gemspec. The behavior isn't changed.
Can we close this issue?

The second patch just reduces the same logic in Rakefile and grpc.gemspec. The behavior isn't changed.

thanks, that answers my question :)
I think this can be closed now


Chore/remove vertx from resource service

Hey there and thank you for opening this pull request! 👋🏼
We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.
Details:
No release type found in pull request title "Chore/remove vertx from resource service". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - fix
 - hotfix
 - feat
 - feature
 - chore


Failing tests on non-english OS

This code is making the tests os-language dependent.
e.g. the german term would be "Der angegebene Registrierungsschl�ssel bzw. Wert wurde nicht gefunden"

Any idea how to fix this? We appreciate pull requests!

Sorry, no idea.

No, I just asked because:

the references file does not even exist any more
the ticket is currently opened
the ticket was changed Feb 14

I guess either the issue still exists and the reference should be changed or the issue should be closed.

Any idea how to fix this? We appreciate pull requests!

This is the reason we keep this issue open :wink:.

https://github.com/camunda/camunda-modeler/blob/master/app/lib/platform/windows/file-associations.js
This is where the file can be found now


No data in Big Query Fourkeys Deployment table

I am using Github as SCM and CloudBuild as CICD. I have integrate Github and Cloudbuild and successfully deploy application on CloudRun but those entry are not populated in BigQuery tables.

Please let me know if I need to change anything.

Hi @Sbhalsing0 -- let's work backwards one step: do you see data in the events_raw table where the source field contains "cloudbuild"?
If you do, then something's wrong with the view that generates deployments. If you don't, then something's wrong with the ingestion pipeline that populates events_raw.

@davidstanke
No data in the events_raw table where the source field contains "cloud build".

Hi @Sbhalsing0!
Are you still encountering this issue? It'd be difficult to pinpoint what could be going wrong here.
My recommendation is that you backup any BigQuery data you might already have and set up Four Keys infrastructure again, as the setup has changed slightly since this issue was opened.  Upon finishing the setup, be sure to use generate_data.py to verify that your event handler and parsers are setup successfully.
Please re-open this issue if you run into it once again.
Thanks for your patience!


[ui-core] v0.1.9

Bundle size will be reported once CircleCI build #643 finishes.

  Generated by :no_entry_sign: dangerJS against ec0fc7e62b052ef3171d38186339f90f381192e8


C++ 11 required to compile step095

Compiling step095 on MacOS gives me:
In file included from /Users/pierric/git/LearnWebGPU-Code/imgui/backends/imgui_impl_wgpu.cpp:31:
/Users/pierric/git/LearnWebGPU-Code/imgui/./imgui.h:263:5: error: unknown type name 'constexpr'
    constexpr ImVec2()                      : x(0.0f), y(0.0f) { }
    ^

Adding this to CMakeLists.txt fixes compilation:
set (CMAKE_CXX_STANDARD 11)

Indeed on macOS clang does not enable C++11 by default, and ImGui requires it. You fiw works, a slightly better solution is to set this flag only for the imgui target, in the CMakeLists that defines it:
set_target_properties(imgui PROPERTIES
	CXX_STANDARD 11
	CXX_STANDARD_REQUIRED ON
)

Great, thanks for the fix!


Switch to aws-sdk-go

https://github.com/awslabs/aws-sdk-go

use https://github.com/goamz/goamz instead of  launchpad and aws-sdk-go.


deep assign if nested fragment

#534 fix attempt
I am not sure it fixes all cases for this. However some guidance would be helpful since I'm not familiar with the codebase

Also I have no idea how to fix the TS errors

Merging here: https://github.com/apollostack/apollo-client/pull/669


jt400AS400 should be registered for runtime reinitialization

fixes https://github.com/apache/camel-quarkus/issues/5899
PR also adds missing *IT class and a few native buildItems.
I set flat-classpath to true, which is a workaround before finding a correct way of excxluding mock classes if -Dskip-mock-tests=true is set.

@jamesnetherton I'd like to try to fix the flat path correctly (to turn it on only for mocked tests) so I haven't created PR for 3.8.x so far.


Update integrations

@yurishkuro @dominikh are you both ok with these writeups? Corrections welcome and encouraged. Thanks.

s/Zipkin-compatible Jaeger tracing system/Zipkin-compatible tracing system Jaeger/
otherwise LGTM

@yurishkuro done (though I added a comma).


Panic when hosted zone is a subdomain

I'm getting a panic when my ingress resource tries to describe a host that's under a subdomain, i.e.
spec:
  rules:
  - host: services.dev.mydomain.com

I think the controller is trying to modify the Route53 record for mydomain.com, instead of dev.mydomain.com. But mydomain.com in not part of this account's Route53 (it is hosted elsewhere), and only the subdomain dev.mydomain.com is available for modification in Route53. Either this is the problem, or I'm doing something else completely wrong :)
Here's the error I'm seeing:
2017-05-01T19:57:18.360353209Z I0501 19:57:18.356997       1 event.go:217] Event(api.ObjectReference{Kind:"Ingress", Namespace:"default", Name:"services", UID:"36b845a6-2ea8-11e7-bbe6-060f29d431aa", APIVersion:"extensions", ResourceVersion:"8473", FieldPath:""}): type: 'Normal' reason: 'CREATE' Ingress default/services
2017-05-01T19:57:18.376081982Z I0501 19:57:18.376042       1 leaderelection.go:188] sucessfully acquired lease default/ingress-controller-leader
2017-05-01T19:57:19.357196268Z W0501 19:57:19.357089       1 queue.go:87] requeuing default/services, err deferring sync till endpoints controller has synced
2017-05-01T19:57:19.360285335Z W0501 19:57:19.360250       1 queue.go:87] requeuing kube-system/flannel-token-7mr23, err deferring sync till endpoints controller has synced
2017-05-01T19:57:29.460878489Z I0501 19:57:29.460788       1 log.go:62] [ALB-INGRESS] [default-services] [ERROR]: Unabled to locate ZoneId for %!s(*string=0xc4205fbd90).
2017-05-01T19:57:29.477453747Z I0501 19:57:29.477395       1 log.go:62] [ALB-INGRESS] [default-services] [ERROR]: Unabled to locate ZoneId for %!s(*string=0xc4205fbd90).
2017-05-01T19:57:29.477472523Z I0501 19:57:29.477415       1 log.go:48] [ALB-INGRESS] [default-services] [INFO]: Start ELBV2 (ALB) creation.
2017-05-01T19:57:30.014926314Z I0501 19:57:30.014836       1 log.go:48] [ALB-INGRESS] [default-services] [INFO]: Completed ELBV2 (ALB) creation. Name: k8s-dev-a721fba39cead27 | ARN: arn:aws:elasticloadbalancing:us-east-1:<redacted>
2017-05-01T19:57:30.015059577Z E0501 19:57:30.014974       1 runtime.go:64] Observed a panic: "invalid memory address or nil pointer dereference" (runtime error: invalid memory address or nil pointer dereference)

Hi @rob-cng,
What version of the controller image are you using?
We're actively developing this controller and recently added more elegant zone resolution. This sounds like #62, which was resolved in #74.
Could you try a recent version of the controller (see versions here) and let me know if the issue persists?
Thanks!

I was using 0.8, and switching to latest fixed the issue. Thanks!


ENH: Make automatic plugin-enabling on stage() optional.

Recall https://github.com/NSLS-II/ophyd/issues/245
I believe this is a non-breaking change --- it just adds a knob -- but I am not 100% confident that the change to detectors.py is correct because I am not sure what self.enable.get() returns.

:+1:

From earlier discussion: we should probably have a common Python soft-signal that allows us to enable/disable plugins and stop their stage_sigs from even being set. This may lead us into having more shared signals - which I'm hoping we can decide on at some point (like in https://github.com/klauer/hxntools/blob/ophyd0/hxntools/detectors/trigger_mixins.py#L28 )

I am working exactly on this piece of code here at SLAC...
What I did was just a check if self.enable not in self.stage_sigs: to
keep compatibility and if it is not then I set_and_wait self.enable.
It worked! ;)
One other thing that I noticed is that the data on the buffer is processed
even if you disable the plugin... which means... it finishes the work that
it was doing.
On Wed, Aug 2, 2017 at 12:04 PM Dan Allan<EMAIL_ADDRESS>wrote:

@danielballan commented on this pull request.
In ophyd/areadetector/plugins.py
https://github.com/NSLS-II/ophyd/pull/326#discussion_r130967385:

@@ -86,8 +89,9 @@ def init(self, *args, **kwargs):
port_name = C(EpicsSignalRO, 'PortName_RBV', string=True)

 def stage(self):

   # Ensure the plugin is enabled. We do not disable it on unstage.

   set_and_wait(self.enable, 'Enable')

   if self.auto_enable:

       # Ensure the plugin is enabled. We do not disable it on unstage.

       set_and_wait(self.enable, 'Enable')

If this was disabled to begin with, it should be disabled on unstage, a la
'stage_sigs'.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/NSLS-II/ophyd/pull/326#pullrequestreview-53900130,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHzmUfjqZC3Ex2AzDrZUICg1MJHSpGGtks5sUMgpgaJpZM4IkGTB
.

Codecov Report

Merging #326 into master will decrease coverage by 0.4%.
The diff coverage is 86.66%.

@@            Coverage Diff             @@
##           master     #326      +/-   ##
==========================================
- Coverage   91.19%   90.79%   -0.41%
==========================================
  Files          48       48
  Lines        6692     6702      +10
==========================================
- Hits         6103     6085      -18
- Misses        589      617      +28

Impacted Files
Coverage Δ

ophyd/tests/test_quadem.py
100% <100%> (ø)
:arrow_up:

ophyd/areadetector/detectors.py
100% <100%> (ø)
:arrow_up:

ophyd/tests/test_epicsmotor.py
90.52% <100%> (-7.37%)
:arrow_down:

ophyd/areadetector/plugins.py
92.46% <80%> (-0.33%)
:arrow_down:

ophyd/epics_motor.py
86.15% <0%> (-6.93%)
:arrow_down:

ophyd/status.py
90.69% <0%> (-1.75%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbeed67...e153a1e. Read the comment docs.

Big thanks to @hhslepicka for a useful offline conversation in this.


Set aspect-ratio for package-icon images

Keeps aspect-ratio as a square, as the recommendation suggests.
Before:

After:

Relates to #9694. A potential UI exploit would allow folks to have very long vertical icons in the search results.

Copying this data from https://github.com/NuGet/NuGetGallery/pull/9694#issuecomment-1750767972 to help the reviewers:
Let me add some data to the mix. The Burkus.Mvvm.Maui example appears to be the most extreme example today (lowest aspect ratio).

Query for internal reference
NiPackageIcons
| where ResultType == "Available"
| extend Ratio = round(1.0 * Width / Height, 4)
| where Ratio < 0.75 or Ratio > 1.25
| join kind=inner NiPackageVersions on Identity
| where IsLatestSemVer2
| project Id, Version, FileSize, Width, Height, Ratio
| order by Ratio asc
| take 5

Id
Version
FileSize
Width
Height
Ratio

Burkus.Mvvm.Maui
0.1.0-preview3
3589
64
229
0.2795

KinsonDigital.CASL
1.0.0-preview.16
3899
71
162
0.4383

AgileTea.Persistence.Mongo
3.0.0-beta.6
3220
150
335
0.4478

TimeyWimey
1.0.0
8277
60
131
0.458

Karamunting.Android.SavviSingh.DateRangePicker
1.2.0
99796
1152
2465
0.4673

Additionally, the display on the package details page is different (we enforce a square render instead of allowing rectangles):

Visual Studio appears to preserve aspect ratio in both the search results and the details pane

Our docs provide no guidance that I see about whether a square icon is allowed but it does recommend 128x128, which only 18% of icons actually follow.

Query for internal reference
let DimensionSummary = NiPackageIcons
| where ResultType == "Available"
| join kind=inner NiPackageVersions on Identity
| where IsLatestSemVer2
| summarize Count = count() by Width, Height
| extend Ratio = round(1.0 * Width / Height, 4)
| extend Dimensions = strcat(Width, "x", Height)
| order by Count desc;
let Total = toscalar(DimensionSummary | summarize sum(Count));
let Q1 = DimensionSummary
| summarize
    ["IDs with icon"] = Total,
    ["Square %"] = round(100.0 * sumif(Count, Ratio == 1.0) / Total, 2);
DimensionSummary
| take 5
| extend ["% of total"] = round(100.0 * Count / Total, 2)

Width
Height
Count
Ratio
Dimensions
% of total

128
128
20879
1
128x128
18.82

64
64
12587
1
64x64
11.34

256
256
10080
1
256x256
9.08

512
512
9050
1
512x512
8.16

200
200
5607
1
200x200
5.05

About 13% of icons are non-square so it seems reasonable to think critically about how we want to handle non-square icons.

Query for internal reference
let DimensionSummary = NiPackageIcons
| where ResultType == "Available"
| join kind=inner NiPackageVersions on Identity
| where IsLatestSemVer2
| summarize Count = count() by Width, Height
| extend Ratio = round(1.0 * Width / Height, 4)
| extend Dimensions = strcat(Width, "x", Height)
| order by Count desc;
let Total = toscalar(DimensionSummary | summarize sum(Count));
DimensionSummary
| summarize
    ["IDs with icon"] = Total,
    ["Non-square %"] = round(100.0 * sumif(Count, Ratio != 1.0) / Total, 2)

IDs with icon
Non-square %

110956
13.36

For me this is reasonable change, we shouldn't let someone to abuse icon ratio to attract unnecessary attention.
Alternative would be we just reject the packages with extreme aspect-ratio values during upload, but I'm not sure how it works for remotely hosted icons, if I understand correctly they can change it later.

Can't we just specify max-height and max-width on the icon and let the browser resize the image keeping proportions?

Can't we just have max-height and max-width specified for the icon element and let the browser resize the image keeping proportions?

@khalidabuhakmeh what are your thoughts on this?

Thank you very much for your feedback. We appreciate you letting us know about the problem you encountered. Based on community feedback, this is currently low priority for us.
If you feel differently please let us know, you can reopen this PR or create new one.


if theres an error, the plugin inserts the error text into vim

heres a gif showing the issue.
i think it makes more sense to put the error message into the vim statusline section, where i can just look at it instead of it covering everything up

Just force stdout and stderr to /dev/null...
replace line 8 in vim-glslViewer.vim with
exec "!" . g:glslViewer_command . " " . bufname("%") . " -l 2>1& > /dev/null"


Support IPv6

Is your feature request related to a problem? Please describe.
We'd like to use Pinniped in IPv6 Kubernetes clusters. I'm opening this issue to track things that need to be fixed for Pinniped to work on IPv6 environments.
After testing Pinniped within an IPv6 cluster, here is a list of things that we have come across.

Pinniped-supervisor does not honor the HTTP_PROXY/HTTPS_PROXY/NO_PROXY environment variables. This is not directly an IPv6 issue, but in our testing we were required to use a proxy to use some IPv4 services.

The upstreamwatcher creates a client with a new http.Transport and it doesn't set many of the fields the DefaultTransport sets. Important to us is the Proxy field, but it may also be valuable to set many of the other fields the DefaultTransport sets, such as Timeout fields.

Certain areas of the pinniped codebase assume that if an IP address is provided it is an IPv4 address. For example, a quick search for splitting on colons results in things like this. It isn't reliable to split on colons because IPv6 uses colons as a delimiter.

Golang does have a helper function that could be used instead: net.SplitHostPort.
We didn't end up hitting this case ourselves because we have been using FQDNs in most places, which seems to work. So a deeper search may be required to root out all the places were we assume an IP address is an IPv4 address.

The pinniped cli hardcodes the <IP_ADDRESS> localhost address as the callback listen address.

This may not be a big deal because users of the pinniped cli should be able to bind to an IPv4 loopback address on their machines, even if they are working with an IPv6 only Kubernetes environment.

Are you considering submitting a PR for this feature?
Yes

How will this project improvement be tested?
It seems like it would be valuable to have an E2E test(s?) that could run on a Kind cluster that has been deployed as an IPv6 environment. Open to any suggestions here for additional things to test.

How does this change the current architecture?
It shouldn't. This is just fixing parts of the codebase that assumed IPv4 addresses and honoring the proxy environment variables.

How will this change be backwards compatible?
It should still support IPv4.

How will this feature be documented?
Not sure if any additional documentation is necessary other than saying IPv6 is now supported. Open to any suggestions here.

For example, a quick search for splitting on colons results in things like this. It isn't reliable to split on colons because IPv6 uses colons as a delimiter.

Another thing to watch out for is the opposite, when joining host and port, best to use net.JoinHostPort. See this related PR from another project, for example: https://github.com/kubernetes-sigs/cluster-api/pull/4045/files

After testing Pinniped within an IPv6 cluster

Adding some notes with additional details on what we tested:

Pinniped IPv6 Investigation
How to Deploy for IPv6

kind create cluster --name pinniped-supervisor --config ../ipv6-kind.yaml
Add your user to the Consent Screen
https://console.cloud.google.com/apis/credentials/consent?project=tanzu-xcc
Install certstrap
Run the ./install-pinniped.sh
Clone https://github.com/christianang/pinniped and checkout the
proxy-envvar-patch branch
Build the pinniped image by running the following command in the pinniped
directory (if necessary as this was already done and pushed):DOCKER_BUILDKIT=1 docker build --tag projects.registry.vmware.com/xcc/pinniped:dev .

Push the image to our xcc registry (if necessary)
Edit the pinniped-supervisor deployment to use the
projects.registry.vmware.com/xcc/pinniped:dev image
Update your /etc/hosts on the workstation to forward
pinniped-supervisor.kokoni.info to localhost: ::1
Start kubectl port-forward for the pinniped-supervisor pod to port 443 on your
workstation:sudo kubectl port-forward -n pinniped-supervisor \
  pinniped-supervisor-889549f5f-jq496 --address ::0 443:8443

Configure your Firefox Proxy to talk to the workstation, ask in slack if you
need help
Runpinniped --kubeconfig /tmp/sup.kubeconfig get kubeconfig \
--kubeconfig-context kind-pinniped-supervisor \
--oidc-skip-browser > /tmp/pinniped-kubeconfig

Runkubectl --kubeconfig /tmp/pinniped-kubeconfig get pods -n \
pinniped-concierge

Go through the login flow
You can open the link presented in Firefox, it should forward you to Google
login
The link you get after forwarding will fail to load, copy that and curl it
form the workstation
See authentication succeed, but see an error with authorization

Runkubectl --kubeconfig /tmp/sup.kubeconfig create clusterrolebinding \
user-can-read --clusterrole view --user<EMAIL_ADDRESS>

Runkubectl --kubeconfig /tmp/pinniped-kubeconfig get pods -n \
pinniped-concierge

See pods

Notes

Ingress to the cluster didn't work on IPv6 (using MetalLB). To workaround this
we had to use the following port-foward command to port forward our
workstation to the pinniped-supervisor. We also updated our /etc/hosts file
to point pinniped-supervisor.kokoni.info to ::1.

sudo kubectl port-forward -n pinniped-supervisor \
  pinniped-supervisor-889549f5f-jq496 --address ::0 443:8443

After testing Pinniped within an IPv6 cluster

Adding some additional notes on the testing we did to produce the notes above /cc @adobley @tylerschultz

Pinniped IPv6 Investigation
Note: some of the steps below are necessary due to the fact that we're using dual-stack jumpboxes on a private IPv6 network.
How to Deploy for IPv6
Create an IPv6 kind cluster and deploy pinniped

create a file ipv6-kind.yaml with the contents:kind: Cluster
apiVersion: kind.x-k8s.io/v1alpha4
networking:
  ipFamily: ipv6

kind create cluster --name pinniped-supervisor --config ../ipv6-kind.yaml
We used google for the OIDC provider and added ourselves as users to the Consent Screen: https://console.cloud.google.com/apis/credentials/consent?project=projectname
Install certstrap
Run the ./install-pinniped.sh (contents below)
Update your /etc/hosts on the workstation to forward  pinniped-supervisor.test to localhost: ::1::1 pinniped-supervisor.test

Update pinniped to use a squid proxy
These steps are necessary in our case because IPv6 pods are unable to resolve DNS addresses on our network. This should not strictly be necessary if you can connect directly to providers via IPv6. However, there may be a number of use cases where support for an HTTP Proxy configuration would be valuable.

Clone https://github.com/christianang/pinniped and checkout the  proxy-envvar-patch branch
Build the pinniped image by running the following command in the pinniped directory:DOCKER_BUILDKIT=1 docker build --tag yourregistry/pinniped:dev .

Push the image to our xcc registry (if necessary)
Edit the pinniped-supervisor deployment to use the yourregistry/pinniped:dev image
Edit the supervisor deployment to use a squid proxy (see add'l notes below for installing/configuring squid)kubectl set env deployment/pinniped-supervisor -n pinniped-supervisor \
    HTTP_PROXY="http://[fc00:f853:ccd:e793::1]:3128" \
    HTTPS_PROXY="http://[fc00:f853:ccd:e793::1]:3128" \
    NO_PROXY="localhost,::/0,<IP_ADDRESS>,<IP_ADDRESS>,<IP_ADDRESS>"

Note: fc00:f853:ccd:e793::1 is the address typically assigned to the bridge device used by kind/docker -- may need to double-check and replace.
Edit the concierge deployment to use the squid proxy as wellkubectl set env deployment/pinniped-concierge -n pinniped-concierge \
    HTTP_PROXY="http://[fc00:f853:ccd:e793::1]:3128" \
    HTTPS_PROXY="http://[fc00:f853:ccd:e793::1]:3128" \
    NO_PROXY="localhost,::/0,<IP_ADDRESS>,<IP_ADDRESS>,<IP_ADDRESS>"

Test it out

Start kubectl port-forward for the pinniped-supervisor pod to port 443 on your  workstation:sudo kubectl port-forward -n pinniped-supervisor \
  pinniped-supervisor-$GUID --address ::0 443:8443

Configure your Firefox Proxy proxy via your SSH session to the workstation (see add'l notes below)
Runpinniped --kubeconfig /tmp/sup.kubeconfig get kubeconfig \
--kubeconfig-context kind-pinniped-supervisor \
--oidc-skip-browser > /tmp/pinniped-kubeconfig

Runkubectl --kubeconfig /tmp/pinniped-kubeconfig get pods -n \
pinniped-concierge

Open the link presented in your local browser, which will forward you to provider's login (Google in our case)
After the forwarding will fails to load, copy the link from the browser and curl it form the workstation
See authentication succeed, but see an error with authorization

Runkubectl --kubeconfig /tmp/sup.kubeconfig create clusterrolebinding \
user-can-read --clusterrole view --user '{your_email_id}'

Runkubectl --kubeconfig /tmp/pinniped-kubeconfig get pods -n \
pinniped-concierge

See pods

install-pinniped.sh:
#! /bin/bash

# https://pinniped.dev/docs/tutorials/concierge-and-supervisor-demo/

set -e -u -o pipefail
set -x

DOCKERHUB_PROXY="${DOCKERHUB_PROXY:-docker.io}"
clientid=$OIDC_PROVIDER_CLIENT_ID
clientsecret=$OIDC_PROVIDER_CLIENT_SECRET
cn=pinniped-supervisor.test
issuer=https://$cn

kind get kubeconfig --name pinniped-supervisor > /tmp/sup.kubeconfig

kubectl --kubeconfig /tmp/sup.kubeconfig apply -f https://get.pinniped.dev/latest/install-pinniped-supervisor.yaml

rm -rf /tmp/${cn}*

certstrap --depot-path /tmp init --passphrase '' --common-name "${cn}_ca"
certstrap --depot-path /tmp request-cert --passphrase '' --common-name "${cn}" --domain "${cn}"
certstrap --depot-path /tmp sign --passphrase '' --CA "${cn}_ca" "${cn}"

tls_crt=$(cat "/tmp/${cn}.crt" | base64 -w0)
tls_key=$(cat "/tmp/${cn}.key" | base64 -w0)

set +e
kubectl --kubeconfig /tmp/sup.kubeconfig delete --context kind-pinniped-supervisor --namespace pinniped-supervisor secret my-federation-domain-tls
set -e
cat <<EOF | kubectl --kubeconfig /tmp/sup.kubeconfig create --context kind-pinniped-supervisor --namespace pinniped-supervisor -f -
apiVersion: v1
kind: Secret
metadata:
  name: my-federation-domain-tls
type: kubernetes.io/tls
data:
  # the data is abbreviated in this example
  tls.crt: |
        $tls_crt
  tls.key: |
        $tls_key
EOF

set +e
kubectl --kubeconfig /tmp/sup.kubeconfig delete --context kind-pinniped-supervisor --namespace pinniped-supervisor federationdomains my-federation-domain
set -e
cat <<EOF | kubectl --kubeconfig /tmp/sup.kubeconfig create --context kind-pinniped-supervisor --namespace pinniped-supervisor -f -
apiVersion: config.supervisor.pinniped.dev/v1alpha1
kind: FederationDomain
metadata:
  name: my-federation-domain
spec:
  issuer: $issuer
  tls:
    secretName: my-federation-domain-tls
EOF

set +e
kubectl --kubeconfig /tmp/sup.kubeconfig delete --context kind-pinniped-supervisor --namespace pinniped-supervisor secret my-oidc-identity-provider-client
set -e
kubectl --kubeconfig /tmp/sup.kubeconfig create secret generic my-oidc-identity-provider-client \
  --context kind-pinniped-supervisor \
  --namespace pinniped-supervisor \
  --type secrets.pinniped.dev/oidc-client \
  --from-literal=clientID=$clientid \
  --from-literal=clientSecret=$clientsecret

set +e
kubectl --kubeconfig /tmp/sup.kubeconfig delete --context kind-pinniped-supervisor --namespace pinniped-supervisor oidcidentityproviders my-oidc-identity-provider
set -e
cat <<EOF | kubectl --kubeconfig /tmp/sup.kubeconfig create --context kind-pinniped-supervisor --namespace pinniped-supervisor -f -
apiVersion: idp.supervisor.pinniped.dev/v1alpha1
kind: OIDCIdentityProvider
metadata:
  name: my-oidc-identity-provider
spec:
  issuer: https://accounts.google.com
  claims:
    username: email
  authorizationConfig:
    additionalScopes: ['email']
  client:
    secretName: my-oidc-identity-provider-client
EOF

function update_image_repo_and_kubectl_apply() {
  resourceURL=$1
  curl -L "${resourceURL}"| \
    sed "s~image: \(.*\)$~image: ${DOCKERHUB_PROXY}/\1~" | \
    kubectl --kubeconfig /tmp/sup.kubeconfig apply -f -
}

set +e
kubectl --kubeconfig /tmp/sup.kubeconfig delete ns metallb-system
set -e

cat <<EOF | kubectl --kubeconfig /tmp/sup.kubeconfig apply --context kind-pinniped-supervisor --namespace pinniped-supervisor -f -
---
apiVersion: v1
kind: Service
metadata:
  labels:
    app: pinniped-supervisor
  name: pinniped-supervisor
  namespace: pinniped-supervisor
spec:
  ports:
  - port: 443
    protocol: TCP
    targetPort: 8443
  selector:
    app: pinniped-supervisor
  sessionAffinity: None
  type: ClusterIP
EOF

kubectl --kubeconfig /tmp/sup.kubeconfig apply -f https://get.pinniped.dev/latest/install-pinniped-concierge.yaml

audience="$(openssl rand -hex 8)"
cat <<EOF | kubectl --kubeconfig /tmp/sup.kubeconfig apply --context kind-pinniped-supervisor -f -
apiVersion: authentication.concierge.pinniped.dev/v1alpha1
kind: JWTAuthenticator
metadata:
  name: my-jwt-authenticator
spec:
  issuer: $issuer
  audience: $audience
  tls:
    certificateAuthorityData: $(cat "/tmp/${cn}_ca.crt" | base64 -w0)
EOF

Stand up a squid proxy server
If running in an environment where IPv6 is not routable to the internet, setup an HTTP proxy.
On the dualstack jumpbox:
sudo apt update && sudo apt install -y squid

Configure squid to allow traffic.
sudo vim /etc/squid/squid.conf

Edit the line that allows localhost to allow all
- http_access allow localhost
+ http_access allow all

Comment out the deny all line and add a line to cause DNS on squid to prefer IPv4.
- http_access deny all
+ # http_access deny all
+ dns_v4_first on

Restart squid proxy
sudo systemctl restart squid

Configuring Firefox to proxy via your workstation's SSH session
in your ~/.ssh/config for the destination, add : DynamicForward 1080, e.g.:
Host jumpbox
  Hostname <IP_ADDRESS>
  User myusername
  ForwardAgent yes
  KeepAlive yes
  DynamicForward 1080

Use the following settings in Firefox

Wow, these notes are awesome! Thanks @mcwumbly @christianang @tylerschultz !

@mattmoyer looks like this got auto-closed. should it be repoened per your comment here?:

Before we officially call #586 (IPv6 support) closed, I think we'll need to to set up a proper IPv6 acceptance testing environment

Reviewed on 12-7-21. This is part of our Roadmap.


Post reverts to draft after some time if left on the publish page

Issue Summary
Publishing a post and then leaving it for some time (30 minutes to an hour), it will revert to a draft even after it has been published. This does not happen if you navigate back to the main posts page.
Steps to Reproduce

Create a post using the new ghost editor
Publish the post by clicking "Publish"
Confirm that you want to publish the post
Stay on the page that tells you that it is published.
Go do something else for 30 or so minutes - you must keep the tab open - you can visit other sites or whatnot
Now go back to the main post's page and you will see that it has reverted to a "draft"

Ghost Version
Latest
Node.js Version
v16.20.0
How did you install Ghost?
Standard production install - Debian 11, Mariadb, Nginx
Database type
Other
Browser & OS version
Firefox (Fedora) v114.0
Relevant log / error output
No response
Code of Conduct

[X] I agree to be friendly and polite to people in this repository

Thanks for letting us know. We're investigating some similar reports, did you experience this when using the beta editor or the original editor?

Thanks for letting us know. We're investigating some similar reports, did you experience this when using the beta editor or the original editor?

Beta Editor - it doesn't seem to happen with the original editor.

@Johnnyyyy1234 This has been fixed in v5.52.3 🙂


[Feature Request] List all your uploaded avatar's IDs

A feature like this would be beneficial for things like mass setting avatar IDs on pedestals with VRWorldToolKit an ability to filter between public and private will be appreciated aswell

I agree would like this aswell as for it to show there publication status i know its possible just needs to filter out useless json extras

I have already made avatar ID's more visible with this commit https://github.com/pypy-vrc/VRCX/commit/34efa9f24b3ab5450e075ed8a474f60e31bc6788  but if you still want an export list I will add it.

would still like the export list and on another note for commit 34efa9f you should Hide the avatar id behind a hidden element unless selected if not already done hide text unless clicked

Why would it need to be hidden, I don't see any benefit in that anymore.

Entire point of the api update was to stop people you didnt want to get avatars you didn't want to share with them that includes publics maybe your streaming on discord and happen to select one of your avatars or another's on accident?

https://github.com/pypy-vrc/VRCX/commit/857f2f48141993ee6e8835769faeb336111b554e


Missing ndarray dev dependency

npm install && npm test fails because ndarray isn't included as a dev dependency. I can fix this totally trivially, but if I'm gonna contribute, I'd like to get into a pattern where I don't have to fudge a bunch of stuff. I'm newish to the node world. Is there a way to fix this aside from adding the dev dependency and submitting a pull request?

I think a PR is the best way to do it, if you send me a patch I can just merge it in later on tonight (going to be driving all day).


Mutable access to neighbors weights.

Is there a particular reason that there are no iterators to access neighbor weights? There exists WalkNeighbors that can be used kind of like an iterator, and there is a true Iterator to access all node weights, but there is no Iterator for Neighbor weights.
Would implementing something like NeighborsWeightsMut be possible? I did some attempts, but I kept having lifetime errors.

The main reason is that walking and accessing the graph is much more general, and is intended to cover all use cases.
Every borrowing iterator inevitably covers a specific pattern of borrowing and is not as general. For example, an iterator of mutable references to neighbor's weights will exclude any other access to graph structure or other graph weights, so it is just useful in special cases. So you see why the general graph walking is provided as a first priority.

The WalkNeighbors struct could of course learn convenience methods that access weights more directly.

Any hints on how to achieve that? I'll could try to implement it. For now i've been stuck on different variations of the NodeWeightsMut iterator and the Neighbors iterator.

Question: Does it have to be an iterator?

To implement a convenience method would be to add a new method next to the ones here https://docs.rs/petgraph/0.4.3/src/petgraph/graph.rs.html#1769-1773

I managed to make an implementation of such an iterator. Would you like to have it merged into the code base?


ansible.errors.AnsibleUndefinedVariable: 'haproxy_stats_listener_options' is undefined

haproxy_stats_listener_options is not set by default but referenced by the template causing a failure.
should this be uncommented and defaulted as haproxy_stats_listener_options: [] ?
https://github.com/uoi-io/ansible-haproxy/commit/3abed7d99712f97e209cbab151a0fe3dd92c1bad#diff-23e21b6c89468f7534697ad091835b3ee5e0213b37ace489488234e5a9548ec4R95

Hi @bcg62
Thanks for the issue, feel free to create a PR, I'll review it and merge it.
Otherwise, I'll try to fix that soon as possible.
:+1:


allow container separator name to be specified on command line

container names seem to have been docker version and platform dependent in the past:
e.g. mw1_38_4-mw-1 has "-" as the name separator
allow to specify on command line just in case there is an awkward setting where this needs to be setable

This is obsolete we try both "_", "-"


How to get traceid and use it in log (log4j/log4j2)

Our developers wants do some manually collecting  with logs, so we need get the trace id first , and then output it  with log4j/log4j2,   is there a way to easily do this ,maybe like skywalker? : )

Hi @sunface
Is this what you're looking for?

It seems very similar to what i want, here is another question: in which version has this feature been supported? we are now using 1.7.0-snapshot now

Since 1.1.2 I think. You'll be able to use it with 1.7.0-SNAPSHOT.

That's really helpful , thanks :) . In this doc,  only shows configuration for log4j and logback，so what about log4j2?

I don't think we have this supported for log4j2 unfortunately.
If you'd like to make the plugin for log4j2 to have it supported and throw us a PR, that would be fantastic :)


Fix unit tests to use the local timezone [main]

Description of the Change
Some unit tests recently added expected an EST timezone. This fix has it use the local environment timezone.

Unit tests don't seem to be rerunning on the latest commit as the test failure messages are old. Closing this PR to open a fresh one.


Default webpack config causes wrong version of a node module to be resolved

Preflight Checklist

[ x] I have read the contribution documentation for this project.
[x ] I agree to follow the code of conduct that this project follows, as appropriate.
[x ] I have searched the issue tracker for a bug that matches the one I want to file, without success.

Issue Details

Electron Forge Version:

6.0.0-beta.52

Electron Version:

v9.1.0

Operating System:

Pop!_OS 20.04 LTS

Expected Behavior
All node_module resolution works correctly, the same as when using node.js directly.
Actual Behavior
Due to this webpack setting line:
https://github.com/electron-userland/electron-forge/blob/master/packages/plugin/webpack/src/WebpackConfig.ts#L160
webpack will ignore un-hoisted node_module directories and only see the modules in root node_modules directory.
I noticed this when a different version of a node module caused a crash, but in reality, I suspect this could have more devious behaviors. Eg. everything appears to be working, but you are unexpectedly using a version of a module with subtly different API or surprising behaviors.
Is there a reason why the default config is using this overridden resolve.modules configuration?
To Reproduce
Clone: https://github.com/panta82/electron-forge-webpack-config-issue-demo
Then yarn and yarn start.
The issue in this case is that fs-extra module uses newer version of jsonfile, which gets installed in its own node_modules. But that directory is not seen due to the webpack config mentioned above.

Oh wow. I think I've been bitten by this hard.  Several things are starting to make sense now.

Duplicate #2386
Solution: In webpack.main.config.js, change resolve.modules to ['node_modules']
resolve: {
    ...
    modules: [
      'node_modules'
    ]
},


rbd: set scheduling interval on snapshot mirrored image

Mirror-snapshots can also be automatically created on a periodic basis if mirror-snapshot schedules are defined. The mirror snapshot can be scheduled globally, per-pool, or per-image levels. Multiple mirror-snapshot schedules can be defined at any level.
To create a mirror-snapshot schedule with rbd, specify the mirror snapshot schedule add command along with an  optional pool or image name; interval; and optional start time:
The interval can be specified in days, hours, or minutes using d, h, m suffix respectively. The optional start-time can be specified using the ISO 8601 time format. For example:
$ rbd --cluster site-a mirror snapshot schedule add --pool image-pool --image image1 24h 14:00:00-05:00

fixes: #2119
Note:-  Documentation will be covered in #2117
Signed-off-by: Madhu Rajanna<EMAIL_ADDRESS>

Snapshot scheduling testing
apiVersion: replication.storage.openshift.io/v1alpha1
kind: VolumeReplicationClass
metadata:
  name: rbd-volumereplicationclass
spec:
  provisioner: rook-ceph.rbd.csi.ceph.com
  parameters:
    mirroringMode: snapshot
    schedulingInterval: "12"
    schedulingStartTime: "16:18:43"
    replication.storage.openshift.io/replication-secret-name: rook-csi-rbd-provisioner
    replication.storage.openshift.io/replication-secret-namespace: rook-ceph

When invalid interval is provided
d7d5-11eb-a951-0242ac110006 GRPC error: rpc error: code = Internal desc = rados: ret=-22, Invalid argument: "Invalid interval (12ad)"

when invalid startTime is provided
E0628 05:59:47.154659       1 utils.go:172] ID: 95 Req-ID: 0001-0009-rook-ceph-0000000000000001-5cf49c95-d7d5-11eb-a951-0242ac110006 GRPC error: rpc error: code = Internal desc = rados: ret=-22, Invalid argument: "Invalid start time 26:18:43: hour must be in 0..23"

Only scheduling time is provided in volumereplicationclass
E0628 06:01:11.661248       1 utils.go:172] ID: 110 Req-ID: 0001-0009-rook-ceph-0000000000000001-3f70ca01-d4c4-11eb-a392-0242ac110005 GRPC error: rpc error: code = InvalidArgument desc = schedulingStartTime parameter is supported only with schedulingInterval

When only interval is provided
sh-4.4# rbd mirror snapshot schedule ls --pool=replicapool --image=csi-vol-5cf49c95-d7d5-11eb-a951-0242ac110006 --format=json
[{"interval":"12m","start_time":""}]

When both interval and scheduling start time is provided
sh-4.4# rbd mirror snapshot schedule ls --pool=replicapool --image=csi-vol-5cf49c95-d7d5-11eb-a951-0242ac110006 --format=json
[{"interval":"12m","start_time":"16:18:00"}]

Just a quick initial look, definitely needs an updated version in go.mod instead of hacking vendor/. Releases of ceph-csi should only refer to released versions of go-ceph, so there needs to be an other issue/PR that rebases go-ceph later.

This is not hacking anything in vendor, rbd/admin is already available in go-ceph 0.10.0 release. till now rbd/admin has not imported, This PR is importing it.

Just a quick initial look, definitely needs an updated version in go.mod instead of hacking vendor/. Releases of ceph-csi should only refer to released versions of go-ceph, so there needs to be an other issue/PR that rebases go-ceph later.

This is not hacking anything in vendor, rbd/admin is already available in go-ceph 0.10.0 release. till now rbd/admin has not imported, This PR is importing it.

Oh, really?! Sorry about the confusion then :see_no_evil:

/test ci/centos/mini-e2e-helm-sc/k8s-1.20

/test ci/centos/mini-e2e-helm-sc/k8s-1.20

Kindly ignore, want to test something

/retest ci/centos/mini-e2e-helm/k8s-1.20

/retest ci/centos/mini-e2e-helm/k8s-1.20

 etcdserver: request timed out

/retest ci/centos/mini-e2e-helm/k8s-1.21

/retest ci/centos/mini-e2e-helm/k8s-1.21

Jul  5 12:13:11.973: INFO: Error getting pvc in namespace: '': etcdserver: request timed out Jul  5 12:13:11.973: INFO: failed to create PVC (rbd-13180): failed to get pvc: etcdserver: request timed out

/retest ci/centos/mini-e2e/k8s-1.21

Apart from https://github.com/ceph/ceph-csi/pull/2216#discussion_r664360483, this looks good to me :+1:

Apart from #2216 (comment), this looks good to me

This is already answered at https://github.com/ceph/ceph-csi/pull/2216#discussion_r664364858 @humblec anything else is required?

@mergifyio rebase

/retest ci/centos/mini-e2e-helm/k8s-1.19

/retest ci/centos/mini-e2e-helm/k8s-1.20

/retest ci/centos/mini-e2e-helm/k8s-1.20

X Exiting due to GUEST_PROVISION: Failed to start host: creating host: create: Error creating machine: Error in driver during machine creation: IP not available after waiting: machine minikube didn't return IP after 1 minute

/retest ci/centos/mini-e2e-helm/k8s-1.20

failed to create PVC with error failed to get pvc: etcdserver: request timed out


Added A Drumkit Project

This is my Drum kit project made using HTML, CSS & JAVASCRIPT.
It is a website where you can play using by clicking mouse and keyboard strokes.

This is my contribution for HacktoberFest 2021.
Please review my PR #61
@manjunani

Please add the Hactoberfest-accepted tag.
@manjunani


Missing example on MLTable

In text there is mentioned:
"For a full example of using an MLTable, see the [Working with MLTable notebook]."
but in brackets, there is no lonk to MLTable notebook,
section:
https://docs.microsoft.com/en-us/azure/machine-learning/how-to-use-data?tabs=use-local%2Crw-blob#table

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b06f8322-5448-9ece-0764-3bd7b5ac6058
Version Independent ID: dc853c35-3129-aad7-3b42-e4755cf376a3
Content: Work with data using SDK v2 (preview) - Azure Machine Learning
Content Source: articles/machine-learning/how-to-use-data.md
Service: machine-learning
Sub-service: core
GitHub Login: @Blackmist
Microsoft Alias: larryfr

@michalmar Thanks for spotting this. @Blackmist Could you please  help to update the section to update with the correct hyperlink?

Thanks for reporting @michalmar . I'll check with engineering to see what the correct link should be.

@michalmar
From speaking with the PM team, the notebook hasn't merged into the main branch yet and is undergoing some changes. The original is at https://github.com/Azure/azureml-examples/blob/samuel100/mltable/sdk/assets/data/working_with_mltable.ipynb. The changes are in PR - https://github.com/Azure/azureml-examples/pull/1358.
Once the PR changes have been merged to the main branch, I'll update the link to point to it.


Icon button style is broken in version 9

Reproduction link
https://stackblitz.com/edit/ng-zorro-antd-button-v9-0-0-beta-3
Steps to reproduce
Create button with an icon but no text.
What is expected?
The button should be a square.
What is actually happening?
The button is a rectangle.

Environment
Info

ng-zorro-antd
9.0.0-beta.3

Browser
Chrome 80

The bug occurs with the new beta version and Angular 9.
This worked as expected with latest stable version (8.5.1) and Angular 8: https://stackblitz.com/edit/ng-zorro-antd-button-v8-5-1

https://stackblitz.com/edit/ng-zorro-antd-button-v9-0-0-beta-3-uhmta9?file=src/app/app.component.html

@vthinkxie, your project shows a circular icon button, what I am talking about is the square icon button.

ng-zorro-antd v9 follow the antd v4 design spec, you can modify the less to customize the theme if you want.

Oh, ok, I don't really know how this spec works.
What I did is pick the example from the documentation:

So does this mean that this type of button won't no longer be available in v9 ?

sorry for misunderstanding your repo
we will add this type back soon.


Update table with select causes ambiguous column error

Version
1.26.0
What happened?
First time I tried field name "id" in both table, it's very common in realworld, but it said "id" is ambiguous, so I change the id to bid in second table, but still get wrong...
Also tried sqlc.args(xxx), but will failed either.
For your reference, the sql clause should not failed.
Relevant log output
sqlc generate failed.
# package
query.sql:6:40: column reference "bid" is ambiguous

Database schema
CREATE TABLE authors (
  id   BIGSERIAL PRIMARY KEY,
  name text      NOT NULL,
  bio  text
);

CREATE TABLE authors2 (
  bid   BIGSERIAL PRIMARY KEY,
  name text      NOT NULL,
  bio  text
);

SQL queries
-- name: CreateAuthor2 :one
UPDATE authors SET (
  name, bio
) = (
  select name, bio from authors2 where bid=$2
) where id=$1
RETURNING *;

Configuration
{
  "version": "2",
  "sql": [{
    "schema": "schema.sql",
    "queries": "query.sql",
    "engine": "postgresql",
    "gen": {
      "go": {
        "out": "db"
      }
    }
  }]
}

Playground URL
https://play.sqlc.dev/p/3ef93462e0cc926c18e7d79bbdd1ce8239fe3b1c4afed1026cd357502a8c7adf
What operating system are you using?
Linux, macOS
What database engines are you using?
PostgreSQL
What type of code are you generating?
Go

Similar problem here, but with a different input:
Version
1.26.0
Relevant log output
# package db
queries/queries.sql:5:7: column reference "id" is ambiguous

From playground:
sqlc generate failed.

2024/08/08 15:33:36 sqlite.convertLiteral: Unknown node type *parser.Expr_literalContext
2024/08/08 15:33:36 sqlite.convertLiteral: Unknown node type *parser.Expr_literalContext
2024/08/08 15:33:36 sqlite.convert(case=default): Unknown node type *parser.Expr_unaryContext
# package
query.sql:5:7: column reference "id" is ambiguous

Database schema
CREATE TABLE IF NOT EXISTS USERS (
  ID INTEGER PRIMARY KEY,
  DOCUMENT INTEGER,
  REMOVED_AT TEXT,
  FOREIGN KEY (DOCUMENT) REFERENCES DOCUMENTS (ID)
);

CREATE TABLE IF NOT EXISTS DOCUMENTS (
  ID INTEGER PRIMARY KEY,
  REMOVED_AT TEXT
);

SQL queries
-- name: RemoveDocument :execrows
UPDATE DOCUMENTS
SET
  removed_at = CURRENT_TIMESTAMP
WHERE id = ?1
  AND removed_at IS NULL
  AND id NOT IN (SELECT document FROM USERS WHERE document IS NOT NULL);

Configuration
version: "2"
sql:
  - engine: "sqlite"
    queries: "./queries"
    schema: "./migrations"
    gen:
      go:
        out: "."
        package: "db"

Playground URL
https://play.sqlc.dev/p/906eac25119af6f519b77983cfe4a67e5aa41465e76dbcdbe08af6c8b5b033e3
What operating system are you using?
Linux
What database engines are you using?
SQLite
What type of code are you generating?
Go

Also having this issue, as above, tried aliasing to no avail.
Version
v1.27.0
Relevant log output
line 71:2 no viable alternative at input 'UPDATE\n\tEvents AS e\nSET\n\te.'
line 78:3 no viable alternative at input 'Entries'
# package models
sql/queries/events.sql:1:1: no viable alternative at input 'Entries'

Database schema
-- +goose Up
CREATE TABLE IF NOT EXISTS Events (
	Id INTEGER PRIMARY KEY,
	Name TEXT NOT NULL,
	Description TEXT NOT NULL,
	Visible INTEGER NOT NULL DEFAULT (1) CHECK (Visible IN (0, 1)),
	Location TEXT REFERENCES Locations(Name),
	EventDateTime INTEGER NOT NULL CHECK (EventDateTime > strftime('%s', 'now')),
	CreatedAt INTEGER NOT NULL DEFAULT (strftime('%s', 'now')),
	UpdatedAt INTEGER
) STRICT;

-- +goose Up
CREATE TABLE IF NOT EXISTS Entries (
	Id INTEGER PRIMARY KEY,
	Name TEXT NOT NULL,
	Description TEXT,
	UserId TEXT NOT NULL REFERENCES Users(Id) ON DELETE CASCADE,
	EventId INTEGER NOT NULL REFERENCES Events(Id) ON DELETE CASCADE,
	Category TEXT NOT NULL REFERENCES Categories(Name) ON DELETE CASCADE,
	Score INTEGER CHECK (Score BETWEEN 0 AND 10),
	CreatedAt INTEGER NOT NULL DEFAULT (strftime('%s', 'now')),
	UpdatedAt INTEGER
) STRICT;

SQL queries
-- name: ToggleEventVisibility :one
UPDATE
	Events AS e
SET
	e.Visible = 1 - e.Visible
WHERE
	e.Id = ? AND
	e.Id NOT IN (
		SELECT DISTINCT
			t.EventId
		FROM
			Entries AS t
	)
RETURNING
	COUNT(*);

Configuration
version: "2"
sql:
  - engine: "sqlite"
    queries: "./sql/queries/*"
    schema: "./sql/schema"
    gen:
      go:
        package: "models"
        out: "./internal/models"

Playground URL
https://play.sqlc.dev/p/c8f1b46ed9a1b6cdf7a2ccecd1ec32b79aa1cdee3d8e80f4b1b5f6c7ec1ba3f6
What operating system are you using?
OS 1:
Distributor ID:	Debian
Description:	Debian GNU/Linux 12 (bookworm)
Release:	12
Codename:	bookworm
OS 2:
Apple M1
ProductName:    macOS
ProductVersion: 14.5
BuildVersion:   23F79
What database engines are you using?
SQLite
What type of code are you generating?
Go


Folded code automatically unfolded by moving the cursor up/down

Does this issue occur when all extensions are disabled?: Yes

VS Code Version:  1.79.2
OS Version:  Windows_NT x64 10.0.22621

Steps to Reproduce:

fold a block of code by ctrl - (Windows)
press arrow down key (it will unfold automatically)

Dear Visual Studio Code Team,
I would like to suggest an enhancement to the code folding behavior in Visual Studio Code. Currently, when moving my cursor up/ down from the folded line, the code automatically unfolds, which may not be desirable for users who prefer manual control over code folding.
I propose the addition of an option to control the automatic code unfolding behavior through a boolean setting, allowing users to choose whether code should unfold automatically or not. This option could be accessible in the Visual Studio Code settings, enabling users to customize their code folding experience according to their preferences.
 However, the automatic unfolding on moving the cursor up/down can sometimes disrupt the flow, especially for users who are accustomed to other editors or IDEs where this behavior is not present.
By providing the option to disable automatic code unfolding, Visual Studio Code can cater to a broader range of users, including those who prefer manual control over their code folding. This enhancement would improve the overall usability of the editor and make it more adaptable to different coding workflows.
Thank you for considering this feature request. I believe it would greatly benefit Visual Studio Code users, especially those who rely on code folding for efficient navigation and comprehension of their code.
Sincerely,
@IAmTahazzot

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.79.2. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.79.2. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

Not solved!

Please use the Start Extension Bisect command to see if the problem is being caused by an extension you installed.

Please use the Start Extension Bisect command to see if the problem is being caused by an extension you installed.

Thanks for you valuable time,
The technical issue at hand pertains to a particular extension, namely vscodevim.vim-1.25.2, which is causing an unfavorable disruption. The current predicament evokes a sense of dismay as Vim has become an indispensable tool for coding 😢, while simultaneously appreciating the benefits of the VSCode environment. Prior experiences with WebStorm and PhpStorm have been positive, yet the allure of VSCode remains.
I don't have any problem with VIM in WebStorm/ PHPStorm, thought VIM extension in VSCode won't be the problem. I was wrong 😔.
I am uncertain about the availability of any developer behind this extension to resolve the issue pertaining to the vscodevim.vim-1.25.2 extension.

/causedByExtension
VS Code"s Report Issue option from the Help menu can help you report this to the extension author.

This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the marketplace for VS Code. See also our issue reporting guidelines. If you don't know which extension is causing the problem, you can run Help: Start extension bisect from the command palette (F1) to help identify the problem extension.
Happy Coding!


Cobertura for delta changes testing

Hi,
I already post about the cobertura issue in my last post,
https://github.com/jashkenas/backbone/issues/3887
I also need to do report generation for my delta changes
Thanks in advance.

Hi jridgewell,
Can I know why you close this without any reply?

Any chance to have automatic responses to the new issues saying the usual Backbone/Stackoverflow thing? Maybe like this?


Add support for format switching to the pluginLogger

What would you like to be added?
Include a  setFormatter function in the internal/logger/logger.go (pluginLogger) package to allow switching between text, json, and logstash messages to match the functionality of the internal logger package.
See this conversation in PR #1258 for conext and this link for an example.
Anything else you would like to add?
No response
Are you willing to submit PRs to contribute to this feature?

[X] Yes, I am willing to implement it.

discussed in community meeting, please sync offline with @binbin-li


Fixes issue #175

Stops a crash from happening when the value isn't found during decoding.

....Tests needed to verify the fix 😉

@0xTim I don't think we really need a test to verify that Vapor doesn't crash when you force unwrap.  It just changes from a force unwrap to a throw.  Also, I don't know exactly how to trigger that.  I just knew force unwrapping is bad and so fixed that for him.

I think I'm gonna let you do this one, @tanner0101 .  I'm not entirely sure that code is really just saying it got nil and so I'm not sure this is the right value to throw.  The "fix" got him running quick as he's just pointing at the branch, but I'll let you implement the proper solution.  Thanks and sorry.

With regards to a test - I completely disagree. This was allowed to cause a crash because there was no test in place to ensure that it didn't. Tests aren't just there to ensure that code in PRs in valid, they're also there to stop regressions happening in the future.

@0xTim , @tanner0101 , @grosch I created a somewhat reduced test case here: https://github.com/vapor/postgres-kit/issues/175#issuecomment-602119597
hope that helps

This has been fixed on master and a DecodingError is thrown now.


specifying IP Group addresses in format combinations

The referenced docs.microsoft.com page specifies the following: "An IP Group can have a single IP address, multiple IP addresses, or one or more IP address ranges." That first "or" implies that single or multiple addresses cannot be combined with address ranges in a single IP Group.  I was curious if that implied exclusion is the case.  Upon further research, I found that the example here, https://docs.microsoft.com/en-us/azure/firewall/create-ip-group#create-an-ip-group---azure-powershell,  shows that a single address and a range can be combined in an IP Group definition.
I suggest the specified sentence on the referenced page be modified to something like, "An IP Group can have a single IP address, multiple IP addresses, one or more IP address ranges, or addresses and ranges in combination."

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9f9791cb-ba50-98bf-8831-5e03b568c9f3
Version Independent ID: 9f4d1a49-9c81-b0b8-ee85-87c5f8a0dae3
Content: IP Groups in Azure Firewall
Content Source: articles/firewall/ip-groups.md
Service: firewall
GitHub Login: @vhorne
Microsoft Alias: victorh

Thank you for your feedback! We will review and update as appropriate.

Hello @brucelangston, Thank you for your feedback. I have made the suggested change and it will go live in next 24 hours. Thank you!


Identify packaged builds with date and commit hash

Signed-off-by: Victor Porof<EMAIL_ADDRESS>

This depends on #71 which awaits review.


Fixes #1911

Fixes #1911

Docs Build status updates of commit c37315c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-conceptual/azps-6.4.0/install-az-ps.md
:white_check_mark:Succeeded
View (azps-6.4.0)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


failAsyncPlatform called under valid conditions

failAsyncPlatform is always called for AsyncParsableCommand with AsyncParsableCommand subcommands running on platforms macOS 10.15, macCatalyst 13, iOS 13, tvOS 13, watchOS 6, or above with package requirements at or above the aforementioned versions. This is due to a faulty platform check which asserts that the desired platforms are available and then throws an error when they are available.
ArgumentParser version:
main branch.
Swift version:
swift-driver version: 1.62.15 Apple Swift version 5.7.2 (swiftlang-<IP_ADDRESS>.5 clang-14<IP_ADDRESS>)
Target: arm64-apple-macosx13.0

Checklist

[x] If possible, I've reproduced the issue using the main branch of this package
[x] I've searched for existing GitHub issues

Steps to Reproduce

Create an AsyncParsableCommand root command with at least one AsyncParsableCommand subcommand.
Specify a minimum platform version at or above macOS 10.15, macCatalyst 13, iOS 13, tvOS 13, or watchOS 6.
Attempt to run in a debug configuration

Expected behavior
Command executes successfully
Actual behavior
failAsyncPlatform is called and execution stops due to a fatal error.

It seems that what this logic is intended to do is check if the specified platforms are unavailable, but I'm not sure why such a check would be needed as AsyncParsableCommand itself annotated with @available(macOS 10.15, macCatalyst 13, iOS 13, tvOS 13, watchOS 6, *) and attempting to conform to it on a platform where it isn't available should throw a compiler error.

Thanks! Would be great to clarify this in the error message.


all CVs -- check for consistency with Martin and Denis

all CVs
Denis points out that the frequency, table_id, and realm CVs are not complete (or inconsistent with Martin's.  We need to check for correctness.

@dnadeau4 @taylor13 please indicate what requires changing, or where this information can be obtained so we can maintain consistency

@taylor13 @dnadeau4 @martinjuckes we are awaiting these details to be finalised the following outputs, see http://clipc-services.ceda.ac.uk/dreq/index.html
for e.g. table_id/miptable
We are going to have to double check realm, and possibly others..

A duplicate of #51, closing


🏗 Add list view toggle to discover details screen

Add a list view to the discover details screen, similar to the search results screen. We probably want to make this style of screen generic so it can be used on both discover details and search results as well as any screens in the future that may have a similar style.

Closed by #1062. Thanks @Dlewis89 🥳


[YUNIKORN-2541] Upgrade golang.org/x/net for CVEs

What is this PR for?
Update golang dependencies for CVEs
What type of PR is it?

[X] - Improvement

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2541
The jira was closed but skipped the release repo and dependabot complains about the CVE

How should this be tested?


switch to python.org installers for Python on Mac OS

My Python environment randomly died again today, so I decided to try to install the latest Python 3.6 with pyenv:
$ brew update && brew upgrade pyenv
<snip>
$ pyenv install 3.6.8
python-build: use openssl from homebrew
python-build: use readline from homebrew
Downloading Python-3.6.8.tar.xz...
-> https://www.python.org/ftp/python/3.6.8/Python-3.6.8.tar.xz
Installing Python-3.6.8...
python-build: use readline from homebrew

BUILD FAILED (OS X 10.14.2 using python-build 20180424)

Inspect or clean up the working tree at /var/folders/w2/fp50813135gbpm3xcf4q7wc40000gn/T/python-build.20190219100425.63416
Results logged to /var/folders/w2/fp50813135gbpm3xcf4q7wc40000gn/T/python-build.20190219100425.63416.log

Last 10 log lines:
  File "/private/var/folders/w2/fp50813135gbpm3xcf4q7wc40000gn/T/python-build.20190219100425.63416/Python-3.6.8/Lib/ensurepip/__main__.py", line 5, in <module>
    sys.exit(ensurepip._main())
  File "/private/var/folders/w2/fp50813135gbpm3xcf4q7wc40000gn/T/python-build.20190219100425.63416/Python-3.6.8/Lib/ensurepip/__init__.py", line 204, in _main
    default_pip=args.default_pip,
  File "/private/var/folders/w2/fp50813135gbpm3xcf4q7wc40000gn/T/python-build.20190219100425.63416/Python-3.6.8/Lib/ensurepip/__init__.py", line 117, in _bootstrap
    return _run_pip(args + [p[0] for p in _PROJECTS], additional_paths)
  File "/private/var/folders/w2/fp50813135gbpm3xcf4q7wc40000gn/T/python-build.20190219100425.63416/Python-3.6.8/Lib/ensurepip/__init__.py", line 27, in _run_pip
    import pip._internal
zipimport.ZipImportError: can't decompress data; zlib not available
make: *** [install] Error 1

I'm sure I could dig through all the dependencies and get it to build properly, but I feel like we shouldn't have to build our own Python binaries to use it on Mac OS X. Indeed, python.org offers pre-built installers that I have never found to fail: https://www.python.org/downloads/mac-osx/
This is a draft PR for switching our recommended Python installer for Mac OS from pyenv to python.org. That also requires settling on something other than pyenv to manage virtual environments.
To be clear, if you have a setup that works for you, of course don't change it on my account. But for new installs -- or if you're running into issues with pyenv after routing Mac OS upgrades -- the installers from python.org might help.

I should add that https://github.com/caktus/django-project-template already recommends use of virtualenvwrapper, so it's a bit odd that we documented something else for Mac OS here anyways...


Company group page list

The company group page shows production and payment associated with each of its companies, but the project list does not show any project (ie. any associated with companies within the group).
http://resourceprojects.org/group/573f80b09469380100398226

Is this still happening?

yes, project list is still empty for company groups.


Fix type issue introduced by #28

Commit #28 changed apply_rotary_embed to have dtype parameter with default float32, and forces attention softmax to be done float32. Since attention doesn't specify the dtype parameter when calling apply_rotary_embed, and the output matmul doesn't convert back from float32 to match the values type, this is an issue if you're running BF16.
This specifies the existing xq.dtype for the dtype parameter when calling apply_rotary_embed (alternatively, we could cast keys to float32 in scores = torch.matmul(xq, keys)), and casts scores to match values at the output matmul.

@Arrabonae could you take a look


changes

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Hi, I'm sorry but what is the intention of this change?


Minimum Difficulty of a Job Schedule

https://leetcode.com/problems/minimum-difficulty-of-a-job-schedule

Top-down DP easier than bottom-up, as usual.


Update dependencies

This should resolve the current kramdown security alert (CVE-2020-14001).
I tested these changes locally and the slide deck still works. 👍

@parkerbxyz Thanks for addressing this. Why did you add vendor/ to the gitignore? Is the intent to ignore any cached versions of existing gems, and how does this relate to the CVE?

@ericalloyd Great questions and presupposition!
The generally accepted recommendation (e.g. "best practice") is to not commit dependencies, so we add it to the .gitignore.  We don't want to bloat the repo size or duplicate history that occurred elsewhere (CVE repos, for instance); if someone wants them, they can get them elsewhere (source).
This being said, some people very much disagree with that notion and think that things should be able to build self-sufficiently, or that you should have a "backup" in case a dependency disappears--that's the whole point of vendor.
This doesn't really align with the trajectory of open source software development (even by/with private of public businesses), and software is generally moving away from revoking things like this that would cause issues. Ultimately, in this case, I think @parkerbxyz took into account the fact that vendoring can be very messy and it can bog a repo down, and we simply don't need the history bloat in this repo.
@parkerbxyz do you want to chime in? @ericalloyd does that check out to you?

Thanks, @allthedoll! ✨

Is the intent to ignore any cached versions of existing gems, and how does this relate to the CVE?

Great question, @ericalloyd! Adding vendor/ to .gitignore doesn’t directly relate to the CVE.
The only file that needed to be changed to fix the vulnerable dependency and resolve the security alert was Gemfile.lock. To update the lock file and test your changes, you have to install the dependencies locally with script/setup or bundle install. This creates thousands of files and adds them to vendor/.

Ultimately, in this case, I think @parkerbxyz took into account the fact that vendoring can be very messy and it can bog a repo down, and we simply don't need the history bloat in this repo.

This is exactly right. These were some of my considerations:

These dependencies are only necessary to run the project locally
This repo is simply a template for a GitHub training activity that uses GitHub Pages (i.e. not intended to be run locally)

With those points in mind, I decided to ignore vendor/ rather than adding thousands of new files to this repo.
I hope this helps! Let me know if you think we should reconsider this approach.


command not available on Mac

command installed, command not found.
squirple:~ dietrich$ node --version
v0.8.18
squirple:~ dietrich$ npm --version
1.3.1
squirple:~ dietrich$ npm list | grep html
├──<EMAIL_ADDRESS>│ ├──<EMAIL_ADDRESS>squirple:~ dietrich$ html
-bash: html: command not found

I had to run npm link html to get the command html at my shell. Don't know if that's the proper way to set that up or not...


Allow working with tasks that have "other" values

Can dataview store the "data-task" attribute for tasks to allow filtering beyond completed?
For example:
- [>] deferred
- [?] still interesting?
- [-] cancelled
- [R] under review
- [!] important

Yep. Already know how to handle styling/rendering. ;)
Thank you!

closing in favor of the other

@blacksmithgu On a similar note, what about a query setting to change how tasks are checked in dataview.
dv.taskList(..., char onClickInsert)

the onClickInsert argument would accept any char that would be used within - [here]

That's rather restrictive IMO. Something like #1048 seems like a better fit.

I can see something like
dv.taskList(..., {
  selector: () => "X"
});

Where "selector" more broadly is an asynchronous function that allows you to return what the check should be given the task + current state. This may be nice to implement immediately as a workaround until I implement #1048 .

Hi somebody knows how to filter custom tasks status like [f] ,[*], [?] in Obsidian tasks plugin?

This is dataview, not tasks. As such, it's unlikely you'll get an answer here.

Here for you (and to prove @AB1908 wrong 😈)


Support for ES6++/Traceur types and annotations

Traceur has built in support for types and annotations. These are not part of the ES6 standard, however some projects are beginning to use them nonetheless (because Traceur enables you). I think there might be some discussion about adding them to ES7, which could be why they appear in Traceur.
I don't believe support for this belongs in JSHint, but is there any other way one can extend JSHint so that the linter doesn't complain when it sees syntax such as below?
// Annotations
@Inject(Foo)
function bar(foo) {}

// Types
function bar(name: String) {
}

++ on this one as well, or at least a fork specifically for AtScript

:+1:


Responsive header overlay images (srcset etc.)

Header images tend to be very large, often measuring several megabytes in size. Using responsive images, they can be reduced by significant factors for smaller displays (which tend to have slower connection too), potentially to the tune of 90%.
Support for this could be added by something like
header:
  overlay_image: /assets/images/unsplash-image-1.jpg
  overlay_image_mid: /assets/images/unsplash-image-1-mid.jpg
  overlay_image_small: /assets/images/unsplash-image-1-small.jpg

(Of course if mid/small aren't specified, the behavior would stay the same as it is now)

I'm with you that responsive images are an important optimisation to make. I do this with my own site.
Just not convinced the added complexity is worth it for the theme since there is really no good way to do it without a plugin or extra tooling. YAML variables go down the path of extra maintenance for the user to.
I'm really into Gatsy a newish static site generator that uses React. It has some really nice transformer plugins that take care of writing img elements with the appropriate srcset markup and generating sized images with Sharp.
 Something I haven't seen done with Jekyll yet. Unless you count custom Liquid tags which isn't ask that elegant and pollutes the source content making it less portable.

I agree that automatic generation would be the holy grail, but like you said Jekyll doesn't support it yet and extra plugins or tooling might complicate things.
What I'm suggesting is a manual approach where the user adds the YAML variables I mentioned above, and creates the scaled image sets himself. Sure that adds a bit more maintenance, but users who don't use this feature will be none the wiser.
My use case, which should be a fairly common one going by the WordPress theme, is a single header image that's present in all blog page. It should be a simple one-time matter to create a few scaled versions and configure.

I'm probably starting to sound like a broken record with all these requests, but I'm trying to balance a lot of things. Every new feature or enhancement has a cost, and this one is fairly high in my book.
Sure adding some extra YAML variables seems like the lowest cost of the bunch as it can be opt'd in. But doing so introduces a mess of Liquid spaghetti code for something I really don't think many people will go to the trouble of using.
Not to mention it'll be a messy solution as srcset is used for img elements. You're asking for support to the "overlay image" which doesn't use an img element at all. The images are added via inline CSS which uses a completely different syntax for supporting "background" responsive images.
And once it is advertised that the theme can support "responsive" header images, the expectation would be to do that elsewhere... and rightfully so.
I'd be up for supporting responsive images that were triggered via a Jekyll plugin that did all the heavy lifting as far as image generation and possibly markup are concerned. The issue there is I've used all of the available solutions and they all kind of stink and have drawbacks in their own way.
 Nothing comes close to what Gatsby is doing with its modern toolset and I'm not one for adding half-baked features into my projects.
This is another one of those features that Wordpress has spoiled people as you can pretty much set it and forget... something that just isn't the case with Jekyll. I think that's were the friction I'm facing comes from with the theme. Features like this are more of a framework slash infrastructure thing versus something at the theme level. Jekyll has the hooks to do it, but the plugins aren't really there to support it. And I know zero about Ruby to help in that regard.

You could also use a service like Cloudinary (they have a free tier) to serve up responsive images. Without modifying the theme you could load their Javascript, point it at the feature image class and it'll automatically generate responsive images.

The only thing I disagree with is your all-or-nothing approach. If you have a low hanging fruit case you can handle (don't know if header images can be classified as such) I think it's totally cool, and no further "expectations" have to be assumed or accepted on your part.
Cloudinary looks really cool, I will check it out. I knew CloudFlare were doing this but not on the free tier. Looks like a bunch of Israeli guys too, maybe I'll get special treatment ;)

So in case anyone is interested, here's how you use Cloudinary with header (hero) images:

Sign up to Cloudinary and upload your image of choice (highest quality you have)
Remove existing header image definitions from your _config.yml
Add the following to your _config.yml:

footer_scripts:
  - /assets/js/main.min.js
  - https://cdnjs.cloudflare.com/ajax/libs/cloudinary-core/2.3.0/cloudinary-core-shrinkwrap.min.js
  - /assets/js/images.js

Create /assets/js/images.js with the following content:

var cl = cloudinary.Cloudinary.new({cloud_name: "YOUR_CLOUD_NAME"});
var img = cl.image("YOUR_IMAGE_NAME",
{
    width: "auto",
    dpr: "auto",
    responsive: "true",
    crop: "scale",
    responsive_placeholder: "blank"
});
$(img).addClass("page__hero-image");

$heroDiv = $('

');
$heroDiv.append(img);
$heroDiv.insertAfter(".masthead");

cl.responsive();

(substituting YOUR_CLOUD_NAME and YOUR_IMAGE_NAME with the proper Cloudinary values)
@mmistakes looks OK?


Feature request: Add "validate" command

For a script I'm currently writing it would be nice to have an option to just validate a version string. Would it be possible to add something like semver validate 0.1.0-dev+001? And as a result it could return version 0.1.0-dev+001 does match the semver scheme. That would be really nice :)

You could just check for the return code with $?, if it's zero then it's in a valid form.
Give it a try

@WoLfulus that was a nice idea! Thank you 🙏


Add multi-selection support to dropdown widget

The WidgetMultiSelection should work almost the same way as WidgetSelection, but (obviously) allow selecting multiple choices (it does not close after click at choice), and the picked items are put in List - and this list should be displayed with vector widget, because we want to allow reordering picked choices.

This task is automatically imported from the old Task Issue Board and it was originally created by Paweł Grabarz.
Original issue is here.

Step 3: Support for multi-selection
Delivery requirements:
The implementation should be refined to allow a multi-selection of entries. The information if the widget should allow multi-selection should be delivered from the engine together with the information that a particular input should be displayed as a drop-down widget.
See the widget metadata design to learn more: https://github.com/enso-org/design/blob/main/epics/widgets/drop-downs/dynamic-widgets.md

Refinement notes:

Recognizing what options are selected should be simple text matching of vector's elements code (like it is in single-choice right now).
Now we assume the widget always produces a vector (it may try to read non-vector as a single value, but any change would turn it to vector)
Let's also add API for Vector AST node and use it in WidgetVector as well (see TODO there)


Release v0.13.0

I looked at the changes since the v0.12.0 release and didn't spot any breaking changes, but I figured since there were quite a few changes that maybe it warranted a minor version bump (as opposed to a patch bump).

Codecov Report

Merging #2715 (8399cae) into master (6b4e80b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2715   +/-   ##
=======================================
  Coverage   93.91%   93.91%
=======================================
  Files          87       87
  Lines        6329     6329
  Branches     1309     1309
=======================================
  Hits         5944     5944
  Misses        355      355
  Partials       30       30

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b4e80b...8399cae. Read the comment docs.

I think we should merge PR #2712 before a release. As is, all those new AMS environments will write a parse error given default rendering options.

Does KA still load MathJax as a backup? After this release, it should try to do without.

@ronkok it does unfortunately.  We're still on 0.11.x.  I'm sure we'll upgrade at some point in the new year at which point we'll test all of our content against the new version to see if we still need the MathJax fallback.

I'm going to close this and will recreate it once #2712 has been reviewed and merged.

@kevinbarabash Is there any reason not to release v0.13.0?

Does anyone happen to know if there are any pending tasks before a 0.13 release? I see that https://github.com/KaTeX/KaTeX/pull/2712 got merged, should I add a new release PR?

@ronkok not that I'm aware of.  @ChrisZieba while you could create a release PR you won't be able to do the publish and I don't think we've ever tried the release process with multiple people doing different parts of it.

I've created a new PR for the 0.13.0 release, see #2824.

I looked at the changes since the v0.12.0 release and didn't spot any breaking changes, but I figured since there were quite a few changes that maybe it warranted a minor version bump (as opposed to a patch bump).

Is there a changelog?

@ice1000 Yes, you'll want to look at both the release notes and this release's migration guide.

Thanks!


Add document for CA1851

Hi,
I checked in a new analyzer in Roslyn Analyzer repo
PR in roslyn-analyzer repo
Design in the runtime repo
And this is the document for it

Ah, I forget this PR in the last few weeks, will update it soon.


[FLINK-17470][scripts] Use timeout only if present (osx compat)

The scripts were causing error messages like this
Stopping taskexecutor daemon (pid: 43659) on host RobertsbabaMac2.localdomain.
/Users/robert/Projects/tmp-release-1.12/flink/flink-dist/target/flink-1.12-SNAPSHOT-bin/flink-1.12-SNAPSHOT/bin/flink-daemon.sh: line 98: timeout: command not found
Stopping taskexecutor daemon (pid: 43403) on host RobertsbabaMac2.localdomain.
/Users/robert/Projects/tmp-release-1.12/flink/flink-dist/target/flink-1.12-SNAPSHOT-bin/flink-1.12-SNAPSHOT/bin/flink-daemon.sh: line 98: timeout: command not found
Stopping standalonesession daemon (pid: 40906) on host RobertsbabaMac2.localdomain.
/Users/robert/Projects/tmp-release-1.12/flink/flink-dist/target/flink-1.12-SNAPSHOT-bin/flink-1.12-SNAPSHOT/bin/flink-daemon.sh: line 98: timeout: command not found

I tested the fix on two macs, one with timeout, one without.

@aljoscha could you review this?

Sorry, should have mentioned the failing IT case. Lmk once you confirmed locally.

Everything looks good!

Thx for the review. Merging.


[BUG] Product Search Bar is not working

Description of the Bug
The search functionality can be implemented by simply filtering the products available in the current state.

i want to work on this issue @mdkaifansari04 @Niharika0104

@mdkaifansari04  You are already assigned with a lot of issues that's why I am assigning this to @captainsahil001 .
@mdkaifansari04 Try to complete the already assigned issues as soon as possible.

Yeah, I was busy with some other work and although I'll try to complete it as soon as possible

@mdkaifansari04  You can un assign yourself from some issues if you think you will be unable to complete them


Fix item buy time

fixes #437

Do you have a sample match ID that you tested this against?

https://www.opendota.com/matches/2762021523/overview
Before and with fix

Fix also affects the buy time of all items in general.
I think the use of the purchase_log is much more reasonable than the first_purchase_time.
Is there any reason for use first_purchase_time? Perhaps I do not see the whole picture as a whole?

It's just simpler since it doesn't require iterating over the purchase log.


Installation Error

Getting the following error when trying to install this plug-in.

I'm sorry I haven't maintained this for a long time and I would think that a few adjustments need to be made for newer inkdrop versions.
Sadly I'm not using inkdrop anymore.


Feature/message endpoint

resolved: #64
sorry pr #64 suddenly closed..  I've feedback @hihiboss, add logs to validateMessage function

[x] Test case

I'll sqush the last 2 commits

@hihiboss
hihiboss 5 hours ago  Member
I wonder that sequence is string, not unsigned integer!
@zeroFruit
zeroFruit 3 hours ago  Member
you can reference Seq in message.pb.go. and I think seq can be hash
@hihiboss
hihiboss 2 hours ago  Member
Oh, I forgot it. You’re right! But I still wonder why seq is hash or string...
Plz explain that to me @junbeomlee ??

@hihiboss 5 hours ago  Member
Does it need to go func??
@zeroFruit
zeroFruit 3 hours ago  •
Member
I can't understand because in handle there's no go func
@hihiboss
hihiboss 2 hours ago  Member
I meaned “Should the cbFn & delete func be executed as go func?”
@zeroFruit
zeroFruit 28 minutes ago  •
Member
oh. you mean because resHandler.handle function blocking Listen function?

@hihiboss 5 hours ago  Member
resHandler is reference but Why messageHandler is not reference?!
@zeroFruit
zeroFruit 36 minutes ago  •
Member
I coded like this because I think that each MessageEndpointshould reflect respondHandler's change. and I've remembered interface as pointer of struct, and MessageHandler is interface, resHandler struct. so I've tried to keep consistency


Shorten list style declaration

According to http://stackoverflow.com/questions/19889069/whats-the-difference-between-list-style-type-and-list-style list-style can be substituted for list-style-type if it's meant to replace all relevant sub-styles (position and image).

Thanks!


Fix for code sign error

Fixes #33
Removed RunPath search paths and framework search paths which causes signature problem.

Thanks for your PR.
Can you provide more details about your setup. When did you encounter the signing issues?
How did you integrate ZIP Foundation into your workspace (Carthage, SPM, CocoaPods...)?
ZIP Foundation currently uses the default Xcode project template (with the exception of multiple deployment targets for iOS, macOS & watchOS) so signing should work automatically if the consuming project is set up properly.

I used carthage and built with release configuration for macOS. I don't face any problem while signing and even no problem is shown during the verification of signature. But once I download the application via internet and try to open it, the gatekeeper shows a message that the app is from an unidentified developer. This is because

From 10.10.4, If  an app uses @rpath or an absolute path to link to a dynamic library outside of the app, the app will be rejected by Gatekeeper.

Thank you,

Thank you for the details - Great find.
I can reproduce the problem when archiving a Test app that integrated the framework via Carthage.
I am not sure yet how those FRAMEWORK_SEARCH_PATHS and LD_RUNPATH_SEARCH_PATHS settings came to be. I either created the initial project in Xcode or generated it via swift package generate-xcodeproj and never touched those build settings. I will test your PR with the other 2 package managers and merge it over the weekend.
Xcode 9.1 does indeed not set FRAMEWORK_SEARCH_PATHS, but it does set LD_RUNPATH_SEARCH_PATHS to "$(inherited) @executable_path/../Frameworks @loader_path/Frameworks";
So maybe we should try the default value and check if this also interferes with Gatekeeper.

The problem is when the project is generated via swift package generate-xcodeproj

Yes. There's even a comment about that in the SPM source:
https://github.com/apple/swift-package-manager/blob/master/Sources/Xcodeproj/pbxproj().swift#L418
I merged your PR and re-added platform-dependent settings for LD_RUNPATH_SEARCH_PATHS (I used the default values that Xcode adds for macOS/iOS/tvOS/watchOS framework targets).
With these changes, apps that integrate ZIP Foundation via Carthage now work for distribution.
Other package managers should be not affected.
Thanks again for your contribution.


Component Sourcing Issue

I cannot seen to find a source for C14, C17 (C_0402_1005Metric) has anoyone found a suitable substitute?

Try Mouser

I have and it says "No results" same for Newark but I would rather have JLCPCB source it and install them.

I used jlcpcb pn C513697


feat(custom-element): Custom elements support child component style tags

close:  #7941

Hello @LinusBorg ,
I hope you are well.
Could you please look at this PR and decide if that's a valid fix for #4662  once you have some time?
Thank you so much,
Taras Savka

current problems

The hot update seems to be invalid
When the component only has a single node, the scopeId is not generated
Haven't tested cssvars yet

@johnp Thank you very much for your help. I modified the implementation logic, but this is not a small modification. I still need more tests. If you have other test cases, you can provide them to me, and we can discuss how to solve them together.

Thank you for your feedback, but there seems to be no problem in my local project test.

It seems that your test method does not take effect in vite or other reasons 😂?
Here I share my local test project with you and tell you my test method.
I don't know if this method is correct, you can refer to it.
test-repo

download the repo and run pnpm install  at root

run dev

When dev finishes executing and open the address localhost:5173, you will find that there is a problem with the page, just as you described. Close the dev process at this time

At this time, there will be a vue.js file under the path \vue-ce-child-style\node_modules\.vite\deps\vue.js (vite will request it to the browser during development )and then put the code of my pr build (packages/vue/dist/vue.esm-browser .js) to override it

run  dev

the style order problem is caused by the anchor, I updated the code 😆

the style order problem is caused by the anchor, I updated the code 😆

I marked the style of each child component with a timestamp, which allows them to be found and deleted when the component is unloaded, but I think the timestamp does not seem elegant. I tried to use hash-sum, but found that it would Makes it necessary to package all hash-sum codes at runtime, which seems even worse

Are you aware of #4404?

Are you aware of #4404 and https://github.com/EranGrin/vue-web-component-wrapper?

What is missing about Vite support? I have an almost exactly configuration of a custom defineCustomElement composable and it works decently.

Are you aware of #4404 and https://github.com/EranGrin/vue-web-component-wrapper?

I'm aware of #4404, but I didn't include it in my plugin because it already has a PR. And my plugin is only implemented according to the PR I proposed, which is an intrusive way to the source code, which is completely different from vue-web-component-wrapper

Is there an ETA version for this?

I took a closer look at #4662 and this PR doesn't seem to be the correct fix. The root cause is that custom components are treated as normal components.

I deleted the code and unit test about removing the style tag.
For ceChildStyleMap, I use style as the key and the uid of the component instance as the value to record.
The purpose of this is to avoid adding styles repeatedly.
But if a component has a lot of style content, then the ceChildStyleMap will become very bloated. If they are not cleared when the component is uninstalled, I am worried about unnecessary memory usage.

Just mentioning this bug here, I also reproduce using this PR
Let me know if you want to report this fix here as well :)

Shadow DOM should support link style.

I've been following this PR and thank you for your hard work so much. However, does the vue team have a positive view on this PR?

Hello everyone ✋ I have a simpler solution for those who want to bootstrap their vue app inside a shadowRoot:
here is a simple vitejs plugin that will inject all styles using the adoptedStylesheets API.
Let me know if you face some limitation, and if you need a version for webpack.
https://github.com/lseguin1337/vue-adopted-stylesheets

ping @LinusBorg

@yyx990803 please 😭😭


Update ME

Maine is already in session with 2019 legislators, but the openstates people scraper is broken for the house.
I'm working on it over at https://github.com/openstates/openstates/tree/tim/2018/me-2019-people and expect to knock it out in the next few days, just filing this as a tracking bug.

@jamesturk What's the plan for updating this repo with new legislators for the 2019 sessions? Is there going to be some mass update from scrapers, or will it have to be a divided strategy among volunteers?

just added #38 to track the work, but it'll be a mix of scraping/manual updating


Implement 1.12 support (per request)

Should be fixed in https://github.com/Ruinscraft/Panilla/commit/a038cbdcc712181bd73982a308cc3cdf08254a51