release notes and proxy update

Docs Build status updates of commit 8f52b9d:
:warning: Validation status: warnings

File
Status
Preview URL
Details

Advertising/bingads-13/guides/release-notes.md
:warning:Warning

Details

Advertising/bingads-13/guides/handle-service-errors-exceptions.md
:bulb:Suggestion

Details

Advertising/bingads-13/guides/walkthrough-web-application-java.md
:bulb:Suggestion

Details

Advertising/bingads-13/bulk-service/account.md
:white_check_mark:Succeeded

Advertising/bingads-13/bulk-service/getbulkdownloadstatus.md
:white_check_mark:Succeeded

Advertising/bingads-13/bulk-service/getbulkuploadstatus.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addadextensions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addadgroupcriterions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addadgroups.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addads.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addaudiences.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addbudgets.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addcampaigncriterions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addcampaigns.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addconversiongoals.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addexperiments.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addkeywords.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addlabels.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addlistitemstosharedlist.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addnegativekeywordstoentities.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addsharedentity.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/adduettags.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/appealeditorialrejections.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/applyofflineconversions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/applyproductpartitionactions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deleteadextensions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deleteadextensionsassociations.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deleteadgroupcriterions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deleteadgroups.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deleteads.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deleteaudiences.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletebudgets.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletecampaigncriterions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletecampaigns.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deleteexperiments.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletekeywords.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletelabelassociations.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletelabels.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletelistitemsfromsharedlist.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletemedia.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletenegativekeywordsfromentities.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletesharedentities.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletesharedentityassociations.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/getaccountproperties.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/getadextensionsassociations.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/getadextensionsbyids.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/getadextensionseditorialreasons.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/getadgroupsbycampaignid.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/getadgroupsbyids.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/getadsbyadgroupid.md
:white_check_mark:Succeeded

This comment lists only the first 50 files in the pull request.

Advertising/bingads-13/guides/release-notes.md

Line 27: [Warning] Invalid file link:(~/bingads-13/guides/getconversiongoalsbyids.md).
Line 27: [Warning] Invalid file link:(~/bingads-13/guides/getconversiongoalsbytagids.md).

Advertising/bingads-13/guides/handle-service-errors-exceptions.md

Line 180: [Suggestion] Link 'https://docs.microsoft.com/en-us/dotnet/framework/wcf/samples/expected-exceptions' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites. NOTE: This Suggestion will become a Warning on 12/20/2019.
Line 184: [Suggestion] Link 'https://docs.microsoft.com/en-us/dotnet/framework/wcf/samples/avoiding-problems-with-the-using-statement' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites. NOTE: This Suggestion will become a Warning on 12/20/2019.

Advertising/bingads-13/guides/walkthrough-web-application-java.md

Line 255: [Suggestion] Link 'http://azure.microsoft.com/services/app-service/web/' is insecure. Links to Microsoft sites must use 'https' instead of 'http'. NOTE: This Suggestion will become a Warning on 12/20/2019.
Line 255: [Suggestion] Link 'http://azure.microsoft.com/services/app-service/' is insecure. Links to Microsoft sites must use 'https' instead of 'http'. NOTE: This Suggestion will become a Warning on 12/20/2019.
Line 289: [Suggestion] Link 'http://azure.microsoft.com/pricing/purchase-options/' is insecure. Links to Microsoft sites must use 'https' instead of 'http'. NOTE: This Suggestion will become a Warning on 12/20/2019.
Line 291: [Suggestion] Link 'https://docs.microsoft.com/en-us/azure/azure-toolkit-for-eclipse-installation' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites. NOTE: This Suggestion will become a Warning on 12/20/2019.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 313ef9d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Advertising/bingads-13/guides/get-started-csharp.md
:bulb:Suggestion

Details

Advertising/bingads-13/guides/handle-service-errors-exceptions.md
:bulb:Suggestion

Details

Advertising/bingads-13/guides/walkthrough-web-application-csharp.md
:bulb:Suggestion

Details

Advertising/bingads-13/bulk-service/account.md
:white_check_mark:Succeeded

Advertising/bingads-13/bulk-service/getbulkdownloadstatus.md
:white_check_mark:Succeeded

Advertising/bingads-13/bulk-service/getbulkuploadstatus.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addadextensions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addadgroupcriterions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addadgroups.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addads.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addaudiences.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addbudgets.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addcampaigncriterions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addcampaigns.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addconversiongoals.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addexperiments.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addkeywords.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addlabels.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addlistitemstosharedlist.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addnegativekeywordstoentities.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addsharedentity.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/adduettags.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/appealeditorialrejections.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/applyofflineconversions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/applyproductpartitionactions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deleteadextensions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deleteadextensionsassociations.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deleteadgroupcriterions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deleteadgroups.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deleteads.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deleteaudiences.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletebudgets.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletecampaigncriterions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletecampaigns.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deleteexperiments.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletekeywords.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletelabelassociations.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletelabels.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletelistitemsfromsharedlist.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletemedia.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletenegativekeywordsfromentities.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletesharedentities.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletesharedentityassociations.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/getaccountproperties.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/getadextensionsassociations.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/getadextensionsbyids.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/getadextensionseditorialreasons.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/getadgroupsbycampaignid.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/getadgroupsbyids.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/getadsbyadgroupid.md
:white_check_mark:Succeeded

This comment lists only the first 50 files in the pull request.

Advertising/bingads-13/guides/get-started-csharp.md

Line 20: [Suggestion] Link 'https://docs.microsoft.com/en-us/dotnet/standard/net-standard' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites. NOTE: This Suggestion will become a Warning on 12/20/2019.

Advertising/bingads-13/guides/handle-service-errors-exceptions.md

Line 180: [Suggestion] Link 'https://docs.microsoft.com/en-us/dotnet/framework/wcf/samples/expected-exceptions' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites. NOTE: This Suggestion will become a Warning on 12/20/2019.
Line 184: [Suggestion] Link 'https://docs.microsoft.com/en-us/dotnet/framework/wcf/samples/avoiding-problems-with-the-using-statement' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites. NOTE: This Suggestion will become a Warning on 12/20/2019.

Advertising/bingads-13/guides/walkthrough-web-application-csharp.md

Line 19: [Suggestion] Link 'https://docs.microsoft.com/en-us/azure/app-service/app-service-web-get-started-dotnet-framework' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites. NOTE: This Suggestion will become a Warning on 12/20/2019.
Line 491: [Suggestion] Link 'https://docs.microsoft.com/en-us/azure/app-service/app-service-web-get-started-dotnet-framework' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites. NOTE: This Suggestion will become a Warning on 12/20/2019.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit b4bf94d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Advertising/bingads-13/bulk-service/account.md
:white_check_mark:Succeeded

Advertising/bingads-13/bulk-service/getbulkdownloadstatus.md
:white_check_mark:Succeeded

Advertising/bingads-13/bulk-service/getbulkuploadstatus.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addadextensions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addadgroupcriterions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addadgroups.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addads.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addaudiences.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addbudgets.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addcampaigncriterions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addcampaigns.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addconversiongoals.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addexperiments.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addkeywords.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addlabels.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addlistitemstosharedlist.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addnegativekeywordstoentities.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addsharedentity.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/adduettags.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/appealeditorialrejections.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/applyofflineconversions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/applyproductpartitionactions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deleteadextensions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deleteadextensionsassociations.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deleteadgroupcriterions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deleteadgroups.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deleteads.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deleteaudiences.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletebudgets.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletecampaigncriterions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletecampaigns.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deleteexperiments.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletekeywords.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletelabelassociations.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletelabels.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletelistitemsfromsharedlist.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletemedia.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletenegativekeywordsfromentities.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletesharedentities.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletesharedentityassociations.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/getaccountproperties.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/getadextensionsassociations.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/getadextensionsbyids.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/getadextensionseditorialreasons.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/getadgroupsbycampaignid.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/getadgroupsbyids.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/getadsbyadgroupid.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/getadsbyeditorialstatus.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/getadsbyids.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/getaudiencesbyids.md
:white_check_mark:Succeeded

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


1.12.2 Dark Steel Armor Bug after update

Issue Description: Dark Steel Armor suddenly takes durability damage after i updated ender io.
What happens: I had it set in the configs that Dark Steel Armor  doenst take durability damage  when fully upgraded to energy IV as long as it has power. But now it takes damage again and the part where i could set it in the configs is gone.
What you expected to happen: not to take durability damage as long as armor is charged.
Steps to reproduce:
1.Install, set configs
2. cinfigs go missing when updateing to newest version and or are all messed up.
3. suddenly armor gets destroyed out of nowhere
...

Affected Versions (Do not use "latest"):

EnderIO:Newest
EnderCore:Newest
Minecraft:1.12.2
Forge:<IP_ADDRESS>68
SpongeForge? dont know normal forge
Optifine? No tested it with no other mods installed
Single Player

Your most recent log file where the issue was present: No log for that
[pastebin/gist/etc link here]

It literally says do not say "latest" in the template. Please give the version number you updated from. Energy usage values for Dark Steel is now stored in the capacitor key xml files


Added Famous Graph Algorithms C++

I have implemented various important algorithms found in competitive coding .
Fixes Issue #35

Please review @orvil1026 @csendranshi @clare0901

@orvil1026 After this PR is merged, pls assign issue #38  and #37 to me. I have worked on them and have implemented the algorithm and created the app. I am just waiting for those issues to be assigned to be as it is mentioned in the Code of Conduct that I can only work on them after they have been assigned. Thanks :)

Updated the location of the files. Pls review @csendranshi

@orvil1026 After this PR is merged, pls assign issue #38 and #37 to me. I have worked on them and have implemented the algorithm and created the app. I am just waiting for those issues to be assigned to be as it is mentioned in the Code of Conduct that I can only work on them after they have been assigned. Thanks :)

Issue #37 has been assigned to you.After you make an pr for #37 issue #38 will be assigned to you.


wrong slippage on swap trade

I used the bot to swap directly because there was an issue with the official frontend, and to play safe before some panic-sell i tried to use the bot.. i added the contracts of the tokens and selected default option mmf for the router. I selected all the assets I had and performed the swap.
The problem was that I had the window small and didnt saw the slippage, witch was 90% and I lost over 10k usd 🤦♂.
I noticed that the swap didnt used the defaut method for swaps on mmf SwapETHForExactTokens but instead used swapExactTokensForTokensSupportingFeeOnTransferTokens.
Is there a way to specify the methodId on settings?

Hey, was the slippage on 90% by default or did you configure that accidently? Also what tokens did you trade? If you try to swap a token for another token (e.g. mmf -> usdc) you can't use the swapETHForExactTokens function.

No, i didn't set anything besides the contract of the tokens.
I swapped svn and mshare.. I have here a printscreen that fortunately didn't hit "enter" on the MAD token (12$ each at the time)

and this is the transaction

On 3 trades I mad yes, the slippage was huge, but as I said, the terminal window was small and I didnt noticed :
20220504211333.log

but as I said, the terminal window was small and I didnt noticed
So, I'm a bit confused.. Was the slippage wrong because of some default settings from the bot? -> default slippage should be 1%

but as I said, the terminal window was small and I didnt noticed

So, I'm a bit confused.. Was the slippage wrong because of some default settings from the bot? Is there something to be fixed there?
-> default slippage should be 1%

closing this since I'm still not getting an answer if the problem was caused by the user or by the program itself.
Feel free to comment and I'll reopen it.

Hi sorry... yes, there is a problem, because the bot used a method on contract what is not the standard on that router, like I said on first comment, it should had used SwapETHForExactTokens

I strongly disagree here. SwapETHForExactTokens can only be used when you trade ETH (on cronos CRO) for another token.
Another option would be using SwapTokensForExactTokens but that would exclude all tokens that have a dev/marketing/whatever fee (like safemoon e.g.). In order for the bot to be able to trade all these tokens swapExactTokensForTokensSupportingFeeOnTransferTokens must be used.

I'm not aware of other implementations.. I understand your point of view and makes sense.. but on cronos/mmf they use that for all tokens swaps.. you can check here ie here

You're right.. it should had used SwapTokensForExactTokens I can verify on their router here

Again, not supporting a fee on transfer would exclude all tokens from trading which take a dev fee on each swap. Beside that, SwapTokensForExactTokens also requires the configuration of a slippage. So if the wrong slippage wasn't a layer 8 problem, then the error is somewhere else in the code.
Unfortunately I'm not having the time to look into this in the next few weeks.
Is this behavior reproducible with order trades or does it only affect swaps?

Hi, I'm sorry I don't check this email often. I talked to the dex team, and they said I was front-runned (idk what that even really means). Like I said since the beginning, I used all default options, just inserted the tokens and went for swap. Slippage was default 1%, and as I was running on a small window, I did not see the slippage before hit the "enter".
When I saw what really happened was too late, but that was totally my fault to not tripple-check things... I don't know solidity (yet) and not in position to say what should be used or not, I just said that the dex uses the method SwapTokensForExactTokens  and I assumed that the bot should use that too, if not maybe configure somehow.
Thank u

Thanks for the follow up. In that case I will close this again.

You can close it, but I think u didn't understand yet.. the team said that I got frontrunned, but before commit the swap the slippage was already 98% instead of the 1% default, so I don't think that was the case.. or am I missing something?


HTTPFaultInjection in VS does not work if percentage is omitted

Bug Description
Description
I was trying to configure HTTPFaultInjection in my VirtualService and as per documentation, the percentage field is optional. Omitting it should abort all the requests meeting the criteria.
But when I omit it, the abort faultInjection stops working and all the requests pass through to the upstream cluster successfully. I'm unsure if this is a bug in the implementation or if I'm using it incorrectly?
Steps to reproduce

Install the httpbin app in a mesh enabled NS
Install the sleep app in a mesh enabled NS
Create a VS as shown below

apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: sleep-vs
spec:
  hosts:
  - httpbin.default.svc.cluster.local
  http:
  - fault:
      abort:
        httpStatus: 403
    route:
    - destination:
        host: httpbin.default.svc.cluster.local
        port:
          number: 8000
    match:
      - uri:
          prefix: "/get"

Try to make a request from the sleep pod

k exec <SLEEP_POD> -it -- curl -vso /dev/null http://httpbin.default.svc.cluster.local:8000/get

Expectation
The expectation was that all the requests to the /get endpoint should result in 403.
What was observed?
All the requests returned 200.
Please do let me know if I'm missing something
Version
$ istioctl version
client version: 1.13.2
control plane version: 1.13.2
data plane version: 1.13.2 (4 proxies)

$  k version --short
Client Version: v1.21.2
Server Version: v1.22.1

Additional Information
Here is the corresponding envoy config snippet
"name": "httpbin.default.svc.cluster.local:8000",
"domains": [
	"httpbin.default.svc.cluster.local",
	"httpbin.default.svc.cluster.local:8000",
	"httpbin",
	"httpbin:8000",
	"httpbin.default.svc",
	"httpbin.default.svc:8000",
	"httpbin.default",
	"httpbin.default:8000",
],
"routes": [{
		"match": {
			"prefix": "/get",
			"case_sensitive": true
		},
		"route": {
			"cluster": "outbound|8000||httpbin.default.svc.cluster.local",
			"timeout": "0s",
			"retry_policy": {
				"retry_on": "connect-failure,refused-stream,unavailable,cancelled,retriable-status-codes",
				"num_retries": 2,
				"retry_host_predicate": [{
					"name": "envoy.retry_host_predicates.previous_hosts"
				}],
				"host_selection_retry_max_attempts": "5",
				"retriable_status_codes": [
					503
				]
			},
			"max_grpc_timeout": "0s"
		},
		"metadata": {
			"filter_metadata": {
				"istio": {
					"config": "/apis/networking.istio.io/v1alpha3/namespaces/default/virtual-service/sleep-vs"
				}
			}
		},
		"decorator": {
			"operation": "httpbin.default.svc.cluster.local:8000/get*"
		},
		"typed_per_filter_config": {
			"envoy.filters.http.fault": {
				"@type": "type.googleapis.com/envoy.extensions.filters.http.fault.v3.HTTPFault",
				"abort": {
					"http_status": 403
				}
			}
		}
	}

Hello @howardjohn should we fix the code or change the doc?

The optional percentage field can be used to only abort a certain percentage of requests. If not specified, all requests are aborted.

IC, it is not in api doc. So we need to fix the istio.io
The Delay has same issue

Also, if the percentage is not mentioned, then the code should default it to 100%

Now it just skip setting the percentage
https://github.com/istio/istio/blob/1.14.2/pilot/pkg/networking/core/v1alpha3/route/route.go#L1104

so we'll probably need a code change along with documentation

Do you mean we should fix the doc and leave the code as is? I'm asking because the current doc sounds more semantically correct to me

I think so, this conforms with the rule not make breaking changes.

@hzxuzhonghu @dddddai  ... just wanted to be clear. Since the percentage field is an optional field, what should the user expect when it is omitted from the config?
If the user does not mention the percentage field, should

fault injection not take effect? OR
fault injection implicitly sets it to 100?

I was at first leaning towards making unset == 100%, but after some more analysis I think its dangerous. If we switch this, any user will flip from 0% fault to 100% which can cause outages.
I did some analysis and found over 10% of fault configs in live clusters are NOT setting percentage. So I think it cannot be safely changed.

@howardjohn

I was at first leaning towards making unset == 100%, but after some more analysis I think its dangerous. If we switch this, any user will flip from 0% fault to 100% which can cause outages.

Well, TBH it does conform with the istio documentation which states that 100% of requests will be aborted if percentage is omitted. But I do get your point that this is dangerous as users would get blindsided by the fix.

I did some analysis and found over 10% of fault configs in live clusters are NOT setting percentage. So I think it cannot be safely changed.

In that case, should we change the wording in the documentation from If not specified, all requests are aborted. to If not specified, none of the requests will be aborted. ?

Fixed document


Somethings about putting DvsGesture on the right place

Hi~
First I download the DvsGesture folder in the data folder
and then ->>cd data
->>ln -s path_to_dvs_gestures/DVS\ \ Gesture\ dataset/DvsGesture/
but something wrong:
Ln: unable to create symbolic link '. / dvsgeature': file already exists
Could you tell me the DvsGesture folder should be Where?
Thanks!

Hello,
I recommend you to move to the more recent version of this code: https://github.com/nmi-lab/decolle-public
The files (*.aedat) of the DvsGesture dataset should be in the following folder: dcll-public/data/dvsgesture/raw
The command ln simply creates a symbolic link.


Fixed crash in Example project

Fixed crash in Example project generated due to changes in SeatGeek API requiring https. Also take in consideration that beginning June 1, 2016 all requests to the SeatGeek API will be required to pass a valid API Key.

Where will we have to pass the API key?

Merge?

Checkout my fork https://github.com/BadChoice/RVCalendarWeekView
It is updated and with some new features 👯


fix: #146 Add arguments to img2img

Workaround for issue #146

This solved a problem I had with the current release. Posting the error here to make it easier for others to solve the problem:
TypeError: img2img() missing 1 required positional argument: 'override_settings_texts'


Upgrade to Node 20.12.2

This PR upgrades to Node 20.12.2, refreshes all dependencies by generating a fresh package-lock.json, and migrates from Travis to a GitHub Actions workflow.

@onebytegone This one is ready for you if you want to review!


Fix: Deal with exception when err is undefined.

Exception raised when running example1.js
Failure TypeError: Cannot read property 'message' of undefined
    at C:\code\brakes\lib\Circuit.js:96:17
    at tryCatcher (C:\code\brakes\node_modules\bluebird\js\release\util.js:16:23)
    at Promise._settlePromiseFromHandler (C:\code\brakes\node_modules\bluebird\js\release\promise.js:547:31)
    at Promise._settlePromise (C:\code\brakes\node_modules\bluebird\js\release\promise.js:604:18)
    at Promise._settlePromise0 (C:\code\brakes\node_modules\bluebird\js\release\promise.js:649:10)
    at Promise._settlePromises (C:\code\brakes\node_modules\bluebird\js\release\promise.js:725:18)
    at _drainQueueStep (C:\code\brakes\node_modules\bluebird\js\release\async.js:93:12)
    at _drainQueue (C:\code\brakes\node_modules\bluebird\js\release\async.js:86:9)
    at Async._drainQueues (C:\code\brakes\node_modules\bluebird\js\release\async.js:102:5)
    at Immediate.Async.drainQueues [as _onImmediate] (C:\code\brakes\node_modules\bluebird\js\release\async.js:15:14)
    at processImmediate (internal/timers.js:439:21)

Fix is out in 3.0.1 release: https://github.com/awolden/brakes/releases/tag/3.0.1


Only consider queries in subproject

Fixes: https://progress.opensuse.org/issues/109857

https://github.com/os-autoinst/scripts/pull/154 might help.
If not you could extend the condition in _common:63

#154 might help.
If not you could extend the condition in _common:63

I suppose we don't need the new project then. The tracker is what locks down permissions. comment_on_job will never be reached with your change.


chore: converted arrow functions

@J-Ankit2020
Hey, seems like there is a bit of misunderstanding of the problem and hence, the solution you have currently implemented doesn't seem to be solving it.
let me help you to move in the correct direction.
For Functional Component -> memoize the function using useCallback ( Refer this article to understand the problem better and also the solution  )
For Class Component ->  arrow function which is class property ( Refer this article  for example )


fix openchannels checkf or cln in menu

Tested OK
Can use the SENT in CLN menu item.
No longer getting


fix deadlock during prevote migration process

Fixes #20

Hi @csmoe, would you like any help with getting this PR merged? I see @BusyJay left a few comments. If you're busy I can wrap things up for you.

@Hoverbear sorry for a delayed commit, I totally forgot this thread.
Feel free to do anything, thank you.

@BusyJay Can you give this another look regarding the feedback you gave?

PTAL @hicqu

Rest LGTM

PTAL @Hoverbear

Please run cargo fmt and we can merge this. :) We just merged #55 which runs code on the CI through rustfmt.

@Hoverbear The current rustfmt in CI is stable-ver, but:
Warning: can't set `use_try_shorthand = true`, unstable features are only available in nightly channel.

So rustfmt config might need changes.

Ping @Hoverbear

Opened https://github.com/pingcap/raft-rs/issues/62 to reflect the cargo fmt warnings.


fusedev: add fd-passthrough support

This patch adds support for fd-passthrough feature (in anolis kernel). The fd-passthrough feature significantly improves the read/write performance of passthrough filesystems.
However, it only supports fuse not virtiofs.
About fd-passthrough, see:
https://gitee.com/anolis/cloud-kernel/commit/ea085d4df6697594772a72b55f1ea53018646c3c https://gitee.com/anolis/cloud-kernel/commit/433ec5ac4cea91cebf5682fa729a570c00bb60c5 https://gitee.com/anolis/cloud-kernel/commit/b4f2155fbfafca7763739b9a5a11585ee59f3c67 https://gitee.com/anolis/cloud-kernel/commit/63c4968a7881f61a2ad04176d3ad3a4e3aa1e706 https://gitee.com/anolis/cloud-kernel/commit/01ec57c17665cd793f115385ac8ba2ca735fe582 https://gitee.com/anolis/cloud-kernel/commit/5c7c7e9ec18fba42d03910ac7501f7e6b472a5f7 https://gitee.com/anolis/cloud-kernel/commit/00d1e12e5bf69a51724bd6f3450719f6eeb615bc https://gitee.com/anolis/cloud-kernel/commit/354315cb7497d0943bc974f8a8cad1c748345b56 https://gitee.com/anolis/cloud-kernel/commit/5953f752bfa7609b1302c960bb2d9bd2a90f30a3 https://gitee.com/anolis/cloud-kernel/commit/2a1346c4e5446a8f7a7d6e458f96fe0dd81539ad https://gitee.com/anolis/cloud-kernel/commit/354b614827a953aa688d9f37c37fccbff26aa901 https://gitee.com/anolis/cloud-kernel/commit/881f0097c036c2e8f676b2bb2f38fe3f19b116d7

@bergwolf Hi, CI problem fixed, would you review it again?


readme: Fix a minor typo

Hi @sschuberth,
could you please explain what is the difference? GH and AS can't find any diffs:(

@akarimova You can see the diff online at https://github.com/onepf/OpenIAB/pull/443/files. It fixes "alreay" to say "already".

o, thank you!


Make sure to redact env data

Environment data passed to the CPI may contain sensitive data. We did a quick investigation and a few places might be logging sensitive data. Example:

Redact user_data when logging. As an example. The redact_credentials_in_request_body only redacts the keys ['adminPassword', 'client_secret'], not anything present in the user_data such as registry_endpoint.
Make sure to redact sensitive data passed through the env in the create_vm

A tracker story with more info can be found here #148715311
cc @ktchen14

Close this since it is fixed in this PR #298.


docs: mistyped change directory command

Description

Mistyped cd website - website instead of cd modelina-website

Related issue(s)

Fixes @sambhavgupta0705 error identified https://github.com/asyncapi/modelina/pull/1395#discussion_r1225764387

@rukundob451 you have merge conflics

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 92.192%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
5259

Relevant Lines:
5562

💛  - Coveralls


Test suite uses local cluster for all validations.

Test cases automated in this suite are applicable to local cluster. Therefore updated the clusterName to be taken as local.

@brudnak can you review this?


 I have infinity as
death energy, and XXX on rank I and rank II, and MAX on rank III, and I
tried everything I could think of.
Also what is Dead Runes or "Dead Runs" for?
—
Reply to this email directly, view it on GitHub
https://github.com/CutFuyi/JS13KGAMES-2022-Idle-Necromancer-/issues/1,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALYUQ64XZMXHO2PYCQXP7M3V36LK3ANCNFSM6AAAAAAQBTF74M
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Hey,
Thanks for the answer. I didn't notice that the bloody ritual's candles get lit when I click them. My bad. I actually quite like the mysterious aspect of the game, that you have to figure stuff out.
Nice game. Had a couple of bloody rituals now.  : )


Latest Tag of sstarcher/uchiwa broke ADOP sensu-uchiwa service

I just noticed a while ago while testing adop that sensu uchiwa service is not working as it used to be last night and I saw that there is a new tag that was pushed to this repo. To fix, I had to hardcode the last working version to 0.15.0.
sensu-uchiwa:
container_name: sensu-uchiwa
restart: always
image: sstarcher/uchiwa:0.15.0
net: ${CUSTOM_NETWORK_NAME}
environment:
SENSU_HOSTNAME: sensu-api
expose:
- "3000"

@bzon image was tagged and merged, please check it

Thanks @anton-kasperovich. closing this issue now


"safety" has identified security vulnerability in all 5.x versions released so far

Describe the bug
Report from "safety"
| package                    | installed | affected                 | ID          |
+============================+===========+==========================+==========+
| coverage                   | 5.5          | <6.0b1                   | 41002    |
+==============================================================================+
| Coverage 6.0b1 starts to use a modern hash algorithm (sha256) when fingerprinting for high-security environments. |
+==============================================================================+
To Reproduce
How can we reproduce the problem?  Include coverage project in any python code and run safety. We use poetry and have dependency defined listed below.
Answer the questions below:

What version of Python are you using? 3.7

What version of coverage.py are you using? 5.5

What versions of what packages do you have installed? Listed below

What code are you running?  private repo, just running

What commands did you run?
safety check --full-report
Above command fails, while ignoring 41002 (like below) passes
safety check --full-report -I 41002

Expected behavior
We should not have to ignore 41002 vulnerability identified by safety and it should succeed. This appears to be security issue identified due to old hashing algorithm used.
Additional context
Reporting, with request to release the secure version of the package soon.
Poetry dependency defined:
[tool.poetry.dependencies]
click = "^7.0"
python = "^3.7"
python-dateutil = "^2.8.1"
[tool.poetry.dev-dependencies]
black = "^19.10b0"
coverage = {extras = ["toml"], version = "^5.0.3"}
darglint = "^1.1.3"
flake8 = "^3.7.9"
flake8-annotations = "^2.0.0"
flake8-bandit = "^2.1.2"
flake8-docstrings = "^1.5.0"
flake8-isort = "^2.8.0"
isort = "^4.3.21"
numpy = "^1.19.1"
pytest = "^5.2"
pytest-cov = "^2.8.1"
pytype = "^2020.2"
safety = "^1.9.0"
sphinx = "^3.0.4"
sphinx-click = "^2.7.1"
sphinx-autodoc-typehints = "^1.10.3"
sphinx-rtd-theme = "^0.5.0"
testfixtures = "^6.14.0"
xarray = "^0.16.1"
xdoctest = "^0.11.0"
Packages installed:
• Installing greenlet (1.1.0)
• Installing h11 (0.12.0)
• Installing sniffio (1.2.0)
• Installing typing-extensions (<IP_ADDRESS>)
• Installing httpcore (0.12.3)
• Installing pydantic (1.8.2)
• Installing rfc3986 (1.5.0)
• Installing sqlalchemy (1.4.22)
• Installing db-tools-core (1.4.1)
• Installing httpx (0.17.1)
• Installing markupsafe (2.0.1)
• Installing numpy (1.19.5)
• Installing psutil (5.8.0)
• Installing pytz (2021.1)
• Installing tenacity (7.0.0)
• Installing alabaster (0.7.12)
• Installing babel (2.9.1)
• Installing cached-property (1.5.2)
• Installing docutils (0.16)
• Installing imagesize (1.2.0)
• Installing jinja2 (3.0.1)
• Installing locket (0.2.1)
• Installing memory-profiler (0.58.0)
• Updating packaging (20.9 -> 21.0)
• Installing pandas (1.1.5)
• Installing pygments (2.9.0)
• Installing pymysql (1.0.2)
• Installing snowballstemmer (2.1.0)
• Installing sphinxcontrib-applehelp (1.0.2)
• Installing sphinxcontrib-devhelp (1.0.2)
• Installing sphinxcontrib-htmlhelp (2.0.0)
• Installing sphinxcontrib-jsmath (1.0.1)
• Installing sphinxcontrib-qthelp (1.0.3)
• Installing sphinxcontrib-serializinghtml (1.1.5)
• Installing toolz (0.11.1)
• Installing attrs (21.2.0)
• Installing cftime (1.5.0)
• Installing cloudpickle (1.6.0)
• Installing fsspec (2021.7.0)
• Installing influxdb (5.3.1)
• Installing numexpr (2.7.3)
• Installing pluggy (0.13.1)
• Installing more-itertools (8.8.0)
• Installing scipy (1.6.1)
• Installing test-support (0.1.3)
• Installing py (1.10.0)
• Installing structlog (20.2.0)
• Installing sphinx (3.5.4)
• Installing partd (1.2.0)
• Installing wcwidth (0.2.5)
• Installing asv (0.4.2)
• Installing core-maths (0.0.10)
• Installing dask (2021.7.2)
• Installing future (0.18.2)
• Installing h5py (2.10.0)
• Installing parse (1.19.0)
• Installing redis (3.5.3)
• Installing sphinx-rtd-theme (0.5.2)
• Installing tables (3.6.1)
• Installing pydoe (0.3.8)
• Installing smmap (4.0.0)
• Installing netcdf4 (1.5.7)
• Installing pytest (5.4.3)
• Installing xarray (0.16.2)
• Installing dataframe-io (1.0.5)
• Installing frozendict (1.2)
• Installing gitdb (4.0.7)
• Installing pycodestyle (2.7.0)
• Installing mccabe (0.6.1)
• Installing pyflakes (2.3.1)
• Installing pbr (5.6.0)
• Installing flake8 (3.9.2)
• Installing gitpython (3.1.20)
• Installing networkx (2.6.2)
• Installing stevedore (3.3.0)
• Installing toml (0.10.2)
• Installing transforms (1.1.1)
• Installing appdirs (1.4.4)
• Installing bandit (1.7.0)
• Installing configargparse (1.5.1)
• Installing dparse (0.5.1)
• Installing coverage (5.5)
• Installing flake8-polyfill (1.0.2)
• Installing importlab (0.6.1)
• Installing isort (4.3.21)
• Installing ninja (1.10.2)
• Installing pydocstyle (6.1.1)
• Installing regex (2021.7.6)
• Installing pathspec (0.9.0)
• Installing python-json-logger (2.0.2)
• Installing tabulate (0.8.9)
• Installing tblib (1.7.0)
• Installing testfixtures (6.18.0)
• Installing typed-ast (1.4.3)
• Installing black (19.10b0)
• Installing darglint (1.8.0)
• Installing flake8-annotations (2.6.2)
• Installing flake8-bandit (2.1.2)
• Installing flake8-docstrings (1.6.0)
• Installing flake8-isort (2.9.1)
• Installing pytest-cov (2.12.1)
• Installing safety (1.10.3)
• Installing pytype (2020.2.6)
• Installing sphinx-autodoc-typehints (1.12.0)
• Installing xdoctest (0.11.0)
• Installing sphinx-click (2.7.1)

This is a duplicate of #1198. Please express your displeasure to the "safety" team, who did not bother to ask me about this.


Added scipy and proper indentation

Also looks like our current sandbox dockerfile fails because of some lean error. Can you please work with @Alcray to fix that (by pinning the version wherever necessary or any other fix that works)?


Bundle up

Coverage remained the same at 70.43% when pulling c04aa805fb552036eab58de227fdbfdc7e5055cc on bundle into fe02ad75a37c6e6f6c47d27a4d4ba278a3fc9c2e on master.


Arrows for vertical scroll

@lightsighter has requested that up/down arrows also be usable, in order to scroll the panel of plots up and down.

Not a high priority, but since we have horizontal movement with the arrows, I found myself wanting to do the same thing with the vertical arrows.

This seems achievable using config.scroll_to_item by searching for any next / previous item to assign, but I was going to look into whether the UI viewport could just be generically scrolled programatically.

I would not use the scroll_to_item code directly, but I think it's an illustrative example of how to accomplish a programmatic vertical scroll. Here's the relevant code:
https://github.com/StanfordLegion/prof-viewer/blob/6417711efc2e5de90879037d19561fa5e88c169c/src/app.rs#L1372-L1380
The relevant API is ui.scroll_to_rect which can be given any rectangle, not just ones concerning a specific item. So all we need to do is calculate the appropriate rectangle to scroll to (whether an item is there or not) and figure out the most elegant way to thread that information through the system.


Correction for raw affiliation #N#        National Institute for Medical Research, Mwanza Centre Mwanza, Tanzania

Correction needed for raw affiliation #N#        National Institute for Medical Research, Mwanza Centre Mwanza, Tanzania
raw_affiliation_name: #N#        National Institute for Medical Research, Mwanza Centre Mwanza, Tanzania
new_rors: 05fjs7w98
previous_rors: 04tnbqb63
works_examples: W2063319389;W2129999114;W2130221069
contact:<PHONE_NUMBER>0c31036acee0ee457c48dc:e8e83cf0fd27092dd3a828f884786d0d80043cda @ crick.ac.uk

This issue was accepted and ingested by the OpenAlex team on 2024-10-10. The new affiliations should be visible within the next 7 days.


Using nlog instead of console + mongo db timeout information

Current coverage is 5.21% (diff: 100%)

Merging #66 into master will not change coverage

@@            master       #66   diff @@
========================================
  Files            4         4
  Lines          115       115
  Methods         76        76
  Messages         0         0
  Branches        13        13
========================================
  Hits             6         6
  Misses         109       109
  Partials         0         0

Powered by Codecov. Last update 1dc8059...354d422

Hmm and now interesting question does NLog support Mono...
Yest it does: Mono 4

LGFM


Account for speed modifiers in Aimed/Multi Shot cast time

This pull request seeks to update the Aimed Shot / Multi-shot cast bar to account for speed modifiers which would reduce the total cast time of the shot (Rapid Fire, Improved Aspect of the Hawk, quiver/ammo pouch, etc). It also changes the base cast time of aimed shot to 3.5 seconds (up from 3 seconds), based on findings in this forum post. The cast time is updated when UNIT_RANGEDDAMAGE event fires, based on observations that increased haste after the cast begins will decrease the overall cast time (but never increase it when losing speed buffs). This may be caused by a race condition between the initial cast and the buff gained.

@Aviana Thanks a lot for all the updates!


Display personal achivements on /person/achievements

Well, this is awkward.  (And why I dislike coding while on the train)
Merge conflicts everywhere!

Travis tests have failed
Hey @silasary,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.
1st Build
View build log

     echo $CMD

python dev.py mypy

     $CMD

$ $CMD
CONFIG: production=False
decksite/achievements.py:99: error: Signature of "display" incompatible with supertype "Achievement"
decksite/achievements.py:126: error: Signature of "display" incompatible with supertype "Achievement"
decksite/achievements.py:160: error: Signature of "display" incompatible with supertype "Achievement"

Exit status: 1 (Failure)
4 issues

TravisBuddy Request Identifier: c3d83040-d862-11e8-b9f2-b1fbc111596d


can't find mapping relationship between actions and joints

I notice that num_dofs = 19, and num_actions = 10.
I wonder where  defines the mapping relationship between actions (output of the RL policy) and actual joints.
Thanks a lot!

After load_urdf, num_dof is 10 (same as defination in config file).


⚠ Bofrost.hr has degraded performance

In b2eba36, Bofrost.hr (https://www.bofrost.hr) experienced degraded performance:

HTTP code: 200
Response time: 3084 ms

Resolved: Bofrost.hr performance has improved in 67eee25 after 7 minutes.


[BUG] download malfunctioning

Describe the Bug
It appears that the download function is malfunctioning. Previously (6 months ago), I have successfully used the download feature with Ungoliant. However, currently, it seems to be skipping files, possibly due to an inability to download or a change in the address.
To Reproduce
Attempt to download the wet.paths.gz file from https://data.commoncrawl.org/crawl-data/CC-MAIN-2024-10/index.html.
Expected Behavior
The expected behavior is that the download should occur successfully.
Screenshots
It quickly moves to the next file, indicating that it's not downloading properly.

Desktop (Please Complete the Following Information):
uname -a
Linux delta 5.14.21-150500.55.36-default #1 SMP PREEMPT_DYNAMIC Tue Oct 31 08:37:43 UTC 2023 (e7a2e23) x86_64 x86_64 x86_64 GNU/Linux

Additional Context
Additionally, the link to the CommonCrawl dump in the readme.md is broken. I have used this link instead: https://commoncrawl.org/overview.

It seems I was wrong.
I just created a folder named 'cc' as the destination, and it worked.  Maybe I should create the destination folder first.


[BUG]  Updating to azure-core-amqp 2.9.9 causes breaking runtime change in ServiceBusReactorAmqpConnection super class call

Describe the bug
Updating to azure-core-amqp 2.9.9 causes breaking runtime change in ServiceBusReactorAmqpConnection super class call.
Updating the azure-core-amqp dependency to 2.9.9 introduces this problem where it's passing 11 arguments to something taking 10. This is compiling against com.azure:azure-core:1.52.0.
Exception or Stack Trace
java.lang.NoSuchMethodError: 'void com.azure.core.amqp.implementation.ReactorConnection.<init>(java.lang.String, com.azure.core.amqp.implementation.ConnectionOptions, com.azure.core.amqp.implementation.ReactorProvider, com.azure.core.amqp.implementation.ReactorHandlerProvider, com.azure.core.amqp.implementation.AmqpLinkProvider, com.azure.core.amqp.implementation.TokenManagerProvider, com.azure.core.amqp.implementation.MessageSerializer, org.apache.qpid.proton.amqp.transport.SenderSettleMode, org.apache.qpid.proton.amqp.transport.ReceiverSettleMode, boolean)'
        at com.azure.messaging.servicebus.implementation.ServiceBusReactorAmqpConnection.<init>(ServiceBusReactorAmqpConnection.java:79)
        at com.azure.messaging.servicebus.ServiceBusClientBuilder$V2StackSupport.lambda$createConnectionCache$0(ServiceBusClientBuilder.java:1360)
        at com.azure.core.amqp.implementation.ReactorConnectionCache.lambda$new$0(ReactorConnectionCache.java:84)
        at reactor.core.publisher.MonoSupplier.call(MonoSupplier.java:86)
        at reactor.core.publisher.FluxFlatMap.trySubscribeScalarMap(FluxFlatMap.java:127)
        at reactor.core.publisher.MonoFlatMap.subscribeOrReturn(MonoFlatMap.java:53)
        at reactor.core.publisher.InternalMonoOperator.subscribe(InternalMonoOperator.java:57)
        at reactor.core.publisher.FluxRetryWhen.subscribe(FluxRetryWhen.java:77)
        at reactor.core.publisher.MonoRetryWhen.subscribeOrReturn(MonoRetryWhen.java:46)
        at reactor.core.publisher.InternalMonoOperator.subscribe(InternalMonoOperator.java:57)

Hi @talios, thank you for reaching out. The 2.9.9 is not compatible with the previous versions of Service Bus and Event Hubs. The Service Bus and Event Hubs libraries aligning with the changes in 2.9.9 are slated for September release (within 1-2 weeks)
In most cases, applications acquire azure-core-amqp as a "transitive dependency" (e.g., via Service Bus). I'm interested to learn about your particular use case that requires "direct dependency" on azure-core-amqp.

Over the years, we have developed a process to prevent the use of transitive dependencies and to require locked version ranges in our projects. This approach aims to facilitate reproducible builds, especially when working on hotfixes or support branches.
We adopted this practice because we faced runtime issues caused by other libraries introducing API-breaking changes in their transitive dependencies. These problems would sometimes only surface after deployment or release.
For example, we encountered an issue with the Spring library, which had included a transitive dependency with an open range. Despite locking the version of Spring, we inadvertently introduced a new and unchecked dependency change, leading to a runtime application failure.
In this specific case, an API-breaking change was introduced in a patch release, which is typically meant for minor bug updates and should not break compatibility. Adhering to SEMVER or not, it is generally expected that patch releases do not introduce breaking changes.
I remember that one of the common suggestions when reporting issues was to ensure that we are using the latest version of dependencies. As a result, we have moved away from directly depending on the Bill of Materials (BOM) for most of our dependencies - this may have been a bit preemptive of us tho.

Hello @talios, thank you for your response and the details. Unfortunately, a big redesign caused an internal/impl type breaking change affecting apps pinning this core version, usually pulled as transitive via main packages (Service Bus, Event Hubs). Sorry for any trouble this has caused. We've released the version of Service Bus/Event Hubs to align with this update.
Please bump up to the service bus version 7.14.4 (and Event Hubs 5.19.0 if app using EH).  I’ll go ahead and close this issue.


Initial cleanup of core shell script

NOTE
This is a WIP meant to flag what's being done behind the scenes. Currently untested so it'd be a good idea to not approve the merge until you've ran it on your end. I'll be doing the same locally and update the PR when I've tested it.
@moraroy Please leave comments on individual TODOs / proposed changes with yea/nay and I'll honor your requests.

use $PATH bash shebang
capture exit code from pipes
locally removed .shellcheckrc  and hardcoded # shellcheck disable=SC____ to pinpoint language server errors
environment variables to get actual user calling script ($HOME can be /home/root if called via sudo)
parameterize working directory technically already existed, just 1000+ lines down — moved to top of the script and replaced hardcoded filepaths
added a bunch of inline TODOs
add error handling for killing steam by process id (pid)
removed unnecessary newlines
fixed indents on various code blocks
tidied nested python script per pep8 (e.g., newlines between functions)
set script as executable (chmod +x)

For context re: killall steam patch:
Before

After

Should probably clarify, own a Steam Deck, but in the process of migrating to the ROG Ally running a community fork of SteamOS / HoloISO, ChimeraOS.

Wait wait wait this is interesting actually @pythoninthegrass Is there a way I can message you on discord or something I need to show you something haha

Sure thing. My handle is exographicskip


hi Please answer

how to find your contact i want to connect with you for business

@Bintangelfandri check here https://github.com/MShawon

I didn't get your email address, I'm developing a gui interface for your script, can we work together, give me your social media contacts,


Fix race in broker version check

Move it until after we're sure we have a version to check against. Fixes a race
found by @kchaliki (https://github.com/Shopify/sarama/pull/678#issuecomment-226786282).
Also make the which-version-do-I-need part of the protocol interface where it
belongs.

@eapache thanks for the fix, I can confirm I no longer get a panic due to the nil pointer, however I still don't see a timestamp applied to my messages - does it work for you?

I have not been able to properly test this yet; it seems there are some broker-side settings that may need to be set in addition to just producing with the right message version?

Indeed, I will dig some more

Confirmed after running
kafka-topics.sh  --zookeeper blah --alter --topic mytopic --config message.timestamp.type=LogAppendTime
I get timestamps. I think one small issue is they are millisecond timestamps and that is not accounted for correctly when parsing the response and calling time.Unix(block.Timestamp, 0)

Something like this does the trick
timestampNsec := block.Timestamp % 1000
timestampSec := block.Timestamp / 1000
timestamp := time.Unix(timestampSec, timestampNsec)


⚠ HawkeUno has degraded performance

In 2c702bf, HawkeUno ($UNO) experienced degraded performance:

HTTP code: 403
Response time: 3337 ms

Resolved: HawkeUno performance has improved in f6632c8 after 2 hours, 12 minutes.


SAK-32117 - Content review is disabled for all options after selecting NON-ELECTRONIC submissions

Content review is disabled for all options after selecting NON-ELECTRONIC submissions.
This was fixed in master, for some reason wasn't merged in 11.x

Okay, this looks like it was fixed in in an unrelated SAK-31638 which isn't getting back into 11 because it seemed unfinished/untested.

I'm okay with this 11.x merge because it looks like SAK-31638 isn't going to be backported.

Thanks!


Auto-upgrade to <IP_ADDRESS>

Base PullRequest
default branch (https://github.com/http4k/http4k-connect/tree/master)
Command results

Details:

add path
/home/runner/work/_actions/technote-space/create-pr-action/v2/node_modules/npm-check-updates/build/src/bin

./upgrade_http4k.sh <IP_ADDRESS>

Changed files

Changed file:

gradle.properties

:octocat: Repo | :memo: Issues | :department_store: Marketplace

Codecov Report

Merging #136 (1d4cf14) into master (ca78ae9) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #136      +/-   ##
============================================
- Coverage     62.42%   62.38%   -0.05%
  Complexity      659      659
============================================
  Files           396      396
  Lines          4256     4248       -8
  Branches        311      310       -1
============================================
- Hits           2657     2650       -7
  Misses         1412     1412
+ Partials        187      186       -1

Impacted Files
Coverage Δ

...in/kotlin/org/http4k/connect/amazon/sns/FakeSNS.kt
81.81% <0.00%> (-2.80%)
:arrow_down:

.../http4k/connect/amazon/secretsmanager/endpoints.kt
93.33% <0.00%> (-0.79%)
:arrow_down:

.../kotlin/org/http4k/connect/amazon/kms/endpoints.kt
90.90% <0.00%> (-0.76%)
:arrow_down:

.../kotlin/org/http4k/connect/amazon/sts/endpoints.kt
79.31% <0.00%> (-0.69%)
:arrow_down:

...rg/http4k/connect/plugin/Http4kConnectProcessor.kt
0.00% <0.00%> (ø)

...in/kotlin/org/http4k/connect/amazon/sqs/FakeSQS.kt
93.33% <0.00%> (+5.83%)
:arrow_up:

...ain/kotlin/org/http4k/connect/example/endpoints.kt
100.00% <0.00%> (+12.50%)
:arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Very big rom size

Changing STM32F103 type from C8T6 to CBT6 can be dangerous and can lead to unpredictable system behavior.
It will compile, but C8T6 has smaller program memory and some code after programming can be cut...
Maybe we should work on fitting code in 64kBytes?

Of course it could, but first dirty porting exploded to 100kB from Atmega8 code - there has to something wrong and code clean you is neccessary

First problem is fonts used with display.
In GFX lib we can comment out unused font defines, need to search code for used fonts and comment out unused. This will give few kBytes smaller flash.

Removing SPI support from SSD1306 lib gave 1264 bytes lighter code.
I think there is more unnecessary code to remove from libs.
We shouldn't bother to keep SPI in display lib, cause we support only one platform which uses I2C ;)

I'm preparing to rewrite this using HAL without usage of Arduino. The code will be smaller.
Also it will work better cause I will use DMA, HW I2Cs, SPI only software because of swapped lines on board


ionImgDidLoad fires before before inner img  load event

Bug Report
Ionic version:

[x] 4.x
Current behavior:

I want to display a placeholder image while the ion-img is loading
using ion-img component and binding to the ionImgDidLoad event. the event would fire as soon as the image start loading.
Expected behavior:
from its name ionImgDidLoad event must be fired after the image have been completely loaded.
Steps to reproduce:

Related code:
https://stackblitz.com/edit/ionic-4-template-fewyal?embed=1&file=src/app/home/home.page.html
https://stackblitz.com/edit/ionic-4-template-fewyal?embed=1&file=src/app/home/home.page.html

<ion-content padding>
    <ion-img class="placeholder-img"
      src="https://via.placeholder.com/150"
      [style.display]="loaded ? 'none' : 'unset'"
    ></ion-img>

    <ion-img class="full-img"
      [src]="'https://picsum.photos/5000/5000'"
      [style.opacity]="loaded ? 1 : 0"

      (ionImgDidLoad)="loaded = true"
      ></ion-img>
</ion-content>

Other information:
the issue is related to this part of the ion-img source
private load() {  this.loadSrc = this.src;  this.ionImgDidLoad.emit();  }
the event is triggered as soon as the src attribute is set, i think this event must be frenamed to ionImgStartLoad, and add another event ionImgDidLoad that is fired when the inner img load completed.
Ionic info:

Ionic:

   ionic (Ionic CLI)             : 4.10.3 (C:\Users\jahmani\AppData\Roaming\npm\node_modules\ionic)
   Ionic Framework               : @ionic/angular 4.0.1
   @angular-devkit/build-angular : 0.7.5
   @angular-devkit/schematics    : 0.7.5
   @angular/cli                  : 7.3.1
   @ionic/angular-toolkit        : 1.4.0

Cordova:

   cordova (Cordova CLI) : not installed
   Cordova Platforms     : not available
   Cordova Plugins       : not available

System:

   NodeJS : v10.15.1 (C:\Program Files\nodejs\node.exe)
   npm    : 6.4.1
   OS     : Windows 10

Hi there,
Thanks for opening an issue with us! Which browser/version are you seeing this issue with?

Google crome

But I think it's unrelated to the browser. It's a bug in the ion-img component code.
It must wait the inner image load event before emiting this Event - ionImgDidLoad - .
Also I suggest adding another onError event in case the img failed to load.  Or providing a public proxy property for the inner img element

Hi there,
Thanks for the follow up. I am not seeing the issue you are describing. Can you provide a repository with the code required to reproduce this issue?
Thanks!

Hi @liamdebeasi
TLDR: using ion-img. how to show a placeholder img while the ion-img src being loaded or if it failed to load?
https://stackblitz.com/edit/ionic-4-template-fewyal?embed=1&file=src/app/home/home.page.html
in this stackblitz example .
in a normal html img element a placeholder img will be displayed while loading the full-img or if loading full-img failed;
in the ion-img element. the placeholder not displayed  at all. the full-img will be rendered as soon as it's being observed.

Hi @jahmani,
Thanks for the additional info! I am able to reproduce what you are describing. Thanks for the bug report -- we will look into this!

I would like to propose having two events:

ionImgDidLoad  - Emitted when the img has been loaded
ionImgIsLoading -  Emitted when the img src has been set (i.e., actual img loading starts)

Notice, that in current implementation ionImgDidLoad is emitted as soon as src is set. This proposal suggest that instead ionImgIsLoading is emitted when omg sr is set and then when actual image is loaded, emit ionImgDidLoad.
Also notice that this would be a breaking change since it is changing when ionImgDidLoad is emitted.
I will be submitting PR for this shortly for review.

Hi @vhinic,
Please submit a Feature Request. This thread is only being used to track the bug noted by the author.
Thanks!

Hi @liamdebeasi, I'm a bit confused... I'm offering to fix the bug reported by @jahmani. Why is new issue required?

Hi @vhinic,
You are proposing a new API called ionImgIsLoading, so we typically ask for a Feature Request so we can track and discuss the changes.

I understand. I'm only proposing introduction of new event so that existing functionality can be retained. The new behaviour for existing event ionImgDidLoadis fixing original issue. But capturing existing behaviour have value as well. That is why I proposed introducing  ionImgIsLoading so that existing functionality is not lost. My apology if this was not clear.

I create new feature request that addresses and expands on above issue:
https://github.com/ionic-team/ionic/issues/18161

Ah that makes sense. Ok I will talk with the team to see if ionImgIsLoading is an API we'd like to introduce to the framework. You can keep your PR as it is for now, and we will follow up there for any discussion regarding it. 🙂
Thanks!


Suggest changing Upload/Download to Backup/Restore

Aldo I've used this package a few times, every time I have to wait and think what upload and download mean. Choosing the wrong action overrides everything, without confirmation (feature?).
I want to propose to change the actions to other words:

Upload → Backup
Download → Restore

:+1: Agree, sounds more accurate.


Question: InputLengthRestrictions.TokenHandle configurable?

I see that InputLengthRestrictions.TokenHandle does not have a public setter, which I ran into when playing with a token generation scheme that was generating strings of length > 100.
Before making a PR, is there any desire:

to have this value configurable?
have reference token handles validated as they're generated (.. and so have an incorrect implementation detected earlier)?

which I ran into when playing with a token generation scheme that was generating strings of length > 100.

How? IIRC we gen a 128 bit random number and put that into a base64url encoded string.

Sorry, I really should have said "playing with a token handle generation scheme".
I've got my own implementation of IReferenceTokenStore that fully encapsulates reference token storage, and so does not depend on IHandleGenerationService / DefaultHandleGenerationService in anyway.

Hmm... well, we have to have some limits. We'll take a look.

Absolutely agree that there needs to be a limit -- only question is could it be configurable by users of IdentityServer4.

Done.


Undo history dock widget

Have a dock widget that shows a list of all undo entries as well as current location in the undo history, with the ability to roll back to any entry

Added in 4.1.5277-dev


Add La Trobe

Uni URL: https://www.latrobe.edu.au/
Course URL: https://www.latrobe.edu.au/courses/bachelor-of-information-technology
Email Domain Proof URL: https://www.latrobe.edu.au/students/support/it/email
https://www.latrobe.edu.au/students/support/it/email/email/access-email/personal-desktop-or-notebook/other-mail-clients
http://latrobe-current.custhelp.com/app/answers/detail/a_id/1044/~/student-email-address

@PersonIKnow Pull request merged. Thank you!


Add Tests

Need to add unit, integration and e2e tests

Can I work on this one?

Added Unit test


SHACL implementation (CP-23)

I can see the CI failing but I am not understanding the cause. What do you mean by it expecting last line of tile to be blank? Which file?

FYI, I also caught an oversight in the changes for CP-69.
All of the typos had been fixed except for the NetworkConnection ones.
So, that is the other commit here.

rdf-toolkit expects all normalized turtle files to end with a blank line.  Unfortunately, text editors (yours included) tend to remove trailing blank lines.  Git style guidance does the same.
The files you just touched had their trailing blank lines removed (uco.ttl and observable.ttl).
Sorry that my comment wasn't clear.  I commented on the patch and Github shifted that comment to the PR.
Thanks for the NetworkConnetion catch.

Ok. So, it sounds like the CI issue is not something I can fix but you can?
Other than that issue it should be ready to approve and merge into develop

There are a few other minor matters reported by rdf-toolkit, sort order and dangling -da references.  I'm fixing now.

The CI tests have returned to failing at the expected location based on the pyshacl bug.
It occurs to me this might be correctable with a pytest skipif based on the pyshacl version, so we could have this merge with a passing CI.  @sbarnum , would you prefer a passing CI, or merging and just "soft"-expecting CI to fail?

...Eh, scratch that, it makes the Makefile a bit more complex.
I suggest merging now.  I've assigned the PR to you so you can merge if you concur.

I concur with merging as is.


Windows specific warning message in chrome console: "(webpack)/buildin/module.js There are multiple modules with names that only differ in casing...."

Environment: Windows,  use npm link angular-cli to the master branch of Angular-cli repository, apply to any projects created with CLI.

Warning message in Chrome's console window:

(webpack)/buildin/module.js
There are multiple modules with names that only differ in casing.
This can lead to unexpected behavior when compiling on a filesystem with other case-semantic.
Use equal casing. Compare these module identifiers:
* c:\Projects\angular-cli\node_modules\source-map-loader\index.js!C:\Projects\angular-cli\node_modules\webpack\buildin\module.js
    Used by 1 module(s), i. e.
    c:\Projects\angular-cli\node_modules\source-map-loader\index.js!C:\Projects\github-client\node_modules\rxjs\util\root.js
* c:\Projects\angular-cli\node_modules\source-map-loader\index.js!c:\Projects\angular-cli\node_modules\webpack\buildin\module.js
    Used by 2 module(s), i. e.
    c:\Projects\angular-cli\node_modules\source-map-loader\index.js!c:\Projects\angular-cli\node_modules\punycode\punycode.js

Discussed with @filipesilva who noticed that C: is different thanc:. The command line tool on windows use capital C in default. I tried to use cd c:\project to change the path with lower case c: and the warning message was gone.

Definitely a weird issue. I don't think it's a CLI issue per se, but perhaps a node issue. I'm closing for now as a workaround has been reached and it doesn't seem to be a widespread thing, but will reopen if more reports arrive.

Having exactly same issue with cli version: "1.0.0-beta.11-webpack.2", on windows 10 with node 6.3.1.
WARNING in (webpack)/buildin/module.js
There are multiple modules with names that only differ in casing.
This can lead to unexpected behavior when compiling on a filesystem with other case-semantic.
Use equal casing. Compare these module identifiers:
* C:\Users\asad\ng2fb-material\node_modules\source-map-loader\index.js!C:\Users\asad\ng2fb-material\node_modules\webpack\buildin\module.js
    Used by 2 module(s), i. e.
    C:\Users\asad\ng2fb-material\node_modules\source-map-loader\index.js!C:\Users\asad\ng2fb-material\node_modules\punycode\punycode.js
* C:\Users\asad\ng2fb-material\node_modules\source-map-loader\index.js!c:\Users\asad\ng2fb-material\node_modules\webpack\buildin\module.js
    Used by 1 module(s), i. e.
    c:\Users\asad\ng2fb-material\node_modules\rxjs\util\root.js
Child html-webpack-plugin for "index.html":
         Asset     Size  Chunks       Chunk Names
    index.html  2.41 kB       0
webpack: bundle is now VALID.

If there's an updated webpack version that addresses this issue we're happy to use it!

Hy Guys,
This happened with me too. I figure out what causes the problem. The driver letter where I was running the application was not in capital letter e.g.
c:\Project> instead of C:\Project>.
This happend because i switched from one directory to other using the command

cd /d c:\project

because i was in H:>.


#92656 (native JSON types) does not support custom objects

Tested versions
4.4-dev2
System information
n/a
Issue description
Per the request of @fire from PR #92656
The new JSON methods from_native and to_native do not appear to work with Objects of user created classes. The code I used to test this is in the steps to reproduce.
I could be wrong, but I believe the underlying issue is that the entire script is being serialized, and when it is loaded it is trying to override the existing script thus causing a class name conflict. I do not see any reason a developer would want to serialize the entire source code of an object's script into JSON. Many developers use JSON to avoid this security issue that exists in Resources currently.
It could make more sense to simply serialize the script's path, and load it to create a new instance of the object. But I don't know if that's the best solution as projects get refactored and saves need to be preserved. I handled it a bit differently for that reason in my WIP JSON addon, by allowing devs to define "configurations" for each object type which contain the script/scene that should be instantiated & a unique ID for that configuration which is what is stored in the JSON.
But besides that thanks to those who put their time in for this PR, definitely great for many devs when it comes to the rest of native types
Steps to reproduce
MyClass extends Resource and has 1 simple string var.
var my_class: MyClass = MyClass.new()
var json: String = JSON.stringify(JSON.from_native(my_class, true, false))
# Prints: # {"__gdtype":"Object","properties":{"resource_local_to_scene":false,"resource_name":"","serialize_this":"test"},"type":"Resource"}
print(json, "\n")
var deserialized: Variant = JSON.to_native(JSON.parse_string(json), true, false)
# Prints: false
print(deserialized is MyClass)

# Testing with the script param as true
var json_with_script: String = JSON.stringify(JSON.from_native(my_class, true, true))
# Prints:
# {"__gdtype":"Object","properties":{"resource_local_to_scene":false,"resource_name":"","script":{"__gdtype":"Object","properties":{"resource_local_to_scene":false,"resource_name":"","script/source":"class_name MyClass extends Resource\n\t\n@export var serialize_this: String = \"test\"\n"},"type":"GDScript"},"serialize_this":"test"},"type":"Resource"}
print(json_with_script, "\n")
# Below throws: Parser Error: Class "MyClass" hides a global script class.
var deserialized_with_script: Variant = JSON.to_native(JSON.parse_string(json_with_script), true, true)

Minimal reproduction project (MRP)
n/a see steps to reproduce

I'm providing a MRP for convenience
JsonDesserializeScriptBug.zip
Note that, when allowing scripts (the third parameter in JSON.from_native) the generated dictionary contains the script source itself, wich does not seem correct at all for non embeded scripts (in the MPR I have used a separate script file, not an embedded script).
The error "MyClass hides a global script class" probably happens because when desserializing with JSON.to_native the newly created script, wich is not relatedto the previously existing script at all, tries to "steal" the class_name from it by declaring an already existing class_name.
I don't know what is the intended behavior when serializing/deserializing scripts (if there is one), but at least when desserializing by the same application that serialized the object, I think that the user expected behavior is to have the desserialized object to reference the previously existing script, and not for a new script to be created, not tied to the previous one, to be created. Maybe there should be a special case for scripts where besides serializing the object itself, a reference to the resource path should be added so that, when unserializing in another application, it would create a new script, but when serializing in an environment where the resource path exists and is a script, the serialized script data is discarded (except for exported variables) and the existing resource in the refered resource path is used.
{
  "__gdtype": "Object",
  "properties": {
    "resource_local_to_scene": false,
    "resource_name": "",
    "script": {
      "__gdtype": "Object",
      "properties": {
        "resource_local_to_scene": false,
        "resource_name": "",
        "script/source": "class_name MyClass extends Resource\n\t\n@export var serialize_this: String = \"test\"\n"
      },
      "type": "GDScript",
      "resource_path": "res://"
    },
    "serialize_this": "test"
  },
  "type": "Resource"
}

I didn't want to hard code special processing since I'm fetching the property as if it was a string and putting it into the json.
I feel like special processing would be a separate system? maybe a callback or a better design.
However, this is bad in the sense that the surprising behavior of serializing an object to string has an unexpected result and there's no natural way of fixing it.
We could remove class_name though, but I'm not an expert at gdscript internals.

For the script property I think the security issue definitely warrants a special case to omit it.
I faced this issue in my project and thought on it way too long. Not sure if it helps, but here's a breakdown of what I went through
The problems:

When developers serialize to JSON, they don't want all properties included. script being one of them. There are many others such as process_mode which don't need to be stored in game save files. 99% of the time you only need to save data relevant to player's game save. Not the configuration of your scene tree; that's done in the editor by the developer. So how do we determine which properties are to be serialized?
Detecting what class a serialized object is. Is it native? Is it based on a script?
After the above is solved, how do we determine how to create an instance of this object? What if it's based on a PackedScene and not just a script?
Another consideration, what if this is a dynamic Array or Dictionary containing objects? Such as an array of "Enemy" nodes that all extend from "Enemy" but are their own classes. That eliminates the possibility of a user passing an instance of an object into JSON.to_native() to deserialize into that object.
Property names, class names, and script paths all change throughout the development cycle. What's the best way to help a developer preserve their saves without too much of a headache?

Below is what I did to tackle this issue. Not saying it is perfect to build into the engine but could maybe spark up some ideas.
My solution:
A global instance that manages "json specification" resources on how to serialize a specific class. It contains an id which the developer sets & does not change to preserve saved data.
Next the developer sets what class this specification is for. Can be set by script or by inputting the class name (for native object support). Then they set how to construct instances of the object. I used a "json instantiator" resource which I extended into a few implementations; Native (constructs instance using ClassDB & class name), Script (constructs instance from a gdscript), and PackedScene (constructs instance from a scene file). This feature prevents class name & script path changes from breaking saves.
Finally, the user selects which properties are to be serialized, each property is its own resource within the object's specification resource. I made it easy using PROPERTY_HINT_ENUM_SUGGESTION and setting that hint as a list of all of the properties of the class & its parents. For the actual engine this would be better off using the property selector UI (like MultiplayerSynchronizer has). Also, each property gets its own "json key" string that is used to store the property in JSON, this protects against the property name changing as long as the dev updates the property resource after changing the property name.
Now any supported object can be serialized whether it's a standalone instance, a property of another object, or in an array/dictionary.
The only downside is that it's a bit of legwork to configure it for all of your objects. But the benefits of no boilerplate code, nice clean save files w/o excess properties, and seamless Object -> JSON -> Object functionality are well worth the trade off.

Why would a local instance that manages "json specification" resources not work?
You would pass in parameter array that contains all the instructions on how to serialize a specific class to the JSON to native methods.

I don't know if a node would be correct.
The defining difference between RefCounted objects and Node objects is that Nodes have _process and _physics process (internal versions too).
Does your manager need ticking?

No not all, it is set & forget (until you need it). Can always be a Resource/RefCounted, I just suggested a node so its easier to make it globally accessible which I think would usually be the case. But easy enough to do that with a resource or refcounted as well.

Do you think you're able to make a pull request implemnting this? I can also port gdscript versions of this.
I think keep it local to a Resource is the best approach for now. Like manually pass a resource to the JSON to native from native.

Possibly
I don't know C++, just enough to (kind of) read it, and don't have the time to learn it so it'd have to be in gdscript. I am also a bit clueless on where I'd put these gdscript files & how this whole process would work with me writing it in gdscript in a fork, unless you want me to just write this system separately & not in a forked repo

Write this system separately if that's easiest.

@neth392

Want me to just write this system separately & not in a forked repo

Yeah. Then once we've narrowed the design we can port to c++.


chore(deps): update dependency ts-jest to v29

This PR contains the following updates:

Package
Type
Update
Change

ts-jest (source)
devDependencies
major
28.0.8 -> 29.0.0

Release Notes

kulshekhar/ts-jest
v29.0.0
Compare Source
Features

drop Node 12 and Node 17 support (#3787) (0f1de16)
migrate globals config to transformer config (#3780) (31e5843)
support Jest 29 (#3767) (94b553b)

DEPRECATIONS

Define ts-jest config under globals is now deprecated. Please define the config via transformer config instead.

BREAKING CHANGES

Only Node 14, 16 and 18 are supported
Jest 29 is required.

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Renovate Bot.

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: package-lock.json
Found file in cache: /tmp/renovate/cache/containerbase/7576b42decc67f70b61585f41c5074bea75c260886346e567578ea0e0dc2d571/node-v16.17.0-linux-x64.tar.xz
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/jest
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/ts-jest
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /tmp/renovate/cache/others/npm/eresolve-report.txt for a full report.

npm ERR!


Assistance Needed: Missing Address (Zip Code, Street Name) and Picture URL for MercadoPago Integration HONZEM

Hello,
I'm encountering issues with the MercadoPago payment integration due to missing fields in our system. Specifically, when processing payments, we’re required to provide zip_code, street_name, and picture_url fields, but these are currently unavailable in the customer and product data. This results in the following errors:
Undefined array key "zip_code"
Undefined array key "street_name"
Undefined array key "picture_url"

platform/plugins/fob-mercadopago/src/MercadoPagoPayment.php
        $data = apply_filters(PAYMENT_FILTER_PAYMENT_DATA, [], $request);
        try {
            /** @var Preference $preference */
            $preference = app(MercadoPagoClient::class)
                ->createPreference([
                    'external_reference' => $data['order_id'][0],
                    'auto_return' => 'all',
                    'installments' => 1,
                    'default_installments' => 1,
                    'items' => array_map(fn ($item) => [
                        'id' => Arr::get($item, 'id'),
                        'title' => Arr::get($item, 'name'),
                        'picture_url' => Arr::get($item, 'image'),
                        'currency_id' => Arr::get($item, 'currency'),
                        'quantity' => (int) $quantity = Arr::get($item, 'qty'),
                        'unit_price' => Arr::get($item, 'price_per_order') / $quantity,
                    ], $data['products']),
                    'payer' => [
                        'name' => $data['address']['name'],
                        'email' => $data['address']['email'],
                        'phone' => [
                            'number' => $data['address']['phone'],
                        ],
                    ],
                    'back_urls' => [
                        'success' => route('payment.mercadopago.callback'),
                        'failure' => route('payment.mercadopago.callback'),
                        'pending' => route('payment.mercadopago.callback'),
                    ],
                    'notification_url' => route('payment.mercadopago.webhook'),
                    'address' => [
                        'zip_code' => $data['address']['zip_code'] ?? 'none',
                        'street_name' => $data['address']['address'] ?? 'none',
                    ],
                    'metadata' => [
                        'order_id' => $data['order_id'],
                        'customer_id' => $data['customer_id'],
                        'customer_type' => $data['customer_type'],
                        'checkout_token' => $data['checkout_token'],
                    ],
                ]);
            echo view('plugins/fob-mercadopago::checkout', [
                'preferenceId' => $preference->id,
                'publicKey' => get_payment_setting('public_key', 'mercadopago'),
                'locale' => $this->getLocale(),
            ])->render();
            exit();
        } catch (MPApiException $e) {
            return [
                'error' => true,
                'message' => 'API error: ' . $e->getApiResponse()->getContent()['message'] ?? $e->getMessage(),
            ];
        }
    }

Since our customer/agent registration and product data do not currently include these fields, we're unable to populate them when creating the payment request for MercadoPago. Could you please provide guidance on how we can address this? Additionally, would it be possible for the development team to add these fields to the system or suggest an alternative solution to ensure compatibility with MercadoPago’s requirements?

The payment gateway is currently only compatible with e-commerce scripts.

The payment gateway is currently only compatible with e-commerce scripts.

thanks for the answer. I really need this integration with Homzen, wouldn't there be a simple way (I know it's never that simple) to make it work in Homzen?


Refactor DomAppplier

This PR pursues the following goals:

Simplify the DOM application logic and readibility
Prepare code for supporting SVG entities.

Merged


gh-1672 - Register Default ScoreResolver implementations

Any implementations of ScoreResolver which are native to Gaffer are now added to the list of available ScoreResolvers by default.
This can easily be expanded as and when any new implementations are added, but still allows for externally configurable resolvers to be added via a json config file.

Codecov Report

Merging #1673 into develop will increase coverage by <.01%.
The diff coverage is 100%.

@@              Coverage Diff              @@
##             develop    #1673      +/-   ##
=============================================
+ Coverage      65.78%   65.78%   +<.01%
+ Complexity      1949     1948       -1
=============================================
  Files            801      801
  Lines          25754    25760       +6
  Branches        3310     3310
=============================================
+ Hits           16941    16947       +6
  Misses          7484     7484
  Partials        1329     1329

Impacted Files
Coverage Δ
Complexity Δ

.../operation/handler/ScoreOperationChainHandler.java
82.19% <100%> (+1.59%)
0 <0> (ø)
:arrow_down:

...onutil/iterable/LimitedInMemorySortedIterable.java
47.22% <0%> (-2.78%)
15% <0%> (-1%)

...store/operation/resolver/DefaultScoreResolver.java
88.23% <0%> (+11.76%)
0% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 530353c...a8d2141. Read the comment docs.


Multiple editor crashes on fedora 37 / godot 4 beta 10 - mono build

Godot version
4.0 Beta 10 Mono
System information
Fedora 37, Intel i5-11300h, IGPU
Issue description
While running a project from within the editor, the editor crashes quit often without any output to console (5/6 times a day).
Steps to reproduce
Just open the editor and after 10-20 starts it just closes but the game keeps running. Example coredmp is provided.
coredmp.txt
Minimal reproduction project
N/A

Can you reproduce this with a non-Mono build, or on a blank project?

@Calinou Well, after lots of days of crashing i don't experience them anymore. Maybe because i upgraded to Beta 11? Guess the ticket can be closed for now.


Updating service health incident page

Updated 2nd table formatting

Thank you. I've added the missing period at the bottom.
It's important that we change the title as it is more appropriate to what the feature is about.

@efrene Please merge this PR. Thanks


added header customizability to graphql.Request

This PR gives developers the ability to add their own headers to a graphql.Request. The graphql.Request.Header mirrors the Header of a http.Request. It contains the request header fields sent by the client.
If a server received a request with header lines,
Host: example.com
accept-encoding: gzip, deflate
Accept-Language: en-us
fOO: Bar
foo: two

then
Header = map[string][]string{
  "Accept-Encoding": {"gzip, deflate"},
  "Accept-Language": {"en-us"},
  "Foo": {"Bar", "two"},
}

+1


backport: tor-browser-bundle-bin: 9.0.1 -> 9.0.2

Motivation for this change
Backporting newest version of tor-browser-bundle-bin to stable release.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Notify maintainers
cc @

Please use git cherry-pick -x for backporting in the future. See https://nixos.org/nixpkgs/manual/#submitting-changes-stable-release-branches.


chore: bump chart version to v0.3.4

Hello,
Do you have ETA for this PR, so new chart version 0.3.4 can be used ?


Bump default git clone plugin

and add alternate quay registry to trusted clone image
add alternate registry for buildx plugin

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@479e500). Click here to learn what that means.
 Consider uploading reports for the commit c873fd2 to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2215   +/-   ##
=======================================
  Coverage        ?   40.80%
=======================================
  Files           ?      182
  Lines           ?    10897
  Branches        ?        0
=======================================
  Hits            ?     4446
  Misses          ?     6110
  Partials        ?      341

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

->  #2220


VE-160 Update TransferList

Closes VE-160
Changes
This PR updates the TransferList to be used to replace the application specific implementations in Vehicle, ID, and Data.

Removes the old method of transferring on check
Items are now selected for transfer on click
Items are transferred on clicking a transfer button
Add secondary labels
Updated style to match new figma design
Client side optimistic transfer with a callback function
Controlled transfer to ignore default functionality

UI/UX
https://github.com/user-attachments/assets/804da284-0200-4d4d-b75c-45e2e6c0ad72

Testing notes

Selected items transfer correctly
Select all functions correctly
The onTransfer callback is called correctly
handleTransfer calls prop and does not change the UI
Filtered items that have already been selected still transfer
Selected items should always reflect the unfiltered data

Author checklist
Before I request a review:

[x] I have reviewed my own code-diff.
~[ ] I have tested the changes in Docker / a deploy-preview.~
[x] I have assigned the PR to myself or an appropriate delegate.
[x] I have added the relevant labels to the PR.
[x] I have included appropriate tests.
[x] I have checked that the Lint and Test workflows pass on Github.
~[ ] I have populated the deploy-preview with relevant test data.~
[x] I have tagged a UI/UX designer for review if this PR includes UI/UX changes.

Could you give this a look over please @Sowbhagya-ipg? Thanks

Looks good to me @lukemojo

Lets make sure that we have relevant selectors in the code as well so that @vjayap can correctly target elements of this component in automated e2e testing.

Which release is this destined for? Currently set to main.

Before releasing this I suggest you integrate it into VIRTO.DATA on a branch with a deploy preview. If it's truly a non-breaking change then that should just mean bumping the dependency. I see it used in two places in DATA currently.

There seems to be flicker and layout shift as I move items from one side to the other in the parameter set UI in DATA.
https://github.com/user-attachments/assets/16377883-4411-48c0-9644-23ee3549c061

Not sure if related to DATA or the RUI component, but when I moved everything from one list to another, for one render everything appears selected in the other list before they get deselected:
https://github.com/user-attachments/assets/848d0ef4-aad0-4fab-895a-1488674297f9

Issues I reported in DATA depoy preview are now fixed. No further feedback from my side.


Upper constraints do not exclude prerelease (alpha/rc) versions of next higher version

Checks

[X] I have checked that this issue has not already been reported.

[X] I have confirmed this bug exists on the latest version of pixi, using pixi --version.

Reproducible example
pixi add cowpy
cat pixi.toml

Issue description
Upper version constraints do not exclude prereleases
Expected behavior
Expected: Prerelease versions are excluded as well in automatic upper constraints. This is what conda forge does
cowpy = ">=1.1.5,<1.2a0"

Actual:
cowpy = ">=1.1.5,<1.2"

Compare to the pins of conda recipes:
- libzlib >=1.2.13,<2.0.0a0

@baszalmstra do you think this would be correct to always add? Or is there some other logic we could benefit from?

Yeah I think it would be more correct to add it. Its just reaaally ugly. I know @wolfv added this behavior in rattler-build as well.
We could also reevaluate using the ~ operator. That also doesnt include prereleases.