Icon change for macOS Big Sur

macOS Big Sur brings macOS' system icons all with square corners, and some 3rd party developers including Adobe are converting their app icons to match up with these system icons.
Are there any plans for VS Code?

I second this. It's not like all 3rd party apps will adopt the new icon style overnight, but after a while the ones that haven't will start to stick out like a sore thumb.

The release of the developer betas are meant for changes like these, until September/October, most likely most apps will already be using the new icons. And as you said, the ones that aren't will stick out.
Design-wise, this is a really bad practice. An example would be:

A similar situation will happen to all apps when Big Sur is released, this time with circle and freeform icons.

The old macOS icon proposal might be well suited for this change (but in a square shape instead of the hexagon).

Is there a PSD or SVG file for the macOS one?

Perhaps something like one of these?

 Light
 Light Bordered

 Dark
 Dark Bordered

Well, I think adaption to the current theme might be way better suited for an extension. The blue logo simply is a part of VSCode’s branding and shouldn’t be changed by default. Other than that it would make it way harder to differentiate between the Stable version and the Insiders build, if you do use both with the same Theme. Also I’d say that it theoretically would make more sense more sense to switch between the light and dark version depending on the OS setting, but even that would be unexpected behaviour as Apple’s own ions don’t do that as well.
But other than that, I sure do like the Dark and the Dark Bordered Icons. The Overhang versions seem unbalanced to me though.

Check out this, I made some icons 2 weeks ago
https://github.com/mohouyizme/vscode-big-sur-icons

@mohouyizme These are nice, but a shadow for the new look would be better in my opinion. See @austincondiff's icons.

@ardacebi yes I agree, I did that on purpose, I tried to keep it simple without affecting the identity of the logo, maybe adding a shadows version will be good.
 It is however debatable whether or not every third-party icon needs to adopt it. I think it is always good to be consistent while adhering to brand standards.

@austincondiff thanks for the details!

Check out this, I made some icons 2 weeks ago
https://github.com/mohouyizme/vscode-big-sur-icons

This is beautiful. Thanks mate.

With the macOS Public Beta getting out, this is getting more important. Do we have any updates regarding this?

I agree with @ardacebi. Does someone need to submit a PR for this or can a current maintainer pull one of these options in?

Hi @austincondiff,
Thanks mate, I love the icons!
Just 1 comment re:

change the icon according to the theme you have installed

I'd rather have an option in settings to do that. The reason is: I use dark themes everywhere and a very dark wallpaper.
If the dark icon would show up on that - the dark plate of the icon would blend with the background, e.g. like plex does currently:

So, using dark theme, I prefer the icons to have more contrast.
Same as on iOS - a lot of icons use white plate, and more apps allow you to change your icon now.

Here's another choice...

Thanks @austincondiff that looks fantastic on my dock!
Here's the icns version: vscode.icns.zip
and the script for lazy people like me 😄
sudo cp "~/Desktop/vscode.icns" "/Applications/Visual Studio Code.app/Contents/Resources/Code.icns"
sudo touch "/Applications/Visual Studio Code.app"
killall Finder && killall Dock

Love this @austincondiff!

Those mockups look really fantastic @austincondiff - would love to see some form of icon update now that we're at a general release, but am sure there's a ton of stuff on the devs plate atm :)

could even go extra fancy and do something like this https://github.com/rrroyal/AutomaticDockTile

Perhaps something like one of these?

Light
Light Bordered
Light Overhang

Dark
Dark Bordered
Dark Overhang
This may be a separate issue but I think it might be nice to change the icon according to the theme you have installed. The light version would be used for light themes and the dark for dark themes. The color of the logo could be influenced by the primary color of the theme, and the background of the icon could be influenced by the background color of the theme.
EDIT
For those interested, I've done more icons. You can download them here.

Hi!
Great work!
Is there a way to download these? Also the same icons for Visual Studio (NOT code) would be great too.
Thanks.

@kristof12345 have a look here: https://macosicons.com/

@tborychowski Thank. Already checked it, there are hundreds of great icons, but not all of the above shown are there.

Wow, this looks great. Is it available as a .icns?

Here's another choice...

Wow, this looks great, is it available as a .icns?

I agree that the icon should be updated to match.  I am really liking some of the mockups.  Especially:

and

Agreed. I don’t think a light icon is a good idea because it’s too similar to many other Big Sur icons (so it’s easily confused). Additionally, I don’t tend to associate light colours with VS Code, since the default colour scheme is dark.

Here's another choice...

I prefer this one. The other ones are either light or dark themed, but this one works with either light or dark macOS themes.

I’d say the new macOS icons have a lot of shadows and other ‘realistic’ effects. The Messages icon, for example, has a glossy texture, shadow, and the green from the background is colouring the bubble slightly green. The VS Code icons suggested by @austincondiff only have a large shadow (I guess maybe the background on the blue version is colouring the ribbon); reducing this I think would leave the icon too flat.

Anyway, I'm pretty sure Microsoft is already working on an icon :D It really would be cool though if they used an icon from the community...

Oh god please no...

@arzg @gavin310 The MacOS Big Sur Messages icon originally had a much larger shadow. In a recent beta, they slimmed the shadow down quite a bit. I'll play with a smaller shadow. The reason for the shading and textures is the bubble shape is round, while the ribbon is flat.
I'll export files for the rest of the icons when I get a few. Stay tuned.

Here's another choice...

Wow this one is realy nice

I think Microsoft should adopt this whole set...

Perhaps something like one of these?

Light
Light Bordered
Light Overhang

Dark
Dark Bordered
Dark Overhang
This may be a separate issue but I think it might be nice to change the icon according to the theme you have installed. The light version would be used for light themes and the dark for dark themes. The color of the logo could be influenced by the primary color of the theme, and the background of the icon could be influenced by the background color of the theme.
EDIT
For those interested, I've done more icons. You can download them here.

Are the dark overhang versions around anywhere? I much prefer them to the light versions available on the link.

@kristof12345 @DJFriar As promised...

@austincondiff
Do you think a combination of a blue background + whiteish ribbon that have blue reflection would be good? Much like the message icon.

@austincondiff the blue-backgrounded one looks nice, although I suppose to match the system color choices, the background could be brighter and the shadow of the ribbon could be lighter while having a slightly bigger radius.

Here's another choice...

Absolutely love this one!

Now what? When is this going to ship? :)

Should match VS 2019 for Mac icon.

Here's another choice...

(Or, in Google's case, seem to imply the developer resents the broader design language.)

@jeremybanka Knowing Microsoft, they'll most likely end up doing the same and throw it on a white background. Lame! 👎🏻

Love this one. Can anyone do a green version for VSCode Insiders? (cc @austincondiff)

Can anyone do a green version for VSCode Insiders?
@philsinatra here you go!

vscode-insiders.icns.zip

Awesome! Thank you @joerglehmann

Here's one for Exploration :) icns: https://we.tl/t-EnxpwEsIxz

Hi @austincondiff,
Thanks mate, I love the icons!
Just 1 comment re:

change the icon according to the theme you have installed

I'd rather have an option in settings to do that. The reason is: I use dark themes everywhere and a very dark wallpaper.
If the dark icon would show up on that - the dark plate of the icon would blend with the background, e.g. like plex does currently:

So, using dark theme, I prefer the icons to have more contrast.
Same as on iOS - a lot of icons use white plate, and more apps allow you to change your icon now.

If I may know where did you get that terminal icon I really liked it.

@Javierr9
This was iTerm default icon.
New one is more BigSur-themed (rounder).

i see, thank you!
ill take a look at it

So, when can I experience the new official icon?

So, when can I experience the new official icon?

When's the new icon going to be included in a release?

那么，什么时候可以体验新的官方图标？

新图标何时发布到版本中？

Yes

I'm creating a pull request to add @austincondiff 's icon. Does anyone have an idea where the icons for MacOS are located?

@alexfunnell
/Applications/Visual Studio Code.app/Contents/Resources/Code.icns

@tborychowski
I meant in the source code.

@tborychowski I believe it's in /resources/darwin/code.icns

@tborychowski I believe it's in /resources/darwin/code.icns

Had a look, /resources/darwin/code.icns looks like this...

Any further ideas?

@alexfunnell From my understanding, there is a separation between the VSCode builds we get from Microsoft and the open source portion (called Code - OSS). I believe the icon is one of those proprietary bits that isn't found in this repository.
For more details, see: https://code.visualstudio.com/docs/supporting/faq#_what-does-built-on-open-source-mean
The icon you included above is the icon for the Code - OSS project.
As a result, I don't think it's possible for us to help out and change the icon for the official VSCode builds with a pull request here, unfortunately. 😞

@BenJetson
Looks like you are right, unfortunately.

Would love to see an official icon update now that Big Sur has been out for a while. For what it's worth, I prefer the colored (blue/teal/orange) VSCode logo on a dark background square with a shadow.

Here's another choice...

Absolutely love this one!

I 😍 too. Hope he's gonna be used !

Here's another choice...

Replace app icon in 3 steps!

Open this image in your browser & press ⌘+C
Find vscode in your Applications. Select App & press ⌘+I
Click to app icon & press ⌘+V (replace icon from clipboard)! Done.

Here's another one from the amazing Tile Icons pack.
To be honest the entire set is pretty gorgeous and covers a lot of ground. Worth checking out!

Here's another one from the amazing Tile Icons pack.
To be honest the entire set is pretty gorgeous and covers a lot of ground. Worth checking out!

@wzxu The overall shape of the vs code logo is slightly off. For example, the left corners are sharp (not rounded) and it gets too narrow too quick.

@wzxu The overall shape of the vs code logo is slightly off. For example, the left corners are sharp (not rounded) and it gets too narrow too quick.

Folks, how about we stop discussing how the icon should be like and start talking about why no decision has been made by the VS Code team? We've been discussing almost the same issue since Big Sur's beta introduction, and now it's been months since the official release.
Discussing how the icon should be won't do any good as the team should take the decision of changing the current icon first, then discussing internally, and possibly using our feedback written here.

Folks, how about we stop discussing how the icon should be like and start talking about why no decision has been made by the VS Code team? We've been discussing almost the same issue since Big Sur's beta introduction, and now it's been months since the official release.
Discussing how the icon should be won't do any good as the team should take the decision of changing the current icon first, then discussing internally, and possibly using our feedback written here.

Folks, how about we stop discussing how the icon should be like and start talking about why no decision has been made by the VS Code team? We've been discussing almost the same issue since Big Sur's beta introduction, and now it's been months since the official release.
Discussing how the icon should be won't do any good as the team should take the decision of changing the current icon first, then discussing internally, and possibly using our feedback written here.
And thanks to the ones who gave tips on how to change the app icon locally, but the issue is about reaching out to the team itself to change the icon shape for everyone.

A very good idea. Could we perhaps get an update internally from  @misolori ? He seems to be the guy on the VS team assigned to this.

Folks, how about we stop discussing how the icon should be like and start talking about why no decision has been made by the VS Code team? We've been discussing almost the same issue since Big Sur's beta introduction, and now it's been months since the official release.
Discussing how the icon should be won't do any good as the team should take the decision of changing the current icon first, then discussing internally, and possibly using our feedback written here.
And thanks to the ones who gave tips on how to change the app icon locally, but the issue is about reaching out to the team itself to change the icon shape for everyone.

A very good idea. Could we perhaps get an update internally from  @misolori ? He seems to be the guy on the VS team assigned to this.

Hey everyone, just wanted to chime in here and let you know that we are definitely working on this in the background and read every comment. Since this is specific to the Mac platform it requires more strategic planning across the VS family of products (i.e. VS for Mac). We'll post updates here when we have something ready. Thanks for your patience.

Hey everyone, just wanted to chime in here and let you know that we are definitely working on this in the background and read every comment. Since this is specific to the Mac platform it requires more strategic planning across the VS family of products (i.e. VS for Mac). We'll post updates here when we have something ready. Thanks for your patience.

Thanks @misolori, really glad to hear that. Looking forward to updates from your side.

Thanks @misolori, really glad to hear that. Looking forward to updates from your side.

For those interested, I've done more icons. You can download them here.

@austincondiff Awesome icons, but the link does not seem to include the dark variants? I would love the "Dark Overhang" version!

For those interested, I've done more icons. You can download them here.

@austincondiff Awesome icons, but the link does not seem to include the dark variants? I would love the "Dark Overhang" version!

Check out this, I made some icons 2 weeks ago
https://github.com/mohouyizme/vscode-big-sur-icons

This is almost perfect, the size is just a tad smaller than the official one.

Check out this, I made some icons 2 weeks ago
https://github.com/mohouyizme/vscode-big-sur-icons

This is almost perfect, the size is just a tad smaller than the official one.

I think @austincondiff's overhang idea is genius. It gives it a little more flare, but still conforms to the Big Sur style.

It's a shame this discussion is going on since so many months. It's very easy to update the icons manually from here: https://github.com/mohouyizme/vscode-big-sur-icons/

It's a shame this discussion is going on since so many months. It's very easy to update the icons manually from here: https://github.com/mohouyizme/vscode-big-sur-icons/

Problem is the size of that icons is a tad too small. Regardless, every time the VSCode executable gets updated, the icon reverts to the default one.

You'd think Microsoft could manage to get an updated icon into the app by now...

@niccolomineo I've given up waiting and started using https://replacicon.app
Problem solved 😬

@niccolomineo I've given up waiting and started using https://replacicon.app
Problem solved 😬

Thanks, but no, thanks.

I'm subscribed in an issue regarding the implementation of background highlights in the color themes (which as you know probably every other editor in the planet does support) and the Code team have kept the issue open there for maybe 3-4+ years because they are not convinced that having highlight backgrounds is good for the user's eye. Now we all know that it is possible and okay and there are a ton of themes using it and vscode already has many placed like the Diff editor where using background highlight is even implemented. But I don't know for some reason they still expect the users to try to convince them and they still say we will implement it once we are convinced and therefore the issue keeps being open. And I think this issue has become one of those issues as well. I do not know why things like this happen.
Now, I have bought an M1 mac where unfortunately you only get to use the vscode in the insiders build. So I have to wake up everyday and get an update and then change the insiders build icon to something that is good to the eye and works with the rest of the big sur.  Please at least don't keep us waiting.

nothing yet?

+1

If there were updates, wouldn't they be posted here? Absolutely no need to ask nothing yet? @josephillips85.
Please also be respectful to the subscribers on this thread and use the 👍 reaction on the original post instead of commenting +1.

I’m just ask for a update why are you so mad?
On Tue, Feb 23, 2021 at 12:48 AM Charlie Fish<EMAIL_ADDRESS>wrote:

If there were updates, wouldn't they be posted here? Absolutely no need
to ask nothing yet? @josephillips85 https://github.com/josephillips85.
Please also be respectful to the subscribers on this thread and use the 👍
reaction on the original post instead of commenting +1.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/101014#issuecomment-783926885,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AG3RNORXGDHU2RSX4NUQYN3TAM6R7ANCNFSM4OIFAPWA
.

@josephillips85 The last update from Microsoft was made by @misolori on January 5th, and clearly states: We'll post updates here when we have something ready. Nothing since then. Hence, there are no updates. Asking is pointless.
A lot of people subscribed to this thread are doing so to receive notifications when Microsoft posts updates. Please be considerate to those people and don't spam this thread.

I hope @misolori and the rest of the Microsoft team will consider locking this thread. No additional value is being added to this thread, and the only further discussion of value will be updates from the Microsoft team (and those individuals can bypass locked threads).

Updated icons for macOS Big Sur
👋  Hey everyone, we've finally got good news: starting next week all of our new builds (insiders/explorations) will have the updated icons that follow Apple's app icon guidelines. See below for an example:

This update aligns with other efforts across Microsoft where other apps will start getting a similar update (i.e. Office apps). The changes are minimal so that we don't stray too far from the original branding and the icons are scoped to only be on macOS. For our stable version, this will be rolled out in the 1.55 release. Take a look and let us know what you think!

Not bad, but a bit flat and drab for me. I'd prefer it to pop and look gorgeous like the icon below (the one I'm using) or the other icons posted in this thread.

But it's a good start.

Updated icons for macOS Big Sur
👋 Hey everyone, we've finally got good news: starting next week all of our new builds (insiders/explorations) will have the updated icons that follow Apple's app icon guidelines. See below for an example:

This update aligns with other efforts across Microsoft where other apps will start getting a similar update (i.e. Office apps). The changes are minimal so that we don't stray too far from the original branding and the icons are scoped to only be on macOS. For our stable version, this will be rolled out in the 1.55 release. Take a look and let us know what you think!

Thank you for the effort, to be honest, the white background looks kind of bland. I'd see a dark background fitting more.

Clearing Icon Cache for Insiders icons
The icons are now out on Insiders. You may still see the earlier logo due to operating system caching of the application icon. Here are a few methods for the Mac that you can attempt to use to clear the cache:

Restart your dock via killall Dock in the terminal

Run these scripts in your terminal (which updates the timestamp of the icons):

sudo touch /Applications/Visual\ Studio\ Code\ -\ Insiders.app
sudo touch /Applications/Visual\ Studio\ Code\ -\ Insiders.app/Contents/Info.plist;
sudo touch /Applications/Visual\ Studio\ Code\ -\ Insiders.app/Contents/Resources/Code.icns;
killall Dock Finder

_Note: For Explorations, simply replace Insiders  with Exploration.

Force the IconService cache to be rebuilt using these steps

The white background on a dark themed dock without transparency really doesn't look great IMO. Looking at the Edge icon for example, it looks much better with the transparent background. Please don't fix what's not broken 😃

The white background on a dark themed dock without transparency really doesn't look great IMO. Looking at the Edge icon for example, it looks much better with the transparent background. Please don't fix what's not broken 😃

I'm partially confused by this statement. Are you asking to not have the icon changed at all on macOS, even if it looks out of place with the rest of the app icons?

Are you asking to not have the icon changed at all on macOS, even if it looks out of place with the rest of the app icons?

You’re asking a loaded question - “the icon looks out of place” is stated as fact.
To clear the confusion - to me, the existing icon, meaning the one currently used for non-insider build, is not broken, is not out of place and is just fine.
The one currently in place for the insider builds doesn’t look good on dark themed macOS IMO.
Personally, I’ve moved on following the advice of people in this thread on how to replace app icons. Several community favorites look good to me, I chose one and am happy (this all happened after I wrote the comment above, otherwise wouldn’t have bothered).

Are you asking to not have the icon changed at all on macOS, even if it looks out of place with the rest of the app icons?

You’re asking a loaded question - “the icon looks out of place” is stated as fact.
To clear the confusion - to me, the existing icon, meaning the one currently used for non-insider build, is not broken, is not out of place and is just fine.
The one currently in place for the insider builds doesn’t look good on dark themed macOS IMO.
Personally, I’ve moved on following the advice of people in this thread on how to replace app icons. Several community favorites look good to me, I chose one and am happy (this all happened after I wrote the comment above, otherwise wouldn’t have bothered).

I certainly agree that the white background for the app shape isn't appealing, especially when using dark mode. I also feel that using a white background adds a slight loss of character to the icon and will make it somewhat difficult to differentiate when others are doing the same thing. I've been using one of the community icons for the past few months with a blue background and really enjoy it.

As for the current icon in its pre-Big Sur form, I'd disagree on the basis of the app's shape. The current shape, although well-padded to line up with the heights of the new app icons a bit, is still inconsistent and, IMO, sticks out like a sore thumb. I will acknowledge that there are some who disagree with the app icon guidelines for the new design language and the mindset of "if it's not broken, don't fix it". I'm not one of those people and disagree with the notion, but I'm not going to discount that POV.
I think a good in-between could be to use the white background in light mode, and a dark one in night mode (I know that custom dock tiles are a thing with NSDockTile, though I don't know if Electron exposes this API).

I've been using one of the community icons for the past few months with a blue background and really enjoy it.

I’m using something very similar but green, for insiders build. While I’m not sure what you are disagreeing with here 😉 I’ll agree that white background for light theme and dark for dark could be a good compromise.

The NSDockTile isn't fully exposed but electron does allow app.dock.setIcon(NativeImage) on macOS.

Not sure if it's something todo with my machine, but the Icon shows a render issue in smaller sizes. It's fine in the dock and big preview sizes.

Running the latest build (Commit: 111a6cec70f9562cdd31a5fd8cdea4b3a9b7bd82) of Insiders on macOS Catalina (10.15.7)

@jrmileham Same scenario for me, dock is fine but all smaller sizes look exactly like your screenshot.

@philsinatra @jrmileham #118754

@philsinatra @jrmileham #118754

Thanks for linking the issue. From reading it seems like an electron/chromium issue when using AMD graphics on external displays (which is what I'm doing but I haven't tested different graphics cards variations). I hope Chromium/Electron/Apple (wherever the fault lies) fixes this soon, it looks pretty ugly.

@austincondiff's Overhand icon is superb

I think Microsoft should adopt this whole set...

Raven Yu has some pretty sweet designs over here as well!

@misolori ⤴

Thank you for your feedback
Thanks everyone for the feedback and suggestions. We know that everyone has different perspectives on what the icon should be, and as much as we'd like to go with one of the colored examples from above (@austincondiff), and we did explore that option, our biggest concern is this would cause confusion on what our branding was. This was a big issue in previous versions so in https://github.com/microsoft/vscode/issues/71827#issuecomment-495167013 we attempted to solve it by having the same icon on all platforms. This is the main reasoning behind keeping the macOS icon as simple as possible while still adhering to Apple's app icon guidelines. We also partnered with the rest of the Microsoft products, which will follow with a similar design for Big Sur.
Shipping the icons

We'll be shipping our Stable icons in the next release (which will happen next week) and the Insiders/Exploration builds are already using the icons. I really appreciate the feedback and discussions we've been having, I still get pinged on every comment so know you are being heard. I'll go ahead and close out this issue, 👏 thanks again to everyone who provided input!

Clearing Icon Cache for Stable
Depending on your platform, you may still see the earlier logo due to operating system caching of the application icon. Here are a few methods for the Mac that you can attempt to use to clear the cache:

Restart your dock via killall Dock in the terminal

Run these scripts in your terminal (which updates the timestamp of the icons):

sudo touch /Applications/Visual\ Studio\ Code.app;
sudo touch /Applications/Visual\ Studio\ Code.app/Contents/Info.plist;
sudo touch /Applications/Visual\ Studio\ Code.app/Contents/Resources/Code.icns;
killall Dock Finder

Note: For Insiders and Explorations, simply append \ -\ Insiders or \ -\ Exploration to each version name reference.

Force the IconService cache to be rebuilt using these steps

White background with the logo on top. So creative...

It's probably not meant to be creative, it's meant to be consistent and timeless.

It's probably not meant to be creative, it's meant to be consistent and timeless.

And identical to all the other "consistent and timeless" app icons.

I like it, but I think it has too much white to it. The white background is more visible in the VS Code icon than, say, Safari or Chrome for example.

I think something like the Bear app might be nice where the background is something other than white?
But, whatever happens, big ups for the designers that made it, looks nice already!

Just to bring some more positivity into this thread, I think the new icon set does look very nice!
This still probably has been much more work for the designers than you might assume in the first moment. In the end, if you don't like the Icons it's more than easy to switch them out on macOS.

Another product logo on a white background ... I think we missed a chance here. It looks as boring as all the other Microsoft product icons on a white background on my iPhone. Too bad...

In the end, if you don't like the Icons it's more than easy to switch them out on macOS.

That's not completely true, after each update the icon is reset.

@austincondiff Can I get a copy of your icons that you mention above (https://github.com/microsoft/vscode/issues/101014#issuecomment-804159942)? They're soo much more inspiring than the ones with white backgrounds.
Also as a general note, this issue (https://github.com/microsoft/vscode/issues/101014#issuecomment-802022447) still happens even on intel only graphics. I don't think there has been an electron update between this and last version? So why broken now?

Next step will be to make all icons with same colors, and white background, so you will be not able to distinguish them. Just like with Google new ~garbage~ design icons

In the end, if you don't like the Icons it's more than easy to switch them out on macOS.

That's not completely true, after each update the icon is reset.

I've found that the Pictogram app is a good workaround as it adds a helper that will automatically replace the icon for you if it isn't the one you applied: https://pictogramapp.com

Am i supposed to talk how strange does white background looks now?
Of course, i can patch app bundle with old icon, but... Ehm... Maybe we can at least add choice in preferences?

 Apple design system is sometimes not amazing (like in a this situation), but let's be honest: guys who drew this icons are not lazy at all. Just white background doesn't fit at all wallpapers and dark them at the same time

Not sure if it's something todo with my machine, but the Icon shows a render issue in smaller sizes. It's fine in the dock and big preview sizes.

Running the latest build (Commit: 111a6ce) of Insiders on macOS Catalina (10.15.7)

Not sure if it's something todo with my machine, but the Icon shows a render issue in smaller sizes. It's fine in the dock and big preview sizes.

Running the latest build (Commit: 111a6ce) of Insiders on macOS Catalina (10.15.7)

also in the macOS bigsur 11.2.3, I have same issue.

Generally I think the new icon is fine, but I agree that the white background is too white. Not a single other icon in my dock uses #ffffff; it's all #fbfbfb, #fcfcfc, #fefefe and so on.

@thijsvandien still has question: is it so hard to make custom option in preferences? or, lol, even better, why not to allow user themes change icon?
I've researched this problem, looks like any app can replace its own icon without requiring any permissions (just patching app bundle, symlinks allowed), soooooo why not to? Real deal is to make this option intuitive, cuz apps doesn't update them icons without removing from dock and adding it again, maybe macos api provide some method, which could force reload app data on all system

So my app icon updated today. How do I revert my icon back? Does anyone know where I can get the previous .icns file? It doesn't look like it's in this repo.

Same issue in the Launch Pad.

However when I expand the tile to display its content the VSCode icon appears fine.
It seems to be related to displaying the scaled down version of the icon.

So my app icon updated today. How do I revert my icon back? Does anyone know where I can get the previous .icns file? It doesn't look like it's in this repo.

Check out Pictogram if you're on Big Sur, and this .icns
Code.icns.zip

@misolori
How did you get that Big Sur Teams icon ? Is that a sneak peak ?
Same question for Spotify, is that a custom icon or is this a beta version ?

I hope is just a test this is on a stable release  at least please change
the background color a little bit less white
On Sat, Apr 3, 2021 at 2:12 AM Sébastien LeBlanc @.***>
wrote:

@misolori https://github.com/misolori
How did you get that Big Sur Teams icon ? Is that a sneak peak ?
Same question for Spotify, is that a custom icon or is this a beta version
?
[image: 112679588-920c1200-8e29-11eb-8d65-98a1ede95732]
https://user-images.githubusercontent.com/17392251/113471451-4dd0d100-942a-11eb-8dbb-8d358c6a4969.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/101014#issuecomment-812825567,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AG3RNOUST3NEIF2XFIHKIW3TG25WDANCNFSM4OIFAPWA
.

For those encountering issues with the app icon appearing glitched, please see https://github.com/microsoft/vscode/issues/120305 as we're planning to roll out a patch for it this week.

@misolori what about changing icon in preferences feature? Btwm it could be useful in other OSes, cuz it looks like too many people don't like new logo with white background

For those wanting to configure the app icon, please upvote and subscribe to https://github.com/microsoft/vscode/issues/120604

So my app icon updated today. How do I revert my icon back? Does anyone know where I can get the previous .icns file? It doesn't look like it's in this repo.

Check out Pictogram if you're on Big Sur, and this .icns
Code.icns.zip

Hi @eliyap, can you point me out where I can get the previous icon for the Insiders build, please?

Excellent, I always wanted all the icons on my bar to look the same blank white square with tiny symbol in, it was far too easy to click on the app I wanted without carefully studying my dock 👍  big improvement

I'm glad the team want to make the icon design more inline with Big Sur, however this white background is very stark and almost hurts the eyes to look at against the rest of my dock icons. The white also makes the app look 'non-devy' and more 'everyday consumer' focused.
I feel a grey/dark background would look more pleasing as well as more 'devy' 🙂

I'm on BigSur 11.2.3 (20D91)
VS code:
Version: 1.55.2
Commit: 3c4e3df9e89829dce27b7b5c24508306b151f30d
Date: 2021-04-13T09:36:32.643Z (1 wk ago)
Electron: 11.3.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 20.3.0
But the icon in the dock did not change after the upgrade.

Ok, fixed with this https://github.com/microsoft/vscode/issues/101014#issuecomment-808368475


adds answer post type

Solves issue #39

This is incomplete. The post type was added to the Feeds.jsx file but the UI still needs updated

Closing this to reopen a new one with updated files, etc.


dev-cmd/audit: enforce uses_from_macos only if core tap

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[ ] Have you successfully run brew tests with your changes locally?

This allows formulae in non-core taps to depend on e.g. Homebrew llvm without getting an audit failure.
Supersedes #8066

Fixed test

Thanks again @SeekingMeaning!


boot2docker (and vbox) don't like it when you move dirs

I renamed the .boot2docker dir, so it thinks the vm is both there, and not, and complains horribly.
I'm not sure what we can or should do about corner cases like this, but its worth thinking about

Sorry, this repository is long-since deprecated in favor of Docker Toolbox (whose usage is now also discouraged in favor of Docker for Windows and Docker for Mac).


EOF kept in installed hooks

Hi. I'm working on making a docker with Redmine-3.3.1 and RedmineGitHosting-1.2.1. But when testing to install hooks, hook left untouchedoccurred.
I tried to push commits, I found the error message:
remote: $GITOLITE/local/hooks/common/lib/git_hosting/http_helper.rb:127:in `<top (required)>': uninitialized constant EOF (NameError)
remote:     from hooks/post-receive:9:in `require_relative'
remote:     from hooks/post-receive:9:in `<main>'

And then, I found the literal EOF were kept in installed hooks. That's weired.
$ cat /etc/issue
Welcome to Alpine Linux 3.4
Kernel \r on an \m (\l)

$ ruby --version
ruby 2.3.1p112 (2016-04-26 revision 54768) [x86_64-linux-musl]

$ grep -nFr 'EOF' $GITOLITE/local/hooks/common
./post-receive.d/mail_notifications:36:EOF
./post-receive.d/git_multimail.py:2588:EOF
./post-receive:20:EOF
./lib/git_hosting/http_helper.rb:127:EOF
./lib/git_hosting/custom_hook.rb:100:EOF
./lib/git_hosting/post_receive.rb:74:EOF
./lib/git_hosting/hook_logger.rb:38:EOF
./lib/git_hosting/config.rb:134:EOF

After I deleted those lines manually, Config Test told me hooks installed well.

Well... this is weird.. but I don't know how to reproduce it ^^

And if you delete hooks and reinstall them? what happens?

And if you delete hooks and reinstall them? what happens?


png convert aliasing

With clipping masks there is a bug demonstrated by this Commit,
https://github.com/adobe-photoshop/generator-assets-automation/commit/f422db4ff0f02a2f216372043dd9e61b3354fbb7
@iwehrman said about this commit that  "This ... demonstrates what appears to be a convert bug, originally reported in Watson as 3830464 "

regress after switching to FLITE


Determine how to support analyzer's need to create nodes for which there is no corresponding kernel representation

The Factory API currently provides the methods needed to create the kernel representations of code. The API has been made generic so that analyzer can return its own AST representations. But there are AST nodes to represent pieces of code that kernel only represents implicitly. For example, there is no kernel representation of the syntactic form of a type annotation, only the semantic representation of a DartType.
We need to figure out how we're going to support the creation of these additional AST nodes.

Related, a (currently internal only) doc about transmitting type information from the front end to the analyzer.

The CFE integration work is suspended, so this will not be addressed.


Update to make centered images work

I believe this addresses the remaining issues in https://github.com/zurb/foundation-emails/issues/165

@gakimball assigning to you to make sure this scss approach makes sense to you.  I thought it was easier to add another scss matcher than change inky's behavior for image tags inside a center tag

Looks good to me


WimMessageScanning parameters are incorrect

After working with the WimgApi and trying to use the WimMessageScanning callback message, I discovered that its behavior is incorrect, but it's actually a problem with the API differing from the Microsoft documentation.
Currently, the WimMessageScanning object has DirectoryCount and FileCount properties, in line with the documentation which says that lParam specifies the number of files scanned and wParam is the number of directories scanned. However, that is not true; lParam will contain either the total number of files scanned OR the total number of directories scanned, and wParam is a flag to show which -- if wParam == 0 then lParam contains the total number of files, if wParam == 1 then lParam contains the total number of directories.

You are totally right.  The documentation is wrong but under the debugger I can clearly see that wParam indicates if its a directory or file count.
I'll send a PR to fix this...

@Herohtar please review #23 and let me know what you think.

That will work, but having two properties seems unnecessary since it's just a Boolean -- if one is true you know the other has to be false. I would suggest either having just IsDirectoryCount, since that is typically the less common case, or else give it an enum property something like CountType with values of File and Directory.

The fix is available in 1.2.3: https://www.nuget.org/packages/Microsoft.Wim/1.2.3


GitHub issue templates (bug reports and feature requests link Foundry)

Description
Adds Github templates for bug reports and feature requests.
Context from this issue https://github.com/celo-org/developer-tooling/issues/48
The Foundry repo (foundry-rs/foundry) has great drop-down template for bug reports and feature requests.
This makes it a lot easier for them to review, reproduce, and fix bugs.
Our currently issue template:

issue-template.md

Foundry issue templates:

BUG-FORM.yml
FEATURE-FORM.yml

GitHub Docs:

Syntax for issue forms
Changing the order of templates

Tested

[ ] Not yet tested

Related issues

Fixes #48

Backwards compatibility

[ ] Should be backwards compatible, will double-check

Oops, there are more commits than expected. I probably branched off before pulling from origin.

Asked for necessary Github permissions to preview this template before merging it (if possible).
Otherwise, not sure how this can be tested. It's not terribly important to test this if we don't find an easy way to do this.

If you review and approve the changes, I'm ok to merge this as is without preview or testing. We can always revert this PR if the Github templates are messed up.


feat: add webi as install option in readme

This PR is purely for another install option in the readme. It will be available shortly
I've been getting ollama added to Webi because I use that to install cli tools for as much as I can these days (I like simple portable ways and Webi works well as a flow for our CI/CD jobs which often have to run cross platform as well).
The PR for that at the time of this writing is https://github.com/webinstall/webi-installers/pull/712
Happy to make adjustments to the wording or placement or whatever would be helpful.

Thanks so much for the PR. Since this is a community created package, it would be great to add it to the community integrations section at the bottom of the page. Can you update this to be a link to where ever folks can go for more info?

Sorry for late reply, @technovangelist , I have yet to find a suitable way to filter important things from github's notification deluge. I will add a bookmark for me to check directly regularly.
I have added a link to the bash scripts and cheat sheet for ollama in webi. I wanted to clarify, did you want it simply added to the community section, or also remove it as an install option in the same doc? I'm fine with that, but webi is extremely convenient to lowering install as a barrier to entry. It's about as complicated as the current install shell, and I could add the webi equivalent:
curl -sS https://webi.sh/ollama | sh
I also don't know what integration section it should go under, so I chose package manager, even though it simply uses ollama's own github releases, not a separate storage mechanism. Fetch-helper is more accurate I suppose, though that's not a great section header.
Happy to make further adjustments, too.

Hi there, thanks for the PR! I hadn't heard of Webi yet - cool!
Would it be possible for us to start with a link to the webi installer under "package managers"? (I left a suggestion) It would be a bit too much to add every package manager to the header of README.md in its current formatting


Windows MSVC x64 Debug Mono build fails due to "Could not load file or assembly 'Microsoft.DotNet.PlatformAbstractions, Version=<IP_ADDRESS>"

Godot version
3.3.3-stable
System information
Windows 10
Issue description
I am trying to build Godot within Mono x64 Command Prompt with Visual Studio 2019 installed:
It seems like this might be relevant?
F:\GodotBuild\godot>mono --version
Mono JIT compiler version 6.12.0 (Visual Studio built mono)
Copyright (C) 2002-2014 Novell, Inc, Xamarin Inc and Contributors. www.mono-project.com
        TLS:           __thread
        SIGSEGV:       normal
        Notification:  Thread + polling
        Architecture:  amd64
        Disabled:      none
        Misc:          softdebug
        Interpreter:   yes
        LLVM:          supported, not enabled.
        Suspend:       preemptive
        GC:            sgen (concurrent by default)

F:\GodotBuild\godot>dotnet --version
5.0.400

F:\GodotBuild\godot>scons --version
SCons by Steven Knight et al.:
        SCons: v4.2.0.fcdadeef19fe5fead09fa7544a27502be65312be, Sat, 31 Jul 2021 18:12:46 -0700, by bdbaddog on ProDog2020
        SCons path: ['c:\\users\\aytas\\appdata\\local\\programs\\python\\python37-32\\lib\\site-packages\\SCons']
Copyright (c) 2001 - 2021 The SCons Foundation

F:\GodotBuild\godot>scons p=windows target=debug tools=yes module_mono_enabled=yes copy_mono_root=yes -j8
scons: Reading SConscript files ...
Configuring for Windows: target=debug, bits=default
Found MSVC version 14.2, arch amd64, bits=64
Checking for `thread_local` support... supported
Found Mono root directory: C:\Program Files\Mono\
YASM is necessary for WebM SIMD optimizations.
WebM SIMD optimizations are disabled. Check if your CPU architecture, CPU bits or platform are supported!
Checking for C header file mntent.h... (cached) no
scons: done reading SConscript files.
scons: Building targets ...
[ 96%] build_api_solution(["bin\GodotSharp\Api\Debug\GodotSharp.dll", "bin\GodotSharp\Api\Debug\GodotSharp.pdb", "bin\GodotSharp\Api\Debug\GodotSharp.xml", "bin\GodotSharp\Api\Debug\GodotSharpEditor.dll", "bin\GodotSharp\Api\Debug\GodotSharpEditor.pdb", "bin\GodotSharp\Api\Debug\GodotSharpEditor.xml"], [])
[ 97%] MSBuild path: C:\Program Files\dotnet\dotnet.exe
[ 99%] progress_finish(["progress_finish"], [])
[100%] Microsoft (R) Build Engine version 16.11.0+0538acc04 for .NET
Copyright (C) Microsoft Corporation. All rights reserved.

  Determining projects to restore...
  All projects are up-to-date for restore.
C:\Program Files\dotnet\sdk\3.1.101\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(192,5): error MSB4018: The "GenerateDepsFile" task failed unexpectedly. [F:\GodotBuild\godot\modules\mono\glue\GodotSharp\GodotSharp\GodotSharp.csproj]
C:\Program Files\dotnet\sdk\3.1.101\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(192,5): error MSB4018: System.IO.FileNotFoundException: Could not load file or assembly 'Microsoft.DotNet.PlatformAbstractions, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60'. The system cannot find the file specified. [F:\GodotBuild\godot\modules\mono\glue\GodotSharp\GodotSharp\GodotSharp.csproj]
C:\Program Files\dotnet\sdk\3.1.101\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(192,5): error MSB4018: File name: 'Microsoft.DotNet.PlatformAbstractions, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60' [F:\GodotBuild\godot\modules\mono\glue\GodotSharp\GodotSharp\GodotSharp.csproj]
C:\Program Files\dotnet\sdk\3.1.101\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(192,5): error MSB4018:    at Microsoft.NET.Build.Tasks.FrameworkReferenceResolver.GetDefaultReferenceAssembliesPath() [F:\GodotBuild\godot\modules\mono\glue\GodotSharp\GodotSharp\GodotSharp.csproj]
C:\Program Files\dotnet\sdk\3.1.101\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(192,5): error MSB4018:    at Microsoft.NET.Build.Tasks.GenerateDepsFile.WriteDepsFile(String depsFilePath) [F:\GodotBuild\godot\modules\mono\glue\GodotSharp\GodotSharp\GodotSharp.csproj]
C:\Program Files\dotnet\sdk\3.1.101\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(192,5): error MSB4018:    at Microsoft.NET.Build.Tasks.GenerateDepsFile.ExecuteCore() [F:\GodotBuild\godot\modules\mono\glue\GodotSharp\GodotSharp\GodotSharp.csproj]
C:\Program Files\dotnet\sdk\3.1.101\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(192,5): error MSB4018:    at Microsoft.NET.Build.Tasks.TaskBase.Execute() [F:\GodotBuild\godot\modules\mono\glue\GodotSharp\GodotSharp\GodotSharp.csproj]
C:\Program Files\dotnet\sdk\3.1.101\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(192,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() [F:\GodotBuild\godot\modules\mono\glue\GodotSharp\GodotSharp\GodotSharp.csproj]
C:\Program Files\dotnet\sdk\3.1.101\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(192,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask) [F:\GodotBuild\godot\modules\mono\glue\GodotSharp\GodotSharp\GodotSharp.csproj]
scons: *** [bin\GodotSharp\Api\Debug\GodotSharp.dll] RuntimeError : 'msbuild' exited with error code: 1
Traceback (most recent call last):
  File "F:\GodotBuild\godot\modules\mono\build_scripts\solution_builder.py", line 106, in run_command
    subprocess.check_call(args, env=env_override)
  File "c:\users\aytas\appdata\local\programs\python\python37-32\lib\subprocess.py", line 328, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['C:\\Program Files\\dotnet\\dotnet.exe', 'msbuild', 'F:\\GodotBuild\\godot\\modules\\mono\\glue/GodotSharp/GodotSharp.sln', '/restore', '/t:Build', '/p:Configuration=Debug', '/p:NoWarn=1591']' returned non-zero exit status 1.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "c:\users\aytas\appdata\local\programs\python\python37-32\lib\site-packages\SCons\Action.py", line 1279, in execute
    result = self.execfunction(target=target, source=rsources, env=env)
  File "F:\GodotBuild\godot\modules\mono\build_scripts\api_solution_build.py", line 21, in build_api_solution
    build_solution(env, solution_path, build_config, extra_msbuild_args=extra_msbuild_args)
  File "F:\GodotBuild\godot\modules\mono\build_scripts\solution_builder.py", line 148, in build_solution
    run_command(msbuild_path, msbuild_args, env_override=msbuild_env, name="msbuild")
  File "F:\GodotBuild\godot\modules\mono\build_scripts\solution_builder.py", line 108, in run_command
    raise RuntimeError("'%s' exited with error code: %s" % (name, e.returncode))
RuntimeError: 'msbuild' exited with error code: 1
scons: building terminated because of errors.

  We import a props file with auto-generated includes. This works well with Rider.
  However, Visual Studio and MonoDevelop won't list them in the solution explorer.
  We can't use wildcards as there may be undesired old files still hanging around.
  Fortunately code completion, go to definition and such still work.
  -->
  <Import Project="Generated\GeneratedIncludes.props" />
</Project>

modules\mono\glue\GodotSharp\GodotSharpEditor\GodotSharpEditor.csproj
<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <ProjectGuid>{8FBEC238-D944-4074-8548-B3B524305905}</ProjectGuid>
    <OutputPath>bin/$(Configuration)</OutputPath>
    <AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath>
    <RootNamespace>Godot</RootNamespace>
    <TargetFramework>netstandard2.0</TargetFramework>
    <DocumentationFile>$(OutputPath)/$(AssemblyName).xml</DocumentationFile>
    <EnableDefaultItems>false</EnableDefaultItems>
  </PropertyGroup>
  <PropertyGroup>
    <DefineConstants>$(DefineConstants);GODOT</DefineConstants>
  </PropertyGroup>
  <ItemGroup>
    <ProjectReference Include="..\GodotSharp\GodotSharp.csproj">
      <Private>false</Private>
    </ProjectReference>
  </ItemGroup>
  <!--
  We import a props file with auto-generated includes. This works well with Rider.
  However, Visual Studio and MonoDevelop won't list them in the solution explorer.
  We can't use wildcards as there may be undesired old files still hanging around.
  Fortunately code completion, go to definition and such still work.
  -->
  <Import Project="Generated\GeneratedIncludes.props" />
</Project>

Minimal reproduction project
No response

I see that the official build of v3.3.3-stable is currently on what seems to be Mono 4.0 or Mono 4.5? Is this correct?

@CinchBlue It's a bit confusing, but the folder is called 4.5 because of the .NET Framework 4.5 API level, not the Mono version. The Mono version that Godot uses is actually the latest 6.12.0.x. And Godot supports features from C# 7 (and some C# 8 features), which is similar to what's available in .NET Framework 4.7.

I see. Well, based on this error:
C:\Program Files\dotnet\sdk\3.1.101\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(192,5): error MSB4018: System.IO.FileNotFoundException: Could not load file or assembly 'Microsoft.DotNet.PlatformAbstractions, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60'. The system cannot find the file specified. [F:\GodotBuild\godot\modules\mono\glue\GodotSharp\GodotSharp\GodotSharp.csproj]
it seems like there is something to track down with SDK targets and project building breaking with regards to Mono. We'll have to see if we can track someone down to take a look at this.


Is a new URL structure worth the hassle?

As discussed in Slack, the benefits of switching URL structure to something like alistapart.com/title are  branding and SEO.  But it would take a lot to implement this change.  Is it worth it?

@murtaugh and @michellekondou discussed and determined that changing the url scheme in EE is too complex for the little value we'd get from the change.  If we change CMS in the future, it would be a good idea to change the URL scheme.


Wrong duration of AVC elementary stream after recent changes

MediaInfo v24.01 reports different Duration and Frame Rate of the AVC (H.264) elementary stream then v22.09. I only noticed it when I use the source which was sliced from the origin video (but not sure if it needed). Here is how I prepared the source:
ffmpeg -y -ss 00:00:05.0 -i big_buck_bunny.mov -t 00:00:10.0  -c:v libx264 -an -vf "fps=30,scale=640:480" -f h264  bunny.h264
So it cut from 5 second to 15 second of source, changes fps to 30 + downsizes image (just for reducing size of the file) and outputs as H.264 elementary stream.
I would expect the duration of such stream to be close to 10 seconds + fps reported as 30.
I noticed different behaviour of MediaInfoLib after commit https://github.com/MediaArea/MediaInfoLib/commit/52715481f9645b629ff0c52440d60548232d5bd0
Before that commit I got Duration 10 s 0 ms and FPS 30.000 FPS
General
Complete name                            : bunny.h264
Format                                   : AVC
Format/Info                              : Advanced Video Codec
File size                                : 1.16 MiB
Duration                                 : 10 s 0 ms
Overall bit rate                         : 970 kb/s
Writing library                          : x264 core 164 r3108 31e19f9
Encoding settings                        : cabac=1 / ref=3 / deblock=1:0:0 / analyse=0x3:0x113 / me=hex / subme=7 / psy=1 / psy_rd=1.00:0.00 / mixed_ref=1 / me_range=16 / chroma_me=1 / trellis=1 / 8x8dct=1 / cqm=0 / deadzone=21,11 / fast_pskip=1 / chroma_qp_offset=-2 / threads=15 / lookahead_threads=2 / sliced_threads=0 / nr=0 / decimate=1 / interlaced=0 / bluray_compat=0 / constrained_intra=0 / bframes=3 / b_pyramid=2 / b_adapt=1 / b_bias=0 / direct=1 / weightb=1 / open_gop=0 / weightp=2 / keyint=250 / keyint_min=25 / scenecut=40 / intra_refresh=0 / rc_lookahead=40 / rc=crf / mbtree=1 / crf=23.0 / qcomp=0.60 / qpmin=0 / qpmax=69 / qpstep=4 / ip_ratio=1.40 / aq=1:1.00

Video
Format                                   : AVC
Format/Info                              : Advanced Video Codec
Format profile                           : High@L3
Format settings                          : CABAC / 4 Ref Frames
Format settings, CABAC                   : Yes
Format settings, Reference frames        : 4 frames
Duration                                 : 10 s 0 ms
Bit rate                                 : 970 kb/s
Width                                    : 640 pixels
Height                                   : 480 pixels
Display aspect ratio                     : 4:3
Frame rate mode                          : Variable
Frame rate                               : 30.000 FPS

But after this commit I get Duration 6 s 933 ms and FPS 43.271 FPS
General
Complete name                            : bunny.h264
Format                                   : AVC
Format/Info                              : Advanced Video Codec
File size                                : 1.16 MiB
Duration                                 : 6 s 933 ms
Overall bit rate                         : 1 399 kb/s
Frame rate                               : 43.271 FPS
Writing library                          : x264 core 164 r3108 31e19f9
Encoding settings                        : cabac=1 / ref=3 / deblock=1:0:0 / analyse=0x3:0x113 / me=hex / subme=7 / psy=1 / psy_rd=1.00:0.00 / mixed_ref=1 / me_range=16 / chroma_me=1 / trellis=1 / 8x8dct=1 / cqm=0 / deadzone=21,11 / fast_pskip=1 / chroma_qp_offset=-2 / threads=15 / lookahead_threads=2 / sliced_threads=0 / nr=0 / decimate=1 / interlaced=0 / bluray_compat=0 / constrained_intra=0 / bframes=3 / b_pyramid=2 / b_adapt=1 / b_bias=0 / direct=1 / weightb=1 / open_gop=0 / weightp=2 / keyint=250 / keyint_min=25 / scenecut=40 / intra_refresh=0 / rc_lookahead=40 / rc=crf / mbtree=1 / crf=23.0 / qcomp=0.60 / qpmin=0 / qpmax=69 / qpstep=4 / ip_ratio=1.40 / aq=1:1.00

Video
Format                                   : AVC
Format/Info                              : Advanced Video Codec
Format profile                           : High@L3
Format settings                          : CABAC / 4 Ref Frames
Format settings, CABAC                   : Yes
Format settings, Reference frames        : 4 frames
Duration                                 : 6 s 933 ms
Bit rate                                 : 1 399 kb/s
Width                                    : 640 pixels
Height                                   : 480 pixels
Display aspect ratio                     : 4:3
Frame rate mode                          : Variable
Frame rate                               : 43.271 FPS

I also noticed that the difference in Duration is highly related with the fps which I use to encode the stream.

Here is an example file  - named .mp4 to be able to attach to issue ;-)
https://github.com/MediaArea/MediaInfoLib/assets/72302178/ed6597a7-cae4-42e1-958c-701e2037cee3
generated with
ffmpeg -y -ss 00:00:05.0 -i big_buck_bunny.mov -t 00:00:10.0  -c:v libx264 -an -vf "fps=30,scale=640:480" -f h264  bunny.h264

It can be downloaded, right click, save video.

Before that commit I got Duration 10 s 0 ms and FPS 30.000 FPS

Well, ffplay cannot recognise any fps in this video and just says 25 fps.

Well, ffplay cannot recognise any fps in this video and just says 25 fps.

Quick test with FFmpeg 4.4.2 and 30 fps are detected:
Stream #0:0: Video: h264 (High), yuv420p(progressive), 320x240, 30 fps, 30 tbr, 1200k tbn, 60 tbc
Issue is in MI, no discussion about that.

Update ffmpeg?


Implement sorting in file_list

This resolves #1143 by implementing sort in file_list based on name/date/price, in ascending or descending order.
I do have a standing question in that issue regarding the addition of something like a created_at field in the files table. For now, the code in this PR depends on the insertion order of records into the database, which is related to the date that the record was created, but does not keep a record of it.

Thanks for the review, I will make the suggested changes and work on unit tests for the parsing of sort options and sorting functionality with some mock data.

I added a pretty thorough unit test for file_list sorting, using the Faker library for generating some somewhat-realistic looking fake file objects, and added both Faker and mock (which I was missing) to requirements_testing.txt.
The following should quickly reproduce the test results:
source lbry-venv/bin/activate
pip install -U -r requirements_testing.txt
trial lbrynet/tests/unit/lbrynet_daemon/test_Daemon.py

@kafene, I apologize for the long period without feedback. I've actually reviewed this more closely since your last commits and we've even discussed it internally.
The main issue blocking this pull request is that there is too much hard coded logic in this implementation. For example, imagine needing to add a new field in the future... this would require changes in several different places and adding new if statements to handle the new field.
Could you refactor this implementation so that the field names are inferred from the data model (as best as you can, with possible dictionary mapping between user friendly field names and the actual object attributes) with the goal being that adding a new field should be a simple and obvious addition to the mapping instead of making changes in various places (adding new constants, modifying if statements, etc).

I agree. It should simply be any field that is visible when doing a normal file_list command.
One issue with the generic approach is that I had the sort applied outside of the transformation to JSON that is ultimately displayed to the end user. It looks like the only place that sorting this way is needed is when JSON is being returned, so it would make sense to only support sorting when return_json=True and to sort the list of objects returned by _get_lbry_file_dict, so the sort would actually be applied to the data seen in the output.
This is definitely doable. I would also like to support some notation like --sort=metadata.title.

Okay, next round.
Sorting can now be done on any property of an object found in the results of file_list. This includes nested fields like metadata.author or metadata.title.
I added a test case for sorting by nested fields, currently only applicable to metadata.
I noticed that sorting by a field that does not exist produced a very vague error message with just the name of the key that was not found, so I added a more meaningful error message.
I also fixed up the unit tests to not use @inlineCallbacks and instead use other means of testing deferred objects as suggested in the Twisted docs.
Things to consider:
Sorting by date is still not explicitly supported. The real fix for this is to add a date field to the output, which also means storing it somewhere, most likely in the file table of the database. That's out of scope for this PR, I think.
If in the future any lists/arrays are added to the results, sorting on numerically-indexed keys of these would not be supported. A simple solution would be to add something like key = int(key) if isinstance(value, (list, tuple)) in the key_getter callback function, I just refrained from doing so for now because it's a case that currently doesn't occur (premature optimization?). Let me know if you think it should be accounted for regardless and I can add it.

@eukreign @tzarebczan @kafene
https://github.com/lbryio/lbry/issues/1227
https://github.com/lbryio/lbry/issues/1228


Cognitive Services: Add missing descriptions for errors

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[x] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version,  please select SDKs of specific language and CLIs that require refresh after swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[ ] No, no need to refresh for updates in this PR

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of “no breaking changes
[x] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[ ] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
Adding a new service

[ ] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable version with Breaking Change Validation errors
[ ] Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

Breaking change checking tool says im adding new response codes, but im actually adding default fallbacks.
I believe AutoRest by default consider un-advertised response codes as error, adding default fallbacks will not break anyone. Thus its not a breaking change?

@yangyuan I agree. However, pls follow the breaking change process to get approval, it shouldn't take long.

Thanks @leni-msft, I have created the ticket: https://msazure.visualstudio.com/One/_workitems/edit/8887858

/azp run

/azp run

Hi @leni-msft, this PR was not processed because of breaking change policy, but since now we have a breaking change exceptions for Swagger KPIs, maybe we can continue this PR.
It went through breaking change process.

/azp run

@leni-msft looks like everything else is passing except for ruby, and errors seems to be issue of autorest itself.
Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag --unhandled-rejections=strict (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 52)


[GE] Text Block Can't be unselected

Also additional issues with positioning and scrolling, may be related.

Update: Scrolling is related to be constantly selected. Will adjust to fix this separate issue.


Secure memory allocator and restricted runtime

"Security in software sucks, but let's suck less"

The aim of this PR is to provide a unobtrusive abstraction to guarded and locked memory allocations and syscall filtering (seccomp on Linux).
let st: Secure<T> = Secure::new(...);

let b = zone::soft(|| {
    // We're now in an isolated process running in a restricted zone.
    //
    // No syscalls will return except:
    // - exit and write(1) (for propagating the result to the parent)
    // - anonymous mmap (and others to support the secure memory allocator)
    // - other uncontroversial auxillary syscalls (like clock_gettime and such)

    st.unlock(|t| {
         let a = t.decrypt();
         sensitive_operation(a)
    })
});

For the uninitiated: a syscall filtering makes it possible for a process to give up its rights to access operating system resources. As an easy example: why should a crypto algorithm ever need to access the file system (remember in Unix everything is a file)? The wrapper I implement here actually forks away from the main process (think the wallet application/stronghold daemon, that may contain UI and/or networking code and such) to perform the sensitive operations. This also adds the "normal" process isolation benefits with regards to memory.

I, robot, ran rustfmt Perfect!!


acls

i chage acls in event.json file to:
{
"accessType": "",
"principalType": "ROLE",
"principalId": "$everyone",
"permission": "DENY"
},
{
"accessType": "",
"principalType": "ROLE",
"principalId": "admin",
"permission": "ALLOW"
},
{
"accessType": "READ",
"principalType": "ROLE",
"principalId": "$authenticated",
"permission": "ALLOW"
}
after login http://localhost:3333/#/login with username and password
http://localhost:3333/#/app/events -> 0k.
http://localhost:3333/api/events ->
{"error":{"name":"Error","status":401,"message":"Authorization Required","statusCode":401,"code":"AUTHORIZATION_REQUIRED","stack":"Error: Authorization Required\n    at C:\Users\VDP\Desktop\admin\node_modules\loopback\lib\application.js:344:21\n    at C:\Users\VDP\Desktop\admin\node_modules\loopback\lib\model.js:295:5\n    at C:\Users\VDP\Desktop\admin\node_modules\loopback\common\models\acl.js:437:23\n    at C:\Users\VDP\Desktop\admin\node_modules\async\lib\async.js:254:17\n    at done (C:\Users\VDP\Desktop\admin\node_modules\async\lib\async.js:135:19)\n    at C:\Users\VDP\Desktop\admin\node_modules\async\lib\async.js:32:16\n    at C:\Users\VDP\Desktop\admin\node_modules\async\lib\async.js:251:21\n    at C:\Users\VDP\Desktop\admin\node_modules\async\lib\async.js:575:34\n    at C:\Users\VDP\Desktop\admin\node_modules\loopback\common\models\acl.js:420:17\n    at C:\Users\VDP\Desktop\admin\node_modules\loopback\common\models\role.js:207:21"}}

+1

I'm closing it now because ACL's are not yet implemented in this project.
For general questions about LoopBack I recommend you to go to one of these gitter rooms and ask there:
https://gitter.im/strongloop/loopback
https://gitter.im/loopbackers/loopbackers.github.io
If it is a bug that is only in this project please reopen this issue.


Add assignment textobjects to CSS

These are the property/value textobjects for CSS.
Selecting property (key):

Selecting value:

However there's an edge case which I don't know how to properly handle. It has to do with some properties having multiple values. With the current implementation, only one of the values is selected (the closest one).
background-image:

transition:

As a workaround we can make @assignment.rhs and @assignment.inner (which seem to be synonyms in most language queries) to differ slightly and have @assignment.rhs capture all the values and @assignment.inner capture one value only.
Having the following keymaps works very intuitively for this setup:
['ik'] =<EMAIL_ADDRESS>-- select the key
['ak'] =<EMAIL_ADDRESS>-- select the whole assignment
['iv'] =<EMAIL_ADDRESS>-- select the value (a single value, if multiple are available)
['av'] =<EMAIL_ADDRESS>-- select the value (the whole value, if multiple are available)

This query is very close, but I struggle to exclude the : and ; characters from the range via #offset!.
(declaration
  (property_name) @assignment.lhs
  (":") @_start (#offset! @_start 0 1 0 1)
  (_) @assignment.inner
  (";") @_end (#offset! @_end 0 -1 0 -1)
  (#make-range! "assignment.rhs" @_start @_end)
) @assignment.outer

Note: assignment.inner selects both rhs and lhs depending on the cursor position in all other languages, so it should be consistent with CSS

Ah, I see. This is also fine.
The query in the PR is consistent with the other @assignment queries so it should be good to go. Let me know if you need anything more from me.

In order for @assignment.inner to work properly, we need one more query like this:
(declaration
  (property_name) @assignment.inner
)

In my opinion the entire value should be selected, because in other languages like Python which support multiple assignment values, we don't separate it.

In order for @assignment.inner to work properly, we need one more query like this:
(declaration
  (property_name) @assignment.inner
)

I'm a bit confused about this. All other instances of assignment in the queries I could find had assignment.inner set to the value of the assignment and not the name. The only exception being value-less assignments, e.g. var name.
https://github.com/nvim-treesitter/nvim-treesitter-textobjects/blob/e7234c57d7a1dfc98d56ef84b1e38dbb79a875bd/queries/go/textobjects.scm#L101-L119
Maybe I'm missing something?

In my opinion the entire value should be selected, because in other languages like Python which support multiple assignment values, we don't separate it.

I agree. I've updated the query to select the whole value and behave exactly as other assignment captures that are currently implemented.
The query is a bit complicated because the nodes in the treesitter tree don't provide left/right or name/value field names like in Go for example.
Perhaps we can add name/value field names in the CSS grammar upstream and later simplify this query?

It's because, you can't use the same capture name twice in one query. Thus in all other languages they have a separate query that captures lhs part too.
In the example of Go,
 (const_spec
   name: (_) @assignment.lhs
   value: (_) @assignment.rhs @assignment.inner) @assignment.outer
 (const_spec
   name: (_) @assignment.inner
   type: (_))

This is exactly selecting either lhs or rhs. We don't need repeating @assignment.outer though, so I removed the second one here for illustration.

Oh, I see. I think I understand now.
I've rebased against the current master and updated the queries to reflect the proposed changes.

This is perfect, except you don't need to repeat the @assignment.outer. It is redundant as both queries will capture the same range.
Just make the second query like this:
(declaration
  (property_name) @assignment.inner
)

@kiyoon I see. I was trying to match the style of the existing queries.
I've updated the PR with your feedback. It should be good to go.

Great, thank you!


Fix https://github.com/ciena-frost/ember-frost-core/issues/455

This project uses semver, please check the scope of this pr:

[ ] #none# - documentation fixes and/or test additions
[x] #patch# - backwards-compatible bug fix
[ ] #minor# - adding functionality in a backwards-compatible manner
[ ] #major# - incompatible API change

CHANGELOG

Fix select search by escaping regex special characters. Fixes https://github.com/ciena-frost/ember-frost-core/issues/455

Changes Unknown when pulling 471f51b9472492fa86ebb4bca3208b4cb8e06aed on EWhite613:no-regex into ** on ciena-frost:master**.

Changes Unknown when pulling 39272a5f2071a96a7bf97a94a04b3795f5d83b0b on EWhite613:no-regex into ** on ciena-frost:master**.

Approved


Better transition including rotation

Currently only the position is interpolated, we don't do anything with the rotation.
Amelioration suggestion for rotation:
Move up y first then move xz like https://au-floor.vercel.app (cursor doesn't seem to work on Firefox, use Chrome)
Related:

#55

You can sponsor $30 to vincentfretin fully or partially to work on this feature. Find other work you can sponsor at https://github.com/c-frame/sponsorship

@3DStreet sponsored me to work on this issue. Thank you!


Unclear mapping of Azure AD authentication methods to NIST authenticator types

I'm having some trouble understanding the following statement:

Password AND
Single-factor one-time-password hardware (from OTP manufacturers) OR
Hybrid Azure AD Joined w/ software TPM OR
Azure AD joined w/ software TPM OR
Compliant managed device

Does this mean password AND one of the remaining four options? In this case, I think it would be helpful to add some braces around, similar to how it was done above:

Password AND
(Hybrid Azure AD Joined w/ hardware TPM OR
Azure AD joined w/ hardware TPM)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 36a92a90-4b26-8f6f-5c90-77dec7b55c95
Version Independent ID: 5d2b6ef8-126a-a7cd-3fd5-b91fcb81065b
Content: Achieving NIST AAL3 with the Azure Active Directory
Content Source: articles/active-directory/standards/nist-authenticator-assurance-level-3.md
Service: active-directory
Sub-service: fundamentals
GitHub Login: @BarbaraSelden
Microsoft Alias: baselden

@muenchdo
Thanks for your feedback! We will investigate and update as appropriate.

@muenchdo
I've created a PR to update the documentation and will now close out this issue. Please allow some time for the changes to reflect and if you don't see the document update, please let me know.
I will be more than happy to re-open this issue and look into what happened.
Thank you for your time and patience!


Adding GPUs to jobs without remote

Jobs which do not rely on ray.remote, such as lm-harness, run without GPUs by default.
If we want to add GPUs to our jobs, we need to manually add gpus to ray.submit (see here), for instance when it is called in the example notebooks.
This is ok, I just wanted to raise this to make sure we describe this behavior in the documentation. The reason is that lm-harness jobs break if e.g. we run an evaluation on a quantized model without using a GPU.

Just got this issue as well replicating a run from scratch, will open a ticket for it

Resolved with the above PR ^


unknow error

Hi ! Thank you for this extension, I'm configuring a flarum instance and ldap is the only way my users will log in.
I tried to configure the extension, but all my attempts are failing with no error. Only this in the firefox console :
TypeError: this.ldaplogin(...) is undefined LDAPLogInModal.js:165:9
    onsubmit LDAPLogInModal.js:165
    onsubmit self-hosted:1019
    L/t[e]< mithril.js:1286

My access.log :
POST /auth/ldap HTTP/1.1" 500
php-ldap is installed, I have no other clue...

Hi, thanks for your feedback!
Do you have any error in your PHP logs, server side?

In debug mode, this appears :

In my php-fpm.log, nothing.
In my nginx/error.log, I have all this but I had already those messages before installing your extension :
2019/11/27 13:30:20 [error] 17741#17741: *103 open() "/var/www/flarum/public/service-worker-29f380effd40cdaa98cfa88ea74b0c66ba6ca6c901f666253c7592d49fa5e7d4.js" failed (2: No such file or directory), client: <IP_ADDRESS>, server: talk.felinn.org, request: "GET /service-worker-29f380effd40cdaa98cfa88ea74b0c66ba6ca6c901f666253c7592d49fa5e7d4.js HTTP/1.1", host: "talk.felinn.org"
2019/11/27 13:30:20 [error] 17741#17741: *104 open() "/var/www/flarum/public/javascripts/workbox/workbox-sw.js" failed (2: No such file or directory), client: <IP_ADDRESS>, server: talk.felinn.org, request: "GET /javascripts/workbox/workbox-sw.js HTTP/1.1", host: "talk.felinn.org"
2019/11/27 13:30:20 [error] 17741#17741: *105 open() "/var/www/flarum/public/javascripts/workbox/workbox-routing.prod.js" failed (2: No such file or directory), client: <IP_ADDRESS>, server: talk.felinn.org, request: "GET /javascripts/workbox/workbox-routing.prod.js HTTP/1.1", host: "talk.felinn.org"
2019/11/27 13:30:20 [error] 17741#17741: *106 open() "/var/www/flarum/public/javascripts/workbox/workbox-core.prod.js" failed (2: No such file or directory), client: <IP_ADDRESS>, server: talk.felinn.org, request: "GET /javascripts/workbox/workbox-core.prod.js HTTP/1.1", host: "talk.felinn.org"
2019/11/27 13:30:20 [error] 17741#17741: *107 open() "/var/www/flarum/public/javascripts/workbox/workbox-strategies.prod.js" failed (2: No such file or directory), client: <IP_ADDRESS>, server: talk.felinn.org, request: "GET /javascripts/workbox/workbox-strategies.prod.js HTTP/1.1", host: "talk.felinn.org"
2019/11/27 13:30:20 [error] 17741#17741: *108 open() "/var/www/flarum/public/javascripts/workbox/workbox-expiration.prod.js" failed (2: No such file or directory), client: <IP_ADDRESS>, server: talk.felinn.org, request: "GET /javascripts/workbox/workbox-expiration.prod.js HTTP/1.1", host: "talk.felinn.org"

OK, I think the extension is not listening to all the errors the LDAP binding can throw. You hence get a generic error.

Can you try to see what triggers this error? In debug mode, you should be able to "rewind" the stack of commands to led to it.
Can you check all your settings? (try to do an ldap search via command line for example)
Try also not to use the admin authentication, I am doubting it actually works.

Thanks again !
I tried without admin auth, without change.

Can you try to see what triggers this error? In debug mode, you should be able to "rewind" the stack of commands that led to it.

I can't identify what exactly triggers the error. Here are the 3 last commands before the error :

Can you check all your settings? (try to do an ldap search via command line for example)

What exactly should I be searching for ? Files ? Paths ?
I don't know if it can helps, but here is our gitlab ldap configuration (working fine), I tried to adapts it for flarum :
gitlab_rails['ldap_servers'] = YAML.load <<-'EOS'
  main: # 'main' is the GitLab 'provider ID' of this LDAP server
    label: 'FELINN'
    host: '<IP_ADDRESS>'
    port: 389
    uid: 'uid'
    bind_dn: 'cn=fd-admin,dc=felinn,dc=org'
    password: '****************************'
    encryption: 'plain' # "start_tls" or "simple_tls" or "plain"
    verify_certificates: true
    active_directory: true
    allow_username_or_email_login: true
    lowercase_usernames: false
    block_auto_created_users: false
    base: 'dc=felinn,dc=org'
    user_filter: '(objectclass=person)'
    ## EE only
    group_base: ''
    admin_group: ''
    sync_ssh_keys: false

Flarum config :

method_name : FELINN
hosts : <IP_ADDRESS>
base_dn : dc=felinn,dc=org
port : 389
account_prefix : objectclass=person
account_suffix :
follow_referrals (oui/non) : no
use_ssl (oui/non) :  no
use_tls (oui/non) :  no
use_admin (oui/non) : no
admin_dn (oui/non) :  no
admin_password (oui/non) : no
onlyUse (oui/non) : no

Note that I'm not an ldap expert...

Try emptying the account_prefix, it is not meant as a filter.
Basically if your user id is ornanovitch, then it would end up looking for objectclass=personornanovitch.
I will investigate if it's possible to implement this filter in the extension, but it would work without it.

OK, thanks. I emptied account_prefix, now there is only
method_name : FELINN
hosts : <IP_ADDRESS>
base_dn : dc=felinn,dc=org
port : 389

So in theory I guess it should give access and create an user in DB for all members referenced into the base_dn ? It would be a first victory, but for now the same error remains...

No, what it does is using the username and password given in Flarum's login modal to connect into the LDAP server as this user. If the connection is successful, then it creates the same user in Flarum's database.
I will try to investigate tonight, I am at a loss about the next steps.
Note to self: write an actual README. :)

Hi, to help me debug the issue, can you delete these two lines?
https://github.com/tituspijean/flarum-ext-auth-ldap/blob/d88361a1e3b26139097d881a86a4d15183c817db/src/Controllers/LDAPAuthController.php#L77-L78
The file should be in ${your_flarum_path}/vendor/tituspijean/flarum-ext-auth-ldap/src/Controllers/LDAPAuthController.php. Then post the debug screen.

The error is more verbose now :
No LDAP query results for filter: [(objectclass=*)] in: [uid=ornano,dc=felinn,dc=org]

Weird. I really do not know what is the matter.
Can you try binding with the admin account again?

Implementing this extension in my environment let me to the conclusion that the search is not being done recursively within the directories.
I think that changing the base_dn in your case to cn=fd-admin,dc=felinn,dc=org will work.

Can you try binding with the admin account again?

Same problem...

I think that changing the base_dn in your case to cn=fd-admin,dc=felinn,dc=org will work.

It does not, but thanks for helping me !
Should I try your solution @nadi106 ? How would I implement this ? In LDAPAuthController.php, replacing lines 53-54 ? :
      $provider->auth()->attempt($uid_dn, $password, $bindAsUser = true);
      $user = $provider->search()->findByDnOrFail($uid_dn);

OK, I tried to implement your modifications, it brings me to this error :
could not bind to ldap server

@Ornanovitch what OS are you on?

Debian 9 !

Also, it matters on which line this error occurred, can you send more info?

This one (the last one) :
throw new Exception("Could not bind to LDAP server")

Debian 9 !
I was on Ubuntu when integrating this and I found using ldapsearch package to test some queries helpful. You should try that.

OK, I'll do that, thanks !

Solved ! :fireworks:
So, we have investigated a lot with my mates, here is what's happening :
adLDAP wants to have user's dn referenced by uid, like this :
ldapsearch -H ldap:// -x  -b "uid=<uid>,ou=people,dc=felinn,dc=org"

But in our LDAP configuration, the user's dn was referenced by cn (last name + surname). We didn't want this but it seemed to be a default configuration that we didn't see.
So we had to change the default configuration in fusion directory (configuration, people and group storage), but as it's not a backdated action, we also had to change manually existing users with a script as explained here :
dn: cn=<actual user's cn variabl>,ou=<if you have one by default>,dc=foo,dc=bar
changetype: modrdn
newrdn: uid=<username>
deleteoldrdn: 0
newsuperior: ou=<no change>,dc=foo,dc=bar

Then we pass the script throught command line :
ldapmodify -x -D "cn=admin,dc=foo,dc=bar" -w <password> -H ldap:// -f <script>.ldif

Now every LDAP user can sign up in our flarum ! :+1:
It's interesting because it suggests that we would have achieve this if there were some other options in your extension, like filters. But it allowed us to understand that we had a bad practice with this user's dn option (because we had to register name and surname of all our users, witch is not our desire). At least, I think it's important for admins to know that they should have user's dn mapped with uid in their LDAP configuration to use this extension.
Thanks a lot for all your help, and thanks for this extension !

I am glad you solved the issue, and I am sorry you had to change your LDAP setup to accommodate this extension's flaws. If that's already with you, I am keeping this issue open to try to implement versatile DN configurations.
I will investigate the matter, but on first thoughts providing a uid is mandatory for Flarum. It is tricky to identify users only by their cn since it can change! (I am thinking about marriage, legal name change, etc.)


CDPD-18761  change OOTB value of mapreduce input list status threads count

CDPD-18761
In a customer env, split computation took longer time as FileInputFormat scanned files in single threaded mode. It has been recommended to set value of mapreduce.input.fileinputformat.list-status.num-threads to
100 OOTB. Hence setting following in DE templates for 7.2.0, 7.2.1, 7.2.2, 7.2.6, 7.2.7
mapreduce.input.fileinputformat.list-status.num-threads=100
Testing done :
Have created a DE cluster using a modified 7.2.6 template that includes above mentioned config changes. Cluster creation was successful on AWS using m5d.2xl instance types.

@rbalamohan Pls review and approve.


Double counting on controller restart

The controller keeps track of how much energy per pod has already been accounted for in main memory. This table is lost on restart of the controller meaning total energy consumption will be incorrectly doubled on restart when the label group is not setup to reset counts on restart.

I am seeing this also. Even worse, occasionally values go down after restart.

Excellent!


Error when Manabox csv contains Binder columns

Some exports from Manabox evidently contain columns for 'Binder Name' and 'Binder Type' which throws off the indexing of the columns when reading the csv data.

Removing these columns before running the csv through the converter is a simple workaround but might be something to consider having built-in ability to handle if users aren't able to identify the problem.
Cheers,
~ Bodey (Cardsphere)

Fixed - Updated script to read the headers and return their offsets instead of assuming they would always be in the exact same order/position mine were.


[WIP] migrate from Travis CI to GitHub actions

Travis CI will be used again soon for cgroup v2 environments
test: https://github.com/AkihiroSuda/usernetes/actions

 message: '0/1 nodes are available: 1 node(s) had taint {node.kubernetes.io/disk-pressure:
        }, that the pod didn''t tolerate.'


Update CBL0002.cobol

PRINT-REC NOT REX
Proposed changes
Last line WRITE PRINT-REX  ---> PRINT-REX not exist change into PRINT-REC.
Fixes # (issue)
Type of change
What type of changes does your PR introduce to the COBOL Programming Course? Put an x in the boxes that apply.

[ ] Bug fix (change which fixes one or more issues)
[ ] New feature (change which adds functionality or features to the course)
[ ] Translations (change which adds or modifies translations of the course)
[ ] Documentation (change which modifies documentation related to the course)
[ ] This change requires an update to the course's z/OS environment

Checklist:
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

[ ] I have read the Contributing Guideline
[ ] I have included a title and description for this PR
[ ] I have DCO-signed all of my commits that are included in this PR
[ ] I have tested it manually and there are no regressions found
[ ] I have commented my code, particularly in hard-to-understand areas (if appropriate)
[ ] I have made corresponding changes to the documentation (if appropriate)

Hi Sourav,
Thanks for your interest in contributing to the course. However, for this particular COBOL program, the typo there is intentional as part of our Lab on the File Handling chapter.


decent weekday and month day choosers

Currently, for repeating events the weekday and month selection UI is horrible. A decent day chooser and another for weekday are important.
In both cases probably a dropdown with all available choices is the best solution, type number in the case of month day so that mobile OS can show the adapted field with increment/decrement buttons.

Closed/Implemented with https://github.com/Kartones/flask-calendar/commit/ac1fa0da7b5d96f7b46c9fc0d6ce1032095fbb66


Passing a string for a node failes silently

In a recent issue discovered at xml-crypto it was discovered that if a string is passed for the node argument to select() and friends, it isn't first parsed into a Node, it just fails to find any matching nodes matching the xpath query, even though if the string were parsed into a Node first, it would have. This inconsistent behavior isn't checked for in the API. It seems that if a string is passed in the library should throw or should parse it first.
Referenced issue: https://github.com/node-saml/xml-crypto/pull/380
If desired I can create a PR to do which ever option seems better to you.

Thank you for bringing this up. This should be fixed in 0.0.34 (just published).
#137


Allow loading a drawing from URL

I saw this tweet and like the idea that Excalidraw can actually be used as an open "drawing" format by other apps.
It would be nice if apps could "export to Excalidraw" using a simple link, something like:
https://excalidraw.com/?load=[url-encoded json payload here]

A big drawing might quickly reach the max standard length of an URL, but if it's only loaded on the client side, it might work fine?

Also support "export" instead of "load" to auto-open the export dialog (or even download some default format automatically, if allowed by browser and requested via another param).

I wonder how we should address the fact we don't yet have a JSON spec, and that it's changing quite often still (it's giving us problems to migrate imported files, and there we have some sort of a control over, in terms of expectations).

Also support "export" instead of "load" to auto-open the export dialog (or even download some default format automatically, if allowed by browser and requested via another param).

What use case do you have in mind for this?
Interestingly, if this was done server-side, it could actually allow anyone to embed a drawing based on an url-encoded JSON, which could allow to integrate Excalidraw features in markdown pages, for example:
<img src="https://excalidraw.com/api/render?format=png&data=[url-encoded json payload here]" />

But maybe this is a bit too far-fetched 🤔

What use case do you have in mind for this?

One-click render from another tool into a file.

@gaelduplessix this is exactly the feature I'm interested in. I'm using excalidraw to create sketches on top of documentation and right now I'm storing exports next to MD files in case I need to edit them. What would be cool, is to have some way how to generate images based on the URL data provided and at the same time be able to just drop some route parameter to open excalidraw for editing

I would be happy without the payload being in the URL. It would be great to be able to host the exported *.json wherever I want. Then reference it with
https://excalidraw.com/?load=[url-encoded url to mycustom.excalidraw file].
This would allow me to update mycustom.excalidraw without having to share a new URL.

Check out kroki.io.  Here's an example from the website using the base64 compressed JSON payload:

Hello, is this more current? If so, I would like to try to dev it!
This will allow me to directly open the files in my browser with a small AppleScript:
on run {input, parameters}
	set filePath to POSIX path of input
	set urlString to "https://excalidraw.com/#json=" & filePath
	tell application "Google Chrome"
		open location urlString
	end tell
	return input
end run


SQL syntax support implementation for CREATE Catalog

Enhancement
For Introducing a new framework for StarRocks to connects to external data source more easily,we should implement ddl like create external catalog catalog_name properties ("type"="hive", "hive.metastore.uris"="thrift://[<IP_ADDRESS>:9083](http://<IP_ADDRESS>:9083/)");.

The code has been commited in pr feature: support external catalog ddl.


Set up some CI

Things that would be nice to have:

Automatically checking the whole repo to see if it compiles
Linters like checking we don't go over 80 chars (this is the style in the cubical stdlib)

What do you mean by reject broken builds? Will it actually stop you from pushing to a branch until it passes? Or is this just for PRs?
Check if all code compiles, yes. Broken/incomplete code can go in branches
No clue

Right now, whatever code the user pushes will be on the desired branch. If it passes all the tests you get a green check, if it fails a red X.
I think there are rules that can be added to enforce that you must pass all the tests before the code change is accepted. I currently don't have any of these, but I was asking if we want this sort of functionality on either PRs or when pushing to a branch?
This could be somewhat "safer" but might be a little annoying/overkill. In any case, I think I can get the non-rejecting version of this setup on main later today

#27 sets this up
we still need to fix some line lengths, and there is existing non-compiling code on main. Over the next few days, we can gradually fix these and move the broken code into development branches.
At this moment, I'm unsure which files still have lines that are too long but I'm finding them one at a time with
find . -type f -name "*.agda" -print0 | xargs -0 awk 'length($0) > 80 { print FILENAME ":" FNR ": line too long"; exit 1 }'
and the files that do not compile are

Multicategory.Planar
Categories.Monad.Strength.Cartesian
Categories.Constructions.Product.Fin
Categories.Constructions.Free.Profunctor
Categories.Constructions.Free.Functor.Uniqueness
Categories.Constructions.Graph
Categories.Constructions.Comma
Categories.Constructions.CoGraph
Categories.Limits.AsRepresentable.Cone
Categories.DistributiveLaw.ComonadOverMonad.BiKleisli
Categories.Profunctor.Morphism

We can find these by reading the output of make test-and-report which compiles all files and lists which failed.

This is NOW finally set up. Sorry for the PR spam
Will close this issue when there is finally a green checkmark after fixing the above

Finally passing checks on my fork. So I'm pushing the changes to line lengths/commenting out broken code
I think that the CI can be more efficient, but I'm having some issues correctly caching the agdai files


METS error generated

METS error generated when Archivematica Premis Object Characteristics Extension field is undefined.

Turning off processes that generate derivatives from video, audio, and pdfs affected how the METS file is generated.  METS parsing still fails.

Fixed.


Fix code format

We use Allman style braces, where each brace begins on a new line.
We use PascalCasing style to name the Method.
Summary
Describe your changes here.
Fixes dotnet/docs#Issue_Number (if available)

@rpetrusha For VB should not be changed the property name format that I will only change the cpp file.
And I can not find any VB naming conventions about the field. See Visual Basic Naming Conventions

Thanks, @lindexi, for revising the C++ example. It would still be good to modify the VB example to use the same variable name as the C# and C++ examples. The naming conventions topic is in need of revision and focuses on naming conventions for a type's public interface.
If you'd prefer, though, I can merge your PR, and we can make the VB changes in a separate PR.

@rpetrusha I changed the name in VB.