[FEATURE] Add a different stacking rule to tooltips.

Description of the requested feature
Currently hovering over a widget with tooltip forces said tooltip to use the same stacking rule as the widget. This leads to strange behavior where a tooltip appears behind a window.

Hard to notice, but there is a tooltip behind the terminal.
My suggestion is, if possible, a flag that allows a tooltip to have a different stacking rule.
Widget -> bg
tooltip -> fg
If this is a bug instead, aka it works for other window managers etc then I am happy to report it instead. Currently using Hyperland.
Small note, awesome project, thanks and keep it up :D
Proposed configuration syntax
:tooltip "something"
:tooltip-stacking true/false
Additional context
No response

Also the orientation is the same for the tooltip. When using a vertical bar, tooltips show vertically on the bar itself.
More customization of the tooltip is necessary

I agree, I have my eww bar at the bottom, and the tooltips are displayed below the screen... Impossible to put them at the top.
It's a great idea for a feature.


[UX] Remove association between an alerting monitor and a visualization

Is your feature request related to a problem?
As a user who want to manage information density on the dashboards I want to be able to remove some of the associations between alerting monitors and visualizations.
UX Meta issue
What solution would you like?
https://github.com/opensearch-project/alerting-dashboards-plugin/issues/458
https://github.com/opensearch-project/alerting-dashboards-plugin/issues/457
User story

User wants to be able to list all alerting monitors associated with visualization
User wants to be able to list all visualizations associated with a given alerting monitor
User wants to be able to create/remove an association between a monitor and a visualization.

For associating monitors see https://github.com/opensearch-project/alerting-dashboards-plugin/issues/483
Unlink alerting monitor from visualization

https://user-images.githubusercontent.com/105245012/224926679-1a5b7c7c-988a-4724-9b12-5aa4e837df2a.mp4
Screen 1: User selects a visualization on a dashboard and selects "Alerting" from the visualization context menu OuiContextMenu:

Screen 2: User selects "Associated monitors" from the context menu:

Screen 3a: Selecting "Associated monitors" opens a flyout OuiFlyout with the list of all monitors (OuiBasicTable) associated with the visualization.

Screen 4: Selecting "Remove association" button icon from the "Actions" column opens a confirmation modal (OuiModal) dialog.

Screen 5: User selects "Remove association", and the modal dialog closes. User returns to the flyout. The success or fail message appears as a toast (OuiToast ).  The list of monitors is reloaded and updated accordingly.

Screen 6: Monitor name in the table points to the monitor page in Alerting plugin.
(Selecting "edit" button icon from the "Actions" column opens monitor page in Alerting plugin in "edit" mode.) User scrolls down the page to "Associated visualizations" table, listing all visualizations the monitor is associated. If a visualization is incompatible with the plugin augmentation feature (an example being user changes visualization type after the monitor has been associated), a warning badge (OuiBadges) is displayed in the "Compatibility" column.

Screen 7: Selecting "Remove association" icon button from the "Actions" column triggers a confirmation modal (similar to screen 4).

Screen 8: User selects "Remove association" and returns to the monitor page. A toast message appears.

Additional states for "Associated monitors" flyout:
Screen 3b: Empty state of "Associated monitors" flyout (no alerting monitors associated with the visualization)

Screen 3c: When the limit of plugin objects per visualization is reached, a warning callout is added to the flyout, and the "Associate monitor" button is disabled.

Screen 3d: Permissions error state. When user doesn't have required permissions to read the alerting monitors associated with the visualization, the system shows "Associated monitors" flyout in empty state. A toast message opens with the security error. "Associate monitor" button is hidden.

Done


Daily compound returns analysis

In response to Issue #154, I modified the Returns Analysis table so that the "Mean Period Wise Return Top (Bottom) Quantile" rows displayed daily (one-period) returns, so that it is consistent with the "Mean Period Wise Spread" row.

Thank you @MichaelJMath


magic trap @effect not working

looks like I cant fire @effect under the magic trap spell either.

Fix sent, remember that there is no behaviour for magic trap / untrap (for now) but the spelleffect/effect triggers are properly fired now.

looks like i still couldnt get this one to fire

By default the spells has SPELLFLAG_TARG_ITEM, so you need to cast it on a item

i casted it on a pouch, and couldnt get it to fire off `[SPELL 13]
DEFNAME=s_magic_trap
NAME=Magic Trap
SOUND=snd_spell_magic_trap
RUNES=IJ
CAST_TIME=1.0
RESOURCES=i_reag_garlic,i_reag_spider_silk,i_reag_sulfur_ash
RUNE_ITEM=i_rune_magic_trap
SCROLL_ITEM=i_scroll_magic_trap
FLAGS=spellflag_dir_anim|spellflag_targ_item|spellflag_playeronly
EFFECT_ID=0
EFFECT=0
DURATION=0.0
MANAUSE=6
SKILLREQ=MAGERY 10.0
INTERRUPT=100.0,100.0
//Magic Trap can be used to trap containers. When opened, these containers will damage the person attempting to open it. For this reason, magic trapped pouches can be used to counter the Paralyze spell.
on=@effect
//if (==t_container)
//events=+t_magic_trapped_container
//endif
serv.b effect @
return 1
`

It works here

Confirmed that this is fixed, closing out. Thank you Drk


No longer working

I'm not sure if you are still running this @kevin-hanselman, but it's recently stopped working for entirely for me. Was wondering if you are seeing the same.
In the logs I see:
2023/12/23 10:16:01 listening on [::]:8000
2023/12/23 10:16:44 received request with header map[Accept:[text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/webp,image/apng,*/*;q=0.8] Accept-Encoding:[gzip, deflate, br] Accept-Language:[en-AU,en;q=0.7] Cache-Control:[max-age=0] Sec-Ch-Ua:["Brave";v="119", "Chromium";v="119", "Not?A_Brand";v="24"] Sec-Ch-Ua-Mobile:[?0] Sec-Ch-Ua-Platform:["macOS"] Sec-Fetch-Dest:[document] Sec-Fetch-Mode:[navigate] Sec-Fetch-Site:[none] Sec-Fetch-User:[?1] Sec-Gpc:[1] Upgrade-Insecure-Requests:[1] User-Agent:[Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36] X-Forwarded-For:[<IP_ADDRESS>] X-Forwarded-Host:[whoami.xxx.xxx.xxx] X-Forwarded-Method:[GET] X-Forwarded-Port:[443] X-Forwarded-Proto:[https] X-Forwarded-Server:[1e4eae88806f] X-Forwarded-Uri:[/] X-Real-Ip:[<IP_ADDRESS>] X-Traefik-Router:[5fe107d428019842]]
2023/12/23 10:16:44 can't look up <IP_ADDRESS>:443: 404 Not Found: no match for IP:port

DNS is still set up correctly and nothing has changed with the traefik config. Still trying to chase down what has changed, but thought I'd see if anyone else is having issues.

Ignore me, I had a network configuration issue.


Remove description hash check for lnurl

For https://github.com/lnurl/luds/pull/234

Thanks for the PR!


Update sbt-native-packager to 1.7.4

Updates com.typesafe.sbt:sbt-native-packager from 1.7.0 to 1.7.4.
GitHub Release Notes - Changelog - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.typesafe.sbt", artifactId = "sbt-native-packager" } ]

labels: sbt-plugin-update, semver-patch

Codecov Report

Merging #43 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #43   +/-   ##
=======================================
  Coverage   97.29%   97.29%
=======================================
  Files           1        1
  Lines          37       37
  Branches        1        1
=======================================
  Hits           36       36
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95c58de...587a4a0. Read the comment docs.


many2many not creating foreign keys on join table

I'm trying to build a simple many2many relation between two structs, but I can't seem to get gorm to add foreign keys on the join table, which leaves orphan rows on the table when I delete a record from either one of the structs.
This is the DDL for the join table gorm creates
-- auto-generated definition
CREATE TABLE bookmark_tags
(
    bookmark_id INTEGER,
    tag_id      INTEGER,
    PRIMARY KEY (bookmark_id, tag_id)
);

I was expecting it to be along the lines of
CREATE TABLE bookmark_tags
(
    bookmark_id INTEGER,
    tag_id      INTEGER,
    PRIMARY KEY (bookmark_id, tag_id),
    FOREIGN KEY (bookmark_id) REFERENCES bookmark (id) ON DELETE CASCADE,
    FOREIGN KEY (tag_id) REFERENCES tag (id) ON DELETE CASCADE
);

What version of Go are you using (go version)?
go version go1.12.1 linux/amd64
Which database and its version are you using?
sqlite3
A complete runnable program to reproduce the issue
package main

import (
	"fmt"
	"time"

	"github.com/jinzhu/gorm"
	_ "github.com/jinzhu/gorm/dialects/sqlite"
)

type Bookmark struct {
	ID        uint `gorm:"primary_key"`
	CreatedAt time.Time
	UpdatedAt time.Time

	URL  string `gorm:"type:text;not null"`
	Name string `gorm:"type:text;not null"`
	Tags []*Tag `gorm:"many2many:bookmark_tags;association_foreignkey:ID;"`
}
type Tag struct {
	ID        uint `gorm:"primary_key"`
	CreatedAt time.Time
	UpdatedAt time.Time

	Name      string      `gorm:"type:text;unique;not null"`
	Bookmarks []*Bookmark `gorm:"many2many:bookmark_tags;association_foreignkey:ID;"`
}

func InitSqliteDB(filename string) (*gorm.DB, error) {
	db, err := gorm.Open("sqlite3", filename)
	if err != nil {
		return nil, err
	}

	db.LogMode(true)
	db.SingularTable(true)

	db.AutoMigrate(
		Bookmark{},
		Tag{},
	)

	return db, err
}

func main() {
	db, err := InitSqliteDB("app.db")
	if err != nil {
		panic("Failed to connect to DB")
	}
	defer db.Close()

	result := struct{ Count int }{}
	db.Raw(`SELECT COUNT(*) as count from sqlite_master WHERE sql LIKE '%foreign%'`).Scan(&result)
	fmt.Println(result)
	if result.Count > 1 {
		fmt.Print("Success")
	} else {
		fmt.Print("Fail")
	}
}

I came here to report the same thing.
type User struct {
	ID        int `gorm:"primary_key"`
	CreatedAt time.Time
	UpdatedAt time.Time
	Questions []Question `gorm:"many2many:user_questions;"`
	Answers   []Answer   `gorm:"many2many:user_answers;"`
	Name      string
	Title     string
	Avatar    string
	SlackUser string `gorm:"type:varchar(10);unique"`
}

/*Question table in the Database */
type Question struct {
	ID           int `gorm:"primary_key"`
	CreatedAt    time.Time
	UpdatedAt    time.Time
	UserID       int      `gorm:"index"`
	Question     string   `gorm:"type:varchar(100);unique"`
	Answers      []Answer `gorm:"many2many:question_answers;"`
	SlackChannel string
}

/*Answer table in the Database */
type Answer struct {
	ID           int `gorm:"primary_key"`
	CreatedAt    time.Time
	UpdatedAt    time.Time
	UserID       int    `gorm:"index"`
	Answer       string `gorm:"type:varchar(100);unique"`
	QuestionID   int    `gorm:"index"`
	SlackChannel string
}

mysql> select * from questions;
+----+---------------------+---------------------+---------+----------+---------------+
| id | created_at          | updated_at          | user_id | question | slack_channel |
+----+---------------------+---------------------+---------+----------+---------------+
|  1 | 2019-04-01 23:22:13 | 2019-04-01 23:22:13 |       0 | afsasf   | DGPSA2E0P     |
+----+---------------------+---------------------+---------+----------+---------------+
1 row in set (0.00 sec)

mysql> select * from answers;
+----+---------------------+---------------------+---------+--------+-------------+---------------+
| id | created_at          | updated_at          | user_id | answer | question_id | slack_channel |
+----+---------------------+---------------------+---------+--------+-------------+---------------+
|  1 | 2019-04-01 23:22:18 | 2019-04-01 23:22:18 |       0 | asfasf |           1 | DGPSA2E0P     |
+----+---------------------+---------------------+---------+--------+-------------+---------------+
1 row in set (0.00 sec)

mysql> select * from users;
+----+---------------------+---------------------+------------------+------------------------------+------------------------------------------------------------------------------------+------------+
| id | created_at          | updated_at          | name             | title                        | avatar                                                                             | slack_user |
+----+---------------------+---------------------+------------------+------------------------------+------------------------------------------------------------------------------------+------------+
|  1 | 2019-04-01 23:22:13 | 2019-04-01 23:22:13 | Jane Does | Engineer | avatar.jpg | channelID  |
+----+---------------------+---------------------+------------------+------------------------------+------------------------------------------------------------------------------------+------------+
1 row in set (0.00 sec)```

@grvlle I guess you're referring to the issue where the UserID index is not updated in the tables, when QuestionID is? Not sure if this is related to this issue.
I'm experiencing the same issue using mysql. The join tables gets created but remain empty for a many2many relationship.

@netrounds-martin Well both actually. My join tables are empty too.

The join tables gets created but remain empty for a many2many relationship.
@netrounds-martin In my case, new records get added to the join table, but there's no foreign keys to enforce data consistency.

I have tried many things from gorm documentation but I am also facing the same issue.
It seems like all the associations are created only at the model level but not on DB schema.

Yeah this kind of sucks, if you use gormigrate you can explicitly create the join table and migrate it before adding the many2many on the two models you want to be joined through the join table. And then migrate the many2many table which won't modify the existing explicit join table.
** Auto Migration using Gormigrate (1)**

// Inside the migrate function in the gomigrate migration
type Bookmark struct {
	ID        uint `gorm:"primary_key"`
	CreatedAt time.Time
	UpdatedAt time.Time
	URL  string `gorm:"type:text;not null"`
	Name string `gorm:"type:text;not null"`
}

type Tag struct {
	ID        uint `gorm:"primary_key"`
	CreatedAt time.Time
	UpdatedAt time.Time
	Name      string      `gorm:"type:text;unique;not null"`
}

type BookmarkTag struct {
    BookmarkID uint `sql:"type:int8 REFERENCES bookmarks(id)"`
    Bookmark *Bookmark `gorm:"foreignkey:BookmarkID"`
    TagID uint `sql:"type:int8 REFERENCES tags(id)`
    Tag *Tag `gorm:"foreignkey:TagID"`
}

db.AutoMigrate(
		Bookmark{},
		Tag{},
                 BookmarkTag{}
	)

Automigration in Gomigrate file (2)
Here we update the Tag and Bookmark tables with the many2many annotations so we can use the gorm association methods with the explicit bookmark_tags join table

// Inside the migrate function in the gomigrate migration
type Bookmark struct {
	ID        uint `gorm:"primary_key"`
	CreatedAt time.Time
	UpdatedAt time.Time

	URL  string `gorm:"type:text;not null"`
	Name string `gorm:"type:text;not null"`
	Tags []*Tag `gorm:"many2many:bookmark_tags;"`
}
type Tag struct {
	ID        uint `gorm:"primary_key"`
	CreatedAt time.Time
	UpdatedAt time.Time

	Name      string      `gorm:"type:text;unique;not null"`
	Bookmarks []*Bookmark `gorm:"many2many:bookmark_tags;"`
}

db.AutoMigrate(
		Bookmark{},
		Tag{}
	)

You would just run these two migrations in this order and it works fine.
Another hacky solution if you don't want to use gormigrate that works okay and generates fks on the join table if you are just using this to get the tables migrated initially like in an initilization script is to automigrate all the models first and then drop the join tables and re-automigrate them. I think it's a good idea to explicitly definite the join tables, but it sucks that the many2many struct tags generate the join table before explicitly creating the join table if you try to automigrate everything and add additional fields to your join table but the primary key annotation isn't added to the field.
// In db Initialization script
type Bookmark struct {
	ID        uint `gorm:"primary_key"`
	CreatedAt time.Time
	UpdatedAt time.Time

	URL  string `gorm:"type:text;not null"`
	Name string `gorm:"type:text;not null"`
	Tags []*Tag `gorm:"many2many:bookmark_tags;"`
}
type Tag struct {
	ID        uint `gorm:"primary_key"`
	CreatedAt time.Time
	UpdatedAt time.Time

	Name      string      `gorm:"type:text;unique;not null"`
	Bookmarks []*Bookmark `gorm:"many2many:bookmark_tags;"`
}

type BookmarkTag struct {
    BookmarkID uint `sql:"type:int8 REFERENCES bookmarks(id)"`
    Bookmark *Bookmark `gorm:"foreignkey:BookmarkID"`
    TagID uint `sql:"type:int8 REFERENCES tags(id)`
    Tag *Tag `gorm:"foreignkey:TagID"`
}

db.AutoMigrate(
		Bookmark{},
		Tag{},
                 BookmarkTag{}
	)

db.DropTableIfExists(BookmarkTag{})
db.AutoMigrate(BookmarkTag{})

There should really be a flag to ignore creating the many2many table annotated on a field during automigrate so that we can just explicitly define jointables without having to do some automigration or migration trickery and retain the nice many2many join/associate helper functions etc.
Anyways hope this helps.

These missing foreign keys caused some confusion on my side too.
Another workaround to add the foreign keys would be to use gorm's AddForeignKey() on a temporary model representing the join table. It plays well with the auto migration too.
// regular models
type User struct {
	gorm.Model
	Name string
}

type Board struct {
	gorm.Model
	Name    string
	Members []User `gorm:"many2many:board_members"`
}

db.AutoMigrate(
	User{},
	Board{},
)

// temporary model for adding foreign keys
type BoardMembers struct {
	UserID  uint
	BoardID uint
}
db.Model(&BoardMembers{}).AddForeignKey("user_id", "users(id)", "CASCADE", "RESTRICT")
db.Model(&BoardMembers{}).AddForeignKey("board_id", "boards(id)", "CASCADE", "RESTRICT")


Pass in counterparty portID, channelID when verifying channel in ChanUpgradeOpen.

Description
Fixes a bug raised by Luca Joss in the shared ibc-go-rs channel.
Rename to proofCounterpartyChannel to align with the rest.
closes: #XXXX
Commit Message / Changelog Entry
fix: pass counterparty portid, channelid.

see the guidelines for commit messages. (view raw markdown for examples)

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against correct branch (see CONTRIBUTING.md).
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards and Go style guide.
[ ] Wrote unit and integration tests.
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/).
[ ] Added relevant godoc comments.
[ ] Provide a commit message to be used for the changelog entry in the PR description for review.
[ ] Re-reviewed Files changed in the Github PR explorer.
[ ] Review Codecov Report in the comment section below once CI passes.

We should add a test case that would catch this?

We should add a test case that would catch this?

I tried. This issue was a result of both chains having the same values for port/channel. It's tricky since we create the mock IBC app using a portID of mock and channel ids by default result in channel-0 for both. Unsure if I'm missing some other option here.

I tried. This issue was a result of both chains having the same values for port/channel. It's tricky since we create the mock IBC app using a portID of mock and channel ids by default result in channel-0 for both. Unsure if I'm missing some other option here.

One quick hack is to make a second path and call endpoint.ChanOpenInit on one side. This will generate channel-0 on that end. Then when you create the path for testing, one side will have channel-0 and the other will have channel-1


Training yolo-v3 models sometimes results in checkpoints that cannot be loaded correctly

Hi SparseML team.
Describe the bug
When I train models, in some cases I cannot load them into the test.py tool. Specifically I get an error message at this line that tells me I cannot change requires_grad flag of non-leaf variables.
Interestingly, this seems to happen only when training on coco, but not voc or coco128.
Expected behavior
A clear and concise description of what you expected to happen.
Environment
Include all relevant environment information:

OS [e.g. Ubuntu 18.04]:
Python version [e.g. 3.7]:
SparseML version or commit hash [e.g. 0.1.0, f7245c8]:
ML framework version(s) [e.g. torch 1.7.1]:
Other Python package versions [e.g. SparseZoo, DeepSparse, numpy, ONNX]:
Other relevant environment information [e.g. hardware, CUDA version]:

I am using the sparseml/integrations/ultralytics-yolov3 sparseml integration as described in that readme. My HEADs are set to:
sparseml repo: 5713665bb69582f56c1ec7ac9a93a3dbd8578b42 (note: I don't use the pip version of sparse ml, I source the code in src/ directly)
yolov3 repo: e3bbbad5431f4a3c600547c79f968be540886310
OS: Ubuntu 18
Torch:  1.7.1
Cuda 11.2
To Reproduce
Exact steps to reproduce the behavior:
Train model:
CUDA_VISIBLE_DEVICES=0,5,6,7 python -m torch.distributed.launch --master_port=654327 --nproc_per_node 4 train.py --workers 16 --batch 32 --img 512 --weights PRETRAINED_WEIGHTS --data data/coco128.yaml --hyp ../data/hyp.pruned.yaml --recipe ../recipes/short-yolov3-gmp.85.acdc.md --cfg models/yolov3-spp.yaml --disable-ema
(note that the exact recipe doesn't seem to matter, I just made a really short one)
Test model:
CUDA_VISIBLE_DEVICES=1 python test.py --weights runs/train/exp81/weights/last.pt
train.py and test.py are located in sparseml/integrations/ultralytics-yolov3/yolov3
Errors
If applicable, add a full print-out of any errors or exceptions that are raised or include screenshots to help explain your problem.
Namespace(augment=False, batch_size=32, conf_thres=0.001, data='data/coco128.yaml', device='', exist_ok=False, img_size=640, iou_thres=0.6, name='exp', project='runs/test', save_conf=False, save_hybrid=False, save_json=False, save_txt=False, single_cls=False, task='val', verbose=False, weights=['runs/train/exp81/weights/last.pt'])
YOLOv3 🚀 v9.5.0-33-g62c06bb torch 1.7.1 CUDA:0 (GeForce RTX 2080 Ti, 11019.4375MB)
Fusing layers...
Model Summary: 269 layers, 62971933 parameters, 62971933 gradients, 157.1 GFLOPS
Traceback (most recent call last):
File "test.py", line 328, in
save_conf=opt.save_conf,
File "test.py", line 59, in test
model, extras = load_checkpoint('ensemble', weights, device)  # load FP32 model
File "/nfs/scistore14/alistgrp/eiofinov/sparseml/integrations/ultralytics-yolov3/yolov3/models/export.py", line 70, in load_checkpoint
p.requires_grad = True
RuntimeError: you can only change requires_grad flags of leaf variables.
NOTE: wrapping the offending line in a try statement or just saying if p.is_leaf fixes the problem and leads to test output. But this is probably not ideal :)
Additional context
Add any other context about the problem here. Also include any relevant files.

Thanks for bringing this to our attention @ohaijen, we'll dive into this more this week to see about a resolution.

Hi @ohaijen
We could not reproduce this error; in October, we will be having a software release. We will circle back and see if you're still having this issue. Thank you for your patience.

Hello @ohaijen
With our last release deployed at the end of October, we wanted to check in and see if you were still experiencing this issue? Let us know your experience! We're happy to assist.
Best, Jeannie / Neural Magic

Hello @ohaijen
As there have been no further comments on this, we will close out this issue. Feel free to re-open it however if you would like to continue the conversation.
Thank you! Jeannie / Neural Magic


Make tutorials interactive with binder

Binder allows the user to open a certain file in a Jupyter notebook to immediately experiment with it with zero configuration and installation steps. It would be a good idea to give user's access to the examples in this way.

Looks like readthedocs has no native integration with binder (see issue).

Then we could just offer a button at the beginning of the tutorial to open it with binder 😢.

Yes, I was just thinking about that. We could add a badge with the link to Binder.
I just tried to run one of the tutorials out of the box, but binder fails when automatically installing the docs repo.
We might have to look into that

Note: Probably has to do with the custom install script that automatically builds the docs when installing

Note: According to the binder documentation, binder will build based on a Dockerfile when one is present. However, the Dockerfile we use is meant to start a server for rendering the docs locally. The options I can think of:

Rename the Dockerfile to something like "build_locally.Dockerfile", and provide the name in the build command via -f. It must be checked that binder won't pick up one with a different name.
Remove the CMD line in the Dockerfile that starts the server and just print the command so that the user can run it when running the image interactively.

Detect in the dockerfile if it is running in Binder.

/cib

@yoavnash @kysrpex
An issue here. The binder badge will have a link pointing to the file in GitHub, which means it has to include (hardcoded) the branch name. Since it should probably be master, it also means it won't be fully testable until we merge to master at the end of the sprint.

@yoavnash @kysrpex
An issue here. The binder badge will have a link pointing to the file in GitHub, which means it has to include (hardcoded) the branch name. Since it should probably be master, it also means it won't be fully testable until we merge to master at the end of the sprint.

I guess we can still click and then change the address, so it would be almost tested. We may be lucky if there is some trick Sphinx can do for us here.


Datepicker consistency

All in the picture:

Steps:

got to 31th January 2015
move to next month (the cursor will be placed on 28, display 31)
move to the next year (will display the content of the picture)

If 31th Jan 2015 is selected, it should keep on displaying Jan 31 2015, or that day in the month ie 31 Mar 2015 / 28 Feb 2015?

You should not be able to display "31 Feb",
and the display date should be the same as the selected or the cursor.
I had reported the issue because I think there is some working rules missing.

Fixed in 45a809a96be690d402a285a3a080929c2c1f654a

Still display 31 Feb
Steps:

got to 31th January 2015
move to next month (the cursor will be placed on 28, display 31)

I'm not seeing it display Feb 31.
On Wed, Feb 25, 2015 at 3:31 PM, Tacyniak<EMAIL_ADDRESS>wrote:

Still display 31 Feb
Steps:
got to 31th January 2015
move to next month (the cursor will be placed on 28, display 31)
—
Reply to this email directly or view it on GitHub
https://github.com/Dogfalo/materialize/issues/565#issuecomment-76049638.

--
Doggy sends his greetings from Mars.

Fixed in bea3f9a97ee14080fc88c6f7bd70ba2df5377e95

Tanks!


What about moving the repository away from GitHub?

GitHub, under Microsoft, still collects and tracks personal user information.
Any thoughts on moving the repository to a more privacy focused git hosting, like Codeberg?
Thanks for all the contributions, I really enjoy this project!

I am now slowly moving to codeberg. This will be also moved there but I will need some time.

Awesome, thanks!

While I do like Gitlab, I prefer Codeberg as it is based on Gitea and is more lightweight.

On top of that, I would argue gitea is also better for privacy than gitlab as you can view projects with javascript disabled, but if you want to selfhost a git service, I would recommend you checkout this spreadsheet (while this is made by gitea, it does not seem biast (to me, at least) as it covers all the features people probably care about).

The repo is already mirrored in Gitea, so anyone can use that link instead of the Github one! Also, any issues opened there are also reviewed.


 That was probably drawn from the  "durationSeconds"=>{"gteq"=>{"from"=>0, "to"=>nil}} block in the params - which is a malformed filter from the client.
Action item

[x] Better validate the filter queries for this particular case
[x] When done, file issue in client to stop malformed filter requests

Client issue: https://github.com/QutBioacoustics/baw-client/issues/284


Gameboy octane test fails

identifier 'gameboy_rom' undefined

gbemu-part2 has the gameboy_rom var at the bottom as a very long string

No further action to take on this.


Unable to type-cast a dataframe to Dataset

from typing import cast

df = cast(Dataset["timestamp", "volume"], df)

Gives the error:
Expected class type but received "Unknown | DatasetMeta"
  "DatasetMeta" is not a classPylancereportGeneralTypeIssues

Is this an issue with Pylance? I would expect to be able to cast a dataframe to the Dataset type

The same happens when I define it as the return type of a method 🤔 :

I am not using Pylance so I don't really know why it doesn't accept it. Maybe it is a special case that it doesn't support.
See e.g. https://github.com/microsoft/pylance-release/issues/360 which looks similar.
Cheers
/C


[TF Backend] Wrap tf.where into Keras

Summary
Hi @fchollet, I wrap tf.where into Keras: K.where. An easy wrapper~
Related Issues
PR Overview

[y] This PR requires new unit tests [y/n] (make sure tests are included)
[y] This PR requires to update the documentation [y/n] (make sure the docs are up-to-date)
[y] This PR is backwards compatible [y/n]
[y] This PR changes the current API [y/n] (all API changes need to be approved by fchollet)

@fchollet Thx a lot, i add it in all backend. But i had not found there is a where ops in CNTK which can performs same function like tf.where.

@taehoonlee maybe we could resurrect #11265 ? This would be useful for this PR, #11556 , and also the tests of the new K.clip function since clip can now take three input tensors as arguments.
To me, having check_single_tensor_operation, check_two_tensor_operation, check_three_tensor_operation isn't a good idea. It will be hard to maintain in the long run. Especially if we start making check_five_tensor_operation for batchnorm.

The tests are ok but we'll need to do a refactoring later. It is ok to merge.

@fchollet maybe a noob question, but what's the benefit of having K.where when we have K.switch? Isn't K.switch just a more powerful version of K.where which also handles callables?


Settings Capabilities for dumpcap failed

So running the builder first time. It’s been churning away for 3 hours on my old 2 core toshiba satellite (I think it’s smoking lol). I did not go with the default option regarding non root member privilidges and wireshark (selected yes). Running a fresh install of Ubuntu 18.04LTS
Now I have encountered two problems one is an error window in terminal showing setting capabilities for dumpcap failed.
The second problem is that I cannot select the  prompt in the above mentioned error window. It’s like I cannot send a “return” to the terminal to select ok (my only option). So now the builder is stuck. I will mess with it some more to see if I can get past this poor mans gui problem.
On a positive note I burned @Yes21 2.0beta image dated 11-05 and had great results so far. Not sure where to post them but
AirPi is running ez-wbc 1.6rc6
Pi zero w
36nha x1
GroundPi 2.0beta
Pi 3b+
722n x1
Official pi 7 inch display
Telemetry, OSD, RC worked with both the pi display only and with android phone tethered running fpv-vr
As reported elsewhere no splash screen.
Nice work! I’ll do more testing with more dongles and also running this 2.0beta image on the airpi

Couldn’t tab to the ok either...

Now I have encountered two problems one is an error window in terminal showing setting capabilities for dumpcap failed.

Happy to see you trying the builder ;-)
Sorry to be unable to help you, but I've never encountered this issue with the builder ...
I hope you will soon understand what happens.

Second time around was much faster to compile. I went with the default "no" option to the wireshark question and avoided the hangup again. Will test my fresh image tomorrow.

@pilotnbr1 Did you now succeed in building a 2.0beta image ?

Yes! Now on my 10th easily lol
I have one cooking now with quite a few packages removed- we will see :)

@pilotnbr1 Is this issue always pending ?

@Yes21 honestly not sure, but I think so.
This error occurred when selecting “yes” to the wireshark question/prompt.
Now I always select “no” and have not looked into it.

OK, so we need to add this to the readme, and then close the issue.
Danke.

@pilotnbr1 Please could you now close this issue ?

👍


⚠ Processors has degraded performance

In c6e201b, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 77 ms

Resolved: Processors performance has improved in 11d92bf.


FilesystemRoleDataStore.InitializeRootPath doesnt work with "~/"

Hi,
Because of the way that System.IO.Path.Combine works, if the 2nd argument starts with "\" it will return the 2nd argument as the combined path.
In the code of Unicorn.Roles.Data.FilesystemRoleDataStore.InitializeRootPath(), when computing the 2nd argument for Path.Combine you have rootPath.Substring(1) which results in a 2nd argument starting with "\" if the rootPath started with "~/"
I noticed that the Rainbow.Storage.SerializationFileSystemDataStore.InitializeRootPath() already accounts for this, so maybe use that code instead? :)

The root cause of this looks to be the same as #260


Segfaults on highly nested html

Example:
iex(4)> Enum.reduce(1..4000, "", fn _,acc -> "<div>" <> acc end) |> Html5ever.parse()
Segmentation fault

While I doubt any HTML document really needs 4k nested tags, this could be abused by attackers if the library is used to parse user-generated content.
I am not too familiar with Rust, but I am pretty sure you are hitting recursion depth limit when transforming the parsed tree to erlang terms.

This should hopefully not be an issue with the latest commits. Would you mind testing again?

Looks like it's fixed now, can't reproduce even with 100k nested <div>s.


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target/pull/173 is merged into live branch.
Auto archive content to https://github.com/OPS-E2E-PPE/docs-archive-test-target.git

Docs Build status updates of commit 3f8209a:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error]

Cannot sync git repo to specified commit because branch Archive_master_2019-10-11-04-00-52 has been deleted or has been force pushed: fatal: Couldn't find remote ref Archive_master_2019-10-11-04-00-52

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Plugin Intention

Hello! The Homebridge community is a curious one and as a result there's been some talk of your plugin already. I am wondering if you can clarify what the intended goal of your plugin is. Do you aim to have an official supported plugin that regular homebridge users can download and use directly? Or are you designing this for your OEM partners?

Hi @rcoletti116, sorry for the late reply! Glad that the homebridge community is interested in the new official tuya homebridge plugin!  This plugin is definitely not designed for Tuya's OEM partners, we're going to provide official support for the community. While we wish the homebridge users can use this plugin as Tuya developers, and the intended goal of this new plugin is mainly for Tuya developers to try our Tuya IoT Cloud and App SDK products to build SaaS solutions, like Smart Home SaaS. For more info, please check the API Products Doc。
The new plugin is built on top of the Tuya's Open API capabilities. And it requires connecting to Tuya Cloud for device control. We will support two types of Cloud projects in Tuya IoT Platform: Smart Home and Industry Solution.

Using the Smart Home type, developers can use Tuya Smart/Smart Life app to pair your PBT devices directly to homebridge. It's more friendly to the existing Tuya homebridge users. We will support this project type in late May,2021. This type is mainly for the smart home customers/end users/individual developers/geek.

Using the Industry Solution type, developers need to use our new Device Manager app (Only provide Android version for now, iOS version will be released soon) to do device network pairing to homebridge. For existing devices linked in the Tuya Smart/Smart Life app, you need to relink them using this new app for now as it's in different account system. This type is mainly for Individual Service Vendor(ISV), software companies/startups who want to build SaaS solutions for smart hotel, apartment, retail, etc. And it's now available in this github repo!

As this new plugin is developed using Tuya's Open API, all the exiting device drivers for homebridge in the market are not adaptable. We need to rebuild all the drivers using Tuya's Standard Instruction Set, which can support much wider product types compared to the existing ones in the market.
If the homebridge community is interested to help build these new drivers as Tuya developers for the new plugin together, support much more PBT products, please let us know. Any help is appreciated!  Here is the tutorial for building the new Tuya homebridge drivers: https://developer.tuya.com/en/demo/tuyahomebrigeplugin
Tuya developer email<EMAIL_ADDRESS>


AppBarLayout with suggestion takes up the whole page

When testing the library with a large suggestion list within AppBarLayout, the toolbar takes up the whole page. The screenshot is attached:

After clicking the search and back button, the page is back to normal state. When the search view is shown, the suggestion is working properly.

Take a look in the native approach: http://www.materialdoc.com/search-filter/

I followed also your "fix" trick but i have a drawer and in the case you show the toolbar is on the nav drawer.

@Songroid can u solve this ?

Here's how I've solved this, notice android:layout_height="?attr/actionBarSize"
<android.support.v7.widget.Toolbar
                android:id="@+id/toolbar_home"
                android:layout_width="match_parent"
                android:layout_height="?attr/actionBarSize"
                android:background="?attr/colorPrimary"
<EMAIL_ADDRESS>/>

            <com.miguelcatalan.materialsearchview.MaterialSearchView
                android:id="@+id/materialSearchView_search"
                style="MaterialSearchViewStyle"
                android:layout_width="match_parent"
                android:layout_height="?attr/actionBarSize" />

Hi mehmetakiftutuncu, Do you get to see suggestions after adding android:layout_height="?attr/actionBarSize" in MaterialSearchView ? I am trying but it does not show suggestions now !

I have the same problem. non of suggestions help me!

Commenting line
mTintView.setVisibility(VISIBLE);
from MaterialSearchView.java -> setSuggestions method did the trick for me

@HamedGh if you actually download the demo and try it with the "tabs", it would not work so it's better to stick to another approach.


Fix typing error in suggester

It seems like there was an error in the types of the suggester function. The functions seems to be used to map the elements to a string array, so the lambda should return a string, as it is called on every element in the array.

https://quickadd.obsidian.guide/docs/QuickAddAPI#suggester-displayitems-string--value-string-index-number-arr-string--string-actualitems-string-promisestring


Creating figma plugin for the icon set

Creating a Figma plugin for this icon set will give the designers ( figma community/users) a helping tool when creating designs for the hospitality sector. The chances of using the icon set will increase as a Figma plugin
Please assign me this so I can create a figma plugin for your iconset.
Thank you
sanya
GSSOC 2023 contributor

This is a good issue. Can you please specify any charges for this? or is it free to publish? Also is there anything you want us to help you with that?

It is free to create a Figma plugin.
here is the official plugin guide link by figma- https://www.figma.com/plugin-docs/
if we don't want to pursue this, an alternative to this is creating a library of icon and publishing it on the Figma community page. We can use components and do it in a user friendly way. I can create the file. Or we can do both.
Let me know which way you want to go

@sanya031 so for the Figma part do we have to create an account or something like that??

Yes we can publish the library and plugin in 2 ways

I can create the library on my figma account share the file with you. You can duplicate it and publish it under your name.
The plugin is to be coded so we can code on any system but will be uploaded for public use from your account only.

You can create a figma account using your gmail, create a file and give me editing access. This way I can create the library in your account's file  and you can see the progress too by opening it.

Either way you have to create an account under your name or bookingjini whatever is comfortable for you.
I think the 2nd method is easier.

@bikidsx can you please take it forward from here

@sanya031 Please go forward with creating a plugin. We don't need a library as of now. Upload the code in this repo, we will then publish it from our account.

@sanya031 any update on this?

closing the issue since the assignee didn't give any  update


Add a medical template button to the market templates

'Don't see your category? Learn more' will get pushed below - see design.
https://www.figma.com/file/IpIAYVQPeQfuT5TTUboQpo4S/Market-creation?node-id=3047%3A4344

added closing


Fix URL for use with newer Keycloak versions

Newer versions do not use /auth anymore.

In addition, the auth word needs to be removed from the below in Ch 4:
https://github.com/PacktPublishing/Keycloak-Identity-and-Access-Management-for-Modern-Applications/blob/80b4ad2db37fb72ea9d6d1bd2743d68edf4d7b8d/ch4/index.html#L25

Thanks for the PR, but since the book was written for older versions of Keycloak it wouldn't make that much sense to alter the examples to be incompatible with the book. A 2nd edition of the book is in development, which updates the examples for newer versions of Keycloak. In the meantime we've written up some workarounds in https://github.com/PacktPublishing/Keycloak-Identity-and-Access-Management-for-Modern-Applications/issues/26.


Remove modal style close buttons on pages in favour of breadcrumbs

See #2828 as an example.

More specifically, we shouldn't have the close button in the top nav bar, it breaks the context of the header.

Done

Done


[Question]: Best way to initiate VectorIndexStore from predefined embeddings

Question Validation

[X] I have searched both the documentation and discord for an answer.

Question
I can't seem to find in the documentation the most efficient way to introduce a VectorStoreIndex based on embeddings that I retrieved earlier (without Llamaindex). Right now I have the following method but I reckon it is very inefficient:
nodes = [TextNode(text=self.texts[i], id_=str(i), embeddings = self.embeddings[i]) for i in range(0,len(self.texts))]
index = VectorStoreIndex(nodes)

Is there a better way to do this?

This seems to be moving the problem from VectorStoreIndex to ZepVectorStore. I have my embeddings stored locally and can acccess them via python numpy array objects.

@MaartenCVonk if you attach embeddings to the node object, they will not be re-embeded, and directly inserted
node = TextNode(text="text", metadata={}, embedding=[0.1, 0.1, ...])
index = VectorStoreIndex(nodes=[node], ...)


Make TagHelper resolution delta based

We were getting hit pretty hard in serialization & deserialization paths in our TagHelper resolution endpoints. After investigation it looks like every keystroke will kick off resolution requests every 1 second. While this may seem "too frequent" it actually enables us to provide better TagHelper detection/colorization/error states so keeping a frequent polling approach is still a goal. Therefore I designed a path to reduce the amount of data that's passed back & forth between VS & the Roslyn service hub processes. The gist is that we now have a delta result which the client & server both understand. That result has an Added, Removed, ResultId and Delta parameter. First two are self explanatory, ResultId represents an "id" that a client needs to keep track of (inspired by LSP) and Delta just indicates if the response is delta based or the client should not try and apply the response as a delta.
Added exhaustive unit tests for each of the delta pieces given they have an extremely high impact to end-user functionality.

Results
Scenario: Opening users application and hitting "enter" 5x in their @code section. Wait for bottom left hand corner (background processing) to complete. Measure.
Allocations
Before = Left, After = Right

Gist: We allocate 61% less when only looking at Newtonsoft specific objects; however, Newtonsoft also allocates other transient objects like lists, dictionaries, extra strings etc so understanding the true reduction of memory is a bit harder. Therefore I also took CPU profiles
CPU
Before = Left, After = Right

Gist: devenv's CPU utilization is 58% less and ServiceHub's is 42% less. Taking both processes into account we utilize 52% less CPU on users machine for basic editing.
Fixes #5673

Thank you SO much to everyone there for your contributions towards addressing this.  This goes to each and every one of you:

🙏

I have no real comments here, other than it would be good to see benchmarks (in a follow up obv) because the one thing that does stand out to me as odd is the usage of List<T>s for things that are doing lots of Contains calls. Seems a hashset could make an impact, especially with the 4.5k tag helpers cases you were talking about elsewhere.

We think alike! I actually have a local stash where I translated all of the cached containers into HashSets and then manually benchmarked them (didn't actually write a benchmark test).  In practice it looked like the HashSets didn't cause too much of a difference probably because our sub-systems in our tooling infra utilize IReadOnlyList everywhere which required me to translate from HashSet -> List / manage mutability. Basically I figured that the complexity in translating to/from hash sets wasn't worth the minimal gain I was seeing via manual testing.
Now that being said after you rightfully called out the opportunity for HashSets I went back and wrote some proper benchmark tests that represent what would happen and the gains are pretty stellar there (around 5k TagHelpers):

Method
Mean
Error
StdDev
Op/s
Gen 0
Gen 1
Gen 2
Allocated

'(List) GetAddedTagHelpers'
83.311 ms
1.6337 ms
2.1809 ms
12.00
1714.2857
-
-
7 MB

'(List) GetRemovedTagHelpers'
82.732 ms
1.6464 ms
1.7616 ms
12.09
1714.2857
-
-
7 MB

'(HashSet) GetAddedTagHelpers'
5.137 ms
0.0940 ms
0.0833 ms
194.67
1039.0625
203.1250
-
4 MB

'(HashSet) GetRemovedTagHelpers'
5.245 ms
0.1046 ms
0.1431 ms
190.67
1039.0625
203.1250
-
4 MB

Leads me to believe my manual benchmarking didn't do the potential gains justice; sooooo all that said I think I'll re-visit this changeset and actually do the HashSet variant in a follow up like you suggest ❤


[textures] GetScreenData() is very slow

I am writing a CLR wrapper on Raylib to use it with WPF.
This requires calling GetScreenData method.
While using it seems that GetScreenData method is much slower.
In a normal scenario I get 60 fps when I do not call GetScreenData method.
But when I call the method the fps drops to 15-30 fps.
Need an efficient way to fetch the frame buffer and create a C# bitmap or D3D image which can be shown on WPF window.
System Specs are as follows:
Intel I7 8th gen cpu
NVidia GTX 1060 6GB Graphics card
16 GB Ram

GetScreenData() is very slow, not many options here, it just copies data from VRAM to RAM, this is a very slow process, it's a limitation imposed by the OpenGL driver.
I imagine there could be some option to directly share graphics buffer but I don't know how...

Some possible references after a quick search:
https://www.codeproject.com/Articles/265903/Using-OpenGL-in-a-WPF-Application
https://community.khronos.org/t/wpf-and-opengl/59433/12


Parameter documentation incomplete

For example, under 'Very Common':

fail_on_severity

Only fail if flaws of Very High or High severity are found.

It's not obvious what I pass here? The usual command line argument 'Very High,High' doesn't seem to work.
There is no description for the 'Common' parameters also.

The syntax "Very High, High" is correct according to the documentation in action.yaml:
fail_on_severity:
    description: 'Fail the pipeline job if the scan finds flaws of the specified severities. Enter a comma-separated list of severities in quotation marks.'

But you are right, there's currently a parsing bug and it doesn't work. I have PR #30 for it.


SQL Editor Display Issues caused by SQL Syntax Parser

Description
Recently I am getting display issues on OSX with latest DBeaver. Please see attached screenshot.

I think it has something to do with the SQL Syntax parser. If I disable the parsing the text is displayed correctly.
DBeaver Version
Community Edition Version <IP_ADDRESS>402181738
Operating System
macOS 14.2.1
Database and driver
No response
Steps to reproduce
Open SQL Editior
Add some sql commands with brackets ()
Additional context
No response

Thank you for bug report. It's a duplicate of #22299
You can vote for the mentioned issue with 👍 under the issue description to promote it to a higher priority.


Update SslHandler to set bio fd member to facilitate openssl tracing (Pixie integration)

Motivation:
I've been working on extending the pixie platform to support out of the box instrumentation for twitter/finagle and eventually the netty project (https://github.com/pixie-io/pixie/issues/407).
For those that aren't familiar, Pixie is an open source, Kubernetes Observability tool that provides auto instrumentation by leveraging eBPF. It has support for tracing network traffic for a variety of protocols (http/2, kafka, mysql, mux, etc) even if encrypted with openssl. Its openssl tracing support works by instrumenting the SSL_read and SSL_write functions through a uprobe. This uprobe captures the data just before encryption or just after decryption, in addition to navigating openssl's rbio struct to access the socket file descriptor (necessary for associating network traffic with a particular container).
Modification:
Due to how netty uses openssl today, the openssl SSL struct passed to SSL_read and SSL_write does not have the socket fd set. This is because netty's Java code handles the network transport and leverages openssl only for encryption and decryption. The functionality added in this PR allows netty to populate the SSL struct's rbio field with the socket file descriptor when a channel becomes active (first created). This change is dependent on the netty-tcnative changes made in https://github.com/netty/netty-tcnative/pull/731
My understanding is that each netty channel will be given its own ssl engine, so setting this socket file descriptor on a per connection basis shouldn't be a problem. It's also worth mentioning that getting this to work with Pixie requires setting -Dio.netty.native.deleteLibAfterLoading=false. So while the goal is to instrument netty TLS connections with no configuration, that option would be necessary.
Result:
Fixes the majority of the remaining work in https://github.com/pixie-io/pixie/issues/407. The remaining changes would be in the pixie project

[x] Verified that pixie's netty TLS tracing works for a twitter/finagle service on https://github.com/pixie-io/pixie/pull/446

I wanted to open up this PR to facilitate discussion on how to accomplish this integration between pixie and netty and look forward to your feedback :)
Todo

[ ] Deploy a Twitter production service with this change to stress test there aren't any regressions
[ ] Other items from code review

@normanmaurer @chrisvest just wanted to check in on this. Would we need to wait until netty-tcnative 2.0.53 is released before this could be merged (and update the dependencies appropriately)?

@ddelnano I think so, yeah.

@normanmaurer I've just rebased 👍
Is there anything that needs to be done to support netty 5? Is there a process for making sure changes are pulled 'upstream'?
Otherwise, let me know if there is anything left for me to do.

@normanmaurer I think there might be an issue with the netty-tcnative 2.0.53 release (as mentioned in Discord).

@chrisvest if you are satisfied merge this one please .

Yeah

Am 06.06.2022 um 02:43 schrieb Dom Del Nano @.***>:

@normanmaurer @chrisvest just wanted to check in on this. Would we need to wait until netty-tcnative 2.0.53 is released before this could be merged (and update the dependencies appropriately)?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.

@normanmaurer was your reply about my netty 5 question?


Troubleshoot SSH connection issues

@megk105 @rnpatel99 you can close this issue when you successfully SSH into our server at <IP_ADDRESS>


fix(avoidance): fix avoidance path chattering (#2012)

Description
https://github.com/autowarefoundation/autoware.universe/pull/2012
hotfix to beta/v0.5.2-odaiba
(Currently, the target branch of the PR is beta/v0.5.2 because beta/v0.5.2-odaiba does not exist yet.)

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Codecov Report

:exclamation: No coverage uploaded for pull request base (beta/v0.5.2@54da3fb). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##             beta/v0.5.2    #151   +/-   ##
=============================================
  Coverage               ?   0.76%
=============================================
  Files                  ?      41
  Lines                  ?    5739
  Branches               ?    3061
=============================================
  Hits                   ?      44
  Misses                 ?    5671
  Partials               ?      24

Flag
Coverage Δ

differential
0.76% <0.00%> (?)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


💚 Fix badges in README and main page

Fixing workflow badge to point to the master branch and not forks with PR. Looking into how to do the same for codecov

Awesome, thank you @ghandic! :rocket:
I just updated the main page as well, the README is generated from it, so now tests should pass. Thanks for your contribution! :cake:

You'll be measuring the PR coverage and displaying that on the main page though. I did have a look to see if there was some filtering that could be done for that badge but couldn't see anything at a first pass.
I'll continue to look 👍🏻

We could add flags conditional of whether it is a PR or a push and then filter by that flag for the badge. I'll make another PR today to fix, that way you'll keep the codecov run for PR to check but also have the coverage % accurate on the readme
https://community.codecov.com/t/badges-for-flags/270/5

@tiangolo see PR - https://github.com/tiangolo/fastapi/pull/3982


prettier&linter issue

When a string has quoted string inside it for example
const a = "hello 'world'"
When running the linter we get
const a = 'hello \'world\''
but prettier detect an error and fix it by making
const a = "hello 'world'"
which is detected as an error for the linter
I tried playing with https://prettier.io/docs/en/options.html#quote-props but without success
Solution (hack)
replace with const a = `hello 'world'`

the hack is the recommended solution for this case

Closing as will not be resolved


Documentation: Inconsistency in ppo.py torch_deterministic parameter comment

Hi there,
I found a potential documentation issue in examples/baselines/ppo/ppo.py. There seems to be an inconsistency between the default value and the docstring for the torch_deterministic parameter:
torch_deterministic: bool = True
"""if toggled, `torch.backends.cudnn.deterministic=False`"""

The default value is set to True, but the docstring suggests it would set deterministic=False, which appears contradictory.
Could you please verify if this is indeed a documentation error and update the comment to accurately reflect the parameter's behavior?
Thank you for maintaining this great project!
Best regards

It should be left true. The speed gains with it false are very small and it's generally good to have reproducibility in RL. Happy to accept a PR to fix this


Localization loading issue

Hive no-sql database has been implemented in replace of flutter secure storage
scrolling issue is improved

raised another PR with reviewed comment fixes


Asset Etag is useless and invalid

The ETag sent back for assets (js,img,..) changes for every response making it useless.
https://github.com/gobuffalo/buffalo/blob/0ffd608c63439be1fc033ad7e48430528c96d2bc/route_mappings.go#L111-L115
This is because packd just returns the time you opened the file.
https://github.com/gobuffalo/packd/blob/128b5da43f114d0f9af8b4bba549b02e3496dfa8/file.go#L115
The ETag is also of invalid format and should be quoted as per RFC https://tools.ietf.org/html/rfc7232#section-2.3
Suggest the ETag is just removed as the info to make a sensible ETag is not avaliable and a very long max-age is already sent back.

Thanks for investigating, does that mean the ETag will change after every deploy tho?

That's a good question. I think you're right. Here is what I did to prove it:
buffalo build -o bin/app # builds the app
bin/app # starts the app

# Requesting asset
curl -s -o /dev/null -D - http://localhost:3000/assets/application.463d2be36c4e069c72b5.css
HTTP/1.1 200 OK
Accept-Ranges: bytes
Cache-Control: max-age=31536000
Content-Length: 443539
Content-Type: text/css; charset=utf-8
Etag: 16120c74bb30a368
Last-Modified: Sun, 24 May 2020 19:08:33 GMT
Date: Sun, 24 May 2020 19:08:33 GMT

buffalo build -o bin/app # builds the app
bin/app # starts the app

curl -s -o /dev/null -D - http://localhost:3000/assets/application.463d2be36c4e069c72b5.css
HTTP/1.1 200 OK
Accept-Ranges: bytes
Cache-Control: max-age=31536000
Content-Length: 443539
Content-Type: text/css; charset=utf-8
Etag: 16120c9736764ce0
Last-Modified: Sun, 24 May 2020 19:11:02 GMT
Date: Sun, 24 May 2020 19:11:02 GMT

Notice how Etag changes without any modification to the file. I think Packr is using the compilation time as the last modification time of the file.


SDK generation issue in AM 3.0.0 M35

Generated java project using the SDK feature cannot be built. It throws class not found errors.

fixed in https://github.com/wso2/carbon-apimgt/pull/7058


Changing default tagNames of Heading and Subheading tools (Add receipe book?)

Hi,
I've been struggling for a while doing something very simple in the end. I think that would be great to create a receipe book (github md) with simple hacks/common patterns.
For instance changing the heading tools default tagNames was pretty straight forward:
ContentTools.Tools.Heading.tagName = 'h2'
ContentTools.Tools.Subheading.tagName = 'h3'

But I had to dig into the source code for a while (coffee doesn't help when not used to it), tracking all the way down from Editor.init() method...
I would be glad to help/create/write the first couple of receipes. Maybe something very informal?
Receipes out of my head:

How to disable 'Enter' / return line in editable elements? – A.k.a. [data-fixtures] (I had to ask on github for this one! I dug into the code for hours trying to achieve that, in the end, it is very straight forward)
How to change default tag names of Heading tools?
How to disable tools on-the-fly? (Didn't figured out this one yet, I wanted to disable all tools when [data-fixture] element is clicked/being edited)
...

Hi @eightyfive - I agree there are a number of recurring questions that would be far better served in the form of a recipes/guides section of the website. I'll flag this as an enhancement and I'd be very happy to take submissions from pees :)
With regard to disabling tools on the fly you might find this issue helpful: https://github.com/GetmeUK/ContentTools/issues/173

Would you like me to write a raw MD document with simple recipes?
Should I contribute to this repository? Where?

By the way #173 totally did it!
My solution:
ContentEdit.Root.get().bind('focus', function (element) {
  var isFixture = element.domElement().hasAttribute('data-fixture')

  if (isFixture) {
    editor.toolbox().hide()
  } else {
    editor.toolbox().show()
  }
})

If you would like to post this as a pull request to a new top level directory in the project repo called recipes I'd be happy to accept it :+1:


add simdjson

This passes relevant CI on my fork. Please let me know if anything could be improved.

thanks.


Control node-role taint missing on nodes after cluster initialization

Rancher versions:
rancher/server or rancher/rancher: 2.0.4
rancher/agent or rancher/rancher-agent: 2.0.4
Infrastructure Stack versions:
kubernetes (if applicable): v1.10.3
Docker version: (docker version,docker info preferred)
Server:
Version:      17.03.2-ce
API version:  1.27 (minimum version 1.12)
Go version:   go1.7.5
Git commit:   f5ec1e2
Built:        Tue Jun 27 03:35:14 2017
OS/Arch:      linux/amd64
Experimental: false
Operating system and kernel: (cat /etc/os-release, uname -r preferred)
Ubuntu 16.04.5, kernel 4.4.0-131-generic
Type/provider of hosts: (VirtualBox/Bare-metal/AWS/GCE/DO)
VMWare
Setup details: (single node rancher vs. HA rancher, internal DB vs. external DB)
single node rancher
Environment Template: (Cattle/Kubernetes/Swarm/Mesos)
Kubernetes
Steps to Reproduce:

Create a Kubernetes new cluster
Get the command to add a new node with the roles "etcd" and "control"
Register 3 nodes with that command at once
Register a 4th node with just the worker role

Results:
After the cluster is initialized and all the nodes are finished, all three nodes at the etcd taint but only one had the control taint.
$ kubectl get nodes -o json | jq ' .items[].spec| {"name": .externalID, "taints": [(.taints // [])[].key]}'
{
  "name": "tst-k8s-01",
  "taints": [
    "node-role.kubernetes.io/etcd"
  ]
}
{
  "name": "tst-k8s-02",
  "taints": [
    "node-role.kubernetes.io/controlplane",
    "node-role.kubernetes.io/etcd"
  ]
}
{
  "name": "tst-k8s-03",
  "taints": [
    "node-role.kubernetes.io/etcd"
  ]
}
{
  "name": "tst-k8s-bm-01",
  "taints": []
}

rancher/rancher:master at August 3rd
I was able to test this case, and i can see both annotation present on etcd and controlplane:
> kubectl get nodes -o json | jq ' .items[]| {"name": .metadata.name, "taints": [(.spec.taints // [])[].key]}'
{
  "name": "hgalal-rk-do-worker1",
  "taints": []
}
{
  "name": "hgalal-rke-do1",
  "taints": [
    "node-role.kubernetes.io/controlplane",
    "node-role.kubernetes.io/etcd"
  ]
}
{
  "name": "hgalal-rke-do2",
  "taints": [
    "node-role.kubernetes.io/controlplane",
    "node-role.kubernetes.io/etcd"
  ]
}
{
  "name": "hgalal-rke-do3",
  "taints": [
    "node-role.kubernetes.io/controlplane",
    "node-role.kubernetes.io/etcd"
  ]
}
{
  "name": "hgalal-rke-do4",
  "taints": [
    "node-role.kubernetes.io/controlplane",
    "node-role.kubernetes.io/etcd"
  ]
}
{
  "name": "hgalal-rke-do5",
  "taints": [
    "node-role.kubernetes.io/controlplane",
    "node-role.kubernetes.io/etcd"
  ]
}


unable to launch default generated android app - ReferenceError: DEV is not defined

I'm using a default, generated app with no changes but I can't get it to launch in the emulator.  Instead I get the error ReferenceError: __DEV__ is not defined when I run react-native run-android.
sequence of events
○ → ignite new DemoApp

☕  ☕  ☕
○ → react-native run-android
/Users/tgaff/devel/reactNative/DemoApp/node_modules/react-native/Libraries/react-native/react-native.js:15
if (__DEV__) {
    ^

ReferenceError: __DEV__ is not defined
    at Object.<anonymous> (/Users/tgaff/devel/reactNative/DemoApp/node_modules/react-native/Libraries/react-native/react-native.js:15:5)
    at Module._compile (module.js:435:26)
    at Module._extensions..js (module.js:442:10)
    at Object.require.extensions.(anonymous function) [as .js] (/Users/tgaff/devel/reactNative/DemoApp/node_modules/react-native/node_modules/babel-register/lib/node.js:166:7)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:311:12)
    at Module.require (module.js:366:17)
    at require (module.js:385:17)
    at /Users/tgaff/devel/reactNative/DemoApp/node_modules/react-native/node_modules/babel-core/lib/transformation/file/options/option-manager.js:391:22
    at Array.map (native)

react-native functional in general
React-native otherwise is working fine.
I can generate apps with react-native init Bananas and then run them with react-native run-android.

Note I do have to add a local.properties file and set the sdk.dir first.  But as far as I can tell that's par for the course.

I did try adding a local.properties to the ignite app but that did not resolve the issue.

thanks for any help

Hiya! So you think it's broken or missing a feature eh?
Welllllll, it just might be.  Do me a favor and check the following.

[x] Issue does not already exist
Identify exactly what aspect your issue is about

[x] ignite base application
[ ] ignite the cli
[ ] ignite generated code

Also, for the quickest assistance please include the following version information.

node -v: v4.2.1
npm -v: 2.14.7
react-native -v (cli): 1.0.0
react-native -v: 0.28.0  (but globally installed is 0.29.1)
ignite --version: 1.3.0

Can you try heading up to node 6.x?

That seems to have worked.  I also had to generate a new app from scratch and kill the previous one's node processes.
Thanks.  Is there anything we should do to help the next user with this?

We can put a check in for the node version, during install.


[SPARK-42794][SS] Increase the lockAcquireTimeoutMs to 2 minutes for acquiring the RocksDB state store in Structure Streaming

We are seeing query failure which is caused by RocksDB acquisition failure for the retry tasks.

at t1, we shrink the cluster to only have one executor

23/03/05 22:47:21 INFO StandaloneAppClient$ClientEndpoint: Executor updated: app-20230305224215-0000/2 is now DECOMMISSIONED (worker decommissioned because of kill request from HTTP endpoint (data migration disabled))
23/03/05 22:47:21 INFO StandaloneAppClient$ClientEndpoint: Executor updated: app-20230305224215-0000/3 is now DECOMMISSIONED (worker decommissioned because of kill request from HTTP endpoint (data migration disabled))

at t1+2min, task 7 at its first attempt (i.e. task 7.0) is scheduled to the alive executor

23/03/05 22:49:58 INFO TaskSetManager: Starting task 7.0 in stage 133.0 (TID 685) (<IP_ADDRESS>, executor 0, partition 7, ANY,

It seems that task 7.0 is able to pass dataRDD.iterator(partition, ctxt) and acquires the rocksdb lock as we are seeing
23/03/05 22:51:59 WARN TaskSetManager: Lost task 4.1 in stage 133.1 (TID 700) (<IP_ADDRESS> executor 0): java.lang.IllegalStateException: StateStoreId(opId=0,partId=7,name=default): RocksDB instance could not be acquired by [ThreadId: Some(50), task: partition 7.1 in stage 133.1, TID 700] as it was not released by [ThreadId: Some(449), task: partition 7.0 in stage 133.0, TID 685] after 60003 ms.
23/03/05 22:52:59 WARN TaskSetManager: Lost task 4.2 in stage 133.1 (TID 702) (<IP_ADDRESS> executor 0): java.lang.IllegalStateException: StateStoreId(opId=0,partId=7,name=default): RocksDB instance could not be acquired by [ThreadId: Some(1495), task: partition 7.2 in stage 133.1, TID 702] as it was not released by [ThreadId: Some(449), task: partition 7.0 in stage 133.0, TID 685] after 60006 ms.
23/03/05 22:53:59 WARN TaskSetManager: Lost task 4.3 in stage 133.1 (TID 704) (<IP_ADDRESS> executor 0): java.lang.IllegalStateException: StateStoreId(opId=0,partId=7,name=default): RocksDB instance could not be acquired by [ThreadId: Some(46), task: partition 7.3 in stage 133.1, TID 704] as it was not released by [ThreadId: Some(449), task: partition 7.0 in stage 133.0, TID 685] after 60003 ms.

Increasing the lockAcquireTimeoutMs to 2 minutes such that 4 task retries will give us 8 minutes to acquire the lock and it is larger than connectionTimeout with retries (3 * 120s).
What changes were proposed in this pull request?

Increase the lockAcquireTimeoutMs to 2 minutes for acquiring the RocksDB state store in Structure Streaming
Why are the changes needed?

hanging the thread for lock acquisition rather than giving up easily
Does this PR introduce any user-facing change?

NO
How was this patch tested?

Trivial change

cc @HeartSaVioR

Thanks! Merging to master.


Ver 1.3.2 Causing Error

Going to previous version for now...
Getting this error ;
10x GS-Core\startup.lua:351: Usage: CreateMacro(name, iconFileName, body, perCharacter)
[C]: in function CreateMacro' GS-Core\startup.lua:351: in function GSregisterSequence'
GS-Core\startup.lua:367: in function `GSCheckMacroCreated'
GS-Core\Core.lua:305: in function <GS-Core\Core.lua:235>
Locals:
(*temporary) = "DB_KTN_MouseOver"
(*temporary) = nil
(*temporary) = "#showtooltip
/click DB_KTN_MouseOver"
(*temporary) = 1

I'm having an issue with this version also. when logging in with my mage I'm getting the following error.
{see attached BugGrabber.lua.zip file
GS-Core.!BugGrabber.zip
}
The gest of it is that the spec id {#64} is wrong.
On a side note {and not really an error} when doing /gs showspec, I'm only getting the Spec ID, where before I would get both the spec id (say 63 for Fire Mage) and Class id ( say 2 for Mage)

Thanks for this.  I will look into it as I level Legion. I will have a patch out in a day it so.
TimothyLuke

On 31 Aug 2016, at 12:38 AM, jfvandenbosch<EMAIL_ADDRESS>wrote:
I'm having an issue with this version also. when logging in with my mage I'm getting the following error.
{see attached BugGrabber.lua.zip file
GS-Core.!BugGrabber.zip
}
The gest of it is that the spec id {#64} is wrong.
On a side note {and not really an error} when doing /gs showspec, I'm only getting the Spec ID, where before I would get both the spec id (say 63 for Fire Mage) and Class id ( say 2 for Mage)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@jfvandenbosch The problem is in your sequence.
Your sequence should read specID=64, not specID="64",

@Comicus I cant replicate the problem you are describing.  If i open as a priest and look at that sequence it works as per normal

@jfvandenbosch I have forced specID to be converted to a number.

@camelot10 found the same error that was originally reported but I cannot replicate the problem. Is there anymore information apart from the stack trace?

Fixed the showspec part in #70

I've released this in the Beta build on Curse and the updated Translator. If there are no issues overnight the Beta will become the final version


Update job broken the past few weeks

Came to see if there was an unstable installer with a recently-merged fix for someone having install trouble and noticed it hasn't generated in a few weeks.

It looks like there haven't been Hydra evals which have all builds and test jobs succeed for a long while... (https://hydra.nixos.org/job/nix/master/tests.setuid.i686-linux/all in particular has been failing for a while) The only reason the update job fails is because it can't find any good builds anymore since the number of evals it checks is capped
I'll probably adjust the script to exclude that one failing job for now since it seems to be failing for unrelated reasons and is i686-linux, which I really don't care for anyway


\mathord

Example
\begin{gather}
\nabla\varphi\\
\mathord\nabla\varphi
\end{gather}

In Temml \mathord\nabla is italic
In LaTeX \mathord\nabla is normal

In LaTeX, the \mathord\nabla command is expected to produce a normal (non-italic) nabla symbol. However, in Temml, this symbol is being placed inside a <mi> element, which results in it being rendered in an italicized form.
I suggest place characters that are typically normal in a <mi> element with the attribute mathvariant="normal". This would ensure that the nabla symbol appears in its normal (non-italic) form, consistent with LaTeX conventions.

Example
\mathord\Delta

The result is <mi><mi mathvariant="normal">Δ</mi></mi>

In the next day or two, I will publish an update that fixes this specific problem. However, I cannot completely fix the larger issue of invalid MathML inside a <mi> element.
In LaTeX, it is possible to wrap a \mathord around an expression. Example: \mathord{\frac a b}. That doesn't make much sense, but it is possible. I can think of no way to express such a thing in MathML but to wrap the expression in an <mi> element.  The MathML spec says that is invalid, but I cannot think of any alternative.
 That is valid MathML. But for larger expressions, I think the invalid MathML is here to stay.

This instance of the invalid <mi> problem is fixed by release v0.10.22.


Typo Fixing

This PR fixes issue #1907 by changing "features" to "feature", adding a period, and adding a "to".

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

LGTM


item corrections 2 (hopefully the last one)

Actually tested(gasp) all items this time instead of assuming I got everything
+Grand Helmet
+Mystic Vest (custom mod item)
+Materia Blade
+Platinum Sword

:D I know it's a lot so it's ok if a few pop up every now and then. Thanks for taking the time to dig into this!


Add min/max props to the TextInput and NumberInput components

Fixes #124 by providing min and max props to the NumberInput component and by setting is type to number.

Désolé, c'est prettier :innocent:


PHP Fatal error:  Uncaught exception 'ReflectionException' with message 'Class App\Http\Kernel does not exist'

Hi,
If I changed Laravel root namespace like php artisan app:name "Passport"
Then composer.json
{
"autoload": {
    "classmap": [
      "database"
    ],
    "psr-4": {
      "Passport\\": "app/"
    }
  }
}

But, there is hard code in file Base.php line 208
$app->singleton(
    \Illuminate\Contracts\Http\Kernel::class,
    \App\Http\Kernel::class
);

$app->singleton(
    \Illuminate\Contracts\Console\Kernel::class,
    \App\Console\Kernel::class
);

$app->singleton(
    \Illuminate\Contracts\Debug\ExceptionHandler::class,
    \App\Exceptions\Handler::class
);

Maybe we can make a config for root namespace

PR #21

Release 0.2.5 is not corret without code of commit PR #21.

0.2.5 only fix the config error, and due to I am working on a new fastcgi processer, 0.2.6 will be released later.
By now, you can use dev-master to get lateset code.


Add Procfile worker

This worker process will be used by GOV.UK Puppet when it spins up a worker to transform data.

The tests are failing on this, and are also failing on master when I rebuilt master - https://travis-ci.org/alphagov/backdrop/builds/60353517
Briefly looking at the test, I suspect an issue with dates, but not looked into in great detail yet

Do we still need this? If so, I'm happy to rebase it against master, which is passing again.

Yep, thanks for the prompt! I've rebased against master and it's working now.

:+1:


Payment page for customers

Add a server-hosted payment page with instructions for the lightning payment that e-commerce stores can redirect customers to (similarly to how the checkout process with PayPal and other payment providers works), as an alternative to embedding the payment directly into the store.

Added by 3ea9bc57f97793cb3df18c5344e723dfd1c3256f.


lightGlue

HELLO . Have you considered making public the training code for xeat+lightglue/lighterglue?

Hi @Xiaole-An, thanks for the interest!
I simply used the nice GlueFactory lib out of the box, you just need to change the hyperparams, as defined in the "lighter" version of LightGlue here -- if you want to make it faster and more lightweight.  Then you can simply use XFeat as detector & extractor, for that you just replace the ALIKED example with XFeat model.


Remove colons from example headings

Related to #1564 and ToC generation.

A colonoscopy, if you will?


Security review notes for followup

Hi @blt, as requested I'm including security review notes here. (I'm not particularly Rust-savvy at the moment, so some of this may not be interesting in reality.) PTAL and assess if there's anything worth following up on.

Good to see fuzzing in place, though I’m only just now learning about memory safety w.r.t. Rust.  Looks like Rust is only unsafe in places explicitly marked as unsafe, but I don’t see this in the code.  Any further context on the fuzzing would be interesting to hear about.

@randomdross please see comment on https://github.com/postmates/hopper/issues/22


Remove Ant Commander Personal version 4.6

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Removed Ant Commander Personal version 4.6 as latest version is 4.10
Microsoft Reviewers: Open in CodeFlow

URL: https://www.antcommander.com/personal/versions/AntCommander-4.6.exe
OK
(Automated message - build 882)


Feature Request | Multiple strings

I'd love it if you included the option to have multiple different strings that could be highlighted separately. That way, I could get notifications for messages that say both my IRL name and my in-game alias.

033def628382dc52f5834acf5658ff5c55171f7e adds support for comma-separated values when in non-regex mode


Speeding up multiple cel_bulirsch calculations with same k_c.

One of the more expensive parts of cel_bulirsch(k_c,p,a,b) is the square-root operation, \nu_{i+1} = 2\sqrt{\nu_i \mu_i}, that is performed for each iteration.   It turns out that the terms involved in the square-root only depend on k_c, but not on p, a, or b.  So, when computing s_2, when we evaluate the necessary three elliptic integrals, we can save computing time by computing all three of these at once, and then we will only need to do the square roots 1/3 as much of the time!
It turns out that division is almost as expensive as square-root;  these are both about 10x the expense of addition or multiplication.  https://github.com/eschnett/AutoBenchmark.jl
There are two */p terms in cel which could be combined to be optimized.   All to say, these elliptic integrals may be faster to evaluate together rather than alone.  I will write a method that works with vector a, b, and p values.

Interesting! I'd love to use this to speed up starry as well.

This has been implemented, and it did in fact speed up the elliptic integral computation.


Fix column guessing when translations enabled

WHY
BEFORE - What was wrong? What was happening before this PR?
Columns that are "translatable" are automatically casted to array in the model making the guessing functionality think that we are going to display an array.
AFTER - What is happening after this PR?
The guessing functionality is now aware of this possibility and will use the "old" set to text and return the column method without trying to infer the column type.
HOW
How did you achieve that, in technical terms?
Checking if translations are enabled for the model and also check if the column name exists in this translations property.
Is it a breaking change or non-breaking change?
Non.
How can we test the before & after?
See #4040 . Just visit product page on demo.

A new inspection was created.

The inspection completed: 544 Issues, 80 Patches

Works like a charm! Good job @pxpm , merged into 4.2.

Works like a charm! Good job @pxpm , merged into 4.2.