Change element type

Hello,
This is a Pull Request, as discussed in Issue #694 ([Feature Request] Change element type).
This issue has been closed a being covered by #663, but it is not, as this last one is about relationship, whereas the #694 is about element type.
I may not reopen it.
In this PR:

A "Refactor" menu is added into the diagram context menu, and in the Tree View menu. They have been developped based on the other existing actions/commands. In particular, based on the Delete action of the Tree View menu.
This "Refactor" menu contains submenu, one per element type (Business, Application...). Each of these submenus contain the items of this type.
The Undo and Redo works for both
There is no control on the existing relationship for this element. As a consequence, and to be fully operationnal, the #663 issue should be also implemented. This would allow to change relationship's type, when a relationship becomes "illegal" based on the new element type.

I can work on the #663 implementation. But I'll start that only if you think you'll accept these two PR.

The job is done by creating an ArchimateElement of the good type, copying into it the id, name, description and properties from the source one. The replacing the element in all DiagramModelArchimateObject that contain the old one. The new element is created in the same folder (if the element is of the same type), or in the root of the folder's type otherwise

A JUnit test checks that the old instance doesn't exist any more in the model

A tricky and sensitive part is the ability to create an instance of an element type, based on its name, by using Java reflection. It's not very difficult, but it will fail if a name is changed. So a JUnit test checks that instance creation works for every element type.
It's of course possible to change the type for several elements in the same operation (multiple selections)
JUnit tests have been added and integrated in the existing test suites. They check the execute, undo and redo actions. And I confirm the good integration in the whole maven build, as I checked that with a failing test.
The last commit from the archi master has been merged

Changed after the command from the previous and now closed PR (699):

Element instances are now created by the IArchimateFactory, instead of Java reflection
Features are now copied from the source element to the target one, that is for execution, undo and redo. No change on diagram objects, as these objects are unchanged (only its archimate element is set)
About storing the color: I had the same think as you. So this the code works, but is currently deactivated, thanks to the CHANGE_COLOR_TO_DEFAULT_IF_ELEMENT_TYPE_CHANGES constant set to false.
Added the icons for each element type, in the context and tree menu
I didn't remove the .ignore file.  Why do you want to remove it? (perhaps you have your own ignore file, but it is not commited in git)

NB:

Thanks to your documentation (very clear), I was able to implement and execute JUnit tests, and embed them in the whole build. I check this, as a change in my code has made the JUnit test to fail. And I was happy to double-check it, before raising an issue on them, as this issue was mine ;)
I also was able to build a Product, and I use it now for my own Archimate work.

Etienne

Thanks for this draft PR.
Looking at ChangeElementTypeCommand:
I don't think I would implement it this way. Normally in a Command the state of all affected objects is stored before calling Execute so that Undo can roll back to those objects in that state. Your implementation does things differently by performing another Execute when Undo is called.
This means that you have to store the elementId to get the original object and also the model in order to call ArchimateModelUtils.getObjectByID().
(Also, I don't think you should use a class ArchimateObjectModelProperties to store state, and no need to store the colour.)
I think if I were to do this it would be more in line with the jArchi implementation which restores the previous objects on Undo rather than creating new objects each time.

Thanks for this draft PR.
Looking at ChangeElementTypeCommand:
I don't think I would implement it this way. Normally in a Command the state of all affected objects is stored before calling Execute so that Undo can roll back to those objects in that state. Your implementation does things differently by performing another Execute when Undo is called.
This means that you have to store the elementId to get the original object and also the model in order to call ArchimateModelUtils.getObjectByID().
(Also, I don't think you should use a class ArchimateObjectModelProperties to store state, and no need to store the colour.)
I think if I were to do this it would be more in line with the jArchi implementation which restores the previous objects on Undo rather than creating new objects each time.

I didn't remove the .ignore file.  Why do you want to remove it? (perhaps you have your own ignore file, but it is not commited in git)

Your .gitignore for the root of all projects is:
#Ignore build files, in all subfolders
bin/
icons/
target/

**/.project
**/*.jar
**/*.log

.project and .jar files should not be ignored as these are part of each project. bin is already in each project's .gitignore file. Perhaps you are using a maven build? When I do a maven build I run a script that copies the source to a new folder then builds in that folder so I don't mess my source folder with target folders. But it's up to you, it just means that I can't merge any commit with it in,

I didn't remove the .ignore file.  Why do you want to remove it? (perhaps you have your own ignore file, but it is not commited in git)

Your .gitignore for the root of all projects is:
#Ignore build files, in all subfolders
bin/
icons/
target/

**/.project
**/*.jar
**/*.log

.project and .jar files should not be ignored as these are part of each project. bin is already in each project's .gitignore file. Perhaps you are using a maven build? When I do a maven build I run a script that copies the source to a new folder then builds in that folder so I don't mess my source folder with target folders. But it's up to you, it just means that I can't merge any commit with it in,

I think if I were to do this it would be more in line with the jArchi implementation which restores the previous objects on Undo rather than creating new objects each time.

I agree, that's even mandatory to keep ids, or else this is not a real undo as we expect and undo to come back to the exact previous state.
For the sake of simplicity ,here is a copy of what I wrote in #694

Might be worth looking at this issue for a reminder of previous discussions about it.
So again, here are the key points, based on the implementation done in my jArchi scripts set:

User should first decide what to do with invalid relationships. Only two options here: abort or convert to associations (and then keep track of previous type in a comment added into the documentation attribute).
If 'abort', then the whole operation should succeed only if all elements can be converted. This means that as soon as converting one element leads to unvalid relationship, we should roll-back the whole operation.
The new feature should be able to also change type of relationships. But this adds additional checks (junctions)
The "new" concept should have a new id and not reuse the old one as this is no more the same concept (this is to avoid side effects on model import feature, coArchi...)

Btw, "refactor" is not really a good menu name (sounds too technical to me). A simple "Change type..." menu with per layer sub-menus seems better.

In addition, there is something which can't be implemented in jArchi but can in a native implementation: when converting multiple concepts in a single operation, intermediate states might be invalid while the target state is valid. In jArchi, this leads to (temporarily) invalid relationships to be converted to association.
For example, take a Business Object A which is composed by another Business Object B. If I select A and B and want to convert them to Data Objects, I should get Data Object A is composed by Data Object B, because composition is allowed between two Data Objects. In the jArchi implementation, because I first convert A, I have an intermediate state in which A is a Data Object and B is still a Business Object. This is invalid, thus I am forced to first convert the composition to association.
What we should do in a native implementation is to first convert all elements, an only after, convert invalid relationship to association.

I think if I were to do this it would be more in line with the jArchi implementation which restores the previous objects on Undo rather than creating new objects each time.

I agree, that's even mandatory to keep ids, or else this is not a real undo as we expect and undo to come back to the exact previous state.
For the sake of simplicity ,here is a copy of what I wrote in #694

Might be worth looking at this issue for a reminder of previous discussions about it.
So again, here are the key points, based on the implementation done in my jArchi scripts set:

User should first decide what to do with invalid relationships. Only two options here: abort or convert to associations (and then keep track of previous type in a comment added into the documentation attribute).
If 'abort', then the whole operation should succeed only if all elements can be converted. This means that as soon as converting one element leads to unvalid relationship, we should roll-back the whole operation.
The new feature should be able to also change type of relationships. But this adds additional checks (junctions)
The "new" concept should have a new id and not reuse the old one as this is no more the same concept (this is to avoid side effects on model import feature, coArchi...)

Btw, "refactor" is not really a good menu name (sounds too technical to me). A simple "Change type..." menu with per layer sub-menus seems better.

In addition, there is something which can't be implemented in jArchi but can in a native implementation: when converting multiple concepts in a single operation, intermediate states might be invalid while the target state is valid. In jArchi, this leads to (temporarily) invalid relationships to be converted to association.
For example, take a Business Object A which is composed by another Business Object B. If I select A and B and want to convert them to Data Objects, I should get Data Object A is composed by Data Object B, because composition is allowed between two Data Objects. In the jArchi implementation, because I first convert A, I have an intermediate state in which A is a Data Object and B is still a Business Object. This is invalid, thus I am forced to first convert the composition to association.
What we should do in a native implementation is to first convert all elements, an only after, convert invalid relationship to association.

Thanks for this review!
I respond point by point hereafter
Etienne

Thanks for this review!
I respond point by point hereafter
Etienne

Perhaps you are using a maven build? When I do a maven build I run a script that copies the source to a new folder then builds in that folder so I don't mess my source folder with target folders. But it's up to you, it just means that I can't merge any commit with it in,

Yes, I'm using a maven build.
I don't understand why you don't want this ignore files: it doesn't hurt, and it protects git from containing files that should not be there.
But it's up to you, of course.
I removed it.

Perhaps you are using a maven build? When I do a maven build I run a script that copies the source to a new folder then builds in that folder so I don't mess my source folder with target folders. But it's up to you, it just means that I can't merge any commit with it in,

Yes, I'm using a maven build.
I don't understand why you don't want this ignore files: it doesn't hurt, and it protects git from containing files that should not be there.
But it's up to you, of course.
I removed it.

Thanks for this draft PR.
Looking at ChangeElementTypeCommand:
I don't think I would implement it this way. Normally in a Command the state of all affected objects is stored before calling Execute so that Undo can roll back to those objects in that state. Your implementation does things differently by performing another Execute when Undo is called.
This means that you have to store the elementId to get the original object and also the model in order to call ArchimateModelUtils.getObjectByID().
(Also, I don't think you should use a class ArchimateObjectModelProperties to store state, and no need to store the colour.)
I think if I were to do this it would be more in line with the jArchi implementation which restores the previous objects on Undo rather than creating new objects each time.

Yes, that's right. Currently, I store the id. This allows the execute/undo/redo in an easy way, as all executions are identical.
But I need to call getObjectByID, which browse through the model.
So your idea make the code a little quicker and a little more complex, I think.
I'll give it a try.
Etienne

Thanks for this draft PR.
Looking at ChangeElementTypeCommand:
I don't think I would implement it this way. Normally in a Command the state of all affected objects is stored before calling Execute so that Undo can roll back to those objects in that state. Your implementation does things differently by performing another Execute when Undo is called.
This means that you have to store the elementId to get the original object and also the model in order to call ArchimateModelUtils.getObjectByID().
(Also, I don't think you should use a class ArchimateObjectModelProperties to store state, and no need to store the colour.)
I think if I were to do this it would be more in line with the jArchi implementation which restores the previous objects on Undo rather than creating new objects each time.

Yes, that's right. Currently, I store the id. This allows the execute/undo/redo in an easy way, as all executions are identical.
But I need to call getObjectByID, which browse through the model.
So your idea make the code a little quicker and a little more complex, I think.
I'll give it a try.
Etienne

jbsarrodie wrote:

User should first decide what to do with invalid relationships. Only two options here: abort or convert to associations (and then keep track of previous type in a comment added into the documentation attribute).

Hum, I only partially agree with this one.
There is a third choice, which is the current one: let the association be invalid.
I see several reasons for that. Ok, they are not all very very good. But once grouped, it makes some sense. And also see after, what I propose.

It makes the functionality more complex to use. How to manage this, when several items are selected, of several types
It makes the code really more complex than it is now. Or perhaps there is already a portion of code the defines the valid relati
without this PR, I still need to change some objects. And (I'm sorry for that) I won't use jArchi. It's too complex to learn how to install it, learn a new language, a new API. So I would export the model data, change the element's type, then reimport.
It may also happen that the relationship is that bad: perhaps the user will change other element's type, just after, making the relationship be correct again
There still is a validator, that allows to check valid and invalid relationship.

So an idea would be to:

Let it be simple, to start with, that is: let this PR as is.
Develop the #663 (UI for changing relation type). I can work on this one, but I must finish some work on my other open source project.
Allow a Right Click on the Validator view, to allow quick correction of wrong relationships. This would be done in the #663 implementation. Perhaps a warning message could lead to the display of this view

This would be partial implementation, but will add two important features into archi.
What do you think ?
Etienne

jbsarrodie wrote:

User should first decide what to do with invalid relationships. Only two options here: abort or convert to associations (and then keep track of previous type in a comment added into the documentation attribute).

Hum, I only partially agree with this one.
There is a third choice, which is the current one: let the association be invalid.
I see several reasons for that. Ok, they are not all very very good. But once grouped, it makes some sense. And also see after, what I propose.

It makes the functionality more complex to use. How to manage this, when several items are selected, of several types
It makes the code really more complex than it is now. Or perhaps there is already a portion of code the defines the valid relati
without this PR, I still need to change some objects. And (I'm sorry for that) I won't use jArchi. It's too complex to learn how to install it, learn a new language, a new API. So I would export the model data, change the element's type, then reimport.
It may also happen that the relationship is that bad: perhaps the user will change other element's type, just after, making the relationship be correct again
There still is a validator, that allows to check valid and invalid relationship.

So an idea would be to:

Let it be simple, to start with, that is: let this PR as is.
Develop the #663 (UI for changing relation type). I can work on this one, but I must finish some work on my other open source project.
Allow a Right Click on the Validator view, to allow quick correction of wrong relationships. This would be done in the #663 implementation. Perhaps a warning message could lead to the display of this view

This would be partial implementation, but will add two important features into archi.
What do you think ?
Etienne

A quick comment on this one:

Allow a Right Click on the Validator view, to allow quick correction of wrong relationships.

I don't want to add this kind of functionality to the Validator. I prefer to keep the Validator as it is now, just reporting the issues rather than turning it into a fix-it thing. :-)

A quick comment on this one:

Allow a Right Click on the Validator view, to allow quick correction of wrong relationships.

I don't want to add this kind of functionality to the Validator. I prefer to keep the Validator as it is now, just reporting the issues rather than turning it into a fix-it thing. :-)

There is a third choice, which is the current one: let the association be invalid.

Absolutely not: Archi, as an an ArchiMate modelling tool can't include invalid relationships. Period.

It makes the functionality more complex to use. How to manage this, when several items are selected, of several types

It's just a matter of asking the user what to do once: either rollback if the target state is invalid, or convert to association. That's how the current script work and this has proven to be a good approach.

It makes the code really more complex than it is now.

Nobody said this PR was easy. Why do you think we didn't implement it knowing that a working and easy solution exist in jArchi.

without this PR, I still need to change some objects.

Not our problem but yours

And (I'm sorry for that) I won't use jArchi. It's too complex to learn how to install it, learn a new language, a new API.

Come on. It's only a matter of installing the plugin through the plugin manager and copying a script which already exist.

There still is a validator, that allows to check valid and invalid relationship.

This is only meant to be used to discover some issues related to manual edits, or model screwed by external plugins. That's not a argument to purposefully create invalid models.

So an idea would be to:

Let it be simple, to start with, that is: let this PR as is.
What do you think ?

You don't seem to understand what a good product is. That's absolute non sens to propose a PR which doesn't address all this. It seems to me that you in fact just want to adresse your own issue without actually contributing to Archi. As we first explained with Phil, contributing implies lots of things, including to first agree on the feature scope.
@Phillipus I'm afraid we'll loose energy an time if there is not a clear commitment to work on the whole feature, at least on par with the jArchi implementation done in my script set. FWIW, this is not an urgent feature...

There is a third choice, which is the current one: let the association be invalid.

Absolutely not: Archi, as an an ArchiMate modelling tool can't include invalid relationships. Period.

It makes the functionality more complex to use. How to manage this, when several items are selected, of several types

It's just a matter of asking the user what to do once: either rollback if the target state is invalid, or convert to association. That's how the current script work and this has proven to be a good approach.

It makes the code really more complex than it is now.

Nobody said this PR was easy. Why do you think we didn't implement it knowing that a working and easy solution exist in jArchi.

without this PR, I still need to change some objects.

Not our problem but yours

And (I'm sorry for that) I won't use jArchi. It's too complex to learn how to install it, learn a new language, a new API.

Come on. It's only a matter of installing the plugin through the plugin manager and copying a script which already exist.

There still is a validator, that allows to check valid and invalid relationship.

This is only meant to be used to discover some issues related to manual edits, or model screwed by external plugins. That's not a argument to purposefully create invalid models.

So an idea would be to:

Let it be simple, to start with, that is: let this PR as is.
What do you think ?

You don't seem to understand what a good product is. That's absolute non sens to propose a PR which doesn't address all this. It seems to me that you in fact just want to adresse your own issue without actually contributing to Archi. As we first explained with Phil, contributing implies lots of things, including to first agree on the feature scope.
@Phillipus I'm afraid we'll loose energy an time if there is not a clear commitment to work on the whole feature, at least on par with the jArchi implementation done in my script set. FWIW, this is not an urgent feature...

Hum,
I feel that you're disappointed there. I'm sorry for that.
Please note that I was just presenting ideas.
About jArchi : please also not that I'm not the only one to think like this.
For instance, stefankroes did the same comment, in the #265 issue: https://github.com/archimatetool/archi/issues/265#issuecomment-537808993
About "this is not an urgent feature".
Yes of course: archi is an excellent tool.
But please note that, as it's a free tool, lots of beginners start with it. This allows to test ArchiMate. It was the case for me, and for lots of other architects around me. And beginners do beginner's errors, like creating a BusinessActor instead of a BusinessRole, for instance. So, IMHO, the capacity to correct this kind of error is important for such a free tool. It's a driver powerful enough to pay a for a licence.
To sum up: I'll work on this PR, in order to respect the requirements you defined, here above
Like stated before, I also work on another open source project.
So I'll be back in some weeks, I guess.
Etienne

Hum,
I feel that you're disappointed there. I'm sorry for that.
Please note that I was just presenting ideas.
About jArchi : please also not that I'm not the only one to think like this.
For instance, stefankroes did the same comment, in the #265 issue: https://github.com/archimatetool/archi/issues/265#issuecomment-537808993
About "this is not an urgent feature".
Yes of course: archi is an excellent tool.
But please note that, as it's a free tool, lots of beginners start with it. This allows to test ArchiMate. It was the case for me, and for lots of other architects around me. And beginners do beginner's errors, like creating a BusinessActor instead of a BusinessRole, for instance. So, IMHO, the capacity to correct this kind of error is important for such a free tool. It's a driver powerful enough to pay a for a licence.
To sum up: I'll work on this PR, in order to respect the requirements you defined, here above
Like stated before, I also work on another open source project.
So I'll be back in some weeks, I guess.
Etienne

I feel that you're disappointed there. I'm sorry for that.

Yes, I was.

Please note that I was just presenting ideas.

The way I read it was: "I need this feature and don't care about how it fits in Archi, so I won't do more"

About jArchi : please also not that I'm not the only one to think like this.
For instance, stefankroes did the same comment, in the #265 issue: #265 (comment)

His comment was mostly based on "jArchi is not publicly available at this point.", while it was. The thing is that people don't even read what's written on the plugins page. I can imagine that not everyone wants to setup eclipse and compile the plugin, but in this case there's the donation route, and frankly, if someone is not able to give 1$ to get a plugin and install a community contributed script, then that's simply not our target user and he/she should buy a commercial tool with 2000€/day consultant and some support.
That being said, @Phillipus I think we should update the list of provided scripts in the binary version to include my script pack. This would be one less step for those who get the plugin through paypal one time donation or patreon.

About "this is not an urgent feature".
Yes of course: archi is an excellent tool.
But please note that, as it's a free tool, lots of beginners start with it. This allows to test ArchiMate. It was the case for me, and for lots of other architects around me. And beginners do beginner's errors, like creating a BusinessActor instead of a BusinessRole, for instance. So, IMHO, the capacity to correct this kind of error is important for such a free tool.

I know, but this is already covered by a jArchi script and there are more urgent features. Remember that only Phil and (a bit of) me work on Archi.

It's a driver powerful enough to pay a for a licence.

So it's a driver powerful enough to donate 1$ for jArchi.

To sum up: I'll work on this PR, in order to respect the requirements you defined, here above

Great. Let's be clear, my goal is not to push you out, only to make it clear that any new feature in Archi must be first discussed as a whole before even thinking about code. That's only when we are all clear on the feature that we can all move on. It seems we are now aligned and that's good.

So I'll be back in some weeks, I guess.

In the mean time I'll clarify even more the behavior I have in mind so we can all agree on it or tune it if needed.

I feel that you're disappointed there. I'm sorry for that.

Yes, I was.

Please note that I was just presenting ideas.

The way I read it was: "I need this feature and don't care about how it fits in Archi, so I won't do more"

About jArchi : please also not that I'm not the only one to think like this.
For instance, stefankroes did the same comment, in the #265 issue: #265 (comment)

His comment was mostly based on "jArchi is not publicly available at this point.", while it was. The thing is that people don't even read what's written on the plugins page. I can imagine that not everyone wants to setup eclipse and compile the plugin, but in this case there's the donation route, and frankly, if someone is not able to give 1$ to get a plugin and install a community contributed script, then that's simply not our target user and he/she should buy a commercial tool with 2000€/day consultant and some support.
That being said, @Phillipus I think we should update the list of provided scripts in the binary version to include my script pack. This would be one less step for those who get the plugin through paypal one time donation or patreon.

About "this is not an urgent feature".
Yes of course: archi is an excellent tool.
But please note that, as it's a free tool, lots of beginners start with it. This allows to test ArchiMate. It was the case for me, and for lots of other architects around me. And beginners do beginner's errors, like creating a BusinessActor instead of a BusinessRole, for instance. So, IMHO, the capacity to correct this kind of error is important for such a free tool.

I know, but this is already covered by a jArchi script and there are more urgent features. Remember that only Phil and (a bit of) me work on Archi.

It's a driver powerful enough to pay a for a licence.

So it's a driver powerful enough to donate 1$ for jArchi.

To sum up: I'll work on this PR, in order to respect the requirements you defined, here above

Great. Let's be clear, my goal is not to push you out, only to make it clear that any new feature in Archi must be first discussed as a whole before even thinking about code. That's only when we are all clear on the feature that we can all move on. It seems we are now aligned and that's good.

So I'll be back in some weeks, I guess.

In the mean time I'll clarify even more the behavior I have in mind so we can all agree on it or tune it if needed.

Thanks for your reponse, Jean-Baptiste

Thanks for your reponse, Jean-Baptiste

When it comes to arguing about paying a $1 for a plug-in it's time to move on...
Closed.

This is in Archi 5.1 beta.


(followup to old bug report)  clientcert never initialized (IDFGH-6652)

See https://github.com/espressif/esp-idf/issues/7479 .
That solution is now in esp-idf-v4.4-rc1, thanks.
Suggestion to not only call user_cb at session creation but also from httpd_ssl_close to assist the application in managing its own state. (If the application does more than just cope with short sessions, then managing long ones is hard without this additional call to assist in cleanup.)

I can see several ways of doing that. The fundamental problem is that you can't pass much info (one parameter) into httpd_ssl_close, and information is scattered (the https_server uses leftover fields in httpd sess_db to store its stuff). Lookups in the sess_db require two parameters, not one.
Solution 1 is to allocate another structure to pass to httpd_ssl_close, with all the desired fields. That's a workaround for the problem above, and would not touch httpd_server coding.
Solution 2 could be to expose sess_db to https_server. Then it would be able to grab the global_ctx and call user_db from there.
I'm sure there are other ways. I can code a sample if you tell me how.

Here is a sample implementation based on my suggestion #1 above
d.txt
.


.XLSM files restricted

Thank you so much for this plugin! It's such a huge help.
I'm posting this here as it seems the original trac ticket is closed (https://core.trac.wordpress.org/ticket/39963).
We can upload almost all of our files again, but  have found one file type that is still triggering the security error: .xlsm files.

FILE
WORDPRESS:
    name:        survey_results.xlsm
    type:        application/vnd.ms-excel.sheet.macroEnabled.12
    ext:         xlsm
FILEINFO:
    type:        application/zip
    ext/type:    FALSE
BLOB-MIMES:
    name:
    type:        FALSE
    ext:         FALSE
    ext/type:    FALSE

=======
Just wanted to let you know.

Thanks for the report! Real world feedback is really helpful in this cat-and-mouse game, particularly for MS Office files, which are crazy wiggly. On the one hand it speaks to Microsoft's credit that their formats are so flexible, but on the other, wow, probably could just pick a standard or two. Haha.
I assume you're running version 0.5.0 of the WP plugin  Lord of the Files (i.e. what spun off from #39963)?
If so, would you mind swapping the aliases.php file with this fresh one from Git? Then give that XLSM file another shot and see if it uploads?
If it does, let me know and I'll push the MIME DB update to the WP plugin.

So, I was actually using version 0.1.3 (you're moving fast with development!).
Unfortunately, our server is on php 5.3. We're actually upgrading servers and will have php 7, but not for another month.
We do have a test server with php 7 setup so let me sync things over there and test it; may take a day or two to get back to you.

I did manage to get version 0.1.3 working by adding this to the media-mimes.php file:
	'xlsm' => array(
		'application/vnd.ms-excel.sheet.macroenabled.12',
		'application/vnd.ms-office',
		'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet',
		'application/zip',
	),

Thank you so much! And sorry about the requirement bump!
The plugin was originally just a wrapper for the proposed Core patches from #39963, a stopgap so users could fix their sites without having to wait an indeterminate (but surely long) amount of time for an official fix to land.
Ultimately WordPress didn't feel that the security enhancements were necessary and so the bug fix was thrown out with the bathwater. Haha. I didn't want to leave it there, though, and so decided to repurpose the plugin as a more general and permanent upload-related security tool. A few items on the wishlist required a minimum of PHP 5.4 to do well, so rather than leave some operations disabled or weakened for some people (which could lead to a false sense of safety), I opted to just raise the baseline up a little.
Hopefully that doesn't cause you too much grief before your migration to PHP 7. And thanks again for the feedback.

I just did a little testing on our updated server and the first thing I tried was uploading an xlsm file without Lord of the Files enabled. Figured it would be best to try it without it on first.
Looks like our new environment doesn't have the same problem and the file uploaded fine. Not sure if it's the newer version of php or something else. Not sure I can test this all that well for you since it's working without the plugin.

Thanks for trying, but no worries. "Inconsistency" is the name of the game. Haha.
The type information returned by the fileinfo.so PHP extension will vary based on the operating system, PHP version, library version, and various system configurations. To make things crazier, some file formats (like XLS) allow for multiple internal structures, many of which end up with different MIME type responses even from a single server.
What blob-mimes actually does is maintain a massive database of MIME history so that it can answer simple questions like, "Does it make sense that file.xxx is believed to be application/whatever?"
Lord of the Files brings this database to WordPress so that inconsistent server responses can be mapped to the singular whitelist the CMS uses to accept or reject file uploads. Otherwise if WordPress thinks a WOFF is font/x-woff and PHP thinks it is application/font-woff (both common associations at one point, neither correct today), the upload would fail.


Simplify commandline arguments code

I can't checkout the commit a the moment but I take that IOTest is passing?

Thanks, it's cool to see that it can be simplified by that much :)


Mark slow tests, update __eq__ methods, pin reqs

Summary of changes:

Add --skip-slow option (slow tests are still run by default)
Mark various tests as slow based on run time as captured by pytest --durations=0
Pin numpy<1.20 on MacOS due to test failures
Add feature to Geometry class __eq__ method that if other object is a container, the equality method on the container is called, so now performing an equality check between a geometry object and a geometry array should return correct results, which should be a bool array, whereas previously it would simply return False because the objects were not the same immediate type.
Add feature to GeometryArray class __eq__ method to allow comparison of an individual element to all objects in the array, returning an array of bool.
Add NotImplementedError for __contains__ method.
Sort imports on modified files
Add some type hints to parquet functions

Let me know if there are any questions or concerns about any of these changes.

In addition to the changes above, Dask has now been pinned on Mac due to incompatibilities with pyarrow>=2.
Also, I updated the change log for the next release.
@jbednar, thanks for your time reviewing and your input.  Let me know if you have any additional questions or concerns.
I think this should be ready to merge.


ci: add create cluster stage to cilium scale test pipeline

Reason for Change:

Adds stage to create a cluster in Cilium scale test pipeline and allows to specify resource group name separately from cluster name.
Issue Fixed:

Requirements:

[X] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] relevant PR labels added

Notes:

/azp run Azure Container Networking PR


busy p...

If two separate AT commands are sent simultaneously, it will reply "busy p...".
For example, I opened one socket and while it is processing it, I send request to open another socket
at 20:07:22.410 -> AT+CIPSTART=3,"TCP","<IP_ADDRESS>",5002
Log:
20:07:18.802 -> AT+CIPSTART=2,"TCP","<IP_ADDRESS>",5000
20:07:22.435 ->
20:07:22.435 -> busy p...
20:07:27.898 ->
20:07:27.898 -> ERROR
This is a major issue when we have to wait for Ping and we need to send data on socket.

@ravdeepboparai esp-at commands are serial

Yes, all AT engines are serial but they have Async and sync pair of commands.
The commands starting with "+" are considered as Async replies, while OK and ERROR commands are considered as Sync.
For example, if I send a ping command with a timeout of 10 seconds, and I will be blocked to send data on an already opened socket for 10 seconds.
Do I am missing some configuration in which I will be allowed to send data while ping is waiting for a reply?

This is something similar to https://github.com/espressif/esp-idf/issues/1271#issuecomment-352313549
In which a Host queue was implemented but still for a particular case, here in AT engine the response to the commands which goes over the internet should not block the commands to the device itself. This affects the purpose of the multicore, multithreaded environment of ESP32.

To be honest, i am sorry that i do not know what you need


Remove first class IServiceProvider properties

We should remove:

IApplicationBuilder.ApplicationServices
HttpContext.ApplicationServices
HttpContext.RequestServices

We should make the providers available via HttpContext.Items with specific keys. Reason being that only framework pieces need access to the service provider so that we can pick composition roots for user code to plug into. This will encourage us to make those points more obvious and help clean up some of our own code.

/cc @Tratcher @muratg @Eilon @lodejard

This is going to wreck action results

This shouldn't go in Items, it should remain a Feature. You can drop the HttpContext properties and access it via GetFeature instead.

@Tratcher sure

IApplicationBuilder.ApplicationServices is used frequently.
HttpContext.ApplicationServices is only referenced once outside of tests:
https://github.com/aspnet/Diagnostics/blob/3fa5dee2d7f377d57e75fbb0d328cd26b6ff093a/src/Microsoft.AspNet.Diagnostics/Views/BaseView.cs#L56
HttpContext.RequestServices is used very frequently, especially in MVC.

httpContext.GetFeature<IServiceProvidersFeature>().RequestServices


⚠ Bofrost.com has degraded performance

In 3f74d34, Bofrost.com (https://www.bofrost.com) experienced degraded performance:

HTTP code: 200
Response time: 1501 ms

Resolved: Bofrost.com performance has improved in eecc839 after 6 minutes.


Do you have a paper to introduce this network?

Hello, I want to know, have you published corresponding articles on your project? I want to read it to help you understand the project. thanks

No, this just a simple modification of existing work out there. Please refer to the SRGAN paper to understand what's happening here. The only difference here is that I'm using a smaller neural network to make it faster.


Using sfdx sfpowerscripts:package:data:install to recognize back slash in VlocityComponents.yaml

Describe the bug
sfpowerscripts:package:data:install won't install vlocity data packs as it recognizes back slash as an escape character when projectPath is inputted with back slash in VlocityComponents.yaml
To Reproduce
set projectPath in VlocityComponents.yaml same as below.. assuming vlocity data packs is already in the folder.
projectPath: src\vlocity-config
Expected behavior
If it can be recognized as part of the path and not an escape character.
Screenshots

Additional context
Some devs do not know the difference of forward slash and back slash when commands are being executed on linux distro.

Will be addressed as #633  goes fully live

Handled in #633


Parse errors in FO formulas don't generate helpful error messages

When a malformed FO formula is part of a definition of an SFT, the error message basically states "expecting a quantified formula" and points to the beginning of the formula.

Fixed in cafae0d


If the WhenExpression of the task is evaluated to false immediately after the pipelinerun is started, the pipelinerun stays in "Running(Started)" state

Expected Behavior
The Pipelinerun should start and run successfully
Actual Behavior
If the WhenExpression of the task is evaluated to false immediately after the pipelinerun is started, the pipelinerun stays in "Running(Started)" state for a pipeline which has sequential tasks (tasks which run after another)
Steps to Reproduce the Problem

Create 2 tasks (task-1, task-2)
Create a pipeline in such a way that task-2 runs after the task-1 and add WhenExpression to the task-2
Make sure that the WhenExpression of the task-2 always fails and always gets executed immediately when the pipelinerun is started (you can use static input to make sure that the WhenExpression always fails)
Start the pipeline and check the status of the pipelinerun

Additional Info

Kubernetes version:
Output of kubectl version:
Client Version: version.Info{Major:"1", Minor:"10+", GitVersion:"v1.10.0+b3b92b2", GitCommit:"b3b92b2", GitTreeState:"clean", BuildDate:"2020-07-15T09:27:21Z", GoVersion:"go1.14.3", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"18+", GitVersion:"v1.18.3+8b0a82f", GitCommit:"8b0a82f", GitTreeState:"clean", BuildDate:"2020-07-10T05:34:00Z", GoVersion:"go1.13.4", Compiler:"gc", Platform:"linux/amd64"}

Tekton Pipeline version:
$ tkn version
Client version: 0.12.0
Pipeline version: v0.16.0
Triggers version: unknown

Command Execution Logs:
$ kubectl get pipeline pipeline-with-when-expression -o yaml
apiVersion: tekton.dev/v1beta1
kind: Pipeline
metadata:
  creationTimestamp: "2020-09-11T05:38:05Z"
  generation: 18
  managedFields:
  - apiVersion: tekton.dev/v1beta1
    fieldsType: FieldsV1
    fieldsV1:
      f:spec:
        .: {}
        f:params: {}
        f:resources: {}
        f:tasks: {}
    manager: Mozilla
    operation: Update
    time: "2020-09-11T08:35:28Z"
  name: pipeline-with-when-expression
  namespace: veeresh-testing
  resourceVersion: "412847"
  selfLink: /apis/tekton.dev/v1beta1/namespaces/veeresh-testing/pipelines/pipeline-with-when-expression
  uid: 3bc57b32-e865-4d57-ac0d-d32ad235898b
spec:
  params:
  - name: status-1
    type: string
  tasks:
  - name: task-1
    taskRef:
      kind: Task
      name: first-task
  - name: task-2
    runAfter:
    - task-1
    taskRef:
      kind: Task
      name: second-task
    when:
    - Input: $(params.status-1)
      Operator: in
      Values:
      - Success
      - success
$
$
$ tkn p start pipeline-with-when-expression -p status-1=Failure
PipelineRun started: pipeline-with-when-expression-run-6bd55

In order to track the PipelineRun progress run:
tkn pipelinerun logs pipeline-with-when-expression-run-6bd55 -f -n veeresh-testing
$
$ kubectl get pipelinerun
NAME                                      SUCCEEDED   REASON    STARTTIME   COMPLETIONTIME
pipeline-with-when-expression-run-6bd55   Unknown     Started   100s
$
$ tkn pr ls
NAME                                      STARTED        DURATION   STATUS
pipeline-with-when-expression-run-6bd55   1 minute ago   ---        Running(Started)
$
$ kubectl get pipelinerun pipeline-with-when-expression-run-6bd55 -o yaml
apiVersion: tekton.dev/v1beta1
kind: PipelineRun
metadata:
  creationTimestamp: "2020-09-11T08:44:37Z"
  generateName: pipeline-with-when-expression-run-
  generation: 1
  labels:
    tekton.dev/pipeline: pipeline-with-when-expression
  managedFields:
  - apiVersion: tekton.dev/v1beta1
    fieldsType: FieldsV1
    fieldsV1:
      f:metadata:
        f:labels:
          .: {}
          f:tekton.dev/pipeline: {}
      f:status:
        .: {}
        f:conditions: {}
        f:pipelineSpec:
          .: {}
          f:params: {}
          f:tasks: {}
        f:startTime: {}
    manager: controller
    operation: Update
    time: "2020-09-11T08:44:37Z"
  - apiVersion: tekton.dev/v1beta1
    fieldsType: FieldsV1
    fieldsV1:
      f:metadata:
        f:generateName: {}
      f:spec:
        .: {}
        f:params: {}
        f:pipelineRef:
          .: {}
          f:name: {}
    manager: tkn
    operation: Update
    time: "2020-09-11T08:44:37Z"
  name: pipeline-with-when-expression-run-6bd55
  namespace: veeresh-testing
  resourceVersion: "414792"
  selfLink: /apis/tekton.dev/v1beta1/namespaces/veeresh-testing/pipelineruns/pipeline-with-when-expression-run-6bd55
  uid: 5baedc5c-78b9-49ec-b05e-64a09c9156f9
spec:
  params:
  - name: status-1
    value: Failure
  pipelineRef:
    name: pipeline-with-when-expression
  timeout: 1h0m0s
status:
  conditions:
  - lastTransitionTime: "2020-09-11T08:44:37Z"
    reason: Started
    status: Unknown
    type: Succeeded
  pipelineSpec:
    params:
    - name: status-1
      type: string
    tasks:
    - name: task-1
      taskRef:
        kind: Task
        name: first-task
    - name: task-2
      runAfter:
      - task-1
      taskRef:
        kind: Task
        name: second-task
      when:
      - Input: $(params.status-1)
        Operator: in
        Values:
        - Success
        - success
  startTime: "2020-09-11T08:44:37Z"
$
$
$ kubectl get pipelinerun
NAME                                      SUCCEEDED   REASON    STARTTIME   COMPLETIONTIME
pipeline-with-when-expression-run-6bd55   Unknown     Started   3m6s
$
$ tkn pr ls
NAME                                      STARTED         DURATION   STATUS
pipeline-with-when-expression-run-6bd55   4 minutes ago   ---        Running(Started)
$ tkn tr ls
No TaskRuns found
$ kubectl get taskrun
No resources found.

yikes! thanks for trying when expressions out so thoroughly @VeereshAradhya we'll get to this right away :D

Quick update: aiming to have a release with a fix for this out on Monday

Okay 0.16.2 is up now (https://github.com/tektoncd/pipeline/releases/tag/v0.16.2) please let us know if you still run into problems!


2 Sales price worksheet (one is not working)

1. Describe the bug
2 times of "Verkoopprijsvoorstel" (sales price worksheet) in the search.
1 is not working because I activated the new sales price calculation

I also added the CLEAN19 in the preprocessorSymbols in the app.json.

2. To Reproduce

Activate the new sale price calculation
Search for "Verkoopprijsvoorstel"

3. Expected behavior
Only one "Verkoopprijsvoorstel" in the search.
4. Actual behavior
A clear and concise description of what happened accompanied by images, animations, or a link to a video showing the issue occurring
5. Versions:

Hi, this issue is out of scope of for this repository. You should do one of the following:

Open a support request to CSS through the PartnerSource portal
Open a bug in Collaborate
Contact your Service Account Manager (SAM) in your local subsidiary to understand what is included in your contract as of support incident and PAH (Partner Advisory Hours). Your SAM might also direct you "step by step" how to open a support request or how to get credentials, if this is the first time for you or your company

As a reminder, this repository only handles issues to do with the compiler or VSCode development experience for AL.


CIF QA testing

Describe the task
Team QA testing
Acceptance Criteria

[ ] Bugs are identified and prioritized

Thanks for the hard work!


Events list default sort should be Last Seen rather than Name

During testing on v2.7-head (Commit ID: e54432e), I was able to verify that the Sort Default on the Events page grid is now Last Seen. Therefore I am closing this ticket.


NTR: negative regulation of pollen tube guidance

Please provide as much information as you can:

Suggested term label:
negative regulation of pollen tube guidance

Definition (free text)
Any process that decreases the rate, frequency or extent of pollen tube guidance towards ovules. This is one mechanism to prevent polytuby, the simultaneous penetration of ovules by multiple pollen tubes.

Reference, in format PMID:#######
PMID:33790463

Gene product name and ID to be annotated to this term
AT1G31450 (ECS1)
AT2G35615 (ECS2)

Parent term(s)
GO:0010183 pollen tube guidance

Children terms (if applicable) Should any existing terms that should be moved underneath this new proposed term?

Synonyms (please specify, EXACT, BROAD, NARROW or RELATED)
prevention of polytuby BROAD

Cross-references

For enzymes, please provide RHEA and/or EC numbers.

Can also provide MetaCyc, KEGG, Wikipedia, and other links.

Any other information

+[Term]
+id: GO:0160068
+name: negative regulation of pollen tube guidance
+namespace: biological_process
+def: "Any process that decreases the rate, frequency or extent of pollen tube guidance towards ovules. This is one mechanism to prevent polytuby, the simultaneous penetration of ovules by multiple pollen tubes." [PMID:33790463]
+synonym: "prevention of polytuby" BROAD []
+is_a: GO:0065007 ! biological regulation
+intersection_of: GO:0065007 ! biological regulation
+intersection_of: negatively_regulates GO:0010183 ! pollen tube guidance
+created_by: rynl
+creation_date: 2023-03-31T21:16:03Z


Tweak wording based on user feedback

Incorporate the feedback from https://github.com/dependabot/dependabot-core/issues/3341 to clarify the wording.

Why:
Closes https://github.com/dependabot/dependabot-core/issues/3341

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

[ ] I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
[ ] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[ ] This pull request impacts the contribution experience

[ ] I have added the 'writer impact' label
[ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@jeffwidman Thanks so much for opening a PR! I'll get this triaged for review :zap:

Ok
Den sön 18 sep. 2022 01:06Jeff Widman @.***> skrev:

@.**** commented on this pull request.
In
content/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file.md
https://github.com/github/docs/pull/20095#discussion_r973637367:

@@ -417,7 +417,7 @@ updates:

open-pull-requests-limit
-By default, {% data variables.product.prodname_dependabot %} opens a maximum of five pull requests for version updates. Once there are five open pull requests, new requests are blocked until you merge or close some of the open requests, after which new pull requests can be opened on subsequent updates. Use open-pull-requests-limit to change this limit. This also provides a simple way to temporarily disable version updates for a package manager.
+By default, {% data variables.product.prodname_dependabot %} opens a maximum of five pull requests for version updates. Once there are five open pull requests from {% data variables.product.prodname_dependabot %}, {% data variables.product.prodname_dependabot %} will not open any new requests until some of those open requests are merged or closed. Use open-pull-requests-limit to change this limit. This also provides a simple way to temporarily disable version updates for a package manager.
I tried to get at that though in the wording of "...are merged or closed.".
Since the old one is closed, then that unlocks "open new pull
requests"... so I don't see the conflict here? I do agree though that it
requires parsing through the logic there to realize that.
Feel free to submit a docs PR if you have a suggestion for how to word it
better, they're open to contributions from anyone, not just GH employees!
😄
—
Reply to this email directly, view it on GitHub
https://github.com/github/docs/pull/20095#discussion_r973637367, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AV4I4GO3KXLTIRB7HVFQZFLV6ZFG5ANCNFSM57MSWITQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Added group diag

@whyrusleeping Need your feedback on this. These need to be changed.

Note: 0.4.0 has an extra subcommand to ipfs diag
ipfs diag cmds - List commands run on this ipfs node

@RichardLitt Timeout is global: find the relevant go-code and put it in a thing.

Added subcmds. Also edited them, so, this PR should be merged first. https://github.com/ipfs/go-ipfs/pull/2487

Final thing to do: Add a PR for timeout. However, the rest of this is RFCR and then RFM.

Mentioned PR in https://github.com/ipfs/go-ipfs/issues/2583. Merging this as that isn't relevant to the direct code in this PR.


Feature Request: Refactoring UI

Hi.
I came up with the following changes to improve your application usability.

[ ] Remove buttons and render UI by selectbox change event
[ ] Change selectbox option values from "id" to "Station name"
[ ] Integrate two selectbox to one

If it becomes a direction to implement through the discussion here,
I would like to work on this.
Regards.

sure go ahead with this, actually i wanted to combine both the datasets and info together


report different states to azure test plans

This PR implements the change described in #38 without the option to configure the mapping.
I have no NodeJs IDE or the option to test this changes locally, so please review.

@joerg1985 I appreciate you work
I am added a little bit fixes in you code but I not added config mapping
also I published package as beta, check out
<EMAIL_ADDRESS>

@alexneo2003
thank you, will test it in the next days and give feedback.

skipped = 'Not Applicable', should be skipped = 'NotApplicable', looks like we need to hit a Enum name here.
All the enums are listed here, so we can map other values too:

timeout to Timeout
interrupted to Aborted

@alexneo2003 could you please create a new beta with the latest fixes?

@alexneo2003 could you please create a new beta with the latest fixes?

<EMAIL_ADDRESS>

I had a look at the last runs of the pipeline and the results look good, this could be merged.
The only thing to notice is that the 'Aborted' status does not update the state shown, but it will be listed in the details.
To check this i had to call the API with the 'Aborted' status, as this state is IMHO not reachable when running in the CI.
PS: i think the 'colors' dependency could be removed or did i miss the usage in the code?
https://github.com/alexneo2003/playwright-azure-reporter/blob/main/package.json#L43


Make CertaintySampling query strategy

This should be basically identical to the UncSampling class, but the dist value will be what is closest to the value of "anomaly". See the notes below:
def uncertainty_sampling(class_prob: np.array, test_ids: np.array,
                         queryable_ids: np.array, batch=1,
                         screen=False, query_thre=1.0) -> list:

    if class_prob.shape[0] != test_ids.shape[0]:
        raise ValueError('Number of probabiblities is different ' +
                         'from number of objects in the test sample!')

    # calculate distance to the decision boundary - only binary classification
    dist = abs(class_prob[:, 1] - 0.5) **#! Change this to be which ever is closest to 1 (or 0, which ever is anomaly)**

    # get indexes in increasing order
    order = dist.argsort()

    # only allow objects in the query sample to be chosen
    flag = list(pd.Series(data=test_ids[order]).isin(queryable_ids))

    # check if there are queryable objects within threshold
    indx = int(len(flag) * query_thre)

    if sum(flag[:indx]) > 0:

        # arrange queryable elements in increasing order
        flag = np.array(flag)
        final_order = order[flag]

        if screen:
            print('\n Inside UncSampling: ')
            print('       query_ids: ', test_ids[final_order][:batch], '\n')
            print('   number of test_ids: ', test_ids.shape[0])
            print('   number of queryable_ids: ', len(queryable_ids), '\n')
            print('   *** Displacement caused by constraints on query****')
            print('   0 -> ', list(order).index(final_order[0]))
            print('   ', class_prob[order[0]], '-- > ', class_prob[final_order[0]], '\n')

        # return the index of the highest uncertain objects which are queryable
        return list(final_order)[:batch]

    else:
        return list([])

So sorry!!! Too many github issues windows open, created this in the wrong repo.


Adding Pre-Arrival Checklist page and Orientation Calendar page to Next Steps Nav Area

Hey Jay,
Can you do this for JUST http://risd-undergraduate-welcome.risd.systems/ for now.
Thanks!
Carrie

Hey Jay,
Pre-arrival is now in the Nav area on both .systems and the live site, and soon we'll be putting the Orientation Programs page (previously called Orientation Calendar) on both, so no need to do this request anymore.  I'm going ahead and closing this.
Thanks,
Carrie


Knockback

Add knockback to PvP. I've added sound, so we're almost there!

I send entity-velocity to everyone if it's a mob, and then only to a player if I'm moving them?
Wait, do I even need to send it to everyone for a mob since I'm sending the mob's position anyway?

There's knockback for entities, but not players. Why ?


/home/axle/reconftw/reconftw.sh: line 3: ./reconftw.cfg: No such file or directory

The Title pretty much sums it up. Basically when trying to run a scan
~/reconftw/reconftw.sh -d domain
Then I get this:
/home/axle/reconftw/reconftw.sh: line 3: ./reconftw.cfg: No such file or directory
Any idea Why what the reconftw.cfg file is?

I've figured it out. For some reason I didn't see the file even tho it was staring me in the face.


Clarify how often usage reports are sent

Closes #921. This PR doesn't change the current behavior, but it tries to make that behavior clear. For example, I used to think that usage reports were sent every 30 days. After this PR, usage reports will continue to be sent every 31 days — but I think that fact will be clearer.
What has been done to verify that this works as intended?
Updated and new tests.
Why is this the best possible solution? Were any other approaches considered?
I considered not making any changes at all. I realized that I could send daily usage reports by setting the default.taskSchedule.analytics config to 0 instead of 1. However, I think this PR makes things a little clearer.
I'll also leave a comment about an individual line.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
The current behavior is intended to stay the same. I've updated tests to help verify that there hasn't been a change in behavior.
Does this change require updates to the API documentation? If so, please update docs/api.md as part of this PR.
I don't think so. We say in the API docs that usage data is sent monthly, which is consistent with the current interval of 31 days.
Before submitting this PR, please make sure you have:

[x] run make test-full and confirmed all checks still pass OR confirm CircleCI build passes
[x] verified that any code from external sources are properly credited in comments or that everything is internally sourced

@ktuite, I'm thinking this can be reviewed async.


Slovenia Addresses

can @nvkelso or @iandees look at the terms?
http://egp.gu.gov.si/egp/
right under blue box (where it says Splošni pogoji uporabe geodetskih podatkov )
I think it is fine, but want another set of eyes on it

It looks like a CC-BY license, which is fine.

downloading a few supplemental datasets to hopefully add in street names as these only contain number/ apartment. they should join based on a street id field. stay tuned

Wow!
On Wed, Apr 26, 2017 at 10:58 AM, Justin Meyers<EMAIL_ADDRESS>wrote:

downloading a few supplemental datasets to hopefully add in street names
as these only contain number/ apartment. they should join based on a street
id field. stay tuned
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openaddresses/openaddresses/issues/2926#issuecomment-297492152,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA0EO36Apr7JHX9IvS5wcsVzSGJuSs1Gks5rz4XPgaJpZM4NJMPc
.

if you want you guys can sign up and dl directly!

there is a whole bunch of other goodies in there ;) admins, settlements, etc

😮
That’s a whole country.

yeah - we aren't messing around here... this is a serious global dataset!!!!!!!!!

awesome! this was rumored to be coming but it's amazing to see it actually happened

here is the formatting: http://www.e-prostor.gov.si/fileadmin/struktura/sifrant_rpe_enot.htm

uploading raw gis data to dropbox

https://www.dropbox.com/sh/8pred67i3zycstl/AABhJOfrXRyqHi0s8J0ZbJWVa?dl=0

The dataset contains plenty of other information, should some of that be included as well (besides minimal mandatory street name and numbers)?
Eg city names, post codes (with names), commune & region names...
Some smaller places don't have street system, so the city name + house number is normally used instead. Is it ok to repeat the city name in both fields (street and city) in such cases?
There are 500000+ addresses, is it ok to have them all in a single csv or should it be split into smaller chunks (eg regionally)? "Address counts per source" chart on  http://results.openaddresses.io/dashboard tops at 200000 addresses, but there seem to be larger sources mentioned in the Lost sources section.

@stefanb Thanks for looking into this! The relevant fields are in the "Attribute Tags" section of the contributing manual (https://github.com/openaddresses/openaddresses/blob/master/CONTRIBUTING.md). So, I'd say at least house, street, city, postcode are necessary. If available, municipalities/communes should be under the "district" field, and statistical region under "region".
Best to keep the whole source as a single file. The Mexico import contained 30M addresses in one file and the import went smoothly.
On street names my feeling is that it should be kept empty, but maybe there was a similar precedent already? @migurski and @thatdatabaseguy, do you have suggestions on this?

@stefanb @sergiyprotsiv I think that's fine. OSM has the notion of "addr:place", which handles this, but IIRC in most countries in the region, the place is basically used as a street name. We currently import Slovakia, Poland, Austria, etc. which would probably list the city in the street field for smaller villages. If we're changing that for Slovenia we'd want to do the same for other sources, so think I'd prefer to list the city as "street".

Tnx, all clear now. I expect to have a pull request with scripts and source definition JSON ready in the next few days.

thanks @stefanb !!!!!!!!!!!


Bump Razor and Roslyn to respond to Razor serialization changes

Still need to update the changelog, but lets see if it builds

Forgot to run updateRoslynVersion too 🤦♂

/azp run


[SPARK-17100] [SQL] fix Python udf in filter on top of outer join

What changes were proposed in this pull request?
In optimizer, we try to evaluate the condition to see whether it's nullable or not, but some expressions are not evaluable, we should check that before evaluate it.
How was this patch tested?
Added regression tests.

Test build #65402 has started for PR 15103 at commit 1a076b7.

Test build #65402 has finished for PR 15103 at commit 1a076b7.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65402/
Test FAILed.

Test build #65502 has started for PR 15103 at commit 4b6ec42.

Test build #65502 has finished for PR 15103 at commit 4b6ec42.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65502/
Test PASSed.

LGTM

Merging into master and  2.0


add function CreateContainer and SaveBlockBlob"

What this PR does / why we need it:
We need functions to create Container and save Blob to ServiceAccount for ManagedOpenShift SP
We also realized that the CreateContainer and SaveBlob should be public functions so that other SPs can reuse that.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
If applicable:

[ ] documentation
[ ] unit tests
Passed by running makedev.ps1 & make test
=======================
Ginkgo ran 28 suites in 12m56.9024074s
Test Suite Passed
==========================
[ ] tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

@CecileRobertMichon We think those two functions need to be public because the CreateContainer and SaveBlob are very common functions that other RP may also need them.
Unit test is just added.

@mick0601 Thanks for the fixes. Looks good so far. Added a few more comments :)

/lgtm

Thanks a lot @mick0601 :)


invalid or unsupported zip format. no end header found

I found this issue while trying to set up autoupdater, I saw this is an issue specifically with AdmZip but couldnt find any helpful solutions. Can someone please help me out? I will attach a few photos.

Why are you using Adam-zip ?, you can just follow the tutorial in YouTube. Or use electron-updater, it's a little implementation for electron-builder


Executable resilience tests re-build library under a new name now

Building a new dylib with the same name was breaking some internal bots.
Fixes rdar://problem/34148403.

@swift-ci Please smoke test

@swift-ci Please smoke test


Enable sensitivity analysis

My goal is to make the building of a simulation and the solution differentiable. This will enable sensitivity analysis of the output of a dynamic simulation wrt some parameters of the system model. The first commit addresses the first step which is to build out the capability of passing and handling parameters as a flat vector (similar to the states).

[x] Pass parameters as a flat vector when constructing the differential equation problem.
[ ] Simulation flow upgrades
[ ] Changes for compatibility with automatic differentiation (Zygote)
[ ] Sensitivity analysis API

An open question is coming up with a set of rules for determining what is a parameter and what is not? For example, non Float values (ie Flags) are not considered parameters. Some saturation values are also not passed as parameters. The only downside is that those values cannot be used in sensitivity analysis.


Speech Recognition with Intents is Incomplete

Please provide us with the following information:

This issue is for a: (mark with an x)
- [ ] bug report -> please search issues before submitting
- [X] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

NA
Any log messages given by the failure

NA
Expected/desired behavior

When using the IntentRecognizer, it returns IntentRecognitionResult. The IntentRecognitionResult only has the intents and not the entities. I have found that I can add Microsoft.Bot.Builder.Ai.LUIS and related packages. I then have to cast this in a very confusing way.
var result = await recognizer.RecognizeAsync().ConfigureAwait(false);
var luisJson = result.Properties.Get(ResultPropertyKind.LanguageUnderstandingJson);
var luisResult = JsonConvert.DeserializeObject(luisJson);
Why would dependencies be needed for the BotBuilder framework? The BotBuilder framework is huge, and not directly related. The predecessor of this project (ProjectOxford) seemed to have had at least a Payload property for storing the JSON. In addition, it would be nice to have a LuisResult or an extension that would not be dependent on the whole BotBuilder framework to get a complete Intent object with entities, scoring, etc.
OS and Version?

Windows 7, 8 or 10. Linux (which distribution). Other.
Windows 10

Versions

Version 0.5.0
Mention any other details that might be useful

Thanks! We'll be in touch soon.

I figured out that you can get the Microsoft.Azure.CognitiveServices.Language.LUIS.Runtime package to get the LuisResult class.

thank you for posting the answer ... closing
please open a new issue if required


bugfix - #1192 editing purchase

there was an error editing a purchase, referred on #1192
when i ran the tests, this message appeared

so, i fixed the spec and there is no false positive anymore

i made a mistake and sent commits that should not be here, i'll open another pr.


Chomecast not showing friendly names, but device numbers.

Windows 10
All my Chromecast devices (and groups) aren't being shown with their names, but some internal device numbers (and duplications):
(however, they do still seem to work!)

Here's the list in Chrome:

I have a feeling this is an issue with the underlying electron-chromecast library we built, we'll have to look into it and see what's been updated.

Hmmmm, do you see this on your machine @jostrander ?  I still have proper device names appearing on mine
@exemmer Do you have Bonjour installed on your machine?

Bonjour? Nope. Don't do Apple;)

@exemmer Please install Bonjour print services and restart.  The names should be resolved then

Install an Apple product to make a Google product work?

It's almost as if Google uses existing technology instead of reinventing the wheel...

Although bonjour is apple, it is the cross platform standard for MDNS.  Even Chrome implements a version of Bonjour

Now that's it ironic, Alanis..

I'm getting this bug too. I suspect it's because I opted into the Chromecast preview firmware.

I'll have to get one of my three casts joined into that so I can test this out.

Fixed up stream, @MarshallOfSound can we add this to a minor future release?

This will go out with v4

I'm on OSX and v4 of the app and still seeing this.


[DOC]: Clarify the benchmarks page

Suggested Changes
I can't suggest exact text, because I couldn't understand the page so to be able to say what is what. But there is something which can be done to improve the usability of this page.
For example, there is a matrix with title "Performance Matrix for euclidean_l2 while alignment is False". Let's take the "ArcFace" column.

I don't get what "for euclidean_l2"  in the title does mean - did you perform training of the backbone of the ArcFace using euclidean_l2 distance instead of ArcCosine distance in the loss function then evaluating on LFW using again euclidean_l2 instead of cosine or if not, what did you do ?
The first, noname column contains things like "retinaface", "centerface", etc. which look like alignment methods. So what alignment is False statement means - that you did not perform alignment using the methods in the noname coumn ? Then these metods were used to perform what ? Only face detection ?
Where alignment is True, did you train each model with the given alignment applied to the training dataset and on the testing (LFW) dataset or you took a pretrained on whatever dataset model and evaluated it only on aligned (with the given alignment model) LFW dataset ?

Additional Info
No response

recommend to read its paper - https://doi.org/10.17671/gazibtd.1399077
everything is explained in there


Provide a way to configure more Kafka Streams and Kafka Producer properties in API server

For both the global Kafka Producer and Kafka Streams in the API server, we only have a small selection of properties that are configurable via application.properties or environment variables.
There are certain properties whose optimal values will depend heavily on the environment: The producer properties batch.size and linger.ms come to mind.
We should provide a way for users to configure more, if not all, Kafka properties via environment variables - similar to how it is possible with the Quarkus-based services.
Instead of adding ConfigKeys for every single property, we can leverage the solution for https://github.com/DependencyTrack/hyades/issues/576 (https://github.com/stevespringett/Alpine/pull/494) to achieve this.

Blocked by pending Alpine release.


Best practices for getting noble to poll for notifications quickly and consistently?

Hi there -
I'm running noble on a Raspberry pi 3 device, using an external antenna - trying to read heart rate from several BLE heart rate monitors at a time.
I've basically taken the intro code from this repo and changed it to only look for the Heart Rate Service (180d) - which has done a good job of ensuring that my Pi only connect to devices I'm interested in... but past that I haven't changed much.
I've noticed that noble doesn't seem to consistently connect to all of the devices I've got in the room with me.  Even with an CSR antenna, often times it only seems to connect to 2-4 devices, rather than all 5 that are possible.  Is there something I can do to see what's happening here?
In addition to that, once the devices are found, paired, and connected to, often times the notifications I subscribe to for the heart rate service don't happen very quickly (initially).  Sometimes I'm waiting 30s-1min before a single heart rate comes back from a given device.  Is that a known issue?

I should add that testing on a Macbook Pro yields different results - I hit the 6 device limit right away (using the internal bluetooth radio), and get notifications pretty quickly thereafter, every time.

Hi @mbifulco,

Is there something I can do to see what's happening here?

Let's start with an HCI dump capture: sudo hcidump -t -x - this will shed some light as to what's going on at the adapter level.

Closing this due to lack of activity for now.


dogecoin/src/$ make -f makefile.unix use_upnp =-

ubuntu version 14.10
after using this command i get this error
dogecoin/src/$ make -f makefile.unix use_upnp =-
make: ***empty variable name.  stop.

The build system is based on the Bitcoin Core 0.9 build environment, rather than the older versions that use "make -f..."
Have a look at https://github.com/dogecoin/dogecoin/blob/1.9-dev/doc/build-unix.md for instructions


I can't set the program up

I typed git clone https://github.com/lorenzodifuccia/safaribooks.git into cmd and I get an error:
'git' is not recognized as an internal or external command,
operable program or batch file.

Hello comrade, you'll have to install git first via your distro's package manager. For instance on my ubuntu instance, I type
sudo apt-get install git
and then you can use git. For more documentation, please see https://git-scm.com/book/en/v2/Getting-Started-Installing-Git


Celo:I made a heat transaction to a wallet and mark as approved and sent and I never arrive at the coinlist wallet I need help to solve it please

Describe your issue here.
Environment

Elixir Version: 1.11.4

Erlang Version: 23

BlockScout Version: d334a72ffc31ee415908a27c74bc0a0ffa21a681

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.106 Safari/537.36

Steps to reproduce
Tell us how to reproduce this issue. If possible, push up a branch to your fork with a regression test we can run to reproduce locally.
Expected Behaviour
Tell us what should happen.
Actual Behaviour
Tell us what happens instead.

Same problem, same time (6/19/21 12:30-45). can someone help us?


dragino lps8 hacked?

The LPS8 had been working -> end device activated, uplink activity recorded in the staging console, and finally data transmitted and rewards were showing up helium explorer (usually within a half hour).  Starting a few days ago, something changed, and now -> end device activated, uplink activity recorded in the staging console, but now nothing shows up in helium explorer (ever).
Before, when I would restart the helium gateway, I would see lines like this:
Tue Feb 22 23:25:06 2022 daemon.info helium_gateway[2062]:  INFO starting, oui: 20, uri: http://<IP_ADDRESS>:8080/, pubkey: 11Z71QiBvLd8m2LFtgDpVwR86H3mpXsT93wbntF46LUsSxyqxCw, module: router
Tue Feb 22 23:25:06 2022 daemon.info helium_gateway[2062]:  INFO starting, oui: 16, uri: http://<IP_ADDRESS>:8080/, pubkey: 11afuQSrmk52mgxLu91AdtDXbJ9wmqWBUxC3hvjejoXkxEZfPvY, module: router
Tue Feb 22 23:25:06 2022 daemon.info helium_gateway[2062]:  INFO starting, oui: 12, uri: http://<IP_ADDRESS>:8080/, pubkey: 112ewJNEUfSg3Jvo276tMjzFC2JzmmZcJJ32CWz2fzYqbyCMMTe1, module: router
Tue Feb 22 23:25:07 2022 daemon.info helium_gateway[2062]:  INFO starting, oui: 10, uri: http://<IP_ADDRESS>:8080/, pubkey: 11YmZtwTPEuMSFGxze1x9TfDfGezN7vXevLu71iJe9FBbvNRAgk, module: router
Tue Feb 22 23:25:07 2022 daemon.info helium_gateway[2062]:  INFO starting, oui: 9, uri: http://<IP_ADDRESS>:8080/, pubkey: 11w77YQLhgUt8HUJrMtntGGr97RyXmot1ofs5Ct2ELTmbFoYsQa, module: router
Tue Feb 22 23:25:07 2022 daemon.info helium_gateway[2062]:  INFO starting, oui: 4, uri: http://<IP_ADDRESS>:8080/, pubkey: 11263KvqW3GZPAvag5sQYtBJSjb25azSTSwoi5Tza9kboaLRxcsv, module: router
Tue Feb 22 23:25:07 2022 daemon.info helium_gateway[2062]:  INFO starting, oui: 2, uri: http://<IP_ADDRESS>:8080/, pubkey: 1124CJ9yJaHq4D6ugyPCDnSBzQik61C1BqD9VMh1vsUmjwt16HNB, module: router
Tue Feb 22 23:25:07 2022 daemon.info helium_gateway[2062]:  INFO updated routing to height 1238054, module: dispatcher
Tue Feb 22 23:25:07 2022 daemon.info helium_gateway[2062]:  INFO starting, oui: 1, uri: http://<IP_ADDRESS>:8080/, pubkey: 112qB3YaH5bZkCnKA5uRH7tBtGNv2Y5B4smv1jsmvGUzgKT71QpE, module: router
The oui's, ip addressess, and pubkeys were persistent (wouldn't change).
Now, over the course of a few minutes, I start to see this:
Tue Feb 22 23:54:39 2022 daemon.info helium_gateway[9241]:  INFO uplink @1774690708 us, 904.90 MHz, Ok(DataRate(SF9, BW125)), snr: 2, rssi: -115, len: 52 from MacAddress(A8:40:41:21:D7:BC:50), module: gateway
Tue Feb 22 23:59:40 2022 daemon.info helium_gateway[4096]:  INFO new packet forwarder client: MacAddress(A8:40:41:21:D7:BC:50), <IP_ADDRESS>:47208, module: gateway
Meanwhile in the system logs, I see this:
Tue Feb 22 23:28:20 2022 authpriv.notice dropbear[5639]: Password auth succeeded for 'root' from <IP_ADDRESS>:52558
Tue Feb 22 23:29:00 2022 cron.info crond[1177]: USER root pid 6651 cmd /etc/init.d/auto_update start
Tue Feb 22 23:29:06 2022 authpriv.info dropbear[6851]: Child connection from <IP_ADDRESS>:52559
Tue Feb 22 23:29:08 2022 authpriv.warn dropbear[6851]: Bad password attempt for 'root' from <IP_ADDRESS>:52559
Tue Feb 22 23:29:08 2022 authpriv.notice dropbear[6851]: Password auth succeeded for 'root' from <IP_ADDRESS>:52559
Tue Feb 22 23:29:50 2022 authpriv.info dropbear[7515]: Child connection from <IP_ADDRESS>:52569
Tue Feb 22 23:30:00 2022 cron.info crond[1177]: USER root pid 7579 cmd /etc/init.d/auto_update start
Tue Feb 22 23:30:00 2022 cron.info crond[1177]: USER root pid 7580 cmd /etc/init.d/DR_enable_rssh.sh start
Tue Feb 22 23:31:16 2022 daemon.info lora_pkt_fwd[2493]: PKT_FWD~ DATA_UNCONF_UP-> {"DevAddr": "0100DA30", "FCtrl": ["ADR": 0, "ADRACKReq": 1, "ACK": 0, "RFU" : "RFU", "FOptsLen": 5], "FCnt": 3361, "FPort": 79, "MIC": "E3703F70"}
Tue Feb 22 23:31:16 2022 daemon.info lora_pkt_fwd[2493]: RXTX~ {"rxpk":[{"tmst":371387412,"time":"2022-02-22T23:31:16.676571Z","chan":6,"rfch":1,"freq":905.100000,"stat":1,"modu":"LORA","datr":"SF9BW125","codr":"4/5","lsnr":-10.0,"rssi":-129,"size":52,"data":"QDDaAAFVIQ3+AOHBAE88ixx9M/BJR0NjlDoZ/gaymPH4w9fq0aHHOf+TAjrtWIxHcD9w4w=="}]}
Tue Feb 22 23:31:16 2022 daemon.info helium_gateway[2062]:  INFO uplink @371387412 us, 905.10 MHz, Ok(DataRate(SF9, BW125)), snr: -10, rssi: -129, len: 52 from MacAddress(A8:40:41:21:D7:BC:50), module: gateway
Tue Feb 22 23:31:39 2022 daemon.info helium_gateway[9241]:  INFO new packet forwarder client: MacAddress(A8:40:41:21:D7:BC:50), <IP_ADDRESS>:47208, module: gateway
Tue Feb 22 23:33:11 2022 daemon.info lora_pkt_fwd[2493]: PKT_FWD~ DATA_UNCONF_UP-> {"DevAddr": "4800080A", "FCtrl": ["ADR": 1, "ADRACKReq": 0, "ACK": 0, "RFU" : "RFU", "FOptsLen": 0], "FCnt": 23, "FPort": 10, "MIC": "128032CD"}
Tue Feb 22 23:33:11 2022 daemon.info lora_pkt_fwd[2493]: RXTX~ {"rxpk":[{"tmst":485993908,"time":"2022-02-22T23:33:11.285744Z","chan":3,"rfch":0,"freq":904.500000,"stat":1,"modu":"LORA","datr":"SF10BW125","codr":"4/5","lsnr":12.2,"rssi":-47,"size":23,"data":"QAoIAEiAFwAKaUZYQxOCuI1Vnc0ygBI="}]}
Tue Feb 22 23:33:11 2022 daemon.info helium_gateway[9241]:  INFO uplink @485993908 us, 904.50 MHz, Ok(DataRate(SF10, BW125)), snr: 12.2, rssi: -47, len: 23 from MacAddress(A8:40:41:21:D7:BC:50), module: gateway
Tue Feb 22 23:33:14 2022 daemon.info lora_pkt_fwd[2493]: PKT_FWD~ DATA_UNCONF_UP-> {"DevAddr": "4800080A", "FCtrl": ["ADR": 1, "ADRACKReq": 0, "ACK": 0, "RFU" : "RFU", "FOptsLen": 0], "FCnt": 24, "FPort": 10, "MIC": "DD11DCC5"}
Tue Feb 22 23:33:14 2022 daemon.info lora_pkt_fwd[2493]: RXTX~ {"rxpk":[{"tmst":489060060,"time":"2022-02-22T23:33:14.348978Z","chan":6,"rfch":1,"freq":905.100000,"stat":1,"modu":"LORA","datr":"SF10BW125","codr":"4/5","lsnr":10.8,"rssi":-66,"size":23,"data":"QAoIAEiAGAAK+ahKM8CL1DEgr8XcEd0="}]}
Tue Feb 22 23:33:14 2022 daemon.info helium_gateway[9241]:  INFO uplink @489060060 us, 905.10 MHz, Ok(DataRate(SF10, BW125)), snr: 10.8, rssi: -66, len: 23 from MacAddress(A8:40:41:21:D7:BC:50), module: gateway
Tue Feb 22 23:33:14 2022 daemon.info lora_pkt_fwd[2493]: INFO~ [up] PUSH_ACK received in 0 ms
Tue Feb 22 23:33:22 2022 daemon.info lora_pkt_fwd[2493]: PKT_FWD~ DATA_UNCONF_UP-> {"DevAddr": "4800080A", "FCtrl": ["ADR": 1, "ADRACKReq": 0, "ACK": 0, "RFU" : "RFU", "FOptsLen": 0], "FCnt": 25, "FPort": 10, "MIC": "246F595C"}
Tue Feb 22 23:33:22 2022 daemon.info lora_pkt_fwd[2493]: RXTX~ {"rxpk":[{"tmst":496900284,"time":"2022-02-22T23:33:22.191459Z","chan":2,"rfch":0,"freq":904.300000,"stat":1,"modu":"LORA","datr":"SF10BW125","codr":"4/5","lsnr":8.2,"rssi":-47,"size":23,"data":"QAoIAEiAGQAKv2fb+uZEEp9EDFxZbyQ="}]}
Tue Feb 22 23:33:22 2022 daemon.info helium_gateway[9241]:  INFO uplink @496900284 us, 904.30 MHz, Ok(DataRate(SF10, BW125)), snr: 8.2, rssi: -47, len: 23 from MacAddress(A8:40:41:21:D7:BC:50), module: gateway
Can someone please tell me if this looks normal?
If I have been hacked is there a way to fix it?
Restore factory settings?
Thanks in advance.

I can't tell if you got hacked or not.. When I read this I was assuming that

Tue Feb 22 23:29:06 2022 authpriv.info dropbear[6851]: Child connection from <IP_ADDRESS>:52559
Tue Feb 22 23:29:08 2022 authpriv.warn dropbear[6851]: Bad password attempt for 'root' from <IP_ADDRESS>:52559
Tue Feb 22 23:29:08 2022 authpriv.notice dropbear[6851]: Password auth succeeded for 'root' from <IP_ADDRESS>:52559

meant that this was you logging in to start tailing logs. If this is not the case you may have been compromised, but I can't really help with system security on other people's systems.
I do know that the mitigations to get past the last chain outage, causes the router to having issues closing state channels. This means your hotspot doesn't get recognized for routing the packets and no data packet rewards are issues until state channels are closed. The fix for this being tested and will get deployed soon.

@madninja thanks for taking a look and commenting

I'm going to close this since it's not really a gateway-rs issue and more general linux/device security.


fix: double slash URLs + misc

What

fix for double-slash in URLs, e.g. foo//bar/baz
fix for .ical links to remove trailing slash
fix for webinar links to use same domain

Why

we don't want broken links, and the more we can automate detection/ prevention, the better

Refs

task

Closing, as the target branch was incorrect


L2-514: Hide Spawn neuron percentage for HW

Motivation
Spawning a neuron does not need percentageToSpawn.
Changes

Make percentageToSpawn as optional.
"spawnNeuron" returns new neuron id.
Refactor some error management code.

Tests

Update test to check return value.

I have not yet been able to test with a hardware wallet.
It won't work until we move the request creation to protobuf. But this already changes the API and refactors and cleans up some code.

@peterpeterparker @mstrasinskis please review


Event card UX improvement mobile

Description
On mobile, the event cards "depress" on click but nothing happens.  The user must click on the event title to navigate to the event.  This creates confusion in the user experience.
This can be addressed in 1 of 2 ways (to be discussed)

remove the click event on the entire card and make it clear that the event title is clickable visually
adjust the click event so that on click of the event card, navigation to the event takes place

Screenshots
See this video for the card click interactions
https://user-images.githubusercontent.com/97615019/230390611-ed5a55a8-3fe5-46d4-9230-4c86666ff2a5.mov
Additional information
No response

I would like to take this one @amandamartin-dev @eddiejaoude

If approved, I would like to work on this.

i would love to work on this issue as i've worked on something similar @amandamartin-dev @eddiejaoude

Hey I would like to work on this issue. @amandamartin-dev

a reminder to all who have asked to work on this, while we appreciate contributions and the enthusiasm it is important to read the labels.  This issue is "awaiting triage" please do not ask to be assigned unless you see the status "ready for dev"
See the contributing guide for more information: https://github.com/EddieHubCommunity/LinkFree/blob/main/CONTRIBUTING.md

I think I can fix this issue,we will be changing the path to which the page will be directed,please assign it to me

Thank you @amandamartin-dev for raising the bug 👍 and for collaborating with the community.
I have updated the issue labels with ready for dev, so it can be assigned. I think option 2 is my preferred option, but I am opened to suggestions

Hi @amandamartin-dev i can fix this issue. Assign this to me.

I would like to take this one @amandamartin-dev @eddiejaoude

Hi @ashutosh887 I see you are already assigned to another issue so I will assign to the next in the list. Thank you for contributing.
@swagataroy30 assigning you, if you are no longer interested please let us know so that we can reassign

Sure @amandamartin-dev
Thanks!

I would like to take this one @amandamartin-dev @eddiejaoude

Hi @ashutosh887 I see you are already assigned to another issue so I will assign to the next in the list. Thank you for contributing.
@swagataroy30 assigning you, if you are no longer interested please let us know so that we can reassign

Hey sorry for the late response. I will make a PR soon. Thanks!

hey @amandamartin-dev is this issue still open ?

@Noothan-am I will re-assign the issue to you as there has been no activity for more than 2 weeks from the original assignee

@eddiejaoude i can take up this issue,please assign it to me if it is up for grabs

@eddiejaoude i can take up this issue,please assign it to me if it is up for grabs

@karthiknadar1204 please read the comment above yours from 2 hours ago

Please continue @Noothan-am

hey @amandamartin-dev @eddiejaoude, I think the possible fix might be to wrap the whole card in the Link Component.


Toggling LCDC.5 mid-scanline effects

On "LCDC.5 - Window Display Enable"

This bit controls whether the window shall be displayed or not. (TODO : what happens when toggling this mid-scanline ?) This bit is overridden on DMG by bit 0 if that bit is reset.

Fixed by #254


Add GRPC Plugin support

Add support for GRPC plugins using an init-container image which
installs a plugin into an emptyDir volume on startup.
Example Containerfile for installing the image:
FROM registry.access.redhat.com/ubi8-minimal
COPY --from=build /src/jaeger-storage /
CMD ["cp", "/jaeger-storage", "/plugin/humio-jaeger-storage"]

Example CRD for deployment with allInOne and a pre-existing secret
plugin-config:
jaegertracing.yaml
apiVersion: jaegertracing.io/v1
kind: Jaeger
metadata:
  name: with-grpc-plugin
spec:
  storage:
    type: grpc-plugin
    grpc-plugin:
      image: my-image
    options:
      grpc-storage-plugin.binary: "/plugin/start"
      grpc-storage-plugin.configuration-file: "/etc/plugin-config/jaeger-plugin-configuration.json"
  volumeMounts:
  - name: plugin-volume
    mountPath: /plugin
  - name: plugin-config-volume
    mountPath: /etc/plugin-config
  volumes:
  - name: plugin-volume
    emptyDir: {}
  - name: plugin-config-volume
    secret:
      secretName: plugin-config

Fixes #1042

This is a draft/POC to discuss the implementation options. Should volumes be explicitly defined in the CRD by the user? What about command line options? Or should there be a default binary name, default volume path for the plugin? What about the config file?

Are there any other alternatives or the plugin can be initialized only via init containers?
Do we have to add init containers into JaegerCommonSpec since there is new node for gRPC plugin?

Should volumes be explicitly defined in the CRD by the user?

I think that is fine.

What about command line options? What about the config file?

Could you please elaborate what you mean?
--grpc-storage-plugin.configuration-file does this have to be always specified?

Are there any other alternatives or the plugin can be initialized only via init containers?

This is the lowest maintenance option I found. It allows a user to use the operator and have the installation running with images from a vendor such as Red Hat, without having to rebuild the images whenever a security patch/update is out.
A binary is too large for a configmap or other k8s object.
It could be "downloaded" from an HTTP URL on startup, but I did not think this was a better option. Do you know any better alternative?

Do we have to add init containers into JaegerCommonSpec since there is new node for gRPC plugin?

Should volumes be explicitly defined in the CRD by the user?

I think that is fine.

What about command line options? What about the config file?

Could you please elaborate what you mean?
--grpc-storage-plugin.configuration-file does this have to be always specified?

I think most plugins will require it but maybe not all (i.e. something using service discovery and k8s service account for auth might automagically work).
What I meant was the we could have
   grpcPlugin:
     image: demo-plugin:1.0.0
   options:
     grpc-storage-plugin.binary: "/plugin/demo-plugin"
     grpc-storage-plugin.configuration-file: "/etc/plugin-config/config.json"

OR
   grpcPlugin:
     image: demo-plugin:1.0.0
     binary: /plugin/demo-plugin # The location where the init image installs the plugin entrypoint
     configurationFile: /etc/plugin-config/config.json

Do we have to add init containers into JaegerCommonSpec since there is new node for gRPC plugin?

I guess I only did it to match storage.Update(c.jaeger, commonSpec, &options), i.e. it only mutates commonSpec, not c.jaeger
Would you like to have func Update(jaeger *v1.Jaeger) which mutates jaeger?

Regarding the CR design. We shouldn't expose the flags directly as properties. We don't do it for any other storage. It's also better if the flags change over time.

Would you like to have func Update(jaeger *v1.Jaeger) which mutates jaeger?

Probably yes, I don't think we want to expose init containers to users.

@chlunde, if you are stuck, we can probably help you. I think this is a great feature to have in the operator.

@jpkrohling I been on vacation. I might have time this week.

@chlunde, could you rebase your PR on the latest master and force-push? The CI problems should have been fixed already.

Any progress with this PR?

I just restarted the e2e tests.

@jpkrohling did something change with the e2e/cluster/image availability?
Successfully tagged runner/jaeger-operator-demo-storage-plugin:latest

Error:     TestPluginSuite/TestPlugin: wait_util.go:67: Waiting for full availability of my-jaeger deployment (0/1)

time="2020-10-11T21:18:32Z" level=info msg="Warning events for test TestPluginSuite/TestPlugin"
time="2020-10-11T21:18:32Z" level=warning msg="Event Warning: Reason: Failed Message: Failed to pull image \"runner/jaeger-operator-demo-storage-plugin:latest\": rpc error: code = Unknown desc = Error response from daemon: pull access denied for runner/jaeger-operator-demo-storage-plugin, repository does not exist or may require 'docker login': denied: requested access to the resource is denied"
time="2020-10-11T21:18:32Z" level=warning msg="Event Warning: Reason: Failed Message: Error: ErrImagePull"
time="2020-10-11T21:18:32Z" level=warning msg="Event Warning: Reason: Failed Message: Error: ImagePullBackOff"

Not that I'm aware, but the image's namespace looks suspicious: runner/jaeger-operator-demo-storage-plugin:latest. Looking at the PR, shouldn't it be jaegertracing/jaeger-operator-demo-storage-plugin instead? Note that jaegertracing/jaeger-operator-demo-storage-plugin:latest doesn't work for me (nor does jaegertracing/jaeger-operator-demo-storage-plugin:1.20, but 1.18.1 does work).

@jpkrohling yeah, I think you pushed to 1.18.1 manually.
The runner name comes from Makefile
NAMESPACE ?= "$(USER)"

The operator itself has a similar name. Does it run as an image, or binary, for these tests?
Successfully tagged runner/jaeger-operator:latest
Skipping push, as the build is running within a CI environment

yeah, I think you pushed to 1.18.1 manually.

Right, as this image is the result of a code in this PR.

The operator itself has a similar name. Does it run as an image, or binary, for these tests?

Not sure I understood the question. Basically, we should end up using $USER only for development. In CI, it's overridden pretty much everywhere, IIRC. But @kevinearls would probably know more.

@jpkrohling I don't know who created it originally, but maybe NAMESPACE should be DOCKER_NAMESPACE or something of that sort.  By default it assumes this is the same as your username, but mine is not so I need to override it.  So in order to publish something to jaegertracing you would have to set NAMESPACE to that, and of course be logged in as that user as well.
Apparently the github tests use userid "runner", so when we build things locally they look like "runner/jaeger-operator:latest" or "runner/jaeger-operator-demo-storage-plugin:latest".  This seems to be working fine with the operator.  The misc_test that runs as part of smoke tests actually confirms that we are using what BUILD_IMAGE is set to.
I can't tell why the test is failing here though, as it works fine for me locally.  I will take another look later when my post-PTO brain fully wakes  up.

@chlunde thanks for the work. The feature was done in #1517


Move resource pool create from upload_ova.sh to deploy_vcva.py

We should move line 12 govc pool.create '*/${vmware_resource_pool}' to deploy_vcva.py for users that are not completing the Anthos prerequisites .
This is the more logical place for it any how.
We may also want to refactor upload_ova.sh to be a .py to keep consistency.

@boredabdel tagging you on this until we can add you as a collaborator and assign to you.

@paemason If someone is not deploying Anthos automatically, and we create this resource pool for them (An Anthos pre-req). Wouldn't they not know about this step in a generic VMware Env? I think keeping this behind the "Deploy Anthos" flag is best.

Discussed with with @c0dyhi11 and I agree. The creating the resource pool is part of the Anthos install and should be there for someone who wants to 'practice' the full anthos install experience. We're going to close this issue.


Upload metrics from PR CI as artifacts in GitHub Actions

We collect a lot of metrics about each CI run. In builds run by bors within the rust-lang-ci organization, we upload these metrics to S3 and make them available at https://ci-artifacts.rust-lang.org/rustc-builds/{run.sha}/metrics-{name}.json. This provides a great tool to analyze the efficiency of our builds and continually optimize them.
For builds run on pull requests in the public rust-lang organization, we don't upload the metrics to S3 because we don't want to add a token with write permissions to S3 to the public environment.
Instead of discarding the metrics after each run, we should upload them as artifacts in GitHub Actions. This will allows us to store them somewhere without having to grant the jobs any additional permissions, and download and analyze them similar to the metrics collected by bors.

Hey @jdno,
I'd like to give this a try.
I realized you mentioned "rust-lang organization public repos". Does that imply that creating a workflow file in here is enough to resolve this requirement? (and then later on, using such workflow from other repositories with uses: rust-lang/simpleinfra/github-actions/example@v1?)

Rather than a new workflow, I think that this should be added to the existing CI code. There is code at the end of src/ci/run.sh (IIRC) that uploads the metrics to S3. If we find that S3 is not available (or that we're in a PR CI run, I think that there is now a dedicated env variable that tells us that), the metrics file should instead be uploaded as a workflow artifact.

Sorry, I actually misunderstood your comment, I thought that you wanted to create a new workflow in rust-lang/rust. So yeah, it could be a workflow in simpleinfra, and then it would be added to our CI workfloe after the run step. We have to double check that the metrics file is not deleted in run.sh though and that it's available to following GHA steps.

Sorry that the issue description wasn't very specific. We only really care about the metrics from rust-lang/rust. I'm not even sure if other repositories produce similar metrics during their builds.
We already have a step that uploads documentation from the pull request builds:
- name: upload artifacts to github
  uses: actions/upload-artifact@v3
  with:
    # name is set in previous step
    name: ${{ env.DOC_ARTIFACT_NAME }}
    path: obj/artifacts/doc
    if-no-files-found: ignore
    retention-days: 5
  <<: *step

I think that we just need to add another step that uploads the files that upload-artifacts.sh would upload as well. Since that is only required for pull requests, it should have an if condition that limits it to pull request events.
And since we only need a single step, I would avoid creating a new GitHub Action for this.