Comment on reddit example in docs

The docs (very good by the way!) recommends to use the following store structure in the reddit example:
users: {
  1: {
     name: "Andrew",
   },
},
posts: {
  1: {
     id: 1,
     title: "Redux",
     author: 1,
  },
  2: {...},
},
postsBySubreddit: {
  reactjs: {
     posts: [1,2]
  },
}

Looking at that schema it seems that if you're a moderator and deletes a thread for example, you might need to dispatch 2 actions or have 2 reducers answer to the same action.
Option 1: 2 actions

DELETE_POST async which will remove it from posts
REMOVE_POST_FROM_SUBREDDIT which will remove the post from the nested postsBySubreddit list

Option 2: 1 action & 2 reducers
For that you would need to add the subreddit id to the the payload, despite probably not needing it to delete the thread itself and have an action effecting 2 reducers, which doesn't look very neat.
How about storing data like that instead:
users: {
  1: {
     name: "Andrew",
   },
},
posts: {
 reactjs: [
   {
      id: 1,
      title: "Redux,
      author: 1,
   },
  {...}
 ],
},
subreddits: {
  reactjs: {
      isFetching: false,
      didInvalidate: false,
      lastUpdated:<PHONE_NUMBER>547,
  },
}

The difference is having the child reducer keyed by the parent id, this way you only need to handle one element on delete but then you need 2 when fetching anyway (as you can see my mind changed a bit while writing the issue) to update.
How would you handle deleting/shuffling of data in the first schema?

With the schema you suggested, there is duplication of data. If the same post appears in several reddits, there is no canonical representation of it in the state.
If there is no canonical representation, implementing something like EDIT_POST becomes problematic because copies of its data can be anywhere in the state, and you'd have to update them all. This is why I don't see it as a viable solution. There should be only one copy of any model, and it should be keyed by an ID.
Note one nice thing: if you fetch a different API endpoint that still happens to include some post, it will be merged into the entity cache. This means all API endpoints “contribute to” the same local cache. With the approach you suggested, however, there is no such benefit: data is stored separately, so you can't reuse already available information if it is requested in a different context.
As for your original question, some approaches to deleting entities from an entity cached were discussed here: https://github.com/rackt/redux/issues/386#issuecomment-127051008.

In the case where elements can be present on several containers sure.
But for comments on a post for example (comments belong to one post and one post only), would you have each post id as key in the comments reducers? That seems a bit wasteful to duplicate those ids potentially thousands of times

But for comments on a post for example (comments belong to one post and one post only), would you have each post id as key in the comments reducers?

Yes, it's still easier to access a comment in the state just by its ID, without thinking which post it's attached to, and without inefficient array lookup every time we need to find it (for example, to update it). Things like optimistic updates are also easier when you separate ID list from entities.

That seems a bit wasteful to duplicate those ids potentially thousands of times

I don't understand what duplication you are referring to. Please show an example.

Let's take a random thread as an example: https://www.reddit.com/r/technology/comments/3gu9b0/lenovo_crams_unremovable_crapware_into_windows/
There are 2000+ comments at the moment on that thread. Going by the approach in the docs you would have an array of 2k+ ids in the posts reducers with id 3gu9b0 and then 2k+ new keys in the comments reducers (this is the id duplication i was referring to).
Now on your connect you would need to load all the comments and then filter the ones for that thread in the merge so if you have an object you'll need to Object.keys and then filter on that, which is going to be slower.
In that case it seems like it's whether you want faster loading vs faster editing

Going by the approach in the docs you would have an array of 2k+ ids in the posts reducers with id 3gu9b0 and then 2k+ new keys in the comments reducers (this is the id duplication i was referring to).

Why is this “duplication” harmful in any way? It's negligible in terms of memory usage. (Two 2k-keyed objects instead of one).

Now on your connect you would need to load all the comments and then filter the ones for that thread in the merge so if you have an object you'll need to Object.keys and then filter on that, which is going to be slower.

Um, why? You'd need postsIds.map(id => state.posts[id]). It's pretty efficient. Worst case, put memoization like reselect on it.

Why is this “duplication” harmful in any way? It's negligible in terms of memory usage. (Two 2k-keyed objects instead of one).

If you don't clean them and use uuids for example it can add up quickly but fair enough, it's still a fairly low amount.

Um, why? You'd need postsIds.map(id => state.posts[id]). It's pretty efficient. Worst case, put memoization like reselect on it.

Sorry if i wasn't clean enough. Getting the post is easy but getting its comments would be harder, something like:
function merge(state, dispatchActions, props) {
   const postId = props.post.id;
   const comments = Object.keys(state.comments).map((commentId) => {
     if (props.post.commentsIds.indexOf(commentId) > -1) {
        return state.comments[commentId];
     }
   });
  ....
}

But after a good night sleep I realised I would probably have the comments store be emptied on transition to a new post and only ever contains one post comments.

This:
   const postId = props.post.id;
   const comments = Object.keys(state.comments).map((commentId) => {
     if (props.post.commentsIds.indexOf(commentId) > -1) {
        return state.comments[commentId];
     }
   });

is a rather expensive way to do this:
   const postId = props.post.id;
   const post = state.posts[postId];
   const comments = post.comments.map(commentId => state.comments[commentId]);

Am I missing your pont?

But after a good night sleep I realised I would probably have the comments store be emptied on transition to a new post and only ever contains one post comments.

It depends on the app. If there are thousands of comments under every post, maybe. If there's thousand or less, I don't see the point much. You can also schedule manual garbage collection (i.e. deleting content entities that aren't referenced from anywhere) once in a while.

Cheers for the replies


Add the ability to bypass smoothing on JSON and Protobuf interfaces

As an option when integrating from other LED drivers/systems to Hyperion, it would be a useful option to bypass the "smoothing" effect that applies as part of Hyperion's LED update. It would be useful for keeping things snappy, especially when run through an interface.
The option would be default ON to respect the defaults set in Hyperion's config, but for a low-latency interface, this could be set to OFF.
E.g. as the colour changes on the external LED system, it sends a new "color" to Hyperion via protobuf. As it sends many updates rapidly, I wouldn't want it to "smooth" with the previous value to save latency cost. That. and in this scenario, the color values are already smoothed before they're sent.

(posted to Forum Development Requests area)
https://hyperion-project.org/threads/add-the-ability-to-bypass-smoothing-on-json-and-protobuf-interfaces.913/


feat: update golang-github-azure-go-autorest to 14.2.0+git20220726.711dde1

HTTP request pipeline suitable for use across multiple go-routines
Issue: https://github.com/deepin-community/sig-deepin-sysdev-team/issues/552
Log: update repo

/lgtm

/approve


Enable Format R code in Rmd

Describe the solution you'd like
Recognize the part of R code in Rmd, and format them when formatting the Rmd file.
Additional context
It is currently not quite possible to format the R code in the Rmd file with the extension, which I think is quite reasonable to have one.

Format R chunks in rmd is supported.
Could you provide an example where you find formatting not working properly?

Hm it seems work fine now. Not sure what's causing it not working before. Thanks for responding.


Question about flutter Isolate

I was using Isolate to upload files with v1.82.6 and it worked fine. But after I upgrade frb to 2.0.0.dev.21, when I use Isolate, it throws
should init Rustlib. I have inited RustLib in main function. I have 2 questions.

should I init RustLib everytime in a new Isolate?
should I dispose RustLib after works done in Isolate?

Good question - I should add the multi-isolate scenario in the tests.

I see. Thanks for the answer.


Fix a race condition in d2l-icon that can cause the wrong icon to be shown

Simplifies d2l-icon by using safe built-in Lit Element directives instead of the custom build runAsync.
This fixes a race condition in which, if an icon is set to two different new values quickly, sometimes the older of the two new values will permanently (or until the icon changes again) be rendered instead of the newer one.

Forgot to prefix the commit message with fix:. Can a version bump be manually triggered?

Forgot to prefix the commit message with fix:. Can a version bump be manually triggered?

Usually I've just seen people make an empty commit and merge another PR with the right prefix to trigger release.


utils/cups-browsed.c: Lock before all 'examine_discovered_printer_rec

…ord()'
The current code doesn't use rwlock in found_cups_printer() and
cupsdUpdateLDAPBrowse(), which causes deadlock when discovering queues
via BrowsePoll or LDAP.
It happens because the code in 'examine_discovered_printer_record()'
expects the rwlock to be locked already, so it unlocks the lock, calls
'get_local_queue_name()' and locks again.
The commit contains change '&(lock)' -> '&lock' too, it represents the
same thing, so we should use the same code for it.

Lools like that the original multi-threading code was only tested under "modern" conditions (all CUPS in local network >= 1.6.x, DNS-SD-only).
Thank you very much for fixing the legacy cases.

@tillkamppeter since there is still no other simple (you can theoretically reflect mDNS or create a container within your LAN which is basically a copy of remote server, but it is more difficult than just one-liner on cups-browsed) and full-fledged (you can set ServerName in /etc/cups/client.conf, but you cannot modify the queues unless you have permissions on the server) solution to get a print queue from a different subnet than what cups-browsed provides, we're stuck with it until we implement something new in CUPS - so it doesn't sound as a legacy case. Most users which aggregate their printers at servers in one LAN and have their PCs in other LAN use BrowsePoll.
I'm not sure about LDAP, I didn't test that one - but it looked it can suffer the same problem.


Add tensor rank expression support and nearestNeighbor for streaming search

Streaming search does currently not support using tensors in ranking expressions. There is no warning about this when deploying a rank profile with tensor expressions.
The current workaround for vector search is to use legacy dot products over an array of floats:
field embedding_vector type array<float> { indexing: summary | attribute}
Query example limited to personal data for userid=1 and for document text containing april.
/search/?yql=select%20*%20from%20sources%20*%20where%20text%20contains%20"april"&streaming.userid=1&tracelevel=0&ranking.properties.dotProduct.query=[1%202%203%204]&ranking=embedding

rank-profile embedding {
      first-phase {
        expression: dotProduct(embedding_vector, query)
      }
}

Vector streaming search is available in Vespa 8.181.15. This supports using tensors and the nearestNeighbor query operator in streaming mode.
See the blog post where the feature is announced: https://blog.vespa.ai/announcing-vector-streaming-search/
See the reference documentation for more details: https://docs.vespa.ai/en/streaming-search.html


Release the implementation of LVMOGP

The code implements the LVMOGP model for both with and without missing entries cases.
The link to the paper: https://arxiv.org/abs/1705.09862

Codecov Report

Merging #562 into devel will increase coverage by 1.14%.
The diff coverage is 86.02%.

@@            Coverage Diff             @@
##            devel     #562      +/-   ##
==========================================
+ Coverage   51.76%   52.91%   +1.14%
==========================================
  Files         195      201       +6
  Lines       19477    20114     +637
  Branches     2638     2682      +44
==========================================
+ Hits        10082    10643     +561
- Misses       8929     8984      +55
- Partials      466      487      +21


Fix VyOS Directives.

Description
Updated the directives for VyOS to work with the current LTS release.

Related Issues
https://github.com/thatmattlove/hyperglass/issues/245
This only fixes the syntax which will work with 1.4/1.5, while the issue wanted version specific syntax.

Motivation and Context

Because the directives do not work with VyOS. This fixes that.
Tests
Built fresh docker container with changes, tested all functions with v4 and v6 on VyOS 1.4.0 and 1.5 Rolling.

Great. I installed Hyperglass today and encountered this behavior. I'll follow up to validate as soon as the fix is available!


"Contact Us" section

Include a "Contact Us" section with links to Facebook and YouTube Live.

Done in upcoming commit.


Ignore fullscreen spaces in the "space indexing"

I want to be able to consistently switch between spaces with the same keybinds, but right now, when I open an app in fullscreen, it increases the space number of any space "after" that fullscreen space, messing with my muscle memory. For example, I have Spaces 1 and 2 on Monitor 1 and Spaces 3 and 4 on Monitor 2. If I open a Fullscreen app 1 on Monitor 1, now Monitor 2's spaces will have been pushed to Space 4 and 5.
My ideal solution would be a way to ignore fullscreen apps in the indexing of spaces, and then have a separate keybind to get to my fullscreen app.
Sorry if this is a question that could've been answered by reading documentation, but I couldn't find what I needed.

Something you could do is to filter the spaces that have non-fullscreen-native and those that have fullscreen-native. After you have that filter array, you could use the current space to get the index of the space you are and then move left or right in the array.
Pseudocode:
yabai query windows | filter them by fullscreen-native | form an array of distinct spaces  | yabai space focus  [index(current-space)]
I'm currently on my phone, but let me know if you need code sample and I can happily do it for you once I"m on my PC.

Thanks for the idea! I get how it works, but I'm not at all experienced writing shell scripts, so if/when you find the time, I'd really appreciate if you could write a code sample!

Here is an example of how to do it. I'm adding it here too just in case:
map(select(."is-native-fullscreen" == false) |
[.index, (if ."has-focus" then .index else empty end)]) |
[[.[][0]], .[][1] // .] as [$spaces, $focus] |
$spaces |
(index($focus)) as $idx |
.[($idx + 1)%length]

This is done with jq. Line by line, what it does is to select only the non-native-fullscreen spaces. Then we save those in an tuple that has 2 elements; first is the spaces and second one is the focused one. After that, we just get the index of the focused space and at the end, we access it (+1 means going to the right, -1 is left).
I'm assuming you are using skhd, so this is query goes in a yabai query like:
yabai -m space --focus $(yabai -m query --spaces | jq -e 'map(select(."is-native-fullscreen" == false) | [.index, (if ."has-focus" then .index else empty end)]) | [[.[][0]], .[][1] // .] as [$spaces, $focus] | $spaces | (index($focus)) as $idx | .[($idx + 1)%length]').
Now, this doesn't work when you are focused in a fullscreen-native space (because we won't have a focused index). But that's easy to fix. Let us know how you improve this, as this was done pretty quickly and can be improved. Share it with us :D

Thanks a lot for writing and sharing that!
Just got to take a look at it today, and I realized that the stuff I wanna do is complex enough that it would just be easier for me to write something in Python to handle it, so that's what I ended up doing (plus, I don't know jq at all, so I would've had to learn it).
Here's what I ended up writing. get_nonfullscreen_index() takes in an index and returns the "corrected" index when taking only non-fullscreen spaces into account. get_next_space() gets the name space (looping around if you're at the last space), taking into account what type of space you're in -- if you're in a fullscreen space, it'll go to the next fullscreen space, same for non-fullscreen. And then get_fullscreen_index() and get_previous_space() are self explanatory taking in account the things I just described.
Now I can do:

yabai -m space --focus $(/path/to/python  /path/to/spaces.py get_nonfullscreen_index 1) to get the 1st non-fullscreen index
yabai -m space --focus $(/path/to/python  /path/to/spaces.py get_fullscreen_index 1) to get the 1st fullscreen index
yabai -m space --focus $(/path/to/python  /path/to/spaces.py get_next_space) to get the next space (using my "rules")
yabai -m space --focus $(/path/to/python  /path/to/spaces.py get_previous_space) to get the previous space (using my "rules")

Still not fully sure this is the logic I want to have, but I seem to like it so far and it's definitely better than what I had before!

Thanks @hotsno for sharing this. I went with a little bit different implementation.
I use 3 displays, sometimes multiple desktops on the same display, and often also using native-fullscreen apps. I don't want native-fullscreen apps to affect my ordering, so I wrote some similar functions in order to:

move non-native windows around the spaces across displays
label spaces from specific displays accordingly (specific to the display, not space)
move window to prev/next space

all of the above regardless of me using native-fulscreen apps or not
Here's the script: https://gist.github.com/mlubej/5a8a7c477d12193c584a458b239ec8fd
Example skhd + yabai commands:
yabai -m space $(/Users/mlubej/.pyenv/versions/3.8.7/bin/python /Users/mlubej/.config/yabai/spaces.py get_first_space_from_display 1) --label main
yabai -m space $(/Users/mlubej/.pyenv/versions/3.8.7/bin/python /Users/mlubej/.config/yabai/spaces.py get_first_space_from_display 2) --label mail
yabai -m space $(/Users/mlubej/.pyenv/versions/3.8.7/bin/python /Users/mlubej/.config/yabai/spaces.py get_first_space_from_display 3) --label chat

# Move focus container to workspace
hyper - 1 : yabai -m window --space $(/Users/mlubej/.pyenv/versions/3.8.7/bin/python /Users/mlubej/.config/yabai/spaces.py get_nth_space 1)
hyper - 2 : yabai -m window --space $(/Users/mlubej/.pyenv/versions/3.8.7/bin/python /Users/mlubej/.config/yabai/spaces.py get_nth_space 2)
hyper - 3 : yabai -m window --space $(/Users/mlubej/.pyenv/versions/3.8.7/bin/python /Users/mlubej/.config/yabai/spaces.py get_nth_space 3)
hyper - 4 : yabai -m window --space $(/Users/mlubej/.pyenv/versions/3.8.7/bin/python /Users/mlubej/.config/yabai/spaces.py get_nth_space 4)
hyper - 5 : yabai -m window --space $(/Users/mlubej/.pyenv/versions/3.8.7/bin/python /Users/mlubej/.config/yabai/spaces.py get_nth_space 5)
hyper - 6 : yabai -m window --space $(/Users/mlubej/.pyenv/versions/3.8.7/bin/python /Users/mlubej/.config/yabai/spaces.py get_nth_space 6)
hyper - 0x21 : yabai -m window --space $(/Users/mlubej/.pyenv/versions/3.8.7/bin/python /Users/mlubej/.config/yabai/spaces.py get_previous_space)
hyper - 0x1E : yabai -m window --space $(/Users/mlubej/.pyenv/versions/3.8.7/bin/python /Users/mlubej/.config/yabai/spaces.py get_next_space)

# Focus after moving
hyper - f : yabai -m window --focus recent


Reporters: Improve the handling of curated license findings

The implementation of license finding curations is currently very basic:

raw findings are just replaced with curated ones
~The findings are split-up for each used AND and OR operator, that is
if a license of a finding is 'MIT AND 0BSD'  then collectLicenseFindings() splits it into
two findings with same file location, but one with 'MIT' and one with 0BSD' as license.
For the presentation there are probably better ways than this duplication.~ (Implemented already.)
~It is not shown which curation got applied to a finding. It would make sense to figure out how~ (Related ticket closed as part of backlog grooming.)
a UI presentation could look like
~OR is not yet supported by ORT and handled exactly like the AND operator, which applies also to declared and concluded licenses.~ (Implemented already.)

Closed as part of backlog grooming. Feel free to comment if you would like to contribute to this.


Fix examples: remove unused and import icons

I found unused App.vue file in /examples. Real used file in /examples/src
And unused index.js in examples, real used main.js in examples/src. Also remove duplicate json files.
And add import for 'leaflet.icon.glyph'.

@bezany the building is failing on travis, I fixed the problem on master, can you merge master in all your PR so that I can have a travis ci green-light before merging ?

@lordfuoco great! I merged with master, the building is OK on travis.


I want to run gazebo controllers with harmonic and humble

Environment

OS Version: Ubuntu 22.04
Source or binary build?

Binary Installation for ROS2 humble + Source installation of ros_gz (humble branch) + Source installation of gazebo_ros_control master branch
Description

Expected behavior: Trying to run an example script - ros2 launch gz_ros2_control_demos cart_example_position.launch.py
This should happen - https://control.ros.org/master/doc/gz_ros2_control/doc/index.html
Actual behavior:

apurv@apurv-Alienware-m15-R2:~/artefacts_ws/src$ ros2 launch gz_ros2_control_demos cart_example_position.launch.py
[INFO] [launch]: All log files can be found below /home/apurv/.ros/log/2024-01-18-15-20-10-577185-apurv-Alienware-m15-R2-52537
[INFO] [launch]: Default logging verbosity is set to INFO
[INFO] [ruby $(which gz) sim-1]: process started with pid [52538]
[INFO] [robot_state_publisher-2]: process started with pid [52540]
[INFO] [create-3]: process started with pid [52543]
[create-3] [INFO] [1705558810.756671381] [ros_gz_sim]: Requesting list of world names.
[robot_state_publisher-2] [INFO] [1705558810.784014225] [robot_state_publisher]: got segment cart
[robot_state_publisher-2] [INFO] [1705558810.784120816] [robot_state_publisher]: got segment slideBar
[robot_state_publisher-2] [INFO] [1705558810.784130449] [robot_state_publisher]: got segment world
[ruby $(which gz) sim-1]
[ruby $(which gz) sim-1] Using deprecated environment variable [IGN_GAZEBO_RESOURCE_PATH].
[ruby $(which gz) sim-1] Please use [GZ_SIM_RESOURCE_PATH] instead.
[ruby $(which gz) sim-1] [Dbg] [gz.cc:166] Subscribing to [/gazebo/starting_world].
[ruby $(which gz) sim-1] [Dbg] [gz.cc:168] Waiting for a world to be set from the GUI...
[ruby $(which gz) sim-1] [Msg] Received world [empty.sdf] from the GUI.
[ruby $(which gz) sim-1] [Dbg] [gz.cc:172] Unsubscribing from [/gazebo/starting_world].
[ruby $(which gz) sim-1] [Msg] Gazebo Sim Server v8.0.0
[ruby $(which gz) sim-1] [Msg] Loading SDF world file[/usr/share/gz/gz-sim8/worlds/empty.sdf].
[ruby $(which gz) sim-1] [Msg] Serving entity system service on [/entity/system/add]
[ruby $(which gz) sim-1] [Dbg] [Physics.cc:860] Loaded [gz::physics::dartsim::Plugin] from library [/usr/lib/x86_64-linux-gnu/gz-physics-7/engine-plugins/libgz-physics-dartsim-plugin.so]
[ruby $(which gz) sim-1] [Dbg] [SystemManager.cc:74] Loaded system [gz::sim::systems::Physics] for entity [1]
[ruby $(which gz) sim-1] [Msg] Create service on [/world/empty/create]
[ruby $(which gz) sim-1] [Msg] Remove service on [/world/empty/remove]
[ruby $(which gz) sim-1] [Msg] Pose service on [/world/empty/set_pose]
[ruby $(which gz) sim-1] [Msg] Pose service on [/world/empty/set_pose_vector]
[ruby $(which gz) sim-1] [Msg] Light configuration service on [/world/empty/light_config]
[ruby $(which gz) sim-1] [Msg] Physics service on [/world/empty/set_physics]
[ruby $(which gz) sim-1] [Msg] SphericalCoordinates service on [/world/empty/set_spherical_coordinates]
[ruby $(which gz) sim-1] [Msg] Enable collision service on [/world/empty/enable_collision]
[ruby $(which gz) sim-1] [Msg] Disable collision service on [/world/empty/disable_collision]
[ruby $(which gz) sim-1] [Msg] Material service on [/world/empty/visual_config]
[ruby $(which gz) sim-1] [Msg] Material service on [/world/empty/wheel_slip]
[ruby $(which gz) sim-1] [Dbg] [SystemManager.cc:74] Loaded system [gz::sim::systems::UserCommands] for entity [1]
[ruby $(which gz) sim-1] [Dbg] [SystemManager.cc:74] Loaded system [gz::sim::systems::SceneBroadcaster] for entity [1]
[ruby $(which gz) sim-1] [Dbg] [SystemManager.cc:74] Loaded system [gz::sim::systems::Contact] for entity [1]
[ruby $(which gz) sim-1] [Msg] Loaded level [3]
[ruby $(which gz) sim-1] [Msg] Serving world controls on [/world/empty/control], [/world/empty/control/state] and [/world/empty/playback/control]
[ruby $(which gz) sim-1] [Msg] Serving GUI information on [/world/empty/gui/info]
[ruby $(which gz) sim-1] [Msg] World [empty] initialized with [1ms] physics profile.
[ruby $(which gz) sim-1] [Msg] Serving world SDF generation service on [/world/empty/generate_world_sdf]
[ruby $(which gz) sim-1] [Msg] Serving world names on [/gazebo/worlds]
[ruby $(which gz) sim-1] [Msg] Resource path add service on [/gazebo/resource_paths/add].
[ruby $(which gz) sim-1] [Msg] Resource path get service on [/gazebo/resource_paths/get].
[ruby $(which gz) sim-1] [Msg] Resource path resolve service on [/gazebo/resource_paths/resolve].
[create-3] [ERROR] [1705558811.319355172] [ros_gz_sim]: Must specify either -file, -param, -stdin or -topic
[ERROR] [create-3]: process has died [pid 52543, exit code 255, cmd '/home/apurv/artefacts_ws/src/install/ros_gz_sim/lib/ros_gz_sim/create --ros-args --params-file /tmp/launch_params_ddwn3yon'].
[INFO] [ros2-4]: process started with pid [52610]
[ruby $(which gz) sim-1] [GUI] [Wrn] [Application.cc:904] [QT] file::/EntityContextMenuPlugin/EntityContextMenuPlugin.qml:52:3: QML RenderWindowOverlay: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
[ruby $(which gz) sim-1] [GUI] [Wrn] [Application.cc:904] [QT] file::/EntityContextMenuPlugin/EntityContextMenuPlugin.qml:67:3: QML EntityContextMenu: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
[ruby $(which gz) sim-1] [GUI] [Wrn] [Application.cc:904] [QT] file::/EntityContextMenuPlugin/EntityContextMenuPlugin.qml:52:3: QML RenderWindowOverlay: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
[ruby $(which gz) sim-1] [GUI] [Wrn] [Application.cc:904] [QT] file::/EntityContextMenuPlugin/EntityContextMenuPlugin.qml:67:3: QML EntityContextMenu: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
[ruby $(which gz) sim-1] [GUI] [Wrn] [Application.cc:904] [QT] file::/EntityContextMenuPlugin/EntityContextMenuPlugin.qml:52:3: QML RenderWindowOverlay: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
[ruby $(which gz) sim-1] [GUI] [Wrn] [Application.cc:904] [QT] file::/EntityContextMenuPlugin/EntityContextMenuPlugin.qml:67:3: QML EntityContextMenu: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
[ruby $(which gz) sim-1] [GUI] [Wrn] [Application.cc:904] [QT] file::/EntityContextMenuPlugin/EntityContextMenuPlugin.qml:52:3: QML RenderWindowOverlay: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
[ruby $(which gz) sim-1] [GUI] [Wrn] [Application.cc:904] [QT] file::/EntityContextMenuPlugin/EntityContextMenuPlugin.qml:67:3: QML EntityContextMenu: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
[ruby $(which gz) sim-1] [GUI] [Wrn] [Application.cc:904] [QT] file::/EntityContextMenuPlugin/EntityContextMenuPlugin.qml:52:3: QML RenderWindowOverlay: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
[ruby $(which gz) sim-1] [GUI] [Wrn] [Application.cc:904] [QT] file::/EntityContextMenuPlugin/EntityContextMenuPlugin.qml:67:3: QML EntityContextMenu: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
[ruby $(which gz) sim-1] [GUI] [Wrn] [Application.cc:904] [QT] file::/EntityContextMenuPlugin/EntityContextMenuPlugin.qml:52:3: QML RenderWindowOverlay: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
[ruby $(which gz) sim-1] [GUI] [Wrn] [Application.cc:904] [QT] file::/EntityContextMenuPlugin/EntityContextMenuPlugin.qml:67:3: QML EntityContextMenu: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
[ruby $(which gz) sim-1] [Msg] [Msg] Gazebo Sim GUI    v8.0.0
[ruby $(which gz) sim-1] [Dbg] [Gui.cc:263] Waiting for subscribers to [/gazebo/starting_world]...
[ruby $(which gz) sim-1] [Dbg] [Application.cc:101] Initializing application.
[ruby $(which gz) sim-1] [Dbg] [Application.cc:175] Qt using OpenGL graphics interface
[ruby $(which gz) sim-1] [GUI] [Dbg] [Application.cc:662] Create main window
[ruby $(which gz) sim-1] [GUI] [Dbg] [PathManager.cc:68] Requesting resource paths through [/gazebo/resource_paths/get]
[ruby $(which gz) sim-1] [GUI] [Dbg] [Gui.cc:343] GUI requesting list of world names. The server may be busy downloading resources. Please be patient.
[ruby $(which gz) sim-1] [GUI] [Dbg] [PathManager.cc:57] Received resource paths.
[ruby $(which gz) sim-1] [GUI] [Dbg] [Gui.cc:401] Requesting GUI from [/world/empty/gui/info]...
[ruby $(which gz) sim-1] [GUI] [Dbg] [GuiRunner.cc:149] Requesting initial state from [/world/empty/state]...
[ruby $(which gz) sim-1] [GUI] [Msg] Loading config [/home/apurv/.gz/sim/8/gui.config]
[ruby $(which gz) sim-1] [GUI] [Dbg] [Application.cc:533] Loading plugin [MinimalScene]
[ruby $(which gz) sim-1] [GUI] [Dbg] [MinimalScene.cc:800] Creating gz-rendering interface for OpenGL
[ruby $(which gz) sim-1] [GUI] [Dbg] [MinimalScene.cc:800] Creating gz-rendering interface for OpenGL
[ruby $(which gz) sim-1] [GUI] [Dbg] [MinimalScene.cc:982] Creating render thread interface for OpenGL
[ruby $(which gz) sim-1] [GUI] [Dbg] [MinimalScene.cc:800] Creating gz-rendering interface for OpenGL
[ruby $(which gz) sim-1] [GUI] [Dbg] [MinimalScene.cc:982] Creating render thread interface for OpenGL
[ruby $(which gz) sim-1] [GUI] [Msg] Added plugin [3D View] to main window
[ruby $(which gz) sim-1] [GUI] [Msg] Loaded plugin [MinimalScene] from path [/usr/lib/x86_64-linux-gnu/gz-gui-8/plugins/libMinimalScene.so]
[ruby $(which gz) sim-1] [GUI] [Dbg] [Application.cc:533] Loading plugin [EntityContextMenuPlugin]
[ruby $(which gz) sim-1] [GUI] [Msg] Added plugin [Entity Context Menu] to main window
[ruby $(which gz) sim-1] [GUI] [Msg] Loaded plugin [EntityContextMenuPlugin] from path [/usr/lib/x86_64-linux-gnu/gz-sim-8/plugins/gui/libEntityContextMenuPlugin.so]
[ruby $(which gz) sim-1] [GUI] [Dbg] [Application.cc:533] Loading plugin [GzSceneManager]
[ruby $(which gz) sim-1] [GUI] [Msg] Added plugin [Scene Manager] to main window
[ruby $(which gz) sim-1] [GUI] [Msg] Loaded plugin [GzSceneManager] from path [/usr/lib/x86_64-linux-gnu/gz-sim-8/plugins/gui/libGzSceneManager.so]
[ruby $(which gz) sim-1] [GUI] [Dbg] [Application.cc:533] Loading plugin [InteractiveViewControl]
[ruby $(which gz) sim-1] [GUI] [Msg] Camera view controller topic advertised on [/gui/camera/view_control]
[ruby $(which gz) sim-1] [GUI] [Msg] Camera reference visual topic advertised on [/gui/camera/view_control/reference_visual]
[ruby $(which gz) sim-1] [GUI] [Msg] Camera view control sensitivity advertised on [/gui/camera/view_control/sensitivity]
[ruby $(which gz) sim-1] [GUI] [Msg] Added plugin [Interactive view control] to main window
[ruby $(which gz) sim-1] [GUI] [Msg] Loaded plugin [InteractiveViewControl] from path [/usr/lib/x86_64-linux-gnu/gz-gui-8/plugins/libInteractiveViewControl.so]
[ruby $(which gz) sim-1] [GUI] [Dbg] [Application.cc:533] Loading plugin [CameraTracking]
[ruby $(which gz) sim-1] [GUI] [Msg] Added plugin [Camera tracking] to main window
[ruby $(which gz) sim-1] [GUI] [Msg] Loaded plugin [CameraTracking] from path [/usr/lib/x86_64-linux-gnu/gz-gui-8/plugins/libCameraTracking.so]
[ruby $(which gz) sim-1] [GUI] [Dbg] [Application.cc:533] Loading plugin [MarkerManager]
[ruby $(which gz) sim-1] [GUI] [Msg] Listening to stats on [/world/empty/stats]
[ruby $(which gz) sim-1] [GUI] [Msg] Added plugin [Marker Manager] to main window
[ruby $(which gz) sim-1] [GUI] [Msg] Loaded plugin [MarkerManager] from path [/usr/lib/x86_64-linux-gnu/gz-gui-8/plugins/libMarkerManager.so]
[ruby $(which gz) sim-1] [GUI] [Dbg] [Application.cc:533] Loading plugin [SelectEntities]
[ruby $(which gz) sim-1] [GUI] [Msg] Added plugin [Select entities] to main window
[ruby $(which gz) sim-1] [GUI] [Msg] Loaded plugin [SelectEntities] from path [/usr/lib/x86_64-linux-gnu/gz-sim-8/plugins/gui/libSelectEntities.so]
[ruby $(which gz) sim-1] [GUI] [Dbg] [Application.cc:533] Loading plugin [Spawn]
[ruby $(which gz) sim-1] [GUI] [Msg] Added plugin [Spawn] to main window
[ruby $(which gz) sim-1] [GUI] [Msg] Loaded plugin [Spawn] from path [/usr/lib/x86_64-linux-gnu/gz-sim-8/plugins/gui/libSpawn.so]
[ruby $(which gz) sim-1] [GUI] [Dbg] [Application.cc:533] Loading plugin [VisualizationCapabilities]
[ruby $(which gz) sim-1] [GUI] [Msg] View as transparent service on [/gui/view/transparent]
[ruby $(which gz) sim-1] [GUI] [Msg] View as wireframes service on [/gui/view/wireframes]
[ruby $(which gz) sim-1] [GUI] [Msg] View center of mass service on [/gui/view/com]
[ruby $(which gz) sim-1] [GUI] [Msg] View inertia service on [/gui/view/inertia]
[ruby $(which gz) sim-1] [GUI] [Msg] View collisions service on [/gui/view/collisions]
[ruby $(which gz) sim-1] [GUI] [Msg] View joints service on [/gui/view/joints]
[ruby $(which gz) sim-1] [GUI] [Msg] View frames service on [/gui/view/frames]
[ruby $(which gz) sim-1] [GUI] [Msg] Added plugin [Visualization capabilities] to main window
[ruby $(which gz) sim-1] [GUI] [Msg] Loaded plugin [VisualizationCapabilities] from path [/usr/lib/x86_64-linux-gnu/gz-sim-8/plugins/gui/libVisualizationCapabilities.so]
[ruby $(which gz) sim-1] [GUI] [Dbg] [Application.cc:533] Loading plugin [WorldControl]
[ruby $(which gz) sim-1] [GUI] [Msg] Using world control service [/world/empty/control]
[ruby $(which gz) sim-1] [GUI] [Msg] Listening to stats on [/world/empty/stats]
[ruby $(which gz) sim-1] [GUI] [Dbg] [WorldControl.cc:250] Using an event to share WorldControl msgs with the server
[ruby $(which gz) sim-1] [GUI] [Msg] Added plugin [World control] to main window
[ruby $(which gz) sim-1] [GUI] [Wrn] [Application.cc:904] [QT] file::/EntityTree/EntityTree.qml:148:7: QML ToolButton: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
[ruby $(which gz) sim-1] [GUI] [Msg] Loaded plugin [WorldControl] from path [/usr/lib/x86_64-linux-gnu/gz-gui-8/plugins/libWorldControl.so]
[ruby $(which gz) sim-1] [GUI] [Dbg] [Application.cc:533] Loading plugin [WorldStats]
[ruby $(which gz) sim-1] [GUI] [Msg] Listening to stats on [/world/empty/stats]
[ruby $(which gz) sim-1] [GUI] [Msg] Added plugin [World stats] to main window
[ruby $(which gz) sim-1] [GUI] [Msg] Loaded plugin [WorldStats] from path [/usr/lib/x86_64-linux-gnu/gz-gui-8/plugins/libWorldStats.so]
[ruby $(which gz) sim-1] [GUI] [Dbg] [Application.cc:533] Loading plugin [Shapes]
[ruby $(which gz) sim-1] [GUI] [Msg] Added plugin [Shapes] to main window
[ruby $(which gz) sim-1] [GUI] [Msg] Loaded plugin [Shapes] from path [/usr/lib/x86_64-linux-gnu/gz-sim-8/plugins/gui/libShapes.so]
[ruby $(which gz) sim-1] [GUI] [Dbg] [Application.cc:533] Loading plugin [Lights]
[ruby $(which gz) sim-1] [GUI] [Msg] Added plugin [Lights] to main window
[ruby $(which gz) sim-1] [GUI] [Msg] Loaded plugin [Lights] from path [/usr/lib/x86_64-linux-gnu/gz-sim-8/plugins/gui/libLights.so]
[ruby $(which gz) sim-1] [GUI] [Dbg] [Application.cc:533] Loading plugin [TransformControl]
[ruby $(which gz) sim-1] [GUI] [Msg] Added plugin [Transform control] to main window
[ruby $(which gz) sim-1] [GUI] [Msg] Loaded plugin [TransformControl] from path [/usr/lib/x86_64-linux-gnu/gz-sim-8/plugins/gui/libTransformControl.so]
[ruby $(which gz) sim-1] [GUI] [Dbg] [Application.cc:533] Loading plugin [Screenshot]
[ruby $(which gz) sim-1] [GUI] [Msg] Screenshot service on [/gui/screenshot]
[ruby $(which gz) sim-1] [GUI] [Msg] Added plugin [Screenshot] to main window
[ruby $(which gz) sim-1] [GUI] [Msg] Loaded plugin [Screenshot] from path [/usr/lib/x86_64-linux-gnu/gz-gui-8/plugins/libScreenshot.so]
[ruby $(which gz) sim-1] [GUI] [Dbg] [Application.cc:533] Loading plugin [CopyPaste]
[ruby $(which gz) sim-1] [GUI] [Msg] Added plugin [Copy/Paste] to main window
[ruby $(which gz) sim-1] [GUI] [Msg] Loaded plugin [CopyPaste] from path [/usr/lib/x86_64-linux-gnu/gz-sim-8/plugins/gui/libCopyPaste.so]
[ruby $(which gz) sim-1] [GUI] [Dbg] [Application.cc:533] Loading plugin [ComponentInspector]
[ruby $(which gz) sim-1] [GUI] [Msg] Added plugin [Component inspector] to main window
[ruby $(which gz) sim-1] [GUI] [Msg] Loaded plugin [ComponentInspector] from path [/usr/lib/x86_64-linux-gnu/gz-sim-8/plugins/gui/libComponentInspector.so]
[ruby $(which gz) sim-1] [GUI] [Dbg] [Application.cc:533] Loading plugin [EntityTree]
[ruby $(which gz) sim-1] [GUI] [Msg] Added plugin [Entity tree] to main window
[ruby $(which gz) sim-1] [GUI] [Msg] Loaded plugin [EntityTree] from path [/usr/lib/x86_64-linux-gnu/gz-sim-8/plugins/gui/libEntityTree.so]
[ruby $(which gz) sim-1] [GUI] [Dbg] [Application.cc:403] Loading window config
[ruby $(which gz) sim-1] [GUI] [Msg] Using server control service [/server_control]
[ruby $(which gz) sim-1] [GUI] [Wrn] [Application.cc:904] [QT] file::/EntityTree/EntityTree.qml:148:7: QML ToolButton: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
[ruby $(which gz) sim-1] [GUI] [Wrn] [Application.cc:904] [QT] file::/WorldStats/WorldStats.qml:53:3: QML RowLayout: Binding loop detected for property "x"
[ruby $(which gz) sim-1] [GUI] [Wrn] [Application.cc:904] [QT] file::/EntityContextMenuPlugin/EntityContextMenuPlugin.qml:52:3: QML RenderWindowOverlay: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
[ruby $(which gz) sim-1] [GUI] [Wrn] [Application.cc:904] [QT] file::/EntityContextMenuPlugin/EntityContextMenuPlugin.qml:67:3: QML EntityContextMenu: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
[ruby $(which gz) sim-1] libEGL warning: egl: failed to create dri2 screen
[ruby $(which gz) sim-1] libEGL warning: egl: failed to create dri2 screen
[ruby $(which gz) sim-1] [Wrn] [Component.hh:144] Trying to serialize component with data type [N3sdf3v145WorldE], which doesn't have `operator<<`. Component will not be serialized.
[ruby $(which gz) sim-1] [GUI] [Wrn] [Component.hh:189] Trying to deserialize component with data type [N3sdf3v145WorldE], which doesn't have `operator>>`. Component will not be deserialized.
[ros2-4] Could not contact service /controller_manager/load_controller
[ERROR] [ros2-4]: process has died [pid 52610, exit code 1, cmd 'ros2 control load_controller --set-state active joint_state_broadcaster'].

[INFO] [launch]: process[ruby $(which gz) sim-1] was required: shutting down launched system

I don't see the model spawning.
Steps to reproduce

Get the above environment and run - ros2 launch gz_ros2_control_demos cart_example_position.launch.py

Output

I assume you meant https://github.com/ros-controls/gz_ros2_control instead of https://github.com/ros-controls/gazebo_ros2_control. I believe the master branch is making use of changes inros_gz that are only available in rolling https://github.com/ros-controls/gz_ros2_control/pull/211, so you'll also need to use the humble branch for gz_ros2_control as well.

I have tried the humble branch, and it gives me the same error that I posted above.

Basically, this is the problem
[ruby $(which gz) sim-1] [INFO] [1706429551.323616584] [controller_manager]: Loading controller 'joint_state_broadcaster'
[ruby $(which gz) sim-1] [ERROR] [1706429551.323757245] [controller_manager]: Loader for controller 'joint_state_broadcaster' (type 'joint_state_broadcaster/JointStateBroadcaster') not found.
[ruby $(which gz) sim-1] [INFO] [1706429551.323796786] [controller_manager]: Available classes:
[ruby $(which gz) sim-1] [INFO] [1706429551.323854688] [controller_manager]:   controller_manager/test_controller
[ruby $(which gz) sim-1] [INFO] [1706429551.323873620] [controller_manager]:   controller_manager/test_controller_failed_init
[ruby $(which gz) sim-1] [INFO] [1706429551.323884612] [controller_manager]:   controller_manager/test_controller_with_interfaces
[ruby $(which gz) sim-1] [INFO] [1706429551.323898151] [controller_manager]:   controller_manager/test_chainable_controller

@Apurv354 you need to install the dependency
sudo apt-get install ros-humble-joint-state-broadcaster

or run rosdep

How did you solved this issue, I tried humble branch but it only has ign_ros2_control package and not gz_ros2_control. I build it but when it only works with fortress and not harmonic


npm package

Is there any hesitation to publish an npm package?

No problem. But would you like to use the lib with webpack?

I am not using webpack at this point in time. I could probably be convinced to use webpack, but it would not be an immediate transition.

+1 to this.  You already have the package.json file. You just need to npm publish it :)

Done


Implemented HashMap::try_insert

Follow up on #58.

This change is

Ah, I saw just now that the existing insert method has docs similar to the ones I just had you rewrite :p Maybe we should update the insert docs to match the style of the new try_insert docs while we're at it?

Ah, I saw just now that the existing insert method has docs similar to the ones I just had you rewrite :p Maybe we should update the insert docs to match the style of the new try_insert docs while we're at it?

Exactly! Gonna work on this.

I don't really know why the linting test is failing. I've already runned cargo fmt.

#76 has now landed!

All done I think.

I still think we should use the TryInsertError struct I proposed earlier, since currently the user has no way to recover the value (or key) they provided in the case of a failed insert.

See https://github.com/jonhoo/flurry/pull/77 for a way to recover the value.

I still think we should use the TryInsertError struct I proposed earlier, since currently the user has no way to recover the value (or key) they provided in the case of a failed insert.

I'm not quite sold on this proposal. Although it does provide some useful functionality which is not provided in our current public API, I seems a bit cumbersome and unergonomic.
Also, since this is a public API, we'd probably have to implement the ? operator for it, besides some traits for useful conversions.

I think functionally the error is similar to a CompareAndSetError, so that would maybe be another argument for going with a similar implementation as well (CompareAndSetError does contain both old and new value).
@GarkGarcia what traits exactly would you propose to implement if we went with a custom error?

@GarkGarcia Ah, so, to be clear, my proposal is:
pub fn try_insert(..) -> Result<&'g T, TryInsertError<'g, T>> { .. }

Which should work just fine with ?.

@GarkGarcia Ah, so, to be clear, my proposal is:
pub fn try_insert(..) -> Result<&'g T, TryInsertError<'g, T>> { .. }

Which should work just fine with ? since we're still using Result.

Ohh I see. Seems quite reasonable then.

I think functionally the error is similar to a CompareAndSetError, so that would maybe be another argument for going with a similar implementation as well (CompareAndSetError does contain both old and new value).

Fair enought.

@GarkGarcia what traits exactly would you propose to implement if we went with a custom error?

Mainly Error, Display and Debug, but also Clone, PartialEq and Eq whenever possible.

I don't know why the linting tests are failing, I already run cargo fmt.
Also, maybe we should make the fields of TryInsertError private. That would make it so that users can only construct an instance of TryInsertError through  the try_insert methods. We could then allow access to those fields through getters. We would then have to adapt the example of HashMap::try_insert though.

 That's what the CI task checks against.
Regarding the fields, I don't actually know; can you destructure a struct if it's fields are private? I would like the user to be able to do
match map.try_insert(&i, value, &guard) {
	Ok(new) => {...},
	Err(TryInsertError { old, not_inserted } ) => {...}
}

Regarding the fields, I don't actually know; can you destructure a struct if it's fields are private? I would like the user to be able to do
match map.try_insert(&i, value, &guard) {
	Ok(new) => {...},
	Err(TryInsertError { old, not_inserted } ) => {...}
}

Nope, you can't. I think you can deconstruct them inside the matches! macro, but I'm not sure and that's pretty limited anyway.

 That's what the CI task checks against.

Just did it:
$ cargo fmt --all -- --check
Diff in ~/Documents/flurry/src/map.rs at line 135:

 #[derive(Eq, PartialEq, Clone, Debug)]
 enum PutResult<'a, T> {
-    Inserted {
-        new: &'a T,
-    },
-    Replaced {
-        old: &'a T,
-        new: &'a T,
-    },
-    Exists {
-        old: &'a T,
-        not_inserted: Box<T>,
-    },
+    Inserted { new: &'a T },
+    Replaced { old: &'a T, new: &'a T },
+    Exists { old: &'a T, not_inserted: Box<T> },
 }

 impl<'a, T> PutResult<'a, T> {

Dunno why cargo fmt hasn't fixed it by itself. Anyway, on my way to fixing it.

Nope, you can't. I think you can deconstruct them inside the matches! macro, but I'm not sure and that's pretty limited anyway.

Then I'm against making them private. I think it's not worth for them to be private if we lose the destructuring

Nope, you can't. I think you can deconstruct them inside the matches! macro, but I'm not sure and that's pretty limited anyway.

Then I'm against making them private. I think it's not worth for them to be private if we lose the destructuring

Makes sence. @jonhoo what do you think?

I am strongly in favor of both fields being public. We could mark it #[non_exhaustive], but I don't think even that's necessary.

I am strongly in favor of both fields being public. We could mark it #[non_exhaustive], but I don't think even that's necessary.

Alright, public it is. Marking things as #[non_exhaustive] is good practice.
I guess the only things left to do are:

Polishing the documentation of TryInsertError and TryInsertResult.
Implementing Display and Error for TryInsertError.

The biggest downside of #[non_exhaustive] is that people now must match on TryInsertError with , .., which is a bit of an ergonomic penalty. I guess the question is how likely we think it is that we'll want to change it later. I think it's fairly unlikely..?

The biggest downside of #[non_exhaustive] is that people now must match on TryInsertError with , .., which is a bit of an ergonomic penalty. I guess the question is how likely we think it is that we'll want to change it later. I think it's fairly unlikely..?

Fair enough. Seems unlikely indeed.

Thanks @jonhoo and @domenicquirl  for the help!

Thanks for taking the time to implement it, and to follow up on all our nitpicking :sweat_smile:


Update the status of replication job in database when fail to summit the job to jobservice

Update the status of job:
https://github.com/vmware/harbor/blob/master/src/replication/replicator/replicator.go#L121
And need to handle the situation that the mapping relationship isn't saved successfully here:
https://github.com/vmware/harbor/blob/master/src/replication/replicator/replicator.go#L126

Maybe same issue exists in scan job.

Fixed.


Create a Route for CityGram

Create an API for providing data to CityGram. See: https://github.com/citygram/citygram-services

I'm starting to look at this here -> https://github.com/codeforhawaii/citygram-services

Done in codeforhawaii/citygram-services@e8c83b43db62c06c71ad873e0fbf81716f92ae48


Local dev environment

Are there any instructions for getting this running locally? Does it all run off of a single dev database? Give me information please.


Migrate all Closure's to Action's

Any chance we could have you guys migrate all existing Closure's to using Action's instead? Would make Kotlin integration a bit easier.

The newest release available on maven central https://search.maven.org/artifact/org.jfrog.buildinfo/build-info-extractor-gradle/4.23.4/jar contains the merged pr https://github.com/jfrog/build-info/pull/441/files. This issue should now be closed marked fixed.


o.e.r.sail.shacl.planNodes.Tuple.compareTo() doesn't properly handle tuples of different length

o.e.r.sail.shacl.planNodes.Tuple.compareTo() should report shorter tuples as lesser than longer ones. The current implementation report them as equal, resulting in unstable sorts, sensitive to hash-induced ordering.
How to reproduce
assertThat(new Tuple(RDF.FIRST)).isLessThan(new Tuple(RDF.FIRST, RDF.REST))

Notes
Fixed by replacing:
return 0;

with:
return Integer.compare(line.size(), o.line.size());

at the end of the method.

A a side remark, the use of the non-final/constant line field in .equals()/.hashCode().compareTo() could lead to inconsistencies if Tuple objects are modified after being inserted into a collection.


Fix missing "Restart TS Server" command in Command Palette

Fixes https://github.com/microsoft/vscode/issues/210649

Problem
Some of the TypeScript extension command rely on certain context keys being updated.
Due to changes made in https://github.com/microsoft/vscode/pull/201847 this logic was updated in activeJsTsEditorTracker to find active editors using tabs, so we can set the right context keys even if you've got the typescript files open in the diff view, and other scenarios.
However, because the logic was being run on text editor events, it seems that the state of the vscode.window.tabGroups.activeTabGroup was not always correct, resulting in the wrong editor being chosen.
As such, you might have a typescript editor open, but the commands wouldn't show up.
Fix
This PR adds a subscription to the tabGroups.onDidChangeTabGroups event, so that when the ActiveJsTsEditorTracker.update() method is run, the activeTabGroup state has already been updated correctly.

@microsoft-github-policy-service agree

cloneapp2024

Thanks. Will be in the first 1.93 insiders build we release later this week


[FLINK-36840][table] Add correct call syntax for functions without ()

Backport of https://github.com/apache/flink/pull/25733

What is the purpose of the change
For Table API, there are 5 time-related functions that can't be called right now. This maps these the function calls for CURRENT_DATE, LOCALTIMESTAMP, LOCALTIME, CURRENT_TIMESTAMP, CURRENT_TIME currectly. These function do not support parenthesis when being called.
Brief change log

Add NO_PARENTHESIS call syntax
Use it for CURRENT_DATE, LOCALTIMESTAMP, LOCALTIME, CURRENT_TIMESTAMP, CURRENT_TIME
Update serialization tests

Verifying this change
This change added tests and can be verified as follows:

Added serialization tests to make sure the table api call get's mapped to the proper SQL Function

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): yes
The serializers: don't know
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no

Does the old syntax with () still work?

It never did. We might change that in another ticket. But right now, these five functions can only be called without parenthesis.

Does the old syntax with () still work?

It never did. We might change that in another ticket. But right now, these five functions can only be called without parenthesis.

Sorry for the confusion.  I meant to ask, after this change, do both syntaxes work?

I meant to ask, after this change, do both syntaxes work?

no, this change is only about serialization of table api calls to correct (working) SQL
before the change it serialized to function calls with () which currently doesn't work (and didn't work in previous Flink versions)

Does the old syntax with () still work?

It never did. We might change that in another ticket. But right now, these five functions can only be called without parenthesis.

Sorry for the confusion. I meant to ask, after this change, do both syntaxes work?

What @snuyanzin said 👍 I'll look into making them also work with () in SQL, but we first wanted to mitigate the issue and make sure users can use the functions with table api

one finding which I think should be covered in follow-up issues.
Just noticed if you try to execute any from those 5 functions in FlinkSQL with () then the error message is wrong
select current_date();
[ERROR] Could not execute SQL statement. Reason:
org.apache.calcite.sql.validate.SqlValidatorException: No match found for function signature CURRENT_DATE().
Supported signatures are:
'CURRENT_DATE()'


Create a minimal variant of the image

This image packs a lot of features, but they should not be always needed. It would be nice to have a minimal variant of this image.

Done as https://github.com/felipecrs/jenkins-agent-dind/pull/97.


LED: Add menu to select the triggering mode.

This allows user to set a LED to blink on CPU, Disk, etc...

Hi,
I tweaked a bit the LED component to let user decide the triggering mode.
Could you please take a look at commit number 2?
https://github.com/SAtacker/beagle-config/pull/18/commits/4835491f194a1374e36aa4e76db9f03dbd9db5e9


DefectDojo docker deployment not work

Issue Type

[x] Bug
[ ] Enhancement

Description
I struggle with the DefectDojo Docker setup, so this problems relates as well to the https://github.com/aaronweaver/docker-DefectDojo project.

The entry-command of the appsecpipeline/django-defectdojo container executes docker-startup.bash with the wrong path(see docker-compose.yml). --> set the path to "/opt/django-DefectDojo/docker/docker-startup.bash"
docker-startup.bash needs the argument "setup" at first execution for creating the setup-functions(via dojo-shared-resources) that are later called. --> bash /opt/django-DefectDojo/docker/docker-startup.bash setup
Creating a venv is not possible because the needed command is not found. --> added "apt-get install -y virtualenv"
I got the message: "Error loading MySQLdb module: No module named MySQLdb.Did you install mysqlclient or MySQL-python?" So, the Python venv is created successfully and the script is sourcing the venv. But the following "pip install ." seems still to refer to the default /usr/bin path. --> Going with docker exec into the container and manually install the requirements in the created venv fixed this (at least temporarly for testing..)
From there going to the next Issue: "/dojo-data.bash: No such file or directory". The script calls "DOCKER_DIR/dojo-data.bash". i dont know where DOCKER_DIR is defined.. it is just empty..

And this are still not all of the problems i got while trying to deploy DefectDojo.. the whole process feels buggy..
Am I the only one who have to fight extremely with this setup?! Or am i doing something completely wrong?
Operating System
Ubuntu 16.04
Install

[ ] setup.bash
[x] docker

DefectDojo Version
latest
Steps to Reproduce
git clone https://github.com/aaronweaver/docker-DefectDojo
bash setup.bash
docker-compose up
Console Logs (optional)
Traceback (most recent call last):
File "manage.py", line 10, in
execute_from_command_line(sys.argv)
File "/opt/django-DefectDojo/venv/local/lib/python2.7/site-packages/django/core/management/init.py", line 364, in execute_from_command_line
utility.execute()
File "/opt/django-DefectDojo/venv/local/lib/python2.7/site-packages/django/core/management/init.py", line 338, in execute
django.setup()
File "/opt/django-DefectDojo/venv/local/lib/python2.7/site-packages/django/init.py", line 27, in setup
apps.populate(settings.INSTALLED_APPS)
File "/opt/django-DefectDojo/venv/local/lib/python2.7/site-packages/django/apps/registry.py", line 108, in populate
app_config.import_models()
File "/opt/django-DefectDojo/venv/local/lib/python2.7/site-packages/django/apps/config.py", line 202, in import_models
self.models_module = import_module(models_module_name)
File "/usr/lib/python2.7/importlib/init.py", line 37, in import_module
import(name)
File "/opt/django-DefectDojo/venv/local/lib/python2.7/site-packages/django/contrib/auth/models.py", line 4, in
from django.contrib.auth.base_user import AbstractBaseUser, BaseUserManager
File "/opt/django-DefectDojo/venv/local/lib/python2.7/site-packages/django/contrib/auth/base_user.py", line 52, in
class AbstractBaseUser(models.Model):
File "/opt/django-DefectDojo/venv/local/lib/python2.7/site-packages/django/db/models/base.py", line 124, in new
new_class.add_to_class('_meta', Options(meta, app_label))
File "/opt/django-DefectDojo/venv/local/lib/python2.7/site-packages/django/db/models/base.py", line 325, in add_to_class
value.contribute_to_class(cls, name)
File "/opt/django-DefectDojo/venv/local/lib/python2.7/site-packages/django/db/models/options.py", line 214, in contribute_to_class
self.db_table = truncate_name(self.db_table, connection.ops.max_name_length())
File "/opt/django-DefectDojo/venv/local/lib/python2.7/site-packages/django/db/init.py", line 33, in getattr
return getattr(connections[DEFAULT_DB_ALIAS], item)
File "/opt/django-DefectDojo/venv/local/lib/python2.7/site-packages/django/db/utils.py", line 211, in getitem
backend = load_backend(db['ENGINE'])
File "/opt/django-DefectDojo/venv/local/lib/python2.7/site-packages/django/db/utils.py", line 115, in load_backend
return import_module('%s.base' % backend_name)
File "/usr/lib/python2.7/importlib/init.py", line 37, in import_module
import(name)
File "/opt/django-DefectDojo/venv/local/lib/python2.7/site-packages/django/db/backends/mysql/base.py", line 30, in
'Did you install mysqlclient or MySQL-python?' % e
django.core.exceptions.ImproperlyConfigured: Error loading MySQLdb module: No module named MySQLdb.
Did you install mysqlclient or MySQL-python?

Hello, MySQL error occurred when I built this environment with docker. What should I do?
Is there any effective way to shoot wrong ideas or solutions to tell me?
Thank you.
The following are commands and errors:
Docker run-it-p 8000:8000 appsecpipeline/django-defectdojo bash-c "export LOAD_SAMPLE_DATA=True & bash/opt/django-DefectDojo/docker/docker-startup.bash"

Starting MySQL database server mysqld No directory, logging in with HOME=/

Hello, MySQL error occurred when I built this environment with docker. What should I do?
Do you have any effective ideas or solutions to troubleshooting?
Thank you.
The following are commands and errors:
Docker run-it-p 8000:8000 appsecpipeline/django-defectdojo bash-c "export LOAD_SAMPLE_DATA=True & bash/opt/django-DefectDojo/docker/docker-startup.bash"

Starting MySQL database server mysqld No directory, logging in with HOME=/

Fixed in dev and push soon to master. Thanks to Hendrik Mallow's assistance.


[WIP] Add connection tables to details panel

Fixes #680, Fixes #378

How about making connections a toplevel node field:
{
metadata,
metrics,
connections: [
  {
    id: "out",
    columns: [{id: "id", label: "Remote"}, {id: "port", label: "Port"}, {id: "count", label: "Label"}}],
    items:[{id: <nodeId>, port: <port>, count: <count>}, ...]
  },
  {id: in, ...}
]}

Sorry should have WIP marker.  Yes I hope to combined lots of this code, once I get it working.

@davkal I eventually want the rows to link to other objects in the topology (ie link to the other container talking to this one) like the other children tables.  Links will always be within the current view.  Can you update your datastructure for this?  I'm hoping links will always be possible, but you might want to make them optional.

just reading a bit for curiosity.

Alternatively we can model connections as a nodes table, i.e. wrapping ports as metadata (typed as int to make it sortable as a number) and counts wrapped as a metric:
{
metadata,
metrics,
children,
connections: [{
    id: "out",
    label: "Outgoing Connections",
    columns: [{id: "label", label: "Remote"}, {id: "port", label: "Port"}, {id: "count", label: "Count"}}],
    nodes: [{
      id: <nodeId>,
      label: <nodeLabel>,
      topologyId: <topologyId>,
      metadata: [{port: <port>, type: "number"}]
      metrics: [{count: <count>}]
    }, ...]
  },
  {id: in, ...}

topologyId: "endpoint-incoming" needs to be id: "endpoint-incoming". topologyId is something like processes that will be used together with a node's id to build a deeplink.

still quite a bit of tricky string-munging code shared between the incoming connections and outgoing connection aggregators.

Connections Fr... is not a great table name.

I guess no luck on converting the endpoints to their respective nodes in the relevant topology?

I guess no luck on converting the endpoints to their respective nodes in the relevant topology?

Time constraint I'm afraid.  Will do it next sprint.

Aside from a few naming things and refactoring (if possible), this LGTM.

@paulbellamy I think I've addressed all the feedback, and got it working for the internet node.  Its a bit of a hack.  I think we should punt this form 0.13 and finish it properly.  Thoughts?

Also think the internet is going to need a custom table (for outgoing connections):

Going to hold this until #566 is merged.  Also need @pidster input on the table for the internet node(s).

General approach seems fine. A couple naming and tidiness things.


(Funny) new way MuseScore is blocking us

They just switched to "Please, disable TamperMonkey to access the website."
lol
Any alternative recommended?

Same thing happened to me, but it seems like if you are quick enough, you can still download the score by clicking the button before it disappears.

They just switched to "Please, disable TamperMonkey to access the website."
lol
Any alternative recommended?

I used violentmonkey so far no blocks from musescore. But the script doesnt seem to work anymore? Idk, It's stuck on processing after clicking on Individual parts

They just detect the script and refuse to show the page, it is impossible to detect the userscript managers themselves. They could patch the API, but I suspect they haven't done that. Is there some way to "click" the buttons using the console?

They just switched to "Please, disable TamperMonkey to access the website."
lol
Any alternative recommended?

The thing has nothing to do with TamperMonkey.

They just detect the script and refuse to show the page, it is impossible to detect the userscript managers themselves

It actually detects this script.

Hi there! Same issue here using Firefox on Windows (downloaded the latest XPI)

Hi there! Same issue here using Firefox on Windows (downloaded the latest XPI)

Oh. I forgot to release the XPI of the latest version

Is there some way to "click" the buttons using the console?

It will expose a global variable which is very easy to be detected

Just curious, how does it detect the script itself?
Get Outlook for Androidhttps://aka.ms/ghei36

From: Xmader<EMAIL_ADDRESS>Sent: Friday, November 20, 2020 6:02:18 PM
To: Xmader/musescore-downloader<EMAIL_ADDRESS>Cc: Ruben Vergani<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [Xmader/musescore-downloader] (Funny) new way MuseScore is blocking us (#64)
Is there some way to "click" the buttons using the console?
It will expose a global variable which is very easy to be detected
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://eur06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FXmader%2Fmusescore-downloader%2Fissues%2F64%23issuecomment-731287189&data=04|01||91a860753b144f02ba1d08d88d760a28|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637414885392299894|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=GRIqM460wLdLSamKd6CKIAjdRD%2ByVxG0By0BjVYKt28%3D&reserved=0, or unsubscribehttps://eur06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAMRJI3EWW7UIBTNAESWGUUTSQ2OJVANCNFSM4T4YPUGQ&data=04|01||91a860753b144f02ba1d08d88d760a28|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637414885392299894|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=ewwCALBuwUlZS3JHpbxdX4STcFJJ98B%2FDHLaf%2Bvxt%2B8%3D&reserved=0.

Just curious, how does it detect the script itself?

The script loads unused webpack modules on the webpage


perf: improve performance of web3 provider send transaction

What I did
Improved performance of transaction handling

fixes: APE-563
How I did it

How to verify it

Checklist

[ ] All changes are completed
[ ] New test cases have been added
[ ] Documentation has been updated

So I am not hitting the None account issue I was before, but now getting this error in ape-hardhat from these changes:
AttributeError: 'TestContractSol' has no attribute 'call'.
It happens on a test that impersonates a contract.

Yes, it is ignoring contractinstance as sender either i need to also add that or revert my change regarding sender and just add or condition to send send_raw_transaction which should be more performant i guess as there will be less code line executed

How about changing whole architecture to use just simple classes like no cached_property or property, and create just pub-sub system so when config changes, managers would be notified. This is basically already keeping everything in memory and doesnt compute them if it is not required really. Also, is using yield necessary? mostly projects wont have thousands users for example that yield would perform, in other context just using lists are faster. @unparalleled-js  @fubuloubu

I am getting errors in ape-foundry for contract-as-sender based tests when using this PR... I can look into it.

OK foundry errors may not related to this PR, not sure why they suddenly have come up.. But fixed here: https://github.com/ApeWorX/ape-foundry/pull/32

I am unable to update this branch with main for some reason, else I would do that and merge now.

I am unable to update this branch with main for some reason, else I would do that and merge now.

@bilbeyt has to enable maintainers to update

I am unable to update this branch with main for some reason, else I would do that and merge now.

@bilbeyt has to enable maintainers to update

I rebased this one now and as i tried with another MR, i dont see a checkbox to enable maintainers to edit

I rebased this one now and as i tried with another MR, i dont see a checkbox to enable maintainers to edit

Is it not appearing in the usual spot? Odd, maybe an organization setting?
Here is the guide on it in case its that's helpful: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork


Fixed DeprecationWarning

Description of changes
WARNING
  /home/philipp/dev/ai-vertragsdaten/.venv/lib/python3.10/site-packages/chromadb/utils/read_write_lock.py:29: DeprecationWarning: notifyAll() is deprecated, use notify_all() instead
    self._read_ready.notifyAll()

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

Summarize the changes made by this PR.

Improvements & Bug fixes

Fixed DeprecationWarning
 def release_read(self) -> None:  """Release a read lock."""  self._read_ready.acquire()  try:      self._readers -= 1      if not self._readers:          self._read_ready.notify_all() # perviously notifyAll()  finally:      self._read_ready.release()

New functionality

No

Test plan
How are these changes tested?

pytest during fastAPI integration -all tests passed

Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

No

I believe this won't work on versions <3.10

@braun-viathan what are the additional commits meant to address? just trying to get up to speed on this. thanks!


Debug Console NEEDS a filter

Issue Type: Feature Request
There is a lot of extensions that overwhelm the debug console (including C# and Flutter extensions). The Flutter extension team blames VSCode for not having the proper API's to allow filtering.
On Flutter it's even a bit more complicated, because the guy who build the extension is not the same guy who build the Flutter plugin that is not the same guy who wrote the original native plugin that is spamming the debug console.
So, WE NEEED A FILTER ON VSCODE (a simple "contains" and "starts with") will do. It is not that hard to implement =(
VS Code version: Code 1.43.2 (0ba0ca52957102ca3527cf479571617f0de6ed50, 2020-03-24T07:38:38.248Z)
OS version: Windows_NT x64 10.0.18362

@isidorn the new tree supports filtering and the LoadedScripts view even uses it to search in "invisible" parts of the tree. Could we not just enable the filter UI?

Yeah the filtering is enabled in the debug console. Users can trigger it via cmd/ctrl + F.
Yeah it is a duplicate but this user is very persistant and keeps on reopening issues I close as duplictes. Thus I decided to leave this one open.

@JCKodel have you tried to use the existing filter functionality of the debug console?

Yeah the filtering is enabled in the debug console. Users can trigger it via cmd/ctrl + F.
Yeah it is a duplicate but this user is very persistant and keeps on reopening issues I close as duplictes. Thus I decided to leave this one open.

This user is very persistent because people like you don't realize that FIND is not the same as FILTER.
FIND is when you want to ONLY include the searched term.
FILTER is when you want to EXCLUDE the filtered term.
The problem is the spam nature of this dialog. I want to be able to FILTER OUT some specific lines, but see anything else (even those lines I don't EVEN REALIZE THEY EXIST YET, such as error messages.
Instead of saying "ThE uSeR iS vErY pErSistAnt", try to least understand the issue at hand. THAT'S WHAT LISTEN TO CUSTOMERS IS LIKE.
 Microsoft never heard user's opinion before, it was my mistake to let me believe you could have changed.

I case you still don't understand, here's a drawing for you.

I have similar issue when I debug video player on android device.
I think this is a reasonably request which help filter logs which develop cares in case when develop can't do more config on logs from some libs.

I will support the author of the thread.
In response to a request to make a debug panel filter in VS Code, JCKodel shows the Logcat filter in Android Studio.
It is perfectly!

Do we have access to the input/output/buffer of the debug console via extensions? If yes, I'm really surprised such an extension doesn't exist yet (or I haven't found it).
To give you an example my application has different services and each one has its "log tag". If I'm debugging a certain service, I don't want to be spammed by any other logs.
Here is a real world example:
[request] <Done in 187ms> fetching "https://example.com"
<WARNING> [test] cannot fill cache which was already filled
[request] <Done in 152ms> fetching "https://example.com"
[ViewFilterService] Resolved 1 waiting listener

I'd like to filter only "test" using something like /\[test\]/gm.
Of course, this is simplified quite a bit, because here it wouldn't be easier filter with your brain :D

Its actually really hard to get use of debug console in real world application which has lots of processes in. Basically, I have a wall of logs which produces faster than I can read and there is no reliable way for me to configure what I wanna see, searching is nice but it didn't really helps much as: I want to see only what I need, not search for what I need in tons of text

Dup of https://github.com/microsoft/vscode/issues/20838


Updated offer ID for veritas solution

Required items, please complete
Change(s):

See guidance below

Reason for Change(s):

See guidance below

Version Updated:

Required only for Detections/Analytic Rule templates
See guidance below

Testing Completed:

See guidance below

Checked that the validations are passing and have addressed any issues that are present:

See guidance below

Guidance <- remove section before submitting

Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:
Thank you for your contribution to the Microsoft Sentinel Github repo.

Details of the code changes in your submitted PR.  Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process.  Providing associated Issues that this resolves also easily connects the reason.

Change(s):

Updated syntax for XYZ.yaml

Reason for Change(s):

New schema used for XYZ.yaml
Resolves ISSUE #1234

Version updated:

Yes
Detections/Analytic Rule templates are required to have the version updated

The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly.  If your submission requires a custom parser or function, it must be submitted with the PR.

Testing Completed:

Yes/No/Need Help

Note: If updating a detection, you must update the version field.

Before the submission has been made, please look at running the KQL and Yaml Validation Checks locally.
https://github.com/Azure/Azure-Sentinel#run-kql-validation-locally

Checked that the validations are passing and have addressed any issues that are present:

Yes/No/Need Help

Note: Let us know if you have tried fixing the validation error and need help.

References:

Guidance for Detection checks
General contribution guidance
PR validation troubleshooting

Hi @swapnildombaleveritas,
Please also change the details below:

The tier should be Partner not Microsoft
The support details also need to be changed; they should be partner details.

Hi @swapnildombaleveritas,
We are waiting for your updates on above asks. Thanks

Hi @swapnildombaleveritas, We are waiting for your updates on above asks. Thanks

Thanks for the review. Will make the changes and update the PR.

Hi @swapnildombaleveritas,
Please reply on above comment. Thanks

Hi @swapnildombaleveritas,
Please correct OfferId as we mentioned in above comment. Thanks

Hi @swapnildombaleveritas,
We are waiting for your reply on above asks. Thanks

This offer id "veritas-netbackup-8-s" we have generated for veritas for other offerings as well.
Kindly suggest if we need to generate new offer id with 'sentinel' name in it?

Hi @swapnildombaleveritas,
Please generate new offer with sentinel keyword. Thanks

Hi @swapnildombaleveritas, Please generate new offer with sentinel keyword. Thanks

Kindly help us to create new offer id. Should it be a new market place offer or do we have any new method for sentinel?
If we have any documentation which mention how to create new offering specifically for sentinel please let us know.

Hi @swapnildombaleveritas,
Please refer step 3 from below link. Thanks
https://github.com/Azure/Azure-Sentinel/blob/master/Solutions/README.md

Hi @swapnildombaleveritas,
We are waiting for your reply on above asks. Thanks

Hi @swapnildombaleveritas,
Please respond. Thanks

Hello @swapnildombaleveritas,
We are waiting for your reply. Thanks

Hi @swapnildombaleveritas,
Any update. Thanks

Hi @swapnildombaleveritas,
We have already shared the offer creation document with you, if you still have doubts then please let us know. Thanks

Hi @swapnildombaleveritas,
Can we connect over a call? Thanks

Hi @swapnildombaleveritas,
Could you please provide your email address so that we can arrange a call? Thanks

Hi @swapnildombaleveritas,
Please respond on above. Thanks

Hi @swapnildombaleveritas,
Please respond on above ask. Thanks

We wanted to check on the status of PR #10406. PR is pending for more than 60 days. Please let us know if you need any assistance to review this PR. Per our standard operating procedures if no response is received in the next 7 business days, we will close this PR. Thank you for your cooperation.

Since we have not received a response in the last 7 days, we are closing your PR #10406 per our standard operating procedures. If you still need support for this issue, you can re-open the PR at any time.
If you do re-open, we simply request that you ensure the PR has response to the last request. Thank you for your cooperation.


Update vault history section

Update vault history section
Changes 👷♀

Updated layout in vault history section.
Removed extensive usage of divs all over the place and changed some of them into other tags according to HTML semantics.

How to test 🧪
Check out manage vault page or, in case of automation feature flag enabled, "history" tab on vault page. Please not that you need to check multiply vault to see events on in history that has details.

Hey. This redesign changes should be hidden behind AutomationBasicBuyAndSell feature toggle. Feature toggle Automation and current production version should use old design.

Okay, done, moved into AutomationBasicBuyAndSell but that required to copy old history components and update them separately. Conditioning every layout change in old component would lead to unreadable garbage.
Old components should be removed when AutomationBasicBuyAndSell flag is no longer needed, I left a comment in the code so the person who is going to do that would remember about it.


Locale hr: Month name fix

Note: This is similar to #2048, although this one has tests. In that issue, it was noted that CLDR had it as "sječanj," however CLDR has since updated it to "siječanj." The abbreviation is also shown as "sij."

This is pretty much duplicate of #2048 but I added tests.

Looks good.
@tomhorvat can you please rebase to latest develop. Check https://github.com/moment/moment/blob/develop/CONTRIBUTING.md for more info.

Merged in f2ee575


[ttLib/pyftmerge] Handle cmap merge better

Changed the merge algorithm to properly handle cmap subtables
of type 4 and 12 with platform id and encoding ids of 3/1 and 3/10
respectively. All other subtables are not merged and ignored.
The resulting merged cmap table includes a subtable of format 4/3/1
and a format 12 subtable iff there are mappings outside of the BMP.
If one font has two codepoints that point to the same glyph,
and another font has the same code points pointing to two other glyphs,
keep the behavior where the first replacement glyph is stored in 'locl'
and output the third glpyh (or more) to let the user know that they were
dropped, instead of failing to merge the font.
Fixes #444
Fixes #322

I was trying to merge Emoji fonts so I could get some color emoji on my Windows 7 machine occasionally when I discovered that pyftmerge doesn't output valid Windows font files if there are any code points outside the BMP, so I originally wrote a script to generate a cmap4 table, then wrote this patch to fix it in FontTools. Then got a little carried away to try and fix other cmap merging related errors.

Coverage increased (+0.2%) to 71.036% when pulling fcad0c214b7977525ca5586b4ab9fa82a1ed020d on yincrash:cmap_merge into 3b8387fa457bb349fc2fd8da3817f22c8e57afb3 on behdad:master.

Coverage increased (+0.2%) to 71.071% when pulling fcad0c214b7977525ca5586b4ab9fa82a1ed020d on yincrash:cmap_merge into 3b8387fa457bb349fc2fd8da3817f22c8e57afb3 on behdad:master.

Thanks for this!  I left a few minor comments.  Please address those and I'll merge.

Amended my commit with your recommendations :)

Coverage increased (+0.1%) to 71.051% when pulling 9ed62af9ccdba3a8fbde4cd2a0cbf8d2a3ca5a1a on yincrash:cmap_merge into 5cd1fbaff6a3f8f3ab09354712fc65ff0e9f91d0 on behdad:master.

Thanks!


When installing Final Demo, 3drend.dll is not installed

3drend.dll contains all the assets for Christmas Mode.
2.0 removes it, but Final Demo won't work on Dec 25th without it.
I checked and when the file is included, the game does run.

Thank you for reporting this isue. Included installing "3drend.dll" from extracted SRB2 Final Demo assets in commit d209827f1.


New plugin - Sololegends - temple-trek-bog-helper

Runelite Temple Trek Bog Helper
Highlights firm bog ground as you find them
During the bog event in Temple Trekking, as you discover tiles that are "firm" they will be highlighted automatically for you. These highlights will only persist for that single event and be reset when the bog puzzle resets.
There is also a full on solver which automatically highlights all firm tiles without having to poke around in the bog.

is this different than https://github.com/runelite/plugin-hub/pull/4788 ?

is this different than #4788 ?

A bit, yeah. That linked plugin just renders out the "solid" tiles by ID.
While this plugin also can do that, the main goal is to allow people to still play the mini game by keeping track of the solid tiles they have found using the testing sticks.


Add Tim Sort implementation in Python | #824

I have added a new file tim_sort.py in the directory: Data-Structures-and-Algorithms/Python/Algorithms/Sorting-Algorithms
Issue no - #824
Self Check(Tick After Making pull Request)

[x] This issue was assigned to me if not it will marked as spam.
[x] My file is in proper folder.
[x] I am following clean code and Documentation.
[x] I have added title and what program will do first in the file.

@div-bargali Can you please review this?


create apply_compression method to consistently apply compression and…

Inconsistent application of Blosc lz4 compression causes downstream issues. Apply it everywhere in a dedicated method to avoid this issue.

I don't think there's necessarily a tension between having a function and a script. My assumption was that actual applications of these functions would occur in standalone scripts, not within ETLs.
Perhaps the functions could exist outside the tools library still; I wanted to write the functions within the main stack so they could be rigorously tested and fully leverage useful member variables of dataset managers.
Perhaps in the longer term maintenance-type functions should live in their own utils file?
Regarding the different applications of the function, fully agreed that it does three different things. I decided against three different functions as it would result in 80% duplicated code within each. I'm open to any ways you can see to square this circle.

For the modify encoding function, something that could work pretty smoothly is if we leave the function as is and make it "private" by adding an underscore at the front of the name like _modify_array_encoding. This convention comes with some official support in Python.
Then we can add simple wrapper functions like insert, update, and remove that call the common function.
For the maintenance functions, a separate module could be a good way to keep functions like this and maybe others like rollback in the same repo. Our rule could be something like the maintenance module can call utils but not the other way around.


Got charged 650$ after using the text classification example script

Hi,
I tried to use the text classification example script thinking it would train the model on my gpu, I was trying it on random models, nothing was mentioned that it costs lots of money to run this script, please check what I got after i ran the script:

After some minutes I got an invoice from hugging face for 650$, what should I do in this case? Why the script is randomly charging me money, it didn't mention that it would cost money to run this script. Also as you can see in the picture the script stops after starting training, isn't this an open source project which i can use to train models on my GPU? How can I get a refund for the money that got charged? this is the script i ran: https://github.com/huggingface/autotrain-advanced/blob/main/examples/text_classification_binary.py

Hi @Stealthwriter ! We've sent you an email though let us know if you have any further questions! Thanks again


Publish to npm?

Hey this is a great project. Have you considered publishing it to npm as a package? I'm sure lots would find it useful!
Thanks!

Hey thanks! I haven’t (additional maintenance burden I do not wish to take on) but the code is open source so others can totally do that! :)
Sent from my iPhone

On Oct 29, 2017, at 2:23 PM, James Milner<EMAIL_ADDRESS>wrote:
Hey this is a great project. Have you considered publishing it to npm as a package? I'm sure lots would find it useful!
Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Running on windows 11 with 16 core 32 threads AMD processor

I did some test with my desktop and found everything to be working pretty well (even faster than my M1 macbook)
Performance on a single thread is already pretty decent with slight improvement for more threads
julia> @time dd,ini,act=  FUSE.init(:ITER;init_from=:scalars);
nthreads = 1
4.544329 seconds (10.68 M allocations: 1.675 GiB, 32.86% gc time, 0.14% compilation time)
nthreads = 4
3.219013 seconds (10.69 M allocations: 1.675 GiB, 31.29% gc time, 0.16% compilation time)
nthreads = 8
2.495964 seconds (10.69 M allocations: 1.676 GiB, 11.17% gc time, 0.10% compilation time)
nthreads = 16
2.305549 seconds (10.69 M allocations: 1.677 GiB, 10.17% gc time)
Note there are no lock conflicts during the init
RunningFUSE.warmup(dd)gives some locking errors when using threads
nthreads = 1
44.404490 seconds (366.93 M allocations: 11.523 GiB, 5.45% gc time)'
nthreads = 4
39.077457 seconds (372.00 M allocations: 11.657 GiB, 6.13% gc time, 4 lock conflicts)
nthreads = 8
36.465294 seconds (373.95 M allocations: 11.715 GiB, 3.40% gc time, 8 lock conflicts)
nthreads = 16
30.831370 seconds (432.66 M allocations: 13.309 GiB, 3.92% gc time, 75 lock conflicts, 0.02% compilation time)
32.200818 seconds (439.29 M allocations: 13.488 GiB, 3.87% gc time, 87 lock conflicts)
Performance with more threads gives some lock conflicts which isn't constant across different runs

So it's running, just not multithreading properly?

@bclyons12 I think it's running, and the multithreading seems to accelerate the execution. However the speedup may be hindered by lock conflicts.
Two things:

It's interesting those lock conflicts don't show up on Macs
It would be good to understand where those lock conflict occur

Searching for @threads (and filtering out some that are certainly not the problem for this application) this is what I get:

We came to the conclusion that the lock conflicts comes from x86 problem on newer julia releases


[ListPage] A ref is missing on the list component to be able to read selected items

@remigrange

@remigrange  Ok we will fix it as soon as possible. cc @Bernardstanislas


Hi quys i find it this issues..thanks


TypeScript Version?

Hi
Question: Which TypeScript version does your js library support?
Thank you for your feedback.
With best regards,
Jan

ok, problem solved by not-using your library...


Use new test data for HGVS genomic coordinates

Genomic coordinates are now available in the test data as seen here https://github.com/ga4gh/compliance/pull/162.
This PR puts the genomic coordinates into the HGVS annotation record fixing #838 .

You need to rebase this off upstream/variation_annotation @david4096.


Create chosun.txt

I'm a student. The student's domain is @chosun.kr.
The teacher's domain is @chosun.ac.kr.
Please, add @chosun.kr

@anubiss21 Pull request merged. Thank you!


[ci-auto] GenAIExample ChatQnA,CodeGen,CodeTrans,DocSum,FaqGen,SearchQnA,Translation compose.yaml got changed.

GenAIExample ChatQnA,CodeGen,CodeTrans,DocSum,FaqGen,SearchQnA,Translation compose.yaml got changed
Below files are changed in this commit

ChatQnA/docker/aipc/compose.yaml
ChatQnA/docker/gaudi/compose.yaml
ChatQnA/docker/gpu/compose.yaml
ChatQnA/docker/xeon/compose.yaml
CodeGen/docker/gaudi/compose.yaml
CodeGen/docker/xeon/compose.yaml
CodeTrans/docker/gaudi/compose.yaml
CodeTrans/docker/xeon/compose.yaml
DocSum/docker/gaudi/compose.yaml
DocSum/docker/xeon/compose.yaml
FaqGen/docker/gaudi/compose.yaml
FaqGen/docker/xeon/compose.yaml
SearchQnA/docker/gaudi/compose.yaml
SearchQnA/docker/xeon/compose.yaml
Translation/docker/xeon/compose.yaml

Please verify if the helm charts and manifests need to be changed accordingly.

This issue was created automatically by CI.

They disabled langsmith tracing support which is disabled by default in the helm charts. No need to update.


Implement the add command to support start time and end time

Dependencies: #66 and #67
Format: add "DESCRIPTION" [on] [today/tomorrow/DAY/DATE] [from] [START_TIME] [to] [END_TIME]
E.g.

add "Programming Workshop" on Sunday from 10am to 4pm
add "Flower Arrangement Workshop" on 23 October from 7.30pm to 9.30pm
add "Interview" tomorrow from 11am to 11.30am
add "Do maths assignment" from 2pm to 4pm

*NOTE:

If date is not specified, it is assumed to be today or tomorrow depending on the current time. However, the result of the add will be displayed and so the user can check whether is the task added correctly.

Refer to issue #63

Complete support startTime endTime


Add template with airflow dep structure

Describe your changes :

We are replicating the configMap structure for the pod_template_file and passing it as a constant name to the webserver.
This will create the pod_template.yaml file in the webserver regardless of the deployment name of the charts, which was the initial issue.

Type of change :

[x] Bug fix
[x] Improvement
[x] New feature
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Documentation

Frontend Preview (Screenshots) :
For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] I have performed a self-review of my own.
[ ] I have tagged my reviewers below.
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] My changes generate no new warnings.
[ ] I have added tests that prove my fix is effective or that my feature works.
[x] All new and existing tests passed.

Reviewers

MountVolume SetUp failed for volume "pod-template" : configmap "openmetadata-pod-template" not found ?


Roll OCaml version to 4.05.0

cc @cdykes - as well as the actual content of this change, roll-out might be affected by whatever led to d1c1bf36787628d00279a0f39f1886c5ccccbb19

@fredemmott: Discussed this with @Orvid. At least, I think this is what we were discussing, and I got the idea that I'm clear to land. Is that right, @Orvid.

Yep, this is fine to land. The revert to the submodules was because I started to update the first-party stuff but never finished.


[UPDATE] Button

Component References
Figma Link
https://www.figma.com/file/R7ymwKrEI3LF6ssrZe5opG/Dekstop-UI-KIT?node-id=139%3A288
Additional Info

Button borders are now 8px (lg)
Variants are still the same, slightly tweaked colors.
Icons now only on the left (deprecate iconPosition="right")
New outline-destructive variant

Missed disclosure variant
Missed disclosure plain variant

@neveraemje button udah okey menurutku. Disclosure & disclosure plain available


Python3.11 support

Is this feature request related to a new rule or cfn-lint capabilities?
No response
Describe the feature you'd like to request
Could you please add python 3.11?
AWS CloudFormation Linter................................................Failed
- hook id: cfn-python-lint
- exit code: 2

E3030 You must specify a valid value for Runtime (python3.11). Valid values are ["dotnet6", "dotnetcore1.0", "dotnetcore2.0", "dotnetcore2.1", "dotnetcore3.1", "go1.x", "java11", "java17", "java8", "java8.al2", "nodejs", "nodejs10.x", "nodejs12.x", "nodejs14.x", "nodejs16.x", "nodejs18.x", "nodejs4.3", "nodejs4.3-edge", "nodejs6.10", "nodejs8.10", "provided", "provided.al2", "python2.7", "python3.10", "python3.6", "python3.7", "python3.8", "python3.9", "ruby2.5", "ruby2.7", "ruby3.2"]
template.yaml:6:3

Describe the solution you'd like
Adding python3.11 to not show error when Runtine: 3.11
Additional context
No response
Is this something that you'd be interested in working on?

[x] 👋 I may be able to implement this feature request

Would this feature include a breaking change?

[ ] ⚠ This feature might incur a breaking change

The values for that are brought from https://github.com/boto/botocore/blob/99d6a50ea6c2bf6e78e9dbe8dcb1e23e391f3fc1/botocore/data/lambda/2015-03-31/service-2.json#L5199C1-L5234C1
I don't see any announcements for Python 3.11 support.  Do you have one available?

Ok I see, thank you.
I will add issue in their repo too: https://github.com/boto/botocore/issues/2980

They are working on it here: https://github.com/aws/aws-lambda-base-images/issues/62

Its published: https://github.com/aws/aws-lambda-base-images/issues/62#issuecomment-1635917903

Now included in the automated maintenance task
https://github.com/aws-cloudformation/cfn-lint/pull/2804/files#diff-a5a6f378b19287fd419ef6c9edf44d4493163add0a727420af026573a02f165aR240311

looks like they've released the 3.11 runtime and its included in the 132.0.0 spec.

The newest release has the 132.0.0 spec and has python 3.11 in it.


revisit scroll clean frame

since the image starts off screen, a clean frame at the end is also needed, which should be accomplished by modifying the step size
however, this still produces imperfect results, need to investigate further

the scroll is correct after some changes, but there is still an issue relating to some straggling data after frame reset. not sure if this is just gif artifacts or something i can fix


feat: PWA support

Is your feature request related to a problem? Please describe.
Currently the app can't be installed as a PWA which could make it more feel like a native application.
Describe the solution you'd like
Make it possible to install the app as an PWA.
Additional context
https://blog.logrocket.com/how-to-build-a-progressive-web-app-pwa-with-node-js/

Hi, Thanks for the suggestion. I'll take a look at it when I can, as adding core features to the webui is the top priority at the moment. In the meantime, if you manage to implement this feature and make a PR, I'll review and merge to main. Thanks!


How do I remove the next and previous buttons at the bottom of a page?

On some pages, I want to be able to remove, or control what pages are linked too next, instead of these being auto-generated. They sometimes push the user onto the next section, which might be completely unrelated.

In your _meta.json file, under the page you want to remove navigation for, use this.
"example": {
     "title": "Example Page",
     "theme": {
        "pagination": false
      }
}

Read HERE for more info.

thanks @C-EO !


Math functions now missing?

In an earlier build, I was able to use C math functions, i.e.
let c0 = cos angle in ...
In the latest build, I am now receiving this error
Note: Alpha transform failed ...
Do those functions now have to be wrapped?

All functions imported from C is defined here. Math functions are not defined yet.
I'm not sure which they should be implemented, in gocaml or in C. Anyway, yeah, importing math functions is better than never.

I added math functions in f37e33c. Please check it out.


[Frontend] UI Enhancements in Manage Q&A Section of Admin Panel

Description

[ ] We should only show Delete button after approval in both question and answer
[ ] The loader while fetching the answer is making the UI look bad, either shift the loader under the expanded section of answers or replace the ui with pop-up for better user experience

Hey @Kajol-Kumari
Please assign me the issue