Docker rootless image size close to twice as big

Looks like dockerfile command chown & chmod creates new layer in size of gitea binary that makes image close to twice as big.
see: https://github.com/go-gitea/gitea/blob/master/Dockerfile.rootless#L54
and: https://hub.docker.com/layers/gitea/gitea/latest-rootless/images/sha256-b55c30e134a5ce42aaf3cb94402c3ac98294ffbbb82ea1a70e9c669a586b0441?context=explore
Maybe file could be chown'ed and chmod'ed before building docker image?

ping @sapk

There's docker build --squash to merge layers but it's been considered experimental for years. Interestingly, it seems not experimental on docker buildx.

yes but that will squash all layers that is not so good as base layers are not reused anymore

btw why *linux-amd64|*linux-arm64 tags are needed when there is already tag that has both archs in it?

btw why *linux-amd64|*linux-arm64 tags are needed when there is already tag that has both archs in it?

@lafriks docker manifest needs images to already exist

oh, ok

Should probably switch to docker buildx for cross-platform builds at some point.


Update README to clarify current purpose of this repo

This repo houses the Cog Predictor code used by dreambooth-api-experimental.replicate.com as described in https://replicate.com/blog/dreambooth-api
Let's update the README to reflect that.
cc @bfirsh

this was done as part of the work to integrate cog-stable-diffusion improvements


how does rss work?

I entered the rss endpoints but I cant see any new articles or documents pulled from rss?
how do I create an RSS toread?
Can you explain what should happen?
also the af_pull.py is failing because there is no reddit authentication set up. I dont want to monitor reddit. i removed reddit and twitter from CONTENT_SOURCES but it still trying to pull from there :(

Thanks for raising the question, From your description I feel it mainly because of pulling failed , and RSS step hasn't start, if that's the case, I will check later to see the bypass path.

yes it was because i didnt rebuild the docker images to deploy the updated code
does rss need to be pulled on a schedule or can it get the articles the moment the feed is updated?

i think you should have exception handlers in each task so that one fail doesnt fail all the others down the path for pulling

does rss need to be pulled on a schedule or can it get the articles the moment the feed is updated?

RSS pulled on schedule (every hour), in case you want to reduce the interval, modify the schedule in this dag and build a new image to deploy

i think you should have exception handlers in each task so that one fail doesnt fail all the others down the path for pulling

I rechecked, and yes, there is protection for each source pulling, so even if the Reddit path failed, it wouldn't impact other sources (ref). At this moment, I feel it may be related to your RSS Inbox setup, if you followed this wiki, it should be fine.
However, some RSS cannot be pulled programmatically (aka Robot/Api); it only allows access via Browser. I am not sure whether you are in this case, but if you don't mind sharing your RSS, I can help to verify offline. Otherwise, you may want to wait for my next release, which I have an ongoing experiment to deal with this issue.


[pigment-css][vite] Plugin not working when used in a monorepo (w/ shareable theme)

Steps to reproduce
Link to live example
Steps:

Clone repo
Install deps npm install (from repo's root)
Run npm run start (from pkg1)
Observe error in your CLI

Error: @pigment-css/react: You were trying to call "css" function without configuring your bundler

Comment out theme in vite.config.ts
Restart npm run start (it will run without issues)

Current behavior
pigment-css-vite-plugin doesn't work when a theme is connected directly (imports a value) or imports a type from one of the files that is importing from a file with @pigment-css/react's css.
Expected behavior
Theme should be shareable and references shouldn't break the pigment-css-vite-plugin unexpectedly.
Context
Btw, the bug exists in both pigment's 0.0.4 and the latest state of mui's next branch (checked a couple of hours ago)
Your environment

npx @mui/envinfo

  System:
    OS: macOS 14.4
  Binaries:
    Node: 21.7.1 - /opt/homebrew/bin/node
    npm: 10.5.0 - /opt/homebrew/bin/npm
    pnpm: 8.15.5 - /opt/homebrew/bin/pnpm
  Browsers:
    Chrome: 123.0.6312.87
    Edge: 112.0.1722.39
    Safari: 17.4
  npmPackages:
    @pigment-css/react: 0.0.4
    @pigment-css/vite-plugin: 0.0.4
    @emotion/react:  11.11.4
    @emotion/styled:  11.11.5
    @mui/private-theming:  5.15.14
    @mui/styled-engine:  6.0.0-alpha.0
    @mui/system:  6.0.0-alpha.0
    @mui/types:  7.2.14
    @mui/utils:  5.15.14
    @types/react: 18.2.73 => 18.2.73
    react: ^18.2.0 => 18.2.0
    react-dom: ^18.2.0 => 18.2.0
    typescript: 5.4.3 => 5.4.3

Search keywords: pigment vite monorepo

Can you try changing the import from
import * as pigment from "@pigment-css/react"; to `import { css } from '@pigment-css/react';

I wouldn't say it's a bug, rather a lack of documentation on how to export themes and styled/css function exports.
When you are using the same package to export styled/css calls as well as themes, either of those, preferably theme should be exported on a subpath and not in the same export as others.
In your case, you should be exposing your theme on @monorepo/pkg2/theme and other runtime exports can be directly on @monorepo/pkg2. This is becasue when trying to import @monorepo/pkg2 in your vite.config, it is indirectly also executing the css function which would throw error because it requires a code transform to work.
Hope this is clear. Let me know if this worked.

I disagree. The logic is too fragile.
Anything cannot be safely imported from the file with a theme.

if you import a value or even a type, you risk the file you import references a common file with a file that uses pigment

I am not sure where the fragility comes from. Importing a file in your bundler config is different than importing the same in your source code.
When you are importing -
import { theme } from "../pkg2/src";

Vite executes the pkg2/src/index.ts file. This file also imports your pigment.css() definition. So this function gets executed as well. If you look at the css function definiton, it simply throws an error:
function css() {
  throw new Error(
    `@pigment-css/react: You were trying to call "css" function without configuring your bundler. Make sure to install the bundler specific plugin and use it. @pigment-css/vite-plugin for Vite integration or @pigment-css/nextjs-plugin for Next.js integration.`
  );
}

This is because it is supposed to be compiled away during bundling and get replaced with string class name. So importing and calling the same css function in your vite config file will throw the error.
You can try this patch in your above repo. It just removes the theme export from the main index file.
commit a75173dd1270ae1497b295e5f7be9b9652805ee5
Author: Brijesh Bittu<EMAIL_ADDRESS>Date:   Mon Apr 1 13:52:37 2024 +0530

    Subpath export

diff --git a/pkg1/vite.config.ts b/pkg1/vite.config.ts
index b8a532f..e48eece 100644
--- a/pkg1/vite.config.ts
+++ b/pkg1/vite.config.ts
@@ -2,7 +2,7 @@ import { defineConfig } from "vite";

 import react from "@vitejs/plugin-react";
 import { pigment, extendTheme } from "@pigment-css/vite-plugin";
-import { theme } from "../pkg2/src";
+import { theme } from "../pkg2/src/theme";

 export default defineConfig(() => ({
   plugins: [
diff --git a/pkg2/src/index.ts b/pkg2/src/index.ts
index 514cada..6f6427c 100644
--- a/pkg2/src/index.ts
+++ b/pkg2/src/index.ts
@@ -1,2 +1 @@
 export * as css from "./css";
-export * from "./theme";

I just provided you with the simplest possible example to highlight the issue.
In the real apps, the references might happen through several files (it happened for me when I tried to use Pigment in a big repo).
Please refer to the proposed solution in my previous reply.

The logic within Pigment's API is too fragile. css, keyframes, etc. all always throw an error when invoked. Instead, they should throw an error only in development and only in browser environment.
The simple solution would be to check on the existence of window, when Pigment's API is invoked.

there could be a more complex check whether Pigment is invoked in browser or during bundling

@brijeshb42 in MUI X we tend to move everything that should not be imported inside an internals folder, that way importing it feels more wrong that utils.

Yeah. I'm thinking of doing something same here.
On Tue, 2 Apr 2024 at 6:14 PM, Flavien DELANGLE @.***>
wrote:

@brijeshb42 https://github.com/brijeshb42 in MUI X we tend to move
everything that should not be imported inside an internals folder, that
way importing it feels more wrong that utils.
—
Reply to this email directly, view it on GitHub
https://github.com/mui/material-ui/issues/41730#issuecomment-2031945754,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFPF3VZQLKOJ2C7TAPY4ZLY3KRZLAVCNFSM6AAAAABFQW5472VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZRHE2DKNZVGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

With that being said, I do agree that we should be crystal clear about what can be imported in a config file :+1:

This issue has nothing to do with internals; and it's not a question issue.
I mentioned the same thing in the previous 2 replies, here's the same summary.

The logic within Pigment's API is too fragile. css, keyframes, etc. all always throw an error when invoked. Instead, they should throw an error only in development and only in browser environment.

The simple solution would be to check on the existence of window, when Pigment's API is invoked.

there could be a more complex check whether Pigment is invoked in browser or during bundling

The scenario is outlined in the linked repo in the first comment.
The main issue is that one of the packages is exporting both styled/css function calls as well as a theme object. The error arises from the fact that calling styled/css directly (for ex: similar to importing and calling them in the node REPL) will directly throw an error. They are supposed to be transformed through bundler plugin and compiled away.
In this case, since the package is also being imported in the vite config, there's no code transformation happening and css is also being called which is throwing an error. It's by design. So my main proposal was that the theme (which will be used in the config) be exported through a subpath so that no css call happens there.
It's not just about monorepo as stated. It can happen in a standalone npm package as well.

Here's how vite treats a similar issue, TLDR as a bug.


Basic CLI

A basic CLI to guess a file's encoding and transcribe it into UTF-8 would be amazing.
Something like this:

charmagic guess test.txt
charmagic decode test.txt --enc="<Name>"

Suggestions are welcome.

Now missing is the decoding into UTF-8 from the guessed encoding.

With ad0e9fcb50c956d0b2c908b3c8c4f0de780508e2, all basic commands are added; all that's missing now is an update of the project's README.


I want use cuda8 to run

I want to use cuda8, and set CUDA9 = False in the cfgs.py file, but GPU don't run.

GPU_GROUP in cfgs.py @A-mockingbird


Config clean up

Some minor changes to clean up the config.

Removes some unused assetholder address config
Exported config types from ServerWallet package
Accept chainId as a number.

I think exporting the types is also a "fix" btw.


chore: OPTIC-1154: biome linting tweaks

PR fulfills these requirements

[x] Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
[ ] Tests for the changes have been added/updated (for bug fixes/features)
[ ] Docs have been added/updated (for bug fixes/features)
[ ] Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
[x] Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)
(check all that apply)

[ ] Product design
[ ] Backend (Database)
[ ] Backend (API)
[x] Frontend

Describe the reason for change
updating biome lint to clean up unused imports and variables

/git merge develop

/git merge develop

/git merge develop


How to compute flops on the fly?

Hi, I want to compute the FLOPs of the model in each forward pass and add the score of FLOPs in my loss. Could you give me some advice to implement it?

Please refer to this script for calculating the FLOPs.


Visual Novel Text Hooker Option

I'm operating on Windows, and I downloaded the Windows version win-game2text.zip. However, the visual novel hooker option isn't showing in the toolbar, as it's shown to work in screenshots on the site and there doesn't appear to be any other way to access it. Have I done something wrong?

I have the same issue with running last release executables.
Had to build app from sources from master branch to fix it.
Judging by  this repo hasnt been updated for number of years, I guess we should fix these issues by ourselves.


Json/units in columns

Last commit changes order of destinations from csv-input to resulting Table, but since destinations are considered a "set" this should be ok.

git diff 4dcbdc63495200ffeeecb72c0f3c16876ff93046 434f22d5950a176dbd1a24acb3656e4688632941
diff --git a/examples/pdtable_demo.ipynb b/examples/pdtable_demo.ipynb
index d32be92..0b4a675 100644
--- a/examples/pdtable_demo.ipynb
+++ b/examples/pdtable_demo.ipynb
@@ -594,7 +594,7 @@
"data": {
"text/plain": [
"**farm_animals\n",

  "other_farm, your_farm, my_farm\n",

  "your_farm, other_farm, my_farm\n",
  "  species [text]  n_legs [-]  avg_weight [kg]\n",
  "0        chicken         2.0              2.0\n",
  "1            pig         4.0             89.0\n",

Looks great! Feels much better with the units as part of the columns in JSON.


Externally managed content update

Update the externally managed content. This includes all content, including updates to the rare disease subsets.

Closing since a new qc check is now added to src/ontology/config/robot_report_external_content.txt in mondo-ingest branch externalclingenmedgenefo so that this error will be identified and the content causing the error will be removed to the relevant report file. I will re-run the pipeline.


Buttons not working on Unleashed 075 and official 0.103

Hello. I already reported a Bug over at „Unleashed“. I use the Kasiin Module which works fine with 074 Flipper Unleashed Build. Now with the new 075 Build - no AirMouse App version seems to work: As soon the AirMouse App is running, the Cursor is working (via Bluetooth) - but no D-Pad/Back-Button Entry on the Flipper is processed. Hence: to Quit the AirMouse App - i need to Reset Flipper.
Current workaround: I use my Flipper with 074 Release…. MasterX (from Unleashed) asked to open issue here :)

I did notice this as well on the official firmware 0.13, so I guess something's changed there. I'll take a look when I have some time.

Welp, if anything, I think it's caused by this: https://github.com/flipperdevices/flipperzero-firmware/commit/6d8b050eda8d1e782f553880da66f4135f01a685

This part:
Missing

Edge events
One Shot and other less common flags
Priorities
Priority inversion

kinda gives me hope it'll be relatively easy to fix in the future. Not sure what to do now though.

Gonna be in your app store once https://github.com/flipperdevices/flipper-application-catalog/pull/454 is merged.


Update CLI: convert showcolortables to subcommand as an example

In ESMValGroup/ESMValTool#1657 I propose a change in the CLI to make it more accesible and features more discoverable.
As an example, this pull request converts the showcolortables executable into an esmvaltool subcommand:
esmvaltool colortables ncl

Tasks

[ ] Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
[ ] Give this pull request a descriptive title that can be used as a one line summary in a changelog
[ ] Make sure your code is composed of functions of no more than 50 lines and uses meaningful names for variables
[ ] Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
[ ] Preferably Codacy code quality checks pass, however a few remaining hard to solve Codacy issues are still acceptable. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.
[ ] Please use yamllint to check that your YAML files do not contain mistakes
[ ] (Only if really necessary) Add any additional dependencies needed for the diagnostic script to setup.py, esmvaltool/install/R/r_requirements.txt or esmvaltool/install/Julia/julia_requirements.txt (depending on the language of your script) and also to package/meta.yaml for conda dependencies (includes Python and others, but not R/Julia)
[ ] If new dependencies are introduced, check that the license is compatible with Apache2.0

New recipe/diagnostic

[ ] Add documentation for the recipe to the doc/sphinx/source/recipes folder and add a new entry to index.rst
[ ] Add provenance information

Modified recipe/diagnostic

[ ] Update documentation for the recipe to the doc/sphinx/source/recipes folder
[ ] Update provenance information if needed
[ ] Assign the author(s) of the affected recipe(s) as reviewer(s)

New data reformatting script

[ ] Test the CMORized data using recipes/example/recipe_check_obs.yml, to make sure the CMOR checks pass without errors
[ ] Add the new dataset to the table in the documentation
[ ] Tag @mattiarighi in this pull request, so that the new dataset can be added to the OBS data pool at DKRZ and synchronized with CEDA-Jasmin

Modified data reformatting script

[ ] Test the CMORized data using recipes/example/recipe_check_obs.yml, to make sure the CMOR checks pass without errors
[ ] Tag @mattiarighi in this pull request, so that the updated dataset can be added to the OBS data pool at DKRZ and synchronized with CEDA-Jasmin

If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.

Closes #issue_number

@jvegasbsc Could you have a look at the merge conflict?

@jvegasbsc there are some codacy issues, could you have a look?

@jvegasbsc there are some codacy issues, could you have a look?

Most of those are related to the imports not being in the top but in the functions. This is a change I did to improve the response time of the CLI.

Most of those are related to the imports not being in the top but in the functions. This is a change I did to improve the response time of the CLI.

Ah, yes, now I remember the discussion.

There is one doc related in the middle. Let me fix it!

Could you have a look at the failing test?


[LESS/CSS] VSC suggests "text-emphasis" first while writting "text-transform"

VSCode Version: 1.20.1
OS Version: Win 10 x64 CZ - 1709 (16299.248)

Steps to Reproduce:

Start writting text-transform: property
VS Code suggests texts-emphasis first at all times even tho text-transform cleary matches more

Does this issue occur when all extensions are disabled?: Yes

also when writing text-a (as for text-align), text-emphasis pops up first

The fix for this will be out in tomorrow's Insiders. Do give it a try.


keyof any incorrectly maps (only) to type string

TypeScript Version:  2.7.1 and 2.8.0-dev.20180215

Search Terms: "keyof any"
Code
function foo<T>(bar: T, baz: keyof T) {
        console.log(bar[baz]);
}

const sym = Symbol();
const quirk = { [sym]: "thing" };

foo<any>(quirk, sym);

Expected behavior:
keyof any should be equivalent to PropertyKey (that is string | number | symbol)
The example code should compile without error.
Actual behavior:
keyof any is equivalent to string
The example code does not compile and produces error:
error TS2345: Argument of type 'unique symbol' is not assignable to parameter of type 'string'.
Playground Link:
https://www.typescriptlang.org/play/#src=function foo<T>(bar%3A T%2C baz%3A keyof T) {
        console.log(bar[baz])%3B
}

const sym %3D Symbol()%3B
const quirk %3D { [sym]%3A "thing" }%3B

foo<any>(quirk%2C sym)%3B

If symbolof (#20721) was supported, you could write it like this:
function foo<T>(bar: T, baz: keyof T | symbolof T) {
        console.log(bar[baz]);
}

const sym = Symbol();
const quirk = { [sym]: "thing" };

foo(quirk, sym);

There are no number property keys. All non-symbol property keys are either strings or numeric strings.

Whilst there are technically no number keys in reality they are often used and it would be considered inappropriate to call toString every time you wanted to index an array. In addition we already have PropertyKey defined as the three types.
It makes sense to introduce some consistency and use PropertyKey everywhere a key could reasonably be used.
That would include in interface definitions and in keyof any.
Right now keyof any is string, interface index keys are string|number, PropertyKey is string|number|symbol and in actual usage of an object we use PropertyKey.
This isn’t a duplicate because I’m proposing that the inconsistency is the bug and symbolsof would do nothing useful but increase the chaos that we’re already faced with!

I just think it's not appropriate as a widened type for the result of keyof.

How come?

I've just come up with a better example that demonstrates the inconsistency more clearly:
const foo: any = {};

// Fine
const symKey: symbol = Symbol();
foo[symKey] = null;

// Error
const keyOfKey: keyof any = symKey;

// Also error
const otherKeyOfKey: keyof typeof foo = symKey;

// Compiler output
index.ts(8,7): error TS2322: Type 'symbol' is not assignable to type 'string'.
index.ts(11,7): error TS2322: Type 'symbol' is not assignable to type 'string'

Another options would be to make keyof any equivalent to any. Because any is essentially a way to turn off type checking.

As for making keyof return symbols.... Object.keys only returns string keys at runtime, and many other JS constructs only operate over string keys. I think we may do symbolof operator to maintain compatibility and keep a distinction between the two namespaces.

@ogwh that was in @weswigham's comment for why keyof should be just strings.
As for keyof any, since this is not referring to the keys of any particular object, why not just use the PropertyKey type in your annotation instead?

I was about to agree but thought it through a bit more. :-P
To answer your question @yortus I can't use PropertyKey because in the vast majority of cases the type T is known and so to use anything but keyof T would introduce the possibility of typos.
There is no reason for keyof to maintain consistency with Object.keys() because it's only used to ensure type safety. There is an argument that the ES spec is flawed and 7.3.21 point 4.a. should be changed to include symbols but sure that might break existing code.
In effect the type checking provided by keyof is plain and simply wrong if it doesn't include symbol keys. The only times it will be used is to ensure nobody tries to improperly index an object. Right now it's preventing people from properly indexing an object.
Also the ECMAScript spec (current draft) is inconsistent itself on this:
<IP_ADDRESS> Invariants of the Essential Internal Methods
In this section we have a declaration that keys are either strings or symbols.

[[OwnPropertyKeys]] ( )
The return value must be a List.
The returned list must not contain any duplicate entries.
The Type of each element of the returned List is either String or Symbol.
The returned List must contain at least the keys of all non-configurable own properties that have previously been observed.
If the object is non-extensible, the returned List must contain only the keys of all own properties of the object that are observable using [[GetOwnProperty]].

Other sections that assert this include (I didn't do an exhaustive check):
https://tc39.github.io/ecma262/#sec-topropertykey
https://tc39.github.io/ecma262/#sec-ispropertykey
So in effect we have a standard that accepts property keys are strings and symbols, a backwards compatibility (presumably) to ensure legacy JS code doesn't break at runtime and a type checker that is observing the legacy runtime characteristics rather than the actual type characteristics of properties. The type checker itself also conceding (by the definition of PropertyKey) that a generic property of any old object should conform to compilation-time type checking expectations and not runtime expectations of legacy code.
Legacy JS doesn't benefit from Typescript enforcing what is already enforced by the runtime, yet Typescript code suffers because of the inconsistency outlined in the examples already given.
With the element type of the array returned by Object.keys always being a subset of the types of PropertyKey there's no danger there. But by keysof T being a subset of the possible actual property key types we end up with broken type checking that excludes possible values.
Finally symbolof has no practical purpose once keysof is fixed. If it were to be introduced then it would be equally valid to introduce stringsof to complement it if it's accepted that keysof is currently broken.
Phew

Ruminating on this I don't think Object.keys is ever supposed to return symbols. I think the word key is being used in reference to keys in the sense of a map and not in the sense of an actual JS object property.
That being a consequence of objects being used traditionally as maps. So we have two different usages of the word "key".
If we look at section <IP_ADDRESS> we see the proper definition of key used in reference to the getOwnPropertyDescriptors implementation:
<IP_ADDRESS> Object.getOwnPropertyDescriptors ( O )

When the getOwnPropertyDescriptors function is called, the following steps are taken:
Let obj be ? ToObject(O).
Let ownKeys be ? obj.[OwnPropertyKeys].
Let descriptors be ! ObjectCreate(%ObjectPrototype%).
For each element key of ownKeys in List order, do
Let desc be ? obj.[GetOwnProperty].
Let descriptor be ! FromPropertyDescriptor(desc).
If descriptor is not undefined, perform ! CreateDataProperty(descriptors, key, descriptor).
Return descriptors.

I don't mind having keyOf and symbolOf for backward compatibility but can we also have anyKeyOf which would return both type of keys because I can't think of a use case where I would want to use symbolOf on its own.

Having keyof only refer to string keys can be useful, introducing symbolof  seems to be the right way to go. My guess is most of the time people are going to need keyof more than symbolof anyway. If someone consistently needs both they can just create a type alias type SymbolKeyOf<T> = keyof T | symbolof T.

What's your reasoning behind:

Most of the time people are going to need keyof more than symbolof; and
Having keyof only refer to string keys can be useful

If that is the case then it seems to me to be more explicit/clear to have keyof, stringof and symbolof?
Thanks :-)

Symbols are usually used to store hidden values on an object, and are used far less than string keys.
keyof as is can be useful when using Object.keys or Object.entries which do not return symbols as keys.

keyof has already been declared as string keys, and is being used as such, why break it? It also makes sense seeing as Object.keys refers only to strings.
Can you provide a use case where you would need to use keyof T | symbolof T many times throughout? Is there a instance where an alias wouldn't be enough?

That's kind of my point! :-P Being able to pass a symbol to a function as a key to an object to access a hidden (symbol) property
Object.keys and Object.entries always return collections where object keys are strings, what's the use case where keyof would come in to play? I haven't been able to come up with one.

keyof being extended to include all of the keys of an object wouldn't break anything. You can't use any of the info from it at runtime, it's only used for type checking (which it's currently getting wrong). The current behaviour kind of is broken because it's giving compiler errors erroneously.
Yeah I could use an alias. But why use an alias when keyof is broken and fixing it won't (can't) break anything? My argument isn't one of convenience, it's that keyof is fundamentally broken as it stands at the moment.
The hard question is: how should symbols be identified in the string representation of the type generated by keyof? (This also applies to symbolof so perhaps someone has an answer over there.)

I've found another bug that emerges as a side effect to this. Because symbols aren't included in keyof a Readonly<T> where T implements the iterable protocol can't be iterated over:
class MyIterable {
    [Symbol.iterator]() {
        const it = (function*() {
            for (let s of ["foo", "bar"]) yield s;
        })();
        return it;
    }
}

const collection = new MyIterable();
const readonlyCollection: Readonly<MyIterable> = MyIterable;

for (let value of collection) {
    console.log(value);
}

for (let value of readonlyCollection) {
    console.log(value);
}

tsc output:
index.ts(17,19): error TS2488: Type must have a '[Symbol.iterator]()' method that returns an iterator.

@ogwh that could be fixed either way: either by (a) adding symbols to keyof, or by (b) adding symbolof and redefining Readonly<T> to use keyof T | symbolof T.
So yes, that is a problem with the current definitions, but its not necessary an argument for one approach over the other.

Perhaps not, but I think I've already made a strong case! That addition is just supplementary! ;-)
My biggest fear is that it becomes a case of tl;dr! >_<

For the busy people I'll summarise:

The spec defines a property key as string or symbol
Typescript defines PropertyKey as string | number | symbol even though number isn't a valid indexing type
From 2 we can infer that Typescript favours type sanity, which is good (no obj[num.toString()])
The spec defines Object.keys as returning string[]
Some claim that parity with Object.keys is important, this seems to be based on the word key
The "keys" in Object.keys refers to the specific usage of "key" when an object is used as a hash table; as in HashTableKey (made up) vs PropertyKey (which it isn't)
Object.keys already differs from the type of a property key (it's a single-item subset)
Through 2, 3, 4, 6 and 7 the argument that keyof matches Object.keys is disproven (as is point 5)
The type information from keyof is only available at compile time currently
Because symbols are guaranteed to be unique there's no possibility of it resolving to too large a set of values that may be used accidentally
Through 4, 5 and 6 we have backwards compatibility if keyof is changed now
symbolof has no use case except as a hack around the broken keyof
keyof without symbols is already a source of bugs in Typescript itself (Readonly<t> from my previous example)
Typescript is a superset of Javascript, refer to 1 :-P

I think that covers everything.

@ogwh Here's a simple example of how expanding keyof to include symbols could break existing code
const sym = Symbol();

function values <T, K extends keyof T>(obj: T) {
  return Object.keys(obj).map((key: K) => {
    return obj[key];
  });
}

const exampleObj = {
  a: 1,
  b: 2,
  [sym]: '',
};

const numbers: number[] = values(exampleObj);

Currently works perfectly, but if symbols were included you'd get the resulting type error
Type '(string | number)[]' is not assignable to type 'number[]'.

When in reality that would not be the correct type to return.
In response to some of your summary:

I think I've shown an example that proves this is not something based merely on wording. For a long time there were no symbols in JS, hence why when talking about objects, a key generally refers to a string property (even if technically the spec defines it as either string or symbol).
(+ 7, 8) I'm afraid I don't get what your point is here. Though you are correct that Object.keys does not directly correlate to keyof, in most cases though usage of keyof as the return type of Object.keys does work (and is useful).

My example above shows your proposal would be a breaking change.
symbolof would not break anything, and allow us to do everything we would need to

One last note about expanding keyof
If one were to try and separate keys into 2 types of symbol and string:
interface O {
  a; b; c;
  [sA]; [sB];
}
type OStringKeys = keyof O & string;
type OSymbolKeys = keyof O & symbol;

it would currently result in this mess:
type OStringKeys = ("a" & string) | ("b" & string) | ("c" & string)
type OSymbolKeys = (unique symbol & symbol) | (unique symbol & symbol)

(though from a glance it looks like this is something typescript could and should optimise)
if we left keyof alone and added symbolof, we'd get:
type OStringKeys = keyof O = "a" | "b" | "c"
type OSymbolKeys = symbolof O = unique symbol | unique symbol

The example you gave currently results in a compilation error because string can't be assigned to the more restricted type K. This goes back to 5, 6, 7 & 8 which still hold and invalidate 11.
It seems that tsc still emits output when there's an error in the file (version 2.7.2), and it also omits the error message when there are errors in other files. It's very bizarre behaviour and seems like a separate bug. But I'm guessing that tricked you! Try the example you gave in a clean environment and you'll get the same error I've included at the end of this comment.
12 is true but it's still a hack around the broken keyof, I still don't see any need for symbolof once keyof is brought in line with the JS spec definition of a property key.
Moreover anywhere a keyof type is used currently it will be a subset of string, so it can always be assigned to string but never vice-versa without a cast. For that reason expanding keyof can't break existing code, the worst it can do is make it easier to introduce the following bug:
const foo = Symbol();
const bar = {
  "foo": "baz",
  [foo]: "quirk"
};

function doThing<T, K extends keyof T>(obj: T, key: K) {
  // Do the thing
}

doThing(bar, foo); // Bug here
// The coder meant "foo" but left out the quotes, currently this results in a type mismatch.
// However with the change the foo symbol is perfectly valid.
// But, this bug is still possible currently and just as likely as demonstrated by:
const value = bar[foo];

Copied from your example:
function values<T, K extends keyof T>(obj: T) {
    return Object.keys(obj).map((key: K) => {
        return obj[key];
    });
}

We currently get the error:
test.ts(2,33): error TS2345: Argument of type '(key: K) => T[K]' is not assignable to parameter of type '(value: string, index: number, array: string[]) => T[K]'.
  Types of parameters 'key' and 'value' are incompatible.
    Type 'string' is not assignable to type 'K'.

I kid you not that's the actual error code too btw!

There is a breakage when we go in the other direction:
function foo(bar: string) {}
const sym = Symbol();
class Thing { [sym] = 42 };
const key: keyof Thing = sym;
foo(sym); // Error here

Damn! It would be correct, and would only affect types that already have symbol properties so it's probably very rare but it is no less a breaking change.
That's so disappointing. Can we change it anyway?! :'(

@ogwh it is producing an error you've enabled strict function types, and is due to the fact that Object.keys does not return the type (keyof T)[], there was a proposal to have it do so, but that wouldn't be correct in all scenarios (discussion on that).
Here's a updated version with strict function types enabled (Also tested locally with 2.7.2)

Thanks for the clarification, that makes sense. I've filed a new bug in relation to the JS spec which I believe is what has lead to the current situation. There's a reference notification for that just before this comment.
I'm fairly sure we can't change this in TS 2, but perhaps once the spec is clear it could be something to change in TS 3?


Shaker icon renders too small with display scaling set to 200%

I'm using Linux, so this is actually only visible for me with the recently introduced "prefer wayland" setting in Godot 4.3...

But I know of another plugin which had a similar issue and they resolved it with "When scale != 100%, convert Texture2D -> Image -> Resize by Scale -> Convert back to Texture2D" if that means anything to you (I'm a designer not a coder, so not entirely sure).

Sorry, this is a core engine issue!
https://github.com/godotengine/godot/issues/90788


Table block content can not be edited after it has been saved

Issue Summary
When using Wagtail 5.2.0 I am unable to edit content in a Table block when content has been saved
Steps to Reproduce

In a Wagtail project, create a Page with a StreamField that contains TableBlock in its block_types.
In the Wagtail admin, create an instance of this page and save it.
Add a table to your stream field, editing it as you like. This works fine.
Save the page.
Try to edit the table again.

This issue was previously raised by @nathanielwarner in Wagtail version 4.1.4

I have confirmed that this issue can be reproduced as described on a fresh Wagtail project: (yes / no)

Technical details

Python version: 3.9.2.
Django version: 4.1.13
Wagtail version: 5.2.0
Browser version: Chrome

Original issue: #10335

I cannot replicate this yet, tried making some changes that might address it in #11312 but I don't know for sure. Bumping this to 6.0 for now so it doesn't block the 5.2.2 release, but if we can replicate this or if you can confirm that the issue is fixed with #11312, then we can backport it for a 5.2.3 release at some point in the future.

Also unable to replicate on the given Wagtail / Django versions. I suspect this may have been happening due to outdated javascript files (e.g. this was happening on a production site, and ./manage.py collectstatic hadn't been run after upgrading).


YARN RM returned a failed response: 401 Client Error: Unauthorized access for url:

Is there an existing issue for this?

[X] I have searched the existing issues

Description
Symptom After hue configures yarn parameters and restarts, an error occurs when the jobs module is opened on the hue page:

Steps To Reproduce
1、config hue.ini with yarn：

[[yarn_clusters]]
[[[default]]]
[[[default]]]
resourcemanager_host=<IP_ADDRESS>
resourcemanager_port=8032
submit_to=True
resourcemanager_api_url=http://...:8088
history_server_api_url=http://...:19888

2、restart hue docker container
3、open hue web，open Jobs page
Logs
`[12/Jul/2023 22:50:28 -0700] exceptions_renderable ERROR    Potential trace: [<FrameSummary file /usr/share/hue/desktop/libs/hadoop/src/hadoop/yarn/resource_manager_api.py, line 176 in _execute>, <FrameSummary file /usr/share/hue/desktop/core/src/desktop/lib/rest/resource.py, line 157 in get>, <FrameSummary file /usr/share/hue/desktop/core/src/desktop/lib/rest/resource.py, line 78 in invoke>, <FrameSummary file /usr/share/hue/desktop/core/src/desktop/lib/rest/resource.py, line 105 in _invoke>, <FrameSummary file /usr/share/hue/desktop/core/src/desktop/lib/rest/http_client.py, line 244 in execute>]
[12/Jul/2023 22:50:28 -0700] api2         ERROR    Error running <function jobs at 0x7f07fd850940>
Traceback (most recent call last):
File "/usr/share/hue/desktop/core/src/desktop/lib/rest/http_client.py", line 235, in execute
resp.raise_for_status()
File "/usr/share/hue/desktop/core/ext-py3/requests-2.27.1/requests/models.py", line 960, in raise_for_status
raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 401 Client Error: Unauthorized access for url: http://<IP_ADDRESS>:8088/ws/v1/cluster/apps?user=root&limit=500&startedTimeBegin=1688622628000
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/share/hue/desktop/libs/hadoop/src/hadoop/yarn/resource_manager_api.py", line 176, in _execute
response = function(*args, **kwargs)
File "/usr/share/hue/desktop/core/src/desktop/lib/rest/resource.py", line 157, in get
return self.invoke("GET", relpath, params, headers=headers, allow_redirects=True, clear_cookies=clear_cookies)
File "/usr/share/hue/desktop/core/src/desktop/lib/rest/resource.py", line 78, in invoke
resp = self._invoke(
File "/usr/share/hue/desktop/core/src/desktop/lib/rest/resource.py", line 105, in _invoke
resp = self._client.execute(
File "/usr/share/hue/desktop/core/src/desktop/lib/rest/http_client.py", line 244, in execute
raise self._exc_class(ex)
desktop.lib.rest.http_client.RestException: 401 Client Error: Unauthorized access for url: http://<IP_ADDRESS>:8088/ws/v1/cluster/apps?user=root&limit=500&startedTimeBegin=1688622628000
{
"servlet":"org.eclipse.jetty.servlet.DefaultServlet-2e6a5539",
"message":"Unauthorized access",
"url":"/ws/v1/cluster/apps",
"status":"401"
} (error 401)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/share/hue/apps/jobbrowser/src/jobbrowser/api2.py", line 48, in decorator
return func(*args, **kwargs)
File "/usr/share/hue/apps/jobbrowser/src/jobbrowser/api2.py", line 73, in jobs
jobs = get_api(request.user, interface, cluster=cluster).apps(filters)
File "/usr/share/hue/apps/jobbrowser/src/jobbrowser/apis/job_api.py", line 58, in apps
return self.yarn_api.apps(filters)
File "/usr/share/hue/apps/jobbrowser/src/jobbrowser/apis/job_api.py", line 116, in apps
jobs = NativeYarnApi(self.user).get_jobs(**filter_params)
File "/usr/share/hue/desktop/libs/hadoop/src/hadoop/cluster.py", line 58, in decorate
raise ex
File "/usr/share/hue/desktop/libs/hadoop/src/hadoop/cluster.py", line 46, in decorate
return funct(api, *args, **kwargs)
File "/usr/share/hue/apps/jobbrowser/src/jobbrowser/api.py", line 112, in get_jobs
json = self.resource_manager_api.apps(**filters)
File "/usr/share/hue/desktop/libs/hadoop/src/hadoop/yarn/resource_manager_api.py", line 126, in apps
return self._execute(self._root.get, 'cluster/apps', params=params, headers={'Accept': _JSON_CONTENT_TYPE})
File "/usr/share/hue/desktop/libs/hadoop/src/hadoop/yarn/resource_manager_api.py", line 178, in execute
raise PopupException(('YARN RM returned a failed response: %s') % e)
desktop.lib.exceptions_renderable.PopupException: YARN RM returned a failed response: 401 Client Error: Unauthorized access for url: http://<IP_ADDRESS>:8088/ws/v1/cluster/apps?user=root&limit=500&startedTimeBegin=1688622628000
{
"servlet":"org.eclipse.jetty.servlet.DefaultServlet-2e6a5539",
"message":"Unauthorized access",
"url":"/ws/v1/cluster/apps",
"status":"401"
} (error 401)
[12/Jul/2023 22:50:28 -0700] access       INFO     <IP_ADDRESS> root - "POST /jobbrowser/api/jobs/jobs HTTP/1.1" returned in 5ms 200 385
[12/Jul/2023 22:50:28 -0700] access       INFO     <IP_ADDRESS> root - "POST /jobbrowser/api/jobs/jobs HTTP/1.1" returned in 5ms 200 385

<IP_ADDRESS> - - [12/Jul/2023:22:50:28 -0700] 'POST /jobbrowser/api/jobs/jobs HTTP/1.1' 200 385 'http://<IP_ADDRESS>:8880/hue/jobbrowser/' 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36'
[12/Jul/2023 22:50:28 -0700] exceptions_renderable ERROR    Potential trace: [<FrameSummary file /usr/share/hue/desktop/libs/hadoop/src/hadoop/yarn/resource_manager_api.py, line 176 in _execute>, <FrameSummary file /usr/share/hue/desktop/core/src/desktop/lib/rest/resource.py, line 157 in get>, <FrameSummary file /usr/share/hue/desktop/core/src/desktop/lib/rest/resource.py, line 78 in invoke>, <FrameSummary file /usr/share/hue/desktop/core/src/desktop/lib/rest/resource.py, line 105 in _invoke>, <FrameSummary file /usr/share/hue/desktop/core/src/desktop/lib/rest/http_client.py, line 244 in execute>]
[12/Jul/2023 22:50:28 -0700] api2         ERROR    Error running <function jobs at 0x7f07fd850940>
Traceback (most recent call last):
File "/usr/share/hue/desktop/core/src/desktop/lib/rest/http_client.py", line 235, in execute
resp.raise_for_status()
File "/usr/share/hue/desktop/core/ext-py3/requests-2.27.1/requests/models.py", line 960, in raise_for_status
raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 401 Client Error: Unauthorized access for url: http://<IP_ADDRESS>:8088/ws/v1/cluster/apps?user=root&limit=500&startedTimeBegin=1688622628000

During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/share/hue/desktop/libs/hadoop/src/hadoop/yarn/resource_manager_api.py", line 176, in _execute
response = function(*args, **kwargs)
File "/usr/share/hue/desktop/core/src/desktop/lib/rest/resource.py", line 157, in get
return self.invoke("GET", relpath, params, headers=headers, allow_redirects=True, clear_cookies=clear_cookies)
File "/usr/share/hue/desktop/core/src/desktop/lib/rest/resource.py", line 78, in invoke
resp = self._invoke(
File "/usr/share/hue/desktop/core/src/desktop/lib/rest/resource.py", line 105, in _invoke
resp = self._client.execute(
File "/usr/share/hue/desktop/core/src/desktop/lib/rest/http_client.py", line 244, in execute
raise self._exc_class(ex)
desktop.lib.rest.http_client.RestException: 401 Client Error: Unauthorized access for url: http://<IP_ADDRESS>:8088/ws/v1/cluster/apps?user=root&limit=500&startedTimeBegin=1688622628000
{
"servlet":"org.eclipse.jetty.servlet.DefaultServlet-2e6a5539",
"message":"Unauthorized access",
"url":"/ws/v1/cluster/apps",
"status":"401"
} (error 401)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/share/hue/apps/jobbrowser/src/jobbrowser/api2.py", line 48, in decorator
return func(*args, **kwargs)
File "/usr/share/hue/apps/jobbrowser/src/jobbrowser/api2.py", line 73, in jobs
jobs = get_api(request.user, interface, cluster=cluster).apps(filters)
File "/usr/share/hue/apps/jobbrowser/src/jobbrowser/apis/job_api.py", line 58, in apps
return self.yarn_api.apps(filters)
File "/usr/share/hue/apps/jobbrowser/src/jobbrowser/apis/job_api.py", line 116, in apps
jobs = NativeYarnApi(self.user).get_jobs(**filter_params)
File "/usr/share/hue/desktop/libs/hadoop/src/hadoop/cluster.py", line 58, in decorate
raise ex
File "/usr/share/hue/desktop/libs/hadoop/src/hadoop/cluster.py", line 46, in decorate
return funct(api, *args, **kwargs)
File "/usr/share/hue/apps/jobbrowser/src/jobbrowser/api.py", line 112, in get_jobs
json = self.resource_manager_api.apps(**filters)
File "/usr/share/hue/desktop/libs/hadoop/src/hadoop/yarn/resource_manager_api.py", line 126, in apps
return self._execute(self._root.get, 'cluster/apps', params=params, headers={'Accept': _JSON_CONTENT_TYPE})
File "/usr/share/hue/desktop/libs/hadoop/src/hadoop/yarn/resource_manager_api.py", line 178, in execute
raise PopupException(('YARN RM returned a failed response: %s') % e)
desktop.lib.exceptions_renderable.PopupException: YARN RM returned a failed response: 401 Client Error: Unauthorized access for url: http://<IP_ADDRESS>:8088/ws/v1/cluster/apps?user=root&limit=500&startedTimeBegin=1688622628000
{
"servlet":"org.eclipse.jetty.servlet.DefaultServlet-2e6a5539",
"message":"Unauthorized access",
"url":"/ws/v1/cluster/apps",
"status":"401"
} (error 401)
[12/Jul/2023 22:50:28 -0700] access       INFO     <IP_ADDRESS> root - "POST /jobbrowser/api/jobs/jobs HTTP/1.1" returned in 4ms 200 385
[12/Jul/2023 22:50:28 -0700] access       INFO     <IP_ADDRESS> root - "POST /jobbrowser/api/jobs/jobs HTTP/1.1" returned in 4ms 200 385

<IP_ADDRESS> - - [12/Jul/2023:22:50:28 -0700] 'POST /jobbrowser/api/jobs/jobs HTTP/1.1' 200 385 'http://<IP_ADDRESS>:8880/hue/jobbrowser/' 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36'`

Hue version
gethue/hue:latest

Hi @zhangzhaohuazai and thank you for reporting. We will try to have someone take a look shortly. @wing2fly can you have a look?

@zhangzhaohuazai is your Yarn a Kerberos-secured?
From your STR, I don't see such config:
https://github.com/cloudera/hue/blob/master/desktop/conf/pseudo-distributed.ini.tmpl#L1280-L1281


‘’ Either .total_ops ’’ is the error log?

logs:
Either .total_ops or .total_params is already defined in Conv2d(3, 16, kernel_size=(3, 3), stride=(2, 2), padding=(1, 1), bias=False).Be careful, it might change your code's beh avior. Either .total_ops or .total_params is already defined in BatchNorm2d(16, eps=1e-05, momentum=0.1, affine=True, track_running_stats=True).Be careful, it might change your code's behavior.

total_ops is already defined in your model, as shown in the log file.

total_ops is already defined in your model, as shown in the log file.

I also encounter this problem. How to solve it?


[#2PlaysAmonth] emoji guess game

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #954
Added the emoji game and its component on the specified branch
Type of change
Adding a game
Motivation
This was a card game that really fascinated me, the game is simple and uses usestate to implement the game
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
The test was conducted on all the possible outcome or result of the game, ]
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist:

[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Screenshots or example output

Hi @rashy10
When you create the PR, there is an option to specify the issue link.
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Please edit the description and put it

@rashy10 what's the issue number?

@rashy10 what's the issue number?

Hi sir, the issue number is #954

@rashy10 Kindly resolve the merge conflicts

Hi @rashy10 Could you please make the PR ready for merge?

hi sir I have made the changes , can you check again sir

@rashy10 you seem to have closed the PR

yes sir i closed it some issue , i couldnt really understand so closed it , now made new PR #1008

yes sir i closed it some issue , i couldnt really understand so closed it , now made new PR #1008

You were very near to completion. You just had to run the linting and formatting commands mention in the readme @rashy10.
IMO, its not great to leave the hard work because you need to understand it. We are available on Discord to help you and make you understand. So feel free to get back at any time. Thanks!

yes sir i closed it some issue , i couldnt really understand so closed it , now made new PR #1008

You were very near to completion. You just had to run the linting, and formatting commands mentioned in the readme @rashy10.
IMO, it is not great to leave the hard work because you need to understand it further. We are available on Discord to help you and make you understand. So feel free to get back at any time. Thanks!

Yes sir sure,Sir I understood the mistake and corrected it in the new PR #1008 ,the linting and formatting is done sir, I am new to github ,so was trying and exploring to make PR, now figured out how github works ,so tried new PR #1008 , the problem is with cypress run


Postgres issues

This pull request deals primarily with two postgres issues.
First, when it comes to updating the stats in postgres the connection was being refused because of too many connections.
Second, there was a refactoring of the way that the facts are being stored in postgres.  This required a change to the way that queries that gather the stats information were written.

Can we improve the README build section to include how you build.
Also, a section on how to add a new statistic would be very useful

I addressed all of these issues (and Greg's request for documentation) in my latest commit. I will push this commit once Andre (or Greg?) grants me access to the bulkfhirloader repository.


Use sqlite3 instead of pandas.

Avoids needing pandas installed which seems impossible in OSX due to code signing rules.
Uses iconv and sqlite3 binaries to convert the CSV rather than using Python for performance.

Ok, I did some test on Windows. I put the necessary binarys and dlls in a bin folder within the plugin folder an got it working.
But it needs quite some changes:
These are the lines I've modified: https://github.com/Bouni/kicad-jlcpcb-tools/blob/39be32c7a8d29418fda9b65dac305b5ef080ce71/library.py#L64-L65
        iconv_path = os.path.join(self.bindir, "iconv.exe")
        with open(utf8_path, "w") as f:
            subprocess.call(
                [iconv_path, "-f", "gbk", "-t", "UTF-8", self.csv], stdout=f
            )
        os.chdir(self.bindir)
        subprocess.call(
            [
                "sqlite3.exe",
                "../jlcpcb/jlcpcb_parts.db",
                "-cmd",
                f".import --csv '../jlcpcb/jlcpcb_parts_utf8.csv' jlcpcb_parts",
            ],
            stdin=subprocess.DEVNULL,
            stderr=subprocess.DEVNULL,
        )

Maybe we can somehow pipe these with subproccess popen / communicate magic 🧙🏽
These are the .exe files and the dll files, mostly from the GnuWin repo on sourceforge:
iconv.exe
libcharset1.dll
libiconv2.dll
libintl3.dll
sqlite3.exe

I've not yet looked into the licences to judge if we can simply ship them with the plugin ...
For sure we need to build some kind of os switch logic into this in order to get it working.

Ok, I did some test on Windows. I put the necessary binarys and dlls in a bin folder within the plugin folder an got it working. But it needs quite some changes:
These are the lines I've modified:
https://github.com/Bouni/kicad-jlcpcb-tools/blob/39be32c7a8d29418fda9b65dac305b5ef080ce71/library.py#L64-L65
        iconv_path = os.path.join(self.bindir, "iconv.exe")
        with open(utf8_path, "w") as f:
            subprocess.call(
                [iconv_path, "-f", "gbk", "-t", "UTF-8", self.csv], stdout=f
            )
        os.chdir(self.bindir)
        subprocess.call(
            [
                "sqlite3.exe",
                "../jlcpcb/jlcpcb_parts.db",
                "-cmd",
                f".import --csv '../jlcpcb/jlcpcb_parts_utf8.csv' jlcpcb_parts",
            ],
            stdin=subprocess.DEVNULL,
            stderr=subprocess.DEVNULL,
        )

This quick test worked for me in Windows:
sqlite = 'y:\\downloads\\sqlite-tools-win32-x86-3360000\\sqlite3.exe'
iconv = 'y:/downloads/gettext0/bin/iconv'
csv = 'y:/downloads/jlcpcb_parts.csv'
subprocess.check_call([sqlite, '-cmd', '.import --csv "|%s -f gbk -t UTF-8 %s" jlcpcb_parts' % (iconv, csv), 'c:\\temp\\test.db'], stdin = subprocess.DEVNULL, stderr = subprocess.DEVNULL)

Note the iconv and csv path need to be forward slashes otherwise they get munched going through sqlite, I tried escaping the back slash version (passing them through shlex.quote) but it failed with a different error:
sqlite = 'y:\\downloads\\sqlite-tools-win32-x86-3360000\\sqlite3.exe'
iconv = 'y:\\downloads\\gettext0\\bin\\iconv'
csv = 'y:\\downloads\\jlcpcb_parts.csv'
subprocess.check_call([sqlite, '-cmd', '.import --csv "|%s -f gbk -t UTF-8 %s" jlcpcb_parts' % (shlex.quote(iconv), shlex.quote(csv)), db], stdin = subprocess.DEVNULL)
The filename, directory name, or volume label syntax is incorrect.
<pipe>: empty file

Maybe we can somehow pipe these with subproccess popen / communicate magic 🧙🏽

I had a look but I can't see how to get sqlite's .import command to read from stdin (on windows anyway, on Linux/OSX /dev/stdin would probably work)
IMO it's not a deal breaker if we have to run iconv and sqlite serially - it is a bit slower but not that much.

I've not yet looked into the licences to judge if we can simply ship them with the plugin ...

Sqlite is public domain: https://www.sqlite.org/copyright.html
The iconv libraries are LGPL but the binary is GPL: https://www.gnu.org/software/libiconv/ (look for "copyright")
There is win-iconv (https://github.com/win-iconv/win-iconv) which uses Win32 APIs and is public domain but I have not tested it.

For sure we need to build some kind of os switch logic into this in order to get it working.

Yeah, I think detecting Windows is pretty easy though.


Api docs refactor

Fixes #78

Adds the location parameter to the catalog.create_table(...) example for more context.
Adds the code to initialize the catalog in a database if this was not done previously

@Fokko do you mind reviewing this PR ?


Animation editor NodePath:Assign

invalid path
1 add call function track
2 pass 1 parameter (type:NodePath)
3 tie any node
the path is incorrect. first will be a lot Moussoro.
I would like to convey is not the way to the backing necessary and himself Offer.

@ret80 ~ Seems like automated translation didn't work for you. Can you add the source text (in your native language), so we can understand it more easily?

en:
1 Create an animation.
2 adds "add call function track"
3 Specify any Node and any func.
4 Set parameter 1 to the transfer. Parameter Type NodePath
5 Make Assign
When playing this animation in callBack comes to setting the path to the linked Node. So this way is not true.
ru:
1 Создаем анимацию.
2 Добавляем "add call function track"
3 Указываем любую Node и любую func.
4 Устанавливаем 1 параметр на передачу. Тип параметра NodePath
5 Делаем Assign
При проигрывании этой анимации в callBack приходит параметр с путем к привязанной Node. Так вот этот путь не верный.

Ok, I can confirm this. The problem is that the NodePath is assigned an editor-only path (/root/EditorNode/@@7/@@11/@@13/@@17/@@21/@@22/@@23/@@39/@@40/@@42/@@47/@@8386/@@8297/@@8298/@@8299/@@8300/@@8301/TestCube/world/Area2D2/CollisionShape2D), and not a path relative to the AnimationPlayer's root or function track's object.

Seems like the problem is at https://github.com/godotengine/godot/blob/master/tools/editor/animation_editor.cpp#L3641

My family comes from Ukraine (you probably guessed already by my last name)
, but unfortunately I don't understand russian :(
On Wed, Jan 27, 2016 at 10:09 AM, Bojidar Marinov<EMAIL_ADDRESS>wrote:

Seems like the problem is at
https://github.com/godotengine/godot/blob/master/tools/editor/animation_editor.cpp#L3641
—
Reply to this email directly or view it on GitHub
https://github.com/godotengine/godot/issues/3448#issuecomment-175613782.

but unfortunately I don't understand russian :(

That's why we'll let @bojidar-bg handle this one :D

@reduz ~ The problem is that the path assigned by AnimationEditor Function Track Argument Properties (NodePath argument) is editor-only, and not relative to Function Track's node. (so it is something of the sort /root/EditorNode/@@7/@@11/@@13/@@17/@@21/@@22/@@23/@@39/@@40/@@42/@@47/@@8386/@@8297/@@8298/@@8299/@@8300/@@8301/world/Area2D/CollisionShape2D)
To reproduce (my nomenclature might be wrong):

Create a new Function Track
Add a Function Call
Chose some random function (preferably one that prints its first argument)
Increase number of arguments to 1
Set argument type to NodePath
Assign any node from the scene
Play and see that some global, editor-related path is printed...

BTW, I know just a very little bit of Russan, but I know Bulgarian, and that's enough for me to understand it :wink:
P.S. I can provide a video of it :smile:

OK I think I understand the problem, this is indeed quite an obscure use case.. trying to fix it anyway

Теперь не работает: Сlear

Так как калбек срабатывает в скритпе который работает на анимационной ноде то путь должен быть построен от анимационной ноды а не от ее родителя.

My Russian is soooo rusty and he makes typos  :( but I think he wants to say something like:

Now it does not work: Clear
As callback works in the script that works on an animation node, the same path should be created from an animation node and not from it's parent.

1 earned "assign" but stopped working "clean"
2 path must be "../n1/n2" instead of "/n1/n2"

the path will always be from the node the animation track refersto to, just
as if you were editing that node directly
fixing clean, give me a second
On Tue, Feb 2, 2016 at 6:41 PM, ret80<EMAIL_ADDRESS>wrote:

1 earned "assign" but stopped working "clean"
2 path must be "../n1/n2" instead of "/n1/n2"
—
Reply to this email directly or view it on GitHub
https://github.com/godotengine/godot/issues/3448#issuecomment-178840833.


Add a simple API to access open positions (HJ's take)

Building on top of the idea in https://github.com/cesko-digital/cd-tools/pull/3. Work in progress. Abusing Zeit's live previews to develop in production. Will mark this for a review when ready.
➡ CLICK HERE FOR INSTANT BLISS

Closing this in favor of https://github.com/cesko-digital/cd-tools/pull/3, after I've got push access I'll continue there.


Serialization failed for IAuthenticationResult

I am trying to use spring jdbc session and I want to store the IAuthenticationResult object returned on calling ClientConfidentialParamter.acquireToken() method. However, I keep getting the error that IAuthenticationResult cannot be serialized. I looked into it and realized that IAuthenticationResult is an interface. AuthenticationResult is the subclass but I cannot use it as its visibility is default in the package and I dont have access to it. Is there anyother way to serialize/deserialize IAuthenticationResult data?

Hello @abhijeetsaxena7 : Unfortunately, I don't think there's a quick way to serialize IAuthenticationResult/AuthenticationResult objects themselves. We plan on discussing this issue, and make serialization of these objects more straightforward in a future update.
For now though, the best workaround I can suggest is to extract the data you need from the IAuthenticationResult into a custom object, and serialize that.

Maybe we should add a demonstration in our samples for this.

Hello @abhijeetsaxena7 : Unfortunately, I don't think there's a quick way to serialize IAuthenticationResult/AuthenticationResult objects themselves. We plan on discussing this issue, and make serialization of these objects more straightforward in a future update.
For now though, the best workaround I can suggest is to extract the data you need from the IAuthenticationResult into a custom object, and serialize that.

I create my own class for and stored tokenCache and account details and then serialized that class.

Hello @abhijeetsaxena7 : Glad you were able to work around this issue. We plan on making IAccount serializable in the next update, to help with things like setting up .acquireTokenSilently() calls and searching through the results of .getAccounts().
However, we don't plan on making IAuthenticationResult serializable, as we don't think there is a good use-case for that: all of the token info they contain can be found in the token cache (which is serializable), and once IAccount is serializable there'll be no reason to store the IAuthenticationResult instead of the IAccount and the token cache.
Could you share a bit of your use case here? Was there some specific need/convenience to store IAuthenticationResult objects in session rather than the token cache, and would the ability to serialize/store the IAccount from an auth result along with the token cache solve that issue?

The msal java Web app sample stored the entire IauthenticationResult object in the session. After carefully studying the code, I realised it was misleading and corrected my storage options. I am now only storing IAccount and Token cache.


Added custom menus and improved tray for electron wrapper

Added custom menus and improved tray for electron wrapper

All menu links now link to this repo
Tray now has a toggle mute option

Gonna create a new cleaner pull


Add Vectr 0.1.7

Adding Vectr.app version 0.1.7.
Their homepage can be found here: https://vectr.com/

This cask is already present (see what you’re really submitting).

Sorry about that @vitorgalvao, I should've updated brew cask first. :+1:


Fixing the carousel in RTL languages

Fixes https://github.com/Microsoft/pxt-microbit/issues/1426
Tested in Edge, Firefox, Chrome, and IE

Looks good, we should also test this on touch devices.

FYI iPhone the carousel is too sensible and capture drag gesture as horizontal. Would be nice to address this too.

^^ agreed with Peli, but perhaps in a different change ;)

This PR doesn't really change how touch is handled at all, just reverses the direction in RTL


New files for terraform/environments

This PR was automatically created via a GitHub action workflow 🤖

This PR commits new files under terraform/environments.

test not required


[otelfiber] Allow for disabling client IP collection in traces

Introduces a WithCollectClientIP(collect bool) that disables IP collection into traces.

Summary by CodeRabbit

New Features

Enhanced privacy settings with the ability to control the collection of client IP addresses in requests.
Middleware function now collects client IP addresses by default.
Attribute handling now includes client IP based on configuration.
Improved middleware configuration using functional parameters.

I wasn't sure how to update the README.. The README currently describes the config fields, but they are private as functional parameters are used instead. This PR introduces a field which is entirely private, so it can not be accessed.

I wasn't sure how to update the README.. The README currently describes the config fields, but they are private as functional parameters are used instead. This PR introduces a field which is entirely private, so it can not be accessed.

Fair!

@gzuidhof Why is the config setting private and can only be changed using the help function?
Regardless of the answer, please also include the help function with signature and explanation in the readme
Every feature without examples or explanation gives the user fewer hints and is therefore questioned, is not known or is not used
Only transparency and hints help to avoid questions and make it usable for everyone

I'm happy for you (or anybody else) to make changes to this PR as you see fit :)
There is no mechanism for passing in your own Config object anyhow, so it doesn't really matter if it's public or private - so better to default to private was my thinking. Aside from that, with something that defaults to true setting it to false would not do anything.
The discoverability for these functional parameters are in your language server suggestions.. otelfiber.With...
Anyhow: happy for you to make any changes, just explaning my reasons :)

okay thanks for the explanation
can you include the signatures of the "with" methods and their explanation in the readme

f.e. https://docs.gofiber.io/api/middleware/proxy#signatures

Done! :)

thx for the adjustment
@gzuidhof  can you also check these suggestions

from our ai

I addressed them in this commit, I think it hasn't refreshed

ok, thx

@coderabbitai can you pls check the last state again


1.0.0 release - move to semantic versioning?

sb-edit has plenty room to shake up in the future - #53, #93, #98, #100 - and maybe some of these are issues that we want to address before giving it a spiritual "1.0.0" release. But, on a practical level, it is now a package which certain other software depend on (i.e. leopard-website). Although package-lock.json has long addressed the worst concerns, still, to the end of smooth updates within package.json constraints, semantic versioning is a useful thing.
leopard was published as a semver project basically immediately. As far as we're aware there has only just recently even been a concern about bumping leopard to 2.x.y, see: https://github.com/leopard-js/leopard/pull/201#issuecomment-2207857285.
Changing toLeopard (we should perhaps change all such interfaces?) to be async - #154 - is a breaking change. One that's easy to prepare for - PullJosh/leopard-website#64 - but still breaking.
We don't personally see semantic versioning as making a statement about a certain "quality" or any other guarantee, for a project. It's just saying: this package has interfaces for usage in your code project, and they will continue to work, in the same shape, until the next major release.
We have somewhat arbitrarily used minor and patch 0.x.y versions and could discuss what we want to "count" for a minor/patch bump more specifically, but personally the main motivation is to treat breaking changes as major version bumps, so they can be more plainly documented e.g. in release notes or summaries of major API changes (maybe some of the issues linked at the top of this issue).

I'm on board with this as a practical choice. I think my gut instinct is to be precious about major releases, but there's no practical reason to treat them that way, as far as I can tell. Using major releases as a clear marker of breaking changes seems wise, and it makes sense to publish 1.0.0 so that we can then bump to 2.0.0 when we release a breaking change to the API.


[Bug] Focused content hover disappear when leaving the editor

Focused content hover disappears when leaving the editor whereas it should remain visible until unfocused

Not sure if this is very important. Will fix this if there are sufficient requests.


"Create a dev drive" missing from End-to-End setup

Dev Home version
0.401.226.0
Windows build number
10.0.23545.0
Other software
No response
Steps to reproduce the bug

Install Insider Dev build
Install Dev Home (Preview)
Log in to GitHub account in Dev Home
Start End-to-end setup from Machine configuration
select "Add repository" and choose one

Expected result
Ability to check "Create Dev Drive to optimize performance"
Actual result
mentioned option is not available
Included System Information
Dev Drive option is available in system settings however.
Included Extensions Information
No response

Hi @pdsccode this will be resolved in v0.5 which is coming soon. Thanks


Issues getting light binning to work

Thanks for this guide! I'm trying to adapt it for my own engine.
I noticed that when viewing the scene from oblique angles, the lights do not appear to bin properly. The issue is shown in this video:
https://github.com/user-attachments/assets/98f44506-c14e-468a-8db0-ae30e5e8644f
Do you know of any common mistakes that can cause this? I'm using reverse-Z and my depth range is [0,1] rather than [-1,1], so I changed the screenToView function to this:
vec3 screenToView(vec2 screenCoord)
{
    // normalize screenCoord to [0, 1] and
    // set the NDC depth of the coordinate to be on the near plane.
    vec4 ndc = vec4(screenCoord / ubo.screenDimensions, 0, 1.0);

    vec4 viewCoord = ubo.inverseProjection * ndc;
    viewCoord /= viewCoord.w;
    return viewCoord.xyz;
}

Everything else is a direct port of the code shown on the guide.

Hi, the screenToView function should still normalize xy to [-1, 1]. Reverse z should only have changed the range of the z coordinate.
vec3 screenToView(vec2 screenCoord)
{
    // normalize screenCoord to [-1, 1]
    // z = 0.0 (near plane in reverse z)
    // w = 1.0
    vec4 ndc = vec4(screenCoord / screenDimensions * 2.0 - 1.0, 0.0, 1.0);

    vec4 viewCoord = inverseProjection * ndc;
    viewCoord /= viewCoord.w;
    return viewCoord.xyz;
}

Thanks for the quick response! The change to screenToView seemed to have helped a little bit, but it's still not fully working:
https://github.com/user-attachments/assets/efcdeec5-336c-4e24-aa80-4fbbb61af004
The froxels themselves look fine, so I don't think it has to do with consumption in the fragment shader (here I'm outputting the computed froxel coordinates):

Here are my exact grid build and light assignment shaders:
cluster_build_grid.csh
cluster_assign_lights.csh
cluster_shared.glsl
Are there other common mistakes that could cause this?

Well one common problem is the light attenuation affecting fragments beyond the light's defined radius. It can cause those lighting artifacts.
This happens when light's radius encompasses only part of a cluster. The light is assigned to the cluster, but not all the fragments in the cluster should be lighted.
So if you're using an attenuation like 1.0 / (dist * dist), you should add a range check.
        if (distanceToFragment >= lightRadius)
        {
            attenuation = 0.0;
        }

 if (distanceToFragment >= lightRadius)
{
     attenuation = 0.0;
}

I tried adding this, and it had no effect.
To me, it seems like it's undershading rather than overshading. For example the chunk missing from the red light on the right side of the triangle:

This looks like it was erroneously not included in that cluster when it should have been. I'm currently setting the light's radius to well beyond the effective attenuation range, so to me it seems like something else would be causing it.
From my debugging, the radius of the point light was slightly too small to be included in that froxel:

Could it be that there's an error in the bounds calculations for the froxels?

I found the source of the problem - the C++ code was calculating the wrong radius for the lights (the values were too small). Fixing this fixed the issue. Thanks for your help!

Glad to hear!


Multiple font-pickers

Hello, what would be the best method to have multiple font-pickers?

Unfortunately, it is currently only possible to have one font picker. I will look into it though and keep you updated.

I just added the option to have multiple font pickers on the same site.
For them to work, you need to give both font pickers a name, and then use these names in the respective divs where the font pickers should be generated, and also in the class names where the fonts should be applied to.
Here's an example:

Text in font 1

Text in font 2

Hope this helps :)

Works great, thanks for the update!


[Feature][Metrics][TubeMQ] Add grafana dashboard json template

Description
Agent and DataProxy have added:
https://github.com/apache/inlong/tree/master/inlong-tools/grafana/dashboards
TubeMQ Metrics for Prometheus:
https://inlong.apache.org/docs/next/modules/tubemq/configure_introduction

Use case
No response
Are you willing to submit PR?

[ ] Yes, I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hello,Please assign this to me

@ogkunald thanks.

I would love to contribute in this task! If no one is working on this, can you please assign it to me

@bibhu107 do you have a plan to work on this issue?

@dockerzhang Hello, I am occupied with few other priority tasks for now, so don't have enough bandwidth for this one.

I would like to work on this issue.


Shared app launcher icon for both platforms

Most apps share the icon they use for both platforms and so it would be great if it was possible to specify an app launcher icon for both the iOS project and Android project without having to delve into both projects and adding image files in two separate locations.
I think the current way is specified within this Stack Overflow question: https://stackoverflow.com/questions/43928702/how-to-change-the-application-icon-on-flutter
The assets and images guide describes how you can have shared assets among both projects, perhaps this would be the best place to include shared app launcher icons? Default projects could come with this asset directory preloaded with the default flutter icon which is used as an app launcher icon for both apps.
Perhaps for the very few cases where developers want to specify slightly different app launcher icons, you could configure the pubspec.yaml so that you can declare if you want a shared app launcher icon or if not, could specify what app icon from the asset directory that you want for each platform.
# The following section is specific to Flutter.
flutter:

  # The following line ensures that the Material Icons font is
  # included with your application, so that you can use the icons in
  # the material Icons class.
  uses-material-design: true

  # Line for having a shared app launcher icon
  uses-shared-app-icon: true

  # if above line isn't used then the next two lines would be required to supply icon for both platforms
  android-app-icon: 'assets/android-icon/*'
  ios-app-icon: 'assets/ios-icon/*

Not sure if this idea would be a good way to specify the shared icons but having the ability to do so would be greatly appreciated.

cc @szakarias

I'm not sure you want this.  The UI guidelines for the two platforms are different.
There are however a variety of tools which can help you generate the two sets of icons from a single  source image.
e.g. https://romannurik.github.io/AndroidAssetStudio/ or https://itunes.apple.com/us/app/iconkit-the-icon-resizer/id507135296?mt=12 are ones I've used in the past.

@eseidelGoogle what do you mean?
The UI guidelines for the app design are different yes but in terms of the icon which the user clicks on, it's the same for both platforms unless you're specifying different android icons for the adaptive icons in Oreo or above.
In that case you could create a directory within the assets/android-icon/ directory and have one for each or the adaptive icon shapes.
Otherwise I don't see why you couldn't just use the identical icon for both.

As an example, here are the launcher icons for stocks for iOS:
https://github.com/flutter/flutter/blob/master/examples/stocks/ios/Runner/Assets.xcassets/AppIcon.appiconset/Icon-60%402x.png
https://developer.apple.com/ios/human-interface-guidelines/icons-and-images/app-icon/
And Android:
https://github.com/flutter/flutter/blob/master/examples/stocks/android/app/src/main/res/mipmap-xxxhdpi/ic_launcher.png
https://developer.android.com/guide/practices/ui_guidelines/icon_design.html
The size, the borders (or lack there of) as well as shading are all expected to be different.  And that's not even considering round icons for Android, or the various sizes which need to be generated for both.
These sorts of generations are definitely automatable.  Just not sure Flutter itself has a lot of value add here (at least not in the short term).

Ionic has feature:
http://blog.ionicframework.com/automating-icons-and-splash-screens/

Is this something someone could build a simple/small script to handle?
The pubspec.yaml file is designed to be extensible, so you (and others) can add more custom metadata there.
Then, you could write the Dart code to read the custom metadata from pubspec.yaml and "do the right thing" with the image assets. Then, you could publish that util script to pub.
Users can install your package, and then run it from the command line (because pub, when it installs packages, can put package bin scripts into your path).
Then, your users can run your script via some build tool or task runner.
Basically, I think you don't necessarily require the flutter tool to perform these kinds of asset manipulations and managements. I think what's required is for us to help you contribute this kind of functionality to the ecosystem. And we're very happy to do that.
Thoughts?

Im guessing you could use something like this.
https://pub.dartlang.org/packages/image
Then use that as a base to generate the images.

@MarkOSullivan94 , would you like to create a package like this to contribute?, I would be more than happy to help.

Starting work at https://github.com/franzsilva/flutter_launcher_icons

Added changes which should allow for generation of iOS icons and allow you to specify what platform you want to generate the icons for. Just waiting for @franzsilva to test it out and then merge the pull requests into the repo.

Done Merging the changes. We have a 0.1.0 version of the plugin. I think this issue can be closed. it basically does what was originally intended. Future version POC to generate formated images like round, square with shadow, padding is in the works.

https://pub.dartlang.org/packages/flutter_launcher_icons


Add the possibility to add a subject line in the letter

This is simply the suggestion given by Matthias Baur on launchpad
https://answers.launchpad.net/moderncv/+question/222784 in comment 12
Closes #113
It works well for my purposes and looks decent. Maybe the spacing before the subject line could be bigger, let me know what you think.

Looks good to me - @jranke would you squash to one commit and rebase?

OK, sure, I squashed the two commits to one, the branch is already based on the latest commit of your master branch.

Yes, good idea! Will do so in a minute


Memory leaks?

hi, it looks like there is a memory leak in this library. I have a list 10 items with a shadow, these items rerenders/changes over the time. The memory is constantly increasing and finally the app crashes due to low memory. Without this shadow the memory does not grow.
with drop shadow:

without drop shadow:

hey, what tool is this for checking memory usage?

Hey @lelukas, these screenshots of memory usage are from Android studio.

Hey @mamartin，is the problem solved?

Hi @GabeJing, i dont think its fixed since there is no reply. I had to stop using this library because of this as i need my app to run very long (weeks).

@mamartin Did you use any other alternatives?

@GabeJing no


Fix autolayout conflict on devices > 4"

The "Use Touch ID" button had a fixed left margin, fixed width and fixed right margin. And it used only 15px from the bottom. This commit removes the margins for a center-in-container constraint, makes the width a greater-than or equal and uses a standard 20px distance from the bottom.

r=me


cognito-idp sign_up

Piggy backing off of PR #2151

Coverage decreased (-0.3%) to 94.057% when pulling bdbb5b9cb3af529b14bb037724a102b6a359071a on fadur:cognitoidp-signup into 0317602ae503ab384a56a3c04a1d36e919b99e39 on spulec:master.

Hi @bblommers
@xsphrx have been collaborating to add support for cognitoidp please see #3260 where initiate_auth is covered.

Looks like everything is now covered in #3260, so I'll close this. Thanks for the PR!


TFRS - [Tech Debt] Refactor UNSAFE_componentWillReceiveProps

Description of the Tech Debt
There are some legacy class based components that are still using the deprecated UNSAFE_componentWillReceiveProps lifecycle method. These components should be refactored to use a more modern approach to updating component state. There are approximately 33 components that need to be refactored, and a similar solution will most likely work for each of them.
Tech Debt Triage
The purpose of our technical debt triage process is to analyze technical debt to determine risk level of the technical debt and the value in tackling that technical debt.

Discussed at stand-up: There are approx. 33 separate components that require different solutions. Jignesh to detail what he has done and then new card to be created to deal with the remaining components.

Here is a list of the changed components:
/CarbonIntensityLimitEditContainer.js
/DefaultCarbonIntensityEditContainer.js
/EnergyDensityEditContainer.js
/EnergyEffectivenessRatioEditContainer.js
/PetroleumCarbonIntensityEditContainer.js
/FuelCodeEditContainer.js
/HistoricalDataEntryContainer.js
/HistoricalDataEntryEditContainer.js
/UserAddContainer.js
/UserEditContainer.js
/Navbar.js
/SessionTimer.js
/ChangelogContainer.js
/ComplianceReportingContainer.js
/ComplianceReportingEditContainer.js
/ScheduleAContainer.js
/ScheduleBContainer.js
/ScheduleCContainer.js
/ScheduleDContainer.js
/ScheduleSummaryContainer.js
/AutosaveNotifier.js
/CreditTransferAddContainer.js
/CreditTransferEditContainer.js
/DashboardContainer.js
/components/UserSettings.js
/ExclusionReportEditContainer.js
/OrganizationEditContainer.js
/SecureFileSubmissionDetailContainer.js
/SecureFileSubmissionEditContainer.js

Raj to test test pages relating to the list to check this is all working properly.


checkout.addPromotionPlaceholder snippet no longer has any effect

PHP Version: 8.3 | Shopware Version: <IP_ADDRESS>  | Affected area / extension: Platform(Default)

Expected behaviour:
When no voucher is added I expect the placeholder snippet in the voucher field to be shown.
Actual behaviour:
When no voucher is added the placeholder snippet in the voucher field is no longer shown since <IP_ADDRESS>
How to reproduce:

Install SW <IP_ADDRESS> and <IP_ADDRESS> with demodata
Place an item in the shopping cart and call up the OffCanvas or the entire shopping cart.

!checkoutsnippet_1.png|width=384,height=669,alt="checkoutsnippet_1.png"!
!checkoutsnippet_2.png|width=381,height=708,alt="checkoutsnippet_2.png"!

[public] Shopware automated response: This issue is linked to the internal issue: NEXT-40052
[created from NEXT-40052, comment 526378]

[public]

Priority changed to: Low

Thank you for your report. After careful consideration, we've concluded that this issue does not require immediate attention or isn't something we can address right now. We prioritize openness and clear communication with our community, so we want to be transparent. We may not resolve all reported issues, and this one might remain unresolved. To stay effective, we periodically clean our backlog, and this issue could be closed in the future.
For now, we'll keep this ticket open to invite further feedback from the community in case we've underestimated its impact and to allow us to revisit it later.
[created from NEXT-40052, comment 526866]


You say version 3.7.1 can also use 1.21.1. However, the latest version of PurPur 1.21.1 has an error and cannot be used.

You say version 3.7.1 can also use 1.21.1. However, the latest version of PurPur 1.21.1 has an error and cannot be used.
log out error lines
Caused by: Incompatible Minecraft version. This version of HuskSync is designed for Minecraft 1.21.3.
Please download the correct version of HuskSync for your server's Minecraft version (1.21.1).
But Will said:
"HuskSync supports Minecraft 1.20.1, 1.21.1, and 1.21.3. You must download the correct JAR file for your server version from https://william278.net/project/husksync#download"
Supports 1.21.1?
Why my latest PurPur 1.21.1 can't move version 3.7.1 ?
Pleease thanks in advance.

Multiple jars are published for each release. Please get in touch on discord for support related matters.


[#336] Add scripts to deploy the operator

will this actually work on minikube. I switched the KUBE to kubectl and ran install_opr.sh but:
$ kubectl get pods
NAME                                                  READY   STATUS             RESTARTS   AGE
activemq-artemis-controller-manager-db6db4f59-lrjjx   0/1     ImagePullBackOff   0          2m42s

this is because we haven' t release yet quay.io/artemiscloud/activemq-artemis-operator:1.0.6
you could change the image defined in deploy/operator.yaml to quay.io/artemiscloud/activemq-artemis-operator:1.0.5


Diff is compared with oldest snapshot/history in default

Describe the bug
When you open the diff view of an entry, the diff is compared with the oldest snapshot/history of the webpage. Maybe this problem is related to #709
Version
v0.39.15 - Docker Container updated today
To Reproduce
Steps to reproduce the behavior:

Open a diff of a page of your choice.
See that diff is compared with the oldest snapshot/history

Example page: https://changedetection.io/share/Wh4zVpfbKm4a
Expected behavior
The diff should be compared with the newest version of the webpage
Screenshots

Desktop (please complete the following information):

OS: Windows
Browser Chrome
Version 103.0

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context

Err, it says right there that the newest is being compared

Sorry, my explanation wasn't that good.
The newest snapshot should be compared to the second newest snapshot of the web page. Currently the oldest ist selected from the dropdown list.
As you can see in this screenshot, there are newer versions available:

But if I just open the diff page, the oldest snapshot is pre selected. I think this behavior was different some versions ago.

Ok, i'll make a new release soon, so the situation is more clear :)


Fixed #25189 - Allowed DateTimeField to validate datetime.isoformat() strings

using new DATETIME_INPUT_FORMATS values which match the naive-datetime case of JSON encoded values.
Tested for:

a naive datetime with microseconds
a naive datetime without microseconds
a datetime with UTC tzinfo (which would end up as a special value "Z", which to my awareness isn't parsable by strptime)

Ticket link for reference

Test failure in Jenkins seems unrelated to my changes, but I don't use GIS, so someone else would need to verify:
Traceback (most recent call last):
  File "/home/jenkins/workspace/pull-requests-trusty/database/mysql_gis/label/trusty-pr/python/python3.4/tests/gis_tests/test_geoip.py", line 78, in test03_country
    self.assertEqual('United States', func(query), 'Failed for func %s and query %s' % (func, query))
AssertionError: 'United States' != 'Vietnam'
- United States
+ Vietnam
 : Failed for func <bound method GeoIP.country_name of <django.contrib.gis.geoip.base.GeoIP object at 0x7f848912cbe0>> and query www.google.com

Yes, that test failure is tracked in https://code.djangoproject.com/ticket/25183.
This would also need documentation (docs/ref/settings and release notes), but we need to figure out interaction with localization (e.g, should it be added to every locales formats.py?) I'm not much of an expert here, so please write to the mailing list if needed.

The joys of being monolingual. I rather assumed that the locale specific ones would be a series of additions or removals from the defaults, but certainly grepping the conf/locale suggests that is not the case.
By my count, I'd need to touch 40 locale/*/formats.py files.
I also think I'd need to touch the eo (Esperanto) locale doubly, because while that accepts %Y-%m-%d %H:%M:%S, unlike the 39 others, it does not accept %Y-%m-%d %H:%M:%S.%f. I am presuming that as a language it still has the same measurement units of time.

Closing per ticket.


[BEAM-2120] Do not repeat log messages in DataflowPipelineJob

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[ ] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[ ] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[ ] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[ ] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

R: @jkff

Coverage increased (+0.02%) to 70.17% when pulling 401eef09a0dc94dc2ed1e4afcaa30259d922ba3f on kennknowles:DataflowPipelineJob into 9f2733ac460ce42d6b3bd49f3db1bacb771ef85c on apache:master.


Update init.py with conversion of deprecated async_get_registry to async_get - bringing PR over from OG repo

async_get_registry is deprecated and was removed in 2023.5.0. Converted use of the deprecated function to the replacement async_get
@nguilbault
Update init.py
580daad
@bdraco
bdraco commented on May 4, 2023
You also need to remove the await on this line
https://github.com/nguilbault/homeassistant_ecowitt/blob/[580daad](https://github.com/garbled1/homeassistant_ecowitt/pull/153/commits/580daadfa84e4206e2f1207d028e504c5a143b0f)fa84e4206e2f1207d028e504c5a143b0f/custom_components/ecowitt/__init__.py#L421
@nguilbault
Update init.py
46bf366
@nguilbault
Author
nguilbault commented on May 5, 2023
good catch - that's what I get for assuming that a function named async_get is actually async.
@mattdevo1
mattdevo1 commented on May 7, 2023 •
Thank you! Fixed my problem after upgrading to 2023.5. Although it looks like this project is dead at this point and there is an official Ecowitt integration now, so I guess I'll be migrating soon.
@rpajik
rpajik commented on May 9, 2023
@nguilbault Help a lot, thx. @mattdevo1 official Ecowitt integration is cloud based :-(
@seidler2547 seidler2547 mentioned this pull request on May 9, 2023
https://github.com/garbled1/homeassistant_ecowitt/issues/155
Open
@mattdevo1
mattdevo1 commented on May 9, 2023
@nguilbault Help a lot, thx. @mattdevo1 official Ecowitt integration is cloud based :-(
The official integration is Local Push (not cloud based) - https://www.home-assistant.io/integrations/ecowitt/
Your Ecowitt hub pushes data to Home Assistant locally. There is no cloud involved.
@rpajik
rpajik commented on May 9, 2023
@nguilbault Help a lot, thx. @mattdevo1 official Ecowitt integration is cloud based :-(
The official integration is Local Push (not cloud based) - https://www.home-assistant.io/integrations/ecowitt/
Your Ecowitt hub pushes data to Home Assistant locally. There is no cloud involved.
Sorry, my fault. thx
@cheechm13 cheechm13 mentioned this pull request on May 25, 2023
https://github.com/elad-bar/ha-blueiris/issues/208
Closed
@nliaudat
nliaudat commented on Jun 14, 2023
This repo is dead. Has anyone a good replacement or working fork ?
@mattdevo1
mattdevo1 commented on Jun 14, 2023
This repo is dead. Has anyone a good replacement or working fork ?
Have you tried the official integration?
https://www.home-assistant.io/integrations/ecowitt/
I haven't migrated yet. Would be interested to hear if it works for you.
@DMcGav
DMcGav commented on Jun 29, 2023
good catch - that's what I get for assuming that a function named async_get is actually async.
Thanks guys - great fix!

PR has changes already fixed by PR #6


Incorporate tekton/catalog recommendations

Tekton has a nice document with recommendations for Task authors: https://github.com/tektoncd/catalog/blob/main/recommendations.md we should incorporate the suggestions in this project.
Most importantly is this one that deals with string interpolation of params, we need to address this in our tasks.

/kind bug
/priority urgent

/triage accepted


Add support for unix domain socket

Now client can listen on a unix domain socket, server can also connect to a unix domain socket.

This pull request is now managed with CodeReviewHub. Refresh.


Correlation of Activation Maps from Grad-Cam with Prediction Scores

This is probably more of a theoretically question than a practical issue. Is it expectable that, when using grad-cam, the class producing the strongest heatmap is the predicted class?
I am using an inception-V3 network fine-tuned for a 5-class classification problem. The class activation maps produced by visualize_cam seem reasonable for most of the cases. However, I have noted that sometimes my predicted class does not present a particular strong heatmap.
For instance, I have an image with predicted score 0.78 for class 2. But activation maps produced for classes 0 and 1 are much "stronger" than the one from the class 2.
Is this an expected behavior? Or I might have a bug in my implementation? I was under the impression that the strongest class activation map should be the one from the predicted class, but not sure if this is inherently true for all the cases.

If you look at the code for visualize_cam you can tell it is calling visualize_cam_with_losses to return the normalized gradients for one class, this normalization may show a larger CAM for other classes may seem "stronger" than the correct one.

Thank you for your interesting question and your intuitively answering.
(Strictly speaking, even if the gradients was NOT normalized, the CAM does NOT indicate value that is relating predicted score of model.)
For now, we'll close this issue, but please feel free to reopen this issue whenever you need.
Thanks!


"Delete" is incomplete

When I use "Delete", only the entries from the language files are deleted. The entry in the neutral file still exists.
Is this a bug or a feature? :)

Maybe you have cell-selection active? In this case it will of course delete the selected cells only.

Yes, cell-selection is active. I'm going to disable the option.
It is confusing and unintuitive when you select the row with a right-click on the first column, and then only the cells of the languages are emptied during the delete. :)

Would it be an option to call it "Clear" when cell-selection is active?

And maybe just disable it if any of the fixed columns are selected...

UX should be improved here...


[Add] Flush Animated Button

Details
I would like to propose the addition of a "Flush Button" feature to our website.
The flush button will have an interactive animation that mimics water flushing over the button when hovered.
When the user hovers over the button, a water-like filter effect will smoothly flow down from the top of the button, covering half of its surface.
Screenshots
No response
Type of Contribution

[ ] Update to an existing Animated Button
[X] Adding a new Button
[ ] Resolving a bug
[X] Proposal to the Repository
[ ] Changes related to documentation or README.md
[ ] Other Changes

Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue
[X] I am a GSSoC'23 contributor

🎉 The GSSOC'23 program has reached its conclusion, prompting us to officially close all pull requests (PRs) and issues. We extend a heartfelt thank you for your amazing contributions! 🙌 Keep the coding spirit alive with the same enthusiasm, and may luck 🍀 favor you in all your future coding adventures!


Typings file for jsblocks framework

I have created typings for jsblocks framework.

@ksmigiel Thanks mate!

@horiuchi  You too man, for merge!


Allow us to go a little deeper in relations for Spatie Media Library Table Column

This is a bug fix for the Spatie Media Library Table Column. Previously there were errors if attempting to use a media collection nested on a relation of the main table record.
There are no documentation or visual changes to add.

Thanks!


Add command for teleporting one player to another, even if they are on different servers

Why? In slice mode, players on the same world will be on different servers and it can be extremely difficult to teleport to one another as the Minecraft server executing the command may not know the location of the players.
A solution is a new command: /mtp <target-player> <destination-player>. It could work like this on a high level

Alice is on server A and Bob is on server B. Alice issues /tp Alice Bob
Server A sends a GlobalMessage with replication IncludingSelf with parameter “MinecraftTeleportPositionLookup“ and a flex field including Alice’s in the target field and Bob in the destination.
Server B receives this message, looks up Bob’s location, and creates a similar message with parameter “MinecraftTeleport” including Alice’s name and bob’s location.
Server A receives this and teleports Alice to the provided coordinates.

works gr8