Breakpoint Condition not working

Type: Bug
I have this code (in Dart)
        if ((a is Income && b is Income) || (a is NotaFiscal && b is NotaFiscal)) {
          bool isIncome = a is Income;
          return b.id!.compareTo(a.id!);
        }

and a breakpoint at the return line with this condition isIncome == true
but it prints at the console this:
Debugger failed to evaluate breakpoint condition "isIncome == true": [Sentinel kind: OptimizedOut, valueAsString: ] from evaluateInFrame()
VS Code version: Code 1.81.0 (Universal) (6445d93c81ebe42c4cbd7a60712e0b17d9463e97, 2023-08-02T12:40:02.782Z)
OS version: Darwin arm64 22.6.0
Modes:

System Info

Item
Value

CPUs
Apple M1 Pro (10 x 24)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
3, 3, 3

Memory (System)
16.00GB (0.06GB free)

Process Argv
--crash-reporter-id f7f4ec88-0a9f-4aa6-938f-1dbd8f0228f0

Screen Reader
no

VM
0%

Extensions (23)

Extension
Author (truncated)
Version

flutter-snippets
ale
3.0.0

ng-template
Ang
16.1.8

dart-code
Dar
3.70.0

flutter
Dar
3.70.0

xml
Dot
2.5.1

gitlens
eam
14.2.0

chatgpt-vscode
gen
0.0.8

copilot
Git
1.101.317

copilot-chat
Git
0.6.0

vscode-github-actions
git
0.26.1

vscode-pull-request-github
Git
0.70.0

githd
hui
2.3.3

rest-client
hum
0.25.1

Kotlin
mat
1.7.1

git-graph
mhu
1.30.0

vscode-docker
ms-
1.26.0

remote-containers
ms-
0.304.0

remote-wsl
ms-
0.81.0

awesome-flutter-snippets
Nas
4.0.1

docthis
oou
0.8.2

vscode-yaml
red
1.14.0

intellicode-api-usage-examples
Vis
0.2.7

vscodeintellicode
Vis
1.2.30

(1 theme extensions excluded)

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492:30256859
vstes627cf:30244335
vslsvsres303:30308271
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30410667
vsclangdf:30486550
c4g48928:30535728
dsvsc012:30540252
pynewext54:30695312
azure-dev_surveyone:30548225
vsccc:30803844
3biah626:30602489
f6dab269:30613381
2i9eh265:30646982
showlangstatbar:30737416
vsctsb:30748421
03d35959:30757346
pythonfmttext:30731395
pythoncmv:30756943
fixshowwlkth:30771522
showindicator:30805244
pythongtdpath:30769146
i26e3531:30792625
gsofb:30804716
pythonnosmt12:30797651
pythonidxptcf:30805731
pythonnoceb:30805159
dsvsc013:30795093
dsvsc014:30804076

/causedByExtension
The extension providing Dart debugging is responsible for evaluation of conditions.

This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the marketplace for VS Code. See also our issue reporting guidelines. If you don't know which extension is causing the problem, you can run Help: Start extension bisect from the command palette (F1) to help identify the problem extension.
Happy Coding!


dep: Bump windows to v0.48

Bump dep windows to its latest release.

Supersedes #9

This doesn't really supersedes #9 since it also replaced windows by windows-sys to make dep bumps less frequent, avoiding such PRs in the future

This doesn't really supersedes #9 since it also replaced windows by windows-sys to make dep bumps less frequent, avoiding such PRs in the future

Thanks, I've hidden that comment now,


NOPs slow down my algorithm

They take unnecessary clock cycles; you should rewrite the bytecode so that it does not have NOPs

Fixed by 2b0f5e5. Note that there are still NOP instructions in the generated code, but they are never executed, as they are preceded by JUMP_FORWARD or JUMP_ABSOLUTE instructions.

I did run the example from the README, with %timeit range(0, 1000) in ipython:
 10000 loops, best of 3: 72.9 µs per loop @ CPython 2.7.10 with NOP
 10000 loops, best of 3: 77.2 µs per loop @ CPython 2.7.10 with JUMP_FORWARD
 10000 loops, best of 3:  106 µs per loop @ CPython 3.5.0  with NOP
 10000 loops, best of 3:  106 µs per loop @ CPython 3.5.0  with JUMP_FORWARD
100000 loops, best of 3:  8.6 µs per loop @ PyPy 2.4.0     with NOP
100000 loops, best of 3:  8.7 µs per loop @ PyPy 2.4.0     with JUMP_FORWARD

So it turned out that one JUMP_FORWARD instruction isn't any faster than 7 NOPs. In Python 2.7, JUMP_FORWARD is even slower. So I reverted the change: d19d244.
Alternatively, one could strip the code completely instead replacing it. However, the you have to adjust jump targets, which isn't probably worth it.


More precise site matching

I saw when I had goodsite.com it would also match goodsite.com.evilsite.com, so I was able to fix it. Doing so also ended up fixing the color bleed problem. Fixes #10.

I was aware of this problem but had not fixed it.
Thank you for this patch!


Fixes #42: ImportError for safe_join

Not really sure if this breaks something else, please verify

Fixed Import Error caused by regression from Flask version 2.1.0 update

Duplicate of #41.


Appconfig kv restore

Added appconfig kv restore command, tests and help. Please add Azure appconfig relevant users to this PR.
This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

[x] I adhere to the Command Guidelines.

@tjprescott can you take a look at this pr. Thanks!

@tjprescott could you help complete this PR?

@bariscaglar  please resolve conflicts in your files.

@bariscaglar have you signed for license/cla?


feat: Full Stack Chat Application

Description 📜
This application will have entire chat functionality. Use of Tailwind CSS for designing frontend with node.js and express.js to handle the backend API. For real time data transfer Socket.io will also be used.
Requirements 🛠
The app needs realtime data or chat transfer.
Functionality of sending friend request.
Bonus ✨
Can add media transfer in future by using Amazon S3 bucket for storing Images or any media.
⭐I would love to contribute the addition of this new mini-react project to the this repository.

@ojasggg This is beginner-friendly React JS repo, please add only Reeact based Front-end app

Got it, my bad.


Shortening the link to link to the vlog videos playlist.

Related Issue/Addition to code

I think that this link is very long https://www.youtube.com/watch?v=dBUHBrYB_bQ&list=PL6x5Q-Sj_BlYlBoxMa_jo7LO3OSUhhbru&index=1 to be linked in README.md, so I adjusted it with a bit.ly link which I just created.

Type of change

[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Proposed Changes

Update link preview to link to vlog series to https://bit.ly/minecraftvlogseries instead of https://www.youtube.com/watch?v=dBUHBrYB_bQ&list=PL6x5Q-Sj_BlYlBoxMa_jo7LO3OSUhhbru&index=1

Additional Info

@codyseibert You have your website, you can link it directly instead of going through bit.ly, a third party source via a redirect like https://webdevjunkie.com/minecraftvlogseries or anything else, bit.ly has most of the stuff taken, but that's not a restriction with using your own domain.

Screenshots

Original
Updated

** original screenshot
** updated screenshot **

Not inculding screenshots for this PR

thanks for the work.  BTW, webdevjunkie.com isn't my website

thanks for the work. BTW, webdevjunkie.com isn't my website

Your welcome, thanks for merging them in. Oh oh, I thought that was your website. But you can use any domain you own, in the future or currently own and always edit it instead of a bit.ly link. But, for now a bit.ly link should be good!


Add option to sum all fields for a player

For pitching, batting, and appearances modules add option to sum all data using people/playerID/batting?total=true

Appearances

G_all
GS
G_batting
G_defense
G_p
G_c
G_1b
G_2b
G_3b
G_ss
G_lf
G_cf
G_rf
G_of
G_dh
G_ph
G_pr

Batting

G
G_batting
AB
R
H
2B
3B
HR
RBI
SB
CS
BB
SO
IBB
HBP
SH
SF
GIDP

Pitching

yearsTotal
W
L
G
GS
CG
SHO
SV
IPouts
H
ER
HR
BB
SO
BAOpp
ERA
IBB
WP
HBP
BK
BFP
GF
R
SH
SF
GIDP


Fix Invoker.injectParameters(): vararg handling; injection handling

I've added (actually changed existing) two tests; both fail on current version.
First (VarArgsDataProviderTest) is about data provider's vararg handling:

method with no vararg parameter works
method with the only vararg parameter works
method with mixed not vararg and vararg parameters fails to execute

Second (NoInjectionTest) is about data provider & method parameter's @NoInjection annotation handling.

Fixed by #923


Onboarding Existing account to AFT with retry

Describe the outcome you'd like
I'm looking for a feature where AFT includes a built-in retry mechanism during the process of importing existing accounts into AWS Control Tower. Ideally, this feature would automatically attempt the enrollment process a few times for on boarding existing account, especially considering that Control Tower enrollments can take a bit of time and might not always succeed on the first try.
Is your feature request related to a problem you are currently experiencing? If so, please describe.
Yeah, the issue I'm facing is that enrolling existing AWS accounts into Control Tower can often take longer than expected. When I try to manage these accounts using AFT, there's no built-in way to automatically retry the enrollment if it fails initially. This means I have to keep an eye on the process and manually retry, which is a bit of a hassle and not very efficient.
Additional context
Nothing much to add, just think this would be a cool improvement for AFT users.

@annguyen36 thank you for reaching out with the feature request.
I have added it to our internal backlog.


improve variants section on product creation

Is your feature request related to a problem? Please describe.
Currently product variants creation requires "save" and "queued job" before it populates.
Describe the solution you'd like

doesn't require save to populate the variant table
able to fill/edit minimal variant info (sku, price, stock, backorder, purchasablity) in base product page

example: https://youtu.be/qukulIfqtjs?t=136
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

@glennjacobs @markmead any thoughts? this screen is during the product creation, edit will be pretty much the same. if this design is good to go then I can work on the backend logic to save the product and also a PR

I think I would be happy to see a PR on this. We need to consider the SKU generation and validation config.
@alecritson do you agree?


Add,remove, & update various sources

Remove sources

ManhwaIndo (ID)
Manhwaland (18+) (ID)
They're no longer updating mangas/manhwas

Add new sources:

Manhwalist (ID)

Update sources:

KomikTap (18+) (ID)

Checklist:

[x] Updated source's version for individual source changes
[x] Updated all sources' versions for template changes
[x] Set appropriate nsfw value
[x] Did not change id even if a source's name or language were changed
[x] Tested the modifications by running it on the simulator or a test device

do the sources still work? as long as the websites exist and sources work, I don't think they should be removed if they're just not adding anything new to the site

do the sources still work? as long as the websites exist and sources work, I don't think they should be removed if they're just not adding anything new to the site

The site are still alive, but there's an error with the sources. "Failed to load chapter", even though there's no changes with the sites / sources and i cannot fix that

alright if the sources are broken that's fine then


Table Extraction format

Hello @SuleyNL,
Thank you for the awesome work. I was wondering if it is possible to extract the tables in some other format other than xml?
like csv or json or any other.
I will be waiting for your response

Hi, @Dipankar1997161,
Yes thats possible!
Many filetypes are supported. But not all of these have been tested yet.
Supported Filetypes can be seen in the Extractable.Filetypes.py file:
class Filetype(str, Enum):
    EXCEL = 'xlsx'
    LATEX = 'tex'
    PARQUET = 'parquet'
    PDF = 'pdf'
    IMG = 'img'
    XML = 'xml'
    JSON = 'json'
    CSV = 'csv'
    HTML = 'html'
    YAML = 'yaml'

You can provide the desired Filetype when calling any of the extract() functions like so:
import extractable as ex
ex.extract(input_file, output_dir,  output_filetype=ex.Filetype.CSV)

This should output your desired filetypes in the output_dir.

Keep in mind Extractable is still a work in progress, so you can contribute by leaving valuable feedback or by making changes in the code.


Sb roi handles

Attempting to save spectra on mzieg-roi-handles created an error message. This happens because Measurement is relying on Multispec to carry a reference to Graph. The solution was to give Measurement a ctl parameter so it can reference Graph directly.
With this comes some more refactoring. Any class that depends on a live instance takes a ctl parameter, including ColumnFileParser which depends on a save_options and a measurements instance. Self contained classes such as DashFileParser do not need (and should not have) the ctl parameter.

Measurment gets a ctl parameter as well as some other parameters. Only the save_options and measurements fields were removed. MeasurementFactory keeps some of it's copied references not because that's the ideal state, but to limit the scope of this PR. That class has ctl tacked along with the other parameters (redundant).
Remember any time you inherit from an object you can simply omit inheritance for the exact same meaning. Object is inherited by default.

Any interest in just giving Controller a static get_instance() method so that any code in ENLIGHTEN can just grab their own Controller instance anytime they want, and we won't need to keep passing it around?
Good refactor.  Apologies for trying to merge code that clearly wasn't ready.

Yes that would be interesting.
One possible downside is that no longer would classes be identified as self-contained or not. For instance ColumnFileParser is not self contained because it takes a ctl param and depends on some Enlighten instances, but DashFileParser is self contained and can be trivially copied to another program.
But generally yes, in fact that would make Enlighten more compliant with Enlighten Extended Development section 4.4.


More small gardening

Some more small fixes I noticed while fixing dladdr stuff.

@swift-ci smoke test and merge

@swift-ci smoke test and merge


some perfo

Hi Angerman,
Hope this can be of help to you, let me know on IRC if anything isn't clear.
My fork is here: https://github.com/duog/data-bitstream
There's enormous improvement in the synthetic cases, not much change in the rest.
before/after benchmarks on my machine here:
https://gist.github.com/duog/d86400d6f50789b78e62f4000f2251c3
Runtime is still dominated by garbage collection, so it's possible there is a memory leak, I didn't get to looking into heap profiles.
I think the main problem was that right associated binds in Bitstream would result in right accumulated mappends in Stream. i.e.
s1 <> (s2 <> s3 )

which means that s3 is bitshifted twice.
I made several changes:

Changed Bitstream  to be a newtype of a state monad. This is one less thing to worry about, and we can be sure the state accumulates strictly.
Introduce a new accumulating type data Streams f a = Streams (Seq Stream f a, Position). This allows us to delay the bitshifting until the end, ensuring it is left associated.
Add a bunch of specialize pragmas, at least some of these helped but I don't know which ones :)

Hi @duog! Thanks for this. The code with the L.mapAccumL has some rather nasty space leak. I'll try to get some more reasonable real world examples, which seem to show this behavior much better than the synthesized ones.


ZEPPELIN-3907. Add code statement into Spark JobGroup Id for SparkInterpreter

What is this PR for?
Straightforward change to add code statement into Spark JobGroupId, so that we can find the associated spark job in spark ui easier.
What type of PR is it?
[ Improvement ]
Todos

[ ] - Task

What is the Jira issue?

https://jira.apache.org/jira/browse/ZEPPELIN-3907

How should this be tested?

Manually tested.

Screenshots (if appropriate)

Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

While this is a really nice feature to have, it does introduce some risk of information leakage in an organization. Take for example select * from tableofsecrets where secretcolumn = 'supersecret'.
What about adding a configuration parameter for activating this feature?

Another option is to set Spark JobGroup Id to paragraph's title ..


hover effect is added issue #256

issue #256 of hover effect has been fixed
Kindly merge this PR Under GSSOC'24

Issue already solved!


Consider some vim configurations

Vim [configuration tutorial] that might be helpful.

Tips

scroll faster with vim
most productive shortcuts list SOF
switching to vim
ctrl [ is the same as esc


Patch 1

Thanks for the PR but I don't want to document adapter specifics in the README. Users can read the documentation of the adapters

Ok, but is necessary including some information about adapters could require some extra configuration


Prepare next monthly update

Fix script for December.
Signed-off-by: Daniel Holbach<EMAIL_ADDRESS>

We need to figure out if we can get an update out for December (I won't have time).
Or we combine the Dec+Jan update.

Planned release: 2023-02-01.


Issues when importing LayerComponents (from Constructions)

Hi,
I think I have found another bug, similar to those already reported. I am using the Importer/Exporter and the energy-ADE-citydb updated and compiled as of today (27.4.2021).
I have created a sample data containing 2 constructions. Upon import, gml_id, name and description properties are not imported. The LayerComponent objects are assigned a (new) id generated upon import. All other objects are imported correctly.
Here the sample file. The data are compliant with the KIT profile.
Sample_construction.zip

Thanks for your careful testing, @gioagu. Yes, was indeed a similar bug in the citygml4j parser module. Fixed here: https://github.com/citygml4j/energy-ade-citygml4j/commit/e9dea8aae98a546f330105fe9d6c34231f56ef61

fixed in version 1.2.1


tf.reshape() fails for shapes containing non-32 bit precision TF integer types

Environment: TensorFlow v1.3.0-rc2-20-g0787eee 1.3.0 running on Mac OS X (v10.12.6)
Issue:
Function tensorflow.reshape() works when provided a list-based shape containing tf.int32; but, fails for, e.g., tf.int16 and tf.int64 with error message TypeError: List of Tensors when single Tensor expected.
Example:
import tensorflow as tf
src = tf.constant(list(range(32)))
for dtype in ['int32', 'int64', 'int16']:
	print("Calling tf.reshape using 'tf.{:s}'".format(dtype))
	tf.reshape(src, [tf.cast(16, dtype), 2])

The behavior is expected, see API: tf.reshape

shape: A Tensor. Must be one of the following types: int32, int64. Defines the shape of the output tensor.

Not sure I fully understand. The API seems to suggest that it should work for both int32 and int64. In the example provided above, the first iteration (using int32) succeeds but the remaining do not.

Yes, you're right. The shape must be either int32 or int64, unfortunately, mixing them is not permitted. To be honest, it is not convenient. Perhaps you can open a feature request:-)

By the way, cast shape to valid type might be useful for you.
In [9]: tf.reshape(src, tf.cast([tf.cast(16, tf.int64), 2], dtype=tf.int64))
Out[9]: <tf.Tensor 'Reshape_1:0' shape=(16, 2) dtype=int32>

Thanks for helping to clarify this issue. Using what you've mentioned, the following work for both int32 and int64: tf.reshape(x, tf.cast([16, 2], dtype)). This usage pattern suffices for my purposes; however, I would like to point out the following nuance (which still seems like a bug).
Of the following, the former works but the latter does not:
tf.reshape(x, [tf.cast(16, 'float32'), tf.cast(2, 'float32')]) #works
tf.reshape(x, [tf.cast(16, 'float64'), tf.cast(2, 'float64')]) #fails

Presumably, support was added somewhere along the lines to allow for the first convention; otherwise, it should throw the same exception as the latter --- namely: TypeError: List of Tensors when single Tensor expected

It's not perfect, I agree with you, @j-wilson .
However, note that tf.cast([16, 2], dtype) is a tensor, while [tf.cast(16, 'int64'), tf.cast(2, 'int64')] is a list of tensors. In fact, tf.shape expects a tensor for shape.

Thank you for helping our friend @facaiy. The Python API makes a best effort to do type coercion, to make TensorFlow easier. It's highly nontrivial code and I'm not sure if collections with these sorts of mixed types was considered. While I'm sure it's something we'd like to support, I'm not sure if there would be performance ramifications to recursive type coercion. Therefore it might not be a feature we'd consider.
Also, one thing you might want to consider is to express these operations as TensorFlow operations, which could be verbose, but might help ensure that graph is fully defined and there isn't any performance bottlenecking magic that's happening.


⛔ Error starting agent for character Eliza

I am getting error starting Eliza character when  I run pnpm start --characters="characters/eliza.character.json" yet I have added all the necessary inputs in the .env file

+1
were you able to resolve


⚠ ClamAV has degraded performance

In 506c034, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 69 ms

Resolved: ClamAV performance has improved in e9f2c9a.


Primary Key Data Annotations are randomly being ommited (Database first)

I'm using EF Core Power Tools to do a Reverse Engineer for my database model. When the tool used EFCore 2.1.4, everything was working as expected when generating my model in code from my DB. But the tool got updated to EFCore 2.2 and now when reverse engineering, my classes are being randomly generated without the Primary Key Data Annotation
Checking the issue with @ErikEJ who authored EF Core Power Tools, he was able to reproduce the issue and said that the issue is with EFCore's reverse engineering.
https://github.com/ErikEJ/EFCorePowerTools/issues/180
I would appreciate your help.
Steps to reproduce

Create a project and have the EFCore Power Tools 2.2.12 VSIX installed
Create a DB in SQL with the following two tables

CREATE TABLE [dbo].[Arr_Cat_MontoGasolina](
	[IdCat_MontoGasolina] [int] IDENTITY(1,1) NOT NULL,
	[MontoGasolina] [int] NOT NULL,
	[Borrado] [bit] NOT NULL,
 CONSTRAINT [PK_Arr_Cat_MontoGasolina] PRIMARY KEY CLUSTERED
(
	[IdCat_MontoGasolina] ASC
)WITH (PAD_INDEX = OFF, STATISTICS_NORECOMPUTE = OFF, IGNORE_DUP_KEY = OFF, ALLOW_ROW_LOCKS = ON, ALLOW_PAGE_LOCKS = ON) ON [PRIMARY]
) ON [PRIMARY]

GO

ALTER TABLE [dbo].[Arr_Cat_MontoGasolina] ADD  DEFAULT ((0)) FOR [Borrado]
GO

CREATE TABLE [dbo].[Arr_Cat_Paso](
	[IdCat_Paso] [int] IDENTITY(1,1) NOT NULL,
	[Paso] [nvarchar](30) NOT NULL,
	[Borrado] [bit] NOT NULL,
 CONSTRAINT [PK_Arr_Cat_Pasos] PRIMARY KEY CLUSTERED
(
	[IdCat_Paso] ASC
)WITH (PAD_INDEX = OFF, STATISTICS_NORECOMPUTE = OFF, IGNORE_DUP_KEY = OFF, ALLOW_ROW_LOCKS = ON, ALLOW_PAGE_LOCKS = ON) ON [PRIMARY]
) ON [PRIMARY]

GO

ALTER TABLE [dbo].[Arr_Cat_Paso] ADD  DEFAULT ((0)) FOR [Borrado]
GO

Right click the project in the Solution Explorer in Visual Studio, and select Reverse Engineer->Select Connection->Select Tables ->

Choose the following options on the last screen and run the tool

Further technical details
EF Core version: 2.2 (Used by EF Core Power Tools 2.2.12), 2.1.4 Used by my project
Database Provider: Microsoft.EntityFrameworkCore.SqlServer
Operating system:  Windows 10
IDE: Visual Studio 2017 15.8.7

Answered here https://github.com/ErikEJ/EFCorePowerTools/issues/180#issuecomment-465699609
This is non-issue.

Thanks for your support. I understand what happened and made the necessary changes in my database.


feat: experiment detail

What problem does this PR solve?
This PR adds a temporary experiment detail page, I will optimize it in the future.
What is changed and how does it work?

Adapt mobile interface
Add events preview of experiment card
Add experiment detail page

Does this PR introduce a user-facing change?

Codecov Report

Merging #593 into master will decrease coverage by 0.25%.
The diff coverage is 54.43%.

@@            Coverage Diff             @@
##           master     #593      +/-   ##
==========================================
- Coverage   55.98%   55.73%   -0.26%
==========================================
  Files          67       68       +1
  Lines        4324     4383      +59
==========================================
+ Hits         2421     2443      +22
- Misses       1733     1769      +36
- Partials      170      171       +1

Impacted Files
Coverage Δ

api/v1alpha1/iochaos_types.go
40.00% <ø> (ø)

controllers/iochaos_controller.go
85.71% <ø> (ø)

pkg/chaosdaemon/time_server.go
88.23% <ø> (ø)

pkg/webhook/config/config.go
17.14% <ø> (ø)

pkg/utils/selector.go
51.42% <40.00%> (-1.06%)
:arrow_down:

pkg/store/experiment/experiment.go
38.77% <45.23%> (ø)

controllers/twophase/types.go
55.88% <74.07%> (+0.09%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af17a74...e1d030c. Read the comment docs.


missing features forgot password, reset password, user management.

Thank you very much for this.  A couple of routes that seem to be missing are the ones listed above.
Like in the default breeze example in the routes auth.php it has
Route::post('/forgot-password', [PasswordResetLinkController::class, 'store'])
                ->middleware('guest')
                ->name('password.email');

Route::post('/reset-password', [NewPasswordController::class, 'store'])
                ->middleware('guest')
                ->name('password.store');

Route::get('/verify-email/{id}/{hash}', VerifyEmailController::class)
                ->middleware(['auth', 'signed', 'throttle:6,1'])
                ->name('verification.verify');

Route::post('/email/verification-notification', [EmailVerificationNotificationController::class, 'store'])
                ->middleware(['auth', 'throttle:6,1'])
                ->name('verification.send');

I am guessing I could just add these to the web.php but since you had this listed as a feature and user management, I wanted to make sure I was not missing something.  Cheers!

 I'm grateful for your input. Indeed, those routes are absent. If you're interested, you're welcome to contribute to their addition. Alternatively, I can take care of adding them, but there might be times when I'll need your assistance with them.

Thanks. I would be happy to contribute but right now I am very new to Laravel and am using this as a learning project.

forgot password, password reset add on API & Frontend. Verification will be added soon.

awesome!

user management add done. pull the latest code. User Verification will be added soon.

Thank you very much for this project.  Cheers!


Cleanup and release

Post #18 TODO list:

[x] investigate ways to improve performance
[x] DRY up some of the numerous select statements using the nil channel trick I talk about here (definitely feels weird to be referencing my own talks now)
[ ] changelog
[ ] release new version (1.0.1 or 1.1? it is technically only a bug fix, but still a fairly substantial behaviour change)

After several experiments with involved benchmarking, I can't find any changes that recover the performance lost by #18 (tested on Go 1.5.1). I guess we'll just have to live with it.


Unable to change account in acquireTokenRedirect

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Other... Please describe:

Browser:

[x] Chrome version XX
[x] Firefox version XX
[x] IE version XX
[x] Edge version XX
[x] Safari version XX

Library version

Library version: 1.1.3

Current behavior

Due to the login hint a user is not able to switch his/her account when using acquireTokenRedirect even though the option is available in the microsoftonline screen. This is only relevant if there is still an account in cache by MSAL but the session has ended (this can be reproduced by fiddling with the cookies and localstorage. The issue is not applicable for all users but there are some enterprise users with certain policies where this issue occurs).
Following error is provided
AADSTS50058 A silent sign-in request was sent but none of the currently signed in user(s) match the requested login hint.

Expected behavior

Either the user should not be able to switch his/her account during the acquireTokenRedirect flow
or the token response should correctly provide a new preferred_username and update the local account state so the login can be completed and a token can be retrieved.

Minimal reproduction of the problem with instructions

Login as normal using loginRedirect
Remove the cookies from microsoftonline.com and remove the msal.authority session key or localstorage key (depending on config, issue occurs in both instances)
Attempt to get a token using acquireTokenRedirect and choose "Log in with another account"
The auth response will still have the previously logged in preferred_username which means acquireTokenSilent will fail again due to an account mismatch

@LiamMartens We can't support changing accounts while acquiring an access token currently because we don't support scenarios with multiple accounts. If you need to login with a new account, you should call loginRedirect/loginPopup. When we have support for multiple accounts, you should be able to call acquireTokenRedirect as you described.


Ability to click in specific Chrome tab?

I like this tool, but I can't figure out how to specify to click in a specific Chrome tab. I have the process ID but the process name for each tab is just "chrome". Is there any way to do this?

Hi, this is a limitation to Chrome itself. the active tab is what will be what the process is linked to. Unfortunately nothing I can add support for.


ANSI-730 - Scram 256 sasl mechanism

Description
Can now set sasl_protocol: scram256
scram will represent scram-512
Solves a ksql bug which checked for scram 256
Updates the client_properties and listener_properties filter
Still will only allow one sasl protocol per listener, but can have different scrams on different listeners
Fixes # (issue)
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Updated scram-rhel scenario to test both scram options
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[ ] Any dependent changes have been merged and published in downstream modules
[x] Any variable changes have been validated to be backwards compatible

@stan-confluent unfortunately merging this, and I think in cp-env you may need to put conditionals around cp-ansible versions. These filters may continue to change, but hopefully in the future we have a simpler path for containing two kafka clusters in your inventory and hooking everything up, and you wont even need to use the client_properties filter.


Remove app label in phoenix rules

Towards https://github.com/giantswarm/giantswarm/issues/30932
Checklist

[ ] Update CHANGELOG.md
[ ] Add Unit tests
[ ] Follow Alert structure
[ ] Consider creating a dashboard (guidelines) (if it does not exist already) to help oncallers monitor the status of the issue.
[ ] Request review from oncall area, as well as team (e.g: oncall-kaas-cloud GitHub group).

I checked the metrics in anteater and alba grafana explore.


Resource.get - add option to pass exceptions_dict

Short description:
More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
Bug:

/cherry-pick v4.14
/cherry-pick v4.13

/verified


Multiple Items but only move one item at a time

I saw a few issues filed before that suggests to put multiple items in a single li. My question is, is it possible to increase the viewport to show 3 items instead of 1 and scroll through them 1 item at a time.
e.g.
1 | 2 | 3 -> slide right  -> 2 | 3 | 4
instead of
1 | 2 | 3 -> slide right  -> 4 | 5 | 6
Thanks

any updates guys on this... require the same feature.

It seems like this is already possible, just requires a couple tricks with the CSS.
On the carousel ul that has your rn-carousel attributes, set the css to have:
width: (width of one of your slides);
overflow: visible;
Wrap it inside of a container and set the container's width to whatever you want the total width of the all visible slides of your carousel and overflow: hidden;
The one thing that seems tricky with this is making the control buttons still get pushed to the outer edges of the container, which may just take playing with absolute positioning until you get them where you want them.
Anyone see any issues with this method?

angular-slick have one at a time option that does what you (and I) want.


Adds possibility of scrolling to indexpaths (children included) to the HUBViewController.

Putting this up as work-in-progress for discussion purposes!
This PR adds the possibility of scrolling to nested children.
The first challenge with doing this is that the HubFramework doesn't really know anything about how its children handles their children, which forces us to delegate that to the components themselves.
The second challenge is animations – since the components are reported to the HubFramework when they are visible, we have to wait for the animations to finish each step along the way.
Unit tests coming soon™!
@JohnSundell, @cerihughes, @spotify/objc-dev

Not entirely sure if we should keep the scrollPosition parameter to the HUBComponentWithChildren-call or just let them decide where to put it themselves

@cerihughes, @JohnSundell do you think it makes sense to call the scrollingWillStartInViewController: & scrollingDidEndInViewController: methods on the scroll handler when manually scrolling to a component indexpath?

@Goos It probably does, because we can't make the assumption that the scrolling is both performed and observed in the same piece of code. That is, some logic in an app might cause the view to scroll, while the scroll handler for the current view is implemented in a totally different code base.

 Last update 3766a65...7500165


Basic windows features are not returning in search results.

Microsoft PowerToys version
"0.53.3"
Running as admin

[X] Yes

Area(s) with issue?
PowerToys Run
Steps to reproduce
Search for 'Device Manager'
✔ Expected Behavior
A search result for Device Manager to return
❌ Actual Behavior
The only search result I get it is try searching the web with Edge

Other Software
No response

Duplicate of #12243

Issue is a duplicate
Thank you for your issue! We've linked your report against another issue to centralize the thread.
Thanks for helping us to make PowerToys a better piece of software.

@liamfoneill
You can search it as Windows settings with the following command: $device

Thanks, I was aware of that keyword as a workaround - the issue was created as I think the original intent of PowerToys Run is that you could just search without needing the keyword? (happy to be corrected)

From: Heiko @.>
Sent: Saturday, January 29, 2022 11:28:14 AM
To: microsoft/PowerToys @.>
Cc: Liam F. O'Neill @.>; Mention @.>
Subject: Re: [microsoft/PowerToys] Basic windows features are not returning in search results. (Issue #15828)
@liamfoneillhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fliamfoneill&data=04|01|liam.f.oneill%40microsoft.com|7ab3e918459d48a13b1708d9e31a70a5|72f988bf86f141af91ab2d7cd011db47|1|0|637790524994813303|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=qv5AWi%2BX3QPaKocUawkrPZ4Y5sxScSmLh8KyZ%2FlCsmI%3D&reserved=0
You can search it as Windows settings with the following command: $device
—
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FPowerToys%2Fissues%2F15828%23issuecomment-1024893263&data=04|01|liam.f.oneill%40microsoft.com|7ab3e918459d48a13b1708d9e31a70a5|72f988bf86f141af91ab2d7cd011db47|1|0|637790524994813303|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=pU071F5o0%2BLag0ZyN3vTBapZTjidSvZC4hIwn%2BZT4PI%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAJPQJFMWHI5LYN4CBL5K3TUYPFM5ANCNFSM5NCQJW3Q&data=04|01|liam.f.oneill%40microsoft.com|7ab3e918459d48a13b1708d9e31a70a5|72f988bf86f141af91ab2d7cd011db47|1|0|637790524994813303|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=w2IyuRj9tTZ2JqdyXPTyO5TWxCW3wkT9%2Ft0ihxwGUSs%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>

You can sett this setting under plugin options:

Then you don't need the keyword.


Please reopen #376

In commentary https://github.com/neuvector/neuvector/issues/376#issuecomment-1232248185_ @becitsthere mentioned that the issue can be reopened if it still exist. This is the case, the issue is still valid. However, the project does not allow to re-open closed issues.

#376 reopned


Added visualisations to loan status prediction Model

I have added the following visualisations to Loan Status Prediction Model(Loan Status Prediction/Loan_Status_prediction.ipynb) :
Confusion Matrix: Shows the counts of correct and incorrect predictions for each class (Loan Status). The heatmap makes it easy to visualize the performance.
Classification Report: Provides a more detailed breakdown of precision, recall, F1-score, and support for each class.
ROC Curve: Useful for binary classification to assess the model's ability to distinguish between classes. The area under the curve (AUC) is a metric for how well the model separates positive and negative cases.

Hi @Akshat111111 , Please assign labels GSSOC and level 2 to this PR.
Resolves #216 .


Please update registry image (aws-sdk-go outdated - issue with ceph)

I tried to use the registry:2 image with ceph (private s3) but requests are not working.
It succeed when I used a ubuntu image with the latest version of aws-sdk-go and go.
Is it possible to update the registry image with the latest version of go and aws-sdk-go ?
Thanks !

I have same issue with you. I can't push image to my private registry which backend is S3 like (CEPH Rados Gateway).

Is it possible to update the registry image with the latest version of go and aws-sdk-go ?

The aws-sdk code is vendored in this repository (see https://github.com/docker/distribution/blob/fb7b0ddfc3aad9abf55247095e913e218f4cd5dc/vendor.conf#L4); is there a specific change that's needed for this to work? I see there's an open pull request to update the package; https://github.com/docker/distribution/pull/2563 that could be addressing this?
I just opened a pull request to update Go to 1.10; https://github.com/docker/distribution/pull/2582


Count method with two level join and two column join fails on SqlServer

Bug description
Given a three level schema
Country --< Author --< Post
with two columns joining Author to Post.
If you try to count Posts restricted to a particular country, the generated SQL is invalid for SQL Server
How to reproduce
See https://github.com/michaelaltmann/prisma_bug_2col_join
Create schema
Country --< Author --< Post
with two columns joining Author to Post.
Try to count Posts for a particular country.
Fails on SqlServer
Generated SQL is
SELECT COUNT(*) FROM (SELECT [dbo].[Post].[id] FROM [dbo].[Post] WHERE ([dbo].[Post].[id]) IN (SELECT [t0].[id] FROM [dbo].[Post] AS [t0] INNER JOIN [dbo].[Person] AS [j0] ON (([j0].[id] = [t0].[author_id] AND [j0].[country_id] = [t0].[author_country])) WHERE (([j0].[id],[j0].[country_id]) IN (SELECT [t1].[id], [t1].[country_id] FROM [dbo].[Person] AS [t1] INNER JOIN [dbo].[Country] AS [j1] ON (([j1].[id] = [t1].[country_id])) WHERE ([j1].[id] = @P1 AND [t1].[id] IS NOT NULL AND [t1].[country_id] IS NOT NULL)) AND [t0].[id] IS NOT NULL)) /* traceparent=00-00-00-00 */) AS [sub]
Error
Error occurred during query execution:
ConnectorError(ConnectorError { user_facing_error: None, kind: QueryError(TokenError { code: 4145, state: 1, class: 15, message: "An expression of non-boolean type specified in a context where a condition is expected, near ','.", server: "4f84ff6ad587", procedure: "", line: 1 }) })

Expected behavior
count should return the number of Posts in a given country
Prisma information
// Schema
generator client {
  provider = "prisma-client-js"
}

datasource db {
  provider = "sqlserver"
  url      = env("DB_URL")
}

model Country {
  id      String   @id
  persons Person[]
}

model Person {
  id         String
  country_id String
  posts      Post[]
  country    Country @relation(fields: [country_id], references: [id])

  @@unique([id, country_id])
}

model Post {
  id             Int    @id @default(autoincrement())
  author_id      String
  author_country String
  author         Person @relation(fields: [author_id, author_country], references: [id, country_id])
}

// main.js
const { PrismaClient } = require('@prisma/client')
const prisma = new PrismaClient({ log: ["query", "warn", "error"] })
 await prisma.post.count({ where: { author: { is: { country: { id: "USA" } } } } })

Environment & setup

OS: macOS
Database:  SQL Server running in a Docker VM or in Azure
Node.js: 16.14.2

Prisma Version
4.3.1

Can confirm:
PS C:\Users\Jan\Documents\throwaway\15178> node main.js
Sanity check 1: This works
prisma:query SELECT [dbo].[Post].[id], [dbo].[Post].[author_id], [dbo].[Post].[author_country] FROM [dbo].[Post] WHERE ([dbo].[Post].[author_id] = @P1 AND [dbo].[Post].[author_country] = @P2) /* traceparent=00-00-00-00 */
Sanity check 2: This works
prisma:query SELECT COUNT(*) FROM (SELECT [dbo].[Post].[id] FROM [dbo].[Post] WHERE ([dbo].[Post].[author_id] = @P1 AND [dbo].[Post].[author_country] = @P2) /* traceparent=00-00-00-00 */) AS [sub] /* traceparent=00-00-00-00 */
Sanity check 3: This works
prisma:query SELECT COUNT(*) FROM (SELECT [dbo].[Post].[id] FROM [dbo].[Post] WHERE ([dbo].[Post].[id]) IN (SELECT [t0].[id] FROM [dbo].[Post] AS [t0] INNER JOIN [dbo].[Person] AS [j0] ON (([j0].[id] = [t0].[author_id] AND [j0].[country_id] = [t0].[author_country])) WHERE ([j0].[id] = @P1 AND [j0].[country_id] = @P2 AND [t0].[id] IS NOT NULL)) /* traceparent=00-00-00-00 */) AS [sub] /* traceparent=00-00-00-00 */
Sanity check 4: This works
prisma:query WITH [cte_0] AS (SELECT [t1].[id], [t1].[country_id] FROM [dbo].[Person] AS [t1] INNER JOIN [dbo].[Country] AS [j1] ON (([j1].[id] = [t1].[country_id])) WHERE ([j1].[id] = @P1 AND [t1].[id] IS NOT NULL AND [t1].[country_id] IS NOT NULL)) SELECT [dbo].[Post].[id], [dbo].[Post].[author_id], [dbo].[Post].[author_country] FROM [dbo].[Post] WHERE ([dbo].[Post].[id]) IN (SELECT [t0].[id] FROM [dbo].[Post] AS [t0] INNER JOIN [dbo].[Person] AS [j0] ON (([j0].[id] = [t0].[author_id] AND [j0].[country_id] = [t0].[author_country])) WHERE ([j0].[id] IN (SELECT [id] FROM [cte_0] WHERE [country_id] = [j0].[country_id]) AND [t0].[id] IS NOT NULL)) /* traceparent=00-00-00-00 */
Bug: this fails with SqlServer, but not with SQLite
prisma:error An expression of non-boolean type specified in a context where a condition is expected, near ','.
prisma:query SELECT COUNT(*) FROM (SELECT [dbo].[Post].[id] FROM [dbo].[Post] WHERE ([dbo].[Post].[id]) IN (SELECT [t0].[id] FROM [dbo].[Post] AS [t0] INNER JOIN [dbo].[Person] AS [j0] ON (([j0].[id] = [t0].[author_id] AND [j0].[country_id] = [t0].[author_country])) WHERE (([j0].[id],[j0].[country_id]) IN (SELECT [t1].[id], [t1].[country_id] FROM [dbo].[Person] AS [t1] INNER JOIN [dbo].[Country] AS [j1] ON (([j1].[id] = [t1].[country_id])) WHERE ([j1].[id] = @P1 AND [t1].[id] IS NOT NULL AND [t1].[country_id] IS NOT NULL)) AND [t0].[id] IS NOT NULL)) /* traceparent=00-00-00-00 */) AS [sub] /* traceparent=00-00-00-00 */
C:\Users\Jan\Documents\throwaway\15178\node_modules\@prisma\client\runtime\index.js:29913
      throw new PrismaClientUnknownRequestError(message, this.client._clientVersion);
            ^

PrismaClientUnknownRequestError:
Invalid `prisma.post.count()` invocation in
C:\Users\Jan\Documents\throwaway\15178\main.js:20:21

  17 await prisma.post.findMany({ where: { author: { is: { country: { id: "USA" } } } } })
  18
  19 console.log('Bug: this fails with SqlServer, but not with SQLite')
→ 20 await prisma.post.count(
Error occurred during query execution:
ConnectorError(ConnectorError { user_facing_error: None, kind: QueryError(TokenError { code: 4145, state: 1, class: 15, message: "An expression of non-boolean type specified in a context where a condition is expected, near ','.", server: "691e20505c5a", procedure: "", line: 1 }) })
    at RequestHandler.handleRequestError (C:\Users\Jan\Documents\throwaway\15178\node_modules\@prisma\client\runtime\index.js:29913:13)
    at RequestHandler.request (C:\Users\Jan\Documents\throwaway\15178\node_modules\@prisma\client\runtime\index.js:29892:12)
    at async PrismaClient._request (C:\Users\Jan\Documents\throwaway\15178\node_modules\@prisma\client\runtime\index.js:30864:16)
    at async main (C:\Users\Jan\Documents\throwaway\15178\main.js:20:3)
    at async C:\Users\Jan\Documents\throwaway\15178\main.js:26:3 {
  clientVersion: '4.3.1'
}

Duplicate: https://github.com/prisma/prisma/issues/14037


[BUG]:From server.py:  ValueError: The following model_kwargs are not used by the model: ['token_type_ids']

🐛 Describe the bug
I run my server with this:
python3 ./ColossalAI/applications/Chat/inference/server.py /home/ubuntu/modelpath/llama-7b/llama-7b/ --quant 8bit --http_host <IP_ADDRESS> --http_port 8080
then I call the api with this:
import requests
import request
data = {"history": [{"instruction":"where is the capital of USA", "response":""}], "max_new_tokens": 150, "top_k": 30, "top_p": 0.5, "temperature": 0.6}
response = requests.post("http://localhost:8080/generate/stream", json=data)
print(response.text)
As result I got this:
Traceback (most recent call last):
File "/opt/conda/envs/deploy/lib/python3.9/site-packages/uvicorn/protocols/http/h11_impl.py", line 429, in run_asgi
result = await app(  # type: ignore[func-returns-value]
File "/opt/conda/envs/deploy/lib/python3.9/site-packages/uvicorn/middleware/proxy_headers.py", line 78, in call
return await self.app(scope, receive, send)
File "/opt/conda/envs/deploy/lib/python3.9/site-packages/fastapi/applications.py", line 276, in call
await super().call(scope, receive, send)
File "/opt/conda/envs/deploy/lib/python3.9/site-packages/starlette/applications.py", line 122, in call
await self.middleware_stack(scope, receive, send)
File "/opt/conda/envs/deploy/lib/python3.9/site-packages/starlette/middleware/errors.py", line 184, in call
raise exc
File "/opt/conda/envs/deploy/lib/python3.9/site-packages/starlette/middleware/errors.py", line 162, in call
await self.app(scope, receive, _send)
File "/opt/conda/envs/deploy/lib/python3.9/site-packages/starlette/middleware/cors.py", line 84, in call
await self.app(scope, receive, send)
File "/opt/conda/envs/deploy/lib/python3.9/site-packages/starlette/middleware/exceptions.py", line 79, in call
raise exc
File "/opt/conda/envs/deploy/lib/python3.9/site-packages/starlette/middleware/exceptions.py", line 68, in call
await self.app(scope, receive, sender)
File "/opt/conda/envs/deploy/lib/python3.9/site-packages/fastapi/middleware/asyncexitstack.py", line 21, in call
raise e
File "/opt/conda/envs/deploy/lib/python3.9/site-packages/fastapi/middleware/asyncexitstack.py", line 18, in call
await self.app(scope, receive, send)
File "/opt/conda/envs/deploy/lib/python3.9/site-packages/starlette/routing.py", line 718, in call
await route.handle(scope, receive, send)
File "/opt/conda/envs/deploy/lib/python3.9/site-packages/starlette/routing.py", line 276, in handle
await self.app(scope, receive, send)
File "/opt/conda/envs/deploy/lib/python3.9/site-packages/starlette/routing.py", line 66, in app
response = await func(request)
File "/opt/conda/envs/deploy/lib/python3.9/site-packages/fastapi/routing.py", line 237, in app
raw_response = await run_endpoint_function(
File "/opt/conda/envs/deploy/lib/python3.9/site-packages/fastapi/routing.py", line 165, in run_endpoint_function
return await run_in_threadpool(dependant.call, **values)
File "/opt/conda/envs/deploy/lib/python3.9/site-packages/starlette/concurrency.py", line 41, in run_in_threadpool
return await anyio.to_thread.run_sync(func, *args)
File "/opt/conda/envs/deploy/lib/python3.9/site-packages/anyio/to_thread.py", line 31, in run_sync
return await get_asynclib().run_sync_in_worker_thread(
File "/opt/conda/envs/deploy/lib/python3.9/site-packages/anyio/_backends/_asyncio.py", line 937, in run_sync_in_worker_thread
return await future
File "/opt/conda/envs/deploy/lib/python3.9/site-packages/anyio/_backends/_asyncio.py", line 867, in run
result = context.run(func, *args)
File "/opt/conda/envs/deploy/lib/python3.9/site-packages/slowapi/extension.py", line 762, in sync_wrapper
response = func(*args, **kwargs)
File "/home/ubuntu/./ColossalAI/applications/Chat/inference/server.py", line 118, in generate_no_stream
output = model.generate(**inputs, **data.dict(exclude={'history'}))
File "/opt/conda/envs/deploy/lib/python3.9/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
return func(*args, **kwargs)
File "/opt/conda/envs/deploy/lib/python3.9/site-packages/transformers/generation/utils.py", line 1231, in generate
self._validate_model_kwargs(model_kwargs.copy())
File "/opt/conda/envs/deploy/lib/python3.9/site-packages/transformers/generation/utils.py", line 1109, in _validate_model_kwargs
raise ValueError(
ValueError: The following model_kwargs are not used by the model: ['token_type_ids'] (note: typos in the generate arguments will also show up in this list)
Does anybody know how to resolve this?

Can you try downgrading transformers to 4.21.0?

I tried, another bug happend:
Traceback (most recent call last):
File "/home/ubuntu/./ColossalAI/applications/Chat/inference/server.py", line 10, in
from llama_gptq import load_quant
File "/home/ubuntu/ColossalAI/applications/Chat/inference/llama_gptq/init.py", line 1, in
from .loader import load_quant
File "/home/ubuntu/ColossalAI/applications/Chat/inference/llama_gptq/loader.py", line 4, in
from transformers import LlamaConfig, LlamaForCausalLM
ImportError: cannot import name 'LlamaConfig' from 'transformers' (/opt/conda/envs/pytorch/lib/python3.9/site-packages/transformers/init.py)

same problem

Can you try downgrading transformers to 4.21.0?

I tried, another bug happend: Traceback (most recent call last): File "/home/ubuntu/./ColossalAI/applications/Chat/inference/server.py", line 10, in from llama_gptq import load_quant File "/home/ubuntu/ColossalAI/applications/Chat/inference/llama_gptq/init.py", line 1, in from .loader import load_quant File "/home/ubuntu/ColossalAI/applications/Chat/inference/llama_gptq/loader.py", line 4, in from transformers import LlamaConfig, LlamaForCausalLM ImportError: cannot import name 'LlamaConfig' from 'transformers' (/opt/conda/envs/pytorch/lib/python3.9/site-packages/transformers/init.py)

see https://github.com/underlines/awesome-marketing-datascience/issues/2
try pip uninstall transformers and then pip installing the one with pip install git+https://github.com/zphang/transformers.git@llama_push

Has the problem been fixed?

try pip uninstall transformers and then pip installing the one with pip install git+https://github.com/zphang/transformers.git@llama_push

This method fixed this issue


[gRPC] Service invocation failed when service project has a org name

Description:
When gRPC service project has a org name defined in the toml file, service methods are registered under method id formatted like,

<org_name>/<package_name>.<service_name>/<method_name>

But client is calling to the same method as,

<package_name>.<service_name>/<method_name>

Hence, service invocation is failed, giving following error message,

Error from Connector: Status{ code UNIMPLEMENTED, description HTTP status code 404
invalid content-type: text/plain
MESSAGE DATA: method not found: service.HelloWorld/hello, cause null}

Steps to reproduce:

Create Ballerina project.

Create package inside the project and write gRPC service.

Build the project and run the service.

Generate client stub using the service proto file.

Invoke remote service method by calling service stub method.

Affected Versions:
0.980.0 RC
OS, DB, other environment details and versions:
Not dependent on environment.
Related Issues (optional):
No

Closing this issue, since fix is already merged to master branch


Adding Rbenv support for RVM branch

Adding Rbenv support for RVM branch, though now without rbenv-gemset support.

Do you think the RVM section to be renamed Ruby? That would make people to update their .zshrc files to do the overrides.
If I can rename that section, do I need to include any special mark in the Readme or a changelog?

Guess it makes more sense to rename it to Ruby.
And yes again, rename the README file with the new variable names for configuration.

Let me know if you need anything else on this.

That is amazing work.
Cheers @vadviktor


Replace graph legend handling

Description
Changes proposed in this pull request:

...
...
...

Related issue(s)

After spending some time on that topic, it is not worth the effort to replace the current solution with the useCssVariable hook at a push. It would require changing a lot of logic which is not valuable if current mechanisms work well.


NTR: Regulation of synapse disassembly

Hi,
I am a CACAO student and I am annotating PMID: 27779093 for mouse MEFC2. I need several child terms for the existing term GO: 0098883 Synapse disassembly.
First, I need the term "Regulation of Synapse disassembly". The proposed definition is:  Any process that modulates the frequency, rate or extent of synapse disassembly , which is opposite to the definition of the existing term GO:0051963 regulation of synapse assembly.
Under Regulation of synapse disassembly, there should be child terms positive regulation of synapse disassembly as well as negative regulation of synapse disassembly.
Moreover, under positive regulation of synapse disassembly there should be both positive regulation of excitatory synapse disassembly  and positive regulation of inhibitory synapse dissasembly.
Similarly, under negative regulation of synapse disassembly, there should be child terms negative regulation of excitatory synapse disassembly and negative regulation of inhibitory synapse dissasembly.
A total of 7 terms are being requested.
Thank you

The first three terms [positive/negative]regulation of synapse disassembly can be created easily through TermGenie.  I'll do that.  For the other four, we first need to create the terms for 'excitatory synapse disassembly' and 'inhibitory synapse disassembly' and then can create the regulation terms for them.
Can the same PMID be used for ALL of the suggested new terms? Not just the regulation ones?  If yes, I will go ahead and create all of them.

We're not overly confident on what exactly should be annotated to this paper.  Most of these terms are because there are holes in the ontology.  We usually use GitHub instead of using TermGenie ourselves to ensure the terms we're requesting are reasonable.
The short answer is probably not.
Thanks

@suzialeksander @paolostefano28 :  Which ones are the terms that you think you need for annotation?  Please list.  Those are the ones that I'll add.
If you have references to support the creation of the terms 'inhibitory synapse disassembly' and 'excitatory synapse disassembly', those can be added as well.  Thanks.

*We definitely need:
Neg. reg. of excitatory synapse disassembly
*We want something to reflect:
Neg. reg. of inhibitory synapse formation and/or stability (I think this falls under "organization")
possibly Negative GO:0050807 regulation of synapse organization (if the inhibitory/excitatory is too much detail for GO).
PMID:27779093 states "These results suggest that endogenous MEF2C functions predominantly as a transcriptional repressor to inhibit target genes that promote excitatory synapse elimination and inhibitory synapse formation and/or stability."
We'll ask the neurobiology department for a review for the other terms.

@suzialeksander : need a reference for 'excitatory synapse disassembly' - can I use PMID:27779093? I can use the standard template definition to create it.  Thanks.

Status for commit #90804: Success
ID: GO:1905805 Label: excitatory synapse disassembly
ID: GO:1905806 Label: regulation of synapse disassembly
ID: GO:1905807 Label: negative regulation of synapse disassembly
ID: GO:1905808 Label: positive regulation of synapse disassembly
ID: GO:1905809 Label: negative regulation of synapse organization

Status for commit #90901: Success
ID: GO:1905810 Label: regulation of excitatory synapse disassembly
ID: GO:1905811 Label: negative regulation of excitatory synapse disassembly

@suzialeksander: I've added terms as you requested. If you need any more, please open a new issue.
Thanks.


add whitelist library

@etanshaul @joaoandremartins fix #166

I forwarded you by email the link to the internal whitelist that is used. It looks a little different than this. I wonder if we want to sync it up?

This is based on that. The plan overall is to deprecate the internal one
though.
On Thu, Jul 14, 2016 at 1:23 PM, Etan Shaul<EMAIL_ADDRESS>wrote:

I forwarded you by email the link to the internal whitelist that is used.
It looks a little different than this. I wonder if we want to sync it up?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/app-tools-lib-for-java/pull/167#issuecomment-232733188,
or mute the thread
https://github.com/notifications/unsubscribe/AA9X6CaklmZy1NOWCBUtNSxngjoDdpKdks5qVnCdgaJpZM4JMqGo
.

--
Elliotte Rusty Harold
<EMAIL_ADDRESS>

I didn't check if the list matched the one in our docs.  Other than that, lgtm.

lgtm to me too. but maybe @loosebazooka or @meltsufin will want to check to make sure it fits in with the design

just out of curiosity, isn't this in the appengine sdk somewhere?

Its here https://mvnrepository.com/artifact/com.google.appengine/appengine-tools-sdk/1.9.38
But is this something we'd want to use?

I see apphosting.runtime.security.WhiteList in appengine-tools-api.jar, which we can get from the cloudsdk object. It does make the whitelist check a little more difficult though.

I don't see it in appengine-tools-api.jar,
$ jar tvf appengine-tools-api.jar|grep whitelist
elharo-macbookair2:Downloads elharo$

I imagine there was an offline conversation here. Why did appu's tools
include the whitelist and Elliotte's not?
On Fri, Jul 15, 2016 at 3:17 PM, Elliotte Rusty Harold <
<EMAIL_ADDRESS>wrote:

Merged #167
https://github.com/GoogleCloudPlatform/app-tools-lib-for-java/pull/167.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/app-tools-lib-for-java/pull/167#event-724788372,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHf5HcjGOJxOmu36rT8HUMzGJsJJ72p2ks5qV9yxgaJpZM4JMqGo
.


API tokens in source file

What are the API tokens in snapchat.agent.ts?
If they're at all legitimate then they really shouldn't be in source files in plain text. My recommendation is to remove them and have users supply their own. Additionally, they (if they are the tokens I think they are) provide carte blanch access to whatever account they are associated with, and that usually leads to bad people doing bad things

@pvrs12 They're taken from
https://github.com/cuonic/SnapchatDevWiki/wiki/Global-variables

I would normally agree that it doesn't make sense to have API tokens in plain text in source code, but there are two reasons why I think it makes some sense here.

The project is designed so the average WM10 user could side-load the app onto the phone, a user having to generate an API token and drop it in somewhere would be a huge barrier here. Not to mention there is no official way to generate API tokens for Snapcat.

The API tokens have already been made public, as was linked to.

The big disadvantage though that I see is that the API tokens are currently hard-coded into the source. Meaning that if the API was to ever be updated or those tokens were to ever expire it would require an update to be made to the source here. Although that is a very minor change, it does mean that user need to download the latest version and update the side-loaded app on their device.

Ahh, did not know they were static things. Thanks for clarifying that


Restart Loop

Description
Running this for the first time and it does not seem to start properly. Just goes into a restart loop with this only error outputted for logs
{"name":"bull-prom-metrics","hostname":"answers-bull-exporter-76776dc6cb-6njqp","pid":8,"level":50,"msg":"No clean exit after 5 seconds, force exit","time":"2019-11-13T20:23:48.853Z","v":0}

Minimal, Working Test code to reproduce the issue.
apiVersion: apps/v1
kind: Deployment
metadata:
  name: answers-bull-exporter
  labels:
    app: answers-bull-exporter
spec:
  selector:
    matchLabels:
      app: answers-bull-exporter
  replicas: 1
  template:
    metadata:
      labels:
        app: answers-bull-exporter
    spec:
      containers:
        - name: answers-bull-exporter
          image: uphabit/bull_exporter:latest
          imagePullPolicy: Always
          securityContext:
            privileged: false
            allowPrivilegeEscalation: false
            readOnlyRootFilesystem: true
            capabilities:
              drop:
                - all
          resources:
            requests:
              cpu: 100m
              memory: 128M
            limits:
              cpu: 200m
              memory: 512M
          env:
            - name: EXPORTER_REDIS_URL
              value: redis://my.redisserver.com:6379/0
            - name: EXPORTER_PREFIX
              value: assist-task-manager
            - name: EXPORTER_STAT_PREFIX
              value: assist-task-manager-stats
          livenessProbe:
            initialDelaySeconds: 30
            periodSeconds: 15
            httpGet:
              path: /healthz
              port: 9538
---
apiVersion: v1
kind: Service
metadata:
  name: answers-bull-exporter
  labels:
    app: answers-bull-exporter
spec:
  type: ClusterIP
  ports:
    - name: http
      port: 9538
      targetPort: 9538
  selector:
    app: answers-bull-exporter

Bull version
Additional information
Any Idea what I maybe doing wrong here?

@krisrmgua any luck debugging this?

no luck

For me this was because the redis url was incorrect.
We had to add the redis password to the url like so: redis://:password@redis:6379/0.


Add two issues to known limitations

Added known limitations with some examples. Please let me know if I need to make anything more clear.

Nice 👍


Annotation/info metric type

General issue to track things related to the annotation metric pattern, which looks something like
python_info{implementation="CPython",major="3",minor="5",patchlevel="2",version="3.5.2"} 1.0

in the text format.
I would like to propose we start calling these "info" metrics instead, as "annotation" is too overloaded a word and we keep on getting confused.

Agreed, that's what I have heard them referred to as, in the past.
Slightly related to https://github.com/RichiH/OpenMetrics/issues/4#issuecomment-316951571


refactor: Add integration tests

Codecov Report

Merging #4 (e1fd3e0) into develop (f16cd87) will decrease coverage by 32.50%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##           develop       #4       +/-   ##
============================================
- Coverage   100.00%   67.50%   -32.50%
============================================
  Files            7        1        -6
  Lines          267       40      -227
  Branches        31        3       -28
============================================
- Hits           267       27      -240
- Misses           0       12       +12
- Partials         0        1        +1

Impacted Files
Coverage Δ

src/lib/Jelban.ts
67.50% <50.00%> (-32.50%)
:arrow_down:

src/lib/providers/gmail.ts

src/lib/email-addresses-filter/list.ts

...b/email-addresses-filter/email-addresses-filter.ts

src/lib/providers/router.ts

src/lib/providers/index.ts

src/lib/providers/outlook.ts

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


simd support for fp16/bf16

issue: https://github.com/zilliztech/knowhere/issues/287
some test result with vdbench:(768d-1m,hnsw)
fp32:

fp16:

bf16:

fp16 before opt:

any test to see the performance improvement before and after this code change ?

/lgtm

/lgtm

Please also change _mm256_load_si256 into _mm256_loadu_si256

/lgtm


[gardening] prefer '-> Void' over '-> ()'

This is the same as https://github.com/apple/swift/pull/6521.

@swift-ci test and merge


Sync does not update the cached values

needs investigation

preload already updates the cache before the rdacs are changed
is this a mismatch?
what does the user want to see, the preloaded value, or the actual value.

Alternative  syncLoad(rdac0..rdacn) which preloads all and after the last preload it syncs them all simultaneously.
drawback if that doing a subset e.g. only 1 and 3, requires reading the last value for the others (0 and 2).

minus 1 as rdac setting would let the function solve that.

Current code
Current code is inconsistent.

preload(const uint8_t rdac, const uint8_t value) sets cache
preloadAll(const uint8_t value) does not set cache
sync(const uint8_t mask) sets cache

Solution:

Removing cache set from preload() keeps cache consistent with the actual value

syncLoad()
trivial implementation
syncLoad(val0, val1, val2, val3)
{
  preload(0, val0);
  preload(1, val1);
  preload(2, val2);
  preload(3, val3);
  sync();
}

// or slightly optimized
syncLoad(val0, val1, val2, val3)
{
  preloadAll(val0);
  if (val0 != val1) preload(1, val1);
  if (val0 != val2) preload(2, val2);
  if (val0 != val3) preload(3, val3);
  sync();
}

Sync()
sync(mask) could have a default mask...

sync(mask) could have a default mask 0x0F (all)

No it should not as not necessary all values are preloaded giving an undefined behavior.
Keeping extra administration (mask of preloaded values) could be done. Think that would make the behavior not less complex.
syncLoad(val0, val1, val2, val3)
better name preloadSync(...) ?


starter task 2

Description

Reason for Change

Fixes CFD-
Completes CFD-
Contributes to CFD-
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Documentation update
[ ] Other

Testing

[ ] Test A
[ ] Test B

oh no u have conflicts again


Cannot read property 's' of undefined, not connecting

I tried using both MultiOgar-Edited and OgarII versions, but there would appear the same error when I try to connect to the private server. https://prnt.sc/q3x7w9
"Cannot read property 's' of undefined." what does that even mean I never saw someone else get the same error (it also happens when I casually enter agar.io to play with friends, the Inspect tab is flooded with these error things) I have properly installed node.js and the only problem here is this.
What are these: https://prnt.sc/q3xaxf and is there any fix? (also this link is when i normally open agario without servers)

Also this second link is

Support for the official agar.io client hasn't been revised since mid last year, please use Cigar or a client alike.


Media Player status limited

I have compared this component with my implementation:
https://gist.github.com/runningman84/5464ec4dc39b10efd10828ca7cef25d0
My custom component reports this device state:
media_player.yamaha_wx030_box

state:	playing

volume_level: 0.3
is_volume_muted: false
media_content_type: music
media_title: Need It
media_artist: Jay Hardway
media_album_name: Need It
source: spotify
source_list: napster,spotify,juke,tidal,deezer,airplay,mc_link,server,net_radio,bluetooth
model_name: WX-030
device_id: 00A0DED2EEXX
device_ip: <IP_ADDRESS>
system_id: 0DB97153
system_version: 2.37
api_version: 1.19
netmodule_version: 1624
friendly_name: Yamaha WX-030 Box
entity_picture: /api/media_player_proxy/media_player.yamaha_wx030_box?token=f5347fad9df7ed6a3b6b09d0ca245f9d164918e8107c622cc5cc483fa4a2d400&cache=754c8
supported_features: 18828

Your component doesn't show any picture or other infos:
media_player.yamaha_wx030_box

state:	on

volume_level: 0.3
is_volume_muted: false
media_content_type: music
source: spotify
source_list: spotify,napster,juke,tidal,deezer,airplay,mc_link,server,net_radio,bluetooth
friendly_name: Yamaha WX-030 Box
supported_features: 22973

Maybe you can extend your module accordingly...

@runningman84 congrats for filing the first issue on this project. 🥇
I will not comment on your feature-bashing, but I will be happy to look into this issue, if you provide me with raw-data (not the output of your solution). Please provide the output of querying the following URLs:
http://<deviceIp>/YamahaExtendedControl/v1/system/getDeviceInfo
http://<deviceIp>/YamahaExtendedControl/v1/system/getFeatures
http://<deviceIp>/YamahaExtendedControl/v1/netusb/getPlayInfo
http://<deviceIp>/YamahaExtendedControl/v1/main/getStatus

here you go:
curl http://<IP_ADDRESS>/YamahaExtendedControl/v1/system/getDeviceInfo
{"response_code":0,"model_name":"WX-030","destination":"BG","device_id":"00A0DED2EXX","system_id":"0DB97153","system_version":2.37,"api_version":1.19,"netmodule_version":"1624    ","netmodule_checksum":"F86C1689","operation_mode":"normal","update_error_code":"00000000"}

curl http://<IP_ADDRESS>/YamahaExtendedControl/v1/system/getFeatures
{"response_code":0,"system":{"func_list":["wired_lan","wireless_lan","wireless_direct","network_standby","auto_power_standby","bluetooth_tx_setting","airplay","stereo_pair","network_reboot"],"zone_num":1,"input_list":[{"id":"napster","distribution_enable":true,"rename_enable":false,"account_enable":true,"play_info_type":"netusb"},{"id":"spotify","distribution_enable":true,"rename_enable":false,"account_enable":false,"play_info_type":"netusb"},{"id":"juke","distribution_enable":true,"rename_enable":false,"account_enable":true,"play_info_type":"netusb"},{"id":"tidal","distribution_enable":true,"rename_enable":false,"account_enable":true,"play_info_type":"netusb"},{"id":"deezer","distribution_enable":true,"rename_enable":false,"account_enable":true,"play_info_type":"netusb"},{"id":"airplay","distribution_enable":false,"rename_enable":false,"account_enable":false,"play_info_type":"netusb"},{"id":"mc_link","distribution_enable":false,"rename_enable":true,"account_enable":false,"play_info_type":"netusb"},{"id":"server","distribution_enable":true,"rename_enable":true,"account_enable":false,"play_info_type":"netusb"},{"id":"net_radio","distribution_enable":true,"rename_enable":true,"account_enable":false,"play_info_type":"netusb"},{"id":"bluetooth","distribution_enable":true,"rename_enable":false,"account_enable":false,"play_info_type":"netusb"}],"ymap_list":["vtuner"]},"zone":[{"id":"main","func_list":["power","sleep","volume","mute","equalizer","signal_info","prepare_input_change","link_control"],"input_list":["napster","spotify","juke","tidal","deezer","airplay","mc_link","server","net_radio","bluetooth"],"equalizer_mode_list":["manual"],"link_control_list":["speed","standard","stability"],"range_step":[{"id":"volume","min":0,"max":60,"step":1},{"id":"equalizer","min":-10,"max":10,"step":1}]}],"netusb":{"func_list":["recent_info","play_queue","mc_playlist"],"preset":{"num":40},"recent_info":{"num":40},"play_queue":{"size":200},"mc_playlist":{"size":200,"num":5},"net_radio_type":"vtuner","vtuner_fver":"A","pandora":{"sort_option_list":["date","alphabet"]}},"distribution":{"server_zone_list":["main"]},"ccs":{"supported":true}}

curl http://<IP_ADDRESS>/YamahaExtendedControl/v1/netusb/getPlayInfo
{"response_code":0,"input":"spotify","play_queue_type":"system","playback":"play","repeat":"off","shuffle":"off","play_time":-60000,"total_time":0,"artist":"George Harrison","album":"Cloud Nine","track":"Got My Mind Set On You - Extended Version","albumart_url":"/YamahaRemoteControl/AlbumART/AlbumART7781.jpg","albumart_id":7781,"usb_devicetype":"unknown","auto_stopped":false,"attribute":16777631,"repeat_available":[],"shuffle_available":[]}

curl http://<IP_ADDRESS>/YamahaExtendedControl/v1/main/getStatus
{"response_code":0,"power":"on","sleep":0,"volume":15,"mute":false,"max_volume":60,"input":"spotify","distribution_enable":true,"equalizer":{"mode":"manual","low":0,"mid":0,"high":0},"link_control":"standard","disable_flags":0

Thanks for your feedback! Would you mind to also get me this info:
http:///YamahaExtendedControl/v1/system/getLocationInfo

Looking at the info you provided, I am wondering if you are blocking incoming UDP-traffic on the port you configured. 🤔

@runningman84 does this problem still persist?

There is no firewall between the home assistant and musiccast device. They are all in the same lan. I will try with the latest version later this day.

ok in 0.56.2 the infos are populated. The on and off button also works.
One thing which could be improved is that if the musiccast device is playing net radio the pause button should actually call the stop function because pause does not seem to work with net radio.

Cool, thanks for reporting back! So we can finally close our first issue. 🎉
Please open a new issue regarding your observation and I will take a look at it.


Log delete message events times

When we send or edit message we add events_times timestamp, but not on delete

Store here 6f1cfae


Record livechat

go to https://www.livechat.com/
click the chat box in the bottom right

This ticket has been moved to RUN-154


feat: Integrate Brave Web Search API in search toolkit (#1005)

Description
Brave Web Search API is a REST API to query Brave Search and get back search results from the web.
This PR enhance the search toolkit with the Brave Web Search API.
Motivation and Context
Closes issue #1005.
Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds core functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation (update in the documentation)
[ ] Example (update in the folder of example)

Implemented Tasks

[x] Add one new model type in Gemini model series.
[x] Edit the corresponding example, and test file.

Checklist
Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

[x] I have read the CONTRIBUTION guide. (required)
[x] My change requires a change to the documentation.
[x] I have updated the tests accordingly. (required for a bug fix or a new feature)
[x] I have updated the documentation accordingly.

Hi @MuggleJinx! Thank you for your contribution! Could you please add a comment at the end of the example file to indicate the expected output for this example? You can refer to the other examples for guidance. Thanks!


Patch the correct observed state after a rm.ReadOne call

Issue https://github.com/aws-controllers-k8s/community/issues/807
For some controllers we noticed an incorrect reconciliation behaviour
when a custom hook code was returning a RequeueNeededAfter error.
More precisely resourceManager.ReadOne was not returning the correct
observed state when sdkFind returns with an error. Which was causing
the reconciler to patch to wrong state (desird instead observed).
This patch fixes this issue by passing the correct observed state to onError.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

i'm currently testing this fix with ecr and dynamodb controllers
/hold

@A-Hilaly you may want to update the PR/commit message to mention that RequeueNeededAfter is actually an error and is the reason why we're noticing some of this behaviour in some of the custom hook code.

/approve

@jaypipes Updated,  PTAL again.

/unhold

/lgtm


Expression in case statement

Can I use an expression in case statement?
		switch(true) {
			case 1 > 0:
				echo 1;
		}

This code throw a syntax error on compiling.

It's not possible.
I encounter this case with php-to-zephir translator and symfony/event-dispatcher. The solution was to translate switch to if.

I already rewrite the code to use if instead of switch, but it looks ugly :(

It's not implemented
Why do you need it?
case 1 > 0

Can you show a good example?

For example
switch (true) {
	case var1 > 10 && var1 < 20:
	case var2 == var1:
	case var2 > 100500:
		return sprintf("var1 = %d, var2 = %d", var1, var2);

	case var2 < 0:
	case var1 <= 10 || var1 >= 20:
		throw new \Exception();
}

Instead of this I should use if:
if (var1 > 10 && var1 < 20) || (var2 == var1) || (var2 > 100500) {
	return sprintf("var1 = %d, var2 = %d", var1, var2);
} elseif (var2 < 0) || (var1 <= 10 || var1 >= 20) {
	throw new \Exception();
}

It's similar, but looks not so clearly.


updating readme to include release page, better instructions

Adding the release page to the install instructions, as well as updating the README to mirror the format of other plugs (such as kn-plugin-admin).
/assign @csantanapr

/lgtm
/approve


cannot save image

Hi,
Can you help to look into this issue?
i cannot save image using python.
is it a padlocal issue or a configuration of my environment?
thanks.

Root cause:
running wechaty-gateway on arm64 server will cause this error.
Workaround:
run wechaty-gateway on an amd64 server and use version 0.65


File purge apply to deeper items eg lists, to be able to do more precise selectors

https://github.com/packit-service/requre/pull/56 solves it


Tests refactor

What was wrong?
The test loading and JSON parsing code was duplicated for every fork.
How was it fixed?
Moved it into a common function.
Cute Animal Picture

Codecov Report

Merging #458 (dc9b902) into master (5ea89ca) will increase coverage by 0.28%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #458      +/-   ##
==========================================
+ Coverage   79.45%   79.73%   +0.28%
==========================================
  Files         187      182       -5
  Lines        9864     9779      -85
==========================================
- Hits         7837     7797      -40
+ Misses       2027     1982      -45

Flag
Coverage Δ

unittests
79.73% <ø> (+0.28%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/ethereum/frontier/utils/hexadecimal.py
87.50% <0.00%> (-12.50%)
:arrow_down:

src/ethereum/homestead/utils/hexadecimal.py
87.50% <0.00%> (-12.50%)
:arrow_down:

src/ethereum/spurious_dragon/utils/hexadecimal.py
87.50% <0.00%> (-12.50%)
:arrow_down:

...rc/ethereum/tangerine_whistle/utils/hexadecimal.py
87.50% <0.00%> (-12.50%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ea89ca...dc9b902. Read the comment docs.

@SamWilsn Would it then also make sense to move the vm_test_helpers to out of the individual hard-forks and into helpers

Added a PR on top of this for VM test helpers


LocalTarget.exists no-permission fails silently and returns False

The exists check should probably raise an exception if it doesn't have permission to see if the file exist.

I'm closing this issue.

[x] It has been inactive for +4 months.
[ ] It's not about luigi core, so not as many users are affected about this.
[ ] The change seems quite big, it's unlikely to be sporadically picked up.
[ ] The owner haven't responded or disappeared.
[ ] I don't understand what this issue is about.
[ ] There exists a reasonable workaround for this.
[ ] We need to check if this hasn't been fixed by now (for old issues).
[ ] This is kind of by design and not a bug.
[ ] Resolving this would probably add a lot of complexity.

Every open issue adds some clutter, and we try to make the issues fewer and make it easier for new collaborators to find. Currently we try to close any issue that meets the first checkbox + one other.
Feel free to reopen this issue at any point if you have the intent to continue to work this. :)


Fix VSCode

Fixes the built executable not launching when debugging from VSCode because of misconfiguration
Fixes the build error on macOS due to calling the wrong make version

@stefanerwinmayer I'm merging and further editing on my side (some new changes required).

@stefanerwinmayer I'm merging and further editing on my side (some new changes required).

Thanks. Sorry for the late response.


Provide .zip or .tar.gz along with 7zip archives?

I'm looking to write a utility for setting up ruby environments.
Non-free 7zip is a bit of a barrier-to-entry.
Would it be possible to provide something easier to extract such as .tar.gz or .zip?

7zip is actually Free and Open Source; licensed under the LGPL.
If you look through the config directories you can find the download link to the 7za.exe executable that we use.

In that case, I'd like to be able to extract archives without additional dependencies (I'd rather not introduce subprocess dependencies).  zip and tar both have much better support, especially out of the box and in the language I'm targetting (python).

The choice to use 7z was practical as well as functional.
If you would like zip archives a PR would be welcome, but there are multiple ways to unzip 7z files, since it's based on lzma, but all of them do introduce some kind of dependency. (Though some distributions may ship with a lzma library)
You could also just as easily figure out how to run the installer unattended for similar results.

Could you point me in the right direction as to where I would add such a thing?

@asottile You can try looking at https://www.joachim-bauch.de/projects/pylzma/

@Azolo Ping!  Where should I start looking to add .zip support?  I'd like to write a PR but I'm rather unfamiliar with the repository

@asottile Look at https://github.com/oneclick/rubyinstaller/blob/master/recipes/packager/inno.rake

@Azolo, @asottile Inno based installer can silently install into location. Something like this:
rubyinstaller-X.Y.Z.exe /VERYSILENT /SUPPRESSMSGBOXES /NOICONS /SP- /DIR="C:\some_ruby_dir"

I understand I can run arbitrary executables to do this but I'd rather have archives that I can extract without having to do so.  Can you point me in the direction so I can add zip archives to the artifacts you prvide?

@asottile All of the interpreter packages are created from the rake tasks in inno.rake.
However, the solution from @dmajkic is perfect in my opinion. It prevents any extra burden on me as a maintainer and you as an implementer by using already available functionality.
In this case, I feel like you're being dogmatic in your approach. My recommendations are basically this:
If you don't want to shell out to an executable of any kind, then include an lzma dependency.
If you don't want to include any extra dependencies, then silent install using the above method.
If you don't want to shell out or include extra dependencies, then writing a new packaging pipeline would probably be easier than extending RubyInstaller's.

I'm still baffled why there's so much resistance to adding a more widely supported archive format.  Is there an actual reason 7zip was chosen?  I guess more importantly for what I care about is there an actual reason why not also zip?
The reason I'm being so "dogmatic" as you put it:

lzma doesn't have good python2 + python3 support (or even a pip package!) so it is not suitable for the platforms I target
my primary platform I target isn't even windows to begin with so anything that complicates packaging / dependencies is already really unfortunate (not a real reason: fair)
I really just want the ruby interpreter -- there aren't really any other providers which have downloadable prebuilt interpreters which is why I came here at all
If I can avoid dependencies that greatly reduces the barrier to entry for my target users.  The entire reason I'm doing this work at all is I don't want people to have to install $N tools (a C compiler, etc.).  The zip format is extractable on every windows box going back to XP. .tar.gz is supported by any python installation (since python2.6).  Both of those are zero-dependency choices for my targets.  In order to support 7zip archives I'd have to worry about whether or not my consumers have installed 7zip or I'd have to use liblzma which would again require a C compiler.

This has been a really unfortunate and impolite exchange.  I feel like the things I'm asking for aren't unreasonable and yet my questions have been avoided, my requirements dismissed, and this issue closed aggressively without solution and with action items still open.
I'll look into inno.rake, thanks.

I'm sorry it came off that way. I don't mean to be unwelcoming. I'll try to address parts of my concerns and your questions.

is there an actual reason why not also zip?

I understand where you're coming from, but I would rather try to solve the problem in a way that doesn't increase my workload. So when introducing something like a new format I have to consider what that means for the release workload, that's the resistance you're finding.

lzma doesn't have good python2 + python3 support (or even a pip package!) so it is not suitable for the platforms I target

Ruby doesn't either, we shell out to the 7za executable.

..., my requirements dismissed, ...

I guess I don't understand your requirements other than the fact you would like a zip file distribution. Which we don't have. So we tried to come up with alternatives, which involved shelling out to external executables. In the ruby world shelling out to executables isn't just common, in a lot of cases it's encouraged. So, my original suggestion was to just download 7za or bundle it then shell out to it. I can accept that isn't something you would want to do because it's an external dependency. But with @dmajkic's suggestion you don't need that external dependency. That's where my dogmatic comment comes from. The silent installation solves the same problem as a zip distribution from my point-of-view.

I'll look into inno.rake, thanks.

I glanced through the recipes and it didn't look like it wouldn't be super easy to add something like a zip option without some major refactoring. Using something like Bintray you could probably much more easily create a pipeline to use 7z and rezip and upload it.

Is there an actual reason 7zip was chosen?

The reason why lzma/7z is used is because of the devkit.
Here are the stats for mingw64-64-4.7.2:

uncompressed:  ~400 MB
zip archive: ~150 MB
lmza/7z: 48 MB

When files were hosted on a CDN and not BinTray this was significant. As an aside, we shell out to the 7za executable to do all of this.

The entire reason I'm doing this work at all is I don't want people to have to install $N tools (a C compiler, etc.).

This is something that you have to do in Ruby(The DevKit), and the reason why RubyInstaller builds are repackaged in all-in-one packages like RailsInstaller.
All of this being said, I would still consider a PR but I was a lot more open about it before @dmajkic's silent install trick. There would need to be a compelling reason that other solutions didn't work for me to consider adding release overhead.

fwiw unlike ruby, in python it's strongly discouraged to shell out (especially on windows where the subprocess cost is so high) which is the main reason I'm trying to avoid it.
What part of the release becomes more complicated - if possible I can try and reduce that burden if it's some script that needs updating, tests, etc.

fwiw unlike ruby, in python it's strongly discouraged to shell out (especially on windows where the subprocess cost is so high) which is the main reason I'm trying to avoid it.

What's the cost in a one time shell out that saves you time and accomplishes the goal besides the fact you don't want to?  Likewise, the cost of creating a process is still milliseconds, it probably takes longer to establish a tcp connection.

What part of the release becomes more complicated - if possible I can try and reduce that burden if it's some script that needs updating, tests, etc.

Uploading the files, updating the site, writing the release notes, getting the md5 and sha256 digests, and handling the BinTray manual steps. The big one is the website where an extra 2 files would probably increase the workload by about 2-3 minutes. So if there were 3 or 4 releases at once it would be an extra ~15 minutes of my time total.
The release notes may be able to be templated, but some things change. The md5 and sha256 digests are already generated  as files and I use PowerShell to get the contents collect them and copy/paste them where they need to go. But without a major rewrite the website is still manual updates and the Bintray stuff is manual as well.
But, once again, even if you opened a PR you need another compelling reason for me to maintain code for another release format other than the fact you aren't willing shell out to another executable.
I know this reply seems like I'm dismissing you, but we're still talking about it and I'm all but pleading with you to use accepted solutions to solved problems. If there were obstacles to being able to use these solutions or this was a frequently requested item then it would be much easier to convince me,


Simple Loader doesn't work

Hi all,
Following the docs in Class: Loader
var loader = new PIXI.loader();
loader.add('bunny',"data/bunny.png");
loader.once('complete',onAssetsLoaded);
loader.load();
Give to me :
TypeError: Object is not a constructor (evaluating 'new PIXI.loader()')

var loader = PIXI.loader();
loader.add('bunny',"data/bunny.png");
loader.once('complete',onAssetsLoaded);
loader.load();

or
var loader = new PIXI.loaders.Loader();
loader.add('bunny',"data/bunny.png");
loader.once('complete',onAssetsLoaded);
loader.load();

PIXI creates one loader for you (PIXI.loader) already ready for use. To create a new one, you must not forget the namespace "loaders"

@JiDW you have type in the first line of your example. It should be:
var loader = PIXI.loader;

Yes sorry, thanks.

Thank you, ok so the docs is false. Thank you. Please correct the docs (docs/PIXI.loaders.Loader.html)

Docs fixed, and issue solved!


Oversized menu bar icon.

This is a very minor request, but it does seem that the menu bar icon is a bit taller than most of the other icons shown on my Mac. Is it possible to shrink the icon down a bit to fit in with the rest of the apps? I've provided a screenshot that shows this. Thanks!

It will be great if there would be opportunity to hide icon at all as well.

@nograsswillgrow, here's a smaller version of the menu bar icon (76 px vs 88 px):
Just go to /Applications/Fanny.app/Contents/Resources/ and replace the existing fanIcon.png with one you download.

@fcccbf8f8f1, thanks for providing this!


Only EscapeKey not work

jquery-confirm version:
v3.3.4
I'm submitting a ...  (check one with "x")
[X] bug report
[ ] feature request
[ ] support request
Steps to reproduce:
https://craftpip.github.io/jquery-confirm/#escape-key
Other information:
my last version used was 3.3.0 and it was working.

@craftpip help please 😁


Option for empty lines before and after comment

Hi @jamief,
cool extension and formatter! 🚀
Would be possible to config number of empty lines after comment line?
When hit Format document, this input:
Host *
    # Allow the use of local keys remotely
    ForwardAgent yes
    # Automatically add keys to the SSH agent
    AddKeysToAgent yes
    # Send a keepalive packet every 4 minutes to prevent the connection timing out
    ServerAliveInterval 240

# Office Jump Server
Host bastion
    HostName xxxxxxxx.com
    User tomas
    Port 1234

... turns to :
Host *
    # Allow the use of local keys remotely
    ForwardAgent yes
    # Automatically add keys to the SSH agent
    AddKeysToAgent yes
    # Send a keepalive packet every 4 minutes to prevent the connection timing out
    ServerAliveInterval 240

# Office Jump Server
             <------(this empty line added)
Host bastion
    HostName xxxxxxxx.com
    User tomas
    Port 1234

That visual is a bit confusing.
Would be nice if formatter wouldn't force empty line after the section comment.

Hi @tomassebestik,
Thank you for your suggestion and support for the extension!
The issue you raised regarding the empty lines after comments has been addressed and the new version has been published, let me know if you encounter any further issues!
Thanks!

Hi @jamief,
Thanks for super-fast update. It works as expected! ❤


Update HelloBank

So BNPorc and HelloBank modules have been merged.

[x] fix the BNP description in banks-all.json and add websites
[x] migrate HelloBank users to BNP module
[ ] backport this update onto master :( and update the patch version number (this will land in incoming and a new version is going to get released)

See also https://git.symlink.me/?p=weboob/devel.git;a=blob;f=modules/bnporc/module.py;h=b15f87aa8e02dfba9bdbd5ac0e712a9ba3aed887;hb=HEAD#l51

Fixed by https://github.com/bnjbvr/kresus/commit/6862871e3c6a53e5a6d530e3b8e851938efaf8d4


Frames for mounting

Hi. I would like to know if you bought or printed the frames you use for mounting. If bought, where? If printed, could you share the files?
Thank you!

I bought the frames with the displays - ali express


Move CSS class setting logic above the 'return if less than two rows' in sortTable function

Hi,
We are using a streaming rendering library with TableSort. In other words, each row gets added one at a time as the data streams in. We are running to an issue that in the initial sort call, there are less than two rows in the table, so the sortTable() logic ends early, before the CSS classes are applied, on the statement
if (that.table.rows.length < 2) return;
Then, when more rows are added, they are considered an 'update' and the CSS class logic is again not applied.
So, if we add the 'sort-default' class to one of the header columns, we never actually see the correct CSS classes for 'sort-up' or 'sort-down' ever applied. Moving the logic for the CSS classes above that return statement fixes the problem.
Thanks!

@asindhu Sorry about delaying this! Looks good to me. I'll have this under a new release soon.