403 for CLA

When I click on this:
You have signed the CLA already but the status is still pending? Let us [recheck](https://cla-assistant.cds.internal.unity3d.com/check/Unity-Technologies/InputSystem?pullRequest=1603) it.
I'm prompted to do a SSO sign-in, but then I'm redirected to a 403

Unity, not us, hosts the CLA assistant UI. Therefore we can't help you with the 403 issue.
I see in your PR that you have used an e-mail address for your commit that is not linked to your GH account (https://api.github.com/repos/Unity-Technologies/InputSystem/pulls/1603/commits). Once you have added it to your account as described here https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user the status of the CLA check should become green after a trigger. If "recheck" doesn't work as a trigger, you can also push one more commit to the PR.

Ah thank you very much! I just needed to set my local git email and recommit.  Thank you, thank you!


REQ: Break re-factoring down into new additions and then removals.

.22 is really great, but gpt4 still struggles with breaking larger functions down in to smaller pieces as it tries to make very large diffs and fails.  I have had good luck asking it to do one function at a time, and to do all the new adds as one diff, then once the functions are present and complete, go back and remove the duplicate code from the original function.  Not sure how this approach could be incorporated but wanted to mention that GPT4 is struggling with this particular task and this seems to be a way around it.

bump


[5.6] Yet another blade helper @dump

Why don't we also have a @dump helper along with @dd in our blade views? ;)
Example:
// welcome.blade.php
...

<div class="title m-b-md">
    Laravel
</div>

@dump(42, 'foobar', new \App\User)

It simply passes all given arguments to dump function and then prints the output.
No more old school dumping like so {{ dump() }}.

Thanks, but 👎. I don't see the need for this, the original code you posted there looks fine.

Well, currently both 'dd' and 'dump' methods (that are related to output debug data), as I remember, are fine:

by their own
on collection objects (Illuminate/Support/Collection::dump())
on test response objects (while testing) (\Illuminate\Foundation\Testing\TestResponse::dump())

By are they really not okey at viwes? I do feel dissonance about this.

Those methods aren't supported by everyone either. I dislike them and would like them removed. You cannot argue that since there's some weird part of the framework in once place, you can add more weird parts to another area.

I can definitely argue that is someone prefer another way, they are free not to use them at all, due they all are optional. Think of them as kind of weird on not is the all about personal tastes. Also, I can notice that Laravel in fact is tightly integrated with Symfony's var-dumper component for a very long time by now. :)

Going to hold off on this for now. :)

Okay. But pretty sure someone will attempt to pull in a thing like this again sooner or later. :)

@dd should never have been merged either.

You mean https://github.com/laravel/framework/pull/22293, and I agree that it shouldn't have been merged. This only shows to the randomness of the selection process. And the main argument seem to be "Eh, it's fine I guess [...]"

Can't we create a simple library where you have all these "extra" blade helpers. Or even can list all the ones you want... I feel like there is a road in between, one where everyone can add stuff like @form and one where it isn't included by default. Also if built correctly, it should be fairly easy to include composer require laravel-blade-helpers --save. I really don't like all these helpers being merged. And the lack of proper reasoning why one is merged and the other not is disturbing...

I find it effing annoying how {{ dd() }} apparently has to be shortened into @dd(). Now there's even more people using different syntax, and the quality of the helpers added is in decline.  That's 50% less code. @dump() is also 5 characters shorter than {{ dump() }}, but it's only roughly 41% less code, so I guess it doesn't quite make the cut.
Code size is often ignored, but for some people running their production code on old hardware or embedded systems, these seemingly minute changes can be a big help.

@36864 Please don't tell me you are either using {{ dd() }} or {{ dump() }} in production... Those are development only methods and should never be used in production.
I'm also really doubting if removing characters would drastically improve the performance. If you are really interested in performance gains, try experimenting with object references and loop optimisations. Of course Laravel should definitely be runnable on older or "lesser fortunate" hardware, but I don't think we are gaining any performance by adding these blade directives.

@36864 so you want to save 5 chars but add 2 functions to support this?

In retrospect, I should not have attempted sarcasm before having my morning coffee.
I was trying to find a logical reason for adding @dd() but not @dump(), but the only reason I could find was immediately defeated by the fact that these are test functions that should never make it to production, coupled with the fact that it would only be a valid argument if the helper was being used quite a lot.
Sorry.

Don't be sorry, healthy discussions are actually great! And maybe if somebody feels inspired by this he or she can come up with another point.

It's just that stuff like this makes the core overly bloated. There's already too many helpers no one would need if they knew plain PHP, how strange it may be.

In recent versions of Symfony the dump will return what was passed into it.
So doing this in a view {{ dump($var) }} will be a bit problematic. After the dump function has displayed the contents of the passed var, Blade will try to display the return value. And because {{ is used it will output gibberish.
So it might make sense to have a @dump Blade directive that discards the return value of the dump function.

Or just
Or just ignore the gibberish since it's just a debugging tool and you can easily identify what you dumped vs what gets echoed afterwards.

Yeah, or even use the Blade version of <?php => @php @endphp :)

Heh, it directive was pulled in, but in different PR - https://github.com/laravel/framework/pull/23364.


creates levenshtein.py and update README

(Put an X inside the [ ] to denote check mark [X].)

[ ] If creating a new file :

[x] added links to it in the README files ?
[ ] included tests with it ?
[x] added description (overview of algorithm, time and space compleixty, and possible edge case) in docstrings ?

[ ] if done some changes :

[ ] wrote short description in the PR explaining what the changes do ?
[ ] Fixes #[issue number] if related to any issue

[ ] other

Pull Request Test Coverage Report for Build 751

0 of 19 (0.0%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.2%) to 71.327%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

algorithms/strings/levenshtein.py
0
19
0.0%

Files with Coverage Reduction
New Missed Lines
%

algorithms/linkedlist/is_palindrome.py
1
93.33%

Totals

Change from base Build 750:
-0.2%

Covered Lines:
4306

Relevant Lines:
6037

💛  - Coveralls


Add TGA block

Added an TGA example file to the branch ml-evs/example_TGA_dat in e45d191

Ok I also added a parser + test to that branch (will make a PR).
Can decide how to structure it wrt. echem/NMR.


CLOUD-2070 fix access to hsperfdata_jboss

Thanks for submitting your Pull Request!
Please make sure your PR meets the following requirements:

[ ] Pull Request title is properly formatted: [CLOUD-XYA] Subject
[ ] Pull Request contains link to the JIRA issue
[ ] Pull Request contains description of the issue
[ ] Pull Request does not include fixes for issues other than the main ticket
[ ] Attached commits represent units of work and are properly formatted
[ ] You have read and agreed to the Developer Certificate of Origin (DCO) (see CONTRIBUTING.md)
[ ] Every commit contains Signed-off-by: Your Name<EMAIL_ADDRESS>- use git commit -s

rebased and merged

This breaks building this image, so I will probably have to revert it.

In case you are curious:
Step 24 : RUN bash -x /tmp/scripts/openshift-layer/configure_layers.sh
 ---> Running in 76a809c2d161
+ set -e
++ dirname /tmp/scripts/openshift-layer/configure_layers.sh
+ SCRIPT_DIR=/tmp/scripts/openshift-layer
+ ADDED_DIR=/tmp/scripts/openshift-layer/added
+ MODULES=()
+ OPENSHIFT_LAYER_PATH=/modules/system/layers/openshift
+ OVERLAYS_PATH=/modules/system/layers/base/.overlays
+ MODULES_SOURCE_PATHS=("$JBOSS_HOME/modules/system/layers/base")
+ '[' -f /modules/system/layers/base/.overlays/.overlays ']'
++ find /modules/system/layers/openshift -name module.xml
find: '/modules/system/layers/openshift': No such file or directory
+ cp -p /tmp/scripts/openshift-layer/added/modules/layers.conf /modules/
cp: cannot create regular file '/modules/': Not a directory

Link to jira for convenience https://issues.jboss.org/browse/CLOUD-2070


Support Page Visibility API

Story:

When the dashboard is visible to user, then the javascript in the backend should send active REST queries.
When the dashboard is not visible, then the javascript should not send REST query to backend.

This will save resource both for frontend browser, and for backend server. It also saves network bandwidth.
The good news is that we have visibility API: Doc
jquery plugin: JQuery plugin
Here is an example: Code Example

Interesting. I believe for bandwidth sensitive environment, using websocket can save more bandwidth.

it seems like there is good websocket support in akka-streams. From past experience with websockets I would also recommend this transition. Note: both approaches are possible. One concern is page visibility is that once visible we may need to request a large range of values and there may be a short delay before this data is correctly displayed.

Sleep this for low priority.


Direct HTTP clients should not throw exception when no credentials are found

PR: https://github.com/pac4j/pac4j/pull/262


Initial migration to github

The current state of this cookbook is deployable, but would improve with some touchups and cleaning.
osl_element
This resource is fairly simple, it deploys with Nginx as a reverse proxy for connecting with port 80. Nginx will most likely get removed so we can connect directly to HAProxy.
osl_matrix
This resource deployed the actual synapse server. We might want to change the name to osl_synapse, but matrix makes this more easily understandable as the "main" resource to use. This resource should be added after all app services.
It's possible to connect to a Postgres DB or using sqlite locally. Only use sqlite for testing.
osl_heisenbridge
This resource adds in the heisenbridge app service, adding a bot to the Synapse server which allows us to bridge IRC chats into a Matrix room.
TODO services:

Hookshot: Allows for webhooks to post in rooms.
MS Teams bridge (Turns out that the only, officialy available bridge is behind an enterprise paywall)

Along with all of the requested changes, the biggest update is that I have solved the chicken and egg problem, by restarting the docker containers when they fail.
While I was hoping to find a more elegant solution, this is the best one, unless we want to work with Chef on a lower level, messing with the run order at converge time.

Synapse is now in a state where we can start using it for basic communication, along with also having the ability to host meetings w/ screen sharing. My next goal is to add in a Hookshot docker as a resource, with it being another appservice.
The provided osl_heisenbridge gives a good example for how future appservice resource should be set up.

@zwall-bp please remind me the status on this?

Still working on the requested changes, pushing the latest changes before clocking out.

There is an issue right now with the firewall. At the end of the converge, IPTables restarts. This leads to the removal of rules for any running Docker containers.

There is an issue right now with the firewall. At the end of the converge, IPTables restarts. This leads to the removal of rules for any running Docker containers.

Is this related to the issue I'm seeing on the first run where I get the following error?
Docker::Error::TimeoutError
---------------------------
Container osl-hookshot-webhook failed to change to running state after 20 seconds

!bump major ~

Jenkins has merged this PR into master and has automatically performed a major-level version bump to v1.0.0.  Have a nice day!


Blocks are not working

Hi
If you use other cocoaPods , (e.g : TapjoySDK) beside UIAlertView+Blocks the blocks are not returning.

Hi - I've used this pod with other pods many times - Perhaps this is a case of category collision? The TapjoySDK is closed-source, so I can't tell if they are doing anything to UIAlertView, but it seems to be problem when using this pod in conjunction with TapJoy. If I find a workaround i'll post it here.

Yeah, i thought it's not necessarily the problem with your pod but i wanted you to know.
Thanks for the answer.

I have the same problem. Just wonder if there is any workaround available. I have been changing the category name and method name. but no luck

@macinux are you using the same library (TapJoy) or is another incompatibility?

yes. same library (TapJoy). thanks

Unfortunately i had to use TapJoy library so i stopped using this category.
My solution was to set my block as a property and called that from clickedButtonAtIndex.
typedef void (^TapBlock) ();
@property (nonatomic, copy) TapBlock savedTapBlock;

(void)showAlertWithBlock:(TapBlock)block
{
self.savedTapBlock = block;
// Show alertView
}

(void)alertView:(UIAlertView *)alertView clickedButtonAtIndex:(NSInteger)buttonIndex
{
// ...
if (_savedRetryBlock)
{
_savedRetryBlock();
}

// ...
}

Thanks @DavidHorvath for sharing your solution. It would be good to find a permanent workaround

The bug also repeated to me. After adding the lib: Tapjoy

They should call it Tapsad.

This is a category name collision. If you just change to (Blocks2) for example, it will work.


Copy Files Over SSH gives 'handle is not a Buffer' error with dot-files

When using the task 'Copy Files Over SSH' I'm running into an issue when I add a dot-file to the list of files to copy. In my case I'm trying to copy a .htaccess file, but it fails with the error: Unhandled: handle is not a Buffer. This is happening both on the hosted agent and a local (Mac) agent. When I don't include any dot-files, everything is fine.
This is the log:
2016-12-04T13:58:01.4328270Z ==============================================================================
2016-12-04T13:58:01.4345720Z Task         : Copy Files Over SSH
2016-12-04T13:58:01.4356460Z Description  : Copy files or build artifacts to a remote machine over SSH
2016-12-04T13:58:01.4366160Z Version      : 0.1.2
2016-12-04T13:58:01.4381000Z Author       : Microsoft Corporation
2016-12-04T13:58:01.4392030Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=821894)
2016-12-04T13:58:01.4404190Z ==============================================================================
2016-12-04T13:58:01.9834970Z Setting up SSH connection to remote host *******.
2016-12-04T13:58:02.7855400Z Found 22 files to copy to the remote machine.
2016-12-04T13:58:02.7910230Z Copying file /Users/tim/vstsbuildagent/_work/r1/a/Master build/distribution/.htaccess to /var/www/html/********/public_html/.htaccess on remote machine.
2016-12-04T13:58:02.9029540Z ##[error]Unhandled: handle is not a Buffer

@Mardaneus86: I am able to copy files starting with dot from build agent running on windows to my Ubuntu machine.  I suspect the issues is related to folder permissions similar to the issue here: https://github.com/spmjs/node-scp2/issues/21.
What OS is your build machine running on? What OS is your remote machine? Can you check if the folder is created on the destination and what permissions it has? Please check the folder permissions on the build machine as well.
Thanks,
Madhuri

OS of build machine: macOS Sierra
OS of remote machine: Linux Debian 8.6
You are absolutely right about the permissions. Didn't check those properly, working now. Thanks for your support!

@Mardaneus86 can you share how exactly you fixed this issue? I'm running into the same issue with the azure pipeline

@Mardaneus86 can you share how exactly you fixed this issue? I'm running into the same issue with the azure pipeline

I changed in my prod machine (ubuntu 18) the folder permissions. Just a chmod -R 777 [folder_name].


Export required v1 symbols to implement LDS v2.

This change is solely capitalizing the function names that need to be exported. No functional  changes.

@ostromart: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
97a0a627ed0ec04fe3bb543121e6a5a1e234c776
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
97a0a627ed0ec04fe3bb543121e6a5a1e234c776
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
97a0a627ed0ec04fe3bb543121e6a5a1e234c776
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
97a0a627ed0ec04fe3bb543121e6a5a1e234c776
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
97a0a627ed0ec04fe3bb543121e6a5a1e234c776
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
97a0a627ed0ec04fe3bb543121e6a5a1e234c776
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
97a0a627ed0ec04fe3bb543121e6a5a1e234c776
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
97a0a627ed0ec04fe3bb543121e6a5a1e234c776
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
97a0a627ed0ec04fe3bb543121e6a5a1e234c776
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
97a0a627ed0ec04fe3bb543121e6a5a1e234c776
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Computed Fields

At long last ... the most requested feature in pydantic.

closes #935
closes #1241
closes #2313
replaces #2625 - thank you so much @PrettyWood for your initial work, I've copied a lot of your ideas and code here 🙏

The example from #2625 works unchanged (except underscore_attrs_are_private has been removed):
from functools import cached_property
from random import randint

from pydantic import BaseModel, computed_field

class Square(BaseModel):
    side: float
    _private_attr: int = 1

    @computed_field(title='The area')
    @property
    def area(self) -> float:
        return self.side ** 2

    @area.setter
    def area(self, area: float) -> None:
        self.side = area ** .5

    @area.deleter
    def area(self) -> None:
        self.side = 0.0

    @computed_field(alias='The random number')
    @cached_property
    def random_n(self) -> int:
        return randint(0, 1_000)

    @property
    def public_attr(self) -> int:
        return self._private_attr + 1

    @public_attr.setter
    def public_attr(self, v: int) -> None:
        self._private_attr = v - 1

sq = Square(side=10)
assert sq._private_attr == 1
assert sq.public_attr == 2
sq.public_attr = 5
assert sq._private_attr == 4
assert sq.public_attr == 5
the_random_n = sq.random_n
assert sq.model_dump(by_alias=True) == {'side': 10, 'area': 100, 'The random number': the_random_n}
sq.area = 49
assert sq.model_dump() == {'side': 7, 'area': 49, 'random_n': the_random_n}
del sq.area
assert sq.model_dump() == {'side': 0, 'area': 0, 'random_n': the_random_n}
assert sq.model_dump(exclude={'random_n'}) == {'side': 0, 'area': 0}

The following changes have been made from #2625:

computed fields are not include in JSON Schema at the moment - we need #4697 to generate a separate JSON Schema for the output/serialization of a pydantic model - computed fields will be included in that
x: int = ComputedField(...) style usage has been removed - as @dmontagu pointed out, this will confuse IDEs as it looks like the field should be filled at init time
the return values of computed fields are no longer validated - your a grown-up make sure you return the right type
Some of the funkier passthrough of attributes to custom properties e.g. the update_g test is not long possible - ComputedFieldInfo only proxies setter and deleter to the wrapped property
computed_field on pydantic dataclasses is also supported
serialisation of computed properties is managed in rust, see https://github.com/pydantic/pydantic-core/pull/547 so should be significantly more performant than #2625

TODO:

[x] copy docs across

selected reviewer: @adriangb

please review.

Hi @samuelcolvin
Looks great!
Have a few questions:
1 - is property mark required ?
    @computed_field(title='The area')
    @property
    def area(self) -> float:
        return self.side ** 2

or it can be just like this:
    @computed_field(title='The area')
    def area(self) -> float:
        return self.side ** 2

2 - can a computed field have access to context or object that you pass into model_validate ?

Just wanted to say that I was just looking for this and was very pleasantly surprised that this was literally being done as I was searching for a solution. Great work! 🙌

As far as I'm concerned, this is ready to merge.

Don't merge, there's some missing code.

I wish @samuelcolvin would've referred to #4650, which of the points in the main post have been implemented?
I f not all, any roadmap for the lacking features?

Sorry, I didn't see that issue, I did look, but as you say, there's a lot of noise.
Inheritance is tested and works fine.
Frozen should work fine, needs a test, also a test for validate assignment.
Classmethod - I'm not clear what your asking for, could you give an example?
abstractmethod should work, bit needs a test.
I'm about to get on a flight to pycon, I'll check those on the plane or when I land.

Classmethod - I'm not clear what your asking for, could you give an example?

@classmethod
@property
def some_class_property(cls):
    ...

@classmethod
@cached_property
def some_class_property(cls):
    ...

Wish you a safe flight :superhero:

flight delayed ... everything works fine except there's not TypeError on missing abstractmethods - see the xfail.
Question @adriangb @dmontagu @caniko:

Am I doing the abstractmethod tests right?
Do we care about supporting this?

I am invariant when it comes to abstractmethod, here is the link to the discussion in the previous.
I would use computed_fields with abstract methods that are properties if it is idiomatic. Is it?

If we can make the TypeError work as if there's no comouted_field decorator, sounds like a good idea.
Anyone know how to do that, it's not obvious

I would use computed_fields with abstract methods that are properties if it is idiomatic. Is it?

property is a method that is disguised as a field. Idiomatic/textbook example:
class Person:
    @property
    def age(self) -> int:
        # compute age based on `self.birth_date` and `now()`
        pass

abstractmethod is an ABC method that needs to be implemented in non-ABC child classes. Idiomatic/textbook example:
class EventProducer(ABC):
    @abstractmethod
    def produce(self):
        pass

Now let's combine the two, similarly to as in @adriangb's code (modified it a bit):
class Shape2D:
    @property
    @abstractmethod
    def area(self) -> int:
        pass

I don't know what to say more than it looks idiomatic.
Now, if this is indeed idiomatic then adding computed_field on top, should also be, in my opinion.
(I'm not saying this should be done in this MR. Maybe releasing it without it and waiting for feedback will be a better approach?)

Regarding how to get the type error, I was able to produce an error in Adrian's example via:
from abc import ABC, abstractmethod

from pydantic import computed_field, BaseModel

class AbstractSquare(BaseModel, ABC):
    @computed_field
    @property
    @abstractmethod
    def area(self) -> float:
        raise NotImplementedError

AbstractSquare.__abstractmethods__ = frozenset(set(AbstractSquare.__abstractmethods__) | {'area'})

class BadSquare(AbstractSquare):
    pass

BadSquare()
#> TypeError: Can't instantiate abstract class BadSquare with abstract method area

So I think if we manually update __abstractmethods__ in the Metaclass.__new__ based on the computed fields it should work. I think if we just store whether the wrapped property/method is abstract it should be possible to store the relevant info then update the __abstractmethods__ attribute as appropriate.
And better yet I think we could do this for all the decorators, including @field_validator etc. in the same manner.

@dmontagu, this can be easily implemented on the computed_fields side, why not finish it off now that it is apparent.
Using @abstractmethod on a method sets the method's __isabstractmethod__ attribute to True. Just do the same when applying @computed_field to a method with __isabstractmethod__ set to True.

Merging this since it seems to be 99% ready. We can always iterate on that last 1% or fix any issues in follow-ups.


docs: Added additional instructions for server types

🔗 Linked issue

📚 Description

I managed to keep nuxi typecheck working by adding this lines to my  roottsconfig.json.

Oh yeah I see, that's maybe better than to do it manuelly yeah! Otherwise on server plugin I get typecheck error with vue-tsc

When you do this, does api inference work - e.g. $fetch('/api/route') returns correctly value?

When you do this, does api inference work - e.g. $fetch('/api/route') returns correctly value?

checking, this breaks API type inference, so I wouldn't want to recommend it.
But improving the type support for server vs app is an important priority for me now that we have a directory structure in nuxt v4 that is more conducive to it...


[nightly] Merge from main

This PR merges from the microsoft/go-images main branch, which brings in the 1.19 release, phases out 1.17 and Debian stretch, and updates the readme. Then, another commit adds the microsoft/go main (1.20) images back into nightly, because the merge removes them.
This gives us a clean slate to continue running nightly builds, and also fixes nightly auto-update by getting past the 1.19-rc builds that are currently conflicting with the 1.19 stable builds and causing CI to fail:  https://github.com/microsoft/go-images/pull/152.
I'd recommend only reviewing the final commit that adds the microsoft/go main build back in, because other than that, this is the same as the go-images microsoft/main branch.

Going ahead with one review: this was all already reviewed, this PR just merges and puts a bit of code put back into the config from the nightly branch.


might have issue with destroyed objects

I needed to implement this here https://github.com/kellyselden/ember-macro-helpers/pull/73/files
contexts in the weakmap were destroyed but still being observed. Just wanted to share with you, your implementation may be different, and you might not need this.

Thanks for the heads-up. I'm not sure ember-classy-computed could run into this though as we're never observing anything on the context. If a CP class observes anything on the context that observer would have to be removed when the context is destroyed of course but that's outside of our control. I guess that would best be fixed by providing documentation.
I'll certainly investigate this (when I find the time…) to be sure we're safe here!

OK I remember now that I changed the observer to watch the context instead of the internal class. What about memory leaks? The weakmap never gets cleared out, so destroyed contexts get stored there forever?

I think the idea of WeakMaps is that they clear the key and value once the key object is destroyed.

@kellyselden I think your project (ember macro helpers) might also behaves incorrectly in case of dynamically setting computed properties on context object. Please refer to my PR to learn more about the issue.


[Options] Audio and SFX toggles do not display the correct state

Options Page
Audio and SFX toggles do not display the correct state
Tasks

[x] Have options toggles display correct state

Notes
Simplest is probably reading the current volume from the audio mixer and using that to set the toggle's state.  I just personally haven't had time to do this.
FYI, the mixer uses a slightly different format for volume than an audio source.  Instead of float 0 (volume off) to 1 (full volume) it uses float -80 (volume off) to 0 (default level).

I managed to adjust the script so that the current state of the button is preserved OnDestroy() and DontDestroyOnLoad setting the switch itself inactive so that it cannot be interacted with upon entering other scenes.
Though the behaviors work as intended such that when switching scene if the button says On while music is actually Off, pressing the button again does not suddenly turn audio on; we still run into the issue of the visual aspect not being preserved.
I will have to look further into this because Audio Mixers unfortunately do not have a simple method to get their current volume.

The variables for the Audio and SFX mixer channels should have their volumes as an exposed variable, that's how I've been setting them.
AudioMixer.GetFloat("MusicMasterVol") and AudioMixer.GetFloat("SFXMasterVol") should return the current values.
I'll take a look at this in a few minutes.

I had tried to use the GetFloat function at first, though it actually takes in 2 parameters with one being the name and the other being the out float value. Unity's documentation on this function isn't really the best.

Ok I have managed a way to preserve the visual behavior of the button, but now the audio itself does not carry over to reflect that
visual change. I will push what I have onto my branch if you would like to take a look at it @CCrawfordUOP.

Sounds good, yeah I'll take a look.

I'm thinking of adding another boolean variable to save the previous state of the music such that the boolean check (audioState for example) can also reflect that change because I noticed that when I was debugging I was able to preserve the .isOn behavior from the switch when changing scenes but not the boolean value of the check itself.

I think I've narrowed it down to a weird interaction with the ModenUI asset pack messing with the toggle's default state, though I don't know exactly what part is causing it.
I have a proof of concept implementation that works using a toggle from the default Unity UI objects on the cube-testing branch if you want to take a look.

Honestly thinking about it, what do we really lose deciding to go for the default Unity UI over the Modern pack?

There is nothing to lose other than the aesthetic ripple the buttons have present throughout the app. If it works by using the default button, go for it.

Fixed in cube-testing branch.


Error in readme

I wasn't off to a good start but things turned out in the end. Following the readme give an error on the first step. (Ruby 2.1.2 and  Rails 4.2.0.)
~/code% rails new example -m http://emberjs.com/edge_template.rb
Using --skip-turbolinks --skip-test-unit --skip-bundle --database=postgresql --view-specs=false --controller-specs=false from /Users/dev/.railsrc
  create
  create  README.rdoc
<...snip...>
  create  vendor/assets/stylesheets
  create  vendor/assets/stylesheets/.keep
   apply  http://emberjs.com/edge_template.rb
/Users/dev/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/open-uri.rb:231:in `open_loop': HTTP redirection loop: http://emberjs.com/edge_template.rb (RuntimeError)
	from /Users/dev/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/open-uri.rb:149:in `open_uri'
	from /Users/dev/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/open-uri.rb:704:in `open'
	from /Users/dev/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/open-uri.rb:34:in `open'
	from /Users/dev/.rvm/gems/ruby-2.1.2/gems/thor-0.19.1/lib/thor/actions.rb:218:in `apply'
	from /Users/dev/.rvm/gems/ruby-2.1.2/gems/railties-4.2.0/lib/rails/generators/app_base.rb:143:in `apply_rails_template'
	from (eval):1:in `apply_rails_template'
	from /Users/dev/.rvm/gems/ruby-2.1.2/gems/thor-0.19.1/lib/thor/command.rb:27:in `run'
	from /Users/dev/.rvm/gems/ruby-2.1.2/gems/thor-0.19.1/lib/thor/invocation.rb:126:in `invoke_command'
	from /Users/dev/.rvm/gems/ruby-2.1.2/gems/thor-0.19.1/lib/thor/invocation.rb:133:in `block in invoke_all'
	from /Users/dev/.rvm/gems/ruby-2.1.2/gems/thor-0.19.1/lib/thor/invocation.rb:133:in `each'
	from /Users/dev/.rvm/gems/ruby-2.1.2/gems/thor-0.19.1/lib/thor/invocation.rb:133:in `map'
	from /Users/dev/.rvm/gems/ruby-2.1.2/gems/thor-0.19.1/lib/thor/invocation.rb:133:in `invoke_all'
	from /Users/dev/.rvm/gems/ruby-2.1.2/gems/thor-0.19.1/lib/thor/group.rb:232:in `dispatch'
	from /Users/dev/.rvm/gems/ruby-2.1.2/gems/thor-0.19.1/lib/thor/base.rb:440:in `start'
	from /Users/dev/.rvm/gems/ruby-2.1.2/gems/railties-4.2.0/lib/rails/commands/application.rb:17:in `<top (required)>'
	from /Users/dev/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/rubygems/core_ext/kernel_require.rb:73:in `require'
	from /Users/dev/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/rubygems/core_ext/kernel_require.rb:73:in `require'
	from /Users/dev/.rvm/gems/ruby-2.1.2/gems/railties-4.2.0/lib/rails/cli.rb:14:in `<top (required)>'
	from /Users/dev/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/rubygems/core_ext/kernel_require.rb:73:in `require'
	from /Users/dev/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/rubygems/core_ext/kernel_require.rb:73:in `require'
	from /Users/dev/.rvm/gems/ruby-2.1.2/gems/railties-4.2.0/bin/rails:9:in `<top (required)>'
	from /Users/dev/.rvm/gems/ruby-2.1.2/bin/rails:23:in `load'
	from /Users/dev/.rvm/gems/ruby-2.1.2/bin/rails:23:in `<main>'
	from /Users/dev/.rvm/gems/ruby-2.1.2/bin/ruby_executable_hooks:15:in `eval'
	from /Users/dev/.rvm/gems/ruby-2.1.2/bin/ruby_executable_hooks:15:in `<main>'

This happened three times but then it succeeded on the fourth and subsequent attempts. Just thought I'd let someone know.

It seems a GH-pages issue. (http://emberjs.com is hosted on GH-pages.)
Could you retry a few more times?
ref: https://github.com/emberjs/ember-rails/issues/427

Yes, I tried it right after you replied and again several hours later. I'll close this.


[Bug]: SyntaxError: Unexpected token 'export' of @ckeditor/ckeditor5-*

Version
27.1.0
Steps to reproduce
Example steps :

Clone my repo at https://github.com/michael-vasyliv/react-typescript-editor-demo
npm install
npm run test
You should see the error come up

><EMAIL_ADDRESS>test /home/michael/workspace/react-typescript-editor-demo
> jest

 PASS  tests/enzyme.test.tsx
 FAIL  tests/axios-upload-adapter.test.ts
  ● Test suite failed to run

    Jest encountered an unexpected token

    Jest failed to parse a file. This happens e.g. when your code or its dependencies use non-standard JavaScript syntax, or when Jest is not configured to support such syntax.

    Out of the box Jest supports Babel, which will be used to transform your files into valid JS based on your Babel configuration.

    By default "node_modules" folder is ignored by transformers.

    Here's what you can do:
     • If you are trying to use ECMAScript Modules, see https://jestjs.io/docs/ecmascript-modules for how to enable it.
     • To have some of your "node_modules" files transformed, you can specify a custom "transformIgnorePatterns" in your config.
     • If you need a custom transformation specify a "transform" option in your config.
     • If you simply want to mock your non-JS modules (e.g. binary assets) you can stub them out with the "moduleNameMapper" config option.

    You'll find more details and examples of these config options in the docs:
    https://jestjs.io/docs/configuration
    For information about custom transformations, see:
    https://jestjs.io/docs/code-transformation

    Details:

    /home/michael/workspace/react-typescript-editor-demo/node_modules/@ckeditor/ckeditor5-core/src/index.js:10
    export { default as Plugin } from './plugin';
    ^^^^^^

    SyntaxError: Unexpected token 'export'

    > 1 | import { Plugin } from '@ckeditor/ckeditor5-core';
        | ^
      2 | import FileRepository, { FileLoader } from '@ckeditor/ckeditor5-upload/src/filerepository';
      3 | import { AxiosUploadAdapter } from './axios-upload-adapter';
      4 |

      at Runtime.createScriptFromCode (node_modules/jest-runtime/build/index.js:1517:14)
      at Object.<anonymous> (src/components/text-editor/axios-upload-plugin.ts:1:1)

Test Suites: 1 failed, 1 passed, 2 total
Tests:       4 passed, 4 total
Snapshots:   0 total
Time:        5.411 s
Ran all test suites.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>test: `jest`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>test script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/michael/.npm/_logs/2021-08-31T13_11_52_131Z-debug.log

Expected behavior
don't see the error
Actual behavior
see the error SyntaxError: Unexpected token
Additional context
I've tried this way of configration
transform: {
        '^.+\\\\.(js|jsx)$': 'babel-jest',
        '^.+\\\\.(ts|tsx)$': 'ts-jest'
    },
    transformIgnorePatterns: [
        '<rootDir>.*(node_modules)(?!.*(ckeditor5-react|ckeditor5-build-classic|ckeditor5-build|ckeditor5-core|ckeditor5-highlight|ckeditor5-utils|ckeditor5-ui|lodash-es).*).js$'
    ],

it does not work, jest does not transform js files of ckeditor5
Environment
System:
    OS: Linux 5.11 Ubuntu 20.04.3 LTS (Focal Fossa)
    CPU: (8) x64 Intel(R) Core(TM) i7-7700K CPU @ 4.20GHz
  Binaries:
    Node: 14.17.5 - ~/.nvm/versions/node/v14.17.5/bin/node
    npm: 6.14.14 - ~/.nvm/versions/node/v14.17.5/bin/npm
  npmPackages:
    jest: ^27.1.0 => 27.1.0

@michael-vasyliv are you seeing this problem for Jest 26.x.y as well?
Did you start to see this problem when you did an upgrade?
What was the last version of Jest that worked for you?

@achudars I have not tried version 26.x.x, I've tried many other regexps from all over StackOverflow and all wide internet but it just does not work as expected. I just want to rebuild all packages under @ckeditor (since jest does not parse es6), but jest does not allow me to do that.

to fix issue you have to use ts-jest/presets/js-with-ts


Use magic logo for the readme

I was snooping and finally decided to implement a logo that can change the color of the text based on whether the browser is in dark mode.

Sick!

Merge on green!

Incredible.


implemented album services and added first e2e test

Did not show images properly when trying to load Track List.


Remove outdated work arounds

Removes two work arounds for OSs versions we don't support any more.
Closes #1561

Is Android API level 21 unsupported?

Is Android API level 21 unsupported?

No it's supported.
The EPOLL_CLOEXEC not being defined isn't really an issue that affects us since the libc crate does define the constant. According to https://github.com/android/ndk/issues/394#issuecomment-301710618 and  https://android.googlesource.com/platform/bionic/+/master/libc/libc.map.txt#308 Android API level 21 have epoll_create1.

Sorry @link2xt, but this isn't going to change. As you said Rust officially doesn't support Android 4 any more, so I don't want to take on the additional maintenance burden to support it either.


ptb_word_lm.py error: unsupported operand type(s) for /: 'Tensor' and 'int'

Hi,
I ran the ptb_word_lm example from models/rnn/ptb. however I got the unsupported operand type(s) for /: 'Tensor' and 'int' for line 139 in ptb_word_lm.py.
I also managed to fix it, by changing
139 self._cost = cost = tf.reduce_sum(loss) / batch_size
to
139 self._cost = cost = tf.div(tf.reduce_sum(loss), tf.constant(batch_size, dtype=tf.types.float32))
And it works fine so far.

Thanks for letting us know about this. Could you tell me whether you're using Python 2 or 3? (Although we're using from __future__ import division, this smacks of a Python 3 compatibility issue....)

I'm using 2.7, however when I commented out the from __future__ import division the original code worked fine. So it is some "v3" trickery.

This may be a 'feature' -- tensors are intentionally rather strict about
implicit conversions, so I think they don't have olddiv. Try casting
the int to a float.
On Mon, Dec 14, 2015 at 1:00 PM Martin Tutek<EMAIL_ADDRESS>wrote:

I'm using 2.7, however when I commented out the from future import
division the original code worked fine. So it is some "v3" trickery.
—
Reply to this email directly or view it on GitHub
https://github.com/tensorflow/tensorflow/issues/506#issuecomment-164557689
.

Attempt 1:
from __future__ import division
self._cost = cost = tf.reduce_sum(loss) / float(batch_size)

TypeError: unsupported operand type(s) for /: 'Tensor' and 'float'

Attempt 2. maybe numpy?
from __future__ import division
self._cost = cost = tf.reduce_sum(loss) / np.array(batch_size, dtype=np.float32)

TypeError: unsupported operand type(s) for /: 'Tensor' and 'float'

With from __future__ import division just the way in the original issue I wrote seems to work.

@mttk: what do you get when you print
tf.__version__ ?

@vrv you got it :)
First I got AttributeError: 'module' object has no attribute '__version__'
After updating to 0.6.0 , the original code works fine. My bad, sorry for the mistake guys!


fontTools.ttLib.tables.otBase.OTLOffsetOverflowError: ('GPOS', 'LookupIndex:', 0, 'SubTableIndex:', 1, 'ItemName:', 'PairSet', 'ItemIndex:', 45)

I got this error for the first time on 2016-04-08 at 17:52 but I didn't notice it. I just noticed it today looking at the font creation dates.
This happens when processing NotoSansEthiopic-MM.glyphs
NotoSansEthiopic-MM.glyphs.zip

Removing overlaps for NotoSansEthiopicCondensed-Black
Saving OTF for NotoSansEthiopic-Thin
Saving OTF for NotoSansEthiopic-Light
Saving OTF for NotoSansEthiopic-Regular
Saving OTF for NotoSansEthiopic-Medium
Traceback (most recent call last):
File "/usr/lib/python2.7/runpy.py", line 162, in _run_module_as_main
"main", fname, loader, pkg_name)
File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
exec code in run_globals
File "build/bdist.linux-x86_64/egg/fontmake/main.py", line 58, in
File "build/bdist.linux-x86_64/egg/fontmake/main.py", line 42, in main
File "build/bdist.linux-x86_64/egg/fontmake/font_project.py", line 215, in run_from_glyphs
File "build/bdist.linux-x86_64/egg/fontmake/font_project.py", line 252, in run_from_ufos
File "build/bdist.linux-x86_64/egg/fontmake/font_project.py", line 112, in build_otfs
File "build/bdist.linux-x86_64/egg/fontmake/font_project.py", line 157, in save_otfs
File "/usr/local/lib/python2.7/dist-packages/fonttools-3.0-py2.7.egg/fontTools/ttLib/init.py", line 216, in save
self._writeTable(tag, writer, done)
File "/usr/local/lib/python2.7/dist-packages/fonttools-3.0-py2.7.egg/fontTools/ttLib/init.py", line 648, in _writeTable
tabledata = self.getTableData(tag)
File "/usr/local/lib/python2.7/dist-packages/fonttools-3.0-py2.7.egg/fontTools/ttLib/init.py", line 659, in getTableData
return self.tables[tag].compile(self)
File "/usr/local/lib/python2.7/dist-packages/fonttools-3.0-py2.7.egg/fontTools/ttLib/tables/otBase.py", line 91, in compile
return writer.getAllData()
File "/usr/local/lib/python2.7/dist-packages/fonttools-3.0-py2.7.egg/fontTools/ttLib/tables/otBase.py", line 412, in getAllData
tableData = table.getData()
File "/usr/local/lib/python2.7/dist-packages/fonttools-3.0-py2.7.egg/fontTools/ttLib/tables/otBase.py", line 282, in getData
raise OTLOffsetOverflowError(overflowErrorRecord)
fontTools.ttLib.tables.otBase.OTLOffsetOverflowError: ('GPOS', 'LookupIndex:', 0, 'SubTableIndex:', 1, 'ItemName:', 'PairSet', 'ItemIndex:', 45)

Beat you to it! Duplicate of https://github.com/googlei18n/fontmake/issues/63

Thanks James for catching this earlier :-) I need to read open bugs and avoid duplicates.


Broken link on 'LinuxWindowsSupport.md'

From LinuxWindowsSupport.md:

If you hit a ERROR  Watcher took too long to load on Windows, try increasing the timeout in this file (under your node_modules/react-native).

However, the code that should've been linked to has moved to node-haste.
I'd send a PR but, well, I'm not certain how dependencies have moved around.

cc @cpojer

Ugh, we should at least update the documentation, but then the problem is that the developer has to dig into compiled output in node_modules/node-haste/lib. Is this a common issue? If yes, we should probably make this a configurable option for FileWatcher instances.

@cpojer - good point, perhaps this should be configurable. I'm not sure where this originated from and don't use windows, @DanielRosenwasser do you know if this is common?

Well I ran into it when starting to use React Native on Windows, and someone else documented it at some point, so it's probably sufficiently common.
For the record, I don't see node-haste as a dependency in version 0.21.0, so I don't know what the correct workaround is right now.

For older versions that don't have node-haste, you can just update https://github.com/facebook/react-native/blob/5fa33f3d07f8595a188f6fe04d6168a6ede1e721/packager/react-packager/src/DependencyResolver/FileWatcher/index.js as you pointed out yourself in the initial comment.

as you pointed out yourself in the initial comment.

D'oh. Forgot where I'd left off last night. :smile:


Fix & escape character problem

Fix '&' problem

After

Hey Wei!
Thank you for your PR, much much appreciated!
Let me grab some time to review it and get back to you soon.
Thanks again!

I'm sorry it took me so long to review this. I enhanced the fix by escaping any special character in the uri encodeURIComponent. Thanks again for your contribution!
New PR here: https://github.com/caroso1222/amazon-autocomplete/pull/16


Backup alternates between single file and multiple files

The backup occurs regularly but sometimes the result is a single .json file and other times it's a collection of markdown files. There doesn't seem to be any rhyme or reason to when it's one or the other. You can tell the difference by the file sizes in this image.

it's similar/same as #7 - the larger your database - the less reliably the switch to json works


TypeError: e.getIdToken is not a function

Describe the bug
Type error when launching next-firebase-auth linked to getIdToken function.
Version
  "firebase": "^8.3.2",
   "firebase-admin": "^9.6.0",
   "next": "^10.1.2",
   "next-firebase-auth": "^0.13.0-alpha.3",
   "react": "^17.0.2",
   "react-dom": "^17.0.2",

To Reproduce
Steps to reproduce the behavior:

Wrap a static landing page with withAuthUser
export default withAuthUser()(LandingPage);

Launch
yarn dev

The error is linked to createAuthUser

Uncaught (in promise) TypeError: e.getIdToken is not a function
    at Object.eval (index.browser.js?3144:1)
    at Generator.next (<anonymous>)
    at asyncGeneratorStep (asyncToGenerator.js?c973:3)
    at _next (asyncToGenerator.js?c973:25)
    at eval (asyncToGenerator.js?c973:32)
    at new Promise (<anonymous>)
    at Object.eval (asyncToGenerator.js?c973:21)
    at Object.eval [as getIdToken] (index.browser.js?3144:1)
    at eval (index.browser.js?3144:1)
    at Generator.next (<anonymous>)
    at asyncGeneratorStep (asyncToGenerator.js?c973:3)
    at _next (asyncToGenerator.js?c973:25)
    at eval (asyncToGenerator.js?c973:32)
    at new Promise (<anonymous>)
    at eval (asyncToGenerator.js?c973:21)
    at eval (index.browser.js?3144:1)
    at eval (index.browser.js?3144:1)
    at Generator.next (<anonymous>)
    at asyncGeneratorStep (asyncToGenerator.js?c973:3)
    at _next (asyncToGenerator.js?c973:25)
    at eval (asyncToGenerator.js?c973:32)
    at new Promise (<anonymous>)
    at eval (asyncToGenerator.js?c973:21)
    at eval (index.browser.js?3144:1)
    at Object.eval (index.browser.js?3144:1)
    at Generator.next (<anonymous>)
    at asyncGeneratorStep (asyncToGenerator.js?c973:3)
    at _next (asyncToGenerator.js?c973:25)

Expected behavior
Understand where the error comes from and correct it
Additional context
Add any other context about the problem here.
Thank you for your help!

FYI, I downgraded to 0.12.2, no issue with this version if someone is facing the same issue.

Same problem here, works with alpha.0

Fixed in v0.13.0-alpha.4 and updated the live example app.


typo

line 12 sceanrios corrected to proper spelling

Closing as dupe of https://github.com/MicrosoftDocs/windows-ai-docs/pull/55.


Bad type checking inside typeguarded block

TypeScript Version:  3.5.1

Search Terms: Type Guard
interface FOO {
    [key:string]: number
}

declare var foo: FOO | null

if(foo) {
    var a =  foo['string'] // good
    Object.keys(foo).map(key => {
        var b =  foo[key]  // foo cannot possibly be null
    })
}

//related
foo && foo['string'] && Object.keys(foo).map(key => {
    var a = foo[key] // foo cannot possibly be null
})

Expected behavior:
Should know Object is not 'null'
Actual behavior:
Thinks Object is possibly 'null'
Playground Link: ts-playground
Related Issues:

It cannot know that foo won't become null inside the function, in the general case.
In this specific instance, you can say that the callback is invoked immediately and never invoked again after .map(), so, it cannot be null.
But the compiler can't know that for sure yet

https://github.com/microsoft/TypeScript/issues/11498

Also see #9998.


Maybe refactor documentations

See discussions in https://github.com/fzyzcjy/flutter_rust_bridge/issues/250
TODO:

[x] the basics
[ ] configure mdbook (since it is by rust ;))

I think you could even consider a book and a step-by-step extended example IMHO.
This crate looks awesome, but difficult to grasp without some prior knowledge and digging informations scattered around.

@Roms1383 Great, I will consider that

Will do mdbook tomorrow (e.g. by https://rust-lang.github.io/mdBook/continuous-integration.html)

almost done


⚠ Processors has degraded performance

In 2ede292, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 140 ms

Resolved: Processors performance has improved in 05cb074.


New version: JetBrains.CLion.EAP version 242.20224.66

Created by 🥟 Dumplings in workflow run #6682.

Log
Updated: 242.19890.26 → 242.20224.66
Submitting WinGet manifests
Creating manifests
Uploading manifests and making commits
Creating a pull request

Microsoft Reviewers: Open in CodeFlow

https://github.com/microsoft/winget-pkgs/issues/142854


docs(README): add documentation badge

:tada: This PR is included in version 1.1.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Increasing space in Column content (with Arrangement.spacedBy(16.dp)) when ModalBottomSheet is opened

Describe the bug
When bottom sheet is in Column with verticalArrangement = Arrangement.spacedBy(16.dp) then after bottom sheet is shown, spacing in main content increases. (check attached video)
Affected platforms

iOS

Versions

Libraries:

Compose Multiplatform version: 1.6.10

Kotlin version: 2.0.0
OS version(s) (required for Desktop and iOS issues): 17.0, 17.5...
OS architecture (x86 or arm64): arm64
Device (model or simulator for iOS issues): iPhone 15 iOS 17.5 Simulator (happens on other versions as well)

To Reproduce
Steps to reproduce the behavior:

Checkout code from https://github.com/syru88/BottomSheetJumpingIssue or use this snippet:

@OptIn(ExperimentalMaterial3Api::class)
@Composable
@Preview
fun App() {
    MaterialTheme {
        Scaffold { paddingValues ->
            val sheetState = rememberModalBottomSheetState()
            val scope = rememberCoroutineScope()
            var showBottomSheet by remember { mutableStateOf(false) }

            Column(
                modifier = Modifier.fillMaxWidth().padding(paddingValues),
                // ok without arrangement
                verticalArrangement = Arrangement.spacedBy(16.dp),
                horizontalAlignment = Alignment.CenterHorizontally
            ) {
                Text("Just random text")

                if (showBottomSheet) {
                    ModalBottomSheet(
                        onDismissRequest = {
                            showBottomSheet = false
                        },
                        sheetState = sheetState
                    ) {
                        Button(onClick = {
                            scope.launch { sheetState.hide() }.invokeOnCompletion {
                                if (!sheetState.isVisible) {
                                    showBottomSheet = false
                                }
                            }
                        }) {
                            Text("Hide bottom sheet")
                        }
                    }
                }

                Button(onClick = { showBottomSheet = true }) {
                    Text("Click me!")
                }

            }
        }
    }
}

Click on "Click me!"
Spacing between text and button in main content has increased.

Expected behavior
Space should be same as before bottom sheet is opened. It works on Android.
Screenshots
https://github.com/JetBrains/compose-multiplatform/assets/3898471/9d887ef4-ff37-4070-8fdd-1ce677caff3f

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


ci: Adjust VM usage for CNI Release Test Pipeline

Reason for Change:

Amplifies the ability for CNI Release Test Pipeline to use different regions for our test matrix.
As this adjusts restart-node-template.yaml, its usages across other pipelines have been updated.
Issue Fixed:

Requirements:

[x] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[x] relevant PR labels added

Notes:

/azp run Azure Container Networking


[FR Currency] Issue when parsing french word "sur" in currencies

When I send the following sentence to Luis
Je veux un crédit de EUR 1000 sur 3 ans (I want to loan EUR 10000 for 3 years), the entity money recognized is "EUR 1000 sur".
However, if I invert the currency and put it after the amount, it works. But Speech service formats it that way (currency in front of amount)
Thanks

Fixed in #1802.


dry run mode

Should dry-run mode be the default?

I would propose something like the git clean dry run. There it says:
would remove target/
would remove hello.txt

In our case this could look like:
[0] % cargo run -- -p ../test-project
     Running `target/debug/semantic-rs -p ../test-project`
semantic.rs 🚀
Analyzing your repository
Current version: 2.0.0
Analyzing commits
Commits analyzed. Bump would be Major
New version would be: 3.0.0
Would Changelog
Would create annotated git tag

Yup, dry-run by default sounds good. Maybe it makes sense to show the Changelog on the console in dry-run mode.
Also: semantic-release checks the env variable CI and if it is set it runs the real tool, otherwise a dry-run, we should do the same eventually.

Agree!

Resolved in #46


The operation was unable to achieve a quorum during its retry window.

Hi, What is this problem?

Hi @WinmezzZ, This package is a wrapper for node-redlock, so it does not implement the algorithm of redlock itself.
Perhaps checking these Issues may provide the solution you are seeking.
https://github.com/mike-marcacci/node-redlock/issues/168


Word 'Break me' add to stabilize full scenario tender_owner role

unnecessary empty strings removed

This change is

one more fix will be add, so no need in this one


Update Azure Account ext. workaround guidance

Related to https://github.com/Azure/azure-sdk-for-net/pull/28736
Update the guidance we provide to customers

API change check for azure-identity
API changes are not detected in this pull request for azure-identity


Get script for helm does not work since latest release

The get script searches the github releases page for a matching tag if no desired version is provided:
release_url="https://github.com/helm/helm/releases"
# ...
TAG=$(curl -Ls $release_url | grep 'href="/helm/helm/releases/tag/v2.[0-9]*.[0-9]*\"' | grep -v no-underline | head -n 1 | cut -d '"' -f 2 | awk '{n=split($NF,a,"/");print a[n]}' | awk 'a !~ $0{print}; {a=$0}')

https://github.com/helm/helm/blob/main/scripts/get#L83
to be precise it searches for a v2 tag which since the latest release appears only on page 2 of the release pages. This way it does not seem to find a usable tag.

Just hit this issue myself.

For background context, we dropped support for Helm 2 back in November. It was only a matter of time before things like the install script would begin to fail.
https://helm.sh/blog/helm-2-becomes-unsupported/
The workaround described by @dbsanfte will work as it bypasses the "smart checks" used in the install script to scrape the latest release from the GitHub releases page.
Because we are no longer providing fixes for Helm 2, I'm going to close this as a wontfix.
Please migrate to Helm 3 as soon as possible. There are a number of significant security issues addressed in Helm 3 since October that likely affect Helm 2 users.
Thanks.

For those who haven't migrated to helm3 so far
curl -fsSL https://raw.githubusercontent.com/helm/helm/master/scripts/get | sed 's/$TAG-$OS-$ARCH/v2.17.0-linux-amd64/' | bash


Change in the report name dynamically based on the module.

we changed the name in html_template.py file... but this is static approach.. I am just looking to do change dynamically

we changed the name in html_template.py file... but this is static approach.. I am just looking to do change dynamically

@priya24it yes this changes needed.
@prashanth-sams thanks for all your effort to make this plugin. Really nice to see this detailed and graphical representation of the test report 👍

@prashanth-sams Please review my changes for the HTML report name update from environment variable. Thanks for your support
@priya24it Can you please try this change and let me know your feedback.

@nireshs @priya24it Added this feature in 0.2.7
Sample Usage:
pytest tests/ --html-report=./report/report.html  --title='YOUR CUSTOM TITLE'


bump expensify-common version to latest

Details
Bump the expensify-common version to the latest, mainly for https://github.com/Expensify/expensify-common/pull/606
Fixed Issues
$ https://github.com/Expensify/App/issues/26490
$ https://github.com/Expensify/App/issues/16982
PROPOSAL: https://github.com/Expensify/App/issues/26490#issuecomment-1758233329
Tests

Go to any report
Paste and send markdown provided below
Copy the message sent and paste the copied message in the composer
Verify that the (line break) is kept

```
code
```
text
```
code
```

[x] Verify that no errors appear in the JS console

Offline tests
Same as tests
QA Steps
Same as tests

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/Expensify/expensify-common/assets/97473779/fde883da-8824-450e-a6ae-d5a48f682c02

Android: mWeb Chrome
https://github.com/Expensify/expensify-common/assets/97473779/1645e93f-78ee-48a1-ba16-e22910b08478

iOS: Native
https://github.com/Expensify/App/assets/30532000/7ba9c917-0ed8-4f45-a852-bb2fe53095c3

iOS: mWeb Safari
https://github.com/Expensify/expensify-common/assets/97473779/c441bb1a-6d15-4812-9928-5d6099a84fdb

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/30532000/ee0f376b-4e11-4495-811e-4f2cb2895ea9

MacOS: Desktop
https://github.com/Expensify/expensify-common/assets/97473779/16f7cee9-5659-457b-b71d-47be4428ddd7

I have read the CLA Document and I hereby sign the CLA

I have read the CLA Document and I hereby sign the CLA

@0xmiroslav Yes, I completed the checklist, thanks

Ah looks like sync is down. I verified locally by making sure that npm install isn't making any changes as done here. Going to go ahead with the merge.

🚀 Deployed to staging by https://github.com/srikarparsi in version: 1.4.2-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.2-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


YamlMapping.java:35-37: We should implement class...

The puzzle 59-9ff4de5f in src/main/java/com/amihaiemil/camel/YamlMapping.java (lines 35-37) has to be resolved: We should implement class ReadYamlMapping, which should implement this interface. The class will encapsulate and work with YamlLines.
The puzzle was created by amihaiemil on 16-Feb-17.
Estimate: 30 minutes, role: DEV.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD.

@amihaiemil please pay attention to this new issue.

The puzzle 59-9ff4de5f has disappeared from the source code, that's why I closed this issue. //cc @amihaiemil


Simple authorization use case: define graph DB unit test data

Created by: @bayegan Sep 26 2021 at 07:23 CET
Last updated: Jul 18 2022 at 11:23 CET
ClickUp ID: IK-1546
Implement user data as defined in previous tickets related to creating a POC for a simple authorization use case:
Implement unit tests in graph DB
Propose back-end APIs required for unit tests
Propose scenario for demonstration using Wonka and Slugworth sample apps

Commented by: @bayegan Oct 11 2021 at 19:00 CET
Duplicate of 1j7zz4y


WIP

Codecov Report

:exclamation: No coverage uploaded for pull request base (atspi@5832acf). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             atspi       #1   +/-   ##
========================================
  Coverage         ?   83.73%
========================================
  Files            ?       58
  Lines            ?    21941
  Branches         ?        0
========================================
  Hits             ?    18372
  Misses           ?     3569
  Partials         ?        0


.gitignore not being respected

For some reason, I've found since updating silver searcher from the Ubuntu repo version (to latest git snapshot) ag doesn't respect gitignore files anymore (only my system $HOME/.agignore seems to be respected).
Any ideas why this is happening? Even in the README it is advertised it respects gitignore. My ag command is just plain ag "Query Here".

Having the same problem here:
ag version 0.28.0
Linux ricardo-xxxxxx 3.19.0-51-generic #58-Ubuntu SMP Fri Feb 26 21:22:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
Distributor ID:	Ubuntu
Description:	Ubuntu 15.04
Release:	15.04
Codename:	vivid

I have the same issue. My .gitignore looks like:
...
log/*.log

But .log files are still searched. However, change the .gitignore to
...
log

allows ag to ignore them.

Seems like this is fixed for me in the latest silversearcher
ag version 0.33.0

This is also fixed for me now that I'm on 0.33.0

Going to close as not to pollute issues list.


Split bill - App crashed when try to split bill via group

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Issue found when executing PR https://github.com/Expensify/App/pull/22643
Action Performed:

Create a brand new account that isn't on a domain with a subscription (xyz@expensify
❌ //<EMAIL_ADDRESS>✅ )
Create a group chat with multiple participants
'Split Bill' for group

Expected Result:
You should be able to split a bill from someone successfully
Actual Result:
App crashed on iOS. Android App, Button "Split" not active for Mac/Chrome, Desktop App, mweb
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[ ] Android / Chrome
[x] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/dd9ff7a7-acba-4aba-b5fc-e9958f3f4d6f
https://github.com/Expensify/App/assets/78819774/e170cde5-92d7-4e0b-a56d-0c19f35f2bce
https://github.com/Expensify/App/assets/78819774/7001dfc3-9db0-45b2-8148-ad37ef01fcd8
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Proposal
Please re-state the problem that we are trying to solve in this issue.
App crashes when try to split bill with new users
What is the root cause of that problem?
The backend returns personalDetail info with login = 'undefined' for new users as I mentioned https://github.com/Expensify/App/issues/22588#issuecomment-1631609348.
So the parameters of Localize.arrayToString includes undefined for newly created accounts.
https://github.com/Expensify/App/blob/25c8ae5212f433ea7679ba4bd040c79f151a282a/src/libs/actions/IOU.js#L462
This is the root cause
What changes do you think we should make in order to solve the problem?
login field for new users are undefined. Instead they have alternateText(email) and text(display name) fields. We can use this
    const formattedParticipants = Localize.arrayToString([currentUserLogin, ..._.map(participants, (participant) => participant.login || participant.alternateText)]);

This works as expected.
What alternative solutions did you explore? (Optional)
This can be fixed in the backend

Closing since this is a duplicate of https://github.com/Expensify/App/issues/21268. Please take all proposals to that issue instead.


Tidy scivision README

Changes
Simplifies the repo landing page and moves the maintainer documentation to a separate place

This looks good - not cluttering the README with instructions for maintainers is a good idea.
These files are sphinx doc pages, so don't forget to update index.rst so the changes get reflected there too.
Perhaps we could update some of these links (e.g. contributing, maintainer_docs) so that they point to the relevant place on readthedocs, rather than the markdown file on GH? The idea being to keep the docs conceptually in one place, with the README file a landing page/jumping off point only.

Thanks for the review @ots22 I've made most of the changes including linking to the readthedocs contribution page -  actually the maintainer docs I think should be left off readthedocs - what do you think? The index.rst is currently different from README.md in a way I think makes sense.
I need to update the rst files on the other PR though!

To me this is all part of the project documentation - is there a reason to separate it?

@ots22 perhaps you're right, it just seems odd to have a bit about how to update readthedocs inside readthedocs haha

@ots22 would you be happy for me to merge this? I can be persuaded to adopt your view on the maintainer docs if you think it makes the most sense, but see above comment

Ah sorry - I still think it makes sense to keep it all together - even the readthedocs part (perhaps even especially so!)

@ots22 I've moved this to readthedocs and added some links to the github repo (and pypi repo) so that it makes sense in this context now 😄


MaBoSSG_BB Building block for using the GPU implementation of MaBoSS

This building block (and associated singularity image) implements the sensitivity analysis of the MaBoSS_BB (used in UC2), but using MaBoSSG, the GPU implementation of MaBoSS done by @asmelko.
I'm also including a sample model, list of druggable and list of targets to be able to test it using :
MaBoSSG_BB --tmpdir=/tmp --model_folder ./data/ --genes_druggable ./data/genes_druggable.csv --genes_target ./data/genes_target.csv --result_file result.csv
One important note is that I had to modify the permedcoe library for this, to reproduce the way we are running GPU code with singularity here at Curie. When lanching the code, we are using :
singularity exec --nv
which enables NVIDIA GPU support in Singularity. So I had to add this in the core/building_block.py by changing to this :         self.sing_command_comp["action"] = "exec --nv"
There might be an easier way, but I couldn't find it.
Another important note is that the singularity image is using the NVIDIA toolkit v11.6, so it needs the CUDA drivers version >=450.80.02

Update README.md including a short description of the new Building Block.

I just did :

I specified it does mutant analysis using NVIDIA GPU accelerators
I added the NVIDIA drivers dependency

The rest is a clone from MaBoSS_BB, but this is on purpose (This BB is doing exactly the same thing as MaBoSS_BB, but on GPU).


4033 product drives filter by category

Resolves #4033
Description

Added new filter to the product drive page. This allows for filtration by item category. Made adjustments to the functions that display donation quantities and distinct item counts to return correct figures for when item category is chosen.
Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Visual Test:

Login as organization admin.
Go to the product drive page.
Select an item category from the drop down menu.
Apply the filter.
Confirm product drive are filtered correctly and that donation quantities and distinct item counts are correct.

Rspec Tests:
Added testing to spec/models/product_drive_spec.rb to confirm that

All donated organization item quantities by category and date are correctly calculated and returned.
All distinct donated organization items belonging to a given category are correctly counted and returned.
Filter by_item_category_id works as expected.

Screenshots

Before:

After:

One last nitpick and then I think this is good to go!

Sorry missed that one! Should be sorted now 😄

Seems as though there appears to be a flaky test case in spec/system/manufacturer_system_spec.rb:51 that caused the following timeout failure
Failures:

  1) Manufacturer allows a user to update a manufacturer with empty attributes
     Failure/Error: raise TimeoutError unless data

     Ferrum::TimeoutError:
       Timed out waiting for response. It's possible that this happened because something took a very long time (for example a page load was slow). If so, setting the :timeout option to a higher value might help.

Not sure if this a known issue.
see https://github.com/rubyforgood/human-essentials/actions/runs/8059102112/job/22012957655 for full log
And another flaky test in ./spec/system/distribution_system_spec.rb:111 but I believe this was confirmed to be a known issue based on the conversation here and that there is a fix on another branch

Yep, does look flaky. Re-ran it and it passed. The other one should be fixed on the main branch.

Looks good - thank you!

No problem, thanks for all the good feedback!


Fix warning when accessing configurations

In getSubFolders.ts.
const excludedFilesSettings = workspace
    .getConfiguration('files', workspaceFolder)
    .get<ExcludeFilesSetting>('exclude')

The warning is:
[ms-vscode.csharp] Accessing a resource scoped configuration without providing a resource is not expected. To get the effective value for 'files.exclude', provide the URI of a resource or 'null' for any resource.

Should be fixed in v2.0.2


SwiftSpinner Android?

Wondering if you ever plan to implement the same thing with Android?

hey - I work on the iOS platform - don't have any plans about Android. If you like SwiftSpinner maybe as k an Android developer to port it?


Move to Ionide org

Right after FableConf, I agreed with Krzystof that we'd name the new project Ionide-Fable and he created a repo for us in Ionide org, but I forgot to move the code there 😅
Moving the REPL to Ionide org may help create synergies from both projects: sharing more code, getting help from Ionide contributors, etc. What do you think @MangelMaxime @ncave?

Sure I am OK with that 😊
What will we share the whole project? Only part of it?

I guess the easiest way is to transfer the whole repo, but I'm not sure if that will break the web address we just announced. I'll look into that :+1:

We also have hard-coded url in the generator.fs file

@alfonsogarciacaro I don't really have an opinion either way on Fable org vs the Ionide org, whichever org you think will add more contributors or visibility.


There is no distinction between no data and an error in __return_json_v3

Hey,
we want to use your library and we came across the problem that there is no possibility to distinguish between there is no data and there was an error thrown __return_json_v3. We need this for retrying. Or is there a possibility which I have overseen? Otherwise we would add it, and maybe we can merge back in this repository.

Yeah, error catching is definitely thin in this project.  I'd love to
see what you come up with to resolve this!
On 9/17/21 12:03 AM, Markus Semmler wrote:

Hey,
we want to use your library and we came across the problem that there
is no possibility to distinguish between there is no data and there
was an error thrown __return_json_v3. We need this for retrying. Or is
there a possibility which I have overseen? Otherwise we would add it,
and offer to merge back!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/daxm/fmpsdk/issues/21, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAZOMZZEGRA5CISZYBHCYXLUCLK43ANCNFSM5EGIJLUQ.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

No error handling, because it would actually introduce breaking changes. Here is a minimal change to support handling all errors (as once) outside of the function https://github.com/daxm/fmpsdk/pull/22.

PR merged


Setup internal/external index with the API server. (still relevant?)

This is about having somewhere that people can push to without worrying that they will affect the production content.
The development workflow for creating item descriptions is:

have a local/jasmin/ingest installation of the generators.
Run a small subset of your dataset through using the file_system input and file_out output.
Develop the item-description until you have your desired output
Try on a different/larger subset
Push your item-description into github and use the stac_rescan_dir command to send your dataset through the system
Tweak item-description to modify the content and re-run the tagging.

Using the above workflow, having a separate index setup may not be necessary.

Not required.


[Fix] implement requiresMainQueueSetup

Module CashfreePgApi.swift and CashfreeEventEmitter.swift requires main queue setup since it overrides init but doesn't implement requiresMainQueueSetup

This issue is fixed in version 1.0.2 which is released today.
Please update to the latest version.


update(slide-toggle): remove CRLF line endings

Previously the slide-toggle files were commited with CRLF line endings, but to provide consistency those should be only LF.

LGTM
Confirmed that this removes the CR characters (github doesn't show them in the diff)


Typescript version / definition files

Hi,
I was wondering if there are any plans to eventually release a typescript version of OpenSeadragon, or at least release a .d.ts definition file.
I've found a few mentions to this topic in #456 but it appears no one is working on it.
In case anyone is interested, I started my own definition file, which you can find in this repo:
https://github.com/alvaromartmart/types-openseadragon
Bear in mind it is not complete and is based on the official documentation of v. 2.4.0 of OpenseaDragon.
If anyone is interested in collaborating, please let me know!
Whenever it is stable I would like to publish it to the DefinitelyTyped repo or as an npm package so anyone can install it as @types/openseadragon

Sweet!
I don't foresee us switching to TypeScript, or creating a parallel version in TypeScript, but if it's possible to have a sidecar file that gives optional TypeScript support to OpenSeadragon, that would be lovely!
The one you've built so far already looks pretty comprehensive. Sounds like publishing to DefinitelyTyped when you're ready is a great plan. Let me know if there's anything that would be helpful on the OSD side.  For instance I imagine it would be good to reference in the docs somewhere.

@alvaromartmart
Excellent! This just recently got added to my need-to-do-soon list, so it's great to see someone already started tackling it!
If I find anything I can contribute then I'll definitely be interested in collaborating

So helpful!!! Thank you!

@alvaromartmart are you still looking for help on this?

@peterlazzarino I am!
While the current state of the definition file suits my needs, there are some tasks I would like to work on at some point:

Disclaimer: As I stated on the OP, I wrote the definition file based on the official documentation, mostly. At some points I went to the code to better understand some things that were not clear to me, but 95% was me trusting that the documentation is up to date with the implementation.

[ ] Reviewing the current definitions. Maybe not thoroughly, but I don't use the whole range of OpenSeadragon features, so there are things I might have missed:

[ ] There are a lot of methods/constructors with optional parameters, which in my head translates to several function signatures. I tried to include as many supported signatures in the definition file, but some may be missing.
[ ] I don't consider myself the greatest js developer in the world, so feedback is welcome. For instance, I'm not always sure when to use an interface over a type aliases.

[ ] There are no tests. I have not investigated yet the proper way to write ts definition file tests.
[ ] There is just one big declaration file, it may be a good idea to spread it between several, feature-related files, and export them all together.
[ ] OSD plugins support: I have not used any plugins yet and have not looked into how they are implemented, so I am not sure how easy it will be to include plugin definitions too.

Looking further down the road:

I think including the code documentation in the definition file would be great, as we would be getting intellisense in VSCode and others, making it much easier to work with OpenSeadragon.
Publishing the definition file to DefinitelyTyped, or including it on the OpenSeadragon repo itself.

So the TL; DR version is: anyone willing to help with this stuff, feel free to contact me, I'm open for collaborators ;)

Very helpful! Could you please give some brief code example for usage?

...more specifically, just the basics for gettings started, import statement and contructor basically, I can't seem to get it to work

@markmatney yes, I should probably make some working example when I have the time... just to get you started, if you use npm you can:
npm i --save openseadragon
npm i --save-dev alvaromartmart/types-openseadragon

Then you should be able to import stuff in your code like this:

import { Viewer } from 'openseadragon';
const viewer = new Viewer({
      id: 'osd-div',
      prefixUrl: 'https://openseadragon.github.io/openseadragon/images/',
      tileSources:
        {
          Image: {
            xmlns: 'http://schemas.microsoft.com/deepzoom/2008',
            Url: '//openseadragon.github.io/example-images/duomo/duomo_files/',
            Format: 'jpg',
            Overlap: '2',
            TileSize: '256',
            Size: {
              Width:  '13920',
              Height: '10200'
            }
          }
        }
    });

@alvaromartmart I'm interested in collaborating to get this over the finish line into a DefinitelyTyped PR! 🎉

@kristinruben sure! Actually, I was thinking on preparing the PR soon (maybe in the next couple of days), I'll give you the heads up when I get to it.
I will probably need some help writing some tests as recommended by the DefinitelyTyped guidelines.

@alvaromartmart awesome, would love to help!

@kristinruben I've created an openseadragon branch in my DefinitelyTyped fork with the intention of preparing the PR from there.
It's already passing the linting enforced by DefinitelyTyped
cd types/openseadragon
npm run lint openseadragon

and can be compiled
tsc

So it's almost ready to go, the only thing is, the test file is almost empty. If you can come up with a couple of tests -keep in mind that they're not ran, only type-checked- feel free to add them to openseadragon-tests.ts.

@alvaromartmart I have a local branch knr/openseadragon that I'm ready to push. Just need push access if that's okay!
I've linted the tsconfig.json to remove the comments (my linter was complaining?) and added the following to openseadragon-tests.ts. Based on the other modules in Definitely Typed, this seemed sufficient, but happy to add more if that's preferable:
import Viewer, { Drawer, Viewport, MouseTracker } from 'openseadragon';

const viewer = new Viewer({ id: "viewerid" });

const viewport = new Viewport({ margins: {} });

const element = new Element();

const drawer = new Drawer({ viewer, viewport, element });

const mouseTracker = new MouseTracker({ element });

Thanks @kristinruben, I just gave you collaboration permissions.

Hey, thanks for you efforts! How does it currently look regarding types?
I'm manually creating some of the most important interfaces right now and would be super happy if I could get rid of them at some point.

I actually made a PR to DefinitelyTyped a while ago so that hopefully one day we can install the types using
npm install @types/openseadragon
Unfortunately my PR seems to be stuck waiting for the first reviewer to check it again, and I have not been able to catch his/her attention.
@iangilman, as a library maintainer, maybe you could drop by the PR comments and say something? 😅

Thanks for the quick reply!
I read the comments inside of the PR you mentioned. As @RyanCavanaugh still gets mentioned as "was requested for review", it seems not correct. I don't know, but perhaps the PR state of "Changes requested" prevents the initial mentioned reviewer to get informed/have a look at it again. 5 weeks since your last adjustment seem to be quite a long time for a review. Your initial pull request was reviewed within 3 days. So I guess somebody wasn't notified and as the state of the PR is "Changes requested", they still wait for changes. So it could be a good old deadlock...
However, amazing work! I just hope they move on with this.

I just realized they merged your pull request. So sweet! Do you know how this will progress from here? How will the types enter NPM?

It's supposedly to be done automatically by DefinitelyTyped, I think. But I just checked and it's not yet listed in the npm registry... no idea why.

Ok, i'ts already been published: https://www.npmjs.com/package/@types/openseadragon
It still doesn't appear on search results, though. I guess they have some sort of cache.

Super nice!
Thank you very much for your amazing work and all the instant responses!

@alvaromartmart yes, thank you for making this happen!
Should we list information about the types somewhere on the OpenSeadragon site so people who need them can more easily find them?
Also, what happens in the future when new features are added to OpenSeadragon… Should there be a process for updating the types?

@alvaromartmart thank you for making a PR with the installation instructions; I'll get that deployed soon.
Any thoughts on how we should maintain the types going forward?
I'm working with @Dan503 on an OpenSeadragon-based comic viewer using TypeScript, and he had a few bits he needed to add to our local copy of the definitions. You can see those changes here:
https://github.com/pixfabrik/driftory-viewer/pull/5/commits/350b5560a363b76707ceb0c273bc04b134702dbe
Does that seem like a reasonable change to make to the "official" version? How do we go about that? A new PR on https://github.com/DefinitelyTyped/DefinitelyTyped?

Does that seem like a reasonable change to make to the "official" version?

The exact change I made was more of a quick hack to just do the bare minimum to get my copy working so it could probably be better. I don't have enough seadragon or typescript knowledge to do a quality fix. The types in the official version should get fixed though.

How do we go about that? A new PR

Personally I think it would be easier to just manually maintain a local .d.ts file as part of this repository rather than make PRs against the @types library.
It would automatically get downloaded when users npm install OpenSeadragon.
Also, if you ever make changes to the API, updating the types is as simple as updating the local file as part of the API changes. No need to make a PR against a third party repository that you don't have control over.

Personally I think it would be easier to just manually maintain a local .d.ts file as part of this repository rather than make PRs against the @types library.

That does sound appealing! I don't know enough about the TypeScript ecosystem to know if that's a common scenario. @alvaromartmart any thoughts on that?

Yes, I think that would be much better than having to keep the types at DefinitelyTyped in sync (specially considering that OpenSeadragon releases patch versions, and DefinitelyTyped only considers minor versions in order to determine which types correspond to the library version ).

@alvaromartmart (and anyone else here interested) maybe it's time to revisit moving the TypeScript definitions into this repository? With the recent 5.0.0 release, there are new APIs to provide types for (for example), and at any rate, DefinitelyTyped versions have already drifted out of sync.

Be aware that the DefinitelyTyped library was built for the purpose of giving developers a way to define types for old JS libraries that have either been abandoned or the maintainers of the library have no interest in adding TS types to the list of their responsibilities.
If the maintainers of this library are happy to add maintaining TS types to the list of their responsibilities, then it makes the most sense for the .d.ts files to be added directly to this repo. The maintainers of this library should not maintain the types for their own library through DefinitelyTyped.

I have my own fork of the definitelytyped definitions that I have fixed tons of incorrect definitions and added lots of the new stuff. I use it in my projects, but it turned into such a big task I haven't been able to finish and publish it to definitely typed yet

Also, as a maintainer, I am very interested in maintaining this 😄

It's been a while now since I last used Openseadragon and honestly I don't have the time to contribute to the project nowadays but just wanted to give my 👍🏻 to moving away from DefinitelyTyped and include ts definitions in this repo, I think it makes total sense and will ensure better DX and avoid the challenges of keeping versions in sync. My only concern is that I never got to find a proper way of supporting plugins as I mentioned here but you folks will probably figure it out as you're more familiar with the codebase 🙂 .

@Dan503 Thank you for the perspective... That makes a lot of sense.
@msalsbery Awesome... I guess a good start would be for you to add that definition file here in a PR. It doesn't have to be perfect, just better than what's on DefinitelyTyped. Then we can continue to refine it.
@alvaromartmart Totally understood on your availability. Thank you for getting the ball rolling in the first place! What's your concern with plugins? I guess I'm not sure how they would be affected by type definitions.


Support for Angular 6

Added support for Angular support 6 - updated the use of RXJS files.
Updated project to use the new angular cli.
Bump the version number of ngx-responsive to 6.0.0 to follow the version numbers of angular

Thanks @tocDK !! Conflicts resolved. Merge with master branch.


Grace branch - Add Slider

Hackathon Git Labs Project PR 🎉🎉
👉 Please remove the below and replace with your own values, leaving the headers where they are. 👈
PR contains:

Added a small JS slider of mockups of my projects and re-did some of the CSS grid so layout would be nicer.

Hacktoberfest 2022:

[ ] Does this PR follow the intermediate.md guide and submitted as part of Hacktoberfest 2022?

Please note, we cannot accept basic.md PR submissions for Hacktoberfest, it must be a custom HTML or CSS creation following the intermediate.md guide.

IF YOU HAVE NO SCREENSHOTS, ENTER 'None'

Also added a banner, footer and redid the grid...again


undo call{T}(::Type{Node{T}}, x) deprecation

This undoes the deprecation introduced in #65 for call{T}(::Type{Node{T}}, x). AFAIK it wasn't an issue with syntax as much as the difficulty of finding the right Base.call (arggghh type invariance!).

Is there a way to keep Signal(T, value) working?
I think this is consistent with the Julia convention, e.g. Array(T, 10) etc.

Yes, I can do that. Since 0.4 Array{T}(10) has been supported with call, so it is helpful to have both I guess.

I lost some motivation rebasing for the Signal rename, so I just removed the deprecation and added constructor tests. This makes the patch much smaller.

Bump.