feat(vite): enable usage of function as library fileName (#3585)

Description
This PR would enable users of the library mode to use a function to define the output filename. (As discussed in #3585)
I didn't see existing tests in this area, but maybe I missed it, glad to add some if required.

What is the purpose of this pull request?

[ ] Bug fix
[x] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the Commit Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[x] Ideally, include relevant tests that fail without this PR but pass with it.

Changed the existing lib tests within the playground package

I just wonder: don't we have a test only for fileName: string?
May I ask you to cover all three possibilities. 🙂
This would prevent regression in the future and stabilize this feature 🙂

I just wonder: don't we have a test only for fileName: string?
May I ask you to cover all three possibilities.
This would prevent regression in the future and stabilize this feature

Yeah would be a good idea, I didn't get it to work without creating multiple playgrounds though :thinking:
Would that be a problem? Or do you have any pointers on how to do it without creating more playgrounds?

Maybe you can extract the logic and create a unit-test for it 🤔
You can orient yourself on the __tests__ folder in packages/vite/src/node/__tests__ and create one for client
Then the playground test is enough for the integration test and then the unit test covers the rest 🙂

Ok, I gave it a shot with the unit tests

I think we need a "exclude": ["**/__tests__"] in .../client/tsconfig.json like in .../node/tsconfig.json
Also I don't see the running test in the checks 🤔
I see some for src/node https://github.com/vitejs/vite/pull/3625/checks?check_run_id=2727359038#step:10:14
These unit tests are only in test-serve. @patak-js Do you know a bit more about this and how we configure them for src/client?

Yeah, it should be fixed now


errors with Phoneword

Hi, I have a new installation of Visual Studio Community 2017 for Mac
Version 7.6.10 (build 27).
I entered the code on this page. When I build I get two errors:
-MainPage.xaml.cs(17,32,17,51): error CS0103: The name 'PhonewordTranslator' does not exist in the current context
-MainPage.xaml.cs(38,52,38,59): error CS0246: The type or namespace name 'IDialer' could not be found (are you missing a using directive or an assembly reference?)
I'm new to this. This is my very first app and I'm lost. Please help.
Thank you

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2de3e72c-8948-4dd5-e37f-9cf81e62c127
Version Independent ID: 7b7c5c7f-4102-8e91-fbe6-7d21fcc8f5be
Content: Xamarin.Forms Quickstart - Xamarin
Content Source: docs/xamarin-forms/get-started/hello-xamarin-forms/quickstart.md
Product: xamarin
GitHub Login: @davidbritch
Microsoft Alias: dabritch

Hi @jlt911
It looks like you've missed step 11 (to create the PhonewordTranslator) and step 14 (to create IDialer).
If in doubt, look at the fully working sample that's linked from the bottom of the document (in the Related Links section).


Error creating project 				Oops; flutter has exited unexpectedly. 				Crash report written to C:\Users\Kathirvel\FlutterProjects\flutter_03.log; 				please let us know at https://github.com/flutter/flutter/issues.

flutter_03.log
please help

Hi @kathir-6tz
Looks like you've very old version of Flutter installed
Please execute flutter upgrade --force to latest stable and execute flutter doctor -v
and try creating new project.
Closing, as this isn't an issue with Flutter itself,
if you disagree please write in the comments and I will reopen it
Thank you


added testimonial-8 blue.

Here is the component I have built.

this pull request will closes #1830 under JWOC.

@RavindraP04 i think now it is very much similar to the figma disgn and i have also removed the previous code as well.

updated


Dockerized the application

A bit late on this buddy!
There's already an open pull request on the same topic!


Issues getting nix to work in general and specifically on an M1

Just loaded nix onto a brand new M1 mac mini. Literally the first thing I did. It was a very complicated install process.
My background with nix is a pitch of it at work that tanked due to massive ease of use issues, and a bad reputation of being difficult to learn when people spoke with their social network. I still respect the goal of a platform-independent package manager / build tool. So my goal here is to identify the rough edges so they can be smoothed out.
Here's an exhaustively detailed journal:
I first went to the download page. It told me:
curl -L https://nixos.org/nix/install | sh

https://nixos.org/download.html
Well, I was pretty sure that wouldn't work, but I ran it anyway. Of course it didn't, it told me I needed to use darwin-unencrypted command line flag. I also wanted better sandboxing, so I added on --daemon. That gave me this:
      Alright! We have our first nix at /nix/store/kanh3awpf370pxfnjfvkh2m343wr3hj0-nix-2.3.9

---- sudo execution ------------------------------------------------------------
I am executing:

    $ sudo /nix/store/kanh3awpf370pxfnjfvkh2m343wr3hj0-nix-2.3.9/bin/nix-store --load-db

to load data for the first time in to the Nix Database

sudo: unable to execute /nix/store/kanh3awpf370pxfnjfvkh2m343wr3hj0-nix-2.3.9/bin/nix-store: Bad CPU type in executable

---- oh no! --------------------------------------------------------------------
Jeeze, something went wrong. If you can take all the output and open
an issue, we'd love to fix the problem so nobody else has this issue.

:(

We'd love to help if you need it.

If you can, open an issue at https://github.com/nixos/nix/issues

Or feel free to contact the team,
 - on IRC #nixos on irc.freenode.net
 - on twitter @nixos_org

At first I assumed that this was due to the install script being out of date. So I tried curl directly from install.in in master, then I tried installing the dev tools and cloning the entire repo. IIRC trying to run install.in I got a message about rosetta.
So:
softwareupdate --install-rosetta

Then I reran the install script using the vanilla URL again, since I'd seen the install instructions from angerman:
sh <(curl -L https://nixos.org/nix/install) --darwin-use-unencrypted-nix-store-volume --daemon

https://gist.github.com/angerman/cbe02d814d81a8e4d4ced56b19046c19
Well, the next problem was that the original install hadn't cleaned up. I got this message:
---- oh no! --------------------------------------------------------------------
There are some relics of a previous installation of Nix at /nix, and
this scripts assumes Nix is _not_ yet installed. Please delete the old
Nix installation and start again.

Uninstalling nix:
1. Delete the files Nix added to your system:

  sudo rm -rf /etc/nix /nix /var/root/.nix-profile /var/root/.nix-defexpr /var/root/.nix-channels /Users/spease/.nix-profile /Users/spease/.nix-defexpr /Users/spease/.nix-channels

and that is it.

So I gave that a shot:
$ sudo rm -rf /etc/nix /nix /var/root/.nix-profile /var/root/.nix-defexpr /var/root/.nix-channels /Users/spease/.nix-profile /Users/spease/.nix-defexpr /Users/spease/.nix-channels
Password:
rm: /nix/.Spotlight-V100: Operation not permitted
rm: /nix/.Trashes: Operation not permitted
rm: /nix: Resource busy

Fortunately I had been through the pain of uninstalling things before and recognized that I needed to do something with /etc/synthetic.conf, and that the above instructions are incomplete. After some googling, I found this:
  1. Remove the entry from fstab using 'sudo vifs'
  2. Destroy the data volume using 'diskutil apfs deleteVolume'
  3. Remove the 'nix' line from /etc/synthetic.conf or the file

https://discourse.nixos.org/t/help-fixing-macos-catalina-install/7900
After figuring out how to "Destroy the data volume using 'diskutil apfs deleteVolume'":
$ diskutil apfs list
$ diskutil apfs deleteVolume 77F2FD3B-879C-47CB-91C2-4EF4E4C121B6

and following the other instructions, I was able to install successfully.
Next I installed nix-darwin via the instructions:
nix-build https://github.com/LnL7/nix-darwin/archive/master.tar.gz -A installer
./result/bin/darwin-installer

Here I ran into:
error: not linking environment.etc."nix/nix.conf" because /etc/nix/nix.conf already exists, skipping...
existing file has unknown content ff08c12813680da98c4240328f828647b67a65ba7aa89c022bd8072cba862cf1, move and activate again to apply

https://github.com/LnL7/nix-darwin/issues/149
and more critically
error: file ‘darwin’ was not found in the Nix search path (add it using $NIX_PATH or -I)

https://github.com/LnL7/nix-darwin/issues/40
After manually setting NIX_PATH to
nixpkgs=/nix/var/nix/profiles/per-user/root/channels/nixpkgs:/nix/var/nix/profiles/per-user/root/channels

I could finally do a darwin-rebuild switch, and install Firefox, so I could post this message!
However I still haven't figured out why I have to manually set the NIX_PATH.
It's probably perfectly obvious, but most users would get stuck and give up, or if they hadn't had prior experience with these sorts of failures, could end up spending hours. Especially if they have no clue about nix concepts and are just getting started.
Concrete suggestions

Install script should default to using the unencrypted option if it needs to
Install script should maybe default to daemon - I believe there's some discussion about this in another ticket
Uninstall instructions should be updated to include the unencrypted option
Install should be able to uninstall, unless this is dangerous (I've been embarassed telling someone that there's no uninstall, and the incomplete uninstall instructions are even less flattering)
Rosetta detection for an absolutely clean system could possibly be improved (maybe it already is and that install.in just hasn't hit the web site though)

All that being said, things do seem to be working, and it's probably just a matter of time before I solve the NIX_PATH thing and have it functioning normally.
Thanks for getting it ported this far.

Just annotating these for passers-by:

Concrete suggestions

Install script should default to using the unencrypted option if it needs to

It will after nixos/nix#4289.

Install script should maybe default to daemon - I believe there's some discussion about this in another ticket

It will after nixos/nix#4289.

Uninstall instructions should be updated to include the unencrypted option

Discussed in https://github.com/NixOS/nixos-homepage/issues/639 (but probably mooted by the next one).

Install should be able to uninstall, unless this is dangerous (I've been embarassed telling someone that there's no uninstall, and the incomplete uninstall instructions are even less flattering)

I think this will be tractable after nixos/nix#4289 (which will add what the installer needs to remove the darwin-specific components--and introduces patterns for a more general uninstall--but it'll need some work to round out a full uninstall, support Linux-specific things, etc.)

Rosetta detection for an absolutely clean system could possibly be improved (maybe it already is and that install.in just hasn't hit the web site though)

AFAIK this is fixed in NixOS/nix#4305 (which you correctly guess is not yet released).

This is a NixOS/Nix issue, not a NixOS/nixpkgs issue.


Discourage date() in favor of gmdate()

Is your feature request related to a problem?
WordPress core sets PHP time zone to UTC during boot. However it cannot guarantee that timezone isn't changed by third party code, which is relatively common in the wild.
date() calls rely on current PHP time zone. If time zone is changed from UTC it causes invalid results through the core and extensions code.
Describe the solution you'd like
date() function should be discouraged in favor of gmdate(), which is functionally equivalent, but always operates in UTC and is not affected by runtime time zone changes.
Additional context
WordPress core code had been recently switched from date() to gmdate(), see #46438

Loosely related to #739

Oops... forgot to mention I opened a PR for this #1714 - @Rarst could you have a look to see if that's in line with your ideas ?

Looks good to me. Note that core still has few lingering uses of date(), in third party-ish parts. Don't know if there is automated testing being done in core that would trip over it.

Thanks for having a look.
Third party libraries in core are excluded from the WPCS check, so that shouldn't be a problem: https://core.trac.wordpress.org/browser/trunk/phpcs.xml.dist#L78

Ok, so I've just ran into a bug caused by changing a call to date() to gmdate().
When working with hard-coded times, like when creating a time dropdown, date() should be used over gmdate().
For an example of what I mean, see: https://3v4l.org/MaDQ5
With this in mind, I think we should downgrade it from an error to a warning as "blindly" changing the function call over can have unintended consequences.

You are using date_default_timezone_set(), that should not happen in WP environment.
WP core code should never do this. Extension code might, but it's a bad idea (for the WP context) and it's on them to justify using date() in that case.

@Rarst Of course date_default_timezone_set() shouldn't be used, but isn't that the whole point ?
Using gmdate() instead of date() hardens WP against those situation when it is used. Except that in a limited set of circumstances this may have an undesired side-effect.

Maybe I am not following your point? Could you please elaborate on what do you think bug is?
Because gmdate() behaving differently from date() if you change time zone from UTC is the feature here.

Because gmdate() behaving differently from date() if you change time zone from UTC is the feature here.

But it's also the reason for the bug when using hard-coded time values.
There are two things I can think of here to mitigate it:

Downgrade the error to a warning and possibly adjust the message to make it clearer that the advise cannot be followed blindly.
Add additional logic to the sniff trying to determine if a hard-coded date/time is being passed.
To be fair, I highly doubt that will be very effective as even with a drop-down as per the example above, the time passed is variable as it is created via a loop.

What do you think ?

As above I don't understand what are you calling a bug here.
If you rely on combination of date() and date_default_timezone_set() to produce somethings that is just doing two things wrong, which sort of to add up to "correct-ish" result (that is precisely what we are trying to get rid off in core and beyond).
The actual correct results is to sniff out and do neither of the two.

I'm going to close this issue for now as the original request from the OP has been addressed.
Bugs against this sniff or requests to make it more intelligent should be opened as a new issue.


[Video Conference Mute] Show explanation about how to use the PowerToys Camera in settings

Seems that a lot of users are confused about selecting the PowerToys Camera as their camera input. Would be nice to show this within the Video Conference Settings (or part as OOBE).
Maybe something like this could work.. or within a tooltip next to the Camera header.

If you'd like to see this feature implemented, add a 👍 reaction to this post.

@niels9001
I would write the text in black. It's not a warning, error or description why a setting is disabled.

@niels9001 Seems simple to do and with fair reason. Also requested for in #14522


ad more quota attributes

Description
Add more quota attributes.
restricted -> the fixed value for a quota limit.
isRestricted -> boolean  if the maximum avatilable quota has been set. This parameter can be used in PATCH, POST Requests to remove a quota restriction.
@C0rby @butonic @felix-schwarz @JammingBen @TheOneRing

let me change my proposal

ok, i agree. We need to fix the total quota in reva.

IMO quota has nothing to do with the actual free bytes.

I agree. Please keep those separate. If the physical storage is full, you cannot upload more and will see errors but this is independent of the quota a user has. Storage needs separate monitoring.


[Peek] Peek Window Size Issue

Microsoft PowerToys version
0.70.0
Installation method
PowerToys auto-update
Running as admin
No
Area(s) with issue?
Peek
Steps to reproduce

Enable Peek
In File Explorer, peek a .zip file

✔ Expected Behavior
Allow the window size to adjust according to the content. Also we can shrink the icon size for a bit if necessary.
Also currently the window allows resizing but the new size will not be memorized..
❌ Actual Behavior

Texts are pushed aside and forced to overflow by the giant icon that doesn't actually help.
Other Software
No response

Hello and thanks for your message. What are your display settings? (Resolution and scaling)

Hello and thanks for your message. What are your display settings? (Resolution and scaling)

3840 x 2160, 175%

Seems fixed in 0.70.1


[BUG] Node duplicate display when it back online

Describe the bug
Previous status of certain Node still shown when it back online.
To Reproduce
Steps to reproduce the behavior:

install Harvester with 3+ nodes
reboot specific Node (for example, Node1)
Wait until its state changed to In Progress, then boot back to OS
the Node back online, but old one still here.

Expected behavior
Old state column should be eliminated.
Environment:

Harvester ISO version: master-82506f55-head
Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630): Baremetal DL360 3nodes

Additional context
[on joining]

[after joined]

Cannot reproduce on KVM for 3 node clusters. @lanfon72 if you haven't stepped into this issue, feel free to close it. Thanks.

Close as I didn't hit this bug recent two weeks.


Documentation Error

[Enter feedback here]
Documentation error on page:
https://docs.microsoft.com/en-us/sharepoint/dev/declarative-customization/column-formatting
Incorrect content:
getMonth: returns the month in the specified date according to local time, as a zero-based value (where zero indicates the first month of the year). - Only available in SharePoint Online
"txtContent":"=getMonth(Date('12/26/1981'))" results in 11
Correct content:
getMonth: returns the month in the specified date according to local time, as a zero-based value (where zero indicates the first month of the year). - Only available in SharePoint Online
"txtContent":"=getMonth(Date('12/26/1981'))" results in 12

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f60068c3-4534-a400-350b-fdbcefd684b6
Version Independent ID: 228accdb-a7de-0671-34ad-60a37866c380
Content: Use column formatting to customize SharePoint
Content Source: docs/declarative-customization/column-formatting.md
Product: sharepoint
GitHub Login: @VesaJuvonen
Microsoft Alias: vesaj

There should be no problem with this part of the content. The month retrieved here starts from 0, so 11 represents December.

There is a similar method in JavaScript:Date.prototype.getMonth()

Amos Wu
Microsoft SharePoint Community Support


Custom control flow

Hi,
I am trying to write user space device drivers using Monifu.
I have a USB port exposed as an Observable and Subscriber for reading and writing bits, similar to a Scalaz Exchange.
The driver must sequence requests sent to the device, that is, once a request is written to the device, the next one should be written only after a response is received. Furthermore, if a response is not received within a specified timeout, the first request must be retried.
I do not want to add this sequencing logic in the client. A client should be able to send any number of requests and the driver should sequence it appropriately.
Are there any examples for such custom processing? Any help will be much appreciated.

For posterity, I was able to solve the problem by updating the driver state defined as (last: Option[Request], queue: Queue[Request]) atomically. The state was updated when either a request or response was received.
Requests were written and scheduled for retry only when last is non empty. Note that this needs to be performed during response processing also.

@ajaychandran sorry for not helping you out with this. I haven't received the GitHub notification, saw your question later, postponed it, then forgot about it :-)
BTW, I would model the business logic itself by means of the scan operator, so I would keep a case class State(Option[Request], queue: Queue[Request]) as the accumulator of scan.

@alexandru No problems. The time spent in coming with the solution led to a deeper understanding of the library and the problem.
The operator scan would not work in this case since both the observable and observer need to update the state atomically.
A USB port is modeled as a Subject[BitVector, BitVector].
The driver transforms a port (by piping a codec at both ends) into a Subject[O, I] where O/I are output/input device messages. These unidirectional streams (write and read) need to coordinate using the atomic state (Option[O], Queue[O]) to achieve sequencing and retry.
PS: Thanks for creating this library. It is much easier to follow (IMO) than the competition and handles terminal conditions correctly*.

There is a problem with monifu.concurrent.cancelables.RefCountCancelable (as of version 1.0). Executing the block below does not print anything.

  val ref = RefCountCancelable(println("completed"))
  Seq.fill(10)(ref.acquire()).foreach(_.cancel())

I am using a custom BooleanCancelable. See https://gist.github.com/ajaychandran/c2229a351e5bb68e208f

@ajaychandran the RefCountCancelable example you listed is behaving properly, at least under its current contract. In order for you to be shown a "completed" message, the RefCountCancelable reference itself needs to be canceled.
val ref = RefCountCancelable(println("completed"))
Seq.fill(10)(ref.acquire()).foreach(_.cancel())
ref.cancel() // <-- needs this call to work

You see, by doing ref.cancel() you're in effect saying that "I want to cancel, but only after all child references have been canceled as well". If there are no child references active, then the cancellation is immediate. If there are child references active, then the last child reference to cancel will also trigger the cancellation.

I see now. That seems more reasonable.
Thanks.
PS: The class documentation is not clear on this.

@ajaychandran thanks, will update the api docs.


Add documentation for additional domains

I created this readme based on https://github.com/davidalger/warden/issues/14
I didn't explicitly test each of the exact commands that I added, but I believe they should work based on running them for different domains locally.

@erikhansen Thanks for this, I was just digging into how to go about doing multi-store subdomain setup with warden.

@erikhansen I can confirm this works. I just tested it. Great work as always my friend.

Thanks for the contribution @erikhansen!

@mandatoryhashtags and @molotovbliss If either of you spend time figuring out how to configure Nginx to route specific domains to specific MAGE_RUN_CODE values, feel free to submit a PR to add that to the documentation. :) I have yet to make time to do that.

@erikhansen What I've done to set those env vars based on domains is add a file at app/etc/stores.php with the following contents:
<?php

use \Magento\Store\Model\StoreManager;
$serverName = isset($_SERVER['HTTP_HOST']) ? $_SERVER['HTTP_HOST'] : null;

switch ($serverName) {
    case 'exampledomain1.clnt.test':
        $runCode = 'examplecode1';
        $runType = 'website';
        break;
    case 'exampledomain2.clnt.test':
        $runCode = 'examplecode2';
        $runType = 'website';
        break;
    default:
        return;
}

if ((!isset($_SERVER[StoreManager::PARAM_RUN_TYPE])
        || !$_SERVER[StoreManager::PARAM_RUN_TYPE])
    && (!isset($_SERVER[StoreManager::PARAM_RUN_CODE])
        || !$_SERVER[StoreManager::PARAM_RUN_CODE])
) {
    $_SERVER[StoreManager::PARAM_RUN_CODE] = $runCode;
    $_SERVER[StoreManager::PARAM_RUN_TYPE] = $runType;
}

Then in composer.json add this to list of files which are auto loaded:
{
    "autoload": {
        "files": [
            "app/etc/stores.php"
        ]
    }
}

This is similar to using magento-vars.php on Magento Commerce Cloud, but using composer to load the file:
https://devdocs.magento.com/guides/v2.3/cloud/project/project-multi-sites.html

@davidalger Great, thanks. Want me to submit a PR to add this to the readme? If you don't think it belongs embedded in the readme, I could link to your comment from the readme?

@davidalger would you say that the stores.php include is production-safe? I get that Magento Cloud is using a similar approach, but I'm not sure it's clear to developers who will commit changes to composer.json that running composer install from that state during a build will generate an autoloader which runs this file.
And therefore, they must decide whether to manage run codes here, or in the traditional host/vhost configuration for their web services, across environments.

@vbuck I would consider this production safe. My personal preference is to enforce and specify these codes via an Nginx map in production environments, but I've seen a similar file to the above used successfully in production on some large scale projects for routing of the production names. I have high-traffic projects running an almost near copy of the above for local dev, but utilizing map on production for routing with no issues encountered.
As-written the example above should not impact execution unless the switch case matches a host name, falling back to a simple return doing effectively nothing. With OpCache enabled and used on production, the performance impact of this will be no more than a few additional CPU instructions to execute the switch. If you wanted to use the stores.php file for production configuration as well, simply add the hostnames to the switch case.
Why I like this for local development use is because it allows configuring the environment for multiple hostnames without requiring a developer to customize Nginx configuration (which in context of Warden, would require mounting a config file into the container, and be more configuration heavy).
It's not documented in an issue yet, but Warden 0.2.0 will essentially make the above file the only configuration required for multi-domain to work as long as sub-domains of the same domain (i.e. sub1.clnt.test and sub2.clnt.test are used vs site1.test and site2.test):

Added native support for multi-domain projects without requiring per-project routing configuration. This is accomplished using wildcard rules in the new Traefik labeling configuration allowing Warden to automatically route any sub-domain of the TRAEFIK_DOMAIN value in .env to the nginx and/or varnish container for handling by the application.

Great, thanks for weighing in on it. It makes sense to run it this way, but as an extension to #37 it would still be good to see some documentation about how this could affect/benefit projects in production.

@davidalger , I followed your documentation about multiple domains, but somehow it does not work in my case.
So I have two urls, which I want to handle in the app/etc/stores.php like you advised.
Let's call them app.base.test and app.alternative.test.
base is my WARDEN_ENV_NAME.
My warden-env.yml now looks like this:
version: "3.5"
services:
  varnish:
    labels:
      - traefik.http.routers.${WARDEN_ENV_NAME}-varnish.rule=
        HostRegexp(`{subdomain:.+}.${TRAEFIK_DOMAIN}`)
        || Host(`${TRAEFIK_DOMAIN}`)
        || HostRegexp(`{subdomain:.+}.alternative.test`)
        || Host(`alternative.test`)
  nginx:
    labels:
      - traefik.http.routers.${WARDEN_ENV_NAME}-nginx.rule=
        HostRegexp(`{subdomain:.+}.${TRAEFIK_DOMAIN}`)
        || Host(`${TRAEFIK_DOMAIN}`)
        || HostRegexp(`{subdomain:.+}.alternative.test`)
        || Host(`alternative.test`)
  php-fpm:
    extra_hosts:
      - alternative.test:${TRAEFIK_ADDRESS:-<IP_ADDRESS>}
      - sub1.alternative.test:${TRAEFIK_ADDRESS:-<IP_ADDRESS>}

  php-debug:
    extra_hosts:
      - alternative.test:${TRAEFIK_ADDRESS:-<IP_ADDRESS>}
      - sub1.alternative.test:${TRAEFIK_ADDRESS:-<IP_ADDRESS>}

Now I try to handle the requests from the two domains differently in my app/etc/stores.php using $_SERVER['HTTP_HOST'].
Unfortunately the host is always app.base.test, no matter which URL I initially call.
So any calls to app.alternative.test are directly redirected and as soon as I reach my stores.php I have no option to find out which URL was initially called.
So I expect something to be wrong in my warden-env.yml. Could you shortly give me a hint what I do wrong?


Remove console.error from server

Logging NotFound errors are Plone' stuff and responsibility, because it's not Volto's responsibility.
This could be useful to debug SSR but it's generating a lot of noise in prod env

@nzambello well, not only NotFound errors are shown. I think it's valuable to log errors in there, if not, you are blind on what happens in the SSR world. I agree that NotFound errors might be useful to be filtered from here.
Could we filter them somehow?

@errorlog endpoint :) so that we can read the ignored exceptions list.

@sneridagh I agree with that. IMO it is valuable to have that.
@tiberiuichim that could be super cool, do we have access to that in some way?
I now used an array with Plone's default for that.


false positive for missing generic arguments when arguments have default type aliases

type GraphQLScalarType<TInternal = any, TExternal = TInternal> = {
}

GraphQLScalarType = {} :: GraphQLScalarType

gives
Generic count mismatch, expected 2, got none.Roblox LSP Diagnostics.(undefined-type)

how do you solve this code ?


chore(platform): update tooltip definition in carbon.yml

thanks for reviewing @metonym , are you able to merge? 🙏🏻 I don't seem to have access


Better bloom blending / bloom rework

Godot version: 3.0.2
This one might be a bit nit-picky but I think it's still worth mentioning:
At the moment, bloom is blended after tonemapping & gamma correction, loosing a lot of its impact (because it's not blended in HDR). On top of that it's mixed using modes that you might find in image editing software (soft light, screen, etc.) but which I consider unfit for the job. One of the downsides is that bloom looks pretty dull and/or causes a lot of overexposure depending on which mode you choose.
The usual, more physically correct (and in my opinion best) approach is using a mix or add operation in linear space before the tonemapping, utilizing the full range of colors.
In pseudo-code, this is what's currently done in the shader:
Color = Tonemap(Color, Whitepoint);
Glow = Tonemap(Glow, Whitepoint);
Color = GammaCorrect(Color);
Glow = GammaCorrect(Glow);
Color = ApplyBloom(Color, Glow, Mode); // mix color with bloom using the selected blending mode

And this is what I'd suggest (being done in pretty much all current gen titles)
Color = mix(Color, Glow, BlendFactor); // blend in LINEAR space for a physically based approach (alternative: additive blending)
Color = Tonemap(Color, Whitepoint); // tonemapping and gamma correction comes last!
Color = GammaCorrect(Color);

And lastly, if the current blending modes are going to stay in the long run, I'd like to suggest some improvements for the "soft light" algorithm which seems unnecessarily complex right now:
It uses a lot of branching which is generally considered bad practise in shaders (see the following link) especialy since it's the default mode. I'd suggest an alternate algorithm which looks similar but doesn't use any branching.

Hi, I understand your concern and it's true that the way Bloom is done is not physically correct. In fact, the way you mention is how I approached it first, but later found it very difficult to tweak and adjust for a specific look, or control cases of excessive bleeding.
However, the decision to do it like this is more for artistic reasons than being physically correct. Current implementation is easier for artists to tweak, which is what the aim of most of Godot rendering is.

That said, doing it linear space should be easy to add as an extra option, if there is a good use case for it.

Thanks for all the info, I'd love to see an optional linear approach.  I wasn't sure if anyone would get it as it's a pretty low-level thing most devs don't get it touch with directly.
I once made a dirty implementation of what I suggested along with one or two additional fixes and it worked pretty much as I wanted it to. That being said I'm also kind of biased since this is the way I've implemented it in applications outside of Godot recently.
The soft light algorithm I posted is based on one that I've written a while ago. It looked pretty much exactly like the one used in GIMP as far as I can tell. I adjusted it a bit so it's not too different from what's currently used.
Anyway, if you need a hand with what I suggested I'm happy to help with shader source code or something. Implementing it into Godot is another thing... I feel like I'd break everything I touch.

It seems I misunderstood this issue when I first read it, but maybe it answers a nagging question I had a look at the TPS demo:

The demo has plenty of lights which glow in this unrealistic saturated way. If you were to make a proper lightsaber or want to achieve better photorealism, that's not how light should look like.
For example, from a render by @CptPotato, this is what I would have expected:

Now I understand that having one or the other would be an artistic choice, but I'd like the possibility for Godot to offer ways to achieve both.

Yeah, so the second screenshot Zylann posted is from my own deferred & forward hybrid renderer.
The bloom is done in HDR (Godot should use a similar approach) and blended in the way I described in the original post. Notice how it looks a lot softer and has a nicer saturation and color falloff. Additionally there is a little saturation trick I'm using to make sure even highly saturated colors "fade to white" when bright enough.
I made a fork and will be trying to implement this (along with fixing #19163, as it's related and in the same shader file) somewhere in the upcoming weeks.

As an artist, I would like to have as precise control about the bloom color mixing as possible. If there are defaults that look good and/or realistic, that's a big plus.
Currently however there is neither really. Almost no intention driven control, and it does not really look realistic either out of the box. Intention driven would mean to be able to pick exactly which color is in the center, what is the gradient of colors fading out from it and having options for how are both blending with the underlying pixels.
Right now all you can do is play around with arbitrary levers and numbers and somehow hope you will end up with a result you like. This can take forever and is really hard to replicate and worst: You cannot aim for a certain look.

I'm fine without having a tint option for the bloom effect but I guess that's just personal preference. To get the most realistic look, use Screen as blending mode and turn down the glow intensity quite a bit (I'm using around 0.05 to 0.10).

While reworking the bloom, some parameters could easily be removed or consolidated.
Intensity, Strength and Bloom all seem to do the same thing. It's possible that they technically do different things, but visually there's no difference between using either of them to tweak the resulting strength of the effect

I also find the actual Glow hard to setup.
The overall feeling with the Godot render system right now is that is a bit hard to setup compare to someting like Eevee
It's good to have control but it's even better when the render help you to go in the right direction.
For exemple, nobody want to see someting like the "Blender Internal" again and all the hours spend to tweak all the parameters to have good enough renders.
Why not get the inspiration from Eevee's Bloom? It give realistic results and the "Color" parameter can really help to change the mood of a scene.
Is it based on the same render technics that the Glow from Godot?
Maybe that is for an another topic but,
Other stuff would be good to have like Curve for color management that is use a lot to punch the highlights and the shadows  in post prod.
And is the tonemap system working in the right way? The results I have seems less consistent than the Eevee's one.

@RonanZe Glow has been reworked in the master branch, give it a try (if you can build Godot from source).

Nice to hear that!
I have build the master yesterday under linux but it's difficult to test it because I can import an old demo scene (everything is black) and I can't assign the color atlas texture by drag and drop in the editor.
I'll give an other try today with an Eevee scene I'm working on to see the differecences and the improvements in Godot

I've played with the master branch, Godot 3.2 and Eevee today.
Maybe it's better that the old one because everything is compute in the right order.
But for me the Glow seems still diffcult to setup compare to Eevee's Bloom effect.
It's difficult the know which Levels to put on or off to get a good result, what is the difference between Strengh and Intensity and what the HDR stuffs are meaning here.
It would be a good thing to have a Color option like in Eevee (I can give an exemple to show the benefits of it if needed)
And it's buggy atm --> you have a lot of flickering. it's like you dont have the right upscale and that you can see the low res image that is used to create the effect.
I'll do more accurate comparisons between Godot 3.2 and master when I will be able to load again an hdr image in the settings.

And it's buggy atm --> you have a lot of flickering. it's like you dont have the right upscale and that you can see the low res image that is used to create the effect.

Did you enable Bicubic Upscale?

I can't find the option in a fresh master build. Is it in the same place has in 3.2 ?

@RonanZe It was moved to the Project Settings as it's a quality setting. (Godot 4.0 will centralize quality settings there to make them easier to adjust at the same time.)

That said, bicubic upscale is already the default. Can you upload a minimal project with the glow configured? Also, could you record a video and upload it somewhere?

The upscale is on. Here is a video + the project:
2020-05-10 17-08-00.zip
Great-Village.zip
Can you see the flickerings?

Can you see the flickerings?

Yes, but I don't know how to solve them exactly.

That's not an issue with the upscale, it seems the glow is really sensitive to changes in brightness in the original scene. The flickering is caused (from what I could tell when running it) from the little bumps on the battlement combined with the glow being sensitive to changes.
I believe this issue what hdr_luminance and hdr_scale are supposed to fix, but they are having no effect in the test scene, would be worth opening a new issue so this can be investigated.

This should be fixed in the master branch thanks to the Vulkan renderer, closing.
Please create a new bug report for the issues related to oversensitivity to brightness changes in glow.


Fix comment on reinstallation

pip first takes in the command (i.e., install), then options, so --force-reinstall should be at the end. Also, automation should have 2 as, not 3.

Looks great, thanks!

Thank you!


lxc restart hangs when run immediately after lxc launch

Required information

Distribution: NixOS
Distribution version: Unstable
LXD  version: 4.1 (but happens also on 3.18)
The output of lxc info : lxd-info.txt

Issue description
lxc restart hangs when run just after lxc launch.
This should be a low-priority issue as it can be worked around easily (but finding the right delay on a loaded machine can be tricky). However, it may not manifest itself each time depending on the latency between the client and the server, so it can make automation scripts hang in a non-deterministic way.
Restarting just after launch is required in some cases where the inner system only applies some of its configuration at boot, since there is no way to launch a stopped container.
Steps to reproduce

lxc launch images:debian/10 test && sleep 1 && lxc restart test => OK
lxc launch images:debian/10 test && lxc restart test => Hang

Information to attach

[ ] Any relevant kernel output : no relevant output

[X] Container log : lxd-container-log.txt

[X] Container configuration : lxd-container-config.txt

[ ] Main daemon log

[X] Output of the client with --debug : lxd-client-debug.log

[X] Output of the daemon with --debug : lxd-server-debug.log

That's normal. lxc restart sends a signal to the init system in the container, similar to ctrl-alt-del on a physical system.
If the init system hasn't yet setup its logic to detect and respond to that event, nothing will happen.
lxc restart --force should always work as that one doesn't send an event, instead having LXD directly kill everything (causing potential data loss).


ApiVersioning is not working on route using netcore 3.1

Hello folks!
I'm implementing Api Versioning in my NetCore 3 project using package Microsoft.AspNetCore.Mvc.Versioning(4.1.1) but it's throwing me an error if I try to add version into my router - it works fine if I don't pass the route.
Here is what I have done:
using System.Threading.Tasks;
using Microsoft.AspNetCore.Mvc;

namespace Aus.GGG.Company
{
    [Route("v{version:apiVersion}/[controller]")]
    [ApiController]
    [ApiVersion("1.0")]
    public class BaseController : ControllerBase
    {

        [HttpGet("/test.json")]
        public async Task<IActionResult> Get() => Ok("test");
    }
}

That is how I have added my service:
        public static IServiceCollection RegisterExtraStuff(this IServiceCollection services)
        {
            services.AddApiVersioning(config =>
            {
                config.DefaultApiVersion = new ApiVersion(1, 0);
                config.AssumeDefaultVersionWhenUnspecified = true;
                config.ReportApiVersions = true;
            });

            return services;
        }

    }

And here is the curl that doesn't works:
curl --location --request GET 'http://localhost:3000/v1.0/test.json

And the curl that works:
curl --location --request GET 'http://localhost:3000/test.json

In the last curl, I can see the extra header api-supported-versions on response so my configuration looks right, I guess.
Any idea on what is missing?

It was a miss config in my route. I will close the ticket for now.


Name for reader/writer packages

Currently they are called portphp/doctrine, portphp/excel, portphp/pagerfanta and so on. Problem is that this makes them look a bit like forks from official packages like doctrine and pagerfanta. Should we rename the reader/writer packages to:

pagerfanta-plugin
pagerfanta-ship (in metaphor of ports)
pagerfanta-transfer
something else?

And if we choose a suffix, should it be reflected in the namespace as well?

I am against putting the suffix in the namespace. Like we don't put PHP in Port. Package names are one thing (like you said @ddeboer, we want to avoid confusion whether it is a fork or a custom package). Namespaces another.

pagerfanta-adapter?

Yeah, but if for some reasons we have to fork pagerfanta, we can't. I can't imagine too much cases when that would be necessary, but still...

portphp/pagerfanta-extension
portphp/pagerfanta-add-on

I like the name portphp/pagerfanta-adapter. Its clear what the package contains.

:+1:

@Baachi Do you agree this should not be reflected in the namespace?
Port\PagerFantaAdapter\PagerfantaReader
Port\Adapter\Pagerfanta\PagerfantaReader
Port\Pagerfanta\PagerfantaReader

Hell, no. :stuck_out_tongue:
It is mixing up package architecture with code.

Yep a package name and namespaces are different things.

Agreed, I’ll rename the packages.

I don't think the core should support more than one excel adapter, so I think it is fine that way.


Update sources-dist-stable.json: swiss-weather-api

And another "bugfix" in the swiss-weather-api adapter, which caused the change in the SRF API. This version has been tested by several people and seems to be stable now.
Now the adapter is worthy of version 1.0.0 drum roll :)

wwwooohhooooo :-)


Fix a typo in an error message

:+1: you know you really don't need to await/solicit review for obvious typo fixes like this :wink:


no more tasks when requires_local done

hi , I got a question about requires_local
I have two luigi.hadoop.JobTask for map-reduce job, but both two tasks should pull the same data first
as the document said, there is a instance cache for tasks, so I just give the same parameters in the two requires_local, it look like:
def requires_local(self):
return [pull_data.PullData(client=self.client, d
segment_id=self.segment_id,
endpoint=self.endpoint,
start_date=self.pull_start_date,
end_date=self.pull_end_date,
conf_file=self.conf_file,
env=self.env)]
to ensure the pulling action not run twice, or the data should be duplecated. but when I run two tasks meanwhile, it seems not work, one of the tasks always finish directly after scheduled the pullData,  and said "There are no more tasks to run at this time", but the pullData is still in "PENDING" status, why that task didn't wait until the pull task done and run its mr job?
the log:
2015-12-25 06:05:04       Scheduled PullData(client=seg1, segment_id=68, model_id=None,...)(PENDING)
2015-12-25 06:05:04     Running Worker with 1 processes
2015-12-25 06:05:04 luigi-interface INFO           Done
2015-12-25 06:05:04 luigi-interface INFO           There are no more tasks to run at this time
2015-12-25 06:05:04 luigi-interface INFO           PullData(client=seg1, segment_id=68, ....) is currently run by worker Worker(salt=143519565, workers=1, host=hostname, username=hdfs, pid=2300)

I believe you need to enable the worker-keep-alive configuration boolean in order for the second worker to wait for the shared task run by the first worker to complete.
worker-keep-alive
If true, workers will stay alive when they run out of jobs to run, as long as they have some pending job waiting to be run. Defaults to false.

closing this issue.

[x] It has been inactive for +4 months.
[ ] It's not about luigi core, so not as many users are affected about this.
[ ] The change seems quite big, it's unlikely to be sporadically picked up.
[x] The owner haven't responded or disappeared.
[ ] I don't understand what this issue is about.
[ ] There exists a reasonable workaround for this.
[ ] We need to check if this hasn't been fixed by now (for old issues).
[ ] This is kind of by design and not a bug.
[ ] Resolving this would probably add a lot of complexity.

Every open issue adds some clutter, and we try to make the issues fewer and make it easier for new collaborators to find. Currently we try to close any issue that meets the first checkbox + one other.
Feel free to reopen this issue at any point if you have the intent to continue to work this. :)


Examples for authz redelegation are incorrect

Summary of Bug
The usage examples of the authz command are incorrect:
Usage:
  provenanced tx authz grant <grantee> <authorization_type="count"|"send"|"generic"|"delegate"|"unbond"|"redelegate"> --from <granter> [flags]

Version
1.15.0
Steps to Reproduce
Attempt to use the authz grant cli command per above.  Note that the type information is not correct.
The following shoes the correct syntax:
provenanced tx authz grant tp1yrtcht90kvscc796adaj7vhr74295teqa6qsr2 generic \
     --msg-type=/cosmos.staking.v1beta1.MsgBeginRedelegate \
     --from large-hashholder \
     --chain-id pio-mainnet-1 \
     --gas auto --gas-adjustment 1.25 --gas-prices 1905nhash \
     --node=https://rpc.provenance.io:443

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged
[ ] Contributor assigned/self-assigned

@dcshock ^^^


Win2022 image: New "Java SDK 11.0 or above is required" errors when building .csproj targeting Android v12.0

Description
We have multiple .csproj files that target Android 12.0 and our Azure DevOps build pipeline uses the Windows Server 2022 agent pool to build them. After today's image update, our builds began to fail with errors like this:
2023-11-16T20:46:54.6444765Z C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Xamarin\Android\Xamarin.Android.Legacy.targets(254,5): error XA0031: Java SDK 11.0 or above is required when using $(TargetFrameworkVersion) v12.0. [{path to our .csproj file]
2023-11-16T20:46:54.6448075Z C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Xamarin\Android\Xamarin.Android.Legacy.targets(254,5): error XA0031: Download the latest JDK at: https://aka.ms/msopenjdk [{path to our .csproj file]
2023-11-16T20:46:54.6452207Z C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Xamarin\Android\Xamarin.Android.Legacy.targets(254,5): error XA0031: Note: the Android Designer is incompatible with Java SDK 11.0: https://aka.ms/vs2019-and-jdk-11 [{path to our .csproj file]

I have found a workaround -- I added the following JavaToolInstaller step to my pipeline:
- task: JavaToolInstaller@0
  inputs:
    versionSpec: '11'
    jdkArchitectureOption: 'x64'
    jdkSourceOption: 'PreInstalled'

Platforms affected

[X] Azure DevOps
[ ] GitHub Actions - Standard Runners
[ ] GitHub Actions - Larger Runners

Runner images affected

[ ] Ubuntu 20.04
[ ] Ubuntu 22.04
[ ] macOS 11
[ ] macOS 12
[ ] macOS 13
[ ] Windows Server 2019
[X] Windows Server 2022

Image version and build link
20231115.2.0
Is it regression?
20231029.1.0
Expected behavior
The project should build successfully, as it did on image version 20231029.1.0.
Actual behavior
The project now fails to build.
Repro steps
My build pipeline is complex so I can't immediately provide a working example, but below is a trimmed-down example of the kind of project file I'm trying to build using the 'windows-2022' image.
<Project ToolsVersion="4.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
  <PropertyGroup>
    <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
    <Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
    <ProductVersion>8.0.30703</ProductVersion>
    <SchemaVersion>2.0</SchemaVersion>
    <OutputType>Library</OutputType>
    <AppDesignerFolder>Properties</AppDesignerFolder>
    <RootNamespace>Example.Android</RootNamespace>
    <AssemblyName>Example.Android</AssemblyName>
    <FileAlignment>512</FileAlignment>
    <AndroidResgenFile>Resources\Resource.Designer.cs</AndroidResgenFile>
    <GenerateSerializationAssemblies>Off</GenerateSerializationAssemblies>
    <AndroidUseLatestPlatformSdk>false</AndroidUseLatestPlatformSdk>
    <TargetFrameworkVersion>v12.0</TargetFrameworkVersion>
    <NuGetPackageImportStamp>
    </NuGetPackageImportStamp>
    <RestoreProjectStyle>PackageReference</RestoreProjectStyle>
    <LangVersion>10.0</LangVersion>
  </PropertyGroup>
  <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
    <DebugSymbols>true</DebugSymbols>
    <DebugType>full</DebugType>
    <Optimize>false</Optimize>
    <OutputPath>bin\Debug\</OutputPath>
    <DefineConstants>DEBUG;TRACE</DefineConstants>
    <ErrorReport>prompt</ErrorReport>
    <WarningLevel>4</WarningLevel>
  </PropertyGroup>
  <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
    <DebugType>pdbonly</DebugType>
    <Optimize>true</Optimize>
    <OutputPath>bin\Release\</OutputPath>
    <DefineConstants>TRACE</DefineConstants>
    <ErrorReport>prompt</ErrorReport>
    <WarningLevel>4</WarningLevel>
  </PropertyGroup>
  <ItemGroup>
    <Reference Include="Microsoft.CSharp" />
    <Reference Include="Mono.Android" />
    <Reference Include="mscorlib" />
    <Reference Include="System" />
    <Reference Include="System.Core" />
    <Reference Include="System.IO.Compression" />
    <Reference Include="System.Net.Http" />
    <Reference Include="System.Xml.Linq" />
    <Reference Include="System.Xml" />
  </ItemGroup>
  <Import Project="$(MSBuildExtensionsPath)\Xamarin\Android\Xamarin.Android.CSharp.targets" />
</Project>

@dd-eg hey! This is expected behaviour as one should not really rely on the image default and pick the java version they need using the JavaToolInstaller@0 task. That psaid, please continue using the task :)

Thanks for the quick response, much appreciated. Now that I'm reviewing the installed software, I see that the default Java version is 8, so the error makes sense.
Any thoughts as to why our builds were working on the prior image version? We changed the project's target Java framework to v12 about 8 months ago, so I'm surprised we didn't hit the issue earlier.

I guess because VS on windows-2022 got updated recently

This is new behavior that is breaking builds. What is the source of the change? I've been building to Android 13 for a while, and the server hasn't had issue. Did the default JDK version get rolled back on the server or did was there a Java change that previously allowed Android 13 to be built with version 8, but now requires Java version 11?
I am aware of what the fix is and understand that servers upgrade SDK versions over time, but this appears that the server downgraded the installed SDK version.


logseq added support for the logseq protocol (logseq://), we don't have a handler for it

Around this version logseq added support for the logseq protocol (logseq://), shouldn't we have a handler for it?
Something like:
xdg.mime.defaultApplications."x-scheme-handler/logseq" = "logseq.desktop"
Originally posted by @necauqua in https://github.com/NixOS/nixpkgs/issues/179013#issuecomment-1167341924

My comment was probably wrong: it seems that it's enough to have a MimeType=x-scheme-handler/logseq line in the desktop file for xdg-open to pick it up, and upstream desktop file does not have that.
Same thing works fine for discord, for example, without explicitly touching things like xdg.mime.defaultApplications

Closing as an upstream issue (see the link above)

@necauqua in which version was it fixed? I still have the same issue in 0.8.9

@necauqua in which version was it fixed? I still have the same issue in 0.8.9

The fix is in 0.8.11 which is currently in nixos-unstable

I said it will be fixed, someday, because that's an upstream issue with their appimage packer, not a nix-specific one
However I see this was merged https://github.com/logseq/logseq/pull/7219 recently, so the next release probably will actually be fixed

The fix is in 0.8.11 which is currently in nixos-unstable and fixed the issue for me.

oh, this, great


Add animate to bounds on Map from LatLngBounds

Add newLatLngBounds option when creating CameraUpdate, to be similar in GoogleMap.
Please take a look. Thank you.

Thank you for your contribution!


issue with config parsing spaces

Current pipeline (v2.2) did not have any defaults for the modules loaded within the pipeline. As a result when snakemake updated to v 7.19.1, our pipeline used this new version.
Parsing of the config file has changed and an error was seen:
"------------------------------------------------------------------------
*** STARTING DryRun ***
[+] Loading snakemake  7.19.1
run_snakemake.sh: line 559: 1: command not found
run_snakemake.sh: line 63: 1: command not found
ERROR: Output dir provided: /data/RBL_NCI/Wolin/mov10_par_Y_r2_01052023 does not match snakemake_config: . Update and re-run."
This was caused by two lines in the snakemake_config.yaml file
outSJfilterCountTotalMin: "3 1 1 1" #minimum total (multi-mapping+unique) read count per junction for: (1) non-canonical motifs, (2) GT/AG and CT/AC motif, (3) GC/AG and CT/GC motif, (4) AT/AC and GT/AT motif
outSJfilterOverhangMin: "30 12 12 12" #minimum overhang length for splice junctions on both sides for: (1) non-canonical motifs, (2) GT/AG and CT/AC motif, (3) GC/AG and CT/GC motif, (4) AT/AC and GT/AT motif

Solution:

Fix the snakemake_config.yaml file to include commas rather than spaces

outSJfilterCountTotalMin: "3,1,1,1" #minimum total (multi-mapping+unique) read count per junction for: (1) non-canonical motifs, (2) GT/AG and CT/AC motif, (3) GC/AG and CT/GC motif, (4) AT/AC and GT/AT motif
outSJfilterOverhangMin: "30,12,12,12" #minimum overhang length for splice junctions on both sides for: (1) non-canonical motifs, (2) GT/AG and CT/AC motif, (3) GC/AG and CT/GC motif, (4) AT/AC and GT/AT motif

Update the Snakefile to convert these to spaces

star_filt_sjmin = config['outSJfilterCountTotalMin'].replace(",", " ")
star_filt_overhang = config['outSJfilterOverhangMin'].replace(",", " ")

Create a function to control the module loading of each of the packages used within the pipeline

load_modules(){
  if [[ $1 =~ "python" ]]; then module load python/3.8; fi
  if [[ $1 =~ "snakemake" ]]; then module load snakemake/7.19.1; fi
  if [[ $1 =~ "graphviz" ]]; then module load graphviz/2.40; fi
}

Will tag a minor pipeline version and update the /data/RBL_NCI/Pipelines/iCLIP directory location

fixed with commit/merge request https://github.com/RBL-NCI/iCLIP/pull/138


Update world-clock extension

Description
Added UTC time
https://github.com/raycast/extensions/issues/13257
Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

@pernielsentikaer could you please check?


Rule no-tabs

Request for support for this rule: http://eslint.org/docs/rules/no-tabs

It should be very simple to write this rule, so if you wanna contribute with it, feel free :)


When app is in foreground or user is connected and I want notification.Is it possible?

Issue fix.


python3Packages.spacy: 3.2.0 fix

Motivation for this change
the initial Idea was to fix spacy. But all fixes took more work then expected. The update was done by @jonringer.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 153771 run on x86_64-linux 1

12 packages built:

python38Packages.spacy
python38Packages.spacy-loggers
python38Packages.spacy-transformers
python38Packages.textacy
python38Packages.wandb
python38Packages.yaspin
python39Packages.spacy
python39Packages.spacy-loggers
python39Packages.spacy-transformers
python39Packages.textacy
python39Packages.wandb
python39Packages.yaspin

nixpkgs-review successful, macos 10.15 & nixos x86_64

nixpkgs-review successful, macos 10.15 & nixos x86_64

Bump spacy to 3.2.1 please.

because of #138474 i removed the duplicate commits adding yaspin&wandb.

@sikmir & @jonringer anything to add?

spacy broken again on master caused by thinc.


military comparison skips my own empire

The Custom Chart tool silently skips my own empire at military comparison, and then fails to show anything (see screenshot).
The preset Comparison chart military view excludes my own empire.

Good catch, thanks for the report. I'll take a look and see if I can figure out what's going on.


some qol adjustments adds support for epoch training

TRAIN BY EPOCHS not steps!!!! adds the ability to allow the user to gradient steps batch size and change the scheduler, also gives the ability to turn off contains faces inside of the accelerate cell so a new session is not needed. lastley sets warm up steps to 10% of total run

ill b bak


Add elm version to docs sidebar

When fetching elm packages, also gets the elm.json package info.
This is used to show the elm version in the docs sidebar so there is no confusion when getting to package links through google.
I added the package info to the model but I could just scale back to the elm version if it is too much.

#255 (-:

This was and is one of the most annoying features of Elm's package ecosystem for me and seems like a straightforward improvement. I'd really appreciate it if this were released! cc/ @evancz since we talked about this the other day

The elm version required has been added in the "About" section of each package.
A warning is also displayed for packages not compatible with the last Elm version.
For example, see:
https://package.elm-lang.org/packages/elm-lang/websocket/latest/


Remove notifyChangesToDocument as this is no longer necessary

Codecov Report

Merging #14237 into main will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #14237      +/-   ##
==========================================
- Coverage   59.95%   59.93%   -0.03%
==========================================
  Files         706      706
  Lines       39184    39183       -1
  Branches     5681     5681
==========================================
- Hits        23493    23484       -9
- Misses      14454    14459       +5
- Partials     1237     1240       +3

Impacted Files
Coverage Δ

src/client/datascience/notebook/contentProvider.ts
51.16% <ø> (+1.16%)
:arrow_up:

src/client/datascience/notebook/types.ts
100.00% <ø> (ø)

...very/locators/services/virtualenvwrapperLocator.ts
76.92% <0.00%> (-15.39%)
:arrow_down:

src/client/common/utils/platform.ts
60.00% <0.00%> (-12.00%)
:arrow_down:

.../pythonEnvironments/common/externalDependencies.ts
57.57% <0.00%> (-3.04%)
:arrow_down:

src/client/linters/pydocstyle.ts
86.66% <0.00%> (-2.23%)
:arrow_down:

src/client/datascience/debugLocationTracker.ts
76.56% <0.00%> (-1.57%)
:arrow_down:

src/client/common/process/proc.ts
14.49% <0.00%> (-0.73%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 516f5f1...83f3cee. Read the comment docs.


How well energy storage capacity is represented in the dataset?

I am including here a question I have received from Alexander.

Can you give an estimation on how well energy storage capacity is
represented in the dataset? 45 TWh for Norway for instance seem to be a
bit too low, but maybe I am wrong.

This was my answer:

Regarding the storage (and in general to the whole dataset), we have tried to include "as much as possible" but, of course, it wasn't enough to match what we think it should be the 'reality', both for the installed power and reservoir capacity.
Norway, thanks to the NVE data that is the best you can found among the European countries, is quite accurate but however the total storage doesn't match the values in the ENTSO-E TP or the Nord Pool data, which is ~76 TWh. In general, for the reservoir capacity, we rescale all the values we have at national level to match the maximum storage capacity we have from ENTSO-E TP or other source (for example, TERNA for Italian hydro).
For the Norwegian power plants, NVE provides a variable named 'energiEkvivalent_kWh_m3'  which is the energy that can be generated from each m3 of water. Then we multiply this with the volume of the storage in cubic meters to get the maximum storage capacity in GWh. Honestly I don't know why the values do not match but unfortunately right time I do not have the time to investigate those issues.

Dear Matteo,
Im interested in how energy storage capacities are estimated and just wanted to know if you have a link/sorce for the NVE database where they provide the 'energiEkvivalent_kWh_m3' and the volume of storage.
Thanks in advance!

Hi,
I have also looked into it recently and I'll let him correct me if it is wrong but I think he obtained the energy equivalent from the NVE Vannkraftdatabase and the volume from the column "OPPSTRVOL" in the table starting around p.240 in this report.

We use essentially two files: Vannkraft.xlsx and Vannkraft_Magasin.shp, both downloaded from the NVE website. I can't find the URLs to download them by the way so one is here
Vannkraft.xlsx and a zip with the shapefile is here (the link will work only for 7 days).
The size of the storage is taken from the column energiEkvivalent_kWh_m3  of the Excel file and the volume is in the field volOppdemt of the shapefile.

Can I just confirm that the MWh of storage quoted are 'usable' rather than the total in the reservoir? thanks Michael

Yes, I confirm. In all the cases, the reported reservoir capacity (MWh
and/or hm3) is the 'usable' part.
On Sat, Mar 13, 2021 at 11:11 AM mtaylor72 @.***> wrote:

Can I just confirm that the MWh of storage quoted are 'usable' rather than
the total in the reservoir? thanks Michael
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/energy-modelling-toolkit/hydro-power-database/issues/1#issuecomment-798086315,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABQQYASHTXNCUQ42ZJ7JK4TTDM24NANCNFSM4HFDRBIQ
.

--
Matteo

Yes, I confirm. In all the cases, the reported reservoir capacity (MWh and/or hm3) is the 'usable' part.
…
On Sat, Mar 13, 2021 at 11:11 AM mtaylor72 @.***> wrote: Can I just confirm that the MWh of storage quoted are 'usable' rather than the total in the reservoir? thanks Michael — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQQYASHTXNCUQ42ZJ7JK4TTDM24NANCNFSM4HFDRBIQ .
-- Matteo

Thanks for the quick repsonse!

Hi Matteo,
Allow me to follow up on this thread, although it is more than three years since you created it. I am looking at the storage energy capacities (i.e., the 'storage_capacity_MWh' attribute) for pumped-hydro storage in your dataset.
What is in particular of my interest is the plant named 'Villarino VLLRINO 1G - Almendra (Villarino) Hydroelectric Power Plant Spain'. According to your dataset, it has a storage energy capacity of 3.1 TWh and a power capacity of 851 MW. This corresponds to a discharge time (duration) of 3666 hours. As I understand it, this means that - if fully charged - it can discharge at max power capacity (851 MW) for a full year, before running empty. I am not exactly familiar with how the Villarino plant operates, but it seems quite impressive. Is this true, is it a bug, or does it relate to the above disclaimer regarding how well energy storage capacity is represented?
I have furthermore compared your reported cumulative energy capacity of pumped-hydro storage (approximately 11TWh) with a study from 2015 by Geth et al. (https://doi.org/10.1016/j.rser.2015.07.145) who finds it to be one order of magnitude lower (approximately 1.5 TWh). Again, could the discrepancy relate to how well energy storage capacity is represented?
Best regards
Ebbe

Dear @ebbekyhl, yes the Villarino plant is quite impressive: the size of its reservoir is also confirmed in this news https://www.lagacetadesalamanca.es/provincia/viaje-a-las-entranas-de-la-central-de-villarino-CH900206
The paper by Geth et al. is indeed a very good paper, but we think that our collected data might be more accurate because we tried to collect multiple sources for most of the biggest plants.

Thanks for turning back to me and for clarifying, @matteodefelice.

Hi both,
Villarino is one of the hybrid (PHS + reservoir) hydro plants in Spain.
It is mostly used as a reservoir plant (i.e. it shows a seasonal pattern) as shown in the next image
https://www.embalses.net/pantano-71-almendra.html
(It has two official names 'Villarino' and 'Almendra')
I would suggest not considering it a PHS plant since its energy capacity (3TWh) is two orders of magnitude larger than the estimated energy capacity for PHS in Spain (around 72 GWh) and this can introduce significant errors.

Thanks @martavp, this is indeed very interesting. It would be nice to be able to understand how much of this storage is "managed" as bi-directional. I tend to agree with you, probably we are drastically overestimating the PHS capacity in Spain...

Are there plans to fix this?
I think other datasets (powerplantmatching) are correcting for the Spain issue...
Or perhaps this is an old problem that is already fixed?

Hi everyone,
May I ask you to open an issue on Github and propose a solution? I think
it's worth keeping track of this kind of discussions.
Would you suggest splitting in two? Or just classifying it as a reservoir?
Let's continue there, what do you think?
On Wed, Aug 14, 2024 at 10:20 AM Ivan Ruiz Manuel @.***>
wrote:

Are there plans to fix this?
I think other datasets (powerplantmatching) are correcting for the Spain
issue...
Or perhaps this is an old problem that is already fixed?
—
Reply to this email directly, view it on GitHub
https://github.com/energy-modelling-toolkit/hydro-power-database/issues/1#issuecomment-2288132505,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABQQYAWZJ75Q7KKZNV4DOZLZRMHLVAVCNFSM6AAAAABMP2FUOOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBYGEZTENJQGU
.
You are receiving this because you were mentioned.Message ID:
@.***
com>

--
Matteo


Pdf download of dashboard

Is it possible to download the pdf version of the dashboard created? i think it would be useful to export and be able to print the canvas.

No, I don't know if that's feasible. I am aware that certain packages enable the conversion of widgets for exportation to PDF format; however, these products necessitate the importation of widgets directly from the package. It won't actually be feasible because of the intricacy and the need for unique paint objects, among other things.
As a solution, though, I could recommend using a plugin that lets you take a photo or picture of a specific widget and use it to generate a PDF. Again, though, I haven't personally tested it, so this is just a possibility.

No I said you could try to do it
outside the package

I've tried with the screenshot package in order to get an image and then convert it to pdf.
The problem is that it doesn't get the entire screen even if some components are hidden, if i try to scale down the elements are too small to be seen and then a screen aspect ratio could be different from an A4 pdf.
Any idea to get the whole content of the dashboard and fit the pdf content?
Thank you

You can try to use Capturing Widgets that are not in the widget tree and give it a Dashboard larger than the device screen.
I close this issue since the capture Dashboard feature is not (yet) planned.

Already tried, when passing FlowChart Widget as parameter:
The following assertion was thrown building Draggable<FlowElement>(dirty, state: _DraggableState<FlowElement>#bd279):
No Overlay widget found.

Draggable<FlowElement> widgets require an Overlay widget ancestor within the closest LookupBoundary.
An overlay lets widgets float on top of other widget children.

To introduce an Overlay widget, you can either directly include one, or use a widget that contains an Overlay itself, such as a Navigator, WidgetApp, MaterialApp, or CupertinoApp.

tried then to wrap in a MaterialApp widget but leds to another error.
I'm not getting if i'm doing something wrong with your widget.


neohtop: init at 1.0.8

NeoHtop is a new cross-platform desktop application for system monitoring.
It was released recently and has already gotten quite a bit of attention, including requests for it to be packaged.
Close #354007
I have pretty much just followed the approach of Hoppscotch, as they are both Tauri applications and they should function similarly.
I would also appreciate feedback on darwin, as I have no way to test that myself.
This is my first time contributing, so I appreciate any and all feedback.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Please include word fix/close before issue mention to close it automatically on merge

If possible, I think it would be better if it's built from source via cargo-tauri.hook — repacking binary artifacts from upstream should only be used for closed-source packages or as a last resort (e.g. exceedingly complicated compilation/circular dependencies/bootstrapping issues)

Been messing around with it for a couple of hours now and I don't think I can progress further or build it from source as is (although this is likely a skill issue).
NeoHtop is a tauri v2 application, but cargo-tauri for the time being is still in v1 (waiting on #346277).
I have tried overwriting the version of tauri in cargo-tauri similar to this but I have been unsuccessful and get some errors from the tauri derivation that I do not know how to get around.
So unless someone else wants to take a crack at it, I will probably not be able to progress further till cargo-tauri is updated to v2.
Should I move my PR to a draft for the time being?

I think you can just base your PR on the tauri v2 PR and not merge until that one is merged

I am closing the PR.
I have tried to the best of my ability to package this, but I cannot get it to work.
From my understanding as of tauri v2, tauri is affected by a bug in cargo in relation to weak dependencies (I do not think this is unique to neohtop, rather this affects all tauri v2 projects).
This means that hyper-tls cannot be found in the vendored dependencies (because it is an optional dependency) and is therefore not added correctly.
The fix to this is to copy what has been done with surrealist, which involves patching Cargo.toml and Cargo.lock to correctly include the hyper-tls dependency. But I cannot get this approach to work, and I cannot be bothered wasting more of my time trying to get this to work.


met one error when run test.py for scannet dataset. KeyError: Caught KeyError in DataLoader worker process 0. KeyError: 'image_paths'

Hi, when i run test.py for scannet dataset, i met one error.
please help, thanks very much.
root@65eb20bdb6a8:/mmdetection3d# python tools/test.py configs/imvoxelnet/imvoxelnet_scannet.py ./data/checkpoints/scannet.pth --show --show-dir ./data/scannet/show-dir/
Use load_from_local loader
[                                                  ] 0/6, elapsed: 0s, ETA:Traceback (most recent call last):
File "tools/test.py", line 153, in
main()
File "tools/test.py", line 129, in main
outputs = single_gpu_test(model, data_loader, args.show, args.show_dir)
File "/mmdetection3d/mmdet3d/apis/test.py", line 27, in single_gpu_test
for i, data in enumerate(data_loader):
File "/opt/conda/lib/python3.7/site-packages/torch/utils/data/dataloader.py", line 363, in next
data = self._next_data()
File "/opt/conda/lib/python3.7/site-packages/torch/utils/data/dataloader.py", line 989, in _next_data
return self._process_data(data)
File "/opt/conda/lib/python3.7/site-packages/torch/utils/data/dataloader.py", line 1014, in _process_data
data.reraise()
File "/opt/conda/lib/python3.7/site-packages/torch/_utils.py", line 395, in reraise
raise self.exc_type(msg)
Original Traceback (most recent call last):
File "/opt/conda/lib/python3.7/site-packages/torch/utils/data/_utils/worker.py", line 185, in _worker_loop
data = fetcher.fetch(index)
File "/opt/conda/lib/python3.7/site-packages/torch/utils/data/_utils/fetch.py", line 44, in fetch
data = [self.dataset[idx] for idx in possibly_batched_index]
File "/opt/conda/lib/python3.7/site-packages/torch/utils/data/_utils/fetch.py", line 44, in
data = [self.dataset[idx] for idx in possibly_batched_index]
File "/mmdetection3d/mmdet3d/datasets/custom_3d.py", line 292, in getitem
return self.prepare_test_data(idx)
File "/mmdetection3d/mmdet3d/datasets/custom_3d.py", line 166, in prepare_test_data
input_dict = self.get_data_info(index)
File "/mmdetection3d/mmdet3d/datasets/scannet_monocular_dataset.py", line 19, in get_data_info
for i in range(len(info['image_paths'])):
KeyError: 'image_paths'

Hi @jasmine202106 ,
Did you follow our ScanNet instructions in README?

the filenames in the sens_reader/scans/scene0000_00/out extracted from sensreader are 0.jpg, 0.txt, 1.jpg, 1.txt......, not frame-000001.color.jpg .....
is that the reason?
others are all ok with your instruction.

Are you running with --dataset scannet_monocular? Can you please ensure that this line is executed while running create_data.py? As you missing image_paths key is added there.
One more thing about filenames. If your names are like 0.txt and not like 000001.pose.txt, can you please update these 6 lines accordingly?
Sorry for these inconveniences. Your 0.txt is produced by ScanNet official python script, however they also provide a c++ code.

root@65eb20bdb6a8:/mmdetection3d# python tools/create_data.py scannet --root-path ./data/scannet --out-dir ./data/scannet --extra-tag scannet --dataset scannet_monocular
usage: create_data.py [-h] [--root-path ROOT_PATH] [--version VERSION]
[--max-sweeps MAX_SWEEPS] --out-dir OUT_DIR
[--extra-tag EXTRA_TAG] [--workers WORKERS]
kitti
create_data.py: error: unrecognized arguments: --dataset scannet_monocular
root@65eb20bdb6a8:/mmdetection3d#
train sample_idx: scene0000_00 0/24
Traceback (most recent call last):
File "tools/create_data.py", line 293, in
monocular=True
File "tools/create_data.py", line 127, in scannet_data_prep
root_path, info_prefix, out_dir, workers=workers, monocular=monocular)
File "/mmdetection3d/tools/data_converter/indoor_converter.py", line 42, in create_indoor_info_file
infos_train = train_dataset.get_infos(num_workers=workers, has_label=True)
File "/mmdetection3d/tools/data_converter/scannet_data_utils.py", line 182, in get_infos
infos.append(self.process_single_scene(sample_idx, has_label))
File "/mmdetection3d/tools/data_converter/scannet_data_utils.py", line 148, in process_single_scene
base_file_names.remove('_info')
KeyError: '_info'
i changed the 6 lines in scannet_data_utils.py to:
base_file_names = {x.split('.')[0] for x in os.listdir(frame_path)}
#base_file_names.remove('_info')
for base_file_name in base_file_names:
#pose = np.loadtxt(osp.join(frame_path, f'{base_file_name}.pose.txt'))
pose = np.loadtxt(osp.join(frame_path, f'{base_file_name}.txt'))
if np.all(np.isfinite(pose)):
#info['image_paths'].append(osp.join(frame_sub_path, f'{base_file_name}.color.jpg'))
info['image_paths'].append(osp.join(frame_sub_path, f'{base_file_name}.jpg'))
info['pose'].append(pose)
then:
root@3f02d12999fe:/mmdetection3d# python tools/create_data.py scannet_monocular --root-path ./data/scannet --out-dir ./data/scannet --extra-tag scannet
Traceback (most recent call last):
File "tools/create_data.py", line 5, in
from tools.data_converter import kitti_converter as kitti
File "/mmdetection3d/tools/data_converter/kitti_converter.py", line 5, in
from mmdet3d.core.bbox import box_np_ops
File "/mmdetection3d/mmdet3d/core/init.py", line 2, in
from .bbox import *  # noqa: F401, F403
File "/mmdetection3d/mmdet3d/core/bbox/init.py", line 4, in
from .iou_calculators import (AxisAlignedBboxOverlaps3D, BboxOverlaps3D,
File "/mmdetection3d/mmdet3d/core/bbox/iou_calculators/init.py", line 1, in
from .iou3d_calculator import (AxisAlignedBboxOverlaps3D, BboxOverlaps3D,
File "/mmdetection3d/mmdet3d/core/bbox/iou_calculators/iou3d_calculator.py", line 5, in
from ..structures import get_box_type
File "/mmdetection3d/mmdet3d/core/bbox/structures/init.py", line 1, in
from .base_box3d import BaseInstance3DBoxes
File "/mmdetection3d/mmdet3d/core/bbox/structures/base_box3d.py", line 5, in
from mmdet3d.ops.iou3d import iou3d_cuda
File "/mmdetection3d/mmdet3d/ops/init.py", line 5, in
from .ball_query import ball_query
File "/mmdetection3d/mmdet3d/ops/ball_query/init.py", line 1, in
from .ball_query import ball_query
File "/mmdetection3d/mmdet3d/ops/ball_query/ball_query.py", line 4, in
from . import ball_query_ext
ImportError: cannot import name 'ball_query_ext' from 'mmdet3d.ops.ball_query' (/mmdetection3d/mmdet3d/ops/ball_query/init.py)

This _info.txt is the output of Scannet c++ script. We just use it to read single 4x4 matrix of camera intrinsics per scene. If you are using their python script can you please run it with --export_intrinsics and save the resulting 4x4 matrices for corresponding _info.txt file?

Also my PR for ScanNet preprocessing is today merged to mmdetection3d master. It is much more documented and supports processing for example 100 images out of 5000 per scene to speed up this step. It also support multiprocessing. You can probably use this for preprocessing and then just simply update these 1, 2, 3 lines in ScanNetMultiViewDataset.
I'm going to update this here when I have some time. Sorry again for your inconveniences.

PR #21 aims to merge the full ScanNet processing from mmdetection3d master branch. However I need to test it later.


install_cucumber_rails & Other legacy methods: Tidy up / Lint

Minor tidy to method to improve linting and use new syntax
Expected Behavior
Should use new ruby 2.3+ syntax
Current Behavior
Use Ruby 1.9 or older syntax
Possible Solution
Update syntax

Partially fixed by #441 but need to put into better layout (private methods e.t.c.), not a massive huge chunky one.

What needs to be done to close this issue @luke-hill ?

Not really sure. I can check on friday as I've got most of the day to go into this. If memory serves me right #441 was a tidy up of really bad syntax / standards. But I think I only fixed half of it. (Due to time / complexity).

I'll just close this now. As it's working and tidier than it was after that OP.


Why is rversions in Suggests?

I see rversions is listed among Suggests dependencies but I don't see where it is used in the package code, is it actually needed?

thats actually a good question. figured it came from some dependency.
lets me check it and at same time upgrade all dependencies.

pushed some updates to branch 0.3.1
you can review there the updated dependencies

Thanks!

0.3.1 released

🎉


Rayan's suggestion to half the alphabet size

get rid of the odd numbers and check start and end with ranks over the mask

Sorina, I propose we close this. We have a better solution planned.

um, I don't think our solution applies to this. whatever way we choose to do the range search, we still need to check whether the markers found represent the start or end of a site

yes, but don't need one alphabet per site


here is my model by using LSTM method with 99% accuracy

sir please assign me level 3 badge

sir please assign me level 3 badge

you can work on some advanced issues, then I will put level 3.This issue is of level 2 only.

sure sir i work some big financial analytic project


Animated Profile Card

What is the change?
It adds an animated profile card template in card section
Related issue?
closes: #115
How was it tested?
The code was tested by using live server extension in VSCode
Checklist:
Before you create this PR, confirm all the requirements listed below by checking the checkboxes [x]:

[x] Have you followed the Contribution Guidelineswhile contributing.
[x] Have you checked there aren't other open Pull Requests for the same update/change?
[x] Have you made corresponding changes to the documentation?
[x] Have you tested the code before submission?
[x] Have you formatted your code ? (You can use any html,css beautifier)
[x] My changes generates no new warnings.
[x] I'm Hacktoberfest'21 contributor.
[x] I have commented my code, particularly in hard-to-understand areas.

GIF/video of the working of component you created:

Add a hyphen in name of folder !

Add your component to general readme.

done

Add your component to general readme.

Do this!

Sorry, I didn't get this

Add your component to general readme.

Do this!

Sorry, I didn't get this

Refer to other prs

Now it's all good?


Inconstant List Indentation

Input
 - Item 1
   - Item 2
     - Item 3
       - Item 4
         - Item 5

Output

Item 1

Item 2

Item 3

Item 4

Item 5

Expected Output
Each bullet with more indentation than the previous bullet should start a child list.
References
https://gitlab.com/gitlab-org/gitlab-ce/issues/3470

It looks like the list parsing recursion is happening in ext/redcarpet/markdown.c#L1886-L1887.
has_next_uli = prefix_uli(data + beg + i, end - beg - i);
has_next_oli = prefix_oli(data + beg + i, end - beg - i);

It looks like the logic for determining if the following line is a sibling list item is not properly matching the indentation. Both variables should be false, and it should parse the following lines as a nested block.

I believe I have a potential fix for this issue, and will open up a pull request. I noticed when peeking at the work buffers that indentation was being lost or not properly handled, so this fix focuses on the indentation handler at ext/redcarpet/markdown.c#L1873-L1876 .
while (i < 4 && beg + i < end && data[beg + i] == ' ')
  i++;

pre = i;

This fix works by initializing pre to a value of 4, and substituting the current fixed value of 4 for pre. This allows the initial indentation check to fire correctly, and additionally, allows for that indentation range to narrow down to the amount of indentation we need.
This fix does, however, expose a quirk that I've noted in the commit message for markdown.c; in short, max_nesting has an effect on lists, with each level from that point adding n to the current nest level (1 + 2 + ... + n ). This means the input supplied in the original message will work, as it hits a nest level of 15. However, a list 6 levels deep will have issues due to the max_nesting being exceeded (21 vs. 16). This was verified by monitoring the nest level as the process was running. A temporary hard-coding of max_nesting to 64 allowed a test of 10 levels deep to pass without issue.

Has there been any progress on this issue?

Wow, didn't know a bug related to simple nested lists, which I encountered today, has such a long history.
I don't write C that much, so I don't know why it is so difficult to fix the issue.
Anyway, thank you for creating/maintaining Redcarpet.
But do people here have any alternative gem recommendations?
I want something similar to Redcarpet in the way that it lets me customize output HTML.
For example:
# text

can be rendered to

text

This bug is a deal breaker for me; any recommended alternatives are welcome.


Use brace_style for macro_rules!

Sorry for opening so many issues at once here!
New macros don't adhere to brace_style. For example, when brace_style = "AlwaysNextLine", a macro_rules! will look like this:
macro_rules! filter_map_view {
  ($query:ident, $val:ident) => {

It should look like this:
macro_rules! filter_map_view
{
  ($query:ident, $val:ident) =>
  {

Closing as per https://github.com/rust-lang/rustfmt/issues/4938#issuecomment-913862620


Fix: Darwin (OSX) doesn't have util-linux

util-linux cowardly refuses to install on all platforms. Therefore we
cannot rely on it for external dependancies, in particular luuid.
e2fsprogs won't configure without the luuid dependancy being satisfied.
Motivation for this change
e2fsprogs failed to build (failed to configure) on osx, and presumably all platforms that failed the assert stdenv.isLinux assertion in utils-linux
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

All my tests are failing because of a license problem with pymol?  Is that because I merged in upstream master, and it was broken?

I'd recommend doing cleanup and rebase on top of master.


Update for new register backend image for Data Archival to cloud

What type of PR is this?

Uncomment only one  /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind new feature
/kind bug fix

/kind cleanup
/kind revert change
/kind design
/kind documentation
/kind enhancement

What this PR does / why we need it:
Add update for data archival changes and support metrics for multi-cloid.
Note Support metrics need to be updated for feature list
Which issue(s) this PR fixes:
Fixes # 151
Test Report Added?:

Uncomment only one  /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind TESTED
/kind NOT-TESTED

Test Report:

Special notes for your reviewer:

LGTM

LGTM

@kumarashit Please check some link issues and formatting.
One thing that is missing is to add a note in archival and retrieval regarding archived objects in GCP not requiring Restore as they are implicitly rehydrated / restored when downloaded.
Similarly a note about the Azure Hot/Cool tier and only restoring to Standard priority. (This may not be needed here.)

Mentioning this may require more details. But already architecture-analysis link s provided

@kumarashit Please check some link issues and formatting.
One thing that is missing is to add a note in archival and retrieval regarding archived objects in GCP not requiring Restore as they are implicitly rehydrated / restored when downloaded.
Similarly a note about the Azure Hot/Cool tier and only restoring to Standard priority. (This may not be needed here.)

Mentioning this may require more details. But already architecture-analysis link s provided

One thing that is missing is to add a note in archival and retrieval regarding archived objects in GCP not requiring Restore as they are implicitly rehydrated / restored when downloaded.

I think this may need to be added at the least since there is a difference in the way it operates on the frontend.


ForeignKey monkeypatch not needed for Django 4.1+

It's coming in Django https://github.com/django/django/commit/0de89b6f8d4d8f5fd232d6c5412260b0d79a760a

Thanks!


Tidying

I have made several small changes:

ran cargo fmt and cargo clippy
added more information to some documentation comments
removed an empty module
added formatting and linting checks to the CI

I have not used Travis CI before so there may be problems with my changes
I added FreeBSD as part of the CI process. I see from #65  that this will fail currently so the configuration currently allows that.
I see that the latest commit is failing on rust nightly. The CI configuration allows build failures on nightly now which is probably advisable
travis-cargo has not been updated since 2016 so I'm not sure whether it still works, but I left it in anyway
it should be possible to automatically push to crates.io by pushing to the release branch but I don't have a crates.io account so can't experiment with that.
I made some changes that were recommended by travis when I ran the travis job on another repo for testing, namely:

root: deprecated key sudo (The key `sudo` has no effect anymore.)
root: missing dist, using the default xenial
root: missing os, using the default linux

I'll probably switch to gh actions at some point, but thanks for tidying up the ci script.


Add per-age processing

This is a huge PR. Sorry about that.
It should not affect any existing functionality.
Per-age processing is turned on with pacehrh::SetPerAgeStats(TRUE). Turning per-age processing on will slow simulations down A LOT.
Closes Issue #133.

@MeWu-IDM : I lied. I did make a breaking change:

I removed the setGlobalConfig() and replaced it with SetInputExcelFile(). This allows for code like the following.
  pacehrh::SetInputExcelFile("./simple_config/super_simple_inputs.xlsx")
  pacehrh::InitializePopulation(popSheet = "Flat_Population")
  pacehrh::InitializeScenarios()
  pacehrh::InitializeStochasticParameters()
  pacehrh::InitializeSeasonality()

@celiot-IDM  I have done some testing on @rhanIDM simulation scenario with 50 trails, comparison of some tasks are shown here:
Most of the seasonality tasks seems very close but "Record keeping" seems to be slightly higher (no seasonality), not sure if that is due to rounding. I think we can merget this PR first and continue investigation next week.

this is the aggregated results for "record keeping"


URL in the maven artifact incorrectly points the KTX repo

Starting at version 1.3.0 the URL associated with the com.google.maps.android:android-maps-utils artifact points to https://github.com/googlemaps/android-maps-ktx instead of https://github.com/googlemaps/android-maps-utils.  Can compare at:
https://search.maven.org/artifact/com.google.maps.android/android-maps-utils/1.2.1/aar
vs.
https://search.maven.org/artifact/com.google.maps.android/android-maps-utils/1.3.1/aar

Thanks for reporting!


[AIRFLOW-1799] Fix log format string syntax

Dear Airflow maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[x] My PR addresses the following Airflow JIRA issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-1799

Description

[x] Here are some details about my PR, including screenshots of any UI changes:
I have a task which uses schedule_interval in a deprecated way, and as a result airflow logs thousands of error messages in an attempt to warn against using the deprecated feature. These errors are obscure because the formatting syntax used in the log message is incorrect.

Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason: This is a trivial fix to a logging line which was intended to help users migrate away from deprecated behavior.

Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report

Merging #2777 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2777      +/-   ##
==========================================
- Coverage   73.38%   73.37%   -0.01%
==========================================
  Files         157      157
  Lines       11932    11932
==========================================
- Hits         8756     8755       -1
- Misses       3176     3177       +1

Impacted Files
Coverage Δ

airflow/models.py
87.25% <ø> (-0.05%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 715602c...bff64e8. Read the comment docs.

Thanks for spotting. LGTM


Update quick reference broken link

The current link for how-to-work-on-coding-challenges.md is broken as it doesn't include the docs folder

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

Thank you for opening this pull request.
This is a standard message notifying you that we’ve reviewed your pull request and have decided not to merge it. We would welcome future pull requests from you.
Thank you and happy coding.


Is there js version pdf.js? or from now on there is only mjs version?

I want to use newest pdf.js but I found that the file are mjs type, but my web site don't support that, is there js version I can use?

We only distribute .mjs files now, sorry.