add custom error handler

would be good to record errors on sentry (or similar) and ensure they aren't seen on live sites

hi,
what kind of errors you'd like to record ? tracing uncaught errors can get quickly complex. there are also a few browser quirks (FF <11, safari) which have to be treated explicitly. anyway, it's a full day of work and near 2 pages of dense code ...

In my experience it need not be so complicated. In other projects I've simply set up a free dashboard at sentry.io, and used their Raven javascript tooling to automatically catch and trace otherwise uncaught errors, and push to the dashboard alongside custom meta that I think would be useful for debugging (e.g. state variables). This is more like 5-10 lines of code in total, and could also easily be extended to also work with react's own componentDidCatch mechanism to aggregate errors on individual components.
A 10 minute search on google and I don't see any strong alternatives (open to suggestion). Also I've only ever used with Angular projects (and it works very well), I see there is documentation for React so I assume all would be fairly straight forward for anyone interested in implementing.

hey, ok lets go for it :-)
I understand using this functionality is rather at certain moments. may be it makes easier to define what to inject and when and how, as outline.
btw. writing a good opt-in agent to trace errors (stack-trace as well) requires quite a good amount of knowledge about browsers. the code we did was 80% about browser quirks and the rest about onError and stack-traces

yeah that doesn't sound very fun at all! But maybe a battle worth fighting in the future if we really see a rise in user numbers, devices and browsers

lol, let me check the sentry.io agent but I guess it's complete and doesn't add too much size. I have some spare time to get this done, til we proceeded with the tinymce merge and so we make the final steps afterwards (mention plugin, link, doc, whatever picker, multiple image uploads, image resize, etc...)
g

ok, I checked. please :

create sentry.io token
let m know how you want this, ie: as HOC for any component, or as simple class implementation as suggested by sentry :

// Sentry.init({
//  dsn<EMAIL_ADDRESS>// });
// should have been called before using it here
// ideally before even rendering your react app

class ExampleBoundary extends Component {
    constructor(props) {
        super(props);
        this.state = { error: null };
    }

    componentDidCatch(error, errorInfo) {
      this.setState({ error });
      Sentry.withScope(scope => {
        Object.keys(errorInfo).forEach(key => {
          scope.setExtra(key, errorInfo[key]);
        });
        Sentry.captureException(error);
      });
    }

    render() {
        if (this.state.error) {
            //render fallback UI
            return (
               Sentry.showReportDialog()}>Report feedback
            );
        } else {
            //when there's not an error, render children untouched
            return this.props.children;
        }
    }
}

I think it makes most sense for initially you to create your own account and use the token from that so that you have full access to the dashboard, then we can transfer ownership to a shared email later once working correctly (it would be good to avoid paying for a team subscription unless felt necessary at a later point).
I don't have a strong opinion or knowledge of how best to implement so feel free to experiment however you feel best.

hi,
so i finished the first slice

sentry catches all errors but also wraps the console object (which is annoying because you have an altered stack / display in the chrome - dev - tools. i have put a quick toggle in src/config 'sendErrors' to disable this via url '?captureException=false'
i have put an Error Boundary component at the root of the app
i re-exported the sentry.io manual log functions  in https://github.com/tx4x/onearmy/blob/error-handler/src/common/errors.ts so if needed this can be wrapped further as decorators or common logging functions

I have to wait for dev-notice (#272 ) and mobx (#276 ) to make a PR for this.

sounds great, yeah the PRs have been slow today as some challenging refactoring for backend functions needed (still WiP, but 90% there), and lots of conflicts to sort as quite a bit of work done across the different branches. Should have #272 and #276 in by tomorrow though

New account setup for onearmy, dsn info has been added to src/config for dev/staging and prod sites and pushed to the master branch.
For anybody who would like to access the dashboard I'm happy to share the details (unique password for platform and no billing setup)
Can login as<EMAIL_ADDRESS>pw: 5wcigHBuV8tXMez
I'm guessing now the other PRs have been merged this should be good to go @tx4x?

Also if anybody just wants to receive the weekly error summary report via email I can setup a label and forwarding rule for the email inbox

@chrismclarke, great, i am back tomorrow with a PR for that.


Linked list: Implement Doubly linked list in C++

may i work on this one?

may i work on this one?

Sure

hey a similar issue has been merged, can u suggest changes/improvements from the previous implementation soIcan get working.

hey @akgmage Assign this to me if no one is working

added the solution after the merge please close this issue.

added the solution after the merge please close this issue.

Thanks


WIP : Add Microsoft Graph API

Description
I have created this one to be able to call microsoft graph API and be able to create GuestUser invitation.
Related issues
https://github.com/terraform-providers/terraform-provider-azuread/issues/41
https://github.com/Azure/azure-sdk-for-go/issues/4086
Collaboration
If someone want to help me, don't hesitate to ask, i'll give you right on my fork to work together
you can also speak about this subject on slack: https://gophers.slack.com/archives/C018JNKB81E
General
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of “no breaking changes
[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[x] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
Adding a new service

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable version with Breaking Change Validation errors
[ ] Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

You don't have permission to trigger SDK Automation.
Please add yourself to Azure group from opensource portal if you are MSFT employee,
or please ask reviewer to add comment *** /openapibot sdkautomation ***.
Please ask<EMAIL_ADDRESS>(or NullMDR in github) for additional help.

Can one of the admins verify this patch?

Hello,
We was able to set if work, the invitation sent, but after generation by autorest of the go's code we MUST modify like this :
 -91 autorest.WithJSON(invitationContent)) +91 autorest.WithJSON(invitationContent), +92 client.Authorizer.WithAuthorization())  93 p,err := preparer.Prepare((&http.Request{}).WithContext(ctx)) /services/graph/1.0/graph/guestuser.go
Do you have an idea of paramter to put on readme, json, or somewhere else to let it managed by autorest generation directly ?
Regards Marc.

Hello,
We was able to make it work, the invitation sent, but after generation by autorest of the go's code we MUST modify like this :
-91 autorest.WithJSON(invitationContent))
+91 autorest.WithJSON(invitationContent),
+92 client.Authorizer.WithAuthorization())
 93 p,err := preparer.Prepare((&http.Request{}).WithContext(ctx))
/services/graph/1.0/graph/guestuser.go

Do you have an idea of paramter to put on readme, json, or somewhere else to let it managed by autorest generation directly ?
Regards Marc.

In fact we figure about this using a dedicated authorizerWithresource it work without modification of code generated by autorest
package main

import (
	"context"

	"github.com/Azure/azure-sdk-for-go/services/graph/1.0/graph"

	"github.com/Azure/go-autorest/autorest/azure/auth"
	"github.com/Azure/go-autorest/autorest/to"
	"fmt"
)

func main(){
	guestUserClient := graph.NewGuestUserClient()
	// create an authorizer from env vars or Azure Managed Service Idenity
	authorizer, err := auth.NewAuthorizerFromEnvironmentWithResource("https://graph.microsoft.com")
	if err == nil {
		guestUserClient.Authorizer = authorizer
	}else{
		fmt.Println(err)
	}
	guestUserObj := graph.InvitationSended{ InvitedUserEmailAddress : to.StringPtr("toto@domain.com"), InviteRedirectURL : to.StringPtr("https://portal.azure.com"), SendInvitationMessage : to.BoolPtr(true)}
	invitation,err := guestUserClient.Create(context.Background(),guestUserObj)
	if err != nil {
		fmt.Println(err)
	}
	fmt.Printf("%+v\n", invitation)
}

Regards Marc.

Hello,
CI always said that I need version matching YYYY-MM-DD but the graph API does not work like this it's version 1.0.
I tried to add -preview suffux but did not correct this.
Does someone know how to fix this ?
Regards Marc.

BTW, I have no access to https://aka.ms/ameonboard to review the workflow

Hello,
@fengzhou-msft can I have some feedback plz ?
I really would like to improve this subject.
Regards Marc.

Please go through the contribution checklist added as part of the review and mark them completed. This is a requirement before review can be continued.

Please go through the contribution checklist added as part of the review and mark them completed. This is a requirement before review can be continued.

Hello,
like I said I have no access to documentation I can check boxes but I prefer to read it before, to be sure I'm compliant ;)
Regards Marc.

/azp run

thanks @ArcturusZhang do you have any improvement / change that I should / must do ?
Regards Marc.

not sure if this is meant for ARM review as the paths dont seem to be compliant with control plane APIs. It seems dataplane to me. If this is a new RP, please set up a call with armapireview to go over the APIs, but please ensure its compliant with ARM Resource provider contract.

@Maarc-D what's the plan for this PR? It's been idle for a while.

@Maarc-D what's the plan for this PR? It's been idle for a while.

I already answer here : https://github.com/Azure/azure-rest-api-specs/pull/10275#discussion_r473691914
maybe you can close it


User feedback

Good work with the planner so far.
My suggestions:

Right click interacts strangely with probably "drag grid". Suggestion: move drag grid to middle mouse button or allow that as an option.
Allow placements of "nodes" with an input that will cap the numbers you can put later in the production chain. (probably for ore, possibly for any product not only ore.)
Allow to insert mergers/splitters on an existing connection.

I wish you good luck with your project!

Thank you for your feedback, will try to look what can be done

I want to add the need for some node. I just found your tool on reddit and already love it. I want to use this on my laptop next to my monitor where I run Satisfactory and want to plan my whole savegame in it. So I want to be able to put in all my nodes that I somewhere have connected to a Miner with its output to know how much ore I have left and to draw down every single factory I have. Maybe even give us some sort of text to place down and paint squares.

I want to add the need for some node. I just found your tool on reddit and already love it. I want to use this on my laptop next to my monitor where I run Satisfactory and want to plan my whole savegame in it. So I want to be able to put in all my nodes that I somewhere have connected to a Miner with its output to know how much ore I have left and to draw down every single factory I have. Maybe even give us some sort of text to place down and paint squares.

A ore node may be added sometimes in the future. In the meantime, on the left panel in the "inputs" section you should see the sum of all the ore of each type you are using, so if you know how much you have in your world you can compare both numbers easily.


[ISSUE #658]🚀Support pull message consume

Which Issue(s) This PR Fixes(Closes)

Fixes #658
Brief Description

How Did You Test This Change?

Summary by CodeRabbit

New Features

Introduced new struct PullMessageResponseHeader for handling message pulling with fast serialization capabilities.
Added support for dynamic message consumption configuration with lite_pull_message_enable option.

Improvements

Enhanced ConsumeMessageHook with additional trait constraints for better concurrency support.
Extended PullMessageProcessor with new fields and methods to improve message processing.
Updated method signatures and implementations for better performance and flexibility in message handling.

Refactor

Refactored SendMessageResponseHeader to use static method calls for improved code clarity.
Promoted filter module to be publicly accessible.

Documentation

Added detailed documentation for new modules and updated existing ones to reflect changes.

🚀Thanks for your contribution🎉. CodeRabbit(AI) will review your code first🔥

🚀Thanks for your contribution🎉. CodeRabbit(AI) will review your code first🔥

🚀Thanks for your contribution🎉. CodeRabbit(AI) will review your code first🔥


update method GetSurfaceNamesFromMap

had to update this to return the correct surface layers

@dhagens please review and merge


[Question] Are there any C# clients available to deploy workloads to Arc-enabled kubernetes?

Describe scenario
Deploy workloads to Azure Arc Enabled AKS Edge (Device) from .NET
Question
The current documentation only describes use-cases where GitOps or native kubernetes CLI tools can deploy workloads to an Arc-enabled kubernetes. I am looking for a .NET client library that can target an Arc-enabled edge essentials device. In case one does not exist, what are my options? I have a central system that can create the yaml deployment manifest, and I need a way to call an API that targets the AKS Edge device through Azure ARC.

Hi @mikanygTC,
Thanks for reaching out.  Check Microsoft Azure Hybrid Kubernetes management client library for .NET.
Thanks,
Francisco


updated recoveries on district data for gp_westrand file

Updated recoveries data and the daily subdistrict cases on the gp_westrand.csv file
added daily entries for West Rand Recoveries column, WR Merafong city, WR Mogale city, WR RW city and Unallocated.

@BadisaMosesane Thank you for this --- this file is automatically updated with all the other GP metros from a common source file so I don't update this file separately from all the others and it will be over-written. I see you have some older data not captured. Could you summarise the differences and I will try to update the GP source file over the next day or two.

@BadisaMosesane Please could you relook at your pull request. You have added quotes to the header, which is not correct and breaks the GitHub pretty viewer which makes it hard for me to review. And then if you could just give me a one sentence explanation of what you've done then I can look at it. Again thanks for your help -- much appreciated

@shaze thanks for the feedback, I will have a look at it again, I guess the csv save format (utf csv) might have caused the quotes to the header.
I have added some data on the gp_westrand file I.e. added missing entries for the recoveries column, and added daily cases for the individual subdistricts. The idea is to populate missing values in the daily sub district cases.

Great -- if you could fix the header then I will look at it and import.

Alright @shaze I will change the delimiter to comma and push

@BadisaMosesane Can you update so that we can merge

Hi Vukosi,
I had updated and shared the files with Scott.
Regards
On Fri, Jul 10, 2020 at 3:50 PM Vukosi<EMAIL_ADDRESS>wrote:

@BadisaMosesane https://github.com/BadisaMosesane Can you update so
that we can merge
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dsfsi/covid19za/pull/453#issuecomment-656687161, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AD3YXIE7XRSMPHHURMSKYU3R24MCRANCNFSM4N6GNEIA
.

--
Badisa Mosesane
Computer Science Student
University of Botswana
'Aspiring Data Scientist'

Sorry -- I am the bottleneck. This is historical data -- a one-off collection. I do intend to start updating this data and will integrate when I have the time to start.


fix: modelMesh destroy bug

Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

Codecov Report

Merging #477 (eb3c6d3) into main (28c4c17) will increase coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #477      +/-   ##
==========================================
+ Coverage   47.99%   48.17%   +0.18%
==========================================
  Files         349      349
  Lines       18963    18894      -69
  Branches     2544     2530      -14
==========================================
+ Hits         9101     9103       +2
+ Misses       9862     9791      -71

Impacted Files
Coverage Δ

packages/core/src/mesh/ModelMesh.ts
96.26% <100.00%> (+0.50%)
:arrow_up:

packages/draco/src/decoder.ts
0.00% <0.00%> (-0.92%)
:arrow_down:

packages/loader/src/scene-loader/Oasis.ts
0.00% <0.00%> (ø)

...ackages/loader/src/scene-loader/ResourceManager.ts
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28c4c17...eb3c6d3. Read the comment docs.


Java batch update

It looks like the build is failing because bigtable now needs iam.

Also you seem to be including class files, those should be removed.

Removed class files, and fixed iam dependency in bigtable.

PTAL
Not sure why the openjdk7 build fails on a STANDARD_ERROR that passes in tests outside of the logging API; openjdk8 build does pass!


DashboardMonitor Pie charts show title on online preview but not on locahost.

I've visited https://preview.pro.ant.design/dashboard/monitor and scrolling down to the "Proportion Per Category" card, Pie charts show titles: Fast food, Western, Hot pot.

However, after running the following, those labels disappear.
// Install empty project of Ant Design Pro
npm create umi
Select ant-design-pro
Select TypeScript
// Add all blocks from demo preview
npm run fetch:blocks
// run project
npm start

After you login and navigate to http://localhost:8000/dashboard/monitor and then scroll down again to "Proportion Per Category", the Pie charts do not show their title anymore.
I've checked through the code and changed the  "title" props to "subTitle" and at this time it works correctly.
Edited src/pages/dashboard/monitor/index.tsx from the following...

... and changed it into the following:

And now it works again!

Why is there this difference? I spent half a day to figure out, it's a shame that the online version and the installed version are different. I've also spotted other differences. It would be nice and expected to have them consistent. Please let me know, that would help.

http://localhost:8000/dashboard/monitor.kbl)


[EKS Windows]: Bootstrap argument not working in Windows nodes

What happened:
I'm following the official documentation for Windows nodes on EKS. When deploying the windows nodes I follow https://docs.aws.amazon.com/eks/latest/userguide/launch-windows-workers.html
and set AssociatePublicIpAddress: 'false' for the image /aws/service/ami-windows-latest/Windows_Server-2019-English-Full-EKS_Optimized-1.14/image_id
If I don't set any bootstrap parameters, I can see the new Windows nodes by running kubectl get node.
However, I need to add the following kubelet args to the bootstrap script:
--kubelet-extra-args '--register-with-taints os=Win1809:NoSchedule'

The result is that kubectl get node does not show the windows nodes at all.
What you expected to happen:
kubectl get node to show windows nodes and with the expected taint
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

AWS Region: eu west 1
Instance Type(s): t2.medium
EKS Platform version (use aws eks describe-cluster --name <name> --query cluster.platformVersion):
"eks.1"
Kubernetes version (use aws eks describe-cluster --name <name> --query cluster.version):
"1.14"
AMI Version:
ami-082eddfe14aefde9e
Kernel (e.g. uname -a):
Release information (run cat /etc/eks/release on a node):

Same problem here. I had to remove the --kubelet-extra-args flag to get the node to register.
I was attempting to pass the following:
--kubelet-extra-args '--node-labels=node-role.kubernetes.io/ondemand-windows-r5-large-green=true'

'--register-with-taints os=Win1809:NoSchedule'

What happened:
I'm following the official documentation for Windows nodes on EKS. When deploying the windows nodes I follow https://docs.aws.amazon.com/eks/latest/userguide/launch-windows-workers.html
and set AssociatePublicIpAddress: 'false' for the image /aws/service/ami-windows-latest/Windows_Server-2019-English-Full-EKS_Optimized-1.14/image_id
If I don't set any bootstrap parameters, I can see the new Windows nodes by running kubectl get node.
However, I need to add the following kubelet args to the bootstrap script:
--kubelet-extra-args '--register-with-taints os=Win1809:NoSchedule'

The result is that kubectl get node does not show the windows nodes at all.
What you expected to happen:
kubectl get node to show windows nodes and with the expected taint
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

AWS Region: eu west 1
Instance Type(s): t2.medium
EKS Platform version (use aws eks describe-cluster --name <name> --query cluster.platformVersion):
"eks.1"
Kubernetes version (use aws eks describe-cluster --name <name> --query cluster.version):
"1.14"
AMI Version:
ami-082eddfe14aefde9e
Kernel (e.g. uname -a):
Release information (run cat /etc/eks/release on a node):

Are you passing "--kubelet-extra-args" as well? Remove that and try. If you still face issues let us know.

@somujay I'm setting this in the bootstrap arguments --kubelet-extra-args '--register-with-taints os=Win1809:NoSchedule'

bump? This is a huge blocker since I can't taint my Windows nodes and Linux pods are scheduled there. Modifying all Linux manifests to require a Linux node would be too much work.

bump? This is a huge blocker since I can't taint my Windows nodes and Linux pods are scheduled there. Modifying all Linux manifests to require a Linux node would be too much work.

Can you just add '--register-with-taints os=Win1809:NoSchedule' ? I will fix windows bootstrap to match with linux behavior.


from future import divisions

when running the code, it reports that:
 File "tools/Train_ResNet_VCOCO.py", line 20, in <module>
    from ult.config import cfg
SyntaxError: future feature divisions is not defined (config.py, line 8)

And I update the from __future__ import divisions of config.py with:
from __future__ import division
and solve this error. it seems a typo error of lib/ult/config.py.

Good catch!
It is fixed. Thanks.


virt-controller: fix panic when the handling request vm has been deleted

What this PR does / why we need it:
When VolumeRequest is in the VirtualMachine Status, the virt-controller calls the VirtualMachine Update method. If the VirtualMachine may have been deleted and the returned vm.spec.template is nil, a panic error will occur.
When an error occurs on the virt-controller, it is hoped that the error log is printed instead of a panic to avoid a brief service interruption.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note:

NONE

Hi @ivandans ,
Thanks for the contribution. We should fix the root cause, and make sure we always have a non-nil VM. WDYT?

HIIt would be nice to be able to fix the root cause.The vm controller calls the vm's Update method when handling requests such as VolumeRequest.But the vm returned by the Update method is not reliable due to concurrency issues, so we need to add a judgment before you can execute the rest of the process. Do you have a better way to handle this?

The
vm, err = c.clientset.VirtualMachine(vmCopy.Namespace).Update(vmCopy)
if err != nil {
	syncErr = &syncErrorImpl{fmt.Errorf("Error encountered when trying to update vm according to add volume and/or memory dump requests: %v", err), FailedUpdateErrorReason}
}

The vm should not be overridden.
We should do
updatedVm, err := c.clientset.VirtualMachine(vmCopy.Namespace).Update(vmCopy)
 if err != nil {
 	syncErr = &syncErrorImpl{fmt.Errorf("Error encountered when trying to update vm according to add volume and/or memory dump requests: %v", err), FailedUpdateErrorReason}
 } else{
   vm = updatedVm
}

@ivandans Could you also add a unit test?


add ecosystem page with current set of logos

This change would add an Ecosystem basepage with a table of metadata producers and consumers.
Signed-off-by: Michael Robinson<EMAIL_ADDRESS>

@rossturk This is ready for review

@rossturk This is ready for review

@rossturk we're getting there, I think. The different stroke on the borders on the bottom is actually a resolution issue, not a stroke issue

@rossturk This RFR. Please note the way I resolved a conflict in config.ts in case you would prefer a different order for the basepages there.


SendTask support

Q
A

Branch?
master

Bug fix?
no

New feature?
yes

BC breaks?
no

Deprecations?
no

Tests pass?
yes

Fixed tickets

License
BSD-2-Clause

Added support for SendTask. As per the BPMN2 specification, since a Send Task operation will send a message and then complete itself (and also has a field for operation reference), it uses the same mechanism as the OperationalInterface so can be passed to the OperationRunner for sending (check if implements MessageInterface).

@SirWaddles Thank you! :smile:


Adds read support types for objects within a list.

For example, take this schema:
    const PostSchema = new mongoose.Schema({
      title: String,
      authors: [{
        username: String,
        email: String
      }]
    })

Before this commit authors would be mapped to GraphQLGeneric. This commit
generates the appropriate nested types within a GraphQLList.
This change only applies to queries. Mutations of objects nested in a list are a TODO.

Thanks for the PR! :+1: I only had time for quick coding style review. I will take another look tomorrow, but it looks great!
Can you change the commit message to follow our style? We use the angular commit message conventions, so we can generate the changelist automatically.

@tothandras Thanks for the review. I've made changes based on your suggestions and updated my branch.
While I was waiting for your review of the original pull request, I realized that I wasn't resolving nested refs properly. This new pull fixes nested refs, both in objects and lists.

@jashmenn Thanks for the changes! Although I am really against including Mongoose specific reference resolve logic in type.js. Eventually we would like to split this project into two, making it easier for others to create adapters for other ORMs. Every Mongoose specific code should be either in query.js or model.js.

@jashmenn I've added you to a gitter room, feel free to ping me there too.

This has been working nicely for me. Including nested refs support :+1:

@jashmenn I've opened a PR against your branch, changed a few things here and there. Take a look at it. :)

Never mind, I've pushed it instead, you are probably on holidays. :)


RDKTV-13966: Correction setCoreTempThresholds API

Reason for change: setCoreTempThresholds API documentation correction
Test Procedure: Create a thunder command based on the documentation
and execute the command
Risks: Low
Signed-off-by: sputhi200<EMAIL_ADDRESS>

Closing this pull request and opening a new request with the correct changes.
https://github.com/rdkcentral/rdkservices/pull/2162


Cisco Catalyst 9800 template

Overview
This pull request adds a template for Cisco Catalyst 9800 series wireless LAN controller
What it is?

SNMP based template for Cisco Catalyst 9800 series wireless LAN controller
It covers wireless monitoring like Wireless Client Count, AP Count, Radio utilization, Mobility tunnel status, and High Availability status.
It relies "Cisco IOS by SNMP" template or others to get general IOS-XE status like CPU utilization, Memory usage, or interface status.

Background

Current Zabbix templates including user community support either legacy AireOS based Wireless Controller, Meraki or just for IOS-XE like interface stats.
Current generation Cisco wireless controller is not monitored via Zabbix from wireless point of view, because some of SNMP MIBs changed from AireOS

Target Zabbix version

6.0 and later (tested on 6.0.29)

Testing
I tested this template on my environment below.

Cisco IOS Software [Dublin], C9800 Software (C9800_IOSXE-K9), Version 17.12.3, RELEASE SOFTWARE (fc7)
C9800-L-F-K9
C9800-CL-K9
Zabbix 6.0.29

Note
I updated it to my personal github repository.
If this is merged, it will move to archived.

Hello!
Please, follow the guidelines
Change the destination directory name format to
<source_directory>/template<your_tempalte_name_splitted_by_underscores>/<zabbix-version_supported>/
Example
Cloud/template_cisco_9800_by_snmp/6.0/
Don't forget to define your GitHub user name as an author for maintenance in the future
Use underscores in file names as separators instead of hyphens
If it is possible, please add the template for the 7.0 LTS Zabbix version as well

Hi igorbach,
I modifiled destination name format folowing the guideline and add auther on the template description.
I will try to add 7.0 LTS formate later, but it make take a little bit time.
Thanks,
hshimomura

Add template for 7.0 LTS, changed tested environment and resolve errors.


add support for Obsolete tag

The dependencies section of the spec file appears to have requires, provides, and conflicts but nothing for obsoletes. I recommend introducing the tag following the same syntax as the other tags easy-rpm already provides:
options: {
    obsoletes: [ "foo-bar >= 1.12", "some-package" ]
}

Thanks for this and your PR.  I've merged this into the develop stream and will be cutting a new release fairly soon.


Internal Exception?

Hello!
I have a Sentry NPC running a task that starts with
- while <npc.is_spawned||false> {

When the NPC gets killed, the console gives me "ERROR! Internal exception was thrown!", and "[dNPC] Uh oh! Denizen has encountered a NPE while trying to fetch an NPC. Has this NPC been removed?" There's also a lot of [SEVERE] gray text, so something has obviously gone wrong.
I've tried queue<EMAIL_ADDRESS>clear-ing on death, which runs successfully but does not resolve the issue.
I've also tried adding "if npc.is_spawned||false {" before every command, and running the task instantly. I was hoping that no commands would ever been given to a dead NPC, but the errors still occur.
Yes, I've updated everything. Denizen Dev build 301, Citizens build 1248, latest version of Spigot.
I have citizens, denizen, permissionsEx, sentry and vault on a local server.
Here's a debug recording:
http://mcmonkey.org/paste/18289
This is one task, that throws a ton of gray text. It walks the NPC towards crops, or has them wander, while it's spawned.
http://mcmonkey.org/haste/18294
This task also throws the same errors, but only about one paragraph on death rather than several pages. It just plays particles near the NPC.
http://mcmonkey.org/haste/18295
What is the best way to handle this?
Cheers, Tea

Actually, I think this has to do with the walk command specifically. It only happens when the NPC is removed while it is walking.
I took a look at dSentry to compare to see how mcmonkey was creating NPC behaviours, and the exact same error is thrown when the dSentry is removed when walking.
The NPCs I'm trying to make spend 90% of their time walking, which explains why I was constantly throwing errors. I think I'm a little out of my league here, is there any way for me to work around this?

This was fixed.


Missing dependencies

I followed the installation guide from https://frappeui.com/getting-started.html, but when I tried to access the URL todo.test:8080/frontend, I encountered an error message that said:

Failed to resolve import '@tiptap/pm/state'
Failed to resolve import 'prosemirror-model'

However, I was able to fix the issue by installing @tiptap/pm and then reloading the /frontend URL, which resolved the problem.

in package.json
"dependencies": {
"@headlessui/vue": "^1.7.8",
"@tiptap/pm": "^2.0.0-beta.210",
"@tiptap/starter-kit": "2.0.0-beta.209",
"@tiptap/vue-3": "2.0.0-beta.209",
"canvas-datagrid": "^0.4.5",
"docx-preview": "^0.1.14",
"dropzone": "^6.0.0-beta.2",
"feather-icons": "^4.29.0",
"frappe-ui": "0.0.101",
"fuzzysort": "^2.0.4",
"mitt": "^3.0.0",
"vue": "^3.2",
"vue-router": "^4.1.6",
"vuex": "^4.1.0",
"xlsx": "^0.18.5"
},
"devDependencies": {
"@vitejs/plugin-vue": "^4.0.0",
"autoprefixer": "^10.4.13",
"postcss": "^8.4.21",
"tailwindcss": "^3.2.4",
"vite": "^4.0"
}

I followed the installation guide from https://frappeui.com/getting-started.html, but when I tried to access the URL todo.test:8080/frontend, I encountered an error message that said:

Failed to resolve import '@tiptap/pm/state'
Failed to resolve import 'prosemirror-model'

However, I was able to fix the issue by installing @tiptap/pm and then reloading the /frontend URL, which resolved the problem.

in package.json
"dependencies": {
"@headlessui/vue": "^1.7.8",
"@tiptap/pm": "^2.0.0-beta.210",
"@tiptap/starter-kit": "2.0.0-beta.209",
"@tiptap/vue-3": "2.0.0-beta.209",
"canvas-datagrid": "^0.4.5",
"docx-preview": "^0.1.14",
"dropzone": "^6.0.0-beta.2",
"feather-icons": "^4.29.0",
"frappe-ui": "0.0.101",
"fuzzysort": "^2.0.4",
"mitt": "^3.0.0",
"vue": "^3.2",
"vue-router": "^4.1.6",
"vuex": "^4.1.0",
"xlsx": "^0.18.5"
},
"devDependencies": {
"@vitejs/plugin-vue": "^4.0.0",
"autoprefixer": "^10.4.13",
"postcss": "^8.4.21",
"tailwindcss": "^3.2.4",
"vite": "^4.0"
}

This is now fixed in latest version


build: relocation: Fix long command-line invocations

For applications relocating big parts of the code with many sections, builds were failing on Windows due to hitting the max command-line length on that platform.
Fix this by using a file to store the dictionary passed to the python script.
Fixes https://github.com/zephyrproject-rtos/zephyr/issues/60994.

@carlescufi - it looks like ThriftTest.tlsTransport test passed on the second try here. The pass frequency for that particular test is about 97% right now (the rest of the suite is fine), so in the next while there might be the occasional retry.
It looks like there might be an xtensa relocation test that is failing.

@dcpleung there was a change missing in a regex, fixed now.


Added Periodic Table

Description
Added the files for displaying a periodic table using HTML and CSS.
Fixes #135

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Explain the Testing instructions
Test Configuration:

Operating system: Windows 10
Version:
Text-editors used: VSCode

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

@Dhruv-194 u can delete Periodic Table/Periodic Table SS.png file

no worries @ankitapuri i will delete it

@Dhruv-194 is this Periodic Table is from codepen ?

@arpit456jain Yes this is from my CodePen project only. I developed this as an Assignment for my college work.


[formrecognizer] Readme update

Fixes #31481

API change check
API changes are not detected in this pull request.


Add two new colorsets: white and black

In addition to the current list of "coloured" color sets (this sounds repetitive), it would come to complement them if Nefertiti for Sphinx had a white and black colorsets, maybe they would in the end be the same but the navbar would be either white or black.

Implemented in release 0.7.0. #47


Add 'from_context' classmethod to node tree

This is how node trees automatically sync to the active material

covered in f6622933dfbb816c5e2f85ea7ee81d7b45626f12


ADC clock configuration

It seems the if you call 'rcc.freeze(rcc::Config::msi(MSIRange::Range5));' and then enable Adc it will just freeze, because there is no clock to it (default is HSI16) and no way to change clock source. For now I just modified CFGR2 manually through unsafe code. Am I missing something?

I encountered the same issue.  To repro, one just needs to modify this line in the adc example to use the MSI clock:
-    let mut rcc = dp.RCC.freeze(Config::hsi16());
+   let mut rcc = dp.RCC.freeze(Config::msi(MSIRange::Range5));

and observe it hang on adc.read.
@romixlab Would you mind sharing your workaround?  I tried:
    // HSI clock is the default, but we are not using it.  Configure ADC to use
    // APB (aka PCLK) clock instead
    p.ADC.cfgr2.modify(|_, w| w.ckmode().pclk_div4());

before ADC::new() but did not work for me.
Thanks!

Well, finally made it work, but was not very ergonomic.  Documenting here for my future self or for others in the same pickle...
    // Enable ADC clock.  This is only needed when using PCLK as ADC clock
    // The alternative is to use HSI16 clock, but system clock is MSI
    p.RCC.apb2enr.modify(|_,w| w.adcen().set_bit());
    // Pick MSI clock for lower power.  Range 5 is 2MHz
    let mut rcc = p.RCC.freeze(Config::msi(MSIRange::Range5));

    // Enable ACD in low frequency mode, needed because we run out of the MSI clock at 2MHz and
    // datasheet says this need to be enabled below 3.5 MHz
    p.ADC.ccr.modify(|_, w| w.lfmen().set_bit());

    // Pick PCKL clock for ADC
    p.ADC.cfgr2.modify(|_, w| w.ckmode().pclk());
    let mut adc = Adc::new(p.ADC, &mut rcc);
    ...

Sorry, couldn't find it, it was a long time ago..

had the same problem, your workaround worked perfectly. thanks @jcard0na
any update on when this gets fixed in hal?


Customizable display utility

At this time, the cqparts.display.display chooses a callable display method based on the detected environment.
Problem
This does not allow the flexibility of new environments:

introduced in the future, or
custom display methods designed by users (that may not be made public)

Solution
Allow env_name to be forced (but detected automatically by default), and the display methods mapped by an environment key value.

In the process of creating a DisplayEnvironment class to handle different environments in which to display models.

Method of setting various display environments using DisplayEnvironment merged in #94


Fix #634: Simplify service worker caching

This depends on (and currently includes) https://github.com/mozilla/brackets/pull/637, so that should land first.
I'm switching how we do our service worker cache to not depend on manual intervention to add new files, or remove old ones.  What we have now is way to easy to mess up, since I'm pretty much the only person who understands it.
I need to figure out the right way to deal with dist/nls/**/* since this new approach is including all strings for all languages in what we cache, which takes the cache up to 5.31 MB for 192 resources from 3.54 MB for 98 resources (I totally missed dist/nls before, so it's amazing it runs at all!)

This is ready for review.  I've dealt with the dist/nls caching, based on advice from people at Google.

This needs to get rebased and landed after #637, which should go in first.

Looks like this still needs to be rebased because it has one extra commit - "Fix review issues, rework ?disableExtensions logic"

OK, I fixed the compress stuff too.  I actually had to compress first, then do the sw cache, and then compress the service worker file; otherwise it caches uncompressed files, which is wrong.
Thanks for the review.


Fix teller run child process docs to pass flags

Update the teller run docs to include -- to ensure flags are passed to child process
Resolves #6

Yup, definitely!! thanks!


Docs: Describe removing ContextExamples in the migration doc

What were you searching in the docs?
In v1, @aws-lambda-powertools/commons had ContextExamples that helped our test coding.
It was written in v1 docs. See https://docs.powertools.aws.dev/lambda/typescript/1.18.1/core/logger/#inject-lambda-context.
It seems to be moved to packages/testing.
Is this related to an existing documentation section?
https://docs.powertools.aws.dev/lambda/typescript/2.0.1/upgrade/
How can we improve?
This breaking change is better to be described in migration docs I think.

Got a suggestion in mind?
Adding new row to the table;
| **Common**            | Removed `ContextExamples` and `Events` that is objects used for testing.                                                       | Yes                  |

Acknowledgment

[X] I understand the final update might be different from my proposed suggestion, or refused.

Hey @yamatatsu
thanks for opening the issue and すみません for removing the dependency you have used, we completely missed this point.
We have moved the tests resources to internal package, so you'd need to create your own context object. This is nothing too complex and you can copy it from our code.
I will update the docs to reflect this change for the future, thanks again for letting us know.


chore(deps): update common-dev-assets digest to 66ecde4

This PR contains the following updates:

Package
Update
Change

common-dev-assets
digest
505d834 -> 66ecde4

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

/run pipeline


Alpha diversity boxplot axis should say metric

Alpha div scatter does this. The boxplot should as well.

Looks good


App will not display any favorite contact groups for a few users.

ISSUE:
When users access the contact group app, they are either presented with a blank page as if they have not saved contact groups or the splash page as if they were a new user.
CAUSE
One of the contact groups that the user had saved to their favorite list was deleted. You can confirm this by reviewing the logs in the Azure application insights for the app. If you query the exceptions app insights you should see an error that displays an error "Request_ResourceNotFound". This error will also display the GUID for the contact group that was not found.
Resolution
In Azure navigate to the storage account for the contact group app. Click on the Storage explorer section to view the tables for the app. Expand the tables section and click on the FavoriteDistributionLists table. Click the query button and remove the  query definition for PartitionKey leaving just the RowKey parameter, update the value with the GUID you found in the Logs and execute the query. This will show you all users that have the deleted contact group saved as a favorite. You can remove the contact group from each user by right clicking on the row and clicking delete.

We have this problem every week or two as a DL is bound to get deleted somewhere in the organization. The resolution posted for this issue works great, but it's reactive and tedious. Any thoughts on how I could identify DLs that get deleted and remove them from the FavoriteDistributionList table before the user calls us? (I've done PowerShell scripts for M365, but I have no experience  doing development in Azure)


Duplicate Constraint fails when I try to save model on Admin Panel

I am getting this error when I change the tenant and save the model through admin panel:

How can I resolve this error?

Check to make sure the postgresql sequence that was created to add an ID for that table is set correctly and the next ID is Max(id)+1
Or it could be that you tried to update the id manually.
You can reset it using the following:
SELECT setval('tablename_id_seq', (SELECT COALESCE(max(id),0)+1 FROM "tablenames"), false);


Fixing: Logfile with lower loglevel than console output

This fixes the issue described in #57.
To sum it up briefly:
The loglevel of a Handler added to a logger object is limited to be equal to or higher than the
loglevel of the logger object. Previously the logger objects loglevel was always set to the loglevel of
the corresponding StreamHandler. This meant that the loglevel a later defined logfile could not be lower.
This 'fix' is the easiest I could come up with and has very minimal changes to the code. It sets the loglevel of the logger object by default to DEBUG, the (by default) lowest logging level.

Any news here?
cheers mathias

Thanks for submitting this PR, and with a test too! It is now superseded by #339 therefore closing this. Feel free to reopen if there are any issues or improvements over the other <3


Add all token owners from zkApps

Token owners are only getting added when accounts are added to the ledger.
We want token owners added even when a zkApp fails, and accounts are not added to the ledger.

See #12809.

#12841 has a better solution.


Bundle the configproxy

In the same way that jupyterhub launches the configproxy in the same container, we should do that here as well to make operations simpler.

If both processes are in the same container, what would the container entrypoint (PID 1) be?

tmpnb / orchestrate.py. This is what JupyterHub does. I liked having it broken out personally, but it seemed like people had trouble with running multiple services.

I like having it broken out too, but I don't have an argument against combining to one container in light of the fact that the CHP does not retain state after a restart. If it did, then I'd suggest it remain separate, or at least separable.


Support for a custom syslog forwarder job

I'd like to provide some custom syslog config and use the metron agent.  Though currently it seems metron agent takes over all syslog forwarding config of vcap* messages since it is config 00 and contains :programname, startswith, "vcap." ~
Any interest in accepting a PR that either make disposal of all vcap.* message optional, changes syslog_forwarder config to something like 05 instead of 00, or breaks the syslog forwarder config out into a separate job?  So I can simply replace that job with my custom one?
I'd be happy to submit a PR for any of the above.  Thoughts?

Nevermind.  I discovered that syslog config 0 is ahead of 00.  Though ugly I'll be fine using 0 until I have to rewrite this to support component syslog going through the firehose.


Fix tests and add auto_clean.sh script

test suite is 'fixed' most of the failing tests are skipped
flake8 errors have been fixed, C901 error (complexity) is ignored
add isort/autopep8 and wrap them in a auto_clean.sh script

Changes Unknown when pulling 10dd3eb03a1d0babbc7c3e58595f9b58294e16cd on dodobas:fix-tests into ** on healthsites:develop**.

Changes Unknown when pulling b4ea6cc209655c83bffba7b5a949d7d9881295f3 on dodobas:fix-tests into ** on healthsites:develop**.

Changes Unknown when pulling 33bb765f2c002813dd3647369b5a60d57fdc9e94 on dodobas:fix-tests into ** on healthsites:develop**.

Changes Unknown when pulling d9e4da8debab9405c6bc3f75a5f53fbd1ca902b8 on dodobas:fix-tests into ** on healthsites:develop**.


[Feature Request] Turn off charging when batt hits 95%

via Kasa (TP-Link) or ?

Jay Fornow on on Facebook says:
It's a simple formula.
The amount of minutes to set in timer = (Y - Z) x 22.5 seconds /60 seconds
Y=Desired Percentage
Z=Current Battery Percentage.
For example: If I want to stop charging the battery at 96% and current charge is 40%.
(96-40)x 22.5/60= 21 minutes

Looks like we can connect to Kasa via IFTTT.com

Oh wow, interesting... yeah we can add intents/broadcasts/a service?/tasker integration etc for the stats, not sure what we can do past that. For what it's worth, I have a raspberry pi running home assistant for controlling/automating my house and created a sensor, a script, that uses ble tools to pull the % directly. Then I can create actions based on that, like turning off the charging.

onewheel_stats.py
#!/usr/bin/env python3
import argparse,subprocess

text = 'This program returns stats from an Onewheel BLE device'
parser = argparse.ArgumentParser(description = text)
parser.add_argument("address",help="mac address of device")
parser.add_argument("--battery", help="get battery level",action="store_true")
args = parser.parse_args()

if __name__ == "__main__":
    if args.battery:
        p = subprocess.Popen("/usr/bin/gatttool -b {0} --char-read --handle=0x0021".format(args.address), stdout=subprocess.PIPE, shell=True)
        (output, err) = p.communicate()
        p_status = p.wait()

        p_out = output.decode('ascii').split()
        if len(p_out) > 0:
            r = '{0}{1}'.format(p_out[2],p_out[3])
            print(int(r,16))
        else:
            print(-1)

Hmm also the protocol used for the smart plug been reversed engineered https://github.com/softScheck/tplink-smartplug/blob/master/tddp-client/tddp-client.py - so there is the possibility of adding a shared preference option of "if battery level gets to 100% tell smart plug at <IP_ADDRESS> to turn off". That being said, connecting into IFTTT would open it up to their services and broader triggers etc. Might be a bit of work to getting the OW app added as a "service", a workflow that would work would be creating a custom notification of battery % and use the IFTTT "android device" service & "Notification received from a specific app" -> "Filter by notification keyword".


Add support for PNG icons and icon packs

Icons have also been renamed as per XDG specifications

I would need help in form of code for PNG, it wasn't easy for me to get it working. Or you could drop the PNG commit.

I'll PR again when I get time to fix this.


[Suggestion]Two contributing buttons at the top right of doc pages link to milvus repo instead of docs repo

Note: This repository is ONLY used to solve issues related to DOCS.
For other issues, please move to other repositories.

Is there anything that's missing or inappropriate in the docs? Please describe.
Currently we have "Edit this page", "Discuss it on GitHub", and "Report a bug" at the top right section of each doc page, but the latter two both lead to the milvus repo instead of the milvus-docs repo.
Describe your suggestion

We need to provide a link to direct our audience to submit a doc issue.
The issue submission window automatically has the relevant page name in the issue title block.
The link opens the web page in a new tab.

Additional reference
https://www.cockroachlabs.com/docs/cockroachcloud/quickstart.html

https://github.com/milvus-io/milvus.io/pull/666


Multistage builds for our Docker images

This issue is to track the work discussed with @taharah here: https://github.com/deepmind/kapitan/pull/359#discussion_r323043154

Closing this as fixed by https://github.com/deepmind/kapitan/pull/370


IBM.com style model research part 2

Notes
In order to support our adopters and help them make the best decisions re: style models for ibm.com, we need to identify and communicate design research best practices.
Problem
When designers are tasked with designing ibm.com experiences, they don't always know where to start. Design research can provide insights and best practices for designers to follow and apply to their work. IBM has robust user research tools but less design (visual, UX, interaction) guidelines.
Additional Information

This issue is for additional research work.  Additional research issues are:  Issue (#1538)

Tasks

Map out design research flow/steps
Identify existing tools and resources that designers can use to get started
Propose new methods or tools that we need to provide
Consider how this fits into style model, library, system etc.

Continuing this work in Mural.

Similar to last sprint for part 1, I'm considering my work for this part 2 story complete (1 story point). This work will need to continue.


bug fixes

Environment
Windows build number: [run `[Environment]::OSVersion` for powershell, or `ver` for cmd]
Windows Terminal version (if applicable):

Any other software?

Steps to reproduce

Expected behavior

Actual behavior

We can’t do anything if you don’t give us any information.


Smooth the animation.

The simulation appears choppy. Improve the animation by fading cells easing new cells into existence.

This is dependent on issue #5.


[WIP] Removed mobiledoc format from Content V2 API response

closes #10097

Removed mobiledoc format from content API v2 input serializer

@rishabhgrg When is the PR ready for review? Tomorrow morning would be great. Thanks :)

@kirrg001 👍 Just want to use the isContentAPI util here from this PR, all ready otherwise 😄 Will


#275 Heroku

Resolves #275 (and #1104), needs to be squashed but appears to be fully functional :-).
Things I have not yet tested:

LDAP
CAS

Please also look over the changes to the custom buildpack (i.e. my commits) as well, thanks!

this all looks excellent

In terms of the login credentials, I noted them in the wiki page but you're right, if you're just coming from the repo it won't be clear (even though you'll likely have to visit the wiki page to deal with the configuration stuff).
I'm fine to default to no seeding / requiring app:setup, we'll just have to update our documentation accordingly. I just figured that since you were clicking a "Deploy to Heroku" button to get your instance started, you'd probably start fresh if you wanted to deploy for real and this would be more oriented towards people who just want to mess around, hence, `rake db:seed

Note to self, once #1115 is merged in, update the lib/tasks/scheduler.rake to include the new rake task to send e-mails for missed reservations.

I made the above change; I'd like to hold off on merging this in until #1146 and #1116 are merged in just to offset any merge conflicts.

@squidgetx: are you good with leaving rake db:seed running by default with the Heroku button and allowing for proper setup using rake app:setup via the command line if you want to deploy a local instance? I don't think we should assume that someone clicking the Heroku button will necessarily be comfortable on the command line (e.g. we're providing users with the ability to spin up demo instances), so I'd rather avoid it for Heroku button users. I'll make a note at the end of the wiki page that explains how to clear the database if you want to start fresh and I think that should cover all of our use cases. Does that make sense?
Let me know how this all looks (now that I addressed my comment) and if I should squash commits. Thanks!

Sounds good to me; squash + merge!

On second thought, I want to test both CAS and LDAP, here we go!

Ok, CAS works perfectly :-D

:shipit: :shipit: :shipit:

LDAP isn't working right now :-(. Not sure if it's Heroku or just master :-P

BTW, merged in the #1116 changes and it looks really nice :smile:

Yale LDAP lookup isn't working, and I don't know of another service I can use to test it. Anyone have any ideas?

You mean LDAP isn't working on heroku-deployed instances? Seems to make sense right, since LDAP just doesn't work anyway when not on a Yale server

So that's not quite true. You can't do NetID-based lookups from outside Yale, but you should be able to do e-mail based lookup (according to @dgoerger). I'm switching off CAS and seeing if that helps.

Ok, I think this is all good. Can someone please do a quick final review and merge? Thanks!

Yup, you can look up by email like this from a linux terminal:
ldapsearch -LLL -x -h directory.yale.edu -b o=yale.edu mail=$EMAIL_ADDRESS

Changing the login field for CAS-auth from NetID to email address probably makes sense anyway, given non-CAS auth uses email, right?

We're (probably I'm) going to try and make CAS and non-CAS auth live happily together (see #1106), hopefully in v5.2.0. We could just switch all LDAP lookups to e-mail, I'll add a note there.

Ok, resolved a merge commit due to #1110, ready for final review / merge.

Did you mean to commit the bin directory?

Yup, see here

Okay. I left one super minor inline comment, otherwise this is ready for merge

Thanks! Issue resolved, just re-squashing and then I'll merge :smile:

cool


Please add the message that the user gets with the feature enabled

[Enter feedback here]
Please add a note for the below in the article which will help administrators in validating that the proxy in their environment is configured to make of tenant restrictions feature.
When this feature is enabled by having the proxy inject the headers Restrict-Access-To-Tenants, Restrict-Access-Context, the user trying to access a resource from a tenant that is not part of the Restrict-Access-To-Tenants, the user ideally will get the below message

Additionally, if we review the sign-in logs in Azure AD then we should authentication with the status as a 'Failure' and with a sign-in error code of '500021'. The failure reason will be listed as 'Access to '{tenant}' tenant is denied.'
Status	Failure
Sign-in error code	500021
Failure reason	Access to '{tenant}' tenant is denied.
Additional Details	Please contact your IT department.
We do not have any documentation for the sign-in error code of 500021 and so adding the above as a note will help customers.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 89ea5c2d-4602-25b8-3cdd-60cfb5c31895
Version Independent ID: 35d4af7e-72e4-7c40-9dd6-b8490ee73f0d
Content: Use tenant restrictions to manage access to SaaS apps - Azure AD
Content Source: articles/active-directory/manage-apps/tenant-restrictions.md
Service: active-directory
Sub-service: app-mgmt
GitHub Login: @kenwith
Microsoft Alias: kenwith

@rrajan82 Thanks for the feedback! We are taking a look into this and will get back to you soon.

@rrajan82 Thanks for the feedback! We are taking a look into this and will get back to you soon.

@rrajan82 This error code can be searched here: https://login.microsoftonline.com/error

@rrajan82 This error code can be searched here: https://login.microsoftonline.com/error


Basic supports for backfilling compressed whisper files

Will merge this changes soon unless objected. :)

LGTM, feel free to merge.


[Android] update android package versions

Description
Prepare DJL 0.17.0 Android releases

Codecov Report

Merging #1635 (274b6aa) into master (bb5073f) will decrease coverage by 1.23%.
The diff coverage is 62.14%.

@@             Coverage Diff              @@
##             master    #1635      +/-   ##
============================================
- Coverage     72.08%   70.85%   -1.24%
- Complexity     5126     5432     +306
============================================
  Files           473      507      +34
  Lines         21970    23769    +1799
  Branches       2351     2589     +238
============================================
+ Hits          15838    16841    +1003
- Misses         4925     5638     +713
- Partials       1207     1290      +83

Impacted Files
Coverage Δ

api/src/main/java/ai/djl/modality/cv/Image.java
69.23% <ø> (-4.11%)
:arrow_down:

...i/djl/modality/cv/translator/BigGANTranslator.java
21.42% <ø> (-5.24%)
:arrow_down:

...odality/cv/translator/BigGANTranslatorFactory.java
33.33% <0.00%> (+8.33%)
:arrow_up:

...nslator/InstanceSegmentationTranslatorFactory.java
14.28% <0.00%> (-3.90%)
:arrow_down:

.../modality/cv/translator/YoloTranslatorFactory.java
8.33% <0.00%> (-1.67%)
:arrow_down:

...i/djl/modality/cv/translator/YoloV5Translator.java
5.69% <0.00%> (ø)

...odality/cv/translator/YoloV5TranslatorFactory.java
8.33% <0.00%> (-1.67%)
:arrow_down:

...pi/src/main/java/ai/djl/ndarray/BytesSupplier.java
54.54% <0.00%> (-12.13%)
:arrow_down:

api/src/main/java/ai/djl/ndarray/NDArray.java
78.40% <ø> (+1.13%)
:arrow_up:

...ain/java/ai/djl/ndarray/index/dim/NDIndexPick.java
100.00% <ø> (ø)

... and 242 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9072ad0...274b6aa. Read the comment docs.


Clarify Information

The "Effective Values" section does not cover the behavior for when request_min_resource_grant_percent is less than the effective request_min_resource_grant_percent. Is it automatically increased to the effective request_min_resource_grant_percent? My sys.workload_management_workload_groups table contains request_min_resource_grant_percent values that are below their effective value. This applies to the default workload groups (associated with resource classes) as well.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d79ae973-3a8a-0456-b618-fc23ab8dfe09
Version Independent ID: 4cc8fa7c-af8f-7732-a188-75a70e7ba1c8
Content: CREATE WORKLOAD GROUP (Transact-SQL) - SQL Server
Content Source: docs/t-sql/statements/create-workload-group-transact-sql.md
Product: sql
Technology: t-sql
GitHub Login: @julieMSFT
Microsoft Alias: jrasnick

@potato-enthusiast: apologies for the delayed response on this.  The values are automatically adjusted.  See the sys.dm_workload_management_workload_groups_stats DMV for further details.  A new doc update is being published that should make this more clear.

#please-close