bosh v2 cli seems to break blobs.yml for v1 cli users

Hi Bosh,
We hit an interesting issue when adding blobs to our release yesterday. We're at the start of a v2 cli migration across the team - some developers have v2 installed whilst others are still using v1, and as yet our CI is still using v1.
A developer with v2 successfully added a new blob to the release, and committed the blobs.yml update to source control. Since this was the first time v2 had been used to update blobs.yml, we noted that the keys within the yaml maps in that file had been re-ordered. We didn't think should matter to anything, so shrugged and continued.
Our CI job then ran, which uses v1 to update two blobs in the release to new versions (artifacts generated in the previous build step).
This resulted in blobs.yml being corrupted and bosh add blob failing:
Adding blob /tmp/build/660fa31b/artifacts/spring-cloud-service-broker-1.5.0-build.85.jar to spring-cloud-service-broker
Incorrect YAML structure in '/tmp/build/660fa31b/scs-broker-release/config/blobs.yml': Found duplicate key 'object_id'

So it seems that v1 is not able to modify a blobs.yml which has already been processed by v2. To fix this, we had to revert the commit, re-add the new blob with bosh cli v1, and then re-commit.
Clearly this wouldn't be a problem if we were using v2 across the board, but it does mean that it's tricky to migrate over to v2 in a non big-bang style, which is hard to synchronise across large teams and multiple CI pipelines etc. We wondered if, to help people out with migration, either the bosh v1 cli could be updated to be agnostic to the blobs.yml key ordering, or v2 could be updated to generate blobs.yml with the same key ordering as v1?

can include what that problematic blobs.yml looks like?
Sent from my iPhone

On Oct 19, 2017, at 4:23 AM, Gareth Clay<EMAIL_ADDRESS>wrote:
Hi Bosh,
We hit an interesting issue when adding blobs to our release yesterday. We're at the start of a v2 cli migration across the team - some developers have v2 installed whilst others are still using v1, and as yet our CI is still using v1.
A developer with v2 successfully added a new blob to the release, and committed the blobs.yml update to source control. Since this was the first time v2 had been used to update blobs.yml, we noted that the keys within the yaml maps in that file had been re-ordered. We didn't think should matter to anything, so shrugged and continued.
Our CI job then ran, which uses v1 to update two blobs in the release to new versions (artifacts generated in the previous build step).
This resulted in blobs.yml being corrupted and bosh add blob failing:
Adding blob /tmp/build/660fa31b/artifacts/spring-cloud-service-broker-1.5.0-build.85.jar to spring-cloud-service-broker
Incorrect YAML structure in '/tmp/build/660fa31b/scs-broker-release/config/blobs.yml': Found duplicate key 'object_id'
So it seems that v1 is not able to modify a blobs.yml which has already been processed by v2. To fix this, we had to revert the commit, re-add the new blob with bosh cli v1, and then re-commit.
Clearly this wouldn't be a problem if we were using v2 across the board, but it does mean that it's tricky to migrate over to v2 in a non big-bang style, which is hard to synchronise across large teams and multiple CI pipelines etc. We wondered if, to help people out with migration, either the bosh v1 cli could be updated to be agnostic to the blobs.yml key ordering, or v2 could be updated to generate blobs.yml with the same key ordering as v1?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Sorry @cppforlife, this turns out to be a problem on our side. It turns out we do some pre-processing of blobs.yml - removing old blobs - before using bosh v1 to add new ones. That removal step breaks with the bosh v2 key ordering, and then hands bosh v1 a broken file to work on.
When we jump to bosh v2 across the board we'll replace that broken script with bosh remove-blob. Sorry for hassling you with this one!


[FLINK-19888][hive] Migrate Hive source to FLIP-27 source interface for streaming

What is the purpose of the change
Migrate hive streaming read to FLIP-27 source.
Brief change log

Make file source more extensible by changing method/field access modifiers of AbstractFileSource, ContinuousEnumerationSettings and PendingSplitsCheckpoint.
Implement ContinuousHivePendingSplitsCheckpoint as sub-class of PendingSplitsCheckpoint. It keeps the max current partition read timestamp, and the processed partitions for this timestamp.
Implement ContinuousHivePendingSplitsCheckpointSerializer as the SerDe for ContinuousHivePendingSplitsCheckpoint.
Implement ContinuousHiveSplitEnumerator as the SplitEnumerator for reading partitioned table in streaming fashion.
Change HiveSource to create/restore ContinuousHiveSplitEnumerator to do streaming read on partitioned tables.
Change HiveTableSource to use HiveSource for streaming read.

Verifying this change
Existing streaming read tests
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): yes
The serializers: yes
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? NA

Hi @JingsongLi @StephanEwen , this is the PR to migrate hive source to FLIP-27 for streaming read. And I noted some file source classes need to be more extensible to support that. I put those changes in this commit. Let me know if you think it's OK. Thanks.

Test failure seems unrelated and my personal pipeline passed: https://dev.azure.com/lirui-apache/flink/_build/results?buildId=293&view=results

Thanks @StephanEwen and @JingsongLi for the review. I have updated and addressed your comments. Please have another look, thanks!


Error  while train

error happened while training, hope you can help me
Traceback (most recent call last):
File "train/cityscapes-psp_net/train2.py", line 252, in
main()
File "train/cityscapes-psp_net/train2.py", line 110, in main
train(train_loader, net, criterion, optimizer, curr_epoch, args, val_loader, restore_transform, visualize)
File "train/cityscapes-psp_net/train2.py", line 159, in train
validate(val_loader, net, criterion, optimizer, curr_epoch, train_args, restore, visualize)
File "train/cityscapes-psp_net/train2.py", line 182, in validate
outputs,aa = net(inputs)
File "/usr/local/lib/python2.7/dist-packages/torch/nn/modules/module.py", line 224, in call
result = self.forward(*input, **kwargs)
File "/home/htjiang/Desktop/pytorch-semantic-segmentation/models/psp_net.py", line 79, in forward
x = self.final(x)
File "/usr/local/lib/python2.7/dist-packages/torch/nn/modules/module.py", line 224, in call
result = self.forward(*input, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/torch/nn/modules/container.py", line 67, in forward
input = module(input)
File "/usr/local/lib/python2.7/dist-packages/torch/nn/modules/module.py", line 224, in call
result = self.forward(*input, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/torch/nn/modules/conv.py", line 254, in forward
self.padding, self.dilation, self.groups)
File "/usr/local/lib/python2.7/dist-packages/torch/nn/functional.py", line 52, in conv2d
return f(input, weight, bias)
RuntimeError: CUDNN_STATUS_INTERNAL_ERROR

Try to comment the line “cudnn.benchmark=True” and run again.

@ZijunDeng  “cudnn.benchmark=True” is already wrotten in the code,i will try false


Class initialization issue with redisson 3.23.3 on Java 1.8

Expected behavior
The program to start.
Actual behavior
The program exits with java.lang.NoClassDefFoundError: Could not initialize class org.redisson.config.Config
Steps to reproduce or test case

Use java 8 version, I used SDK to choose 8.0.372-amzn
Use Redisson versioin 3.23.3, I used sbt so the syntax looks like this: "org.redisson" % "redisson" % "3.23.3"

Redis version
7.0.12
Redisson version
3.23.3
Redisson configuration
This is how we initialize the config, it is the first line that throws the error actually:
    val redisClientConfig = new redisson.config.Config()
    redisClientConfig
      .setNettyThreads(0) // number of processors * 2
      .useSingleServer()
      .setAddress(formattedConnectionString)
      .setConnectionMinimumIdleSize(settings.minPoolSize)
      .setConnectionPoolSize(settings.maxPoolSize)
      .setTimeout(settings.timeout)
      .setDnsMonitoringInterval(settings.dnsCacheCheckInterval)

    Redisson.create(redisClientConfig)

Here is how are redis settings look in HOCON:
  redis {
    host = "localhost"
    host = ${?PRODUCTION_ENDPOINT}
    port = 6379
    min-pool-size = 10
    max-pool-size = 30
    timeout-ms = 10000
    dns-check-interval-in-ms = 10000
  }

Not that the issue goes away and the code runs once I use java 11+ (I've also successfully tried 17). Successful versions were in particular: 11.0.19-tem and 17.0.7-tem.

What was the cause?

What was the cause?

I don't have access to that code base now so I can't go back to that commit.., but it was something related to multiple sbt modules and a different dependency.


Try to expose the gorm API

NGORM is not intending to be 100% API compatible with gorm. One aspect which ngorm emphasis is error handling. Errors must be handled, so any operation that might result into an error returns an error.
So, many functions should be familiar with gorm, it is just how they are implemented differs. So, this is the list of API for DB that must pe implemented by ngorm.
I discourage heavy use of chaining.Only when it is necessary to chain then chain.


[Dubbo-5215] get & set & remove in org.apache.dubbo.common.utils.Stack take no consideration that index plus mSize is negative

What is the purpose of the change
fix #5215
Brief changelog
XXXXX
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #5231 into master will increase coverage by 0.54%.
The diff coverage is 96.77%.

@@             Coverage Diff              @@
##             master    #5231      +/-   ##
============================================
+ Coverage     63.57%   64.11%   +0.54%
+ Complexity      463      462       -1
============================================
  Files           791      770      -21
  Lines         35225    33399    -1826
  Branches       5503     5262     -241
============================================
- Hits          22394    21414     -980
+ Misses        10302     9559     -743
+ Partials       2529     2426     -103

Impacted Files
Coverage Δ
Complexity Δ

...main/java/org/apache/dubbo/common/utils/Stack.java
96.77% <96.77%> (ø)
0 <0> (ø)
:arrow_down:

...che/dubbo/remoting/transport/mina/MinaChannel.java
43.42% <0%> (-10.53%)
16% <0%> (-1%)

...ng/transport/dispatcher/all/AllChannelHandler.java
51.42% <0%> (-5.72%)
0% <0%> (ø)

...mmon/threadpool/support/AbortPolicyWithReport.java
83.78% <0%> (-5.41%)
0% <0%> (ø)

.../org/apache/dubbo/remoting/ExecutionException.java
15.78% <0%> (-5.27%)
0% <0%> (ø)

.../apache/dubbo/remoting/transport/AbstractPeer.java
63.04% <0%> (-4.35%)
0% <0%> (ø)

...he/dubbo/remoting/transport/netty/NettyServer.java
70.17% <0%> (-3.51%)
8% <0%> (-1%)

...exchange/support/header/HeaderExchangeHandler.java
64.75% <0%> (-2.46%)
0% <0%> (ø)

.../dubbo/remoting/transport/netty4/NettyChannel.java
64.77% <0%> (-2.28%)
0% <0%> (ø)

.../exchange/support/header/HeaderExchangeServer.java
66.98% <0%> (-1.89%)
0% <0%> (ø)

... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20351b0...474c7c8. Read the comment docs.


Allow measuring custom cells

In the current state, custom cells cannot be measured and are not auto-sized. This PR removes a check that does not seem to be required anymore:
https://github.com/glideapps/glide-data-grid/blob/c9e1f3df5d545171ccca2226c0c55e253fb6cc83/packages/core/src/data-editor/use-column-sizer.ts#L24
Closes: https://github.com/glideapps/glide-data-grid/issues/648

Resolved by https://github.com/quicktype/glide-data-grid/commit/525f94e1a989b035c57da386e4d15b99cfc39571


Yungez integrationtest

add integration test for spring data document db.
@xscript  @aovechki @ZhijunZhao

@yungez,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

Leave a comment

@yungez,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

Codecov Report

Merging #61 into master will increase coverage by 17.77%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           master      #61       +/-   ##
===========================================
+ Coverage   50.34%   68.11%   +17.77%
===========================================
  Files          24       24
  Lines         435      436        +1
  Branches       43       43
===========================================
+ Hits          219      297       +78
+ Misses        195      106       -89
- Partials       21       33       +12

Impacted Files
Coverage Δ

...pring/data/documentdb/core/DocumentDbTemplate.java
65.92% <100%> (+56.97%)
:arrow_up:

...zure/spring/data/documentdb/DocumentDbFactory.java
25% <0%> (+6.25%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fe1fb2...74ad045. Read the comment docs.


Suggestion - Data Folder location selection

Suggestion to allow the user to pick the desired Data Folder path during wallet installation phase.
Another work-around (Windows OS)

Create a shortcut of VERGE-qt.exe
Right click on the created shortcut then Properties , add the following line at Target path:

-datadir=DRIVE:\DATA_FOLDER_PATH
Example:
Target: " D:\verge-3.0\VERGE-qt.exe " -datadir=DRIVE:\DATA_FOLDER_PATH
Drive: Drive where data folder is located (D: E: F: etc..)
DATA_FOLDER_PATH: Exact location of the desired Data folder

I can get it working for linux daemon, it will work?

Closing issue -- since Verge really isn't an "installation" and more of an "unzip these 2 files" :smile:   If Verge ever moves into an "installation" like some of the other QT Wallets, I'm sure code to include custom data directory will be involved.
But for now you got the right idea  on the workaround --- run it with a -datadir=


Deque subscript _modify accessor heap allocates

Consider the following simple function (the operation is not useful, it's just intended to be complex enough to defeat being optimized away and simple enough to make the generated assembly simple):
func twiddle(index: Int, twiddle: UInt8, deque: inout Deque<UInt8>) {
    deque[index] ^= twiddle
}

When compiled in release mode using swift-collections 1.0.2 and current main (c3fdcf7), this generates the following assembly on my arm64 Mac:
_$s18alloc_modify_repro10DequeReproV7twiddle5indexAD5dequeySi_s5UInt8V0D6Module0D0VyAHGztFZTf4nnnd_n:        // function signature specialization <Arg[3] = Dead> of static alloc_modify_repro.DequeRepro.twiddle(index: Swift.Int, twiddle: Swift.UInt8, deque: inout DequeModule.Deque<Swift.UInt8>) -> ()
sub        sp, sp, #0x40                               ; CODE XREF=_$s18alloc_modify_repro10DequeReproV4mainyyFZTf4d_n+208
stp        x20, x19, [sp, #0x20]
stp        fp, lr, [sp, #0x30]
add        fp, sp, #0x30
mov        x19, x1
mov        x1, x0                                      ; argument #2 for method _$s11DequeModule0A0VyxSiciMs5UInt8V_Tg5
mov        x0, sp                                      ; argument #1 for method _$s11DequeModule0A0VyxSiciMs5UInt8V_Tg5
mov        x20, x2
bl         _$s11DequeModule0A0VyxSiciMs5UInt8V_Tg5     ; generic specialization <Swift.UInt8> of DequeModule.Deque.subscript.modify : (Swift.Int) -> A
mov        x8, x0
ldrb       w9, [x1]
eor        w9, w9, w19
strb       w9, [x1]
mov        x0, sp
mov        w1, #0x0
blr        x8
ldp        fp, lr, [sp, #0x30]
ldp        x20, x19, [sp, #0x20]
add        sp, sp, #0x40
ret

As you can see, _modify has not been inlined but it has been specialized. As a result, the call to the continuation has been split and delayed (visible as blr x8).
_modify has compiled to:
_$s11DequeModule0A0VyxSiciMs5UInt8V_Tg5:        // generic specialization <Swift.UInt8> of DequeModule.Deque.subscript.modify : (Swift.Int) -> A
stp        x24, x23, [sp, #-0x40]!                     ; CODE XREF=_$s18alloc_modify_repro10DequeReproV7twiddle5indexAD5dequeySi_s5UInt8V0D6Module0D0VyAHGztFZTf4nnnd_n+32
stp        x22, x21, [sp, #0x10]
stp        x20, x19, [sp, #0x20]
stp        fp, lr, [sp, #0x30]
add        fp, sp, #0x30
mov        x21, x1
mov        x22, x0
mov        w0, #0x28                                   ; argument "size" for method imp___stubs__malloc
bl         imp___stubs__malloc                         ; malloc
str        x0, [x22]
stp        x21, x20, [x0]
tbnz       x21, 0x3f, loc_100012600

mov        x19, x0
ldr        x23, [x20]
mov        x0, #0x0
bl         _$sSo10HeapObjectVMa                        ; type metadata accessor for __C.HeapObject
ldr        x8, [x23, #0x18]
cmp        x8, x21
b.le       loc_100012604

add        x22, x19, #0x20
mov        x0, x23                                     ; argument "arg0" for method imp___stubs__swift_isUniquelyReferenced_nonNull_native
bl         imp___stubs__swift_isUniquelyReferenced_nonNull_native ; swift_isUniquelyReferenced_nonNull_native
tbnz       w0, 0x0, loc_1000125b0

bl         _$s11DequeModule0A0V8_StorageV15_makeUniqueCopyyyFs5UInt8V_Tg5 ; generic specialization <Swift.UInt8> of DequeModule.Deque._Storage._makeUniqueCopy() -> ()

loc_1000125b0:
ldr        x8, [x20]                                   ; CODE XREF=_$s11DequeModule0A0VyxSiciMs5UInt8V_Tg5+88
ldr        x9, [x8, #0x20]!
str        x9, [x19, #0x10]
add        x9, x9, x21
ldur       x10, [x8, #-0x10]
str        x10, [x19, #0x18]
cmp        x9, x10
csel       x10, xzr, x10, lt
sub        x9, x9, x10
add        x8, x8, x9
ldrb       w8, [x8, #0x8]
strb       w8, [x19, #0x20]
adr        x0, #0x100012608
nop
mov        x1, x22
ldp        fp, lr, [sp, #0x30]
ldp        x20, x19, [sp, #0x20]
ldp        x22, x21, [sp, #0x10]
ldp        x24, x23, [sp], #0x40
ret

loc_100012600:
brk        #0x1                                        ; CODE XREF=_$s11DequeModule0A0VyxSiciMs5UInt8V_Tg5+44

loc_100012604:
brk        #0x1                                        ; CODE XREF=_$s11DequeModule0A0VyxSiciMs5UInt8V_Tg5+72

Notice the call to malloc at the start of the function. This call drastically dominates the performance of _modify, and it makes Deque extremely difficult to use in performance sensitive code.
Information

Package version: 1.0.2 or main (c3fdcf7)
Platform version: 21G83
Swift version: swift-driver version: 1.45.2 Apple Swift version 5.6.1 (swiftlang-<IP_ADDRESS>3.66 clang-13<IP_ADDRESS>) Target: arm64-apple-macosx12.0

Checklist

[X] If possible, I've reproduced the issue using the main branch of this package.
[X] I've searched for existing GitHub issues.

Steps to Reproduce
Use the above code sample in an empty Swift project that depends on swift-collections.
Expected behavior
No allocations in _modify.
Actual behavior
A direct call to malloc and a subsequent call to free.

The latest nightly build on Linux successfully inlines the _modify accessor into the calling code, and as a result the malloc is optimised out. This seems pretty fragile to me based on the current code.

(Latest nightly on Linux is swift-DEVELOPMENT-SNAPSHOT-2022-08-18-a.

The same is true in the latest nightly on macOS, the _modify accessor inlines.

The 5.7 nightlies, however, still allocate.

I wonder what change in the compiler made it capable of inlining this and optimizing out the malloc. Might be worth making sure that there was an adequate test case added in whatever PR that was in the compiler repo to ensure this optimization doesn’t regress.

We have very limited options here to work around this. Would marking the accessor @inline(__always) help here?

Hm, force-inlining the accessor does appear to help in Release builds. The code size implications are somewhat worrying, but I'm not sure what else can we do on this end.
I can try moving the preparations & cleanup into separate inlinable functions, perhaps that would be enough.

Yep, that seems to help:
  @inlinable
  public subscript(index: Int) -> Element {
    ...
    @inline(__always) // https://github.com/apple/swift-collections/issues/164
    _modify {
      precondition(index >= 0 && index < count, "Index out of bounds")
      var (slot, value) = _prepareForModify(at: index)
      defer {
        _finalizeModify(slot, value)
      }
      yield &value
    }
  }

  @inlinable
  internal mutating func _prepareForModify(at index: Int) -> (_Slot, Element) {
    _storage.ensureUnique()
    // We technically aren't supposed to escape storage pointers out of a
    // managed buffer, so we escape a `(slot, value)` pair instead, leaving
    // the corresponding slot temporarily uninitialized.
    return _storage.update { handle in
      let slot = handle.slot(forOffset: index)
      return (slot, handle.ptr(at: slot).move())
    }
  }

  @inlinable
  internal mutating func _finalizeModify(_ slot: _Slot, _ value: Element) {
    _storage.update { handle in
      handle.ptr(at: slot).initialize(to: value)
    }
  }

DequeTests`specialized DequeTests.twiddle(index:twiddle:deque:):
    0x105d07fcc <+0>:   sub    sp, sp, #0x40
    0x105d07fd0 <+4>:   stp    x22, x21, [sp, #0x10]
    0x105d07fd4 <+8>:   stp    x20, x19, [sp, #0x20]
    0x105d07fd8 <+12>:  stp    x29, x30, [sp, #0x30]
    0x105d07fdc <+16>:  add    x29, sp, #0x30
    0x105d07fe0 <+20>:  tbnz   x0, #0x3f, 0x105d0803c    ; <+112> [inlined] Swift runtime failure: precondition failure at <compiler-generated>
    0x105d07fe4 <+24>:  mov    x20, x2
    0x105d07fe8 <+28>:  mov    x19, x1
    0x105d07fec <+32>:  mov    x21, x0
    0x105d07ff0 <+36>:  ldr    x22, [x2]
    0x105d07ff4 <+40>:  mov    x0, #0x0
    0x105d07ff8 <+44>:  bl     0x105d0345c               ; type metadata accessor for __C.HeapObject
    0x105d07ffc <+48>:  ldr    x8, [x22, #0x18]
    0x105d08000 <+52>:  cmp    x8, x21
    0x105d08004 <+56>:  b.le   0x105d08040               ; <+116> [inlined] Swift runtime failure: precondition failure at <compiler-generated>
    0x105d08008 <+60>:  add    x0, sp, #0x8
    0x105d0800c <+64>:  mov    x1, x21
    0x105d08010 <+68>:  bl     0x105d0f4ec               ; generic specialization <Swift.UInt8> of DequeModule.Deque._prepareForModify(at: Swift.Int) -> (DequeModule._DequeSlot, A) at <compiler-generated>
->  0x105d08014 <+72>:  ldrb   w8, [sp, #0x8]
    0x105d08018 <+76>:  ldr    x9, [x20]
    0x105d0801c <+80>:  eor    w8, w8, w19
    0x105d08020 <+84>:  add    x9, x9, x0
    0x105d08024 <+88>:  strb   w8, [x9, #0x28]
    0x105d08028 <+92>:  ldp    x29, x30, [sp, #0x30]
    0x105d0802c <+96>:  ldp    x20, x19, [sp, #0x20]
    0x105d08030 <+100>: ldp    x22, x21, [sp, #0x10]
    0x105d08034 <+104>: add    sp, sp, #0x40
    0x105d08038 <+108>: ret
    0x105d0803c <+112>: brk    #0x1
    0x105d08040 <+116>: brk    #0x1

CC: @eeckstein

Not inlined co-routines almost always allocate. There is not much we can do here.
Except to give co-routines high priority for inlining.

I'm inclined to say we should investigate that idea: the cost of the coroutine allocations ends up being really painful.

Coroutine lowering is currently pretty naive and allocates a lot more than it needs to. We have a whole bunch of issues tracking various improvements to the lowering that would reduce the likelihood of allocation without relying on inlining.

But still, the inline buffer size (which is 2 or 3 words) is a hard limit. Unless we increase that, it's still very likely that a co-routine will allocate.


Make Hierarchy List Support Dnd

Make Hierarchy List Support Dnd(react-dnd) to update the config path

feature completed


Use Relocatable for accessed addresses

Description
Analogous to #286 but for tracking accessed addresses. Improves 3-6% run time when proof mode is enabled, should halve the memory required for the bookkeeping.
Description of the pull request changes and motivation.
Checklist

[ ] Linked to Github Issue
[ ] Unit tests added
[ ] Integration tests added.
[ ] This change requires new documentation.

[ ] Documentation has been added/updated.

I'll close this rather than merge it. It makes sense to wait for optimizations to this path when proof mode is actually implemented. Even testing it without it implies making custom builds.


Cache-specific Prometheus metrics

Pelican Service:

[ ] Client
[ ] Plugin
[ ] Registry
[ ] Director
[ ] Origin
[X] Cache
[ ] Other (please give the detail)

Currently, origin and cache have the same metrics in Prometheus monitoring. Besides them, we want to include more specific metrics for cache servers to collect additional information. Here are the candidates for cache-specific metrics.
Cache Performance Metric
We'd be interested in the response time of a cache server for each request it serves. By collecting xrootd_cache_latency_seconds, we will be able to analyze cache performance with the status of a request, size of object and client's geological location, etc.
Labels:
type: ["hit", "miss"]
path
size - object size
ip - this records the TCP connection metadata from client to XRootD server, including client's IP address and subnet
proj - client’s User-Agent header when requesting the file
Derived metrics:
xrootd_cache_hit_count (count by type == "hit")
xrootd_cache_miss_count (count by type == "miss")
Weighted xrootd_cache_hit/miss_count by object size (suggested by @Saartank)
Cache Space Management Metrics
In cache, objects come and go. We want to track the entire lifecycle of each object staying in a cache server, since it is prefetched/fetched from the origin. xrootd_cache_object
Labels:
path
ns
status: ["cached", "evicted"]
size
creation_time
access_count
eviction_reason - null if still cached, reason if evicted
Derived metrics:
age of files (current_time - creation_time)
eviction counts (count by eviction_reason)
space usage (sum of size)
Cache Health Metrics
When something bad happens in cache, we want to get an alert. xrootd_cache_corruption_count tracks cache data integrity issues. I'm not very familiar with how does Pelican wrap XRootD so these are my suggested labels.
Labels:
path
ns
type: ["checksum", "incomplete", "storage"]

checksum: cached file's checksum doesn't match original
incomplete: interrupted transfers from origin
storage: file system error, permission problem...

action: ["removed", "refetched", none]

This might be a bit harder but I would be curious to see the # bytes per project

This might be a bit harder but I would be curious to see the

# bytes per project
IP address of requesting Client

Thanks! Just updated.


Combining with ipWhiteList middleware

How does this DenyIP work with the native ipWhiteList middleware?
What takes precedence, if I have same IP address on both lists?
What about in a case when I have a CIDR network address on one, but single IP on the other?

Hi @shalak, were you able to find the answers to the above questions?
My assumption is that the native middleware would be evaluated first, but it's been a couple years since I've worked with Traefik or the middleware routines.
Cheers!


xFormers can't load C++/CUDA extensions

Hi there, it seems there's a bug with the requirements
I install unsloth using these three lines:
!pip install --upgrade --force-reinstall --no-cache-dir torch==2.1.1 triton \
  --index-url https://download.pytorch.org/whl/cu118
# Installs Unsloth, Xformers (Flash Attention) and all other packages!
!pip install "unsloth[cu118] @ git+https://github.com/unslothai/unsloth.git"
!pip install --no-deps "xformers<0.0.26" trl "peft<0.11.0" accelerate bitsandbytes

And then I try to load a model with this line:
from unsloth import FastLanguageModel
import torch
max_seq_length = 4096 # Choose any! We auto support RoPE Scaling internally!
dtype = None # None for auto detection. Float16 for Tesla T4, V100, Bfloat16 for Ampere+
load_in_4bit = False # Use 4bit quantization to reduce memory usage. Can be False.

# 4bit pre quantized models we support for 4x faster downloading + no OOMs.
fourbit_models = [
    "unsloth/mistral-7b-bnb-4bit",
    "unsloth/mistral-7b-instruct-v0.2-bnb-4bit",
    "unsloth/llama-2-7b-bnb-4bit",
    "unsloth/gemma-7b-bnb-4bit",
    "unsloth/gemma-7b-it-bnb-4bit", # Instruct version of Gemma 7b
    "unsloth/gemma-2b-bnb-4bit",
    "unsloth/gemma-2b-it-bnb-4bit", # Instruct version of Gemma 2b
    "unsloth/llama-3-8b-bnb-4bit", # [NEW] 15 Trillion token Llama-3
] # More models at https://huggingface.co/unsloth

model, tokenizer = FastLanguageModel.from_pretrained(
    model_name = "unsloth/llama-3-8b-bnb-4bit",
    max_seq_length = max_seq_length,
    dtype = dtype,
    load_in_4bit = load_in_4bit,
    token = "token here", # use one if using gated models like meta-llama/Llama-2-7b-hf
)

But I get this error:
WARNING[XFORMERS]: xFormers can't load C++/CUDA extensions. xFormers was built for:
    PyTorch 2.1.0+cu121 with CUDA 1201 (you have 2.1.0+cu118)
    Python  3.10.13 (you have 3.10.12)
  Please reinstall xformers (see https://github.com/facebookresearch/xformers#installing-xformers)
  Memory-efficient attention, SwiGLU, sparse and more won't be available.
  Set XFORMERS_MORE_DETAILS=1 for more details
---------------------------------------------------------------------------
OSError                                   Traceback (most recent call last)
File /usr/local/lib/python3.10/dist-packages/xformers/_cpp_lib.py:121, in _register_extensions()
    120 try:
--> 121     torch.ops.load_library(ext_specs.origin)
    122 except OSError as exc:

File /usr/local/lib/python3.10/dist-packages/torch/_ops.py:852, in _Ops.load_library(self, path)
    848 with dl_open_guard():
    849     # Import the shared library into the process, thus running its
    850     # static (global) initialization code in order to register custom
    851     # operators with the JIT.
--> 852     ctypes.CDLL(path)
    853 self.loaded_libraries.add(path)

File /usr/lib/python3.10/ctypes/__init__.py:374, in CDLL.__init__(self, name, mode, handle, use_errno, use_last_error, winmode)
    373 if handle is None:
--> 374     self._handle = _dlopen(self._name, mode)
    375 else:

OSError: libcudart.so.12: cannot open shared object file: No such file or directory

The above exception was the direct cause of the following exception:

xFormersInvalidLibException               Traceback (most recent call last)
File /usr/local/lib/python3.10/dist-packages/unsloth/models/_utils.py:229
    228 try:
--> 229     _register_extensions() # Check if C++ modules are loaded correctly
    230 except Exception as error:

File /usr/local/lib/python3.10/dist-packages/xformers/_cpp_lib.py:123, in _register_extensions()
    122 except OSError as exc:
--> 123     raise xFormersInvalidLibException(build_metadata) from exc
    124 return build_metadata

xFormersInvalidLibException: xFormers can't load C++/CUDA extensions. xFormers was built for:
    PyTorch 2.1.0+cu121 with CUDA 1201 (you have 2.1.0+cu118)
    Python  3.10.13 (you have 3.10.12)
  Please reinstall xformers (see https://github.com/facebookresearch/xformers#installing-xformers)
  Memory-efficient attention, SwiGLU, sparse and more won't be available.

During handling of the above exception, another exception occurred:

ImportError                               Traceback (most recent call last)
Cell In[3], line 1
----> 1 from unsloth import FastLanguageModel
      2 import torch
      3 max_seq_length = 4096 # Choose any! We auto support RoPE Scaling internally!

File /usr/local/lib/python3.10/dist-packages/unsloth/__init__.py:158
    148         warnings.warn(
    149             "Unsloth: CUDA is not linked properly.\n"\
    150             "Try running `python -m bitsandbytes` then `python -m xformers.info`\n"\
   (...)
    154             "Unsloth will still run for now, but maybe it might crash - let's hope it works!"
    155         )
    156 pass
--> 158 from .models import *
    159 from .save import *
    160 from .chat_templates import *

File /usr/local/lib/python3.10/dist-packages/unsloth/models/__init__.py:15
      1 # Copyright 2023-present Daniel Han-Chen & the Unsloth team. All rights reserved.
      2 #
      3 # Licensed under the Apache License, Version 2.0 (the "License");
   (...)
     12 # See the License for the specific language governing permissions and
     13 # limitations under the License.
---> 15 from .loader  import FastLanguageModel
     16 from .llama   import FastLlamaModel
     17 from .mistral import FastMistralModel

File /usr/local/lib/python3.10/dist-packages/unsloth/models/loader.py:15
      1 # Copyright 2023-present Daniel Han-Chen & the Unsloth team. All rights reserved.
      2 #
      3 # Licensed under the Apache License, Version 2.0 (the "License");
   (...)
     12 # See the License for the specific language governing permissions and
     13 # limitations under the License.
---> 15 from ._utils import is_bfloat16_supported, HAS_FLASH_ATTENTION, HAS_FLASH_ATTENTION_SOFTCAPPING
     16 from .llama import FastLlamaModel, logger
     17 from .mistral import FastMistralModel

File /usr/local/lib/python3.10/dist-packages/unsloth/models/_utils.py:231
    229     _register_extensions() # Check if C++ modules are loaded correctly
    230 except Exception as error:
--> 231     raise ImportError(
    232         "Unsloth: Xformers was not installed correctly.\n"\
    233         "Please install xformers separately first.\n"\
    234         "Then confirm if it's correctly installed by running:\n"\
    235         "python -m xformers.info\n\n"
    236         "Longer error message:\n" + str(error)
    237     )
    238 pass
    239 import xformers.ops.fmha as xformers

ImportError: Unsloth: Xformers was not installed correctly.
Please install xformers separately first.
Then confirm if it's correctly installed by running:
python -m xformers.info

Longer error message:
xFormers can't load C++/CUDA extensions. xFormers was built for:
    PyTorch 2.1.0+cu121 with CUDA 1201 (you have 2.1.0+cu118)
    Python  3.10.13 (you have 3.10.12)
  Please reinstall xformers (see https://github.com/facebookresearch/xformers#installing-xformers)
  Memory-efficient attention, SwiGLU, sparse and more won't be available.

NVM, I just had a corrupt install

Had the same problem, believe it is based on us both trying to use CUDA 11.8. Was able to resolve for myself by installing with:
!pip install "unsloth[cu118-torch230] @ git+https://github.com/unslothai/unsloth.git@c73636f6c5a733f86af23cf92ecc9901a29305d0"
guessing that commit f65cc9877c9ee42b9c6719a4fe168b00abceb095 caused my issue

Oh I shall revert this change actually!


Inferno

Hi,
Congrats on the ReactiveUI framework, it's Event-driven done right.
I wanted to (ab)use this communication channel to inform you about Inferno, feel free to have a look and spread the word.
PS I've left Git history intact for the reviewers.
Gr

Thank You for the information.  I appreciate you acknowledging you are abusing the communication channel.  We reserve issues for bug reports and feature requests.  I would make sure that you are following proper attribution guidelines.


(PUP-4702) Replace RGEN based Type system with immutable classes

This commit changes all RGEN based classes in the Puppet Type
system into plain Ruby classes. Each class is immutable which means
that the instance is completely initialized by its initializer and
that only attr_readers exists to read the properties of the instance.
Each class has a DEFAULT constant defined which is the singleton
default for the type that the class represents. Some types have
additional constants such as PCollectionType::DEFAULT_SIZE or
PStringType::NON_EMPTY.
In addition to creating immutable classes, some performance critical
methods were also moved out of the polymorphic dispatch. This includes
methods like assignable?, instance? and generalize. The methods
are still available on the TypeCalculator to ensure backward
compatibility.

CLA signed by all contributors.

I am fine with having a runtime implementation of types that is optimized like this. The intent though is to be able to model types and serialize them. We currently have no need to do so in the AST (we build types by evaluating expressions that mean "construct a type"), but we will most likely need this when we also allow users to define type aliases, and to define complete types.
In order to support that, we need to either have a model of the types and serialize that, or make it possible to use types as a data type in RGen models.
My original idea was to build one type model out of all types in a module; the server and client would share this model.
With that in mind; I don't know how valuable the type_meta model is - if it should be kept and evolved, if it is meaningful to be able to go from runtime object to model, and vice versa.
When we get to the implementation of resource types (and other types described by users), they have to also fit into the runtime model.
A general note is that it is a shame that we cannot get the performance out of an RGen model and that we instead start to hand code model after model. There will be more models. There will be polyglot implementations (representing models in different implementation languages).
At the same time, this is a tactical performance optimization (and work around for deficiencies in RGen that are more time consuming to correct).

Pushed a rebased commit that I think addresses all issues that we've agreed should be addressed in this PR.


Java codegen

Description
Generate CiServers.java at build time, using Groovy as a template engine and the root ciDict.json as data for the template. This addresses #17 for the Java implementation.
Motivation & context
With this change the library no longer needs to parse JSON at runtime. This makes the library:

more performant (not really important)
smaller memory footprint (not really important)
more secure and less maintenance needed, because 3rd party JSON parsers tend to have CVEs

With this change there is no need to copy the ciDict.json file either.
Type of change

Refactoring/debt (improvement to code design or tooling without changing behaviour)
Bug fix (non-breaking change which fixes an issue)

Thanks for the feedback @mpkorstanje !


Editor doesn't allow blanks

Describe the Bug
Can't enter FEEL expressions in the input parameters of a service task.
Get the error "Source must not contain spaces".

Steps to Reproduce

Create a service task
go to the input/output parametrers task
Create a new input parameter (click the +)
Enter "=if (variable = null) then 1 else variable + 1"
Error message appears - "source must not contain spaces"

Expected Behavior

Editor should accept valid FEEL expressions
Environment

OS: Ubuntu 18.04.3
Zeebe Modeler Version: 0.9.0

This restriction is also enabled for other attributes that allow FEEL expressions:

service task type
source attribute of input and output parameters (i.e. variable mappings)

Current overview of the attributes that can be expressions: https://docs.zeebe.io/reference/expressions.html

Seems like we need to update our validation to support FEEL.

We decided to have a quick fix for this issue in the next release and move the advanced FEEL validation to another issue, cf. https://github.com/zeebe-io/zeebe-modeler/issues/238.

Closed via https://github.com/zeebe-io/zeebe-modeler/pull/240


Repositories Manager window always on top

After launching Repositories Manager, it always stays on top which is making the user difficult to focus on other windows/apps.

This behavior was corrected in our last release and now it isn't as invasive as you reported.
Hope you enjoy it.
Happy hacking!


Add icon.pngs for libs

closes jwunderl/pxt-corgio#4
(followed the format of pxt-common-packages with putting the package images into docs/static)
@abchatra

You should be able to just add those images under /docs/static/libs without modifying pxt.json

Fixed, thanks

Can we get the corgi on a solid background? I like how the dart one looks and went with a solid background on this one too: https://github.com/Microsoft/pxt-arcade/pull/282

@riknoll I'll see how they look with the color of the packages like you did for animation, one sec

Beautiful!


mistral does not support NVIDIA V100 (compute_cap <= 800)

Describe the bug
it does not support some old hardware.
Can it just convert bfloat16 to float16 before loading model. just like vllm is doing?

Hi @thesues!
This is a problem with the way we compile our CUDA kernels. I'll try to see if we can modify the compilation process (likely with conditional compilation) to avoid this, but it will probably be difficult.

@thesues I would recommend converting the model before loading.


Increases default symbol limits & adds config option to change these

@jaredbroad config.json has merge conflicts. Looks like some other changes related to IB & Tradier & Local Desktop were made. Do you want to handle merging those?


Tweak Javascript in example to display as GeneralizedTime instead

@JamesSmartCell if the time attribute is already generated as a dictionary with date and generalizedTime key-value pairs, this should just work and display as 5pm.
You can see examples of why CDATAs are useful here. This PR uses code that includes < and &. In order to work without CDATAs, I modified them to be entities like < and &. Let's just leave it like this for the moment and we can revisit why it doesn't work when we have the time. (but useful to know in case this comes up during the workshop)

it doesn't work when we have the time

What does 𝑖𝑡 refer to in this case? Do you mean CDATA doesn't work?
P.S. you know the Makefile converts < to < if it's in CDATA right?

it doesn't work when we have the time

What does 𝑖𝑡 refer to in this case? Do you mean CDATA doesn't work?
P.S. The Makefile converts < to < if it's in CDATA so all signed XML files has no CDATA in it, but we should work with CDATA as well for developers to debug

James said that it failed to render on the Android TokenScript client.


May you release a wheel for Python 3.8 Windows 64-bit?

In Python 3.8 with Windows 64-bit, I do not install it by pip for missing MS VC.
I found no the wheel package. May you release it?

Any plans to release soon?

Other wheels for linux and osx would be greatly appreciated as well.

I agree, a wheel for Python 3.8 would be great!
Currently, I can't use netifaces on a box where I don't have and can't install build tools.
It worked with Python 3.4 because a wheel was provided - netifaces-0.10.9-cp34-cp34m-manylinux1_i686.whl
Looks like the wheel is already being created, it's just a matter of getting it to PyPI:
Building wheels for collected packages: netifaces
  Building wheel for netifaces (setup.py) ... done
  Created wheel for netifaces: filename=netifaces-0.10.9-cp38-cp38-linux_x86_64.whl size=33522 sha256=286dace2827286b6734f63908a85619052a24aa2d7e9aed0f29491bbba875f76
  Stored in directory: /tmp/pip-ephem-wheel-cache-87ydwskm/wheels/bf/4c/ae/80a6a14f01628be9d0b96e068fe33d3cfd6867ef3d984f7291

https://travis-ci.org/github/al45tair/netifaces/jobs/745925548#L207


Consider how to bring the Ember.js "new repository" wizard into the app

partially refactored by moving the Ember app out of the core core


Convert Project to AR/Arel

There's only one method to convert. The join seems like it would be complicated to phrase in AR, but if anyone knows the right syntax, let's try it and I'll benchmark.
The Arel (in the PR currently) produces exactly the same SQL as it's replacing.

Coverage increased (+0.001%) to 93.033% when pulling a8440a6c83b350a091e4e8289e734d252ce14c93 on nimmo-SQL-in-models-project into 131a79a4360b91f16716591f4c04971bcdf65036 on master.


[1.11.x] Bump Quarkus 2.2.0.Final

Many thanks for submitting your Pull Request :heart:!
Please make sure that your PR meets the following requirements:

[ ] You have read the contributors guide
[ ] Your code is properly formatted according to this configuration
[ ] Pull Request title is properly formatted: KOGITO-XYZ Subject
[ ] Pull Request title contains the target branch if not targeting main: [0.9.x] KOGITO-XYZ Subject
[ ] Pull Request contains link to the JIRA issue
[ ] Pull Request contains link to any dependent or related Pull Request
[ ] Pull Request contains description of the issue
[ ] Pull Request does not include fixes for issues other than the main ticket

How to retest this PR or trigger a specific build:

Run all builds
Please add comment: Jenkins retest this

Run (or rerun) specific test(s)
Please add comment: Jenkins (re)run [runtimes|optaplanner|apps|examples] tests

Quarkus LTS checks
Please add comment: Jenkins run LTS

Run (or rerun) LTS specific test(s)
Please add comment: Jenkins (re)run [runtimes|optaplanner|apps|examples] LTS

Native checks
Please add comment: Jenkins run native

Run (or rerun) native specific test(s)
Please add comment: Jenkins (re)run [runtimes|optaplanner|apps|examples] native

Full Kogito testing (with cloud images and operator BDD testing)
Please add comment: Jenkins run BDD
This check should be used only if a big change is done as it takes time to run, need resources and one full BDD tests check can be done at a time ...

The (build) Runtimes check has failed. Please check the logs.

why is that not failing on kogito-apps with the rest-client ? test does not exist ?

anyway created https://github.com/kiegroup/kogito-apps/pull/1017 just in case


`uv_cond_wait_helper' linker error

libuv/src/win/thread.c:664: undefined reference to `uv_cond_wait_helper'
I compiled libuv as a static library using MinGW on Windows 7.
I think uv_cond_wait_helper should not be declared inline, because it is too big.
When I remove the inline keyword from it, the linking process is OK.

Fixed by 454688d.

Just for the reference of anybody looking at this later, adding static on that line fixes the immediate compilation failure as well.


NestedScrollView

Steps to Reproduce

Run flutter create bug.
Update the files as follows: ...
...

Expected results:
Actual results:

Logs

@duynp117 Please mention your issue and also please provide all the details that are required in the template (Logs, minimal code, expected and actual results).

@duynp117
When opening an issue, please try to provide all or some of the information indicated in the template.

Issue Template
If you are looking for support, please check out our documentation
or consider asking a question on Stack Overflow:
- https://flutter.dev/
- https://api.flutter.dev/
- https://stackoverflow.com/questions/tagged/flutter?sort=frequent

If you have found a bug or if our documentation doesn't have an answer
to what you're looking for, then fill our the template below. Please read
our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports

Steps to Reproduce

Please tell us exactly how to reproduce the problem you are running into.

Please attach a small application (ideally just one main.dart file) that
reproduces the problem. You could use https://gist.github.com/ for this.

If the problem is with your application's rendering, then please attach
a screenshot and explain what the problem is.

1. ...
2. ...
3. ...

Please tell us which target platform(s) the problem occurs (Android / iOS / Web / macOS / Linux / Windows)
Which target OS version, for Web, browser, is the test system running?
Does the problem occur on emulator/simulator as well as on physical devices?

Target Platform:
Target OS version/browser:
Devices:

Run your application with `flutter run --verbose` and attach all the
log output below between the lines with the backticks. If there is an
exception, please see if the error message includes enough information
to explain how to solve the issue.

Run `flutter analyze` and attach any output of that command below.
If there are any analysis errors, try resolving them before filing this issue.

Finally, paste the output of running `flutter doctor -v` here.

Closing this issue, since no information has been provided.
Thank you.


Migration module

We should allow user to configure whether to generate the migration functionality, such as CREATE TABLE, ALTER TABLE, etc

The current migration code had a flaw because different SQL driver support different SQL for migration, many of it look different, instead of returning the schema on the table, we should generate the SQL files.


Looking for clarification on internal and external links - what is same/different domain?

Hi, looking for some guidance on external links. The canope guidance is:

If the page it links to is internal (i.e. hosted by the same organisation on the same domain), it should open in the same tab.
If the page it links to is external (hosted by a different organisation on a different domain), it should open in a new tab.

But what counts as same and different domain?
eg would Condeco be our L&G domain ie internal https://legalandgeneral.condecosoftware.com/master.aspx ?
And what about MyHR and https://fa-ewnn-saasfaprod1.fa.ocs.oraclecloud.com/hcmUI/faces/FuseWelcome?_afrLoop=44456260991143642&_adf.ctrl-state=8lzhv8q4_9 ?
Thanks,
The Hub product team

Copilot has this guidance but would be good to verify:
Determining whether a link is considered internal or external depends on the domain of the URL. A domain typically refers to the main part of the URL that identifies the owner of the website. For example, in the URL https://legalandgeneral.condecosoftware.com/master.aspx, legalandgeneral.condecosoftware.com is the domain.
If the domain of the link matches the domain of your organization's official website, then it is considered an internal link. If the domain is different, then it is considered an external link.
Based on the information provided, Condeco seems to be a space booking platform used across various locations of your organization, and it is accessed through a subdomain of legalandgeneral.com which suggests that it is an internal domain [1](https://legalandgeneral.sharepoint.com/sites/thehubOurBusiness/SitePages/Condeco(1).aspx?web=1)[2](https://legalandgeneral.sharepoint.com/sites/thehubApps/SitePages/Condeco.aspx?web=1)[3](https://legalandgeneral.sharepoint.com/sites/Office365Services/SitePages/Condeco-Registration.aspx?web=1).
On the other hand, MyHR appears to be an HR solution for your organization, and while the exact domain isn't provided in the search results, it is referred to in various internal documents and guides, indicating that it is also an internal domain [4](https://legalandgeneral.sharepoint.com/sites/thehubmanagers/SitePages/Joiners-movers-extensions-leavers-(JMEL)-process.aspx?web=1)[5](https://legalandgeneral.sharepoint.com/sites/thehubLifeatLG/SitePages/HR-Hub.aspx?web=1)[6](https://legalandgeneral.sharepoint.com/sites/thehubLifeatLG/SitePages/Recruitment-&-Internal-Vacancies.aspx?web=1)[7](https://legalandgeneral.sharepoint.com/sites/thehub/SitePages/Our new HR solution.aspx?web=1)[8](https://legalandgeneral.sharepoint.com/sites/thehubPolicies/Shared Documents/HR/MyHR/Documents/Employee-Handbook(Ireland)-MyHR.pdf?web=1)[9](https://legalandgeneral.sharepoint.com/sites/thehubNews/SitePages/An-update-on-MyHR.aspx?web=1)[10](https://legalandgeneral.sharepoint.com/sites/thehubPolicies/Shared Documents/HR/MyHR/Documents/Employee-Handbook(Hong Kong)-MyHR.pdf?web=1)[11](https://legalandgeneral.sharepoint.com/sites/sp-4W3ZAw3b/ITAS/Project Documents/HR/HCM/SAD MyHR Tech and Data v1.1.docx?web=1)[12](https://legalandgeneral.sharepoint.com/sites/sp-4W3ZAw3b/ITAS/Project Documents/HR/HCM/SAD MyHR Tech and Data v1.0.docx?web=1)[13](https://legalandgeneral.sharepoint.com/sites/sp-4W3ZAw3b/ITAS/Project Documents/HR/HCM/Functional Design/SAD MyHR Tech and Data v1.0.docx?web=1).
Therefore, both Condeco and MyHR would open in the same window as they are internal links, according to the Canope guidance you mentioned. If you need further clarification or assistance with domains, I recommend consulting with your IT department or the team responsible for managing your organization's web domains. They would have the definitive information on what is considered internal or external for your specific organizational setup. If you have any more questions or need further assistance, feel free to ask!


Chunk size calculation logic errors in Azure Monitor ingestion

Package Name: azure.monitor.ingestion
Package Version: 1.0.0
Operating System: Windows
Python Version: 3.10.10

Describe the bug
The chunking functionality in _helpers.py has multiple logic errors related to event size calculation.
Error 1: The chunking functionality in _helpers.py:30 incorrectly calculates size based on a fixed 4 bytes per character: size = len(json.dumps(log)) * CHAR_SIZE_BYTES. As logs are ultimately encoded in UTF-8 (see _helpers.py:48), the bytes-per-character is not fixed and will range from 1 to 4 bytes/character based on the characters in use. The assumption of 4 bytes/character has the effect of dramatically (4x) overstating the size of most logs with only plain ASCII content (1 byte/character). This results in a substantial increase in overhead and latency, as the resulting chunk size is often as little as 256KB of the 1MB limit, which equates to quadruple the number of requests/round-trips to ingest the same content.
In order to properly calculate sizing for UTF-8 encoded text, something like size = len(json.dumps(log).encode('utf-8)) should be done to account for the variable byte/character ratio.
Error 2: The size calculation algorithm does not properly take into account the separators and opening/closing braces added in the final json.dumps() in _helpers:48.
Take the following three JSON events as an example:
{"name":"event1"}, {"name":"event2"}, and {"name":"event3"}
If all three of these events are added to a single chunk, they will be packed as:
[{"name":"event1"},{"name":"event2"},{"name":"event3"}]
However, only the size of {"name":"event1"}, {"name":"event2"}, and {"name":"event3"} are taken into account in _split_chunks(). The [, ], and two separating , characters are added after the size calculation is performed. This can result in an oversize message when the raw events are close to or at the 1MB limit.
To address this:

The size calculation in _split_chunks() should start with chunk_size = len('[]'.encode('utf-8')) to account for the opening/closing braces.
Each event should check if a separator is needed and add the appropriate overhead. Since a separator is only added on the second event, something like this would provide proper calculation:

SEPARATOR_SIZE = len(','.encode('utf-8'))
overhead = SEPARATOR_SIZE if curr_chunk.count() else 0 # First event will not have a separator
size = len(json.dumps(log).encode('utf-8)) + overhead

Thank you so much for this detailed analysis @tfrederick74656!
@pvaneck are you able to take a look?

Hey @tfrederick74656, thanks for the descriptive feedback! You are right, we definitely do not need to be multiplying each len by CHAR_SIZE_BYTES, and I will update the code accordingly.
For the second problem, was this an issue you encountered when using the ingestion SDK? I think this is a valid concern, but since we are not uploading raw data and are sending gzip-compressed data, I think it's safe to disregard the brackets/commas in the count. The API service limit for compressed data is 1 MB, and since gzip does quite well at compressing JSON, we have a lot of room to work with. Generally after compression, we are well below the 1MB limit.
One thing I've been meaning to investigate was the possibility of compressing on the fly so that we can make full use of the 1 MB after compression, but I haven't had a chance to look into it yet.

@pvaneck No problem, thanks for taking a look so quickly!
The second problem is definitely theoretical, I haven't encountered this in practice with the SDK. I'm migrating from a homebuilt client where we weren't compressing data and thus had to actually take that into account. Completely agree with you regarding gzip, that should leave plenty of headroom.
Love the idea of doing on-the-fly compression. I had actually mocked up some rough code for this a few months ago that you're welcome to borrow from if it's helpful. Zlib isn't exactly great for doing streaming compression because you have to flush the compressor at regular intervals to determine the current compressed size. I took the approach of first compressing 1MB of raw text, then subtracting the resulting compressed size from 1MB to get X bytes remaining, then compressing X bytes of raw text, and so on and so forth, until all space is exhausted. It's a tradeoff of decreasing efficiency (since each subsequent block is smaller, yielding a lower compression ration) for a guarantee of never exceeding the max size and always compressing to an event boundary. I'm sure there's a better way to implement this, but it's still a great deal more space efficient than a single compression pass.


Copy all files that starts with lua

As suggested by @xpol in #4

Yes, lua*.h* left lauxlib.h away. Sorry for my mistake.

No worries. Reverted the commit to do the copy the old way.


QueryParam's order

I know this is really stupid, but some apps, do not support QueryParameters like they should, and only support QueryItems in custom order. (like Maps.Me)
Any suggestions on how to fix this problem?
I was trying to add:
enum Query {
    case parameters([String:String])
    case items([URLQueryItem])

    var queryItems: [URLQueryItem] {
        switch self {
            case .parameters(let params): return params.map { URLQueryItem(name: $0, value: $1) }
            case .items(let queryItems): return queryItems
        }
    }
}

And use Query as an input, But since Path's queryParameters is variable and public, it'll definitely break backward compatibility.
Any suggestions?

Could you please provide the error you got, when you tried to use Appz to add this application ?

Thanks for reporting this!
I thought of this simple, non-intrusive solution. Would love to hear your thoughts:
public enum QuerySortStrategy {
    case none
    case array([String])
    case callback((String, String) -> Bool)
}

public struct Path {

    public var pathComponents = [String]()
    public var queryParameters = [String:String]()
    public var querySortStrategy = QuerySortStrategy.none

    public var queryItems: [URLQueryItem] {
        let items = queryParameters.map {
            URLQueryItem(name: $0, value: $1)
        }

        switch querySortStrategy {
        case .none:
            return items
        case let .array(keys):
            return items.sorted {
                (keys.index(of: $0.name) ?? Int.max) < (keys.index(of: $1.name) ?? Int.max)
            }
        case let .callback(callback):
            return items.sorted {
                return callback($0.name, $1.name)
            }
        }
    }
    ...
}

It will solve the problem, but me myself, i'm not a fan of this way, since it is not error-prune. consider the cases when most of people forget to insert a Key inside .array or in the queryParameters or ...

Having a [URLQueryItem] instead of [String:String] is the approach I'd chose as well, but of course, we need to be mindful of backward compatibility.
So .. This approach properly isolates the sorting strategy from the key/value pair definition. If a user forgets to give the proper order in their sorting strategy, they might make the same mistake in arranging them within an array, so it is a problem present in both cases.
However, they might omit a key from the array on purpose, which is a feature, that means you don't care about the position of that key, so just throw it at the end.
Hence, I think this solution is not ideal, but is also free from any major flaws.

another possibly way is to allow an optional [URLQueryItem], and simply merge the two. Would that work better for you?

Well, I imported the Appz code directly into my code and solved my problem with the way i proposed (using an enum Query as an input).
I'm not in a hurry anymore, let's find the best solution possible ^_^.
what about using DictionaryLiteral? it will still break backward-compatibilty, but it won't cost much to fix the problems (for anyone which did use queryParameters directly). And it's also ordered...

Well, I remember we didn’t add Microsoft apps because they didn’t work with Appz. So, I have a suggestion if you don’t mind: I think the best thing to do is: to find a solution that works for both of this case and Microsoft apps.

What's their problem?

Please check #30


fix: consider generation when skipping upgradePolicy update

Without this patch, this upgrade policy is never reported twice:
    conditions:
    - lastTransitionTime: "2022-11-02T21:33:40Z"
      message: ""
      observedGeneration: 5
      reason: FullyReconciled
      status: "True"
      type: Available
    observedGeneration: 5
    observedVersion: 2.7.1
    phase: Ready
    upgradePolicy:
      id: 93c7dc0a-44ca-11ed-ba66-0a580a8118bf
      observedGeneration: 3
      value: completed

As you can see, we are stuck at observedGeneration "3"
Signed-off-by: Amador Pahim<EMAIL_ADDRESS>

/hold


tracker return 404

hi sir, i try to build the tracker.. but i confuse, when i connect using wss or ws always return 404. i try to add index.html header return 404 no 101 switching

Can you elaborate a bit or share some logs?
What server is the tracker running on, did you enable ws, and the client side code which is connecting to it?
wss probably wont work unless  you have an SSL certificate.

i am running using ubuntu 18.04 lts 64 bit,
this is my config
`{
"servers": [{
"server": {
"port": 80,
"host": "<IP_ADDRESS>"
},
"websockets": {
"path": "/",
"maxPayloadLength": 65536,
"idleTimeout": 240,
"compression": 1
}
}
],
"tracker": {
"maxOffers": 20,
"announceInterval": 120
}
}
`
this happen only when i use config.json sir, if not then its ok

What is the output when you run wt-tracker in the command line?
And can you run netstat -natl on your server to check the port is open?

when i run :
root@Str1:~/wt-tracker# npm start sample/config.json

><EMAIL_ADDRESS>start /root/wt-tracker
> node ./dist/run-uws-tracker.js

listening <IP_ADDRESS>:80

and i run netstat :
root@Str1:~/wt-tracker# netstat -natl
Active Internet connections (servers and established)
Proto Recv-Q Send-Q Local Address           Foreign Address         State
tcp        0      0 <IP_ADDRESS>:80              <IP_ADDRESS>:*               LISTEN
tcp        0      0 <IP_ADDRESS>:53           <IP_ADDRESS>:*               LISTEN
tcp        0      0 <IP_ADDRESS>:22              <IP_ADDRESS>:*               LISTEN

Hmm, looks like the port is fine, as is the wt-tracker  instance. What is happening on the client side? I.e. how are you connecting to the ws tracker in code? Can you share that part?
 As in you are connecting to it via an IP / domain?

yes it is public sir ip is <IP_ADDRESS>
and for the client i use demo from http://novage.com.ua/p2p-media-loader/demo.html
when i run without config.json, return is ok (you can try ws://<IP_ADDRESS>:8000).
but when i use config.json its not ok 404 ( you can try ws://<IP_ADDRESS> ).

So this is what I got:

and

One guess I have, is that there is some other application listening on port 80 already? I mean this would give an error, but just a guess.
I'll try port 80 on my server and see what results I get

Hi,
There is the issue in uWebSockets.js library. Please change "path": "/" to "path": "/*" in your config:
"websockets": {
"path": "/*",

wow.. its work after i change path to /*
thanks all for fast response


[WIP] Add support for longer RSA keys longer than 2048, init ECDSA support

Closes #20
as @cipherboy suggested I have created the code to support longer RSA and added support for ECDSA keys
Looking forward to suggestions as I'm not very proficient in Go yet :)

RSA part was tested (load key, sign) with 4096 bit keys.
ECDSA was tested with ecdsa-p521 curve (load only yet)

@cipherboy thanks for all the suggestions, the idea behind merging checkKeyType and wrapPrivateKey looks much more obvious right now 😅
I'm going to test out the EC keys during the weekend and leave the feedback if they are working fine or require some more work :)

@cipherboy I have tested yesterday the EC key-based signatures, and it doesn't work.
It fails to verify the Vault Transit's signature on the notation cli side right after signature creation - the plugin output is failing with
Error: generated signature failed verification: signature is invalid. Error: crypto/ecdsa: verification error
But as for now I have no clue, why Vault would respond with a broken signature - probably sth in invocation of "SignWithTransit()" - I assumed that "signature_algorithm" should be empty for ECDSA (as Vault transit api doc say nothing about EC for that field)
So seems like I'm stuck right now with this, and I'm not sure how I should approach this to solve this, or maybe remove the EC parts and deliver longer RSA only for now

I have longer break, but I finally have time to tidy this up
I'm going to provide smaller PR just for RSA longer keys, as it blocks me to use the plugin it in project

Closing as #23 contains cleaned-up version


No USB Devices Available to store firmware backup

Is there a way to get rid of the option to backup? No matter what I try it always says No USB Devices available to store firmware backup whenever I try and install UEFI with the firmware script.
I have an SD card in the inbuilt reader and not sure if it's getting read or not but it's all I have at the moment. Thanks.

if your SD card reader isn't USB-attached, that could be why. Don't have a USB stick to use?


Does the PR scan open new PRs?

I noticed the following setting in the template frogbot-scan-pull-request.yml file:
          # [Optional, Default: "FALSE"]
          # If TRUE, Frogbot creates a single pull request with all the fixes.
          # If false, Frogbot creates a separate pull request for each fix.
          # JF_GIT_AGGREGATE_FIXES: "FALSE"

https://github.com/jfrog/documentation/blob/77008ab7c9402ea1a7eb6b99c016074cd1ada5fe/jfrog-applications/frogbot/templates/github-actions/frogbot-scan-pull-request.yml#L116-L119
This implies it will create PRs to resolve issues detected by the PR scan. Is this actually the case? Shouldn't this only be true for the repo scan?
Also, since the default value is already "FALSE", perhaps # JF_GIT_AGGREGATE_FIXES: "FALSE" should be changed to # JF_GIT_AGGREGATE_FIXES: "TRUE". frogbot-scan-repository.yml would also need to be updated with this change.

Hello @jasminjohal-els, thank you for getting in touch.
Setting JF_GIT_AGGREGATE_FIXES to TRUE doesn't imply the creation of a PR for the scan-pr results.
When this flag is TRUE, it signifies that if multiple vulnerabilities are identified, their fixes will be consolidated into a single PR. Conversely, if set to FALSE, each vulnerability will be addressed in individual PRs.
Hence, the default value is FALSE, and it should stay that way for the time being.

Hello @jasminjohal-els and thank you for using Frogbot!
You are correct, JF_GIT_AGGREGATE_FIXES is related to scan-repository only and not scan-pr. Thank you for bringing it to our attention!
As for the default value for this env var- it should be FALSE in default


Missing Backlinks

While editing Zetteln, I don't see any backlinks in the top of the file, instead it shows a constant '0 backlinks'.
This was on a freshly installed Neuron + neovim + neuron.vim.
I checked the served rib generated html pages to make sure that the backlinks that should be visible in nvim are. The backlinks are displayed on the bottom of the HTML pages, but the same zettel in neuron.vim still shows '0 backlinks' at the top of the file.
Neuron Version: <IP_ADDRESS>
neuron.vim version: downloaded on 10th Nov. 2020
using neuron.dhall inside flat directory containing Zetteln

Are other zettels in the same directory ok? Or every zettel displays 0 backlinks?

It's the same for every Zettel

Will have a look into it - @beandipper does opening the backlinks buffer show you any backlinks?

The array of backlinks for every zettel is built inside neuron.vim using the output from neuron --query. It would be good to see that output or maybe a reproducible case with two zettels if that's easier.

I'm not sure which part of the JSON contains the backlinks, if it is the content of the "t": "Link" section, here is an example from neuron query
                {                   "t": "Link",                   "c": [                     [                       "",                       [],                       []                     ],                     [                       {                         "t": "Str",                         "c": "z:/1795fc73"                       }                     ],                     [                       "z:/1795fc73",                       ""                     ]                   ]                 },

thanks @beandipper - can confirm I am seeing it too, will see what is what.

Ok, have pushed an update to master. Please try that and report back. Thanks.

I've ran :PlugUpdate and :PlugUpgrade, but it seems to have not made a difference. I also refreshed the cache with gzr, but still no change. Are those the only to commands I have to give within vim to pull the latest update?

Sorry @beandipper - you indeed did the right commands. I didn't check the push. Please try again.

Thank you for your help, it does seem to work now, solved!

Do you think it would be possible in the future to display a preview of the backlinks when hovering over them, showing the information that the neuron webpage backlinks show on the bottom of the HTML pages

Great - glad to know it is resolved. Yeah I would expect some kind of hover would be possible. There are murmurs of an LSP being created so will see what happens on that front first as that would have hovers out of the box.


Fix #424 Update single owner cash flow spreadsheet

New energy and revenue cash flow variables

Things look good overall, but I did get this error code when testing it:
09:29:50: OLE Automation error in Range: error code 0
09:29:57: OLE Automation error in Range: error code 0
09:29:58: OLE Automation error in Range: error code 0
Not sure if that's new to this PR or not.

Those OLE Automation messages are not related to this PR -- that's an an ongoing minor issue with SAM's interactions with Microsoft objects.


Issue : Declaration of jsonSerialize() must be compatible #35

For the overload (or implementation of an interface) of a method to be valid, the signatures of the methods must be identical. Here, the jsonSerialize() method of the BenjaminHirsh/NovaSlugField/slug class must have the exact same signature as that of the Laravel/Nova/Fields/Field class.
To resolve this error, check the declaration of the jsonSerialize() method in the BenjaminHirsh/NovaSlugField/slug class and ensure that it has the same signature as that of the parent class Laravel/Nova/Fields/Field.

@tomhatzer Is there a chance that you can merge the pull request?
This would enable the package to be used with Nova v.4.x

It's not my pull request but I need the same change and I thought maybe I can speed things up when I ping you directly 😄
Worked 👍
Can you make the release directly 🙏

@tomhatzer 🙏 please make a new release with that change - would really appreciate it

@juergenZeindlinger done!

Thank you so much


Add Binary Operators to the Exception List for 'yield'

This is a stopgap that prevents us from parsing yield followed by an operator as a yield statement. This is not a fantastic solution in the long run because
_modify {
  yield += x
}

is meant to actually be a parse-time error under the current rules. I suspect the proper solution is to have an UnresolvedYieldSyntax node and make either ASTGen or operator folding do the right thing here. For now, fix the regression in parsing.

@swift-ci test


🐛 [Crashlytics] Crash when upgrading to Flutter 2.0.4

Bug report
../Dev/flutter/.pub-cache/hosted/pub.dartlang.org/firebase_crashlytics-0.2.4/ios/Classes/FLTFirebaseCrashlyticsPlugin.h:8:9: 'Flutter/Flutter.h' file not found
Steps to reproduce
Build app using Xcode 12.4
Additional context
No problem using:
Flutter 1.22.6 • channel stable • https://github.com/flutter/flutter.git
Tools • Dart 2.10.5

Flutter doctor
Run flutter doctor and paste the output below:
Click To Expand

[✓] Flutter (Channel stable, 2.0.4, on macOS 11.2.3 20D91 darwin-x64, locale en-GB)
    • Flutter version 2.0.4 at /Users/xxx/Dev/flutter
    • Framework revision b1395592de (4 days ago), 2021-04-01 14:25:01 -0700
    • Engine revision 2dce47073a
    • Dart version 2.12.2

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/xxx/Library/Android/sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.4, Build version 12D4e
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.55.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (2 available)
    • iPhone xxx (mobile) • xxx • ios            • iOS 14.4.2
    • Chrome (web)                 • chrome                    • web-javascript • Google Chrome xxx

• No issues found!

Flutter dependencies
Run flutter pub deps -- --style=compact and paste the output below:
Click To Expand
Dart 2.12.2 is incompatible with your dependencies' SDK constraints. Please run "pub get" again.
pub finished with exit code 65

@limoncello
There's similar open issue describing your case, https://github.com/FirebaseExtended/flutterfire/issues/5660
Please follow-up there for updates.
Closing this as duplicate.


OCM-2489: Fix useSpotInstances attribute usage

Refactor the code, to make it more clear
Populate state should set useSpotInstances only if it true, otherwise leave it empty
Prevent setting negative "max_spot_price"

/retest


[improve] [pip] PIP-356: Support Geo-Replication starts at earliest position

Motivation

DIscussion
[Vote] It has not been started yet

Modifications

Documentation

[x] doc
[ ] doc-required
[ ] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository: x

Should we support this config on namespace level or even topic level? Otherwise, some topics might have large backlog that users don't want to replicate.

Added

Sorry, I merged it with a mistake, I drafted another PR to revert the merging.

https://github.com/apache/pulsar/pull/22805

I sent an email to start the VOTE for this PIP, if the vote passes in the future, we can discard the PR that reverts current one


Remove unused private methods

Description
I realised there is a bunch of private/package private unused methods...
Since they are private and unused this is a PR to remove them
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff
[x] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #4926 (391dab7) into main (8c9ca4e) will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #4926      +/-   ##
============================================
+ Coverage     70.78%   70.81%   +0.02%
+ Complexity    57906    57901       -5
============================================
  Files          4689     4689
  Lines        276991   276914      -77
  Branches      40311    40302       -9
============================================
+ Hits         196074   196097      +23
+ Misses        64677    64583      -94
+ Partials      16240    16234       -6

Impacted Files
Coverage Δ

.../opensearch/gradle/info/GlobalBuildInfoPlugin.java
37.15% <ø> (+0.59%)
:arrow_up:

...ain/java/org/opensearch/painless/antlr/Walker.java
85.01% <ø> (+0.18%)
:arrow_up:

...admin/indices/segments/IndicesSegmentResponse.java
73.86% <ø> (+8.86%)
:arrow_up:

...ava/org/opensearch/cluster/node/DiscoveryNode.java
89.83% <ø> (+3.68%)
:arrow_up:

...main/java/org/opensearch/index/engine/Segment.java
71.42% <ø> (+5.47%)
:arrow_up:

.../opensearch/index/mapper/DocumentMapperParser.java
90.14% <ø> (+7.02%)
:arrow_up:

...org/opensearch/index/query/ExistsQueryBuilder.java
93.54% <ø> (+15.42%)
:arrow_up:

...ain/java/org/opensearch/ingest/IngestMetadata.java
98.14% <ø> (+5.16%)
:arrow_up:

...ava/org/opensearch/snapshots/SnapshotsService.java
47.50% <ø> (+0.67%)
:arrow_up:

...a/org/opensearch/test/OpenSearchIntegTestCase.java
57.17% <ø> (+1.21%)
:arrow_up:

... and 472 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nknize Any underwater mines you know of with this?


feat(postgraphql): Provide mechanism to add data to resolver context

Add an optional parameter called additionalGraphqlContextFromRequest to the options object supplied to the postgraphile middleware here
This should be provided an async function which resolves to an object. It will be called upon graphql requests, and provided the incoming request object. The resultant object is then applied to the context passed to all graphql resolvers.
This will allow us to add extra information from the request into the graphql resolver context, which when writing custom plugins will be useful for instances such as personalisation or auth flows outside of postgres.
Cheers for the library, think it's awesome.

Changed the head to benjie/graphql-build so had to rebase to remove the postgraphile commits. (Currently master is v3; v3 gets merged into v4 periodically (which is benjie/graphql-build branch) that is then released as postgraphql@next, and then postgraphile is rebased on benjie/graphql-build and released. Fun times.

Thanks again for this, I'm now using it in one of my projects 👍

No problem, we're actually moving slowly away from postgraphile now, turns out our simple little back end is turning into a horrible Goliath. But i use it for my projects now 👍 it does so much so fast

I'd be interested to hear more about this if you've time to jot down some rough thoughts in an email. Are you moving from logic in the database, or keeping that and moving to a simpler custom GraphQL schema? Have you considered using PostGraphQL behind another GraphQL schema generated with something like graphql-weaver?

Yeah we've got the postgraphile running against our postgres instance, and using apollo-tools to join that with a hand written schema + resolvers for other fields we want more control over.
We're losing some more of that now as we're actually making a complex DB structure that has a recursion in it, which means graphql can't really handle it as there's no concept of infinite depth recursion (understandably). So we're going custom for that too.
TBH our team wasn't comfortable putting too much logic into the DB, so that's where we break with philosophy and limit what we achieve with postgraphile, so it's not a limitation in postgraphile, just limits we placed on it ourselves 👍

Yeah; as you say the indefinite recursion is a limitation of GraphQL itself... You could potentially work around that by using a recursive CTE and generating a path string (e.g. <IP_ADDRESS>.<IP_ADDRESS>) so you can re-constructing the structure on the client. Another way would be to use a recursive CTE and just expose the results as JSON. Neither are perfect though - are you looking at switching that endpoint to REST, or...?
I think there's a lot of resistance about putting logic in the database just because it's not been the way that we're used to building things in web-dev, but with todays microservices/etc putting all the business logic in the most central location makes a lot of sense as it effectively prevents anything from bypassing it or corrupting the data. I heard someone the other day say "only using a ORDBMS to store data is like only using a car to store petrol" - I feel there's an amount of truth to that, but if you're using constraints, foreign keys, indexes, triggers and views you're still reaping a lot of the benefits even if you don't use it for access control, business logic, computed columns, etc.

I think we're looking at the JSON solution so you still obtain the graph through graphql, but requesting a certain field just returns a JSON blob. We'd been toying with putting the JSON in the db too, but that didn't sit well either. This is all very much in flux though! Thanks for the CTE link, i'm still learning postgres, that will definitely come in handy when I want this data back...
RE: the resistance to moving logic to the DB, one simple problem we have is the competence of the team, we're all JS devs and postgres although simple, is still not something we feel confident to do anything complicated with yet. We also had some discussion around the microservices idea, we'll be a monolith for the foreseeable future, but when splitting to micro services we would probably never have two services hitting the same DB, so there'd be no sharing there. Not sure if you have a use-case in mind where you'd have that?

toying with putting the JSON in the db too, but that didn't sit well either

Postgres' JSONB handling is pretty 👌  but no doubt you've factored that in when evaluating it.

is still not something we feel confident to do anything complicated with yet

That's fair enough - generally a good idea to make things in technologies where you already know the caveats!

Not sure if you have a use-case in mind where you'd have that?

The sharing of Postgres between multiple microservices? Might be for example if a job worker needs to access the same database as the web clients (to see the tasks they have queued); or if there's additional gateways into the same data (e.g. an SMTP or chat gateway) that requires similar permissions checks - having these go through the existing web API could be a performance bottleneck and would also add to latency. That said, there's a lot more scaling options this way so it definitely makes sense in some contexts! As with everything, it depends on the needs of your stack.


Update marketplace cli commands with last version of service marketplace

Dependant on https://github.com/mesg-foundation/core/pull/844
Output of commands look like:
➜ ./dev-cli marketplace purchase influxdb
? Enter the account to use 0x978369695a3758abc8c0706a9b7cee4b1cb9652c
? Enter passphrase *
? Enter the offer index to purchase 0
? Are you sure to purchase service "influxdb" for 20 MESG Tokens and a duration of 60 seconds? Yes
✔ Offer index "0" of service "influxdb" purchased with success and expires on 2019-04-05 18:45:24 +0700 +07

➜ ./dev-cli marketplace create-offer com.mesg.bitcoin
? Enter the account to use 0x978369695a3758abc8c0706a9b7cee4b1cb9652c
? Enter passphrase *
? Enter the price (in MESG Token) of the offer 1000
? Enter the duration (in second) of the offer 30
? Are you sure to create offer for service "com.mesg.bitcoin" with a price of 1000 MESG Tokens and a duration of 30 seconds? Yes
✔ Offer created with success with index "0"
✔ See it on the marketplace: https://marketplace.mesg.com/services/com.mesg.bitcoin#offers

➜ ./dev-cli marketplace publish ../services/service-bitcoin
? Enter the account to use 0x978369695a3758abc8c0706a9b7cee4b1cb9652c
? Enter passphrase *
✔ Image built with success
✔ Service deployed with sid com.mesg.bitcoin and hash 55sdquWL8U6sujUyRjYS5xQFiSdGFemPjbtcYkdQXRgw
? Are you sure to publish a new version of service "com.mesg.bitcoin" from path "../services/service-bitcoin" using account "0x978369695a3758abc8c0706a9b7cee4b1cb9652c"? Yes
✔ Service published with success with sid "com.mesg.bitcoin" and marketplace hash "HNybfCZZw6uKSArfPjZbeF6R7FJznGLFC8dr3SvcFS13"
✔ See it on the marketplace: https://marketplace.mesg.com/services/com.mesg.bitcoin/HNybfCZZw6uKSArfPjZbeF6R7FJznGLFC8dr3SvcFS13
✔ To create a service offer, execute the command:
	mesg-core marketplace create-offer com.mesg.bitcoin

diff --git a/systemservices/marketplace/mesg.yml b/systemservices/marketplace/mesg.yml
index 1452a275..c1da8997 100644
--- a/systemservices/marketplace/mesg.yml
+++ b/systemservices/marketplace/mesg.yml
@@ -3,7 +3,7 @@ sid: marketplace
 description: ""
 configuration:
   env:
-    - PROVIDER_ENDPOINT=https://ropsten.infura.io/v3/6115ae2531f64c04a9a392cf500e5fbe
+    - PROVIDER_ENDPOINT=https://localhost:1234

If you change ENDPOINT then marketplace stucks on
⣯ Publishing service on the marketplace...

Forever (or maybe there is some timeout but it would be strange to have timeout to nonexisting port)

diff --git a/systemservices/marketplace/mesg.yml b/systemservices/marketplace/mesg.yml
index 1452a275..c1da8997 100644
--- a/systemservices/marketplace/mesg.yml
+++ b/systemservices/marketplace/mesg.yml
@@ -3,7 +3,7 @@ sid: marketplace
 description: ""
 configuration:
   env:
-    - PROVIDER_ENDPOINT=https://ropsten.infura.io/v3/6115ae2531f64c04a9a392cf500e5fbe
+    - PROVIDER_ENDPOINT=https://localhost:1234

If you change ENDPOINT then marketplace stucks on
⣯ Publishing service on the marketplace...

Forever (or maybe there is some timeout but it would be strange to have timeout to nonexisting port)

Can you check the log of the service? ./dev-cli service logs marketplace.
I think the service throw an error and actually never properly start. This is not an issue only related to this service but to all service. The core doesn't check if the service is properly running before sending a task.

Yes it throws error, but at the same time
EQcbh3CqmjdxFatGao959tc5VQkX3j7DJToMYvQoR2VK    marketplace                                      Marketplace        running
Is still running, so, in that case, can task return error as well, or service should be killed (and it will be seen as stopped )


EDGE 97 Excel Policy template not updated - Similar issue on every new release

Hi Microsoft Team,
EDGE 97 Excel policy template is not updated in below link. Please check and update.
https://www.microsoft.com/en-us/download/details.aspx?id=55319
https://techcommunity.microsoft.com/t5/discussions/latest-edge-browser-policies-in-excel-template-not-showing-not/m-p/3054347

@Y-Kelly, Could you please check this?

@NConnects Hi!  I would recommend checking out https://techcommunity.microsoft.com/t5/microsoft-security-baselines/bg-p/Microsoft-Security-Baselines to monitor when the update is available.
You can also provide feedback to the team directly through the Security Baseline Community https://techcommunity.microsoft.com/t5/microsoft-security-baselines/bd-p/Security-Baselines.  Thanks!

Hi Y-Kelly, But, still i dont see the baseline for EDGE 97 in mentioned link
https://techcommunity.microsoft.com/t5/microsoft-security-baselines/bg-p/Microsoft-Security-Baselines

@Y-Kelly , Still I don't see EDGE 97 Compliance baseline templates. It should get updated after every new release. In the mentioned link, I could see only EDGE 96.


pushes unneeded files into the stream when options are - module: amd, out: file.js, noExternalResolve: false

Expected behavior:
Should not pull a file in the output file when the following options are used:
module: 'amd',
out: 'file.js',
noExternalResolve: false

Reasoning:
Just like described in the docs under section Resolving files:

Files that are resolved when noExternalResolve is off, won't be pushed to the output stream, unless you are using the out option.

Well, I'm using module amd and I need to use out option so that define functions are generated with unique names. However, it results in resolved files also being pushed into the stream, which is not desirable.
Your gulpfile:
gulp.task('client-modules', function () {
    var tsProject = $.typescript.createProject({
        removeComments: true,
        module: 'amd',
        outFile: 'app.js',
        noExternalResolve: false
    });

    var tsResult = gulp.src(globs.clientModules.concat(globs.types))
        .pipe($.typescript(tsProject));

    return tsResult.js
        .pipe(gulp.dest(destinations.client));
});

tsconfig.json
not related
Code
file /common/misc.ts
class Misc {

}
export = Misc;

file /feature1/a.ts
import Misc = require('../common/misc');
class A {
    constructor(private misc: Misc) {}
    // actual Misc is not used. Only its type definitions
}
export = A;

file /feature1/b.ts
import Misc = require('../common/misc');
class B {
    constructor(private misc: Misc) {}
    // actual Misc is not used. Only its type definitions
}
export = B;

After running the gulp task I get something like this:
define("common/misc", ["require", "exports"], function (require, exports) {
    // common/misc code
    // This code should not be here. It should be in a separate file so that it can be
    // reused by other features of the website
});
define("feature1/a", ["require", "exports"], function (require, exports) {
    // feature one/a code...
});
define("feature1/b", ["require", "exports"], function (require, exports) {
    // feature one/b code...
});

When you use out or outFile, all files are emitted. That is by design. However, when you remove outDir and use something like gulp-concat, you will not get those unneeded files.

I saw that this is by design. Though I think it's incorrect when using module amd. I cannot remove out and use gulp-concat because in this case it'll come out as this:
define(["require", "exports"], function (require, exports) {
    // feature one/a code...
});
define(["require", "exports"], function (require, exports) {
    // feature one/b code...
});

Notice that define functions don't have names (first param), which is required when having multiple amd modules in a single file.

Could you use gulp-amd-optimizer? Or gulp-name-amd? I cannot change this, since it would be a large breaking change and it might not even be possible with TypeScript.

That looks like it could solve this issue. I'll give it a try right now and let you know how it went.

So both of these options didn't work for me. gulp-amd-optimizer was throwing an error that I could not figure out quickly, and gulp-name-amd does not take path into consideration and only uses file name so you may end up with duplicate module names.
I searched around more and could not find a decent solution, which led me to trying to switch to module: 'system', which looked promising, but I quickly stumbled in the exact same issue. Running gulp-typescript without out parameter generates unnamed System.register() functions, which leads to the error when these are placed in a single file.
What is the reason of pulling all resolved deps into the stream when out option is used? I can't see the logic. It would seem to me that noExternalResolve should have dominance.

What is the reason of pulling all resolved deps into the stream when out option is used? I can't see the logic. It would seem to me that noExternalResolve should have dominance.

First of all, noExternalResolve: false means that all files are resolved and provided to TypeScript. TypeScript will use these files for type checking and it will also emit all files. Setting this to true would cause error messages that a file cannot be found.
Unneeded files are filtered out after the compilation. That works when you don't set outFile, but when you set that option only one file is emitted. Thus, it was not possible to filter these files when outFile was set. It might now be possible to emit only specific files, though I'm not sure about that. I cannot change this now as it would be a breaking change, though I can change it in a next major version when #190 is solved.

I've taken a look at this, and it isn't possible to do this with the TypeScript API. So we have to keep the current behavior for this situation.


[meta] request for admin permission to the termbox-haskell repo

Hey! I was thinking of pulling the termbox-haskell repo out of this org and back under my own control. It seems to be the odd one out, as other language bindings are also in separate orgs.
But I'm not authorized to move the repo location (via Settings). Could I get permission?
Thanks :v:

Ping!

Hi @mitchellwrosen I made you an admin. Let me know if that works for you.


Error while cleaning markers on ionic wrapper

I'm submitting a ...  (check one with "x")
[ ] question
[x] any problem or bug report
[ ] feature request
The plugin version:  (check one with "x")
[ ] 2.0-beta3 (github)
[x] 2.0 (npm)
If you choose 'problem or bug report', please select OS:  (check one with "x")
[x] Android
[ ] iOS
cordova information:  (run this.map.clear();)
main.js:1122 TypeError: Cannot read property 'apply' of undefined
    at Marker.trigger (BaseClass.js:62)
    at Marker.remove (Marker.js:112)
    at clearObj (Map.js:268)
    at Map.clear (Map.js:277)
    at vendor.js:52912
    at new t (polyfills.js:3)
    at GoogleMap.clear (vendor.js:52911)
    at GoogleMap.value [as clear] (vendor.js:128009)
    at MapsPage.<anonymous> (main.js:1111)
    at step (main.js:1022)

If you use @ionic-native/google-maps, please show me the package.json
"@ionic-native/google-maps": "^4.3.2",
<plugin name="cordova-plugin-googlemaps" spec="^2.0.11">

Current behavior:

Expected behavior:

Steps to reproduce:

Screen capture or video record:

Related code, data or error log (please format your code or data):
insert any relevant code, data, or error log here

I had a comparable issue when upgrading ionic from 4.2.1 to 4.3.3 _this.get('_overlays') on the GoogleMap object was null (This could stem from the same issue) maybe try to downgrade @ionic-native to 4.2.1

I'm having this same issue. However, the latest version of Ionic appears to be 3.7.1, so not sure if @Luttik is referring to a different platform or if he is using a beta version?
Either way, the _this.get('_overlays') issue was fixed when I updated @ionic-native/google-maps to v5.5.1 and this issue highlighted by @jalescardoso appeared when I tried to clear my markers. I don't think that's a solution to the issue, unfortunately. but I'd love to hear one! :)

@fablrdigital Yeah, sorry for not being clear. I was talking about ionic-native. More specifically @ionic-native/google-maps (but I believe they suggest to keep all ionic-native plugins at the same version).

@Luttik That makes more sense and I should probably have put two and two together and figured it out. I guess downgrading would be the interim solution in this instance, then.

Please try to use #multiple_maps branch.

$> cordova plugin rm cordova-plugin-googlemaps

$> npm uninstall @ionic-native/core @ionic-native/google-maps

$> cordova plugin add<EMAIL_ADDRESS>--variable API_KEY... --no-fetch

$> npm install<EMAIL_ADDRESS><EMAIL_ADDRESS>

Thanks @wf9a5m75 ! everything working here.


Split out unittest classes to avoid potential racing conditions when running in Python 3.11 and 3.12

Description

When test classes share some physical resources (e.g., file storage), some potential racing conditions could happen  in Python 3.11 and 3.12 if these classes are stored in one source file.
How Has This Been Tested?

[X] Tested in a local development environment

Checklist

[ ] The PR is tagged with proper labels (bug, enhancement, feature, documentation)
[X] I have performed a self-review of my own code
[ ] I have added unit tests that prove my fix is effective or that my feature works
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation

cc:

@wangxiaoyou1993

@wangxiaoyou1993 PTAL

Merged the relevant changes in https://github.com/mage-ai/mage-ai/pull/5393.


envoy: Include Cilium NetworkPolicies in Envoy Config Dump

This commit updates the Cilium Proxy docker image to the latest version (797bea843de17da8f8a096747c4691405b540aa8).
This provides the enhancement that Cilium NetworkPolicies are now part of Envoys Config Dump and therefore part of Ciliums SysDump (cilium/proxy#184)
Cilium L7 Proxy: Envoy config dump contains Cilium network policies

/test

marking this as ready-to-merge - with the main intention to bring this into v1.14.0-snapshot.2
@sayboras already covered all SIGS (vendor & build)

Merged and thanks :heavy_check_mark: