Added aria attributes to login and contact form

Description

Added aria roles to the forms
Included descriptive aria labels using the aria-label attribute.
Implemented ARIA states (e.g., aria-required for required fields).

Pull Request Checklist
Please make sure that your PR meets the following requirements:

[x] The app is working correctly after applying the changes.
[x] The app is responsive and displays properly on different screen sizes and devices.
[x] The changes are thoroughly documented in the appropriate files or documentation sections.
[x] The coding conventions and style guidelines are followed consistently.

Checklist
Please check all applicable boxes and provide any additional information if needed.

[x] I have tested the changes locally and ensured that the app is functioning as expected.
[x] I have verified that the app is responsive and looks good on various screen sizes and devices.
[x] I have reviewed the documentation and ensured that it accurately reflects the changes made.
[x] I have followed the coding conventions and style guidelines defined in the project.
[x] I have run the automated tests and all of them pass.
[x] I have considered the performance implications of the changes made.
[x] I have considered the security implications of the changes made.
[x] I have checked for any potential regressions or side effects caused by the changes.
[x] I have performed a self-review of my code.
[x] Starred the repository.
[x] Added My Name to the Contributor's List.
[x] Followed the repository's Contributing Guidelines.
[x] I ran the app and tested it locally to verify that it works as expected.

Related Issues
#521

Thanks for this @Avinash905 . I am curious to know the accessibility score of this website on different metrics. Are you aware of any testers online ?

Thanks for this @Avinash905 . I am curious to know the accessibility score of this website on different metrics. Are you aware of any testers online ?

You can use the lighthouse report to generate accessibility

@Harshil-Jani Could you please add level label too?


Dynamically generated forms : seeking some help

Hello,
I'm trying to implement dynamically generated forms : the goal is that a user can choose the position and type of inputs within a form.
You can take a look at this basic twiddle, which shows both a static and dynamic forms.
With basic form elements (text, email, textarea...), it should work. But I met a problem with a custom type (a masked-input component).
In a static form, I'm using this code, which works pretty well:
  {{#form.element property="phoneNumber" as |el|}}
  	{{masked-input mask='<IP_ADDRESS>.11' classNames='form-control input' value=el.value}}
  {{/form.element}}

In a dynamic form, I refered to #299, and created a custom control at /component/bs-form/element/control/masked-phone and used the following code:
  {{form.element controlType="masked-phone" property="phoneNumber" }}
This problem with this method is that it is creating an additional div, surrounding the input (highlighted in red in the twiddle), with an "****-field" id, that breaks my layout.
Is there a mean to make the form element NOT generate this div ?
Thank you, and sorry for the lengthy post :-/

@Moxide The <div> comes from your bs-form/element/control/masked-phone component, not form ember-bootstrap itself. Just make this a tagless component by adding tagName: ''
See https://ember-twiddle.com/e2879dd5a9b9b07211e48351f31b6087?openFiles=components.bs-form.element.control.masked-phone.js%2C

Thank you very much ! Sorry, I completely missed this !!!


Development: Fix issues with LTI 1.3 deep linking service for openedX

Checklist
General

[ ] This is a small issue that I tested locally and was confirmed by another developer on a test server.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Server

[x] Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
[x] I strictly followed the server coding and design guidelines.
[x] I added multiple integration tests (Spring) related to the features (with a high test coverage).
[x] I added pre-authorization annotations according to the guidelines and checked the course groups for all new REST Calls (security).
[x] I documented the Java code using JavaDoc style.

Client

[x] Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
[x] I strictly followed the client coding and design guidelines.
[x] Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
[x] I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
[x] I added authorities to all new routes and checked the course groups for displaying navigation elements (links, buttons).
[x] I documented the TypeScript code using JSDoc style.
[x] I added multiple screenshots/screencasts of my UI changes.

Motivation and Context

This PR fixes current deep linking service implementation to be able used by openedX configurations as well.
Description

Combined the 'auth-callback' and 'deep-link' endpoints into a single controller method. This streamlines application routing, ensuring consistent handling of related LTI 1.3 processes.
Corrected the deep linking response content items JSON to make it more universally parsable across various scenarios.

Steps for Testing

Prerequisites:

Please deploy to TS5 where lti profile is enable and already prepared for easy testing

Log in to openedX Studio https://studio.openedx.ase.cit.tum.de/home/ (Studio is the edX tool you use to build your courses) with one of the instructors (i.e. artemis_test_user_11)
Click on "Introduction" section
Navigate to first "Unit" subsection
Click on the link at the bottom part of the LTI Consumer Block "Deep Linking Launch - Configure tool"
Verify you will be directed to Artemis login page where you need to login using same instructor credentials.
Select the couse and verify you are navigated into selecting exercises page.
Select one of the exercises listed.
Verify you see deep linking successfull and close the frame message on the page.
Close the tab and go back to previous tab refresh the page and verify you see selected exercise link and title as json object on the bottom side of the lti consumer block.

Testserver States

[!NOTE]
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked

Review Progress

Performance Review

[ ] I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance
[ ] I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

[ ] Code Review 1
[ ] Code Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

Test Coverage

Client

Class/File
Line Coverage
Confirmation (assert/expect)

edit-lti-configuration.component.ts
85%
✅

lti-configuration.component.ts
94.73%
✅

lti-configuration.service.ts
88.88%
✅

edit-course-lti-configuration.component.ts
82.5%
✅

Server

Class/File
Line Coverage
Confirmation (assert/expect)

Lti13DeepLinkingResponse.java
82%
✅

Lti13LaunchRequest.java
97%
✅

LtiResourceLaunch.java
76%
✅

LtiPlatformConfigurationRepository.java
76%
✅

Lti13LaunchFilter.java
100%
✅

Lti13Service.java
88%
✅

LtiDeepLinkingService.java
97%
✅

AdminLtiConfigurationResource.java
86%
✅

OnlineCourseDTO.java
100%
✅

PublicLtiResource.java
97%
✅

Screenshots

Summary by CodeRabbit

New Features

Updated LTI integration with a new endpoint for handling LTI 1.3 Deep Linking Request Responses.

Enhancements

Improved content item representations for LTI deep linking with support for complex structures.
Enhanced flexibility by using a variable for client registration ID in LTI configuration.

Bug Fixes

Ensured consistency in deep linking URL paths for correct routing.

Tests

Updated tests to align with changes in deep linking URL paths and content item representation.

Manually tested on TS5, works as expected


Loading index.html errors on link 597 of main-number.js file

Hello!
I think this is a great mod, however, I am having trouble just viewing the default html file on windows.
It should be able to run seeing the code there, however, it is unable to load the mapshot.json due to the link being a file:/// rather than http://
I have tried editing the js file that is generated from however it isn't following my change.
I was wondering if you've tried this, or if this is not possible.

Trying out the exe file... Read then comment..
Will see if that fixes the issues. :)

Trying out the exe file... Read then comment..
Will see if that fixes the issues. :)

Yeah, the exe fixes the problem. Sorry about that.
Note, when loading the exe, run in a cmd window so you can see the output for anyone who doesnt know how to use the exe.
You will probably have to point it at your factorio installation if its on steam.
And you don't need to defign which map to show, it will list them.

Yeah, the exe fixes the problem. Sorry about that.
Note, when loading the exe, run in a cmd window so you can see the output for anyone who doesnt know how to use the exe.
You will probably have to point it at your factorio installation if its on steam.
And you don't need to defign which map to show, it will list them.

Hey Palats!
Fantastic mod!
Yes, the cmd window did immediately close. And I QUITE like the map tool.
I would love to give you more feedback on it if you're interested, I have lots of ideas and questions.
The whole reason I was thinking of it, was to look for something like Dynmap for Minecraft.
On the maps I've rendered yesterday, they all had a 1px gap between the images on the map, is this normal?

Hey Palats!
Fantastic mod!
Yes, the cmd window did immediately close. And I QUITE like the map tool.
I would love to give you more feedback on it if you're interested, I have lots of ideas and questions.
The whole reason I was thinking of it, was to look for something like Dynmap for Minecraft.
On the maps I've rendered yesterday, they all had a 1px gap between the images on the map, is this normal?

Thanks for the feedback! I'm happy with ideas/questions - Github issues & Factorio mod discussion pages (https://mods.factorio.com/mod/mapshot/discussion) are fine places for those. Though of course I make no guarantees :) I tend to work on mapshot only periodically. I guess once Factorio 1.1 gets released I will do another pass.
For Dynmap - I've used it for Minecraft, it is nice. Unfortunately, it is not possible to do something similarly real-time with Factorio, as the plugins are much more limited (Minecraft plugins basically patch Minecraft code, while Factorio as a clean API surface). I have one idea to simulate it, but that would be a terrible hack.
For the gaps between tiles - indeed, that's an issue. It comes from Leaflet, the map library I'm using. I've open https://github.com/Palats/mapshot/issues/4 to track it (somehow I got use it and never took a stab so far).

Thanks for the feedback! I'm happy with ideas/questions - Github issues & Factorio mod discussion pages (https://mods.factorio.com/mod/mapshot/discussion) are fine places for those. Though of course I make no guarantees :) I tend to work on mapshot only periodically. I guess once Factorio 1.1 gets released I will do another pass.
For Dynmap - I've used it for Minecraft, it is nice. Unfortunately, it is not possible to do something similarly real-time with Factorio, as the plugins are much more limited (Minecraft plugins basically patch Minecraft code, while Factorio as a clean API surface). I have one idea to simulate it, but that would be a terrible hack.
For the gaps between tiles - indeed, that's an issue. It comes from Leaflet, the map library I'm using. I've open https://github.com/Palats/mapshot/issues/4 to track it (somehow I got use it and never took a stab so far).


Environment variables in docker for connection

Idea Statement
First of all, I want to express my gratitude for such a wonderful product that I use often. However, there is one thing that I am missing, given that I often use ch-ui for testing and writing SQL queries.
It would be great to add support for Docker container variables as connection parameters.
For example:
CLICKHOUSE_URL
CLICKHOUSE_USER
CLICKHOUSE_PASS

So that when the container starts, you can specify the variables that ch-ui will add as connection settings and you don’t have to enter them manually in the settings
Like this:
docker run -p 5521:5521 -e CLICKHOUSE_URL=localhost:5432 -e CLICKHOUSE_USER=default -e CLICKHOUSE_PASS=some_password ghcr.io/caioricciuti/ch-ui:latest
Feature implementation brainstorm
No response

Hey, @Zerpico, hope all is good!
Ut's doable for sure! I'll see if I can implement it soon.
Thank you for using ch-ui! I'm glad it helps the community!

Hey it's added, since the tools uses vite, the env variables start with VITE_
docker run -p 5521:5521 \
  -e VITE_CLICKHOUSE_URL=http://your-clickhouse-server:8123 \
  -e VITE_CLICKHOUSE_USER=your-username \
  -e VITE_CLICKHOUSE_PASS=your-password \
  ghcr.io/caioricciuti/ch-ui:latest


EXCEPTION_ACCESS_VIOLATION_READ in getParsersEventHandler

https://sentry.adguard.com/adg/adguard-windows/issues/19149

https://sentry.adguard.com/adg/adguard-windows/issues/19139

Fixed in 1.3.250


fix readthedocs build

This PR follow the required changes by readthedocs
https://grobid.readthedocs.io/en/fix-doc/

coverage: 39.977% (-0.003%) from 39.98% when pulling 7f62e1194e62c045825cfd939ee91d2d858fba58 on fix-doc into 2c720dd55344f48edab83f636f9bff640a92fbdc on master.


Fix error when calling str() or repr() on GCS SeekableBufferedInputBase

Fix __repr__ and __str__ on gcs.SeekableBufferedInputBase by storing the bucket as _bucket instead of bucket.
This is now consistent with gcs.BufferedOutputBase and s3. _SeekableRawReader (which stores its S3 client as _object)
Motivation
We were seeing logging errors originating from smart_open:
Traceback (most recent call last):
  File "/usr/local/lib/python3.8/logging/__init__.py", line 1081, in emit msg = self.format(record)
  File "/usr/local/lib/python3.8/logging/__init__.py", line 925, in format return fmt.format(record)
  File "/usr/local/lib/python3.8/logging/__init__.py", line 664, in format record.message = record.getMessage()
  File "/usr/local/lib/python3.8/logging/__init__.py", line 369, in getMessage msg = msg % self.args
  File "/usr/local/lib/python3.8/gzip.py", line 220, in __repr__ s = repr(self.fileobj)
  File "/usr/local/lib/python3.8/site-packages/smart_open/gcs.py", line 379, in __repr__ self.__class__.__name__, self._bucket.name, self._blob.name, self._current_part_size, AttributeError: 'SeekableBufferedInputBase' object has no attribute '_bucket'

Merged. Thank you @robcowie for your contribution!


Month filter numbers inconsistent

When filtering by month, 2 scenes appear to be ignored:
With all months filtered on, which should be the same as no months filtered on, there is a 2 scene difference. This may be an issue with the way the query is constructed or the importer.

This can be closed. It was determined this was expected behavior since acquisition date is optional, though highly recommended.

On a related note, there's currently no way to filter on stuff that has no acquisition date. Do you think of a use case where someone would want to?

Good question. I can't think of one, so let's hold off on dealing with it until we need to. I don't think it makes things complicated in the short-term and it's another filter we can add later if we need to.


Oj 2 and 3 support

By using dynamic definition, we can support both versions with only
tiny cost at start-up.  Oj3 has made its option hash more like the
JSON gem's, but duplicate "by hand" the "pretty" option hash as it's
small and slow-changing enough, and to avoid surprises with new Ruby
versions.
Closes #181

Fixed in https://github.com/intridea/multi_json/commit/5d8febdbebc428882811b90d514f3628617a61d5


fix not(null) with constant null

Which issue does this PR close?

Closes #1191.
Rationale for this change

df not expression can not take NULL like
> select not(null);
Internal("NOT 'Literal { value: Utf8(NULL) }' can't be evaluated because the expression's type is Utf8, not boolean")

the correct output should be NULL
What changes are included in this PR?

NotExpr accepts  NULL input presented as ScalarValue::Utf8(None)
Are there any user-facing changes?

NO.

cc @alamb @Dandandan @yjshen
plz have a review, thank you.

Is there any Null transform rule (doc) in datafusion?

rule

@Ted-Jiang I'm afraid there is not.
Maybe most of expressions (except for string expressions like concat, concat_ws, etc) should  return NULL when accept NULL IMO

I wonder if it would be helpful to add a test in datafusion/core/tests/sql somewhere to show a query like SELECT null, not(null) working?

@alamb OK, will add more tests:

SELECT not(true), not(false) = false, true
SELECT null, not(null) = NULL, NULL
SELECT NOT('hi'), type check error would raise.

@alamb PTAL, thank you.

@Dandandan @yjshen @xudong963 PTAL, thank you!

cc @yjshen @xudong963 @liukun4515 @Dandandan  PTAL, thank you!


Sparklyr code is not working for Apache Spark version 3.3

When using a Spark Pool with version 3.3, the following piece of code provided by the documentation:
%%sparkr
spark_version = sparkR.version()
config = spark_config()
sc = spark_connect(master = 'yarn', version = spark_version, spark_home = '/opt/spark', config = config)

gives the following error:
Error: [1] 'Error: org.apache.spark.SparkException: The Spark SQL phase analysis failed with an internal error. Please, fill a bug report in, and provide the full stack trace.....
Basically any operation that includes the object sc, fails with the above error, with the exception of spark_connection_is_open(sc) which yields the value TRUE.
By adding the argument method='synapse', like this:
%%sparkr
spark_version = sparkR.version()
config = spark_config()
sc = spark_connect(master = 'yarn', version = spark_version, spark_home = '/opt/spark', config = config, method='synapse')

The error does not appear any longer. However this is not reflected on the documentation.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 94f90a2e-f64f-0cd9-30f4-4c0c059b9491
Version Independent ID: 797f4bcf-fde9-7d05-5314-020dd9262d14
Content: Use R for Apache Spark - Azure Synapse Analytics
Content Source: articles/synapse-analytics/spark/apache-spark-r-language.md
Service: synapse-analytics
Sub-service: spark
GitHub Login: @midesa
Microsoft Alias: midesa

@bernobfer
Thanks for your feedback! We will investigate and update as appropriate.

@bernobfer
Thanks for reporting this! We have created a PR for this issue and the changes should go live soon.


Added include query option

Adds option to write a condition for the include query so that one can make a call as follows
Adds strict property that changes OPTIONAL MATCH to MATCH for relationship selection if set to true
const opts = {
  varName: 'person',
  include: {
    'Student': {
      model: Student, // assume imported at the top
      relName: 'IS_STUDENT_OF',
      many: true,
      strict: true,
      where: { university: 'LP' }
    }
  }
};
Person.findAll(opts, function(err, results) {
  // will result return only Persons that have a relation to Student with a `university` property === 'LP'
})

supports multiple include queries
Additionally this PR adds in option for the query condition, example with multiple queries and in statement below
const opts = {
  varName: 'person',
  include: {
    'Student': {
      model: Student, // assume imported at the top
      relName: 'IS_STUDENT_OF',
      many: true,
      strict: true,
      where: { university: 'LP' }
    },
    'City': {
      model: City, // assume imported at the top
      relName: 'IS_CITY',
      many: true,
      strict: true,
      where: { name: ['Lviv', 'Kyiv', 'Bergen'] }
    }
  }
};
Person.findAll(opts, function(err, results) {
  // will result return only Persons that have a relation to Student with a `university` property === 'LP'
  // and with has relation to City with `name` value in `['Lviv', 'Kyiv', 'Bergen']`
})

if strict option is not set OPTIONAL MATCH will be performed, so that all the records for the Person will be returned, and only those that have relation will be extended.
The only restriction is that all the strict include relations should be placed before the non-strict ones, as MATCH can't follow OPTIONAL MATCH
All tests are passing

@jonpacker
Hope it's descriptive enough. Should bring any breaking changes. If you have any questions ping me.


Migrate interactive functions to modal container exec

Looks good to me, may need to edit it to pass tests (lmk if you need help with this!)


New version: StandardNotes.StandardNotes version 3.9.8

ARP entries are correct.
Auto-updated by vedantmgoyal2009/winget-pkgs-automation in workflow run 948
Microsoft Reviewers: Open in CodeFlow

Issue is being tracked at https://github.com/standardnotes/desktop/issues/795


Support for different help messages for same argument in different constructors

I don't know if it's possible, but something like:
data Example1 =
  Example1
    { foo :: Int    <?> "Documentation for the foo flag in Example1"
    , bar :: Double <?> "Documentation for the bar flag in Example1"
    }
  | Example2
    { foo :: Int    <?> "Documentation for the foo flag in Example2"
    , bar :: Double <?> "Documentation for the bar flag in Example2"
    }

    deriving (Generic, Show)

Probably requiring some type of record fields. This feature would be quite useful in that you could have a program with multiple entry points with the same arguments, such as input but take in different formats.

@GregorySchwartz: I don't think it's possible, mainly due to a Haskell restriction requiring fields of the same name to have the same type for different constructors and the help text is part of the field type


Helped with typos

Hey.
I notices an issue (https://github.com/PaulCoral/Compile-Time-LL1-Parser/issues/3) and thought I would give it a try.
Hope I was of help.

Hey.
I notices an issue (https://github.com/PaulCoral/Compile-Time-LL1-Parser/issues/3) and thought I would give it a try.
Hope I was of help.

Yes thanks a lot !


Add support for url config source

We should be able to download a manifest directly from a url.

/assign @Akado2009


[0.4] some receptor fingerprint cannot print neurotransmitters

see https://github.com/FZJ-INM1-BDA/siibra-python/actions/runs/3969041796/jobs/6802998498
to reproduce:
from siibra.features.molecular.receptor_density_fingerprint import ReceptorDensityFingerprint

all_features = ReceptorDensityFingerprint.get_instances()

for feature in all_features:
    assert isinstance(feat, ReceptorDensityFingerprint)
    print(feat.name, feat.id)
    print(feat.unit)
    print(feat.neurotransmitters)
    print(feat.data)

issue narrowed down to ill(?) formed tsv
e.g. preconf file at features/fingerprints/receptor/f61c27af-d18e-4abc-9b02-96c09d49e542_CA1_fp_20200217_RAT_CORNU_AMMONIS_1_V3.json , tsv file contained within is malformed:
curl 'https://object.cscs.ch/v1/AUTH_227176556f3c4bb38df9feea4b91200c/hbp-d000045_receptors-rat-CA1_pub/v2.0/CA1_fp_20200217.tsv'

returns
"receptor label (CA1)"  "density (mean)"        "density (sd)"  "density (unit)"
"AMPA"  4199    350     "fmol/mg"
"kainate"       669     51      "fmol/mg"
"NMDA"  5290    318     "fmol/mg"
"GABAA" 1254    100     "fmol/mg"
"M1"    1530    73      "fmol/mg"
"M2"    333     49      "fmol/mg"
"alpha1"        223     19      "fmol/mg"
"alpha2"        430     51      "fmol/mg"
"5-HT1A"        811     168     "fmol/mg"
"5-HT2" 34      15      "fmol/mg"

pandas will interpret the keys to be e.g. "AMPA" rather than expected AMPA, leading to key error

Should be fixed in 07788bd5e3b7

@AhmetNSimsek can you confirm and close the issue?


fix: link font size inherit issue

:tada: This PR is included in version 1.11.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


User Inventory Float Value

Hi, I know that the repository is not maintained or support anymore but did anyone found a way to get the float value?

@Banana0008 the float value of what? the script wasw updated a few years back to include csgo float values.

Closing, as the issue is null. Already included within the script.

What I mean is to return me the actual value of the float ex: AWP I Dragon Lore (Fiel-Tested) 0.014554 --> This Value

https://github.com/pepzwee/node-csgo-web-tradebot/blob/master/lib/bots.js#L155-L184
Floats are for bots, not user inventories. Code might need updating if it's not working.
Good luck.

@pepzwee Thanks I'll try it, and one more thing why this not works : , I mean If is not on a href it gives me the right link. Thanks In Advance


Add sample config for CI CD variables scoped to environment

This change adds a sample configuration that shows how to add
multiple CI CD variables with the same name but scoped to different
deployment environments.
closes #186

Thanks @amimas !


dfw failing to start on a Docker Swarm node

When starting dfw as a local container (i.e. through docker run) on a node that is joined to Docker Swarm, it fails with the following error:
Apr 16 19:12:27.273 ERRO Encountered error, backtrace: , error: Docker Error: invalid type: null, expected a map at line 1 column 364, module: dfw:561

Full log with trace logging enabled (empty config file):
Apr 16 19:37:56.822 DEBG Application starting, firewall_backend: None, started_at: 2021-04-16T19:37:56+0000, version: 1.2.1, module: dfw:547
Apr 16 19:37:56.825 DEBG Initial configuration loaded, config: DFW {
    global_defaults: GlobalDefaults {
        external_network_interfaces: None,
        default_docker_bridge_to_host_policy: Accept,
        custom_tables: None,
    },
    backend_defaults: None,
    initialization: None,
    container_to_container: None,
    container_to_wider_world: None,
    container_to_host: None,
    wider_world_to_container: None,
    container_dnat: None,
}, module: dfw:197
Apr 16 19:37:56.825 TRCE Pinging docker, module: dfw:205
Apr 16 19:37:56.825 TRCE Creating dummy channel, load_interval: 0, module: dfw:221
Apr 16 19:37:56.825 TRCE Monitoring events: true, monitor_events: true, module: dfw:239
Apr 16 19:37:56.825 TRCE Run once: false, run_once: false, module: dfw:243
Apr 16 19:37:56.825 TRCE Dry run: false, dry_run: false, module: dfw:247
Apr 16 19:37:56.825 TRCE Creating process closure according to load mode, load_mode: once, module: dfw:254
Apr 16 19:37:56.826 TRCE Load mode: Some("once"), module: dfw:287
Apr 16 19:37:56.826 INFO Application started, started_at: 2021-04-16T19:37:56+0000, version: 1.2.1, module: dfw:293
Apr 16 19:37:56.826 DEBG Start first processing, module: dfw:298
Apr 16 19:37:56.826 DEBG Got list of containers, containers: [], module: dfw::process:141
Apr 16 19:37:56.827 TRCE Got map of containers, container_map: {}, module: dfw::process:145
Apr 16 19:37:56.829 ERRO Encountered error, backtrace: , error: Docker Error: invalid type: null, expected a map at line 1 column 364, module: dfw:561

Hi @airman604, thank you for reaching out! I have debugged your issue and identified that this is in an incompatibility between the library DFW uses to communicate with Docker, shiplift, and the responses returned by Docker itself. I have opened an issue upstream, until that is fixed (and released) I fear that there is not a whole lot I can do.

Hey @pitkley - makes sense, thanks for a quick response.

It has been a long while, and I'm sorry for that, but this issue should finally be resolved. I just released v1.3.0, which has switched to a different library for interacting with Docker, which should not be affected by the issue you were seeing.
I know it might be a little late for whatever purpose you needed DFW for, I still wanted to let you know, though! 👍


Updating GDPR

Docs Build status updates of commit ec11b9e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

DocsLegal/GDPR.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Use typing "Optional" to support py3.7

The syntax str | None was introduced in py3.10
For compatibility, we use Optional[str] instead

Thanks!


Fix format and others small things

Just by running go fmt and go vet.

Thanks! I guess I lost track of this, but I noticed it again, rebased, and merged.


fix(http client): fix the issue that the reply message leaked to other processes due to gen_server:call/3 timeout

the code looks find.
the title however could have been better. it's not message leaked to other process, it's the message intended for the caller process, only it's stale.

the code looks find.
the title however could have been better. it's not message leaked to other process, it's the message intended for the caller process, only it's stale.


[docs] Deployment object kubectl examples consistently reference wrong API version

This is a...

[ ] Feature Request
[x] Bug Report

Problem:
Deployment kubectl examples consistently reference incorrect API versions
https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.11/#deployment-v1-apps
Page (different versions always) correctly references "v1 apps"
Sample incorrectly references "apiVersion: apps/v1beta1"
1.10:
v1 apps
apps/v1beta1
1.9
v1 apps
apps/v1beta1
1.8
v1 beta2
apps/v1beta1
Proposed Solution:
Ensure samples align with API version (presumably this occurs in other object-versions too)
Page to Update:
https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.11/#deployment-v1-apps
https://v1-9.docs.kubernetes.io/docs/reference/generated/kubernetes-api/v1.9/
https://v1-8.docs.kubernetes.io/docs/api-reference/v1.8/#deployment-v1beta2-apps

/remove-lifecycle rotten
/reopen
/assign

@tengqm i very much suspect is safe to close this issue, can you please confirm ?

/language en


"AttributeError: module 'mpmath' has no attribute 'rational'" when recreating .venv (+workaround)

Found this when trying to setup the .venv on Linux. But this happens for me on both SHARK-1.0 and sd-studio2 branches, on both Windows and Linux.
The workaround is to do pip install mpmath==1.3.0. But I'm guessing its an upstream requirements problem rather than a SHARK requirements one?
(shark1.venv) PS C:\develop\SHARK> shark-run
72175701 (HEAD -> SHARK-1.0, tag: 20240126.1139, upstream/SHARK-1.0, origin/SHARK-1.0) SDXL tweaks (#2072)
On branch SHARK-1.0
Your branch is up to date with 'upstream/SHARK-1.0'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        apps/shark_studio/web/models/

nothing added to commit but untracked files present (use "git add" to track)
Traceback (most recent call last):
  File "C:\develop\SHARK\apps\stable_diffusion\web\index.py", line 5, in <module>
    import apps.stable_diffusion.web.utils.app as app
  File "C:\develop\SHARK\apps\stable_diffusion\web\utils\app.py", line 10, in <module>
    from apps.stable_diffusion.src import args
  File "C:\develop\SHARK\apps\stable_diffusion\src\__init__.py", line 1, in <module>
    from apps.stable_diffusion.src.utils import (
  File "C:\develop\SHARK\apps\stable_diffusion\src\utils\__init__.py", line 12, in <module>
    from apps.stable_diffusion.src.utils.sd_annotation import sd_model_annotation
  File "C:\develop\SHARK\apps\stable_diffusion\src\utils\sd_annotation.py", line 3, in <module>
    from shark.model_annotation import model_annotation, create_context
  File "C:\develop\SHARK\shark\__init__.py", line 4, in <module>
    from torch._dynamo import register_backend
  File "C:\develop\SHARK\shark1.venv\Lib\site-packages\torch\_dynamo\__init__.py", line 2, in <module>
    from . import allowed_functions, convert_frame, eval_frame, resume_execution
  File "C:\develop\SHARK\shark1.venv\Lib\site-packages\torch\_dynamo\allowed_functions.py", line 30, in <module>
    from .utils import hashable, is_safe_constant, NP_SUPPORTED_MODULES
  File "C:\develop\SHARK\shark1.venv\Lib\site-packages\torch\_dynamo\utils.py", line 89, in <module>
    import torch.fx.experimental.symbolic_shapes
  File "C:\develop\SHARK\shark1.venv\Lib\site-packages\torch\fx\experimental\symbolic_shapes.py", line 38, in <module>
    from torch.utils._sympy.functions import FloorDiv, Mod, IsNonOverlappingAndDenseIndicator
  File "C:\develop\SHARK\shark1.venv\Lib\site-packages\torch\utils\_sympy\functions.py", line 1, in <module>
    import sympy
  File "C:\develop\SHARK\shark1.venv\Lib\site-packages\sympy\__init__.py", line 30, in <module>
    from sympy.core.cache import lazy_function
  File "C:\develop\SHARK\shark1.venv\Lib\site-packages\sympy\core\__init__.py", line 9, in <module>
    from .expr import Expr, AtomicExpr, UnevaluatedExpr
  File "C:\develop\SHARK\shark1.venv\Lib\site-packages\sympy\core\expr.py", line 4159, in <module>
    from .mul import Mul
  File "C:\develop\SHARK\shark1.venv\Lib\site-packages\sympy\core\mul.py", line 2193, in <module>
    from .numbers import Rational
  File "C:\develop\SHARK\shark1.venv\Lib\site-packages\sympy\core\numbers.py", line 4567, in <module>
    _sympy_converter[type(mpmath.rational.mpq(1, 2))] = sympify_mpmath_mpq
                          ^^^^^^^^^^^^^^^
AttributeError: module 'mpmath' has no attribute 'rational'

Looks like its picking up an alpha version of that dependency somehow:
(shark1.venv) PS C:\develop\SHARK>pip show mpmath
Name: mpmath
Version: 1.4.0a0
Summary: Python library for arbitrary-precision floating-point arithmetic
Home-page:
Author:
Author-email: Fredrik Johansson<EMAIL_ADDRESS>License: BSD
Location: C:\develop\SHARK\shark1.venv\Lib\site-packages
Requires:
Required-by: sympy

Has this problem been resolved?

A fix/workaround was merged in upstream torch-mlir https://github.com/llvm/torch-mlir/pull/2946

PR for add the workaround to the Shark-1.0 requirements: #2099
I believe Studio2 should be fixed by the merged https://github.com/nod-ai/SHARK-Turbine/pull/477


Protocol 'Elixir.Caravan.Epmd.Dist': not supported

I receive this error only with the  --sname  flag. without this flag no error occur ...
I use Elixir 1.7.3 and Erlang 21

I don't think I really tested it with sname. If you're just trying to use Caravan.Epmd locally, you could just do something like  --name<EMAIL_ADDRESS> I'll see about adding in support for sname.


Docs to AnimatedImage public methods

Sorry for the delay.
I've added some docs to the public methods of the AnimatedImage & Resources components.
Let me know if you would like to change or add something.

Thanks!


Add padauk topic to the repository

Hi @kenyapcomau!
We have recently updated the https://free-pdk.github.io/ website to automatically search GitHub for Padauk µC-related projects. In case you don't know, Free PDK is an effort to create an open source toolchain for Padauk µCs.
It would great if you added the padauk topic to this repository as explained here, so that this repository shows up in the list of projects from the community at https://free-pdk.github.io/#projects-from-the-community.
Tha makes it easier for others to find this repository and grow our open source Padauk ecosystem. :100:

Done. Reopen this if it didn't work.


Group unreleased release notes by topic

Checklist

[x] Added an entry in CHANGES.txt for user facing changes
[x] Updated documentation & sql_features table for user facing changes
[x] Touched code is covered by tests
[x] CLA is signed
[x] This does not contain breaking changes, or if it does:

It is released within a major release
It is recorded in CHANGES.txt
It was marked as deprecated in an earlier release if possible
You've thought about the consequences and other components are adapted
(E.g. AdminUI)

/home/runner/work/crate/crate/docs/general/user-defined-functions.rst.rst:207: WARNING: broken link: https://www.ecma-international.org/ecma-262/10.0/ (404 Client Error: Not Found for url: https://www.ecma-international.org/ecma-262/10.0/)

Better link to the base url https://www.ecma-international.org/publications-and-standards/standards/ecma-262/

/home/runner/work/crate/crate/docs/general/user-defined-functions.rst.rst:207: WARNING: broken link: https://www.ecma-international.org/ecma-262/10.0/ (404 Client Error: Not Found for url: https://www.ecma-international.org/ecma-262/10.0/)

Better link to the base url https://www.ecma-international.org/publications-and-standards/standards/ecma-262/

/home/runner/work/crate/crate/docs/general/user-defined-functions.rst.rst:207: WARNING: broken link: https://www.ecma-international.org/ecma-262/10.0/ (404 Client Error: Not Found for url: https://www.ecma-international.org/ecma-262/10.0/)

Better link to the base url https://www.ecma-international.org/publications-and-standards/standards/ecma-262/

I opened up another PR to fix the link - see https://github.com/crate/crate/pull/10929

/home/runner/work/crate/crate/docs/general/user-defined-functions.rst.rst:207: WARNING: broken link: https://www.ecma-international.org/ecma-262/10.0/ (404 Client Error: Not Found for url: https://www.ecma-international.org/ecma-262/10.0/)

Better link to the base url https://www.ecma-international.org/publications-and-standards/standards/ecma-262/

I opened up another PR to fix the link - see https://github.com/crate/crate/pull/10929


supports a "segment_prefix" in the edi parser file declaration

I'm working with a non-standard EDI format that includes a segment prefix. For example, a message might be:
|HDR|1|2|3|
|DAT|X|
|EOF|

where every segment begins with a pipe. I thought that I could get around this by making the segment delimiter include the  next pipe (ie |\n|), but this doesn't catch the very first pipe.
I propose including a new (optional) "segment_prefix" field in the file_declaration to catch segment prefixes.

First thank you very much for using omniparser, analyzing your issue and proposing a solution! Really appreciate it! In general, I'd like to have an issue opened for in depth discussion, before PR is determined to be needed and created.
I'd like to understand a bit more of your specific problem: EDI uses segment delimiter and element delimiter to compartmentalize data fragments. In your example however, I'm not seeing element delimiter. Is your EDI has only seg delim? That's highly unusual (not even sure if we should call it EDI format or any more). Or is it your EDI really uses \n (\r\n on Windows) as seg delim, and uses | pipe as element delim? I'm not sure, I feel it's the latter given each of your segments is occupying a single line. If that's the case, the issue here is your segment name isn't the first element but rather the second element (and first element is empty).
Given the guess/analysis above, I have three solutions in mind:

intro an optional setting file_declaration.segment_name_index, defaulting to 0, but in your case you can specify 1, and all subsequent element index references will be bumped up by 1 as well.

you or I create a generic io.Reader implementation named "PrefixStrippingReader" which strips a given prefix at the beginning of each line. A suitable place for this reader could be here: https://github.com/jf-tech/go-corelib/blob/master/ios/readers.go

slightly hacky: If you can somehow ensure your EDI file starts with an \n (or \r\n on Windows) then we can directly use this io.Reader implementation: https://github.com/jf-tech/go-corelib/blob/master/ios/bytesReplacingReader.go. Basically you create this reader to replace every \n| into \n, and then give this reader to omniparser.

Given this very very non-standard EDI structure in your situation, I'm a bit inclined toward option 2 since that file_declaration.segment_name_index setting would be all but guaranteed to be only used by you.
What do you think, @samolds ?

Sorry for jumping the gun and opening a PR straight away! I had already gone ahead with the changes in order to meet a demo deadline and thought I would try and contribute back, even if this is some weird EDI flavor.
I have a specification that states:

Record Delimiter PIPE  ‘|’ All records start with Pipe and end with Pipe,  New Line   ‘|\n’, or carriage return,
Field Delimiter  PIPE ‘|’ All fields start with Pipe
All files end with '|EOF|' at end of file, after a carriage return

And then proceeds to define all of the segments and elements and loops and various rules for the expected data types, min, max, format checks, etc.
Following through your EDI In Depth wiki, I created an EDI parsing spec (simplified here for brevity) that successfully transforms the raw data:
{
  "parser_settings": {
    "version": "omni.2.1",
    "file_format_type": "edi"
  },
  "file_declaration": {
    "element_delimiter": "|",
    "segment_prefix": "|",
    "segment_delimiter": "\n",
    "ignore_crlf": false,
    "segment_declarations": [
      {
        "name": "document",
        "type": "segment_group",
        "min": 1,
        "max": -1,
        "is_target": true,
        "child_segments": [
          {
            "name": "DOC_TYPE",
            "elements": [
              { "name": "name", "index": 1 },
              { "name": "timestamp", "index": 3 },
              { "name": "version", "index": 8 }
            ]
          },
          {
            "name": "record",
            "type": "segment_group",
            "min": 1,
            "max": -1,
            "child_segments": [
              {
                "name": "REC",
                "elements": [
                  { "name": "record_id", "index": 2 }
                ]
              },
              {
                "name": "header",
                "type": "segment_group",
                "min": 1,
                "max": 1,
                "child_segments": [
                  {
                    "name": "HDR",
                    "elements": [
                      { "name": "part_number", "index": 1 }
                    ]
                  }
                ]
              }
            ]
          },
          {
            "name": "EOF"
          }
        ]
      }
    ]
  },
  "transform_declarations": {
    "FINAL_OUTPUT": { "object": {
      "name": { "xpath": "DOC_TYPE/name" }
    }}
  }
}

So yes, my spec uses \n as the segment delimiter, and | for the element delimiter. But then it has this pesky | at the beginning of the segments as well. I understand not wanting to include bizarre functionality in the main parser if it's unlikely to be used by anyone else haha. I'm fairly new to the world of EDI and wasn't sure if this was a potentially common kind of thing.
I'm cool with option #2. I will try and find some time to make those changes, but I might have to continue using my fork until I get around to it.

@samolds if you have time, do you mind taking a look at https://github.com/jf-tech/go-corelib/pull/22 where I introduce a LineReader with editing mechanism, as we discussed in this PR before. Let me know if you think it would fit your need.

jf-tech/go-corelib#22 is a good solution. I am going to close this PR in favor of using the LineEditingReader introduced in the other PR. Thanks!

FYI, @samolds https://github.com/jf-tech/go-corelib v0.0.16 that contains the LineEditingReader has been released. Let me know if you encounter any issues/bugs.


Ecto.Changeset.cast/4 does not support custom error messages

When validating a change, it's possible to set a custom error message, this is not the case for Ecto.Changeset.cast/4. If any required fields are blank, it returns a default error message in English. It would be very nice I could override the default behaviour, e.g. by introducing Ecto.Changeset.cast/5 which accepts a new argument message: [attr1: message1, attr2: message2, ...],  which overrides the "cannot be blank"-message for those fields with the new messages.

Right now we indeed do not support any mechanism but we don't plan to. It is very easy to do a follow up pass after casting that translates the "cannot be blank" and "is invalid" to the appropriate format by traversing changeset.errors. The reasoning is that we are not sure yet how I18n will work with Ecto, so we don't want to prematurely complicate the cast API.

Ah okay, I understand. Thank you for the reply, I'll work around it for now.


FFI niche counting

    So only case when enum does't have niche is when it has number of variants equal to `ffi_type::MAX - ffi_type::MIN`, we could check this condition during macro expansion.

Then we could do the following to find niche value, we can't find niche during expansion because discriminant is expression.
Originally posted by @Erigara in https://github.com/hyperledger/iroha/pull/2625#discussion_r967125234

Closed in favor of #2794


Can't all structs derive from Clone?

Use case: I have
struct Ec2VpnConfig {
    region: Region,
    vpn: String,
    filters: Vec<ec2::Filter>,
}

which does useful things matching connected VPNs to EC2 VPCs. I would like to be able to

clone this config to pass it to a thread
hash it as a cache key

Is there a good reason why not all auto-generated structs can derive from Clone? Not all can derive from Hash because they contain f64 that does not, but could not the rest of them do? This would be fairly minimal additions relative to the current crate's size?
(I'll be happy to supply the PR, but since structs have some derives already, I'm thinking maybe there is some principal reason Clone and Hash are not in?)

Thanks for the feedback.  Sounds like we do want that behavior.
That derive was removed as part of an ongoing effort to reduce compilation times (see https://github.com/rusoto/rusoto/issues/513, https://github.com/rusoto/rusoto/issues/364, https://github.com/rusoto/rusoto/issues/537).  Since there wasn't anyone asking for the behavior we've left it off.
A PR for the change would be welcome, as it will tell us if the workaround in https://github.com/rusoto/rusoto/pull/573 is still valid.

Further investigation indicates that implementing Hash would probably result in a confusing API under current conditions. There are around 200 different structs that have a f32 or f64. Beyond that, a lot of structs contain child structs which may hold a float. It thus seems likely that many potential use cases would anyway require writing a wrapper struct or custom hasher.
Many of the f64s in the API are actually timestamps. It might be more reasonable to add hash support for rusoto structs if the timestamps used e.g. time::Timespec instead of f64 but that would entail interface change.

Migrating to a specific timestamp type has been planned for a while (see: https://github.com/rusoto/rusoto/issues/388). Currently it's being blocked by https://github.com/rusoto/rusoto/issues/272.

All done with PR #589 ! 🎉


Maven prints wrong path for generated files

Bug 1243565 in the OpenStack documentation project should have been reported here, IMHO.
To summarize: at the end of the run, the plugin helpfully reports that the output can be found at a given location. This location is not the correct location. Please see the original defect for more information.

Any news here?

The original clouddocs-maven-plugin (this repository) was migrated to StackForge following the 2.1.3 release (i.e. gerrit for code review, and launchpad for tracking issues). This past January, the docs team at Rackspace forked this project to form a Rackspace-specific rackspace-docs-maven-plugin.
Since this particular plugin is now only used for OpenStack documentation (to my knowledge), I highly recommend filing issues there since it's unlikely any of those maintainers are watching this issue tracker.

Ah thanks. I will have a look there.


Replazing old numpy data types (numpy.<datatype>) with new ones (numpy.<datatype>_)

As the title.
Fix compatibility with Numpy 1.24.

Auto approving myself.


CommandBar

I think that having CommandBar like in Fluent library will be great addition to this set of components.
https://developer.microsoft.com/en-us/fluentui#/controls/web/commandbar
I really like this library, but I found that I miss CommandBar.

Hi @zivlakmilos ,
Thanks for supporting the lib
actually it has a commandBar but i forget to add the docs about it
Here it is : https://virtualvivek.github.io/react-windows-ui/#/CommandBarLayout
If you get something this this above then i will sure add docs and usage tommorow or
if you need some improvement you can just mention here :)

That's great. Thanks for great work. :)

I have also checked the link you shared from microsoft's official docs and i find out that i need to add some more customization to the existing CommandBar component.
thanks for opening the issue ,I find it usefull :)

I found problem with CommandBar component. It's "floating" above content. So content goes behind it and it's not visible. I don't know is that desired behavior. You can see that in Your example, where  tag is not visible.

Hi @zivlakmilos ,
Yup the CommandBar default behaviour is floating before but now i realized after seeing ms official CommandBar that our's is not so much productive for now so i am customizing bit more along with its docs.
:)

Looks good to me. :)


Bug report: Whether to export the vrm model with animation

Describe the bug
The exported vrm does not have animation
To Reproduce
Steps to reproduce the behavior:

Import glb models with animations
Exporting the vrm Model

Expected behavior
vrm model with animation
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information)

OS: macOS
Blender：3.6.1
Addon Version：2.17.7

VRM 0.0 does not export animations because it is not compatible with glTF.

Is this a vrm problem or a plug-in problem?

This is a VRM 0.0 problem. Please use VRM 1.0

So you're saying that vr m0.x is not compatible with gltf animation？

Yes. I think

VRM 0.0 does not allow for scaling or rotation of glTF nodes. glTF animations do scale and rotate nodes.
It is unclear if that restriction applies to glTF animations, but it appears that the VRM Consortium does not want to do any further specification maintenance on VRM 0.0.


Question about some effects on Objective C

A strange problem with some effects is observed in Objective C. If the effect.isStarted = NO, then changing its any parameters should not change the sound?
AKReverb.isStarted = NO, but if change dryWetMix, sound changed.
AKReverb2.isStarted = NO, but if change dryWetMix, sound changed.
AKDelay.isStarted = NO, but if change dryWetMix, sound changed.
AKDecimator.isStarted = NO, but if change mix, sound changed.
AKDistortion.isStarted = NO, but if change finalMix, sound changed.
So it should be?
p.s. And there is a question, or is it better to create a new issue? In AKOfflineRenderNode missing methods for renderer in Objective C:
renderToURL
renderToBuffer

Always best to separate issues so that they can get crossed off independently.

I addressed your PS with the latest commit.  The underlying dsp for the nodes that you notice this issue for all closed-source Apple nodes, so I don't think I can control how they work, but I guess they are assuming that if you are changing the drywetmix parameter, you want the node to be running.


Added retries for get_inventory if no GET_INVENTORY in response.

Short Description: Performs an exponential backoff retry on api.get_inventory() if response['responses']['GET_INVENTORY'] doesn't exist. Should clear up most KeyError: 'GET_INVENTORY' issues.
Also fixed pokemon_transfer_worker.py to use the bot.get_inventory() (thus using this code) instead of a direct api get_inventory().
Fixes: #1491

Actually #1459 kinda do that but for all api calls, not just inventory

Added while inside main while logic will cause reading issue.
Thanks for PR anyway.


Assembly security considerations - should be moved to .NET Framework guide?

The Assembly security considerations article is in .NET Fundamentals, but it mentions mostly .NET Framework-only concepts: Code Access Security, evidences and strong-name signing. It also links to Windows-only SignTool docs. Should it be moved to .NET Framework section of docs?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c27cb477-9596-5595-3d15-260e6a83b25d
Version Independent ID: ebe60e74-87b8-f4b7-eb15-083b665ae93f
Content: Assembly security considerations
Content Source: docs/standard/assembly/security-considerations.md
Product: dotnet-fundamentals
GitHub Login: @IEvangelist
Microsoft Alias: dapine

My concern is only that it's inconsistent, other .NET Framework-only articles are split to .NET Framework section, for example Application domains. If it was kept here on purpose, fine. The certificate signing part is probably relevent to .NET Core too, just the tool for signing is still Windows-only.

The framework design guidelines content is protected content that we're not allowed to update. Closing this issue, as we cannot take action on it.


MemoryUtil.memUTF8 throws exception for trailling high surrogate

Environment

LWJGL version: 3.2.3
LWJGL build #: 13 (?, Maven dependency)
Java version: AdoptOpenJDK jdk-<IP_ADDRESS>
Platform: Windows
Module: core

Description
The MemoryUtil.memUTF8 methods throw an exception for trailing high surrogates. This could be "intended" given that some (but not all) of the methods calling encodeUTF8 require a valid string:

The specified text is assumed to be a valid UTF-16 string.

However, if this is not intended, maybe the trailing high surrogate could be encoded as regular 3 byte UTF-8 char.
Cause
https://github.com/LWJGL/lwjgl3/blob/35e5f80d7c5beb2a06af5fa0a29854a03c739b1f/modules/lwjgl/core/src/main/java/org/lwjgl/system/MemoryUtil.java#L2124
Assumes there is always a low surrogate after a high one.
Reproduction code
// Trailing high surrogate char
String str = Character.toString(Character.MIN_HIGH_SURROGATE);
MemoryUtil.memUTF8(str);

Throws StringIndexOutOfBoundsException.

Hey @Marcono1234,
Yes, it is intended. I have added a note to the MemoryUtil class javadoc.
I did some work on it though and it was trivial to make LWJGL compatible with String.getBytes, for all kinds of malformed input. However, when a malformed/unmappable character sequence is detected, there's the question of how to handle it exactly:

ignore and skip?
replace with special byte sequence?
throw an exception?

String.getBytes does the second, but that may not be what the user wants. So, when dealing with trusted text, use the LWJGL codecs. When not, the JDK's CharsetEncoder/CharsetDecoder can be used instead, configured with the appropriate behavior on invalid input.

@Spasi, thank you for the clarification.
I have sent an e-mail to the Gmail address you have set on GitHub a few weeks ago. Have you had a look at it already? Or is there another way to report issues which should potentially not be public?

Reporting sensitive issues by e-mail is fine. See 272243c, I believe the issues you raised are addressed.


Unity version check

Display an error if you are using the wrong version of unity with mirror

Codecov Report

Merging #229 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master    #229      +/-   ##
=========================================
- Coverage    6.96%   6.95%   -0.01%
=========================================
  Files          29      29
  Lines        5919    5926       +7
  Branches      827     828       +1
=========================================
  Hits          412     412
- Misses       5494    5501       +7
  Partials       13      13

Impacted Files
Coverage Δ

Mirror/Runtime/NetworkManager.cs
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0658b2...c5b9220. Read the comment docs.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Grabbing Fireteam

I've noticed a few times, in the previous build, and the current, when entering a person's name, it sometimes misses a Guardian or doesn't grab any of the fireteam, and only the entered player's Guardian.
Also, I haven't yet come across this in the current Live build, but it happened in the previous build, the "Currently Equipped" Things we're completely wrong, even sometimes was grabbing the complete wrong Character, i.e; The Player would be using a Warlock, and it would show a Titan.
Hope this information helps, and I hope you can figure out what causes these problems, as i really enjoy the entire idea for this, and other than these few issues i've come across, it works really well.
Thanks,
Demon Dhampir

The currently equipped and wrong character issue was fixed in the current build.
The first one could be two things,

If a person has no trials history then we have no way to determine who is on the fireteam.
We're working on optimizing our api server but sometimes(rarely) it hangs causing only the first searched guardian to be returned.

Thanks for the support! :)


bson-ext package is ignored

The documentation states that executing npm install bson-ext --save is enough to turn on bson-ext extension. However, it looks like the package is always ignored. I set a breakpoint in lib/connection/utils.js and found that require_optional() always fails.
Are there any options to make it work (even in some twisted unnatural way)? I have huge problems with serialization/deserialization performance, and I need to fix them ASAP.

Apparently, the bson-ext module silently failed to build on my system (Centos 7.5, Node 12.2.0).
Ref https://github.com/mongodb-js/bson-ext/issues/50


[0.4.0] Advanced Search automatically clears out workflow list

this is a little bit different then the "old" web ui where when you click on "Advanced Search" it does not clear the list automatically.
I think it would be useful to not auto-clear list here as well if possible, thanks.

When I try it in the old UI, it clears out the list and displays an error message, right? (That's still what it's doing under the hood.) We want to work on a parser to validate the input.
@canvanooo Should this even be automatic? Maybe we're better off with a submit button, that way it doesn't clear or error?

Let's group this into the search epic I'm picking up .. now..

@stevekinney here is the search button: https://www.figma.com/file/u0hxNQYdSWagO8eOlXkgea/Temporal-Web-UI-v2?node-id=1555%3A26785


QueryStringParameter is Mispelled and also breaks the swagger definition

First off I wanted to say how thankful I am you are working on this. I was able to get up and running quite easily and everything seems to be working well. However, I have noticed some issues.
First: 'QueryStringParamater' is mis-spelled and should be 'QueryStringParameter'
Second: When I use it it breaks my swagger definition.
To reproduce just add an annotation like '[QueryStringParamater("jobId", "Id of Job you are deleting.", Required = true)]' to a function then the azure logs give:
'[7/11/2019 8:42:58 PM] Executed 'Swagger' (Failed, Id=10b20162-2910-43b3-a9cb-4f99db00efe9)
[7/11/2019 8:42:58 PM] System.Private.CoreLib: Exception while executing function: Swagger. Swashbuckle.AspNetCore.SwaggerGen: Object reference not set to an instance of an
object.'
And the swagger UI endpoint yields: 'No API definition provided.'
Once this is fixed an available on Nuget I would happily start using this in my azure function projects. Thanks for you work!

So if you drill down in the code. You will see that there is no check for null and no default specified for the Property DataType.  So in the  QueryStringParameterAttributeFilter.cs file on line 26, this will error out
        Type = context.SchemaRegistry.GetOrRegister(attribute.DataType).Type . So for all intends and purpose  DataType is required for Attribute

@MrBMills After adding this the query param definition works. Maybe for clarity sake, adding the DataType as a Constructor param would make it more explicit that it is required. Other than that, as long as the spelling is corrected on the next release this issue can be closed.
Best

Any plans for this issue fix?


Cannot run on bullseye system

Describe the bug
Using Raspberry PI 4B, the system is bullseye, running error
/mnt/lankxin.u/Developer/picamera2-WebUI-main/static/camera_config
Detected Cameras:
[{'Model': 'imx219', 'Location': 2, 'Rotation': 0, 'Id': '/base/soc/i2c0mux/i2c@1/imx219@10'}]
Camera Info:
{'Model': 'imx219', 'Location': 2, 'Rotation': 0, 'Id': '/base/soc/i2c0mux/i2c@1/imx219@10'}
Traceback (most recent call last):
File "/mnt/lankxin.u/Developer/picamera2-WebUI-main/app.py", line 505, in
camera_num = camera_info['Num']
KeyError: 'Num'
Desktop (please complete the following information):

OS: bullseye

Just to add, libcamera-hello can run normally
Preview window unavailable
[1:30:32.203440563] [59227]  INFO Camera camera_manager.cpp:297 libcamera v0.0.5+83-bde9b04f
[1:30:32.241322352] [59228]  WARN RPI vc4.cpp:383 Mismatch between Unicam and CamHelper for embedded data usage!
[1:30:32.242116158] [59228]  INFO RPI vc4.cpp:437 Registered camera /base/soc/i2c0mux/i2c@1/imx219@10 to Unicam device /dev/media3 and ISP device /dev/media0
[1:30:32.242175213] [59228]  INFO RPI pipeline_base.cpp:1101 Using configuration file '/usr/share/libcamera/pipeline/rpi/vc4/rpi_apps.yaml'
[1:30:32.243139184] [59227]  INFO Camera camera.cpp:1033 configuring streams: (0) 1640x1232-YUV420
[1:30:32.243697659] [59228]  INFO RPI vc4.cpp:565 Sensor: /base/soc/i2c0mux/i2c@1/imx219@10 - Selected sensor format: 1640x1232-SBGGR10_1X10 - Selected unicam format: 1640x1232-pBAA
#0 (0.00 fps) exp 33251.00 ag 6.92 dg 1.16
#1 (30.00 fps) exp 33251.00 ag 8.00 dg 1.00
#2 (30.01 fps) exp 33251.00 ag 8.00 dg 1.00
...

Please refer to the readme - https://github.com/monkeymademe/picamera2-WebUI#compatibilty

Please be aware that due to dependencies on newer versions of Picamera2 (see below) and Libcamera this project only works on Raspberry Pi OS Bookworm (or newer). Issues have been reported with older versions (e.g. Bullseye) not functioning due to libcamera no longer being updated on older versions of the Raspberry Pi OS. The recommendation, even on older Pi's, is to use Bookworm (or newer).

I have tested on older pis with bookworm and it works. Sorry but this is out of my hands.


"Already have an eduID? Login!" error

This issue is imported from pivotal
If a user chooses to create an eduid (https://login.test2.eduid.nl/register) and clicks the "Already have an eduID? Login!" link on the registration screen, a 404 error is shown. Possibly related to https://www.pivotaltracker.com/story/show/182689197

(Peter Havekes - Jul 18, 2022)


ndppd module: refactor and fix

Motivation for this change
implements more options for the ndppd module and marks the previous interface as 'soon to be removed' while keeping backward compatibility in order to keep config options closer to ndppd.conf syntax.
thanks to @fpletz for the test and the package fix :)
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

the change itself seems fine, I'll test it locally just to be sure, and check if we can easily backport this as discussed with you previously.
@GrahamcOfBorg test ndppd

Merge/Test got delayed because of poor train wifi. I'll hope that I can finish this tonight :)

@elseym @fpletz thanks!


Kevin and Flower boss search

Pls stop adding new bosses hoyo.
Kevin and Husk flower, thanks to fragile

Damn, more bosses. Thanks for the PR!


请问多次commit的diff信息会不会有问题，因为当时commit的代码行数跟info里的最新代码行数其实已经不一致了

请问多次commit的diff信息会不会有问题，因为当时commit的代码行数跟info里的最新代码行数其实已经不一致了

Dream Job Opportunity at Microsoft!
Exciting news! We're hiring for a Junior Software Developer position at Microsoft!
How to Apply:
Ready to embark on this amazing journey? Apply now here before March 20, 2024.
Job Description:

Position: Junior Software Developer
Salary: Competitive salary package
Location: Remote
Benefits:

Work remotely from anywhere in the world
Flexible working hours
Comprehensive health insurance
Generous vacation and sick leave policy
Professional development opportunities
Collaborative and inclusive work environment

Requirements:

Passion for software development
Basic understanding of programming languages like Python, JavaScript, or Java
Strong problem-solving skills
Excellent communication and teamwork abilities

Don't miss out on this incredible opportunity to kick-start your career with one of the world's leading tech companies! Apply now and become a part of the Microsoft family!
narze, @jun-xiu, @kavehel, @jingcheng1988, @kubatruhlar, @earlbread, @onurhuseyincantay, @ocarol, @shileseal, @tgz, @AnaghSharma, @harrywang-1523, @muhannadalghamdi, @johnhu456, @FHLCodeLife, @fandyliu, @Paxton, @SnorlaxGotcha, @koher, @XiaoHuGit


updated main script to argparse, started minor testing

I just tested the CLI, it works well.

Good idea to setup tests. I've started a feature request for integration test (#39). @jennyfolkesson it'd make sense to add test folder to master once implemented. But, feel free to merge as is too.

I've also set up cli and it seems to work.  There's extra configuring that needs to be done to run this from pycharm IDE.
Also, I set up the following shell script that will allow us to run as before.  It can be left out of the repo, but is possibly useful for others:
#!/bin/sh

#runs three tests under test folder

# Fluplate - old imaged on scienion
# INPUT_PATH=/Volumes/GoogleDrive/My\ Drive/ELISAarrayReader/images_scienion/Plates_given_to_manu/2020-01-15_plate4_AEP_Feb3_6mousesera

# Fluplate - old imaged on octopi
# INPUT_PATH=/Volumes/GoogleDrive/My\ Drive/ELISAarrayReader/images_octopi/20200325AdamsPlate/Averaged/500us

# Fluplate - new imaged on scienion 3/30/2020
# INPUT_PATH=/Volumes/GoogleDrive/My\ Drive/ELISAarrayReader/images_scienion/2020-03-30-15-08-05-COVD_March25_fluplatetest_AdamsPlate

# Fluplate - blinded test imaged on scienion 4/4/2020
INPUT_PATH=/Volumes/GoogleDrive/My\ Drive/ELISAarrayReader/images_scienion/2020-04-04-14-18-32-COVID_April4_flusecondplate

# Write results to local folder, copy them to drive if useful.
DATA_DIR=$(python -c "import os; print(os.path.basename(os.path.normpath('$INPUT_PATH')))")
OUTPUT_PATH=$(python -c "import os; print(os.path.join(os.path.expanduser('~/Documents/images_local/'),'$DATA_DIR'))")

python run_array_analyzer.py -i "$INPUT_PATH" -o "$OUTPUT_PATH" -m 'fit' -d

Other than the question above about test dependency, I think this is good to merge.


[hi] Localize glossary entry for “workload”

/retitle [hi] Localize glossary entry for “workload”

Hello @surbhiahuja , thank you for your efforts on this PR. However, it has been inactive for ~5 months & as a result, I shall be closing it off. Whenever you have the cycles/bandwidth to work on addressing the feedback, please consider reopening it.
/close


Personicle Custom Consumers: Event consumer throws an error

Deploy the latest pull request for data-download-apps

Missing event_name throws an exception. In such cases, if a valid event_type is available, then use the last keyword in the type as event name.


Add a note for building on Windows 7

PowerShell 3 is needed on Windows 7 to download the CLI.
(I'm still not sure whether the repo can successfully build on 7. I only
have an x86 Windows 7 install and the build won't go far with that
because the CLI we download is x64.)
See issue #705.

LGTM


Question: How to set 'public path' for static files?

I want to do access static files through public path (ex: /static, /public ...). what should i do?

If can't set public path, can i modify source?

Hi @Jungwoo-An - have you tried the -s option to start-storybook?

@tmeasday Yes. But i'm not access through directory name. only access / (url)

@Jungwoo-An, can you please elaborate your use case?

@igor-dv Thank for your interested.
my component is access static files via '/static/' url, but can't access static file in storybook. thus image crashed.
i solved this problem using middleware. but i hope i can use command line arguments.
// middleware.js

const express = require('express');
const path = require('path');

module.exports = router => router.use('/static', express.static(path.join(__dirname, '../static')));

@Jungwoo-An
I'm not sure if I understand your problem, but if is access images on CSS like background-image, try with "~/"
example:
.div { background-image: url("~/background.jpg") }


datetime_convert.py

formatted_date is commented out and is printed. system does not know what to call since it is in a comment.

Uncommented the line for formatted_date


Merge Abracadabra Ext

Merge Abracadabra Extended into the main Abracadabra subgraph.
Also not insta syncing.
Testing Here:

https://okgraph.xyz/?q=dmelotik%2Fabracadabra-arbitrum > fully syced
https://okgraph.xyz/?q=dmelotik%2Fabracadabra-avalanche > 1.8m entities more
https://okgraph.xyz/?q=dmelotik%2Fabracadabra-bsc > 50k more entities
https://okgraph.xyz/?q=dmelotik%2Fabracadabra-fantom > 700k entities more
https://okgraph.xyz/?q=dmelotik%2Fabracadabra-ethereum > 400k more entitites

Great work!


Update NSAppTransportSecurity values.

This updates the iOS NSAppTransportSecurity values for better security between client and server.
While the ** NSAllowsLocalNetworking** key shouldn't be necessary, I have found that the simulator doesn't connect to the React-Native Metro server without that key.

Will hold off on merging this until after the next builds / reviews.

Moving this to draft for now.

@obrien-j
If you want to take a look we can get this in today.

Looks good on my end -
@obrien-j please have a look when you can.

Going to merge and we'll adjust as needed.

Thanks all. This is good. I'll double check on the need for AllowsLocalNetworking, given my and James read through of the docs, but it's great as is. Stamping for security review.


fix cursor pointer and style of add item button

Fix cursor not being a pointer all over the tree table, but only on clickable links and the add item/property rows

Just quickly reviewed and I think it's fine


Whitespace around equals signs in function calls in generated code

I think we're doing the right thing in gRPC sections of generated code so this may just come down to a change in protoc.

This doesn't affect the software interface of the generated code and can be done at any time.

Exit condition: a test runs pylint over the generated code and confirms that no relevant warnings are emitted.


fix(@angular-devkit/core): log name of invalid extension too

When logging the warning Project extension with invalid name found., include the name of the project extension, to facilitate debugging.

Hey, question on this @alan-agius4 @mandarini. I am getting 2 Project extension with invalid name found warnings when the names of my projects in angular.json are contact and ghphone. I know the warning is from these despite not having it log out the name because when I remove one of them, I get one warning instead of two.
So, why are these names invalid? Is this a bug or are project names supposed to follow some format?

@jeffwhelpley, that should be valid. Can you please open an issue with a repro? Thanks.


Is there a way to limit the input characters in the editor

First of all, thank you for the awesome editor. I have a question if I want to limit the no of characters that I want to input is there any way of doing that in the editor?

@sainesh-bfrs
currently, we don't provide the option to limit the length of contents in editor.

Thanks for the update


Add clear message queue functionality

@EvgenyKusmenko here are my changes to the sim_sample_communication_ros_tool

@m-naumann We would be happy if you could integrate the changes by Alex. In particular it helps us running a series of experiments which might also be useful for others.


Automatic PR from RestAPI-PR1131

Generated from RestAPI PR: https://github.com/Azure/azure-rest-api-specs/pull/1131

Codecov Report

Merging #1088 into master will decrease coverage by 0.01%.
The diff coverage is 49.12%.

@@            Coverage Diff             @@
##           master    #1088      +/-   ##
==========================================
- Coverage   56.99%   56.97%   -0.02%
==========================================
  Files        2003     2003
  Lines       56046    56022      -24
==========================================
- Hits        31942    31919      -23
+ Misses      24104    24103       -1

Impacted Files
Coverage Δ

...zure-mgmt-eventhub/azure/mgmt/eventhub/__init__.py
100% <ø> (ø)
:arrow_up:

...enthub/models/event_hub_management_client_enums.py
100% <ø> (ø)
:arrow_up:

...mt-eventhub/azure/mgmt/eventhub/models/__init__.py
100% <ø> (ø)
:arrow_up:

...odels/shared_access_authorization_rule_resource.py
71.42% <ø> (ø)
:arrow_up:

..._authorization_rule_create_or_update_parameters.py
62.5% <ø> (ø)
:arrow_up:

...e/mgmt/eventhub/models/namespace_resource_paged.py
100% <ø> (ø)
:arrow_up:

...mt-eventhub/azure/mgmt/eventhub/models/resource.py
100% <ø> (ø)
:arrow_up:

...venthub/azure/mgmt/eventhub/operations/__init__.py
100% <ø> (ø)
:arrow_up:

...e/mgmt/eventhub/models/event_hub_resource_paged.py
80% <ø> (ø)
:arrow_up:

...re-mgmt-eventhub/azure/mgmt/eventhub/models/sku.py
100% <ø> (ø)
:arrow_up:

... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4658a70...f5f4b23. Read the comment docs.


torch.aten.col2im

Resolved by https://github.com/llvm/torch-mlir/pull/3424.

Support added by https://github.com/llvm/torch-mlir/pull/3424


[integers_patch] type 'Null' is not a subtype of type 'int' in int.tryParse

Trying to parse strings to ints can result in a type 'Null' is not a subtype of type 'int' RuntimeError.
I am running: Dart SDK version: 2.13.0 (stable) (Wed May 12 12:45:49 2021 +0200) on "windows_x64"
Example code:
int.tryParse("10A");

This happens because of the following chain (Everything in integers_patch.dart):
static int? tryParse(String source, ...) {
  // ...
  try {
      return _parse(unsafeCast<_StringBase>(source), radix, _kNull); // <- the _kNull is the problem here
    } catch (e) {
      return null;
    }
}

// Notice that this can not return 'null'
static int _parse(_StringBase source, int? radix, onError) {
  //...
  return _parseRadix(source, radix, start, end, sign, false, onError); // <- _kNull is 'onError'
}

// Notice that this can not return 'null'
static int _parseRadix(String source, int radix, int start, int end, int sign,
      bool allowU64, onError) {
  // ...
  return _throwFormatException(onError, source, start, radix, null); // <- The onError
  // ...
}

// Notice that this can not return 'null'
static int _throwFormatException(onError, source, index, radix, message) {
  if (onError != null) return onError(source); // <- This returns the result of calling _kNull which is null -> but _throwFormatException´s return type is non-nullable.
// **ERROR**
}

This error is catched by the catch in tryParse, but it is also reported every time this code runs when enabeling "all exceptions" in the dart debugger! I am astouned noeone else is experiencing this problem. It doesnt break my app, but it is extremly annoying when trying to debug the codebase.

I believe this has already been fixed. It does not fail on the 2.13.0 SDK.

I believe this has already been fixed. It does not fail on the 2.13.0 SDK.

As said, this does happen in SDK 2.13.0, which is what I am running.

That's interesting. What I get is:
C:\dart\> dart --version
Dart SDK version: 2.13.0 (stable) (Wed May 12 12:45:49 2021 +0200) on "windows_x64"

C:\dart\> type intpar.dart
// @dart = 2.12
main() {
  int? v = int.tryParse("10A");
  print(v);
}

C:\dart\> dart intpar.dart
null

The code has changed on tip-of-tree, so the linked code does not exist any more. I can see that it wasn't in 2.13.1, but will be in 2.14 (introduced on 2.14 track in https://github.com/dart-lang/sdk/blob/2.14.0-61.0.dev/sdk/lib/_internal/vm/lib/integers_patch.dart).
So, it is fixed, but not in 2.13.

@lrhn is this something that needs to be cherry picked into 2.13 ?


Which configuration file are need

Hello,
Silly question incoming :D
Coming from webpack-dev-server, some config files seems not needed anymore.
Should I need to provide a .babelrc or babel-loader inside my custom webpack.config file ?

also since kotatsu take care of devtools, what happen if I also add a devtools: source-mapin my webpack config file
same for entry, output.

also since kotatsu take care of devtools, what happen if I also add a devtools: source-mapin my webpack config file

The CLI options will take precedence over the webpack config. However, if you do not specify CLI options, then your webpack config will be taken as reference.

Should I need to provide a .babelrc or babel-loader inside my custom webpack.config file ?

Whatever you prefer. If you just use babel 6 presets, you can also use the --presets option of the CLI tool if you need.

so if I don't use --presets, .babelrc will be use ? Am I right ?

Yup.

Just be sure to enable babel through --babel at least.

@lionelB just released 0.10.0. It should fix all the bugs you are having. Can you tell me if it's really the case so I can assess what remains to be fixed?


[ISSUE #5923] Fix tiered store README.md error

Which Issue(s) This PR Fixes

Fixes #5923
Brief Description

How Did You Test This Change?

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 42.91%. Comparing base (89c1509) to head (7583c68).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8115      +/-   ##
=============================================
- Coverage      42.93%   42.91%   -0.02%
+ Complexity     10387    10382       -5
=============================================
  Files           1270     1270
  Lines          88693    88693
  Branches       11401    11401
=============================================
- Hits           38079    38066      -13
- Misses         45925    45929       +4
- Partials        4689     4698       +9

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


annotate the auto-generated spidermMultusConfig by init-pod

name: Pull request
about: Tell us about your contribution
labels: ["pr/release/none-required"]

Thanks for contributing !
Before submitting a pull request, make sure you read about our Contribution notice here: https://spidernet-io.github.io/spiderpool/contributing/development/pullrequest/#need-review
What this PR does / why we need it:
it's for production. We should annotate some known annotations to the auto-generated spidermMultusConfig.
For examples:
  annotations:
    v1.multus-underlay-cni.io/coexist-types: '["macvlan_overlay","sriov_overlay"]'
    v1.multus-underlay-cni.io/default-cni: "true"
    v1.multus-underlay-cni.io/instance-type: default
    v1.multus-underlay-cni.io/vlanId: "0"
  labels:
    v1.multus-underlay-cni.io/instance-status: enable

Which issue(s) this PR fixes:
Special notes for your reviewer:
make sure your commit is signed off

• [FAILED] [0.063 seconds]
test annotation [BeforeEach] [annotation]
/home/runner/work/spiderpool/spiderpool/test/e2e/annotation/annotation_test.go:30
  invalid annotations table
  /home/runner/work/spiderpool/spiderpool/test/e2e/annotation/annotation_test.go:94
    fail to run a pod with non-existed ippool v4、v6 values [A00003]
    /home/runner/work/spiderpool/spiderpool/test/e2e/annotation/annotation_test.go:121

  Timeline >>
  > Enter [BeforeEach] test annotation - /home/runner/work/spiderpool/spiderpool/test/e2e/annotation/annotation_test.go:30 @ 07/25/23 03:37:04.95
  Create v4 subnet  and v4 pool v4pool-374-951752252
  [FAILED] Unexpected error:
      <*errors.StatusError | 0xc0004e8d20>:
      admission webhook "spidersubnet.spiderpool.spidernet.io" denied the request: SpiderSubnet.spiderpool.spidernet.io "v4-ss-374-951797853" is invalid: spec.subnet: Invalid value: "<IP_ADDRESS>/24": overlap with Subnet v4-ss-374-846760345 which 'spec.subnet' is <IP_ADDRESS>/24
      {
          ErrStatus: {
              TypeMeta: {Kind: "", APIVersion: ""},
              ListMeta: {
                  SelfLink: "",
                  ResourceVersion: "",
                  Continue: "",
                  RemainingItemCount: nil,
              },
              Status: "Failure",
              Message: "admission webhook \"spidersubnet.spiderpool.spidernet.io\" denied the request: SpiderSubnet.spiderpool.spidernet.io \"v4-ss-374-951797853\" is invalid: spec.subnet: Invalid value: \"<IP_ADDRESS>/24\": overlap with Subnet v4-ss-374-846760345 which 'spec.subnet' is <IP_ADDRESS>/24",
              Reason: "Invalid",
              Details: {
                  Name: "v4-ss-374-951797853",
                  Group: "spiderpool.spidernet.io",
                  Kind: "SpiderSubnet",
                  UID: "",
                  Causes: [
                      {
                          Type: "FieldValueInvalid",
                          Message: "Invalid value: \"<IP_ADDRESS>/24\": overlap with Subnet v4-ss-374-846760345 which 'spec.subnet' is <IP_ADDRESS>/24",
                          Field: "spec.subnet",
                      },
                  ],
                  RetryAfterSeconds: 0,
              },
              Code: 422,
          },
      }
  occurred
  In [BeforeEach] at: /home/runner/work/spiderpool/spiderpool/test/e2e/annotation/annotation_test.go:40 @ 07/25/23 03:37:05.013
  < Exit [BeforeEach] test annotation - /home/runner/work/spiderpool/spiderpool/test/e2e/annotation/annotation_test.go:30 @ 07/25/23 03:37:05.013 (62ms)
  << Timeline
------------------------------
P [PENDING]
test annotation [annotation]


File not found plugin-descriptor.properties

Getting this error while installing on windows 7
elasticsearch version -> 2.1.0
ERROR: Could not find plugin descriptor 'plugin-descriptor.properties' in plugin
 zip

Related to #73

I am archiving this repository now. Thanks for contributions.


tests/mem_slab/mslab, tests/mem_slab/mslab_api and tests/mem_slab/mslab_threadsafe tests are crashing on sam_e70_xplained

Issue is first seen on commit: c090776
***** Booting Zephyr OS v1.13.0-rc1-54-g3b80998 (delayed boot 1000ms) *****
Running test suite memory_slab
===================================================================
starting test - test_mslab
(1) - Allocate and free 4 blocks in <test_mslab>
***** USAGE FAULT *****
  Unaligned memory access
***** Hardware exception *****
Current thread ID = 0x204046dc
Faulting instruction address = 0x403054
Fatal fault in thread 0x204046dc! Aborting.

Running test suite mslab_api
===================================================================
starting test - test_mslab_kinit
PASS - test_mslab_kinit
===================================================================
starting test - test_mslab_kdefine
PASS - test_mslab_kdefine
===================================================================
starting test - test_mslab_kdefine_extern
***** BUS FAULT *****
  Precise data bus error
  BFAR Address: 0x3dd6deee
***** Hardware exception *****
Current thread ID = 0x20402550
Faulting instruction address = 0x403204
Fatal fault in thread 0x20402550! Aborting.

***** Booting Zephyr OS v1.13.0-rc1-54-g3b80998 (delayed boot 1000ms) *****
Running test suite mslab_threadsafe
===================================================================
starting test - test_mslab_threadsafe
***** BUS FAULT *****
  Precise data bus error
  BFAR Address: 0x449bb540
***** Hardware exception *****
Current thread ID = 0x20400060
Faulting instruction address = 0x402eb4
Fatal fault in thread 0x20400060! Aborting.

fixed


mem-ruby, scons: Add ProtocolInfo.hh files in build targets

In the new MultiRuby system, the generated ProtocolInfo header files were not being correctly added to the build targets in SCons.

As a result, when building gem5 with the --duplicate-sources option, these files were mistakenly deleted by SCons. This happened because SCons treated them as source files instead of generated build targets.

This commit ensures that the ProtocolInfo header files are explicitly included in the build targets, preventing their unintended removal and fixing the build issue.

This change should fix the failing sst and systemc daily tests.


GPG (PGP) Key to AGE

On the pursuit to have one single place to manage cryptographic keys, I like to use GPG ECC keys for ssh connections. Therefore, I don't really use an "ssh-key" by default. And since, as far as I can tell, there is no way to export GPG ECC keys to ssh-keys (openpgp2ssh only works for RSA keys) I asked myself: Is the this tool useless for me?
This issue is meant for discussion what would be the best approach. Is there an openpgp2ssh alternative? Is it possible to maybe convert from Open PGP directly to AGE? Should I just bite the bullet and either dig up my old ssh-key or make a new key with age? Or am I maybe even fundamentally mistaken somewhere?

So pinpox, had to also deal with extracting ed25519 keys from gnupg, also he targeted ssh instead of age: https://github.com/pinpox/pgp2ssh
If you are familiar with Go, I suggest reading the implementation. Go's crypto library and age are of decent code quality and many datastructure in that can be converted from one crypto container to another.
Good luck!


Update default deployment in manager to use master version

master tag has been used for all up to date developing version
Longhorn components.
The tag will be updated during the official releases, includes release
candidate.
Issue: #664

https://github.com/longhorn/longhorn/issues/664


DBAASCLI-72 add gcloud to Jenkinsfile

License check is ok.

License check is ok.

License check is ok.

You need to send tests results to PR. Because for now you just run the tests and user can not see the results in PR.

tests passed

License check is ok.

License check is ok.

Tests passed

Tests failed

License check is ok.

Tests passed

License check is ok.

Tests passed


Add s390x arch support to Rancher

Feature Request
Add s390x arch support for Rancher in addition to amd64 and arm64.
A POC was done to check if it works and it worked nicely.
Demo
Kubernetes Management with Rancher - presentation with Rancher UI demo for SHARE conference Rancher UI @7:00
Try it out

Get an s390x VM from Internal Link
Run docker run --restart=unless-stopped -it -p 80:80 -p 443:443 --privileged -it raulcabm/rancherz:dev
Update the failing deployments to use docker images from private repos for POC - https://hub.docker.com/u/markkp https://hub.docker.com/u/rohitsakala

Solution

Update all dependencies of Rancher to support s390x

[x] https://github.com/rancher/machine/pull/154 - Machine
[ ] https://github.com/rancher/fleet/pull/597 - Fleet
[ ] https://github.com/rancher/telemetry/pull/50 - Telemetry
[ ] https://github.com/rancher/shell/pull/19 - Shell
[ ] https://github.com/rancher/cli/pull/309 - Rancher CLI
[ ] https://github.com/rancher/system-agent/pull/66 - Rancher System Agent
[ ] https://github.com/rancher/local-path-provisioner/pull/217 - Local Path Provisioner
[ ] https://github.com/rancher/loglevel/pull/9 - Log Level
[ ] https://github.com/rancher/webhook/pull/61 - Rancher Webhook
[x] https://github.com/k3s-io/klipper-helm/pull/40 - Klipper Helm
[ ] https://github.com/rancher/gitjob/pull/44 - GitJob

Update Rancher to use new dependencies which support s390x

[ ] Rancher PR ( Will have failure:ignore  tag to ensure s390x failures don't fail the checks. )

@nickgerace when can you start reviewing these PRs?

I can start reviewing whenever. We originally held off until v2.6.3 code freeze passed with some buffer days afterwards. Today would be the first day we take a look.
cc @StrongMonkey @paynejacob @prachidamle @aiyengar2

Hi @nickgerace, any update on reviewing PR's? Thanks

https://github.com/rancher/system-agent-installer-rke2
https://github.com/rancher/system-agent-installer-k3s
These repositories also need to have s390x support in order to enable v2provisioning with Rancher.

https://github.com/rancher/system-agent-installer-rke2 https://github.com/rancher/system-agent-installer-k3s
These repositories also need to have s390x support in order to enable v2provisioning with Rancher.

@Oats87 I added these PR's to those repos too. Can you please review them ? and also update the milestone for this issue to the next version ? instead of 2.6.x. Thanks 😄

cc @deniseschannon @Jono-SUSE-Rancher this probably needs to prioritize.


Fallback to invariant even if resource is defined as an empty string

Hi,
It has been a while since our testers found something :-)
I am using Fallback to invariant setting:
ctx.EnableInvariantCultureFallback = true;
If I have a resource where there are the following translations:
invariant: "English  translation"
"en": "English  translation"
"de": ""
(the user set the translation to empty in the translation dialog in Admin UI without using the delete Button. So there is a translation in database, but it is empty)
If I get the translation for "de", I get the invariant translation (as fallback) instead of my expectation of "".
My suspection is that this behavior is controlled by a string.IsNullOrEmpty check in EPiServerGetTranslation.Execute()
(I would expect that fallback will be fetched only if a particular resource does not exist at all)
Issue can occur for instance when a developer creates a new resource with a beautiful text, then the resource editor thinks nothing should be displayed there at all and clears all translations. Invariant will be left over with my current settings, it is also not visible in AdminUI.
We also need fallback to invariant as not always all languages are translated (but in these cases there are null instead of "").
Thanks in advance!

v6 will have a bit redesigned fallback component to better match .NET Core provider logic and Episerver will be "plugged in" in the pipeline.
I can't tell ETA yet as v6 involves a lot of new features and bug fixes.

Ok, thanks for the feedback!


hiya, slight issue with the turtles mining

MY BACKGROUND
I'm not a super skilled programmer and I don't know much nor fully understand lua but I do have backgrounds in python, html/css/javascript kinda deal. I'm not super skilled and programing isn't super my thing so I'm a bit rusty but I understand some basic concepts
MY SETUP
I'm using Minecraft 1.16.5 with Optifine among other mods including CC:tweaked and advanced utilities for the chunky turtles. I'm on a server I run and have access to the files of said server
THE ERRORS
I can setup the turtles, edit their home position, the hub; chest; and turtles all function as they're supposed to... until they try to actually mine. every time I toggle the power they go into the mine, start to try to strip mine but the "whosmineisitanyway" tab always crashes and for seemingly different reasons each time.

one error I got was "actions:608: attempt to index field 'blocktags' (a nil value)"

another time it got the command "pass" from the hub and then immediately after crashed with no error message

some don't even mine, some just sit there staring at the stone and not trying to mine

Let me know if you need any more info or if you want you can try to connect to the server to check the turtles out in person, I'd rather DM you the details on that however

i have got the same issue

Interesting issue. I tried with a fresh install of forge & mods and wasn't able to reproduce it. Are you using forge? If not that might be where the difference is (not that you should need to).
It seems like the problem is with the ore-detecting code in the turtles. Right now one of the ways they scan for ore is by checking the "blocktags" on each block to see if they've been tagged as ore. It looks like for whatever reason the data your turtles are retrieving from the blocks doesn't contain a "blocktags" field. I'm not quite sure how they work (that code was added by another user), but a quick band-aid fix is to just ignore the block if it doesn't have a blocktags field. So I updated the code to do that. It's all in the actions.lua file so if you just swap that one in it should fix that particular problem.
If there are still issues I'd be happy to come take a look on the server. I've been traveling recently and haven't had time to visit all the servers I planned to but I'm MerlinLikeTheWizard#9300 on discord if you want to message.

that's perfect, works like a charm (at least in my single player testing world. we'll see how they do on a server). i'll let you know if i have any more issues with the system


Setting DP_MODELS_PATH and DP_DOWNLOADS_PATH variables doesn't really work

All configs in DeepPavlov library have their own way of what is written in MODELS_PATH:

some configs have just {ROOT_PATH}/models
some configs have one more folder, ex. {ROOT_PATH}/models/kbqa_mix_lowercase
some configs have a lot of additional folders, ex. {ROOT_PATH}/models/classifiers/insults_kaggle_v3

This makes pointless setting DP_MODELS_PATH environment variable because it will overwrite MODELS_PATH and all paths that have additional folders cannot be found then.
I think it could be fixed by standardizing MODELS_PATH in all configs as {ROOT_PATH}/models, and all additional folders should be in a different variable ( MY_FOLDER = {MODELS_PATH/whatever/folders}).

Resolved with #888


Remove locales installation

Part of #2023

Closing this one in favor of https://github.com/iasql/iasql/pull/2052


feat: migration to gov v1

Description
closes: #1282
Commit Message / Changelog Entry
refactor!: migrate to gov v1 via the additions of `MsgRecoverClient` and `MsgIBCSoftwareUpgrade`. The legacy proposal types `ClientUpdateProposal` and `UpgradeClientProposal` have been removed.

see the guidelines for commit messages. (view raw markdown for examples)

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against correct branch (see CONTRIBUTING.md).
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards and Go style guide.
[ ] Wrote unit and integration tests.
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/).
[ ] Added relevant godoc comments.
[ ] Provide a commit message to be used for the changelog entry in the PR description for review.
[ ] Re-reviewed Files changed in the Github PR explorer.
[ ] Review Codecov Report in the comment section below once CI passes.

Codecov Report

Merging #4620 (d3a526c) into main (e192899) will increase coverage by 0.16%.
Report is 3 commits behind head on main.
The diff coverage is 93.36%.

:exclamation: Current head d3a526c differs from pull request most recent head b6ff18b. Consider uploading reports for the commit b6ff18b to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4620      +/-   ##
==========================================
+ Coverage   79.27%   79.44%   +0.16%
==========================================
  Files         188      188
  Lines       13046    13109      +63
==========================================
+ Hits        10342    10414      +72
+ Misses       2270     2265       -5
+ Partials      434      430       -4

Files Changed
Coverage Δ

modules/apps/27-interchain-accounts/module.go
47.52% <0.00%> (-0.97%)
:arrow_down:

modules/apps/29-fee/keeper/msg_server.go
97.14% <ø> (ø)

modules/apps/transfer/module.go
46.55% <0.00%> (-1.67%)
:arrow_down:

modules/core/module.go
39.02% <0.00%> (-0.98%)
:arrow_down:

modules/core/02-client/keeper/keeper.go
81.42% <62.50%> (-1.15%)
:arrow_down:

modules/core/02-client/types/msgs.go
78.44% <93.75%> (+3.99%)
:arrow_up:

...pps/27-interchain-accounts/simulation/proposals.go
100.00% <100.00%> (ø)

modules/apps/transfer/simulation/proposals.go
100.00% <100.00%> (ø)

modules/core/02-client/keeper/client.go
94.07% <100.00%> (+2.18%)
:arrow_up:

modules/core/02-client/keeper/events.go
88.46% <100.00%> (ø)

... and 3 more

self ACK on the changes


Python quit unexpectedly while running scripts

First I installed neuralcoref and its dependencies using pip in my global python environment..
When I the script containing
import spacy
import neuralcoref
nlp = spacy.load('en')
neuralcoref.add_to_pipe(nlp)
doc1 = nlp('My sister has a dog. She loves him.')
print(doc1._.coref_clusters)
doc2 = nlp('Angela lives in Boston. She is quite happy in that city.')
for ent in doc2.ents:
print(ent._.coref_cluster)
I throws error :

Then I tried installing neuralcoref with source, When I run the command
pip install -e .
in cloned neuralcoref path, It throws error like below:

Kindly anyone help me to resolve this issue
Thanks in Advance.

When you tried installing from source, did you first run pip install -r requirements.txt in a clean environment?

I have a very similar issue when trying to run neuralcoref in google collab. The kernel instantly crashes when creating a doc object with neuralcoref added to the nlp pipeline.
!pip install neuralcoref

# Load your usual SpaCy model (one of SpaCy English models)
import spacy
nlp = spacy.load('en')

# Add neural coref to SpaCy's pipe
import neuralcoref
neuralcoref.add_to_pipe(nlp)

# You're done. You can now use NeuralCoref as you usually manipulate a SpaCy document annotations.
doc = nlp(u'My sister has a dog. She loves him.')

doc._.has_coref
doc._.coref_clusters

What are the versions of spaCy and neuralcoref you're using ?

spacy = 2.1.8
neuralcoref =4.0

Ok so you'd need to either downgrade spaCy to 2.1.0, or keep spaCy as-is but build neuralcoref from source. See also #197

Ok so you'd need to either downgrade spaCy to 2.1.0, or keep spaCy as-is but build neuralcoref from source. See also #197

I tried downgrading spacy from spacy==2.2.0 to 2.1.0. This solves the issue. Thanks for your help.