Docs: Hint that SELinux can be enabled/disabled

What type of PR is this?
/kind documentation
What this PR does / why we need it:
Add the information that SELinux can be enabled or disabled explicitly.
Which issue(s) this PR fixes:

None
Does this PR have test?
None

Special notes for your reviewer:
None
Does this PR introduce a user-facing change?

Added information that SELinux can be enabled/disabled in `installation-usage.md`.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.80%. Comparing base (11d77f4) to head (377db3f).
Report is 243 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2298      +/-   ##
==========================================
- Coverage   45.50%   41.80%   -3.71%
==========================================
  Files          79      109      +30
  Lines        7782    15543    +7761
==========================================
+ Hits         3541     6497    +2956
- Misses       4099     8570    +4471
- Partials      142      476     +334


One shot circuit with measurement

I want to demonstrate a quantum algorithm with deterministic success probability (one). This can be done with 1-shot computation on the simulator. But the current simulator will issue a warning as below:
/Users/.../miniconda3/envs/QISKitenv/lib/python3.6/site-packages/qiskit/backends/local/qasm_simulator_cpp.py:99: DeprecationWarning: The behavior of getting statevector from simulators by setting shots=1 is deprecated and will be removed. Use the local_statevector_simulator instead, or place explicit snapshot instructions.
  DeprecationWarning)

It asks me to use local_statevector_simulator, but the local_statevector_simulator does not accept circuit with measurement, which is a contradiction.
Expected Behavior

Allow users to run simulator with shot=1 without warning.
Current Behavior

Possible Solution

Steps to Reproduce (for bugs)

Context

Your Environment

Version used: 0.5.2
Environment name and version (e.g. Python 3.6.1): 3.6.x
Operating System and version: MacOSX

This warning is emitted because in previous versions we had a somewhat hidden functionality that if you set shots=1 in the local_qasm_simulator, you would get the statevector in the result. Since this functionality is deprecated in favor of local_statevector_simulator, we need to have a DeprecationWarning for users coming from the old code. This will be removed after a little while (in version 0.6).


python38Packages.shouldbe: disable for python3.8

Motivation for this change
https://github.com/DirectXMan12/should_be/issues/4
upstream hasn't seen any activity in more than a year. May want to consider removing the package
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 98329 1


Bring back support for content negotiation (allow +page.svelte & +server.ts to co-exist)

Describe the problem
Previous versions of SvelteKit supported content negotiation where a route could serve HTML to browsers or JSON data if an accept header was used for a data request (as well as supporting data being posted to the same route).
Existing sites may already use this, it's been part of HTTP since forever. You might want to replace such a site with SvelteKit (or previously relied on SvelteKit supporting this) but changing the existing URL structure would be problematic and impactful (other systems using endpoints, pages already indexed and publicized etc...)
I think a router should be flexible enough to support existing URL structures, even if they are not the favoured default for the framework.
Describe the proposed solution
Support the accept header in the routing and allow application/json requests to an endpoint at the same route. Pages should only be concerned with GET requests with no accept header (or one for html content).
Alternatives considered
Adding a load function to +page.server.ts allows a GET request for data, but makes it difficult to control the response and would limit things to JSON (maybe you want CSV, PDF, or XML). It also appears limited in terms of what control you have over the response (http headers etc...) and still leaves you unable to use other HTTP methods.
Update: it appears that I should be treating load as GET and the other methods are supported. However they are inconsistent in terms of signature and what response is returned.
Importance
i cannot use SvelteKit without it
Additional Information
No response

I'm not sure the proposed logic is quite right — there's nothing special about application/json. What about rendering the page if text/html is accepted, and falling back to +server.js in all other cases?
Pending the outcome of https://github.com/sveltejs/kit/discussions/5875, what happens if +page.server.js specifies POST (or PUT/PATCH/DELETE) and these methods are also defined in +server.js? Is it the same — use the +page.server.js if text/html is accepted, and +server.js otherwise? (A fetch request is populated with */* by default, under which text/html is accepted, so this would use +page.server.js before +server.js.)

Yes, the negotiation part is more about the request not coming from a regular web browser page request, so only being limited to a particular type. I used application/json as it's likely going to be the most common / 90-99% use-case.
The overlap between +page.server.js and +server.js is confusing, I'm still going through the docs and trying things out but the initial feel is that things overlap and it's not clear why I would want to use one vs the other. But I take it this might already be subject to change with the form / action stuff.
Taking that into account, I would prefer that +server.js be the fallback and it would make more sense if the +page.actions.js / +server.actions.js (?) is really going to map to a different hidden URL anyway so there wouldn't be any conflict at that point.

Just learned from @s3812497 in discussion that we can't do GET application/json requests against +page.server.ts (former shadow endpoints) anymore.
My use case: I have bigger content properties but send only smaller, requested chunks via REST. With the initial pageload the user gets the first part and then, within the client the user can request further parts without the need to reload the page. Both use the exact same API and DB call.
It'd be nice to just use the same +page.server.ts for this, e.g. with a { headers: { accept: 'application/json' } }. I get super fast initial loads because the API request is preloaded and my code stays clean.
Why not +server.ts? Then, I'd need another dedicated +page.ts with a load function. Before, shadow endpoints gave you the highest flexibility with the least LOC and redundancy.
Not sure if I miss something and/or this would align well with #5875


Support Name attribute in #EXT-X-STREAM-INF tag

The Name attribute (within a master manifest's #EXT-X-STREAM-INF) tag is
a non standard attribute used by Wowza and JWPlayer to display different
text on a User-Agent's quality (variant) selector.
See:
http://support.jwplayer.com/customer/portal/articles/1430240-hls-adaptive-streaming
This change adds support by adding the Name field to the Variant struct
as well as decoding support and writing support via the Encode()
methods.
References #29

Merged. Thank you for this contribution!


Add the manufacturer part number of the phoenix connector mounted on the optional case ring to the datasheet

The manufacturer part number of the phoenix connector mounted on the optional case ring is missing in the docs.

That's where I started looking, was quite surprised when I couldn't find it in the datasheet. XD
Would be helpful if you could document the pitch size as well as there are other manufacturers that make compatible terminal blocks. Phoenix Contact's are... pricey. Would also be helpful in the case where the end-user is not connecting the phoenix connector to the balenaFin and is instead repurposing it for some other use which requires multiple terminal blocks. For example:
positions 1-3 - RS485 to one device
positions 4-6 - RS485 to another device
positions 7-12 - some other use


Add an option for srb tc to output in json format

Problem
I want to analyze the result of srb tc with some tool. I'd like to have a format that's more programmatically friendly.
Proposed solution
Add an option for srb tc to output in json format
> srb tc --format=json

We've been pretty hesitant to add this feature in the past (it was one of the first features I tried to implement when I joined the team and I was taught that this is not as great as it sounds).
Adding something to serialize errors to JSON requires committing to some sort of API stability, which is hard. We're already forced to do this to some extent with the LSP editor integration: each language client operates with the guarantee that the LSP spec is more or less stable. So we'd prefer to just have LSP, and not have to re-implement something that approximates LSP to get this feature.
And what's more, the things that people usually want a JSON output format for are actually just things that an LSP editor plugin would do anyways. So at that point, why not just use LSP?
We've instrumented many codemods at Stripe on top of Sorbet using no more than the existing flags—in particular, the first line of the error message is pretty reasonable to parse with bash.
If you can come back with specific things that the existing console output isn't good enough to support right now, I'm happy to track those in separate issues, but the generic feature request of "--format=json" seems like it's a solution in search of a problem to me.


404 page

As a user I would like a 404 page to make it clear to me if the hyperlink points to missing content
Designs and Mockups
TBD
Acceptance Criteria:

[ ] A 404 page is shown when the user visits a link for a missing page

closing in favor of #349


Authentication for NFS File Share

Hi,
The document says it does not support identity based authentication.
Can you please call out what exact authentication it support? Storage Access key or SAS?
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a888b024-cae0-d9d7-d593-580b080f1b46
Version Independent ID: fa3bfa5c-b539-d2ea-48ce-00f63a8bf99e
Content: Create an NFS share - Azure Files
Content Source: articles/storage/files/storage-files-how-to-create-nfs-shares.md
Service: storage
Sub-service: files
GitHub Login: @roygara
Microsoft Alias: rogarana

@RonnieQuan Please the Security section here which answers your question:
"Unlike Azure Files using the SMB protocol, file shares using the NFS protocol do not offer user-based authentication. Authentication for NFS shares is based on the configured network security rules. Due to this, to ensure only secure connections are established to your NFS share, you must use either service endpoints or private endpoints."


Update documentation

Proposed Changes

Update the documentation to better describe how to use super-linter.
Remove outdated information.

Readiness Checklist
Author/Contributor

[x] I included all the needed documentation for this change.
[x] I provided the necessary tests.

Reviewing Maintainer

[x] Label as breaking if this is a large, fundamental change.
[x] Label as either: automation, bug, documentation, enhancement, infrastructure.

Yes, good catch!


Make it possible to enter several characters at once

Could be useful when typing something math-heavy (so that it could be done without copying every symbol separately).

We can't integrate Bob into any text input, but we can create a custom text input in Bob itself. Here's an example of how an interaction with it might look (simulated in Emacs):

A problem with this approach is as follows: how to enter “/”? Note that /+space can't mean “/”, because / / is a valid thing (e.g. unbreakable space). // can't mean “/” too, because //=/ is a valid thing that means “≠”. Perhaps instead of closing “/” I shall use Enter? Then /+Enter could mean “/”.


[stable/jenkins] added changelog

What this PR does / why we need it:
It adds a change log to the README
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #16324

Special notes for your reviewer:
I added the commit columns for the auto generated change log. We can't maintain it within PRs as the merge commit isn't known when creating the PR.
Therefor I am unsure if we should keep or remove that column. For the existing changes it might help to improve the change log as it's easier to find the commit.
I used this script to generate the initial change log and did some manual changes afterwards:
#!/usr/bin/env bash

git log --abbrev-commit --pretty=oneline stable/jenkins/ | while read line ;
do
  read -r commit message <<< "$line"
  version=$(git show $commit:stable/jenkins/Chart.yaml|grep "version:"|sed 's/version: //')
  printf "| %6s | %s | %s |\n" $version $commit "$message"
done

Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Title of the PR starts with chart name (e.g. [stable/chart])

/assign @mogaal

/assign maorfr

have you looked at existing changelogs in other charts?
stable/ambassador/CHANGELOG.md
stable/concourse/CHANGELOG.md
stable/falco/CHANGELOG.md
stable/gocd/CHANGELOG.md
stable/sysdig/CHANGELOG.md
stable/logdna-agent/CHANGELOG.md

@maorfr Thanks for the pointer. I updated the change log and added a note that it's auto generated. So for sure it's not as good as a manually crafted change log, but better then nothing as a starting point.

/lgtm

Very nice work!


jfrog to shut down jcenter and bintray

jcenter artifactory is shutting down.
move to mavenCentral artifactory.
refer to
https://proandroiddev.com/publishing-android-libraries-to-mavencentral-in-2021-8ac9975c3e52
https://central.sonatype.org/publish/publish-guide/#deployment

https://github.com/designe/euphony/commit/a084f065421e2b545998920cec491e7f1d333b8e
https://github.com/designe/euphony/commit/57b75cf0eb96370386233dfa0223a6629c06383f
This issue has resolved.


Microsoft Surface Pro 2 and 16:9 devices in general

For Surface 2 and 16:9 devices it seems that hiding divs with class mdl-cell--hide-tablet does not work as expected in portrait mode as you can see here:
https://drive.google.com/file/d/0B3WE_sGto9DjNzFlUHBjOHRyYW8/view?usp=sharing
I expected that in portrait the full width would be taken by the content - as is true for phones. The same too narrow display can be seen on the Surface with the template "stand-alone article":
http://www.getmdl.io/templates/article/index.html
In landscape mode it displays as expected - as you can see here:
https://drive.google.com/file/d/0B3WE_sGto9Djb3p3MU0zWkxqenM/view?usp=sharing
In addition: the page getmdl.io has problems to be displayed and used properly on the Surface Pro 2 but this can be related to compatibility issues of the W8.1 Internet Explorer in tablet mode.
Keep up the good work and thanks for listening!

Hey @steamonimo. Thanks for the screenshots, this is actually good to have to show to the MD team.
What you describe probably means that you the Surface 2 has a width above 840px and therefore falls into the desktop category (for now). We are still working with the MD team to make the Adaptive UI spec more reliable, so this is likely going to change (or dare I say “improve”) in the future.
Closing this for now as it is working as intended. But we are aware of the flaws.


Fix for iOS: messages app should not pop up with old messages #968

Hi @gfwilliams, here are a few more changes which I hope help Bangle's platform

Added the 'new' flag to messages from iOS integration
Changed notification behaviour in messages if it's not a new message (don't buzz us then)
Added more common app bundle id's to the iOS integrations
Changed nl_NL locale again because the other notation didn't fit on Bangle.js2 screen with the default Anton clock

Remarks/Questions though:

I don't have an Android phone and I didn't see a pointer on if Android has the preExisting indicator, so I didn't touch that
now iOS has more 'app detection', should we have a few more icons in messages too?
are you open to changing the default icon to a bell or information (just the i in a box) icon, as the envelope commonly indicates 'mail' instead of a notification (although the app is called 'messages')
maybe my coding style is a bit too verbose, please dont hesitate to change it if that is better

This looks perfect - thanks!

I don't have an Android phone and I didn't see a pointer on if Android has the preExisting indicator, so I didn't touch that

Yes, I don't think there is one right now (or at least it's not exposed by Gadgetbridge).

now iOS has more 'app detection', should we have a few more icons in messages too?

Yes, that'd be great. I've been getting them from icons8 and then using the Image Converter with crop + inverted + transparency

are you open to changing the default icon to a bell or information (just the i in a box) icon, as the envelope commonly indicates 'mail' instead of a notification (although the app is called 'messages')

Yes, absolutely - that sounds like a good plan!

maybe my coding style is a bit too verbose, please dont hesitate to change it if that is better

Generally I skip {} if there's just a single line in a block, but what you've done there is great. The file gets minified normally so those things will get pulled out anyway so it's not like it hurts size/performance :)

Thanks for the merge and your answers! I tried using NRF.ancsGetAppInfo(msg.appId) but I didn't get it right..
I will be sending more PRs soon. I like the idea that I can contribute to something that is widely used.

I tried using NRF.ancsGetAppInfo(msg.appId) but I didn't get it right..

It might be that it returns a promise, so you need...
NRF.ancsGetAppInfo(msg.appId).then(appName => {
...
});

But it's async - so the function will complete and lines after are executed before the 'then' part is excecuted

Thanks for the pointers, I already tried exaclty that. But I am not familair enough with promises I guess. Inside the then() I overwrote the variable with the app name, but I think that finished after the notification 'aired'. For now I'll be making a list of apps.  I'll try to see what I think is popular and a few apps that I use myself (without a specific icon). If you have any preferences, please let me know.


Table missing data

The table for default and effective values is missing data for the actual values.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 2291e02c-6e5b-e9b9-b8d0-1ce2d71ad32d
Version Independent ID: 0ee07415-d973-44c1-2b7f-f0f36a96276f
Content: Microsoft network server Amount of idle time required before suspending session - Windows Security
Content Source: windows/security/threat-protection/security-policy-settings/microsoft-network-server-amount-of-idle-time-required-before-suspending-session.md
Product: windows-client
Technology: itpro-security
GitHub Login: @vinaypamnani-msft
Microsoft Alias: vinpa

To make it easier for you to submit feedback on articles on learn.microsoft.com, we're transitioning our feedback system from GitHub Issues to a new experience.
As part of the transition, this GitHub Issue will be moved to a private repository. We're moving Issues to another repository so we can continue working on Issues that were open at the time of the transition. When this Issue is moved, you'll no longer be able to access it.
If you want to provide additional information before this Issue is moved, please update this Issue before December 15th, 2023.
With the new experience, you no longer need to sign in to GitHub to enter and submit your feedback. Instead, you can choose directly on each article's page whether the article was helpful. Then you can then choose one or more reasons for your feedback and optionally provide additional context before you select Submit.
Here's what the new experience looks like.
Note: The new experience is being rolled out across learn.microsoft.com in phases. If you don't see the new experience on an article, please check back later.
First, select whether the article was helpful:

Then, choose at least one reason for your feedback and optionally provide additional details about your feedback:

Article was helpful
Article was unhelpful

Finally, select Submit and you're done!


(v5) not assignable to parameter of type 'RequiredEntityData'

Describe the bug
When initializing values inside entity class would still throw error when trying to insert the entity without defining the default value.
Stack trace
Argument of type '{ }' is not assignable to parameter of type 'RequiredEntityData<EntityName>'.
  Type '{ }' is missing the following properties from type '{ data: string; }': data ts(2345)

To Reproduce
Steps to reproduce the behavior:

The entity is as follow:

@Entity()
export class EntityName {
	@PrimaryKey({ type: 'uuid' })
	id: string = v4();

	@Property()
	data: string = 'default';
}

Insert a new data using em.create(), but will show type error, expecting data to be defined as it is required param.

const test = em.create(EntityName, {});
await em.persistAndFlush(test);

Expected behavior
A variable/field that already been initialized with default value should not showing any type error
Versions

Dependency
Version

node
16.13.2

typescript
4.5.4

mikro-orm
5.0.0

You need to use OptionalProps symbol to mark every optional property that has a database default.
@Entity()
export class EntityName {
    [OptionalProps]?: 'data'; // id is there automatically

	@PrimaryKey({ type: 'uuid' })
	id: string = v4();

	@Property()
	data: string = 'default';
}

I have a similar problem. It works if I specify something like
 [OptionalProps]?: 'data';

but how to do it for more than one parameter? I tried
 [OptionalProps]?: ['prop1', 'prop2'];

but this is not working

I'm also wondering why this is needed. Shouldn't be typescript capable of understanding that
class A{
    optional = 'defaultvalue'
}

is optional?

but how to do it for more than one parameter? I tried

It needs to be union of keys, not array/tuple. So:
 [OptionalProps]?: 'prop1' | 'prop2';

I'm also wondering why this is needed. Shouldn't be typescript capable of understanding that

I don't think so, that property is defined as mandatory, with a default value. It is you defining it this way, if you want to tell TS it is optional, you can do this instead:
class A {
    optional?: string = 'defaultvalue'
}

(or maybe there will be some hack to achieve this via assignability checks, but that seems like quite overkill, I can imagine perf costs if we try to do it that way, as well as some false positives - so we would fix one problem but introduced another)

Thanks, I'll try.
In general these are considered optional in typescript
function x(aParameter = 'something') {} // aParameter is optional

class A {
   aMember = 'anything'; // aMember is considered with a value
}

I see, btw, how this can be complicated or impossible when assigning a type to the create function

There's another problem with this [OptionalProps] approach. I have all my classes extending a base class similar to this
@ObjectType()
abstract class BaseEntity {
  [OptionalProps]?: 'createdAt' | 'updatedAt';

  @PrimaryKey()
  _id!: ObjectId;

  @SerializedPrimaryKey()
  id!: string;

  @Property()
  createdAt = new Date();

  @Property({
    onUpdate: () => new Date(),
  })
  updatedAt = new Date();
}

now, since this base class already defines [OptionalProps], I cannot redeclare in all the children, forcing me to remove it from here and copy it in all the children classes.

You can use generics for this

Makes sense. Thanks

Makes sense. Thanks

Just to clarify, is this roughly how you'd use generics to handle this case? Is there a more precise way to define the type for T?
@ObjectType()
abstract class BaseEntity<T> {
  [OptionalProps]?: 'createdAt' | 'updatedAt' | T;
}

yop. you could have two type args if you want to make it type safe, so you could use <E, K extends keyof E>

Perfect makes sense, thank you! Would you consider adding some sort of createPartial method that supports the previous interface that doesn't require all keys? We frequently run into cases where we explicitly want to initialize a partial object that gets fully populated later, so we happened to prefer the behavior from <v5.

You can always create such method yourself in a custom repository.
  createPartial<P = never>(data: EntityData<T>): T {
    return this.em.create(this.entityName, data as any);
  }

(if you dont like the any cast, it could be also as unknown as RequiredEntityData<T>)

Perfect, that's exactly what we've done. Thank you!


Amending footer links to include all and start petitions

Fixed the inconsistent labelling of create/start a/start a new petition etc
https://www.pivotaltracker.com/story/show/97506102

Looks good, but definitely needs commits squashing before merging :computer:

Merge when green pls.


[Bug] 'ConfigDict' object has no attribute 'log_level'

描述该错误
When I used my dataset to train resnet ,the terminal told me that 'ConfigDict' object has no attribute 'log_level'.I can't find it's solution  on the  other  website.
环境信息
Traceback (most recent call last):
File "tools/train.py", line 206, in
main()
File "tools/train.py", line 149, in main
logger = get_root_logger(log_file=log_file, log_level=cfg.log_level)
File "/home/lixin/mmclassification/lib/python3.8/site-packages/mmcv/utils/config.py", line 519, in getattr
return getattr(self._cfg_dict, name)
File "/home/lixin/mmclassification/lib/python3.8/site-packages/mmcv/utils/config.py", line 50, in getattr
raise ex
AttributeError: 'ConfigDict' object has no attribute 'log_level'
其他信息
No response

Can you provide your config file?


global: profile creation fix

FIX Fixes a bug in user's initialization in models.

Signed-off-by: PaulinaLach<EMAIL_ADDRESS>

@PaulinaLach I have amended this PR. Please make sure that you configure email and name in git correctly. The signature didn't match the commit author name. (cc @nharraud)

LGTM

LGTM


Fixed an issue in LibLinear.cpp

In response to Issue of fixing memory allocations by SG_MALLOC

Okay I will do check the API

the malloc creates a memchunk of the size of the later used SGMatrix..... so there's no need for the SGVector wrappingm and i believe that this last patch wasn't even compiling locally... plz try to check that before send in a commit unless you are super blocked

the malloc creates a memchunk of the size of the later used SGMatrix..... so there's no need for the SGVector wrappingm and i believe that this last patch wasn't even compiling locally... plz try to check that before send in a commit unless you are super blocked

It's kinda weird it compiled for me when I used the make command, but yea I will pay more emphasis for that from now on I must of gotten it wrong but thanks for exampling however

@Khalifa1997 huh some crazy stuff happened with your branch. i guess you were rebasing something? in general would be great if you'd google around how to rebase a branch over another branch and some other 101 git operations. there are really tons of good material about this out there.
until you get of hold of that maybe just open a PR per commit/fix

Nvm the commits, I had some issues with rebase but I have more grasp of it now :)

@Khalifa1997 it'd be good if you could sort out this PR (i mean the commits) as i'd really like to have it merged into develop, but unfortunately now in it's state its not possible.

@Khalifa1997 it'd be good if you could sort out this PR (i mean the commits) as i'd really like to have it merged into develop, but unfortunately now in it's state its not possible.

Yea I agree, but how do you suggest going about this whenever I do
 git pull --rebase upstream develop
I get those merge changes that I do, then I add the changes, then commit and push
now what happens is I get those ton of commits in the push, and I have no idea how this happens


Dev-002 Create a version to display

Display version number that will allow me to track the changes

version added to form


[FEATURE REQ] Specify which file to download

Hi, is it possible when adding a torrent with multiple files in it to specify which file(s) to actually download (of course I know the exact name of the file(s) to be downloaded in advance) ?

Hi!
As far as I know this is only supported in the desktop ui and not the webui. The WebUI/WebAPI lacks any endpoints to handle partial downloads on add.
There is an open pr #21015 that aims to provide that functionality but it might be months to a year if it is implemented in future versions.


CORE-18532: Retry Transient Errors in Flow Engine

Instead of automatically publishing the original event back to the
"flow.event" topic whenever a transient exception occurs when executing
the flow pipeline, automatically retry the exceptions using an
exponential backoff retry mechanism and permanently fail the flow if
the configured time or attemps is reached.

Create internal retry utility to manage retries in an automated
fashion with plugable backoff strategy (constant, linear and
exponential provided out of the box).
Replace existing utilities in the crypto components and tests with
the new one and delete unused classes.
Update FlowEventProcessor to automatically retry transient exceptions
through the new retry utility using an exponential backoff with a
growth factor of 250ms.
Remove unnecessary code and update tests to accommodate for the new
internal retry.

Did you consider using an off-the-shelf library like Resilience4J rather than rolling our own? (not saying we should, but we should evaluate pros/cons).
Also, I thought we'd look at moving away from crypto doing its own bespoke thing and consolidate how we do retries etc with the RPC pattern?

Did you consider using an off-the-shelf library like Resilience4J rather than rolling our own? (not saying we should, but we should evaluate pros/cons).

I did at the beginning but our use case is quite simplistic at the moment, adding resilience4j felt like killing mosquitos with a cannon... not the most technically valid reason in the world 🤷♂ .

Also, I thought we'd look at moving away from crypto doing its own bespoke thing and consolidate how we do retries etc with the RPC pattern?

Not sure what the background context is here, I've simply created a retry utility to be shared across the code base and refactored the existing crypto retry mechanism to use the new one. Any other work to replace by RPC pattern should likely be its own epic/task, not included within this PR.

Also, I thought we'd look at moving away from crypto doing its own bespoke thing and consolidate how we do retries etc with the RPC pattern?

Yeah I don't remember us discussing or agreeing anything. But as I'm working on handling transient errors for external processors the crypto retry logic breaks the mould. If @dickon agrees we could add a story to remove crypto retry handling and fall back on the RPC client's retry logic, the epic is here.


Sageattention breaks compiling with onediff.

Installed sageattention. It gave a speed boost. Even if I don't use fp8 quant, compile with onediff fails. Says cannot find a compatible kernel from triton. Uninstalling sageattention works but then it can't be used otherwise. 3090 on linux.

I think this is to be expected, I doubt it can work with onediff without specific support from them, I don't know enough of this to say if it's something that will be possible.

I think the fix would be to not have it use sageattention when onediff compile is on, rather than making them work together. Right now it's beating both compilation methods anyways. I get down to 9s/it.
Speaking of compile, the torch.compile also fails on the 2nd gen when the seed is changed. I'd like to try compiling with it that way, but I never get to enjoy the fruits of my labor for that reason.
Have you tried their other onediff backend or is it incompatible with the model arch?

I guess I will try oneflow and see if it errors out.

I guess I will try oneflow and see if it errors out.
edit: played with some of the options you send to nexfort and they speed things up when not using fp8. when the first one was set false, compiling was almost slower than not.

That's curious, it makes no difference to me, but someone else told the same that it's slower... it was taken from the CogVideo example on the onediff repo, probably best to change it then.

Yup, I turned on the other one too, but I don't think that makes a difference in speed. Made the videos less blurry when using the LCM scheduler.
I seem to get the best perf when setting things to FP16 but then I get a black image. Its as if there are NaN in the output. maybe it's so fast because it's multiplying 0's?
I also tried to use ondiff, but it fails on the attention function. The 2 shapes it torch.cat's at line ~63 are not compatible.

Nexfort is the only one I've gotten to work, never got torch.compile to work at all.

Does this mean you also get a mosaic of pixel patches with sageattention installed? Fresh environment, all python versions none of them produce images but removing sageattention fixes it

Nexfort is the only one I've gotten to work, never got torch.compile to work at all.

Does this mean you also get a mosaic of pixel patches with sageattention installed? Fresh environment, all python versions none of them produce images but removing sageattention fixes it

I haven't tried it with onediff, otherwise it's been working fine and I don't see any quality changes.


fixed typos in the URI's referenced

Updated the URI references in the ElevationRequest docs as they were incorrect

#sign-off


install upgrade to 1.2.2 fails in every way

install an upgrade to 1.2.2 fails in every way. this product is proving to be very buggy and the upgrades really make me question whether I should rely in any way on this product.
After I followed the upgrade this is my result
ubuntu@ip-172-31-19-18:/var/www/html/bagisto$ php artisan bagisto:version
v1.1.0
ubuntu@ip-172-31-19-18:/var/www/html/bagisto$ sudo git reset --hard v1.1.2
HEAD is now at c88ca31b9 Merge pull request #2961 from jitendra-webkul/1.0
ubuntu@ip-172-31-19-18:/var/www/html/bagisto$ php artisan bagisto:version
v1.1.0
ubuntu@ip-172-31-19-18:/var/www/html/bagisto$
Notice no upgrade!
these instructions in a ticket also are not very good since I followed the link and di what they said and please notice after bringing my site down and more than 24 hours they cannot help me.
Support Team
Hello Michal Pina
I am attaching a package called bagisto standard which is used to upgrade the latest version of bagisto.
Kindly install this packages UpgradeVersion package in your bagisto and do the required changes as we used to do while creating the package (ex-service providers entry at different places).
Now this package automatically tells you to upgrade version and fro single click you can achieve the same.
Repo - https://github.com/bagisto/bagisto-standard
Note - KIndly take the backup of the database to avoid any problem.
Thanks
Rahul Shukla

I do not know what is happening here!
ubuntu@ip-172-31-19-18:/var/www/html/bagisto$ sudo    composer create-project
Do not run Composer as root/super user! See https://getcomposer.org/root for details

@php -r "file_exists('.env') || copy('.env.example', '.env');"
Loading composer repositories with package information
Installing dependencies (including require-dev) from lock file
Package operations: 5 installs, 73 updates, 25 removals

Removing voku/portable-ascii (1.5.1)
Removing symfony/string (v5.1.0)
Removing symfony/polyfill-php80 (v1.17.0)
Removing symfony/polyfill-intl-normalizer (v1.17.0)
Removing symfony/polyfill-intl-grapheme (v1.17.0)
Removing symfony/deprecation-contracts (v2.1.2)
Removing sebastian/type (1.1.3)
Removing react/promise (v2.8.0)
Removing ramsey/collection (1.0.1)
Removing psr/event-dispatcher (1.0.0)
Removing myclabs/php-enum (1.7.6)
Removing maennchen/zipstream-php (2.1.0)
Removing league/oauth1-client (1.7.0)
Removing laravel/socialite (v4.4.1)
Removing laravel/scout (v8.0.1)
Removing facade/ignition-contracts (1.0.0)
Removing ezimuel/ringphp (1.1.2)
Removing ezimuel/guzzlestreams (3.0.1)
Removing elasticsearch/elasticsearch (v7.8.0)
Removing brick/math (0.8.15)
Removing babenkoivan/elastic-scout-driver (v1.1.0)
Removing babenkoivan/elastic-client (v1.0.1)
Removing babenkoivan/elastic-adapter (v1.2.0)
Removing algolia/algoliasearch-client-php (2.7.0)
Removing laravel/ui (v2.0.3)
Downgrading symfony/polyfill-ctype (v1.17.0 => v1.14.0): Loading from cache
Downgrading phpoption/phpoption (1.7.4 => 1.7.2): Loading from cache
Downgrading vlucas/phpdotenv (v4.1.7 => v3.6.1): Loading from cache
Downgrading symfony/css-selector (v5.1.0 => v5.0.5): Loading from cache
Downgrading symfony/polyfill-php72 (v1.17.0 => v1.15.0): Loading from cache
Downgrading symfony/polyfill-mbstring (v1.17.0 => v1.15.0): Loading from cache
Downgrading symfony/var-dumper (v5.1.0 => v4.4.5): Loading from cache
Downgrading symfony/routing (v5.1.0 => v4.4.5): Loading from cache
Downgrading symfony/process (v5.1.0 => v4.4.5): Loading from cache
Downgrading symfony/polyfill-php73 (v1.17.0 => v1.14.0): Loading from cache
Downgrading symfony/polyfill-intl-idn (v1.17.0 => v1.15.0): Loading from cache
Downgrading symfony/mime (v5.1.0 => v5.0.7): Loading from cache
Downgrading symfony/http-foundation (v5.1.0 => v4.4.7): Loading from cache
Downgrading symfony/event-dispatcher-contracts (v2.1.2 => v1.1.7): Loading from cache
Downgrading symfony/event-dispatcher (v5.1.0 => v4.4.5): Loading from cache
Downgrading psr/log (1.1.3 => 1.1.2): Loading from cache
Downgrading symfony/debug (v4.4.9 => v4.4.5): Loading from cache
Downgrading symfony/error-handler (v5.1.0 => v4.4.5): Loading from cache
Downgrading symfony/http-kernel (v5.1.0 => v4.4.5): Loading from cache
Downgrading symfony/finder (v5.1.0 => v4.4.5): Loading from cache
Downgrading symfony/service-contracts (v2.1.2 => v2.0.1): Loading from cache
Downgrading symfony/console (v5.1.0 => v4.4.5): Loading from cache
Downgrading symfony/polyfill-iconv (v1.17.0 => v1.14.0): Loading from cache
Downgrading doctrine/lexer (1.2.1 => 1.2.0): Loading from cache
Installing paragonie/random_compat (v9.99.99): Loading from cache
Downgrading ramsey/uuid (4.0.1 => 3.9.3): Loading from cache
Downgrading opis/closure (3.5.4 => 3.5.1): Loading from cache
Downgrading symfony/translation-contracts (v2.1.2 => v2.0.1): Loading from cache
Downgrading symfony/translation (v5.1.0 => v4.4.5): Loading from cache
Downgrading nesbot/carbon (2.35.0 => 2.31.0): Loading from cache
Downgrading monolog/monolog (2.1.0 => 2.0.2): Loading from cache
Downgrading league/flysystem (1.0.69 => 1.0.65): Loading from cache
Downgrading league/commonmark (1.4.3 => 1.3.1): Loading from cache
Downgrading doctrine/inflector (2.0.3 => 1.3.1): Loading from cache
Downgrading laravel/framework (v7.14.1 => v6.18.1): Loading from cache
Downgrading astrotomic/laravel-translatable (v11.8.1 => v11.8.0): Downloading (100%)
Downgrading maximebf/debugbar (v1.16.3 => v1.16.1): Downloading (100%)
Downgrading barryvdh/laravel-debugbar (v3.3.3 => v3.2.9): Downloading (100%)
Downgrading sabberworm/php-css-parser (8.3.1 => 8.3.0): Loading from cache
Downgrading phenx/php-font-lib (0.5.2 => 0.5.1): Loading from cache
Downgrading barryvdh/laravel-dompdf (v0.8.6 => v0.8.5): Loading from cache
Downgrading doctrine/cache (1.10.1 => 1.10.0): Loading from cache
Downgrading guzzlehttp/guzzle (6.5.4 => 6.5.2): Loading from cache
Downgrading kalnoy/nestedset (v5.0.1 => v5.0.0): Loading from cache
Downgrading konekt/enum (3.0.0 => 2.3.0): Loading from cache
Downgrading konekt/concord (1.5.1 => 1.5.0): Loading from cache
Downgrading nikic/php-parser (v4.5.0 => v4.3.0): Loading from cache
Installing jakub-onderka/php-console-color (v0.2): Loading from cache
Installing jakub-onderka/php-console-highlighter (v0.4): Loading from cache
Downgrading psy/psysh (v0.10.4 => v0.9.12): Loading from cache
Downgrading laravel/tinker (v2.4.0 => v1.0.10): Loading from cache
Downgrading lcobucci/jwt (3.3.2 => 3.3.1): Loading from cache
Downgrading phpoffice/phpspreadsheet (1.13.0 => 1.11.0): Downloading (100%)
Downgrading maatwebsite/excel (3.1.19 => 3.1.18): Loading from cache
Downgrading prettus/l5-repository (2.6.45 => 2.6.42): Downloading (100%)
Downgrading symfony/polyfill-util (v1.17.0 => v1.14.0): Loading from cache
Downgrading symfony/polyfill-php56 (v1.17.0 => v1.14.0): Loading from cache
Downgrading behat/gherkin (v4.6.2 => v4.6.1): Loading from cache
Downgrading sebastian/global-state (3.0.0 => 2.0.0): Loading from cache
Downgrading phpunit/php-code-coverage (7.0.10 => 6.1.4): Loading from cache
Downgrading webmozart/assert (1.8.0 => 1.7.0): Loading from cache
Downgrading phpdocumentor/reflection-common (2.1.0 => 2.0.0): Loading from cache
Downgrading doctrine/instantiator (1.3.1 => 1.3.0): Loading from cache
Downgrading phpunit/phpunit (8.5.5 => 7.5.20): Loading from cache
Downgrading codeception/phpunit-wrapper (8.1.2 => 7.8.0): Loading from cache
Downgrading codeception/lib-asserts (1.12.0 => 1.2.0): Loading from cache
Downgrading symfony/yaml (v5.1.0 => v5.0.5): Loading from cache
Downgrading codeception/stub (3.6.1 => 3.0.0): Loading from cache
Downgrading codeception/module-asserts (1.2.1 => 1.1.1): Loading from cache
Downgrading symfony/dom-crawler (v5.1.0 => v5.0.5): Loading from cache
Downgrading symfony/browser-kit (v5.1.0 => v5.0.5): Loading from cache
Downgrading codeception/module-laravel5 (1.1.0 => 1.0.0): Loading from cache
Downgrading codeception/module-webdriver (1.1.0 => 1.0.7): Loading from cache
Downgrading mockery/mockery (1.4.0 => 1.3.1): Loading from cache
Downgrading filp/whoops (2.7.2 => 2.7.1): Loading from cache
Downgrading nunomaduro/collision (v4.2.0 => v2.1.1): Loading from cache
Installing laravel/helpers (v1.2.0): Loading from cache
Installing nwidart/laravel-modules (3.3.1): Loading from cache
paragonie/random_compat suggests installing ext-libsodium (Provides a modern crypto API that can be used to generate random bytes.)
Package jeremeamia/superclosure is abandoned, you should avoid using it. Use opis/closure instead.
Package jakub-onderka/php-console-color is abandoned, you should avoid using it. Use php-parallel-lint/php-console-color instead.
Package jakub-onderka/php-console-highlighter is abandoned, you should avoid using it. Use php-parallel-lint/php-console-highlighter instead.

Webkul\Core\Events\ComposerEvents::postCreateProject

| __ )  __ _  __ ()| | ___
|  _ \ /  |/ _ | / __| __/ _
| |) | (| | (| | __ \ || () |
|/ _,|_, ||/__/
|__/
Welcome to the Bagisto project! Bagisto Community is an open-source e-commerce ecosystem
which is built on top of Laravel and Vue.js.
Made with 💖  by the Bagisto Team. Happy helping :)
ubuntu@ip-172-31-19-18:/var/www/html/bagisto$    php artisan vendor:publish
Which provider or tag's files would you like to publish?:
[0 ] Publish files from all providers and tags listed below
[1 ] Provider: Astrotomic\Translatable\TranslatableServiceProvider
[2 ] Provider: Barryvdh\Debugbar\ServiceProvider
[3 ] Provider: Barryvdh\DomPDF\ServiceProvider
[4 ] Provider: Fideloper\Proxy\TrustedProxyServiceProvider
[5 ] Provider: Flynsarmy\DbBladeCompiler\DbBladeCompilerServiceProvider
[6 ] Provider: Illuminate\Foundation\Providers\FoundationServiceProvider
[7 ] Provider: Illuminate\Mail\MailServiceProvider
[8 ] Provider: Illuminate\Notifications\NotificationServiceProvider
[9 ] Provider: Illuminate\Pagination\PaginationServiceProvider
[10] Provider: Intervention\Image\ImageServiceProviderLaravelRecent
[11] Provider: Konekt\Concord\ConcordServiceProvider
[12] Provider: Laravel\Tinker\TinkerServiceProvider
[13] Provider: Maatwebsite\Excel\ExcelServiceProvider
[14] Provider: Nwidart\Modules\LaravelModulesServiceProvider
[15] Provider: Prettus\Repository\Providers\RepositoryServiceProvider
[16] Provider: Tymon\JWTAuth\Providers\LaravelServiceProvider
[17] Provider: Webkul\Admin\Providers\AdminServiceProvider
[18] Provider: Webkul\BookingProduct\Providers\BookingProductServiceProvider
[19] Provider: Webkul\Core\Providers\CoreServiceProvider
[20] Provider: Webkul\Product\Providers\ProductServiceProvider
[21] Provider: Webkul\Shop\Providers\ShopServiceProvider
[22] Provider: Webkul\Ui\Providers\UiServiceProvider
[23] Provider: Webkul\Velocity\Providers\VelocityServiceProvider
[24] Tag: config
[25] Tag: laravel-errors
[26] Tag: laravel-mail
[27] Tag: laravel-notifications
[28] Tag: laravel-pagination
[29] Tag: public
[30] Tag: translatable

0

Copied Directory [/vendor/laravel/framework/src/Illuminate/Foundation/Exceptions/views] To [/resources/views/errors]
Copied Directory [/vendor/laravel/framework/src/Illuminate/Notifications/resources/views] To [/resources/views/vendor/notifications]
Copied Directory [/vendor/laravel/framework/src/Illuminate/Pagination/resources/views] To [/resources/views/vendor/pagination]
Copied Directory [/packages/Webkul/Admin/publishable/assets] To [/public/vendor/webkul/admin/assets]
Copied Directory [/packages/Webkul/Ui/publishable/assets] To [/public/vendor/webkul/ui/assets]
Copied Directory [/packages/Webkul/Shop/publishable/assets] To [/public/themes/default/assets]
Copied Directory [/packages/Webkul/Velocity/publishable/assets] To [/public/themes/velocity/assets]
Copied Directory [/packages/Webkul/Velocity/src/Resources/views/shop] To [/resources/themes/velocity/views]
Copied Directory [/packages/Webkul/BookingProduct/publishable/assets] To [/public/themes/default/assets]
Copied Directory [/vendor/laravel/framework/src/Illuminate/Mail/resources/views] To [/resources/views/vendor/mail]
Publishing complete.
ubuntu@ip-172-31-19-18:/var/www/html/bagisto$   php artisan storage:link
The "public/storage" directory already exists.
ubuntu@ip-172-31-19-18:/var/www/html/bagisto$   composer dump-autoload
Cannot create cache directory /home/ubuntu/.composer/cache/repo/https---repo.packagist.org/, or directory is not writable. Proceeding without cache
Cannot create cache directory /home/ubuntu/.composer/cache/files/, or directory is not writable. Proceeding without cache
Generating optimized autoload files
[ErrorException]
file_put_contents(/var/www/html/bagisto/vendor/composer/autoload_namespaces.php): failed to open stream: Permission denied
dump-autoload [--no-scripts] [-o|--optimize] [-a|--classmap-authoritative] [--apcu] [--no-dev]
ubuntu@ip-172-31-19-18:/var/www/html/bagisto$ sudo   composer dump-autoload
Do not run Composer as root/super user!
Generated optimized autoload files containing 6497 classes
ubuntu@ip-172-31-19-18:/var/www/html/bagisto$ php artisan bagisto:version
v1.1.0

@mikeyapina
Have you added upgradedVersion packages inside your bagisto package/Webkul directory? As said in the provided instruction.

No how would I do that or how would I know to do that>
I am just trying to get ti v 1.2.2 at this point
Isn’t that already part of that build

On Jul 22, 2020, at 11:09 PM, Vaishali Agarwal<EMAIL_ADDRESS>wrote:
@mikeyapina https://github.com/mikeyapina
Have you added upgradedVersion packages https://github.com/bagisto/bagisto-standard/tree/master/packages/Webkul/UpgradeVersion inside your bagisto package/Webkul directory? As said in the provided instruction.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/bagisto/bagisto/issues/3559#issuecomment-662835086, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEONMG7TOWW7SJH76OMR52DR47HY5ANCNFSM4PFHNWYA.

that is what the last guy said now my whole setup is messed up try gin figure out why you guys did not give right instructions
I just wanted to upgrade my system and keep my data now it is a mess
Your isntruciont ski don’t work!

On Jul 22, 2020, at 11:09 PM, Vaishali Agarwal<EMAIL_ADDRESS>wrote:
@mikeyapina https://github.com/mikeyapina
Have you added upgradedVersion packages https://github.com/bagisto/bagisto-standard/tree/master/packages/Webkul/UpgradeVersion inside your bagisto package/Webkul directory? As said in the provided instruction.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/bagisto/bagisto/issues/3559#issuecomment-662835086, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEONMG7TOWW7SJH76OMR52DR47HY5ANCNFSM4PFHNWYA.

@mikeyapina
all the provided instruction are working at our end, so We are checking what's wrong done at your project and get back to you!
We value your time.

We value your time.

We value your time.

6 months of work has been written over by your not correct upgrade instructions!

I fixed it.

Dear we appreciate your feedback and understand your frustration, but as @vaishaliwebkul  pointed out, someone of the team was following up on your problem as the upgrade documentation is correct.
I do notice that your issue has been resolved now so great to hear that.
We have also simplified the upgrade process for more info please check the following link https://bagisto.com/en/how-to-update-bagisto-with-one-click
if you have any questions or comments about this issue, do not hesitate to contact us.

@vaishaliwebkul i think this issue can be closed.

Where is the documentation to upgrade 1.1.0 to 1.1.1+?

Where is the documentation to upgrade 1.1.0 to 1.1.1+?


Show deprecation warnings in hint typeahead

This adds additional rendering in the hint typehead to indicate when a field hinted is deprecated. The styling matches that used in the info hover tooltips.
As mentioned in #273

lg2m


Closes #5 - Extension of the sorting function

Closes #5 - Extension of the sorting function

Let me just address some concerns besides the technical difficulties I´m having trying to get this to work:

not all files added via this PR are in use (e.g. src/img/blueCheck.png, src/img/greenCheck.png)
-> do we really need those images at all or could we find a more simpler or even more meaningful way of displaying available metrics?

new dependencies were added
-> are those really needed? Cant we get around using bootstrap

code formatting
-> lots of empty space, using a codeformatter with shared preferences should help avoiding commiting formatting changes in future commits

cleanup code

-> there should not be any logs left in "a final version" that we merge into the main branch. Same goes for unnecessary commented out code.


failing test cases

I found some cases to fail, how do I solve that issue?
Total Test time (real) =   3.53 sec
The following tests FAILED:
1 - flang-20190512a-run (Failed)
3 - flang-20190511b-run (Failed)
4 - flang-20190511c-run (Failed)
5 - flang-20190506b-obj (Failed)
6 - flang-20190506c-obj (Failed)
7 - flang-20190505a-run (Failed)
8 - flang-20190504a-exe (Failed)
9 - flang-20190504a-run (Not Run)
10 - flang-20190504b-run (Failed)
11 - flang-20190504c-run (Failed)
12 - flang-20190503a-run (Failed)
13 - flang-20190503b-run (Failed)
17 - flang-20171123a-obj (Failed)
18 - flang-20171123b-obj (Failed)
21 - flang-20171122c-run (Failed)
24 - flang-20171122f-run (Failed)
25 - flang-20171122g-run (Failed)
32 - flang-20170924c-run (Failed)
Errors while running CTest

All the test cases in this repo were written to expose bugs in the respective compilers. Some compiler bugs have been fixed (those tests pass), while others have not.  Unless you are a flang compiler developer, you or I can't "solve" the issue; that's up to the flang developers. But these issues have been reported to flang.  The comments at the top of each source file have a link to the corresponding issue in their issue tracker.


Add support for smooth pinch-to-zoom on a trackpad (bug 1659492)

I tested the feature on a windows laptop and on a macbook and in both cases it works well.

/botio-linux preview

@Snuffleupagus could you re-review it please ?
I made some changes to take into account your last comment which led me to think that the 1e-2 was not a good threshold (1% of 10% is not the same as 1% of 500%).
I tested successfully those changes on touchscreen and on two laptops (mac and win) with a trackpad.

/botio-linux preview


Add Andi Wang to Contributors list

@Andi-Wang, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added Facebook share and tweet feature to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.

I've used a bit of Git before, so in my own experience the experience was a bit underwhelming (especially with how trivial the pull request was).
However, I went on to make another merge request fixing a bug on a different open source project. Since I spent a couple hours working on that merge request, I was pretty excited when I received comments from a couple of collaborators this morning. (Still in the process of altering my changes there, so it hasn't been pulled yet.) I also found myself referring back to various tidbits in this guide more than once, so it was helpful in that way as well.
Pain point so far is definitely squashing/rebasing. Haven't used those before, but the other project requested that contributors use it. I just saw that there's a mention of those things here as well, so I'll be taking a look at that when I have the time.

We also have a slack team to help/mentor people trying to contribute to open source projects.
You can join the team by going to https://goo.gl/PM1Jdh
Please share a link to the above mentioned pull request in the slack group. It'll inspire others too


Does resource graph query supports microsoft.Authorization?

Can you please confirm if resource graph query does not support microsoft.Authorization/*?
Seems to me it's not available, I would like to understand why resource group only certain type of resources, not all.
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 824e201e-3023-45c1-d14d-488e2584b9ef
Version Independent ID: fa14046b-ceb4-1368-2766-39e70c2088c2
Content: Overview of Azure Resource Graph - Azure Resource Graph
Content Source: articles/governance/resource-graph/overview.md
Service: resource-graph
GitHub Login: @DCtheGeek
Microsoft Alias: dacoulte

@RonnieQuan Thanks for the question.  While most Microsoft.Authorization types aren't currently supported in Azure Resource Graph, resourceManagementPrivateLinks is.  For the full list of supported types, see Azure Resource Graph table and resource type reference.
#assign:DCtheGeek
#label:triaged
#label:assigned-to-author
#label:product-question
#please-close

#label:"triaged"
#label:"assigned-to-author"
#label:"product-question"


Support for external secondary instances (WIP)

Closes #201
I have verified this PR works in these browsers (latest versions):

[x] Chrome
[x] Firefox
[x] Safari (macOS)
[x] Safari (iOS)
[ ] Not applicable

What else has been done to verify that this works as intended?

Some existing tests ported from JavaRosa now pass

At least one happy path test for each format (XML, CSV, GeoJSON)

Added a slew of CSV parsing tests based on conversation yesterday with @lognaturel

Added/updated integration in @getodk/web-forms dev/preview modes:

Web Forms Preview: when a user uploads a form referencing an external secondary instance, previewing the form will behave as if those instances are blank/empty.
Dev mode: when loading a fixture from the file system, it will load any referenced external secondary instances from files of the same name, in the same directory as that fixture; if any referenced file does not exist, the form will fail to load.

These cases effectively represent the behaviors an integrating host application can expect. The latter is the default behavior for missing external secondary instance resources. The former requires a configuration option, and should be suitable for e.g. Central's form preview mode.

Worth noting: there is still a failing test ported from JavaRosa, where an error is expected when referencing a node that doesn't exist in a secondary instance. This test technically references an external secondary instance, but it isn't clear whether the behavior would be applicable to all secondary instances.
Another test ported from JavaRosa is now marked failing, representing the same default behavior for missing external secondary instances described above. A companion test has been added representing the optional/configured alternate behavior.
Why is this the best possible solution? Were any other approaches considered?
This builds on the work in #245, and mostly follows the design laid out in #201. It deviates somewhat from that design, mostly addressing some of the later discussion on that thread. I'll add more detail on that deviation below.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
The main regression risk I can think of is that the newer default behavior is technically stricter for forms with external secondary instance references. Prior to this PR, those forms will always treat all such instances as blank. As of this PR, by default they'll be loaded and parsed by default, and evaluated as appropriate for any instance(...)/... expression defined in the form.
The other regression risk is that this does introduce breaking changes for host applications. Those will also be detailed below.
Do we need any specific form for testing your changes? If so, please attach one.
This is pretty much covered by existing/added test fixtures. If you want to try it with your own form/attachments, they can be placed together in any fixtures subdirectory and accessed in dev mode.
What's changed
Breaking changes: host application <-> @getodk/web-forms

To support loading external secondary instances, a host application must implement a fetchFormAttachment function.
To provide a graceful fallback for loading a form without loading external secondary instances, a host application must override the default missingResourceBehavior option.

Both of these are specified (likely in kebab-case) as props on the OdkWebForm component.
Breaking changes: client <-> engine
The same host/client breaking changes apply to integration between clients and the engine. These breaking changes have been implemented in @getodk/web-forms to support host application integration. They've also been implemented in @getodk/scenario to reflect the functionality in existing/added tests.
Note: I am only realizing now that I've neglected to integrate these changes in @getodk/ui-solid. I am honestly not sure how valuable the package is at this point, so I'm hesitant to address this unless anyone feels strongly otherwise. If we all agree that the package itself isn't providing much value now, I'd like to consider removing it sometime soon (so it doesn't languish in a weird semi-broken state).
Engine configuration: fetchFormAttachment
The interface for this configuration is (simplified for reading inline):
type FetchFormAttachment = (resource: URL & { protocol: 'jr:' }) => Promise<FetchResourceResponse>

... where FetchResourceResponse is the same subset of Response already exposed for loading remote XForm XML resources, slightly expanded to allow an optional headers property (which in turn is a subset of the native Headers type).
This deviates from the design in #201: rather than providing a Map (or other map-like structure) for resolving jr: URLs, clients are expected to provide a fetch-like function. This deviation from the design is intended to address discussion in that issue around the appropriate keys for such a map-like structure.
In spirit, it makes sense that the keys should be the full jr: URL (which I believe reflects @brontolosone's view in that discussion). In practice, a client and/or host will almost certainly be resolving those jr: URLs from a file name without additional information. In order for a caller to be able to satisfy a mapping between jr: URL and something resolving it, we'd need to provide a parsed set of URLs to satisfy. We can certainly do this! And we've discussed doing it. But as a primary API, it would complicate the form initialization process by introducing a step I believe is unnecessary.
This design change is a compromise recognizing that these are conceptually equivalent concepts:

map-like structure whose values may be accessed by a suffix of its canonical keys
function of canonical key to value

I briefly considered providing a sample implementation for the two most common formats we'd expect to derive this configuration: OpenRosa Manifest documents and the Central Form Attachments API. But I decided that implementing them is trivial enough that it shouldn't hold up the PR. I'll be happy to assist with integration if it turns out to be less obvious downstream than I hope.
Engine configuration: missingResourceBehavior
This configuration is mostly described above. It reflects a duality of expected behaviors:

By default, a form is not complete without its external secondary instances
There are specific use cases where that default is unsuitable (e.g. various use cases conveniently all called "preview")

The configuration options for this are exposed as constants, but a bare string is acceptable as well.
Notable engine internal implementation details
This is mostly covered in 0fbc3c5 and its commit notes. The most important detail is that parsing and loading is intentionally staged/layered:

I/O
Data format detection
Per-format parsing logic
Common representation of all external secondary instances
Finally, common representation of all secondary instances

That final common representation is then provided through PrimaryInstance to its instance of XFormsXPathAdapter. From there, evaluation of a form's instance(...)/... expressions makes no distinction between any secondary instance's type (internal vs external), source (XForm definition, FetchFormAttachment response) or format (XML DOM, XML text, CSV, GeoJSON).
There is also a bit of groundwork in the I/O layer anticipating support for media attachments. Not much is done there other than recognizing the entrypoint for that functionality will likely flow through a common FormAttachmentResource abstraction (as do external secondary instance resources now).
Acknowledgement: some of the StaticNode interfaces are super awkward
(Where StaticNode and its subclasses are part of the engine's DOM adapter representation introduced in #245.)
Parsing logic for both CSV and GeoJSON introduce some indirection around these representations to make them a little bit easier to reason about/more ergonomic to use. I think there's some room to simplify the base constructor signatures further, but I decided to put that off and live with that bit of tech debt for now. I'm eager to land the functionality, and expect others on the team are as well. So let's call this ready for review!

Yay!
The tests you added following our conversation look great. I haven't gotten to adding a test for JR around behavior when CSV tokens have whitespace around them. The behavior at https://github.com/getodk/web-forms/pull/259/commits/6b1f1454749c6ab5226d3ba6654d15f254639645#diff-0ae498d66cc2114687268adaea646f23d17985f3209cc8596693a1e55251eeffR918 looks like it matches the JR behavior and I'm not inclined to make any changes to it currently. For posterity -- Enketo strips those spaces.
I'd be inclined to have an option or config prop for the client <> host interface for optional things like the missing resource behavior configuration. Is this kind of thing good to consider now? We could certainly also refine it later.
I am surprised by MissingResourceBehavior in general. I expected to see a boolean related only to external secondary instances. Is this intended to apply to other media attachments? Any other kinds of resources? I think we've talked about how external secondary instances are typically more critical than image/audio/video attachments. Someone may want to require external secondary instances to be there but accept that some other media could be missing. Is that maybe why you have the flexibility of a non-boolean type? But then BLANK feels like it doesn't leave room for the variations I've mentioned.

Yay!
The tests you added following our conversation look great. I haven't gotten to adding a test for JR around behavior when CSV tokens have whitespace around them. The behavior at 6b1f145#diff-0ae498d66cc2114687268adaea646f23d17985f3209cc8596693a1e55251eeffR918 looks like it matches the JR behavior and I'm not inclined to make any changes to it currently.

🎉

For posterity -- Enketo strips those spaces.

It might be interesting to track these specific divergences as they come up. If nothing else it could be valuable documentation. It could also theoretically be part of some kind of config-based way to trigger more Enketo-like behaviors, at least for behaviors users express interest in.

I'd be inclined to have an option or config prop for the client <> host interface for optional things like the missing resource behavior configuration. Is this kind of thing good to consider now? We could certainly also refine it later.

Unless I'm misunderstanding, I think that's covered by this prop. That's a prop on the OdkWebForm component (currently the main host <> UI entrypoint). The intent is that host integrations would conditionally specify 'BLANK' where appropriate. Here is an example where it's in use (effective for both Web Forms Preview and dev mode). I'd expect Central will likely use it for preview mode.
I suppose it'd make sense to update the @getodk/web-forms README to mention that prop. I can do that if that would help make this clearer. It didn't really occur to me that we're using that as API documentation. I tend to think of the type definitions as the source of truth for stuff like this at package boundaries, absent a more dedicated documentation site.
On that note: insofar as the OdkWebForm Vue component and its props constitute our official host <> UI interface, we might want to consider using a documentation generator instead of the README. That way we can be sure it's up to date, and probably benefit from other details commonly solved by such tooling. I'm not sure whether the tool used for the engine API is suitable, but I'd be happy to file an issue about it if there's interest.

I am surprised by MissingResourceBehavior in general. I expected to see a boolean related only to external secondary instances. Is this intended to apply to other media attachments? Any other kinds of resources? I think we've talked about how external secondary instances are typically more critical than image/audio/video attachments. Someone may want to require external secondary instances to be there but accept that some other media could be missing. Is that maybe why you have the flexibility of a non-boolean type? But then BLANK feels like it doesn't leave room for the variations I've mentioned.

Yeah, this gets at the intent of making it an enum. The fetchFormAttachment signature is designed to be general enough for loading all form attachments, but the branchy logic isn't likely to be binary when we add support for media. If we made it a boolean flag now, we'd proably end up with at least one additional boolean flag (perhaps more?). As it stands, I hope the enum values are reasonably self-explanatory (and if they're not that, I'd like to revisit!), but it's definitely intended to support additional values.
I also hope that BLANK as a concept is general enough that we can expand on the existing application of that concept to produce valid-but-void representations for any other missing resource. That way the engine can provide some meaningful/usable non-null value anywhere a client would expect to find and present media. I haven't thought too far ahead on what that BLANK representation might be for a given media type—it may just be stub blob:/data: URLs appropriate for the expected MIME type, maybe something more structured depending on where that design goes. But I think it'll be valuable to have something non-null in those cases (at the engine/client boundary) once we get there.

It might be interesting to track these specific divergences as they come up

Agreed. I try to at least have them in the differences doc we have and added some details at
https://docs.google.com/document/d/1hmHrHJYsbovzli2aLHLvdt6Tq9reibnC4PylunKI58I/edit?tab=t.0#heading=h.dima7n868glp

Unless I'm misunderstanding, I think that's covered by this prop.

I wasn't clear enough! I mean instead of having that at the top level, introduce a prop with name config or options that would be an object with a defined type for all of the different optional configurations that we'll eventually have. I think there will be many and that it will be nice from a user standpoint to see a difference between things that are critical to think about and others that are less so.

Yeah, this gets at the intent of making it an enum.

So instead of a couple of booleans we'd end up with the corresponding cross product, basically. Something like BLANK, ERROR, EXTERNAL_SECONDARY_ERROR__OTHERS_BLANK, EXTERNAL_SECONDARY_BLANK__OTHERS_ERROR (maybe not needed) And then we'd have room for other nuances we may eventually learn about.
Did you consider making this part of what the host returns on a per-resource basis instead of a blanket config ("here's how you get the resource and what you should do if you find you can't")? I imagine Central would just use the resource type to decide so what you have now is sufficient but other hosts could do things like state that a specific video is critical to the form but others aren't.


🐞 - Multiselect dropdown jerks when using expanded="true"

Which @taiga-ui/* package(s) are the source of the bug?
kit
Please provide a link to a minimal reproduction of the bug
https://stackblitz.com/edit/taiga-starter
Description
https://user-images.githubusercontent.com/46284632/159659944-0da5d290-75bf-467a-9f9e-3e0820b1d075.mov
Angular version
9>
Taiga UI version
2.38.0
Which browsers have you used?

[X] Chrome
[ ] Firefox
[X] Safari
[ ] Edge

Which operating systems have you used?

[X] macOS
[X] Windows
[ ] Linux
[ ] iOS
[ ] Android

any updates about this bug?


Shorten outbound connectivity check wait

This PR makes two changes:

Shorten the retries for outbound connectivity check from 100 to 50 retries.
Avoid blocking on nc command and timeout after 30s. I'm not sure what the intention of the second if clause was because on success, we won't print the time. I've repurposed to be a final retry that would tell us if our timeout for the first clause is too aggressive but pretty sure we can just drop it and alternatively print the retry co

Basically, the second or conditional would allow us to uncover "slowness" in case our 10s timeout for the first clause is too long. This gives it a grace period of 30s for one last retry. In the worst case, we'll end up waiting ~10min.
Planning on following-up with a further shorter number of retries.

😭


Add Modal Component

Add Modal Component #1

Hey Chalarangelo, I have updated the PR but to be honest im not that good at documentation so i need your help for that.
Thanks

Hey Chalarangelo,
Can you please what is remaining?

Thanks bro


how to recv other people send e2eemessage？

upup

DON'T MAKE NEW ISSUES WITH A QUESTION
Use Github Discussion
https://github.com/DeachSword/CHRLINE/discussions
Or Join our Discord group (link in README.md)


Moved test out of run_in_eager_and_graph_mode in resampler_ops.

@autoih
You are owner of some files modified in this pull request.
Would you kindly review the changes whenever you have the time to?
Thank you very much.

@gabrieldemarmiesse, not sure why it's waiting for cla, can you please help check? Thanks.

The cla is not preventing us from merging. So no worries on this part.

It seems there are conflicts. Could you fix them? Thanks, @gabrieldemarmiesse.


Add ability to easily create/manage arpa treasury report queue locally

Ticket #Add ability to easily create/manage arpa treasury report queue locally
Description
The task achieved was to add two env variable in two different files that will make easier to create/manage arpa treasure report queue locally.
Screenshots / Demo Video
N/A
Testing
Automated and Unit Tests

[ ] Added Unit tests

Manual tests for Reviewer

[ ] Added steps to test feature/functionality manually

Checklist

[ ] Provided ticket and description
[ ] Provided screenshots/demo
[ ] Provided testing information
[ ] Provided adequate test coverage for all new code
[ ] Added PR reviewers

I'll make sure to follow the branch naming convention for next PRs :)

@inaki this looks great so far, but we might have to update this a little bit more.
How do you plan on running the workers?
Looking at https://github.com/usdigitalresponse/usdr-gost/blob/main/packages/server/src/scripts/arpaTreasuryReport.js, it looks like it wants this process.env.TASK_QUEUE_URL, which as of now is set to the audit report.
I also added some runners in package.json to make running the process locally a little easier. It may be worth adding that for the treasury report workers as well.

@inaki @tzinckgraf Adding a few thoughts on the path forward for this type of setup...
First, maybe TASK_QUEUE_URL doesn't need to be set in packages/server/.env since it's a common directive that each async task worker expects to point to whatever queue it should be polling to find new tasks; it could just as well be passed to a task runner as a CLI flag like --task-queue-url=http://sqs.region.localstack-hostname:4566/000000000000/queue. For that matter, I'm actually not aware of anything that ensures env vars from packages/server/.env are sourced when running any of the async task workers that initialize from packages/server/src/scripts – I don't see any usages of dotenv in arpaAuditReport.js or arpaTreasuryReport.js, for example. (Note: this is different with docker compose setups – see below). So there's a general point here that currently, there are no environment variables (including TASK_QUEUE_URL) inherently deriving from packages/server/.env when a script is run.
Second, although setting the queue URL via a common environment variable name is useful for instrumentation and deployment, it doesn't have to be the (only) means by which the queue URL is configured for a specific task worker. Again, we could use a CLI flag, or we could have a "higher weight" environment variable that we use in dev environments, e.g.
// async function main() in packages/server/src/scripts/arpaAuditReport.js ...
const queueUrl = process.env.AUDIT_REPORT_TASK_QUEUE_URL || process.env.TASK_QUEUE_URL;

and expect that AUDIT_REPORT_TASK_QUEUE_URL is only used in non-dev environments.
Third, we could lean into what @tzinckgraf configured for the start:arpa-audit-worker and debug:arpa-audit-worker scripts in packages/server/package.json and rely on that mechanism to ensure that those scripts are properly configured when run in a development environment.
Finally, as mentioned earlier, there are docker compose workflows to consider and potentially build a solution around. Our docker-compose.yml file configures the app service with env_file: ['./packages/server/.env'], which does mean that anything run in the app service container loads environment variables from that file (regardless of whether a tool like dotenv is in use). Another (and not mutually-exclusive) approach here would be to define task workers as new services in docker-compose.yml.

To offer something concrete: from my perspective, we should have an easy way for developers to run these workers with necessary configuration options (including/especially environment variables) by default. I feel like this would work best by continuing with the package.json scripts convention that @tzinckgraf mentioned earlier, but adding a bit more instrumentation to ensure that, at minimum, default environment variables are sourced from packages/server/.env, and that TASK_QUEUE_URL was set explicitly per-worker when executing the script. I could see that working like this:

In packages/server/.env.example, set per-worker task queue URLs, e.g. AUDIT_REPORT_TASK_QUEUE_URL=https://...
In packages/server/package.json modify start:arpa-audit-worker to do the following

Something (maybe using dotenv?) that sources environment variables from .env
Runs TASK_QUEUE_URL=$AUDIT_REPORT_TASK_QUEUE_URL node src/scripts/arpaAuditReport.js

Repeat step 2 for debug:arpa-audit-worker
Add `start:arpa-treasury-

PS- I clicked the wrong button; sorry for closing & reopening the PR!

Closing as the requirements have changed.


fix(plugin): check for empty pod list in "cnpg psql"

This patch adds a check for an empty pod list in NewCommand function and raises an error if no pods are found.
Closes #5913

/test d=push tl=4


[PUI] Part Pricing Improvements

Follows on from https://github.com/inventree/InvenTree/pull/6985
Tasks

[x] Add button to reload / rebuild part pricing
[x] Add dialog to edit manual pricing overrides
[ ] Split pricing history into separate panel tab potentially
[ ] Add separate permissions RuleSet for viewing pricing data

Closing this, merging with https://github.com/inventree/InvenTree/issues/7025


Add safety check to ensure no softlocks

Some quick code to run through the progression and ensure no softlocks were generated. Realize I should've done a bit more vigorous testing before pushing, but at least this test has shown that no softlocks are generated.
Feel free to toss this Pull Request if you think it adds too much overhead, just wanted to mention it as evidence that I didn't ruin the logic with my changes.

Would love to merge this just to have a safety net in the future. There are some conflicts because I reformatted the code additions from the previous merge to match existing code style. Can you rebase your changes on top and match the coding style of this repo? Mainly, limit lines to 80 chars, omit semicolons from line ends, and use Array.from() instead of using spread syntax (im not sure what browser support for ES7 operators is like lately and i would rather be safe than break the rando for people on shitty browsers).

I think that's everything? Let me know if I missed anything.


Jersey localised home page

First "sweep" of localisation changes, focussed on the home page and petition show pages.
Does not include:

most of admin backend
archived petitions
static pages linked in footer

Marked DO NOT MERGE as I expect master should be updated from alphagov upstream first.

Removed DO NOT MERGE as this repo has now been synced with the upstream fork


make va"aw works fine

imagine you have this text
        class="top" style="border:none;margin-top: 1px;" href="this"

if you want to select the first attribute from the word "style", you can 2f". but if you are in the middle of the value, it would be nice to have va"aw works. instead, aw selects href=.

<Visual>aw seems to extend to the right; but you can do the va"obb which does the following:

va" selects the double-quoted string; the cursor is left on the right-hand quote.
o moves the cursor to the other end of the visual selection
b moves it to the equal sign
b again moves it to the s of style=

Best regards,
Tony.

thanks for the tip. a bit shorter with va"oB.
but anyway, it doesn't feel consistent when you have habits like vatatatat.
regards

@eiro , Can this PR be closed?

indeed


Add dockerfile

Given the difficulty in getting the dependencies working together properly, as well as the separate Caffe build, I've worked up a Dockerfile in order to create a sterile environment going forward.

@piiswrong can you re-merge - sorry, I just noticed a typo at the end of the apt-get lines


Connection drop

During development and test deployment I was getting several connections drops.
After the stable / working-state release I was able to replicate the same problem. It's seems that after the very first packets are sent out and the wait time before data re-check (5 min), the packets after that are not being sent to the APRS server.

Fixed by @AlexandreVaughan with commit #5


chat server crashes on client timeout uncaught error

recent commit attempts to fix this, it maybe works ???


Ignore .odo/env folder for devfile

What type of PR is this?

Uncomment only one  /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug
What does does this PR do / why we need it:
Add .odo/env in the .gitignore file for devfile push
Which issue(s) this PR fixes:
Fixes https://github.com/openshift/odo/issues/3386
How to test changes / Special notes to the reviewer:
Do odo create..odo push component creation
and then check .gitignore for .odo/env

/retest

error: some steps failed:
  * could not run steps: step unit failed: test "unit" failed: the pod ci-op-8whi026s/unit failed after 1m51s (failed containers: test): ContainerFailed one or more containers exited

/test unit

/approve

/hold
until PR 3291 is merged

Removing hold as the 3291 PR got merged
/hold cancel

/retest


Replace Identicon by component from SRC

Closes #2099
Now we use the Identicon component from SRC
https://components.gnosis-safe.io/?path=/docs/utils-identicon--sizes

@alongoni please, also take note of all the screens where the component was replaced so Franco can know where to test.
cc: @francovenica

hey @nicosampler  I was thinking that we could leave this PR as it is and make anothers PRs (smallers) for Cp buttons, texts, addresses, etc.
Also we have a ticket for cp button https://app.zenhub.com/workspaces/safe-multisig---web-5ce554debb310a35b2f8b6f8/issues/gnosis/safe-react/2097
Make sense?

no, I would add all in the same PR, the changes needed are really simple to review.

good job @alongoni

This is the complete list to check where the components were replaced:
Welcome (Add Safe):

[x] Load existing Safe (Owner list and review)
qa note: I assume the safe's icon and hash as well in the review step. all look good
[x] New Safe - Review Information (see data-testid) @francovenica
qa note: I'll find a way around the test id thing

New transactions:

[x] Send funds
[x] Send funds (Review)
[x] Send - Contract Interaction
[x] Send - Contract Interaction (Review)
[x] Send - Collectible
[x] Send - Collectible (Review)

Address Book:

[x] Address Book
[x] Send Assets Modal
[x] Receive Assets Modal
qa note: receive is not in the address book anymore, but is on the left sidebar, under the safe  name

Settings:

[x] Remove Safe Modal
[x] Owners: Manage Safe owners list
[x] Owners: Edit owner name modal
[x] Owners: Add new owner (Review)
[x] Owners: Remove owner.
[x] Owners: Remove owner (Review)
[x] Owners: Replace Owner
[x] Owners: Replace Owner  (Review)
[x] Advanced: Safe Modules List
[x] Advanced: Safe Modules Modal (remove)

Everything looks good
@alongoni Question: The "spending limit section hasn't being touched?"

hey @francovenica. No, the Spending limit section has already implemented the EthHashInfo component. So no changes needed there.


v1.8.1, Support<EMAIL_ADDRESS>

bors try

Maybe make a separate 1.8.0 branch from that tag and use that instead of main?

bors try


Fixed simulation end freeze bug

Description
Problem: Bug causing the simulation to freeze after running a route scenario.
Solution: Synchronous mode is now removed when the simulation ends (either normally or via manual interruption)
Where has this been tested?

Platform(s): Ubuntu 18.04
Python version(s): 3.6
Unreal Engine version(s): 4.22
CARLA version: 0.9.8

Possible Drawbacks
None?

This change is

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

scenario_runner.py, line 193 at r2 (raw file):
Previously, fabianoboril (Fabian Oboril) wrote…
I don't exactly follow your idea. Is it to just add an additional check to see if the manager is not None?

Yes, I think we have to do that.

Please rebase ;)


Support YAML encoding for generic resources

Resources such as namespaces and roles are considered generic.
Todo:

[x] draft code per component to encode envoy nodes into YAML documents
[ ] implement codegen based on the draft implementation

Important points:

Support arbitrary io.Writer instead of just writing to files
The encoding interface changed drastically from the previous version
Special attention to nesting resources

[ ] option to trim/include empty values
[ ] option for custom param encoding
[ ] custom ref field logic (try to use handles instead of IDs)

[ ] TZ and time layout error reporting (currently I panic out)


Adds macro thrift struct constructor.

Adds a function to Inspect that abstracts constructing scrooge and humbug thrift structs and refactored the Decode, Join and Transform macros to use.

:+1:


New fixture

Excellent Robert ! :+1:
Just one minor thing. When you commit to your branch please give a description that can be recognized in the GIT history. In this case: "New fixture: Venue ThinPar 38"
Keep up the great job ! This is the way :smiley:

I noticed that as soon as it got posted!


[Bug] The detail value is below the gauge

Version
5.5.0
Link to Minimal Reproduction
https://echarts.apache.org/examples/en/editor.html?c=gauge-temperature
Steps to Reproduce
On echart documentation, on the gauge, if you shrink the browser window enough, the value of the gauge detail falls below the gauge itself.
Current Behavior

The value is below the gauge
Expected Behavior
We need to be able to see the value of the gauge above the gauge, so that the value is legible.
Environment
- OS:
- Browser:
- Framework:

Any additional comments?
The problem seems to be that the svg components are displayed in the order in which they were created, so the text would have to be generated last for it to be above the gauge.

The referenced example is made of two gauges. By setting zlevel: 11 to the second one, we can improve the view, but not solve the problem entirely, unless the second progress is removed, Demo.

 Is it possible to set a specific zlevel on the progress gauge?

ok, if two do not work, let it make three - Demo.
lot of trouble for a pretty picture, heh...


rework implicits in grpc sample

see https://github.com/apache/incubator-pekko-grpc/issues/49 for background
this change reduces the number of implicits used

See #16

I'll look into whether this extra implicit is intentional or some kind of smell

@pjfanning @sam-byng Is this PR fine to merge? I want to apply scalafmt on this repo and its best to do when there arent many PRs open.

merged


Couldn't load the irb library 'boson/console': SyntaxError

Couldn't load the irb library 'boson/console': SyntaxError

/var/www/gcr_ordering/shared/bundle/ruby/2.2.0/gems/boson-more-0.3.0/lib/boson/repo_index.rb:38: syntax error, unexpected keyword_do_cond, expecting ':'
File.open(marshal_file, 'rb') do |f|
^
/var/www/gcr_ordering/shared/bundle/ruby/2.2.0/gems/boson-more-0.3.0/lib/boson/repo_index.rb:41: syntax error, unexpected ':', expecting keyword_end
end : [[], [], {}]
^
/var/www/gcr_ordering/shared/bundle/ruby/2.2.0/gems/boson-more-0.3.0/lib/boson/repo_index.rb:73: syntax error, unexpected keyword_do_cond, expecting keyword_end
File.open(marshal_file, rdwr_access) do |f|
^
/var/www/gcr_ordering/shared/bundle/ruby/2.2.0/gems/boson-more-0.3.0/lib/boson/repo_index.rb:134: syntax error, unexpected keyword_end, expecting end-of-input
/var/www/gcr_ordering/shared/bundle/ruby/2.2.0/gems/activesupport-4.1.5/lib/active_support/dependencies.rb:247:in `require'
Loading production environment (Rails 4.1.5)

Thanks for reporting your issue! This is one of my 13 active issues. Use that link to check how soon your issue will be answered. Don't forget to check your issue against this project's CONTRIBUTING.md. Cheers.

Fixed in #4

0.3.1 released with fix


Spring boot version 2.7.5 @ SentinelRestTemplate does not take effect

My version is as follows:

<spring-boot.version>2.7.5</spring-boot.version>
<alibaba-cloud.version>2<IP_ADDRESS></alibaba-cloud.version>
<springcloud.version>2021.0.4</springcloud.version>

It is found that @ SentinelRestTemplate does not take effect when it is placed in the restTemplate. There is no problem with calls between feigns. I guess the version is incompatible,
Can you give me a compatible version? I used the version of spring boot recommended on the official website, which is 2.6.11, and it doesn't work

You can refer to example module and check whether miss some configurations or dependencies. It works in our example.

You can refer to example module and check whether miss some configurations or dependencies. It works in our example.

I mean, the @ SentinelRestTemplate annotation does not mean that load balancing is not possible, but that the circuit breaker policy cannot take effect. The circuit breaker policy invoked by feign is OK

@ SentinelRestTemplate annotation in RestTemplate is alright.

@ SentinelRestTemplate annotation in RestTemplate is alright.

You can limit the flow in this way. I have already run in the demo. However, what I am simulating now is that the provider has two nodes, one of which returns slowly, and the other returns normally The json file is configured with a fusing policy. It is found that the nodes are always polled and no fusing occurs
The file degraderule.json has the following contents
[
{
"resource": "GET:http://service-provider/echo/{str}",
"count": 1,
"grade": 2,
"timeWindow": 5,
"statIntervalMs": 10000,
"minRequestAmount": 3
}
]

@steverao Can you help me with this question?

ok, I reproduced the problem, it seems come from Sentinel. If you want to use degrade in RestTemplate, you can adjust version. If we solved it, we will tell you in the issue.

@steverao Can you help me with this question?

ok, I reproduced the problem, it seems come from Sentinel. If you want to use degrade in RestTemplate, you can adjust version. If we solved it, we will tell you in the issue.

OK，thank you so much

@ SentinelRestTemplate annotation in RestTemplate is alright.

You can limit the flow in this way. I have already run in the demo. However, what I am simulating now is that the provider has two nodes, one of which returns slowly, and the other returns normally The json file is configured with a fusing policy. It is found that the nodes are always polled and no fusing occurs The file degraderule.json has the following contents [ { "resource": "GET:http://service-provider/echo/{str}", "count": 1, "grade": 2, "timeWindow": 5, "statIntervalMs": 10000, "minRequestAmount": 3 } ]

I found the result, because, your configuration is wrong. You can refer to Sentinel document to see how to configure slow response.
. In your configuration, you grade is 2, it means mode of error count.

@ SentinelRestTemplate annotation in RestTemplate is alright.

You can limit the flow in this way. I have already run in the demo. However, what I am simulating now is that the provider has two nodes, one of which returns slowly, and the other returns normally The json file is configured with a fusing policy. It is found that the nodes are always polled and no fusing occurs The file degraderule.json has the following contents [ { "resource": "GET:http://service-provider/echo/{str}", "count": 1, "grade": 2, "timeWindow": 5, "statIntervalMs": 10000, "minRequestAmount": 3 } ]

I found the result, because, your configuration is wrong. You can refer to Sentinel document to see how to configure slow response. . In your configuration, you grade is 2, it means mode of error count.

At present, I want to control the fusing strategy through the error number. However, I found that the lower version of Sentinel can control the fusing

@ SentinelRestTemplate annotation in RestTemplate is alright.

You can limit the flow in this way. I have already run in the demo. However, what I am simulating now is that the provider has two nodes, one of which returns slowly, and the other returns normally The json file is configured with a fusing policy. It is found that the nodes are always polled and no fusing occurs The file degraderule.json has the following contents [ { "resource": "GET:http://service-provider/echo/{str}", "count": 1, "grade": 2, "timeWindow": 5, "statIntervalMs": 10000, "minRequestAmount": 3 } ]

I found the result, because, your configuration is wrong. You can refer to Sentinel document to see how to configure slow response. . In your configuration, you grade is 2, it means mode of error count.

I tried to introduce Sentinel-core instead of spring-cloud-alibaba, and found that the 1.8.6 slow call ratio of Sentinel-core is not effective. If this version is changed to 1.6.4, it can be effective. Is there any processing done by Sentinel that causes the fuse to fail


QA Reporting form spacing issue

Spacing looks broken here:

Should look like this:
https://www.figma.com/file/aAzKHh4cA6OT2t7WFv2BQ7fB/Reporting-and-Disputing?node-id=198%3A7607

And additional scalar information like this:
https://www.figma.com/file/aAzKHh4cA6OT2t7WFv2BQ7fB/Reporting-and-Disputing?node-id=2324%3A4169

done. closing


Poedit build failure

Hi Vaclav, not really a bug, but I submit as issue anyway.
Poedit doesn't build if casablanca is available, but there is no webview wx package.
(link failure).
Maybe having a check when cpprest is used for wx-webview might avoid troubles to other people facing the same build failure.
In the meanwhile I'm going to upload poedit 1.8 in Debian/experimental with the added build-dependency libwxgtk-webview3.0-dev
thanks!

Poedit’s configure script adds the webview sublibrary if casablanca is enabled to the list of wx sublibraries for WX_CONFIG_CHECK : https://github.com/vslavik/poedit/blob/master/configure.ac#L100
So yes, it is required and Poedit won’t build without it. Not a bug.

mmm thanks, but the question actually was:
"shouldn't in this case the error be thrown by the configure script rather than in the build process?"

but the question actually was:

Perhaps you should have written that from the start… Checking wx availability is WX_CONFIG_CHECK’s responsibility, I don’t think something like this is worth working around in Poedit’s script. If it doesn’t check for actual presence, it should be improved in wx’s wxwin.m4, not in Poedit.

thanks, indeed this is a wxwin.m4 bug.
thanks!

FYI, 1.8.2 (imminent) will no longer require wxWebView, see 48fcff60. It was replaced with a new .desktop file to handle the poedit:// URI scheme from browsers.

wonderful! In the meanwhile I opened a Debian bug with a patch inside.
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=786986
Unfortunately a wxwidgets 3.0 is waiting in the binary-NEW queue (we added the doc package), so every fix should wait a little bit :)
thanks again,
G.