two different behaviours on requirement occurrences

Puccuni 0.18.0 signals no problem on the following template:
tosca_definitions_version: tosca_simple_yaml_1_3
node_types:
  MyNodeType:
    requirements:
      - req:
          capability: tosca:Compute
          # default occurrences is [1, 1]
#          occurrences: [1, 1]
topology_template:
  node_templates:
    node:
      type: MyNodeType
    compute:
      type: tosca:Compute

The req requirement of nodetemplate is fulfilled to the compute node template.
But if one uncomments occurrences: [1, 1] then Puccini signals a problem:
$ puccini-tosca compile previous_template.yaml
PROBLEMS (1)
  file:.........../previous_template.yaml
    @11,5 topology_template.node_templates["node"].requirements: number of requirement "req" assignments is 0, must be >= 1 and <= 1
$

This seems that there are two totally different behaviours depending on the absence or presence of the occurrences keyname.

Yes, this is intentional. Let me try to explain what is going on --
"occurrences" in requirement definitions refers how many assignments you make to that requirement in the node template. When you set it to [ 1, 1 ] it means you must assign it exactly once, which you did not do in this case. Thus it makes no sense to me that the default would be [ 1, 1 ]. Instead, I interpret the default to be [ 1, UNBOUNDED ].
So, would this mean that you would need to assign at least one requirement in the node template. Yes! However, it would clearly be very cumbersome to do this for every node template. Thus, I decided on a quality-of-life improvement here: if "occurrences" is not overridden in any way then Puccini will attempt to assign that minimum single requirement for you. In recent discussions regarding TOSCA 2.0 we agreed that this is a good idea -- in fact, we may state that the TOSCA processor would try to automatically assign all the missing requirements up to the minimum specified. (I thought that would be going too far for now in Puccini.)
In other words, when you specified occurrences as [ 1, 1 ] it means you are making it explicit and thus you must also make those requirement assignments explicit in the node template.
By the way, in capabilities the "occurrences" mean something very different.. According to the TOSCA 1.3 spec the default there is [ 1, UNBOUNDED ], but what does that mean? How do you understand "occurrences"? You can read my interpretation here. Essentially, I understand it to refer to the number of incoming relationships. So a minimum of 1 would mean you should get an error if no relationship comes in. And a maximum of 1 means there should be no more than 1 incoming relationship. Thus I actually interpret the default to be [ 0, UNBOUNDED ], because otherwise there would be errors all over the place.

This issue disappeared with release v0.20.0. Thank @tliron.


Link to the live version is not working

Hello @GOlivierNation, we appreciate how your code is clean and the functionalities are fine, however, we suggest that if it is possible for you. you could fix the link to the live version provided on the read me file, because it is not working as demonstrated in the following screenshot. otherwise, you did a great job.
Cheers.

Thanks @bizip


moveit: 0.7.13-0 in 'indigo/distribution.yaml' [bloom]

Increasing version of package(s) in repository moveit to 0.7.13-0:

upstream repository: https://github.com/ros-planning/moveit.git
release repository: https://github.com/ros-gbp/moveit-release.git
distro file: indigo/distribution.yaml
bloom version: 0.6.1
previous version for package: 0.7.12-0

moveit
* [fix][moveit_ros_planning] Avoid segfault when validating a multidof-only trajectory (#691 <https://github.com/ros-planning/moveit/issues/691>). Fixes #539 <https://github.com/ros-planning/moveit/issues/539>
* [fix][moveit_ros_planning] find and link against tinyxml where needed (#569 <https://github.com/ros-planning/moveit/issues/569>)
* [fix][moveit_ros_visualization] don't crash on empty robot_description in RobotState plugin #688 <https://github.com/ros-planning/moveit/issues/688>
* [fix][moveit_ros_visualization] RobotState rviz previewer: First message from e.g. latching publishers is not applied to robot state correctly (#596 <https://github.com/ros-planning/moveit/issues/596>)
* [fix][moveit_ros_planning_interface] MoveGroupInterface: Fixed computeCartesianPath to use selected end-effector. (#580 <https://github.com/ros-planning/moveit/issues/580>)
* [fix][moveit_ros_move_group] always return true in MoveGroupPlanService callback #674 <https://github.com/ros-planning/moveit/pull/674>
* [fix][moveit_setup_assistant] add moveit_fake_controller_manager to run_depend of moveit_config_pkg_template/package.xml.template (#613 <https://github.com/ros-planning/moveit/issues/613>)
* [fix][moveit_setup_assistant] find and link against tinyxml where needed (#569 <https://github.com/ros-planning/moveit/issues/569>)
* [fix][moveit_kinematics] create_ikfast_moveit_plugin: fixed directory variable for templates that were moved to ikfast_kinematics_plugin #620 <https://github.com/ros-planning/moveit/issues/620>
* [fix][moveit_experimental] remove explicit fcl depends #632 <https://github.com/ros-planning/moveit/pull/632>
* [fix][moveit_core] Add missing logWarn argument (#707 <https://github.com/ros-planning/moveit/issues/707>)
* [fix][moveit_core] IKConstraintSampler: Fixed transform from end-effector to ik chain tip. #582 <https://github.com/ros-planning/moveit/issues/582>
* [fix][moveit_core] robotStateMsgToRobotState: is_diff==true => not empty #589 <https://github.com/ros-planning/moveit/issues/589>
* [fix][moveit_commander] Bugs in moveit_commander/robot.py (#621 <https://github.com/ros-planning/moveit/issues/621>)
* [fix][moveit_commander] pyassimp regression workaround  (#581 <https://github.com/ros-planning/moveit/issues/581>)
* [capability][moveit_ros_planning] Multi DOF Trajectory only providing translation not velocity (#555 <https://github.com/ros-planning/moveit/issues/555>)
* [capability] Multi DOF Trajectory only providing translation not velocity (#555 <https://github.com/ros-planning/moveit/issues/555>)
* [capability] Adds parameter lookup function for kinematics plugins (#701 <https://github.com/ros-planning/moveit/issues/701>)
* [improve][moveit_ros_planning_interface] Disabled copy constructors and added a move constructor to MoveGroupInterface (#664 <https://github.com/ros-planning/moveit/issues/664>)
* [improve][moveit_ros_perception] removed deprecated pluginlib macro (#677 <https://github.com/ros-planning/moveit/issues/677>)
* [improve][moveit_ros_move_group] adding swp's to gitignore and removing redundant capabilites from capability_names.h (#704 <https://github.com/ros-planning/moveit/issues/704>)
* [improve][moveit_kinematics] IKFastTemplate: Expand solutions to full joint range in searchPositionIK #598 <https://github.com/ros-planning/moveit/issues/598>
* [improve][moveit_kinematics] IKFastTemplate: searchPositionIK now returns collision-free solution which is nearest to seed state. (#585 <https://github.com/ros-planning/moveit/issues/585>)
* [improve][moveit_core] Make operator bool() explicit #696 <https://github.com/ros-planning/moveit/pull/696>
* [improve][moveit_core] Get msgs from Planning Scene #663 <https://github.com/ros-planning/moveit/issues/663>
* [improve][moveit_core] moveit_core: export DEPENDS on LIBFCL `#632 https://github.com/ros-planning/moveit/pull/632>`_
* [improve][moveit_core] RobotState: Changed multi-waypoint version of computeCartesianPath to test joint space jumps after all waypoints are generated. (#576 <https://github.com/ros-planning/moveit/issues/576>)
* [improve][moveit_core] Better debug output for IK tip frames (#603 <https://github.com/ros-planning/moveit/issues/603>)
* [improve][moveit_core] New debug console colors YELLOW PURPLE (#604 <https://github.com/ros-planning/moveit/issues/604>)
* [doc][moveit_ros_visualization] Document auto scale in Rviz plugin (#602 <https://github.com/ros-planning/moveit/issues/602>)
* Contributors: axelschroth, 2scholz, Bence Magyar, Bruno Brito, Dave Coleman, Dennis Hartmann, fsuarez6, G.A. vd. Hoorn, Henning Kayser, Isaac I.Y. Saito, Jonathan Meyer, Jorge Nicho, Kei Okada, Konstantin Selyunin, Michael Goerner, Mikael Arguedas, Mike Lautman, Phil, Shingo Kitagawa, Simon Schmeisser, Simon Schmeisser, Sarah Elliott, Shingo Kitagawa, Troy Cordie, William Woodall

moveit_commander
* [fix] Bugs in moveit_commander/robot.py (#621 <https://github.com/ros-planning/moveit/issues/621>)
* [fix] pyassimp regression workaround  (#581 <https://github.com/ros-planning/moveit/issues/581>)
* Contributors: Kei Okada, Konstantin Selyunin

moveit_controller_manager_example

No changes

moveit_core
* [fix] Add missing logWarn argument (#707 <https://github.com/ros-planning/moveit/issues/707>)
* [fix] IKConstraintSampler: Fixed transform from end-effector to ik chain tip. #582 <https://github.com/ros-planning/moveit/issues/582>
* [fix] robotStateMsgToRobotState: is_diff==true => not empty #589 <https://github.com/ros-planning/moveit/issues/589>
* [capability] Multi DOF Trajectory only providing translation not velocity (#555 <https://github.com/ros-planning/moveit/issues/555>)
* [capability] Adds parameter lookup function for kinematics plugins (#701 <https://github.com/ros-planning/moveit/issues/701>)
* [improve] Make operator bool() explicit #696 <https://github.com/ros-planning/moveit/pull/696>
* [improve] Get msgs from Planning Scene #663 <https://github.com/ros-planning/moveit/issues/663>
* [improve] moveit_core: export DEPENDS on LIBFCL `#632 https://github.com/ros-planning/moveit/pull/632>`_
* [improve] RobotState: Changed multi-waypoint version of computeCartesianPath to test joint space jumps after all waypoints are generated. (#576 <https://github.com/ros-planning/moveit/issues/576>)
* [improve] Better debug output for IK tip frames (#603 <https://github.com/ros-planning/moveit/issues/603>)
* [improve] New debug console colors YELLOW PURPLE (#604 <https://github.com/ros-planning/moveit/issues/604>)
* Contributors: Dave Coleman, Dennis Hartmann, Henning Kayser, Isaac I.Y. Saito, Jorge Nicho, Michael Görner, Phil, Sarah Elliott, Simon Schmeisser, TroyCordie, v4hn

moveit_fake_controller_manager

No changes

moveit_kinematics
* [fix] create_ikfast_moveit_plugin: fixed directory variable for templates that were moved to ikfast_kinematics_plugin #620 <https://github.com/ros-planning/moveit/issues/620>
* [improve] IKFastTemplate: Expand solutions to full joint range in searchPositionIK #598 <https://github.com/ros-planning/moveit/issues/598>
* [improve] IKFastTemplate: searchPositionIK now returns collision-free solution which is nearest to seed state. (#585 <https://github.com/ros-planning/moveit/issues/585>)
* Contributors: Dennis Hartmann, G.A. vd. Hoorn, Michael Görner, fsuarez6

moveit_planners

No changes

moveit_planners_ompl

No changes

moveit_plugins

No changes

moveit_ros

No changes

moveit_ros_benchmarks

No changes

moveit_ros_control_interface

No changes

moveit_ros_manipulation

No changes

moveit_ros_move_group
* [fix] always return true in MoveGroupPlanService callback #674 <https://github.com/ros-planning/moveit/pull/674>
* [improve] adding swp's to gitignore and removing redundant capabilites from capability_names.h (#704 <https://github.com/ros-planning/moveit/issues/704>)
* Contributors: Mike Lautman, Shingo Kitagawa

moveit_ros_perception
* [improve] removed deprecated pluginlib macro (#677 <https://github.com/ros-planning/moveit/issues/677>)
* Contributors: Mikael Arguedas

moveit_ros_planning
* [fix] Avoid segfault when validating a multidof-only trajectory (#691 <https://github.com/ros-planning/moveit/issues/691>). Fixes #539 <https://github.com/ros-planning/moveit/issues/539>
* [fix] find and link against tinyxml where needed (#569 <https://github.com/ros-planning/moveit/issues/569>)
* [capability] Multi DOF Trajectory only providing translation not velocity (#555 <https://github.com/ros-planning/moveit/issues/555>)
* Contributors: Isaac I.Y. Saito, Michael Görner, Mikael Arguedas, Troy Cordie

moveit_ros_planning_interface
* [fix] MoveGroupInterface: Fixed computeCartesianPath to use selected end-effector. (#580 <https://github.com/ros-planning/moveit/issues/580>)
* [improve] Disabled copy constructors and added a move constructor to MoveGroupInterface (#664 <https://github.com/ros-planning/moveit/issues/664>)
* Contributors: 2scholz, Dennis Hartmann, Jonathan Meyer, Simon Schmeisser

moveit_ros_robot_interaction

No changes

moveit_ros_visualization
* [fix] don't crash on empty robot_description in RobotState plugin #688 <https://github.com/ros-planning/moveit/issues/688>
* [fix] RobotState rviz previewer: First message from e.g. latching publishers is not applied to robot state correctly (#596 <https://github.com/ros-planning/moveit/issues/596>)
* [doc] Document auto scale in Rviz plugin (#602 <https://github.com/ros-planning/moveit/issues/602>)
* Contributors: Dave Coleman, Isaac I.Y. Saito, Simon Schmeisser, axelschroth

moveit_ros_warehouse

No changes

moveit_runtime

No changes

moveit_setup_assistant
* [fix] add moveit_fake_controller_manager to run_depend of moveit_config_pkg_template/package.xml.template (#613 <https://github.com/ros-planning/moveit/issues/613>)
* [fix] find and link against tinyxml where needed (#569 <https://github.com/ros-planning/moveit/issues/569>)
* Contributors: Kei Okada, Michael Görner, Mikael Arguedas, William Woodall

moveit_simple_controller_manager
* [capability][kinetic onward] optionally wait for controllers indefinitely (#695 <https://github.com/ros-planning/moveit/issues/695>)
* Contributors: Bruno Brito, Michael Görner

Please hold a review for this for now.

Now, please review.


added a note about a known issue for Unity

The change of useGlobalMono fixes .NET Core scenarios, but breaks Unity scenario ☹

Passing CI - https://travis-ci.org/github/OmniSharp/omnisharp-vscode/builds/719868859


Status 400 when attempting to query by array value

Bug report
Describe the bug
Status 400 when attempting to query by array value
For example:

Making a query for all works.

.from("posts").select(columns: "*").execute().value

But making a query by array value gives a unacceptableStatusCode(400)

.from("posts").select(columns: "*").contains(column: "members", value: userid).execute().value
To Reproduce
Crate a table, RLS policy and query by array value

Table name: posts
Table column name: "members"
Column array: [userid1, userid2, userid3]

Expected behavior
Should either return an empty array or results
System information
OS: macOS Ventura 13.3
Version of supabase-ios: 0.2.1

I saw your post on Stack Overflow, and noticed the same error occurs when using .overlaps() instead of .contains(). Thanks for creating an issue - hopefully it's resolved soon.
For example:
.from("posts")
.select()
.overlaps(column: "column", value: "value")
.execute().value

Hey @luisw90 I've added this case on the integration tests of postgrest-swift library, and I was able to make it work.
The value parameter has to be an Array as the underlying Postgres type is an array.
Please check this PR https://github.com/supabase-community/postgrest-swift/pull/45, if you still have an issue let me know.


Running go test with -race flag takes a lot of cpu time and memory.

On mine Linux desktop - it eats more than 8gb of memory (essentially disabling my machine). The culprit is TestGoFuzzCrashers.

See https://github.com/streadway/amqp/pull/197 for an explanation. Unfortunately merging the proposed changes break CI in ways that I cannot reproduce anywhere else.


ID fields of converted Avro records are not expected to be fully qualified URLs.

Please fill out the below template as best you can.
Description of Issue
I am not sure if this is WAI or a bug.
I am using Bunsen for converting HAPI FHIR objects to Avro GenericRecords using resourceToAvro. The id field of the converted records have the full URL of the original server from which the resources are fetched. It seems to me that according to the FHIR documentation this is not correct (e.g., invalid characters). In my particular use case, I am only interested in the logical ID (getIdPart()) of the resource IDs.
After some debugging, it seems that the issue is here which eventually ends up calling getValue() which calls IdType.getValue(). I wonder if there is any way to have the IdType.getIdPart() of an ID element in the converted record instead?
System Configuration
Project Version
0.5.7
Additional Details (optional)
Steps to Reproduce the Issue

Create a FHIR resource objects.
Call resourceToAvro on that.

Expected Outcomes
I was expecting to only get the logical ID in the id fields of generated records, not the fully qualified URLs.

A fix for this issue can be found here.


Add src/setupTests.js to specify environment setup for Jest (#545)

Fix #545
Test plan
Run npm run create-react-app my-app and in the generated App.js, add something like localStorage.getItem('test');. Run npm test, it should fail because localStorage is undefined. Add a setupTests.js in src that looks like this:
const localStorageMock = {
  getItem: jest.fn(),
  setItem: jest.fn(),
  clear: jest.fn()
};
global.localStorage = localStorageMock

Then run npm test again (you need to re-run the command in order to have the setupTests.js added to Jest config) and it should pass.
You can also simply add a setupTests.js that does a console.log('Hello world') to check it's properly executed before the tests.

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at<EMAIL_ADDRESS>Thanks!

Can you please specify the test plan?
See https://github.com/facebookincubator/create-react-app/blob/master/CONTRIBUTING.md#submitting-a-pull-request:

Please also provide a test plan, i.e. specify how you verified that your addition works.

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Test plan added to the initial PR description

Removed the sample 'setupTests.js' and added docs to the README.md

Sorry for the trouble but I just merged another set of changes that made this conflict.
Could you please rebase?

Fixed doc title and conflicts ✅

Awesome. Thank you.

Out in 0.4.0.
See the release notes!


custom_profile_fields: Make name, required, hint, field_data optional during update

Fixes: #23022
This PR makes the following 4 fields optional i.e. you could not pass them if they are unchanged for the patch request.

Name
Hint
field_data
required

I have not made any changes on the frontend code which handles the API requests to not pass these fields if they are unchanged. IMO they should be tackled in a separate issue once this gets merged, so its not too many changes to review at one.
NOTE: As for the documentation, I have not added anything since I could find a relevant entry in rest-endpoints.md. Since this is an existing endpoint, is that intentional? If not intentional, do we track it in another issue or fix it in this one? IMO another issue will be better for ease of review.
Screenshots and screen captures:
No UI changes

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:
Not a UI change

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

@sahil839 Are you up for reviewing this one?

This is ready for another review :) !

Looks good to me. We can update the webapp code to only pass the updated field as a follow-up.

So I noticed this is an API change -- we need to document it as such. git log api_docs/changelog.md for many examples of how to do this correctly. We also usually discuss those in the "api design" stream, but I think this one already has been? I didn't double-check the issue for a link.

So I noticed this is an API change -- we need to document it as such.

Made the changes here, I followed the pattern from here since the documentation for this endpoint does not exist, it's categorised as one of the low value to document endpoints here.

We also usually discuss those in the "api design" stream, but I think this one already has been? I didn't double-check the issue for a link.

I mistakenly assumed that it was already discussed since the issue was opened, should I open a topic right now to discuss making these fields optional?

That sounds correct; https://github.com/zulip/zulip/issues/24993 tracks documenting the feature.

This looks great; my only remark is that it might have been easier to review if you just less the parameter reordering to a single commit at the end, rather than having each commit move a parameter to a different list.
Probably there's some further refactor that would be very nice that involves moving these parameters to the new Pydantic-based typed_endpoint system, but I think that'll naturally happen as part of that migration, and critically, won't require API changes.
Renumbered the API migration and merged, thanks @shubham-padia!
I think the main follow-up that we should remember is to look at making the web app not send the now-unnecessary extra parameters?

Opened follow up issue at #29750


Ability to Commit Back to Git from Bolt

When importing a git repo into bolt then making changes in bolt and opening in Stackblitz, Stackblitz should be able to recognise that this is an imported git repo and allow the user to commit and not show "Create Git Repo" This is bad because the only way to save my changes is to create another repo suffixed by "v2" etc.

This would be fantastic. Pushing directly to Git from Bolt is ideal.

Would really be a huge update if this feature was implemented. I'm finding it can only create new repos each time and won't update the existing repo or connected to which really defeats the purpose of the repo

Yeah this is a much needed feature for developing with Bolt

+1 here. in bolt, it would be nice if there were a [Commit] button you could push, when things look right -- bolt could fill in a nice commit msg too -- for committing changes to local repo with 1-click.

Agreed. I think Glitch implemented this well. As I recall, they exposed the git binary in their terminal. A Glitch instances could be a remote. it could also push to other remotes. It played well various local / remote dev workflows.


Last plugin pod is still embedded in an iOS app even after it is removed from the pubspec

I found a problem with release build for iOS. The app is built, but it crashes on launch.
[VERBOSE-3:dart_init.cc(560)] Error while initializing the Dart VM: JIT runtime cannot run a precompiled snapshot

iOS debug, Android debug/release work well.
This issue is on master and alpha channels.
New project (flutter create ...) runs without crashes.
Steps to Reproduce
flutter run --release -v
https://gist.github.com/mogol/1702b19068d949f44bdb54f693351b23
Logs
Run your application with flutter run and attach all the log output.
flutter run

Launching lib/main.dart on iPhone 7 GS in debug mode...
Automatically signing iOS for device deployment using specified development team in Xcode project: PWSQ8TH82A
Running Xcode build...                               16.4s
You've implemented -[<UIApplicationDelegate> application:didReceiveRemoteNotification:fetchCompletionHandler:], but you still need to add "remote-notification" to the list of your supported UIBackgroundModes in your Info.plist.
Syncing files to device iPhone 7 GS...                2.8s

🔥  To hot reload your app on the fly, press "r". To restart the app entirely, press "R".
An Observatory debugger and profiler on iPhone 7 GS is available at: http://<IP_ADDRESS>:8102/
For a more detailed help message, press "h". To quit, press "q".

Run flutter analyze and attach any output of that command also.
flutter analyze
Analyzing /Users/herman/Projects/fitness/mobileapp...
  lint • Type annotate public APIs at lib/calendar/calendar.dart:45:20 • type_annotate_public_apis
  lint • Type annotate public APIs at lib/main.dart:99:20 • type_annotate_public_apis
  lint • Avoid annotating with dynamic when not required at lib/redux/state.g.dart:46:20 • avoid_annotating_with_dynamic
  lint • Sort constructor declarations before method declarations at lib/redux/state.g.dart:105:3 • sort_constructors_first
  lint • Avoid returning this from methods just to enable a fluent interface at lib/redux/state.g.dart:107:23 • avoid_returning_this
  lint • Avoid using `as` at lib/redux/state.g.dart:122:11 • avoid_as
6 issues found.
(Ran in 11.1s)

Flutter Doctor
flutter doctor

[✓] Flutter (on Mac OS X 10.12.6 16G29, locale en-RU, channel master)
    • Flutter at /Users/herman/Projects/github/flutter
    • Framework revision f1a23e263c (3 hours ago), 2017-08-29 14:58:31 +0200
    • Engine revision e5395796cd
    • Tools Dart version 1.25.0-dev.11.0

[✓] Android toolchain - develop for Android devices (Android SDK 26.0.0)
    • Android SDK at /Users/herman/Library/Android/sdk
    • Platform android-26, build-tools 26.0.0
    • ANDROID_HOME = /Users/herman/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_112-release-b06)

[✓] iOS toolchain - develop for iOS devices (Xcode 8.3.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 8.3.3, Build version 8E3004b
    • ios-deploy 1.9.1
    • CocoaPods version 1.2.1

[✓] Android Studio (version 2.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Java version OpenJDK Runtime Environment (build 1.8.0_112-release-b06)

[✓] IntelliJ IDEA Ultimate Edition (version 2017.2.2)
    • Flutter plugin version 16.0
    • Dart plugin version 172.3757.55

[✓] Connected devices
    • None

I'm not able to reproduce this crasher. Do you remember what commands you'd issued prior to the flutter run --release that failed?
Also, can you give the following steps a go and report whether the issue persists?
$ flutter upgrade
$ flutter build clean
$ flutter run --release

I marked this TODAY because if it's a problem that affects many people, then this should block alpha. But if we cannot reproduce it then we can remove the label.

@cbracken steps didn't help me

Do you remember what commands you'd issued prior to the flutter run --release that failed?
It looks like some issues with flutter & cocoa pods . I hope I found commit where it started. I deleted dependencies from  pubspec.yaml, but it didn't update Podfile.lock.

How is it possible to force "pod install" command with right enviroment?

I fixed  the issue by adding dummy dependency, it makes run pod install and then no crash 🎉
Main problem -  Podfile.lock is not updated after removing dependencies from pubspec.yaml that depends on another pods.
In my case, seems I hack it manually somehow: it fixed debug, but breaks release configuration.

If a project doesn't have flutter plugins, it hasn't Podfile and Podfile.lock. So no issues with new projects.
If a project has flutter plugins, pod install will be invoked , no issues.
But my case:
If a project had flutter plugins before, then it were removed, as a result pod install wouldn't be invoked. But it has already Podfile and Podfile.lock. There is a reference  in Podfile.lock
  Flutter:
    :path: "/Users/herman/Projects/github/flutter/bin/cache/artifacts/engine/ios-release"

or in debug
  Flutter:
    :path: "/Users/herman/Projects/github/flutter/bin/cache/artifacts/engine/ios"

And it doesn't update the reference for flutter run --debug or flutter run --release. And wrong config crashes app.

As workaround, I deleted Podfile/Podfile.lock and did pod deintegrate.
As a solution, what's about running cocoaPods.processPods if Podfile exists, not flutter plugins?

@mogol thanks for the update and details.
/cc @xster who's done a bunch of cocoapods work in flutter_tools for thoughts on the best approach to fixing this.
I've removed the TODAY label since this has been around for months and should be relatively rare, but we should definitely fix this.

Since this is rare, it doesn't fit our criteria for our near-term priorities.
@cbracken Can we actually repro this? It wasn't clear from the comments above.

@Hixie yes, it was reproducible but I was only able to repro with a hand-edited Podfile pointed at the debug engine bundle, then attempting to run in release mode.
@xster is probably the person most familiar with the Podfile management bits of flutter_tools and might have ideas how a Podfile could end up in the incorrect state.

@mogol, your description https://github.com/flutter/flutter/issues/11819#issuecomment-325874061 is representative.
If I understood correctly, there may be 2 things we might want to do.

If you removed the last plugin but still have manually specified pods (e.g. you edited the Podfile), we would still stop automatically running pod install but we should show a warning to the user reminder the user to manually run pod install to make sure it's updated.
If you removed the last plugin and have no manually specified pods (e.g. the Podfile still matches exactly the original template), then we should run pod deintegrate and the user doesn't have to worry about it anymore.

Did I summarize correctly?

@xster, looks good

I had to remove the package from project.pbxproj

I had to remove the package from project.pbxproj

Better to let pod remove it.
$ cd ios
$ pod deintegrate

I had to remove the package from project.pbxproj

Better to let pod remove it.
$ cd ios
$ pod deintegrate

I tried it multiple times, didn't work.

I had to remove the package from project.pbxproj

Better to let pod remove it.
$ cd ios
$ pod deintegrate

I tried it multiple times, didn't work.

same here getting  ld: framework not found error disappear after manually removing in project.pbxproj

Same problem here

cc @loic-sharma can you confirm this isn't an issue with Swift Package Manager https://github.com/flutter/flutter/issues/33850?  Meaning, the code that would remove the last plugin from the Package.swift  is actually called when there the last native plugin dependency is removed from the pubspec?

@jmagman I verified this works as expected when using Swift Package Manager. I also sent a pull request that adds a test for this scenario in Swift Package Manager: https://github.com/flutter/flutter/pull/153519


chore: bdd-spring-1582000605 to 0.0.1

chore: Promote bdd-spring-1582000605 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Fixes docs typo

Hey! Was browsing your docs when I noticed a typo, so thought I'd push up a quick patch.

I've merged this commit and updated the website (which is auto generated from the docs)


[Enhancement] partition name of partitions should be same

Search before asking

[X] I had searched in the issues and found no similar issues.

Description
https://github.com/apache/doris/discussions/32183
Solution
No response
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

i will try

maybe we should close this issue since changes on this may cause much instability


Incompatible with Symfony 4.3

As of Symfony 4.3, the signature of the EventDispatcher has changed: https://symfony.com/blog/new-in-symfony-4-3-simpler-event-dispatching
This causes an error of type E_USER_DEPRECATED to be triggered: bundle:
Calling the "Symfony\Component\EventDispatcher\EventDispatcherInterface::dispatch()" method with the event name as the first argument is deprecated since Symfony 4.3, pass it as the second argument and provide the event object as the first argument instead. in /app/vendor/symfony/event-dispatcher/EventDispatcher.php:58

also see:
https://github.com/symfony/event-dispatcher/blob/v4.3.3/EventDispatcher.php#L58
Maybe we can prevent this error by restricting the version of the used Symfony Event-Dispatcher in composer.json to "symfony/event-dispatcher": "^3.0 || <4.3":
`

Well, this is just a deprecation warning, so I don't there is anything we have to do. If you are concerned about this error, just don't install 4.3. :)

Like @sagikazarmark already said this is indeed a warning and shouldn't be a problem until symfony 5.0. But we can already fix our code to not trigger this deprecation on version of symfony that support the new way of dispatching events.
If you want @holtkamp you can open a PR to provide a backwards compatible fix for this deprecation, otherwise this will be fixed in the future when I have some time!

AFAIK the Symfony version is stored in Symfony\Component\HttpKernel\Kernel::VERSION_ID which is not used in Bernard, so we can not compare versions easily.
However, as of 4.3 Symfony\Component\EventDispatcher\EventDispatcherInterface extends the Symfony\Contracts\EventDispatcher\EventDispatcherInterface.
Essentially the dispatch() method has changed from:
Symfony\Component\EventDispatcher\EventDispatcherInterface::dispatch($eventName, Event $event = null)
to
Symfony\Contracts\EventDispatcher\EventDispatcherInterface::dispatch($event/*, string $eventName = null*/)
@acrobat what do you think of the following approach to detect this new Interface to determine what to do?
class Producer
{
    /* ... properties and constructor can remain unchanged ...*/

    public function produce(Message $message, $queueName = null)
    {
        $queueName = $queueName ?: Util::guessQueue($message);
        $queue = $this->queues->create($queueName);
        $queue->enqueue($envelope = new Envelope($message));
        $this->dispatch(BernardEvents::PRODUCE, new EnvelopeEvent($envelope, $queue));
    }

    private function dispatch($eventName, EnvelopeEvent $event)
    {
        $this->dispatcher instanceof \Symfony\Contracts\EventDispatcher\EventDispatcherInterface)
           ? $this->dispatcher->dispatch($event, $eventName)
           : $this->dispatcher->dispatch($eventName, $event);
    }
}

Fixed in https://github.com/bernardphp/bernard/pull/406


trainer.evaluate() without trainer.fit()

Describe the bug
I'd like to only evaluate fitted model with Trainer instance by calling its evaluate method
To Reproduce
Steps to reproduce the behavior:
model = MyLightningModule()
trainer = Trainer()
trainer.evaluate(model, model.val_dataloader(), max_batches=100)

Gets TypeError: 'NoneType' object is not callable when it tries to call trainer.get_val_dataloaders which is does not have, because fit wasn't called before
Expected behavior
Passing the model and dataloader into evaluate should be enough to evaluate model's performance.

Perhaps evaluate is not meant to be used like that. Maybe use test instead.
Define the test methods and then call trainer.test(): see here and here
You can then limit the size of your dataset inside the test_dataloader method.
Or do I misundestand?

Evaluate should really be a private method. not meant to be used externally

Got it, thanks!

Can I get metrics named 'val_*' without training?
Trainer.test(test_dataloaders...) will produce metrics called test_ with my current code. The easiest way I can think of is to make an empty train dataset?


add an extensive example file to the repo

I have seen this in a lot of sublime language definition projects.
A large file with a collection of valid and invalid codes, in order to see what is working and what not.
In the SublimeText/PowerShell, for example, tis file is only available in the "dev" branch

I feel this would be superflous to a SublimeText package. The most important thing - is it working with YOUR script. There are lots of example files of AutoHotkey available on the net. Closing since the purpose of this Github is everyone to test this package on there script and report back there findings.


New Job page

Adds a New Job page which allows a user to queue a job by specifying a queue name and JSON payload.

In this implementation Create on the New Job page causes a page refresh which then stops the count refresh from working correctly in the nav bar. I have rewritten using jQuery ajax and will raise another pull request after a little more testing.


Can't use current_admin in visible block

On Rails 3.1, Ruby 1.9.2, with this config (snip):
config.model Shop do
  list do
    field :name do
      visible { current_admin.name == 'John Doe' }
    end
  end
end

When I try to view the list page, it says:
undefined local variable or method 'current_admin' for #<RailsAdmin::Config::Fields::Types::BelongsToAssociation:0x00000004d312c0>
I have a model called Admin, and Devise is setup to use it. Everything else works properly.

Same here

I also needed access to the current user.  I did a debug and looked at trace, this works:
Would be nice for documentation somewhere I guess.
bindings[:view]._current_user

It's been fixed meanwhile.

Even in rails-3.0 branch?


Feature: Defining Equals (and local deletion of QuerySet)

Hi Miles,
so I noticed a while back that if I want to compare two Objects I get False no matter what I do, unless I directly compare their objectId's for example.
So I wanted to implement this myself using
def __hash__(self):
      return hash(self.obj)

  def __eq__(self,other):
      pdb.set_trace()
      print('__eq__()')
      return self.objectId == other.objectId

And I added this code to query.Queryset as I am working with Querysets.
(BTW pdb is there just so I can see what's going on but the code never gets triggered)
So then I would expect that if I do
queryset[0] == samequeryset[0]

That it would return True. But it still keeps returning False.
As I am guessing I am not understanding something here, I also added the code to ParseType and QueryManager.
To no appeal.
Do you know which object would be a proper place to put this code in?
I was also implementing a (local)delete function for Queryset [ something like list.remove(x) ]as well as that's something I needed badly.
And I got something now so I was wondering if you'd be interested in me submitting this (and adding it to the , I am guessing , Queryset Class.
I already tried using delitem method with no success again so I just implemented a public function for myself.
I would love to contribute so let me know what you think/potential feedback.

@SovcikJoe
I'm not sure why your __eq__ is not working, however I have not looked into it much.
But I would be VERY hesitant to add this functionality. Since Python is a pass-by-reference language, overriding == to compare attributes of the objects, instead of the address of the python objects, violates expectations based on Python defaults. While this might be okay in a new library (if well documented), it could break existing code.
What if you have two copies of the same Parse object (i.e., the same objectId), but you modify a property of one of them, but not the other? In that case would you want them to be "equal"?
Because the notion of "equality" in Python can get very thorny depending on what you want to do, it can introduce a lot of unforeseen bugs. For that reason, I'm not interested in a pull request implementing this functionality. The cost does not seem worth the small benefit.
However, if you're interested in implementing it in your own fork, these links might be helpful:
http://stackoverflow.com/questions/3076967/python-is-this-an-ok-way-of-overriding-eq-and-hash
http://stackoverflow.com/questions/390250/elegant-ways-to-support-equivalence-equality-in-python-classes
Miles


Integrate delta debugging

Add functionality in test_fn to specify that set of rules do not rewrite term A to term B. Additionally, use the delta debugging crate to discover a minimal set of rules that do rewrite A to B to make debugging easier.
One thought: this should either not be turned on by default OR only run once per run of a test suite. This can take a while to run, especially on large rule sets. A single unsoundness may trigger many tests to fail, but the result of rerunning DD will usually not give much more information. I still think it would be good to complete running the entire test suite, but maybe having a DD_HAS_RUN flag somewhere and checking it before running.

For disequality testing, I use this as a workaround:
egg::test_fn! {
    #[should_panic]
    fail, rules(), "(+ 0 (* (+ 4 -3) foo))" => "123",
}

It assumes test_fn is complete, but is helpful during development.


Unable to resolve SPM dependency in Xcode

All of a sudden Xcode is not able to resolve JGProgressHUD as an SPM dependency. Did something recently change that may have caused this?

Seems to be back up 🤷

Yes, I accidentally deleted a tag. Sorry!

No problem. Was just wondering 😊


Install packages with Poetry and pyproject.toml

Hei, could you please add to the readme how to use the package to add private packages to poetry evironment via pyproject.toml [[tool.poetry.source]] ).
Given that there is no username/password or explicit certificates, this is not obvious thanks!

The reason I am asking is because I could not make it work, would you like to have my steps?

The last couple of days I have been leaving a paper trail on issues I looked at while trying to make things work.
Besides installing artifacts-keyring you might want to install azure-devops-artifacts-helpers which provides a virtualenv seeder called azdo-pip that installs artifacts-keyring into new virtual environments. You can configure virtualenv to use that seeder via the config file or setting the VIRTUALENV_SEEDER environment value to azdo-pip.
Poetry does not currently use keyring the same way that pip and pipenv do: python-poetry/poetry#4086.
Hopefully someone finds this helpfull.

Hei, I did not see the link to the specific issue in the 'Developer Community', please share

https://developercommunity.visualstudio.com/t/Artifact-Feed--Connect-to-feed--Pip-/1429453


Need a way to check under which topic(s) a service belongs

We received an email from go2hr. Their services are listed in the March 2019 bc211 dataset. However, I couldn't find any of their services under any of the following Education topics or any of the Employment topics on the app:

Continuing Education for Adults
Post-secondary education
Training and certifications to upgrade your qualifications

**Possible solution:**Need a way to check the similarity score of a service corresponding to every topic.
AC:

Need a way to look up a service using swagger and see its relation to topics (and perhaps locations)to understand why it shows up under a certain a topic related service search.

Another example, Big Sisters of BC Lower Mainland emailed us to discuss potential partnership re: their Study Buddy program. The service is listed on bc211 March 2019 dataset (service ID 9487553), but I couldn't find it in any of the following category:

Help for young people
Help for families

The Big Sisters of BC Lower Mainland may not appear on AA search results at all. Do we know which services that are listed on bc211 dataset that don't appear on our app at all?

AC: WE have a REST end point that can answer this question. TODO move this issue to the backend repo.


Windows defender blocking the app.

Trying to use the software amonguscapture, triggers microsoft defender. So I can't run it.

You just need to click more info or whatever then on run anyways.


drivers: phy: new phy api function for reading mac address

Many chips, like Davicom DM8806, or Microchip KSZ9897 are equiped with more than one MAC and PHY units. This give them ability to controll the Ethernet Switch device with four or more connected devices (stations). In such situation it seams to be reasonable to have the API function which will returns MAC addresses of connected devices.

and why do you need the mac address anyways?

I need the MAC addresses of the devices (PC's or other Ethernet devices) which are connected to the switch controller (for example Davicom DM8806) for further processing in the application level, collecting connected Ethernet devices, visualization etc. So the consumer will be the application - maybe visualization system, maybe management system...

and when you say "get the mac address of the connected device" what does that mean? which device do you mean?

Only one device can be connected to one MAC PHY. I need the address of this concrete device. If switch chip controller has more MAC PHY unit inside (like Davicom DM8806 or KS9897), then I would like to get all addresses of the connected devices - each device connected to one MAC PHY built-in in the switch controller. The number of the built-in MAC PHY I will pass through the parameter called port to inform the driver, which MAC PHY number I would like to read the address of the device from.

and why do you need the mac address anyways?

I need the MAC addresses of the devices (PC's or other Ethernet devices) which are connected to the switch controller (for example Davicom DM8806) for further processing in the application level, collecting connected Ethernet devices, visualization etc. So the consumer will be the application - maybe visualization system, maybe management system...

and when you say "get the mac address of the connected device" what does that mean? which device do you mean?

Only one device can be connected to one MAC PHY. I need the address of this concrete device. If switch chip controller has more MAC PHY unit inside (like Davicom DM8806 or KS9897), then I would like to get all addresses of the connected devices - each device connected to one MAC PHY built-in in the switch controller. The number of the built-in MAC PHY I will pass through the parameter called port to inform the driver, which MAC PHY number I would like to read the address of the device from.

Only one device can be connected to one MAC PHY. I need the address of this concrete device. If switch chip controller has more MAC PHY unit inside (like Davicom DM8806 or KS9897), then I would like to get all addresses of the connected devices - each device connected to one MAC PHY built-in in the switch controller. The number of the built-in MAC PHY I will pass through the parameter called port to inform the driver, which MAC PHY number I would like to read the address of the device from.

What I meant was, I was confused if you were needing the address of the mac using the phy or the link partner

Anyway - it look's that that dsa driver will fit better fir this

that's good


Why does the Splash reappear when back is pressed?

Ideally, the splash screen shouldn't appear when the back button is pressed from the MainActivity. Is this a bug in the API?

use onBackPressed


Include + using file syntax

This seems like it will be a normal occurrence:
namespace AnythingButItHasToBeUnique
    include 'somefile.sink'
end
using AnythingButItHasToBeUnique

The idea here is that 'somefile.sink' might include definitions that were already included.  By putting it in its own namespace, the second include will still work.  However, we want access to the new definitions inside of 'somefile.sink' without having to type the wrapping namespace (that was only there to allow the multiple includes).
Currently we have:
include foo 'foo.sink'

To be short for:
namespace foo
    include 'foo.sink'
end

I think the next step is to allow something like:
include . 'foo.sink'

To be short for:
namespace SomeUniqueNamespaceThatCanNeverHaveCollisions
    include 'foo.sink'
end
using SomeUniqueNamespaceThatCanNeverHaveCollisions

Where the unique namespace isn't even addressable in any way.

done


:arrow_up<EMAIL_ADDRESS>for iojs support

https://github.com/iojs/io.js/issues/456

+1

+1

Maybe @michael-grunder or @pietern could help

@antirez ping ;)

I'll take care of it the next week

Thanks!


Security concerns when using containers apps for a SAAS offering

The intention is to launch a saas product where end-users can easily run containers on the fly.  We would like to use containers apps for this.
I am looking for some guidance in order to have a secure offering.
Which kind of issues are present when the containers are provisioned in the same Azure Container Environment?

When ingress is turned off, can apps use network communication to reach other apps in the same environment
Can end-users eardrop on other containers?  Like traffic, container image...

What kind of measures can be taken to co-host multiple customers in one enviroment?
Or is it better to provision each customer in a separate container enviroment?
Thanks for the insights!

ACA runs on Kubernetes, so most of the same security considerations apply here. Each Container App is a Kubernetes pod, and each Environment is basically an isolated node running the pods. While ACA does provide basic ingress security options per each App, some of which are still broken (hello IP whitelists on TCP apps!), the basic Kubernetes premise is to facilitate communication between pods, so I would definitely provision a separate Environment for each customer.

Having each customer in a separate environment would indeed be the most ideal situation.  However, the problem is that there is a limit to 15 env/subscription/region.  For a saas tool this is a very low limit.  Having to maintain multiple subscriptions/regions would be an administrative burden...
The containers are indeed untrusted, so I am looking into ways to minimize the security impact while still be able to host them in one environment.  Customers who seek more isolation can pay more for a dedicated environment.
When apps have ingress disabled or when customer containers are deployed as a sidecar to a reverse-proxy (controlling communication/auth), what would be other concerns, typical related to running them as pods in one environment.
Would it be possible for low-level hardware access (memory, disk, internal network, ...) by untrusted containers?
I see there is a preview for isolated pods on AKS, using KATA.  Would this also be possible to integrate in ACA?

Containers can't run as priviledged, so their low level access is very limited. However, in terms of functionality, take into account that:

Each environment has the same IP address for all its apps
Different apps in the same environment can't have ingress on the same port, because of the point above, except for:
HTTP apps (which) must all use port 80 and 443 for ingress, and all run behind the same built-in Envoy Proxy which is pretty much not configurable, apart from custom domains and very basic security features.

As for KATA, the ACA team hasn't announced anything AFAIK, which means it's not going to be supported at least for the near future.

You should be able to request quota for more than 15 environments now. Also, we've also just launched dynamic sessions which might fit your needs too.


Add results out of a search

First set of results, very plain, just results, no faceting etc. yet, or boosting, or those kind of things.

Closes #26


Can we make it a shared service?

Currently one instance only works for a single Glip team. Users needs to deploy new instances for their Glip teams.
Can we deploy a shared instance, so that others don't have to deploy their own? They can specify Glip group id via query parameter.

And we can have a menu item inside Glip: "Share this team".

And we can have a menu item inside Glip: "Share this team".

This is a good idea. Could it be done in Glip Plus?

Good to see this to be possible. It has confused me for a long time.
And how to leverage in Jupiter app?


Update understand-vm-reboot.md

Reflects the following change.
https://github.com/MicrosoftDocs/azure-docs/commit/b541cddc8867dc86c0c8ede8f8f5cf5282924205#diff-dd52e146a646ac8587ede5951bac893637eb9523a239f8f9c5795bf9595c9a9c

@NAO-MSFT : Thanks for your contribution! The author(s) have been notified to review your proposed change.


& inside html string

I am trying to export / save to XLSX a HTML table, where some values might contain "&" sign
This is always converted into & inside XLSX file (due to innerHTML() call)
I think that the htmldecode() function should also replace & with &

This appears to be fixed in 0.11.13, testing against http://sheetjs.com/demos/table .  There are plenty of missing html entities but we'll grind through them in the coming versions.


[TST] Add tests for binary_metrics_proba

Unit tests are needed for the binary_metrics_proba function in mmu.metrics

Closed by #13


Error in stateless nested component

version of next.js: 2.0.0-beta.23
i’m reproduced bug:
https://gist.github.com/Rastopyr/7dc995ec888e962aaea387376049c5b2#file-error-md
with this component:
https://gist.github.com/Rastopyr/7dc995ec888e962aaea387376049c5b2#file-component-with-error-js
and problem probably related with this issue
https://github.com/zeit/next.js/issues/827
error throw in this line
https://github.com/zeit/next.js/blob/master/client/index.js#L76
NOTE: i can prepare PR, but next.js i use just second day, and not had enough time to research codebase. if somebody can help me, with this issue, i will very grateful

Also i found, that error fired in initial rendreing on dev/production environment. But in dev env, after HMR reloading, component rendering is ok.
Also i found that doRender fired three times.

Component - is correct (IndexPage for example)
Component - is undefined but component variable the same IndexPage source
Component - ErrorComponent.

Error was fired from React.js
Info:
https://facebook.github.io/react/docs/error-decoder.html?invariant=32&args[]=33
Close this issue.


BlobTrigger payload expression binding not working as expected

When using a queue trigger binding with a blob input binding, the following example works as expected. In this example, we are able to parse the payload of myBook and use the id to evaluate input-container/{id}.txt to input-container/1.txt
QueueTrigger/index.js
import { AzureFunction, Context } from "@azure/functions"

const queueTrigger:
    AzureFunction = async function (context: Context, myBook: Book): Promise<void>
    {
        context.log("Queue trigger function processed blob");
        context.log("Book name:", myBook.name);
        context.log("Book content:", context.bindings.myBlob);
    };

type Book = {
    id: string,
    name: string,
}

export default queueTrigger;

function.json
{
  "bindings": [
    {
      "name": "myBook",
      "type": "queueTrigger",
      "direction": "in",
      "queueName": "book-trigger",
      "connection": "AzureWebJobsStorage"
    },
    {
      "name": "myBlob",
      "type": "blob",
      "direction": "in",
      "path": "input-container/{id}.txt",
      "connection": "AzureWebJobsStorage"
    }
  ],
  "scriptFile": "../dist/QueueTrigger/index.js"
}

Trigger payload:
{ "id": "1", "name": "mybook" }
Output:
[2022-10-25T22:58:17.636Z] Executing 'Functions.QueueTrigger' (Reason='New queue message detected on 'book-trigger'.', Id=e4545b2a-0fe5-4f08-aed5-705f24dfc2a3)
[2022-10-25T22:58:17.637Z] Trigger Details: MessageId: fd82d6a8-40dd-4275-a700-51c394e5bc1c, DequeueCount: 1, InsertedOn: 2022-10-25T22:58:15.000+00:00
[2022-10-25T22:58:17.857Z] Queue trigger function processed blob
[2022-10-25T22:58:17.858Z] Book name: mybook
[2022-10-25T22:58:17.858Z] Book content: hello world
[2022-10-25T22:58:17.884Z] Executed 'Functions.QueueTrigger' (Succeeded, Id=e4545b2a-0fe5-4f08-aed5-705f24dfc2a3, Duration=270ms)

This behaviour is also expected to work for the BlobTrigger
BlobTrigger/index.js
import { AzureFunction, Context } from "@azure/functions"

const blobTrigger:
    AzureFunction = async function (context: Context, myBook: Book): Promise<void>
    {
        context.log("Blob trigger function processed blob")
        context.log("Book name:", myBook.name);
        context.log("Book content:", context.bindings.myBlob);
    };

type Book = {
    id: string,
    name: string,
}

export default blobTrigger;

function.json
{
  "bindings": [
    {
      "name": "myBook",
      "type": "blobTrigger",
      "direction": "in",
      "path": "book-trigger",
      "connection": "AzureWebJobsStorage",
      "dataType": "string"
    },
    {
      "name": "myBlob",
      "type": "blob",
      "direction": "in",
      "path": "input-container/{id}.txt",
      "connection": "AzureWebJobsStorage",
      "dataType": "string"
    }
  ],
  "scriptFile": "../dist/BlobTrigger/index.js"
}

Trigger payload (book.json)
{ "id": "1", "name": "mybook" }
Output
[2022-10-25T22:58:52.738Z] Executing 'Functions.BlobTrigger' (Reason='New blob detected(LogsAndContainerScan): book-trigger/book.json', Id=a8c7a83f-f490-43a1-a6ca-955f554c19b5)
[2022-10-25T22:58:52.738Z] Trigger Details: MessageId: 3a6ad397-27ca-47d3-b012-5973cd36a039, DequeueCount: 1, InsertedOn: 2022-10-25T22:58:52.000+00:00, BlobCreated: 2022-10-25T21:39:49.000+00:00, BlobLastModified: 2022-10-25T22:58:42.000+00:00
[2022-10-25T22:58:52.785Z] Executed 'Functions.BlobTrigger' (Failed, Id=a8c7a83f-f490-43a1-a6ca-955f554c19b5, Duration=116ms)
[2022-10-25T22:58:52.785Z] System.Private.CoreLib: Exception while executing function: Functions.BlobTrigger. Microsoft.Azure.WebJobs.Host: No value for named parameter 'id'.

We should have seen is a similar result to what happened with the queue trigger:
Book name: mybook
Book content: hello world

Interestingly, when we remove the use of the blob input binding and just use a blob trigger by itself, still binding to a Book, instead of getting the payload as a Book, we get binary data (even if the data type is set to string):
{
  "bindings": [
    {
      "name": "myBook",
      "type": "blobTrigger",
      "direction": "in",
      "path": "book-trigger",
      "connection": "AzureWebJobsStorage",
      "dataType": "string"
    }
  ],
  "scriptFile": "../dist/BlobTrigger/index.js"
}

[2022-10-25T23:01:19.747Z] Executing 'Functions.BlobTrigger' (Reason='New blob detected(LogsAndContainerScan): book-trigger/book.json', Id=75277b64-3197-477c-afeb-044a30253ce6)
[2022-10-25T23:01:19.748Z] Trigger Details: MessageId: 9bd797ac-a7d8-477e-8516-791ae788c6c2, DequeueCount: 1, InsertedOn: 2022-10-25T23:01:19.000+00:00, BlobCreated: 2022-10-25T21:39:49.000+00:00, BlobLastModified: 2022-10-25T23:01:11.000+00:00
[2022-10-25T23:01:19.821Z] Blob trigger function processed blob
[2022-10-25T23:01:19.821Z] MyBook: <Buffer 7b 20 22 69 64 22 3a 20 22 31 22 2c 20 22 6e 61 6d 65 22 3a 20 22 6d 79 62 6f 6f 6b 22 20 7d>
[2022-10-25T23:01:19.821Z] Book name: undefined
[2022-10-25T23:01:19.849Z] Executed 'Functions.BlobTrigger' (Succeeded, Id=75277b64-3197-477c-afeb-044a30253ce6, Duration=205ms)

We would expect to get a POCO as we have logic in the host here that pulls json values from the payload if it's a String. We can see this in action with the queue trigger example.

[ ] The goal of this issue is to investigate why the payload binding expression is not working for the BlobTrigger

I don't know why this is, but AFAIK we're just handling what the host gives us. Specifically, here is the invocation we get for a queue trigger with data set to "string" and for a blob trigger with data set to "bytes":

Are we sure that's not by design on the host's part? I would understand if a file was handled differently than a queue entry

If that's the case, this is probably a host or WebJobs sdk issue (I can transfer issue). We should not be giving you bytes in this use case 🙃


Modification on APA_impute and Covariate formatting

The new section in data_preprocessing/covariate_formatting.ipynb is designed to merge peer factors generated using the new methods and the covariate file. The apa_impute change the impute workflow from impute then merge to merge and then impute.

@hsun3163 could you review the changes to the covariate formatting code and make comments for improvements? Alternatively you can let me know if I should merge that and you make improvements after i merge -- that might be easier?

@gaow professor, I have talked with hao sun, and he agreed to add the additional part to merge peer factors with covariate data.  I shall comment the improvement made and restart the pull request.

Thanks @seriousbamboo you can commit to this PR when you have the changes. I'll review after you commit. (I will receive notifications as u make commits to this PR; no need to start a new one)

Got it. I am polishing the impute code, would push it to hub soon.

@gaow professor, all commits are pushed and commented. Please check.


Explain migration histories terminology

Currently we have this subsection on migration histories.
Would be good to clarify the difference between the migration files and the migration table, and use consistent terminology to refer to each of them.
Also we may want to pull this out into its own separate page as part of a general reorganisation of the information in this page.
Slack discussion here: https://prisma-company.slack.com/archives/CGMCB82N8/p1659705786802819

👋 we're cleaning up our backlog of issues and are closing everything older than two years. If you still feel that this issue is relevant, please feel free to re-open and our team will take a look. Thank you!


Switch to crossplane/build

Description of your changes

See https://github.com/crossplane/crossplane/issues/1583 for context
I have:

[x] Read and followed Crossplane's contribution process.
[x] Run make reviewable to ensure this PR is ready for review.
[ ] Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Just kidding I did this two weeks ago in https://github.com/crossplane/provider-template/pull/88. 🙃


support array-like objects in R.slice

Fixes #839

The flip side is this will break on objects with custom slices

The flip side is this will break on objects with custom slices

True. Do you think we should special-case Arguments objects?

I updated the pull request to use _checkForMethod, and added a test case for an object with a custom slice method.

LGTM


⚠ Bofrost.de has degraded performance

In 0b6c9f6, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1375 ms

Resolved: Bofrost.de performance has improved in e3cce83.


Add ability to configure instance tenancy

what

Add new variable tenancy that allows user to configure instance tenancy (default (default), dedicated, or host)

why

An organization that I work with has a security policy that requires use of dedicated tenancy. This PR adds the capability to do that when using this module.

references

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/instance#tenancy
Closes #139

/test all

/test all

Looks like the pipeline runs are failing on "Update GitHub Status for pending".
https://github.com/cloudposse/actions/actions/runs/3145776764/jobs/5113473987

/test all

/test all

Will do, thanks 😄

@Nuru done, PTAL

/test all

bump @Nuru PTAL

/test all


Adding Operator workflow

Closes #10

Having some issues with GH packages with the release run, which is why it's not passing.


Tests for docker color feature

Complete the tests for the docker color feature.
[SP: 8]
[Priority: High]
[Risk: Low]
[Ideal Time: 3 days]

Completed on merge.


add traceAll

Hello,
Thank you for lovely ❤  library. Often I am in a situation where I have tracer for e.g. Transaction
putStrlnTracer :: Tracer IO String
putStrlnTracer = Tracer (\tx -> putStrLn tx)

txTracer :: Tracer IO Tx
txTracer = showTracing putStrlnTracer

and I have Block full of transactions:
data Tx = Tx Int deriving Show
data Block = Block String [Tx] deriving Show

b :: Block
b = Block "001" (map Tx [41,43,47,53,61,71,83])

I know how to get Transactions from Block.
blockTx :: Block -> [Tx]
blockTx (Block hash tx) = tx

I would like to trace all transactions from Block. Result from Tracer is IO () so If I can smash together results.  PR contains (generalised) combinator for this:
traceAll :: (Applicative m) => (b -> [a]) -> Tracer m a -> Tracer m b

You can use it like so:
blockTracer :: Tracer IO Block
blockTracer = traceAll blockTx txTracer

traceWith blockTracer b
Tx 41
Tx 43
Tx 47
Tx 53
Tx 61
Tx 71
Tx 83

You could play this game with Maybe or any other Traversable.

Looks good to me, but I would suggest factoring it like this:
traceTraversable :: (Applicative m, Traversable t) => Tracer m a -> Tracer m (t a)
traceTraversable tr = Tracer (void . traverse (runTracer tr))

traceAll :: (Applicative m, Traversable t) => (b -> t a) -> Tracer m a -> Tracer m b
traceAll f = contramap f . traceTraversable

or maybe we should go one step further:
mapTracer :: ((a -> m ()) -> b -> n ())
          -> Tracer m a -> Tracer n b
mapTracer f (Tracer tr) = Tracer (f tr)

natTracer :: (forall x. m x -> n x)
          -> Tracer m a
          -> Tracer n a
natTracer f = mapTracer (f .)

-- using `traverse_` we can reduce the constraint of `t` to `Foldable t`.
traverseTracer :: (Applicative m, Foldable t) => Tracer m a -> Tracer m (t a)
traverseTracer = mapTracer traverse_

Thank you 🙇 for the review. Applied suggestion with traceTraversable and mapTracer. New functions are exposed.
mapTracer is beautiful in many ways :)

Could you just squash the review commits onto the other ones? Then it's ready to be merged.

Could you just squash the review commits onto the other ones? Then it's ready to be merged.

@coot Commits from PR were squashed. Thank you for review.


Make scripts pass mypy check

In some scripts, I have changed things other than annotations. I have tested some of those scripts, but not all.

Merged everything but the last commit, which I don't understand - it seems to me like the old code passed mypy anyway?

It doesn't pass mypy. I get this on running tools/run-mypy --scripts-only tools/update-deployment:
Checking tools/update-deployment
tools/update-deployment:9: error: "module" has no attribute "configparser"

The problem is that in typeshed, the package six.moves doesn't yet contain the stub file for configparser. We can work around that by using --silent-imports and using import six.moves.configparser as configparser instead of using import six.moves.configparser or from six.moves import configparser.
Maybe I should add a comment to make it clear why I'm using such a weird import statement.

Ahh, of course, I failed to run with --scripts-only when testing.  Yeah maybe we should do the same solution as we used previously for https://github.com/python/typeshed/issues/307, e.g. a type ignore with comment like https://github.com/TomaszKolek/zulip/commit/6dc1c3431fab85863f1b500c529d239e27d7fbe2.

Added a type: ignore and a comment explaining it.

Merged!


 Let the user override the license with a flag like:
license-bill-of-materials --override "github.com/coreos/etcd,BSD 3-clause"

@philips I fixed the first part. Now we report the missing license as an error. For the second part, I feel adding a flag might be inconvenient. If we have a project that miss 5 licenses on its deps, the string list will be pretty long. Are you open to change that to an input file?
license-bill-of-materials --override-file

file example
github.com/coreos/etcd BSD 3-clause
github.com/coreos/example Apache 2

A file is fine.

@philips Fixed in master.


DOC: remove broken link to scipy.stats.distributions

remove broken link to scipy.stats.distributions

Reference issue

What does this implement/fix?

Additional information

Thanks @partev. Next time for a doc-only change, please include [skip actions] [skip cirrus] in the commit message so that only the doc-build job runs. (Nobody would have expected you to know that before, though!)

I see now that scipy.stats.distributions was supposed to appear on that page because it is still a public subsubpackage. The preferable fix would be to ensure it goes to a page (which may not exist yet). Would you like to make that happen?

Oh seeing your comment now Matt (again this phone caching sorry.) I will let you decide then

@tupui I know we have plans for the tutorials, but did we have plans for the API section? What did you have in mind?

Work for me 👍 The ball in on your side @partev 😃

thanks for all the comments. I am going to close this since you are going to refactor this soon.


Unexpected exception when package version does not follow semver

Problem
Having a reference that uses an incorrect semver version like this:
<ItemGroup Condition="'$(os)' == 'Windows_NT'">
	<PackageReference Include="IBM.Data.DB2.Core" Version="<IP_ADDRESS>" />
</ItemGroup>

<ItemGroup Condition="'$(os)' == 'Unix'">
	<PackageReference Include="IBM.Data.DB2.Core-lnx" Version="<IP_ADDRESS>" />
</ItemGroup>

Gives the following error:
Sorry, an unexpected exception has occurred: System.ArgumentException: '<IP_ADDRESS>' is not a valid version string. (Parameter 'value')
   at NuGet.Versioning.SemanticVersion.Parse(String value)
   at LibYear.Lib.FileTypes.XmlProjectFile.<>c__DisplayClass10_0.<.ctor>b__1(XElement d) in X:\LibYear\src\LibYear.Lib\FileTypes\XmlProjectFile.cs:line 31
   at System.Linq.Enumerable.ToDictionary[TSource,TKey,TElement](IEnumerable`1 source, Func`2 keySelector, Func`2 elementSelector, IEqualityComparer`1 comparer)
   at System.Linq.Enumerable.ToDictionary[TSource,TKey,TElement](IEnumerable`1 source, Func`2 keySelector, Func`2 elementSelector)
   at LibYear.Lib.FileTypes.XmlProjectFile..ctor(String filename, String elementName, String[] packageAttributeNames, String versionAttributeName) in X:\LibYear\src\LibYear.Lib\FileTypes\XmlProjectFile.cs:line 29
   at LibYear.Lib.FileTypes.CsProjFile..ctor(String filename) in X:\LibYear\src\LibYear.Lib\FileTypes\CsProjFile.cs:line 7
   at LibYear.Lib.FileUtils.ToProjectFile(String path) in X:\LibYear\src\LibYear.Lib\FileUtils.cs:line 18
   at LibYear.Lib.ProjectFileManager.GetProjects(String arg) in X:\LibYear\src\LibYear.Lib\ProjectFileManager.cs:line 17
   at System.Linq.Enumerable.SelectManySingleSelectorIterator`2.ToList()
   at System.Linq.Enumerable.ToList[TSource](IEnumerable`1 source)
   at LibYear.Lib.ProjectFileManager.GetAllProjects(IReadOnlyList`1 args) in X:\LibYear\src\LibYear.Lib\ProjectFileManager.cs:line 11
   at LibYear.App.Runner.Run(List`1 args) in X:\LibYear\src\LibYear\Runner.cs:line 41
   at LibYear.App.Program.Main(String[] args) in X:\LibYear\src\LibYear\Program.cs:line 24

Expected behavior
Swallow the exception and to display the libyear if it is an accepted Nuget package and perhaps with an error message.
Alternatively using a flag when running the program to use a non-strict version checking and/or suppressing errors in individual packages.

I get this message too and came to the same conclusions. Semver is nice, but not everything follows it.

Thanks for reporting! This was fixed in #20 for #17, I just haven't gotten around to releasing a new version yet, but you can build it yourself to get the fix until then.

Any chance for a release in the foreseeable future?

@mdschweda v4.1.0 has been released, thanks for the bump!


tools to validate cluster setup during application run

Is your feature request related to a problem? Please describe.
It would be nice to have a script or tool that validated that a spark application got the resources that you requested. For instance, I might request 8 executors but depending on the cluster manager you might not get 8... ie on YARN or standalone it might not have enough resources if you don't take the totals into account.  with dynamic allocation on you could get different then you expect, etc.
This would be useful for benchmark runs.
it would be nice if it dumped out configurations like memory and core per executor as well.

This might be useful as part of the profiling tool.  The tool could print the diff between what was expected vs. the actual configs used in the cluster.
cc: @mattahrens


(WIP) safety checks

(WIP. Not ready to merge.)
Working on #43. The goal is have a flag --check which, before writing to the output, checks the following:

lex(output) = lex(input): no tokens added, removed, or reordered (including comments).
parse(output) = parse(input): make sure nothing terrible has gone wrong in the parser. (If the result of the lexer is good, then this check should be superfluous. But, uhhh, for my sanity... I'm just gonna check it explicitly.)
format(output) = format(input): make sure the formatter is idempotent.

Together, these checks should ensure that smlfmt is always safe to use.
Current status:

[x] CheckOutput.check interface
[x] --check flag, and plumbing for calling CheckOutput.check in the right place
[x] ~implement CheckOutput.checkTokenSeqs.checkTokens~. Implement Token.sameExceptForMultilineIndentation, which compares two tokens, handling multiline tokens where it's okay for indentation to differ.
[ ] implement CompareAst.

this is nifty, once impl'd i'll probably call smlfmt from millet with this flag and move the disclaimer to only apply to my naive formatter.
can there be specific exit codes so a caller of smlfmt (like millet) can tell the difference between user error (e.g. parse error) and smlfmt internal error (e.g. lex(output) != lex(input) etc)? that way millet could ignore smlfmt errors about bad user input but show a warning/request the user fill out a bug report when smlfmt fails the safety checks.

that sounds nice but also a lot more work

On the smlfmt side, it would be really easy to do an initial protocol. I'm picturing just three possible messages initially:

success with formatted output, e.g. { "tag": "success", "data": ... }
error: invalid SML input { "tag": "parse-error", "data": ... }
error: smlfmt bug { "tag": "bug", "data": ... }

Would this be difficult to support on Millet's side?
(I think it's worth the investment, because then the protocol could be incrementally extended with more interesting functionality down the line.)

oh no it wouldn't really be much harder to consume that on the millet side. the 'more work' i was thinking of would be smlfmt  being able to input/output incremental diffs.
i'd suggest a flag like --json-version=<N> where <N> is some integer starting with 1 to output json data. then if you need to change the output in a backwards incompatible way you can request new callers use e.g. json version 2 while keeping version 1 around.

Excellent! The --json-version thing is a great idea, thanks. I'll try throwing this together soon and let you know how it goes.


[SPARK-45034][SQL] Support deterministic mode function

What changes were proposed in this pull request?
This PR adds a new optional argument to the mode aggregate function to provide deterministic results. When multiple values have the same greatest frequency then the new boolean argument can be used to get the lowest or highest value instead of an arbitraty one.
Why are the changes needed?
To make the function more user friendly.
Does this PR introduce any user-facing change?
Yes, it adds a new argument to the mode function.
How was this patch tested?
Added new UTs.
Was this patch authored or co-authored using generative AI tooling?
No.

Hmm, the failure seems unrelated but persistent...
[info] - client INVALID_CURSOR.DISCONNECTED error is retried when other RPC preempts this one *** FAILED *** (385 milliseconds)
[info]   org.apache.spark.SparkException: io.grpc.StatusRuntimeException: INTERNAL: [INVALID_CURSOR.POSITION_NOT_AVAILABLE] The cursor is invalid. The cursor position id c156089c-f861-467e-9031-31ee6f26d2b4 is no longer available at index 2.
[info]   at org.apache.spark.sql.connect.client.GrpcExceptionConverter$.toThrowable(GrpcExceptionConverter.scala:113)

+1, LGTM. Merging to master.
Thank you, @peter-toth and @cloud-fan @srielau for review.

Thanks all for the review!


how to change the format of col from general to text so i can keep leading zeros in mobile number

@SheetJSDev Do you have any solution to this? I get from excel for the number 90887 with format 0000000 (7 zeroes making it look like 0090887):
{
  s: {patternType: "none"},
  t: "n",
  v: 90887,
  w: "90887",
  z: "General"
}

using XLSX.read. If there were a field that could give me excel's custom format, that would probably fix it.

Pass a string:
{ t: "s", v: "0090887" }

OR use a number format:
{ t: "n", v: 90887, z: "0000000" }

The z key is the number format that you would specify in Excel


Startup failure with systemd

This happens after I install gophernicus.    It won't start afterwards.
Created symlink /etc/systemd/system/sockets.target.wants/gophernicus.socket → /lib/systemd/system/gophernicus.socket.
Job for gophernicus.socket failed.
See "systemctl status gophernicus.socket" and "journalctl -xe" for details.
make: *** [Makefile:239: install-systemd] Error 1

is now handled through pull request


Community Button: Discuss doc or page

The Discuss doc or page programmable button is not working.
Steps to reproduce

Copy link
right click programmable button.
paste a url
error 😢

Video
https://github.com/OrionBrowser/ProgrammableButtons/assets/4629398/4825da3c-75f6-44b5-b9f3-c4cdfbd492c5

That is a community member submitted one, so best would be to mention the person who submitted it.

^^@j-peeters

Hi, I'd hoped to give the community button repository a push by adding this one by copying the code from a Discord post but seemingly my technical knowledge is lacking to get this working via GitHub. I have not found a way to fix this. I've deleted the file and mention in the Readme and made a pull request for their deletions.


Create Blog “the-top-5-reasons-to-review-your-company’s-financial-statements-1”

Automatically generated by Netlify CMS

👷 Deploy Preview for safehavenaccounting processing.

Name
Link

🔨 Latest commit
2cdb1c7a8e60032be690d44b1fa69ab4b28c68da

🔍 Latest deploy log
https://app.netlify.com/sites/safehavenaccounting/deploys/647552bf47bb230008b2bf18


Add QT and turtlesim example

Adds QT support and turtlesim example.
The very vast majority of changes is from copying the original turtlesim example (Commit: Add turtlesims as is from tutorial to examples).

Thx for your comment Milan.
I agree to your concerns and have actually expected this. My reason to use QT anyhow was because QT is widely used in many ROS examples and I considered an example how to integrated it as helpful. While I'd be interested in porting it to IMGUI, I do not need it for my self and do not see that I have the cycles for this, ATM. Sorry.
Feel free to close this PR
Andreas

Hi Andreas, I fully understand you. Let's put the PR in the fridge at the moment, and maybe we or someone else will have time to take a look at this in the future. Thanks once again for the initial push!

Thx for your understanding!
BTW, which ImGui backend would you use?

Hi, I already experimented with DearImGui with OpenGL+glfw backend on Linux, and this is quite easy to set up on Linux + Bazel; and it works like a charm. So, I think I would start with that. Any other ideas?


Update football network to parametric action distribution API

Now football network uses parametric action distribution to sample and postprocess actions.

Looks good. Added a comment.

Should I also change
https://github.com/google-research/seed_rl/blob/8af694ebd21af5f1b14bd8891e84aa42c5f13b2f/agents/vtrace/networks.py#L75
in order to maintain consistency.

That would be great thanks

Thanks


build: fix kubelet issue#60987

When a Pod which has used PVC is deleted from kubuernetes cluster
we can get a error message repeatedly(Orphaned pod "1f415e-...-4b38"
found, but volume paths are still present on disk) from kubelet log.
this error message is caused by kubelet because it cannot clean the
parent path of targetPath when Pod is deleted from cluster
(targetPath like:
/var/lib/kubelet/pods/9cda187a-7fb3-11ea-80b3-246e968d4b38/volumes/kubernetes.io~csi/pvc-9ae9405c-7fb3-11ea-80b3-246e968d4b38/mount
). Ceph CSI can remove the parent path of targetPath first instead of
waiting kubelet to fix this issue.
Signed-off-by: chengyu-l<EMAIL_ADDRESS>

There are few things which I would like to discuss here, so adding DNM for now.

is this method work?  @humblec


Pylint

Hi - what's the standard practice for pylintrc files with Deep Mind projects?
Could we add the standard Google one to the repo, and perhaps also add a linting step the CD? Happy to commit a PR if useful.

Thanks John!
Something like https://github.com/marketplace/actions/python-code-quality-and-lint should work

Should the .style.yapf not use equals instead of colons? i.e.
[style]
based_on_style = chromium
indent_width = 2
split_before_named_assigns = True
column_limit = 80

Actually, I am still getting errors using this file. Would you be able to advise me please? I believe this is because chromium is not a recognised style.
Yapf says that you can choose a predefined style https://github.com/google/yapf
... based in the file style.py https://github.com/google/yapf/blob/main/yapf/yapflib/style.py
But chromium is not one of them.

Update: I was wrong about the equals signs, colons are fine. But I think you want
based_on_style: yapf
That appears to be what the chromium style is now called
https://github.com/google/yapf/pull/789

Thanks for the heads-up. I think it should just be:
[style]
based_on_style: yapf

Change incoming soon.


fix sonar bug: null check in api.executorService

What is the purpose of the pull request
sonar check bug
fix bug: add null check in api.executorService
Brief change log

Modify api/service/ExecutorService
Modify api/utils/ZooKeeperState
Modify dao/entity/ProcessData
Modify master/runner/MasterTaskExecThread

This pull request is code cleanup without any test coverage.

Codecov Report

Merging #1808 into dev will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             dev    #1808      +/-   ##
=========================================
- Coverage   21.4%   21.38%   -0.02%
=========================================
  Files        293      293
  Lines      14051    14057       +6
  Branches    2316     2319       +3
=========================================
- Hits        3007     3006       -1
- Misses     10717    10724       +7
  Partials     327      327

Impacted Files
Coverage Δ

...ler/server/master/runner/MasterTaskExecThread.java
0% <0%> (ø)
:arrow_up:

...pache/dolphinscheduler/dao/entity/ProcessData.java
0% <0%> (ø)
:arrow_up:

.../dolphinscheduler/api/service/ExecutorService.java
0.47% <0%> (-0.01%)
:arrow_down:

...che/dolphinscheduler/api/utils/ZooKeeperState.java
0% <0%> (ø)
:arrow_up:

...scheduler/alert/template/AlertTemplateFactory.java
42.85% <0%> (-14.29%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 289ae6a...ddb7f00. Read the comment docs.


Bug report: formatCurrency() returns wrong format for de-DE as naviator.language

Describe the bug A clear and concise description of what the bug is.
The formatCurrency() test is failing on a computer with navigator.language set to de-DE.
[display] formatCurrency() => ./utils/display_test.ts:34:6
error: AssertionError: Values are not equal.

    [Diff] Actual / Expected

-   5$
+   $5

  throw new AssertionError(message);
        ^
    at assertEquals (https://deno.land/std@0.202.0/assert/assert_equals.ts:53:9)
    at file:///Users/<user>/saaskit/utils/display_test.ts:35:3

To Reproduce Steps to reproduce the behavior:
Run deno task test with the navigator.language set to de-DE for example.
Expected behavior A clear and concise description of what you expected to
happen.
Having the expected correct $ format however the navigator.language.
Additional context Add any other context about the problem here.
This might be an interesting case since for example € is handled the other way. There it would be 5€ and not €5

After diving deeper into the documentation of Intl.NumberFormat this is the indended behaviour. However we then have to adapt our tests. Since navigator.language is a constant and read-only we can not just set it to en-US when running the tests.


Add initial repo config

Summary
This PR adds the initial repo config (builder.toml, README, License, etc) and github config (workflows, labels, etc). Once this is in place, we can then submit a PR to add the github-update workflow which should then keep the repo in sync with the upstream builder config.
Checklist

[x] I have viewed, signed, and submitted the Contributor License Agreement.
[ ] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
[ ] I have added an integration test, if necessary.
[x] I have reviewed the styleguide for guidance on my code quality.
[x] I'm happy with the commit history on this PR (I have rebased/squashed as needed).

Could we get a CODEOWNERS in this as well?

No smoke tests yet, but the infrastructure is in place to run them if/when we add them.


Chinese characters are chopped

Given a chinese character that uses more than one cell, and another one, we get two CTRuns, one for the Chinese character, and one that contains both a space and the second character.   The space when we render seems to be overwriting the second half of the Chinese character:

The patch below extracts the position of the rune relative to the line, and helps a bit, but now the last character of the line is chopped, so there is some clipping somewhere I need to find, this is what it looks like now:

diff --git a/Sources/SwiftTerm/Apple/AppleTerminalView.swift b/Sources/SwiftTerm/Apple/AppleTerminalView.swift
index 59f8643..4ba20e0 100644
--- a/Sources/SwiftTerm/Apple/AppleTerminalView.swift
+++ b/Sources/SwiftTerm/Apple/AppleTerminalView.swift
@@ -564,9 +564,13 @@ extension TerminalView {
                     CTRunGetGlyphs(run, CFRange(), bufferPointer.baseAddress!)
                     count = runGlyphsCount
                 }
+                let x = [CGPoint](unsafeUninitializedCapacity: runGlyphsCount) { (bufferPointer, count) in
+                    CTRunGetPositions(run, CFRange(), bufferPointer.baseAddress!)
+                    count = runGlyphsCount
+                }

                 var positions = runGlyphs.enumerated().map { (i: Int, glyph: CGGlyph) -> CGPoint in
-                    CGPoint(x: lineOrigin.x + (cellDimension.width * CGFloat(col + i)), y: lineOrigin.y + ceil(lineLeading + lineDescent))
+                    CGPoint(x: lineOrigin.x + x [i].x /* (cellDimension.width * CGFloat(col + i))*/, y: lineOrigin.y + ceil(lineLeading + lineDescent))
                 }

                 var backgroundColor: TTColor?

I think you need to convert the whole string to a width, not just the glyphs, especially in Unicode which can have reverse text, subscripts etc.

I think you need to convert the whole string to a width, not just the glyphs, especially in Unicode which can have reverse text, subscripts etc.
https://developer.apple.com/documentation/foundation/nsstring/1524729-boundingrectwithsize

I think it's not the string width but glyph postions in line are wrong. You just point out a right direction of this issue, because the CoreText calculate each character's position not just using the char width multiply the index of it in a line.
I will try to fix this issue, good luck to me.

Perhaps an alternative is to allocate cells when the characters are generated.  So when double-width characters like Chinese characters or emoji are produced, I record both the character and an empty slot after, and use this information while rendering, so I can normalize all output into a grid.
And perhaps rather than trying to create a single attributed string for the whole line, I need to break up the attributed string at these width-changing boundaries

Some of the suggestion above already existed in the codebase, and I should addressed a few scenarios for characters that did not have the right metrics.  There might be more places where I need to add this information.

Given a chinese character that uses more than one cell, and another one, we get two CTRuns, one for the Chinese character, and one that contains both a space and the second character. The space when we render seems to be overwriting the second half of the Chinese character:

The patch below extracts the position of the rune relative to the line, and helps a bit, but now the last character of the line is chopped, so there is some clipping somewhere I need to find, this is what it looks like now:

diff --git a/Sources/SwiftTerm/Apple/AppleTerminalView.swift b/Sources/SwiftTerm/Apple/AppleTerminalView.swift
index 59f8643..4ba20e0 100644
--- a/Sources/SwiftTerm/Apple/AppleTerminalView.swift
+++ b/Sources/SwiftTerm/Apple/AppleTerminalView.swift
@@ -564,9 +564,13 @@ extension TerminalView {
                     CTRunGetGlyphs(run, CFRange(), bufferPointer.baseAddress!)
                     count = runGlyphsCount
                 }
+                let x = [CGPoint](unsafeUninitializedCapacity: runGlyphsCount) { (bufferPointer, count) in
+                    CTRunGetPositions(run, CFRange(), bufferPointer.baseAddress!)
+                    count = runGlyphsCount
+                }

                 var positions = runGlyphs.enumerated().map { (i: Int, glyph: CGGlyph) -> CGPoint in
-                    CGPoint(x: lineOrigin.x + (cellDimension.width * CGFloat(col + i)), y: lineOrigin.y + ceil(lineLeading + lineDescent))
+                    CGPoint(x: lineOrigin.x + x [i].x /* (cellDimension.width * CGFloat(col + i))*/, y: lineOrigin.y + ceil(lineLeading + lineDescent))
                 }

                 var backgroundColor: TTColor?

seems we don't need the space after a Unicode character.
for example,
$ cd dir && tree .
.
├── 你好.txt
in the func buildAttributedString(), https://github.com/migueldeicaza/SwiftTerm/blob/4df9211e2f039e426ba02859a7d668e40212d90f/Sources/SwiftTerm/Apple/AppleTerminalView.swift#L394,
the str's value will become to "你 好 .txt", there's a space between '你' and '好', and a space between '好' and '.',
even we fix the space overlapping issue (I'v tried don't append a space after a unicode character), it just works well in the rendering mode, but in the selection mode, the spaces still be there, and we paste it to somewhere else, we just got "你 好 .txt" rather than "你好.txt".

Given a chinese character that uses more than one cell, and another one, we get two CTRuns, one for the Chinese character, and one that contains both a space and the second character. The space when we render seems to be overwriting the second half of the Chinese character:

The patch below extracts the position of the rune relative to the line, and helps a bit, but now the last character of the line is chopped, so there is some clipping somewhere I need to find, this is what it looks like now:

diff --git a/Sources/SwiftTerm/Apple/AppleTerminalView.swift b/Sources/SwiftTerm/Apple/AppleTerminalView.swift
index 59f8643..4ba20e0 100644
--- a/Sources/SwiftTerm/Apple/AppleTerminalView.swift
+++ b/Sources/SwiftTerm/Apple/AppleTerminalView.swift
@@ -564,9 +564,13 @@ extension TerminalView {
                     CTRunGetGlyphs(run, CFRange(), bufferPointer.baseAddress!)
                     count = runGlyphsCount
                 }
+                let x = [CGPoint](unsafeUninitializedCapacity: runGlyphsCount) { (bufferPointer, count) in
+                    CTRunGetPositions(run, CFRange(), bufferPointer.baseAddress!)
+                    count = runGlyphsCount
+                }

                 var positions = runGlyphs.enumerated().map { (i: Int, glyph: CGGlyph) -> CGPoint in
-                    CGPoint(x: lineOrigin.x + (cellDimension.width * CGFloat(col + i)), y: lineOrigin.y + ceil(lineLeading + lineDescent))
+                    CGPoint(x: lineOrigin.x + x [i].x /* (cellDimension.width * CGFloat(col + i))*/, y: lineOrigin.y + ceil(lineLeading + lineDescent))
                 }

                 var backgroundColor: TTColor?

seems we don't need the space after a Unicode character.
for example, $ cd dir && tree . . ├── 你好.txt
in the func buildAttributedString(),
https://github.com/migueldeicaza/SwiftTerm/blob/4df9211e2f039e426ba02859a7d668e40212d90f/Sources/SwiftTerm/Apple/AppleTerminalView.swift#L394
,
the str's value will become to "你 好 .txt", there's a space between '你' and '好', and a space between '好' and '.',
even we fix the space overlapping issue (I'v tried don't append a space after a unicode character), it just works well in the rendering mode, but in the selection mode, the spaces still be there, and we paste it to somewhere else, we just got "你 好 .txt" rather than "你好.txt".

Yes, when the terminal builds attributed string for rendering, it appends a whitespace char after some special chars( double width chars Chinese char or Emoji, or something else). But when drawing the attributed string, the whitespace char is also drawn, it must be handled specially.


Style updates

I think it's pretty clear I'm putting a lot of time and effort into making my programs the best they can be, and if you're reading this, I think you care.
This is the amount of effort I put into everything, and that is why I'm good at what I do, and also why I'd be a good fit for your team.


chore: release 1.4.0

:robot: I have created a release *beep* *boop*
1.4.0 (2019-09-16)
Features

candidate applications and assignments support (#98) (0a9e8c1)
filter support (#97) (3496527)
load protos from JSON, grpc-fallback support (a0cee41)

This PR was generated with Release Please.

Release is at https://github.com/googleapis/nodejs-talent/releases/tag/v1.4.0

The release build has started, the log can be viewed here. :sunflower:

:egg: You hatched a release! The release build finished successfully! :purple_heart:


Passing integer to file size hook via rest api fails with java.lang.ClassCastException

Using python and Bitbucket Server 4.2.0 (see exception log for more info)
I tried passing the following dict (gets converted to JSON) to the generic "enable" endpoint for hooks:
{u'pattern-1': u'.*',
u'size-1': 100000,
u'pattern-exclude-1': '',
u'pattern-branches-1': ''}

The problem is that "size-1" is an integer and not a string which makes the validation fail, the logs indicate that line 46 in FileSizeHookValidator.java is the problem:
try {
    int size = Integer.parseInt(settings.getString(SETTINGS_SIZE_PREFIX + i, ""));
    if (size < 1) {
        errors.addFieldError("size-" + i, i18n.getText("filesize-hook.error.size", "Size must be an integer value larger than 0"));
    }
} catch (NumberFormatException e) {
    errors.addFieldError(SETTINGS_SIZE_PREFIX + i, i18n.getText("filesize-hook.error.size", "Size must be an integer value larger than 0"));
}

Can you please try to use a string for the size instead of an int, like in the following example?
{u'pattern-1': u'.*',
u'size-1': '100000',
u'pattern-exclude-1': '',
u'pattern-branches-1': ''}

I think it should work then.

I've already fixed that by converting the parameter as string, but the plugin should give some kind of error message if the exception occurs instead of getting a 5xx error from the rest api


deps: point to correct hash of str0m fork

I accidentally force-pushed to the branch that we depend on in our str0m fork.

Merging this with admin override because it will break other builds. The fact that it compiles is a good enough check, we don't need to wait for the integration tests.


React v16 support

A new feature of react is to return strings and arrays on render, not just react components. I tried returning a string on a Motion child but i got this error React.Children.only expected to receive a single React element child.

this is basically issue #499.

Replied in #499

ReactMotion expects only one child element that should be a function, so check is still completely legit


./gradlew :beam-runners-google-cloud-dataflow-java:validatesRunner fails due to invalid GCS path

The default root is gs://temp-storage-for-end-to-end-tests/ and the code adds a slash and then the test case name, so it results in two slashes in a row, rejected by the filesystem implementation.
Imported from Jira BEAM-6715. Original Jira may contain additional context.
Reported by: kenn.

fixed by #7901


fix(trivial): add columns to trivial step circuit

Motivation
Without this, the trivial step circuit fails the test. Our algorithms require formal columns to pass the some checks.
Overview
Add two formal fields

@chaosma any idea, why after this fix I still receive panic here
https://github.com/snarkify/sirius/blob/f3e9492319c9bd2c34aa447efaab18a7b9579ffc/src/plonk/eval.rs#L39-L47 ?
Furthermore, in theory I should have a folding that always fills in some fixed/advice columns, implying that we shouldn't impose such fixes (why wasn't it done that way originally)?

I had encounter error in trivial circuit example as well. The reason is that StepCircuit trait is not a complete circuit. We have to assign z_in and pass it into trivial circuit columns/regions. My fix is to create a new column in process_step.
https://github.com/snarkify/sirius/blob/ivc-fix/src/ivc/step_circuit.rs#L80
Not sure if it is the exactly the error here. Hopefully it give you some hints. @cyphersnake

We have to assign z_in and pass it into trivial circuit columns/region

So it already happens even in the main branch, both in synthesis_step and process_step

process_step https://github.com/snarkify/sirius/blob/b526fdd9dd0aea7a4a17ddf867ef00dda47a7f5c/src/ivc/step_circuit.rs#L99-L101
synthesize_step https://github.com/snarkify/sirius/blob/b526fdd9dd0aea7a4a17ddf867ef00dda47a7f5c/src/ivc/step_folding_circuit.rs#L361-L372
This column already exists in main for both cases of circuit invocation.

For process_step we do not perform any manipulations on TableData, so no formal fixed&selector columns are needed there
For synthesis, we call the step circuit together with folding, so there are always fixed&advice columns inside cs.
So I don't understand why I'm crashing on that error above, and because of rayon I can't trace where exactly.

Back to this after #146


Update readme with infos from #522

Coverage remained the same at 78.175% when pulling 448f1db2bdd26dbee1aaa10fb12162ff51a5ba06 on kaffarell-patch-1 into c81962e266ceef5e35c9a0d77ce77de14eebf04e on master.