Test failures in product-apim

Description
Below tests are failing in product-apim latest repo. The failures are observed in the public jenkins build #3010 [1] and also in the latest build #3019

org.wso2.am.integration.tests.logging.CorrelationLoggingTest.testRetrieveDefaultCorrelationLoggingConfigsTest
org.wso2.am.integration.tests.logging.CorrelationLoggingTest.testEnableAllCorrelationLoggingConfigsTest

Some other tests in this same Test class had failed earlier and fixed via the commit [2].
[1] https://wso2.org/jenkins/job/products/job/product-apim/3010/
[2] https://github.com/wso2/product-apim/pull/13042/commits/93306af3717d2f1bb697bf7f5dc8ac7940dfb351
Steps to Reproduce
N/A
Affected Component
APIM
Version
4.1.0-alpha
Environment Details (with versions)
No response
Relevant Log Output
Failure logs:

- testRetrieveDefaultCorrelationLoggingConfigsTest

java.lang.AssertionError: expected [{"components":[{"name":"http","enabled":"false","properties":[]},{"name":"jdbc","enabled":"false","properties":[{"name":"deniedThreads","value":["MessageDeliveryTaskThreadPool","HumanTaskServer","BPELServer","CarbonDeploymentSchedulerThread"]}]},{"name":"ldap","enabled":"false","properties":[]},{"name":"synapse","enabled":"false","properties":[]},{"name":"method-calls","enabled":"false","properties":[]}]}] but found [{"components":[{"name":"http","enabled":"true","properties":[]},{"name":"jdbc","enabled":"true","properties":[{"name":"deniedThreads","value":["MessageDeliveryTaskThreadPool","HumanTaskServer","BPELServer","CarbonDeploymentSchedulerThread"]}]},{"name":"ldap","enabled":"true","properties":[]},{"name":"synapse","enabled":"true","properties":[]},{"name":"method-calls","enabled":"true","properties":[]}]}] at org.wso2.am.integration.tests.logging.CorrelationLoggingTest.testRetrieveDefaultCorrelationLoggingConfigsTest(CorrelationLoggingTest.java:154)

- testEnableAllCorrelationLoggingConfigsTest

java.lang.AssertionError: expected [true] but found [false] at org.wso2.am.integration.tests.logging.CorrelationLoggingTest.testEnableAllCorrelationLoggingConfigsTest(CorrelationLoggingTest.java:181)

Related Issues
No response
Suggested Labels
No response

Observations from the console output
[INFO]
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] org.wso2.am.integration.tests.logging.CorrelationLoggingTest.testEnableAllCorrelationLoggingConfigsTest
[ERROR]   Run 1: CorrelationLoggingTest.testEnableAllCorrelationLoggingConfigsTest:181 expected [true] but found [false]
[INFO]   Run 2: PASS
[INFO]
[ERROR] org.wso2.am.integration.tests.logging.CorrelationLoggingTest.testRetrieveDefaultCorrelationLoggingConfigsTest
[INFO]   Run 1: PASS
[ERROR]   Run 2: CorrelationLoggingTest.testRetrieveDefaultCorrelationLoggingConfigsTest:154 expected [{"components":[{"name":"http","enabled":"false","properties":[]},{"name":"jdbc","enabled":"false","properties":[{"name":"deniedThreads","value":["MessageDeliveryTaskThreadPool","HumanTaskServer","BPELServer","CarbonDeploymentSchedulerThread"]}]},{"name":"ldap","enabled":"false","properties":[]},{"name":"synapse","enabled":"false","properties":[]},{"name":"method-calls","enabled":"false","properties":[]}]}] but found [{"components":[{"name":"http","enabled":"true","properties":[]},{"name":"jdbc","enabled":"true","properties":[{"name":"deniedThreads","value":["MessageDeliveryTaskThreadPool","HumanTaskServer","BPELServer","CarbonDeploymentSchedulerThread"]}]},{"name":"ldap","enabled":"true","properties":[]},{"name":"synapse","enabled":"true","properties":[]},{"name":"method-calls","enabled":"true","properties":[]}]}]

This 2 test seem to fail intermittently. However following are the suspecting reasons

Delay of writing the correlation logs in  Jenkins
Correlation configs of the server not getting reset between tests

Results from jenkins run
Run 1
testRetrieveDefaultCorrelationLoggingConfigsTest : PASSED
testEnableAllCorrelationLoggingConfigsTest: FAILED
Run 2
testRetrieveDefaultCorrelationLoggingConfigsTest : FAILED
testEnableAllCorrelationLoggingConfigsTest: PASSED (but SKIPPED)

Sample http correlations log observed is as below
2023-01-20 15:22:56,124|e8365836-9f3e-4dcd-9c15-da5286a0ce62|PassThroughMessageProcessor-23|897|HTTP|TestAPI1:v1.0.0|null|/testapi1/1.0.0/*|testapi1/1.0.0|null|null|null|null|null|15|15|200|DefaultApplication|e2QHrwQi8V7RMTPH_hva_eRl_18a|901
But, isHTTPLogLine() function checks whether the line contains "HTTP-In".

It takes some time to append logs to the correlation.log on Jenkins compared to testing locally. Therefore, most of the time tests pass locally but not on Jenkins.
The previous implementation (with thread sleeps) misses some logs due to this file writing issue.
Therefore a third-party library Awatility is now integrated to read the correlation.log file with a timeout.

Test failures mentioned in the issue are fixed now. However, as the dependent test are now running testSpecificCorrelationLoggingConfigsTest() test started failing intermittently.
The reason for this failure is frequent logging of JDBC logs once it is enabled

When only http correlation logging is enabled, http logs are not logged when API is invoked.
When both method-calling is enabled together with http, http logs are also logged among method logs.
Therefore, until we fix it, http related test is commented in testSpecificCorrelationLoggingConfigsTest.

This issue is fixed with https://github.com/wso2/product-apim/pull/13101 and tests passed both locally and on jenkins https://wso2.org/jenkins/job/products/job/product-apim/3048/


Prepare the 0.3.7 release

IIRC, this also requires a release of the macros crate?

🤦 I hope it's fine now?


tests: drivers: build_all: split gsm and add mux test

Not sure if this works, not very familiar with the test suite

Haven't gone through thoroughly but seems like it found some issues with 64bit soc?
/__w/zephyr/zephyr/drivers/console/gsm_mux.c:247:31: note: format string is defined here
  247 |   LOG_DBG("%d: Too long msg (%d)", __LINE__, ret - sizeof(out));
      |                              ~^
      |                               |
      |                               int
      |                              %ld

and redefinition of a macro in nuvoton_pfm_m487?
/__w/zephyr/zephyr/drivers/console/gsm_mux.c:33: error: "PF" redefined [-Werror]
   33 | #define PF 0x10  /* Poll / Final       */
      |
In file included from /__w/zephyr/modules/hal/nuvoton/m48x/Devices/M480/Include/NuMicro.h:12,
                 from ../../../../../../../soc/arm/nuvoton_numicro/m48x/soc.h:12,
                 from ../../../../../../../include/arch/arm/aarch32/cortex_m/cmsis.h:17,
                 from ../../../../../../../include/arch/arm/aarch32/mpu/arm_mpu_v7m.h:11,
                 from ../../../../../../../include/arch/arm/aarch32/mpu/arm_mpu.h:14,
                 from ../../../../../../../include/arch/arm/aarch32/arch.h:194,
                 from ../../../../../../../include/arch/cpu.h:19,
                 from ../../../../../../../include/kernel_includes.h:33,
                 from ../../../../../../../include/kernel.h:17,
                 from /__w/zephyr/zephyr/drivers/console/gsm_mux.c:10:
/__w/zephyr/modules/hal/nuvoton/m48x/Devices/M480/Include/M480.h:375: note: this is the location of the previous definition
  375 | #define PF                   ((GPIO_T *)  GPIOF_BASE)
      |

seems like it can only build for either the native_posix or the native_posix64, is there any workaround for this? I can only think of up-casting all of them to unsigned long int.
/__w/zephyr/zephyr/drivers/console/gsm_mux.c:221:47: error: format specifies type 'long' but the argument has type 'unsigned int' [-Werror,-Wformat]
                LOG_DBG("%d: Too long msg (%ld)", __LINE__, ret - sizeof(out));
                                           ~~~              ^~~~~~~~~~~~~~~~~
                                           %u

@rlubos @jukkar

Yeah, those errors are a bit of a pain. In theory, it should be possible to use fixed-size types and symbols from https://github.com/zephyrproject-rtos/zephyr/blob/main/lib/libc/minimal/include/inttypes.h, but I recall that the compiler still complained on some platforms when I tried to use them to address this issue in some other PR. I've ended up doing exactly what you suggest, i.e. leaving the type used in the string as it was, and explicitly casting the argument provided (https://github.com/zephyrproject-rtos/zephyr/blob/main/subsys/net/lib/lwm2m/lwm2m_util.c#L384).
Perhaps someone has a better solution though, I would be happy to hear if this could be addressed in a better way.


Empty LoginView

Hi,
it seems there is some code missing in the LoginView class.
To have a functional application, it would be perfect to add the missing code.
Best,
Gilwu

Hey GilWu,
what do you mean? Are you talking about the master branch? Well, this one does not contain any login view code, you are right. But instead you should check out the branches and decide which login view implementation and approach you like. Check the readme.

Ahhhh, sorry.


high heap used

Actual behavior
when workerGroup greater than 1 heap Significant increase
Steps to reproduce
Using concurrent connections(about 4000 Client Connection)，Change workerGroup to any number greater than 1;
workerGroup=1

workerGroup=2

Minimal yet complete reproducer code (or URL to code)
`public class NettyDemo {
public static void main(String[] args) throws Exception {
    new NettyDemo().start(8080);
}

public void start(int port) throws Exception {
    DefaultChannelGroup channelGroup = new DefaultChannelGroup(new DefaultEventLoop());

    EventLoopGroup bossGroup = new NioEventLoopGroup(1);
    EventLoopGroup workerGroup = new NioEventLoopGroup(1); Change any number greater than 1
    try {
        ServerBootstrap b = new ServerBootstrap(); // (2)
        b.group(bossGroup, workerGroup)
                .channel(NioServerSocketChannel.class) // (3)
                .childHandler(new ChannelInitializer<SocketChannel>() {
                    @Override
                    protected void initChannel(SocketChannel ch) throws Exception {
                        ch.pipeline().addLast(new HttpServerCodec());
                        ch.pipeline().addLast(new HttpObjectAggregator(8192));
                        ch.pipeline().addLast(new AuthHandler(channelGroup));
                        ch.pipeline().addLast(new WebSocketServerProtocolHandler("/websocket", true));
                        ch.pipeline().addLast(new MyWebSocketServerHandler());
                    }
                })
                .option(ChannelOption.SO_BACKLOG, 128)// (5)
                .childOption(ChannelOption.SO_KEEPALIVE, true); // (6)
        ChannelFuture f = b.bind(port).sync(); // (7)
        f.channel().closeFuture().sync();
    } finally {
        workerGroup.shutdownGracefully();
        bossGroup.shutdownGracefully();
    }
}

public static class AuthHandler extends ChannelInboundHandlerAdapter {

    private final DefaultChannelGroup DEFAULT_CHANNEL_GROUP;
    AuthHandler(DefaultChannelGroup defaultChannelGroup){
        this.DEFAULT_CHANNEL_GROUP = defaultChannelGroup;
    }
    @Override
    public void channelRead(ChannelHandlerContext ctx, Object msg) {
        if (msg instanceof FullHttpRequest request) {
            Channel channel = ctx.channel();
            String s = STR."channel: \{channel.id()} Login";
            ctx.fireChannelRead(request.retain());
            DEFAULT_CHANNEL_GROUP.writeAndFlush(new TextWebSocketFrame(s));
            DEFAULT_CHANNEL_GROUP.add(channel);
            ReferenceCountUtil.release(msg);
        } else {
            ctx.fireChannelRead(msg);
        }
    }

}

public static class MyWebSocketServerHandler extends SimpleChannelInboundHandler<WebSocketFrame> {

    @Override
    protected void channelRead0(ChannelHandlerContext ctx, WebSocketFrame msg) {
        WebSocketFrame webSocketFrame;
        switch (msg) {
            case PingWebSocketFrame pingWebSocketFrame -> webSocketFrame = new PongWebSocketFrame();
            case PongWebSocketFrame pongWebSocketFrame -> webSocketFrame = new PingWebSocketFrame();
            default -> webSocketFrame = new TextWebSocketFrame("ok");
        }
        ctx.channel().writeAndFlush(webSocketFrame);
    }
}

}`
Netty version
io.netty,netty-all,4.1.101.Final
JVM version (e.g. java -version)
openjdk version "21.0.1" 2023-10-17
OpenJDK Runtime Environment Homebrew (build 21.0.1)
OpenJDK 64-Bit Server VM Homebrew (build 21.0.1, mixed mode, sharing)
OS version (e.g. uname -a)
MacOs-M1Max
Darwin xx 22.6.0 Darwin Kernel Version 22.6.0: Wed Jul  5 22:22:05 PDT 2023; root:xnu-8796.141.3~6/RELEASE_ARM64_T6000 arm64

.option(ChannelOption.SO_BACKLOG, 128)// (5) doesn't seem a good idea with 4000 Client Connections, anyway...raise it to avoid queuing, unless is what you need.
Additionally, I suggest to take an heap dump/histogram with worker group 1 and beyond and report what's the diff between them, and which instances seems to not grow proportionally. If they belong to Netty, we can look at it.

Yeah without more details its impossible to help

Closing... there is nothing we can do without more details


Convert production cassandra config to a template with volumeClaimTemplate support

Which problem is this PR solving?

Resolves #54 (Adding support for volumeClaimTemplates to the cassandra statefulset)
Setups the StatefulSet to support scaling up the cluster with persistent volume claims
Conversion to template is required to parameterize things like size and pool names for the PVC

Short description of the changes
The built in cassadnra template doesnt really work with persistent data. Changing it to a template, and introducing volumeClaimTemplate in the StatefulSet makes it so its usable for being able to scaling at all.
That being said apparently according to #30 it doesnt seem like there is a goal of making the cassandra* bits in this repo prod ready?

That being said apparently according to #30 it doesnt seem like there is a goal of making the cassandra* bits in this repo prod ready?

That's correct: we provide the template as a starting point, but we have no intention in getting into the business of providing a production-grade Cassandra installation :-)

Thanks for the PR! Looks good to me, except for a couple of places where it seems a } is missing.

I thought i had caught all of those :/
updated.
my whole point in making this happen was to actually use this as the prod data store because it was already openshift prepared. So i'm a bit torn around what to move forward with :/

my whole point in making this happen was to actually use this as the prod data store because it was already openshift prepared. So i'm a bit torn around what to move forward with :/

You probably know this better than me, but having Cassandra on Kubernetes/OpenShift is tricky, as pods come and go without notice. As far as I understand, this is not a pattern that Cassandra is particularly fond of. @pavolloffay and/or @burmanm can probably give you more details, as they spent more time on it than I have. Besides, at the time we wrote this OpenShift template, there hasn't been any official/supported way of running Cassandra on them, other than a few quick starts/tutorials here and there. This might have changed, though.
In any case, the main point is that we expect users to understand what they are doing with their Cassandra installation and be able to self-support: we can help with the Jaeger parts, but we can't help with the Cassandra parts.

Sorry for taking so long to merge this!

thanks


Search on v2.docusaurus.io returns no results

🐛 Bug Report
On https://v2.docusaurus.io, run a search. No results come back.
Have you read the [Contributing Guidelines on issues]
Yes
To Reproduce

Visit https://v2.docusaurus.io.
Search for "markdown"
No results come back

Expected behavior
Results come back

Actual Behavior
No results come back
Your Environment

macOS 10.15.7
Tried in Safari, Chrome, and Firefox

Reproducible Demo
Search on https://v2.docusaurus.io

Yes me too I found the search completely unusable today. And I think it worked well yesterday.

thanks, should be fixed very soon


Inconsistent/Weird hover behavior with ListViewItemPresenter

Describe the bug
There are 2 inconsistencies I'm seeing.

When CanDragItems and/or CanReorderItems is set to True for the ListView, and you release a click (and presumably any sort of pointer tap event) while still hovering, the hover styling dissapears. This is more noticable when SelectionMode is set to Multiple, and you deselect an item by clicking on it.
Seemingly regardless of any settings on the ListView, releasing a click on a child Button(presumably other controls with pointer tap behaviours) while still hovering also incorrectly removes the hover style

Steps to reproduce the bug

Create a ListView with CanDragItems and/or CanReorderItems and SelectionMode="Multiple" to make this more obvious eg.

    <ListView x:Name="TestListView" CanDragItems="True" CanReorderItems="True" SelectionMode="Multiple" >
        <ListView.ItemTemplate>
            <DataTemplate x:DataType="local:TestData">
                <Grid >
                    <Grid.ColumnDefinitions>
                        <ColumnDefinition Width="*" />
                        <ColumnDefinition Width="Auto" />
                    </Grid.ColumnDefinitions>
                    <TextBlock Text="{x:Bind Name}" Grid.Column="0"/>
                    <Button Content="Test" Grid.Column="1"></Button>
                </Grid>
            </DataTemplate>
        </ListView.ItemTemplate>
    </ListView>

Populate it with data

    public struct TestData
    {
        public string Name;

        public TestData(string name)
        {
            this.Name = name;
        }
    }
    /// <summary>
    /// An empty window that can be used on its own or navigated to within a Frame.
    /// </summary>
    public sealed partial class MainWindow : Window
    {
        public ObservableCollection<TestData> TestDataCollection { get; set; } = new () {
            new ( "Test 1" ),
            new ( "Test 2" ),
            new ( "Test 3" ),
        };

        public MainWindow()
        {
            this.InitializeComponent();

            this.TestListView.ItemsSource = this.TestDataCollection;
        }
    }

Run the app
Depending on which inconsistency:
a) First Inconsistency: Click on an item to select it (technically the bug happens here also, but is more noticable on the next step) and then click again to deselect it, while not moving the cursor
b) And the second: Click the button in the list view item while not moving the cursor

Expected behavior
The ListViewItemPresenter should keep it's hover styling (instead it reverts to nothing)
Screenshots
No response
NuGet package version
WinUI 3 - Windows App SDK 1.3.2: 1.3.230602002
Windows version
Windows 11 (22H2): Build 22621
Additional context
No response

Duplicated with https://github.com/microsoft/microsoft-ui-xaml/issues/3191. It's a bug of ListView


Remove the need to reopen the terminal when installing

Currently whenever I install with chocolatey I need to reopen my terminal as it adds a new variable to the path.
npm doesn't require this as it has a central folder which is in the path which cmd files are added to for each global module. uninstalling removes the cmd from that location.
the cmd in this case would change to the directory where the chocolatey app is installed and run it passing in any args.

Old one that is fixed


2 lines of text in menubar

If you echo text with a small font size, there is space to fill two lines with text. Is there a standard option for this, or could this be a possible feature on the roadmap?

Related: https://github.com/matryer/xbar/issues/617


go-grpc-string-input-client

go-grpc-string-input-client

Hello, thanks for the PR. Can you follow guidelines from contributing to Triton for your PR? Namely tests and CLA

Hello, thanks for the PR. Can you follow guidelines from contributing to Triton for your PR? Namely tests and CLA

Thanks for your reply. I'll study it later


Perf: Sequential read from DbDataReader

Duplicate of https://github.com/aspnet/EntityFrameworkCore/issues/885


Independence and marginals in DiscreteDistribution

This is not an issue or bug, but rather a desired feature that I think would make our lives easier and more elegant.
It would be useful if multivariate discrete distributions had:

A property telling us whether its dimensions are independent.
A method to extract joint distributions of subsets of its dimensions. E.g., if I have the joint distribution of permanent shocks to income, transitory shocks to income, and risky returns ShkDstn, it would be useful to be able to do something like InkShkDstn = ShkDstn.marginal(dims=[0,1]).
A method to determine whether its dimensions are independent. Since we are dealing with discrete distributions, this should be easy.

What is the value of all this?
1. Redundancy reduction: IndShockConsumerType currently tracks IncShkDstn, TranShkDstn, and PermShkDstn. It'd be good if we kept track of a single object.
2. In-code determination of the methods/speedups that can be used: Harmenberg's method works only if permanent shocks are independent from all other shocks (I think); a portfolio problem can be solved much more quickly if the return factor is independent of other shocks. Currently we ask the user to tell us whether these things are true with arguments like IndepDstnBool. If would be good if the user could simply give us a joint distribution of shocks and we figured out the rest.
3. The above point would help to reduce hard-coded features and make things more modular: IndShockConsumerType knows its shocks are independent because we have hard-coded its income process. If we want to move towards a world where we can pass an income distribution constructed elsewhere, we have to be able to determine the properties of that distribution, for the reasons above.

@Mv77,
This is a perfect example of the reason I've been advocating for a long time that we should simply adopt one of the sophisticated external architectures that already exist for handling distributions.  All of them have built in ways for doing these and all the other kinds of sophisticated things one might want to do with distributions.  In my mind, the two leading candidates are TensorFlow and sympy though pytorch might be an option as well, and stan seems to have a big following.
I've asked @nicksawhney to familiarize himself with the way Mathematica does these things (partly because there are very good tutorials, and because as best I can tell, sympy and TensorFlow implement much the same set of ideas in slightly different ways.
One crosscutting point that would apply whatever method we adopt:  If we want to allow our shocks to be correlated, then at the simulation stage it will probably be best to draw all the shocks simultaneously at the beginning of the 'period' in which they are all realized.  And probably for the solution procedure it would make sense to define the abstract mathematical description of the shocks at the same point.  The only argument against this that I can think of is that we might be solving a problem in which some of the shocks are contingent on conditions that may not matter.  Like, if the person is not employed, then it would be a waste of computational resources to draw the shocks for the covariance of their income-if-employed with the rate of return.  Still, the generality and simplicity of drawing all the shocks at once seems compelling -- especially since that's what Pablo does in Dolo and whenever we don't have a strong reason to do things differently from Dolo I want to adopt Pablo's choices.
One other subtlety is the desirability of distinguishing between draws of aggregate shocks (like the rate of return) and idiosyncratic shocks (like employment income).  This probably militate for specifying the aggregate shock process as an input to the individual's problem, and then specifying the individual's shocks as marginals contingent on the aggregate shocks.
@nicksawhney, @sbenthall, @alanlujan91

@Mv77 I agree that this would be good functionality.
@llorracc I agree that the best way towards this is to see if we can get it from an imported library.
As we've discussed, I think the practical blocker to experimenting with alternative Distribution implementations is #1105. Once that is done, it should open up a lot of possibilities.
I've made been using this issue label for tickets related to the Distribution architecture.
Once #1105 is completed, I would recommend systematically:

listing all the features we use and anticipate using for distributions.
going through the various libraries and checking off, for each one, which of those desired features it supports

I've begun a wiki page to address this and other issues about possible use of external libraries for probability distributions.
https://github.com/econ-ark/HARK/wiki/Distribution-Libraries
I'd like us to use it to:

Python libraries that have an existing representation of probability distributions
Features we want in HARK for our distribution objects

For now, we can build these lists out separately, and should not let either list bias the creation of the other.
Later, we can survey across the two lists and see which libraries get us the farthest to our goals.


add representation support STRUCT,LIST & related types

When we began work on Rill Developer, the node bindings didn't even have STRUCT and LIST support, so we didn't prioritize making representations for these. This GH issue codifies the work needed to be done to support complex / nested types as reps.

table representation – stringify the JSON as a starting point.
icon – this should be straightforward, but it's worth it for us to add the right icons for htis.
details – we'll opt to leave out the detail or see if top k works as expected.

It turns out the top k does kind of work, but the query seems to coerce to VARCHAR first. See #1708 for progress on changing that. If we can't for some reason, we'll figure out how to make do with the representation being .toString-ified first. It's more of a problem for LIST than other nested types since we can't do much with the representation.


Question about Quantization Fn in DoReFa

Hi there -- question about the the quantization function to k-bit in DoReFa-Net:
1/(2^k - 1) * round((2^k - 1) * r_i)
where r_i is the input.
Why do the (2^k - 1) scaling? Why would bit shifting (just scaling by 2^k) do the same job?
Thanks!

k bits can represent 0...2^k - 1, not 0...2^k

Ah, yup, of course.


Add put to Client,  update profile module to have update

@rubygeek Released to RubyGems as version 0.2.2


[174] Feed page styling desktop

PR Checklist:
Hey there! It's great to have you here. Here's a quick checklist to help you make a shiny PR:

[x] Have you checked out the guidelines in our Contributing document?
[x] Have you looked if there might be other open Pull Requests for the same update/change?

Quick Description of the PR
https://github.com/FightPandemics/FightPandemics/issues/174 - Feed page UI styling for desktop.
An Overview of the Changes
Created components and updated current styles.

The changes to the Navbar may be out of scope for this PR ? #332 was working on the two files related to the Navbar

Sidebar is fixed and navbar must be edited to be fixed too. Changes were updated to the current header.

Reviewed the last comments.

Reviewed the last comments.

Hmm, I still see the last two issues? Did you push your changes?

Yes, changes were uploaded.

Yes, changes were uploaded.

@silenceway I still see the issues but I think the code looks good to merge for now. If anyone points out those issues we can work on them in another PR since this PR is getting pretty messy with lots of comments. Thanks so far for your work!


Add python 3.8 and 3.9 support

Please add python3.8 and 3.9 support in future version. IMHO a minor modification of CPythonAPI.scala is enough.

I'm definitely planning to do this soon! Hoping to switch to GitHub actions, which will allow us to have a much wider matrix so that we can test support with all these Python versions.

I'm definitely planning to do this soon! Hoping to switch to GitHub actions, which will allow us to have a much wider matrix so that we can test support with all these Python versions.

I'm definitely planning to do this soon! Hoping to switch to GitHub actions, which will allow us to have a much wider matrix so that we can test support with all these Python versions.

Great job! Waiting for the update.

I'm definitely planning to do this soon! Hoping to switch to GitHub actions, which will allow us to have a much wider matrix so that we can test support with all these Python versions.

Great job! Waiting for the update.

I've try to compile a modified version(change "3.7" to "3.9" in CPythonAPI.scala) for python 3.9 but I failed. It's weird that the modified version can not locate python library.
Btw, both test environment are based on conda-env management, the only different is python version.

I've try to compile a modified version(change "3.7" to "3.9" in CPythonAPI.scala) for python 3.9 but I failed. It's weird that the modified version can not locate python library.
Btw, both test environment are based on conda-env management, the only different is python version.

Update:
Under correct setting of SCALAPY_PYTHON_LIBRARY and LD_LIBRARY_PATH, python3.8 works properly, but python3.9 still malfunction.

Update:
Under correct setting of SCALAPY_PYTHON_LIBRARY and LD_LIBRARY_PATH, python3.8 works properly, but python3.9 still malfunction.

https://github.com/shadaj/scalapy/pull/139 :) there's indeed a breaking API change in Python 3.9 that crashes ScalaPy, but I'm working on fixing it right now!

https://github.com/shadaj/scalapy/pull/139 :) there's indeed a breaking API change in Python 3.9 that crashes ScalaPy, but I'm working on fixing it right now!


modules: mbedtls: add mbed debug dependency to its Kconfig

Debug function pointer in MbedTLS will not be set if not
sockets log level is debug (see [sockets_tls:412)
https://github.com/zephyrproject-rtos/zephyr/blob/8e75fff5808f0af0e8de941f6a5d77de72962b0b/subsys/net/lib/sockets/sockets_tls.c#L411-L413

I don't think this is the right approach - mbedTLS is a standalone module and should not be dependent on the socket layer.

The module is not dependent on it; only its debug prints which is actually the truth since it's some LOG_DBG call in sockets_tls that prints the messages from mbedTLS. No LOG_DBG in sockets_tls, no debug msg from mbedTLS.
As it is now, people will enable CONFIG_MBEDTLS_DEBUG and expect mbedTLS debug prints to come out but nothing happens (which is what just happened to me). At least now they will get an error and be able to fix it.

Maybe let's move tls_init outside of socket_tls.c, remove #if (CONFIG_NET_SOCKETS_LOG_LEVEL >= LOG_LEVEL_DBG) part and hardcode LOG_LEVEL_DBG whenever CONFIG_MBEDTLS_DEBUG is selected? At some point we add log level mapping between mbedTLS and Zephyr's logging, so that mbedTLS logs would be more readable (especially errors and warnings).

The module is not dependent on it; only its debug prints which is actually the truth since it's some LOG_DBG call in sockets_tls that prints the messages from mbedTLS. No LOG_DBG in sockets_tls, no debug msg from mbedTLS.

This is exactly what I understand as adding sockets dependency to the mbedTLS - what if someone wanted to use mbedTLS w/o socket layer and enable debug logs in it (and provide his own debug handler, note that the debug log function is registered per TLS context). It won't be possible with such approach.

As it is now, people will enable CONFIG_MBEDTLS_DEBUG and expect mbedTLS debug prints to come out but nothing happens (which is what just happened to me). At least now they will get an error and be able to fix it.

If that's an issue then I think it should be solved in a different way. At very least, we could bump the default socket log level to DEBUG if MBEDTLS_DEBUG is enabled. But I think that a better solution would be decoupling the mbedTLS logs from socket layer logs, i. e. register a separate LOG instance for mbedTLS with its own log level (there already is a log level specified for mbedTLS), and then register the log handler in the TLS context independently from CONFIG_NET_SOCKETS_LOG_LEVEL.

The module is not dependent on it; only its debug prints which is actually the truth since it's some LOG_DBG call in sockets_tls that prints the messages from mbedTLS. No LOG_DBG in sockets_tls, no debug msg from mbedTLS.

This is exactly what I understand as adding sockets dependency to the mbedTLS - what if someone wanted to use mbedTLS w/o socket layer and enable debug logs in it (and provide his own debug handler, note that the debug log function is registered per TLS context). It won't be possible with such approach.

As it is now, people will enable CONFIG_MBEDTLS_DEBUG and expect mbedTLS debug prints to come out but nothing happens (which is what just happened to me). At least now they will get an error and be able to fix it.

If that's an issue then I think it should be solved in a different way. At very least, we could bump the default socket log level to DEBUG if MBEDTLS_DEBUG is enabled. But I think that a better solution would be decoupling the mbedTLS logs from socket layer logs, i. e. register a separate LOG instance for mbedTLS with its own log level (there already is a log level specified for mbedTLS), and then register the log handler in the TLS context independently from CONFIG_NET_SOCKETS_LOG_LEVEL.

Ah yes I understand, you are right. We can't use mbedTLS without socket layer as it is now. I agree with you, we need to decoulple it. I'll look at it this weekend.

register a separate LOG instance for mbedTLS with its own log level (there already is a log level specified for mbedTLS), and then register the log handler in the TLS context independently from CONFIG_NET_SOCKETS_LOG_LEVEL

Yes, this is actually the best option here.

Please see updated branch.
If I build echo_client sample with
west build -b stm32h747i_disco_m7 zephyr/samples/net/sockets/echo_client/ -- -DCONF_FILE="prj.conf overlay-tls.conf"

and the prj.conf from below (and no echo server to provoke errors and warnings) I can see that mbedtls debug messages comes out. I have also verified log level filtering works (as in, if I set CONFIG_MBEDTLS_DEBUG_LEVEL=3 we will only see error, warning & info).
Please note that:

I have kept mbedtls_debug_set_threshold(CONFIG_MBEDTLS_DEBUG_LEVEL); in sockets_tls.c since this is a global setting among all mbedtls contexts.
I changed the default CONFIG_MBEDTLS_DEBUG_LEVEL to 3 since as a user I'd expect some kind of logs to come out if I enable CONFIG_MBEDTLS_DEBUG (which is default n so no debug messages will come out anyways if you don't enable this explicitly).

# Generic networking options
CONFIG_NETWORKING=y
CONFIG_NET_UDP=y
#CONFIG_NET_TCP=y
#CONFIG_NET_IPV6=y
CONFIG_NET_IPV4=y
CONFIG_NET_SOCKETS=y
CONFIG_NET_SOCKETS_POSIX_NAMES=y
CONFIG_NET_SOCKETS_POLL_MAX=4
CONFIG_NET_CONNECTION_MANAGER=y

# Kernel options
CONFIG_MAIN_STACK_SIZE=2048
CONFIG_ENTROPY_GENERATOR=y
CONFIG_TEST_RANDOM_GENERATOR=y
CONFIG_INIT_STACKS=y

# Logging
CONFIG_NET_LOG=y
CONFIG_LOG=y
CONFIG_NET_STATISTICS=y
CONFIG_PRINTK=y

# Network buffers
CONFIG_NET_PKT_RX_COUNT=16
CONFIG_NET_PKT_TX_COUNT=16
CONFIG_NET_BUF_RX_COUNT=80
CONFIG_NET_BUF_TX_COUNT=80
CONFIG_NET_CONTEXT_NET_PKT_POOL=y

# IP address options
#CONFIG_NET_IF_UNICAST_IPV6_ADDR_COUNT=3
#CONFIG_NET_IF_MCAST_IPV6_ADDR_COUNT=4
CONFIG_NET_MAX_CONTEXTS=10

# Network shell
CONFIG_NET_SHELL=y

# The addresses are selected so that qemu<->qemu connectivity works ok.
# For linux<->qemu connectivity, create a new conf file and swap the
# addresses (so that peer address is ending to 2).
CONFIG_NET_CONFIG_SETTINGS=y
#CONFIG_NET_CONFIG_NEED_IPV6=y
#CONFIG_NET_CONFIG_MY_IPV6_ADDR="2001:db8::2"
#CONFIG_NET_CONFIG_PEER_IPV6_ADDR="2001:db8::1"
CONFIG_NET_CONFIG_NEED_IPV4=y
CONFIG_NET_CONFIG_MY_IPV4_ADDR="<IP_ADDRESS>"
CONFIG_NET_CONFIG_PEER_IPV4_ADDR="<IP_ADDRESS>"
CONFIG_MBEDTLS_DEBUG=y
CONFIG_LOG_STRDUP_BUF_COUNT=100

Additionally, the commit message has typo:

modules: mbedtls: move mbedTLS logginq to separate module

Some additional suggestions.
@emillindq, what's the status of this PR?

The status is that I'm hoping to get time to complete it very soon (will try this weekend). The plan is to implement https://github.com/zephyrproject-rtos/zephyr/pull/32473#discussion_r592994470 and I've gotten quite a way already. If anybody wants to finish it, please do.

@emillindq

The status is that I'm hoping to get time to complete it very soon (will try this weekend). The plan is to implement #32473 (comment) and I've gotten quite a way already. If anybody wants to finish it, please do.

That's good plan. Otherwise, just a friendly ping that 2.6 pre-release freeze in coming up (1-2 weeks, not sure), during which it may be harder to merge changes (e.g. may need to wait for reopening merge window for the next release).

Unfortunately I'm not sure when I'm going to be able to complete this. I encourage somebody else to continue where I left off, but in the meantime I'm closing this as this is a non-critical thing as long as you know to enable the right configs.


Purchase with "Slow test card. Approves after a few minutes" triggers 2 consecutive succesful event on purchaseUpdatedListener

Version of react-native-iap
4.5.2
Version of react-native
0.62.0
Platforms you faced the error (IOS or Android or both?)
Android
Expected behavior
When making a consummable purchase with "Slow test card. Approves after a few minutes", I expect to receive 1 success event on the purchaseUpdatedListener
Actual behavior
2 events are send (~100ms apart), with 100% identical data
(I did not test with a non-consummable purchase, neither for subscriptions, as my app does not include any)
Tested environment (Emulator? Real Device?)
Real Device
App published in closed alpha track
Licensed tester account (to get access to the fake card)
Steps to reproduce the behavior
As stated above:

make a consummable purchase with a "Slow test card. Approves after a few minutes" card
either keep the app opened or not during the process
the callback you passed to purchaseUpdatedListener will be called twice

Thanks for the great lib!
Hopefully I could get some time soon to investigate further

since I have been calling initConnection & consumeAllItemsAndroid on mount, I am unable to reproduce the issue. Maybe worth adding initConnection in the README examples?

@AmauryLiet  I am also calling initConnection & consumeAllItemsAndroid on mount . I am still facing this issue


Remove CodeQL from presubmits?

I've never seen it catch anything, ever, and it takes the longest out of all of our tests.

I agree, codeql usually does not find stuff. But it is that one time that you miss it catches. Usually, the codeql tests aren't this slow for PR.
But I vote for not removing it. It is a security feature and for this project it is critical.
Here is an example of it caught an issue https://github.com/ossf/scorecard/commit/b278475af0c79b6c43139934b29a575961d44a37

Maybe make this a daily scheduled job rather than PR?

Maybe make this a daily scheduled job rather than PR?

But how do you catch bad code in PR?

But how do you catch bad code in PR?

Yeah, it would only be daily. This is only useful if you recommend people work on releases or at least a couple days before latest. I think pinning at latest revisions is bad practice anyway.
Other alternative: only build some portion of the code based on the diff.

I think we actually already have it daily: https://github.com/sigstore/cosign/blob/main/.github/workflows/codeql-analysis.yml

But how do you catch bad code in PR?

Yeah, it would only be daily. This is only useful if you recommend people work on releases or at least a couple days before latest. I think pinning at latest revisions is bad practice anyway.

☝ Sorry, I don't get it.

Other alternative: only build some portion of the code based on the diff.

Sorry, I don't get it.

If it were daily you can still catch and fix regressions within a short window 1-2 days. As long as people aren't running directly at head this doesn't expose them to the issue.
I see. Looks like it's on both daily and PR.

Sorry, I don't get it.

If it were daily you can still catch and fix regressions within a short window 1-2 days. As long as people aren't running directly at head this doesn't expose them to the issue.
I see. Looks like it's on both daily and PR.

Thanks, I understand. That means someone has to manually look at the issue in the Security center and do PR for the fix. If it is missed then we run into an issue of opening a security hole.


Fixing avatar presence cutout position in RTL languages.

Platforms Impacted

[x] iOS
[ ] macOS

Description of changes
Despite the fact that the Avatar leverages from the SwiftUI framework support for RTL, the presence cutout is positioned in the view by calculated coordinates that are not taking RTL languages into consideration.
This change fixes this issue by allowing independent X and Y coordinates for the cutout and flips the calculation for the X coordinate in case the language is RTL.
Verification

Before
After

Pull request checklist
This PR has considered:

[x] Light and Dark appearances
[x] iOS supported versions (all major versions greater than or equal current target deployment version)
[ ] VoiceOver and Keyboard Accessibility
[x] Internationalization and Right to Left layouts
[ ] Different resolutions (1x, 2x, 3x)
[ ] Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
[ ] iPad Pointer interaction
[x] SwiftUI consumption (validation or new demo scenarios needed)
[ ] Objective-C exposure (provide it only if needed)

Microsoft Reviewers: Open in CodeFlow

Confirmation we should flip in RTL? Good to know..


How would this be used with a Hapi powered API?

I currently use JWT, how would I use this instead as it seems a better option for the static/server-side generation aspect of NextJS.

Hi @bonbonio, are you using HAPI? If so then https://github.com/hapijs/yar would be the way to achieve what you want.
If I misunderstood your question just let me know. Thanks

Hi, this looks like it, thank you.
Is iron still very new? I am having trouble finding much in the way of examples; but it seems to solve the problem of allowing a user to authenticate in my App, and avoid the need for the getInitialProps in _app.jsx to work.
Are there any other good resources/tutorials for this? Perhaps they could be added to this projects docs too - if this is stated to be the best practice auth for NextJS I feel that would rapidly help people adopt it.
Many thanks though, I think I can dig through yar now.

Hi there, I am not sure to fully understand if you're a user of Next.js or HAPI but:

There's a full example on how to use this module with Next.js: https://github.com/vvo/next-iron-session/tree/master/examples/next.js
If you're using Hapi, then you should not use this module but rather https://hapi.dev/family/yar/api/
This module does not handle user registration, only user authentication, that is: once you know who your user is, save this information in a session to then be able to read it again from session

Good luck!

Hi @vvo , I need to reopen this.
To clarify; as I think you misunderstood my responses. I use NextJS and Hapi, one for FE and one for the API.

I read through the example numerous times before posting. I tried both @hapi/yar and @hapi/cookie; I am currently using Yar, but I will switch to cookie later as its supported as an auth strategy in Hapi (This is what i mentioned above).
I do also understand this module doesn't handle registration!
I have a fully functional site and api using JWT auth but I want to replace it with iron-sessions so I can get rid of the getInitialProps method in my _app.jsx.

So with the clarify of that preamble;
I am hitting so many hurdles, this library feels like a solution, but I am surprised that NextJS can have it as best practice authentication when there is minimal documentation – and it would appear a considerable number of gotchas. So I want to help work them out with your help, to fix my issues and then document them for others.
The API is Hapi runs (locally) on http://<IP_ADDRESS>:4000, and I a using Yar to set a cookie, and I see the response with the header set-cookie. The following is my yar configuration.
hapi; index.js
 {
      plugin: require('@hapi/yar'),
      options: {
        storeBlank: false,
        cookieOptions: {
          password: '32-bit-string-password',
          isSecure: process.env.NODE_ENV === 'production',
        }
      }
    }

The NextJS App runs on the typical dev port <IP_ADDRESS>:3000
The header response from the API for /login returns;
Set-Cookie: session=blah

The NextJS site fetches the API using a service wrapped around axios, but the cookie does not get set at the client side when I view dev tools on Chrome/Safari/Firefox as I heard someone mention that chrome doesn't like session cookies on ports but that doesn't appear to make any difference as yet.
It might be worth you providing an example of NextJS authenticating with a Hapi API, or we can post all my code when its working, but my current issue is that the session cookie is not set by NextJS. I am unsure if the issue is axios, NextJS or the browser policies for such domains, but I assume you use the same port locally for your own next installation.
I am intending to write a very complete guide for others to follow, as I feel that NextJS using this authentication method with a Hapi API would be a very common use case - it is just very problematic!


Change deformers to an ordered dict

This way, each transformer can have its own specified order of operations.

Done. b4744dc26c0fdce40df295dd48b7e951decac10f


Gradle 7.5 Javadoc plugin is broken for multi-module aggregation (due to setting --source-path)

Expected Behavior
Javadoc task should set only --module-path, and not also --source-path when modularity is enabled.  The --module-source-path switch must be used to properly generate multi-module aggregated javadocs, but is strictly mutex with --source-path.
Current Behavior
In Gradle 7.4 and earlier, I was able to generate a proper aggregated multi-module javadoc by using:
        options.addStringOption('-module-source-path', './*/src/main/java/')

This worked because gradle was adding only --module-path (thanks to modularity.inferModulePath).
In Gradle 7.5, the same task fails with:
  error: cannot specify both --source-path and --module-source-path

This error happens because of a bit of new code which got added in Gradle 7.5, which explicitly sets --source-path for modular projects.  I believe that is incorrect behavior, at least for my project's specific case.
The code I referred to is from this commit:
https://github.com/gradle/gradle/commit/abacb6729a00ea4992341c38909a443a9d52c437
I can manually run javadoc tool successfully by manually removing the --source-path line from the generated javadoc.options file.  However I cannot find any way to easily automate this as a workaround, because Gradle does not have any feature for post-processing of the javadoc.options file for workarounds.
Context
This regression prevents upgrade beyond Gradle 7.4.
Steps to Reproduce
Create a task of type Javadoc which includes sources from multiple modular projects.
Your Environment
Gradle 7.5

The code I referred to is from this commit:
https://github.com/gradle/gradle/commit/abacb6729a00ea4992341c38909a443a9d52c437

This is vaguely similar to #2357, except for javadoc instead of javac.

As a related note, it would be nice if Gradle could be extended in the future to automatically add --module-source-path as needed for aggregated multi-module javadoc generation.  But in the meantime, it is easy enough to workaround.

Also vaguely related: https://github.com/java9-modularity/gradle-modules-plugin/issues/128

(Apologies for accidentally filing this as "bug" instead of "regression", since it is clearly a regression.)

@tcfurrer Any chance you could provide a minimal reproducer that illustrates the problem?
You can use the following as a base for your reproducer: https://github.com/gradle/gradle-issue-reproducer

FWIW the css4j-dist project is affected by this. With Gradle 7.5:
$ git clone https://github.com/css4j/css4j-dist.git
$ cd css4j-dist
$ gradle mergedJavadoc
Starting a Gradle Daemon (subsequent builds will be faster)

> Task :mergedJavadoc FAILED
error: cannot specify both --source-path and --module-source-path
1 error

FAILURE: Build failed with an exception.

But if you run mergedJavadoc with the wrapper (7.4.2 currently) it works.

@ljacomet Yes I can work today on providing a minimal reproducer using that template.

@tcfurrer See the #21442 which is a minimal fix. If you can confirm it works on your project, that would be great. I no longer need a minimal reproducer as I was able to craft a test.

Minimal reproducer is here, nonetheless: https://github.com/tcfurrer/gradle-issue-reproducer-21399

I grabbed the build artifacts from #21442 and tried them on my original full project. Fix looks good there.

We decided to  fix this by reverting the fix for #19726 which has a number of issues. See #21446.

Revert has been merged, behavior in 7.5.1 will match 7.4.2


chore: eslint update with jsdocs added

Todo

Update docs with new types
Implement server options to select which server of the swagger file to use with servers.url
Copy paste client.ts from @kubb/swagger-client/client if no custom client is set in @kubb/swagger-client

Codecov Report

Merging #277 (43652db) into main (aa47912) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #277   +/-   ##
=======================================
  Coverage   86.21%   86.21%
=======================================
  Files          66       66
  Lines        3844     3844
  Branches      471      471
=======================================
  Hits         3314     3314
  Misses        529      529
  Partials        1        1

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[Feature Request] Add a Results Tab for Viewing Outputs in Gradio Demo

[todo] Add a Results Tab for Viewing Outputs in Gradio Demo

Scrap the plan


Doc for KRM function in Kustomize

kpt functions have been rebranded as KRM Config Functions
This means changes in the kustomize repo, the kpt repo,  the kpt function catalog and the kpt typescript sdk repo.

Docs in Kustomize repo don't mention kpt. No need to update.

Close this issue. Will create another issue for other repos.


-Add JumpMarks to Xcode plugin section

This Xcode plugin allows for easy navigation of code files as documented in https://github.com/merrickp/JumpMarks

Thanks!


[Bug] incorrect dataGroupId for old data items in universalTransition

Version
5.3.0
Link to Minimal Reproduction
https://codepen.io/tyn1998/pen/GRxpgQq
Steps to Reproduce

visit my codepen url above
click "Animals" bar (universalTransition animation works)
click "Back" (not works)
comment line 12 dataGroupId: "", and repeat 2 and 3 they both will work

Current Behavior
Hi, Echarts core team!
I have read the related source code so I know where the problem occurs.
https://github.com/apache/echarts/blob/89d57f21b7eabfcc6770447f6cf6a20a8f406585/src/animation/universalTransition.ts#L210
When processing old data items, after executing this line, dataGroupId is wrongly assigned to a value that is belong to new data items, which is due to the factor of having notMerge default set to false when .setOption(newOption).
This bug will not be exposed when data item's groupId is specified.
Expected Behavior
Old data items should be given correct dataGroupId when item.groupId is not specified.
Environment
- OS: macOS Monterey
- Browser: Chrome 103
- Framework: None

Any additional comments?
N.A.

which is due to the factor of having notMerge set to false when .setOption(newOption).

Can be supported by another case in

Complement:
if Echarts cannot find dataGroupId in series, it will try to find it in parent model:
https://github.com/apache/echarts/blob/7f3b2ba4d2f4f77c70b51a8e1bb0b227ca197df0/src/model/Model.ts#L234-L239

closed via #17559


[Publisher] Improvement needed with the listing of the created scopes

Once scopes are created for a given API, these created scopes are not shown in any order (looks to be random). One such example is shown below, where the order of creation of scopes are: "Scope 1", "Scope 2", "Scope 3", "Scope 4", "bar". But as shown below, they are not listed in any order.

+1 to sort the scopes by 'Name' by default.


Current project status

Hi, what is the current status of this project? Is it still maintained?

Current project status is that I still maintain this repo.
No feature development only bug fixes tho...
Why are you asking?

Well, I guess you already saw the numerous open issues and PRs. Can you need some help with them?


Cannot connect to Opensearch dashboard

I am using OpenSearch with docker compose file.
Both services (5601 & 9200) are working fine.
But when I try to  add volume in OpenSearch-dashboard service, dashboard is not reachable.

Can please anyone help!

[Triage] Hey @VartikaSharma14 ,
Can you take a look at the docker-compose from our website https://opensearch.org/samples/docker-compose.yml for reference? If it still does not work can you post your docker-compose file here so that we can take a look?
Thanks!

Hello, @VartikaSharma14, I am closing this issue for now, and please open a new issue/re-open it if you are still facing difficulties .. thank you!


Questionnaire Builder strips out whitespace in question description

When constructing a questionnaire, this can produce unexpected behavior.
@rahul1 if you could provide repro details, that would be appreciated.


Add skeleton and stubbing

Been looking through Go conventions and looking at how Google and MongoDB does their file structuring. Seems everything is in lower case for filenames and they use a _. e.g., crypto_hasher.go.

Updated file names

1- For naming conventions, I see:

If the functions with names that start with an uppercase letter will be exported to other packages. If the function name starts with a lowercase letter, it won't be exported to other packages, but you can call this function within the same package.

Reviewed all function names and updated exportable functions accordingly.

There are some new and New let's make sure they are all correct.

Updated.

2- In some structs, you've used anonymous fields, I personally think it makes it easier to read the code if we have name for all the fields.

Some structs have anonymous fields for the purpose of embedding,
eg:
type structSerializer struct { 	baseSerializer ... }
structSerializer is embedding baseSerializer so it 'inherits' baseSerializer's functions

Generally looks good; a couple overall thoughts:

remove "2020" from copyright headers

Removed.

now's a good time to agree on some consistent approach to code formatting (e.g., spacing in function signatures varies a bit in this PR)

Applied code formatting (gofmt)

if we're following amzn/ion-go#12, a number of HashReader's / HashWriter's functions are part of an Event, which should allow the HashReader/HashWriter interfaces to be simpler

Currently we are basing on the fernomac APIs, once the PR ^ is approved, we will update accordingly.


Get marker info on drag end.

Hi!
Is possible get the marker´s information when I finish drag?
My code:
Html
<map center="{{center.lat}},{{center.lon}}"
      zoom="15"
      disable-double-click-zoom="true">
        <marker ng-repeat="info in information"
        position="{{info.lat}}, {{info.lon}}"
        on-click="showInfoWindow(event, info)"
        animation="DROP" draggable="true"
        on-dragend="onDragEnd($event,info)"
        icon="./assets/svg/mark.svg"></marker>
</map>

Javascript
$scope.onDragEnd = function($event,info) {
       console.log($event); // Here I get the latLng
       console.log(info); // undefined
   };

Yes, try this with plunker, and provide me the plunker example if it does not work

$scope.onDragEnd = function($event) {
console.log($event); // event
console.log(this.info); // marker
};

this was helpful for me, thaks

This might be totally off to this issue but how do I access $scope variables inside callback functions. In this case onDragEnd. Is this because callbacks run outside the scope of angular?


Add stream email to stream/create event.

For each stream we make a long email address that people can use to send messages to Zulip streams via email.
For some reason we don't include this in the stream/create event, which has the effect that we don't see it in the UI.  (The UI is doing the right thing for the data it gets.)
We should add the email data to the stream/create event.  The only thing that's slightly complicated here is that we need to encode the email address.  You can look for code related to encode_email_address.
We'll want automated tests for this code, of course.

@showell Can I give this a try?

Yep!

So, I'll start working on this!

So, I noticed some things in regard to this issue:
This problem is not there in the development environment, in the sense that, on stream creation, email address does not show up, but on refreshing the page, the page has stream email address.
Secondly, on clicking the create button, the first thing that happens, even before bulk_add_subscriptions is called in add_subscriptions_backend (in views/streams.py) (which is called via /users/me/subscriptions endpoint), send_stream_creation_event in actions.py is called (which I cannot track from where is that function is being called) because send_stream_creation_event is directly called only for invite only streams and in function create_stream_if_needed.
Nevertheless, I tried adding email_address (with encoding) in send_stream_creation_event, but still in server_events_dispatch, the email_address property is being shown as undefined (why?). Another thing to note is that, send_stream_creation_event does not have the email_address field.
@showell Can you please guide me here, if I am missing something. :)

Your first finding isn't surprising.  The email is being created in the database, it's just not getting sent in an event that users can see.  (When you refresh the browser later, you receive the email through a different codepath.)
I think you're right that I may have been wrong to look at send_stream_creation_event.  Apparently we send a lot of stream info in notify_subscriptions_added, which sends a subscription/add event.  This eventually takes us to stream_events.mark_subscribed.


Repo cloned by FSI OSPO

Hello,
This repo has been cloned by the NatWest Group Open Source Program Office who will feedback upon internal review.
Thank you for contributing the industry accelerator.
James.

Awesome @mcleo-d - we're happy to support if you have any questions 💚


Removing PK FK guidance as not relevant to Warehouse in Fabric

Thank you for contributing to Microsoft Fabric documentation
Fill out these items before submitting your pull request:
If you are working internally at Microsoft:
Provide a link to an Azure DevOps Boards work item that tracks this feature/update.

Email request from Xiaoyu Li to make the page update

Who is your primary Skilling team contact? @mention them individually tag them and let them review the PR before signing off.

??

For internal Microsoft contributors, check off these quality control items as you go

[ ] 1. Check the Acrolinx report: Make sure your Acrolinx Total score is above 80 minimum (higher is better) and with no spelling issues. Acrolinx ensures we are providing consistent terminology and using an appropriate voice and tone, and helps with localization.

[ ] 2. Successful build with no warnings or suggestions: Review the build status to make sure all files are green (Succeeded).

[ ] 3. Preview the pages:: Click each Preview URL link to view the rendered HTML pages on the review.learn.microsoft.com site to check the formatting and alignment of the page. Scan the page for overall formatting, and look at the parts you edited in detail.

[ ] 4. Check the Table of Contents: If you are adding a new markdown file, make sure it is linked from the table of contents.

[ ] 5. #sign-off to request PR review and merge: Once the pull request is finalized and ready to be merged, indicate so by typing #sign-off in a new comment in the Pull Request. If you need to cancel that sign-off, type #hold-off instead. Signing off means the document can be published at any time. Note, this is a formatting and standards review, not a technical review.

Merge and publish

After you #sign-off, there is a separate PR Review team that will review the PR and describe any necessary feedback before merging.
The review team will use the comments section in the PR to provide feedback if changes are needed. Address any blocking issues and sign off again to request another review.
Once all feedback is resolved, you can #sign-off again. The PR Review team reviews and merges the pull request into the specified branch (usually the main branch or a release- branch).
From the main branch, the change is merged into the live branch several times a day to publish it to the public learn.microsoft.com site.

#sign-off

#sign-off

@XiaoyuMSFT
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off

Merging per email request from @WilliamDAssafMSFT.
@SQLAdventurer - in the future, open PRs in the private repo, fabric-docs-pr, to be able to sign off.
Thanks!


scroll is not working in firefox

scroll is not working in firefox for all booking page and it dosen't scroll completely to the bottom for articles detail.
@kantord found a possible cause https://stackoverflow.com/questions/28636832/firefox-overflow-y-not-working-with-nested-flexbox/28639686#28639686

I think that is working perfectly 💯


ProtectedConfigurationBuilder value contains escaped (doubled up) backslashes

Hi,
Thanks for the work.
Was creating a test project to encrypt JSON files using Nuget version 1.0.5 and noticed that double backslashes in the unencrypted value (\\) are encrypted successfully but are returned as escaped backslashes when accessed in the ProtectedConfigurationBuilder (\\\\)
This is especially important when using connection strings and trying to store a Server\\Instance value
e.g.
Unencrypted in appSettings.json
{   "ConnectionStrings": {     "DatabaseConnectionString": "Protect:{Server=(LocalDb)\\MSSQLLocalDB;}"   }
The decrypted value In code from the ProtectedConfigurationBuilder is Server=(LocalDb)\\\\MSSQLLocalDB; and I would expect it to be Server=(LocalDb)\\MSSQLLocalDB;

Turns out this behaviour is in the DataProtect Protect / Unprotect. Closing

Hi,
sorry for the late reply, but I was busy, you were right there was a bug, the backslash was double escaped, not due to DataProtect Protect /  Unprotect but instead due to Regex which escapes some special characters (among which there is the obvious backslash, see Regex.Escape function) when extracting groups value. To solve this I had just to use Regex.Unescape function before encrypting any value extracted from the regex, I am releasing package version 1.0.6 shortly with the fix (see the screenshot below).
Thank you very much for using and testing my package and for having raised a bug which I didn't notice.

Thanks for the update. I’ll keep an eye out for the 1.0.6 version.

Give me some more time, while testing now I understood the real problem, it is the encryption of json and xml files....basically I read both of them just by using File.ReadAllText which gets the raw characters without decoding the format of the particular file (in JSON \ must be double escaped, in XML < must be replaced by <) so to read these files I can't simply use File.ReadAllText

I have just published the new version 1.0.6 of the package, the bug should be fixed now as the ProtectFiles method should decode all input files according to their format (JSON and XML are supported for now, but I added also an extension point in order to allow anyone to support any other format they need, see ConfigurationBuilderExtensions.FilesDecoding public property).
Test it when you have time and let me know if everything is fine.

Looks like that fixed it. I tested using an appsettings ConnectionString and it work fine.
Thanks for the quick response


Cannot add code to project

I am trying to use a piece of code from nuget using Visual Studio Express 2013. I can invoke the "Manage Nuget Packages" and the nupkg of interest shows under the "updates ->all item, but I cannot see how to add the code to the project. What am I missing?
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bd0c2ac7-8837-d4fd-955b-6a5b261592f3
Version Independent ID: 4c62f271-70ea-8537-f670-b59bb702c4c0
Content: What is NuGet and what does it do?
Content Source: docs/what-is-nuget.md
Product: nuget
GitHub Login: @karann-msft
Microsoft Alias: karann

@RLCongithub - you can referene the types and methods exposed by the nuget pacakge you reference. The source/implementation of the package won't appear in your project as you shouldn't have to worry about that.
Take a look at this quickstart. Although its for VS 2017, it shouldn't be terrible different in VS 2013 - https://docs.microsoft.com/en-us/nuget/quickstart/install-and-use-a-package-in-visual-studio

Doesn't work.  nuget.org appears but Newtonsoft.Json is not in dropdown list and cannot be found in search. Dead end.
Please respond.
Ron<EMAIL_ADDRESS>-----Original Message-----
From: Karan Nandwani<EMAIL_ADDRESS>To: NuGet/docs.microsoft.com-nuget<EMAIL_ADDRESS>Cc: RLCongithub<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Sent: Mon, Apr 8, 2019 4:38 pm
Subject: Re: [NuGet/docs.microsoft.com-nuget] Cannot add code to project (#1356)
@RLCongithub - you can referene the types and methods exposed by the nuget pacakge you reference. The source/implementation of the package won't appear in your project as you shouldn't have to worry about that.
Take a look at this quickstart. Although its for VS 2017, it shouldn't be terrible different in VS 2013 - https://docs.microsoft.com/en-us/nuget/quickstart/install-and-use-a-package-in-visual-studio—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

You have not helped.
-----Original Message-----
From: Karan Nandwani<EMAIL_ADDRESS>To: NuGet/docs.microsoft.com-nuget<EMAIL_ADDRESS>Cc: RLCongithub<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Sent: Mon, Apr 8, 2019 4:38 pm
Subject: Re: [NuGet/docs.microsoft.com-nuget] Cannot add code to project (#1356)
@RLCongithub - you can referene the types and methods exposed by the nuget pacakge you reference. The source/implementation of the package won't appear in your project as you shouldn't have to worry about that.
Take a look at this quickstart. Although its for VS 2017, it shouldn't be terrible different in VS 2013 - https://docs.microsoft.com/en-us/nuget/quickstart/install-and-use-a-package-in-visual-studio—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@RLCongithub - this repo is for docs. File an issue on the Home repo.


find should return null when a value could not be found, instead of false

This applies to all current and future variations of find.

Deque has a find; what else? I seem to remember some docs for this ext but can't seem to find them anymore.

Ah, docs are on php.net now. Will look into this.

I think I've fixed everything I can find (ha) about it.

I've actually changed my mind on this. find should support an optional default value and throw an exception if the key couldn't be found and no default was provided. So if you know you have string keys you can use $map->find(5, false) which would return false if a key for the value 5 couldn't be found. This allows us to not be ambiguous by returning null or false when those two values could have been used as keys. It's up to the developer to establish an appropriate "not found" value. A side effect of this is that it imitates how get(key, default) works, only in reverse.


Autosave:  Please provide option to be on by default

When I first bring up ST3 Autosave is by default turned off. I take it from your notes that this is considered a feature, not a bug. I take issue with this design decision. If a user has taken the trouble to install Autosave it's because they want it's functionality. It's a nuisance to have to turn on Autosave each time ST3 is activated. To make everyone happy, please provide an option to allow Autosave to be on by default for those who prefer this way of working.
My platform: ST3 Build 3126, running on Windows 7 and 10.

I completely agree.

actually, this can be adjusted by adding:
{
"auto_save_on_modified": true
}

into Packages/User/auto_save.sublime-settings

Thank you, luxe. Your fix works. Just tested it out.


Coredump

Angie 1.7.0 dumps core using proxy_http_version 3.
If it helps I can compile -O0 - to provide the content of some variables.
Our config is a bit awkward: we want to test http/3 only for certain requests:
    map $http_authorization $upstream_server {
        ''                      http://upstream_http11;
        default                 https://<IP_ADDRESS>:5678;
    }
    server {
        location / {
            proxy_pass                      $upstream_server;
            proxy_http_version              1.1;
            if ($http_authorization) {
                proxy_http_version          3;
            }
        }
    }

(gdb) backtrace
#0  ngx_http_v3_decode_insert_count (c=c@entry=0x7ffc11741830, insert_count=insert_count@entry=0x1b39e48) at src/http/v3/ngx_http_v3_table.c:526
#1  0x00000000004b0fe2 in ngx_http_v3_parse_field_section_prefix (b=<optimized out>, st=<optimized out>, c=<optimized out>) at src/http/v3/ngx_http_v3_parse.c:477
#2  ngx_http_v3_parse_headers (c=c@entry=0x7ffc11741830, st=st@entry=0x1b39e18, b=b@entry=0x1b39b50) at src/http/v3/ngx_http_v3_parse.c:340
#3  0x00000000004c7cb9 in ngx_http_v3_proxy_process_status_line (r=0x1a984c0) at src/http/modules/ngx_http_proxy_module.c:6875
#4  0x00000000004929f9 in ngx_http_upstream_process_header (r=0x1a984c0, u=0x1b39848) at src/http/ngx_http_upstream.c:2815
#5  0x000000000048e430 in ngx_http_upstream_handler (ev=0x7ff495100e90) at src/http/ngx_http_upstream.c:1405
#6  0x000000000043aa3b in ngx_event_process_posted (cycle=cycle@entry=0x1696de0, posted=0x52e310 <ngx_posted_events>) at src/event/ngx_event_posted.c:34
#7  0x000000000043a525 in ngx_process_events_and_timers (cycle=cycle@entry=0x1696de0) at src/event/ngx_event.c:263
#8  0x0000000000443c21 in ngx_worker_process_cycle (cycle=0x1696de0, data=<optimized out>) at src/os/unix/ngx_process_cycle.c:733
#9  0x0000000000441feb in ngx_spawn_process (cycle=cycle@entry=0x1696de0, proc=proc@entry=0x443b1d <ngx_worker_process_cycle>, data=data@entry=0x3, name=name@entry=0x4e0396 "worker process", respawn=respawn@entry=-4) at src/os/unix/ngx_process.c:200
#10 0x0000000000442dde in ngx_start_worker_processes (cycle=cycle@entry=0x1696de0, n=8, type=type@entry=-4) at src/os/unix/ngx_process_cycle.c:355
#11 0x0000000000444a0f in ngx_master_process_cycle (cycle=0x1696de0, cycle@entry=0x1692dd0) at src/os/unix/ngx_process_cycle.c:211
#12 0x0000000000418847 in main (argc=<optimized out>, argv=<optimized out>) at src/core/nginx.c:419

Can't reproduce on a development machine.
This is the line in question:
max_entries = h3scf->max_table_capacity / 32;

Hello,
thank you for report.
Can you please send debug log (https://en.angie.software/angie/docs/troubleshooting/#debug-logging)
and full configuration (angie -T).
Compiling with -O is also would be useful.
What request is being made? It looks like related to dynamic headers table. The quoted line should be fine unless there is some
problem with getting configuration from connection.
Thank you

This is what ASAN reports:
=================================================================
==473010==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000000 (pc 0x0000006a83e0 bp 0x7ffec1b91b40 sp 0x7ffec1b91af0 T0)
==473010==The signal is caused by a READ memory access.
==473010==Hint: address points to the zero page.
    #0 0x6a83e0 in ngx_http_v3_decode_insert_count src/http/v3/ngx_http_v3_table.c:524
    #1 0x69faf2 in ngx_http_v3_parse_field_section_prefix src/http/v3/ngx_http_v3_parse.c:477
    #2 0x69f20e in ngx_http_v3_parse_headers src/http/v3/ngx_http_v3_parse.c:340
    #3 0x716ed7 in ngx_http_v3_proxy_process_status_line src/http/modules/ngx_http_proxy_module.c:6875
    #4 0x60d439 in ngx_http_upstream_process_header src/http/ngx_http_upstream.c:2815
    #5 0x605303 in ngx_http_upstream_handler src/http/ngx_http_upstream.c:1405
    #6 0x4b4cfc in ngx_event_process_posted src/event/ngx_event_posted.c:34
    #7 0x4ae0ef in ngx_process_events_and_timers src/event/ngx_event.c:263
    #8 0x4ddfb3 in ngx_worker_process_cycle src/os/unix/ngx_process_cycle.c:733
    #9 0x4d4e56 in ngx_spawn_process src/os/unix/ngx_process.c:200
    #10 0x4db23f in ngx_start_worker_processes src/os/unix/ngx_process_cycle.c:355
    #11 0x4da5a9 in ngx_master_process_cycle src/os/unix/ngx_process_cycle.c:211
    #12 0x41aee0 in main src/core/nginx.c:425
    #13 0x7f80bd0295cf in __libc_start_call_main (/lib64/libc.so.6+0x295cf) (BuildId: 804ecab49bded24d516bc3d72a950a982eef6ddf)
    #14 0x7f80bd02967f in<EMAIL_ADDRESS>(/lib64/libc.so.6+0x2967f) (BuildId: 804ecab49bded24d516bc3d72a950a982eef6ddf)
    #15 0x419d74 in _start (/usr/local/nginx/sbin/angie+0x419d74) (BuildId: b267d7146e6a393f83b4ae500e44f32428018467)

AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: SEGV src/http/v3/ngx_http_v3_table.c:524 in ngx_http_v3_decode_insert_count
==473010==ABORTING

I think it is related with the proxy_cache directive.
This config reproduces this issue:
daemon              off;
master_process      off;
events {
    worker_connections      1024;
}
http {
    ssl_protocols               TLSv1.1 TLSv1.2 TLSv1.3;
    ssl_certificate_key         /tmp/domain.key;
    ssl_certificate             /tmp/domain.crt;
    proxy_cache_path            /tmp/cache keys_zone=cache:16m inactive=1w max_size=16384m;
    server {
        listen                  20443 quic reuseport;
        listen                  20443 ssl;
        http3                   on;
        http3_max_concurrent_streams    65536;
        quic_gso                on;
        quic_retry              off;
        ssl_early_data          off;
        access_log              off;
        location / {
            proxy_pass                      https://<IP_ADDRESS>:4434;
            proxy_http_version              3;
            proxy_set_header                Host $host;
            proxy_redirect                  off;
            proxy_buffering                 on;
            # here be dragons
            proxy_cache                     cache;
        }
    }
}

Thank you! Got it reproduced.
Yes, cache use explains the problem. there is no connection it tries to use, thus empty configuration.

Can you please try the following patch?
# HG changeset patch
# User Vladimir Khomutov<EMAIL_ADDRESS># Date<PHONE_NUMBER> -10800
#      Mon Oct 28 19:31:43 2024 +0300
# Node ID 88b2159c9f34662fa9694ddb7969ea95b3893799
# Parent  076586da0db5ecc37642dfdaedadb04ea7a13c5d
HTTP/3: cache fix.

diff --git a/src/http/modules/ngx_http_proxy_module.c b/src/http/modules/ngx_http_proxy_module.c
--- a/src/http/modules/ngx_http_proxy_module.c
+++ b/src/http/modules/ngx_http_proxy_module.c
@@ -6842,7 +6842,7 @@ ngx_http_v3_proxy_process_status_line(ng
     }

 #if (NGX_HTTP_CACHE)
-    if (r->cache) {
+    if (r->cache && c == NULL) {
         /* no connection here */
         h3c = NULL;
         ngx_memzero(&stub, sizeof(ngx_connection_t));

Yes, that solves that particular issue.

Behaviour you see is the result of attempts to access non-existing http3 session
when decoding table. But even fixed, the caching still doesn't work. See the patch
commit-log for details.
So, what are the options? Please try the attached patch and add "http3_max_table_capacity 0;"
directive to the configuration (server level). It will disable dynamic table and caching should work.
If you still see things like described above, please provide debug log.
http3_cache_qpack_fix.diff.gz

Thanks for the patch!
It works without proxy_cache.


Update Dell FC630 bios and idrac versions

Updates  the dell-update-fc630.yml playbook with the latest versions of the BIOS and iDRAC. These can be deployed with ansible-playbook -i <INVENTORY> hardware-dell/dell-update-fc630.yml -l <LIMIT-HOSTS> --ask-become-pass and will involve an automatic reboot.

Seems fine.


fix layout

this PR fix issue https://github.com/probot/probot.github.io/issues/346

@gr2m  review please

It's not easy for me to review the change. I haven't contributed to the website code myself, and the local setup fails for me. Did you manage to test your change locally? If so, can you upload before/after screenshots in differen resolutions, or a short screenshare? That'd  be very helpful

before in issue https://github.com/probot/probot.github.io/issues/346
after

@gr2m  done
the block with the code goes beyond the boundaries of the container and its overflow properties do not work, but this fix fixes everything

you can watch it online, just go to the site where there is a block with any code
for example https://probot.github.io/docs/hello-world/
and in the developer panel reduce the screen to 375 + -
you will see that it comes out, and apply the properties that I did in the PR and it will return to normal

Got it, thank you!


[REFAC] - Standardize Bootstrap Controller

As part of the standardisation of the reconciliation loop for Greenhouse controllers, this controller needs to be updated to follow the common recommendation for the Reconciliation
Acceptance Criteria

[ ] Implement the Interface
[ ] Use the standardised patch for updating the status instead of the deferred update (if applicable)
[ ] Convert the tests to use test.TestSetup (if applicable) including creation of missing resources

This controller will be skipped for the standardisation


build failure since a7ba86c75f4c (implement Link in terms of Linkat)

I cloned the tree:
aim@x1c:/tmp
: git clone http://github.com/4ad/go
Cloning into 'go'...
remote: Counting objects: 194894, done.
remote: Compressing objects: 100% (267/267), done.
remote: Total 194894 (delta 220), reused 91 (delta 68)
Receiving objects: 100% (194894/194894), 54.06 MiB | 2.93 MiB/s, done.
Resolving deltas: 100% (161506/161506), done.
Checking connectivity... done.
aim@x1c:/tmp
: cd go
aim@x1c:/tmp/go
: cd src
aim@x1c:/tmp/go/src
: GOARCH=arm64 ./make.
[ elided]
trings
strconv
bufio
sort
container/heap
encoding/base64
syscall
/tmp/go/src/syscall/syscall_linux.go:37: undefined: Linkat
/tmp/go/src/syscall/syscall_linux.go:869: undefined: readlinkat
/tmp/go/src/syscall/syscall_linux.go:903: undefined: symlinkat
/tmp/go/src/syscall/zsyscall_linux_amd64.go:204: Chmod redeclared in this block
previous declaration at /tmp/go/src/syscall/syscall_linux.go:824
/tmp/go/src/syscall/zsyscall_linux_amd64.go:246: Creat redeclared in this block
previous declaration at /tmp/go/src/syscall/syscall_linux.go:22
/tmp/go/src/syscall/zsyscall_linux_amd64.go:635: Link redeclared in this block
previous declaration at /tmp/go/src/syscall/syscall_linux.go:36
/tmp/go/src/syscall/zsyscall_linux_amd64.go:696: Mknod redeclared in this block
previous declaration at /tmp/go/src/syscall/syscall_linux.go:857
/tmp/go/src/syscall/zsyscall_linux_amd64.go:797: Readlink redeclared in this block
previous declaration at /tmp/go/src/syscall/syscall_linux.go:868
/tmp/go/src/syscall/zsyscall_linux_amd64.go:842: Rename redeclared in this block
previous declaration at /tmp/go/src/syscall/syscall_linux.go:875
/tmp/go/src/syscall/zsyscall_linux_amd64.go:987: Symlink redeclared in this block
previous declaration at /tmp/go/src/syscall/syscall_linux.go:902
/tmp/go/src/syscall/syscall_linux.go:903: too many errors
go tool dist: FAILED: /tmp/go/pkg/tool/linux_amd64/6g -pack -o /tmp/go-tool-dist-764739828/go.a -p syscall /tmp/go/src/syscall/env_unix.go /tmp/go/src/syscall/exec_linux.go /tmp/go/src/syscall/exec_unix.go /tmp/go/src/syscall/flock.go /tmp/go/src/syscall/lsf_linux.go /tmp/go/src/syscall/netlink_linux.go /tmp/go/src/syscall/race0.go /tmp/go/src/syscall/sockcmsg_linux.go /tmp/go/src/syscall/sockcmsg_unix.go /tmp/go/src/syscall/str.go /tmp/go/src/syscall/syscall.go /tmp/go/src/syscall/syscall_linux.go /tmp/go/src/syscall/syscall_linux_amd64.go /tmp/go/src/syscall/syscall_unix.go /tmp/go/src/syscall/zerrors_linux_amd64.go /tmp/go/src/syscall/zsyscall_linux_amd64.go /tmp/go/src/syscall/zsysnum_linux_amd64.go /tmp/go/src/syscall/ztypes_linux_amd64.go
I was able to build and run 'hello world' earlier today \o/ with b933b98029c8b5357d50820c5547e164876ea75e

Yes, known issue. Only arm and arm64 builds are working right now. 386, amd64 and ppc64 are broken. Someone has to regenerate zsyscall_linux_amd64.go from an amd64 machine.

Basically
cd go/src/syscall
./mksyscall.pl syscall_linux.go syscall_linux_arm64.go |gofmt >zsyscall_linux_arm64.go

Ah, I was s/amd/arm/. Builds OK now.

I've fixed the build errors on other platforms in https://github.com/minux/go-arm64/commit/bfdc81b7fe6f38f343843458ce346e353a5ce23e

I believe this is fixed.


I can't install the framework? Import error: "No such module PKHUD"

Hi,
the framework looks so awesome.
But I have problems to use it:
I downloaded the newest .zip from 04/12/2014.
Unzip the files.
Drag & Drop the folder "PKHUD" to my existing swift xcode project.
Then I go to my "AppDelegate.swift" and adding on the top, right under the "import UIKIT" a new line:
import PKHUD
The compiler show me an error: "No such module PKHUD".
What do I wrong?
[By the way the standalone Demo-versions works perfect. I think I have just a little problem, to import the PKHUD.]
I'm using the new Xcode 6.1.1 from the Mac App Store, no beta.
And OS X 10.10.1 Yosemite.

you are right ghost. I have also solved my problem. Thank you


Bump omero-marshal dependencies in omero-web role

For OMERO 5.3.x, any non-breaking 0.5.x omero-marshal version should be valid. The dependency sets 0.5.1 as the minimum as it contains a patch required for any OMERO version greater than 5.3.1

I am also inclined to merge and release this asap as it contains a necessary fix for the latest OMERO.web deployment. Following up on https://github.com/openmicroscopy/ansible-role-omero-web/pull/4#issuecomment-297649715, I don't have strong preference. I am fine with this being either 1.0.0-m2 and targeting #4 for 1.0.0 or 1.0.0 and targeting #4 for 2.0.0.

👍  merging.


Window Application icon doesn't work

on windows platform with kivy 1.8.0 ‘portable package’, App.icon doesn't  set the window icon, tested with the following code:
from kivy.app in App

class MyApp(App):
    def build(self):
        self.icon = 'myicon.png'

if __name__ == '__main__':
    MyApp().run()

example from the kivy.App documentation

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

It mentions sizes here, but it is not accurate: https://github.com/kivy/kivy/blob/b72d1735a91b5cabad8343e8d63f84c840df1a96/kivy/app.py#L386
Relevant info for windows ico from https://github.com/kivy/kivy/commit/e0f59eb16602a5f0ada0af9a02db157a248dad9d:
"You need to provide a .ico along the .png, and must contain at a 16x16 and 48x48 image."
We should list the needed sizes and extensions for every platform.

Doesn't seem to work on Ubuntu 15.10, either, with the Unity desktop.  Works with the xfce4 desktop on Ubuntu 16.04, though.  Though I guess this is an SDL issue...

Doesn't work here either. @dessant If we provide a png and an ico file, which one will be referenced with self.icon?

I just upgraded from Kivy 1.8.0 to 1.9.1 and there was a behavioural change on Windows. Yes, png works across OSX and Windows now, in fact, it is the other way: ico no longer works on Windows. But there is a caveat: OSX supports and requires 1024x1024 icons and kivy supports that on OSX, but on Windows the png cannot exceed 512x512 or it will not display.

Confirmed on Kivy v1.9.2 on Ubuntu 16.04 LTS Unity. Window application icon doesn't work.

Bug still present on Ubuntu 16.04 and Kivy 1.9.2.
One reason is because the icon doesn't appear on Ubuntu Unity is because that OS relies on .desktop files. On my blog, I describe a handy workaround: http://www.indeliblebluepen.com/?p=1012

Ah, thanks for that Unity pointer!

Problem persists in current version v1.10.1. What worked for me was setting an *.png image instead of an *.ico.
It seems like there are two problems at work here:

*.ico are not supported, use *.png
check your path, add assert self.get_application_icon() != "" if unsure

tried to track this down, and found at least two issues.
Firstly the App's .icon property usually gets bypassed with SDL2 the first mention of
from kivy.core.window import Window
makes an instance of Window, and right in the create_window function sets the icon, long before your App class is even found.
This function sets it using
filename_icon = self.icon or Config.get('kivy', 'window_icon')
where self.icon is an empty StringProperty which you are unable to manipulate, since the code runs on module import.
Alright, so we set that property, right?
Config.set("kivy", "window_icon",ICON)
This then sets the variable, as long as you keep your slashes and backslashes ok.
self.set_icon(filename_icon) which goes to self._win.set_window_icon(str(filename)) which is in a pyd file. At this point the file name is correct, but no icon appears. Not with ico files, nor with png, of whatever size.

Is there a fix for this?

Bug still present on Ubuntu 16.04 and Kivy 1.9.2.
One reason is because the icon doesn't appear on Ubuntu Unity is because that OS relies on .desktop files. On my blog, I describe a handy workaround: http://www.indeliblebluepen.com/?p=1012

@CodeMouse92 this link is broken

Ah, yes it is. I'll have to run it through internet archive later.

@maltfield Hm, it appears it wasn't archived, however, I DID republish it on DEV a while back! (I'd forgotten).
https://dev.to/codemouse92/icons-python-and-ubuntu

I encountered a similar issue and was able to come up with a workaround...
My problem was the .ico file would not load in the ActionPrevious icon, however it would load for the app icon. I added a .png to the project and now it loads fine:
https://github.com/n2qzshce/ham-radio-sync/blob/1819c70019f9e42140b056b76b082bb0208454af/src/ui/app_window.py#L135

how is this still broken

how is this still broken

@yukkidev I was able to get this working in my project, you may be able to use it for a reference: https://github.com/n2qzshce/ham-radio-sync/blob/1819c70019f9e42140b056b76b082bb0208454af/src/ui/app_window.py#L135


Upgrading Cypress to 12.8.1

Description
[Describe what this change achieves]
Upgrade Cypress to version 12.8.1
Issues Resolved
[List any issues this PR will resolve]
Corrects the wrap error from cypress-watch-and-reload present in version 6 causing all test to currently fail.
Check List

[ ] New functionality includes testing.

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Toaster error present in 1_event_analytics.specs.js is able to be fixed with the code below; will be pushed in separate PR.

Placed in .cypress->support->command.js(can be any file here just so that it runs on start)


UPDATED ISSUE :-11931

Summary

Checklist

[ ] The Pull Request has tests
[ ] A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
[ ] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Full changelog

[Implement ...]

Issue reference

Fix #11931

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@Harsh-Mangukia07 can you please clarify the purpose of this PR?

@Harsh-Mangukia07 i am closing this. it doesn’t seem to ve doing what it says. pkease ooen a new pr, if you are still interested to see the issue fixed.


unable to use ng new on stackblitz

Command
new
Is this a regression?

[X] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
Creating a new project on stackblitz fails. It used to work before
Minimal Reproduction

go to https://node.new
execute npx @angular/cli new foo in the terminal
choose to proceed with the installation
choose CSS as the stylesheet format

The command stops with the error
[Inquirer] Hook functions can only be called from within a prompt

Exception or Error
[Inquirer] Hook functions can only be called from within a prompt

Your Environment
On stackblitz:

Angular CLI: 18.2.6
Node: 18.20.3
Package Manager: npm 10.2.3
OS: linux x64

Anything else relevant?
I don't know if it's a regression on stackblitz or if it's a limitation that always existed, but that previous versions of the CLI didn't have a problem with.
Sorry for the noise if it's purely a stackblitz problem. But it would really be nice to be able to use stackblitz for repros of bugs and demos.

This is not caused by Angular CLI, please see: https://github.com/SBoudrias/Inquirer.js/issues/1426


Permissions failure opening Mac desktop app

Download OWASP-Threat-Dragon-1.6.1-mac
Unpack
Right click and select "open"

Expect: app starts
Actual: "You do not have permission to open the application"

Open Terminal. Use command "open <path to .app directory>"
Get error with diagnostic information

The application cannot be opened for an unexpected reason, error=Error Domain=NSOSStatusErrorDomain Code=-10826 "kLSNoLaunchPermissionErr: User doesn't have permission to launch the app (managed networks)" UserInfo={_LSFunction=_LSLaunchWithRunningboard, _LSLine=2436, NSUnderlyingError=0x7fdfe95182f0 {Error Domain=RBSRequestErrorDomain Code=5 "Launch failed." UserInfo={NSLocalizedFailureReason=Launch failed., NSUnderlyingError=0x7fdfe9518ab0 {Error Domain=NSPOSIXErrorDomain Code=111 "Unknown error: 111" UserInfo={NSLocalizedDescription=Launchd job spawn failed with error: 111}}}}}

sudo open <path to .app>
Get error with different diagnostic information

The application cannot be opened for an unexpected reason, error=Error Domain=NSOSStatusErrorDomain Code=-10826 "kLSNoLaunchPermissionErr: User doesn't have permission to launch the app (managed networks)" UserInfo={_LSFunction=_LSLaunchWithRunningboard, _LSLine=2436, NSUnderlyingError=0x7f81fce0e660 {Error Domain=RBSRequestErrorDomain Code=5 "Launch failed." UserInfo={NSLocalizedFailureReason=Launch failed., NSUnderlyingError=0x7f81fce081c0 {Error Domain=NSPOSIXErrorDomain Code=111 "Unknown error: 111" UserInfo={NSLocalizedDescription=Launchd job spawn failed with error: 111}}}}}

Hello @lucasgonze
Apologies for not responding sooner, I was on vacation in a place without internet (hard to find, but they still exist :)
It looks like your MacOS has a security policy that  does not allow the zip archive to run directly, which is the case for the majority (but not all) MacOS these days. Can you try the installer OWASP-Threat-Dragon-1.6.1.dmg ?
This should install directly without need for any security exception.
There are some instructions at https://threatdragon.github.io/install-desktop/#macos-installer , but it should be made clearer in the instructions that the .dmg file should be used in most cases. I will raise a Docs issue for this

Raised Docs issue : https://github.com/threatdragon/threatdragon.github.io/issues/35

Jon, thanks for this guidance. I will try again, using the DMG.

I have updated the wiki to include this and have also have updated the documentation


Restore Django 1.8/1.9 compatibility, and allow caching of Falsey values

Existing dependency django_userforeignkey offers the means to maintain django 1.8/1.9 compatibility for relatively little cost
If a cache_for_request function attempts to cache a falsey response, e,g, 0, False, [] then it will previously attempt to re-fetch the result each time and the cache benefit will be lost.

Has anyone considered to merge this for Django 1.8/1.9 compatibility or no longer possible?


Create an achievement section

Changes are to be made in index.html, styles.html and index.js files.
Achievement  Section should contain:
Title: Accomplishment.

500+ Members
25+ Events
10+ Mentorship Provided
Background should be white, and colour should be matching with the theme

Design
Inspo: (You can refer to it and can make your own interpretations too, Creativity is welcomed.)

Please join the Discord to discuss design of the components.

i want to contribute on this issue , can you please assign me this

I have experience with the Bootstrap library. I will be able to create this section. Requesting to assign me this task.

@girlscript-asansol i have a made a PR for a achievement section, can u confirm please

@girlscript-asansol @jay-io

I want to work on this

@thatsuman  Go to #114 for samples.


Add option to notify if a portal spawns and points are below 150

Take a look and let me know what you think

Can you bump the version number to the next 1.x (I think it's gonna become 1.5). Don't close this PR just commit that update to your branch.
Otherwise looks good to me. (Not testing, not going back to gotr lol)

Oh, I think this will notify you when you're below 150 and come back while the portal is up. Maybe set a 40 second timer on the alert so that it doesn't double dip on the notify because if I go though a portal and mine and come back I don't need the second alert.
Is that the behavior it has or does it stay loaded for the onGameObjectSpawned to only fire the once?

When you enter the portal, you stay in the same chunk so there shouldn't be any more loading but I'll test and see.

It did exactly what you said it would. I fixed it and played a game of GOTR and it works pretty well.


Fix visible 'hidden' scrollbar when content frame is shorter than container

The scrollbar was still visible when 'hidden' if the content frame height was shorter than the container frame height. Using pack and pack_forget instead of lift and lower fixes this issue.

Note: 000c1e5 bumps to version <IP_ADDRESS>; the title is a typo


slow Scanning notes

I have around 1300 notes in my vault.
The preview loads, but when you click the check to add the link, it just freezes for a long time for each link. I'm running on a very high-end PC. Please add the option to select and add all links with one click, currently, it's gonna take forever to add links for large vaults. Also as some people have mentioned, maybe add integration with ChatGPT? Maybe build on top of the Smart-Link Plugin to do that, ChatGPT is very good at finding links, it just doesn't have the function to link them.

have you updated to the latest version? it added pagination.

I am also experiencing the same issue... The page feature doesn't seem to be working. I don't know how long each page is supposed to be but for me it creates a massive single page list of all the potential link. When selecting a checkbox It freezes for upwards of 45 seconds before I can select the next checkbox. I'm on version 1.2.4.


Adding Stellio links to the list of implementation in the Fiware NGSI-LD FAQ

I guess this update has to be made in smart data model repository


Repackage video files on the fly to support streaming to  tag

i cannot stream any video
i always receive this error...
Uncaught InvalidStateError: Failed to execute 'appendBuffer' on 'SourceBuffer': This SourceBuffer has been removed from the parent media source. bundle.js:10746

Thanks for the recommendation. mp4box.js looks like a good start. I wish it used browserify and streams.

An initial implementation of on-the-fly video repackaging has been live on https://instant.io for a couple months, thanks to @jhiesey and mp4box.js. It still needs some work to make it more robust, but this issue is complete now.


pull request for e2e test at 02/04/2017 02:45:06

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Added support for ${env:…} variable substitution and ~ handling.

Adds support for user home folders (using os.homedir()) as well as env variables (using process.env[]).
Addresses #47

This is outdated and stale. The important change was already implemented in 1.8.0.