When will requirements.txt be updated?

The numpy version in Tacotron 2 requirement file is 1.13.3, when numba, imgaug require >= 1.15, tensorflow require >= 1.16; torch==1.0 in Waveglow's requirement file is also outdated since the code is using torch.utils.tensorboard, which only appear in newer version of Pytorch

+1 on this one. Currently it's a big trial & error to get it running when installing from scratch

+1 the requirements is outdated, and I don't know which version I should use on tensorflow/numpy/numba/llvmlite ...
And this error occured:
ImportError: numpy.core.multiarray failed to import

For reference for people having issues installing deps later on, I'm using conda and this sequence of commands seemed to work well to create a new env that can run it, though it's likely not necessary to stretch it out like this:
conda config --add channels conda-forge
conda create --name tacotron2
conda install python=3.7
conda install tensorflow=1
pip install -r requirements.txt
conda install pytorch

I've got everything to run with this but I'm worried the version numbers are affecting my output. I can't remember the reasoning for using python 3.6 but it was to get it to run on windows.
conda create -n tacotron python=3.6
conda install pytorch==1.5.0 torchvision==0.6.0 cudatoolkit=10.2 -c pytorch
(if on windows) conda install -c conda-forge nvidia-apex
Then requirements.txt:
matplotlib==2.1.0
tensorflow==1.15.2
numpy==1.16.0
numba==0.48.0
inflect==0.2.5
librosa==0.6.0
scipy==1.0.0
Unidecode==1.0.22
pillow
future

I've got everything to run with this but I'm worried the version numbers are affecting my output. I can't remember the reasoning for using python 3.6 but it was to get it to run on windows.
conda create -n tacotron python=3.6 conda install pytorch==1.5.0 torchvision==0.6.0 cudatoolkit=10.2 -c pytorch (if on windows) conda install -c conda-forge nvidia-apex
Then requirements.txt: matplotlib==2.1.0 tensorflow==1.15.2 numpy==1.16.0 numba==0.48.0 inflect==0.2.5 librosa==0.6.0 scipy==1.0.0 Unidecode==1.0.22 pillow future

the librosa==0.6.0  lead  numpy==1.16.0  change to numpy==1.19.5
why and how change

I'm not sure what you mean exactly.
Make sure you are using python 3.6. Its been a long time but I think you might be using that numpy because of a different cuda toolkit? I'm guessing windows? What GPU?


Add missing features to openbookqa dataset for additional config

Fix #4276.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


#10 #11 error handling

@morpheyesh  Requesting you to review this pull request.

@indykish It can be merged!

@thomasalrin  please refresh the gem.


⚠ Bofrost.de has degraded performance

In 323d4cb, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1215 ms

Resolved: Bofrost.de performance has improved in 5427219.


Commands maybe lost via pipeline

reported from zhuanzhuan
Commands sent via pipeline and the last serval commands may be lost.

testcase ： echo -en "lpush ky 1 2 3 4 5 6 7 8 9 0\r\nexpire ky 600\r\n" |nc IP Port

Has this been resolved ?


Question: Does ReactJS.NET support js from cdn for server side rendering?

Any scripts used for server-side rendering need to be located on a locally accessible drive, ideally in the web root of the application. The server side rendering doesn't support loading scripts via HTTP.


YouTube API changed

Please tick all applicable boxes.

[ x ] I am using Python 3.5 or higher (run python --version on the command line)
[ x ] I have followed the official guides to install the bot for my system
[ x ] I have updated my dependencies to the latest version using the appropriate update script

Which version are you using?

[ x ] The latest master version (1.9.7)
[ ] The latest review version

What type of issue are you creating?

[ x ] Bug
[ ] Feature request
[ ] Question

Description of issue
Today, YouTube has changed its API.
If you want to play a video on the Musicbot with !play, nothing will be played. The bot does not give an error message.
With !skip but an error message is issued, which says that the bot is currently playing nothing.

Log file
Userchat: !play mgmt
Download started: https://www.youtube.com/watch?v=rtL5oMyBHPsWolfsschanze
Download complete: https://www.youtube.com/watch?v=rtL5oMyBHPs
[ERROR:bot] Error in skip: CommandError: Can't skip! The player is not playing!
Traceback (most recent call last):
File "/home/pi/MusicBot/musicbot/bot.py", line 2841, in on_message
response = await handler(**handler_kwargs)
File "/home/pi/MusicBot/musicbot/bot.py", line 2158, in cmd_skip
raise exceptions.CommandError(self.str.get('cmd-skip-none', "Can't skip! The player is not playing!"), expire_in=20)
musicbot.exceptions.CommandError: Can't skip! The player is not playing!

send log please

Not sure where you got this information about an API change, I tested both the command you used, https://www.youtube.com/watch?v=rtL5oMyBHPsWolfsschanze and https://www.youtube.com/watch?v=vvtRtxHAKg0
All of which worked perfectly fine on two separate bots.
As asked above, send your log file. This will give us a better understanding as to what's wrong.

Strange, today it works again. I thought it was the API because thirdparty apps had problems as well, like the MyTube app.
I think it's no longer needed to send the log file, because it works again.
Anyway, thanks for the replies. This thread can be closed.


Allow suggestion of category colour

Suggestion by mister X :
A colour palette to choose colours from for categories. Currently the app sometimes chooses colours that make the text unreadable.

Hello mister X, I have worked in latest release (0.12) to make background always readable by improving color automatic selection. I think this makes selecting color useless, and Iwant to keep usage of software stupid simple.

Although I couldn't agree more with your Simple Usage concept, there are synesthetes who, like me, tend to associate certain colors with words and ideas. Ability to choose specific color would create an easily perceptible combination that could help speed up the packing process later on.

Ok, so where and how would you imagine inserting this feature in existing app for the user?
Technically for now categories are just string attributes of an item, it will be a bit difficult to insert but why not.

Unfortunately I'm a graphic designer with little to no Java or Kotlin knowledge. But I could suggest that you take a look at this app's code here:
https://github.com/brarcher/loyalty-card-locker
There's a color picking dialog within the item attributes editing full-screen dialog.


Use python3 venv for installation.

Suggest to use python3 venv for installation. This allows users to have non-conflicting dependencies in their base python installation.
Note: I am using .venv directory, as that is already excluded in the .gitignore file.

Hi @lorenzodifuccia - when you have a moment, would you mind considering this PR? Much appreciated!

I think that's not what the standard user wants (also I don't have any conflicts).
As in general for python everybody is free to install it into a venv (which you need to activate before every use which is not that user friendly as the standard behaviour).
To sum it up, in my opinion, there should be the option to do so but this should be no obligation for a venv.

Hi @holzkohlengrill - thank you for sharing your thoughts!

also I don't have any conflicts

This may be the case for you and folks, but is not necessarily going to be true for everyone. Having users install packages outside of a virtual environment can become problematic with people start using / working on many python projects where version conflicts may occur when doing this. For example, say I was working on another project that had a requirements.txt file set to requests==1.2.3 (yes, I realize this is a very old version) and installed without a virtual environment, and then did similar for this project - my prior project would likely have issues. For a 'standard user', this may cause difficulties debugging, and may eventually result in a GitHub issue opened for whatever project they are encountering the issue (ie, it might not be https://github.com/lorenzodifuccia/safaribooks where the issue is opened).
I agree with your general sentiment, having a virtual environment is extra steps for the standard user and a bit more cumbersome for them. If we were to abstract these extra steps away for users (ie, if we created a nicer 'installation script', and wrapper script around the main python files that automatically sourced the venv prior to executing), would you still have concerns with using virtual environments?

Thanks for the extensive response.
First I would say when a project uses old versions it's their duty to make it compatible to newer versions of the libraries.
Secondly having a separate install script for venv is additional maintaing effort with little benefit (however at the end @lorenzodifuccia has to decide this).
Third, I agree with the hassle about version conflicts. In the other hand you should avoid that in the first place (supporting current versions) instead of workarounds. Users having a multitude of scripts (installed) normally are capable of setting up a venv (also a quick Google search will show the steps for those who don't).
So for a big projects having complex setup routines this makes definitely sense.
@lorenzodifuccia what do you think?

Thank you so much @ChrisCarini @holzkohlengrill for your considerations!
I just think that a venv would add only an additional step for normal user, as said by Marcel.
Of course, people is free to manage their python libraries however they want.
Versions on requirements.txt will always be >= and with the first working version (addressing bugs or security issues).
We can add a line in the README encouraging people to use pipenv or a separate venv, in the Req&Setup cap...

TL;DR: SGTM - I'll close and delete this branch then. Sorry to consume the time.

Thanks for the extensive response.

@holzkohlengrill  - no problem!

First I would say when a project uses old versions it's their duty to make it compatible to newer versions of the libraries.

I agree, in the ideal world this is how it would work. But as I'm sure you are aware, there are many still-useful projects that do not get the attention they deserve. This can be true in the OSS community, but also behind corporate walls, as you may or may not be aware.

Secondly having a separate install script for venv is additional maintaing effort with little benefit (however at the end @lorenzodifuccia has to decide this).

Sure, understood that this would be additional effort - the benefit, IMO, would be keeping this project as isolated from other python projects on a users system as possible.

Third, I agree with the hassle about version conflicts. In the other hand you should avoid that in the first place (supporting current versions) instead of workarounds. Users having a multitude of scripts (installed) normally are capable of setting up a venv (also a quick Google search will show the steps for those who don't).

Again, agree on avoiding, but this is not always possible as mentioned above.

Thank you so much @ChrisCarini @holzkohlengrill for your considerations!

@lorenzodifuccia - Of course!

I just think that a venv would add only an additional step for normal user, as said by Marcel.

SGTM - I'll close and delete this branch then. Sorry to consume the time.

Versions on requirements.txt will always be >= and with the first working version (addressing bugs or security issues).

Understand - however my concern was not this project, per say, using == in the req.txt file, but rather other projects setting hard dependencies.
@lorenzodifuccia / @holzkohlengrill - what are both of your thoughts on making this a python zipapp (something like https://github.com/pantsbuild/pex or https://github.com/linkedin/shiv as examples), so the need for people to do the installation of dependencies (when using this repo; not when developing) becomes moot? Or is the intent/desire to keep this as a 'standalone' script?


Small fixes for CAN

I know there is an open issue for refactoring the CAN impl (#178) but figured I would patch the existing impl slightly in the meantime.
This fixes an issue where weren't actually transmitting the correct length of data, as well as adding options to allow users to configure the baud rate and enable loopback mode.

Don't worry about #178 too much. This is still very WIP and for now only contains added TODO comments. More of a reminder for myself. Maybe I should close that PR until it contains some useful changes.

updated this to use a builder + the source enums where possible.

updated this to use a builder + the source enums where possible.

(also didnt realize the clippy lints were failing, fixed now)

(also didnt realize the clippy lints were failing, fixed now)

no prob @Sh3Rm4n I am in the same boat myself. I find occasional bouts of time to work on this, but much less than I would prefer!
I will make some of those changes later today and update the changelog as well.
I totally agree about using bxCan, I was looking for something like that to exist when I originally started work on this! I have been meaning to give that a go, but have been hesitant to mess with it because I have been using the existing CAN stuff for a motor driver I am building and didn't want to mess with it. I might give it a go soon though.

I will make some of those changes later today and update the changelog as well.

Nice :+1:

I totally agree about using bxCan, I was looking for something like that to exist when I originally started work on this!

Yeah, I know that your original work on CAN predates the bxCAN crate. It's nice to see the eco-system improving :)

I have been meaning to give that a go, but have been hesitant to mess with it because I have been using the existing CAN stuff for a motor driver I am building and didn't want to mess with it.

No pressure. Maybe some else has time to pick this up and you can focus on your motor driver! :)

Should be good to merge!


Bracket colorization issue in C code

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.76.0
OS Version: Fedora 37

Steps to Reproduce:

Open the libcli.c file from test.zip and note the bracket colorization issue on line 197 indicating a missing bracket.

I can compile this code in all possible configurations without the compiler complaining that I might have done something wrong.
Step to compile the code (on Linux):
gcc -shared -fPIC -o libcli.so libcli.c

Screenshot of the affected line:

Screenshot showing where VSCode thinks the closing bracket of the function belongs (end of line 257).

Also side note, but it would be nice if bracket colorization could be turned off in these disabled sections of code. I noticed this both in both the clangd and C/C++ extensions.

/duplicate (use tags to find the original issue)

What was the duplicate issue? I could not find one?


Include local political corona regulations in a retrievable way.

Feature description
It is somewhat complicated to keep track of the existing corona regulations in different regions and national borders. Even more so if you are not at home in the region, for whatever reason.

Problem and motivation

It would be good if there was the possibility to deposit texts of regulations or links to the texts of regulations of a certain government, country or other district.
Is this something you're interested in working on

no

Hey @silviograu 👋🏻
This seems like a duplicate of #151.
Please monitor this Issue and if necessary follow up there.
Please close this Issue.
Thank you 👍

Hey @silviograu 👋🏻
This seems like a duplicate of #151.
Please monitor this Issue and if necessary follow up there.
Please close this Issue.
Thank you 👍

Hi @Ein-Tim, thanks!
That's pretty much what I wrote. I am #closing 323 . thanks!

Hi @Ein-Tim, thanks!
That's pretty much what I wrote. I am #closing 323 . thanks!

The official app is NINA (Notfall-Informations- und Nachrichten-App) from the Bundesamt für Bevölkerungsschutz und Katastrophenhilfe:

NINA English links
NINA German site

There is also https://www.darfichdas.info/ which links into German information sources.

The official app is NINA (Notfall-Informations- und Nachrichten-App) from the Bundesamt für Bevölkerungsschutz und Katastrophenhilfe:

NINA English links
NINA German site

There is also https://www.darfichdas.info/ which links into German information sources.


Work with AsciiMath

Hi, I am in favor of Markdown and AsciiMath. AsciiMath is another javascript that enables something similar to Markdown that allows me to edit formula with text, see http://asciimath.org/. Unfortunately,  strapdown and AsciiMath does not work properly together at the moment.
Currently, I can use AsciiMath only outside of <xmp> block, this is not convenient as I also want my text to come with formula.
I am not able to propose a solution. However, I will be grateful if strapdown can solve this issue. So that we can use simple text to write documents with formulas.

This is not really a solution but more an alternative. You could use bootmark.  Also, it's in active development, unlike strapdown.
Disclaimer: I am the author of bootmark. ;)

Hi,
thanks for your suggestion. I tried bootmark this morning. It does not work
as expected yet ...
What I did is like:

any tag - document

 The first equation:  `E = m c^2`

First block of Markdown text goes in here

 The second equation: `E = sum_i m_i c^2`

Second block of Markdown text goes in here

Both equations are shown. But the second block of markdown text is gone
after rendering. And there is a navigation bar on the top of the page. Can
you give any suggestion to fix it?
Best Regards
Tian, Bo
On Thu, Oct 6, 2016 at 3:53 AM, obedm503<EMAIL_ADDRESS>wrote:

This is not really a solution but more an alternative. You could use
bootmark https://obedm503.github.io/bootmark/.  Also, it's in active development, unlike strapdown.
Disclaimer: I am the author of bootmark. ;)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/arturadib/strapdown/issues/71#issuecomment-251848162,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APcDePsgKypxWXJiztU7ut4uPzA6pFnRks5qxFSwgaJpZM4KOgkD
.

as of now, bootmark is intended to work with a single block of markdown, and not different segments with other text in between. The good news is that I'm working on a new version that should fix stuff regarding polyfills, and I could fix your issue in there. I really never thought of that use case (several blocks of markdown instead of one), so thanks for bringing that up. It's a great idea.
As for the navigation bar, you can disable that through config on the element with markdown. You simply need to add
<div id="bootmark" data-html="{ toc: false }">
...some markdown...
</div>

to the element with the id of markdown (remember that id's have to be unique), or add
<bootmark html="{ toc: false }">
...some markdown...
</bootmark>

if your using the <bootmark> element.
toc stands for Table Of Contents.
Now that the idea came up of having multiple separated chunks of markdown, I might consider changin the requirement from id="bootmark" to class="bootmark" to allow for such a thing.
Also, I know that the docs are pretty bad right now, that should also be fixed on the new release.

So you will become the first to support AsciiMath along with markdown  :)
I am also thinking about another approach: can we have some markdown
directly for math, e.g.
E = sum_i m_i c^2

then you can figure out a way to use MathJax for further processing.  In
this way, it will feel more like a native solution.
What do you think ?
B.R.
Tian, Bo
On Fri, Oct 7, 2016 at 1:58 AM, obedm503<EMAIL_ADDRESS>wrote:

as of now, bootmark is intended to work with a single block of markdown,
and not different segments with other text in between. The good news is
that I'm working on a new version that should fix stuff regarding
polyfills, and I could fix your issue in there. I really never thought of
that use case (several blocks of markdown instead of one), so thanks for
bringing that up. It's a great idea.
As for the navigation bar, you can disable that through config on the
element with markdown. You simply need to add

...some markdown...

to the element with the id of markdown (remember that id's have to be
unique
http://stackoverflow.com/questions/7262195/several-elements-with-the-same-id-responding-to-one-css-id-selector),
or add

...some markdown...

if your using the  element.
toc stands for Table Of Contents.
Now that the idea came up of having multiple separated chunks of markdown,
I might consider changin the requirement from id="bootmark" to
class="bootmark" to allow for such a thing.
Also, I know that the docs are pretty bad right now, that should also be
fixed on the new release.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/arturadib/strapdown/issues/71#issuecomment-252120811,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APcDeIH5C-IGElUOpacJgyo7UMrdBYoMks5qxYsPgaJpZM4KOgkD
.

So you will become the first to support AsciiMath along with markdown  :)
I am also thinking about another approach: can we have some markdown
directly for math, e.g.
E = sum_i m_i c^2

then you can figure out a way to use MathJax for further processing.  In
this way, it will feel more like a native solution.
What do you think ?
B.R.
On Fri, Oct 7, 2016 at 1:58 AM, obedm503<EMAIL_ADDRESS>wrote:

as of now, bootmark is intended to work with a single block of markdown,
and not different segments with other text in between. The good news is
that I'm working on a new version that should fix stuff regarding
polyfills, and I could fix your issue in there. I really never thought of
that use case (several blocks of markdown instead of one), so thanks for
bringing that up. It's a great idea.
As for the navigation bar, you can disable that through config on the
element with markdown. You simply need to add

...some markdown...

to the element with the id of markdown (remember that id's have to be
unique
http://stackoverflow.com/questions/7262195/several-elements-with-the-same-id-responding-to-one-css-id-selector),
or add

...some markdown...

if your using the  element.
toc stands for Table Of Contents.
Now that the idea came up of having multiple separated chunks of markdown,
I might consider changin the requirement from id="bootmark" to
class="bootmark" to allow for such a thing.
Also, I know that the docs are pretty bad right now, that should also be
fixed on the new release.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/arturadib/strapdown/issues/71#issuecomment-252120811,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APcDeIH5C-IGElUOpacJgyo7UMrdBYoMks5qxYsPgaJpZM4KOgkD
.

though it would be cool, adding a custom code block language might be overkill. (is it even possible?) You could use normal  ` E = sum_i m_i c^2 ` syntax and disabling prettyprint. (prettyprint might mess up the math.) does asciimath allow for multiline math blocks? something like:
`
E = sum_i m_i c^2
`

I figured out how to use multiple bootmark elements/markdown blocks per page. This is still not on the latest stable release.

I'll look into having a custom code block language

after digging through MathJax's documentation I couln't find a simple method which would take a string of math and return html. So I looked for alternatives, and the internet gave me KaTeX. It does just what I wanted, and is alot faster than mathjax.
so, like you suggested, I created an extension for showdown (the parser used by bootmark) that uses katex to convert "latex code" to pretty math.
the syntax works like you suggested it should but instead of
```math
some math here
```

it uses
```latex
some math here
```

since the "code" is in latex.
For a demo of the extension check this https://obedm503.github.io/katex-latex/
that page is built from multiple elements. some with markdown outside and some with markdown inside. Shared config is defined in the <script> tag in the head of the document. Shared config is something new to version 0.5.0 of bootmark.
if you still need to use asciimath, it seems there are ways to convert asciimath to latex which would then be converted by the extension but it's not clear how to accomplish that. I'll look into this tho.
TL;DR: katex-latex is a showdown extension for latex math in markdown. MathJax is slow, and KaTeX is fast (really fast compared to mathjax) with the tradeoff of latex instead of asciimath.
what do you think of the use of latex instead of math ?

It is certainly cool to be able to use Latex in Markdown. But it’s still better to use AsciiMath. The idea is to save time of writing (time of parsing is not a big issue here)
There is a Latex package called asciimth (https://github.com/judah/asciimath-tex). It is old but it works. It use similar syntax to write math. Is it possible to use this package along with KaTeX?
From: obedm503
Sent: Monday, October 10, 2016 5:50 AM
To: arturadib/strapdown
Cc: TianBo-Timothy ; Author
Subject: Re: [arturadib/strapdown] Work with AsciiMath (#71)
after digging through MathJax's documentation I couln't find a simple method which would take a string of math and return html. So I looked for alternatives, and the internet gave me KaTeX. It does just what I wanted, and is alot faster than mathjax.
so, like you suggested, I created an extension for showdown (the parser used by bootmark) that uses katex to convert "latex code" to pretty math.
the syntax works like you suggested it should but instead of
some math here

it uses
some math here

since the "code" is in latex.
For a demo of the extension check this https://obedm503.github.io/katex-latex/
that page is built from multiple elements. some with markdown outside and some with markdown inside. Shared config is defined in the

turns out it wasn't so complex to add asciimath support.
check this for an example https://obedm503.github.io/katex-latex/ and it's source
the example builds the webpage from 2 markdown files (README.md and CHANGELOG.md) and some inline markdown (the second <bootmark> element), uses both the <bootmark> element and a div with class="bootmark", uses both latex and asciimath, uses a different code prettify theme than the default.
It is the finest of bootmark + math examples.
Let me know what you think.

I just tried out.
It’s wonderful!
I will definitely tell my friends about this!
Thanks!!
From: obedm503
Sent: Monday, October 10, 2016 8:14 PM
To: arturadib/strapdown
Cc: TianBo-Timothy ; Author
Subject: Re: [arturadib/strapdown] Work with AsciiMath (#71)
turns out it wasn't so complex to add asciimath support.
check this for an example https://obedm503.github.io/katex-latex/ and it's source
the example builds the webpage from 2 markdown files (README.md and CHANGELOG.md) and some inline markdown (the second  element), uses both the  element and a div with class="bootmark", uses both latex and asciimath, uses a different code prettify theme than the default.
It is the finest of bootmark + math examples.
Let me know what you think.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

just glad I could help


RancherD installation documentation fails every time (Ubuntu 20.04)

I'm trying to set up a rough test environment for RancherD on Ubuntu 20.04. I cannot for the life of me get an actually working environment (single node to start) when following the documentation.
This is the documentation I've tried about 3x times now: https://rancher.com/docs/rancher/v2.x/en/installation/install-rancher-on-linux/
There's at least two issues here:

After the initial provisioning, if I run "rancherd reset-admin" the webUI doesn't work when going to the URL. I am using the hostname in the tls-san section (as I don't yet need it to work against a FQDN).
If I reboot, and try "rancherd reset-admin" I get the error "FATA[0000] cluster and rancher are not ready. Please try later.: Local cluster is not ready yet" and this is after running the export command again "export KUBECONFIG=/etc/rancher/rke2/rke2.yaml PATH=$PATH:/var/lib/rancher/rke2/bin"

I have to ask, when was the last time this documentation was actually TESTED from scratch? I know that the documentation at the very top says this is "experimental", but I generally expected this to actually work far more than this. Especially since this is on the latest LTS version of Ubuntu, and RancherD has been available for so long.
I can't find any useful resources online either :/ so I'm stuck. And I'm liking the looks of RancherD more vs other methods.
Please help! I don't know what to do, and where the documentation needs improvement, as I don't even know what I'm doing wrong here.

FYI, according to issue https://github.com/rancher/rancher/issues/33423, it appears the currently documented implementation of RancherD is dead . I suspect it will be replaced by a new rancherd implementation being developed here: https://github.com/rancher/rancherd.

I installed RancherD twice in the last couple of days (2.5.8 on July 14th, 2.5.9 on July 21st) following the documentation in https://rancher.com/docs/rancher/v2.5/en/installation/other-installation-methods/install-rancher-on-linux/ and it worked both times without any problems.
Before running rancherd reset-admin I ran watch "kubectl get pods -n cattle-system;kubectl get pods -n fleet-system;kubectl get pods -n rancher-operator-system" to wait for all pods to become ready.


Issue 14 - Implementing a user-supplied redact function

Changed suppression_check.py to implement redacting based on a user-supplied redact column.
Added a "Redact" column to the example dataset
Modified the function call in the apply_anonymization.ipynb example to include a redact columm.

It looks like there may need to be a conditional in the code prevents a call to the UserRedact field if it wasn't provided by the user.  Or maybe adds it if it's not there.

@amstutzg1 It looks like this is failing CI for the same reason @VT-AOE-DMAD-Drew-Bennett's PR for Issue #15 was failing. If this was branched for develop prior to him merging in his fix, then I think you will need to merge develop back into your feature branch so the parameters in the test and the function align.
@VT-AOE-DMAD-Drew-Bennett Can you take a look and see if what I'm describing above is what's happening?

Okay I added some code so that an empty column is added in the event that the user does not supply a column in the function call. Looks like the check is passing now.


Is there a way to distinguish relationships?

First of all, thanks for the incredible effort.
Let's say that I would like to show divorced couples with a dashed relationship line, is that possible?
Thanks again for your time

Hi,
Thats a good point, and something I should probably include in the future,
but unfortunately I don't know any quick fix that can help you right now :/

Alright, thanks for the response


bvh.get_data()

Hello, I used this command last week and it worked :   local_rotations, local_positions, parents, offsets = bvh.get_data()
But today, when I try to run the code, this issue appears:

ValueError                                Traceback (most recent call last)
 in <cell line: 1>()
----> 1 local_rotations, local_positions, parents, offsets = bvh.get_data()
ValueError: too many values to unpack (expected 4)

I think I had the same error suddenly pop up just last week after using the 0.0.1 version extensively over the recent months without having any problems. For me, the error went away when I used a different BVH file (which is not a real fix, of course), so I never really looked into it more closely.
Could it be that some regression was introduced with the last update (0.0.2 or 0.0.3)?

Hi , I tried with diffrent Bvh files from diffrent datasets , but the error remains yet!

Ok, that's different from my experience. Guess we'll have to wait if @JLPM22 has any idea on this.

I used :    local_rotations, local_positions, parents, offsets,rotations_orders,joint_names = bvh.get_data()
and worked !!
I guess maybe in new version this new parameters added !

Hi!
Thank you for the feedback and for using pymotion!
Last week I updated pymotion so that the BVH class can store the end-sites of the leaf joints.
Now bvh.get_data() should be used as follows:
local_rotations, local_positions, parents, offsets, end_sites, end_sites_parents = bvh.get_data()
Sorry for the inconvenience, for future updates, I will try to keep compatibility with previous versions.
I will also update the examples in the Readme soon.
Let me know if there are any other issues :)

Many Thanks for updating me ...

Thank you for this great library! I used it in my master's thesis project and I will surely continue to use it in future research projects.

Thank you for this great library! I used it in my master's thesis project and I will surely continue to use it in future research projects.

I'm so happy to hear that! :) I'm excited to continue improving the library for future research!


WAS container with main label fails to start

I didn't have this problem before, but have recently started to see a startup failure on WAS container
image: ghcr.io/toverainc/willow-application-server:main
error:
  File "/app/api.py", line 207, in <module>
    app.mount("/admin", StaticFiles(directory="static/admin", html=True), name="admin")
                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/starlette/staticfiles.py", line 57, in __init__
    raise RuntimeError(f"Directory '{directory}' does not exist")
RuntimeError: Directory 'static/admin' does not exist

I have looked into the container, and it does seem there is nothing under static
╰─> docker run -it --rm ghcr.io/toverainc/willow-application-server:main /bin/bash
root@a6369e58506e:/app# ls -al static/
total 8
drwxr-xr-x 2 root root 4096 Oct 26 17:58 .
drwxr-xr-x 1 root root 4096 Oct 26 17:59 ..
-rw-r--r-- 1 root root    0 Oct 26 17:58 .keep

seems there was a change, switching to latest tag fixes it
leaving here for anyone else running into this, and closing the issue


Feature/add turkish language support 51

Hey @kcw-grunt , I still need to convert some of these comments back to english. Other than that we should be good to go. Do we test these or have UI Tests?
-Also, side note: Somehow I can't build again. Did anything change with the UnstoppableDomainsResolution pod? That's the one that is seeming to give me issues.

@kcw-grunt Still working on getting these comments back to english, but I did test that the turkish localized strings appear when you change the app language on a device. Can't speak to how good the translations are though ha

@kcw-grunt Comments are done. Looks like it's linked up properly but I may have missed something. I added tr to BartyCrouch but not sure I used it.
Also, I ended up writing a python script because this is a pain haha. Should be able to modify the script a bit and use google tranlate to do a future translation in a few minutes instead of a few hours lol.

Added these files in this ^ commit because I'd like to get your thoughts on if they should be included. And if not, why. @kcw-grunt

sweet @kcw-grunt I will. Sorry Ive been a bit MIA so far this week.

👀..need to pull it in a few hours.


Filter removed from Dashboard in 4.9 version

I recently upgraded from 4.8 to 4.9 and I see a few of the changes which have now been removed.

Filter - That provided flexibilty to filter my screenshots, based on Status/Name etc. It was of great help when I had huge amount of screenshots in the single build. Should we not consider replacing that filter there?
Introduction to pagination have restricted the usage for right arrow(Attached snippet) for navigation onto the next images once the images of one page have been completed.  If we can continue navigating to the images of next page that would be of help.

@priyankachaturvedi30 thanks for noticing

with pagination added filters gonna be reworked in scope of #194
good catch, will fix in scope of this ticket


Getting Aravis example code work for DMK23G274

Hi,
I am trying to get stream from DMK23G274 in C++ code using Aravis library on the ARM board with Ubuntu server. I've downloaded Aravis 0.3.6 from the repository:
https://git.gnome.org/browse/aravis/snapshot/ARAVIS_0_3_6.tar.xz
and after installing various packages, I finally was able to configure, compile and install aravis:
./autogen.sh --enable-gst-0.10-plugin --enable-gst-plugin
make
make install

The aravis example program now compiles, but running it gives the following error:
gstaravis could not be created.

I tried to capture images using gst-launch tool:
gst-launch-0.10 --gst-plugin-load=/root/ARAVIS_0_3_6/gst-0.10/.libs/libgstaravis-0.4.so aravissrc ! video/x-raw-gray,width=1600,height=1200,framerate=3/1 ! jpegenc ! filesink location=capture1.jpeg

By running this command I get the following output.
Setting pipeline to PAUSED ...

(gst-launch-0.10:30230): GStreamer-CRITICAL **: range start is not smaller than end for `GstIntRange'

(gst-launch-0.10:30230): GStreamer-CRITICAL **: range start is not smaller than end for `GstIntRange'
Pipeline is live and does not need PREROLL ...
Setting pipeline to PLAYING ...
New clock: GstSystemClock

This commands blocks until so I guess it has connected to the camera. However, the created capture1.jpeg is a zero-length file.

Issue closed since there were no answers


[cli] cannot install app into existing namespace

I would like to use the cli to install apps into an existing namespace. is there a customize flag, just like in the ui?
What kind of request is this (question/bug/enhancement/feature request):
question
Steps to reproduce (least amount of steps as possible):
rancher apps install kibana --answers values/kibana.yaml kibana -n logging
Result:
FATA[0001] namespace logging already exists
Other details that may be helpful:
Environment information
rancher version v2.0.6

Cluster information

Kubernetes version (use kubectl version):
Client Version: version.Info{Major:"1", Minor:"12", GitVersion:"v1.12.2", GitCommit:"17c77c7898218073f14c8d573582e8d2313dc740", GitTreeState:"clean", BuildDate:"2018-10-24T06:54:59Z", GoVersion:"go1.10.4", Compiler:"gc", Platform:"linux/amd64"}

I have the same problem.

Version: v2.2.3

Create project 16873 and create logging namespace in this project
Create API key for Rancher CLI in my case with no scope
Download CLI from rancher (v2.2.0)
Login to CLI and choose the 16873 project upon login

NUMBER    CLUSTER NAME   PROJECT ID        PROJECT NAME   PROJECT DESCRIPTION
1         david-223ec2   c-hdmzq:p-dncb9   Default        Default project created for the cluster
2         david-223ec2   c-hdmzq:p-jc5xf   16873
3         david-223ec2   c-hdmzq:p-jdqh4   System         System project created for the cluster
Select a Project:2
INFO[0011] Saving config to /Users/david/.rancher/cli2.json

Have your answers in a yaml and execute command to deploy the app in my case docker-registry
./rancher apps install docker-registry --answers values/docker-registry.yaml docker-registry -n logging

This worked for me. I didn't get the FATA[0001] namespace logging already exists error mentioned by the issue author.
I did run into an unrelated issue while the app was deploying and will investigate. If an issue needs to be created I will update this comment with a link to that issue.

@quorak I wasn't able to reproduce the issue in Rancher v2.2.3. If you have any questions or concerns please let us know and feel free to re-open the issue please.

People may with same prob:
Just make sure the namespace is under the current project in rancher configuration

People may with same prob:
Just make sure the namespace is under the current project in rancher configuration


Update strategies-for-backing-up-and-restoring-snapshot-and-transacti…

…onal-replication.md
Updated note with this after discussing with akbarf:
Setting of sync with backup option on distribution database is not compatible when publisher database is part of availability group. This could lead to following error when log reader agent runs post failover -

Learn Build status updates of commit 774f855:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/relational-databases/replication/administration/strategies-for-backing-up-and-restoring-snapshot-and-transactional-replication.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@MashaMSFT

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

if these new lines are being added all to the same note, the line breaks in between will need to contain   > or they will appear in the standard blockquote format and not as part of the note.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

https://github.com/MicrosoftDocs/sql-docs-pr/pull/25098 #8331 #please-close


Fix syntax for 0.980.0

Purpose
This PR will update the syntax according to Ballerina 0.980.0 syntax changes and update README with missing content

Shall we fix the typos in the readme as well? e.g., docker -> Docker

Shall we get rid of the complete programming language part in line 40 of readme.md? That doesn't make sense


Add codecov flags for unit and integration tests

Add codecov flags for unit and integration tests

Codecov Report

Merging #14446 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #14446      +/-   ##
============================================
- Coverage     64.24%   64.24%   -0.01%
  Complexity      425      425
============================================
  Files          2187     2187
  Lines         97025    97025
  Branches      12989    12989
============================================
- Hits          62337    62336       -1
+ Misses        29714    29710       -4
- Partials       4974     4979       +5

Impacted Files
Coverage Δ
Complexity Δ

...java/org/ballerinalang/bre/bvm/BLangVMStructs.java
48.33% <0%> (-3.34%)
0% <0%> (ø)

...va/org/ballerinalang/util/codegen/PackageInfo.java
83.15% <0%> (-2.11%)
0% <0%> (ø)

...ain/java/org/ballerinalang/net/websub/hub/Hub.java
69.53% <0%> (-1.57%)
0% <0%> (ø)

.../java/org/ballerinalang/bre/bvm/BLangVMErrors.java
72.91% <0%> (-1.05%)
0% <0%> (ø)

...e/src/main/java/org/ballerinalang/bre/bvm/BVM.java
78.44% <0%> (-0.04%)
0% <0%> (ø)

...a/org/ballerinalang/bre/bvm/WorkerDataChannel.java
81.48% <0%> (+0.61%)
0% <0%> (ø)
:arrow_down:

...a/org/ballerinalang/bre/bvm/GlobalMemoryBlock.java
79.41% <0%> (+0.98%)
0% <0%> (ø)
:arrow_down:

...va/org/ballerinalang/channels/ChannelRegistry.java
97.29% <0%> (+2.7%)
0% <0%> (ø)
:arrow_down:

...ballerinalang/stdlib/internal/file/CreateFile.java
84.61% <0%> (+30.76%)
0% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c9f49d...33fd90b. Read the comment docs.


x/net/html: provide convenience methods FirstElementChild/NextElementSibling

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

go version go1.6.1 linux/amd64

What operating system and processor architecture are you using (go env)?

GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/user/go"
GORACE=""
GOROOT="/usr/lib/go-1.6"
GOTOOLDIR="/usr/lib/go-1.6/pkg/tool/linux_amd64"
GO15VENDOREXPERIMENT="1"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0"
CXX="g++"
CGO_ENABLED="1"

What did you do?
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.

Here is a link to golang playground, but note that this library doesn't actually run on the playground. I am providing a playground link because I cannot format the code correctly here given the string formatting I am using.
https://play.golang.org/p/DrERE6s0tT

What did you expect to see?

The last printed div is supposed to have children as per the html string.

What did you see instead?

Instead it is parsed as a Text NodeType, and thus has no children, or even data.

One other thing to note is that calling html.Render will reproduce the missing elements, despite them not being represented as Nodes.

Nodes also contain TextNodes for their content (including whitespace), which is what you're seeing here.
Adding a test for section.LastChild.Type to your example shows it is of type TextNode (either with this simpler html or with your example). Removing the whitespace from your example means it works as you expect.
https://play.golang.org/p/uGfE2LTsjg
You can test this with a simpler version of the html, with some whitespace before the last section tag, which becomes the last child node:

So I don't think this is a bug?

Isn't whitespace supposed to be ignored as part of the HTML specification? I'm not sure if this is the right reference, but this portion of the HTML 5 spec is about space separated tokens, which I'm assuming should include tags.
https://html.spec.whatwg.org/multipage/infrastructure.html#space-separated-tokens

This may be a better resource. It specifically mentions inter-element-whitespace. It states that these Text nodes consisting of only whitespace must be ignored.
https://www.w3.org/TR/html/dom.html#inter-element-whitespace

Can you reproduce this in a browser using the DOM?  Obviously on rendering that content the whitespace would be ignored, but it does seem to be in the DOM, and I'm not sure why the spec is implying something browsers don't do there.
I will leave it to the maintainer to comment further but I hope this helps a little.

Interesting. I think I see what is going on here. It's not that the browser doesn't support this, it supplies it in a different way. Here is the functionality I have been expecting document.firstElementChild, which skips the empty Text Nodes as in the html specification. However, the net/html package only supplies the functionality of the form document.firstChild, which does not.
Given this realization, yes you are right to say that the package isn't malfunctioning. So in effect, this is actually a feature request rather than a bug report.

Chose not to edit previous post.
So the functionality I am looking for is easily provided by a for loop skipping over Text Nodes. Doing this manually provides me with the data that I am looking for as in this example.
https://play.golang.org/p/ZNKgZATPUI

@RayfenWindspear You can use this issue for tracking that addition. I don't know how likely it is to be accepted, though, since as you demonstrated it is easy to implement yourself.
/cc @adg @nigeltao Are we likely to add these methods?

Yes, whitespace is ignored, but at rendering time, not at parse time. kennygrant gave a javascript example, but for a Python example, this program:
#!/usr/bin/python

import html5lib

h = '''

Job Snapshot

            Base Pay
            $150,000.00 - $160,000.00 /Year

'''

doc = html5lib.parse(h)
for t in doc.itertext():
    print "[" + t + "]"

prints
[
    ]
[Job Snapshot]
[
    ]
[

        ]
[
            ]
[Base Pay]
[
            ]
[$150,000.00 - $160,000.00 /Year]
[
        ]
[
    ]
[
]

because those (whitespace) text nodes are part of the DOM tree.
As for a FirstElementChild method, I suppose it's possible, although it's straightforward to provide that as a function (in your package). It doesn't need to be a method (in package html).
Or, if you want to loop only over element children, it's trivial:
for c := n.FirstChild; c != nil; c = c.NextSibling {
  if c.Type != html.ElementNode {
    continue
  }
  etc
}

so I'm not convinced yet for the need for FirstElementChild and NextElementSibling methods.


Fix Facebook share button

Helping tool: https://developers.facebook.com/tools/debug/

Possible solution - fetch the image and add width and height in the Open Graph

Added default Open Graph image width of 1360. Needs further testing. If it works, the issue will be closed, otherwise each Image should save its width and height


DOC: Infinite Loop Detected Error on Old Version Website Access

URL
https://python.langchain.com/v0.1
Checklist

[X] I added a very descriptive title to this issue.
[X] I included a link to the documentation page I am referring to (if applicable).

Issue with current documentation:
When I tried to access the 0.1 version of the LangChain Python website at https://python.langchain.com/v0.1, I encountered the following error:
This Request has triggered an infinite loop.

Your connection is working correctly.

Vercel is working correctly.

508: INFINITE_LOOP
Code: INFINITE_LOOP_DETECTED
ID: hnd1:hnd1:hnd1:hnd1:hnd1:hnd1::szrhd-1725175871433-bfefc919473f

When accessing the 0.2 version of the website, it seems to be functioning well however.
Idea or request for content:
No response

I am facing the same issue. Please rectify as soon as possible since I was referring to some of them for my project.
https://python.langchain.com/v0.1/docs/use_cases/question_answering/
https://python.langchain.com/v0.1/docs/expression_language/how_to/message_history/
Or can someone please point me to the new location for these?

same

same

same

This issue seems to be resolved. Closed


Add ability to flush an Encoder.Feed

When using an Encoder.Feed directly, it'd be nice to be able to call doFinal w/o closing the feed so that multiple things can be encoded without having to instantiate a new feed. Having the ability to call flush will open up the possibility to perform multiple encodings within the .use lambda.
val sb = StringBuilder()
Base64().newEncoderFeed { encodedChar ->
    sb.append(encodedChar)
}.use { feed ->
    messageBytes.forEach { b -> feed.consume(b) }

    feed.flush()

    sb.append(':')

    signatureBytes.forEach { b -> feed.consume(b) }
}

flush() should be available for both Encoder.Feed and Decoder.Feed.
Because of some of the implementations that hold on to some stateful data, this should be implemented in the following manner:

Add EncoderDecoder.Feed.flush
Add EncoderDecoder.Feed.flushProtected
Encoder.Feed and Decoder.Feed use final override flush and call flushProtected

Implementors of EncoderDecoder.Feed were required to OptIn to the ExperimentalEncodingApi, so this is a "non-breaking" change

Actually, this can be done w/o the need to break the current API


Update plate correlation analysis

Here, the plate correlation analysis and corresponding README are updated using the recently updated analysis utils. Correlations are computed from cell morphology features aggregated to the well level. Feel free to add any constructive feedback you may have while reviewing this pr.

Thanks for the comments @jenna-tomkinson! Re-requesting a review

Thanks @jenna-tomkinson, merging now!


Fix Clients only in one line

pivpn clients script was showing clients in only one line, and titles were not properly aligned.
Fixed confits due to my local repo not syncing correctly, tested, everything is fine now!

Thanks!


Refresh token doesn't expires on revoking app permission

In my app, I want to give user capability to revoke access from app only, since revoking access can only be done manually according to this doc  , so I am opening that page for user in a separate activity with Webview inside the app.
Now on coming back from that page as the document says, refresh token should expire.

When consent for an app is revoked, any refresh token previously provided to your application will no longer be valid. You will need to repeat the authentication flow to request a new access and refresh token from scratch.

But when I try coming back and trying silent login, it logs in user successfully, even all the drive file related methods are working properly, which is not right flow.
Please see if it's a bug, or let me know I am doing anything wrong in this flow

Thank you for reaching out and for your patience. This SDK is being officially deprecated. See #172 for more information


Translate v3

Can you leave the translate_samples.rb file name as it was? The current older samples are pointing at that file, and they will break between when this PR is merged and when the links from cloud.google.com get updated to point to the new file names.

translate_samples.rb now seems to have been deleted outright.

How to even git? Unbody know.
(Fixed.)


Exception Caused by Serializer Finalizer

Summary
When executing the finalizer of a Serializer that is based on a non-closing stream wrapper, an Exception will be thrown if the file stream has already been closed before.
How to reproduce

In the real-world use case that is described here, the bug occurs non-deterministically.
It can, however, be reproduced by explicitly creating a serializer, using it on a wrapped stream, disposing the underlying stream and then waiting for the serializer to be garbage-collected.

Analysis

Investigate a potential Serializer leak, since it isn't disposed, but collected.
Investigate a potential bug in the finalizer implementation of Serializer.
Investigate desired behavior when invoking functionality on a wrapper stream when the wrapped stream is disposed. However, it is likely that throwing an ObjectDisposedException is the preferable behavior and the bug occurs because of using the wrapper in a bad / an unsafe way.

Attachments

Forum posting with details
Callstack:

   at System.IO.__Error.FileNotOpen()\r\n   at System.IO.FileStream.Flush(Boolean flushToDisk)\r\n   at Duality.IO.NonClosingStreamWrapper.Flush() in c:\\projects\\duality\\Duality\\IO\\Streams\\NonClosingStreamWrapper.cs:line 79\r\n   at Duality.Serialization.BinarySerializer.OnTargetStreamChanged(Stream oldStream, Stream newStream) in c:\\projects\\duality\\Duality\\Serialization\\BinarySerializer.cs:line 175\r\n   at Duality.Serialization.Serializer.set_TargetStream(Stream value) in c:\\projects\\duality\\Duality\\Serialization\\Serializer.cs:line 253\r\n   at Duality.Serialization.Serializer.Finalize() in c:\\projects\\duality\\Duality\\Serialization\\Serializer.cs:line 283

Fixed and release in progress. New binaries should be available in about 15 minutes.


Add timeout param

Adding a timeout parameter for search queries.
more details: https://www.elastic.co/guide/en/elasticsearch/reference/8.9/search-your-data.html#search-timeout

@buinauskas please merge this 🙏 (I'm not authorized to merge this)


Python package not usable since build system update

Thank you for all your work with this package. Uniform resampling has been a very useful in 3D Slicer and worked very well until the recent revamping of the build system. Now we cannot use it at all, because the package depends on a specific VTK binary package version. We cannot use the VTK in PyPI, because we - as many others - cannot use the exact same VTK build options that are used for the PyPI package.
Now that the implementation is in C++ the clean solution would be to implement clustering as a VTK filter and use VTK's Python wrapping.
You may contact @jcfr (Jean-Christophe Fillion-Robin at Kitware) if you need help with building clean VTK remote modules that use VTK's built-in Python wrapper (see for example https://github.com/Slicer/vtkAddon).

@lassoan, I'm curious why this is the case since the new build using nanobind and scikit-build-core doesn't rely on a specific VTK version. Could you please post the error you're getting? CMakeLists.txt and clustering.cpp only rely on numpy.

Thanks a lot for the quick response. Maybe I made a conclusion too quickly. I've started from this user report:
[Python] Failed to compute output model: DLL load failed while importing _clustering: The specified module could not be found.
Traceback (most recent call last):
File “C:/Users/kucerabi/Desktop/Slicer 5.6.2/bin/…/lib/Slicer-5.6/qt-scripted-modules/SurfaceToolbox.py”, line 278, in onApplyButton
self.logic.applyFilters(self.parameterNode)
File “C:/Users/kucerabi/Desktop/Slicer 5.6.2/bin/…/lib/Slicer-5.6/qt-scripted-modules/SurfaceToolbox.py”, line 579, in applyFilters
SurfaceToolboxLogic.remesh(outputModel, outputModel,
File “C:/Users/kucerabi/Desktop/Slicer 5.6.2/bin/…/lib/Slicer-5.6/qt-scripted-modules/SurfaceToolbox.py”, line 404, in remesh
if not SurfaceToolboxLogic.installRemeshPrerequisites():
File “C:/Users/kucerabi/Desktop/Slicer 5.6.2/bin/…/lib/Slicer-5.6/qt-scripted-modules/SurfaceToolbox.py”, line 387, in installRemeshPrerequisites
import pyacvd
File "C:\Users\kucerabi\Desktop\Slicer 5.6.2\lib\Python\Lib\site-packages\pyacvd_init.py", line 3, in
from pyacvd.clustering import Clustering
File “C:\Users\kucerabi\Desktop\Slicer 5.6.2\lib\Python\Lib\site-packages\pyacvd\clustering.py”, line 16, in
from pyacvd import _clustering
ImportError: DLL load failed while importing _clustering: The specified module could not be found.

Then saw the relatively recent pyacvd build system changes and connected the two, but maybe that was just a coincidence. While pyacvd depends on pyvista, pyvista does not install VTK, so the version that Slicer has should work well.
I've tried the latest pyacvd on a fresh Slicer installation and it still worked well. So, now I suspect that the issue is not with pyacvd but the user may have some problem specific to that computer. It might be a too aggressive antivirus software that removes the .pyd file for some reason.
I'll update you here when I get feedback from the user.

Thanks for the update.
I would prefer not reverting since there's both build and performance benefits from the new approach.

The user confirmed that downgrading to pyacvd<0.3 solved the problem (https://discourse.slicer.org/t/importerror-with-uniform-remesh/38448/6). It seems the problem only occurs only on certain computers.
I've checked the dependencies of _clustering.cp39-win_amd64.pyd and I've found that they depend on very similar MSVCRT libraries, but there is a huge difference: pacvd<3 does not depend on OpenMP, while pyacvd-3.0.3 depends on OpenMP (LIBOMP140.X86_64.DLL). OpenMP is not part of the operating system. It may be installed by various developer tools and may be distributed as part of applications. I don't know what is the current guidance for using OpenMP in Python packages - not to use OpenMP, bundle an OpenMP DLL with the package, depend on some Python package that provides OpenMP, etc.

No problem, I can remove openmp as a dependency. It's only used for a minor operation and not for the main application. Thanks for looking into this.

Sounds good! Let me know here when there is a new release to test with.

@lassoan, there's a new release at pyacvd==0.3.1 for you to test.

Thanks a lot, I'll let you know if it fixes the issue on that user's computer.

We haven't heard back from that user, so I assume everything is good. Thanks for taking care of this!


feat: Refurbishing design of Profile page (#214)

Also added dark mode theme

TODO:

Make Profile page nested
Add ACMG cards


Do not rely on isinstance to find the default engine.

This allows django_coverage_plugin to work again. (I still have to test django_coverage_plugin ;))

coverage output:
py35-djangotip create: /home/florian/sources/django_coverage_plugin/.tox/py35-djangotip
py35-djangotip installdeps: unittest-mixins==1.1, https://github.com/apollo13/django/archive/django_coverage.tar.gz
py35-djangotip develop-inst: /home/florian/sources/django_coverage_plugin
py35-djangotip installed: coverage==4.2,Django==1.10rc1,-e git+https://github.com/nedbat/django_coverage_plugin.git@6ca652519934cab7fa248f02e6197d0a459d90a9#egg=django_coverage_plugin,six==1.10.0,unittest-mixins==1.1
py35-djangotip runtests: PYTHONHASHSEED='3905908550'
py35-djangotip runtests: commands[0] | python -c import tests.banner
CPython 3.5.2+; Django 1.11.dev20161007122508
py35-djangotip runtests: commands[1] | python -m unittest discover -b
............ss.........................................
----------------------------------------------------------------------
Ran 55 tests in 0.370s

OK (skipped=2)
__________________________________________________________________________________________________________________ summary ___________________________________________________________________________________________________________________
  py35-djangotip: commands succeeded
  congratulations :)

@nedbat Can you verify that against the coverage plugin? I just did run the testsuite…

Florian, what's the status of this?

waiting on @nedbat for feedback on whether that fixes django-template-coverage or not

Sadly, I haven't had time to work on the Django template coverage plugin in quite a while.  I'm not sure how long it will be before it comes to the top of the list again.  If you know someone who wants to take on a project, let me know.  Sorry to drop the ball... :(

I just submitted a PR to django_coverage_plugin that solves the problem for dj-cov-plg (https://github.com/nedbat/django_coverage_plugin/pull/30) w/o requiring a fix in Django.  However, this PR would also have resolved the failing test.

Perfect, closing here.


[Fatal Error] AmplitudeTap in doHandleTapBlock

macOS Version(s) Used to Build
macOS Sequoia 15.0
Xcode Version(s)
Xcode Version 16.1
Description
Subject: Crash with AmplitudeTap on Specific Audio File
Hi,
I’m encountering a crash when using AmplitudeTap with this particular audio file. Could someone help me identify the issue and provide a fix?
Audio File: https://drive.google.com/file/d/17OeYc5L0mUG5qA7y70j57Uh8SCEO4Xni/view?usp=sharing
Thank you!
Crash Logs, Screenshots or Other Attachments (if applicable)

Hi, yes this file is crashing AudioKit for AmplitudeTap
7. Could It Be.m4a.zip


Build Rails app for production environment

Description
In our Soak Tests, we found out that a Rails app instrumented with OTel Ruby in development mode will use an unbounded amount of memory when receiving several requests.
CloudWatch showed a development Rails app using 11 GB of memory after just 2 hours:

We asked on the OTel Ruby CNCF Slack channel and got the great feedback that we should use a production environment.
This PR does that, and when we did that the Memory Usage was less than 1 GB after 5 hours:

However, to allow for a production environment, the rails app requires a "secret_base_key". Otherwise it will spam the log output with warnings which is really troublesome.
To solve this, we added dummy credentials which don't do anything. Because this is an example, we directly commit the security credentials in the Dockerfile but this is NOT GOOD PRACTICE FOR REAL PRODUCTION ENVIRONMENTS. We allow it to be like this because we want this demo example to work.
You can confirm the credentials work and view the encoded contents of by doing the following command:
$ cd sample-apps/manual-instrumentation/ruby-on-rails
$ RAILS_MASTER_KEY=<KEY_IN_SAMPLE-APP_DOCKERFILE> bin/rails credentials:edit

This will show the following contents:
# NOTE: DO NOT USE THIS IN PRODUCTION ENVIRONMENTS, WE ONLY SET THIS TO SIMULATE A REAL RAILS APP.

# Used as the base secret for all MessageVerifiers in Rails, including the one protecting cookies.
secret_key_base: DO_NOT_STORE_A_SECRET_THIS_IS_JUST_FOR_AN_EXAMPLE

Thanks for figuring this out and making it work!
Just out of curiosity, if the RAILS_MASTER_KEY is just a dummy credential, does it need to be in a certain format to work or can we simply replace it with something like "dummy_credential"?

@srprash Thanks for that prompt!!
I actually did test this with something like RAILS_MASTER_KEY=BOGUS_KEY but the tests immediately fail to start the app 😕:
app_1             | 2022-02-04 22:18:51 +0000 Rack app ("GET /outgoing-http-call" - (<IP_ADDRESS>)): #<ActiveSupport::MessageEncryptor::InvalidMessage: ActiveSupport::MessageEncryptor::InvalidMessage>

It's a good idea to post this in the README and PR description though so I've done that!


Documenting the FRSCA architecture

Draft pending the merge of #262.
This documents the architecture of FRSCA to hopefully answer some of the questions of how signing happens, and how Vault, Spire, and admission controllers are integrated.

Are Github triggers in place today?

Are Github triggers in place today?

Are you looking for a doc site preview? Or just seeing the CI succeed?

Are Github triggers in place today?

Are you looking for a doc site preview? Or just seeing the CI succeed?
Hi, nope just wondering if Github triggers has been setup as I don't see anything in Frsca and is its documented like it exists.  Could always have missed it.

Hi, nope just wondering if Github triggers has been setup as I don't see anything in Frsca and is its documented like it exists.  Could always have missed it.

Oh, the Git triggers into Tekton, I thought you were asking about the GitHub actions here.  There's a lot still left to develop.

@sudo-bmitch I know that it currently doesn't exist but there would be a connection with spire + pipelines also.

Based on the diagram I looks like spire server and vault are outside in a trusted k8s cluster. Which is great. But why is run-time visibility there also? Maybe I am understanding the diagram wrong.

@pxp928

I know that it currently doesn't exist but there would be a connection with spire + pipelines also.

Ok, I can flip some things around to make that easier to draw.

Based on the diagram I looks like spire server and vault are outside in a trusted k8s cluster. Which is great. But why is run-time visibility there also? Maybe I am understanding the diagram wrong.

I was aiming for trust boundaries, but there's a good chance that needs to be moved to be along side the admission controller. The part I want to be sure of is if an attacker does something in a task that manages to escape, runtime visibility should both detect that, and not be able to be disabled by that malicious code without some kind of detection.


sqlite connector: execute() silently ignores statements after the first one

Thanks for the lovely library.
Adding this here quickly mainly for visibility (might be helpful for others). The sqlite connector uses the sqlite API call sqlite3_prepare_v2() when processing a statement string via connection.execute(statement).
Sqlite docs for this API call state (emphasis mine)

If pzTail is not NULL then *pzTail is made to point to the first byte past the end of the first SQL statement in zSql. These routines only compile the first statement in zSql, so *pzTail is left pointing to what remains uncompiled.

I found this because I was debugging a situation where I called execute() with a string with more than one CREATE TABLE ... statement (separated by semicolon), and only the table corresponding to the first statement was created.
As a user, I can of course work around that. I don't want to recommend any specific action item here. But of course we may want to adjust docs, or do some magic given pzTail mentioned in the sqlite docs.

Maybe we should just change sqlpp::sqlite3::connection_base::execute() to use sqlite3_exec() instead of calling prepare_statement() and then executing the prepared statement.
Here they claim that sqlite3_exec() is able to handle correctly multiple statements separated by semi-colon(s):

The sqlite3_exec() interface runs zero or more UTF-8 encoded, semicolon-separate SQL statements passed into its 2nd argument, in the context of the database connection passed in as its 1st argument.

Thanks for the report and the discussion so far! And sorry for the late reply, I was offline for a bit.
My preference is to

document that this is for one statement only
fail explicitly if there is more than one statement (probably using pzTail).

Rationale: Executing one statement is supported by all backends and the behavior is pretty much the same in that case. Executing multiple statements is conditionally possible and the behavior is non-uniform. See for instance

https://dev.mysql.com/doc/c-api/8.0/en/mysql-query.html
https://www.postgresql.org/docs/current/libpq-exec.html

The rationale is  a bit weak as postgres supports multiple statements by default. But I would rather look into ways how to restrict that then allowing multiple statements for all backends.
WDYT?
Thanks,
Roland

@rbock

My preference is to
1. document that this is for one statement only

2. fail explicitly if there is more than one statement (probably using `pzTail`).

I am OK with either approach as long as it is uniform across all the connectors. So basically I am OK, with your suggestion.
However it should be noted that PostgreSQL supports natively multi-command queries, where commands are separated by semi-colons. From the libpq documentation  for PQexec

The command string can include multiple SQL commands (separated by semicolons). Multiple queries sent in a single PQexec call are processed in a single transaction, unless there are explicit BEGIN/COMMIT commands included in the query string to divide it into multiple transactions.

So maybe we should change the PostgreSQL connector to use [PQexecParams](https://www.postgresql.org/docs/current/libpq-exec.html#LIBPQ-PQEXECPARAMS), for which they say:

Unlike PQexec, PQexecParams allows at most one SQL command in the given string. (There can be semicolons in it, but not more than one nonempty command.) This is a limitation of the underlying protocol, but has some usefulness as an extra defense against SQL-injection attacks.

What do you think?

Switching to PQexecParams is tempting to get uniform behavior as you mention.
However, it will almost certainly break existing code. So this will require some transition and/or communication strategy.

I dealt with the immediate issue first: instead of silently ignoring following statements, the sqlite3 connector now throws an exception.
The others are unchanged except for documentation.

Considering the reported issue fixed.


General: Replay Prevention

To prevent replay attacks, signature construction need to take into consideration more than just the transaction's message. At the very least, it should take into consideration the account sequence (nonce), so that the transaction cannot be rebroadcasted successfully, given that the nonce would have changed.
Changing this from the signature verification side will affect any component using ixo-blockchain that signs transactions, including the blockchain itself, given that it signs transactions for example when the user uses the CLI to submit a transaction.

Closed by #129


Embeddable Behaviors

Idea, to add ability to have Behaviors for Embeddable
#[Embeddable]
#[Behavior\CreatedAt(column: 'created_at')]
#[Behavior\UpdatedAt(column: 'updated_at')]
#[Behavior\SoftDelete(column: 'deleted_at')]
class UserTimestamps
{
    #[Column(type: 'datetime')]
    public \DateTimeImmutable $createdAt;

    #[Column(type: 'datetime')]
    public \DateTimeImmutable $updatedAt;

    #[Column(type: 'datetime', nullable: true)]
    public ?\DateTimeImmutable $deletedAt;

}

Hi. I think that issue should be opened in https://github.com/cycle/orm

open in: https://github.com/cycle/orm/issues/473


Proposal: Move all ProjectSettings access to a new DialogicSettings.gd file

Is your feature request related to a problem? Please describe.
While working on various fixes/features for Dialogic, I've noticed that a lot of Dialogic settings (ones using ProjectSettings) are accessed in multiple places, leading to default values needing to be defined in multiple places, as well as the string-based keys being all over the place leading to potential typos or repeated const definitions in multiple places.
Describe the solution you'd like
I propose we move all of these into a new DialogicSettings.gd file as static get/set functions so that default values and string-based keys are only defined in one place and accessed as DialogicSettings.get_translation_enabled() instead of ProjectSettings.get_setting('dialogic/translation/enabled', false). This will minimize the chances of typos, and remove the need to change values in multiple places if a default value for something needs to be changed. It also allows us to utilize autocomplete more effectively when working on the Dialogic code.
Describe alternatives you've considered
N/A
Additional context
N/A

This has been considered before. However it kinda defeats the purpose of the modules, because it means they are no longer self-contained. The best alternative I can think of is putting the settings on the subsystems they most closely belong to and giving the subsystem a class name. However this would result in a bunch more class names (and dialogic is already flooding projects with a bunch of custom classes. It's unfortunate that we cannot mark classes as not to be exosed to the add node dialog).

Yeah that was my original thought as well. I had first investigated about having them on the subsystems, only to later realize they aren't tool scripts (alongside the Dialogic autoload also not being a tool script).
I just thought of this while typing this so it might not be fully fleshed out, what if we made the DialogicSettings.gd have a generated list of the subsystems like DialogicGameHandler.gd does (or a new DialogicModuleSettings derived class instead of DialogicSubsystem) that can be added to the indexer. This way each module can have it's own settings accessed as DialogicSettings.Audio.get_whatever() and they can still be unnamed classes because the type can be bound using preload like the subsystems are. This way each module can have a module_settings.gd or something, and it can be added to that modules index.gd file. This would keep them self contained, while still providing the other benefits and only adding 2 new global class names. This also means that settings that don't currently have a module could be added to core, but with a different group name, for example translation settings could be under DialogicSettings.Translations.get_whatever(). This would allow them to be moved to a different module in the future if needed, without having to change how they are accessed everywhere.
I also heavily lament that fact that Godot doesn't have any kind of namespaces or way to limit global class name pollution which would help alleviate these kinds of problems from the start but, that's unlikely to be implemented anytime soon. :sob:

Well traits have been discussed for ages now, but yeah, unlikely they will happen soon. I kinda like your proposal. It does feel a bit over-kill, as it's a lot of effort for something that is already kinda working and just not pretty, but I could see it certainly being useful. And I certainly can't think of a much better version rn.

I can move forward with an implementation if you want, after I finish the new audio event.


Functional test failure graceful exit

This is in preparation of exposing kernel-mode XDPAPI #196
To reduce the chance of a kernel mode functional test failure causing a crash, make test failure code paths gracefully return.
Making this a separate PR as the diff is rather large and doesn't depend on the kernel mode API

Closing PRs for deferred/cut kernel tests/NMR.


New version: aimotrens.impulsar 0.13.3

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

I have retested the manifest with winget install --manifest .... and it works. Is this the same Error as in #157223 ?

Automatic Validation ended with:

Installation failed with exit code -1978335187
2024-07-16 00:09:27.580 [FAIL] Installer failed security check. Url: https://github.com/aimotrens/impulsar/releases/download/v0.13.3/impulsar_windows_amd64.zip Result: 0x80004005

Automated error analysis suggests -1978335187 may mean Installer failed security check. Another script should retry this every 18 hours.
(Automated response - build 886.)

/azp run

Automatic Validation ended with:

Installation failed with exit code -1978335187
2024-07-16 18:32:19.003 [FAIL] Installer failed security check. Url: https://github.com/aimotrens/impulsar/releases/download/v0.13.3/impulsar_windows_amd64.zip Result: 0x80004005

Automated error analysis suggests -1978335187 may mean Installer failed security check. Another script should retry this every 18 hours.
(Automated response - build 886.)

/azp run

Automatic Validation ended with:

Installation failed with exit code -1978335187
2024-07-17 13:33:18.969 [FAIL] Installer failed security check. Url: https://github.com/aimotrens/impulsar/releases/download/v0.13.3/impulsar_windows_amd64.zip Result: 0x80004005

Automated error analysis suggests -1978335187 may mean Installer failed security check. Another script should retry this every 18 hours.
(Automated response - build 886.)

/azp run

Automatic Validation ended with:

Installation failed with exit code -1978335187
2024-07-18 11:34:22.601 [FAIL] Installer failed security check. Url: https://github.com/aimotrens/impulsar/releases/download/v0.13.3/impulsar_windows_amd64.zip Result: 0x80004005

Automated error analysis suggests -1978335187 may mean Installer failed security check. Another script should retry this every 18 hours.
(Automated response - build 886.)

/azp run


Add SSRPHandler and update SqlConnector

Addressing issue https://github.com/dotnet/SqlClient/issues/2644

Added basic version of SSRPHandler.
Updated HandlerOrchestrator as a singleton class
Added SqlConnector related changes to initiate a chain.
Minor typo fix

Remaining tasks are added as TODO.

Update SSRPHandler to get DAC port and use it for connection
Reset function in SqlConnector Close()

@samsharma2700  I dont see the code to resolve the SQL server port for Non-DAC connections. Should that be added to the TODO as well  ? Or am I missing some code?

Closing PR for now, until we get back to ClientX


use options.KubeConfig to check if loading API is needed

Signed-off-by: Wayne Witzel III<EMAIL_ADDRESS>Which issue(s) this PR fixes

Fixes #1128
Fixes #1129

Tested on my machine and it works well (note: I was also not able to repro the issue on my machine before the fix).
Notice that when I remove current-context field from bubeconfig file, Octant fails to start with this:
unable to start runner: failed to start service api: failed to init cluster client: invalid configuration: no configuration has been provided, try setting KUBERNETES_MASTER environment variable

Since that used to make Octant show the Add a new kubeconfig popup, I thing this is much better than before (and as Wayne just pointed out to me, kubectl fails in that case too).

I extended our error message to hint at checking the current-context

Testing various ways to provide a kubeconfig (command line flag, environment variable, manual input through UI) will be need be expanded upon from the e2e proposal in #810


Passable Wiki

The wiki needs to be up and usable for those looking for information.
A history of the development process would be good.

This wiki shall be postponed until later


flatpak uninstall --unused

Is it possible to run an equivalent to
flatpak uninstall --unused --noninteractive --assumeyes or flatpak uninstall --unused -y
declaratively right after periodic autoupdates to clean storage?

Yes, that would be useful.
While this feature is not currently supported, it should be straightforward to implement. I wouldn’t enable it by default, but this cleanup could be performed when users set services.flatpak.uninstallUnmanaged=true.


[Discussion] Map Architecture

A map architecture which welcomes multiple map formats/companies/organization/researchers.

A.I.

[ ] Dig down map abstraction layer

@msmcconnell
Yes, I am aware of the center line calculation.
However, there is no connection information between the center lines of each lanelet. You have to reference back to lanelet connection in order to connect the center line, which I thought is bothersome if we mainly use center line for calculation. Also, points of the centerline doesn't have unique ID, and we have to assign them by our hands.
I have a feeling that we at least need to re-organize or modify Lanelet to some extent in order to use it in Autoware without stress. Once we do that modification, we have to convert them back to Lanelet format to use Lanelet2 functions, which kind of weakens the merit of using Lanelet2 in calculation efficiency.

However, the key for an interface like that proposed above is how we represent the lane geometry and connections in ROS messages.

I also think this is very important. I've asked in Lanlet2 if they have such interface, but they said that it will be available later this year.
https://github.com/fzi-forschungszentrum-informatik/Lanelet2/issues/7

@mitsudome-r
Those are valid concerns with regards to LaneLet2 and probably worth sharing in the other issue page as well.
Why don't we start moving this issue forward by identifying the high level data we need even if some details like (lane id) may not yet be determined.
For this purpose, I have created the following document. Please leave comments. After we agree upon a data set and access method, we can start outlining ROS messages.
https://docs.google.com/document/d/1bRKtcFLnzv0C-zgzOpggp7TU2MW1y8Q0NgVNhGVSMT4/edit?usp=sharing


CAMEL-18637: camel-http support for OAuth2 client credentials flow

Description
Adding oauth2 authentication to camel-http component as requested in that Jira issue.

Target

[x] I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

[x] If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

[x] I checked that each commit in the pull request has a meaningful subject line and body.

[x] I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

When done with code I will provide documentation.

You need to fully build the project. There are uncommitted changes. I'll take a look later

Pushed missing files.

I think I'm done. Could someone take a look?

Do you have test failure locally with HttpNoConnectionRedeliveryTest ?

Ok PR is now passing


any reason to use file here https://github.com/cbgaindia/parsers/blob/master/pdf_to_csv.py#L95 instead of open ?

Could you explain more about this here? Where should we put this?

why not open(self.temp_pdf_file, "wb") instead of file(self.temp_pdf_file, "wb")


Update user-defined-data-type.md

Fixed spacing

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

VBA/Language-Reference-VBA/articles/user-defined-data-type.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Historychange event is triggered at wrong times

A needupdate event now triggers the historychange event to the external page. The needupdate is triggered whenever dialogues should close (also when there's no dialog) and through setting a needupdate property in the entities model. A clever hack but it's not resulting in the correct behaviour and has unwanted side effects.
A more correct solution is refactoring of the events-system so that change events can be either persistent or not. A persistent change event would replace the needupdate event. This requires passing event objects instead of a string when propagating.
A persistent change event on tool level then triggers a historychange event which the browser can use to update the URL and/or browsing history.
Possibly the name historychange of the event to the external page should be changed (it doesn't describe the event which happened in Vizabi).
Maybe just passing the change event to the page is the easiest and best.
This will also fix #916, #917 and will allow external pages to handle #932 as they wish.

If we change the event to the external page I guess that would mean we change the public api and thus going to 0.9 according to semver @arthurcamara1 @angieskazka?

can you also look into #932 together with the event issues?

Yep, think it's all part of this bigger thing event & public API thing, but I need your input on the API too, I don't want it to be a one-sided thing where it's just my ideas.

:+1:

@arthurcamara1
I'm rethinking the event registration to have a eventType, targetPath and function, so that you can register with this.model.on('change', 'marker.axis_x.min', function() {}) which will be translated to this.model.marker.axis_x.min.on('change', function() {}).
Question: what would be the right form for the 'many registrations in one go' object parameter? It's mainly used as this.model_binds, the predefined bindings in tools/components before the model is ready.
this.model_binds = {
    // 1. event type with array to allow multiple path-function combinations
    change: [
        // 2. path single value, function array: bind multiple functions to one event
        {
            path: 'marker.axis_x.min',
            func: [ function1, function2 ]
        },
        // 3. path array, function single: bind one function to different events (of one eventType)
        {
            path: ['entities.show', 'entities2.show'],
            func: function3
        }
    ],
    // 4. medium: evenType with one object with path-function combination
    init: {
        path: 'marker.axis_y.max',
        func: function4
    },
    // 5. simple: evenType with the function to bind to it
    ready: function5
}

How much flexibility should we allow?
Should every value (path or function) be either a value or array of values?
Should event types be able to have functions, objects and arrays as values (1, 4 and 5).
And is the above even a good notation? Below you can compare it with a less flexible, simple but readable notation, containing the same info as the upper.

// complex, flexible, concise
this.model_binds = {
    change: [
        {
            path: 'marker.axis_x.min',
            func: [ function1, function2 ]
        },
        {
            path: ['entities.show', 'entities2.show'],
            func: function3
        }
    ],
    init: {
        path: 'marker.axis_y.max',
        func: function4
    },
    ready: function5
}

// simple, not flexible, verbose
this.model_binds = [{
        type: 'change',
        path: 'marker_axis_x.min',
        func: function1
    },{
        type: 'change',
        path: 'marker_axis_x.min',
        func: function2
    },{
        type: 'change',
        path: 'entities.show',
        func: function3
    },{
        type: 'change',
        path: 'entities.show2',
        func: function3
    },{
        type: 'init',
        path: 'marker.axis_y.max',
        func: function4
    },{
        type: 'ready',
        func: function5
    }
}

that looks like an overly complicated syntax: adds 2 lines per function call and the need to remember "change", "path", "func" thing.

but of course we can get used to it if it's needed

not sure if putting ready and init inside model_binds is cool. isn't it better to have less of nested things?

looks not related to the original issue, but rather like some by-optimisation

so, i'm not very excited, but i might not see all the benefits the new syntax suggests.
i suggest wait and see what @arthurcamara1 says

to bind many functions to one change item we now do something like this:
so it's possible
      "change:entities:select": function() {
        if(!_this._readyOnce) return;
        _this.selectDataPoints();
        _this.redrawDataPoints();
        _this._trails.run(["resize", "recolor", "opacityHandler","findVisible", "reveal"]);
        _this.updateBubbleOpacity();
        _this._updateDoubtOpacity();
      },

So far, we've had the type and the path together as "change:state:marker". The type is change, the path is the rest. While keeping those two together seems to be semantically confusing, it has a few advantages:

We can write events as key-value pairs:

this.model.on({
"change:state": function(){},
"change:language": [func1, func2]
});

It's very simple to write, less verbose and shorter.

It's simple to compare, we just compare the full string to match events, no need to check type and path.

It ultimately involves less object manipulation.

So while I am convinced that fixing the events for updates and URL is needed, I'm not so convinced this syntax is an improvement of the syntax as a whole.
I agree with you that some changes should be marked as persistent, and also that persistent is a bette name than historyChange. But that could also be just another event with parameters or even a parameter passed when triggering each "change" event callback.

We could also opt for something like change:state.marker.size

@angieskazka @jheeffer

@angieskazka

What would be a better syntax? The current syntax (on('change:marker:axis_x:max', func)) combines the event type and path in one string variable. We could leave it as syntactic sugar for setting the events, while using the separated version on a programming level. Preferably what Arthur says 'change:marker.axis_x.max'.

correct, while working on events, I figured this would be a good fix too. This will remove a lot of string functions that were used before when registering and triggering events.

ready and init are just examples for events that are actually in Vizabi and that are used at some places in the model_binds

I didn't understand point 2, @jheeffer

For example the splits/joins in
https://github.com/Gapminder/vizabi/blob/develop/src/base/events.js#L50-L68
https://github.com/Gapminder/vizabi/blob/develop/src/base/events.js#L120-L124

To your previous post @arthurcamara1

Yes the key-value pair notation is very easy to read, concise and simple. That's why keeping it as syntactic sugar could be alright, for the API. But we'd pull it apart internally to type and path right away.

For comparison: when would you compare? I believe right now only in unbinding you're using a comparison of some sort. Unbind is (1) not used anywhere and (2) not working because it was written for the old way of registering (to 'this' instead of first descending down the path). That's why we should refactor it now to unbind(eventType[, path][, function]). This way you can:

unbind specific functions or all functions at once

do so on descendants

do so for any eventType. Possibly leaving out eventType could unbind all events altogether (though we have unbindall for that now, which can again be kept for syntactic sugar)

Not sure what you mean with object manipulation. There's no need to manipulate the objects, just read them out. While the other notation requires string-manipulation (splits/joins).

fixed with event refactoring https://github.com/Gapminder/vizabi/commit/e942f03007299f397d71e5578f37b14feed04185


Fix multiple admin boundaries

Fix visibility for multiple admin boundaries (issue #178)

before (boundary is not clear when layer transparency is high)

after

Thanks @hafidz142. This works well for a single layer, but when I increased the opacity for an exposure analysis, or 'run analysis' results layer, the admin boundaries become hidden. See the screenshots below for examples from Myanmar, but the issue exists in any deployment.
Select tropical storm layer, and date May, 21, 2016. Then click exposure analysis button, and increase result layer's opacity:

Run analysis on any hazard and vulnerability layer, then increase opacity of results layer:

@hav142 - the latest commit fixed the issues I found earlier. I also verified that this works as expected when using the selection feature in the alert module
@ericboucher - can you review or assign for technical review?

I like what you did, but you need to make it more explicit and add a few comments to explain that we are:
* setting boundary layers to be before firstSymbolId

* setting all other layers to be below the first boundary layer

I noticed that not all layer types have a before parameter, such as WMSLayer which uses the before setting in the component itself. should we uniformly use this before parameter for the other layer types?

I like what you did, but you need to make it more explicit and add a few comments to explain that we are:
* setting boundary layers to be before firstSymbolId

* setting all other layers to be below the first boundary layer

I noticed that not all layer types have a before parameter, such as WMSLayer which uses the before setting in the component itself. should we uniformly use this before parameter for the other layer types?

@ericboucher - can you give some final feedback to @hav142 on this?

Ah, sorry. I just found a minor issue with an edge case. If you toggle between admin level data layers with different associated boundary files, the admin 1 boundary doesn't seem to come back to the top. See screenshots below. First one is before toggling to a lower level admin level layer, the second is after.
Steps to reproduce:

REACT_APP_COUNTRY=mozambique
Activate layer vulnerability/multidimensional poverty index
Next activate layer exposure/total population
Bump up opacity to 100% and you'll see the admin1 level boundary is no longer on top

there is another issue when we activate analysis layer. when a layer has it own unique boundary, we can't use before parameter since the boundary layer will not be available on the map and it causes an error. So, I added a condition that if the layer has its own boundary, it will use the setting instead of the before parameter.

Nearly there from a functionality perspective. The last issue I came across is that after running an analysis with a unique boundary, and then clearing the analysis, we should see the default boundaries again.
To reproduce:

REACT_APP_COUNTRY=mozambique
Run this analysis: http://localhost:3000/?analysisHazardLayerId=rainfall_dekad&analysisBaselineLayerId=mpi&analysisDate=2022-07-21&analysisStatistic=mean
Clear analysis results using 'clear analysis' button. The map shows admin1 boundaries instead of reverting to default admin2 boundaries

@hav142 - The last issue mentioned regarding reverting back to the default boundary file after running an analysis works. But, if I load an admin data layer which is not the default, and then load a WMS layer, nothing happens. Steps to reproduce:

REACT_APP_COUNTRY=mozambique
Load vulnerability / multidimensional poverty index layer
Load any WMS layer (ex. 10-day rainfall anomaly). The WMS layer doesn't load

This is specific to admin data layers which do not use the default boundary. See screenshots below of the app and errors in console.

I think this is a good example of why we should implement cypress tests to toggle layers on/off.
@wadhwamatic could write a layer test protocol that we could implement? I.e. a sequence of layers we want to turn on/off. And we can then add it as part of the CI

I think this is a good example of why we should implement cypress tests to toggle layers on/off. @wadhwamatic could write a layer test protocol that we could implement? I.e. a sequence of layers we want to turn on/off. And we can then add it as part of the CI

@ericboucher - sounds good. I don't have time to do this now but please create an issue and we can get to this later

@hav142 - this is looking good now. thanks for all the changes. @ericboucher - could you give a final code review?


Initial location

How do you specify the initial location?  In the simulator, the map always starts in the North Sea.

You can not pass in a config for the viewport currently, which is not implemented yet.
The default map view is based on the device location.
Workaround: In iOS Simulator menu, go to Debug -> Location -> Custom Location.

It would be great if you could provide an initial location. When editing an existing record with a location, I'd like to start the map at the already assigned location.


doc: path to docs in examples/cfg.yaml

Just made these edits in my config. Thought I'd help you out. Thanks for the nice app!

https://github.com/alex-courtis/way-displays/pull/141

Many thanks!


XCloud menu item missing from main nav bar

The XCloud menu item is missing on a signed in account. Not subscribed to game pass but I play Fortnite on steam deck using the MS recommended method. Is game pass required for this menu item to show up?

Gamepass is indeed needed to have this to show up. I will check if it is possible to get fortnite running in the app