drivers: pwm_nrf5_sw: Fix the driver and make it support nRF9x SoCs

This PR makes the blink_led sample working (again) on boards with nRF52 series SoCs. The SW PWM driver is selected for them instead of the default HW one, as the latter cannot handle periods longer than ~262 ms (this is a hardware limitation).
It also fixes a couple of issues (details below) found in the pwm_nrf5_sw driver and makes it support nRF9x SoCs as well, so that the blink_led sample can be run on boards equipped with those.
drivers: pwm_nrf5_sw: Use dynamically adjusted timer prescaler
Adjust the timer prescaler used by the pwm_nrf5_sw driver according to
the requested period length, so that it does not need to be specified
at the build time. Remove the incorrect "scaling" that was done to the
requested pulse and period cycles to fit them into 16 bits.
samples: blink_led: Use nRF SW PWM driver for nRF52 boards
The nrfx Hardware PWM driver cannot be used in this sample
since the driver does not allow to set a period longer than ~262 ms.
drivers: pwm_nrf5_sw: Correct the use of GPIOTE channels and TIMER
GPIOTE base channel number taken from DeviceTree was not used
consistenly, hence the driver could properly work only when this
number had the value of 0.
TIMER was not stopped during the reconfiguration of the channel
and this could lead to the inversion of the PWM polarity.
The config structure was removed on the occasion as it unnecessarily
complicated the code of this currently single-instance only driver.
drivers: pwm_nrf5_sw: Use nrfx HALs instead of direct register accesses
Now instead of accessing peripheral registers directly, the driver
uses the nrfx HAL functions. This makes the code easier to maintain
and also gives the possibility to use pins from GPIO port P1 on
nRF52840 (absolute numbers 32-47) as the GPIO HAL provides the needed
translation.
drivers: pwm_nrf5_sw: Refactor the code
Move all channel initialization code that does not need to be executed
on every pin reconfiguration (like initialization of the PPI channels)
to the driver initialization function. Simplify the routines that check
the requested period and find a suitable channel for driving the pin.
drivers: pwm_nrf5_sw: Make the driver support nRF9x series SoCs as well
Now the driver uses DPPI or PPI depending on the presence of one of
these interfaces in a given SoC, hence it can be used on nRF9x SoCs
as well. Remove the '5' from its name then, and make the blink_led
sampe use it for the nrf9160_pca10090 board, thus making the sample
working properly on this board.
Fixes #15323.

Fixed checkpatch and codeowners issues.

Is there a filed bug for this PR? Otherwise, it shouldn't go to 1.14 - we are close to release, AFAIK

Is there a filed bug for this PR? Otherwise, it shouldn't go to 1.14 - we are close to release, AFAIK

I am not aware of any. The bug was reported on slack:
Aaron Tsui 9:15 AM, March 22nd
BTW, As the PWM_CLK lowest is 125khz(16M/128) and COUNTERTOP max is 0x7fff on nrf52, my understanding the nrf52 HW PWM longest period is about 262ms, cannot reach period as 1000ms. right?
@gaute this will cause failure on sample/blink_led, which need a 1000ms period.

cc @overheat

@anangl @ioannisg I didn't raise an issue specific for this topic. But I think this is related to #14749, which is verifying samples. Since this is a basic sample bug, I think it's better to be solved before the LTS version released.

Added one line that I somehow lost during splitting the changes into several logical commits. Sorry about that.

@ioannisg

Is there a filed bug for this PR? Otherwise, it shouldn't go to 1.14 - we are close to release, AFAIK

I am not aware of any. The bug was reported on slack:

[..]

Sure. Could you file an issue in GH with "bug" and 1.14" that relates to the slack report?

Created #15323.

Removed a no longer needed overlay file that was changing the clock-prescaler property eliminated by this PR.

Do these change also address the issue raised in #8628 (Fix polarity issue when using multiple channels) in the SW PWM driver?

@henrikbrixandersen

Do these change also address the issue raised in #8628 (Fix polarity issue when using multiple channels) in the SW PWM driver?

Yes, they do. By stopping the timer. But I think I'll try to use the solution with PPI channel group, as proposed by @cvinayak in https://github.com/zephyrproject-rtos/zephyr/pull/8628#discussion_r210176762.

Applied a couple of minor corrections.

Rebased on master.

Applied adjustments needed after rebasing.

Rebased on master to resolve the conflict in samples/basic/servo_motor/src/main.c.

@MaureenHelm can you please take a fresh look at this one?

@cvinayak @kl-cruz @nordic-krch can you please take a look?

Rebased on master.

@anangl is there any way to detect if there is conflict in TIMER instance usage?

Replaced (as a fix for #15323) by #20369.


isSame behaves differently with null and undefined

moment().isSame(null, 'year') // -> false
moment().isSame(undefined, 'year') // -> true

The latter case seems wrong to me, I would expect false for both. Seems to behave the same for any unit.

I think this is because the underlying methods used behave the same as when you do moment(undefined) vs moment(null). Null produces an invalid date object, while undefined is no different than doing moment() which produces the current datetime wrapped as a moment object.

I guess that makes sense, it just leads to unexpected behavior in cases where you have a parameter being passed to a function and it gets coerced to "now" in these cases. I guess I'll just add an explicit check

@MattKunze I agree that these comparator methods shouldn't have this hidden gotcha.

Maybe I'll take a quick peek at some point and try to put together a PR, looking at the source it doesn't seem terribly difficult. Perhaps just defaulting the input value to null in cases where the default coercion is undesired would work.
I guess the question would be coming up with the list of functions where undefined should be explicitly handled as input

I was bitten by this as well: m.isSame(x,'day') returned true for x===undefined... spent some time finding the issue in my code


[stable/sonarqube] Duplicate scheduling settings in deployment.yaml template

Describe the bug
The deployment.yaml file contains duplicate entries of the elements nodeSelector, hostAliases, tolerations and affinity. The problem is that the first occurence between L102 and L118 of these elements is right in the middle of the initContainer array.
This leads to a failed helm install when using for example affinity and the plugin install init container.
As the elements in question have their correct occurence between L239 and L251 it should be save to simply remove the first, incorrect ones.
A workaround is to remove the node scheduling settings from the values.yaml.
Which chart:
stable/sonarqube 3.2.7
What happened:
When using affinity and the plugin install init container, the chart installation fails with the message:

Failed to install app sonarqube. Error: YAML parse error on sonarqube/templates/deployment.yaml: error converting YAML to JSON: yaml: line 97: did not find expected key

Line 97 in my case was the duplicate entry of affinity
How to reproduce it (as minimally and precisely as possible):
I used the following values (among others):
  plugins:
    install:
      - "https://github.com/SonarSource/sonar-ldap/releases/download/2.2-RC3/sonar-ldap-plugin-<IP_ADDRESS>1.jar"

  affinity:
    nodeAffinity:
      preferredDuringSchedulingIgnoredDuringExecution:
      - weight: 50
        preference:
          matchExpressions:
          - key: "node-role"
            operator: In
            values:
            - services

@rjkernick @tsiddique, can you please confirm this is an issue? It seems to be an easy fix. Thanks!


ucan 0.10

Updates the ucan impl to match the upcoming 0.10 version of the spec. This pr also removes a lot of the IPLD stuff as that will be covered by the cacao crate. Because of this, it removes tracking of the codec and implements verification in tandem with deserialisation so that it can have the original serialisation to verify. It also depends on the as-yet unreleased ucan-capabilities-object crate.
probable TODOs:

[ ] tests, there are currently no independent 0.10 ucan test vectors that I'm aware of
[x] ucan-capabilities-object has to be released

Looks like some tests are failing

There's no test vectors anywhere for ucan 0.10, so I wasn't sure which to use. I will generate some.


Keypoint Regression example in documentation

I was following the KeypointRegression example from the documentation and ran into the following two errors:
julia> using FastAI.FilePathsBase, FastAI.StaticArrays, FastAI.DLPipelines
ERROR: UndefVarError: DLPipelines not defined
Stacktrace:
 [1] top-level scope
   @ ~/.julia/packages/CUDA/Uurn4/src/initialization.jl:52

and
julia> task = BlockTask(
           (Image{2}(), Keypoints{2}(1)),
           (
               ProjectiveTransforms(sz, buffered=true, augmentations=augs_projection(max_warp=0)),
               ImagePreprocessing(),
               KeypointPreprocessing(sz),
           )
       )
ERROR: UndefVarError: FlipX not defined
Stacktrace:
 [1] augs_projection(; flipx::Bool, flipy::Bool, max_zoom::Float64, max_rotate::Float64, max_warp::Int64)
   @ FastAI.Vision ~/.julia/packages/FastAI/GAIqz/src/Vision/encodings/projective.jl:200
 [2] top-level scope
   @ REPL[7]:1
 [3] top-level scope
   @ ~/.julia/packages/CUDA/Uurn4/src/initialization.jl:52

I think the first error can be solved simply by removing the FastAI.DLPipelines import.
Regarding the second error, FlipX alone can also not be found in the REPL but with the prefix DataAugmentation. it works.
julia> DataAugmentation.FlipX
FlipX (generic function with 1 method)

julia> FlipX
ERROR: UndefVarError: FlipX not defined
Stacktrace:
 [1] top-level scope
   @ :0
 [2] top-level scope
   @ ~/.julia/packages/CUDA/Uurn4/src/initialization.jl:52

I'd be happy to submit a PR fixing both issues. Is this prefix ^ also how you would solve it or do you prefer something different?
Julia version: 1.7.2
FastAI version: 0.4.0
Platform: macOS on M1

The second error related to FlipX and augs_projection() is resolved now, I'll open a PR to fix the remaining issues in the documentation for Keypoint Regression

Resolved with #221


Add scheduling posts capability

Description

Created a new posts collection.
Added filter to exclude posts with future dates (only in production, so the preview is available in dev_mode and netlify preview).
Added a warning message to scheduled posts.
Changed the cron function to build the site everyday at noon.

Related Issue(s)
Replica plus fix of https://github.com/FlowFuse/website/pull/1439
Checklist

[x] I have read the contribution guidelines
[x] I have considered the performance impact of these changes
[ ] Suitable unit/system level tests have been added and they pass
[ ] Documentation has been updated

Hi @ZJvandeWeg could you please take a look at this? It's the PR with the changes we discussed last Friday.


add ActiveRecord like exists? behavior.

Currently ActiveHash::Base has exists? method but its behavior is different with ActiveRecord's one.
It seems like to be used in save method only but it is a public method.
So I added ActiveRecord like behaviors and keep current behavior.

@kbrock How about this? If something lacks for your decision, please tell me.

I changed author email in each commits, so I did force push.

@kbrock Could you do review again?


ERROR: Package 'finrl' requires a different Python: 3.8.10 not in '<3.8,>=3.7'

Describe the bug
Attempted to install fin-ril in Google Colab Tutorial Notebooks as well as Linux WSL, but it gives the error >> ERROR: Package 'finrl' requires a different Python: 3.8.10 not in '<3.8,>=3.7'.
The same code was functional 2-3 days ago when I previously ran.
To Reproduce
Steps to reproduce the behavior:

Go to https://colab.research.google.com/github/AI4Finance-Foundation/FinRL/blob/master/tutorials/2-Advance/FinRL_PortfolioAllocation_Explainable_DRL.ipynb
run cell with pip install git+https://github.com/AI4Finance-LLC/FinRL-Library.git

Expected behavior
Successful installation

Same, need to use this in class tomorrow.

I ran the installation command on Google colab, and I was able to successfully install it. It comes with default python 3.8.15. Can you say where the installation is failing?Like for which package?

In colab you can do the following.
Install python3.7
!sudo apt-get install python3.7
!sudo update-alternatives --install /usr/bin/python3 python3 /usr/bin/python3.7 1

select python version 3.7 for runtime kernel
!sudo update-alternatives --config python3

 Selection    Path                Priority   Status
------------------------------------------------------------
* 0            /usr/bin/python3.8   2         auto mode
  1            /usr/bin/python3.6   1         manual mode
  2            /usr/bin/python3.7   1         manual mode
  3            /usr/bin/python3.8   2         manual mode

re-install pip
!curl https://bootstrap.pypa.io/get-pip.py -o get-pip.py
!python3 get-pip.py --force-reinstall

check environment
!python --version
!pip --version

Python 3.7.15
pip 22.3.1 from /usr/local/lib/python3.7/dist-packages/pip (python 3.7)

Hope it helps.

I fixed this bug.
You need to do two things.
1: change file
https://github.com/AI4Finance-Foundation/FinRL/blob/master/pyproject.toml
Change line 27 to be python = ">=3.7”
2: install package
In colab, run:
!apt install swig

@Phantom-eva's solution fixed it for me. Thanks!

@Phantom-eva's solution fixed it for me also. Thanks a lot !

I fixed this bug. You need to do two things. 1: change file https://github.com/AI4Finance-Foundation/FinRL/blob/master/pyproject.toml Change line 27 to be python = ">=3.7” 2: install package In colab, run: !apt install swig

thanks!!!


Added generation of mandatory commandClasses

database/mandatory.go:34: syntax error: non-declaration statement outside function body

Codecov Report

Merging #23 into master will decrease coverage by 2.96%.
The diff coverage is 2.43%.

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
- Coverage   62.54%   59.57%   -2.97%
==========================================
  Files          36       36
  Lines        1810     1823      +13
==========================================
- Hits         1132     1086      -46
- Misses        653      712      +59
  Partials       25       25

Impacted Files
Coverage Δ

gozwave.go
66.66% <ø> (ø)
:arrow_up:

nodes/request_states.go
0% <0%> (ø)
:arrow_up:

generators/commandclasses/commandclasses.go
0% <0%> (ø)

nodes/request_endpoints.go
0% <0%> (ø)
:arrow_up:

nodes/node.go
21.51% <27.27%> (+0.85%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 229c36e...38c03e5. Read the comment docs.


[manager/dispatcher] Synchronize Dispatcher.Stop() with incoming rpcs.

git cherry-pick 6b163ff64355d7a0a0fcc97af860b7893e90a2c5
Cherry pick was clean.

@anshulpundir needs -x flag for cherry-pick:
$ git cherry-pick -s -x 6b163ff

LGTM.

For reference, this is a backport of PR:

#2519 [manager/dispatcher] Synchronize Dispatcher.Stop() with incoming rpcs.


Error: Not Enough Funds

Hi guys,
I'm using the CreateTransaction API. Everything works as expected, but my minimum fee to send a transaction from newely generated address is 13,500 satoshies, which is near 72 sat / B.
JSON Here: click

You can lower the preference to pay lower fees.


Fix setRenderDone call in ExamplePanel.tsx

React state setters actually call a function argument rather than set the state to the function so we need to wrap the function with another function.

Maybe we should expand on that comment a bit to explain why we have to invoke it that way?

Maybe we should expand on that comment a bit to explain why we have to invoke it that way?

👍 I'll add something in a follow-up


make "restart" button under video player do something

Describe the addition

The "Restart" button does not yet work, we should make it work.
Context

After clicking, original BSB says "Are you sure you want to restart from the beginning?" using a yes or no popup. Clicking OK reloads the page with user progress completely reset.
Proposed Solution

We can simply have the button reload the page without any user data. We should figure out whether we want to save that user data or dump it-- maybe integrate this choice into the dialogue box?

Basic version of this has been added.

This is the modal the original game presents when you click Restart. We should present options to Save, Don't Save, or cancel.


feat(validateMessage): ignore merge commit validation

merge commit are auto generater by git and should thus be considered as a valid message
fix #26

Current coverage is 100.00%

Merging #27 into master will not affect coverage as of 2a4fe14

@@            master     #27   diff @@
======================================
  Files            1       1
  Stmts           67      71     +4
  Branches         0       0
  Methods          0       0
======================================
+ Hit             67      71     +4
  Partial          0       0
  Missed           0       0

Review entire Coverage Diff as of 2a4fe14

Powered by Codecov. Updated on successful CI builds.

Perfect. Thanks!


cmklimitation

Learn Build status updates of commit e70b847:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: CannotMergeCommit] Cannot merge commit e70b8479e90c8ecb9a02cf2e9ed5b61ca4d84f2d in branch newedits2 of repository https://github.com/vivgk/azure-docs into branch main (commit f50cabd2cb2d7432d5ba42960665625117b29c07). Please follow this documentation: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ to use git.exe to resolve you content conflicts locally and then push to remote.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Without seed the map is always the same

Description
If the players do not input any seed, the map will always be the same. When using a seed this is of course still a wanted feature.
Solution
Check if the seed is empty and use some system variable as a seed, such as the time, or use Qt's builtin random generator features.

I personally don't think that this is a bug. It's not said anywhere explicitly that the map should be different every time hence there's the seed for having a different map. However, this can be a feature and relatively easily implemented if really wanted.


feat: add bibitem format feature

Also changed main program to use this feature.

That looks very nice, thanks a lot!


Bug: Hass-agent crashes when gpu driver is upgraded

Please make sure that the issue you're planning to report is not already registered :)

Describe the bug
I noticed today when upgrading my nvidia drivers, the hass-agent disappeared from the task tray. I have a gpu load sensor, which I assume may have fired while the driver was upgrading.
To Reproduce
Steps to reproduce the behavior:

Add a gpu load sensor that runs regularly, eg every second, or in my case every 10 seconds.
Update the gpu driver and don't restart the PC. Note the hass-agent has disappeared from the running task tray icons.

Expected behavior
I assume it should have an internal retry mechanism for all sensors like this, to retry x times / indefinitely if some error occurs while trying to read the data from in this case the gpu, but could be the case for anything I guess.
Screenshots
na
Misc info (please complete the following information):

Windows build (ideally screenshot/info of winver.exe output): Windows 11 23H2 (OS Build 22631.4037)
Windows' UI language: Unsure
HASS.Agent version: 2.0.1

Please check what's applicable (multiple answers possible):

[x] Installed via installer
[ ] Installed manually
[x] Problem occurs in HASS.Agent
[ ] Problem occurs in Satellite Service

Additional context
Add any other context about the problem here.
Logs
If possible, please provide the logs of HASS.Agent and - if applicable - the Satellite Service. You can find HASS.Agent's logs by going to the main window, then Configuration -> Logging -> open logs folder. The Satellite Service's logs are in the same window, but the Satellite Service tab -> open service logs folder.

Hello,
Interesting, this might be related to either the virtual desktop management library or the LibreHardwareMonitor library.
Could you please provide logs from the time when the crash occurred? Were there any Windows Even Viewer logs that might be related to this?


Work on the admin system

Clean it up.
Set up different endpoints.
Find a way to update the semesters you can register for programmatically.

Done:

Clean up
v1 endpoint
Basic v2 endpoint set up

To Do:

Separate the place types from the config
Figure out If-Modified-Since maybe ? A crude implementation ?
Remove MongoDB when we push the admin system
Update places endpoint in v1 config, remove it from v2 config


Add OwnerId and IsPartner properties to NPC (partners/nosmates)

Thank you for the PR, do you think you could change the test as well to make the checks pass?
The failing test is located in NosSmooth.Packets.Tests/Converters/Packets/InPacketConverterTests

I will add a patch version (NosSmooth.Game 2.5.2) shortly


Extract find-bugs --mode=qe in find-bugs:qe

Codecov Report

Merging #294 (2c3e3f7) into master (7c70d79) will decrease coverage by 0.17%.
The diff coverage is 25.83%.

@@            Coverage Diff             @@
##           master     #294      +/-   ##
==========================================
- Coverage   30.65%   30.48%   -0.18%
==========================================
  Files          55       57       +2
  Lines        5349     5481     +132
  Branches     1179     1196      +17
==========================================
+ Hits         1640     1671      +31
- Misses       3608     3708     +100
- Partials      101      102       +1

Impacted Files
Coverage Δ

elliottlib/cli/__main__.py
0.00% <0.00%> (ø)

elliottlib/cli/attach_bugs_cli.py
0.00% <0.00%> (ø)

elliottlib/cli/create_placeholder_cli.py
0.00% <0.00%> (ø)

elliottlib/cli/create_textonly_cli.py
0.00% <0.00%> (ø)

elliottlib/cli/find_bugs_qe_cli.py
0.00% <0.00%> (ø)

elliottlib/cli/verify_attached_bugs_cli.py
0.00% <0.00%> (ø)

elliottlib/openshiftclient.py
0.00% <ø> (-14.64%)
:arrow_down:

elliottlib/runtime.py
15.47% <ø> (ø)

elliottlib/tarball_sources.py
32.22% <ø> (ø)

elliottlib/util.py
38.46% <ø> (-2.37%)
:arrow_down:

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98bbbb7...2c3e3f7. Read the comment docs.


UserAssignedIdentity(WorkloadIdentity) auth fails with 'scope https://api.botframework.com is not valid'

Hi! 👋
Firstly, thanks for your work on this project! 🙂
Today I used patch-package to patch<EMAIL_ADDRESS>for the project I'm working on.
I am using the botbuilder with the msteams connector. My configuration uses a UserAssignedMSI and the botframeworkauthentication is configured like this:
const botFrameworkAuthentication = new ConfigurationBotFrameworkAuthentication(
    {},
    new ConfigurationServiceClientCredentialFactory({
      MicrosoftAppId: config.botId,
      MicrosoftAppType: "UserAssignedMSI", // Bot test framework can only handle "MultiTenant",
      MicrosoftAppTenantId: config.botTenantId,
    })
);

I use it in conjunction with Azure Workload Identity and my bot is running inside a Pod deployed in AKS.
I get an error when a response should be returned to the bot service: (while fetching the token)
azure:identity:warning IdentityClient: authentication error. HTTP status: 400, AADSTS70011: The provided request must include a 'scope' input parameter. The provided value for the input parameter 'scope' is not valid. The scope https://api.botframework.com is not valid. Trace ID: f136be63-1f12-4d80-94be-804dabe01600 Correlation ID: bcc381f3-2e02-455d-a46c-fd3705f24eb4 Timestamp: 2023-12-11 13:59:55Z

The correct scope would be https://api.botframework.com/.default
I spend some debugging and found a diff comparing the UserAssignedMSI vs the SingleTenant code branch.
Single Tenant version:
https://github.com/microsoft/botbuilder-js/blob/f3db3e98bb139c7aecc921483ea188574de7aada/libraries/botbuilder-core/src/configurationServiceClientCredentialFactory.ts#L97-L130
If you drill further down it is clear that the audience is taken as input and then used as scope in the oauth flows.
This only works, if /.default is appended to the scope.
For the single tenant version this is done in the msalAppCredentialsclass: https://github.com/microsoft/botbuilder-js/blob/f3db3e98bb139c7aecc921483ea188574de7aada/libraries/botframework-connector/src/auth/msalAppCredentials.ts#L108-L112
In the UserAssignedMSI version the scope is taken without any further modification: https://github.com/microsoft/botbuilder-js/blob/f3db3e98bb139c7aecc921483ea188574de7aada/libraries/botframework-connector/src/auth/managedIdentityAppCredentials.ts#L37
In order to use the same logic like in the SingleTenant version here is the diff that solved my problem:
diff --git a/node_modules/botframework-connector/src/auth/managedIdentityAppCredentials.ts b/node_modules/botframework-connector/src/auth/managedIdentityAppCredentials.ts
index cc19c1b..fb4f414 100644
--- a/node_modules/botframework-connector/src/auth/managedIdentityAppCredentials.ts
+++ b/node_modules/botframework-connector/src/auth/managedIdentityAppCredentials.ts
@@ -34,7 +34,13 @@ export class ManagedIdentityAppCredentials extends AppCredentials {

         this.tokenProviderFactory = tokenProviderFactory;
         super.appId = appId;
-        this.authenticator = new ManagedIdentityAuthenticator(this.appId, this.oAuthScope, this.tokenProviderFactory);
+
+        const scopePostfix = '/.default';
+        let scope = this.oAuthScope;
+        if (!scope.endsWith(scopePostfix)) {
+            scope = `${scope}${scopePostfix}`;
+        }
+        this.authenticator = new ManagedIdentityAuthenticator(this.appId, scope, this.tokenProviderFactory);
     }

     /**

This issue body was partially generated by patch-package.
What do you think? If you agree I can prepare an pull request for the change

one further addition: it does not fix the issue completely. I think the old @azure/identity version embedded in the botframework-connector does not support workload identity

Hi @patst, we couldn't reproduce the error using a UserAssignedMSI bot deployed in an Azure App Service.
We are working on deploying the bot to an AKS cluster, and it would be helpful if you could provide the steps you followed to deploy your bot and configure the Azure Workload Identity.
Thanks!

Hi @patst, we couldn't reproduce the error using a UserAssignedMSI bot deployed in an Azure App Service. We are working on deploying the bot to an AKS cluster, and it would be helpful if you could provide the steps you followed to deploy your bot and configure the Azure Workload Identity. Thanks!

@ceciliaavila  thanks for your message.
I created a little example app to reproduce the error. See the repository at https://github.com/patst/botbuilder-js-4582
I added some kubernetes manifests in the manifests folder.
The configuration in the Azure Portal follows the docs provided on the AKS pages (https://learn.microsoft.com/en-us/azure/aks/workload-identity-overview?tabs=dotnet#microsoft-authentication-library-msal )
Hope that helps

I @patst, thanks for the information. We managed to deploy the application in the cluster and enable workload identity, but we are struggling to create the ingress and the service to access the bot. Do you have the steps or the manifests for this?
We are following these two guides, but we are not sure if we are missing something.
https://learn.microsoft.com/en-us/azure/aks/ingress-basic?tabs=azure-cli
https://learn.microsoft.com/en-us/azure/aks/ingress-tls?tabs=azure-cli#create-an-ingress-controller
Thanks!

I @patst, thanks for the information. We managed to deploy the application in the cluster and enable workload identity, but we are struggling to create the ingress and the service to access the bot. Do you have the steps or the manifests for this? We are following these two guides, but we are not sure if we are missing something. https://learn.microsoft.com/en-us/azure/aks/ingress-basic?tabs=azure-cli https://learn.microsoft.com/en-us/azure/aks/ingress-tls?tabs=azure-cli#create-an-ingress-controller Thanks!

hey @ceciliaavila  , thanks for working on it. I added a ingress and service definition to the example repository.
I addition to that, you will need a valid TLS certificate for the ingress. You could use certmanager for that.
What problems are you facing exactly?
Maybe the AKS team can give you a hand on getting the cluster up and running.

I @patst, thanks for the information. We managed to deploy the application in the cluster and enable workload identity, but we are struggling to create the ingress and the service to access the bot. Do you have the steps or the manifests for this? We are following these two guides, but we are not sure if we are missing something. https://learn.microsoft.com/en-us/azure/aks/ingress-basic?tabs=azure-cli https://learn.microsoft.com/en-us/azure/aks/ingress-tls?tabs=azure-cli#create-an-ingress-controller Thanks!

hey @ceciliaavila , thanks for working on it. I added a ingress and service definition to the example repository.
I addition to that, you will need a valid TLS certificate for the ingress. You could use certmanager for that. What problems are you facing exactly? Maybe the AKS team can give you a hand on getting the cluster up and running.

Hi @patst, thanks for all your help, we were finally able to reproduce the error. We'll be reviewing the fix you proposed.
Thanks!


How the training data is divided？

Hello, I'm very interested in your work, and I'm currently attempting to train a general sentence representation model. I have a question: When my training dataset comes from different domains, how can I ensure that samples within the same batch belong to the same task during the training process? Would it be better to include samples from different tasks within the same batch during training? I'm not sure about my assumption. Could you provide insights based on your experience?

Hi, Thanks a lot for your interest in the INSTRUCTOR!
You can arrange the examples in a sequence such that, after they are divided into batches, examples in the same batch come from the same task. As we use in-batch negative sampling, it would be better if we provide meaningful negative instances from the same task.

Hello author, I am very interested in your work instructor. I would like to ask about the task_id in your training dataset. I would like to know which datasets these ids correspond to, as my own correspondence may take more time. By the way, I found that there are only 329 task_id, 302 is missing, which does not match the 330 in the paper. Looking forward to your reply and wishing your work success.
---- Replied Message ----
From  @.> Date  09/27/2023 21:46 To  @.> Cc<EMAIL_ADDRESS>Subject  Re: [xlang-ai/instructor-embedding] How the training data is divided？ (Issue #87)
Hi, Thanks a lot for your interest in the INSTRUCTOR!
You can arrange the examples in a sequence such that, after they are divided into batches, examples in the same batch come from the same task. As we use in-batch negative sampling, it would be better if we provide meaningful negative instances from the same task.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

We found that we may missed a task_id when we uploaded the dataset. We anticipate to fix it in our next version.

Is there any update on where to find the meaning of these task_ids?


[TC-S-2.3] Script has to be updated as per Test plan

Description:

[ ] Step 2b, 3b PICS has to be updated as per Test plan.
[ ] Step 2a, 2b - In Reference command GroupId, SceneId and Transition time values has to be updated as per Test label.

Steps to reproduce:
Steps 2a, 2b, 3b
Yaml References:

https://github.com/project-chip/connectedhomeip/blob/master/src/app/tests/suites/certification/Test_TC_S_2_3.yaml

Test plan References:

https://github.com/CHIP-Specifications/chip-test-plans/blob/master/src/cluster/scenes.adoc#tc-s-2-3-secondary-functionality-with-dut_server

@Ashwinigrl fixed in PR 31060 please verify it and close the ticket.

Issue Fixed


Relative imports seem to break the program

I have a folder with 2 files types.py and common.py.
types.py Imports from common.py
from .common import x, y, z

I get the following error:
Failed to load module dependant module: No module named 'types.common'; 'types' is not a package
For the time being I have put a workaround to maintain the package behaviour and satisfy pydoctest, however this seems like a bug IMO, please let me know if I am mistaken.
try:
    from .common import x,y,z
except:
    from common import x,y,z

Thanks for submitting this! I haven't used relative imports much myself, so it may very well be a bug in pydoctest.
I don't know if types.py is perhaps clashing with the builtin types module, since if I rename it to e.g. types_test.py, I instead get ImportError('attempted relative import with no known parent package'), similar to running python3 types_test.py`. I'll see if I can find the problem.

I never got around to look further into this. Can someone create a minimal reproduce of the issue?


UP-4432:  Switch the default PAGS implementation from XML file config to...

... the database (JPA entity) flavor;  @depricate the legacy version
https://issues.jasig.org/browse/UP-4432

I suggest also increasing maxActive in uPortal's databaseContext.xml file from 75 to 100.  I don't think we really need a 25 increase just due to this feature, but from load tests I've seen the 75 value is a little small so I think going to 100 as a default is not unreasonable at all.

+1

@jameswennmacher -- done.

Coverage decreased (-0.01%) to 22.81% when pulling 1961c94f7802be3caa0a1527a408be3699e18fc0 on drewwills:UP-4432 into 50d1c847b22dd1b048fb59a6e0aff15e7da1f796 on Jasig:master.

12 days on the queue -- time to merge.


Wrong description on EventDispatcher.funbind()

Hi I think the description is wrong.
https://github.com/kivy/kivy/blob/master/kivy/_event.pyx#L576-L577
Actually, EventDispatcher.unbind() will only unbind the first.

You are right, but here is what's going on IIRC. Originally, unbind searched for all matches if it bound a property, while bind only added a bound callback if one that was equal to it didn't already exist, depending if it was an event or property. When I added fbind and co. I simply replicated that functionality in EventObservers for simple bind.
However, I also fixed some inconsistencies at the time, then after doing that I realized that if no duplicates are added, then unbinding all is done after finding the first :D. So the comment is technically true, but also meaningless and is just there because history.
So feel free to make a PR to remove it. Also, just a note in case you're planning you use it, the ref keyword will probably go away at some point if the KV proposal is merged, and instead an explicit fbind_proxy will be added instead.

Aha! Thanks for the detailed explanation :smile: . I should have read docs of other classes(Observable, BoundCallback, EventObservers). I've only read EventDispatcher's doc.

So feel free to make a PR to remove it

Probabely I'm not going to make a PR for that because I don't fully understand the code.


Update commons-io to 2.8.0

Updates commons-io:commons-io from 2.7 to 2.8.0.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "commons-io", artifactId = "commons-io" } ]

labels: library-update

Codecov Report

Merging #37 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop      #37   +/-   ##
========================================
  Coverage    56.25%   56.25%
========================================
  Files            7        7
  Lines          112      112
  Branches         1        1
========================================
  Hits            63       63
  Misses          49       49

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2707119...c536ad6. Read the comment docs.


Thorium exceeds file descriptors and starts to hang

System Details

OS: CachyOS
Thorium Version 128.0.6613.189 binary release version with SSE3.

Problem
I got a warning by Netdata, that thorium used up all available file descriptors. Previously it never exceeded around 30%.
At the same time I noticed hanging while opening Gmail and I restarted the browser after waiting a couple of seconds, and closing the tab and reopening it, with the same result: Page loads and then hangs when selecting a mail.

ulimit -n

Reports 1024 on my system.

Looks like this is a symptom of https://github.com/Alex313031/thorium/issues/835 and the issue expanded to often having Gmail getting stuck as well as Google Drive.
The tab will become unresponsive and sometimes refuse to close. Closing and creating a new tab usually won't fix the issue. Restarting the browser often also doesn't fix the issue. Sometimes it goes away from it's own, sometimes it doesn't.
The same is happening on Reddit as well as in PDF documents opened in the browser.


ledger-agent OSError: open failed

As I tried the great article from Fred de Villamil (https://thoughts.t37.net/a-step-by-step-guide-to-securing-your-ssh-keys-with-the-ledger-nano-s-92e58c64a005), I do not manage to generate the SSH keys (or at least for have a communication with the ledger :
$ ledger-agent  login@host
2018-04-09 21:30:06,816 WARNING      DISPLAY not defined                                                                                [ui.py:65]
Traceback (most recent call last):
File "/usr/local/bin/ledger-agent", line 11, in
sys.exit(ssh_agent())
File "/usr/local/bin/ledger_agent.py", line 5, in
ssh_agent = lambda: libagent.ssh.main(DeviceType)
File "/usr/local/lib/python3.6/site-packages/libagent/ssh/init.py", line 164, in wrapper
return func(*args, **kwargs)
File "/usr/local/lib/python3.6/site-packages/libagent/ssh/init.py", line 287, in main
for pk in conn.public_keys():
File "/usr/local/lib/python3.6/site-packages/libagent/ssh/init.py", line 199, in public_keys
self.public_keys_cache = conn.export_public_keys(self.identities)
File "/usr/local/lib/python3.6/site-packages/libagent/ssh/client.py", line 24, in export_public_keys
with self.device:
File "/usr/local/lib/python3.6/site-packages/libagent/device/interface.py", line 118, in enter
self.conn = self.connect()
File "/usr/local/lib/python3.6/site-packages/libagent/device/ledger.py", line 47, in connect
return comm.getDongle()
File "/usr/local/lib/python3.6/site-packages/ledgerblue/comm.py", line 202, in getDongle
dev.open_path(hidDevicePath)
File "hid.pyx", line 72, in hid.device.open_path
OSError: open failed
login@host's password:
Even with the good password, the connection get closed, and I have no confirmation on the Ledger.
I use the firmware Secure Element 1.4.1 and MCU 1.5 on a High Sierra 10.13.4

I think that solves the problem:
wget -q -O - https://raw.githubusercontent.com/LedgerHQ/udev-rules/master/add_udev_rules.sh | sudo bash

Maybe this issue should be close

Just updated ledger firmware recently and this same error start to happen again, add udev rules won't fix.

Not sure why, but changing the USB port fix the problem. Both USB ports seem to be working fine (Metamask can use them), but ledgerctl will only works correctly with one port


fix(celery cache warmup): add auth and use warm_up_cache endpoint

SUMMARY

Fixes cache warmup via celery job.

adds cache and data cache configs to the docker-compose superset_config to enable caching for development env.
add authentication to the cache warmup celery beat job, using the THUMBNAIL_SELENIUM_USER config for auth.
use the /superset/warm_up_cache endpoint for warming up the cache.
run the warmup call as a single celery job instead of running all the warmups in single job. This approach should enable some parallelization of the warm up calls. A slow warmup call should also not slow down the entire process.

There is currently an open PR that addresses this issue, however it is using a web driver process to compute the warmup by visiting the dashboard which seems a bit process heavy. Since there is already a cache warmup endpoint that is able to handle charts and filters combos, it make more sense to use that endpoint.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

use the docker-compose workflow
Add a celery cache warmup beat config using top_n_strategy, set it to run at a high interval (for eg, every minute). documented here
visit dashboards to that top n strategy has data to work with
observe the cache warmup logs in the worker
visit dashboards and notice the charts are cached

ADDITIONAL INFORMATION

[ ] Has associated issue: Fixes #18933, Fixes #9597
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

rerunning CI

UPDATE: I've recently discovered that the /superset/warm_up_cache endpoint does not work with the new charts based on the /api/v1/chart/data api and with dashboards that are using dashboard native filters. Generating a query context in the backend only will be quite difficult, so the approach in https://github.com/apache/superset/pull/20387 might be better


[core] SetMouseCursor crashes on wayland

Issue description
I made a simple example code where I check for hover, change the cursor to MOUSE_CURSOR_POINTING_HAND, and then return to the default. When I hover over the rectangle multiple times the app crashes and I get this error message: X connection to :1 broken (explicit kill or server shutdown).
Environment
Arch Linux 6.5, Wayland, OpenGL 4.6
Code Example
Rectangle rect = CLITERAL(Rectangle){50, 50, 100, 100};
DrawRectangleRec(rect, RED);

if (CheckCollisionPointRec(GetMousePosition(), rect))
{
    SetMouseCursor(MOUSE_CURSOR_POINTING_HAND);
}
else
{
    SetMouseCursor(MOUSE_CURSOR_DEFAULT);
}

@Zielin0 Unfortunately that could be a GLFW issue. Wayland will slowly become a problem for us while we depend on GLFW. In the meantime, my suggestion would be compiling for X11. XWayland will still be able to run it well enough.

Definitely, out of scope of raylib.


invalid product campaign requests from product detail pages

"ProductCampaign.ff" requests from product detail pages have not "productNumber" parameter. I didn't get the system how that should work, I just see the requests in the access logs of the FF server.
The product campaigns from the shopping cart page work fine. Please check that.

Ok, the bug is a bit stranger than expected: even if campaigns are disabled for product detail pages, they are triggered from there.

@rudibatt Can you please describe steps to reproduce this issue?
I tried product page and get no requests if campaigns are disabled, either generally or for product pages. Also when the campaigns are enabled, there's always productNumber: either ID or SKU

These requests appeared in a system with many other modules installed, a custom template but with a standard FF module, whenever a product detail page was loaded. But I wasn't able to find the cause of these requests. It's very likely this is an issue related to the customer's system.
However I have no access to that system anymore, so I guess this is a "can't reproduce" issue...

Ok then, can't reproduce

Please investigate this because I have observed it recently in two customer setups. There might be a bug in the campaign sub-module which does not depend on custom templates.

@tuegeb Any other details about how I could reproduce this or at least how it appeared at your side and what exact messages you got, please?

Sorry for the late reply. After some more tests (using the branch https://github.com/tuegeb/Magento-FACTFinder) I could not reproduce this bug locally. Maybe the customer has used additionally older versions of this module at the same time in different systems.
In order to avoid this and simplify the update to the head revision, could you please provide the latest version of this module (would be version 4.0.6+) via Magento Connect? Thank you in advance.

@tuegeb The newest release 4.0.6 was added and uploaded to Magento Connect.
In any case is the module not approved yet, so it's not accessible for normal user from the magento website.

So far we weren't able to reproduce the problem

Now I could reproduce it:
Currently it happens only on the shopping cart page after you have removed the last item. The resulting request url has no mandatory parameter "productNumber":
ProductCampaign.ff?do=getShoppingCartCampaigns&channel=de&idsOnly=true&format=json...

@xpoback: I can also confirm that the issue is still immanent with 4.0.9.

productNumber parameter should be provided even if empty (Omicron)

Solved: 6176aa2.
@tkn98: Could check the version in the master branch, please?

I took 4.1.5, testing in a staging system


Validation check to ensure query vector dimension is not greater than the data vectors

Elasticsearch process crashes when query vector dimension is greater than data vector dimension. Crash possibly happening from nmslib library.

Same here, we get the following from the jvm:
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  SIGSEGV (0xb) at pc=0x00007fc5f18b11c8, pid=1, tid=239
#
# JRE version: OpenJDK Runtime Environment AdoptOpenJDK (14.0.1+7) (build 14.0.1+7)
# Java VM: OpenJDK 64-Bit Server VM AdoptOpenJDK (14.0.1+7, mixed mode, sharing, tiered, compressed oops, g1 gc, linux-amd64)
# Problematic frame:
# V  [libjvm.so+0xe4d1c8][thread 301 also had an error]
  SymbolTable::do_lookup(char const*, int, unsigned long)+0xb8
#
# Core dump will be written. Default location: Core dumps may be processed with "/usr/lib/systemd/systemd-coredump %P %u %g %s %t %c %h" (or dumping to /usr/share/elasticsearch/core.1)
#
# An error report file with more information is saved as:
# �
[thread 265 also had an error]
*** Error in `/opt/jdk/bin/java': munmap_chunk(): invalid pointer: 0x00007fc5ec0015c0 ***
*** Error in `/opt/jdk/bin/java': free(): invalid pointer: 0x00000000ffffffff ***
*** Error in `/opt/jdk/bin/java': free(): invalid pointer: 0x00000000ffffffff ***
[thread 275 also had an error]
[thread 261 also had an error]
[thread 262 also had an error]
[thread 233 also had an error]
[thread 270 also had an error]
[thread 271 also had an error]
[thread 238 also had an error]
[thread 269 also had an error]
[thread 268 also had an error]
[thread 294 also had an error]
[thread 252 also had an error]


Accessibility improvements

fixes tabindex issue (#51)
introduces aria-expanded &aria-hidden (#57)

Hey @LukaszWatroba, I leave the semver updates on dist files to you.. Let me know if you have any remarks.

Thanks @tameraydin! Everything looks great.

Awesome, thank you too!


How to use extension tokens for parsing?

I'd like to parse something like
Some math $a+b=c$

```math
x^2 = -1
```

into Markdown with explicit math blocks. I see that mistletoe has the Math extension token (https://mistletoe-ebp.readthedocs.io/en/latest/api/extension_tokens.html), but I can't for life of me figure out how to use it. The documentation (e.g., here) seems outdated since the imports in the examples don't even work anymore.
MWE:
import mistletoe
from mistletoe.markdown_renderer import MarkdownRenderer

doc = mistletoe.Document("a ~~st~~ $b+c$")

print()
print(doc)
print()
print(doc.children)
print()
print(doc.children[0].children)

print()
with MarkdownRenderer() as mdr:
    print(repr(mdr.render(doc)))

<mistletoe.block_token.Document with 1 child at 0x7f51dd939a90>

[<mistletoe.block_token.Paragraph with 3 children at 0x7f51dda2a090>]

[
    <mistletoe.span_token.RawText content='a ' at 0x7f51dd72dd10>,
    <mistletoe.span_token.Strikethrough with 1 child at 0x7f51dd72ddd0>,
    <mistletoe.span_token.RawText content=' $b+c$' at 0x7f51dd72de50>
]

'a ~~st~~ $b+c$\n'

Any hints?

Hi @nschloe, I'm not sure if I get your question. In mistletoe (not mistletoe-ebp which is/was a fork which I don't know deeply), you can use e.g. MathJaxRenderer if you are interested in rendering HTML together with the MathJax JS library.
Related mistletoe documentation:

https://github.com/miyuchina/mistletoe/#usage
https://github.com/miyuchina/mistletoe/blob/master/dev-guide.md#creating-a-custom-renderer - more in-depth view on custom tokens and renderers

not mistletoe-ebp which is/was a fork which I don't know deeply)

Ah, hadn't realized they were different. (When googling I always get to their documentation.)

if you are interested in rendering HTML

My interest in in parsing. I'd like to parse, change some things, and render back to Markdown. For this to work, I need Strikethrough (~~...~~), math, tables, etc. parsed correctly.

OK, so what about the following code? Essentially, you need to pass additional token class(es) to the parsing process as well as to define corresponding render_... method(s) - you do this by defining your own renderer class:
from typing import Iterable

import mistletoe
from mistletoe import block_token
from mistletoe.latex_token import Math
from mistletoe.markdown_renderer import Fragment, MarkdownRenderer

class MyMarkdownRenderer(MarkdownRenderer):
    def __init__(self, **kwargs):
        """
        Args:
            **kwargs: additional parameters to be passed to the ancestors'
                      constructors.
        """
        super().__init__(Math, **kwargs)

    def render_math(self, token) -> Iterable[Fragment]:
        yield Fragment(token.content + " (Math rules :))")

    # @override
    def render_fenced_code_block(
        self, token: block_token.BlockCode, max_line_length: int
    ) -> Iterable[str]:
        indentation = " " * token.indentation
        yield indentation + token.delimiter + token.info_string + (
            " (Math rules :))" if token.info_string == "math" else ""
        )
        yield from self.prefix_lines(token.content[:-1].split("\n"), indentation)
        yield indentation + token.delimiter

print(
    MyMarkdownRenderer().render(
        mistletoe.Document(
            """
a paragraph with math: $ 2^3 $

$$ c^2 = a^2 + b^2 $$

```math
x^2 = -1
```
"""
        )
    )
)

This outputs:
a paragraph with math: $ 2^3 $ (Math rules :))

$$ c^2 = a^2 + b^2 $$ (Math rules :))

```math (Math rules :))
x^2 = -1
```

Closing this as answered, feel free to "reopen" by commenting.


enhance: Add repair legacy-collection-remnant command

See also milvus-io/milvus#33608
Command removes collection with no field to fix the bug in previously mentioned issue

/lgtm


Why SPDY is not work for iOS with AFNetworking?

I see that SPDY protocol support is now available in NSURLSession on OS X Yosemite and iOS 8 , and is Supported transparently by NSURLSession.
see details： https://developer.apple.com/videos/wwdc/2014/ [What's New in Foundation Networking]
It is ok with NSURLSession like this,
NSURLRequest *request = [NSURLRequest requestWithURL:url];
NSURLSessionDataTask *task =[[NSURLSession sharedSession] dataTaskWithRequest:request completionHandler:^(NSData *data, NSURLResponse *response, NSError *error) {
}];
[task resume];
But why it not work When i use AFNetworking's AFURLSessionManage?

Is there a good SPDY server that I could test with? Something like httpbin.org?


Fix errors on first load / Change SW strategy

This seems to happen only after a fresh build and on the first load. A forced refresh fixes this situation temporary.

This should - hopefully - be solved now with https://github.com/TryGhost/gatsby-starter-ghost/commit/9ab4a785cc148f6c99a5798511c425cb8d071f64 and https://github.com/TryGhost/docs/commit/279bd325632ade90a242dbfac326882d46d2dcdf which include dependency updates for the gatsby-plugin-offline.
According to the related issue in Gatsby

old bugs can still appear once the site has updated, due to browsers having the previous SW installed, but future updates should be okay assuming the bug was fixed because by that point, browsers have installed the latest SW.

This is also what I experienced and am therefor optimistic about this fix.
Safari:

I had visited https://docs.ghost.org before this dependency update.
After the update the usually experienced "blank page" did not occur and it seemed to load fine.
The console stated that the sw got installed, which I assume is the fixed one.

It would be good to get some feedback regarding this issue with Safari, which I wasn't able to test:

We keep having issues with Safari with the docs site due to the service worker setup serving stale content. It's not being cleared at all when new content is pushed and it's very difficult to clear stale content manually (no luck with cache clear, deletion of indexed db records, or running with dev tools open and cache disabled).

Chrome:

I had visited https://docs.ghost.org before this dependency update
After the update the usually experienced "blank page" did occur, but only for a second.
The console stated that the sw got installed, which I assume is the fixed one.

I will close this issue for now, but we need to keep an 👀 on it. I will reopen it when it turns out to still be causing problems.


Consider dropping Authentication from all of the classes

Since all of the Auth stuff lives under the Microsoft.AspNet.Authentication namespace already.  Why do we use Authentication in the class name everywhere?  It seems extra verbose and redundant.  Can we strip them across the board on the class names and only leave them on the Use/Add methods?

Hurrah a grand renaming which breaks the world.
Actually not a bad idea.

Like this?
TwitterOptions
TwitterMiddleware
TwitterHandler
TwitterDefaults
ITwitterEvents
TwitterEvents
UseTwitterAuthentication
How about the base classes? I think we'd have to leave those or else we'd end up with:
Handler
Middleware
Options
etc..

Yeah so basically I think the general rule should be to only add Authentication when its needed to be clear, as opposed to just always tacking it on everywhere.
For the base classes I agree that those make sense to have the prefix as the names would be meaningless without it :)

I'm willing to be the sacrificial lamb for this work if your plate is full, since this has always been a pet peeve of mine :)

We'll take it up with Triage.

Note to self, need to rename ConfigureJwtBearer => AddJwtBearer to match the new naming pattern

e8090a3176de5e6fc84be829be3a98f1e5ee8a5d


2.13 rccp

This pull request modifies the top level CMakeLists.txt so that
On Mac: CMAKE_INSTALL_NAME_DIR is set to the directory into which libraries are installed (consisten with homebrew conventions)
On Linux: add $ORIGIN to the rpath.
Set CMAKE_INSTALL_RPATH_USE_LINK_PATH to true.
On Windows, install zlib1.dll
Ability to disable osxfixup, which is needed only for packaging.
It modifies src/sim/V2/swig/python/simV2_wrap.cxx to be compatible with C++11 by including cmath.
It then has various fixes in the Vs directory to allow different kinds of meshes to coexist.  The commit message explains all that.

@jrobcary, there are no plans for another release off of the 2.13 branch.
Should we work to get these changes on "develop"?
We most certainly want the VsPlugin and LibSim changes on develop.
I think we could get the rpath and origin changes in if they were further guarded with a new cmake option for VisIt's build system.
I understand you install a different way than we do for our releases, but I worry if not guarded those changes could throw off something with our standard install.

Okay, so I should fork off develop and put a pull request from/into there?

@jrobcary ... sorry I didn't catch 2.13 issue.

@jrobcary Since we decided this should go into develop, I went ahead and closed this PR.


Secret with connection secrets is not created for serverless instance

What did you do to encounter the bug?
Steps to reproduce the behavior:
Apply the following helm template
apiVersion: v1
kind: Secret
metadata:
  name: testing
  labels:
    atlas.mongodb.com/type: "credentials"
type: Opaque
stringData:
  password: "OENkWWcxR3JleVZucGNsU1Z5M3lxSkpjTllBejhVeWM="
---
apiVersion: atlas.mongodb.com/v1
kind: AtlasDatabaseUser
metadata:
  name: atlas-deployment-user-testing
  labels:
    helm.sh/chart: testing-0.0.1_replaced.by.yq.in.pipeline
    app.kubernetes.io/name: testing
    app.kubernetes.io/instance: release-name
    app.kubernetes.io/version: "1.0.0"
    app.kubernetes.io/managed-by: Helm
spec:
  username: tester
  passwordSecretRef:
    name: tester-secret
  projectRef:
    name: mongodb-atlas-project
    namespace: mongodb-atlas
  roles:
    - databaseName: testdb
      roleName: readWrite
---
apiVersion: atlas.mongodb.com/v1
kind: AtlasDeployment
metadata:
  name: atlas-deployment
  labels:
    helm.sh/chart: testing-0.0.1_replaced.by.yq.in.pipeline
    app.kubernetes.io/name: testing
    app.kubernetes.io/instance: release-name
    app.kubernetes.io/version: "1.0.0"
    app.kubernetes.io/managed-by: Helm
spec:
  projectRef:
    name: mongodb-atlas-project
    namespace: mongodb-atlas
  backupRef:
    name: ''
    namespace: ''
  serverlessSpec:
    name: testdeployment
    providerSettings:
      providerName: AZURE
      regionName: EUROPE_WEST

What did you expect?

[OK] AtlasDeployment created in k8s

[OK] Deployment created in Atlas Cloud

[OK] AtlasDatabaseUser created in k8s

[OK] User created in Atlas Cloud

[NOK] Secret containing the connection secrets o be created in k8s

What happened instead?
Everything else worked as expected, just the secret containing the connection secrets was not created.
NOTE
After trying the same template and changing the serverlessSpec to a deploymentSpec we see the secret getting created.
Screenshots
If applicable, add screenshots to help explain your problem.
Operator Information

Operator Version: 1.5.0

Kubernetes Cluster Information

Distribution
Version: 1.24.3
Image Registry location (quay, or an internal registry)

Additional context
Add any other context about the problem here.
If possible, please include:

kubectl describe output
yaml definitions for your objects
log files for the operator and database pods

Hi @ThumNet, thanks a lot for raising an issue. In order for the secret to be created, you need an instance, a user, and a connected private endpoint. In the case of a serverless instance, you need to set up the private endpoint in the serverless spec. More details can be found in the documentation: https://www.mongodb.com/docs/atlas/reference/atlas-operator/ak8so-private-link-serverless/

Thanks @Sugar-pack: I'm a colleague of @ThumNet and we ran into this issue together.
Just to verify: we got this working with a deploymentSpec, and this works without configuring a private-link. Is this a requirement? The docs say that this is optional if I understand this correctly.
I would like to start without a private-link, as I'm already very happy with all the options.

@sunib, you are right. The secret should be created even without configured private endpoints. In this case, it will contain empty strings in the connectionStringPrivate and connectionStringPrivateSrv fields. Could you please check if connection strings data appeared in the deployment status? The status should looks like this:
status:
  conditions:
    - lastTransitionTime: '2022-12-09T05:30:02Z'
      status: 'True'
      type: Ready
    - lastTransitionTime: '2022-12-08T07:28:42Z'
      status: 'True'
      type: ValidationSucceeded
    - lastTransitionTime: '2022-12-09T05:29:54Z'
      status: 'True'
      type: DeploymentReady
  connectionStrings:
    standardSrv: mongodb+srv://some_conn_string
  mongoDBVersion: 6.2.0-rc2
  observedGeneration: 4
  stateName: IDLE

I think it was in status: but I will retry today to confirm this (all resources are now deleted).
The operator is installed by helm (https://mongodb.github.io/helm-charts/mongodb-atlas-operator:1.5.0). We use Argo to deploy it and no values are overriden.
To be complete, the application manifest from Argo that does this:
apiVersion: argoproj.io/v1alpha1
kind: Application
metadata:
  name: mongodb-atlas-operator
  namespace: argocd
spec:
  destination:
    namespace: mongodb-atlas
    server: https://kubernetes.default.svc
  project: infra
  source:
    repoURL: https://mongodb.github.io/helm-charts
    targetRevision: '1.5.0'
    chart: mongodb-atlas-operator
  syncPolicy:
    automated:
      prune: true
      selfHeal: true
    syncOptions:
      - CreateNamespace=true

That's solved quickly! Thank you very much.

@Sugar-pack: is there already a release planned so that I can try this? Or is there some pre-release process that I'm missing?

Planned to release in January. But I will talk about making a patch release sooner with a team.

That would be very nice, thanks! It would help us to have a patch release earlier then I can switch to serverless, including it's automatic backups.

Good news:  release with fixes is scheduled for release tomorrow.

@sunib FYI, 1.5.1 released today: https://github.com/mongodb/mongodb-atlas-kubernetes/releases/tag/v1.5.1


Can you address the work you have referenced?

For instance:

SAM pretrained model didn't listed or quated in readme;
the whole architecture looks very same to Vary, please add quate to it and possible made modifications and compare to original work?

thanks.

Hi, thanks for your interest.

Our DeepSeek-VL use pure SAM pretrained by Meta AI, as we mentioned and cited in our paper.
We have cited Vary, and also closely discussed with Haoran Wei, the first Author of Vary.

It would be better write these citations in README.
The modifications insights would be benificial to community as I noticed there are some differences between Vary and deepseek-VL.
Since the whole code base not really opensourced, and DeepSeek acutally always being the frontier in Chinese opensource, you can give more dicussions publicly for others to learn. These information might be curcial for users who use deepseek, not just open a model.

Agree with @lucasjinreal , looking forward to seeing the comparison results with Vary.

Thanks for your interest. It is important to note that our choice of DeepSeek-VL for the vision encoder was not based on Vary, and the motivations behind Vary and DeepSeek-VL on the vision encoder are quite different.

Vary aims to equip the model with OCR capabilities by specifically training on documents using SAM, then merging with the original CLIP to enhance the model's OCR abilities.
On the other hand, DeepSeek-VL aims to enable the model to process high-resolution images of 1024 * 1024 dimensions as input, thereby avoiding the loss of low-level vision information in general real-world tasks. During training, we treat them as a unified Hybrid Encoder and conduct collaborative training on all our data. We have also tried other vision encoders, discussion regarding the model's encoder is also addressed in the main text.

In summary, the motivations and specific initialization parameters differ between Vary and DeepSeek-VL on the vision encoder, as do their training strategies. They share similarities in utilizing a Hybrid Encoder and SAM as the second encoder, as we cited in our report. However, the Hybrid Encoder concept itself is common (not Vary's core contribution), and the SAM structure is not unique to Vary's work. Therefore, we did not extensively elaborate on the differences between the two in the paper and the GitHub repository.

From the code I can notice that the SAM used way are actually a little bit different then Vary, from the aspect of Hybrid it could treat as same.
But here is the question: I tested Deepseek VL, the OCR ability are weak, why not choose using Vary's training strategies instead using combined directly? It's it better? (from result clearly it's not)


failure to send communications

Hello, when a mass communication is sent, two people do not receive that communication. The other people in the organization receive it but not two specific people, what could it be?

Hi @gsv022,
That step has already been done, we already created the group and sent a statement, but those two people do not receive it in the bot of the company app, we tried that process but nothing, what could it be?

Since the team with 2 members already created. Please share the export results

Hello, Uninstall company in teams and then add it again. Then I sent a statement to that test group as a chat to all the members (to the 2 people) and for now the BOT worked for us, it already sends the statement to those two people through a chat.

Glad that message is getting delivered to the test team. Please let us if you have any queries..

No thank you very much!!


⚠ Samsung has degraded performance

In de05583, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2637 ms

Resolved: Samsung performance has improved in 85261b6.


iOS [AppDelegate window]: unrecognized selector sent to instance

Error

[AppDelegate window]: unrecognized selector sent to instance

occurs after calling
BranchIOS.Init(_branchKey, options, this);
I tried to figure out the cause...but I could only track it down to an exception occurring at
Branch.g.cs
InitSessionWithLaunchOptions
On the following line
global::ApiDefinition.Messaging.void_objc_msgSend_IntPtr_IntPtr (this.Handle, Selector.GetHandle ("initSessionWithLaunchOptions:andRegisterDeepLinkHandler:"), options.Handle, (IntPtr) block_ptr_callback);
Using Xamarin.Forms project.
Oddly enough it works on the TestBed and on a sample project that I created with the same X.Forms version.  In my production app, it fails :(
Any advice would be greatly appreciated.
Thanks,
Ant

@AntRemo check please your parameters,
You can use one of two methods:
Init(String branchKey, NSDictionary launchOptions, IBranchSessionInterface callback)
Init(String branchKey, NSDictionary launchOptions, IBranchBUOSessionInterface callback)
You call:
BranchIOS.Init(_branchKey, options, this)
so, what is "this"?
is "this" a reference to IBranchSessionInterface/IBranchBUOSessionInterface?

Hi @antonargunov
Thanks for the super fast reply :+1:
I am using IBranchSessionInterface.
I tried IBranchBUOSessionInterface as well, but believe that gave me a different error. I can try again if needed.

@AntRemo I think you did not inherit IBranchSessionInterface.
In my case I declare:
public class AppDelegate : global::Xamarin.Forms.Platform.iOS.FormsApplicationDelegate, IBranchSessionInterface
Then I implement interface methods:
public void InitSessionComplete(Dictionary<string, object> data) {
}
public void SessionRequestError(BranchError error) {
}
Then I call:
....
BranchIOS.Init(_branchKey, options, this)
....
All works.

Hi @antonargunov
I first inheritted from AppDelegate,
public partial class AppDelegate : global::Xamarin.Forms.Platform.iOS.FormsApplicationDelegate
then later tried applying the interface to Application
public partial class App : Application, IBranchSessionInterface
I was able to get this working super fast on Android.  But iOS is not going as smoothly.
I'm comparing the build settings to see if I can find what is different between the apps that is causing it to crash.

Applying my build settings caused it to crash in the test app. I'll know more in a few mins :)

@AntRemo Sorry, I don't know how you make your app's architecture, but in this case you need to use reference to your App class in BranchIOS.Init(...)
Example:
....
App app = new App ();
BranchIOS.Init ("Your Branch key here", launchOptions, app);
LoadApplication (app);
....

Found the issue.
If I build with linker OFF, it will crash with this error.
Setting to SDK assemblies only fixes it.  WOW, that was a ALOT of time troubleshooting that.

Great!

@antonargunov is there something that can be done to fix it with the linker off for the future?
I imagine there will be a time where I, or someone else, may need to run with Linker off on device.
Thanks

@AntRemo I tried to make new iOS application with Xamarin SDK nuget package.
All works with "linker behaviour = Don't Link"

@antonargunov Ok thanks.
I am NOT on the latest Xamarin iOS or Forms.  So maybe it is something that will be resolved after I update.

@antonargunov
I am getting the same error frequently when resuming the app.  If I remove the call to BranchIOS.Init () the error does not occur.
[AppDelegate window]: unrecognized selector sent to instance
Any ideas?

I have a repo case...
If you replace your App constructor with:
public App()
{
// The root page of your application
var tabbedPage = new TabbedPage()
{
Children =
{
new ContentPage()
{
Content = new StackLayout
{
VerticalOptions = LayoutOptions.Center,
Children = { new Button() { Text = "Tap Me", Command = new Command(() =>
{
NavigationPage.PushAsync(new ContentPage()
{
Title = "Second Page",
Content = new WebView()
{
Source = "https://www.google.com",
}
});
                        })}
                        }
                    }
                }
            }
        };

        NavigationPage = new NavigationPage(tabbedPage);

        Current.MainPage = NavigationPage;
    }

Launch the app
Tap the button
Tap Home
Tap the app again.

Exception will occur.

@AntRemo sorry but I can't compile that code.
Can you place your test app on github and give me a link?

Good Day @antonargunov!
Please find a repo @ https://github.com/AntRemo/BranchForms
I also have a bit more details on the error
Foundation.MonoTouchException: Objective-C exception thrown.  Name: NSInvalidArgumentException Reason: -[AppDelegate window]: unrecognized selector sent to instance 0x14eb7230
Native stack trace:
0   CoreFoundation                      0x22138123 <redacted> + 150

1   libobjc.A.dylib                     0x218dee17 objc_exception_throw + 38

2   CoreFoundation                      0x2213d925 <redacted> + 0

3   CoreFoundation                      0x2213b3fb <redacted> + 350

4   CoreFoundation                      0x2206bc08 _CF_forwarding_prep_0 + 24

5   BranchFormsTestiOS                  0x0115dcb9 -[BNCStrongMatchHelper presentSafariVCWithBranchKey:] + 832

6   BranchFormsTestiOS                  0x0115d953 -[BNCStrongMatchHelper createStrongMatchWithBranchKey:] + 250

7   BranchFormsTestiOS                  0x01146ca3 -[Branch registerInstallOrOpen:] + 250

8   BranchFormsTestiOS                  0x01146ba5 -[Branch initializeSession] + 280

9   CoreFoundation                      0x220ece9d <redacted> + 12

10  CoreFoundation                      0x220ec8a7 <redacted> + 390

11  CoreFoundation                      0x220ec685 <redacted> + 40

12  CoreFoundation                      0x221402db <redacted> + 1334

13  CoreFoundation                      0x2204ea53 _CFXNotificationPost + 486

14  Foundation                          0x2287a95f <redacted> + 74

15  UIKit                               0x262fc11b <redacted> + 1150

16  UIKit                               0x26512949 <redacted> + 104

17  FrontBoardServices                  0x2340f637 <redacted> + 158

18  Foundation                          0x2291b1e7 <redacted> + 446

19  Foundation                          0x228a635f <redacted> + 66

20  BaseBoard                           0x233a8b8b <redacted> + 102

21  FrontBoardServices                  0x2340aba7 <redacted> + 94

22  FrontBoardServices                  0x2340f4a5 <redacted> + 308

23  UIKit                               0x265130ef <redacted> + 170

24  UIKit                               0x26512db9 <redacted> + 644

25  FrontBoardServices                  0x23401a59 <redacted> + 40

26  FrontBoardServices                  0x2341cc7f <redacted> + 230

27  FrontBoardServices                  0x2341cf71 <redacted> + 48

28  CoreFoundation                      0x220fb68f <redacted> + 14

29  CoreFoundation                      0x220fb27d <redacted> + 452

30  CoreFoundation                      0x220f95eb <redacted> + 794

31  CoreFoundation                      0x2204cbf9 CFRunLoopRunSpecific + 520

32  CoreFoundation                      0x2204c9e5 CFRunLoopRunInMode + 108

33  GraphicsServices                    0x23298ac9 GSEventRunModal + 160

34  UIKit                               0x262dcba1 UIApplicationMain + 144

35  BranchFormsTestiOS                  0x00bba5cc wrapper_managed_to_native_UIKit_UIApplication_UIApplicationMain_int_string___intptr_intptr + 272

36  BranchFormsTestiOS                  0x00b30184 UIKit_UIApplication_Main_string___intptr_intptr + 52

37  BranchFormsTestiOS                  0x00b30144 UIKit_UIApplication_Main_string___string_string + 204

38  BranchFormsTestiOS                  0x000c70a8 BranchFormsTest_iOS_Application_Main_string__ + 152

39  BranchFormsTestiOS                  0x003231f8 wrapper_runtime_invoke_object_runtime_invoke_dynamic_intptr_intptr_intptr_intptr + 256

40  BranchFormsTestiOS                  0x0118bf2f mono_jit_runtime_invoke + 1150

41  BranchFormsTestiOS                  0x011cda05 mono_runtime_invoke + 88

42  BranchFormsTestiOS                  0x011d0e6b mono_runtime_exec_main + 282

43  BranchFormsTestiOS                  0x0123e138 xamarin_main + 2072

44  BranchFormsTestiOS                  0x0113dff9 main + 112

45  libdyld.dylib                       0x21cfb873 <redacted> + 2

Thanks very much :)
Ant

@AntRemo
add please
BranchIOS.Debug = true;
before
BranchIOS.Init(_branchKey, options, this);
I will investigate what is happens without enabling Debug mode.

@antonargunov
Thanks for the workaround! :+1:

Hi @antonargunov!
I was wondering if you made any progress in resolving this.
I'd like to release with this feature, however, I do not want to release with Debug enabled.
Thanks,
Ant

@AntRemo @antonargunov
In the AppDelegate.cs file, I am not sure where the window object is defined/instantiated. Can you check if this object exists?

Hi @ahmedanawar
I think it is handled by the Xamarin.Forms framework.
Unfortunately, I do not know enough about how it works to provide more info.

@ahmednawar
Solution: BranchFormsTest.iOS
File: AppDelegate.cs
Row 26: var commonApp = new App();
Solution: BranchFormsTest
File: App.cs
Row 18: var tabbedPage = new TabbedPage() ..... etc.

@antonargunov does this bug occur for all projects on Xamarin?

@ahmednawar this bug occurs only if you move to NavigationPage that contain WebView (iOS); if you will not move to NavigationPage that contain WebView - all works

Hi @antonargunov
To add, I can make it occur in my app without navigating to a webview, however, I found it also crashes with a webview as well.

@antonargunov which core iOS library version do you use? We changed something in our latest release v 0.12.1 that deals with window objects that might fix this problem

@ahmednawar 0.11.18 I guess

@ahmednawar as I understand I need to update iOS lib, right?

@antonargunov yeah, let's see if this fixes the problem

@AntRemo wait please new version of Xamarin SDK

Hi @antonargunov
Sorry I misunderstand.  Would you like me to wait or upgrade to the latest Xamarin SDK?
Thanks

@AntRemo I meant - wait, I will ping you when I will have new version

@antonargunov Ok cool :)

For what it's worth, I have the same exception in our Xamarin (not forms) application. Application launches properly but if I minimize it, when bringing it back to the foreground it crashes with that exception. I'll be waiting for the update you are talking about.

@MatFillion it will be the best if you ping our support team and send test project where we can reproduce the issue. After I will finish new version I will be able to test and if issue will occur then we will b able to continue fixing without delay.
But if you don't want to create test project, just wait until I will finish new version.
Thanks!

Hi @antonargunov
Just checking in for a status update. :)
Thanks,
Ant

Hi @AntRemo I have committed new version of Xamarin SDK.
You can download nuget package from github and update form your local source or wait until we upload package to nuget.org
Btw, I have checked your test project, I have no exceptions. Try please and write me something :).

Thanks @antonargunov !!! :)
I've never updated from a local nuget source, so I'll have to learn that first. :)

I've updated the production nuget file!

@AntRemo  we have uploaded to nuget.org :)

@aaustin @antonargunov  Awesome!!! THANKS :) I'll test now

@antonargunov @ahmednawar @aaustin Works great now!!! 👍 :)
Thanks so much for the fast turnaround and great service.  I appreciate it!
All the best,
Ant

@AntRemo @MatFillion
I hope all works nice!
Good luck!


fix(windows): Disable rebuilding bindings in electron-builder

We disable npm rebuild and node-gyp rebuild being run through
electron-builder, as we already rebuild native bindings against
the respective CPU arch through make electron-develop, and
electron-builder doesn't appear to respect package's install / rebuild scripts.
Change-Type: patch

I guess this will make electron-builder slightly faster too? :)


0.5.2b: compile failure on macOS (due to using clang?)

Hi,
pip install pyglm fails with all versions between 0.5.0b1 and 0.5.2b1 on macOS 10.13.6 with Xcode 10.1, see gist: https://gist.github.com/devernay/9601e4ad7c0a270b05e80016483a7810
Installing 0.4.8b1 with pip install pyglm==0.4.8b1 succeeds.
My initial guess is that it is probably due to using clang to compile it.

Fixed it and created PR https://github.com/Zuzu-Typ/PyGLM/pull/30

when can we expect this fixed new version?

It'll be a while until I've finished the update I'm currently working on.
I could theoretically push an update of the current version on the PyPI, although I don't see there being such a high demand for it.
You could try building from source otherwise

Thanks for the fix! I found this PR while looking for how to build PyGLM on macOS. I hope you can push this to PyPI, as it is easier to set up than building from source. Thanks!

@wouterbt  @steve3d you must also disable the frexp and ldexp functions to compile on macOS, or wait for a full fix. This can be done by installing from this fork https://github.com/devernay/PyGLM/tree/disable-frexp-ldexp or you can wait for a better solution if you need frexp and ldexp.
@Zuzu-Typ why not use travis-ci to build PyGLM on Linux and macOS, and appveyor to build it on Windows? That way every version would be guaranteed to built on the three systems. This is pretty simple to set up. I would be great to also have a small set of unit tests, at least to test the numerical functions.

I don't have any experience setting up a test suite, but I'll try once I find the time

It can be as simple as running a python script with a bunch of asserts inside, which you can run using pytest to get details about failures: https://docs.pytest.org/en/latest/
As for setting up travis, you just have to insert this simple .travis.yml at the root of the git, and enable the travis build:
https://docs.travis-ci.com/user/languages/python/
to enable multiple OS, see https://docs.travis-ci.com/user/languages/python/#running-python-tests-on-multiple-operating-systems

Thank you very much!
I'll look into that when I have spare time.

And please also tag the same version on github， so we can know the detail changes between each version.


Bugs in examples/scripts/chat.py

I'm trying to use this script to chat with microsoft/Phi-3-mini-4k-instruct, but an issue, possibly with the tokenizer, is formatting the chat incorrectly. Loading a local PEFT adapter for microsoft/Phi-3-mini-4k-instruct creates further issues. I ended up making my own chat script because of these issues.

Hi, thanks for reporting.
Can you provide the code to reproduce, and be more specific than "an issue [...] is formatting the chat incorrectly", or "further issues"? This would enable better referencing and help us address the issue.
Currently, running
python examples/scripts/chat.py --model_name_or_path microsoft/Phi-3-mini-4k-instruct

We get
<quentin_gallouedec>:
What is the capital of France?

<microsoft/Phi-3-mini-4k-instruct>:
The attention mask is not set and cannot be inferred from input because pad token is same as eos token. As a consequence, you may observe unexpected behavior. Please pass your input's `attention_mask` to obtain reliable results.
You are not running the flash-attention implementation, expect numerical differences.
France? The capital of France is Paris. It's one of the most iconic cities in the world, well known for its art,
fashion, gastronomy, and culture. Paris also serves as an important center for international diplomacy and is
home to many organizations, including the United Nations and UNESCO.

<quentin_gallouedec>:

Is it what you are experiencing?

I will specify additional details. I am getting the same results when running your steps. Here is how to recreate the bug:
trl sft \
--model_name_or_path microsoft/Phi-3-mini-4k-instruct \
--dataset_name HuggingFaceH4/no_robots \
--learning_rate 0.0001 \
--per_device_train_batch_size 1 \
--max_seq_length 2048 \
--output_dir ~/llama3-sft \
--use_peft \
--load_in_4bit \
--gradient_checkpointing \
--logging_steps 10 \
--lora_target_modules q_proj k_proj v_proj o_proj

trl chat \
--model_name_or_path llama3-sft/checkpoint-28000 \
--device cuda \
--load_in_4bit

To reproduce:
- Platform: Linux-5.15.0-1048-aws-x86_64-with-glibc2.31
- Python version: 3.11.9
- PyTorch version: 2.4.1
- CUDA device: NVIDIA H100 80GB HBM3
- Transformers version: 4.46.0.dev0
- Accelerate version: 0.34.2
- Accelerate config: not found
- Datasets version: 3.0.0
- HF Hub version: 0.24.7
- TRL version: 0.12.0.dev0+51ca76b
- bitsandbytes version: 0.41.1
- DeepSpeed version: 0.15.1
- Diffusers version: 0.30.3
- Liger-Kernel version: 0.3.0
- LLM-Blender version: 0.0.2
- OpenAI version: 1.46.0
- PEFT version: 0.12.0

$ trl chat --model_name_or_path microsoft/Phi-3-mini-4k-instruct
<quentin_gallouedec>:
Hello, world!

<microsoft/Phi-3-mini-4k-instruct>:
world! Hello there! How can I assist you today?

<quentin_gallouedec>:
What's your opinion?

<microsoft/Phi-3-mini-4k-instruct>:
opinion? As an AI, I don't have personal opinions. I'm programmed to offer information and assistance based on data and
algorithms.

The interface seems to repeat the last word(s) before answering (not consistently though).


Rough edges when swapping QROM for SelectSwapQROM in StatePreparationViaRotation

I was trying to see what would happen to the resource counts if I replaced QROM with SelectSwapQROM in StatePreparationViaRotation and I ran into an issue. A drop in replacement doesn't work. It fails in a way that is captured in this MWE:
import numpy as np

from qualtran.bloqs.data_loading.qrom import QROM
from qualtran.bloqs.data_loading.select_swap_qrom import SelectSwapQROM

data = np.array([1])
selection_bitsize = 0
target_bitsize = 2
control_bitsize = 1

qrom = QROM(
    [data],
    selection_bitsizes=(selection_bitsize,),
    target_bitsizes=(target_bitsize,),
    num_controls=control_bitsize,
)

select_swap_qrom = SelectSwapQROM(
    [data],
    selection_bitsizes=(selection_bitsize,),
    target_bitsizes=(target_bitsize,),
    num_controls=control_bitsize,
)

This looks like a case where a more sensible error should be raised, does SelectSwapQROM make sense with a length 1 array (I think the answer is it should handle it gracefully).


Fix java VM startup for all java versions

This PR fixes #23 and adds a test for java version 8

Codecov Report

Merging #24 into main will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #24   +/-   ##
=======================================
  Coverage   77.18%   77.18%
=======================================
  Files          25       25
  Lines         675      675
=======================================
  Hits          521      521
  Misses        154      154

Impacted Files
Coverage Δ

dask_sql/java.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df4572c...9c0d8d3. Read the comment docs.


[WIP] Introduce Code Marker that is fired when project restore completes

Introduce Code Marker that is fired when project restore completes for Performance tests
Fixes #590
WIP: Currently validating if this approach works

Apart from the ConfigureAwait(true)  -> ConfigureAwait(false) change, looks good. Can we get this merged in?

I've pinged the perf team for confirmation that private drop met their needs. They were having some difficulty detecting the marker.


Heartbeat MQTT message

Today, the sensor sends a MQTT message every second that contains accelerometer data.
If we're getting data, we know the board is alive.
If we implement an edge based STA / LTA algorithm, the sensor will process the accelerometer data at the edge.  If there are no earthquakes, we might not hear from a board for weeks/months.  We won't know its alive.
When we implement STA/LTA edge processing, we should also implement a heartbeat MQTT topic to replace the MQTT data. It does not need to be every second.   The MQTT message would only need to send 1 byte of data.  We can derive the macaddress from the device id (part of the Watson IoT headers).  In the cloud, we could either update the Cloudant record with a last heartbeat timestamp.  The OpenEEW dashboard could read that to indicate status.
There's a Watson IoT Last Event rest api but the dashboard would need to know those credentials.  I could find an example of that implementation too.
Maybe once a minute -  would be 1440 messages/day
Maybe once a hour - would be 24 messages/day
If we're worried about the IBM Cloud Watson IoT Platform lite tier, its limited to 200MB/month so we would want to keep our heartbeats small / sufficiently infrequent.

Doesnt the MQTT broker automatically track devices that are connected to it
? isnt there an inbuilt heartbeat that is used by MQTT which we can simply
read from node-red ?
On Thu, 10 Dec 2020 at 15:40, John Walicki<EMAIL_ADDRESS>wrote:

Today, the sensor sends a MQTT message every second that contains
accelerometer data.
If we're getting data, we know the board is alive.
If we implement an edge based STA / LTA algorithm, the sensor will process
the accelerometer data at the edge. If there are no earthquakes, we might
not hear from a board for weeks/months. We won't know its alive.
When we implement STA/LTA edge processing, we should also implement a
heartbeat MQTT topic to replace the MQTT data. It does not need to be every
second. The MQTT message would only need to send 1 byte of data. We can
derive the macaddress from the device id (part of the Watson IoT headers).
In the cloud, we could either update the Cloudant record with a last
heartbeat timestamp. The OpenEEW dashboard could read that to indicate
status.
There's a Watson IoT Last Event rest api but the dashboard would need to
know those credentials. I could find an example of that implementation too.
Maybe once a minute - would be 1440 messages/day
Maybe once a hour - would be 24 messages/day
If we're worried about the IBM Cloud Watson IoT Platform lite tier, its
limited to 200MB/month so we would want to keep our heartbeats small /
sufficiently infrequent.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/openeew/openeew-sensor/issues/57, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABP5GHLYKHL5JWNIPQAHAFDSUE56PANCNFSM4UVURKEQ
.

--
Andres Meira
m +52 (55) 12246468
*skype *andresmeira

Yes, Possibly.  There is a Node-RED node to query the status of a device.   I have a flow which can enumerate all of the devices.  It then can iterate across all the devices and get status for each one.  I've never used that technique as a heartbeat.  Will need to experiment to see if I can discover if they are up/down
I see:
payload.status.alert.enabled is either true or false
payload.status.alert.timestamp

There are other techniques to get the MQTT status of a device.  Will implement this for the OpenEEW Dashboard in a different way.  Saves sending useless messages to the cloud. Closing ticket.


LEGO: Pull request from lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20210717034257431 to main

LEGO: Pull request from lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20210717034257431 to main with localized lcls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 42.569%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
26721

Relevant Lines:
56890

💛  - Coveralls