Why are the depths taken against a flat object   (equivalent to the floor or wall) by D435 inconsistent?

| Camera Model                       | { R200 / F200 / SR300 / ZR300 / D400 } |
| Firmware Version                   | 5.15.1 |
| Operating System & Version |   Win 10  |
| SDK Version                            |  Intel RealSense Viewer v2.54.2 |

why the depth of floor is different?
I want the background to have the same depth so I can use depth to separate the foreground and background.

Hi @birard  First please try resetting the calibration of your D435 camera to its factory-new default calibration using the instructions at https://github.com/IntelRealSense/librealsense/issues/10182#issuecomment-1019854487

I have calibrated according to the steps but the problem still exist. When i use a certatin distance and a angle, the depth of background will be consistent. And it needs to be very horizontal.  Some parts of the depth are correct, but it's hard to keep them all consistent.

@MartyG-RealSense Thanks ! Now, i have another question about the function colorizer. I want add a colorbar corresponding to depth and color so that i can see the depth value on the picture more directly.
I am new to python, hope you can give me some ideas.

If you wish to add a depth scale bar like the one at the edge of the RealSense Viewer depth image panel then that would be difficult in Python.  More information about this can be found at https://github.com/IntelRealSense/librealsense/issues/11570

Hi @birard  Do you require further assistance with this case, please?  Thanks!

At present, I still haven't found a way to prevent the depth value from being affected by shadows. Is there any other solution that I can refer to?
My project is to use the depth value to scan the grain size as much as possible and separate it, but it seems that this is not a good method for small and complex scenes.

If the camera is at a fixed height above the floor then you could try setting a Threshold Filter post-processing filter.  This filter enables you to set a minimum and maximum distance for depth rendering.  So by configuring the maximum depth distance that can be rendered on the depth image, you may be able to eliminate the shadowed floor from the image and leave the objects just above the floor remaining on the image.

Hi @birard  Do you require further assistance with this case, please?  Thanks!

Case closed due to no further comments received.


Unexpected token (7:4)

I don't know what is the exact problem, code is good.
but not sure where is the problem.

@manishoctal When are you getting this error?
How to re-produce it? Thanks

I just installed, included.
May be some presets error.
I don't know how to resolve this.


Default CPU Instance to 2

Defaults instance groups of KIND_CPU to a count of 2 rather than 1 be default. Pytorch is excluded from this list as it doesn't benefit from this higher instance count. Other backends which need to be excluded can be added to the list.

That's a good catch. I will make sure of that.

It looks fine for now. But we must think of how to configure these settings from backend.


Support TLS hooks on QUIC

These are copied from SSLNetVConnection but aren't used currently. It would be great if we could use the same hooks for both SSL and QUIC. Also, we should use enum class.
https://github.com/apache/trafficserver/blob/85155fa607828380f9b55d2a7ebfbb1b32b1976c/iocore/net/P_QUICNetVConnection.h#L87-L92

The enum was removed. Seems like it was for tunneling, which is currently out of scope. Closing for todo cleanup.


ImapProtocol::logout always throws 'not connected' Exception after upgraded to 4.1.2

After the upgrade the logout function always throws the RuntimeException. I checked the $this->stream value and it's NULL.
src/Connection/Protocols/ImapProtocol.php
public function logout(): array {
        if (!$this->stream) {
            throw new RuntimeException('not connected');
        }

        $result = $this->requestAndResponse('LOGOUT', [], true);

        fclose($this->stream);
        $this->stream = null;
        $this->uid_cache = null;

        return $result;
    }

Does anyone know how to solve this? Thanks!

Hi @gitstashgithub ,
many thanks for your report. I was able to replicate the behavior and pushed a fix :)
Best regards,


can provide java8 base dependency

sorry, I won't be able to support Java8.  because I need to use the Text Blocks feature in Java 17, as the string concatenation in Java 8 is cumbersome to use.


Support labels on server monitoring

Could u support labels attribute on server monitoring?
I want to use labels for applying server alert policy automatically :)

Thanks for the PR @ae06710!
Kind regards,
David


Node crashes during build

Summary
When trying to build 1.13.1 on an F-Droid build VM, Node crashes during bundleReleaseJsAndAssets.
Steps to reproduce
The build recipe is available here but except for the patching, we are basically running this:
make pre-run
gradle assembleRelease

Expected behavior
The app should build correctly.
Observed behavior
The build fails with this error:
DEBUG: buildserver > Execution failed for task ':app:bundleReleaseJsAndAssets'.
DEBUG: buildserver > > Process 'command 'node'' finished with non-zero exit value 137

Possible fixes
This error is probably caused by a lack of memory (our build VMs have 2 GB of RAM and I can't reproduce the issue on my computer with 12 GB of RAM).
Is there a way to limit the amount of memory used by the React Native build script?
(Also, I can't reproduce this with 1.11.0 so I suppose recent versions started to use more ressources.)

@Rudloff Thanks for the report.  That's interesting but I thought 2GB is pretty low.  Honestly, I don't know if there's a way to limit memory usage while building the app.  Maybe try experimenting like upgrading the node version or the like.
Also can you try to revisit our build documentation, especially the build preparation and setting up environment variables and see if there's something that might be helpful in your case?

2GB is pretty low

I agree, but we use these VMs to build much larger apps like Firefox, and it is slow but does not crash like that. I think Gradle is smart enough to detect the available memory but Node does not seem to do that.

Maybe try experimenting like upgrading the node version or the like.

I tried to use Node 10.13.0 but it does not change anything.
I see that Node has a max-old-space-size flag but I am not sure how to make Gradle use it when calling the React Native build script.
I also tried to play with this parameter but it did not work: https://github.com/mattermost/mattermost-mobile/blob/30cccafcd5eb2ff8af39f3c03d7774d89491f501/android/gradle.properties#L14
I guess it only applies to Gradle and not to Node.

Also can you try to revisit our build documentation, especially the build preparation and setting up environment variables and see if there's something that might be helpful in your case?

If I understand correctly, these environment variables are used by make or fastlane, but we call Gradle directly. Anyway, I had a look but did not find anything that could improve memory usage.

I found a way to limit the amount of memory Node can use:
--- a/android/app/build.gradle
+++ b/android/app/build.gradle
@@ -75,7 +75,8 @@ import com.android.build.OutputFile
 project.ext.react = [
     entryFile: "index.js",
     bundleCommand: "ram-bundle",
-    bundleConfig: "packager-config.js"
+    bundleConfig: "packager-config.js",
+    nodeExecutableAndArgs: ["node", "--max-old-space-size=2048"]
 ]

 apply from: "../../node_modules/react-native/react.gradle"

I still wish this could be done automatically but at least we can build the app now :slightly_smiling_face:

It looks like I claimed victory too soon. Even with --max-old-space-size, Node uses too much memory (but not every time for some reason).
But instead of the 137 exit code, I get a more verbose memory allocation error:
:app:bundleReleaseJsAndAssets
warning: the transform cache was reset.
Loading dependency graph, done.
BUILDING MODULES FOR android
FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory

<--- Last few GCs --->

[1576:0x34d1470]    86594 ms: Mark-sweep 994.3 (1067.3) -> 979.9 (1067.6) MB, 1948.2 / 0.1 ms  (average mu = 0.118, current mu = 0.063) allocation failure scavenge might not succeed
[1576:0x34d1470]    88715 ms: Mark-sweep 994.5 (1067.6) -> 983.2 (1066.1) MB, 2019.7 / 0.1 ms  (average mu = 0.083, current mu = 0.047) allocation failure scavenge might not succeed

<--- JS stacktrace --->

==== JS stack trace =========================================

    0: ExitFrame [pc: 0x8e237edbe1d]
Security context: 0x1ceef269e6e1 <JSObject>
    1: push [0x1ceef2685851](this=0x2742b83217d1 <JSArray[0]>,0x0a4cbb1cdf19 <TraversalContext map = 0x3e96aaa9cbe9>)
    2: visitQueue [0x3c73e4440969] [/home/vagrant/build/com.mattermost.rnbeta/node_modules/@babel/core/node_modules/@babel/traverse/lib/context.js:~96] [pc=0x8e238b38d28](this=0x0a4cbb1cdf19 <TraversalContext map = 0x3e96aaa9cbe9>,queue=0x0a4c...

 1: 0x8daaa0 node::Abort() [node]
 2: 0x8daaec  [node]
 3: 0xad73ce v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node]
 4: 0xad7604 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [node]
 5: 0xec4c32  [node]
 6: 0xec4d38 v8::internal::Heap::CheckIneffectiveMarkCompact(unsigned long, double) [node]
 7: 0xed0e12 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [node]
 8: 0xed1744 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [node]
 9: 0xed43b1 v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [node]
10: 0xe9d834 v8::internal::Factory::NewFillerObject(int, bool, v8::internal::AllocationSpace) [node]
11: 0x113cf9e v8::internal::Runtime_AllocateInNewSpace(int, v8::internal::Object**, v8::internal::Isolate*) [node]
12: 0x8e237edbe1d
:app:bundleReleaseJsAndAssets FAILED

It turns out that, while our dev VM has only 2 GB of RAM, our production server has 6 GB.
It seems to be enough to build the app so I will close this issue.
(I am still interested in making it build with 2 GB though, because we use the dev VM to test new builds.)

I have the same problem... VM has 6GB of memory and gets out of memory error here...

But this is crazy, 6GB memory required to build mobile app...

@freerider7777 maybe you need to tweek the max-workers for gradle, if you are building in a CI consider disabling gradle daemon also you could try setting this env vars
JAVA_OPTS: '-Xms1024m -Xmx2g'
      GRADLE_OPTS: '-Xmx3g -Dorg.gradle.daemon=false -Dorg.gradle.jvmargs="-Xmx2g -XX:+HeapDumpOnOutOfMemoryError" -Dkotlin.compiler.execution.strategy=in-process '

and see if that helps

I'm building from command line "make run-android", ok, I'll try!


"package com.google.android.gms.common.GooglePlayServicesClient does not exist"

Does not build because
"Error:(40, 62) package com.google.android.gms.common.GooglePlayServicesClient does not exist"
I have not modified the project in any way.

Building with ./gradlew assemble succeeds.
If the issue persists, feel free to comment and re-open.


Changed the default do_plot behaviour to False in doNd and make it configurable

The default behavior of do_plot is changed to False, which I think it is preferred by most users. Also, it may solve the figure.max_open_warning issue, when users do a lot of plotting simultaneously.

I agree. We should point users towards interactive plots such as plottr rather than doing manual plots like this. @astafan8 @WilliamHPNielsen @Akshita07 what do you think

@FarBo @jenshnielsen @astafan8 this might be out of scope for this PR but maybe it would be worthwhile to rethink the implementation of doNd functions slightly (see comments in this PR https://github.com/QCoDeS/Qcodes/pull/2478). Many setups are run with the need for slightly different default values for the doNd functions. Is there a way to allow the user to choose the defaults at runtime rather than having to request a change in qcodes itself? It gets quite cumbersome if one needs to pass in arguments at every doNd function call just because the default is not what you want.

@ThorvaldLarsen
Updated the pr to still make it false by default but enable the user to change the default value locally via the qcodesrc config file

This is much more a proper way.


UX: Thumbnail is never available during the submission

Describe the bug
The upload step in the submission includes a thumbnail but this can never be present at this stage.
To Reproduce
Steps to reproduce the behavior:

start a new submission and upload a file
the upload step will show a "No thumbnail available" placeholder

Expected behavior
It would be better to avoid to include the thumbnail placeholder at all. The extra space could be used to provide more information about the file that are currently hidden in the edit screen (access conditions and extra metadata) or details about technical metadata (format and checksum)

Agreed, the thumbnail placeholder likely should not be displayed at all on the submission form, since it will never be visible in the submission itself.
This needs a volunteer, but it seems like a lower priority task right now.


[Improvement] Sky cam freeze

Stops the ability to move the camera all arround while loading for a new player

Merge in https://github.com/SOZ-Faut-etre-Sub/SOZ-FiveM-Server/commit/624707f11f505b2a8cbefa9155f846a09cdf00f8
Thanks for the contribution and the improvment ❤


digest-auth-request in cordova app

I'm developing a mobile application with apache/cordova  and i am interested in putting this javascript in my application.
How I can set parameters for a get request to my server?

I actually developed this for use in a cordova app. It should work the same whether you're using it on a website or app. What's the specific issue you have?

Thanks for responding so quickly
I configured authentication api of apigility .
I set the realm , username , password, and domain .
Do I have to configure something in digestAuthRequest.js that I added in my app?
Parameters such scheme , nonce , qop , response , opaque , nc and cnonce I do not know how to configure or whether to leave empty .
Thanks again

The usage explains how to use it, you don't have to configure anything. Did you actually try making a request yet? Again, what's your specific issue?

I believe I have correctly configured the api but always get a 403 forbidden

Okay, I would start adding log statements to see how far you're getting with the request. digestAuthRequest actually makes two requests, it first makes an unauthenticated request to get the challenge, then sends an authenticated request with the challenge response. I would log the first request's response headers, then log the headers of the authenticated request and look at what it's sending back. Let me know what you find out...

These are my logs:
"[digestAuthRequest] Unauthenticated request to http://myuri", source: file:///android_asset/www/js/digestAuthRequest.js (130)
"digestHeaders1: WWW-Authenticate: Digest realm="myrealm", domain="/mydomain", nonce="f11fd749cc76608716d0c2a287183966", opaque="e66aa41ca5bf6992a5479102cc787bc9", algorithm="MD5", qop="auth" ", source: file:///android_asset/www/js/digestAuthRequest.js (64)
"self.realm: myrealm", source: file:///android_asset/www/js/digestAuthRequest.js (78)
"self.nonce: f11fd749cc76608716d0c2a287183966", source: file:///android_asset/www/js/digestAuthRequest.js (83)
"self.opaque: e66aa41ca5bf6992a5479102cc787bc9", source: file:///android_asset/www/js/digestAuthRequest.js (88)
"self.qop: auth", source: file:///android_asset/www/js/digestAuthRequest.js (93)
"self.cnonce: ed69b684e804b64", source: file:///android_asset/www/js/digestAuthRequest.js (98)
"self.nc: 2", source: file:///android_asset/www/js/digestAuthRequest.js (100)
"digestAuthHeader: Digest username="myusername", realm="myrealm", nonce="f11fd749cc76608716d0c2a287183966", uri="http://myuri", response="4a500e1c9582472d266532820ce33c74", opaque="e66aa41ca5bf6992a5479102cc787bc9", qop=auth, nc=00000002, cnonce="ed69b684e804b64"", source: file:///android_asset/www/js/digestAuthRequest.js (157)
"[digestAuthRequest] Authenticated request to http://myuri", source: file:///android_asset/www/js/digestAuthRequest.js (200)
"no dice: 403", source: file:///android_asset/www/js/getCredits.js (17)

well, this isn't stack overflow, I wasn't going to debug your app for you ;) I was just suggesting what you could do.
I can see that you were able to make an authenticated request. I'm thinking since you're getting a 403 your creds are no good. Are you positive that your username and password are correct?

Credentials are correct.
I will configure authentication again because it seems that the error comes from the api .
Thanks for everything

Sure. If it's any help I know this works... other people have had it working.... good luck.


Render to custom image buffer

Have you considered an API that will allow a render to an image buffer ? For embedded apps, showing a window is not necessary, and just drawing to RGBA buffer, and exposing the buffer is preferred.

I haven't but that would be an interesting feature to have. The problem is it seems largely dependent on whether the underlying webviews (WebView2, WKWebview, WebkitGTK) support it. What kind of use cases do you have in mind?


Is this a replacement for the whitespace package?

Editor config addon let's me know there are potential conflicts with White Space package.

I usually have an .editorconfig for all my projects, but sometimes not.
Out of curiosity, to the other users, How do you manage editorconfig plugin and whitespace package/atom indentation settings?
What is the recomendation for Atom users? Should we disable whitespace package? Just curious what the best approach is?

@mhulse - that's a pretty good question. Currently we're not replacing 100% of the whitespace package's functionality (namely most of the exposed commands, f.e. to turn leading spaces into tabs and vice versa).
atom-editorconfig should respect Atom's default configuration if there is no editorconfig property found (or editorconfig file at all). Using the "Fix File"-command allows you to reformat leading (and trailing) spaces, too - but this would need an editorconfig file.
I personally use it as a complete replacement for the whitespace package. But i have to admit that i most of the times have a editorconfig-file.
I guess we have a blind spot for people not using editorconfig files and then need to do a lot of transformations of leading spaces.
I hope that answers your question.

Very helpful! Thank you so much @florianb, I greatly appreciate the help. :)
I have not used the "fix file" command, that's cool! Looking forward to using it.
I think I will just go for a full-on replacement and try to have .editorconfig in all projects.
Thanks again for your help!
I ❤  editorconfig!

@mhulse i am happy to hear that! Enjoy using Atom-Editorconfig and feel free to come back if you face any issues or have any other feedback! 😄  🎁


feat(oidc): add backoff strategy

Closes #1135
/claim #1135
This is my initial work; if it looks okay, I can proceed to add some test cases.
I'm waiting for your feedback.

Hello @ahmethakanbesel, I have assigned the task to you. However, 'keyfunc' may already support some features. Can you review the examples at https://github.com/MicahParks/keyfunc and take another look?

Hello @ahmethakanbesel, I have assigned the task to you as it seems logical. However, 'keyfunc' may already support some features. Can you review the examples at https://github.com/MicahParks/keyfunc and take another look?

Thanks for pointing that out. I refactored it to use the RefreshUnknownKID option of keyfunc.Get without manually re-fetching when 'kid' is not found.


Updated Dockerfile to allow building on network. Tweaked extremes…

… report numeric --> string conversion to include the proper number of decimal places without any trailing 0s.

Coverage decreased (-0.04%) to 97.431% when pulling db5c4a8c9dd0a319e8f2660a60b8e6e101f4df14 on zmoore-usgs:update into c953349a41763f09b2791fe9375bc76c15191c9f on USGS-R:master.


Login Error, server busy (on start)

Expected Behavior
Actual Behavior
2016-08-01 00:38:33,688 [pgoapi.pgoapi] [DEBUG] Auth provider: ptc
2016-08-01 00:38:33,689 [pgoapi.auth] [ INFO] Login for: <LOGIN>
2016-08-01 00:38:33,691 [requests.packages.urllib3.connectionpool] [ INFO] Starting new HTTPS connection (1): sso.pokemon.com
2016-08-01 00:38:34,272 [requests.packages.urllib3.connectionpool] [DEBUG] "GET /sso/login?service=https%3A%2F%2Fsso.pokemon.com%2Fsso%2Foauth2.0%2FcallbackAuthorize HTTP/1.1" 200 104
2016-08-01 00:38:34,475 [requests.packages.urllib3.connectionpool] [DEBUG] "POST /sso/login?service=https%3A%2F%2Fsso.pokemon.com%2Fsso%2Foauth2.0%2FcallbackAuthorize HTTP/1.1" 302 0
2016-08-01 00:38:34,655 [requests.packages.urllib3.connectionpool] [DEBUG] "GET /sso/oauth2.0/callbackAuthorize?ticket=ST-12823768-cTXLM06Z6QMtXzT6li6F-sso.pokemon.com HTTP/1.1" 500 2565
2016-08-01 00:38:35,040 [requests.packages.urllib3.connectionpool] [DEBUG] "POST /sso/oauth2.0/accessToken HTTP/1.1" 200 106
2016-08-01 00:38:35,041 [pgoapi.auth] [ INFO] PTC Login successful
2016-08-01 00:38:35,041 [pgoapi.auth] [DEBUG] PTC Session Token: <TOKEN>
2016-08-01 00:38:35,041 [pgoapi.pgoapi] [ INFO] Starting RPC login sequence (app simulation)
2016-08-01 00:38:35,041 [pgoapi.pgoapi] [ INFO] Create new request...
2016-08-01 00:38:35,042 [pgoapi.pgoapi] [ INFO] Adding 'GET_PLAYER' to RPC request
2016-08-01 00:38:35,042 [pgoapi.pgoapi] [ INFO] Adding 'GET_HATCHED_EGGS' to RPC request
2016-08-01 00:38:35,042 [pgoapi.pgoapi] [ INFO] Adding 'GET_INVENTORY' to RPC request
2016-08-01 00:38:35,042 [pgoapi.pgoapi] [ INFO] Adding 'CHECK_AWARDED_BADGES' to RPC request
2016-08-01 00:38:35,042 [pgoapi.pgoapi] [ INFO] Adding 'DOWNLOAD_SETTINGS' to RPC request including arguments
2016-08-01 00:38:35,042 [pgoapi.pgoapi] [DEBUG] Arguments of 'DOWNLOAD_SETTINGS':

{'hash': '<HASH>'}
2016-08-01 00:38:35,043 [pgoapi.pgoapi] [ INFO] Execution of RPC
2016-08-01 00:38:35,043 [pgoapi.rpc_api] [DEBUG] Generating main RPC request...
2016-08-01 00:38:35,043 [pgoapi.rpc_api] [DEBUG] Generating sub RPC requests...
2016-08-01 00:38:35,043 [pgoapi.rpc_api] [DEBUG] Subrequest class: POGOProtos.Networking.Requests.Messages_pb2.DownloadSettingsMessage
2016-08-01 00:38:35,043 [pgoapi.rpc_api] [DEBUG] Generated protobuf request:

status_code: 2
request_id: <ID>
requests {
  request_type: GET_PLAYER
}
requests {
  request_type: GET_HATCHED_EGGS
}
requests {
  request_type: GET_INVENTORY
}
requests {
  request_type: CHECK_AWARDED_BADGES
}
requests {
  request_type: DOWNLOAD_SETTINGS
  request_message: "\n(05daf51635c82611d1aac95c0b051d3ec088a930"
}
latitude: <LAT>
longitude: <LON>
auth_info {
  provider: "ptc"
  token {
    contents: "<TOKEN>"
    unknown2: 59
  }
}
unknown12: 989

2016-08-01 00:38:35,044 [pgoapi.rpc_api] [DEBUG] Execution of RPC
2016-08-01 00:38:35,045 [requests.packages.urllib3.connectionpool] [ INFO] Starting new HTTPS connection (1): pgorelease.nianticlabs.com
2016-08-01 00:38:35,178 [requests.packages.urllib3.connectionpool] [DEBUG] "POST /plfe/rpc HTTP/1.1" 403 None
2016-08-01 00:38:35,179 [pgoapi.rpc_api] [DEBUG] Parsing main RPC response...
2016-08-01 00:38:35,179 [pgoapi.rpc_api] [WARNING] Unexpected HTTP server response - needs 200 got 403
2016-08-01 00:38:35,180 [pgoapi.rpc_api] [DEBUG] HTTP output:

<title>403 Forbidden</title>

403 Forbidden

nginx/1.11.1

2016-08-01 00:38:35,180 [pgoapi.pgoapi] [ INFO] Cleanup of request!
2016-08-01 00:38:35,182 [pgoapi.pgoapi] [ INFO] Login failed!
[00:38:35]  [X] Login Error, server busy
[00:38:35]  [X] Waiting 10 seconds to try again

Steps to Reproduce
Other Information
OS:
Ubuntu server 16.04.1  x64
commit: c01839d6fed4f8d3a561cdfc8baf661137e3c281 (dev branch, fresh installation)
Python 2.7.12

I just seen this failure, but it was an error with my credentials, are you sure about yours credentials ?

@robertpro Tested with 3 account credentials (including google auth service too), same output

same error here from my aws instance. I guess niantic block the aws IP.
no issue to run with my local IP.

Correct. Most of the large cloud providers are banned

any solution for this guys ?

As a simple workaround, i use a proxy atm on my OpenShift instance
http://docs.python-requests.org/en/master/user/advanced/#proxies
$ export HTTP_PROXY="http://PROXY_URL:PORT"
$ export HTTPS_PROXY="https://PROXY_URL:PORT"

Restart pokecli.py and voilà. Won't work in the long run if niantic keep banning IPs tho.

@kerluc too bad, free proxy got banned too... niantic become very strict ...
any reference proxy that not banned yet ?

[Sugesstion] In this situation script should oputput that "Your ip is banned"

an unrelated and really basic question, how can I run this bot, what is the exact command?
(I was using the PokemonGo-Bot-Desktop version, now I want to use terminal solely.)

@g2384

Dont hijack issues. If you have a problem, post your own issue
Read the wiki. Such a basic question has an answer... https://github.com/PokemonGoF/PokemonGo-Bot/wiki/FAQ#how-do-i-start-the-application


typescript support

Can you provide an crypto-browserify.d.ts? I am using typescript. Without this file, my editor will report an error. At present, I am using a magic revision of crypto.d.ts, and only change its module name to crypto-browserify

Types should come from a DT package, and someone would have to make one.

I solved the problem by adding the reference before import crypto
/// <reference types="node" /> import * as crypto from 'crypto';

Who can solve the problem?

@Bruce-zxy literally anyone who makes a PR to DefinitelyTyped.

some modules have DT
https://github.com/search?q=repo%3ADefinitelyTyped%2FDefinitelyTyped crypto-browserify&type=code


Wrong BOOST_PFR_CORE_NAME_PARSING with "clang for MSVC"

Under Windows with Visual Studio Installer, install "clang compiler for Windows"
With CMake, generate a project with toolset "ClangCL" : -G"Visual Studio 2022" -T ClangCL.
Build.
In this case, _MSC_VER is defined but I need to use the BOOST_PFR_CORE_NAME_PARSING from __clang__.
https://stackoverflow.com/questions/67599384/distinguish-between-clang-cl-and-msvc-cl
Solution is to check __clang__ first :
#ifndef BOOST_PFR_CORE_NAME_PARSING
#   if defined(__clang__)
#       define BOOST_PFR_CORE_NAME_PARSING (sizeof("auto boost::pfr::detail::name_of_field_impl() [MsvcWorkaround = ") - 1, sizeof("}]") - 1, backward("."))
#   elif defined(_MSC_VER)
#       define BOOST_PFR_CORE_NAME_PARSING (sizeof("auto __cdecl boost::pfr::detail::name_of_field_impl<") - 1, sizeof(">(void) noexcept") - 1, backward("->"))
#   elif defined(__GNUC__)
#       define BOOST_PFR_CORE_NAME_PARSING (sizeof("consteval auto boost::pfr::detail::name_of_field_impl() [with MsvcWorkaround = ") - 1, sizeof(")]") - 1, backward("::"))
#   else
// Default parser for other platforms... Just skip nothing!
#       define BOOST_PFR_CORE_NAME_PARSING (0, 0, "")
#   endif
#endif

Here is the fix: https://github.com/boostorg/pfr/pull/149

Close since fix works.


feat: adding reverse transactions

adding reverse scan
for Transaction::Scan and DB::Scan
added test cases

Also test_reverse_scan_with_struct is not correct, because just reverse lower bound and upper bound does not make sense to cross_beam SkipMap, it does not support this to reverse the iteration, you need to change the behavior of MutableScan.

close for stale， thanks vipul!


Implemented dehandle! everywhere it makes sense

Look how much sexier that is...
*cough* *cough*
Excuse me.
Implement dehandle! everywhere we used to use with_handles!. Should not be merged until wlroots-rs is and we fix the removal of the input manager callbacks.

I'm ok with this :+1: .

This broke the compositor xdgv6 map_request function. It says the compositor handle is already borrowed.

thread 'main' panicked at 'Could not upgrade unhandle_name and set the result to handle_name: AlreadyBorrowed', libcore/result.rs:945:5

yikes, my bad.
Also looks like that error message is basically garbage, which is fun..
Will fix after work.

This has been fixed, sorry about that.


Undo/redo function

ctrl-z for undo
shift-ctrl-z for redo (?)
And two buttons too.
Should multiple rotations of the same tile be combined into one undo?

Ctrl-Z = undo
Ctrl-Shift-Z / Ctrl-Y = redo
What needs logged for undo/redo?
2 types of rotations
pin
2 types of edge marks
coordinates
if there is some "checkpoint" system, will that consist of a list of moves which will be undone, or will it be a copy of the entire state? Consider for massive puzzles that a full copy could include a lot, such as the 100x100 that I am currently solving. I would assume that logging the moves since the checkpoint would take less to store.


feat(vc): remove viem from validator client

Overview
Removes viem signer from the validator, this prevents a large amount of data transforming back and forth.
It also makes interfaces much nicer as signing and recovery can be synchronous, which is a very nice to have.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#8517  👈
#8498
#8434
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Maddiaa0 and the rest of your teammates on  Graphite

Benchmark results
Metrics with a significant change:

proof_construction_time_sha256_30_ms (16): 1,362 (-20%)
protocol_circuit_simulation_time_in_ms (private-kernel-tail-to-public): 783 (-44%)
avm_simulation_time_ms (Token:_increase_public_balance): 48.9 (+31%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Proof generation
Each column represents the number of threads used in proof generation.

Metric
1 threads
4 threads
16 threads
32 threads
64 threads

proof_construction_time_sha256_ms
5,755
1,544
704
746 (-1%)
778

proof_construction_time_sha256_30_ms
11,476 (-1%)
3,037 (-2%)
:warning: 1,362 (-20%)
1,423 (-9%)
1,450 (-6%)

proof_construction_time_sha256_100_ms
45,265
11,765 (-1%)
5,698 (+2%)
5,980 (+1%)
5,351 (-6%)

proof_construction_time_poseidon_hash_ms
79.0 (+1%)
34.0
34.0
58.0
88.0 (+1%)

proof_construction_time_poseidon_hash_30_ms
1,531
416
198 (-1%)
223
267

proof_construction_time_poseidon_hash_100_ms
5,673 (+1%)
1,500
669 (-1%)
713 (-3%)
740 (-1%)

L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
4 txs
8 txs
16 txs

l1_rollup_calldata_size_in_bytes
4,612
8,260
15,524

l1_rollup_calldata_gas
52,804
97,622
186,932

l1_rollup_execution_gas
819,490
1,555,716
3,346,461

l2_block_processing_time_in_ms
256 (+2%)
442 (-2%)
828 (+3%)

l2_block_building_time_in_ms
9,333 (-1%)
18,398 (-1%)
36,526 (-1%)

l2_block_rollup_simulation_time_in_ms
9,333 (-1%)
18,398 (-1%)
36,526 (-1%)

l2_block_public_tx_process_time_in_ms
7,917 (-1%)
16,981 (-1%)
35,072 (-1%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric
3 blocks
5 blocks

node_history_sync_time_in_ms
3,158
3,971 (-2%)

node_database_size_in_bytes
14,229,744
18,235,632

pxe_database_size_in_bytes
16,258
26,818

Circuits stats
Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit
simulation_time_in_ms
witness_generation_time_in_ms
input_size_in_bytes
output_size_in_bytes
proving_time_in_ms

private-kernel-init
71.0 (-7%)
374
20,975
44,933
N/A

private-kernel-inner
139 (-2%)
688 (-1%)
71,787
45,067
N/A

private-kernel-reset-tiny
332
695
64,273
44,922
N/A

private-kernel-tail
152
135 (+3%)
50,551
57,178
N/A

base-parity
5.51
N/A
160
96.0
N/A

root-parity
35.4 (+1%)
N/A
73,964
96.0
N/A

base-rollup
2,149 (+1%)
N/A
189,128
664
N/A

block-root-rollup
40.9 (-1%)
N/A
58,217
2,448
N/A

public-kernel-setup
86.0
N/A
114,433
79,670
N/A

public-kernel-app-logic
99.1 (-1%)
N/A
114,251
79,670
N/A

public-kernel-tail
582 (-1%)
N/A
487,098
16,414
N/A

private-kernel-reset-small
302
N/A
66,345
45,629
N/A

private-kernel-tail-to-public
:warning: 783 (-44%)
594 (-3%)
448,120
1,825
N/A

public-kernel-teardown
86.3 (+1%)
N/A
114,697
79,670
N/A

merge-rollup
19.8 (-1%)
N/A
38,182
664
N/A

undefined
N/A
N/A
N/A
N/A
104,731 (+2%)

Stats on running time collected for app circuits

Function
input_size_in_bytes
output_size_in_bytes
witness_generation_time_in_ms

ContractClassRegisterer:register
1,344
11,731
348

ContractInstanceDeployer:deploy
1,408
11,731
18.2 (-1%)

MultiCallEntrypoint:entrypoint
1,920
11,731
421

FeeJuice:deploy
1,376
11,731
396 (+1%)

SchnorrAccount:constructor
1,312
11,731
60.7

SchnorrAccount:entrypoint
2,336
11,731
367 (-1%)

FeeJuice:claim
1,344
11,731
35.4 (-6%)

Token:privately_mint_private_note
1,280
11,731
73.3 (+10%)

FPC:fee_entrypoint_public
1,344
11,731
25.6 (+5%)

Token:transfer
1,312
11,731
206

Benchmarking:create_note
1,344
11,731
74.2 (+1%)

SchnorrAccount:verify_private_authwit
1,280
11,731
26.2 (-1%)

Token:unshield
1,376
11,731
483 (-1%)

FPC:fee_entrypoint_private
1,376
11,731
644 (-1%)

AVM Simulation
Time to simulate various public functions in the AVM.

Function
time_ms
bytecode_size_in_bytes

FeeJuice:_increase_public_balance
136 (-2%)
1,188

FeeJuice:set_portal
11.1 (+25%)
1,170

Token:constructor
254 (+3%)
10,378

FPC:constructor
72.4 (+3%)
7,877

FeeJuice:check_balance
35.6 (+1%)
995

Token:mint_public
246 (+2%)
2,123

Token:assert_minter_and_mint
49.8 (-17%)
1,435

AuthRegistry:set_authorized
44.3 (+22%)
515

FPC:prepare_fee
93.9 (+15%)
1,588

Token:transfer_public
15.5 (-8%)
8,603

FPC:pay_refund
41.5 (+10%)
2,090

Benchmarking:increment_balance
996 (-1%)
1,516

Token:_increase_public_balance
:warning: 48.9 (+31%)
1,159

FPC:pay_refund_with_shielded_rebate
49.7
2,090

Public DB Access
Time to access various public DBs.

Function
time_ms

get-nullifier-index
0.164

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
1 leaves
16 leaves
64 leaves
128 leaves
256 leaves
512 leaves
1024 leaves

batch_insert_into_append_only_tree_16_depth_ms
2.17 (+1%)
3.86
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.7
31.8
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.113 (+1%)
0.108 (-1%)
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
11.1 (-1%)
17.8 (+1%)
31.0 (+2%)
59.2 (-2%)
115 (+4%)

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
95.9
159
287
543
1,055

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
0.106
0.103
0.101 (+1%)
0.102 (-2%)
0.101 (+1%)

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
14.3
26.0 (-2%)
43.7 (+1%)
82.5 (-1%)
163 (-1%)

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
109
207
357
691
1,363

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
0.109
0.105 (-2%)
0.105 (+4%)
0.102 (-1%)
0.102 (-3%)

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
16.1
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
129
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
0.105
N/A
N/A
N/A
N/A

Miscellaneous
Transaction sizes based on how many contract classes are registered in the tx.

Metric
0 registered classes
1 registered classes

tx_size_in_bytes
72,419
668,302

Transaction size based on fee payment method
| Metric |  |
| - |  |


[script] Add method get_sigop_count

Planning to also add methods for the various parts of Transaction etc. to eventually allow for easier sigops calculation.
Bare multisig is making a comeback, which is causing a large amount of transactions' effective vSizes (for fee calculation) to be dependent on the sigop count.
This is a first step at making those transactions easier to estimate fees for / template blocks for etc.

A preview of what's to come:
https://github.com/junderw/rust-bitcoin/compare/feat/getsigopcount...feat/wip-sigop-tx
This is very rough, and I'm assuming it will need to be behind the consensus flag and needs tests... but this is a rough WIP idea of where I'm trying to go with this.
Eventually, we want Esplora to return sigop based vSize as well (if it's higher).
But for now (this PR) I'm putting it off until we discuss here.

Continuing on the thread of things that aren't rust-like, perhaps we should make two methods, get_sigop_count and get_sigop_count_legacy which used accurate = true and false respectively.
Either that or create a bool-enum that's more descriptive, like Accurate, Legacy... any thoughts?

I'd prefer two methods to an enum, but I don't feel strongly.

Now we definitely want a single commit, this is going to be annoying for others to review :)

Done.

hmmm, I don't really like the co-authored-by tag but because you put it in it forced me to look a lot closer at the code so I guess that's a win. (All I did was give some review suggestions so I totally don't need attribution, but thanks for the thought.)
To the best of my knowledge this PR mirrors the behavior in Core CScript::GetSigOpCount.
ACK 85e4672f2ba07c9a7f1380f0b3a4ceaeffdb3fa2

I think I just invented a new underhanded way to get a review! hahahahahah /s

I like changing it to two methods, I was thinking about it before but forgot to mention it. Bit more bikeshedding: in Rust we tend to not use the get_ prefix, so maybe get rid of it? And maybe even rename the method to count_sigops to signal this has linear complexity?

Made the name change. (I agree, the count_sigops name is better)
Removed @tcharding as Co-author. Thanks for your suggestion on the doctest!
Force pushed. (You can see the diff here)

Follow up PR started here: https://github.com/rust-bitcoin/rust-bitcoin/pull/1898/commits/24a33528c8378a89dde63f61b19dbe0c9f9e08bc

A

post merge ACK 1a1fe0e3139386811f3a9ea6d0b47fc6f182eaec. Double checked with bitcoin core source.


feat: Adds licence

Description of the change
Adds licence.

🦙 MegaLinter status: ✅ SUCCESS

Descriptor
Linter
Files
Fixed
Errors
Elapsed time

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff
MegaLinter is graciously provided by


WebSearch: fix search using parentheses inside regular expressions

Originally on 2011-12-02
search_pattern_parenthesised() is breaking the regex search when the search pattern contains parentheses.
Example (taken from the Invenio Search Guide - find all titles containing words dense and matter that are separated by at most one word that doesn't contain the letter l)
Searching for title:/dense ([^ l]* )?matter/
produces the following output:
Search stage 1: search_pattern_parenthesised() searched 'title:/dense ([^ l]* )?matter/'.
Search stage 1: search_pattern_parenthesised() returned ['+', 'title:/dense', '+', '[^ + l]*', '+', '?matter/'].
Search stage 1: basic search units are: [['+', '/dense', 'title', 'w']]
[...]

search_pattern_parenthesised() should not trigger the use of the parenthesis parser but forward the search query as it is to the search_pattern() function, like in the following example:
Searching for title:/dense ([^l]* )?matter/ - note the missing space between ^ and l inside the parentheses which will not trigger the use of parenthesis parser - general case of (foo) vs (foo bar), produces the following output:
Search stage 1: basic search units are: [['+', 'dense ([^l]* )?matter', 'title', 'r']]
[..]

It works with invenio_query_parser:
>>> from invenio.modules.search import api
>>> s = api.SearchEngine('title:/dense ([^ l]* )?matter/')
>>> s.query
KeywordOp(Keyword('title'), RegexValue('dense ([^ l]* )?matter'))

even with parenthesis:
>>> s = api.SearchEngine('(title:/dense ([^ l]* )?matter/ AND author:ellis) OR year:2000')
>>> s.query
OrOp(AndOp(KeywordOp(Keyword('title'), RegexValue('dense ([^ l]* )?matter')), KeywordOp(Keyword('author'), Value('ellis'))), KeywordOp(Keyword('year'), Value('2000')))

Please re-open if needed in invenio_query_parser package.


Update TextBubble Layout to fix choice size placement

Supposed to be a fix for coppolaemilio#1721, also kindof adresses coppolaemilio#1734.
@Kookiness Maybe you could try out this branch?
Choice size is now correctly taken into account and the text-bubble will get as big as needed. When choices get to long, they will get pushed into the next line.
This also means, we can't say for sure how big the choices will be which results in a size-increase after text finished (when choices become visible).
I also decided to rewrite the bubble-shader to more clearly expose the settings that are of interest for us. This results in a bit of a different look, especially with the same settings.
Also fixes

text bubble background ignored modulate alpha

Certainly! I'll give this branch some testing. Thank you for working on this!

Hm, I'm getting an error immediately after confirming dialogue choice selections:

@Kookiness You probably had the name label disabled. I've pushed a fix for that case. Could you try it again?

@Jowan-Spooner
I like the changes so far! Very nice.
I noticed that the size of the bubble around its text isn't always consistent.
Here are some screenshots (two separate ones since the bubble didn't all fit onscreen at once) using default font, font size, padding, but with increased max bubble width:

Here's a screenshot using a different font and reduced max bubble width:

Also, would there be the possibility of having an option to left-align the choices?
And maybe the possibility to force each choice onto a separate line, regardless of the choice's length?
I ask because those seem like the ways I would most intuitively expect choices to be displayed, so the player can just scan down the list quickly and not risk the mistake of not realising that one line has two separate choices displayed on it.
Happy to do further testing!

It was having trouble finding the problem here, but turns out (as shader parameters are shared across instances) any hidden textbubble would also set the box_size parameter of the shader. However while being hidden they would often be of a different aspect ratio and considerably smaller and thus the box background would be stretched a lot (resulting in different padding and bad border aliasing).
I will try to also adress the other requests unless it turns out to be a lot of work.

Great stuff, glad you figured it out. Yeah, I noticed it looks like the speech bubbles were being stretched, rather than using some kind of 9-slice/9-patch type solution. I assumed that was an intentional design decision to be to make the roundness of the corners reflect the dimensions of the bubble, but I'm not certain.
Regarding my suggestion about left-alignment - I just want to mention that I later made a small edit to my comment, to say that having the choices centred might actually be what I would expect - but I think this only makes the most sense if the choices are listed as one per line.
Anyway, no pressure from me - I appreciate you making use of my feedback!

@Jowan-Spooner Not sure if you want more testing yet, but when I try the latest version of this branch, this is what I get with bubbles that have choices, using default size values:

@Kookiness Strange, it works fine for me, and I think this has all settings at default size too.

@Jowan-Spooner Oh, strange. I tried making sure every single setting was reset, and enabled displaying of the character name too, just to make sure we had everything the same.
If it helps, I notice that when choices are displayed, I also get the character name offset differently than yours, so it sits further away from the bubble, making it seem like the bubble needs to be bigger. The bubble also looks more rounded when there are choices.
Here are screenshots comparing bubbles with choices vs. no choices:

Huh, the issue doesn't happen when I just click the "Test Style" or "Play Timeline" buttons; it only happens when I run the game.


"Drained"

please remove the word "drained"
This command does not drain CCE. All calls in progress going via the device are dropped. The following line is factually incorrect: "The appliance is "drained"—that is, all existing calls will complete, but new calls are rejected."

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 857063c3-e4d2-fd72-6643-8a4ecda0112e
Version Independent ID: 446736cd-9690-53d7-a71d-ef668b39f136
Content: Enter-CcUpdate
Content Source: Skype/SfbServer/skype-for-business-hybrid-solutions/plan-your-phone-system-cloud-pbx-solution/enter-ccupdate.md
Product: skype-for-business-itpro
GitHub Login: @CarolynRowe
Microsoft Alias: crowe

@TobieFysh Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

@officedocsbot assign @scanum

@TobieFysh Thank you for your feedback. We have made changes to the description via PR https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/pull/2352

@TobieFysh Thank you for submitting feedback. We understand that this issue has been resolved.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.
@officedocsbot close

@officedocsbot close


improve camera cache warning message

This change updates the warning message displayed when the CameraCache cannot determine which camera is the main.

/azp run


Add the csv data files into the package data discovery

Closes #202

You should just be able to pre-commit run --all-files to fix the interrogate test. Hopefully


Change in the navigation through questions: skip/proceed

In the Navigation at the right side, there is "skip to  previous/next page".
Below the recent question set also the "back", "skip", "save" and "save and proceed" options are available.
For easier control the four buttons could be in the right menu and the "skip to  previous/next page" could be deleted.
Advantage:

no doubling of this functionality at the same page.
avoids scrolling for longer question sets and/small screens.

We discussed this and finally added the same buttons but smaller to the sidebar in 8f96a1adcb9e7da9611378498168c667c6b17e50.


Create shared helper for components

A number of the components are now using the same or similar code for setting a margin bottom and creating a heading level. This PR creates a single shared component helper that provides that functionality in one place, and updates those components that need it to use it.
Trello card: https://trello.com/c/DCHfrY2s/82-draft-create-a-shared-set-of-helper-functions-to-be-used-across-components

@alex-ju thanks for the comments. Yeah, I struggled with the name a bit. I went with that because it was the clearest and shortest thing I could think of. Happy to change it later if we can think of something better.


Mini Map

I want to work in a mini-map on the GUI at some point in the tutorial. I'm not sure which step to insert it into.

Made this an Extra Credit project


Make kuchiki more forgiving about invalid encodings

At the moment I can't parse https://google.com (after resolving redirects), because some character there is invalid UTF-8, apparently.

Could you give more details? Do you get a Result::Error return value? A panic? What does it say exactly? What are steps to reproduce?

I get what seems to be an io::Error. From the server logs:
Io(Error { repr: Custom(Custom { kind: Other, error: StringError("Invalid UTF-8.") })

And indeed the recieved document contains very few invalid bytes. I'd wish for a mode to just skip them (since they are unlikely to be important for the kind of scraping I'll be doing), or replace them with a default character (similar to how Python's decoding modes work).
I suppose the issue can be triggered with any Read that yields invalid UTF-8, but in this particular case I was fetching the document from http://google.com (honoring redirects).

Alright, I see what’s going on.
Kuchiki currently uses "strict" decoding, but it should be using "lossy" decoding that decodes invalid byte sequences as a U+FFFD replacement character. https://github.com/servo/tendril/pull/23 should help with that.
Another issue is that it doesn’t support character encodings other than UTF-8. The from_http method could look at the Content-Type header and there could be another method to override the encoding. Then there’s more detection that should be done on the content, that’s: https://github.com/servo/html5ever/issues/18

Exactly, excellent, thank you!

https://github.com/servo/html5ever/pull/188 is waiting for review. Once that lands, I can finish https://github.com/SimonSapin/kuchiki/pull/19 and clean up the API a bit so that you can use e.g.:
use kuchiki::{parse_html, ParseOpts};
let document = try!(parse_html(ParseOpts::default()).from_http("https://google.com"));

This will pick a character encoding based on, in order:

A byte order mark
A charset parameter of a Content-Type response header
Fall back to UTF-8

More work is needed in html5ever to detect <meta charset=…> elements etc. But that should be doable without changing the API further.

Alright, I published kuchiki 0.4. The usage is something like:
use kuchiki::traits::*;
use kuchiki::parse_html;
let document = try!(parse_html().from_http("https://google.com"));

Let me know if this solves your issue.

Sorry for late response -- from_http doesn't seem to be a thing.

Nevermind, forgot the feature flag. Lemme check again...

Okay, this broke a site I am trying to parse (that worked fine before IIRC) Concretely, https://taskrs.5apps.com/ fails. Here's a rudimentary patch against the testsuite: https://gist.github.com/untitaker/e9a4426a742f0c4a6bfe
The last assertion always fails because the document is certainly not empty, but it should contain more than a barebones document.
I'm still trying to figure out what's wrong.

I've found nothing. The document is just ASCII and otherwise I also don't understand what's wrong with it. What am I missing?

Updated the gist again with a simplified testcase. It seems to me that parsing from bytes is deeply broken.

Oops! This one is my fault: https://github.com/servo/html5ever/pull/190

Alright, a new version with that fix is published, cargo update -p html5ever should fix this.

Excellent, that fixes it, and as far as I can tell the sites I care about work. Thank you.


Ignore goland project folders and files

Signed-off-by: Joshua Moody<EMAIL_ADDRESS>

Moved the .gitignore changes to a separate branch

I closed #475 to move the changes onto a separate branch.


Multiple items on the same day in wrong order

Hi,
If you have multiple items on the same day, they are in random order. Can you sort them by Start time?

Thanks!!


Add a new argument to a request that allows people to always keep the same method after a redirect

Hi, i'm sorry if this is written incorrectly - unsure if feature requests are really allowed, so if they're not just simply delete the issue.
A small annoyance i've found which isn't a problem specifically with requests is when a webserver uses a 302/301 redirect when they should be using a 307 or a 308. This happens a lot with common webservers as more and more websites have http -> https redirects.
This can be a problem when doing anything that isn't a GET request, as request's resolve_redirects code will change the request method when the webserver isn't using the correct http status code (or is trying to preserver backwards compatibility.
My suggestion is to add an argument to a request that allows people to not rebuild the method in the case of redirects.
I have written the code (and test) for it if anybody is interested to look at it.

Thanks, but Requests isn’t accepting additional keyword arguments at this time. Disabling redirect resolution or overriding some of the methods on Session that handle redirects can get you what you want.

I do know it's fixable via disabling redirect resolution, it's just a bit of a pain to work with.
Thanks though, wasn't sure what was allowed to be added and what wasn't..


[WIP] Change attribute most_likely_phase to phase in PhaseEstimator

IterativePhaseEstimation #6096 will satisfy the PhaseEstimator interface.
However, the property for retrieving the phase is currently
PhaseEstimator.most_likely_phase, which is too specific to accomodate
IterativePhaseEstimation, which only computes a single phase in any
case. This PR renames this property to phase, and leaves the
definition of phase to the specific implementation.
This PR currently does not include a deprecated version of the previous attribute most_likely_phase. Perhaps it should.

This PR currently does not include a deprecated version of the previous attribute most_likely_phase. Perhaps it should.

Yes, I think it should, could you add one? 🙂


Mechanism for installing via RPM

QwikContext
I think many sysadmins would prefer to install via RPM(s) in RHEL-like environments.
Details
To support the building of RPMs a RPM spec file is required.  I think dependencies can also be pulled from EPEL rather than PyPI.
Impact
See #18 and #19 for users that might benefit from this.

thanks @willfurnass. This is great.


Fix LocaleStore type

Looks like LocaleStore is WritableAtom with set function.
import { createI18n, localeFrom, browser, formatter } from '@nanostores/i18n'
import { persistentAtom } from '@nanostores/persistent'

let availableLanguages: string[] = ['en', 'ru']

export let localeSettings = persistentAtom<string>('PROJECT_LANGUAGE')

export let locale = localeFrom(
  localeSettings,
  browser({
    available: availableLanguages,
    fallback: 'en',
  }),
)

console.log('locale', locale)

LocalStore should take local only from sources.
set() is sort of semi-private method which developers should not use.


Exclude classes by path

What is your use-case and why do you need this feature?
We would like to exclude all generated sources from the coverage report/verify rules, we are using dagger that adds some annotations but they don't have BINARY or RUNTIME retention.
Source set exclusion does not work for us as Kapt generated sources are included in the main source set.
We could use class inheritance to filter some (maybe all) generated classes but it is not working and even when working it adds a time penalty.
Adding a feature to exclude from reports/verification based on source path can help excluding all autogenerated classes that are stored in the build directory in gradle it should be efficient and work with most of the code generation tools as they tend to store the generated classes in a different path.
Describe the solution you'd like
Add another option to exclude (maybe include) classes by file path, perhaps an exclude dir option or something similar.

Unfortunately, there is a problem with the directory filter, namely, compiled class-files do not store the directory where the source file was located, but only the name of this file.
We can indirectly guess the directory by the package name and the filename from the class-file.
However, in general, this does not work, because in Kotlin, the directory name may differ from the package name.

To ensure that the source file directory is analyzed, it is necessary to work at the compiler level.
We will be able to implement this after integration with KGP (see #608), because this is a major change that also changes the workflow of Kover.