openjdk11: 11.0.8+10 -> 11.0.8-ga

Motivation for this change
Fixes #95117 ... which I don't really know how to square with https://github.com/NixOS/nixpkgs/pull/94029#issuecomment-670248960, but it's definitely true.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Hi, can this PR be reviewed/merged please? I have the same problem for the last few days:
# A LOT of output
stripping (with command strip and flags -S) in /nix/store/7q3hx50k458la5yssrl7mqisg98lpqij-openjfx-modular-sdk-12-14/.
patching script interpreter paths in /nix/store/7q3hx50k458la5yssrl7mqisg98lpqij-openjfx-modular-sdk-12-14
checking for references to /build/ in /nix/store/7q3hx50k458la5yssrl7mqisg98lpqij-openjfx-modular-sdk-12-14...
output '/nix/store/7q3hx50k458la5yssrl7mqisg98lpqij-openjfx-modular-sdk-12-14' is not allowed to refer to the following paths:
  /nix/store/v2brw3j6nwfq2jzib97n7knr09ckqv2a-openjdk-headless-11.0.8+10
cannot build derivation '/nix/store/74dk6rzwqignfzpb0vrq75dm2lpzapgy-openjdk-12.0.2-ga.drv': 1 dependencies couldn't be built
# blabla

I understand this PR would fix it?

What's missing for this to be merged please?

@asbachb @Ma27 do you have any opinion or alternative solution?

I guess I changed it from "-ga" to "+10" since thats the versioning the jdk is normally versioned.

If there's a workaround for having the build number instead of "ga" I'd prefer that.
I don't know what's the exact problem with the derivation.
/CC @edwtjo

I agree it would be nice if we understood this better.  But, I'm not sure it needs to hold up the merge either.
I think one next step to understanding it is to see if we can find out how the build against +10 ends up referencing it (since nix doesn't report that to us).

Currently taking a look at it btw :) Would merge after that unless I find something.

I figured out the source of the problem: The output path of openjdk11_headless is used in  a sed command in pkgs/development/compilers/openjdk/openjfx/14.nix line 99. But the new version contains a '+', which is not escaped and thus interpreted as a regular expression quantifier.

@petabyteboy do you want to fix this here or shall we merge?

I have a fix that I am testing right now. I think we can close this and I will open another PR with a proper fix in a moment.


Missing operators =+ and =- in binary_operator_spaces rule

The PHP version you are using ($ php -v):
=> 7.0.2
PHP CS Fixer version you are using ($ php-cs-fixer -V):
=> 2.8.3
If applicable, please provide minimum samples of PHP code (as plain text, not screenshots):

before running PHP CS Fixer (no changes):

class Response extends SymfonyResponse
{
    const HTTP_INVALID_BRAIN_RESPONSE = 550;

    public static $statusTexts =+ [
        self::HTTP_INVALID_BRAIN_RESPONSE => 'Invalid response from Brain client',
    ];
}

with unexpected changes applied when running PHP CS Fixer:

class Response extends SymfonyResponse
{
    const HTTP_INVALID_BRAIN_RESPONSE = 550;

    public static $statusTexts = +[
        self::HTTP_INVALID_BRAIN_RESPONSE => 'Invalid response from Brain client',
    ];
}

with the changes you expected instead:

class Response extends SymfonyResponse
{
    const HTTP_INVALID_BRAIN_RESPONSE = 550;

    public static $statusTexts =+ [
        self::HTTP_INVALID_BRAIN_RESPONSE => 'Invalid response from Brain client',
    ];
}

Conclusion
There should be no diff. Instead $a =+ []; is transformed to $a = +[];. This seems to be due to missing =+ operator in binary_operator_spaces rule. The =- might me also affected.

AFAIK the =+ operator does not exist. I'd say that PHP reads it as = operator followed by + operator so the fixer behavior is actually correct.
Note that since PHP 7.0.18, this code snippet would trigger an error: https://3v4l.org/uftMc. In such case, the fixing process should catch it and ignore the file.

You are right. Thank you 😄


R grammar has been updated (breaking treesj)

First, thanks for the great plugin, I use it all the time.
Some nodes were recently renamed in treesitter-r and as a consequence, the split does not work anymore.

I have submitted a PR on nvim-treesitter-textobject regarding these new changes to the nodes (https://github.com/nvim-treesitter/nvim-treesitter-textobjects/pull/645/files).
Do you think it would be an easy fix?

Hi!

Do you think it would be an easy fix?

I think it would be a very easy fix:

Just change the names of the nodes here;
and update the tests for R;

Do you plan to do a PR?

I can try to do it!

Might missing the new comma thing?

I started to figure it out, and indeed it turned out to be a bit more complicated than just renaming the nodes. So I made a PR that passed the tests (#156).
I have questions about the code you suggested (since I don't write in R myself).
In particular about the operators '<-', '<<-', '->', '-->', etc.: did I understand correctly that they only occur inside the binary_operator node and can be removed from the config entirely?

I started to figure it out, and indeed it turned out to be a bit more complicated than just renaming the nodes. So I made a PR that passed the tests (#156).
I have questions about the code you suggested (since I don't write in R myself). In particular about the operators '<-', '<<-', '->', '-->', etc.: did I understand correctly that they only occur inside the binary_operator node and can be removed from the config entirely?

I think so. Let me install this commit and play around for a bit so I can confirm.


fix arp proxy exit in large scale cluster

Pull Request Description
Describe what this PR does / why we need it
In a large scale cluster, the number of vxlan neigh cache entries on the every node might grow to a huge size, which will bring a "No buffer space available" failure for netlink.NeighSubscribe function. Once NeighSubscribe function is exit, userspace arp proxy will never start again. (The NeighSubscribe function will also close the event channel passed to it.)
Does this pull request fix one issue?

NONE.
Describe how you did it
In this PR, I fix the NeighSubscribe exist problem and change the behaviors of arp proxy to control the size of neigh cache size:

Multicast arp/ndp request will only be sent if a neigh cache is INCOMPLETE, in other words, when neigh cache is just created. So we just need to handle the INCOMPLETE netlink neigh event, and proxy arp for it.
Unicast arp/ndp probe request will be sent if a neigh cache is STALE. This will not be handled in arp proxy.
Gratuitous arp/ndp packets will be sent on overlay forward interface once, while an overlay/underlay pod is being created.
Daemon will clean STALE and FAILED neigh caches periodically on vxlan interface, default once an hour.

Describe how to verify it
Special notes for reviews

Codecov Report

Merging #111 (9ca3634) into main (83fef4c) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #111   +/-   ##
=======================================
  Coverage   18.00%   18.00%
=======================================
  Files          31       31
  Lines        2516     2516
=======================================
  Hits          453      453
  Misses       2006     2006
  Partials       57       57

Flag
Coverage Δ

unittests
18.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/daemon/arp/arp.go
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83fef4c...9ca3634. Read the comment docs.


Cleanup usage of SyncManager and Settings across codebase.

I changes Settings.LatestCommitment and Settings.LastFinalizedSlot usages that require taking the values from the underlying KVStore, to use SyncManager which stores the value in memory.
Values from Settings are still used during component initialization to avoid potential problems due to order in which components are initialized and in some low-level Storage logic.

Would it also be worth considering an in-memory latestCommitment for the notarization manager? storage.Settings() is accessed very frequently there.

It is used in a few different places across the code, however to me it looks like it's only executed when the node is not bootstrapped yet or when we're committing (which happens only every 10s).
Looking a bit closer at the settings we can see that the latestCommitment is stored as *kvstore.TypedValue[*model.Commitment] which actually manages an in-memory version abstracted away.


User prettier-config VS shadcn-formatting

Using a prettier config different from what the components are based on creates a lot of unnecessary diffs, which makes using the diff command (I know it's experimental right now) quite cumbersome.
It would be nice to either

automatically (and optionally) add the shadcn-prettier-config to a project when initializing
format the upstream with the user's prettier config before comparing

Any opinions? Would be happy to help if someone could point me in the right direction
Diff from badge component:
import * as React from "react"
import { cva, type VariantProps } from "class-variance-authority"
import * as React from "react";
import { cva, type VariantProps } from "class-variance-authority";

import { cn } from "@/lib/utils"
import { cn } from "@/lib/utils";

const badgeVariants = cva(
  "inline-flex items-center rounded-full border px-2.5 py-0.5 text-xs font-semibold transition-colors focus:outline-none focus:ring-2 focus:ring-ring focus:ring-offset-2",
  "inline-flex items-center rounded-full border px-4 py-1 text-xs font-semibold transition-colors focus:outline-none focus:ring-2 focus:ring-ring focus:ring-offset-2",
  {
    variants: {
      variant: {
        default:
          "border-transparent bg-primary text-primary-foreground hover:bg-primary/80",
        secondary:
          "border-transparent bg-secondary text-secondary-foreground hover:bg-secondary/80",
        destructive:
          "border-transparent bg-destructive text-destructive-foreground hover:bg-destructive/80",
        outline: "text-foreground",
      },
    },
    defaultVariants: {
      variant: "default",
    },
  }
)
);

export interface BadgeProps
  extends React.HTMLAttributes<HTMLDivElement>,
    VariantProps<typeof badgeVariants> {}

function Badge({ className, variant, ...props }: BadgeProps) {
  return (
    <div className={cn(badgeVariants({ variant }), className)} {...props} />
  )
  );
}

export { Badge, badgeVariants }
export { Badge, badgeVariants };

This issue has been automatically closed because it received no activity for a while. If you think it was closed by accident, please leave a comment. Thank you.


CRAN Error

Dear maintainer,
Please see the problems shown on
https://cran.r-project.org/web/checks/check_results_ssdtools.html.
Specifically, please see the noRemap additional issue.
Compilation fails when using R_CXX_USE_NO_REMAP=true, which compiles
C++ code with R_NO_REMAP defined.  See chapter "The R API: entry points
for C code" in "Writing R Extensions" for more information.
It is planned that R_CXX_USE_NO_REMAP=true will become the default in
due course, ideally already for R 4.5.0, for which it would be good if
all CRAN packages compile/install ok with the new default.
Your package is among the ones which need updating.  We would thus
really appreciate if you could provide a new version of your package as
soon as possible which checks ok with R_CXX_USE_NO_REMAP=true.
You can verify that your package checks ok with
R_CXX_USE_NO_REMAP=true via R CMD check --as-cran using a current
version of R-devel.
Please correct before 2024-10-21 to safely retain your package on CRAN.
Best wishes,
The CRAN Team

Closed by e0bfc03386809f0844cb9d2e74e9edc5a505c668


Migrate CircleCI jobs to 2.0

Migrate CircleCI jobs to 2.0. Some of CI jobs are running on CircleCI and using 1.0. Will start failing after August 31 because 1.0 service will stop supporting.
ref: https://circleci.com/docs/2.0/migration/

Related PR: https://github.com/treasure-data/digdag/pull/817


Proof Key Tester example in Java

Proof Key Tester example in Java

@jkratter,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.
It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@jkratter, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.
Thanks, Microsoft Pull Request Bot


MCU mode

iam trying to send and receive data with meshbee MCU mode
but it always fail
could any one put a simple example for me
thanks

Hi mostafa,
Please find the cook book and user manual at the google group of mesh bee.
https://groups.google.com/forum/#!topic/seeedstudio-mesh-bee-discussion-group/NByFzvWBsWg

i turns out that i was using old version of cookbook
i tried the API in the new version but there is no aupsairportreadable function or aups air port read
is there new version of the firmware or i have missing files ?


Desruisseaux jdk8

As of June 2017, Apache SIS source code is still hosted on Subversion (SVN); this GitHub repository is a read-only mirror. Consequently it is not possible to merge this pull request. However parts of it have already been merged manually to the SVN repository.


fend: 1.0.4 -> 1.0.5

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/printfn/fend/releases.
meta.description for fend is: "Arbitrary-precision unit-aware calculator"
meta.homepage for fend is: "https://github.com/printfn/fend"
meta.changelog for fend is: ""
Updates performed

Rust version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.0.5 with grep in /nix/store/bs6sywb61y3qnfr0krfqrg2yss7kwg6b-fend-1.0.5
found 1.0.5 in filename of file in /nix/store/bs6sywb61y3qnfr0krfqrg2yss7kwg6b-fend-1.0.5

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
fend

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/bs6sywb61y3qnfr0krfqrg2yss7kwg6b-fend-1.0.5 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A fend https://github.com/r-ryantm/nixpkgs/archive/5c8381a7a203fa16422ea18bf32f4243bf3db2bb.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/bs6sywb61y3qnfr0krfqrg2yss7kwg6b-fend-1.0.5
ls -la /nix/store/bs6sywb61y3qnfr0krfqrg2yss7kwg6b-fend-1.0.5/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

fend

Maintainer pings
cc @djanatyn for testing.

Result of nixpkgs-review pr 186610 run on x86_64-linux 1

1 package built:

fend

Result of nixpkgs-review pr 186610 run on x86_64-linux 1

1 package built:

fend


GridListEditorEventController Error

Hi
GridListEditorEventController Error during for FotterOptionOn and User RightClick
Error Log
Object reference not set to an instance of an object.
at Xpand.ExpressApp.Win.SystemModule.RuleCollector..ctor(IModelListView modelListView) in D:\a\1\s\Xpand\Xpand.ExpressApp\Xpand.ExpressApp.Win\SystemModule\GridListEditorEventController.cs:line 129
at Xpand.ExpressApp.Win.SystemModule.GridListEditorEventController.GridViewOnPopupMenuShowing(Object sender, PopupMenuShowingEventArgs e) in D:\a\1\s\Xpand\Xpand.ExpressApp\Xpand.ExpressApp.Win\SystemModule\GridListEditorEventController.cs:line 38
at DevExpress.XtraGrid.Views.Grid.PopupMenuShowingEventHandler.Invoke(Object sender, PopupMenuShowingEventArgs e)
at DevExpress.XtraGrid.Views.Grid.GridView.RaisePopupMenuShowing(PopupMenuShowingEventArgs e)
at DevExpress.XtraGrid.Views.Grid.GridView.DoShowGridMenu(GridMenuEventArgs e)
at DevExpress.XtraGrid.Views.Grid.Handler.GridHandler.OnMouseDown(MouseEventArgs ev)
at DevExpress.Utils.Controls.BaseHandler.ProcessEvent(EventType etype, Object args)
at DevExpress.XtraGrid.GridControl.OnMouseDown(MouseEventArgs ev)
at System.Windows.Forms.Control.WmMouseDown(Message& m, MouseButtons button, Int32 clicks)
at System.Windows.Forms.Control.WndProc(Message& m)
at DevExpress.XtraEditors.Container.EditorContainer.WndProc(Message& m)
at DevExpress.XtraGrid.GridControl.WndProc(Message& m)
at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

please post more details on how to repro it

Open Model Edtior
Enable IsFooterVisible in ListView
Go and RightCLick on FooterPanel
Exception Raised

I fail to repro the problem from the info you posted. This is what I tried:

Create a new Empty XAF solution
Install latest nuget SystemWin package from lab servers
Modify the model
Right click with no issues
attaching my sample
Solution267.zip

Closing issue for age. Feel free to reopen it at any time.
.Thank you for your contribution.


Bug 1798051: Reinstate v1alpha2 operatorgroup

We did not properly deprecate v1alpha2 version of operatorgroup crd in
the 4.4 OpenShift release. Adding back that version to the crd spec
In addition, this pr cuts a new upstream release to keep the manifests
in lockstep (along with fixing the 0.14.1 upstream release)
https://bugzilla.redhat.com/show_bug.cgi?id=1798051

/lgtm

/bugzilla refresh

/retest

/test e2e-aws-olm
TestDeleteInternalRegistryPodTriggersRecreation Failure

/test e2e-aws-console-olm

/retest

/retest

/lgtm

/cherry-pick release-4.2

/cherry-pick release-4.4


List of all companies where authenticated user is the Admin

I couldn't figure out which helper method to use in order to get list of all companies where the current user is Admin. I can see this Api end point(https://api.linkedin.com/v1/companies?format=json&is-company-admin=true) listed on LinkedIn page (List of all companies) which provides list of all companies including their id in json format but not sure how to query the same using Linkedin Gem.
I did checked out the rubydocs (http://www.rubydoc.info/gems/linkedin/LinkedIn/Api/Companies) and I did found everything but not the method which provides list of all companies.
Any help would be much appreciated.

Sorry that was my mistake, I kept ignoring the options hash part in Company Api section.


Even with official demos, SwiperJS on mobile is really laggy.

Look at this video: https://user-images.githubusercontent.com/8330244/197607387-cd5e891a-b3aa-4bd2-afbf-02893ee4f444.MP4
I am attaching a video to express the issue which is clearly visibile even on official swiper js demos.
It's simply "laggy" when swiping, it's not smooth.
I noticed it once I visited nytimes.com and noticed how nytimes could make very smooth swipers containing high quality pictures.
Why Swiper JS is not at that level?
Regards

Your issue is closed because it is not filled correctly. Before you open an issue please review the contributing guideline.
Please fill the issue template correctly and:

Clearly describe the issue including steps to reproduce when it is a bug.
Make sure you fill in the earliest version that you know has the issue.
Provide live link or JSFiddle/Codepen or website with isssue

It will save a lot of time for other contributors to check your issue and fix it.


#734: Http Integration tests for COMMAND and COMMAND/COUNT

Fixes: https://github.com/DiceDB/dice/issues/734
I will be splitting the implementation of this issue in multiple PR's.
The PR contains tests to for the below commands

COMMAND/COUNT : command_count_test.go
COMMAND: command_default_test.go

@svkaizoku build is failing can you please have a look?

@lucifercr07  Done 👍

@svkaizoku please resolve comments and conflicts.

@lucifercr07 on it. Will do it today.

@svkaizoku build is failing, please have a look.

@svkaizoku build is failing, please have a look.

@lucifercr07

@svkaizoku build is failing, please have a look.

Hey @lucifercr07
I need to send empty body for the request. But i am not sure how to do it though.
{
name: "Command count should be positive",
commands: []HTTPCommand{
{Command: "COMMAND/COUNT", Body: map[string]interface{}{}},
},
expected: []interface{}{float64(123)},
}
If i do this, an Invalid HTTP request format error is coming. i have asked the same in discord, can you point me to an example if you know?

@svkaizoku build is failing, please have a look.

@lucifercr07

@svkaizoku build is failing, please have a look.

Hey @lucifercr07 I need to send empty body for the request. But i am not sure how to do it though. { name: "Command count should be positive", commands: []HTTPCommand{ {Command: "COMMAND/COUNT", Body: map[string]interface{}{}}, }, expected: []interface{}{float64(123)}, }
If i do this, an Invalid HTTP request format error is coming. i have asked the same in discord, can you point me to an example if you know?
What is the use case for this error?
https://github.com/DiceDB/dice/blob/97e435cda39df070310fab9a3b7dfb8d7305c97a/internal/server/utils/redisCmdAdapter.go#L76
Can i remove this?

No need to remove it. Have updated ability to add empty body in tests.

@lucifercr07  can you take a look at this PR?

@svkaizoku build is failing, please have a look.

@lucifercr07 it is fixed, can you take a look now?


chore: bump dependencies to the latest version

Migrate dependencies to the latest versions

@gkalpak PR ready for another round of review

Changed commit message

@jzolnowski, can you please rebase this on master (avoid merge commits) and make sure the commit is signed? 🙏

Done

The commit does not seem to be recognized as signed by GitHub? Have you set up commit-signing locally?

The commit does not seem to be recognized as signed by GitHub? Have you set up commit-signing locally?

Fixed that in the current PR:

Do you want me to set the signature to the old commits? Or is it good as it is now?

All commits should be signed (including old ones) for the PR to be good to go.

All commits should be signed (including old ones) for the PR to be good to go.

Commit signed

We should also update the PageHome component's template to mention/link to XLTS.dev packages (and update or remove the version numbers).

Please rebase and resolve conflicts.

Branch up-to-date with master.
README and PageHome updated.


Update README.md

fixed typo

Thank you a lot.
So I have at least 1 download !
BTW. Benjamin de Boe confirmed 1st release of iKnow was with  Caché 2011.2 / 2012.1
They were a bit insüired by my approach.
Regards, Robert


fix: create roles before migration

Hi! Thanks for working on this!
I wanted to run tests (mix test) in the project and hit a couple of snags in a fairly fresh vanilla Ubuntu install (I can give details about them if you'd like, but it is not related to this issue at hand. There are a couple of dependencies that I didn't have, but were straightforward to add (cargo, cmake, llvm and friends).
Once everything is set up and we are able to run things, there is a check in the priv/repo/seeds_after_migration.exs that will never succeed (making sure the roles are created). It's because we don't create them in tests, we only do it in dev (https://github.com/supabase/supavisor/blob/main/dev/postgres/00-setup.sql#L1-L3). At least, this is what I think at the moment (I may be wrong).
What kind of change does this PR introduce?
Small test setup change, allows to run a mix test from the project root.
What is the current behavior?
I got the following error when running locally:
10:40:42.512 [info] == Running<PHONE_NUMBER>3121 Supavisor.Repo.Migrations.AddDefaultPoolStrategy.change/0 forward file=lib/ecto/migration/runner.ex line=342 pid=<0.961.0>
10:40:42.512 [info] alter table _supavisor.tenants file=lib/ecto/migration/runner.ex line=342 pid=<0.961.0>
10:40:42.513 [info] create check constraint default_pool_strategy_values on table _supavisor.tenants file=lib/ecto/migration/runner.ex line=342 pid=<0.961.0>
10:40:42.514 [info] == Migrated<PHONE_NUMBER>3121 in 0.0s file=lib/ecto/migration/runner.ex line=342 pid=<0.961.0>
** (MatchError) no match of right hand side value: {:error, :rollback}
    priv/repo/seeds_after_migration.exs:66: (file)
    (elixir 1.15.4) lib/code.ex:1435: Code.require_file/2

What is the new behavior?
The roles are created in the test db successfully.
Additional context
Debugging sesh:
Add this diff (where my pg lives):
diff --git a/config/test.exs b/config/test.exs
index 66e90b2..e8cbf5f 100644
--- a/config/test.exs
+++ b/config/test.exs
@@ -19,7 +19,7 @@ config :supavisor, Supavisor.Repo,
   database: "supavisor_test#{System.get_env("MIX_TEST_PARTITION")}",
   pool: Ecto.Adapters.SQL.Sandbox,
   pool_size: 10,
-  port: 6432
+  port: 5432

Try mix test:
10:40:42.512 [info] == Running<PHONE_NUMBER>3121 Supavisor.Repo.Migrations.AddDefaultPoolStrategy.change/0 forward file=lib/ecto/migration/runner.ex line=342 pid=<0.961.0>
10:40:42.512 [info] alter table _supavisor.tenants file=lib/ecto/migration/runner.ex line=342 pid=<0.961.0>
10:40:42.513 [info] create check constraint default_pool_strategy_values on table _supavisor.tenants file=lib/ecto/migration/runner.ex line=342 pid=<0.961.0>
10:40:42.514 [info] == Migrated<PHONE_NUMBER>3121 in 0.0s file=lib/ecto/migration/runner.ex line=342 pid=<0.961.0>
** (MatchError) no match of right hand side value: {:error, :rollback}
    priv/repo/seeds_after_migration.exs:66: (file)
    (elixir 1.15.4) lib/code.ex:1435: Code.require_file/2

Add inspects with this diff:
diff --git a/priv/repo/seeds_after_migration.exs b/priv/repo/seeds_after_migration.exs
index 58b1ce4..2e8fef0 100644
--- a/priv/repo/seeds_after_migration.exs
+++ b/priv/repo/seeds_after_migration.exs
@@ -77,5 +77,7 @@ end)
       "grant all on table public.test to postgres;",
       "grant all on table public.test to authenticated;"
     ]
-    |> Enum.each(&query(Repo, &1, []))
+    |> Enum.each(fn el ->
+      query(Repo, el, []) |> IO.inspect(label: "SHEEP")
+    end)
   end)

We get:
# all previous are successes

SHEEP: {:ok,
 %Postgrex.Result{
   command: :create_table,
   columns: nil,
   rows: nil,
   num_rows: 0,
   connection_id: 1536665,
   messages: []
 }}
SHEEP: {:error,
 %Postgrex.Error{
   message: nil,
   postgres: %{
     code: :undefined_object,
     line: "5184",
     message: "role \"anon\" does not exist",
     file: "acl.c",
     unknown: "ERROR",
     severity: "ERROR",
     routine: "get_role_oid",
     pg_code: "42704"
   },
   connection_id: 1536665,
   query: nil
 }}

# all below are errors, since this is a Repo.transaction/1 call

I am getting a different error at the moment, but seems to be that my current Erlang install (26.0.2) didn't bring in the ct_slave module. Seems like there was some discussion about it here: https://github.com/supabase/supavisor/pull/31/files#r1145024804
To keep this issue smaller, I replaced the ct_slave call with the peer one, expecting to get failed test. And that "works", the tests run.
Hope this helps! Again, thanks for your work! :heart:
edit: I realize that the commit message and some of the wording above may incorrectly categorize this issue as a "test" db issue, but in fact, it's any db that it runs in. I approached this problem from "Cool project, let me run the tests" starting point. Please feel free to change the commit wording, the code, anything you'd like and also, if you don't use this, no problem at all. :heart:

@abc3 can we merge this one or do you have any additional concerns?

Sorry, I haven't had a chance to check yet. I will take a look soon


[February 7 2024] Adding Valentin Delaye's spotlight

This PR is to add the next contributor spotlight to the queue for review & publication. The next spotlight will be for @jonesbusy and is intended to be published on February 7th.
This would resume the normal Wednesday publication, and keep the 2 week period that we are currently using.

Thanks you, I will check this in the next few days.
Meanwhile the picture doesn't seem to be added on https://deploy-preview-77--contributor-spotlight.netlify.app/

Thanks for the heads up on that @jonesbusy ! I didn't realize the extension was incorrect, but just fixed it. I've uploaded the new version and it should appear/render properly this time. I'll keep an eye out and make sure of it though!

I would like to change my picture using this one

I did some test locally and this one fits much better.
Thank you!

Awesome, thanks very much @jonesbusy, I've updated the avatar image accordingly :)

Suggested crop for a centered avatar:

Thanks @lemeurherve, I also sent it through compressor.io to make sure it is also following other best practices.

Thanks so much for the review @MargoBGH!

Looks very good overall.
I just want to add 2 sentences about recent contributions
Thanks

LGTM!

@kmartens27
Thanks for the release!
I noticied it was published/shared on some social media like 'X' but not on LinkedId like other contributors.
Is it possible to also have a post on https://www.linkedin.com/company/jenkins-project/posts/?feedView=all ?
Thanks

@jonesbusy good catch, published at https://www.linkedin.com/feed/update/urn:li:activity:7161678637316993024/ cf https://matrix.to/#/!cRulYWcErlSqXzBIyw:gitter.im/$aPP8_SXAdrCoOlK__pL4HhKi_kcKqoSnYiTFEUsMFb4?via=gitter.im&via=matrix.org&via=g4v.dev

Thanks!


"POSTCSS: failed to transform" error on Hugo 0.100.2

Hello,
I'm using Hugo 0.100.2 and I'm getting the following error:

15:18:29.084	Executing user command: hugo
15:18:29.182	Start building sites …
15:18:29.182	hugo v0.100.2-d25cb2943fd94ecf781412aeff9682d5dc62e284+extended linux/amd64 BuildDate=2022-06-08T10:25:57Z VendorInfo=gohugoio
15:18:29.352	Error: Error building site: POSTCSS: failed to transform "css/eureka.css" (text/css): resource "css/css/eureka.css_59122205213644db2a335025f85b41bf" not found in file cache

I tried setting baseURL as:

baseURL: /

and as:

baseURL: https://XXXX.com

and as:

baseURL: https://XXXX.com/

But nothing worked.

Hi @verlanmar,
What is your eureka version? You can upgrade to Eureka 0.9.3 and this should be solved.

I can not reproduce this issue with Hugo 0.100.2 and Eureka 0.9.3. Do you want to share your repo so maybe we can have a look at it?

I tried now doing everything from scratch, and everything is fine now.
https://github.com/verlanmar/-hugo-eureka-test
Not sure why I could not make it work before.
Sorry for the trouble!

I got same issue after I upgrade hugo to v0.101.0 and eureka to v0.9.3. but there is no issue if create a new site.


Is it possible to have less layers?

Current, more than 10 layers are engaged, however 3 layers are very enough for most cases.
I hope JWM can be configured to has less layers, or has only 3 layers by default.

The only layers I can think of are for the Tray OR the windows
layer
The layer of the tray. The default is above. Valid values are below, normal, and above.

layer:layer 	The layer on which windows in this group will be started. Valid options are below, normal, and above.

Could you be more specific, as there are only 3 layers: below, normal and above

Currently, I bind the window menu to W-x, i.e.,
<Key mask="4" key="x">window</Key>

Everytime I press W-x, the window menu will popup as expected. The structure of the menu looks like this,
    [Send To]
        1
        2
    [Layer]
        Bottom
        1
        2
        3
        Normal
        5
        6
        7
        8
        9
        10
        11
        Top
    Stick
    Maximize
    .
    .
    .

There seems to be 13 layers.
I hope it has been fixed since you claim that there are only 3 layers. My JWM version is 2.1.0:
    ~> jwm -v
    JWM vsvn-579 by Joe Wingbermuehle

Hi,
You should really run a newer version of JWM.  There are a LOT of improvements since 2.1.0
But indeed for me it looks like
[Layer]
  Below
  [Normal]
  Above

Yes, great idea! Thank you again for helps.


splitting the run methods of algorithms

Not sure I am overseeing something, but the run methods in the algorithms only return the predicted samples - nothing else.
It might be worthwhile to consider refactoring this, so that each python module in the algorithms directory offers to return the obtained posterior. This would entail in pseudo code:
def train(...):
	return trained_objects

def infer(...)
	return predicted_objects

def run(...):
	trained_objects = train(...)
	predicted_objects = infer(trained_objects, ...)
	return predicted_objects

This refactoring should/would not change the API which is used downstream. It would however allow more analyses on the obtained posterior (mean/median map estimation versus SGD based map estimation etc).

Thanks for the suggestion, Peter!
I agree that for additional analyses, it might be useful to be able to access the "trained object" (currently, depending on the algorithm, there is one trained object, or none, e.g., for some ABC methods). run does return not only predictive samples, but also the number of simulations that were actually performed (simulator.num_simulations; as a safety-check), and, if the algorithm supports it, the log probability of true parameters as an optional third return.
If you are up for it, I'd be glad to accept a PR that refactors the functions along the lines you propose and continue discussing there :)


Polyfills for fetch/Promise, ES6 transpilation?

I'm only targeting the latest version of Firefox so far (since that's what I dev with), but will other devs need support in the browsers that don't:

have fetch
do ES6 natively

These browsers include IE11 (no fetch & Promise support, no ES6 support), Safari 10 (no fetch & Promise support), and most mobile browsers.
For fetch, I can add polyfills, and for ES6 I can use Babel more (although I really don't want to and would rather ship native ES6).

ES6 support is really good with the latest batch of browsers (https://kangax.github.io/compat-table/es6/) that all I really need is to transpile the module import/export definitions.  Everything else runs natively.


Toogle Message Panel

SQL Operations Studio Version: sqlops 0.26.7 (723c7cb3bfd80d87fc8a1141632089cd4808495c, 2018-02-16T21:34:47.034Z)
OS Version: Windows_NT x64 10.0.16299
Extensions: none

Steps to Reproduce:

Execute SQL Query
No close options to message panel

The Toggle Query Results command should hide the results and messages pane.  Setting "sql.messagesDefaultOpen": false in the User Settings will make the Messages collapsed by default.  Please reactive if these options don't meet your ask.  Thanks!


smooth dragging

I did not see any improvments. Thanks fir attempt, but this is useless.

Why not run in studio and try dragging

I try it. Compile it, but this is nothing. There are no new drag smooth mechanics, just some click intercept.

All right. Sorry for help nothing


The current version lacks all Plutus V2 support

If i try to import for example :
import qualified Plutus.Script.Utils.V2.Typed.Scripts as PSU.V2
I end up with
    Could not find module ‘Plutus.Script.Utils.V2.Typed.Scripts’
    Perhaps you meant
      Plutus.Script.Utils.V1.Typed.Scripts (from plutus-script-utils-<IP_ADDRESS>)
      Plutus.Script.Utils.V1.Scripts (from plutus-script-utils-<IP_ADDRESS>)
      Plutus.Script.Utils.V1.Typed.TypeUtils (from plutus-script-utils-<IP_ADDRESS>)
    Use -v (or `:set -v` in ghci) to see a list of the files searched for.

Also we're not able to use the Contact Monad latest version to use inline datums or references

I try to fix this, here:
https://github.com/aleeusgr/plutus-tests/pull/3

https://github.com/aleeusgr/plutus-tests/pull/4

hi @cmorgado
I followed the path you suggested, bumped dependencies for this repo.
I have doubts about sending a PR to the repo tho: bumping dependencies is a recurring task and plutus-starter is the perfect place to learn.
I am not sure it will do any good to hold the hand of anyone who comes after me: if it works out of the box, the user will still have to bump dependencies at some point, but likely in a situation with deadline and stakeholders involved.
there is a nice guide on how to update dependencies in the repo:
https://github.com/input-output-hk/plutus-starter/blob/main/CONTRIBUTING.md
Maybe name is not suggestive, or maybe it needs more visible, but I am not convinced I need to go through additional debuggin guessing game contract to make tests pass while I think it goes against the educational value of this repo.

Hi @aleeusgr thank you for your effort and guidance!

I found an issue such that newer versions of plutus-apps depend on CHaP, and for it the manual suggests to use a flake.nix, however this feature has not been added to plutus-starter

I found an issue such that newer versions of plutus-apps depend on CHaP, and for it the manual suggests to use a flake.nix, however this feature has not been added to plutus-starter

I'm right there right now.  Learning how to convert a repo to flakes by fire!

Oh man, thank you so much.
I cant work and this makes me feel worse.
Knowing someone cares makes me feel better.
thank you


chore: add integrity attribute to external links

Another try at #2215 but with infrastructure changes to the CDN for dev-blue and dev-green enabled. Let's test it!

replaced by #2236


6809 decompiler: overlapping input varnodes with LSLA/B output for indexed JMP

Describe the bug
Decompiling the function shown in the screenshot results in Low-level Error: Overlapping input varnodes. Changing the LSLA instruction to INCA fixes decompilation, as well as changing 6x09.sinc to
macro logicalShiftLeft(op)
{
        $(C) = op >> 7;
---      op = op << 1;
+++      op = op + 1;
        $(Z) = (op == 0);
        $(N) = (op >> 7);
}

Shouldn't $(V) also be set?

Not sure what causes the original issue, but as I see it, $(V) should definitely be set to the exclusive or of the original bits 6 and 7 of the operand. This is also wrong in the rotateLeftWithCarry macro which affects ROLA, ROLB and ROL. The correct versions might look like this (if ^ is the correct XOR operator):
macro rotateLeftWithCarry(op)
{
        local carryIn = $(C);
        local tmp = (op >> 7);
        $(C) = tmp;
        op = (op << 1) | carryIn;
        $(V) = tmp ^ (op >> 7);
        $(Z) = (op == 0);
        $(N) = (op >> 7);
}

macro logicalShiftLeft(op)
{
        local tmp = (op >> 7);
        $(C) = tmp;
        op = op << 1;
        $(V) = tmp ^ (op >> 7);
        $(Z) = (op == 0);
        $(N) = (op >> 7);
}

Isn't N also implemented incorrectly there too?  It's setting N to the high bit (1->1 0->0) but should be setting if clear (0->1 1->0)
$(N) = (op >> 7) == 0

This is generally a bug in decompiler because it doesn't check and reject input varnodes which cause error. It doesn't have to do with instructions or something, it just makes unsafe assumptions or like.

Isn't N also implemented incorrectly there too? It's setting N to the high bit (1->1 0->0) but should be setting if clear (0->1 1->0)
$(N) = (op >> 7) == 0

That sounds correct. Seems like there is an error in the programming reference manual I used (see here on page 96) vs. the original reference here on page  A-46.

@Danil6969 : Thank you for the analysis starting point. Since the error message itself is not very informative at all, I tried to hack setInputVarnode to sneak some more info in there. For most of the occurrences, I got something like this (in the first line the varnode and input varnode are extended with the address and the size, the lines below are the output of the printInfo method of the varnodes):
  Low-level Error: Overlapping input varnodes vn: 0x00, 1 invn: 0x00, 2
  vn:
   undefined = A(free) (consumed=0xffffffffffffffff) (internal=000000000066B8F0) (create=0x454)
  invn:
   undefined2 = D(i) (consumed=0xffff) (internal=0000000000697760) (create=0x2ad)

  Low-level Error: Overlapping input varnodes vn: 0x00, 1 invn: 0x00, 2
  vn:
   undefined = A(free) (consumed=0xffffffffffffffff) (internal=000000000066CDC0) (create=0x2cb)
  invn:
   undefined2 = D(i) (consumed=0xff00) (internal=000000000066BCE0) (create=0x262)

  Low-level Error: Overlapping input varnodes vn: 0x00, 1 invn: 0x00, 2
  vn:
   undefined = A(free) (consumed=0xffffffffffffffff) (internal=00000000005EE020) (create=0x154a)
  invn:
   short = D(i) (consumed=0xffff) (internal=0000000000699B60) (create=0xef5)

So far as I understand it, it is trying to create a varnode of size 1 at an address, where a varnode with size 2 already exists. If the identifiers A and D stand for the respective 6809 registers, the overlap would at least sound plausible, though the reason remains unclear. It the moment, I can not make much sense of the remaining information.

are you testing this with the fix for Push2/Pull2?

Yes, and with my recent fixes to rotateLeftWithCarry, logicalShiftLeft, subtraction, compare, LEAX, LEAY and ADDB.

Hey @Pinoerkel could you share a branch with printInfo debug logs? I've build Ghidra master now and would like to investigate this issue further.

Hey @Pinoerkel could you share a branch with printInfo debug logs? I've build Ghidra master now and would like to investigate this issue further.

Hey @Pinoerkel could you share a branch with printInfo debug logs? I've build Ghidra master now and would like to investigate this issue further.

I am not completely sure what you want me to do, but I think the key to understanding the issue is having several as small as possible code examples that produce the error and then squeezing as much information out of ghidra at the position where the error is detectable. Then one should probably determine what Ghidra should do in several specific error situations and see if there is a rule or heuristic that can be derived from that to resolve the issue.
To produce the output I posted above, i patched Ghidra\Features\Decompiler\src\decompile\cpp\funcdata_varnode.cc at line 358, where the overlapping input varnodes error is produced, replacing
		throw LowlevelError("Overlapping input varnodes");

with
		ostringstream s;
		s << "Overlapping input varnodes";
		s << " vn: ";
		vn->getAddr().printRaw(s);
		s << ", " << vn->getSize();
		s << " invn: ";
		invn->getAddr().printRaw(s);
		s << ", " << invn->getSize();
		s << "\nvn:\n ";
		vn->printInfo(s);
		s << "\ninvn:\n ";
		invn->printInfo(s);
		throw LowlevelError(s.str());

to produce an error string with more information about the respective varnodes.
Unfortunately I was not able to find someone who could explain the general varnode issue to me by means of a specific minimal example. At the moment, I have the theory(but I may be completely wrong with this) that it might be something like:

A function with parameters gets called from multiple other pieces of code.
Using each piece of code and looking at what stack data is used inside the function, the Ghidra decompiler tries to estimate, which parameters the function has.
Now, if on one function call this estimation leads to differently sized parameters or a different amount of parameters(e.g. because one parameters is not used inside the function during one call) than on another function call to the same function, the Ghidra decompiler does not know how to handle differently sized input parameters estimated to be at the same location.
Theoretically, it should be possible to reconstruct the original set function parameters by looking at the code and find a solution that works for all instances the function is called.
Unfortunately, I am quite new to Ghidra and thus, the theory outlined above may be completely wrong.

Thanks a lot for your answer and ideas!  I'll try to dig into it more next weekend.
As a first try I've just commented out the exception and the decompilation result looks reasonable on first sight :)

ok the issue when turning off the exception is that things that should be stored in D are stored in B

In my case, it seemed to be mostly conflicts between A and D. The architecture of the 6809 with the overlapping A, B and D registers could make it especially hard or even impossible for the compiler to decide how some stack variables should be handled. E.g. the ROM code could compute the upper and lower byte separately in A and B, push them onto the stack and use them via the D register in the function. In another call of the same function the data for the D register in the function could have been explicitly computed in the D register, confusing the decompiler. Maybe there is a heuristic that can handle all those cases. Until now, I even failed to clearly understand these conflicts in my ROM code and see if I would be able to determine the "correct" solution manually. If I could, then the solution for errors like this, might be as easy as looking at the code, understanding what the function parameters should look like and manually editing the stack frame of the function accordingly.


Core.cross domain lib

New sample that shows how you can use javascript on a SharePoint page to call serverside MVC methods of a provider hosted app (in another domain). To make this work, I wrote a small cross domain library. The serverside code can create clientcontext in the same way a normal provider hosted app would do. (user and app permissions). It is also possible to show html rendered by the razor views on a SharePoint page.

Thanks Stijn. Before we can process this sample you'll need to get the CLA signed (https://cla.microsoft.com).

@stijnneirinckx, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;

Excellent work stijn! Another way to beat iframes :)


Are there challenges to merge the OpenAPI.next branch into the Master branch

Known issues:

[ ] Prepare ReadMe.md for merge (@usarid, week of 7/10 - 7/14)
[ ] Other issues as identified
[ ] Merge OpenAPI.next branch into Master branch (@webron, week of 7/17 - 7/21)
[ ] Publish release (@webron, week of 7/17 - 7/21)
(@DarrelMiller prefers Thu, 7/20)

Also watch for announcements / calls for help in the #spec channel on Slack
Planned time off:
7/24 - 7/28: @darrelmiller and @RobDolinMS

Happy to help on the Travis side. Some files cleaned up in the OpenAPI.next branch will get removed by a simple git merge - though if 2.0 is frozen this may no longer be a consideration.


Update config-build and uberenv for MSVC 2022

Summary

This PR is a feature
It updates vcpkg to 2022.05.10 release
It updates config-build.py to use MSVC 2022

Note: A sidre data collection test was failing in develop. This appears to be related to #820.

Thanks!

Here's a "manual Windows TPL" CI test showing the failing sidre_mfem_datacollection test:
https://github.com/LLNL/axom/actions/runs/2472312978


Site Constants

Hi,
First of all I want to say fantastic work, this library made my life so much easier.
My query was about the constants for siteId when setting up the TradingServices.
DTS\eBaySDK\Constants\SiteIds contains 'GB' for the United Kingdon
but when yo make a GetUserRequest to ebay its ruturns 'UK' as the site
Also according to the docs, it should be UK?
https://developer.ebay.com/devzone/xml/docs/reference/ebay/types/SiteCodeType.html
Thanks

GetUserRequest does return UK but this value has nothing to do with the site id constant name.  The constants could have been called anything, E.g SITE_UK or UK_SITE. The constants are just a means to specificity a site or global id in your code.


HDDS-7428. Calculate number of blocks to allocate on SCM

What changes were proposed in this pull request?
Currently, AllocateBlock takes two major arguments: size and num. There are some problems in the current API:

For EC replication type, the allocated size for clients to write is size * ec.numData * num, which is not a good abstraction from the HDDS client's view.
It assumes all blocks are in same size. However, sometimes it's useful to let SCM allocate arbitrary size the client wants (e.g. when client know the key size in advance).

In this Jira, I wish to add a requestedSize field in the AllocateBlock RPC.
SCM will calculate how many blocks to allocate based on requestedSize,
and return size of each block allocated to client.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7428
How was this patch tested?
TODO

Hi @JacksonYao287, this PR implements the idea of better AllocateBlock abstraction https://github.com/apache/ozone/pull/3882#pullrequestreview-1157514505.
It's still work in progress though (need to add tests and handle compatibility),
can you help review the API design first?

Converted to draft to address compatibility issues.


Allow the tel regex to be overridden.

Replaces: https://github.com/filamentphp/filament/pull/4515

Thanks!


added new post

#36  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @leonchike and the rest of your teammates on  Graphite


Expression browser metric autocomplete misses certain search terms

Metric name fragments that are not a metric prefix (but contained somewhere in a metric name) and contain an underscore are not shown by the fuzzy-matching autocompleter in the expression browser.
For example, enter disk on http://demo.robustperception.io:9090/ to see that there are metrics node_disk_bytes_read, etc. Then enter disk_ to see that all those suggestions disappear.
This is likely related to https://github.com/prometheus/prometheus/commit/50f8e35c54b7c4035f3267e9b106f4523d4a18bf. /cc @lightpriest

Yes, it's probably because of this change. The fuzzy matching breaks words by space. To perform the lookup, I remove the underscore from the metric name before looking up, and add it back after.
I wonder what will be the solution here. What would you expect the behavior to be? It might be treated as a space, or it might be treated as an underscore.
If treated as a space, then typing an underscore is meaningless, but the user was actually trying to do something - reduce the suggested options?
If treated as an underscore, maybe the code should fallback to the regular string matching? This will reduce the suggestion list, but in some cases might generate a different set of results.

@lightpriest Hmm, not sure yet! Do you know why it does work if the search term is a metric prefix (like node_boot -> node_boot_time), but not if it's in the middle somewhere (boot_time)?

@juliusv #2396 includes a fix for this issue. It also includes a change the library itself to provide better results.
I tried replacing the fuzzy search lib with atom's one (https://github.com/atom/fuzzaldrin), but it's targeted at path subjects, giving higher scores to the last path element, treats slash specially, etc.


Add Two-Role access system

The access user system should support two roles: Admin and normal.
An Admin user should have additional features available to them on the Website. Maybe a "Manage Inventory" option that would allow them to delete donation items?

Finished admin features with a manage inventory page that has edit and delete donation features


Edited bookmark doesn't edit the activity

I edited this bookmark: https://tomcasavant.glitch.me/bookmark/19 to correct "twee" to "tweet" and that doesn't seem to have been edited in the actual activity. I assume ActivityPub has some sort of 'edit' endpoint that needs to be hit or something?

Thanks for reporting-- this was working at some point (this switch case should handle it) but this code got heavily refactored a couple times in August/September, so probably without tests available something got broken.

https://github.com/ckolderup/postmarks/blob/0522da2c250ad139c67a5dbc42c1a084d8f01a1b/src/activitypub.js#L90
Looks like there were problems w/ the update activity at some point and it was switched to create

oof, I wish I had documented more thoroughly what I was seeing there, because that seems like a mistake.
I'm not an expert on the Mastodon codebase but it appears that edits get broadcast as "Update" objects with a special array for the id and the to and cc set to the original post id, which is interesting:
https://github.com/mastodon/mastodon/blob/c86ad4566003f15f2f4f2499efd36f20b62737ab/app/workers/activitypub/status_update_distribution_worker.rb#L18-L28

That line has been in there for 9 months though so if it was working before I doubt that's what broke it, I'm not sure how mastodon interprets a 'create' notice on an object that already exists

Yeah, I mean I'm just working from memory at this point since that was a stage of the project where I was working on it entirely on my own and doing extremely slipshod manual QA. I can take a stab at reproducing doing things "the Mastodon way" and see if that gets interop fixed for now.
(Also once we can confirm it works, getting tests set up for some degree of reproducibility, which is actually on my todo list to scaffold this evening, as I finally have a free night at home)

https://community.nodebb.org/post/101114

It turns out that just sending the Update(Note) activity was not enough, the underlying object needed to also have the updated field set in order to Mastodon to process the update. My guess is Mastodon checks that field and only processes the note if the value is greater than the last known value.

I think this might be the issue (I haven't had the opportunity to test it yet)

It works!

Probably needs a lot of cleanup and I'm not sure when I'll get the time to fully test it so here's what I have working if anyone wants to beat me to it
async function createUpdateMessage(bookmark, account, domain, db) {
  const guid = await db.getGuidForBookmarkId(bookmark.id);
  const guidCreate = crypto.randomBytes(16).toString('hex');
  let note;
  const updatedBookmark = bookmark;

  console.log(bookmark.description)
  updatedBookmark.title = escapeHTML(bookmark.title);
  updatedBookmark.description = bookmark.description;
  console.log(updatedBookmark.description)

  let linkedTags = '';

  if (bookmark.tags && bookmark.tags.length > 0) {
    linkedTags = bookmark.tags
      ?.split(' ')
      .map((tag) => {
        const tagName = tag.slice(1);
        return `<a href="https://${domain}/tagged/${tagName}" class="mention hashtag" rel="tag nofollow noopener noreferrer">${tag}</a>`;
      })
      .join(' ');
  }

  if (updatedBookmark.description?.trim().length > 0) {
    updatedBookmark.description = `<br/>${updatedBookmark.description?.trim().replace('\n', '<br/>') || ''}`;
  }

  if (linkedTags.trim().length > 0) {
    linkedTags = `<p>${linkedTags}</p>`;
  }

  if (guid === undefined) {
    // If the bookmark was created but not published to ActivityPub, create a new note
    note = createNoteObject(bookmark, account, domain);
    await createMessage(note, bookmark.id, account, domain, db);
  } else {
    // Fetch the existing note object
    const existingMessage = await db.getMessage(guid);
    const existingNote = existingMessage ? JSON.parse(existingMessage.message) : null;

    const publishedDate = existingNote.published;

    //console.log(existingNote);
    note = {
      id: `https://${domain}/m/${guid}`,
      type: 'Note',
      attributedTo: `https://${domain}/u/${account}`,
      content: `
${replaceEmptyText(
      updatedBookmark.title,
      updatedBookmark.url,
    )}${updatedBookmark.description}
`,
      published: publishedDate, // Keep the original published date
      updated: new Date().toISOString(), // Set the updated date to now
      to: [`https://${domain}/u/${account}/followers/`, 'https://www.w3.org/ns/activitystreams#Public'],
      tag: []

    };

    bookmark.tags?.split(' ').forEach((tag) => {
      const tagName = tag.slice(1);
      note.tag.push({
        type: 'Hashtag',
        href: `https://${domain}/tagged/${tagName}`,
        name: tag,
      });
    });

    // Update the note in the database
    await db.updateNoteByGuid(guid, note);
  }

  const updateMessage = {
    '@context': ['https://www.w3.org/ns/activitystreams', 'https://w3id.org/security/v1'],
    summary: `${account} updated the bookmark`,
    id: `https://${domain}/m/${guidCreate}`,
    type: 'Update',
    actor: `https://${domain}/u/${account}`,
    object: note.id ? note : `https://${domain}/m/${guid}`,
  };
  console.log(updateMessage);

  //print(err);
  return updateMessage;
}


Continuous crash after clicking Preview Premix - Apple M1 chip

Hello,
I'm not able to perform a mix because after clicking "Preview Premix" Sparrow crashes (the apple rainbow crash appears).
I tried many times, but I always obtain a crash.
I think there is a bug to fix.
Let me know if I can do something.
Thank you.
Dongwe1

Can you provide more details on the nature of the crash? For example are there any logs or crash report available?
Can you provide details on the system you are running on? Have you tried running Sparrow after a reboot without other apps running?

I run macOS Monterey 12.4 - Apple M1 iMac.
My node (Umbrel) is connected to Sparrow.
I tried to run Sparrow after a reboot and after have closed other apps, I also closed VPN.
Same result: apple rainbow crash appears every time (then I have to force close Sparrow).
I attach a screenshot.
I don't see a Sparrow crash report.
I see the Apple problem report that is very very long. Let me know if I you need it. Let me know if I can do something.
Thank you.

I notice that in the screenshot the apple rainbow crash doesn't appear.

Yes, I need the Apple crash report. I actually don’t know what you mean by “apple rainbow crash”. Are you talking about the spinning beach ball, or something else?

Yes, sorry for my ignorance, I mean the spinning beach ball.
I attach here the Apple crash report. I saved it in word docx, if you need another format please let me know.
Thank you.
Sparrow_crashreport.docx

Thanks for the report, marking as a duplicate of #586.


[Card - logo] Card variation dedicated to logo / app icons

Problem
We might need a Card variation dedicated to logo / ~pictogram /~ app icons. We have pictogram cards at the moment, but they are not most suited for logo.
Task

Audit, collect, and create designs for cards with logo / pictogram / app icons

Additional information
For reference, here is a designs from Jen Witkowski from Hybrid Cloud team referencing our default card. It drops the card heading, but creates a lighter design.

Design and functional spec Box folder

Convert to an epic, design exploration

issues needed:  consulting dev for WC, React wrapper, QA issues, website

Work completed!


Fixed spellingmistakes in Strings.de.resx

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


MSEdge inspector missing in docked debug toolbar

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.57.0
OS Version: Windows

MSEdge inspector missing in {"debug.toolBarLocation": "docked"} mode

Dup of https://github.com/microsoft/vscode/issues/115945


Can't install pytorch==0.4.0

Can't install pytorch==0.4.0, the oldest that I can find from https://pytorch.org/get-started/previous-versions/ is 0.4.1
Collecting torch==0.4.0 (from -r requirements.txt (line 1))
ERROR: Could not find a version that satisfies the requirement torch==0.4.0 (from -r requirements.txt (line 1)) (from versions: 0.1.2, 0.1.2.post1)
ERROR: No matching distribution found for torch==0.4.0 (from -r requirements.txt (line 1))

What OS and CUDA version?

You can run with pytorch==0.4.1. I tested it. But you need change all AT_ASSERT to AT_CHECK to install neural renderer


The implementation can be found in keras_text_summarization/library/seq2seq.py

Dead link
https://github.com/chen0040/keras-text-summarization/blob/master/keras-text-summarization/blob/master/keras_text_summarization/library/seq2seq.py

Hi @Mandrewoid thanks for the notification, i have rectified the problem, pls let me know if you came across such a problem again

Thanks for the good attitude :)


SwitchLinc brightness state reported as 1 regardless of actual state

Home Assistant release with the issue:
.89.2
Last working Home Assistant release (if known):
Operating environment (Hass.io/Docker/Windows/etc.):
Linux Ubuntu 18.04
Component/platform:
insteon
Description of problem:
When using insteon plm with insteon switchlinc dimmer, when the dimmer is turned on, the entity brightness is reported as 1, regardless of what the dimmer actually brightened up to.

I am pushing a fix for the next release.


Clean barbuk theme

Description
Add barbuk theme to clean_files.txt.
shfmt lint only.

@BarbUk Looks like you figured out the bug I ran into; shfmt must be run a few times to catch all the whitespace issues.

Yes.
What's strange is that pre-commit is telling me that everything is fine, but running shfmt change the file.
For example, from the current master:
~/.dotfiles/modules/bash-it on  master ⤏  origin •1 ✗ ❯ git diff
──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
modified: clean_files.txt
──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
@ clean_files.txt:30 @ lint_clean_files.sh
#
themes/90210
themes/powerline
themes/barbuk

# plugins
#

   ~/.dotfiles/modules/bash-it on  master ⤏  origin •1 ✗ ❯ pre-commit run --files `cat clean_files.txt`
Trim Trailing Whitespace....................................................Passed
Fix End of Files............................................................Passed
Check for merge conflicts...................................................Passed
Mixed line ending...........................................................Passed
Check for added large files.................................................Passed
Check for conflict markers and core.whitespace errors.......................Passed
Test shell scripts with shellcheck..........................................Passed
Check shell style with shfmt................................................Passed
CRLF end-lines remover......................................................Passed

   ~/.dotfiles/modules/bash-it on  master ⤏  origin •1 ✗  1.1s ❯ shfmt -w themes/barbuk/barbuk.theme.bash

   ~/.dotfiles/modules/bash-it on  master ⤏  origin •2 ✗  2.0s ❯ git status
On branch master
Your branch is up to date with 'origin/master'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   clean_files.txt
	modified:   themes/barbuk/barbuk.theme.bash

no changes added to commit (use "git add" and/or "git commit -a")

@BarbUk Looks like you figured out the bug I ran into; shfmt must be run a few times to catch all the whitespace issues.

Yes.
What's strange is that pre-commit is telling me that everything is fine, but running shfmt change the file.
For example, from the current master:
~/.dotfiles/modules/bash-it on  master ⤏  origin •1 ✗ ❯ git diff
──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
modified: clean_files.txt
──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
@ clean_files.txt:30 @ lint_clean_files.sh
#
themes/90210
themes/powerline
themes/barbuk

# plugins
#

   ~/.dotfiles/modules/bash-it on  master ⤏  origin •1 ✗ ❯ pre-commit run --files `cat clean_files.txt`
Trim Trailing Whitespace....................................................Passed
Fix End of Files............................................................Passed
Check for merge conflicts...................................................Passed
Mixed line ending...........................................................Passed
Check for added large files.................................................Passed
Check for conflict markers and core.whitespace errors.......................Passed
Test shell scripts with shellcheck..........................................Passed
Check shell style with shfmt................................................Passed
CRLF end-lines remover......................................................Passed

   ~/.dotfiles/modules/bash-it on  master ⤏  origin •1 ✗  1.1s ❯ shfmt -w themes/barbuk/barbuk.theme.bash

   ~/.dotfiles/modules/bash-it on  master ⤏  origin •2 ✗  2.0s ❯ git status
On branch master
Your branch is up to date with 'origin/master'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   clean_files.txt
	modified:   themes/barbuk/barbuk.theme.bash

no changes added to commit (use "git add" and/or "git commit -a")

HI All -  This is a drive-by comment, I have not deeply reviewed the situation, but I noticed:
❯ pre-commit run --files `cat clean_files.txt`

This is likely not going to do what you think it will ... I don't believe that pre-commit will traverse directories given in the clean_files.txt file.
That's whylint_clean_files.sh actually has logic to traverse the directories and build a file-only list which is passed to pre-commit.
Try running ./lint_clean_files.sh instead of invoking pre-commit directly.

HI All -  This is a drive-by comment, I have not deeply reviewed the situation, but I noticed:
❯ pre-commit run --files `cat clean_files.txt`

This is likely not going to do what you think it will ... I don't believe that pre-commit will traverse directories given in the clean_files.txt file.
That's whylint_clean_files.sh actually has logic to traverse the directories and build a file-only list which is passed to pre-commit.
Try running ./lint_clean_files.sh instead of invoking pre-commit directly.

Well done @BarbUk, and thanks for the review @cornfeedhobo @davidpfarrell !

Well done @BarbUk, and thanks for the review @cornfeedhobo @davidpfarrell !

Try running ./lint_clean_files.sh instead of invoking pre-commit directly.

This is the correct solution, thanks.

Try running ./lint_clean_files.sh instead of invoking pre-commit directly.

This is the correct solution, thanks.


Received packets send by SendLargeArray contains invalid data/bytes

There is some problem with read bytes from message. Some bytes are replaced by other or even removed.
Example:

Send from client client.SendLargeArray(buffer, false, false) where buffer contains 40 bytes.
Receive packet on server with OnDataReceive. Resulting packet will contains only 36 bytes. I.e. 4 bytes was consumed somewhere in chain leading to corrupted data on the end.

Another example:

Send from client client.SendLargeArray(buffer, false, true) where buffer contains 40 bytes.
Receive packet on server with OnDataReceive. Resulting packet will contains 40 bytes, but last two bytes were removed and two bytes [00, 00] were inserted at begning. Again - leading to corrupted data.

In addition to all above. Using SendLargeArray results in instant disconnect from server after sending message.

The standard protocol used by EasyTcp (PrefixLenghtProtocol) stores the length of the message in the first 4 bytes.
Then when data is normally received, the first 4 bytes are used to determine the message length.
I assume that SendLargeArray is used to send an array and is received outside a receive event.
This would let the standard protocol handle the message, which results in the first 4 bytes being removed (or the connection being dropped because of an invalid header)
The solution to this problem would be sending a small message (probably with some additional information) and then in the receive event would call the ReceiveLargeArray() function.
This would fix the problem because the standard protocol (PrefixLenght) isn't running for that connection inside the onReceive event.
See this example:
https://github.com/Job79/EasyTcp/blob/master/EasyTcp3/EasyTcp3.Examples/LargeArray/LargeArrayExample.cs
Note that when not using EasyTcp.Actions the ReceiveLargeArray function would be called inside the OnReceive event instead of the action function.

I am guessing the above comment was helpful, feel free to reopen this issue when this is not the case.


Fixes to visual c++ for #492

Some changes were made for MinGW, also marked those changes to apply to Visual C++

@Andne thanks again, Andy.
I was thinking of doing this myself, but don't currently have access to Visual Studio. Actually, there are two more function pointer interfaces that need adding to Visual C++ as well... sorry about that.

@arstrube  No problem.
I noticed some linker errors until I fixed made the changes to UtestPlatformTest.cpp, they involved a fork and a wait platform-specific function.  I left them out since once I disabled the fork tests there weren't any errors, so I figured that they could be left until someone figures out how to make them work in the first place.
Also, I added a commit to add several missing files to AllTest.vcxproj.  My code tree has a different project file structure, so I didn't notice them at first.

You are right -- these functions are new and actually not needed for Visual C++

Vow, some of these other files have been missing in the project for a long time.


MATLAB Crashes when trying to run "svmtrain" on CentOS

I'm trying to run some feature selection and classification models using libsvm-3.17 on my university's supercomputer. I haven't had issues in the past running these functions and libsvm-3.17 has been properly made on my system. But recently, the code will start running and then crash once it tries to use "svmtrain". It generates the attached segment violation and crash dump. I've tried re-compiling libsvm, running on a different cluster, increasing memory, but I still get this report. I reached out to MATLAB support and based on what they read in the crash report, there may be a bug in the C/C++ code. I've attached the error report here.
Is this a known issue with CentOS or Rocky8?
matlab_error_report.txt

We need more information. Can you give us your whole code?

I'm sorry, this was user error. It works fine.


🐛 [Immich] Immich can't use NAS server, it can only access it in read mode

Description
I have this configuration on home assistant but the plugin
DB_DATABASE_NAME: immich
DB_HOSTNAME: homeassistant.local
DB_PASSWORD: ****
DB_PORT: "5432"
DB_USERNAME: homeassistant
DISABLE_MACHINE_LEARNING: true
JWT_SECRET: ****
PGID: 0
PUID: 0
TZ: Europe/Paris
data_location: /mnt/HomeAssistantShare/immich
networkdisks: //<IP_ADDRESS>/FRITZ.NAS/TOSHIBA_EXT/HomeAssistantShare
cifspassword: ****
cifsusername: ****
Reproduction steps
1. Go the web or mobile immich console
2. upload a photo
3. Photo is uploaded but no thumb is generated

Addon Logs
[Nest] 1193  - 03/01/2024, 6:00:04 PM   ERROR [JobService] Unable to run job handler (thumbnailGeneration/generate-jpeg-thumbnail): Error: Input file contains unsupported image format
[Nest] 1193  - 03/01/2024, 6:00:04 PM   ERROR [JobService] Error: Input file contains unsupported image format
    at Sharp.toFile (/app/immich/server/node_modules/sharp/lib/output.js:89:19)
    at MediaRepository.resize (/app/immich/server/dist/infra/repositories/media.repository.js:39:14)
    at MediaService.generateThumbnail (/app/immich/server/dist/domain/media/media.service.js:129:44)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async MediaService.handleGenerateJpegThumbnail (/app/immich/server/dist/domain/media/media.service.js:116:28)
    at async /app/immich/server/dist/domain/job/job.service.js:137:37
    at async Worker.processJob (/app/immich/server/node_modules/bullmq/dist/cjs/classes/worker.js:394:28)
    at async Worker.retryIfFailed (/app/immich/server/node_modules/bullmq/dist/cjs/classes/worker.js:581:24)
[Nest] 1193  - 03/01/2024, 6:00:04 PM   ERROR [JobService] Object:
{
  "id": "fc808f3f-fda9-4279-a7da-30ee8a8e4838",
  "source": "upload"
}

When trying to open the photos or download them I also have those log errors and photos are not displayed and download file is corrupted:
[Nest] 1137  - 03/01/2024, 6:00:07 PM     LOG [CommunicationRepository] Websocket Disconnect: Qjqu4yrBN_dNFmDdAAAD
[Nest] 1137  - 03/01/2024, 6:00:08 PM     LOG [CommunicationRepository] Websocket Connect:    -MAWu-C-EFu7ZNa1AAAF
[Nest] 1137  - 03/01/2024, 6:03:38 PM   ERROR [Error: Unknown system error -116: Unknown system error -116, open '/mnt/HomeAssistantShare/immich/library/admin/2020/2020-09-04/Portrait_6.jpg'] Failed to download file
[Nest] 1137  - 03/01/2024, 6:03:38 PM   ERROR [Error: Unknown system error -116: Unknown system error -116, open '/mnt/HomeAssistantShare/immich/library/admin/2020/2020-09-04/Portrait_6.jpg'] Error: Unknown system error -116: Unknown system error -116, open '/mnt/HomeAssistantShare/immich/library/admin/2020/2020-09-04/Portrait_6.jpg'
[Nest] 1137  - 03/01/2024, 6:03:38 PM    WARN [ExpressAdapter] Content-Type doesn't match Reply body, you might need a custom ExceptionFilter for non-JSON responses
[Nest] 1137  - 03/01/2024, 6:05:04 PM     LOG [CommunicationRepository] Websocket Connect:    RaQ56Tp2n-B0UGuIAAAH
[Nest] 1137  - 03/01/2024, 6:05:17 PM     LOG [CommunicationRepository] Websocket Disconnect: RaQ56Tp2n-B0UGuIAAAH
[Nest] 1137  - 03/01/2024, 6:05:18 PM     LOG [CommunicationRepository] Websocket Connect:    qTmYezbW7jacyzjgAAAJ
[Nest] 1193  - 03/01/2024, 6:05:21 PM   ERROR [JobService] Unable to run job handler (thumbnailGeneration/generate-jpeg-thumbnail): Error: /mnt/HomeAssistantShare/immich/library/admin/2023/2023-12-03/amigos-snap_2023-12-03_13-45-30.png: unable to open for read
unix error: Stale file handle
/mnt/HomeAssistantShare/immich/library/admin/2023/2023-12-03/amigos-snap_2023-12-03_13-45-30.png: unable to open for read
unix error: Stale file handle
pngload: stream error
[Nest] 1193  - 03/01/2024, 6:05:21 PM   ERROR [JobService] Error: /mnt/HomeAssistantShare/immich/library/admin/2023/2023-12-03/amigos-snap_2023-12-03_13-45-30.png: unable to open for read
unix error: Stale file handle
/mnt/HomeAssistantShare/immich/library/admin/2023/2023-12-03/amigos-snap_2023-12-03_13-45-30.png: unable to open for read
unix error: Stale file handle
pngload: stream error
    at Sharp.toFile (/app/immich/server/node_modules/sharp/lib/output.js:89:19)
    at MediaRepository.resize (/app/immich/server/dist/infra/repositories/media.repository.js:39:14)
    at MediaService.generateThumbnail (/app/immich/server/dist/domain/media/media.service.js:129:44)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async MediaService.handleGenerateJpegThumbnail (/app/immich/server/dist/domain/media/media.service.js:116:28)
    at async /app/immich/server/dist/domain/job/job.service.js:137:37
    at async Worker.processJob (/app/immich/server/node_modules/bullmq/dist/cjs/classes/worker.js:394:28)
    at async Worker.retryIfFailed (/app/immich/server/node_modules/bullmq/dist/cjs/classes/worker.js:581:24)
[Nest] 1193  - 03/01/2024, 6:05:21 PM   ERROR [JobService] Object:
{
  "id": "bf0415ef-7cd6-448c-abe2-bc653c163bf6",
  "source": "upload"
}

Architecture
aarch64
OS
HAos

When checking from the NAS the photos are available and I can correctly view them

My first guess would be something like this:
https://askubuntu.com/questions/1265164/stale-file-handler-when-mounting-cifs-smb-network-drive-from-fritz-router
https://debianforum.de/forum/viewtopic.php?t=176154

From https://linux.die.net/man/8/mount.cifs

noserverino
Client generates inode numbers itself rather than using the actual ones from the server.

I've actually noticed that some times seem to work. But the other photos without the thumbnail  doesn't even open, even if the files is correctly stored on the HDD

Did you try the "noserverino" mount option?

From https://linux.die.net/man/8/mount.cifs

noserverino
Client generates inode numbers itself rather than using the actual ones from the server.

No, how can I try?

Obviously, it is added to the script already:
https://github.com/alexbelgium/hassio-addons/issues?q=noserverino
Someone else had a similar issue: https://github.com/alexbelgium/hassio-addons/issues/813
Try this:

Fortunately I could fix it by myself with a small hack: Just add ,noserverino as a suffix in the smb password field. This solution works, but is not elegant. I would recommend an own mountoption field in the advanced options, because I have no idea how to test reliably for server or client index nodes usage.

Hi,

Obviously, it is added to the script already: https://github.com/alexbelgium/hassio-addons/issues?q=noserverino
Someone else had a similar issue: #813
Try this:

Fortunately I could fix it by myself with a small hack: Just add ,noserverino as a suffix in the smb password field. This solution works, but is not elegant. I would recommend an own mountoption field in the advanced options, because I have no idea how to test reliably for server or client index nodes usage.

The trick is actually working now it's saving and generating thumb correctly, many thanks!
Should be a  separate option for the mounting options be added in future ?

Excellent! Glad I could help.
That's a question only @alexbelgium can answer.

This is the log when I upload a photo
[Nest] 1273  - 03/04/2024, 6:40:52 PM   ERROR [Error: Unknown system error -116: Unknown system error -116, open '/mnt/HomeAssistantShare/immich/thumbs/6d90c831-1eac-4b75-a275-69c6a6e004a4/09/ae/09aed2dc-160a-42b4-a30b-afaca948557c.webp'] Failed to get asset thumbnail
[Nest] 1273  - 03/04/2024, 6:40:52 PM   ERROR [Error: Unknown system error -116: Unknown system error -116, open '/mnt/HomeAssistantShare/immich/thumbs/6d90c831-1eac-4b75-a275-69c6a6e004a4/09/ae/09aed2dc-160a-42b4-a30b-afaca948557c.webp'] Error: Unknown system error -116: Unknown system error -116, open '/mnt/HomeAssistantShare/immich/thumbs/6d90c831-1eac-4b75-a275-69c6a6e004a4/09/ae/09aed2dc-160a-42b4-a30b-afaca948557c.webp'
[Nest] 1273  - 03/04/2024, 6:40:52 PM    WARN [ExpressAdapter] Content-Type doesn't match Reply body, you might need a custom ExceptionFilter for non-JSON responses
[Nest] 1273  - 03/04/2024, 6:41:15 PM     LOG [CommunicationRepository] Websocket Disconnect: Dg0QcSP4ozx6ANIOAAAH
[Nest] 1273  - 03/04/2024, 6:41:18 PM     LOG [CommunicationRepository] Websocket Connect:    X3Ha9BoI3gl5mP4nAAAN
[Nest] 1321  - 03/04/2024, 6:41:19 PM     LOG [MediaService] Successfully generated JPEG image thumbnail for asset b1db84aa-218b-4bac-84f4-dcfb1916bb2d
[Nest] 1321  - 03/04/2024, 6:41:19 PM   ERROR [JobService] Unable to run job handler (smartSearch/smart-search): Error: Unknown system error -116: Unknown system error -116, open '/mnt/HomeAssistantShare/immich/thumbs/6d90c831-1eac-4b75-a275-69c6a6e004a4/b1/db/b1db84aa-218b-4bac-84f4-dcfb1916bb2d.jpeg'
[Nest] 1321  - 03/04/2024, 6:41:19 PM   ERROR [JobService] Error: Unknown system error -116: Unknown system error -116, open '/mnt/HomeAssistantShare/immich/thumbs/6d90c831-1eac-4b75-a275-69c6a6e004a4/b1/db/b1db84aa-218b-4bac-84f4-dcfb1916bb2d.jpeg'
[Nest] 1321  - 03/04/2024, 6:41:19 PM   ERROR [JobService] Object:
{
  "id": "b1db84aa-218b-4bac-84f4-dcfb1916bb2d",
  "source": "upload"
}

[Nest] 1321  - 03/04/2024, 6:41:19 PM   ERROR [JobService] Unable to run job handler (faceDetection/face-detection): Error: Unknown system error -116: Unknown system error -116, open '/mnt/HomeAssistantShare/immich/thumbs/6d90c831-1eac-4b75-a275-69c6a6e004a4/b1/db/b1db84aa-218b-4bac-84f4-dcfb1916bb2d.jpeg'
[Nest] 1321  - 03/04/2024, 6:41:19 PM   ERROR [JobService] Error: Unknown system error -116: Unknown system error -116, open '/mnt/HomeAssistantShare/immich/thumbs/6d90c831-1eac-4b75-a275-69c6a6e004a4/b1/db/b1db84aa-218b-4bac-84f4-dcfb1916bb2d.jpeg'
[Nest] 1321  - 03/04/2024, 6:41:19 PM   ERROR [JobService] Object:
{
  "id": "b1db84aa-218b-4bac-84f4-dcfb1916bb2d",
  "source": "upload"
}

[Nest] 1321  - 03/04/2024, 6:41:20 PM   ERROR [JobService] Unable to run job handler (thumbnailGeneration/generate-thumbhash-thumbnail): Error: Input file contains unsupported image format
[Nest] 1321  - 03/04/2024, 6:41:20 PM   ERROR [JobService] Error: Input file contains unsupported image format
    at Sharp.toBuffer (/app/immich/server/node_modules/sharp/lib/output.js:161:17)
    at MediaRepository.generateThumbhash (/app/immich/server/dist/infra/repositories/media.repository.js:118:14)
    at MediaService.handleGenerateThumbhashThumbnail (/app/immich/server/dist/domain/media/media.service.js:166:54)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async /app/immich/server/dist/domain/job/job.service.js:137:37
    at async Worker.processJob (/app/immich/server/node_modules/bullmq/dist/cjs/classes/worker.js:394:28)
    at async Worker.retryIfFailed (/app/immich/server/node_modules/bullmq/dist/cjs/classes/worker.js:581:24)
[Nest] 1321  - 03/04/2024, 6:41:20 PM   ERROR [JobService] Object:
{
  "id": "b1db84aa-218b-4bac-84f4-dcfb1916bb2d",
  "source": "upload"
}

[Nest] 1321  - 03/04/2024, 6:41:20 PM     LOG [MediaService] Successfully generated WEBP image thumbnail for asset b1db84aa-218b-4bac-84f4-dcfb1916bb2d
[Nest] 1273  - 03/04/2024, 6:41:22 PM   ERROR [Error: Unknown system error -116: Unknown system error -116, open '/mnt/HomeAssistantShare/immich/thumbs/6d90c831-1eac-4b75-a275-69c6a6e004a4/b1/db/b1db84aa-218b-4bac-84f4-dcfb1916bb2d.webp'] Failed to get asset thumbnail
[Nest] 1273  - 03/04/2024, 6:41:22 PM   ERROR [Error: Unknown system error -116: Unknown system error -116, open '/mnt/HomeAssistantShare/immich/thumbs/6d90c831-1eac-4b75-a275-69c6a6e004a4/b1/db/b1db84aa-218b-4bac-84f4-dcfb1916bb2d.webp'] Error: Unknown system error -116: Unknown system error -116, open '/mnt/HomeAssistantShare/immich/thumbs/6d90c831-1eac-4b75-a275-69c6a6e004a4/b1/db/b1db84aa-218b-4bac-84f4-dcfb1916bb2d.webp'
[Nest] 1273  - 03/04/2024, 6:41:22 PM    WARN [ExpressAdapter] Content-Type doesn't match Reply body, you might need a custom ExceptionFilter for non-JSON responses

My PGID and PUID are set to 0, I think when they were  "1000" I had other issues

My PGID and PUID are set to 0, I think when they were "1000" I had other issues

Actually I've switched back the PGID and PUID to 1000 and it works normally (with the noserverino option)


go_ora.AddSessionParam(db, k, v) put values to global driver hashmap

If the go program connect to more than one database/schema and using go_ora.AddSessionParam the last call to AddSessionParam overwrites other values.
for example:

db1 := db.Open("db1.example.com")
go_ora.AddSessionParam(db1, "CURRENT_SCHEMA", "WS")
db2 := db.Open("db2.example.com")
AddSessionParam(db2, "CURRENT_SCHEMA", "TEST")
db1.Exec(..) -> ORA-01435: user does not exist - because TEST was used at initConnection

The cause of this is the global hashmap in OracleDriver used in AddSessionParam.
func AddSessionParam(db *sql.DB, key, value string) error {
	...
	if drv, ok := db.Driver().(*OracleDriver); ok {
		drv.mu.Lock()
		defer drv.mu.Unlock()
		drv.sessionParam[key] = value # issue
		...

func (driver *OracleDriver) init(conn *Connection) error {
	...
	for key, value := range driver.sessionParam {
		_, err = conn.Exec(fmt.Sprintf("alter session set %s=%s", key, value))
		...

Because of implementing database/sql maybe the ConnectString might be the right place to do something like this. If you agree i can create a pull request. Otherwise AddSessionParam should be removed from api and every developer must implement his own initialization. Or do you see another approach?

hi @rheilek
sorry for late
the issue will not be restricted to session parameters also you will face same issue with user defined type (UDT)
I use the driver to pass data between connections in connection pool
so if you want to use multiple database you should use separate driver for each one, I explain this here

thanks, I hadn't seen that, sorry


managedClusters resource not available in selected region

Type of issue

[x] Bug
[ ] New feature
[ ] Enhancement

Description
In the CLI we should only show the regions where the resources are available
C:\Users\brcaspar\source\pcs-cli>pcs --versionOverride actions-bug-bash --dockerTagOverride testing -s standard -r java
? Enter a solution name: brcaspar-actions-bugbash
? Select a subscription: IOTS
? Select a location: South Central US
? Enter prefix for .azurewebsites.net: brcaspar-actions-bugbash
✓ Application registered: https://portal.azure.com/iotsl.onmicrosoft.com#blade/Microsoft_AAD_IAM/ApplicationBlade/objectId/fe340bb4-77da-4b50-997e-9957bebf460e/appId/7629aaca-1248-4dba-b913-4a13871d0ed2
✓ Created resource group: https://portal.azure.com/iotsl.onmicrosoft.com#resource/subscriptions/d7ca9718-3a3c-4ce8-8ec9-76a6396c0206/resourceGroups/brcaspar-actions-bugbash
✕ Deployment validation failed:
{
"code": "LocationNotAvailableForResourceType",
"message": "The provided location 'southcentralus' is not available for resource type 'Microsoft.ContainerService/managedClusters'. List of available regions for the resource type is 'eastus,westeurope,centralus,canadacentral,canadaeast,uksouth,westus,westus2,australiaeast,northeurope,japaneast,eastus2,southeastasia,ukwest'."
}
Error: {"code":"LocationNotAvailableForResourceType","message":"The provided location 'southcentralus' is not available for resource type 'Microsoft.ContainerService/managedClusters'. List of available regions for the resource type is 'eastus,westeurope,centralus,canadacentral,canadaeast,uksouth,westus,westus2,australiaeast,northeurope,japaneast,eastus2,southeastasia,ukwest'."}
...
Steps to reproduce

[First step]
[Second step]
[and so on...]

Expected behavior
...
Current behavior <!-- The actual behavior observed --
...
Known workarounds
Register the provider.
Below is the instruction:
https://docs.microsoft.com/en-us/azure/azure-resource-manager/resource-manager-register-provider-errors#solution-3---azure-portal
Possible solution
...
Context and Environment

Operating System: ...
GitHub branch: ...
Node.js Runtime: ...

It is because the provider (Microsoft.ContainerService) was not registered automatically for some subscriptions.
A customer who sees this error needs to register the provider manually.
(See Known workarounds for instruction)
IcM ticket has created and assigned to ACS to see if the provider can be registered automatically to all subscriptions.

@sakimsft could you please update the TSG with the appropriate set of guidelines for the customers?

@avneet723
I already added TSG under PCS at below location since I could not find Wiki or TSG for CLI.
https://github.com/Azure/azure-iot-pcs-remote-monitoring-dotnet/wiki/Developer-Troubleshooting-Guide#Resolve-errors-for-resource-provider-registration
If you have other preferable location to document, please let me know - I will add document accordingly.


Quick box improvements for multi-step inputs

Continuing #48116. Mockups #45589.

#50050 shows several attempts to draft the API for multi-step inputs, each accompanied with a simple example of asking the user for three inputs:

A resource group (to create an App Service in).
A name for the App Service.
A runtime for the App Service.

Some challenges we need to solve in order to implement the mockups in #45589:

No flicker in the UI, also when, e.g. step 3 first needs to fetch the list of available picks based on the choice in step 1.
Cancellability while the user provides input and between inputs (e.g., while additional data is fetched).
Dynamic steps and custom actions, e.g., step 1 can have a toolbar item for creating a new resource group. For that an additional step to input the name of the new resource group needs to be added dynamically.
The UI allows the user to navigate back to the previous inputs.
We should consider what it means for an input sequence to be suspended and later resumed.

What makes it difficult to weave this into the existing API of showQuickPick and showInputBox:

'Navigate back' and 'custom action': The two functions only support two possible outcomes in their return types: Input is provided or it is cancelled. Introducing additional outcomes requires expanding the return types or having an additional way of receiving the outcome.
Connecting multiple input steps requires some kind of context that is passed either as an option to the existing API or as an implicit state to the implementation behind the existing API.

Adding additional outcomes like 'back to previous step' and custom actions like 'create resource group' to the existing API has proven to be difficult without jeopardizing its simplicity. So our current thinking is that we need to introduce new API to handle these and other advanced cases (e.g., dynamically updating the list of items) we haven't discussed yet.

The new API will provide the basic operations needed to build not only multi-step input flows, but also dynamic updating of the items list and other currently not foreseen scenarios.

A draft of this API is shown in Take 3 of the API exploration.
A simple multi-step example is shown in Take 3 of the examples.
A more elaborate multi-step example with back navigation and custom actions is shown in Take 10 of the examples.

The additional flexibility comes at the price of extensions having to write more code to implement useful behavior. At the same time we are keeping the existing API simple as it is and we are not introducing new API that tries to anticipate future use cases beyond the basic operations these will be made of. It will also be easy to add more of these basic operations later.

A couple of quick first thoughts.
Instead of using toolbarItems with events, why not use Commands -- not that you would define their placement in the QuickInput, but you could change toolbarItems to be commands and then any commands added with icons would be added as toolbar buttons, and others would be added under a ... menu. I feel like that would be a bit more consistent with other APIs and UI structures.
What is onDidAccept? Is it for accepting text input that isn't in the pick list?
I also don't yet understand what enabled & busy are for.
Some other nit picks:

pickMany -> multiselect

I would also love it if there was an API affordance to expose the ability the file picker has, which is to use the right-arrow to perform an action on a pick item. I go through some gymnastics in GitLens to offer a similar ability - although I can't use right-arrow without a modifier otherwise you couldn't move the cursor in the input box.

I was asked to provide input here in reference to closed issue #35993
However, I think the scope of the other issue is far beyond what is being talked about here?
I want the ability to build a custom command palette for vscode with the same capabilities of the command palette which I built for Eclipse.
You can see an example of the capabilities in the Eclipse palette here Commander, a next-gen command palette for Eclipse
Probably what I actually need is a webview that can be positioned like a quick picker that allows handling of keyboard events and access to the list of all commands and their names, descriptions etc.

@eamodio Thanks for the feedback:

I'll look into using commands, that would indeed make it more consistent.
onDidAccept is for accepting text in the input box (although it can also be interpreted as pick the current item in the list, that is up to the extension), onDidSelectItem (was: onDidPickItem) is for selecting an item in the list.
enabled: false would prevent the user from interacting with the input UI (e.g., between two steps of a multi-step input).
busy: true would show a progress indicator (e.g., while loading additional items).
I'm renaming pickMany to canSelectMany which is consistent with canSelectMany in the OpenDialogOptions.

@dakaraphi Thanks for the feedback, to reply to your feature requests in #35993:

Capture keyboard input events from input field and handle in extension

onDidTextChange gives the text changes.

Change list content on handling of input events

items can be updated in response to changes in the text field.

Add columns to list content

This is not within the scope of this change. We would probably need additional use cases to better understand the requirements of the community with this before we add API.

Handle some level of rendering of content

Provide indication of markers to be applied on a row
Provide character indices or information for highlighting matched characters

Highlighting of characters in list items is not part of the proposed API yet, but will need to be added in some way to match the capabilities of the existing showQuickPick API.

PR #50402 shows an updated version of the API draft. Still not using commands, that needs more thought on whether it fits this use case.

@chrmarti thx, so where do I go from here?  Should this be a separate issue? Should the original be reopened?

@dakaraphi I have reopened the other issue.

I wondered if the new API for multi-step QuickOpen-Actions, in some form or another, will find a way into the standalone monaco-editor, since I would have great use for this. (consuming the editor, not extending it, so using vanilla JS)
So, are there any plans to bring it to standalone monaco-editor?
monaco-editor#683

@sydeslyde It currently seems unlikely that we will add API to Monaco that is not core to the editor.

Some screenshots of the current work showing a multi-step flow.
Step 1 with a custom action "+" (icon from the extension) in the title:

Step 2 with a built-in back button (icon is TBD) in the title:

The built-in back button will have keyboard shortcuts assigned (by default the same as Back editor navigation).
Step 3 with a light theme:

If someone hits esc on one of the steps does it just back up or is the whole sequence canceled?
Definitely agree that the back button needs a better icon (and/or stronger treatment)

The API currently leaves handling of Esc or any other way of cancellation to the extension. The API tries to be generic in such a way that you need to implement 'multi-step input' on top of it.

So the input steps that say "Press Enter to confirm or Esapce to cancel" won't do anything unless the author handles Esc?

Escape will hide it and fire onDidHide, that part cannot be overridden for consistency. Enter will fire onDidAccept, but it will not hide the input UI, so it is up to the extension to either hide it or continue with other inputs.

Ah, got it -- thanks

Is there any way to easily include an optional step? Eg. in Flutter we have a "new project" command which prompts you for a few things - a project name, location, etc.. Some people want to add additional steps for some optional values (which programming language, etc.) but it would make the simple flow more complicated.
I'm not sure how it'd fit into the UI, but if there was some way to allow the user a way to go to advance settings without adding another step in. I'm not sure you could really do it without adding buttons along the bottom or something, but I thought it worth asking in case you'd thought about it :-)

@chrmarti Aha, I misunderstood what that + was. Sounds good, thanks!

Good progress on the implementation. There is the multi-step example based on this new API: https://github.com/Microsoft/vscode-extension-samples/tree/chrmarti/quickinputsample/quickinput-sample
The API is still proposed, now would be a good time to check if it will suit your needs. Thanks!

@raix You can update the list of items while the picker is already shown (just assign a new array to items). While fetching new items remotely you can also turn on a progress indicator (set busy to true) to give a hint that the list will be updated. One current limitation is that the list does not have a message area to show a validation message.

@chrmarti Ok, sounds good - I'll take a closer look.
Would be nice with the ability to validate the input (like in the regular input component)

Collecting feedback in https://github.com/Microsoft/vscode/issues/53327.