Update Kubernetes dependencies

Kubernetes only supports 3 major releases at a time, so 1.11 is out of support now.
KinD also needs 1.13, so this will be useful as we adopt/try adding KinD for our integration tests.
Aside from the vendor updates, the code changes required were minimal.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: howardjohn
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rshriram
If they are not already assigned, you can assign the PR to them by writing /assign @rshriram in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-trustdomain.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-bookInfoTests-trustdomain

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-trustdomain.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-bookInfoTests-trustdomain

prow/e2e-mixer-no_auth.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-trustdomain.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-bookInfoTests-trustdomain

prow/e2e-mixer-no_auth.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-mixer-no_auth

prow/e2e_pilotv2_auth_sds.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio_auth_sds_e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-trustdomain.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-bookInfoTests-trustdomain

prow/e2e-mixer-no_auth.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-mixer-no_auth

prow/e2e_pilotv2_auth_sds.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio_auth_sds_e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-trustdomain.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-bookInfoTests-trustdomain

prow/e2e-mixer-no_auth.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-mixer-no_auth

prow/e2e_pilotv2_auth_sds.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio_auth_sds_e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-trustdomain.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-bookInfoTests-trustdomain

prow/e2e-mixer-no_auth.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-mixer-no_auth

prow/e2e_pilotv2_auth_sds.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio_auth_sds_e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-dashboard.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-trustdomain.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-bookInfoTests-trustdomain

prow/e2e-mixer-no_auth.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-mixer-no_auth

prow/e2e_pilotv2_auth_sds.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio_auth_sds_e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-dashboard.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-dashboard

prow/e2e-simpleTests.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-simpleTests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-trustdomain.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-bookInfoTests-trustdomain

prow/e2e-mixer-no_auth.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-mixer-no_auth

prow/e2e_pilotv2_auth_sds.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio_auth_sds_e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-dashboard.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-dashboard

prow/e2e-simpleTests.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-simpleTests

prow/istio-pilot-multicluster-e2e.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-trustdomain.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-bookInfoTests-trustdomain

prow/e2e-mixer-no_auth.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-mixer-no_auth

prow/e2e_pilotv2_auth_sds.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio_auth_sds_e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-dashboard.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-dashboard

prow/e2e-simpleTests.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-simpleTests

prow/istio-pilot-multicluster-e2e.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests-cni.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-trustdomain.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-bookInfoTests-trustdomain

prow/e2e-mixer-no_auth.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-mixer-no_auth

prow/e2e_pilotv2_auth_sds.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio_auth_sds_e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-dashboard.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-dashboard

prow/e2e-simpleTests.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-simpleTests

prow/istio-pilot-multicluster-e2e.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests-cni.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-trustdomain.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-bookInfoTests-trustdomain

prow/e2e-mixer-no_auth.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-mixer-no_auth

prow/e2e_pilotv2_auth_sds.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio_auth_sds_e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-dashboard.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-dashboard

prow/e2e-simpleTests.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-simpleTests

prow/istio-pilot-multicluster-e2e.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests-cni.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio-integ-k8s-tests

prow/istio-presubmit.sh
f9a9bdea55640c39975f068832dad6b04ad02072
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-trustdomain.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-bookInfoTests-trustdomain

prow/e2e-mixer-no_auth.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-mixer-no_auth

prow/e2e_pilotv2_auth_sds.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio_auth_sds_e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-dashboard.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-dashboard

prow/e2e-simpleTests.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-simpleTests

prow/istio-pilot-multicluster-e2e.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests-cni.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio-integ-k8s-tests

prow/istio-presubmit.sh
f9a9bdea55640c39975f068832dad6b04ad02072
link
/test istio-presubmit

prow/istio-unit-tests.sh
f9a9bdea55640c39975f068832dad6b04ad02072
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-trustdomain.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-bookInfoTests-trustdomain

prow/e2e-mixer-no_auth.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-mixer-no_auth

prow/e2e_pilotv2_auth_sds.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio_auth_sds_e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-dashboard.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-dashboard

prow/e2e-simpleTests.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-simpleTests

prow/istio-pilot-multicluster-e2e.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests-cni.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio-integ-k8s-tests

prow/istio-presubmit.sh
f9a9bdea55640c39975f068832dad6b04ad02072
link
/test istio-presubmit

prow/istio-unit-tests.sh
f9a9bdea55640c39975f068832dad6b04ad02072
link
/test istio-unit-tests

prow/istio-integ-local-tests.sh
f9a9bdea55640c39975f068832dad6b04ad02072
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-trustdomain.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-bookInfoTests-trustdomain

prow/e2e-mixer-no_auth.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-mixer-no_auth

prow/e2e_pilotv2_auth_sds.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio_auth_sds_e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-dashboard.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-dashboard

prow/e2e-simpleTests.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-simpleTests

prow/istio-pilot-multicluster-e2e.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests-cni.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio-integ-k8s-tests

prow/istio-unit-tests.sh
28ea5ffffbba259fd2c96d2eafecb137a1dee7d3
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-trustdomain.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-bookInfoTests-trustdomain

prow/e2e-mixer-no_auth.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-mixer-no_auth

prow/e2e_pilotv2_auth_sds.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio_auth_sds_e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests-cni.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio-integ-k8s-tests

prow/istio-unit-tests.sh
28ea5ffffbba259fd2c96d2eafecb137a1dee7d3
link
/test istio-unit-tests

prow/e2e-dashboard.sh
28ea5ffffbba259fd2c96d2eafecb137a1dee7d3
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-trustdomain.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-bookInfoTests-trustdomain

prow/e2e-mixer-no_auth.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-mixer-no_auth

prow/e2e_pilotv2_auth_sds.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio_auth_sds_e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio-integ-k8s-tests

prow/e2e-dashboard.sh
28ea5ffffbba259fd2c96d2eafecb137a1dee7d3
link
/test e2e-dashboard

prow/e2e-simpleTests.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test e2e-simpleTests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-trustdomain.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-bookInfoTests-trustdomain

prow/e2e-mixer-no_auth.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-mixer-no_auth

prow/e2e_pilotv2_auth_sds.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio_auth_sds_e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio-integ-k8s-tests

prow/e2e-simpleTests.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test e2e-simpleTests

prow/e2e-dashboard.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-trustdomain.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-bookInfoTests-trustdomain

prow/e2e-mixer-no_auth.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-mixer-no_auth

prow/e2e_pilotv2_auth_sds.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio_auth_sds_e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio-integ-k8s-tests

prow/e2e-simpleTests.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test e2e-simpleTests

prow/e2e-dashboard.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test e2e-dashboard

prow/e2e-simpleTests-cni.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-trustdomain.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-bookInfoTests-trustdomain

prow/e2e-mixer-no_auth.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-mixer-no_auth

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio-integ-k8s-tests

prow/e2e-simpleTests.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test e2e-simpleTests

prow/e2e-dashboard.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test e2e-dashboard

prow/e2e-simpleTests-cni.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test e2e-simpleTests-cni

prow/e2e_pilotv2_auth_sds.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test istio_auth_sds_e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-mixer-no_auth

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio-integ-k8s-tests

prow/e2e-simpleTests.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test e2e-simpleTests

prow/e2e-dashboard.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test e2e-dashboard

prow/e2e-simpleTests-cni.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test e2e-simpleTests-cni

prow/e2e_pilotv2_auth_sds.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test istio_auth_sds_e2e

prow/e2e-bookInfoTests-trustdomain.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test e2e-bookInfoTests-trustdomain

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-mixer-no_auth

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio-integ-k8s-tests

prow/e2e-simpleTests.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test e2e-simpleTests

prow/e2e-dashboard.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test e2e-dashboard

prow/e2e-simpleTests-cni.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test e2e-simpleTests-cni

prow/e2e_pilotv2_auth_sds.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test istio_auth_sds_e2e

prow/e2e-bookInfoTests-trustdomain.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test e2e-bookInfoTests-trustdomain

prow/e2e-bookInfoTests-v1alpha3.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-mixer-no_auth

prow/istio-pilot-multicluster-e2e.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio-integ-k8s-tests

prow/e2e-simpleTests.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test e2e-simpleTests

prow/e2e-dashboard.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test e2e-dashboard

prow/e2e-simpleTests-cni.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test e2e-simpleTests-cni

prow/e2e_pilotv2_auth_sds.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test istio_auth_sds_e2e

prow/e2e-bookInfoTests-trustdomain.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test e2e-bookInfoTests-trustdomain

prow/e2e-bookInfoTests-v1alpha3.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test e2e-mixer-no_auth

prow/istio-integ-k8s-tests.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio-integ-k8s-tests

prow/e2e-simpleTests.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test e2e-simpleTests

prow/e2e-dashboard.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test e2e-dashboard

prow/e2e-simpleTests-cni.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test e2e-simpleTests-cni

prow/e2e_pilotv2_auth_sds.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test istio_auth_sds_e2e

prow/e2e-bookInfoTests-trustdomain.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test e2e-bookInfoTests-trustdomain

prow/e2e-bookInfoTests-v1alpha3.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
9101dc07c101bb19f4427fe53148eba01e8e3180
link
/test istio-integ-k8s-tests

prow/e2e-simpleTests.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test e2e-simpleTests

prow/e2e-dashboard.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test e2e-dashboard

prow/e2e-simpleTests-cni.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test e2e-simpleTests-cni

prow/e2e_pilotv2_auth_sds.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test istio_auth_sds_e2e

prow/e2e-bookInfoTests-trustdomain.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test e2e-bookInfoTests-trustdomain

prow/e2e-bookInfoTests-v1alpha3.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test e2e-simpleTests

prow/e2e-dashboard.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test e2e-dashboard

prow/e2e-simpleTests-cni.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test e2e-simpleTests-cni

prow/e2e_pilotv2_auth_sds.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test istio_auth_sds_e2e

prow/e2e-bookInfoTests-trustdomain.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test e2e-bookInfoTests-trustdomain

prow/e2e-bookInfoTests-v1alpha3.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test e2e-mixer-no_auth

prow/istio-integ-k8s-tests.sh
59812da662d6ad0d209b888d34832e79b2fb57e1
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/assign @rshriram @linsun @costinm

@howardjohn: GitHub didn't allow me to assign the following users: rshriram, linsun.
Note that only istio members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign @rshriram @linsun @costinm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
1f35eb103860c44654b14393148a89051b19f150
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

integ tests are known failures
/assign @rshriram

@howardjohn: GitHub didn't allow me to assign the following users: rshriram.
Note that only istio members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

integ tests are known failures
/assign @rshriram

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/hold
Let's resolve klog thing before merging. It is a risk to write logs into containers.

@kyessenov What do you think next steps should be? Is the current code ok since we don't actually write to container, or do you think we should add the init to galley as well as a safety?

Please add calls to klog.Init to write to stderr in all binaries. Alternatively, redirect klog package to istio/glog package.

I think redirecting the klog package is the best option, and it aligns with what we have right now. It will be safer and more consistent. Will update

https://github.com/istio/glog/pull/4

/hold cancel
@howardjohn Can you please add a package redirect for klog?

Yep that is the plan, will have it done later today

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: howardjohn
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm
If they are not already assigned, you can assign the PR to them by writing /assign @costinm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyessenov klog shim is set up

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
a7253dc6955f9634def720318a1b4bc92230d11b
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm
On Wed, Apr 24, 2019 at 5:51 PM istio-bot<EMAIL_ADDRESS>wrote:

@howardjohn https://github.com/howardjohn: The following test failed,
say /retest to rerun them all:
Test name Commit Details Rerun command
prow/istio-integ-k8s-tests.sh a7253dc
https://github.com/istio/istio/commit/a7253dc6955f9634def720318a1b4bc92230d11b
link
https://k8s-gubernator.appspot.com/build/istio-prow/pr-logs/pull/istio_istio/13324/istio-integ-k8s-tests/7357 /test
istio-integ-k8s-tests
Instructions for interacting with me using PR comments are available here
https://git.k8s.io/community/contributors/guide/pull-requests.md. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
https://github.com/kubernetes/test-infra/issues/new?title=Prow issue:
repository. I understand the commands that are listed here
https://go.k8s.io/bot-commands.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/13324#issuecomment-486478949, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACIYRRWEYMZ3CXRWWRC2AUTPSD6CVANCNFSM4HF4J6BQ
.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: howardjohn, kyessenov
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm
If they are not already assigned, you can assign the PR to them by writing /assign @costinm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
a7253dc6955f9634def720318a1b4bc92230d11b
link
/test istio-integ-k8s-tests

prow/e2e-bookInfoTests-trustdomain.sh
79b7981b5415a5febd60595d76a48740abe2aae2
link
/test e2e-bookInfoTests-trustdomain

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-bookInfoTests-trustdomain

New changes are detected. LGTM label has been removed.

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
a30aa1a2298f1b8436e68085c0ba5b39363972c0
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm
/approve

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: howardjohn, kyessenov
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm
If they are not already assigned, you can assign the PR to them by writing /assign @costinm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@geeknoid can we merge this before experimenting with go mod?

/approve
/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: costinm, howardjohn, kyessenov
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [costinm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
a30aa1a2298f1b8436e68085c0ba5b39363972c0
link
/test istio-integ-k8s-tests

prow/e2e_pilotv2_auth_sds.sh
a30aa1a2298f1b8436e68085c0ba5b39363972c0
link
/test istio_auth_sds_e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
a30aa1a2298f1b8436e68085c0ba5b39363972c0
link
/test istio_auth_sds_e2e

prow/istio-integ-k8s-tests.sh
a30aa1a2298f1b8436e68085c0ba5b39363972c0
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio_auth_sds_e2e


scroll to bottom on page load

I think it would be nice if the page scrolled to the bottom when it loaded.
window.scrollTo(0,document.body.scrollHeight);
but not sure how to do this in elm

Great idea! I just opened a PR that implements that. If you're curious about how it would look in Elm, it's on these lines.

Thank you for the suggestion @chapmanjacobd and @hkgumbs for implementing it! Hope you enjoyed the koans.


Auto Slide

can i set to auto slide?

this.findViewById(R.id.button_next).callOnClick();
Put above code inside the activity that extends MaterialIntroActivity - this would help you move to next page


Fix EditorSpinSlider bad mouse position and zoom issues (Fix #46632 & #46708)

Fix #46632 & #46708 issues
As described in the issue mentionned,  EditorSpinSlider grabber was not at the correct position when GraphEdit zoom wasn't set to 1.
Also the mouse position when releasing the grabber was incorrect.
Solution :
Scale in now applied when calculating the grabber position.
I use get_global_transform_with_canvas().get_scale() to get the scale.
Also, the visual size of the grabber is now correctly scaled.
Finaly, the mouse position when we released the grabber is set correctly at the grabber position.
Zoom fix :
(Note that this gif has been captured before the mouse fix was added, so the mouse position is weird but now it's ok)

Mouse position fix :
Before :

After :

Closed this one and open the new PR for grabber zoom only #46943

Closed this one and open the new PR for grabber zoom only #46943


Support for HTML5 document.currentScript

Can add guaranteed support for HTML's document.currentScript in IE 8-10 (but NOT IE 11 😭) by using the techniques from JamesMGreene/document.currentScript.
If it weren't for the lack of defining getters on DOM interfaces in IE <8, this can actually be supported all the way down to IE 6.
I can submit a PR for this soon-ish.

If it weren't for the lack of define getters in IE <9, this can actually be supported all the way down to IE 6.

Although, now that I've said that, I am struggling to remember why this didn't work in IE 8 since we are adding the accessor to a DOM object (Document/HTMLDocument)... I will investigate that before submitting: JamesMGreene/document.currentScript#17

@triblondon et al:
Object.defineProperty exists but only works on DOM interfaces (not other JS objects).  However, for the PR related to this issue, I can still support IE8 by utilizing Object.defineProperty as I will be adding a getter to a DOM interface.
How would I handle declaring my dependencies on Object.defineProperty for this feature, given that I also want to enable its use In IE8?

@JamesMGreene Here is an example of adding another polyfill as a dependency -- https://github.com/Financial-Times/polyfill-service/blob/master/polyfills/Element/prototype/placeholder/config.json#L10

@JakeChampion: Thanks, I get that (just recently made use of the same thing in my PR #951. However, my question is a bit more complex than that.
The difference here is that the version of Object.defineProperty that I need/want to utilize (only needs to work for DOM interfaces) is available in IE8, whereas the full-featured version of Object.defineProperty did not hit the scene until IE9.
If you look at polyfills/Object/defineProperty/detect.js, for example, you will see that the feature test is done specifically on a plain JS object (which is the right thing to do). However, that also means that, if I mark "Object.defineProperty" as a dependency, Polyfill will needlessly include the polyfills/Object/defineProperty/polyfill.js file for IE8 despite the fact that I don't actually need it.  The polyfill will work fine due to polyfills/Object/defineProperty/polyfill.js#L9-L12, so that isn't a concern so much as potentially wasting download/execution time with it unnecessarily.
The issue is also exacerbated for this particular polyfill as it can ONLY be correctly polyfilled for IE8-10 (and NOT IE11 😭), so the polyfill's browser inclusion pattern will have already limited it to those IE versions which have the means available already.
Can polyfills be forcibly included even if they don't match the compatible browser versions?

If so, it is probably best to mark the Object.defineProperty polyfill as a dependency to ensure that appropriate pre-conditions are being verified.
If not, then we'd achieve the best performance by omitting the Object.defineProperty dependency indication and just adding descriptive comments instead.

@JakeChampion @triblondon: Any further clarification on what you'd recommend here?

Hi James. Sorry for the delay on this. It's a tricky one: it is indeed possible to force-include a polyfill in all browsers (and many people do this) using the always flag. This is not normally recommended but it makes sense in some cases.
So in this case you want to ship a polyfill that depends on defineProperty, but only works in browsers that already have it. if there are any cases where including defineProperty would actually offer any value (e.g. In cases where your polyfill is being force loaded in inappropriate browsers) then I'd agree that on the safe side you should list it as a dependency. However if it makes no difference (your polyfill still fails, and no more or less gracefully) then there'a no benefit to drawing the relationship between the two.

Thanks for fielding that one, Andrew.  I'll proceed to create a corresponding PR when I find the time.


temporarily bypass the "real CI" for the engine python port work

use the faux CI for now

@grdumas we need to merge this so that your work (such as #383 ) doesn't cause needless CI runs.  Please review this ASAP.


turn cookie store detection on it's feet

All the Unix-like platforms (Linux, *BSD) use the same location for
the browser profile directories, so it makes some sense to make
that the default instead of tracking all the platform names; and
treat Windows and OSX as the exceptions they are (based on the number
of platform names, not installs). This is especially useful as the
"platform" name on at least FreeBSD changes with each major release
(e.g. freebsd12, freebsd13, ...) and would have to be updated for
every release without this change here.
At the same time, fix the error condition: the question is not whether
we are on a "supported" platform but if the browser profile directory
exists in the place where we expect it. That handles all the cases like
"browser not available", "browser not installed", "profile not
initialized (yet)" and "non-standard profile dir location". Change
error message to match that behaviour.

Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8 and ran relevant tests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Fix or improvement to an extractor (Make sure to add/update tests)
[ ] New extractor (Piracy websites will not be accepted)
[x] Core bug fix/improvement
[ ] New feature (It is strongly recommended to open an issue first)

Description of your pull request and other information
Explanation of your pull request in arbitrary form goes here. Please make sure the description explains the purpose and effect of your pull request and is worded well enough to be understood. Provide as much context and examples as possible.

Replaces https://github.com/yt-dlp/yt-dlp/pull/3370


How to save array ?

How can I save primitiv type arrays. eg:
obj.setMyArray(new Integer[] {1,2,3,4});
obj.save();

When my entity:
public class Profile extends SugarRecord<Profile> {
    private Integer[] myArray;
//Setter & Getter

Because like that, the array isn't stored!

i implemented that myself by having a ignored member list and filling that. now i look for a "moment" to do so and wanted to overwrite inflate() but that is package local. would be good to have that protected or the like to allow additional actions after retrieving the pojo from db...

Any news on this?


Helm - Add NodePool and EC2NodeClass

Description
What problem are you trying to solve?
Allow specifying NodePool and Ec2NodeClass
How important is this feature to you?
It will simplify the installation of the karpenter with helm, allowing specifying a node pool and ec2nodeclass in the initial installation.
Ex: Install the karpenter with the terraform in a Kubernetes cluster with fargate(serverless) or another option with 0 nodes, and install the GitOps tools after it, without the need to create another resource (NodePool and Ec2NodeClass), and has all things work out-of-the-box.
If it is fine, I can do the PR.

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

We had a similar request here: #1956. We are generally recommending that users build a "top-level chart" that take this chart as a dependency elsewhere since we are generally trying to avoid the burden of having to maintain the chart ourselves. given the number of options that we would have to support.

hum... https://github.com/aws/karpenter/pull/1956#issuecomment-1163402365, this commentary really makes sense. closing.

@mtavaresmedeiros In my production cluster, I am using my own karpenter-nodepool chart, integrated into the karpenter chart as a child chart.
Subchart dependencies declared in the Chart.yaml of the karpenter chart:
# charts/karpenter/Chart.yaml
dependencies:
  - name: karpenter-nodepool
    version: 0.0.7
    repository: "file://./charts/karpenter-nodepool"
    condition: karpenter-nodepool.enabled

Directory structure for karpenter chart, including karpenter-nodepool chart as subchart:
karpenter  # parent chart
├── Chart.lock
├── Chart.yaml
├── README.md
├── charts
│   └── karpenter-nodepool  # subchart
├── crds
├── templates
└── values.yaml


org.bouncycastle.asn1.BEROctetString found in input should only contain DEROctetString since 1.63

Hi,
for a e-mail i got a exception since 1.63 till 1.67b04
Caused by: java.lang.IllegalArgumentException: org.bouncycastle.asn1.BEROctetString found in input should only contain DEROctetString
	at org.bouncycastle.asn1.BEROctetString.toBytes(BEROctetString.java:48)
	at org.bouncycastle.asn1.BEROctetString.<init>(BEROctetString.java:104)
	at org.bouncycastle.asn1.BEROctetString.<init>(BEROctetString.java:78)
	at org.bouncycastle.asn1.ASN1OctetString.getInstance(ASN1OctetString.java:140)
	at org.bouncycastle.asn1.cms.EncryptedContentInfo.<init>(EncryptedContentInfo.java:55)
	at org.bouncycastle.asn1.cms.EncryptedContentInfo.getInstance(EncryptedContentInfo.java:82)
	at org.bouncycastle.asn1.cms.EnvelopedData.<init>(EnvelopedData.java:84)
	at org.bouncycastle.asn1.cms.EnvelopedData.getInstance(EnvelopedData.java:131)
	at org.bouncycastle.cms.CMSEnvelopedData.<init>(CMSEnvelopedData.java:75)
	... 3 more

if i try do read the e-mail:
SMIMEEnveloped smimeEnveloped = new SMIMEEnveloped(msg);
Maybe the problem is in the e-mail itself, but at the moment i try to find the errorplace.... Maybe some got the exception too and had a idea for me?
I'm trying to set up a test case...
Suggestions and ideas for solving the problem are very welcome!
Thx. Martin

Update:
I compare now 1.62 with 1.63 and I think the change is in:
org.bouncycastle.asn1.ASN1OctetString in getInstance method.
In 1.62 it works with this code.
    public static ASN1OctetString getInstance(
        ASN1TaggedObject    obj,
        boolean             explicit)
    {
        ASN1Primitive o = obj.getObject();

        if (explicit || o instanceof ASN1OctetString)
        {
            return getInstance(o);
        }
        else
        {
            return BEROctetString.fromSequence(ASN1Sequence.getInstance(o));
        }
    }

In 1.63 this methode has huge change.
The "taggedObject"	is from typ "BERTaggedObject". So in 1.63 I am in this code:
        /*
         * constructed object which appears to be explicitly tagged and it's really implicit means
         * we have to add the surrounding octet string.
         */
        if (taggedObject.isExplicit())
        {
            ASN1OctetString singleSegment = ASN1OctetString.getInstance(o);

            if (taggedObject instanceof BERTaggedObject)
            {
                return new BEROctetString(new ASN1OctetString[]{ singleSegment });
            }

            // TODO Should really be similar to the BERTaggedObject case above:
//            return new DLOctetString(new ASN1OctetString[]{ singleSegment });
            return (ASN1OctetString)new BEROctetString(new ASN1OctetString[]{ singleSegment }).toDLObject();
        }

In "return new BEROctetString(new ASN1OctetString[]{ singleSegment });" the exception is thrown.
The "singleSegment" is from type "BEROctetString" and has this value "string with 1000 chars".
In BEROctetString is this method:
Here is a cast to "DEROctetString " but the value is a "BEROctetString".
  static private byte[] toBytes(
        ASN1OctetString[]  octs)
    {
        ByteArrayOutputStream bOut = new ByteArrayOutputStream();

        for (int i = 0; i != octs.length; i++)
        {
            try
            {
                DEROctetString o = (DEROctetString)octs[i];

                bOut.write(o.getOctets());
            }
            catch (ClassCastException e)
            {
                throw new IllegalArgumentException(octs[i].getClass().getName() + " found in input should only contain DEROctetString");
            }
            catch (IOException e)
            {
                throw new IllegalArgumentException("exception converting octets " + e.toString());
            }
        }

        return bOut.toByteArray();
    }

Sorry, I don't have that much idea, but this change (in ASN1OctetString) is causing the "bug".

Update 2:
The problem is in ASN1OctetString.getInstance with this if statement:
if (taggedObject.isExplicit())
        {
            ASN1OctetString singleSegment = ASN1OctetString.getInstance(o);

            if (taggedObject instanceof BERTaggedObject)
            {
                return new BEROctetString(new ASN1OctetString[]{ singleSegment });
            }

            // TODO Should really be similar to the BERTaggedObject case above:
//            return new DLOctetString(new ASN1OctetString[]{ singleSegment });
            return (ASN1OctetString)new BEROctetString(new ASN1OctetString[]{ singleSegment }).toDLObject();
        }

My "BERTaggedObject" ist explicit because in ASN1StreamParser in " ASN1Primitive readTaggedObject(boolean constructed, int tag) throws IOException" this code is executed:
  if (_in instanceof IndefiniteLengthInputStream)
        {
            return v.size() == 1
                ?   new BERTaggedObject(true, tag, v.get(0))
                :   new BERTaggedObject(false, tag, BERFactory.createSequence(v));
        }

The size of v is 1, so explicit "true" is set.
And then the ASN1OctetString is trying to generate the new objects,
Maybe this code:
 if (o instanceof ASN1OctetString)
        {
            ASN1OctetString s = (ASN1OctetString)o;

            if (taggedObject instanceof BERTaggedObject)
            {
                return s;
            }

            return (ASN1OctetString)s.toDLObject();
        }

in ASN1OctetString.getInstance should come before this " if (taggedObject.isExplicit())" ?

Update 3:
If i change in ASN1OctetString the code from:
        /*
         * constructed object which appears to be explicitly tagged and it's really implicit means
         * we have to add the surrounding octet string.
         */
        if (taggedObject.isExplicit())
        {
            ASN1OctetString singleSegment = ASN1OctetString.getInstance(o);

            if (taggedObject instanceof BERTaggedObject)
            {
                return new BEROctetString(new ASN1OctetString[]{ singleSegment });
            }

            // TODO Should really be similar to the BERTaggedObject case above:
//            return new DLOctetString(new ASN1OctetString[]{ singleSegment });
            return (ASN1OctetString)new BEROctetString(new ASN1OctetString[]{ singleSegment }).toDLObject();
        }

        if (o instanceof ASN1OctetString)
        {
            ASN1OctetString s = (ASN1OctetString)o;

            if (taggedObject instanceof BERTaggedObject)
            {
                return s;
            }

            return (ASN1OctetString)s.toDLObject();
        }

to
        if (o instanceof ASN1OctetString)
        {
        	ASN1OctetString s = (ASN1OctetString)o;

        	if (taggedObject instanceof BERTaggedObject)
        	{
        		return s;
        	}

        	return (ASN1OctetString)s.toDLObject();
        }
        /*
         * constructed object which appears to be explicitly tagged and it's really implicit means
         * we have to add the surrounding octet string.
         */
        if (taggedObject.isExplicit())
        {
            ASN1OctetString singleSegment = ASN1OctetString.getInstance(o);

            if (taggedObject instanceof BERTaggedObject)
            {
                return new BEROctetString(new ASN1OctetString[]{ singleSegment });
            }

            // TODO Should really be similar to the BERTaggedObject case above:
//            return new DLOctetString(new ASN1OctetString[]{ singleSegment });
            return (ASN1OctetString)new BEROctetString(new ASN1OctetString[]{ singleSegment }).toDLObject();
        }

works it again....

I think the real issue is toBytes(), ASN.1 being flexible to the point of tear inducing there's no "issue" with nesting BER data. I'm not sure how that got there, but I've changed toBytes() just to treat things as ASN1OctetString and to not look specifically for DER.

Thank you very much with the BC 1.67b07 it works again! Thank you very much!

Fixed, testes in BC 1.67b07.


propose_to_be_provider extrinsic should reject bad names

Problem
I was able to add a motion via propose_to_be_provider with an invalid provider name (somethingverylongthatIknowwill fail to be specific), because it's just a passthrough.  The extrinsic would fail on execution, however, it's undesirable to have people create trash proposals for a number of reasons.
expected:
the transaction to fail
actual
the transaction succeeded and a Council motion was created.
Also noted: there are no minimum name size or character validations like there is with handles. Should any of these checks be there?  You can right now register with a single character name, or use spaces, or for example on Rococo, I was able to register MSA 1129 as "猫猫-X" by entering the hex value 0xe78cabe78cab2d58

Re: Character validations. I don't think so? The provider name is not human validated. On Rococo for example we have many providers with the same name due to test runs.
It is more for self discovery and easy development than anything else. Assuming you know what you named your provider (and no one else uses that name), you can find yourself.
I think there is a future where we have some provider registry data here that could be validated. One example would be a domain name. The domain data is unvalidated on chain, but a DNS txt record can be used to validate as needed.

Sounds good.  Existing restrictions should stay the same, and be applied on the proposal. Updated the description.


test: add snapshot tests to verify solver sorting order

This PR adds a few tests to verify the solver sorting order in preparation for #892

Nice!


python3 problem: discovery.build(...).service.users().messages().send(message) requires bytes obj that is unserializable by json

First of all, in Python 2 there is no problem.
In trying to send a message with a service instance (as in this example), by
service.users().messages().send('me', message)

it requires message to be in bytes format, which it tries to serialize with json.dumps. However, in Python 3 this is not possible.
To reproduce run this gist in python2 and python3.
I currently don't know what the solution to this would be.

Can you give the full stacktrace?

python new.py --noauth_local_webserver
Traceback (most recent call last):
  File "new.py", line 92, in <module>
    send_message(message)
  File "new.py", line 82, in send_message
    message = service.users().messages().send(userId='me', body=message).execute()
  File "/Users/basnijholt/anaconda/lib/python3.5/site-packages/googleapiclient/discovery.py", line 764, in method
    actual_path_params, actual_query_params, body_value)
  File "/Users/basnijholt/anaconda/lib/python3.5/site-packages/googleapiclient/model.py", line 151, in request
    body_value = self.serialize(body_value)
  File "/Users/basnijholt/anaconda/lib/python3.5/site-packages/googleapiclient/model.py", line 260, in serialize
    return json.dumps(body_value)
  File "/Users/basnijholt/anaconda/lib/python3.5/json/__init__.py", line 230, in dumps
    return _default_encoder.encode(obj)
  File "/Users/basnijholt/anaconda/lib/python3.5/json/encoder.py", line 198, in encode
    chunks = self.iterencode(o, _one_shot=True)
  File "/Users/basnijholt/anaconda/lib/python3.5/json/encoder.py", line 256, in iterencode
    return _iterencode(o, 0)
  File "/Users/basnijholt/anaconda/lib/python3.5/json/encoder.py", line 179, in default
    raise TypeError(repr(o) + " is not JSON serializable")
TypeError: b'Q29udGVudC1UeXBlOiB0ZXh0L3BsYWluOyBjaGFyc2V0PSJ1cy1hc2NpaSIKTUlNRS1WZXJzaW9uOiAxLjAKQ29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogN2JpdAp0bzogYmFzbmlqaG9sdEBnbWFpbC5jb20KZnJvbTogYmFzbmlqaG9sdEBnbWFpbC5jb20Kc3ViamVjdDogVGVzdAoKVGV4dA==' is not JSON serializable

you can probably just do message = message.decode('utf-8') and be fine.

@jonparrott indeed!
This works:
base64.urlsafe_b64encode(message.as_string().encode('utf-8')).decode('utf-8')

I ran into this as well, and google is erroring for me.
Trace:
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/my/amazing/path", line 36, in _send_message
    message = (self.service.users().messages().send(userId=email, body=body)
  File "/path/to/venv/python3.8/site-packages/googleapiclient/_helpers.py", line 134, in positional_wrapper
    return wrapped(*args, **kwargs)
  File "/path/to/venv/python3.8/site-packages/googleapiclient/http.py", line 907, in execute
    raise HttpError(resp, content, uri=self.uri)
googleapiclient.errors.HttpError: <HttpError 400 when requesting https://www.googleapis.com/gmail/v1/users/email%40gmail.com/messages/send?alt=json returned "Bad Request">

Relevant code:
userID = 'my email'
message = MIMEMultipart('alternative')
message['to'] = to
message['from'] = sender
message['subject'] = subject

part1 = MIMEText(message_text, 'plain')
part2 = MIMEText(message_html, 'html')
message.attach(part1)
message.attach(part2)
body = {'raw': base64.urlsafe_b64encode(message.as_string().encode('utf-8')).decode('utf-8')}
self.service.users().messages().send(userId=userID, body=body).execute()


crypto: "error Never include this file directly. Use <lzma.h> instead." during test

Hi,
We just got the following report, https://youtrack.jetbrains.com/issue/GO-5653, on our issue tracker but I believe this is a Go issue.
By the looks of it, the user is using at least Go 1.10 on a macOS. I suspect this has something to do with the fact that we force Go to compile the test binary with -gcflags="all=-N -l" in order to improve the debugging experience for the users.
Thank you.
OS: Mac OS X (10.13.4, x86_64)
GOROOT=/usr/local/go
GOPATH=/Users/xueqzhan/source/go

/usr/local/go/bin/go test -c -o /private/var/folders/fx/2f29vz253_z8grcj9cbkq3jw0000gn/T/___TestFollowerOnly_in_planner_scheduler_election -gcflags "all=-N -l" planner-scheduler/election

# crypto/x509
In file included from /usr/local/go/src/crypto/x509/root_cgo_darwin.go:16:
In file included from /System/Library/Frameworks/CoreFoundation.framework/Headers/CoreFoundation.h:43:
In file included from /System/Library/Frameworks/CoreFoundation.framework/Headers/CFBase.h:72:
/usr/local/include/Block.h:16:3: error: Never include this file directly. Use <lzma.h> instead.
#       error Never include this file directly. Use <lzma.h> instead.
        ^
1 error generated.

Compilation finished with exit code 2

@dlsniper can we tell what version of CoreFoundation.framework source code they're on?
I don't have a /usr/local/include/Block.h on my OSX (10.13.4) install.

Unfortunately, I cannot. However, I asked the user about this: https://youtrack.jetbrains.com/issue/GO-5653#comment=27-2855172

I get same error when I copy Applications from one Macbook to another , maybe the copy that overlay the "/usr/local/include" dir , so move it and use global librarys .
you can execute :
sudo mv /usr/local/include /usr/local/include_old
and try again

pI have same issue too.
Can someone tell us which way we should go?

close
发自我的 iPhone

在 2018年5月11日，14:12，David Wang<EMAIL_ADDRESS>写道：
pI have same issue too.
Can someone tell us which way we should go?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

sudo mv /usr/local/include /usr/local/include_old

@cc14514 This solved my issue. Thank you so much :)

Why doesn't Apple's migration assistant take care of something like this???? Thank you for posting.

cc @FiloSottile several users seem to be running into this.

@cc14514    How did you know about this solution? It has been bothering me for a long time. thank you very much.

I get same error when I copy Applications from one Macbook to another , maybe the copy that overlay the "/usr/local/include" dir , so move it and use global librarys .
you can execute :
sudo mv /usr/local/include /usr/local/include_old
and try again

Thanks, solved my issues too!

I get same error when I copy Applications from one Macbook to another , maybe the copy that overlay the "/usr/local/include" dir , so move it and use global librarys .
you can execute :
sudo mv /usr/local/include /usr/local/include_old
and try again

Works perfectly! Just migrated to my new machine and came across the issue when I ran a Swift script. Thanks again.

@cc14514 This solved my issue. Thank you so much :)

I'm glad to help you.

@cc14514 How did you know about this solution? It has been bothering me for a long time. thank you very much.

you are welcome, It's been bothering me for a long time too.

I'm glad to help you all.

In case you don't want to mess with the whole /usr/local/include directory - you can also just rm /usr/local/include/block.h

It helped me a lot, thanks very much.

The crypto/x509 darwin cgo code was deleted entirely only the other day in CL 232397. That will be part of go1.16 so this issue should be fixed now for the next release.

Yay!


Handle spread props in jsx-no-target-blank rule

When running the jsx-no-target-blank rule against code like the following:
<a {...this.props} target='_blank' />

the following error would be raised:
TypeError: Cannot read property 'name' of undefined

The root cause is that the node representing the spread props does not have a name property.
Note that if the desired rel attribute appears before the spread props, the error does not occur.

Merged, thanks!


Some findings

File packagedoc\additional_docs\Description.rst exists, but is not referenced in packagedoc\packagedoc_config.json

Contradictory license information in several files (Apache/BIOS). Needs to be aligned.

Meaning of files README_orig.rst and setup_orig.py needs to be clarified.

INSTALLREQUIRED/requirements.txt needs to be reviewed.

Hi Cuong,
what is the status here?
Thank you,
Thomas


No navigation sidebar/menu on mobile

Tested on Android:

Firefox 59.0.2
Chrome 65.0.3325.109

At the bottom of each page, it'd be good to provide a link to the next page/section. This would make navigation easier on mobile devices.

dup of https://github.com/steveklabnik/doxidize/issues/39, thanks!


[SPARK-24640][SQL] Return NULL from size(NULL) by default

What changes were proposed in this pull request?
Set the default value of the spark.sql.legacy.sizeOfNull config to false. That changes behavior of the size() function for NULL. The function will return NULL for NULL instead of -1.
Why are the changes needed?
There is the agreement in the PR https://github.com/apache/spark/pull/21598#issuecomment-399695523 to change behavior in Spark 3.0.
Does this PR introduce any user-facing change?
Yes.
Before:
spark-sql> select size(NULL);
-1

After:
spark-sql> select size(NULL);
NULL

How was this patch tested?
By the check outputs of expression examples test in SQLQuerySuite which runs expression examples.

@HyukjinKwon @cloud-fan @gatorsmile Please, take a look at the PR.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16860/
Test PASSed.

Test build #111880 has started for PR 26051 at commit a8a0a98.

Test build #111880 has finished for PR 26051 at commit a8a0a98.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111880/
Test PASSed.

Merged to master.

@MaxGekk Could you submit a follow-up PR to update the migration guide?

Here is the PR https://github.com/apache/spark/pull/26066 which updates the SQL migration guide.


Fix volume mismatch in Node.js guide

Proposed changes
Node.js guide  uses /app path in the Build Images step. Whereas develop your app step used /code. This PR fixes the mismatch and uses /app on both pages. (Note: Python uses /app on both pages, that's why I chose to keep /app.
Unreleased project version (optional)

Related issues (optional)
Related https://github.com/docker/docker.github.io/issues/12329

@david-szabo97 Thank you. I was testing the tutorial and saw that file changes didn‘t work. Your change fixes this.


Don't display food and drink image if not present

We will be supplying these from ES. If no image exists, we should not show one.

:+1:


Pull strategy for the Private participants

Closes https://github.com/poanetwork/dpos-token/issues/39

I tried to briefly review the pull-strategy branch. Here are the first notes (regarding only the PrivateOfferingDistribution contract as I haven't reviewed another changes yet):

onTokenTransfer should return true.

I think we don't need in ERC677Receiver interface.

I think we need to extend the withdraw function so that it would allow transferring zero address share to address(0). For withdrawing to address(0) that should be called by an owner.

Here we should see an exception thrown on these lines, please check it through test: https://github.com/poanetwork/dpos-token/blob/441b97d5815450c632f1da2249e16feb0390dba0/contracts/PrivateOfferingDistribution.sol#L69-L70

To save gas, we don't need to have the stakes array because we already have participantStake mapping: https://github.com/poanetwork/dpos-token/blob/441b97d5815450c632f1da2249e16feb0390dba0/contracts/PrivateOfferingDistribution.sol#L33

The private participants array should have a public getter: https://github.com/poanetwork/dpos-token/blob/441b97d5815450c632f1da2249e16feb0390dba0/contracts/PrivateOfferingDistribution.sol#L32

The mappings should also be public: https://github.com/poanetwork/dpos-token/blob/441b97d5815450c632f1da2249e16feb0390dba0/contracts/PrivateOfferingDistribution.sol#L35-L38

The maxBalanceForCurrentEpoch should be public.

I think the setDistributionAddress should have require(distributionAddress == address(0)); to restrict setting the address of Distribution contract more than once.

Let's measure how much gas will be consumed for 100 participants by the constructor.

Please also review and update README.md.

Let's read PrivateOffering amount from the PrivateOfferingDistribution.TOTAL_STAKE constant instead of the hard-coded duplicated stake[PRIVATE_OFFERING] = 8500000 ether; in the Distribution contract.

Let's add revert() into the PrivateOfferingDistribution.onTokenTransfer for the case when _from != distributionAddress to prevent sending tokens not from the Distribution contract.
And add initialized modifier for the withdraw function.

Let's add require(IDistribution(_distributionAddress).supply == 100000000 ether) to the PrivateOfferingDistribution.setDistributionAddress to make sure we didn't mistake with the address of the contract.

Let's add a Withdrawn event for the PrivateOfferingDistribution.withdraw function.

Let's add unit tests for the withdraw and burn functions of the PrivateOfferingDistribution contract and update the README.

Seems something's wrong with one of the unit tests:

Please add a test for PrivateOffering which would check the participants list in case when we call addParticipants more than once.

Let's add ParticipantsFinalized event.

Please recheck unit tests. There are no tests for the next cases:
addParticipants: can only be called by an owner
finalizeParticipants: can only be called by an owner
getParticipants: should return correct array after addParticipants is called more than once
sumOfStakes: should return correct value after addParticipants is called more than once
initialize: should fail if participants are not finalized
setDistributionAddress: should be set should check the distributionAddress getter and DistributionAddressSet event

Please add unit tests for PrivateOfferingDistribution.onTokenTransfer.

It's very important to add require(msg.sender == address(token)); to the PrivateOfferingDistribution.onTokenTransfer because the current implementation can be called by anyone. Please also add unit tests for that requirement.

Let's add .call to unit tests to run npm run coverage successfully.


Stuck on first slide

When using slick slider, it appears that it can take upto 1 minute for the second slide to be shown despite having set autoplay to true and the slide delay to 6 seconds.
It is behaving like this on the following site:
http://thamesideroofing.co.uk
What is the expected behaviour?
As previously mentioned the slider should slide after 6 seconds but gets stuck sometimes.
Happens reportedly on Firefox and chrome.

Reduced test case please.


Deploying multiprocess setup with new job defined

Hello, thanks for the awesome gem!
I've recently discovered a problem during the deployment of the sidekiq-cron
Let's go with the following case step by step:

At the same commit I modified the schedule.yml and added a new Sidekiq job that is used there

class MyBrandNewJob < ApplicationJob
...
end

config/schedule.yml
run_unknown_job_queue:
  cron: "* * * * * UTC"
  class: MyBrandNewJob

We have 2 nodes, nodeA and nodeB
I'm trying to deploy this change to my sidekiq servers using Rolling Restart powered by Sidekiq Enterprise, which restarts servers one by one.
NodeA is restarted and a new configuration with MyBrandNewJob is persisted into Redis
NodeB is picking up new configuration from redis and trying to enqueue job that doesn't present in the code MyBrandNewJob.
Sidekiq-cron itself is tolerant for such cases and doesn't crash, but there are middlewares (example of open source sidekiq-grouping and our custom ones) that doesn't expect that. Most sidekiq middleware developers assume that the passed class exists and can be loaded.

I personally see a solution to split the code into PRs, firstly add the job and only then configure the schedule on modification.
 Do you have any suggestions on how this problem could be approached?
Thanks in advance!

Thank you @markets! I think I can close this issue then.


fix: account for services with empty valid_days

Problem: instead of selecting weekday service as the default on a weekday, we were finding cases where Saturday is selected instead.
This seems to be happening when the typical weekday service that should be selected happens to have an empty value for valid_days. One example (typical weekday service for the 1 bus): https://api-v3.mbta.com/services/BUS422-hbc42cl1-Wdy-02
This PR: When evaluating whether a given service is "current": for services where valid_days is an empty array, skip the valid day check. This falls back to instead checking whether the service is within the rating dates, which should generally produce a favorable result.

Revised comment: We were filtering out too many services in some cases where there were multiple services covering the same start/end dates but differing by applicable valid_days. Latest commit compares the valid_days in order to determine whether services are actually overlapping.
This produces successful display of the Weekday schedule for the 505 bus and successful selection of the relevant schedule (today, the "Monday-Thursday" schedule) for the 1 bus -- deploying on dev-green now so we can QA more cases.

Targets this Asana ticket: Saturday service selected by default for some bus routes

TL;DR: Current state of this PR isn't perfect, but it would allow riders to view weekday schedules on some routes they currently can't. I think we should deploy as-is today unless there's an obvious and quick fix.
I tested the latest version of this on dev-green just now, comparing the top 20 most visited bus route schedules over the last week to production. I also tested the 501 and 505, which were known to be a problem before the initial fix to handle these split weekday schedules.
The current state of production for the routes listed in the Asana task is different now than it was 12 days ago. At that time the weekday schedule was an option, but not selected by default. Today, the weekday schedules are no longer presented as options for routes like 1, 47, and 66.
From what I've tested again and the service patterns we saw two weeks ago, this implementation:

displays different Monday-Thursday and Friday weekday options for routes that have M-R and F services but not M-F (e.g., 1, 47, 66)
displays a single weekday option for routes that have M-R, F, and M-F services as well as weekend services (e.g., 8, 57, 60)
displays a single weekday option for routes that have M-R, F, and M-F services but no weekend services (e.g., 501, 505, CT2)

Ideally those routes with service patterns like 47 or 66 would display a single weekday option, but presenting multiple options is better than none. Can we get this deployed today and come back again for another round of polish and testing later?
Quick links:

missing weekday on prod: https://www.mbta.com/schedules/1/line?schedule_finder[direction_id]=0&schedule_finder[origin]=place-nubn
split weekdays on dev-green: https://dev-green.mbtace.com/schedules/1/line?schedule_finder[direction_id]=0&schedule_finder[origin]=place-nubn


Change default value for trimSpaces attribute on query senders from true to false

Related Problem or Business Case
It often occurs that Frank developers find themselves confused about the query senders trimming spaces by default. Especially during investigation of production incidents, its quite hard to figure out that values are trimmed by the query sender.
In 99% of the cases you actually don't want the spaces to be trimmed and you'd have to remember yourself everytime you write a query sender with a SELECT statement that you have to set the trim spaces attribute to false.
See the following issue reports as examples:
#7245
#3402
#992
Describe the Feature
Change default value from true to false.
Collaboration with External Companies
No, community resolution only
Anything else?
No response

We don't think changing a default value is a good solution. We will implement a better way to document this behavour.


Improved error message

Description
Improved error reporting on malformed v2 module
closes #3797
Self Check:
Strike through any lines that are not applicable (~~line~~) then check the box

[x] Attached issue to pull request
[x] Changelog entry
[x] Type annotations are present
[x] Code is clear and sufficiently documented
[x] No (preventable) type errors (check using make mypy or make mypy-diff)
[x] Sufficient test cases (reproduces the bug/tests the requested feature)
[x] Correct, in line with design

Processing this pull request

Merged into branches master, iso5 in d56a1b361dd3bec6cf04d18606888c748f721f65


Add ignore attribute on an index

Problem
Currently, if you add an index to a table without a reference in the model, it will be marked for removal in a following migration. Some indices are out of scope of the index (ie. an index with an expression).
Suggested solution
Adding an ignore attribute on an index would allow db admins to ignore a specific index and manage it outside of the model.
Alternatives
@@ignore on an index... however attributes work on fields and models.
Additional context
Currently, when I try to create a new migration while a custom index exists, I get the following message:
[*] Changed the `...` table
  [+] Added index on columns (...)

✔ We need to reset the PostgreSQL database "..." at "localhost:5432".
Do you want to continue? All data will be lost. …

Also, the generated migration will have a query to drop the index.

Would adding support for indexes with expressions be the better solution here? Please search our issues to make sure the type of index this applies to is adequately represented with a feature request already.

I think this feature could act as a stop gap measure when Prisma is missing a feature for indices in general.

@janpio I suspect no. There will almost always be gaps or new features between what Prisma supports and what the latest SQL database engines support. A great examples is:

#18442

Where even though the Vector type can be used via Unsupported, indexes cannot be maintained in migrations because the ivfflat index type and WITH (lists = ...) clause is not supported.

@janpio
I am using pgvector as an extension with Prisma. I want to utilize the HNSW index with pgvector version 0.5.1. Since such an implementation was not supported in the schema, I manually created a migration file and wrote the create index command.
CREATE INDEX ON "Vector" USING hnsw (embedding vector_cosine_ops);

However, when I attempt to migrate, the shadow database outputs an error because it does not recognize the unsupported type for the embedding column as having dimensions.
npx prisma migrate dev
Environment variables loaded from .env
Prisma schema loaded from prisma/schema.prisma
Datasource "db": PostgreSQL database "sample", schema "public" at "localhost:5432"

Error: P3006

Migration `20231107144953_hogehoge` failed to apply cleanly to the shadow database.
Error:
ERROR: column does not have dimensions
   0: schema_core::state::DevDiagnostic
             at schema-engine/core/src/state.rs:270

Using HNSW is urgent, and I would like to skip the checks done by the shadow database.
Is there any good way to do this?

No. Please open a new issue so we can figure out why the shadow database does think that this column does not have dimensions.

I would recommend using OpenAI assistants API with built-in RAG. There is no need for a vector store anymore. :)


Kissanime search doesn't work at all

(See the image)
In this example I tried searching for Naruto,but it returned an anime not related to it.

did you try it without add the provider param?  just anime dl 'Naruto'

Is this still hapenning? If yes use the rewrite branch and post the output of the log.

Yup,(sorry but how do I use the rewrite branch??)

@Arnav71 in github go to the code tab and change the branch dropdown.  you can download that code and run the program from the new folder

@vn-ki i did this:
pip uninstall anime-downloader
pip install git+https://github.com/vn-ki/anime-downloader.git@rewrite#egg=anime-downloader[cloudflare]
anime dl --provider kisscartoon -xd "{aria2}" hotel
and got this:
ERROR: No module named 'anime_downloader.commands'
Guess I'm not sure how to run the rewrite branch either

This is probably fixed in master. If not please reopen


The width and height property of the HTML element

Is there a possibility of having a width and height property for the HTML document/element as there are in javascript:
https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement.offsetWidth
https://developer.mozilla.org/en-US/docs/Web/API/Element.clientWidth
Such that one can know the width or height if the document is to converted to some other format.
Or is there any workaround to deduce this with the current implementation?

Any update on this now ?


Minor VaporeMons fixes

Keeping as a draft until I can test one thing, might not re-open until VaporeMons Slate 8 ends idk

Added VaporeMons Slate 8, can be merged now


How to use P12 files to send pushes

How do I fix this? What is going on here? What am I missing?

I am using a P12 generated the same way as this tutorial: https://youtu.be/jq42brrSg28
Here is what my code looks like:
const apn = require('apn');

async function test() {

  // ⚠ This token is valid and from an actual iOS device with the same bundle id
  var deviceToken = 'f6209a7b84f17e4fa601e2a37b53937ff2843c24cc86eee2b7f1a0393555fbe3';

  var apnProvider = new apn.Provider({
    pfx: 'Certificates.p12',
    passphrase: 'password',
    production: false
  });

  let notification = new apn.Notification();

  notification.alert = {
    title: 'Hey',
    body: 'Whats up'
  };

  const res = await apnProvider.send(notification, deviceToken)
  console.log(res)

}

test()

I get the following error in the console when running:
{
  sent: [],
  failed: [
    {
      device: 'f6209a7b84f17e4fa601e2a37b53937ff2843c24cc86eee2b7f1a0393555fbe3',
      error: Error: unsupported
          at configSecureContext (node:internal/tls/secure-context:277:15)
          at Object.createSecureContext (node:_tls_common:117:3)
          at Object.connect (node:_tls_wrap:1629:48)
          at Endpoint.connect [as _connect] (/Users/xxx/Desktop/Folders/test/node_modules/apn/lib/protocol/endpoint.js:87:37)
          at new Endpoint (/Users/xxx/Desktop/Folders/test/node_modules/apn/lib/protocol/endpoint.js:44:10)
          at EndpointManager.createEndpoint (/Users/xxx/Desktop/Folders/test/node_modules/apn/lib/protocol/endpointManager.js:51:22)
          at EndpointManager.getStream (/Users/xxx/Desktop/Folders/test/node_modules/apn/lib/protocol/endpointManager.js:32:12)
          at /Users/xxx/Desktop/Folders/test/node_modules/apn/lib/client.js:121:43
          at new Promise (<anonymous>)
          at Client.getStream (/Users/xxx/Desktop/Folders/test/node_modules/apn/lib/client.js:120:12)
    }
  ]
}

Why is this error happening?

Anybody know what's going on here?

I can confirm that I've also observed the issue, but on Node 18, but not on Node 16 or 14.

This is a node 18 issue. Thanks @mtrezza. Downgrading to node 16 works.
Would still be nice to find a working solution for node 18

To be exact, it's more a certificate cipher issue than a Node issue.

"An 'error: unsupported' message may occur in Node.js 17 RC2 because the legacy OpenSSL provider is disabled by default. If you enable the --openssl-legacy-provider flag, it should work as expected."
Ref:- https://github.com/nodejs/node/issues/40672
How to enable flag:- node --openssl-legacy-provider index.js(Root file)

Anybody know what's going on here?

You have to enable --openssl-legacy-provider

try this for Node 18, https://github.com/dchahla/easy-apn

As a workaround: Instead of using the .p12 you can use the certificate and key you used to generate the p12.
cert: "./certs/signerCert.pem",
key: "./certs/signerKey.pem",
passphrase: "yourPW"

Just in case you are like me and generate the p12 in Mac Keychain.
For me following these steps made the p12 work for me.
https://www.docuseal.com/docs/convert-legacy-p12-pfx-files-to-support-openssl-3


[FEA] Better Memory Management for BroadcastNestedLoopJoin

For #296 BroadcastNestedLoopJoin is going to be disabled by default because of the potential for a memory explosion.  Before we can enable it by default we need a much better way to do memory management for it.
Some of the ideas that I had are.

Have CoalesceBatches take a function instead of a hard value and use the schema + broadcast size to avoid combining data together if we are just going to have to split it apart later anyways.
Implement batch splitting so we can take the size of both input batches and guess as to what the size of the produced output would be. If it is too large then we can split the streamed batch up into smaller batches to try and avoid using too much memory. This one might get a little hard, because we have to manage the partial batch along with the new batch that we are trying to produce.  We need to do some experiments to see if we want to actually split the incoming batch into smaller pieces, which probably requires a kernel launch and extra memory buffers vs using a zero copy slice which would require some code changes to the CUDF APIs to be able to support this. Some of this code can probably be reused for #45

There are only two join types were we could split the broadcast table and those are covered by CarteseanExec.  In all other cases if we wanted to split the broadcast table we would need some help from cudf to support it.

My preference would be approach#1 since it gives us more control.

I think we need both

Hi @revans2, I have some questions about the first approach. Does it applied on the broadcast table? And what kind of function the CoalesceBatches should take? Thank you!

Currently we only support inner joins for this. It means that each join is going to do a full cross join, optionally followed by a filter. In this case, inner joins, Spark will insert a BroadcastNestedLoopJoin iff it estimates that the size of the build table is small enough that it fits in the auto-broadcast threshold.  Otherwise it will fall back to a CartesianProductExec.  So even though we could split up the build table Spark and the user think it is small enough that we should not need to. Also if we did split up the build table we would need to change the algorithm so it matched more closely to what CartesianProductExec is doing.
A cross join produces rows where everything on the left is combined with everything on the right.  100 rows on the left and 5 rows on the right produces 500 rows of output.  So we can guess at the output size with
output_rows = left_side_rows * right_side_rows
approximate_row_size = left_side_bytes/left_side_row + right_side_bytes/right_side_rows
approximate_output_size = output_rows * approximate_row_size
approximate_output_size = left_side_rows * right_side_rows * (left_side_bytes/left_side_row + right_side_bytes/right_side_rows)
approximate_output_size = (left_side_bytes * right_side_rows) + (right_side_bytes * left_side_rows)

In query planning we can estimate the size of each row based off of the schema. We can estimate the size of the broadcast based off of the autoBroadcastThreashold config. We can also set our target output size based off of gpuTargetBatchSizeBytes.
So for the CoalesceBatch we can start out with a default value of something like.
approximate_output_size = (left_side_bytes * right_side_rows) + (right_side_bytes * left_side_rows)
gpuTargetBatchSizeBytes = (left_side_rows * estimate_left_row_size * (autoBroadcastThreashold/estimated_right_row_size)) + (autoBroadcastThreashold * left_side_rows)
gpuTargetBatchSizeBytes = left_side_rows * ((estimate_left_row_size * autoBroadcastThreashold/estimated_right_row_size) + autoBroadcastThreashold
left_side_rows = gpuTargetBatchSizeBytes/((estimate_left_row_size * autoBroadcastThreashold/estimated_right_row_size) + autoBroadcastThreashold
target_left_side_bytes = left_side_rows * estimated_left_row_size

Once we have real numbers for the build table and the batch that showed up we can then decide if we need to split up the input table or not.

Thanks for so detailed explanation. I am trying to understand it.
So, we decide whether to split up the stream table (and the split size) according to above estimation formula?
If I am not wrong, the formula above is to ensure the batch size of cross join's outputs doesn't exceed the gpuTargetBatchSizeBytes?
And I also found that BroadcastNestedLoopJoin can be run without  CoalesceBatches, like below plan:
GpuColumnarToRow false
+- GpuBroadcastNestedLoopJoin BroadcastNestedLoopJoin BuildRight, Cross, Cross,<PHONE_NUMBER>
   :- GpuRowToColumnar TargetSize(2147483647)
   :  +- LocalTableScan [longs#7L, more_longs#8L]
   +- GpuBroadcastExchange IdentityBroadcastMode, [id=#28]
      +- GpuRowToColumnar TargetSize(2147483647)
         +- LocalTableScan [longs#18L, more_longs#19L]

The math I did was just quick back of the envelope math.  If you can come up with a better estimate for splitting the data then that is fine. Also please check my math, I am not 100% sure that it is correct.
The plan you showed is the typical plan.  The build table comes from a GpuBroadcastExchange.  The data for that table is already concatenated together.  In theory we could split it up into smaller pieces and join each of them with each of the stream batches (cross product) but since the size of the broadcast is likely to be small (10MB by default) then that hopefully means that we can split the stream data into similarly small pieces.

Closing as won't fix for now


Support arrays

Hi :)
We have a few private resources which I want to generate L1 constructs for.
For some of them I get always the same error:
Unsupported type {"type":"array","items":{"type":"string"}} for read-only property (attribute) PRIVATE::PRIVATE::Shared.Subnets

The properties of the schema look like this:
  "properties": {
    "Id": {
      "description": "unique identifier",
      "type": "string"
    },
    "VpcId": {
      "description": "id of the vpc",
      "type": "string"
    },
    "Subnets": {
      "type": "array",
      "items": {
        "type": "string"
      }
    }
  },

Therefore for me it looks like arrays are not supported yet.
Is that assumption correct? Could it be implemented?
edit: Looking at https://github.com/cdklabs/cdk-import/blob/45d0fbb626d25c88bb445b4b5174cbf2e9728692/src/cfn-resource-generator.ts#L185 it looks like it should work.. Any hints on how to debug this better?
edit2: Found it!
Adding && def.type !== 'array' to https://github.com/cdklabs/cdk-import/blob/45d0fbb626d25c88bb445b4b5174cbf2e9728692/src/cfn-resource-generator.ts#L47 solves it for me.
It gets properly resolved via this.attrSubnets = cdk.Token.asList(this.getAtt('Subnets'));
What do you think about fixing that? Did I miss something?

Hi @madeline-k I saw you merging my other pull request.
Could you have a quick look at this one too? A fix is already included :)


bugfix: 因Gse升级导致升级Proxy失败 (fixed #170)

Codecov Report

Merging #172 (1467f93) into V2.1.348rc (4b4b5d9) will increase coverage by 2.95%.
The diff coverage is 33.33%.

@@              Coverage Diff               @@
##           V2.1.348rc     #172      +/-   ##
==============================================
+ Coverage       58.91%   61.86%   +2.95%
==============================================
  Files             395      224     -171
  Lines           25944    19413    -6531
==============================================
- Hits            15284    12010    -3274
+ Misses          10660     7403    -3257

Impacted Files
Coverage Δ

apps/backend/components/collections/agent.py
75.00% <33.33%> (-0.28%)
:arrow_down:

apps/utils/periodic_task.py
42.85% <0.00%> (-17.15%)
:arrow_down:

apps/node_man/handlers/plugin_v2.py
58.00% <0.00%> (-7.52%)
:arrow_down:

apps/backend/plugin/tools.py
93.68% <0.00%> (-3.91%)
:arrow_down:

apps/utils/env.py
44.44% <0.00%> (-3.18%)
:arrow_down:

apps/utils/basic.py
64.47% <0.00%> (-1.44%)
:arrow_down:

apps/node_man/models.py
73.11% <0.00%> (-0.96%)
:arrow_down:

apps/backend/components/collections/job.py
80.84% <0.00%> (-0.31%)
:arrow_down:

apps/node_man/handlers/job.py
86.07% <0.00%> (-0.28%)
:arrow_down:

... and 230 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b4b5d9...1467f93. Read the comment docs.


Support custom event ingests

Link
https://github.com/Rapptz/discord.py/issues/6711

I think this is a cool idea although it needs to be implemented differently. How about discord.internals.event and discord.internals.opcode decorators?

this seems kinda out of scope for this library
custom events can be used with bot.dispatch("event", *args, **kwargs)
as for whatever that linked one is about, seems too complex for a niche


YD.Download() throwing ECONNREFUSED Error

When I use the example script to try to get an MP3 when it reaches YD.Download() it throws an error stating:
connect ECONNREFUSED <IP_ADDRESS>:80
I have tried troubleshooting but I cannot figure out why it isn't working.

The example doesn't do calls to <IP_ADDRESS> on port 80. So what exactly have you changed?

I don't believe I changed anything, but I deleted and re-installed youtube-mp3-downloader and it now works.