Support arbitrary delimiters

The S3 protocol supports arbitrary delimiters when asking to list objects. In other words, when using S3, you can pretend that something besides "/" separates path elements by asking to list all paths with a shared prefix up to a next delimiter of any type. Storj uses the forward slash as an encryption element delimiter, so it doesn't make a ton of sense for us to allow arbitrary delimiters in normal use cases. However, this means that we are incompatible with S3 for some applications.
We explicitly disable support for arbitrary delimiters here: https://github.com/storj/gateway-st/blob/9768ca244e4fd356ba46abd36dc2de805d53a46a/miniogw/gateway.go#L211-L213
A recent consequence of this is that we are incompatible with Cockroach's backup tool. https://github.com/cockroachdb/cockroach/issues/69165
Cockroach is probably not the last tool we won't work with, so as that Cockroach ticket points out, it's probably preferable we are slow over broken. So, we should mimic arbitrary delimiter support by listing recursively and then filtering. We will have to do this client-side because the arbitrary delimiter will be processed on the paths prior to encryption, so there won't be any opportunity for Satellite-side optimization.
Since this only applies to things trying to use us like S3 (libuplink doesn't have a delimiter option at all), the gateway-st miniogw package is the right place for this (as gateway-st and gateway-mt will pick it up).
tl;dr: miniogw's ListObjects method should, when given a delimiter besides "/" or "", internally list all objects, then filter down to the provided delimiter, mimicking support for arbitrary delimiters.

cc @amwolff (thanks for the original cockroach ticket filing!) and also https://storjlabs.atlassian.net/browse/IN-607

Upvote for this. It would be super nice to have that functionality. But I am a bit confused with the next things:
aws --endpoint-url=https://gateway.eu1.storjshare.io s3 cp s3://<bucket> . --recursive --exclude "*" --include "<one>" --include "<two>" --profile storj works like a charm but when I am trying to do the same through .net SDK
  new ListObjectsRequest    {        BucketName = resp.Buckets.First().BucketName,        Delimiter = "*",        Prefix = "<one>*<two>"     }
I got error:
A header you provided implies functionality that is not implemented

Change https://review.dev.storj.io/c/storj/gateway/+/6434 mentions this issue.

@OlegOLK I believe the reason the former works and the latter doesn't is that in the first case, AWS CLI lists the whole bucket and filters it locally. Amazon's implementation of S3 doesn't support filtering using wildcards, and Storj's Gateway-MT and Gateway-ST also don't support it. So even if you tried it against, e.g., AWS S3, it would give you results different from the first command you posted. Fortunately, filtering by prefix and delimiter can be pretty powerful, too, and support for that in Gateway-MT and Gateway-ST is coming!

Here is good news: the arbitrary prefix and delimiter support (or making the ListObjects and ListObjectsV2 actions fully S3-compatible) should be in the next Gateway-ST release (13th of December). For Gateway-MT, it should be there after the production deployment.
Here's the changeset associated with this issue:

https://review.dev.storj.io/c/storj/gateway/+/6434
https://review.dev.storj.io/c/storj/gateway/+/6448
https://review.dev.storj.io/c/storj/gateway/+/6449
https://review.dev.storj.io/c/storj/gateway/+/6450
https://review.dev.storj.io/c/storj/gateway/+/6452


No Support for the Nacon Revolution pro controller ??

I just go the Nacon Revolution pro ps4 controller but it does not get picked up in the ds4 windows app please help it was really expensive and i cant return it

Hopefully the only problem is a different VID + PID combination being used by the device that DS4Windows is not looking for. Is the Nacon Revolution detected by Windows as a game controller? Can you access the controller properties in Device Manager and check the VID and PID, and maybe REV, of the HID-compliant game controller?

Hi thanks for the quick reply , the controller is picked up by windows as a
game controller i found the information you were looking for and i added a
snip of it as an attachment to this email
On 11 Mar 2017 20:51, "Travis Nickles"<EMAIL_ADDRESS>wrote:

Hopefully the only problem is a different VID + PID combination being used
by the device that DS4Windows is not looking for. Is the Nacon Revolution
detected by Windows as a game controller? Can you access the controller
properties in Device Manager and check the VID and PID, and maybe REV, of
the HID-compliant game controller?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Jays2Kings/DS4Windows/issues/275#issuecomment-285891411,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AZIKTICFUWjIfJ3iue1LfwJ7MOOW3Klqks5rku06gaJpZM4MaQAy
.

It didn't go through. It would probably be better to share that using Dropbox or Google Drive.

https://drive.google.com/file/d/0B-MLxB4feTfxd2FGMWo4NHVIb1ZpNHR2YlpBb1JHLW5kWmhV/view?usp=drivesdk
On 12 Mar 2017 00:02, "Travis Nickles"<EMAIL_ADDRESS>wrote:

It didn't go through. It would probably be better to share that using
Dropbox or Google Drive.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Jays2Kings/DS4Windows/issues/275#issuecomment-285903563,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AZIKTDP56MDq7JTAOsiPMyaWhLe1RDCyks5rkxnzgaJpZM4MaQAy
.

Neither the VID nor PID were included in the device search routine. I have changed DS4Windows to include the VID and PID of the Nacon Revolution controller in its search. As long as the HID reports are the same as a standard PS4 controller then it should work.
https://dl.dropboxusercontent.com/u/31073509/DS4Windows_Test_20170311.zip

I tried the new Application however the controller is still not being
recognized by DS4Windows is there anyway i could check the HID reports and
give you the information ?
On Sun, Mar 12, 2017 at 1:36 AM, Travis Nickles<EMAIL_ADDRESS>wrote:

Neither the VID nor PID were included in the device search routine. I have
changed DS4Windows to include the VID and PID of the Nacon Revolution
controller in its search. As long as the HID reports are the same as a
standard PS4 controller then it should work.
https://dl.dropboxusercontent.com/u/31073509/DS4Windows_Test_20170311.zip
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Jays2Kings/DS4Windows/issues/275#issuecomment-285908995,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AZIKTFn-DxBaZK6ASoUjc3sjxfvSDj0Pks5rkzABgaJpZM4MaQAy
.

Does DS4Windows show anything in the Log tab regarding detecting the controller at all? Even though the code is structured so the device might attempt to read and then remove the device before a log message would appear, there is a chance that DS4Windows would acknowledge that the device is detected before failing to read a report.
I don't know how to obtain the HID report descriptors for a device on Windows; obtaining an HID report descriptor looks like an easier task to perform on Linux. Even with the HID report descriptors, it might be too much work to modify DS4Windows to get it to work with the Nacon Revolution. I was just hoping that the Nacon Revolution would still conform to standard PS4 controller reports so the code would only have to be changed to check for the device.

I understand i found a way to make the controller work using steams generic
controller support it just isn't as nice as using the ds4windows
application, thank you for your help though ill just have to start playing
ps4 again lol.
On 13 Mar 2017 00:07, "Travis Nickles"<EMAIL_ADDRESS>wrote:

Does DS4Windows show anything in the Log tab regarding detecting the
controller at all? Even though the code is structured so the device might
attempt to read and then remove the device before a log message would
appear, there is a chance that DS4Windows would acknowledge that the device
is detected before failing to read a report.
I don't know how to obtain the HID report descriptors for a device on
Windows; obtaining an HID report descriptor looks like an easier task to
perform on Linux. Even with the HID report descriptors, it might be too
much work to modify DS4Windows to get it to work with the Nacon Revolution.
I was just hoping that the Nacon Revolution would still conform to standard
PS4 controller reports so the code would only have to be changed to check
for the device.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Jays2Kings/DS4Windows/issues/275#issuecomment-285980830,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AZIKTLkrEs4KMm5e5TchzgBsZHrilcBAks5rlGyNgaJpZM4MaQAy
.

I have had limited success in getting my Nacon Revolution to work with DS4Windows. Modifying the search routine allows it to detect the controller however it fails to enumerate it with the error "Index was outside the bounds of the array" unless the HID-compliant vendor-defined device (VID_146B&PID_0D01&REV_0100&MI_03&Col02) is disabled in device manager.
With this device disabled it can enumerate the controller (Exclusive mode is sporadic) and everything apart from the touchpad works, although the d-pad is stuck scrolling to the left despite no input being shown in the controller properties. Some games tend to ignore this unless you're trying to use the d-pad whereas it renders others unplayable.
It reports a MAC address of all zeroes in the log (makes sense since it doesn't have bluetooth) and often doesn't appear in the Controller list at all when connected aside from the USB icon.
If I can provide any more information to help iron out these issues I'm more than happy to.

I've managed to resolve the issue with the d-pad and have an updated fork here:
https://github.com/Yuki-nyan/DS4Windows
Everything is now working aside from the touchpad and you no longer need to disable any devices. Would anyone mind giving my code a sanity check? I'm far from a confident programmer and I don't want to submit a pull request if there are any glaring errors.
As far as the touchpad goes, I can see the values changing when I use the debug feature to dump the HID data so I can probably fix it although I'm not sure if I'll be able to do so without affecting compatibility with normal DS4 controllers - my current fork works with either controller.

Nice fork Yuki-nyan (i didn't get through the code i'm not a C# developper) but it make my controller works. But i'm still thinking about sending it back. It depends on the nacon response and if DS4 the your fork in the official release.

Thank you Yuki-nyan, very nice work. Like you said, controller works except for the touchpad. But I still had to disable the device in Device-Manager.

I've managed to get the touchpad working now in a separate branch based off Ryochan7's fork here: https://github.com/Yuki-nyan/DS4Windows/releases/tag/v1.4.67-touchpad
All functions should work, both for original DS4 controllers and the Nacon.

@Yuki-nyan great work there, controller does work fine! I have disconnection issues though but they may have been fixed in @Ryochan7 fork. Maybe you could propose your patch there?

I have a release based on a somewhat recent version of his fork, if you've
tried that and it doesn't work it might be the cable. It seems very weak
near to the ferrite bead at the controller end, I've already had one
replacement after mine stopped working entirely and the new one has
developed an intermittent issue within days.
Let me know how you get on, I might update my version of his fork later on.
On 5 Jun 2017 10:50, "Antoine Bluchet"<EMAIL_ADDRESS>wrote:

@Yuki-nyan https://github.com/yuki-nyan great work there, controller
does work fine! I have disconnection issues though but they may have been
fixed in @Ryochan7 https://github.com/ryochan7 fork. Maybe you could
propose your patch there?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Jays2Kings/DS4Windows/issues/275#issuecomment-306148626,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AYMyq_VYvK11wTqMZ7Xj_1gaIT18xF5jks5sA89dgaJpZM4MaQAy
.

Hey guys, hope some one can help,i have the exact same issue, Windows 10 picks up the controller steam and the calibration tools to except the mouse-pad, just DS4 and none of the games picks up the controller, anyone aware of a fix soon? This is the event i get.
Device USB\VID_146B&PID_0D01&MI_03\7&442eed&0&0003 could not be migrated.
Last Device Instance Id: USB\VID_046D&PID_C52F&MI_01\7&26fd2c6c&0&0001
Class Guid: {745a17a0-74d3-11d0-b6fe-00a0c90f57da}
Location Path:
Migration Rank: 0xF000FFFF0000F120
Present: false
Status: 0xC0000719
Thanks in advance.

@Yuki-nyan I merged your patches with @Ryochan7 recent fixes (https://github.com/Ryochan7/DS4Windows). Everything works great!
here is my fork: https://github.com/soyuka/DS4Windows

I'm confused how do I use your branches in ds4? Or in general how do I use the solutions you guys came up with? I downloaded the files and then what?
any help is welcome same issue as the guy who started the post

@Jon93c use https://github.com/Yuki-nyan/DS4Windows/releases/ or open my fork in Visual Studio and find the "build" menu. After building the exe is available under bin/

@Jon93c use https://github.com/Yuki-nyan/DS4Windows/releases/

Tried this but get the error message "Index was outside the bounds of the array", am I doing it wrong?

About this, Steam does support the Nacon Revolution pro controller!

How can I get it to work on Steam? Doesn't work for me

How can I get it to work on Steam? Doesn't work for me

Got it to work, apparently you first have to enable controller support in the options. Who knew.

Yeah :) ! Was happy when I found this too. Also it's working without issues for me so far.

Hey Guys, can somebody please explain to me what I have to do to get the nacon revolution working, step by step. I downloaded ds4 with the zip files, but it doesn't recognize my nacon I need help please.

please someone help me ds4 doesent reconise my controller i wont even reconise thr normal ps4 controler what do i do

Hi there,i am using a ps4 controller on my PC.It gets connected but when i run DS4 Windows it gives this error 'INDEX WAS OUTSIDE THE BOUNDS OF THE ARRAY'.Please help.Thanks.

Windows recognizes a microphone in the control. In order to function I had to disable it. It worked perfectly there.
https://www.flickr.com/photos/140320798@N05/26558998948

@promailson  Thank you so much, I will try this tonight :)
Didn't think it would recognize a headphone jack as a microphone, but will check tonight;
Im using the wired controller. LOVE IT :) but DS4windows doesn't find it - trying everything possible

Thank you,
I  got this one yesterday:
https://www.takealot.com/nacon-red-wired-compact-controller-ps4/PLID48674042
So I must just check the Windows Microphone/Sound devices? and disable it
there? :) will look in two hours;
On Wed, Aug 15, 2018 at 1:20 PM, Mailson Queiroz<EMAIL_ADDRESS>wrote:

@SativaPhoenix https://github.com/SativaPhoenix If it does not, disable
the headset on the nacon as well. What version of your nacon? Mine is
version 1.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Jays2Kings/DS4Windows/issues/275#issuecomment-413168795,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AY9OaXTgdntlnQ_hAjCEZzH8imePhOSdks5uRAQHgaJpZM4MaQAy
.

I sent this to the Nacon team:
Question :
Le 14/08/2018 22:03, NACON Gaming<EMAIL_ADDRESS>a écrit :
[NACONGAMING] REVOLUTION PRO CONTROLLER - South Africa
From : Darryn Sheldon du Plessis<EMAIL_ADDRESS>)
Subject : [NACON GAMING]REVOLUTION PRO CONTROLLER - South Africa
Dear Nacon,
Today, I bought the beautiful PS4 controller _ but ds4windows doesn't
detect it-  and I have to use it as xbox 360 controller. This is fine,
Except that I want to use the touch pad.
Steam thinks it's a ps3 controller.. but it's for PS4; how can we fix
this?: )
Love your products. Thank you. Would love some support.
This e-mail was sent from a contact form on NACON Gaming .
Réponse / Answer :
Greetings,
We have carried the greatest attention to your e-mail.
It is not intended to work on pc.
Only on ps4.
Staying at your service for more information,
The Hot Line Team.
LOL their response was weak..
On Wed, Aug 15, 2018 at 3:10 PM, Darryn du Plessis <
<EMAIL_ADDRESS>wrote:

Thank you,
I  got this one yesterday: https://www.takealot.com/nacon-red-wired-
compact-controller-ps4/PLID48674042
So I must just check the Windows Microphone/Sound devices? and disable it
there? :) will look in two hours;
On Wed, Aug 15, 2018 at 1:20 PM, Mailson Queiroz<EMAIL_ADDRESS>
wrote:

@SativaPhoenix https://github.com/SativaPhoenix If it does not,
disable the headset on the nacon as well. What version of your nacon? Mine
is version 1.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Jays2Kings/DS4Windows/issues/275#issuecomment-413168795,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AY9OaXTgdntlnQ_hAjCEZzH8imePhOSdks5uRAQHgaJpZM4MaQAy
.

Did somebody get a fix to this?
I got a Nacon Revolution Pro controller

If you want to pass me the TeamViewer id I try to help you. My self made it work.

i set up a meeting no remote control

Hi. Unfortunately I do not support the Nacon Revolution Pro controller with the latest DS4. There is something to do. Thanks

To make it work on steam go to big picture => controller settings => enable ps4 support

Thanks. As soon as I get home I'll try and the above-mentioned audio block. I am writing about the developments

To make it work on steam go to big picture => controller settings => enable ps4 support

Unfortunately, although I've enabled the controller in Steam Big Picture mode, it only works in the game does not work

Köszönöm a közreműködést,  kedves  @promailson !!!!
Probléma megoldva!!!
Teljes támogatás!!!
Nagyon szépen köszönöm!!!
Thanks for your help, dear @promailson !!!!
Problem solved!!!
Full Support !!!
Thank you very much!!!

Hello guys, so ds4windows was working perfectly until I reset my pc.  I installed ds4windows from @Ryochan7 like I usually do and it didn’t work this time, I set it up as a normal install not the program thingy in the left of when you first run ds4windows.  When I plugged in the controller for the first time without ds4windows I heard the windows plugged in sound, but after that when I ran ds4windows it doesn’t work.  I found a pattern as this isn’t the first time it has happened, I’m pretty sure it has to do with shared mode or with the Vig bus or whatever it was called (not a dev or a smart person like you guys) so help would really be apretiated PLEASE, it’s the 3rd week of worldcup in fortnite and I don’t want to miss it

This is wrong forum. This is the obsolete Jays2Kings web site and developers are no longer following this web page. If you are using the newer DS4Windows/Ryochan7 fork then you should jump over to that github web page. Anyway, check your Device Manager and make sure there are no yellow warning icons in any of the devices or any of the HID devices are not in disabled state.
I recommend you to update to V1.7.6 DSWindows version and to update ViGem gamepad device driver also. (or uninstall existing ViGem driver and let DS4Windows to download and install a new version). Few days ago both of those received a new version.

It's 2019 so I don't know if this will even get any attention but my Nacon Revolution pro controller it's not working at all even what the new version of DS4.

It's 2019 so I don't know if this will even get any attention but my Nacon Revolution pro controller it's not working at all even what the new version of DS4.

I'll take a look. Please can you confirm which version of the Revolution Pro you have and that it still works reliably with a PS4? I found the proprietary cable of the first version to be a point of weakness when testing my original port and had to get a replacement from Nacon.

The Pro Controller 1 and it still works on my PS4. And it works perfectly
fine on Steam games but that's it
On Sun, Sep 22, 2019, 8:39 AM SiliconExarch<EMAIL_ADDRESS>wrote:

It's 2019 so I don't know if this will even get any attention but my Nacon
Revolution pro controller it's not working at all even what the new version
of DS4.
I'll take a look. Please can you confirm which version of the Revolution
Pro you have and that it still works reliably with a PS4? I found the
proprietary cable of the first version to be a point of weakness when
testing my original port and had to get a replacement from Nacon.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Jays2Kings/DS4Windows/issues/275?email_source=notifications&email_token=ANITSZ43ACNRUWOEIAMREQDQK5RRJA5CNFSM4DDJAAZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7JFOBY#issuecomment-533878535,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANITSZ7GBXV66ASYQYQ55I3QK5RRJANCNFSM4DDJAAZA
.

Well some Steam games not all of them
On Sun, Sep 22, 2019, 8:44 AM Sirath Icebreath<EMAIL_ADDRESS>wrote:

The Pro Controller 1 and it still works on my PS4. And it works perfectly
fine on Steam games but that's it
On Sun, Sep 22, 2019, 8:39 AM SiliconExarch<EMAIL_ADDRESS>wrote:

It's 2019 so I don't know if this will even get any attention but my
Nacon Revolution pro controller it's not working at all even what the new
version of DS4.
I'll take a look. Please can you confirm which version of the Revolution
Pro you have and that it still works reliably with a PS4? I found the
proprietary cable of the first version to be a point of weakness when
testing my original port and had to get a replacement from Nacon.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Jays2Kings/DS4Windows/issues/275?email_source=notifications&email_token=ANITSZ43ACNRUWOEIAMREQDQK5RRJA5CNFSM4DDJAAZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7JFOBY#issuecomment-533878535,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANITSZ7GBXV66ASYQYQ55I3QK5RRJANCNFSM4DDJAAZA
.

my Nacon Revolution pro controller it's not working at all even what the new version of DS4.
You are using the one from here right: https://github.com/Ryochan7/DS4Windows/releases
I've just tested it with my Pro Controller 1 and everything is working just as I left it c:

Hi it's possible to add compatibility to Nacon Wired Compat?
VID_146B&PID_0603

Would it be possible to add Nacon Revolution Unlimited support as well?
VID_146B&PID_0D10
When connected through a cable.

Bonjour, j'ai une manette nacon wired illuminated compact controller et je n'arrive pas à me connecter sur Ds4 windows. Quelqu'un aurai une solution svp. C'est très important ça fait plusieurs moi que je cherche et tente des trucs mais rien à faire. J'avais acheté cette manette en particulier pour le pad tactile pour l'utiliser à la place de la souris sur les jeux (steam, emulateur etc) merci d'avance

@JDA-GAMING  In that case you should post the question to Ryochan7 github forum: https://github.com/Ryochan7/DS4Windows/issues
And while you are posting the question there then attach the content o %APPDATA%\DS4Windows\Logs logfile (or content of Logs tabpage in DS4Windows app in text format) to the issue post. Developers cannot do much without details about the environment, app version and log files. And optionally run the debug version of DS4Windows Ryochan7 version to generate more detailed logfile from a gamepad connection problems.
https://github.com/Ryochan7/DS4Windows/wiki/Troubleshooting#detailed-debug-log-file-from-gamepad-connection-problems
Please don't reply to this post, instead post a question to correct forum (ie. Ryochan7 github forum).

Bonjour, je n'arrive toujours pas à connecter ma nacon pro evolution controller v1 , pouvez vous m'aidez s'il vous plait , mon pc reconnait la manette , l'application Nacon Sofware aussi mais sur DS4Windows il ne l'as trouve pas

Bonjour, je n'arrive toujours pas à connecter ma nacon pro evolution controller v1 , pouvez vous m'aidez s'il vous plait , mon pc reconnait la manette , l'application Nacon Sofware aussi mais sur DS4Windows il ne l'as trouve pas

@RevengeHisoka You are using the wrong web site to post a question. Thsi is Jays2Kings version of DS4Windows, but it hasn't been updated for several years and the support here is minimal.
Instead, you download the latest DS4Windows from Ryochan7/DS4Windows web site and post your question to https://github.com/Ryochan7/DS4Windows/issues web site (and read the pinned "Read this before posting a new issue ticket" post and provide the required details about your environment and app versions and logfiles. And try to run the debug version as instructed there).
And I recommend you to use English (or Finnish) in the post, so there is chances to get help from more people around there in Ryochan7/DS4Windows site.

@RevengeHisoka You are using the wrong web site to post a question. Thsi is Jays2Kings version of DS4Windows, but it hasn't been updated for several years and the support here is minimal.
Instead, you download the latest DS4Windows from Ryochan7/DS4Windows web site and post your question to https://github.com/Ryochan7/DS4Windows/issues web site (and read the pinned "Read this before posting a new issue ticket" post and provide the required details about your environment and app versions and logfiles. And try to run the debug version as instructed there).
And I recommend you to use English (or Finnish) in the post, so there is chances to get help from more people around there in Ryochan7/DS4Windows site.


"panicking in constants is unstable" at build time in 0.7.2

Regression from 0.7.1 to 0.7.2. Getting this at build time:
error[E0658]: panicking in constants is unstable
   --> /home/kvark/.cargo/registry/src/github.com-1ecc6299db9ec823/hecs-0.7.2/src/entities.rs:510:21
    |
510 |             None => unreachable!(),
    |                     ^^^^^^^^^^^^^^
    |
    = note: see issue #51999 <https://github.com/rust-lang/rust/issues/51999> for more information
    = note: this error originates in the macro `$crate::panic::panic_2015` (in Nightly builds, run with -Z macro-backtrace for more info)

This was stabilized in 1.57: https://blog.rust-lang.org/2021/12/02/Rust-1.57.0.html#panic-in-const-contexts.

Maybe we should add a rust-version entry to Cargo.toml?

Good idea!

Bumping MSRV in a patch version should not be done. Instead, it should be considered a breaking change, since it will stop building for some users.


Add a session method.

We can have the option to allow developer to set a Session count only on which the Ads will be loaded and shown.
For example:
If the session is set to say 4,
then we load the Ad when the app is opened for the 3rd time & show it on the 4th time.
However, there's a caveat.
If the difference between both the sessions is over 4 Hours, it wouldn't make any sense as the Ad impressions won't be counted. Maybe we can think of something else.

Closing this as it does not seem good from monetising aspect,
as described in the caveat above.

Closing this as it does not seem good from monetising aspect,
as described in the caveat above.


[e2e]: generic workflow_dispatch main default slsa3

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/8446026918
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.generic.workflow_dispatch.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.generic.workflow_dispatch.main.default.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Wed Mar 27 03:08:45 UTC 2024

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/8461807695
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.generic.workflow_dispatch.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.generic.workflow_dispatch.main.default.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Thu Mar 28 03:09:01 UTC 2024
Tests are passing now. Closing this issue.


new abilities for before/after handlers

Coverage increased (+1.7%) to 92.734% when pulling 23fa3e50e4d0a38179902be1aef37a96de57ced5 on before-after-handlers-params into 5c5af568b4aa11e2e94b437223897094d864f2aa on master.


double-beep: Watch abanslogistics.lk

double-beep requests the watch of the watch_keyword abanslogistics\.lk. See the MS search here and the Stack Exchange search here.

abanslogistics\.lk has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by angussidney in Charcoal HQ


Adds detailed classifiers to setup.py

A possible fix for #403

Could you use git rebase -i to squash all commits into one?

@untitaker Done

Excellent, thanks!


DOC Write tutorial "How to add a datafit? How to add a penalty? in skglm"

I think that'd be a valuable addition for any newcomers wanting to add a custom datafit or penalty. Plus it's a great piece of doc to understand how skglm works behind the scenes.

We have https://contrib.scikit-learn.org/skglm/add.html with a link in the header but if you did not find it, we may need to think about a better way to emphasize it. Feel free to update the content itself too, now that we have progressed on solvers and API

I was thinking about a more hands-on tutorial, like adding the Poisson datafit. We start from the formulation of the datafit, and derive all the necessary quantities and questions one would need to ask itself to add the datafit (e.g. is my datafit Lipschitz). A mix between maths and code actually.

Also, I find the raw_grad and raw_hessian names very misleading, that's worth at least an explanation in the documentation and an example.

I agree with @PABannier on having a hands-on tutorial on adding new datafit.
We can get inspired by the approach we followed to add Poisson or Gamma datafits.

Go for it !


Too many values to unpack (cannot print return values of transactions)

I have the following function:
# SPDX-License-Identifier: MIT
# pragma version 0.4.0

# Should return<PHONE_NUMBER>000000
@external
def get_difficulty() -> uint256:
    return block.difficulty

(Yes, I know it should be a view function, but roll with me)
If I have the following code:
set_zksync_test_env()

difficulty: ZksyncContract = Difficulty.deploy()
print("Difficulty: ", difficulty.get_difficulty())

I will get this error:
  File "/Users/patrick/code/moccasin/tests/data/zksync_project/script/deploy.py", line 10, in deploy
    print("Difficulty: ", difficulty.get_difficulty())
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/patrick/code/moccasin/.venv/lib/python3.12/site-packages/boa/contracts/abi/abi_contract.py", line 127, in __call__
    computation = self.contract.env.execute_code(
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/patrick/code/moccasin/.venv/lib/python3.12/site-packages/boa_zksync/environment.py", line 147, in execute_code
    receipt, trace = self._send_txn(**args.as_tx_params())
    ^^^^^^^^^^^^^^
ValueError: too many values to unpack (expected 2)

Updating this line:
receipt, trace = self._send_txn(**args.as_tx_params())

to this:
_, receipt, trace = self._send_txn(**args.as_tx_params())

Fixes the error. Should we add this?

This is caused by changes in titanoboa 0.2.3, more specifically this commit.
We should update the code and the required titanoboa version


RPC failed (cluster)

I'm on CentOS 6.8, running the latest EMQ beta (2.0-beta2).
When calling './bin/emqttd_ctl cluster join<EMAIL_ADDRESS>I get the following output:
RPC to<EMAIL_ADDRESS>failed: {'EXIT',
                                        {badarg,
                                         [{ets,match,
                                           [mqttd_ctl_cmd,
                                            {{'_',cluster},'$1','_'}],
                                           []},
                                          {emqttd_ctl,lookup,1,
                                           [{file,"src/emqttd_ctl.erl"},
                                            {line,78}]},
                                          {emqttd_ctl,run,1,
                                           [{file,"src/emqttd_ctl.erl"},
                                            {line,70}]},
                                          {rpc,'-handle_call_call/6-fun-0-',
                                           5,
                                           [{file,"rpc.erl"},{line,206}]}]}}

@Venorcis The error log means the node has not been started successfully.


Merge pull request #1 from bcakmakoglu/master

Merge pull request
🚀 What's changed?

Change 1
Change 2
...

🐛 Fixes

[ ] #Issue1
[ ] #Issue2
[ ] ...

🪴 To-Dos

[ ] To-Do 1
[ ] To-Do 2
...

Mh? What is this PR supposed to do?
It's empty, no description either?
I'm closing it, re-open it if you have an actual PR to propose 😄


a patch to fix CI failure in windows

A little advice, if you can avoid Shotgun Surgery is better

good to know. But this patch is just turned out not the case, so I decided to just revert it with minor changes.


Infix to Postfix

Appended a new file with the code for converting postfix to infix expression.

Not good for a merge?

This is my first time doing pull requests so guide me if possible


Invalid docker logs example

File: engine/reference/commandline/logs.md
For both online reference and man docker-container-logs the example executes docker logs -f --until=2s which is invalid as it is missing container parameter. Should be changed to docker logs -f --until=2s test.
I wanted to make a PR but it not clear to me whether it should go here or docker/cli or both. README and https://docs.docker.com/opensource/ do not even mention docker/cli so it's a little bit confusing imho.

Thanks for sharing the issue. This particular content is maintained in an upstream repo. If the issue is still applicable, please help create an issue or PR in the source repo at https://github.com/docker/cli/tree/master/docs/reference/commandline https://github.com/docker/cli/tree/master/man/src


Feat #2 - complete cart component

Assignee Tasks

[ ] added unit tests (or none needed)
[ ] written relevant docs (or none needed)
[ ] referenced any relevant issues (or none exist)

Guidelines
Please add a description of this Pull Request's motivation, scope, outstanding issues or potential alternatives, reasoning behind the current solution, and any other relevant information for posterity.

Closes #2

Looks great Jess!


Extensions can't work with large files

VS Code doesn't provide the document element of the editor when a large file is open. This means that extensions can't get any file information at all.
Editing still works fine, even a (large number of) find/replace functions work.
Using registerTextEditorCommand fails to enter the callback function at all (presumably the exception is thrown when the arguments to the callback are created) and trying to access the document via the activeTextEditor in registerCommand fails (throws) when attempting to access the .document getter of the TextEditor object. Inspecting the activeTextEditor object shows that _documentData is undefined
I've had this failure with a 6MB file. Yet editing, and highlighting (JSON) work on a 16MB file.

// @jrieken

Indeed, this is our current strategy for handling large files:

files < 5 MB get synced everywhere
files < 20MB get only colorization and don't get synced to the extension host (invisible to extensions), nor to web workers (no diff)
files > 20MB don't get colorization and don't get synced.

closing this cos this it is by design.


Update dockerfile for parcel/watcher package fix

What does this PR do / why we need it
This PR tries to fix the issue with @parcel/watcher package and the node-gyp dependency. The issue comes from the 2.0.4 of the watcher package. This is a known issue which has been fixed here https://github.com/nrwl/nx/pull/19751. As a result in order to have a full fix of this issue we might need to update to nx 17.1.3.
As the update of nx dep might require a fair amount of changes to the package.json of the project, as a temporary solution we can add overrides to the package.json in order to use the version 2.3.0.
Another required step is to install gcc, make and python3 deps.
More info about the fixes can be found here: https://github.com/parcel-bundler/watcher/issues/156#issuecomment-1721077490 & here: https://github.com/nrwl/nx/issues/19457
Which issue(s) does this PR fix
Fixes https://github.com/devfile/api/issues/1356
PR acceptance criteria

[ ] Unit Tests
[ ] E2E Tests
[ ] Documentation
Update the sidebar if there is a new file added or an existing filename is changed

How to test changes / Special notes to the reviewer
In order to reproduce it to a non-silicon environment I've tried to run:
ABSOLUTE_PATH="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
BUILD_DIR=$ABSOLUTE_PATH/..

docker buildx build --platform linux/arm64 --no-cache -t registry-viewer $BUILD_DIR \
    --build-arg PROJECT_NAME=registry-viewer \
    --build-arg NEXT_PUBLIC_BASE_PATH=${NEXT_PUBLIC_BASE_PATH:-"/viewer"}

@Jdubrick could you check if this workaround resolves the issue you are facing with apple silicon?

I mentioned in the main issue for this that the changes weren't able to fully solve the issue and I was still receiving a 139 error code on the yarn --frozen-lockfile stage. I think these proposed changes however may be a step in the right direction as I feel there is multiple layers of issues here. I'm going to do some more tinkering with this to see if I can get it working.

I mentioned in the main issue for this that the changes weren't able to fully solve the issue and I was still receiving a 139 error code on the yarn --frozen-lockfile stage. I think these proposed changes however may be a step in the right direction as I feel there is multiple layers of issues here. I'm going to do some more tinkering with this to see if I can get it working.

@Jdubrick yeah might be not only one issue and I'm pretty sure we will find it again in the future. Although I'd suggest to merge a fix specifically for your case as atm we only know of this issue for the silicon case.


Manage Dynamics 365 instances

Acording this doc page, Dynamics 365 Service Administrators can manage instances, but in fact, they only have full access to Sandbox instances while for Production instances they can only set them up: after configured, no access to data in that environment neither ability to reset / delete it.
I've raised a support ticket regarding this issue, and I was told that documenation is not complete and it should state that limitation. Please, review this and update accordingly.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2bc0e430-037c-c08a-3bb6-9ab04a16ce57
Version Independent ID: f51bb8e3-8263-45b5-e4e1-0b170906e124
Content: Use the Dynamics 365 for Customer Engagement apps (online) service admin role to manage your tenant
Content Source: ce/admin/use-service-admin-role-manage-tenant.md
Service: crm-online
GitHub Login: @jimholtz
Microsoft Alias: jimholtz

@nickbrandl
Sorry for the extensive delay. The doc is correct as-is.  Reset and Delete operations are only supported in Sandbox instance type and both Global and D365 Service Administrators have the privilege to run these operations.  Production instance type is locked down where Reset and Delete operations are not allowed.


Fix BulkListSerializerObject is not iterable thing

Fix for https://github.com/miki725/django-rest-framework-bulk/issues/33 by making the object iterable even though it doesn't actually iterate over anything.  Everything seems to work still.  Kind of hacky, but better than nasty 500 errors.

@liquidpele thanks. I wonder if this can have any negative side-effects.
also build failed

No idea, seemed to work for me though.   I don't have time to play with it more though, sorry.

Oooh I just read @typerlc description of the problem. He said "The  values  object is my serializer object", however, list(values) DOES NOT necessarily contains instances of serializers. It simply iterates over values and creates a list with the items returned (which are BoundField, as the Serializer has defined.

I am currently swamped at work however will try to take a look at this next week.

Just an FYI you might want to fix this a better way.  I ended up implementing my own multi functionality in a viewset instead of the serializer, so I won't have the ability to help out.  As a hint, I noticed I got the same error in my own implementation when I passed an object to the serializer (instead of a list) when I had many=True set for the serializer's definition.   Hope that leads you to figuring it out...  Cheers!

Has there been any progress on this PR?


[Tutorial Docs] Change text to title

name: :memo: Documentation Fix
about: Fixing a problem in an existing docs page
Checklist

[ ] Is there an existing issue for this PR?

link issue here

[ ] Have the files been linted and formatted?

What docs page needs to be fixed?

Section: Redux Essentials
Page: Part 4 (Using Redux Data)

What is the problem?
In the code and everywhere else a property is named as title but in one place it's referenced as text.
What changes does this PR make to fix the problem?
Rename text to title.

Thanks!

Thanks!


Integral symbol too small, interval values seem too big/placed incorrectly

Comparison shot between MathJax and KaTeX for definite integrals:

@Pomax please re-open if this is still an issue for you.

(We added a new flag…)
katex.render("c = \\pm\\sqrt{a^2 + b^2}", element, { displayMode: true });

That flag centers stuff on the test page.  Not sure how it will affect @Pomax's layouts.


fix(controller): allow "*" wildcard in cert REST URLs

One of the regular expressions for Certificate endpoints wasn't allowing * through, so wildcard certs could be created but not deleted. This relaxes the regex to allow such certs to be deleted. Thanks to @bacongobbler for the test! :green_heart:
Note that wildcard certificates aren't fully supported yet, but users should still be able to delete them.
Closes #3533.

Code LGTM.

code LGTM

Looks like this passed the latest one. :ship:


Cancel workflow info editing doesn't revert

Describe the bug
Error and cancel doesn't revert back to the original.
To Reproduce
Steps to reproduce the behavior:

Have a workflow where you can edit some workflow level info (default descriptor path, default test parameter path, etc)
Click edit
Change to something weird
Click cancel
See that the weird text still remains

Expected behavior
5. the weird text is not there, the original text remains
Screenshots

Additional context
Webservice - 0eae84c
UI - 2.8.2-95-g8569af25
Compose Setup - 120d9b9
Deploy - 1.11.1-99-g7f09f05
galaxyParsingLambdaVersion: 0.0.6
┆Issue is synchronized with this Jira Story
┆fixVersions: Dockstore 1.13
┆friendlyId: DOCK-2001
┆sprint: 93- Ursula
┆taskType: Story

To clarify, the change is not saved to the backend; the UI is showing the unsaved changes.

Notes for myself, this is a tad confusing:

info-tab.component.ts has an extendedWorkflowproperty. This is set via an @Input, and comes from the Akita store.
info-tab.component.ts has a workflow property/object. It is initialized in the ngOnChanges, which fires when a data-bound property changes. In practice for this case, I think, it fires once, essentially after the componenent initializes and the @Inputs are processed. The ngOnChanges sets the workflow property to a copy of the extendedWorkflow.
The UI edits the workflow object, i.e., the copy of the extendedWorkflow.

When you click the edit button, it invokes a toggle method, e.g.,
toggleEditWorkflowPath() {
    if (this.workflowPathEditing) {
      this.save();
    }
    this.infoTabService.setWorkflowPathEditing(!this.workflowPathEditing);
  }

This invokes next on a BehaviorSubject in info-tab.service.ts, whose sole listener is info-tab.component.ts, which updates this.workflowPathEditing.
IOW, the effect of the above code is the same as:
toggleEditWorkflowPath() {
    if (this.workflowPathEditing) {
      this.save();
    }
    this.workflowPathEditing = !this.workflowPathEditing;
  }

The save() method invokes info-tab.service.ts:updateAndRefresh with this.workflow as a parameter.
The cancelEditing method, which is invoked when you cancel, remember, after this.workflow has been updated via the HTML

Calls infoTabService.cancelEditing(), which
Calls the BehaviorSubjects with false, i.e., so that this.workflowPathEditing ends up being false
Calls infoTabService.restoreWorfklow(), which reverts infoTabService.workflow. But infoTabComponent never reads infoTabService.workflow`, I think. Hence the problem.


Show/Hide feature on page navigator in the documentation portal

Pages in the documentation portal looks good. Just for suggestion, if you add a show/hide feature for the left side page navigator or something like read thru immersive reader option in edge for the technical documentation page, it would be looks like somewhat better. I just feel like the documentation portal scrambled with more option that distracts focus on the content of the page.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 3ad87897-30cc-e639-b91a-b3800269f7fe
Version Independent ID: 9d3015b4-cba1-0956-9ec7-4154dbb74d93
Content: .NET (and .NET Core) - introduction and overview
Content Source: docs/core/introduction.md
Product: dotnet-fundamentals
GitHub Login: @gewarren
Microsoft Alias: dotnetcontent

@MuraliManickam Thank you for the feedback!


Allow to control sealing module visibility

Fixes #9
Bumps up crate to 0.3.0 version as using private visibility by default is a breaking change.

[x] Tests added
[x] Documentation and README are updated
[x] Examples and demo are updated

@jmg-duarte please, review.

@jmg-duarte

IMO all error messages should be capitalized, if you disagree, I am open to know more as to why

Just following the style of standard compile-time error messages (like in tests/fail/*.stderr files). I tend to capitilze error messages too, but rather runtime's ones.

@jmg-duarte CI fails due to nightly Rust printing slightly changed diagnostic messages than stable.
Some approaches:

We can opt-out codegen failure tests for nightly.
We can copy-paste the suite for nightly, correct the .stderr files and run different suits on nightly and stable.

What should we prefer?

@jmg-duarte

IMO all error messages should be capitalized, if you disagree, I am open to know more as to why

Just following the style of standard compile-time error messages (like in tests/fail/*.stderr files). I tend to capitilze error messages too, but rather runtime's ones.

Great point, I hadn't noticed before

@jmg-duarte CI fails due to nightly Rust printing slightly changed diagnostic messages than stable.
Some approaches:
1. We can opt-out codegen failure tests for nightly.

2. We can copy-paste the suite for nightly, correct the `.stderr` files and run different suits on nightly and stable.

What should we prefer?

I've opted to only do UI tests on stable (https://github.com/jmg-duarte/sealed-rs/issues/11), I'll be working on this in a bit

@tyranron the new CI should be able to cope with your changes

Everything checks out, however I noticed one thing that is missing.
What is the default visibility when the argument is not passed in? Could you document that?

@jmg-duarte I've thought this is quite obvious from the expansion examples. But mentioning defaults is not a big deal, so here we go.

@jmg-duarte I've thought this is quite obvious from the expansion examples. But mentioning defaults is not a big deal, so here we go.

Explicit > Implicit
Regardless, great work! Thank you for your contribution!


Remove environment model

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #3221
Does this PR introduce a user-facing change?:

NONE

Finally🙌
/lgtm

Thank you 🙆♀
/approve

/changelog


Verify pylint disable locations

Given major refactors in #316 and #360 (once it's merged), we should go through and check the several locations where we have pylint: disable in the Flow and Tool code, as I suspect many of the locations could be removed.

Our pylint min_similarity lines is set to 4, I propose moving it to 5 because there were a couple of spots in the create_build_snippets and __init__ methods of our biggest flows where there were more than four tools being used, and it caused a duplication error without the disables. 5 lines would allow us to remove these disables.
Currently, I'm doing as asked above and only looking at the Flow and Tool code.  The unittest scripts are full of duplicate code and the pylint disables, but I don't think that's a bad thing given that they are unit tests and we don't want to make them opaque. Also the rw utility has several other types of disables. Also, most of the old legacy flows have duplicate code disables, but I don't think we should worry about that either.
Thoughts? @jgoeders

I'm fine raising line similarity to something a bit larger.


ci: allow dispatch for flagship integrations

What does this PR do?
still pending adding apps :cowboy_hat_face:
ref: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_dispatch
Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[ ] Did you make sure to update the documentation with your changes? (if necessary)
[ ] Did you write any new necessary tests? (not for typos and docs)
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] Did you list all the breaking changes introduced by this pull request?
[ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃

Flashy is passing, the other two have still broken/outdated tests :chipmunk:


Add basic bot behavior

Start implementing basic bot decision making, make them go to the closest player and attack on a certain range.

Can we merge this issue with #370 ?


temREDUNDANT when swapping Gatehub USD with Bistamp USD (Version: 2.1.1)

Issue Description
When executing a swap transaction between Gatehub USD and Bitstamp USD, a temREDUNDANT error is thrown by the rippled engine.
Same currency with different issuer is the only reason I can see behind this bug, since it only appears for this swap pair.
Steps to Reproduce
{
  "TransactionType":"Payment",
  "Destination":"<my-account>",
  "Account":"<my-account>",
  "Amount":{
      "value":10.8951797815249,
      "currency":"USD",
      "issuer":"rhub8VRN55s94qWKDv6jmDy1pUykJzF3wq"
   },
   "SendMax":{
      "value":11.0279832334121,
      "currency":"USD",
      "issuer":"rvYAfWj5gh67oV6fW32ZzP3Aw4Eubs59B"
   },
   "Fee":"10",
   "Sequence":<my-sequence>,
   "Flags":2147614720,
}

For Swaps with the same currency code, you should specify the Paths field.
https://github.com/XRPLF/rippled/blob/c88166e055e4378f78fb0236e0bf347d6544e517/src/ripple/app/tx/impl/Payment.cpp#L121-L130

Why that? Is that a feature or a bug?
Since issuers are different, it should be treated as different currencies

It is a very long-standing process and I don't know about it.
It may be a check that is necessary when considering the Rippling.

Ok, at least there is a solution!
I'm still curious about the exact reason, if someone with this knowledge passes by

@tequdev
How should the path be built?
I tried many combination with what I found on https://xrpl.org/docs/concepts/tokens/fungible-tokens/paths/ and https://xrpl.org/docs/references/http-websocket-apis/public-api-methods/path-and-order-book-methods/ripple_path_find/
But I always end up with either a temBAD_PATH, temBAD_PATH_LOOP or tecPATH_DRY (trustlines are set, and partial payment flag is on).
I didn't find anything about paths for AMM, maybe it's different?
The only path accepted by rippled engine that threw tecPATH_DRY is this one :
[
	{
		"account": "<my-account>"
	},
	{
		"account": "rhub8VRN55s94qWKDv6jmDy1pUykJzF3wq"
	},
	{
		"currency": "USD",
		"issuer": "rhub8VRN55s94qWKDv6jmDy1pUykJzF3wq"
	},
	{
		"currency": "USD",
		"issuer": "rvYAfWj5gh67oV6fW32ZzP3Aw4Eubs59B"
	},
	{
		"account": "rvYAfWj5gh67oV6fW32ZzP3Aw4Eubs59B"
	},
	{
		"account": "<my-account>"
	}
]

it would work with the following Paths field
"Paths": [
	[
		{
			"currency":"XRP"
		},
		{
			"currency":"USD"
			"issuer":"rvYAfWj5gh67oV6fW32ZzP3Aw4Eubs59B"
		}
	]
]

When specifying both destination_amount and source_amount in path_find, the amount you want to send should be specified in source_amount, and the value of destination_amount should be "-1".
Your code is incorrect, so it is not making the expected path_find result.

I'll try the path later,
for the path request, I'm not using source_amount, this is not the problem (I'm not getting the amount malformed exception)

I just tried your path, and it works!
I was asking myself "why add XRP in the path since XRP is not involved?"
But after trying to remove it and only use :
"Paths": [
	[
		{
			"currency":"USD"
			"issuer":"rvYAfWj5gh67oV6fW32ZzP3Aw4Eubs59B"
		}
	]
]

It works too. As simple as that.
Thx for the help ;)

Closing this issue as it appears resolved.


Training code

I'm sorry to bother you again. I have been tracing your code, but I still cannot find the training code that consists of the complete training flow. Could you give me a hint?

Thank for your help!


Inheritance of Sprite class

Hi! First of all great work on this!
Question: Is inheritance between classes something that is supported (or to be supported in the future)?
Right now I'm trying to make a subclass of the Sprite class, but I get this nasty error when trying to compile with swift package pdc
[...]
building pdex.elf
/usr/local/playdate/gcc-arm-none-eabi-9-2019-q4-major/bin/../lib/gcc/arm-none-eabi/9.2.1/../../../../arm-none-eabi/bin/ld: /Users/angelo/Projects/Swift/playdate/unicode-survivors/.build/plugins/PDCPlugin/outputs/unicodesurvivors_device.o:(.data+0xc): undefined reference to `$s18playdatekit_device8PlaydateO6SpriteOADC7pointerAFs13OpaquePointerV_tcfC'
collect2: error: ld returned 1 exit status
error: ccFailed(exitCode: 1)

Note: I had to mark the Sprite class as open in order to be able to subclass it

Thanks for the report! This seems to me like another bug in the Swift compiler, not 100% sure.
Reproducible by creating one module that contains an open class with a non-public init, and another module containing a subclass.
Module 1:
open class Foo {
    init() {}
}

Module 2:
class Bar: Foo {}

I assume this is something that should work, so this should be supported eventually!
cc @rauhul

Definitely a bug! the absolute best thing you can (short of fixing the bug yourself) is filing a GitHub issue on apple/swift with a minimal repro. Additionally please tag both me and @kubamracek in the issue!
The best repro would be two simple files with the content you have here and either a single command to repro the issue or a script.

Definitely a bug! the absolute best thing you can (short of fixing the bug yourself) is filing a GitHub issue on apple/swift with a minimal repro. Additionally please tag both me and @kubamracek in the issue!
The best repro would be two simple files with the content you have here and either a single command to repro the issue or a script.

Good to know, I was starting to feel bad about tagging you in random bugs 😛
I'll try to get a minimal repro and open an issue.

https://github.com/apple/swift/issues/72531


refactor: Use GITHUB_TOKEN instead of REGISTRY_TOKEN

To keep things as consistent as possible, we're switching to using the GITHUB_TOKEN env var for login instead. Env vars were also all pulled out into their own constants to make things more consistent.
This change also includes prioritizing public/private key signing over OIDC keyless for GitHub for an easier transition. It would require the user to delete their cosign.pub file from their repo in order to start using the keyless method.

definitely like the constant var cleanup


[earlgrey_1.0.0] Ibex timing fix

Update code from upstream repository
https://github.com/lowRISC/ibex.git to revision
38c070939183cc10940b66c8e9e04eeca6b65470

[rtl] Remove ECC related data_rdata_i -> instr_X_o feedthroughs
(Greg Chadwick)

This is a cherry pick of commit<PHONE_NUMBER>7bfb1108da7743d9dac7167dcc4888
to branch earlgrey_1.0.0.
~NOTE: This PR will be updated once the PR into master (#24403 ) has been merged.~ This has now been done.

CHANGE AUTHORIZED: hw/vendor/lowrisc_ibex/rtl/ibex_controller.sv

CHANGE AUTHORIZED: hw/vendor/lowrisc_ibex/rtl/ibex_controller.sv


[Don't bother to look here] - Wiki content holder

This ticket will be used just keep uploaded visuals because the GitHub wiki is very limited and doesn't allow us to upload images.


Loop in BFGS.java#127 can fall into infinite loop.

See discussion in PR https://github.com/signaflo/java-timeseries/pull/3
Code
while (!(Double.isFinite(functionValue) &&
                           functionValue < priorFunctionValue + C1 * stepSize * slopeAt0) && !stop) {

can fall into infinite loop.

Release 0.4 includes the simplest solution of using a counter to keep track of the number of iterations and exiting the loop when the maximum is reached. It is far preferable to understand why the algorithm is falling into this state and taking steps to prevent that.


download bedrock data very slow

Env:

use simple-optimism-node branch is sc/bedrock.
the server is aws ec2,and location is `us-east-1
has open udp and tcp port 6881

But the data download is very slow
logs:
Bedrock node needs to be initialized...
Initializing via download...
Fetching download link...
Downloading bedrock.tar...
Download Progress: 0.00%
Download Progress: 0.00%
Download Progress: 0.00%
Download Progress: 0.01%
Download Progress: 0.01%
Download Progress: 0.01%
^[Download Progress: 0.01%
Download Progress: 0.01%
Download Progress: 0.01%
Download Progress: 0.01%

Use you solution,i have download data,but when i start docker,the simple-optimism-node-op-geth-1 have error log.

In the end, I solved it. thanks @kchojn ,the bedrock data url has change,we can query by here
the new url is https://op.datadirs.xyz/mainnet-bedrock.tar.

Great! Sorry @0xwhatly, I noticed the message only when you tagged me.
My link was from the official documentation: https://community.optimism.io/docs/useful-tools/networks/#, and it worked for me 😅


Should  allow wildcards?

With inclusion of PLATFORM.moduleName we have a cleaner means of parsing bundle dependencies from things like the webpack loader, but since webpack supports dynamic contexts, how do we include that information at the view level?
We can add plugins to glob in the folder contents, but that puts the view dependencies in the loader, rather than associating them with the component.
Would there be any issue with something like
<require from="elements/status-*"></require>

and to extend the webpack (or any other framework) loader to detect wild card use properly?
I suppose the alternative is to do it 'properly' and allow
<compose view="elements/status-${status}"></compose>

and have the loader ensure elements/status-* is used to wildcard in the inclusions. This is in line with nature of webpack dynamic contexts, but would it cause issues with other packaging options?

Seems like a good idea. Thoughts @jods4?

Won't work with other module loaders including the whatwg standard.
On Apr 27, 2017 6:46 AM, "Bazyli Brzóska"<EMAIL_ADDRESS>wrote:

Seems like a good idea. Thoughts @jods4 https://github.com/jods4?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/aurelia/templating/issues/548#issuecomment-297717898,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIBnQg0cxtymx5cGbD-IQcoSlTojC8vks5r0JxNgaJpZM4NJoQf
.

I feel like there are two different discussion in the issue description.
Regarding the title one: Should  allow wildcards?
I will defer this to Rob as the first step is specify the behavior of aurelia-templating when <require from="folder/*"> is encountered.
Adding support in Webpack would come second after implementation in Aurelia.
My personal opinion on that:

Loaders are not able to list contents of a folder, so I don't see how that could be defined/work.
What extensions would be grabbed? Pretty much any extension could be valid for someone.
ES standard doesn't need import "folder/*" or import("folder/*"). Why would we? + being explicit brings more safety.

:-1:

The arguments against are pretty good, I'm persuaded. We should probably mention in the blog post that we deprecated dynamic imports in Webpack though (explained here https://github.com/aurelia/skeleton-navigation/issues/810), unless that's something we want to consider implementing.

I did not see that issue. I'll leave a comment there.
It's not deprecated as there are good use cases to bind <compose>.
The way you handle dependencies has changed, though. Auto-include everything doesn't work anymore.

I have no issue with webpack's dynamic context in module 'require' functions being deprecated, but then I've never wanted to use it because it looks like a messy shortcut to referring to dependencies properly.
Other people might feel differently, so we'll need to get some feedback.
As @jods4 says, it's really about composition, and how a loader is able to say "this template has a dependency on this template or these templates".
I'm happy to insist each 'child' dependency template be on a separate line, but if so we need to lock it in and document that as a tooling change.
I'll close https://github.com/aurelia/skeleton-navigation/issues/810#issuecomment-297869833 and point people to this discussion, as I believe the template level needs to be the lowest common denominator between loaders.

So what are the solutions for someone who wants to use dynamic composition such as
<compose view="elements/status-${status}"></compose>

import all those modules explicitly using require statements?

@istrau3 I'll add a page to the wiki about it.
In the meantime all options are described here:
https://github.com/aurelia/skeleton-navigation/issues/810#issuecomment-297760384
TL;DR: it's much better to not use interpolation but put the full module id in your code, wrapped in moduleName. It has several benefits in large-scale projects, see the discussion that followed the comment linked above.

Closing this since it's not something we can do. I wish we could.


npm test: ERROR: 'Warning: ReactComponentTreeDevtool: Missing React element ...

In case anyone is getting this error in tests:
ERROR: 'Warning: ReactComponentTreeDevtool: Missing React element for debugID 17 when building stack'
This is a React error, #7240 Should be corrected in the next React release.
As this is just a Warning and all tests pass, I see no reason to roll back React.

Corrected by react 15.3.1 in #892


#4322  bitbucket own hosted v5.11.1 branchUrl fix and enabled error tracing…

Hey, I just made a Pull Request! for   #4322
Closes #4322
@OrkoHunter

Added branchUrl for  bitbucket own hosted v5.11.1
added error tracing for mkdocs stderr

:heavy_check_mark: Checklist

[ :heavy_check_mark: ] A changeset describing the change and affected packages. (more info)

[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)

Hi, you need to run prettier on the modified file.

Hey! You need to run prettier on those files to fix failing CI.

Please also add a changeset with a patch change for @backstage/integration. (Detail is in PR description.)

done. thanks

Sorry, prettier is still failing on CI for two files
Use yarn run prettier --write <filepath>

Sorry, prettier is still failing on CI for two files
Use yarn run prettier --write <filepath>

Sorry, prettier is still failing on CI for two files
Use yarn run prettier --write <filepath>

It is done. thanks.

Hi @OrkoHunter
except the  "documentation quality check " all other CI steps are  green now ;-)
Would you like to fix this Doc quality check please ?  I was thinking this PR is for doc-for-code fix...  :-)

We have a language linter so bitbucket just needed to be Bitbucket!

Doc Quality check now ok.  thanks
further Fossa/Build - is due to  "502 Bad Gateway" nginx proxy? etc. from build server ...

Yeah, ignore FOSSA. It's a known issue. #4240
This LGTM!


Bio-maf not working with new MAF-files

The new MAF-files are not split on chromosomes, so when I try to look up i.e. hg38.chr1 I get the message
/usr/local/lib/ruby/gems/2.1.0/gems/bio-maf-1.0.1/lib/bio/maf/index.rb:266:in chrom_index': No index available for chromosome hg38.chr1! (RuntimeError)`
However, if I try to look up hg38.chr8 it works, presumably because that is the very first chromosome in the maf-file.
endrebakkenstovner@dhcp-033193 ~/pipeline_sirnas> head -3 data/hg38.7way.maf
##maf version=1 scoring=blastz
a score=96727.000000
s hg38.chr8     60297 1234 + 145138636 AAAGACTTCTTGTCTTTATTTTGTTCCCATGCCTACCTTTTAGCCATAATACAACAGAAblablabla

This happens to all other MAF-parsers too, so if you update yours you will have the only one that actually works.

Thanks to an earlier issue here, I've come to realize that the problem is likely not multiple chromosomes, but rather the fact that the chromos are scattered all over the file.
ack -oh "hg38.chr[0-9]*" data/hg38.7way.maf | uniq
results in output like
...
hg38.chr9
hg38.chr17
hg38.chr1
hg38.chr17
hg38.chr11
hg38.chr17
hg38.chr
hg38.chr11
hg38.chr1
hg38.chr4
hg38.chr11
hg38.chr17
hg38.chr15
...

Hi @ghost,
I’m facing the same issue with querying specific chromosomes in a MAF file, where the parser (bio-maf) fails due to scattered chromosome entries.
Did you find a solution for this? Any advice on how to index these MAF files would be appreciated!
Thanks!
Gemma


Cannot connect to pcluster instance - times out.

When I try to connect to my pcluster instance, it times out and says:

ERROR: Something went wrong during DCV connection.
ssh: connect to host <IP_ADDRESS> port 22: Connection timed out
Please check the logs in the /var/log/parallelcluster/ folder of the master instance and submit an issue https://github.com/aws/aws-parallelcluster/issues

So I try to ssh to it and also get a time out.  I'm afraid I might have filled my disk running an application but not sure.  Thanks in advance for any help!
Lee

Hi Lee,
I'm going to close this ticket since we're following through AWS Support ticketing system.
Just as a reference we've been able to detect the root cause of the issue after providing head node instance id.
Enrico


Format for spike-in sequences

Hi
I am trying to include spike-in sequences for small RNA analysis. The libraries were made using the Qiaseq UMI method. I included the spike-in sequences as a fasta file or as a csv but both ended with errors. The same fastq files run fine with out the spike-in option enables. What is the format in which the spike-in sequences should be specified?
thanks

please provide a jobID of your failed attempt, example input files and example spike-in files.


Updates Markdown code blocks with correct types

Code blocks for HTTP requests should be of the following form.
```http
GET /articles/1
```

Code blocks for JSON data should be of the following form.
```json
{"key": "value"}
```

I've been wanting to get rid of javascript too.
But some of the payloads contain comments and/or ellipses, and these will be highlighted as invalid syntax if marked json. That's the reason for javascript. I'm sure this could be addressed through CSS, though.
There are quite a few blocks that contain both HTTP and JSON, and this PR turns them all into http. However, the highlighter seems to be smart enough to recognize an HTTP response header and a JSON payload inside a text block and format them accordingly. Makes no sense to turn those into http.
The magic doesn't apply to request examples, but I think I still prefer text — then, at least the code is uniformly non-formatted.

Thanks for taking the time to submit this PR @jfinkels. Would you mind re-basing this and updating to only use http in examples where the only content of the block is http?

Okay, now the pull request only changes HTTP request blocks.

Thanks @jfinkels!


Automated cherry pick of #2392: fix: qcloud change config failed

Cherry pick of #2392 on release/2.12.
#2392: fix: qcloud change config failed

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.12@58e8347). Click here to learn what that means.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             release/2.12   #2394   +/-   ##
==============================================
  Coverage                ?   7.06%
==============================================
  Files                   ?     454
  Lines                   ?   71632
  Branches                ?       0
==============================================
  Hits                    ?    5062
  Misses                  ?   66151
  Partials                ?     419

Flag
Coverage Δ

#aFlag
7.06% <0%> (?)

Impacted Files
Coverage Δ

pkg/compute/guestdrivers/managedvirtual.go
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58e8347...b30ce69. Read the comment docs.

/approve
/lgtm


Any way you could push 1.0.0 to CocoaPods?

Thanks 😄

Hey
I have to tell you that I messed up the push to the cocoapods repo if you want version 1.0.0 now please use
pod 'SentrySwift', :git => 'git@github.com:getsentry/sentry-swift.git', :tag => '1.0.0'
I will release version 1.1.0 today which will be pushed to the master repo ...
Stay tuned and thanks for pointing that out

Version 1.1.0 was released and is available in the master repo 👍

👍


BNCDeviceInfo.m line 81 CRASH

If there is a bug or error in this repo, please file the issue here.
If you need assistance integrating a Branch SDK, please email<EMAIL_ADDRESS>Thank you.
App is crashing on launch when it requests device info. Mostly occurs with iOS 9 and below but the issue has risen drastically in the last few days.
branch_crash.txt

Sorry to hear about your crashes!
We haven't updated that part of the SDK in a few months, and I don't have any other reports of crashing in that part of the code. I've tested it on iOS 7,8,9,10 and 11 devices.  So I'm a little perplexed about your problem.
Which version of the Branch SDK are you using? Are these crashes isolated to a particular kind of device?  Have you tried updating to the latest version of the Branch SDK?

@E-B-Smith
We are using Branch (0.12.16) via  mParticle-BranchMetrics (6.11.0).
Curiously, there was similar crash in Mixpanels' SDK this week, also when they we collecting device properties. They have since patched it, but it does seem odd to me that 2 SDKs would have such a tightly related problem in this close a time frame.
We will try updating to the latest. Looks like Branch (0.15.3) via  mParticle-BranchMetrics (6.14.0. We are always hesitant to upgrade when something is working well.
Here is the mixpanel stack trace if you are interested.
mixpanel.txt

The issue in that Mixpanel stack trace doesn't look related.
You can see the area of the code that is crashing here:
https://github.com/BranchMetrics/ios-branch-deep-linking/blob/master/Branch-SDK/Branch-SDK/BNCDeviceInfo.m#L61-L85
We get the country and local differently depending on the iOS version.  Maybe there's something about those particular devices?  How much of an increase are you seeing?  Are you getting an uptick of installs from a new region in the world?

I also appeared in my application the same procedure Fenbu, do not know is the Branch of the bug
branch_crash.txt

I also appear in my application, the same program crashes, do not know the branch bug
branch_crash.txt

Thanks for the extra information.
I'm working on this now.  If you have any more information about this please send it along!

Actually @E-B-Smith, I followed up with marketing, and in fact it is as it seems. Its quite possible the campaign generated more users outside of the US than we have ever done before. So the noticeable uptick in crashes is indeed very tightly linked to the locale for sure.
thanks for acting so quick on this.

I have a fix for this that is being tested now.  I'll post again when the fix is available.

This is fixed in release 0.16.2.


How long it is to convert whole LIDC dataset to nrrd ?

Hello Sir Michael, it is almost 48 hours since I start converting LIDC-IDRI datasets (1010 patients) into nrrd (nifty) file before preprocessed again into numpy by preprocessing.py at medicaldetectiontoolkit repo. However, it still load 60% of the progress
For my reference when preprocess my private dataset, do you have any solution or code to add in order to enchance the conversion using CUDA (Note: I am planning to reconstruct my database using Sir Michael code
Is it possible to enchance the speed of conversion using CUDA core, since you are using 3rd party MITK software to convert it to nrrd (nifty) file?
Thank you Sir
PC Used:
Intel i7-7700, 16GB RAM, NVIDIA GTX1050Ti 4GB

I cannot exactly tell you, but the code isn't written with performance in mind. I think it took me about 1 day?
I think including some CUDA-cores wouldn't significantly speed up the progress. There is not a single, computing-intensive part of the programm, rather the simple programming (with a different focus than speed) is the main reason.
For example, in the XML files, there is no direct link to the corresponding DICOM files, instead those are searched using GLOB, which makes it quite slow. Another reason are the sheer number of patients, there are more than 1000 Patients, so if the processing of each patient takes more than 2 minutes, it already adds up to more than a day.
However, I am happy to include any suggestions for speed-up.

Thank you Sir Paul, I finish processing all the data around 3,5days


I can't remove the app on Android

The installer crashes all the time on my Samsung S6. Now what?

You can't install or you can't remove it?
 Cordova is a well tested framework. So it's fault of samsung/android. (I own S8 and oh God it's buggy)

Installing was fine, uninstalling crashes.
Marcel
Op 14 jun. 2017 10:11 schreef "Egor Homakov"<EMAIL_ADDRESS>
You can't install or you can't remove it?
 Cordova is a well tested framework. So it's fault of
samsung/android. (I own S8 and oh God it's buggy)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/sakurity/securelogin/issues/27#issuecomment-308355608,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAH-smzvkbiX8dbAmy8SP-bMce7MM-Bsks5sD5W0gaJpZM4N5a_t
.

Screenshot attachef

rolled out new version - hopefully after update it will be possible to remove?
anyway, cannot really do anything: this is bug of android

Yes, fixed!!

oh, than it must be Cordova bug. this software is still largely experimental, not tested with most devices


:recycle: Refactoring Code with various improvements

Hi! I'm a future student, joining Epitech for the 2027 session.
This project is really nice to check compliance with Epitech C Coding Style.
I have started to refactor the code of this project as I've seen some unpythonic things.

Unit tests seems to fail. This PR can only be reviewed if the unit test works

Unit tests seems to fail. This PR can only be reviewed if the unit test works

The unittests are failling before the first commit of this pr, see #17


Application Does not Deploy

I was unable to push this application to Cloud foundry. I have relevant part of the log attached below. Please point me to the right direction, thank you
Log
2018-07-09T18:20:37.69+0000 [STG/0] OUT        WARNING A newer version of dotnet-framework is available in this buildpack. Please adjust your app to use version1.0.11 instead of version 1.0.5 as soon as possible. Old versions of dotnet-framework are only provided to assist in migrating to newer versions.
2018-07-09T18:20:40.87+0000 [STG/0] OUT -----> Installing dotnet-framework 1.1.0
2018-07-09T18:20:40.87+0000 [STG/0] OUT        ERROR DEPENDENCY MISSING IN MANIFEST:
2018-07-09T18:20:40.87+0000 [STG/0] OUT
2018-07-09T18:20:40.87+0000 [STG/0] OUT        Version 1.1.0 of dependency dotnet-framework is not supported by this buildpack.
2018-07-09T18:20:40.87+0000 [STG/0] OUT        The versions of dotnet-framework supported in this buildpack are:
2018-07-09T18:20:40.87+0000 [STG/0] OUT              - 1.0.5
2018-07-09T18:20:40.87+0000 [STG/0] OUT              - 1.0.10
2018-07-09T18:20:40.87+0000 [STG/0] OUT              - 1.0.11
2018-07-09T18:20:40.87+0000 [STG/0] OUT              - 1.1.2
2018-07-09T18:20:40.87+0000 [STG/0] OUT              - 1.1.7
2018-07-09T18:20:40.87+0000 [STG/0] OUT              - 1.1.8
2018-07-09T18:20:40.87+0000 [STG/0] OUT              - 2.0.0
2018-07-09T18:20:40.87+0000 [STG/0] OUT              - 2.0.7
2018-07-09T18:20:40.87+0000 [STG/0] OUT
2018-07-09T18:20:40.87+0000 [STG/0] OUT        ERROR Unable to install required dotnet frameworks: dependency dotnet-framework 1.1.0 not found
2018-07-09T18:20:40.87+0000 [STG/0] ERR Failed to compile droplet: Failed to run finalize script: exit status 12
2018-07-09T18:20:40.88+0000 [STG/0] OUT Exit status 223

change the version for dotnet-framework to 1.1.8

Did you try that? Because it does not work.


add --deploy-to path/to/deploydir

The 5.0.2 version builds only one javascript and index.html plus resources. The new qx compiler puts plenty of other files into the build folder. They are not all needed for deployment and could cause a possible security issue, if installed as is.

There are a few files which have crept into the build that I don't understand why they're there - app.png (which is the Qooxdoo logo) and js_256x256.png (which is some kind of javascript logo).
Of the rest of the files the only ones which are not required are build-data.json and *.map; the .map files are part of the target and need to be there, although I agree that they would normally be excluded from your deployment process.
Potentially we could add a --deploy-to <directory> option to qx compile which would copy the essential files to a deployment directory?

I agree, this would a good solution.

I agree as well

To add a bit more detail about this... The first application listed in compile.json is now the one whose index.html is copied to the root. Other necessary files, however, are not copied to the root, e.g., favicon.png, which means that if the app is accessed as /myApp/index.html the favicon shows on the tab, but if it's accessed as /index.html, the facicon is not shown on the tab.

when building multiple apps it would be great to have a way to specify a separate index.html or rather a separate boot directory for it ...
one option would be to structure boot the same as the resources directory in that it has subdirectories per app and if the app is missing then it gets the defaul settings ...
whatever is in the toplevel boot would end up in the root of the *-output tree

Updated title.

For first compile of a source target, how about we output a message to the console in big friendly letters saying that the build version will be much smaller?

Good idea. This will reach people who might not have read the info in the getting-started-guide.
An alternative to a deployment switch would be to output the paths to the directories containing the deployable code when using a "Build" target.

It has just been brought up on the main chat that source maps leak information on paths on the development machine. They should be excluded from the deployed source code bundle. This reinforces the idea that we should have a dedicated command to export deployable code. This would avoid that we have to document such internal stuff.

Maybe the most natural solution is to ship a separate compilation target --target=deploy which would automatically remove all unneeded code and copy stuff into, i.e., a deploy folder in the root (not under compiled)

Copy it into a folder compiled/deploy...

@johnspackman What would be the best way to create a deploy target that inherits from https://github.com/qooxdoo/qooxdoo-compiler/blob/master/source/class/qx/tool/compiler/targets/BuildTarget.js ? Would it make sense to factor out some stuff there that could be then be overridden?

It has just been brought up on the main chat that source maps leak information on paths on the development machine. They should be excluded from the deployed source code bundle.

That's seems to be a bug. I never saw this

It's in the source maps. That's why they need to be stripped from the build files.

You are right. Overriding BuildTarget should work.

This deploy target could also minimize the number of files - preferrably just one javascript file plus the resources.

Ideally, the deploy target never produces the source map files in the first place instead of stripping them out afterwards - this should save a bit of time?

Wait... That source map is necessary on the target machine. Otherwise, you can't figure out where the error is really occurring from the browser.

But if the sources are not available - which they aren't in a deployment scenanrio - a source map doesn't make sense, does it? I would think that if an error occurs that cannot be figured out in a deploy build, you have to locally debug it in a "build" build with the sources present.

No. If I can find out at the browser where the error is occurring, I can look at my sources. In my case, the only environment that works is "build" as the app needs to establish websockets so is tested in a (development) true deployment. But an app could "phone home" and report an error including where it occurred, and someone could fix it and build a new version, too. @johnspackman indicated that he uses this feature at customer sites as well.

That's right, but the problem with sourcemaps is that in an untrusted environment the sourcemaps have the side effect of leaking information about file names and directory structures; although this is minor, it is worrying because ultimately it is leaking private data.
The original issue is that users look at the target output directory and see a massive bunch of files, and it is not clear what they need to deploy (and could reasonably assume it's everything, which is massive).
On reflection, I don't think that we want a separate "deploy" target because that would just duplicate all the massive number of files in the "build" target ("source" target is similarly large, with its own resources and transpiled directories).  Also, the "build" target is what the developer is likely to be testing against, and also what is likely to be deployed (with source maps) onto private testing servers.
When releasing to the end users, it is not a good idea to introduce a whole new build process which is effectively untested.  That's really crucial for repeatable testing, you only deploy the version that was on the testing server, you do not recompile because eventually something will go wrong.
Our goal here is just to simplify the deployment process, and make sourcemaps something that you can turn on/off.  As sourcemaps are being suppressed for security concerns, but OTOH sourcemaps are so very useful, IMHO you should have to them turn on explicitly, but the deploy would issue a warning if you do not turn it on.
This would suggest that qx deploy runs the compilation process for qx compile --target=build and then copies the relevant files into the deployment directory (because the build compilation is very expensive, this would benefit from making sure that the compiler only actually runs & minifies etc if the code has changed).

I'd say we create a default "deploy" target without source maps. Anyone who wants to continue to use them can use the "build" target as before. I find it important, also for PR reasons, to have a compile target which is as small as possible, and has as few files as possible. There have been many requests for that on the main chat and I think that is an important selling point.

...just saw @johnspackman's post - qx deploy is fine for me too, although I like the idea of a separate target better since it fits well into our current design and can be realized without extending the API.

I'm going to try and work on this today, along with combining output into a single file (famous last words... :sigh: 😉)


Error on: https://www.kamu.dev/blog/kamu-update-2021-03/a-brief-history-of-time-in-data-modelling-oltp-systems.md

I got the following 404 message:
404 Not Found
Code: NoSuchKey
Message: The specified key does not exist.
Key: blog/kamu-update-2021-03/a-brief-history-of-time-in-data-modelling-oltp-systems.md
RequestId: 01G5V90P4WF6CQHJ
HostId: rs8UsRwKOGeyavaJ0zaRii+UCYvF381jf7YWjzw2p0Z9sUf2S/aOulr2QotbMxl90ucNtgAz9sA=

An Error Occurred While Attempting to Retrieve a Custom Error Document
Code: NoSuchKey
Message: The specified key does not exist.
Key: error.html

The link is fixed now, thanks a lot for reporting!


Annotation support via Custom resource

Is this a BUG REPORT or FEATURE REQUEST?
Feature Request
Choose one: BUG REPORT or FEATURE REQUEST
As we are building admin use case, target namespace might have AWS IAM role access. To get this access from admin use case we need a capability to send the annotation of Target IAM roles via Custom resource, so that when we can runner and engine, they honor the annotation of IAM roles. This is a use case for AWS, but it might application to other use cases too. We should be override the annotation as well as send the annotation.

What happened:
EC2 use case for terminate a pod from different namespace.
What you expected to happen:
There is no way we can pass IAM role information via CR. as well as operator won't pass this to experiment pods.
How to reproduce it (as minimally and precisely as possible):
you can use job and reproduce that, where adiding job for given experiment will work but triggering via chaos litmus operator won't work.
Anything else we need to know?:
We are working on fix, and share the details.

Custom annotations are supported via an operator ENV today (https://github.com/litmuschaos/chaos-operator/blob/master/pkg/controller/resource/resource.go#L40). An example usage on the operator ENV would be:
apiVersion: extensions/v1beta1
kind: Deployment
metadata:
  annotations:
    deployment.kubernetes.io/revision: "1"
    intuit.io/aws: "true"

We did consider making this a ChaosEngine spec item initially, that takes both custom annotation key & value. Some thoughts were:

The annotation fuels a one-time check (entry gate for chaos).
It is also something that we have generally seen stay consistent across a group of apps OR cluster (say, users want custom annotations w/ their apigroup/org references over litmus)
The ChaosEngine Spec today consists of a considerable set of spec items (appInfo, runtime properties, experiments section) which we felt should be enhanced/increased only if really necessary (also helps automation of engine creation itself).

Another thought has been to provide an annotation whitelist, i.e., a set of annotations that operator can compare against to determine selection for chaos. Would this help?
In cases where annotations are used inside experiment business logic itself, we could pass it as an ENV in the experiment spec of the ChaosEngine.
Having said that, open to other viewpoints that we can discuss.

Transferring to #litmus repo for milestone/project level prioritization and tracking.


Oksana_Kachmar_qa_cypress_e2e_alerts_Solution

Good job
But I think it will be better if you create variables for notification messages and alert text


[Feature] Added new Navbar as per design

Issue ref: #157
I have added the new navbar component as per design.
Pending issues:
The wallet connect button (Web3Button ) component's styles couldn't be modified, there is no property built into the component to modify it.

Great, Thanks!


Remove dev-only features

Ignores features of dependencies that are only used for dev dependencies. I think this can cause build error, but lets see.
So maybe we need to add the features directly into the deps. Downside is that this will cause build errors when the tests are run without that feature.
Another way is to just call the strip command as part of the release process and never push the result of that. I think this would be the most correct way.

Ideally, tests shouldn't require additional feature flag. They should be unconditionally enabled in dev-dependencies. There could be exceptions such as some features could be mutual exclusive (which is a code smoke) but we don't have those atm.


Add binding to useWindowDimensions hook

This hook has been added in RN 0.61.0 and is (according to the release notes) intended to replace most uses of various Dimensions methods.
Dimensions.t type is called DisplayMetrics in RN, and that type has accordingly been renamed displayMetrics.

Sorry for the delay to review all of this new awesome stuff. I will merge that as soon as I released a patch release for 0.60


fix paths

hiyo
quick fix :)

seems server does redirect transparently so never saw it.
LGTM. Thanks!


verifiablePresentation typo fixed

see P&A ticket: https://github.com/Open-Credentialing-Initiative/Digital-Wallet-Conformance-Criteria/issues/25

Since this is a minor typo changes, I have used this ticket to walk through the entire process from editing to merging in order to document the steps in our internal SOP.


Rewrite vue-video-player in typescript

The vue-video-player is a fairly simple wrapper around video.js, that works ok enough. However, it lacks type symbols, some of the font loading doesn't seem to play well with our type system, etc. It should be fairly easy to reimplement it in typescript, and gives us more flexibility in working with video.js, since we may be doing odd stuff with it.

Unpopular opinion: ditch the type system :P

Ok, update on this:

The type system wasn't the problem, my lack of understanding of how to work around the type system when using non-typescript libraries was.
The fonts weren't a problem, my lack of understand of how webpack worked was.

So, types and fonts are figured out. However, this still leaves a much larger issue: this package is missing some events and features of video.js, which would be quite useful for us. Not only that, since we're now using Video.js to control both 2d and VR video, we may want our own hooks closer to the video.js library.

If you have time, could you add a list of things that are missing in your opinion?

No longer required. Another 10 months of typescript and vue experience have gotten me what I needed without reinventing wheels.


Why TaskDelegate subclasses are internal?

Hello everybody. I was wondering what where the reasons to make such classes as UploadTaskDelegate, DataTaskDelegate and DownloadTaskDelegate internal? They have a bunch of closure-typed properties that, if exposed, would allow to easily add different handlers for NSURLSessionTaskDelegate methods for each individual Request.

These were never intended to be used publicly. They are only implemented to allow internal customization of Alamofire handling. You already have the ability to override everything at the session level through the Manager.SessionDelegate. If you can come up with some examples of what you can't currently do because of this design, then we'll certainly consider the proposal. But at this time we have no intention of opening up those APIs.
Cheers. 🍻


Gradle sb fix

Just started reviewing :) :octocat: Sent from GH.

Merged, thanks! See 9c7e2f7...652b716 :octocat: Sent from GH.


Can not build AFNI using Neurodocker

Hi:
I am getting the following error during the build of AFNI using a dockerfile generated by neurodocker:

configure: Need to download and build NLopt
trying URL 'http://ab-initio.mit.edu/nlopt/nlopt-2.4.2.tar.gz'
Error in download.file(url = "http://ab-initio.mit.edu/nlopt/nlopt-2.4.2.tar.gz",  :
cannot open URL 'http://ab-initio.mit.edu/nlopt/nlopt-2.4.2.tar.gz'
Execution halted
/bin/tar: This does not look like a tar archive
gzip: stdin: unexpected end of file
/bin/tar: Child returned status 1
/bin/tar: Error is not recoverable: exiting now
Warning message:
In untar(tarfile = "nlopt-2.4.2.tar.gz") :
'/bin/tar -xf 'nlopt-2.4.2.tar.gz'' returned error code 2
configure: Starting to install library to /tmp/RtmpqWSb5X/R.INSTALL4236c845677/nloptr/nlopt-2.4.2
./configure: line 3325: cd: nlopt-2.4.2: No such file or directory

The docker file was generated using the following command:

docker run --rm kaczmarj/neurodocker:master generate -b ubuntu -p apt --afni version=latest use_binaries=true > afni_docker

I get the same error if I do not include the 'use_binaries' flag.
The build is then initiated using:

docker build -f afni_docker -t afni .

My docker version info:

docker version
Client:
Version:      17.06.2-ce
API version:  1.30
Go version:   go1.8.3
Git commit:   cec0b72
Built:        Tue Sep  5 20:12:06 2017
OS/Arch:      darwin/amd64
Server:
Version:      17.06.2-ce
API version:  1.30 (minimum version 1.12)
Go version:   go1.8.3
Git commit:   cec0b72
Built:        Tue Sep  5 19:59:19 2017
OS/Arch:      linux/amd64
Experimental: true

The build proceeds for quite a while, but appears to get stuck while installing R packages, at this line in the generated dockerfile:

/opt/afni/rPkgsInstall -pkgs ALL

The error is strange, because if you copy / paste the troublesome url into your browser:

http://ab-initio.mit.edu/nlopt/nlopt-2.4.2.tar.gz

the download starts and completes.

Hi @ross-mitchell - thank you for the report. I was able to replicate your issue. The download error is a little misleading, but lines right above it are telling:
checking nlopt.h usability... no
checking nlopt.h presence... no
checking for nlopt.h... no

Turns out the system package nlopt can be installed with apt-get, and then the R package will install successfully: https://stackoverflow.com/a/38340228/5666087
For now, you can manually add libnlopt-dev to line 57 of your Dockerfile, before the trailing slash. I will put out a patch later today.
As an aside, it is good practice to use specific base images, like ubuntu:16.04 as opposed to ubuntu, which is equivalent to ubuntu:latest. The latest tag corresponds to 16.04 in this case, but this mapping can change over time.

@ross-mitchell - if this fix works for you, please feel free to submit a PR. This line would have to be modified to install libnlopt-dev. I am happy to do this, but it would be nice if you got the credit for discovering this bug.

Will do. thanks for you help. The PR will not happen until this evening, due to circumstances…  - Ross
J Ross Mitchell, PhD
Professor of Radiology, Mayo Clinic College of Medicine
Senior Associate Consultant, Department of Research
Precision Neurotherapeutics Innovations Lab
Mayo Clinic, 5777 East Mayo Blvd., Phoenix AZ 85054
SSB 2-700

On Sep 26, 2017, at 9:57 AM, Jakub Kaczmarzyk<EMAIL_ADDRESS>wrote:
@ross-mitchell https://github.com/ross-mitchell - if this fix works for you, please feel free to submit a PR. This line https://github.com/kaczmarj/neurodocker/blob/b332a4f55f39973fff9458c7ed068bbf1400d25b/neurodocker/interfaces/afni.py#L124 would have to be modified to install libnlopt-dev. I am happy to do this, but it would be nice if you got the credit for discovering this bug.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/kaczmarj/neurodocker/issues/98#issuecomment-332265122, or mute the thread https://github.com/notifications/unsubscribe-auth/AM4sXK682CFScB_YqlQNSeBfVO1b0Dg4ks5smS0NgaJpZM4PjoKZ.

I know this is closed, but I'm running into this issue still using d02f8ed7940748348c1076da5163e217f3408d64 on master. It looks like this PR got refactored into this line https://github.com/kaczmarj/neurodocker/blob/d02f8ed7940748348c1076da5163e217f3408d64/neurodocker/interfaces/interfaces.py#L37? If so I'll make a new PR

@mattcieslak - yes, i forgot to include libnlopt-dev during the refactor. please submit a PR adding 'libnlopt-dev' to the apt portion of the line you linked above.
unfortunately i cannot see how to install nlopt-devel on distros that use yum (without having to use epel). for now, we can include nlopt installation for apt distros.