Way to exclude the citations from the demo by default?

Right now when creating the demo, all of the files from the contents directory are copied:
https://github.com/jupyter/jupyter-book/blob/master/jupyter_book/create.py#L124
Also, an unmodified version of /_data/toc.yaml which includes the Citations section is used, rather than a table of contents which does not include it.
Since this is also the source directory for the Jupyter Book website, there seems to be no non-hacky way to modify this repository to exclude including the citations in the demo without also breaking the website.
However, for someone using this tool for the first time, who wants to test it and see how it works, having the citations.md included causes problems, because GitHub pages will refuse to build the website, since the necessary Jekyll plugin isn't supported. Thus this presents a barrier to adoption for new users, which seems problematic for a new tool like this.
What would be the best recommended solution? An addition to the documentation asking users to manually remove that file and that section in the table of contents by themselves if they want to try to host the demo on GitHub Pages?
I would like to avoid the situation where someone tries to use this, gets this preventable error, gets frustrated, and gives up on it, because it really is a great tool.

This is a great point, I agree that it'll be confusing to people if the demo book doesn't work "out of the box". A couple ideas:

Here's the information message after the create process: https://github.com/jupyter/jupyter-book/blob/master/jupyter_book/create.py#L128
I wonder if we could update that to add a warning about the jekyll-scholar plugin?

Alternatively, we could modify the create.py module to instead remove the citations file entirely, along with the Gemfile dependency on Jekyll Scholar, and instead add more documentation on how to set up the repository for citations.

We could emphasize even more a build process where we aren't relying on the automatic gh-pages builds (maybe once @emdupre 's netlify tutorial and #293 are in the docs, we can stop telling people to rely on github pages?)

Lemme know what you think

If there's an elegant way to do 2. that doesn't make the code less modular, then it seems like a good idea. 3. is probably a good idea too although I admittedly don't really understand it.
In an ideal world I think 1. would also work out well, but to be honest I had forgotten that there was an information message after the create process, so possibly many people might not read it and therefore not realize it was helping them. So the extent to which it is a good idea depends on how lazy the average person is in comparison to me.

I agree that 2 is the most doable. 3 just means not relying on GitHub's automated book building process, and instead using things like Netlify and CircleCI to build/host the books (which would mean you can use any Jekyll plugin, not just the GitHub-approved ones)

Oh OK that makes a lot more sense. The freedom to use any Jekyll plugin does sound nice.

For a month or two, I've been trying to follow path 2, to build local HTML and push it to a repository, so my citations would work. I could never get the Ruby path to work, but Docker worked fine. There were some episodes of nokogiri being the wrong version, generating Github warnings, but I would ignore them, or repair them, or edit Gemfile.lock to a earlier version.
Now, in updating several of my JupyterBooks to version 6.2,  those that had working citations have reverted to the dreaded Liquid tag error, which means my attempts to follow instructions to send locally generated HTML to Github have stopped working.
To make it work in the first place, for one of my JupyterBooks, I had to do a Github hack to make it work, by creating an index.html file at the repository root that redirected from the root, the base URL, aka the subpath of my site, to _site/intro.html, where the html was that had been created by Docker using the .css files.
After talking to Sarah, at BIDS, who used to work at Anaconda, I decided the reason that twenty tries to make Ruby work had littered my anaconda3 world, and she emboldened me to wipe out anaconda. So I did.  Then, loaded miniconda. Then created a clean environment.
Hooray! For the first time, following the Jupyterbook instructions to execute conda install -c conda-forge rb-github-pages, everything loaded. Then, skip to the section named "Install Ruby Plugins" (better than saying  "the section using make install").
Hooray! Running make install actually works. Lots of stuff installs.
Hooray! make serve actually works. Everything looks perfect at <IP_ADDRESS>. The URL starts at my subpath, or root.  Everything is good. The bibliography, using {% bibliograpy %}, works perfectly.
Not so fast.  I can't just push it to Github and see the HTML. I put a .nojekyll file at the root.
Using GitHub Desktop (which should be part of the JupyterBook instructions, since new users trying to learn git commands, or trying to learn Atom git push commands, have just one more obstacle to using JupyterBooks} I push my new book to Github.
Hooray! No Liquid tag error.  Check out Settings.  Hooray! √ Your site is published at https://johngage.github.io/h1/  .But it's not.   404 File not found.
There is a .nojekyll file at the root: /h1 ; there is no index.html at the root.  Maybe the .nojekyll is in the wrong place?
_build has the HTML pages, but only partial HTML pages, with YAML at the top.  It seems that jupyter-book build h1 now generates .html files in _build, not .md files.  If I delete my local _build/ .md files, they are not regenerated by running jupyter-book build h1.
_site has full HTML pages, with all URL's starting at the root, or subpath: /h1.
The new _site/index.html is missing .html on all the redirects.
Where am I going wrong? The URL's all point to the root, and the HTML files are all in _site.
So building with Ruby route now makes a perfect JupyterBook, with a perfect bibliography, that I can see locally. The root is /h1. But the HTML is in _site. So the  make serve must adjust the path for the local server.
I just don't know how to move it to GitHub and have Github serve my locally-built HTML from the root.
I've tried rewriting the JupyterBook documentation where it's confusing.  It needs a little more explanation of what happens, where, when you run jupyter-book build, and make serve, and docker...............; and add what happens when you change the docker command to end in build.
============
Now to Docker.  It used to work perfectly.  Now, it doesn't work.
I have the newest image from emdupre; I deleted older images.
I run the exact Docker command that always worked in the past.
`(dockerenv) [BookJupyter]$ docker run --rm --security-opt label:disable  \

-v /Users/johngage/Repos/BookJupyter/h1:/srv/jekyll
-p 4000:4000
-it -u 1000:1000
emdupre/jupyter-book bundle exec jekyll serve --host <IP_ADDRESS>

`
It loads 107 gems.  And fails.  Here is the failure: jekyll 3.8.5 finds an uninitialized constant Faraday.
I remember seeing this two months ago, wrestling with Ruby.
I have no idea how to fix it. jekyll is in /usr/local/bin, and is version 3.8.5.
Here is the death of Docker emdupre
**_Bundle complete! 8 Gemfile dependencies, 107 gems now installed.
Bundled gems are installed into /usr/local/bundle
Post-install message from dnsruby:
Installing dnsruby...
For issues and source code: https://github.com/alexdalitz/dnsruby
For general discussion (please tell us how you use dnsruby): https://groups.google.com/forum/#!forum/dnsruby
Post-install message from sass:
Ruby Sass has reached end-of-life and should no longer be used.

If you use Sass as a command-line tool, we recommend using Dart Sass, the new
primary implementation: https://sass-lang.com/install

If you use Sass as a plug-in for a Ruby web framework, we recommend using the
sassc gem: https://github.com/sass/sassc-ruby#readme

For more details, please refer to the Sass blog:
https://sass-lang.com/blog/posts/7828841

Post-install message from html-pipeline:
Thank you for installing html-pipeline!
You must bundle Filter gem dependencies.
See html-pipeline README.md for more details.
https://github.com/jch/html-pipeline#dependencies
Configuration file: /srv/jekyll/config.yml
jekyll 3.8.5 | Error:  uninitialized constant Faraday::Error::ClientError
Did you mean?  Faraday::ClientError**
(dockerenv) [BookJupyter]$ which jeckyll
Thanks, Chris.  And thanks, krinsman.
John

Hi @johngage  --
Sorry to hear you've been having such trouble. A few ideas:
Can you confirm your _config.yml is listing the sub-directory you want as the start path ? Specifically here:
https://github.com/jupyter/jupyter-book/blob/780017fc6df1dfaf59faaaa9957d34ffeb2cd4a4/jupyter_book/book_template/_config.yml#L25
The Faraday error seems to have been in the octokit dependency, see here. That being said, I recently updated the Docker build image (and corresponding call) in https://github.com/jupyter/jupyter-book/pull/364; could you please try to run the image with:
docker run --rm --security-opt label:disable  \
   -v /full/path/to/your/book:/srv/jekyll \
   -p 4000:4000 \
   -it -u 1000:1000 \
   emdupre/jupyter-book

Let us know how that works for you. If you're still encountering errors, we can try to narrow down exactly where they're arising ! Sharing your generated book might help, here.

Closing as this should be superceded by beta.jupyterbook.org


single prompt being used in training

Hi,
currently the code seems to be hardcoded to use only num_rollouts(configured to 1 here) for training, regardless of the number of epochs, as can be seen in the prompt_dataloader creation in PPOTrainer (here). Is there a reason why? Also why is num_rollouts configured to 1? Thanks

hi，now it supports to change the default config in ppo_configs. In the future, the ppo_config will be converted to a yaml file, and users can change the configs in a yaml file


Update UG and DG

Coverage remained the same at 91.435% when pulling d1824cae63dde652a04574a984d7b0eed9a535cb on Valerieyue:Documentation into e6f59e73e30c62d628d7f0612d2f8e6bce2aed01 on CS2103AUG2017-T16-B3:master.


[PORT] disable unused codeSignValidationInjection task in main CI

Port this change from botbuilder-dotnet/master branch:
https://github.com/microsoft/botbuilder-dotnet/pull/4056

Partially addresses: #4055
Build 137843 for these changes has a total duration of 21min and 16s:

The last successful build (137707) took 27min 12s to complete:

This PR speeds up the build by disabling the auto-injected "Run Codesign Validation" task, which was running at the end of our stages.  This task automaically fetches an internal tool for the codesign validation step and applicable .NET Core SDKs before eventually skipping the workflow, a process that takes around one minute.
Searching for the variable name, there were other Microsoft projects that also disabled this task as it was N/A. (https://github.com/microsoft/terminal/pull/4387 and https://github.com/microsoft/react-native-windows/pull/3923)

This is applicable, but these Azure DevOps pipelines still run in Classic. This means that any changes would be committed in Azure DevOps, not in this repo.
Unsure of the priority for this issue as Java isn't currently at parity or prioritized.
Applying correct Pillar label and adding to project for tracking.


refactor(prettier): add call_arguments.rs

Current dependencies on/for this PR:

main

PR #2393   👈

This stack of pull requests is managed by Graphite.

Merge activity

Feb 11, 10:16 AM EST: @Boshen merged this pull request with Graphite.


Link leads to 404

On this page: https://gleam.run/getting-started/installing/#installing-gleam
There is a link to AUR page: https://aur.archlinux.org/gleam.git
However the page on AUR does not exists.

Thank you.


[BUG] Space station not docking modules, then crashes when I return.

[Please fill out the form below and delete the sections in square brackets after reading them]
Version of Advanced Rocketry

[1.12.2-1.6.0-162 universal]

Why is this important?
Knowing the version of Advanced Rocketry helps us narrow down an offending piece of code faster because we can easily determine what code is added and when.]

Have you verified this is an issue in the latest unstable build

[x] Y

Why is this important?
If you're not testing with the latest build, you may be encountering a bug that's already been fixed.
Reporting bugs that have already been fixed wastes everyone's time.  (please look in open issues too, somebody else could have already reported it!)

Version of LibVulpes

1.12.2-0.4.1-1-universal

Why is this important?
Advanced rocketry depends on a library mod (LibVulpes), some errors can really be in that mod.  So knowing the verison helps us not only start looking for fixes there without you needing to anwer more questions, it also helps us know if you have a version mismatch.

Version of Minecraft

1.12.2

Why is this important?
Different versions of minecraft have different codebases for Advanced Rocketry.  Knowing the version of minecraft (and thus AR) helps us pinpoint issues quicker!

Does this occur without other mods installed

[x] Y

If Y, what is the MINIMUM set of mods required.

Why is this important?
Sometimes interactions between mods cause issues.  While it can be a problem with Advanced Rocketry, sometimes it's not.  When there are a lot of mods, it can take bugtesters HOURS to go through the list to determine the root cause.  When there are a lot of bug reports, that can add DAYS to the time it takes to fix a large set of issues.

Crash report or log or visualVM (if applicable)
http://pastebin.com is a good place to put them
crash reports that are put in the issue itself are
hard to read
https://pastebin.com/kyk31j2z

If it's an issue involving lag, please submit a visualVM sampler snapshot.  Mods like lag goggles often do not provide the kind of information needed to debug lag.
For more information on how to create a snapshot, please see "How to Run CPU Sampling" here.  Then export the snapshot as an .nps.  You may have to zip it since github is weird, then please upload it here.

Why is this important?
Full crashlogs contain valuable information like where exactly in the code the error occurred, what other mods may be running and what version of forge you have.  This helps us replicate and diagnose the issue FAR faster.

Description of the problem
When I try to dock a new module to my space station, it does not get attached, the space station container that I built it in is deleted from the rocket's satellite bay, and then the game crashed when I tried to land the rocket back in the overworld.

Why is this important?
If we cannot reproduce the problem, we probably cannot fix it at all.

How exactly are you docking them?  What names are you using in the docking ports?  What are you putting on the rocket carrying the module up?  Are you going up on the same rocket as the module?  Does it have a guidance computer?
Would you be able to get me a copy of the crash report generated with only AR and libvulpes installed?

I am going up in the rocket when I send a module up. It has a guidance computer and a satellite bay in it. When this happened, the rocket also started landing on top of the center of the station again instead of the designated docking pad.

When I run it in an isolated instance, the mod works but that same error appears in the log file.

Does the guidance computer have a chip in it?  If so what's on the chip?
Can you post the log file from the isolated instance?

I'm not able to replicate the issue with the docking port as of yet, however I was able to get the stack trace to print though the game doesn't crash.
I have tested building a rocket containing a guidance computer, a seat, and a satellite bay.
The station container contains a build with a docking port with the target name "test".
The space station in orbit contained a docking port with the name "test".  The station container was loaded into the satellite bay on the rocket.  A chip programmed with the target station was loaded into the guidance computer.  The rocket was then fueled and launched with my player onboard.  After reaching orbit, it descended and landed on the station.  The module I built had been moved in place as expected.
I have however been able to replicate the stacktrace upon landing.  The game does not crash, but an error is printed.  I will fix that.

5c17933d61135f6af5c10f14ebe09846c78468b2


Unable to use

Not available after adjusting setting offset pixels

Could you please be a little bit more descriptive? What did you do? What steps I can follow to reproduce etc.?

I Adjusted icon left pixel -6or-11，Software cannot render，cannot be set.

I Adjusted icon left pixel -6or-11，Software cannot render，cannot be set.
I used version 1.5 backups to overwrite and cannot restore.Updating later did not restore

Could you please be a little bit more descriptive? What did you do? What steps I can follow to reproduce etc.?

I Adjusted icon left pixel -6or-11，Software cannot render，cannot be set.
I used version 1.5 backups to overwrite and cannot restore.Updating later did not restore

I still don't really understand. Do you have a log of the developer console of obsidian?

obsidian.md-1685801292046.log
I Adjusted icon left pixel -20

Okay, I see the error now in the logs, thank you. This issue should be resolved in v2.1.1 and is related to #189.


Record videos using the native camera

Hello,
Does this plugin also incorporate the native camera's ability to take pictures and record video? Or does it only take in video feed and put it into a game object? If that's the case, then what's the difference between this and the WebCamTexture that Unity comes with?
Thanks,
Kevin

Hi Kevin,
This plugin was not created with this purpose but you could modify it to take pictures and record video since you have access to the Android Camera2 APIs.
Years ago when I was working on this, the WebCamTexture did not provide a way for me to capture the RGB frames so that I could pass to a library that I was using.
If this requirement came to me today, I would prefer starting with https://github.com/Syn-McJ/TFClassify-Unity-Barracuda.


Add Google Colab link?

Hey! I saw @josevalim 's youtube video announcing BumbleBee and noted that he didn't have easy access to a GPU to demo.
I know that Fly.io is great for hosting Livebooks, but doesn't support GPUs. SOOOO ->
I put together a google colab notebook that runs LiveBook w/ BumbleBee and CUDA support here ->
https://github.com/lukegalea/LiveBook_GoogleColab/blob/main/Google_Colab_hosted_Elixir_LiveBook_%2B_BumbleeBee_on_GPU_(Stable_Diffusion_%2B_GPT_2)_v1_0.ipynb
If you've got Colab Pro+, you can assign a high memory, high performance GPU instance and have 52GB of RAM and 40GB of VRAM, enough to run something like GPT-J, etc.
Think it's worth linking to?
I could easily make it so you can choose to add bumblebee support or not to make it faster & cheaper to launch for those who just want Livebook alone.

Hey @lukegalea, great work setting this up! Unfortunately ubuntu18 (specifically old glibc) may cause issues for XLA users (https://github.com/livebook-dev/livebook/issues/1598#issuecomment-1361587410). I think if we wanted to link to such setup in the readme, it should always work for everybody. In particular, the Elixir version, or dependency-specific setup like the tokenizers build can easily get out of sync.

Yeah, I think the TL;DR is that we definitely want to support Google Colab BUT we need a more up to date environment, unfortunately.
@lukegalea can you please reach out once Google Colab updates their stack? Thank you!


Feat/cs 36414

includes changes requested by SRE team in ticket CS-36414

@abhinav-from-contentstack Any version updates required?

I don't think so netraj. Because as part of the release, all packages are being updated to the next major version.


Needs a small clarification - when will the auto upgrade occur

Tutorial is good except for those confusing items :

NodeImage ( which is the Node OS Upgrade channel ) and node-image.

it is not clear when the upgrade happens if a use has NOT set a maintenance window

@tshaiman
It would be great if you could add a link to the documentation you are following for these steps? This would help us redirect the issue to the appropriate team. Thanks!!

@AjayBathini-MSFT  : sorry , I've accidently remove the template
https://learn.microsoft.com/en-us/azure/aks/auto-upgrade-node-os-image

@tshaiman
Thanks for your feedback! I've assigned this issue to the author who will investigate and update as appropriate.

@tshaiman, Thanks for the feedback.

I agree, having NodeImage and node-image can be confusing. They effectively accomplish the same thing, but some customers still rely on the NodeImage cluster auto-upgrade channel, which was the only way to automate node image upgrades before the node OS auto-upgrade feature was released.

If no maintenance window is set, you can expect maintenance to occur whenever a version is available for your cluster's region. You can check availability using the AKS release tracker](https://releases.aks.azure.com/webpage/index.html).

@Nickomang  thanks for the detailed explanation.  so you suggest us to use only node-image ?

@tshaiman, You can use either the node-image Node OS upgrade channel or the NodeImage cluster auto-upgrade channel, the behavior should be the same.


Test working of the plugin with Loklak API

Closing for now! As I have tested it on my online installation


add nvptx vendor intrinsics and initial no_std support

stdsimd does currently not compile as is with #![no_std].
This PR adds the "nostd" crate feature that enforces #![no_std] and ci test to cover this.
The only dependency stdsimd has on std is std::os::raw::c_void, which I've worked around by c&p c_void into the x86 module.
Once we merge ARM run-time feature detection it will also get a dependency on std::fs.  The plan is then to split stdsimd into a core component, and a std component.

The nvptx intrinsics are always available independently of the architecture, but one can only call them from an nvptx kernel.

This looks OK to me. r? @alexcrichton

@alexcrichton I am not suggesting that we should stabilize nvptx intrinsics any time soon, but...
Currently compiling CUDA code using Rust requires three unstable features: abi_ptx, untagged_unions (isn't this stable already?), and platform_intrinsics.
So... if we were to ever stabilize this... that basically cuts it down to abi_ptx.
In the mean time this allows those interested to implement and use these intrinsics on unstable rust without having to use platform_intrinsics or hack into the compiler.

we would need to figure out a way to use cross to at least tests that kernels compile properly.

we don't really need cross to use the nvptx targets though. Emitting NVPTX doesn't require any system library or tool and there's no binary distribution of core for these targets either so Xargo is enough -- provided that you have the target specification file around since these targets are not built-in.
(semi on-topic: I'd like to see cargo build to Just Work and directly generate NVPTX as the output artifact but there's no such thing as a standalone NVPTX linker (there's no NVPTX object forrmat either) -- you can use clang as a linker to link bitcode but that's too big of a dependency. What we could do is something like what's being done for the new wasm target: set obj-is-bitcode to true, force LTO and have LLVM do the linking under the hood.)

we don't really need cross to use the nvptx targets though.

Yes, the problem is not compiling, but running the tests.
So what I was thinking is using cross just for running the tests. Instead of using qemu-user we would use, e.g., ocelot, to run the PTX kernels on x86. I haven't used ocelot myself though, so I don't know how good this could work.

(semi on-topic: I'd like to see cargo build to Just Work and directly generate NVPTX as the output artifact but there's no such thing as a standalone NVPTX linker (there's no NVPTX object forrmat either)

Even less on-topic: I'd like to just be able to stamp a #[kernel] attribute to a Rust function or closure, compile my code with cargo build --kernel-targets="x86-avx2,nvptx-sm30", and be able to call the kernel transparently in the CPU and also launch it as a GPU kernel.

Nit: Cargo features should be additive (couldn't find a better link but Steve has mentioned this), so it'd be better to have a std feature that's enabled by default.

@mattico thanks, looks better now :)

Is there a URL at which we can point the documentation to as well? Something like Intel's source of truth for these intrinsic definitions?

@alexcrichton probably the CUDA API docs are the closest thing to that. The problem is that CUDA considers these to be part of the CUDA language, we only see them as intrinsics here because CUDA Rust is not a thing.
So I am going to link those there and also link the docs of the LLVM's NVPTX backend but I will mention that these intrinsics are experimental and if you don't know what they do you probably shouldn't be using them.
I still think this is pretty exciting. If we get @japaric's https://github.com/japaric/cuda and nvptx libraries to work on top of this, we might one day offer CUDA on stable Rust "as a library" by just stabilizing these.


New Endpoint API in 3.1.x

I am implementing a new endpoint API for the upcoming version 3.1.0 of the library. The new implementation only affects the server implementation.
With the new API it is possible to open as many endpoints as required. Even multiple unencrypted TCP endpoints are possible. Each open endpoint has an assignable ID so that the server handlers can check where a certain client belongs to. This allows treating intranet connections differently than external ones etc. Furthermore the API for configuration (options) is aligned and no longer implemented twice etc.
@JanEggers I ported the ASP stuff so far. Please have a look if there are more obsolete classes in the ASP.NET project. My plans for the next version are to get rid of all obsolete stuff.
@JanEggers While checking the ASP.NET code I found a client side implementation for a Span based adapter. Isn't this a part for the regular library which should be used when supported by the target platform (#if etc.)? Are you using this adapter in your projects?
@JanEggers @SeppPenner Please have a look at the API and let me know what you think. I am still working on some bits like exposing the endpoint ID in event handlers etc.
All others are also welcome to have a look and giving feedback before the API is final and released.
The branch is: feature/Server_Endpoint_API

My plans for the next version are to get rid of all obsolete stuff.
just make it clear in the docs.
for me it is confusing now as you allow asp.net core 2.1 but when using 3.1 you removed the methods  that are required for 2.1 but obsolete in 3.1.
I would prefere a clean baseline here. So if you remove methods that are obsolete in 3.1 then remove the support of aspnetcore 2.1.

Im personally on net5 now so I dont mind ditching anything older than that. that would also enable us to cleanup docs as we dont need to document how to use it for each different version as there are slight differences.

While checking the ASP.NET code I found a client side implementation for a Span based adapter. Isn't this a part for the regular library which should be used when supported by the target platform (#if etc.)? Are you using this adapter in your projects?

yes I use them. but Id rather wait for the official pipeline based network stack from microsoft and use that once its ready.

also there is some commented out code so im not sure that this was intentional / is still working

@JanEggers Do you mean the code that I removed is for ASP 2.1 etc.? I removed it because it was declared as obsolete. So is this NOT obsolete and still required? If that is true I will revert the deletions but also remove the obsolete declaration.
The code which is commented out needs to be reviewed and migrated if required. But for now I want to talk about the general idea behind these endpoints.
For the pipeline thing I would like to create a separate library which can be uploaded as a nuget and maintained separately. What do you think about that idea instead of having this "hidden" in the ASP.NET library?

regardning the obsolete stuff:
it is required for asp.net 2.1 but obsolete in 3,1. so I also marked the method as obsolete because it is calling an obsolete api of aspnet. the issue is that it is dependent on the version of the aspnet stuff. I dont know if that makes sense...

For the pipeline thing I would like to create a separate library which can be uploaded as a nuget and maintained separately. What do you think about that idea instead of having this "hidden" in the ASP.NET library?

sounds good for me

I will close this for now because the feature is delayed to version 4.x.


TextBoxHelper.ClearTextButton show error

if I add this as resource in App.xaml, TextBoxHelper.ClearTextButton will display wrong.
<Style TargetType="TextBlock">
    <Setter Property="FontFamily"
            Value="Microsoft YaHei UI Light" />
</Style>

@Cologler it's not recommended to make a default TextBlock syle for the hole application, this have some bad side effect e.g. to TabItems...

Could you specify the font for TextBoxHelper.ClearTextButton?


Lots of false postive on SQLi scanner

Hey @coffinsp
I have tested the SQLi scanner and notice that the result is totally different the tools does not managed to detect the SQLi I used your old tools on one of the vulnerable target it detect the SQLi but this scanner can't it give 0 result but the BSQLi tool give 5 please make changes

bcz its uses urlencoding to encode all payload and show results you can test without urlencoding payload that show while scanning testing with xor.... payload use it without encode and try..


Pass ResourceContext to ResourceCandidate

if no ResourceContext is passed on ResourceMap::GetValue, a new context will be created and scoped to that function. Once GetValue returns, the context is deleted. To keep context alive, we pass ResourceContext to ResourceCandidate instead of the raw handle.

/azp run


Ultra mega  Soap

Your checklist for this pull request
Author name
Author: Joser1109

About your game
Stickman scared of dingle. Use soap dingle, Be careful the soap is omnipotent and can destroy you too!!!!!!!

How do you play your game?
Press WASD to move, and IJKL to place your soap. place soaps on dingles to delete them. Only one soap bar at a time!!!!   To reset reboot the machine

Code
Check off the items that are true.

[x] The game was made using the Sprig editor.
[x] The game is placed in the in the /games directory.
[x] The code is significantly different from all other games in the Sprig gallery (except for games labeled "demo").
[x] The game runs without errors.
[x] The name of the file/game contains only alphanumeric characters, -s, or _s.
[x] The game name is not the same as the others from gallery

Image (If an image is used)

[ ] The image is in the /games/img directory.
[ ] The name of the image matches the name of your file.

Thanks for your PR!

Thanks for the PR! How do you win your game?

It's endless and the objective is just to survive!

Hmm looks like these never disappear

Hmm looks like these never disappear

You gotta use the soap bar to clear your path!

I like the cleaning premise but I do think this game need more clear parameters for playing. If it's survival at least give a score for how well you survived and indicate when you lost.
Right now you can stand still and spam soap above your head.

I'm going to close this for housekeeping but feel free to reopen a submission when you are ready.


add esol descriptor

Checklist:

[x] Add tests to cover the fixed bug(s) or the new introduced feature(s) (if appropriate).
[ ] Update the API documentation is a new function is added or an existing one is deleted.
[x] Added a news entry.

copy news/TEMPLATE.rst to news/my-feature-or-branch.rst) and edit it.

Thanks for the review.


esp smartconfig provisioning fails on ios

The plugin is working fine with android but trying it with ios returns error message "Socket error: SocketException: Send failed(OS Error : No route to host, errno =65), address = <IP_ADDRESS>, port = 18266"

Check if readme section Breaking Change iOS 14.6/16 can help with your issue.

Yes I have added the multicast network entitlement and still facing the same issue, I guess the issue that the process is still running on port 18266 although the provisioning method is done and the stream is closed; so trying to call the provisioning start method again throws this exception.

hello, any evolution with ios16?
Thanks!!!


Conversion fails on model loaded via torch.load or torch.jit.load

Description of the bug:
I have a pytorch model which was saved  with torch.jit.save(). I tried both with a traced model and scripted model. The error is:
_File /orcam/ear/scratch/usr/avis/VENV_AI_EDGE/lib/python3.10/site-packages/torch/export/_trace.py:1449, in _export(mod, args, kwargs, dynamic_shapes, strict, preserve_module_call_signature, pre_dispatch, _allow_complex_guards_as_runtime_asserts, _disable_forced_specializations, _is_torch_jit_trace)
1447 original_state_dict = mod.state_dict(keep_vars=True)
1448 if not _is_torch_jit_trace:
-> 1449     forward_arg_names = _get_forward_arg_names(mod, args, kwargs)
1450 else:
1451     forward_arg_names = None
File /orcam/ear/scratch/usr/avis/VENV_AI_EDGE/lib/python3.10/site-packages/torch/export/_trace.py:753, in _get_forward_arg_names(mod, args, kwargs)
739 def _get_forward_arg_names(
740     mod: torch.nn.Module,
741     args: Tuple[Any, ...],
742     kwargs: Optional[Dict[str, Any]] = None,
743 ) -> List[str]:
744     """
745     Gets the argument names to forward that are used, for restoring the
746     original signature when unlifting the exported program module.
(...)
751         export lifted modules.
752     """
--> 753     sig = inspect.signature(mod.forward)
754     _args = sig.bind_partial(*args).arguments
756     names: List[str] = []
File /usr/lib/python3.10/inspect.py:3254, in signature(obj, follow_wrapped, globals, locals, eval_str)
3252 def signature(obj, *, follow_wrapped=True, globals=None, locals=None, eval_str=False):
3253     """Get a signature object for the passed callable."""
-> 3254     return Signature.from_callable(obj, follow_wrapped=follow_wrapped,
3255                                    globals=globals, locals=locals, eval_str=eval_str)
File /usr/lib/python3.10/inspect.py:3002, in Signature.from_callable(cls, obj, follow_wrapped, globals, locals, eval_str)
2998 @classmethod
2999 def from_callable(cls, obj, *,
3000                   follow_wrapped=True, globals=None, locals=None, eval_str=False):
3001     """Constructs Signature for the given callable object."""
-> 3002     return _signature_from_callable(obj, sigcls=cls,
3003                                     follow_wrapper_chains=follow_wrapped,
3004                                     globals=globals, locals=locals, eval_str=eval_str)
File /usr/lib/python3.10/inspect.py:2550, in _signature_from_callable(obj, follow_wrapper_chains, skip_bound_arg, globals, locals, eval_str, sigcls)
2548         except ValueError as ex:
2549             msg = 'no signature found for {!r}'.format(obj)
-> 2550             raise ValueError(msg) from ex
2552 if sig is not None:
2553     # For classes and objects we skip the first parameter of their
2554     # call, new, or init methods
2555     if skip_bound_arg:
ValueError: no signature found for <torch.ScriptMethod object at 0x7f942662ffb0>_
Actual vs expected behavior:
No response
Any other information you'd like to share?
No response

Hi @pkgoogle, I just came across this as I was trying to convert a pix2pix model (here the training code). I save using torch.jit.script, which allows me to reload easily without having to redefine the model in Python. I see that you recommend reading about torch.export, but it's still unclear to me whether it's a matter of saving the model using this new approach, or something else...? The current example is nice but it uses an off-the-shelf network rather than something users would have defined themselves. Any ideas? It would be nice to have a workable pipeline from PyTorch to mediapipe, thanks in advance!

Hi @jchwenger, we don't support non-torch-exportable models (plenty of custom models are torch exportable, although not every one). Fundamentally the root issue is with torch-export so we cannot fix that, however once/if that is fixed then this library should be able to convert it or if it can't then the root cause may be a bug on our end. To test for torch exportability you have to follow the steps here: https://pytorch.org/docs/stable/export.html i.e. you can load the model and see if you can export it with PyTorch API's. If you don't run into an exception then it is probably torch exportable. Torch.Export exports its to StableHLO, an MLIR dialect which is more interoperable w/ the ecosystem of libraries that support MLIR, including this one. You can think of it as a different saving format which is more interoperable with other libraries. This is important to get the models working on heterogenous hardware such as edge devices, mobile, TPU's etc.

Hi @pkgoogle, thanks for this! I was confused by the phrasing in the docs, it's as simple as that: when you say "must be compliant with torch.export", it just means the model must be saved using that format/API. Got this to work, yay!, however out of three tests only a simple dense net works, and I'm not entirely sure why.
I have a very simple and runnable Colab here, maybe you will see something super obvious I missed?
Strangely, I get an error around frozen tensors in the Pix2Pix for the in-place nn.ReLU(True), but not in the DCGAN generator, I'll report this on PyTorch...

Side note: the in-place nn.ReLU(True) mystery is now solved, caused by the presence of dropout before that (no mutation, therefore in-place operation, after it as of now).

Hi again, bumping this up, @pkgoogle. Just wondering: do you believe there is reasonable hope to fix this discrepancy (off-the-shelf ResNet and small dense net OK, but DCGAN and pix2pix not) when converting? Or should I try and post this issue on the PyTorch repo? Any thought welcome, thanks!

Hi @jchwenger I'm having trouble figuring out which discrepancies you are referring to. Are you saying that we can convert ResNet and small dense net, but not DCGAN and pix2pix? The answer will depend on what is causing the issue. If it's due to PyTorch export then the root cause is with PT Export (in which case you should create an issue there), if it's something else...well I will have to investigate. For DCGAN and pix2pix if we haven't confirmed it's PT Export, can you provide me a reproducible script which shows the error? (Sometimes people make small changes/adjustments in their code that actually affect the investigation).

Thanks @pkgoogle for the answer!
It's quite simple, with the custom dense net and ResNet, the test described in the original docs passes with "Inference result with Pytorch and TfLite was within tolerance", whereas with the DCGAN and pix2pix models it fails, with "Something wrong with Pytorch --> TfLite".
As you say, I don't know if it's the PT export or the conversion...
I have all four examples in this Colab, which should be runnable out of the box, with only the session restart needed after installing the dependencies. Thanks in advance!

Hi @jchwenger, I'm looking into it but do you associate w/ the OP? reason being is it feels like we are hijacking this thread as the original problem seems different. If you are not -- In which case we much prefer you create a new issue to track progress on your issues. In this case it's looking like an accuracy issue post-conversion for DCGAN & pix2pix.

Fair point, all done, see here!


python3 getConfig.py <IP_ADDRESS> <IP_ADDRESS> not returning anything.

Hello,
I'm very new to Raspi and I'm trying to setup some Cozylife smart plugs that I got recently to add to HA.
I've installed getConfig using "pip install getconfig' and then I navigate to the directory that it installs to: pi@raspberrypi:~/.local/lib/python3.9/site-packages/getConfig
I run the command "python3 getConfig.py <IP_ADDRESS> <IP_ADDRESS>" but nothing is returned, and no warnings or errors.
What am I doing wrong?  I have the plugs detected and working in the Cozylife app.

Try modifying getconfig.py file by increasing connection timeout. Line 30, change to
    a = tcp_client(ip, timeout=1)

It helped me.


AWS Lambda binary compatibility

AWS lambdas run on the ami amzn-ami-hvm-2<IP_ADDRESS>81129-x86_64-gp2, except lambdas for the Node 10.x runtime, which use a different ami.
A binary compiled on the mentioned ami links against the following binaries:
# ldd migration-engine
linux-vdso.so.1 =>  (0x00007fffc01ba000)
libssl.so.10 => /lib64/libssl.so.10 (0x00007f0877ec4000)
libcrypto.so.10 => /lib64/libcrypto.so.10 (0x00007f0877a65000)
libdl.so.2 => /lib64/libdl.so.2 (0x00007f0877861000)
librt.so.1 => /lib64/librt.so.1 (0x00007f0877659000)
libpthread.so.0 => /lib64/libpthread.so.0 (0x00007f087743d000)
libgcc_s.so.1 => /lib64/libgcc_s.so.1 (0x00007f0877227000)
libc.so.6 => /lib64/libc.so.6 (0x00007f0876e5a000)
/lib64/ld-linux-x86-64.so.2 (0x00007f0878c37000)
libm.so.6 => /lib64/libm.so.6 (0x00007f0876b58000)
libgssapi_krb5.so.2 => /usr/lib64/libgssapi_krb5.so.2 (0x00007f087690b000)
libkrb5.so.3 => /usr/lib64/libkrb5.so.3 (0x00007f0876622000)
libcom_err.so.2 => /usr/lib64/libcom_err.so.2 (0x00007f087641f000)
libk5crypto.so.3 => /usr/lib64/libk5crypto.so.3 (0x00007f0876204000)
libz.so.1 => /lib64/libz.so.1 (0x00007f0875fee000)
libkrb5support.so.0 => /usr/lib64/libkrb5support.so.0 (0x00007f0875ddf000)
libkeyutils.so.1 => /lib64/libkeyutils.so.1 (0x00007f0875bdc000)
libresolv.so.2 => /lib64/libresolv.so.2 (0x00007f08759c3000)
libselinux.so.1 => /usr/lib64/libselinux.so.1 (0x00007f08757a2000)

The specific package versions are found here:
openssl-1.0.2k
glibc-2.17

The binary can be built as described in #5.

Reposting from prisma/next repo:
Steps to Reproduce:
mkdir lambda && cd lambda
curl -o migration-engine-glibc https://s3-eu-west-1.amazonaws.com/prisma-native/alpha/latest/linux-glibc/migration-engine
curl -o migration-engine-musl https://s3-eu-west-1.amazonaws.com/prisma-native/alpha/latest/linux-musl/migration-engine
curl -o prisma-glibc https://s3-eu-west-1.amazonaws.com/prisma-native/alpha/latest/linux-glibc/prisma
curl -o prisma-musl https://s3-eu-west-1.amazonaws.com/prisma-native/alpha/latest/linux-musl/prisma
# todo: also fix permission plz :-)
chmod +x migration-engine-glibc migration-engine-musl prisma-glibc prisma-musl

In lambda/, Create an index.js:
const os = require('os')
const { execSync } = require('child_process')

exports.handler = function(event, ctx, fn) {
  console.log(execSync('./prisma-musl').toString())
  fn(null)
}

Now inside lambda/ run:
docker run --rm -v "$PWD":/var/task lambci/lambda:nodejs8.10 index.handler

You'll see:
START RequestId: 86ae9067-25bd-1b5b-3b09-3f6d917b42c3 Version: $LATEST
/bin/sh: ./prisma-musl: /lib/ld64.so.1: bad ELF interpreter: No such file or directory
2019-06-16T09:55:35.784Z	86ae9067-25bd-1b5b-3b09-3f6d917b42c3	Error: Command failed: ./prisma-musl
/bin/sh: ./prisma-musl: /lib/ld64.so.1: bad ELF interpreter: No such file or directory

    at checkExecSyncError (child_process.js:601:13)
    at execSync (child_process.js:641:13)
    at exports.handler (/var/task/index.js:5:15)

You can then modify the index.js and see it with other binaries.
If you run prisma-glibc, you'll see:
START RequestId: 328fbca9-8987-1c19-497d-ba31e148cb8f Version: $LATEST
./prisma-glibc: error while loading shared libraries: libssl.so.1.1: cannot open shared object file: No such file or directory
2019-06-16T11:16:44.258Z	328fbca9-8987-1c19-497d-ba31e148cb8f	Error: Command failed: ./prisma-glibc
./prisma-glibc: error while loading shared libraries: libssl.so.1.1: cannot open shared object file: No such file or directory

    at checkExecSyncError (child_process.js:601:13)
    at execSync (child_process.js:641:13)
    at exports.handler (/var/task/index.js:5:15)

Though I'd imagine this would be expected.

Fixed in latest alpha.


Adding nested "properties":{ "properties": { for ARM template.

updating examples.

Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[ ] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

/azp run automation - sdk

We are in private preview. Our internal customers need the .net SDK. Please expedite the SDK generation process.
Thanks.

HI @MyronFanQiu,
There was a difference between the .net SDK and Azure template data model.
I worked with @Anthony<EMAIL_ADDRESS>who pointed out that I need to use nested “properties” to make it compatible with ARM template and Azure SDK.
We are in private preview, so correcting the data model.
Yes, it’s a breaking change, but no users have started using it. We want to deliver the right API and SDK to the users, that’s why, I fixed.
Are the changes merged to master?
I don’t see the changes in master - https://github.com/Azure/azure-rest-api-specs/blob/master/specification/reservations/resource-manager/Microsoft.Capacity/preview/2019-07-19/quota.json#L493
It should be like following:
"CurrentQuotaLimitBase": {
"type": "object",
"description": "Quota limits.",
"x-ms-azure-resource": true,
"properties": {
"properties": {
"description": "Quota properties for the resource.",
"$ref": "#/definitions/QuotaProperties"
}
}
},
We would like to share the new SDK with our private preview users.
Thanks.
Rahul.
From: MyronFanQiu<EMAIL_ADDRESS>Sent: Sunday, February 23, 2020 5:57 PM
To: Azure/azure-rest-api-specs<EMAIL_ADDRESS>Cc: Rahul Singh<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [Azure/azure-rest-api-specs] Adding nested "properties":{ "properties": { for ARM template. (#8480)
@MyronFanQiu approved this pull request.
In my opinion, this should be a breaking change. It's in preview api version. LGTM in general.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F8480%3Femail_source%3Dnotifications%26email_token%3DAMYYUHBF4VTAA3247NK2PVLREMSQLA5CNFSM4KZLYKD2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCWSSRZI%23pullrequestreview-363145445&data=02|01|rahul.singh%40microsoft.com|d8e307b752fe4bde0e6108d7b8cce5d4|72f988bf86f141af91ab2d7cd011db47|1|0|637181062483772204&sdata=4stiKptMByYbTuA7NaqKc5gJlp7AeEhCDnxAIpVEY2E%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAMYYUHCOBZSXNWQ67PJYBVTREMSQLANCNFSM4KZLYKDQ&data=02|01|rahul.singh%40microsoft.com|d8e307b752fe4bde0e6108d7b8cce5d4|72f988bf86f141af91ab2d7cd011db47|1|0|637181062483782161&sdata=oodl4S6pNySwZd1KHZ1ybqwE8Aeq4EF6Lxn4q2dy8Mg%3D&reserved=0.

Please merge the changes and release the .Net SDK.
Our partner teams are waiting for the latest SDK to onboard the preview APIs.
As, it' preview version, so changes are OK. Based partner usages and feature requests, the API may change again. We will lock down the changes by Public Preview.
Thanks.

@MyronFanQiu How do we merge it to master?
Thanks.
Rahul.

@rahuls-microsoft Hello. This PR need ARM's approval.

I think @anthony-c-martin can help you approve this PR.

Can one of the admins verify this patch?

Can we get a sign off from one of the  authorized users.
Thanks.


1.6 Schedule

A proposal in line with our one release per quarter for the 1.6 release.  We can modify and update based on feedback at the next community meeting.
cc @idvoretskyi @calebamiles @sarahnovotny

Ha @erictune, that's what I call a race condition :smile:

I might be mis-remembering, but I thought we used to have 8-week coding periods. IIRC you already figured out the schedule for all of 2017 and I guess that resulted in 7-week coding periods, but do you know why it changed from 8 to 7 (or am I mis-remembering?)?

I wonder if it would be helpful to have an explicit "release candidate" the schedule.
A "release candidate" would be a tarball that we think (with high confidence) is identical to the release tarball, but which comes out prior to the release "fanfare".
Currently, we have a number of Kubernetes ecosystem projects which depend on the release, but which are not part of the release.   Those projects would like to have their product ready at the same time as the big Kubernetes release announcement.  But they also would want to test against the actual release, or as close as possible.   Right now, there is zero time for them to do that.
Examples of things that might use a release candidate:

Charts maintainers, to do final testing of PRs that use features in the new release, and to move the charts from incubator to  ( @kubernetes/sig-apps @viglesiasce : would a release candidate and a few days of slack be useful?)
Blog post writers need to write and text examples that use new release features.
Downstream tools (kubeadm, minikube, kargo, kompose, etc) need to do final integration with the new release and write their own release announcements.

Anyone else think this is useful?

It's an interesting idea (it's also kinda what we wanted for manual upgrade testing) but where would we fit it into the schedule?

@erictune To me it sounds like that is essentially v1.5.0-beta.3 without the fanfare.
I'm in favor for that anyway, it could be declared a week before the planned release for instance, and be "just another cut from the release branch" technically, but a more trusted and announced version to users.
The naming could be hard though, there are quite a lot of places that expect the kubernetes version to fit the regex that just allows (alpha|beta) as extra items.
We may just be using the current beta naming, but do a better job with telling people about it and making the timing be consistent, so everybody knows a beta release (a release candidate) is gonna take place exactly one week before the planned release.
WDYT?

We may just be using the current beta naming, but do a better job with telling people about it and making the timing be consistent, so everybody knows a beta release (a release candidate) is gonna take place exactly one week before the planned release.
WDYT?

That works for me.

cc @saad-ali @sarahnovotny then
Maybe something to bring up on the community meeting?

@erictune I don't see any problems between v1.5.0-beta.3 vs v1.5.0-rc.1 as long as both follow semver, which they do. Which is what @luxas is afraid of, imho.
👍 for the idea itself.

@soltysh I know it can be fixed, but I know there's a lot of regexes out there for validating the version where alpha and beta are hardcoded, so the regexes we have are now k8s-specific when we probably want semver-compliant validators.
I know for sure it can be fixed, but just pointing it out so we're ready for it so we're not pushing a rc version just to note that for example the build stuff and other things break

I agree that having explicit rc is better but as @luxas said some logic is hardcoded and rc will not pass that.

Hardcoding is bad and should be avoided at all costs. We can start with announcing plans of introducing rc's and do it incrementally, so that people have time to update their tooling, if needed.

@soltysh part of that hardcoding is done on k8s side ;-) But yeah agree with you completely.

@erictune big +1.
I'd like to upvote having the RC version of Kubernetes that will be consumable for the partners, Kubernetes-related projects as well as for preparing in the scope of marketing purposes.
Some time ago I've also created a brief diagram that describes the desired release process of Kubernetes, probably we'll have to rework on it.

Overall, LGTM. Thanks for putting this together.

Couple changes I just added to the schedule:
@saad-ali had mentioned that some Feature burndown meetings might be helpful prior to "Feature Complete (Code Freeze/Slush)", where we can finalize a list of features going into the release.
@erictune's suggestion from above for a rc release one week prior to 1.6 release.

@grodrigues3 @saad-ali we actually already had PM-initiated ad-hoc meetings before the "Feature complete" date during 1.5 iteration. But thank you for adding this to the release schedule.

@sarahnovotny what's the process for getting this merged into community


Inaccurate error message when handler returns null

Here is the code, x is an object I've created:
 post("user/login", (request, response) -> {
           ...
           return x.getResponse(); // *x.getResponse() is null at this point*
});

When null is returned, Spark sends a 404 and reports in the console that The requested route [/user/login] has not been mapped in Spark. The route was found (so 404 probably isn't correct), and the route has been mapped, it just isn't working correctly.
P.S. Awesome library! Thank you!

I agree that this is somewhat irky behaviour.

Uhm well a response should be returned so if the implementor decides that x == null then he should create a response indicating the desired result and HTML result code. It is hard for spark to guess what the HTML result code must be in this case so 404 is as good as any.

Wouldn't 404 be more appropriate if you didn't define a post or get for that route? It found a route, just the route returned null.

No if get or post are not defined I would return a 405 or a 501. Have a look at HTTP result codes. My point is: if you end up in a condition that you cannot return a valid response, you should define a response that must be returned instead.

I'm talking more for debugging. The error message leads me to believe that I never defined anything for user/login, but it's pretty clear that I did "map a route in spark".

I think the HTTP response mechanism leaves ample room to pass a good message to the browser in that case. You can just return null and spark will catch that for you but the onus is on you and not spark if you want to have meaningful error messages in that case.

Changed my mind, this is not actually a bug. If your route is null, 404 seems fine.


VD specific configurations

Configuration of reconstruction modules specific for VD and LE events.

This has been waiting for review for a bit. Any updates on this?

This goes together with PR https://github.com/DUNE/dunesw/pull/19 in dunesw. Just defining some VD configurations for LE events.


[Map] DM-Coke][

Hash: d1cdef3cdc1f67007ad32a0195da42e74fe78d2c
Current name: DM-Coke][
The author is simon 'birdieman' medium

Done


[Documentation]: Sambanova Integration Issues: Package Names Mismatch and Import Errors

Documentation Issue Description
Reliability of llama-index Out of the Box
Import Error №1

GitHub Issue

At one point, a simple line of code like from llama_index.llms.fireworks import Fireworks could result in three errors simultaneously:

cannot import name 'global_handler' from 'llama_index.core'
ImportError: cannot import name 'Secret' from 'pydantic'
ValueError: Did not find api_key, please add an environment variable FIREWORKS_API_KEY which contains it, or pass api_key as a named parameter.

Cause

It turned out that the code in the documentation (on several pages) contained errors that had gone unnoticed.

Fix
Thanks to @logan-markewich, a PR was released to address the issue.

Import Error №2

After successfully integrating Fireworks through llama-index into my project, I moved to a new LLM API provider—Sambanova. However, I encountered a ModuleNotFoundError, specifically:
No module named 'llama_index.llms.sambanova'

GitHub Issue

Cause

The llama-index-llms-sambanova package was published not by the official developers but by a third-party contributor.
During development, the package was accidentally renamed to sambanova.

Fix
Thanks to @logan-markewich, a PR was released:

The package was renamed back to llama-index-llms-sambanovacloud.
The documentation was updated to reflect these changes.

Import Error №3
For a long time, everything worked with the standard installation:
pip install llama-index "llama-index-llms-sambanovacloud>=0.3" sseclient-py.
I even managed to integrate SambanovaCloud through llama-index into my project, but over time, I began receiving numerous errors that I couldn't understand.
After two weeks of searching for errors in my project (unaware the issue wasn't on my side), I finally left a comment on the open issue.
Upon revisiting the problem, I decided to check for documentation updates and found that the previous page we had edited was removed.
Instead, a new page appeared, as the package was renamed to llama-index-llms-sambanovasystems.

I don't understand why the package name changes so frequently, as this can cause significant issues for developers using it.
Now this page needs to be edited again because the error persists:
No module named 'llama_index.llms.sambanovasystems'
This issue arises even after following the installations in the documentation:
!pip install llama-index-llms-sambanovacloud
!pip install sseclient-py

or
%pip install "llama-index-llms-sambanova"
%pip install sseclient-py

The documentation doesn't mention pip install llama-index-llms-sambanovasystems, and this package leads to another error:
User Warning: Field "model_kwargs" in Samba Studio hack conflict with protected namespace "model_".
Now we have three package names, none of which work:

llama-index-llms-sambanovacloud
llama-index-llms-sambanova
llama-index-llms-sambanovasystems

notebook №1
notebook №2

Conclusion
Over the past month, the following critical issues have been observed:

Basic integration with the Sambanova API via llama-index remains non-functional.
Frequent package renaming (three different names) causes confusion and breaks backward compatibility.
Documentation fails to keep up with changes.
Significant time is spent debugging and creating issues instead of productive development.

Recommendations for the llama-index team:

Stabilize package naming conventions.
Implement automated testing for examples in the documentation.
Improve the PR review process for changes affecting documentation.

@logan-markewich
Documentation Link
https://docs.llamaindex.ai/en/latest/examples/llm/sambanovasystems/

@hherpa regretably i did not want to change the package name either. But I'm also going to abide by the actual people who work at samba
https://github.com/run-llama/llama_index/pull/16930#discussion_r1838863470
It's a newer package (and not used at all 1 2), so impact to a rename was minimal
Your "error" about the pydantic fields is just a warning, it's benign but yes could be cleaned up. It does not effect usage.
Lately, I'll take a look at the import issue

The import works fine for me
https://colab.research.google.com/drive/1As1dOmRaVdZBGYJOg6CvQ9qxaCgQ2hn0?usp=sharing
But try a fresh env, or removing all previous versions of the samba package first before continuing.
Opening an issue shortly to clean up a few nits.
I'd love to have automated testing for examples, but thats not possible when everything relies on external systems, api keys, etc.

@hherpa regretably i did not want to change the package name either. But I'm also going to abide by the actual people who work at samba #16930 (comment)
It's a newer package (and not used at all 1 2), so impact to a rename was minimal
Your "error" about the pydantic fields is just a warning, it's benign but yes could be cleaned up. It does not effect usage.
Lately, I'll take a look at the import issue

Yes, you’re correct that
pip install llama-index-llms-sambanovasystems

displays a warning at the end rather than an error—it seems I’ve been overworking myself 😅.
However, my point was different: the installation commands listed in the documentation were only:
!pip install llama-index-llms-sambanovacloud
!pip install sseclient-py

And:
%pip install "llama-index-llms-sambanova"
%pip install sseclient-py

These, in fact, lead to an error because the package has been renamed. That’s why I filed my issue as [Doc] rather than [Bug].
Thank you for the PR and responsiveness!


What method have you used for clustering?

Is this based on any published work?

Actually, I havn't do anything on clustering...
The figures are hidden states after PCA.
The papers are in the folder "references" -- they already proposed the methods to perform DFA extraction.


Label_image always giving same outputs

Hi all !
While testing our models with basic label_image example, we faced with strange results.
We tried label_image with 2 different YOLO models with their corresponding label.txt. However regardless the input images and labels, the test output is always in the same order as [2 3 0 1]. Finally we also gave the Grace Hopper image from official source and still we faced with same issue. You can see the outputs in the image below.
Normally our models are working smoothly on PC. But, it is important for us to test them in our iMX6 device with this basic sample. Do you have any idea or solution about this problem ?
Thank you in advance.

Can you shows the input and output description of your models?
Note that label_image example assumes there is one output and that is the probabilities of each labels.

Can you shows the input and output description of your models?

Input and output are defined as below in our YOLO model.

Note that label_image example assumes there is one output and that is the probabilities of each labels.

Normally in terms of classification our model performs well on our tests in Colab, but basicly we also want to see how it works on label_image sample.
When we try label_image with MobileNet model and grace hopper image, it works properly. So we want to figure out what we are doing wrong in our model...

Normally in terms of classification our model performs well on our tests in Colab
Did you run it with Tensorflow or Tensorflow Lite in Colab?

Did you run it with Tensorflow or Tensorflow Lite in Colab?

Actually, we run it with Tensorflow.

Could you try to run the TFLite model in Colab and check its result there.
The reason is you fully understand and control the input/output processing there (since you have the code working for the TF model) so it will be a good start to debug it there.
In my experience, most of these unexpected accuracy problems is in input/output handling.


use exec on linux, in order to forward signals

Fixes https://github.com/gqmelo/exec-wrappers/issues/14
No issue with pytest

Thanks @gqmelo for merging, yes I changed some signatures, as this was a dirty quick patch. I'm sure it will need proper testing and rework :)


Simple registration app with backend

working on it.

you're doing login page, so please stick with one, so that others can do... So choose only one,, and let me know which one you want to do

working on this. for login page i was just asking as about ui.

okay done then do this,,

@sudhir-kumar-au3  will do this this task


Experimental Mixer-less telemetry lacks parity with Mixer

I realize that mixer-less telemetry is WIP/experimental in 1.3.0 but wanted to officially be able to track issues in the new telemetry that affect Kiali or potentially other consumers.
After configuring mixer-less using these instructions I found the following differences in istio_requests_total (may not be an exhaustive list), using bookinfo, that negatively affect Kiali:
With Mixer:
destination_service="ratings.bookinfo.svc.cluster.local"
destination_service_name="ratings"

Mixer-less:
destination_service="ratings:9080"     // maybe incorrectly set to request.host?
destination_service_name="ratings-v1"  // maybe incorrectly set to destination.workload.name?

I was expecting parity in values with or without mixer.
[X ] Policies and Telemetry
> istioctl version --remote
client version: 1.3.0
control plane version: 1.3.0

> kubectl version
oc v3.11.0+maistra-0.11.0+f2e7517
kubernetes v1.11.0+d4cacc0
features: Basic-Auth GSSAPI Kerberos SPNEGO

Server https://x.x.x.x:8443
kubernetes v1.11.0+d4cacc0

Istio installed via helm charts on a local OpenShift 3.11 on an F28 VM.

@jshaughn I've noticed this as well. Thanks for filing, and catching this early.

This is marked as a 1.4 P0, do we have an owner?

Here is an example of v2 telemetry full metric
--- istio_req.json	2019-10-11 11:30:32.000000000 -0700
+++ envoy_req.json	2019-10-11 11:30:21.000000000 -0700
@@ -1,30 +1,26 @@
-app="svc05-0"
 connection_security_policy="none"
-date="1570471790"
 destination_app="svc05-0"
 destination_principal="unknown"
-destination_service="svc05-0.local"
-destination_service_name="svc05-0v1"
+destination_service="svc05-0.service-graph05.svc.cluster.local"
+destination_service_name="svc05-0"
 destination_service_namespace="service-graph05"
 destination_version="v1"
 destination_workload="svc05-0v1"
 destination_workload_namespace="service-graph05"
-endpoint="15090"
-instance="<IP_ADDRESS>:15090"
-job="svc05-0"
-namespace="service-graph05"
-pod="svc05-0v1-69b8c58b55-kghnx"
-pod_name="svc05-0v1-69b8c58b55-kghnx"
-pod_template_hash="69b8c58b55"
+endpoint="prometheus"
+instance="<IP_ADDRESS>:42422"
+job="istio-telemetry"
+namespace="istio-system"
+permissive_response_code="none"
+permissive_response_policyid="none"
+pod="istio-telemetry-7b6c7996c7-5fm65"
 reporter="destination"
 request_protocol="http"
 response_code="200"
 response_flags="-"
-role="service"
-service="svc05-0"
-source_app="unknown"
+service="istio-telemetry"
+source_app="istio-ingressgateway"
 source_principal="unknown"
 source_version="unknown"
 source_workload="istio-ingressgateway"
 source_workload_namespace="istio-system"
-version="v1"

The meaningful diffs are:

mixerless fills destination_service with host header and destination_service_name with workload name, while mixer fills in service fqdn and short name.
mixerless does hot fill permissive_response_code and permissive_response_policyid which are from authn filter.
mixerless does not fill in app label.

Yes. Need to check if app label missing is specific to source ingress or also sidecars.
Need to see what app label is used by ingress.

Actually I miss read the diff a bit. app and version labels are missing in mixer metrics, not mixerless metrics. Looks like prometheus adds those implicitly during scraping, so we just need to fix the first two diffs.


can only install trusty

Please paste the output of the following command here: sudo edit-chroot -all

uilding dependency tree
Reading state information... Done
E: Unable to locate package #gnome-session-fallback
Failed to complete chroot setup.
The chroot setup script may be broken. Your chroot is not fully configured.
Removing the chroot setup script. You may want to update your chroot again.
UID 1000 not found in xenial
Unmounting /mnt/stateful_partition/crouton/chroots/xenial...
Please describe your issue:
Anytime I have tried to install xenial, or anything other than trusty, I get some errors.  I posted the output above with xenial -gnome because thats what I would prefer to use, but I could not install vivid with xfce, xenial with unity, wily with lxde, etc....  It all comes down to some kind of missing package most of the time and the UID 1000 not found.  I was able to get xenial -gnome to install by editing prepare.sh and removing gnome-session-fallback and replacing it with gnome-session-flashback.
If known, describe the steps to reproduce the issue:
just installing crouton with a distro other than trusty

I forgot to add the output of edit-chroot -all
ame: trusty
encrypted: no
Entering /mnt/stateful_partition/crouton/chroots/trusty...
crouton: version 1-20160715134041~master:0dc76a22
release: trusty
architecture: amd64
xmethod: xorg
targets: gnome
host: version 8350.68.0 (Official Build) stable-channel winky
kernel: Linux localhost 3.10.18 #1 SMP Tue Aug 2 21:10:21 PDT 2016 x86_64 x86_64 x86_64 GNU/Linux
freon: yes
Unmounting /mnt/stateful_partition/crouton/chroots/trusty...
name: xenial
encrypted: no
Entering /mnt/stateful_partition/crouton/chroots/xenial...
crouton: version 1-20160715134041~master:0dc76a22
release: xenial
architecture: amd64
xmethod: xorg
targets: gnome
host: version 8350.68.0 (Official Build) stable-channel winky
kernel: Linux localhost 3.10.18 #1 SMP Tue Aug 2 21:10:21 PDT 2016 x86_64 x86_64 x86_64 GNU/Linux
freon: yes
Not unmounting /mnt/stateful_partition/crouton/chroots/xenial as another instance is using it.

I had the same issues everytime I tried to target Gnome as the DE. I did get things working when I changed to installing XFCE though. It does seem to be failing b/c they renamed that packaged to gnome-flashback or something like that. I think if we found the line that calls that package and changed it, that it would solve the issue.
chronos@localhost ~/Downloads $ sudo edit-chroot -l xenial name: xenial encrypted: no Entering /mnt/stateful_partition/crouton/chroots/xenial... crouton: version 1-20160823173305~master:1e0c0488 release: xenial architecture: armhf xmethod: xiwi targets: chromium,x11,xiwi,xfce,audio,core,gtk-extra,xorg,cli-extra host: version 8737.1.0 (Official Build) dev-channel daisy  kernel: Linux localhost 3.8.11 #1 SMP Thu Aug 25 00:43:54 PDT 2016 armv7l armv7l armv7l GNU/Linux freon: yes Unmounting /mnt/stateful_partition/crouton/chroots/xenial...

I found the line, i am able to get it installed just have to wait for it to fail and edit prepare.sh.  its a pain, i dont know how to edit it before the fact... Otherwise id fix it

Can you link to the line?
On Aug 28, 2016 8:52 PM, "jsnow0187"<EMAIL_ADDRESS>wrote:

I found the line, i am able to get it installed just have to wait for it
to fail and edit prepare.sh. its a pain, i dont know how to edit it before
the fact... Otherwise id fix it
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/dnschneid/crouton/issues/2723#issuecomment-243010820,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACrSHoTZeGmkw9wDs6Oo32ic1Ubvf379ks5qki1WgaJpZM4Jj6PJ
.

@RMcNeely,
The prepare.sh script is built on-the-fly depending on which targets you specify so the line number in question will be different for different installations. The line # in the 'gnome' target file is L13.
When the crouton install fails, just use enter-chroot and answer 'n' when asked if you want to let it finish.
You'll then drop to a shell and you can edit /prepare.sh replacing gnome-session-fallback with gnome-session-flashback.
You can exit then and re-enter the chroot using enter-chroot -u root to let it finish the setup and add the user, etc.
Hope this helps,
-DennisL

Fixed via #2818


switch RTD from mamba to miniconda

As title

Offered as an alternative to #8352
We had switch to mamba on RTD some time ago to workaround a missing feature in conda. We had always wanted to switch back to miniconda, since this is more consistent with out public CI setup (Azure Pipelines).

@esc I think it'd make sense to accept both this and #8352. This patch is "working" as Anaconda distribution channels don't have the setuptools version which is broken for Numba's purposes, but as soon as setuptools version 65 is released into Anaconda distribution channels it'll break again.

I think accepting this patch is a good idea as it means the doc builds are performed using the same distribution/tooling as the rest of Numba's public CI.
I think accepting #8352 is a good idea as it prevents the use of a package broken for Numba's use case (I suspect NumPy/Numba package constraints might need also adjusting to accommodate).

Closing, merged as part of #8354.


Add label to floating-item

It should be nice too, to be able to add a label in the left of an ion-floating-item.
Like that :
http://i.stack.imgur.com/BHzxI.png

@Shinzah Thanks for the comment! We will include it in the next release!
If you are using the lib and you are happy about it, do not forget to rate it on the Ionic Market! Thanks

I will do it ! Thank for your job !

@Shinzah  I included the attribute text and text-class to define labels.
Let me know if everything is alright.
ps
Thanks for the review!

Hi, everything work fine ! Thank you !
(Don't forget to bump your version for bower usage)

Great, Thanks for reminding me. I'll do it now!


Add community member profile for dinujoh

Description
Add community member profile for dinujoh
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

This profile is needed for #2867.


feat(theme): improve Redoc component to display it in full size when used in MDX file

Refactor that component to extract an hook file : http://regardsoss.github.io/docs/development/backend/services/catalog/api-swagger/
And introduce a new param named fullscreenWithSidebar inside RedocProps. When true, it sets a special class that fix layout of Redoc to get it in full size.
It should looks lilke http://regardsoss.github.io/docs/development/backend/services/catalog/api-swagger

Are you affraid I introduced a regression ?
I do hook all day along, so I feeled like it was the right moment to do it :upside_down_face:

Are you affraid I introduced a regression ?

No, don't see any issue. Just would like to keep the refactoring separate.

I do hook all day along, so I feeled like it was the right moment to do it 🙃

It is definitely a good idea. I'd like to do it myself in a separate PR, and use it in ApiSchema and maybe other components also.

Hey!
I'll be closing this PR since this I made a bunch of breaking changes in v1. And there are a lot of conflicts. Though I don't think this PR will be needed anymore, since using the @theme/Redoc component is now way easier in v1 and you can now pass classname directly to it.
If there is still some usecase that is not handled and this is needed, feel free to open another issue and we can add it in.
Thank you for the contributions.


https://raw.githubusercontent.com/tupadr3/plantuml-icon-font-sprites/v2.4.0 produces an 400: Invalid request

Hi, I getting a little issue with some diagrams
https://raw.githubusercontent.com/tupadr3/plantuml-icon-font-sprites/v2.4.0
retrieves a:
400: Invalid request

By itself https://raw.githubusercontent.com/tupadr3/plantuml-icon-font-sprites/v2.4.0 does not exist. It needs to be combined with an existing file. For instance common.puml: view-source:https://raw.githubusercontent.com/tupadr3/plantuml-icon-font-sprites/v2.4.0/common.puml
As per the example in the README:
!define ICONURL https://raw.githubusercontent.com/tupadr3/plantuml-icon-font-sprites/v2.4.0
!includeurl ICONURL/common.puml

Without further code it is hard to tell what might be the problem. Could you post the (part of the) code that is giving you issues?


Initial bringup of DuckLinkExample and DuckDetector, Issues noted:

Noted two different things:

Was told that the DuckDetector should NOT have the web server portal running nor should the emergency page be available.

With the DuckLinkExample code running on a Heltec LoRa 32 and the DuckDetector code running on another Heltec LoRa 32 the DuckLinkExample is never seen.  The two units are about 3 feet apart.

When attached to the SerialPort of the DuckDetectorand reset is pressed I see:
rst:0x1 (POWERON_RESET),boot:0x13 (SPI_FAST_FLASH_BOOT)
configsip: 0, SPIWP:0xee
clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
mode:DIO, clock div:1
load:0x3fff0018,len:4
load:0x3fff001c,len:1216
ho 0 tail 12 room 4
load:0x40078000,len:9720
ho 0 tail 12 room 4
load:0x40080400,len:6352
entry 0x400806b8
Serial start 115200
Starting LoRa......
LoRa online, Quack!
Listening for quacks
Created Wifi Access Point
Created local DNS
Setting up Web Server
Detector Online
Ping!LORA SND millis:4068 size:4 data:f4023000
startTransmit Packet sent
Ping!LORA SND millis:7068 size:4 data:f4023000
startTransmit Packet sent
... endless repeat ...
Ping!LORA SND millis:10068 size:4 data:f4023000
startTransmit Packet sent
Ping!LORA SND millis:13068 size:4 data:f4023000
startTransmit Packet sent
Ping!LORA SND millis:16068 size:4 data:f4023000
startTransmit Packet sent
I would expect to see:
Ping! Pong! from the DuckLinkExample running.  It never happens.

https://github.com/Code-and-Response/ClusterDuck-Protocol/tree/master/examples/DuckDetector

Recompiled using the code at the DuckDetector link above.  With the DuckLinkExample device unplugged, the code still exports a WiFi  connection and that connection still has a web server running and a portal page on it.  Once I plug in the DuckLinkExample device the DuckDetector device still does not see  DuckLinkExample device.  I also have a TTGO device I'll try swapping it in and seeing if I can get a DuckDetector to see it.

We need to take out the duck.setupAp(false) and that should stop the web page from popping up.

@dmandala can you try the fix in the most recent PR? See if it solves your issue

Tested the latest fix. There was an issue with the 'setupWifiAP(false)` that was causing the issue. Will need to fix that in another issue.


RootMenu label doesn't work

I set the label attribute of RootMenu in /root/.jwmrc as follows:
....
   <RootMenu label="Start" ...>
...

After restarting JWM, it still show 'JWM'.
I'm using Debian with JWM vsvn-579.

Hi this is working in at least git version 1102 and up... possibly earlier
You may also want to modify
<TrayButton label="JWM">root:1</TrayButton>

thx Israel, TrayButton is what I need.

Glad it worked for you!!  If you want to try a different menu system, (if you are using the Debian menu/menu-xdg packages) that builds from the desktop files (/usr/share/applications) rather than the menu files I have a script I adapted from Puppy Linux.  I use it in Ubuntu, so it should work just the same in Debian ( I have also used it manually in Fedora).  You simply:
# apt-get install menu menu-xdg xdg-user-dirs-gtk xdg-user-dirs xdg-utils
And browse this:
http://bazaar.launchpad.net/~israeldahl/jwm-menu/trunk/files
you can use bzr to branch it:
bzr branch lp:jwm-menu
cd into the directory and (if not root run sudo)
cp etc/menu-methods/toriOSmenu etc/menu-methods
cp etc/menu-methods/places etc/menu-methods
cp -R usr/share/desktop-directories/ usr/share/

<Include>$HOME/.config/torimenu</Include>
<!-- snip-->
<TrayButton label="Apps" icon="distributor-logo.png" border="false">root:5</TrayButton>

For a Places menu use:
<Include>$HOME/.config/placesmenu</Include>
<!-- snip-->
<TrayButton label="Places" icon="folder.png" border="false">root:7</TrayButton>


[[FIX]] maxcomplexity doesn't take into account &&

Fixes #840

interestingly neither does http://jscomplexity.org/
I don't understand why not..

Thanks, Luke! And sorry for the egregious delay.


Plugin applying Box Shadow in wrong order

Describe the bug
The plugin supports adding multiple box shadows as a token. The issue is the order of the shadows is getting flipped when it gets converted to Figma Effects. This means the styles from the token are not displayed as intended on Figma.
To Reproduce
Steps to reproduce the behavior:

Create a Box Shadow token
Create a Drop Shadow token with the values 0 0 0 1px red.
Create a second Drop Shadow token with the values 0 0 0 2px blue
Create a third Drop Shadow token with the values 0 0 0 3px green
Save the token
Apply the token to an element on Figma.
Note the order of the styles in the Effects panel. It is the reverse order of what it should be.

Expected behavior
The order created in the plugin should be maintained when applied to a Figma element.
An example of the implemented tokens showing why the order matters.
https://codepen.io/dermyhughes/pen/MWXoXwr

Screenshots or Screencasts
Token on Plugin

Order of styles as created on Figma (Note the flipped order)

Released in 129


Add extra documentations as well as random re-org to sync with RFC order

Basically this pull request is not going to contain any programming changes to the library with the exception of changed in the orders of variables in different structures. For the most part everything is really synced up but as I am going through the RFC that are still things that are in-flux and are not organized. It just makes it really hard to follow when I constantly have to jump from one place to another between the RFC and the code.
The bottom line goal I am trying to achieve here is so that if someone is reading our documentations they are not necessarily need to go to the RFC in order to understand the more in depth stuff. I am going at it this way because I am also learning the whole library. Once I am up to speed I'll be able to add more documentations and tutorials for a wider range of audience and not just in-depth information.

Pull Request Test Coverage Report for Build 369

0 of 2 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 25.309%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/ice/ice.go
0
2
0.0%

Totals

Change from base Build 361:
0.0%

Covered Lines:
1002

Relevant Lines:
3959

💛  - Coveralls

I ended up merging full-ice on top of this. Once full-ice is completely merged into master this branch is going to be only docs changes and not show all the other code changes.

I am actually killing this PR because of all the conflicts that are there due to full-ice changes. I am going to re-create this PR on top of the latest master once full-ice is merged.


LightOccluder2D polygons cause editor slowdowns

Godot version
3.3.3.stable
3.4.beta4
System information
Windows 10
GLES3,
Ryzen 7 3700X,
32GB RAM
Issue description
LightOccluder2D polygons slow the editor down even with small polygons. (And my computer is not a potato)
https://user-images.githubusercontent.com/14185889/133438422-9841b2b7-f798-4b0b-87f7-8f97b6a3f2c5.mp4
Steps to reproduce

Open gear2.tscn
Select LightOccluder2D (<- slowdown starts here)
Pan the canvas

Minimal reproduction project
Slow LightOccluder.zip

Yes, I can hook VS into Godot once I am done with my current task

Could well be similar to #38543, possibly issuing a large number of drawcalls to draw the preview.

Could you check if #54377 fixes it? I tested locally and couldn't reproduce the slowdown before this PR either, so I can't confirm.

Tested on v3.5.beta.custom_build.4cae48d81 and issue is still noticable. Though not so extreme (just a feeling. May be incorrect)

I can share the diagsession with someone if there is interest. I just don't want to post it here. I don't see anything suspicious. (OK my GPU get's one fire...)

It's okay shouldn't need the project. I tried the min reproduction project again, and compiled it so the occluder debug draws even outside the editor, so I could diagnose the frame with the batching.

canvas_begin FRAME 554
items
	joined_item 1 refs,
			batch R 0-1 [0 - 152] {255 255 255 255 }
	joined_item 1 refs,
			batch P 0-138 {255 255 255 255 } MULTI
canvas_end

This is the output, so the debug drawing is the second, as a polygon all in one drawcall.
Looking at the calling code, this may be the same as before the PR above, so the drawcalls is not a problem, it's drawing everything in just 2 drawcall.
			PoolVector<Vector2> poly = occluder_polygon->get_polygon();

				if (poly.size()) {
					if (occluder_polygon->is_closed()) {
						Vector<Color> color;
						color.push_back(Color(0, 0, 0, 0.6));
						draw_polygon(Variant(poly), color);
					} else {
						int ps = poly.size();
						PoolVector<Vector2>::Read r = poly.read();
						for (int i = 0; i < ps - 1; i++) {
							draw_line(r[i], r[i + 1], Color(0, 0, 0, 0.6), 3);
						}
					}
				}

So not immediately sure why it might be slow. :thinking:

Could that be a driver issue? I mean the 3060 TI should be able to draw this poly. On the other hand the core usage of main thread goes up to 100%

Possibly, it's strange behaviour, if it's with the MRP. If you are able to use a CPU profiler, and you find a load of time is spent in the driver, then that sees like a culprit.
Some things you could try if that was the case:

Turn off batching in the editor (rendering/batching/options/use_batching_in_editor) and restart. The legacy may use a different draw method (although I'm not sure it may be the same for polys, but worth a try)
In rendering/2d/openg there are 4 settings for the dynamic buffer usage.

Idk tbf. I could try to update my driver.

Turn off batching in the editor (rendering/batching/options/use_batching_in_editor) and restart. The legacy may use a different draw method (although I'm not sure it may be the same for polys, but worth a try)

Did that. No change.

In rendering/2d/openg there are 4 settings for the dynamic buffer usage. You could try tweaking them for your system, you may have some joy.

will try

@HaSa1002 Did you end up finding what was the cause for the problem? I'm having similar performance issues with the LightOccluder2D. Hard to draw a polygon, when it gets super laggy after drawing about 15 vertices.

This comment still applies, by the way:

Can you try running a C++ profiler to see where the slowdown comes from?

(Please post results of profiling here by taking screenshots.)

Here is a couple of screenshots from running the profile for about a minute while modifying a LightOccluder2D polygon:
With godot.windows.tools.64 filter:

And without:

That does look like it's spending a lot of time in the driver (DrvValidateVersion seems prominent, and some sleeps and waits, which might be indicative of stalls).

I'm interested in claiming this as a first contribution (for a school assignment). Is that acceptable?

There's no need to claim.
Whether this is suitable for a first issue I'm not absolutely sure (if I remember it correctly), but feel free to have an investigate.

I was discussing this with someone else and we found this issue that may be similar: https://github.com/opentk/opentk/issues/474. I'm trying to track down where the relevant OpenGL operations would be done in the code so I can check that directly (looking at logs hasn't been very informative so far) but I'm having trouble figuring out exactly where those are...

Yeah, unfortunately I think this is actually out of my depth and I should probably look for something else to work on. I'm sorry for the inconvenience!


git commands

While working on workstation-setup project, I'm really missing these git commands / aliases
git co (git checkout)
gst (git status)
I realize that I might be opening a can-of-worms as some pivots have a lot of git tweaks. I feet that my list is pretty common in SF and PA and are used frequently each day.

+1

Closed by<PHONE_NUMBER>3c0abfed551ac68dab9bfc945d9465


Fix build failures due to Polish translations

Removed redirect from Polish index, as it then forces docs to always be Polish
_includes/pl_sidebar.md missing from _i18n/pl/sidebar.md so I have dumped in the English translations so the site renders correctly.
"lang" removed from _i18n/pl/categories/* as it produces
Exception: Could not locate the included file 'sidebar.md' in any of ["/home/zvecr/qmk.fm/_i18n/pl/categories"]. Ensure it exists in one of those directories and, if it is a symlink, does not point outside your site source. in /_layouts/qmk-category.html

Keyboard translations removed as it produces
TODO

Fixes #115

Looking to get some clarity on if this (and the parent issue) is the reason that the QMK Toolbox "Keyboard from qmk.fm" hex download isn't working right now as well as the outdated All Supported Keyboards page on qmk.fm proper. If it isn't directly related, should another issue be submitted?

Looking to get some clarity on if this (and the parent issue) is the reason that the QMK Toolbox "Keyboard from qmk.fm" hex download isn't working right now as well as the outdated All Supported Keyboards page on qmk.fm proper. If it isn't directly related, should another issue be submitted?

@kylemccreery It should be fixed now that this PR has been merged. If you still see an issue, please do raise an issue!


fix link

Hey Jason,
Thank you for helping with the Mycroft project! We welcome everyone into the community and greatly appreciate your help as we work to build an AI for Everyone.
To protect yourself, the project, and users of Mycroft technologies we require a Contributor Licensing Agreement (CLA) before accepting any code contribution, big or small. This agreement makes it crystal clear that along with your code you are offering a license to use it within the confines of this project. You retain ownership of the code, this is just a license.
You will also be added to our list of excellent human beings!
Please visit https://mycroft.ai/cla to initiate this one-time signing.
Thank you!

Hi Jason, as we haven't received a CLA or follow up comment, we'll be closing this in favour of PR #49.
If you'd still like to have this PR merged and be added to our public list of Mycroft contributors please visit https://mycroft.ai/cla to initiate this one-time signing. If #49 hasn't been merged already, I'm very happy to re-open and merge this.


New generic field type to show more text on website

We are requesting a generic field type that folds out or reveals additional text when the user clicks on the heading.
We don’t want to show a long block of text on the website because 1) users only want to know more about their specific issue area of focus and 2) too much information will make the page text heavy.
We believe that having text nested underneath a specific subject/heading would minimize the amount of text on the webpage at first glance.

Could you provide some prompts, links, or indicate how I could test this feature? Thank you.

@fourthletter  Add the new "More" field to any page in Wagtail admin. Each field has two rich text sections, the first always show, the other is reveled when users clicks a "Show more" button.
You can add as many "More" fields as you need to a page.

This works! Thank you! 💥


Fix validation messages

Originally intended to bring in the correct text for validation summaries (from #245 in the DM Toolkit), this now also contains the following fixes:

fixes for the Validation summary links don't work story
corrections to the HTML of validation summaries, replacing label tags for their text in the links and wrapping links in a list

New validation summary copy

Validation summary HTML
Old

New

:+1: will merge once Travis is happy.


Fixed old message not being cleared in spinner.message

I submitted the issue and now i see it's an easy fix. So, here's the pull request. :)

Nice! Let me run a quick test and I'll get that merged in

Great solution! Tested great, thank you for your contribution!


Add support for accessing UIA rectangle dimensions to UiaRect

winrt::Microsoft::UI::UIAutomation::AutomationRemoteRect has full support for reading X, Y, Width and Height of rectangle properties and attributes. However, UiaRect defined by the UIA operation abstraction library does not give access to the these qualities of rectangles.
This change adds the missing support for the rectangle members/qualities to UiaRect.
The support allows implementing heuristics around rectangles and the areas they cover (such as Win32's IsRectEmpty) through the abstraction library types and operations.

/azp run

Thanks!


feat(prow): adds merge conflict workflow

This PR brings conflict detection workflow.
Related repos:

jobs: https://github.com/bartoszmajsak/repo-sync/
custom plugin: https://github.com/bartoszmajsak/prow-patch-propagator

/test test-infra_lint

@dgn we could automate make gen in a job and push it back instead of failing and round-tripping to the poor developer opening a PR :)

@dgn we could automate make gen in a job and push it back instead of failing and round-tripping to the poor developer opening a PR :) If that's of interest I can make this happen in separate PR.

heh. sounds cool. separate PR would be good, though!

@yxun it's not about detecting merge conflicts between what's in the PR and the target branch, but what are the conflicts between maistra-specific commits applied on top of upstream main branch to see where we have issues. You can think of it as an interactive rebase through GitHub PR. It takes care of storing those changes in the external repository as a patchset. This lets us apply them every time there's a new change in the upstream branch so we don't have to do a big shabang rebase next time.
The plugin is a small part of the whole workflow and it does handle jobs annotated with a special label on a default branch name change.