Inconsistent behavior when querying properties with has()

Bug Type (问题类型)
gremlin (结果不合预期)
Before submit

[X] 我已经确认现有的 Issues 与 FAQ 中没有相同 / 重复问题 (I have confirmed and searched that there are no similar problems in the historical issue and documents)

Environment (环境信息)

Server Version: 1.0.0 (Apache Release Version)
Backend: RocksDB x nodes, HDD or SSD
OS: xx CPUs, xx G RAM, Ubuntu 2x.x / CentOS 7.x
Data Size:  xx vertices, xx edges

Expected & Actual behavior (期望与实际表现)
I can retrieve the vertex with has('vp3',0.9011454).
g.V().has('vp3',0.9011454)
==>[id:712320049687298049,label:vl0,type:vertex,properties:[vp3:0.9011454]]

However, when I remove all three trategies provided by HugeGraph, i.e., HugeVertexStepStrategy, HugeGraphStepStrategy and HugeCountStepStrategy, an exception is thrown.
g.withoutStrategies(HugeVertexStepStrategy).withoutStrategies(HugeGraphStepStrategy).withoutStrategies(HugeCountStepStrategy).V().has('vp3',0.9011454)
java.lang.NumberFormatException

But I can get the correct result when turning on one of these strategies, e.g., only turning on HugeVertexStepStrategy.
g.withoutStrategies(HugeGraphStepStrategy).withoutStrategies(HugeCountStepStrategy).V().has('vp3',0.9011454)
==>[id:712320049687298049,label:vl0,type:vertex,properties:[vp3:0.9011454]]

Vertex/Edge example (问题点 / 边数据举例)
No response
Schema [VertexLabel, EdgeLabel, IndexLabel] (元数据结构)
No response

Can you provide the schema and some sample data?

@javeme Hi, can you reproduce it? Can it be confirmed as a bug?


Higher ranking threshold is returning more results

Describe the bug
The title.
Search_1 with ranking threshold set on 0.90 will return 4 results, with 0.9083333333333333 as max relevancy score.
Search_2, identical to Search_1 minus the ranking threshold that is changed from 0.90 to 0.91 returns 200+ results with 0.9611111111111111 and similars, that weren't even in Search_1.
To Reproduce
It's a closed instance, but I can provide a dump or a key + host privately.
Expected behavior
By increasing the ranking threshold I would expect less or none results, not 200+ out of nowhere.
Meilisearch version:
v0.10.0
This is an example of query:
{"q": "search term", "limit": 1000, "showRankingScore": true, "rankingScoreThreshold": 0.92, "attributesToRetrieve" : ["A", "B"]}
The endpoint is /search, but obviously it also affects multi-search.

Hello @zperzendetta
is your issue the same as #4988?

Hi @curquiza, yes that's indeed the same issue.

@zperzendetta, thank you for your answer, I am closing this issue in favor of #4988,
don't hesitate to subscribe to it if you want to follow the advancement,
see you!


Use a 'catch' wrapper that can ignore signals

The addition of Tclx signal handlers means that SIGINT and SIGTERM
now result in an error being raised. In most places where the catch
command is used, we don't actually check if the error is a signal, and
in most of those cases can't do anything sensible except re-raise the
error anyway.
Thus we replace 'catch' with our own version which encapsulates
checking if the error is a signal and (by default) re-raises it if so.
The -signal flag can be passed as the first argument to the new catch
to make it catch signals too.
The code is sourced from its own file in both the main interpreter
and the slave interpreters that execute Portfiles. It can't simply be
aliased in to the slaves like we normally do for shared commands
because it uses uplevel and aliases add an extra call level.

@raimue @neverpanic Requesting review please.

No comments other than @raimue's.

I've been using this for a while and it seems to work, so I'm going to go ahead and merge.


Plugin autopublish didn't get correct status

Yesterday a PR triggered an auto-publish even though one of the postsubmit tests failed. This run:
https://github.com/flutter/plugins/runs/4722368042?check_suite_focus=true
lists 44 actions, all of which were success, but
https://github.com/flutter/plugins/runs/4722368957
was red when the publish happened. That test is in the wait list (so this isn't https://github.com/flutter/flutter/issues/88120 coming back somehow), so it seems that somehow the wait action got the wrong completion status.
I thought I saw this once just before the break as well, but wasn't sure since I was checking status on a phone and wasn't sure I read it right; this time I'm sure it happened—so presumably the other instance did too, and this isn't just a one-off.

We haven't seen this in a while; likely it was resolved upstream.


type: module should have option to require .js when .ts or .tsx is used

If you have a file with .ts or .tsx it will potentially create a .js file. When package type is 'module' this means .js needs to be used as the extension for relative imports.

That's true, but this plugin, via resolve, doesn't yet support "exports" or "type module" (which should be avoided regardless). Additionally, extensions are only required in native ESM; CJS files can still follow the best practice of omitting then.
When resolve gets this support, then the plugin will need a setting for people to opt in to "native ESM" mode for files, and the "extensions" rule will need to be updated to handle this use case.

I made a crack to solve the issue in https://github.com/import-js/eslint-plugin-import/pull/2483


start documenting the GitHub tables

Starts to document the GitHub tables in the README, will wait to merge as more GitHub functionality is added

Codecov Report

Merging #146 (b6b6805) into main (a1aa14f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #146   +/-   ##
=======================================
  Coverage   67.91%   67.91%
=======================================
  Files          26       26
  Lines        1119     1119
=======================================
  Hits          760      760
  Misses        221      221
  Partials      138      138

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1aa14f...b6b6805. Read the comment docs.


Bot throws error when new version has been deployed

In existing conversations with bots, when a new version of the bot is deployed an error is thrown when the user continues the conversation.

When this situation happens the bot should have a failback, as uploading a new version is part of continuous improvement and conversations can be long lasting, like in Teams for example.

@cxbuilders transferring to the dotnet project


Context menu doesn't show at first

Discord has changed how context menus are handled internally and are now lazy loaded, please update this and resubmit to BD and it will be accepted.
Since you are using ZLibrary this is easy to do, feel free to reach out if you are unsure.

Fixed


Update train_agent.md

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #28
Type of change
Please delete options that are not relevant.

[x] Documentation only change (no code changed)

Screenshots
Please attach before and after screenshots of the change if applicable.

Checklist:

[x] I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

@TangLongbin Could you summarise what you are fixing or solving in this PR?

@TangLongbin Could you summarise what you are fixing or solving in this PR?

Sure! I remembered that i added description when pulling the request, but it's gone for some reasons. Sorry for that! I'll explain the modification here:

In train_agent.md, the class BlackjackAgent needs env for initialization, but the demo code is initialized without env which results in errors. I added the parameters and use 'agent.env' instead of 'env' in the training.

No code for post-processing the training log (such as reward, episode length and training error) visualization. It should be average value rather value of each episode (gym.wrappers.RecordEpisodeStatistics only records this) which is not the same as figure provided in the doc. So I add the average value calculation (for later visualization) and the visualization code using matplotlib to help people get the result the expected.

Apologies for taking a couple of days to respond @TangLongbin I've updated the code, I think that agent.env is unnecessary and have removed And the rolling mean code that you added, I used np.convolve like in the original tutorial that will compute this more simplify for us

THX！


[enhancement] spawn data

[Problem]
Some scripters would love to know spawn locations. It is open knowledge, but unavailable until pokedex entry has been generated.
[Suggestion]
How about generating a spawn table from pro wiki, since they are pretty active lately:

get all maps via locations link: http://prowiki.info/index.php?title=Category:Locations
read map spawns from e.g.: http://prowiki.info/index.php?title=Mt._Moon
publish through new lua methods e.g.:

getSpawnsFrom(map)
getSpawnsOn(pokemon)

Currently working on a lua library, so there's no particullar need any longer.


show_graph_report API crashes BinaryNinja 4.0.4911

Long time, no see ! ;)
Version and Platform (required):

Binary Ninja Version: Binary Ninja 4.0.4911
OS: Ubuntu Linux
OS Version: 22.04
CPU Architecture: x64

Bug Description:
We've been using the show_graph_report API for visualizing custom graphs. I'm experiencing Binja crashes since upgrade to version 4.0.
Steps To Reproduce:
For any binary --
>>> g = FlowGraph()
>>> show_graph_report("Test", g)

Expected Behavior:
It should open a new but empty pane, but Binja crashes instead.
Screenshots:
Screenshot of executing the same command on 3.5.4526

Additional Information:
More generally, I have also tried experimenting with using that API with some legitimate graphs (by adding FlowGraphNodes) but ran into similar issues.

Ah, I just saw #5147 and I see that the issue is fixed in 4.1.49. I'll close this one in favor of the other!


Template: allow to use wildcard in firmware version definition

It could be a regular expression.

It could be a regular expression.

Allowing regular expression in perfect.

Done in https://github.com/LucasBrazi06/ev-server/commit/fb3865fa853b6f8f4d0c22fbdcc631a399170fae

The capabilities on the Legrand chargers have disappear from the DB since the use of regexp in template.

All related issues fixed. Working fine.


Provide the ability to replace the default cipher used by the req command for encrypting private keys

The openssl req command will encrypt a private key that it creates by default. But there appears to be no way of defining which cipher algorithm it should use. It uses 3DES by default - although you have the option of not encrypting the private key at all.
We should add an option to enable the cipher algorithm to be used to be specified.
We should consider what the default cipher algorithm should be.
See https://github.com/openssl/openssl/discussions/25775

Hi @mattcaswell,
I’m interested in working on this feature request. Could you please provide more details or any specific guidance on how you'd like the implementation to proceed?
Should we proceed by adding a new flag (e.g., -cipher) to specify the cipher to use, or are you planning to change the default cipher?

Adding an OTC hold so that the issue of what the default should be is discussed at OTC (@adimail - this hold should not prevent you from adding a -cipher option to the req app - so please feel free to proceed with that)
Question for OTC: Should we change the default cipher for the req, cms, smime, and pkcs12 apps from 3DES to something else?

thank you @mattcaswell
I will continue with adding the new flag and updating the relevant documentation.

Hi @mattcaswell,
I've started working on adding the cipher option to the req app and had a question about the implementation approach.
I noticed that in enc.c, the cipher option is implemented using a wildcard flag:
{"", OPT_CIPHER, '-', "Any supported cipher"}
with opt_set_unknown_name("cipher").
However, other apps like kdf.c use a specific string flag:
{"cipher", OPT_CIPHER, 's', "Cipher"}
For the req app implementation, which approach would you prefer? Should I:

Use the wildcard flag (-*) with opt_set_unknown_name("cipher") like enc.c, or
Add it as a specific "-cipher" string option like in kdf.c?

The current default behavior in req.c uses "digest" as the unknown name:
opt_set_unknown_name("digest");
I want to ensure I follow the most appropriate pattern for this addition.

An interesting anomaly. I would go with the most prevalent pattern in the apps - which seems to be the first style.

For the unknown name setting, req.c currently has:
opt_set_unknown_name("digest");
Should I:

Keep this setting for digest and add a separate one for cipher, or
Change it to opt_set_unknown_name("cipher"); since we're adding the cipher option?

Want to ensure we handle both digest and cipher options correctly.

I would definitely add -cipher option as in the kdf command. That avoids confusion and makes it explicit. I would even go as far as adding the -cipher option to the commands that support the -aes256 form (of course keeping that way for backwards compatibility) to make everything uniform.

I would definitely add -cipher option as in the kdf command. That avoids confusion and makes it explicit. I would even go as far as adding the -cipher option to the commands that support the -aes256 form (of course keeping that way for backwards compatibility) to make everything uniform.

Ok - fine by me.

I apologize for not asking for feedback before opening PR (#25796). Would you mind reviewing it and suggesting any necessary changes? I'm open to any improvements that would make the code better align with the project's standards.
# In req.c: Added new command line option
 const OPTIONS req_options[] = {
     OPT_SECTION("General"),
     {"help", OPT_HELP, '-', "Display this summary"},
+    {"cipher", OPT_CIPHER, 's', "Specify the cipher for private key encryption"},

# Added handler for the cipher option
+        case OPT_CIPHER:
+            cipher = EVP_get_cipherbyname(opt_arg());
+            if (cipher == NULL) {
+                BIO_printf(bio_err, "Unknown cipher: %s\n", opt_arg());
+                goto opthelp;
+            }
+            break;

Apologies for the basic question.
I'm working on adding test cases for the newly introduced -cipher flag in the req app. I'd appreciate guidance on whether I should:

Add a new subtest to tests/recipes/25-test_req.t, or
Extend existing tests to cover this flag

Any pointers to the project's testing documentation would also be helpful, as I'm new to the testing framework used here.

Add a new subtest IMO.

OTC: The default should be changed to aes-256. We need to ensure that all the apps where the default is changed has an option to change the cipher back to 3des for backwards compatibility.

Already fixed


Dl3 97 do not sync lineitems if deep linking disabled

Description
I updated the middleware to not try to sync the lineitems if deep linking is disabled. I also added INFO logging to indicate that this is happening (please let me know if this is overkill for logging - it will be very easy to remove).
Motivation and Context
This ensures that there aren't errors when doing standard LTI core launches with deep linking disabled and no harmony API in place.
Fixes
DL3-97
How Has This Been Tested?

Ensured that deep linking is enabled locally.
In a new course in the LMS that has access to my local tool, I went through the deep linking flow and inserted the links to my test course.
I clicked on one of the links I had inserted and ensured that the logs indicated that the lineitems syncing had taken place.

2022-09-22 16:18:12.479  INFO 18118 --- [-nio-443-exec-5] n.u.lti.controller.lti.LTI3Controller    : 23 lineitems have been synced to Harmony successfully for iss https://unicon.d2l-partners.brightspace.com, client_id 68ff69cc-7bb6-46c4-b899-31af213713e1, deployment_id b97f0815-d874-44c3-82d2-09beb0d66c05, and LMS context_id 6997. We received root_outcome_guid 357365c8-fd91-415b-8139-aa19779dabdd from Harmony.

I disabled Deep Linking in my local environment and redeployed.
I returned to the same course and clicked on one of the link and ensured that there were no errors in the logs and that there was no indication that lineitems had synced.

2022-09-22 16:20:56.912  INFO 18733 --- [-nio-443-exec-5] n.u.lti.controller.lti.LTI3Controller    : Lineitems will not be synced because deep linking is disabled.

Screenshots
N/A

Database changes
N/A
⚠ Deployment instructions ⚠
N/A
New ENV variables
N/A

Checklist

[x] I have reviewed the AC for this feature and my changes meet all requirements
[ ] (For UI changes) I have considered the accessibility of this feature (see https://www.a11yproject.com/checklist/ for a high-level checklist)
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have requested a review from at least one other dev

I realized that it was also a bug that the system wasn't completely broken due to the absence of the harmony API url, so I just updated this PR to fix that issue as well. Now if deep linking is enabled, there must be a value for the harmony API url or else the Lumen error page displays. If deep linking is disabled, then no value is required for the harmony API url and lineitems syncing does not take place.


resolve tsserver.js via an absolute path

this commit changes the tsserver.js resolution logic to use an absolute path rather than a relative one.
previously, if a user wanted to use a tsserver.js that was local to a project but didn't live in
node_modules (which would be automatically resolved by default), the tsserver.tsdk needed to be hardcoded to an absolute path. this required the user to modify coc-settings.json each time they wished to switch projects. by resolving to an absolute path, a user can now set the value to a relative path which will resolve correctly per project.
this change facilitates simplified usage of Yarn v2's PnP feature, which can generate a project-specific tsserver.js to enable correct IDE integration.

Hey there. Tonnes of appreciation for the work on coc.nvim. Let me know if you need any more info or would like anything changed.
For what it's worth, VSCode actually has logic that resolves the user setting to an absolute path amongst other things; this seemed like a much simpler change with no ill effect that I can see than porting all the new logic, though.

But your PR doesn't fix anything.

Hey there - sorry, I'm a bit confused by your response. This commit isn't a fix - it's an enhancement. It adds flexibility to the tsdk option.
Specifically, it allows usage of a relative or an absolute path, whereas currently, coc-tsserver only supports absolute paths - relative paths explode TypeScriptServiceClient#startProcess. I don't know about all use cases for tsdk, but tools that provide a per-project tsserver.js ex. Yarn v2, are a pain to work with if you're working on multiple projects; preventing users from using a relative path means they need to modify coc-settings.json whenever they switch a project.
Imagine working on any highly distributed project - if CoC used Yarn instead of NPM, every time you switched to a different repo (you have 30+), you'd need to update your coc-settings.json to get your intellisense working. If Yarn isn't a priority for you, it's worth remembering it's a ~35,000 stars project used incredibly widely, and includes CoC users. As v2 is curently in alpha, most people aren't effected yet (as coc-tsserver autoresolves node_modules) - but in Yarn v2, node_modules is gone, and requires a tiny wrapper for things like typescript so that node_modules can be magically emulated. Requiring a developer to swap the tsdk path every time they swap projects isn't a bug requiring fixing, but it's a tedious user experience that's can be fixed with my proposed change.
I'm not an expert, but I'm not aware of any edge cases with path#resolve that make this a breaking change. resolve returns an absolute when given an absolute, an absolute when given a relative, and absolute paths are compatible with TypeScriptServiceClient#startProcess - I don't see this introducing issues for anyone using the option in it's current state.
As stated, VSCode already resolves the tsdk option to an absolute path, and is the only IDE to support seamless usage of Yarn v2's PnP feature. I investigated porting their new VersionProvider logic, but I don't have the time to dissect the diverged code and propose a much bigger set of changes. from a quick look: I believe they've reworked it so that they try to pull tsserver.js from more, well structured sources, and provide additional metadata that's used in their widgets.
I hope that clarifies the purpose of this change and illustrates that this tiny change actually provides high value for a potentially large subset of users.
Please let me know if I can provide any more information or if you have a different solution in mind.
Cheers mate


When running pip install -r requirements.txt I get an error with  cffi==1.15.0 and apparently a demand to install "Microsoft C++ Build Tools"

When running pip install -r requirements.txt I get an error with  cffi==1.15.0 and apparently a demand to install "Microsoft C++ Build Tools"
Microsoft Windows [Version 10.0.19045.2546]
(c) Microsoft Corporation. All rights reserved.

N:\media\music\Bandcamp>pip install -r requirements.txt
Defaulting to user installation because normal site-packages is not writeable
Collecting beautifulsoup4==4.11.1
  Downloading beautifulsoup4-4.11.1-py3-none-any.whl (128 kB)
     ---------------------------------------- 128.2/128.2 kB 3.7 MB/s eta 0:00:00
Collecting browser-cookie3==0.14.0
  Downloading browser-cookie3-0.14.0.tar.gz (9.3 kB)
  Preparing metadata (setup.py) ... done
Collecting bs4==0.0.1
  Downloading bs4-0.0.1.tar.gz (1.1 kB)
  Preparing metadata (setup.py) ... done
Collecting certifi==2021.10.8
  Downloading certifi-2021.10.8-py2.py3-none-any.whl (149 kB)
     ---------------------------------------- 149.2/149.2 kB 9.3 MB/s eta 0:00:00
Collecting cffi==1.15.0
  Downloading cffi-1.15.0.tar.gz (484 kB)
     ---------------------------------------- 484.1/484.1 kB 29.6 MB/s eta 0:00:00
  Preparing metadata (setup.py) ... error
  error: subprocess-exited-with-error

  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [24 lines of output]
      Traceback (most recent call last):
        File "<string>", line 2, in <module>
        File "<pip-setuptools-caller>", line 34, in <module>
        File "C:\Users\Log\AppData\Local\Temp\pip-install-nd_sq6c0\cffi_cfb44d5914ea4403b7f375e43a841f38\setup.py", line 126, in <module>
          if sys.platform == "win32" and uses_msvc():
                                         ^^^^^^^^^^^
        File "C:\Users\Log\AppData\Local\Temp\pip-install-nd_sq6c0\cffi_cfb44d5914ea4403b7f375e43a841f38\setup.py", line 105, in uses_msvc
          return config.try_compile('#ifndef _MSC_VER\n#error "not MSVC"\n#endif')
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "C:\Program Files\Python311\Lib\site-packages\setuptools\_distutils\command\config.py", line 224, in try_compile
          self._compile(body, headers, include_dirs, lang)
        File "C:\Program Files\Python311\Lib\site-packages\setuptools\_distutils\command\config.py", line 129, in _compile
          self.compiler.compile([src], include_dirs=include_dirs)
        File "C:\Program Files\Python311\Lib\site-packages\setuptools\_distutils\_msvccompiler.py", line 344, in compile
          self.initialize()
        File "C:\Program Files\Python311\Lib\site-packages\setuptools\_distutils\_msvccompiler.py", line 253, in initialize
          vc_env = _get_vc_env(plat_spec)
                   ^^^^^^^^^^^^^^^^^^^^^^
        File "C:\Program Files\Python311\Lib\site-packages\setuptools\msvc.py", line 214, in msvc14_get_vc_env
          return _msvc14_get_vc_env(plat_spec)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "C:\Program Files\Python311\Lib\site-packages\setuptools\msvc.py", line 168, in _msvc14_get_vc_env
          raise distutils.errors.DistutilsPlatformError(
      distutils.errors.DistutilsPlatformError: Microsoft Visual C++ 14.0 or greater is required. Get it with "Microsoft C++ Build Tools": https://visualstudio.microsoft.com/visual-cpp-build-tools/
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

This seems like it is probably an issue with cffi. Looking at their instructions, it seems that they require a c-compiler to function correctly. This might be a change in requirements for one of our dependencies. I can't really do anything about it from this scripts side of things.
You can find the instructions for installing the necessary windows for the failing package here: https://cffi.readthedocs.io/en/latest/installation.html#windows-32-64-bit

Closing this, since there isn't much of anything we can do about it.


project.py returns a WindowsError instead of showing that the library is not found

I launched the following command without building rtos and ethernet libraries prior to it:
python ..\mbed\workspace_tools\project.py -c -m NUCLEO_F746ZG -p 96 -i uvision5
This is failing with the following errors
Traceback (most recent call last):
  File "..\mbed\workspace_tools\project.py", line 176, in <module>
    setup_user_prj(project_dir, test.source_dir, test.dependencies)
  File "C:\mbed\workspace_tools\export\__init__.py", line 170, in setup_user_prj
    copy_tree(lib_path, join(user_lib, basename(lib_path)))
  File "C:\mbed\workspace_tools\export\__init__.py", line 152, in copy_tree
    copytree(src, dst)
  File "C:\Python27\lib\shutil.py", line 171, in copytree
    names = os.listdir(src)
WindowsError: [Error 3] The system cannot find the path specified: 'C:\\mbed\\.build\\rtos/*.*'

Martin asked me to create the issue, mentioning that I should not get a Windows Error but the script should return an error.
Kind regards

cc @bridadan

Addressed in #1868

Thanks @briadan

ARM Internal Ref: IOTMORF-168

Hello, I confirm that PR#2166 has fixed the issue
python tools/project.py -c -m NUCLEO_F746ZG -p 96 -i uvision5
gives:
Failed:
  * NUCLEO_F746ZG::uvision5     Library path 'C:\MCDGitW601\mbed\build\rtos/*.*' does not exist. Ensure that the library is built.

I am closing the issue
Kind regards
Armelle


pre-commit: PR117535

Link: https://github.com/llvm/llvm-project/pull/117535
Requested by: @nikic

/add-label reviewed
/close


Separating domain parameters from keypairs proper comes with difficulties, let's not do that any more

The libcrypto <-> provider KEYMGMT interface makes a "strict" difference between keypairs proper and their domain parameters.  This has worked for some time...  as long as we don't try to use EVP_PKEY_copy_parameters() on an EVP_PKEY that holds an actual key, which happens here for example:
https://github.com/openssl/openssl/blob/bddbfae1cd667f0c1458deff98cbc03171e90d5a/apps/x509.c#L1009
So, while the idea of stricter compartmentalizing felt like a nice idea at the time, it turns out to be less than smooth in practice.
Note: I could have made this just a PR, but I felt that this needs to get some extra attention, because it will fundamentally affect quite a number of ongoing PRs

This was fixed with #11006.  Closing


Date format selection bug: new absence

Hi:
There's a bug using the date format DD/MM/YYYY. When I create a new leave request with one or more days (for example 01 May to 05 May) it fails:

I think there problem is in leave_request.js
Best regards

Hi @enriquetoledano, thank you for reporting this issue.
I will have a look at it ASAP.

I can confirm this bug.

hi @jekuno,
the fix is still in progress..

Should be fixed now.


Feature/adding list kubernete

:tada: This PR is included in version 1.4.0 :tada:
The release is available on:

GitHub release
v1.4.0

Your semantic-release bot :package::rocket:


Tree-sitter injections

Hi, I want to write tree-sitter language injections to work with sql, json and xml strings that are in a .cs file. Like for example in this plugin https://github.com/ray-x/go.nvim/tree/master/after/queries/go.
What do you think about including them in your plugin?
I'm planning to make an analog of language injections like in Rider https://www.jetbrains.com/help/rider/Language_Injections.html#use-comments
so that this sql string will be correctly highlighted:
//language=sql
var someQuery = "select * from user where id = 0";

with fallback options that will work based on regexp.

That would be awesome! Its definitely something that would be cool to have included in this plugin

Hi, @GustavEikaas!
I've prepared a PR that addresses the functionality outlined in the table (highlighting for SQL, JSON, and XML in strings). The PR is ready for merging, and it covers all the use cases marked with checkmarks.
However, there are a few topics I'd like to discuss for future improvements, which could be handled in subsequent or this PR:

Regex-based string detection: Should we use regex for detecting certain string patterns? If there’s a bug in this detection, it may be tricky to disable the injection easily. What are your thoughts on this approach? I think simple rules can be written without bugs, as for example it is done in a plugin for Go for strings with sql.
Examples for queries: Currently, I've written examples for the injections in .scm file, but I think a text description might be sufficient. This would reduce the number of lines and improve file readability.
JSON injections for single-line strings: I've not implemented injections for quoted and verbatim JSON strings due to the complexity and what I see as limited value.
SQL providers: It might be useful to add injections for strings used in SQL providers as well, similar to this config.

Lastly, do you think we should close this issue after merging, or should we leave it open and update the scope of work for further improvements?
I'm happy to adjust things based on your feedback.
Thanks!

Regex-based string detection
This touches upon my first thought when testing out the PR, it works out of the box without any configuration. Which is always a scary thing. I'm assuming there is not an easy way to dynamically register the queries? If there is not then we should be careful with potentially complex logic. It would be a shame to introduce a bug to users who have no conscious relation to this feature

Examples for queries
To a dev unfamiliar with TS queries it was nice to see examples in the file but I have no strong feelings for or against this. You have worked more with this type of functionality than me so you should be better suited to answer this question as its a preference thing

JSON injections for single-line string
This initial PR is above and beyond my expectations and I think the consumers will see every improvement as a plus. Referring to discussion point 1. Lets not introduce too much complexity initially

SQL providers
If you feel motivated to implement more sql providers after merging this PR go ahead, but if not then dont sweat it.

I think the work you have done here is amazing and I feel comfortable approving the PR at this stage. I think its important to not overcomplicate things. Testing this initial functionality on actual users will hopefully give us a broader perspective on the value it provides
Awesome work!❤


update "ms" to v0.7.1

I really hate making PRs just to update a dependency, but if this helps you with getting it updated, then I guess yay :)
fixes #201

ping @TooTallNate ;)

Thanks!

w00t, thanks @TooTallNate ! Don't forget to publish to npm at some point ;)


adding a fix to include multiple folder in url

Codecov Report

Merging #54 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master     #54   +/-   ##
========================================
  Coverage      23.5%   23.5%
  Complexity       19      19
========================================
  Files             6       6
  Lines           234     234
  Branches         25      25
========================================
  Hits             55      55
  Misses          176     176
  Partials          3       3


Auto remove completed torrent list

3d471db9fc87ef314ecd74c3e6f26979e1fb0624
Completed torrent list will be removed when user check list of torrent

3cbad869fa619c1346e1504f18fa945cac1ca2f1


Settings Screen

Hello, I am capable of completing the task, but in order to do so effectively, I require additional information. Could you please provide me with more details or insights to guide my understanding and approach?

Hello, I am capable of completing the task, but in order to do so effectively, I require additional information. Could you please provide me with more details or insights to guide my understanding and approach?

Currently, I don't have a solid design or functionality in mind for the settings screen except for Trakt login status. However, I'm eager to hear your suggestions and insights.


Failed reading /var/run/secrets/kubernetes.io/serviceaccount/token

Hello,
I'm facing an issue running the node-labeling process.
the pod in not running properly and this is the log:
Installing collected packages: six, pyasn1, urllib3, rsa, pyparsing, pyasn1-modules, protobuf, idna, chardet, certifi, cachetools, requests, pytz, packaging, httplib2, googleapis-common-protos, google-auth, uritemplate, google-auth-httplib2, google-api-core, google-api-python-client
Successfully installed cachetools-4.2.2 certifi-2021.5.30 chardet-4.0.0 google-api-core-1.27.0 google-api-python-client-1.12.8 google-auth-1.24.0 google-auth-httplib2-0.0.4 googleapis-common-protos-1.53.0 httplib2-0.19.1 idna-2.10 packaging-20.9 protobuf-3.17.2 pyasn1-0.4.8 pyasn1-modules-0.2.8 pyparsing-2.4.7 pytz-2021.1 requests-2.25.1 rsa-4.7.2 six-1.16.0 uritemplate-3.0.1 urllib3-1.26.5
WARNING: Running pip as root will break packages and permissions. You should install packages reliably by using venv: https://pip.pypa.io/warnings/venv
Failed reading /var/run/secrets/kubernetes.io/serviceaccount/token

I'm running on GKE with workload identity, I created a Cloud SA with the role
roles/compute.instanceAdmin
and bounded with a k8s SA with the same ClusterRole.
Where I am wrong?
thank you so much in advance, for your help and effort.
With all the best,
Fabio Rigato

The reason is probably in workload identity enabled on the cluster. I will have to check it but this is my first guess. I did not check the solution on the clusters with workload identity enabled.
Let me to check it and get back to you.

Thanks, @minherz for your fast reply.
I was able to solve the problem, I was creating the SA with automountServiceAccountToken: false
here for more info: https://kubernetes.io/docs/tasks/configure-pod-container/configure-service-account/#use-the-default-service-account-to-access-the-api-server
In particular, since I'm using workload identity I had to:

create the k8s SA and bind it with the IAM SA
Create a ClusterRoleBinding associated to node-info-reader ClusterRole
Update the serviceAccountName with me new SA in the Deamonset

Thanks for your time anyway.
With all the best,
Fabio Rigato

Thank you for digging the problem out. I will add an explicit automountServiceAccountToken: true into the daemonset's manifest to avoid such situations.


feat: add two new methods showing the impact of allowing binary PyYAML

Adds two new methods: fast-ops and slow-ops, which are like the ops method, but force using the Python PyYAML (slow) or libyaml PyYAML (fast) versions of load/dump.
Also adjusts the build so that the binary PyYAML gets installed, so that the libyaml version is available. Note that this changes the "ops" method to be the same as "fast-ops" rather than "slow-ops" as previously.

Wow I had no idea that it would be that easy to get libyaml into the build. That's brilliant, thanks!


parallelisation tweaks for CI acceptance tests

TLDR: 3 x reduction in CI credit usage ~5,000, other recent PRs ~15,000
More insights recent PR runs
Modifications in this PR:

remove parallelism for acceptanceTestsCliqueBft and acceptanceTestsPermissioning and reduce the machine executor size requirement (time before: 3 min, 6 min; after: 6 min, 10 min)
reduce parallelism for acceptanceTests task (this task failed with concurrency limit reached when parallelism was removed altogether https://app.circleci.com/pipelines/github/hyperledger/besu/25171/workflows/a5b6d9bc-fa7c-4e59-aac2-985f642492e9/jobs/164393) (parallelisation before: 4; after: 2 | time before: 4 min; after: 6 min)
move privacy ATs to nightly build and reduce parallelism (many tests failed when parallelisation was removed https://app.circleci.com/pipelines/github/hyperledger/besu/25170/workflows/81fc005b-6f3a-4c78-a8e9-f35e6f349aa6/jobs/164381) - note there's a separate effort to remove the docker dependency used by container tests - draft PR https://github.com/hyperledger/besu/pull/5968
remove small executor since it's not used
added comments to explain where the machine xl executor is actually required and why

refs #5791


TangemSdk.sign invokes both Success and Failure

Using:
implementation "com.github.tangem.tangem-sdk-android:core:3.8.2"
implementation "com.github.tangem.tangem-sdk-android:android:3.8.2"

When I try to get something signed using TangemSdk.sign , after successfully signing and getting the CompletionResult.Success , also the CompletionResult.Failure is invoked unexpectedly.
To be clear, the the Success part works OK and has the correct signature. So things seem to work fine, until the Failure is also triggered. It doesn't cause problems when the failure is ignored, but if a failure message is displayed or some code is run when Tangem signing fails, it breaks the proper operation.
The code I receive in the Failure TangemSdkError is 50002 .
Perhaps this has something to do with cards setup with the older Tangem app. Perhaps not.
Could you please check?

Hey Tangem team, any updates here?

We'll check it and give feedback.

@lazutkin-andrey @mobile-tangem @kozarezvlad any updates here?

Check it in version 3.9.1.
Code 50002 happens when dialog has been closed by user interaction with BottomSheet, otherwise it shouldn't throws.
If error still happens in 3.9.1, let us know.

Yes unfortunately I still see this behavior in 3.9.1
I am definitely not closing the popup with user interaction. The flow is:

App requests signature
I trigger TangemSDK
Card scan popup is displayed, I scan the card
Pin is asked, I enter the pin
The success sheet is shown with the check, then it closes itself
To my wallet both Success and Failure callbacks are returned, with the Success having the correct signature and Failure having the code 50002

What could be the reason that 50002 is triggered even though the user doesn't close this popup manually?

We're looking your case

Fix has merged in develop branch.
You can try it with tag develop-350

Yes, I confirm this solves the issue.
Many thanks. Please kindly merge into next main release.

When could we expect a release including this fix?
I would really not like to ship a version that has a develop version of TangemSDK integrated. Thanks.

Fixed in 3.9.2


InternalValue sometimes empty when page refresh

Use vue 3 with multiselect, i have an problem with InternalValue sometimes return empty when page refresh. When i go to another page, and return, sometimes the InternalValue is success. I get a data from server, and store it on reactivity.
<multiselect v-model="company.city" :options="listCity.data" valueProp="_id" label="name" trackBy="name" :searchable="true" placeholder="Choose city:" />
SETUP():
const company = reactive({             city: '', })
const listCity = reactive({             data: [] })
onMounted(() => {             axios.get("city").then((response) => {                 listCity.data = response.data             }).catch(error => {                 console.log(error);             })         })
Thank for your help.

No, my problem not solved yet

Please use the issue template to create a reproducible example:
https://jsfiddle.net/q6Lnpr7a/


[zh] Sync decrypt-data.md

Add zh text to this new page:
content/zh-cn/docs/tasks/administer-cluster/decrypt-data.md

See preview please.

/approve


ScrollController doesn't work when ListView is not full screen

-------------------code----------------------------------------------------------------
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatefulWidget {
  @override
  State<StatefulWidget> createState() {
    return _MyAppState();
  }
}

class _MyAppState extends State<MyApp> {
  final List<String> entries = <String>['A', 'B', 'C'];
  final List<int> colorCodes = <int>[600, 500, 100];
  ScrollController _scrollController = ScrollController();

  @override
  void initState() {
    super.initState();
    _scrollController.addListener(() {
      if (_scrollController.position.pixels ==
          _scrollController.position.maxScrollExtent) {
        print("drop down");
      }
    });
  }

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        body: ListView.builder(
            padding: const EdgeInsets.all(0),
            physics: AlwaysScrollableScrollPhysics(),
            controller: _scrollController,
            itemCount: entries.length,
            itemBuilder: (BuildContext context, int index) {
              return Container(
                height: 50,
                color: Colors.amber[colorCodes[index]],
                child: Center(child: Text('Entry ${entries[index]}')),
              );
            }),
      ),
    );
  }

  @override
  void dispose() {
    super.dispose();
    _scrollController.dispose();
  }
}

The log is not printed

C:\Users\Orion\Desktop\SC\flutter-test-master\test_flutter>flutter  doctor
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel stable, v1.12.13+hotfix.5, on Microsoft Windows [Version 10.0.18362.592], locale zh-CN)
[√] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
[√] Android Studio (version 3.5)
[√] VS Code (version 1.41.0)
[√] Connected device (1 available)
• No issues found!

C:\Users\Orion\AndroidStudioProjects\mobile_client_app>flutter doctor -v
[√] Flutter (Channel stable, v1.12.13+hotfix.5, on Microsoft Windows [Version 10.0.18362.592], locale zh-CN)
• Flutter version 1.12.13+hotfix.5 at C:\src\flutter
• Framework revision 27321ebbad (8 weeks ago), 2019-12-10 18:15:01 -0800
• Engine revision 2994f7e1e6
• Dart version 2.7.0
[√] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
• Android SDK at C:\Users\Orion\AppData\Local\Android\Sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-29, build-tools 29.0.2
• ANDROID_HOME = C:\Users\Orion\AppData\Local\Android\Sdk
• Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)
• All Android licenses accepted.
[√] Android Studio (version 3.5)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin version 42.1.1
• Dart plugin version 191.8593
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)
[√] VS Code (version 1.41.0)
• VS Code at C:\Users\Orion\AppData\Local\Programs\Microsoft VS Code
• Flutter extension version 3.7.1
[√] Connected device (1 available)
• MI 8 • fb21bfb6 • android-arm64 • Android 9 (API 28)
• No issues found!

Hi @Tumbler0809
By 'ScrollController doesn't work' do you mean that you expected to have listener called even on the scroll attempt? not only on actual scrolling?

When my finger swipes up on the list view, I also need to trigger a scroll listener

Yes, what you described is correct

A page displays 3 pieces of data at a time, and the 3 pieces of data cannot fill the screen. The user slides up, hoping to load more, so the scroll monitoring needs to be triggered.

The ScrollController only notifies its listeners when the scroll offset changes. In your example it looks like the ListView can't actually scroll because it doesn't have enough content to be scrollable. Therefore, the ScrollController doesn't call its listeners when you attempt to scroll it. So, this is working as intended.
You could try using BouncingScrollPhysics which will make the ListView bounce when you scroll it.

@Tumbler0809 Hi. Did you manage to find a way to detect scrolling even when the list does not fill the screen? This is important for pagination.

yes, I also need this for pagination

yes, I also need this for pagination

@Tumbler0809 did you find any solution?


TypeScript - Bad syntax generated due to private interface

Describe the bug
When a public query would return a private interface (due to a mistake in the public schema), the Codegen CLI "successfully" completes, but creates a type definition file with invalid (syntactically incorrect) types/interfaces (Maybe<Array<Maybe<>>>).
To Reproduce
Steps to reproduce the behavior:

My GraphQL schema:

type Foo = { ... } # Private type which should be public but isn't (setting in CMSs public GraphQL schema)

type Query = {
    foos(id: String): [Foo]
}

My GraphQL operations:

query Foos($id: String) {
    foos(id: $id) { ... }
}

My codegen.yml config file:

schema: ${GRAPHQL_SCHEMA_URL}
documents:
    - 'src/**/*.{ts,tsx}'
    - '!src/graphql/*'
generates:
    src/graphql/index.tsx:
        plugins:
            - typescript
            - typescript-operations
            - fragment-matcher
        config:
            avoidOptionals: true
            nonOptionalTypename: true

My src/graphql/index.tsx:

export type FoosQuery = (
    { __typename: 'Query' } &
    { foos: Maybe<Array<Maybe<>>> } // <-- Missing interface due to private type, would be Pick<Foo, '...'> if it were public
)

Expected behavior
Codegen CLI should throw an error detailing that there is a missing/private type that it can't write and then not output a file
Environment:

OS: Windows 10
"@graphql-codegen/cli": "^1.19.1",
"@graphql-codegen/fragment-matcher": "^2.0.0",
"@graphql-codegen/schema-ast": "^1.18.0",
"@graphql-codegen/typescript": "^1.17.11",
"@graphql-codegen/typescript-operations": "^1.17.9",
NodeJS: 13.11.0

Another possibility would be to write unknown in place of the missing type. Though a warning in CLI would also be nice

Thank you for reporting this @ArrayKnight . I'm not sure I fully understand this concept of private/public here. If an interface isn't being published as part of the schema, it should fail in codegen due to a missing type during the validation phase.
Can you please share a live reproduction of this issue?

I don't have any immediate time to setup an environment, but I can describe it in a more specific example:
We're using Craft CMS as a headless CMS, so we bought a Pro license, enabled the GraphQL interface and got to modeling our data.

Create a top level Entry type (Page)
Go to the GraphQL Public Schema
Notice that Assets is unchecked (private, not part of the public schema)
Check Entries > Section - Page, hit Save
Add a field (images) to Page of the type Assets

Now, when you do a schema codegen you'll end up with something like:
type Query {
    entry(
        # ...removed for clarity
    ): EntryInterface

    entries(
        # ...
    ): [EntryInterface]
}

type AssetInterface { # Oddly present despite not being part of the public schema
    #...
}

type page_page_Entry implements ElementInterface & EntryInterface {
    images(
        # ...
    ): [AssetInterface]
}

So, then you would write a query:
query Page($uid: [String]){
    entry(uid: $uid) {
        ... on page_page_Entry {
            images {
                url
            }
        }
    }
}

fragment Section on section_BlockType {
    tiles {
        ... on tiles_BlockType {
            tileImage { # also an assets field
                uid
                url
            }
        }
    }
}

And what's interesting is that you will find AssetInterface as a top level type and you'll even find it referenced within top level types that have asset fields, but when you have a fragment that references that interface you get invalid syntax:
export type AssetInterface = {
    // ...
}

export type Page_Page_Entry = ElementInterface & EntryInterface & {
    // ...

    images: Maybe<Array<Maybe<AssetInterface>>>;
}

export SectionFragment = (
    { __typename: 'section_BlockType ' } &
    { tiles: Maybe<Array<Maybe<(
        { __typename: 'tiles_BlockType' } &
        { tileImage: Maybe<Array<Maybe<>>> } // <-- Invalid syntax
    )}
)

To remedy this, I had to go to the GraphQL Public Schema, check Assets, and hit save.

Closing, @ArrayKnight . This was related to missing config right?

@dotansimha I disagree that this should be closed.
I can see the argument that this is a setting in Craft CMS that causes this issue, however, I feel like the codegen tool should handle this case by either throwing an error in CLI or replacing the missing type with unknown and warning in the CLI.

I see, but I'm not familiar with CraftCMS, or with the exact setup that you have, and you are not able to create a complete reproduction. I don't have any tools to reproduce or investigate it.
I'm willing to try to solve that, but I will need your cooperation...
Please share a reproduction and then I'll re-open this.


<IP_ADDRESS>420 disconnects GCM with every reboot

Sine upgrading to <IP_ADDRESS>420 the GCM connection stays disconnected until you manually connect it with ##2432546## in the dialer.
With the previous version this had to be donr once and then the GCM connection survived reboots. Now on <IP_ADDRESS>420 the GCM connection is lost and stays disconnected after every reboot until again the dialer code is used.

See https://github.com/microg/android_packages_apps_GmsCore/issues/964#issuecomment-546473162 for a temporary build to test.

@Iey4iej3 Thanks. Unfortunately microg.org gives me a bad gateway error right now. Will test later.

microg.org gives me a bad gateway error

Confirmed - same here

Inform @mar-v-in of that.

Bad Gateway should be fixed

Bad Gateway should be fixed

Confirmed - all good now

The test apk fixed all my issues. i will also confirm in the main thread. Thanks!


sokol_audio.h: check more OpenSLES calls during Android audio init

This likely caused an application crash on a system with a buggy audio
system (see https://github.com/mgerdes/Open-Golf/issues/27).
Note that this change is completely untested!

Looking good, I'll give it a whirl on my Pixel 4 and then merge.

Ok , merged. Many thanks! I had to change the SOKOL_LOG() calls to the newer SAUDIO_LOG() (I think this changed in the meantime when a log callback was added).

I couldn't verify that this solved the problem, since the issue was intermittent and had gone away by the time I came up with the patch. Thanks for merging!


feat: added avg tokens per request for the dashboard page

Description

Added average tokens per request

Fixes #44

Closing this PR as the PR https://github.com/dokulabs/doku/pull/67 is already merged.


Documentation for Traits

There are now Smart TVs available with Google Assistant. They support Channel, Volume, Input Selector. So, why is there no public documentation for this traits?
It would be very helpful for implementing my personal Smart Home Integration.

These capabilities are not currently available through the Actions on Google developer platform. We provide reference documentation only for types and traits that are available to the public developer community.
There are open feature requests for many of the items you mentioned. I would encourage you to star/track these issues for updates on when they might be coming for public use:

TV device
Channel trait
Volume trait


Refinements to namespace isolation

Any more details?

What is this epic for? There are no issues associated with it and no details


Ramda Omit should return Partial instead of T

There are few type issue on Ramda declaration
for example:
omit<T>(names: List<Prop>, obj: T): T;
omit(names: List<Prop>): <T>(obj: T) => T;

should be
omit<T>(names: List<Prop>, obj: T): Partial<T>;
omit(names: List<Prop>): <T>(obj: T) => Partial<T>;

or maybe a Pict<T1, T2>
omitting means removing parts of object specified in the second argument and return new object without the specified lists of key, so it should return Partial instead of T since it will returning only some part of the object key value

Yeah, fair enough. That said, at this point I did figure out how to do type level omit now. Put it in a gist but currently on phone.

For reference, my progress on typing it further (see here):
export type Omit<T, K extends keyof T> = Pick<T, Diff<keyof T, K>>;

// needs TS 2.5
export type Diff<T extends string, U extends string> =
({[P in T]: P } &
{ [P in U]: never } &
{ [k: string]: never })[T];

// alternative for older TS:

export type UnionDiff_<Big extends string, Small extends string> =
{[K in Big]: { 1: Union2Keys<Big>[K], 0: never }[Not<UnionHasKey<Small, K>>]}//[Big];

export type UnionDiff<
Big extends string,
Small extends string,
Step extends UnionDiff_<Big, Small> = UnionDiff_<Big, Small>
> = Step[Big];

I'd like to retype the whole library more accurately with things like this, but still got a few obstacles and need to test a lot more whether things wouldn't break down with less granular types.
Until then, feel free to send a PR to make it use Partial!

Currently my hack is
omit<O>(lists: string[], obj: Dict<any>): O with this I will also get the auto complete for outputted object keys
the T generic is used for the OUTPUT I was looking for.
When using Partials<T> or Pick<T, U>, the keys of object inputted still remain in the results omitted.
Also in Partial<T> every key is assigned an undefined on the results, this is not really helpful since I need to keep checking the key with if not undefined even though the value is defined.
I also tried with this one
omit<I, O>( lists: [keyof I], obj: I): O

interface Input {
  a: string;
  b: string;
}

interface Output {
  a: string;
}

omit<Input, Output>( ['b'], { a: 'a', b: 'b' } ) // got tooltips when inputting array of keys, got autocomplete for object keys in results and I can keep the object values type in VSCODE

By specifing type of Input and Output object, since I use VSCODE it helps me with tips on which key I can input on and which key value pairs I get back from the result. I only use this one if I have a huge lists of object keys in my third party library and want to avoid typo.
I think currently it's impossible to get difference between object in typescript.

omit<O>(lists: string[], obj: Dict<any>): O

We used to have typings like this, but I think they don't add much value: it seems little different from just explicitly casting the result like <T> omit(k, o). How would you see that?

I think currently it's impossible to get difference between object in typescript.

Did you check my link? You're not likely to find it used anywhere yet cuz we just only recently figured out how one might be able to do it.
You're right though, typings currently out there don't really go this far yet, standard library included.

Yes, I checked your link, I also try all of the type definition in your gist link but nothing works

I can't get it to work as a function yet either, just like R.path (see mention of #12290 here):
const keys: ['a', 'b'] = ['a', 'b'];
const obj: { a: 1, b: 2, c: 3 } = { a: 1, b: 2, c: 3 };
declare function omit<T, Keys extends string[]>(names: Keys, obj: T): Omit<T, TupleToUnion<Keys>>;
const omitTest = omit(keys, obj);
// expect {c:3}, get Pick<{ a: 1; b: 2; c: 3; }, "a" | "b" | "c">
declare function omit2<Keys extends string[]>(names: Keys): TupleToUnion<Keys>;
const omitTest2 = omit2(keys);
// expect 'a'|'b', got never
type abc1 = TupleToUnion<['a', 'b']>;
// 'a'|'b'
type abc2 = TupleToUnion<string[]>;
// gives never, did omitTest2 have it turn into string[] too?
declare function omit3<Keys extends string[]>(names: Keys): Keys;
const omitTest3 = omit3(keys);
// ["a", "b"] as expected, no info lost here... weird.

So yeah, the jump to functions is one thing I'm still having trouble with...

Filed as bug here now.

Actually works now on master. Guess there is hope!
I'd better further test type-level programming in typical before we really dive into it over here though.


feat(modelgen): connected model support for custom pk

Description of changes

Some changes for connection info metadata changes to support custom PK:

Changed foreign key naming from{modelName}{connectedModelFieldName}*Id to {modelName{connectedModelFieldName}{otherSidePrimaryKeyName}*
Added targetNames to hasOne and belongsTo relation meta
Added new feature flag useFieldNameForPrimaryKeyConnectionField

Issue #, if available

Description of how you validated changes
Checklist

[ ] PR description included
[ ] yarn test passes
[ ] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)
[ ] Breaking changes to existing customers are released behind a feature flag or major version update
[ ] Changes are tested using sample applications for all relevant platforms (iOS/android/flutter/Javascript) that use the feature added/modified

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Merge this to staging branch first and get this reviewed together with https://github.com/aws-amplify/amplify-codegen/pull/427


fix(setup): Fix typo with opentelemetry-distro in setup.py

fixes https://github.com/getsentry/sentry-python/issues/1857

This has been fixed in 1.14.0.


Retry is supported after #8

Is it, right?

Hi @MikkCZ, yes sure, you are right. Reviewed logic and removed odd code.
Thank you


Add -stopafterblockimport option

Stop after importing blocks. This can be useful for development
and trouble shooting.

Works as advertised


How HTTP push works

To implement push notifications in a web application, we need three main components:
A push service:
This is a server-side component that manages the delivery of push notifications to clients.
The push service is responsible for sending notifications to the appropriate clients based on their subscription endpoints.
A service worker:
This is a client-side JavaScript file that runs in the background of a web page and handles push notifications sent by the push service. The service worker subscribed to the endpoint and listens to incoming push notifications, displays them to the user, and may perform additional actions based on the notification payload.
A database:
This is a data storage component that allows you to save and manage subscription endpoints for your users.
When a user opts in to receive push notifications, their subscription endpoint is saved to the database.
When it's time to send a notification to a particular user,the push service retrieves the user's subscription endpoint from the database and sends the notification to that endpoint.


Feature request: Search for new devices

I'd like to search for new devices without logging in to the Phoscon app (because it is still not really usable on mobile devices. At least on Firefox on iOS it's a pain in the ass).
Ideally there would be a datapoint I can set to true, which activates searching for devices.

Did you search before you opened the issue?

Absolutely, yes. Neither for the term "search" nor "suche" any valid results are available.

Then maybe this is not a feature request but a bug report: Changing this value to true in ioBroker does not allow new devices to be added.
In fact, before opening this issue I had seen and tested this value, without reading its description. Since it didn't work I assumed it must be something else. Sorry 'bout that.
I looked in the code and found the PUT request that should be made for the network_open state change.
If I read the code correct, there should be a "modify config" entry be added to the logs, unless there is an error. The log is empty though.


Generate new representation of .sln with specified project

After validation, create a new .sln representation in memory. Copy over relevant settings and set up new settings based on pulling only what is required from previous .sln given the specified project for extraction (project and all its dependencies).
Previous validation steps can warn about broken dependency links, but this step can fix them and import missing projects, if they exist.
TBD should it fail out if dependent projects are missing?

Pie in the sky.
Feature complete as of 55cb619.
Won't do.

Re-opening and moving to future-work.


error_position! and family should accept input first

Error macros currently have input accepted as second argument, which makes it impossible to use them in most combinators which try to pass input first.

should be fixed in https://github.com/Geal/nom/commit/d9948588bfd7f2d0037665b3016cef287cb70315


TypeError: null is not an object (evaluating 'NativeModule.requestPermission')

Doesn't work on  RN 0.61.1. Screenshot below.

When I check my package-lock.json file, I see react-native-qrcode-scanner depends on "react-native-permissions": "^1.1.1"
This version of react-native-permissions works for react native versions between 0.56.0 - 0.59.10. The react-native-permissions version works for new react native version (> 0.60) is 2.0.0.
I think changing this dependency will work.

@eggybot it definitely is. I just resolved my problem by downgrading react-native-qrcode-scanner and it's dependencies.

There's a pull request for this one. Waiting for it to be merged.
https://github.com/moaazsidat/react-native-qrcode-scanner/pull/202/commits/1a842ef69eda9b920533a4332bf3ffa0be35ecf5

The PR for this should be merged ASAP. :D

@eggybot it definitely is. I just resolved my problem by downgrading react-native-qrcode-scanner and it's dependencies.

What version ?

Anyone successfully implement the pull request @dcosmin2003 referenced above?  Post changes, I get this instead of the original error @redeguzman-gbf reported..

Anyone successfully implement the pull request @dcosmin2003 referenced above? Post changes, I get this instead of the original error @redeguzman-gbf reported..

You need to add related permissions to the podfile according to the following url:
https://www.npmjs.com/package/react-native-permissions
As far as I remember adding this two lines is enough
permissions_path = '../node_modules/react-native-permissions/ios' pod 'Permission-Camera', :path => "#{permissions_path}/Camera.podspec"

Anyone successfully implement the pull request @dcosmin2003 referenced above? Post changes, I get this instead of the original error @redeguzman-gbf reported..

You need to add related permissions to the podfile according to the following url:
https://www.npmjs.com/package/react-native-permissions
As far as I remember adding this two lines is enough
permissions_path = '../node_modules/react-native-permissions/ios'
pod 'Permission-Camera', :path => "#{permissions_path}/Camera.podspec"

@mertkir - thanks for the reply - I had already added all of the related permissions to the pod file per that link.  I actually copied all of them to start with and was going to trim out the unused ones once I had it working.

Is there a chance that you forgot to run 'pod install' ?
Also I run 'npm install react-native-permissions --save'. I think normally it should not be necessary if you install react-native-qrcode-scanner via npmjs but I manually copy it to the node_modules directory so I needed to add this dependency to the project.
If it still does not work, remove node_modules and pods directories and reinstall them. Also clean XCode project before running.

@JimLuschkowski did you get it working? Got exactly the same issue.. Tried to implement #1a842f but then getting TypeError: undefined is not an object (evaluating '_reactNativePermissions.PERMISSIONS.IOS').
I did a pod install, added the permissions_path = '../node_modules/react-native-permissions/ios' pod 'Permission-Camera', :path => "#{permissions_path}/Camera.podspec" as stated in react-native-permissions, cleaned the XCode build.
Using

"@react-native-community/async-storage": "^1.6.2"

"react": "16.9.0"

"react-native": "0.61.0"

"react-native-camera": "^3.7.2"

"react-native-permissions": "^2.0.2"

"react-native-qrcode-scanner": "^1.2.3"

@ferdiamg @JimLuschkowski 's original question is related to the pull request which is not merged to the main branch yet. You are using version 1.2.3 of react-native-qrcode-scanner. Instead you should get the code with the pull request and use that version. My comments are related to the code offered by pull request. I successfully managed to run a test app by following the procedures I described in the previous comments.

@ferdiamg @JimLuschkowski 's original question is related to the pull request which is not merged to the main branch yet. You are using version 1.2.3 of react-native-qrcode-scanner. Instead you should get the code with the pull request and use that version. My comments are related to the code offered by pull request. I successfully managed to run a test app by following the procedures I described in the previous comments.

Yeah I am using the updated index.js from the Pull Request just like you and also adjusted the package.json in react-native-permissions to ^2.0.0. Still the same issue somehow..

@ferdiamg I'm still having the same issue... I've performed all of the steps in this thread, several times in multiple permutations, without any measurable impact.
The index.js and package.json in my node_modules/react-native-qrcode-scanner folder match the pull request.  My local package.json references react-native-qrcode-scanner 1.2.3, and react-native-permissions 2.0.0.  I deleted ios/builds and ran "pod install".  Any other suggestions?

i have the same issue

i move and use react-native-camera, by default has qrcode reader.

@JimLuschkowski Try remove node_modules/ and package-lock.json then npm install
After that go look inside node_modules/react-native-permissions/, recheck package.json inside that folder is it match to<EMAIL_ADDRESS>Sometimes npm is install wrong version, if in that case you need to npm install --save<EMAIL_ADDRESS>manually.

It worked for me -

Used the pull request
Installed the Pod

https://github.com/moaazsidat/react-native-qrcode-scanner/commit/1a842ef69eda9b920533a4332bf3ffa0be35ecf5

Anyone successfully implement the pull request @dcosmin2003 referenced above? Post changes, I get this instead of the original error @redeguzman-gbf reported..

@JimLuschkowski,
react-native-permissions is not linked correctly.
< RN 0.59
run $ react-native link react-native-permissions should solve that issue
> RN 0.60
Linking should be automated if the package can be autolinked
A lot of issues can be generated depending what versions of RN and third party packages you are using so I think the best way to link module is via manual linking. See manual linking docs here.

@reddeguzman and anyone else who offer assistance, it is greatly appreciated.  I tried them all (and more) without success, so I decided to drop back to just using react-native-camera as @f0ntana suggested.  react-native-scanner-mask is a nice add if anyone else goes this route.

moaazsidat Can you please merge the pull request?

I tried all the steps above and it still results in an error. I hope the merge happens soon.

I tried these steps as a temporary solution until their merge the PR fixing this issue:

yarn add moaazsidat/react-native-qrcode-scanner#refs/pull/202/head
Add to your Podfile ->
permissions_path = '../node_modules/react-native-permissions/ios'
pod 'Permission-Camera', :path => "#{permissions_path}/Camera.podspec"
Make sure you have your permission key in your info.plist example: NSCameraUsageDescription
You give permission to open your photo library?
https://github.com/react-native-community/react-native-permissions
follow these steps here in case you get an invalid 'RNPermission X. Should be one of: () error'.
Clean your pods in the ios folder rm -rf Pods/, yarn start --reset-cache, clean your XCode build and uninstall your app in your simulator. Then run your app and it should work, at least that worked for me.

Any solution for this one the does not including using POD? I use Carthage instead. Nothing works for me, I get the same error.
Thanks

Has anyone found iOS builds failing after adding the PR and the lines to the pod etc?
xcode build error as per below:
duplicate symbol 'OBJC_CLASS$_RNPermissionHandlerCamera' in:
/Users/build.mac/Library/Developer/Xcode/DerivedData/CortexMonitoring-ddckgtmysivxhiebtkcjrvtlhtos/Build/Products/Debug-iphoneos/Permission-Camera/libPermission-Camera.a(RNPermissionHandlerCamera.o)
/Users/build.mac/Library/Developer/Xcode/DerivedData/CortexMonitoring-ddckgtmysivxhiebtkcjrvtlhtos/Build/Products/Debug-iphoneos/ReactNativePermissions/libReactNativePermissions.a(RNPermissionHandlerCamera.o)
duplicate symbol 'OBJC_METACLASS$_RNPermissionHandlerCamera' in:
/Users/build.mac/Library/Developer/Xcode/DerivedData/CortexMonitoring-ddckgtmysivxhiebtkcjrvtlhtos/Build/Products/Debug-iphoneos/Permission-Camera/libPermission-Camera.a(RNPermissionHandlerCamera.o)
/Users/build.mac/Library/Developer/Xcode/DerivedData/CortexMonitoring-ddckgtmysivxhiebtkcjrvtlhtos/Build/Products/Debug-iphoneos/ReactNativePermissions/libReactNativePermissions.a(RNPermissionHandlerCamera.o)
ld: 2 duplicate symbols for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
It looks like the project tries to bring in the same symbol due to the references in pod file to permissions from
permissions_path = '../node_modules/react-native-permissions/ios'
pod 'Permission-Camera', :path => "#{permissions_path}/Camera.podspec"
&&
pod 'ReactNativePermissions', :path => '../node_modules/react-native-permissions'
If I roll back the changes to podfile then I end up back with the TypeError: null is not an object (evaluating 'NativeModule.requestPermission') issue

I'll be closing this one once it was a problem related to the react-native-permissions compatibility which it's not happening anymore

and just to clarify the comment made above by @f0ntana, the react-native-camera don't have any QRcode scanner, it scans just barcodes and nothing more beyond that, which by the way we're working to move it as a scanner on react-native-camera and it will be available in the next few months, feel free everyone to task

This issue is still exists

can you detail better the problem that you're still facing @dalugoda?

@dalugoda try to see if something like that works for you https://github.com/moaazsidat/react-native-qrcode-scanner/issues/289#issuecomment-690045328


Add non-privileged user

Would you consider adding the possibility of running as a non-privileged user to the image as described in the molecule docs?
https://molecule.readthedocs.io/en/latest/examples.html#docker-with-non-privileged-user
I'd be happy to contribute this change instead of forking, if you think it would be a good addition.

For my own workflows, I use these images just to test the basic functionality of the Ansible roles and playbooks I'm using, and don't test out things like permissions/become/etc., so I don't have a need for it...
However, I would be willing to add this on (since it doesn't seem to break anything by default), but only if I were able to get it added to all my various docker-*-ansible images so they're on feature parity. But if you work on a PR for this one, I may be able to just copy and paste across the rest.

Let me know whether I should open the other PRs as well after you had time to review the changes here or if it's easier for you to do the changes yourself.


Alias config

Hi,
I think it would be nice to have a button to add/remove alias in the index dropdown:

great plugin btw, thank you!

umm, it's right there on the main menu... https://github.com/lmenezes/elasticsearch-kopf/blob/master/imgs/aliases.png

oops... thanks @up-town-down !


Base64 func

Feature: Adds the feature of prefixing base64 before either the parenths(( or braces{{ to encode the returned value base base64. $base(key), $base64((key)), and base64{{key}} are now supported.  See README.md for updated information.
Use case: when using template files for secrets, the value is expected to be sent to the api in base64 encoding.  This allows the variables file or -k=key=value flag to be plain text.
Other changes: This also reduces the repetition of the code from 3 functions for each format, to a single function.
Test run:
/tmp/base64 $ cat mysecret.yaml
apiVersion: v1
kind: Secret
metadata:
  name: mysecret
data:
  quotedName: $(name)
  quotedBase64Name: $base64(name)
  s3Bucket: $((s3_bucket))
  base64S3Bucket: $base64((s3_bucket))
  legacyWebsite: {{Website}}
  base64LegacyWebsite: base64{{Website}}

/tmp/base64 $ cat values.yaml
name: Dennis
s3_bucket: my-bucket
Website: github.com

/tmp/base64 $ kexpand expand -f values.yaml mysecret.yaml
apiVersion: v1
kind: Secret
metadata:
  name: mysecret
data:
  quotedName: "Dennis"
  quotedBase64Name: "RGVubmlz"
  s3Bucket: my-bucket
  base64S3Bucket: bXktYnVja2V0
  legacyWebsite: github.com
  base64LegacyWebsite: Z2l0aHViLmNvbQ==

Thanks @dennis-bsi
So I’m trying to follow this language: https://github.com/kubernetes/kubernetes/blob/master/docs/proposals/templates.md
It doesn’t have support for base64 expansion at template time.  If you search for “base64” in that doc it looks like they intend for the input values to be base64 encoded already
I’m in two minds here; on the one hand it is pretty useful because secrets are pretty awkward.  But I’m wary of breaking compatibility with the (proposed) syntax for templates.

I also wonder about base64{{key}} - I wonder if {{ key | base64 }} would be safer.

Changed to recommended format.
/tmp/kex $ cat template.yaml
apiVersion: v1
kind: Secret
metadata:
  name: mysecret
data:
  quotedName: $(name)
  quotedBase64Name: $(name|base64)
  s3Bucket: $((s3_bucket))
  base64S3Bucket: $((s3_bucket|base64))
  legacyWebsite: {{Website}}
  base64LegacyWebsite: {{Website|base64}}
/tmp/kex $ cat values.yaml
name: Dennis
s3_bucket: my-bucket
Website: github.com
/tmp/kex $ kexpand expand -f values.yaml template.yaml
apiVersion: v1
kind: Secret
metadata:
  name: mysecret
data:
  quotedName: "Dennis"
  quotedBase64Name: "RGVubmlz"
  s3Bucket: my-bucket
  base64S3Bucket: bXktYnVja2V0
  legacyWebsite: github.com
  base64LegacyWebsite: Z2l0aHViLmNvbQ==

This commit will supercede #6.  Upon merging, #6 should be closed

Thanks - going to merge and then fix up CI!


Sequence does not exist

Experimenting with the latest sqlc on an existing db, I'm hitting an error where it cannot find sequences. Here is a stripped down example
$ sqlc generate
# package .
schema.sql:19:1: relation "authors_id_seq" does not exist

Line 19 is an alter sequence line (note that ALTER TABLE is also valid here, see the Notes section in https://www.postgresql.org/docs/10/sql-altersequence.html):
ALTER SEQUENCE authors_id_seq

schema.sql
CREATE TABLE authors
(
    id   integer PRIMARY KEY,
    name text NOT NULL,
    bio  text
);

CREATE SEQUENCE authors_id_seq
    AS integer
    START WITH 1
    INCREMENT BY 1
    NO MINVALUE
    NO MAXVALUE
    CACHE 1;

ALTER SEQUENCE authors_id_seq
    OWNER TO postgres;

ALTER TABLE ONLY authors
    ALTER COLUMN id SET DEFAULT nextval('authors_id_seq'::regclass);

It appears in the parser output:
$ sqlc parse schema.sql | grep _seq
     Relname: (*string)(0xc000171010)((len=14) "authors_id_seq"),
     Relname: (*string)(0xc000171460)((len=14) "authors_id_seq"),
             Str: (string) (len=14) "authors_id_seq"

You found the root of the issue. ALTER SEQUENCE is really just ALTER TABLE under the hood, so sqlc was trying to find the authors_id_seq table. Since that DDL is changing the owner, something sqlc ignores, I made sure to ignore unimplemented ALTER TABLE statements. See #219

Thanks for the very speedy response & fix!


Update distribution name from 'galley' to 'galley-proof'

Update package distribution name from 'galley' to 'galley-proof' to sidestep name collision on readthedocs and pypi. Also change 'pybee' to 'beeware' everywhere to fix broken links. Resolves #2 and resolves #9.

Hey there! It looks like a rebase is needed to move forward with this PR.


please use a git tag to make packaging easy

This is a really useful utility!  Would you consider using a git tag with a version number to make packing for Linux distros eaiser?
tag=v0.550
git tag "$tag" -m "$tag"
git push --tags

I've tagged the latest version as "4.0.0"


Adding additional samples to pipeline

Hi Tim and Cade,
I have a question about adding additional samples to pipeline. I have previously run ~150 polar bear samples through snpArcher, which worked great, and created a multi-sample vcf file for use in downstream analyses. Now I have another 150 samples that I would like to add to the original set. They were sequenced at separate times, at at slightly lower coverage (10x instead of 15x). Is it possible to set snpArcher up in such a way that I can filter, align, etc the new samples and add them in to the merged vcf of the old samples? Sorry if this has an obvious answer, but I have gone through all the docs and I'm still uncertain. I have attached my sample sheet from the initial run in case that is helpful.
Thanks!
Ruth
PB1_samples.csv

Hi Ruth,
There are a few ways you can do this. First, if you still have the g.vcf files (should be in a directory like results/{refGenome}/gvcfs/{sample}.g.vcf.gz), then you can recall your new and your old samples together relatively straightforwardly. Just make a new sample sheet that includes both your new and old samples, and rename your (current) final vcf to something else. Snakemake should hopefully automatically realize that most of the work is already done for the old samples, and only generate g.vcfs for the new samples. I would highly recommend a dry run in this case first, to make sure that you are not regenerating and overwriting things you already have (sometimes Snakemake can be tricky with e.g. file modification times making it think it needs to regenerate files that actually exist).
Alternatively, if you call the new sample set in an independent snpArcher run, you can use bcftools merge (https://samtools.github.io/bcftools/bcftools.html#merge) to merge the two VCFs.
Tim

Thanks! Appreciate the quick answer!


Adding binary files

Currently, I face two issues with dalliance when trying to add bigbed files.

I have an error when a URL parameter already exists in the link. I have managed to fix this issue with the following, and I would appreciate if the change is permanent.

In utils.js
function saltURL(url) {
if (url.indexOf('?') < 0) {
    return url + '?salt=' + b64_sha1('' + Date.now() + ',' + (++__dalliance_saltSeed));
} else {
    return url + '&salt=' + b64_sha1('' + Date.now() + ',' + (++__dalliance_saltSeed));
}

}

When adding the following,

http://www80.lamp.le.ac.uk/download?get=gencode.v20.annotation.bb
the file is processed successfully, but it is stuck with the connecting message. Additionally, I get "Uncaught RangeError: byte length of Int32Array should be a multiple of 4" error in the console.

As it happens, we've already made a somewhat-analogous change to handle URIs containing a '?' character, although the change is make here rather than in utils.  This change should have made it into the recent 0.13.0 release.

That server doesn't appear to support HTTP "Range" requests, which are required by Biodalliance so that it can fetch portions of the file based on the index.  You can test this straightforwardly with:
    curl -o test.bb -r 0-499 http://www80.lamp.le.ac.uk/download?get=gencode.v20.annotation.bb

(should retrieve 500 bytes, actually retrieves the whole file).
Secondarily, this server also doesn't support the HTTP OPTIONS command, which could cause problems for Biodalliance unless you never make cross-origin requests to this resource.
If possible, I'd suggest just using a "standard" web-server (Apache, nginx, etc.) pointed at a directory of files when serving up bigbeds.  If this isn't an option, you'll need to ensure that whatever you're using supports Range and OPTIONS.


Create Application for Credentials

is there any mechanism in Tweetinvi to create credential application and get my 4 keys?

Hello there. Sorry for the delay.
I am not sure that I understand the question you are asking.
From my understanding of your sentence you are trying to generate credentials.
If this is correct please take a look at the documentation related with it : https://github.com/linvi/tweetinvi/wiki/Authentication


Removing Emitter leaves particles

Removing Emitter stops updating emitted particles and they are left on screen.
I expect particles to die normally after emitter is removed.
I have done a workaround that calls Emitter.stop() and waits for max lifetime and then calls Emitter.destroy()

There is a also a method removeAllParticles() on Emitter that sets all its particles "dead" flag to true.
Calling update() after that destroys all the particles properly.
Kinda threw me off as well.

 Like for example fade away.


Nightly mode for the bots

Right now the bots are beta-only, but #83 added support for the nightly channel. It would be nice to have nightly versions of playbot and playbot-mini, either with separate nicknames or some special command. (I admit 4 bots would be a bit much, but it doesn't seem that bad if they are reasonably named.)
We could reintroduce the unstable parts of the bot template removed in #81 for the non-mini nightly version of the bot.

Due to the way nightly/beta works, the only benefit I can think of is that playbot-nightly-mini would allow you to opt in to features via #![feature], but otherwise they should be basically identical. Did you have some other use cases in mind?

Yeah, I guess playbot-nighly-mini may not be that useful.

Ok, in that case I'm going to close this for now, but we can always add a bot if we can think of a use case for it!

But playbot-nightly is still useful with a bunch of default #[feature(..)] in its template. Only -mini is not useful.

Possibly, yeah, but we're we're likely to not update this template very often and the set of features is likely to change quite often, so I suspect it may not work out well in the long run.


feat: Videojs POC

Overview
Early draft of Videojs Integration.
Notes

Currently videojs does not support module css and also importing .css file results into build errors. Right now we have just copied entire videojs's styles from lib directly into our Global, we could also import css as - !style-loader!css-loader!video.js/dist/video-js.css to force style-loader and get rid of base videojs styles from gamut
Using Types from videojs results into build errors for some reason, Currently removed them from the POC for review.
videojs uses their custom font for icons (currently uploaded to our S3), but we could easily remove this font and use our custom icons.

📬Published Alpha Packages:@codecademy/gamut@57.5.0-alpha.7d3d42.0@codecademy/gamut-icons@9.32.1-alpha.7d3d42.0@codecademy/gamut-illustrations@0.49.1-alpha.7d3d42.0@codecademy/gamut-kit@0.6.452-alpha.7d3d42.0@codecademy/gamut-patterns@0.9.16-alpha.7d3d42.0@codecademy/gamut-styles@17.2.0-alpha.7d3d42.0@codecademy/gamut-tests@5.1.3-alpha.7d3d42.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://67348a478bc08be320b5c4c6--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut@57.5.0-alpha.f857dc.0@codecademy/gamut-icons@9.32.1-alpha.f857dc.0@codecademy/gamut-illustrations@0.49.1-alpha.f857dc.0@codecademy/gamut-kit@0.6.452-alpha.f857dc.0@codecademy/gamut-patterns@0.9.16-alpha.f857dc.0@codecademy/gamut-styles@17.2.0-alpha.f857dc.0@codecademy/gamut-tests@5.1.3-alpha.f857dc.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://6734993dea0a2ee34f876237--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut@57.5.0-alpha.89adc0.0@codecademy/gamut-icons@9.32.1-alpha.89adc0.0@codecademy/gamut-illustrations@0.49.1-alpha.89adc0.0@codecademy/gamut-kit@0.6.452-alpha.89adc0.0@codecademy/gamut-patterns@0.9.16-alpha.89adc0.0@codecademy/gamut-styles@17.2.0-alpha.89adc0.0@codecademy/gamut-tests@5.1.3-alpha.89adc0.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://673f3b47848775162b15d870--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut@57.5.0-alpha.89adc0.0@codecademy/gamut-icons@9.32.1-alpha.89adc0.0@codecademy/gamut-illustrations@0.49.1-alpha.89adc0.0@codecademy/gamut-kit@0.6.452-alpha.89adc0.0@codecademy/gamut-patterns@0.9.16-alpha.89adc0.0@codecademy/gamut-styles@17.2.0-alpha.89adc0.0@codecademy/gamut-tests@5.1.3-alpha.89adc0.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://673f4adc0d52ee00c6ee82c7--gamut-preview.netlify.appDeploy Logs

still need to look into some of this CSS stuff here, but i'm wondering because of the added complexity and dependecies here if this should be moved into it's own package outside of Gamut (esp the CSS stuff makes me think this might be best?) @jakemhiller curious about your thoughts here!
i'm also going to look to see if other design systems have video players and take a look around

Yeah, i think a separate package makes sense. @dreamwasp were you thinking it should still be in this repo? i think it would be fine in the repo, since the dependencies and stuff will be mostly isolated. I haven't taken a really deep look at the code, but it does seem like we have to do a lot to make it work, which isn't great. I haven't been close enough to the project to suggest any alternatives though, if that's even an option.


did not work

--- Installing files in kali-linux
--- Installing SSH, GPG, etc. agent scripts in kali-linux
--- Disabling conflicting systemd services in kali-linux
--- Updating desktop-file MIME database in kali-linux
Get:1 http://kali.download/kali kali-rolling InRelease [30.5 kB]
Get:2 http://kali.download/kali kali-rolling/main amd64 Packages [17.8 MB]
Get:3 http://kali.download/kali kali-rolling/main amd64 Contents (deb) [40.3 MB]
Get:4 http://kali.download/kali kali-rolling/contrib amd64 Packages [108 kB]
Fetched 58.3 MB in 15s (3,983 kB/s)
Reading package lists... Done
Reading package lists...
Building dependency tree...
Reading state information...
desktop-file-utils is already the newest version (0.26-1).
desktop-file-utils set to manually installed.
0 upgraded, 0 newly installed, 0 to remove and 28 not upgraded.
--- Installing WSLUtilities in kali-linux
Hit:1 http://kali.download/kali kali-rolling InRelease
Reading package lists... Done
Reading package lists...
Building dependency tree...
Reading state information...
The following NEW packages will be installed:
apt-transport-https gnupg2
0 upgraded, 2 newly installed, 0 to remove and 28 not upgraded.
Need to get 595 kB of archives.
After this operation, 620 kB of additional disk space will be used.
Get:1 http://kali.download/kali kali-rolling/main amd64 apt-transport-https all 2.3.8 [160 kB]
Get:2 http://kali.download/kali kali-rolling/main amd64 gnupg2 all 2.2.27-2 [434 kB]
Fetched 595 kB in 1s (467 kB/s)
Selecting previously unselected package apt-transport-https.
(Reading database ... 501913 files and directories currently installed.)
Preparing to unpack .../apt-transport-https_2.3.8_all.deb ...
Unpacking apt-transport-https (2.3.8) ...
Selecting previously unselected package gnupg2.                                                                                Preparing to unpack .../gnupg2_2.2.27-2_all.deb ...                                                                                Unpacking gnupg2 (2.2.27-2) ...                                                                                Setting up gnupg2 (2.2.27-2) ...                                                                                Setting up apt-transport-https (2.3.8) ...
Processing triggers for kali-menu (2021.3.1) ...
Processing triggers for man-db (2.9.4-2) ...
--2021-08-27 09:07:35--  https://access.patrickwu.space/wslu/public.asc
Resolving access.patrickwu.space (access.patrickwu.space)... Warning: apt-key is deprecated. Manage keyring files in trusted.gpg.d instead (see apt-key(8)).
<IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>, ...
Connecting to access.patrickwu.space (access.patrickwu.space)|<IP_ADDRESS>|:443... failed: Connection timed out.
Connecting to access.patrickwu.space (access.patrickwu.space)|<IP_ADDRESS>|:443... failed: Connection timed out.
Connecting to access.patrickwu.space (access.patrickwu.space)|<IP_ADDRESS>|:443... failed: Connection timed out.
Connecting to access.patrickwu.space (access.patrickwu.space)|<IP_ADDRESS>|:443... failed: Connection timed out.
Connecting to access.patrickwu.space (access.patrickwu.space)|<IP_ADDRESS>|:443... failed: Connection timed out.
Connecting to access.patrickwu.space (access.patrickwu.space)|<IP_ADDRESS>|:443... failed: Connection timed out.
Connecting to access.patrickwu.space (access.patrickwu.space)|2400:cb00:2049:1::a29f:1b48|:443... failed: Network is unreachable.
Connecting to access.patrickwu.space (access.patrickwu.space)|2400:cb00:2049:1::a29f:1981|:443... failed: Network is unreachable.
Connecting to access.patrickwu.space (access.patrickwu.space)|2400:cb00:2049:1::a29f:1a63|:443... failed: Network is unreachable.
Connecting to access.patrickwu.space (access.patrickwu.space)|2400:cb00:2049:1::a29f:1827|:443... failed: Network is unreachable.
Connecting to access.patrickwu.space (access.patrickwu.space)|2400:cb00:2049:1::a29f:1819|:443... failed: Network is unreachable.
gpg: no valid OpenPGP data found.
Hit:1 http://kali.download/kali kali-rolling InRelease
Ign:2 https://access.patrickwu.space/wslu/kali kali-rolling InRelease
Ign:2 https://access.patrickwu.space/wslu/kali kali-rolling InRelease
Ign:2 https://access.patrickwu.space/wslu/kali kali-rolling InRelease
Err:2 https://access.patrickwu.space/wslu/kali kali-rolling InRelease
Cannot initiate the connection to access.patrickwu.space:443 (2400:cb00:2049:1::a29f:1b48). - connect (101: Network is unreachable) Cannot initiate the connection to access.patrickwu.space:443 (2400:cb00:2049:1::a29f:1981). - connect (101: Network is unreachable) Cannot initiate the connection to access.patrickwu.space:443 (2400:cb00:2049:1::a29f:1a63). - connect (101: Network is unreachable) Cannot initiate the connection to access.patrickwu.space:443 (2400:cb00:2049:1::a29f:1827). - connect (101: Network is unreachable) Cannot initiate the connection to access.patrickwu.space:443 (2400:cb00:2049:1::a29f:1819). - connect (101: Network is unreachable) Could not connect to access.patrickwu.space:443 (<IP_ADDRESS>), connection timed out Could not connect to access.patrickwu.space:443 (<IP_ADDRESS>), connection timed out Could not connect to access.patrickwu.space:443 (<IP_ADDRESS>), connection timed out Could not connect to access.patrickwu.space:443 (<IP_ADDRESS>), connection timed out Could not connect to access.patrickwu.space:443 (<IP_ADDRESS>), connection timed out Could not connect to access.patrickwu.space:443 (<IP_ADDRESS>), connection timed out
Reading package lists... Done
W: Failed to fetch https://access.patrickwu.space/wslu/kali/dists/kali-rolling/InRelease  Cannot initiate the connection to access.patrickwu.space:443 (2400:cb00:2049:1::a29f:1b48). - connect (101: Network is unreachable) Cannot initiate the connection to access.patrickwu.space:443 (2400:cb00:2049:1::a29f:1981). - connect (101: Network is unreachable) Cannot initiate the connection to access.patrickwu.space:443 (2400:cb00:2049:1::a29f:1a63). - connect (101: Network is unreachable) Cannot initiate the connection to access.patrickwu.space:443 (2400:cb00:2049:1::a29f:1827). - connect (101: Network is unreachable) Cannot initiate the connection to access.patrickwu.space:443 (2400:cb00:2049:1::a29f:1819). - connect (101: Network is unreachable) Could not connect to access.patrickwu.space:443 (<IP_ADDRESS>), connection timed out Could not connect to access.patrickwu.space:443 (<IP_ADDRESS>), connection timed out Could not connect to access.patrickwu.space:443 (<IP_ADDRESS>), connection timed out Could not connect to access.patrickwu.space:443 (<IP_ADDRESS>), connection timed out Could not connect to access.patrickwu.space:443 (<IP_ADDRESS>), connection timed out Could not connect to access.patrickwu.space:443 (<IP_ADDRESS>), connection timed out
W: Some index files failed to download. They have been ignored, or old ones used instead.
Reading package lists...
Building dependency tree...
Reading state information...
E: Unable to locate package wslu
Skipping Gpg4win installation
--- Adding a Windows scheduled tasks and starting services

This should now be fixed.


Highlighted links in wiki destroys entire wiki section --> markup problem

Hi everyone,
looks like there's a bug in MS Teams Wiki.
Everytime I try to highlight a link to a document from the team in a wiki section, it opens the document but also deletes the section from wiki where the link was located.
To reproduce:

Copy a link from a document located in Teams
Paste the link into a wiki section
Highlight it with the text marker
Click on the link
Watch how the section is gone

Anyone with the same experience?

We are not able to reproduce this issue. Are you pasting the link in wiki page content section and highlighting? Could you please share some screenshots?

Exactly.
Firstly, copying the link to an alternate text. The link opens a Word file, which is located in the channel "general". Wiki is in "general" as well.

After that, use the highlight option to highlight the alternate text for the link.

After you click on the link, the wiki section should be removed.

@davegr99, We still could not able to repro this issue. After you highlight a alternate text which have a link associated with it, clicking on that text should navigate to the  inserted link. Please find the attached screenshot.

If you are still facing this issue, Please record a video and attach the same here. We will look into thi.

Yes, the link takes me to the document, but after that, when I close the document, the wiki section is empty. Here's the video you asked for:
Teams issue.zip
Thanks for your help!

Hello again,
how's the progress with this issue after two weeks?
Could you replicate it?

@davegr99 , We still could not able to repro this issue. It is working fine on our end.

That's problematic.
But you see in the video, that it's not working.
Right? So I'm not hallucinating 🤐


usage issue

usage issue

doubts about how to use the software

I need to understand how do I increase the backoffLimit for the job  it creates to install kubernetes.
I basically want to attempt installation multiple times . Is it possible?

@ErikJiang  it would be great help , if you can guide me for above. thanks

We removed backoffLimit since v0.8.0.
These are reasons:
Almost failures during the job was caused by the sluggish network, and on the other hand a lot of retrying logic for that in Kubespray. If it is still failed, we consider that it is generally cannot resilient after job restarting, maybe there are some brokens in your operating system. Overall, Kubespray is not completely reentrant, so we removed backoffLimit.
But for workarroud, if you still want to use backoffLimit, you could downgrade kubean version to below v0.8.0

@tu1h  thanks for your response. I understand that you have removed backoffLimit for valid reasons that you have mentioned. I was wondering if it is possible to give an option to user(as an optional argument which can be defaulted to backoffLimit to 0) in helm chart deployment. I would be helpful for us.
Thank you.

Hi @prtkdave, we're actually interested in understanding your specific usage scenario, why is backoffLimit needed in your scenario?
I'd also like to add an explanation as to why we'd want to remove backoffLimit, one important reason is that operating a cluster is a relatively prudent behavior.
For example, when performing an upgrade operation, we'd rather create a new ClusterOperation after a failed one than have the job automatically retry, which creates a lot of uncertainty and destroys the scene of the crime, making it more expensive to troubleshoot.


[CI] Rev ci-cpu image to include latest PRs

I'm just raising this as a request for the ci-cpu image to be updated, to include latest PRs updating dependencies. Specifically, I'm interested to get #8514 into the image.
As a way to simplify the work required by someone with access to upload tlcpack images, I've already tested images based on my ongoing work with tlcpackstaging. Here is the job in which all tests pass with an updated set of images: https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/ci-docker-staging/146/pipeline
So, my understanding of the work needed here is:
docker pull tlcpackstaging/ci_cpu:20210815-225913-1a95f9bd0
docker tag tlcpackstaging/ci_cpu:20210815-225913-1a95f9bd0 tlcpack/ci-cpu:v0.76   # already bumped by 0.01
docker push tlcpack/ci-cpu:v0.76

Once this is done, we can create a PR to Rev the image version and than make it permanent.
So, the tasks:

[ ] pull, retag, push docker images using commands above (needs to be done by someone in the list below)
[ ] submit a PR updating the ci-cpu version on Jenkins (one the one above is done, I can do that myself)

I have no permission to upload images myself, so I'm adding here the people I think have access to do so: @tqchen @areusch @jroesch @zhiics @masahi.
cc @grant-arm @u99127

@leandron I am currently executing the push, will ping back when its done.

@leandron its currently uploading to dockerhub

That is completed now. Closing the issue. Thanks @jroesch.