Add acro mode for fw

When setting up a new fw I noticed that there is no acro mode for airplanes according to the docs.
Is this correct? And in that case how much work would it be to implement?

Probably not that much work actually, but it's a bit awkward with the way ECL is currently structured. The rate setpoint is converted to bodyrate in control_bodyrate(). https://github.com/PX4/ecl/blob/master/attitude_fw/ecl_roll_controller.cpp#L59
I've been working on a refactor of fw_att_control to use controllib and I was going to throw in acro and rattitude mode. https://github.com/dagar/Firmware/blob/fw_att_control_cleanup/src/modules/fw_att_control/FixedwingAttitudeControl.cpp
Interested in working together to add acro and review/test?

Nice!
I am in the middle of my thesis at the moment so don't have much time left for coding, but I can for sure do my best in reviewing and testing :)

Do you have any opinions on FW acro? Would you like to see pure rate mode with stick input = bodyrate setpoint for roll, pitch, yaw? We could also do a bit of a hybrid and re-enable attitude control below a certain threshold (rattitude), or hold the current attitude when the sticks are neutral.

I would go with pure rate control, I think it is the most fun to fly. At least to start with:)

I am looking for FW acro too. Want to fly FPV and rate mode should give the best experience.

@dagar @CarlOlsson I'm also interested in helping drive this. I've spend some time thinking about this and have some comments and questions:

We need to handle the turn compensation for acro mode. When you attempt to do a roll the controller will output lots of pitch up which eventually will lead to a yawrate (in earth frame) which then could have a negative (blocking) effect on roll. I've given this a test in JSBSim and had great problems doing a 360 roll when turn compensation was enabled. Maybe we can scale pitch control down when roll angle is close to 90 degrees.

We need to think if and how we want to use the rudder during roll maneuvers. Ideally, the rudder could be used to hold pitch during a knife edge maneuver. However, in the simulator I had problems rolling the plane further due to the coupling of the rudder with roll.
I have to say that I didn't use an acro plane in the simulation so this effect might not be as strong as I encountered it.

I assume we want to lock the attitude (roll, pitch) when the user is not giving stick inputs?

Stick inputs from the user (roll, pitch) should be interpreted as desired body rates, NOT euler angle rates.

@CarlOlsson Carl, does that make sense to you as an experiences acro pilot?

I was originally thinking of coming back to this a bit later after casually working on the stick_mapper and/or fw_att_control cleanup, but it's easy enough to do now.
I think the main thing is to coordinate and agree on a design here. At a minimum we'll need to refactor ecl to be able to set body rates directly.

Should acro even have turn compensation?
2/3. Would that be if sticks are neutral store the current attitude as a setpoint and resume control_attitude? Or just keep the rate 0?
yep

If we can work through the details here I'll propose refactoring ecl and the rest of the changes shouldn't be too bad. Do you think we need/want separate rate limits for FW acro?

@dagar Comments to

Can't really say, I never flew a fixed wing in acro. I could imagine that it could be useful holding the altitude while doing rolls.

I would go for keeping the attitude. That may help when flying in turbulence.

Intuitively I think attitude lock does sound better. It should be easy to experiment with and without as well as per axis. It also easily gives us rattitude from the beginning as well.
I think that should also take care of the knife edge case.

There are 2 use cases:

fun 3d flying for everybody
rate support for planes with properties that make them difficult to fly nice manually (also for good pilots)

For 1) attitude locking is fine, for 2) body rate control is needed. Reading back @CarlOlsson would also go for rate control. I'm also more a fan of 2 because I think if you now how a plane flies fully manual you'd expect a similar behavior in 3D mode and that is not holding attitude.

I've quickly looked through a few stabilizers and most of them support both, some of them only with attitude locking. Rate only control is usually advertised as added stability with less adverse impact on agility of the plane.
NX3 Evo: both
FY-40A: attitude
Vector: both
bavarianDemon: both
APM: attitude

That's for the overview @AndreasAntener
I think now the most difficult part is deciding how to restructure ECL fw_attitude. The body angular rate transformation is done in control_bodyrate, but depends on the rate setpoint from other controllers from the same iteration.

I'll discuss with Roman today but I'm thinking of extracting the PID controls from the control_bodyrate methods and use them directly when in the correct mode. Then split up the block for attitude control. This should work for rate control. For attitude locking I think the ECLs need a mode so you can use them like now but they handle all the axis without the turn compensation. We're probably only going to implement the first part now. Does that make sense to you? Would you want to take over attitude locking?

Great to see so much progress here, awesome! I agree with @AndreasAntener, the preferences for acro mode are probably very different from person to person. Some want a mode that does the aerobatic "by itself" and some want a plane that feels more like it is in "assisted manual". However, I think pure rate control is the most natural mode that should be supported. It is also what users outside of the autopilot community would expect when they go with "acro" since it corresponds to normal RC "gyros" e.g. http://www.multiplex-rc.co.uk/multiplex-wingstabi-system-53-c.asp

@dagar Here is a video of my first results.
This is controlling body x rate with pitch still controlled as in stabilized. You can see really well how rudder is used to control pitch at large roll angles.
https://www.youtube.com/watch?v=t8Ie6F2PFF4&feature=youtu.be

@CarlOlsson I have a question about turning behaviour in acro mode.
When you speak about "full rate control" what do you mean regarding the body_z axis?
When you bank the plane it will try to do a turn which requires non-zero body_z rate. Should there be some kind of turn coordination in acro mode?

I would as a start not control rate around body z since it is not really needed to achieve a smoother more wind robust feeling for a plane in acro mode compared to pure manual, it is also not possible to control it for many airframes, e.g. flying wings without rudder.

@CarlOlsson Is your plane ready? ;-)
https://www.youtube.com/watch?v=Qz62aW02SPk&feature=youtu.be

@tumbili of course :)

Implemented in #6567

@CarlOlsson you're up ;)


findOne( {} ) returns the whole Collection .data

Hi, first and foremost thanks for this wonderful piece of code.
I noticed (on the latest github version as well as on later versions) a strange behavior:
if I call *.findOne( {} )   (with empty criteria) the result I get is the whole .data of the collection.
Calling *.findOne({live:1}) where live is a parameter all stored documents satisfy,
the query correctly returns an Object of the Collection.
(btw: calling *.findOne() <-- without arguments the result is a Resultset but the call itself is uncorrect.)
Thanks for your time,
--R

Not sure how we missed both of those... thanks for pointing out.   Both cases should be fixed, let me know if you have any issues.  I will try to remember to add unit test for that.

Hi @obeliskos . Confirmed.
tested find() and find({}) and now they are OK.
--R


New Fairs rail

[x] Working Fairs rail
[x] Tests

Please note the ordering of rails is expected to change as we near the finish of the Home/ForYou scene; I put Fairs at the top for now.

Fixes https://github.com/artsy/collector-experience/issues/454
Skip New Tests

@sarahscott 👌  looks awesome!

Fails

:no_entry_sign:

No CHANGELOG added.

:no_entry_sign:

Missing Test Files:

src/lib/Scenes/Home/Components/ForYou/__tests__/index-tests.tsx

If these files are supposed to not exist, please update your PR body to include "Skip New Tests".

  Generated by :no_entry_sign: dangerJS

Warnings

:warning:

Missing Test Files:

src/lib/Scenes/Home/Components/ForYou/__tests__/index-tests.tsx

If these files are supposed to not exist, please update your PR body to include "Skip New Tests".

  Generated by :no_entry_sign: dangerJS

@katarinabatina it's up for code review now 🌺

Warnings

:warning:

Missing Test Files:

src/lib/Scenes/Home/Components/ForYou/__tests__/index-tests.tsx

If these files are supposed to not exist, please update your PR body to include "Skip New Tests".

  Generated by :no_entry_sign: dangerJS

@l2succes just realized matt is OOO - reassigning to you!


SimpleXMLElement::addAttribute(): string is not in UTF-8

This might not be an issue with this package, but I thought I'd let you know. I'm getting a lot of errors from dbtlr/php-airbrake
Uncaught exception 'ErrorException' with message 'SimpleXMLElement::addAttribute(): string is not in UTF-8' in /home/forge/example.co.uk/vendor/dbtlr/php-airbrake/src/Airbrake/Notice.php:59

I've opened an issue: https://github.com/dbtlr/php-airbrake/issues/50
If you have any ideas let me know

Seems to be an nginx issue so I'll close this!


Requesting VSYNC toggle option

Could it be possible to add a VSYNC toggle option to to remove the 60 fps lock?
Thank you for your service! 😄

Related :
https://docs.unity3d.com/ScriptReference/Application-targetFrameRate.html
https://docs.unity3d.com/ScriptReference/QualitySettings-vSyncCount.html

On all other platforms, Unity ignores the value of targetFrameRate if you set vSyncCount.

An option to also set the framerate would also be a nice thing if we can disable the vsync or a single option "targetFrameRate that do both like 0=vsync,, -1 unlimited (not sure if possible), otherwise set target frame rate to x fps).

So I believe that when you set Application.targetFrameRate to -1 it uses the screen refresh rate but I can grab that at runtime anyway just in-case. Setting it to 0 uncaps the framerate (when VSync is off obviously).
It's kind of annoying because, say you wanted VSync on but the framerate capped to 60 you would have to use vSyncCount=1 on a 60Hz display, 2 on a 120Hz display etc etc. You effectively can't set an arbitrary framerate cap when VSync is enabled.
So with that, I'll add a VSync toggle but I won't be exposing Application.targetFrameRate since it behaves differently when VSync is engaged. I think having both would just confuse people. I'd highly recommend setting a framerate cap with tools like RTSS/Special K/your GPU driver control panel. They'll produce better framepaced results than unity's framerate limiter anyway and they work just fine with VSync.

Added in v0.9.3.


Fix DebuggerDisplay-Attribute of GroupName

This makes the debugger display the compareString as intended, instead of this error message:
error CS0103: The name 'Item2' does not exist in the current context

thx


Create an Embiggen class.

I believe the package would benefit by the creation of an Embiggen class that handles every aspect of the graph embedding, such as:
class Embiggen:

    def __init__(self, ...all the arguments):
        # Initialization of the class

    def fit(self, graph):
        # Actual learning of the embedding of the graph and tuning of the
        # Embiggen graph for future embeddings

    def transform(self, graph)->"Embeddding of graph":
        # Return embedding of the given graph based on the learned embedding

It could then be used as follows:
from embiggen import Embiggen
from models import MyModel

graph_train, graph_test = load_data()

embedder = Embiggen(arguments here)
embedder.fit(graph_train)
embed_train = embedder.transform(graph_train)
embed_test = embedder.transform(graph_test)

model = MyModel(arguments here)
model.fit(embed_train)

pred_train = model.train(embed_train)
pred_test = model.train(embed_test)

After the code refactoring that we are doing in the ray_loss_function branch it should not be that far off, maybe one hackathon down the line.
What do you think?

The implemented Embiggen class can be seen here.


[WIP] Trust cli

First iteration of the trust tool to register and manage grants

@dmcgowan next steps?

Figuring out how the namespace will work with distribution and other elements, then breaking down how the cli will work with it.

yeah. that discussion is stagnated a bit. I would love to see domain names
and a hierarchy of paths in the namespace, rather than just 'username'.
Where can we have that discussion?
On Tue, Jan 27, 2015 at 4:11 PM, Derek McGowan<EMAIL_ADDRESS>wrote:

Figuring out how the namespace will work with distribution and other
elements, then breaking down how the cli will work with it.
—
Reply to this email directly or view it on GitHub
https://github.com/docker/libtrust/pull/42#issuecomment-71728798.

The discussion will happen under distribution with expectation that different roles will be represented when discussing the namespaces.  The namespace responsibility will ultimately spin off to trust when there is a defined working group.


[c#] Unexpected syntax color for nested namespace declarations

Namespaces contained in namespace declarations don't get any syntax coloration.
Additionally while the "Light" theme show a color for the namespace keyword different from the namespace name, the "Dark" one doesn't.
Version 0.12.2

This issue was moved to atom/language-csharp#44

Now tracked in https://github.com/OmniSharp/omnisharp-vscode/issues/101


Remove raw image on rebuild

Closes #339

Closes https://github.com/suse-edge/edge-image-builder/issues/337


Navigate to /output path with LinktaFlow ID path variable on returned valid response from LLM

Related User Story

Related Tickets

Acceptance Criteria

The user should be redirected on a successful response.
Consider how LLM response streaming might impact this logic; redirect on first chunk? What happens if the stream never resolves?
Subtasks
<!-- If necessary, break down the ticket into smaller, actionable subtasks. Create issues accordingly.>

Since this ticket is related to #228 where streaming may be implemented so I unassigned myself from this ticket for now.


🧑💻 : add times of different zones/countries in Clock project

:red_circle: Title : create an option to display live time from several countries/time zones. The project currently only displays time of india.
:red_circle: Enhancement Aim : add more functionality to project and increase user interactions
:red_circle: Changes :

aiming to create a dropdown menu using which user will be able to select timezones of different countries and display their respective time
the page will start with displaying time in india

Screenshots 📷

display time of different countries and display the country's name with the time

✅ Details to Include When Taking the Issue:
Name : Riya Chauhan
Participant Role : GSSOC, Hacktoberfest, Contributor

Happy Contributing! 🚀
Wishing you all the best on your open source journey. Enjoy! 😎

Hi @Riyachauhan11 , I noticed you’re assigned to this issue. I’m really interested in working on it too. If you’re unable to continue, I’d love to take over or assist you. I believe I can bring some valuable insights to this problem. Let me know what you think!

Hi @Riyachauhan11 , I noticed you’re assigned to this issue. I’m really interested in working on it too. If you’re unable to continue, I’d love to take over or assist you. I believe I can bring some valuable insights to this problem. Let me know what you think!

Hi! Thanks for reaching out. I’m planning to continue working on this issue and I’m confident I’ll be able to finish it. However, if for some reason I’m unable to complete it, I’ll definitely let you know and you can take over.


Miscellaneous Fixes Before Release

Changes

[x] Only parse status if confirming success in parser

Pull Request Test Coverage Report for Build 3086

6 of 8 (75.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 65.507%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

parser/intent.go
6
8
75.0%

Totals

Change from base Build 3076:
0.01%

Covered Lines:
2015

Relevant Lines:
3076

💛  - Coveralls


[cleanup] remove engine-use-ray

Finally removing this. We should start looking at worker-use-ray too.

Thanks @simon-mo! It would be great to get this merged asap since it simplifies other changes being made (and the code in general).
I think at some point at least, some of the tests "relied" on this setting to avoid the issues with re-initializing a vllm in the same process, especially in multi-worker cases. There have been some improvements to that but it might be that something else is needed instead to get around this, like splitting into separate tests / pytest invocations for example.

superseded by #8126


fosspay: init at 3b957a1b

Motivation for this change
#119290
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Testing
{
  imports = [
    /home/pn/code/nixpkgs/nixos/modules/services/web-apps/fosspay.nix
  ];

  services.fosspay.enable = true;
  services.fosspay.config = ''
[dev]
# Change this to the actual location of your site
# You can include a path in the domain if it's a subdirectory
# i.e. domain=drewdevault.com/donate
# omit the trailing slash
protocol=http
domain=localhost:5000
# Change this value to something random and secret
secret-key=hello world

# On the debug server, this lets you choose what to bind to
debug-host=<IP_ADDRESS>
debug-port=5000

# Fill out these details with your mail server
smtp-host=mail.example.org
smtp-port=587
smtp-user=you
smtp-password=password
<EMAIL_ADDRESS>
# Your information
your-name=Joe Bloe
<EMAIL_ADDRESS># ^ you should have a gravatar that works with this email

# SQL connection string
connection-string=postgresql://postgres@localhost/fosspay

# Stripe API info: https://dashboard.stripe.com/account/apikeys
stripe-secret=
stripe-publish=

# Currency to use
# "usd" for dollar, "eur" for euro
# refer to stripe documentation for details : https://stripe.com/docs/currencies
currency=usd

# Separate with spaces
default-amounts=3 5 10 20
# Which one to pick when they arrive?
default-amount=5

# Pick between "monthly" and "once"
default-type=monthly

# Display monthly donations publicly
public-income=yes

# How much are you hoping to earn monthly, in cents
goal=500

# Optional Patreon integration
# Register a client here: https://www.patreon.com/portal/registration/register-clients
# And put in the "Creator's Access Token" here:
patreon-access-token=
# And the "Creator's Refresh Token" here:
patreon-refresh-token=
# Client ID
patreon-client-id=
# Client secret
patreon-client-secret=
# And the Patreon campaign you want to connect with:
patreon-campaign=

# Optional LiberaPay integration, fill in your username here
liberapay-campaign=

# Optional GitHub sponsors integration
# Generate personal access key at https://github.com/settings/tokens
# Must have "user" access.
github-token=

# Command to reload fosspay (send it a SIGHUP)
reload-command=kill -HUP $(pgrep -xf '/usr/bin/python3.*app.py' | tail -n 1)
  '';

  nixpkgs.config.packageOverrides = pkgs: {
    fosspay = pkgs.callPackage /home/pn/code/nixpkgs/pkgs/servers/fosspay {};
  };

  system.stateVersion = "20.03";
}

Result of nixpkgs-review pr 119750 at b497478b run on x86_64-linux 1

1 package built successfully:

fosspay

3 suggestions:

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/servers/fosspay/default.nix:30:3:
   |
30 |   installPhase = ''
   |   ^

warning: license-missing
Package is missing a license.
Near pkgs/servers/fosspay/default.nix:30:3:
   |
30 |   installPhase = ''
   |   ^

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near pkgs/servers/fosspay/default.nix:30:3:
   |
30 |   installPhase = ''
   |   ^

Update:

Still struggling with setting up database connection, because psycopg2 complains about empty password. Weird, by default postgres doesn't use trust as it is in docs - this sounds not right but I'm not sure.
This module will not configure nginx. I set up gunicorn.
I use connectionString because it is the format that sqlalchemy uses, and it's easier to left it as it is.
TODO: cronjob.py

Nice update! A few notes:

I would guess your postgresql issue is likely resolved by specifying the socket in the connection string
at some point before we merge this you should take a look at https://github.com/NixOS/nixpkgs/issues/121293


Register  atribute automatically

… on the default, unnamed service behavior. This can help prevent issues such as https://github.com/Microsoft/ApplicationInsights-SDK-Labs/issues/6 in many basic cases.
If the user is using named behaviors, then it will still need to be added manually.

Hi @tomasr, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

Do you need a new NuGet now or want to accumulate more fixes?


Fix protobuf comparison

Description

This PR addresses https://github.com/openfga/openfga/issues/894 by using protocmp functions to check that proto messages in unit tests are semantically equal
References
https://github.com/openfga/openfga/issues/894
Review Checklist

[x] I have clicked on "allow edits by maintainers".
[x] I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
[x] The correct base branch is being used, if not main
[x] I have added tests to validate that the change in functionality is working as expected

Hey @jon-whit,
I prepared PR to fix https://github.com/openfga/openfga/issues/894
I see unit tests and linter jobs run only after a maintainer approval. Can you help me to run them?

Hey @jon-whit,
I prepared PR to fix #894
I see unit tests and linter jobs run only after a maintainer approval. Can you help me to run them?

Yeah, no problem. Do you mind rebasing first please? Then I will approve them to run.

Yeah, no problem. Do you mind rebasing first please? Then I will approve them to run.

Hey @jon-whit, I have rebased the branch.
Please take a look again


Compilation for Windows

Is it possible to add a target for Windows? Cross-compilation on Linux/macOS.
Thanks for your great work! Really simple script which works fine on macOS.

Hi Aleksid1, I'm not using Windows, so there are no plans to support this OS.


AI can view Mindshields and Wanted status.

About the PR

Replaces the AI Job Icon view with a Status Icon view, which allows it to see mindshields and wanted status.
Why / Balance

Currently just seeing job icons is underwhelming and pretty useless.
Technical details

Renamed the ActionShowJobIcons to be Status icons instead.
Added new components to the toggle that AI is using.
Media

Requirements

[X] I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changed the ID of ActionShowJobIcons to ActionShowStatusIcons
Changelog

:cl:

tweak: AI can now see mindshields and wanted status.

In 13, ai can only see jobs and structure health borgs/mechs

In 13, ai can only see jobs and structure health borgs/mechs

That can be easily adjusted if needed

again, same with aghost, really would be better to have toggleable menu for this

again, same with aghost, really would be better to have toggleable menu for this

This is a toggle

i mean, so you can toggle which of icons you want to see now

Please explain in the technical details section why you are removing the Clear() call in the systems. It probably is there for a reason, so make sure this does not break anything else.

Please explain in the technical details section why you are removing the Clear() call in the systems. It probably is there for a reason, so make sure this does not break anything else.

Thanks for reminding me, and as far as i tested it works fine, leaves no duplicate comps or anything, same with other huds

Removed the health stuff because its bugged also kinda makes little sense.

Borgs and AI shouldn't be concerned with mindshield status or wanted status, it was already removed from borgs somewhat recently

Borgs and AI shouldn't be concerned with mindshield status or wanted status, it was already removed from borgs somewhat recently

Absolutely agree, ill cause more RP issues

I think AI has more of a concern with wanted stuff
Though in that case the toggle might as well be removed so AI can always see job icons

I think AI has more of a concern with wanted stuff
Though in that case the toggle might as well be removed so AI can always see job icons

The AI should always, and only, be able to see job icons, just like borgs. It is the sole determination of whether someone is crew under default lawsets.
Being wanted or not having a mindshield doesn't change that.

i dont want ai being sec sided, sec ai is worst ai

i dont want ai being sec sided, sec ai is worst ai

There should be some rule clarification when it comes to ai.  I've heard people refer to ai as "valid-hunting" via bolting/snitching on antags.  Is it against the rules for AI to go out of its way to aid security/command?
I get why Borgs don't get the wanted status because they are 99.9% of the time non-combatants who shouldn't be valid hunting, but AI is supposed to be... intelligent and be constantly updated with as much information as the station gives.

i dont want ai being sec sided, sec ai is worst ai

As someone who mains AI in 13 (now 14) we tend to lean on sec most of the time they are really easy to assist and need to get into departments most of the time also if you see someone getting killed and then looted its kinda in your best interest to bolt the door. Now does this mean were vaild hunting?? no we are the station in a way a murderer being bolted off and alerted to security is fine. But if the ai player ONLY interacts with sec it kinda ruins ai as job you have so power to assist people in their jobs and thus should use that power. Even SEEING a wanted symbol would get you sidetracked and focused on helping sec detain this person, rather then seeing this person do bad and helping sec in the moment or being requested by sec to help.

i dont want ai being sec sided, sec ai is worst ai

There should be some rule clarification when it comes to ai. I've heard people refer to ai as "valid-hunting" via bolting/snitching on antags. Is it against the rules for AI to go out of its way to aid security/command? I would think that that's the intended ai playstyle for most of the "good" lawsets(NT default, crewsimov, robocop, paladin, etc).
I get why Borgs don't get the wanted status because they are 99.9% of the time non-combatants who shouldn't be valid hunting, but AI is supposed to be... intelligent and be constantly updated with as much information as the station gives.

I think Ai snitching and bolting doors is completely ok it doesn't cause crew harm and leads to less to harm, Also think about this again but cut out solo antags... yeah the ai would kinda WANT and NEED to tell somebody about Ninjas, Nukies, Dragons, Rat Kings, Revs (The Ghostly Kind).
As Ai you are the station, And threats to the crew and the station are threats to YOU. How i preserve this under crewsimov is helping sec falls under law 1 and law 3, and just so were clear why it would be bad if there was a rule like this heres a example
You see something whos died in a closed off room there's someone standing in a corner healing themselves and its clear to you the Ai that they are murderer.  I've heard people refer to ai as "valid-hunting" via bolting/snitching on antags. Is it against the rules for AI to go out of its way to aid security/command? I would think that that's the intended ai playstyle for most of the "good" lawsets(NT default, crewsimov, robocop, paladin, etc).
I get why Borgs don't get the wanted status because they are 99.9% of the time non-combatants who shouldn't be valid hunting, but AI is supposed to be... intelligent and be constantly updated with as much information as the station gives.

Thus far, and I've complained about it too. AI becomes "sec bot" and starts ordering sec around, which is causing a headache for HOS, Warden or Cap to organise people. I don't care if they can see jobs but AI-sec right now is just annoying to me.

i dont want ai being sec sided, sec ai is worst ai

There should be some rule clarification when it comes to ai. I've heard people refer to ai as "valid-hunting" via bolting/snitching on antags. Is it against the rules for AI to go out of its way to aid security/command? I would think that that's the intended ai playstyle for most of the "good" lawsets(NT default, crewsimov, robocop, paladin, etc).
I get why Borgs don't get the wanted status because they are 99.9% of the time non-combatants who shouldn't be valid hunting, but AI is supposed to be... intelligent and be constantly updated with as much information as the station gives.

Thus far, and I've complained about it too. AI becomes "sec bot" and starts ordering sec around, which is causing a headache for HOS, Warden or Cap to organise people. I don't care if they can see jobs but AI-sec right now is just annoying to me.

I feel like youre misunderstanding ordering people around and being told about a threat. most of the time sec head to the location of an active threat to suppress it believe it or not the literal camera with a speaker can give pin pointing information with no risk what so ever.
And if youre issue is the Ai says "Doctor Pomsom is breaking into caps room from maints." then you should also have a problem with "Hey medical there's a dead engi by solars can you go pick him up."

I don't think this is good for the game in any way.
It's the same reason that cameras aren't mapped into maints roundstart. A.I. is the ultimate information gathering role, and giving them access to more tools and information without any additional effort would just cause massive balance issues. A.I. having access to all comms, but also able to see mindshields and criminal status are IMO too much. A.I. seeing mindshields would prevent people from being able to disguise as command, and if A.I. can see somebody being wanted they can find them without much additional effort, thus completely shutting down their escape. However A.I. CAN choose to read the criminal records console, as well as has access to security channel. I just don't think personally that the INFORMATION role should be given more tools to make their already easy ability to gather information, even easier. Not to mention think about malf/comp AI? This just makes command even bigger targets than they already are in all circumstances, not even mentioning the effect it has on crew. ALSO what about when Ninjas hack criminal records to turn all crew into WANTED?

HoP and Captain were given administrative HUDs, that display only job icons, because they don't need Wanted and Mindshield status to do their job. This is the same thing for AI, except even more important. AI is supposed to control access to places, opening doors, etc, so job info is important.
Giving AI vision of Wanted status, in particular, would make hiding as an antag completely impossible. Giving them Mindshield vision would do the same for revs.
Long story short : you don't want to give Big Brother any more information than absolutely necessary for their job.

s someone who mains AI in 13 (now 14) we tend to lean on sec most of the time they are really easy to assist and need to get into departments most of the time also if you see someone getting killed and then looted its kinda in your best interest to bolt the

You seem to misunderstand the Ai's job completely. The Ai is meant to be the head of Borgs ordering them to do things whilst assisting every department in many ways.
Such as pointing out the locations of anoms to sci, Pointing out station threats to sec, Alerting parameds and medical that death has happened ect. Opening doors is like the least thing you do as Ai.
Giving the AI the power to see wanted status ruins game balance for crooks if the Ai can just see a wanted person at a glance instead of already helping sec locate said person.

Hey, I brought this up for maintainer discussion and the decision was to close this PR for the following reasons:

While the AI can see the same information via the criminal records console it is not its primary job to do so
AI can already see sec channel and hear callouts so it can protect the station against more immediate threats, but you won't need a wanted icon when someone is running down the hallway with a C20-r
Showing the mindshield status makes is very hard for someone to disguise as sec or command

wanted status is necessary,


git config global

You should probably specify that one should configurate git locally (whatever that means) so that committing does not cause a "*** please tell me who you are" error. It should be specified in the 1.4 section of SSH keys.

Thanks, I have add this information here.


Hive 2485/mce 2.6: Backport AssumeRole, credential_process, and kubeconfig exec fixes

Manual cherry-picks of commits related to #2306, #2356, and #2366. See individual commit messages for details.
HIVE-2485

/assign @jstuever
/cc @suhanime
Almost clean backport of these commits.

/lgtm
/approve

/approve

/cherry-pick mce-2.5


'subscript out of bounds' error when running process_weights()

Hi, im receiving this error when following the new cTWAS version tutorials and i'm not sure where to begin solving it:
> tissue_weights <- preprocess_weights(weight,
                                      region_info,
                                      gwas_snp_ids = z_snp$id,
                                      snp_map = snp_map,
                                      type = "expression",
                                      context = TISSUE,
                                      weight_format = "PredictDB",
                                      drop_strand_ambig = TRUE,
                                      scale_predictdb_weights = TRUE,
                                      load_predictdb_LD = TRUE,
                                      ncore = 8)
2024-10-11 12:28:57.952098 INFO::Load weight: /scratch/c.c1214964/cell_specific_TWAS/data/DB_files/Astrocytes.weights_main.db
2024-10-11 12:28:57.955291 INFO::weight_name: Astrocytes_expression
2024-10-11 12:28:57.957155 INFO::type: expression
2024-10-11 12:28:57.958958 INFO::context: Astrocytes
2024-10-11 12:28:57.962862 INFO::Load PredictDB weights
2024-10-11 12:29:05.125009 INFO::Number of molecular traits in weights: 11041
2024-10-11 12:29:05.126549 INFO::No 'protein_coding' in 'extra_table$gene_type'. Skipped filtering protein coding genes.
2024-10-11 12:29:05.127658 INFO::Load PredictDB LD
2024-10-11 13:02:10.574406 INFO::Remove 7 molecular traits without predictdb LD
2024-10-11 13:02:11.047144 INFO::Number of molecular traits in weights: 11034
2024-10-11 13:02:11.331974 INFO::Number of variants in weights: 1949168
2024-10-11 13:02:14.257097 INFO::10986 molecular traits and 1585419 variants left after filtering by GWAS and the reference.
2024-10-11 13:02:15.438338 INFO::Harmonizing and processing weights ...
Error in FUN(X[[i]], ...) : subscript out of bounds
In addition: Warning message:
In mclapply(X, FUN, mc.cores = mc.cores) :
  all scheduled cores encountered errors in user code

Thanks

There may be some issue with the weights. Can you try with ncore = 1, and send us the error messages?

output on 1 core:

2024-10-11 15:10:41.534125 INFO::Load weight: /scratch/c.c1214964/cell_specific_TWAS/data/DB_files/Astrocytes.weights_main.db
2024-10-11 15:10:41.535846 INFO::weight_name: Astrocytes_expression
2024-10-11 15:10:41.536955 INFO::type: expression
2024-10-11 15:10:41.537959 INFO::context: Astrocytes
2024-10-11 15:10:41.53914 INFO::Load PredictDB weights
2024-10-11 15:10:46.857979 INFO::Number of molecular traits in weights: 11041
2024-10-11 15:10:46.859248 INFO::No 'protein_coding' in 'extra_table$gene_type'. Skipped filtering protein coding genes.
2024-10-11 15:10:46.860123 INFO::Load PredictDB LD
2024-10-11 15:41:30.813686 INFO::Remove 7 molecular traits without predictdb LD
2024-10-11 15:41:31.265229 INFO::Number of molecular traits in weights: 11034
2024-10-11 15:41:31.556502 INFO::Number of variants in weights: 1949168
2024-10-11 15:41:34.617714 INFO::10986 molecular traits and 1585419 variants left after filtering by GWAS and the reference.
2024-10-11 15:41:35.861548 INFO::Harmonizing and processing weights ...
Error in `[<-`(`*tmp*`, i, j, value = 1) : subscript out of bounds

Thanks! Sorry, the message is not very informative.
If convenient, would you mind sharing your input to this function? You can put the weight file, region_info, z_snp$id, and snp_map in a zip file on Dropbox, Google Drive, etc. and share the link. (you can skip the snp_map if you use the snp_map we provided). I could help check it.

Thank you for your help
Weight file, region_info, z_snp$id, and snp_map can be found here
UKB b37 LD files are the ones provided by you and Astrocytes.weights_main.txt.gz looks like this:
GENE RSID1 RSID2 VALUE
ENSG00000120915 rs1000108 rs1000108 0.5024130787464004
ENSG00000120915 rs1000108 rs10091924 0.028539554451590954
ENSG00000120915 rs1000108 rs10109760 NA
...

@Chris-Wills thanks for providing the test data. The snp_map is a ".txt" file, but it should be a list object that you can save as ".rds" file. Did you create the snp_map using our create_snp_LD_map() function?
From your provided weight covariance table "Astrocytes.weights_main.txt.gz", it has NAs in the "VALUE" column. I suspect this might cause the problem. We assume no missing values in this table.

Sorry, the snp_map was produced the right way i just saved it as a .txt to send it over, i can send it again if necessary.
Removing all rows containing NA from Astrocytes.weights_main.txt.gz made no difference unfortunately, same error.

Thanks! Can you save snp_map as a .rds file and share the link again? also, please also share the Astrocytes.weights_main.txt.gz file.

Files zipped together here

Thanks for providing the data. I checked your weight file. The issue was that PredictDB weight LD files typically use the varID column (in the format of "chr_pos_ref_alt_build") in the weight table. But your weight LD file uses rsIDs, which causes conflicts. I have fixed the issue and it allows using rsIDs or varIDs now. Please reinstall the ctwas package and try again.
Btw, your PredictDB weight file and LD file are very large. Loading the PredictDB LD file takes a lot of memory. We typically recommend using sparse weights, as dense weights could cause computational challenges. You can also try using the LD_map we provided and turn off load_predictdb_LD argument.  This will compute LD in weights using reference LD instead of PredictDB LD file. This will have less memory requirement for your data and could potentially run faster.

Thank you so much for updating the package and for the recommendations!
Could I ask for a very rough estimate on memory usage/compute time with your LD_map before I submit on our cluster?

It is a little hard to estimate. For the PredictDB files we used in our tutorial, which are much smaller than yours, it usually takes a few minutes with load_predictdb_LD = TRUE, and < 30 minutes with load_predictdb_LD = FALSE. If you use the LD_map we provided, it loads LD matrices on-the-fly, so it shouldn't have too much memory issue, you can use multiple cores to parallelize. You can try running on a smaller chromosome, e.g.:
tissue_weights <- preprocess_weights(weight_file,
                                                                   region_info = region_info[region_info$chrom == 22,],
                                                                   gwas_snp_ids = z_snp_ids,
                                                                   snp_map = snp_map,
                                                                   LD_map = LD_map,
                                                                   type = "expression",
                                                                   context = "Astrocytes",
                                                                   weight_format = "PredictDB",
                                                                   drop_strand_ambig = TRUE,
                                                                   scale_predictdb_weights = TRUE,
                                                                   load_predictdb_LD = FALSE,
                                                                   ncore = 6)

You can even run chromosome-by-chromosome and then concatenate the results.

I just tried with 50GB memory and 4 cores, it took around 5 minutes to run preprocess_weights for chr22.

Amazing, thanks


How to reduce the speed of popup?

I want to reduce the speed of the popup dialog.I used the like..
<PopupDialog
ref={"cartClosePopup"}
dialogStyle={{height: 300, width: 300, backgroundColor: 'rgba(0, 0, 0, .0)',}}
dialogAnimation={slideAnimation}
closeOnTouchOutside={false}
overlayBackgroundColor={'#000000'}
overlayOpacity={0.8}
animationDuration={1600}
        >

But it is not taking the speed i have given.

@Prasanna4693
Currently we cannot change the speed for the SlideAnimation but you can create new animation by you self and pass it into the PopupDialog component by the dialogAnimation prop.
For example:
/* @flow */

import { Animated } from 'react-native';
import Animation from './Animation';

type Param = {
  toValue: number,
  slideFrom: string,
}

export default class SlideAnimation extends Animation {
  constructor({ toValue = 0, slideFrom = 'bottom' }: Param) {
    super(toValue);
    this.animations = this.createAnimations(slideFrom);
  }

  toValue(toValue: number, onFinished: ?Function) {
    Animated.spring(this.animate, {
      toValue,
      velocity: 0,
      tension: 65, # change speed
      friction: 10,
    }).start(onFinished);
  }

  createAnimations(slideFrom: string): Object {
    const transform = [];

    if (['top', 'bottom'].includes(slideFrom)) {
      if (slideFrom === 'bottom') {
        transform.push({
          translateY: this.animate.interpolate({
            inputRange: [0, 1],
            outputRange: [800, 1],
          }),
        });
      } else {
        transform.push({
          translateY: this.animate.interpolate({
            inputRange: [0, 1],
            outputRange: [-800, 1],
          }),
        });
      }
    } else if (['left', 'right'].includes(slideFrom)) {
      if (slideFrom === 'right') {
        transform.push({
          translateX: this.animate.interpolate({
            inputRange: [0, 1],
            outputRange: [800, 1],
          }),
        });
      } else {
        transform.push({
          translateX: this.animate.interpolate({
            inputRange: [0, 1],
            outputRange: [-800, 1],
          }),
        });
      }
    }

    const animations = {
      transform,
    };

    return animations;
  }
}

If you want to do something related to speed then use Animated.timing because in the spring animation we don't have any control related to speed.


Provide metadata for headers in *-sceneRect.csv

Thanks a lot for putting together and making this great tool available!
Could you add somewhere in the readme file of bat_eval/ the information stored in the different columns, some are pretty straightforward to understand (ie DetectorConfidence) but others are rather cryptic (ie Spec_x1).

Hi @lionel68,
Thanks for your comments. Agreed, the info in the -sceneRect.csv files is a bit cryptic, they used for loading the annotations in AudioTagger and do not provide any extra info beyond what is available in the main results.csv file i.e. the call end times is just a fixed window size, not predicted.

Also, if you have any other suggestions on how I can improve the tool I would be happy to hear them. Thanks

So, do we have some infos on the headers now?

You will find an updated description in the readme:

The code outputs annotations as one big csv file. The location where to save the file is specified with the variable:
op_file_name_total = 'res/op_file.csv'
It contains three fields file_name, detection_time, and detection_prob which indicated the time in file and detector confidence (higher is more confident) for each detected call.
It also saves the outputs in a format compatible with AudioTagger. The output directory for these annotations is specified as:
op_ann_dir = 'res/'
The individual *-sceneRect.csv files contain the same information that is specified in the main results file op_file_name_total, where LabelStartTime_Seconds corresponds to detection_time and DetectorConfidence corresponds to detection_prob. The additional fields (e.g. Spec_x1) are specific to Audiotagger and do not contain any extra information.


ARM Docker image

Feature request
Build & publish ARM64 version of the Docker image.
Is your feature request related to a problem? Please describe.
AMD64 images have terrible performance on M1 Macs (even M1 Pro/M1 Max)
Describe the solution you'd like
It would be cool to build & publish linux/arm64 version of the Docker image to Docker Hub, it would help a lot with local development on M1 Macs.
Describe alternatives you've considered
Running existing linux/amd64 image.
Additional context
sysbench CPU benchmark results for linux/amd64 version of the base postgres image:
root@c0af6e852479:/# sysbench cpu --threads=2 run
sysbench 1.0.20 (using system LuaJIT 2.1.0-beta3)

Running the test with following options:
Number of threads: 2
Initializing random number generator from current time

Prime numbers limit: 10000

Initializing worker threads...

Threads started!

CPU speed:
    events per second:   360.03

General statistics:
    total time:                          10.0029s
    total number of events:              3602

Latency (ms):
         min:                                    5.33
         avg:                                    5.55
         max:                                   11.34
         95th percentile:                        5.67
         sum:                                19994.19

Threads fairness:
    events (avg/stddev):           1801.0000/0.00
    execution time (avg/stddev):   9.9971/0.00

sysbench CPU benchmark results for linux/arm64 version of the base postgres image:
root@3cd6496ebf2a:/# sysbench cpu --threads=2 run
sysbench 1.0.20 (using system LuaJIT 2.1.0-beta3)

Running the test with following options:
Number of threads: 2
Initializing random number generator from current time

Prime numbers limit: 10000

Initializing worker threads...

Threads started!

CPU speed:
    events per second: 21270.60

General statistics:
    total time:                          10.0001s
    total number of events:              212719

Latency (ms):
         min:                                    0.09
         avg:                                    0.09
         max:                                    2.68
         95th percentile:                        0.10
         sum:                                19970.88

Threads fairness:
    events (avg/stddev):<PHONE_NUMBER>/5.50
    execution time (avg/stddev):   9.9854/0.00

60x faster!

Resolved in #98


Thoughts on new-movement

I've read the new-movement code roughly, nice work @mattyoung-improbable! and here's my naive feedback on it

the issue i already posted on discord.
character do a jump when i try to move right(i only press D key), i guess something gose wrong with AdjustVelocity or ApplyMovementProcessor, CharacterController use a collide and slide algorithm,  so AdjustVelocity may do some wrong math in calc velocity (like go up stairs/slope)

A more generic taken on CommandFrameSystem + client-prediction would be better. i'll give some reasons why:

CharacterController is actually part of phyiscs, such as doing RigidBody/projectile physics along with CharacterController movement, unity now can have multiple physics scenes & manully simulation step, it would be easy to fulfill gameplay based on physics if we extend the movement system. also the bug above is essentially making wrong assumption about how CharacterController behave.
Unity is planning a new C# based CharacterController, they said it's "equivalent of the PhysX CharacterController", so it will act more like kinematic object but with manually dynamic behaviors. I guess it should be easy to implement features like standing on moving object, Details still TBD
both Overwatch  / Rocket League bring a network model doing client-prediction to all things (overwatch team even develop a node-based language named Statescript to make hero design easier)

More docs would be better. i still can't figure out what PidController is doing.

Thanks so much for the feedback!

I'm still not sure where this bug comes from, it seems to happen whenever you walk into a small step / land on an edge when jumping. Will do some investigations and try to isolate the issue. Might be character controller config with step height / capsule radius or something.

The CharacterController being passed in is leftover from before the pipeline when lots of the module used it. I think now the only part of the pipeline that uses it is the ApplyMovement processor, which could easily get the reference from somewhere else, making the pipeline completely generic.
Interesting, I'll check it out.
This is something I've been thinking about too. The next piece I'm working on is to encode all the input / movement data into a bytes field in schema and provide some API for getting / setting specific data. So if, for example you wanted analog movement instead of WASD, you could add a 2d vector into the input instead of 4 booleans. At that point, you could run any part of the game you needed to through the system.

There will definitely be docs! And maybe even a tech talk if I'm feeling bold 😄

Some updates have happened!

All the input / movement state is now defined outside the module in custom_movement.schema
All the fps movement is handled by the FpsMovement class
All references to CharacterController have been removed from the module, so you can bring your own controller 😄
Under the hood, the custom types you define are being serialized / deserialized by the module, hopefully in the future there will be some Gdk features which will remove the need to do this.
All the old IMovementProcessor have been quickly refactored for the new separation, they don't feel that great yet, need to figure out what level of abstract is best for users, will only come from experimenting though.
Going to start on docs tomorrow I promise.

haha, sounds great !
I checked out the new source, but i got this error when click play, and can not spawn player:
EntryPointNotFoundException: Schema_SerializeBuffer
Improbable.Worker.CInterop.SchemaObject.Serialize () (at <86c1bcc0c96e47b9ba174df556efe490>:0)
FpsMovement.SerializeStateStatic (Improbable.Fps.Custommovement.CustomState state) (at Assets/Fps/Scripts/GameLogic/FpsMovement.cs:168)
Fps.FpsEntityTemplates.Player (System.String workerId, Improbable.Vector3f position) (at Assets/Fps/Scripts/Config/FpsEntityTemplates.cs:49)

seems there is sdk/plugin version issue?

Oh oops, there's currently a bug in the Core Sdk. In your gdk directory you'll need to modify
gdk-for-unity/workers/unity/Packages/com.improbable.gdk.tools/core-sdk.version
to
13.5.0-b7977-97561-WORKER-SNAPSHOT
and then 'Download CoreSdk (force)' from the SpatialOS menu.

Ahh, might be some changes in core that are only in master. Could you checkout master of gdk and see if that works?

it works for now, thx

Awesome! The code that touches the standard Character Controller is the CharacterControllerMovement.Move() static method. There shouldn't be any other references.

Yes, unity SAC's OpenCharacterController is quite simple like the old CharacterController, but the concrete ThirdPersonBrain/FirstPersonBrain introduces many other complex concepts i'm still figuring that out.

Thank you for the feedback!
As the new movement feature module has been dropped from the roadmap, this issue will be closed.


Fix decoding of embedded complex data

Description
The current implementation assumes that complex input data embedded in the WPS post request is base64 encoded. This is not always the case. Probably this issue needs to fixed in both OWSLib.wps and PyWPS.
See discussion in PR #560
Environment

operating system:
Python version:
PyWPS version: 4.2.9
source/distribution
[ ] git clone
[ ] Debian
[ ] PyPI
[ ] zip/tar.gz
[ ] other (please specify):
web server
[ ] Apache/mod_wsgi
[ ] CGI
[ ] other (please specify):

Steps to Reproduce
Additional Information

Hello,
As far as I understand the standard WPS 1.0.0 is quite ill-formed, and the embedded data should be decoded as base64 only if the encoding attribute is base64.
Other encoding string does not make sense for PyWPS because the encoding of the XML data is the encoding used for the full XML document including text section. Note that etree.parse cleanup properly the escape sequence such as XML entities and CDATA pattern. Thus in my opinion the data should be the decoded string from etree with no more guesses, leaving the WPS implementation dealing with unknown encoding.
--- a/pywps/app/WPSRequest.py
+++ b/pywps/app/WPSRequest.py
@@ -775,7 +775,7 @@ def _get_rawvalue_value(data, encoding=None):
             return data
         elif encoding == 'base64':
             return base64.b64decode(data)
-        return base64.b64decode(data)
+        return data
     except Exception:
         LOGGER.warning("failed to decode base64")
         return data

After a double check even more in WPS 1.0.0, it seems that there is not base64 references, only the WPS 2.0.0 has base64 reference.


delete nodebalancer config

Closes #1789

Coverage decreased (-0.1%) to 81.929% when pulling 2322717d27e86c23f7900bebea139b334237117a on na3d:nb-config-delete into b41353b4ea457712fc3b38b2521ca56a430344e2 on linode:master.

Coverage decreased (-0.1%) to 81.929% when pulling dae9219d0dc61532f4d8ae02d0da15097a76e499 on na3d:nb-config-delete into b41353b4ea457712fc3b38b2521ca56a430344e2 on linode:master.


How track the dependencies?

Hello!
I was analizing my bundel and was confuse to find some
big libs on top leve, despite i new use them in my project.
After some reasers i found that that libs was in dependenses
of lib that I use directly.
So.
Why some of libs that was not directly imported but is in
dependencies of other libraries end up on top level?
Is there the way define who is dependent on particular
lib and why it end up in bundle?

Could you send a screenshot of your analyzer browser view so we could see what you mean by top level? Thanks!

Here  moments.js and hammer.js is used only by Vis.js.

Thanks for the extra explanation! Unfortunately, such feature is not yet possible. This issue is a duplicate of #53 so I'll close this one.

@valscion got it thanks.


Sending messages directly to the bot won't receive a reply.

Sending messages directly to the bot should also receive from openai.

even in direct message with the bot, u need to mention the bot(@chatgpt) to trigger the bot to reply.
i would be better if the bot automatically replies.


Long rebuild time for watched blog change

Where to find the issue

Input on cwa-website - blog
Output on http://localhost:8000/en/blog/

Describe the issue
If there is any change made to a blog source and the gulp start-server task is running to display the web contents to http://localhost and to watch for changes, then multiple rebuilds take place and the build takes a long time to complete.
Steps to reproduce
On a local clone of https://github.com/corona-warn-app/cwa-website execute:
npm ci
npm run test:prepare
npm start

After the browser starts, navigate to http://localhost:8000/en/blog/.
In an editor, open blog\2099-01-01-visual-testing\index.md, make a change in the text and save the change.
The terminal window now fills with Starting 'pages'...
Wait for [Browsersync] Reloading Browsers... to be shown in the terminal window.
Note that approximately 1000 lines have been output to the terminal window and the elapsed time is about six times longer than the original build and display sequence.
Press F5 in the browser window to display the text changes which were made. (This step is necessary until issue https://github.com/corona-warn-app/cwa-website/issues/2239 is resolved.)
Analysis
The gulp task start-server in gulpfile.js starts the server and then watches for changes.
When a change is made to one of the blog source files being watched in blog/**/* the buildBlogFiles function is triggered. This (re-)creates subdirectories and index.html (intermediate html) files in src/pages/{de,en}/blog/. Then the pages function is triggered which picks up everything and compiles into public using Panini.
The watch function watches also src/pages/**/*.html. This is problematic because of the number of changes to src/pages/**/*.html caused by running the buildBlogFiles function. Each change causes the pages and reload function to run, leading to a multitude of unnecessary calls.
pages is already called through the blog/**/* watch. reload is triggered later through the watch on src/data/**/*.{js,json,yml} because buildBlogFiles places blogentries.json into src/data which triggers resetPages, pages and reload in sequence.
Suggested change
The section in gulpfile.js which watches for changes in src/pages/**/*.html should be excluded from watching files produced by the buildBlogFiles function.
The pages to be excluded from watching are
src/pages/{de,en}/blog/*-*-*-*/
and
src/pages/{de,en}/blog/*-*-*-*/index.html.
The same issue also applies to the Science blog, however because there are only 4 science blog articles currently, completion of the Science blog rebuild is not delayed so much that it causes a practical problem.

PR ##2249 submitted to resolve this issue.

Thanks to @browkin for testing!
PR #2249 is merged and I verified that it works after the merge by separately changing src\data\blog.json and src\data\science.json, then observing that the web is rebuilt quickly and with only a small number of steps.

@MikeMcC399 Thanks for reporting and providing PR!


fix(ci): whitenoise lint failed when pull request

What type of PR is this?
Fix whitenoise lint error

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes 523

Thanks for working on it, I did not look deep into this issue, but it seems like still throw an error in Pull Request.

Thanks for working on it, I did not look deep into this issue, but it seems like still throw an error in Pull Request.

You're right, I'm not entirely sure about the exact problem either. This is my first test, and I will further study how to solve this issue carefully.

Please temporarily ignore the previous commit records above. I am currently investigating the cause of the issue on my own branch.

Hi, @Xunzhuo. I've identified the issue. In the github pull request CI environment, there is no branch information available, causing the git diff command to fail. Therefore, I added a git fetch command to retrieve the remote branch information and prefixed the branch names with "origin" to match them.
Here is my debug info for reference.

https://github.com/zaunist/gateway/actions/runs/6262614026/job/17005194717

/retest

@zaunist DCO is failing, can you squash, sign and push again ?

@zaunist DCO is failing, can you squash, sign and push again ?

Done

DCO is still failing, you might need to squash commits and then resign and push

I am OK with current approach, thanks for working on it @zaunist.
Actually I think this one is not that high priority, if you would like to help, we can try to pick some important issues for you : )

Willing to make more contributions


Images not appearing in notebooks of jupyterbook - broken links to originals.

This is a Jupyter-book version issue: for more recent versions,  tags are intercepted and the images are copied correctly. Not so for older versions. That is why this issue appeared on the GitHub pages version.


Is there any method to reload particular row and column

Expected Behavior
I'm using spreadsheet view, I need to reload only particluar row and column  is there any method to allow me this?
Actual Behavior
I'm using spreadsheet view, I need to reload only particluar row and column  is there any method to allow me this?
Steps to Reproduce the Problem

Reload spreadsheetview

Specifications

Xcode version: 13.1
iOS version: iPad 15.2

Looking for the same thing, please let me know if anyone has come across a solution


Adding Labelbox annotation backend

This PR adds a Labelbox backend to FiftyOne's annotation API.
Complete documentation is available (after next release) at https://voxel51.com/docs/fiftyone/integrations/labelbox.html.
Example usage
First create an account at https://app.labelbox.com.
pip install labelbox

export FIFTYONE_LABELBOX_API_KEY=...

import fiftyone as fo
import fiftyone.zoo as foz
from fiftyone import ViewField as F

# Step 1: Load your data into FiftyOne

dataset = foz.load_zoo_dataset("quickstart")

dataset.evaluate_detections("predictions", gt_field="ground_truth", eval_key="eval")

# Step 2: Locate a subset of your data requiring annotation

# Create a view that contains only high confidence false positive model
# predictions, with samples containing the most false positives first
most_fp_view = (
    dataset
    .filter_labels("predictions", (F("confidence") > 0.8) & (F("eval") == "fp"))
    .sort_by(F("predictions.detections").length(), reverse=True)
)

# Retrieve the sample with the most high confidence false positives
sample_id = most_fp_view.first().id
view = dataset.select(sample_id)

# Step 3: Send samples to Labelbox

# A unique identifier for this run
anno_key = "labelbox_basic_recipe"

label_schema = {
    "new_ground_truth": {
        "type": "detections",
        "classes": dataset.distinct("ground_truth.detections.label"),
        "attributes": {
            "iscrowd": {
                "type": "radio",
                "values": [True, False],
            },
        },
    },
}

view.annotate(
    anno_key,
    backend="labelbox",
    label_schema=label_schema,
    launch_editor=True,
)
print(dataset.get_annotation_info(anno_key))

# Step 4: Perform annotation in Labelbox and save the tasks

# Step 5: Merge annotations back into FiftyOne dataset

dataset.load_annotations(anno_key)

# Load the view that was annotated in the App
view = dataset.load_annotation_view(anno_key)
session = fo.launch_app(view=view)

# Step 6: Cleanup

# Delete tasks from Labelbox
results = dataset.load_annotation_results(anno_key)
results.cleanup()

# Delete run record (not the labels) from FiftyOne
dataset.delete_annotation_run(anno_key)

@ehofesmann FYI- After making the docs updates to this PR, I decided that it wasn't overly pressing to add a SampleCollection.build_label_schema() method that would generate an annotation-style label schema for one or more existing label fields; the examples in the docs here are fairly clean as is.
Two reasons for this:

Such a method would have to take a backend parameter, because EG the types chosen for attributes depend on what backend you choose (what widgets they support)
Ben's work on embedded document schemas will provide a similar field + attribute schema capability, so I want to make sure an annotation-specific method isn't confusing

My current thinking is that we might just add a utility method in fiftyone.utils.annotation like so:
build_label_schema(sample_collection, fields, backend="cvat"):
    pass

LGTM.
Per offline discussions, I updated the Labelbox backend to explicitly raise an error if an existing field is passed to annotate(), since uploading existing labels is not yet suported.
To go along with that, I updated all the examples in the integration docs to be sure that no pre-existing fields are ever used. I also updated the "Editing labels with a free Labelbox account" section to show my recommended workflow for editing labels (using a new, temporary label field to store edits).
I read through the tutorial and see that there may need to be some work done there to show valid workflows for "editing" existing labels. I was planning to just copy my recommended best practice over from the integration docs, but I noticed some strange things like how some images contain skis but that doesn't appear in any of the label schema definitions that I saw. So, I got cold feet and didn't update the code in the tutorials.

Thanks for the updates! I've gone ahead and added your method to the tutorial.


react-router-redux Redirects no longer trigger an action to the reducer

Version
<EMAIL_ADDRESS>&<EMAIL_ADDRESS>Summary
Redirects in a route nolonger trigger an action to the reducer.
Steps to reproduce
My routes setup.
const Routes = ({store}) => (
  <CoreLayout>
    <Switch>
      <Route exact={true} path='/' render={Routes.homeRedirect} />
      <Route path='/photos/:folder*' component={PhotoView} />
    </Switch>
  </CoreLayout>
)

Routes.homeRedirect = () => (
  <Redirect to='/photos' />
)

Expected Behavior
In version alpha.6 both the initial page load and the redirect are sent to the reducer.
{
  type: '@@router/LOCATION_CHANGE',
  payload: {
    pathname: '/',
    search: '',
    hash: ''
  }
}

{
  type: '@@router/LOCATION_CHANGE',
  payload: {
    pathname: '/photos',
    search: '',
    hash: '',
    key: 'mswocw'
  }
}

Actual Behavior
With version alpha.7 and 8 the only initial page load is sent to the reducer
{
  type: '@@router/LOCATION_CHANGE',
  payload: {
    pathname: '/',
    search: '',
    hash: ''
  }
}

Other than build tooling updates and a relaxed React peer dep, nothing was changed between alpha.6 and alpha.8. Was anything changed in your app when upgrading?

I know I had a look look through the commits to see if I could pinpoint the
problem.
If I downgrade to alpha.6 then I get the expected result, upgrading results
in the problem surfacing again.
I'll try to put together an example tonight to reproduce the problem.
On 24 Oct. 2017 10:08 pm, "Tim Dorr"<EMAIL_ADDRESS>wrote:
Other than build tooling updates and a relaxed React peer dep, nothing was
changed between alpha.6 and alpha.8. Was anything changed in your app when
upgrading?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ReactTraining/react-router/issues/5655#issuecomment-339002548,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC7AoQ70VR-ZKWEqlxtsvKMklZH0-OKtks5sve9egaJpZM4QEbav
.

Experiencing this issue as well.
Connected Router beings listening to history in componentDidMount and react-router Redirect performs the history push in componentDidMount as well. Because componentDidMount is called on children before the parent, there is a moment where a Redirect pushes a new history but the Connected Router is not yet listening to history.

I have the similiar problem.
In my case, action @@router/LOCATION_CHANGE triggered twice with different pathname in wrong order: first, with pathname that is equals to Redirect to property, and then with pathname that equals Redirect from property. So reducer receives wrong last location.
P.S. i using React 16 and alpha.8 version of react-router-redux. Maybe this problem caused by new React version?

Can confirm moving this.unsubscribeFromHistory = history.listen(this.handleLocationChange);  from ConnectedRouter componentDidMount to componentWillMount fixes this issue

Or moving  this.handleLocationChange(history.location); to componentDidMount

The same issue in 5.0.0-alpha.7 and 5.0.0-alpha.8.

@sturzynski Can't do that because of #5203, which solves an SSR memory leak. We have to keep listening in cDM.
@boba-keyost That seems like it might also be wrong, as we want to have the redux state ready for the component before it renders the rest of the tree. cWM lets us set this ahead of time, since we're near the top of the tree at this point.
I'm not sure what a good solution would be here. Can we get a repro together on codesandbox.io?

Maybe you need to check if loaction was changed between cWM and cDM and if so, trigger location change action.
It would make sense because location was changed.

@timdorr Issue is reproduced there https://codesandbox.io/s/kmyj73qrr7

@sturzynski why u use ConnectedSwitch? Default Switch works fine.
I have same trouble - Redirect changle path, but not trigger action => not rerender component. I solve it by wrap every component when i have routing to Route.
@NorfAlrin try to replace  to

A similar problem.
After it rolled back to 5.0.0-alpha.6 there is no problem

I have the same problem too. LOCATION_CHANGE action isn't triggered when using Redirect.
my version is 5.0.0-alpha.8.
Please any new fix or walk around?

joining in. upgrading to alpha.7 or 8 breaks my UI. downgrading back to 6 solves the issue.
without delving into what changed I can see that the location change dispatch happens too late compared to how it was in the previous version.

Plus one's aren't helpful, but me too. This is preventing our migration to react 16, since it's an invalid peer dependency.

Tried to downgrade from alpha 8 to 6, but the problem still exists, I never see the new LOCATION_CHANGE in middleware

Downgraded alpha8 to alpha6 and still exists same problem.
How can we detect redirect route in server side?

Downgrading to alpha.6 did fix the issue for me.
For those who it did not work for, just ensure you don't have your version set to still grab alpha.8, in your package.json, "react-router-redux": "5.0.0-alpha.6" instead of "react-router-redux": "^5.0.0-alpha.6" (not the ^)

I have also just come across this issue and downgrading to alpha.6 also worked for me.
As a workaround you could also add in a nasty hack to push the new route after a timeout:
componentDidMount () {
    setTimeout(() => {
      this.props.redirectToLogin()
    }, 200)
  }

I removed BrowserRouter from ConnectedRouter and dispatch works well again! Maybe it will helps somebody.

Alpha 9 is up. We'll get this right at some point...

yes that was problem with version


feat: upstream 59f354c build

What :computer:
Fix compilation errors for upstream sync

closed due to stale state


[MonorepoBuilder] Add MonorepoBuilderConfig or MBConfig

Closed by https://github.com/symplify/symplify/pull/4085


add metadata validation for hive format

this fix #172 sub task: metadata validation for hive format
Signed-off-by: liyuan<EMAIL_ADDRESS>

this fix https://github.com/NVIDIA/spark-rapids-tools/issues/172 sub task: metadata validation for hive format
Signed-off-by: liyuan<EMAIL_ADDRESS>
@nvliyuan , a reminder that using the word "Fix issue" tells Github to close the issue automatically with the merge.
This means that entire 172 will be closed.
The right way to do that is to create a separate issue for each individual subtask.

Hi Teams, since we will refine to a better structure, so I commit all my code(including metadata validation and dataset validation) to a new pr #184, #184 contains all the changes and all addressed comments of this #173 pr, could you help review and maybe we could move to that pr and close this one
@nartal1 @amahussein


Starter code (WIP)

This is the starting code for the gitautosync cli tool.
Right now the cli acts pretty much like a simple wrapper for nbpuller.
Things still to work on:

Work on creating unit tests
Work on creating integration tests
Refactor pull_from_remote.py

Let's make the initial version as small and feature-less as possible. Let's get rid of sparse checkouts, domain validation, etc.
The initial version should be a very well testable thing of just the following:

given a git repository and file path to clone it
Make sure that the local clone is up to date with the git repository
resolving conflicts automatically in such a way that user work isn't lost.

Let's get rid of everything else, and write good unit tests for this. You can do git clone and what not in the setup phase of a unit test to keep it self contained.
We can even assume that https://nbdime.readthedocs.io/en/latest/#git-integration-quickstart is set up so we don't have to do anything notebook specific.

As an additional guideline / challenge, try to get the entire code (not counting comments, docstrings, setup.py, tests) to be under 100 lines :D I believe you can do it! :D

@yuvipanda Ok, sounds good. Thank you for your feedback. I'll give it my best shot! :)

(Haven't fully read through yet) - I'd also recommend using subprocess for git rather than the library (so we know exactly what it's doing) and argparse instead of click (since we don't have that much configurability)

OK, sounds good. I'll switch to subprocess and argparse.

We can also make this by python3 only, no need to support 2.x
On Wed, May 31, 2017 at 11:02 AM, Peter Veerman<EMAIL_ADDRESS>wrote:

OK, sounds good. I'll switch to subprocess and argparse.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/data-8/gitautosync/pull/1#issuecomment-305268803, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAB23h9tp98N4-IBLaJsLnBb4qPQfiWIks5r_atAgaJpZM4Noehb
.

--
Yuvi Panda T
http://yuvi.in/blog

I see. Cool, I'll remove the python 2.x tests.

@yuvipanda do you think it's safe to merge this into master now?

I wanna do another round of review but haven't had time yet. Work on
nbperiodicrunner for now?
On Jun 7, 2017 4:20 PM, "Peter Veerman"<EMAIL_ADDRESS>wrote:

@yuvipanda https://github.com/yuvipanda do you think it's safe to merge
this into master now?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/data-8/gitautosync/pull/1#issuecomment-306953249, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAB23n7XcaoG1j6NgPT5dGtKTlf4T8xZks5sBzBagaJpZM4Noehb
.

Sounds good. I'll work on nbperiodicrunner. I found a couple things that I can improve on the gitautosync tests, so I'll also work on that a bit too.

Cool! See if you can figure out setting up travis to automatically run
tests too!
On Wed, Jun 7, 2017 at 6:33 PM, Peter Veerman<EMAIL_ADDRESS>wrote:

Sounds good. I'll work on nbperiodicrunner. I found a couple things that I
can improve on the gitautosync tests, so I'll also work on that a bit too.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/data-8/gitautosync/pull/1#issuecomment-306972480, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAB23gL9EtUJ_mHGe-FeRzBrv8XtAXNZks5sB09OgaJpZM4Noehb
.

--
Yuvi Panda T
http://yuvi.in/blog

Travis is running on both repositories. :)

Awesome! \o/ Time to start testing!


Swift version of BMX switch

hey nice library but is it possible for you to convert your Obj-C code into Swift and release the swift files as well? Thanks in advance for your effort

hi. thank you for your suggestion. I would consider it but hold no breath.


Router to route the requests

What would you like to be added:
As a developer, I want to init a router to manage the requests that send to the proxy. The router should be able to find the target API, add a new target API, update and remove an existing API.
Why is this needed:

I think route only find the target,  the other is api manager


[New game]: DSA Quiz Game.

🎮 Game Request
There are some problems related to DSA, and any one of the 10 will be randomly asked to the user. The user needs to answer.
I will use html ,css , js , json file.
Point down the features
-A random selection of questions from a pool of 10.
-Wrong/Right answer indicator.
-Total score calculation.
-A mix of DSA concepts, logical problems, and mathematical problems.
Select program in which you are contributing
GSSoC24
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @zalabhavy !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

/assign

Hey @zalabhavy ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


Find gpu-operator subscriptions with .spec.name rather than .metadata.name

The gpu-addon CI uses the ci-artifact's toolbox "gpu_operator wait_deployment" command which used to assume that the GPU-operator's ClusterServiceVersion would have a particular label. It turned out that this label is not constant and actually dependent on the .spec.name of the Subscription that triggered the creation of that CSV. So I adjusted the script to look for the gpu operator Subscription and determine the label that we need to look for according to that Subscription's .spec.name.
The issue is in the "look for the gpu operator subscription" part - the gpu operator subscription has a different .metadata.name depending on how it's deployed (e.g. add-on vs something else). So my code would simply look for any Subscription containing the string "gpu-operator" (and it would also check that there's only one such subscription to make sure there's no funny business). But that seems to cause issues when it's deployed via add-on, because annoyingly the NFD being deployed has a .metadata.name that looks something like node-feature-discovery-operator-4.8-addon-gpu-operator-certified-addon-catalog-openshift-marketplace
As you can see it also contains "gpu-operator" so it becomes annoyingly non-trivial to find the gpu-operator subscription, we fail on the "Check that there's only one such subscription" part because they both have gpu-operator in their name.
This commit solves this issue by looking at the .spec.name rather than the .metadata.name. The NFD subscription does not contain the string "gpu-operator" in the .spec.name.

/test gpu-operator-e2e

/hold waiting for test results

We're good https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift-psap_ci-artifacts/283/pull-ci-openshift-psap-ci-artifacts-master-gpu-operator-e2e/1460199702547927040/artifacts/gpu-operator-e2e/presubmit-operatorhub/artifacts/010__gpu_operator__wait_deployment/_ansible.log
@kpouget please lgtm/approve
/unhold

thansk @omertuc
/lgtm
/approve


TypeScript twoslash

Great work.
Thank you for making this available.
I suggest adding support for twoslash comments, similar to TypeScript playground.

You can find the implementation used by TypeScript playground here:
https://github.com/microsoft/TypeScript-Website/blob/v2/packages/playground/src/twoslashInlays.ts
then, it is used (for Monaco editor) like that:
https://github.com/microsoft/TypeScript-Website/blob/dc4ecf56cb90d45e98a1afc78e1788d1cc5e208d/packages/playground/src/index.ts#L733
Also, twoslash completions can be found here:
https://github.com/microsoft/TypeScript-Website/blob/v2/packages/sandbox/src/twoslashSupport.ts
and used like that:
https://github.com/microsoft/TypeScript-Website/blob/dc4ecf56cb90d45e98a1afc78e1788d1cc5e208d/packages/sandbox/src/index.ts#L196-L207
It would be great if you consider adding support for that.
Thanks a lot.

Great, thank you.
Please let me know if you think I can help.
I have recently implemented twoslash support (for monaco editor) in my project, LiveCodes.
demo: https://livecodes.io/?x=id/ajgszcfiqvz&editor=monaco


(2.2.11) Exception ticking wild plant spawner, triggers every 24 ingame hours

IMPORTANT: Please first search existing bugs to ensure you are not creating a duplicate bug report!
Describe the bug
!!! bug description here !!!
Exception ticking wild plant spawner related error, triggers every 24 in-game hours, not sure if it will cause new plants to not generate anymore.
exception plant spawner.zip
Steps to reproduce the behavior (VERY IMPORTANT)

Load provided savefile
hit 4
get the error

Error Log
!!! Link to contents of Player.log or Error.log (MUST BE LINK) !!!
!!! Link to HugsLib log. (MUST BE LINK) !!!
https://gist.github.com/cc738522a0edecf920edaa52809c2ca2
Save file
!!! Please add a save file where the issue occurs to speed up testing and fixing of the issue !!!
Screenshots
!!! Add screenshots to help explain your problem here !!!
Mod list (For vanilla report, it has to be same as below list.)

Harmony
Core
Royalty (optional)
HugsLib
RimThreaded

Hoff mentions he fixed this issue on 2.2.14 preview. Fix is yet to be verified by Testing team

verified fix, issue is no longer present.


Implement DNS Templates

Documentation: https://dm.realtimeregister.com/docs/api/templates
Module:

[ ] Add a TemplatesApi module in the Api namespace
[ ] Add this module to the RealtimeRegister class.

Endpoints:

[ ] Get
[ ] List
[ ] Create
[ ] Update
[ ] Delete

When implementing the endpoints, make sure to include links to the documentation using the @see annotation in docblocks.
Tests:

[ ] Add tests for all the added domain objects
[ ] Add tests for all the added endpoints

Because list the URL is https://api.yoursrs.com/v2/customers/__CUSTOMER___/dnstemplates, should we build this into the Customers API?
Because you will need to specify a customer to get the list using the API.

Never mind, I see how you do it in the ContactsApi


Fixed choice of parser on case-insensitive file extension

My Garmin watch uses filenames all in caps like "E65D2014.FIT", so the code failed to choose the parser correctly.

Thank you


[BEAM-4084] Finish RowType -> Schema rename

When RowType was moved to SDK core and renamed Schema there were a few holdout methods and classes. I think I got them all. Checked with grep. Calcite uses the term rowType and all the remaining occurrences are overrides of Calcite methods.

Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.
R: @reuvenlax
CC: @akedin @apilloud

LGTM

R: @iemejia
Not-random committer choice :-)
This is just  finishing a rename. I think Reuven is less available. I can easily fix the conflicts before I merge, I just wanted to leave this green so you can see.

looks good to me


macOS: Obtain NSWindow from FlutterPluginRegistrar

This makes desktop_drop work even if Flutter is embedded into another application. In that case, the Flutter NSWindow is not the application main window.

LGTM, thanks for the contributionl.

@boyan01  Please revert this pull request. This make app cannot receive drag event. registrar.view always return nil in my case so DragTarget has never been attached.

@boyan01 Please revert this pull request. This make app cannot receive drag event. registrar.view always return nil in my case so DragTarget has never been attached.

@hieplee2997 Sorry that my PR caused issues for you. I wonder why it's nil in your case. I tried both with normal operation ("standalone") and with my special way of embedding the app into a larger application ("embedded") and it worked for both scenarios. It also seems to be the official way to get hold of the window, other plug-ins do it similarly as far as I can tell.
@hieplee2997 @boyan01 Instead of reverting, I suggest to try registrar.view?.window first and then - if that's not successful - fall back to the previous way of obtaining the window. Then it would work in all cases. If you agree to this, I would open another PR that does exactly that.

It also seems to be the official way to get hold of the window, other plug-ins do it similarly as far as I can tell.

@helgoboss I agree with this statement too.
@hieplee2997 Can you provide more information so that we can reproduce the issue you are describing? It would be great if you could provide a reproducible example.


Problems with running test_inpainting.py

Hello! When I tried to run the test_inpainting.py file, I received the following error: the inpainted image was black. But the inpainting results are normal when using the gradio demo. Can you give me some suggestions? Is there an error in my input format? In my input mask, the pixel value that requires inpainting is 1(white), and the pixel value that does not require inpainting is 0(black).

The mask format is correct (1 means mask, 0 means valid regions).
Besides, I think that the mask should be dilated to cover the whole object and its shadow.

hello!
@zhide730
how do we prepare dataset for test_inptainting.py?


fix: correct type errors in noir-contracts output

It's currently not possible to bootstrap the repository due to type errors in noir-contract due to how loading from json interacts with TS type system. This PR silences these warnings so that we can bootstrap again.

Benchmark results
No metrics with a significant change found.

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Values are compared against data from master at commit afd7b6d0 and shown if the difference exceeds 1%.
L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
128 txs

l1_rollup_calldata_size_in_bytes
45,444
179,588
716,132

l1_rollup_calldata_gas
222,996
868,160
3,449,864

l1_rollup_execution_gas
867,105
3,746,213
23,306,629

l2_block_processing_time_in_ms
1,324 (-1%)
5,108 (-1%)
21,017 (-1%)

note_successful_decrypting_time_in_ms
354 (-1%)
1,109 (-1%)
4,136 (-1%)

note_trial_decrypting_time_in_ms
64.2 (-5%)
38.5 (+1%)
133 (-4%)

l2_block_building_time_in_ms
14,847
59,146
238,266

l2_block_rollup_simulation_time_in_ms
10,558
42,166
170,269

l2_block_public_tx_process_time_in_ms
4,256
16,906
67,737

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
15,619 (+3%)
29,822 (+3%)

note_history_successful_decrypting_time_in_ms
2,809 (-4%)
5,558 (+1%)

note_history_trial_decrypting_time_in_ms
142 (+42%)
195 (+33%)

node_database_size_in_bytes
3,620,611
3,726,471

pxe_database_size_in_bytes
29,923
59,478

Circuits stats
Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit
circuit_simulation_time_in_ms
circuit_input_size_in_bytes
circuit_output_size_in_bytes

private-kernel-init
209
44,709
25,561

private-kernel-ordering
137 (+1%)
30,953
14,809

base-rollup
1,075
128,374
881

root-rollup
82.5 (+1%)
4,088
889

private-kernel-inner
287
71,236
25,561

public-kernel-private-input
202
31,891
25,561

public-kernel-non-first-iteration
200
31,933
25,561

merge-rollup
9.79 (+2%)
2,608
881

Miscellaneous
Transaction sizes based on how many contracts are deployed in the tx.

Metric
0 deployed contracts
1 deployed contracts

tx_size_in_bytes
15,487
31,878


Fix v0.9

Some fixes are added. Also a new folder of ODH containing Kfdef of ODH v0.9

@Tutj Thanks for all the corrections. Files were from a time were I deployed the Database and Kafka in another folder, which is not necessary.
But before I merge, quick remark/question: do you think it's really useful to deploy all the ODH components like Seldon, AI library,...? It just consumes more resources and may "disorient" the user who does not know what to do with all those pods, deployment configs, routes,...

Agree, we can remove unnecessary components of ODH that can consume more resources.

I also want to remove "rook-ceph-rgw-ocs-storagecluster-cephobjectstore" service when deploying rgw for OCS and modify route to point to default service of OCS. I will update the PR later

You can't do that. MCG/Noobaa, the default S3 service, does not feature
bucket notifications (at least not in this form).
On Mon., Dec. 28, 2020, 01:51 Tutj<EMAIL_ADDRESS>wrote:

I also want to remove "rook-ceph-rgw-ocs-storagecluster-cephobjectstore"
service when deploying rgw for OCS and modify route to point to default
service of OCS. I will update the PR later
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/guimou/datapipelines/pull/3#issuecomment-751602657,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA6C4YWM42C4G2OK25AIRV3SXATGFANCNFSM4VIC4IXQ
.

As by default, Noobar will be the object storage and we will have pods running under the control of noobar. However, i dont see that pod running since we deploy the demo on AWS? (actually i dont know why OCS running on AWS has no rgw :s). That is why we need to deploy rgw by hand then in this case "rook-ceph-rgw-ocs-storagecluster-cephobjectstore" service has no meaning, neither noobar?


Redoing full page

Describe the bug
this program rewirtes full pages over and over to use up max amount of tokens as quickly as possible using 200k tokens per rewrite why
Link to the Bolt URL that caused the error
https://bolt.new/~/sb1-qchflh
Steps to reproduce
none
Expected behavior
create a login
Screen Recording / Screenshot
No response
Platform
Browser name = Firefox
Full version = 132.0
Major version = 132
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:132.0) Gecko/20100101 Firefox/132.0
performance.memory = undefined
Username = asargeant88
Chat ID = 482010b38f8c

Additional context
No response

Appreciate the feedback! The team is hard at work implementing improvements to address this. If you no longer want the AI to modify a file, you can right-click that file in the Bolt code editor and select “Lock file” to prevent the AI from making further changes. This can be done for multiple files. Additionally, this page here has a number of helpful insights on using Bolt most effectively while maximizing token efficiency. Hope this helps!


Upgrade precinct to version 8

The only breaking change is a difference in CLI output, which doesn't impact madge: https://github.com/dependents/node-precinct/compare/v7.1.0...v8.1.0
It does however upgrade detective-typescript to version 7 so it'll deduplicate with the one that's a direct dependency from madge.

@pahen Could you please look at this one? 🙏

@realityking , This approach didn't seem to work for me because of the different version of precinct used by dependency-tree.
I opened a PR in dependency-tree to upgrade precinct there, and it is now merged and released. We can now upgrade both packages as shown in #284 . This approach did solve the issue of dynamic imports for me. I'm currently using the patched version off my github branch.

This is fixed in madge v5.0.0 now


Update README.md with IDOL

Hi LogiTorch Developers,
LogiTorch is such an excellent work for the field of logical reasoning and really lowers the hurdles to research in the area. Our paper "IDOL: Indicator-oriented Logic Pre-training for Logical Reasoning" has been accepted to the Findings of ACL2023 and we presented a novel pre-training framework for logical reasoning there. Therefore, I created this PR to update the readme with IDOL appended to the list of models implemented in LogiTorch, hoping to help build a richer research ecosystem together!
Best,
Xu

It will be great if you could add the model architecture and the training pipeline.

Thank you! It would be great if you could add the model architecture and the training pipeline.

Thanks for merging it! Sure, I will try to add these later after finishing my current thesis.


Light reference in the node

Describe the issue
When create GLTF file for the scene with lights, actual reference to the light does not assigned to the node.
To Reproduce
Minimal example with wrong output:
tinygltf::Model model;
tinygltf::Scene scene;

// setup the light
tinygltf::Light light;
light.name = "light";
light.type = "point";
light.intensity = 0.75;
light.color = std::vector<double>{1.0, 0.8, 0.95};

model.lights.push_back(light);

// setup the node
tinygltf::Node node;
node.name = "light_node";
// assign light to the node
node.light = 0;
// add to the model
model.nodes.push_back(node);
// and to the scene
scene.nodes.push_back(0);

scene.name = "scene_Name";
model.scenes.push_back(scene);
model.defaultScene = 0;

tinygltf::TinyGLTF gltf;
gltf.WriteGltfSceneToFile(&model, "output.gltf");

As a result it produce the following output.gltf:
{
  "asset": {
    "version": "2.0"
  },
  "extensions": {
    "KHR_lights_punctual": {
      "lights": [
        {
          "color": [
            1.0,
            0.8,
            0.95
          ],
          "intensity": 0.75,
          "name": "light",
          "type": "point"
        }
      ]
    }
  },
  "extensionsUsed": [
    "KHR_lights_punctual"
  ],
  "nodes": [
    {
      "extensions": {
        "KHR_lights_punctual": {}
      },
      "name": "light_node"
    }
  ],
  "scene": 0,
  "scenes": [
    {
      "name": "scene_Name",
      "nodes": [
        0
      ]
    }
  ]
}

Expected behaviour
The node with the name light_node should contains
"extensions": {
        "KHR_lights_punctual": {
          "light": 0
        }
      },

Possible solution
In the static void SerializeGltfNode(const Node &node, detail::json &o) function find the KHR_lights_punctual section in the json by using detail::FindMember(extensions, "KHR_lights_punctual", it); instead of detail::FindMember(o, "KHR_lights_punctual", it);

Good find!
The spec says https://github.com/KhronosGroup/glTF/blob/main/extensions/2.0/Khronos/KHR_lights_punctual/README.md#adding-light-instances-to-nodes
So we need to list light ids in extensions.KHR_lights_punctual of node.
Probably we simply forget to serialize light ids to extensions.KHR_lights_punctual of node. PR is much appreciated!

 This has been fixed by https://github.com/syoyo/tinygltf/pull/463

Thank you @ptc-tgamper, close this issue as resolved.


Add a pv-provisioning demo

PITA, I know, but license boilerplate please.

Sigh.  another that I wrote before I moved it into this repo :)

Two nits. Otherwise LGTM.

LGTM.


A small correction to the docs

[x] I've verified that I'm running youtube-dl version 2020.07.28

At https://github.com/ytdl-org/youtube-dl/blob/master/README.md#output-template the template name playlist_index is said to be "padded with leading zeros according to the total length of the playlist". This doesn't happen however (perhaps was the case in the past, then changed and not reflected in the documentation?)
To check execute
youtube-dl --get-filename -o "[index %(playlist_index)d] %(title)s.%(ext)s" "https://www.youtube.com/watch?v=a0ul-BghOAs&list=OLAK5uy_kC4d8eCdL3QzEXEAoF97MMxJLP3f6M0n0", notice the indexes 1-9 aren't padded with zeroes.

youtube-dl --get-filename -o "[index %(playlist_index)s] %(title)s.%(ext)s" "https://www.youtube.com/watch?v=a0ul-BghOAs&list=OLAK5uy_kC4d8eCdL3QzEXEAoF97MMxJLP3f6M0n0"
[index 01] Phantogram 'Nothing But Trouble' [Official Audio].mp4
[index 02] Phantogram - Black Out Days (Official Music Video).mp4
[index 03] Phantogram - Fall In Love (Official Music Video).mp4
[index 04] Never Going Home.mp4
[index 05] The Day You Died.mp4
[index 06] Howling At The Moon.mp4
[index 07] Bad Dreams.mp4
[index 08] Phantogram 'Bill Murray' [Official Audio].mp4
[index 09] I Don’t Blame You.mp4
[index 10] Celebrating Nothing.mp4
[index 11] My Only Friend.mp4

@remitamine  Sorry I didn't paste the verbose log. This is how it looks for me:
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--verbose', '--get-filename', '-o', '[index %(playlist_index)d] %(title)s.%(ext)s', 'https://www.youtube.com/watch?v=a0ul-BghOAs&list=OLAK5uy_kC4d8eCdL3QzEXEAoF97MMxJLP3f6M0n0']
[debug] Encodings: locale cp1251, fs mbcs, out cp1251, pref cp1251
[debug] youtube-dl version 2020.07.28
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.17134
[debug] exe versions: ffmpeg 4.3, ffprobe 4.3
[debug] Proxy map: {}
[debug] Default format spec: bestvideo+bestaudio/best
[index 1] Phantogram 'Nothing But Trouble' [Official Audio].webm
[debug] Default format spec: bestvideo+bestaudio/best
[index 2] Phantogram - Black Out Days (Official Music Video).mp4
[debug] Default format spec: bestvideo+bestaudio/best
[index 3] Phantogram - Fall In Love (Official Music Video).mp4
[debug] Default format spec: bestvideo+bestaudio/best
[index 4] Never Going Home.mp4
[debug] Default format spec: bestvideo+bestaudio/best
[index 5] The Day You Died.webm
[debug] Default format spec: bestvideo+bestaudio/best
[index 6] Howling At The Moon.mp4
[debug] Default format spec: bestvideo+bestaudio/best
[index 7] Bad Dreams.mp4
[debug] Default format spec: bestvideo+bestaudio/best
[index 8] Phantogram 'Bill Murray' [Official Audio].webm
[debug] Default format spec: bestvideo+bestaudio/best
[index 9] I Don’t Blame You.webm
[debug] Default format spec: bestvideo+bestaudio/best
[index 10] Celebrating Nothing.webm
[debug] Default format spec: bestvideo+bestaudio/best
[index 11] My Only Friend.webm

@lkintact use %(playlist_index)s instead of %(playlist_index)d

@s104346 Thank you, with s it worked as described.
I think it's "playlist_index (numeric)" in the documentation that confused me. Maybe since "playlist_index" only works as described if formatted as a string, it should given as "playlist_index (string)"?

@remitamine What do you think about the last paragraph in my post above?

no, the data type of value is an integer/numeric not a string. all the examples already use the syntax that I showed you here.