fix: do not panic parsing \r\n newlines

For https://github.com/denoland/deno/issues/26543

I use windows and only use \n newlines :P


界面效果优化

问题搜索后，界面大概会有5-6S的空白等待时间，用户体验干不高，可以借鉴秘塔的搜索提示

I don't have this issue, this project is highly responsive, perhaps your server needs more resources?


Add option to disable runtime object tagging

Since Boba is a statically typed language, we generally don't need the object type tag on every single object.
However, it is very useful during VM development to have runtime type information enabled. So we should place runtime type information behind a compile tag, which will remove the field from the struct. A few key areas may need to change as well, such as printing and asserting object type.

Closing as this would make total tracing during garbage collection not possible.


Protect SDS config

name: Protect SDS config with global.sds.enabled
about: Make sure SDS config fields are set only when global.sds.enabled is true
Please provide a description for what this PR is for.
Pilot refers to SDS config fields in config map to generate SDS config without checking if global.sds.enabled is true or false. Therefore, protect the SDS config fields with global.sds.enabled, and clear these fields if global.sds.enabled is false.
Without this change, when customers switch from SDS deployment to non-SDS deployment. Customers would set global.sds.enabled to false but leave global.sds.udspath and other fields unchanged. This will make Pilot still generate SDS config for Envoy, but Citadel Agent are not there to provision key/cert. It would be difficult for customers to find the root cause and fix their deployments.
Pick up https://github.com/istio/istio/pull/13605 to fix the SDS config issue.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[X] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastrcture
fixes https://github.com/istio/istio/issues/15102

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: JimmyCYJ
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rshriram
If they are not already assigned, you can assign the PR to them by writing /assign @rshriram in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JimmyCYJ: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-local-presubmit-tests.sh
64c99c4e13a728144902a9b14299f1a9f392bbf8
link
/test integ-security-local-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-local-presubmit-tests.sh
64c99c4e13a728144902a9b14299f1a9f392bbf8
link
/test integ-security-local-presubmit-tests-master

prow/integ-mixer-k8s-k8s-presubmit-tests.sh
64c99c4e13a728144902a9b14299f1a9f392bbf8
link
/test integ-mixer-k8s-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-local-presubmit-tests.sh
64c99c4e13a728144902a9b14299f1a9f392bbf8
link
/test integ-security-local-presubmit-tests-master

prow/integ-mixer-k8s-k8s-presubmit-tests.sh
64c99c4e13a728144902a9b14299f1a9f392bbf8
link
/test integ-mixer-k8s-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
64c99c4e13a728144902a9b14299f1a9f392bbf8
link
/test integ-security-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-local-presubmit-tests.sh
64c99c4e13a728144902a9b14299f1a9f392bbf8
link
/test integ-security-local-presubmit-tests-master

prow/integ-mixer-k8s-k8s-presubmit-tests.sh
64c99c4e13a728144902a9b14299f1a9f392bbf8
link
/test integ-mixer-k8s-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
64c99c4e13a728144902a9b14299f1a9f392bbf8
link
/test integ-security-k8s-presubmit-tests-master

prow/integ-istioctl-local-presubmit-tests.sh
64c99c4e13a728144902a9b14299f1a9f392bbf8
link
/test integ-istioctl-local-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-local-presubmit-tests.sh
64c99c4e13a728144902a9b14299f1a9f392bbf8
link
/test integ-security-local-presubmit-tests-master

prow/integ-mixer-k8s-k8s-presubmit-tests.sh
64c99c4e13a728144902a9b14299f1a9f392bbf8
link
/test integ-mixer-k8s-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
64c99c4e13a728144902a9b14299f1a9f392bbf8
link
/test integ-security-k8s-presubmit-tests-master

prow/integ-istioctl-local-presubmit-tests.sh
64c99c4e13a728144902a9b14299f1a9f392bbf8
link
/test integ-istioctl-local-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
64c99c4e13a728144902a9b14299f1a9f392bbf8
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Please make the change in new installer as well ( or first) and it is
sufficiently tested.
On Mon, Jun 24, 2019, 13:15 istio-bot<EMAIL_ADDRESS>wrote:

@JimmyCYJ https://github.com/JimmyCYJ: The following tests failed,
say /retest to rerun them all:
Test name Commit Details Rerun command
prow/integ-security-local-presubmit-tests.sh 64c99c4
https://github.com/istio/istio/commit/64c99c4e13a728144902a9b14299f1a9f392bbf8
link
https://k8s-gubernator.appspot.com/build/istio-prow/pr-logs/pull/istio_istio/15109/integ-security-local-presubmit-tests-master/2315 /test
integ-security-local-presubmit-tests-master
prow/integ-mixer-k8s-k8s-presubmit-tests.sh 64c99c4
https://github.com/istio/istio/commit/64c99c4e13a728144902a9b14299f1a9f392bbf8
link
https://k8s-gubernator.appspot.com/build/istio-prow/pr-logs/pull/istio_istio/15109/integ-mixer-k8s-k8s-presubmit-tests-master/122 /test
integ-mixer-k8s-k8s-presubmit-tests-master
prow/integ-security-k8s-presubmit-tests.sh 64c99c4
https://github.com/istio/istio/commit/64c99c4e13a728144902a9b14299f1a9f392bbf8
link
https://k8s-gubernator.appspot.com/build/istio-prow/pr-logs/pull/istio_istio/15109/integ-security-k8s-presubmit-tests-master/2230 /test
integ-security-k8s-presubmit-tests-master
prow/integ-istioctl-local-presubmit-tests.sh 64c99c4
https://github.com/istio/istio/commit/64c99c4e13a728144902a9b14299f1a9f392bbf8
link
https://k8s-gubernator.appspot.com/build/istio-prow/pr-logs/pull/istio_istio/15109/integ-istioctl-local-presubmit-tests-master/740 /test
integ-istioctl-local-presubmit-tests-master
prow/integ-mixer-k8s-presubmit-tests.sh 64c99c4
https://github.com/istio/istio/commit/64c99c4e13a728144902a9b14299f1a9f392bbf8
link
https://k8s-gubernator.appspot.com/build/istio-prow/pr-logs/pull/istio_istio/15109/integ-mixer-k8s-presubmit-tests-master/2015 /test
integ-mixer-k8s-presubmit-tests-master
Instructions for interacting with me using PR comments are available here
https://git.k8s.io/community/contributors/guide/pull-requests.md. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
https://github.com/kubernetes/test-infra/issues/new?title=Prow issue:
repository. I understand the commands that are listed here
https://go.k8s.io/bot-commands.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/15109?email_source=notifications&email_token=AAAUR2RZXA3UE2KORRNIMVTP4ETPDA5CNFSM4H3BT2IKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYOCWQY#issuecomment-505162563,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAUR2VJO2R4BHJUM65VPI3P4ETPDANCNFSM4H3BT2IA
.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: JimmyCYJ
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: mandarjog
If they are not already assigned, you can assign the PR to them by writing /assign @mandarjog in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS
tests/integration/security/OWNERS [JimmyCYJ]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-k8s-k8s-presubmit-tests.sh
64c99c4e13a728144902a9b14299f1a9f392bbf8
link
/test integ-mixer-k8s-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
64c99c4e13a728144902a9b14299f1a9f392bbf8
link
/test integ-security-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
64c99c4e13a728144902a9b14299f1a9f392bbf8
link
/test integ-mixer-k8s-presubmit-tests-master

prow/racetest.sh
0a7cb5858fd195cc05a9f9cdaef5e52341dce823
link
/test istio-racetest-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-k8s-k8s-presubmit-tests.sh
64c99c4e13a728144902a9b14299f1a9f392bbf8
link
/test integ-mixer-k8s-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
64c99c4e13a728144902a9b14299f1a9f392bbf8
link
/test integ-security-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
64c99c4e13a728144902a9b14299f1a9f392bbf8
link
/test integ-mixer-k8s-presubmit-tests-master

prow/racetest.sh
0a7cb5858fd195cc05a9f9cdaef5e52341dce823
link
/test istio-racetest-master

prow/istio-lint.sh
0a7cb5858fd195cc05a9f9cdaef5e52341dce823
link
/test istio-lint-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/racetest.sh
0a7cb5858fd195cc05a9f9cdaef5e52341dce823
link
/test istio-racetest-master

prow/istio-lint.sh
26d09dbcd1c9084ea573fda53741c21445878654
link
/test istio-lint-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-lint-master

Please make the change in new installer as well ( or first) and it is sufficiently tested.

I add an integration test to verify that file mounted key/certificate used when global.sds.enabled is false but global.sds.udsPath and global.sds.useNormalJwt are set.
I will create a separate PR to make configmap change in istio/installer.

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/racetest.sh
0a7cb5858fd195cc05a9f9cdaef5e52341dce823
link
/test istio-racetest-master

prow/integ-framework-k8s-presubmit-tests.sh
26d09dbcd1c9084ea573fda53741c21445878654
link
/test integ-framework-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/racetest.sh
0a7cb5858fd195cc05a9f9cdaef5e52341dce823
link
/test istio-racetest-master

prow/integ-framework-k8s-presubmit-tests.sh
26d09dbcd1c9084ea573fda53741c21445878654
link
/test integ-framework-k8s-presubmit-tests-master

prow/e2e-bookInfoTests-trustdomain.sh
26d09dbcd1c9084ea573fda53741c21445878654
link
/test e2e-bookInfoTests-trustdomain-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-framework-k8s-presubmit-tests.sh
26d09dbcd1c9084ea573fda53741c21445878654
link
/test integ-framework-k8s-presubmit-tests-master

prow/e2e-bookInfoTests-trustdomain.sh
26d09dbcd1c9084ea573fda53741c21445878654
link
/test e2e-bookInfoTests-trustdomain-master

prow/racetest.sh
26d09dbcd1c9084ea573fda53741c21445878654
link
/test istio-racetest-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-framework-k8s-presubmit-tests-master

@costinm Please take a look. Thanks!

The plans for 1.3 sds are based on new installer, I think we can close this
unless there is a user reported p0 that rel managers for 1.2 consider.
However - in 1.2 we only support fresh install, not change in this setting,
so I don't see how it can meet the bar for 1.2
On Tue, Jun 25, 2019, 13:25 Jimmy Chen<EMAIL_ADDRESS>wrote:

@costinm https://github.com/costinm Please take a look. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/15109?email_source=notifications&email_token=AAAUR2T4QRZ6CJPHCIBTULTP4J5MJA5CNFSM4H3BT2IKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYRPTTY#issuecomment-505608655,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAUR2UHP6245XDDRQ7EXQDP4J5MJANCNFSM4H3BT2IA
.

@fpesce This change is proposed by customer in https://github.com/istio/istio/pull/13605, but it became stale and was closed.

/test e2e-bookInfoTests-trustdomain-master
/test istio-racetest-master

The plans for 1.3 sds are based on new installer, I think we can close this unless there is a user reported p0 that rel managers for 1.2 consider. However - in 1.2 we only support fresh install, not change in this setting, so I don't see how it can meet the bar for 1.2

Before making the merge, let's just ping the initial author, @castlemilk
@castlemilk : Is this use-case / PR important for you, are you running/moving to istio 1.2?

We will be moving to 1.2 shortly, this PR would still be helpful to avoid hitting unexpected issues in fresh Istio deployments.

/lgtm

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: fpesce, JimmyCYJ
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: mandarjog
If they are not already assigned, you can assign the PR to them by writing /assign @mandarjog in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS
tests/integration/security/OWNERS [JimmyCYJ]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

would you mind giving me an owner's approval @costinm ?
The user's case is justified IMO. It is made clear this will be addressed by the new installer on 1.3
I can be assigned a task of cleaning up the no-more-needed-install-features for the next release if you want.

/assign @costinm

Also I want to make sure any release notes and doc make clear that SDS is alpha feature and we do not support user turning it on over an existing install - only fresh install of SDS.

If this is to be ported to 1.2 - I can approve, but let's make sure we're not creating more problems.

This is going in 1.2 (c.f. the label + milestone).

@costinm the test has the customsetup label, so if we use the skipsetup mode it will be skipped.

Ok, if we have to spend time on this - did more review and asked for some comments on the tests, I don't think I understand for the code what is getting tested.
This appears to break/change the behavior - in the past it was possible to use SPIRE or other SDS agent, no it seems that settings for the SDS path are tied with enabling citadel node agent. I'm not sure this is right, we do want Istio to work with other implementations of SDS.
Please include a link to the PR fixing this on the new installer - since the goal of new installer is to be 'a-la-carte', it is even more important to not make things too coupled and out of sync.
Is there any user reporting this problem ? I'm curious why they got the impression that we support this and how they got into problems, since SDS is an alpha feature and the docs are supposed to make it clear we don't support upgrade, just fresh install.

Ignore my previous comment on other sds implementation - it seems there are 2 'enabled' flags, sds.enabled and the badly named nodeagent.enabled (since CNI and many other stateful sets are node agents). So we can still enable sds with other SDS agents.

New changes are detected. LGTM label has been removed.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: fpesce, JimmyCYJ
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm
If they are not already assigned, you can assign the PR to them by writing /assign @costinm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS
tests/integration/security/OWNERS [JimmyCYJ]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Ignore my previous comment on other sds implementation - it seems there are 2 'enabled' flags, sds.enabled and the badly named nodeagent.enabled (since CNI and many other stateful sets are node agents). So we can still enable sds with other SDS agents.

The test has set both flags to false sds.enabled and nodeagent.enabled. If there are other SDS agents, there should be a way to enable/disable, and we can disable them in the test as well.
One more thing I can do is to verify the Envoy stats, server_ssl_socket_factory.ssl_context_update_by_sds it should be 0 if file mount approach is used.
But that stats is disabled several months ago. I just found that it was disabled and opened an issue at https://github.com/istio/istio/issues/14773. Once I add those stats back, I can verify the stats in the test.

@JimmyCYJ: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/shellcheck.sh
bed29faad1a8bf6c068d9fed3df74bda509e7864
link
/test istio-shellcheck-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/shellcheck.sh
bed29faad1a8bf6c068d9fed3df74bda509e7864
link
/test istio-shellcheck-master

prow/integ-mixer-k8s-presubmit-tests.sh
bed29faad1a8bf6c068d9fed3df74bda509e7864
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/shellcheck.sh
bed29faad1a8bf6c068d9fed3df74bda509e7864
link
/test istio-shellcheck-master

prow/integ-mixer-k8s-presubmit-tests.sh
bed29faad1a8bf6c068d9fed3df74bda509e7864
link
/test integ-mixer-k8s-presubmit-tests-master

prow/e2e-bookInfoTests-trustdomain.sh
bed29faad1a8bf6c068d9fed3df74bda509e7864
link
/test e2e-bookInfoTests-trustdomain-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/shellcheck.sh
bed29faad1a8bf6c068d9fed3df74bda509e7864
link
/test istio-shellcheck-master

prow/integ-mixer-k8s-presubmit-tests.sh
bed29faad1a8bf6c068d9fed3df74bda509e7864
link
/test integ-mixer-k8s-presubmit-tests-master

prow/e2e-bookInfoTests-trustdomain.sh
bed29faad1a8bf6c068d9fed3df74bda509e7864
link
/test e2e-bookInfoTests-trustdomain-master

prow/integ-istioctl-local-presubmit-tests.sh
bed29faad1a8bf6c068d9fed3df74bda509e7864
link
/test integ-istioctl-local-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/shellcheck.sh
bed29faad1a8bf6c068d9fed3df74bda509e7864
link
/test istio-shellcheck-master

prow/integ-mixer-k8s-presubmit-tests.sh
bed29faad1a8bf6c068d9fed3df74bda509e7864
link
/test integ-mixer-k8s-presubmit-tests-master

prow/e2e-bookInfoTests-trustdomain.sh
bed29faad1a8bf6c068d9fed3df74bda509e7864
link
/test e2e-bookInfoTests-trustdomain-master

prow/integ-istioctl-local-presubmit-tests.sh
bed29faad1a8bf6c068d9fed3df74bda509e7864
link
/test integ-istioctl-local-presubmit-tests-master

prow/e2e-mixer-no_auth.sh
bed29faad1a8bf6c068d9fed3df74bda509e7864
link
/test e2e-mixer-no_auth-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/shellcheck.sh
bed29faad1a8bf6c068d9fed3df74bda509e7864
link
/test istio-shellcheck-master

prow/integ-mixer-k8s-presubmit-tests.sh
bed29faad1a8bf6c068d9fed3df74bda509e7864
link
/test integ-mixer-k8s-presubmit-tests-master

prow/e2e-bookInfoTests-trustdomain.sh
bed29faad1a8bf6c068d9fed3df74bda509e7864
link
/test e2e-bookInfoTests-trustdomain-master

prow/integ-istioctl-local-presubmit-tests.sh
bed29faad1a8bf6c068d9fed3df74bda509e7864
link
/test integ-istioctl-local-presubmit-tests-master

prow/e2e-mixer-no_auth.sh
bed29faad1a8bf6c068d9fed3df74bda509e7864
link
/test e2e-mixer-no_auth-master

prow/integ-telemetry-k8s-presubmit-tests.sh
bed29faad1a8bf6c068d9fed3df74bda509e7864
link
/test integ-telemetry-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/shellcheck.sh
bed29faad1a8bf6c068d9fed3df74bda509e7864
link
/test istio-shellcheck-master

prow/integ-mixer-k8s-presubmit-tests.sh
bed29faad1a8bf6c068d9fed3df74bda509e7864
link
/test integ-mixer-k8s-presubmit-tests-master

prow/e2e-bookInfoTests-trustdomain.sh
bed29faad1a8bf6c068d9fed3df74bda509e7864
link
/test e2e-bookInfoTests-trustdomain-master

prow/integ-istioctl-local-presubmit-tests.sh
bed29faad1a8bf6c068d9fed3df74bda509e7864
link
/test integ-istioctl-local-presubmit-tests-master

prow/e2e-mixer-no_auth.sh
bed29faad1a8bf6c068d9fed3df74bda509e7864
link
/test e2e-mixer-no_auth-master

prow/integ-telemetry-k8s-presubmit-tests.sh
bed29faad1a8bf6c068d9fed3df74bda509e7864
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/e2e-bookInfoTests-v1alpha3.sh
bed29faad1a8bf6c068d9fed3df74bda509e7864
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/shellcheck.sh
bed29faad1a8bf6c068d9fed3df74bda509e7864
link
/test istio-shellcheck-master

prow/integ-mixer-k8s-presubmit-tests.sh
bed29faad1a8bf6c068d9fed3df74bda509e7864
link
/test integ-mixer-k8s-presubmit-tests-master

prow/e2e-bookInfoTests-trustdomain.sh
bed29faad1a8bf6c068d9fed3df74bda509e7864
link
/test e2e-bookInfoTests-trustdomain-master

prow/integ-istioctl-local-presubmit-tests.sh
bed29faad1a8bf6c068d9fed3df74bda509e7864
link
/test integ-istioctl-local-presubmit-tests-master

prow/e2e-mixer-no_auth.sh
bed29faad1a8bf6c068d9fed3df74bda509e7864
link
/test e2e-mixer-no_auth-master

prow/integ-telemetry-k8s-presubmit-tests.sh
bed29faad1a8bf6c068d9fed3df74bda509e7864
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/e2e-bookInfoTests-v1alpha3.sh
bed29faad1a8bf6c068d9fed3df74bda509e7864
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
bed29faad1a8bf6c068d9fed3df74bda509e7864
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-k8s-presubmit-tests.sh
bed29faad1a8bf6c068d9fed3df74bda509e7864
link
/test integ-mixer-k8s-presubmit-tests-master

prow/e2e-bookInfoTests-trustdomain.sh
bed29faad1a8bf6c068d9fed3df74bda509e7864
link
/test e2e-bookInfoTests-trustdomain-master

prow/e2e-bookInfoTests-v1alpha3.sh
bed29faad1a8bf6c068d9fed3df74bda509e7864
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
bed29faad1a8bf6c068d9fed3df74bda509e7864
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/integ-pilot-k8s-presubmit-tests.sh
bed29faad1a8bf6c068d9fed3df74bda509e7864
link
/test integ-pilot-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-pilot-k8s-presubmit-tests.sh
bed29faad1a8bf6c068d9fed3df74bda509e7864
link
/test integ-pilot-k8s-presubmit-tests-master

prow/e2e-dashboard.sh
4b9ce88fa900c46f4b49248123eb325c2c936630
link
/test e2e-dashboard-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-pilot-k8s-presubmit-tests.sh
bed29faad1a8bf6c068d9fed3df74bda509e7864
link
/test integ-pilot-k8s-presubmit-tests-master

prow/e2e-dashboard.sh
4b9ce88fa900c46f4b49248123eb325c2c936630
link
/test e2e-dashboard-master

prow/e2e-mixer-no_auth.sh
4b9ce88fa900c46f4b49248123eb325c2c936630
link
/test e2e-mixer-no_auth-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sorry for all the push back, but we are actively working to simplify SDS setup and this PR is not going
in the same direction.
For reference:
https://github.com/istio/istio/issues/15168
https://docs.google.com/document/d/13bEpAeSKV8ADMK37ANkQV4FXli5bTQGAqZvhV50yn0M/edit#
If @fpesece  really needs this in 1.2 or real users have reported this issue - and he is committed to clean this up after it is merged in 1.2 ( or just merge it to 1.2 and not add to master just to remove it after ) - I'm not holding it - but can't approve it either, if any other approver believes it's worth it - no problem with me.

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
4b9ce88fa900c46f4b49248123eb325c2c936630
link
/test e2e-dashboard-master

prow/e2e-mixer-no_auth.sh
4b9ce88fa900c46f4b49248123eb325c2c936630
link
/test e2e-mixer-no_auth-master

prow/codecov.sh
4b9ce88fa900c46f4b49248123eb325c2c936630
link
/test istio-codecov-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
4b9ce88fa900c46f4b49248123eb325c2c936630
link
/test e2e-dashboard-master

prow/e2e-mixer-no_auth.sh
4b9ce88fa900c46f4b49248123eb325c2c936630
link
/test e2e-mixer-no_auth-master

prow/codecov.sh
4b9ce88fa900c46f4b49248123eb325c2c936630
link
/test istio-codecov-master

prow/e2e_pilotv2_auth_sds.sh
4b9ce88fa900c46f4b49248123eb325c2c936630
link
/test istio_auth_sds_e2e-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
4b9ce88fa900c46f4b49248123eb325c2c936630
link
/test e2e-dashboard-master

prow/e2e-mixer-no_auth.sh
4b9ce88fa900c46f4b49248123eb325c2c936630
link
/test e2e-mixer-no_auth-master

prow/codecov.sh
4b9ce88fa900c46f4b49248123eb325c2c936630
link
/test istio-codecov-master

prow/e2e_pilotv2_auth_sds.sh
4b9ce88fa900c46f4b49248123eb325c2c936630
link
/test istio_auth_sds_e2e-master

prow/integ-mixer-k8s-presubmit-tests.sh
4b9ce88fa900c46f4b49248123eb325c2c936630
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sorry for all the push back, but we are actively working to simplify SDS setup and this PR is not going
in the same direction.
For reference:
#15168
https://docs.google.com/document/d/13bEpAeSKV8ADMK37ANkQV4FXli5bTQGAqZvhV50yn0M/edit#
If @fpesce really needs this in 1.2 or real users have reported this issue - and he is committed to clean this up after it is merged in 1.2 ( or just merge it to 1.2 and not add to master just to remove it after ) - I'm not holding it - but can't approve it either, if any other approver believes it's worth it - no problem with me.

Before everyone gangs up on @costinm here, please understand that he's not trying to block this out of some sort of inappropriate intrusiveness.  He's stating that it conflicts with a project he's actively working on.
So, in order to introduce that conflict into Costin's work, we need a good reason.   So if there is an Istio user that is experiencing an issue in prod or otherwise blocked by this, please call that out.  Otherwise the preference will be to avoid introducing the conflict

Before everyone gangs up on @costinm here, please understand that he's not trying to block this out of some sort of inappropriate intrusiveness. He's stating that it conflicts with a project he's actively working on.
So, in order to introduce that conflict into Costin's work, we need a good reason. So if there is an Istio user that is experiencing an issue in prod or otherwise blocked by this, please call that out. Otherwise the preference will be to avoid introducing the conflict

Thanks @duderino I understand that Costin is working on the new installer which will not use the flag global.sds.enabled in 1.3.
The current issue is filed by customer @castlemilk at https://github.com/istio/istio/issues/13604 a while ago. I also hit this recently when I was modifying security perf tests. @castlemilk created a PR https://github.com/istio/istio/pull/13605 to fix this, which didn't get a chance to be merged. I find that PR useful so I picked up that fix to prevent other customers from hitting the same issue. Given that 1.3 is coming, I am fine with either cherry picking the fix into 1.2 or dropping the fix.

I'll have a PR for 1.3 in few days - it is still using sds.enabled, but the
change is far bigger since it adds SDS for the connection to
Pilot and quite a few other structural changes, including making the
udsPath always setup to the typical value.
I saw the issue - but it doesn't give any reason for setting sdsUdsPath.
How about a 1.2 change to update the docs and make it extra clear that the
config is very alpha and users can't
arbitrarily set values, but have to follow the documented config ?
On Thu, Jun 27, 2019 at 12:43 PM Jimmy Chen<EMAIL_ADDRESS>wrote:

Before everyone gangs up on @costinm https://github.com/costinm here,
please understand that he's not trying to block this out of some sort of
inappropriate intrusiveness. He's stating that it conflicts with a project
he's actively working on.
So, in order to introduce that conflict into Costin's work, we need a good
reason. So if there is an Istio user that is experiencing an issue in prod
or otherwise blocked by this, please call that out. Otherwise the
preference will be to avoid introducing the conflict
Thanks @duderino https://github.com/duderino I understand that Costin
is working on the new installer which will not use the flag
global.sds.enabled in 1.3.
The current issue is filed by customer @castlemilk
https://github.com/castlemilk at #13604
https://github.com/istio/istio/issues/13604 a while ago. I also hit
this recently when I was modifying security perf tests. @castlemilk
https://github.com/castlemilk created a PR #13605
https://github.com/istio/istio/pull/13605 to fix this, which didn't get
a chance to be merged. I find that PR useful so I picked up that fix to
prevent other customers from hitting the same issue. Given that 1.3 is
coming, I am fine with either cherry picking the fix into 1.2 or dropping
the fix.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/15109?email_source=notifications&email_token=AAAUR2UNE5DHHG5HGYH4RBLP4UJ4XA5CNFSM4H3BT2IKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYYFJUY#issuecomment-506483923,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAUR2WP3CXH23CBRHY3YKTP4UJ4XANCNFSM4H3BT2IA
.

Thanks @costinm for the update. I will check our doc for any improvements and close this PR.
Is there any GitHub issue to keep tracking of the SDS installation change? I would like to keep security perf tests and SDS integration tests synced with the installation change.


Add float to binarizer output

(Sorry Karla, you were right)

Codecov Report

Merging #266 into master will decrease coverage by 0.79%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #266      +/-   ##
==========================================
- Coverage   93.49%   92.70%   -0.80%
==========================================
  Files          40       41       +1
  Lines        2123     2290     +167
  Branches      383      424      +41
==========================================
+ Hits         1985     2123     +138
- Misses         73       87      +14
- Partials       65       80      +15

Flag
Coverage Δ

#unittests
92.70% <100.00%> (-0.80%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ngbird/ml/operator_converters/sklearn/binarizer.py
100.00% <100.00%> (ø)

...gbird/ml/operator_converters/onnx/onnx_operator.py
87.50% <0.00%> (-7.96%)
:arrow_down:

...mmingbird/ml/operator_converters/sklearn/linear.py
92.59% <0.00%> (-7.41%)
:arrow_down:

hummingbird/ml/convert.py
86.86% <0.00%> (-2.27%)
:arrow_down:

hummingbird/ml/_parse.py
88.10% <0.00%> (-1.69%)
:arrow_down:

hummingbird/ml/_topology.py
85.86% <0.00%> (-1.64%)
:arrow_down:

hummingbird/ml/_utils.py
82.60% <0.00%> (-1.52%)
:arrow_down:

hummingbird/ml/_container.py
93.43% <0.00%> (-1.49%)
:arrow_down:

...rd/ml/operator_converters/_tree_implementations.py
98.15% <0.00%> (-0.01%)
:arrow_down:

hummingbird/ml/operator_converters/__init__.py
100.00% <0.00%> (ø)

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 905f8f3...085616d. Read the comment docs.

What bug did you hit? Do we need to add another test?

What bug did you hit? Do we need to add another test?

I dunno. I just run it into a pipeline and the successive operator expected float (which actually makes sense).

I dunno. I just run it into a pipeline and the successive operator expected float (which actually makes sense).

Ah ok!  I have been trying very hard to break this as-written with a test...but we are not testing expected output by successive operators, so that makes sense. Maybe we should add that in the pipeline testing!


Cannot update article

When update failed, no errors notification.

https://github.com/baizhiheizi/prsdigg/commit/54b911797506e04898e96aea478d4df0eebaae4e


"Edition mode"

Would be nice to have a mode where:

It only applies edition lints
It does this automatically, but prompts for approximate suggestions
You can optionally ask it to apply idiom lints too

We can hardcode the list of edition lints and idiom lints

It occurs to me that for approximate suggestions we should spit them out after we've fixed everything else, so that if the user makes manual changes it's nbd. We should nail down a workflow here.

I'm going to close as I believe this is mostly resolved by the --edition flag.


Overwrite the jupyter underlying layer, to prevent crashes

What are you trying to achieve?
I'm trying to use the doom-emacs +jupyter layer, and I'm running into some trouble with async output crashing the buffer.
My goal is to stop emacs crashing, and perhaps cleanup that results area so that I can only see the ID reference to data (perhaps), or in other case simply truncate that data and append a "..."
My script looks a bit like this:
#+begin_src jupyter-python :async yes :session py :results none
from json import dumps
from my_async_stuff import get

print(get("Something that returns a really large output"))
#+end_src

#+RESULTS:
....many many lines

The issue is also outlined here:
https://github.com/dzop/emacs-jupyter/issues/237
and here:
https://github.com/dzop/emacs-jupyter/issues/237
What have you tried?
I've tried a couple of solutions of code pasted in these issues, but I fear my understanding of emacs-lisp and overriding functions is not good enough to fully grok the ideas.
Would there be some way to affect this from the doom-emacs package, or are we limited to looking for upstream changes?
I saw there were a few other cases where doom had changed it's handling of a layer to optimise performance and was wondering if this case might be the same?
Additional information
My data result is around 2500 lines.
The buffer completely crashes when that result is displayed.
System information

emacs   version    26.3
        features   NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS MODULES THREADS
        build      Sep 02, 2019
        buildopts  (--with-ns '--enable-locallisppath=/Library/Application Support/Emacs/${version}/site-lisp:/Library/Application Support/Emacs/site-lisp' --with-modules)
        windowsys  ns
        daemonp    server-running
doom    version    2.0.9
        build      HEAD -> develop c601382a5 2020-04-27 02:12:47 -0400
        dir        ~/.doom.d/
system  type       darwin
        config     x86_64-apple-darwin18.2.0
        shell      /bin/zsh
        uname      Darwin 19.3.0 Darwin Kernel Version 19.3.0: Thu Jan  9 20:58:23 PST 2020; root:xnu-6153.81.5~1/RELEASE_X86_64 x86_64
        path       (~/.nvm/versions/node/v14.2.0/bin /usr/local/bin /usr/bin /bin /usr/sbin /sbin /Library/TeX/texbin /Applications/Wireshark.app/Contents/MacOS /Applications/Emacs.app/Contents/MacOS/bin-x86_64-10_14 /Applications/Emacs.app/Contents/MacOS/libexec-x86_64-10_14 /Applications/Emacs.app/Contents/MacOS/libexec/)
config  envfile    envvar-file
        elc-files  0
        modules    (:completion company ivy :ui doom doom-dashboard hl-todo modeline ophints (popup +all +defaults) vc-gutter workspaces :editor file-templates (format +onsave) multiple-cursors rotate-text snippets :emacs dired electric ibuffer vc :checkers syntax :tools (eval +overlay) (lookup +docsets) magit :lang data emacs-lisp javascript markdown (org +dragndrop +jupyter +present) python sh :config (default +bindings +smartparens))
        packages   ((gdscript-mode :recipe (:host github :repo GDQuest/emacs-gdscript-mode)) (restclient) (ob-restclient))
        unpin      (n/a)
        elpa       (string-utils soundcloud request-deferred request org-superstar list-utils glsl-mode gdscript-mode emms deferred)

As a temporary fix I've been able to load my data using pandas, which supports automatic output slice for large size sets:
#+begin_src jupyter-python :session py :async yes
import pandas as pd
data = pd.read_json("my_data.json")
print(data.head(300))
#+end_src

Output:
#+RESULTS:
#+begin_example
    instrument granularity                                            candles
0      BCO_USD          H1  {'volume': 4495, 'time':<PHONE_NUMBER>000, 'mid':...
1      BCO_USD          H1  {'volume': 6235, 'time':<PHONE_NUMBER>000, 'mid':...
2      BCO_USD          H1  {'volume': 6585, 'time':<PHONE_NUMBER>000, 'mid':...
3      BCO_USD          H1  {'volume': 7160, 'time':<PHONE_NUMBER>000, 'mid':...
4      BCO_USD          H1  {'volume': 4179, 'time':<PHONE_NUMBER>000, 'mid':...
..         ...         ...                                                ...
295    BCO_USD          H1  {'volume': 1567, 'time':<PHONE_NUMBER>000, 'mid':...
296    BCO_USD          H1  {'volume': 1826, 'time':<PHONE_NUMBER>000, 'mid':...
297    BCO_USD          H1  {'volume': 1510, 'time':<PHONE_NUMBER>000, 'mid':...
298    BCO_USD          H1  {'volume': 1825, 'time':<PHONE_NUMBER>000, 'mid':...
299    BCO_USD          H1  {'volume': 3223, 'time':<PHONE_NUMBER>000, 'mid':...

[300 rows x 3 columns]
#+end_example

I'm going to close this since it's not directly a emacs-doom issue.
My solution was to try and never work with raw outputs, but only processed output.
An example would be:
Don't display raw info, display pandas packed info
In this way the data manipulation library can take care of the output culling.


[DOCS-1608] Update Calico Enterprise for Windows docs for Operator + HPC installation

Product Version(s):

Issue:

Link to docs preview:

SME review:

[ ] An SME has approved this change.

DOCS review:

[ ] A member of the docs team has approved this change.

Additional information:

Merge checklist:

[ ] Deploy preview inspected wherever changes were made
[ ] Build completed successfully
[ ] Test have passed

LGTM. Minor suggestions.

Thanks @bmckercher123! I did address all your comments (on multiple files when appropriate) in this latest commit, please take a look!


miss file :fontawesome-webfont.ttf

(null): error: /Users/istig/Documents/Downloads/font-awesome-4.5.0/fonts/fontawesome-webfont.ttf: No such file or directory

Thanks for notification.
It's fixed now, please pull to renew.


Remove EidosDocument.geolocs

This information is now stored within some TextBoundMentions which are turned into Location attributes.  The information can be retrieved from there.  However, hiding it and then tracking it down again may not be a good strategy.  It's going to depend on how many things need the information and when.  Right now migration is becoming the most important client and so geolocs aren't going to be removed out from under it.
EidosDocument.times is a similar candidate for removal.

This was addressed with #636, approximately.


uWebsockets.js server much slower if host wasn't passed to listen

Hello dear authors and community. I did some benchmarks last days against uWebsockets server for simple "Hello, World!" example on my MacBook M1 Pro (16GB) using both wrk and bombardier load testing tools. And it may sounds strange, but after dozens of attempts I constantly get much lower throughput when I just use server.lisnen(port, callback) instead of server.listen("<IP_ADDRESS>", port, callback). In terms of magnitude that is ~120K/s without passing host and ~180-200K/s for explicit host parameter passing. I also noticed this effect in Bun (built on top of uWebsockets), that passing hostname explicitly make throughput much higher. Is it something related to MacOS or what? I will be grateful for your explanation. P.S the version of uWebsockets is 20.43.0.

<IP_ADDRESS> is an IPv4 address. So without it you most likely listen over IPv6 which could be slower in your case (for whatever reason)


[Bug] Servly.Persistence.Redis is not on NuGet

🐞 Bug Report
Affected Package(s)
Servly.Persistence.Redis
Is this a regression?
No
Description
The package is not pushed to NuGet rendering the idempotency package unusable.
🔬 Minimal Reproduction Steps
Try to install any package dependent on Servly.Persistence.Redis
🔥 Exception or Error Message

N/A
🌍 Your Environment
Servly Version

v0.1.0
.NET  Version:

.NET 6
Anything else relevant?

This has been resolved, and will be on NuGet with the next tagged release.


add support for KERNEL_VERSION replacement for signing

filesToSign (the filepaths of the kmods to sign) and unsignedImage (the name of the image that contains the kmods if its not built in cluster) both normally would contain the kernel version, this commit allows the embedding of "$(KERNEL_VERSION)" in them and have it replaced with the actual kernel version

/lgtm
/assign @yevgeny-shnaidman

/test ?

/lgtm

/approve

/approve


Cmake: Improved setconfig support for setting multiple parameters

Summary
Improved setconfig support for setting multiple parameters for the .config
Added Cmake and Ninja version info
Added utility target to check .config from board's defconfig for refresh stage on GITHUB
Impact
Impact on user: No changes to user-facing functionality
Impact on build: Build process remains the same
Testing
We tested on the local platform MSYS2 and GitHub

[Experimental Bot, please feedback here]
The PR partially meets the NuttX requirements. Here's a breakdown:
Strengths:

Summary: Provides a decent overview of the changes.
Testing:  Includes testing information (platform and evidence with screenshots).

Areas for Improvement:

Impact:  The impact section needs to be more thorough.

Impact on hardware: Does this affect any specific architectures or boards? Be specific.
Impact on documentation:  If no documentation updates are needed, state that explicitly.  If updates are needed, provide them in the PR or a linked PR.
Impact on security, compatibility:  Even if the answer is NO, you must explicitly state it for each item.  Don't leave any blanks.

Testing:

Logs: The screenshots provide visual confirmation but lack context. Include relevant snippets of build logs or test output to demonstrate the changes' effects.
Target(s): Specify the exact target architectures and boards tested.  "Local platform MSYS2" is not specific enough for a NuttX target.
Before/After: The description mentions testing on MSYS2 and GitHub, but it's unclear what was tested on each.  Provide distinct "before" and "after" logs for each testing environment (local and GitHub).

Recommendation:
Revise the PR to address the missing information, particularly in the "Impact" and "Testing" sections. Provide specific details about the testing environments, include relevant log snippets, and address all impact points explicitly.


chore: migrate mergify behavior to actions

Replaces mergify functionality that cannot be replicated by Github settings with actions.

Semantic PR failure comment
Core contributor label

@NGL321 This looks good in general.
The problem is that since enabling auto-merge on a PR is a manual action, it means our automatic dependency upgrade PR's won't get automatically merged.
I think this problem needs to be addressed before we can disable mergify and move over. Perhaps using GraphQL github API's to enable auto-merge on those PR's as part of their approval.

https://github.community/t/enabling-auto-merge-on-a-pr-using-the-api/150797/5


Transform functions into RPC services

Implements transforming scanner.Func into protobuf.RPC. One single service is emitted per package and all methods and functions are put there.
NOTE: is missing some full integration tests for the same reason the resolver is missing them: we need the scanner implementation of scanning functions and methods first. But the core logic is already tested thoroughly.
Caveats

There is no way to set per service options right now (because there is no declared service per se. I don't know if we need them for anything, though.

Current coverage is 94.21% (diff: 94.73%)

Merging #21 into services will increase coverage by 0.04%

@@           services        #21   diff @@
==========================================
  Files            10         10
  Lines           635        709    +74
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            598        668    +70
- Misses           25         28     +3
- Partials         12         13     +1

Powered by Codecov. Last update 5ddc245...264a29d

@Serabe @dpordomingo can be fully reviewed again.


added writemode

completed the opWriteArea() in s7_micro_client.php
I also added a s7_phphelper.php as a external class. I know it goes around the snap7 library, if you don't like it please ignore this commit and I'll keep it for myself ;)

Thank you very much for your work!
I have no hardware and time to develop at the moment, so your work is highly appreciated. 👍


MailChimp API v3 migration

Not only are we moving from v2 to v3, we're also changing some behaviors:

Emails are validated through us, and we only put email on MailChimp when
they are validated.
When an email is validated, it is updated on MailChimp
Email validation unsetting happens in the user handler instead of middleware,
so that it only happens on successful user changes
Stripe emails are updated more consistently as well
First and last names are sent to MailChimp
Combined the two User post-init middleware functions
The webhook is tested, handles email changes, and checks if email is validated.

Coverage increased (+0.3%) to 55.927% when pulling 55f3e2c2ae061e0a99c25888705c02c2ea77762e on mailchimp-tweaks into cc111576e65cbf72f0bc7cb9a5ec7d0818553b76 on master.

Coverage increased (+0.3%) to 55.94% when pulling 55f3e2c2ae061e0a99c25888705c02c2ea77762e on mailchimp-tweaks into cc111576e65cbf72f0bc7cb9a5ec7d0818553b76 on master.

Coverage increased (+0.3%) to 55.967% when pulling a08e2aa7e2ce5682a89469bdfc32bada98d87823 on mailchimp-tweaks into 342db640d0e6a52739a30a1b0d2b2e1351732876 on master.

Coverage increased (+0.3%) to 55.96% when pulling a08e2aa7e2ce5682a89469bdfc32bada98d87823 on mailchimp-tweaks into 342db640d0e6a52739a30a1b0d2b2e1351732876 on master.

Coverage increased (+0.3%) to 56.013% when pulling 43a90234fd477e4296b62dbe7084e8add3d771de on mailchimp-tweaks into 90403ff5b2ffa7d15b93b549e0faee12a6d31649 on master.

Coverage increased (+0.3%) to 56.007% when pulling 43a90234fd477e4296b62dbe7084e8add3d771de on mailchimp-tweaks into 90403ff5b2ffa7d15b93b549e0faee12a6d31649 on master.


Users have a screen-name

Add column to Users table
User can update from user-account page
Screen-name visible on navbar

Added username colunm to database. Can see username in home screen.


Playing through Mopidy

Clear and concise description of the problem
I'm running a media server using Mopidy. Is it possible to stream the local files through a Mopidy-linked speaker?
Suggested solution
If there are http/https endpoints for this, this should be possible to route it to Mopidy: https://docs.mopidy.com/en/latest/ext/stream/
Eg for a radio station mpc add https://live.leanstream.co/CKNXFM && mpc play
Alternative
No response
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Thanks for the issue. I have the plan to build a client that connects to PodFetch via a websocket and then carries out the play/pause requests. This of course will take some time to implement.


Captions not loaded in Firefox when setting tracks with .source setter

Expected behaviour
Setting caption tracks in the player .source in JavaScript code should work like setting <track> tags in HTML.
Actual behaviour
This works fine with the latest Chrome and Safari but not Firefox.
Looking at the network requests shows Firefox never actually loads the caption file in the first place.
Steps to reproduce
See example at https://codesandbox.io/s/magical-knuth-e6qhq
Environment

Browser: Firefox
Version: 67.0
Operating System: macOS
Version: 10.14.5

Console errors (if any)
No errors but enabling debug: true shows it's setting a TextTrack with no cues in Firefox:
Track added
  > TextTrack { kind: "captions",
    > cues: TextTrackCueList { length: 0 }

while in Chrome it does have some cues
cues: TextTrackCueList {0: VTTCue, 1: VTTCue, 2: VTTCue, 3: VTTCue, 4: VTTCue, 5: VTTCue, 6: VTTCue, length: 7}

Link to where the bug is happening
https://e6qhq.codesandbox.io/

Can also attest to this issue:
Track added  TextTrack  activeCues: TextTrackCueList { length: 0 }  cues: TextTrackCueList { length: 0 }  id: ""  inBandMetadataTrackDispatchType: ""  kind: "captions"  label: ""  language: ""  mode: "hidden"  oncuechange: null  <prototype>: TextTrackPrototype { addCue: addCue(), removeCue: removeCue(), kind: Getter, … } plyr.js:2641:33
Also occurs in IE and Edge. This is a pretty massive bug that breaks the most essential accessibility a video player can provide.

I seem to be experiencing this issue as well on Chrome.
I've tried to debug to the best of my abilities but I'm not sure what's wrong. All I can say, seems like first time I assign tracks and video it works. Then if I assign new video and new tracks, those tracks will not be downloaded and won't be shown :(

Similar issue #1959


Preloaded contexts not used by json-ld gem in develop branch

I have tried to investigate which change could have led to this, but nothing obvious stands out to me. I can confirm that json-ld 3.0.2 and json-ld-preloaded 3.0.2 were using preloaded contexts, not executing any HTTP requests for them (specifically: https://w3id.org/identity/v1).
However, commit e742697a0906e74e8bb777ef98137bc3955d981d of json-ld and json-ld-preloaded 3.0.4 are executing a HTTP request for the very same context URL. I have manually checked and JSON::LD::Context::PRELOADED contains https://w3id.org/identity/v1 in both cases.

Update: It seems like this affects only https://w3id.org/identity/v1... Trying https://w3id.org/security/v1 does not execute HTTP requests...

The point of json-ld-preloaded is to avoid http requests to common contexts by preloading them. Periodically, contexts are changed, and these need to be rebuilt.
To be used, you specifically need to add the gem to either your Gemfile, or dependencies in your gemspec. The JSON-LD gem tries to load it, and it will insert the cache if it’s there, otherwise, it will go on and do loads.

I’m sorry but I don’t think you understood the problem description. I know how to use the gem and it works for all common contexts except the identity one.
What i have found is that the json-ld gem canonicalizes context URIs before checking the ‘PRELOADED’ constant, which means it checks if the http version is defined (not https). However this gem defines the https version for specifically the identity context (all other contexts are defined against http and creating a preload alias for https), which means it can never be found. I submitted a fix.

Okay, sorry. I left a comment in the PR. The change goes in Rakefile, and re-run the gen_contexts task.

Fixed in https://github.com/ruby-rdf/json-ld-preloaded/commit/2adb1dfd898415a79f964e737342bfaf604e80d1.


Slight adjustment to the return value of Update Control Maps API.

You're not meant to update the map before this time, you're meant to
update after it has elapsed (this is why it is half the expiry time).
Signed-off-by: Kristian Amlie<EMAIL_ADDRESS>

Merged this into 3.0.x as well (there were no other changes in master since the branching).


bump supported ruby versions

Pull Request Test Coverage Report for Build 183

0 of 0   changed or added relevant lines in 0 files are covered.
12 unchanged lines in 6 files lost coverage.
Overall coverage remained the same at 92.363%

Files with Coverage Reduction
New Missed Lines
%

test/dummy/config/initializers/migration_class.rb
1
75.0%

test/test_password_expired_controller.rb
1
100.0%

lib/devise-security/controllers/helpers.rb
1
50.94%

lib/devise-security/rails.rb
2
100.0%

test/test_security_question_controller.rb
3
100.0%

test/dummy/config/environments/test.rb
4
100.0%

Totals

Change from base Build 182:
0.0%

Covered Lines:
895

Relevant Lines:
969

💛  - Coveralls

Pull Request Test Coverage Report for Build 183

0 of 0   changed or added relevant lines in 0 files are covered.
12 unchanged lines in 6 files lost coverage.
Overall coverage remained the same at 92.363%

Files with Coverage Reduction
New Missed Lines
%

test/dummy/config/initializers/migration_class.rb
1
75.0%

test/test_password_expired_controller.rb
1
100.0%

lib/devise-security/controllers/helpers.rb
1
50.94%

lib/devise-security/rails.rb
2
100.0%

test/test_security_question_controller.rb
3
100.0%

test/dummy/config/environments/test.rb
4
100.0%

Totals

Change from base Build 182:
0.0%

Covered Lines:
895

Relevant Lines:
969

💛  - Coveralls


feat(blob): add blob service

Overview
Implemented blob service and covered it with UTs
Checklist

[x] New and updated code has appropriate documentation
[x] New and updated code has new and/or updated testing
[x] Required CI checks are passing
[x] Visual proof for any user facing features like CLI or documentation updates
[x] Linked issues closed with keywords

Codecov Report

:exclamation: No coverage uploaded for pull request base (feature_branch_blob_module@0387e6f). Click here to learn what that means.
The diff coverage is n/a.

@@                      Coverage Diff                      @@
##             feature_branch_blob_module    #2052   +/-   ##
=============================================================
  Coverage                              ?   53.84%
=============================================================
  Files                                 ?      219
  Lines                                 ?    14283
  Branches                              ?        0
=============================================================
  Hits                                  ?     7690
  Misses                                ?     5768
  Partials                              ?      825

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@distractedm1nd, reworked all tests besides tests with padding because it requires extra logic and cannot be combined.

Hmm okay so blob contains NID - I think the cleanest way is to sort by order of nIDs given then

I think it's fine to keep it without a strict order. We do not commit to return blobs in a particular order


feat(core/MedplumClient): add support for Binary/{id} urls in download

This PR adds support for Binary/{id} url downloads as mentioned in #1216.
It also adds tests for a new util method MedplumClient.normalizeFetchUrl() as well as tests to make sure the expected urls reach MedplumClient.fetch() from MedplumClient.download().
I didn't add an explicit check for valid IDs since I wasn't sure in which part of the architecture such validations are done.
Please let me know if I there is anything obvious I missed here.
Thank you! 😄

coverage: 94.359% (+0.03%) from 94.329% when pulling 3b9a116eaa71cc3f29115770df075fb3a0f7323d on ThatOneBro:derrick/feat/core/add-binary-support into 7d31f8c5aa016367329e6f5493d9b07004e13b40 on medplum:main.


fix def SO:0001877 lncRNA

What is the SO term name and accession?
SO:0001877 lncRNA
non-coding RNA generally longer than 200 nucleotides that cannot be classified as any other ncRNA subtype.
Describe what you would like to change.
Please remove the word "generally".
In  contrast sncRNA is defined
A non-coding RNA less than 200 nucleotides in length.
This means that logically an lncRNA can never  less than 200  (or it would be a snc) and the word generally is just making the definition imprecise.
@sjm41  FYI

I am not seeing that conclusion in the ticket?
I am not a fan of the arbitrary snc /lnc size distinction, but:

the snc/lncRNA distinction does seem to be adopted by the ncRNA community.
This solution is problematic in that it leaves the issue that  there are small non-coding RNAs that do not fit sn/snoRNA which it would seem very strange to call these "lncRNAs"
Including the word 'generally' in a term seems problematic because the definition is not precise. It would be better to exclude any size qualifier and just say
"a non-coding RNA that cannot be classified as any other ncRNA subtype" because in this scenario the information about size becomes irrelevant. Or to add this after the differentia as a comment to explain clearly that lncRNAs include ncRNAs under 200 nt that cannot be classified as a type of sncRNA (but that sounds a bit bonkers)

Anyway, the community classification is not good, but the solution here isn't great because putative sn and and RNAs will be classified as lncRNAs.

(original ticket to improve lncRNA definition is #575.)
@blakesweeney just alerted me to this new 'consensus statement' paper that tries to define and classify lncRNAs better: https://www.nature.com/articles/s41580-022-00566-8
Relevant passages:
lncRNAs have the unfortunate distinction of being named for what they are not, rather than what they are.
lncRNAs have been arbitrarily defined as non-coding transcripts of more than 200 nucleotides (200 nt), which is a convenient size cut-off in biochemical and biophysical RNA purification protocols that deplete most infrastructural RNAs, such as 5S rRNAs, tRNAs, snRNAs and snoRNAs, as well as miRNAs, siRNAs and piRNAs. This definition also excludes some other well-known short RNAs such as the primate-specific snaRs (~80–120 nt), which associate with nuclear factor 90; Y RNAs (~100 nt), which act as scaffolds for ribonucleoprotein (RNP) complexes; vault RNAs (88–140 nt), which are involved in transferring extracellular stimuli into intracellular signals; and promoter-associated RNAs and non-canonical small RNAs produced by post-transcriptional processing. Other non-coding RNAs lie close to the 200-nt border, such as 7SK (~330 nt in vertebrates), which controls transcription poising and termination, including at enhancers, and 7SL (~300 nt), which is an integral component of the signal recognition particle that targets proteins to cell membranes and the evolutionary ancestor of the widespread primate Alu (~280 nt) and rodent B1 (~135 nt) small interspersed nuclear elements.
Given this grey zone of sizes, we support the suggestion that non-coding RNAs be divided into three categories:
(1) small RNAs (less than 50 nt);
(2) RNA polymerase III (Pol III) transcripts (such as tRNAs, 5S rRNA, 7SK, 7SL, and Alu, vault and Y RNAs), Pol V transcripts in plants and small Pol II transcripts such as (most) snRNAs and intron-derived snoRNAs;
(3) lncRNAs (more than 500 nt), which are mostly generated by Pol II.
In the absence of more specific categorization, we recommend retention of the general descriptor ‘lncRNA’ for non-coding RNAs greater than 500 nt in length.
I'm not sure yet if some/all of these proposals would work well within the SO....

It also has the potential to muddy the waters by bringing in  two more arbitrary size classifiers.  Why 500? Why 50? What about those in between?
Fission yeast researchers routinely use 200 nt cut-off for lncRNA.
I'm all for better classification, but I don't think we should jump to this one.
Classifying by polymerase might be OK, but aren't some (or all)? 5S RNA  snRNA and snoRNA transcribed by pol II?

Thanks for that reference!
The wording is fuzzy, but I think bin (2) is intended to be defined by size 50-500 nt, including what's listed but also (not clearly said) other small Pol II transcripts in that size range. Try adding a comma: "and small Pol II transcripts ,comma, such as (most) snRNAs and intron-derived snoRNAs." Moving the threshold up to 500 does work to include nearly all of the shortish ncRNAs of well-characterized types, but increases the issue for lncRNA vs not-as-long lncRNA (nalncRNA?), and probably creates some headaches for RNA types that fall in the 40-60 nt range.
Trying to fit this into the SO hierarchy, with 1-50, 50-500, and 501+ nt parent terms, would still be challenging. There would be some benefit to having a parent term for the set of known short ncRNA types one is likely to isolate with a short size fractionation, but some types would need to have multiple size parents which complicates traversing the hierarchy. So I don't know if there's really a benefit.
The term lncRNA is very entrenched in the literature, and there isn't much in the <200-nt range that isn't defined by other terms. I continue to think that dropping sncRNA entirely and allowing the minimum size for lncRNA to be fuzzy comes close to typical usage while de-emphasizing size as the defining characteristic, when lncRNAs are really just a catch-all for "not otherwise defined".


Add Quotes

You're welcome to propose your own funny quotes!
Currently, we're accepting quotes exclusively in English.
Feel free to contribute and add some humor to FunnyQuoteLib!

This issue will stay open

Thanks to: divyakelaskar
for: https://github.com/olarno/funnyQuoteLibrary/pull/24


Privacy-Preserving Borrowing/Lending

Description : Develop privacy-preserving solutions for borrowing and lending protocols on zkSync Era, allowing users to participate without revealing their financial positions or transaction details.
Rationale : Privacy concerns are a major barrier to adoption for some users, especially with DeFi applications. Privacy-preserving borrowing/lending could attract new users and unlock additional use cases.
Additional Context : Explore different privacy-enhancing technologies (e.g., zero-knowledge proofs, homomorphic encryption) and their suitability for this specific application.

to me FHE would have been the besst bet on this Privacy process, but the question is can FHE merge with Zksync so easily
.

to me FHE would have been the besst bet on this Privacy process, but the question is can FHE merge with Zksync so easily .

While directly merging FHE with zkSync Era is currently not feasible, exploring hybrid solutions or targeted integrations for specific use cases holds promise for leveraging the benefits of both technologies.

Not currently on a roadmap.


There is update which works with CubicEoS v0.3.0

VT stability included
MWE
using CubicEoS
using CP_PC_SAFT

c1c5saft = CubicEoS.load(CPPCSAFTMixture; names=("methane", "n-pentane"))
volume = 1e-6
nmol = [0.6, 0.4] * 7000 * volume
RT = CubicEoS.GAS_CONSTANT_SI * 500
vt_stability(c1c5saft, nmol, volume, RT, CubicEoS.VTStabilityIdealIdentityState)

VT split was not tested yet.

vt_split added
new tests added

@vvpisarev


Is the Collections guidelines page out of date?

https://docs.microsoft.com/en-us/dotnet/standard/design-guidelines/guidelines-for-collections?source=docs
... says to prefer to return concrete read-only collections, e.g. ReadOnlyCollection<T> instead of IReadOnlyCollection<T>:

✔ DO use ReadOnlyCollection, a subclass of ReadOnlyCollection, or in rare cases IEnumerable for properties or return values representing read-only collections.

Following Postel's Law:

"be conservative in what you send, be liberal in what you accept"

... the concrete type is more conservative than the interface, but does this trump 'prefer abstractions over concretes'?
Even if it is deemed by concensus that the this rule still holds, maybe a paragraph is required to show that the alternative has been considered.

These guidelines are reprinted from a 2008 book, so unfortunately we can't change what's written. But it might be possible to add a note to the top of the page. @dotnet/docs Thoughts on this?

What are concrete advantages of using IReadOnlyCollection? It's just IEnumerable with Count property attached to it, it does not provide an item indexer like ReadOnlyCollection. So it's not a full replacement for cases where ReadOnlyCollection is used today. Also, ReadOnlyCollection is implicitly convertible to IReadOnlyCollection anyway, so it does not hurt people who want to use abstractions.
Maybe IReadOnlyList would be more suitable modern replacement, but i don't think it's worth changing guidelines at this point. While guidelines are old, changing them could create inconsistency between older and newer APIs. Changing guidelines is good for new substantial language features, such as async/nullable. There it's better to not touch what appears to work good.

I mean, I've already provided a couple of examples where the advice is actively bad? e.g. configuration
Sometimes you'll want IReadOnlyCollection, sometimes IReadOnlyList. In general terms you want interfaces to reveal as little of their implementation details as possible, whilst still being useful for clients. e.g. a HashSet can be an IReadOnlyCollection and that might be a completely acceptable return value.

I mean, I've already provided a couple of examples where the advice is actively bad? e.g. configuration

I'm not enough familiar with that library to understand why it's bad. It seems i can implement IConfiguration interface without any need of IReadOnlyCollection. Its method return IEnumerable, where exactly IReadOnlyCollection could be used?

I mean, I've already provided a couple of examples where the advice is actively bad? e.g. configuration

I'm not enough familiar with that library to understand why it's bad. It seems i can implement IConfiguration interface without any need of IReadOnlyCollection. Its method return IEnumerable, where exactly IReadOnlyCollection could be used?

The implementation of System.Configuration binds config to properties. If the config is a collection, and the field on a class is IEnumerable (or derived), then it picks a collection to use and populates the field.  If it is a concrete read-only collection, then it silently ignores it.

Another interesting point is that there is no mention of immutable collection types (e.g.: ImmutableList<T>) in the Collections Guidelines page.
These types are becoming more and more popular in the .NET community. Some guidelines on their usage could be really helpful.

We're coming up on the two year anniversary of this issue - if the bad advice is still coming up as a top result on search engines, etc., and cannot be edited... wouldn't it be prudent to remove the article and replace it with a simple redirect to something like https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/builtin-types/collections? At the moment, and for the last 2 years+, this bad advice that's indistinguishable from any other documentation has just been left to fester and mislead.

if the bad advice is still coming up as a top result on search engines

I still don't see a valid argument why using ReadOnlyCollection is bad advice. I get that configuration binder does not support it, but this guidelines for public APIs, not for types used for configuration. While some of Framework design guidelines are indeed outdated, this particular page is completely OK.

The text is written in a context where the modern alternatives had yet to be developed. At the time, this was the only way to represent a collection that the receiver could not change. I'd argue that ReadOnlyCollection has now been superseded by many more modern features:

IReadOnlyCollection (doesn't create a new object, achieves same effect, more flexible implementation, easier to mock)
FrozenList (faster lookups)
ImmutableList (better for subsequent updates, thread-safe, backtracking)

The fact that it's incompatible with other BCL APIs just underlines the point that it's been superseded.
In the context of a public API, I'd argue IReadOnlyCollection is probably the default choice, but the other two have their place. I don't think there's anywhere I'd favour ReadOnlyCollection.

@JulianBirch, @SteveDunn, @nivomi there are perfomance and safety implications which are all in favor of ReadOnlyCollection.
If we return IReadOnlyCollection, nothing prevents us from casting it back. ButReadOnlyCollection is trully unmodifiable as it’s a wrapper.
As for performance, consider this code:
private static void EnumerateCollection(IReadOnlyCollection<string> items)
 // or any other interface like IEnumerable
{
    foreach (var item in items)
    {
    }
}

Congratulations, we got ourselves boxing of enumerator and unnecessary memory allocation because of that. If instead we use concrete type (like ReadOnlyCollection, sic the missing I), we don’t allocate as the enumerator in List, Dictionary and other collections is value typed.
In addition to boxing the enumerator, the MoveNext and Current calls made per element go from being potentially-inlineable non-virtual calls to being interface calls. That interface dispatch immediately subjects us to 2…3× perfomance degradation.
Both of these things we would escape if used ReadOnlyCollection that is recommended in that “omg almost 20 year old” article :-)

IReadOnlyCollection (doesn't create a new object, achieves same effect, more flexible implementation, easier to mock)

No new object, but 20(?) bytes will be allocated each and every time you would try to enumerate + slower performance due to interface dispatch (don’t forget about GC of that allocations). And it doesn’t prevent you from casting back to say List and modify it all you want. So not exactly the “same effect”, would you agree?

FrozenList (faster lookups)

There is no such thing (only FrozenDictionary and FrozenSet). As for frozen collections it’s more for long-live stuff due to creation time. Even with .net 8 frozen* creation improvements, AsReadOnly to create ReadOnlyCollection or ReadOnlyDictionary is O(1) operation (just a wrapper).

ImmutableList (better for subsequent updates)

The current context is for read-only collections. ImmutableList is a bad name as it’s more about persistent collection optimized for copying. As for modifying the collection, it’s very hard to say it’s better for subsequent updates, as adding an element in ImmutableList is O(log n) operation. As is getting item by index from that list (as it has a tree as backing field instead of an array). Whereas both are O(1) in ordinary list. So unless you are copying a list in a loop (which would be O(N²) vs still O(log n)), ImmutableList  is rather specific option for very specific cases.
—
That said ReadOnlyCollection and ReadOnlyDictionary are here for a reason. They truly don’t allow outsiders to change the collection, they don’t allocate in foreach (compared to interface-based alternative like IReadOnlyCollection or IEnumerable), have concrete type that avoids interface dispatch, and are as fast to create in O(1) as they are just a wrapper.
Thus, @gewarren that page in question is absolutely not out-of-date regarding its advice even so many years later :-)


Fix some missed jQuery references

A followup to #2845, since I think some files were modified after that PR.

You're right, thanks @arkon!


ESP-12E (nodeMCU) support?

Hi
Any chance for nodeMCU support please?
Thank you

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/27550150-esp-12e-nodemcu-support?utm_campaign=plugin&utm_content=tracker%2F2014790&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F2014790&utm_medium=issues&utm_source=github).

Try this manual http://clemix.de/www/platformio

Hello
Thank you for prompt answer.
I use Atom with platform on Mac. Does it mean that I can use -board esp01 for nodeMCU?
I’m a bit confused. That what I have tried but got some issues. The same code worked fine via Arduino IDE.
Thank you
Best
Grzegorz

On 20 Oct 2015, at 14:18, Ivan Kravets<EMAIL_ADDRESS>wrote:
Try this manual http://clemix.de/www/platformio http://clemix.de/www/platformio
—
Reply to this email directly or view it on GitHub https://github.com/platformio/platformio/issues/310#issuecomment-149564820.

Hi @grzegorzshub,
Paste here source code which doesn't work with @PlatformIO.
Thanks.

Hi Ivan
I’m trying to recreate the issue and get back to you with more details soon.
Thank you
Best
Grzegorz

On 20 Oct 2015, at 14:30, Ivan Kravets<EMAIL_ADDRESS>wrote:
Hi @grzegorzshub https://github.com/grzegorzshub,
Paste here source code which doesn't work with @PlatformIO https://github.com/PlatformIO.
Thanks.
—
Reply to this email directly or view it on GitHub https://github.com/platformio/platformio/issues/310#issuecomment-149568718.

It looks like it is a Adafruit_NeoPixel library issue.
Code compiles with Atom+platformio without any warnings or errors, neopixel doesn’t work. Neopixel works fine when the same code is compiled with Arduino IDE.
The code:
#include <ESP8266WiFi.h>
#include <Adafruit_NeoPixel.h>
#define neoPin 14  //neopixel on nodeMCU pin D5
#define NUMPIXELS      1  // How many NeoPixels are attached to the Arduino?
Adafruit_NeoPixel pixels = Adafruit_NeoPixel(NUMPIXELS, neoPin, NEO_GRB + NEO_KHZ800);
void setup() {
pixels.begin();
pixels.setPixelColor(0, pixels.Color(255, 0, 0));
pixels.setBrightness(20);
pixels.show();
}
void loop() {
}

On 20 Oct 2015, at 14:30, Ivan Kravets<EMAIL_ADDRESS>wrote:
Hi @grzegorzshub https://github.com/grzegorzshub,
Paste here source code which doesn't work with @PlatformIO https://github.com/PlatformIO.
Thanks.
—
Reply to this email directly or view it on GitHub https://github.com/platformio/platformio/issues/310#issuecomment-149568718.

Hi @grzegorzshub !
I've just added ESP-12E board.
Please update packages via platformio update and install development version of PlatformIO
http://docs.platformio.org/en/latest/installation.html#development-version

Hi
Tested with PlatformIO version 2.4.0.dev0 and board = esp12e and still the same issue with neopixel.
Just noticed that arduino IDE works with nodeMCU ESP12E 80Mz, while platformio —boards 40Mz, does it matter?

On 21 Oct 2015, at 10:56, Valeriy Koval<EMAIL_ADDRESS>wrote:
Hi @grzegorzshub https://github.com/grzegorzshub !
I've just added ESP-12E board.
Please update packages via platformio update and install development version of PlatformIO
http://docs.platformio.org/en/latest/installation.html#development-version http://docs.platformio.org/en/latest/installation.html#development-version
—
Reply to this email directly or view it on GitHub https://github.com/platformio/platformio/issues/310#issuecomment-149842547.

@grzegorzshub you can force MCU speed manually via http://docs.platformio.org/en/latest/projectconf.html#board-f-cpu

neopixel library works fine with board_f_cpu = 80000000L
Thank you!

On 21 Oct 2015, at 21:55, Ivan Kravets<EMAIL_ADDRESS>wrote:
@grzegorzshub https://github.com/grzegorzshub you can force MCU speed manually via http://docs.platformio.org/en/latest/projectconf.html#board-f-cpu http://docs.platformio.org/en/latest/projectconf.html#board-f-cpu
—
Reply to this email directly or view it on GitHub https://github.com/platformio/platformio/issues/310#issuecomment-150021535.


[Publisher] API product in "Created" lifeCycle is displayed as published API in store

API product created in the publisher is not in published status but in created status

However it is displaed in the API Store

Fixed in https://github.com/wso2/carbon-apimgt/pull/7262


Doing a filter on an empty array throws an error

To recreate issue:
let userIds = [Int]()
return try User.query(on: req).filter(\User.id !~ userIds).all()

Here a filter is one on an empty array.
This throws the following error:
[ ERROR ] PostgreSQLDiagnosticResponse.coerce_to_boolean: ERROR: argument of WHERE must be type boolean, not type integer (Logger+LogError.swift:17)
[ DEBUG ] Possible causes for PostgreSQLDiagnosticResponse.coerce_to_boolean: argument of WHERE must be type boolean, not type integer (Logger+LogError.swift:23)

This issue belongs on vapor/fluent-postgresql since it deals with Fluent.


[release-1.23] Automated branching step 1

@thedebugger: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
25eae3b69f45089398047b4e52e2102f243d673a
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@thedebugger: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
25eae3b69f45089398047b4e52e2102f243d673a
link
true
/test release-notes

release-test_istio
25eae3b69f45089398047b4e52e2102f243d673a
link
true
/test release-test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@thedebugger: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
25eae3b69f45089398047b4e52e2102f243d673a
link
true
/test release-notes

release-test_istio
25eae3b69f45089398047b4e52e2102f243d673a
link
true
/test release-test

integ-cni_istio
25eae3b69f45089398047b4e52e2102f243d673a
link
true
/test integ-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@thedebugger: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
25eae3b69f45089398047b4e52e2102f243d673a
link
true
/test release-notes

release-test_istio
25eae3b69f45089398047b4e52e2102f243d673a
link
true
/test release-test

integ-cni_istio
25eae3b69f45089398047b4e52e2102f243d673a
link
true
/test integ-cni

integ-pilot-istiodremote_istio
25eae3b69f45089398047b4e52e2102f243d673a
link
true
/test integ-pilot-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@thedebugger: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
25eae3b69f45089398047b4e52e2102f243d673a
link
true
/test release-notes

release-test_istio
25eae3b69f45089398047b4e52e2102f243d673a
link
true
/test release-test

integ-cni_istio
25eae3b69f45089398047b4e52e2102f243d673a
link
true
/test integ-cni

integ-pilot-istiodremote_istio
25eae3b69f45089398047b4e52e2102f243d673a
link
true
/test integ-pilot-istiodremote

integ-pilot-istiodremote-mc_istio
25eae3b69f45089398047b4e52e2102f243d673a
link
true
/test integ-pilot-istiodremote-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@thedebugger: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
25eae3b69f45089398047b4e52e2102f243d673a
link
true
/test release-notes

release-test_istio
25eae3b69f45089398047b4e52e2102f243d673a
link
true
/test release-test

integ-cni_istio
25eae3b69f45089398047b4e52e2102f243d673a
link
true
/test integ-cni

integ-pilot-istiodremote_istio
25eae3b69f45089398047b4e52e2102f243d673a
link
true
/test integ-pilot-istiodremote

integ-pilot-istiodremote-mc_istio
25eae3b69f45089398047b4e52e2102f243d673a
link
true
/test integ-pilot-istiodremote-mc

integ-pilot_istio
25eae3b69f45089398047b4e52e2102f243d673a
link
true
/test integ-pilot

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@thedebugger: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
25eae3b69f45089398047b4e52e2102f243d673a
link
true
/test release-notes

release-test_istio
25eae3b69f45089398047b4e52e2102f243d673a
link
true
/test release-test

integ-cni_istio
25eae3b69f45089398047b4e52e2102f243d673a
link
true
/test integ-cni

integ-pilot-istiodremote_istio
25eae3b69f45089398047b4e52e2102f243d673a
link
true
/test integ-pilot-istiodremote

integ-pilot-istiodremote-mc_istio
25eae3b69f45089398047b4e52e2102f243d673a
link
true
/test integ-pilot-istiodremote-mc

integ-pilot_istio
25eae3b69f45089398047b4e52e2102f243d673a
link
true
/test integ-pilot

integ-pilot-multicluster_istio
25eae3b69f45089398047b4e52e2102f243d673a
link
true
/test integ-pilot-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Going to re-open after this is merged https://github.com/istio/istio/pull/52079#pullrequestreview-2178804199


HTAN SD: WUSTL biospecimen re-submission not stored as new csv version

https://sagebionetworks.jira.com/browse/FDS-38
cc: @milen-sage  for prioritization into a sprint.

Access issue identified via https://sagebionetworks.jira.com/browse/HTAN-150?focusedCommentId=166101
No pending action item for the FAIR Data team. Closing.


Overlapping Intervals(using python or cpp only)

Given a collection of Intervals, the task is to merge all of the overlapping Intervals.
Example 1:
Input:
Intervals = {{1,3},{2,4},{6,8},{9,10}}
Output: {{1, 4}, {6, 8}, {9, 10}}
Explanation: Given intervals: [1,3],[2,4] ,[6,8],[9,10], we have only two overlapping intervals here,[1,3] and [2,4]. Therefore
we will merge these two and return [1,4],[6,8], [9,10].
Example 2:
Input:
Intervals = {{6,8},{1,9},{2,4},{4,7}}
Output: {{1, 9}}

You can assign this to me

hi you can assign this to me i can implement it using c++


[backport] Add maintainers in setup.py

Backport of #5756 by @kmaehashi

[automatic post] Jenkins, test this please.

Jenkins CI test (for commit 31a22fa9359851b2acd94a656653b102081b5ae0, target branch v9) succeeded!


doc: document changes in behavior of gofmt in 1.11

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
go version go1.11beta1 linux/amd64
Does this issue reproduce with the latest release?
yes, latest beta
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOCACHE="/root/.cache/go-build"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build926389312=/tmp/go-build -gno-record-gcc-switches"
VGOMODROOT=""

What did you do?
Running gofmt in Go 1.11beta1 causes a diff :smile:
To reproduce;

Create a file example.go, with the following content;

package main

func main() {
	_ = map[string]string{
		"a": "",
		"123456789012345678": "",
	}
	_ = map[string]string{
		"a": "",
		"1234567890123456789": "",
	}
}

gofmt the file;

gofmt -s -d ./example.go

What did you expect to see?
On Go 1.10.3, only the first map is re-formatted (the threshold for aligning values lies at 19 characters)
--- example.go.orig	2018-07-05 10:23:56.358365143 +0000
+++ example.go	2018-07-05 10:23:56.358365143 +0000
@@ -2,7 +2,7 @@

 func main() {
 	_ = map[string]string{
-		"a": "",
+		"a":                  "",
 		"123456789012345678": "",
 	}
 	_ = map[string]string{

What did you see instead?
On Go 1.11beta1, both maps are re-formatted (the threshold for aligning values lies at 18 characters):
--- example.go.orig	2018-07-05 10:24:32.709844185 +0000
+++ example.go	2018-07-05 10:24:32.709844185 +0000
@@ -2,11 +2,11 @@

 func main() {
 	_ = map[string]string{
-		"a": "",
+		"a":                  "",
 		"123456789012345678": "",
 	}
 	_ = map[string]string{
-		"a": "",
+		"a":                   "",
 		"1234567890123456789": "",
 	}
 }

This change complicates projects that test against multiple versions of Go (see related issues https://github.com/moby/moby/pull/37358, https://github.com/containerd/containerd/pull/2436)
If this was a deliberate change, please add a mention of this in the changelog 🤗

This change was done on purpose in 542ea5ad91367d2b40589942cc5757a4d5f43f97.
As to why gofmt changes every release - see @griesemer's comment in https://github.com/golang/go/issues/25161#issuecomment-385481599.
However, I agree that this change should be documented in the release notes. I can't see it in https://tip.golang.org/doc/go1.11.

Oh! actually found that commit, but see I forgot to include it in my description (thanks!)
hm, alright, so I understand Go should not stop progression; just thinking what the best approach is for projects that test against, and support multiple go versions;

for CI; exclude gofmt check on version X
more problematic; accepting contributions from users running different versions of Go 😕 😅

Yes - if a project wants to enforce gofmt via CI, it should stick to exactly one version of gofmt. That tends to be the latest stable version, such as 1.10 now.
The other option is to not enforce it via CI, and instead enforce it via pre-commit checks and by humans, like Go itself does.

I agree that enforcing this server-side instead of client-side is better. Perhaps it should be made easier for developers to download specific versions of gofmt, so that they could use gofmt1.10 for work projects even if they were using 1.9 or 1.11beta1 (master) on their laptop.
gofmt could even include a version flag, so that scripts could check if the right version is being used. Although it might be a bad idea for the gofmt that ships with Go itself to report a version, equal but separate from go version.
https://github.com/golang/go/issues/22695 didn't seem to reach any conclusion that would help with this. I might open a proposal issue along the lines of what I described above, once this documentation issue is fixed.

gofmt could even include a version flag, so that scripts could check if the right version is being used. Although it might be a bad idea for the gofmt that ships with Go itself to report a version, equal but separate from go version.

Yes, while writing my previous comment, I wanted to suggest a "version" option, so that a different gofmt could be used to ease a project's transition between Go versions. I decided not to, because doing so may defeat the whole purpose of gofmt (end all discussions around code-style/formatting).
Having said the above, perhaps there's still merit in that option; introduce an option to select a "slow" version of gofmt, limited to versions of Go that are actively maintained;
For example, currently, Go 1.11 (next stable), 1.10.x (current stable), and 1.9.x (previous stable) are actively maintained; I think it's ok to assume (most) projects that support multiple Go versions won't Go beyond those versions
Could look something like this; (gofmt [--version=<option>]);

Option
Description

(not set)
default; use gofmt of the installed version

current
same as above; use gofmt of the installed version

stable
use current stable; same as default (/ current) under normal circumstances, but can be useful when running go tip or a beta

previous-stable
use previous stable; useful during migration betwen versions, and if a project supports both "current" and "previous" stable

When I mentioned a version flag, I meant just a flag to print its version :) Then, scripts could do something like:
gofmt="gofmt"
if [[ $(gofmt -version) != go1.10.* ]]; then
    # download gofmt1.10
    gofmt="gofmt1.10"
fi
# use $gofmt

I'll send a proposal about this in a few days. @thaJeztah if you want, I can email you a draft before publishing.

Looks like that would indeed help 👍  You can /cc me at  sebastiaan <swirly-thingy> docker.com

@mvdan

The other option is to not enforce it via CI, and instead enforce it via pre-commit checks and by humans, like Go itself does.

Yes, Russ has made this comment too in the past. Pre-commit checks don't work well in practice unless there is either a requirement that contributors run a Makefile to install the hooks or there is a bespoke codereview tool as exists for Go contributions. These are not necessarily feasible for small open source projects (a good example is Gonum where we already have difficulty managing new and drive-by contributions).
I'll just go and eat my brioche.

@kortschak please note that this issue is closed, and that I filed a proposal precisely to make enforcing gofmt easier - #26397.


Implement rollback within Update

Closes #42.

Tests are passing but I'm pretty sure there's something wrong with this. Failing transactional squares, maybe?

Good enough. I'll merge and tag as a pre-release.


Improve godoc

It would be good to have more documentation on the configuration functions along with an example of how to start the IMAP server. At the moment it is not clear how to use the configuration functions unless you have read the blog post on their use.
The DummyImap server should not be public because it is only used for testing and takes up around 1/3 of the godoc at the moment.

It should be noted that the correct godoc convention should be used... This currently is not the case, and I think it should be updated with this issue.


Move ess notebook on beam center finder

The notebook describing the procedure for the beam center finder in the ess docs contains some useful information that should not be lost.
We should move this notebook over to esssans.
Right now, we only have a notebook in the examples section. We probably need to re-organise the docs a little?

It also would need to be extended with the new method via the center of "mass".

Fixed in #72


add NomikaiFTSO

We recommend you amend the logo image to exclude any text, it'll look bad in most wallet user interfaces including Bifrost Wallet.

Thank you. We have removed the text from the image.

Merged in https://github.com/TowoLabs/ftso-signal-providers/commit/a2024ebd31ac4b207867fadf81bc03a8f2562e30


Use same config file for parser as for interpreter

[ ] angle
[ ] step size
[ ] commandset
[ ] ???

I think the parser should output something like
#angle 30
#stepsize 2
#commandset default
<lstring>