Test and potentially add support for AWS RDS

This issue is to test whether our current Postgres implementation will connect to Amazon RDS, which is a commonly-used Amazon-hosted Postgres database. If it does, we're done. If not, we should try to add support.
Steps

Create an RDS instance for testing inside a Cyral-paid Amazon account
Create a username and password
Run the authenticator locally
Run the Python client locally
Attempt to retrieve a connection to the database using the Python client

This could be completed either inside the Docker dev environment, or outside of it.

Tested and works! ✅

Followed steps as stated.
Tested on both Mac and Docker dev environment.

That is awesome, @UpGado ! For RDS, are the connection strings exactly the same? Or is there any difference?

That is awesome, @UpGado ! For RDS, are the connection strings exactly the same? Or is there any difference?

They are the same. This is what it looked like, for example:
conn = connect(host='rds-dbpg.*******.us-east-2.rds.amazonaws.com',
               user='bob', authenticator=auth,
               dbname='finance')

That is awesome! If it's the same, I'm not sure if it would be valuable to add an example for it. Do you think we should add an example somewhere with a note that we do support Amazon RDS? Or do you think it's implied so it's better to just leave it off?

I lean towards leaving it off, since RDS claims to be Postgres compatible, it should be implied.

I think we're done then! Thanks for testing!


Consider whether NAME should also be included in netdev variables

Currently all networks are named Default according to wwinit ifcfg.ww.
With this paramenter under "network devices:" each interface can have its own name.

Cleaning up old / inapplicable issues. If this issue is still relevant, please open it in the main warewulf repo.


[1.16] Plant Gatherer stops working 1 operation after a tier 1 range card is added

After adding a range card to a plant gatherer, it will stop after breaking 1 crop and never work again, only tested with mystical agriculture plants so far, the modpack is FTB oceanblock and teams settings should be allowing fake player interaction

Industrial Foregoing Version: <IP_ADDRESS>-16
Titanium Version: <IP_ADDRESS>-22

I am also having the same issue. Also on Oceanblock modpack.

I'm having the exact same issue. Removing and reinserting the range upgrade makes it do one more operation after which it stops again.

I have one Plant Gatherer working as intended with a Range Addon +1 but my second gatherer just a few blocks away set up the exact same way is experiencing this issue. I'm on the latest version of OceanBlock, I believe it's the latest version of Industrial Foregoing.

g


Allow double click on tab to return layout to original

Issue Type: Bug
If you have a split screen you can vary the width of the split.
One behaviour was that you could double click a tab and it would occupy most of the window and then double click again to return it to its previous size and layout.
The second double click now resets the layout of all splits to some sort of middle.
It used to be very useful if you had many files but only generally wanted to be able to see a little bit of them in reference (like the bootstrap css breakpoints) but then occasionally enlarge that file to look at other parts of it.
Or just flick between file tabs and keep them large. This is very useful on screens smaller than enormous.
I have removed all extensions and it appears to be the same without extensions.
VS Code version: Code 1.64.2 (Universal) (f80445acd5a3dadef24aa209168452a3d97cc326, 2022-02-09T22:00:58.347Z)
OS version: Darwin x64 20.6.0
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4980HQ CPU @ 2.80GHz (8 x 2800)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 3

Memory (System)
16.00GB (0.08GB free)

Process Argv
--crash-reporter-id a910920d-1205-4d5b-bb90-06a303804f97

Screen Reader
no

VM
0%

/gifPlease

Ok thanks. Will sort that later today.
Best regards
Matt Holmes
Director
Origin London Ltd
@.***
UK:<PHONE_NUMBER>0
Int: +447500847210
Companies House Number: 7302875
VAT Registration Number: GB231798196
Registered Office: 52 Llanover Road, London. SE18 3SU

From: Benjamin Pasero @.***>
Sent: Thursday, 3 March 2022, 11:44
To: microsoft/vscode
Cc: originlondon; Author
Subject: Re: [microsoft/vscode] Double click on tab no longer returns layout to original (Issue #144311)
/gifPlease
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/vscode/issues/144311#issuecomment-1057960727, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AH7Y25OQI25IIB4HEAARYOLU6CQY7ANCNFSM5P2AIEBA.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID: @.***>

Thanks

I was asked to explain further with a screencast.
I have uploaded an mp4 and tried to embed a gif as requested, but couldn't as the mp4 converted to a gif was too large. It seems to display inline with mp4 though anyway.
https://user-images.githubusercontent.com/33525109/157091189-ef01fec6-1e59-4e57-bf98-de38377631d7.mp4

@originlondon I see but you indicate this has changed recently? I do not think so. Can you clarify?

I believe it was working as described in October last year. I couls be mistaken, as I took a break from coding for a few months.
My larger screen broke so I had to use an older smaller one. I also remember discovering that feature when using just a left-right split. So I discovered the feature around July/August last year, perhaps.
But I am pretty sure that it used to work like that as I used to keep four or five core scss variable definition files at the bottom of my left panel, each with just a few key lines showing and then expand and contract them as necessary, if needed to see the rest of the file, rather than search through them via the dropdown, or flick along the tabs or choose them in the open tabs browser in the panel.
Apologies for any typos, I was finding this difficult to write as Microsoft Outlook on Android mobile was not doing 'cut' functionality, only copy, paste and delete - weird. Lol. (not going to report that just yet - could be an Android thing after an update last night and its indicating another one due, which could correct that).
Thanks.

Best regards
Matt Holmes
Director
Origin London Ltd
@.***
UK:<PHONE_NUMBER>0
Int: +447500847210
Companies House Number: 7302875
VAT Registration Number: GB231798196
Registered Office: 52 Llanover Road, London. SE18 3SU

From: Benjamin Pasero @.>
Sent: Tuesday, March 8, 2022 6:28:33 AM
To: microsoft/vscode @.>
Cc: originlondon @.>; Mention @.>
Subject: Re: [microsoft/vscode] Double click on tab no longer returns layout to original (Issue #144311)
@originlondonhttps://github.com/originlondon I see but you indicate this has changed recently? I do not think so. Can you clarify?
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/vscode/issues/144311#issuecomment-1061453056, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AH7Y25IF4XMFT5SWPADNSLLU63XRDANCNFSM5P2AIEBA.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID: @.***>

I think this is working for a long time like that, but treating as feature request.
//cc @joaomoreno @sbatten since this is grid related.

Ok thank you!
Best regards
Matt Holmes
Director
Origin London Ltd
@.***
UK:<PHONE_NUMBER>0
Int: +447500847210
Companies House Number: 7302875
VAT Registration Number: GB231798196
Registered Office: 52 Llanover Road, London. SE18 3SU

From: VS Code Issue Triage Bot @.>
Sent: Tuesday, March 8, 2022 8:13:49 AM
To: microsoft/vscode @.>
Cc: originlondon @.>; Mention @.>
Subject: Re: [microsoft/vscode] Allow double click on tab to return layout to original (Issue #144311)
This feature request is now a candidate for our backlog. The community has 60 days to upvotehttps://github.com/microsoft/vscode/wiki/Issues-Triaging#up-voting-a-feature-request the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentationhttps://aka.ms/vscode-issue-lifecycle.
Happy Coding!
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/vscode/issues/144311#issuecomment-1061515320, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AH7Y25O3OKQDCYCP4LNIC4DU64D33ANCNFSM5P2AIEBA.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID: @.***>

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


vstart application to load/store including vlxff

Zvlssegg extension explicitly mentions vstart as applicable to restarting at units of structures.
This implies that all the vector load/store instructions can resume with a vstart not equal to zero.
This should be stated explicit in the load/store section. I'm certainly willing to make a PR for it.
It raises the question whether vstart is applicable to the Fault-only-first load instructions.
Some faults are avoided because the vl is reduced to only process non-faulting elements. However, some faults cannot be avoided, especially interrupts. In this case it may be very advantageous to resume the load rather than process a truncated set of elements. (In particular the buffering of read elements may be lost during the processing of a memory heavy loop).
I propose vstart also be applicable to the Fault-only-first load instructions.
And it also be noted that on a trap vl should not be reduced.
Again I'm willing to do the PR if this is what is intended.

The fault-only-first loads should be interruptible, which means they should be able to handle nonzero vstart.  (It's still the case that address exceptions will only happen on element 0, regardless of vstart.)


remove remainders of libcurl

Scope & Purpose
Removes remainders of libcurl from lsan_suppressions

[x] Bug-Fix for devel-branch (i.e. no need for backports?)

Testing & Verification
This change is a trivial rework / code cleanup without any test coverage.
http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/10360/

Tests blue


Angular 2 + Search Component issue - unable to navigate through results with keyboard

Hi,
please see this plunk

focus search box
type "a"
press keydown button to navigate through the results
selected item gets unselected immediately

it's working with pure jQuery implementation, not within an Angular 2 application.
Any idea on that?
Thank you!

okay, it seems to be a known issue with zone.js from Angular 2 - so no Semantic UI issue.
https://github.com/angular/zone.js/issues/319


Question: How to spawn and control multiple threads

I have tried web workers, they work great, but their's no NodeJS stuff like require() etc in their context.
So is there way to spawn multiple threads and control them?
I want to use them to compile js using uglifyjs and modules like that without blocking the main app.

Give child_process.fork a try

I cant believe I did this >_<
I am using pcntl_fork already on my other projects, It's a great way to manage child processes.
Thank You for reminding me @paulcbetts


Don't ignore aboutLibraries_description_text and name

Before this change, the value of aboutLibraries_description_text and aboutLibraries_description_name were ignored. This fix  that.

Thank you very much


[DISCUSS] ProcessedTable interface

Please describe the feature you'd like to see
I would like to get table stats or other meta data of the table that was processed via input/output table.
Describe the solution you'd like
Every operation (or operator) would return a processed table object attached with meta data if available. For example the class could simply look like this.
class ProcessedTable(Table):
   """A processed table containing meta data of the table which was processed by an operator."""

   metadata: Any

Note that this processed table can also be used as input table which makes this feature a non-breaking change if table instances are being swapped out with processed table instances.
Acceptance Criteria

[ ] All checks and tests in the CI should pass
[ ] Unit tests (90% code coverage or more, once available)
[ ] Integration tests (if the feature relates to a new database or external service)
[ ] Example DAG
[ ] Docstrings in reStructuredText for each of  methods, classes, functions and module-level attributes (including Example DAG on how it should be used)
[ ] Exception handling in case of errors
[ ] Logging (are we exposing useful information to the user? e.g. source and destination)
[ ] Improve the documentation (README, Sphinx, and any other relevant)
[ ] How to use Guide for the feature (example)

I am still brainstorming about this feature.. Maybe we only attach operator specific information or table information or both, I don't know yet.
Please let me know what you think.

I like the idea although I am not yet clear on how a user would know what data is available to them? i.e. what should I do to access the data available to me, if it is a dict, how does a user know the key name
i.e. do we have a set fields that will be part of this class/instance?

I like the idea although I am not yet clear on how a user would know what data is available to them? i.e. what should I do to access the data available to me, if it is a dict, how does a user know the key name

Yes, we have to find out.. 😅 and then document it. It could be different depending on the sql query and the db client being used.

i.e. do we have a set fields that will be part of this class/instance?

We could have some basic ones e.g.:

rows affected (and percentage)
total rows

For basic ones which are the same for every database we can create a class.
The question is also do we want to make additional queries or only store what we get from the initial query?

@feluelle @kaxil  - Just adding my two cents.

Rows affected: this info is more related to the operation than a table. Like one operator did something to a table can return rows affected / percentage but it should not be part of the table object.
total rows: we can add it as part of the table object, but keeping it up to date across multiple operations can be an issue.

But returning the same object that the user passed to the operator does seem weird.

Yes, we should differentiate between table and operator information.


Multi-select support for selection manager

Allow selecting multiple ids in one select call of selection manager.

completed


  Yes

Describe the bug
Install binary fails with:
thread 'main' panicked at 'Missing expected environment variable "CARGO_PKG_LICENSE"', /home/xxx/.cargo
/registry/src/github.com-1ecc6299db9ec823/built-0.4.4/src/lib.rs:498:5

Clap debug

            has cargo: 1
            has maple: /home/xxx/.vim/bundle/vim-clap/target/release/maple
           maple info: version 0.1.22 (git v0.22), built for x86_64-unknown-linux-gnu by rustc 1.43.0.

         has +python3: 1
has py dynamic module: 1
            has ctags: ctags without JSON output support
    Current sync impl: Lua
     Current FileType:
Third Party Providers: []
       Global Options:
    let g:clap#autoload_dir = '/home/xxx/.vim/bundle/vim-clap/autoload'
    let g:clap#provider_alias = {'gfiles': 'git_files', 'hist:': 'command_history', 'hist/': 'search_history'}
    let g:clap_background_shadow_blend = 50
    let g:clap_disable_bottom_top = 0
    let g:clap_disable_matches_indicator = v:false
    let g:clap_disable_optional_async = v:false
    let g:clap_disable_run_rooter = v:false
    let g:clap_enable_background_shadow = v:true
    let g:clap_enable_debug = v:false
    let g:clap_enable_icon = 0
    let g:clap_forerunner_status_sign = {'done': '•', 'running': '!', 'using_cache': '*'}
    let g:clap_insert_mode_only = v:false
    let g:clap_multi_selection_warning_silent = 0
    let g:clap_no_matches_msg = 'NO MATCHES FOUND'
    let g:clap_open_action = {'ctrl-v': 'vsplit', 'ctrl-x': 'split', 'ctrl-t': 'tab split'}
    let g:clap_popup_border = 'rounded'
    let g:clap_preview_size = 5
    let g:clap_providers_relaunch_code = '@@'
    let g:clap_search_box_border_style = 'nil'
    let g:clap_search_box_border_symbols = {'nil': ['', ''], 'curve': ['', ''], 'arrow': ['', '']}
  Provider Variables:
                     []

To Reproduce
Steps to reproduce the behavior:

Create the minimal vimrc min.vim:

set nocompatible
filetype off

call plug#begin('~/.vim/bundle')
Plug 'liuchengxu/vim-clap', {'do': ':Clap install-binary' }
call plug#end()

let g:python_host_prog = '/home/xxx/.virtualenvs/neovim/bin/python'
let g:python3_host_prog = '/home/xxx/.virtualenvs/neovim3/bin/python3'

syntax on
filetype plugin indent on
set hidden

:Clap install-binary

Additional context
Deleting build folder did not help

What does rustup show say? Since you have compiled the Rust binary successfully before, can you recall any Rust lated suspicious changes you did to your system since the last compilation?

What does rustup show say? Since you have compiled the Rust binary successfully before, can you recall any Rust lated suspicious changes you did to your system since the last compilation?

I do not have rustup because I installed rust from the ubuntu packages. Make also fails. I have rust only for clap installed, so I did not change my env.
I did some research, the ubuntu rust version is only 1.43.0 and CARGO_PKG_LICENSE env var was added in 1.46.0.
I set CARGO_PKG_LICENSE to foo and got another error:
error[E0460]: found possibly newer version of crate `std` which `autocfg` depends on

I do not have rustup because I installed rust from the ubuntu packages. Make also fails. I have rust only for clap installed, so I did not change my env.
I did some research, the ubuntu rust version is only 1.43.0 and CARGO_PKG_LICENSE env var was added in 1.46.0.
I set CARGO_PKG_LICENSE to foo and got another error:
error[E0460]: found possibly newer version of crate `std` which `autocfg` depends on

Ok, upgrading your rust version to the latest should be helpful.
Or if you can checkout the latest tag and choose to use the pre-built binary from GitHub:
" :Clap install-binary[!] will always try to compile the binary locally,
" if you do care about the disk used for the compilation, try using the force download way,
" which will download the prebuilt binary even you have installed cargo.
Plug 'liuchengxu/vim-clap', { 'do': { -> clap#installer#force_download() } }

Ok, upgrading your rust version to the latest should be helpful.
Or if you can checkout the latest tag and choose to use the pre-built binary from GitHub:
" :Clap install-binary[!] will always try to compile the binary locally,
" if you do care about the disk used for the compilation, try using the force download way,
" which will download the prebuilt binary even you have installed cargo.
Plug 'liuchengxu/vim-clap', { 'do': { -> clap#installer#force_download() } }

Works with 1.46

Works with 1.46


Feature: Add support for Proto3 language

Requesting simultaneous support for both proto2 and proto3 language syntax, selected via the new syntax = "[proto2|proto3]"; statement.
https://developers.google.com/protocol-buffers/docs/reference/proto3-spec
As possible incentive, the official C# generator for Proto3 does not (and will not) support generating code for the proto2 language, and thus it is not (and will-not-be) possible to write protobuf tooling and self-describing services in .NET.
Perhaps Froto can be used to fill that need.

Why is it not possible to write self-describing services in .NET for Protocol Buffers v3? What do you mean by self-describing services? Do you mean code-first with attributes like:
https://github.com/mgravell/protobuf-net#1-first-decorate-your-classes

Have in mind to create a service registration protocol which allows a generic service to register it's FileDescriptorProto (or Set) at run-time, so that the service's metadata can be inspected as well as to provide transcoding from/to JSON, without recompiling the server being registered with.  That's what I meant by "self-describing services".
The official C# generator from Google will not generate code for proto2, but proto2 is required if one wants to define and process custom options in .NET.  So... I am hunting for an alternative.

I had to read up more about custom options. I have't used them, but they could be useful for altering the code generation. It looks to me like you can put custom options in a proto3 descriptor. Did I miss something?
https://developers.google.com/protocol-buffers/docs/proto#options
https://developers.google.com/protocol-buffers/docs/proto3#options
https://github.com/google/protobuf/blob/master/src/google/protobuf/descriptor.proto#L35-L37

Hah.  What you missed is that while custom options can be used in proto3, they require proto2 syntax to define (custom options use the extend keyword, which is proto2 only).  Further, the Google C# code generator only supports generating proto3 constructs, so while it will recognize custom options, it will not generate code to access them. :P


GH-198: Ignore runtime errors where exit code was 0

RuntimeError did not seem to be typed in any meaningful way so unfortunately I think the best way to do this might just be a string comparison.
Resolves #198

This seems relevant: https://github.com/wasmerio/wasmer/blob/master/examples/early_exit.rs
If anything it's a more "proper" way to handle it, though I can't get it working myself for some reason. Food for thought at least!
In any case I was trying to apply it like this:
match e.downcast::<ExitCode>() {
    Ok(ExitCode(0)) => {}
    Ok(exit_code) => {...}
    Err(e) => {...} // a failed downcast returns the original error
}

I think it looks good as well! The only thing I may add is to maybe do the string conversion just once and store it in a local variable, but otherwise it seems fine!

@CMDJojo I changed it, looks good?

Looks good! It was just a small change, I doubt the previous version would be expensive anyways, but looks good! Ready to merge


Feature/1588 fix menu link issue

Pull Request

fixed issue where the uswds Link component was used instead of reactDOM

reviewed with Addis


Sample Collection Protocol field in the study doesn't take input

To Reproduce
Steps to reproduce the behavior:

create a new study in a project
go to the  Sample details
Try to write in the  Sample Collection Protocol field.
I am also not sure why there is a "save" button there while the rest are "edit"

Screenshots

This also applies to the following fields in the study -> Datasets tab

[ ]  Extraction
[ ]  NMR Sample preparation
[ ]  Data transformation

Closed in favor to #528


Getting this while opening spyder on Mac OS Sierra 10.12.6

Description
What steps will reproduce the problem?

Open terminal
Type "spyder" to open spyder in python path

What is the expected output? What do you see instead?
Got error window after Spyder opens but console never starts, keeps spinning.
Please provide any additional information below
AttributeError: Queue instance has no attribute 'put'
Version and main components

Spyder Version: 3.2.4
Python Version: 2.7.14
Qt Versions: 5.6.2, PyQt5 5.6 on Darwin

Dependencies
pyflakes >=0.5.0  :  1.6.0 (OK)
pycodestyle >=2.3 :  2.3.1 (OK)
pygments >=2.0    :  2.2.0 (OK)
pandas >=0.13.1   :  0.20.3 (OK)
numpy >=1.7       :  1.13.3 (OK)
sphinx >=0.6.6    :  1.6.3 (OK)
rope >=0.9.4      :  0.10.5 (OK)
jedi >=0.9.0      :  0.10.2 (OK)
psutil >=0.3      :  5.4.0 (OK)
nbconvert >=4.0   :  5.3.1 (OK)
sympy >=0.7.3     :  1.1.1 (OK)
cython >=0.21     :  0.26.1 (OK)
qtconsole >=4.2.0 :  4.3.1 (OK)
IPython >=4.0;<6.0:  5.4.1 (OK)
pylint >=0.25     :  1.7.4 (OK)

This is an installation with one of Spyder dependencies. Please post the entire error message and not only the last line.

This happened with the Mac OS graphical installer. I did a clean and
reinstall with command line installer and it worked.
On Sun, Nov 5, 2017, 6:39 AM Carlos Cordoba<EMAIL_ADDRESS>wrote:

This is an installation with one of Spyder dependencies. Please post the
entire error message and not only the last line.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/spyder-ide/spyder/issues/5656#issuecomment-341977873,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFKbT0PIa7OCK5RJLXaDAbWYXZO6f4dUks5szciNgaJpZM4QSMAB
.

Thanks for letting us know about it.


[Bug]: AccessList RegexValidator not allowing hyphens

NetBox access-list plugin version
v1.2.2
NetBox version
v3.4.3
Steps to Reproduce
Use the access-list name "test-test"
Expected Behavior
test-test should succeeded
Observed Behavior
Error is raised: "Only alphanumeric, hyphens, and underscores characters are allowed."

Hi Ryan! As far as I understand, this bug correction is not included in current version 1.3.0.
Is there by any chance a new release planned soon?
Thx!

I swore it was in there, but I will check this afternoon.


velero-plugin-registry

This velero plugin registry enhancements will do the following

[x] Find registry deployments for dpa BSLs and delete them
[x] Set additional environment variable to velero deployment to enable plugin registry behavior

[ ]  This can only be tested in CI once https://github.com/openshift/openshift-velero-plugin/pull/145 is merged and quay.io image is updated.

Codecov Report

Merging #743 (4ae48e4) into master (5b41bea) will increase coverage by 0.35%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #743      +/-   ##
==========================================
+ Coverage   36.96%   37.32%   +0.35%
==========================================
  Files          16       16
  Lines        3219     3188      -31
==========================================
  Hits         1190     1190
+ Misses       1926     1895      -31
  Partials      103      103

Impacted Files
Coverage Δ

controllers/registry.go
41.59% <0.00%> (+1.39%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b41bea...4ae48e4. Read the comment docs.

/test all

oops forgot needs plugin PR merge first

ready for review but
/hold for https://github.com/openshift/openshift-velero-plugin/pull/145

ready for review but
/hold for https://github.com/openshift/openshift-velero-plugin/pull/145

bundle is up to date

/retest-required

/retest

/test 4.9-operator-e2e-gcp

For AWS:
Internal 500 error
trying to reuse blob sha256:ca753d5e70afb765e08ae8e79316b2feb7618fc6c779109ac7f797709c51d9b6 at destination: failed to read from destination repository mongo-persistent/todolist-mongo-go: 500 (Internal Server Error)

For GCP
It appears GCS storage driver init function is not called...
plugin panicked: StorageDriver not registered: gcs

https://github.com/distribution/distribution/blob/3f4c558dac40dfb4fe13285ffc43a0d738d3a3f0/registry/storage/driver/gcs/gcs.go#L80
For Azure envs used was malformed.
azure: malformed storage account key: illegal base64 data at input byte 0

https://github.com/openshift/openshift-velero-plugin/issues/152 might be an issue.

waiting on https://app.travis-ci.com/github/openshift/openshift-velero-plugin/builds/253057305 to retest again

Looks like no retest required.. since all running tests are still installing ocp

/test 4.10-operator-e2e-aws

GCP tests blocked by https://github.com/openshift/openshift-velero-plugin/pull/155. Once travis builds this, retesting GCP is expected to pass.

/retest


Fix sourcemap support

I have a problem enabling sourcemap at building. The sourcemap files are not generated properly, and console prints warnings like:
> vite build

  vite-plugin-virtual-html [vite-plugin-virtual-html]: This plugin cannot use in library mode! +0ms
vite v4.0.4 building for production...
✓ 28 modules transformed.
rendering chunks (1)...Sourcemap is likely to be incorrect: a plugin (vite-plugin-virtual-html) was used to transform files, but didn't generate a sourcemap for the transformation. Consult the plugin documentation for help
Sourcemap is likely to be incorrect: a plugin (vite-plugin-virtual-html) was used to transform files, but didn't generate a sourcemap for the transformation. Consult the plugin documentation for help
rendering chunks (2)...Sourcemap is likely to be incorrect: a plugin (vite-plugin-virtual-html) was used to transform files, but didn't generate a sourcemap for the transformation. Consult the plugin documentation for help
Sourcemap is likely to be incorrect: a plugin (vite-plugin-virtual-html) was used to transform files, but didn't generate a sourcemap for the transformation. Consult the plugin documentation for help
rendering chunks (3)...Sourcemap is likely to be incorrect: a plugin (vite-plugin-virtual-html) was used to transform files, but didn't generate a sourcemap for the transformation. Consult the plugin documentation for help
Sourcemap is likely to be incorrect: a plugin (vite-plugin-virtual-html) was used to transform files, but didn't generate a sourcemap for the transformation. Consult the plugin documentation for help
Sourcemap is likely to be incorrect: a plugin (vite-plugin-virtual-html) was used to transform files, but didn't generate a sourcemap for the transformation. Consult the plugin documentation for help
Sourcemap is likely to be incorrect: a plugin (vite-plugin-virtual-html) was used to transform files, but didn't generate a sourcemap for the transformation. Consult the plugin documentation for help
Sourcemap is likely to be incorrect: a plugin (vite-plugin-virtual-html) was used to transform files, but didn't generate a sourcemap for the transformation. Consult the plugin documentation for help
Sourcemap is likely to be incorrect: a plugin (vite-plugin-virtual-html) was used to transform files, but didn't generate a sourcemap for the transformation. Consult the plugin documentation for help

And the sourcemap files are empty:
{"version":3,"file":"admin.js","sources":[],"sourcesContent":[],"names":[],"mappings":""}

This PR fixes it, no warning and sourcemap files are correct.

ehh,right.
This plugin only need to transform html code. So other code should return null.
My fault...
And I reviewed this code, Can you add a null type to transform function to make sure code has no error.
When you add the type, and I will merge this PR


Remove  from the global-reset() helper.

 should arguably not be reset, because currently something like blah will reset the font family, which is obviously undesirable...

doesn't matter to me :D haven't seen that tag in years I just grabbed it from that dude


invalid on latest SDK

invalid on latest SDK

Can you try the latest version?

me too,target SDK 24, invalid

我现在是25的..直接用不了

There shouldn't be any issue any more.

it is ok.


Skip Image Export (node) credential validation

The credentials used for Image Export don't have validation logic,
causing over-all provider credential validation to fail. This blocks
provider refresh from the GUI.
In the future, we should add validation to these credentials if the user
provides them (Image Export is an optional feature, so credentials also
need to be optional).

fyi @iv1111 - adding you as a reviewer to make sure I'm not missing something here.

@jaywcarman thanks for solving this one, I will check it today and write here

Looking good.


HOTPOT-997: Show 'unfollow' in ••• menu on profile

Adds 'unfollow' to the overflow menu on profiles of people you follow that have new/broken proofs

note that this doesn't appear on the PeopleResult ••• menu since that menu doesn't have an indicator of broken state or a follow button


Rspec and Unit test not working as expected. It used to work earlier.

please add a screenshot or any other details of what doesn't work.

I tried the rspec and unit test commands in my rails project but it takes forever to complete and it doesnt work. I wont be able to share the screenshot due to security reasons. When i cloned the "dummy folder" and tried, it worked, so the behaviour is strange. All other use cases worked for my rails project.

Thankyou, i will check it

Hi,
May I know the dependencies of this gem? I am using a latest version of
rails and ruby and it's fine for me. But which of the older versions does
it support?
A friend of mine tried for ruby 2.5.3 and rails 3.1 and it didn't work.
On Mon, Feb 19, 2024 at 9:43 PM Igor Kasyanchuk @.***>
wrote:

then I can only suggest clone this repo, connect it directly in your app
and debug
somewhere here:
https://github.com/railsjazz/ask_chatgpt/blob/main/lib/ask_chatgpt/executor.rb#L43
—
Reply to this email directly, view it on GitHub
https://github.com/railsjazz/ask_chatgpt/issues/18#issuecomment-1952791890,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A7A6SBHYSECDGIJQXMTM63TYUN23PAVCNFSM6AAAAABDPEAZ56VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJSG44TCOBZGA
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Thanks,
Samseena Rahmathulla* | *Lead Software Engineer
+91-9995031898
--
Disclaimer: The information contained in this e-mail is private &
confidential and may also be legally privileged. The contents of this mail
and any of its attachments are subject to change without notice. If you are
not the intended recipient of this mail, please notify us, preferably by
e-mail; and do not read, copy or disclose the contents of this message to
anyone. Whilst we have taken reasonable precautions to ensure that any
attachment to this e-mail has been swept for viruses, e-mail communications
cannot be guaranteed to be secure or error-free, as information can be
corrupted, intercepted, lost or contain viruses. We do not accept liability
for such matter or their consequences.


AMQP-628: Master to 2.0, SF 5.0

JIRA: https://jira.spring.io/browse/AMQP-628
Remove log4j Appender (deprecated in 1.6.2).

Pushed

Since we don't have log4j code any more, we don't need its dependency. Even if it is optional.
I can remove on merge, of course, but would like to hear from you about a general our logging system in project. Right now it is:
testCompile "log4j:log4j:$log4jVersion" (1.2.17)

SF-5.0 has moved to log4j 2 already.
Different JIRA or we can consider it here as well?

Yeah - separate JIRA I guess - I was going to suggest going to logback to be consistent with boot but if SF uses log4j2 ...

Done: https://jira.spring.io/browse/AMQP-630
Merging this one with those minor concerns in the build.gradle.

Merged as https://github.com/spring-projects/spring-amqp/commit/2ee8c34a8cea2c7f6706943d8092e7d9996ba4fa


chore: some clean-up to e2e tests

Signed-off-by: bitliu<EMAIL_ADDRESS>chore: some clean-up to e2e tests

Codecov Report

Merging #162 (f2eca97) into main (b000bc6) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #162   +/-   ##
=======================================
  Coverage   42.00%   42.00%
=======================================
  Files          29       29
  Lines        4866     4866
=======================================
  Hits         2044     2044
  Misses       2661     2661
  Partials      161      161


[deliver,frameit] frame latest iOS devices

Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.

Motivation and Context
Note: Continuation of https://github.com/fastlane/fastlane/pull/13368
Implement support for the latest Apple devices
Description
Added support for iPhone XR, iPhone XS, iPhone XS Max. Added new resolutions, added option to use legacy iPhone X instead iPhone XS, changed default 5.8" device to iPhone XS

@mirkokg Can you please approve use of your commits in this PR?

@daveanderson Thanks for adding this! I'm working on testing this but I also added the new frames to the frameit-frames repo - https://github.com/fastlane/frameit-frames/pull/5
This should add to this PR and allow for actually using the new frames with the new color

@daveanderson Are you cool if I throw some commits onto here? 😊

@mirkokg we will need one more approval to merge this 😂

Thanks for the addition @joshdholtz ⭐

@joshdholtz Can you approve. I believe your commit resolved your own review concern.

@KrauseFx Anything holding this up? @joshdholtz committed a change to address his own request for changes.

@joshdholtz is there anything holding up approval for this? I discovered this PR the other week when I was getting ready to submit screenshots. Would be nice to have it released.
Thanks everyone for making this happen!


Run the deployment inside a container

When using the pull mode, run the deployment inside a container.
This container will come with all the tools/binaries needed:
hyperkube, kubectl, etcd, etdcdctl, calicoctl, kargo, kargo-cli, kpm ...

i'd like to recommend not using hyperkube whenever possible, or at least strongly advising users of the project to avoid conditions where hyperkube is deployed. for instance...a disclaimer during deployment that it is an insecure framework and meant for development purposes only: https://github.com/kubernetes/kubernetes/issues/21735

kubernetes guys are aiming to use hyperkube as default binary : https://groups.google.com/forum/#!topic/kubernetes-sig-cluster-lifecycle/FhEsevva6Yg

kubernetes running as a single binary in a container (hyperkube) is definitely a security concern when running directly on the internet. this is misleading when advertising as a "production ready" deployment until there is some other [more secure] method. hyperkube as a single binary...sure. hyperkube via a docker container...not so much when carefully reading the security advisory and issues thread.

I agree we'll take care of these security concerns when we'll choose the method (single binary or not).
Anyway we currently trying to run everything into containers when possible.
I want to keep this issue opened as a reminder.
Thank you @v1k0d3n

No activity
This should be part of a larger discussion


SqlSetup: Test-TargetResource should test whether service is running

Scenario:
I am using SQLServerDSC <IP_ADDRESS> to install SQL Server 2016 SP2 on a Windows 2016 Server Datacenter Core VM on an A2 size plan in the ASDK for Microsoft Azure Stack (MAS). I am using this as a test and to play around with DSC and the azure DSC Extension.
The error:
When the deployment process is finished, the MAS deployment gives me the following error.

Error message: DSC Configuration 'SQLConfiguration' completed with error(s). Following are the first few: PowerShell DSC resource MSFT_SqlSetup failed to execute Test-TargetResource functionality with error message: System.InvalidOperationException: Failed to connect to SQL instance 'MYSQLVM'.

Troubleshooting:
Checking the SQL installation log, I find that the setup itself was successful. I followed this up by checking whether the MSSQLSERVER service was running. It turns out, it was not. I manually started the service; running the Start-DscConfiguration in verbose gave me a pass on all tests.
Cause:
After checking the event log, I found out that the services time-out during start-up. In all likelihood, my VM is not powerful enough to handle the start-up of all services in a timely manner even though the server runs on the core edition and the VM size meets the minimum requirements for SQL Server 2016.
Quick solution:
As this is a test case and it doesn't need to be pretty, I solved this problem by changing the default servicepipetimeout to 4 minutes. My deployment now passes. I chose not to increase the VM size as space on our ASDK is very limited. I also chose not to use the service resource to make sure the required services are running, because the resulting IF statement proved a bit too difficult to make with my current understanding of DSC.
Suggestion:
In order to facilitate troubleshooting, I suggest the Test-TargetResource performs a test to see if the required services, such as MSSQLSERVER, are running before it tries to test the connection.
Code for those interested:

Registry Sevicespipetimeout {
Key = "hklm:\system\currentcontrolset\control"
ValueName = "servicespipetimeout"
ValueData = "240000"
ValueType = "Dword"
Ensure = "Present"

I think you mean the Test-TargetResource of the SqlSetup resource? I think it should be possible to add a optional boolean parameter which will test that the service is is running. Not sure if we should do this by default since that would change the behavior today, so if we add an optional parameter VerifyServiceRunning or similar, and that is set to $true then that check is done. 🤔
Would it be possible to use the Service resource from PSDscResources, or xService resource from xPSDesiredStateConfiguration to do this instead? 🤔

Yes, that is exactly what I mean.
I tried adding the Service resource after the setup, this solved the problem of the service not running. However, because I added DSC as part on an Azure deployment, it would still result in a "failed" deployment because the Test-TargetResource from the SqlSetup resource would run before the Service resource.
I tried placing the Service resource before the SqlSetup. In my case, this failed as well because the Test-TargetResource from the SqlSetup ran before the MSSQLSERVER service had completely started.
I toyed with the idea of making the SqlSetup and Service resource dependent on each other, but this proved too difficult for me to make and would needlessly complicate things.
I am sure my particular problem will not arise on most production machines as these will be powerful enough to make sure the MSSQLSERVER service wont timeout on startup. I made my suggestion for two reasons:

I used small VM sizes to save resources during my test phase. I assume I wont be the only one making this choice. Having the deployment fail because the service is not running might make troubleshooting easier in those cases.
If someone runs into the same problem I did, my post at least provides some documentation and a possible solution for the problem. :wink:

Thank you for your detailed information in this issue! :smile: I labeled this as enhancement and help wanted so that someone in the community can run with this :)

Same problems, because on Azure I have Analysis Services installed but disabled and the test-targetsource go to error (I NOT have specified in features AS but go to error always..)

@paololec For your issue I think you should use the Service resource to enforce the service to the state 'Running'. I think changing the StartupType and State of a service is not something SqlSetup resource should do.

@paololec If you mean that AS feature is not part of your configuration and the SqlSetup fails anyway, then  please open a separate issue that SqlSetup should ignore any feature not part of the configuration.

yes. it is.


Fix some issues to work better in scrolled pages

I fixed some issues in the module the improve the UX.

Remove of the invisible div angular-bootstrap-contextmenu: Originally, when you open the context menu, the div was created and you have to click out of the menu to destroy both. The div blocks for a moment any iterate with the page, Removing it, the module close the context menu and do the any action the page. With that improve, the behavior of the context menu will be the same behavior of the default browser context menu.
Fix the open position in scrolled pages: In scrolled pages, when you open the context menu in any position above the start position (scroll position = 0), the menu always open from the bottom to the top. Fixed this issue to considerate the scroll position in the calculation.
Align the position of nested menu with their parent when it opens from the bottom to the top: When the nested menu will open from the bottom to the top adds the parent pixels height in the top position to align the nested menu to its parent.
Close on scroll: Close the context menu when the page scroll down

Thank you, @rzucareli
Nice improvements

Looks good. Thanks!

Actually there was a bug that you can no longer click outside to close the menu. Fixed that with d8ca2d4


pod failed

The 'Pods-XXXX' target has transitive dependencies that include static binaries: (/Users/lxmacmini/Documents/myapp/XXXX/Pods/TXLiteAVSDK_Player/TXLiteAVSDK_Player/SDK/TXLiteAVSDK_Player.framework)
pod失败,xxxx是项目名,网上搜了下是动态库什么问题,升级,更新多次还是不行

repeat issue #5


Restructuring app and package bugzilla

Structuring the app with the proper file structure and some empty files to generally track how the app might be split up (subject to change).
Also adds the bugzilla package that provides a custom bug object and a function to query bugzilla's "jsonrpc" API with a saved search.

@directxman12 Here we go, some actual code to review.


Lower level GPU abstraction

We need to provide a level of GPU abstraction that doesn't have any overhead over using some API bindings directly. That means no resource lifetime management and preferably no heap allocation.
If we try to implement such a layer from scratch, we'd end up re-using most of the existing code from gfx_core and the backends. Thus, I believe we should steer the gfx_core towards this no-overhead goal, reaching it before we stabilize the API.
One effect of this transition would be - clearer separation between gfx_render and gfx_core. Another - opened use cases for applications demanding no overhead, like webrender. These applications may have limited use cases, allowing them to manage resource lifetimes more efficiently than us.

We already have these 3 levels of resource type abstraction:

Raw untracked structs (gfx_core, R::Texture).
Tracked Arc/Rc handles with metadata (gfx_render, handle::RawTexture<R>).
Tracked generically-typed handles (gfx_render, handle::Texture<R, Type>).

So the transition would be to make gfx_core operate on R::* structs entirely, not be aware of the tracked handles (which will live in gfx_render only), and minimize any heap allocations.

We need to provide a level of GPU abstraction that doesn't have any overhead over using some API bindings directly.

This is really difficult with regards to Vulkan/D3D12 as we would have to provide a very thin layer above those two APIs exposing concepts like resource barriers and explicit memory control. There was a talk by Chajdas concerning this some time ago (http://gpuopen.com/wp-content/uploads/2016/03/d3d12_vulkan_lessons_learned.pdf), which states that such a low level wrapper might be the best way for implementation.
(For gfx I started implementing something similar but I was kinda stuck at descriptor stuff and other projects had priority https://github.com/msiglreith/gfx/tree/gfx_next/src/core_next/src)
I assume the new architecture would be to implement core as some kind of bare metal API, which is kind of unsafe for the user. Render is then an higher-level entry point for users, which rather want an easy and safe gfx layer to use for quickly building applications, but don't need the full control over the GPU.

@msiglreith thanks for the info! You seem to not only understand the goal clearly, but also already having the first bits of the implementation. That's pretty impressive and exciting to see 👍

Small status update for corell:
Currently playing around with shaders and pipelines, trying to come up with a nice API and gathering all the required information to create a pipeline state (quite verbose!).
In my current design iteration I replaced Shader with ShaderLib, constisting of multiple shaders similar to Vulkan's SPIR-V modules and Metals .metallib approach. For pipeline creation the user then passes the library and an entrypoint (e.g "main") for each shader stage. (On OpenGL a shaderlib would always be a single shader with the fixed entrypoint "main".)
New factory interface (haven't worked out the factory methods for RenderPass and Signature so far):
fn create_shader_library(&mut self, code: &[u8]) -> Result<R::ShaderLib, shade::CreateShaderError>;
fn create_graphics_pipelines<'a>(&mut self, &[(&GraphicsShaderSet<R>, &R::PipelineSignature, &R::SubPass, &pso::GraphicsPipelineDesc)])
            -> Vec<Result<R::PipelineStateObject, pso::CreationError>>;
fn create_compute_pipelines(&mut self) -> Vec<Result<R::PipelineStateObject, pso::CreationError>>;

I'm still a bit unsure about how to handle SubPass and PipelineSignature (Vulkan: PipelineLayout, D3D12: RootSignature). Vulkan's PSO need to be compiled for a specific RenderPass and SubPass.
The PipelineSignature could be derived automatically from the render pso macro, but the user might want to fine-tune it to avoid register spilling and more efficient desciptor handling.
RenderPass would be emulated on the other backends by automatically insert the required transitions between the attachments.


Ignore json files from TypeScript type checking

Fix #5613
Sound's like another typescript bug. Opened https://github.com/Microsoft/TypeScript/issues/28202

Do we have an open issue with typescript about this? Can you link it here please?

https://github.com/Microsoft/TypeScript/issues/28202
I was just trying to create a sandbox before opening an issue on TypeScript but I'm not being able to make tsx work there: https://codesandbox.io/s/xl1y2vjwk4

Awesome!

I don't think codesandbox has support for TypeScript yet, maybe try just .ts and don't use JSX?

Didn't work, but nevermind, codesandbox wouldn't show this error output anyway because it's from the typescript compiler

CodeSandbox will deploy a fix tomorrow: https://github.com/CompuIves/codesandbox-client/pull/1239
TypeScript just fixed this bug in under 1h and merged: https://github.com/Microsoft/TypeScript/pull/28207
The community is so great 💙

I guess we should revert this once that's released?

Not released yet, just merged. Maybe on 3.1.4.

We'll keep this behavior until CRA 3.0.

TypeScript 3.1.4 released; I didn't confirm if the fix was included.


feat: update ingestion metadata jre examples

Notes
This change adds the ingestionMetadata to event with the backwards compatibility support.
This example uses Java reflection, which is working for both old version and new version Java/Kotlin SDKs, including:

jre-java v1
jre-kotlin v1
android-java v1
android-java v2
android-kotlin v1
android-kotlin v2

Updates

feat: update ingestion metadata jre examples

Tests

echo server with both old/new version Java SDKs

Close this, refer to the new one: https://github.com/amplitude/ampli-examples/pull/146


Relation "corsheaders_corsmodel" does not exist

Hello, I don't know if this is a local issue or not, but this happened on Django 1.9 when I tried to flush my db, to solve it I had to do a manual migration:
./manage.py makemigrations corsheaders
./manage.py migrate

Thanks in advance.

Having the same problem with django 1.10. In fact the corsheaders_corsmodel table is not created due to a missing migration in django-cors-headers.
It looks like the model is nowhere used in the code base (except in models.py and tests). Could we remove it?

+1 It doesn't need to be a django model by the looks of it.

Yup most users don't need it, will be gone via #121

Hi, I just ran into this bug because I tought that 1.2.0 was the last release as tagged here on github, while actually latest version is 2.1. Maybe you want to move the "latest release" tag to a more recent commit?

Sorry, I don't use GitHub releases for any other projects so wasn't aware of what that page was showing. The GitHub UI is a bit nasty there, folding up newer tags because the repo owner hasn't created a "release" object. Since there were only 4 tags with "releases" associated, and there was no special info on them, I just deleted the release objects, so the 'releases' tab only shows the tags now. That should prevent any future mistakes.
However I'd also advise you, use PyPI as the source of truth about releases, not GitHub. I've seen other projects with worse organization - e.g. the release tag accidentally not pushed to the repo. You can always check PyPI, especially when using a tool like pipenv or pip-compile to manage your deps.

Sorry, I don't use GitHub releases for any other projects so wasn't aware of what that page was showing. The GitHub UI is a bit nasty there, folding up newer tags because the repo owner hasn't created a "release" object.

Yeah, that's what tricked me :smile:

However I'd also advise you, use PyPI as the source of truth about releases, not GitHub. I've seen other projects with worse organization - e.g. the release tag accidentally not pushed to the repo. You can always check PyPI, especially when using a tool like pipenv or pip-compile to manage your deps..

Thanks for the suggestion, when I found out I was using an older version, I checked on PyPI indeed.


Graphcast improvements part II

Modulus Pull Request
Description

Closes https://github.com/NVIDIA/modulus/issues/530, https://github.com/NVIDIA/modulus/issues/555
Checklist

[x] I am familiar with the Contributing Guidelines.
[x] New or existing tests cover these changes.
[x] The documentation is up to date with these changes.
[x] The CHANGELOG.md is up to date with these changes.
[x] An issue is linked to this pull request.

Dependencies

/blossom-ci

/blossom-ci

/blossom-ci


SoundCloud URLs with very little time of life

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2018.10.05. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2018.10.05

Before submitting an issue make sure you have:

[x] At least skimmed through the README, most notably the FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones
[x] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[ ] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[x] Question
[ ] Other

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
youtube-dl -g --restrict-filenames -v https://soundcloud.com/france-dj/d

j-france-rage-dubstep-2014
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-g', '--restrict-filenames', '-v', 'https://soundcl
oud.com/france-dj/dj-france-rage-dubstep-2014']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2018.10.05
[debug] Python version 3.4.4 (CPython) - Windows-8.1-6.3.9600
[debug] exe versions: none
[debug] Proxy map: {}
[debug] Default format spec: bestvideo+bestaudio/best

https://cf-media.sndcdn.com/poj3MfLbhE50.128.mp3?Policy=eyJTdGF0ZW1lbnQiOlt7IlJl
c291cmNlIjoiKjovL2NmLW1lZGlhLnNuZGNkbi5jb20vcG9qM01mTGJoRTUwLjEyOC5tcDMiLCJDb25k
aXRpb24iOnsiRGF0ZUxlc3NUaGFuIjp7IkFXUzpFcG9jaFRpbWUiOjE1Mzg4NjU5MTZ9fX1dfQ__&Sig
nature=O2xfr0aujOaDlyh4IOGbm2VdkMT3WQIXOz5UK-FcH0TYDJYgLGjr4Hsh5HHShKb26TufFl2-N
4YLLTUe7ufwrGSL38f2G12-yHcdjpmW-6cy8O6STSzpf8RpuSZQEUJERGVYmwqGWeUZcOJXENhWzbw-2
Sc1nueGxTBbz1Rvf0d9T1UN53cOF8QqhLeEW46s7Sy3xQa8XSMj7GaIuQnZMFfXyHvNh8rqOcJL7bGgx
9gnsiNt60JmJKIdcj088Ge3aUUT0F677YB7UMZZdfLuMGj4FV-qvvJZcykFbv~WoCqT46mQuJl8rqe0h
N8veIrSijExsj5oGg5EFzIWaKRWDw__&Key-Pair-Id=APKAJAGZ7VMH2PFPW6UQ

Description of your issue, suggested solution and other information
The URL that starts with "cf-media." provided by youtube-dl for SoundCloud tracks, has a very little time of life, of about 15-20 minutes, past this time URL returns a lovely "Forbidden".
I would like to know if there're any ways to obtain URLs with longer time of life?

No way.

Other question; is it possible to block the downloading of a file by youtube-dl after certain size? I mean, after 15 mb downloaded, stop the download? So I can play the mp3, listen to what equals to 15 mb?

Ctrl+C.

Yeah, but I mean reproduce this exact action with commands & options?

Not possible.


Update to futures-preview 0.3.0-alpha.17

try_ready! macro was removed, rust-lang-nursery/futures-rs#1602
Sink::SinkError was renamed to Sink::Error

The test failed because FnBox has been removed from std, and libtest outdated, waiting for rust-lang/libtest#19 (Tested locally, all passed)

LGTM. Let's hope async closures don't break too often.

@iovxw the libtest failures should be fixed now, if you merge to master.


Please expand on your vulnerability report

In https://github.com/google/security-research/security/advisories/GHSA-mjmj-j48q-9wg2
you call out that snakeyaml has a vulnerability in version 1.30 and that the vulnerability has been disclosed. You do not however call out any fixes in either artifact versions or commits. The developers don't seem to have added any clearly related commits after your disclosure date and it's left ambiguous to the reader if a fix exists or is planned.
Commit log: https://bitbucket.org/snakeyaml/snakeyaml/commits/

The vulnerability still exists. Upgrading won't fix the issue unfortunately.  We recommend using SnakeYaml's SafeConsturctor when parsing untrusted content, as it restricts deserialization to only primitive types, thus preventing exploitation.


fix(ssr): match phrasing content validation to HTML spec

fixes #3257
fixes #2431
What is it?

[ ] Feature / enhancement
[x] Bug
[ ] Docs / tests

Description
There is some phrasing content that we still throw validation errors on, for example  elements.
In terms of provenance, I generated this list by going to https://html.spec.whatwg.org/multipage/dom.html#phrasing-content-2 and running this command:
JSON.stringify([...document.getElementById('phrasing-content').nextElementSibling.nextElementSibling.querySelectorAll('code')].map(e => e.textContent).reduce((acc, el) => {
  acc[el] = true
  return acc
}, {keygen: true, command: true} /* These were already present but not in this list */), null, 2)

Use cases and why
People want to be able to use HTML elements that are valid to use according to the spec
Checklist:

[x] My code follows the developer guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[x] Added new tests to cover the fix / functionality

rehype-katex and remark-math also fails the validations, could this pr also fix this?
https://stackblitz.com/edit/qwik-starter-nf8x9s?file=src%2Froutes%2Findex.mdx
$\KaTeX$

[vite] Internal server error: <semantics> can not be rendered because one of its ancestor is a
 or a
.

@swwind thanks for flagging that. Since <semantics> is always used inside <math> elements, I generalized IS_SVG to IS_PHRASING_CONTAINER which applies to both math and svg.

This is amazing!!

Thank you for this update.
Just to clarify the behaviour: does this mean react elements cannot be rendered (even if the element is a wrapper around valid phrasing content like an anchor)…?
Many thanks!
For more context: I am seeing the following when attempting to run (QwikifedReactComponent wraps an ):
import { ReactComponent } from '@my/library';

const QwikifedReactComponent = qwikify$(ReactComponent)

component$(() => {
  return
Text before <QwikifedReactComponent>a link</QwikifedReactComponent> and text after.
;
});

[vite] Internal server error: <qwik-react> can not be rendered because one of its ancestor is a
 or a
.

This goes against the HTML spec: https://html.spec.whatwg.org/multipage/dom.html#phrasing-content-2

Obviously no issue with including the
 in a new React component and then qwikifying this component.

@cmbartschat Now I found <rp> element also can not be rendered!
Could it be fixed by adding a new tagName === "ruby" in this line?
https://github.com/BuilderIO/qwik/blob/3a70dbf208fdac109c570c6cb7fb09ae0edb32c9/packages/qwik/src/core/render/ssr/render-ssr.ts#LL685C1-L685C1


conversion goal category requirements

Docs Build status updates of commit a69864e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Advertising/bingads-13/campaign-management-service/appinstallgoal.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/durationgoal.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/eventgoal.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/instoretransactiongoal.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/offlineconversiongoal.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/pagesviewedpervisitgoal.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/urlgoal.md
:white_check_mark:Succeeded

Advertising/bingads-13/guides/release-notes.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Memory driver Query should return ErrReleaseNotFound for zero results

Alternative to #7368 , see that PR for background.
The Storage.History method, which just calls s.Driver.Query, claims that it returns ErrReleaseNotFound if no such release name exists. This is the case when the driver is the ConfigMaps driver, the Query of which explicitly returns ErrReleaseNotFound. But the MemoryDriver just happily returns an empty list of releases, which is inconsistent.
This PR updates and tests the memory driver to be consistent. As mentioned on #7368, a test error then shows up in TestRollbackRelease [1], the cause of which is that all the test cases were using the same (mutable) data, rather than generating test data for each test (which this PR does).
[1] The reason it only shows up with this change is because TestRollbackRelease after running the first test successfully (which updated the test data), was then not erroring when it failed to find the release.
cc @latiif @SimonAlling
Signed-off-by: Michael Nelson<EMAIL_ADDRESS>

Nice job! We think this check can also be removed, since it's made obsolete by your changes to the Memory driver (and it returns the wrong error anyway):
diff --git a/pkg/action/uninstall.go b/pkg/action/uninstall.go
index dfaa9847..87098c5b 100644
--- a/pkg/action/uninstall.go
+++ b/pkg/action/uninstall.go
@@ -70,9 +70,6 @@ func (u *Uninstall) Run(name string) (*release.UninstallReleaseResponse, error)
        if err != nil {
                return nil, errors.Wrapf(err, "uninstall: Release not loaded: %s", name)
        }
-       if len(rels) < 1 {
-               return nil, errMissingRelease
-       }

        releaseutil.SortByRevision(rels)
        rel := rels[len(rels)-1]

Nice job! We think this check can also be removed, since it's made obsolete by your changes to the Memory driver (and it returns the wrong error anyway):
diff --git a/pkg/action/uninstall.go b/pkg/action/uninstall.go
index dfaa9847..87098c5b 100644
--- a/pkg/action/uninstall.go
+++ b/pkg/action/uninstall.go
@@ -70,9 +70,6 @@ func (u *Uninstall) Run(name string) (*release.UninstallReleaseResponse, error)
        if err != nil {
                return nil, errors.Wrapf(err, "uninstall: Release not loaded: %s", name)
        }
-       if len(rels) < 1 {
-               return nil, errMissingRelease
-       }

        releaseutil.SortByRevision(rels)
        rel := rels[len(rels)-1]

Yes - indeed, that was where we started on this yak-shaving experience, wasn't it :) Updating... Thanks!

Hi @absoludity I agree with the memory driver change. But the sql driver deserves a second look.
Maybe the check for sql driver should change from
	if len(releases) == 0 {
		return nil, ErrReleaseNotFound

to
	if len(records) == 0 {
		return nil, ErrReleaseNotFound

so that it's consistent with secret and cfgmap.
I think if the release exists, but all the decoding fails and its going to return an empty array then that should be a new error (not ErrReleaseNotFound) but something that tells the user, release exists but it fails to decode it. Maybe the comment for History can mention the fact that empty return doesn't mean the release doesn't exists. What do you think?

Hi @absoludity I agree with the memory driver change. But the sql driver deserves a second look.
Maybe the check for sql driver should change from
	if len(releases) == 0 {
		return nil, ErrReleaseNotFound

to
	if len(records) == 0 {
		return nil, ErrReleaseNotFound

so that it's consistent with secret and cfgmap.

+1, I agree with your #8470 :)

I think if the release exists, but all the decoding fails and its going to return an empty array then that should be a new error (not ErrReleaseNotFound) but something that tells the user, release exists but it fails to decode it. Maybe the comment for History can mention the fact that empty return doesn't mean the release doesn't exists. What do you think?

Makes sense, yes. I'm not sure this PR is going to get any more attention. Perhaps it's worth doing the two smaller changes in isolation that I've got here (the memory driver, and the update action, as the update action change is the one which worried Matt, I think).

Closing this, since the main change to update the memory driver landed as part of https://github.com/helm/helm/commit/1ab52fa79c100332bc8014095cf7aed6937cae8a , as mentioned by @mikeshng .

Thanks for your effort on this @absoludity. This will feed into improving consistency in the driver area.


MariaDB doesn't appear in the topology view and is completely not recognized by SkyWalking

Please answer these questions before submitting your issue.

Why do you submit this issue?
[x] Question or discussion
[x] Bug
[ ] Requirement
[x] Feature or performance improvement

Question

What do you want to know?
I'd like to monitor my Liferay Portal CE 7.2 GA1 instance with Apache SkyWalking 6.5.0. Liferay is a Java CMS. On that DEV environment following software is installed: Ubuntu 18.04.3 LTS, OpenJDK 11.0.4, Apache Tomcat 9.0.17 and MariaDB 10.1.41 as Liferay storage.

In than configuration the MariaDB database is not recognized by SkyWalking completely.
On a different VM with Ubuntu 19.10, Azul Zulu JDK 11.0.5 and MySQL 5.7.28 Skywalking recognizes the DB just fine. On that environment the DB is a different server, on the first one everything is on one machine.
Is that a bug or SkyWalking just doesn't work with MariaDB and it's a missing Feature? Or coud it be a configuration issue? (Config is on both environments is similar).
Thank you.

Bug

Which version of SkyWalking, OS and JRE?
SkyWalking 6.5.0, Ubuntu 18.04.3 LTS, OpenJDK 11.0.4, Apache Tomcat 9.0.17 and MariaDB 10.1.41

Which company or project?

What happen?
If possible, provide a way for reproducing the error. e.g. demo application, component version.
SkyWalking doesn't "see" the MariaDB database of the monitored application.

Requirement or improvement

Please describe about your requirements or improvement suggestions.

Do you read the supported-list doc? https://github.com/apache/skywalking/blob/master/docs/en/setup/service-agent/java-agent/README.md#supported-middleware-framework-and-library. SkyWalking's auto-detection is totally based on variable plugins. I am assuming the MariaDB has its own driver, right?
Could you try to follow MySQL driver plugin and contribute one to us?

I have migrated the my DB from MariaDB to MySQL. Now tracing works.

I see. I still hope someone could contribute MariaDB driver plugin

@TigerIcecold The plugin has been provided.


adds transformer logic and CLI

closes https://github.com/inveniosoftware/invenio-vocabularies/issues/85
closes https://github.com/inveniosoftware/invenio-vocabularies/issues/89

Sample commands
Import
invenio vocabularies import -v names -o "/.../ORCID_2020_10_summaries.tar.gz"
-n 1000

Outputs
ServiceWriter: [{'ValidationError': {'family_name': ['Field may not be null.']}}]
OrcidXMLTransformer: Record not found in ORCiD entry.
ServiceWriter: [{'ValidationError': {'family_name': ['Field may not be null.']}}]
...
Number of samples reached 1000
Vocabulary names loaded. Total items 1000.
960 items succeeded, 40 contained errors.

Left it running for around 100k, there were 3k errors (3-4%). All of them were one of the above (missing record of part of the name)
Convert
invenio vocabularies convert -v names -o "/.../ORCID_2020_10_summaries.tar.gz" -t "/.../test_orcid.yaml" -n 10

Sample of the produced file:
- affiliations: []
  family_name: Vilela Santos
  given_name: Cristiano
  identifiers:
  - identifier: https://orcid.org/0000-0001-5014-4000
    scheme: orcid
- affiliations: []
  family_name: Olonilua
  given_name: Oluponmile
  identifiers:
  - identifier: https://orcid.org/0000-0001-5087-3000
    scheme: orcid
- affiliations:
  - name: PCSIR Labs. Complex, Ferozepur Road
  family_name: Sabri
  given_name: Muhammad Usman
  identifiers:
  - identifier: https://orcid.org/0000-0001-5042-7000
    scheme: orcid
- affiliations: []
  family_name: de Medeiros
  given_name: "Jo\xE3o Vitor"
  identifiers:
  - identifier: https://orcid.org/0000-0001-5022-4000
    scheme: orcid
- affiliations: []
  family_name: Hopcroft
  given_name: Russell
  identifiers:
  - identifier: https://orcid.org/0000-0001-5021-6000
    scheme: orcid
- affiliations: []
  family_name: "\u0426\u0430\u0440\u0430\u043A\u0430\u0435\u0432\u0430"
  given_name: "\u0415\u043A\u0430\u0442\u0435\u0440\u0438\u043D\u0430"
  identifiers:
  - identifier: https://orcid.org/0000-0001-5104-0000
    scheme: orcid

Included in #117.


LUN-264: Locking lane for exercises screen

This pull request belongs to an issue on our bugtracker.
You can find it there by looking for an issue with the key which is mentioned in the title of this pull request.
It starts with the keyword LUN.

Is something else required for this to work? It shows the checkmark for all exercises except from an empty circle for the write exercise for me. When I complete the write exercise, it stays the same. This is the case for ALL disciplines. Looking good except from that though, I like the design.

This ticket is just for design. You can change hardCoded status in ExercisesScreen.tsx to see how it looks for no or one exercises finished. Logic will be done in next ticket.


Where to find an address of Community Pool of Cosmos Network

Try to find any information about address of Community Pool of Cosmos Network, and can't find it.
Maybe somebody knows where to find it?

No but I intend to answer your question shortly


chore: Set up development environment

This is essentially using the same setup as the JVM library. For example:

CI runs on Linux/macOS/Windows and Java 8/11.
100% unit test coverage required.
ktlint is run on CI. To reformat code locally, run ./gradlew spotlessApply
Each push to master gets released automatically to Bintray/JCenter if all tests pass. (We're using semantic-release for this, and that's why we need the Node.js files package.json and package-lock.json)

I already created a package on Bintray, and will be requesting its inclusion on JCenter once this PR is merged.
Fixes #2

Adding Sergio to the review, in case he can have a look at this one first. I think one reviewer will suffice though.


Minor diagnostics and stability improvements.

May help investigating #170, #181

I tried this version, it dosen't even find Visual Studio on available platform now.

and still emits "Invalied backend promise"

seems newest version of Visual Studio's vcvarsall.bat doesn't supports without selecting platform.
Error runnig C:\Program Files (x86)\Microsoft Visual Studio\Shared\14.0\VC\vcvarsall.bat Error in script usage. The correct usage is:
    "C:\Program Files (x86)\Microsoft Visual Studio\Shared\14.0\VC\vcvarsall.bat" [option]
  or
    "C:\Program Files (x86)\Microsoft Visual Studio\Shared\14.0\VC\vcvarsall.bat" [option] store
  or
    "C:\Program Files (x86)\Microsoft Visual Studio\Shared\14.0\VC\vcvarsall.bat" [option] [version number]
  or
    "C:\Program Files (x86)\Microsoft Visual Studio\Shared\14.0\VC\vcvarsall.bat" [option] store [version number]
where [option] is: x86 | amd64 | arm | x86_amd64 | x86_arm | amd64_x86 | amd64_arm
where [version number] is either the full Windows 10 SDK version number or "8.1" to use the windows 8.1 SDK
:
The store parameter sets environment variables to support
  store (rather than desktop) development.
:
For example:
    "C:\Program Files (x86)\Microsoft Visual Studio\Shared\14.0\VC\vcvarsall.bat" x86_amd64
    "C:\Program Files (x86)\Microsoft Visual Studio\Shared\14.0\VC\vcvarsall.bat" x86_arm store
    "C:\Program Files (x86)\Microsoft Visual Studio\Shared\14.0\VC\vcvarsall.bat" x86_amd64 10.0.10240.0
    "C:\Program Files (x86)\Microsoft Visual Studio\Shared\14.0\VC\vcvarsall.bat" x86_arm store 10.0.10240.0
    "C:\Program Files (x86)\Microsoft Visual Studio\Shared\14.0\VC\vcvarsall.bat" x64 8.1
    "C:\Program Files (x86)\Microsoft Visual Studio\Shared\14.0\VC\vcvarsall.bat" x64 store 8.1
:
Please make sure either Visual Studio or C++ Build SKU is installed.
rejected promise not handled within 1 second

Detecting environment: Visual Studio Community 2017 - x86
Detecting environment: Visual Studio Community 2017 - amd64
Detecting environment: Visual Studio Community 2017 - arm
Error runnig C:\Program Files (x86)\Microsoft Visual Studio\Shared\14.0\VC\vcvarsall.bat Error in script usage. The correct usage is:
    "C:\Program Files (x86)\Microsoft Visual Studio\Shared\14.0\VC\vcvarsall.bat" [option]
  or
    "C:\Program Files (x86)\Microsoft Visual Studio\Shared\14.0\VC\vcvarsall.bat" [option] store
  or
    "C:\Program Files (x86)\Microsoft Visual Studio\Shared\14.0\VC\vcvarsall.bat" [option] [version number]
  or
    "C:\Program Files (x86)\Microsoft Visual Studio\Shared\14.0\VC\vcvarsall.bat" [option] store [version number]
where [option] is: x86 | amd64 | arm | x86_amd64 | x86_arm | amd64_x86 | amd64_arm
where [version number] is either the full Windows 10 SDK version number or "8.1" to use the windows 8.1 SDK
:
The store parameter sets environment variables to support
  store (rather than desktop) development.
:
For example:
    "C:\Program Files (x86)\Microsoft Visual Studio\Shared\14.0\VC\vcvarsall.bat" x86_amd64
    "C:\Program Files (x86)\Microsoft Visual Studio\Shared\14.0\VC\vcvarsall.bat" x86_arm store
    "C:\Program Files (x86)\Microsoft Visual Studio\Shared\14.0\VC\vcvarsall.bat" x86_amd64 10.0.10240.0
    "C:\Program Files (x86)\Microsoft Visual Studio\Shared\14.0\VC\vcvarsall.bat" x86_arm store 10.0.10240.0
    "C:\Program Files (x86)\Microsoft Visual Studio\Shared\14.0\VC\vcvarsall.bat" x64 8.1
    "C:\Program Files (x86)\Microsoft Visual Studio\Shared\14.0\VC\vcvarsall.bat" x64 store 8.1
:
Please make sure either Visual Studio or C++ Build SKU is installed.

Loading environments
Loading CMake Tools from c:\llvm\.vscode\.cmaketools.json
Error runnig C:\Program Files (x86)\Microsoft Visual Studio\Shared\14.0\VC\vcvarsall.bat Error in script usage. The correct usage is:
    "C:\Program Files (x86)\Microsoft Visual Studio\Shared\14.0\VC\vcvarsall.bat" [option]
  or
    "C:\Program Files (x86)\Microsoft Visual Studio\Shared\14.0\VC\vcvarsall.bat" [option] store
  or
    "C:\Program Files (x86)\Microsoft Visual Studio\Shared\14.0\VC\vcvarsall.bat" [option] [version number]
  or
    "C:\Program Files (x86)\Microsoft Visual Studio\Shared\14.0\VC\vcvarsall.bat" [option] store [version number]
where [option] is: x86 | amd64 | arm | x86_amd64 | x86_arm | amd64_x86 | amd64_arm
where [version number] is either the full Windows 10 SDK version number or "8.1" to use the windows 8.1 SDK
:
The store parameter sets environment variables to support
  store (rather than desktop) development.
:
For example:
    "C:\Program Files (x86)\Microsoft Visual Studio\Shared\14.0\VC\vcvarsall.bat" x86_amd64
    "C:\Program Files (x86)\Microsoft Visual Studio\Shared\14.0\VC\vcvarsall.bat" x86_arm store
    "C:\Program Files (x86)\Microsoft Visual Studio\Shared\14.0\VC\vcvarsall.bat" x86_amd64 10.0.10240.0
    "C:\Program Files (x86)\Microsoft Visual Studio\Shared\14.0\VC\vcvarsall.bat" x86_arm store 10.0.10240.0
    "C:\Program Files (x86)\Microsoft Visual Studio\Shared\14.0\VC\vcvarsall.bat" x64 8.1
    "C:\Program Files (x86)\Microsoft Visual Studio\Shared\14.0\VC\vcvarsall.bat" x64 store 8.1
:
Please make sure either Visual Studio or C++ Build SKU is installed.

seems that is my problom, lol
PS C:\Program Files (x86)\Microsoft Visual Studio\Shared\14.0\VC> ./vcvarsall.bat x86_amd64
Error in script usage. The correct usage is:
    "C:\Program Files (x86)\Microsoft Visual Studio\Shared\14.0\VC\vcvarsall.bat" [option]
  or
    "C:\Program Files (x86)\Microsoft Visual Studio\Shared\14.0\VC\vcvarsall.bat" [option] store
  or
    "C:\Program Files (x86)\Microsoft Visual Studio\Shared\14.0\VC\vcvarsall.bat" [option] [version number]
  or
    "C:\Program Files (x86)\Microsoft Visual Studio\Shared\14.0\VC\vcvarsall.bat" [option] store [version number]
where [option] is: x86 | amd64 | arm | x86_amd64 | x86_arm | amd64_x86 | amd64_arm
where [version number] is either the full Windows 10 SDK version number or "8.1" to use the windows 8.1 SDK
:
The store parameter sets environment variables to support
  store (rather than desktop) development.
:
For example:
    "C:\Program Files (x86)\Microsoft Visual Studio\Shared\14.0\VC\vcvarsall.bat" x86_amd64
    "C:\Program Files (x86)\Microsoft Visual Studio\Shared\14.0\VC\vcvarsall.bat" x86_arm store
    "C:\Program Files (x86)\Microsoft Visual Studio\Shared\14.0\VC\vcvarsall.bat" x86_amd64 10.0.10240.0
    "C:\Program Files (x86)\Microsoft Visual Studio\Shared\14.0\VC\vcvarsall.bat" x86_arm store 10.0.10240.0
    "C:\Program Files (x86)\Microsoft Visual Studio\Shared\14.0\VC\vcvarsall.bat" x64 8.1
    "C:\Program Files (x86)\Microsoft Visual Studio\Shared\14.0\VC\vcvarsall.bat" x64 store 8.1
:
Please make sure either Visual Studio or C++ Build SKU is installed.

new located Visual Studio 15 2017 version of vcvarsall is [Program Files]/Microsoft Visual Studio/2017/Community/VC/Auxiliary/Build

And seems this condition not even working.

Bugs everywhere... in my opinion, this extension looks pretty dirty, needs refactoring.

@ArtBlnd Thanks for your investigation and pointing at issues with this PR, I've managed to reproduce it.
VS 2015's and older vcvars apparently don't return proper error code so looking for pattern is necessary.

Sorry for the slow. I'll get this out.


Clarify firewall access requirements for consuming Artifacts nuget feeds

Similar to issue #3801 .
My organisation is in West Europe. My build agent is running on premise and all traffic goes through a firewall. I have to white list traffic to be allowed from the agent. I have white listed *.dev.azure.com (and others, like mentioned on ). However a nuget restore still fails from my Azure Artifacts feeds.
I noticed when looking at the traffic that after https://pkgs.dev.azure.com/{myorg}/... the agent tries to go to https://08wvsblobprodsu6weus73.blob.core.windows.net/... . It seems that the package is being pulled from Azure Storage. However I can't allow wild card *.blob.core.windows.net to be access from the agent.
Is there any list of the endpoints that I need to allow for the nuget feeds from Azure Artifacts (from West Europe region)?
(Logged on https://developercommunity.visualstudio.com/content/problem/806256/clarify-firewall-access-requirements-for-consuming.html as well.)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 899a78d6-9d08-7744-108d-10add2ba7e2c
Version Independent ID: 6ab31e96-fed8-4335-ed81-b97663d8300f
Content: Consume NuGet packages in Visual Studio
Content Source: docs/artifacts/nuget/consume.md
Product: devops
Technology: devops-artifacts
GitHub Login: @chasewilson
Microsoft Alias: phwilson

@Styxxy -- Hans, thank you for your feedback, and for adding it to the developer community site.
@chasewilson -- Chase, please look into this issue.

Any progress on this one? It is really a blocking issue... We have seen already multiple attack attempts with downloads from Azure Storage (not yet from public azure artifacts, but it is only a matter of time).
We really do which to limit the traffic to:

Azure Region for our Azure Organization (+ DRP scenario): in my case this would be West Europe (+ North Europe)
Scope it to our corporate owned Azure DevOps Organizations

Below the storage shard list I was able to obtain for West Europe. Ideally we can retrieve this list (+ for other regions) from a globally available/published list, like the Azure Cloud list.
mzgvsblobprodsu6weus1.blob.core.windows.net
n4pvsblobprodsu6weus2.blob.core.windows.net
w25vsblobprodsu6weus3.blob.core.windows.net
fmzvsblobprodsu6weus4.blob.core.windows.net
uh6vsblobprodsu6weus5.blob.core.windows.net
w2vvsblobprodsu6weus6.blob.core.windows.net
w0cvsblobprodsu6weus7.blob.core.windows.net
pv3vsblobprodsu6weus8.blob.core.windows.net
23lvsblobprodsu6weus9.blob.core.windows.net
elgvsblobprodsu6weus10.blob.core.windows.net
xojvsblobprodsu6weus11.blob.core.windows.net
xuavsblobprodsu6weus12.blob.core.windows.net
2dbvsblobprodsu6weus13.blob.core.windows.net
ao9vsblobprodsu6weus14.blob.core.windows.net
xlmvsblobprodsu6weus15.blob.core.windows.net
jnjvsblobprodsu6weus16.blob.core.windows.net
n19vsblobprodsu6weus17.blob.core.windows.net
24uvsblobprodsu6weus18.blob.core.windows.net
kwrvsblobprodsu6weus19.blob.core.windows.net
1hhvsblobprodsu6weus20.blob.core.windows.net
wravsblobprodsu6weus21.blob.core.windows.net
cknvsblobprodsu6weus22.blob.core.windows.net
79tvsblobprodsu6weus23.blob.core.windows.net
oglvsblobprodsu6weus24.blob.core.windows.net
corvsblobprodsu6weus25.blob.core.windows.net
323vsblobprodsu6weus26.blob.core.windows.net
9ajvsblobprodsu6weus27.blob.core.windows.net
tmhvsblobprodsu6weus28.blob.core.windows.net
41hvsblobprodsu6weus29.blob.core.windows.net
iosvsblobprodsu6weus30.blob.core.windows.net
cfyvsblobprodsu6weus31.blob.core.windows.net
57ivsblobprodsu6weus32.blob.core.windows.net
yr3vsblobprodsu6weus33.blob.core.windows.net
fx1vsblobprodsu6weus34.blob.core.windows.net
ikavsblobprodsu6weus35.blob.core.windows.net
6egvsblobprodsu6weus36.blob.core.windows.net
684vsblobprodsu6weus37.blob.core.windows.net
o78vsblobprodsu6weus38.blob.core.windows.net
ijgvsblobprodsu6weus39.blob.core.windows.net
ollvsblobprodsu6weus40.blob.core.windows.net
njbvsblobprodsu6weus41.blob.core.windows.net
nsevsblobprodsu6weus42.blob.core.windows.net
mz5vsblobprodsu6weus43.blob.core.windows.net
lnxvsblobprodsu6weus44.blob.core.windows.net
x7evsblobprodsu6weus45.blob.core.windows.net
vb8vsblobprodsu6weus46.blob.core.windows.net
9zpvsblobprodsu6weus47.blob.core.windows.net
9qavsblobprodsu6weus48.blob.core.windows.net
3u7vsblobprodsu6weus49.blob.core.windows.net
qkyvsblobprodsu6weus50.blob.core.windows.net
s8svsblobprodsu6weus51.blob.core.windows.net
pfcvsblobprodsu6weus52.blob.core.windows.net
dshvsblobprodsu6weus53.blob.core.windows.net
308vsblobprodsu6weus54.blob.core.windows.net
vh9vsblobprodsu6weus55.blob.core.windows.net
si5vsblobprodsu6weus56.blob.core.windows.net
nu4vsblobprodsu6weus57.blob.core.windows.net
eupvsblobprodsu6weus58.blob.core.windows.net
i40vsblobprodsu6weus59.blob.core.windows.net
a8zvsblobprodsu6weus60.blob.core.windows.net
buqvsblobprodsu6weus61.blob.core.windows.net
bwlvsblobprodsu6weus62.blob.core.windows.net
pyvvsblobprodsu6weus63.blob.core.windows.net
l78vsblobprodsu6weus64.blob.core.windows.net
fqqvsblobprodsu6weus65.blob.core.windows.net
kx9vsblobprodsu6weus66.blob.core.windows.net
qvsvsblobprodsu6weus67.blob.core.windows.net
w8hvsblobprodsu6weus68.blob.core.windows.net
alcvsblobprodsu6weus69.blob.core.windows.net
8bwvsblobprodsu6weus70.blob.core.windows.net
5bsvsblobprodsu6weus71.blob.core.windows.net
s83vsblobprodsu6weus72.blob.core.windows.net
08wvsblobprodsu6weus73.blob.core.windows.net
6wovsblobprodsu6weus74.blob.core.windows.net
y78vsblobprodsu6weus75.blob.core.windows.net
m8vvsblobprodsu6weus76.blob.core.windows.net
dgsvsblobprodsu6weus77.blob.core.windows.net
ohxvsblobprodsu6weus78.blob.core.windows.net
pizvsblobprodsu6weus79.blob.core.windows.net
r23vsblobprodsu6weus80.blob.core.windows.net
kd2vsblobprodsu6weus81.blob.core.windows.net
fv1vsblobprodsu6weus82.blob.core.windows.net
9mmvsblobprodsu6weus83.blob.core.windows.net
af3vsblobprodsu6weus84.blob.core.windows.net
aaevsblobprodsu6weus85.blob.core.windows.net
6iwvsblobprodsu6weus86.blob.core.windows.net
m1evsblobprodsu6weus87.blob.core.windows.net
lf4vsblobprodsu6weus88.blob.core.windows.net
wg0vsblobprodsu6weus89.blob.core.windows.net
va5vsblobprodsu6weus90.blob.core.windows.net

There is a range of IPs updated weekly for azure storage split by region in the Azure DevOps docs: https://docs.microsoft.com/en-us/azure/devops/organizations/security/allow-list-ip-url?view=azure-devops#azure-artifacts

@magleaso

There is a range of IPs updated weekly for azure storage split by region in the Azure DevOps docs: https://docs.microsoft.com/en-us/azure/devops/organizations/security/allow-list-ip-url?view=azure-devops#azure-artifacts

The global list is not sufficient. It is really important to adhere to many security standards, one of those being only allow outbound traffic that you know and wish to allow. In this case:

Only allow the endpoints for Azure DevOps Artificats
Through deeper inspection, scope these (multi-tenant) endpoints to our own trusted organization(s).

Why we would do this? In an enterpise setting, we uphold the "assume breach" principle (Microsoft even advocates this themselves! A read about O365 (but accounts for all situations): https://docs.microsoft.com/en-us/office365/enterprise/office-365-monitoring-and-testing#assume-breach-methodology).
This means, if we are breached: make sure the attacker / malware can't download nor upload to any other source (eg command endpoint). In this case, we already start limiting the scope of potential endpoints that can be used to Azure DevOps (artifacts) alone (see (1)). And even further, we can mitigate more if we trust our own Azure DevOps organization (see (2)), otherwise the attacker could still pull their stuff from their own organization.

@Styxxy Thank you for your feedback. This seems more like a product question rather than a documentation issue but I will be happy to help find an answer for you
@samuelkoppes Do you have any input on this one?

@Styxxy Thank you for your feedback. This seems more like a product question rather than a documentation issue but I will be happy to help find an answer for you
@samuelkoppes Do you have any input on this one?

Therefore I opened the ticket on developer community, and here to reflect the information in the docs.
This is an important part of the docs, especially for organizations who docare about thight security and defense in depth.

Just to give some clarity on what is happening here: Artifacts stores content in Azure Storage, and when customers access packages in some use cases we redirect the client to Azure Storage to download the package content. In order for this to work, access to Azure Storage must be provided through the corporate firewall. If there are concerns about how Azure Storage manages their public endpoints, I would encourage you to contact customer support and share your request for routing to the storage team.

@Styxxy Thank you for your feedback. I added it as a prerequisite to the getting started article.

@ramiMSFT Doesn't help me one bit further... The service around Azure Artifacts is quite bad, very disappointed in Microsoft and their security concerns. Definitely will let my account manager know through our EA program.

Did this ever get resolved? I too am in the same boat and need the list of storage accounts

Did this ever get resolved? I too am in the same boat and need the list of storage accounts

Unfortunately not. We compiled a list of endpoints through monitoring and trial. It is a bit of an upkeep to have the list up-to-date.

I have raised a case with MS support - I'll update this thread with their feedback.
To simply resolve this, since Azure Devops is bound to a billing subscription - it would have made sense for the storage accounts to also have been created in the billing subscription too - that way we can see them.

@piroinno -- Peter, thank you for your follow-up.  Please consider these resources:

Azure DevOps Services
Azure DevOps on Stack Overflow

I have raised a case with MS support - I'll update this thread with their feedback.
To simply resolve this, since Azure Devops is bound to a billing subscription - it would have made sense for the storage accounts to also have been created in the billing subscription too - that way we can see them.

My team is running into the same issue. We're opening up a support item too. Seems a little silly it's been 3 years and this is still an issue!

I have raised a case with MS support - I'll update this thread with their feedback.
To simply resolve this, since Azure Devops is bound to a billing subscription - it would have made sense for the storage accounts to also have been created in the billing subscription too - that way we can see them.

We escalated our question to Microsoft and there is no way to address this issue at the moment. They asked us to raise a Developer Community suggestion, which I've just done: https://developercommunity.visualstudio.com/t/Add-ability-to-whitelist-requests-to-pri/10143620

@john--  and @piroinno - reference Case ID<PHONE_NUMBER>005800 when reaching out to support.

@johnterickson Thanks. Support has already closed closed our ticket, though.

Any progress on this one @WilliamAntonRohm @ramiMSFT @mijacobs ? It is really a blocking issue...
We have seen already multiple attack attempts with downloads from Azure Storage (not yet from public azure artifacts, but it is only a matter of time).
We really do which to limit the traffic to:

Azure Region for our Azure Organization (+ DRP scenario): in my case this would be West Europe (+ North Europe)
Scope it to our corporate owned Azure DevOps Organizations

I couldn't find yet the fully endpoint construct of the storage account links. When restoring from nuget feed, or downloading a published artifact, it will pull the data from pkgs.dev.azure.com/<myorganization>/..., but this request will return a "see other location" with a link to the storage. From what I have seen from my proxy server, this contains the structure below. However I couldn't figure out yet the full structure that I can generate:
<storageshard>.blob.core.windows.net/<guid>/...
<storageshard>.blob.core.windows.net/A<guid>/...
<storageshard>.blob.core.windows.net/b-<guid-without-dashes>/...
<storageshard>.blob.core.windows.net/db<guid-without-dashes>/...

_Note: you can get your organization guid from https://app.vssps.visualstudio.com/apis/accounts !
Below the storage shard list I was able to obtain for West Europe. Ideally we can retrieve this list (+ for other regions) from a globally available/published list, like the Azure Cloud list.
Click to expand (West Europe list)!
mzgvsblobprodsu6weus1.blob.core.windows.net
n4pvsblobprodsu6weus2.blob.core.windows.net
w25vsblobprodsu6weus3.blob.core.windows.net
fmzvsblobprodsu6weus4.blob.core.windows.net
uh6vsblobprodsu6weus5.blob.core.windows.net
w2vvsblobprodsu6weus6.blob.core.windows.net
w0cvsblobprodsu6weus7.blob.core.windows.net
pv3vsblobprodsu6weus8.blob.core.windows.net
23lvsblobprodsu6weus9.blob.core.windows.net
elgvsblobprodsu6weus10.blob.core.windows.net
xojvsblobprodsu6weus11.blob.core.windows.net
xuavsblobprodsu6weus12.blob.core.windows.net
2dbvsblobprodsu6weus13.blob.core.windows.net
ao9vsblobprodsu6weus14.blob.core.windows.net
xlmvsblobprodsu6weus15.blob.core.windows.net
jnjvsblobprodsu6weus16.blob.core.windows.net
n19vsblobprodsu6weus17.blob.core.windows.net
24uvsblobprodsu6weus18.blob.core.windows.net
kwrvsblobprodsu6weus19.blob.core.windows.net
1hhvsblobprodsu6weus20.blob.core.windows.net
wravsblobprodsu6weus21.blob.core.windows.net
cknvsblobprodsu6weus22.blob.core.windows.net
79tvsblobprodsu6weus23.blob.core.windows.net
oglvsblobprodsu6weus24.blob.core.windows.net
corvsblobprodsu6weus25.blob.core.windows.net
323vsblobprodsu6weus26.blob.core.windows.net
9ajvsblobprodsu6weus27.blob.core.windows.net
tmhvsblobprodsu6weus28.blob.core.windows.net
41hvsblobprodsu6weus29.blob.core.windows.net
iosvsblobprodsu6weus30.blob.core.windows.net
cfyvsblobprodsu6weus31.blob.core.windows.net
57ivsblobprodsu6weus32.blob.core.windows.net
yr3vsblobprodsu6weus33.blob.core.windows.net
fx1vsblobprodsu6weus34.blob.core.windows.net
ikavsblobprodsu6weus35.blob.core.windows.net
6egvsblobprodsu6weus36.blob.core.windows.net
684vsblobprodsu6weus37.blob.core.windows.net
o78vsblobprodsu6weus38.blob.core.windows.net
ijgvsblobprodsu6weus39.blob.core.windows.net
ollvsblobprodsu6weus40.blob.core.windows.net
njbvsblobprodsu6weus41.blob.core.windows.net
nsevsblobprodsu6weus42.blob.core.windows.net
mz5vsblobprodsu6weus43.blob.core.windows.net
lnxvsblobprodsu6weus44.blob.core.windows.net
x7evsblobprodsu6weus45.blob.core.windows.net
vb8vsblobprodsu6weus46.blob.core.windows.net
9zpvsblobprodsu6weus47.blob.core.windows.net
9qavsblobprodsu6weus48.blob.core.windows.net
3u7vsblobprodsu6weus49.blob.core.windows.net
qkyvsblobprodsu6weus50.blob.core.windows.net
s8svsblobprodsu6weus51.blob.core.windows.net
pfcvsblobprodsu6weus52.blob.core.windows.net
dshvsblobprodsu6weus53.blob.core.windows.net
308vsblobprodsu6weus54.blob.core.windows.net
vh9vsblobprodsu6weus55.blob.core.windows.net
si5vsblobprodsu6weus56.blob.core.windows.net
nu4vsblobprodsu6weus57.blob.core.windows.net
eupvsblobprodsu6weus58.blob.core.windows.net
i40vsblobprodsu6weus59.blob.core.windows.net
a8zvsblobprodsu6weus60.blob.core.windows.net
buqvsblobprodsu6weus61.blob.core.windows.net
bwlvsblobprodsu6weus62.blob.core.windows.net
pyvvsblobprodsu6weus63.blob.core.windows.net
l78vsblobprodsu6weus64.blob.core.windows.net
fqqvsblobprodsu6weus65.blob.core.windows.net
kx9vsblobprodsu6weus66.blob.core.windows.net
qvsvsblobprodsu6weus67.blob.core.windows.net
w8hvsblobprodsu6weus68.blob.core.windows.net
alcvsblobprodsu6weus69.blob.core.windows.net
8bwvsblobprodsu6weus70.blob.core.windows.net
5bsvsblobprodsu6weus71.blob.core.windows.net
s83vsblobprodsu6weus72.blob.core.windows.net
08wvsblobprodsu6weus73.blob.core.windows.net
6wovsblobprodsu6weus74.blob.core.windows.net
y78vsblobprodsu6weus75.blob.core.windows.net
m8vvsblobprodsu6weus76.blob.core.windows.net
dgsvsblobprodsu6weus77.blob.core.windows.net
ohxvsblobprodsu6weus78.blob.core.windows.net
pizvsblobprodsu6weus79.blob.core.windows.net
r23vsblobprodsu6weus80.blob.core.windows.net
kd2vsblobprodsu6weus81.blob.core.windows.net
fv1vsblobprodsu6weus82.blob.core.windows.net
9mmvsblobprodsu6weus83.blob.core.windows.net
af3vsblobprodsu6weus84.blob.core.windows.net
aaevsblobprodsu6weus85.blob.core.windows.net
6iwvsblobprodsu6weus86.blob.core.windows.net
m1evsblobprodsu6weus87.blob.core.windows.net
lf4vsblobprodsu6weus88.blob.core.windows.net
wg0vsblobprodsu6weus89.blob.core.windows.net
va5vsblobprodsu6weus90.blob.core.windows.net

For extra reference, list from a certain US region (info from #3801 by @mitchdenny ).
Click to expand (US list)!

@Styxxy Can you tell me how you got this list? I would like to get the latest list for West Europe region, and also keep it up to date in the future. So some sort of script would help.


Image source selection support for ImagePicker plugin

This PR makes it possible to control whether the image comes from gallery or camera. The old behavior is preserved as the default option, which lets the user decide.
Here are the available options:
enum ImageSource {
  /// Let the user choose an image from a source they prefer.
  /// (the old default behavior)
  askUser,

  /// Opens up the device camera on both Android and iOS.
  camera,

  /// On Android, presents a grid of images from the users gallery. On iOS,
  /// opens the users photo library.
  gallery,
}

Here's how someone might pick an image from the device camera now:
Future<File> imageFile = ImagePicker.pickImage(source: ImageSource.camera);

cc @collinjackson since you seem to be the image_picker plugin review guy.

Fixed the test description, but I have no idea why the tests would fail.

Does https://github.com/flutter/plugins/pull/266 help you with fixing the test failures?

Thanks! Just applied that commit to my tests.

I think I might have messed something up when merging/rebasing stuff. At least the changes are humongous.
I'll look into it when I have time.

I signed it!

@goderbauer I started over: #271


Add nfs role in epicli

Originally created here: https://github.com/epiphany-platform/epiphany/pull/961
I believe I have addressed the points raised. Please let me know if there are still some gaps in the implementation.
Thanks,
DI team

You dont need to add the nfs entry in the minimal-cluster-config.yml`s. nfs is more of an edge case and the entry will still by added when people run epicli init with --all.

I have applied the recommended changes.

Are you able to give us some insight into what will happen from now; in the feature branch and how the changes will eventually be released?
Is there anything additional you will require from our team?
Thanks,
DI team


Readme: improved Codecov representation

Current coverage is 35.27% (diff: 100%)

Merging #61 into Development will not change coverage

@@           Development        #61   diff @@
=============================================
  Files               25         25
  Lines             1593       1593
  Methods              0          0
  Messages             0          0
  Branches             0          0
=============================================
  Hits               562        562
  Misses            1031       1031
  Partials             0          0

Powered by Codecov. Last update 31c321e...a70931a