FHIR validation failing because of encodeResourceToString

Describe the bug
FHIR validation is failing on "note" field in ServiceRequest resource because of encodeResourceToString not serializing a space (markdowntype) in text field.
To Reproduce
Steps to reproduce the behavior:
Create a servicerequest bundle, add note field with text value as " " (space) and extension (url and valueString). It generates a MarkdownType for text with string value as " ".
Now use encodeResourceToString method to serialize the bundle, The bundle has note with extension but missing the text field and when converting this string to bundle again and validate, it fails with below error: SingleValidationMessage[col=... ,row=1,message=cvc-complex-type.2.4.b: The content of element 'note' is not complete.
Expected behavior
The encodeResourceToString should have text with " "(space) in note field.
Screenshots
If applicable, add screenshots to help explain your problem.
When debugging JsonParser.encodeCompositeElementChildrenToStreamWriter method, below is the screen shot for that field, its a MarkdownType with string value as space

JsonParser.encodeCompositeElementChildrenToStreamWriter method calls nextValue.isEmpty() -> internally calls PrimitiveType.isEmpty which check for StringUtils.isBlank(getValueAsString()) -> StringUtils.isBlank(" ") returns true
Can this be change to say StringUtils.isEmpty instead of StringUtils.isBlank?
Example of serialized object: {"resourceType":"ServiceRequest","id":"abc","identifier":[{"type":{"coding":[{"system":"servicerequest","code":"ABCD"}]},"value":"1009"}],"status":"completed","intent":"order","category":[{"coding":[{"system":"modality","code":"MRI"}]}],"code":{"coding":[{"system":"servicerequestcode","code":"1009","display":"1009"}]},"subject":{"id":"12345","reference":"Patient/12345","type":"Patient","display":"Patient"},"encounter":{"id":"123456","reference":"Encounter/123456","type":"Encounter","display":"Encounter"},"occurrencePeriod":{"start":"2023-09-08T14:49:00+00:00","end":"2023-09-08T14:49:00+00:00"},"authoredOn":"2023-08-20T19:24:35.63+00:00","requester":{"id":"11111","reference":"Practitioner/11111","type":"Practitioner","display":"OrderingProvider"},"reasonCode":[{"coding":[{"system":"reasonforexam","code":"ReasonForStudy"}]}],"note":[{"extension":[{"url":"servicerequest/annotation/label","valueString":"ClinicalInfoLabel"}]},{"extension":[{"url":"sservicerequest/annotation/label","valueString":"Comment"}],"text":"ClinicalInfo"}]}
Environment (please complete the following information):

HAPI FHIR Version (6.8.3)
OS: windows

JsonParser.encodeCompositeElementChildrenToStreamWriter method calls nextValue.isEmpty() -> internally calls PrimitiveType.isEmpty which check for StringUtils.isBlank(getValueAsString()) -> StringUtils.isBlank(" ")  returns true

It is not actually valid for a FHIR resource to have only spaces in a string. Note this text from the FHIR specification's description of the String datatype (which the Markdown type extends):

Note that strings SHALL NOT exceed 1,048,576 (1024*1024) characters in size. Because UTF-8 characters can be expressed with more than one byte, the string size may be more than 1MB. Strings SHOULD not contain Unicode character points below 32, except for u0009 (horizontal tab), u000D (carriage return) and u000A (line feed). Leading and Trailing whitespace is allowed, but SHOULD be removed when using the XML format. Note: This means that a string that consists only of whitespace could be trimmed to nothing, which would be treated as an invalid element value. Therefore strings SHOULD always contain non-whitespace content

In our scenario, we are generating a ServiceRequest with a note that contains a single space " ". During debugging, this is correctly displayed as a MarkdownType and valueString having " ".
According to the FHIR documentation for markdowntype field, the regular expression \s*(\S|\s)* validates a space as a legitimate value.

When we convert a bundle into a string for streaming (
during which the field gets omitted due to the JsonParser.encodeCompositeElementChildrenToStreamWriter method invoking nextValue.isEmpty(), which internally calls PrimitiveType.isEmpty that checks for StringUtils.isBlank(getValueAsString()), where StringUtils.isBlank(" ") returns true
),
and then revert it back to a bundle for validation, the validation process fails.

@jamesagnew any update on this?

@jamesagnew could you please provide an update on this.

I apologize, I don't have any further updates on this at this time. A PR would be considered, but we don't provide any SLA on community support. Please get in touch if you are interested in a support contract, which allows for an SLA.


Bundle size

Bundle size: optimize
Hi there,
we started using carbon-react-components lately. So far so good, but we have a huge issue with the bundle size. It's currently 70% of the bundle, and that's without taking into account the css, which, as far as I know we need to import entirely even if we just use a button.
The following screenshot shows the issue :

I should add that I use webpack 4, I have tried many things already to remove duplicates and try to eliminate dead code, but nothing seems to work. Anything I may be doing wrong ?

Hi @aboeglin! 👋 Thanks so much for taking the time to make this issue 😄
Definitely understand the bundle concern here, and we're actively trying to get an example that demonstrates how to effectively include only the components you use in your bundle.
With webpack 4, it should be DCE modules since we have the "sideEffects": false flag in our package.json in latest versions. Make sure that the version you're using has that flag included! The example we took this from for inspiration was: https://github.com/webpack/webpack/tree/master/examples/side-effects
If that doesn't help, we're also working on a babel plugin right now to re-write the routes that you import so that you don't have to pay the cost of the module initialization that makes it such that they don't get DCE.
Hope that helps!

I'm using the latest version of create-react-app (v1.1.4) and latest carbon-components-react which has "sideEffects": false When I import components like this: import { Button } from "carbon-components-react It add all components to the bundle. Hoever, if I target directly like this import Button from "carbon-components-react/lib/components/Button" Then just that component is added.

Hi @zerostatic! 👋 What version of react-scripts are you using?

Hi @joshblack  I'm using: 1.1.4

Gotcha, so definitely is the most up-to-date. My hunch is that something is up with how its being imported or the build configuration itself (under the hood). If it's possible to share more info about the setup we can try and help debug 😄
In the worst case, you can still use: https://www.npmjs.com/package/babel-plugin-transform-carbon-imports to help out with the bundle size problem 👍

Hi @joshblack Sure, I created a repo with a test here: https://github.com/zerostatic/carbon-test. This is a basic create-react-app that imports and displays a button from carbon-component-react When analyzing with source-map-explorer all the components are included.

@zerostatic actually, do you want to make a new issue for this? Would hate for this conversation to get lost since this issue has been closed.

New issue has been filed here: https://github.com/carbon-design-system/carbon-components-react/issues/964


Tweet MicroProfile 4.0M1 release

For the purpose of reviewing the staged twitter MicroProfile 4.0M1 release graphic and text, the link will be https://github.com/eclipse/microprofile/releases/tag/4.0M1

M1 release is now available.  Feel free to  tweet - https://github.com/eclipse/microprofile/releases/tag/4.0-M1

just fantastic @jclingan :)
twitter description for @rstjames
#MicroProfileAnnouncement: 💛@MicroProfileIO 4.0-Milestone 1 Release is now available!  This is the first #MicroProfileRelease based on @JakartaEE 8.
Check-out what is new:  https://github.com/eclipse/microprofile/releases/tag/4.0-M1
#OpenSourceFUN #ByCommunityForCommunity
tweet schedule work week day
Twice per month, same day/time/description/design until October 4th.

sent out and scheduled.

the design card looks simple fantastic @rstjames!
@jclingan as stated on yesterday call, you are on fire with timing on the release.
as decided on yesterday Mktg call, there won't be any adjustments on the website related to the release.
such action will enable minor releases from MP APIs to occur and be covered via MP twitter media without extra debt or complications.


Add button to insert summary

What
closes #1670
Notes
Still learning how to web dev, and using this PR as a learning opportunity. Looking forward to feedback!
I wasn't sure what icon to use for the toolbar button for inserting a summary, so I used the info just for representation, but can change it to something else if needed.

I might be overthinking it, but I'm not sure how to properly insert the details block into the textarea without it being formatted into a block of text. 🤔
This:
<details>
  <summary>Some text</summary>
  then here is some long text you want to hide
</details>

gets formatted as a block of text when I use string interpolation, or if I try to insert as innerHTML, it comes out like so:
[object HTMLDetailsElement]

I'm also getting a console error:
Uncaught DOMException: Failed to construct 'CustomElement': The result must not have attributes
But I've tried to follow the format of existing features as much as possible and am not sure what I am doing wrong..

Thanks for the feedback and helpful tips! It also helped me realize I needed to make a couple extra changes that weren't pointed out (e.g. adding the "insert summary" button to all <markdown-toolbar>'s for existing comments too, rather than just the new comment one)

Here's what it looks like now:

@doms Let's apply the latest suggested changes and merge this soon ^_^

@bfred-it Sorry for the lack of updates, I've been super busy! I took some time to try implementing an idempotent delegate (and reading up on multi-key WeakMaps) and tried to make sense of it by playing around with the concepts in that thread, but I wasn't able to come up with something different than the other proposed implementations.. (well, that and my code was a mess 😅 )

I took some time to try implementing an idempotent delegate

You can skip that for this PR, it'd mean (re-)writing and publishing 2 modules unrelated to this.

I believe renaming the feature was the last suggested change that needed to be done! 😄

This looks great. Thanks for working on it, @doms :)


Strong reference cycle - objects not released from memory

Describe the bug
Strong reference cycle between CameraPreviewViewModel and LivenessCaptureSession prevents objects to be released from memory after each liveness session. Please see screenshots from Xcode Memory Graph.

Steps To Reproduce
Steps to reproduce the behavior:
1. Perform full liveness session flow.
2. Perform another full liveness session flow.
3. Observe Xcode Memory Graph -> objects keep accumulating.

Expected behavior
Objects are released from memory after liveness session is completed.
Swift Liveness Version
1.2.9
Xcode version
15.2
Relevant log output
No response
Is this a regression?
No
Regression additional context
No response
OS Version
iOS 17
Device
iPhone 15
Specific to simulators
No response
Additional context
No response

@alekkova Thanks for submitting the issue.  We'll investigate and provide updates here.

Fixed in version 1.2.12


Bug fix explode_json_array_int can't handle min/max values

Proposed changes
the json str get value maybe beyond max/min of Int64,
so add some check to limit the value, and return the max/min of Int64
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

better also add some hint in docs.

run p0


Use WARN_PRINT_ONCE() for FSR-related warning messages

print_error() should generally not be used directly. Also, falling back is best done by printing a warning message instead of an error message.

Thanks!


Accept Calling not working

display modal accept and reject appears but when receiving a call nothing happens.
i just running the samples not change anything

Hi @alfianricky09

Could you please tell me devices you running app?
Are there any errors in the console?

Since there is no activity I’m going to close the issue. Please raise a separate issue in case of any other questions.


bug(testrunner):🐛 <leader>R runs all tests even when filter for failed tests is active

<leader>R runs all tests even when filter for failed tests is active
Find way to use dotnet filter to scope down to the failed tests

Research indicates that targeting a list of individual tests is really complicated due to the filtering command in dotnet test --filter being so sensitive and requiring, escaping, stripping etc to ensure the correct tests are run.

Using TranslationLayer might be a viable solution for this issue

100% possible using this code https://github.com/stryker-mutator/stryker-net/blob/master/src/Stryker.Core/Stryker.Core/TestRunners/VsTest/RunEventHandler.cs


Package configuration, linter and license information

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Translating C++ lesson source code to Spanish

Even when this lesson was in Spanish the two code snippets used as reference were in English.  I've added a little more information about private, public and protected access modifiers.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

LGTM, good job.

Thanks and congratulations on your first merged contribution!


Add favorite buddy v1

Users can now add ad buddy to favorite from the search index page
You can also see you buddies names on the account overview my beehive tab
I used acts_as_favoritor gem. Feel free to read the documentation. It's useful to retrive the information.

TODO:

Race Condition: A race condition occurs when multiple operations (in this case, favoriting or unfavoriting) are performed concurrently by different threads or processes, leading to unexpected outcomes or errors. So sometimes the request overlap each other and than the request can't be sent. We need to find a way to solve this in the backend or AJAX
Front-End for account overview beehive is still open.

to test this:
bundle install

seems fine, good notes!


build_all_ios.sh error

In file included from /Users/viatom/tensorflow/tensorflow/contrib/makefile/downloads/eigen/unsupported/Eigen/CXX11/Tensor:79:
In file included from /Users/viatom/tensorflow/tensorflow/contrib/makefile/downloads/eigen/unsupported/Eigen/CXX11/ThreadPool:58:
/Users/viatom/tensorflow/tensorflow/contrib/makefile/downloads/eigen/unsupported/Eigen/CXX11/src/ThreadPool/SimpleThreadPool.h:153:5: error:
      thread-local storage is not supported for the current target
    EIGEN_THREAD_LOCAL PerThread per_thread;
    ^
/Users/viatom/tensorflow/tensorflow/contrib/makefile/downloads/eigen/unsupported/Eigen/CXX11/src/ThreadPool/ThreadLocal.h:15:35: note:
      expanded from macro 'EIGEN_THREAD_LOCAL'
#define EIGEN_THREAD_LOCAL static __thread
                                  ^
<command line>:3:18: note: expanded from here
#define __thread thread_local
                 ^
In file included from tensorflow/core/common_runtime/graph_runner.cc:21:
In file included from ./tensorflow/core/common_runtime/graph_runner.h:23:
In file included from ./tensorflow/core/common_runtime/device.h:35:
In file included from ./tensorflow/core/framework/allocator.h:23:
In file included from ./tensorflow/core/framework/numeric_types.h:20:
In file included from ./third_party/eigen3/unsupported/Eigen/CXX11/Tensor:1:
In file included from /Users/viatom/tensorflow/tensorflow/contrib/makefile/downloads/eigen/unsupported/Eigen/CXX11/Tensor:79:
In file included from /Users/viatom/tensorflow/tensorflow/contrib/makefile/downloads/eigen/unsupported/Eigen/CXX11/ThreadPool:59:
/Users/viatom/tensorflow/tensorflow/contrib/makefile/downloads/eigen/unsupported/Eigen/CXX11/src/ThreadPool/NonBlockingThreadPool.h:326:5: error:
      thread-local storage is not supported for the current target
    EIGEN_THREAD_LOCAL PerThread per_thread_;
    ^
/Users/viatom/tensorflow/tensorflow/contrib/makefile/downloads/eigen/unsupported/Eigen/CXX11/src/ThreadPool/ThreadLocal.h:15:35: note:
      expanded from macro 'EIGEN_THREAD_LOCAL'
#define EIGEN_THREAD_LOCAL static __thread
                                  ^
<command line>:3:18: note: expanded from here
#define __thread thread_local
                 ^
In file included from tensorflow/core/common_runtime/local_device.cc:18:
In file included from ./tensorflow/core/common_runtime/local_device.h:19:
In file included from ./tensorflow/core/common_runtime/device.h:35:
In file included from ./tensorflow/core/framework/allocator.h:23:
In file included from ./tensorflow/core/framework/numeric_types.h:20:
In file included from ./third_party/eigen3/unsupported/Eigen/CXX11/Tensor:1:
In file included from /Users/viatom/tensorflow/tensorflow/contrib/makefile/downloads/eigen/unsupported/Eigen/CXX11/Tensor:79:
In file included from /Users/viatom/tensorflow/tensorflow/contrib/makefile/downloads/eigen/unsupported/Eigen/CXX11/ThreadPool:58:
/Users/viatom/tensorflow/tensorflow/contrib/makefile/downloads/eigen/unsupported/Eigen/CXX11/src/ThreadPool/SimpleThreadPool.h:153:5: error:
      thread-local storage is not supported for the current target
    EIGEN_THREAD_LOCAL PerThread per_thread;
    ^
/Users/viatom/tensorflow/tensorflow/contrib/makefile/downloads/eigen/unsupported/Eigen/CXX11/src/ThreadPool/ThreadLocal.h:15:35: note:
      expanded from macro 'EIGEN_THREAD_LOCAL'
#define EIGEN_THREAD_LOCAL static __thread
                                  ^
<command line>:3:18: note: expanded from here
#define __thread thread_local
                 ^
In file included from tensorflow/core/common_runtime/local_device.cc:18:
In file included from ./tensorflow/core/common_runtime/local_device.h:19:
In file included from ./tensorflow/core/common_runtime/device.h:35:
In file included from ./tensorflow/core/framework/allocator.h:23:
In file included from ./tensorflow/core/framework/numeric_types.h:20:
In file included from ./third_party/eigen3/unsupported/Eigen/CXX11/Tensor:1:
In file included from /Users/viatom/tensorflow/tensorflow/contrib/makefile/downloads/eigen/unsupported/Eigen/CXX11/Tensor:79:
In file included from /Users/viatom/tensorflow/tensorflow/contrib/makefile/downloads/eigen/unsupported/Eigen/CXX11/ThreadPool:59:
/Users/viatom/tensorflow/tensorflow/contrib/makefile/downloads/eigen/unsupported/Eigen/CXX11/src/ThreadPool/NonBlockingThreadPool.h:326:5: error:
      thread-local storage is not supported for the current target
    EIGEN_THREAD_LOCAL PerThread per_thread_;
    ^
/Users/viatom/tensorflow/tensorflow/contrib/makefile/downloads/eigen/unsupported/Eigen/CXX11/src/ThreadPool/ThreadLocal.h:15:35: note:
      expanded from macro 'EIGEN_THREAD_LOCAL'
#define EIGEN_THREAD_LOCAL static __thread
                                  ^
<command line>:3:18: note: expanded from here
#define __thread thread_local
                 ^
gcc --std=c++11 -DIS_SLIM_BUILD -fno-exceptions -DNDEBUG -O3 -mios-simulator-version-min=9.0 -arch i386 -mno-sse -fembed-bitcode -D__thread=thread_local -DUSE_GEMM_FOR_CONV -Wno-c++11-narrowing -DTF_LEAN_BINARY -D__ANDROID_TYPES_SLIM__ -fno-exceptions -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator11.3.sdk -MT /Users/viatom/tensorflow/tensorflow/contrib/makefile/gen/obj/ios_I386/tensorflow/core/common_runtime/memory_types.o -MMD -MP -MF /Users/viatom/tensorflow/tensorflow/contrib/makefile/gen/dep/ios_I386//tensorflow/core/common_runtime/memory_types.Td -I. -I/Users/viatom/tensorflow/tensorflow/contrib/makefile/downloads/ -I/Users/viatom/tensorflow/tensorflow/contrib/makefile/downloads/eigen -I/Users/viatom/tensorflow/tensorflow/contrib/makefile/downloads/gemmlowp -I/Users/viatom/tensorflow/tensorflow/contrib/makefile/downloads/nsync/public -I/Users/viatom/tensorflow/tensorflow/contrib/makefile/downloads/fft2d -I/Users/viatom/tensorflow/tensorflow/contrib/makefile/downloads/double_conversion -I/Users/viatom/tensorflow/tensorflow/contrib/makefile/gen/proto/ -I/Users/viatom/tensorflow/tensorflow/contrib/makefile/gen/proto_text/ -I/Users/viatom/tensorflow/tensorflow/contrib/makefile/gen/protobuf-host/include -I/usr/local/include -c tensorflow/core/common_runtime/memory_types.cc -o /Users/viatom/tensorflow/tensorflow/contrib/makefile/gen/obj/ios_I386/tensorflow/core/common_runtime/memory_types.o
2 errors generated.
make: *** [/Users/viatom/tensorflow/tensorflow/contrib/makefile/gen/obj/ios_I386/tensorflow/core/common_runtime/local_device.o] Error 1
make: *** Waiting for unfinished jobs....
2 errors generated.
make: *** [/Users/viatom/tensorflow/tensorflow/contrib/makefile/gen/obj/ios_I386/tensorflow/core/common_runtime/graph_runner.o] Error 1
+ '[' 2 -ne 0 ']'
+ echo 'i386 compilation failed.'
i386 compilation failed.
+ exit 1

I tried running tensorflow/contrib/makefile/build_all_ios.sh and then this issue occurred. I searched for a lot of similar issue, but not fixed the issue.
So, i need help.

-r 1.9
-mac 10.13.4 (17E199)

I recently fixed this for TFLite: https://github.com/tensorflow/tensorflow/issues/20900 the issue might be similar.

@shashishekhar #20900 helped me fixed this issue, thanks.

Nagging Assignee @shashishekhar: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

@ChaosYang, could you submit a PR, please! That would be awesome.

Nagging Assignee @aselle: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @aselle: It has been 29 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

I am having the same issue.  and I am using tensorflow r1.10 branch and xcode 9.4.1.  https://github.com/tensorflow/tensorflow/issues/20900 does not help since flatbuffers is not dowloaded anymore .

Nagging Assignee @aselle: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @aselle: It has been 29 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @aselle: It has been 44 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @aselle: It has been 59 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.


create a mechanism to migrate from community vectorstore to this implementation

Whats your use case? Why can you not re-index the data? Are you able to create the relevant migrations manually?

Related to https://github.com/langchain-ai/langchain-postgres/issues/30


Add export to postman

Allow users to export their mocks directly to postman collections.
The end result should be one collection where each scenario is a category if possible.
Also allow to run tests against the api by using newman.
The final format should look similar to this:
{
  "variables": [],
  "info": {
    "name": "Github",
    "_postman_id": "105cff9a-e733-c089-f033-9f6529582a65",
    "description": "",
    "schema": "https://schema.getpostman.com/json/collection/v2.0.0/collection.json"
  },
  "item": [
    {
      "name": "https://api.github.com/users/hackeryou",
      "event": [
        {
          "listen": "test",
          "script": {
            "type": "text/javascript",
            "exec": "tests[\"Status code is 200\"] = responseCode.code === 200;\n\nvar response = JSON.stringify({\n  \"login\": \"morsdyce\",\n  \"id\": 1665570,\n  \"avatar_url\": \"https://avatars.githubusercontent.com/u/1665570?v=3\",\n  \"gravatar_id\": \"\",\n  \"url\": \"https://api.github.com/users/morsdyce\",\n  \"html_url\": \"https://github.com/morsdyce\",\n  \"followers_url\": \"https://api.github.com/users/morsdyce/followers\",\n  \"following_url\": \"https://api.github.com/users/morsdyce/following{/other_user}\",\n  \"gists_url\": \"https://api.github.com/users/morsdyce/gists{/gist_id}\",\n  \"starred_url\": \"https://api.github.com/users/morsdyce/starred{/owner}{/repo}\",\n  \"subscriptions_url\": \"https://api.github.com/users/morsdyce/subscriptions\",\n  \"organizations_url\": \"https://api.github.com/users/morsdyce/orgs\",\n  \"repos_url\": \"https://api.github.com/users/morsdyce/repos\",\n  \"events_url\": \"https://api.github.com/users/morsdyce/events{/privacy}\",\n  \"received_events_url\": \"https://api.github.com/users/morsdyce/received_events\",\n  \"type\": \"User\",\n  \"site_admin\": false,\n  \"name\": \"Maayan Glikser\",\n  \"company\": \"500Tech\",\n  \"blog\": \"http://www.glikm.com\",\n  \"location\": null,\n  \"email\": null,\n  \"hireable\": null,\n  \"bio\": null,\n  \"public_repos\": 34,\n  \"public_gists\": 56,\n  \"followers\": 5,\n  \"following\": 3,\n  \"created_at\": \"2012-04-21T12:47:33Z\",\n  \"updated_at\": \"2016-07-20T20:53:42Z\"\n});\n\ntests[\"Body matches string\"] = responseBody.has(response);"
          }
        }
      ],
      "request": {
        "url": "https://api.github.com/users/hackeryou",
        "method": "GET",
        "header": [],
        "body": {
          "mode": "formdata",
          "formdata": []
        },
        "description": ""
      },
      "response": []
    },
    {
      "name": "https://api.github.com/users/morsdyce",
      "event": [
        {
          "listen": "test",
          "script": {
            "type": "text/javascript",
            "exec": "tests[\"Status code is 200\"] = responseCode.code === 200;\n\nvar response = {\n  \"login\": \"morsdyce\",\n  \"id\": 1665570,\n  \"avatar_url\": \"https://avatars.githubusercontent.com/u/1665570?v=3\",\n  \"gravatar_id\": \"\",\n  \"url\": \"https://api.github.com/users/morsdyce\",\n  \"html_url\": \"https://github.com/morsdyce\",\n  \"followers_url\": \"https://api.github.com/users/morsdyce/followers\",\n  \"following_url\": \"https://api.github.com/users/morsdyce/following{/other_user}\",\n  \"gists_url\": \"https://api.github.com/users/morsdyce/gists{/gist_id}\",\n  \"starred_url\": \"https://api.github.com/users/morsdyce/starred{/owner}{/repo}\",\n  \"subscriptions_url\": \"https://api.github.com/users/morsdyce/subscriptions\",\n  \"organizations_url\": \"https://api.github.com/users/morsdyce/orgs\",\n  \"repos_url\": \"https://api.github.com/users/morsdyce/repos\",\n  \"events_url\": \"https://api.github.com/users/morsdyce/events{/privacy}\",\n  \"received_events_url\": \"https://api.github.com/users/morsdyce/received_events\",\n  \"type\": \"User\",\n  \"site_admin\": false,\n  \"name\": \"Maayan Glikser\",\n  \"company\": \"500Tech\",\n  \"blog\": \"http://www.glikm.com\",\n  \"location\": null,\n  \"email\": null,\n  \"hireable\": null,\n  \"bio\": null,\n  \"public_repos\": 34,\n  \"public_gists\": 56,\n  \"followers\": 5,\n  \"following\": 3,\n  \"created_at\": \"2012-04-21T12:47:33Z\",\n  \"updated_at\": \"2016-07-20T20:53:42Z\"\n};\n\n_.merge(response, responseBody, function (objectValue, sourceValue, key, object, source) {\n    if ( !(_.isEqual(objectValue, sourceValue)) && (Object(objectValue) !== objectValue)) {\n        tests['response'] = false;\n    }\n    \n    tests['response'] = true;\n});"
          }
        }
      ],
      "request": {
        "url": "https://api.github.com/users/morsdyce",
        "method": "GET",
        "header": [],
        "body": {
          "mode": "formdata",
          "formdata": []
        },
        "description": ""
      },
      "response": []
    }
  ]
}

@morsdyce We need to save the full URL of the mocked request when exporting scenarios, otherwise exporting as postman collection would not make much sense.


[do not merge] Test CI against atom/ci changes

Ensure that the changes in atom/ci#86:

Do not break the stable and beta channel builds in Travis (which are using the older npm version)
Fix the dev channel build in Travis (which is using the newer npm version)

👌


Api Endpoint /domain/_search returns not all elements, bulk max without paging

Hello,
The POST /domain/_search endpoint should return a list of domains. In my case i have 160 domains in AutoDNS, however the api returns exactly 100 elements. In the Swagger-Doku i found a header X-Domainrobot-Bulk-Limit which propably helps in my case if i just set it to a very large number... However a better approach would be an api endpoint that allows real paging.

Hello @Zeg0,
How does your body of the POST request look like ?
The amount of entities fetched via this endpoint is defined via the "view" field within the json body. Example :
{
    "filters": [
        {
            "key": "name",
            "operator": "LIKE",
            "value": "%mydomain%"
        }
    ],
    "view": {
        "children": 1,
        "limit": 1000,
        "offset": 0,
    },
    "orders": [
        {
            "key": "created",
            "type": "ASC"
        }
    ]
}

The view can then be used via the limit and offeset parameter to create a pagination.
The response should look similar to this :
{
  "stid": "20240223-app3-dev-3587",
  "status": {
    "code": "S0105",
    "text": "Domain-Daten wurden erfolgreich ermittelt.",
    "type": "SUCCESS"
  },
  "object": {
    "type": "Domain",
    "summary": 102
  },
  "data": [
    {
      "created": "2014-10-29T13:58:56.000+0100",
      "updated": "2023-05-17T14:15:53.000+0200",
      "owner": {
        "context": 4,
        "user": "myuser"
      },
      "name": "mydomain.de",
      "payable": "2024-02-29T23:59:59.000+0100"
    }
  ]
}

The "object" field holds a "summary" field that respresents the amount of entities that belong to your user. With the limit and the summary, the maximum number of pages can then be calculated.
If there are any questions left, feel free to comment.

Ahhh i see - i thought i needed the header, but your recommended body "view" worked just fine. I left that completely empty previously.
Now it works - thank you!


Add double-scrolling

Library is widely used to stick sidebar along content and I think it will be good feature, if it will take two selectors and stick the lower one, because sometimes sidebar is higher than content.
Possible syntax:
$('#sidebar').stickit({with: '#content'});
$.stickit('#content', '#sidebar')

I will consider it when I have time.

Thanks!
2016-06-21 17:11 GMT+03:00 emn178<EMAIL_ADDRESS>
I will consider it when I have time.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/emn178/jquery-stickit/issues/18#issuecomment-227452061,
or mute the thread
https://github.com/notifications/unsubscribe/ARyoVyIzryCJGUrCQZNwomZDP3m8NcJxks5qN_EcgaJpZM4I5cFc
.

Hi,
New version v0.2.8 should support this feature.
You can simply stick the different elements which have the same parent.
You can see the demo https://emn178.github.io/jquery-stickit/samples/columns/


fix: fix a link in docs

What type of PR is this?

(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):
(Optional) Which issue(s) this PR fixes:

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

https://www.cloudwego.io/docs/kitex/tutorials/advanced-feature/generic-call/
英文的也改下吧


Support rebasing ops for testing. Part 1, the mock.

Description
Adding a mock to support the new states added with https://github.com/microsoft/FluidFramework/pull/16176. This will be further integrated into the test pipeline via the fuzz testing harness.

Converting it back to a draft PR, this is more involved than I originally thought.

back to the drawing board with this, I believe it may be feasible to include this logic in the existing mock.

Closing this in favor of https://github.com/microsoft/FluidFramework/pull/16460


add ownedTeams method to User model

I think it would be great if I can call $user->ownedTeams() and I get a list of teams that I own (1 or more).

Yes, great idea!
Added this feature to release 1.1.0


[web]: Transform.scale rasterizes elements

When using Transform.scale, elements are simply scaled up without re-rendering elements, leading to low-resolution assets.
Tested on a Switch component.

@drewcovi Please provide your flutter doctor -v output, and some code example to reproduce the issue.

This is a bug in the web engine. To fix it we need to compute pixel density based on ancestor transforms and adjust the bitmap canvas size.

@drewcovi @yjbanov Is this still a valid issue on latest Flutter version ?
@drewcovi If issue persists, can you provide a minimal complete reproducible code sample that shows the issue ?

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs, and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.


Prompts do not randomise between batches

version 7cfd16eb26e789456e751f1078df139e4b624264
expected: using a __filename__ should randomise per batch
actual: it does not
similarly {prompt1|prompt2|prompt3} will not randomise per batch

Does this issue addresses this: https://github.com/adieyal/sd-dynamic-prompts/issues/26?

That was rediculously quick :D I was about to resolve the issue... it isn't that it doesn't randomise, it's simple that for whatever reason Gradio displays the same prompts.. the filename and and PNG info are both correct.

Is a visual Gradio issue, it's working as intended.


Re-organized MIP Editor and Governance Facilitator Components (MIP0c8…

Components 8-11 are now:

MIP Editor Role
Governance Facilitator Role
Core Personnel Onboarding
Core Personnel Offboarding

Content changes have been kept to a minimum so far as was possible given the reshuffle.
Onboarding and Offboarding Templates have been made more general (removed explicit references to roles)

Have now merged this with the latest changes.

LGTM.


Partitioning layout

This makes the installer to accept a cloud-init file, - only with GPT partition types - like the following:
stages:
   partitioning:
     - name: "Repart disk"
       layout:
         device:
           path: /dev/sda
         add_partitions:
           - fsLabel: COS_STATE
             size: 8192
             pLabel: state
           - fsLabel: COS_OEM
             size: 10
             pLabel: oem
           - fsLabel: COS_RECOVERY
             # default filesystem is ext2 if omitted
             filesystem: ext4
             size: 40000
             pLabel: recovery
           - fsLabel: COS_PERSISTENT
             pLabel: persistent
             # default filesystem is ext2 if omitted
             filesystem: ext4
             size: 40000

Of course, it can be also used to create additional partitions, or either create those into a different device (by setting path), having more stages, etc.
That can be supplied to the installer with cos-installer --partition-layout <file> <device>

Not possible to add tests due to #734

There is a small change required into yip to make it work. Between mkfs calls, yip tries to detect the partition location and calls partprobe to recall tables, however that doesn't seems to be sufficient while testing locally. If I define more than 2/3 partitions, it starts to error out that can't find the partition number. A call to sync in between seems to fix the issue

Done, included in 0.9.21

Docs PR: https://github.com/rancher-sandbox/cos-toolkit-docs/pull/56


feat: customize logger

Codecov Report

Merging #6 (23265ce) into master (5e186f9) will decrease coverage by 6.63%.
The diff coverage is 32.00%.

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
- Coverage   82.03%   75.39%   -6.64%
==========================================
  Files           8        8
  Lines         423      443      +20
==========================================
- Hits          347      334      -13
- Misses         57       88      +31
- Partials       19       21       +2

Impacted Files
Coverage Δ

cmd/go-runner/main.go
50.00% <22.72%> (-19.24%)
:arrow_down:

internal/server/server.go
40.77% <100.00%> (-17.48%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e186f9...23265ce. Read the comment docs.


Add support for contenteditable

Add the initial support for contenteditable elements by abstracting how we retrieve element text. If it's a form element (input[type=text] or textarea) we'll grab the value otherwise fall back to textContent to support text nodes and regular elements.
Refs #11
Questions

I modified a single test to show one way it could be done. Would you like me to apply the same logic to the rest or would you like to try something else?

There are a few more changes to make, but I'll handle them in a separate PR:

selectionStart and selectionEnd don't work for contenteditable
we're still referencing value in a couple places
our message input (in Slack) is always adding a trailing newline for some reason 💭

This is a great start though, thanks @montlebalm!


Introduction of dashboard_rbac broke user_attribute welcome_dashboard_id

The method check_dashboard_access tries to access str(kwargs["dashboard_id_or_slug"] which results in a KeyError if the user was redirected from /welcome
Expected results
No KeyError, and user is directed to their welcome_dashboard_id
Actual results
A KeyError
Screenshots

How to reproduce the bug
Add a row to UserAttribute linking User ID X with welcome_dashboard_id Y
Checklist
Make sure to follow these steps before submitting your issue - thank you!

[ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[X] I have reproduced the issue with at least the latest released version of superset.
[X] I have checked the issue tracker for the same issue and I haven't found one similar.

Fixed by https://github.com/apache/superset/pull/13505


Added detached option to IMPORT

Updated import option table, warning, and added examples.
Closes #10085

This change is


Shortcut for MD5?

It is possible to create a shortcut to replace String with your MD5 function ?

Hey @ChR-iSz
Im not sure if I understand what you need...
You want to find a specific string and replace all occurrences of it with an md5 digest for them?
If thats the case thats already possible... Select the string what you and press ctrl+shift+l (or cmd+shift+l on a mac), this will allow you to edit all occurrences of that word at once. Then just invoke the swissknife command palette and select the MD5 script.
If you just want to MD5 a specific word just select that work and run the MD5 script from swissknife.
Have in mind that by default swissknife will apply a script to the entire editor's content if no text is selected, but in case the text is selected it will only apply to that text, and if you have multi selection with multi cursors it will apply that script to all the selections at once


Adds ActivityInsightOaFile model and db migration.  Tests as well.

Closes #638

Need to add a checksum field


Show stopped thread when breakpoint is hit

Not sure where this would exist in the UI. Maybe after Input?

Input (status: stopped, thread=1) or something like that.

This is completed.


plugin - scan a git repo (dir path)

use gitleaks with common config
suggest args to expose for user

@jossef @cx-monicac what do you think about these to start?
--repo-url or -r: The URL of the git repository to be scanned.
--branch or -b: The branch of the git repository to be scanned (optional, defaults to "master").
--api-key or -k: The API key to authenticate with the Checkmarx 2MS service.
--exclude or -e: A list of files or directories to be excluded from the scan (optional).
--format or -f: The output format for the scan results (optional, defaults to "json").
--output or -o: The output file for the scan results (optional, defaults to "results.").

@bryantschuck
--format and  --output are unrelated to this issue and more general, please create a separate issue and include detailed format of the desired output json and format field values.
It would be simpler to scan a directory path having a git repo instead of receiving a url. Most likely 2ms will be executed in ci pipelines and the project's candidate code to scan will be there. I would remove at this point --repo-url, --branch, --api-key
Regarding --exclude, please see gitleaks docs, as this plugin implementation is going to use the project's capabilities in scanning a git project's dir path. I think they have some customization might be relevant for us to activate

@jossef According to your suggestion, we are not talking about scanning a git repo, but just scanning a local folder. Unless you want to scan also the git history?

@baruchiro I'll pick this one up since in the last meeting we discussed that for now we would like to only scan a directory or a single file


Update network-access-options-for-connecting-to-centurylink-clouds-pl…

…atform.md

closing due to staleness


Include views in a different context

Hi,
First of all thank you for your hard work and this plugin. It's awesome.
However, I'm missing some documentation about whether/how it's possible to include default view functionality you provide in my templates.
Let's say I like the default behaviour of your views -> /accounts && /accounts/1/ and I'd like to include it to my page (to a specific part of a template). Is there any easy way to do so?
NOTE: I've came back to Django after 1-2 years, so the solution might be obvious and maybe it's out of scope of this plugin's documentation, but maybe it could help if it's more explicit.

Hi Ján - I'm not sure what you mean by "include [the default behavior of the views] in [your] page". Do you mean using your own template with the views here?
It sounds like you're asking how to either (1) use a different template or (2) add data into the view.
For the first, there are two ways to do this: either (a) pass a template_name variable to the view factory method (as_view) in your URL conf (like this in the docs) or subclass the particular view in your own views.py module, using that class, and overriding the template_name definition in your class (like this in the docs). All things being equal the second method is preferred.
If you mean how do you include other data or functionality, then continue with the last recommendation and create a subclass of the view. You can add whatever data or methods you want here.
class MyAccountView(OrganizationList):
    template_name = "myapp/account_list.html"

    def get_context_data(self, **kwargs):
        context = super().get_context_data(**kwargs)
        context.update({
            'is_this_real_life': self.is_this_real_life(),  # defined elsewhere on the class
            ...
        })
        return context

Does that answer your question?

Yes thank you, it partially does.
But I was looking for more like an out of a box solution where I could just override base template and use a plugin without a need to override any View.
url(r'^accounts/', include('organizations.urls')),
url(r'^invitations/', include(invitation_backend().get_urls())),

But I was looking for more like an out of a box solution where I could just override base template and use a plugin without a need to override any View.

So something like the dependency injection used by the invitation/registration backends? While technically feasible, that's neither present in django-organizations nor is that really how Django CBVs work or at least are expected to work. I think you'd be best off overriding the view. It'll be a little bit of code and it'll be explicit to boot.

Thanks a lot for your help :)

Hi,
So at the end I've achieved my goal by doing this:

I've created organizations_base.html file

{% extends 'base.html' %}
{% block content %}
{% endblock content %}

And I've overriden templates in a organizations folder based on my needs. https://github.com/bennylope/django-organizations/tree/dev/organizations/templates
That way I don't need to create anything special (no views, etc), I've just overriden the base template + templates I need. I hope this will help somebody.
Thanks for your time & help @bennylope !


Issue with CURL

Extracted from #97
Because of this string, the Microsoft returns the bad response:
curl_setopt($request, CURLOPT_SSL_VERIFYPEER, false);

If I set it to true, the correct access_token is returned.
Reproduced on PHP7. What would you suggest? Are you able to reproduce this issue? If so, how do you recommend to fix it?

I was not able to reproduce this behavior, but it should be safe to set it to true.
And also this would be a lot safer, since it does not allow man-in-the-middle attacks.
I will change the code and test the various drivers.


Deleting functionality related to reservoir

This functionality was cut for v1, so removing the related code.
Fixes #72.

This change is

Coverage decreased (-0.2%) to 84.951% when pulling dd0fdc42ca3df3949f93c30b19adac9eb312ec0d on mtlynch:cut-res into 6ba1904f2d8ab7b08e06fadf19e52dc18407e3c6 on JeetShetty:master.

Should delete weight_sensor/test_weight_sensor as well. Otherwise LGTM.

Ah! you're right. Fixed

Coverage increased (+0.03%) to 85.142% when pulling 6c3365761f8ae0962d4e7f28ad288446b47f8f58 on mtlynch:cut-res into 6ba1904f2d8ab7b08e06fadf19e52dc18407e3c6 on JeetShetty:master.


[BUG] Trying to get property of non-object telescope in voyager

Version information

Laravel: v5.7.21
Voyager: v1.1
PHP: 7.1.3
Telescope: 2.0

Description

When setting up environment from local to production it's showing error.
Screenshots

Why do you use telescope inside voyager/admin group?
I don't really wonder that this is failing.

I don't do anything i just install telescope as per the instruction given at laravel docs and its working fine in local environment but when i change environment from local to productions its showing error.

Nonetheless this looks very similar to https://github.com/the-control-group/voyager/issues/3868

\TCG\Voyager\Models\User breaks the Laravel Gates
Permissions from Voyager try to load them from their database definitions which overwrites the Gate check from Laravel.
Just got the same thing with Laravel Passport

Ok so looks like Policies are prioritized over Gates and Voyager registers User model policy. This causes for Voyager permissions to be checked instead of checking for actual Gate.
Easiest fix is to create your own user policy php artisan make:policy -m User UserPolicy
Inside the UserPolicy add your permission name function or in my case
public function viewHorizon(User $user)

@gkmk thanks that did the trick for telescope too!

@gkmk thanks this works for me.

@gkmk Should I copy and paste Voyager's UserPolicy methods in it ? And should I overwrite defaut value in User BREAD with App\Policies\UserPolicy as well ? Will I loose user permissions ?

@CharlieEtienne just extend the Voyager UserPolicy class and add the method


BLIP and BLIP2 model details

Great work! Thanks for releasing the models, pre-trained checkpoints and examples.
I have a couple of questions about the BLIP and BLIP 2 models - I can't clearly find this info in the papers/repo but apologies if I've missed it.

For the ‘base’ BLIP feature extractor:
a. How many images were used during pretraining (is it the 14M or 129M version)?
b. Is this the ViT-B/16 vision transformer version?
For the ‘pretrain’ and ‘coco’ BLIP 2 feature extractors:
a. Which image encoder was used? (I’m assuming ViT-L or ViT-G)
b. Roughly, how many images were used during the COCO fine-tuning?

Thanks!

Thanks for your questions. Here are my answers.
1.a. It is the 129M version
1.b. Yes
2.a. We use ViT-g for all BLIP-2 models
2.b. We use coco-karpathy-train with 113K images.
Hope this helps.

Perfect, thanks!


Autofill biometrics disabled screen

Task/Issue URL: https://app.asana.com/0/0/1203093081439357/f
Tech Design URL:
CC: @THISISDINOSAUR
Description:
Implementation of the biometrics disabled screen + associated state management

Steps to test this PR:

From a clean install, go to the Autofill Logins screen and reject permission to allow biometrics (or disable biometrics for the app)
You should be presented with new screen
Tap the "Set up Face ID" button and ensure you are taken to DDG iOS Settings where access to biometrics can be enabled
Test with devices that use FaceID and TouchID and confirm the copy updates accordingly
Confirm that all functionality works as before when biometrics permission is enabled

Copy Testing:

[ ] Use of correct apostrophes in new copy, ie ’ rather than '

Orientation Testing:

[ ] Portrait
[ ] Landscape

Device Testing:

[ ] iPhone SE (1st Gen)
[ ] iPhone 8
[ ] iPhone X
[ ] iPhone 14 Pro
[ ] iPad

OS Testing:

[ ] iOS 14
[ ] iOS 15
[ ] iOS 16

Theme Testing:

[ ] Light theme
[ ] Dark theme

Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

I've been unable to see this screen on any device or simulator. It just asks me for a passcode, and then if I cancel or fail that, dismisses the autofill screen

Ugh, I'm so sorry about that! This one has been going on for so long that I forgot to update the PR steps in line with the spec changes.
The updated requirement is for the user to only be presented with this new screen when they do not have a device passcode set; I've updated the PR steps and title accordingly. Translations were also ready so I've included those too 🙂


Wallet on android will not allow UNBONDING

I can bond and add additional bond but when I want to UNBOND, it will not get past the submit button to next screen where the fee is shown and you are able to sign and submit

I tried unbond action and it seems working well. Are you using the latest version?

Yes I am
On Sun, Aug 30, 2020, 8:55 PM Shawn Yang<EMAIL_ADDRESS>wrote:

I tried unbond action and it seems working well. Are you using the latest
version?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/polkawallet-io/polkawallet-flutter/issues/155#issuecomment-683535648,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIGJSJANEDKSOAGBJQHIQ63SDMNKXANCNFSM4QOLHXXQ
.


Weird error when sourcemap is enabled

Describe the bug
When I update from 0.14.7 to 0.15.0 source map is enabled by default and
whenever I make change in content script and save it print the error
Error when using sourcemap for reporting an error: Can't resolve original location of error.
Set it off sourcemap: false will not cause it anymore.
Not sure if this happened with other frameworks like React or Svelte
To Reproduce
Share minimal reproduction. Examples of a minimal reproduction:
temp.zip
Steps to reproduce the bug using the reproduction:

Install dependencies: pnpm i
Start dev mode: pnpm dev
Go to MainUI.vue
Try comment const test = ref('test');
It will crash

Screenshots

Environment
System:
    OS: Windows 11 10.0.22631
    CPU: (16) x64 12th Gen Intel(R) Core(TM) i5-12500H
    Memory: 4.44 GB / 15.73 GB
  Binaries:
    Node: 20.11.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.21 - C:\Program Files\nodejs\yarn.CMD
    npm: 10.2.4 - C:\Program Files\nodejs\npm.CMD
    pnpm: 8.15.1 - C:\Program Files\nodejs\pnpm.CMD
  Browsers:
    Edge: Chromium (121.0.2277.112)
    Internet Explorer: 11.0.22621.1
  npmPackages:
    wxt: ^0.15.0 => 0.15.0

Additional context
Already tested out latest 0.16.6 but still yeah

Yeah, not sure TBH. This is the second problem with the vue plugin, also see #270. I haven't had time to look into this yet, but it appears only related to content scripts... Re-running the dev command works, but that's obviously not a solution...
I'll have to explore the vue plugin a bit more to try to figure out what's going on, but I have other priorities right now, so it'd be a great help if someone else helped out with this.

Hey, I updated all the dependencies in the temp.zip and it does not seem to happen anymore, so I think this issue seems fixed!

Hey, I updated all the dependencies in the temp.zip and it does not seem to happen anymore, so I think this issue seems fixed!

I've not used Vue and Wxt for about 6 months. So I can't be sure, but maybe it's been fixed. So I'll close it


Statistics & Machine learning: feedback from the embedded feedback form

@galaxyproject/training-statistics
Notes for all tutorials in this topic (16.09.2019):

Age prediction using machine learning

Basics of machine learning

Pro:

very straightforward tutorial (08/03/2019)
This was a helpful example for how machine learning can be applied to a real-world dataset. (18/03/2019)
Easy way to use machine learning (06/07/2019)

Con:

Add more info on how to access the SVM Classifier tool. This tool does not seem to be available in the US Galaxy instance, but it is available in the EU Galaxy instance. (18/03/2019)
maybe more information or link for understand each advanced parameters (06/07/2019)

Machine learning: classification and regression

Pro:

Short and efficient primer (02/09/2019)

Con:

The theory behind the method in this particular example could be more expanded (02/09/2019)

Now moved here: https://training.galaxyproject.org/feedback


feat: allow use system environment variables.

Problem:
I know it can use user  variables but typing that every time is annoying.
It will better I can use system environment variables.
Solution:
allow to use system environment on command.

Thanks for the contribution!


US 09.01.01 As an owner, I don’t want to store big images online.

As an owner, I don’t want to store big images online.
Acceptance Criteria

The game must employ  alternate means to ensure that big images are not stored online
The alternate means of storage must not impede the user in any way
The alternate means must prioritize speed and efficiency to ensure a fast user experience
The alternate means must not compromise the security of the game in any way

Does firebase include an image compression feature or format conversion (to smaller format) feature? We need to consider ways we upload photos to firebase (like, are we reducing to photo to smaller size with an acceptable resolution?, etc)

While I do not see anything about native compression, I'm sure we can consider intuitive methods of efficient data compression via third party dependencies or image resizing.

Photo capturing algorithm will compress the jpeg photos before uploading to firebase storage (avg size is 34kb, not much in my opinion).


DX: Use "yield from" in tests

The scenario is almost always the same, huge array $tests and the foreach with yield and some if after:
        $tests = [/** ... */];

        foreach ($tests as $index => $test) {
            yield $index => $test;
        }

        if (\PHP_VERSION_ID < 80000) {

I would argue we should extract conditional cases into dedicated providers with @require annotations, but this can be done later.

I'd like to discuss it, so we have some order in tests/providers, so when bumping lowest PHP version we have this, not this.

i'm open to discuss how to have conditional tests existing, but IMHO it's good value to see some tests were skipped due to missing requirements.
it;s different to say " 100 / 100 tests passed" vs "100 / 150 tests passed and 50 could not be executed due to not fulfilled requirements"

Thank you @kubawerlos.

it;s different to say " 100 / 100 tests passed" vs "100 / 150 tests passed and 50 could not be executed due to not fulfilled requirements"

what I would REALLY like is to have a way to get reported tests that are skipped in every PHP version we support (like the removed one with @requires PHP <7.0 from https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/5902).

Coverage remained the same at 92.294% when pulling 09ab5acd30a46865735516a1778c32f5e407b1aa on kubawerlos:use_yield_from_in_tests into 1127221c0c3beaac7a581d8ea20e539ba55c1e56 on FriendsOfPHP:3.0.


Fixed CancelUpgrade; CallDelete must not be wrapped by scoped_lock

I'm really sorry

It looks fine. But let me merge in the morning just in case I missed something.


allow U2F with default settings for gitea in subpath

credit to @zeripath for logic

Codecov Report

Merging #12990 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #12990      +/-   ##
==========================================
- Coverage   42.59%   42.59%   -0.01%
==========================================
  Files         671      671
  Lines       73625    73625
==========================================
- Hits        31363    31360       -3
- Misses      37180    37183       +3
  Partials     5082     5082

Impacted Files
Coverage Δ

modules/setting/setting.go
47.61% <100.00%> (ø)

modules/charset/charset.go
68.53% <0.00%> (-4.50%)
:arrow_down:

services/pull/check.go
47.69% <0.00%> (-0.77%)
:arrow_down:

modules/queue/unique_queue_disk_channel.go
55.38% <0.00%> (+1.53%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7670a9d...b9ca15c. Read the comment docs.

Blocking this as it needs more testing.

Looking at the settings code it is definitely the case that the AppSubURL does not have a terminal "/" and it is always the case the the AppURL has a terminal slash - therefore the proposed PR is correctly stripping off the AppSubURL


Errors from queued jobs aren't sent until the queue runner is restarted

Exceptions from queued background jobs are logged properly, but they only seem to be sent to the remote Sentry server when you manually restart or shut down the queue runner. I assume that's the intended behavior for HTTP requests, but for queue runners it means reports are delayed indefinitely (or lost).
I'm using the Horizon queue runner, but I assume this happens with the basic one as well.
I think this was handled in #153, but the sendUnsentErrors method was removed from a later version of sentry-php so I'm not sure what the best method to fix this would be at this point.

@misenhower sorry about the late response.
As long as the default transport is used reports should be sent immediately, did you implement the SpoolTransport?

Nope, nothing out of the ordinary. I set up a test project here that demonstrates the issue: https://github.com/misenhower/laravel-sentry-test
After checking out the repo:
cp .env.example .env
touch database/database.sqlite
composer install
php artisan migrate

Then add a Sentry DSN inside .env.
You can add a job that will throw an exception to the queue with:
php artisan sentry:test

If you run the queue worker, it will process and fail the job but the exception won't be reported to Sentry as long as the worker is running:
php artisan queue:work --tries=1

So that's the issue I'm running into -- failed jobs aren't reported while the queue worker is running.
If you hit ctrl+c, it won't report the job either (probably because it isn't a clean exit) and any accumulated reports will be lost.
If you tell the queue worker to quit when its queue is empty, then errors will be reported after it finishes processing jobs, right before the worker exits (gracefully):
php artisan queue:work --tries=1 --stop-when-empty

Let me know if you need any more info or if you're seeing something different! 😃

@misenhower you got my attention with this, many thanks! I can reproduce the issue! Going to hunt for a solution!

Just come across this too - errors occurring in Horizon are not being reported to Sentry.

@misenhower & @dwightwatson, we have some hurdles not allowing us to implement a proper fix so I crafted up a temporary one until we can fix the base SDK.
I would appreciate if you all could take a look at #228 and see if that would solve the issues described in this issue.

Thanks @stayallive, I'm out of town right now but I will check this out next week. Thanks for all your effort, that seemed to kick off a long chain of comments 😄

Yeah this is going to require some effort to really "fix" in the end. But in the meantime the #228 PR is there to get a fix out soon while we work out the details :)

Hey, sorry for my delay on this. I just tested out the code from #228 with my sample project as well as a real project and it seems to fix the problem in both of them. So everything looks good from what I can see, thanks again for your help! 👍

[...] did you implement the SpoolTransport?

Sorry for disturbing here, but is there anywhere more information about how to do this in Laravel @stayallive ?

@andre-hh I am not sure what you are asking here. But if you have a question not related to sending errors from a queue until it's restarted please open a new issue with your question so we can follow it better.
This issue is fixed in 1.0.2 and above of sentry/sentry-laravel.

I'm wondering if this issue has re-surfaced in Laravel 9. I'm seeing "failed jobs" in the Horizon dashboard that aren't being reported to Sentry. Wondering if anyone from this thread has noticed the same behaviour - perhaps some event names have changed and broken reporting.

@dwightwatson are you sure the exception with what those jobs failed are not ignored by default (like a ModelNotFoundException) or the job has a failed method?

https://docs.sentry.io/platforms/php/guides/laravel/usage/#queue-jobs

Feel free to open up a new issue with a little more info so we can investigate if needed.

Yeah - everything in my failed job list should have been reported - all proper exceptions.
I'll review closer and open a new issue if I can narrow it down.


Add a router

Currently, the only way we route is by using the filesystem. This isn't very versatile so it would be nice to have a routes.js or router.js file that defines what routes there are. Note that if this file exists then we do NOT automatically import any routes. They must be defined in that file.
The challenge is figuring out how to define routes easily. I think the way jest does it with nested functions is pretty nice (to allow for scoping). We also need to figure out the syntax of each route. Maybe something like this: router.get('/', 'index')?

Next does something interesting. If you want the route: /post/hello-world, you create the following file: /pages/post/[id].js and you can access it from router.query.id.


NullReferenceException when trying to start server or host after canceling client

A small bug I encountered - when using the network manager HUD, if I start a client and then cancel and try to create a host or server the following exception is raised:
Client Recv Exception: System.NullReferenceException: Object reference not set to an instance of an object
at Telepathy.Client.ReceiveThreadFunction (System.String ip, System.Int32 port) [0x00019] in C:\Users\user\Desktop\Test\Assets\Mirror\Runtime\Transport\Telepathy\Client.cs:60
UnityEngine.Debug:LogError(Object)
Telepathy.Client:ReceiveThreadFunction(String, Int32) (at Assets/Mirror/Runtime/Transport/Telepathy/Client.cs:84)
Telepathy.<>c__DisplayClass11_0:b__0() (at Assets/Mirror/Runtime/Transport/Telepathy/Client.cs:144)
System.Threading.ThreadHelper:ThreadStart()
Repro project
This can be reproduced on the Mirror Basic example scene:
https://github.com/vis2k/Mirror/tree/master/Assets/Mirror/Examples/Basic
To Reproduce

Open the scene in the unity editor
Click LAN Client
Click Cancel Connnection Attempt
Click LAN Server or LAN Host
Unity pauses and the error is shown in the console

Expected behavior
No error is raised
Desktop (please complete the following information):

OS: Windows
Build target: standalone
Unity version: 2018.4.12f1
Mirror branch: version 5.0.2

I can't reproduce it

I can every time.

doesn't seem to happen on mac.
mrgadget and op are both on windows

Why was this closed?
Although I would have asked if this was fixed. Mirror 5.x is obsolete.

Vis and I worked on this today and fixed it in PR 1408 above.


Update kubernetes deps to v0.31.0

This PR contains the following updates:

Package
Type
Update
Change

k8s.io/api
require
minor
v0.30.3 -> v0.31.0

k8s.io/apimachinery
require
minor
v0.30.3 -> v0.31.0

k8s.io/client-go
require
minor
v0.30.3 -> v0.31.0

Release Notes

kubernetes/api (k8s.io/api)
v0.31.0
Compare Source

kubernetes/apimachinery (k8s.io/apimachinery)
v0.31.0
Compare Source

kubernetes/client-go (k8s.io/client-go)
v0.31.0
Compare Source

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: undefined
Command failed: make
/home/ubuntu/go/pkg/mod/k8s.io/api@v0.31.0/core/v1/doc.go:21:1: missing argument "" (at <input>)
/home/ubuntu/go/pkg/mod/k8s.io/api@v0.31.0/core/v1/doc.go:21:1: missing argument "" (at <input>)
k8s.io/api/core/v1:-: unknown type "k8s.io/api/core/v1".Pod
k8s.io/api/core/v1:-: unknown type "k8s.io/api/core/v1".Pod
aerf.io/renovate-learning/pkg/api/v1alpha1:-: unable to locate schema for type "k8s.io/api/core/v1".Pod
Error: not all generators ran successfully
run `controller-gen crd paths=./pkg/... output:crd:artifacts:config=./crds -w` to see all available markers, or `controller-gen crd paths=./pkg/... output:crd:artifacts:config=./crds -h` for usage
make: *** [Makefile:31: generate-crds] Error 1

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.


remove operations modules from services

The models are still generated in a models submodule, but the operations are now directly in the module. This also removes the "generated by AutoRust" header.

Replaced by #984 with no conflicts.


Arc - Fix sqlmiaa initial load

Fixes this bug where the sqlmiaa pages do not load until you click refresh.  Reproduces every time in my environment.

Cause: The models finish refreshing before the UI pages subscribe to model changes.
The code looks something like this:
dashboard = azdata.window.createModelViewDashboard(...)
dashboard.registerTabs(() => // create UI pages);
await dashboard.open();

// Kick these off without waiting for them to finish
controllerModel.refresh()
miaaModel.refresh()

The models finish refreshing before the registerTabs callback is executed.  When the models fire their updated events, the UI pages have not yet been created and therefore miss the events.
The pages were designed to initialize the UI with empty data, and rely on the model update events to initialize the data.
There are 2 ways to fix it.

Move the model refresh to inside the registerTabs callback.  This way the UI pages are created before we initiate the model refreshes.

Initialize the UI with data from the model instead of empty data.

I think (2) is the way to go based on a similar but different bug I saw in the Postgres pages.  In that bug, the models finished refreshing after the UI page was constructed, but before it finished initalizing.  eventuallyRunOnInitialized would do its job to delay the refresh until the page was initialized.  But the UI would still show empty data sometimes.  There's some race here I don't fully understand.  But the fix was (2) so applying same idea to sqlmiaa.

Coverage decreased (-0.01%) to 35.399% when pulling 7d856c67b0f210ac7bc934ea75c0e28a5ba77eb1 on brberger/arc-sql-load into e452cd20d401e1d2875de34cba8bb783c3d071f8 on main.


Add prerequisite to README

Please answer the following questions and leave the below in as part of your PR.

[ ] This PR corresponds to an issue with a clear problem statement.

[ ] I have updated the CHANGELOG.md file with a description of the addressed issue.

Thanks!


Implement BasicSnippet for AddU64

Remove its implementation of DeprecatedSnippet.
Also, use pick & place over swap for marginally more efficient stack manipulation.

Looks very good. Two remarks:

Maybe expose bind the error code 310 and expose it in case someone wants to use it downstream?
Normally, we have LHS on the bottom of the stack, then RHS, since this corresponds to how Rust would translate to a stack machine, first evaluating the LHS of the expression, then RHS.

we have LHS on the bottom of the stack

Has that convention changed at some point? To name just a few, the previous version of this snippet, LtU128 introduced in #142, and AndU64 all have the right-hand side at the bottom of the stack. In fact, the only two snippets that seem to expect the left-hand side on the bottom of the stack[^regex] are LtDigest and OverflowingAdd for u64.
[^regex]: I'm using the regex before.*lhs.*rhs for this search


Added the DOCUMENT_ROOT for the custom runtime

cc @nkubala

@dpebot merge when green

@dpebot you can do it


[CI] Job to update REST and GraphQL docs

Current Behavior
The Meshery REST API docs obtains information to be displayed from docs/_data/swagger.yml, which is built using the following make command
## Build Meshery REST API documentation
swagger-docs-build:
	swagger generate spec -o ./docs/_data/swagger.yml --scan-models; \
	swagger flatten ./docs/_data/swagger.yml -o ./docs/_data/swagger.yml --with-expand --format=yaml

GraphQL docs are built using the following make command
## Build Meshery GraphQL API documentation
graphql-docs-build:
	cd docs; bundle exec rake graphql:compile_docs

Desired Behavior
These commands should be run in a build workflow and auto-committed, to ensure that both the REST and GraphQL docs are always upto date
Implementation

Acceptance Tests

Contributor Guides and Handbook

🛠 Meshery Build & Release Strategy
📚 Instructions for contributing to documentation

Meshery documentation site and source

🎨 Wireframes and designs for Meshery UI in Figma
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

Is it open for contribution? Then i can work

@abdullah1308 While investigating this issue, I discovered that the Makefile contains commands for updating the REST and GraphQL API documentation. I have a question regarding the execution of the Makefile during the build process. If the Makefile is executed every time during the build, it may not be necessary to include the commands in the build workflow. However, if the Makefile is not executed automatically, I would like to know in which build workflow it should be added.
Thanks, Regards
Hitesh

@suhail34 @Hs809 This issue is open for contribution. The changes have to be added to the Meshery Build and Releaser (stable and edge) workflows.

Aren't we doing the same thing here only thing we aren't doing is not authocommiting the changes and have to update the path for filters to work
https://github.com/meshery/meshery/blob/0bebcb79aacde419a376b4a424ff9796f912481f/.github/workflows/build-ui-and-server.yml#L290-L343

@suhail34 Hey take a look at these workflows -
https://github.com/meshery/meshery/blob/0bebcb79aacde419a376b4a424ff9796f912481f/.github/workflows/redocly.yml#L1
https://github.com/meshery/meshery/blob/0bebcb79aacde419a376b4a424ff9796f912481f/.github/workflows/graphql.yml#L1
We would want to add these with appropriate filters to the build-and-release workflows as we would want to update the docs on a release. The workflow that you've mentioned is the build-ui-and-server workflow which runs on every PR to ensure that both Meshery UI and server are built.


🐞 - v3 docs version switcher broken

Playground Link
No response
Description

Navigate to any component description in the documentation site
Try to switch from v4 to v3
Instead of redirecting to /v3/components/button, it redirects to /v3/ index page
Pressing Browse components redirects back to v4 docs

Angular version
No response
Taiga UI version
No response
Which browsers have you used?

[X] Chrome
[ ] Firefox
[ ] Safari
[ ] Edge

Which operating systems have you used?

[ ] macOS
[X] Windows
[ ] Linux
[ ] iOS
[ ] Android

Ok, after clearing local storage and hard refresh, seems to be working again.

@hakimio It was my mistake, sorry

No problem. Thanks for quick fix.


[Content creation - Youtube Import ] Mktg video recording 7/19

Thank you, @Emily-Jiang or @jclingan for helping with export to youtube!

I could not upload the recording to youtube as the login does not approve my device:(
his device isn’t recognized. For your security, Google wants to make sure it’s really you. Learn more
@jclingan I think it might have to send a code to the mobile number associate with the microprofileio email.

@Emily-Jiang,
You need to be added as an admin to the MP Youtube channel. You are not yet based on the INFRA spreadsheet inventory
4 MicroProfilers have access.
@jclingan can you please add Emily to the tool?
Emily, once you gain access, please update the INFRA sheet. Thank you everyone,


"issue retrieving Bootstrap's version" - even when Bootstrap loaded first

Using with Angular 5, I'm getting the following error:
bootstrap-select.min.js:7 There was an issue retrieving Bootstrap's version. Ensure Bootstrap is being loaded before bootstrap-select and there is no namespace collision. TypeError: Cannot read property 'Constructor' of undefined
    at bootstrap-select.min.js:7
    at bootstrap-select.min.js:8
    at bootstrap-select.min.js:7
    at bootstrap-select.min.js:7

I'm loading bootstrap first, here's the relevant part of my angular.json:
            "scripts": [
              "node_modules/jquery/dist/jquery.min.js",
              "node_modules/popper.js/dist/umd/popper.min.js",
              "node_modules/bootstrap/dist/js/bootstrap.min.js",
              "node_modules/bootstrap-select/dist/js/bootstrap-select.min.js",
              "src/assets/Scripts/classList.min.js"
            ],
            "styles": [
              "node_modules/bootstrap/dist/css/bootstrap.min.css",
              "node_modules/bootstrap-select/dist/css/bootstrap-select.min.css"
            ],

package.json:
"dependencies": {
  "@angular/animations": "^5.0.0",
  "@angular/common": "^5.0.0",
  "@angular/compiler": "^5.0.0",
  "@angular/core": "^5.0.0",
  "@angular/forms": "^5.0.0",
  "@angular/http": "^5.0.0",
  "@angular/platform-browser": "^5.0.0",
  "@angular/platform-browser-dynamic": "^5.0.0",
  "@angular/platform-server": "^5.0.0",
  "@angular/router": "^5.0.0",
  "@types/sprintf": "^0.1.0",
  "@types/sprintf-js": "^1.1.0",
  "bootstrap": "4.0.0-beta.2",
  "bootstrap-select": "^1.13.1",
  "core-js": "^2.4.1",
  "file-saver": "^1.3.3",
  "font-awesome": "^4.7.0",
  "intl": "^1.2.5",
  "jquery": "^3.2.1",
  "mydatepicker": "^2.6.3",
  "popper.js": "^1.14.3",
  "rxjs": "^5.5.2",
  "sprintf-js": "^1.1.1",
  "zone.js": "^0.8.14"
},

Would appreciate an assistance ;-)

It looks like you're using a beta version of Bootstrap 4. Do you still get the error with a stable release?

the problem is here:
version.full = ($.fn.dropdown.Constructor.VERSION || '').split(' ')[0].split('.');
release "bootstrap-select": "1.13.1".

Any way anybody can link me to a live example so I can get a better look at what's happening?

I'm not 100% sure what the source of your issue is (obviously I'd like to get to the bottom of it). In any case, I'll be adding a new option in the next release - BootstrapVersion - that will allow you to specify the version as a workaround for any detection issues. Here is a snippet documenting it:

Because there are some changes in class names and layout between Bootstrap 3 and Bootstrap 4, bootstrap-select needs to know the version of Bootstrap you are using. By default, bootstrap-select automatically detects the version of Bootstrap. However, there are some instances where the version detection does not work properly (e.g. Bootstrap is being loaded asynchronously or there is a namespace collision). For now, bootstrap-select defaults to using Bootstrap 3 formatting if version detection fails. This will be changed in the next major release.
You can manually specify Bootstrap's version via bootstrap-select's Constructor.BootstrapVersion object:
$.fn.selectpicker.Constructor.BootstrapVersion = '4';

Also, as a note, I'm no longer developing in this repository due to a disagreement with Silvio. I've moved development to https://github.com/snapappointments/bootstrap-select. Please post all future issues there to ensure they're seen.

I am using this library along with react and it gives the same issue did any of you guys found the solution

@H27-VEN I was able to solve this by referencing the source .js file directly instead of requiring the package by name:
require('bootstrap-select/js/bootstrap-select.js');
If I tried referencing the dist .js file directly, as show below, I had the same error as requesting the package by name:
require('bootstrap-select/dist/js/bootstrap-select.js);

Support for BootstrapVersion has been released in v1.13.2! See https://developer.snapappointments.com/bootstrap-select/options/#bootstrap-version for more info.

I had the same issue in my angular app, but only when using it via 'selectpicker' class, after change to js  everything works fine.

Same here with a Ruby app running Sinatra and using HAML. Changing to JS worked as well.

Just placed jquery.js before bootstrap.js and got fixed.

Does not work even after putting it after jquery file. I put this file in the end of the scripts list. It still does not work.

Just placed jquery.js before bootstrap.js and got fixed.

Amazing... I got it

In which file $.fn.selectpicker.Constructor.BootstrapVersion = '4'; needs to be specified?

I am getting the same error in bootstrap 5. only works in bootstrap version 4.6.2

I'm having this issue with Bootstrap 5. Is there a resolution yet?

Downgrading Bootstrap from 5.x to 4.6.2 worked to me!


Update README.md

Why:
Closes [issue link]

What's being changed:

Check off the following:

[x] I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
[x] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[x] This pull request impacts the contribution experience

[ ] I have added the 'writer impact' label
[ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@vladdoster Thanks for opening this PR! You can convert this to ready for review when you are done with making changes ✨

Should I rebase my commits? I couldn't find any docs stating it as a PR requirement.

@vladdoster
This seems to be opened accidentally, I am going to close it now :yellow_heart: Take a look at the contributing.md to learn how to contribute in this repo. You can open a discussion if you have any questions :sparkles:


Hystrix thread pool queue size doesn't get set correctly

Hello,
I'm trying to increase the "wait" queue in the thread pool, but the queue size appear to remain the same (by default 5 I think). In the unit test below, I expect no RejectedExecutionException to be thrown because the maxQueueSize is set to 20. The idea is to have the client send a bunch of requests to Hystrix pool to be processed asynchronously. The client doesn't care about the result.
From this, what's the difference between the maxQueueSize parameter and queueSizeRejectionThreshold? If I set the queueSizeRejectionThreshold instead of maxQueueSize, i don't get the RejectedExcecutionException anymore
    @Test
    public void shouldNotThrowRejectedException() {

        final int threadPoolCoreSize = 2;
        final boolean fallBackEnabled = false;
        final boolean circuitBreakerEnabled = false;
        final int executionTimeoutInMilliseconds = 20000;
        final int maxQueueSize = 20;

        String groupKey = "sendMail";
        HystrixCommandKey commandKey = HystrixCommandKey.Factory.asKey(groupKey);

        HystrixCommand.Setter setter = HystrixCommand.Setter.withGroupKey(com.netflix.hystrix.HystrixCommandGroupKey.Factory.asKey(groupKey)).andCommandKey(commandKey)
                .andThreadPoolPropertiesDefaults(HystrixThreadPoolProperties.Setter()
                                .withAllowMaximumSizeToDivergeFromCoreSize(true).withMaximumSize(maxQueueSize)
                                .withCoreSize(threadPoolCoreSize)
                                .withMaxQueueSize(maxQueueSize)
                )
                .andThreadPoolKey(new HystrixThreadPoolKey() {
                    @Override
                    public String name() {
                        return "ThreadPoolForSendMail";
                    }
                })
                .andCommandPropertiesDefaults(HystrixCommandProperties.Setter()
                        .withCircuitBreakerEnabled(circuitBreakerEnabled)
                        .withFallbackEnabled(fallBackEnabled)
                        .withExecutionTimeoutInMilliseconds(executionTimeoutInMilliseconds));

        for(int i = 0; i < 10; i++) {
            HystrixCommand cmd = new HystrixCommand(setter) {
                @Override
                protected Object run() throws Exception {
                    try {
                        MDC.setContextMap(MDC.getCopyOfContextMap());
                        System.out.println(Thread.currentThread().getName() + " starts work " + new Date());
                        Thread.sleep(2000);
                        System.out.println(Thread.currentThread().getName() + " finnish work " + new Date());
                    } finally {
                        MDC.clear();
                    }
                    return null;
                }
            };

            cmd.queue();
        }

        assertTrue(true);
    }

The queueSizeRejectionThreshold default is 5. Please try to set this property as the same as maxQueueSize.

As I mentioned in the post, if I set the queueSizeRejectionThreshold to a large enough value, the problem goes away. My question is, what's the difference between maxQueueSize vs. queueSizeRejectionThreshold?

The maxQueueSize value is what gets read to set up the static data structure used by the first invocation of the thread pool.  The queueSizeRejectionThreshold is the value of the queue length that triggers rejection.  By definition, queueSizeRejectionThreshold <= maxQueueSize.  Having 2 values allows some amount of dynamic behavior without a restart, since queueSizeRejectionThreshold may be adjusted anywhere between 0 and maxQueueSize.

I see. Thank you


BuildingCard.tsx Damage Calc Update

Initial damage loop would cutoff if building couldn't be destroyed with Zaps alone. This change allows the loop to continue if that isn't the case. Tested with Zap 7 and Earthquake 4 against Eagle Artillery 3.

Found an issue, going to fix and resubmit.


Adding Home in navbar

Right now, the potato icon will take us to the home page.
But some users might not know this functionality.
Adding the word "Home" to the potato icon will defeat the purpose of using an icon here.
So I think it is better to add a new tab to the navar, called "Home". When the user clicks on it, it should bring us to the home page.
Should be easy, you need to go add a new Route in app.js and add the logics in the navbar.jsx as well. Should be a simple fix.

Issue closed from Andres's merge.

Issue closed from Andres's merge.


Better checking if type symbol implements special type interface

When I was working on PutInsideUsing and IterateViaForeach refactorings I noticed that checking if type symbol is IDisposable or IEnumerable is tricky.
This pull request adds mechanism to check if type symbol implements specific special type interface and updates both refactorings to use it.

Indeed, I had core.autocrlf set to false.
Changed & rebased, so now there are no EOL changes.

Thank you! And sorry, I'll be able to check this only after my vacation.

No problem. Have a good time :)

Thanks!


Cannot create resource groups with parenthesis

$ az resource group create -l westus -n "derek(1"
Parameter 'resource_group_name' must conform to the following pattern: '^[-\\w\\._]+$'.

From the documentation at https://msdn.microsoft.com/en-us/library/azure/dn790546.aspx:
{resource-group-name} must uniquely identify the resource group within the subscription. It must be no longer than 80 characters long. It can only contain alphanumeric characters, dash, underscore, opening parenthesis, closing parenthesis or period. The name cannot end with a period. Currently, using a parenthesis in the name causes problems when using Azure PowerShell or Azure CLI. Therefore, we recommend you avoid using an opening or closing parenthesis in the name.
Creating this issue to track this along with xplat CLI and PowerShell.
https://github.com/Azure/azure-xplat-cli/issues/3109
https://github.com/Azure/azure-powershell/issues/2768

The Swagger file was updated with this fix (https://github.com/Azure/azure-rest-api-specs/pull/490).
When the new azure-mgmt-resources SDK package is released (0.30.0rc6?), this will be fixed and the issue can be closed.

@derekbekoe and @yugangw-msft : Is this change in with the RC6 update we just did.

Verified that this is working now. Closing issue.


Error: 404 - failed to download

The download fails since the latest selenium version is in alpha. The latest version is parsed as 4.0.0, that generates this download url: https://selenium-release.storage.googleapis.com/4.0/selenium-server-standalone-4.0.0.jar.
But that file does not exist, there is only an alpha release of 4.0.0 and the url to download that one is https://selenium-release.storage.googleapis.com/4.0/selenium-server-standalone-4.0.0-alpha-1.jar
I suggest that alpha versions are ignored and that the script shall continue downloading the 3.9.1 version until 4.0.0 is stable

Hi,
this is indeed a real blocker for us !
Thanks for your help !

I do not have the time to do a nice and proper fix today, but here is a temporary fix that works if it helps someone:
https://github.com/andreaspsson/selenium-download/commits/fix/handle-4.0-alpha

Thanks for the report & the fix! I'll see if I can create a PR based on those changes.

I created a fix based on code in the branch above: https://github.com/groupon/selenium-download/pull/50


Why should this module not be used?

The github description says [DON'T USE THIS MODULE PLEASE] but the readme doesn't say why not, and looking at the open issues doesn't make it clear either.
It would be good to put a sentence or two in the readme that says what's wrong with the module.

+1

Partly because of https://github.com/sindresorhus/deep-assign/issues/6.

Explained here: https://github.com/sindresorhus/deep-assign/commit/b3320626909f7b60c06292b09f6b025488374f97


Trouble with Untappd

I'm having an issue with Untappd where, after sign-in, I get an error back from Untappd stating that the redirect_url or client_id is missing. I'm not really sure how to debug this issue. If I call dialogUrl() on the class I implemented, the URL includes both of those parameters.
I know Untappd had an OOTB implementation in ng-cordova-oauth and I looked it it... didn't see anything out of the ordinary there.
`
// Start OAuth2
let oauth: OauthCordova = new OauthCordova();
interface IUntappedOptions extends IOAuthOptions {
}

let oauthProvider: OAuthProvider = new class extends OAuthProvider {
  protected authUrl: string = 'https://untappd.com/oauth/authenticate';
  protected defaults: Object = {
    responseType: 'token'
  };

  constructor(options: IUntappedOptions = {}) {
    super(options);
  }

}({clientId: 'xxxxxx'} );
console.log(oauthProvider.dialogUrl());

this.platform.ready().then(() => {
        oauth.logInVia(oauthProvider, {location:'yes', fullscreen: 'yes'}).then(success => {
            console.log("RESULT: " + JSON.stringify(success));
        }, error => {
            console.log("ERROR: ", error);
            this.showToast('Error linking Untappd');
        });
    });

`

I found the issue myself. Untappd is not following the OAuth standard of using redirect_uri, instead they are using redirect_url. In my subclassing of OAuthProvider, I had to override the optionsToDialogUrl method, which leads to lots of copy/paste code.

Merged into development branch.


http-01, invalid, urn:acme:error:unauthorized, status 403

What might be causing this error?
The diagnostics test provided in /docs/troubleshooting.md passes. See below.
The config file is using staging CA, per staging.md
Here is complete history of latest attempt:
[letsencrypt@or97 ~]$ bash dehydrated/dehydrated -c -f /home/letsencrypt/config
`# INFO: Using main config file /home/letsencrypt/config
Processing or97.net

Signing domains...
Generating private key...
Generating signing request...
Requesting challenge for or97.net...
Responding to challenge for or97.net...
ERROR: Challenge is invalid! (returned: invalid) (result: {
"type": "http-01",
"status": "invalid",
"error": {
"type": "urn:acme:error:unauthorized",
"detail": "Invalid response from http://or97.net/.well-known/acme-challenge/VuYLOVM67NO_vVlYmbQYyBJcUVnNhEUhrIPS7auZjM8 [<IP_ADDRESS>]: 404",
"status": 403
},
"uri": "https://acme-staging.api.letsencrypt.org/acme/challenge/ScDB3W7f9fcLmt_8s3waNELOY9sJ1QInzkR0nkEeKeI/19674597",
"token": "VuYLOVM67NO_vVlYmbQYyBJcUVnNhEUhrIPS7auZjM8",
"keyAuthorization": "VuYLOVM67NO_vVlYmbQYyBJcUVnNhEUhrIPS7auZjM8.SjR9lX0eFmmOyCAllb43DCesuKnhj7ocuE0buM6iZIY",
"validationRecord": [
{
"url": "http://or97.net/.well-known/acme-challenge/VuYLOVM67NO_vVlYmbQYyBJcUVnNhEUhrIPS7auZjM8",
"hostname": "or97.net",
"port": "80",
"addressesResolved": [
"<IP_ADDRESS>"
],
"addressUsed": "<IP_ADDRESS>"
}
]
})
`
I created a replica file using the same user. Here's the results:

$ telnet or97.net 80
`Trying <IP_ADDRESS>...
Connected to or97.net.
Escape character is '^]'.
GET .well-known/acme-challenge/VuYLOVM67NO_vVlYmbQYyBJcUVnNhEUhrIPS7auZjM8 HTTP/1.1
Host: or97.net
HTTP/1.1 200 OK
Server: NaviServer/4.99.12
Date: Thu, 05 Jan 2017 04:21:30 GMT
Set-Cookie: ad_user_login=""; Expires=Fri, 01-Jan-1980 01:00:00 GMT; Path=/
Set-Cookie: ad_secure_token=""; Expires=Fri, 01-Jan-1980 01:00:00 GMT; Path=/; Secure
Set-Cookie: ad_user_login_secure=""; Expires=Fri, 01-Jan-1980 01:00:00 GMT; Path=/; Secure
Set-Cookie: ad_session_id="78360046%252c0%252c0%252c1483590090%2b%257b874%2b1483591290%2bD68F6CFD05A841A5AD4F1DBAEF4E4CD3BF33DDB1%257d"; Expires=Fri, 01-Jan-2035 01:00:00 GMT; Path=/; Discard; HttpOnly
Last-Modified: Thu, 05 Jan 2017 03:54:55 GMT
Content-Type: /
Accept-Ranges: bytes
Content-Length: 8
Connection: keep-alive
success
Connection closed by foreign host.
`

server log shows a slight variation of the GET url from letsencrypt staging server than the one tested via telent; ie a '/' prefix:
<IP_ADDRESS> - - [05/Jan/2017:03:53:04 +0000] "GET /.well-known/acme-challenge/VuYLOVM67NO_vVlYmbQYyBJcUVnNhEUhrIPS7auZjM8 HTTP/1.1" 404 697 "" "Mozilla/5.0 (compatible; Let's Encrypt validation server; +https://www.letsencrypt.org)" "<PHONE_NUMBER>.020250  0.000284  0.000045  0.001559  0.000144"
However, all cases in the server log show the same GET url, and there doesn't seem to be a  different in the data returned via telnet on a retest with prefix '/'

You'll notice the server log shows 404 for this case, but the log shows the server returns 200 for the test cases.
Is it possible this is a timing issue between dehydrated and letsencrypt? Is the script removing the file before it's checked, or is it possible the file is created and removed after its checked?

This normally happens when WELLKNOWN isn't configured correctly, it should point directly to the directory you are serving under /.well-known/acme-challenge.
There also can't be a timing problem, the script creates the files before the checks and doesn't remove them until after everything is completed.
I'm closing this for now as it really just seems to be a configuration issue.

You write: WELLKNOWN "should point directly to the directory you are serving under /.well-known/acme-challenge."
To be clear, I've tried pointing WELLKNOWN at different directories in the server's delivery tree, including one that doesn't send cookies with the content, but letsencrypt response is consistently a 404 error with reference to the server's root directory.
I know dehydrated is using other values from config; The evidence is in the lack of errors and the files returned in specified non-default locations.
Might value of WELLKNOWN get overwritten or lost somewhere?
Dehydration is supplied only 1 domain via domains.txt  (No www.or97.net.) Has this case been tested?

btw:
$ bash --version
GNU bash, version 4.3.42(1)-release
$ uname -r
10.3-STABLE

This seems conspicuously similar to issue #330 except producing a silent error later on. My understanding of bash is limited, but am investigating further.


add the project folder to PYTHONPATH

How do I perform this action?
Currently I have typed the following terminal commands:
python
import sys
sys.path.append("path/to/Modules")
print (sys.path)

Run in terminal:
export PYTHONPATH=/path/to/StackGAN-Pytorch
or in case of non empty PYTHONPATH:
export PYTHONPATH=$PYTHONPATH:/path/to/StackGAN-Pytorch


Non expected behavior when showing an alert inside the completion block from an other alert

Thank you Alexander for making this great control available!
Problem:
The second alert seems to have a randomly behavior. Indeed, sometimes it's displayed, sometimes not.
And in all the cases, the bounce effect is not as smooth as the first alert.
Do you have any idea?
Thanks a lot.

Still have this issue.
Solved by putting the next PXAlertView into
dispatch_after(dispatch_time(DISPATCH_TIME_NOW, NSEC_PER_SEC), dispatch_get_main_queue(), ^{ /* **here** */ });


haskellPackages.generic-lens: dontCheck

Motivation for this change
The test suite for generic-lens currently fails to build.
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[X] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Fits CONTRIBUTING.md.

@GrahamcOfBorg build haskellPackages.generic-lens

No attempt on aarch64-linux (full log)
The following builds were skipped because they don't evaluate on aarch64-linux: haskellPackages.generic-lens
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-darwin (full log)
Attempted: haskellPackages.generic-lens
Partial log (click to expand)
Preprocessing test suite 'generic-lens-test' for generic-lens-<IP_ADDRESS>..
installing
Installing library in /nix/store/a2p1j28r0jmgs5xjcc1q4cnchbjwg97w-generic-lens-<IP_ADDRESS>/lib/ghc-8.4.3/x86_64-osx-ghc-8.4.3/generic-lens-<IP_ADDRESS>-2RHbhJokaSsFvWPnf3PoSt
post-installation fixup
strip is /nix/store/4w56qihlrddav67p7d1vy5qkyayaqw11-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/a2p1j28r0jmgs5xjcc1q4cnchbjwg97w-generic-lens-<IP_ADDRESS>/lib
patching script interpreter paths in /nix/store/a2p1j28r0jmgs5xjcc1q4cnchbjwg97w-generic-lens-<IP_ADDRESS>
strip is /nix/store/4w56qihlrddav67p7d1vy5qkyayaqw11-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/v6mydw76kd6s0mjy0i2ljnclld2aph81-generic-lens-<IP_ADDRESS>-doc
/nix/store/a2p1j28r0jmgs5xjcc1q4cnchbjwg97w-generic-lens-<IP_ADDRESS>

Success on x86_64-linux (full log)
Attempted: haskellPackages.generic-lens
Partial log (click to expand)
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/bh6ikpc2v1yqxgxz8ajwrsys5vlpdw42-generic-lens-<IP_ADDRESS>/lib
patching script interpreter paths in /nix/store/bh6ikpc2v1yqxgxz8ajwrsys5vlpdw42-generic-lens-<IP_ADDRESS>
checking for references to /build in /nix/store/bh6ikpc2v1yqxgxz8ajwrsys5vlpdw42-generic-lens-<IP_ADDRESS>...
wrong ELF type
shrinking RPATHs of ELF executables and libraries in /nix/store/i5iksfmhdjk069b3g660bbqipjjb7328-generic-lens-<IP_ADDRESS>-doc
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/i5iksfmhdjk069b3g660bbqipjjb7328-generic-lens-<IP_ADDRESS>-doc
checking for references to /build in /nix/store/i5iksfmhdjk069b3g660bbqipjjb7328-generic-lens-<IP_ADDRESS>-doc...
/nix/store/bh6ikpc2v1yqxgxz8ajwrsys5vlpdw42-generic-lens-<IP_ADDRESS>

Thanks @Taneb!