Android - New room - The page darkens and the drop-down menu is poorly visible

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open the app
Login with any account
Click on FAB button -> New Room
Open any drop-down window (Workspace or Visibility)

Expected Result:
The page doesn't go dark, and the drop-down menu is visible well
Actual Result:
The page darkens and the drop-down menu is poorly visible
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: no
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/210285310-8c197643-db76-438e-8c29-e6784fffdabb.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

I'm pretty sure this PR is the one that introduced the bug (cc @sketchydroide)

@deetergp This actually happens for any dropdown menus you pull-up on Android, it isn't unique to the New Room Page. Here's a screenshot after opening the language selector dropdown on the login page. I think we should test all the dropdowns on Android and create a new issue for this:

To add to this I don't think this needs to be a deploy blocker since no behavior is actually broken. This is purely a visual glitch.
cc @grgia @Luke9389 could this have anything to do with this dark theme PR?

I'm pretty sure https://github.com/Expensify/App/pull/13859 is the one that introduced the bug (cc @sketchydroide)

Not sure how this could be caused by that PR, it just checks if the language was changed and makes the componenent update if it did...
Am I missing something?

This PR solving this issue is causing a Deploy Blocker https://github.com/Expensify/App/issues/13951 Currently as the issue is locked so commenting here and tagging the issue. Already proposed solution on Slack.
To fix it we need to set color  to colorBackgroundFloating to fix the issue in styles.xml because applying background color dark to android app also causes Modals to be Dark.
As it is a Deploy Blocker I know the urgency to fix the issue so I will be available to raise a PR in next few minutes if assigned to the job.

diff --git a/android/app/src/main/res/values/styles.xml b/android/app/src/main/res/values/styles.xml
index a804c14ab..b30501c5b 100644
--- a/android/app/src/main/res/values/styles.xml
+++ b/android/app/src/main/res/values/styles.xml
@@ -10,6 +10,7 @@
         <item name="android:statusBarColor">#061B09</item>
         <item name="colorAccent">@color/accent</item>
         <item name="android:editTextBackground">@drawable/rn_edit_text_material</item>
+        <item name="colorBackgroundFloating">@color/white</item>
     </style>

     <!-- Themes unique to the boot splash page -->

After Fix :-
https://user-images.githubusercontent.com/81307212/210307867-943023cb-54eb-4854-a483-69785fe08d55.mp4

Proposal

cc @0xmiroslav since you mentioned a fix on your PR

Proposal
items={_.map(this.props.items, item => ({...item, color: Platform.OS === 'android' ? themeColors.text : themeColors.pickerOptionsTextColor}))}

@syedsaroshfarrukhdot your proposal only changes background color in dark theme. so ripple color is still white and user feels no ripple effect.

we could use @color/ripple_material_dark to change color of it

@0xmiroslav Instead of fixing the other way around i agree with you on this:

So the solution is to set picker text color to white in android (like video above), and still keep light mode (white background, dark text) in all other platforms. But eventually, we need to fix iOS and web too to apply dark theme to picker, either customizing this package or replace with other good package.
I will raise PR if this is agreed.

And can someone explain what exactly is the fix we are looking for here?

I think you're right @aimane-chnaif. We definitely want parity, so let's say the goal here is to apply the dark theme to the picker on all platforms.

Updated Proposal :-
We could decide upon ripple effect color which should be used.
diff --git a/android/app/src/main/res/values/styles.xml b/android/app/src/main/res/values/styles.xml
index a804c14ab..b66042132 100644
--- a/android/app/src/main/res/values/styles.xml
+++ b/android/app/src/main/res/values/styles.xml
@@ -10,8 +10,14 @@
         <item name="android:statusBarColor">#061B09</item>
         <item name="colorAccent">@color/accent</item>
         <item name="android:editTextBackground">@drawable/rn_edit_text_material</item>
+        <item name="colorBackgroundFloating">@color/white</item>
+        <item name="colorControlHighlight">@color/gray4</item>
     </style>

     <!-- Themes unique to the boot splash page -->
     <style name="BootTheme" parent="AppTheme">
         <item name="android:background">@drawable/bootsplash</item>

After Fix :-
https://user-images.githubusercontent.com/81307212/210423245-4e350861-5a31-4e6f-baea-e3fa5f547009.mp4

@syedsaroshfarrukhdot did you read #13951 (comment)?

Sorry missed it initially was updating proposal have just read it now after you highlighted it. Will look for a possible solution to implement darkmode for react native picker on all platforms. Thanks for highlighting.

Updated Proposal
We are able to handle Android and iOS in this regard. But web and desktop always end up using the system default. I don't see any ways to customize that. Even Github hasn't figured it out, their website follows the user's sytem defaults even if you set to dark mode in Github settings. So I guess its better for us settle with the mobile platforms.
/src/components/Picker/index.js
   <RNPickerSelect
      onValueChange={this.onInputChange}

      // We add a text color to prevent white text on white background dropdown items on Windows
-      items={_.map(this.props.items, item => ({...item, color: themeColors.pickerOptionsTextColor}))}
+      items={_.map(this.props.items, item => ({...item, color: Platform.OS === 'windows' ? themeColors.pickerOptionsTextColor : themeColors.text}))}

Android

/src/components/Picker/pickerStyles/index.ios.js
 const pickerStyles = isDisabled => ({
     ...styles.picker(isDisabled),
     inputIOS: styles.picker(isDisabled).inputNative,
+    done: {
+        color: '#ffffff',
+    },
+    doneDepressed: {
+        fontSize: 17,
+        color: '#aaaaaa',
+    },
+    modalViewMiddle: {
+        borderTopWidth: 0,
+        backgroundColor: '#232323',
+    },
+    modalViewBottom: {
+        backgroundColor: '#252525',
+    },
 });

 export default pickerStyles;

iOS

@aimane-chnaif by the way, when you say windows do you mean desktop(mac)? Because I didn't if know the app was targeted to windows as the Readme only had macOS mentioned. As for the issue currently there seems to be no way to achieve this on web and desktop. (Unless someone comes up with a solution)
And as for macOS if the user has set the system setting to dark mode then this is what we get in our app, which is what we want:

And on the web

But if the user switches the system setting to light mode then I guess we are left with no options as we cant be switching the system setting of the user.
We will wait and see what others come up with

FWIW I think this is a regression probably caused by https://github.com/Expensify/App/pull/13874 and the closest proposal to what we want is probably https://github.com/Expensify/App/issues/13951#issuecomment-1370123025, except switching the colors out from light to dark.
Reason being – https://github.com/Expensify/App/pull/13874 hard-coded the dark theme on Android, so it's fine to hard-code a dark theme for native modals too.

Though, I tried doing that suggestion, just with different colors, and then the modal didn't open at all for me on a physical Pixel 4a

@aimane-chnaif acutally github hasn't figured it out either. I'll attach some reference images:
MacOS
Chrome
System setting: light mode
Github setting: dark mode

As you can see it is still rendered as light picker (follows the system setting)

If we switch it other around like
System setting: dark mode
Github setting: light mode
Once again it simply follows the system setting regardless of what mode github is in.

As for mobile web:
Android
Chrome
System setting: light mode
Github setting: dark mode
Follows system setting again:

iOS
Safari
System setting: light mode
Github setting: dark mode
Same here:

@aimane-chnaif yep, you were right. Was able to get it to work on Windows web. Updated my proposal.

Though, I tried doing that suggestion, just with different colors, and then the modal didn't open at all for me on a physical Pixel 4a

It must be due to the issue which I reported we are currently facing Issue on opening picker on android on Physical Device. There is a PR up for it. It should be resolved soon.

@aimane-chnaif Its just the colors, the approach stays the same. We can choose the appropriate colors from the design team. But never the less, we should consider this upcoming PR as well,
for which i propose this fix in the index.html file within the style tag to fix the windows issue on top of my previous proposal. Because with the above PR's design changes the background color of the <Picker> component  has to be set as 'transparent' as it is now, which in turn breaks the windows theming as it is now. So the below fix promises future compatibility.
+ select option {
+ background-color: rgba(6,27,9,0.92); // to be replaced with the suitable color
+ }

@0xmiroslav honestly I've been putting time into this as well 😀. On Firefox also, my last suggestion works, but there is a slight border, which I think we might have to consider a trade off, taking into account this PR

@aimane-chnaif
If not we will have to pass a prop containing the background color to the picker component manually on each and every place it is used just to sort out this windows issue. And this color has to go hand in hand with the bg of where it is used. That way we can ensure it all would look the same. I wouldn't not recommend this approach, if were to get this windows issue sorted out no matter the cost this is the only way. For instance, <LocalePicker /> component encompasses the Picker component, and it is used in a couple of places, so we will have to edit LocalPicker once again to take in a prop which will then pass on to picker component. As you can see, I see this as the ultimate solution, but it involves a lot of moving parts, so it's hard to recommend. So Im just putting this out there, for the team to decide on this.
And by the way @0xmiroslav solution does not have a significant difference to my approach, its the same, with only change of colors 🤷♂ which will be ultimately has to be decided the by design team.

slight border is just the issue I meant. I don't think this is acceptable solution.

But It does work fine on all the major players in browsers

@aimane-chnaif Even with @0xmiroslav solution he is setting a background color. So the best bet, considering the way forward is this solution If not once this PR merges, it will once again set the color to be transparent and we have to start all over again.

@deetergp @aimane-chnaif are we agreed to HOLD this issue until we merge #12447?

Currently on hold. Going to bump this down to weekly till the hold is removed.

Removed Help Wanted because job is on hold, please add back when it's off hold

Still on hold

If you say so @aimane-chnaif :)

Proposal with fix for firefox
Android and iOS native app fixes are straight forward. Web on macOS always follows user's system settings. So we dont have any control in that.
But web on windows got a little tricky. To not break the design we will have to have the background color of the picker (select tag) to be transparent. So skipping select tag and passing a text color and a background to the underlying <option> tag using css solves it, except for Firefox.  So to fix firefox, we can't have transparent as the background color for the <select> tag, we will have to revert it. But that will cause another issue, where the whole component will have a gray background, which breaks the design.
To counter all of this, I target Firefox only, and revert the background color (which fixes the drop down), and then hide the select tag and render a Text where the select is, with the select's value. I have taken this value by processing within our wrapper component. But it would be nice if we can get it from the RNPickerSelect component by editing the package from the repo. I came across a thread where it was mentioned that these packages were to be included in this repo itself, not sure when that would happen.
Anyways, this fix will make the picker to be in dark mode all across.
Screenshots
Android

iOS

Web Windows - Chrome

Web Windows - Firefox

Note: We cant change Firefox's default dark mode dropdown background color (dark grey) without breaking our design.
Web Windows - Edge

Code
One thing to note is that in the following code snippets is that the colors are subject to change according to design preference.
diff --git a/src/components/Picker.js b/src/components/Picker.js
index 3350e5cc92..3e89f5ab2f 100644
--- a/src/components/Picker.js
+++ b/src/components/Picker.js
@@ -10,6 +10,8 @@ import Text from './Text';
 import styles from '../styles/styles';
 import themeColors from '../styles/themes/default';
 import {ScrollContext} from './ScrollViewWithContext';
+import * as Browser from '../libs/Browser';
+import CONST from '../CONST';

 const propTypes = {
     /** Picker label */
@@ -100,6 +102,7 @@ class Picker extends PureComponent {
         super(props);
         this.state = {
             isOpen: false,
+            selectedItemLabel: '',
         };

         this.onInputChange = this.onInputChange.bind(this);
@@ -110,6 +113,8 @@ class Picker extends PureComponent {
             ...this.props.placeholder,
             color: themeColors.pickerOptionsTextColor,
         };
+
+        this.isFirefoxOnWindows = Browser.getBrowser() === CONST.BROWSER.FIREFOX && Browser.isOnWindows();
     }

     componentDidMount() {
@@ -130,6 +135,8 @@ class Picker extends PureComponent {
      * @param {Number} index
      */
     onInputChange(value, index) {
+        this.setSelectedItemLabel({value});
+
         if (this.props.inputID) {
             this.props.onInputChange(value);
             return;
@@ -138,12 +145,45 @@ class Picker extends PureComponent {
         this.props.onInputChange(value, index);
     }

+    setSelectedItemLabel({value, index}) {
+        if (index >= 0) {
+            const selected = this.props.items[index] ? this.props.items[index].label : '';
+            this.setState({selectedItemLabel: selected});
+            return;
+        }
+
+        const idx = _.findIndex(this.props.items, item => item.value === value);
+
+        let selected = '';
+        if (idx >= 0) {
+            selected = this.props.items[idx].label || '';
+        } else if (this.placeholder) {
+            selected = this.placeholder.label || '';
+        }
+        this.setState({selectedItemLabel: selected});
+    }
+
+    getSelectedItemLabel() {
+        if (this.state.selectedItemLabel) {
+            return this.state.selectedItemLabel;
+        }
+
+        if (this.placeholder && this.placeholder.label) {
+            return this.placeholder.label;
+        }
+        return '';
+    }
+
     setDefaultValue() {
         // When there is only 1 element in the selector, we do the user a favor and automatically select it for them
         // so they don't have to spend extra time selecting the only possible value.
         if (this.props.value || !this.props.items || this.props.items.length !== 1 || !this.props.onInputChange) {
+            if (this.props.value) {
+                this.setSelectedItemLabel({value: this.props.value});
+            }
             return;
         }
+        this.setSelectedItemLabel({index: 0});
         this.props.onInputChange(this.props.items[0].value, 0);
     }

@@ -164,6 +204,22 @@ class Picker extends PureComponent {
                     {this.props.label && (
                         <Text style={[styles.pickerLabel, styles.textLabelSupporting]}>{this.props.label}</Text>
                     )}
+
+                    {this.isFirefoxOnWindows
+                        ? (
+                            <Text
+                                numberOfLines={1}
+                                style={
+                                    [this.props.size === 'normal'
+                                        ? styles.picker(this.props.isDisabled).inputWeb
+                                        : styles.pickerSmall.inputWeb,
+                                    styles.pickerValueLabelFirefox]
+                                }
+                            >
+                                {this.getSelectedItemLabel()}
+                            </Text>
+                        )
+                        : null}
                     <RNPickerSelect
                         onValueChange={this.onInputChange}

diff --git a/src/libs/Browser/index.js b/src/libs/Browser/index.js
index dbc21c9a1f..e5271ba793 100644
--- a/src/libs/Browser/index.js
+++ b/src/libs/Browser/index.js
@@ -10,8 +10,13 @@ function isMobileSafari() {
     return false;
 }

+function isOnWindows() {
+    return false;
+}
+
 export {
     getBrowser,
     isMobile,
     isMobileSafari,
+    isOnWindows,
 };
diff --git a/src/libs/Browser/index.web.js b/src/libs/Browser/index.web.js
index e7eb1db26d..9a9416ae99 100644
--- a/src/libs/Browser/index.web.js
+++ b/src/libs/Browser/index.web.js
@@ -50,8 +50,19 @@ function isMobileSafari() {
     return /iP(ad|od|hone)/i.test(userAgent) && /WebKit/i.test(userAgent) && !(/(CriOS|FxiOS|OPiOS|mercury)/i.test(userAgent));
 }

+/**
+ * Checks if requesting user agent is on Windows
+ *
+ * @returns {Boolean}
+ */
+function isOnWindows() {
+    const {userAgent} = window.navigator;
+    return userAgent.indexOf('Win') > -1;
+}
+
 export {
     getBrowser,
     isMobile,
     isMobileSafari,
+    isOnWindows,
 };
diff --git a/src/styles/styles.js b/src/styles/styles.js
index c58d05a50a..2c6e5feac4 100644
--- a/src/styles/styles.js
+++ b/src/styles/styles.js
@@ -35,6 +35,23 @@ const picker = {
     textAlign: 'left',
 };

+const iosBottomSheetPickerStyles = {
+    done: {
+        color: themeColors.text,
+    },
+    doneDepressed: {
+        fontSize: 17,
+        color: themeColors.buttonPressedBG,
+    },
+    modalViewMiddle: {
+        borderTopWidth: 0,
+        backgroundColor: '#232323',
+    },
+    modalViewBottom: {
+        backgroundColor: '#252525',
+    },
+};
+
 const link = {
     color: themeColors.link,
     textDecorationColor: themeColors.link,
@@ -608,6 +625,7 @@ const styles = {
             width: variables.iconSizeExtraSmall,
             height: variables.iconSizeExtraSmall,
         },
+        ...iosBottomSheetPickerStyles,
     },

     badge: {
@@ -863,8 +881,14 @@ const styles = {
         inputAndroid: {
             ...picker,
         },
+
+        ...iosBottomSheetPickerStyles,
     }),

+    pickerValueLabelFirefox: {
+        position: 'absolute',
+    },
+
     disabledText: {
         color: themeColors.icon,
     },
diff --git a/src/styles/themes/default.js b/src/styles/themes/default.js
index 823f58c598..618859ea68 100644
--- a/src/styles/themes/default.js
+++ b/src/styles/themes/default.js
@@ -58,7 +58,7 @@ const darkTheme = {
     dropUIBG: 'rgba(6,27,9,0.92)',
     dropTransparentOverlay: 'rgba(255,255,255,0)',
     checkBox: colors.green,
-    pickerOptionsTextColor: colors.midnight,
+    pickerOptionsTextColor: colors.white,
     imageCropBackgroundColor: colors.greenIcons,
 };

diff --git a/web/index.html b/web/index.html
index e11198fe94..5b3f89fd90 100644
--- a/web/index.html
+++ b/web/index.html
@@ -69,6 +69,26 @@
             -webkit-text-fill-color: #ffffff;
             caret-color: #ffffff;
         }
+
+        select option {
+            color: rgb(231, 236, 233);
+            background-color: rgba(6, 27, 9, 0.92);
+        }
+
+        @-moz-document url-prefix() {
+            @media not screen and (hover: none) and (pointer: coarse) {
+                select {
+                    color: revert !important;
+                    background-color: revert !important;
+                    opacity: 0 !important;
+                }
+
+                select option {
+                    color: revert !important;
+                    background-color: revert !important;
+                }
+            }
+        }
     </style>
     <meta name="viewport" content="width=device-width, user-scalable=no, initial-scale=1">
     <link rel="shortcut icon" id="favicon" href="/favicon.png">

proposals coming in hot! @aimane-chnaif and @deetergp would love your thoughts!

@0xmiroslav I have proposed the same solution as your latest proposal https://github.com/Expensify/App/issues/13951#issuecomment-1407762215 for web earlier here: https://github.com/Expensify/App/issues/13951#issuecomment-1372624790 But, I still don't recommend this approach as you'll have to go around passing this prop all over the place where the picker is used and will be used. Your solution wont work as is anywhere. Your proposal missed the implementation.

All things being equal, provided it doesn't cause a regression, I prefer @0xmiroslav's solution since it's smaller and doesn't target specific platforms. @aimane-chnaif, I'd love to get your thoughts.

@shawn is back from ooo Tuedsay!

The screenshots look good to me. Though to clarify, can we control the gray background color used here?

Cool, thanks for confirming - that works for me.

Thanks @shawnborton & @aimane-chnaif 👍 @adelekennedy let's hire @0xmiroslav to implement their solution.

📣 @0xmiroslav You have been assigned to this job by @mallenexpensify!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.2.70-1 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/14984

If no regressions arise, payment will be issued on 2023-02-20. :confetti_ball:
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

Was there a regression test? I'm not seeing it in this GH. Thanks!

@0xmiroslav I think your regression test proposal is acceptable.

I've chatted with @adelekennedy and believe the next step is payment. Adele will run with that process.

@0xmiroslav Thanks for flagging. I'm checking with @adelekennedy that the bonus has not been prepared following your post and we will initiate the process tomorrow.

done and done! Bonuses added


rapgenius-esque hover on confusing vocab words

hover tooltip is better than having a separate glossary page, so that users don't need to leave their current page

waiting on a list of words to define + definitions

@cathydeng I have started a list for these definitions: https://docs.google.com/spreadsheets/d/1UiAC4_UU0PPRPkAMXTiTg9aJrkgtXToBgoh_GnI9iMs/edit#


Clicking on tags brings up broken XML page

Both on your blog and mine, clicking on a tag in the tag cloud or on the All Tags page will break the webpage.

@Darthagnon
It probably is the empty file layouts/tags/term.html (ece0e00) that is causing it. Try to remove it in your copy of the theme, it should work then.
You can check the tags on my blog here: https://im.youronly.one/yuki/tags or an example tag https://im.youronly.one/yuki/tag/explained/

@techmagus Thank you for the clarification, someone said the same on the Hugo forums. I've been working on what is more-or-less a hard fork of this theme - do you have the source for your blog's version of the theme, or did you just replace "tags" with "categories"? What you've got on your blog is exactly what I was dreaming of doing on my website (GitHub/GH Pages seems to be having connectivity issues at the moment). If you could share your source, or if you feel like opening a pull request on my fork, I'll merge it immediately.

@g1eny0ung Doesn't seem to be much maintenance going on on this theme, any chance you could please disable these annoying bots from closing issues?

@Darthagnon I've realized this problem...Sorry about this, I don't have the energy to maintain this theme for now, and I may have to leave for a while because I have other things to do. I will remove the stale bot and recover the unsolved issues.

@Darthagnon I've realized this problem...Sorry about this, I don't have the energy to maintain this theme for now, and I may have to leave for a while because I have other things to do. I will remove the stale bot and recover the unsolved issues.

No worries; I know life gets in the way. Thank you for developing it in the first place! I'm currently maintaining the theme in my fork, since I actively use it on my homepage. I'll open an issue to link to it. Maybe eventually we can merge them again.

do you have the source for your blog's version of the theme, or did you just replace "tags" with "categories"?

I have, but it's only one change in this fork: https://github.com/techmagus/hugo-theme-dream
The change for the tags/categories is in my website repo: https://github.com/YourOnly-One/site.yuki (mirror). But, yes, I just changed it to categories. I think it was this file: https://github.com/YourOnly-One/site.yuki/blob/main/layouts/partials/header.html

PS. if you want to colab on developing this theme further, I'm all ears.

I'll check my load. Though, I've been meaning to submit a PR for the translation bit since I started using the theme, it's 2023 and I still haven't. ^_^;; In my site, there are flags at the top bar, and when viewing a post, there are translations on the sidebar, too. (My website repos are a mess, since I use it for testing stuff and what not.)

I don't have the energy to maintain this theme for now, and I may have to leave for a while because I have other things to do.

No worries about that! That's where the community comes in, and the beauty of FLOSS/FOSS.

Resolved in https://github.com/g1eny0ung/hugo-theme-dream/commit/5796a28759eb5fe89e2e24e8fbb41a0c0cfe39c1.


chore: default driver-write-secrets to true

Signed-off-by: Anish Ramasekar<EMAIL_ADDRESS>
Reason for Change:

Next step of #475 for driver writing the files to filesystem. This feature was added in v0.0.21 of the driver and will be made default in v0.1.0.
The flags will be removed in a future release and the file write logic in provider will be cleaned up.

Requirements

[x] squashed commits
[x] included documentation
[x] added unit tests and e2e tests (if applicable).

Issue Fixed:

Does this change contain code from or inspired by another project?

[ ] Yes
[x] No

If "Yes," did you notify that project's maintainers and provide attribution?
Special Notes for Reviewers:

Codecov Report

Merging #541 (e39e451) into master (aabc6d4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #541   +/-   ##
=======================================
  Coverage   61.49%   61.49%
=======================================
  Files           7        7
  Lines         535      535
=======================================
  Hits          329      329
  Misses        172      172
  Partials       34       34

/azp run pr-e2e-azure


Remove unwanted whitespace

closes #673 LiveURL: https://smartfaq-remove-unwanted-whitespace.surge.sh

:tada: This PR is included in version 1.3.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add fix for SQLite strings being coerced to numbers internally

SQLite has a neat "feature" where any data type that does not contain TEXT, CLOB, or CHAR will be treated with NUMERIC affinity.
All SQLite STRING fields should instead be declared with TEXT
This also adds a test that ensures that a string containing a large number will remain encoded as a string and not get coerced to a number internally.
More information: https://www.sqlite.org/datatype3.html
This new test fails miserably (the data is returned as "Inf" instead of the long string of 1s) with the old behavior, and passes with the new.

Current coverage is 83.87% (diff: 87.50%)

Merging #12 into master will increase coverage by 7.87%

@@             master        #12   diff @@
==========================================
  Files             1          8     +7
  Lines            50        217   +167
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits             38        182   +144
- Misses           12         35    +23
  Partials          0          0

Powered by Codecov. Last update e7763a2...1da764e

Thanks!


OSError: [Errno 2] No such file or directory: '/output_dir/freesurfer/sub-01/mri/orig/001.mgz'

Description
When the multiscalebrainparcellator has already been run on a subject but need to be reprocess, symlink to orig/001.mgz is broken
Steps to reproduce the error

Run a first time the multiscalebrainparcellator
Delete the derivatives/cmp and derivatives/nipype folders but keep the derivatives/freesurfer (we do not want to run reconall for about 10 hours again)
Run a second time the multiscalebrainparcellator

Command line error
docker run -v '/media/localadmin/HagmannHDD/Seb/ds005:/bids_dir' -v '/media/localadmin/HagmannHDD/Seb/ds005/derivatives:/output_dir' -it sebastientourbier/multiscalebrainparcellator:v1.0.1-beta0 '/bids_dir' '/output_dir' participant --participant_label 01 --skip_bids_validator --thalamic_nuclei --hippocampal_subfields --brainstem_structures
BIDS dataset: /bids_dir
MAIN INFO: /bids_dir/code/license.txt Freesurfer license found will be used
MAIN WARNING: the specified number of cores (None) should be greater to 0
MAIN INFO: Maximal number of cores set to the maximal number of available cores (12)
MAIN INFO: Default isotropic resolution for resampling: 1.0
Traceback (most recent call last):
  File "/opt/conda/envs/py27msbparc/bin/multiscalebrainparcellator_bidsapp_entrypointscript", line 189, in <module>
    total_size += os.path.getsize(fp)
  File "/opt/conda/envs/py27msbparc/lib/python2.7/genericpath.py", line 57, in getsize
    return os.stat(filename).st_size
OSError: [Errno 2] No such file or directory: '/output_dir/freesurfer/sub-01/mri/orig/001.mgz'

Solution
001.mgz should be deleted. It will be regenerated by the multiscalebrainparcellator


Is freertos support plan?

WAMR supports ESP-IDF platform(as you can see here), which uses FreeRTOS as the underlying RTOS, so it already has the freertos platform APIs. I believe you can just integrate WAMR runtime to your project on FreeRTOS without too much trouble.


Optimize nitc

Some minor optimizations after looking at reports of valgrind.

+1

Misclick, sorry

+1


How can I create an encrypted scoped token to use in my docker config?

Is your feature request related to a problem? Please describe.
In my terraform config I create a user, a permission target and then I create a scoped token for the user.
The permission target allows the user (which is a technical user) to read from a docker registry.
resource "artifactory_user" "jfrog_user" {
  name              = var.jfrog_user_name
  email             = var.jfrog_user_email
  groups            = var.jfrog_user_group
  disable_ui_access = var.jfrog_user_disable_ui
  profile_updatable = var.jfrog_user_profile_updatable
}

resource "artifactory_scoped_token" "jfrog_user" {
  username          = artifactory_user.jfrog_user.name
  refreshable       = var.jfrog_token_refreshable
  expires_in        = var.jfrog_token_expire //in seconds
}

resource "artifactory_permission_target" "jfrog_user" {
  name = var.jfrog_user_perm_name

  repo {
    includes_pattern = var.jfrog_user_perm_include
    excludes_pattern = var.jfrog_user_perm_exclude
    repositories     = var.jfrog_user_perm_repos

    actions {
      users {
        name        = artifactory_user.jfrog_user.name
        permissions = var.jfrog_user_perm
      }
    }
  }
}

Then I create a docker secret with the output in a kubernetes namespace:
output "jfrog_access_token" {
  value = artifactory_scoped_token.jfrog_user.access_token
  description = "Specifies the access token of the technical user"
}

output "jfrog_user_name" {
  value = artifactory_user.jfrog_user.name
  description = "Specifies the name of the technical user"
}

output "jfrog_user_id" {
  value = artifactory_user.jfrog_user.id
  description = "Specifies the id of the technical user"
}

output "jfrog_user_email" {
  value = artifactory_user.jfrog_user.email
  description = "Specifies the email of the technical user"
}

However, when I download the secret from the namespace, and decode it base64, I get the following error when I try a docker login:
docker login <myserver.jfrog.io>
Username: oc-user-int
Password: <base64 decoded access token>
Get "https://<myserver.jfrog.io>/v2/": unknown: Artifactory configured to accept only encrypted passwords but received a clear text password, getting the encrypted password can be done via the WebUI.

Describe the solution you'd like
I want to have the possibility to have an encrypted token return from the terraform provider to use in my config files.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Maybe I am just wrong in my approach: We currently use technical users to pull/push from our CI Pipelines. We disable local passwords and create identity tokens which works as passwords. This combination we use for our docker config.
So do I even have to create a scoped access token for this technical user? Is this even the identity token? And do I have to change the encrypted password policy in jfrog.io from "required" to "supported" to use these tokens/passwords unencrypted without the need to download them from the webui? Help appreciated, thanks!


Fix converting S3 URIs to HTTP URIs

This was actually generating strings starting like https:/s3-buck-name/...
which worked when hosting from localhost but not when from staging
Switching from path.join which is meant for filepaths to url.resolve which
is designed for URIs fixed the issue
Overview
Brief description of what this PR does, and why it is needed.
Demo
Optional. Screenshots, examples, etc.
Notes
Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.
Testing Instructions

How to test this PR
Prefer bulleted description
Start after checking out this branch
Include any setup required, such as bundling scripts, restarting services, etc.
Include test case, and expected output

Closes #XXX

Trivial, merging


Member Event APIs

refs https://github.com/TryGhost/Ghost/issues/12602
This issue tracks APIs on top of member events that allows us to visualize data in Admin Dashboard, using data collected in this issue
Tasks/Endpoints

[x] Aggregate newsletter subscribers over time
[x] Member events timeline

[x] Member email address change events
[x] Member subscription events
[x] Member login events
[x] Member payment events

[x] Aggregate MRR over time
[x] Top members (top 10 members sorted by open rate)
[x] Activity feed of members
[x] Newsletter open rates over time
[x] Members

[x] Total
[x] Paid

Closed with https://github.com/TryGhost/Ghost/commit/0620ff6ae0af7bc01b3d7eb5decb778657d68d19 as all endpoints are now in main


Use *bool for Silver/Premium push rules

The commit_committer_check and reject_unsigned_commits project and group push rules are only available in GitLab Silver/Premium and above.
See: https://docs.gitlab.com/ee/api/projects.html#get-project-push-rules
This commit changes the push rules response struct to use type *bool instead of bool for those rules, since they aren't returned by the API if you don't have the right plan. Leaving the type as bool makes it hard to tell if trying to set those rules will succeed or return a 403 Forbidden error.

@jtdoepke I can see why you created this PR, but I will not be merging this one. The current assumption is that the users of this package (i.e. the GitLab API) know what they are doing and understand which fields are applicable for them.
Currently the response structs are consistent in their configuration, which makes if very easy to use them. Making them have both pointer and non-pointer fields for the same types (so a bool and  *bool for example) isn't an improvement and would still require special handling of the fields (do a nil check first). So I don't see the benefit and will close this one. Sorry!


Reland Cupertino text input padding

Reland #113958
Reverted in #114102
Originally failed due to tests merged in around the same time conflicting.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@MitchellGoodwin Looks like this is stuck on google testing. Maybe you can rebase to the latest master to try to get the tests to re-run.


Haxe VS Code extension doesn't recognize TJSON

Describe your problem here.
For some reason, the VS Code extension I use for Haxe doesn't recognize that I have TJSON installed. The game still compiles, but the extension throws a bunch of errors about it not being able to find TJSON.
Edit: It's also been happening for even longer with Discord RPC.
Edit 2: A similar issue started happening at the same time as the TJSON issue where the extension says: Unknown identifier: Mods after hovering over something referencing the Mods class.
Console Log:
Haxe language server started
Haxe Path: haxe.exe
Using --server-connect
Haxe connected!
Listening on port 6000
Done.
Haxe server restart requested: DisplayArguments configuration was changed
Haxe Path: haxe.exe
Using --server-connect
Haxe connected!
Restarted Haxe server: DisplayArguments configuration was changed
Failed - try fixing the error(s) and restarting the language server:

source/backend/StageData.hx:9: characters 8-19 : Type not found : tjson.TJSON
source/backend/Song.hx:3: characters 8-19 : Type not found : tjson.TJSON
source/backend/WeekData.hx:9: characters 8-19 : Type not found : tjson.TJSON
source/states/PlayState.hx:34: characters 8-19 : Type not found : tjson.TJSON
source/cutscenes/DialogueBoxPsych.hx:3: characters 8-19 : Type not found : tjson.TJSON
source/cutscenes/DialogueCharacter.hx:3: characters 8-19 : Type not found : tjson.TJSON
source/animateatlas/AtlasFrameMaker.hx:7: characters 8-19 : Type not found : tjson.TJSON
source/objects/Character.hx:22: characters 8-19 : Type not found : tjson.TJSON
source/states/editors/ChartingState.hx:4: characters 8-19 : Type not found : tjson.TJSON
source/objects/MenuCharacter.hx:8: characters 8-19 : Type not found : tjson.TJSON
source/psychlua/HScript.hx:206: characters 1-2 : Unexpected }
[Error - 2:00:31 PM] Request textDocument/hover failed.
  Message: Type not found : tjson.TJSON
  Code: -32603
[Error - 2:00:36 PM] Request textDocument/hover failed.
  Message: Type not found : tjson.TJSON
  Code: -32603
[Error - 2:00:39 PM] Request textDocument/hover failed.
  Message: Type not found : tjson.TJSON
  Code: -32603
[Error - 2:00:57 PM] Request textDocument/hover failed.
  Message: Type not found : tjson.TJSON
  Code: -32603
[Error - 2:01:28 PM] Request textDocument/hover failed.
  Message: Type not found : tjson.TJSON
  Code: -32603

Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
In the experimental branch, I added support for characters to reference multiple sheets.

Okay, so, for some reason, the TJSON issue stopped today. I don't know why. However, the other two issues are still present, and as for the Mods issue, I've noticed that there's a lot more stuff that just isn't imported, but still lets the game compile. Does anybody know why some things don't need to be imported and why the extension is freaking out?


Disable debug and chip_Stack_lock_Tracking

Problem
What is being fixed?  Examples:

pump-app example not able to build and run
pump-controller-app example not able to build and run

Change overview
Disabled debug to save memory
Disabled chip_Stack_lock_tracking since it was not working for this platform
Testing

Complied the code and tested in physical demonstrator

/rebase

@andy31415 it is now rebased :-)

If this PR is accepted instead of #15595, can you propagate the chip_stack_lock_tracking = "none" change to the lock_app as well?

@srickardti chip_stack_lock_tracking = "none" is now added to the lock_app example as well.

@andy31415 @bzbarsky-apple  it is almost like the restyle bot thinks the restyle branch is still available and fails with an error while executing.
Can you kickstart the restylebot or suggest how to proceed from here?

@mgarb1 - please merge with master since github complains about conflicts.
Also run ./scripts/helpers/restyle-diff.sh to make sure style is ok. I cannot kick resyler, however I can bypass it if we are sure the changes are ok.

andy31415 made a rebase again and restyle seems to be running again. So ok to merge, for now :-)

/rebase

@mgarb1 The current PR version is based on a revision that was not passing CI.  Needs to be merged/rebased to tip, and automatic rebase is not handling it...  Please merge/rebase?

/rebase

4.th merge/rebase done in 7 days... Just adding a few configuration lines here.......  :-)
Don't know why iMX Linux are failing now??? Cannot checkout submodules for lwip ???
@woody-apple @bzbarsky-apple @andy31415


Optimize EnvPackageCache using a nested map

Purpose
$subject
Fixes https://github.com/ballerina-platform/ballerina-lang/issues/36790
Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Used VisualVM to track the CPU consumption and the memory(heap) size over many iterations. There is no noticeable difference between the results in the old and new implementations.
Got the heap dump as well and the EnvPackageCache in both instances use the same amount of space (16 bytes).


[Cache] Improve packing tags into items

I think the attached patch would be a nice improvement on top of https://github.com/symfony/symfony/pull/42997
~Please don't merge, that's for discussion (Tests don't pass)~
Basically, this delegate the serialization of tags to the wrapper adapters instead of letting TagAwareAdapter manage that part.

PR updated to keep compat with already populated pools.
I still need to fix tests and to have a closer look at your version of getTagVersions.

Not with a special storage class (named Ͼ for making it as short as possible).
This could also act as a DTO between adapters and items, to store metadata more efficiently (eg using an HSET on redis).
This is left as an exercise for another iteration :)

Last change: added $persistTags on getTagVersions(), so not create tags when only fetching them for comparison.


Pin bigger on iOS than on Android

VERSIONS

Xamarin.Forms.GoogleMaps - 3.3.0
Xamarin.Forms - <IP_ADDRESS>0310

PLATFORMS

[ ] Android
[x] iOS

ACTUAL BEHAVIOR
Pin is bigger on iOS than on Android. I have seen issue #40, however that did not fix this.
var clientPin = new Pin()
{
    Icon = BitmapDescriptorFactory.FromBundle("icon_map_client.png"),
    Position = new Position(lat, lng),
    Tag = "client"
};

Thank you!

I still have the same problem although I have installed the 3.3.0 version in my project, any suggestion?

@woemike  Did you solve this problem in any way?

I have the same issue. I had to resize the image in the meantime, but the image is a lot more blurry than on Android.

Is there a solution to this problem, or is there no way to avoid having to resize the iOS image and thus making it look blurry and pixelated?


Request - add institution_acronym to all container-involved bulk tools

Help us understand your request (check below):

[x] other

Describe what you're trying to do
See eg https://github.com/ArctosDB/arctos/issues/6789 and linked issues eg https://github.com/ArctosDB/arctos/issues/8194

I don't think the container environment is fully understood (and most of the time it doesn't need to be)
Some users seem to have (or had, or ??) access to institutions which might have overlapping barcodes
Adding an explicit column will hopefully add clarity to the user experience, and the cost would I believe be extremely minimal - for most users most of the time, this would just be a static thing that requires very little consideration.
Adding an explicit column would remove any chance of an error resulting from me trying to make inferences from user's rights, or tripping up on some change in those rights, or failing in any of the other ways implicit data can  be misunderstood

I'll take this to dev in a week or so if no better ideas or technically-viable alternatives show up here.

I don't quite understand. Will this allow KSB to switch the institution acronym for overlapping MSB barcodes from MSB to KSB when we bulkload barcodes?


The shoot control plane Prometheus forwards its alerts to the seed alertmanager

How to categorize this PR?

/area monitoring
/kind regression
What this PR does / why we need it:
The shoot control plane Prometheus should forward its alerts to the alertmanager in the garden namespace of the seed, to the alertmanager-seed.
Which issue(s) this PR fixes:
Before #9695 (that was released with v1.95.0), the shoot Prometheus always forwarded its alerts to the alertmanager-seed. The alertmanager-seed can be configured in real landscapes e.g. to send email notifications to Gardener operators. This can be useful if some shoot control plane alerts need to be acted upon e.g. for auditing purposes.
With #9695, the shoot control plane Prometheus only forwards the alerts to the shoot alertmanager. Note that the alertmanager-shoot is deployed only if the alerting feature is turned on (see doc).
Special notes for your reviewer:
/cc @vicwicker @rfranzke @ScheererJ

Additional hints when testing in the local setup...
In the local setup, to deploy the seed alertmanager, we can apply the following secret based on example/10-secret-alerting.yaml:
kubectl apply -f - <<EOF
apiVersion: v1
kind: Secret
metadata:
  name: alerting
  namespace: garden
  labels:
    gardener.cloud/role: alerting
type: Opaque
stringData:
  auth_type: smtp
  auth_identity: identity
  auth_password: password
  auth_username: username
  from: from@localhost
  smarthost: localhost:25
  to: to@localhost
EOF

and then restart the gardenlet(s) e.g. with kubectl delete pods -l role=gardenlet
Furthermore, in the shoot control plane namespace, we can add some alerts that are always firing:
k apply -f - <<EOF
apiVersion: monitoring.coreos.com/v1
kind: PrometheusRule
metadata:
  labels:
    prometheus: shoot
  name: test
spec:
  groups:
  - name: test
    rules:
    - alert: TestOperator
      expr: vector(1)
      for: 1m
      labels:
        type: seed
        severity: critical
        visibility: operator
      annotations:
        summary: Shoot test summary (operator)
        description: |-
          Shoot test description (operator)
    - alert: TestAll
      expr: vector(1)
      for: 1m
      labels:
        type: seed
        severity: critical
        visibility: all
      annotations:
        summary: Shoot test summary (all)
        description: |-
          Shoot test description (all)
EOF

The we can port-forward to the shoot and seed alertmanagers and verify that the alerts were sent there.

Release note:

A regression is fixed and now the shoot control plane Prometheus forwards its alerts to the seed alertmanager

/cherry-pick release-v1.96

/cherry-pick release-v1.95

@rfranzke: https://github.com/gardener/gardener/pull/9870 failed to apply on top of branch "release-v1.95":

There were some conflicts while rebasing this PR to the release-v1.95 branch, hence Prow could not open the PR automatically.
Following the docs/development/process.md#cherry-picks documentation, I resolved the conflicts and opened #9884 for the release-v1.95 branch.


Selenoid docker networking slow on EC2

We're using Selenoid in Docker, with Protractor.  Our tests run against an externally hosted app.  Everything works well when we run Selenoid locally on our Macs.  However, when we try to move Selenoid into an AWS EC2, tests become very slow.  The issue seems to be related to networking, specifically when the browser container tries to contact the app (the app is just static html files hosted on an external S3 bucket).
I looked through the recommended docker settings and followed the suggestions there. The docker bridge wasn't enabled by default in EC2, so I enabled it as follows:
# cat /etc/docker/daemon.json
{
  "bridge": "docker0", # added this
  "log-driver": "json-file",
  "log-opts": {
    "max-size": "10m",
    "max-file": "10"
  },
  "live-restore": false,  # changed this from "true" to "false"
  "max-concurrent-downloads": 10,
  "default-ulimits": {
    "memlock": {
      "Hard": -1,
      "Name": "memlock",
      "Soft": -1
    }
  }
}

Then I set the docker0 MAC to eth0 as described in the documentation:
ip link set docker0 address 11:22:33:44:55:66

This didn't have any effect, even after restarting docker and the network.
I'm fairly certain this is not related to memory or CPU, but I tried setting the quota recommendations as well, and even used a rather large EC2 instance (m5.xlarge) which did not resolve the issue.  docker stats reveals similar cpu/memory utilization on both EC2 and Mac, and we don't appear to be hitting any resource limits there.
A docker inspect on the running browser container reveals identical configuration on EC2 vs Mac (with the exception of something called "CgroupnsMode": "host" which is on Mac).  Both are using the "bridged" network type.
The Docker versions differ, but we are using the latest available on the EC2:
##################
# EC2 INSTANCE
##################
# docker version
Client:
 Version:           19.03.6-ce
 API version:       1.40
 Go version:        go1.13.4
 Git commit:        369ce74
 Built:             Fri May 29 04:01:26 2020
 OS/Arch:           linux/amd64
 Experimental:      false

Server:
 Engine:
  Version:          19.03.6-ce
  API version:      1.40 (minimum version 1.12)
  Go version:       go1.13.4
  Git commit:       369ce74
  Built:            Fri May 29 04:01:57 2020
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          1.4.1
  GitCommit:        c623d1b36f09f8ef6536a057bd658b3aa8632828
 runc:
  Version:          1.0.0-rc92
  GitCommit:        ff819c7e9184c13b7c2607fe6c30ae19403a7aff
 docker-init:
  Version:          0.18.0
  GitCommit:        fec3683

##################
# LOCAL MAC
##################
# docker version
Client: Docker Engine - Community
 Cloud integration: 1.0.7
 Version:           20.10.2
 API version:       1.41
 Go version:        go1.13.15
 Git commit:        2291f61
 Built:             Mon Dec 28 16:12:42 2020
 OS/Arch:           darwin/amd64
 Context:           default
 Experimental:      true

Server: Docker Engine - Community
 Engine:
  Version:          20.10.2
  API version:      1.41 (minimum version 1.12)
  Go version:       go1.13.15
  Git commit:       8891c58
  Built:            Mon Dec 28 16:15:28 2020
  OS/Arch:          linux/amd64
  Experimental:     true
 containerd:
  Version:          1.4.3
  GitCommit:        269548fa27e0089a8b8278fc4fc781d7f65a939b
 runc:
  Version:          1.0.0-rc92
  GitCommit:        ff819c7e9184c13b7c2607fe6c30ae19403a7aff
 docker-init:
  Version:          0.19.0
  GitCommit:        de40ad0
 Kubernetes:
  Version:          v1.18.9-eks-d1db3c
  StackAPI:         Unknown

The network bridges also appear to be identical:
##################
# MAC
##################
docker network inspect dd82cbf319b0
[
    {
        "Name": "bridge",
        "Id": "dd82cbf319b046be25cf5b84041b9f6505b31bc89c273feabe546ae78c4cfb2e",
        "Created": "2021-02-26T23:12:18.373017176Z",
        "Scope": "local",
        "Driver": "bridge",
        "EnableIPv6": false,
        "IPAM": {
            "Driver": "default",
            "Options": null,
            "Config": [
                {
                    "Subnet": "<IP_ADDRESS>/16",
                    "Gateway": "<IP_ADDRESS>"
                }
            ]
        },
        "Internal": false,
        "Attachable": false,
        "Ingress": false,
        "ConfigFrom": {
            "Network": ""
        },
        "ConfigOnly": false,
        "Containers": {
        },
        "Options": {
            "com.docker.network.bridge.default_bridge": "true",
            "com.docker.network.bridge.enable_icc": "true",
            "com.docker.network.bridge.enable_ip_masquerade": "true",
            "com.docker.network.bridge.host_binding_ipv4": "<IP_ADDRESS>",
            "com.docker.network.bridge.name": "docker0",
            "com.docker.network.driver.mtu": "1500"
        },
        "Labels": {}
    }
]

##################
# EC2 INSTANCE
##################
docker network inspect f1ddb6e8c0d7
[
    {
        "Name": "bridge",
        "Id": "f1ddb6e8c0d7acfcdd0ab81391ce3eb4247deaffa04c71dfe3eebf3660995e3e",
        "Created": "2021-02-27T20:11:01.976419111Z",
        "Scope": "local",
        "Driver": "bridge",
        "EnableIPv6": false,
        "IPAM": {
            "Driver": "default",
            "Options": null,
            "Config": [
                {
                    "Subnet": "<IP_ADDRESS>/16",
                    "Gateway": "<IP_ADDRESS>"
                }
            ]
        },
        "Internal": false,
        "Attachable": false,
        "Ingress": false,
        "ConfigFrom": {
            "Network": ""
        },
        "ConfigOnly": false,
        "Containers": {
        },
        "Options": {
            "com.docker.network.bridge.default_bridge": "true",
            "com.docker.network.bridge.enable_icc": "true",
            "com.docker.network.bridge.enable_ip_masquerade": "true",
            "com.docker.network.bridge.host_binding_ipv4": "<IP_ADDRESS>",
            "com.docker.network.bridge.name": "docker0",
            "com.docker.network.driver.mtu": "1500"
        },
        "Labels": {}
    }
]

Is there anything else I could/should be looking at?

@kflavin couldn't it be just a firewall issue when you don't have network access to some static resources (scripts, styles, images and so on)?

@vania-pooh I don't think so, the static resources are all on S3.  Both machines are behind a NAT, and there aren't any firewall/security group rules blocking return traffic.  I'll be looking at it more tomorrow.

Also, the tests still pass, they just take much longer.  If there were missing resources I would think they'd fail.

@kflavin could you check that Docker storage driver is OverlayFS with docker info | grep Storage.

@vania-pooh yes, it's using overlay:
$ docker info | grep Storage
 Storage Driver: overlay2

@kflavin I would then take a look at system metrics like iowait, cpu usage and so on.


Azure Cloud Shell delayed output scenario

I'm trying to run a PowerShell script from a Cloud Shell session, where the *.ps1 sits in a storage account container protected by a SAS token. The script runs successfully, but one of the output required for end user review, does not show up until after the third user input prompt (needed to create a new RG, VNET, subnet, NSG, peering, tagging).  The output is needed for informed user input to create non-overlapping vnet/subnet space. Code runs correctly using copy/paste into Cloud Shell with no delay, code also runs correctly from a local PS session.
#Get existing VNETs
$vnets = Get-AzVirtualNetwork -ResourceGroupName $networkRG
$vnets | Where-Object -Property Name -match "spoke" | Select-Object Name -ExpandProperty AddressSpace | Sort-Object AddressPrefixes
#user prompt 1
#user prompt 2
#user prompt 3

PS /home/***> $env:ACC_VERSION
master_20200515.4
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8f7b8330-007e-d13b-ce2e-c9f1dd9ea06b
Version Independent ID: ace5ecf4-2021-63a7-c28f-73a11767f0be
Content: Azure Cloud Shell troubleshooting
Content Source: articles/cloud-shell/troubleshooting.md
Service: azure
GitHub Login: @maertendMSFT
Microsoft Alias: damaerte

Hi Matt @the-blesss, If possible, can you provide complete .ps1 script and also can you explain the use-case and/or scenario with more context (like what does user prompt 1 and user prompt 2 do ? and when you say 'user prompt', is it cloud shell session prompt in shell.azure.com or cloud shell session in your machine or something else?) It would be easier to diagnose, troubleshoot and try reproducing the issue if you provide more context around the issue (if possible, even with some screenshots).
On the other hand, I would like to let you know that this azure-docs repository deals about feedback related to particular Azure document page (like correcting doc bugs, doc enhancements, product issues related to wrong doc instructions, etc.) so if issue is intended to update / correct / enhance anything in an Azure document then please let us know else I suggest you to ask the question in public forums like Microsoft Q&A, etc or directly reach out to Azure technical support to access your environment and diagnose the issue.

Hi @KrishnaG-MSFT, thanks for the reply. It turns out I got the existing code to work properly when running from Cloud Shell in the Azure Portal and shell.azure.com. I was not sure if this was a bug, but I have a valid work-around. Here is the working block of code:
#Get existing VNETs
$vnets = Get-AzVirtualNetwork -ResourceGroupName $networkRG
$vnets | Where-Object -Property Name -match "spoke" | Select-Object Name -ExpandProperty AddressSpace | Sort-Object AddressPrefixes | Out-Host

Hi Matt @the-blesss, Glad to know that you have self resolved the issue! 👍
Closing this issue for now. If there are further questions regarding this matter or feedback on the referred Azure documentation, please do let us know and we will gladly continue the discussion.


Unable to pip install shazamio on macos

Unable to pip install shazamio on macos
Collecting shazamio-core<2.0.0,>=1.0.7 (from shazamio)
Using cached shazamio_core-1.0.7.tar.gz (2.2 kB)
Installing build dependencies ... done
Getting requirements to build wheel ... done
Preparing metadata (pyproject.toml) ... error
error: subprocess-exited-with-error
× Preparing metadata (pyproject.toml) did not run successfully.
│ exit code: 1
╰─> [5 lines of output]
💥 maturin failed
Caused by: Can't find /private/var/folders/qw/h4rml07d7tgg8rk7n74zz7bm0000gn/T/pip-install-v20bfs9n/shazamio-core_99820c2f6dbb4ca4a69a735798cb5690/Cargo.toml (in /private/var/folders/qw/h4rml07d7tgg8rk7n74zz7bm0000gn/T/pip-install-v20bfs9n/shazamio-core_99820c2f6dbb4ca4a69a735798cb5690)
Error running maturin: Command '['maturin', 'pep517', 'write-dist-info', '--metadata-directory', '/private/var/folders/qw/h4rml07d7tgg8rk7n74zz7bm0000gn/T/pip-modern-metadata-nibupmsw', '--interpreter', '/Library/Frameworks/Python.framework/Versions/3.10/bin/python3']' returned non-zero exit status 1.
Checking for Rust toolchain....
Running maturin pep517 write-dist-info --metadata-directory /private/var/folders/qw/h4rml07d7tgg8rk7n74zz7bm0000gn/T/pip-modern-metadata-nibupmsw --interpreter /Library/Frameworks/Python.framework/Versions/3.10/bin/python3
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed
× Encountered error while generating package metadata.
╰─> See above for output.
note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

Same issue here.
Any update on this matter ?

Downgrading to python 3.7 solved the issue for me.
The error triggers with python 3.12, not tested on other versions to see where the bug appears.

There's no wheel artifact for macosx-x86_64 of shazamio-core, so pip is trying to compile from source but there's no
Cargo.toml in the shazamio_core-1.0.7.tar.gz source code tarball.
I installed shazamio with following commands with python-3.12.
git clone https://github.com/shazamio/shazamio-core.git
cd shazamio-core
git switch 1.0.7
python -m pip install .
pip install shazamio

I tried to install it on Mac with that
pip install shazamio-core==1.0.7
but still get this error
(shazamio) PolziMacs-Mini:alessandro12341 polzimac$ pip install shazamio-core==1.0.7
Collecting shazamio-core==1.0.7
  Using cached shazamio_core-1.0.7.tar.gz (2.2 kB)
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... error
  error: subprocess-exited-with-error

  × Preparing metadata (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [5 lines of output]
      💥 maturin failed
        Caused by: Can't find /private/var/folders/q1/288l_zvn2sl7_lx4cv34yz3m0000gn/T/pip-install-k9ah1x6j/shazamio-core_c2f1e1172c7f452dab123830f297ceeb/Cargo.toml (in /private/var/folders/q1/288l_zvn2sl7_lx4cv34yz3m0000gn/T/pip-install-k9ah1x6j/shazamio-core_c2f1e1172c7f452dab123830f297ceeb)
      Error running maturin: Command '['maturin', 'pep517', 'write-dist-info', '--metadata-directory', '/private/var/folders/q1/288l_zvn2sl7_lx4cv34yz3m0000gn/T/pip-modern-metadata-qt_8_cjx', '--interpreter', '/Users/polzimac/Documents/DEV/venv/shazamio/bin/python3']' returned non-zero exit status 1.
      Checking for Rust toolchain....
      Running `maturin pep517 write-dist-info --metadata-directory /private/var/folders/q1/288l_zvn2sl7_lx4cv34yz3m0000gn/T/pip-modern-metadata-qt_8_cjx --interpreter /Users/polzimac/Documents/DEV/venv/shazamio/bin/python3`
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

I tried to install it on Mac with that
pip install shazamio-core==1.0.7
but still get this error

@Rapid1898-code You cannot install shazamio-core which is dependency for shazamio with just pip on macosx-x86_64. You have to install shazamio-core first from the source code as stated above.
After that you can install shazamio.

ok - thanks a lot for your response -
I tried it with the statements above from you but when trying to input the 3rd statement i get this error:
(shazamio) PolziMacs-Mini:TEMPDEV polzimac$ git clone https://github.com/shazamio/shazamio-core.git
Cloning into 'shazamio-core'...
remote: Enumerating objects: 730, done.
remote: Counting objects: 100% (90/90), done.
remote: Compressing objects: 100% (84/84), done.
remote: Total 730 (delta 5), reused 2 (delta 2), pack-reused 640 (from 1)
Receiving objects: 100% (730/730), 132.46 KiB | 3.01 MiB/s, done.

With that command it works great on my Mac - thanks a lot!


HDDS-3174. Rebalance integration tests

What changes were proposed in this pull request?

Group hdds integration tests with om instead of client, because the latter takes the most time.
Reduce time required for TestBlockOutputStreamWithFailures by lowering stale/dead node interval.
Apply integration test profiles to mini-chaos-tests, too.  Previously all it-* runs triggered chaos tests.  Although the test itself was skipped, @BeforeClass still took 1 minute.

These save about 8 minutes overall.
https://issues.apache.org/jira/browse/HDDS-3174
How was this patch tested?
https://github.com/adoroszlai/hadoop-ozone/runs/506630819

Thanks @bshashikant for reviewing and merging it.


Update KuryrConfig.MTU setting description

This updates the description with information on additional side-effect of the setting based on behavior from
openshift/cluster-network-operator#1586.

Should 0000_70_cluster-network-operator_01_crd.yaml and  consequently operator/v1/zz_generated.swagger_doc_generated.go be updated as well?

I had hard time trying to generate that, let's see.

/lgtm

/assign @JoelSpeed

/approve

I had hard time trying to generate that, let's see.

@dulek If you can provide any feedback on the issues you saw, I'm currently working on improving the tooling experience in this repo so can take into account your issues

/approve

I had hard time trying to generate that, let's see.

@dulek If you can provide any feedback on the issues you saw, I'm currently working on improving the tooling experience in this repo so can take into account your issues

make update-scripts would mess protobuf code, make update-codegen-Default-crds wouldn't do anything, make generate-with-container failed with some error.

/lgtm

/remove-lifecycle stale

/cc @maxwelldb @eurijon can you take a look and apply the needed labels if you see fit? Thanks

/cc @maxwelldb
/cc @eurijon


R1.3

sadas

Can one of the admins verify this patch?

@anony00 can you improve the description of the PR and what is this for ?

r1.3 cherrypicks were already merged back into master.


Force to disable hibernation

According to feedback from Qubes OS Forum it is critical to disable hibernation with Windows 10 at preparation stage. Looks like auto-qwt/run.bat is the place for it.
P.S. Very nice tool, thank you.

@jevank -
Would it make sense to have it be part of the general power_settings.bat execution in the crossbuild of QWT, modifying here:
https://github.com/QubesOS/qubes-installer-qubes-os-windows-tools/blob/master/power_settings.bat
:: Disable idle sleep & hibernation
powercfg /setacvalueindex SCHEME_MIN SUB_SLEEP STANDBYIDLE 0
powercfg /setdcvalueindex SCHEME_MIN SUB_SLEEP STANDBYIDLE 0
powercfg /setacvalueindex SCHEME_MIN SUB_SLEEP HIBERNATEIDLE 0
powercfg /setdcvalueindex SCHEME_MIN SUB_SLEEP HIBERNATEIDLE 0

By adding powercfg -H off or similar?
B

I've made changes in QWT-cross preparation.bat so this issue mostly for R4.0 users. But power_settings.bat looks more reasonable.

We're already disabling hibernation in optimize.bat (it's at the end of the script). But it's good to have QWT doing it too now.


dangling incomplete sentence

The page section https://docs.atomicdata.dev/interoperability/rdf.html#why-these-changes ends like this:

I've asked two colleagues working on RDF about this constraint, and both were critical. The reason

The reason what?
Great text - which makes it so much more frustrating to leave the reader hanging in suspense over that detail... :-)

Thanks for letting me know! There's a bit more of these unfinished sentences in the project... Sorry, it's the chaotic way I tend to write things down.
Anyways, to answer the question:
Two separate RDF developers (who did not know each other) gave me the exact same reason for using Named Graphs: They wanted to extend the schema.org ontology by adding properties to these items in a local graph.
I don't think even this usecase is appropriate for named graphs. They were actually using an external resource that did not provide them with the things they needed. The things that they would add (the translations) are not re-usable, so in the end they will just keep spreading a URL that doesn't provide people with the things that they will come to expect. The schema.org URL still won't provide the translations that they wrote!
I believe a better solution is to copy the resource (in this case a part of the schema.org ontology), and extend it, and host it somewhere else, and use that URL. I'd like to see a more organic usage of URLs that actually provide meaningful and valuable machine readable properties, including translations and icons.

Do I understand you correctly that your recommendation for the schema.org example is to formally create a subclass of the ontology?
...because making a fork with different content (added triples to cover a new language strings) without formally renaming the project sounds bad to me.

I can suggest to add the word FIXME whenever you are leaving something incomplete.

Good idea!

Right. Just spotted another one at the end of https://docs.atomicdata.dev/schema/intro.html#atomic-schema

Thanks, fixed it!

Do I understand you correctly that your recommendation for the schema.org example is to formally create a subclass of the ontology? ...because making a fork with different content (added triples to cover a new language strings) without formally renaming the project sounds bad to me.

Well, to be honest, I think forking it with a new subject is preferable to re-using it and add properties to it, but is still not the optimal scenario. Ideally, you'd create a PR and add properties / translations to the source, like what is happening here in this repo (see #21). But in any case - you want the world to be able to use your improvements!

Well, to be honest, I think forking it with a new subject is preferable to re-using it and add properties to it, but is still not the optimal scenario. Ideally, you'd create a PR and add properties / translations to the source, like what is happening here in this repo (see #21). But in any case - you want the world to be able to use your improvements!

Obviously the optimal scenario is a different collaborative one than the scenario you presented: I assume those choosing to work elsewhere has first considered and given up on the collaborative approach for whatever reason.


feat:file added

please merge my college

@Jit-Bdr-Rana I have to close this request without merging, because you requested to add a non-existent domain to this repository: Host thearyanschool.edu not found: 3(NXDOMAIN) Please ensure that you are familiar with this repository rules located at the bottom of this page and submit a new request with the correct information. Thank you for your understanding!


Support connect agent configuration in cvdr.toml

While working on this PR, I found a weird point about flag setting before running subcommand. For some configurations, it brings config of default service if config of speficied service is empty IIUC. Is it known issue? I feel we need to refactor around here, not to bring configuration value of different service.


Problem playing back captured Instagram pages

I have captured Instagram pages with Squidwarc and playing them in back in openwayback (latest Docker) triggers a script that seems to put the UI in an endless loop of reloads:

The same WARC file plays back in Webrecorder player and pywb without any problems.
The openwayback log does not seem to contain any errors apart from messages like this when the interface is reloaded:
Dec 25, 2018 7:49:32 AM org.archive.wayback.util.webapp.PortMapper getRequestHandlerContext
FINER: No mapping for localhost/wayback
Dec 25, 2018 7:49:32 AM org.archive.wayback.util.webapp.PortMapper getRequestHandlerContext
FINER: No mapping for localhost/

Attaching a sample WARC where this issue happens (which works fin in e.g. Webrecorder player):
58434.warc.gz

Hi, I have the same problem with Port:

Feb 27, 2019 5:00:41 PM org.archive.wayback.util.webapp.RequestMapper mapRequest
WARNING: No PortMapper for port 80

@jafamo is your problem also specifically with replaying Instagram pages?
@peterk thanks for opening this issue. We recognize there is a problem, as you report, with replaying Instagram pages. We currently do not have a fix in the works for handling this, but we are accepting pull requests if anyone would like to work on the issue.

Hi @ldko,
Not really. I  installed openwayback and I change port in wayback.xml to port=80
Now I have a new error:
Feb 27, 2019 5:37:54 PM org.archive.wayback.util.webapp.PortMapper getRequestHandlerContext
FINER: No mapping for MY_DOMAIN/
Feb 27, 2019 5:37:54 PM org.archive.wayback.util.webapp.PortMapper getRequestHandlerContext
FINER: No mapping for /

In my wayback.xml I have configured:
wayback.basedir.default=/tmp/openwayback
wayback.url.scheme.default=https
wayback.url.host.default=localhost
wayback.url.port.default=80

Hi @jafamo,
What is the URL you are using when you are getting an error? Using https with port 80 is not common. By default, if you are not specifying a port in your URL, it would be looking at port 443 when using a https scheme. Also, if you are running in Tomcat and not using the default port 8080, you may need to configure a <Connector> for the port in your Tomcat's conf/server.xml if you haven't already.
Have you tried running OpenWayback with a default configuration to see if it is working for you? As it is, I believe your issue is unrelated to the issue initially described in #389. If you continue to have a problem after troubleshooting your port, please open a new issue and link to this one as a reference to the thread so far. Thanks!


Add some utils functions to ChemReactions

provide a function to re/move agents
add utils function to remove atom-mapping numbers

I think this is ready to merge.
@bp-kelley : you agree?

I'd like to go ahead and tag the release branch (because April 1 is just the day to do such things), so I'm going to interpret silence as assent and merge this.
Thanks Nadine!


[suggestion] use protobuf for serialization

Please consider using protobuf as a measure to unify the message definitions between different components which may implement this API.
Protobuf is a simple serialization framework which generates fast serde methods based on definitions written in a file; these definitions are portable between 10+ different languages and generally offer a clearer understanding of the data within the messages as there is no clutter presented from the serialization logic.
For more information please refer to: https://protobuf.dev/getting-started/javatutorial

I'm not familiar with protobuf, is it just a spec similar to OpenAPI or is it also a specific way of serializing the data? My primary goal when making the current implementation was to keep it as standard as netty and Minecraft's PacketByteBuf. The reason is that I felt it is what most developers would likely look at using from what the client provides.
Are there any major benefits to protobuf vs the current implementation also? I don't foresee something such as multiple languages being very beneficial for the goal of this project, which is mods for the Java Minecraft client

Using protobuf serves no benefit here.

It creates a higher entry barrier for devs
multi-language support is unneccessary for Minecraft: Java Edition
It adds a fullblown new library to every hypixel mod without need.

The current implementation seems to be very efficient, what kind of "clutter" in serialization logic do you see here?

multi-language support is unneccessary for Minecraft: Java Edition

With things like mineflayer and other Minecraft cross-language APIs, protobuf generation could be helpful.

It creates a higher entry barrier for devs

not really? protobuf is relatively simple, and it would be a similar api regardless

It adds a fullblown new library to every hypixel mod without need.

protobuf core is 1.7 MB as of now.

ProtoBuf is also easier to manage and understand, since it can be verified on server and client. Although if Hypixel's internal APIs don't already use protobuf, I understand that it probably doesn't make sense to start using it for this specific API.

@pauliesnug The example of mineflayer is a bad one - this api as well as the whole hypixel server is not created to serve headless clients.

ProtoBuf is also easier to manage and understand, since it can be verified on server and client. Although if Hypixel's internal APIs don't already use protobuf, I understand that it probably doesn't make sense to start using it for this specific API.

Please do not use ProtoBuf. Use a sensible protocol encoding library like capnproto or something hand rolled.

On a more serious note: protobuf does not really provide many benefits over minecrafts native methods. Protobuf is also just generally a worse option for any project not on the scale of google. There is a lot of leniency that makes working with them very cumbersome and error prone to work with. There are way to remedy this, but even protobufs own authors recommend other libraries over it and (as most projects made by google) protobuf intentionally trades in human capital for slight efficiency gains. I can whole heartedly recommend not using protobuf for most things, and especially in this context, where a more standard and easier alternative already presents itself.

I think based on the split opinions here and the current implementation being more for our intended target audience we'll be sticking with that, but thanks for the suggestion!


analyzer.go: add support for nested go modules

This change adds support for analyzing projects with more than one go.mod. This will let us run this tool on https://github.com/cosmos/cosmos-sdk
Updates https://github.com/cosmos/cosmos-sdk/issues/10572
Related: https://github.com/securego/gosec/issues/501

Codecov Report

Merging #23 (103e494) into master (d50c2b8) will decrease coverage by 0.21%.
The diff coverage is 70.58%.

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
- Coverage   71.05%   70.84%   -0.22%
==========================================
  Files           9        9
  Lines         570      583      +13
==========================================
+ Hits          405      413       +8
- Misses        143      146       +3
- Partials       22       24       +2

Impacted Files
Coverage Δ

analyzer.go
89.15% <70.58%> (-2.35%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d50c2b8...103e494. Read the comment docs.


Run all flutter/packages macOS tests manually on macOS 14.5 bot

Prerequisites

[x] https://github.com/flutter/flutter/issues/148860

Instructions
Update to latest depot_tools by running gclient:
To run manual led test on a Mac-14 staging bot:
led get-builder "luci.flutter.staging:Mac channels_integration_test" | led edit -d os=Mac-14 | led edit-recipes-bundle | led launch

To run on a specific bot:
led get-builder "luci.flutter.staging:Mac channels_integration_test" | led edit -d id=[insert bot id here] | led edit -d pool=luci.flutter.staging | led edit -d cpu= | led edit -d os= | led edit -d device_type= | led edit -d mac_model= | led edit-recipes-bundle | led launch

❗ File issues for tests that fail and add links to the issues in https://github.com/flutter/flutter/issues/148882. This is important so we can track any fixes that need to be cherrypicked to beta/stable and so steps that are steps are not completed before issues are resolved.

Tracking Progress:

[ ] Mac_arm64 macos_repo_checks
[ ] Mac_x64 build_all_packages master
[ ] Mac_x64 build_all_packages stable
[ ] Mac_arm64 macos_platform_tests master - packages
[ ] Mac_arm64 macos_platform_tests stable - packages
[ ] Mac_arm64 custom_package_tests master
[ ] Mac_x64 ios_build_all_packages master
[ ] Mac_x64 ios_build_all_packages stable

Ran and verified tests pass. Two tests do not pass, follow up issue files: https://github.com/flutter/flutter/issues/149830


Replace deprecated fields with calls to bindings.

This PR replace use of deprecated fields in DuckDBResult to the newly added recommended bindings (see https://github.com/duckdb/duckdb/blob/master/src/include/duckdb.h#L214).
Feedback is welcome.

@kmosegaard  It looks like NativeMethods.DuckDBNullmaskData throws exception when the column > 0. Any ideas?

I found the problem. DuckDBResult was not decorated with [In, Out]. I've created another PR.


Import Polling Locations from Spreadsheet

We are able to import a variety of data, like Measures and Candidates. Please extend this system to import polling locations from an uploaded CSV.
This is a related page in the admin interface: https://api.wevoteusa.org/import_export_batches/batch_list/?kind_of_batch=MEASURE&google_civic_election_id=0&state_code=
Specifically we need to import "Utah polling stations" from this Google spreadsheet:
https://docs.google.com/spreadsheets/d/1xAVTtzleTF9FOIN5YXGptnXsidNzjxUqU4mFUnjXLQ0/edit#gid=1868994993

Finished and verified.


Fix PyPi release

PyPi now requires use of API tokens (and 2FA for the user that generates them). https://blog.pypi.org/posts/2024-01-01-2fa-enforced/
Steps needed

[x] log in and generate an API token
[x] Add GitHub secret for PYPI_API_TOKEN with the token

Validated the approach and twine config w/ API token via this run --> https://pypi.org/project/getgauge/
So this should be fine for next release.

@sriv This can be merged any time, can wait for next release.


Deploy failing to overwrite PrecompiledViews.dll

For deployment issues, please provide us with the following information:

Repro steps.

When committing to branch, project is failing to deploy with the following error:
Error: Failed to change file that is currently being used "D:\home\site\wwwroot\ASSEMBLY.PrecompiledViews.dll"\r\nD:\Program Files (x86)\SiteExtensions\Kudu\75.10629.3460\bin\Scripts\starter.cmd "D:\home\site\deployments\tools\deploy.cmd"

Project structures.

ASP.NET Core 2.0 project

The log/error given by the failure.

Copying file: 'ASSEMBLY.PrecompiledViews.dll'
Failed exitCode=1, command="kudusync" -v 50 -f "D:\local\Temp\8d5fb6cc8f1aec8" -t "D:\home\site\wwwroot" -n "D:\home\site\deployments\8cf42941a42289b50bc1f4b4160a576f40c6533c\manifest" -p "D:\home\site\deployments\e6927448cbc2052f84335b187cbb23c87f40ef44\manifest" -i ".git;.hg;.deployment;deploy.cmd"
An error has occurred during web site deployment.
Error: Failed to change file that is currently being used "D:\home\site\wwwroot\ASSEMBLY.PrecompiledViews.dll"\r\nD:\Program Files (x86)\SiteExtensions\Kudu\75.10629.3460\bin\Scripts\starter.cmd "D:\home\site\deployments\tools\deploy.cmd"

Debug your Azure website remotely.

boothbuddy.azurewebsites.net

Note: In order to deploy, I have to stop the website and sync

When it's in that state, if you go to Kudu Console, are you able to rename that file? Normally, kudusync tries doing that, and dll files should be renamable.

Hi
If the problem persists and is related to running it on Azure App Service, please open a support incident in Azure:
https://learn.microsoft.com/en-us/azure/azure-portal/supportability/how-to-create-azure-support-request
This way we can better track and assist you on this case
Thanks,
Joaquin Vano
Azure App Service


update pre-commit & bump supported python versions

See pysal/spaghetti#663.

Failure unrelated to PR, see #213.


Set 'void' to return type in types file.

#95 which lacks return-type annotation, implicitly has an 'any' return type.
Set 'void' to return type in types file.

👍


syntax highlighting not enabled

Hi. Thanks for a great extension that complements "docs view". When the syntax highlighting works, it's great, but for most of my .ts/.tsx files, it's all white and without linebreaks. I can't seem to find a pattern for which files it works for and which it don't.
Edit: I want to add three things:

The syntax highlighting either works or don't for the whole active file in the editor, regardless of where the displayed definition is imported from.
When the syntax highlighting works, there is a horizontal scrollbar. I would prefer it if the lines just wrap, like they do in "docs view" and the terminal.
It seems to work for all .css and .js files though

Yeah I've noticed this for some cases as well. I copied the syntax highlighting code from docs view and adapted it, so I'm not really sure how to resolve it. If you're able to provide some examples that might help. If you're able to contribute to this that would be really appreciated too. This is the first extension I created so a lot of it felt quite experimental 😅 It works most of the time but there's a lot of awkward handling to try to make it work in most cases.
With Rust (my main language) it gives me a start and end line that encompass the whole function. But most other languages only provide the start/end line for the function signature. So the extension tries to figure out where the function docs start and where the function ends using some hacky heuristics. It's not perfect but felt "good enough" for a v0.1.
Regarding the horizontal scroll - I added this intentionally for my own preference but it's easy to make it wrap as well. I haven't looked into adding settings yet. There is a setting inherited from docs view but I don't think it works unfortunately.
I don't have a lot of time to work on this atm sorry. Something specific like adding an option to toggle the horizontal scrollbar might be easy to do. If you do figure out why syntax highlighting doesn't work for some files, I'd be interested to have a look.

A hint that might help you debug: If the definition is a React component, your view renders HTML as HTML, i.e. a  becomes an actual button.
I maybe would like to help if possible, if you can guide me on where to start...


update on #434

Signed-off-by: shivam tyagi<EMAIL_ADDRESS>This is a fix for

#434

@jihoon-seo
I am not sure we need this PR.  I think the current setting for Labeler works for main branch.
https://github.com/cncf/glossary/actions/workflows/labeler.yml
PTAL #473 for testing.

FYI @jihoon-seo
https://github.com/actions/labeler/issues/121

@jihoon-seo
If the changes acceptable, please merge :)
I will reopen the PR #471 for testing :)


Typescript support?

Hello
Thanks for this great library. When I use react-bootstrap-table, I can install @types/react-bootstrap-table
for the react-bootstrap-table-next, there seems no @types/types/react-bootstrap-table-next.
I'm using Typescript with react for a new project, is there any way to make the library work with typescript?
Thanks

@cbfrank @types/react-bootstrap-table is developed by other contributor not me, right now I have no plan to support TS, hope someone can help on it. Anyway, I'm also start to use TS in my company, maybe I can support the TS after I master on it ：）

@AllenFang is this something that you're still interested in supporting? I've started to hack on this a bit, but not being familiar with all the intricacies of the lib I'm sure there are gaps in my knowledge.  Would love some early feedback if you want to add TS support to the library still!

i have some hastily thrown together typedefs if you need. by no means releasable through DefinitelyTyped, but i'm happy to share if you like.

Any news about the support for TypeScript of this very nice lib?

Hello! I really needed typings for this great library, so I started working on them, see the current status here: https://github.com/cancerberoSgx/suitescript-types-tools-and-frameworks/blob/master/react-redux-client-app/src/components/data/react-bootstrap-table-next/types/types.d.ts
There's still much to do, but basic examples already work without compile errors. I will keep working on this, although I would like to know if the author is interested on adding these in this project itself or if should I contribute them in DefinitelyTyped .
Thanks and keep it up!

Hi there,
Any update on this issue?
After I installed the library, npm install @types/react-bootstrap-table-next, I tried to use "import BootstrapTable from 'react-bootstrap-table-next';" in my tsx file. Same as example showed in storybook.
I got error message says "Could not find a declaration file for module 'react-bootstrap-table-next'. '../node_modules/react-bootstrap-table-next/lib/index.js' implicitly has an 'any' type."
And I run npm install @types/react-bootstrap-table-next, but couldn't find any.
Does anyone has same issue? or how could I solve the problem?

@ronz28 You are having that error because npm didn't install anything since @types/react-bootstrap-table-next does not exist.
@cancerberoSgx I've looked into your types and i think we should move on and push that to DefinitelyTyped. Even if it is incomplete, that would be enough for a first version.
It's been a long time since this issue was first opened and I (as many other TS-lovers) need this to upgrade from react-bootstrap-table. will try to contribute improving the type definitions frequently.

@dacevedo12 OK will try to put it to Definitely Typed in the short term, will keep you posted, thanks

@cancerberoSgx any updates on this?

lets add type definitions directly in repository so everybody can use TS w/o waiting for Definitely Typed update

@dacevedo12  I'm sorry I miss this for too long. I'm trying to build the project and then see how I can add my typings to it. npm  install is currently failing for libsass so now I'm updating your dependencies
In the meanwhile, since I not sure I will have the time , these are  the typings I've written.
https://github.com/cancerberoSgx/worldbank-data-ui-client/blob/master/src/components/data/react-bootstrap-table-next/types/types.d.ts
I remember types for most public API was typechecking correctly and documented Ifrom sources or your docs. I think these types target all the projects so we need to divide it - one .d.ts for each project in the mono repo.
I assume it's OK to assume you want the typings inside the project and not externally like in DefinetelyTyped ? If not, please comment so I desist
I will integrate that as it is to feet the projects and after that continue working on completing the thing , formatting, etc. I assume that's your idea ? If not please tell me so I desist sine I have little time.
THanks and sorry again for the delay

Hey @cancerberoSgx those types look great!. Just like you said, we should get an ultimatum from @AllenFang to know whether he wants to maintain the type definitions here in the repo or if we should add them to the community-maintained DefinetelyTyped

@dacevedo12 OK, I standby then - since I'm not actively using the library I have little time or motivation to complete the typings, but once we know how to proceed I will

@cancerberoSgx Thanks for posting your types. I am using them in a project and have made a few additions. It would certainly be nice if we could get those definitions posted in this repo, because I would be more than happy to contribute. @dacevedo12 How long do you think we should be waiting before just adding them to DefinetelyTyped?

Let's just open a PR in DefinetelyTyped. I think it's better for the repo maintainer since he doesn't need to care about it and the community that can do faster changes or fixes if necessary.
@cancerberoSgx if you open a PR please link it here so everyone following this issue knows

Any news on this?

Hi there, just wondering if there was any update on the push of types to DefinitelyTyped.

I have a personal repo that I use for my types, https://github.com/MacroPower/PossiblyTyped
I put @cancerberoSgx 's code there and have been adding a bit here and there. Don't mean to credit steal or anything, if he wants to make a repo of his own and admin all this, more than OK with me.
The issue here is that the types are not comprehensive and they also need to conform to DefinitelyTyped guidelines. Right now, there's no way they would be merged. This is a pretty large package, so it's not exactly trivial. I certainly don't have time to do them myself, and I assume @cancerberoSgx doesn't either.
If anyone wants to work on this together, feel free to use my repo... Once the types are good enough, someone can open a PR with DefinitelyTyped.

Does anyone know if this subject advanced in some direction?
There are any plan to add these types definitions in an official module or not?

Thanks for all who put the types together for react-bootstrap-table-next.
Has anyone created a types file for the react-bootstrap-table2-toolkit by any chance?

@owen-stellar We use @cancerberoSgx 's base, developing the types as we need them. There are still lots of any which isn't ideal for publishing but it works.
https://gitlab.com/fluidattacks/integrates/-/blob/master/front/src/typings/react-bootstrap-table-2/index.d.ts#L267
hopefully on this thread people contributes towards the goal of publishing them on DefinitelyTyped

Hi @gosticks,
I've just installed your types definition, thanks for your work !
I was wondering if you have planned to support exportCSV options ? It seems that exportCSV prop hasn't been defined in TableToolkitProps interface...
Again, thanks for your contribution 🤩

Hey @Wait4Code,
it seemed I missed the CSV export somehow, I just added those definitions to my fork of DefinitelyTyped. I will also create a PR for the changes in the official repo but it will probably take 7 to 10 days before the PR is processed. So if you need the types sooner I would suggest just getting them from my fork:
https://github.com/gosticks/DefinitelyTyped/tree/feature/react-bootstrap-table-next.

So I tried installing react-bootstrap-table-next but the import says the module cannot be found... Does anyone have a working example of this?

@ccoffman-ebsco do you have both packages installed react-bootstrap-table-next and @types/react-bootstrap-table-next?

Hello people, I won't we working on typings for this (sorry) so (@MacroPower ) feel free to use my code as you wish, thanks.

Seems to me this issue can be closed
https://www.npmjs.com/package/@types/react-bootstrap-table-next


Add Streaming Subscription Support

Dapr v1.14 adds support for streaming subscriptions which allows for dynamically subscribing to pubsub topics over a bi-directional gRPC stream. This API is exposed via the SubscribeTopicEventsAlpha1 gRPC API.
On first call, the client sends an InitialRequest containing the pubsub, topic name, etc. From then on, topic event messages are sent from daprd to the client over the stream. The client reports the processing status of this message back to daprd. A message will not be considered processed until the client has responded with this status. There can be multiple in-flight topic messages. Daprd unsubscribes from the topic when the stream is closed.
https://github.com/dapr/go-sdk/pull/578/ is a reference implementation for the go-sdk.

You used the wrong issue template. :)

This is needed for the Catalyst launch, due by next Wednesday. Is this still on track?


README - separate user vs developer install instructions

Shorten the installation instructions a bit (don’t need to install go-swagger to compile + run, for instance) and then have a longer “for developers” section that includes dev tool requirements and instructions for developing (including code generation for both pop + swagger)

I will also need to add developer instructions to emphasize the special sqlite3 tags that are required for using soda and compiling sqlite3 into the binary.

Completed.

Completed.


Dev guide

Updated the feature contributions part

Be careful of deprecated files. If a file has Person/Phone/Address/Email in the filename or as a string anywhere in the file, high chance you need to change/delete it.

Pull Request Test Coverage Report for Build 59

24 of 25 (96.0%) changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.06%) to 91.993%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/main/java/seedu/recipe/logic/parser/RecipeBookParser.java
0
1
0.0%

Totals

Change from base Build 54:
0.06%

Covered Lines:
1551

Relevant Lines:
1686

💛  - Coveralls


Add a CONTRIBUTING.md

Add a CONTRIBUTING.md to help people know what is expected for contributing (like needing tests and documentation)

This is one of those things I had in the back of my head but never made an issue for. Thank you for bringing it up :D

What sort of guidelines does everyone think we should have in place?
I'm thinking about:

"git commit message" guide.
Every PR should have godoc style comments on ever piece of code modified, regardless of whether or not it had documentation before
If the PR breaks backwards compatibility it should be noted in the README
Tests should be added if at all possible. PRs without tests will be merged, but a PR with tests is more favourable than one without.

And gofmt? @paked

I thought that was a given already :p
On Tue, 28 Jun 2016 3:54 pm Ousmane Traore<EMAIL_ADDRESS>wrote:

And gofmt? @paked https://github.com/paked
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/EngoEngine/engo/issues/376#issuecomment-228955268,
or mute the thread
https://github.com/notifications/unsubscribe/AIBJSj6_xQGdIoBJeF7X1CRVKxLHldsbks5qQLcDgaJpZM4I-sXB
.

Closed by #396