Flywheel

created flywheel subsystem
wrote function set flywheel with feedforward and PID

Please merge from main to resolve merge conflicts.


TD-222: Sync with valitydev/erlang-templates@da1971c

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@e37c7bb). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #1   +/-   ##
=========================================
  Coverage          ?   85.43%
=========================================
  Files             ?       21
  Lines             ?      755
  Branches          ?        0
=========================================
  Hits              ?      645
  Misses            ?      110
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e37c7bb...a389c80. Read the comment docs.


WR-1378-fix-styling-latest-employment-trends

The client requested that the content be themed as per the following wireframe.
See LMS tab on:  http://workbc.docker.localhost:8000/industry-profile/accommodation-and-food-services

The theme has been fixed as shown below

Thanks, lgtm. One request: could you please recommend, on the ticket, a browser extension that shows the styles as per the first screenshot? This will be helpful to the whole team.

Sure @infojunkie It looks to me like the screenshot at the top of this page is using the stock Chrome Dev tools using the steps shown below.


Add ADR 0012 Map Component Api

Overview
ADR for the leaflet map component
Checklist
~- [ ] Styleguide updated, if necessary~
~- [ ] Swagger specification updated, if necessary~

As in doing L.Map.extend({})? Not a bad idea. I think I'll need to mess with the implementation to figure out which makes more sense - it shouldn't affect the API very much, so I think we can go ahead and merge this, then come back to it if it turns out that extending makes more sense.


CertificatePinner JavaDocs Offer Odd Advice

The JavaDocs for CertificatePinner recommends creating pins for every certificate in the chain, as reported by the "Peer certificate chain" output in LogCat when a pin fails. So, at the moment, the docs have:
CertificatePinner certificatePinner = new CertificatePinner.Builder()
       .add("publicobject.com", "sha256/afwiKY3RxoMmLkuRW1l7QsPZTJPwDS2pdDROQjXw8ig=")
       .add("publicobject.com", "sha256/klO23nT2ehFDXCfx3eHTDRESMz3asj1muO+4aIdjiuY=")
       .add("publicobject.com", "sha256/grX4Ta9HpZx6tSHkmCrvpApTQGo67CYDnvprLg5yRME=")
       .add("publicobject.com", "sha256/lCppFqbkrlJ3EcVFAkeip0+44VaoJUymbnOaEUk7tEU=")
       .build();

Near as I can tell, CertificatePinner implements a logical OR when there are multiple pins set for any given hostname. So long as any certificate in the chain matches a pin for that hostname, the certificate is accepted.
Hence, from a security standpoint, the code in the question is the same as:
CertificatePinner certificatePinner = new CertificatePinner.Builder()
       .add("publicobject.com", "sha256/lCppFqbkrlJ3EcVFAkeip0+44VaoJUymbnOaEUk7tEU=")
       .build();

or even:
CertificatePinner certificatePinner = new CertificatePinner.Builder()
       .add("publicobject.com", "sha256/AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=")
       .add("publicobject.com", "sha256/lCppFqbkrlJ3EcVFAkeip0+44VaoJUymbnOaEUk7tEU=")
       .build();

The recommended advice is not pinning on the specific certificate for that server, but rather for every certificate based on the root CA (in this case, AddTrust's), since you're setting up a pin on that root CA certificate. There is nothing wrong with pinning on the root CA, but the code's superfluous pins makes it appear that you are pinning on the server's certificate, not the root CA's.
You might want to modify the docs to:

Specifically mention that each add() is logically OR'd with other pins for that hostname
Revise the example to only pin the specific server certificate (i.e., sha256/afwiKY3RxoMmLkuRW1l7QsPZTJPwDS2pdDROQjXw8ig=)
Offer a related example showing pinning the root CA (i.e., sha256/lCppFqbkrlJ3EcVFAkeip0+44VaoJUymbnOaEUk7tEU=) and noting the effective difference
Possibly show implementing a pin set via two add() calls (e.g., for migrating to a new certificate)

If I am misunderstanding the nature of add() and CertificatePinner, I sincerely apologize.

Does this help?
  @Test public void upgradeCases() throws Exception {
    // Create a CA, a private cert, and a certificate pinner that knows both of them.
    HeldCertificate caCert = new HeldCertificate.Builder()
        .serialNumber("100")
        .build();

    HeldCertificate myCert = new HeldCertificate.Builder()
        .serialNumber("200")
        .issuedBy(caCert)
        .build();

    CertificatePinner pinner = new CertificatePinner.Builder()
        .add("example.com", CertificatePinner.pin(myCert.certificate))
        .add("example.com", CertificatePinner.pin(caCert.certificate))
        .build();

    // Confirm this all checks out.
    pinner.check("example.com",
        Arrays.<Certificate>asList(myCert.certificate, caCert.certificate));

    // What if our CA is loses trust by the browsers?
    // We can get a different CA to sign our old certificate.
    HeldCertificate newCaCert = new HeldCertificate.Builder()
        .serialNumber("300")
        .build();
    HeldCertificate sameCertDifferentCa = new HeldCertificate.Builder()
        .keyPair(myCert.keyPair)
        .serialNumber("400")
        .issuedBy(newCaCert)
        .build();
    pinner.check("example.com",
        Arrays.<Certificate>asList(sameCertDifferentCa.certificate, newCaCert.certificate));

    // What if our cert is compromised? We can get a new cert signed by our old CA.
    HeldCertificate differentCertSameCa = new HeldCertificate.Builder()
        .serialNumber("500")
        .issuedBy(caCert)
        .build();
    pinner.check("example.com",
        Arrays.<Certificate>asList(differentCertSameCa.certificate, caCert.certificate));
  }

This issue is with respect to improving the documentation for CertificatePinner. I am sorry, but I do not see how that code snippet will help.

It’s just an example of why you’d want to use multiple pins.

Just to be clear: by documentation, I am referring to this page, this page, or perhaps a new page. My interpretation of your comments is that you are proposing adding this block of code, sans explanation, to one of those pages.
However, HeldCertificate is not part the public API, and so few people reading the documentation will have heard of it. Also, I am not certain that many people will recognize your middle scenario ("We can get the blue CA to sign our old certificate").
As a test case, your block of code is great! As documentation, on its own, I do not believe that it will help much. But, that's just me.

The code above is intended to convince you that pinning all certs in the chain is useful in practice.

There is nothing wrong with using your sample pin configuration, so long as the developer realizes what is going on here and understands that it means that fraudulent certs issued by the CA will bypass the pin. I doubt that developers reading the documentation will realize that this is the behavior, that's all.

Got it. My argument is that more pins aren’t superfluous as you suggest, but functional because they support more kinds of forward migrations.

I think we should expand the https://github.com/square/okhttp/wiki/HTTPS documentation to show what an example client setup for using certificate pinning with regular certificate rotation would look like.  Maybe a page for here's how you can deploy a client pinning against Let's Encrypt certificates that rotate every 3 months.

Thanks for your awesome work on Okhttp! It is one of the most used library in our teams.
I think this issue should be discussed some more. It is my understanding that the recommended approach on de docs is not a good security advice but I may be wrong and would like to revive this issue because of that.
By pinning all the certificates printed in logcat we are pinning the whole certificate chain. Since CertificatePinner checks if any cert on the chain is pinned, that makes any certificate issued by the same root as valid on your configuration.
Say my cert chain is:

root
intermediate 1
mycert

And I pin them all. With that, any other chain like:

root (same as above)
intermediate 2
completely_different_cert

Will ALSO pass validation since I've pinned the root. Is that correct? If that is the case, then I agree the docs are misleading to say the least and wouldn't recommend this as security best practice.
Hopefully this can be peer reviewed by other here too. Thanks

Suppose your device trusts 300 root certificates. The practical benefit of certificate pinning is to defend against attacks by the 299 root certificates that your device trusts.
If the root you’ve chosen to sign your certificate is not trustworthy, you should choose another root. Otherwise users with browsers and other user agents that don’t pin are vulnerable.
The reason I recommend pinning the root certificate is that it allows you to gracefully recover from a lost private key on your own certificate. Your in-the-wild devices will trust a new certificate that you get issued as long as you use the same CA.

If the root you’ve chosen to sign your certificate is not trustworthy, you should choose another root.

I suspect that few developers have the ability to determine whether a particular root certificate authority is or is not trustworthy. Also, "trustworthy" itself is somewhat nebulous. For example, if the attacker is able to get a fraudulent certificate via apparently legitimate means (e.g., law enforcement requests), is that certificate authority now somehow not trustworthy?
IMHO, a better framing is in terms of the abilities of an attacker:

If an attacker can obtain a fraudulent certificate, but only from an authority of their choosing (e.g., one where they have successfully bribed the right people), then pinning the root certificate of your CA may be acceptable. It comes down to the number of potential attackers who might try pulling off this sort of attack.

If the attacker can obtain a fraudulent certificate from a wide range of authorities ("nation-state level adversary"), pinning at the root CA level will be less effective.

Or, in matrix form:

Weak Attackers
Strong Attackers

Few Attackers
pin the root certificate
pin the site certificate

Many Attackers
pin the site certificate
abandon hope

Most apps should in the few/weak attackers quadrant, so pinning the root certificate should be fine (exemplary, even). For any individual project, it's a matter of coming up with your "threat vectors" and deciding which quadrant you are in, and whether you are in position to deal with the challenges of pinning the site certificate.

From what I understand, and again, that might be wrong, all you need to
have a certificate that passes pin validation, as is now recommended, is
any certificate from the same root which is relatively easy to achieve. You
just buy a new certificate from the same issuer and then you can bypass
pinning. As you mentioned, there are 300 or some root certificates that are
embedded in Android. It is feasible to buy one from each of them but even
then that is not necessary. Most apps connect to known apis. You just check
which root you need by looking at the api endpoint and find how to get a
new certificate from the same root.
You don't even need to buy a level 2 certificate. You can buy a very cheap
one from some intermediate. It just needs to: 1. Be a valid certificate
(that is why I'm saying to buy one) and 2. Be from the same root.
I understand that narrowing it down from 300 roots to one is better than
nothing but I still think that to recommend this in the docs is not
recommending a good practice IMHO but I might be wrong. I'm no expert.
Some way to solve this issue would be to let us pass an implementation of
check, or have an option to change the algorithm applied to one that would
mandate validating all instead of any certificate in the chain.
Em sex, 20 de set de 2019 20:33, Mark Murphy<EMAIL_ADDRESS>escreveu:

If the root you’ve chosen to sign your certificate is not trustworthy, you
should choose another root.
I suspect that few developers have the ability to determine whether a
particular root certificate authority is or is not trustworthy. Also,
"trustworthy" itself is somewhat nebulous. For example, if the attacker is
able to get a fraudulent certificate via apparently legitimate means (e.g.,
law enforcement requests), is that certificate authority now somehow not
trustworthy?
IMHO, a better framing is in terms of the abilities of an attacker:

If an attacker can obtain a fraudulent certificate, but only from an
authority of their choosing (e.g., one where they have successfully bribed
the right people), then pinning the root certificate of your CA may be
acceptable. It comes down to the number of potential attackers who might
try pulling off this sort of attack.
If the attacker can obtain a fraudulent certificate from a wide range
of authorities ("nation-state level adversary"), pinning at the root CA
level will be less effective.
Or, in matrix form:
Weak Attackers Strong Attackers
Few Attackers pin the root certificate pin the site certificate
Many Attackers pin the site certificate abandon hope
Most apps should in the few/weak attackers quadrant, so pinning the root
certificate should be fine (exemplary, even). For any individual project,
it's a matter of coming up with your "threat vectors" and deciding which
quadrant you are in, and whether you are in position to deal with the
challenges of pinning the site certificate.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/square/okhttp/issues/3471?email_source=notifications&email_token=AAC34QSO2BQLDPHLNGG44L3QKVMVHA5CNFSM4DTZFKR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7IETEI#issuecomment-533744017,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAC34QQP4E5HMU632PBF5TLQKVMVHANCNFSM4DTZFKRQ
.

I stand by defending against the dangers of bricking an app due to a compromised private key. This isn't academic; Heartbleed compromised many private keys.
The advice offered is intended to help busy software developers improve the security of their software. Anyone who is sufficiently motivated is going to have a security and operations team setting policy and those people can make appropriate security vs. operations trade-offs.

@victorolinasc the attacker needs a certificate signed by the same CA, but also that has a SubjectAltName of the victim’s domain. Root CAs don't typically sign certificates without proof of domain ownership.

We should probably focus on concise specific advise for small companies without security teams. And assume the Squares and Twitters of the world have their well informed security teams with informed policies, just support them via the APIs.
The bigger risk for the former is only pinning against something temporary or revokable. Hence the OR of multiple pins.
Regarding which root CAs to trust. You do that when you choose who to pay for certs from. And should have more than 1.

Going to close as won't fix.  This topic isn't one size fits all, you should understand what you are doing enough that you don't need to follow along or worse copy and paste from a open source website.
I came here to write up this documentation, then realised that there are lots of external blogs on best practices.  We don't need one more.
@swankjesse re-open if you disagree

My in progress draft
Client Security
Security Teams
Discuss your security needs/requirements with your Security Team.
For any large companies, especially those with external user data,
the policies provided by your security team should define what you
should be doing to secure clients.
Certificate Pinning
Questions to Answer

Why are we certificate pinning, what attacks are we worried about?
Which hosts do you control, that you should be pinning requests for?
What happens when and on what frequency are certificates rolled.
What happens in DR scenarios, for example a switch to backup data centres,
or certificates are accidentally leaked.
What is the complete list of CAs that will issue any valid certificates.
Are there any other relevant hosts hosting or proxying sensitive user data
such as a CDN (fastly etc).

Good reasons to apply certificate pinning

The app transfers sensitive user data, and a MITM attack by

Certificate Pinning
val hostname = "publicobject.com";
val certificatePinner = CertificatePinner.Builder()
    .add(hostname, "sha256/AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=")
    .build()
val client = OkHttpClient.Builder()
    .certificatePinner(certificatePinner)
    .build()

val request = Request.Builder()
    .url("https://" + hostname)
    .build();
client.newCall(request).execute();

Hosts


npm install fails on vmwarefusion docker-machine vm (but works on virtualbox)

I'm trying to run npm install through a docker container, using:
docker run -it --rm -v $(pwd):/src cthulhu666/yeoman npm install
but it fails with:
85351 error node v5.5.0
85352 error npm  v3.3.12
85353 error path /src/node_modules/.defaults.DELETE/node_modules/clone
85354 error code ENOENT
85355 error errno -2
85356 error syscall rename
85357 error enoent ENOENT: no such file or directory, rename '/src/node_modules/.defaults.DELETE/node_modules/clone' -> '/src/node_modules/defaults/node_modules/clone'
85357 error enoent This is most likely not a problem with npm itself
85357 error enoent and is related to npm not being able to find a file.

I then tried using docker run -it --rm -v $(pwd):/src cthulhu666/yeoman /bin/bash to enter the VM and run the npm install command but I got:
78120 error node v5.9.0
78121 error npm  v3.7.3
78122 error path /src/node_modules/.concat-with-sourcemaps.DELETE/node_modules/source-map
78123 error code ENOENT
78124 error errno -2
78125 error syscall rename
78126 error enoent ENOENT: no such file or directory, rename '/src/node_modules/.concat-with-sourcemaps.DELETE/node_modules/source-map' -> '/src/node_modules/concat-with-sourcemaps/node_modules/source-map'
78127 error enoent ENOENT: no such file or directory, rename '/src/node_modules/.concat-with-sourcemaps.DELETE/node_modules/source-map' -> '/src/node_modules/concat-with-sourcemaps/node_modules/source-map'
78127 error enoent This is most likely not a problem with npm itself
78127 error enoent and is related to npm not being able to find a file.

Whilst the file seems to change, it's always an error of a similar nature which suggests that it's a permissions issue. I can see that the directory in question (/src/node_modules/.concat-with-sourcemaps.DELETE/node_modules/source-map) does indeed exist.
I've just tried switching to a VirtualBox machine and running the same command and that completes without issue.

Dupe of https://github.com/docker/machine/issues/1460 maybe?  @frapposelli

Docker version 1.10.3, build 20f81dd
docker-machine version 0.6.0, build e27fb87
On the working VirtualBox machine:
Boot2Docker version 1.10.3, build master : 625117e
On the not-working VMWare Fusion machine:
Boot2Docker version 1.10.3, build master : 625117e


Improve Sorting Capability

With many items in the Gradebook, it can be difficult to efficiently sort items. There should be a "Sort" popup window where instructors can see their gradebook items and categories in a vertical list. Everything in this list can be dragged and dropped into new locations.
When changing items from uncategorized to categorized, item settings like "include in course grade calculation" and "release to students" need to be updated appropriately.
The sort order should also respect whatever view you were currently using in the Gradebook. So if you were viewing items by category, the sort box will be categorized. If you were viewing your Gradebook not grouped by category, the sort box would reflect the uncategorized sort order.

The developers at UD created this feature and plan to share it with the community.
Here is a video demonstration: https://youtu.be/iPVcxSTl0tM


pass all arguments

By using the arguments object, all arguments will be passed to the original ajaxBeforeSend method to ensure compatibility.

Thank You :)


Add combinational Pease FFT

Builds an FFT using the pease dataflow. This will be super useful for pipelining, as every stage performs exactly the same computation, making parallelism much easier.

Any references for "Pease dataflow"? I must confess I've not come across this before

Page 6 of spiral's paper describes it here; It's pretty much an FFT where the crossbar (reordering of inputs) is the same every cycle. This makes implementation a lot easier as every stage is identical, so we just have to repeat the same computation NStages times to complete the FFT.

Surprising how easy this was to implement, looks like the testing is going well! I do think my logic for pease might be a little off so I might increase the testing size from 8 to 16 points.

Also a surprisingly easy change, and the FFT seems to be working as-is!

Woohoo! I'm going to credit your SWE skillz and Filament for the ease of extension!! One thing I'd be curious about at some point is your reflections from implementing the whole FFT project and which parts felt easy. It would be particularly interesting because you've been building it in Verilog as well (I assume for C2S2).


findAllMatches broken

Describe the bug
there seems to be an issue with scores already mentioned here https://github.com/krisk/Fuse/issues/545 which may lead to the problem that findAllMachtes never finds a perfect match and therefore always shows partial matches
Version
6.4.6.
Is this a regression?
already happened in 6.4.1
🔬Minimal Reproduction
    const options = {
        findAllMatches: false,
        threshold: 0.3,
        keys: ["name"],
      };

   const results = (new Fuse([{name: 'Auditor'}, {name: 'Auditee'}], options)).search('Auditor');

Unfortnuately it seems like fuse is dead and I have to switch to another option for fuzzy search.

For anyone also running into this problem, as score never returns 0 and findAllMatches is looking for a zero which will never appear, I simply added a check on my own that looks for a score near 0 which counts as an exact match. This might not be the best solution as it can return false positives, but was the only way I could think of.


Create dashboard status.kodadot

For particular reason to be aware if we are up or not would be great to have handsome endpoints to see what's needed to have seamless working with users
spec
We should be able monitoring endpoints and route on minute basis, hope that's enough using serverless functions

[ ] subquery endpoint (magick)
[ ] SubSquid endpoint (rubick)
[ ] snek
[ ] unique
[ ] Netlify edge performance points
[ ] Pinata
[ ] Estuary

Then we could measure amount of time to resolve particular queries for routes

[ ] series-insight
[ ] spotlight
[ ] gallery
[ ] collection
[ ] random item detail
[ ] collections
[ ] random profile artist
[ ] other upcoming bigger query routed

[ ] Link "Status" to footer at KodaDot

stack
@roiLeo suggested https://github.com/juliomrqz/statusfy
probably it could be written as serverless function, we have some spare capacity on Netlify but for the reason, later it should be running outside Netlify to verify if there is everything ok

This is like great candidate https://calibreapp.com/

Free public status page https://www.atlassian.com/software/statuspage/pricing?tab=public

hello, I will try to create this status page

two submissions from me:
Upptime
Repo: https://github.com/preschian/kodadot-status
URL: https://preschian.github.io/kodadot-status/
Pros:

free, open source

Cons:

minimum 5 minutes interval (limitation from github actions)

Better Uptime
URL: https://kodadot.betteruptime.com/
Pros:

can integrated with infrastructure monitoring (datadog, grafana, prometheus)

Cons:

free version only support 10 urls

I'm impressed!
I guess thinking for the easier check we should have one list of all URLs we need to check for a client to work?
Do we have a global list of endpoints we are using? If not, let's create one and we can merge it with #1492

I've noticed we should add there Estuary endpoint.
Is there anything missing from list ?

bsx & moon endpoints ?
yes for both

plus we've added nft.storage which is currently passing through workers but would be good anyway, but bet it should be stable.

updated remaining endpoints here https://github.com/preschian/kodadot-status/pull/97
what is the moon endpoint? I couldn't find from here https://github.com/kodadot/nft-gallery/blob/main/utils/constants.ts

wow, https://preschian.github.io/kodadot-status/ beautiful!

what is the moon endpoint? I couldn't find from here main/utils/constants.ts

https://github.com/kodadot/click

if we are good to go, I think it's better to move the repo under https://github.com/kodadot
I just realized og-image on vercel had a couple of downtimes in this three days
better to move og-image repo under kodadot also

if we are good to go, I think it's better to move the repo under @kodadot

let's proceed :)

better to move og-image repo under kodadot also

that's would be great; I can reach out to Andrey and probably would need to redeploy on vercel?

let's proceed :)

ok, let me try to move the repository

that's would be great; I can reach out to Andrey and probably would need to redeploy on vercel?

It would be great if the output of the URL were still the same

unable to move the repository
You don’t have the permission to create public repositories on kodadot

handovering from Discord from Vik
Hey @Contributing Developer,
I just released a small API to check if our indexers are running.

Currently it has just two routes:
- /list - get list of all indexers
- /status/:id - status of the indexer

the API is awailable on the route https://squiki.kodadot.workers.dev/

Example
to get a status of rubick just call:
https://squiki.kodadot.workers.dev/status/rubick

I hope it can help you to debug things :pepemeow:

Example
to get a status of rubick just call:
https://squiki.kodadot.workers.dev/status/rubick

hooo, I like that endpoint status 👍
hhmm, for next, how to update that endpoint automatically in the status repo 🤔

We have uptime


[Synapse]: Initial Release

This PR sets up a working setup for a Synapse instance.
This was tested by importing the package from branch and running an ibtp model (from M-KOPA's instance). The model ran fine.
CI Is not yet established for this repo.
Versions used:
dbt-core                  1.4.9
dbt-sqlserver             1.4.3
dbt-synapse               1.4.0
This PR sets up a working set of files that have been tested via import into M-KOPA's instance. The main fix on the PR is to reference the insert_by_period.function() instead of just function() !

Features of release summarised by current topline of README:
NOTE:  Switching from insert_by_period to insert_by_timeperiod is a breaking change for models, IBTP is only known to work on Microsoft Synapse (other dbs to come, contributitions and tests welcome!) and IBTP had a separate developement path from latest IBP materialisation. Compared to "insert_by_period" accessible in dbt-labs-experimental-features , we have retained slightly different naming to make this distinction clear.
insert_by_timeperiod (IBTP) allows dbt to insert records into a table one period (i.e. day, week, month or year) at a time.
This materialisation is supported only for synapse. For other adapters, utilise the insert_by_period macros.
This materialization is appropriate for event data that can be processed in discrete periods. It is similar in concept to the built-in incremental materialization, but has the added benefit of building the model in chunks even during a full-refresh so is particularly useful for models where the initial run can be problematic.
Should a run of a model using this materialization be interrupted, a subsequent run will continue building the target table from where it was interrupted (granted the --full-refresh flag is omitted).
Progress is logged in the command line for easy monitoring.
The synapse insert_by_timeperiod materialisation includes a couple of differences from the other implementations:

CLI supported backfill mode with insertable start and end dates.

Enables you to backfill a range of dates
Backfill is done by DELETING whole date, then inserting replacement records (this is performant and simple)
Make backfill take priority over full refresh, this is a key change as it means you can run a combined backfill (IBP model) and full refresh (incremental models) at the same time. This enables you to run complex graphs of IBTP and incremental models, backfilling a date range, and they just work.
Backfill deletion is done by the timestamp_field

Customisable FROM and TO dates inside the materialisation loop enable you to include WINDOW functions in your code.

This requires sligthly more effort to use than the insert_by_period approach, but is more explicit and configurable, please see usage section below.


limo list events needs some work

Stuff with branches, like creating a branch or deleting a branch, are displayed incorrectly.
Might be nice to have user URLs.
Add GitLab support, if that makes sense.

https://developer.github.com/v3/activity/events/types/
Get all the types and payloads correct


[BUG] - DateRangePicker error message not using NextUIProvider Locale

NextUI Version
2.4.2
Describe the bug
Set the locale in the NextUIProvider
  <NextUIProvider locale='en-GB'>{children}</NextUIProvider>

Your Example Website or App
No response
Steps to Reproduce the Bug or Issue
Set the locale in the NextUIProvider
  <NextUIProvider locale='en-GB'>{children}</NextUIProvider>

Consume the DateRangePicker component
...
// from the docs
const min = today(getLocalTimeZone());
...
<DateRangePicker
  label="Start date - End date"
  minValue={min}
/>

Expected behavior
The error message should respect the provided's locale format.
ATM I receive Value must be 8/29/2024 or later. I expect instead Value must be 29/08/2024 or later.
Screenshots or Videos

Operating System Version
macOs
Browser
Chrome

Seems like validation messages which includes the date needs to be modified by the next-ui.
The validation messages obtained by the react-aria are created from the browser, hence the custom locale would not work in here. The message will contain the locale of the browser.
I am not sure if there is any workaround for this to get the validation message according to the custom locale.
I am putting in a PR to fix this.

Thanks for the issue. If you'd like to set the validation message using a locale other than the browser's, please handle it using the errorMessage prop. You can refer to the following for more details: https://github.com/nextui-org/nextui/pull/3694#issuecomment-2387218249.


Pyotp Module Error in mod_mfa.py

After stepping through the installation process and install pyotp I receive the below error:
sudo python3.8 Athena.py
Traceback (most recent call last):
File "Athena.py", line 11, in
from mod_mfa import mod_mfa
File "/home/n0ps/Athena/bad/mod_mfa.py", line 4, in
import pyotp
ModuleNotFoundError: No module named 'pyotp'

Appears to have worked though yesterday did not. Thanks for the resolution.

welcome thanks for informing me 🚀


:bug: *: split meta namespace keys correctly

If we encode a key with MetaNamespaceKeyFunc, we must decode it with SplitMetaNamespaceKey, instead of assuming no namespace was encoded.
Signed-off-by: Steve Kuznetsov<EMAIL_ADDRESS>/assign @sttts @ncdc

/retest


ssl-opt.sh: if the server fails, do treat it as a test failure

This used to be the case a long time ago but was accidentally broken.
After investigation (see PR comments), openssl and gnutls servers don't report success if we kill them after one connection. But ssl_server2 does, and that's the important case where we want to detect errors. So this PR checks the return code of ssl_server2 only.
Fix, for ssl-opt.sh only, #4103. Useful for https://github.com/ARMmbed/mbedtls/pull/4104.

@daverodgman Thanks for the investigation. I've force-pushed new commits instead of yours, since based on the results I think we should just test the server exit code for mbedtls.
Do we need to fix something with gnutls-serv priority after all?

@daverodgman It looks like the both Travis and Jenkins are failing after your commit and were passing before it, so there might be an issue with this idea. Since it's quite tangential to the original goal of this PR, would you be OK with removing that commit from this PR and perhaps creating another PR for that change, in order to avoid blocking this one (which in turn is blocking 4104 which is somewhat urgent)?

The CI fully passed previously, and the latest run of the pr-merge job only failed due to timeouts in contacting github, which can be ignored for the purpose of merging this.


Correctly construct LiteralTypes for properties that are "const"

Fixes #558

@all-contributors please add @helt  for code

I am not sure that this is done in "the right way". If there are other things that should be checked, too, please let me know.
If everything is fine, I would be happy to have  a patch release out there asap ;D


Rolling update timeout

The rolling update is currently using a Watch to make sure the pod has been deleted. The watch has no timeout. So if it is for whatever reason started only after the Pod is deleted, it would wait forever. We should probably add some timeout and cancel / restart the rolling update if the Pod is not deleted within the timeout.

Do not add timeout only:

reuse waitUntilReady
make it non-blocking
add deadline which causes error


placeholder typo fixed

Hi there, while looking at the source code I stumbled upon a small typo of placeholder spelling.
Indeed, you write it as palcehoder.
This PR replaces all the palcehoder occurrences with the proper placeholder.

Thanks for integrating this PR :)

@luisDanielRoviraContreras I am not familiar with vordx discord. Indeed, this was my first contribution here :)


Fixing Integ Test Case

Description
Fixing Integ Test case by adding engine in IndexMappings.json
Issues Resolved
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@vibrantvarun did you figured out why we missed this in the first place? It may be an issue with CI or some test doesn't actually call functionality


Addition of liveness probe template parameters in Kafka StatefulSet

What this PR does / why we need it:
Exposes liveness probe parameters for configuration
Which issue this PR fixes
None
Special notes for your reviewer:
None

/ok-to-test

/retest

Looking forward to this getting merged, we need it too.

/lgtm
Thanks for the contribution @dzmuda
cc: @javierholguera good to go now


Additionally trained pretrained network yields bad results.

I'm planning to use this network for other domain and I'm trying to train the network by myself with train.py.
First of all, in order to clarify whether my way of training is correct, I proceeded training starting from pretrained checkpoint of CelebA which you provide in Google Drive, using CelebA dataset.
Here, I expected the results of test.py don't drastically change because I thought the provided
pretrained checkpoint was well converged one.
However, additionally trained network yielded bad results.
I think some parameters need to be tuned but I'm not sure how to fix this.
Dataset:
Acquired from the CelebA homepage (http://mmlab.ie.cuhk.edu.hk/projects/CelebA.html).
dataset/CelebA/Img/img_align_celeba.zip at the GoogleDrive (https://drive.google.com/drive/folders/0B7EVK8r0v71pWEZsZE9oNnFzTm8)
Commands:
$ python train.py --dataset celebahq-256 --data_file ~/projects/resize/celeba_train.txt --gpu_ids 0,1 --pretrain_network 0 --batch_size 8 --load_model_dir ./checkpoints/celebahq-srn-subpixel/
$ python test.py --dataset celebahq-256 --data_file ./imgs/celebahq-256/ --load_model_dir ./checkpoints/20200607-200756_celebahq-256_srn_subpixel_contextual_b8_s256x256_gc64_dc64_rand-mask/ --random_mask 1

Result

The given face extrapolation model is trained on CelebA-HQ (256x256) instead of the original celeba. Using the testing images from celeba as inputs to your trained model on celeba should yield reasonable results.
P.S. The train/test splits of CelebA-HQ are given in train_shuffled.txt and val_shuffled.txt.


https://knot-design.jp/MODALit/ is gone

Hi,
Is there a way to have access to the documentations on https://knot-design.jp/MODALit/ ?
The website seem to be gone.
Thank you!

Yes I confirm, the site has not been reached for some time. Is there a way to view the documentations somewhere?
Please :(

The documentations can be reached here:
https://web.archive.org/web/20180506180943/knot-design.jp/MODALit/


20.11.2023 results

add acrobot agent in design C.1 -> though not working on real hardware due to violation of 2pi limit
add LQR controller parameters for design A.0 and design C.1, the simulation phase depend on these parameters.
modify train_sac, train_sac_noisy, train_sac_unlimited(without state and action scaling)
modify test_sac_swing_up, test_saclqr, saclqr(test in noisy simulation in realistic folder)
modify tmotor_saclqr(in experiment folder)

Hi @Chiniklas thanks for your contribution, I would like to ask you to make the following changes:

The paths where you put the data for the lqr controller parameters are missing the model subfolder. I.e. it should be
data/controller_parameters/design_A.0/model_1.1/pendubot/lqr/*
and
data/controller_parameters/design_C.1/model_1.1/acrobot/lqr/*
Note also that it is design_C.1 in the acrobot case.
There are already LQR parameters for design_C.1/model_1.1 in the repository (acrobot and pendubot). If your parameters differ from them, let me know.
I noticed that the model parameters for design_A.0 which you committed with the LQR parameters do not match any of the existing model parameters. Judging from the lengths (l1=0.2 and l2=0.26) these seem to be parameters for design_C. Do you wish to submit new model parameters? If so please do under the path
"data/system_identification/identified_parameters/design_X.x/model_Y.y"

There are now two sac policies at
data/policies/design_C.0/model_3.0/acrobot/SAC/sac_model.zip
and
data/policies/design_C.1/model_1.0/acrobot/SAC_not_working_on_hardware/best_model.zip
Do you want to have both in the repository?
If yes I would propose to store them under the paths
data/policies/design_C.0/model_3.0/acrobot/SAC/sac_model.zip
and
data/policies/design_C.1/model_1.0/acrobot/SAC/sac_model.zip
You can add a readme file with the information that the policy did not work on the hardware.

In "experiments/tmotors_saclqr.py" you load model parameters from "model_data/model_parameters.yml" but they are not committed. If you want to use model parameters which are not yet in the repository please add them under "data/system_identification/identified_parameters/..."

Please remove the print statements in "src/python/double_pendulum/controller/SAC/SAC_controller.py"

Thanks again :)

Changes have been made regarding each comment, please check.

Thanks, I merged the pull request.


Description and title is not extracted from shared links

Moved here from the main Shaarli repo: https://github.com/shaarli/Shaarli/issues/1653
It seems to be a Material theme issue, working fine with the default theme:

kalvn commented 12 minutes ago

I'm pretty sure this is because metadata is now retrieved asynchronously, therefore using JavaScript which is part of the theme, not the core of Shaarli.
It means I have to handle that part on my own. I'll work on it soon.

Thanks for re-opening!
I just noticed that there's now a setting to stick to the regular sync metadata retrieving.
In your data/config.json.php file you can put enable_async_metadata to false, at least until I adapt the theme.

Well, I indeed have it on true but false is even worse :D

This is what I get after clicking the add link button.
strlen() expects parameter 1 to be string, boolean given
/var/www/shaarli/application/front/controller/admin/ShaarePublishController.php230
#0 /var/www/shaarli/application/front/controller/admin/ShaarePublishController.php(230): strlen(false)
#1 /var/www/shaarli/application/front/controller/admin/ShaarePublishController.php(165): Shaarli\Front\Controller\Admin\ShaarePublishController->buildFormData(Array, true, Object(Slim\Http\Request))
#2 /var/www/shaarli/application/front/controller/admin/ShaarePublishController.php(37): Shaarli\Front\Controller\Admin\ShaarePublishController->displayForm(Array, true, Object(Slim\Http\Request), Object(Slim\Http\Response))
#3 [internal function]: Shaarli\Front\Controller\Admin\ShaarePublishController->displayCreateForm(Object(Slim\Http\Request), Object(Slim\Http\Response), Array)
#4 /var/www/shaarli/vendor/slim/slim/Slim/Handlers/Strategies/RequestResponse.php(40): call_user_func(Array, Object(Slim\Http\Request), Object(Slim\Http\Response), Array)
#5 /var/www/shaarli/vendor/slim/slim/Slim/Route.php(281): Slim\Handlers\Strategies\RequestResponse->__invoke(Array, Object(Slim\Http\Request), Object(Slim\Http\Response), Array)
#6 /var/www/shaarli/application/front/ShaarliMiddleware.php(55): Slim\Route->__invoke(Object(Slim\Http\Request), Object(Slim\Http\Response))
#7 /var/www/shaarli/application/front/ShaarliAdminMiddleware.php(25): Shaarli\Front\ShaarliMiddleware->__invoke(Object(Slim\Http\Request), Object(Slim\Http\Response), Object(Slim\Route))
#8 [internal function]: Shaarli\Front\ShaarliAdminMiddleware->__invoke(Object(Slim\Http\Request), Object(Slim\Http\Response), Object(Slim\Route))
#9 /var/www/shaarli/vendor/slim/slim/Slim/DeferredCallable.php(57): call_user_func_array(Array, Array)
#10 [internal function]: Slim\DeferredCallable->__invoke(Object(Slim\Http\Request), Object(Slim\Http\Response), Object(Slim\Route))
#11 /var/www/shaarli/vendor/slim/slim/Slim/MiddlewareAwareTrait.php(70): call_user_func(Object(Slim\DeferredCallable), Object(Slim\Http\Request), Object(Slim\Http\Response), Object(Slim\Route))
#12 /var/www/shaarli/vendor/slim/slim/Slim/MiddlewareAwareTrait.php(117): Slim\Route->Slim\{closure}(Object(Slim\Http\Request), Object(Slim\Http\Response))
#13 /var/www/shaarli/vendor/slim/slim/Slim/Route.php(268): Slim\Route->callMiddlewareStack(Object(Slim\Http\Request), Object(Slim\Http\Response))
#14 /var/www/shaarli/vendor/slim/slim/Slim/App.php(503): Slim\Route->run(Object(Slim\Http\Request), Object(Slim\Http\Response))
#15 /var/www/shaarli/vendor/slim/slim/Slim/MiddlewareAwareTrait.php(117): Slim\App->__invoke(Object(Slim\Http\Request), Object(Slim\Http\Response))
#16 /var/www/shaarli/vendor/slim/slim/Slim/App.php(392): Slim\App->callMiddlewareStack(Object(Slim\Http\Request), Object(Slim\Http\Response))
#17 /var/www/shaarli/vendor/slim/slim/Slim/App.php(297): Slim\App->process(Object(Slim\Http\Request), Object(Slim\Http\Response))
#18 /var/www/shaarli/index.php(176): Slim\App->run(true)
#19 {main}

Maybe I should reopen that issue for Arthur.

You should be able to use Shaarli's assets/common/js/metadata.js with no or only minor changes if you want to support this feature.

I've rebuilt my Shaarli using the support-v012 branch, and I've seen that there is a new addition to the JS file regarding the metadata retrieval: https://github.com/kalvn/Shaarli-Material/compare/support-v012
However, title and description are still not loaded with "retrieve_description": true, "enable_async_metadata": true.

The last commit should fix this issue.

The last commit should fix this issue.

It works wonderfully, thank you!

It works wonderfully, thank you!


Limit port speed

How can i limit port speed per user?

This is besides the scope of this script, you need to use client-config-dir and other tool (example Linux Traffic Control (TC) to limit the bandwidth to each IP - it's not something directly included in OpenVPN and it's not something this script can handle (nor is what this script is designed for [Simple deployment of OpenVPN]).


Initial Implementation of UUID Custom Type

Effectively, this PR is a wrapper around https://github.com/47degrees/memeid
Not every feature has been imported/wrapped. But, this PR should enable basic usage of UUID V1, V3, V4, and V5. There is an opportunity to extend the functionality to allow for utilizing other objects besides strings for UUID V3 and V5, but that does require some more work as the memeid library relies on an additional custom type Digestible

I notice quite a few of the functions available for the UUID module in Elm is not available here, is that intentional?


Feature Suggestion: Include Alchemy in To-Do List

This is kind of connected to #249 and would indeed work best if there's an inventory system in place.
If any of the materials can be alchemised, include some sort of option to convert that into its equivalent alchemy materials and give a prompt if it is craftable.
E.g.
1 x Ominous Mask [-1] [-5] [-10] [+1] [+5] [+10]
-- ALCHEMY: 3 x Stained Mask [-1] [-5] [-10] [+1] [+5] [+10]
---- ALCHEMY: 9 x Damaged Mask [-1] [-5] [-10] [+1] [+5] [+10]
You could extend that to conversion as well.

If this were to be undertaken, I would suggest utilizing 'Genshin Open Object Description' (GOOD) as the import format. It's already used by Genshin Optimizer, and there are a number of existing tools out there that will automatically scan your client and export the results in GOOD
https://frzyc.github.io/genshin-optimizer/#/scanner

Manual options would be good too - I mainly play on my PS4, so client auto-scans aren't as effective for me.


Can't see an existing table portion

With the following feature:
Feature: billing/index
  As a customer
  I should be able to access the billing section

  Scenario: Billing dashboard access
    Given I am authenticated as "user_default" using password "test"
    And I am on "/billing"
    Then the response status code should be 200
    And I should see the following table portion:
      | Réf       | Payé |
      | FR_SC_001 | oui  |

I got the following error:
$ behat features/billing/index.feature
Feature: billing/index
  As a customer
  I should be able to access the billing section

  Scenario: Billing dashboard access                                 # features/billing/index.feature:5
    Given I am authenticated as "user_default" using password "test" # FeatureAppContext::iAmAuthenticatedAs()
    And I am on "/billing"                                           # FeatureAppContext::visit()
    Then the response status code should be 200                      # FeatureAppContext::assertResponseStatus()
    And I should see the following table portion:                    # Knp\FriendlyContexts\Context\TableContext::iShouldSeeTheFollowingTablePortion()
      | Réf       | Payé |
      | FR_SC_001 | oui  |
      The given array

      | Réf       | Payé |
      | FR_VP_5   | oui  |
      | FR_VU_0   | non  |
      | FR_VP_4   | oui  |
      | FR_VP_1   | oui  |
      | FR_SC_001 | oui  |

      does not contain the following rows

      | Réf       | Payé |
      | FR_SC_001 | oui  |

      The given array

      | Réf | Produit | Date | Confirmé |

      does not contain the following rows

      | Réf       | Payé |
      | FR_SC_001 | oui  |
       (Exception)

--- Failed scenarios:

    features/billing/index.feature:5

1 scenario (1 failed)
4 steps (3 passed, 1 failed)
0m4.36s (99.74Mb)

But according to the first given array, the row should be found. Am I right?
Note: The array also have a "Date" column that I don't want to test on the portion. Maybe the issue is because of this.
EDIT: I also tried with the Date column, this change nothing:
      The given array

      | Réf       | Date          | Payé |
      | FR_VP_5   | 3 mars 2016   | oui  |
      | FR_VU_0   | 15 nov. 2015  | non  |
      | FR_VP_4   | 25 oct. 2014  | oui  |
      | FR_VP_1   | 26 sept. 2014 | oui  |
      | FR_SC_001 | 17 août 2014  | oui  |

      does not contain the following rows

      | Réf       | Date         | Payé |
      | FR_SC_001 | 17 août 2014 | oui  |

I found why: The value is not the first row.
Is that expected?

I have the same problem.
Anyone find a solution?
Is this behavior right?!


Relative paths to folders below code-workspace not preserved on save.

VSCode Version: 1.39.2
OS Version: MacOS 10.14.6 (18G87)
Does this issue occur when all extensions are disabled?: Yes

Steps to Reproduce:

Edit Thing1.code-workpace to include a folder below the current code-workspace(e.g. "../docs")
Click "Save WorkSpace As..." and save to a file named Thing2.code-workpace.

Result: Thing2.code-workpace has its relative path turned into an absolute path.
Thing1.code-workpace:
{
    "folders": [
      {
        "path": "."
      },
      {
        "path": "../docs"
      }
    ], ...

Thing2.code-workpace:
{
    "folders": [
      {
        "path": "."
      },
      {
        "path": "/Users/John/myProject/docs"
      }
    ], ...

The documentation implies that relative paths will be preserved. Nesting shared projects can become very cumbersome if accessing directories below the code-workspace is not well supported.
https://code.visualstudio.com/docs/editor/multi-root-workspaces#_save-workspace-as

The schema of .code-workspace is fairly straightforward. You have an array of folders with either absolute or relative paths. Relative paths are better when you want to share Workspace files.

By any chance, is there any update on this?


fix: func-hook judge TRACE_HOOK_ENABLE env

What this PR does / why we need it:
func-hook judge TRACE_HOOK_ENABLE env
Which issue(s) this PR fixes:
Fixes #
Specified Reviewers:
/assign @sfwn

/approve


SDL2: Fix installation and update library version

While working on my SDL2_image PR, I have noticed that SDL2 installation script had a bug in it.
This PR

Fix the bug
Change the version from 2.0.10 to 2.0.16

I need help with the hashes: I don't know how to generated them properly (it's my first contribution to scoop).

cc @rashil2000.
Following our previous discussion.

/verify


npm ERR! 429 Too Many Requests

npm ERR! 429 Too Many Requests - GET<EMAIL_ADDRESS>We started getting this error. If I try to re-run the job we get same error but for different package/url.
So looks like NPMJS is throttling the connections from GitHub actions?

try using registry https://npm.pkg.github.com or https://registry.yarnpkg.com

I don't believe this is related to the setup-node code here which does the install of node and puts it in the path.

Yes, we can close this. It was that day when whole NPM was down.


Keyboard leaves white frame when app goes to background in iOS

Unable to completely hide keyboard on iOS device. I used FocusDetector package to detect focus and visibility. The keyboard dismissed properly only when switching to other screen but if a textfield is in focus and app goes to background, coming back to app will show white space in place of keyboard.
I tried to explicitly unfocused keyboard onFocusLost or onVisibilityLost functions of FocusDetector by calling this code:
FocusManager.instance.primaryFocus.unfocus();

          FocusScopeNode currentFocus = FocusScope.of(context);

          if (!currentFocus.hasPrimaryFocus) {
            currentFocus.unfocus();
          }

But I think its useless to call this when whole Widget's onFocusLost is called, i.e unfocus is already called on TextField and main widget. Is it the case?
Getting app back to foreground and tapping the input field will show keyboard again but it won't type anything in textfield. Here's console error: [EventDispatcher] Found no UIEvent for backing event of type: 11; contextId: 0xC71503B3
Steps to Reproduce
Its simple as in video.
Expected results:
Keyboard should fully dismiss. It happens even if app is downloaded from TestFlight.
Actual results: Check the video.
Focus Detector
`Widget build(BuildContext context) {
return FocusDetector(
onVisibilityLost: () {
debugPrint('focus: onVisibilityLost');
// FocusManager.instance.primaryFocus.unfocus();
      FocusScopeNode currentFocus = FocusScope.of(context);

      if (!currentFocus.hasPrimaryFocus) {
        currentFocus.unfocus();
      }
    },
    onFocusGained: () {
      debugPrint('focus: onFocusGained');
    },
    onFocusLost: () {
      debugPrint('focus: onFocusLost');
      FocusManager.instance.primaryFocus.unfocus();
      FocusScopeNode currentFocus = FocusScope.of(context);

      if (!currentFocus.hasPrimaryFocus) {
        currentFocus.unfocus();
      }
    },
    onForegroundGained: () {
      debugPrint('focus: onForegroundGained');
    },
    onForegroundLost: () {
      debugPrint('focus: onForegroundLost');
      FocusManager.instance.primaryFocus.unfocus();
    },
    onVisibilityGained: () {
      debugPrint('focus: onVisibilityGained');
    },
    child: SafeArea(
      child: Container(......))'`

Input Field
TextField(                           decoration: InputDecoration(                             icon: Padding(                               padding: EdgeInsets.only(left: 16),                               child: Image.asset(                                 'images/new-assets/search-icon.png',                                 height: 22,                                 color: Colors.grey,                               ),                             ),                             border: InputBorder.none,                             hintText: AppLocalizations.getString('search_here'),                             hintStyle: TextStyle(                                 fontFamily: 'Bolt',                                 color: Theme.of(context).hintColor),                           ),                         )
Please help. Thanks
https://user-images.githubusercontent.com/21374887/218254117-ad744ac7-2784-4f32-8274-21eb48205ebf.mp4

I further checked keyboard state with keyboard_visibility pub and it says keyboard is still visible when app enter foreground again.

call this in applicationWillResignActive function of ios/Runner/AppDelegate.swift resolved the issue.


Installation on WSL2 fails

When I try to install Lingy on WSL2 I get the following error (last lines of the build log):
2023-07-14T09:55:20,29369,Lingy-0.1.18| cp bin/lingy blib/script/lingy
2023-07-14T09:55:20,29369,Lingy-0.1.18| "/home/tekki/perl5/perlbrew/perls/perl-5.38.0/bin/perl" -MExtUtils::MY -e 'MY->fixin(shift)' -- blib/script/lingy
2023-07-14T09:55:20,29369,Lingy-0.1.18| /bin/sh: 1: Syntax error: "(" unexpected
2023-07-14T09:55:20,29369,Lingy-0.1.18| make: *** [Makefile:1075: pure_all] Fehler 2
2023-07-14T09:55:20,29369,Lingy-0.1.18| ! Retrying (you can turn off this behavior by --no-retry)
2023-07-14T09:55:20,29369,Lingy-0.1.18| Executing /usr/bin/make
2023-07-14T09:55:20,29369,Lingy-0.1.18| /bin/sh: 1: Syntax error: "(" unexpected
2023-07-14T09:55:20,29369,Lingy-0.1.18| make: *** [Makefile:1075: pure_all] Fehler 2
2023-07-14T09:55:20,29369,Lingy-0.1.18| Failed to install distribution

Description of the system:
Base OS: Windows 10 + 11
WSL Distribution: Debian Bullseye
Perl Version: 5.38.0 on perlbrew
On a normal installation of Bullseye + perlbrew + 5.38.0 it works fine.
(Btw: this project is great!)

Can you send me more info about make on WSL2? Maybe output of make --version , make --help, man make | tail -n30?
Seems like a aberrant make issue.
Thanks for the report...

Of course I can, but most of it will be in German:
$ which make
/usr/bin/make

$ make --version
GNU Make 4.3
Gebaut für x86_64-pc-linux-gnu
Copyright (C) 1988-2020 Free Software Foundation, Inc.
Lizenz GPLv3+: GNU GPL Version 3 oder später <http://gnu.org/licenses/gpl.html>
Dies ist freie Software: Sie können sie nach Belieben ändern und weiter verteilen.
Soweit es die Gesetze erlauben gibt es KEINE GARANTIE.

$ make --help
Aufruf: make [Optionen] [Ziele] ...
Optionen:
  -b, -m                      Wird aus Kompatibilitätsgründen ignoriert
[...]
  --warn-undefined-variables  Eine Warnung ausgeben, wenn eine undefinierte
                                     Variable referenziert wird.

Diese Programm wurde für x86_64-pc-linux-gnu gebaut
Fehlermeldungen (auf Englisch) an<EMAIL_ADDRESS>senden.

$ man make | tail -n30
       pipe. Once the task is completed, the make process writes a token back to the pipe (and thus,  if  the  tokens
       had  been  exhausted, unblocking the first make process that was waiting to read a token).  Since only N-1 to‐
       kens were written into the pipe, no more than N tasks can be running at any given time.

       If the job to be run is not a sub-make then make will close the jobserver pipe file descriptors before  invok‐
       ing  the commands, so that the command can not interfere with the jobserver, and the command does not find any
       unusual file descriptors.

BUGS
       See the chapter ``Problems and Bugs'' in The GNU Make Manual.

AUTHOR
       This manual page contributed by Dennis Morse of Stanford University.   Further  updates  contributed  by  Mike
       Frysinger.  It has been reworked by Roland McGrath.  Maintained by Paul Smith.

COPYRIGHT
       Copyright © 1992-1993, 1996-2016 Free Software Foundation, Inc.  This file is part of GNU make.

       GNU  Make is free software; you can redistribute it and/or modify it under the terms of the GNU General Public
       License as published by the Free Software Foundation; either version 3 of the License, or (at your option) any
       later version.

       GNU Make is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied
       warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for  more
       details.

       You  should  have  received  a  copy  of  the GNU General Public License along with this program.  If not, see
       http://www.gnu.org/licenses/.

GNU                                                28 February 2016                                           MAKE(1)

It's all identical with my 'normal' Debian machine.
When I clone the repo and call perl/bin/liny directly it seems to work. I made some tests with calls to Mojo::UserAgent and everything looked fine.

I'm attempting to install WSL2 on a Windows 11 VirtualBox VM on my Ubuntu Linux laptop.
Hopefully I can recreate your issue here and fix it.

I'm attempting to install WSL2 on a Windows 11 VirtualBox VM on my Ubuntu Linux laptop.

I wouldn't try that. WSL2 runs on Hyper-V, which is Microsoft's virtualization architecture.
But hey, it's not that important that you have to spend the week end on it. On my Debian machine (and on my Android tablet) it works, which is okay for me for the moment.

OK, that's good advice. Thanks. I don't have a windows machine at the moment.
I have another idea if you are game... You could install tmate and we could pair program on it for a few minutes.
Reach out to me here https://matrix.to/#/@ingy:yaml.io if/when you have time to do this.
I'm glad you like the Lingy project. It's definitely inspiring to hear things like that. :)


Add flags for controlling the memory buffer applied over the maximum value recorded

Is your feature request related to a problem? Please describe.
For larger periods of time that the report is generated for (e.g. last 3 months), if the spikes of the app are rare but significant, the  99th percentile value for memory is naturally lower (since the spikes account for less than 1% of the usage), resulting in memory suggestions that will cause the pod to fail due to an OOMKilled event. In order to avoid this, we could manipulate the memory buffer applied over the maximum value recorded.
Describe the solution you'd like
A dedicated flag or set of flags for controlling the default 15% memory buffer applied to the calculation of the memory request&limits, similar to how you can currently tweak the min cpu/mem:
For memory, we take the maximum value over the past week and add a 15% buffer.
Most helpful flags:
--cpu-min Sets the minimum recommended cpu value in millicores
--mem-min Sets the minimum recommended memory value in MB
--history_duration The duration of the Prometheus history data to use (in hours)
such as:
--mem-buffer Sets the percentage of memory that is added as a buffer over the maximum value from the last 7 days (default period)
Describe alternatives you've considered
At the moment there are no alternatives to tackle this specific scenario
Are you interested in contributing a PR for this?
Yes

Hi, thanks for opening. This shouldn't happen because for memory we're recommending values based on the maximum historical value, not the p99. Is it possible that the app really just had lower values (including the max) in the historical period? If so, you can solve this by increasing the buffer we add to the maximum with the existing flag.
We also have an experimental flag that looks at OOMs and takes them into account for the recommendations. If there were OOMs in the historical period that could be useful for you too.

Hi @aantn, thanks for the clarifying comments! My mistake, the krr simple --help command described more flags than I was aware of:
--memory-buffer-percentage,--memory_buffer_percentage        TEXT  The percentage of added buffer to the peak memory usage for memory recommendation. [default: 15]
And specifically this is the one I needed. Thank you!

@aantn what is the experimental flag you were mentioning and in which version could I start using it?

--use-oomkill-data and --oom-memory-buffer-percentage in version 1.9.0 and above.
They are disabled by default as we have not yet gotten enough user feedback on them. So if you test please share your inputs on:

Did they worked as expected?
Did running KRR with those flags make KRR run more slowly? (How long did it take for KRR to do a full scan of your cluster with and without those flags?)


chore(deps): bump core version to v1.26.0-tm-v0.34.28

Overview

Checklist

[ ] New and updated code has appropriate documentation
[ ] New and updated code has new and/or updated testing
[ ] Required CI checks are passing
[ ] Visual proof for any user facing features like CLI or documentation updates
[ ] Linked issues closed with keywords

Codecov Report

Merging #2183 (49c7709) into main (5b8ec41) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2183   +/-   ##
=======================================
  Coverage   24.47%   24.47%
=======================================
  Files         127      127
  Lines       14311    14311
=======================================
  Hits         3502     3502
  Misses      10449    10449
  Partials      360      360


Critical dependency: require function is used in a way in which dependencies cannot be statically extracted

Bug report
Hi,
I got an error when I try to run webpack and awesome-typescript-loader  (the same issue occurs with ts-loader),  to package a typescript serverless function, with a dependency package named 'imagemin-jpegtran' :

Critical dependency: require function is used in a way in which dependencies cannot be statically extracted

Edit : this error occurs because of bin-wrapper module which is using require('import-lazy')(require);
https://github.com/kevva/bin-wrapper/blob/master/index.js#L5
What is the current behavior?

WARNING in ./node_modules/bin-wrapper/index.js 5:34-41
Critical dependency: require function is used in a way in which dependencies cannot be statically extracted
@ ./node_modules/jpegtran-bin/lib/index.js
@ ./node_modules/jpegtran-bin/index.js
@ ./node_modules/imagemin-jpegtran/index.js
@ ./src/index.ts

If the current behavior is a bug, please provide the steps to reproduce.
package.json
{
  "name": "test-jpegtran-bin",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "dependencies": {
    "imagemin-jpegtran": "^5.0.2"
  },
  "devDependencies": {
    "@types/imagemin-jpegtran": "^5.0.0",
    "@types/node": "^10.11.6",
    "@types/webpack": "^4.4.16",
    "awesome-typescript-loader": "^5.2.1",
    "source-map-loader": "^0.2.4",
    "ts-node": "^7.0.1",
    "typescript": "^3.1.2",
    "webpack": "^4.20.2",
    "webpack-cli": "^3.1.2"
  },
  "scripts": {
    "start": "webpack"
  },
  "author": "",
  "license": "ISC"
}

webpack.config.js
module.exports = {
    mode: 'production',
    entry: "./src/index.ts",
    output: {
        filename: "bundle.js",
        path: __dirname + "/dist"
    },
    devtool: "source-map",
    resolve: {
        extensions: [".ts", ".tsx", ".js", ".json"]
    },
    target: 'node',
    module: {
        rules: [
            { test: /\.tsx?$/, loader: "awesome-typescript-loader" },
        ]
    },
};

tsconfig.json
{
    "compilerOptions": {
        "outDir": "./dist/",
        "sourceMap": true,
        "noImplicitAny": true,
        "module": "commonjs",
        "target": "es5",
        "lib": [
            "es6"
        ]
    },
    "include": [
        "./src/**/*"
    ],
    "exclude": [
        "node_modules",
        "**/*.spec.ts"
    ]
}

src/index.ts
import * as  imageminJpegtran from 'imagemin-jpegtran';
imageminJpegtran();

Other relevant information:
webpack version:  4.20.2
Node.js version: v10.11.0
Operating System: Windows 10

This package is not compatible with in-browser usage. You can't run executables there.

I'm using webpack to package a typescript serverless function, so it's not for "in-browser" usage

Workaround while this is not fixed, if you need to reference require:
const foobarRequire = eval('require'); // trick webpack

Same here, example code:
// Nuxt module
async asyncData () {
	return {
		artists: await loadData<Artist[]>("~/data/artists", "artists")
	};
}

// Another file
export async function loadData<T>(path: string, type: string): Promise<T> {
    const data = require.context(path, false, /\.yml$/);
    return <T><any>await data
        .keys()
        .map((context: any) => ({
            ...data(context),
            key: context.replace("./", "").replace(".yml", "")
        }))
        .map((a: any) => ({ ...a, type: type }));
}

What works for me (but is a little more gross):
// Nuxt Vue class
async asyncData () {
	return {
		artists: await loadData<Artist[]>(
			require.context("~/data/artists", false, /\.yml$/),
			"artists"
		)
	};
}

// Another file
export async function loadData<T>(dataContext: any, type: string): Promise<T> {
    return <T><any>await dataContext
        .keys()
        .map((context: any) => ({
            ...dataContext(context),
            key: context.replace("./", "").replace(".yml", "")
        }))
        .map((a: any) => ({ ...a, type: type }));
}

Being able the do the former would clean things up a bit, but the only option I can find is to rip the require.context out into the Vue class. Ick.

Workaround while this is not fixed, if you need to reference require server-side in a code base that is (also) webpacked:
const foobarRequire = m => eval('require')(m); // trick webpack

I'm curious, why are there so many thumbs down on this comment?

I'm curious, why are there so many thumbs down on this comment?

May be, because the require is generated by the compiler. We cannot edit all the files every time that we compile our ts code.


Example on hillslade version

Hi,
I am having some difficulties how to implement hillslade example. I have a custom theme but when I try to use it resulting output is nothing like what is shown in studio.mapbox.com. Can you help me with this? I have set up map like in the example and have a similar url but the result is almost all white.
Thank you

Hi, thanks for reaching out. If you still want help with this, can you provide an example of what you're trying to do? For example, you could fork this repository and update the example app to show what you're trying to do, then link it here.


The config.json is read multiple times whenever resin-vars is called

Currently we read the config.json file for every variable in https://github.com/resin-os/meta-resin/blob/e4fcc8010beccdeaac468018511848c63809f6fa/meta-resin-common/recipes-support/resin-vars/resin-vars/resin-vars#L49-L58 - it would be much nicer if we only had one read into the file, and only spawned a jq process once

@Page- do you have an approach in mind for how to do this? The ways I can think of seem to be a bit messy and error prone, e.g. splitting on newlines in bash

I don't have a specific approach in mind, but there are some suggestions in https://github.com/stedolan/jq/wiki/Cookbook#extract-data-and-set-shell-variables

Closed by https://github.com/resin-os/meta-resin/pull/759


new release

can we have a new release?

We will soon, if you need a new release because of the file system dependency, you can always override it locally.

You are probably using a very old version.


[T2A2][W15-A3]Sriram Sami

Ready for review.

@frizensami

some good refactoring done here; couple of good catches;
i believe you can do even better than this attempt.
in general, pay more attention to coding standards violation.
some useful ones include checking how conditional statements are written, naming conventions etc.,

Thanks for the comments! Much appreciated.

welcome! your ACK came in late ;-)
On Thu, Sep 8, 2016 at 10:43 PM, Sriram Sami<EMAIL_ADDRESS>wrote:

Thanks for the comments! Much appreciated.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/nus-cs2103-AY1617S1/addressbook-level1/pull/90#issuecomment-245620699,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA-eBgtS21cQpDkQMrd90dQRLUGpUGSfks5qoB72gaJpZM4Jq2rx
.

please close the PR if you haven't done yet.
On Thu, Sep 8, 2016 at 10:43 PM, Sriram Sami<EMAIL_ADDRESS>wrote:

Thanks for the comments! Much appreciated.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/nus-cs2103-AY1617S1/addressbook-level1/pull/90#issuecomment-245620699,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA-eBgtS21cQpDkQMrd90dQRLUGpUGSfks5qoB72gaJpZM4Jq2rx
.

Yep I think it's closed already


TagMap: add shouldUpdateState function

This worked well in the previous deck.gl version. But in the recently released beta version, the tagMap example doesn't call the updateState function when the viewport changes. Adding the shouldUpdateState function fixed the issue though.

@rivulet-zhang Good catch
For performance reasons, in v4.1 we don't "disturb" the layers when only the viewport changed, as most layers don't need to do anything in this case.
And yes, it does mean that the few layers that do calculations in "screen space" do need to override shouldUpdateState
I thought this was mentioned in the upgrade guide but it looks like it isn't, will open a ticket.


check for OFF promo, don't use DO referral code if found

This accompanies uProxy/uproxy-website#146.
If this looks good, next we can add a checkbox to the UI that allows the user to override the promo auto-detection we do here as per @gwpenn.

This change is

Nothing jumps out at me except one little thing - I'm assuming you've tested it so once you're happy, :+1: from me.

If this looks good, next we can add a checkbox to the UI that allows the user to override the promo auto-detection we do here

mocked in https://docs.google.com/presentation/d/1s5xPRRDrmoNNVo1gSrRMBpaxBif2UVV92Yvnp8nv8P0/edit#slide=id.g131a81b40b_4_0

Reviewed 2 of 7 files at r1, 1 of 4 files at r2, 1 of 1 files at r3, 1 of 1 files at r4, 1 of 1 files at r5, 1 of 1 files at r6.
Review status: all files reviewed at latest revision, 11 unresolved discussions, all commit checks successful.

src/chrome/extension/scripts/background.ts, line 63 [r6] (raw file):

      browserApi.bringUproxyToFront();
      sendResponse({ launchedUproxy: true });
    } else if (request.promo) {

Can be removed due to your design switch.

src/firefox/lib/glue.js, line 197 [r1] (raw file):
Previously, jab wrote…
> @jpevarnek When you're ready to end-to-end test the promo changes, maybe we can look at this together.

(Offline discussion: removing support for emitting the event, only checking the url parameter)

src/firefox/lib/glue.js, line 25 [r6] (raw file):

var INSTALL_PAGE_PATH = '/install';
var PROMO_PARAM = 'pr';

Can you remove one of the two blank lines here?

src/firefox/lib/glue.js, line 142 [r6] (raw file):

  /* Allow pages in the addon and uproxy.org to send messages to the UI or the core */
  var contentProxyFile = self.data.url('scripts/content-proxy.js');
  var contentProxyAppliedUrls = [

I don't get exactly what this variable name means reading it without scrolling down to see where it is used.  Maybe something closer to urlsToProxyTo (or any other variable name that makes it more obvious at a quick read)?

src/firefox/lib/glue.js, line 203 [r6] (raw file):

  });

  function matchesContentProxyAppliedUrls(url) {

If we're going to have this be very specific to a global variable, can you place the function closer to the global?  Thanks.

src/generic_ui/scripts/ui.ts, line 328 [r1] (raw file):
Previously, jab wrote…
> done in uproxy/uproxy@880962f, look ok?

(comment below)
For this, I think the event is missing from the BrowserApi interface.  Also, any chance of naming it something more event-y (promoCode(Found|detected) maybe)

src/generic_ui/scripts/ui.ts, line 756 [r6] (raw file):

  }

  public handlePromo = (promo :string) => {

Can you have this be setPromoCode or handlePromoCode?

src/interfaces/uproxy_core_api.ts, line 44 [r6] (raw file):

  enforceProxyServerValidity :boolean;
  validProxyServers :ValidProxyServerIdentity[];
  promo: string;

Can you rename this to promoCode? (I think @trevj also had a comment asking for a comment explaining that, I can't find the comment in reviewable though)

Comments from Reviewable

Review status: all files reviewed at latest revision, 10 unresolved discussions, all commit checks successful.

src/interfaces/uproxy_core_api.ts, line 44 [r6] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> Can you rename this to `promoCode`? (I think @trevj also had a comment asking for a comment explaining that, I can't find the comment in reviewable though)

(ah, sorry, `promoId` from later discussion)

Comments from Reviewable

Review status: all files reviewed at latest revision, 10 unresolved discussions, all commit checks successful.

src/interfaces/uproxy_core_api.ts, line 44 [r6] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> (ah, sorry, `promoId` from later discussion)

(or `activePromoId`)

Comments from Reviewable

Review status: 1 of 7 files reviewed at latest revision, 10 unresolved discussions, some commit checks pending.

src/chrome/extension/scripts/background.ts, line 63 [r6] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> Can be removed due to your design switch.

7c7242d

src/firefox/lib/glue.js, line 25 [r6] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> Can you remove one of the two blank lines here?

7c7242d

src/firefox/lib/glue.js, line 142 [r6] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> I don't get exactly what this variable name means reading it without scrolling down to see where it is used.  Maybe something closer to `urlsToProxyTo` (or any other variable name that makes it more obvious at a quick read)?

7c7242d

src/firefox/lib/glue.js, line 203 [r6] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> If we're going to have this be very specific to a global variable, can you place the function closer to the global?  Thanks.

made independent of global var in 7c7242d

src/generic_core/globals.ts, line 59 [r1] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> Sorry, let me rephrase.
>
>
>
> Why is it that we are saving a semi-random string instead of saving the actual promo code that the users are going to enter? (if we're handing them customized pieces of paper already)

(resolved via in-person discussion)

src/generic_ui/scripts/ui.ts, line 328 [r1] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> (comment below)
>
> For this, I think the event is missing from the `BrowserApi` interface.  Also, any chance of naming it something more event-y (`promoCode(Found|detected)` maybe)

7c7242d

src/generic_ui/scripts/ui.ts, line 756 [r6] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> Can you have this be `setPromoCode` or `handlePromoCode`?

7c7242d

src/interfaces/uproxy_core_api.ts, line 44 [r6] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> (or `activePromoId`)

7c7242d

Comments from Reviewable

Please add the new event to the browser api interface, otherwise :thumbsup:
Previously, jab wrote…
> > If this looks good, next we can add a checkbox to the UI that allows the user to override the promo auto-detection we do here
>
>
>
> mocked in https://docs.google.com/presentation/d/1s5xPRRDrmoNNVo1gSrRMBpaxBif2UVV92Yvnp8nv8P0/edit#slide=id.g131a81b40b_4_0

Reviewed 6 of 6 files at r7, 3 of 3 files at r8.
Review status: all files reviewed at latest revision, 9 unresolved discussions, all commit checks successful.

Comments from Reviewable

(also as noted in person, we need to re-add proxy functionality to Chrome)
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> Please add the new event to the browser api interface, otherwise :thumbsup:

Review status: all files reviewed at latest revision, 9 unresolved discussions, all commit checks successful.

Comments from Reviewable


HTML5 range ctrl

How do I assign a value to this ?
name: 'span', display: 'DimmerRange', type: 'range', value: '90'
The range is generated OK, but does not follow the value assigned

Hi nmisdev,
I checked that the range type column is working properly.
May be you can take a look on my HTML5 Demo.
If you still have problem, please let me know the web browser that you are using and detailed sample code / jsfiddle. Thanks!

All fixed thanks - I had missed the min/max values
Regards

Hi nmisdev,
I checked that the range type column is working properly.
May be you can take a look on my HTML5 Demo https://appendgrid.apphb.com/Demo/Html5.
If you still have problem, please let me know the web browser that you are using and detailed sample code / jsfiddle. Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/hkalbertl/jquery.appendGrid/issues/105#issuecomment-308029703, or mute the thread https://github.com/notifications/unsubscribe-auth/Ab9O_U7UL93lhei1ttQ2HBZSQcks4Z2Xks5sDjhBgaJpZM4N13K8.


spurious failure in ScrollViewPagerTest.Basic

I just got this locally (running on Android):
FAILED:  AllTests.Fuse.Controls.ScrollViewTest.ScrollViewPagerTest.Basic
         Assertion failed in 'Basic', at C:\Users\erik\src\fuselibs\Source\Fuse.Controls.ScrollView\Tests\ScrollViewPager.Test.uno:75
           Expected: 1
           But got : 0

Second run:
FAILED:  AllTests.Fuse.Controls.ScrollViewTest.ScrollViewPagerTest.Basic
         Assertion failed in 'Basic', at C:\Users\erik\src\fuselibs\Source\Fuse.Controls.ScrollView\Tests\ScrollViewPager.Test.uno:58
           Expected: 6
           But got : 3

On the third run it passed.

Sadly seems like the work-around doesn't really work consistently, as I just triggered the issue locally.


KAFKA-3506: Kafka Connect restart APIs

Couple notes on the current patch:

I have not implemented the 'forward' flag as documented on the KIP. The purpose of the flag was to detect when a request loop had been encountered in the restart forwarding. I discussed the problem with @Ishiihara and we feel this scenario is unlikely to be a problem in practice since it requires consecutive rebalances at a very quick rate. We can imagine a request getting "unlucky" once if a rebalance is triggered just after forwarding, but it's hard to imagine multiple times. And if we are not concerned about the degenerate case, then this actually gives the request some fault tolerance since we would otherwise have to surface the routing failure to the user. On the other hand, if we think this is a serious problem, then it would make more sense to have a general solution which can also be applied to requests which are only forwarded to the leader.

The KIP documented returning 409 when there is a conflicting operation in progress (such as another restart or a rebalance). This is actually trickier than it sounds since the rebalance is hidden inside WorkerCoordinator.poll(). We could set a flag in the revocation callback to indicate that the rebalance has begun, but the rebalance might begin immediately after checking it, so there would be no guarantee that the restart didn't get stuck behind a rebalance. For a restart, we would need to track some additional state for each task and we would need the ability to inspect the request queue in DistributedHerder to see if there were any pending restarts for the same task. This is doable, but the cost feels quite high for a questionable capability since the only impact is that concurrent restart requests may cause unneeded restarts. However, if restarting is expensive for some connectors, maybe it does have some value.

@hachikuji Oops, now that I actually read your follow up note, I realize one of my comments was already addressed.

One concern is infinite forwarding loops -- can you get a case where a stale worker A forwards to worker B which it thinks is leader, worker B can also be stale, etc.? I guess in order for this to actually loop you'd probably need some ridiculous number of nodes with stale leadership info and having gone stale at different times?

Has the KIP been updated? I only see a case for 409 if there is an existing restart in progress. Arguably this is a little weird anywhere except for when you need to forward (you can always just use simple locking and restart multiple times to satisfy the request).

Generally the patch looks good; the 202 status codes are now out of date, but we knew some stuff  would need updating after KIP refinements. However, shouldn't need huge changes to get this ready for commit.

LGTM


docs(prisma): incorrect link to the roadmap

Resolves Issue https://github.com/prisma/prisma/issues/24611 . Perhaps there is a roadmap page that encompasses more than just the ORM but if there is I could not find it. I'm happy to update this PR if there is.

Resolved by Prisma team


Missing descriptions

There are several {{Fill Description}} in this article.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b9dec50f-c0fd-2ae2-e8c6-2b7d2b35c3b8
Version Independent ID: 48d543a5-18c5-e0dd-bcd9-86237b283189
Content: Clear-SPMetadataWebServicePartitionData (sharepoint-server)
Content Source: sharepoint/sharepoint-ps/sharepoint-server/Clear-SPMetadataWebServicePartitionData.md
Product: sharepoint-powershell
GitHub Login: @techwriter40
Microsoft Alias: kirks

@officedocsbot assign @yogkumgit

Thanks for reporting @hwkwicre


Preview Component is not available?

I use js type of react.
I tried to use the Preview component of react-pptx, but when I import {Preview} from 'react-pptx' it says it doesn't exist.
Is there something wrong with me?

I find!!
import Preview from "react-pptx/preview";


FEATURE REQUEST: Make Group Balances Visible from Groups List Page

Would be great to be able to see the balances of each group on this page beside the group names, so as to easily compare without needing to enter group to see.

Seems like this would run into a similar concern as https://github.com/scastiel/spliit2/issues/44#issuecomment-1892447951


8413.10 Add connect to existing option for messaging

Shippable/pm#8413
Add a third radio button to the messaging section of the table, called "connect to existing". When this is selected, the user should see:

Prompt for the IP address (same as "install on new node")
Prompt for the password (same as "install on new node" and "single-node install")
Prompt for secure (amqps) or not (amqp)
Prompt to add the ssh keys to that box (same as "install on new node")

When the user clicks save, send this info in the POST to /api/msg.

complete. closing.


Is there a way to handle schema migrations ?

Does mobx-persist handle cases where an outdated schema is stored and needs to be reconciled with a new one? For comparison, in redux-persist there is such a mechanism (see https://github.com/rt2zz/redux-persist#migrations ).
Maybe I missing something about the way MobX + mobx-persist work that makes this case trivial?
Either way it could be useful to many people if it was mentioned in the README file.

I think this is possible by getting the data out of the storage and manipulating it before hydrating.
Basically, if you have some kind of version naming you could add migration functions that checks if the user has data in localstorage. If the new version of the app contains breaking changes, you simply perform those migrations before hydrating.


support resize for LVM

Describe the problem/challenge you have
Support resize for lvm volumes.

@pawanpraka1 -- I would like to work on this issue. If you have any pointers/relevant doc on this one, please point me to that.

@pawanpraka1 -- I would like to work on this issue. If you have any pointers/relevant doc on this one, please point me to that.

@sonasingh46 there is already a PR for this one https://github.com/openebs/lvm-localpv/pull/4.

@sonasingh46 there is already a PR for this one https://github.com/openebs/lvm-localpv/pull/4.

Ok. I was not aware. At least, I can review.

Ok. I was not aware. At least, I can review.


TST: fix for file opening error in fftpack test_import.py

see gh-5694 - test_import would fail to read from io/init.py
on systems with no default encoding specified.

Merging, thanks Derek!

Am sending an identical fix to master in gh-5720.

Thanks; I realised the moment I sent the request I may have created it against the wrong branch!

No worries, no big deal.


Sharing similar effort: algorithms-js

Hi @trekhleb,
This is one amazing project. Thank you for working on it.
I just wanted to quickly share a similar effort I made last year for building a consumable algorithms and data structure library. I did heavily test it. I hope this might help someone.
https://github.com/ManrajGrover/algorithms-js
Maybe, we can link it in README somewhere?

Hi @ManrajGrover
Good job with https://github.com/ManrajGrover/algorithms-js!
Regarding adding the link in README I think you should better create pull-request to the repository that is specialized on that (on collecting links to great projects). I mean this one https://github.com/tayllan/awesome-algorithms. There you may find collection of algorithms related useful links.
The purpose of current repository is a little bit different.
Anyways thank you for your suggestion!


Add unzip in apt package installs on agent and master

Add to common playbook.

https://github.com/rackerlabs/scantron/pull/142


LLaMA Adapter Fails during the inference due to mixed precision weights.

Running the HF LLaMA model with LLaMa Adapter, it works fine during the training. However to load back the PEFT checkpoints and run inference it fails and complains about
File "/home/ubuntu/peft/src/peft/tuners/adaption_prompt.py", line 347, in forward
    scores = torch.matmul(query_states, adapter_k.transpose(2, 3)) / math.sqrt(self.model.head_dim)
RuntimeError: expected scalar type Float but found Half

Repro code
Error Logs
The model weights are all in fp16 and LLaMa Adapter layers in fp32.
I would appreciate any work around/fix.

cc: @younesbelkada , @pacman100

thanks @younesbelkada for the pointer, seems like change the following in LLaMa Adapter can fix the issue.
previous_dtype = query_states.dtype
query_states = query_states.to(torch.float32)

and finally before  the return
output.to(previous_dtype)

Hi @HamidShojanazeri !
Thanks! Does #456 fixes your issue? I did something slightly different that what you have suggested

Yes, thanks Younes for the quick fix.


WIP: enhance(response-cache): Do not touch the schema and respect execution pipeline

Use visitResult from @graphql-tools/utils instead of modifying the schema by wrapping the resolvers. So if an executor doesn't deal with the schema directly, execution hooks will still be able to process the result only with the execution results passed from the execution.
We also no longer need to interact with the context object because we handle execution result after the execution once.
Sorry I forgot to open this PR as draft because it is still WIP.

Need to figure out why this fails;
https://github.com/n1ru4l/envelop/runs/7049628704?check_suite_focus=true#step:9:271

@ardatan Can you have a look at the failing test?

Oh I missed that one. I thought this PR was ready. I'll take a look 👀


Add woodcutting clickboxes

This adds click boxes to trees, similar to the agility plugin. I searched, but couldn't find any references to this being a rejected feature.
I based this off the agility plugin code, so I used the existing copyright and added my name to the new file. (I didn't see how to handle copyright notices in the docs/wiki...)

This will cause heavy performance impacts to most players. The agility plugin fairly aggressively limits the distance to which it'll draw clickboxes out to.
This may be better-suited as a hub plugin?

This will cause heavy performance impacts to most players.

Is there some rule-of-thumb or telemetry on performance for future reference?

The agility plugin fairly aggressively limits the distance to which it'll draw clickboxes out to.

I copied the same distance limiting to this plugin, but wasn't sure why it was used to begin with. :+1:

This may be better-suited as a hub plugin?

Doesn't matter to me either way, but is performance still a concern if this is just off by default?

Seems like a common use case would be to not draw ALL woodcutting clickboxes, but only clickboxes for the specific tier(s) of tree the player wants to target (i.e., at 45 WC, there's no need to show Magic tree clickboxes, and at 95 WC, there's little reason to highlight willow trees). A checklist of which clickboxes to enable would help reduce clutter, which would in turn improve performance and usability.


Could we get nunjucks and nunjucksFilters enabled for rubricPrompt?

I'm crafting a rubricPrompt but except variable expansion, no way to use any high level features of standard prompt, like nunjucks runtime and custom nunjucksFilters based on javascript.
By example, I would like to extract and post-process fields from a JSON output before analyzing them with a custom Model-graded metric.

Oops, looks like "options.transform" could help much.

Let' forget.

That's a good suggestion - I've opened a PR that updates the context part of the transform function to include information about the prompt: https://github.com/promptfoo/promptfoo/pull/512

Good idea! I will do all the stuff at transform level to generate a crafted output. Thx!

Works well, thank you @typpo !


use tidb latest release-branch cache for integration test

replay test ci

https://ci2.pingcap.net/blue/organizations/jenkins/cdc_ghpr_integration_test/detail/cdc_ghpr_integration_test/11343/pipeline


Add files via upload

把我的照片丟到TinEye結果找到不同人，感覺他只要覺得是證件照就會去找"證件照"不管照片裡人是誰
Checks

[ ] Your YAML file has required fields as listed in Specs
[ ] All checks have passed yaml-lint passed
[ ] You agree to contribute your work under MIT license

cool, u r the only one who had tineye returning something


[Changelog] Update for Sprint 113

[skip ci]

@miq-bot add_label documentation

@carbonin as time permits, can you review/merge.


[issue-139] Improve documentation

Please review this major rewrite and restructuring of ./README.md
and provisioners/README.md and provide feedback particularly on
correctness of the information.

Thank you @rsearls - this is, simply put, great.
It'll take some time to review the changes, but such an improvement will add a huge value, and therefore I bound the PR to the release milestone.

/retest

/retest

/retest

Should rebased on main, first.

/retest


hotfix: iOS nav bar safe area

before:

after:

device with no notch unaffected:

hey @kazedayo thanks for the PR but i think it's fixed already (we were just lacking a margin-top !important) https://staging.holodex.net try it out?
I'm somewhat not sure how your PR works as adding padding-top to the #top-bar causes it to shove everything else downwards.

like this is what happens when i add a padding-top in developer tools...

thanks <3


Object.keys shims

I've left out the enumBug existing in early versions of IE8 (I though would be overkill, but you tell me)

:ship:

:ship:

I know this has already merged, but I don't think it should live in dorsal. It should probably just be bundled up with like an es5 shim. We should just make that a dependency of dorsal https://github.com/es-shims/es5-shim.


Structured arguments in logback-spring.xml

How to use structured arguments in logback-spring.xml just like other log back classes like encoder layouts so that my log statements key value works

I don't quite understand what you are asking, but...
If you use the latest logstash-logback-encoder (5.0), then structured arguments are handled by the LogstashEncoder by default.


clear stack trace in fix action

clear stack trace in database when bug is marked as fixed.

done long time ago


D2.2 Library Smart Contract: Implement and write

Solved in https://github.com/soroswap/core/pull/70


reset a couple of versions down from v2.0

For things that we don't yet want to stabilize, but may want to later!

If we're doing that, I'd put network in there as well.

@tomaka network was already at 0.8, but network-gossip wasn't. network-test isn't either.

@pepyakin you maybe want to downgrade something as well?

It would be great not to make session module 2.0 if we want to change the interaction between staking and session 🤔

the branch gui-rh-shaky-decrease-pallet-session decrease session to 0.8, I actually wonder about how much we want to stabilize for pallets. Stabilizing primitives and frame-* is important but maybe pallets themselves should be able to break change more quickly.

@thiolliere if you a certain that we will need to break something for the session module, than please push the downgrade to this branch.

for (non-consensus) pallets i'm happy to stabilise and bump the major version as needed. they're very much downstream on the dependency tree and i see little problem with keeping multiple major versions of them i crates.io.
primitives-* and frame-* are the important ones to stabilise.

if I decrease pallet-session to 0.8 I also need to decrease pallet using it to 0.8 as when I will upgrade session I will need to upgrade those pallets as well. and pallet using session are: grandpa, babe, im-online, authority-discovery, aura.
I'll do my best to commit the API of session as soon as possible

I agree with Gav - The 2.0 release should be stabilizing everything in frame, especially since that's the part of the code that users will reference the most. This PR should be destabilizing core crates whose API we shouldn't worry about breaking for some time to come.
@thiolliere

It would be great not to make session module 2.0 if we want to change the interaction between staking and session 🤔

Do you have a link to a writeup of what this would entail? First I've heard of it (this issue isn't the place to discuss further, though)

if I decrease pallet-session to 0.8 I also need to decrease pallet using it to 0.8 as when I will upgrade session I will need to upgrade those pallets as well

I don't believe this is true as long as the API of the pallets using it is stable.

It would be great not to make session module 2.0 if we want to change the interaction between staking and session thinking

Do you have a link to a writeup of what this would entail? First I've heard of it (this issue isn't the place to discuss further, though)

This comes from https://github.com/paritytech/substrate/issues/4407 especially this paragraph:

The Session module should, at the end of a session, report the accrued points of each validator together with the era number that the validator set is from back up to the Staking module, giving it full information about which validators should be rewarded. (It should explicitly report so that the number of sessions that the validator set lags behind continues to be immaterial for the Staking module.)

But after some talks it seems this information can be carried by the current pallet-session API, but better to be made explicit in API as written in https://github.com/paritytech/substrate/pull/4609

---- service::tests::test_sync stdout ----
70 thread 'service::tests::test_sync' panicked at 'Waited for too long', client/service/test/src/lib.rs:124:14

sp-state-machine and sp-externalities are both downgraded to pre 1.0, yet they're primatives and i would really hope we can stabilise primitives for a while. what's the deal here?

cc @bkchr @pepyakin - those changes appear to be yours.

@gavofyork My motiviation w.r.t sp-state-machine is that I was thinking about shuffling some stuff between sc-executor and sp-state-machine. I am not strong on this. Although I am a little bit worried that it might hinder @cheme 's efforts w.r.t to https://github.com/paritytech/substrate/pull/3263.

sp-state-machine and sp-externalities are both downgraded to pre 1.0, yet they're primitives and i would really hope we can stabilise primitives for a while. what's the deal here?

sp-externalities will require some more love. We can just remove the Externalities trait from sp-core and than we can have a stable release.