fastlane crashlytics group doesn't work with spaces

I'm using fastlane to release app to crashlytics.
lane :dogfooders_release do |options|
<EMAIL_ADDRESS><EMAIL_ADDRESS>app_identifier: 'com.zendrive.ZDDogfood')
	build_app(scheme: "ZDDogfood",
	        workspace: "ZendriveUnifiedDemo.xcworkspace",
			configuration: "Release",
	        include_bitcode: false)
	crashlytics(api_token: "something",
	          build_secret: "also_something",
			  groups: "iOS Dogfood", notifications: "true")
end

However when upload to crashlytics, it's trying to push it to "Dogfood" group rather than "iOS Dogfood". How do I get it to use the complete group name?

Maybe this is relevant here:

Distributing to Groups: When using the groups parameter, it's important to use the group alias names for each group you'd like to distribute to. A group's alias can be found in the web UI. If you're viewing the Beta page, you can open the groups dialog by clicking the 'Manage Groups' button

From https://docs.fastlane.tools/actions/crashlytics/


Fedora packaging

Hello.
I am trying to package Hatch for Fedora and I have some troubles with tests. First (and IMHO the biggest one) is that build of RPM package is done in the restricted environment without access to the internet. But build environment has more restrictions and I don't know Hatch that much that I can fix or skip all of failing tests.
The thing I can do is to check if internet connection is present and if not, skip tests depending on them. What do you think about it?
Could you please help me fix (or find a reason/condition to skip) the rest of failing tests?
Thank you and have a nice day.
Full output: build_tests.txt

@frenzymadness Thanks for working on this! You can ignore any network test e.g. release, (un)install, update, and a few scattered others.
It looks like hatch new/init ... is failing because of a lack of config file.  I've solved almost all test issues.
Changes I have made:

Skip tests which depend on internet connection.
Run tests (I mean hatch test) with -e argument to use pytest/coverage as a module. The reason for this change is the same as with virtualenv because there is no pytest executable in Python 3 only environment.

I'll prepare pull request from them.
I think that the approach in the second change can be somehow automatic or used as a default. I think that is always better to run pytest/virtualenv/coverage etc. as Python modules instead of executables. If you don't want to run this commands as modules then something like if you cannot find pytest executable try to run the same command with python -m pytest could be helpful and fix some future issues. Moreover when you use python -m <module> Python adds CWD to sys.path which could also be useful. But this is up to you, of course.
I am trying to solve one last failing test. test_package in tests/commands/test_test.py is failing because test inside ok package cannot be executed. The reasons are:

We cannot use pytest for reason described earlier
We are in the temporary folder and virtualenv where only ok package is installed without pytest.

A possible solution is to install pytest and coverage to the same virtualenv as ok package but then the test will depend on internet connection and will be skipped during a build of RPM. Wha do you think about it?

I'm going to make running pytest/coverage as modules the default and change the option to mean use Hatch's pytest/coverage. Sound ok?

Sorry, but what does Hatch's pytest/coverage means? Running pytest/coverage as modules by default sounds really good to me! Thanks!
And what do you think about mentioned solution for test_package?

As in the pytest/coverage shipped with Hatch.

Okay, let me know when you commit this change and I'll take a look. I'll also try to build RPM from the latest source and if everything will be ok, I'll create PR with my changes.

@frenzymadness Here it is :) https://github.com/ofek/hatch/commit/e1bfa6f3992b8f130c8c5c680d1ceb24e618d98c

@frenzymadness Also, as I'm utterly unfamiliar with Fedora packaging, what would this PR include exactly?

Here is bug for new package review: https://bugzilla.redhat.com/show_bug.cgi?id=1491456
Thank you for your help.

No no, thank you! Added link https://github.com/ofek/hatch/commit/ba89d02bbcef5f521a4256cff8c4aabf58c5c50a
So how does this work? What is the time frame for a review usually?

And the review is done with a positive outcome. The package is approved!
In bug, there is one suggestion for you:
You should talk with upstream to move tests/ to be a subdirectory of the main module, and keep the tests installed. Users might want to check the installed package too (e.g. to see if everything still works in the installed system).
I'll let you know when the package will be ready in Fedora.

@frenzymadness Wow, that's awesome! You did great work here :)
Is keeping tests outside a deal breaker? I really prefer them outside to reduce download size from PyPI.

No, I don't think that it is a deal breaker. It only means that the tests are not part of RPM so users with hatch from RPM cannot run them. But it is up to you.

Hatch is now available in Fedora rawhide (future Fedora 28) and also requested as an update for Fedora 27 and 26. Packages will be ready to install in approximately one week.

Fantastic, thanks @frenzymadness!!! Now I gotta try Fedora :)

If you do, you can become a tester of Hatch's updates in Fedora and speed up updates of new versions.

Hatch pushed to the Fedora 26 stable package repository.


NPE in SSLContext#clearOptions()

I wanted to see what happens if I attempt to fiddle with the context's OpenSslSessionContext (e.g. setting session tickets) if the SslContext gets free'd or something else as there are no guards against it.
Seems it's NPE'ing which may or may not a good way of handling it.
Expected behavior
Actual behavior
java.lang.NullPointerException: ctx
	at io.netty.internal.tcnative.SSLContext.clearOptions(Native Method)
	at io.netty.handler.ssl.OpenSslSessionContext.setTicketKeys(OpenSslSessionContext.java:109)
	at io.netty.handler.ssl.SessionTicketsTest.npeSetTicketKeys(SessionTicketsTest.java:20)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)

Steps to reproduce
Minimal yet complete reproducer code (or URL to code)
public class SessionTicketsTest {

  @Test
  public void npeSetTicketKeys() throws Exception {
    SslContext sslContext = SslContextBuilder.forClient()
        .sslProvider(SslProvider.OPENSSL_REFCNT)
        .build();

    // Silly me!
    ReferenceCountUtil.release(sslContext);

    // Ooops!
    ((OpenSslSessionContext)sslContext.sessionContext())
        .setTicketKeys(new OpenSslSessionTicketKey(new byte[16], new byte[16], new byte[16]));
  }
}

Netty version
4.1.32-SNAPSHOT
TCN 2.0.19
JVM version (e.g. java -version)
OS version (e.g. uname -a)

@rkapsi yep that is exactly how we wanted to handle it :) So I would say "works as expected"

Closing, works as expected.


TransactionsTable not working

⨯ components\TransactionsTable.tsx (44:23) @ map
⨯ TypeError: Cannot read properties of undefined (reading 'map')    at TransactionsTable (./components/TransactionsTable.tsx:108:40)
at stringify ()
digest: "1968010985"
42 |
43 |

44 |         {transactions.map((t: Transaction) => {
|                       ^
45 |           const status = getTransactionStatus(new Date(t.date))
46 |           const amount = formatAmount(t.amount)
47 |
GET /transaction-history 500 in 11133ms

Hello, we tried to solve the issue.
This is what we did:
Added a null check for the transactions prop in the TransactionsTable component to prevent the 'Cannot read properties of undefined (reading 'map')' error. If transactions is undefined or null, we now render a message indicating no transactions are available.
You can review changes in this commit: https://github.com/jacks-sam1010/adrianhajdin-banking-87/commit/745688f3cd054ce2f77de091186387d2e7c209ae.

[!CAUTION]
Disclaimer: The concept of solution was created by AI and you should never copy paste this code before you check the correctness of generated code. Solution might not be complete, you should use this code as an inspiration only.

Latta AI seeks to solve problems in open source projects as part of its mission to support developers around the world. Learn more about our mission at https://latta.ai/ourmission . If you no longer want Latta AI to attempt solving issues on your repository, you can block this account.

my RecentTransactions is not displaying, and the issue is from TransactionsTable and when i continued, TransactionHistory this error show, how exactly did u fix ours, i went through your codes i couldn't find a fix.... if u don't mind pls explain

@AdugboAghogho
Here is the Problem fixed
Do changes in the function createLinkToken which is present in the file name user.actions.ts.
export const createLinkToken = async (user: User) => {
try {
const tokenParams = {
user: {
client_user_id: user.$id
},
client_name: ${user.firstName} ${user.lastName},
products: ['auth', 'transactions'] as Products[],
language: 'en',
country_codes: ['US'] as CountryCode[],
}
const response = await plaidClient.linkTokenCreate(tokenParams);
return parseStringify({ linkToken: response.data.link_token })
} catch (error) {
console.log(error);
}
}


Update README.md

The README.md has been created while referring to https://opensource.twitter.dev/

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks, but I don't think we really need to duplicate the content from the website itself in the README.  I have gone ahead and updated the README with some basic information, though.


allow latest phpunit

@garak Tnx for this!

Other packages

[ ] https://github.com/SimpleBus/Asynchronous/pull/13
[ ] https://github.com/SimpleBus/AsynchronousBundle/pull/13
[ ] https://github.com/SimpleBus/DoctrineDBALBridge/pull/4
[ ] https://github.com/SimpleBus/DoctrineORMBridge/pull/9
[ ] https://github.com/SimpleBus/JMSSerializerBridge/pull/6
[ ] https://github.com/SimpleBus/JMSSerializerBundleBridge/pull/11
[ ] https://github.com/SimpleBus/RabbitMQBundleBridge/pull/32
[ ] https://github.com/SimpleBus/Serialization/pull/8
[ ] https://github.com/SimpleBus/SimpleBusBernardBundleBridge/pull/11
[ ] https://github.com/SimpleBus/SymfonyBridge/pull/45
[ ] https://github.com/LongRunning/LongRunning/pull/22


Summer Research 2020 - First Pull Request

contains new "test.py" file that runs all tests for both python implementations at once. should be modified whenever a new test is added
helper methods for creating empty arrays, creating empty matrices, reading matrix test files all declared in one file / class "matrix_reader.py"
search implementation and decision implementations now in separate directories

As far as I can tell, the pull request looks good besides the file "python/search/primary_implementation_search.py".  For the time being, I don't think this file should be in master.

Your search code still exists on the branch SummerResearch2020-Search


Help: unhandled exceptions and custom content-type in the reverse bridge.

Title: Help: unhandled exceptions and custom content-type in the reverse bridge.
Description:

In some unhandled exceptions (i.e.: a 503 upstream not available or internal envoy timeout exceptions) reverse bridge cannot support them due to the response content-type header (application/grpc), since we have custom content-type: application/grpc+proto in the reverse bridge configuration (our upstream is responding using this content-type: application/grpc+proto):

Status (StatusCode = Unknown, Detail ="envoy reverse bridge: upstream responded with unsupported content-type application/grpc, status code 200")

Would It be possible to do some workaround to convert that response header into application/grpc+proto; since we have no control over those exceptions (upstream not available or envoy timeout exceptions) and we cannot modify the content-type?
Thanks
Relevant Links:

Related issue: https://github.com/envoyproxy/envoy/issues/10986

Config (envoy as sidecar):
    admin:
      access_log_path: /dev/null
      address:
        socket_address:
          address: <IP_ADDRESS>
          port_value: 9901
    static_resources:
      listeners:
      - address:
          socket_address:
            address: <IP_ADDRESS>
            port_value: 11111
        filter_chains:
        - filters:
          - name: envoy.filters.network.http_connection_manager
            typed_config:
              "@type": type.googleapis.com/envoy.extensions.filters.network.http_connection_manager.v3.HttpConnectionManager
              stream_idle_timeout: 60.00s
              use_remote_address: false
              stat_prefix: ingress_http_reverse
              route_config:
                name: local_route
                virtual_hosts:
                - name: local_service
                  domains: ["*"]
                  routes:
                  - match:
                      prefix: "/"
                    route:
                      cluster: backend
              http_filters:
                - name: envoy.filters.http.grpc_stats
                  typed_config:
                    "@type": type.googleapis.com/envoy.extensions.filters.http.grpc_stats.v3.FilterConfig
                    emit_filter_state: true
                    stats_for_all_methods: true
                - name: envoy.filters.http.grpc_http1_reverse_bridge
                  typed_config:
                    "@type": type.googleapis.com/envoy.extensions.filters.http.grpc_http1_reverse_bridge.v3.FilterConfig
                    content_type: application/grpc+proto
                    withhold_grpc_frames: true
                - name: envoy.filters.http.health_check
                  typed_config:
                    "@type": type.googleapis.com/envoy.extensions.filters.http.health_check.v3.HealthCheck
                    pass_through_mode: true
                - name: envoy.filters.http.router
                  typed_config: {}
          use_proxy_proto: false
      clusters:
      - name: backend
        connect_timeout: 5.00s
        type: LOGICAL_DNS
        dns_lookup_family: V4_ONLY
        lb_policy: ROUND_ROBIN
        http_protocol_options: {}
        load_assignment:
          cluster_name: backend
          endpoints:
            - lb_endpoints:
                - endpoint:
                    address:
                      socket_address:
                        address: localhost
                        port_value: 8888

Logs:
Status(StatusCode=Unknown, Detail="envoy reverse bridge: upstream responded with unsupported content-type application/grpc, status code 200")

Envoy version:

v1.15.0

Yeah I think we could do a better job here. I think there might be an option to extend the local reply mapper to support this use case, but I think some changes would be necessary to make it possible to convert the local reply to application/grpc+proto. Alternatively we could add some functionality to the filter itself so that it would accept multiple upstream content types and convert it into the desired downstream content type.

Alternatively we could add some functionality to the filter itself so that it would accept multiple upstream content types and convert it into the desired downstream content type.
It would be very useful.
I am not an expert in c++ but if I could help with something please let me know, I would be interested in this functionality.

You can use lua plugin as a workaround
         - name: envoy.filters.http.lua             typed_config:               "@type": type.googleapis.com/envoy.extensions.filters.http.lua.v3.Lua               inline_code: |                 function envoy_on_response(response_handle)                   if (response_handle:headers())                   then                     response_handle:headers():replace("content-type", "application/grpc+proto")                   end                 end

The reverse bridge filter's job is to rewrite responses with content type X to content type application/grpc, correct? If so then wouldn't the easiest path forward be to make the filter skip responses that already have content-type: application/grpc? We can flag that for backwards compatibility but that seems like it is what most users would want.


Edit existing issues

Hi all,
Is it possible to edit existing issues in a repo?
I checked the manpage and hub issue --help, but there is no information about editing a existing issue.
I know there are other tools https://github.com/node-gh/gh, https://github.com/stephencelis/ghi, which can do this.
Perhaps these could be merged into hub, instead of replicating their work..

See https://github.com/github/hub/issues/893#issuecomment-368439928


V0.1.8

Remove cloning resource attributes from prior resource (CHEF-3694)
Permanent fix for #8 - remote_file for enterprise edition with authentication
After PR #12 attribute mesh-seed-address-port not needed.
Update cluster.rb recipe for default value and support chef-solo if possible
Restart amc applicatoin if aerospike was restarted
Update tests and rake's tasks

@pioneerit LGTM, Could you please rebase the PR?

Yeap, 5 min

GitHub says there is nothing to rebase. I think because this both version in a row from me

@vkhatri, sorry. It's 8 P.M., a little bit tired.
I've did rebase via CLI.

I've left version bump to the last commit. And as I've started working on a new version again :), I found that I forgot to bump previous.

Newer version PR #23


Delete data model after each cron run

This resolves #1144

Adding cla: yes label, as the PR & commit authors are googlers at the time of this PR was created.


Support Connection through Arrow Flight RPC / ADBC

What is the problem the feature request solves?
Rationale
The Arrow ecosystem lacks standard database interfaces built around Arrow data, especially for efficiently fetching large datasets (i.e. with minimal or no serialization and copying). Without a common API, the end result is a mix of custom protocols (e.g. BigQuery, Snowflake) and adapters (e.g. Turbodbc) scattered across languages. Consumers must laboriously wrap individual systems (as DBI is contemplating and Trino does with connectors).
ADBC aims to provide a minimal database client API standard, based on Arrow, for C, Go, and Java (with bindings for other languages). Applications code to this API standard (in much the same way as they would with JDBC or ODBC), but fetch result sets in Arrow format (e.g. via the C Data Interface). They then link to an implementation of the standard: either directly to a vendor-supplied driver for a particular database, or to a driver manager that abstracts across multiple drivers. Drivers implement the standard using a database-specific API, such as Flight SQL.
Goals

Provide a cross-language, Arrow-based API to standardize how clients submit queries to and fetch Arrow data from databases.
Support both SQL dialects and the emergent Substrait standard.
Support explicitly partitioned/distributed result sets to work better with contemporary distributed systems.
Allow for a variety of implementations to maximize reach.

Describe the potential solution
The implementation could be done in 3 steps approach

Arrow Flight RPC https://arrow.apache.org/docs/format/Flight.html
Arrow Flight SQL https://arrow.apache.org/docs/format/FlightSql.html
ADBC  https://arrow.apache.org/docs/format/ADBC.html

Additional context
No response

@vaibhawvipul as discussed here is the issue

@vaibhawvipul as discussed here is the issue

Thank you.


Custom theme implementation

Issue Type

[x] Question

Specs
What version are you using?
2.19.1
What browser?
Chrome
Expected Behavior
Based on comments from #572 I try to use a custom theme, I expect scoped style should change default theme colors.
Actual Behavior
What actually happened?
Default theme colors are always shown.
Steps to Reproduce the Problem

in mycomponent.vue I create table and define theme:

<template>
    ...
    <vue-good-table
      ...
      style-class="vgt-table condensed bordered"
      theme="my-theme"
    />
    ...
</template

then in the styles part of this file define colors overrides:

<style lang="scss">
    .vgt-table.mytheme {
      $thead-bg-color-1: rgb(0, 0, 0) !default;
      $thead-bg-color-2: rgb(0, 0, 0) !default;
      $chevron-color: lighten($thead-bg-color-1, 10%);
      $text-color: rgb(255, 255, 255) !default;
      $secondary-text-color: #8290A7 !default;
      $border-color: #435169;
      $border-color-td: $border-color;
      $input-border-color: $border-color;
      $table-bg: #324057;
      $highlight-color: #445168;
    }
 </style>

the page has default theme (white colors)

Code
codepen with example

That won't work, you need to import the source Sass files. and apply the variable changes prior to the import.
$thead-bg-color-1: rgb(0, 0, 0) !default;
$thead-bg-color-2: rgb(0, 0, 0) !default;
$chevron-color: lighten($thead-bg-color-1, 10%);
$text-color: rgb(255, 255, 255) !default;
$secondary-text-color: #8290A7 !default;
$border-color: #435169;
$border-color-td: $border-color;
$input-border-color: $border-color;
$table-bg: #324057;
$highlight-color: #445168;

@import "../node_modules/vue-good-table/src/styles/style.scss";

That won't work, you need to import the source Sass files. and apply the variable changes prior to the import.

....

@import "../node_modules/vue-good-table/src/styles/style.scss";

Thank you! It helped.

@TheJaredWilcurt  I seems you know more of this styling stuff.
I'm convertiing my css files for my project to scss.
The reason for this is, is that I was hoping to have more control on how many times I write my vue-good-table stylings.
Right now in each component that I use vgt, I have css ruls like:
/** Use this as table styling for all table layouts */
.vgt-table-styling >>> .vgt-table {
    width: 100%;
    margin-right: auto;
    margin-left: auto;
    text-align: left;
    border-spacing: 0;
}

I tried moving everything to one css file name vgt-tables.css. And import it.
Like:
<style>
@import `../style/vgt-tables.css`;
</style>

But that doesn't seem to work.
This does work though:
<style src='../style/vgt-tables.css`>
</style>

But then you cant place any other css in the style tags.
I also tried importing them as global imports using webpack sass-loader option, additionalData. But effectively that's the same.
Your solution provided here: https://github.com/xaksis/vue-good-table/issues/688#issuecomment-627421263
Only works when you want to override sass variables right? So that isn't usuable for other styling?
I'm just looking at a DRY solution for reusing vgt styling. Any help is welcome.


save a csv of all image names

make csv to save images on openMV

commit 3a03ea4 - made some progress with this. Right now it saves the datetime and "flood" or "no flood" to a .txt file but I'm sure we can easily change that if you prefer .csv. It takes a round or two of the boron running with cellular for this to work properly. So it might just need a bit of cleaning in the future

i have changed this a bit using append (vs open and write).. see #26


feat: Deprecation warning

Description
This PR, helps in Adding Deprecation message to all the Deprected widgets and also adds code to enable showing the message to the Deprecation messages in the future as well, just by adding isDeprecated: true to the widget config
Fixes #12291
Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Manual UI and Cypress Test
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:green_circle: Total coverage has increased
// Code coverage diff between base branch:release and head branch: deprecationWarning

Status
File
% Stmts
% Branch
% Funcs
% Lines

:green_circle:
total
56.46 (0)
37.91 (0.02)
36.13 (0.01)
56.69 (0.01)

:green_circle:
app/client/src/ce/constants/messages.ts
78 (0.06)
100 (0)
34.94 (0.19)
82.16 (0.1)

:sparkles: :new:
app/client/src/components/ads/BannerMessage.tsx
72.73
100
0
72.73

:green_circle:
app/client/src/pages/Editor/utils.ts
25.6 (1.83)
16.85 (2.73)
39.13 (2.77)
23.68 (2.06)

:green_circle:
app/client/src/pages/Editor/PropertyPane/PropertyPaneView.tsx
88.57 (1.9)
71.43 (-2.25)
60 (0)
93.94 (1.08)

:red_circle:
app/client/src/utils/WorkerUtil.ts
88.98 (-0.78)
70.59 (-1.96)
100 (0)
92.38 (-0.95)

:green_circle:
app/client/src/utils/autocomplete/TernServer.ts
52.94 (0.23)
41.67 (0.84)
36.21 (0)
56.99 (0.25)

/ok-to-test sha=8fafbc9

@rahulramesha please add a screenrecording or screenshot of what the UI looks like. Possibly share an app with older widgets, so that we can quickly check it out.

@riodeuno, @aswathkk @vivekverma2312, I have invited you to try the Application, This Application has all the deprecated widgets we are adding this messages to.
https://appsmith-git-deprecationwarning-get-appsmith.vercel.app/app/deprecated-warning-message-test/deprecated-widgets-6274de107c6b4e16b81a24a3/edit

Updated the message to,

/ok-to-test sha=8416300

/ok-to-test sha=c817207

/ok-to-test sha=e3bbb66


sf::String destruction causes crashes with Visual Studio in debug

Subject of the issue
When attempting to create a window passing a string will cause a fatal error with the message 'An invalid parameter was passed to a function that considers invalid parameters fatal'. Caused by urctbased.dll
I did a bit more research and simply creating a string in a local scope and waiting for it to be deleted will cause a 'Stack cookie instrumentation code detected a stack-based buffer overrun'. This is an issue with deleting the basic_string it uses as a backing store.
When passing an empty string (sf::String()) to the RenderWindow constructor it crashes with an Access violation exception instead
Also when trying to debug through visual studio whenever sf::String is referenced via the call stack it states 'Source Not Available' even though I have added the .pdb files to my symbols path.
There is a high chance this is an issue with the Windows CRT.
Environment
Windows 10 64-bit
SFML 2.5.0 64-bit (pre-built and compiled from source both produce this issue)
I also tried building master and the same issue occurred.
cl.exe was used to compile. From Visual Studio 2017 Community (Version 15.5.6), 19.12.25835 is the version number that it gives.
Steps to reproduce
Invalid parameter example:
#include <SFML/Graphics.hpp>

int main()
{
    sf::RenderWindow window(sf::VideoMode(1280, 720), "Minimal, complete and verifiable example");
}

Access violation example:
#include <SFML/Graphics.hpp>

int main()
{
    sf::RenderWindow window(sf::VideoMode(1280, 720), sf::String());
}

Stack cookie buffer overrun:
#include <SFML/Graphics.hpp>

int main()
{
    sf::String test = "Hello World";
}

Command Used to compile:
cl -Zi /EHsc /I\SFML\include Test.cpp /link /LIBPATH:\SFML\lib sfml-graphics-d.lib sfml-window-d.lib sfml-system-d.lib
Expected behavior
The window should be created and the game loop can start
Actual behavior
The program crashes due to ucrtbased.dll with 'An invalid parameter was passed to a function that considers invalid parameters fatal.', 'Stack cookie instrumentation detected a stack-based buffer overrun' or an 'Access violation'

sf::String has a default constructor and the only member it has is a std::basic_string<sf::Uint32> which gets properly destructed by the STL.
Your issue is, that by leaving out any /MT[d] /MD[d] flag, Visual Studio will automatically default to /MD  which is for the release runtime library, while SFML uses /MDd for the debug libraries, causing a conflict between runtime versions and thus a crash. 🙂
Might be better to be more verbose in the build command, but then you at least know what you pick and don't rely on hoping to get the right default picked out by VS. 😉

Ohh, thank you very much for your help. Sorry to both you with an issue that wasn't due to the library

No worries. If you're unsure about something, you might find quicker help on the SFML forum next time. 🙂


Further improve Gradle build, update installation instructions

update installation and building instructions in README.md to include new tasks (like runJosm)
update versions of Gradle plugins nexus-staging and spotless, remove download plugin
automate activation of the plugin and starting of JOSM when running installPlugin
move configuration of JOSM and its manifest to build.gradle (if there's no Ant build, that's the preferred method)
distribute the Atlas dependency inside the release *.jar

much better, thank you! @matthieun it's ok for me 👍


Fix sporadic failure (key error) introduced in last PR

It looks like #55 introduced a sporadic Smarty failure, i.e. a key error is possible in some situations but the tests aren't long enough to always catch it - at least that's my take on the error messages (i.e. see https://travis-ci.org/open-forcefield-group/smarty/jobs/143498708 - failures in two out of three cases).
@bannanc , can you take a look?
Thanks.

@bannanc - just wanted to make sure you saw this?
One suggestion to aid troubleshooting is to make sure to fix the random seed somewhere to allow reproducing the problem.

@davidlmobley I just saw this I'll take a look when I get into the office this morning.

So the tests are still passing locally, but I'm getting a key error when I run with more iterations, I'm investigating now.

@davidlmobley
I think I've found the problem. I was under the impression we were removing "unused" base types from the self.basetype list, but those are in a separate list self.used_basetypes.
This means my code was looking for something like chlorine in the atomlist after it had been removed since it is still in basetypes.
I'm doing some tests to double check, I'll get a pull request up soon.


feature request

Please could I request Field level permission be available in a future release of Serenity?
Also, is it possible for me to get premium support? Happy to pay for it as we use it extensively at our company.

What I'm trying to achieve is either permission a field to certain groups or at the very least hide in server side code.

It might be possible but not a priority, and might affect performance a bit. It can be done by overriding updateInterface client side, and CanSelectField method at repository level, both using Authorization.HasPermission. Also, it is not very clear what "field level permissions" mean. It might mean not being able to retrieve them from server, or just hiding them client side. If they can't be received from server, any method that depends on their value might fail.

For premium support, you might contact me from my e-mail.

sorry to be clear, what I mean by field level permission is to use attributes such as [ModifyPermssion] on fields within XYZRow,cs. Ideally, these would take precedence over class attributes so we can give granualr permissions.
I understand there could be a performance hit due to the additional checks but when security is concerned we don't mind it being a bit slower.
I will email you direct for prem support.


refactor(api): Remove the last of apiv1 source

This is the last of the core apiv1 code; more work can be done removing
handlers for it in e.g. the api implementations.
Risk
Low, this is removing unused code
Closes #6800
Closes #7054

 👀


Add fallback to local execution option

When fallback should be activated?
My vision is when :uploadToRemote task finished with non-zero exit value.
Then it's up to user to configure rsync with some kind of timeout to take control over overhead.

com.instamotor:mirakle:1.2.0-RC-1 is available.
Fallback is disabled by default, to enable use:
mirakle {
    fallback true
}

It's activated when upload is failed for any reason.
Feedback is welcome.


Explain the function sequence st_transform() |> st_buffer() |> st_transform()

At:
https://github.com/mpjashby/crimemapping/blob/db1960b1a7bfd779865aeb1be6618715339730ee/inst/tutorials/02_your_first_crime_map/02.Rmd#L325-L337
the tutorial tells students this will be explained later, but it doesn't appear to be actually explained anywhere. A possible answer is in this answer to a question on Moodle.

This isn't needed in Week 2 following the transition from ggmap() to ggspatial() for base maps, but I will keep this issue open until the end of term in case it is needed elsewhere.

This hasn't been needed anywhere else in the tutorials, so this can be closed with no further action.


AI image generator in python

Describe the project you want to add with tech stack
The user would describe about their required image taken as string input. Based on their description, a bunch of AI-generative images would be generated, which would be then returned to the user. The project would also have a "saving" option to save a particular image locally.
Tech-stack: OpenAI, python
Expected behavior

User provudes a descriptive input about the image.
Based on the user's input, an AI image is created.
 @MohitGupta121

Do not make more than 5 issues at a time


Add grpc option IncludePoolData to QueryUserDeposits

In order to facilitate easier state computation for the duality frontend additional pool data needs to be included in the UserDepositsQuery. See https://github.com/duality-labs/duality-web-app/issues/493 for more details

https://github.com/neutron-org/neutron-tests/actions/runs/7631771236

manually regenerated proto for neutron-sdk here: https://github.com/neutron-org/neutron-sdk/pull/127

https://github.com/neutron-org/neutron-tests/actions/runs/7879623104

NOTE: openapi.yml has been generated with ignite v28.2.0


restrict dependencies by operating system

Feature request
Add the ability to restrict dependencies by operating systems.
Rationale
I couldn't find any docs about how to achive this in poetry, but sometimes there are optional dependencies that may be installed only on specific operating systems, for example uvloop is not windows compatible, so having something like:
uvloop = { version = "^0.9.0", sys_platform != "windows" }

can come handy

I think this is a duplicate of https://github.com/sdispater/poetry/issues/21.

@jacebrowning Yes you are right, I couldn't find the issue. Sorry, I'll close this.


docs(faq): Add "hide results on init"

I suggest adding a FAQ section to the documentation where we could put
some of the most common use cases of instantsearch that are either not
yet into the core, or are not suitable to be put into the core.
I just had a user asking me how to make instantsearch not display the
first results, and only display them on the first keystroke.
I wrote a small explanation, with code example and added it to the
docs.
Let me know what you think

👍

Right now, the documentation page is quite long so what about having a dedicated page for the FAQ?

I'm not against it, but with only two entries this might look weird (this could even got down to one if we create the helper configurator option).
@Shipow any thoughts on a new page?

The configuration widget, needs its space in the FAQ. I think we should answer there all the tricks we've learned so far. Thanks for starting that :)

yes worth a dedicated page I guess. This part can be long let's think when we will have 10 more entries. Right now i would put the content to the bottom of the page.

This is not even a FAQ what you wrote, it's a tutorial/guide and the first of its kind. Let's write more of them in the future and release a guides page.
Also this PR has conflicts for now

@vvo I would say it's a long answer to a frequently asked question :P

Hi I am the user asking for help on the matters. The explanation is good enough for me.
You already have 3 different document pages about instantsearch.js:

the landing
the documentation
the tutorial

Please don't add one more

@ThibautGery This would be on the same website than instantsearch.js, not a new website.
It's hard to combine on the same page both the API documentation and advanced guides. And we do not want to put advanced guides on Algolia.com even if that's currently the case.
At some point instantsearch.js has became a subproduct and thus we need to put most of the documentation on the same website.
Having the instantsearch website with:

homepage
documentation
guides

is a common pattern for tech projects so it should not be an issue? Or would you really prefer to have a single documentation page with everything inlined?

I rebased the branch, but GitHub is slow on catching up.


Add more messaging functionality

Basically make the group message tab look more like the web page. Make it possible to show all members of a groupchat. This concept was brought up during the "Bara SpindelMÄN?" event. Below is a picture of how one would navigate to show the group members.

This isn't passed to the user by the API.
I have a dummy page working though, so this can be finished quickly if the API-problem is solved (read: i can't fix the api thing by myself).


Number input sliders should have typeable number input/output

Users have expressed that using the slider to get a specific number (e.g. a specific grid size value) can be frustrating.
Having a typeable input that has up/down arrows (a HTML <input type="number" />) next to the slider input should fix this issue.

To make the slider more usable, we should also add tick marks important intervals


Make the custom picture selector the default

Context
Currently, when tapping + in the main activity, there are 3 options: camera, system picker, custom picker.
It is almost impossible for new users to figure out whether they should tap system picker or custom picker.
They may try the former, be content with it, and never discover the many advantages of the custom picker.
Solution
When tapping + in the main activity, only camera and the custom picker would be available.
Only the system picker has the option to upload from Google Drive/etc, so some users may prefer it.
So we should:

Add a "Switch to system picker" in the hamburger menu of the custom picker
Add an option "Use custom picker" in the app's settings, enabled by default, just above "Use document based photo picker".

Can I try taking this on? I have a few ideas on making it work!

Can I quickly implement this and get the issue assign to me? Caz seems Maykur did not done this for a month.

@Maykur Anything progress or insights/findings to share? :-)

Warning: Actually recently the custom selector currently has some bugs, so even if this pull request is created, we might not merge it before a few month. So it might be better to go for a different issue. Thanks for your understanding!


Camera cannot receive the vehicle rendered from carla server in synchronization simulation with SUMO

CARLA version: 0.9.14
Platform/OS: windows 11
Problem you have experienced: Camera cannot receive the rendered vehicle from carla server in synchronization simulation with SUMO. I modified the run_synchronizarion.py file to add a camera on intersection, sumo and carla server both operated normally, but the image saved to disk or displayed in real-time in pygame window only contain the background and no vehicle is captured. So what should I do? Could anyone help me ? Thank you in advance! Below image is my case:
carla server:

saved image:

image in pygame:

it is so weird, I print world.get_actors() in the code and it print the current vehicles in carla server, but the images in the camera show no vehicle and pygame tends to freeze.
What you expected to happen:  I hope the camera can show the normal carla server in operating and show the running vehicles.
Steps to reproduce: I just modified the run_synchronization.py in co-simulation folder to add a camera.
Could you help me solve it? Thank you!

I don't have experience with SUMO and CARLA joint simulations. However, based on my past development experience, I can point out a few potential issues:

I looked at the demo Python code for SUMO, which includes the tick() function to trigger CARLA simulation steps. Therefore, if you use the manual_control.py script, it's best to use asynchronous mode.
2.Printing out the frame number is important to ensure that the images you save correspond to the server's rendering results, as the save_to_disk function often runs very slowly.

我没有sumo和CARLA联合仿真的经验。但可以从我过往开发的经验给你提几个有可能存在问题的地方：
1、我看了sumo的demo python代码，里面是包含了触发CARLA仿真步进的tick()函数，所以如果用manual_control.py脚本，最好用异步模式
2、打印出frame帧号很重要，能确定你保存的图片和Server的渲染结果是否对应。因为save_to_disk函数往往运行的很慢。
如果希望有更详细的咨询讨论，可以加我微信:1824729026


Documentation

Let's do it - first we need to setup a documentation framework (I suggest VuePress) and then populate it with all we've done so far and formalise a plan for how to keep it maintained.
To me, the more important documentation is how to use the API rather than how the internals work, but perhaps we need two different sections of the documentation, one for contributing and another for using.

We could use GitHub's Wiki for this, and then GitHub actions to show a message to newcomers to check the Wiki. Keeps it simpler

I started making a wiki https://github.com/open-dm/api/wiki


Use absolute paths to traits in derive macro output

Allows the user to use the macros without needing to import types that are textually unused.

Initially I have thought that both traits will be used(and thus imported) by user anyway. But now I also found that it is not always the case.
Your solution would prevent users from re-importing macro or renaming crate in Cargo.toml. I think it would be better to just rename derive macro to correspond to trait that is directly being implemented in it i.e., Tidable, so both macro and trait are imported by single use statement.


Can not Switch the wallet to  Ganache

Describe the bug
I deployed the market locally and linked it to the locally deployed barge, using ganache for the chain. I have followed the steps in the document to modify the. env file and app.config.js. However, when I logged into the market using the Metamask wallet, it showed that I could only connect to four networks: Ethereum, Polygon, Optimism, and Sepolia. When I switched to any of these four networks, I did not have the corresponding gas payment, which prevented me from using the market.
Here is a screenshot：

@zhanb Has your issue already been escalated?

Please use metamask and add the network there as well

Please use metamask and add the network there as well

Hello, I am using the Metamask wallet. Unfortunately, it still reports the same error and cannot switch to the development environment properly. I switched the market version to the # 1729 merge with commit id: 0a0ddddd7e89944309ee71da57bdd2b071d127. This version of the market can be switched to the development environment, but I found that it is not complete and cannot be downloaded after publishing the data. Therefore, I am still unable to continue my experiment.

@zhanb You're experiencing transcript error. It sounds like your query would be best dealt with by the support team.
I'll have to refer you to the official support live chat with the ticket ID MET07638
Please see the link below to our dedicated support line:
metamask live support
Note; Click on the live chat icon at the bottom corner of the page to initiate chat with a live support agent


check added to forms.py for import/export default setting in settings.py

To save a few clicks every time I export or import a table by setting a default in the project settings.py:
# import/export defaults for django-import-export
IMPORT_DEFAULT = 'xls'  # options: csv, xls, tsv, json, yaml
EXPORT_DEFAULT = 'xls'  # options: csv, xls, xlsx, tsv, ods, json, yaml, html

I'll think about how to test this...

Thanks @johnnycakes79!  I can help come up with a test too if you like!

To test use the ModelAdmin, render the template and look for "xls" option tag to have the "selected" attribute.
Also, can we start putting all options in a dictionary like: IMPORT_EXPORT_OPTIONS = {
'default_import_format': 'xls',
...
}


Fix init command

1.2.3 introduced a bug that prevents init from working properly.
The init command is generally not called in a directory where molecule.yml is present, since it's used to create a new role, so we have to bypass all the logic around loading config files. With the move of provisioners to its own class, one of these checks was missing.

Seems straightforward :+1:


Adding more than one row

Hi,
I am using DataTables editor to add CRUD permissions.
UI looks as shown in attached image, where user selects the CRUD option and then just gives Table name e.g.
when table name is "tester" than four rows are added in permissions table with "tester-create", "tester-read", "tester-update" and "tester-delete" permissions.
I am not able to do that using creating() callback in PermissionsDataTablesEditor class. I tried following code.
public function creating(Model $model, array $data)
{
	if ($data['crud']) {
		$module = $data['table_name'];
		unset($data);
		$data = [];
		foreach (['create', 'read', 'update', 'delete'] as $permissionValue) {
			$data[] = [
				'name'         => $module . '-' . $permissionValue,
				'display_name' => ucfirst($permissionValue) . ' ' . ucfirst($module),
				'description'  => ucfirst($permissionValue) . ' ' . ucfirst($module),
			];
		}
		return $data;
	} else {
		return $data;
	}
}

Problem is, it is using create() and not insert().
Please suggest what is the best way to do it, if code changes are required I will code and submit a PR.

Thanks,
Karmendra

I think you are trying to insert 4 records on permission? If that is the case, I think you need to override the create function and do your custom logic there.
public function create(Request $request)

yep my bad, I used the incorrect callback, like you said correct function to use is create


bug: config() function is run before plugin's scripts in plugin/ dir

Did you check docs and existing issues?

[X] I have read all the lazy.nvim docs
[X] I have searched the existing issues of lazy.nvim
[X] I have searched the exsiting issues of plugins related to this issue

Neovim version (nvim -v)
NVIM v0.9.0-dev-608+geb702273c
Operating system/version
MacOS 13.1
Describe the bug
Not sure exactly when, but recently my config function for vim-dispatch stopped working:
local M = {
  'tpope/vim-dispatch',
  cmd = { 'Dispatch', 'Make', 'Focus', 'Start' },
  dependencies = {
    'radenling/vim-dispatch-neovim',
  },
}

function M.config()
  local handlers = vim.g.dispatch_handlers
  table.insert(handlers, 1, 'neovim')
  vim.g.dispatch_handlers = handlers
end

return M

The config function modifies a list that the main vim-dispatch plugin file sets up. This was working until a recent update. The error is:
Error  12:18:56 notify.error lazy.nvim Failed to run `config` for vim-dispatch

/Users/jdrouhard/.config/nvim/lua/plugins/dispatch.lua:11: bad argument #1 to 'insert' (table expected, got nil)

# stacktrace:
  - ~/.config/nvim/lua/plugins/dispatch.lua:11 _in_ **config**

Steps To Reproduce
Using the attached minimal init.lua, do the following:
$ mkdir repro && cd repro
$ <put repro.lua from issue here>
$ mkdir -p test_plugin/plugin
$ cat > test_plugin/plugin/test.vim <<EOF
if !exists('g:my_list')
  let g:my_list = [
    \ 'item1',
    \ 'item2'
    \ ]
endif
EOF
$ nvim -u repro.lua

After the assert failure you'll see, you can run :lua=vim.g.my_list to see that the list is actually there, but the file wasn't sourced until after the config() function was called.
Expected Behavior
Files in plugins' plugin/ dirs should be sourced before the config() function from the plugin spec is called. This lets a user override things that a plugin sets up.
Repro
-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath, })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
  "folke/tokyonight.nvim",
  -- add any other plugins here
  {
    dir = vim.fn.fnamemodify("./test_plugin", ":p"),
    config = function()
      assert(vim.g.my_list)
    end
  }
}
require("lazy").setup(plugins, {
  root = root .. "/plugins",
})

vim.cmd.colorscheme("tokyonight")
-- add anything else here

This is indeed due to a recent change where we now run config() before /plugin, because not doing it like that broke some plugins.
I do however agree with you that it makes more sense to load a plugin first and only then call setup, so I'll change that again.  Your use-case is a great example.

See also https://github.com/glepnir/dashboard-nvim/issues/222#issuecomment-1372602674

I was simultaneously debugging and typing up my own report about this when I refreshed github and found that this other issue was filed and already fixed.

I do however agree with you that it makes more sense to load a plugin first and only then call setup

This is my opinion as well. Though the docs don't state this explicitly, it seems intuitive that plugin.config() should be allowed to depend on all the APIs (lua and vimscript) provided by the plugin.
Thanks all! :trophy:


Update s3, sdk-core, sqs to 2.17.140

Updates

software.amazon.awssdk:s3
software.amazon.awssdk:sdk-core
software.amazon.awssdk:sqs

from 2.17.121 to 2.17.140.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "software.amazon.awssdk" } ]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #438.


Fix PUT method in CurlBackend

I'm working on a CLI interface with Scala Native that issues request to an HTTP server, with the unfortunate luck that the first use case is a PUT request with body. Using CurlBackend for this scenario leaves the client completely frozen (I guess some C internals that I don't understand).
Looks like it's not working because deprecated flags are being used in calls to libcurl. Following the recommended example in httpput-postfields it's clear that we need to use a custom request.

More information about the deprecation #6186

Thanks!


STOR 437- Create API for vsphere CSI topology configuration

xref https://issues.redhat.com/browse/STOR-437

/assign @JoelSpeed @deads2k

/lgtm

@JoelSpeed PTAL. Dropped omitempty from optional but non-pointer fields and addressed other review comments.

@JoelSpeed yep. The entire PR has been verified using linked changes into vmware-vpshere-csi-driver https://github.com/openshift/vmware-vsphere-csi-driver-operator/pull/107 and it works as expected.

/lgtm

/lgtm

/approve

/docs approved
/px approved

Since this is just an API change.
/label docs-approved
/label px-approved

/label qe-approved


experiment class for kripke

Implements all functionality from existing kripke experiment in new interface

@becker33 I would like to be able to add the following functionality:

[ ] Require a definition of a single node experiment (for CI)
[ ] For weak and strong scaling, I'd like to specify:
./bin/benchpark experiment init --dest=kripke-rocm kripke programming_model=rocm scaling=weak start_proc=4 end_proc=32

I added in the Kripke experiment what I think this could look like.  Realistically, we probably also want to be able to pass in the starting problem size, that way if we need one problem size for one CPU or GPU, and another for another one, we can do this without modifying the experiment file (I would like for the parameters to go into the experiment suite).
I do wonder what can go into the base class to enforce this.  Specifically:

[ ] How to make sure one always has to define a single node experiment
[ ] How to make sure problem size and scaling parameters are specified orthogonally to the cuda/rocm/programming model.
[ ] I wonder if we can do something about the nested return section - this is where the experiment writer currently has to play the "guess the pattern" game currently (and I am not sure we can give them tests to check if they got it right).

@pearce8 do you want those as part of this PR, or should we merge this as-is and do the scaling as part of #375 ?

Just agreed with @rfhaque to merge this, #352 (AMG), and #379 first - he will work on #375 from there.


Lifx syncing stopped

since auto update to version <IP_ADDRESS> the  lifx configuration was removed and it will no longer connect with error

logs around that time
{"Timestamp":"2021-02-16T09:50:14.7473338+11:00","Level":"Error","MessageTemplate":"Error Getting LIFX Lights - MainWindow.Lifx:CheckLIFX_Click Line: 211","Exception":"System.InvalidCastException: Unable to cast object of type 'PresenceLight.Controls.LIFX' to type 'System.Windows.Controls.Button'.\r\n   at PresenceLight.MainWindow.CheckLIFX_Click(Object sender, RoutedEventArgs e) in D:\a\presencelight\presencelight\src\DesktopClient\PresenceLight\MainWindow.Lifx.cs:line 179","Properties":{"SourceContext":"PresenceLight.MainWindow","LineNumber":211,"FilePath":"D:\a\presencelight\presencelight\src\DesktopClient\PresenceLight\MainWindow.Lifx.cs","MemberName":"CheckLIFX_Click","Application":"PresenceLight"}}
{"Timestamp":"2021-02-16T09:50:19.7457678+11:00","Level":"Information","MessageTemplate":"PresenceLight Running in Teams Mode - MainWindow.xaml:InteractWithLights Line: 821","Properties":{"SourceContext":"PresenceLight.MainWindow","LineNumber":821,"FilePath":"D:\a\presencelight\presencelight\src\DesktopClient\PresenceLight\MainWindow.xaml.cs","MemberName":"InteractWithLights","Application":"PresenceLight"}}
{"Timestamp":"2021-02-16T09:50:20.2222122+11:00","Level":"Error","MessageTemplate":"Error Occurred - MainWindow.xaml:SetColor Line: 366","Exception":"System.ArgumentNullException: Selected LIFX Light Not Specified (Parameter 'lightId')\r\n   at PresenceLight.Core.LIFXService.SetColor(String availability, String activity, String lightId, String apiKey) in D:\a\presencelight\presencelight\src\PresenceLight.Core\Lights\LifxServices\LifxService.cs:line 302\r\n   at PresenceLight.Core.LifxServices.SetColorHandler.Handle(SetColorCommand command, CancellationToken cancellationToken) in D:\a\presencelight\presencelight\src\PresenceLight.Core\Lights\LifxServices\SetColor\SetColorHandler.cs:line 26\r\n   at MediatR.Pipeline.RequestExceptionProcessorBehavior2.Handle(TRequest request, CancellationToken cancellationToken, RequestHandlerDelegate1 next)\r\n   at MediatR.Pipeline.RequestExceptionProcessorBehavior2.Handle(TRequest request, CancellationToken cancellationToken, RequestHandlerDelegate1 next)\r\n   at MediatR.Pipeline.RequestExceptionActionProcessorBehavior2.Handle(TRequest request, CancellationToken cancellationToken, RequestHandlerDelegate1 next)\r\n   at MediatR.Pipeline.RequestExceptionActionProcessorBehavior2.Handle(TRequest request, CancellationToken cancellationToken, RequestHandlerDelegate1 next)\r\n   at MediatR.Pipeline.RequestPostProcessorBehavior2.Handle(TRequest request, CancellationToken cancellationToken, RequestHandlerDelegate1 next)\r\n   at MediatR.Pipeline.RequestPreProcessorBehavior2.Handle(TRequest request, CancellationToken cancellationToken, RequestHandlerDelegate1 next)\r\n   at PresenceLight.MainWindow.SetColor(String color, String activity) in D:\a\presencelight\presencelight\src\DesktopClient\PresenceLight\MainWindow.xaml.cs:line 370","Properties":{"SourceContext":"PresenceLight.MainWindow","LineNumber":366,"FilePath":"D:\a\presencelight\presencelight\src\DesktopClient\PresenceLight\MainWindow.xaml.cs","MemberName":"SetColor","Application":"PresenceLight"}}

With latest nightly I can now successfully retrieve the lifx lights and groups - but syncing still not working.

closing and moving work to #273


Edit name fields work, but don't show current name

When logged in as a site admin, the edit name fields for article sections don't display the section's name if that section is a sub-section.

This is resolved now.


feat: new tty logger

As this logger takes more time to fix, I've split it from the original, used a new logger format name tty2 so we can start merging it and improve it from here.

Another tiny iteration on this sometimes this week would be great. Smooth is fast.

This is great to see! Will check it out either today or tomorrow the latest. 👀

Bumping this one to my tomorrow in case @aluzzardi or @samalba don't beat me to it their today.

The idea behind tty2 was to limit the blast radius of something that we don't know how well it works in practice. A new implementation is likely to have "features" (a.k.a. bugs) that we are not aware of until more people try it out. If things look good in 1-2 weeks, we can promote it to the new default. If they don't, we can try to address them and defer that decision until we are more comfortable with the new implementation.

It's mostly a refactor of the original tty + bug fixes along the way. I tried to keep compatibility to the max between both.
The next part of it will be to break compatibility until we get to an even better result than just few bug fixes. That's why @gerhard and I thought about keeping it separated for now.

I am tempted to ship this in the next version as is, ask for feedback from everyone on the team as well as users, and promote to the default TTY logger a week later at the soonest if we don't discover any show-stoppers. Leaving the final call on the above to you @dolanor.

Good to squash & merge from me AFTER the conflicts are resolved and all checks for green!

Ok, will do that

Is there another command that I should run @dolanor which shows the tty2 improvement over tty? Based on the above, I am not seeing any difference.

The simplest is to zoom your term to the max and dagger do -p ci.cue --log-format=tty test and wait for the panic. (if I remember right, it happens when the log group name is too big. So with a big enough plan with a lot of sub action, it can happen even with wide terminals)
There are few others that I don't remember how to trigger. There must be some test case that highlight them in the tty.v2_test.go file (that I should rename BTW)

@dolanor maybe we can learn something from https://github.com/stern/stern
Have you played with it? I don't really have some k8s env to play with to try it out.
From what I read, it would be more like our plain logger that would aggregate logs and color them.
I guess a little bit like what docker-compose did for multiple containers running.
Here, the logic is way more complex than just writing to os.Stdout/Stderr. Which is why it is error prone and full of bugs.

Leaving this with you @dolanor @grouville. Will check again on August 1st.

@gerhard, the odds are starting to show that the CI cache breaks when integration + universe are running in parallel

@gerhard, just rebased. It works. Let's try it for at least a week 😇


Created a date picker modal for Articles page, and a component

Removed non-relevant comments

Reformatted functions related to date picking

Added modal for date picking

Changed language from english to swedish in quasar settings

Created an auth page for future reference

Works well with the other components. Will be subject to change with new Vuex Setup.


v22.6.2 improve shared test env.

Current coverage is 100% (diff: 100%)

Merging #622 into master will not change coverage

@@           master   #622   diff @@
====================================
  Files          29     29
  Lines         439    439
  Methods       111    111
  Messages        0      0
  Branches        0      0
====================================
  Hits          439    439
  Misses          0      0
  Partials        0      0

Powered by Codecov. Last update bd6db0f...ec3d09b


Add Automatic TLS

Move to using traefik for ingress
Use LE ACME to automatically provision TLS
Only use auto DNS on traefik endpoint
Update repo configs to use https now that we route via traefik

This also reduces cost as there is only one public forwarding rule, which has a minimum expense on GCP.


[docs] Add README syntax highlighting

Also improved formatting
Fix #46

That looks much better. I personally don't much like having a blank line after a heading in a README, but since this will be your project that's up to you. Perhaps it works better with your formatting thingy?
Anyway, I don't have anything to add so I'll just merge.


[Feature] Provide timestamps for Shape points in the future (beyond the right-most candle)

Feature Description
I'm trying to draw trend lines that extend into the future, using the segment Shape. However, point[1].timestamp on the segment is undefined. I expect that it's possible to determine the timestamp, even though it extends beyond the chart. I'm looking for a way to do so.
By the way, this library is awesome. Thank you for all of the hard work!
To Do
Provide a value for timestamps even when they are off of the chart area.

I think you can set the timestamp and index values manually. I needed the segment shape to begin before the first data timestamp point. I left the timestamp undefined and assigned the negative index value - it worked.

I needed the actual timestamp values for use externally. I was able to solve the problem by adding a bunch of dummy candles to the right of the chart.

Creating the line does work. But I'm trying to get the timestamp value for the drawn line for external processing.

From: Melitonas @.>
Sent: Thursday, June 30, 2022 2:05:02 AM
To: liihuu/KLineChart @.>
Cc: aelr @.>; Author @.>
Subject: Re: [liihuu/KLineChart] [Feature] Provide timestamps for Shape points in the future (beyond the right-most candle) (Issue #260)
I think you can set the timestamp and index values manually. I needed the segment shape to begin before the first data timestamp point. I left the timestamp undefined and assigned the negative index value - it worked.
—
Reply to this email directly, view it on GitHubhttps://github.com/liihuu/KLineChart/issues/260#issuecomment-1170803344, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAZRH2OOUKYWCUI4X7OZJK3VRU2I5ANCNFSM52IBYNFA.
You are receiving this because you authored the thread.Message ID: @.***>


Code Review

Coverage increased (+0.3%) to 70.588% when pulling 9e9a2d1e402dc8204fd8d5caf193a1c8ba4b1b61 on review into c329917aa904feab5ea354a65691b5ddb8115e24 on master.


Problem with jdtls

Description
I've noticed a glitch with jdtls and nvim-lspconfig, using lazy nvim. When I create a new file, the warnings and errors don't show up as expected. However, when I open an older file, the warnings and errors start working again, even if I'm editing and saving that older file. Also, when I perform code actions, it seems to execute them for an older file, even if it's not currently open. When deleting that file it sticks onto the next file I choose to open, repeating the process for any new files . This appears to happens with only jdtls, pyright having no problems.
[Edit]
After more testing, it does not work for new java files. I created two java files and for the first one it works as intended. But still, for the last one it still doesn't work.
This is the info from LSP:
Language client log: /home/matei/.local/state/nvim/lsp.log
Detected filetype:   java
2 client(s) attached to this buffer:
Client: null-ls (id: 1, bufnr: [6])
filetypes:       lua, luau, java, python
autostart:       false
root directory:  /home/matei
cmd:
Client: jdtls (id: 2, bufnr: [6])
filetypes:       java
autostart:       true
root directory:  Running in single file mode.
cmd:             /home/matei/.local/share/nvim/mason/bin/jdtls -configuration /home/matei/.cache/jdtls/config -data /home/matei/.cache/jdtls/workspace
And this is the configure file for lsps:
return {
	{
		"williamboman/mason.nvim",
		lazy = false,
		config = function()
			require("mason").setup()
			vim.keymap.set("n", "<leader>cm", ":Mason<CR>", {})
		end,
	},
	{
		"williamboman/mason-lspconfig.nvim",
		lazy = false,
		opts = {
			auto_install = true,
		},
	},
	{
		"neovim/nvim-lspconfig",
		config = function()
			local capabilities = require("cmp_nvim_lsp").default_capabilities()

			local lspconfig = require("lspconfig")
			lspconfig.lua_ls.setup({
				capabilities = capabilities,
			})
			lspconfig.clangd.setup({
				capabilities = capabilities,
			})
			-- lspconfig.hls.setup({})
			lspconfig.jsonls.setup({
				capabilities = capabilities,
			})
			lspconfig.jdtls.setup({
				capabilities = capabilities,
			})
			-- lspconfig.tsserver.setup({})
			lspconfig.pyright.setup({
				capabilities = capabilities,
			})
			-- lspconfig.rust_analyzer.setup({})

			-- Look on the github page to configure more keymaps!
			vim.keymap.set("n", "K", vim.lsp.buf.hover, {})
			vim.keymap.set("n", "gd", vim.lsp.buf.definition, {})
			vim.keymap.set({ "n", "v" }, "<leader>ca", vim.lsp.buf.code_action, {})
			vim.keymap.set("n", "<leader>d", vim.diagnostic.open_float)
		end,
	},
	{
		"hinell/lsp-timeout.nvim",
		dependencies = { "neovim/nvim-lspconfig" },
		config = function()
			vim.g.lspTimeoutConfig = {
				stopTimeout = 1000 * 60 * 5, -- ms, timeout before stopping all LSPs
				startTimeout = 1000, -- ms, timeout before restart
				silent = false,
			}
		end,
	},
	{
		"j-hui/fidget.nvim",
		tag = "v1.0.0",
		config = function()
			local fidgetconfig = require("fidget")
			fidgetconfig.setup()
		end,
	},
}

Thanks for your report. The configs in this repo are unsupported and provided only as a starting point. We depend on users (like you) to troubleshoot issues with their specific LSP setups and send improvements.
If you have a usage question, try asking it at:

https://github.com/neovim/neovim/discussions
https://vi.stackexchange.com/

If you found a bug in the core Nvim  vim.lsp module (not part of this repo), the best way to get it fixed is to report to Nvim (not nvim-lspconfig) with:

steps to reproduce it without the particular LSP server and other factors particular to your environment
(optional, but very helpful): by adding a failing test case to lsp_spec.lua, which has code to setup a fake LSP server to simulate various scenarios


[Bug] [UWP] TouchEffect Press/LongPress not working at all

Description
TouchEffect gestures (Press, LongPress) do not work on UWP platform (Tested PC with mouse and keyboard and Simulator with touch gestures). Android and iOS version are working as expected with no issues.
Steps to Reproduce

Create a Blank Xamarin.Forms app.
Attach Xamarin Community Toolkit TouchEffect Commands (Command, LongPressCommand)
Run the app on UWP platform.
Try to perform Press or LongPress gestures on the said UI element.

Expected Behavior
Press and  long press commands would execute normally
Actual Behavior
Nothing happens after pressing or long pressing the UI
Basic Information

Version with issue: 1.2.0
Last known good version: Unknown
IDE: Visual Studio Enterprise 2019 version: 16.11.1
Platform Target Frameworks:

UWP:  19041

Nuget Packages:

Xamarin.Forms: <IP_ADDRESS>3
Xamarin.CommunityToolkit: 1.2.0
Xamarin.Essentials: 1.7.0

Affected Devices: Windows PC, Windows Simulator

Workaround
No workaround.
Reproduction Link
Reproduction sample project:
You can find the Label with text "Learn more at ...", try to press or longpress it.
App28.zip

Add this to UWP project (where XF is initialized)
var assembliesToInclude = new List<Assembly>()
{
    typeof(Xamarin.CommunityToolkit.Effects.TouchEffect).GetTypeInfo().Assembly
};

Xamarin.Forms.Forms.Init(e, assembliesToInclude);

let us know if it doesn't help

@AndreiMisiukevich I've tried your suggestion but it still does nothing, neither on PC nor on Simulator. Android works well, I presume iOS works well too. Update project sample:
App28.zip

@pictos do you have any idea why it doesn't work?
Is that UWP target version issue?

@AndreiMisiukevich @aodpi I'll try on my end and update the issue ASAP

@pictos any update? :)

@AndreiMisiukevich just looked here, and it's a target issue, the sample doesn't change the min version UWP version 2004, after this the touch effect work as expected.

@aodpi 🔝


Make rayon dependency optional?

Is it possible to make rayon-dependency optional? If so, would you consider accepting a PR that does this?

is there a reason for this?

None in particular, just

Fewer dependencies initially when working with faer,
Perhaps an expectation since everyone does it?
For small enough matrices, I'm not sure rayon is even important anyways, even
though this is supposed to be used with big-stuff.

fair enough. i'll make it optional (enabled by default) then

Thanks! Note, you don't have to do everything. I thought I'd ask first. Then maybe attempt to do it. But of course it would be "easiest" if you did it.

merged in #73


Feature/add discovery vm flag

Description
Add vms command which corresponding to endpoint cloud/discovery/vms so that we can do something like pc discovery vms and get a table of all discovered VMs.
Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes if appropriate.
[ ] All new and existing tests passed.

Already merged into https://github.com/PaloAltoNetworks/prismacloud-cli/pull/144


[Draft, don't merge] Fix failing windows

Tests that the fix on transformers fixes the CI here

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

cc @qgallouedec it seems like that fixed it!

Thanks a lot @LysandreJik


Fix entrypoint generation

Q
A

Bug fix?
yes

New feature?
no

BC breaks?
no

Deprecations?
no

Tests pass?
yes

Fixed tickets
n/a

License
MIT

Doc PR
n/a

If the URL contains a port, it was duplicated in _entrypoint.js because host already contains the port (hostname doesn't).
This PR fixes this bug.

It works (it's my case), because the port is included in the host key returned urlapi.


Now I use lm-format-forcer+vllm and it takes 10 seconds to generate a json. This speed is not feasible in my current business. Is there any accelerated solution, such as a paper, plan or pr?

Now I use lm-format-forcer+vllm and it takes 10 seconds to generate a json. This speed is not feasible in my current business. Is there any accelerated solution, such as a paper, plan or pr?

This has been discussed, also in the vLLM repo. There are some profiling efforts going on there, it might have to do with copying logit buffers from CPU to GPU memory. There is no clear cut solution yet, if you want to step in to investigate, we will be very grateful :)

python -> cpp, python is too slow...
multithreading, python gil...
pre-compute accept/reject/uncertain
... many ways to accelerate


fatal: invalid reference for vim-go plugin.

When updating the vim-go plugin I get the following output:
Updated. Elapsed time: 3.141960 sec.
[x]

- Finishing ... Done!
x vim-go:
    fatal: invalid reference: *

This is occurring on my work Win7 machine as well as my home Ubuntu laptop.  The version information below is from the Win7 box.
The vimrc file is the same between the two machines, and the Plug entry is:
Plug 'https://github.com/fatih/vim-go.git', { 'tag': '*', 'do': ':GoInstallBinaries' }

I am guessing this has something to do with how vim-plug recognises tag labels vs wildcards.

VIM - Vi IMproved 8.0 (2016 Sep 12, compiled Jan 11 2017 14:14:13)
MS-Windows 32-bit GUI version
Included patches: 1-172
Compiled by rhardey@FCCSI
Huge version with GUI.  Features included (+) or not (-):
+acl                +cmdline_hist       -dnd                +gettext/dyn        +listcmds           +num64              +reltime            -tag_any_white      +visual
+arabic             +cmdline_info       -ebcdic             -hangul_input       +localmap           -ole                +rightleft          -tcl                +visualextra
+autocmd            +comments           +emacs_tags         +iconv/dyn          +lua/dyn            +packages           +ruby/dyn           -termguicolors      +viminfo
+balloon_eval       +conceal            +eval               +insert_expand      +menu               +path_extra         +scrollbind         -tgetent            +vreplace
+browse             +cryptv             +ex_extra           +job                +mksession          -perl               +signs              -termresponse       +wildignore
++builtin_terms     +cscope             +extra_search       +jumplist           +modify_fname       +persistent_undo    +smartindent        +textobjects        +wildmenu
+byte_offset        +cursorbind         +farsi              +keymap             +mouse              -postscript         +startuptime        +timers             +windows
+channel            +cursorshape        +file_in_path       +lambda             +mouseshape         +printer            +statusline         +title              +writebackup
+cindent            +dialog_con_gui     +find_in_path       +langmap            +multi_byte_ime/dyn +profile            -sun_workshop       +toolbar            -xfontset
+clientserver       +diff               +float              +libcall            +multi_lang         +python/dyn         +syntax             +user_commands      -xim
+clipboard          +digraphs           +folding            +linebreak          -mzscheme           -python3            +tag_binary         +vertsplit          +xpm_w32
+cmdline_compl      -directx            -footer             +lispindent         +netbeans_intg      +quickfix           +tag_old_static     +virtualedit        -xterm_save
   system vimrc file: "$VIM\vimrc"
     user vimrc file: "$HOME\_vimrc"
 2nd user vimrc file: "$HOME\vimfiles\vimrc"
 3rd user vimrc file: "$VIM\_vimrc"
      user exrc file: "$HOME\_exrc"
  2nd user exrc file: "$VIM\_exrc"
  system gvimrc file: "$VIM\gvimrc"
    user gvimrc file: "$HOME\_gvimrc"
2nd user gvimrc file: "$HOME\vimfiles\gvimrc"
3rd user gvimrc file: "$VIM\_gvimrc"
       defaults file: "$VIMRUNTIME\defaults.vim"
    system menu file: "$VIMRUNTIME\menu.vim"
Compilation: gcc -Iproto -DWIN32 -DWINVER=0x0501 -D_WIN32_WINNT=0x0501 -DHAVE_PATHDEF -DFEAT_HUGE -DHAVE_STDINT_H -DHAVE_GETTEXT -DHAVE_LOCALE_H -DDYNAMIC_GETTEXT -DFEAT_CSCOPE -DF
EAT_NETBEANS_INTG -DFEAT_JOB_CHANNEL -DFEAT_GUI_W32 -DFEAT_CLIPBOARD -DFEAT_MBYTE -DFEAT_MBYTE_IME -DDYNAMIC_IME -DDYNAMIC_ICONV -pipe -march=i686 -Wall -IC:/Lua/5.1/include -IC:/L
ua/5.1 -DFEAT_LUA -DDYNAMIC_LUA -DDYNAMIC_LUA_DLL="lua51.dll" -DFEAT_RUBY -I c:/Ruby193/lib/ruby/1.9.1/i386-mingw32 -I c:/Ruby193/include/ruby-1.9.1 -I c:/Ruby193/include/ruby-1.9.
1/i386-mingw32 -DDYNAMIC_RUBY -DDYNAMIC_RUBY_DLL="msvcrt-ruby191.dll" -DDYNAMIC_RUBY_VER=19 -DFEAT_PYTHON -DDYNAMIC_PYTHON -DDYNAMIC_PYTHON_DLL="python27.dll" -DFEAT_XPM_W32 -I xpm
/x86/include -I xpm/x86/../include -O3 -fomit-frame-pointer -freg-struct-return -s
Linking: gcc -Iproto -DWIN32 -DWINVER=0x0501 -D_WIN32_WINNT=0x0501 -DHAVE_PATHDEF -DFEAT_HUGE -DHAVE_STDINT_H -DHAVE_GETTEXT -DHAVE_LOCALE_H -DDYNAMIC_GETTEXT -DFEAT_CSCOPE -DFEAT_
NETBEANS_INTG -DFEAT_JOB_CHANNEL -DFEAT_GUI_W32 -DFEAT_CLIPBOARD -DFEAT_MBYTE -DFEAT_MBYTE_IME -DDYNAMIC_IME -DDYNAMIC_ICONV -pipe -march=i686 -Wall -IC:/Lua/5.1/include -IC:/Lua/5
.1 -DFEAT_LUA -DDYNAMIC_LUA -DDYNAMIC_LUA_DLL="lua51.dll" -DFEAT_RUBY -I c:/Ruby193/lib/ruby/1.9.1/i386-mingw32 -I c:/Ruby193/include/ruby-1.9.1 -I c:/Ruby193/include/ruby-1.9.1/i3
86-mingw32 -DDYNAMIC_RUBY -DDYNAMIC_RUBY_DLL="msvcrt-ruby191.dll" -DDYNAMIC_RUBY_VER=19 -DFEAT_PYTHON -DDYNAMIC_PYTHON -DDYNAMIC_PYTHON_DLL="python27.dll" -DFEAT_XPM_W32 -I xpm/x86
/include -I xpm/x86/../include -O3 -fomit-frame-pointer -freg-struct-return -s -mwindows -o gvim.exe -lkernel32 -luser32 -lgdi32 -ladvapi32 -lcomdlg32 -lcomctl32 -lversion -lwsock3
2 -Lxpm/x86/lib -lXpm -lole32 -luuid

Type:

[x] Bug
[ ] Enhancement
[ ] Feature Request
[ ] Question

OS:

[ ] All/Other
[x] Linux
[ ] OS X
[x] Windows

Vim:

[ ] Terminal Vim
[x] GVim
[ ] Neovim

Which version of git do you have?

It works for me:
Updated. Elapsed time: 8.608440 sec.
[=]

- Finishing ... Done!
- Post-update hook for vim-go ... OK
- Latest tag for * -> v1.11 (vim-go)
- vim-go:  * [new branch]      default-gopath -> origin/default-gopath

I tried again last night on my Ubuntu system and am no longer seeing the problem there (I was sure I had seen it at least once there but can't replicate anymore). It's git version is 2.7.4.  My Windows version was 2.5.x.windows.1 but I have upgraded to 2.12.2.windows.1 today to see if this helped any.  I am still seeing the problem in Windows even after the upgrade though.

Here's the output again:
Updated. Elapsed time: 4.097376 sec.
[x]

- Finishing ... Done!
x vim-go:
    fatal: invalid reference:

I see you have a post-update hook for vim-go kicking off. I'm not seeing that in my system. Is that a feature kicked off by vim-plug?

I had a look at your script and see that the 'post-update hook' is the 'do' command in the plugin statement.  I removed it from my vimrc just to reduce the noise:
Plug 'https://github.com/fatih/vim-go.git', { 'tag': '*' }

Still seeing the same error.

We have test cases for the option, but we regularly run it only for Linux environments on Travis CI. So this could indeed be a bug only happens in Windows, but unfortunately as I'm not a Windows user, I don't have much chance to test it on Windows. I'll definitely check when I get a chance, but any help is appreciated.

This used to work so I'll try and do a bit of regression testing tomorrow.
On Thu, 30 Mar 2017, 8:55 PM Junegunn Choi<EMAIL_ADDRESS>wrote:

We have test cases for the option, but we regularly run it only for Linux
environments on Travis CI. So this could indeed be a bug only happens in
Windows, but unfortunately as I'm not a Windows user, I don't have much
chance to test it on Windows. I'll definitely check when I get a chance,
but any help is appreciated.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/junegunn/vim-plug/issues/610#issuecomment-290609328,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC1nZEMuNWsB5w6Gb2mMUs0pnLk85nD3ks5rrHkwgaJpZM4MsDAK
.

I've been able to track it down to the following line:
      let tags = s:lines(s:system('git tag --list '.string(tag).' --sort -version:refname 2>&1', spec.dir))

If I replace it with the following then it works as expected:
      let tags = s:lines(s:system('git tag --list '.(tag).' --sort -version:refname 2>&1', spec.dir))

It seems DOS cmd doesn't like the quotes, and behaves in the exact opposite manner to bash.  The following returns nothing running within the cmd prompt:
git tag --list '*' --sort -version:refname 2>&1

Running the following returns the sorted tag list as expected (but in Cygwin bash returns nothing):
git tag --list * --sort -version:refname 2>&1

Note, if you use double quotes (") then it works correctly in both CMD and Cygwin bash.  I don't have any actual linux shells available to test it in at the moment but assume they would also work with double quotes.

Thanks for looking into it. I'll see what I can do.

Maybe we should just use shellescape(tag) instead of string(tag). What do you think?

I've just tried it on my Windows machine and it works, so as long as it
also works in Linux I think it's a good idea.
On Mon, 3 Apr 2017, 6:49 AM Junegunn Choi<EMAIL_ADDRESS>wrote:

Maybe we should just use shellescape(tag) instead of string(tag). What do
you think?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/junegunn/vim-plug/issues/610#issuecomment-291148385,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC1nZC-0K8BaqShA3kke9R-WTzZdJvU2ks5rsPj-gaJpZM4MsDAK
.

Pushed the fix. Thanks for the help!


Enums with falsy values are generated incorrectly when using enumsAsTypes

Issue workflow progress
Progress of the issue based on the Contributor Workflow

[x] 1. The issue provides a reproduction available on CodeSandbox
[x] 2. A failing test has been provided
[x] 3. A local solution has been provided
[x] 4. A pull request is pending review (#7900)

Describe the bug

When generating types programmatically for typescript and enumsAsTypes is set, If an enum type has an item which maps to a falsy value (ie 0) then the generated type uses the enum value name instead of the value
To Reproduce
Steps to reproduce the behavior:

My GraphQL schema:

  const stageType = new GraphQLEnumType({
    name: "Stage",
    values: {
      INITIALIZED: {value: 0},
      STARTED: {value: 1},
      FINISHED: {value: 2},
    }
  });

  const queryType = new GraphQLObjectType({
    name: "Query",
    fields: {
      getStage: {
        type: new GraphQLNonNull(stageType),
      }
    }
  });

  const schema = new GraphQLSchema({
    query: queryType
  });

My GraphQL operations:

Not used

Generated programmatically using:

  const output = await codegen({
    schemaAst: schema,
    pluginMap: {
      typescript: typescriptPlugin
    },
    plugins: [
      {
        typescript: {
          enumsAsTypes: true,
        },
      },
    ],
  });

Expected behavior

The generated type for the enum should be:
export type Stage =
  | 0
  | 1
  | 2;

instead of
export type Stage =
  | 'INITIALIZED'
  | 1
  | 2;

Environment:

OS: Linux
NodeJS: v16.15.0

    "@graphql-codegen/core": "2.5.1",
    "@graphql-codegen/typescript": "2.4.11",
    "graphql": "16.5.0"

released https://github.com/dotansimha/graphql-code-generator/releases/tag/%40graphql-codegen%2Fvisitor-plugin-common%402.10.0


Module.exports is undefined. Use exports

Suggestion PR for solving #34

:tada: This PR is included in version 1.4.12 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Clustered Standard Errors in SURE

Is it possible to use a clustered covariance matrix in the SURE model, similar to statsmodels?

I could definitely add it. Not overly difficult, but just takes the time/effort.


Knobs not customizable

Knobs are a great part of this project, but there are limited options to style them. It seems like the only thing we can do is change the background color (which changes the color of the handle, not the color of the background). It would be great if the handle could be resized, a border added, or the actual background color changed. Any plans to add this sort of thing? I might be interested in helping.

Hi, thank you for the feedback. There are some limitations for sure but most parts can be styled, but the current css use makes it difficult to override some values. I'll review the knob view soon and improve the styling situation.


Upload New App button is broken

Clicking doesn't do anything - the following is also shown in the code:

Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-9WgeUf4xpiU3Vl8Qq+DlE3iqqq+sOu4fmB1iIxVU9ps='), or a nonce ('nonce-...') is required to enable inline execution.

fixed in v 0.0.69


Custom firmware shows as official firmware "Dev" channel

With the current channel detection from softwareRevision logic, there is no way to make custom firmware be shown as custom firmware in the overview menu. It will show as Dev <commit> just like official firmware dev branch does, just that it makes no sense for that to happen on custom firmware and would lead to confusing users.
The problematic code is here:
https://github.com/flipperdevices/Flipper-iOS-App/blob/de05ae402270a6d44d85fe1bd9b3ac0c52381267/Flipper/Packages/Core/Sources/Flipper/InstalledFirmware.swift#L21-L38
I can't think of a solution for this based off of just the softwareRevision that would not break official firmware version description. HOWEVER: the Android app shows the correct information always. It is veeery confusing how the 2 apps show different info. Perhaps instead of erroneously using softwareRevision, use the actual version string provided by the device? Just a thought...

Fixed in 1.6.5

Thanks!


[Bug] anyOf does not mark field as required

Hey there,
thanks for this useful lib, we hope to use it in our system very soon, however we ran into this bug:
Given the following schema:
{
  "type": "object",
  "properties": {
    "one": { "type": "number", "minimum": 0, "maximum": 10 },
    "two": { "type": "number", "minimum": 0, "maximum": 10 }
  },
  "anyOf": [
    { "required": ["one"] },
    { "required": ["two"] }
  ],
  "additionalProperties": false
}

When I run this code:
const enjoiSchema = Enjoi.schema(jsonSchema)
console.log(Joi.validate({}, enjoiSchema).error === null)

I'd expect this to be false, however it returns true. If I take the same schema and run it through ajv or jsonschema, I get the expected results, so I don't think there's anything wrong with the schema.
If I write the same schema directly in Joi, like this:
Joi.object()
  .keys({
    one: Joi.number().positive().min(0).max(10),
    two: Joi.number().positive().min(0).max(10)
  })
  .or('one', 'two')

it also works as expected and does not see the empty object as valid.
Thanks again for building Enjoi, we hope to enjoy it very soon ;-)

anyOf and type are two different validation keywords. I don't think you can use two validation keywords alongside in the same schema. At least I don't see that allowed in the spec.
The other option is for anyOf to be a validation keyword for the object type, but that is also not the case sec. 6.5.
I don't think what you described is the expected behavior.

@maldimirov Thanks for looking into this. If I understand you right, you're saying that my schema is not valid per spec?
If so, both jsonschema and ajv behave not according to spec, as I've mentioned above. But it would explain why enjoi can't deal with it.

Yes, I think the schema is not valid. And I don't know why jsonschema and ajv would behave like that. I would speculate that their code does not stop execution on the first occurrence of a validation keyword, but goes on and so executes several validations on the same data because there are several validation keywords in the schema. But even that would not explain this behavior, since from the anyOf spec (sec. 6.7.2):

Each item of the array MUST be a valid JSON Schema

And in your example that is not true.

* This is my understanding of the spec and I may be wrong.
** If I understand correctly your case, you should be able to just use minProperties.


feat: custom dagger config file

This PR adds a custom engine config file for dagger - this doesn't currently replace our existing buildkit engine.toml (that format will still continue to work).
However, our custom engine config should be the preferred way to edit config moving forwards. By detaching ourselves from the upstream buildkit toml config, we can do a few important things that we couldn't easily before:

Keep the config clean and relevant to what we do - we don't need config items for multiple oci/containerd workers, configuring buildkit frontends doesn't make sense, we don't expose the history API, etc.
Add our own config properties for the engine, instead of needing to hack it using lots of environment variables.
Document our own config format! We can ideally document this using JSON schema, and add high-quality docs for this in our admin guide.

TODO:

[x] Initial engine config file format

[x] Custom gc policies that take precedence over the engine's policies
[x] Custom log level config that takes precedence over the engine's policies
[x] Custom security settings (currently only insecureRootCapabilities control)
[ ] Registry settings (needs bikeshedding)

[x] Auto-mount engine config file from .config/dagger into newly created engine
[x] Check the generated json schemas work
[x] Tests
[ ] Add docs into https://docs.dagger.io/configuration/

Bikeshedding topics:

What's the format of this file? I have a slight preference for JSON here, we should be incredibly unimaginative, something that serializes/deserializes easily would be good.
What should the file be called? I've gone with a basic engine.json to start, but that's not a great name.
How will this interact with live configuration using dagger core engine ...? (suggested by @sipsma in https://github.com/dagger/dagger/pull/8725#discussion_r1817275358)

Would changes just persist for the runtime?
Would they write to some long-term volume and get merged with this file?
Would they write-back to the same file?

Do we include an engineVersion here? Might be good for backwards compatibility (we could ignore it for time being, and introduce compat checks later?)

What's the format of this file? I have a slight preference for JSON here, we should be incredibly unimaginative, something that serializes/deserializes easily would be good.

Yep SGTM, will make it easier to interop with our API potentially too.

What should the file be called? I've gone with a basic engine.json to start, but that's not a great name.

Sounds great enough to me 😄

How will this interact with live configuration using dagger core engine ...? (suggested by @sipsma in https://github.com/dagger/dagger/pull/8725#discussion_r1817275358)
Would changes just persist for the runtime?
Would they write to some long-term volume and get merged with this file?
Would they write-back to the same file?

Good questions, but to start I'd probably just make the file configuration be the config when the engine starts and anything applied at runtime is just maintained in memory. Persistence would be potentially useful but can be layered on later once needed.

Do we include an engineVersion here? Might be good for backwards compatibility (we could ignore it for time being, and introduce compat checks later?)

Probably doesn't hurt, informational if nothing else.

engine.json it is :tada: The current behavior is to have the docker driver attempt to read from ~/.config/dagger/engine.json, and mount it into the container - that way, you can configure dagger settings on your machine.
I've ported a few of the most interesting configs:

GC policy.
The insecure capabilities.
Log levels.

However, a couple questions on some of the others:

Registry configs. Buildkit uses this: https://github.com/dagger/buildkit/blob/f69c0798296a13cfe253ac100c83f06eef838388/util/resolver/config/config.go#L3-L10, which is quite verbose. Do we need all of these? Is there a better encoding of these options?
Speaking of certificates - we could have a special location ~/.config/dagger/certificates that we could mount in as well, is that worth considering? https://github.com/dagger/dagger/pull/7067
What about environment variables?

HTTP_PROXY, HTTPS_PROXY, etc from https://github.com/dagger/dagger/pull/7255
_DAGGER_ENGINE_SYSTEMENV_*?

I think the end goal is that we would be able to spin up a dagger engine entirely from this config file, and ideally avoid the need to manually start and manage an engine container out-of-band.

Also wanted to note that this is also interesting in the context of external compute providers #5583 (and other associated issues). Some of these settings might be interesting for remote compute - others don't make sense.
E.g. it doesn't make sense to configure engine logging, security settings or even gc in the context of a remote provider - those would be the responsibility of the provider. But allowing configuration of proxy settings, or registry settings does feel useful - would we maybe want to go the direction of having a single engine config file for all of this, so users could easily take their existing local config to a compute provider?

I think the end goal is that we would be able to spin up a dagger engine entirely from this config file, and ideally avoid the need to manually start and manage an engine container out-of-band.

Love what I'm reading here! I would indeed be awesome to be able to set up proxies and CA certificates this way so we don't have to maintain our own version of the engine.
My ask is make the config location configurable via ENV. Something like DAGGER_ENGINE_CONFIG so we can include this custom config in our daggerverse repo and ask devs to add an env var to use the custom engine.

What about environment variables?
HTTP_PROXY, HTTPS_PROXY, etc from https://github.com/dagger/dagger/pull/7255
DAGGER_ENGINE_SYSTEMENV*?

Yes, at least in my case I need http_proxy. But something that I know I'll need in the future is GOPROXY. So it makes sense to allow configuring arbitrary  env vars.

engine.json it is 🎉 The current behavior is to have the docker driver attempt to read from ~/.config/dagger/engine.json, and mount it into the container - that way, you can configure dagger settings on your machine.

I wonder if it would make sense to also mount the .gitconfig / .ssh/config as part of those configurations too, and maybe some of the .dockerconfig that we use for registry auth (might be time to decouple from that?) ?
Idea: adding a symlink of those into the ~/.config/dagger/ would mount them and make them accessible ?
This could be a nice UX to centrally declare how / when to mount those for https://github.com/dagger/dagger/issues/8809, and https://github.com/dagger/dagger/issues/8766

* Registry configs. Buildkit uses this: [dagger/buildkit@`f69c079`/util/resolver/config/config.go#L3-L10](https://github.com/dagger/buildkit/blob/f69c0798296a13cfe253ac100c83f06eef838388/util/resolver/config/config.go#L3-L10), which is quite verbose. Do we _need_ all of these? Is there a better encoding of these options?

Okay, I have decided that conceptually, these config options don't belong engine wide - I think these should somehow only be session-wide - https://github.com/dagger/dagger/issues/8766#issuecomment-2474813161. I'm still not sure of the exact config mechanism (it might even be something like ~/.config/dagger/client.json, and not module-specific), but the config should ideally not be part of the whole engine config.
A couple reasons why:

Reloading the whole engine on making changes to the registry/proxy/network settings makes it trickier to configure
It means you can't run one engine and have different sets of registry settings (e.g. with a persistent engine in k8s, where you might want to run jobs with different requirements)

Anyways, I think it's ambiguous enough that I don't want to put it in this PR, and might try and do it separately.

This is now ready-for-review - however, the new ProvisionSuite that tests that the new ~/.config/dagger/engine.json is actually applied when creating a new dagger engine fail in CI.
We've previously discussed this in #t-infrastructure before, but we should try and find a longer term solution. If we can't, this suite can be split out and run on the ubuntu-latest runner which doesn't have this issue.

Worked around the ProvisionSuite issue by running it on ubuntu-latest, exactly how we do for helm test today.
https://dagger.cloud/dagger/traces/7a505333193220b491e0d2dd6a919032#28ff250b26c960f1


Create a metrics table for tracking various metrics

Specifically what'd I'd like to know is how many edits are being performed.

The statistics table is doing this sufficiently well with the versions models, so closing.


Add log_errors option to enable/disable logging of errors.

All Submissions:

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?

Hello - first contribution here! 👋
This PR adds the log_errors option, which enables/disables the MiddlewareErrors middleware, controlling whether or not errors are logged when they are encountered
The PR includes:

changes to the README
changes to the implementation
changes to the tests

Motivation:
I'd like to use ruby-openai because it looks like a wonderful, well-maintained project. Unfortunately, the library logs errors when they are encountered. The information logged includes the response body sent over from OpenAI, which might conceivably include part of the prompt or response. In order to avoid leaking that information to the system orchestrating the request, I'd like to disable logging of errors.
Testing:
I've run all the rspec tests locally and tested the log_errors functionality against my own local project to confirm it works and does not impact behavior anywhere else.
Please let me know if there are any changes you'd like to see in the PR before it can be accepted!

Thanks for this! I'd like to make it a bit more powerful - what about instead adding a error_response: param, making that default to the current logic (ie everything in the rescue in MiddlewareErrors), and then people can pass false to that (your usecase), OR their own custom logic as a proc with how to handle Faraday::Errors. So they could make their own logic for logging errors easily.

Thanks for your quick reply!
I agree with your sentiment about not logging errors by default. Didn't want to be too disruptive in my first PR here, but if you approve, then 👍 . Added a commit to change the behavior.
If you are 👍 on this PR, feel free to approve and merge.

Hi @alexrudall - any thoughts on this?

Ping @alexrudall - let me know if there's anything else to do here!

Thanks so much for this @lalunamel and apologies for the delay in response. I consider this a breaking change and will merge it soon in next major release.

Woo!


No websocket disconnection notice

I have an issue where it seems like the websocket connection has dropped for sending SMS messages. If I try to send a message, it just hangs there. In the console logs I can see Session not connected or already in closing state. If I restart, it will work.
Is there a way to automatically reconnect or receive a notice if the websocket connection drops?

Hey @rodangologic - we released a new version last week with some improvements on the reconnection logic.
Can you run the latest version and double check if the issue is solved? Thanks!