Download models with pooch

I've made a start on https://github.com/computational-cell-analytics/micro-sam/issues/36

This PR downloads the models using pooch
We are still using the SHA256 hashes for validation, although at some future point we could use a (non-cryptographic) XXH128 hash as discussed here
I've removed the 'checkpoint' kwarg from get_sam_model. I think it makes more sense to have custom weights of any sort go through the get_custom_sam_model function (I haven't touched this function yet), and also if we download weights from different checkpoints then the hash validation is going to break.
Problem: I can't test a lot of this, because...

we have low test coverage, and
the example scripts often use hard coded paths to locations on Constantin's computer, so I can't run them (eg: examples/annotator_with_custom_model.py)

If/when we go ahead with https://github.com/computational-cell-analytics/micro-sam/pull/276, we'll need to make sure pooch.os_cache is recomputed in the pooch MODELS registry every time, instead of just once when the module is imported.

Overall this is great!

We are still using the SHA256 hashes for validation, although at some future point we could use a (non-cryptographic) XXH128 hash as discussed here

That's good to know, and we can address this in a follow up.

I've removed the 'checkpoint' kwarg from get_sam_model. I think it makes more sense to have custom weights of any sort go through the get_custom_sam_model function (I haven't touched this function yet), and also if we download weights from different checkpoints then the hash validation is going to break.

I think that makes sense. I need to think about this a bit more because get_custom_sam_model currently also supports other kinds of weights. I will read this more carefully later and follow up.

Problem: I can't test a lot of this, because...
* we have low test coverage, and

* the example scripts often use hard coded paths to locations on Constantin's computer, so I can't run them (eg: `examples/annotator_with_custom_model.py`)

Regarding test coverage: we should probably add some more unit-test for the weights, I will think about it.
Regarding example scripts: good point. I will update those later and remove as much hard-coded paths as possible.

Hi @GenevieveBuckley ,
I had some time to look into this now:
get_sam_model
I think we should keep the (optional) checkpoint_path argument there. Mixing this up with get_custom_sam_model would be confusing. To clarify this:

get_sam_model loads a model from weights stored in the default format. These can come from two sources: either from weights that are available online (either the original SAM weights or our fine-tuned models) and that we have registered. Or they can be loaded from a local filepath that is specified via checkpoint_path.
get_custom_sam_model loads a model from a training checkpoint from our finetuning code. This function is not very relevant for most users, but is important for us to easily evaluate the finetuned models without having to convert them to the default format (which is done by export_custom_sam_model)

So these two functions do something conceptually different, and it would also complicate the implementation if get_custom_sam_model would accept both types of weight files, because we would then need to find out which of the two formats it is before loading the model.

and also if we download weights from different checkpoints then the hash validation is going to break.

We don't want to support downloading weights from arbitrary locations, but only for known models (either original SAM or our finetuned ones). So I don't really see any problems with hash validation here.
(If a user wants to use some other model available online they can download it themselves and use the checkpoint_path argument).
I hope that makes sense to you @GenevieveBuckley.
All of this should probably be documented better, I can follow up with a PR to improve the docstrings after we finish this one.
test coverage and example scripts

I have updated the example scripts so that we use get_cache_directory in there, see 1c79323
I have added more tests to extend the coverage for loading models in #280. I will wait for your review before merging since I have written the test for get_sam_model according to the current logic.

Hi @GenevieveBuckley,
I have merged #280 now to increase the test coverage. Most of the changes here should be covered by tests now, so I think you can continue here.
Let me know if something is still unclear with respect to get_sam_model vs. get_custom_sam_model or if there is some problem in resolving the merge conflicts.

Thanks @GenevieveBuckley! This cleans up things significantly and I hope now the usage of the get_sam_model functions is much clearer.


Improve documentation of internals of bounded implementation

see also https://github.com/smol-rs/concurrent-queue/pull/58#discussion_r1536655857 and a few related comments.
The logic in large parts of the bounded implementation is somewhat non-obvious, and partially stems from other code bases, so it might be a good idea to write down how it works, and that it works correctly, or find a document that already properly does that and link to it. (ad the comments that already exist partially duplicate each other, not necessarily adding to understanding of how all the components interact)

This post by stjepang might be helpful. I'm relatively sure that the core algorithm hasn't changed much since then.
cc https://github.com/smol-rs/smol/pull/302

I'm aware of that document (at least, I've read it in the past), but it doesn't really document how the book-keeping lines up (e.g. slot, tail, lap), and how/when these are incremented, what the intended flow is (in a blocking case, and a "channel filled enough that no blocking needs to happen" case), what edge cases might exist.

The docstring of one_lap sounds like one_lap is actually a constant, and indeed, it is not modified once a bounded channel is created, and it directly depends upon another instance variable mark_bit, so why is it even stored at all? (perf reasons?)
one_lap == mark_bit << 1, basically (and prevented from overflowing in release mode by the allocation above, which would fail)

@taiki-e might be more familiar with the implementation of these channels


sfdx force:org:create fails on converting circular structure to JSON

Summary
sfdx force:org:create fails on converting circular structure to JSON. This fails when default Devhub username is set and SFDX_LOG_LEVEL variable is provided. It crashes even without any parameters to sfdx force:org:create.
Steps To Reproduce:

setup default Devhub username with any command e.g.: sfdx auth sfdxurl store -f auth.txt -a prod -d  (note option -d)
issue the command SFDX_LOG_LEVEL=debug sfdx force:org:create

Expected result
Regular message about lacking params of  force:org:create command.
Actual result
an error:
TypeError: Converting circular structure to JSON
    --> starting at object with constructor 'Timeout'
    |     property '_idlePrev' -> object with constructor 'TimersList'
    --- property '_idleNext' closes the circle
    at JSON.stringify (<anonymous>)
    at /Users/pawel/.nvm/versions/node/v18.14.0/lib/node_modules/sfdx-cli/node_modules/@salesforce/core/lib/logger.js:702:31
    at Array.map (<anonymous>)
    at filterSecrets (/Users/pawel/.nvm/versions/node/v18.14.0/lib/node_modules/sfdx-cli/node_modules/@salesforce/core/lib/logger.js:691:41)
    at /Users/pawel/.nvm/versions/node/v18.14.0/lib/node_modules/sfdx-cli/node_modules/@salesforce/core/lib/logger.js:142:37
    at /Users/pawel/.nvm/versions/node/v18.14.0/lib/node_modules/sfdx-cli/node_modules/@salesforce/core/lib/logger.js:617:61
    at Array.forEach (<anonymous>)
    at Logger.applyFilters (/Users/pawel/.nvm/versions/node/v18.14.0/lib/node_modules/sfdx-cli/node_modules/@salesforce/core/lib/logger.js:617:33)
    at Logger.debug (/Users/pawel/.nvm/versions/node/v18.14.0/lib/node_modules/sfdx-cli/node_modules/@salesforce/core/lib/logger.js:514:32)
    at Create.run (/Users/pawel/.nvm/versions/node/v18.14.0/lib/node_modules/sfdx-cli/node_modules/@salesforce/plugin-org/lib/commands/force/org/create.js:26:21)

System Information
{
  "cliVersion": "sfdx-cli/7.187.1",
  "architecture": "linux-arm64",
  "nodeVersion": "node-v18.14.0",
  "pluginVersions": [
    "@oclif/plugin-autocomplete 1.4.4 (core)",
    "@oclif/plugin-commands 2.2.5 (core)",
    "@oclif/plugin-help 5.2.2 (core)",
    "@oclif/plugin-not-found 2.3.17 (core)",
    "@oclif/plugin-plugins 2.3.0 (core)",
    "@oclif/plugin-search 0.0.11 (core)",
    "@oclif/plugin-update 3.1.1 (core)",
    "@oclif/plugin-version 1.2.1 (core)",
    "@oclif/plugin-warn-if-update-available 2.0.24 (core)",
    "@oclif/plugin-which 2.2.12 (core)",
    "alias 2.2.0 (core)",
    "apex 1.5.0 (core)",
    "auth 2.4.0 (core)",
    "community 2.2.0 (core)",
    "config 1.5.0 (core)",
    "custom-metadata 2.1.0 (core)",
    "data 2.2.0 (core)",
    "generator 2.0.17 (core)",
    "info 2.4.0 (core)",
    "limits 2.3.0 (core)",
    "org 2.3.0 (core)",
    "packaging 1.14.1 (core)",
    "schema 2.3.0 (core)",
    "signups 1.4.0 (core)",
    "source 2.4.1 (core)",
    "telemetry 2.1.0 (core)",
    "templates 55.3.0 (core)",
    "trust 2.4.0 (core)",
    "user 2.3.0 (core)",
    "@salesforce/sfdx-plugin-lwc-test 1.0.1 (core)",
    "salesforce-alm 54.8.5 (core)"
  ],
  "osVersion": "Linux 5.15.49-linuxkit",
  "shell": "unknown",
  "rootPath": "/usr/local/lib/node_modules/sfdx-cli"
}

Additional information
it fails same way on latest-rc 7.188.1
might be related to:

https://github.com/forcedotcom/cli/issues/1914
https://github.com/forcedotcom/cli/issues/1907

Confirming I have the same issue on a Bitbucket pipeline

Me too on bitbucket pipeline

Same issue on my Side on Bitbucet also, I changed the image from my pipeline
"image: salesforce/salesforcedx:7.186.0-slim"
instead of
"image: salesforce/salesforcedx:latest-slim"
and it worked again for me.
But it's not an explanation on the root cause we faced at the beginning.

I can reproduce this locally, no CI involved.  I see the bug happen down in the logging framework, trying to figure out why and how to prevent it.

Same error on sfdx force:package:version:create

Confirming this is occurring in Github Actions as well, but glad @mshanemc was able to reproduce locally.
A bit of a blocking issue, so hopefully this gets a priority fix.

best workaround so far: SFDX_LOG_LEVEL=info instead of debug.

Just to confirm that I am also seeing this error in our CI builds:
sfdx-cli/7.194.1 linux-x64 node-v18.13.0
Successfully authorized ******** with org ID 00D40000000Mw0SEAS
jwt grant succeeded to hub org

> create-scratch-org
> sfdx force:org:create -v HubOrg -s -f config/project-scratch-def.json -a ciorg -d 1 --wait 60

Error (1): Converting circular structure to JSON
    --> starting at object with constructor 'Timeout'
    |     property '_idlePrev' -> object with constructor 'TimersList'
    --- property '_idleNext' closes the circle

When I set SFDX_LOG_LEVEL=info (as in SFDX_LOG_LEVEL=info sfdx force:org:create ...) the deployment succeeds.

@Kevmo92 there's no default log level, this only happens if you set SFDX_LOG_LEVEL=debug

@cristiand391 Why isn't there a default log level set 🤔

@mshanemc Instead of consumers implementing a workaround would it make more sense for a default log level to be set in the cli that's attempting to log?

For our CI builds, we want as much info as reasonable in the logs so that, when a build breaks, it's easier to diagnose the issue. We set a global ENV SFDX_LOG_LEVEL DEBUG for all of our sfdx commands right in the Dockerfile, but I am now overriding that with SFDX_LOG_LEVEL=info for the buggy commands (sfdx org:create:scratch).
It's unfortunate as I would prefer to have that extra level of log information (I assume that's what "debug" is for... debugging), but stepping down to info allowed our CI environment to finish a build without errors.

@cristiand391 @Kevmo92 According to Salesforce CLI Configuration and Tips / Log Messages and Log Levels:

The default level of log messages is warn.

@jdatskuid I think that was being set here:
https://github.com/salesforcecli/command/blob/main/src/sfdxFlags.ts#L528
So, commands supporting--log-level would have log level set to warn even if they didn't specify --loglevel warn when running a command because the flag had a default value.
That code was deprecated and removed for almost all commands now, and using that flag just prints a msg showing how to set the log level using the env var:
https://github.com/salesforcecli/sf-plugins-core/blob/de7f99d9c53410cfe6a514a00e45202aafcd35a0/src/compatibility.ts#L37-L49
I'll double-check with my team, otherwise we'll update the docs.

@jdatskuid A teammate mentioned the default log level set is still set to warn in the logger class:
https://github.com/forcedotcom/sfdx-core/blob/main/src/logger.ts#L208
While it's not exactly set as a global in sfdx like with the --loglevel flag, the default still applies unless a plugin/lib sets a different level.
To sum up:

default log level warn is set in the logger utility used by plugins/libraries.
--loglevel is deprecated and no longer sets log level, you should always set it via the SFDX_LOG_LEVEL env var.

@Kevmo92 do you get the error without setting SFDX_LOG_LEVEL ?

yes

Are there any plans to work on a fix that doesn't require an environment variable to be set? Could sfdx cli set the "necessary" env variable in the users session if it's not set? Or is the plan to just replace the logger system and let this issue linger in the meantime?

@Kevmo92 - Yes there are plans to fix the log level bug.  However, there are 2 workarounds to this issue:

unset SFDX_LOG_LEVEL
Use the newer command for creating orgs: org create scratch

fixed here: https://github.com/salesforcecli/plugin-org/pull/708
and already available on latest CLI.


Maybe use tailwind-variants instead of clsx & cva combo

I recently discover tailwind-variants which is a pretty nice library. It replaces clsx, cva & twMerge and add more tools for building Design System with tailwind.
"Why Tailwind Variants"
Worth noting that kobalte/pigment is already using it :)
What about switching to it ?

Thanks for your suggestion. :)
I'll have a look at it and see how it performs in comparison. We use clsx/cva because shadcn started with it and all ports just adopted the feature/utility class.

@sek-consulting For example here is your implementation of dialog component with tailwind-variants.
import { Dialog as DialogPrimitive } from "@kobalte/core";
import { type Component, type ComponentProps, splitProps } from "solid-js";
import FaIcon from "./fa-icon.tsx";
import { tv } from "tailwind-variants";

const dialog = tv({
  slots: {
    portal:
      "flex fixed inset-0 z-50 justify-center items-start sm:items-center",
    overlay:
      "fixed inset-0 z-50 bg-background/80 backdrop-blur-sm transition-all duration-100 data-[state=closed]:animate-out data-[state=closed]:fade-out data-[state=open]:fade-in",
    content:
      "fixed z-50 grid w-full gap-4 rounded-b-lg border bg-background p-6 shadow-lg animate-in data-[state=open]:fade-in-90 data-[state=open]:slide-in-from-bottom-10 sm:max-w-lg sm:rounded-lg sm:zoom-in-90 data-[state=open]:sm:slide-in-from-bottom-0",
    close:
      "absolute right-4 top-4 rounded-sm opacity-70 ring-offset-background transition-opacity hover:opacity-100 focus:outline-none focus:ring-2 focus:ring-ring focus:ring-offset-2 disabled:pointer-events-none data-[state=open]:bg-accent data-[state=open]:text-muted-foreground",
    header: "flex flex-col space-y-1.5 text-center sm:text-left",
    footer: "flex flex-col-reverse sm:flex-row sm:justify-end sm:space-x-2",
    title: "text-lg font-semibold leading-none tracking-tight",
    description: "text-sm text-muted-foreground",
  },
});

const { portal, overlay, content, close, header, footer, title, description } =
  dialog();

const Dialog = DialogPrimitive.Root;

const DialogTrigger: Component<DialogPrimitive.DialogTriggerProps> = (
  props,
) => {
  const [, rest] = splitProps(props, ["children"]);
  return (
    <DialogPrimitive.Trigger {...rest}>
      {props.children}
    </DialogPrimitive.Trigger>
  );
};

const DialogPortal: Component<DialogPrimitive.DialogPortalProps> = (props) => {
  const [, rest] = splitProps(props, ["children"]);
  return (
    <DialogPrimitive.Portal {...rest}>

        {props.children}

    </DialogPrimitive.Portal>
  );
};

const DialogOverlay: Component<DialogPrimitive.DialogOverlayProps> = (
  props,
) => {
  const [, rest] = splitProps(props, ["class"]);
  return (
    <DialogPrimitive.Overlay
      class={overlay({ class: props.class })}
      {...rest}
    />
  );
};

const DialogContent: Component<DialogPrimitive.DialogContentProps> = (
  props,
) => {
  const [, rest] = splitProps(props, ["class", "children"]);
  return (
    <DialogPortal>
      <DialogOverlay />
      <DialogPrimitive.Content
        class={content({ class: props.class })}
        {...rest}
      >
        {props.children}
        <DialogPrimitive.CloseButton class={close()}>
          <FaIcon name="xmark" style="Regular" class="w-4 h-4" />
          Close
        </DialogPrimitive.CloseButton>
      </DialogPrimitive.Content>
    </DialogPortal>
  );
};

const DialogHeader: Component<ComponentProps<"div">> = (props) => {
  const [, rest] = splitProps(props, ["class"]);
  return
;
};

const DialogFooter: Component<ComponentProps<"div">> = (props) => {
  const [, rest] = splitProps(props, ["class"]);
  return
;
};

const DialogTitle: Component<DialogPrimitive.DialogTitleProps> = (props) => {
  const [, rest] = splitProps(props, ["class"]);
  return (
    <DialogPrimitive.Title class={title({ class: props.class })} {...rest} />
  );
};

const DialogDescription: Component<DialogPrimitive.DialogDescriptionProps> = (
  props,
) => {
  const [, rest] = splitProps(props, ["class"]);
  return (
    <DialogPrimitive.Description
      class={description({ class: props.class })}
      {...rest}
    />
  );
};

export {
  Dialog,
  DialogContent,
  DialogDescription,
  DialogFooter,
  DialogHeader,
  DialogTitle,
  DialogTrigger,
};

Thanks for the example.
But after consulting with the Michael we'll stick with cva since we don't need all the extra features and we don't really want to completely seperate the styling from the components.


[Menu] Support inverted colored pointing menu

As you can see:

It must be:

Inverted menus currently set active colors with rgba() overlays which cant be matched with dropdown arrows. Will have to adjust css variables to use fixed hex colors for each active color.

Thanx for info :+1:

Just wondering what's the status on this? I'm having this issue right now.

It's a lower priority fix. You can fix for your site by adjusting .item .active:after { background-color: #exacthex }

Okay, I'll see if I can get some time to do this.

It looks like this one has slipped through the cracks. I'm facing the same issue and while I figured out the workaround, as @jlukic mentioned above, I hate doing hacks. I want to fix this for good. I'm attempting to do a PR for it (my first fork and PR ever, so bare with me) and I'm a little bit lost with the source code.  I haven't worked at all with LESS yet, and frankly, I've learned so many new things lately that I can't wrap my head around it right now. Any pointers would be welcome, and I'll do my best at attempting to fix it myself.
Also, if anyone does look into this issue themselves, note that the :after needs to be changed for both when you have a whole menu set to red and also if you specify just one menu item to be red.

@jhalbsgut Would be great if you fixed it for everybody. Not sure what to say to help you right away, but If you’ll have some questions, I might be able to answer them in our Gitter chatroom—I don’t want to bother other participants with constant notifications.


Add (back) images to Participants page

they were dropped on the move to the new design

Done

not the most elegant solution, but it works

this will be addressed when creating a template page just for the participants (with links to the participant's twitter, linkedin, etc..)


Fix some discrepancies in SVG logo

Mostly addresses @publicarray's feedback: adds missing glow, fixes color of the rightmost leaf, adds missing shadows.

Fantastic, thank you!

Good work! 👍


Create new skill

Create a new skill for Anna
What you can make is in your imagination.
You can refer to Google Assistant, Siri or Alexa Skills for Inspiration.
Look at the docs to understand how to add a skill or feature
Basically, it's an if statement in the background.js.
Before starting to work on a new feature, please make a new issue on this repo with

Your Idea as Title
How do you plan to Implement it
What are some use cases

This is a great first issue and hard issue as well. It all depends on your imagination.

Hi @gauthamzz, we'd like to add a new feature- Showing Internet Speed to the user.
Input to Anna : "Hey, Show Internet Speed".
Expected Ouput: A new tab is opened directed at Fast.com showing the results.
We also plan to make Anna speak the internet speed to the user through some web-scraping techniques.
For this, probably we need the access to the Dialogflow files to help us give a better understanding of the project, and also, to create a new skill for Anna.

Could you make a new issue named Add Skill: Internet speed and start working on it

Is this issue still open?

yes


TCL4 branch:  UVRs should be stored in grid

Problem
To support future operations, there is a gap related to knowing about any dynamic airspace restrictions (to be known as UAS Volume Reservations or UVRs).
Proposed Solution
This is a TCL4 problem/solution.  We should explore storing UVRs directly in the grid.  This would allow a new entrant to a given grid to immediately have access to the state of that airspace.  UVRs should only be writeable by USSs with an enhanced role, thus we'd have to check for a different scope in the access_token provided.  Only the USS that writes the UVR would have rights to modify or delete.  We may want a feature that automatically expires/deletes UVRs after some time (like within an hour of the UVR's end time), but we may want to wait on that and track as an additional github issue.
Describe alternatives you've considered
Alternatively, one could force enhanced USSs to serve these data to other USSs upon request.  There are issues with this approach.  First and foremost, how do we guarantee that such a USS is always available in a given grid?  And how are they easily identified from other USSs in the grid (some new metadata tag?)?
Additional context
Will need this sooner than later.  We can maybe target Sprint 4, but would take it whenever it might be available.
The model written to grid may leverage the existing UVR schema:  https://github.com/nasa/utm-apis/blob/3189acdb3ce13dd64258cecb0e4f3c40c158a202/utm-domains/utm-domain-commons.yaml#L1270

@BenjaminPelletier, we have updated UVR model
https://github.com/nasa/utm-apis/blob/v4-draft/utm-domains/utm-domain-commons.yaml
This is usually announced in the uss_implementor's channel.
Going forward, we will give you advance notice that will allow our models to be in sync before the announcement goes out.
Can you please update your model based on this?
We have been trying to codegen from your version and have encountered a problem with "allOf" attribute. We are currently blocked. I believe the v4-draft does not include this attribute.
Hopefully, this problem will go away after you sync up with our version.

I have also noticed a "timestamp" field being added to UASVolumeReservation when it is being returned from the grid that is causing trouble.

If the grid has old prior-version models that are returned via GET, that can happen.   We need to clean out incompat models.

Please open a new issue for each new issue.  This issue has already been resolved.

@issmith1, while the first round of UVR changes (storage API version 4.0.3 -> 4.1.0) are API-incompatible, they should be grid-compatible.  In other words, grid content should not need to be cleared or updated to use the 4.1.0 or 4.1.1.


Remove duplicate error class for HTTP status code 429

Thank you for reporting this issue and appreciate your patience. We've  notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.


[GHSA-2wpw-75c5-m9hx] The Replyable WordPress plugin before 2.2.10 does not...

Updates

Affected products
CVSS
CWEs
Description
References
Severity
Source code location
Summary

Comments
The plugin appears to have been patched to deal with at least the deserialization issue. I've added references to the updated source and other CNAs' reports.

Hi @dknauss, we appreciate your contribution. At this time GitHub's Advisory Database only supports WordPress plugins that are listed in Packagist. This plugin would be out of scope.

Ah, OK — I didn't write the original notice, I just edited to make it more
accurate.
––––––––––––––––––––––––
Dan Knauss
newlocalmedia.com • Design. Build.. Sustain...
Book a Call at Calendly ›› https://calendly.com/newlocalmedia
🇨🇦 +1<PHONE_NUMBER> <+1+(780)+394-2700> 🇺🇸 +1<PHONE_NUMBER>
<+1+(515)+329-6560>
On Fri, Mar 17, 2023 at 2:04 PM CallmeMari @.***> wrote:

Hi @dknauss https://github.com/dknauss, we appreciate your
contribution. At this time GitHub's Advisory Database only supports
WordPress plugins that are listed in Packagist. This plugin would be out of
scope.
—
Reply to this email directly, view it on GitHub
https://github.com/github/advisory-database/pull/1790#issuecomment-1474352401,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACCZEVOQ3HXFEVVWAFFWATW4S7WPANCNFSM6AAAAAAV4LNQIY
.
You are receiving this because you were mentioned.Message ID:
@.***>


[MLlib] fix typo

fix typo: it should be "default:" instead of "default;"

Test build #27812 has started for   PR 4713 at commit 15daf2e.

This patch merges cleanly.

OK, it's a quite trivial doc change. No need to wait for tests; I can merge into master.

Test build #27812 has finished for   PR 4713 at commit 15daf2e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27812/
Test PASSed.


Update debounce result

In debounce function, when immediate is false, since use the
setTimeout (_.delay), when debounced function return result, the result value is always undefined.

Coverage remained the same at 96.763% when pulling 043e91284ab9ffed1e25d66e811eb053e1cc1306 on mqyqingfeng:master into 20e7c6e164085e832b6140acc690d6f66f7f6c63 on jashkenas:master.

This is working as intended.


Unable to locate a class or view for component [infocalloutComponent].

Thank for your great work, several of this issues are now solved, there is another issues yet, that I think is correlated to this one.
In some pages I encounter this fatal error
InvalidArgumentException
Unable to locate a class or view for component [infocalloutComponent].

For example I find this error in the kanban page /production/kanban
I not able to understand if it is always correlated to missmatch case. It looks that the code is right. This is the first project in Laravel I ever study, sorry :(
Originally posted by @RobertoBochet in https://github.com/billyboy35/WebErpMesv2/issues/7#issuecomment-1017570464

@RobertoBochet
infocalloutComponent is called when I use a blade component that allows me to put help at the top of the page.
The class blade:
app/View/Components/infocalloutComponent.php
  public function render()
     {
         return view('components.infocallout-component');
     }

call the view: (verify that you have in folder )
resources/views/components/infocallout-component.blade.php
--
at the time of writing, I don't see a problem with case sensitive
I guess you must have other error on other page (like you company, or methods?)
--
Aslo this page executes a vue.js component did you execute in terminal ?
npm install
npm run dev
--
I keep looking :s

I used #8 to perform my test, it includes npm ci and composer install. If you want you can use it to reproduce the bug

I may have found a way out.
My blade component class did not start with a capital letter. What does not meet the standards
https://stackoverflow.com/questions/68494441/laravel-8-unable-to-locate-a-class-or-view-for-component-dashboardheader
can you test (while waiting for me to learn docker ^^)? I just updated the files
I don't know Docker too well, for the moment I can't mount an image, it returns an error and goes to a recovery container

Your fix partially works, I need to rename also the component file. I included this fix in #12

Sorry for docker, I assumed you can run it.
If you are able to install docker-compose you should only create .env file (the laravel .env file) then run the command docker-compose up you should be able to reach the app at address http://<IP_ADDRESS>:45060,  docker will do all the magic 😉


NIFI-10090 Update Guava JRE 28 in NiFi Toolkit to latest version

Summary
[NIFI-10090 Updated Guava JRE in the NiFi Toolkit
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking

[x] [NIFI-10090 issue created

Pull Request Tracking

[x] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
[x] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

[x] Pull Request based on current revision of the main branch
[x] Pull Request refers to a feature branch with one commit containing changes

Verification
Please indicate the verification steps performed prior to pull request creation.
Build

[ ] Build completed using mvn clean install -P contrib-check

[x] JDK 8
[x] JDK 11
[x] JDK 17

Licensing

[x] New dependencies are compatible with the Apache License 2.0 according to the License Policy
[x] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

[x] Documentation formatting appears as expected in rendered files

@exceptionfactory Thanks for the feedback. So would this change upgrade the remaining use of Guava from 28 to the most recent version?

@exceptionfactory Thanks for the information. I reviewed and approved, but is there anything I need to do? Should I submit a new PR instead?
I also noticed that updating the Google-KMS software would resolve another JIRA ticket for Java Protobuf, as the newer version of Google KMS. Is there anything else I need to do for this?

@exceptionfactory Thanks for the information. I reviewed and approved, but is there anything I need to do? Should I submit a new PR instead? I also noticed that updating the Google-KMS software would resolve another JIRA ticket for Java Protobuf, as the newer version of Google KMS. Is there anything else I need to do for this?

In light of the fact that upgrading Google KMS and other libraries impacts more than just Guava, it would be better to handle that in a separate Jira issue and separate PR.
If you can make the version adjustment to the Guava version in the other files, I can approve the workflow run.

@exceptionfactory ok. I have removed the Google KMS change and kept the Guava. Is there anything else I need to do and was that not the right change?

@exceptionfactory Yes sir. Once this is approved, I will either remove or update this fork accordingly.


Improve render - Address mouseEnter bug

WHAT
Changed a bit how rendering works. Rendering no longer spits out a fresh canvas on each UI cycle. Instead is modifies the existing one in the DOM tree, if needs to. Possible performance increase.
WHY

To solve the bug with mouse enter getting triggered on ever mouse move
It just makes things better generally. Its a smarter way to render.

@Chadtech other than fixing the conflict, this looks good :D


add add_student command

Codecov Report

Merging #75 (dabaee7) into master (260d2bc) will decrease coverage by 9.06%.
The diff coverage is 1.41%.

@@             Coverage Diff              @@
##             master      #75      +/-   ##
============================================
- Coverage     60.24%   51.18%   -9.07%
  Complexity      412      412
============================================
  Files            91      101      +10
  Lines          1542     1821     +279
  Branches        167      196      +29
============================================
+ Hits            929      932       +3
- Misses          577      852     +275
- Partials         36       37       +1

Impacted Files
Coverage Δ

...main/java/seedu/address/commons/core/Messages.java
0.00% <ø> (ø)

.../seedu/address/logic/commands/AddClassCommand.java
0.00% <0.00%> (ø)

...eedu/address/logic/commands/AddStudentCommand.java
0.00% <0.00%> (ø)

...edu/address/logic/commands/DeleteClassCommand.java
0.00% <0.00%> (ø)

...du/address/logic/parser/AddClassCommandParser.java
0.00% <0.00%> (ø)

.../address/logic/parser/AddStudentCommandParser.java
0.00% <0.00%> (ø)

.../seedu/address/logic/parser/AddressBookParser.java
80.00% <0.00%> (-20.00%)
:arrow_down:

...address/logic/parser/DeleteClassCommandParser.java
0.00% <0.00%> (ø)

...in/java/seedu/address/logic/parser/ParserUtil.java
57.37% <0.00%> (-39.85%)
:arrow_down:

src/main/java/seedu/address/model/AddressBook.java
59.25% <0.00%> (-34.86%)
:arrow_down:

... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48a9125...dabaee7. Read the comment docs.


v.next: move to .NET 8

Description
Use .NET 8 in v.next branch. Use ArcGIS Maps SDK 200.3. Enforce 200.3 minimum requirements.
Type of change

Other enhancement

Platforms tested on

[x] WPF .NET 6
[x] WPF Framework
[x] WinUI
[x] MAUI WinUI
[x] MAUI Android
[x] MAUI iOS
[x] MAUI MacCatalyst

NOTE: on Mac, in src open a terminal:
dotnet build -t:Run -f net8.0-ios
dotnet build -t:Run -f net8.0-maccatalyst
Visual Studio for Mac will not recognize the target platform identifiers, so must deploy from CLI.
Checklist

[x] Self-review of changes
[x] All changes work as expected on all affected platforms
[ ] There are no warnings related to changes
[x] No unrelated changes have been made to any other code or project files

CC: @duffh @car10567

Note: if switching between branches, you might need to run dotnet restore to get rid of CPM / NuGet errors, it sometimes has a hard time restoring packages until you explicitly run that command at the directory containing the .csproj


Add Super 100 Shooting Star Command Pod from Kerbal Stuff

This pull request was automatically generated by Kerbal Stuff on behalf of RaptorHunter, to add Super 100 Shooting Star Command Pod to CKAN.
Please direct questions about this pull request to RaptorHunter.

Has extras (heatshield is in a folder named extras)
Has internals which depend on RPM-Core to work


fix incorrect nullability for datetime type when writing to arrow

It panics when I try to read nullable datetime fields, then I found this incorrect conversion.

Hi @Cabbagec thanks for the bug fix!


React 19 Support - "Cannot read properties of undefined (reading 'ReactCurrentOwner')"

It seems like 10.3.0 is broken with NextJS 15 / React 19

Are there plans to update @planet/maps for React 19?
For context, I see this former issue in the react-three-fiber repo: https://github.com/pmndrs/react-three-fiber/issues/3398
They also use a custom renderer so I suspect this is a similar issue

Thanks raising the issue. I'll look into what it will take to support React 19.

@sam-skydio - I've pushed changes to make the tests pass and examples work with React 19.
If you're able to npm install @planet/maps@dev and try it out, I'd be curious to hear if you run into any issues.
I'm anticipating that there will still be issues to work out in cases where ref or innerRef are used.


Added ui test for Kompose

Codecov Report

Merging #670 into master will increase coverage by 0.47%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #670      +/-   ##
==========================================
+ Coverage   95.98%   96.46%   +0.47%
==========================================
  Files          29       29
  Lines        2464     2599     +135
  Branches      208      208
==========================================
+ Hits         2365     2507     +142
+ Misses         99       92       -7

Impacted Files
Coverage Δ

browser/services/platform.js
90.37% <0%> (-0.05%)
:arrow_down:

browser/model/devstudio.js
100% <0%> (ø)
:arrow_up:

browser/model/cygwin.js
100% <0%> (ø)
:arrow_up:

browser/pages/start/controller.js
100% <0%> (ø)
:arrow_up:

browser/services/componentLoader.js
100% <0%> (ø)
:arrow_up:

browser/services/request.js
100% <0%> (ø)
:arrow_up:

browser/pages/install/controller.js
100% <0%> (ø)
:arrow_up:

browser/model/hyperv.js
100% <0%> (ø)
:arrow_up:

browser/directives/pathValidator.js
100% <0%> (ø)
:arrow_up:

browser/model/helpers/version.js
100% <0%> (ø)
:arrow_up:

... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 199ef42...43c4597. Read the comment docs.


Problem with updating user-changeable properties

Before scala-dom-types, we used the value attribute and manually synced this with property value (valueSyncHook). This was specific for the value property and still left problems with e.g. checked. Now, we use the property value directly and not the attribute. This generally fixes the problem, but now we are running in into an issue with updating user-changeable properties in snabbdom: https://github.com/snabbdom/snabbdom/issues/345.

React.js has the notion of controlled/un-controlled components, the difference being the source of truth about the state of the component (the DOM or the component).
For example translating the example from snabbdom/snabbdom#345 to Outwatch it could be something like:
import outwatch.dom.{Handler, Attributes => A, Tags => T}

def component(): VNode = {
  Handler.create[String].flatMap { strHandler =>
    T.div(
      T.input(A.`type` := "text", A.value := "test", A.value <-- strHandler),
      T.button(A.onClick("test") --> strHandler, "Set")
    )
  }
}

Here, pressing the "Set" button after changing the input text doesn't do anything because the the new prop'a value is the same as the old prop.
We can turn this into a "controlled component" (in react.js terminology), by sync-ing the DOM state to the component, which fixes the issue:
def component(): VNode = {
  Handler.create[String].flatMap { strHandler =>
    T.div(
      T.input(A.`type` := "text", A.value := "test", A.value <-- strHandler, A.onInputString --> strHandler),
      T.button(A.onClick("test") --> strHandler, "Set")
    )
  }
}

For a nicer syntax, we could have a valueControlled VDomModifier builder:
object valueControlled {
  def <-->(handler: Handler[String]): VDomModifier = Seq(
    A.value <-- handler, A.onInputString --> handler
  )
}

def component(): VNode = {
  Handler.create[String].flatMap { strHandler =>
    T.div(
      T.input(A.`type` := "text", A.value := "test", valueControlled <--> strHandler),
      T.button(A.onClick("test") --> strHandler, "Set")
    )
  }
}

I'm also in favor of not expecting too much knowledge about virtual dom inner workings from the user. It should be simple and just work.
I researched a bit and never found any benchmark or evidence that reading dom properties may be slow. Does anyone know something more about that? Benchmarks would be nice.
When looking at constructs like
A.value <-- strHandler, A.onInputString --> strHandler

I doubt that updating the dom on every keystroke is better than checking once if if the dom property changed.

fixed by 441298a2ee57f539cc00cf5eba7ddd3e1cfc91c6


Text pixels are missing in the generated image

We lost pixels in the generated image, but it not bound to appear.
Someone in the same Browser and System version has this problem, another have not.
One of us reproduce the problem 90% of the time in the browser(Microsoft Edge, version: 107.0.1418.35), when he clears the browser cache.
[browser & version]: Microsoft Edge, version: 107.0.1418.35
[html2canvas version]: 1.4.0
So I can't locate the problem and ask you for help, thank you.

Got the same issue rn

I have the same problem. It appears to be a bug in the hardware accelerated 2D canvas support in Chromium based browsers. I've tested both Edge and Chrome and it affects both. Going to edge://flags/#disable-accelerated-2d-canvas or chrome://flags/#disable-accelerated-2d-canvas in the respective browser and disabling the "Accelerated 2D canvas" setting results in text being rendered properly.

I have the same problem. It appears to be a bug in the hardware accelerated 2D canvas support in Chromium based browsers. I've tested both Edge and Chrome and it affects both. Going to edge://flags/#disable-accelerated-2d-canvas or chrome://flags/#disable-accelerated-2d-canvas in the respective browser and disabling the "Accelerated 2D canvas" setting results in text being rendered properly.

Hi @OneGeek,
Can you recall what bug it was, e.g. do you have a link or some sort of reference to it?
I'm wondering if it is already fixed, or not.
Disabling GPU did the trick for me.
Using JCEF:
CefAppBuilder builder = new CefAppBuilder();
builder.addJcefArgs("--disable-gpu");

I switched to html-to-image. Problem sovled


Update filemod dependency to 2.0.0

I posted an issue on the filemod repo here: https://github.com/intuita-inc/filemod/issues/19
filemod 1.1.0 is missing a LICENSE file, so I am unable to provision this package at my org, having that invalid dependency. 2.0.0 has been released, and it would be great if codemod-engine-node could be updated to use filemod 2.0.0
thank you

@andyparisi already working on it

@andyparisi I released the changes under v. 0.7.1 https://www.npmjs.com/package/intuita/v/0.7.1

@andyparisi I'd be happy to invite you to our Slack community: https://join.slack.com/t/intuita-inc/shared_invite/zt-1bjj5exxi-95yPfWi71HcO2p_sS5L2wA


use readthedocs for generating documentation

Hi Patrick, I'm not sure how far you were with preparations for this, but I'd like to try to set it up now. I hear it's very easy to setup, so I'll just go ahead.

It's already done http://kernel-tuner.readthedocs.io/en/latest/

Haha ok! Never mind ;-)

One very big bummer is that there's now ads on the documentation pages, I had not realized that

Note that, apart from some minimal configuration on readthedocs.org, the one thing that had to be changed in the code is the addition of a requirements.txt file. I put this in the readthedocs branch for the time being. If we decide to use readthedocs.org, the readthedocs branch could be merged into master and the readthedocs.org configuration should be updated to base the build on the master branch. Also, it would be useful to activate Github webhooks then, which I don't have permissions for.

Since we're trying the alternative, I'll close this issue for the time being


add avatar before submit buttons

Added avatar before submit new post buttons, just like before sign in.

Differences:

Thanks! :+1: It's live and looking good!


Commiting Dedicated Load Balancer: Securing Web Traffic

Pulling -- Dedicated Load Balancer: Securing Web Traffic

Comment--> Dedicated Load Balancer: Securing Web Traffic

@maxim-clc there are just 3 images in this pull request.  is there a kb that is supposed to be present to associate with these images?

Adding a KB to the images.


Migrate Protein Folding PoC with opflow to a new design.

How does this relate to #158? Is that done as such, that whatever outcome is being redesigned? And I guess this is all being done under #150 which may could become an Epic with this and #158 as sub-parts of that?


ja-trans:conetent/ja/casestudies/nav

Japanese translation for case study of Nav.
Translated from https://kubernetes.io/case-studies/nav
to https://kubernetes.io/ja/case-studies/nav
Fixes #18212

@maabou512
Thank you for quick fix.
I've checked all of contents in this PR.
I don't have permission for slash lgtm but It's LGTM! :+1:

/lgtm
/approve

/milestone 1.16-ja.1


Invalid JS code when packages have dashes

When using genType.import with an npm package that has dashes in the name the generated JS code becomes invalid.
Example
[@genType]
type visible = [ |<EMAIL_ADDRESS>"auto"] `visible |<EMAIL_ADDRESS>"0"] `hidden];

<EMAIL_ADDRESS>"react-animate-height"]<EMAIL_ADDRESS>"./AnimateHeight.re.js"]
external make:
  (~duration: int, ~visibility: visible, 'a) =>
  ReasonReact.component(
    ReasonReact.stateless,
    ReasonReact.noRetainedProps,
    ReasonReact.actionless,
  ) =
  "default";

let make = make;

for untyped output becomes
/* Untyped file generated by genType. */

const ReasonReact = require('reason-react/src/ReasonReact.js');

const react-animate-height = require('react-animate-height');

// In case of type error, check the type of 'make' in 'AnimateHeight.re' and the props of 'react-animate-height'.
export function react-animate-heightTypeChecked(props) {
  return <react-animate-height {...props}/>;
}

// Export 'make' early to allow circular import from the '.bs.js' file.
export const make = function _(duration, visibility, children) { return ReasonReact.wrapJsForReason(react-animate-height, {duration: duration, visibility: $$toJS1053365315[visibility]}, children); };

const $$toJS1053365315 = {"589592690": "auto", "-862584982": "0"};

Where const react-animate-height is an invalid name for a variable.

I can hotfix this in my code by creating a file called reactAnimateHeight.js that just default exports the npm package for now.

@arnarthor thanks for the report!
This should fix it: https://github.com/cristianoc/genType/commit/39178216b5e1a21b19915a3a8bab5d960e047b47.
Anything else to sanitize?

That is one amazing turnaround time 👌
This is perfect, haven't seen anything else so far but I'll create more issues as I use it more.
Just started integrating this into a decently sized project today, so we'll probably use it pretty heavily in the coming weeks. Looks really good so far at least

Great. If you find anything else, just let us know.


Wakahn branch4 - New Workbook Azure Resource Health

New workbook for Azure Resource Health

i'd hold off on this one a bit, we have some fixes coming for some subtle issues in azure health (like sql database always getting back an "unknown")

Is there an ETA on that fix?

the fix for sql dbs is in today, will be through the pipeline over the next few days.  We have found that "master" databases are not supported (seemingly intended?)

I recreated the file, is this correct now?

actually it looks like maybe you already did that delete/rename and the problem was just in the history of the branch?

Updated resource picker to use ARM query and improved summary page by using tiles

@WKahnZA this PR is like 6 months old, is it still valid?  closing for now, you'll need to reopen and re-merge, etc.  a lot has changed since this PR was created.


hlcy, 1ref, mnvv, cpofp, solar, ssrun, vig, vbdsf, vddsf

new graphics for:

min hlcy (4 levels)
storm relative hlcy (2 levels),
1 hr reflectivity
frozen precip %
incoming SW/Direct/Diffuse radiation
mean vertical velocity
storm surface runoff
vertically-integrated graupel.

pylint and pytest passed.  plot examples to follow.

plot examples. 14 plots but only 3 new color tables.  ;-)
curious about mean vertical velocity.  Wondering if small up and down values are close together so they cover each other up and the color that shows depends on the order of plotting.  can discuss it here or in a meet-up.
web graphics - PR41.pptx


App don't respond If a new user clicked the SIGN IN WITH GOOGLE button

Are you a part of GSSOC' 21?

[X] Yes
[ ] No

Describe the bug
When a new user mistakenly clicks the SIGN IN WITH GOOGLE button, It doesn't show any pop-up or error toast which gives the user the right direction to create an account first. The app doesn't give any reaction to that mistake.
To Reproduce
Steps to reproduce the behavior:

Open the app and click SIGN IN WITH GOOGLE button.
Select an account that is not linked to this app.

Expected behavior
The app should show a pop-up or error toast to the user that this account doesn't have linked with the app, create an account first.
Additional context
I want to work on this issue. Please assign me.
Screenshot
https://user-images.githubusercontent.com/71203077/112310897-15fbb800-8ccb-11eb-9691-87c016081759.mp4

Hey, @Ayan-10 when a user clicks on the SIGN IN WITH GOOGLE button, if the account exists user is signed in and if the account does not exist, one is created for them. Can you tell me what the problem is and how would you solve it?

Hey, @krayong I tested the app. Whenever I clicked the SIGN IN WITH GOOGLE button and select a new google account that is not linked with the app. It just does nothing. You can see this in the video that I shared here. If anyone clicked the SIGN IN WITH GOOGLE buttoned select a new google account that is not linked with the app should show some information to the user through a pop-up. But the app doesn't give any response to that situation.

@Ayan-10 please download the application from play store and check if the issue persists. If it does tell me I'll assign this issue to you and you can work on it.

@krayong I installed it from Playstore. For the first two times, it did not respond means did the same thing. But third time It reacted normally. I think some error occurred in the app the first two times. Didn't you think we should show an error message if login is not successful?

It works correctly for me and while being released it had been tested by 20-30 people. So I don't think there is a problem. But if you find one please open a PR. I'm assigning this issue to you.

Hey, @krayong I was thinking to show a toast if login is not successful. The toast will contain "Login unsuccessful, please try again". Should I move forward with that or Do you have any preference in the toast message or any other recommendation?

Sure do this just use StyleableToast as is used throughout the application.

Sure, Obviously I will maintain the app theme.


[Bug][Complement Data] Business time does not correspond to scheduling time

To Reproduce
Steps to reproduce the behavior, for example:

Program Business time ： $[yyyyMMddHH-1/24]
Complement Data ： start time:20210612 17:00, end time: 20210612 17:00
Normally, the program output business time is<PHONE_NUMBER>
4.But at the end of the day what we get is<PHONE_NUMBER>

运行补数，脚本的业务日期和实际日期有差异。
Expected behavior
A clear and concise description of what you expected to happen.
Which version of Dolphin Scheduler:
-[1.3.5]

阅读了文档


💅 Nuxt 3 Blog Content

Nuxt 3 Blog content (/blog)
This is fun 🏂

ref https://github.com/kodadot/nft-gallery/issues/7034#issuecomment-1717333668

I'll merge it thanks


⚠ Bofrost.at has degraded performance

In 7c3bbe6, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2220 ms

Resolved: Bofrost.at performance has improved in 5d0e7dd after 31 minutes.


[WFLY-16238] Don't export traces by default

https://issues.redhat.com/browse/WFLY-16238
If no sender endpoint or agent is configured, configure a no-op sender.

Dependency Tree Analyzer Output:
New Dependencies:
* org.jetbrains.kotlin:kotlin-stdlib-common:jar:1.7.10:compile

* org.jetbrains.kotlin:kotlin-stdlib:jar:1.7.10:compile

Major Version Changes:
* com.squareup.okio:okio:jar:1.17.5:compile -> 2.8.0

CC @wildfly/prod

These changes have been moved to #16089

/retest


Prepare for release 3.7.0

Description

Added a 3.7.0 version section to CHANGES.rst, and moved the PyPI readme comments (695b17f626ca15d458a7c884833ac107ffd941ca).
Also replaced the PyPI readme comments in CHANGES.rst with a regex in pyproject.toml, to avoid having to move the comments every time we're preparing a new release (1fe70ab41c3add16cc1752929cbd8aee8d08c42b).
Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have run the pre-commit run command to format and lint.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] I have added my name and/or github handle to AUTHORS.rst
[x] I have added my change to CHANGES.rst
[x] All new and existing tests passed.

@tim-schilling Any thoughts on replacing the PyPI readme comments with a somewhat complex regex (in 1fe70ab41c3add16cc1752929cbd8aee8d08c42b)? 🙂

somewhat complex regex

Somewhat eh? :sweat_smile:
I think I'm good with it. If it doesn't work, it's a small problem and doesn't impact the library as a whole. I say to that to mean the risk is fairly low.

Somewhat eh? 😅

Hahah, I've seen too many regexes horrifyingly more complex than this one, so it's sometimes challenging to judge the complexity when I know those exist 😅

I think I'm good with it. If it doesn't work, it's a small problem and doesn't impact the library as a whole. I say to that to mean the risk is fairly low.

I agree :) Worst-case, the PyPI readme will contain parts of the Unreleased section, or the changelog won't be included at all - both of which I think are acceptable, since the unaltered changelog is present in both the docs and on GitHub (which are also linked to from PyPI).

@treyhunner Would you mind publishing the newest version to PyPI, again? :)

@treyhunner Would you mind publishing the newest version to PyPI, again? :)

Published 👍


E2E test for AWS-SSM - Different Regions

Add e2e tests for AWS-SSM that focus on pulling secrets from different regions.
Issue split from #209

I can pick this up! :)

Just had a chat with gustavo and learned that this was a duplicate and already resolved :D will look for something else to contribute to

Alright, good to know, gonna close this then :+1:


Pressing ESC during configuration crashes the tool

✖ What do you want to configure? Start typing to search for options or scroll down to see all options · Show/Hide prev and next article in each article page

node:internal/process/promises:289
            triggerUncaughtException(err, true /* fromPromise */);
            ^

[UnhandledPromiseRejection: This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason "".] {
  code: 'ERR_UNHANDLED_REJECTION'
}

Running with npx blowfish-tools, if I press ESC (sometimes if I hit it twice) it will crash with this message.

Thanks @stevenctl will have a look


refactor: remove all deprecated code

Summary
This commit removes all deprecated code. Even though this is done a bit earlier than originally announced under the Qiskit deprecation policy, we are taking this step now since this project has become part of a community effort.
As a direct consequence, new codeowners will soon join the team behind Qiskit Nature. Rather than handing over a codebase that includes pieces of code which need attention in the near future (and even continued support until then) we are removing these parts early.
As a consequence, if you still require parts of this code, we suggest you stick to Qiskit Nature 0.6 until you can transition based on the provided migration guides.
This commit also removes the deprecation utilities which are superseded by the ones provided by Qiskit directly (see qiskit.utils.deprecation). Thus, this PR closes #1196
Details and comments

[x] add a release note with a prelude section to explain the above

This also closes #1169

Since there is too much to go through in detail in this PR, here are a few noteworthy details:

I removed the deprecation utils (see prior comments)
I removed all occurrences of opflow (this includes PauliSumOp)
I removed all factories and their usage
I removed the QubitConverter and all its usage
I removed the runtime module
I removed all the settings attributes which become unused as a result of all these removals
please have a look at the suggested prelude in the release note

What do you want to do about the AdaptVQE howto docs/howtos/adapt_vqe.rst It refers to settings that this removes. I get that it will also need to be updated around qiskit_algorithms but this PR removes some of what it refers to, so if we want it in sync with this then maybe update it here - and again for the algorithms change later.

What do you want to do about the AdaptVQE howto docs/howtos/adapt_vqe.rst It refers to settings that this removes. I get that it will also need to be updated around qiskit_algorithms but this PR removes some of what it refers to, so if we want it in sync with this then maybe update it here - and again for the algorithms change later.

Nice catch! I did not think to look through the tutorials and how-tos for additional usage of settings or other removed aspects. Will do that now :+1:

I have pushed two additional changes:

removing all further usage of setting attributes which have been removed. Grepping for settings now only shows results for optimize_einsum and in the migration guides (where they should remain)

I removed the release note which was added in #1142 because it is now obsolete


Fix get keywords for only neo fields handles and not all field handles

Iterating over all field handles and overwriting the element in the fieldType breaks other plugins that save other elements depending on the current save event. Instead only iterate over the current NeoBlock fields

Thanks for contributing this :) Might disappoint you but I've actually already fixed this in the dev branch, and will be included in the next release of Neo which'll be soon. Appreciate it though 👍


Can you provide some guidance on the spectrum modeling?

          Thanks for the excellent modern approach to CT reconstruction. I notice that most of your solutions, such as BH and scatter, are based on spectrum modeling of the system. However, I'm new to this field. Can you provide some guidance on the modeling?

Originally posted by @lc82111 in https://github.com/LLNL/LEAP/issues/71#issuecomment-2380564686

@lc82111, I assume you've seen the demo scripts here, here, and here.
Modeling the spectra involves three major components:

x-ray source spectra
filtering of the source spectra
detector response.

The XrayPhysics library provides models for all three of these.  The hardest one to get right is the detector response because vendors don't always disclose details about how the x-ray detector is constructed.  For example, the materials used in the front face of the detector (which is usually plastic and/ or aluminum) must be included in item (2) above, the x-ray filters.  The best way to model the detector response is with a Monte Carlo simulation, but this is very difficult to do.  So here are the main components you will need to model each of the items above
X-ray Source Spectra
kV setting, anode take-off angle, and the anode material type.
Most x-ray tubes use a Tungsten (W) anode and a take-off angle between 11 and 30 degrees.
X-ray Filters
the chemical formula, density, and thickness of all materials the x-ray passes through include the materials in the front face of the detector (but do not include anything in the object you are scanning)
Detector Response
We use just a simple model of the product of stopping power of the scintillator material and a linear conversion of x-ray energy to photodiode response.  For this you need the chemical formula, density, and thickness of the scintillator.
The XrayPhysics library has many of the detector types in its material library which you can use.  This includes: GOS, CsI, LSO, LYSO, NaI, BGO, GSO, and CZT.
If you get all of these specified accurately and you employ all the correction algorithms, you should be able to remove most of the artifacts.  If you goal is absolute quantitative accuracy, then you will want to calibrate your spectra by scanning well-known references and tuning the spectra model until the model matches the measurement.  I will add spectral calibration algorithms to LEAP sometime in the future.

I am on the work to convert BHC example into native c++ with xrayphysics library. And comments are helpful for me too.

What questions do you guys have?


TraceId and spanId do not propagate over kafka messages due to SleuthKafkaAspect.wrapProducerFactory() is not triggered

Tracing information do not propagate over kafka messages due to the method SleuthKafkaAspect.wrapProducerFactory() is not triggered.
On the producer side, the message is correctly sent and the tracing information is correctly logged. On consumer side, instead a new traceId and spanId is created.
The following two logging lines show different values for traceId,spanId (and parentId):
2021-03-23 11:42:30.158 [http-nio-9185-exec-2] INFO  my.company.Producer - /4afe07273872918b/4afe07273872918b// - Sending event='MyEvent'
2021-03-23 11:42:54.374 [org.springframework.kafka.KafkaListenerEndpointContainer#1-0-C-1] INFO my.company.Consumer /1fec3bf6a3c91773/ff4bd26b2e509ed8/1fec3bf6a3c91773/ - Received new event='MyEvent'

In first instance, using Krafdrop and also debugging, I verified that the message header doesn't contains any tracing information.
After that, I figured out that the method SleuthKafkaAspect.wrapProducerFactory() is never triggered, instead on consumer side the method SleuthKafkaAspect.anyConsumerFactory() is.
The libraries versions used are the following:

spring boot:  2.3.7.RELEASE
spring cloud bom: Hoxton.SR10
spring cloud: 2.2.7.RELEASE (and 2.2.5.RELEASE)
spring kafka: 2.5.10.RELEASE
kakfa client: 2.4.1
spring-cloud-starter-sleuth: 2.2.7.RELEASE
spring-cloud-sleuth-zipkin:2.2.7.RELEASE

The kakfa client library version is 2.4.1 is due to a version downgrade related to production bug on 2.5.1 version of kafka client that increase the cpu usage.
I also tried to use the following libraries versions combination with no success:

spring boot:  2.3.7.RELEASE
spring cloud bom: Hoxton.SR10 (and Hoxton.SR8)
spring cloud: 2.2.7.RELEASE (and 2.2.5.RELEASE)
spring kafka: 2.5.10.RELEASE
kakfa client: 2.5.1
spring-cloud-starter-sleuth: 2.2.7.RELEASE (and 2.2.5.RELEASE)
spring-cloud-sleuth-zipkin:2.2.7.RELEASE (and 2.2.5.RELEASE)

spring boot:  2.3.7.RELEASE
spring cloud bom: Hoxton.SR10 (and Hoxton.SR8)
spring cloud: 2.2.7.RELEASE (and 2.2.5.RELEASE)
spring kafka: 2.5.10.RELEASE
kakfa client: 2.6.0
spring-cloud-starter-sleuth: 2.2.7.RELEASE (and 2.2.5.RELEASE)
spring-cloud-sleuth-zipkin:2.2.7.RELEASE (and 2.2.5.RELEASE)

spring boot:  2.3.7.RELEASE
spring cloud bom: Hoxton.SR10 (and Hoxton.SR8)
spring cloud: 2.2.7.RELEASE (and 2.2.5.RELEASE)
spring kafka: 2.6.x
kakfa client: 2.6.0
spring-cloud-starter-sleuth: 2.2.7.RELEASE (and 2.2.5.RELEASE)
spring-cloud-sleuth-zipkin:2.2.7.RELEASE (and 2.2.5.RELEASE)

We migrated our project to a different spring boot version, from 2.3.0.RELEASE to 2.3.7.RELEASE. Before everthing was working correctly.
Below the old libraries versions:

spring-boot: 2.3.0.RELEASE
spring-kafka: 2.5.0.RELEASE
kafka-clients: 2.4.1
spring-cloud: 2.2.5.RELEASE
spring-cloud-starter-sleuth: 2.2.5.RELEASE
spring-cloud-sleuth-zipkin:2.2.5.RELEASE

We also introduced a log42/log4j (before it was slf4j with logback).
Below the related libraries:
- org.springframework.boot:spring-boot-starter-log4j2:jar:2.3.7.RELEASE:compile
- org.slf4j:jul-to-slf4j:jar:1.7.30:compile
- io.projectreactor:reactor-test:jar:3.3.12.RELEASE:test
- io.projectreactor:reactor-core:jar:3.3.12.RELEASE:test
- org.reactivestreams:reactive-streams:jar:1.0.3:test

The properties configured are the following:
spring.sleuth.messaging.enabled=true
spring.kafka.consumer.auto-offset-reset=latest
spring.kafka.consumer.enable-auto-commit=false
spring.kafka.bootstrap-servers=localhost:9092
spring.kafka.client-id=myClientIdentifier
spring.kafka.consumer.group-id=MyConsumerGroup
spring.kafka.producer.value-serializer=org.springframework.kafka.support.serializer.JsonSerializer

The configuration class for the ProducerFactory creation is the following:

@Configuration
@EnableTransactionManagement
public class KafkaProducerConfig {

	KafkaProperties kafkaProperties;

	@Autowired
	public KafkaProducerConfig(
			KafkaProperties kafkaProperties) {
		this.kafkaProperties = kafkaProperties;
	}

	@Bean
	public KafkaTemplate<String, Object> kafkaTemplate() {
		KafkaTemplate<String, Object> kafkaTemplate = new KafkaTemplate<>(producerFactory());
		return kafkaTemplate;
	}

	private ProducerFactory<String, Object> producerFactory() {
		DefaultKafkaProducerFactory<String, Object> defaultKafkaProducerFactory =
				new DefaultKafkaProducerFactory<>(producerConfigs());
		//defaultKafkaProducerFactory.transactionCapable();
		//defaultKafkaProducerFactory.setTransactionIdPrefix("tx-");
		return defaultKafkaProducerFactory;
	}

	private Map<String, Object> producerConfigs() {

		Map<String, Object> configs = kafkaProperties.buildProducerProperties();
		configs.put(ProducerConfig.KEY_SERIALIZER_CLASS_CONFIG, StringSerializer.class);
		configs.put(ProducerConfig.VALUE_SERIALIZER_CLASS_CONFIG, JsonSerializer.class);
		return configs;
	}

}

My spring boot application class:

@Profile("DEV")
@SpringBootApplication(
        scanBasePackages = {"my.company"},
        exclude = {
                DataSourceAutoConfiguration.class,
                DataSourceTransactionManagerAutoConfiguration.class,
                HibernateJpaAutoConfiguration.class
        }
)
@EnableSwagger2
@EnableFeignClients(basePackages = {"my.company.common", "my.company.integration"})
@EnableTransactionManagement
@EnableMongoRepositories(basePackages = {
        "my.company.repository"})
@EnableMBeanExport(registration = RegistrationPolicy.IGNORE_EXISTING)
@ServletComponentScan
public class DevAppStartup extends SpringBootServletInitializer {

    public static void main(String[] args) {
        SpringApplication.run(DevAppStartup.class, args);
    }

}

Here you can find the output of command "mvn dependency:tree"
mvn_dependency_tree.txt

I guess this is the same: https://stackoverflow.com/questions/66766936/why-tracing-information-do-not-propagate-over-kafka-messages-when-spring-sleuth
Could you please try out if it works if you use the spring boot and spring cloud boms and you don't define the versions on your own? Using StreamBinder or MessageChannel should work but the functional (Supplier) approach is not supported.
If it still does not work that way, could you please create a minimal java sample app that reproduces the issue?

Hi Jonatov,
yes, it's the same issue on Stackoverflow.
I already tried using spring boot and spring cloud boms. Anyway I don't have any control about some libraries, because those are managed by another company division. We aren't using a functional approach.
You can find a sample project here: https://github.com/venraf/ms-kafka-issue

@venraf This is quite a big example, could you please reduce it so that you have nothing else but sleuth and kafka libs?

@jonatan-ivanov I created a new branch called "easiest" that just has sleuth and kafka libs.

@jonatan-ivanov I pushed the branch named "solved". I changed the way how kafka is inizialized . I think now will be easy for you understand what is wrong. Please, let me know. Thanks.

@venraf We might have a different idea about what does a minimal sample mean. This is how many .java files your project has on the different branches:

master: 46
easiest-without-log4j2: 20
easiest: 19
solved: 19

To me minimal means that you can't really remove anything (including properties) from the project because it won't really be able to repro the issue anymore. I don't think it is the case for your project. Having a minimal project not just helps understanding what is going on but also, it helps a lot ruling out other factors.
Here are two examples: https://github.com/jonatan-ivanov/sleuth-gh-1659, https://github.com/jonatan-ivanov/sleuth-gh-1729
Could you please create a minimal project that reproduces your issue?

Hello Jonatan,
the number of projects is very large and it was difficult for me to identify the problem and, of course, to provide a clear example.
I apoligize for it. I figured out that the problem occurs when the instantation of KafkaTemplate class is done in this way:
@Bean
public KafkaTemplate<String, Object> kafkaTemplate() {
    Map<String, Object> configs = kafkaProperties.buildProducerProperties();
    ProducerFactory<String, Object> defaultKafkaProducerFactory = new DefaultKafkaProducerFactory<>(configs);
    return new KafkaTemplate<>(defaultKafkaProducerFactory);
}

When the method is commented, the traceId is correctly propagated.
I created a new branch called "minimal" (https://github.com/venraf/ms-kafka-issue) with 3 classes:

MyController: the rest controller that send the message
KafkaProducerConfig: the configuration class with kafkaTemplate() method defined above
DevAppStartup: the Spring Boot starter class

The endpoint url is: http://localhost:9185/resources/{id}
I hope that could be a good example. Probably, I'm missing something really obvious.

@venraf You can always go to start.spring.io and generate a minimal project: here you go: mvc+sleuth+kafka
I cloned your repo, I ran mvn verify and I got this:
[ERROR] /Users/jivanov/playground/sleuth-gh-1886/src/main/java/my/company/project/DevAppStartup.java:[17,8] cannot access javax.servlet.ServletException
  class file for javax.servlet.ServletException not found

Also, the project is still not minimal (I gave you two examples, please look at them):

You don't need log4j
You don't need a bunch of properties
You don't need any of the custom annotations on your app (except an empty SpringBootApplication, no base package)
You don't need transaction management

Please generate a project using start.spring.io (see: mvc+sleuth+kafka) and use it as a starting point.
Why do you create a KafkaTemplate and a ProducerFactory, does not spring create one for you?

@jonatan-ivanov Thanks again. Unfortunately we have several customizations. Here is the new branch "minimal-new" as requested.

@venraf Thank for all of your effort for minimizing this. From our perspective having a project that we can reproduce the issue with minimal moving parts is vital, it makes troubleshooting possible.
I was able to repro and fix your issue, here's what I did:

Since you removed your docker-compose file and the original contains a lot of things (including mongoDB),
I used a different compose file (I think this is unrelated)
Fixed a few things (put application name back, cleaned-up the controller a little) (I think this is unrelated)
Created a ProducerFactory bean as the documentation suggests, I think you need to do this if you use your own KafkaTemplate

Here's the whole class:
package my.company.mykafkaissue;

import org.springframework.boot.autoconfigure.kafka.KafkaProperties;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
import org.springframework.kafka.core.DefaultKafkaProducerFactory;
import org.springframework.kafka.core.KafkaTemplate;
import org.springframework.kafka.core.ProducerFactory;

@Configuration
public class KafkaProducerConfig {

    @Bean
    public ProducerFactory<String, Object>producerFactory(KafkaProperties kafkaProperties) {
        return new DefaultKafkaProducerFactory<>(kafkaProperties.buildProducerProperties());
    }

    @Bean
    public KafkaTemplate<String, Object> kafkaTemplate(ProducerFactory<String, Object>producerFactory) {
        return new KafkaTemplate<>(producerFactory);
    }
}

I can push a fix branch to your repo if you are interested.
Please check and let me know if it works.

Thank you so much for your help! I know, you are absolutely right. When a project is large it becomes impossible to understand the real cause. We have already fixed the problem in our projects. There is no need to share the repository. Many thanks again.

Hi @jonatan-ivanov , Iam also facing similar kind of issue, where Iam not able to see traceId for the Kafka Consumer. Iam using Spring Cloud Sleuth and Spring Kafka for my application.


soc: ti_simplelink: kconfig: ble: kconfig for cc13xx-cc26xx

This Kconfig option is a placeholder for now.
The intent is to control whether additional BLE support is enabled for the cc13xx_cc26xx platform in hal/ti and subsys/bluetooth.
In hal/ti, we would prefer to conditionally compile the support files (see zephyrproject-rtos/hal_ti#13). This change is required to support the SimpleLink BLE port (WIP #21631).
CC: @vanti @galak

@bwitherspoon - can you have a look at this please?

Will wait until after 2.3.0 is released

Sorry @vanti I unintentionally requested your review. I don't think I can undo it.

@carlescufi - rebased. should be good to go. This patch is integer-free!

Looks like ARC / Qemu is causing this to fail. It was green before.


Chore/296 template

Add a template that provides guidelines and examples for documenting OpenAPI Paths and Operations.
Update background and instructions in README.

@kelseiv Will you review my ./README.md changes again?

@StacieClark @gavincabbage @lesam @glinton
cc: @rickspencer3 @evinaku
We've been working on this template to help with documenting API paths and operations.
I'd appreciate your feedback:

Is it usable?
Is it clear?
Is it too much or lacking?

I'll also be pushing some changes for tags soon. The README update here reflects those in-flight changes.
TIA!

@kelseiv Will you review my README.md changes again?

minor edits--LGTM!


Check startup on low level Android

Wasn’t getting past the splash screen in the simulator on Kit Kat

Fixed - default style for AppTheme.NoActionBar wasn't backwards compatible


Retrieving verificationId and code from credential object

See discussion @ https://github.com/arnesson/cordova-plugin-firebase/issues/756
This basically retrieves the verificationId and code from the onVerificationCompleted credential. Meaning we can use verificationId and code to finally solve the instant verification issue.
var code = credential.instantVerification ? credential.code : inputField.value.toString() ;
If instantVerification is true we get the code directly from firebase without the need to go through an sms process. Otherwise use the sms code entered by the user.

[ ] API doc needs to be updated accordingly
[ ] It does work with the single line above and retrieving a valid credential. But I'm not a javascript developer, there might be an even better way to use this to create your own javascript credential object and skip the "firebase.auth.PhoneAuthProvider.credential" part altogether and directly call signInWithCredential. Feedback appreciated

@briantq iOS changes are not needed, instant verification only works on Android according to the Firebase API: https://firebase.google.com/docs/auth/ios/phone-auth

@manuelsc There are definitely half a dozen ways to do thing.  I personally would look for the known list of fields, verify they exist, then get their value rather than trying to guess on the length of their values.  I think trying to rely on value length could be more brittle than field names.  That being said, if you think that is a better solution you put the effort into creating the PR so I don't mind approving.

@briantq I mean it's tricky and I understand your concern. But I think relying on the length is somewhat more reliable than relying on an obfuscated name. Those names could change with any release while using the size is constant. Otherwise we could find ourself in updating the obfuscated names after every firebase update. Sure length is not an absolute viable option either but we would only need to change this if other string fields get included that share a similar length. That's far more unlikely than the obfuscated names being changed.

@manuelsc to start with, I want to make sure to reiterate, I am ok merging with the implementation.
For the acedemic discussion, I think the obfucsated name is better because

Performance (grab 2 fields instead of all, especially since Reflection is notoriously slow).  Very minor I admit, I have been known to over optimized code.
The keys are likely stored in their source code.  If they update the keys, they will need to update their client code otherwise they risk break existing clients.  I think it is unlikely these keys would change, but they could.
New fields are added without warning which could cause problems
3a. If you encounter issues, you wil get unpredicable behavior.  Depending on how the keys are ordered, you might get random behavior where it works some times and not other.  And when it doesn't work, it will appear like it is working since the method is returning a value.  Alternatively, if the field changes the code will break in an expected way that should be evident within minutes of debugging.

In the end, I think changes will be rare which is why I am ok with the implementation.  The big advantage to me is 3a.

@manuelsc please update the API docs to reflect these changes.  Once the docs are updated I will release a new version.


codeql action for cpp fails while creating the codeql db

Hello,
I searched with different keywords here and google and codeql/codeql repository but couldn't find a hinting place. The codeql analysis for cpp fails like below as taken from the github actions output:
    Finalizing cpp
      /home/anAdminForGithubVM/actions-runner/_work/_tool/CodeQL/2.14.3/x64/codeql/codeql database finalize --finalize-dataset --threads=8 --ram=29817 /home/anAdminForGithubVM/actions-runner/_work/_temp/codeql_databases/cpp
      Running TRAP import for CodeQL database at /home/anAdminForGithubVM/actions-runner/_work/_temp/codeql_databases/cpp...
      A fatal error occurred: Could not create array folder /home/anAdminForGithubVM/actions-runner/_work/_temp/codeql_databases/cpp/db-cpp/default/idPool/indices3
      (eventual cause: FileSystemException "/home/anAdminForGithubVM/actions-runner/_work/_temp/codeql_databases/cpp/db-cpp/...")
      A fatal error occurred: Dataset import for /home/anAdminForGithubVM/actions-runner/_work/_temp/codeql_databases/cpp/db-cpp failed with code 2.
      Error: Encountered a fatal error while running "/home/anAdminForGithubVM/actions-runner/_work/_tool/CodeQL/2.14.3/x64/codeql/codeql database finalize --finalize-dataset --threads=8 --ram=29817 /home/anAdminForGithubVM/actions-runner/_work/_temp/codeql_databases/cpp". Exit code was 2 and error was: A fatal error occurred: Dataset import for /home/anAdminForGithubVM/actions-runner/_work/_temp/codeql_databases/cpp/db-cpp failed with code 2.
      Context:
      A fatal error occurred: Could not create array folder /home/anAdminForGithubVM/actions-runner/_work/_temp/codeql_databases/cpp/db-cpp/default/idPool/indices3
      (eventual cause: FileSystemException "/home/anAdminForGithubVM/actions-runner/_work/_temp/codeql_databases/cpp/db-cpp/...")

I'm trying to run codeql on the repository of a 3d open source software called blender. Previously, attempting to use ordinary github runners gave lack of disk space error on codeql action, so I set up an Azure cloud instance (Ubuntu-22.04) with 8 cpu and 32 Gb of Ram as a self-hosted runner. I set it up and started it in a tmux session with ./run.sh and saw that it was ready and working.
The error doesn't make sense since there were many other files created and have a huge disk space(300Gb).
After the error it stopped on the lines above. Their prepending lines were:
Run github/codeql-action/analyze@v[2](https://github.com/nnWhisperer/blender/actions/runs/6173419795/job/16755922895#step:7:2)
  with:
    category: /language:cpp
    output: ../results
    upload: always
    cleanup-level: brutal
    add-snippets: false
    skip-queries: false
    checkout_path: /home/anAdminForGithubVM/actions-runner/_work/blender/blender
    upload-database: true
    wait-for-processing: true
    token: ***
    matrix: {
    "language": "cpp"
  }
    expect-error: false
  env:
    CODEQL_ACTION_FEATURE_MULTI_LANGUAGE: false
    CODEQL_ACTION_FEATURE_SANDWICH: false
    CODEQL_ACTION_FEATURE_SARIF_COMBINE: true
    CODEQL_ACTION_FEATURE_WILL_UPLOAD: true
    CODEQL_ACTION_VERSION: 2.21.5
    JOB_RUN_UUID: 00a4c892-b847-40c5-8f09-07885f85[3](https://github.com/nnWhisperer/blender/actions/runs/6173419795/job/16755922895#step:7:3)720
    CODEQL_ACTION_ANALYSIS_KEY: .github/workflows/codeql-cpp-self-hosted.yml:analyze
    CODEQL_WORKFLOW_STARTED_AT: 2023-09-13T1[4](https://github.com/nnWhisperer/blender/actions/runs/6173419795/job/16755922895#step:7:4):19:39.432Z
    CODEQL_RAM: 29817
    CODEQL_THREADS: 8
    CODEQL_EXTRACTOR_KOTLIN_OVERRIDE_MAXIMUM_VERSION_LIMIT: 1.9.20
    CODEQL_EXTRACTOR_PYTHON_DISABLE_LIBRARY_EXTRACTION: true
    CODEQL_TRACER_LOG: /home/anAdminForGithubVM/actions-runner/_work/_temp/codeql_databases/log/build-tracer.log
    CODEQL_TRACER_DIAGNOSTICS_DIR: /home/anAdminForGithubVM/actions-runner/_work/_temp/codeql_databases/diagnostic/tracer
    CODEQL_TRACER_LANGUAGES: cpp
    SEMMLE_PRELOAD_libtrace: /home/anAdminForGithubVM/actions-runner/_work/_tool/CodeQL/2.14.3/x[6](https://github.com/nnWhisperer/blender/actions/runs/6173419795/job/16755922895#step:7:6)4/codeql/tools/linux64/${LIB}_${PLATFORM}_trace.so
    SEMMLE_PRELOAD_libtrace32: /home/anAdminForGithubVM/actions-runner/_work/_tool/CodeQL/2.14.3/x64/codeql/tools/linux64/lib32trace.so
    SEMMLE_PRELOAD_libtrace64: /home/anAdminForGithubVM/actions-runner/_work/_tool/CodeQL/2.14.3/x64/codeql/tools/linux64/lib64trace.so
    CODEQL_PLATFORM: linux64
    CODEQL_DIST: /home/anAdminForGithubVM/actions-runner/_work/_tool/CodeQL/2.14.3/x64/codeql
    CODEQL_SCRATCH_DIR: /home/anAdminForGithubVM/actions-runner/_work/_temp/codeql_databases/working
    CODEQL_PLATFORM_DLL_EXTENSION: .so
    CODEQL_JAVA_HOME: /home/anAdminForGithubVM/actions-runner/_work/_tool/CodeQL/2.14.3/x64/codeql/tools/linux64/java
    CODEQL_EXTRACTOR_CPP_ROOT: /home/anAdminForGithubVM/actions-runner/_work/_tool/CodeQL/2.14.3/x64/codeql/cpp
    CODEQL_EXTRACTOR_CPP_WIP_DATABASE: /home/anAdminForGithubVM/actions-runner/_work/_temp/codeql_databases/cpp
    CODEQL_EXTRACTOR_CPP_DIAGNOSTIC_DIR: /home/anAdminForGithubVM/actions-runner/_work/_temp/codeql_databases/cpp/diagnostic/extractors/cpp
    CODEQL_EXTRACTOR_CPP_LOG_DIR: /home/anAdminForGithubVM/actions-runner/_work/_temp/codeql_databases/cpp/log
    CODEQL_EXTRACTOR_CPP_SCRATCH_DIR: /home/anAdminForGithubVM/actions-runner/_work/_temp/codeql_databases/cpp/working
    CODEQL_EXTRACTOR_CPP_TRAP_DIR: /home/anAdminForGithubVM/actions-runner/_work/_temp/codeql_databases/cpp/trap/cpp
    CODEQL_EXTRACTOR_CPP_SOURCE_ARCHIVE_DIR: /home/anAdminForGithubVM/actions-runner/_work/_temp/codeql_databases/cpp/src
    CODEQL_EXTRACTOR_CPP_THREADS: 8
    CODEQL_EXTRACTOR_CPP_RAM: 2981[7](https://github.com/nnWhisperer/blender/actions/runs/6173419795/job/16755922895#step:7:7)
    LD_PRELOAD: /home/anAdminForGithubVM/actions-runner/_work/_tool/CodeQL/2.[14](https://github.com/nnWhisperer/blender/actions/runs/6173419795/job/16755922895#step:7:14).3/x64/codeql/tools/linux64/${LIB}_${PLATFORM}_trace.so
    CODEQL_RUNNER: /home/anAdminForGithubVM/actions-runner/_work/_tool/CodeQL/2.14.3/x64/codeql/tools/linux64/runner
/home/anAdminForGithubVM/actions-runner/_work/_tool/CodeQL/2.14.3/x64/codeql/codeql version --format=terse
2.14.3

When I look at the same event on logs left on the self hosted server, it says the following:
    [2023-09-13 15:25:59Z INFO ExecutionContext] Publish step telemetry for current step {
      "action": "github/codeql-action/analyze",
      "ref": "v2",
      "type": "node16",
      "stage": "Main",
      "stepId": "657e1007-ff93-5216-d6a4-b6e19df1982b",
      "stepContextName": "__github_codeql-action_2",
      "hasPreStep": false,
      "hasPostStep": true,
      "result": "failed",
      "errorMessages": [
        "Encountered a fatal error while running \"/home/anAdminForGithubVM/actions-runner/_work/_tool/CodeQL/2.14.3/x64/codeql/codeql database finalize --finalize-dataset --threads=8 --ram=29817 /home/anAdminForGithubVM/actions-runner/_work/_temp/codeql_databases/c"
      ],
      "executionTimeInSeconds": 670,
      "startTime": "2023-09-13T15:14:50.0719318Z",
      "finishTime": "2023-09-13T15:25:59.4846872Z"
    }.

I don't know whether it is related to what's causing my task to fail but, notice that it says "Encountered a fatal error while running "/home/anAdminForGithubVM/actions-runner/_work/_tool/CodeQL/2.14.3/x64/codeql/codeql database finalize --finalize-dataset --threads=8 --ram=29817 /home/anAdminForGithubVM/actions-runner/_work/_temp/codeql_databases/c" Which is different from what the github actions UI shows. I guess that's a bug caused by referring to the same thing with different names "C" or "Cpp"
"/home/anAdminForGithubVM/actions-runner/_work/_temp/" is empty. To me it seems that the second bug is that the codeql_databases/* folders aren't created so it cannot write to subsequent folder. Of course these are only suspicions. So, please help. Thank you

https://github.com/nnWhisperer/blender/actions/runs/6173419795/job/16755922895
This is the job I'm referring to.
When I check that, codeql-action init step gave the following:
    /home/anAdminForGithubVM/actions-runner/_work/_tool/CodeQL/2.14.3/x64/codeql/codeql database init --db-cluster /home/anAdminForGithubVM/actions-runner/_work/_temp/codeql_databases --source-root=/home/anAdminForGithubVM/actions-runner/_work/blender/blender --language=cpp --begin-tracing --trace-process-name=Runner.Worker.exe --codescanning-config=/home/anAdminForGithubVM/actions-runner/_work/_temp/user-config.yaml --calculate-language-specific-baseline
    Calculating baseline information in /home/anAdminForGithubVM/actions-runner/_work/blender/blender
    Running command in /home/anAdminForGithubVM/actions-runner/_work/blender/blender: [/home/anAdminForGithubVM/actions-runner/_work/_tool/CodeQL/2.14.3/x64/codeql/javascript/tools/configure-baseline.sh]
    Calculated baseline information for languages: cpp, csharp, javascript, python, yaml (1.4s).
    Resolving extractor cpp.
    Successfully loaded extractor C/C++ (cpp) from /home/anAdminForGithubVM/actions-runner/_work/_tool/CodeQL/2.14.3/x64/codeql/cpp.
    Created skeleton CodeQL database at /home/anAdminForGithubVM/actions-runner/_work/_temp/codeql_databases/cpp. This in-progress database is ready to be populated by an extractor.

So it says that a skeleton CodeQL db was created in that directory but in fact it isn't.

I note the message You are running out of disk space. The runner will stop working when the machine runs out of disk space. Free space left: 0 MB
Can you allocate the VM a larger disk?

Hello @smowton, you might be looking at a previous run. In the last run,  it gave error I mentioned. As I explained, I had already allocated an Azure gloud instance with 300Gb disk space. At the end only 35Gb were used.

Both https://github.com/nnWhisperer/blender/actions/runs/6173419795/attempts/1 and https://github.com/nnWhisperer/blender/actions/runs/6173419795/attempts/2 show a disk space related message. You mentioned that the database is gone at the end, presumably as a result of temp dir cleanout? Do you know that the disk didn't overflow during execution, only ending up at 35Gb after the temp dir was cleaned?


Mount storage libraries without uncompressing JAR

When building Docker image, setting classpath:
ENV MODULE_OPTS -Dloader.path='BOOT-INF/lib/kafka-module.jar,BOOT-INF/lib/kafka-module.jar!/lib' -Dspring.profiles.active=kafka

Is causing ClassNotFound.
Current workaround is unpacking JAR into classpath:
COPY autoconfigure/target/zipkin-autoconfigure-storage-kafka-${KAFKA_STORAGE_VERSION}-module.jar BOOT-INF/lib/kafka-module.jar
RUN unzip -o BOOT-INF/lib/kafka-module.jar lib/* -d BOOT-INF

BTW this approach works fine on bash (host):
        STORAGE_TYPE=kafka \
	KAFKA_BOOTSTRAP_SERVERS=localhost:19092 \
	java \
	-Dloader.path='autoconfigure/target/zipkin-autoconfigure-storage-kafka-${VERSION}-module.jar,autoconfigure/target/zipkin-autoconfigure-storage-kafka-${VERSION}-module.jar!/lib' \
	-Dspring.profiles.active=kafka \
	-cp zipkin.jar \
	org.springframework.boot.loader.PropertiesLauncher

so if I get you right.. in docker you cannot have compressed jars, but normaly you can.
maybe this has to do with that in docker we unpack zipkin.jar

Right, trying to do this without unpacking zipkin jar, it works fine, check #30
Then, I'm considering to keep zipkin jar and don't unzip it.

unzipping was initially a way to help with incremental containers like cloudfoundry who tries to be smart about only moving necessary change. if you don't unzip, it is only an issue of layering of the base image which is unzipped.. I still think we should try to figure out why this is busted, but meanwhile making own image is fine!


Binomial distribution

Example Problem:
A manufacturer of metal pistons finds that, on average, 38.4% of the pistons they manufacture are rejected because they are incorrectly sized. What is the probability that a batch of 11 pistons will contain no more than 1 rejected pistons
Example Solution:
3.81%
Further explanation (optional):
crash course video about that topic: https://www.youtube.com/watch?v=WR0nMTr6uOo
Would you like to be assigned to this:
Yes

@lukew3 What do you think? This should be ok, right?

Yeah, its good


Change repr to no longer print the whole model content

Codecov Report

Merging #80 into dev will decrease coverage by 0.20%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev      #80      +/-   ##
==========================================
- Coverage   99.06%   98.85%   -0.21%
==========================================
  Files          10       10
  Lines        1066     1049      -17
==========================================
- Hits         1056     1037      -19
- Misses         10       12       +2

Impacted Files
Coverage Δ

tbmodels/_tb_model.py
98.76% <ø> (-0.02%)
:arrow_down:

tbmodels/_sparse_matrix.py
88.23% <0.00%> (-11.77%)
:arrow_down:

tbmodels/io.py
100.00% <0.00%> (ø)

tbmodels/_cli.py
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aecdf99...6a236ea. Read the comment docs.


Issue with DNS auth sequence

I'm getting the error listed below when I attempt to renew or issue a new certificate. The error does not prevent the renewal or issuance of the certificate, however.
ERROR:
Encountered exception during recovery: certbot.errors.PluginError: Unable to rotate DNS challenges: 'record'
This is running certbot 2.4.0 on Ubuntu 20.04.4 after installing certbot and the plugin using the pip3 install method.

Okay, good to hear that it's just a stray error and not impacting renewals. I'll address this in the coming week.

I'm also encountering the same error, but on Ubuntu 22.04.02 with the same version of certbot. I used the docker run method.

Hmm I'm trying to recreate this bug. Haven't had success so far.

I am seeing the same issue. :(  I am extending the ghcr.io/aaomidi/certbot-dns-google-domains:latest docker image.

Could you share the command you’re using? I’m planning to add a debug flag
as well.
On Mon, Mar 20, 2023 at 18:17 Joel Brown @.***> wrote:

I am seeing the same issue. :( I am extending the
ghcr.io/aaomidi/certbot-dns-google-domains:latest docker image.
—
Reply to this email directly, view it on GitHub
https://github.com/aaomidi/certbot-dns-google-domains/issues/25#issuecomment-1477015058,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AALF3OIY7YAI6LIBWG3BVTDW5DJNXANCNFSM6AAAAAAV7ZTVP4
.

Simulating a certificate request for <domain> and 4 more domains
Unsafe permissions on credentials configuration file: /var/lib/letsencrypt/dns_google_domains_credentials.ini
Zone selected for ...
Waiting 30 seconds for DNS changes to propagate
Encountered exception during recovery: certbot.errors.PluginError: Unable to rotate DNS challenges: 'record'
The dry run was successful.

The module (https://pypi.org/project/certbot-dns-google-domains/) has been updated with some additional logging (by default stored at /var/log/letsencrypt/letsencrypt.log).
The access token is already removed from the logs for security purposes. However, if you need to share the logs to investigate the issue, you can also redact any other information that you don't want to share. Keep in mind that domain names in certificates are public information due to certificate transparency, as they are listed on websites such as crt.sh.
Thank you for helping me find the root cause of the problem.

I ran the following command
certbot certonly \
        --dry-run \
        --noninteractive --agree-tos --email<EMAIL_ADDRESS>\
        --authenticator 'dns-google-domains' \
        --dns-google-domains-credentials '/home/canada/.secrets/certbot/google_api_key.ini' \
        --dns-google-domains-zone 'evocable.ca' \
        -d 'www.evocable.ca' \
        --config-dir ~/.certbot/config --logs-dir ~/.certbot/logs --work-dir ~/.certbot/work

The output from the command is:
Saving debug log to /home/canada/.certbot/logs/letsencrypt.log
Simulating a certificate request for www.evocable.ca
Waiting 30 seconds for DNS changes to propagate
Encountered exception during recovery: certbot.errors.PluginError: Unable to rotate DNS challenges: 'record'
The dry run was successful.

The log file is attached:
letsencrypt.log

Thank you so much @epicrunze. PR is out to fix this.

Looks like the docker build release is failing, might be related to all the certificate issues GitHub has been having. Will try again tomorrow. Keeping the bug open till then.

Is this fixed with docker?

I get the error: Encountered exception during recovery: certbot.errors.PluginError: Unable to rotate DNS challenges: 400 Client Error: Bad Request for url: https://acmedns.googleapis.com/v1/acmeChallengeSets /:rotateChallenges. I tried to issue a certificate through docker, and through certbot installed via pip3, but it's still the same

Is this fixed with docker?

This should be pushed with docker too at this point.

I get the error: Encountered exception during recovery: certbot.errors.PluginError: Unable to rotate DNS challenges: 400 Client Error: Bad Request for url: https://acmedns.googleapis.com/v1/acmeChallengeSets /:rotateChallenges. I tried to issue a certificate through docker, and through certbot installed via pip3, but it's still the same

I think I'll have to see the exact logs to be able to figure out what's going on. E.g. if you used
--logs-dir ~/.certbot/logs

The logs will be in there.


Chalkboards should use chalkboard font

We should find a nice chalkboard font and use that for the handwritten parts of the game, like the chalkboard in the puzzles

Closed by #1205


Is it possible to make top level KFServing virtual service optional?

/kind feature
/kind question
Describe the solution you'd like

As KFServing users, we would like to use KFServing without Istio. For example, KNative supports other Ingress like Contour, Kourier, Ambassador, Gloo, etc but KFServing always requires Istio.
The top level KFServing's virtual service needs Istio but the virtualservice could be optional? We cannot access the URL in isvc, but it still can work with the URL in ksvc. The URL in isvc is necessary?

Anything else you would like to add:

Especially this Ingress reconciler codes https://github.com/kubeflow/kfserving/blob/ec9e8ca569ea173de3717a41130e37cfb756ac8d/pkg/controller/v1beta1/inferenceservice/controller.go#L138-L147 should be optional. For example, if ingressGateway and ingressService are not configured, the controller could skip the reconciler and then KFServing controller does not touch VirtualService and Gateway at all.

@nak3 we are planning to make istio optional, the top level virtual service currently is used to route across multiple InferenceService components under a single domain for predictor, transformer and explainer which are created as separate knative services.

@yuzisun That's awesome. And that is really clear answer why the top level VirtualService is necessary :smile:  Thank you so much.

we are planning to make istio optional

Is there an issue to track?

I would like  to know that as well. For internal cluster only traffic, the local gateway is more than enough.

Any update on this? The docs say

Istio ingress is recommended, but you can choose to install with other Ingress controllers.

but that is not the case as noted here.
I do not want to run the mess that is Istio in order to run kserve.

@yuzisun is istio optional now?
GKE has also deprecated Istio, but its working for some time as per this