Recognition of Gastoniella (Pteridoideae, Pteridaceae)

Author(s) of proposal
Liang Zhang
Name of taxon
Gastoniella
Rank of taxon
Genus
Approximate number of species affected
3
Description of change
Zhang et al . (2017) resolved the subfamily Pteridoideae into four strongly supported monophyletic clades: the Pteris clade, the Actiniopteris + Onychium clade, the JAPSTT clade (Jamesonia, Austrogramme, Pterozonium, Syngramma, Taenitis, Tryonia), and the GAPCC (Gastoniella, Anogramma, Pityrogramma, Cerosora, Cosentinia) clade. Within the GAPCC clade, Gastoniella is proposed as a new genus segregated from Anogramma in order to maintain monophyletic Anogramma s.s. and Pityrogramma s.s.
Reason for change
Instead of recognize six genera in the GAPCC clade, one might argue that the four genera, Anogramma, Cerosora, Cosentinia, and Gastoniella can all be synonymized under Pityrogramma s.l. given that: (1) the monophyly of Pityrogramma s.l. is strongly supported; and (2) except Cosentinia, most species of the other three genera have already been placed in Pityrogramma by Domin (1928), e.g., P. chaerophylla, P. leptophylla, and P. microphylla. However, we advocate for the acceptance of these five strongly supported lineages as five genera for the following reasons: (1) They have distinct distributions with Cerosora and Cosentinia being the Old World genera, Pityrogramma and Gastoniella being the New World genera, and Anogramma having worldwide distribution; (2) There are abundant molecular variations among the five genera (e.g., 74-bp divergence exists between Gastoniella chaerophylla and P. calomelanos in 1262 bps of the rbcL gene alone); (3) The monophyly of each genus is strongly supported in molecular analyses; (4) The four genera each have anomalous morphology comparing with Pityrogramma s.s (see below); and (5) Most names have been available for other four genera.
Morphologically, the new genus Gastoniella differs from Cosentinia by having glabrous fronds, ovate-deltoid laminae; from Anogramma by having linear ultimate segments; from Pityrogramma by having annual and smaller habit of the sporophytes and no farina; from Cerosora by having linear ultimate segments, tufted rhizome (C. microphylla) or no farina (C. argentea).
Reference(s) for publication of the name
Domin, K., 1928. Generis Pityrogramma (Link) species ac sectiones in clavem analyticam dispositae. Spisy Vyd. Pøirod. Fak. Karlovy Univ. (Publ. Fac. Sci. Charles Univ.), 88, 1–10.
https://biotanz.landcareresearch.co.nz/references/d2c32d1f-9835-4566-b85c-eaf51fef44dd
Zhang, L., Zhou, X.-M., Lu, N.T., Zhang, L.-B., 2017. Phylogeny of the fern subfamily Pteridoideae (Pteridaceae; Pteridophyta), with the description of a new genus: Gastoniella. Mol. Phylogenet. Evol. 109, 59–72.
https://doi.org/10.1016/j.ympev.2016.12.037
List the numbers of any related issues
No response
Code of Conduct

[X] I agree to follow the PPG Code of Conduct

I think that recognition of Gastoniella by PPG is premature.  The proposal does not cite the foundational work upon which phylogenetic study of this group was based: Nakazato, T., Gastony, G.J., 2003. Molecular phylogenetics of Anogramma species and related genera (Pteridaceae: Taenitidoideae). Syst. Bot. 28, 490–502.  In that earlier work, which was based on data only from rbcL sequences, the authors chose not to segregate the Anogramma chaerophylla complex, stating: "Pityrogramma sulphurea and several other species of that genus, unavailable for this study, were specifically cited by R. Tryon (1962) as morphologically closest to Anogramma. Where rbcL would place those Pityrogramma species relative to the Anogramma clades of Fig. 5 remains to be determined."  The Zhang et al. (2017) study increased the number of molecular markers, but failed to address the issue of incomplete critical taxon sampling for Pityrogramma. Additionally, that study had relatively high amounts of incomplete sequence data in its matrix.  Thus, formal taxonomic segregation of Gastoniella was likely premature.  There have been no subsequent studies to flesh out the branching pattern, so I view this as an unresolved issue.

@crothfels thanks for the aside. I started a Discussion about it, so please post additional comments there.

This proposal was voted on during PPG Ballot 8 (voting period February 2024). A total of 70 votes were cast. There were 49 'Yes' votes (70%) and 21 'No' votes (30%). The proposal passes.


Is Luck Perms got Timed prefixes? (Question or Suggestion)

It seems buggy to patch other rank's prefix into default or other prefixes as I haven't used to use LuckPerms, I asked Google for help, he said I could used "weight" or "rank" to determine what should use first. But I don't get it at part "what should use first". For JUST an example I use rank Member with:
rank: 10
default: true
Prefix: &0Member
Note that its suffix is blank. Second rank Donor with:
Rank: 9
Suffix: &0Donor
And I apply both ranks to the member, I will get:
Rank: 9
Prefix: &0Member
Suffix: &0Donor
Above just an example for you to follow, and now for real question
There's additional prefix I want the player to have when they're "online to get rewards" to placed with is "&4RewardHunter"
The player will still have ordinary perms they should have of both the donator and member, but must change the prefix or suffix that we want to make them separate, ordinary member just enjoy the server will have ordinary "&0Member" prefix, Player Killer or "online to get rewards" will have "&4RewardHunter" prefix
Because I still not used to use LuckPerms, if there is already have this function to timed prefix, or timed group, timed permission, or some function that I could use it for force changing prefix for only a period time. Please guide me! Or this would be the Suggestion for LuckPerms, this function is needed great!

Adding a prefix for a certain amount of time:
https://github.com/lucko/LuckPerms/wiki/Command-Usage:-Meta#lp-usergroup-usergroup-meta-addtempprefix
Adding a group for a certain amount of time:
https://github.com/lucko/LuckPerms/wiki/Command-Usage:-Parent#lp-usergroup-usergroup-parent-addtemp

It helps me a lot! Thank you Mr. Imortal :+1:

Is your question answered/the issue resolved?
Then please close that issue :)


az storage blob generate-sas does not properly encode --full-uri

Describe the bug
az storage blob generate-sas ... --full-uri can have / characters in the SAS sig param. e.g.:
https://(account).blob.core.windows.net/(container)/(filename).vhd?...&sig=.../.../...
These should be escaped to %2F as they are a reserved character for URIs (and in this case we definitely want a full uri): https://tools.ietf.org/html/rfc3986#section-2.2
Unescaped /s in the SAS token can cause parsing issues in various places when trying to use the --full-uri output.
To Reproduce
Run az storage blob generate-sas ... --full-uri to generate the Full URI+SAS token for a blob. You may need to run it a couple times, but eventually there will be a / in the SAS token.
Expected behavior
The expected form of the --full-uri output should have the / characters escaped: https://(account).blob.core.windows.net/(container)/(filename).vhd?...&sig=...%2F...%2F...
The Az powershell module as an example does correctly escape the SAS characters (New-AzStorageBlobSASToken ... -FullUri).
Environment summary

Ubuntu 18.04.
Install method apt-get. Followed these instructions: https://docs.microsoft.com/en-us/cli/azure/install-azure-cli-apt?view=azure-cli-latest
azure-cli version: 2.0.81
Powershell or shell script run by Jenkins

Additional context
Add any other context about the problem here.

add to S167.

I am getting this error when generating SAS token with the source IP as well! The difference between the SAS that was working and the one we have now that it has dots!

Hi @Guilhermeslucas, sorry for  inconvenience and late response.
I have tried to reproduce your scenario and I generate two kinds sas uri as follows:

/ in sas token
https://zuhlrs.blob.core.windows.net/test/file 1.txt?sp=r&st=2020-03-18T08:10:22Z&se=2020-03-18T16:10:22Z&sip=<IP_ADDRESS>&spr=https&sv=2019-02-02&sr=b&sig=1bd9QpZOGkOJ%2FTjRLB3HpGAuYYTaqTI%2Bv8GM00QYwZk%3D
. in sas token
https://zuhlrs.blob.core.windows.net/test/file 1.txt?sp=r&st=2020-03-18T08:10:22Z&se=2020-03-18T16:10:22Z&sip=<IP_ADDRESS>&spr=https&sv=2019-02-02&sr=b&sig=1bd9QpZOGkOJ%2FTjRLB3HpGAuYYTaqTI%2Bv8GM00QYwZk%3D.

But I can succeed to access the blob with above two uris in browser.
Can you provide more information about your issues? For example, with which kind of client, which kind of error occurred , or your use scenario.
In addition, the . and / will be included when generating sas token in Portal. The behavior for Portal and CLI is the same.

Hi @Guilhermeslucas, any update?

Hi, I have the same problem on Windows. The full uri does not work.
Any update?

This is a problem open for months: generate-sas is handing out an invalid value. The provided URL will error out with:
<Error>
AuthenticationFailed
<Message>Server failed to authenticate the request. Make sure the value of Authorization header is formed correctly including the signature.RequestId:2f8c48fa-d01e-0029-05cb-ad71a1000000Time:2020-10-29T08:14:54.6251537Z</Message>
<AuthenticationErrorDetail>Signature fields not well formed.</AuthenticationErrorDetail>
</Error>

It's breaking automated workflows. Please have a look into this.

Hi @jimmybourque  and @kraiz, may I know your cli version now? We already encode  the url in https://github.com/Azure/azure-cli/commit/cdad270771cc44df0317a522035aef96f1547eef, which should take effect after CLI 2.3.0.

Hi @Juliehzl
$ az version
{
  "azure-cli": "2.14.0",
  "azure-cli-core": "2.14.0",
  "azure-cli-telemetry": "1.0.6",
  "extensions": {}
}

I just run generate-sas multiple times and every 4th or 5th time the sig query params contains / next to ordinary escaped special characters.
$ az storage blob generate-sas ...
"se=2038-10-30T06%3A26%3A00Z&sp=r&sv=2018-11-09&sr=b&sig=0jBqCt71j4puypf7%2B7NUNA0A/PIMaRUlHod5TWzCA9o%3D"

Hi  @kraiz , I could reproduce the sas token with /, but it still works as expected no authentication error. Here is the link:
https://zuhdefault.blob.core.windows.net/test4/try.txt?se=2020-11-03&sp=ra&sv=2018-11-09&sr=b&sig=EV5vxI0Wg87/tnyCTNBfkuL085LMhtuANzcQQBl%2BNGg%3D


[Bug] Redstone condition with detector

Hello,
It happens with the new detectors i place on my world. When i choose to set condition to emit when it is above the amount, when i get back to detector, it comes back to default status (emit when the amount).

this is already fixed

i'm on v17 you mean it will be resolved on the version 18?

yes, this will be fixed in 18


Applied @greg2001 changes as made the program friendlier for an automated build environment

Applied pull request #2 from @greg2001
Added support for passing class files in to have headers generated (this made it easier to integrate with a gradle build process)
Made a few more modifications to make the header generate identical to the javac -h ... command
Added caching for ClassReader
Made it possible to send classes in that don't have native methods, these are just ignored (this made it easier to integrate with a gradle build process)

I'm using this with gradle to create header files for my Kotlin code, here's what i'm using in my gradle file:
String NATIVE_SRC_DIR = "src/main/jni"
String NATIVE_SRC_JNI_INCLUDE_DIR = "src/main/jni/src/jni/generated"
String NATIVE_OUTPUT_DIR = "src/main/resources/native/lib"

...

/**
 * Generates header files for native methods.
 */
ext.javah = { String classpath, String outputDir, String classes ->
	exec {
		commandLine "sh", "tools/gjavah.sh", "-d", outputDir, "-classpath", classpath, classes
	}
}

...

tasks.withType(JavaCompile) {
	inputs.files(fileTree(NATIVE_SRC_DIR))
	inputs.files(fileTree(NATIVE_SRC_JNI_INCLUDE_DIR))
	outputs.dirs(NATIVE_OUTPUT_DIR)
	doLast {
		javah((sourceSets.main.runtimeClasspath + sourceSets.main.output).asPath,
				NATIVE_SRC_JNI_INCLUDE_DIR,
				sourceSets.main.output.asFileTree.matching { include "**/*.class" }.join(" "))
	}
}

Where tools/gjavah.sh is simply:
#!/bin/sh -e
MY_DIR=$(realpath $(dirname "$0"))
java -jar "$MY_DIR"/gjavah.jar $@


Dropdown should have left and right

@dtuite This is fixed now. Unlike other popular toolkits, I've somewhat controversially set the default alignment to right and added a prop for left. This is because the most common use case by far is right-aligned dropdowns.


chore: migrate to new prow reviewing

What have you changed? (mandatory)

Add Prow's OWNERS file to prepare to switch to new review controlling with lgtm and approve plugins.

What are the type of the changes? (mandatory)
The currently defined types are listed below, please pick one of the types for this PR by removing the others:

None

How has this PR been tested? (mandatory)
No need to test.
Does this PR affect documentation (docs/docs-cn) update? (mandatory)
No
Refer to a related PR or issue link (optional)

Backgroup: https://internals.tidb.io/t/topic/854
Ref: https://github.com/ti-community-infra/configs/issues/824

/hold It should be merged after bot's config updated, but we can review and approve it at current stage.

/unhold It only add file, will not affect anythings before bot update.

/unhold


created at Heroku

ran git init from root directory and the below:
$ heroku create -a did-i-need-that
Creating ⬢ did-i-need-that... done
https://did-i-need-that.herokuapp.com/ | https://git.heroku.com/did-i-need-that.git

done


code seems do not support resume training from a saved weight?

I was training a model using CASIA-Webface and it stopped in some where of total epochs accidentally. So I've add some lines in Learner.py and tried to resume training but got failed.
here is my resuming code:
 def train(self, conf, epochs,resume=False,fixed_str=None):
        self.model.train()
        conf.device = torch.device("cuda" if torch.cuda.is_available() else "cpu")
        self.model = nn.DataParallel(self.model)
        self.head = nn.DataParallel(self.head)
        self.model.cuda()
        self.head.cuda()
        start_epoch=0
        if resume==True:
            if not fixed_str:
                raise ValueError('must input fixed_str parameter!')
            self.load_state(conf,fixed_str)
            self.step = int(fixed_str.split('_')[-2].split(':')[1])+1
            start_epoch = self.step//len(self.loader)
            self.step = start_epoch*len(self.loader)+1
            print('loading model at epoch {} done!'.format(start_epoch))
            print(self.optimizer)
        running_loss = 0.
        dc_loss = 0.
        bceloss_func = nn.BCELoss()
        for e in range(start_epoch,epochs):
            print('epoch {} started'.format(e))
            if e == self.milestones[0]:
                self.schedule_lr()
            if e == self.milestones[1]:
                self.schedule_lr()
        #nothing changed below

I've changed nothing below.
The wired thing is that when I load whichever the weights of all of model, head and optimizer and then continue training, I got a very high CELoss. I tested it in a ipython notebook. When I random initialize a learner, I got CELoss around 45, but when I load a weights(which get a 93% acc on LFW) for the learner I got CELoss around 77.
I think the problem lies in the logic of class Arcface in Learner.py but I am not sure.
If anyone could help me figure out the issue?

@qq184861643 When I change ArcFace to my own head I have same issue like you. Random initial loss is ~45, but when I resume training from weights loss it start from ~50 (and lfw acc is 94%).

Hi
Unrelated to your question maybe, but i wanted to perform face verification , and the current arcface architecture does not perform really well on my dataset, is it possible to fine tune the model, with my custom dataset?
Thanks in advance

@boomberung Hi! have you figured it out how to solve this? I've tried several methods but still can't fix it

@DecentMakeover if we can't solve the resuming issue I don't think fine-tuning is possible

@qq184861643 No, but I found that even with the curve loss function, the network is learning normally. And I think the problem is with this line "loss_board = running_loss / self.board_loss_every"

@qq184861643 @boomberung Have you solved the problem about resuming?

Hi
Unrelated to your question maybe, but i wanted to perform face verification , and the current arcface architecture does not perform really well on my dataset, is it possible to fine tune the model, with my custom dataset?
Thanks in advance

Yes, it is possible. But, I can not get high accuracy when training on my custom dataset. Have you got any idea to solve it?


verify.py seemingly-boolean flags require arguments

Are the --debug, --toolgraph, --glossarygraph, --verify, and --color command-line parameters meant to require arguments?  Or, are they meant to behave with the store_true action?

debug, toolgraph, glossarygraph, verify and color are optional.

After the whitespace matter is addressed, the minify-output branch settles the question I had.  Thank you.


Only 1 bot

Hey, when i add my data, it only connects and spawns 1 bot, how can i change to 200 for example??
I added the command botLimit:100, etc and than I have no bots spawning...

@bonomok It spawns one bot because Agar.io patched FB bots... but you can use multiple FB accs. to have more than 1 bot.. (edit config.js like this:)
´´
accounts: [
{
c_user: "c_user",
datr: "datr",
xs: "xs"
},
{
c_user: "c_user",
datr: "datr",
xs: "xs"
}
],
´´

Oooh i see, but then each FB account will be leveling up, right?

Yes   slowly

Hmmm, i see, thats too bad, i loved when we were able to use our fb account in more then 1 pc, i leveled up like 40 levels in 1 day hahaha, anyway, thanks a lot, and thanks for the developers!!

Np, close this...

So we can run this 24/7 with 150 fb accs on an raspberry pi and sell the high lvl accs on ebay? :p @hassanila97

From what I've been hearing, they patched it on Facebook but not on Google Plus yet. If we find a way to do it on G+, then we could run multiple bots on one G+ account.

Yes, @ebil-recycle-bin but it will be hard work wasted.... They will patch it very easily,  so that's not the way to go.....      @christopherkardas  Yes, you can make a great business, if people don't find out how-to :P

@ebil-recycle-bin haha nice idea. I think theyve patched google plus too but we dont know about it because we never used g+ to start with. anyway lets suggest some ideas and why not create a skype group?

@suxosuxo123 A skype group is nice but it will be spammed and you can remove users but you cant ban :(

@hassanila97 In a p2p group you can xD We just need a server to host it on >.>


ENH: add new sphinx-external-toc package

This PR adds a new sphinx-external-toc package. The intention is to replicate the functionality of the sphinx-external-toc Python package, for later plumbing into MyST-CLI and JupyterLab-MyST.
This PR:

Adds support for upgrading legacy ToCs
Adds support for book, article, and no-format ToCs
Implements ToC validation using JSON Schema

I was just wondering if this should be a separate package on executablebooks, since it isn't really MyST related...?

That's a good question. I think for now we keep it here because it will exclusively be used by myst-cli. Soon it will end up in jupyterlab-myst / jupyter-book, and at that time we can pull it out once the organisational structure is clearer?

@agoose77 looks like test are failing here. Are you working on that to get this ready to review?

agoose77 looks like test are failing here. Are you working on that to get this ready to review?

Typical! I just rebased it, so I'll check out what's regressed. I think it's to do with AJV. c.f. https://github.com/ajv-validator/ajv/pull/2389

I understand the TOC round-tripping issues a bit better. Thanks for the call @agoose77.
Plan we discussed:

merge the first version of sphinx-external-toc when tests pass here (@agoose77 can advise)
second PR (#957), which uses it and replaces the current reader is breaking because we are (potentially) round-tripping incorrectly. The current implementation is not as strict as the spec, and the writing can be wrong. We can either leave that for a bit, or have a fallback to the current implementation and a warning.
We should have a simpler format for internally reasoning about tocs (probably unist based!), that requires more though, especially about numbering. That thinking/proposal can happen any time, maybe @agoose77 can have a go.

This is no longer necessary, as we are using our own TOC


build(docker): build dependencies in a cacheable image layer

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
https://github.com/risingwavelabs/risingwave/issues/11378
The general idea is that before COPY the whole source code, which is not cacheable, we get the dependencies first.

Use cargo-chef to build rust dependencies
Use mvn dependency:go-offline to build java dependencies
Also split java into a separate build stage, so they can be parallelized. TODO: modify rust code do not rebuild java and vice versa.

Note: Now only local build has the cached layers. In order to speed up CI, further work needs to be done (https://github.com/risingwavelabs/risingwave/issues/7734#issuecomment-1448506846).
Note: It's still slow (~1000s on my mac) even dependencies are cached. Mainly because linking (with LTO) is slow.

Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

testing (test it works, not the cache) https://buildkite.com/risingwavelabs/docker/builds?branch=xxchan%2Fdocker

aarch64 is cached, but amd64 is not 🤪

It seems cache doesn't work very well (because of --target? https://github.com/moby/buildkit/issues/1515#issuecomment-730190775)

I think we can merge first. With mode=min (default`), it doesn't have any drawbacks, although the cache hit rate might not be ideal.

@BugenZhao merge?

Looks good


Shift counter value interpretation

Is shift amount argument going to be signed or unsigned? How do we interpret its value if it is negative?
What if shift amount is larger or equal to element width? The resulting value in that case may be set to some constant like -1 or 0. Or, like in base ISA, shift amount is taken modulo element's width?

The shift amount value interpretation will be the same as the RISC-V scalar ISA.
Explicitly, the shift amount is unsigned, the shift amount will be module the register's element width.

From specification (line 468)

Source operands can be of different widths, but with a difference of no more than a single factor of 2

Which vector registers width (src1, src2 or dst) is a modulo?
Please, reopen issue.

As in the scalar ISA:

In RV64I, only the low 6 bits of rs2 are considered for the shift amount.

The lower log2(src1 width) bits of rs2 will be used.

Conclusions:

maximum number of shifts is determined by the XLEN of the base platform, but not by the vector element size

RV32V cannot shift 64-bit elements
The same code on the same configuration for the same data will produce different results on platforms with different XLENs.

This issue can be closed when the spec is updated.


External libraries not detected by plugins?

I have two contracts in my repository that use external libraries. However only one of them shows this as an error in validations.json and its the only one that ends up in a warning when deploying/upgrading through the plugin. The other one simply works without any warning.
By looking at my code one of them uses the library with the using MyLib... keyword (this is the one that is detected), and the other one  just references it in the code by calling MyLibrary.function(... . Could this be an explanation of why I dont get a warning or its not detected as an error in validations at the time of compilation?
Another possible difference is that the one that does not trigger warning was first imported using forceImport, when it had the library already. The other one is just adding the library now. But not sure this has any impact.
Thanks!

Hi @julianmrodri, can you share what your libraries and calling contracts look like in both cases?

Sure you can take a look to this branch in our repo:  https://github.com/reserve-protocol/protocol/tree/3.0.0

The contract that seems to be working fine is: https://github.com/reserve-protocol/protocol/blob/3.0.0/contracts/p1/BasketHandler.sol
The one that is not triggering any warnings is: https://github.com/reserve-protocol/protocol/blob/3.0.0/contracts/p1/BackingManager.sol

Im doing some basic tests for deploying and upgrading proxies here: https://github.com/reserve-protocol/protocol/blob/3.0.0/test/Upgradeability.test.ts
Steps if you want to run this:
$ git clone git@github.com:reserve-protocol/protocol.git
$ git checkout 3.0.0
$ yarn
$ yarn compile
$ PROTO_IMPL=1 npx hardhat test test/Upgradeability.test.ts

I would be expecting warnings for both contracts but only one is being displayed.
Thanks a lot!

@ericglau I think I may have found what was causing this. I had the unsafe allow external library decorator at the top of the contract for the one that does not emit any warnings.  Completely forgot about it. My bad. I'll close the issue as soon as I confirm.


Method 1 (jim)

Generate random tickets
Distribute tickets randomly to coop members by email
Election app verifies ticket and deploys the votes anonymously
Association of member email and ticket destroyed after vote closing?
Map of ticket hashes votes/answer to each question on rchain
Provide website or interface to vote (2 options)

Dappy - download dappy
Tomislav (Metamask) - visit website
Command line voting -

Meta information would be how the members votes
4. Voter can update their vote
Import data into CSV file to count results (yes/no or integers) or tally in rholang

@jimscarver I trust you're no longer interested to pursue this, except inasmuch as it overlaps with https://github.com/rchain-community/liquid-democracy work.


:robot: Add tests for documented features

Describe the solution you'd like
We should have automated tests for things that are documented and expected to work.  Some recent examples where this could have been helpful were in #840, #924, and #959.

The scope of this card is a bit too big, we have to narrow it down a bit before taking it, and identify what's tested and what's not. We have also https://github.com/kairos-io/kairos/issues/436 on the same topic. Maybe this should be an epic to track all the issues instead

I'm fine with this being a meta task that we split out into different things.  There are now at least there things that I've seen that don't have tests at least, as far as I know that are in the first comment here.


Use libassimp binaries that link to the shared standard library

Built off git@github.com:NolaDonato/assimp.git master, commit 90afc43389b5829e407aab39c05ab7b8d1c72ed9
Using the shared clang c++ standard library.

GearVRf-DCO-1.0-Signed-off-by: Mihail Marinov<EMAIL_ADDRESS>

Planning to merge on Tuesday

Some of the pending changes in other repos may not work with top of trunk.


Vendr 2.0 version?

Are there any plans to release a version of this package for Vendr 2.0 / Umbraco 9+?
If so, would you know an ETA for this?

Yeah, I will probably look at making the package work on Vendr v2 / Umbraco v9 as well.
Not sure if the multi-target approach always will here, when using various part of the Vendr and Umbraco APIs.
I think @mattbrailsford would like to help with this and it could be a great use-case to test Vendr v2.

Hey all, I'm just in the process of porting Vendr.Checkout which I think will be a good indicator whether it's possible to multi target these types of packages, specifically where there are some front end views. I'll keep you posted, or you can keep and eye on the code for it here https://github.com/vendrhub/vendr-checkout/tree/feature/v2
Matt

HI Matt. That link above is going to a 404. Just wondering if we are any closer to a V2 version?

@sashashev the branch was renamed to v2/dev which is now the default branch: https://github.com/vendrhub/vendr-checkout/
I have worked on a multi-target version in the current v2/dev branch https://github.com/vendrcontrib/vendr-reviews/tree/v2/dev which should work with Vendr 2.0 on both Umbraco 8 and 9. Still missing a few parts in code to make it work on both Umbraco versions and some testing of the package.

@bjarnef Thank you for your feedback. Can you please confirm if Vendr Reviews is working in Umbraco v9 yet? I used it in our project, but there are a couple of errors.

@stefanie27 the current Vendr Reviews package won't work on Umbraco v9 since it was built for .NET Framework and Umbraco now is running on .NET Core/.NET5, but the v2 of the package shouldn't be far away.

HI Sorry to hassle but @bjarnef any updates on the reviews?

Hi all
Sorry for the long wait, but v2.0.0 is now available on https://our.umbraco.com/packages/website-utilities/vendr-reviews/ or as NuGet package https://www.nuget.org/packages/Vendr.contrib.reviews/
Note that Vendr 2.0 requires requires Umbraco 8.17.0+ or Umbraco 9.0.0+
Please let me know if you are experiencing some errors or have suggestions for improvement.
Happy holidays ⭐🎅🎄

Thanks Bjarne,
That’s awesome.
Happy Holidays to you also.
Regards,
Sasha Shevelev
managing director
e<EMAIL_ADDRESS>m 0400 200 533
webcoda pty ltd
206/35 buckingham street, surry hills, nsw 2010
t +61 2 9370 3636
w www.webcoda.com.auhttps://urldefense.proofpoint.com/v2/url?u=http-3A__www.webcoda.com.au_&d=DwMF-g&c=fP4tf--1dS0biCFlB0saz0I0kjO5v7-GLPtvShAo4cc&r=iH7JK2kObAP31Dk9cji4IS2psNVQPXxMQfxrYWSg55w&m=DwJNi1ZW-6H7TvCfjEbhReQR0ISfl9pLwOa1NGSB4q4&s=gaK5jV0mhJSw9ygpaWEW8nEg5PiHLAxmOPBAct9w98E&e=
Connect
CONFIDENTIALITY NOTICE
The information contained in this message is confidential, intended only for the use of the individual or the entity named as recipient. If the reader of this message is not that recipient, you are notified that any dissemination, distribution or copy of this message is strictly prohibited. If you have received this message in error, please immediately notify us by telephone on the number above. Your co-operation is appreciated.
From: Bjarne Fyrstenborg @.>
Sent: Thursday, 16 December 2021 1:52 AM
To: vendrcontrib/vendr-reviews @.>
Cc: Sasha Shevelev @.>; Mention @.>
Subject: Re: [vendrcontrib/vendr-reviews] Vendr 2.0 version? (#3)
Hi all
Sorry for the long wait, but v2.0.0 is now available on https://our.umbraco.com/packages/website-utilities/vendr-reviews/ or as NuGet package https://www.nuget.org/packages/Vendr.contrib.reviews/
Note that Vendr 2.0 requires requires Umbraco 8.17.0+ or Umbraco 9.0.0+
Please let me know if you are experiencing some errors or have suggestions for improvement.
Happy holidays ⭐🎅🎄
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/vendrcontrib/vendr-reviews/issues/3#issuecomment-994866092, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAXKX4RBISBDNRMTWMUNGP3URCTQJANCNFSM5CYAEKOQ.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


SQL error

frontend_1  | [2021-04-20 20:05:41 +0000] [9] [ERROR] Exception in ASGI application
frontend_1  | Traceback (most recent call last):
frontend_1  |   File "/usr/local/lib/python3.8/site-packages/uvicorn/protocols/http/httptools_impl.py", line 390, in run_asgi
frontend_1  |     result = await app(self.scope, self.receive, self.send)
frontend_1  |   File "/usr/local/lib/python3.8/site-packages/uvicorn/middleware/proxy_headers.py", line 45, in call
frontend_1  |     return await self.app(scope, receive, send)
frontend_1  |   File "/usr/local/lib/python3.8/site-packages/fastapi/applications.py", line 149, in call
frontend_1  |     await super().call(scope, receive, send)
frontend_1  |   File "/usr/local/lib/python3.8/site-packages/starlette/applications.py", line 102, in call
frontend_1  |     await self.middleware_stack(scope, receive, send)
frontend_1  |   File "/usr/local/lib/python3.8/site-packages/starlette/middleware/errors.py", line 181, in call
frontend_1  |     raise exc from None
frontend_1  |   File "/usr/local/lib/python3.8/site-packages/starlette/middleware/errors.py", line 159, in call
frontend_1  |     await self.app(scope, receive, _send)
frontend_1  |   File "/usr/local/lib/python3.8/site-packages/starlette/exceptions.py", line 82, in call
frontend_1  |     raise exc from None
frontend_1  |   File "/usr/local/lib/python3.8/site-packages/starlette/exceptions.py", line 71, in call
frontend_1  |     await self.app(scope, receive, sender)
frontend_1  |   File "/usr/local/lib/python3.8/site-packages/starlette/routing.py", line 550, in call
frontend_1  |     await route.handle(scope, receive, send)
frontend_1  |   File "/usr/local/lib/python3.8/site-packages/starlette/routing.py", line 227, in handle
frontend_1  |     await self.app(scope, receive, send)
frontend_1  |   File "/usr/local/lib/python3.8/site-packages/starlette/routing.py", line 41, in app
frontend_1  |     response = await func(request)
frontend_1  |   File "/usr/local/lib/python3.8/site-packages/fastapi/routing.py", line 147, in app
frontend_1  |     raw_response = await run_endpoint_function(
frontend_1  |   File "/usr/local/lib/python3.8/site-packages/fastapi/routing.py", line 101, in run_endpoint_function
frontend_1  |     return await dependant.call(**values)
frontend_1  |   File "/usr/src/app/stilio/frontend/main.py", line 46, in index
frontend_1  |     count = Torrent.total_torrent_count()
frontend_1  |   File "/usr/src/app/stilio/persistence/torrents/models.py", line 42, in total_torrent_count
frontend_1  |     count = cls.select().count()
frontend_1  |   File "/usr/local/lib/python3.8/site-packages/peewee.py", line 1845, in inner
frontend_1  |     return method(self, database, *args, **kwargs)
frontend_1  |   File "/usr/local/lib/python3.8/site-packages/peewee.py", line 2121, in count
frontend_1  |     return Select([clone], [fn.COUNT(SQL('1'))]).scalar(database)
frontend_1  |   File "/usr/local/lib/python3.8/site-packages/peewee.py", line 1845, in inner
frontend_1  |     return method(self, database, *args, **kwargs)
frontend_1  |   File "/usr/local/lib/python3.8/site-packages/peewee.py", line 2106, in scalar
frontend_1  |     row = self.tuples().peek(database)
frontend_1  |   File "/usr/local/lib/python3.8/site-packages/peewee.py", line 1845, in inner
frontend_1  |     return method(self, database, *args, **kwargs)
frontend_1  |   File "/usr/local/lib/python3.8/site-packages/peewee.py", line 2093, in peek
frontend_1  |     rows = self.execute(database)[:n]
frontend_1  |   File "/usr/local/lib/python3.8/site-packages/peewee.py", line 1845, in inner
frontend_1  |     return method(self, database, *args, **kwargs)
frontend_1  |   File "/usr/local/lib/python3.8/site-packages/peewee.py", line 1916, in execute
frontend_1  |     return self._execute(database)
frontend_1  |   File "/usr/local/lib/python3.8/site-packages/peewee.py", line 2087, in execute
frontend_1  |     cursor = database.execute(self)
frontend_1  |   File "/usr/local/lib/python3.8/site-packages/peewee.py", line 3070, in execute
frontend_1  |     return self.execute_sql(sql, params, commit=commit)
frontend_1  |   File "/usr/local/lib/python3.8/site-packages/peewee.py", line 3064, in execute_sql
frontend_1  |     self.commit()
frontend_1  |   File "/usr/local/lib/python3.8/site-packages/peewee.py", line 2831, in exit
frontend_1  |     reraise(new_type, new_type(exc_value, *exc_args), traceback)
frontend_1  |   File "/usr/local/lib/python3.8/site-packages/peewee.py", line 183, in reraise
frontend_1  |     raise value.with_traceback(tb)
frontend_1  |   File "/usr/local/lib/python3.8/site-packages/peewee.py", line 3057, in execute_sql
frontend_1  |     cursor.execute(sql, params or ())
frontend_1  | peewee.ProgrammingError: relation "torrent" does not exist
frontend_1  | LINE 1: SELECT COUNT(1) FROM (SELECT 1 FROM "torrent" AS "t1") AS "...
frontend_1  |                                             ^
frontend_1  |

Fixed this by doing docker-compose exec crawler python and running these commands:
from stilio.persistence.database import init
init()

Check this out, fix SQL error: #11

Fixed in #11.


Escaping LaTeX special chars

If your CSV file contains any special chars used in latex like & or % the resulting PDF file might not look as expected. Those characters must be escaped to e.g. \& or \%.
Sources:

https://tex.stackexchange.com/a/34586
http://www.cespedes.org/blog/85/how-to-escape-latex-special-characters

If your CSV file contains any special chars used in latex like & or % the resulting PDF file might not look as expected.

Can confirm.
The tool was originally intended for converting 'raw' CSV files (which might be created from a lab equipment) where the cells contain only numeric values, so I didn't take any precaution when it comes to special characters.
Nonetheless, I will try to solve this in future releases.
Should a whole file be checked for those characters or just a header (first row)?

This might be a minor security issue if you can't trust the CSV file, e.g. infinite loops like \def\x{\x}\x. However, in your use case this might not be an issue.
I vote to escape all cells in all rows.

This might be a minor security issue if you can't trust the CSV file, e.g. infinite loops like \def\x{\x}\x.

Thanks for pointing this out, but this is currently a low priority because of the assumption that CSVs are known/simple/machine generated.
If this kind of situation happens in a 'real-world problem', please open another issue and I'll see what can I do.
Commit f9d642681c413c96eed726008d0d9b8b1698e95f solves the problem with special characters, so I will close this issue.


Unable to upload a video

Describe the bug
The software does not allow to upload a video following the selection of a dataset.
To Reproduce
Steps to reproduce the behavior:

Go to load data
Click on select data and select the .csv file
Click on select video and select the mp4 file
Click on start processing

Expected behavior
The software should load data and video
Screenshots
The software allows to select only csv files when selecting a video.

Desktop (please complete the following information):

Windows 11 pro
10.0.22000

Thanks for the detailed information! Indeed, you have to create your own importer. Simply inherit from mad_gui.plugins.BaseImporter and make sure to set the property for the file types (see https://github.com/mad-lab-fau/mad-gui/blob/main/mad_gui/plugins/base.py#L43).
Also, you may want to take a look at this general information about plugins in the MaD GUI as well as this more detailed explanation regarding how to develop your own plugin (importer).
I think this should solve the issue. If so, please close the issue, otherwise please leave another comment :-)

Thanks for the reply! I don't quite know hot to use python (I was hoping for a faster solution) but I'll give it a try.

Ok, then it may be tricky. However, the "standalone" exe-file we provided is just an example, and you (or someone you collaborate with) would have to create a version for your needs anyway, e.g. for the annotations you want to make. Unfortunately, I cannot provide more help with the general python setup, but you'll find some hints here: https://mad-gui.readthedocs.io/en/latest/preparation.html

see 1.3.1 Installation for Development
use pip install mad_gui
then continue with 1.4 and 1.5


Upgrade checkout action from v1 to v2

Release notes here: https://github.com/actions/checkout/releases.

/skip-all


Suggestion: Update macOS build instructions to not need hardcoded opencv subversion

Tested on macOS Catalina 10.15.3 (19D76)
Manage to build, install and upscale
brew install llvm opencv
brew link --overwrite opencv

git clone https://github.com/DeadSix27/waifu2x-converter-cpp && cd waifu2x-converter-cpp

mkdir build
cd build

CMAKE_C_COMPILER=$(xcrun -find cc)
CMAKE_CXX_COMPILER=$(xcrun -find c++)

export OpenCV_DIR=/usr/local/opt/opencv
source "${OpenCV_DIR}/bin/setup_vars_opencv4.sh"

cmake -G 'Unix Makefiles' -DOPENCV_PREFIX=$OpenCV_DIR -DCMAKE_C_COMPILER=$CMAKE_C_COMPILER -DCMAKE_CXX_COMPILER=$CMAKE_CXX_COMPILER -DCMAKE_BUILD_TYPE=Release ..

make -j4
make install

Using export is comfort but can cause other programs works not properly so cannot recommend to non-programmer users.


Credential

Hello Team ,
I am trying to run this ionic project in local .
I need some credential details , you have this ?
firebase: {
apiKey: '',
authDomain: '',
databaseURL: '',
projectId: '',
storageBucket: '',
messagingSenderId: '',
appId: '',
measurementId: ''
}

you need to setup your own firebase...


chore(ci): use docker metadata action for metadata

This is @detiber's pr but "finished". It seems to be working fine on my fork but I am not too sure itll work completely. The "Signing" stage has not been tested but it seems to work
Jason's PR: https://github.com/centos-workstation/main/pull/16
Fixes: #27

Codacy is mad but renovate is going to fix this


Fixed failing CliTests by Setting Default Locale

Multiple tests in CliTest will fail on systems with a default locale other than English.
ArgParse4j localizes some parts of the validation error message. The tests assert the equality of the whole text. As a fix, I set the default locale to English in the setup of the tests.
FMPOV it is not necessary to save the former default locale and to switch it back after the tests because tests are executed in a separate JVM. Let me know, if you think different.

@fexbraun My default locale is de_DE.UTF-8 and those tests are working. Did you specifically run into problems with those tests?

Hi Jochen,
Yes, on a new machine with a new workspace these tests were failing.
My default locale is "de_DE" when the tests are executed within eclipse, and then they fail.
When I execute the tests via mvn test the default locale is "en_US" and the tests are fine.

Thanks for this PR! I've opted to reset the original default locale at the end of the test.


Draw Spotlight over activity, not DecorView

This probably isn't functionality wanted by many, so i made a fork which draws the spotlight overlay within the root view instead of the DecorView which means your custom target views don't have to worry about whether the nav buttons / app bar exists
This was useful for me, so it might be useful for others...
https://github.com/OliverCulleyDeLange/Spotlight
  implementation 'com.github.OliverCulleyDeLange:Spotlight:05480906cc'
Putting this as an issue here so people have a chance of finding it.

Thank you for sharing this.
I really appreciate your idea and might reimplement in your suggested way.

I added functionality to set a container of Spotlight as of the version of 2.0.0.
So, please check it out!


Add Siri Pydantic models

The client currently returns an XML byte string.
In a future update I would like to start returning python objects.
This will require the XML byte string to be parsed.
To do this I'm using a combination of pydantic and lxml.
I've included tests with various response types.
This change requires the addition of lxml as a dependency.

Codecov Report

Merging #17 (841624d) into main (ff37c08) will increase coverage by 1.24%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
+ Coverage   95.71%   96.96%   +1.24%
==========================================
  Files           8        9       +1
  Lines         257      362     +105
  Branches       42       57      +15
==========================================
+ Hits          246      351     +105
  Misses          9        9
  Partials        2        2

Impacted Files
Coverage Δ

bods_client/models/__init__.py
100.00% <100.00%> (ø)

bods_client/models/siri.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff37c08...841624d. Read the comment docs.


Doc guidance: Multiple commands on NFC tag

Hi there - apologies if this is the wrong pathway to raise such query.
I read in the README section under Card record format:

You can enable cross fade, shuffle, or repeat on a card-by-card basis by adding records to enable these features to the card.

The question I have is, how exactly do I do that?
What I'm looking to do is clear the queue and decide on a per-card basis whether to enable shuffle etc.
Is there any information anywhere that helps to provide guidance on how to do this?
Thanks

Hi @johnnyfleet. You can write multiple NDEF records to a card. Each record can have an instruction. The instruction possibilities are shown here. So for example you could have a card that has spotify:album:4hW2wvP51Myt7UIVTgSp4f as the first record and command:shuffle/on as the second.

Fantastic - that explained it. Apologies for the late reply. I only just attempted it and worked flawlessly.
For reference this is how it looked in NFC tools. I had to add a next command as well as it always played the same first song - so I wanted to truly have a new song each time I started.


Fix error that happens when clicking on some SizeAwareImages

The onClick prop is optional, so it can be undefined. If you click on an image without it provided, an error is printed in the console currently, so this stops that from happening.

/update-branch

/e2e-test

Triggering e2e testing with options:
<nil>

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/150987


pubKey invalid

Describe the bug
nostr.watch returning error but pubkey is in hex:
"pubkeyError": "pubkey is in npub format, should be hex",
To Reproduce
Steps to reproduce the behavior:

navigate to: https://nostr.watch/relay/nostr.azte.co
expand results and go to very bottom

Expected behavior
pubkey is valid, so would expect it to confirm
Screenshots

Desktop (please complete the following information):

OS: macos
Browser: chrome

I am not able to replicate, but I have a feeling the issue you are seeing is happening because pubkeyError is only set if there's an error, when the results are merged, the error is still there (in localStorage). Instead, I'll always set pubkeyError as a blank string so that subsequent checks will overwrite old results.

Usually very frequently, but I haven't had the opportunity to push these changes because I'm I have been preparing for other things.


File only have a ERROR status

Hi there,
I'm interesting in your module, but it don't seem to work on the file.
The folder are ok, but for the file with debug :
IndexStatus.ERROR
WorktreeStatus.ERROR
MergeStatus.ERROR
To be able to use it, I need to put in in usr/share/nautilus-python/extensions, it won't work in my local.

After many tests, it seems ok with file or folder, but only on the folder with the .git, not on the subfolder.

Hi! Thanks for letting me know about the problem.
What version of nautilus are you using?

I'm using the 3.20.3.
But that weird, today all the folder are working, I didn't touch anything.
Is there a sort of cache in nautilus ?

& today it's only working with the first level of the git folder, it's strange.

Sorry for the radio silence. Are you still having this problem?
I have a new Ubuntu install on a new machine with Nautilus 3.26 and am not able to reproduce any problems like this.
I did  notice I had a few undocumented dependencies that I have now added to the README, but I suppose you must have had them all if things worked for you at all.

Closing due to inability to reproduce on latest version of Nautilus. Let me know if you're still having problems!


Ansible 2.11

Motivation for this change
https://docs.ansible.com/ansible-core/devel/roadmap/ROADMAP_2_11.html
And as announced in #122670 the 2.11 release is ansible-core. :shrug:
I'm so close to just install Ansible via direnv/pip...
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build ansible


Add SDL draw unit support to cmake

Use cmake -Bbuild -GNinja -DLV_USE_DRAW_SDL=ON then ninja -Cbuild
Note, install it via sudo apt install libsdl2-image-dev or brew install sdl2_image
Depends on #134

Please document this option in the README.

Thanks!


⚠ GitLab Server has degraded performance

In 5c682f0, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 6415 ms

Resolved: GitLab Server performance has improved in b365b65.


docs(animation): add callbacks documentation

I used console.warn to log the callbacks (which is what protractor can read by default) and filter all the messages to see if there is any from those callbacks. I haven't found a smarter way for this use case.

I've request a few small fixes. Otherwise looks good.


Define a road-map to drop python2 support

I'm not saying that python2 support should be dropped soon, but I think that we should define a road-map, and make an official announcement  to aware spyder users of when and how python2 support will be end.
Reasons:

python2.7 support will end in 2020 https://pythonclock.org/
Some libraries are dropping python2 support (ipython)  http://www.python3statement.org/
the majority of libraries already support python3 http://py3readiness.org/
there is a big technical debt in spyder related of python2 support (the utility py3compat is used in +50 files)
the CI time will drop to ~almost~ the half

I think we could follow what ipython did:

Drop python2 support in a major release (5.0)
Continue buxfixes in 4.0 with python2 support until 2020 (EOL of python2.7)
Maybe we could join http://www.python3statement.org/

Also I think that dropping python2 support shouldn't be too much harm to the end user, although they won't be able to install spyder in a 2.7 environment, they could change the python executable in the preferences and continue running 2.7 code.

Let's see how things evolve after IPython 6 (which is Python 3 only). I think we can revisit this at the end of the year.

@ccordoba12 This is just my opinion. I have no idea if this makes things more difficult or easier for you, but....
I think dropping python 2 in Spyder 4 would be great for development and users wouldn't be confused with dropping support because it's a major version.  I not suggesting that we change a bunch of code to make python 2 not work in Python 4, but just not support it.
I got bit by py2 here:
https://github.com/spyder-ide/spyder-kernels/issues/14
If Spyder 4 is not going to be released until 2019, python 2 will have less then a year of support anyway.
Supporting Spyder 3 with security for less than a year after Spyder 4 is out might be less work then supporting unsupported python 2 in Spyder 4 after Jan 2020 or needing to release a quick Spyder 5 with dropping python 2 as it's major feature.

I think dropping python 2 in Spyder 4 would be great

The problem is the big refactoring we're planning for Spyder 4 (and that now lives in the split-plugins branch) will make really, really hard to keep maintaining our 3 series with bugfixes until 2020.
So we decided to leave Python 2 support in Spyder 4 and to release Spyder 5 at the end of 2019 with the single change of being Python 3 only.

Yeah, that's our main reason right, that Spyder 4 is working just fine in Python 2.


Fewer DDIC type references

char12
char10
char70
char4

BTW, did you run into any troubles with the replaced DDIC types?

no trouble, would just like to avoid DDIC references when possible
the data element "CHAR12" is known in a ABAP system, but without an abap system its not possible to know what CHAR12 is(in the general case), ie. its not possible to statically determine the type without a ABAP system
need to increase the amount of statically determined types in order to be able to do stuff like automatic up-port and downport

OK, since you are probably not going to get rid of the unnecessary formatting changes and I see no flaws in your commits, can I merge?


WIP: Parallel example

The end result for this PR will be that Canopy is fully configurable globally AND with a context/config to enable multiple instances with different configuration to co-exist in the same process; in order to support parallel running of everything.

Sounds great.  Let me know when you feel like its done, I will accept the PR and then test it and make any changes that I need to.

I'm stopping for the evening; I've started the pattern of replacing -B with -C or -Conf where appropriate and I've put everything into a config types. I don't mind help going from here.


Remove some unnecessary dependencies

These are not actually used anywhere. The build was failing on my system on an 'openblas' link error, and this conveniently fixes that :-).

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Ahh sorry, forgot about these when removing PQ.

@hlinnaka if you can sign the CLA I'll be happy to merge

H @hlinnaka, this PR is blocked by the CLA. It's a company requirement, as soon as you sign it we can merge it :)
Thanks.

This was done in another PR


adjusts stack size to address OOM error when running tests

adjusts javaOptions by bumping stack size to 2048K
fixes #993

Codecov Report

Merging #994 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #994   +/-   ##
=======================================
  Coverage   83.99%   83.99%
=======================================
  Files          50       50
  Lines         856      856
  Branches       51       51
=======================================
  Hits          719      719
  Misses        137      137

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bc96e3...a8c2b8c. Read the comment docs.

Thanks @arron-green! This LGTM.


Change boot logo

Framebuffer currently use the vanilla Tux logo on boot, we can cnange it to show NodeOS logo. Also, just today has been submitted a patch to Linux kernel to allow full-screen logos, that would be cool... :-)

@piranna Looking into this!

@piranna  would you like a startup screen similar to that of Ubuntu?

@piranna Looking into this!

Cool! You have the logo sources on the NodeOS/media repository :-)

@piranna would you like a startup screen similar to that of Ubuntu?

This is somewhat conplicated, but I've read about it's possible to add full
screen logos that mimic this, but I'm not sure it it's just an offtree
patch. One step at a time, let's change first the logo and later we'll see
about the full screen one ;-)

@piranna it would be easier to go straight to that as these are actually completely different systems. Swapping the logo is very easy but you need to recompile the kernel. What kernel are we using right now with NodeOS? (i haven't checked)

Vanilla 4.4.3 from kernel.org. If you could provide a patch or better a script to generate it directly from an image it would be awesome :-) 2 and 16 colors versions are just enought.

it would be easier to go straight to that as these are actually completely different systems.

Are you talking about plymouth ?

We could set the kernel output to quiet (this comes with the bonus of speeding the boot process up ) and draw the image (or animation) with the init. I think, this is also how most of the android distributers do it...

We could set the kernel output to quiet (this comes with the bonus of
speeding the boot process up ) and draw the image (or animation) with the
init. I think, this is also how most of the android distributers do it...

Boot takes only about 5 seconds when running on real hardware or with KVM
enabled and most of the time it's about kernel loading, so it doesn't make
sense to show an splash on init. Kernel boot logo or fullscreen boot logo
makes sense since they are shown as soon as framebuffer is ready, almost at
the start of kernel loading.

Hm... If you want an animation (not just the static image) you can start the animation in the bootloader (the kernel has to bequiet) like it is done with many embedded systems...

I'm honestly only interested on change framebuffer penguin for NodeOS logo,
but use the bootloader is a good alternative, syslinux support it... :-)
El 27/2/2016 10:05, "John Green"<EMAIL_ADDRESS>escribió:

Hm... If you want an animation (not just the static image) you can start
the animation in the bootloader (the kernel has to bequiet) like it is done
with many embedded systems...
—
Reply to this email directly or view it on GitHub
https://github.com/NodeOS/NodeOS/issues/156#issuecomment-189608656.

We could set the kernel output to quiet (this comes with the bonus of speeding the boot process up ) and draw the image (or animation) with the init. I think, this is also how most of the android distributers do it...

I had something similar in mind for the full screen. Making the kernel quiet and rendering to the frame buffer the image instead of  the kernel using it for output.
@piranna did you want a kernel patch file for replacing tux? I can do that

We could set the kernel output to quiet (this comes with the bonus of
speeding the boot process up ) and draw the image (or animation) with the
init. I think, this is also how most of the android distributers do it...

I had something similar in mind for the full screen. Making the kernel
quiet and rendering to the frame buffer the image instead of the kernel
using it for output.

Yeah, but peobably it's better to do it on the bootloader since it start
before. I don't believe anyone support animations, though...

@piranna did you want a kernel patch file for replacing tux? I can do that

Yeah! But instead a patch, it would e better a script that generate that
patch so we can integrate it better in NodeOS build steps. If you write
down the steps that you follow, we could do the script later as has been
done with noGUI... :-) Don't worry, an independent project is not needed
here ;-)

Since Syslinux supports (full screen) splash screens, it shouldn't bee too hard to change the splash screen... I asked my friends over at the arch forums if it is also possible to use anomated gifs (if you want to add something like a process bar or whatever)... still waiting for a response :/

:D status? Was anyone able to pick this up?

There was some progress here and was almost working, but don't remember how it's now... Could someone refresh my memory?

@piranna Diffs have to be compressed into one file and the Logo.ppm has to be refreshed since it's to small. I'll do that asap.

Ok, something's pretty sad.

How have you done it? It's impossible it get's so ugly... What steps have you followed to do the ppm file?

The one you posted
pngtopnm logo.png | ppmquant -fs223| pnmtoplainpnm > logo_linux_clut224.ppm
cp logo_linux_clut224.ppm /usr/src/linux/drivers/video/logo/

How did you create the png image? Does it looks good? Can you attach it
here?
El 9/8/2016 14:50, "John Green"<EMAIL_ADDRESS>escribió:

The one you posted
http://web.archive.org/web/20140707092448/http://sumanprasanna.wordpress.com/2012/12/11/how-to-change-your-boot-logo-in-linux-kernel
pngtopnm logo.png | ppmquant -fs223| pnmtoplainpnm > logo_linux_clut224.ppm
cp logo_linux_clut224.ppm /usr/src/linux/drivers/video/logo/
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NodeOS/NodeOS/issues/156#issuecomment-238542521, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAgfvnq4uoJWD-9vupnnM5beK514EFKaks5qeHeLgaJpZM4FRa7M
.

I use gimp to create the png.

Try to check the output of each piped command to see where is failing.
El 9/8/2016 15:10, "John Green"<EMAIL_ADDRESS>escribió:

I use gimp to create the png.
[image: nodeos]
https://cloud.githubusercontent.com/assets/9163037/17517343/53b953ca-5e43-11e6-99ce-1e43a5a36345.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NodeOS/NodeOS/issues/156#issuecomment-238547528, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAgfvrO_xYTwmA70FIe9mooDK8VkQ4Moks5qeHxVgaJpZM4FRa7M
.

Wait: are you using anti-aliasing? That probably is the reason why the png
image has no sharp borders, because the aliasing is increasing the numbers
of colours... It should be enough a palette of just three colours, I set
them specially.
Is there any command line svg raster so we don't need Gimp?
El 9/8/2016 15:22<EMAIL_ADDRESS><EMAIL_ADDRESS>escribió:

Try to check the output of each piped command to see where is failing.
El 9/8/2016 15:10, "John Green"<EMAIL_ADDRESS>escribió:

I use gimp to create the png.
[image: nodeos]
https://cloud.githubusercontent.com/assets/9163037/17517343/53b953ca-5e43-11e6-99ce-1e43a5a36345.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NodeOS/NodeOS/issues/156#issuecomment-238547528, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAgfvrO_xYTwmA70FIe9mooDK8VkQ4Moks5qeHxVgaJpZM4FRa7M
.

http://graphicdesign.stackexchange.com/a/50850
Seems here there are a solution, there's an attribute that can be added to
the SVG file to notify borders should be sharp always and Gimp will respect
that, could you be able to take a look and if so do a pull-request on the
media repo?
El 9/8/2016 15:28<EMAIL_ADDRESS><EMAIL_ADDRESS>escribió:

Wait: are you using anti-aliasing? That probably is the reason why the png
image has no sharp borders, because the aliasing is increasing the numbers
of colours... It should be enough a palette of just three colours, I set
them specially.
Is there any command line svg raster so we don't need Gimp?
El 9/8/2016 15:22<EMAIL_ADDRESS><EMAIL_ADDRESS>escribió:

Try to check the output of each piped command to see where is failing.
El 9/8/2016 15:10, "John Green"<EMAIL_ADDRESS>escribió:

I use gimp to create the png.
[image: nodeos]
https://cloud.githubusercontent.com/assets/9163037/17517343/53b953ca-5e43-11e6-99ce-1e43a5a36345.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NodeOS/NodeOS/issues/156#issuecomment-238547528,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAgfvrO_xYTwmA70FIe9mooDK8VkQ4Moks5qeHxVgaJpZM4FRa7M
.

Sure !

PR done

Did you get any advance creating the patch?
El 9/8/2016 16:08, "John Green"<EMAIL_ADDRESS>escribió:

PR done
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NodeOS/NodeOS/issues/156#issuecomment-238564252, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAgfvgKGmzTXZ6rYFHl9chnO_71qLFvWks5qeInLgaJpZM4FRa7M
.

Yeah, I think I'll push it tomorrow... I'm not sure though if the Download Manager supports patches that create new files ...

It should... and if not, now we have something to do ;-)
El 9/8/2016 21:18, "John Green"<EMAIL_ADDRESS>escribió:

Yeah, I think I'll push it tomorrow... I'm not sure though if the Download
Manager supports patches that create new files ...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NodeOS/NodeOS/issues/156#issuecomment-238660961, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAgfvqypnwz1FtSl0AeKLdoEIIgugf3Hks5qeNJvgaJpZM4FRa7M
.

@piranna I like the new "level of difficulty" tags you've added! Excellent work

You are welcome ^^
El 10/8/2016 7:21, "Lite McFish"<EMAIL_ADDRESS>escribió:

@piranna https://github.com/piranna I like the new "level of
difficulty" tags you've added! Excellent work
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NodeOS/NodeOS/issues/156#issuecomment-238768580, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAgfvv2QnCMmB2LBdDU1qwY8bsbdidQaks5qeV_PgaJpZM4FRa7M
.

Clossing since this is already in master since a while.


Remove missing CSP_NODE_MAC in pycsp.c

Seems like CSP_NODE_MAC was removed in csp_rtable.h but not in the python bindings file in commit e39c97cfa6adf77249f0494414cc3bb5e803e701. Was causing build errors.

Thanks


[ISSUE #231]Fix run DLedger Server with jar can't find Main class

close #231

Fix run DLedger Server with jar can't find Main class

@mxsm Good catch! We will release the next version ASAP.


Not able to login using wrangler2 login

🐛 Bug report
Describe the bug
OAuth callback error when trying to use wrangler2 login command.
Installed wrangler via brew but the same issue occurs even when installed via npm.
Reproduce the bug
A list of steps to reproduce the bug.

Install wrangler
Run 'wrangler2 login'
See error

Expected behavior
The login should be successfull.
Environment and versions
Fill out the following information about your environment.

operating system:
macOS 13.1 M1 MacBook Air
output of wrangler -v:
wrangler 2.6.2
output of node -v:
v19.3.0
content of wrangler.toml:

name = "publiclinkrobot"
main = "src/index.ts"
compatibility_date = "2022-08-07"

[vars]
FQDN = "https://public-link-bot-dp.herokuapp.com"

Hey,
I get this error in my terminal:
divkix@Divs: ~ [🐏 11GiB/16GiB]
❯ wrangler2 login
 ⛅ wrangler 2.9.0
-------------------
Attempting to login via OAuth...
Opening a link in your default browser: https://dash.cloudflare.com/oauth2/auth?response_type=code&client_id=54d11594-84e4-41aa-b438-e81b8fa78ee7&redirect_uri=http%3A%2F%2Flocalhost%3A8976%2Foauth%2Fcallback&scope=account%3Aread%20user%3Aread%20workers%3Awrite%20workers_kv%3Awrite%20workers_routes%3Awrite%20workers_scripts%3Awrite%20workers_tail%3Aread%20d1%3Awrite%20pages%3Awrite%20zone%3Aread%20offline_access&state=lfWX4ijNy_cz47NlpGTIj.dL42e-1jk6&code_challenge=BFTeV9shVyFnxuUpp_8v9Xq1472O_G5LYEuRXw1AehM&code_challenge_method=S256
/opt/homebrew/Cellar/cloudflare-wrangler2/2.9.0/libexec/lib/node_modules/wrangler/wrangler-dist/cli.js:26719
            throw a;
            ^

TypeError: fetch failed
    at fetch10 (/opt/homebrew/Cellar/cloudflare-wrangler2/2.9.0/libexec/lib/node_modules/wrangler/wrangler-dist/cli.js:13582:17)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async fetchAuthToken (/opt/homebrew/Cellar/cloudflare-wrangler2/2.9.0/libexec/lib/node_modules/wrangler/wrangler-dist/cli.js:124311:10)
    at async exchangeAuthCodeForAccessToken (/opt/homebrew/Cellar/cloudflare-wrangler2/2.9.0/libexec/lib/node_modules/wrangler/wrangler-dist/cli.js:123980:20)
    at async Server.<anonymous> (/opt/homebrew/Cellar/cloudflare-wrangler2/2.9.0/libexec/lib/node_modules/wrangler/wrangler-dist/cli.js:124135:30) {
  cause: Error: unable to get local issuer certificate
      at TLSSocket.onConnectSecure (node:_tls_wrap:1540:34)
      at TLSSocket.emit (node:events:512:28)
      at TLSSocket._finishInit (node:_tls_wrap:959:8)
      at ssl.onhandshakedone (node:_tls_wrap:743:12) {
    code: 'UNABLE_TO_GET_ISSUER_CERT_LOCALLY'
  }
}

Node.js v19.5.0

and this in my browser:

I installed wrangler from homebrew.

Thanks for the detailed log! A couple more questions to help us narrow this down:

Do you have a VPN/proxy or similar running?
Can you reproduce this on other WiFi networks?

No, I do not have a VPN/proxy running while trying to use this command. Also, I've tried it on other wifi networks and it still ends up the same way.

Updated to wrangler v2.10.0 and seems that this issue is fixed.


fixing locator that changed with Spring 19 pre-release

Critical Changes
Changes
Issues Closed
New Metadata
Deleted Metadata

Closing since this was already fixed in #4019


Deprecate @libp2p/mplex tracking issue

As a part of the wider initiative to deprecate mplex we need to:

[x] Add a deprecation notice the @libp2p/mplex README.
[x] Add a deprecation notice to the Multiplexing section of the GETTING_STARTED.
[x] Deprecate the@libp2p/mplex module on npm
[ ] Remove all tests using mplex
[x] Remove all references in the docs to mplex

Remove all tests using mplex

The missing piece here is to replace mplex with yamux where a muxer is required by the test.
The thing about mplex is that it's in this repo which means when we next release a major of @libp2p/interfaces we don't need to solve the chicken and egg problem of the tests here not passing (and as such the release not happening) until yamux upgrades, which can't happen until the tests here pass (and the release happening).
I think mplex will still need to be used in tests here for the foreseeable future.

The missing piece here is to replace mplex with yamux where a muxer is required by the test.

I should have articulated it this way, but post-https://github.com/libp2p/js-libp2p/issues/1578 this should be the case, so our tests are currently testing against yamux to my understanding. Therefore, it should be safe to remove mplex from those tests.

Mplex is marked deprecated so there's not much else to do here.
It's still in the repo and being tested/updated as it's very low-maintenance to do so.  If it becomes high-maintenance it'll be removed but that's not happened yet.


What happens to auth.sessions / refresh_tokens on the server?

I'm trying to understand persistence Supabase Auth in this discussion: https://github.com/supabase/supabase/discussions/11100
So far it's quite lonely, I'm only answering myself. One question I cannot find an answer to is what happens with the auth.sessions / refresh_tokens on the server?

If these are cleaned up at regular intervals, when exactly and how can we control this? This would be pretty much the most important setting on the dashboard, much more important than the "JWT expiry limit".

If these are not cleaned up then how do people use Supabase in production? I mean these tables would grow indefinitely with mostly useless leftover data. Over time, performance will degrade and you'll pay for this in storage costs.

Can someone from Supabase comment on this? I've spent a few hours debugging the client behaviour on my own, it'd be so nice if someone could shed some light on the server part.

Hey @hyperknot,
We have a PR open to deal with this #875. It should be going in fairly soon.
We use GoTrue for app.supabase.com and aside from having somewhat large storage we do not experience any performance issues because of the large tables. In general you shouldn't worry about an implementation detail like this for your app.
I'll transfer this issue to the main Supabase repo and convert it as a discussion.


Use --no-cache-dir flag to pip in Dockerfiles, to save space

Using "--no-cache-dir" flag in pip install ,make sure dowloaded packages
by pip don't cached on system . This is a best practise which make sure
to fetch ftom repo instead of using local cached one . Further , in case
of Docker Containers , by restricing caching , we can reduce image size.
In term of stats , it depends upon the number of python packages
multiplied by their respective size . e.g for heavy packages with a lot
of dependencies it reduce a lot by don't caching pip packages.
Further , more detail information can be found at
https://medium.com/sciforce/strategies-of-docker-images-optimization-2ca9cc5719b6
Signed-off-by: Pratik Raj<EMAIL_ADDRESS>

Hi,
The container is not so big, but for future use it will good to have it.
Best regards,
Eli Battat.


Fixes #307. Upgraded slim to 3.0.3 (was 2.1.0)

As Asciidoctor currently depends on sth slim 2.0.0-ish I chose to only upgrade to slim 2.1.0.
I added only a very basic test to see if the slim template is used at all.
It would probably be better to somehow check that really slim 2.1.0 is used...

I reviewed the changelog for Slim, and did some testing, and have determined that it would be fine to upgrade to Slim 3.0.3.
Here are the only two breaking changes:

Drop support for Ruby 1.8.7
Deprecate =', ==' and tag' syntax for trailing whitespace. Use =< etc. instead.

The first one is not really an issue since Slim 2.1.0 dropped support for jruby18 mode. We don't use this mode by default (and no one else should), so it's a non-issue.
The second one does not break existing templates, it merely issues a warning. So it's an ideal opportunity to notify users to upgrade their templates.
Let's move to Slim 3.0.3.

Is slim 3.0.3 (or 3.0.6 respectively) also a candidate for 1.5.3?

I think we can move to Slim in 1.5.3. We don't care about Ruby 1.8.7 support in this environment and we've long since fixed the templates that used the old syntax. Since it poses no risk, I think it's smart to switch to it now.

+1
On Mon, Nov 2, 2015 at 3:38 AM, Dan Allen<EMAIL_ADDRESS>wrote:

I think we can move to Slim in 1.5.3. We don't care about Ruby 1.8.7
support in this environment and we've long since fixed the templates that
used the old syntax. Since it poses no risk, I think it's smart to switch
to it now.
—
Reply to this email directly or view it on GitHub
https://github.com/asciidoctor/asciidoctorj/pull/309#issuecomment-152983898
.

--
Jason Porter
http://en.gravatar.com/lightguardjp


gtk: Cleanup template related functions

Fixes #1189

That's of course not backwards compatible so don't backport that :)

That's of course not backwards compatible so don't backport that :)

yes, that is why i didn't add the corresponding label


Bollinger Bands and Moving Average selections are more specific to avoid conflicts

Selections are now made on element type as well as class name, to reduce the chance of selecting an unintended element. Resolves #235.
There are also a few minor changes to the style for consistency/efficiency.
Another possible solution to #235 would be to use a different class name for moving-average in one of the components.

Looks good to me.
As a general point, I am not sure that we really need to ensure that our series can co-exist within the same parent g element. It is quite straightforward to just append a new container as the parent for a series.

As a general point, I am not sure that we really need to ensure that our series can co-exist within the same parent g element. It is quite straightforward to just append a new container as the parent for a series.

Agreed. However, if I understand correctly, the Chart Builder component will behave this way - all components will be called on the same parent element (the plot area)? Maybe Chart Builder could also create a group for each component and call that component on its own group only (not the plot area)?


AttributeError: 'tensorflow.python.framework.ops.EagerTensor' object has no attribute 'is_fully_defined'

Please make sure that this is a bug. As per our
GitHub Policy,
we only address code/doc bugs, performance issues, feature requests and
build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):windows10
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary):binary
TensorFlow version (use command below):2.4.0
Python version:3.7.6
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version:11.0
GPU model and memory:24GB

You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with:

TF 1.0: python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"

Describe the current behavior
Can not reshapes SparseTensor
Describe the expected behavior
Reshapes a SparseTensor
Standalone code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate
the problem. If possible, please share a link to Colab/Jupyter/any notebook.
import tensorflow as tf

sp = tf.SparseTensor([[1,1],[2,2]],[1.,2.],[4,4])
new_sp = tf.sparse.reshape(sp,[8,-1])

Other info / logs Include any logs or source code that would be helpful to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached.
Traceback (most recent call last):
File "C:\Program Files\Python37\lib\site-packages\tensorflow\python\ops\sparse_ops.py", line 902, in sparse_reshape
and sp_input.shape.is_fully_defined()):
AttributeError: 'tensorflow.python.framework.ops.EagerTensor' object has no attribute 'is_fully_defined'

@manakanemu
I have tried in colab with TF-GPU version 2.4 and i am not seeing any issue. Please, find the gist here.Thanks!

Sorry, I found this problem was caused by myself. I used "pickle" to load a SparseTensor, which caused the init function not be executed, so the correct SparseTensor._dense_shape_default was not obtained.

@manakanemu
Is this still an issue? Please, close this thread if your issue was resolved. Thanks!


Screenshot Folder should be configureable

I should be able to select a directory on my computer where my screenshots will save to.

Merged this and should be live once https://github.com/runelite/plugin-hub/pull/5180 is merged.
I'm not too happy about the fact that there's no easy way (as far as I can tell) to use the file picker to set the directory in the config panel. I might want to create a feature request for this, if one doesn't already exist.


enhancement/toc: Don't generate empty toc (fix #57)

When compiling, one file are created who contains number of element in
toc (because we only know it at the end of the first compilation), so
at the second he will read the file and find out if he should print
the toc.
Note: need cash clean because I use new package

Closed because the feature is implemented zmd side.


20180220 celery

AMLNG-XXX
Description
Research and Choose message broker, Implement Celery with message broker
Acceptance Criteria
Implement Celery with celery
able to do notification emails
How to test code
Redis 3.* Server needs be running
Change EMAIL_BACKEND in settings.py to django.core.mail.backends.smtp.EmailBackend
Will Require Multiple Terminal Windows to test
Terminal Window/tab 1 (Redis Server)
redis-server

Terminal Window/tab 2 (Debug Email Server)
make run_debug_email_server

Terminal Window/tab 3 (Celery Worker)
make celery_worker

Terminal Window/tab 4 (running email notification task)
>> make dev
>> python manage.py runscript notification_email_async
2018-02-20 17:23:54,706 - INFO - notification_email_async - Email Notification Group Results: <GroupResult: f110627e-64bf-4f69-a072-639d8bb2d47d [a9025190-1bf4-42df-b946-99247639d777, 88f62eba-0f95-4b67-9cfa-bf9eb74a51ad, e604d2c3-b908-434f-be5a-39796ff026f9, 9b849aea-a69e-4d32-bc32-dfb2e1b6363a, 46f67816-3a14-4689-bafc-fe3318ec77db, ac6690b9-c176-4ba1-9a1f-ce850cfd8aa2, e91378f6-09cb-47a1-a606-547206881cf2, 43841d27-cfde-4b94-8e4d-fb2eaeaa07c6]>
2018-02-20 17:23:55,256 - INFO - notification_email_async - 9b849aea-a69e-4d32-bc32-dfb2e1b6363a - 4 New Notifications for username: pmurt [71]
2018-02-20 17:23:55,256 - INFO - notification_email_async - 9b849aea-a69e-4d32-bc32-dfb2e1b6363a - 10 New Notifications for username: hodor [136]
2018-02-20 17:23:55,256 - INFO - notification_email_async - 9b849aea-a69e-4d32-bc32-dfb2e1b6363a - 28 New Notifications for username: betaraybill [339]
2018-02-20 17:23:55,413 - INFO - notification_email_async - e91378f6-09cb-47a1-a606-547206881cf2 - 4 New Notifications for username: tparsons [585]
2018-02-20 17:23:55,413 - INFO - notification_email_async - e91378f6-09cb-47a1-a606-547206881cf2 - 4 New Notifications for username: jsnow [50]
2018-02-20 17:23:55,413 - INFO - notification_email_async - e91378f6-09cb-47a1-a606-547206881cf2 - 4 New Notifications for username: charrington [55]
2018-02-20 17:23:56,503 - INFO - notification_email_async - 43841d27-cfde-4b94-8e4d-fb2eaeaa07c6 - 4 New Notifications for username: johnson [1782]
2018-02-20 17:23:59,577 - INFO - notification_email_async - 46f67816-3a14-4689-bafc-fe3318ec77db - 16 New Notifications for username: jones [4408]
2018-02-20 17:23:59,578 - INFO - notification_email_async - 46f67816-3a14-4689-bafc-fe3318ec77db - 4 New Notifications for username: tammy [57]
2018-02-20 17:23:59,578 - INFO - notification_email_async - 46f67816-3a14-4689-bafc-fe3318ec77db - 31 New Notifications for username: rutherford [395]
2018-02-20 17:23:59,989 - INFO - notification_email_async - a9025190-1bf4-42df-b946-99247639d777 - 52 New Notifications for username: bigbrother [2760]
2018-02-20 17:23:59,990 - INFO - notification_email_async - a9025190-1bf4-42df-b946-99247639d777 - 7 New Notifications for username: bigbrother2 [237]
2018-02-20 17:23:59,990 - INFO - notification_email_async - a9025190-1bf4-42df-b946-99247639d777 - 13 New Notifications for username: khaleesi [2287]
2018-02-20 17:24:00,033 - INFO - notification_email_async - ac6690b9-c176-4ba1-9a1f-ce850cfd8aa2 - 4 New Notifications for username: noah [2804]
2018-02-20 17:24:00,034 - INFO - notification_email_async - ac6690b9-c176-4ba1-9a1f-ce850cfd8aa2 - 24 New Notifications for username: syme [2232]
2018-02-20 17:24:00,034 - INFO - notification_email_async - ac6690b9-c176-4ba1-9a1f-ce850cfd8aa2 - 4 New Notifications for username: abe [282]
2018-02-20 17:24:00,619 - INFO - notification_email_async - e604d2c3-b908-434f-be5a-39796ff026f9 - 81 New Notifications for username: obrien [3003]
2018-02-20 17:24:00,620 - INFO - notification_email_async - e604d2c3-b908-434f-be5a-39796ff026f9 - 59 New Notifications for username: david [1088]
2018-02-20 17:24:00,620 - INFO - notification_email_async - e604d2c3-b908-434f-be5a-39796ff026f9 - 40 New Notifications for username: aaronson [1816]
2018-02-20 17:24:02,336 - INFO - notification_email_async - 88f62eba-0f95-4b67-9cfa-bf9eb74a51ad - 82 New Notifications for username: bettafish [5495]
2018-02-20 17:24:02,336 - INFO - notification_email_async - 88f62eba-0f95-4b67-9cfa-bf9eb74a51ad - 49 New Notifications for username: wsmith [998]
2018-02-20 17:24:02,336 - INFO - notification_email_async - 88f62eba-0f95-4b67-9cfa-bf9eb74a51ad - 89 New Notifications for username: julia [1137]
2018-02-20 17:24:02,337 - INFO - notification_email_async - Email Notification Aync tasks took 7693
2018-02-20 17:24:02,337 - INFO - notification_email_async - Sum of task times: 32017

>> python manage.py runscript notification_email_async

2018-02-20 17:19:58,242 - INFO - notification_email_async - Email Notification Group Results: <GroupResult: 70cb1159-05f5-4386-8373-e6024ee4f346 [5a173c77-d250-426a-a574-fe70b660db2a, 82dca7f3-0dff-44ad-ab99-2e8c89aee860, 06a9607d-1e99-4763-812d-a2cda595a7e8, dad11983-ff04-469b-abe9-e43de65045ba, bd007501-1fcb-40a6-975d-4342f47d36f7, 238ea107-0ecd-4ce2-a4e5-d1b6d22b2e90, ac0fb91f-1c49-4693-ac96-bae4cc6e7e06, 332d1b4d-42ad-45b4-a94e-6f1905784c4e]>
2018-02-20 17:19:58,745 - INFO - notification_email_async - 06a9607d-1e99-4763-812d-a2cda595a7e8 - No New Notifications for username: obrien [8]
2018-02-20 17:19:58,746 - INFO - notification_email_async - 06a9607d-1e99-4763-812d-a2cda595a7e8 - No New Notifications for username: david [3]
2018-02-20 17:19:58,746 - INFO - notification_email_async - 06a9607d-1e99-4763-812d-a2cda595a7e8 - No New Notifications for username: aaronson [3]
2018-02-20 17:19:58,746 - INFO - notification_email_async - dad11983-ff04-469b-abe9-e43de65045ba - No New Notifications for username: pmurt [10]
2018-02-20 17:19:58,747 - INFO - notification_email_async - dad11983-ff04-469b-abe9-e43de65045ba - No New Notifications for username: hodor [7]
2018-02-20 17:19:58,747 - INFO - notification_email_async - dad11983-ff04-469b-abe9-e43de65045ba - No New Notifications for username: betaraybill [7]
2018-02-20 17:19:58,748 - INFO - notification_email_async - 332d1b4d-42ad-45b4-a94e-6f1905784c4e - No New Notifications for username: johnson [12]
2018-02-20 17:19:58,748 - INFO - notification_email_async - 238ea107-0ecd-4ce2-a4e5-d1b6d22b2e90 - No New Notifications for username: noah [10]
2018-02-20 17:19:58,749 - INFO - notification_email_async - 238ea107-0ecd-4ce2-a4e5-d1b6d22b2e90 - No New Notifications for username: syme [6]
2018-02-20 17:19:58,749 - INFO - notification_email_async - 238ea107-0ecd-4ce2-a4e5-d1b6d22b2e90 - No New Notifications for username: abe [7]
2018-02-20 17:19:58,749 - INFO - notification_email_async - 5a173c77-d250-426a-a574-fe70b660db2a - No New Notifications for username: bigbrother [28]
2018-02-20 17:19:58,750 - INFO - notification_email_async - 5a173c77-d250-426a-a574-fe70b660db2a - No New Notifications for username: bigbrother2 [8]
2018-02-20 17:19:58,750 - INFO - notification_email_async - 5a173c77-d250-426a-a574-fe70b660db2a - No New Notifications for username: khaleesi [6]
2018-02-20 17:19:58,751 - INFO - notification_email_async - 82dca7f3-0dff-44ad-ab99-2e8c89aee860 - No New Notifications for username: bettafish [20]
2018-02-20 17:19:58,751 - INFO - notification_email_async - 82dca7f3-0dff-44ad-ab99-2e8c89aee860 - No New Notifications for username: wsmith [12]
2018-02-20 17:19:58,751 - INFO - notification_email_async - 82dca7f3-0dff-44ad-ab99-2e8c89aee860 - No New Notifications for username: julia [11]
2018-02-20 17:19:58,752 - INFO - notification_email_async - ac0fb91f-1c49-4693-ac96-bae4cc6e7e06 - No New Notifications for username: tparsons [13]
2018-02-20 17:19:58,752 - INFO - notification_email_async - ac0fb91f-1c49-4693-ac96-bae4cc6e7e06 - No New Notifications for username: jsnow [6]
2018-02-20 17:19:58,753 - INFO - notification_email_async - ac0fb91f-1c49-4693-ac96-bae4cc6e7e06 - No New Notifications for username: charrington [6]
2018-02-20 17:19:58,753 - INFO - notification_email_async - bd007501-1fcb-40a6-975d-4342f47d36f7 - No New Notifications for username: jones [25]
2018-02-20 17:19:58,753 - INFO - notification_email_async - bd007501-1fcb-40a6-975d-4342f47d36f7 - No New Notifications for username: tammy [7]
2018-02-20 17:19:58,754 - INFO - notification_email_async - bd007501-1fcb-40a6-975d-4342f47d36f7 - No New Notifications for username: rutherford [7]
2018-02-20 17:19:58,754 - INFO - notification_email_async - Email Notification Aync tasks took 575
2018-02-20 17:19:58,755 - INFO - notification_email_async - Sum of task times: 222

Return to the email terminal window.
>> make run_debug_email_server
python -m smtpd -n -d -c DebuggingServer localhost:1025
DebuggingServer started at Tue Feb 20 12:16:09 2018
	Local addr: ('localhost', 1025)
	Remote addr:('localhost', 25)

Incoming connection from ('<IP_ADDRESS>', 54274)
Peer: ('<IP_ADDRESS>', 54274)
Data: 'ehlo berlin.udev.bia-boeing.com'
Data: 'helo berlin.udev.bia-boeing.com'
Data: 'mail<EMAIL_ADDRESS>===> MAIL<EMAIL_ADDRESS>sender<EMAIL_ADDRESS>Data: 'rcpt<EMAIL_ADDRESS>===> RCPT<EMAIL_ADDRESS>recips<EMAIL_ADDRESS>Data: 'data'
Data: 'Content-Type: text/html; charset="utf-8"\r\nMIME-Version: 1.0\r\nContent-Transfer-Encoding: 7bit\r\nSubject: 81 New Notifications\r\nFrom<EMAIL_ADDRESS><EMAIL_ADDRESS>Tue, 20 Feb 2018 17:27:09 -0000\r\nMessage-ID<EMAIL_ADDRESS>to App Site\r\n\r\nYou have 81 new notifications\r\n\r\nYou have received this email because you have subscribed to Notifications\r\nYou can disabling these Notifications by logging into Center and disable Email Notifications in profile page'
---------- MESSAGE FOLLOWS ----------
Content-Type: text/html; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: 81 New Notifications
From<EMAIL_ADDRESS>To<EMAIL_ADDRESS>Date: Tue, 20 Feb 2018 17:27:09 -0000
Message-ID<EMAIL_ADDRESS>X-Peer: <IP_ADDRESS>

Welcome to App Site

You have 81 new notifications

You have received this email because you have subscribed to Notifications
You can disabling these Notifications by logging into Center and disable Email Notifications in profile page
.....................
........................
..............

Please Review
@aml-development/ozp-backend-team
Checklist

[x] Read CONTRIBUTING.md
[x] Write code to complete task
[x] Python Code is PEP8 Compliant
[ ] Add unit tests for new code
[ ] All tests must pass before merging the pull request
[ ] At least 2 people reviewed code

:+1: celery spawns workers in parallel and sends email notifications using redis as the message broker.  down the road, we can look into getting approval for and implementing to RabbitMQ if needed, but this is a good start to having background processes using celery

Followed the process, everything is returning as expected.
Notes:  Need to run
source env/bin/activate
pip install -r requirements.txt

and also need redis installed.
:+1:


[DEPENDENCY]: updated ember-getowner-polyfill

Removing the deprecation warning :)

@snewcomer I just bumped/published v5.3.0 with this and your previous jQuery update. Let me know if you run into any issues
cc @pixelhandler


Add the ability to change the tile url from the jquery plugin

@ronichoudhury
Adds tileUrl option to the jquery plugin.  You can also change the url dynamically by calling:
$('#map').geojsMap('tileUrl', 'http://otile1.mqcdn.com/tiles/1.0.0/osm/<zoom>/<x>/<y>.png');

http://jsbin.com/cuqasa/4/edit?js,output
I'll cut a release when merged.

Awesome, thanks!

LGTM. Would it be tested? or do we need to add a test for it? I am assuming that @ronichoudhury will approve it.

Tests added.

:+1:

I'm going to try this out while updating the map apps in the Tangelo examples.  Thanks!

This works great.  If/when there is a point release, I can shed the built version of this file in the Tangelo sources.


NTR: flavin prenyltransferase activity

Proposed definition: Catalysis of the reaction: dimethylallylphosphate + FMNH2 = prenylated FMNH2 + phosphate.  EC reaction <IP_ADDRESS>.  Proposed parent: GO:0004659 prenyltransferase activity.  Publication: PMID 26083743.
Thanks,
Ingrid

Be sure to look for a Rhea xref.

Thanks @deustp01
GO:0106141 flavin prenyltransferase activity


Unsupported Buffer file type on sending buffer containing js file

I'm using the current master git branch.
Expected Behavior
Send buffer containing the contents of a .js file
Actual Behavior
Unhandled rejection Error: EFATAL: Unsupported Buffer file type
telegram.js:249 seems to be the problem.
const filetype = fileType(data);
      if (!filetype) {
        throw new errors.FatalError('Unsupported Buffer file type');
      }

Steps to reproduce the Behavior
Send buffer containing plain text

Why exactly are you checking if the document is a "valid file type" anyways?
Since telegram allows any "file" to be sent via document this doesn't seem reasonable to me.

It's because contentType has to be provided to Telegram.
It's weird file type isn't detected. Maybe should provide a default content-type (application/octet-stream or text/plain)

I have the same issue with MP3 not being detected. Could you add an option to explicitly specify the MIME type?

background
It is easier to have the library auto-detect the MIME type, thus abstracting all that from the user. But advanced users may want to handle that on their own.
When using type auto-detection, we should throw an error if it fails. This avoids situations where bots send files to their users using a probably wrong type.
suggested fix

Allow specifying the MIME type when invoking methods
If none is specified, detect the type (as we are currently doing)

Update:

created feature branch: feature/explicit-mime-type

check out commit https://github.com/yagop/node-telegram-bot-api/commit/bdc79a4e41e10338b909bcc7dd6b24037c3537cd: allows specifying the MIME type explicitly

In v0.30.0, the file type of a buffer, if not be detectable, defaults to "application/octet-stream".
NOTE: For now, this has to be manually activated using environment variable NTBA_FIX_350. (It is an API-breaking change!).
See the updated docs on sending files, particularly here.


AsyncWorkService ConfigAdmin Integration

This PR integrates the asynchronous work service into ConfigAdmin.
The same pattern that was used in the DecarativeServices integration is being re-used for this integration into ConfigAdmin.

Codecov Report

Merging #620 (2a56b05) into development (e34a715) will decrease coverage by 0.10%.
The diff coverage is 76.00%.

@@               Coverage Diff               @@
##           development     #620      +/-   ##
===============================================
- Coverage        89.93%   89.82%   -0.11%
===============================================
  Files              247      248       +1
  Lines            10627    10696      +69
===============================================
+ Hits              9557     9608      +51
- Misses            1070     1088      +18

Impacted Files
Coverage Δ

compendium/ConfigurationAdmin/src/CMActivator.hpp
100.00% <ø> (ø)

.../ConfigurationAdmin/src/ConfigurationAdminImpl.hpp
100.00% <ø> (ø)

...dium/ConfigurationAdmin/src/CMAsyncWorkService.cpp
72.30% <72.30%> (ø)

compendium/ConfigurationAdmin/src/CMActivator.cpp
78.88% <100.00%> (+0.23%)
:arrow_up:

.../ConfigurationAdmin/src/ConfigurationAdminImpl.cpp
92.77% <100.00%> (+0.04%)
:arrow_up:


"Could NOT find OpenSSL" when building for Android

Hi, I'm using NDK's cmake to build rsocket-cpp for Android
First I got:
  Could NOT find Folly (missing: FOLLY_LIBRARY FOLLY_BENCHMARK_LIBRARY
FOLLY_INCLUDE_DIR)

So I added the following to CMakeLists.txt:
set(FOLLY_LIBRARY "/usr/local/opt/folly/lib" )
set(FOLLY_BENCHMARK_LIBRARY "/usr/local/opt/folly/lib/libfollybenchmark.a" )
set(FOLLY_INCLUDE_DIR "/usr/local/include/folly" )

Then I got:
  Could NOT find OpenSSL, try to set the path to OpenSSL root folder in the
  system variable OPENSSL_ROOT_DIR (missing: OPENSSL_LIBRARIES
  OPENSSL_INCLUDE_DIR)

So I added the following to CMakeLists.txt:
set(OPENSSL_ROOT_DIR "/usr/local/opt/openssl" )
set(OPENSSL_LIBRARIES "/usr/local/opt/openssl/lib" )
set(OPENSSL_INCLUDE_DIR "/usr/local/opt/openssl/include" )

Then I got:
  Could NOT find OpenSSL, try to set the path to OpenSSL root folder in the
  system variable OPENSSL_ROOT_DIR (missing: OPENSSL_LIBRARIES) (found
  version "1.0.2l")

I've also tried building OpenSSL for Android following this instruction:

Then changed above lines to:
set(OPENSSL_ROOT_DIR "/usr/local/ssl/android-26" )
set(OPENSSL_LIBRARIES "/usr/local/ssl/android-26/lib" )
set(OPENSSL_INCLUDE_DIR "/usr/local/ssl/android-26/include" )

The result was pretty much the same:
  Could NOT find OpenSSL, try to set the path to OpenSSL root folder in the
  system variable OPENSSL_ROOT_DIR (missing: OPENSSL_LIBRARIES) (found
  version "1.1.0f")

It's finding the headers, but not the libraries.
@lexs How do you guys at Facebook build rsocket-cpp for Android?
Also, is it possible to share the JNI code (or whatever you use to make it available in Java)?
Thank you!

Hey, really sorry about not responding sooner here. Was out on holiday and then forgot to check github notifications.
Anyway, looking through our code I don't think openssl should be a dependency, I'll try removing it. Can you try commenting it out and see how it goes?
For the JNI part, we have a very bare wrapper which is basically Subscription subscribe(String data, String metadata, int initialRequestN, Callback callback); and
interface Subscription {
  void cancel();
  void request(int n);
}
interface Callback {
  void onResponse(String data, String metadata);
  void onError(String error);
}

All the connection logic etc is fully handled in C++.

Seems like OpenSSL is used by folly::AsyncSocket which we use for TCP, so it's indeed needed. @NexZhu What OS are you running on? Under OSX this works for me cmake -DCMAKE_BUILD_TYPE=DEBUG -DOPENSSL_ROOT_DIR=/usr/local/ssl -DOPENSSL_LIBRARIES=/usr/local/ssl/lib ../ but it also works without the OPENSSL options.
We build both rsocket and folly with Buck, so it's quite a different setup.

@lexs On OSX, using system's cmake like you suggested works fine, but this way it's not built for Android right? Using the cmake bundled in NDK from Android Studio won't work. The difference is it has some extra arguments:
/Users/nex/Library/Android/sdk/cmake/3.6.4111459/bin/cmake \
-DCMAKE_BUILD_TYPE=DEBUG \
-H/Users/nex/workspaces/os/rsocket-cpp \
-B/Users/nex/workspaces/os/rsocket-android-demo/app/.externalNativeBuild/cmake/debug/armeabi \
-G"Android Gradle- Ninja" \
-DANDROID_ABI=armeabi \
-DANDROID_NDK=/Users/nex/Library/Android/sdk/ndk-bundle \
-DCMAKE_LIBRARY_OUTPUT_DIRECTORY=/Users/nex/workspaces/os/rsocket-android-demo/app/build/intermediates/cmake/debug/obj/armeabi \
-DCMAKE_BUILD_TYPE=Debug \
-DCMAKE_MAKE_PROGRAM=/Users/nex/Library/Android/sdk/cmake/3.6.4111459/bin/ninja \
-DCMAKE_TOOLCHAIN_FILE=/Users/nex/Library/Android/sdk/ndk-bundle/build/cmake/android.toolchain.cmake \
-DANDROID_PLATFORM=android-21

When I build the RSocket, for CMake to be able to find the OpenSSL, I do either of these two:

Give the path of OpenSSL to CMake with a flag
brew link --force openssl
Call this command once, if you use MacOs with Brew.

Did this help?
brew link --force openssl
Please reopen if otherwise.


[Scheduled Maintenance] Home Server SSD mounting problems

Autogenerated Maintenance
by bettermaintenance.py

Investigating
Expected data is still on SSD, tho the drive doesn't get recognized.
Backup is in progress. Further investigation pending.

Update
Hardware issue. Replacements are being ordered.