Should SignalHandlerId be Copy or should disconnect accept &SignalHandlerId

SignalHandlerId is not Copy and disconnect consumes it. This is done so that the same SignalHandlerId is not accidentally used to disconnect distinct signal handlers in case that SignalHandlerId overflows.
First of all, this can only happen on 32 bit systems or Windows because it's a 64 bit integer otherwise.
Secondly, this makes it impossible to store an object and SignalHandlerIds in a struct and, e.g., disconnect the signal handlers on drop because you cannot move the SignalHandlerId. One workaround is to store the SignalHandlerIds in a Vec or behind Option.
Thirdly, the SignalHandlerIds overflowing is considered a bug in glib. https://github.com/GNOME/glib/blob/861afbe63953c2442658444bc147a7ea15213b8a/gobject/gsignal.c#L688-L689
Fourthly, if SignalHandlerId overflows, then gtk-rs-core aborts: https://github.com/gtk-rs/gtk-rs-core/blob/346cc681052d24c387ee2755902129c7bf26c937/glib/src/signal.rs#L60
Therefore the current setup makes working with signals harder only to prevent certain high-level errors that I am not convinced occur at a significant rate if ever.
It would not be a breaking change to make SignalHandlerId Copy.

I am completely lost: we do want to implement Copy on SignalHandlerId because we want to prevent people to disconnect a signal twice, same reason why disconnect is taking ownership of it. I don't see how it's related to overflow...
As for putting SignalHandlerId in a struct, I definitely don't see the issue. if you want to disconnect the signal outside of a drop implementation, then yes, you need to use Option, it's just how rust works.

we want to prevent people to disconnect a signal twice

Why? If a signal has already been disconnected then disconnecting it again is a no-op except that glib will emit a warning message.

I don't see how it's related to overflow...

That seemed like the only reasonable explanation for the current behavior to me. If overflow comes into play, then disconnecting multiple times can cause logic errors. If overflow is not in the picture, then disconnecting twice causes no harm whatsoever.

if you want to disconnect the signal outside of a drop implementation

How would you do it inside a drop implementation?

Fourthly, if SignalHandlerId overflows, then gtk-rs-core aborts:

Well, no. Because if it overflows then GTK already killed the process via g_error() in the code you linked:

Thirdly, the SignalHandlerIds overflowing is considered a bug in glib. https://github.com/GNOME/glib/blob/861afbe63953c2442658444bc147a7ea15213b8a/gobject/gsignal.c#L688-L689

I don't think overflow is something you have to worry about here. If it happens then it will fail hard and immediately.

That SignalHandlerId is not Copy and disconnecting takes ownership of it is intentional. While it does not prevent all possible bugs (you can still disconnect twice if you try hard enough, you can disconnect on the wrong object, ...), it at least avoids disconnecting twice and pushes people to properly handle the signal handler ids as an actual resource instead of an integer.
Storing it in an Option is exactly what you should do and it pushes you to a design that handles the signal handler ids as something that disappears when disconnecting.
I don't see how making it Copy improves anything here other than potentially making code working with signal handlers more fragile.

Because if it overflows then GTK already killed the process via g_error() in the code you linked:

I wasn't sure if G_DISABLE_CHECKS is usually set or not in GTK builds.

Storing it in an Option is exactly what you should do and it pushes you to a design that handles the signal handler ids as something that disappears when disconnecting.

Rust does not support this properly because it does not have destructuring drop, i.e., drop that can move out of the fields. If you are disconnecting outside of drops, then your approach makes sense to me.
Since you're providing an escape hatch via as_raw and from_glib this is not a serious issue so I'm fine with leaving it as is if you're not convinced.

I think your argument generalizes to the statement that hash maps should return a Key object upon insert and only allow removing elements by passing in this Key object (moving it.) At least I have not seen any argument why the signal handler hash map is different from any other hash maps in this regard.
I've not seen any general purpose hash map implementations that do this.

Well, in any case, it won't happen so closing this issue. If you found a bug using the Rust API, please open another issue with the problem.

I wasn't sure if G_DISABLE_CHECKS is usually set or not in GTK builds.

If you use a GLib build with checks disabled then you're basically on your own :) These checks are preventing bad behaviour in quite a few places, and you have to explictly disable them during the GLib build.


Why audio is low quality

It sounds like its 8 bit and forced mono but why?
Here's my code to load a sound
    STransform audioTransfrom;
    audioTransfrom.Position = Float3(0, 1, 0);
    audioTransfrom.Rotation = Quat::Identity();
    audioTransfrom.Scale    = Float3(1);

    ASoundResource* sound      = GetOrCreateResource<ASoundResource>("/Root/goal1.mp3");
    AActor*         audioPoint = world->SpawnActor2(audioTransfrom);
    ASoundEmitter*  pl         = audioPoint->CreateComponent<ASoundEmitter>("AudioSource");

    ASoundGroup* s = new ASoundGroup();
    s->SetVolume(1);
    s->SetPaused(false);
    pl->SetEmitterType(ESoundEmitterType::SOUND_EMITTER_POINT);
    pl->SetRolloffRate(0.01f);
    pl->SetMaxDistance(400);
    pl->SetReferenceDistance(1);

    pl->PlaySoundAt(world, sound, s, audioTransfrom.Position);

ASoundEmitter::PlaySoundAt is a static method, so ASoundEmitter should not be instantiated. Your code will be simplified to the following:
        ASoundResource* sound = GetOrCreateResource<ASoundResource>("/Root/goal1.mp3");
        ASoundGroup*  s  = new ASoundGroup();
        s->SetVolume(1);
        s->SetPaused(false);
        ASoundEmitter::PlaySoundAt(world, sound, s, Float3(0, 1, 0));
        // or  ASoundEmitter::PlaySoundBackground(world, sound, s);

The HRTF filter is enabled by default. Try turning it off, it may improve the sound quality in your case. The HRTF filter can be disabled with the snd_HRTF 0 console command.


navBar design enhanced

navBar design enhanced with CSS. Also, the sticky menu feature is applied to the navBar. I also did some fixes to the slider as the images on it were stretching. Now it's not stretching and the design is responsible.

Hey, this PR doesn't satisfy the 3 basic requirements:

Add Hover Effects
Actually, the white box fadeIn is a hover effect.

Responsive (add a Hamburger Menu for Mobile devices)
This may take some time. I suggest merging my PR and starting a new issue for this one. But it's your choice in the end.

Smooth scrolling
I added the smooth scrolling. It can be seen effectively between home and testimonials. Switching between about, testimonials, or contact wouldn't show the effect. Because there's simply not much content.

Hi @Eddayavuz

If you wish to make 2 PRs for this issue, please do a PR for the same asap
Please Add Navbar Specific CSS since the changes are applied to all the buttons on the HomePage -

Hello

Hi @Eddayavuz

If you wish to make 2 PRs for this issue, please do a PR for the same asap
Please Add Navbar Specific CSS since the changes are applied to all the buttons on the HomePage -

Hello I fixed the footer icons. If you wish, you can merge. I don't have time to work on the hamburger menu. :(


Fix flaky test testExternalUrl using LinkedHashMap

Checklist

[x] the individual contributor license agreement is signed
[x] commit message follows commit guidelines

Description of change

This PR aims to fix the flaky test: org.apereo.portal.redirect.PortletRedirectionControllerTest.testExternalUrl similar to a previously raised PR https://github.com/uPortal-Project/uPortal/pull/2718.
I found and confirmed the flaky behaviour of the tests using an open-source research tool NonDex, which shuffles implementations of nondeterminism operations.
Problem
The test case org.apereo.portal.redirect.PortletRedirectionControllerTest.testExternalUrl fails due to the below assertion.
https://github.com/uPortal-Project/uPortal/blob/989ba284b63dd8d26565d7b62213d68fd95be472/uPortal-webapp/src/test/java/org/apereo/portal/redirect/PortletRedirectionControllerTest.java#L57-L60
This is because additionalParameters in url is a HashMap which does not preserve the order of the items causing the order of action and list to vary.
https://github.com/uPortal-Project/uPortal/blob/989ba284b63dd8d26565d7b62213d68fd95be472/uPortal-webapp/src/test/java/org/apereo/portal/redirect/PortletRedirectionControllerTest.java#L48
Solution
This PR fixes the flakiness by using a LinkedHashMap which preserves the order of the items in additionalParameters.
Steps to reproduce
The following command can be used to reproduce the assertion errors and verify the fix.
Integrate NonDex:
Add the following snippet to the top of the build.gradle in $PROJ_DIR:
plugins {
    id 'edu.illinois.nondex' version '2.1.1-1'
}

Append to build.gradle in $PROJ_DIR:
apply plugin: 'edu.illinois.nondex'

Execute Test with Gradle:
./gradlew --info uPortal-webapp:test --tests org.apereo.portal.redirect.PortletRedirectionControllerTest.testExternalUrl

Run NonDex:
./gradlew --info uPortal-webapp:nondexTest --tests=org.apereo.portal.redirect.PortletRedirectionControllerTest.testExternalUrl --nondexRuns=50 -x autoLintGradle

Test Environment:
Java version "1.8.0_381"
macOS Venture Version 13.4.1 (22F82)

Please let me know if you have any concerns or questions.

Thanks @KiruthikaJanakiraman!
To clarify, I believe the intent of this test is to be order insensitive.
Would this change it to become order sensitive and potentially cause tests to fail over a property (order) we don't intend to check?

The assert statement checks for a specific order of parameters. Doesn't that make the test order sensitive?

You are right, the test in is current form is indeed order sensitive.
This is testing URL query params. Query params are not order sensitive.
I'd personally lean that the test could/should account query params being in any/different order.
But I'd be interested to hear what you (@KiruthikaJanakiraman) and others (@uPortal-Project/uportal-committers) think.

I think the test should be changed to account for any order.

This is testing URL query params. Query params are not order sensitive.
That makes sense. If the test is meant to be order insensitive, I would suggest 2 alternative fixes:

Checking for both possible order of additionalParameters
Writing a custom function to compare urls with different query parameter orders

Could you kindly let me know the preferred fix?

I have updated the commit with a custom function that compares two urls two urls irrespective of the order of the query parameters. Could you kindly review the same?

@KiruthikaJanakiraman could you run ./gradlew goJF to format the changes?


Add: DataDog, Grunt and Qodana icons

Add New Icon(s)
Icon Details

Icon ID
Icon

datadog

grunt

qodana

Notes

Datadog is a modern monitoring & security tool as a SaaS.
Grunt is a famous JavaScript task runner.
Qodana is a tool that helps development teams follow agreed quality standards, and deliver readable, maintainable, and secure code.

Checklist

[X] Added icon(s) to the appropriate directory
[X] Updated documentation with the new icon(s)
[X] Verified the icon(s) display correctly
[X] If the icon has light and dark, verified the auto switch works correctly

@LelouchFR please, help me on Qodana Auto SVG, I can't make the auto, I've tried so many times.

@LelouchFR I give up with qodana auto 😢, I just can't do it.

@LelouchFR I give up with qodana auto 😢, I just can't do it. Please help me taking a look in my qodana-dark.

I'm going to look at that at the end of the day, since I still have a lot of things to do today :|

@LelouchFR you don't need to do any more, I've fixed it with the help of @atr321


Fix circe-jawn tests, and add constructor for JawnParser

We weren't actually running the circe-jawn tests.

Codecov Report

Merging #1154 into master will increase coverage by 1.09%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1154      +/-   ##
==========================================
+ Coverage   85.78%   86.88%   +1.09%
==========================================
  Files          87       87
  Lines        2843     2844       +1
  Branches      118      118
==========================================
+ Hits         2439     2471      +32
+ Misses        404      373      -31

Impacted Files
Coverage Δ

...jawn/src/main/scala/io/circe/jawn/JawnParser.scala
100% <100%> (+20%)
:arrow_up:

...rc/main/scala/io/circe/shapes/SizedInstances.scala
78.57% <0%> (-14.29%)
:arrow_down:

.../core/shared/src/main/scala/io/circe/Decoder.scala
90.53% <0%> (-0.3%)
:arrow_down:

...les/core/shared/src/main/scala/io/circe/Json.scala
80.36% <0%> (+0.61%)
:arrow_up:

...re/shared/src/main/scala/io/circe/JsonNumber.scala
97.5% <0%> (+3.75%)
:arrow_up:

...d/src/main/scala/io/circe/NonEmptySeqDecoder.scala
100% <0%> (+8.33%)
:arrow_up:

.../main/scala/io/circe/jawn/CirceSupportParser.scala
95.16% <0%> (+41.93%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4906aaf...eec084a. Read the comment docs.


Grafana Observational graphs for Pipelines Controller Monitoring

The goal is to get a better understanding of how our components behave under load so that we can make appropriate tunings/adjustments.
The following metrics are being queried for the dashboard:-
* tekton_pipelines_controller_running_pipelineruns_count -
Number of pipelineruns executing currently
* tekton_pipelines_controller_running_taskruns_count -
Number of taskruns executing currentl
* tekton_pipelines_controller_taskruns_pod_latency
Scheduling latency for the taskruns pods
* tekton_pipelines_controller_workqueue_depth -
The workqueue for the Tekton Pipelines controller
* Pipelines controller restarts
* tekton_pipelines_controller_client_resutls -
 Total number of K8s API requests made by Pipelines Client

Preview

by the way @ramessesii2 I have confirmed that openshift-pipelines 1.11.0 has the quota/node throttling metrics I recently added upstream:
gmontero ~/bin $ curl http://<IP_ADDRESS>:9090/metrics | grep tekton_pipelines_controller_running_taskruns_throttled
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0# HELP tekton_pipelines_controller_running_taskruns_throttled_by_node_count Number of taskruns executing currently, but whose underlying Pods or Containers are suspended by k8s because of Node level constraints. Such suspensions can occur as part of initial scheduling of the Pod, or scheduling of any of the subsequent Container(s) in the Pod after the first Container is started
# TYPE tekton_pipelines_controller_running_taskruns_throttled_by_node_count gauge
tekton_pipelines_controller_running_taskruns_throttled_by_node_count 0
# HELP tekton_pipelines_controller_running_taskruns_throttled_by_quota_count Number of taskruns executing currently, but whose underlying Pods or Containers are suspended by k8s because of defined ResourceQuotas.  Such suspensions can occur as part of initial scheduling of the Pod, or scheduling of any of the subsequent Container(s) in the Pod after the first Container is started
# TYPE tekton_pipelines_controller_running_taskruns_throttled_by_quota_count gauge
tekton_pipelines_controller_running_taskruns_throttled_by_quota_count 0

It is not in 1.10.4.
Assuming when our move to 1.11 happens, I think it makes sense to add those metrics along with the ones you have here.
Also note my findings around the latency metric i.e. https://redhat-internal.slack.com/archives/C032EJ007C0/p1686932611229559 ... I'm beginning to think we don't use that metrics, and just use the exporter's pipelinerun_duration_scheduled_seconds_[bucket, sum, count] metric once you get the dashboard working with the exporter.

I'm beginning to think we don't use that metrics, and just use the exporter's pipelinerun_duration_scheduled_seconds_[bucket, sum, count] metric once you get the dashboard working with the exporter.

Sure Gabe, I'm working on fixing the Exporter metrics in Grafana. I'll keep this note.

Small nit - commit message appears to be missing a "title." The general recommendation is that the first line of a commit message should be fewer than 50 characters.

I've addressed your reviews @gabemontero @adambkaplan.
Although, I've made the final changes and resolved any conflicts that came after @prietyc123's PR is merged, I can't say for sure that it's gonna look the same as the screenshot in the PR's description. This is because Prity's changes aren't yet reflected in the Grafana in Staging envs.

@ramessesii2 and I talked during scrum.  He will take on the next infra-deployment bump to dev/stage to pull in @prietyc123 's change into stage.
And also, once we merge @adambkaplan 's inner dev loop work with Grafana, that will be an option as well.
Ideally yeah let's get that dev/stage or inner loop thing ready so @ramessesii2 can verify his rebase on top of @prietyc123 's change.

Thanks Gabe.
The infra-bump PR is up here - https://github.com/redhat-appstudio/infra-deployments/pull/2033.
I'll rebase once it's merged.

ok @ramessesii2 both @adambkaplan inner loop and https://github.com/redhat-appstudio/infra-deployments/pull/2033 are merged, and I see @prietyc123 's new PaC charts on staging.
Go ahead and rebase when you are next back at work.
I'll also let you drive if we bump to prod with the https://github.com/redhat-appstudio/infra-deployments/pull/2033 changes or if you wait until your changes are in staging, and then we bump that to prod after vetting there.
@adambkaplan @Roming22 FYI

This PR has been rebased. I've also updated the preview image. Since @gabemontero & @adambkaplan are on PTO this week. I'll ask @Roming22 to do me the favor of merging this PR if everything looks good to you.

I'm seeing the same error in #703 with deploy-cluster and destroy-cluster Pipelines as Code CI / pipeline-service-upgrade-test failing. To me it seems unrelated although I've not been able to look at the logs.

/test Pipelines as Code CI / pipeline-service-upgrade-test


Nobody submit it project?

wow , it's very good cms what i find ,

Maybe ask on the Discord Channel https://discord.com/invite/mxmJNSZ2gn

ok，

Maybe ask on the Discord Channel https://discord.com/invite/mxmJNSZ2gn

nobody


Github workflow: test if site building works

There are a javadoc errors in spite of committing a new version... They are not caught when we deploy a version with github actions. This is, of course, wrong... Therefore, the github actions should try to build a site:
    - name: Build with Maven and check if site building works
      run: mvn clean site --file pom.xml

    - name: Build with Maven and test if signing works
      run: mvn clean package -P release --file pom.xml
      env:
        MAVEN_GPG_PASSPHRASE: ${{ secrets.MAVEN_GPG_PASSPHRASE }}

Added mvn clean site to github action.


Test latest CKF in an airgapped environment

We need to test the current CKF in an airgapped environment to gather list of issues that block it's deployment.
In the past we've worked on 3 areas for this:

https://github.com/canonical/bundle-kubeflow/issues/678
Ensure our Charms don't do apt install in their code https://github.com/canonical/dex-auth-operator/pull/148
Extend our Charms to be able to configure all the images the charmed container might deploy

The last piece is to know do a pass and test the latest/edge bundle in an airgapped environment and gather list of issues we will find.

Until https://github.com/canonical/bundle-kubeflow/issues/679 is resolved though we'll need to manually find the list of images, to use when deploying the bundle

We'll also need to pay extra care to

Istio https://github.com/canonical/istio-operators/pull/316
Knative https://github.com/canonical/knative-operators/issues/140

As exposed in https://github.com/canonical/bundle-kubeflow/issues/680#issuecomment-1694869789, since they use an operator to handle the installation.
For those two, if we are time pressured, we can still document a workaround on getting them to work on airgapped by updating the manifests after the installation.

Istio is handled here


Build successful; but jar file seems missing on jcenter

I've been trying to release a simple OSS java library (single jar file) with the following gradle file:
buildscript {
    repositories {
        jcenter()
    }
    dependencies {
    }
}

plugins {
    id "com.jfrog.bintray" version "1.8.0"
}

apply plugin: 'maven-publish'

group 'io.inbot'
version '0.1.0'

ext.isReleaseVersion = false

apply plugin: 'java'

jar {
    baseName = 'inbot-eth-contracts'
}

sourceCompatibility = 1.8

repositories {
    mavenCentral()
}

dependencies {
    testCompile group: 'junit', name: 'junit', version: '4.12'
    compile ('org.web3j:core:3.2.0')
}

ext.pgpPassword='XXXXX'
ext.jcenterApiKey='XXXXX'

task sourceJar(type: Jar) {
    from sourceSets.main.allJava
}

publishing {
    publications {
        mavenJava(MavenPublication) {
            from components.java
//
//            artifact sourceJar {
//                classifier "sources"
//            }
        }
    }
}

// deploy using gradle -PjcenterApiKey=XXXXXXX -PpgpPassword=XXXXXXX clean bintrayUpload
bintray {
    user = 'jillesvangurp'
    key = jcenterApiKey
    publications = ['mavenJava']
    dryRun = false //[Default: false] Whether to run this as dry-run, without deploying
    publish = true //[Default: false] Whether version should be auto published after an upload
    override = false //[Default: false] Whether to override version artifacts already published
    pkg {
        repo = 'inbot-maven-repo'
        name = 'inbot-eth-contracts'
        userOrg = 'inbot'
        licenses = ['MIT']
        vcsUrl = 'https://github.com/Inbot/inbot-eth-contracts.git'
        websiteUrl = 'https://github.com/Inbot/inbot-eth-contracts'
        githubRepo = 'Inbot/inbot-eth-contracts'
        version {
            name = '0.1.0' //Bintray logical version name
            desc = //Optional - Version-specific description'
            vcsTag = 'v0.1.0'
            gpg {
                sign = true //Determines whether to GPG sign the files. The default is false
                passphrase = pgpPassword //Optional. The passphrase for GPG signing'
            }
        }
    }
}

I uploaded with the following commands.
gradle -PjcenterApiKey=XXXXXX -PpgpPassword=XXXXXX bintrayUpload --debug

This errored several times due to apparent server failures and timeouts (website is extremely slow) before it finally succeeded. I got a 405 at some point and a weird html error when it timed out. Because of these failures I had debug logging turned on when it finally 'succeeded'.
Here's the gradle debug log; note it uploads both the pom and the signed jar successfully (201 created for the jar file).
https://gist.github.com/jillesvangurp/cda822a2a4b9905a96a38b57b531914e
However, while I can find the package and version on jcenter, there is no sign of the jar file. I have no idea how to fix this or what is wrong. The plugin is basically telling me everything succeeded even though I can see this is clearly not the case. It's not helpful that the website is extremely unresponsive.
Is this going to be eventually consistent or should I just delete the version and try again?

Hi, @jillesvangurp
I got the same issue, do you have any solutions?

Looked like they had some server issues; the slowness was a good hint that something was up. The problem went away eventually. I wasted a good amount of time on publishing a simple small jar file and failing repeatedly.  Given the problems I've had with it, I won't be going near jcenter any time soon.

Looks like I've run into the same issue. I attempted to publish 2 different projects with the exact same gradle config - the first one uploaded successfully and all artifacts are available via jcenter, and the second one uploaded successfully (according to the gradle plugin) but:

the files aren't visible in bintray (they were initially visible under the files tab, but not in the versions section on the general tab....but now they've disappeared altogether!)
they seem to exist, as I can't republish with the same maven coordinates (HTTP/1.1 409 Conflict [message:Unable to upload files....already exists)
if I try to download the file from the repo I get a basic auth popup (if i do this for an older version it works fine)

I've fired off a support email but not sure how long that will take to get looked at. I'm not sure if I should try and create a new version - if that fails as well I'll be in an even worse place :(
I'll give it a few hours and see......

Ok, it didn't resolve itself, but I've 'fixed it'. I just enabled override in the bintray plugin and republished. It took a really long time (over 10 min) as Bintray's servers were in a degraded state ("Slowness with the REST API, UI and Downloads") but it eventually republished and my files are available in Jcenter now. Not a huge amount of faith in bintray right now...

I'm closing this issue for now.
Do let us know if you think there's something we can add or change in the plugin side.
Thanks

Same problem in my case. artifact is deployed to bintray. Through web interface I can see this is there.
But, cannot download and use it in another project. Says, the artifact is missing

Same problem here for 4 projects I just added.  I can get the pom files but nothing else when I reference them as dependencies in another project.

I stopped using jcenter due to repeated outages, flakiness, and the stuff outlined above. I recommend using jitpack.io for stuff that doesn't need to be on maven central and using sonatype OSS when you do need maven central.
Jitpack is awesome. All you need to do there is git tag your releases on github. It builds them straight from source. Super fast and jars are available in seconds. This is exactly how this stuff should work. Simple, fast, easy. The exact opposite of either Jcenter or Sonatype.


Source required to replace placeholder?

Hi!
I would like to integrate PAPI into the plugin Holograms. These holograms are just ArmorStand with custom names, no packet magic is done. Therefore the source for replacing placeholders can not be determined. Null is forbidden for the source. Is there any way I could integrate it?

I just committed a fix that allows null for the source as far as I can tell (I will test to see if it actually works in a moment, and push any fixes if it doesn't). I will push another update soon but I have been super busy recently. I will close this issue once I've verified that null sources and observers work.
In the future though, when Contexts are properly pushed, you could have a source because displayname can be per player. Might be interesting to look into ;)

Ok so it looks like I've got some more internal issues, so I am looking into that now. From now on, annotated methods will have to specify that they support nullable sources with the @Nullable annotation. I will update my internals accordingly.

Alright, I just pushed another commit that seems to support null sources and observers as much as I can internally. Parameters with the @Nullable annotation CAN be null, while parameters without it are ALWAYS present. The token parameter only uses the annotation if it is a String, because it doesn't make sense to have a null reference for an Optional<String>.
This should fix this issue but I should point out that many of the placeholders I have are dependent on having a source (such as player or rank), so there isn't too much you can do with this. I might work on the economy placeholder to support balance ranks that are source-independent, but I don't have enough time today so maybe another day.


Delay between latest transactions and wallet overview [1.3.1-beta]

Issue description
As in older versions there is a delay between the "Latest transactions" and the "Wallet overview".
Split up funds between two or more wallets. Send internal transfer from Wallet 1 to Wallet 2. Both sent tx and received tx gets solid inside "Latest transactions" but nothing happens in the wallet overview, until you either click the spinning button to refresh latest tx (which then also updates wallet overview), or change from staking tab and back to wallet.
Firefly version
1.3.1-beta
OS details
Windows 10
Can the issue be reliably reproduced?
Yes
Steps to reproduce the issue

Create 2 or more wallets
Send internal transfer
Watch latest tx get updated, but wallet overview be stuck
...

Isn't like this every single time but enough for it to be an issue.
Expected behaviour
Both Wallet overview and Latest transactions should update when the transactions get confirmed.
Actual behaviour
One of the views lag behind.
Errors
No response

Can confirm on macOS 12.1

@t00k @cvarley100 was this fixed in 1.3.1 or 1.3.2?

With the change to a single wallet view this issue doesn´t exist anymore.


Early intervention APIs

This PR contains:
-> APIs for early intervention
-> docs
-> example plugin to show the usage

AU check failed! https://ci.trafficserver.apache.org/job/autest-github/79/

Linux build failed! https://ci.trafficserver.apache.org/job/linux-github/1670/

clang format successful! https://ci.trafficserver.apache.org/job/clang-format-github/82/

RAT check successful! https://ci.trafficserver.apache.org/job/RAT-github/95/

FreeBSD11 build failed! https://ci.trafficserver.apache.org/job/freebsd-github/1777/

Intel CC build failed! https://ci.trafficserver.apache.org/job/icc-github/208/

clang format failed! https://ci.trafficserver.apache.org/job/clang-format-github/83/

RAT check successful! https://ci.trafficserver.apache.org/job/RAT-github/96/

clang-analyzer build successful! https://ci.trafficserver.apache.org/job/clang-analyzer-github/340/

Linux build failed! https://ci.trafficserver.apache.org/job/linux-github/1671/

FreeBSD11 build failed! https://ci.trafficserver.apache.org/job/freebsd-github/1778/

AU check successful! https://ci.trafficserver.apache.org/job/autest-github/80/

Intel CC build failed! https://ci.trafficserver.apache.org/job/icc-github/209/

clang-analyzer build successful! https://ci.trafficserver.apache.org/job/clang-analyzer-github/341/

The regression tests are dumping core, obviously that needs to be fixed.

RAT check successful! https://ci.trafficserver.apache.org/job/RAT-github/99/

clang format failed! https://ci.trafficserver.apache.org/job/clang-format-github/86/

AU check successful! https://ci.trafficserver.apache.org/job/autest-github/83/

FreeBSD11 build failed! https://ci.trafficserver.apache.org/job/freebsd-github/1781/

Linux build failed! https://ci.trafficserver.apache.org/job/linux-github/1674/

Intel CC build failed! https://ci.trafficserver.apache.org/job/icc-github/212/

RAT check successful! https://ci.trafficserver.apache.org/job/RAT-github/100/

clang format successful! https://ci.trafficserver.apache.org/job/clang-format-github/87/

clang-analyzer build successful! https://ci.trafficserver.apache.org/job/clang-analyzer-github/344/

AU check successful! https://ci.trafficserver.apache.org/job/autest-github/84/

FreeBSD11 build successful! https://ci.trafficserver.apache.org/job/freebsd-github/1782/

Linux build successful! https://ci.trafficserver.apache.org/job/linux-github/1675/

Intel CC build successful! https://ci.trafficserver.apache.org/job/icc-github/213/

clang-analyzer build successful! https://ci.trafficserver.apache.org/job/clang-analyzer-github/345/

clang format successful! https://ci.trafficserver.apache.org/job/clang-format-github/88/

RAT check successful! https://ci.trafficserver.apache.org/job/RAT-github/101/

AU check failed! https://ci.trafficserver.apache.org/job/autest-github/85/

Linux build successful! https://ci.trafficserver.apache.org/job/linux-github/1676/

FreeBSD11 build successful! https://ci.trafficserver.apache.org/job/freebsd-github/1783/

Intel CC build successful! https://ci.trafficserver.apache.org/job/icc-github/214/

clang-analyzer build successful! https://ci.trafficserver.apache.org/job/clang-analyzer-github/346/

clang format successful! https://ci.trafficserver.apache.org/job/clang-format-github/104/

RAT check successful! https://ci.trafficserver.apache.org/job/RAT-github/118/

FreeBSD11 build failed! https://ci.trafficserver.apache.org/job/freebsd-github/1800/

AU check failed! https://ci.trafficserver.apache.org/job/autest-github/101/

Linux build failed! https://ci.trafficserver.apache.org/job/linux-github/1692/

Intel CC build failed! https://ci.trafficserver.apache.org/job/icc-github/230/

clang format successful! https://ci.trafficserver.apache.org/job/clang-format-github/105/

RAT check successful! https://ci.trafficserver.apache.org/job/RAT-github/119/

FreeBSD11 build failed! https://ci.trafficserver.apache.org/job/freebsd-github/1801/

clang format successful! https://ci.trafficserver.apache.org/job/clang-format-github/106/

RAT check successful! https://ci.trafficserver.apache.org/job/RAT-github/120/

clang-analyzer build successful! https://ci.trafficserver.apache.org/job/clang-analyzer-github/362/

AU check failed! https://ci.trafficserver.apache.org/job/autest-github/102/

Intel CC build failed! https://ci.trafficserver.apache.org/job/icc-github/231/

AU check successful! https://ci.trafficserver.apache.org/job/autest-github/103/

Linux build successful! https://ci.trafficserver.apache.org/job/linux-github/1693/

Intel CC build successful! https://ci.trafficserver.apache.org/job/icc-github/232/

FreeBSD11 build successful! https://ci.trafficserver.apache.org/job/freebsd-github/1802/

clang-analyzer build successful! https://ci.trafficserver.apache.org/job/clang-analyzer-github/363/

clang-analyzer build successful! https://ci.trafficserver.apache.org/job/clang-analyzer-github/364/

RAT check successful! https://ci.trafficserver.apache.org/job/RAT-github/122/

clang format successful! https://ci.trafficserver.apache.org/job/clang-format-github/108/

AU check successful! https://ci.trafficserver.apache.org/job/autest-github/105/

FreeBSD11 build successful! https://ci.trafficserver.apache.org/job/freebsd-github/1804/

Linux build successful! https://ci.trafficserver.apache.org/job/linux-github/1695/

Intel CC build successful! https://ci.trafficserver.apache.org/job/icc-github/234/

clang-analyzer build successful! https://ci.trafficserver.apache.org/job/clang-analyzer-github/366/


Add Webgpu backend

This is it :) This is the WebGPU backend
I included some GENie scripts modifications to build it against Dawn in native
All the examples referenced here are working: https://github.com/bkaradzic/bgfx/issues/2023
This increments shaderc binary version, since more data per uniform is now needed (texture format and texture dimension)
Shaders need to be rebuilt for WebGPU to work but the other backends are adapted to not require it

How hard would be to port to webgpu.h instead of webgpu_cpp.h? :smile:

Very interesting! Have you yet tried to build against Emscripten to target WebGPU on the web? Or is this targeting Dawn in native?

@juj It's for both:
https://twitter.com/hugoamnov/status/1224055645458006017
https://twitter.com/hugoamnov/status/1119224299242565635

@juj yup, both WebGPU through Emscripten and native through Dawn
Most of the examples linked here kinda work: https://github.com/bkaradzic/bgfx/issues/2023, I need to fix about 5 or 6 of them (/30)
I also have some fixes to Emscripten webgpu library that went a bit out of sync to make those work, that I need to upstream

How hard would be to port to webgpu.h instead of webgpu_cpp.h? 😄

I would suggest maybe doing that change later on, if you wish ? It would indeed be quite a bit of additional work 😄
webgpu_cpp.h is really just a wrapper giving you automatic release + object notation shortcuts, identical to helpers we could have written ourselves (like the ones in metal renderer), and also includes all the default values on all the descriptors specified by the spec. It's just one cpp file that we compile ourselves and link against the C API, so technically we're still linking against the C API (we get the advantages that come with it, e.g could link against the rust implementation too)

I would suggest maybe doing that change later on, if you wish ?

Yeah, nothing urgent.

both WebGPU through Emscripten
I also have some fixes to Emscripten webgpu library

Yeah, that was the reason for me asking, as WebGPU headers are currently outdated (https://github.com/emscripten-core/emscripten/issues/11007). I wonder if your fixes are covered by https://github.com/emscripten-core/emscripten/pull/11067 ? That PR is imminent to land, would be great to have your fixes bubble upstream after that, if there are some still needed.
Hey, any chance you'd be able to zip up a few Emscripten built samples (in release mode)? I've been pondering how much JS garbage the current WebGPU library in Emscripten generates and if there will be some work that to clean that up. With a build or two I should be able to answer that.
Great work here!


Angular 2 + Go endpoints

Hello,
I am looking an example with angular 2 + go-endpoints. Is there any chance to have your example converted to Angular 2 ?
Thanks

i'm confused what you are asking for.
closing since this is old, but please reopen with more context if you'd still like this.


Sonos Play One - use for playback

How can i define the speaker as "use for playback"?

Sonos is not supported by Spotify Web API.


Web export exports an unknown file

Whenever you export a file in the web build, it exports a file called "Unknown" for SVG and "png" for PNG without a file extension. Simply changing these files to add a .svg or .png seems to fix it but it still would be nice to be fixed.

I can confirm this, although for SVGs I get a letter jumble rather than "Unknown".

Ah, I'm on MacOS so that might be why I'm getting Unknown.

https://github.com/MewPurPur/GodSVG/blob/0b9030c8d354c084ec0c3f4aaeb115fa590c17b1/src/HandlerGUI.gd#L317-L323

Yeah, it does I'm working on a fix right now.


Material Class add getters

At the moment it is not possible to view the stored values of a material. For example the value for metallic or rougness factor.
When i am converting a gltf at runtime and want to change the original material, it would be great if i have the possibility to copy the original values to the new material.
The "MaterialParameters" Class has already specific getters for each material type. But this class is private.

I have that problem, too. Wish me more functions in the material class.
Example: Delete textures, return current texture, ...


Use valid licence registry identifier for Apache-2.0 licence

This is so that Poetry sets the licence classifier correctly.
It only parses licences that contain a precise licence registry identifier
Fixes #138

@veronikasiska thank you for the contribution


Avoid potential NilClass error in attributes file

Description
Add a nil check for node['lsb'] and node['lsb']['codename'] before setting the distribution attribute.
Issues Resolved
This fixes a potential NilClass error that arises if the cookbook is compiled on a Windows box.
We have a production environment cookbook with recipes for predominantly Linux nodes but a few Windows nodes as well. This cookbook causes a NilClass error in the compile stage because Windows boxes don't have a node['lsb'] attribute.

We should probably actually fail hard with LSB isn't there. If you're setting the repos up without that distro it's not going to work.

What is the pattern for a hard fail?
So that my issue is clear, the current cookbook causes Chef to fail in the compile phase on Windows nodes which are not directly calling the cookbook. The Winows nodes happen to be in the same environment as Linux nodes which are including chef-apt-docker and on those nodes everything is fine.
I don't want Chef to fail on the Windows nodes just because they don't have the LSB codename attribute.

+1 to getting this merged in. I am experiencing the same issue as @hobochili. This prevents the use of this cookbook as a dependency in multi-platform cookbooks such as role cookbooks.

+1 on getting this merged.

The real solution is to upgrade the docker cookbook since this cookbook isn't necessary with the new version of the cookbook, but I can ship this as-is since it does fix the windows node issue.


python 3.11 compatabilty?

I am trying to install python-pptx on python 3.11 and it is not working any advice

What happens when you try? (I need to test my package that uses python-pptx on 3.11 soon - else my users will raise an Issue on my repo, too.) :-)

It fails the pip install. Had to switch to Python 3.7 I think it'll work with 3.9 but I had 3.7 already installed so went with that.

3.10 has issues with collections package as well.


Ipc custom timeout

Summary: When turning on debug logging in RialtoSever, API calls can take longer than the default set in the Ipc client. This change enables the user to increase this timeout at runtime.
Type: Feature
Test Plan: Unittests
Jira: N/A

https://jenkins.code.rdkcentral.com/job/github-triggered/33747/ started

https://jenkins.code.rdkcentral.com/job/build-component/71347/ started.

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/github-triggered/2115/ started

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/build-component-platform/4434/ started.

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/github-triggered/2116/ started

https://jenkins.code.rdkcentral.com/job/build-component/71349/ started.

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/build-component-platform/4436/ started.

Sanity tests for ['RPI3 Refapp2'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/10426/

Sanity tests for ['RPI3 Hybrid/MC'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/10427/

Sanity tests for ['BCM Reference Refapp2'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/10429/

https://jenkins.code.rdkcentral.com/job/github-triggered/33755/ started

https://jenkins.code.rdkcentral.com/job/build-component/71356/ started.

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/github-triggered/2119/ started

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/build-component-platform/4442/ started.

Sanity tests for ['RPI3 Refapp2'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/10436/

Sanity tests for ['RPI3 Hybrid/MC'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/10437/

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/github-triggered/2120/ started

https://jenkins.code.rdkcentral.com/job/github-triggered/33757/ started

https://jenkins.code.rdkcentral.com/job/build-component/71358/ started.

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/build-component-platform/4446/ started.

Sanity tests for ['BCM Reference Refapp2'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/10438/

Sanity tests for ['RPI3 Hybrid/MC'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/10440/

Sanity tests for ['RPI3 Refapp2'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/10439/

Sanity tests for ['BCM Reference Refapp2'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/10443/


New csproj + same folder + VS2017: project restore/compilation interference

Grab the source code from here: https://github.com/controlflow/resharper-heapview.git
Notice I have a few .csproj files in the same directory referencing different versions of the same package ID. Open in VS 15.0.0+26228.9 and observe the weird interference of package restore:

So the problem here are:

Package restore of 'wave06'-suffixed project for some reason produces wrong package version presentation under 'Dependencies' Solution Explorer node for 'wave08'-project.
When I load 'wave06'-suffixed project into solution, the 'wave08' projects stops compiling because of missing nuget dependency. If I load 'wave07' project, 'wave08' compiles fine. Turns out this is because 'wave06' project is targeting .NET Framework 4.0 while 'wave07'/'wave08' is targeting .NET Framework 4.5.

I don't think misguided presentation and build failures are expected behavior in any way. Looks like this is the result of some project model interference happening between unrelated projects.

Thanks for the repro, this is very likely https://github.com/NuGet/Home/issues/4463.
This MSBuild bug will also break up-to-date: https://github.com/Microsoft/msbuild/issues/1645.

@natidea Can you confirm this is the same as the NuGet above?

Confirmed that this is a dupe of https://github.com/NuGet/Home/issues/4463
Only one of the project.assets.json files survive and the project listed in the file is properly resolved, while the other projects are not.


Modus Data Table - Column Resizing - Add a tooltip message to the truncated cell text

There are some challenges with the existing Modus Tooltip component.
Tooltip issue.docx

This depends on the spike for Tooltip #1445

Should not show tooltip when wrapping is enabled in #1998

@ElishaSamPeterPrabhu This is marked as done in web components project. If I understand correctly this issue is about displaying tooltip when the text is truncated, Could you tell me how to test this if already implemented?

@ElishaSamPeterPrabhu This is marked as done in web components project. If I understand correctly this issue is about displaying tooltip when the text is truncated, Could you tell me how to test this if already implemented?

The issue is moved to done by mistake will move it back to inreview


Source Control Working Tree does not make it clear which is the current file.

When checking code into via 'Source Control' it displays the 'Working Tree'.
The problem is that the UI does not make it clear which version is the 'edit' version and which is the original 'unedit' version.
I will often come back to a project that has some outstanding commits and not remember specially what the work was. (I often get dragged away on other projects with incomplete work).
It will make life much easier if the UI gave a clear indication as to which window was showing the edited vs original version of the code.

The original version is always the left-hand side text document which you can't edit at all. You can clearly see it by the colors of the decorations as well:

By editing a line, you're effectively deleting it and adding a new one.

Sorry but you statement is neither correct nor an acceptable method.
There are some circumstance where neither window is editable.
I think this happens after you stage a commit.
This is exactly the moment when you need to know which is which.
Its also not acceptable to suggest that a user has to make bogus edits to determine which window is the update version.
Other ide's recognise this as an issue and provide an appropriate indication.
This is a common workflow issue and a constant annoyance.


Logistical Sorter size mode not working as expected

Firstly, thanks for your great work on this mod! With that out of the way, I think I've found a bug.
I have a chest A and a chest B connected like this:
A --> Logistical Sorter --> Basic Logistical Transporter --> B.
The Logistical Sorter has 1 filter defined in Size mode:
All works fine when chest B has spare capacity, but when chest B is full or close to full, the Size Mode functionality seems to break.
If chest B is completely full (and chest A has lots of cobblestone still in it) then as expected nothing is sent. If I then remove 32 cobblestone from chest B, I would still expect nothing to be sent as I have defined a minimum of 64 in the filter. However, the sorter immediately sends 32 cobblestone to fill up chest B again.
Interestingly, on trying to reproduce this for this bug report, I discovered that it only happens on the 2nd and subsequent time i.e. if chest B is full of cobblestone when you set this system up, just removing 32 cobblestone will NOT trigger the sorter. However, if you remove a full stack so that it triggers once, and then remove just 32, it will trigger without respecting the minimum size constraint.
I initially discovered this issue with Mekanism 1.7.10-<IP_ADDRESS>1 but have confirmed it since in 1.10.2-<IP_ADDRESS>4.

Fixed! I was forgetting to take into account the min stack size when pulling a destination from the path cache.


Trusted Certificate

Create new resource for Trusted Certificate.
Example Usage
resource "appgate_trusted_certificate" "test_trusted_certificate" {}

duplicate, already fixed.


python312Packages.pyituran: init at 0.1.4

Module to interact with the Ituran web service
https://github.com/shmuelzon/pyituran

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 364273

x86_64-linux

:white_check_mark: 4 packages built:

python311Packages.pyituran
python311Packages.pyituran.dist
python312Packages.pyituran
python312Packages.pyituran.dist


Migrate remaining test code to patchExpectedResult2()

See individual commits.
GoDepFunTest is still left as todo for a future PR.

Are the usual test de-indentation changes coming in another follow-up PR?

yes.


Change the name of isCorporateIP() function in IP-Based template

Change the name of isCorporateIP() function in IP-Based template to isIpInSubnets() and add it as a generic function that can be used in other places.
Refer doc page https://docs.wso2.com/display/IS580/Configuring+IP-Based+Adaptive+Authentication

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


De-dup the docs to some extent. Simplify setup.py. Fixes #7

Coverage remained the same at 100.0% when pulling da0aa57d20891780a88ecc809adf71ab23b4c860 on travis into 1fd0a2b6d9a2993e4247f69b82df373971c7e073 on master.


Added a missing closing brace to the Haml example.

Previous code throws a javascript exception.

good catch, thanks


remove unused styles

Fixes #61.

LGTM, not even sure why these styles are in there in the first place... did they used to be used?

I don't see any current use. Not sure if they have been used in the past either.

They were most likely copied straight from the ancient template project and simply never removed.

This ready to be merged? Looking forward to seeing that deprecation warning gone :-)

I will merge this and do a patch release once the CI build have finished green.

:ship: 0.4.4.


Lytics metafora k8s

Or alternately, lets git branch master into master-upstream and make this master?

This is needed to get our changes on master so go get -u github.com/araddon/gou works correctly.
https://github.com/araddon/gou/issues/21


Unexpected behaviour for Excel formulas in export

Considering this stackoverflow question: https://stackoverflow.com/questions/65412389/alasql-exported-excel-formula-not-working/65424882#65424882
I looked at the prepareSheet function: https://github.com/agershun/alasql/blob/master/src/833xlsx.js
columns.forEach(function(col, idx) {
	var cell = {v: data[j][col.columnid]};
	if (typeof data[j][col.columnid] == 'number') {
		cell.t = 'n';
	} else if (typeof data[j][col.columnid] == 'string') {
		cell.t = 's';
	} else if (typeof data[j][col.columnid] == 'boolean') {
		cell.t = 'b';
	} else if (typeof data[j][col.columnid] == 'object') {
		if (data[j][col.columnid] instanceof Date) {
			cell.t = 'd';
		}
	}
	cells[alasql.utils.xlsnc(col0 + idx) + '' + i] = cell;
});

Anybody trying to export a formula e.g. =A2+B2 will open their output spreadsheet and see that string =A2+B2 and not the result of the formula because the XLSX library flags to Excel that it is a string i.e. cell.t == 's' with cell.v == '=A2+B2'. Most Excel users will likely expect that =A2+B2 would just evaluate and the poster in the SO question has to manually force this. With XLSX a formula is e.g. cell.f == 'A2+B2' (dropping the =).
In case you guys encounter feature requests around this, the update is fairly straightforward e.g. maybe a utility function
function strIsXlFunction(str) {
  if (typeof str !== 'string') return false;
  return str.substr(0, 1) == '=';
}

And then in that block in prepareSheet you can do:
columns.forEach(function(col, idx) {
	var cell;
	if (foo.strIsXlFunction(data[j][col.columnid])) {
		var f = data[j][col.columnid];
		cell = {f: f.substr(1, f.length - 1)}
	} else {
		cell = {v: data[j][col.columnid]};
		if (typeof data[j][col.columnid] == 'number') {
			cell.t = 'n';
		} else if (typeof data[j][col.columnid] == 'string') {
			cell.t = 's';
		} else if (typeof data[j][col.columnid] == 'boolean') {
			cell.t = 'b';
		} else if (typeof data[j][col.columnid] == 'object') {
			if (data[j][col.columnid] instanceof Date) {
				cell.t = 'd';
			}
		}
	}
	cells[alasql.utils.xlsnc(col0 + idx) + '' + i] = cell;
});

Excel formulas are a seething pit of corner cases and I guess you guys have looked at this behaviour before. There is an obvious call for a configuration setting e.g. parseAsFormula which can be false for people who genuinely want to string to stay as a string and not have alasql be opinionated about this... 😃

This is epic! thank you so much :)


mouse gene descriptions using phenotype summary

Mouse gene descriptions on gene detail pages are using a phenotype summary, not a gene summary - was this intentional?
example: http://staging.alliancegenome.org/gene/MGI:109337
PS- MGI does not have phenotype summaries for all genes, has only for the ones with MGI-curated phenotype data.

should fix

Spoke with Joel regarding this issue (DQM). He said he'll coordinate with @cindyJax to obtain new data.


Background Music Added

For now, I think this is a great addition, I'm going to merge it expecting that we can add more sounds and make this better.


Update docs for version 2

[x] document data-polyfill attribute
[ ] document relation to the better-time-element

Are better-time-element and better-emmet-plugin needed? If so, which versions?
They are mentioned in the docs, but weren't downloaded by "bower install better-dateinput-polyfill".
Installing them standalone through bower leads to a bunch of version conflict choices as different versions are required by different modules, so right now I'm getting javascript errors and obviously made bad choices.
PS/ On the docs:  "For example, the code below defines a dateinput that uses a native implementation on mobile phones, but ALL desktop browsers (even Chrome desktop) will have a consistent widget created by the polyfill." is ? or should it be ?

Ah, ok, I've worked it out. bower is installing an older version that doesn't match the one in the docs. Hence only

is needed, but the data-polyfill mobile/desktop options don't appear to work on that version.
To install the latest version, mentioned in the docs needs
bower install better-dateinput-polyfill#2.0.0-rc.4
which seems to work with the data-polyfill mobile/desktop options but has weird positioning issues that I'll have to investigate.
Anyway, for those of us who aren't fully up to date with bower, it might be worth updating the docs to explain that they refer to the latest dev version, but bower will install an older version.

@tomhicz thank for the notice. The version 2 will be released soon, and it should solve confusion in the docs.

Thanks for that @tomhicz

Version 2.0.0 should be available at bower now.


apt_key warning

Warning: /Apt_key[Add key: D88E42B4 from Apt::Source elasticsearch]: The id should be a full fingerprint (40 characters), see README.
Change D88E42B4 into 46095ACC8548582C1A2699A9D27D666CD88E42B4 in the repo.pp
Thx!

Hi,
This is a known issue indeed. This is caused by using the short key which is required for some of the older puppet Enterprise versions i'm supporting which are pinned using older apt module versions.
As soon as i can drop support for those i'll update it, but figured a warning is better then dropping support for things :-)


fix pipeline run monitoring checking Queued status

Fix issue #23801

@minhe-msft : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Hi @minhe-msft thanks for fixing the doc.
It's better to use the private repo, so you can see your work in a preview, and check Acrolinx score for spelling/grammar.
For example azure-docs-pr repo:
https://github.com/MicrosoftDocs/azure-docs-pr/blob/master/articles/data-factory/monitor-programmatically.md
If you get 404, to get access, follow these instructions.

Close pull request, will resubmit from different repo.


MSFT_SPFeature Get-TargetResource returns typo in param name

Details of the scenario you try and problem that is occurring:
The Get-TargetResource function of the MSFT_SPFeature resource has a typo in the return param name "InstallAccount". The following return block:
return @{
Name = $params.Name
FeatureScope = $params.FeatureScope
Url = $params.Url
InstalAcount = $params.InstallAccount
Ensure = $currentState
Version = $featureAtScope.Version
}
Is missing a 2nd 'l' in "InstallAccount".
The DSC configuration that is using the resource:
N/A
Version of the Operating System and PowerShell the DSC Target Node is running:
WMF 4 / Win 2012 R2
Version of the DSC module you're using:
<IP_ADDRESS>

This was also fixed in PR #491

@BrianFarnhill  @ykuijs  Somehow the issue still exsits on the current branch. was the PR even approved? Thanks

@BrianFarnhill @ykuijs ok, I figured this one out. It was partially fixed in <IP_ADDRESS>.
In <IP_ADDRESS> is was showing as InstalAcount, therefore missing both an 'l' and a 'c'. We've fixed the missing 'c' in <IP_ADDRESS>., but it is still missing an 'l'.
V<IP_ADDRESS> has it returned as "InstalAccount" now

I am on it, will be fixed in a bugfix PR

This has been merged to dev and will ship in our next release, closing this issue


fix: move postinstall to prepare

What did you fix?
move postinstall to prepare, no downstream dependency issues
use husky, commitlint

Reproduction steps

Evidence/screenshot/link to line

Considerations

Does this contain a new dependency? [Yes]
Does this introduce opinionated data formatting or manual data entry? [Yes]
Does this pr include updated data files in a separate commit that can be reverted for a clean code-only pr? [Yes]
Have I run the linter? [Yes]
Is is a bug fix, feature request, or enhancement? [Maintenance]

:tada: This PR is included in version 2.0.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Note/event counter

Would be cool to have a note/event served counter like the oldd page web counter "1234 visits on njump"

That's not a bad idea.

Would also be good to have this on the njump dot me main page.

@dtonon


Update Layout.tsx title

WHY are these changes introduced?
Previously the line-height was quite large causing issues with store titles that were long
Before

After

WHAT is this pull request doing?
this PR removes the line-height from a title as titles generally should have a minimal line-height if any (other than the font-size itself)

HOW to test your changes?
Create a store with a long store name
Post-merge steps

Checklist

[x] I've read the Contributing Guidelines
[x] I've considered possible cross-platform impacts (Mac, Linux, Windows)
[x] I've added a changeset if this PR contains user-facing or noteworthy changes
[x] I've added tests to cover my changes
[x] I've added or updated the documentation

Notes
I wasn't sure if this PR warrented a changeset, if you feel its needed, happy to create one :)

Thanks, do you mind generating a changeset for this as well?


Changes to support generator data as json stream

Beginning pylint and unit tests.
See https://cmssdt.cern.ch/jenkins/job/DMWM-PR-test/522/ for details

Please do not merge this PR yet, since we're experimenting with Yuyi to reduce memory footprint of DBS code. There are other changes which may be required.

Summary of pylint changes for pull request 6221:
test/python/WMCore_t/WebTools_t/REST_t.py fails the pylint check. Report follows:

Line 29 E1101 Instance of 'DefaultConfig' has no 'SecurityModule' member
Line 30 E1101 Instance of 'DefaultConfig' has no 'Webtools' member
Line 32 E1101 Instance of 'DefaultConfig' has no 'SecurityModule' member
Line 35 E1101 Instance of 'DefaultConfig' has no 'SecurityModule' member
Line 36 E1101 Instance of 'DefaultConfig' has no 'SecurityModule' member
Line 37 E1101 Instance of 'DefaultConfig' has no 'SecurityModule' member
Line 38 E1101 Instance of 'DefaultConfig' has no 'SecurityModule' member
Line 47 in RESTTest.initialize E1101 Instance of 'DefaultConfig' has no 'Webtools' member
Line 48 in RESTTest.initialize E1101 Instance of 'DefaultConfig' has no 'SecurityModule' member
Line 52 in RESTTest.initialize E1101 Instance of 'DefaultConfig' has no 'SecurityModule' member
Line 53 in RESTTest.initialize E1101 Instance of 'DefaultConfig' has no 'SecurityModule' member
Line 54 in RESTTest.initialize E1101 Instance of 'DefaultConfig' has no 'SecurityModule' member
Line 55 in RESTTest.initialize E1101 Instance of 'DefaultConfig' has no 'SecurityModule' member
Line 56 in RESTTest.initialize E1101 Instance of 'DefaultConfig' has no 'SecurityModule' member
Line 59 in RESTTest.initialize E1101 Instance of 'DefaultConfig' has no 'Webtools' member
Line 60 in RESTTest.initialize E1101 Instance of 'DefaultConfig' has no 'Webtools' member
Line 170 in RESTTest.testA W0612 Unused variable 't'
Line 184 in RESTTest.testSanitisePass.func W0212 Access to a protected member _sanitise_input of a client class
Line 238 in RESTTest.testSanitiseAssertFail.func W0212 Access to a protected member _sanitise_input of a client class
Line 51 in RESTTest.initialize W0201 Attribute 'tempFile' defined outside init
Line 62 in RESTTest.initialize W0201 Attribute 'urlbase' defined outside init
Line 42 in RESTTest.initialize W0201 Attribute 'config' defined outside init
Line 44 in RESTTest.initialize W0201 Attribute 'do_production' defined outside init
Line 43 in RESTTest.initialize W0201 Attribute 'do_debug' defined outside init
Line 40 in RESTTest R0904 Too many public methods (36/20)
plus 99 comments on code style

Pre-python 2.6 idioms found in changed files. Please consider updating the code. Suggested patch follows:
--- test/python/WMCore_t/WebTools_t/DummyRESTModel.py (original)
+++ test/python/WMCore_t/WebTools_t/DummyRESTModel.py (refactored)
@@ -138,7 +138,7 @@
         return aList

     def listTypeValidate(self, request_input):
-        if type(request_input["aList"]) != list:
+        if not isinstance(request_input["aList"], list):
             request_input["aList"] = [int(request_input["aList"])]
         else:
             request_input["aList"] = map(int, request_input["aList"])
@@ -160,7 +160,7 @@
             pass
         # Checks its first request_input contains a int
         try:
-            assert type(request_input['input_int']) == type(123)
+            assert isinstance(request_input['input_int'], type(123))
         except AssertionError:
             raise AssertionError('val_1 failed: %s not int' % type(request_input['input_int']))
         return request_input

Beginning pylint and unit tests.
See https://cmssdt.cern.ch/jenkins/job/DMWM-PR-test/526/ for details

@ticoann, Seangchan, I think we can merge this, since changes I made will only reflect DBS code which may switch to generator. I provided unit tests anyway and fixed some issues with it suggested by pylint. Yuyi claimed that usage of generator already improve single DBS API by 30% memory wise and in order to DBS use generators we'll need this change in WMCore. Later I may refactor WMCore again to move this part directly to the exposed layer of public API.

Summary of pylint changes for pull request 6221:
test/python/WMCore_t/WebTools_t/REST_t.py fails the pylint check. Report follows:

Line 29 E1101 Instance of 'DefaultConfig' has no 'SecurityModule' member
Line 30 E1101 Instance of 'DefaultConfig' has no 'Webtools' member
Line 32 E1101 Instance of 'DefaultConfig' has no 'SecurityModule' member
Line 35 E1101 Instance of 'DefaultConfig' has no 'SecurityModule' member
Line 36 E1101 Instance of 'DefaultConfig' has no 'SecurityModule' member
Line 37 E1101 Instance of 'DefaultConfig' has no 'SecurityModule' member
Line 38 E1101 Instance of 'DefaultConfig' has no 'SecurityModule' member
Line 47 in RESTTest.initialize E1101 Instance of 'DefaultConfig' has no 'Webtools' member
Line 48 in RESTTest.initialize E1101 Instance of 'DefaultConfig' has no 'SecurityModule' member
Line 52 in RESTTest.initialize E1101 Instance of 'DefaultConfig' has no 'SecurityModule' member
Line 53 in RESTTest.initialize E1101 Instance of 'DefaultConfig' has no 'SecurityModule' member
Line 54 in RESTTest.initialize E1101 Instance of 'DefaultConfig' has no 'SecurityModule' member
Line 55 in RESTTest.initialize E1101 Instance of 'DefaultConfig' has no 'SecurityModule' member
Line 56 in RESTTest.initialize E1101 Instance of 'DefaultConfig' has no 'SecurityModule' member
Line 59 in RESTTest.initialize E1101 Instance of 'DefaultConfig' has no 'Webtools' member
Line 60 in RESTTest.initialize E1101 Instance of 'DefaultConfig' has no 'Webtools' member
Line 170 in RESTTest.testA W0612 Unused variable 't'
Line 184 in RESTTest.testSanitisePass.func W0212 Access to a protected member _sanitise_input of a client class
Line 238 in RESTTest.testSanitiseAssertFail.func W0212 Access to a protected member _sanitise_input of a client class
Line 51 in RESTTest.initialize W0201 Attribute 'tempFile' defined outside init
Line 62 in RESTTest.initialize W0201 Attribute 'urlbase' defined outside init
Line 42 in RESTTest.initialize W0201 Attribute 'config' defined outside init
Line 44 in RESTTest.initialize W0201 Attribute 'do_production' defined outside init
Line 43 in RESTTest.initialize W0201 Attribute 'do_debug' defined outside init
Line 40 in RESTTest R0904 Too many public methods (36/20)
plus 99 comments on code style

Unit test changes for pull request 6221:

WMCore_t.WebTools_t.REST_t.RESTTest:testGeneratorMethod was added. Status is success

Beginning pylint and unit tests.
See https://cmssdt.cern.ch/jenkins/job/DMWM-PR-test/557/ for details

Summary of pylint changes for pull request 6221:
test/python/WMCore_t/WebTools_t/REST_t.py fails the pylint check. Report follows:

Line 29 E1101 Instance of 'DefaultConfig' has no 'SecurityModule' member
Line 30 E1101 Instance of 'DefaultConfig' has no 'Webtools' member
Line 32 E1101 Instance of 'DefaultConfig' has no 'SecurityModule' member
Line 35 E1101 Instance of 'DefaultConfig' has no 'SecurityModule' member
Line 36 E1101 Instance of 'DefaultConfig' has no 'SecurityModule' member
Line 37 E1101 Instance of 'DefaultConfig' has no 'SecurityModule' member
Line 38 E1101 Instance of 'DefaultConfig' has no 'SecurityModule' member
Line 47 in RESTTest.initialize E1101 Instance of 'DefaultConfig' has no 'Webtools' member
Line 48 in RESTTest.initialize E1101 Instance of 'DefaultConfig' has no 'SecurityModule' member
Line 52 in RESTTest.initialize E1101 Instance of 'DefaultConfig' has no 'SecurityModule' member
Line 53 in RESTTest.initialize E1101 Instance of 'DefaultConfig' has no 'SecurityModule' member
Line 54 in RESTTest.initialize E1101 Instance of 'DefaultConfig' has no 'SecurityModule' member
Line 55 in RESTTest.initialize E1101 Instance of 'DefaultConfig' has no 'SecurityModule' member
Line 56 in RESTTest.initialize E1101 Instance of 'DefaultConfig' has no 'SecurityModule' member
Line 59 in RESTTest.initialize E1101 Instance of 'DefaultConfig' has no 'Webtools' member
Line 60 in RESTTest.initialize E1101 Instance of 'DefaultConfig' has no 'Webtools' member
Line 170 in RESTTest.testA W0612 Unused variable 't'
Line 184 in RESTTest.testSanitisePass.func W0212 Access to a protected member _sanitise_input of a client class
Line 238 in RESTTest.testSanitiseAssertFail.func W0212 Access to a protected member _sanitise_input of a client class
Line 51 in RESTTest.initialize W0201 Attribute 'tempFile' defined outside init
Line 62 in RESTTest.initialize W0201 Attribute 'urlbase' defined outside init
Line 42 in RESTTest.initialize W0201 Attribute 'config' defined outside init
Line 44 in RESTTest.initialize W0201 Attribute 'do_production' defined outside init
Line 43 in RESTTest.initialize W0201 Attribute 'do_debug' defined outside init
Line 40 in RESTTest R0904 Too many public methods (36/20)
plus 99 comments on code style

Unit test changes for pull request 6221:

WMCore_t.DataStructs_t.LumiList_t.LumiListTest:testAnd was added. Status is success
WMCore_t.DataStructs_t.LumiList_t.LumiListTest:testCompact was added. Status is success
WMCore_t.DataStructs_t.LumiList_t.LumiListTest:testList was added. Status is success
WMCore_t.DataStructs_t.LumiList_t.LumiListTest:testNull was added. Status is success
WMCore_t.DataStructs_t.LumiList_t.LumiListTest:testOr was added. Status is success
WMCore_t.DataStructs_t.LumiList_t.LumiListTest:testRemoveSelect was added. Status is success
WMCore_t.DataStructs_t.LumiList_t.LumiListTest:testURL was added. Status is success
WMCore_t.DataStructs_t.Subscription_t.SubscriptionTest:testAcquiredFiles was added. Status is success
WMCore_t.DataStructs_t.Subscription_t.SubscriptionTest:testAvailableFiles was added. Status is success
WMCore_t.DataStructs_t.Subscription_t.SubscriptionTest:testCompleteFiles was added. Status is success
WMCore_t.DataStructs_t.Subscription_t.SubscriptionTest:testCompletedFiles was added. Status is success
WMCore_t.DataStructs_t.Subscription_t.SubscriptionTest:testFailFiles was added. Status is success
WMCore_t.DataStructs_t.Subscription_t.SubscriptionTest:testFilesOfStatus was added. Status is success
WMCore_t.DataStructs_t.Subscription_t.SubscriptionTest:testGetFileset was added. Status is success
WMCore_t.SiteScreening_t.BlackWhiteListParser_t.BlackWhiteListParserTest:testSEWhiteList was added. Status is success
WMCore_t.WebTools_t.REST_t.RESTTest:testGeneratorMethod was added. Status is success
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testContinuousSplittingSupport changed from failure to success
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testDataDirectiveFromQueue changed from error to success
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testLumiSplitTier1ReRecoWorkload changed from failure to success
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testMultiTaskProcessingWorkload changed from failure to success
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testPileupData changed from failure to success
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testRunWhitelist changed from error to success
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testTier1ReRecoWorkload changed from failure to success
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testWithMaskedBlocks changed from error to success
WMCore_t.WorkQueue_t.Policy_t.Start_t.Dataset_t.DatasetTestCase:testDataDirectiveFromQueue changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Dataset_t.DatasetTestCase:testMultiTaskProcessingWorkload changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Dataset_t.DatasetTestCase:testParentProcessing changed from success to failure
WMCore_t.WorkQueue_t.Policy_t.Start_t.Dataset_t.DatasetTestCase:testWhiteBlackLists changed from success to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testCloseWorkOpenBlocks changed from success to failure
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testParentProcessing changed from success to failure
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testPrioritiesWorkPolling changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testSplittingLargeInputs changed from success to failure
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testWMBSInjectionStatus changed from success to failure

retest this please

Beginning pylint and unit tests.
See https://cmssdt.cern.ch/jenkins/job/DMWM-PR-test/585/ for details

Summary of pylint changes for pull request 6221:
test/python/WMCore_t/WebTools_t/REST_t.py fails the pylint check. Report follows:

Line 29 E1101 Instance of 'DefaultConfig' has no 'SecurityModule' member
Line 30 E1101 Instance of 'DefaultConfig' has no 'Webtools' member
Line 32 E1101 Instance of 'DefaultConfig' has no 'SecurityModule' member
Line 35 E1101 Instance of 'DefaultConfig' has no 'SecurityModule' member
Line 36 E1101 Instance of 'DefaultConfig' has no 'SecurityModule' member
Line 37 E1101 Instance of 'DefaultConfig' has no 'SecurityModule' member
Line 38 E1101 Instance of 'DefaultConfig' has no 'SecurityModule' member
Line 47 in RESTTest.initialize E1101 Instance of 'DefaultConfig' has no 'Webtools' member
Line 48 in RESTTest.initialize E1101 Instance of 'DefaultConfig' has no 'SecurityModule' member
Line 52 in RESTTest.initialize E1101 Instance of 'DefaultConfig' has no 'SecurityModule' member
Line 53 in RESTTest.initialize E1101 Instance of 'DefaultConfig' has no 'SecurityModule' member
Line 54 in RESTTest.initialize E1101 Instance of 'DefaultConfig' has no 'SecurityModule' member
Line 55 in RESTTest.initialize E1101 Instance of 'DefaultConfig' has no 'SecurityModule' member
Line 56 in RESTTest.initialize E1101 Instance of 'DefaultConfig' has no 'SecurityModule' member
Line 59 in RESTTest.initialize E1101 Instance of 'DefaultConfig' has no 'Webtools' member
Line 60 in RESTTest.initialize E1101 Instance of 'DefaultConfig' has no 'Webtools' member
Line 170 in RESTTest.testA W0612 Unused variable 't'
Line 184 in RESTTest.testSanitisePass.func W0212 Access to a protected member _sanitise_input of a client class
Line 238 in RESTTest.testSanitiseAssertFail.func W0212 Access to a protected member _sanitise_input of a client class
Line 40 in RESTTest R0904 Too many public methods (36/20)
Line 51 in RESTTest.initialize W0201 Attribute 'tempFile' defined outside init
Line 62 in RESTTest.initialize W0201 Attribute 'urlbase' defined outside init
Line 42 in RESTTest.initialize W0201 Attribute 'config' defined outside init
Line 44 in RESTTest.initialize W0201 Attribute 'do_production' defined outside init
Line 43 in RESTTest.initialize W0201 Attribute 'do_debug' defined outside init
plus 99 comments on code style

Unit test changes for pull request 6221:

WMCore_t.WebTools_t.REST_t.RESTTest:testGeneratorMethod was added. Status is success
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testTeams changed from failure to success


The badges in the list-group example in docs are not visible

In the example here https://getbootstrap.com/docs/4.0/components/list-group/#with-badges the badges are not visible.
The example uses .badge-default class, but there is no such class for badges.
In branch b4-dev the example uses correct class .badge-primary.

already fixed on the v4 dev branch, (badge-default has been changed to badge-primary)

Closed thanks to @gijsbotje 👍


Clarify invalid geographic raster error message

Replace the message given when a file loaded does not validate as a geographic raster with the following

Validation Error: Unable to add file to resource. See Geographic Raster Resource Type Documentation [https://help.hydroshare.org/hydroshare-resource-types/geographic-raster/] for the requirements for files that can be added.

This should be changed for both the create resource page and adding files to an empty resource.

resolved

resolved


Add rewrite_ignore option to asset_hash extension

This allows for configuring the files that will be skipped when performing URL rewriting on the file content. This differs from the existing ignore option, which configures the files that won't have hashes added to the filename.
This stemmed from wanting to improve build times on a project by skipping the URL rewriting phase on some large minified JS files didn't contain any asset URLs. The discussion in https://github.com/middleman/middleman/issues/1563#issuecomment-122045822 also points to another potential use for this (skipping problematic files).
I did discover that it's currently possible to do something similar with a custom middleware, like this:
class InlineURLRewriterIgnores
  def initialize(app, options= {})
    @app = app
  end

  def call(env)
    if(env["PATH_INFO"] =~ %r{^/example})
      env["bypass_inline_url_rewriter"] = "true"
    end

    @app.call(env)
  end
end
use InlineURLRewriterIgnores

However, this seems to use an undocumented option (bypass_inline_url_rewriter), and it's a little more cumbersome, so I thought I'd submit this pull request, which would make that same configuration look more like:
activate :asset_hash, :rewrite_ignore => [
  %r{^/example},
]

This only adds the new :rewrite_ignore option to the AssetHash extension, but it would be easy to add this same handling to the other extensions that use the InlineURLRewriter middleware (AssetHost, CacheBuster, and RelativeAssets) if you'd be interested.
Let me know if you have any feedback on this approach, the name of the option, etc. Thanks!

This is really smart. I do think it should be on all those similar file-parsing middlewares you mention.
Thanks. Can you update this PR with those other ones too? That'd be amazing.

Sounds good, thanks for the feedback! And yup, I can get this pull request updated with the other extensions.

@tdreyno: I've pushed an extra commit that adds the rewrite_ignore option to the all the other extensions using the InlineURLRewriter middleware.
And it looks like Travis is failing, but the same tests are failing on master, so I don't think it's related to these additions. But let me know if you spot any issues.

So good. Thank you.


git ignores, format debian requirements in README

Updated ignores, format requirements for better readability,
regards

Do you really want to put all of /debian/ and /test/ in .gitignore, not just the files generated during the build?

True, only files added during build should be ignored, thanks for the hint

Can you update and resubmit the pull request?
If possible, please remove the README part as it's unrelated. I'll add the requested formatting manually.


add support for "vertical" orientation and "focus" centering methods

See https://github.com/nerfstudio-project/nerfstudio/pull/1543
Also default to "vertical" which works better than "up" (https://github.com/nerfstudio-project/nerfstudio/issues/1765)
Also rename train_split_percentage to train_split_fraction (https://github.com/nerfstudio-project/nerfstudio/pull/1497)
may help with https://github.com/autonomousvision/sdfstudio/issues/51

Sample usage: ns-train ... nerfstudio-data --center-method focus --orientation-method vertical
"focus" centering method should not be the default, because it is to be used only for datasets where cameras are looking at a single object (there's some rejection logic in it, so it won't generate stupid results if some cameras are looking elsewhere). The default "poses" centering method generates a reasonable center in most cases (except aerial surveys maybe).

@f-dy Awesome! Thanks for the PR. Will try it out later.


[DataStructure] Linear Linked List [Python]

@sangamcse Hello i would like to work on this issue.I think what is expected from me is to implement linear linked list in python isn't?

PR #235 is created for closing this issue. @sangamcse, can you please review the same?


Feature Request:support fcitx input

Tofi seems to start much faster than rofi and is more compatible than wofi in many wayland environments, which looks great. But can tofi support fcitx input method like rofi and wofi?
Rofi did not support fcitx and  ibus  at first, but later added imdkit support and then these input methods could be used. Can tofi also add imdkit support?

If the addition function will lose its fast characteristics, it is better to keep it as it is.
I'll use tofi and rofi together


Error Required field is not set

While following the article and adding the main.tf file and executing terraform plan I'm presenting Error: "features": required field is not set.
It appears that this is required even if the value is empty

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 43614930-38b7-9497-117c-5a6e5dd52201
Version Independent ID: 97159ddc-395c-9f5a-b561-47d3f0ca11ed
Content: Deploy with Terraform from Azure Cloud Shell
Content Source: articles/cloud-shell/example-terraform-bash.md
Service: azure
GitHub Login: @TomArcherMsft
Microsoft Alias: tarcher

@confused-nerd Thanks for your comment! We will review and provide an update as appropriate.

I was also able to reproduce the issue. Assigning content owner @TomArcherMsft for visibility, review and document enhancement consideration as appropriate.

This has now been fixed in all Terraform documentation. #please-close


Find an elegant way to use strict typing with variables (if exists)

Concept
This issue is a traceback to the variables strict typing implementation.
Implementation idea 1
from introspector.types import Float

PI: Float = Float
PI = 3.14
PI = 'string'

The third PI assignement should raise a TypeError, 'cause the type passed to PI is a Float.
The principle is to use the python's property tool or a custom property with the same behavior.
Then, the Float variable will returns an object with the __set__ and __get__ methods.
Implementation idea 2
This implementation is easy to do but very less elegant...
from introspector.types import Float

PI: Float = Float()
PI.value = 3.14
PI.value = 'string'

Same behavior than the first idea, but with more conventional way.

UPDATE: At this state a don't found a way to implement the idea 1.
Keeping to test before give up this model.


Deprecate and refactor

Deprecate:

templates.py
scenario_helpers.py

@khultman Both files deprecated, ready for merge.

@khultman Ready for merge, removed external dependency and removed unit tests from deprecated code


in-repo-engine in ember addon fails to build

I'm trying to create a in-repo-engine within a ember addon and I'm not able to start nor build the addon (dummy-app). I'm getting this error:
Cannot read property 'enabled' of undefined

Stack Trace and Error Report: /tmp/error.dump.e5d99cfb29ccbd62b159c3945d6708f4.log
An error occurred in the constructor for test-engine at {{LOCAL_PATH_TO_ADDON}}/test/test-addon/lib/test-engine

An error occurred in the constructor for test-addon at {{LOCAL_PATH_TO_ADDON}}/test/test-addon

({{LOCAL_PATH_TO_ADDON}} is just a placeholder I added to the original error-message, where of course locally would be the real path)
Those errors are coming from HERE or/and HERE.
I got it working by adding a current.lazyLoading && current.lazyLoading.enabled.... which I could find in other parts of the code like HERE. But not sure if this would end up as the desired behavior.
I'm not pretty sure whats wrong here or I misconfigured/missed something but I could reproduce it with the following steps:

ember addon test-addon
enter folder
ember install ember-engines
ember g in-repo-engine test-engine
ember build --production or ember s
error..

I tried the same for a normal app (by using the same steps but first replaced with ember new test-app) and it worked normally.
I add the current.lazyLoading && current.lazyLoading.enabled to my local node_modules and made some routes and tested the in-repo-engine in the addons-dummy app and seemed to work normally.
So, am I missing something? Or is this even possible a in-repo-engine within a addon?

Tested this issue with the steps provided and if there was an error, it seems to be resolved now. I can start the server without any issues and also mount the engine inside the dummy app. Creating a production build also works fine.


keras.layers.Concatenate fails with 5 dimensional tensors

When trying to use a Concatenate layer with two 5 dimensional tensors with all but the last dimension to 1, there is an "IndexError". In the provided example the result should be a tensor of shape (1, 1, 1, 1, 10). It works ok with <=4 dimensional tensors or when any of the first four dimension is not one.
Here is the code to reproduce the issue (python 3.11) :
import numpy as np
import tensorflow as tf
print("Tensorflow version = ", tf.__version__)
print("Keras version = ", tf.keras.__version__)
sys_details = tf.sysconfig.get_build_info()
cuda_version = sys_details["cuda_version"]
print("CUDA version = ", cuda_version)
cudnn_version = sys_details["cudnn_version"]
print("cuDNN version = ", cudnn_version)

tf.keras.layers.Concatenate()([
    np.arange(5).reshape(1, 1, 1, 1, 5),
    np.arange(5).reshape(1, 1, 1, 1, 5)
])

And here is the result
Tensorflow version =  2.18.0
Keras version =  3.6.0
CUDA version =  12.5.1
cuDNN version =  9
---------------------------------------------------------------------------
IndexError                                Traceback (most recent call last)
File ~/scripts/concatenate.py:12
      9 cudnn_version = sys_details["cudnn_version"]
     10 print("cuDNN version = ", cudnn_version)
---> 12 tf.keras.layers.Concatenate()([
     13     np.arange(5).reshape(1, 1, 1, 1, 5),
     14     np.arange(5).reshape(1, 1, 1, 1, 5)
     15 ])

File ~/.conda/pa311tf/lib/python3.11/site-packages/keras/src/utils/traceback_utils.py:122, in filter_traceback.<locals>.error_handler(*args, **kwargs)
    119     filtered_tb = _process_traceback_frames(e.__traceback__)
    120     # To get the full stack trace, call:
    121     # `keras.config.disable_traceback_filtering()`
--> 122     raise e.with_traceback(filtered_tb) from None
    123 finally:
    124     del filtered_tb

File ~/.conda/pa311tf/lib/python3.11/site-packages/keras/src/layers/merging/concatenate.py:70, in Concatenate.build(self, input_shape)
     60 for axis, axis_value in enumerate(
     61     reduced_inputs_shapes[i][1:], start=1
     62 ):
   (...)
     67     # but if tensor shapes are not the same when
     68     # calling, an exception will be raised.
     69     if axis != concat_axis and axis_value == 1:
---> 70         del reduced_inputs_shapes[i][axis]
     72 if len(reduced_inputs_shapes[i]) > self.axis:
     73     del reduced_inputs_shapes[i][self.axis]

IndexError: list assignment index out of range

Thanks for the report. Looks like the issue is with the Concatenate layer. You can use this instead:
out = keras.ops.concatenate(
    [
        np.arange(5).reshape(1, 1, 1, 1, 5),
        np.arange(5).reshape(1, 1, 1, 1, 5),
    ],
    axis=-1,
)

Fixed the issue.


Label chart axes (w/ numeric values).

For the raw data, pre-processed data, features, and training data.

For Y-axis, this task is pending on a pull request to ofxGrt.
For X-axis, not sure what to display.

Good to know... I think we may want to create our own fork of the GRT for development. We should still try to send changes upstream but I don't want to get stuck waiting for them to be merged. What do you think?
Replying here:
Agree with our own fork.

Great. I added you to my fork of the main GRT here: https://github.com/damellis/grt/

On Jan 22, 2016, at 3:50 PM, Ben Zhang<EMAIL_ADDRESS>wrote:
Good to know... I think we may want to create our own fork of the GRT for development. We should still try to send changes upstream but I don't want to get stuck waiting for them to be merged. What do you think?
Replying here:
Agree with our own fork https://github.com/nebgnahz/ofxGrt.
—
Reply to this email directly or view it on GitHub https://github.com/damellis/sensors/issues/5#issuecomment-174091881.

this issue is resolved...


[Bug] Compact view displays icons full size

Compact view displays icons at same size as comfortable mode but one by one vertically. I'm new to this site but I think they are supposed to be smaller than comfortable.

Hello @GentlemanSquid
First of all, thanks for your feedback and welcome.
It's possible for you to give me a screenshot where I can see at least two posters?
Also, what browser are you using?
Does this happen without filters as well?
Thanks

Thank you. I am using Chrome on Windows 10. Its the same without filters.

Thanks a lot for the screens.
I have more questions to help figuring what might be wrong:

Can you check that your chrome is updated?, This is done under the chrome menu > about chrome
does this happen on your library or also on the " all games" tab?
can you check on incognito? You don't need to login, just go to browse all games.
can you check again on other browser you might have installed?

Thank you again

Yes my chrome is up to date.

Happens on all games too.

Happens on incognito mode as well.

Happens in latest update of firefox and edge.

I'm happy to supply more images and answers.

Hello @GentlemanSquid
Thanks again for the heads up, i have been able to reproduce and solve the issue.
The compact view should be able working again. I suggest you to use it with vertical posters because with the other small ones I find it a bit oppresive.
You might need to have your caché flushed before seeing it correctly.
Thanks again, and don't doubt to open a new issue if you find any bugs or have any suggestions.

Fixed @ Summer 2020
Complete changelog at https://steam-backlog.com/changelog


Support emitting bindings only for things in Web Workers

WebIDL has extended attributes like [Exposed=(Window, Worker)] to mean that the item is available in workers and in the main window. The lack of an Exposed means only exposed on the main window.
We should take a set of target Exposed environments and only emit bindings to WebIDL things that are available in the target environments.
This will allow us to eventually use cargo features to control what we generate bindings to, and allow us to support portability between the main window and web workers.

https://heycam.github.io/webidl/#Exposed

Instead, we took the approach of just generating bindings when requested, and also having a feature per interface anyways. I think we can close this!


Add additional check for lib in format.js module require section.  …

…While running in electron, the node module objects exist, but the global lib doesn’t, so the code fails attempting to require in modules.  Checking to see if lib exists before requiring in from the lib directory solves the electron issue.

hi @johnwebbcole , and thanks for the fix !
Unfortunatly, the structure of the repo has changed quite significantly : please take a look at the dev branch here to see the new structure.
The good new is, I think the issue you mention should be already fixed, since it is now working flawlessly in node.js aswell.

I've been following the new dev branch with excitement.  However since I'm using trunk and it has the issue, I was hoping an easy fix could be added. I can continue to monkey patch around it though.  It would be nice to have bug fixes and releases made for the 0.5.x versions for those people using it.  It would give us a chance to port over to the new vNext version when dev gets promoted.

Yeah you are right, the in-between situation right now is not ideal, there has been some talk to have a regularly updated master with hot-fixes and a dev that is truly for dev, but to be honest that might need to wait until next release. Normally there are only a few things left to fix/update before the release, sorry for the complications in the meantime.

@johnwebbcole I don't have any issues with the change, as the change looks reasonable.
I have a feeling that a new release is about to happen. Can you wait?

@z3dev I don't think it's a question of waiting :-)  Since I have a lot of existing JsCad code that could benefit from a fix and tagged release, it's a question of how much time do I want to spend upgrading projects to the new release.  Some I will, some I'd rather keep at 0.5.x.
It would be very nice to have a tagged 0.5.x branch for future small fixes, like this one.  It would be even better to publish those to NPM along with the new release!

@johnwebbcole Sounds fine with me.
@Spiritdude Are you fine with a patch to 0.5.1?

@Spiritdude @z3dev   sorry to bug you again, but it would be really important to include & tag this before we switch to the new version. Since this does not introduce any breaking changes I think we should just merge it

@johnwebbcole guess what ? there is now a tagged release :)

A very good thing indeed...


python3Packages.zeroconf: 0.36.9 -> 0.36.11

Motivation for this change
Update to latest upstream release 0.36.11
Change log: https://github.com/jstasiak/python-zeroconf/releases/tag/0.36.11
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.


docker stack deploy should support removing a service

Description
Currently, if I run docker stack deploy --compose-file STACKFILE.yml STACKNAME multiple times, subsequent deploy commands update the stack to match the file, with one exception. If I remove a service, the service remains in the stack. This is a feature request to have the service removed if it isn't listed, or alternately have a remove key in the service definition.

/cc @dnephin @vdemeester @mgoelzer

Seconded. This can be an issue if you rename a service that is binding a specific port. The next deployment will fail.


Added usingJobData for Object

In submitting this contribution, I agree to the current Software AG contributor agreement as referred to here:
https://github.com/quartz-scheduler/contributing/blob/main/CONTRIBUTING.md
This PR...
Add

A property to be able to add an Object to JobData

Checklist

[x] tested locally
[ ] updated the docs
[ ] added appropriate test
[x] signed-off on the above mentioned SoftwareAG contributor agreement via git commit -s on my commits.
(If you're not using command-line, you can use a browser extension )

Fixes #

Unfortunately, due to the change of ownership of this project, the terms of contribution have been updated, and this PR will need to be re-created, agreeing to the new terms.