docs: samples and tests for auto-generated createDatabase and createInstance APIs.

Notes

Adds samples and tests for auto-generated createDatabase and createInstance APIs.
The sample code style is mostly consistent with our existing samples.
A new file path has been intentionally introduced so that the samples don't get updated immediately on public documentation - https://cloud.google.com/spanner/docs/create-manage-databases.
PR also adds some utility methods to manage instance creation/deletion for integration tests.

I think it looks good from my end. One last thing came to mind when looking at the samples (which may or may not be a concern for Spanner). In google-cloud-java, we had some issues with creating instances for certain services. The project were running the code in had some quotas and the tests/samples had some issues properly deleting the created instances. We just ended up prefixing the resources with something like it-test-compute (https://github.com/googleapis/google-cloud-java/blob/d0c836e0b6580ca2b5d9fe6a19d8be5da9496c1f/java-compute/google-cloud-compute/src/test/java/com/google/cloud/compute/v1/integration/BaseTest.java#L25) and deleting the stale instances prior to the tests being run: https://github.com/googleapis/google-cloud-java/blob/main/java-compute/google-cloud-compute/src/test/java/com/google/cloud/compute/v1/integration/Util.java


[WIP] Mark and sweep control mechanism

Mark and sweep control mechanism
Depends on:

[ ] https://github.com/ManageIQ/topological_inventory-core/pull/54

cc @agrare


xdebug configuration change - breaks coverage reports

We use this image for running PHPUnit test in as part of our GitLab CI process for projects. Today I have noticed that running PHP Unit configurations with clover reports for coverage no longer creates these reports.
In order to verify if it was something within the docker environment,I have gone to other another project that uses the same image and push a small text file to trigger the CI and confirmed the coverage report is not being created.

If it helps any, I cleared out our runner docker image cache to get room on the runner and to clear out unused image. So it would of have to pulled the latest image and re-ran the docker scripts.

A possible solution would be to add some configs as is done for OpCache
{ \
    echo 'xdebug.coverage_enable=1'; \

} > /usr/local/etc/php/conf.d/20-xdebug.ini

I just encountered a similar issue. Tests on Gitlab CI were running fine last week (using XDebug v2.9.8) and started failing today (using Xdebug v3.0.0beta1). Code hasn't changed much. The most likely cause seems to be the XDebug upgrade, or another change in the docker image.
My error message is different, though. I get a Segmentation fault (core dumped) / error code 139.
Here a the relevant logs:
Pulling docker image edbizarro/gitlab-ci-pipeline-php:7.3 ...

$ php -v
PHP 7.3.23 (cli) (built: Oct 13 2020 10:26:06) ( NTS )
[...]
Zend Engine v3.3.23, Copyright (c) 1998-2018 Zend Technologies
    with Zend OPcache v7.3.23, Copyright (c) 1999-2018, by Zend Technologies
    with Xdebug v3.0.0beta1, Copyright (c) 2002-2020, by Derick Rethans

> phpunit -c phpunit.dev.xml --colors=never --stderr --log-junit phpunit-report.xml --coverage-text
PHPUnit 9.3.2 by Sebastian Bergmann and contributors.
Warning:       xdebug.mode=coverage has to be set in php.ini
...............................................................  63 / 125 ( 50%)
....................................................Segmentation fault (core dumped)
Script phpunit -c phpunit.dev.xml --colors=never --stderr --log-junit phpunit-report.xml --coverage-text handling the coverage-ci event returned with error code 139

Experiencing the same issue (Segmentation fault) in all of our pipelines. Any plans to merge the attempted fix?

Same for me
Error: xdebug.coverage_enable=On has to be set in php.ini
Using 7.4 version

Same issue for 7.4
7.4-alpine works fine

I change xdebug back to 2.9.8 until PHP 8 release, i believe that everything should work now

@edbizarro we're seeing segfaults in CI (using 7.3 image) -- I see xdebug 3.0.2 instead of 2.x again.
did you change your mind on keeping xdebug frozen at 2.x until php 8?
Our latest failing CI:
PHPUnit 8.5.13 by Sebastian Bergmann and contributors.
Runtime:       PHP 7.3.26 with Xdebug 3.0.2
Configuration: /builds/optipub/guavo/phpunit.xml
...../bin/bash: line 132:  1150 Segmentation fault

Our latest passing CI:
PHPUnit 8.5.13 by Sebastian Bergmann and contributors.
Runtime:       PHP 7.3.24 with Xdebug 2.9.8
Configuration: /builds/optipub/guavo/phpunit.xml

This works for now:
before_script:
    - sudo pecl uninstall xdebug && sudo pecl install xdebug-2.9.8

hi @rocksfrow with the release of PHP 8 I think we can move forward to support only xdebug 3 as the default one
Ref: https://xdebug.org/docs/compat#versions

That would break all projects running older versions of PHPUnit (including still supported Laravel versions such as 7.x)

I guess I will stick w/ my before_script usage to avoid the seg faults until we can figure out what in the hell incompatible extension is causing these seg faults then. thanks for the feedback.

Magento 2 also breaks with XDebug as it throws:

Fatal error: Uncaught Error: Call to undefined function xdebug_disable() in /builds/lov/magento2/vendor/magento/magento2-functional-testing-framework/src/Magento/FunctionalTestingFramework/_bootstrap.php on line 78


Add GUI to Extra Utilities Fluid Trash Can

Опишите ваше предложение / Describe your proposal
Make ExU2 Fluid Trash Cans have a GUI, that way you can just put a cell with a fluid for example, and you get an empty cell back.

(an idea of what it would look like)
Какие проблемы решит/добавит ваше предложение? / What problems will your proposal solve / add?
No need to use portable tanks every time you wanna empty a fluid cell.
Объясните, почему ваше предложение должны реализовать? / Explain why your proposal should be implemented?
Quality of Life feature.

Most likely, I will add an void mode for all tanks, and then this will make no sense


Error: queueLoad failed

Hi there,
trying to set url2play i get:
chromecast.0 2018-03-16 08:56:56.329	error	room1 - Cannot play file "http://www.egofm.de/stream/192kb.m3u": Error: queueLoad failed
chromecast.0	2018-03-16 08:56:56.329	error	at Client.emit (events.js:182:7)
chromecast.0	2018-03-16 08:56:56.329	error	at emitMany (events.js:113:20)
chromecast.0	2018-03-16 08:56:56.329	error	at Client.onmessage (/opt/iobroker/node_modules/iobroker.chromecast/node_modules/castv2-player/node_modules/castv2-client/node_modules/castv2/lib/channel.js:23:10)
chromecast.0	2018-03-16 08:56:56.329	error	at Channel.emit (events.js:172:7)
chromecast.0	2018-03-16 08:56:56.329	error	at emitTwo (events.js:87:13)
chromecast.0	2018-03-16 08:56:56.329	error	at Channel.onmessage (/opt/iobroker/node_modules/iobroker.chromecast/node_modules/castv2-player/node_modules/castv2-client/lib/controllers/controller.js:16:10)
chromecast.0	2018-03-16 08:56:56.329	error	at MediaController.emit (events.js:172:7)
chromecast.0	2018-03-16 08:56:56.329	error	at emitTwo (events.js:92:20)
chromecast.0	2018-03-16 08:56:56.329	error	at MediaController.onmessage (/opt/iobroker/node_modules/iobroker.chromecast/node_modules/castv2-player/node_modules/castv2-client/lib/controllers/request-response.js:27:7)
chromecast.0	2018-03-16 08:56:56.329	error	at /opt/iobroker/node_modules/iobroker.chromecast/node_modules/castv2-player/node_modules/castv2-client/lib/controllers/media.js:149:23
chromecast.0	2018-03-16 08:56:56.329	error	room1- Error playing playlist - Error: queueLoad failed
On some other try to play it stated only this:
chromecast.0	2018-03-16 09:59:35.521	error	room1- Cannot play file "http://www.egofm.de/stream/192kb.m3u": Error: queueLoad failed
chromecast.0	2018-03-16 09:59:35.518	error	room1- Error playing playlist - Error: queueLoad failed at /opt/iobroker/node_modules/iobroker.chromecast/node_modules/castv2-player/node_modules/castv2-client/lib/controllers/
I restarted the adapter multiple times. I restarted my device. I got more devices, and they all behave the same. I tried on 1.3.5 and latest 1.4.2 - same thing.
Could you add some more information about the error reason?
kind regards
Manfred

I just found out that the reason is that is wont play this kind streams:
http://www.egofm.de/stream/192kb.m3u
or
http://www.egofm.de/stream/128kb.m3u
But these URLs worked already in my iobroker chromecast environment! And other players and browsers still do play this streams!
And on my iobroker chromecast adapter other stream sources work without problem!e.g. http://mp3-live.swr3.de/swr3_m.m3u or http://stream.klassikradio.de/smooth/mp3-192
I compared them already with VLC player media/codec information, coulnd find something obvious.
Tried other streams for the same radio station:
This stream represents the same radio station and works like a charm - no error message here:
http://mp3ad.egofm.c.nmdn.net/egofm_192/livestream.mp3
Can you please check on your side?

Ok, I debugged the http://www.egofm.de/stream/192kb.m3u URL and found four issues:

the code detecting the media type based in the URL had a bug and did not do anything -> fixed in the castv2-player library
the http://www.egofm.de/stream/192kb.m3u is a redirect to the mp3 file. IMO this is not valid -> an URL ending  in .m3u should be a playlist.
the icy module I use is a wrapper of http that does not follow redirects -> I will need to write a piece of code to follow redirects
chromecast do not like http with redirect - this will handled once I "pre-process" the URL before sending it to the Chromecast

For the time being the circumvention is to use the redirect target in url2play: http://mp3ad.egofm.c.nmdn.net/egofm_192/livestream.mp3

@manne01 - Please try version 1.4.3 (github only for now)

Thank you for checking this. I just installed 1.4.3 and tried playing http://www.egofm.de/stream/192kb.m3u but still get:
error JBLPlaylist - Cannot play file " http://www.egofm.de/stream/192kb.m3u": Error: ENOENT: no such file or directory, open ' http://www.egofm.de/stream/192kb.m3u'
or even

chromecast.0
2018-04-08 10:12:31.863
error
JBLPlaylist - Cannot play file "http://www.egofm.de/stream/192kb.m3u": Error: queueLoad failed

chromecast.0
2018-04-08 10:12:31.860
error
at Client.emit (events.js:182:7)

chromecast.0
2018-04-08 10:12:31.860
error
at emitMany (events.js:113:20)

chromecast.0
2018-04-08 10:12:31.860
error
at Client.onmessage  (/opt/iobroker/node_modules/iobroker.chromecast/node_modules/castv2-player/node_modules/castv2-client/node_modules/castv2/lib/channel.js:23:10)

chromecast.0
2018-04-08 10:12:31.860
error
at Channel.emit (events.js:172:7)

chromecast.0
2018-04-08 10:12:31.860
error
at emitTwo (events.js:87:13)

chromecast.0
2018-04-08 10:12:31.860
error
at Channel.onmessage  (/opt/iobroker/node_modules/iobroker.chromecast/node_modules/castv2-player/node_modules/castv2-client/lib/controllers/controller.js:16:10)

chromecast.0
2018-04-08 10:12:31.860
error
at MediaController.emit (events.js:172:7)

chromecast.0
2018-04-08 10:12:31.860
error
at emitTwo (events.js:92:20)

chromecast.0
2018-04-08 10:12:31.860
error
at MediaController.onmessage  (/opt/iobroker/node_modules/iobroker.chromecast/node_modules/castv2-player/node_modules/castv2-client/lib/controllers/request-response.js:27:7)

chromecast.0
2018-04-08 10:12:31.860
error
at  /opt/iobroker/node_modules/iobroker.chromecast/node_modules/castv2-player/node_modules/castv2-client/lib/controllers/media.js:149:23

chromecast.0
2018-04-08 10:12:31.860
error
JBLPlaylist - Error playing playlist - Error: queueLoad failed

chromecast.0
2018-04-08 10:12:30.998
info
JBLPlaylist - Try to play playlist with 1 items

chromecast.0
2018-04-08 10:12:30.925
info
JBLPlaylist - Try to play url - http://www.egofm.de/stream/192kb.m3u

I am sorry! Could it be differences in our environments?

Could you please check the version of the castv2-playerlibrary at /opt/iobroker/node_modules/castv2-player/package.json ? It should be 1.1.12 for it to work.
When I try to play your URL I get:
2018-04-08 19:05:19.324  - info: chromecast.0 audioBedroom - Try to play url - http://www.egofm.de/stream/192kb.m3u
2018-04-08 19:05:19.337  - info: chromecast.0 audioBedroom - Try to launch default player
2018-04-08 19:05:19.445  - info: chromecast.0 audioBedroom - Detected redirection (301) to https://www.egofm.de/stream/192kb.m3u
2018-04-08 19:05:19.539  - info: chromecast.0 audioBedroom - Detected redirection (302) to http://mp3ad.egofm.c.nmdn.net/egofm_192/livestream.mp3
2018-04-08 19:05:20.145  - info: chromecast.0 audioBedroom - Try to join player
2018-04-08 19:05:20.147  - info: chromecast.0 audioBedroom - Connected player
2018-04-08 19:05:20.148  - info: chromecast.0 audioBedroom - Player joint
2018-04-08 19:05:20.148  - info: chromecast.0 audioBedroom - Connected player
2018-04-08 19:05:20.149  - info: chromecast.0 audioBedroom - Default player lauched
2018-04-08 19:05:20.181  - info: chromecast.0 audioBedroom - Try to play playlist with 1 items
2018-04-08 19:05:21.459  - info: chromecast.0 audioBedroom - Playing playlist with 1 items
2018-04-08 19:05:23.499  - info: chromecast.0 audioBedroom - Playing - http://mp3ad.egofm.c.nmdn.net/egofm_192/livestream.mp3

I checked the version today. The lib is in /opt/iobroker/node_modules/castv2-player/ and the file package.json shows Version 1.1.12 so I guess this is correct.
Checked to play http://www.egofm.de/stream/192kb.m3u again, and -> it works and I have "your" log entries! I guess there was some restart or something missing before.
Great - thanks!!!

hey!
i got a intersting problem. both m3u files are identical but only on two different urls:
working:
http://streams.br.de/bayern3_2.m3u
not working:
http://services.hubermedia.de/partner/privat/playlist.m3u
here the error:

chromecast.0
2020-01-01 11:50:46.477
error
(878) Badezimmer_OG - Cannot play file "http://services.hubermedia.de/partner/privat/playlist2.m3u": Error: queueLoad failed

chromecast.0
2020-01-01 11:50:46.476
error
at TLSSocket. (/opt/iobroker/node_modules/iobroker.chromecast/node_modules/castv2/lib/packet-stream-wrapper.js:28:16)

chromecast.0
2020-01-01 11:50:46.476
error
at PacketStreamWrapper.emit (events.js:198:13)

chromecast.0
2020-01-01 11:50:46.476
error
at PacketStreamWrapper.onpacket (/opt/iobroker/node_modules/iobroker.chromecast/node_modules/castv2/lib/client.js:81:10)

chromecast.0
2020-01-01 11:50:46.476
error
at Client.emit (events.js:203:15)

chromecast.0
2020-01-01 11:50:46.476
error
at Client.onmessage (/opt/iobroker/node_modules/iobroker.chromecast/node_modules/castv2/lib/channel.js:23:10)

chromecast.0
2020-01-01 11:50:46.476
error
at Channel.emit (events.js:198:13)

chromecast.0
2020-01-01 11:50:46.476
error
at Channel.onmessage (/opt/iobroker/node_modules/iobroker.chromecast/node_modules/castv2-client/lib/controllers/controller.js:16:10)

chromecast.0
2020-01-01 11:50:46.476
error
at fn.emit (events.js:203:15)

chromecast.0
2020-01-01 11:50:46.476
error
at fn.onmessage (/opt/iobroker/node_modules/iobroker.chromecast/node_modules/castv2-client/lib/controllers/request-response.js:27:7)

chromecast.0
2020-01-01 11:50:46.476
error
at /opt/iobroker/node_modules/iobroker.chromecast/node_modules/castv2-client/lib/controllers/media.js:149:23

chromecast.0
2020-01-01 11:50:46.476
error
(878) Badezimmer OG - Error playing playlist - Error: queueLoad failed

any idea how i can fix this? i would like to create a simple playlist with several iradio stations in one m3u file.
thx
stefan


Add delegated stake commissions field to ValidatorEntry

Current dependencies on/for this PR:

feature/proof-of-stake

PR #579

PR #613   👈

This comment was auto-generated by Graphite.


Update Ui.png

Updated Ui.png with the latest ui

Pull Request Test Coverage Report for Build 262

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.002%

Totals

Change from base Build 261:
0.0%

Covered Lines:
2510

Relevant Lines:
2885

💛  - Coveralls


Fixed link-typos in server/mod.rs

Due to the case-sensitive file representation on docs.rs
For sure, this one does not lack on windows systems -- but the documentation is mostly served on posix systems -- as you know and already said at #61

Thanks!


fix(azure): Application creds, display and MFA policies

:tada: This PR is included in version 1.17.4 :tada:
The release is available on:

GitHub release
v1.17.4

Your semantic-release bot :package::rocket:


Cmake defines

Added "ENABLE_LEGION_TLS" to the legion_defines

@ipdemes The ENABLE_LEGION_TLS feature is still experimental until we've done some more benchmarking on the performance overhead that it incurs.  I'll keep this pull request around until we decide whether we want to make it part of the mainline Legion master branch or not.

@lightsighter , I think we need to have this logic in legion_defines as long as you have "#ifdef ENABLE_LEGION_TLS" anywhere in the source code. Otherwise cmake would be broken for those who need this option to be ON.

Yes, @streichler has informed me of my ignorance of cmake. :)  Merging the pull request.

@lightsighter , Thank you!!

@ipdemes If you're done with the branch, can you delete it? (There is button in this thread, or you can run git push origin --delete cmake_defines.)

@elliottslaughter , Sure. It should be removed now


feat: add gatsby theme transpilation

Add recommended transpilation of theme per Gatsby docs

Codecov Report

Merging #4 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master     #4   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           2      2
  Lines          20     20
  Branches        6      6
=====================================
  Hits           20     20

Impacted Files
Coverage Δ

...ackages/gatsby-theme-dslemay-core/gatsby-config.js
100% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 593f79f...1154337. Read the comment docs.


[{"resource":"Release","code":"already_exists","field":"tag_name"}]

My workflow.yml
name: REALEASE

on:
  push:
    tags:
      - "v*.*.*"

permissions:
  contents: write
  discussions: write

jobs:
  build:
    runs-on: ubuntu-latest
    name: production deploy
    steps:
      - uses: actions/checkout@v3
      - uses: pnpm/action-setup@v2
        with:
          version: 8
      - name: Use Node.js 16.x
        uses: actions/setup-node@v3
        with:
          node-version: 16.x
        env:
          CI: true
          PROGRESS: none
          NODE_ENV: test
          NODE_OPTIONS: --max_old_space_size=4096
      - name: pnpm install
        run: |
          echo ${{github.ref}}
          pnpm install
      - name: Build
        run: |
          echo ${{github.workspace}}
          pnpm build
      - name: Compress action step
        uses<EMAIL_ADDRESS>        id: compress
        with:
          command: c
          cwd: ./
          files: |
            ./apps/tools-site/dist
          outPath: tools-site.tar.gz
      - name: Release
        uses: softprops/action-gh-release@v1
        with:
          token: ${{secrets.CUSTOM_TOKEN}}
          name: ${{github.ref_name}}
          tag_name: ${{github.ref_name}}
          body_path: ./apps/tools-site/changelogs/${{github.ref_name}}.md
          discussion_category_name: Release
          files: tools-site.tar.gz

When I push a new tag, it starts to run the workflow, but it gives an error
👩🏭 Creating new GitHub release for tag v2.0.3...
⚠ GitHub release failed with status: 404
undefined
retrying... (2 retries remaining)
👩🏭 Creating new GitHub release for tag v2.0.3...
⚠ GitHub release failed with status: 4[22](https://github.com/xp-work/Test2/actions/runs/5655268949/job/15320028840#step:8:23)
[{"resource":"Release","code":"already_exists","field":"tag_name"}]
retrying... (1 retries remaining)
👩🏭 Creating new GitHub release for tag v2.0.3...
⚠ GitHub release failed with status: 422
[{"resource":"Release","code":"already_exists","field":"tag_name"}]
retrying... (0 retries remaining)
❌ Too many retries. Aborting...
Error: Too many retries.

When I went to check Release, I found a new release, indicating that the release was successful, but an error was reported in the workflow

Please tell me how to handle de-posting from an already existing tag without getting an error?
Or whether it should be added to the publishing process to determine whether the tag exists before deciding on the following actions

@AlbertXiaoPeng not sure if you find the problem. If not, can you check if you have the Discussions enabled in your repository and that the discussion_category_name name you use (Release in your example) is a valid category?
As mentioned in https://github.com/softprops/action-gh-release/issues/110#issuecomment-1793486584, the 404 when creating a release seems to be coming from the an invalid discussion category.


fix: fix physics system stablity

Please check if the PR fulfills these requirements

[ ] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:

You fix many bug in this PR, write as a list  to introduce is better

Another thing is:
/**
   * {@inheritDoc IPhysicsManager.addCharacterController }
   */
  addCharacterController(characterController: PhysXCharacterController): void {
    const lastPXManager = characterController._pxManager;
    const shape = characterController._shape;
    if (shape) {
      if (lastPXManager !== this) {
        lastPXManager && characterController._destroyPXController();
        characterController._createPXController(this, shape);
      }
      this._pxScene.addController(characterController._pxController);
    }
    characterController._pxManager = this;
  }


$_ENV is not enabled by default, $_SERVER should be used

Ubuntu has a default setting which only stores the environment variables in $_SERVER. The $_ENV is always empty, only when variables_order is changed to EGPCS $_ENV is available.
Quote from the php.ini:

; This directive determines which super global arrays are registered when PHP
; starts up. G,P,C,E & S are abbreviations for the following respective super
; globals: GET, POST, COOKIE, ENV and SERVER. There is a performance penalty
; paid for the registration of these arrays and because ENV is not as commonly
; used as the others, ENV is not recommended on productions servers. You
; can still get access to the environment variables through getenv() should you
; need to.

Therefore I think zend-console should use $_SERVER instead of $_ENV

Originally posted by @jaapio at https://github.com/zendframework/zend-console/issues/18

This package is abandoned and will receive no further development!
We recommend using laminas/laminas-cli.


Should be equal should show easier diffs

When calling Should be equal with multiline text, the error message is very difficult to read. There should be a cleaner diff in that case.
There could also be nicer diffs for lists.

Good idea. :)

Ready for review I think. @pekkaklarck would you check how this looks?

We decided to only add support for better multiline diffs at this point. Better list and dict comparison can be considered later.


Can't load model file

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
env from google colab
TensorFlow installed from (source or binary):
env from google colab
TensorFlow version (use command below):
1.6.0-rc1
Python version:
python 3.6

Describe the problem
I have code like this:
slim.assign_from_checkpoint_fn(
        pretrained_model_file,
        variables_to_restore,
        ignore_missing_vars=True)

when  pretrained_model_file = "vgg_19.ckpt", where vgg_19.ckpt is a checkpoint file from pre-trained model, it raise Exception:
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-29-b803c1b9c409> in <module>()
     10
     11
---> 12 demo()

<ipython-input-29-b803c1b9c409> in demo()
      7             "1000", "--network", "/content/vgg_19.ckpt",
      8             "--checkpoint-iterations", "10", "--checkpoint-output", "/content/tmp-tv-%s.jpg"]
----> 9     neural_style_main(args)
     10
     11

/usr/local/lib/python3.6/dist-packages/neural_style_demo/neural_style.py in main(args)
    178         pooling=options.pooling,
    179         print_iterations=options.print_iterations,
--> 180         checkpoint_iterations=options.checkpoint_iterations
    181     ):
    182         output_file = None

/usr/local/lib/python3.6/dist-packages/neural_style_demo/stylize.py in stylize(network, initial, initial_noiseblend, content, styles, preserve_colors, iterations, content_weight, content_weight_blend, style_weight, style_layer_weight_exp, style_blend_weights, tv_weight, learning_rate, beta1, beta2, epsilon, pooling, print_iterations, checkpoint_iterations)
     77                                                     naming="style-{}".format(i),
     78                                                     pretrained_model_file=pretrained_model_file,
---> 79                                                     checkpoint_exclude_scopes=checkpoint_exclude_scopes)
     80
     81         for index, layer in enumerate(STYLE_LAYERS):

/usr/local/lib/python3.6/dist-packages/neural_style_demo/losses.py in get_style_features(model_name, style_image, image_size, style_layers, naming, pretrained_model_file, checkpoint_exclude_scopes)
     97                 break
     98         if not excluded:
---> 99             variables_to_restore.append(var)
    100
    101     return assign_from_checkpoint_fn(

/usr/local/lib/python3.6/dist-packages/tensorflow/contrib/framework/python/ops/variables.py in callback(session)
    688     saver = tf_saver.Saver(var_list, reshape=reshape_variables)
    689     def callback(session):
--> 690       saver.restore(session, model_path)
    691     return callback
    692   else:

/usr/local/lib/python3.6/dist-packages/tensorflow/python/training/saver.py in restore(self, sess, save_path)
   1754       raise ValueError("The specified path: %s is a file."
   1755                        " Please specify only the path prefix"
-> 1756                        " to the checkpoint files." % save_path)
   1757     logging.info("Restoring parameters from %s", save_path)
   1758     if context.in_graph_mode():

ValueError: The specified path: /content/vgg_19.ckpt is a file. Please specify only the path prefix to the checkpoint files.

If I change pretained_model_file to the folder contains checkpoint file, it raise Exception: No checkpoint found....
If I force to change tensorflow from 1.6 to 1.4, and  pretrained_model_file = "vgg_19.ckpt", this code can work!

Thank you for your post. We noticed you have not filled out the following field in the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Thanks.
Bazel version
CUDA/cuDNN version
GPU model and memory
Exact command to reproduce

I am having the same problem.

now I'm updated to v1.6.0 and I get the same error at a different spot
/usr/local/lib/python3.6/dist-packages/tensorflow/contrib/framework/python/ops/variables.py in callback(session)
    688     saver = tf_saver.Saver(var_list, reshape=reshape_variables)
    689     def callback(session):
--> 690       saver.restore(session, model_path)
    691     return callback
    692   else:

/usr/local/lib/python3.6/dist-packages/tensorflow/python/training/saver.py in restore(self, sess, save_path)
   1754       sess.run(self.saver_def.restore_op_name,
   1755                {self.saver_def.filename_tensor_name: save_path})
-> 1756     else:
   1757       self._build_eager(save_path, build_save=False, build_restore=True)
   1758

ValueError: The specified path: /content/nima/ckpt/inception_resnet_v2_2016_08_30.ckpt is a file. Please specify only the path prefix to the checkpoint files.

then I downgraded to v1.4.1 and everything is fine.

Bug was fixed now!
Note:

this is a bug from tensorflow, coder add bug to resp #14341
bug was fixed by coder, but colab not update their tensorflow
I fixed bug in colab by this method.


Solutions reacting violates my ears upon starting devmap

Not sure when it started but it's 100% of the time I hear bubbling at full blast.

ok so i poked and it turns out a bunch of grindable/juiceable solutions lost the no reaction flag and now instantly react upon loading in.

ok so i poked and it turns out a bunch of grindable/juiceable solutions lost the no reaction flag and now instantly react upon loading in.


i18n(de): update guides/deploy/google-firebase.mdx

Description (required)

update guides/deploy/google-firebase.mdx

Related issues & labels (optional)

#9240
Suggested label: i18n

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File
Note

de/guides/deploy/google-firebase.mdx
Localization changed, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


[FEAT] Partial command line redirection from a file with comments

Is your feature request related to a problem?
I need to support “@filename” parameters (documentation section 3.1.5) with a more flexible content. Example:
## this is a comment
-I
 dvb
  --frequency
    12,169,000,000
  --symbol-rate
    27,500,000
  --fec-inner
    3/4
  --polarity
    horizontal
  --delivery-system
  --modulation
    8-PSK
## another comment

What I need is that lines starting with # are omitted. And initial spaces are omitted too.
I don't need anything more. With this it's sufficient to write these files as a simple sources that a human can read and edit.
Proposed solution:

After a short review of the code, it could be implemented without effort editing the function ts::UString::LoadAppend() that is called from UString::Load() that is used inside ts::Args::processArgsRedirection().
However, I don't want to do a dirty change in the code. So I request if you @lelegard want to enhance this. Or if not, then let me to know you preference about the change:

You accept to add to ts::UString::LoadAppend() a third boolean parameter to indicate if you want to omit "#" and spaces?
Or you want to pass a list of characters to control the filtering?
Or you have another idea?

Alternatives:

The only alternative is continue using the current file format that is quite difficult to edit for humans.
Additional information:

I hope you want/accept to improve this.

I must admit I do not like the idea very much. The principle of those files is to avoid all escaping issues, special characters, spaces, and all command interpreter syntax issues. Everything on each line literally belong to the parameter, including leading spaces if I remember correctly. One parameter = one line. No syntax, nothing.
By adding comments, you introduce syntactic concepts again. Leading to questions such as: how do you specify a parameter, a service name for instance, such as "#mychannel"? Do not tell me to add quotes because that would be yet another level of syntax. Double it? Yet another syntax?
Comments are nice in general and I do insist to have meaningful comments in source code. But, here, I would rather not.

Hi @lelegard ,
The idea is VERY SIMPLE. Only two enhancements:

Don't consider any line that starts with # (that's a comment)
If the line starts with one space, then remove all spaces until the first non-space character. After continue reading as normal.

So this enables "comments" and "tabulation" in such files. Nothing more.
And to implementing it, the question is this: you prefer to add a simple (optional) bool parameter to enable it (default false); or you want something else?

This is not a complex vs. easy code modification. As I explained, that would break existing command files. The net result is potential annoyance for some users vs. a small benefit for one user. So, the answer is no. Sorry.

Hi @lelegard ,
Perhaps I'm not expresed very well. Sorry, but my suggestion CAN'T generate any side effect. I'll try to explain more clearly:

I want to modify the function ts::UString::LoadAppend() with a third optional parameter called enhanced_mode. It's a bool with a default value of "false".
Only when enhanced_mode is "true" the code doens't consider lines starting with "#" and initial spaces.
Then all the current code continues compiling and working as now.
After I want to modify the chain that process the command line parameters using "@" inside ts::Args::processArgsRedirection() to only trigger the parsing with enhanced_mode as "true" when importing external files. In any other case the parsing will be done using enhanced_mode as "false" following the current behaviour.
To support the previous point I need to enhance some related functions in the chain between the previous function calls. This could be done adding the parameter as optional or adding new function names with this support. Here I need to know your preferance.

So, after these changes... could you please explain which side effect could be created?
Let me to explain my use case, that perhaps could be useful to understanding the advantage of this minimal change:

Using scripts for TSDuck is a must. Every experienced users needs to use them. However, scripts are not portable. Them could be if you use the same interpreter (for example, Bash in Windows or WSL; or PowerShell in Linux). However, it could be more easy to "encapsulate" your scripts inside "include files" (the file with parameters called with "@" in the command line). However, the current strict syntax is quite difficult to read and maintain for the user. Only adding the option to comment lines and use tabs is sufficient to improve the speed as you can do tests and research. For example, compare the sharing of a list of different command lines using "tsp" with the  ending  \ char compatible only with Bash-like shells and not Windows, with sharing a text file that you can call with a simple tsp.exe @test-1.txt or tsp -v --debug @test-1.txt.

So, are you sure that this is only a benefit for one user, when it does not disturb any other user and cannot generate unknown side effects? Also, my idea is to implement it by myself and provide a PR for the merge. So my request is just to do the coding using your recommendations to follow your coding style and not break anything.
Therefore, with all due respect, could you please reconsider your position?

could you please explain which side effect could be created?

Consider a service named "#mychannel" (in the Twitter era, many marketing guys consider that renaming something as "#something" is clever). A production script contains this:
-P
zap
#mychannel

The production is now broken...

Hi @lelegard ,
You're right (another time). And for this reason I prefer to discuss any question before implementing anything. So, I'll try to think on alternatives. I hope you agree to almost continue the discussion.
Thank you.

What you think?

Too awkward, error-prone, creating two types of parameter files. Users already have problems with the double @@ (and there is no other obvious solution), see some issues here. No need to create additional confusion.  You are, by far, the most demanding user in terms of new features. Most of the time, your demands have been implemented, sometimes exceeding the request in terms of features. In return, you have to accept that, sometimes, after debate and explanations, the answer can be no. And, here, this is a final "no".

Hi @lelegard ,

And, here, this is a final "no".

OK. Don't worry. I feel that a constructive discussion is not useless. So I can accept your opinion. In fact it's really true that my last proposal is error-prone. So perhaps I need to use a completly different approach. I'm think on do this externally: that's creating my personal files, and then applying a pre-processing to convert to the TSDuck format, for finally calling to tsp. In fact, is not very complex: with simple shell commands I can do the work (awk?). So finally the KISS model is the winner.
Thank you and regards. 😉


Support for Piczel.tv

I'm trying to record livestreams from Piczel.tv, but this program doesn't seem to support it
Any plans to add support for it?
On the mean time, is there any manual way of grabbing the livestreams from Piczel?

It seems like this project has been abandoned by the original developer.
streamlink is a fork of this project with multiple active developers. You should ask about the plugin over there.


Update helm chart and operator bundle for 2.0.0 3par release

Signed-off-by: Shiva Krishna, Merla<EMAIL_ADDRESS>

Operator scorecard tests:
emltcso300:hpe-csi-operator skrishna$ operator-sdk scorecard
{
  "kind": "ScorecardOutput",
  "apiVersion": "osdk.openshift.io/v1alpha2",
  "metadata": {
    "creationTimestamp": null
  },
  "log": "time=\"2020-04-07T19:47:31-07:00\" level=info msg=\"Using config file: /Users/skrishna/git/src/github.com/hpe-storage/co-deployments/operators/hpe-csi-operator/.osdk-scorecard.yaml\"\n",
  "results": [
    {
      "name": "Spec Block Exists",
      "description": "Custom Resource has a Spec Block",
      "labels": {
        "necessity": "required",
        "suite": "basic",
        "test": "checkspectest"
      },
      "state": "pass"
    },
    {
      "name": "Status Block Exists",
      "description": "Custom Resource has a Status Block",
      "labels": {
        "necessity": "required",
        "suite": "basic",
        "test": "checkstatustest"
      },
      "state": "pass"
    },
    {
      "name": "Writing into CRs has an effect",
      "description": "A CR sends PUT/POST requests to the API server to modify resources in response to spec block changes",
      "labels": {
        "necessity": "required",
        "suite": "basic",
        "test": "writingintocrshaseffecttest"
      },
      "state": "pass"
    },
    {
      "name": "Bundle Validation Test",
      "description": "Validates bundle contents",
      "labels": {
        "necessity": "required",
        "suite": "olm",
        "test": "bundlevalidationtest"
      },
      "state": "pass",
      "log": "time=\"2020-04-07T19:48:11-07:00\" level=info msg=\"loading Bundles\" dir=/Users/skrishna/test-operator/hpe-csi-driver-operator.v2.0.0\ntime=\"2020-04-07T19:48:11-07:00\" level=info msg=directory dir=/Users/skrishna/test-operator/hpe-csi-driver-operator.v2.0.0 file=hpe-csi-driver-operator.v2.0.0 load=bundles\ntime=\"2020-04-07T19:48:11-07:00\" level=info msg=\"found csv, loading bundle\" dir=/Users/skrishna/test-operator/hpe-csi-driver-operator.v2.0.0 file=hpe-csi-driver-operator.v2.0.0.clusterserviceversion.yaml load=bundles\ntime=\"2020-04-07T19:48:11-07:00\" level=info msg=\"loading bundle file\" dir=/Users/skrishna/test-operator/hpe-csi-driver-operator.v2.0.0 file=hpe-csi-driver-operator.package.yaml load=bundle\ntime=\"2020-04-07T19:48:11-07:00\" level=info msg=\"loading bundle file\" dir=/Users/skrishna/test-operator/hpe-csi-driver-operator.v2.0.0 file=hpe-csi-driver-operator.v2.0.0.clusterserviceversion.yaml load=bundle\ntime=\"2020-04-07T19:48:11-07:00\" level=info msg=\"loading bundle file\" dir=/Users/skrishna/test-operator/hpe-csi-driver-operator.v2.0.0 file=hpecsidrivers.storage.hpe.com.crd.yaml load=bundle\ntime=\"2020-04-07T19:48:11-07:00\" level=info msg=\"loading Packages and Entries\" dir=/Users/skrishna/test-operator/hpe-csi-driver-operator.v2.0.0\ntime=\"2020-04-07T19:48:11-07:00\" level=info msg=directory dir=/Users/skrishna/test-operator/hpe-csi-driver-operator.v2.0.0 file=hpe-csi-driver-operator.v2.0.0 load=package\n"
    },
    {
      "name": "Provided APIs have validation",
      "description": "All CRDs have an OpenAPI validation subsection",
      "labels": {
        "necessity": "required",
        "suite": "olm",
        "test": "crdshavevalidationtest"
      },
      "state": "pass"
    },
    {
      "name": "Owned CRDs have resources listed",
      "description": "All Owned CRDs contain a resources subsection",
      "labels": {
        "necessity": "required",
        "suite": "olm",
        "test": "crdshaveresourcestest"
      },
      "state": "pass",
      "suggestions": [
        "If it would be helpful to an end-user to understand or troubleshoot your CR, consider adding resources [customresourcedefinitions/v1beta1 storageclasses/v1 clusterroles/v1 clusterrolebindings/v1 hpecsidrivers/v1 serviceaccounts/v1 roles/v1 rolebindings/v1 daemonsets/v1 csidrivers/v1beta1] to the resources section for owned CRD HPECSIDriver"
      ]
    },
    {
      "name": "Spec fields with descriptors",
      "description": "All spec fields have matching descriptors in the CSV",
      "labels": {
        "necessity": "required",
        "suite": "olm",
        "test": "specdescriptorstest"
      },
      "state": "pass"
    },
    {
      "name": "Status fields with descriptors",
      "description": "All status fields have matching descriptors in the CSV",
      "labels": {
        "necessity": "required",
        "suite": "olm",
        "test": "statusdescriptorstest"
      },
      "state": "pass"
    }
  ]
}

Deployment of helm chart for 3PAR CSP:
helm install csi-driver ./helm/charts/hpe-csi-driver/ --namespace hpe-csi --set backendType=hpe3parprimera

root@skrishna-u16k8s-1:~/shivamerla/co-deployments# kubectl get all -n hpe-csi
NAME                                      READY   STATUS    RESTARTS   AGE
pod/hpe-csi-controller-7d9cd6b855-k9fjz   5/5     Running   0          14s
pod/hpe-csi-node-cgj96                    2/2     Running   0          14s
pod/hpe-csi-node-kc2zv                    2/2     Running   0          14s
pod/hpe3parprimera-csp-778cf87c8b-27bf5   1/1     Running   0          14s

NAME                             TYPE        CLUSTER-IP   EXTERNAL-IP   PORT(S)    AGE
service/hpe3parprimera-csp-svc   ClusterIP   <IP_ADDRESS>   <none>        8080/TCP   14s

NAME                          DESIRED   CURRENT   READY   UP-TO-DATE   AVAILABLE   NODE SELECTOR   AGE
daemonset.apps/hpe-csi-node   2         2         2       2            2           <none>          14s

NAME                                 READY   UP-TO-DATE   AVAILABLE   AGE
deployment.apps/hpe-csi-controller   1/1     1            1           14s
deployment.apps/hpe3parprimera-csp   1/1     1            1           14s

NAME                                            DESIRED   CURRENT   READY   AGE
replicaset.apps/hpe-csi-controller-7d9cd6b855   1         1         1       14s
replicaset.apps/hpe3parprimera-csp-778cf87c8b   1         1         1       14s

For Nimble:
helm install csi-driver ./helm/charts/hpe-csi-driver/ --namespace hpe-csi
NAME: csi-driver
root@skrishna-u16k8s-1:~/shivamerla/co-deployments# kubectl get all -n hpe-csi
NAME                                      READY   STATUS    RESTARTS   AGE
pod/hpe-csi-controller-7d9cd6b855-grlmb   5/5     Running   0          26s
pod/hpe-csi-node-2dgt4                    2/2     Running   0          26s
pod/hpe-csi-node-gjzcc                    2/2     Running   0          26s
pod/nimble-csp-546c9c4dd4-t872r           1/1     Running   0          26s

NAME                     TYPE        CLUSTER-IP      EXTERNAL-IP   PORT(S)    AGE
service/nimble-csp-svc   ClusterIP   <IP_ADDRESS>   <none>        8080/TCP   26s

NAME                          DESIRED   CURRENT   READY   UP-TO-DATE   AVAILABLE   NODE SELECTOR   AGE
daemonset.apps/hpe-csi-node   2         2         2       2            2           <none>          26s

NAME                                 READY   UP-TO-DATE   AVAILABLE   AGE
deployment.apps/hpe-csi-controller   1/1     1            1           26s
deployment.apps/nimble-csp           1/1     1            1           26s

NAME                                            DESIRED   CURRENT   READY   AGE
replicaset.apps/hpe-csi-controller-7d9cd6b855   1         1         1       26s
replicaset.apps/nimble-csp-546c9c4dd4           1         1         1       26s


Use the "C-unwind" abi for functions we cannot guarantee won't panic

a note: const extern "C-unwind" is currently unstable https://github.com/rust-lang/rust/issues/64926, but our const functions should not panic anyway so having them be extern "C" should be fine


Test links

It would be nice to check the validity of the URLs in the documentation.
There is a tool called liche that can do that for HTML and MD files. (Sadly, I am not aware of anything for Python.)
We can use that in pre-commit or as a GitHub action like you can see e.g. here (the action will create an issue with the report like here)

grep | curl ? :)

Does anyone want to take a look? I would close it next time stale-bot brings it to us.

Using the action config you linked should be quite effortless, I'll give it a try.


Unnecessary call to bytesRuff(UP018) fixing false positive

when hovering over the code the LSP warns:
Unnecessary call to `bytes` Ruff(UP018)

and auto fixing changes
foo = str(b'{"foo":"bar"}')

to:
foo = b'{"foo":"bar"}'

which has a different type

Thanks.


Added popcorntime missing desktop file

Description of changes
The official popcorntime git repository mentions that the desktop file should be created by the user when it's installing the package: https://github.com/popcorn-official/popcorn-desktop

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

This pull request is a duplicate for #201657.


Feat: update nacos version to 2.2.3

Describe what this PR does / why we need it

For: #3502

I have run all the examples locally and it has passed successfully and achieved the expected results.


pre-trained  model weights

Hello,
May I ask if you are considering publicizing the pre-training weights?
thanks

We are still preparing, they will be available soon.

We have now released our models and raw results. Thanks for your interest in our work.

Thanks for your help


cherry-pick(#369) and fix conflict

cherry pick: https://github.com/opendatahub-io/kserve/pull/369

Do not merge this PR until other PRs are ready.

/hold

If this is just a cherry-pick, we should be able to merge this. Right?
IMO, it shouldn't have any unwanted effect regardless the other PRs aren't ready yet.

/lgtm

/unhold


Patch openssh to fix CVE-2023-28531

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[x] The toolchain has been rebuilt successfully (or no changes were made to it)
[x] The toolchain/worker package manifests are up-to-date
[x] Any updated packages successfully build (or no packages were changed)
[x] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[x] All package sources are available
[x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[x] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
[x] All source files have up-to-date hashes in the *.signatures.json files
[x] sudo make go-tidy-all and sudo make go-test-coverage pass
[x] Documentation has been updated to match any changes to the build system
[x] If you are adding/removing a .spec file that has multiple-versions supported, please add @microsoft/cbl-mariner-multi-package-reviewers team as reviewer (Eg. golang has 2 versions 1.18, 1.21+)
[x] Ready to merge

Summary

What does the PR accomplish, why was it needed?
Add a patch for CVE-2023-28531 for openssh package
Change Log

Add patch for CVE-2023-28531

Does this affect the toolchain?

NO
Links to CVEs

https://nvd.nist.gov/vuln/detail/CVE-2023-28531

Test Methodology

Buddy Build: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=593315&view=results

Overriding PR check and merging. The only failure is a known libguestfs ptest failure - no regressions.

Auto cherry-pick results:

main :white_check_mark: -> https://github.com/microsoft/azurelinux/pull/9519

Auto cherry-pick pipeline run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=594238&view=results


ShareView remake

Feature or Bugfix

Feature

Detail

Share View page is reorganised. Now all important info is on one screen.
Red reminder to submit the draft
Upon submission, the modal window is shown, where user can revisit the share

Relates

#1009

Security
Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

Does this PR introduce or modify any input fields or queries - this includes
fetching data from storage outside the application (e.g. a database, an S3 bucket)?

Is the input sanitized?
What precautions are you taking before deserializing the data you consume?
Is injection prevented by parametrizing queries?
Have you ensured no eval or similar functions are used?

Does this PR introduce any functionality or component that requires authorization?

How have you ensured it respects the existing AuthN/AuthZ mechanisms?
Are you logging failed auth attempts?

Are you using or adding any cryptographic features?

Do you use a standard proven implementations?
Are the used keys controlled by the customer? Where are they stored?

Are you introducing any new policies/roles/users?

Have you used the least-privilege principle? How?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dlpzx @zsaltys have a look

@SofiaSazonova @dlpzx @noah-paige I think perhaps this is an improvement but I think we could do better...
I think draft shares should not exist at all. A share either exists as submitted or doesn't exist at all. I don't see any value in draft shares and I think they they just serve to add confusion. I think we should rework the graphql endpoints to allow to submit a share together with all the items selected. This would be more work and you couldn't reuse likely the existing UI components but it solves a lot of problems we're trying to work around: putting reminders in red text, adding more modals and buttons to click. I see this modal + red text as bandaging over symptoms vs solving the core problem.
if you really insist to keep drafts:

Please make role name LONG so you can see how it affects the UI.

Revoke/Verify/Re-Apply should not show on draft shares.

It would be nice to remap Your Role to Approver and Requester and not ApproverAndRequester

Put on the title Draft share object... as one more cue visual reminder this is a draft.

Rename the Submit Share in the modal to Review Share...  It's not a nice experience.

Showing status the submit modal only makes sense for drafts.. but it makes no sense to show status on the modal because the status can only be PENDINGAPPROVAL... we can show it but there's little value for it.

Change the button on the Request Access modal to "Create Draft Share"

Remove the request purpose on the request access modal and then it makes more sense to set it on the submit modal and it will be a bit more clear why the submit modal exists..

When creating a share from a TABLE item in the catalog do not automatically preselect the table but leave no items selected to force users to think through what they need to select on the share items..

I agree with Zi. It would be preferable not to encounter an additional page after navigating through the request access modal. I suggest that upon clicking the lock button on a dataset, the user should be directed either to a request access modal or a share page. Here, they should be prompted to fill out all the details from the original request access modal along with the current share page options, such as selecting share items. Having two pages solely for submitting a share request seems unnecessary.
Additionally, if we opt to retain the draft stage page, we should implement the steps outlined by Zi. I particularly emphasize step 7, where instead of a submit button, we should display a "Create Draft Share" button. Subsequently, upon someone clicking on this button, a red pop-up notification should appear at the top right, indicating that the draft request has been submitted and prompting the user to complete the rest of the form to finalize their share request."

Hi @SofiaSazonova , the sleek UI looks nicer than the earlier one.
Adding to the comments from @anushka-singh and @zsaltys ,

I would suggest having the submit button at the end of the UI ( like how it is when we create an IAM role, etc in AWS) . This way the user goes from top to bottom and also ( hopefully 😄 ) sees the share items section.
Just above the submit button, there can be a small banner which provides a note about how the user should proceed with with this share. Maybe here we can mention that the user needs to select atleast one share item and then submit the share request.
If possible ( as a stretch ) if the user is a requestor , we can show another banner telling the user about how the share request will be approved by someone from the approvers team. If the user is an approver, then we can display something like , Next Steps : by clicking on approve, you would create a share for items {} , if you do not wish to share then you can reject the share request
I really liked the way which Anushka described of how after clicking the Catalog's lock icon , the user is taken to the shares page. Additionally , I would suggest that we should replace the lock icon with some text maybe or a  better way to let the user know about how the share request should be created.
During the share creation process, as the consumption role is an optional field, it creates confusion amongst first time users. Maybe we could design that modal such that after selecting the environment, they could take action as to if they want to create a share on the team role or want to select a consumption role ( if its available in that environment )

@zsaltys @anushka-singh @TejasRGitHub Thanks for the feedback!
I will review the workflow once again and will try to fulfil you requirements without dramatic changes to the current procedures.

In addition to the above comments:

The main downside to keep an eye on when simplifying the workflow and avoiding the draft state is the triggering of the shares tasks. Requester submits item1, then item2, then item3. Approver approves the share request right after item2 --> we need to ensure that item3 is not shared. I have not looked at the code but we do queries based on the item status so I guess we could run into that situation
Small thing: when submitting a share already SHARE_SUCCEEDED items do not matter. In the case of having many many tables showing already shared items can be confusing

Share View page is reorganised. Now all important info is on one screen.
Red reminder to submit the draft
Edit and Submission buttons call the Modal window for share editing. User can save share as a draft or submit it.
When request is created from Catalog, the modal window give user the form for share editing and submission (or draft).

@zsaltys

Please make role name LONG so you can see how it affects the UI.
Long role names will be croped by the width of the line and "..." will be added. Full name will be available in the tooltip.

Revoke/Verify/Re-Apply should not show on draft shares.
"Revoke" is now shown only in Edit window. Verify and Reapply are still useful in drafts: share could be previously approved and processed. Then, it was drafted again, but previously shared items still can be diagnosed and reapplied if needed.

It would be nice to remap Your Role to Approver and Requester and not ApproverAndRequester
There are some 'backend strings' that I would love to rename as well, but I will keep for separate PR

Put on the title Draft share object... as one more cue visual reminder this is a draft.
Good Idea

Rename the Submit Share in the modal to Review Share...  It's not a nice experience.
Now the share can be submitted as soon as it's edited, so usually the user won't have to use this modal. I keep it as it is for now.

Showing status the submit modal only makes sense for drafts.. but it makes no sense to show status on the modal because the status can only be PENDINGAPPROVAL... we can show it but there's little value for it.
Now the status is shown, because we have one editing table for all items

Change the button on the Request Access modal to "Create Draft Share"
Good Idea

Remove the request purpose on the request access modal and then it makes more sense to set it on the submit modal and it will be a bit more clear why the submit modal exists..
I keep it now in both places, for i don't want to break the already established ways users can be accustomed to.

When creating a share from a TABLE item in the catalog do not automatically preselect the table but leave no items selected to force users to think through what they need to select on the share items..
In current workflow, user will see right away, what is selected.

@TejasRGitHub

I would suggest having the submit button at the end of the UI ( like how it is when we create an IAM role, etc in AWS) . This way the user goes from top to bottom and also ( hopefully 😄 ) sees the share items section.

Now, it's there

If possible ( as a stretch ) if the user is a requestor , we can show another banner telling the user about how the share request will be approved by someone from the approvers team. If the user is an approver, then we can display something like , Next Steps : by clicking on approve, you would create a share for items {} , if you do not wish to share then you can reject the share request

It's not really a UI change, but more the workflow change as well. We can discuss it separately and create a separate issue

I really liked the way which Anushka described of how after clicking the Catalog's lock icon , the user is taken to the shares page. Additionally , I would suggest that we should replace the lock icon with some text maybe or a better way to let
the user know about how the share request should be created.

Now we can do the whole share submission from catalog page in modal window.

During the share creation process, as the consumption role is an optional field, it creates confusion amongst first time users. Maybe we could design that modal such that after selecting the environment, they could take action as to if they want to create a share on the team role or want to select a consumption role ( if its available in that environment )

Good suggestion. I don't want to overcomplicate this PR, but this option definitely needs some clarification in UI

Hi @SofiaSazonova - think we are getting there but found a couple issues when playing around with the UI and testing locally:
[1] Does this work for Dashboard Shares via requestAccessModal?
[2] If already have a share and open a share request from catalog for another item via RequestAccessModal

Issues

Updating request purpose of first step (i.e. step 0) does nothing (maybe remove?)
If Share Status is Submitted and then I “Include” a new Item

The Share status remains “Submitted” after I add the item
But when I click “View Share” it is actually of state “Draft” (a similar finding is below with editing directly via ShareView)

[3] When I have a share in submitted state with 1+ items

I then click on edit from ShareView and add another item
Issues

When I add a new item my options are then only to “Cancel” (no functional issue but a bit confusing that no other button)
When I click out via “Cancel” - ShareView is not updated with latest status (would be changed from Submitted to Draft because I added a new item)

Additionally should we have a way to add items and immediately re-submit (i.e. no draft) from the ShareView Edit Modal?

I can not edit purpose because the only button shown for this share edit view is “Cancel”

[4] From ShareEditForm opened via ShareView

If status Share_Rejected - it says “Wait until this item is processed”
But I can delete from Shared Items table in Share View which I believe is correct since this is separate from a revoke of an existing share

[5] From ShareEditForm opened via ShareView

When Revoke there is no loading view from UI after first click of Revoke

I can keep spamming Revoke button and likely break something (no way to know something is happening)

[6] From ShareEditForm opened via ShareView

Pagination does not work if over 10 items

@noah-paige

About Dashboard Shares. It should be the same as it was before. Isn't it?
2, 3. I must have missed something and share is not reloaded.

About this

But when I click “View Share” it is actually of state “Draft” (a similar finding is below with editing directly via ShareView)

It actually the way it was before. If share is already exist, we don't change the request, just load the old one. I'll think. how to let user know, why is that so.
Also, I will rename  “Cancel” -> "Close"

Hm, I was overwhelmed with the state machine))) I'll fix it.
Acknowledged. I'll fix
Hm...Does it work in Share View? I'll  create so many items to test it's better.

I fixed the problems @noah-paige mentioned.
The only thing left is to notify user, that the share is already exist before redirecting them to share page. I'm on it)

I added message for user that share already exists. So, they won't be surprised

Thank you @SofiaSazonova for the quick changes on the above - just a few more issues I am finding.
Pending General Issues I still am facing:
[1] Still request purpose does nothing on first view in RequestAccessModal with existing share object

I guess it is fine because notification saying redirecting to existing share

But for a user if they write a lengthy description they then lose it all (annoying UX)

Additionally no way to edit request purpose from Edit button on ShareView because the only button shown for this share edit view is “Close”

[2] From ShareEditForm opened via ShareView

If I delete an item that is in PendingApproval the ShareEditModal updates but when I click “Close” the ShareView is not updated until I “Refresh” on ShareView Page

Maybe Close should just be a Refresh always?

[3] MINOR - Submit with no included share item throws error and keeps share Draft state (may be confusing for user from RequestAccessModal at least)

Disable Submit button if none included?

Additional Considerations (Looking further?):
Maybe as a future issue for 2.7 or later given the amount of work @SofiaSazonova  has already invested here to make these views far better…

But now that we have separate modal views to add/remove items - should we have only dataset objects in catalog

Opening shares for child Tables and Folders already redirect to dataset related shares
As we expand cataloged items (i.e. redshift datasets, s3 datasets, dashboards, etc etc) things may begin to get cluttered in catalog

As long as the user can fully submit a share from the Catalog page I think it is a much cleaner experience but open to thoughts!

Purpose texfield moved to second step of edit form
Request purpose can't be edited, when request is already processed or approved. This button also disabled in ShareView
Reject Purpose can be edited only in statuses Submitted or Draft
Share_Failed added to possible statuses for deletion of item
Submit button is disabled if there is no items
Button to Save&Close  when it's not draft. When the request is saved, the share is reloaded, edits are saved

Thank you @SofiaSazonova for all of your work iterating on this PR

Overall - the process of opening up a new share request is much approved with these changes and will become a more streamlined process.
An Important Remark(!):
With this PR it will not be possible to revoke a list of items in a share object but rather revokes will happen one at a time per share item

Enhancements we can look into for future releases include - (1) adding search / filters to make finding objects to add or to revoke simpler, (2) enabling revoke on a list of items, or other ideas as well

Please take a look at the latest and if no additional concerns I will work with Sofia to get this PR approved and merged in the next day or two
cc: @dlpzx @petrkalos @zsaltys @TejasRGitHub @anushka-singh

Thanks @SofiaSazonova for all the work on this PR!
The changes already look much more user friendly. I found no issues in the code, but I was just wondering if it would be possible to get newer screenshots after the final changes have been made so we can review it easily?

@anushka-singh here you go!

Originally, the Request Purpose box used to be on the "Request Access" page. I see now it has moved to Share status page. Is there a reason for that? I think it made sense to have it on the "Request Access" Page along with the other fields that needed to be filled out.

Thank you @SofiaSazonova for all of your work iterating on this PR
Overall - the process of opening up a new share request is much approved with these changes and will become a more streamlined process.
An Important Remark(!): With this PR it will not be possible to revoke a list of items in a share object but rather revokes will happen one at a time per share item
* Enhancements we can look into for future releases include - (1) adding search / filters to make finding objects to add or to revoke simpler, (2) enabling revoke on a list of items, or other ideas as well

Please take a look at the latest and if no additional concerns I will work with Sofia to get this PR approved and merged in the next day or two cc: @dlpzx @petrkalos @zsaltys @TejasRGitHub @anushka-singh

@SofiaSazonova - can you just pull the latest from main to fix the issue with npm-audit GH workflow check
Afterwards I think we are good on this PR and I will approve

Originally, the Request Purpose box used to be on the "Request Access" page. I see now it has moved to Share status page. Is there a reason for that? I think it made sense to have it on the "Request Access" Page along with the other fields that needed to be filled out.

Before we had the Request Purpose box on both the Request Access initial page (opened from Catalog) and the Share Edit page (opened as second page from Catalog or from Edit button on ShareView)
IMO - It felt less intuitive to have the edit on both pages and I thought it would be best to keep the text box in on ShareEditForm because that UI view is used in both places making it far more accessible for a user to edit this field
Also the Share Object gets created on the first "Request Access" page (opened from Catalog) but if the share object already exists it just gets redirected to re-use the existing share object. Currently the logic we have in backend would just return the existing share object as is and not update the request purpose if one provided as well. Instead of adding more one-off logic to backend and additional conditions,  it seemed best to clean up frontend views in this case
Let me know if I missed anything in the above rationale @SofiaSazonova

@noah-paige done)

@noah-paige
Thanks for addressing this. I like that we modified the frontend instead of adding more clunky code in the backend.
IMO I would still like having request purpose on Request Access page.
As a user, when I create a share request, I can put in my reasoning for requesting resources and the approver will be able to see my reason. However, with the latest change it sounds like the user will have to first create a share request and then go to edit the share request and only then put a reason for requesting the resources. IMO, it should be in request access page. But its not a blocker, we can discuss it further or slate the change for later if we decide to go ahead with it. But otherwise you have my approval to merge.

@anushka-singh

user will have to first create a share request and then go to edit the share request and only then put a reason for requesting the resources.

It's not quite right. The edit page (screenshot 3) appears immediately after the share created. So, just consider Request Access as step 1 and then Share fill in/edit form as step 2. No additional actions needed

Okay! That makes sense.
Thanks for clarifying that for me @SofiaSazonova.
Let's merge it in!

Hi @SofiaSazonova , The changes look really good. I was able to pull in your changes and checked the UI. The UI experience is really nice and I like that the user can create a share request on the same request modal itself.


Don't persist failure to the database

Currently I store failures in the database by marking them explicitly as missing. I see no reason for storing failures since it defeats previous value equality and this can cause huge rebuilds even if nothing changes.

Note that you have to conservatively assume that failures aren't in the DB since the "failure" might be kill -9 while rebuilding. That's another point in favour of not recording failures explicitly.
This issue is also discussed at https://github.com/haskell/cabal/issues/3179.

Let's say the failure is due to a syntax error. In this case, rebuilding is futile until the input files change. Persisting failures (in a structure similar to Result) would stop further builds until the offending syntax is fixed, which would be useful for continuous recompilation (#371).
ShakeException would need to be serializable; would anything be lost with shakeExceptionInner :: String?

Often the failures are due to untracked assumptions, e.g. ghc version, and rebuilding without changing the input files is desirable. I imagine for continuous recompilation you'd want to wait until something relevant changed, so there you have no need to serialise something like ShakeException - you only care if something relevant changed, not what the last result was.

Now implemented, note that this changes the invariants. Previously if you had a rule which claimed to produce foo, but also (secretly from Shake) produced bar, then you could write:
rm bar
need [my-dependency]
touch bar
touch foo

And this would work. There was an invariant that if you ever start running a rule then that rule is dirty until the rule has completed. Now, if the child ends up in an erroneous state, the parent might be started, cancelled, then skipped. Certainly a corner case, so hopefully nothing anyone ever wanders in to.


OSC HA Design Proposal Document

OSC HA Design Proposal with different approaches and future investigations.

@emanoelxavier,@arvindn05,@sudhirappaji ,
Please review the HA Design Proposal and let me know if any changes are required.

@sahasamiran,
Did the required changes as per your review comments.Please review and let me know if any changes needs to be done.

@sudhirappaji,@emanoelxavier,@arvindn05,
I updated the document by adding 3rd approach.Also,formatted the issues.Please review and let me know if any changes needs to be done.

@sudhirappaji,@emanoelxavier,@arvindn05,
As per Emanoel's review comment,renamed the file.Please let me know if any changes needs to be done.

@bmmukund , Please add point under further investigation that Option 3 needs further investigation to narrow down detailed implementation path, please add this and from my side i will approve.
@arvindn05 , Please check and feedback. I plan to merger this by tomorrow, 3/16 if no comments.

@sudhirappaji,
I added the further investigation items as suggested.Please review and let me know if any changes needs to be done.

@arvindn05 ,
I made the changes as per your review comments.Please let me know if anything needs to be changed.


LDAP issue for AD integration.

I am trying to use LDAP for AD integration for opendistro
I have modified the "plugins/opendistro_security/securityconfig/config.yml" and added ldap configs for authc and authz.
I am mentioning the same configs below.
authc:
      ldap:
        http_enabled: true
        transport_enabled: false
        order: 1
        http_authenticator:
          type: "basic"
          challenge: false
        authentication_backend:
          type: "ldap"
          config:
            enable_ssl: false
            enable_start_tls: false
            enable_ssl_client_auth: false
            verify_hostnames: true
            hosts:
                - "ad.example.com:686"
            bind_dn: "cn=esuser1,OU=Users,OU=AD,dc=ad,dc=example,dc=com"
            password: "<< password >>"
            userbase: "OU=Users,OU=AD,dc=ad,dc=example,dc=com"
            usersearch: "(sAMAccountName={0})"
            username_attribute: "cn"

authz:
      roles_from_myldap:
        http_enabled: true
        transport_enabled: false
        authorization_backend:
          type: "ldap"
          config:
            enable_ssl: false
            enable_start_tls: false
            enable_ssl_client_auth: false
            verify_hostnames: true
            hosts:
            - "ad.example.com:389"
            bind_dn: "cn=esuser1,OU=Users,OU=AD,dc=ad,dc=example,dc=com"
            password: "Test1234"
            userbase: "OU=Users,OU=AD,dc=ad,dc=example,dc=com"
            usersearch: "(uid={0})"
            rolebase: "OU=Groups,OU=AD,dc=ad,dc=example,dc=com"
            rolesearch: "(member={0})"
            userrolename: "memberOf"
            rolename: "cn"

After that I have modified the "roles.yml" and "roles_mapping.yml" files as well.  When I am trying to use one of the AD user to create or query index, its giving an Unauhtorized error.
Can someone please tell me which part I am doing wrong.

Enable debug level logging and post them here.

try ldapsearch make sure the ldap query is working

@sdwerwed One of the simplest ways to enable debugging is:
PUT /_cluster/settings {"transient":{"logger._root":"DEBUG"}}

We are doing some "spring cleaning in the fall", and to make sure we focus our energies on the right issues and we get a better picture of the state of the repo, we are closing all issues that we are carrying over from the ODFE era (ODFE is no longer supported/maintained, see post here).
If you believe this issue should still be considered for current versions of OpenSearch, apologies! Please let us know by re-opening it.
Thanks!


Add pre-commit to prevent someone committing directly to main

[x] This contribution adheres to CONTRIBUTING.md.

Prevent accidental commit to main

Pre-commit hooks should be installed in your local .git/hooks directory, not checked into source control.
See discussion on https://github.com/ni/measurementlink-python/pull/277 for more info.


Delete the append_* and from_slice_* as annoying bloat since it's easily implementble to a user already and is a pain to maintain

done


Update how-to-connect-pta-disable-do-not-configure.md

@MichelleSwafford : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


[SNAP-3111] honor spark.task.cpus as a local property

What changes were proposed in this pull request?

spark.task.cpus when set as local property then it override the global one if it is larger
only supported for CoarseGrainedSchedulerBackend (SD, standalone, yarn, mesos coarse)

How was this patch tested?
precheckin -Pspark

Closing this as per discussion

Reopening after some testing with improvements forthcoming.


VM: MegamorphicLookup #5: default visitor pattern

This issue is split out from https://github.com/dart-lang/sdk/issues/26017
In dart2js there are 11 subclasses of HInstruction visitor class, HBaseVisitor
The visitor has defaults visitXXX methods that call the visit method for the superclass of the argument.
class HBaseVisitor {
  visitReturn(HReturn node) => visitControlFlow(node);
  visitControlFlow(HControlFlow node) => visitInstruction(node);
  visitInstruction(HInstruction instruction) {}
}

class SsaInstructionSimplifier extends HBaseVisitor {
  visitGraph(HGraph graph) {
    ....  instruction.accept(this);
  }

  HInstruction visitInstruction(HInstruction node) {
    return node;
  }
  // Visitor is mostly concerned with constant-folding expressions.
  // Does not override visitReturn, visitControlFlow
}

class HReturn extends HControlFlow {
  accept(visitor) => visitor.visitReturn(this);
}

instruction.accept(this) and visitor.visitReturn(this) are megamorphic. This is expected.
The target for on HReturn is HBaseVisitor.visitReturn, which in turn has a megamorphic call up the chain. This is an additional two MegamorphicLookup calls.
I can improve this manually by copying the default behaviour into each visitor, but that defeats the point of having the default behaviour.
The compiler could do this for me by cloning the methods from the base class to the instantiated classes.
I think this can happen dynamically: At the time it is determined that HBaseVisitor.visitReturn is to be entered in the MegamorphicCache for receiver=SsaInstructionSimplifier, we can decide if a specialization should be generated to replace HBaseVisitor.visitReturn. A specialization should be generated if (1) the target is 'small' and (2) if the target has an ICData or MegamorphicCache that is used on the receiver.  If these conditions hold, HBaseVisitor.visitReturn would be compiled with this=SsaInstructionSimplifier, making inlining decisions based on dataflow of the receiver rather than ICData.

Duplicate of #26858


Prevent input focus loss validation

Hi, It possible to prevent validation after input focus loss? I want use validation only when submit clicked.

sure, just provide the events option when installing the plugin:
Vue.use(VeeValidate, {
  events: 'input|blur' // validate on input and on blur, this is the default.
});

// you can change it to:
Vue.use(VeeValidate, {
  events: 'input' // validate on input only
});


Fixed tailwind css in storybook

Description
This PR includes:

fix to include tailwind properly in storybook
added additional guidelines for frontend contributing

/deploy-staging

/deploy-staging

/deploy-staging

/deploy-staging

/deploy-staging

/merge


closes #7 try executing unit tests in gh actions

TODO:

split UnitTests and IntegrationTests
run UnitTests in GitHub-Actions Workflow


Processing images with any arbitrary size

@MTlab Hello, I found that the unet-like architecture is employed in your experiment. This structure adopts convolutions with the stride of 2 and pooling layer. If the input image with the size of the odd number, how does the output image remain the same size as the input?

We did not use operations like pixelshuffle when upsampling, we used deconvolution instead. So when the input image with the size of the odd number, We can still handle it.

@gamewang123 Maybe you misunderstand what I meant. But I have solved my doubts. Thanks for your replay.

@gamewang123 If the input image size is 221 × 221, how can I get the same size output by using this network?