improve debug output for API calls with query strings

I was trying to debug an issue earlier and spotted this issue - if we're making an API call with a query string, we don't display it properly in the logging output so we have to add debug statements to the code and assemble it by hand. I think I've actually hit this before, but today it annoyed me enough to actually fix it :)
Before:
...
 Request  🏹
 https://repo.magicmq.dev/service/rest/v1/search
 Response status code  🎯
 200
...

After:
...
 Request  🏹
 https://repo.magicmq.dev/service/rest/v1/search?group=dev.magicmq&name=itemapi&sort=version&prerelease=false
{
  "headers": {
    "Accept": "application/json"
  }
}
 Response status code  🎯
 200
...

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @chris48s!

  Generated by :no_entry_sign: dangerJS against 92cc458801497e3a424049ac07c883a6cb516aeb

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @chris48s!

  Generated by :no_entry_sign: dangerJS against 92cc458801497e3a424049ac07c883a6cb516aeb

I feel foolish :laughing: Not because of the code changes, but because I don't remember ever seeing this output anywhere, and think I am about to have a big "TIL" moment...
is the printed options in the updated output from the request or response headers?

I feel foolish :laughing: Not because of the code changes, but because I don't remember ever seeing this output anywhere, and think I am about to have a big "TIL" moment...
is the printed options in the updated output from the request or response headers?

Trying to think through whether this may have been intentional to avoid logging any sensitive info in either the query (tokens as query params for certain services) and/or in request headers. Think I vaguely remember something along these lines from a while back but unsure

Trying to think through whether this may have been intentional to avoid logging any sensitive info in either the query (tokens as query params for certain services) and/or in request headers. Think I vaguely remember something along these lines from a while back but unsure

I've run into the same issue a few times, including recently when doing a little paid support to troubleshoot self-hosted services.
It's possible security was a reason for leaving these out. I think it's fine to log the query string, which in most cases is already buried in the output anyway. As far as headers, since those are sometimes sensitive, I wonder if we should place them under a second flag, like TRACE_SERVICES_INSECURE.
Thanks so much for picking this up. It's a good improvement 🍻

I've run into the same issue a few times, including recently when doing a little paid support to troubleshoot self-hosted services.
It's possible security was a reason for leaving these out. I think it's fine to log the query string, which in most cases is already buried in the output anyway. As far as headers, since those are sometimes sensitive, I wonder if we should place them under a second flag, like TRACE_SERVICES_INSECURE.
Thanks so much for picking this up. It's a good improvement 🍻

I feel foolish :laughing: Not because of the code changes, but because I don't remember ever seeing this output anywhere, and think I am about to have a big "TIL" moment...

Run npm run badge https://img.shields.io/appveyor/build/gruntjs/grunt it will be a voyage of discovery :open_mouth:

is the printed options in the updated output from the request or response headers?

This is the request headers

Trying to think through whether this may have been intentional to avoid logging any sensitive info

It's possible security was a reason for leaving these out

Yeah reasonable question. If you look at the original line of code removed in this PR:
- logTrace(emojic.bowAndArrow, 'Request', url, '\n', options)

my reading of that is we always intended to present the entire options object in the log output but we either changed the signature of logTrace() at some point or maybe this used to just be a straight console.log(). We broke it accidentally. So I don't think we ever intended to not show options.
In terms of whether we need to: Where do we actually surface this info? Do we expose it in other places/situations than npm run badge? (that's the only place I ever use it). If that is the only place we show it, I think security is a non-issue there: If you can type npm run badge then you can type printenv or cat config/local.yml although we would need to review it if we were to re-purpose the trace outputs for something like https://github.com/badges/shields/issues/5940 - then we would definitely need to revisit that assumption. If we expose it in other contexts, let me know.
If we do decide we need to hide credentials, we could strip or obfuscate Authorization and basic auth user/pass headers but leave the rest instead of hiding all headers.

I feel foolish :laughing: Not because of the code changes, but because I don't remember ever seeing this output anywhere, and think I am about to have a big "TIL" moment...

Run npm run badge https://img.shields.io/appveyor/build/gruntjs/grunt it will be a voyage of discovery :open_mouth:

is the printed options in the updated output from the request or response headers?

This is the request headers

Trying to think through whether this may have been intentional to avoid logging any sensitive info

It's possible security was a reason for leaving these out

Yeah reasonable question. If you look at the original line of code removed in this PR:
- logTrace(emojic.bowAndArrow, 'Request', url, '\n', options)

my reading of that is we always intended to present the entire options object in the log output but we either changed the signature of logTrace() at some point or maybe this used to just be a straight console.log(). We broke it accidentally. So I don't think we ever intended to not show options.
In terms of whether we need to: Where do we actually surface this info? Do we expose it in other places/situations than npm run badge? (that's the only place I ever use it). If that is the only place we show it, I think security is a non-issue there: If you can type npm run badge then you can type printenv or cat config/local.yml although we would need to review it if we were to re-purpose the trace outputs for something like https://github.com/badges/shields/issues/5940 - then we would definitely need to revisit that assumption. If we expose it in other contexts, let me know.
If we do decide we need to hide credentials, we could strip or obfuscate Authorization and basic auth user/pass headers but leave the rest instead of hiding all headers.

In terms of whether we need to: Where do we actually surface this info? Do we expose it in other places/situations than npm run badge? (that's the only place I ever use it). If that is the only place we show it, I think security is a non-issue there: If you can type npm run badge then you can type printenv or cat config/local.yml although we would need to review it if we were to re-purpose the trace outputs for something like #5940 - then we would definitely need to revisit that assumption. If we expose it in other contexts, let me know.

This makes sense to me. I'm convinced it's fine to print the credentials.
The only other place I could see showing this is if we create a debug endpoint, however if we ever decided to do this we could revisit it at that time.

In terms of whether we need to: Where do we actually surface this info? Do we expose it in other places/situations than npm run badge? (that's the only place I ever use it). If that is the only place we show it, I think security is a non-issue there: If you can type npm run badge then you can type printenv or cat config/local.yml although we would need to review it if we were to re-purpose the trace outputs for something like #5940 - then we would definitely need to revisit that assumption. If we expose it in other contexts, let me know.

This makes sense to me. I'm convinced it's fine to print the credentials.
The only other place I could see showing this is if we create a debug endpoint, however if we ever decided to do this we could revisit it at that time.

I wasn't sure if any of this would make it's way into the Heroku logs, though after thinking some more even if it did, it's a pretty rare case where we accept a user's token as a query param and even then we only allow narrowly scoped, read-only tokens

I think we need to clarify things a bit as there are two "requests" and two "logs" being discussed and we're mixing and-and-matching.
There's the request to shields e.g: https://img.shields.io/appveyor/build/gruntjs/grunt
And then there's the request (or requests) to the upstream API e.g: https://ci.appveyor.com/api/projects/gruntjs/grunt
The thing we are "logging" in this logTrace() statement is the second request - our request to the upstream API. This means that if we send credentials upstream in the request (either query string or headers) we will console.log() them here. Those might be from our env vars. Those might be passed via the query string to the first request. Either way, if you have an interactive shell you can read them anyway. These statements don't end up in the heroku logs, but also bear in mind that 100% of the people who can read the heroku logs can also read (and change) our env vars in heroku too.
The thing you see in the heroku logs are the first type of request - the inbound request to shields.io. Any credentials the user passes in that query string do get logged there and retained for a very short amount of time (heroku only lets us see the last 1000 log entries and we process >10 million per day, so that usually covers less than 1 minute of traffic), but those credentials (as you've already mentioned) should also be safe for the user to expose in a (public) README. Either way, This PR doesn't change anything to do with the logging (to the console) or logging (in heroku) of those requests. The second type of request (to upstream APIs) don't appear in the heroku logs.
The other thing that might be confusing the issue here is I gave the example npm run badge https://img.shields.io/appveyor/build/gruntjs/grunt further up, but if you run that on your local copy no data is being sent to or received from shields.io. Everything is being done locally - it is actually replacing https://img.shields.io with http://localhost:8080.
https://github.com/badges/shields/blob/02692fe810ee91ee7da48c996f89fd1185ec7632/scripts/badge-cli.js#L24
That may have also been..non-obvious in retrospect.

I wasn't sure if any of this would make it's way into the Heroku logs, though after thinking some more even if it did, it's a pretty rare case where we accept a user's token as a query param and even then we only allow narrowly scoped, read-only tokens

I think we need to clarify things a bit as there are two "requests" and two "logs" being discussed and we're mixing and-and-matching.
There's the request to shields e.g: https://img.shields.io/appveyor/build/gruntjs/grunt
And then there's the request (or requests) to the upstream API e.g: https://ci.appveyor.com/api/projects/gruntjs/grunt
The thing we are "logging" in this logTrace() statement is the second request - our request to the upstream API. This means that if we send credentials upstream in the request (either query string or headers) we will console.log() them here. Those might be from our env vars. Those might be passed via the query string to the first request. Either way, if you have an interactive shell you can read them anyway. These statements don't end up in the heroku logs, but also bear in mind that 100% of the people who can read the heroku logs can also read (and change) our env vars in heroku too.
The thing you see in the heroku logs are the first type of request - the inbound request to shields.io. Any credentials the user passes in that query string do get logged there and retained for a very short amount of time (heroku only lets us see the last 1000 log entries and we process >10 million per day, so that usually covers less than 1 minute of traffic), but those credentials (as you've already mentioned) should also be safe for the user to expose in a (public) README. Either way, This PR doesn't change anything to do with the logging (to the console) or logging (in heroku) of those requests. The second type of request (to upstream APIs) don't appear in the heroku logs.
The other thing that might be confusing the issue here is I gave the example npm run badge https://img.shields.io/appveyor/build/gruntjs/grunt further up, but if you run that on your local copy no data is being sent to or received from shields.io. Everything is being done locally - it is actually replacing https://img.shields.io with http://localhost:8080.
https://github.com/badges/shields/blob/02692fe810ee91ee7da48c996f89fd1185ec7632/scripts/badge-cli.js#L24
That may have also been..non-obvious in retrospect.

I think we need to clarify things a bit as there are two "requests" and two "logs" being discussed and we're mixing and-and-matching.

Good call :+1: Sorry, I had this initial abstract thought bubble of "oh this looks neat, let's do it as long as it doesn't result in anything showing up anywhere it shouldn't/running afoul of no-tracking promise", which was manifested as a couple disjointed posts without actually digging into it.
I agree this is a good improvement, and that this doesn't result in any undesired log/exposure of information/etc. that I had initially been pondering. Thanks for the detailed write up as well!

I think we need to clarify things a bit as there are two "requests" and two "logs" being discussed and we're mixing and-and-matching.

Good call :+1: Sorry, I had this initial abstract thought bubble of "oh this looks neat, let's do it as long as it doesn't result in anything showing up anywhere it shouldn't/running afoul of no-tracking promise", which was manifested as a couple disjointed posts without actually digging into it.
I agree this is a good improvement, and that this doesn't result in any undesired log/exposure of information/etc. that I had initially been pondering. Thanks for the detailed write up as well!


asdf-nodejs friendly nvmrc

asdf-nodejs needs a full version specification, not just a major version. So for example
# .nvmc
lts/erbium
v12.x.y

I'd be happy to open a pull request for this change. If that sounds good to you, do you have a preferred version? Latest 12.x is 12.20.0

I don't know how asdf-nodejs works but this is a fair request. Does it affect how nvm would work?
Out of curiosity, how does it keep up with minor or patch version releases short of editing the .nvmrc?

Would this affect how nvm works?

I believe no. nvm seems to only look at the first option — it doesn't cascade. For example, the latest 12.x I have installed with nvm is 12.16.3, and I don't have lts/erbium installed with nvm. If I change the Smix nvmrc to
lts/erbium
v12.16.3

nvm insists on using lts/erbium:
% nvm use
Found 'snip/.nvmrc' with version <lts/erbium>
N/A: version "lts/erbium -> N/A" is not yet installed.

You need to run "nvm install lts/erbium" to install it before using it.

how does the former keep up with minor or patch version releases short of editing the .nvmrc each time?

It doesn't. Which is a good point: my proposal might not be a good fit for this project if you're updating for each Erbium release. Looking at the package-lock I think you might be

I'm not necessarily updating for each minor/patch release. Since it's semver, I'd like for folks who npm install, whenever they clone it, to get those fixes from the recent releases since it doesn't (shouldn't) cause breaking changes.
Since this does not interrupt my workflow with nvm, I'm happy to have it in if you wish to open a PR. Probably worth putting a note in the README.


Angular 19 Support

What problem does this feature solve?
Allows users to migrate to Angular 19
What does the proposed API look like?
Upgrade dependencies to enable users to migrate to Angular 19.
PR merged for @ant-design/icons-angular package chore: bump icons-angular to v19 but it seems we waiting for NPM package to be published

npm package for @ant-design/icons-angular v19 is published.
ng-zorro-antd@19 is on the way, we are planning to publish a beta version this week.

npm package for @ant-design/icons-angular v19 has been published today.
ng-zorro-antd@19 is on the way, we are planning to publish a beta version this week.

Any update on this ? because we are starting new project with angular 19 and we really need to ng-zorro in our project

There is an important feature PR still in progress #8903

These two PRs have nothing to do with Angular 19 though? Why would these block the support of 19?

These two PRs have nothing to do with Angular 19 though? Why would these block the support of 19

@dylanvdmerwe  It's likely to be because those 2 PRs are part of v19 Milestone and since at least one of these PRs contains breaking changes, it will be better to include it with Angular upgrade otherwise the team wouldn't have the opportunity to introduce breaking changes until v20, most likely due out after Angular v20.

Yeah! We're almost there! My frontend team is joining me next week, and I’m pumped to have Angular 19 ready in the architecture for their arrival. Let’s keep up the amazing work!

👋 Hey everyone!
<EMAIL_ADDRESS>is available, welcome to upgrade to the beta version and have a try by executing
ng update<EMAIL_ADDRESS>
We've brought in a lot of new features in v19, please refer to release note to learn more! Thanks to all the developers in the community who have contributed so much to it!
Looking forward to your kindly feedback, which is really important to us.
Best,
NG ZORRO team

ng update<EMAIL_ADDRESS>

For people who use ng update to upgrade, you may encounter the following errors
An unhandled exception occurred: Cannot find module '@angular-devkit/core'
Require stack:
-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>- /Users/laffery/playground/ng-version/ng18/node_modules/ng-zorro-antd/schematics/ng-update/index.js
-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>See "/private/var/folders/wy/hks67dyn2t3856tggqh4zkkw0000gp/T/ng-eUtPGl/angular-errors.log" for further details.

Consider to add @angular-devkit/core to devDependencies explicitly.

@Laffery hey! The 19.0.0-beta.0 changelog says NzInputGroupComponent is deprecated, yet it's not marked as such in the code and I can't find the proposed alternative. Are you sure it's correct?

@Laffery hey! The 19.0.0-beta.0 changelog says NzInputGroupComponent is deprecated, yet it's not marked as such in the code and I can't find the proposed alternative. Are you sure it's correct?

@lppedd hi! It's a mistake, what's really deprecated is its nzCompact input property, which can be replaced with new nz-space-compact component.
The release note is updated, thank you very much!


Broken builds

There are several broken builds currently. This ticket focuses on the broken builds on modules which are included in silverstripe/recipe-kitchen-sink.
Broken builds (minor release branch e.g. 4)

[ ] silverstripe/framework
[x] silverstripe/admin
[x] silverstripe/userforms
[x] silverstripe/totp-authenticator
[ ] silverstripe/installer
[ ] silverstripe/recipe-kitchen-sink
[ ] silverstripe/recipe-blog

Broken builds (patch release branch e.g. 4.10)

[x] silverstripe/admin
[ ] dnadesign/silverstripe-elemental
[x] silverstripe/fulltextsearch

Acceptance criteria

[ ] all builds listed above are passing on the major branch and more recent minor branch.

PRs

[x] silverstripe/silverstripe-testsession#74
[x] silverstripe/silverstripe-behat-extension#213
[x] silverstripe/silverstripe-totp-authenticator#90
[ ] https://github.com/silverstripe/silverstripe-assets/pull/487
[x] https://github.com/silverstripe/silverstripe-postgresql/pull/127
[ ] https://github.com/silverstripe/silverstripe-mfa/pull/453

Note

Cannot replicate the silverstripe/installer behat failure either locally or using github actions ci

The elemental build has broken in a way very similar to silverstripe/silverstripe-elemental#954 - at least for the publish mutation. I'm hoping the fix that was put in place for 4 will work here.

Linked PRs have been merged


Bless with || generates incorrect code

Bless with || generates incorrect code.  For example (from CGI.pm):
  bless $self,ref $class || $class || $DefaultClass;

The || is part of the second argument to bless, not to be checked after the bless completes.

Fixed  in v1.019


Representation Colour Help

Hi.
I am trying to make a viewer where user can view certain residues as of different colors based on the groups.
What I tried is  : https://jsfiddle.net/oL7jvhew/
Try moving cursor on the right side panel list. Wait for few seconds.
Issue: It's slow. It's really slow. Those few seconds it takes to change the color is the problem.
For smaller proteins it works OK. But for bigger structures it becomes impractical.
How to improve the performance?

It's slightly more performant if you don't recreate the representations every time:
https://jsfiddle.net/4q8cyf10/2/
But it's still not great, which is to do with the way the selection engine works. A bit of a workaround is here:
https://jsfiddle.net/4q8cyf10/6/
Basically, the selection code tests each atom against the whole of your expression each time, which, given its structure (lots of chain, residue ID stuff) is slow, we can make a more efficient representation by getting a BitArray (getAtomSet) and then calling toSeleString() on it - this is a string that looks like "@1,2,3,110,12121,..."
My apologies that this is very hacked to your specific case, but the relevant snippet from the fiddle linked above is:
var colourScheme = "";
            var representation = "";

            var sele1 = new NGL.Selection(colorData[0].join(''))
            var sele2 = new NGL.Selection(colorData[1].join(''))

            var comp = stage.compList[0]
            var struc = comp.structure
            var atomSeleExpr1 = struc.getAtomSet(sele1).toSeleString()
            var atomSeleExpr2 = struc.getAtomSet(sele2).toSeleString()

            var sid = generateSchemeID([[atomSeleExpr1], [atomSeleExpr2]])

            stage.getRepresentationsByName("polymer").setParameters({
            	// colorScheme: generateSchemeID(colorData)
              colorScheme: sid
              // colorScheme: schemes[colorSchemeIndex++ % 2]
            });

Two solutions to this (in terms of fixing NGL code):

Do the AtomSet creation inside SelectionColormaker.atomColor (atomSets are cached on Structure so would only get called once)
Allow passing in BitArrays rather than selection expressions

It works. Thank You.
It will take me some time to understand how it is working.
Two more things I am struggling with, related to this.
Issue  #822
https://github.com/nglviewer/ngl/issues/822
I was not able to explain the issue properly there.

Simply, have  a look at the fiddle you posted. The whole structure is of white/gray color except the red, blue groups. I need to put colors on the chains also, so that it's easy to understand where two chains are interacting. I tried manually adding the residue list to the "generateSchemeID" after red, blue groups but that even the first loading is slow. If making them of light colors or of little transparency, it will be better looking.

Second, there are domains in proteins. I need to add boundaries of those domains. Let's say if N residues are forming a domain in chain X, make a dark outline forming an area of boundary residues  Or color them of some other shade of the same colour as chain.
These red,blue interactions happen chain wise and domain wise. ( later need to add trasparency in red, blue also )

I made a different server where on mouehover 2 residues change to ball+stick on cartoon representation, telling the user where the bonds exist. I will try to implement similar logic there to increase the speed.
These kind of features, where we can show certain interactions, residues, representations is very common. JSmol got some scripts which can be implemented directly and it's fast. That's how I was trying to implement same in ngl.
Hope these kind of stuff is implemented in mol*.
Thank You

I've commented on the other one - closing this for now but reopen if there are other things related to this issue


Bad or unmapped utility_id_eia value(s) in ownership_eia860 table

There appears to be a bad utility_id_eia value in the ownership_eia860 table, associated with plant_id_eia==56032 See the dataframe returned by:
own_eia860 = pudl_out.own_eia860()
own_eia860[own_eia860.plant_id_eia==56032]

However, in all other years, that plant has the same utility_id_eia associated with its generators, and it is consistently mapped to a utility_id_pudl
Seems like we should consider some kind of NA filling in the harvesting process.

@cmgosnell Is this related to the weird owner vs. operator thing you encountered recently?

It could be. I know we are re-vamping harvesting but in the meantime I've been leaning more and more towards have utility_id_eia be one of the columns which we always harvest some value for. It is an integral merge key and the original data has known issues, especially with the ownership table. This would be implemented by simply adjusting the required strictness for this column.


I can not run the dissertation

Please tell me what should I do?

Check out the Menu section (above the file explorer) and set the Main Document to My_thesis.tex


Is there a reason why you can't do single-component full-owning groups?

I have a group of components I'd like packed together and fully-owned via an entt::group but the API doesn't like that there's only one component in the registry.group<component>() template specifier.
This seems like a deliberate design decision, leading me to believe I'm missing something about groups.
Is what I'm doing an anti-pattern for some reason?

Uhm... I think you misunderstood how groups work. They are meant to arrange components from different pools in such a way that multi-component iterations are then linear, with no jumps nor branches (the so called perfect SoA).
Not sure what you're trying to do but it seems to me it's something more on the line of - I want to group the entities that have component position for which x is within 10 and 100. Am I wrong?

No, I don't care about filtering based on the component's data.
I have a particular component that is iterated over for all entities (that have it) unconditionally, but is not paired with any other component at all. I want to make iterating over all instances of that component as fast as possible, so I'd like it to be packed into its own list similar to how groups seem to do so.
Now that I'm writing this, I'm realizing that this is probably the default way entt structures instances of components, anyway...

Well, in this case, a single component view is what you want. It iterates all instances at once with no jumps nor branches. :+1:
If you want even more performance and you don't plan to add or remove instances of the same component during iterations, you can also use the raw access (data<T>, raw<T> and size<T>) to iterate directly the internal arrays of entities and components for the given type.
This is the best you can expect overall, no matter what. You're iterating a plain array from 0 to N-1 in this case. :wink:

That's exactly the information I needed ^^
Thanks for a great library, it has really been a breeze to use. ❤

Thank you for using it! I'm looking forward to having your project in the list of showcases. :wink:
Please, feel free to give me your feedback whenever you want. This is what helped to improve EnTT so far. :+1:

Absolutely, will do! :)


Padding needs to be done in home page

Describe the bug
Padding needs to be done in home page.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots

.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Hello @apurvjha123 please assign this issue to me under gssoc 24


Publish stable version

What should we do?
In order to make the library stable, we should do the following

[x] Integrate and test with Camunda Modeler (done via https://github.com/camunda/camunda-modeler/issues/2029#issuecomment-779666632)
[x] Reach out to other teams to try it out
[x] Wait for feedback

If no major obstacles came in

[x] Release v0.1.0.

Why should we do it?
Get out of alpha state.

Done via v0.1.0.


Unable to integrate Factory via CocoaPods on Xcode 14.3.1 (14E300c)

I encountered the following issue when integrating the Factory lib into my iOS project:
Failed to build module 'Factory'; this SDK is not supported by the compiler (the SDK is built with 'Apple Swift version 5.7.2 (swiftlang-<IP_ADDRESS>.5 clang-14<IP_ADDRESS>)', while this compiler is 'Apple Swift version 5.8.1 (swiftlang-<IP_ADDRESS>.5 clang-14<IP_ADDRESS>.100)'). Please select a toolchain that matches the SDK.

I have this issue integrating the latest Factory lib (version 2.1.5) via CocoaPods into my project, and my Xcode version is 14.3.1. When building the application on Xcode 14.2, everything works fine. Any help would be greatly appreciated 🙏

P/S: A potential solution is that the Factory lib needs to set the following flag to YES:
BUILD_LIBRARY_FOR_DISTRIBUTION = YES;
Ref: https://stackoverflow.com/a/58656323

Factory is distributed as source and not as a compiled XCFramework, so there is not place (and need) to set BUILD_LIBRARY_FOR_DISTRIBUTION=YES.
Did you try to:

Close Xcode
Delete derived data
Remove your Podfile.lock and the Pods directory
run pod cache clean 'Factory' --all
run pod install

@danielepantaleone thanks for your reply, it now is realized that in the Podfile's config of my project, the lib is being built in the binary form , :binary => true. Removing this setting now will remove this SDK issue.
Thank you again for your support, marking this issue as Closed now 🙏


Clock in ROS2

    This is another case using a macro that looks different from the idiomatic ROS2 API call, which I guess would be `node->getClock()->now()` (meaning you need to have the node pointer handy).

If the definition of ROS_TIME_NOW() is similar to the example in ros_compat.h, it's mildly concerning. Their ROS_CREATE_NODE() macro defines its own private global clock object to be used by future ROS_TIME_NOW() calls. This defeats the ROS2 concept, as I understand it, that each node has its own clock. I'm not clear how important that compartmentalization is, but if ROS2 supports running multiple nodes in the same process, it might be important to use the clock from the right node (e.g., some nodes might have their clocks initialized before others).
I think the namespaced inline function approach can't provide a definition that looks exactly like the ROS2 API call since the API involves a member function, but if we relax the requirement to match the syntax exactly, at least it could provide an inline function ff_ros::now(node) implemented as:

ROS1: ros::Time::now() (ignoring the node argument)
ROS2: node->getClock()->now()

Or we could decide to just stick with a macro for now, at the risk of having unexpected hassles later.
But if we are using macros for ROS abstraction, they should have a standard prefix such as FF_ROS...
Originally posted by @trey0 in https://github.com/nasa/astrobee/pull/600#discussion_r1037419941

We could also just have the time be different in ros1 and ros2 branches. It isn't very hard to merge and convert between the two here.
Also, now() is what we use most of the time, so maybe this is worthwhile, but for anything more complicated the underlying data type has changed so we won't be able to use the same code in both versions unless we really want to expand our macro library.


Update Secret Management bean in beans.xml

Purpose
$subject
Related Issues

https://github.com/wso2/product-is/issues/12643

When should this PR be merged

After the relevant changes are done in Frontend.
Merging the related PRs in the correct order.

Follow up actions

Database migration.
Merge related PRs.

Migrations (if applicable)

Will follow a database migration task (dropping a table, dropping some foreign key constraints, update secret type stored values).

Related PRs

https://github.com/wso2/identity-api-server/pull/326
https://github.com/wso2/carbon-identity-framework/pull/3788
https://github.com/wso2-extensions/identity-conditional-auth-functions/pull/86
https://github.com/wso2/product-is/pull/12655
https://github.com/wso2/carbon-utils/pull/23

Related FE changes are still not done and seems not planned.
Hence closing the PR


Fix popen_spawn when specifying a path on Windows which contains "" separators

I've opened an identical PR for pexpect: https://github.com/pexpect/pexpect/pull/446

what exactly does this do?

everything is behaving as expected right now.

This lets me run pipenv install --three --python=C:\Miniconda2\envs\python3\python.exe -d on Windows without getting WindowsError: [Error 2] The system cannot find the file specified. shlex.split without posix=False treats backslashes as escapes instead of preserving them.
There's an open StackOverflow question about this issue in popen_expect.
I should have explained the problem this solves for me.

Is posix=(os.sep == '/') maybe a more pragmatic solution?

given that we are specifically interested in whether we are dealing with a posix compliant platform I would recommend posix=(os.name == 'posix')

I just copied the test from earlier in the function where sys.platform == 'win32 is used. Testing for a POSIX system directly might be clearer.

I have a slight change to this over in #570 for reference


support for dataValidation.operator

I noticed that operator support wasn't implemented (and I need it).  I went off of these docs but it was really hard to find anything concrete so please let me know if I'm missing anything: https://learn.microsoft.com/en-my/dotnet/api/documentformat.openxml.spreadsheet.datavalidationoperatorvalues?view=openxml-2.8.1

@patrickomatic
Thanks for the RP.
We have no problem with the modifications and will merge them in.


Update Project Tab Complete Script

Closes #6910
-Add project list function
-Add project key list
-Add tab complete for "create delete edit get list rename set show switch unset " functions
-Add project list after above functions
-Add project key list after "get"|"set"|"unset" functions
-Add additional project list for "rename" function
Question: How would I test this functionality on my local computer? I tried to make a copy of /snap/lxd/current/etc/bash_completion.d/snap.lxd.lxc on my local server then replace it with my edited version, but the file is in use. I'm guessing that's due to lxd running, how would one hot swap the file?

This pull request didn't trigger Jenkins as its author isn't in the whitelist.
An organization member must perform one of the following:

To have this branch tested by Jenkins, use the "ok to test" command.
To have a one time test done, use the "test this please" command.

Those commands are simple Github comments of the format: "jenkins: COMMAND"

@66hades Hi, your commits need to all be individually signed-off (Signed-off-by:  line at the end) before we can review them. You may find more details in contributing.md.


ltp failed

What happened:
<<<test_start>>>
tag=mkdir09 stime=1655452461
cmdline="mkdir09"
contacts=""
analysis=exit
<<<test_output>>>
mkdir09     1  TFAIL  :  mkdir09.c:412: MKDIR ./X.2.0, errno = 4; Wrong error detected.
mkdir09     0  TWARN  :  tst_brk__: Invalid Type: 4. Using TBROK
mkdir09     1  TBROK  :  mkdir09.c:217: 	Child{127544} exited status = 100
What you expected to happen:
ltp pass
How to reproduce it (as minimally and precisely as possible):
Follow the action https://github.com/juicedata/juicefs/runs/6932047496?check_suite_focus=true .
Anything else we need to know?
No
Environment:

JuiceFS version (use juicefs --version) or Hadoop Java SDK version:
The version is d6e18fe .

This failure can't be reproduced, and all other runs recently have passed.
Will put it to a lower priority.

The ltp test has failed three times recently as follow https://github.com/juicedata/juicefs/actions/runs/2558030511 https://github.com/juicedata/juicefs/actions/runs/2558030511 https://github.com/juicedata/juicefs/actions/runs/2544975337 .


Breakdown 'WalletLayer' into top-level functions

Issue Number

N/A
Overview

This is a first step in a serie of refactors pursuing the following end
goals:

Improve modularity of the wallet layer functions by allowing composing
them in a more flexible way (remove the need for instantiating a big
fat 'WalletLayer' for functions which only requires the database).

Better testability for internal and top-level functions, making them
more 'pure' and easier to test.

Make effects & dependencies more explicit and visible from the
top-level signature of each function.

Comments

Next steps: provide a context with class constraints to really functions
modular. For example:
restoreWallet :: WalletLayer s t -> WalletId -> ExceptT ...

can become:
restoreWallet :: (HasRegistry ctx, HasDBLayer ctx) => ctx -> WalletId ->  ExceptT ...

bors r=

bors r+


Hi, Django Link is broken

Hi, Django Link is broken

duplicate

https://github.com/sindresorhus/awesome/pull/1484

Duplicate of #1478


kali startup issue

sorry for 2 issues back to back. dont remember having these issues the last time i installed kali a few months ago.
anyway, getting this when trying to startup xfce
chronos@localhost / $ sudo startxfce4
Entering /mnt/stateful_partition/crouton/chroots/kali-rolling...
/usr/bin/startxfce4: Starting X server
/usr/lib/xorg/Xorg.wrap: Only console users are allowed to run the X server
/usr/bin/xinit: giving up
/usr/bin/xinit: unable to connect to X server: Connection refused
/usr/bin/xinit: server error
Unmounting /mnt/stateful_partition/crouton/chroots/kali-rolling...
Sending SIGTERM to processes under /mnt/stateful_partition/crouton/chroots/kali-rolling...

bump someone please help me out with this

Works fine here... Please reopen with more details if this happens again after a chroot update.


arangoimp command tool is getting closed after entering a password

I have tried to use arangoimp command tool to import data to ArangoDB.
After entering a prompted password, the command tool has suddenly got closed immediately.
Why the arangoimp got closed?
I use the Windows 10 64-bit version, ArangoDB: 3.2
Thanks, Alex.

arangoimp is a command-line tool.
If you are using Windows my guess is you started the application by double-clicking on it?
If yes: from what I know this will open a command prompt and start arangoimp in it. It will then ask for the password, and when this is entered it will probably print an error message about missing other arguments (for example --file, --collection). After that arangoimp will exit and the command prompt will close immediately.
If you actually started it by double-clicking, can you instead try starting it from a command prompt? Then if arangoimp fails with an error message, then you will be able to see it and add the missing arguments.

Hello, Jan.
You are definitely right about using the arangoimp.exe.
I have managed to import two document collections, but I have failed to import the edge collection.
Here is the simple JSON for creating the edge collection (links2.json):
{"id":"links/2500","type":"link","t":"2500","id1":"actor/882","id2":"movie/120","d":{"_key":"2500","_id":"links/2500","_from":"actor/882","_to":"movie/120","_rev":"_VGKiEoS--a","name":"Arwen Evenstar","type":"acts_in"}}
the create command:
arangoimp --server.database movies --file "d:\links2.json" --type jsonl --collection "links2" --create-collection true --create-collection-type edge
and the warning I get:
WARNING at position 1: missing '_from' or '_to' attribute, offending document: {"d":{"_from":"actor/882","_id":"links/2500","_key":"2500","_rev":"_VGKiEoS--a","_to":"movie/120","name":"Arwen Evenstar","type":"acts_in"},"id":"links/2500","id1":"actor/882","id2":"movie/120","t":"2500","type":"link"}
As a result, the edge collection is created, but with no data (empty edge collection).
Thanks in advance, Alex.

The document specified in your example does not contain a _from nor a _to attribute on the top-level.
That's why arangoimp complains and does not import the document.
_from and _to are present in the document only as sub-attributes of top-level attribute d. They will not be picked up from there. In order to import the document, you should make _from and _to top-level attributes.

Thank you, Jan - it works now.

Closing this as answered

Hi @jsteemann, I ran the arangoimp tool from command tool but the import tool closed suddenly. It didn't even print any message on command prompt. Any help would be appreciated

Please don't revive unrelated old issues. Further discussion in https://github.com/arangodb/arangodb/issues/8540


[💡 FEATURE REQUEST]: Add automatic retry on Kafka connection failure

Plugin
JOBS
I have an idea!
I have an idea, listen to me!!
Hey!
When we start RoadRunner with Kafka not available yet (for eg when it is starting), the RR binary stops immediately with the following error:
handle_serve_command: Serve error:
    endure_start:
    endure_serve_internal: Function call error:
    endure_call_serve_fn: got initial serve error from the Vertex jobs.Plugin, stopping execution, error: jobs_plugin_serve:
    new_kafka_consumer: kafka: client has run out of available brokers to talk to: dial tcp: lookup kafka-brokers on <IP_ADDRESS>:53: server misbehaving

It will be great to have an automatic retry with options configurable in the .rr.yaml file, for eg:
connection.retry.attempts: 1 # 0 means forever
connection.retry.timeout: 10 # in seconds

Thank you

Hey @Baiquette 👋🏻 Have you tried the v2.11.2?


[repo] remove unused parts

I'm really only using one subfolder of the src.

related https://github.com/Sebanisu/Field-Map-Editor/commit/651f35688d4aaa03385aacedc39f14771c684796

I have removed alot of dead code and folders. Might need to remove more but closing for now.


DASHBUILDE-166: Content Manager Perspective

Full description of this feature at => https://issues.jboss.org/browse/DASHBUILDE-166
The feature is ready for Eng, QE & UXD review.
@ederign @jhrcek Can you please take a look?

@dgutierr I'm currently fully occupied by patch testing. Given the size of this PR I'll take a more thorough look on Monday and provide some feedback.

@ederign Please, can you specify what ui binder file are you referring to?

jenkins retest this

jenkins retest this

All commits squashed and ready to merge.
@romartin Can you review please?

Hey @dgutierr ,
Great improvements!! Looks and works really good! :)

db14438b1040001b484f9c4d1bc5d6251e2334fe


ubuntu install error

root@waytronic-server:~/下载/kaldi-onnx# sudo pip install -r requirements.txt
/usr/local/lib/python2.7/dist-packages/pip/_vendor/requests/init.py:83: RequestsDependencyWarning: Old version of cryptography ([1, 2, 3]) may cause slowdown.
warnings.warn(warning, RequestsDependencyWarning)
DEPRECATION: Python 2.7 will reach the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 won't be maintained after that date. A future version of pip will drop support for Python 2.7.
Requirement already satisfied: setuptools==18.5 in /usr/local/lib/python2.7/dist-packages (from -r requirements.txt (line 1)) (18.5)
Requirement already satisfied: six==1.11.0 in /usr/local/lib/python2.7/dist-packages (from -r requirements.txt (line 2)) (1.11.0)
Requirement already satisfied: numpy==1.14.1 in /usr/local/lib/python2.7/dist-packages (from -r requirements.txt (line 3)) (1.14.1)
Collecting onnx==1.5.0 (from -r requirements.txt (line 4))
Using cached https://files.pythonhosted.org/packages/1a/a7/a7aecbfe51f01f754b579ab3fbefaa53f03abdd8cc205cc9b0996089df34/onnx-1.5.0.tar.gz
Requirement already satisfied: protobuf in /usr/local/lib/python2.7/dist-packages (from onnx==1.5.0->-r requirements.txt (line 4)) (3.8.0)
Requirement already satisfied: typing>=3.6.4 in /usr/local/lib/python2.7/dist-packages (from onnx==1.5.0->-r requirements.txt (line 4)) (3.6.6)
Requirement already satisfied: typing-extensions>=<IP_ADDRESS> in /usr/local/lib/python2.7/dist-packages (from onnx==1.5.0->-r requirements.txt (line 4)) (3.7.2)
Building wheels for collected packages: onnx
Building wheel for onnx (setup.py) ... error
ERROR: Complete output from command /usr/bin/python -u -c 'import setuptools, tokenize;file='"'"'/tmp/pip-install-BUJ5mr/onnx/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(file);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, file, '"'"'exec'"'"'))' bdist_wheel -d /tmp/pip-wheel-udi8fk --python-tag cp27:
ERROR: fatal: Not a git repository (or any of the parent directories): .git
running bdist_wheel
running build
running build_py
running create_version
running cmake_build
-- The C compiler identification is GNU 5.4.0
-- The CXX compiler identification is GNU 5.4.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMake Error at CMakeLists.txt:226 (message):
Protobuf compiler not found
Call Stack (most recent call first):
CMakeLists.txt:257 (relative_protobuf_generate_cpp)
-- Configuring incomplete, errors occurred!
See also "/tmp/pip-install-BUJ5mr/onnx/.setuptools-cmake-build/CMakeFiles/CMakeOutput.log".
Traceback (most recent call last):
File "", line 1, in
File "/tmp/pip-install-BUJ5mr/onnx/setup.py", line 331, in
'backend-test-tools = onnx.backend.test.cmd_tools:main',
File "/usr/lib/python2.7/distutils/core.py", line 151, in setup
dist.run_commands()
File "/usr/lib/python2.7/distutils/dist.py", line 953, in run_commands
self.run_command(cmd)
File "/usr/lib/python2.7/distutils/dist.py", line 972, in run_command
cmd_obj.run()
File "/usr/lib/python2.7/dist-packages/wheel/bdist_wheel.py", line 179, in run
self.run_command('build')
File "/usr/lib/python2.7/distutils/cmd.py", line 326, in run_command
self.distribution.run_command(command)
File "/usr/lib/python2.7/distutils/dist.py", line 972, in run_command
cmd_obj.run()
File "/usr/lib/python2.7/distutils/command/build.py", line 128, in run
self.run_command(cmd_name)
File "/usr/lib/python2.7/distutils/cmd.py", line 326, in run_command
self.distribution.run_command(command)
File "/usr/lib/python2.7/distutils/dist.py", line 972, in run_command
cmd_obj.run()
File "/tmp/pip-install-BUJ5mr/onnx/setup.py", line 206, in run
self.run_command('cmake_build')
File "/usr/lib/python2.7/distutils/cmd.py", line 326, in run_command
self.distribution.run_command(command)
File "/usr/lib/python2.7/distutils/dist.py", line 972, in run_command
cmd_obj.run()
File "/tmp/pip-install-BUJ5mr/onnx/setup.py", line 192, in run
subprocess.check_call(cmake_args)
File "/usr/lib/python2.7/subprocess.py", line 541, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '[u'/usr/bin/cmake', u'-DPYTHON_INCLUDE_DIR=/usr/include/python2.7', u'-DPYTHON_EXECUTABLE=/usr/bin/python', u'-DBUILD_ONNX_PYTHON=ON', u'-DCMAKE_EXPORT_COMPILE_COMMANDS=ON', u'-DONNX_NAMESPACE=onnx', u'-DPY_EXT_SUFFIX=', u'-DCMAKE_BUILD_TYPE=Release', u'-DONNX_ML=1', '/tmp/pip-install-BUJ5mr/onnx']' returned non-zero exit status 1
ERROR: Failed building wheel for onnx
Running setup.py clean for onnx
Failed to build onnx
Installing collected packages: onnx
Running setup.py install for onnx ... error
ERROR: Complete output from command /usr/bin/python -u -c 'import setuptools, tokenize;file='"'"'/tmp/pip-install-BUJ5mr/onnx/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(file);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, file, '"'"'exec'"'"'))' install --record /tmp/pip-record-Kj6olq/install-record.txt --single-version-externally-managed --compile:
ERROR: fatal: Not a git repository (or any of the parent directories): .git
running install
running build
running build_py
running create_version
running cmake_build
CMake Error at CMakeLists.txt:226 (message):
Protobuf compiler not found
Call Stack (most recent call first):
CMakeLists.txt:257 (relative_protobuf_generate_cpp)
-- Configuring incomplete, errors occurred!
See also "/tmp/pip-install-BUJ5mr/onnx/.setuptools-cmake-build/CMakeFiles/CMakeOutput.log".
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/tmp/pip-install-BUJ5mr/onnx/setup.py", line 331, in <module>
    'backend-test-tools = onnx.backend.test.cmd_tools:main',
  File "/usr/lib/python2.7/distutils/core.py", line 151, in setup
    dist.run_commands()
  File "/usr/lib/python2.7/distutils/dist.py", line 953, in run_commands
    self.run_command(cmd)
  File "/usr/lib/python2.7/distutils/dist.py", line 972, in run_command
    cmd_obj.run()
  File "/usr/local/lib/python2.7/dist-packages/setuptools/command/install.py", line 61, in run
    return orig.install.run(self)
  File "/usr/lib/python2.7/distutils/command/install.py", line 601, in run
    self.run_command('build')
  File "/usr/lib/python2.7/distutils/cmd.py", line 326, in run_command
    self.distribution.run_command(command)
  File "/usr/lib/python2.7/distutils/dist.py", line 972, in run_command
    cmd_obj.run()
  File "/usr/lib/python2.7/distutils/command/build.py", line 128, in run
    self.run_command(cmd_name)
  File "/usr/lib/python2.7/distutils/cmd.py", line 326, in run_command
    self.distribution.run_command(command)
  File "/usr/lib/python2.7/distutils/dist.py", line 972, in run_command
    cmd_obj.run()
  File "/tmp/pip-install-BUJ5mr/onnx/setup.py", line 206, in run
    self.run_command('cmake_build')
  File "/usr/lib/python2.7/distutils/cmd.py", line 326, in run_command
    self.distribution.run_command(command)
  File "/usr/lib/python2.7/distutils/dist.py", line 972, in run_command
    cmd_obj.run()
  File "/tmp/pip-install-BUJ5mr/onnx/setup.py", line 192, in run
    subprocess.check_call(cmake_args)
  File "/usr/lib/python2.7/subprocess.py", line 541, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '[u'/usr/bin/cmake', u'-DPYTHON_INCLUDE_DIR=/usr/include/python2.7', u'-DPYTHON_EXECUTABLE=/usr/bin/python', u'-DBUILD_ONNX_PYTHON=ON', u'-DCMAKE_EXPORT_COMPILE_COMMANDS=ON', u'-DONNX_NAMESPACE=onnx', u'-DPY_EXT_SUFFIX=', u'-DCMAKE_BUILD_TYPE=Release', u'-DONNX_ML=1', '/tmp/pip-install-BUJ5mr/onnx']' returned non-zero exit status 1
----------------------------------------

ERROR: Command "/usr/bin/python -u -c 'import setuptools, tokenize;file='"'"'/tmp/pip-install-BUJ5mr/onnx/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(file);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, file, '"'"'exec'"'"'))' install --record /tmp/pip-record-Kj6olq/install-record.txt --single-version-externally-managed --compile" failed with error code 1 in /tmp/pip-install-BUJ5mr/onnx/

If the python version of your OS is 3.x, try pip3 install instead.

try  python 3.5  and it is the same
kaldi-onnx pip3 instal.log

It seems an issue of environment for onnx installation.
https://github.com/opencv/open_model_zoo/issues/82
https://github.com/onnx/onnx/issues/1914

install protobuf-compiler:
apt install protobuf-compiler
and then another error occured:
Installing collected packages: onnx
  Running setup.py install for onnx ... error
    ERROR: Complete output from command /usr/bin/python3.5 -u -c 'import setuptools, tokenize;__file__='"'"'/tmp/pip-install-6v0n7ibv/onnx/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record /tmp/pip-record-v8uy209c/install-record.txt --single-version-externally-managed --compile:
    ERROR: fatal: Not a git repository (or any of the parent directories): .git
    running install
    running build
    running build_py
    running create_version
    running cmake_build
    CMake Warning at CMakeLists.txt:365 (find_package):
      By not providing "Findpybind11.cmake" in CMAKE_MODULE_PATH this project has
      asked CMake to find a package configuration file provided by "pybind11",
      but CMake did not find one.

      Could not find a package configuration file provided by "pybind11"
      (requested version 2.2) with any of the following names:

        pybind11Config.cmake
        pybind11-config.cmake

      Add the installation prefix of "pybind11" to CMAKE_PREFIX_PATH or set
      "pybind11_DIR" to a directory containing one of the above files.  If
      "pybind11" provides a separate development package or SDK, be sure it has
      been installed.

pip3 install pybind
useless

works for me
apt install python3-dev pip install pytest pip install numpy pip install scipy git clone https://github.com/pybind/pybind11.git cd pybind11 mkdir build cd build cmake .. make -j4 make install


Introduce mut keyword for properties on objects

By default all properties will have readonly: true set on TProp.  When determining if an object is a subtype of another object, properties that are mutable can be thought of as subtypes of their immutable counterpart.

This was added in #297.  unify_mut hasn't been implemented yet though.  I'll open a separate issue for that.


Mockup A, B and C Additions

Maybe try rebasing your commits so all the 'Update README.md" ones are collapsed?
I think the UI looks good, but I'm a little confused on the user interactions. Do they click the icons or drag them? The spring initializr does something similar; maybe we can model some things from this: https://start.spring.io


delete resendoauthverificationrequest and resendoauthverificationrequest_test

Fixes

Fixes #1042  by @sarayourfriend
Description

since the. Verification emails are being sent now, there is no use of the resendoauthverificationrequest command, and it's test cases. So we can remove these files from their respective directories. This branch removes those files.
Please note if you run 'just api-test' too frequently, you'll fail some test cases as they revert with a status code of 429, which is too many requests in a limited time, so you can wait for a couple of minutes and test again it will work fine then.
Testing Instructions
'just api-test' will no more run for resendoauthverification_test.
Checklist

[x] My pull request has a descriptive title (not a vague title like
Update index.md).
[x] My pull request targets the default branch of the repository (main) or
a parent feature branch.
[x] My commit messages follow best practices.
[ ] My code follows the established code style of the repository.
[x] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no visible
errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Hey @sarayourfriend any update??

Hi @sahil-R, I (and many other Openverse maintainers) do not check the Openverse repositories over the weekend. I ask that you be patient with us as well, as it's an active project with lots going on and we sometimes take a moment to get around to things like this. That being said, thanks for the original direct ping as it made this easy to find :slightly_smiling_face:
Please feel free to ignore the repeated test runs causing 429s. We have an issue that would address this problem but needs more thinking before it can be implemented #866. With #1027 merged, it should be slightly easier to implement it, so we might be able to revisit that issue soon.
In any case, so long as you've deleted the two files mentioned in the issue discussion, which you have done here, then this PR will be easy to approve once it is undrafted. Feel free to undraft it at your leisure.

Hi @sahil-R, I (and many other Openverse maintainers) do not check the Openverse repositories over the weekend. I ask that you be patient with us as well, as it's an active project with lots going on and we sometimes take a moment to get around to things like this. That being said, thanks for the original direct ping as it made this easy to find 🙂
Please feel free to ignore the repeated test runs causing 429s. We have an issue that would address this problem but needs more thinking before it can be implemented #866. With #1027 merged, it should be slightly easier to implement it, so we might be able to revisit that issue soon.
In any case, so long as you've deleted the two files mentioned in the issue discussion, which you have done here, then this PR will be easy to approve once it is undrafted. Feel free to undraft it at your leisure.

Hey @sarayourfriend, sorry for the messages, I had university exams aligned so I thought I'll finish it before that rest said , I'll open a pr ,thankyou for your time and once again i apologise for disturbing you out of time.


Move file has some issues with LiteDB

1 - Hide all files and folders after a file moved

It doesn't have problem now.


Timed notifications

-Not getting any timed notification on android device.

Still not getting any timed notification on android device.

@cakesoft-swati  we need to test this somehow.

May need to use the backend to push notification.


Fixed imread for new parsing of =>

Due to the recent change in parsing of => , imread was failing to create properties dict.  Simple fix.

Thanks!


FLUID-5469: Update docs to remove FSS mentions; Update UIO tutorial

@jobara, I've updated your branch to master and also update the UIO tutorial instructions. Michelle will want to share this tutorial at the conference, so we should try to get it merged.

Regarding the restructuring of migration tutorials, let's leave that issue for another branch.

merged at 27c70e78f161ff43adcec8b25c22cd317c351883


Two different IPlayer instances can be equal

Description of the problem
When a player connects he gets a IPlayer instance with a particular Id.
When he disconnects and reconnects back later he gets another IPlayer instance with different Id but the two IPlayer instance are equal.
It seems that the Equal() is not based on content of the IPlayer instance but on something else because the behavior isn't 100% consistant.
Reproduction steps
Create and in Alt.OnPlayerConnect event that add the IPlayer instance to an HashSet and display an error if the add returned false:
    public static class LoginManager
    {
        private static HashSet<IPlayer> _players = new();

        public static void Init()
        {
            Alt.OnPlayerConnect += (IPlayer client, string reason) =>
            {
                Alt.Log($"Client {client.Id} Connected");
                if (!_players.Add(client))
                    Alt.Log("IPlayer already in HashSet");
            };
        }
    }

Result:
[20:10:19] Client 164 Connected
[20:10:34] Client 165 Connected
[20:10:52] Client 166 Connected
[20:10:52] IPlayer already in HashSet

Here it takes me 2 reconnects to have equal IPlayer instances but sometimes it can take morre or less attempts.
Expected behaviour
Different IPlayer instances with different Id should not be equal.
Additional context
No response
Operating system
Windows 10 21H2
Version
release/10.8

IPlayer.Equals() is inherited from SharedBaseObject.Equals(), which only compares type and native pointer.
https://github.com/FabianTerhorst/coreclr-module/blob/6f356bef68ba88f19938a00da2699b4dad442d59/api/AltV.Net.Shared/Elements/Entities/SharedBaseObject.cs#L219
This seems like a breaking change for others if the maintainer overrides IPlayer.Equals() in the module.


VSCode changed "conda activate [environment]" to "source activate [environment]"

Version: 1.74.3 (user setup)
OS: Windows_NT x64 10.0.19044
Steps to Reproduce:
The problem I'm facing is that vscode executes "source activate [environment]" instead of "conda activate [environment]" only when I connect to my server via ssh. My server runs ubuntu 20.04 and same thing happens when connecting from windows or linux. It always worked well until this afternoon. I tried updating vscode, but it didn't solve it.
As I've always done, selecting my python interpreter from my conda env in local works well, but it does not when I do it in remote.
Thank in advance.

/extPython

It looks like this is caused by the Python extension. Please file the issue to the Python extension repository. Make sure to check their issue reporting template and provide them relevant information such as the extension version you're using. See also our issue reporting guidelines for more information.
Happy Coding!


Defensively abort worker task if it didn't return COMPLETE.

This fixes the issue where scheduler would exit the run step with in error (namely BADREQUEST) and then continue to send jobs to the same worker which was stuck running the previous command. This isn't comprehensive but Abort() is the only mechanism we currently have to clean up a worker.

What case is this supposed to be fixing again?

Codecov Report

Merging #287 into master will increase coverage by 0.47%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #287      +/-   ##
==========================================
+ Coverage    59.4%   59.88%   +0.47%
==========================================
  Files          90       90
  Lines        6974     7034      +60
==========================================
+ Hits         4143     4212      +69
+ Misses       2526     2518       -8
+ Partials      305      304       -1

Impacted Files
Coverage Δ

sched/scheduler/task_runner.go
87.67% <100%> (+1.88%)
:arrow_up:

runner/runners/invoke.go
70.62% <100%> (+0.16%)
:arrow_up:

sched/scheduler/stateful_scheduler.go
74.14% <0%> (+0.58%)
:arrow_up:

runner/runners/queue.go
84.95% <0%> (+6.06%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 626d32b...be7aa63. Read the comment docs.


EitherT upgraded to ExceptT (and updates in .cabal)

I've made some updates mainly to cope with a recent change in EitherT.

Thanks -- I'll try to take a look at this in the next week or two.  I need to fix a couple of other things (Travis setup, your earlier PR about hmatrix) and then I'll make a new release.

OK -- merged!  Thanks!


Restore dotty build for AHC and JDK Http ZIO backends

We need zio-interop-reactive-streams to be build and released for dotty.
See: https://github.com/zio/interop-reactive-streams/pull/129

Done in 2.2.0


[Question] It here any performance tests?

I wonder if there also performance tests not only feature support test

Nope, feel free to add some!


Update container with sandbox metadata after NetNS is created

This is to fix a bug introduced in https://github.com/containerd/containerd/pull/5904.
When the network namespace is created, we need to update both container spec and sandbox metadata so that both information can persist on disk. If sandbox metadata is missing, the NetNS is considered as closed when loading sandbox during restart recovery because the NetNS.path is empty. Closed NetNS will affect network teardown in sandbox stop.
Manual Testing

Add a sleep in setupPodNetwork, e.g. 60s
sudo crictl runp sandbox.json
Restart containerd
sudo crictl pods shows the

Before fix: sudo crictl inspectp <POD ID> shows "netNamespaceClosed": true
After fix: sudo crictl inspectp <POD ID> shows "netNamespaceClosed": false
New Integration Test
WIP

/ok-to-test

updateContainerSpec is now no longer called and is causing linter errors.  That will need to be removed.

[It] runtime should support portforward in host network
Timed out after 60.000s.
  Expected
      <*url.Error | 0xc0007b4ab0>: {
          Op: "Get",
          URL: "http://<IP_ADDRESS>:12002/",
          Err: <*net.OpError | 0xc0007c2190>{
              Op: "dial",
              Net: "tcp",
              Source: nil,
              Addr: <*net.TCPAddr | 0xc0007b4a80>{
                  IP: [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 255, 255, 127, 0, 0, 1],
                  Port: 12002,
                  Zone: "",
              },
              Err: <*os.SyscallError | 0xc00014b4a0>{
                  Syscall: "connect",
                  Err: <syscall.Errno>0x6f,
              },
          },
      }
  to be nil
  In [It] at: github.com/kubernetes-sigs/cri-tools/pkg/validate/networking.go:253

[It] runtime should support portforward in host network
Timed out after 60.000s.
  Expected
      <*url.Error | 0xc0007b4ab0>: {
          Op: "Get",
          URL: "http://<IP_ADDRESS>:12002/",
          Err: <*net.OpError | 0xc0007c2190>{
              Op: "dial",
              Net: "tcp",
              Source: nil,
              Addr: <*net.TCPAddr | 0xc0007b4a80>{
                  IP: [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 255, 255, 127, 0, 0, 1],
                  Port: 12002,
                  Zone: "",
              },
              Err: <*os.SyscallError | 0xc00014b4a0>{
                  Syscall: "connect",
                  Err: <syscall.Errno>0x6f,
              },
          },
      }
  to be nil
  In [It] at: github.com/kubernetes-sigs/cri-tools/pkg/validate/networking.go:253

/retest


docs(tabs): add more and different examples

Bug, feature request, or proposal:
Proposal
What is the expected behavior?
To show some more examples of different implementations of the md-tabs components in the documentation.
What is the current behavior?
There's only showing More examples coming soon! on the examples page.
What is the use-case or motivation for changing an existing behavior?
People want good examples to show what a possible result can be. Right now, there's only one example of a basic tab, but adding examples for dynamicHeight, tabs with icons and tabs with navigation (overlapping).
Also, issues like these (#6109 and #6104) will show up earlier or won't show up at all.
Is there anything else we should know?
I can make a PR for this, but I'm not sure if that's desirable. Maybe let's first discuss which examples to be shown.

Done by https://github.com/angular/material2/pull/6295


bibtex for @inproceedings from Crossref

@jowens for the ProceedingsArticle https://doi.org/10.1145/3448016.3452841 i get this bibtex output:
@inproceedings{https://doi.org/10.1145/3448016.3452841,
    author = {Pandey, Prashant and Conway, Alex and Durie, Joe and Bender, Michael A. and Farach-Colton, Martin and Johnson, Rob},
    booktitle = {Proceedings of the 2021 International Conference on Management of Data},
    copyright = {https://www.acm.org/publications/policies/copyright_policy#Background},
    doi = {10.1145/3448016.3452841},
    month = jun,
    publisher = {Association for Computing Machinery (ACM)},
    title = {Vector Quotient Filters},
    url = {https://dl.acm.org/doi/10.1145/3448016.3452841},
    urldate = {2021-06-09},
    year = {2021}
}

It missed the series information and adds a copyright field, but is it otherwise what you expect?

The BibTeX title should be "Vector Quotient Filters: Overcoming the Time/Space Trade-Off in Filter Design". If both title and subtitle fields are present, they should be joined with a colon and put into the BibTeX title field.

I paste in ACM's generated BibTeX for posterity:
@inproceedings{10.1145/3448016.3452841,
author = {Pandey, Prashant and Conway, Alex and Durie, Joe and Bender, Michael A. and Farach-Colton, Martin and Johnson, Rob},
title = {Vector Quotient Filters: Overcoming the Time/Space Trade-Off in Filter Design},
year = {2021},
isbn = {9781450383431},
publisher = {Association for Computing Machinery},
address = {New York, NY, USA},
url = {https://doi.org/10.1145/3448016.3452841},
doi = {10.1145/3448016.3452841},
abstract = {Today's filters, such as quotient, cuckoo, and Morton, have a trade-off between space and speed; even when moderately full (e.g., 50%-75% full), their performance degrades nontrivially. The result is that today's systems designers are forced to choose between speed and space usage. In this paper, we present the vector quotient filter (VQF). Locally, the VQF is based on Robin Hood hashing, like the quotient filter, but uses power-of-two-choices hashing to reduce the variance of runs, and thus offers consistent, high throughput across load factors. Power-of-two-choices hashing also makes it more amenable to concurrent updates, compared to the cuckoo filter and variants. Finally, the vector quotient filter is designed to exploit SIMD instructions so that all operations have O (1) cost, independent of the size of the filter or its load factor. We show that the vector quotient filter is 2\texttimes{} faster for inserts compared to the Morton filter (a cuckoo filter variant and state-of-the-art for inserts) and has similar lookup and deletion performance as the cuckoo filter (which is fastest for queries and deletes), despite having a simpler design and implementation. The vector quotient filter has minimal performance decline at high load factors, a problem that has plagued modern filters, including quotient, cuckoo, and Morton. Furthermore, we give a thread-safe version of the vector quotient filter and show that insertion throughput scales 3\texttimes{} with four threads compared to a single thread.},
booktitle = {Proceedings of the 2021 International Conference on Management of Data},
pages = {1386–1399},
numpages = {14},
keywords = {filters, membership query, dictionary data structure},
location = {Virtual Event, China},
series = {SIGMOD '21}
}

Anyway, except for the title and pages, yes, it looks splendid!

This is very helpful. There are three groups of issues here:

Metadata not submitted to Crossref during DOI registration
Metadata not exposed in the JSON REST API
Metadata not parsed correctly by commonmeta-py

Comparing the submitted XML and generated JSON helps distinguish between the three categories:

https://api.crossref.org/works/10.1145/3448016.3452841
https://api.crossref.org/works/10.1145/3448016.3452841/transform/application/vnd.crossref.unixsd+xml

commonmeta-py supports both API calls using the via property (the default for Crossref DOIs is using the JSON REST API). In a Jupyter notebook (and soon on the command line) you can write:
string = '10.1145/3448016.3452841'
metadata = Metadata(string, via='crossref')
bibtex = metadata.bibtex()
print(bibtex)

string = '10.1145/3448016.3452841'
metadata = Metadata(string, via='crossref_xml')
bibtex = metadata.bibtex()
print(bibtex)

Results:

Page numbers are not submitted to Crossref
Abstract is not submitted to Crossref
Keywords are not submitted to Crossref
ISBN is not exposed in the Crossref JSON
Title/subtitle is not correctly processed by commonmeta-py
Event information (series, location) is not correctly processed by commonmeta-py

I will work on the last two, they seem pretty straightforward. I will tell Crossref to look into exposing the ISBN in the JSON REST API, and more importantly, work with Crossref members to include page numbers in DOI metadata. Not including abstracts in DOI metadata is a known issues, but missing page numbers is new to me. I have seen this before, but thought this info was lost during XML processing.

soon on the command line
That is fantastic.

This is all fantastic! You are doing amazing work here. Always excited when any other human is as dedicated to quality bibtex as I am. :)

I published commonmeta-py 0.7.0 on PyPi. The bibtex for your example DOI – when using the crossref_xml reader because some metadata (e.g. page numbers) are missing in the Crossref JSON – looks like this:
@inproceedings{https://doi.org/10.1145/3448016.3452841,
    author = {Pandey, Prashant and Conway, Alex and Durie, Joe and Bender, Michael A. and Farach-Colton, Martin and Johnson, Rob},
    booktitle = {Proceedings of the 2021 International Conference on Management of Data},
    copyright = {https://www.acm.org/publications/policies/copyright_policy#Background},
    doi = {10.1145/3448016.3452841},
    isbn = {9781450383431},
    location = {Virtual Event China},
    month = jun,
    pages = {1386-1399},
    publisher = {Association for Computing Machinery (ACM)},
    series = {SIGMOD/PODS '21},
    title = {Vector Quotient Filters: Overcoming the Time/Space Trade-Off in Filter Design},
    url = {https://dl.acm.org/doi/10.1145/3448016.3452841},
    urldate = {2021-06-09},
    year = {2021}
}

The only thing missing is abstract and keywords,  but that info is not submitted to Crossref. And some minor formatting differences.


nrf: New API supporting borrowed peripherals

Yet another way... trying to workaround the type inference issues.
This adds the possibility of creating drivers with borrowed peripheral instances.
let p = pac::Peripherals::take().unwrap();
let mut irq = interrupt::take!(SPIM3);

let spim = spim::Spim::new(&mut p.spim3, &mut irq, &mut p.p0_29, &mut p.p0_28, &mut p.p0_30, config);
// use spim...
mem::drop(spim);

// Here we have access to p.spim3, irq, and the pins again!

It's cool:

Type signature is Spim<'_, SPIM3> regardless whether it's owned or borrowed
Spim always holds the zero-sized struct
No weird unergonomic Borrow<'a, T> struct.

I'm playing with this on my nrf-52832. You need the line
+                 $(#[$cfg])?

on line 10 of embassy-extras/src/macros.rs.

Also, I might be wrong but I think you should use pac::Peripherals's taken value for embassy's Peripherals, because it is incorrect to use the raw peripheral and the embassy one at the same time. If the user wants to do something with the raw peripherals, they should use steal and acknowledge the unsafety.

You need the line .. on line 10

Nice catch, added!

you should use pac::Peripherals's taken value for embassy's Peripherals

Yes, I'm aware of this but I'm not sure how to best solve it. Ideally I want to avoid the pac appearing in the public API at all, so we can bump the pac's major version (or switch to something completely different) without bumping embassy-nrf major version (ie the pac should just be an internal implementation detail on how we access registers).
One problem is that PACs intentionally forbid linking multiple major versions at once (precisely so you can't take() the peripherals multiple times), so even if the PAC doesn't appear in the public API bumping it is a breaking change...
The reasoning behind doing our own Peripherals is the PAC's Peripherals is autogenerated from SVDs, which is not ideal:

Some peripherals are really just one. For example SPI0, SPIM0, SPIS0, TWI0, TWIM0, TWIS0 are really a single peripheral, you can only use one of them at a time.
No structs for owning "parts" of a peripheral. I don't want to own P0, I want to own individual pins. Same for ADC, PWM, PPI channels.

Maybe its better if I explain what I mean in code. I mean something like (in the Peripherals macro)
impl Peripherals {
    ///Returns all the peripherals *once*
    #[inline]
    pub fn take() -> Option<Self> {
        cortex_m::interrupt::free(|_| {
            if pac::Peripherals::take().is_some() {
                Some(unsafe { <Self as embassy::util::Steal>::steal() })
            } else {
                None
            }
        })
    }
}

I've done some work on my local copy making nrf gpio match the PeripheralBorrow scheme, which you might as well copy/paste. Let me know if you want me to post it somewhere.

@derekdreery Yes please, that'd be great! You can send a PR to this PR (target branch borrow-v3 instead of master)

I had a look at the UARTE part, but I did not test on real hardware.
The new approach makes the logic much more apparent and the code size improvements are a big win in my eyes.
Still I have few nits for the RX part:

Previously the stop() method exposed a way to abort the reception and get to know the number of received bytes. When using select() we still can stop the transfer by dropping the future. But now there is no way to know how many bytes were received? Unfortunately UARTE does not provide the capability to implement the IdleUart trait.

I think there is a edge case for this specific reception scenario:

tasks_startrx
drop future, tasks_stoprx
endrx -> future dropped
drop uarte, disable uarte -> enters unspecified state (with high current consumption)
rxto outstanding (but not triggered because uarte is disabled)

When canceling a reception we additionally need to wait for the RXTO event before disabling the peripheral.
IIRC that’s how the nrfx libraries handle it and my current measurements showed agreement.
When the reception ends by itself (DMA buffer full) its not required to wait for RXTO.

Thanks for taking a look @timokroeger , very good points.

RX abort is slow, previously we used embassy_extras::low_power_wait_until() to wait until it is over

Yep, I'll bring that back. Requires some care with the new interrupt handling but I think it's doable.

Previously the stop() method exposed a way to abort the reception and get to know the number of received bytes

I removed it because IMO the stop() method on the returned future is not the way to go.

it's extremely unconventional, therefore hard to discover.
It makes it impossible to implement the drivers with async{ }, you have to manually implement a future.
When Rust gets real async traits, the methods will be regular async fns with no way to attach the stop() method either.

I do agree it's a nice functionality to have. An alternative would be adding a .last_read_bytes() -> usize method to Uart which returns how many bytes were read by the last .read() call. Less nice, but plays nice with async{} and the future real async traits. We can make it an extension trait on uart::Read too which is nice.

When canceling a reception we additionally need to wait for the RXTO event before disabling the peripheral.

Oh, that's what RXTO is for :facepalm: . I now understand why your impl was that complex, haha. Will fix.


Edge case with cloning players who leave after being scanned/cloned can spawn Urists

This bug was originally reported by Hardly#1296, and is a distinct issue from #3654, which I believe was fixed by Swept's cloning fix PR.

How to reproduce:

Clone a player.
Have the player being cloned choose to not transfer their soul to their new body.
Have the player being cloned then leave the server.
Kill the cloned body.
Attempt to clone the player who left the server.
The cloner will spawn Urists with no cooldown

The cloner spawning Urists with no cooldown probably indicates a server exception after https://github.com/space-wizards/space-station-14/blob/master/Content.Server/GameObjects/Components/Medical/CloningPodComponent.cs#L119
Assuming the Urist immediately leaves the pod, it is probably also before line 129 (BodyContainer.Insert(mob);)
The problem is, I'm not sure what code here would fail that wouldn't be blocked by other code.
My guess is that GetPlayerProfileAsync fails (in which case this may be partially but not completely solved by #4013 - as it moves that step back to scanning time, and an exception in GetPlayerProfileAsync would simply cause a silent fail-to-scan)


Update the onnx-mlir version

It looks like ONNX-MLIR is now a lot more mature and supports 116 ML models out of 128 Models from the ONNX Zoo, including large models like Bert and GPT. Ref: https://github.com/onnx/onnx-mlir/issues/128.
We should seriously consider upgrading the onnx-mlir version being used with LLTFI.

@abrahamchan I have updated the onnx-mlir version to commit id 9c62e1a4. However, I had to make certain changes in instrumentation passes of the onnx-mlir code to get LLTFI working with it.  We have to decide whether 1) I should keep my changes as a patch and apply the patch to onnx-mlir? Or 2) we fork the onnx-mlir repository to DependableSystemsLab GitHub org and I make changes to the forked version of onnx-mlir.

We added a patch of our changes.


fix fatal error on OSX System update process

without this fix, every update process stops with a fatal error on osx filesystems

Hi @wrongspot, thanks for your PR.
We cannot reproduce your issue and we should not implement this special use case.
If this is still an issue, feel free to open a new PR but with a better list of files to skip.


Trackers not linked to harvest for one day

On August 24, 2019, three bucks were taken, but we only have one of them linked to a logger. There is a note "Trackers collected but no numbers linked to 2 bucks shot in James 3 at end of day."
@amcinturff we COULD go through the 15 tracks and see who had clusters in James 3 at "end of day" and potentially figure it out. Tabling it in case we decide it's worth it?
For now, just excluding this day's tracks.

In metadata, harvest status is now "unknown" so straightforward to remove

E-mailed Alison to ask for locations of harvest for 2019:

I have one more question about the 2019/2020 data. Did you have hunters report their harvest locations on a map with pins as had been done in previous years? And does it exist as a shape file (or at least as a photograph)? If so, I’d be interested in seeing the points for August 24, 2019, specifically (feel free to send them all over and I can filter from there). There is a note that two deer were harvested in James III late in the day but the harvest isn’t linked to particular loggers, and I’m wondering if I might be able to do some detective work to match the loggers if we have a sense of where the deer were harvested and can see who spent a lot of time near those points late in the day.

From Alex:
I have completed my investigation.
Many suspects can be ruled out, as they never went to the area, or were not there at "the end of the day." Frustratingly, none of the loggers were there at what I would consider the "end of the day," with the latest being around 3:30-4pm. So, we proceed with that qualification.
There were two pairs of tracks that remain suspects: 2&11, and 6&13. Both appear to be traveling together and were in the area as close to "the end of the day" as anyone. Both have some activity in the area that is suspicious.
My best guess is that logger 6&13 are the murderers.
• Tracks 2 and 11 are in the area around the same time (3:30), but there isn't obvious clustering, and only 11 appears to have exited a vehicle. We know we should be seeing two different clusters in a pair of hunters, but I don't see that here.
• By contrast, there is a very clear behavioral signature of logger 13 near the kill site: get out, walk, stop, make a tight loop back to the car. We see that at a lot of kills
• The other kill site is right on the road, however, so it's not as obvious. It's hard to distinguish a cluster of points from the frequent back and forth traffic on the road. What's more, there's an obvious viewpoint right near this kill site that every logger seemed to stop at for a bit, so that makes it even trickier. Is the cluster I'm seeing a kill or taking in the view? Is there a minimal cluster since it happened on the road and might have been processed extremely fast? ]
• Still, my best guess is that logger 13 (blue track below) murdered near 39.0318802, -123.079906 (brown star below). If that's true, then their companion, logger 6 (yellow track below) most likely murdered at 39.0283004, -123.0772436 (red star below). I think logger 2&11 were in the area at the same time, but do not appear to be the murderers
• This evidence isn't conclusive, but it is the best fitting based on what we know. Alternative explanations could be: the kill site locations are not accurate, the "end of the day" time is not accurate, we are missing hunter or logger data, Alison is misremembering that the murderers were traveling together. Any of these assumptions being wrong would change things.
• All that said, I think this is the best explanation available, based on what we know, and if nothing else, logger 13 (blue track below) murdering near 39.0318802, -123.079906 (brown star below) seems very likely

I will proceed with 6 and 13.


cli: show file name when failing to open input

pretty sure that ${input} was meant to be in a `` string

Thank you for fixing this 🙏


Remove unused code form TypeReference

PTAL

Codecov Report

Merging #156 (1552a02) into main (ffc15d2) will decrease coverage by 1.43%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #156      +/-   ##
============================================
- Coverage     68.38%   66.95%   -1.44%
+ Complexity     8546     8375     -171
============================================
  Files           416      416
  Lines         45148    45138      -10
  Branches       8990     8959      -31
============================================
- Hits          30875    30220     -655
- Misses        10633    11336     +703
+ Partials       3640     3582      -58

Impacted Files
Coverage Δ

.../main/java/com/alibaba/fastjson/TypeReference.java
79.54% <ø> (-0.46%)
:arrow_down:

...ava/com/alibaba/fastjson2/JSONWriterUTF16JDK8.java
0.00% <0.00%> (-80.77%)
:arrow_down:

...main/java/com/alibaba/fastjson2/util/JDKUtils.java
29.03% <0.00%> (-41.30%)
:arrow_down:

...fastjson2/writer/FieldWriterObjectArrayMethod.java
0.00% <0.00%> (-37.24%)
:arrow_down:

...alibaba/fastjson2/writer/FieldWriterListField.java
12.50% <0.00%> (-27.50%)
:arrow_down:

...va/com/alibaba/fastjson2/reader/ValueConsumer.java
16.66% <0.00%> (-16.67%)
:arrow_down:

...n/java/com/alibaba/fastjson2/util/UnsafeUtils.java
64.15% <0.00%> (-15.10%)
:arrow_down:

...in/java/com/alibaba/fastjson2/JSONReaderASCII.java
71.58% <0.00%> (-9.92%)
:arrow_down:

...ain/java/com/alibaba/fastjson2/JSONWriterUTF8.java
64.33% <0.00%> (-9.69%)
:arrow_down:

...ore/src/main/java/com/alibaba/fastjson2/JSONB.java
80.99% <0.00%> (-6.73%)
:arrow_down:

... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffc15d2...1552a02. Read the comment docs.


AWSWAFSecurityAutomations-LambdaWAFReputationLists rule input does not allow additions due to length constraint

The error "There was an error while saving rule AWSWAFSecurityAutomations-LambdaWAFReputationLists-BPSIVMXJZJP6.
Details: 1 validation error detected: Value 'AWSEvents_AWSWAFSecurityAutomations-LambdaWAFReputationLists-BPSIVMXJZJP6_LambdaWAFReputationListsParserFunction' at 'statementId' failed to satisfy constraint: Member must have length less than or equal to 100." is received when attempting to add add another URL, such as {"url":"https://reputation.alienvault.com/reputation.generic"}
to the lambda functions' Constant JSON text field.
Suggested fix is to have the Cloudformation store the contents of this input in an S3 bucket, then have the lambda function get the json text from S3, which will enable users to add more lists

Got it. Added a task to review this for the next version. Quick question: is this alienvault rep list open to be used? Was thinking to add it in the original template.

Yes.  "When we launched the Open Threat Exchange (OTX) project, one of our goals was creating an open and free threat database and exchange system. We want it to be used by as many users as possible using a wide range of technologies." per https://www.alienvault.com/blogs/labs-research/feeding-alienvaults-open-threat-exchange-otx-threat-information-to-arcsight

Fixed in v2.1

@stevemorad what was the fix? Still seeing this issue...

I'm also experiencing this issue


Do not ask about reboot if --force and no --no-reboot

When "--force" flag and no "--no-reboot" flag present then do not ask about reboot confirmation.
Otherwise hack like yes | ros install --force ... is still needed.
Such behaviour is necessary to install system from scripts over ssh. I use command like this (from Ansible):
ssh rancherhost sudo ros install --force --cloud-config RancherOS.yml --device /dev/sda
I haven't compiled a new ISO with the patch nor tested it yet but this one line change should do the trick.

LGTM
Thanks!


[Code] Allow registration of other languages

Is your feature request related to a problem? Please describe.
Right now, there seem to be code highlighting for the  component only for javascript, json, jsx and typescript. I'm using it as a preview component for the Studio, and I pass in the selected language in parameter (for example, "tsx" or "sh") but I can't get highlighting to work, even if I try registerLanguage myself.
Describe the solution you'd like
It would be nice to be able to support other languages
Describe alternatives you've considered
This is a shortened version of what I'm trying, just to illustrate the problem, but it doesn't work:
import { Stack, Code } from "@sanity/ui";
import { registerLanguage } from "react-refractor";
import tsx from "refractor/lang/tsx";

registerLanguage(tsx);

const Preview = (props) => {
  return (
    <Stack>
      {props.renderDefault(props)}
      {props.code}
    </Stack>
  );
};

const schema = defineType({
  // ...
  preview: {
    select: {
      code: "code",
      language: "language",
    },
  },
  components: {
    preview: Preview,
  },
});

Additional context
This is what the editor looks like. I've logged the props and the "language" is correctly set to "tsx", but there's no highlight.

It might be worth noting that I have both refractor and react-refractor listed as dependencies because I use it differently in my frontend.

In case you want the actual, specific use-case I'm trying to work with, here it is:
// code-group.ts
import { CodeIcon } from "@sanity/icons";
import { defineArrayMember, defineField, defineType } from "sanity";
import CodeGroupPreview from "../../desk/components/code-group-preview/code-group-preview";

export default defineType({
  type: "object",
  name: "codeGroup",
  title: "Code Group",
  icon: CodeIcon,
  fields: [
    defineField({
      type: "array",
      name: "snippets",
      of: [
        defineArrayMember({
          type: "code",
          options: {
            language: "text",
            withFilename: true,
            languageAlternatives: [
              /**
               * If you add more languages, you'll need to:
               * 1. Add the language below
               * 2. Update the post-body-code.tsx to register the language
               */
              { title: "TypeScript", value: "typescript" },
              { title: "TSX", value: "tsx" },
              { title: "Shell", value: "sh" },
              { title: "JSON", value: "json" },
              { title: "Text", value: "text" },
            ],
          },
        }),
      ],
    }),
  ],
  preview: {
    select: {
      snippets: "snippets",
    },
  },
  components: {
    preview: CodeGroupPreview,
  },
});

// code-group-preview.tsx
"use client";
import {
  Button,
  Code,
  Container,
  Menu,
  MenuButton,
  MenuItem,
  Stack,
} from "@sanity/ui";
import { useEffect, useState } from "react";
import { registerLanguage } from "react-refractor";
import tsx from "refractor/lang/tsx";
import type { PreviewProps } from "sanity";
import type { CodeGroup } from "../../../sanity.types";

registerLanguage(tsx);

export type CodeGroupPreviewProps = PreviewProps & {
  snippets?: CodeGroup["snippets"];
};

const CodeGroupPreview = ({
  snippets = [],
  ...props
}: CodeGroupPreviewProps) => {
  const [activeTab, setActiveTab] = useState(0);
  const activeSnippet = snippets[activeTab];

  useEffect(() => {
    if (activeSnippet) return;
    setActiveTab(0);
  }, [activeSnippet]);

  if (!activeSnippet) return null;
  return (
    <Stack space={3}>
      {props.renderDefault({
        ...props,
        title: `Code Group | ${snippets.length} ${snippets.length === 1 ? "Snippet" : "Snippets"}`,
        layout: "block",
      })}
      <MenuButton
        button={
          <Button text={activeSnippet.filename || `Snippet ${activeTab}`} />
        }
        id="code-group-preview-menu"
        menu={
          <Menu>
            {snippets.map((snippet, index) => (
              <MenuItem
                key={index}
                onClick={() => setActiveTab(index)}
                padding={3}
                text={snippet.filename || `Snippet ${index}`}
              />
            ))}
          </Menu>
        }
        popover={{ portal: true }}
      />
      <Container padding={3} overflow="auto">
        {activeSnippet.code}
      </Container>
    </Stack>
  );
};

export default CodeGroupPreview;


Bump to 0.2.18

@alexcrichton: no appropriate reviewer found, use r? to override

@bors: r+

:pushpin: Commit 1063e0c has been approved by alexcrichton

:hourglass: Testing commit 1063e0c with merge ea4f4ed...

:broken_heart: Test failed - status-travis

@bors: r+

:pushpin: Commit 5aae2bb has been approved by alexcrichton

:hourglass: Testing commit 5aae2bb with merge c2a01cd...

:broken_heart: Test failed - status-travis

@bors: r+

:pushpin: Commit 93dbca0 has been approved by alexcrichton

:hourglass: Testing commit 93dbca0 with merge ab9a011...

:sunny: Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing ab9a0112c74cf572105e17a54c4982cd66e404f7 to master...


iOS 12.x support has been dropped in Detox 18.0

Hello,
Please note that iOS 12.x support will soon be dropped in Detox 18. This does not require that you drop support for iOS 12 in your apps, just that tests will no longer work on iOS 12 and below. Please make sure your tests are running on iOS 13 or above.
Thanks

Hey @LeoNatan, out of curiosity, is the intention of detox to support the latest 2 versions of each OS?
The reason I ask is my usecase of Detox and E2E as a whole is to test older devices.

I am no longer involved with the project. When I was, there was no rule set in place when to deprecate existing OSes, only when they became too burdensome to support. With 18, a legacy websocket implementation was removed, requiring iOS 13 and above. In the future, @d4vidi and @alon-ha will make the decision when to drop support.

Thanks @LeoNatan. I believe we shall continue following the same guideline as before. Our capacity to support things is limited, and so we have to contantly consider think of the tradeoffs.


Favorite farming tracker tap

**Is your feature request related to a problem?
Not fast to find my farming patches because use a 10/60+ Farming patches only
Describe the solution you'd like
A tap that we can use our favorite farming patched to show up only and ignore other
Describe alternatives you've considered
1- favorate farming tap
2- enable/disable farming patches
3- showing farming patches if it used only
Additional context
N/A

Duplicate of #8893


Do i need individual rules files for each relation?

We need to specify the Relation in the rules.py, but it accepts only 1 relation at a time, so does that mean I need to create separate rules file for each relation?
And if i run the rule_runner script, which relation would it pick up?

I'm afraid that there's no support for such a thing right now.
It shouldn't be hard to refactor the code for making this possible, so if
you think you can do this contribution, let me know and I can guide you.
On the other hand, an ugly and not very elegant way of overcoming to this
for you may be:

create current rules.py file
create files rules_A.py rules_B.py, .... rules_N.py

Later, when you want to work with relation A

create a symlink named "rules.py" pointing to rules_A.py
use bin/iepy_rules_runner.py as usual

On Thu, Dec 8, 2016 at 8:01 AM, Sindhu Bairavi<EMAIL_ADDRESS>wrote:

We need to specify the Relation in the rules.py, but it accepts only 1
relation at a time, so does that mean I need to create separate rules file
for each relation?
And if i run the rule_runner script, which relation would it pick up?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/machinalis/iepy/issues/117, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAd04_Bom3ch_G2EyJWEHfHOsaDe_Wmvks5rF-OPgaJpZM4LHsV7
.

--
Javier Mansilla - Technical Leader
www.machinalis.com

I handled this problem, adding an extra argument to the rule decorator called "relation_name", so each rule have a relation associated with (this was the most intuitive way to solve it for me).
So that was the only change i did to the framework, the rest of the work was on my own instance, defining an attribute RELATIONS in the file rules.py as a list of relation names (instead of the RELATION attribute), and adapting the bin/iepy_rules_runner.py to handle a list of relations names.
For example:
Calling the RuleBasedCore inside of a loop iterating over the relations names, for each relation and its related rules.
I'm still working on my project but until now, seems to work fine.

Awesome Ariel
Do you think it's possible to make a pull request (against develop branch) with such changes?
Would consist on the changes you mentioned on the "framework" plus also the changes you did on iepy_rules_runner.py (the repo file for it is here https://github.com/machinalis/iepy/blob/develop/iepy/instantiation/iepy_rules_runner.py)