Configuration - Could not retrieve or read configuration (ConfigurationError) - Back again.

Alex,
I'm back with my problem from a few days ago.   Container has been running OK.  I had problems before, Issue 355, but fixed by wiping and reinstalling if you remember.
At 0130GMT today the system stopped working again with the same error.
{"type":"log","timestamp":"2023-02-04T01:30:15Z","message":"Configuration - Could not retrieve or read configuration (ConfigurationError)","level":"error"}
Now nothing changed on the container and it has been using the same one for 4 days.   Interestingly 4 days ago I had several hours of the same message at around 0700GMT which fixed itself and until I looked through the logs today I hadn't noticed.
At 0130GMT I was fast asleep and have not made any changes to the system.  Last time I put it down to something I had done and there was a bit of a mix up with updates.   I hadn't been doing them and I thought I was.
So I have a few questions and hopefully it can lead to a fix for me.
What error generates the above message?  Unable to read, file doesn't exist, certain parameters not there?
Where is the configuration file stored?   I have config/.env and that is w:rwe and still accessible.
When does it read the file?  It looks like during every time speedtest is queued.
In the code after reading the config file does the error handling move on?   If the next command errors will it use this error instead of one of its own?
Grasping at straws here and as it isn't just me it seems a particularly strange error.
What can I do to help diagnose this?

You're getting this error in your results right?

When the test is ran, either through the timer or by clicking the run now button it fails and the following is down as the error when you click on the red icon in the GUI.
{"type":"log","timestamp":"2023-02-04T01:30:15Z","message":"Configuration - Could not retrieve or read configuration (ConfigurationError)","level":"error"}
This is the same error I got last time and then I fixed it by deleting everything and reloading.   This time that isn't working.  I'm now convinced it is something on my system triggering an obscure bug, not something unique to me because others are getting it but definitely present on my system.
I've reloaded the brand new .env from Github, Loaded the new DC and started it up as new.  Still no joy.  See attachments.
It can clearly see and read the .env file as it filled in the App Key environment variable.  So it is clearly in the right place and RW.   It is clearly something simple but finding it will be an issue.   How can I set it up to step through the code to find exactly where it goes wrong?

docker-compose.txt
env.txt

Having the same issue.  Just started up the container for the first time.

So this error occurs when the speedtest-cli can't reach the server it's trying to test against. Try setting another server under General settings (if you have one set) and if you don't have one set try specifying one.

I don't have any options in the General list at all.

Thanks I'll look into this, might be a bug on the initial installs.

I don't have any items in my drop down list to choose as a target.  However it was getting some to target originally so they must have come from somewhere.   Is there an environment setting you can use if there is none on the list and you can't type one in or alternatively a db setting?  Where does it get these from?

Perhaps a more relevant error would be better as well.  I spent hours playing with the configuration files.

Just wanted to confirm that I have this exact same issue. [

Same error here too. And the previous deprecated speed test tracker I was using, stopped passing any tests around 4am today.

@kode54 Thank you - you made me realize that, while I made a network for speedtest to hit the internet, I forgot to add it to the container.  This is working for me now.

@kode54.    I tried editing the file /etc/resolv.conf but it wouldn't let me as it was in use.  I stopped the container and again no joy.  How did you replace yours?   It was pointing to <IP_ADDRESS> for some reason and that isn't anything like my DNS servers so have no idea where that came from so I tried to edit by copying out and got this;.
So in container resolv.conf
nameserver <IP_ADDRESS>
options ndots:0
docker cp speedtest:/etc/resolv.conf .
edited resolv.conf to point to my DNS server
docker cp resolv.conf speedtest:/etc/resolv.conf
Error response from daemon: Error processing tar file(exit status 1): unlinkat /etc/resolv.conf: device or resource busy
Any ideas?

I didn't replace the resolv.conf inside the container. I had originally changed the one on the host machine. Apparently my actual problem was with DNS services on my router.

Mmmmmmm.  That can't be my problem or it would be intermittent as my DNS server is fine.  I may get occasional drop outs when it is heavily used but certainly not continuously for weeks.
Alex,
Still not working.  Even after rebuilds.  Is there anything I can do to help diagnose this?

LOL.  You aren't going to believe this.   I installed a new LXD container and I needed to reboot the system.  It started working and has been doing so for a couple of hours now.  I'll keep my eye on it but it is clearly going to be frustrating to debug.

and stopped again 0800 this morning.   Something very strange here.  Checked logs on host.  Nothing strange happened at that time.  Why just this app as well?

Happened with the unmaintained app this one replaced, too. I swapped it for this one because I thought it was the app, not Docker or the Speedtest-CLI app.

Same - 0700 and 0800 (EST) have failed with the configuration error.

Sorry for the delay, had to catch up on client work.
Going to look into this later this morning after I get some ☕ in the system and a feature branch merged I'm currently working on.

Btw... this error message is from the Speedtest CLI failing.

Alex,
Any progress here.  It's still not pulling any data down.  Is there anything that I can help you with for testing?

I have the same issue.
Raspberry Pi on docker.

v0.11.3 has been released with dependency updates which will also rebuild the Ookla CLI, can someone let me know if they're still getting this error?

So far so good, though the last error I had was 27 hours ago.

@Bag72 still having problems? If not can you close the issue once you've verified it?

I continue to have issues, using latest version in UnRaid. Maybe it is a settings thing for me though, should I have the network to bridge or host?

I'll spin it up on my unraid machine later this week, rebuilding some disks atm

@alexjustesen Just noticed your email.    Thanks for looking at this.    I've just spun up Docker and ran the application.   It worked OK.   I'll run it for a few days and see if there are any further issues.   It frequently runs and is OK before it fails again.  First run 1800GMT 8-Mar.   It runs every 30 mins.

@alexjustesen   Well that didn't last long.   It performed OK till 2100GMT where it failed again with exactly the same error as before.   It has failed since then.  I took down the docker and reset it but still no joy.  It is now as before.

Are you specifying a server?

No.  It has never allowed me to.
I go to General.....Speedtest Settings and then when I select the drop down option in Speedtest server ID  it is blank.  It always has been as well.   Therefore I have always allowed it to select it's own.  How can I force a server?
At 1000GMT it restarted working.  At this point it has had 2 successful tests.

@Bag72 #458 incoming which will show a list of local servers (to you) by default in the search box. The error your getting is the Speedtest CLI not being able to run a test against the server it's try to so it's failing.
Think you found some janky server in the wild.

Still not working. My server is running behind CGNAT, could that present any issues?

Still not working. My server is running behind CGNAT, could that present any issues?

Maybe? I don't have any experience with carrier grade NAT (never been an issue for me). You can always verify the container can reach Ookla's speedtest service by using curl to get a list of servers.
curl https://www.speedtest.net/api/js/servers?limit=1

This should return a json object with one record if it works correctly.

Just tested, able to reach Ookla's service. Plus I can use the Unraid CLI tool for Ookla speedtest.

@Bag72 and @MarcusSi2023 are you both running this on Unraid?

I have a QNAP NAS.   The container is set up in bridge mode which means the NAS IP is the container IP and I use the port to get in to the container.
I've just gone through the data from all the previous tests and it appears that there is about 4 or 5 servers that show when it is working, and they are working now.  Perhaps I have an issue with my location that causes timeouts?
However, as you know I can't set preferred servers via the GUI.  Is there environment settings I can set instead?  Having some servers that are an issue would fit the inconsistency of the errors especially as I don't define any.
Perhaps if the speedcheck failed then if it tried a different server straight away and logged the failures we could keep track of the good servers and remove the bad ones.   I'm UK based perhaps that makes a difference.
@MarcusSi2023 CGNAT does cause issues for some We don't have it here in the UK but there is a good YT article on it under ScottiByte.  He does some obscure articles and CGNAT is one where he explains issues and workarounds.  It may help it may not.  No harm in looking.

OK. Had some time to play yesterdayday so found out how to input the servers.  Not quite as I expected but I managed to get in the few regular successful ones.
Interestingly it has worked since then, 9-Mar-0130GMT, but today it uses servers I've not seen before so it doesn't stick to the ones I listed.   Maybe something was corrupt and entering some servers reset it.  Fingers crossed.

After some successful speedtests, the error is now also displayed...
Basis: Raspian OS @Pi4 and Docker (rootless) managed via Portainer.
curl https://www.speedtest.net/api/js/servers?limit=1 is successful from container:

[{"url":"http://speedtest01.dns-net.de:8080/speedtest/upload.php","lat":"52.5167","lon":"13. 3833", "distance":0, "name": "Berlin", "country": "Germany", "cc": "DE", "sponsor": "DNS:NET Internet Service GmbH", "id": "20507", "preferred":0, "https_functional":1, "host": "speedtest01.dns-net.de.prod.hosts.ooklaserver.net:8080"}]

How can I start the speedtest-cli manually from the container? Command is not found...

How can I start the speedtest-cli manually from the container? Command is not found...

If you wanted to run a speedtest manually from the terminal you can run speedtest, additional basic flags are --server-id=12345 to specify a server and --output=json if you don't want the default human-readable format.
For a list of all commands and flags run speedtest --help.

Alright, I was able to do a manual test:

root@71d1c8162c09:/var/www/html# speedtest
Retrieving speedtest.net configuration...
Testing from Vodafone Germany Cable (xx.xx.xxx.xx)...
Retrieving speedtest.net server list...
Selecting best server based on ping...
Hosted by IWB Telekom (Basel) [215.13 km]: 155.119 ms
Testing download speed................................................................................
Download: 82.17 Mbit/s
Testing upload speed......................................................................................................
Upload: 3.27 Mbit/s

After recreating the container (with keeping the /config volume) I'm still not able to do any (also not manually) test. I also get no "failed result" in the overview. The only response is the popup that the test is queued.
Btw... these terrible bandwidth values are the reason that I like to see this project.

I found out how to input the servers, I think.  Not quite as I expected but I managed to get in the few regular successful ones.
It has now been running since 9-Mar-0130GMT successfully.
Interestingly although it has worked since then it uses servers I've not seen before so it doesn't stick to the ones I input.   Maybe something was corrupt and entering some servers reset it.  Fingers crossed.   I have deleted the container and recreated it at 1345GMT today.   I connected up OK at the last test.
I'll leave it running now and let you know how it goes.

Well, that didn't work well.   Rebuilt and restart worked the once while I was watching.  Failed every time after that and what was worse is that I could get into the config section, server error 500, to enter a server id.   I remember the server 500 error.  Did you adjust it in all relevant areas?
Is there a way to enter a server id, or set, as a config variable in docker compose?
Seems to me that the docker system is not initialising for some reason in my setup.  Perhaps it defaults to one that is flaky and thus is intermittent.

In this discussion I put how to reset the app database and/or update the settings table. lmk if that helps
https://github.com/alexjustesen/speedtest-tracker/discussions/493

Short update: As mentioned I used a new container with new .sqlite db / config without success.
After updating to image v0.11.11  and recreating the container the speedtest tracking works since saturday, 18.3.23. I only changed the cronjob in settings, which is functional (with one 1h shift, but that's another topic and I'm using UTC instead a proper TZ - tried to reduce multiple changes).
I will observe and report here.

Since my last post on the 21st of March and using v0.11.11, I have not had any 'ConfigurationError' errors. I also experienced a lost connection last weekend that was logged correctly.


Documented version doesn't reflect software version

While the release is called version 1.0, the software version seems to be '<IP_ADDRESS>'. This is a bit confusing.
https://github.com/ndexbio/ndex2-client/blob/376aab30e3e6d1d70f1e14f782bfce260a325631/setup.py#L26
https://github.com/ndexbio/ndex2-client/blob/376aab30e3e6d1d70f1e14f782bfce260a325631/docs/conf.py#L64
Additionally, neither of these versioning schemes adheres to semantic versioning. That's okay, but adhering to community standards makes it easier to navigate projects.

Documentation is being updated with the release of v2.0.0


Edit metrics queries and rearrange structure

Signed-off-by: Matan Schatzman<EMAIL_ADDRESS>
📝 Description
Edit metrics queries to fit 4.12 and rearrange the structure to more shareable data
🎥 Demo

Please add a video or an image of the behavior/changes

/lgtm


do not use v.windowPeriod in the derivative unit param

right now, clicking on derivative or non negative derivative in the UI inserts
 |> derivative(unit: v.windowPeriod, nonNegative: false)

but the unit isn't a window period.
most likely, they want something like this:
  |> aggregateWindow(every: v.windowPeriod, fn: max)
  |> derivative(unit: 1s, nonNegative: false)

We may need to update the label in the UI but i'm not sure.

Hard code derivative to 1 second in the UI.  And also the nonNegative derivative as well.

fixed in https://github.com/influxdata/influxdb/pull/19776, but it needs to get added to the UI repo


Fix internationalization issues with cupertinoTextSelectionControls

Fix internationalization issues with cupertinoTextSelectionControls,
cupertino and material are on the same layer, I think they can call each other.

Cupertino shouldn't depend on the Material package. We'll need a separate translation mechanism for Cupertino (https://github.com/flutter/flutter/issues/13452). For now, you can make changes to CupertinoLocalization and supply your own translation. Official translations will be coming in the next quarter.

@songfei Are you interested in implementing the fix using CupertinoLocalization? (It's fine if you don't want to or don't have time, we'll get to it in due course!)

Merged in the fix in a different PR so I'm closing this!

Thanks @jslavitz


Wayland on MS Windows

Text removed from x11docker Wiki, but stored here:
Wayland on MS Windows
It is possible to run Wayland compositor weston on MS Windows with x11docker.

Runs sucessfully on WSL with Debian. Fails on WSL with (default) Ubuntu 16.04.
Install weston and dbus in Debian-WSL. QT5 applications also need qtwayland.
Needs X server VcXsrv installed on Windows.

Wayland compositors can run nested within an X server. To accomplish this, x11docker with an empty X server is started first, and its environment variables are stored and provided to run x11docker with Wayland.

Example: xfce4-terminal in docker container on Wayland in VcXsrv on Windows:

read xenv < <(x11docker --showenv)
env $xenv x11docker --wayland x11docker/xfce xfce4-terminal

With runx (#165) it is quite easy to get a Wayland environment on MS Windows:
XDG_RUNTIME_DIR=/tmp runx -- weston


Parameter lookup store

Description
When implementing complex aggregation functions, we often need to use parameters. At the moment a way to upload parameter data - is to upload them into a data store, but then it has to be joined with the base store somehow, otherwise it is not visible.
Please advise regarding the possibility to access stores which are not connected with the base store.
Examples:

In this notebook I'm creating a field "Experiment" to connect with the critical values table - which is an ugly construction: see cell 27: https://github.com/atoti/notebooks/blob/statistics/statistics/drug-efficacy/main.ipynb

In the finch Accelerators, see data model - there're always stores that are not connected with the risk data, and utilities allowing to lookup values based on conditions: https://support.activeviam.com/confluence/display/KB/SIMM+Data+Model

Hello! You should be able to do this using a parameter hierarchy (see doc). This allows you to create a single level hierarchy with a given set of members, which would be your t-critical values in this use case.

Hi @Skyscimitar thank you for this advice, I tried it out - having a hierarchy with critical values as members - however there seems to be now way to lookup a critical value and compare it with a measure in the cube? Is there a trick I don't know?
I need a measure which will lookup a critical value having the index (degrees of freedom) equal to contributors count. Then I need to compare a measure "t-statistic" with a "critical value"

cube.create_parameter_hierarchy(
    "Critical Values", list([t.ppf(0.95, d) for d in range(1, df.shape[0] + 1)]), index_measure="Degrees of Freedom"
)

I'm closing this ticket as I found an alternative solution and I'm not blocked.
I might need to reopen when return to the SBM use case.


[nginx-ingress-controller] update nginx-slim

The nginx ingress controller currently pulls nginx-slim:0.9 (nginx 1.11.3) while nginx-slim:0.11 (nginx 1.11.6) is current. I suggest that nginx-slim is first updated to build nginx 1.11.8 (nginx-slim:0.12) before the ingress controller is updated, see https://github.com/kubernetes/contrib/issues/2283.

@andrenarchy already open :) https://github.com/kubernetes/ingress/pull/99

@andrenarchy the development of ingress is now located in https://github.com/kubernetes/ingress

ah, will it be removed from this repo then? could be confusing otherwise...

@andrenarchy yes after the first release from the new repo

Thank you! Is there a rough estimate about when this will be released?


[ALLUXIO-3258] Ensure that UFS stream is closed during journal backup

https://alluxio.atlassian.net/browse/ALLUXIO-3258
This should be cherry-picked to branch-1.8 after

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/20713/
Test PASSed.

The success path >.<


Socket class and UDP?

Hey there!
I want to add a Art-Net class using the allready existing Socket class.
My porblem:
You call the createSocket function with a void parameter, but as far as I can see, the function createSocket supports the user datagram protocol. There is currently no way to create a UDP socket, right?
For me, it's looks like there is a parameter missing in the Socket::connect(struct in_addr address, uint16_t port) function...
Maybe, there is an other way to create an UDP socket, but I didn't found it.

There was an other way...


fix GEARPUMP-182 Correct references required for source release in LI…

…CENSE file

[Current coverage][cc-pull] is 70.35%
[][cc-pull]

No coverage report found for master at 08105d5.

Powered by Codecov. Last updated by [08105d5...0ee6ef0][cc-compare]
[cc-base-branch]: https://codecov.io/gh/apache/incubator-gearpump/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/apache/incubator-gearpump/compare/08105d5604b1b77f0de7f0fa7571a495be4cfeb9...0ee6ef0231a52f24f4e990f38e203b74683aac5c?src=pr
[cc-pull]: https://codecov.io/gh/apache/incubator-gearpump/pull/63?src=pr

＋1


[XLA:CPU]  Moving oneDNN threadpool wrapper to tsl

This PR moves the oneDNN threadpool wrapper code under tsl, and uses tsl namesapce so it can also be called from XLA code.
Changes include

Removed dependency on reading an TF environment flag for using calling thread. The call  for reading the flag  (ThreadPoolUseCallerThread()) is removed and the env value is now passed into the constructor from TensorFlow.
Pointer to the Eigen threadpool is directly passed to the constructor instead of getting it from OptKernelContext.
Some additional changes for clarity and using oneDNN instead of mkl in variables and filenames.

Thank you very much for the PR, @agramesh1! The overall PR looks good to me. I have two minor comments.

@penpornk I made the changes. Please take a look at it.


Merge clang/swift modules into one direct_module in SwiftInfo for a framework

What changed:
Rework of _get_merged_swift_info by bubble up the creation of clang module to _apple_framework_packaging_impl level, where it determine how to populate the clang module based on VFS feature on/off.
Remove the need to pass virtualize_frameworks flag to the private method _get_merged_swift_info
Why this change
add fail(swift_info.direct_modules) after creation of it at the end of the packging impl method when running bazel build //tests/ios/frameworks/testonly/... --config=ios --config=vfs, you get
[
struct(
clang = struct(compilation_context = <unknown object com.google.devtools.build.lib.rules.cpp.CcCompilationContext>, module_map = None, precompiled_module = None), compilation_context = None, is_system = False, name = "SwiftLibrary",
swift = None),

 struct(
 clang = None, compilation_context = None, is_system = False, name = "SwiftLibrary",
 swift = struct(ast_files = (), defines = (), indexstore = None, plugins = [], private_swiftinterface = None, swiftdoc = <generated file tests/ios/frameworks/testonly/SwiftLibrary.swiftdoc>, swiftinterface = None, swiftmodule = <generated file tests/ios/frameworks/testonly/SwiftLibrary.swiftmodule>, swiftsourceinfo = None, symbol_graph = None))
]

with the current impl in master branch. Note that for the same module SwiftLibrary, there are two structs representing it, one has clang and no swift, and one has swift and nothing inside clang.
So this PR effectively merge two, but the clang module generation differ based on VFS turn on or not:
with VFS on:
[struct(
    clang = struct(compilation_context = <unknown object com.google.devtools.build.lib.rules.cpp.CcCompilationContext>, module_map = None, precompiled_module = None), compilation_context = None, is_system = False, name = "SwiftLibrary", swift = None), struct(clang = None, compilation_context = None, is_system = False, name = "SwiftLibrary",

   swift = struct(ast_files = (), defines = (), indexstore = None, plugins = [], private_swiftinterface = None, swiftdoc = <generated file tests/ios/frameworks/testonly/SwiftLibrary.swiftdoc>, swiftinterface = None, swiftmodule = <generated file tests/ios/frameworks/testonly/SwiftLibrary.swiftmodule>, swiftsourceinfo = None, symbol_graph = None))
]

with VFS off:
[struct(

clang = struct(compilation_context = <unknown object com.google.devtools.build.lib.rules.cpp.CcCompilationContext>, module_map = <generated file tests/ios/frameworks/testonly/SwiftLibrary/SwiftLibrary.framework/Modules/module.modulemap>, precompiled_module = None), compilation_context = None, is_system = False, name = "SwiftLibrary",

swift = struct(ast_files = (), defines = (), indexstore = None, plugins = [], private_swiftinterface = None, swiftdoc = <generated file tests/ios/frameworks/testonly/SwiftLibrary/SwiftLibrary.framework/Modules/SwiftLibrary.swiftmodule/arm64.swiftdoc>, swiftinterface = None, swiftmodule = <generated file tests/ios/frameworks/testonly/SwiftLibrary/SwiftLibrary.framework/Modules/SwiftLibrary.swiftmodule/arm64.swiftmodule>, swiftsourceinfo = None, symbol_graph = None))
]

This way we now have one direct_module instead of two representing the same SwiftLIbrary module. This is important when trying to collect providers for docc_archive rule on rules_apple side as otherwise we face in dep attribute of docc_archive rule <some_target_docc>: '<some_target>' does not have mandatory providers: 'DocCBundleInfo' or 'DocCSymbolGraphsInfo'. error.
Tests done

tested with downstream big repo's full CI job (which has VFS on + bazel version 7.2.0)
CI job itself being green

@luispadron good catch i can repro on my side as well. Let me try to see how easy to fix it

the error only happens with latest rule but latest rule already failed on docc_archive rule, so will. address it in a sep. PR


feat: add print query to the website

This PR adds print query to the website and show a minimum example of using pagebreak feature.
The no-print class hide the element on print, and the pagebreak add new page before the related div.
Here is the first issue about this: https://github.com/microsoft/TypeScript-Website/issues/3204
This PR improve printing a webpage and hide the unnecessary details here is an example:

Before
After

Page breaks should be added and tested manually which requires a lot of work that I decided to do only if this approach were approved.

@microsoft-github-policy-service agree

@jakebailey hey, is there anything I am missing in this pr? I would love to get your thoughts about it

It's not clear to me how this scales; surely other pages would need this? These are explicit page breaks; how would we keep them in the right place and not forget some or add some where they aren't needed?
It just feels like there should be a better solution to this problem than manually breaking pages.

Thanks for the answer. If you want, we can split this PR into two different PRs, one to fix the headers that hide the text behind it and the other to discuss the page breaks,
The main issue here is that we have extra pages and hidden texts because of the header and footers that are available on the website.
As for scaling I just did a double check and found another property that we can use for the code, I will check it and ping you.

For future reference I need to check:
https://tympanus.net/codrops/css_reference/break-inside/
https://developer.mozilla.org/en-US/docs/Web/CSS/break-inside
https://dev.to/amruthpillai/avoiding-awkward-element-breaks-in-print-html-5goe

@jakebailey Thanks for your suggestion, we have a better and cleaner code now.
The code I wrote avoids the breaks for code blocks and works well.

@jakebailey is there anything I need to do for this?

@jakebailey hey, it seems the checks has passed, is there anything I should do from my side?


Rocky Linux Compatibility

I am interested in installing triton on Rocky Linux 8.8 but the README says that it is compatible only with Ubuntu 22.04. Is installation possible on other Linux distributions?
Thanks!

We have focused on Ubuntu but is worth to give it a try.

Ok. Which installation method would be the best for installation on a different Linux distribution? I see that it can be installed from source or built with a custom LLVM.

The installation method is documented here: https://github.com/intel/intel-xpu-backend-for-triton/blob/spirv-target/docs/build_from_source.md

Ok. Which installation method would be the best for installation on a different Linux distribution? I see that it can be installed from source or built with a custom LLVM.

We are working on conda environment that can be used to build and run Triton. Ideally it will be possible to use it with any Linux distribution where conda is supported.


Do not ignore binds for closed cursors.

Currently a report can product this:
select ... from histgrm$ where obj#=20 and intcol#=3 and row#=0 order by bucket
select ... from histgrm$ where obj#=:1 and intcol#=:2 and row#=:3 order by bucket
select ... from histgrm$ where obj#=:1 and intcol#=:2 and row#=:3 order by bucket

This is caused by the cursor being closed, but cached and reused from cache without a new parse. The program should not now ignore closed cursors unless the close type is 0.

ParseCLOSE() now takes note of the close type. If zero, then this is a hard close and this fact is displayed (unless in --quiet mode) for the user, and in the debug file in --verbose mode.
ParseBINDS() no longer bales out early if a set of binds is found for a closed & cached cursor. This is necessary as a cursor EXEC'd from cache will not have had a PARSE to 'open' it.

Commit 0de2e6e resolved this issue.


get_neighbor_cell_ngrams with "absolute" parameter

Is your feature request related to a problem? Please describe.
It is hard to access a heading of a sub-table in a HTML where all sub-tables are in one <table> tag via a labeling function. get_col_ngrams can return the correct ngrams but without directions or distance. get_neighbor_cell_ngrams can return the direction, but does not consider columns which span multiple such as a heading to be neighboring.
Describe the solution you'd like
I checked the code and adding an absolute flag to the get_neighbor_cell_ngrams function which is then passed to the function calls for row/col difference
row_diff = min_row_diff(sentence, root_cell, absolute=absolute)
col_diff = min_col_diff(sentence, root_cell, absolute=absolute)

could solve that problem. Instead of the False boolean default as it is currently.
Describe alternatives you've considered
Alternatively, I am quite often in need to access the table information of an ngram (e.g. which row/col is the sentence). The functions could provide an option to return the sentences instead of the ngrams. As far as I know I have not seen a way to get from the ngram back to the sentence(?).
Additional context
The example HTML in case needed for reproduction:
1_DJ Index 4-1 Peak.zip
Example with an image: Access the heading "MID COLUMBIA" from the cell with the value $235.33. This is needed to know in which table the value is, as all this "sub-tables" are in one HTML table.

This looks like a very useful feature.
Can you make a PR for this so other users can benefit from this functionality?
Thanks for pointing out this issue.
-Sen

In order to not break the existing logic for directions, I decided against the absolute argument and instead fixed it in the min_range_diff.


Destroyed walls appear as an intact wall on the map

Fixed. Changes will be pushed to binaries when milestone is complete.


Italian Radio on app

one of the most famous italian radio, its smartphone app doesn't work if you don't whitelist:
scripts.deejay.it

@davidebonavita Thanks for reporting, can you provide more info on which blocklists blocks scripts.deejay.it?

I don't use it in Italy, but I can tell you that the host you report does not exist. If you do an online test through a tracker, you can verify for yourself that this domain is not working.
So it would be useless to whitelist it.
You can check here: Host Test

I think the correct domain is scripts.kataweb.it
Radio streaming on deejay.it doesn't work if you don't whitelist it


Feat/infra tests

Codecov Report

Merging #123 into master will decrease coverage by 0.42%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #123      +/-   ##
==========================================
- Coverage   26.27%   25.85%   -0.43%
==========================================
  Files          90       93       +3
  Lines        2310     2348      +38
  Branches      298      302       +4
==========================================
  Hits          607      607
- Misses       1695     1733      +38
  Partials        8        8

Flag
Coverage Δ

#unittests
25.85% <0%> (-0.43%)
:arrow_down:

Impacted Files
Coverage Δ

src/WebTty.Application/PtyMessageHandler.cs
0% <ø> (ø)
:arrow_up:

src/WebTty/Startup.cs
0% <ø> (ø)
:arrow_up:

...ructure/MessagingEndpointRouteBuilderExtensions.cs
0% <ø> (ø)

src/WebTty.Application/PtyEndpointExtensions.cs
0% <ø> (ø)
:arrow_up:

...c/WebTty.Infrastructure/Protocol/BinaryProtocol.cs
0% <ø> (ø)
:arrow_up:

.../WebTty.Infrastructure/Core/WebSocketExtensions.cs
0% <ø> (ø)

...ty.Infrastructure/Transport/WebSocketsTransport.cs
0% <ø> (ø)
:arrow_up:

...c/WebTty.Infrastructure/Core/MemoryBufferWriter.cs
0% <ø> (ø)

...astructure/MessagingServiceCollectionExtensions.cs
0% <0%> (ø)

src/WebTty.Infrastructure/Core/MessageResolver.cs
0% <0%> (ø)

... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4efb0cc...7df82ac. Read the comment docs.


"mismatching data with PKGBUILD" in the keybase-git package

Pacaur seems to be upset with something about how our pkgver function formats the version number. Here's what we have now (which fails):
pkgver() {
    "$srcdir/client/packaging/version.sh" prerelease | sed 's/-/_/g'
}

That produces version numbers like 1.0.15_20160412164431+b747605. If instead we use this function adapted from the peru-git package, the error goes away:
pkgver() {
    cd "$srcdir/client"
    echo $(git rev-list --count master).$(git rev-parse --short master)
}

I see several closed issues related to "mismatching data", but it looks like those have all been fixed. I just repro'd this issue with both pacaur and pacaur-git. Are our version numbers evil?
(Would it be possible to add some more output about exactly what difference pacaur is seeing?)

Seems the + is the evil part here. See guidelines.

(Would it be possible to add some more output about exactly what difference pacaur is seeing?)

Unfortunately, not possible without parsing the PKGBUILD itself.

Ok, I've fixed this on our end. It's an unfortunate limitation, since it doesn't support SemVer.

Yes. Note this is related to vercmp, and not directly related to pacaur.

Hmm, removing the + hasn't fixed the issue. When I diff ~/.cache/pacaur/keybase-git, I see this:
diff --git a/PKGBUILD b/PKGBUILD
index e76607b..12193e3 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -3,7 +3,7 @@
 pkgname=keybase-git
 pkgdesc='the Keybase Go client, filesystem, and GUI'
 license=('BSD')
-pkgver=1.0.15_20160412195754_74b75aa
+pkgver=1.0.15_20160412200627_743277d
 pkgver() {
   "$srcdir/client/packaging/version.sh" prerelease | sed 's/[-+]/_/g'
 }

And here's the .SRCINFO:
# Generated by mksrcinfo v8
# Tue Apr 12 19:58:08 UTC 2016
pkgbase = keybase-git
	pkgdesc = the Keybase Go client, filesystem, and GUI
	pkgver = 1.0.15_20160412195754_74b75aa
	pkgrel = 1
	install = keybase.install
	arch = i686
	arch = x86_64
	license = BSD
	makedepends = go
	makedepends = npm
	makedepends = git
	makedepends = rsync
	depends = fuse
	conflicts = keybase
	conflicts = keybase-release
	source = git+https://github.com/keybase/client
	source = git+https://github.com/keybase/kbfs-beta
	md5sums = SKIP
	md5sums = SKIP

pkgname = keybase-git

Yep, this is weird. I'll have a closer look.

vercmp does seem willing to compare versions with +'s in them, and even -'s.
Apologies in advance for our painfully long build time on that package. You can repro the problem even if you clear out build() and package() and replace their bodies with :, which avoid wasting time on npm. Thanks for taking a look.

Your custom versioning system is indeed completely evil. Every time you run makepkg on it, a different pkgver is generated, even though the source files are strictly the same.
I have no idea why you'd want to do that, but in any case I'd suggest you to get rid of the timestamp part of your custom pkgver. It just doesn't make sense.
Note that prior to pacman 5, that kind of system could have worked with pacaur as it used to use makepkg -i, but I had no choice but replace it (see #364) and pacaur has to "manually" track the version prior to installation, which fails here.
Also note your system might work with older helpers that don't make use of the RPC interface to retrieve info, or with bauerbill as it uses a custom, patched makepkg instead of relaying of the official script.

Interesting :) The version number we were using was the same scheme as the build number we use internally, for the Debian and RPM packages we host. I've switched it to a format without the timestamp. Thanks again for digging through this.


DEC-829: Creating a new collection fails

Refactored the pieces that were shared between the new collection form and the general settings form into its own partial and changed those two forms to render that partial. This structure changed when we added subforms to settings to accommodate the metadata configuration.

:+1:

:+1:


[SERV-534] Define institution and harvest job types

These immutable types should be nearly* impossible to instantiate with invalid arguments, and can be used with service proxies (i.e., sent over the event bus) since they are annotated with @DataObject.
Justification for the various PMD suppressions:

PMD.AvoidThrowingNullPointerException: I think it's fine for the Institution constructor to throw a NPE if it receives null for email, phone, and web contact; that would be a "programmer error" (at least one must be supplied per the Javadoc);
PMD.AvoidCatchingGenericException: the constructors that accept a JsonObject are required for @DataObject classes, since they are called by generated service proxy code. These classes don't compile if their constructors throw checked exceptions, hence the catch-all that wraps those in an IllegalArgumentException;
PMD.AvoidCatchingNPE: I suppose that instead of using Objects#requireNonNull in these constructors, one could explicitly check for equality with null and then throw IllegalArgumentException, but I think it's nice that all errors end up in the catch-all;
PMD.DataClass: it's intended that these classes are "data classes".

* One exception is that email addresses such as me@localhost will not trigger an error; however, we aren't verifying email addresses anyway, so there's nothing preventing an institution from e.g. accidentally providing an email address that they don't own. I think the validation that the javax.mail classes do is enough for our use case.

Okay, actually ready for review now.

Added a few more test cases.


How to use find controller without using PDFViewer.

Hi,
We can use PDFViewer which is deeply packaged to search keywords in the PDF, but it loads the whole pdf and we don't want to do that. We decided to overwrite functions based on PDFViewer in order to load page one by one, but we don't know how to add a find controller when use text layer separately.
Below is the picture how we put the text layer render,and we want to add a find Controller without using PDFViewer.

Thanks

Please see https://github.com/mozilla/pdf.js/issues/12190#issuecomment-671892921, of which this issue is (for all intents and purposes) a duplicate.


Fix freshness threshold on local services import

The freshness threshold for the job to import services and interactions into
Local Links Manager was set to just over 14 days, however the Jenkins job is
scheduled to run on the 1st of the month.
This amends the freshness threshold to be 32 days so that we don't get noise in
Icinga.

Actually had to test that one. Code looks fine and the change makes sense.
Merge away.

The simple maths actually confused me.


Question: Captions for local image files just like urls ?

With nbdev, you can include captions in images like this:
![](https://www.fast.ai/images/fastai_paper/show_batch.png "My Caption")

However, when the link is a local file, instead of a url this is not picked up by nbdev.  For example,
![](my_icons/fastai_logo.png "hello")
is not handled the same way - this results an in error when someone tries to do this.  @sgugger  I believe perhaps we should make an ammendment to the _img2jkl function:
https://github.com/fastai/nbdev/blob/9f572b27314d27f2862fbfc0c0a8321c13a94315/nbdev/export2html.py#L125-L129
However, I am not completely sure that is as easy as changing this function.  We might have to also (1) copy the image (2) change the relative path to the copied location.  Please let me know your thoughts.
The related issue on fatpages: https://github.com/fastai/fastpages/issues/225
cc:@noklam

Thx @hamelsmu I just saw the notification and saw you have already opened the issue.

Should be fixed now. I made sure it works the same way as external images.

Wow that was fast.  You close issues like magic on this repo.  I don’t know how you do it - starting to wonder if you are an artificial intelligence😝

I am only every happy when the number of issues and PRs is 0 ;)


handle late blocks in verifying tortoise

Description
handling late blocks in verifying tortoise. should also design how to handle them.
Affected code
verifying tortoise

@y0sher right now all late blocks are passed into tortoise as they arrive. I proposed a different architecture in #2415. Wondering if you had something more specific in mind here. (Or should we close this issue in favor of that one?)

Will follow up on this in #2552


test: msg sender is 0 when no entrypoint is called

Fixes #2949
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

[ ] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
[ ] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
[ ] Every change is related to the PR description.
[ ] I have linked this pull request to relevant issues (if any exist).

Benchmark results
No metrics with a significant change found.

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Values are compared against data from master at commit 4c832509 and shown if the difference exceeds 1%.
L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
128 txs

l1_rollup_calldata_size_in_bytes
45,444
179,588
716,132

l1_rollup_calldata_gas
222,912
868,136
3,449,552

l1_rollup_execution_gas
841,999
3,595,244
22,204,921

l2_block_processing_time_in_ms
2,333 (+1%)
8,849 (+1%)
34,254 (-1%)

note_successful_decrypting_time_in_ms
345 (+1%)
1,277 (-2%)
3,955 (-2%)

note_trial_decrypting_time_in_ms
45.0 (+5%)
107 (+1%)
138 (+1%)

l2_block_building_time_in_ms
14,749 (+1%)
58,281
233,510

l2_block_rollup_simulation_time_in_ms
13,361
52,841
211,567

l2_block_public_tx_process_time_in_ms
1,347 (+2%)
5,310
21,478 (-1%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
24,780 (+1%)
48,304 (+1%)

note_history_successful_decrypting_time_in_ms
2,516 (+1%)
4,902 (+1%)

note_history_trial_decrypting_time_in_ms
122
145 (-1%)

node_database_size_in_bytes
1,630,430
1,101,574

pxe_database_size_in_bytes
27,188
54,187

Circuits stats
Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit
circuit_simulation_time_in_ms
circuit_input_size_in_bytes
circuit_output_size_in_bytes

private-kernel-init
82.6
61,697
18,841

private-kernel-ordering
50.7
24,233
8,089

base-rollup
2,090
656,309
811

root-rollup
89.4 (-2%)
4,072
1,097

private-kernel-inner
59.4 (+1%)
81,504
18,841

public-kernel-private-input
46.9
41,455
18,841

public-kernel-non-first-iteration
29.1
41,497
18,841

merge-rollup
0.833 (-7%)
2,592
873

Miscellaneous
Transaction sizes based on how many contracts are deployed in the tx.

Metric
0 deployed contracts
1 deployed contracts

tx_size_in_bytes
8,723
29,393


Add Go v1.19 to builder base

Issue #, if available:
Description of changes:
Add Go v1.19 to builder base
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/override builder-base-tooling-presubmit-2022
/woof

/override builder-base-tooling-presubmit-2022

/override builder-base-tooling-presubmit-2022

/override builder-base-tooling-presubmit-2022

/override builder-base-tooling-presubmit
/mew

/lgtm

/lgtm
/approve

/override builder-base-tooling-presubmit-2022
/override builder-base-tooling-presubmit


TypeScript error when using --isolatedModules

Hi! Sorry to bother you, but your type definitions seem to be throwing an error when compiling TS:
$ tsc
node_modules/chalk/types/index.d.ts:4:19 - error TS1209: Ambient const
enums are not allowed when the '--isolatedModules' flag is provided.

export const enum Level {
                  ~~~~~

tsconfig.json:
{
  "compilerOptions": {
    // Disallow features that require cross-file information for emit.
    "isolatedModules": true,
  }
}

The isolatedModules flag is recommended when using Babel 7 to transpile TypeScript. Some more information is available here:
https://blogs.msdn.microsoft.com/typescript/2018/08/27/typescript-and-babel-7/

https://github.com/chalk/chalk/pull/296#issuecomment-418789492


sophuspy colab build fail

sophuspy failed building wheel in colab

I'm sorry that I don't know what colab means. Please provide more details

Hi,
Could you please let us know how to run the VINet code in Google Colab? We
are facing problems in installing the sophus.py file so that we can run
this in Jupyter Notebooks. Also, where do we provide the sensor data (
visual and inertial) collected from hololens in the VINet code.
Thanks & Regards
subhankar
On Thu, Dec 2, 2021 at 2:51 AM craigstar @.***> wrote:

I'm sorry that I don't know what colab means. Please provide more details
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/craigstar/SophusPy/issues/6#issuecomment-984373217,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AV3USMH7NKNXKXSIECLAID3UO4QQTANCNFSM5JAT3TIA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Sorry to reply late. New version 1.0.1 has released, I have solved pybind11 build problem. hope this would help.

Closing cause no more building needed.


Update riak cs debug [RCS-284]

This work is for merging a update of riak-debug on #1116, and includes some fixes to work with latest Riak CS.
I tested this on CentOS and Ubuntu manually.

Nice work! I like newly introduced option verbose :smile:
Added two small comments, will :+1: after they are discussed and/or fixed.

@borshop merge

Summary for release notes?

I will do.

For release note: Add several operator friendly features, fine grained information gathering options, user defined filtering for configuration files and verbose output for failed commands.

For release note: Add several operator friendly features, fine grained information gathering options, user defined filtering for configuration files and verbose output for failed commands.
[posted via JIRA by Kota Uenishi]


Calendar View - Iterations & Days off (links) - on-premise TFS

Having issues with clicking the links for Iterations or Days off from the calendar view.  In our on premise version of TFS 2017 update 2 when we use the links it will open a new tabbed window for Iteration or Capacity of the current sprint..  If try to create a new iteration we get this error "TF400813: Resource not available for anonymous access. Client authentication required.".  If we go to Days off we get an error when the page loads "TF400813: Resource not available for anonymous access. Client authentication required. Session Id: 9f579401-0176-41b3-9c25-c0792743ac93".  Any action taken in the new window assumes a anonymous identity.  We have to close those tabs and add everything with out using these shortcuts from the calendar.  I have tried I.E., Edge, and Chrome all behave the same way.  Any thoughts on how to address this issue?

Thanks for reporting. The issue has been fixed. Within 24 hours, you should see the fix in your on-premises deployment.

I have tested this.. It works with Iterations now however, when clicking Days off I am still getting the following error.
TF400813: Resource not available for anonymous access. Client authentication required.
Session Id: d15cd60f-43fe-458e-a6df-e60572702f22


MSDK-932: Fixing MAX32650 AES_KEY register offsets.

This branch was made before some fixes to the failing test in the workflow. You can either merge main into this. Or you can ignore the failed test honestly its a false result.


Study Quickstep parser

We want to determine if we can rip out the Quickstep parser and use it as a module. The input to the module would be a SQL string and the output would be a JSON query plan that can be accepted by the query processor.
If this is possible, we will determine what modifications need to be made in order to match the language surface of SQLite3.

Can we close this?

Yes I think so.

A new parser will be implemented for Hustle.


remove ct-registry

@PierreMartinon @jbcaillau You can check that CI, documentation and coverage work without ct-registry. Then, merge.


Motion Detection not workin on NVR

Hello, I use this tool with a NVR. All function seems to work except motion detection. The motion detect is always 'Clear' on all channels in home assistant. I am unsure if motion can be detected from the NVR. I found the below api call with the response.
API Call: http://<IP_ADDRESS>/api.cgi?cmd=GetMdState&user=admin&password=123&channel=0
Response:
[
{
cmd: "GetMdState",
code: 1,
error: {
detail: "check err",
rspCode: -3
}
}
]
The NVR is RLN8-410 with 4 D500 cameras.

Thanks, there is already a issue for this. I renamed it to make this clear: https://github.com/fwestenberg/reolink_dev/issues/100

Thanks, there is already a issue for this. I renamed it to make this clear: https://github.com/fwestenberg/reolink_dev/issues/100


Removed obsolete option synda-download from documentation

Description
This PR removes the obsolete option synda-download from the documentation and also updates the description of the example recipe which has been changes in recent releases.

Closes #2481
Link to documentation: https://esmvaltool--2485.org.readthedocs.build/en/2485/quickstart/running.html#running-a-recipe

Before you get started

[x] ☝ Create an issue to discuss what you are going to do

Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

[x] 🛠 This pull request has a descriptive title
[x] 🛠 Code is written according to the code quality guidelines
[x] 🛠 Documentation is available
[x] 🛠 Tests run successfully
[x] 🛠 The list of authors is up to date
[x] 🛠 Any changed dependencies have been added or removed correctly
[x] 🛠 All checks below this pull request were successful

To help with the number of pull requests:

🙏 We kindly ask you to review two other open pull requests in this repository

Thanks for the quick review V!!

I was working on this in #2432, let's see how relevant that still is.


Find in selected text

I use the vim extension to select a few lines, then i would like to do a Find on that selected text.

Please provide more information of VS Code version, OS, and also extensions you are using.

Visual Studo Code Version: 1.50.0
OS: macOS
Extensions:
Dart-Code.dart-code
Dart-Code.flutter
dbaeumer.vscode-eslint
denoland.vscode-deno
Equinusocio.vsc-community-material-theme
Equinusocio.vsc-material-theme
equinusocio.vsc-material-theme-icons
esbenp.prettier-vscode
Kasik96.swift
ms-azuretools.vscode-docker
PKief.material-icon-theme
vknabel.vscode-apple-swift-format
vscodevim.vim

It seem there already is an option for this Auto Find In Selection. Thanks for a great editor!


Fixes for #4, check for initial scale fit & logic fix on line 236

Changed the initial scale to check if 0.5 zoom is too zoomed out for the map size, and adjust accordingly.
Fixed y transformation checking, which after checking if the transformed y would be too low, proceeded to adjust it using the width and view width instead of heights.

Looks perfect.
Thanks for the PR, Xetem!


dmic on chromebooks not working in 2ch mode.

I've personally tested this on the cave and snappy chromebooks but the same thing seems to happen on every chromebook using the avs driver.
The default NHLT configuration for dmic on MrChromebox's uefi firmware is 2ch, which gives this error in dmesg:
[   19.115046] snd_soc_avs 0000:00:0e.0: no DMIC ep_blob found
[   19.115061] snd_soc_avs 0000:00:0e.0: module-type create failed: -2
[   19.115065] snd_soc_avs 0000:00:0e.0: error creating module -2
[   19.115116] snd_soc_avs 0000:00:0e.0: create path failed: -2
[   19.115120] snd_soc_avs 0000:00:0e.0: ASoC: error at snd_soc_dai_hw_params on DMIC Pin: -2
[   19.115132]  DMIC: ASoC: error at __soc_pcm_hw_params on DMIC: -2
[   19.115136]  Digital Microphone: ASoC: error at dpcm_fe_dai_hw_params on Digital Microphone: -2

If I recompile the firmware with 4ch dmic it is able to load just fine. However, the actual mic hardware is only 2 channels which makes the rear 2 channels very noisy and lowers the quality of the mic recording.

Thanks for testing things out, @WeirdTreeThing.

If I recompile the firmware with 4ch dmic

Could you elaborate?
I believe updating the topology so it exposes both 2ch and 4ch formats should do the trick. And then some smart code within the kernel to intersect formats exposed by the topology file with ones exposed by the NHLT. NHLT is an ACPI table that describes hardware capabilities for non-HDAudio devices (the shortcut literally standards for: NonHDAudioLinkTable) which DMIC is example of.

Could you elaborate?

If I wanted to change between 2ch and 4ch on snappy for example, I would need to edit the Kconfig for the reef board and change the included NHLT blob.

On default ChromeOS we consume 4ch and just remap to the correct channels.

I could do something similar to that with UCM but that would still require modifying the firmware.

Hmm.. if you can enable 4ch DMIC in coreboot firmware, is my assistance required?

@WeirdTreeThing I've checked the DMIC topology XML with intention to add missing formats but it seems everything is already in place i.e.: entries for 2ch are there.
Did you try opening the pcm device while explicitly setting channel count to 2? Example:
arecord -Dhw:0,1 -c 2 -r 48000 -f S32_LE -vv > /dev/null

@crojewsk-intel If I try setting the channel count to 2 in arecord I get this error.
Recording WAVE 'stdin' : Signed 32 bit Little Endian, Rate 48000 Hz, Stereo
arecord: set_params:1416: Unable to install hw params:
ACCESS:  RW_INTERLEAVED
FORMAT:  S32_LE
SUBFORMAT:  STD
SAMPLE_BITS: 32
FRAME_BITS: 64
CHANNELS: 2
RATE: 48000
PERIOD_TIME: 125000
PERIOD_SIZE: 6000
PERIOD_BYTES: 48000
PERIODS: 4
BUFFER_TIME: 500000
BUFFER_SIZE: 24000
BUFFER_BYTES: 192000
TICK_TIME: 0

Along with the same error I initially described in dmesg
[   83.206138] snd_soc_avs 0000:00:0e.0: no DMIC ep_blob found
[   83.206147] snd_soc_avs 0000:00:0e.0: module-type create failed: -2
[   83.206151] snd_soc_avs 0000:00:0e.0: error creating module -2
[   83.206242] snd_soc_avs 0000:00:0e.0: create path failed: -2
[   83.206246] snd_soc_avs 0000:00:0e.0: ASoC: error at snd_soc_dai_hw_params on DMIC Pin: -2
[   83.206259]  DMIC: ASoC: error at __soc_pcm_hw_params on DMIC: -2
[   83.206263]  Digital Microphone: ASoC: error at dpcm_fe_dai_hw_params on Digital Microphone: -2

The same thing happens with 4 channels too
Recording WAVE 'stdin' : Signed 32 bit Little Endian, Rate 48000 Hz, Channels 4
arecord: set_params:1416: Unable to install hw params:
ACCESS:  RW_INTERLEAVED
FORMAT:  S32_LE
SUBFORMAT:  STD
SAMPLE_BITS: 32
FRAME_BITS: 128
CHANNELS: 4
RATE: 48000
PERIOD_TIME: 125000
PERIOD_SIZE: 6000
PERIOD_BYTES: 96000
PERIODS: 4
BUFFER_TIME: 500000
BUFFER_SIZE: 24000
BUFFER_BYTES: 384000
TICK_TIME: 0

Pulseaudio is able to record 4 channels just fine, pipewire gives the same error in dmesg.

Could you attach your NHLT here? Also, please dump the entire dmesg from the performed scenario. Before doing so, ensure the dynamic debug for relevant modules is enabled:
// open an existing or create new .conf file in /etc/modprobe.d/
options snd_soc_avs dyndbg==pmf
options snd_soc_core dyndbg==pmf
options snd_intel_dspcfg dyndbg==pmf dsp_driver=4

Sure, the dmesg is in the form of the system journal since the actual dmesg is cut off. I am currently using the stock ChromeOS firmware so the NHLT shouldn't be causing the problem.
journal.txt
NHLT.txt (NHLT is .txt so that github would let me upload it)

The only format I see in your NHLT for DMIC is 4/16/16/48000 as informed by snd_intel_dspcfg:
Apr 05 16:03:18 snappy kernel: snd_intel_dspcfg:nhlt_check_ep_match: snd_soc_avs 0000:00:0e.0: Endpoint: vbus_id=0 link_type=2 dir=1 dev_type = 0
Apr 05 16:03:18 snappy kernel: snd_intel_dspcfg:nhlt_get_specific_cfg: snd_soc_avs 0000:00:0e.0: Endpoint format count=1
Apr 05 16:03:18 snappy kernel: snd_intel_dspcfg:nhlt_get_specific_cfg: snd_soc_avs 0000:00:0e.0: Endpoint format: ch=4 fmt=16/16 rate=48000

whereas the user is attempting either 2/32/32/48000 or 4/32/32/48000. Have you tried with 4/16/16/48000?

That's it, the problem was the audio server would set the format to s32le by default and would fail. Both the 4ch and 2ch NHLT work with s16le.

My solution was to use a wireplumber config file to force pipewire to set the format to S16_LE on dmic. I've been using this for some time now and it has been working perfectly, thanks for all the help.


Chat template rendering extensions to match transformers

I've been using the jinja2 tojson filter in a couple of chat templates to render function calling instructions, which is working very well, however sometimes this will introduce escaped unicode characters, which is undesirable.
This PR simply changes the default parameters of tojson replaces tojson so that the JSON is rendered in unicode without escaped HTML characters.
Examples of models using tojson:

openfunctions-v2
Mistral-7B-Instruct-v0.3

I've also removed the leftover (and unnecessary) loader parameter since I was touching this code area anyway.
Update:
Further changes to chat templates are being made in transformers and since they are dependant on the changes already made here I will simply append them to this PR:

Added loopcontrols jinja2 extension (adds break and continue)
Added strftime to render the current time

See huggingface/transformers#32684

Since the merging of a similar patch to transformers and the formalizing of tools (see references in #1336) there are starting to pop up a lot more models using tojson in their chat templates.

@abetlen Even more transformers changes incoming, see updated OP.

@abetlen It would be really nice to have this merged soon, it's starting to cause issues with quite a few templates not to have this in place.
Additionally this is a requirement for implementing inverse templates (which I'd like to do, as soon as it's merged in transformers, since it will be super useful for universal function calling and parsing).


Update swagger-tools dependency?

The swagger-tools dependency is currently at 0.10.1, which is the latest release, but there's been several important commits since then, for example adding support for "nested controllers":
https://github.com/apigee-127/swagger-tools/pull/422
It seems like their release cadence is pretty slow.
Would it be possible to update package.json to use something like:
"swagger-tools": "apigee-127/swagger-tools#6851b2aa55b3aac93e5cd7f9643d15d167733b36
Would make it easier to use nested controllers without manually figuring out the dependency mess...

As a side note on this, I'm interested to know if there's any thoughts on the deprecation of swagger-tools (read all about it)?
That's perhaps why you're seeing a slow release cadence - I think they're focusing more on getting Sway going now.

Thanks for the link, I wasn't up on the developments with Sway. Looks like it's been at 1.0 since last April - I would also be curious to hear about any plans to make the switch in any other projects with swagger-tools as a dependency.
For what it's worth, if anyone else needs to get nested controllers working now by overriding the dependency version manually, a custom npm shrinkwrap worked fine.


2d/3d Shock-Capturing for curved mesh solvers

Working on an implementation of shock-capturing for all curved mesh solvers.

Does shock-capturing also work in 1D on the StructuredMesh?

Does shock-capturing also work in 1D on the StructuredMesh?

No, I have only implemented it for 2d and 3d. If there is a need for it, I could add to my PR.

Does shock-capturing also work in 1D on the StructuredMesh?

No, I have only implemented it for 2d and 3d. If there is a need for it, I could add it to my PR.

If you do not need it, I'd say do not implement it. However, since 1D is uncurved by default, I think it shouldn't be too hard to just reuse the 1D implementation from tree_dgsem, should it? If it "just works", maybe add a single test.
This, of course, only makes sense if we actually do have SC implemented in 1D, which I think we do.

Does shock-capturing also work in 1D on the StructuredMesh?

No, I have only implemented it for 2d and 3d. If there is a need for it, I could add it to my PR.

If you do not need it, I'd say do not implement it. However, since 1D is uncurved by default, I think it shouldn't be too hard to just reuse the 1D implementation from tree_dgsem, should it? If it "just works", maybe add a single test.
This, of course, only makes sense if we actually do have SC implemented in 1D, which I think we do.

I'll take a closer look and add it in another commit if it's "easy" to implement.

Great job, @Cczernik !
The implementation of the metric terms for the subcell FV method looks correct to me.

Some tests fail, see https://github.com/trixi-framework/Trixi.jl/pull/721/checks?check_run_id=3724237856#step:7:900 - CFL issues?

Overall nice work @Cczernik ! I left my comments throughout, most of it is related to the merge conflict cleanup that was already pointed out by Hendrik.
Also, just to double check, did you test the metric identities from Sebastian's paper for the sub-cell metric terms? The formulas in the code look fine but this is the only sure fire check.

Thank you! Yes I checked the metric identities as well as free-stream preservation.

@andrewwinters5000 Please submit you review and ping me afterwards. I will take care of the rest (since we can't use auto merge etc. since @sloede has requested changes but won't review this again due to time constraints).

@Cczernik Coverage reports indicate that no smoothing is tested on structured meshes in 2D and 3D. Could you please execute this functionality in some test?
See https://coveralls.io/builds/43175327/source?filename=src%2Fsolvers%2Fdgsem_structured%2Findicators_2d.jl#L7 and https://coveralls.io/builds/43175327/source?filename=src%2Fsolvers%2Fdgsem_structured%2Findicators_3d.jl#L7

Thank you all for your reviews so far!
@ranocha smoothing is now tested on structured meshes in 2D and 3D.

@andrewwinters5000 Please submit you review and ping me afterwards.

@ranocha I just submitted my re-review

Thanks, @andrewwinters5000.
@Cczernik I guess we're mostly done. Please revise this PR based on the comments of @andrewwinters5000 and ping me afterwards.

@ranocha @Cczernik I just realized that our feature matrix is now probably out-of-date: https://trixi-framework.github.io/Trixi.jl/stable/overview/#Semidiscretizations. Maybe it would be good to update it before it is referenced from the announcement in #720.

Did you check the dev docs?


[Bug]: The column mode is invalid

ODC version
4.2.0
OB version
4.1.0
What happened?
1、Using SQL query for table data；
2、View result set in column mode；

What did you expect to happen?
The column mode is functioning normally
How can we reproduce it (as minimally and precisely as possible)?
1、Using SQL query for table data；
2、View result set in column mode；
Anything else we need to know?
No response
Cloud
No response

It works on dev-4.2.1 version

PASS


Pass variables between partials

Hi,
I have a partial that includes another one, where I would like to pass a variable from the parent partial to the child.
HTML body
<%~ includeFile('../big_listings_parser', it); %>
big_listings_parser.eta
<% for (var i = 0; listings.length> 0 && i < listings.length ; i++) { %>
      <%~ includeFile('card_body', {  listing: listings[i]  } ); %>
<% } %>

card_body.eta
// use **listing** variable
As you can see, here I want to pass the variable listing which is a single value inside the loop.
What I tried
passing multiple variables like:  it, it.listings[i], listings[i] all gives errors like:

ReferenceError: listings is not defined\n

Kindly :)

It should work in the example above? Don’t forget to call your variables using the it object.
So it.listings in the parent and it.listing in the child partial.

Hi @gurgunday it really doesn't

oh my bad, it does work. the problem was not in the parent partial, so it is in the child that the variable is undefined, but that an error in my child partial. Thanks a lot !!!


Use self.current_session instead of inexistent self.connection

Summary
When RTM Client v2 and calling the close method and exception is raised.
Traceback (most recent call last):
  File "/opt/errbot/bin/errbot", line 8, in <module>
    sys.exit(main())
  File "/opt/errbot/lib/python3.8/site-packages/errbot/cli.py", line 399, in main
    bootstrap(backend, root_logger, config, restore)
  File "/opt/errbot/lib/python3.8/site-packages/errbot/bootstrap.py", line 259, in bootstrap
    bot.serve_forever()
  File "/opt/errbot/lib/python3.8/site-packages/errbot/backends/base.py", line 882, in serve_forever
    self.shutdown()
  File "/opt/errbot/backends/err-backend-slackv3/slackv3.py", line 1230, in shutdown
    self.slack_rtm.close()
  File "/opt/errbot/lib/python3.8/site-packages/slack_sdk/rtm/v2/__init__.py", line 240, in close
    self.disconnect()
  File "/opt/errbot/lib/python3.8/site-packages/slack_sdk/rtm/v2/__init__.py", line 232, in disconnect
    self.connection.disconnect()
AttributeError: 'RTMClient' object has no attribute 'connection'

This patch replaces self.connection with self.current_session
Category (place an x in each of the [ ])

[ ] slack_sdk.web.WebClient (sync/async) (Web API client)
[ ] slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
[ ] slack_sdk.models (UI component builders)
[ ] slack_sdk.oauth (OAuth Flow Utilities)
[ ] slack_sdk.socket_mode (Socket Mode client)
[ ] slack_sdk.audit_logs (Audit Logs API client)
[ ] slack_sdk.scim (SCIM API client)
[x] slack_sdk.rtm (RTM client)
[ ] slack_sdk.signature (Request Signature Verifier)
[ ] /docs-src (Documents, have you run ./docs.sh?)
[ ] /docs-src-v2 (Documents, have you run ./docs-v2.sh?)
[ ] /tutorial (PythOnBoardingBot tutorial)
[ ] tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

[x] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've run python setup.py validate after making the changes.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Oh, thanks - LGTM 🙇


Add admin role to profile page.

If logged in user is one of the listed admins in config.yml, they can see any
user's profile by going to /profile/name_of_user.

I renamed effectiveUser to assumedUser


Valid values for the ImageReference Properties

Type of issue
Missing information
Description
Please provide information on where to get valid values for the ImageReference Properties
Page URL
https://learn.microsoft.com/en-us/dotnet/api/microsoft.azure.management.compute.models.imagereference?view=azure-dotnet-legacy
Content source URL
https://github.com/Azure/azure-docs-sdk-dotnet/blob/master/xml/Microsoft.Azure.Management.Compute.Models/ImageReference.xml
Document Version Independent Id
bb85bf89-ec54-1272-e3c6-164eccce857d
Article author
@azure-sdk
Metadata

ID: 8bced382-3170-ff05-b5c0-0cb91e38e986
Service: multiple

Hi @rob011235.  The Microsoft.Azure..Management.Compute package reached end-of-life in September 2023 and is no longer published nor supported by Microsoft.  The currently supported package for compute management operations is Azure.ResourceManager.Compute.
As this your inquiry is regarding an unsupported package, regrettably, there is no assistance that we can provide.  I'm going to close this out.


TypeError: arg is not iterable

[89164:1222/115023.156687:INFO:CONSOLE(48)] "TypeError: arg is not iterable
	at dispose (/Users/bpasero/Development/Microsoft/monaco/extensions/github/out/util.js:14:34)
	at /Users/bpasero/Development/Microsoft/monaco/extensions/github/out/extension.js:78:36
	at Emitter.fire (/Users/bpasero/Development/Microsoft/monaco/out/vs/base/common/event.js:464:38)
	at ExtensionDescriptionRegistry.deltaExtensions (/Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/services/extensions/common/extensionDescriptionRegistry.js:70:31)
	at ExtHostExtensionService.$deltaExtensions (/Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/api/common/extHostExtensionService.js:588:28)
	at processTicksAndRejections (internal/process/task_queues.js:93:5)", source: vscode-file://vscode-app/Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/api/browser/mainThreadExtensionService.js (48)

Found this running out of sources with a fresh user data dir
//cc @alexr00 @TylerLeonhardt

Seems to be from:
https://github.com/microsoft/vscode/blob/ffda3a18cc91411bd11396b62396f7ccc5d04388/extensions/github/src/util.ts#L8-L16

github -> @joaomoreno
github-authentication -> @TylerLeonhardt

This is our number 1 and 2 error reported:

Verification:

Open workbench, with devtools
Disable built-in git extension
Reload
Enable git extension

There should be no error in devtools


Support for running Exchange Management Shell

It would be great to be able to add MS Exchange Shell to Terminal to manage On-Prem exchange.

I think this might unfortunately be a /dupe of #1785. It looks like the way the MS Exchange Shell works is fairly incompatible with the way the Terminal launches applications. From that thread:
https://github.com/microsoft/terminal/issues/1785#issuecomment-509060477

This might just boil down to #492. It looks like appref-ms shortcuts are another type of ClickOnce application, which means their launch must be brokered through another process (internet explorer, windows shell, etc.) Right now, we can't support hooking the launch of another console application through a broker.

#1785 (and this issue) will work once we've added support for #492. I've also got mail out to the owners of Exchange Management Shell, hopefully we might be able to find a workaround.
I'm going to close this for now, as a dupe of that other thread. If I hear anything back that's usable as a workaround, I'll make sure to reply here ☺


Refactor and use some more cats features

Refactor interpreter: split out handling of FetchOne, FetchMany
and Concurrent, use XorT in processMany to reduce nested folds,
use Validated in processMany and processConcurrent to get
missing ids/identities or some result.
(Prematurely ?) optimize Fetch.join
Replaced custom implementations of map2, sequence and traverse
by using Applicative[Fetch]
...

I moved some methods around in the Fetch object and with the
extraction of the three methods in the interpreter, so the diff looks
much bigger than it actually is.

Amazing work :clap: :clap:, learning a lot form these contributions.

Current coverage is 69.74% (diff: 79.51%)

Merging #73 into reporting will decrease coverage by 2.20%

@@           reporting        #73   diff @@
===========================================
  Files              8          8
  Lines            164        195    +31
  Methods          158        190    +32
  Messages           0          0
  Branches           6          5     -1
===========================================
+ Hits             118        136    +18
- Misses            46         59    +13
  Partials           0          0

Powered by Codecov. Last update 38a8fd4...f173dfd


package.install is not working

example codeserver package

fix at: https://github.com/threefoldtech/js-sdk/commit/1f5bd71a66aa8b965b0389c7143e1b0c0e3f8f1a

verified.


Language related bug on Home page

Keep getting this PHP notice popping up in logs:
Notice: Undefined index: en in dosomething_home_preprocess_node() (line 50 of /var/www/dev.dosomething.org/lib/modules/dosomething/dosomething_home/dosomething_home.module).

Likely to do with language/translation stuffs.

this is caused if there's no cover image and it's on the campaign node
not likely going to happen in prod, but defense! :football:

closing this, it only is caused if there isn't an image set


feat(mis-server): copy slurm.sh to slurm node automatically when mis-server starts

Copy slurm.sh automatically when mis-server starts.

Codecov Report
Base: 65.17% // Head: 65.15% // Decreases project coverage by -0.01% :warning:

Coverage data is based on head (6b06809) compared to base (3ee7819).
Patch coverage: 50.00% of modified lines in pull request are covered.

:exclamation: Current head 6b06809 differs from pull request most recent head 8c1156a. Consider uploading reports for the commit 8c1156a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #233      +/-   ##
==========================================
- Coverage   65.17%   65.15%   -0.02%
==========================================
  Files          94       94
  Lines        2495     2497       +2
  Branches      311      311
==========================================
+ Hits         1626     1627       +1
- Misses        831      832       +1
  Partials       38       38

Impacted Files
Coverage Δ

apps/mis-server/src/plugins/clusters.ts
44.44% <50.00%> (+0.25%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Convert Route.java to Kotlin

Was tempted to use data class for this, but it breaks Kotlin compatibility. Is this fine?

Is this fine?

We should start with direct conversion and then expose properties and create deprecated(hidden) functions afterward to make the API idiomatic.

Makes sense. I'll decline and make another pass.


[Java Client v4] Publish to Maven Central

Acceptance Criteria

Complete testing and ensure the stability of the Java Client v4.
Gather feedback and address any critical issues.
Publish the initial release of Java Client v4 to Maven Central.

Publish Java Client v4 to Maven Central


Introduce cxd56_testset

Summary

I noticed that ldrex/strex on cxd56xx have an issue
The issue is still under investigation
This commit introduces a custom testset to avoid the issue

Impact

Affects cxd56xx in SMP mode if it is enabled

Testing

Tested with spresense:wifi_smp

@jerpelea


Failed to build on Ubuntu 16.04

Hi,
I am new in JS development, and am currently trying to follow steps in quickstart, however when I type "npm install", I have following error:
npm WARN deprecated<EMAIL_ADDRESS>ReDoS vulnerability parsing Set-Cookie https://nodesecurity.io/advisories/130

<EMAIL_ADDRESS>postinstall /home/a/tmp/angular2-quickstart
typings install

/usr/bin/env: ‘node’: No such file or directory
npm WARN optional Skipping failed optional dependency /chokidar/fsevents:
npm WARN notsup Not compatible with your operating system or architecture<EMAIL_ADDRESS>npm WARN<EMAIL_ADDRESS>No description
npm WARN<EMAIL_ADDRESS>No repository field.
npm ERR! Linux 4.4.0-31-generic
npm ERR! argv "/usr/bin/nodejs" "/usr/bin/npm" "install"
npm ERR! node v4.2.6
npm ERR! npm  v3.5.2
npm ERR! file sh
npm ERR! code ELIFECYCLE
npm ERR! errno ENOENT
npm ERR! syscall spawn
npm ERR<EMAIL_ADDRESS>postinstall: typings install
npm ERR! spawn ENOENT
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>postinstall script 'typings install'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the angular2-quickstart package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     typings install
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs angular2-quickstart
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls angular2-quickstart
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     /home/a/tmp/angular2-quickstart/npm-debug.log

Looks like it is problem with standard ubuntu nodejs distribution.
I uninstalled ubuntu nodejs, and installed nodejs using inctructions from https://github.com/nodesource/distributions#debinstall, and it solved the problem.

@crypto5 you can also try install nodejs via https://github.com/creationix/nvm


artificial objects and energy transformation need more axiomatic connections

Description of the issue
In #737 @l-emele said:

In #372 we already had a long discussion which touched also the aspect of connecting the objects to energy transformations. But as far as I can see we did only some top-level relations (i.e. relating energy converting device to energy transformation etc) but not for the subclasses. But I am to doing that now as we now have a much better structure in energy transformation as back then.

Ideas of solution
We should look at the subclasses of artificial object, especially the subclasses of energy converting device and power generating unit and add fitting relations.
Useful object properties are:

participates in: a relation between a continuant and a process, in which the continuant is somehow involved in the process
produces: a produces b if some process that occurs_in a has_output b, where a and b are material entities.
uses: A relation that holds between a continuant and another continuant it requires to function.

An example: PV cell is defined as a generator that converts light into electrical energy., but has no axioms.
We could add

participates in some photovoltaic energy transformation
uses some photon / solar energy (?)
produces some electrical energy

Results so far
New classes

hydrogen fuel cell: A hydrogen fuel cell is a fuel cell that uses hydrogen. (+ axiom hydrogen fuel cell uses some hydrogen)
natural gas turbine: A natural gas turbine is a gas turbine fueled with natural gas. (+ axiom natural gas turbine uses some natural gas)

New / changed axioms

subject
predicate
object

electro motive generator
uses
some kinetic energy

fuel cell
uses
some ~hydrogen~ fuel

fuel cell
participates in
some redox reaction

PV cell
uses
some solar energy

PV cell
participates in
some photovoltaic energy transformation

heat exchanger
uses
some thermal energy

heat exchanger
produces
some thermal energy

electric heat pump
uses
some electrical energy

solar thermal collector
~has physical input~ uses
~only solar thermal heat~ some solar energy

solar thermal collector
participates in
some solar thermal energy transformation

solar thermal collector
produces
some solar thermal energy

motor
produces
some kinetic energy / rotational energy

pump
produces
some (kinetic energy or potential energy)

steam reformer
uses
some hydrocarbon (new class)

steam reformer
produces
some syngas (new class)

gas turbine
produces
some ~electrical energy~ kinetic energy / rotational energy

gas turbine
uses
~only natural gas~ some combustion fuel

hydrogen turbine
uses
~only~ some hydrogen

turbine
produces
some kinetic energy / rotational energy

steam turbine
produces
some ~electrical energy~ kinetic energy / rotational energy

steam turbine
uses
some steam

steam turbine
participates in
some steam-electric process

steam turbine
uses
some thermal energy

water turbine
participates in
some hydro energy transformation

water turbine
produces
some ~electrical energy~ kinetic energy / rotational energy

wind rotor
participates in
some wind energy transformation

wind rotor
uses
some wind energy

wind rotor
produces
some ~electrical energy~ kinetic energy / rotational energy

water electrolyser
uses
some electrical energy and some water

water electrolyser
produces
some hydrogen, oxygen (new class) and chemical energy

power generating unit
produces
some electrical energy

hydro power unit
participates in
some hydroelectric energy transformation

solar power unit
uses
some solar energy

solar thermal power unit
produces
some thermal energy

wind energy converting unit
uses
some wind energy

other changes:

electric heat pump: we should use definition-annotation instead of comment annotation and change "electric energy" to "electrical energy" in the definition text
lignite power unit has an axiom EquivalentTo uses some lignite. This is probably a mistake and should be changed to SubClassOf uses some lignite

To Do

hydrocarbon and syngas are part of the definition of steam transformer, but don't exist in the ontology yet. We should add them
we should add rotational energy, which is used in the definition of motor and turbine
water turbine is defined as converting potential energy and kinetic energy of water, but has the axiom uses some hydro energy. We should change either the definition or the axiom. The same applies to wind rotor.

Workflow checklist

[ ] I discussed the issue with someone else than me before working on a solution
[ ] I already read the latest version of the workflow for this repository
[ ] The goal of this ontology is clear to me

I am aware that

[ ] every entry in the ontology should have a definition
[ ] classes should arise from concepts rather than from words

Here is a list of relations I was able to derive from the definitions:

subject
predicate
object

electro motive generator
uses
some kinetic energy

fuel cell
uses
some ~hydrogen~ fuel

fuel cell
participates in
some redox reaction

PV cell
uses
some solar energy

PV cell
participates in
some photovoltaic energy transformation

heat exchanger
uses
some thermal energy

heat exchanger
produces
some thermal energy

electric heat pump
uses
some electrical energy

solar thermal collector
~has physical input~ uses
~only solar thermal heat~ some solar energy

solar thermal collector
participates in
some solar thermal energy transformation

motor
produces
some kinetic energy / rotational energy

pump
produces
some (kinetic energy or potential energy)

steam reformer
uses
some hydrocarbon (new class)

steam reformer
produces
some syngas (new class)

gas turbine
produces
some ~electrical energy~ kinetic energy / rotational energy

turbine
produces
some kinetic energy / rotational energy

steam turbine
produces
some ~electrical energy~ kinetic energy / rotational energy

steam turbine
uses
some steam

steam turbine
participates in
some steam-electric process

steam turbine
uses
some thermal energy

water turbine
participates in
some hydro energy transformation

water turbine
produces
some ~electrical energy~ kinetic energy / rotational energy

wind rotor
participates in
some wind energy transformation

wind rotor
uses
some wind energy

wind rotor
produces
some ~electrical energy~ kinetic energy / rotational energy

water electrolyser
uses
some electrical energy and some water

water electrolyser
produces
some hydrogen, oxygen (new class) and chemical energy

power generating unit
produces
some electrical energy

hydro power unit
participates in
some hydroelectric energy transformation

solar power unit
uses
some solar energy

solar thermal power unit
produces
some thermal energy

wind energy converting unit
uses
some wind energy

Some minor issues I noticed:

electric heat pump: we should use definition-annotation instead of comment annotation and change "electric energy" to "electrical energy" in the definition text
hydrocarbon and syngas are part of the definition of steam transformer, but don't exist in the ontology yet. We should add them
we should add rotational energy, which is used in the definition of motor and turbine
water turbine is defined as converting potential energy and kinetic energy of water, but has the axiom uses only hydro energy. We should change either the definition or the axiom. The same applies to wind rotor.
lignite power unit has an axiom EquivalentTo uses some lignite. This is probably a mistake and should be changed to SubClassOf uses some lignite

Looks good. I would add solar thermal collector produces some solar thermal energy.

Regarding the fuel cell: Maybe we need a new subclass hydrogen fuel cell that gets the axiom uses some hydrogen that currently the fuel cell has.

Proposal for definition for hydrogen fuel cell; A hydrogen fuel cell is a fuel cell that uses hydrogen. I think we can include this subclass as part of this restructuring issue and do not need a separate issue for that.

I like the idea of including a class hydrogen fuel cell.

I found a further inconsistency: hydrogen turbine is a subclass of gas turbine. Those classes have the following problematic axioms:

'gas turbine' uses only 'natural gas'
'hydrogen turbine' uses only 'hydrogen'

If a gas turbine uses only natural gas, then a subclass of it cannnot use only something else. Also I am not happy here with the uses only part of the axioms for a second reason: Every gas turbine needs also an oxidiser. Almost all gas turbines use air (which has oxygen as part).
The first axiom does not match the definition of gas turbine which has no limitation to natural gas: A gas turbine is a turbine that converts chemical energy into rotational energy using a continous internal combustion process. Hence it is also called combustion turbine.
To fix this, we could introduce a natural gas turbine (or natural gas gas turbine?) which might be defined in parallel to hydrogen turbine: A natural gas turbine is a gas turbine fueled with natural gas.

The first axiom does not match the definition of gas turbine which has no limitation to natural gas: A gas turbine is a turbine that converts chemical energy into rotational energy using a continous internal combustion process. Hence it is also called combustion turbine.
To fix this, we could introduce a natural gas turbine (or natural gas gas turbine?) which might be defined in parallel to hydrogen turbine: A natural gas turbine is a gas turbine fueled with natural gas.

I agree. This means we also need a new class for the gas turbine uses some ... axiom. I would suggest combustion fuel, which is the first common superclass of both hydrogen and natural gas.

If a gas turbine uses only natural gas, then a subclass of it cannnot use only something else. Also I am not happy here with the uses only part of the axioms for a second reason: Every gas turbine needs also an oxidiser. Almost all gas turbines use air (which has oxygen as part).

This is indeed a problem. I just added turbine uses some fluid in PR #769 which lead to a long list of unsatisfiable classes. So I agree that we should change the uses only-axioms. An easy solution would be to replace "only" with "some".

I tried to summarize the results so far in the issue header. Since this issue has gotten pretty comprehensive already, I would suggest to implement what we have (if everyone agrees). For the To Do points, we can open new issues (at least for hydrocarbon / syngas and rotational energy. After taking a closer look at it, water turbine and wind rotor are not really a problem, because hydro energy and wind energy are forms of kinetic energy according to our structure)

I agree. This means we also need a new class for the gas turbine uses some ... axiom. I would suggest combustion fuel, which is the first common superclass of both hydrogen and natural gas.

(combustion fuel and has state of matter gaseous) ?!

The word gas in gas turbine does not mean that it uses a gaseous fuel but that it uses a gas as working medium (i.e. air in most cases) that is heated in an internal combustion (hence the alternative term combustion turbine).
A gas turbine can also used with other combustion fuels than gaseous fuels, some power plants with gas turbines use e.g. heating oil. Most airplanes have gas turbines as engine and use kerosene.


Split up endpoints into graphql and admin

This isn't going to be merged but I've raised this so people can see the diff a bit easier.
It's part of the spike to see about splitting the graphql server into two separate endpoints.

Good to see that this doesn't require any changes to the field definitions. 👍


Docs: Add 3⃣-node single binary quickstart

I feel we should move the Docker sections out of the quickstart entirely, but I'm not sure where a good place to put them would be.
They're not really for production deployment, so Deploy doesn't fit. Recipes is more client level stuff. We could add something, but not sure if that's great either. Open to suggestions :smile:.

Great to de-Docker QuickStart and put the spotlight on a single binary experience.
I think if people are looking for Docker steps, they would expect it under Deploy. We can put it there and improve it while we are pre-production?

I think if people are looking for Docker steps, they would expect it under Deploy. We can put it there and improve it while we are pre-production?

Another one of my concerns was only having a "Docker" section under deploy, might give the impression that Docker's the only way to deploy. Maybe a disclaimer there would be good enough, or could do a pretty quick systemd example file?

I think both "here's the docker image" and "we have github releases" should go under "Instllation" section maybe?


Added Callback cli

Description
Added callback cli. Invokes the inbuilt commands.
This is not finished

What should the value of requestID be. UUID or some string?
For url and default, how should those values be passed?

Sry I was busy with my work, could not look into what should be passed for callbacks which dont require a json
To-Do

[ ] Fix RequestID
[ ] Fix non json flow

@dfarr I couldnt find an option to request for review , so can you help me out?

I am not well. I will look into this next week. Is that fine?

I am not well. I will look into this next week. Is that fine?

Of course, take your time and hope you get well soon!

Hey @Madraceee I can take over this PR if you'd like? Let me know your status :)

Closing in favour of #499


Reimplement datetime literal validation in a way that works on unpatched Postgres

To be clear, the action plan here is that @elprans validates if there's no way we can use some Postgres function to tell if there's an explicit TZ in a date/time string or not.  If there's no such way, then @vpetrovykh will probably implement some rudimentary date parsers in EdgeQL/SQL/PlSQL using regexps.

I have the good news, and the bad news.
The good news is that the following is a way to detect whether an explicit timezone was specified in the literal or not:
create or replace function dt(spec text)
returns timestamptz
language plpgsql AS $$
DECLARE
    result timestamptz;
    chk timestamptz;
BEGIN
    result := spec::timestamptz;
    PERFORM set_config('TimeZone', 'America/Toronto', true);
    chk := spec::timestamptz;

    IF result != chk THEN
        RAISE EXCEPTION 'bad date';
    END IF;

    RETURN result;
END;
$$;

Assuming EdgeDB Postgres sessions are always using 'UTC' as the timezone (as they should), we can temporarily switch the server timezone and compare the result of coercion.
The bad news is that the function above is 47 times slower than a pure cast.  60% of that slowdown comes just from the config shenanigans, and the rest is the PL/pgSQL overhead.  Replacing the config trick with a simple regexp nets a 20x slowdown relative to a cast.
So, if we are looking to keep performance reasonable here, then we must avoid using PL/pgSQL at all and implement parsing in pure SQL, e.g
create or replace function dt(spec text)
returns timestamptz
language sql AS $$
  SELECT
    CASE WHEN spec !~ 'check-regexp' THEN
        raise_exception('bad date', NULL::timestamptz)
    ELSE
        spec::timestamptz

    END;

$$;

This version, depending on the complexity of the condition is relatively close to a cast.

Unassigning this -- this issue is up for grabs.

Here's the big reason why we wanted to patch Postgres's handling of to_timestamp. Basically, it treats the format string so loosely that it's virtually impossible for it to fail. The input characters don't quite match the format? No problem, skip the correct number of characters and move on. The input doesn't actually have something from the format? No problem, just ignore it and see if it gets you any result.
E.g. from Postgres docs:

Ordinary text is allowed in to_char templates and will be output literally. You can put a substring in double quotes to force it to be interpreted as literal text even if it contains template patterns. For example, in '"Hello Year "YYYY', the YYYY will be replaced by the year data, but the single Y in Year will not be. In to_date, to_number, and to_timestamp, literal text and double-quoted strings result in skipping the number of characters contained in the string; for example "XX" skips two input characters (whether or not they are XX).

postgres=# SELECT to_timestamp('          2020~01/01 01"02"03 +0009', 'YYYY-MM-DD HH24:MI:SS "TZ"TZH');
      to_timestamp
------------------------
 2019-12-31 11:02:03-05
(1 row)

postgres=# SELECT to_timestamp('   2020~01/01 01"02"03 +09', 'YYYY-MM-DD HH24:MI:SS "TZ"TZH');
      to_timestamp
------------------------
 2019-12-31 11:02:03-05
(1 row)

postgres=# SELECT to_timestamp('   2020~01/01 01"02"03 +9', 'YYYY-MM-DD HH24:MI:SS "TZ"TZH');
      to_timestamp
------------------------
 2020-01-01 01:02:03-05
(1 row)

And what I kinda expected the correct input to look like:
postgres=# SELECT to_char('2019-12-31 11:02:03-05'::timestamptz, 'YYYY-MM-DD HH24:MI:SS "TZ"TZH');
          to_char
---------------------------
 2019-12-31 11:02:03 TZ-05
(1 row)

So it is not sufficient to detect the presence of the special parsing tokens for the timezone in the converter spec to guarantee that the converter function will actually produce the right result. We will need to use the config trick with changing time zones to validate the result as well.