Helm Chart Ingress

# ingress-route.yaml
---
apiVersion: traefik.containo.us/v1alpha1
kind: IngressRoute
metadata:
  name: minecraft
  namespace: minecraft
spec:
  entryPoints:
    - 25565/tcp
  routes:
    - match: HostSNI(`*`)
      kind: Rule
      services:
        - name: svc-minecraft
          port: 25565

and
kind: IngressRouteTCP

is not an option . How to proceed?
💡N.B.: Installed via Helm with this chart on EKS on AWS behind Traefik.
References | Similar Issues:

Traefik Documentation
Traefik Community
Reddit

I would suggest building a composite helm chart that applies the resource you showed with the Minecraft chart as a dependency.

You can also add extra objects into the extraDeploy array. I use this to kick off a job that adds dns records.
https://github.com/itzg/minecraft-server-charts/blob/157686c9629b68320f13c7c7f8b3fc198caed7f3/charts/minecraft/values.yaml#L132


Remove usage of docker in Gardener, such that Gardener can use OS images without docker daemon installed

How to categorize this issue?

/area control-plane
/kind enhancement
/priority 3
What would you like to be added:
docker is still used in Gardener internals:

The systemd unit responsible for downloading the cloud-config depends on the docker systemd unit: https://github.com/gardener/gardener/blob/2788f29310bb23faa224a72bbf946f12136e0f5f/pkg/operation/botanist/component/extensions/operatingsystemconfig/downloader/downloader.go#L138-L140

This probably makes sense, as the unit runs the script below, which uses docker

Gardener preloads the hypercube image and uses docker to extract the binaries for kubelet and kubectl: https://github.com/gardener/gardener/blob/2788f29310bb23faa224a72bbf946f12136e0f5f/pkg/operation/botanist/component/extensions/operatingsystemconfig/executor/templates/scripts/execute-cloud-config.tpl.sh#L80-L106
Promtail uses a similar mechanism like above to extract the binary from an image: https://github.com/gardener/gardener/blob/2788f29310bb23faa224a72bbf946f12136e0f5f/pkg/operation/botanist/component/extensions/operatingsystemconfig/original/components/promtail/component.go#L60
The root certificate updater restarts the docker daemon after updating the certs: https://github.com/gardener/gardener/blob/2788f29310bb23faa224a72bbf946f12136e0f5f/pkg/operation/botanist/component/extensions/operatingsystemconfig/original/components/rootcertificates/component.go#L62
Gardener tunes some kernel parameters for docker-specific reasons: https://github.com/gardener/gardener/blob/2788f29310bb23faa224a72bbf946f12136e0f5f/pkg/operation/botanist/component/extensions/operatingsystemconfig/original/components/kernelconfig/component.go#L89-L97

We should remove any usage of docker in Gardener, such that Gardener can use OS images without docker daemon installed.
Proposal:

For downloading/preloading images and extracting binaries, we can replace docker with an alternative CLI which uses containerd instead: ctr  should be installed on the OSes supporting containerd already today. Alternatively, there is nerdctl, which offers a UX similar to docker, but supports additional stuff like lazy-pulling (which might come in handy specifically for extracting single binaries from an image: https://github.com/containerd/nerdctl/blob/master/docs/stargz.md)
Drop the daemon reload after updating root certificates
Investigate if kernel parameter tuning is still necessary/valid when using containerd. We might be able to remove this entirely or need very different optimizations

Additional considerations:
Before creating an OS image without support for docker, there's a couple of other things to consider:

Remove the migration step in the CloudProfile controller, adding docker into the list of supported runtimes for each image: https://github.com/gardener/gardener/blob/a82aed23505004b507796b9f47a12f19b98d8fe6/pkg/controllermanager/controller/cloudprofile/cloudprofile_control.go#L122-L132
Remove the validation in https://github.com/gardener/gardener/blob/6f878c51682ba75f8c6281b9f68d5a37998b2b8d/pkg/apis/core/validation/cloudprofile.go#L311-L313, added with https://github.com/gardener/gardener/pull/6480.
TODO: more considerations here

Why is this needed:
While it is possible for users to specify containerd to run their workload containers, Gardener still requires the docker daemon to be present and working in the OS images used for the worker nodes.

ctr images mount seems like a missing puzzle piece in this story: https://github.com/containerd/containerd/pull/4210

I guess this issue can be closed when the new gardener-node-agent is getting introduced. cc @timebertt @majst01 @Gerrit91

I guess this issue can be closed when the new gardener-node-agent is getting introduced. cc @timebertt @majst01 @Gerrit91

Actually, it seems that there is another usage of docker cp: https://github.com/gardener/gardener/blob/master/pkg/component/extensions/operatingsystemconfig/original/components/valitail/component.go#L63-L65

With https://github.com/gardener/gardener/pull/8707, we have adapted the extensions.gardener.cloud/v1alpha1.OperatingSystemConfig API as follows:

.spec.units now has a new field files[] of type []extensionsv1alpha1.File
extensionsv1alpha1.FileContent allows to configure an image reference:spec:
  units:
  - name: kubelet.service
     files:
     - path: /opt/bin/kubelet
        permissions: 0755
        content:
          imageRef:
            image: eu.gcr.io/gardener-project/hyperkube:v1.28.1
            filePathInImage: /kubelet

gardener-node-agent will take care of extracting such binaries from images and copy them to the host (via https://github.com/gardener/gardener/blob/master/pkg/nodeagent/registry/containerd_extractor.go), and then restart the affected units.
This approach will handle:

kubelet binary for the kubelet.service unit
kubectl binary for the kubelet-monitor.service unit (and human operations tooling)
valitail binary for the valitail.service unit (ref)
gardener-node-agent binary for the gardener-node-agent.service unit (GNA performs a "self-upgrade")

In the gardener-node-init script (used for bootstrapping the gardener-node-agent on initial VM/node provisioning), we plan to use ctr as suggested in https://github.com/gardener/gardener/issues/4673#issuecomment-1507003507 (we already expect it to be present on nodes with containerd since a long time as documented in https://github.com/gardener/gardener/blob/master/docs/extensions/operatingsystemconfig.md#contract-operatingsystemconfig-resource).
TL;DR
With above approaches, we get rid of all usages of docker cp and can close this issue as soon as #8023 is closed (as soon as gardener-node-agent is GA).

What a achievement !

What a achievement !

This is massive. Thanks everybody for contributing!


CI accepts --pre option to install rc version automatically

Is your feature request related to a problem? Please describe.
The feature request is about CI of the bundles. When we are working on the rc version of MONAI, we will need to update the monai_version in the bundles to target the release candidate.
For example, @KumoLiu has this change in her PR:
https://github.com/Project-MONAI/model-zoo/pull/575/files
The issue is we need to update the monai_version every time we have a new rc of monai, even though nothing needs to be changed in the bundle.
Describe the solution you'd like
Add an option use_rc_if_applicable in the CI scripts. When it's false, everything stays as it is. When it's true, it can accept the rc version if the official version is not released yet for CI runs.
For example, in release 1.4, when we want to start the release candidate, we can just put the monai_version in the bundles to 1.4. And the CI will actually install the latest 1.4 rc version.
We can keep the switch false most of the time, and only turn it on when the monai is in rc cycle.

For vis @yiheng-wang-nv @KumoLiu @Nic-Ma


Although this configuration CONFIG_BRIDGE_NETFILTER=y is enabled, there is no such file in /sys/module/br_netfilter

Description
Compile kernel with configuration CONFIG_BRIDGE_NETFILTER=y is enabled.
When using the kernel which I was compiled, I can not found br_netfilter file in /sys/module directory. How can I check the br_netfilter module already loaded?
Other modules I enabled can be found in the /sys/module directory such as CONFIG_VXLAN=y.
The same result when I try using  io.katacontainers.config.agent.kernel_modules: "br_netfilter".
Environment
Running k3s in Kubernetes Kata Runtime Pods.
Expected result
br_netfilter file in /sys/module directory after enable kernel config item.
Actual result
I can not found br_netfilter file in /sys/module directory.

Hi @Jason-ZW - if you set CONFIG_BRIDGE_NETFILTER=y, there will be no netfilter module - it will be built (hard-coded) into the kernel (not loaded dynamically), hence no entry in /sys/module/. It should be listed in /lib/modules/$(uname -r)/modules.builtin though.
Note that this touches on the idea of requireing a /proc/config.gz which would provide another way to see what features the guest kernel supports: https://github.com/kata-containers/packaging/issues/222.
@bergwolf, @gnawux, @amshinde - Maybe we want to consider adding this for 2.0?

@jodh-intel Thanks for help me.

@Jason-ZW - no problem. Can we close this issue now?

Sure


[DPG]: Determine client option class name for multiple top-level clients

Describe the issue or request
Right now, we have the following logic to determine the name of a DPG client option class: https://github.com/Azure/autorest.csharp/blob/3aeed711ebbd9e254e29449d755ebb8afde52572/src/AutoRest.CSharp/LowLevel/Output/DpgOutputLibraryBuilder.cs#L102-L106
If there are multiple top-level clients, the class name is from:

Configuration LibraryName
namespace name if above is not available.

However, right now there is no source input for  LibraryName in Configuration.json, so the class name will always come from namespace, which sometimes is too long.
https://github.com/Azure/autorest.csharp/blob/3aeed711ebbd9e254e29449d755ebb8afde52572/test/TestProjects/PetStore-Cadl/Generated/Configuration.json#L4
Describe your ideas for solutions
We should define the source for LibraryName.

For Augst MVP, we can work around by manually editing the Configuration.json to update the LibraryName property to a proper value, so that the generated client option class has a good name.

we will auto gen Configuration.json from cadl and cadl-project.yaml. Then this issue will be resolved. duplicate https://github.com/Azure/autorest.csharp/issues/2755

@archerzz, could you help to verify this problem is resolved?

@archerzz, could you help to verify this problem is resolved?

Verified. For CADL project, LibraryName will be first used to compose the ClientOptions class name. So if I try the following command:

node<EMAIL_ADDRESS>compile --emit @azure-tools/cadl-csharp .\samples\confidentialledger\main.cadl --output-path .\samples\confidentialledger\ --option @azure-tools/cadl-csharp.library-name=Ledger

I'll get LedgerClientOptions class for both ConfidentialLedgerClient and IdentityClient.


Create Spring-instantiable concrete ClientsFactory class

Fixes https://github.com/pac4j/pac4j/issues/202
Create a concrete class ClientsFactoryDIImpl that implements ClientsFactory and provides a constructor taking a List. This list is returned as a Clients object when build() is called on the object, and the environment argument to build() is ignored.
Please also review @mmoayyed.

Thanks for your contribution. My main comment is that you should have four constructors mapping to the four constructors of the Clients class.
The test class is a good thing.
I let you update the PR with all comments before I'll merge.

+1
@mmoayyed : are we good for the merge?

Yup. Go ahead please. :+1:


using identity reboot with identity server

Hui,
Since Identity reboot derives from asp.net identity, what is the best/easiest way of using this with Identity server?
Kind regards
Sean.

Just use the regular ASP.NET Identity and plug in IR where it normally gets plugged in.

Thanks. Is there integration for identity manager/managing users from identity servers ui?
Cheers
Sean.
From: Brock Allen<EMAIL_ADDRESS>Sent: 18 July 2016 13:55
To: IdentityServer/IdentityServer3.AspNetIdentity<EMAIL_ADDRESS>Cc: Sean Farrow<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [IdentityServer/IdentityServer3.AspNetIdentity] using identity reboot with identity server (#73)
Just use the regular ASP.NET Identity and plug in IR where it normally gets plugged in.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/IdentityServer/IdentityServer3.AspNetIdentity/issues/73#issuecomment-233320191, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABY1fi9Zf7dcfa2e0xPyIINP6QpmGJ1Mks5qW3e8gaJpZM4JOXGi.

No, that's no IdSvr's job. You can always use IdentityManager, but it's technically separate.

So, do I need to plugin ir in to identity server. I'm thinking due to the adaptive password hashing/2fa stuff, or does it just go in to the app.
Confused!
Cheers
SEan.

IR just provides a replacement for the hashing API -- that's it. The rest is mainly the same as ASP.NET Identity.


Version info in app is misleading

Looking at the version on the releases page shows it is version 1.3. However, the app seems to indicate it is version 1.0. Is this done on purpose?

You're absolutely right. We just did some releases on github, but never bothered to update the version number in the app.
We'll start doing this with all our future releases.


(addons aws-calico): Calico uses deprecated chart

Describe the bug
According to AWS documentation and eks-charts repo, the helm chart referenced by calico add-on has been deprecated and no longer maintained.
Expected Behavior
Use the recommended Calico Operator instead.
Current Behavior
N/A
Reproduction Steps
N/A
Possible Solution
No response
Additional Information/Context
No response
CDK CLI Version
any
EKS Blueprints Version
latest
Node.js Version
any
Environment details (OS name and version, etc.)
any
Other information
No response

Also see https://github.com/aws-samples/eks-blueprints-add-ons/pull/78

Please see the above comment. The deprecated add-on will be removed in a few releases.


Remove some seemingly dead code in the CMakeLists.txt

Was this doing something? The parts of AvA I am using seem to build without it.

Is there any integration testing script that would check whether this change breaks things?

Good to be removed. Quite some time ago I was trying to maintain dependencies with conan.


inform user if tsconfig.json is not found

I ran into the pb described in https://github.com/Microsoft/TypeScript-Sublime-Plugin/issues/213, and, indeed, setting "typescript_tsdk" in Package settings in order to locate the ts lib has fixed this pb.
I spent quite an hour to investigate the issue, and I think most newcomers are likely to run into this, so it should be a good think :

to document this
and to inform the user if no tsconfig.json was found by the compiler

Actually, I was wrong : ST doesn't still found tsconfig.json.
I was messed by Visual Studio Code which was opened at the same time.
If I don't open VSC, ST doesn't found the file.
I close this issue, since the description of the trouble was not relevant.


....\github.com\go-chassis\go-chassis\metrics\prom\prometheus.go:164:83: too many arguments in call to prometheus.NewProcessCollector

....\github.com\go-chassis\go-chassis\metrics\prom\prometheus.go:164:83: too many arguments in call to prometheus.NewProcessCollector
have (int, string)
want (prometheus.ProcessCollectorOpts)
the params of function NewProcessCollector has changed in the latest prometheus/client_golang/process_collector.go file

you are using which version or master branch?

master branch
cause company can not use go get

you can use go mod in public internet to download vendor and send back to internal network


Add command line gate for changing a release's chart

We author many charts and make many releases. Sometimes we screw up and overwrite an existing release by running a helm install with the name of an existing release that's on a different chart.
It would be nice to have a flow like:
$ helm ls
my-release                   the-app      525             2022-09-09 15:23:22.440161232 +0000 UTC deployed        my-chart-0.1.242
$ helm install --upgrade my-release my-other-chart ...
ERROR release is already installed with chart `my-chart`. In order to replace with `my-other-chart` use `--allow-chart-change`

This would require storing that information in the release object. Please review the HIP related to this proposal and add any feedback you might have. Once that feature is implemented, this wouldn't be that difficult to implement.


Identify Parent from a Child's perspective.

Can we identify/retrieve the parent view and the data associated with it from a child view? If so, how is it done?

@rohanmahale In the dev branch we have the ability to get the index information of the parent and child from a child view. From there you should be able to pull data associated from your data constructs. Give it a shot, instructions on how to get the SNAPSHOT build are in the readme: https://github.com/bignerdranch/expandable-recycler-view/tree/dev

Hi @paul-turner . It seems to be working quite well. I'm still testing.
Another issue, I'm facing currently is with the notify... methods. In my case my parents and children all have checkboxes. Selecting a parent triggers selection on all children. Selecting all children triggers selection of the parent(sort of a tree structure).  I've tried using the notifyParentItemChanged since it triggers listeners on the children, however I get index out of bounds exceptions eventually, when i keep selecting/deselecting.  With notifyDataSetChanged, I do not have this problem.
Any idea why this might be happening? (I hope I've explained it clearly - Do let me know if I have not)

Hmmm, off the top of my head:
Either we have a bug inside the notifyParentItemChanged method or the index being passed in to the method is incorrect in some way. Would start by double checking the right parent index is given (which it should be if you are using those new adapter methods). Or there might be a bug within getParentAdapterPosition()
Would need some more information to try and track those down, which indices it seems more likely to crash on, size of the list, any other peculiar information etc.


Required (and optional) dicts not appearing in json/yaml

A basic example in of
mod_graph0 = Graph(id="Test")
produces the json
{
    "Test": {}
}

and yaml
Test: {}

which are missing entries "nodes": {} and "edges": {} . These are listed as required in the README spec. "parameters": {} and "conditions": {} are also missing, but these are listed as optional. Similarly, parameters is missing from Node if unspecified, although this isn't explicitly mentioned in the spec as required or not.
We should either update the to_json and to_yaml methods for Graph (or the underlying neuromllite classes) to always generate nodes and edges entries,  or update these in the spec as optional. If we do the former, I think we should also consider including empty entries for parameters and conditions as well.

This is the intended behaviour and for maximum flexibility and producing what the programmer probably wants to happen, should be left as such.
However, there is certainly a need for a quick way to get a "best practice" MDF model with all required parts filled in. This can be:

a helper method on Model create_new_mdf_model(model_id, graph_id) which returns a Model with all required elements and possibly some default placeholders added
an optional attribute on to_json etc.: fill_missing_required_elements

That said, it should be assumed by any reader/parser that a missing edges or "edges": {} both imply: there are no edges... A graph is a graph and by definition it can have some edges, if a serialised graph doesn't say anything about edges, it is still a graph, but with no edges.


Integrate postprocessing

new PR 'cause #54 didn't work

Quast wants to compile BWA?? https://github.com/koesterlab/snakemake-workflow-sars-cov2/pull/66/checks?check_run_id=1960619229#step:14:704
Was that the case before as well? That's crazy. Can we avoid that somehow? Maybe by adding the bwa conda package to the quast environment?

Quast wants to compile BWA?? https://github.com/koesterlab/snakemake-workflow-sars-cov2/pull/66/checks?check_run_id=1960619229#step:14:704
Was that the case before as well? That's crazy. Can we avoid that somehow? Maybe by adding the bwa conda package to the quast environment?

That's because the assembly (after filtering with the new combined reference) does not contain contigs, which are longer than 500 bp. See: https://github.com/koesterlab/snakemake-workflow-sars-cov2/pull/66/checks?check_run_id=1960619229#step:14:699.
Thc contigs have around 200 bp length now. The new filtering with the combined reference seems to be the reason for this.
I'm currently testing in #73 the --min-contig (Lower threshold for a contig length (in bp). Shorter contigs won't be taken into account (except for specific metrics, see section 3). The default value is 500.) with a value of 1.
However, it is quite strange, that assembly only contains such small contigs. Tomorrow we'll have a closer look at the assembly of the test data with filtering only using the human reference and then with the combined reference.


Fixed invalid cpacs after write

Description
Before, the guide curve fromCircumeferenceValue was set
by TiGL after connecting the guide curves. If a curve had set
fromGuideCurveUID, both values were written to XML, which
is not allowed.
Now, I added the method CCPACSGuideCurve::GetFromRelativeCircumference
such that an external code can ask for the circumference value, even
if fromGuideCurveUID is set. This was suggested by Roland.
There are many benefits by this approach:

More functional approach with less side effects
Fixed invalid xml
Simpler use of the guide curve. Simplifies calling code
Better code design that adheres better
to the single responsibilty principle

Closes #665

How Has This Been Tested?
I ran unit tests and loaded the guide curve example in TiGL Viewer.
Screenshots, that help to understand the changes(if applicable):
Checklist:

[ ] A test for the new functionality was added.
[x] All tests run without failure.
[x] The new code complies with the TiGL style guide.
[ ] New classes have been added to the Python interface.
[ ] API changes were documented properly in tigl.h.

Codecov Report

Merging #792 (52eb567) into master (7320a3c) will decrease coverage by 0.10%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master     #792      +/-   ##
==========================================
- Coverage   62.54%   62.44%   -0.11%
==========================================
  Files         290      290
  Lines       23403    23376      -27
==========================================
- Hits        14637    14596      -41
- Misses       8766     8780      +14

Impacted Files
Coverage Δ

src/fuselage/CCPACSFuselage.cpp
64.72% <ø> (-4.13%)
:arrow_down:

src/fuselage/CCPACSFuselage.h
100.00% <ø> (ø)

src/wing/CCPACSWing.cpp
78.88% <ø> (-1.89%)
:arrow_down:

src/wing/CCPACSWing.h
100.00% <ø> (ø)

src/wing/CCPACSWingSegment.cpp
81.13% <0.00%> (ø)

src/guide_curves/CCPACSGuideCurve.cpp
78.43% <85.71%> (+1.15%)
:arrow_up:

...fuselage/CTiglFuselageSegmentGuidecurveBuilder.cpp
89.47% <100.00%> (+6.14%)
:arrow_up:

src/wing/CTiglWingSegmentGuidecurveBuilder.cpp
88.09% <100.00%> (+5.48%)
:arrow_up:

src/guide_curves/CCPACSGuideCurves.cpp
63.26% <0.00%> (-10.21%)
:arrow_down:

... and 1 more

Nice!


Add content_for_header, unless & comment snippets

@rickydazla can you rebase it with the current branch to make it mergable?

Sure @puranjayjain – it's done : )

@rickydazla This will be released in the next minor release this week.

:sunglasses:


python312Packages.great-tables: fix on darwin

Description of changes
One test on darwin was failing with:
>       self.socket.bind(self.server_address)
E       PermissionError: [Errno 1] Operation not permitted
/nix/store/9pj4rzx5pbynkkxq1srzwjhywmcfxws3-python3-3.12.5/lib/python3.12/socketserver.py:473: PermissionError

Adding __darwinAllowLocalNetworking fixed it.

python312Packages.great-tables: cleaning
python312Packages.great-tables: allow local networking on darwin to fix a failing test

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.


test delete

About the PR

Why / Balance

Technical details

Media

Requirements

[ ] I have read and am following the Pull Request and Changelog Guidelines.
[ ] I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

wrong repo?

oh shit, im sorry. was was blindly following the dev tutorial...


[CH-186] support RangePartitioning

Changelog category (leave one):

Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
see issue #186
We implement RangePartitionNativeSplitter in this pr which support running range partitioning in native backend.
Some benchmark test by running order by.

data type
rows
eclapsed time(s) by gluten
eclapsed time(s) by spark

long
69498916
6.9
8.5

long
208496748
13.5
22.8

string
69498916
10.5
26.5

string
208496748
23.9
71.3

Information about CI checks: https://clickhouse.tech/docs/en/development/continuous-integration/

Can one of the admins verify this patch?

rely on https://github.com/oap-project/gluten/pull/524

test this please with 524

test this please with 524

test this please with 524

test this please with 524

test this please with 524

As comment, there is a optimization to do:

clickhouse backend consume data from JVM, but not sort the block at once, instead, we read the data and do nothing until memory limit is reached or all data is consumed
sort the data, here if memory limit is reached first, we then flush the sorted data to disk, and do 1; else return the output data stream.
do merge sort on the flushed data, and then return the output data stream.

test this please with 524

test this please with 524


Add action: test tutorials, on push to any PR, split action if turnaround > 15 mins

Notebooks are located in:
https://github.com/devitocodes/devito/tree/master/examples/cfd
https://github.com/devitocodes/devito/tree/master/examples/compiler
https://github.com/devitocodes/devito/blob/master/examples/mpi/overview.ipynb
https://github.com/devitocodes/devito/tree/master/examples/seismic/tutorials
https://github.com/devitocodes/devito/tree/master/examples/userapi


build: as submodule, cancel add_test()

if we use etcd-cpp-apiv3 as submodule, we don't need to test etcd-cpp-apiv3.
in CMakeLists.txt
enable_testing()
add_subdirectory(src)
add_subdirectory(tst)

this code force to set add_test() and maybe make the project failed to unit tests.
Signed-off-by: zhang.han<EMAIL_ADDRESS>

Thanks for fixing.

Thanks for fixing.

my pleasure


Reset Plaid steps if the screen is blurred

Details
Reset Plaid steps if the screen is blurred.
Fixed Issues
$ https://github.com/Expensify/App/issues/23888
PROPOSAL: https://github.com/Expensify/App/issues/23888#issuecomment-1657243651
Tests

Open the app
Open settings
Open workspaces and open any workspace
Open bank account
Click on 'Connect online with plaid' and while loading, click on get assistance icon in header.
Verify that the app doesn't open the next step of 'Connect online with plaid'.

[x] Verify that no errors appear in the JS console

Offline tests

N/A
QA Steps
Same as tests

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/13113013/b8ded282-ac2e-49b3-a75a-18aa7f6f96d8

Mobile Web - Safari
https://github.com/Expensify/App/assets/13113013/198b2f03-32f7-439c-a0f0-d0e04c4fb2b8

Mobile Web - Chrome
https://github.com/Expensify/App/assets/13113013/00062b8d-095d-4f93-bc30-dbf6cc47e6ce

Desktop
https://github.com/Expensify/App/assets/13113013/3fffda8c-165b-447f-8ab6-89d28b791aab

iOS
https://github.com/Expensify/App/assets/13113013/95323ca3-9a4b-4d06-a7d6-14a38f89d800

Android
https://github.com/Expensify/App/assets/13113013/07914303-8041-4514-8b99-771f3f665f5b

Therefore, I introduce a new prop called shouldResetStepOnBlur because in (2), we call Navigation.goBack when exiting.

@ginsuma Instead of this way, In AddPlaidBankAccount we can expose a function similar to onExitPlaid like onBlurPlaid and make the client components use it accordingly. This will make the function more generic and easy to use.

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

https://github.com/Expensify/App/assets/46707890/8a7fbea4-42dc-429e-97a3-a12fc33cff09
https://github.com/Expensify/App/assets/46707890/2f83bdc9-36e6-4f8c-9113-4a2dfa8595c0
https://github.com/Expensify/App/assets/46707890/74f16ea4-d718-4374-a853-2ce0a8eb9173
https://github.com/Expensify/App/assets/46707890/28eadf2f-3863-4637-b975-1f15047e2d1d
https://github.com/Expensify/App/assets/46707890/6d668da2-54e6-4f1d-af8e-a99e3be0cf47
https://github.com/Expensify/App/assets/46707890/6941fa1e-ab18-45f6-9480-29d93183d33f

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/tylerkaraszewski in version: 1.3.71-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.71-12 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Conditionally enqueued assets are not included in static files

In my WordPress theme, I conditionally enqueue a stylesheet based on if the dashicons core stylesheet is enqueued (effectively, if the admin bar is showing or not). This means that for logged-in users, my stylesheet is not loaded, and for guest users, it is loaded.
I'm not sure how deep this goes, but slightly concerned that conditionals concerning admin vs guest aren't being considered.

My apologies; got caught previewing a build, which has a different URL from the one the static files are generated with.


Extension: Disable virtual file from reloading on refocus

I have an extension, that opens a "Virtual File" (I think that is what it is called). The file has a input textbox and which when you type filters a table by showing/hiding rows. When you switch tabs, then come back to the virtual file, the input has been cleared and the table reloaded.
Is there a way to make it so that the tab doesn't get reloaded when it is refocused?
Here is how I am initiating the creation of the virtual file:
    protected static async openVirtualFile(path: string, title: string, content: string) {
        let uri = Uri.parse('laravel-artisan://artisan/' + path);
        let doc = await workspace.openTextDocument(uri);
        let edit = new WorkspaceEdit();
        let range = new Range(0, 0, doc.lineCount, doc.getText().length);
        edit.set(uri, [new TextEdit(range, content)]);
        workspace.applyEdit(edit);
        commands.executeCommand('vscode.previewHtml', uri, ViewColumn.One, title);
    }

/duplicate of #36310


Migrate to WinUI3

Uno Platform project target to WinUI 3, when import ToastNotification.Uno will show error when building:
Error	UNOB0001	Cannot build with both Uno.WinUI and Uno.UI nuget packages referenced.

https://github.com/lld1995/ToastNotification.Uno/commit/0a2438678de68bafdd596f480f0b05b2bb748ab2


Channel listings in Mapping only listing channels from first filter

Describe the bug
Whatever I do, it seems I cannot add more channels into the mapping list when I add more than the 1st filter.  Tried many permutations but when I add more filters it only shows those reflected by first filter
Server (please complete the following information):

Ubuntu
Intel 64 Bit
xTeVe Version: 2.20

To Reproduce
Steps to reproduce the behavior:

Go to Filter - add CA:
Click on Mapping - CA: channels will be there
Go back to filter - add US: - available stream count goes up and list on the top left is added
Click on Mapping -  US: channels are not added

Expected behavior
Add channels matching filter should be in the mapping section
Screenshots
Add Custom Filter with just 3 Canada channels - see 3 channels added

Channels are added in mapping

Go back to filter and add 1 more US channel - also reflected and showing 4 in available streams

Go to Mapping and the 4th channel is not added

Desktop (please complete the following information):

Windows 10
Chrome
90.0.4430.85 (Official Build) (64-bit)

Additional context
Add any other context about the problem here.

been using xteve for a number of years and it's self-sufficient, until recently I noticed my mapped channels randomly disappeared, and came across this.  Mappings section used to update normally as that was my usually way of mapping channels.  the IDs aren't auto mapping my channels unfortunately so I am forced to do them manually in the Mappings section.

also.. going back to first filter and updating it will not update mappings either

This is a Bug in the calculation of the m3u Channel Hash.
If a Channel has no GroupTitle, TVGID,TVGName, UUID KEy or UUID Value the same hash will be calculated cause all Strings are empty.:

A simple HotFix would be to use the Channelname as a Parameter for the Hash. But then U can only have one Channel with the same Name. Or a Channel shouldn't be exist without all these Informations...

Same problem here, they show in (as filtered) but don't show in mappings.

Why are you guys using Custom Filters? Whats wrong with group filtering?

Why are you guys using Custom Filters? Whats wrong with group filtering?

I, for example, have sometimes playlists that have no groups. Only channels with prefixes.

And the Custom Filters are not picking up on a keyword contained in the m3u entry?


[Doc Improvement] [Update Branding and SEO][3715679]

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/toolkit/test-app-behavior.md
100
3
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/toolkit/publish.md
92
12
link
:white_check_mark:

msteams-platform/toolkit/test-app-behavior.md
100
3
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/toolkit/publish-your-teams-apps-using-developer-portal.md
94
3
link
:white_check_mark:

msteams-platform/toolkit/publish.md
92
12
link
:white_check_mark:

msteams-platform/toolkit/test-app-behavior.md
100
3
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/toolkit/publish-your-teams-apps-using-developer-portal.md
94
3
link
:white_check_mark:

msteams-platform/toolkit/publish.md
92
11
link
:white_check_mark:

msteams-platform/toolkit/teams-toolkit-tutorial.md
100
0
link
:white_check_mark:

msteams-platform/toolkit/test-app-behavior.md
100
3
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/toolkit/faq.md
86
13
link
:white_check_mark:

msteams-platform/toolkit/publish-your-teams-apps-using-developer-portal.md
94
3
link
:white_check_mark:

msteams-platform/toolkit/publish.md
92
11
link
:white_check_mark:

msteams-platform/toolkit/teams-toolkit-tutorial.md
100
0
link
:white_check_mark:

msteams-platform/toolkit/test-app-behavior.md
100
3
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/toolkit/faq.md
86
13
link
:white_check_mark:

msteams-platform/toolkit/publish-your-teams-apps-using-developer-portal.md
94
3
link
:white_check_mark:

msteams-platform/toolkit/publish.md
92
11
link
:white_check_mark:

msteams-platform/toolkit/teams-toolkit-tutorial.md
100
0
link
:white_check_mark:

msteams-platform/toolkit/test-app-behavior.md
100
3
link
:white_check_mark:

msteams-platform/toolkit/toolkit-v4/teams-toolkit-fundamentals-vs.md
97
3
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/toolkit/faq.md
86
13
link
:white_check_mark:

msteams-platform/toolkit/publish-your-teams-apps-using-developer-portal.md
94
3
link
:white_check_mark:

msteams-platform/toolkit/publish.md
92
11
link
:white_check_mark:

msteams-platform/toolkit/teams-toolkit-tutorial.md
100
0
link
:white_check_mark:

msteams-platform/toolkit/test-app-behavior.md
100
3
link
:white_check_mark:

msteams-platform/toolkit/toolkit-v4/explore-Teams-Toolkit-vs.md
90
6
link
:white_check_mark:

msteams-platform/toolkit/toolkit-v4/install-Teams-Toolkit-vs.md
94
3
link
:white_check_mark:

msteams-platform/toolkit/toolkit-v4/teams-toolkit-fundamentals-vs.md
97
3
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/toolkit/faq.md
86
13
link
:white_check_mark:

msteams-platform/toolkit/publish-your-teams-apps-using-developer-portal.md
94
3
link
:white_check_mark:

msteams-platform/toolkit/publish.md
92
11
link
:white_check_mark:

msteams-platform/toolkit/teams-toolkit-tutorial.md
100
0
link
:white_check_mark:

msteams-platform/toolkit/test-app-behavior.md
100
3
link
:white_check_mark:

msteams-platform/toolkit/toolkit-v4/explore-Teams-Toolkit-vs.md
90
6
link
:white_check_mark:

msteams-platform/toolkit/toolkit-v4/install-Teams-Toolkit-vs.md
94
3
link
:white_check_mark:

msteams-platform/toolkit/toolkit-v4/teams-toolkit-fundamentals-vs.md
97
3
link
:white_check_mark:

msteams-platform/toolkit/toolkit-v4/tools-prerequisites-v4.md
93
15
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/toolkit/faq.md
86
13
link
:white_check_mark:

msteams-platform/toolkit/publish-your-teams-apps-using-developer-portal.md
94
3
link
:white_check_mark:

msteams-platform/toolkit/publish.md
92
11
link
:white_check_mark:

msteams-platform/toolkit/teams-toolkit-tutorial.md
100
0
link
:white_check_mark:

msteams-platform/toolkit/test-app-behavior.md
100
3
link
:white_check_mark:

msteams-platform/toolkit/toolkit-v4/create-new-project-vs.md
93
7
link
:white_check_mark:

msteams-platform/toolkit/toolkit-v4/explore-Teams-Toolkit-vs.md
90
6
link
:white_check_mark:

msteams-platform/toolkit/toolkit-v4/install-Teams-Toolkit-vs.md
94
3
link
:white_check_mark:

msteams-platform/toolkit/toolkit-v4/teams-toolkit-fundamentals-vs.md
97
3
link
:white_check_mark:

msteams-platform/toolkit/toolkit-v4/tools-prerequisites-v4.md
93
15
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Closing this PR


SessionStorage provided wrong type in core.js

I am attempting to use sessionStorage in a project, but flow provides a bad type of Location.
I believe the bug is in https://github.com/facebook/flow/blob/02515d2074db14a89d70147c4e8ac36043f915d8/lib/core.js#L509.
Example code to reproduce would be:
/* @flow */
if (sessionStorage.getItem('currentUser'))
{
    console.log("OK");
}

The provided error message is:
/home/ethan/test/foo/test.js:3:5,41: call of method getItem
Property not found in
   /tmp/flow_ethan/flowlib_3db57ad7/lib/bom.js:28:1,41:1: Location

Thanks for the report! I took a look and fixed the definition! The fix will be in 0.1.7 next week.

Thanks for the quick fix.


multiple background colors

VSCode Version: 1.7.2
OS Version: mac os 10.12.1

The bounds of the editor view that contain text are a darker background color than the bounds that do not. Is this by design or am I seeing things?
Steps to Reproduce:

open any file with some text present or create a new file.
use a high resolution screen or low zoom level to view the file.
use any included theme - seems to reproduce in all, but harder to see in light themes.

https://github.com/Microsoft/vscode/issues/15126#issuecomment-259123486

@wallverb - thanks, didn't catch all the others :(


MediaDevices.dll does not represent a strongly named assembly

Hi Ralf,
I need to have MediaDevices package to be a strongly named assembly. Is there any signed version available? If not, how do you suggest to sign it?
Thanks & Regards,
Pallavi Garg

Hi Ralf,
Is there any update on this?
Regards
Pallavi

Hi Ralf,
Is there any update on this?
Regards
Pallavi

Hello Pallavi,
what kind of signing do you mean?
On the one hand, you can sign the assembly with a self-made certificate (sn -k ) that does not give you high security and on the other hand you can buy a code signing certificate. This costs a few hundred dollars a year that I do not want to pay.
Why do not you take the DLL and sign it yourself?
al /out:  /keyfile:
Ralf

See https://docs.microsoft.com/en-us/dotnet/standard/assembly/enhanced-strong-naming

However, strong name keys don’t contain any reliable information about the publisher, nor do they contain a certificate hierarchy. A strong name signature does not guarantee the trustworthiness of the person who signed the assembly or indicate whether that person was a legitimate owner of the key; it indicates only that the owner of the key signed the assembly. Therefore, we do not recommend using a strong name signature as a security validator for trusting third-party code. Microsoft Authenticode is the recommended way to authenticate code.

Thanks Ralf for your reply!
We need signing not for security but identity so no monitory cost is involved if you do it.
Please refer to this: https://docs.microsoft.com/en-us/dotnet/standard/library-guidance/strong-naming
Can you please make a signed version available?

You can find the strong name file in the Signed folder.

Thank you so much Ralf. I am closing this issue.


Users/dikhakha/gulp

I don't think we should take this.  Adding build tag to confirm

gulp owned by CIX I believe, added @madhurig


Add Scientific Writing

By @writing-resources @ashwinvis and @maehr
Discussion can be found here https://github.com/sindresorhus/awesome/pull/1700

https://github.com/writing-resources/awesome-scientific-writing
Open source tools for painless academic writing.
This should be included, because academic writing is a hassle.
PRs:

https://github.com/sindresorhus/awesome/pull/1735
https://github.com/sindresorhus/awesome/pull/1635
https://github.com/sindresorhus/awesome/pull/1644

By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request

Don't waste my time. Do a good job, adhere to all the guidelines, and be responsive.
You have to review at least 2 other open pull requests.
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration.
You have read and understood the instructions for creating a list.
This pull request has a title in the format Add Name of List.

✅ Add Swift
✅ Add Software Architecture
❌ Update readme.md
❌ Add Awesome Swift
❌ Add swift
❌ Adding Swift
❌ Added Swift

Your entry here should include a short description about the project/theme of the list. It should not describe the list itself. The first character should be uppercase and the description should end in a dot. It should be an objective description and not a tagline or marketing blurb.

✅ - [iOS](…) - Mobile operating system for Apple phones and tablets.
✅ - [Framer](…) - Prototyping interactive UI designs.
❌ - [iOS](…) - Resources and tools for iOS development.
❌ - [Framer](…)
❌ - [Framer](…) - prototyping interactive UI designs

Your entry should be added at the bottom of the appropriate category.
The suggested Awesome list complies with the below requirements.

Requirements for your Awesome list

Has been around for at least 30 days.That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
Don't open a Draft / WIP pull request while you work on the guidelines. A pull request should be 100% ready and should adhere to all the guidelines when you open it.
Run awesome-lint on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.
The default branch should be named main, not master.
Includes a succinct description of the project/theme at the top of the readme. (Example)

✅ Mobile operating system for Apple phones and tablets.
✅ Prototyping interactive UI designs.
❌ Resources and tools for iOS development.
❌ Awesome Framer packages and tools.

It's the result of hard work and the best I could possibly produce.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
The repo name of your list should be in lowercase slug format: awesome-name-of-list.

✅ awesome-swift
✅ awesome-web-typography
❌ awesome-Swift
❌ AwesomeWebTypography

The heading title of your list should be in title case format: # Awesome Name of List.

✅ # Awesome Swift
✅ # Awesome Web Typography
❌ # awesome-swift
❌ # AwesomeSwift

Non-generated Markdown file in a GitHub repo.
The repo should have awesome-list & awesome as GitHub topics. I encourage you to add more relevant topics.
Not a duplicate. Please search for existing submissions.
Only has awesome items. Awesome lists are curations of the best, not everything.
Does not contain items that are unmaintained, has archived repo, deprecated, or missing docs. If you really need to include such items, they should be in a separate Markdown file.
Includes a project logo/illustration whenever possible.

Either centered, fullwidth, or placed at the top-right of the readme. (Example)
The image should link to the project website or any relevant website.
The image should be high-DPI. Set it to maximum half the width of the original image.

Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
Includes the Awesome badge.

Should be placed on the right side of the readme heading.

Can be placed centered if the list has a centered graphics header.

Should link back to this list.

Has a Table of Contents section.

Should be named Contents, not Table of Contents.
Should be the first section in the list.
Should only have one level of nested lists, preferably none.

Has an appropriate license.

We strongly recommend the CC0 license, but any Creative Commons license will work.

Tip: You can quickly add it to your repo by going to this URL: https://github.com/<user>/<repo>/community/license/new?branch=master&template=cc0-1.0 (replace <user> and <repo> accordingly).

A code license like MIT, BSD, Apache, GPL, etc, is not acceptable. Neither are WTFPL and Unlicense.
Place a file named license or LICENSE in the repo root with the license text.
Do not add the license name or text to the readme. GitHub already shows the license name at the top of the repo.
To verify that you've read all the guidelines, please comment on your pull request with just the word unicorn.

Has contribution guidelines.

The file should be named contributing.md. Casing is up to you.

Has consistent formatting and proper spelling/grammar.

The link and description are separated by a dash. Example: - [AVA](…) - JavaScript test runner.
The description starts with an uppercase character and ends with a period.
Consistent and correct naming. For example, Node.js, not NodeJS or node.js.

Doesn't include a Travis badge.You can still use Travis for list linting, but the badge has no value in the readme.
Doesn't include an Inspired by awesome-foo or Inspired by the Awesome project kinda link at the top of the readme. The Awesome badge is enough.

Go to the top and read it again.

Do not add the license name or text to the readme. GitHub already shows the license name at the top of the repo.

Do not add the license name or text to the readme. GitHub already shows the license name at the top of the repo.

thank you @sindresorhus we fixed it accordingly

The default branch should be named main, not master.

This is a very recent adition to the guidelines, so I don't know how strict @sindresorhus wants to be about it when it comes to previously opened PRs.
Doesn't hurt to change though 😃

@mourarthur Done

Tweet: https://twitter.com/awesome__re/status/1274373790714048513


[SPIR-V] Shared memory limit exceeded for batch matmul dispatch

What happened?
Compiling a phi-2 model for vulkan-spirv backend with target triple rdna2-unknown-linux gives the following error:
failed to translate executables
haldump/configured_state_update_run_initialize$async_dispatch_19.mlir:9:6: error: 'func.func' op uses 1310720 bytes of shared memory; exceeded the limit of 65536 bytes
      func.func @run_initialize$async_dispatch_19_batch_matmul_transpose_b_32xDxDx80_f16xf32xf32() {
    ^
haldump/configured_state_update_run_initialize$async_dispatch_19.mlir:2:2: error: failed to run translation of source executable to target executable for backend #hal.executable.target<"vulkan-spirv", "vulkan-spirv-fb", {spirv.target_env = #spirv.target_env<#spirv.vce<v1.6, [Shader, Float64, Float16, Int64, Int16, Int8, StorageBuffer16BitAccess, StorageUniform16, StoragePushConstant16, StorageBuffer8BitAccess, UniformAndStorageBuffer8BitAccess, StoragePushConstant8, GroupNonUniform, GroupNonUniformVote, GroupNonUniformArithmetic, GroupNonUniformBallot, GroupNonUniformShuffle, GroupNonUniformShuffleRelative, GroupNonUniformClustered, GroupNonUniformQuad, PhysicalStorageBufferAddresses, VariablePointers, VariablePointersStorageBuffer, DotProduct, DotProductInputAll, DotProductInput4x8BitPacked, DotProductInput4x8Bit], [SPV_KHR_16bit_storage, SPV_KHR_8bit_storage, SPV_KHR_integer_dot_product, SPV_KHR_storage_buffer_storage_class, SPV_KHR_physical_storage_buffer, SPV_KHR_variable_pointers]>, api=Vulkan, AMD:DiscreteGPU, #spirv.resource_limits<max_compute_shared_memory_size = 65536, max_compute_workgroup_invocations = 1024, max_compute_workgroup_size = [1024, 1024, 1024], subgroup_size = 64, min_subgroup_size = 32, max_subgroup_size = 64, cooperative_matrix_properties_khr = []>>}>
  hal.executable.variant public @vulkan_spirv_fb target(<"vulkan-spirv", "vulkan-spirv-fb", {spirv.target_env = #spirv.target_env<#spirv.vce<v1.6, [Shader, Float64, Float16, Int64, Int16, Int8, StorageBuffer16BitAccess, StorageUniform16, StoragePushConstant16, StorageBuffer8BitAccess, UniformAndStorageBuffer8BitAccess, StoragePushConstant8, GroupNonUniform, GroupNonUniformVote, GroupNonUniformArithmetic, GroupNonUniformBallot, GroupNonUniformShuffle, GroupNonUniformShuffleRelative, GroupNonUniformClustered, GroupNonUniformQuad, PhysicalStorageBufferAddresses, VariablePointers, VariablePointersStorageBuffer, DotProduct, DotProductInputAll, DotProductInput4x8BitPacked, DotProductInput4x8Bit], [SPV_KHR_16bit_storage, SPV_KHR_8bit_storage, SPV_KHR_integer_dot_product, SPV_KHR_storage_buffer_storage_class, SPV_KHR_physical_storage_buffer, SPV_KHR_variable_pointers]>, api=Vulkan, AMD:DiscreteGPU, #spirv.resource_limits<max_compute_shared_memory_size = 65536, max_compute_workgroup_invocations = 1024, max_compute_workgroup_size = [1024, 1024, 1024], subgroup_size = 64, min_subgroup_size = 32, max_subgroup_size = 64, cooperative_matrix_properties_khr = []>>}>) {

Steps to reproduce your issue
phi-2 mlir can be found here: https://sharkpublic.blob.core.windows.net/sharkpublic/ian/phi_2.mlir
failed dispatch here: https://sharkpublic.blob.core.windows.net/sharkpublic/ian/configured_state_update_run_initialize$async_dispatch_19.mlir
iree compiler command used:
../iree-build/tools/iree-compile --iree-input-type=auto --iree-vm-bytecode-module-output-format=flatbuffer-binary --iree-hal-target-backends=vulkan-spirv --mlir-print-debuginfo --mlir-print-op-on-diagnostic=false --iree-input-type=torch --mlir-print-debuginfo --mlir-print-op-on-diagnostic=false --iree-llvmcpu-target-cpu-features=host --iree-llvmcpu-target-triple=x86_64-linux-gnu --iree-stream-resource-index-bits=64 --iree-vm-target-index-bits=64 --iree-vulkan-target-triple=rdna2-unknown-linux --iree-stream-resource-max-allocation-size=4294967296  --iree-hal-dump-executable-files-to=haldump ../SHARK-Turbine/phi_2.mlir -o phi_2.vmfb

What component(s) does this issue relate to?
Compiler
Version information
SHA: cc2ef92a232e4b6de9b845b6854d4d8667a6162b
Additional context
No response

@Groverkss has a WIP for this on the LLVMGPU side here: https://github.com/openxla/iree/pull/16927. Kunwar, could you also take care of the SPIR-V path?

AFAIU the patch also takes care of SPIRV

AFAIU my patch should also take care of SPIRV

Can you also add a SPIR-V regression test based on the batch matmul from this issue?

Sure, will do tomorrow

AFAIU my patch should also take care of SPIRV

Checked out the https://github.com/openxla/iree/pull/16927 PR and still see the same error

AFAIU my patch should also take care of SPIRV

Checked out the #16927 PR and still see the same error @Groverkss

I'll have a look and fix it if something is wrong. Thanks for checking.

Hey @Groverkss do you have the patch somewhere? Can you give it to @nithinsubbiah to finish it up if so? Or if you don't have, can you guide @nithinsubbiah to fix this issue?

I can't reproduce this issue anymore, @IanNod could you please check if this is resolved on your end? If you could share the weights, I can validate if we can produce outputs.

@nithinsubbiah the provided phi-2 IR has inlined weights so you won't need anything else to try producing output.


Force calculation to be saved when work item is loaded for the first time

I hope I did this right, I'm always confused about source & destination

👍 :shipit:


[Alert manager] Load all custom mibs from configured path

Is this a BUG REPORT or FEATURE REQUEST?:

/kind feature

What happened:
Alert manager should be able to load all custom mib files from given path
What you expected to happen:
Alert manager should be able to load all custom mib files from given path
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

NBP version:
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

/move sim


Automated cherry pick of #6209

Cherry pick of #6209 on release-5.27.
/cc  @hahmadia

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

Trying to auto merge this PR.

Pull Request successfully merged
SHA: 4d30fd43449dd7d136de2e9e0759db42867cb355


Mounting single file breaks if file is edited through gedit or WebStorm

Pretty weird issue I've experienced on my local docker instance.
> docker -v
Docker version 18.06.1-ce, build e68fc7a

> docker-compose -v
docker-compose version 1.21.0, build 5920eb0

OS:
> lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 16.04.5 LTS
Release:	16.04
Codename:	xenial

Think this is problem of docker itself, however I mentioned version of docker compose as well.

Mount single file (test.txt in my simple example)
docker-compose.yml

...
volumes:
    - /path-to-project-on-host/test.txt:/usr/app/test.txt:rw
...

docker-compose up
docker inspect container_app

...
"Mounts": [
            {
                "Type": "bind",
                "Source": "/path-to-project-on-host/test.txt",
                "Destination": "/usr/app/test.txt",
                "Mode": "rw",
                "RW": true,
                "Propagation": "rprivate"
            }
        ]
...

Trying to edit file through terminal like this

> echo "Hello container!" > test.txt

File seems to be changed inside container

> docker exec container_app cat test.txt
Hello container!

Try to edit file through editor gedit

I edit the test.txt through gedit and now I get on host machine
> cat test.txt
Hello container!
Hello container from gedit!

But inside container this file haven't changed. I still see previous message

> docker exec container_app cat test.txt
Hello container!

Then I try to edit file like on fourth step

> echo "Another one hello, container!" > test.txt

Inside container I still see message from fifth step

> docker exec container_app cat test.txt
Hello container!

I assumed that file test.txt is blocked somehow after editing in gedit. Actually I tried IDE like WebStorm or PhpStorm as well with the same behaviour. File was just blocked on writing after editing in them... Although text is edited fine through LibreOffice for example.
File permissions are 777.. And I edit file under the same user.
I would like to notice that mounting entire folder doesn't cause such problems and I can edit files inside mounted folder through gedit or WebStorm. However right now I need to mount single file, not entire folder.
Are there some file blockers inside container or something else I am not familiar with?

This tracker is for problems with open source registry. You may want to check forums.docker.com or support.docker.com for general docker usage questions. If you find an issue in engine then please file an issue with github.com/moby/moby. Thanks.


Session crashes, and when restarted vncstart hangs.

After installing, everything seemed to work fine, however after a few minutes the session crashed and when I try to restart termux (and even rebooting the phone) the ubuntu shell in termux works fine, but when running vncstart it just hangs there and the phone becomes quite hot. Any input on how to fix?

This is because of "Phantom Proccess Killing". Here is the solution:- https://github.com/agnostic-apollo/Android-Docs/blob/master/en/docs/apps/processes/phantom-cached-and-empty-processes.md#how-to-disable-the-phantom-processes-killing


Add architecture ppc64le to travis build

Add support for architecture ppc64le.
This is part of the Ubuntu distribution for ppc64le. This helps us simplify testing later when distributions are re-building and re-releasing. For more info tag @gerrith3
Added ppc64le arch and excluded luajit=2.1 and luajit=2.0 for Travis build.

since we switched to GHA quite a while back now, I'll be closing this PR.


Argo tunnels

Hi Bro --- >  Does it add?
https://zhengweidong.com/try-cloudflare-argo-tunnel
https://imnks.com/5984.html

No, it won't be added.


Update tapir-core, tapir-http4s-server, ... to 1.0.4

Updates

com.softwaremill.sttp.tapir:tapir-core
com.softwaremill.sttp.tapir:tapir-http4s-server
com.softwaremill.sttp.tapir:tapir-json-circe
com.softwaremill.sttp.tapir:tapir-newtype
com.softwaremill.sttp.tapir:tapir-openapi-docs
com.softwaremill.sttp.tapir:tapir-swagger-ui

from 0.20.2 to 1.0.4.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.softwaremill.sttp.tapir" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "com.softwaremill.sttp.tapir" }
}]

labels: library-update, early-semver-major, semver-spec-major, commit-count:1

Superseded by #244.


Added email send changes, vendored gomail package

What this PR does / why we need it:

Added gomail package to use to send emails for torpedo longevity jobs
Modified sendEmail function to use gomail
Which issue(s) this PR fixes (optional)
Closes #https://portworx.atlassian.net/browse/PTX-15093
Special notes for your reviewer:

Please run torpedo dev job before to check for regression, check with Maksym/Leela as to which job that is.

@Rohit-PX  -
Please find the job run below -
https://jenkins.pwx.dev.purestorage.com/job/Dev/job/torpedo-dev01/205/
Aetos results -
http://aetos.pwx.purestorage.com/resultSet/testSetID/88562


migration of plugins fails because placeholders are case sensitive now

I used case sensitive placeholder names in my templates like: {% placeholder "Teaser Links" %}. after updating to django 1.3.1 and django cms 2.2 I have two entries in the db table cms_placeholder: "teaser links" (ID: 7) and "Teaser Links" (ID: 8) and the references are wrong therefore. the result is that plugins are not shown on the homepage. it seemes like the old placeholder mechanism was not case sensitive but the new one is. in the django 2.0.2 version of the table cms_cmsplugin these placeholders can be found in the field "placeholder" - e.g. "teaser links".

Possible verification: prior to moving to classy-tags this time last year, the name used to get modified via "".join(name.lower().split('"')). This new case-sensitive functionality made it into 2.1.0 and has been the same ever since. The first RC for 2.1.0 came just 10 days after the release of 2.0.2.


🏃♂ Move manager to project root

What this PR does / why we need it:
This moves the manager main.go from cmd/manager to the project root for consistency with the other projects and kubebuilder v2 conventions.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note:

/ok-to-test
/lgtm
/approve

/lgtm


go-sdl2/sdl: Force thread-sensitive test code to run in main thread

Wrapped possible problematic test codes in Do(..). Running go test -v -race no longer fails on macOS.

This change is

Thank you for the work! I could confirm it fixed the errors when running tests with -race. Merging it.


Login with service principal fails: The received access token is not valid: at least one of the claims 'puid' or 'altsecid' or 'oid' should be present

Hi, I have followed the instructions on how to login via service principal, and I'm getting the following error in the pipelines:
(InvalidAuthenticationToken) The received access token is not valid: at least one of the claims 'puid' or 'altsecid' or 'oid' should be present. If you are accessing as application please make sure service principal is properly created in the tenant.
Code: InvalidAuthenticationToken

I'm not sure whether I'm missing anything, but googling for that error doesn't seem to yield anything particularly useful. However, this doesn't seem like an error on my end as I've followed the instructions to the letter, any help will be appreciated.
Thank you.

@emassimi I got the same error.   I reverted to version 1.1 of the action and then it worked fine.   I didn't try other versions yet.
@BALAGA-GAYATRI maybe this should be re-opened?   Or should I open a new issue?


Update index.md

And Bitcoin prices have been falling steadily, and most of them have yet to cross the bridge with MetaMask. Did you come to Myanmar if possible in a trust wallet?

Why:
Closes [issue link]

What's being changed:

Check off the following:

[ ] I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
[x] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[x] This pull request impacts the contribution experience

[ ] I have added the 'writer impact' label
[ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

I was asked to do one thing and I did one thing. No matter what I said, I needed money and lost my job binance What about a wallet? BNB It is not enough metamask I'm a millionaire


fixing pypi badge in readme

using the right badge "supabase" instad of "supabase-py"

thanks @Phillackinger !


Eliminate compiler warning and runtime crash in threadstest

With GCC 4.1.0 building for Linux ppc (32-bit big-endian) or linux 390 (31-bit), threadstest.h causes this warning at build time:
gcc  -Iinclude -Iapps/include  -pthread -m31 -Wa,-mzarch -DTERMIO -O3 -Wall -Wall -O3 -DOPENSSL_BUILDING_OPENSSL -DNDEBUG  -MMD -MF test/threadstest-bin-threadstest.d.tmp -MT test/threadstest-bin-threadstest.o -c -o test/threadstest-bin-threadstest.o test/threadstest.c
In file included from test/threadstest.c:23:
test/threadstest.h: In function 'thread_run':
test/threadstest.h:65: warning: dereferencing type-punned pointer will break strict-aliasing rules
test/threadstest.h: In function 'run_thread':
test/threadstest.h:73: warning: dereferencing type-punned pointer will break strict-aliasing rules

At run-time, the threadstest program core dumps with a stack trace going through a null instruction pointer when the thread attempts to call through thread_run.
The type conversion casts through &f can be replaced by a simple cast, which eliminates the warning and fixes the core dump in the test program.

Checklist

[x] tests are added or updated

On further investigation, I learned that:

ISO C doesn't allow assignment between function pointers and other pointers, but POSIX does require it, so my change is only valid for POSIX (so openssl won't take it).  Plus, their automated tests check for ISO C anyway.  (see several discussions at stack-overflow, such as https://stackoverflow.com/questions/36645660/why-cant-i-cast-a-function-pointer-to-void )
In the test program that fails, the code library in question is called many times successfully, it appears to be tripping on a compiler bug--when I build with /usr/bin/gcc, it passes tests fine.

So, I won't need to submit this upstream.


No JDK9 available on Ubuntu s390x build machines e.g. build-marist-ubuntu1604-s390x-3

Required to bootstrap JDK10 in the absence of the RHEL74 machine being available (Ref: https://github.com/AdoptOpenJDK/openjdk-infrastructure/issues/323)

Looking at the playbooks, I find the following packages being installed...

CentOS

java-1.7.0-openjdk-devel
java-1.8.0-openjdk-devel

FreeBSD

openjdk
openjdk8

OracleLinux

java-1.8.0-openjdk-devel

RedHat

RHEL 6

java-1.7.0-ibm-devel
java-1.8.0-ibm-devel

RHEL not 6

java-1.7.0-openjdk-devel
java-1.8.0-openjdk-devel

SLES

none

Ubuntu

openjdk-7-jdk
openjdk-8-jdk

Observation
Looking at the Unix Playbooks, I can find the following JDK packages being installed...

CentOS

java-1.7.0-openjdk-devel
java-1.8.0-openjdk-devel

FreeBSD

openjdk
openjdk8

OracleLinux

java-1.8.0-openjdk-devel

RHEL

RHEL6_PPC64:

java-1.7.0-ibm-devel
java-1.8.0-ibm-devel

NOT_RHEL6_PPC64

java-1.7.0-openjdk-devel
java-1.8.0-openjdk-devel

SLES

SLES12

java-1_8_0-openjdk

Ubuntu

openjdk-7-jdk
openjdk-8-jdk

No JDK9 anywhere. I therefore can't explain where the JDK9 you told me was on the CentOS build machines came from.

Questions

Should JDK9 be on all build machines?
Why don't SLES machines other than SLES12 have any JDK on them?
Why don't SLES12 machines have JDK7 on them?
Am I right to assume that openjdk on FreeBSD is JDK7?

JDK9 should be on all build machines that are building JDK10 as it's required for bootstrapping.
I suspect they're not used for buiding
See 2
Not sure - I've not looked at FreeBSD yet :-)

The JDK9 on build-osuosl-centos74-ppc64le-1 wasn't installed via rpm. My best guess is that it was extracted from one of our built builds but I'm not sure if that was documented anywhere or added to the playbook. @gdams?
[jenkins@build-osuosl-centos74-ppc64le-1 ~]$ rpm -qf /usr/lib/jvm/jdk-9+181/bin
file /usr/lib/jvm/jdk-9+181/bin is not owned by any package
[jenkins@build-osuosl-centos74-ppc64le-1 ~]$ /usr/lib/jvm/jdk-9+181/bin/java -version
openjdk version "9-internal"
OpenJDK Runtime Environment (build 9-internal+0-adhoc.jenkins.openjdk)
OpenJDK 64-Bit Server VM (build 9-internal+0-adhoc.jenkins.openjdk, mixed mode)
[jenkins@build-osuosl-centos74-ppc64le-1 ~]$

As a tactical fix without knowing how the CentOS machines were set up I have modified the two build jobs I'm interested in (https://ci.adoptopenjdk.net/job/openjdk10_openj9_build_s390x_linux and https://ci.adoptopenjdk.net/job/openjdk10_openj9_build_ppc64le_linux/) to download our AdoptOpenJDK9 into the workspace and run from there if the JDK9_BOOT_DIR) is not set to anything useful.

Yes the jdk9 binaries have been pulled from our own website. (except for x64 linux which uses zulu 9)

Cheers @gdams ... @geraintwjones FYI
cd /usr/lib/jvm && wget -O - https://github.com/AdoptOpenJDK/openjdk9-releases/releases/download/jdk-9%2B181/OpenJDK9_s390x_Linux_jdk-9.181.tar.gz | tar xpfz -
That will extract it - we've got variables defined on each machine within jenkins that point to the directory to get it from that are picked up by the build scripts.

basically we just need to get our own apt and rpm repos setup and then ansible will easily pick up our binaries

That is another option

I think the smart move here will be to create a separate role to handle this

My only concern with this is that on some machines we've left it with the original name in the tarball (i.e. /usr/lib/jvm/jdk9+181 on build-osuosl-centos74-ppc64le-1) which is going to change. Should we make a point of renaming this to something neutral such as adoptopenjdk-9- instead of jdk9+181 on the machine?
(This does raise the question of whether we should have a way to update if the release version is updated)


Huge performance hit when loading emoji picker

I'm trying out a slightly modified version of this package in two seperate projects. In one (which is an Electron applicatoin), for all intents and purposes of this issue, it works as expected.
The other is a small widget built with React. I ported over the Emoji Picker from the other project, but when opening the picker in the widget, the various emojis load extremely slow (~2 seconds) and cause the widget to become unresponsive.
What might be causing this issue?

Thanks for bringing this up, it should be much better in 2.0 - https://github.com/tommoor/emojione-picker/releases/tag/v2.0.0


fix(github): fix unicode for pg

Summary
As of #1870, pg cannot support unicode \u0000, we have to drop json as field type in the table. We use text to store json data
In addition, this pr modified an error log as it print the location of err not msg
Does this close any open issues?
close #1870
Current Behavior
Describe the current behaviour of this issue, if relevant.
New Behavior
Describe the new behaviour updated in this issue, if relevant.
Screenshots
Include any relevant screenshots here.
Other Information
Any other information that is important to this PR.

Covered by #1890


Vicuna-7b chat reply stops before end

https://www.loom.com/share/8723218d5a5e4dbb98dea751b5aab61a?sid=8dd1f54f-2711-46eb-a2f5-7d08288426d2
@filopedraz Is it because of a token limit or is it a bug?

Before token limit. The total amount of tokens (input + output) for vicuna is only 512


Publish artifacts to Maven Central

Hi. Do you guys have jars for Mappedbus available in Maven central?
Thanks!

Hi! It's not published at Maven central at the moment.

Third party projects can manage their dependencies better when they're available in an artifact repository such as Maven central or Bintray.
Is there a particular reason stopping this project from sharing artifacts?
Thanks for your time!

Hi all,
It is possible to get Mappedbus as a Gradle/Maven dependency using jitpack: https://jitpack.io/#caplogic/Mappedbus/v0.5
Happy to submit a PR to add this info to readme @caplogic is interested


python311Packages.blinkpy: 0.22.4 -> 0.22.5

Diff: https://github.com/fronzbot/blinkpy/compare/refs/tags/v0.22.4...v0.22.5
Changelog: https://github.com/fronzbot/blinkpy/blob/refs/tags/v0.22.5/CHANGES.rst
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 279596 run on aarch64-darwin 1

4 packages built:

python310Packages.blinkpy
python310Packages.blinkpy.dist
python311Packages.blinkpy
python311Packages.blinkpy.dist

Result of nixpkgs-review pr 279596 run on aarch64-linux 1

4 packages built:

python310Packages.blinkpy
python310Packages.blinkpy.dist
python311Packages.blinkpy
python311Packages.blinkpy.dist


Gif for README

https://www.dropbox.com/s/s6cff9dpkv3eqze/pls.gif?dl=0

Muchhhhh improved :D

except it's way too big lol... i'm trying to get the size down

FINALLY (I think


Depth buffer sharing disables itself due to IHolographicCameraRenderingParameters2

Describe the bug
When Depth Buffer Sharing is enabled in XR Settings, the following warning generates:

"IHolographicCameraRenderingParameters2 interface unavailable; disabling depth buffer sharing"

When disabling Depth Buffer Sharing manually in XR Settings, a different warning is generated:

"Depth Buffer Sharing is not enabled to improve hologram stabilization. See Mixed Reality Toolkit > Utilities > Optimize Window tool for more information to improve performance"

Warning is reproduced by setting up MRTK and Unity scene as usual. Have seen this warning in every project over the last few months in MRTK v2.1 too.

Expected behavior
Ideally no warning appears and Depth Buffer Sharing doesn't disable itself.
Your setup (please complete the following information)

Unity 2019.1.14f1
MRTK v2.2

Target platform (please complete the following information)

HoloLens

Which Windows 10 version are you running?

10.0.18362 Build 18362

Closing this issue as this seems to be a development environment configuration issue, please reopen if you have more information to share.


Keywords should take a space

Got:

Expected:

New code to achieve expected result:
\newenvironment{keywords}{\fontsize{9}{10}\selectfont
    \noindent{\bfseries Keywords:\ }}{}

Please read my comment for #14

I added the space.


maven plugin version issue

i need to use maven.azure.plugin 1.6.0, git repo still use 1.5.1, which has deploy fail

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 264b32e3-9a21-233f-0056-b5bd970b47f2
Version Independent ID: 5e09b057-afba-d0a0-6fc0-94a78edd539f
Content: Build Java Enterprise web app on Linux - Azure App Service
Content Source: articles/app-service/containers/tutorial-java-enterprise-postgresql-app.md
Service: app-service-web
GitHub Login: @JasonFreeberg
Microsoft Alias: jafreebe

@rofangaci, Thanks a lot for your great feedback! Kindly take a look at the doc which provides a sample and see if that helps - https://docs.microsoft.com/java/api/overview/azure/maven/docs/web-app-samples?view=azure-java-stable . Also, find the Azure-maven-plugins releases for details.

@rofangaci, Just checking if the above response helped or you need further assistance.

@rofangaci, Since we have not heard back from you we will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply and we will gladly continue the discussion.

@rofangaci, Since we have not heard back from you we will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply and we will gladly continue the discussion.


Pull request #201 broke some examples in the English README.md file

In example "Adding arrays", the code in the example doesn't work.
In example "Addition of RegExps", the code was formatted weirdly causing it not to return the correct result. The original was /7/ - /5/;
In example "Double dot", the code was changed from 27..toString() to (27).toString(); in both the explanation and example.
In example "Why you should use semicolons", the code from the explanation was copied into the example.
I think that example "Extra Newness" is broken.
I also think that example "A generator which yields itself" is broken.

It also seems that some examples in the other translations are broken. For example Korean, Italian, Hindi and maybe more.


async call with React/Redux/Axios fails to complete promises

I'm trying to write a test for an async call via React/Redux and the axios.js library.  The function works fine in the browser,  and I can see the correct calls and 200 status code when i use the browser.dump() of zombie, but  the dispatch calls after the initial POST aren't getting triggered.
Here is the gist https://gist.github.com/MrRoyce/9228884d8910d990d739f1f0dae03842
The initial console.log 'getUserLogin' statement works fine,  but the other 2 log statements, in both the success and error part of the promise are never fired.  That means the Redux actions, and reducers are not triggered and the DOM doesn't get updated.
I can only guess that zombie is trapping the 200 status code from the initial axios POST and not letting the rest of the promise(s) complete, but I may be way off base.

I added more detail on Stack Overflow
StackOverFlow


Update dependencies

Mostly solves #9 - still requires version upgrade and publishing to crates.io

Passes all tests in cargo test

Thank you very much!  I'm sorry I have not merged this PR yet.  I'll do it as soon as I confirmed the specification changes in the predicates crate.


add directions for hints that the # and backticks need to removed in labs

had students confused by this and told me to do this

I think we can mostly just update earlier labs... but we shall see

[ ] RStudio

[ ] Lab

[ ] Reproducibility
[ ] Basic R

[ ] Lab

[ ] Data IO

[ ] Lab

[x] Subsetting

[x] Lab

[ ] Summarization

[ ] Lab

[ ] Data classes

[ ] Lab

[ ] Data cleaning

[ ] Lab

[ ] Manipulating

[ ] Lab

[ ] Esquisse

[ ] Lab

[ ] Data viz

[ ] Lab

[ ] factors

[ ] Lab

[ ] Statistics

[ ] Lab

[ ] Functions

[ ] Lab

I haven't been uncommenting, just retyping below. My group seemed like this wasn't an issue...

solution: include hint/format under the question, e.g.,

Summarize the data to get the max and min of length using the summarize function.

# General format
{data to use} %>%
    summarize({summary column name} = {operator(source column)})