Varnish Redirect for Designated Texter

Current Behavior
Title of https://www.dosomething.org/us/node/5359/edit was changed back to "Don't Booze and Cruise". The links on Fastweb are: https://www.dosomething.org/us/campaigns/designated-texter?utm_source=partner&utm_medium=scholarship_listing&utm_campaign=fastweb AND https://www.dosomething.org/campaigns/designated-texter. If people click this link, they are brought to a page with the URL as above, but it looks like dosomething.org/us/campaigns.
Desired Behavior
People who click https://www.dosomething.org/us/campaigns/designated-texter?utm_source=partner&utm_medium=scholarship_listing&utm_campaign=fastweb OR https://www.dosomething.org/campaigns/designated-texter get brought to https://www.dosomething.org/us/campaigns/don’t-booze-and-cruise.
We need a redirect from https://www.dosomething.org/us/campaigns/designated-texter to https://www.dosomething.org/us/campaigns/don’t-booze-and-cruise
Why This Matters
People who come in through Fastweb cant currently find the campaign.

DONE! In Varnish.


ng generate guard does not let you choose interfaces

🐞 Bug report
Command (mark with an x)

[x] generate

Is this a regression?
Yes, as the behavior is broken compared to the docs and other articles explaining how to use this feature
Description
When using the cli to generate a new guard, the cli tool becomes stuck on the "Which interfaces would you like to implement?" step, which does not give you the ability to choose the interfaces.
🔬 Minimal Reproduction
In your terminal, run ng generate guard
🔥 Exception or Error

There should be a multi-select to choose the interface. None is shown. If you type in an interface, you receive the following error:

❯ ng generate guard
✔ What name would you like to use for the guard? · can-deactivate
✔ Which interfaces would you like to implement? · CanDeactivate
Property 'implements' does not match the schema. 'CanDeactivate' should be a 'array'.

🌍 Your Environment

Angular CLI: 12.1.4
Node: 14.17.3
Package Manager: npm 6.14.13
OS: darwin x64

Angular: 12.1.4
... animations, cdk, cli, common, compiler, compiler-cli, core
... elements, forms, language-service, localize, material
... material-moment-adapter, platform-browser
... platform-browser-dynamic, router, service-worker

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1200.4
@angular-devkit/build-angular   12.1.4
@angular-devkit/core            12.1.4
@angular-devkit/schematics      12.1.4
@angular/fire                   6.1.4
@angular/flex-layout            11.0.0-beta.33
@schematics/angular             12.1.4
ng-packagr                      12.2.0
rxjs                            6.6.7
typescript                      4.3.5

Anything else relevant?

Unfortunately, we are unable to replicate the issue as described.  Does this issue occur within only this project or do all projects experience the problem (for example, a newly generated project)? If it does occur for all projects, if possible, can you try a different terminal application and shell?

Closing due to lack of communication.


CDN setup

[x] aem-bricks.albertodicagno.com
[x] aem-bricks-preview.albertodicagno.com

Need to follow up and keep an eye on cache invalidation for preview, will raise an issue in case of problems.


translated text & $sanitize on utf-8 title & placeholder

Reference to the original post from angular:
https://github.com/angular/angular.js/issues/12460
Plunker:
http://plnkr.co/edit/mQiWvt?p=preview
The <title> tag can't be checked in plunker, so I've put up a <input placeholder/> on top of the playlists list, in playlists.html.
P.S. I've checked before while trying to look into this issue. It seems that doesn't matter if I use {{ 'some' | translate }} or translate & translate-attr-xxxx attributes.

Note: The issue not new (more or less duplicates), I'll flag them all together.. Stay tuned.

I'm having pretty much the same problem: German special characters like ö, ä, ü and ß don't get parsed well to title or tooltip directives.
This one should say Priorität:

just a reminder that the link in th post has located part (if not root) of the problem, thx to @lgalfaso

Duplicate #1101 -- see also for solutions and workarounds.


[IME] Can't type Korean ( linux only? )

Prerequisites

[x] Can you reproduce the problem with Debug -> Reload Without Extensions?
[x] Did you perform a cursory search to see if your bug or enhancement is already reported?
[x] Did you read the Troubleshooting guide?

Description
Can't type Korean in editor
Steps to Reproduce

Ubuntu 18.04 LTS 64bit / default Korean IME (iBus-engine-hangul)

#apt list | grep ibus-hangul
ibus-hangul/bionic,now 1.5.0+git20161231-1 amd64 [installed]

Install Brackets and launch / Change to Korean type mode
Just only typing English

Expected behavior: [What you expected to happen]
Typing Korean.
**Atom, gedit, Eclipse, Pycharm....GNOME Terminal, FileManager, Web Browser, everything works fine(Can type Korean) only brackets not working
Actual behavior: [What actually happened]
Versions
Release 1.12 build 1.12.0-17621 (release d3b783b99)

@RuchiAgrawalAdobe could you please try to recreate this at our end.


bug: Copy code functionality triggers for all blocks instead of just the clicked one

I discovered an issue with the "Copy code" functionality. I have multiple blocks of code, and I intend to copy only the code that I click on. However, when I click on the "Copy code" button within one block, the "Copied!" message displays on all other blocks as well.
Expected behavior:
The "Copied!" message should appear only in the block that I clicked on, not in all the other blocks.
Steps to reproduce:
Click on a "Copy code" button within one block.
Observe that the "Copied!" message displays in all other blocks as well.
Possible solution:
The implementation needs to be revised to isolate the state for each block. Currently, the copied state is shared all ContentView components, causing it to trigger a re-render in all of them whenever there is a change.

Let me confirm if I understand you correctly - the issue is that when you click on a "Copy code" button in one code block, the message "Copied!" appears in all the code blocks, but it's not actually copying the code from all the blocks, right? If that's the case, maybe it would help to update the title of the feature request to make it clearer.


Microsoft powertoys disappears from autostart and start menu of one account when updated from another

Microsoft PowerToys version
0.60.1
Running as admin

[X] Yes

Area(s) with issue?
General, Installer
Steps to reproduce

Install power toys inside one windows account, set it up and let it autostart
upgrade powertoys from inside another windows account

✔ Expected Behavior
It should preserve any configurations on the respective accounts
❌ Actual Behavior
When I upgrade it from an account, powertoys disappears from the other. The binary is still globally available under "C:\Program Files\PowerToys", but the app disappears from autostart (under the task manager) and from the start menu.
Then if I reinstall if from that account, it shows up, but disappears on the other, so, catch 22
Other Software
No response

I'm thinking it's because the old version is uninstalled, and then the new version is installed on a per-user base. This is why many installations ask you if you want to "install for all users or only this user?"

Actually, power toys doesn't offer a "per user" install option, it installs
the app system wide right away.
If that was the case, then i think your theory wouldn't apply, since per
user installations go into %appdata%, so each user would have their
separate install and they couldn't influence one another.
On Sun, Jul 17, 2022, 18:37 Jay @.***> wrote:

I'm thinking it's because the old version is uninstalled, and then the new
version is installed on a per-user base. This is why many installations ask
you if you want to "install for all users or only this user?"
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/PowerToys/issues/19493#issuecomment-1186611549,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADVCKI4LXPEGYZVGFZDT7DLVUR4JBANCNFSM532KUT6Q
.
You are receiving this because you authored the thread.Message ID:
@.***>

@jay-o-way, this is a multi-user issue and how we do upgrades.  What account is running PowerToys when you click "upgrade"?
@yuyoyuppe thoughts here?  With how the upgrade from inside the app goes, what account would be running the installer?

Are you still experiencing this issue? /needinfo

@cinnamon-msft well, it's been more than a year since I'd last used Powertoys, but I did a test now. I installed it on one account and then did the same on another and it remained on autostart for both. So apparently, the issue is gone.
It might need more investigation though since, as I said, I am not using Powertoys on a daily basis anymore and this was just a quick test.


[🐛] Coding Challenge: Forged Review

:bug: Bug report
Description

Coding Challenge: Forged Review
When working on this challenge, the following code is presented:
module.exports = function productReviews () {
  return (req: Request, res: Response, next: NextFunction) => {
    const user = security.authenticatedUsers.from(req)
    db.reviewsCollection.update(
      { _id: req.body.id },
      { $set: { message: req.body.message } },
      { multi: true }
    ).then(
      (result: { modified: number, original: Array<{ author: any }> }) => {
        res.json(result)
      }, (err: unknown) => {
        res.status(500).json(err)
      })
  }
}

The solutions state that the code should be ammended as follows:
module.exports = function productReviews () {
  return (req: Request, res: Response, next: NextFunction) => {
    const user = security.authenticatedUsers.from(req)
    db.reviewsCollection.update(
      { _id: req.body.id, author: user.data.email },
       {$set: { message: req.body.message, author: user.data.email } },
      // { multi: true }
    ).then(
      (result: { modified: number, original: Array<{ author: any }> }) => {
        res.json(result)
      }, (err: unknown) => {
        res.status(500).json(err)
      })
  }
}

We can see lines 5-7 have been updated. However, incorporating these changes does not patch the vulnerability as hosting the patched version on Heroku still allows me to use Burp and modify the review's author as admin and leave a forged comment.
Is this a regression?

N/A
:microscope: Minimal Reproduction

Make the recommended code changes above and host the application.
Open Burp Suite Proxy and use the browser to navigate to the Juice Shop page
Create a new user and login as that user
Now turn on intercept on Intercept in Burp Proxy
Create a comment and forward until you see the PUT request making the comment
Modify the author in the PUT request to be<EMAIL_ADDRESS>Now forward the request
The comment will still be forged as the admin

:fire: Exception or Error

N/A
:deciduous_tree: Your Environment

Run on Heroku - not locally
Additional Information

This is done using Burp Suite Proxy and its browser (Chromium). The application is hosted on Heroku

Thank you for reporting this in such detail! 😄👍 We'll look into it and see if we can come up with another fix recommendation.

can u assign this to me

has this been assigned to anyone yet or any progress?

nope. we rarely assign tickets to users as this it rarely works and blocks other people from starting. If the people then run out of time / or loose focus we have to chase them down which is really annoying for everybody.
So if somebody wants to take this up, feel free to just do so.
If you started but haven't completed it yet feel free to open up a draft PR.


Add pagination to activity viewer

Add pagination to activity viewer
Signed-off-by: johnsonw<EMAIL_ADDRESS>

This change is

A few notes:

Pagination is on both the activity and the logs viewer
Next button is gray if there are no more entries
Prev button is gray if there are no previous entries
Clicking either next or prev will only fetch if a fetch is not in progress


variables for a mutation query are not being passed to resolver

Hi,
Maybe I'm missing something, but it seems to me that Input Type objects are not being passed to the implemeting mutation resolvers.
getGraphQLParameters is parsing the variables correctly (and the input is confirmed as being a valid inpt type for the specific mutation).
When the operation, query and variables are passed to the async method processRequest, the resolver is hit, but the mathod doesnt receive any variables...
Some example code:
...
const { operationName, query, variables } = getGraphQLParameters(request);

    console.log({ operationName, query, variables });

    const result = await processRequest({
      operationName,
      query,
      variables,
      request,
      schema,
    });

    if (result.type === 'RESPONSE') {
      result.headers.forEach(({ name, value }) => res.setHeader(name, value));
      res.status(result.status);
      res.json(result.payload);
    } else {
      res.status(400);
      res.json({ error: 'no support for multipart responsed or streams' });
    }
...

import { makeExecutableSchema } from '@graphql-tools/schema';

import typeDefs from './typedefs.generated';

import resolvers from './resolvers';

export const schema = makeExecutableSchema({
  typeDefs,
  resolvers,
});

import {
  Claim,
  Policy,
  Customer,
  ClaimInput,
  ClaimCreateResponse,
  // Resolvers,
} from '../types.generated';
import { Claims, Policies, Customers } from '../stores';
import { claims as claimsResolvers } from './claims';

const resolvers = {
  Query: {
    allClaims: () => Claims.findAll(),
    allPolicies: () => Policies.findAll(),
    allCustomers: () => Customers.findAll(),
  },
  Mutation: {
    createClaim: (claim: ClaimInput): Promise<ClaimCreateResponse> => Claims.create(claim),
  },

  ...claimsResolvers,

  Policy: {
    claims: ({ id }: Policy): Claim[] => Claims.findByPolicyId(id),
    customer: ({ customerId }: Policy): Customer | null => Customers.get(customerId),
  },
  Customer: {
    policies: ({ id }: Customer): Policy[] => Policies.findByCustomerId(id),
  },
};

export default resolvers;

import { find, filter } from 'lodash';
import { Claim, ClaimInput, ClaimCreateResponse } from '../types.generated';
import { validate } from '../validators';

import { claims as claimStubs } from './data';

const Claims = {
  get: (id: string): Claim | null => find(claimStubs, { id }) || null,
  findAll: (): Claim[] => claimStubs,
  findByPolicyId: (_id: string): Claim[] => filter(claimStubs, { policyId: _id }),
  create: async (claim: ClaimInput): Promise<ClaimCreateResponse> => {
    // validate input
    console.log(claim);
    if (validate('ClaimInput')(claim)) {
      return {
        claim: {
          ...claim,
          id: 'generatedId',
        },
      };
    } else {
      throw new Error('not valid');
    }
  },
};

export default Claims;

Hi @Sewdn. A GraphQL resolver takes four parameters: the parent value, an arguments object, a context object and a GraphQLResolveInfo object. Your resolver, however, is written like this:
createClaim: (claim: ClaimInput): Promise<ClaimCreateResponse> => Claims.create(claim),

Assuming claim is the name of an argument on the createClaim field, you should instead do:
createClaim: (args): Promise<ClaimCreateResponse> => Claims.create(args.claim),

Thanks for your swift response!
It was indeed the second parameter that I needed, to pass on the typed argument; (I had been testing with the first parameter).
Mutation: {
    createClaim: (_: any, args: MutationCreateClaimArgs): Promise<ClaimCreateResponse> => {
      return Claims.create(args.input);
    },
  },

What is the type of this first parameter? As it is the parent value for the field resolver of an entity, for a mutation this is somewhat misleading for a mutation resolver, since this would be the root entity, and thus an empty {} object of any type?

For root fields, regardless of whether they are on the Query or Mutation root type, the parent value will always be the root value. You can provide this value using the rootValueFactory option, in which case the value will be whatever the factory returns. If the option is omitted, rootValue is simply an empty object.


model gemini-pro-vision generateContentStream with Chinese prompt returns malfunctioning chunks

Expected Behavior
model gemini-pro-vision generateContentStream with Chinese prompt returns malfunctioning chunks
Actual Behavior
model gemini-pro-vision generateContentStream with Chinese prompt returns malfunctioning chunks which contains ���.
Steps to Reproduce the Problem

code

const model = genAI.getGenerativeModel({ model: 'gemini-pro-vision' });
const result = await model.generateContentStream([
        '用中文简体回答',
        ...history,
        {
          inlineData: {
            data: data.base64,
            mimeType: data.mimeType,
          },
        },
      ]);

2.get result like this:
宫保鸡丁是一道著名的川菜，起源于清朝山东巡抚丁宝桢的家厨，以花生、黄瓜、胡萝卜
、������、���丝等配料，再佐以干辣椒、花椒等调味料炒制而成。
3.text contains ���
Specifications

Version: ^0.1.2
Platform: windows

Experiencing this issue as well: https://github.com/danny-avila/LibreChat/discussions/1398

Seems similar to https://github.com/google/generative-ai-js/issues/9
Are you using 0.1.3? The original says ^0.1.2, is the actual installed node_modules version 0.1.2 or 0.1.3?

Just wanted to comment in this repo, since the issue exists in @langchain/google-genai which I believe was developed by someone at Google, and hopefully we can get some eyes on it from here.
The langchain "community" package is using @google/generative-ai at version ^0.1.0.
More details here: https://github.com/langchain-ai/langchainjs/issues/4113

If I'm reading that issue right, you don't need to change anything to get the latest version since langchain has it already set to ^ which allows the latest up to the next major. You should be able to just delete your node_modules and lockfile (package-lock.json or yarn.lock) and reinstall (npm/yarn), and you should get the latest, which is actually 0.2.1 at the moment.
To verify which one is actually installed (or see if you have duplicates), run npm ls @google/generative-ai, it should tell you.

Is anyone still having this problem with the latest version?


some tutorial about distillation dataset

Hi!
Now, I am focusing on the non-autoregressive model for translation. I want to distill some other datasets. I have trained a teacher model using Transformer. But I don't know how to save the generated data. Could you give me some suggestions?

@MultiPath

I tried fairseq-generate data-bin/wmt17_en_de_joined --path checkpoints/transformer_vaswani_wmt_en_de_big/checkpoint_best.pt --batch-size 64 --beam 5 --remove-bpe --gen-subset train --results-path data-bin/wmt17_en_de_distill but no result file was generated in anywhere..
Have you found out how to generate the distillation dataset?


Adaptive card submit action shows error message

Hi,
In Teams, adaptive card on submit action shows 'Unable to reach app' error message but the action gets completed . Is there any way to suppress/hide this messages?
Thanks

@r-vijayalakshmi - We are tracking the issue in this thread.
Please follow that thread for further updates.

We are closing this as a duplicate issue of this: https://github.com/MicrosoftDocs/msteams-docs/issues/6461


Preferences not accessable from java.

Hi,
Thanks for the plugin.
I set preference and I can able to read using plugin. But, when I tried to access the same preferences from Java code, its not available. Can you please guide me on this.

Are you using
SharedPreferences sharedPrefs = PreferenceManager.getDefaultSharedPreferences(cordova.getActivity());

to get the shared preferences? If yes, please give me snippet of code which confirms the issue.

Hey,
Sorry for the delay response.
Please see the below code. ( I used same as in SplashScreen.java )
preferences.getInteger("UserID", 0);
When I tried to print the application preference, I got only the preference which I mention in config file.
Thanks,
Sabari.

Hey,
Its working after creating sharedPref object as you mentioned.
SharedPreferences sharedPrefs = PreferenceManager.getDefaultSharedPreferences(cordova.getActivity());
Thanks,
Sabari.


[MM-17816] Reporter is not automatically set for /jira create on Jira Server, when required field is missing

Summary
MM-17816 Reporter is not automatically set for /jira create on Jira Server, when required field is missing
Ticket Link
https://mattermost.atlassian.net/browse/MM-19256
Fixes #393

This issue has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!
/cc @jasonblais @hanzei

@DHaussermann Friendly reminder to help with PR review when you have the chance :)

@DHaussermann ping

@AGMETEOR I think I see a regression on Jira Cloud with this change that does not occur on master. When custom fields must be set on the Jira side I get a 500 error.

Build plugin from this branch
Install and configure a Jira cloud instance
In Jira configuration, set a custom fields not supported by the form (radio box for example) as mandatory to create the issue.
Create a Jira issue from post or with /create and provide details
Click Create
Expected Modal closes and Link is posted that you can use to complete save in Jira after setting filed
Observed Modal remains open and shows  500 internal server error

Can you see if you can repro this? I will take a pass with Jira server and see if I notice anything else unusual.

Hi @AGMETEOR,
Can I get some clarification on the scope of this PR? When creating an issue from a post I can see your change.

The post created now contain a link with the text of the issue key that points to the issue rather than the full path.
The post created now contains by mattermost-jira-plugin

I don't see any change when attaching to an issue where the post references the Jira plugin. Should I be seeing this as well?

Hi @AGMETEOR I did a round of testing on Jira server and this does seem to be working as expected. The reporter is pre-set based on the mapped user.
That said it does seem like the 500 error observed in the same scenario for Jira cloud would need to be investigated. Please let me know if you're able to repro it.

Hi @AGMETEOR I did a round of testing on Jira server and this does seem to be working as expected. The reporter is pre-set based on the mapped user.
That said it does seem like the 500 error observed in the same scenario for Jira cloud would need to be investigated. Please let me know if you're able to repro it.

@DHaussermann going to investigate this. We could maybe increase the scope of this issue to mention the cloud instances as well?

Hi @AGMETEOR, It seems like we should. This 500 error does not repro on the master branch so, I'm concerned it could have been introduced in this PR.
And as it is, the same issue you resolved for Server is one that occurs on Cloud as well.

Hi @AGMETEOR, It seems like we should. This 500 error does not repro on the master branch so, I'm concerned it could have been introduced in this PR.
And as it is, the same issue you resolved for Server is one that occurs on Cloud as well.

Hello @DHaussermann , thanks for the review. I just made some investigations and fixed the issue on cloud instances.

Tested and passed.

Fix is working for Jira server
Reporter will be set to the mapped user
500 error on Jira Cloud no longer occurs as the solution has now been made specific to Jira server

LGTM! Thanks @AGMETEOR for the fix.
I have created a separate issue here to address the issue for Cloud installs #481

@DHaussermann for cloud the reporter is automatically set and doesn't encounter this issue.

for cloud the reporter is automatically set and doesn't encounter this issue.

@AGMETEOR that's interesting I'm able to reproduce the behaviour on Cloud where you open the link and reporter is not set. Very strange if we're not seeing the same thing as there is only 1 version of Cloud. Possibly the Jira if behaving differently based on filed configuration?

for cloud the reporter is automatically set and doesn't encounter this issue.

@AGMETEOR that's interesting I'm able to reproduce the behaviour on Cloud where you open the link and reporter is not set. Very strange if we're not seeing the same thing as there is only 1 version of Cloud. Possibly the Jira app is behaving differently based on field configuration?

@DHaussermann cloud won't show the reporter field at all after you click the generated link. When you go ahead and create the issue after adding the required field, you'll see that the reporter is set for you.

@AGMETEOR Yes, I see. I believe this does explain the difference in what we're seeing. The behaviour where reporter is not show on the creation screen can be changed based on the filed configuration and screens configuration.
On the instance I'm testing with this field is visible before the issue is created and the reporter field can be manually adjusted. With this configuration in place, the reported will be automatically set to the current user when creating from within Jira but not when the user is sent over by a link provided by the integration.
I can add these details to the new issue for clarity :)

@AGMETEOR, @DHaussermann can we merge this or do we have pending changes?

@jfrerich this could be merged as is. In which case, the issue would be resolved for Jira server but not Jira cloud.
We could the use the related issue to resolve the problem for cloud (I believe the issue is less apparent on cloud as the stock configuration side steps this problem)
Unless @AGMETEOR has any objection and would like to include it in the scope of this PR instead. Given that the issue is less prevalent on Cloud and it says in the title of this PR that the scope is for server, I'd be happy to see it merged.

@jfrerich this could be merged as is. In which case, the issue would be resolved for Jira server but not Jira cloud.
We could the use the related issue to resolve the problem for cloud (I believe the issue is less apparent on cloud as the stock configuration side steps this problem)
Unless @AGMETEOR has any objection and would like to include it in the scope of this PR instead. Given that the issue is less prevalent on Cloud and it says in the title of this PR that the scope is for server, I'd be happy to see it merged.

No objections at all. We can work on resolving the issue on cloud as a separate issue.

Thanks, @AGMETEOR and @DHaussermann.  Merging this ticket and marking issue resolve.


Skip auth data synchronization in the case of unscoped tokens

When a user sends an unscoped token to the server, Keystone still can authenticate
him, but doesn't include information about user's project and roles in the response.
In this case we have to skip the synchronization part, to prevent possible errors.

/test cloud-provider-openstack-unittest

/lgtm
/approve


terraform_azure_example_test.go Type Issue

I am running the example test in terraform_azure_example_test.go, however I'm getting the following test failure:
--- FAIL: TestAzVirtualMachine (28.83s)
    virtual_machine_test.go:51:
        	Error Trace:	virtual_machine_test.go:51
        	Error:      	Not equal:
        	            	expected: compute.VirtualMachineSizeTypes("Standard_D2s_v3")
        	            	actual  : compute.VirtualMachineSizeTypes("Standard_D2s_v3")
        	Test:       	TestAzVirtualMachine
FAIL

import (
	"os"
	"testing"

	"github.com/Azure/azure-sdk-for-go/profiles/latest/compute/mgmt/compute"
	"github.com/gruntwork-io/terratest/modules/azure"
	"github.com/gruntwork-io/terratest/modules/terraform"
	"github.com/stretchr/testify/assert"
)

func TestAzVirtualMachine(t *testing.T) {
	t.Parallel()

	subscriptionID := getTargetAzureSubscription("")

	terraformOptions := &terraform.Options{
		TerraformDir: "../fixtures/az-virtual-machine",
	}

	// defer terraform.Destroy(t, terraformOptions)

	terraform.InitAndApply(t, terraformOptions)

	vmName := terraform.OutputList(t, terraformOptions, "vm_name")[0]
	resourceGroupName := terraform.Output(t, terraformOptions, "resource_group_name")

	actualVMSize := azure.GetSizeOfVirtualMachine(t, vmName, resourceGroupName, subscriptionID)
	expectedVMSize := compute.VirtualMachineSizeTypes(compute.VirtualMachineSizeTypesStandardD2sV3)

	assert.Equal(t, expectedVMSize, actualVMSize)
}

Go: 1.14.2 darwin/amd64
Terraform: v0.12.24
Any idea's?

Definitely looks like a bug in the test!
Could you use the reflect library to print out the types of the expected and actual vars? Perhaps one is wrapped in some struct that is causing the equal check to fail (even though the string versions look identical).

Please see https://github.com/gruntwork-io/terratest/issues/89 for the status on Terratest with Azure. In particular, we're starting some work around it, and when that work is done, we'll be able to come back to this question!

Hi @neal-shah,
Are you still having the problem with the assert failing?
There have been several updates to the Azure compute module since then and I would like to help if needed.

Hey @davesee,
Apologies it's been a while since I looked at this! I'll try and find some time hopefully in the next week or so, and let you know!  I've been working on AWS and GCP recently so have left Azure on the back-burner.
Cheers!

Hi @davesee,
I just run into above problem with the virtual machine example test. Names are the same but comparison fails.
azure-sdk-for-go: v46.0.0+incompatible
terraform: 0.14.7
Any ideas?

Hey @mjooz
The sdk package version should not matter since both module and test use the same version. You can update them and try of course.
I ran both _example and _vm_example and was not able to reproduce the error. I added this to see the types, perhaps see if you get something other than string. Also you can try the assert.EqualValues to be less strict.
a := reflect.ValueOf(actualVMSize)
fmt.Println("Actual VM Size is of type:", a.Kind())

e := reflect.ValueOf(expectedVMSize)
fmt.Println("Expected VM Size is of type:", e.Kind())

assert.EqualValues(t, expectedVMSize, actualVMSize)

results
    Actual VM Size is of type: string
    Expected VM Size is of type: string
    --- PASS: TestTerraformAzureExample

Hope this helps!

Hi @davesee,
issue was (and still is) with Go version and stretchr/testify package - errors from above are present if Go 1.16.2 is used.
It works fine with Go 1.14.15 or 1.15.10. That's good enough for me.


Huge Number of Spurious Requests Generated

There seems to be something that's generating a huge number of reqests when page loads. I get 231 requests generated when visiting https://docs.perl6.org/type/ComplexStr
This is very problematic for users who pay for their bandwidth or users on slow connections, such as users on mobile and wifi, or users in countries with less speedy Internet.
It looks like it's sending a HEAD request for every link on the page? During the day, I browse from a monitored corprorate network. I don't know the details of the data they gather, but I really wouldn't want them to think I'm vising millions of pages per day, instead of working.
This is also a needless load on our volunteer-donated server.
Here's a run on a regular 2G network simulation. 231 requests, half a meg transfer, and it takes half a minute to load:

It seems that the JavaScript website tries to detect broken links for every single requests on the docs:
https://github.com/perl6/doc/blob/master/html/js/main.js#L127

This needs to be removed. We should not be running this check in everyone's browser on every page load.

Related to https://github.com/perl6/doc/issues/697

Cache is in place. It's checking once per commit per page. If the commit changes, the cache is wiped.

fixed with dcab8da86a


getCleanClusterName fixed

Fixes #76

Thank you very much!

I would like to contribute more in this repo. Thank you.


Consider bundling static files

By default, the Mirrorbits web UI currently loads static files (CSS/JS/fonts) from different upstream providers, which impacts users' privacy by leaking browsing habits to those providers.
Even though there are workarounds that could be implemented by individual user's (eg. using Tor) and sysadmins (eg. using LocalJSPath), Mirrorbits could also bundle those files to provide out-of-the-box mitigation for this issue for all Mirrorbits users.
The contrib/localjs/fetchfiles.sh could probably serve as part of the solution if it's integrated in the release workflow.
We were considering implementing the automated fetching and serving of static files in our Mirrorbits instance, but decided to ask here before proceeding, in case that's something Mirrorbits would consider solving upstream.
Thanks for the nice piece of software. :-)

Yes, this should be fixed upstream. Please send patches.


Add types property to package

This exposes types for the compiler
Continues #48

nice!

Thanks @ShaMan123!
@jamesdaniels this looks like a helpful fix to me, but wanted to double check with you before merging.

pls 🙏

@jhuleatt Can you say future version number with this pls?

The latest version on npm, 6.0.0, has types.


[BUG] warning with Machop

Every time a Machop spawns the notification keeps on spamming. It only happens with this pokémon and his notification setting.

Same problem but it's dratini in my case.

similar, but only with squirtle

Pidgey and Weedle, same for me.


bad minute error in crontab

I have tried some with CRON_TIME but I have get the error:

starr-certsdumper-1  | 2022-09-17 17:46:19: Docker container has been started. You can find the log file at /var/log/cron.log
starr-certsdumper-1  | "scheduler.txt":0: bad minute
starr-certsdumper-1  | errors in crontab file, can't install.

Docker compose.yml
services:
  certsdumper:
    image: rafi0101/traefik-ssl-certificate-exporter
    environment:
      - TZ=Canada/Eastern
      - ON_START=1
      - CRON_TIME='* * */2 * *'
      - CERT_OWNER_ID=0
      - CERT_GROUP_ID=1000
    volumes:
      - ./config/traefik/acme.json:/app/traefik/acme.json:ro
      - /etc/ssl/:/app/certs
    deploy:
      restart_policy:
        delay: 34h

I have tried with simple and double quotes. Without CRON_TIME set, it works like a breeze

And, by the way, congrats for your work!

The following seems to work
    environment:
      CRON_TIME: "* * */2 * *"


Disable android studio build

Problem
Android studio compilation seems to hang.
Change overview
Disable it. We still test general android compilation without studio.
We lose android studio configuration validation, however that does not seem as critical as training people to ignore android CI.
Testing
CI will test this for android being able to complete. Change is generally quite safe as it just disables a build step.

Android build seems to complete now.
I still see it taking a long time in "Cleaning orphan processes" so may our build leaks somehow ... still needs to be investigated, but at least this should move ToT towards green. Marking as hotfix.


Issue#758

Github Issue (if applicable): #758
Explanation of Bugfix/Feature/Enhancement:
Updated observe() to make sure titles are added when flags are added during transaction adding/editing and also when hiding/unhiding scheduled transactions.
Recommended Release Notes:
Flag names will now properly display on hover after hiding/unhiding scheduled transactions as well as when adding a flag while editing a transaction.

Thank you!


Fix typo in upgrade name

What was wrong?
Not English word.
How was it fixed?
Made into English word.
Cute Animal Picture

Codecov Report

Merging #403 (a0a316d) into master (f8c026f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #403   +/-   ##
=======================================
  Coverage   95.73%   95.73%
=======================================
  Files          81       81
  Lines        4313     4313
=======================================
  Hits         4129     4129
  Misses        184      184

Flag
Coverage Δ

unittests
95.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8c026f...a0a316d. Read the comment docs.


Update for Django 4 and Wagtail 4 ?

I have brought the code in par with Django 4 and Wagtail 4. The UI still looks a little off and there's still work to do to reimplement the views as class-based. I will soon create a PR for the code part and probably start implementing the better UI then.

Fixed in wagtailnews 4.0


Succinct Tree support?

I recently became interested in succinct trees, in particular the balanced parentheses (BP) version with an eye on fully-functional succinct trees. I've been staring at various ways to implement fwd-search, bwd-search and rmq which appear fundamental to support various operations efficiently. I am daunted as I cannot find Rust implementations of this.
I saw an old reddit discussion where you mentioned wanting to look into succinct trees. This is basically just an inquiry about where your thinking about this is now, in the hopes that there's been secret progress on this. :)  Thank you!
A brief literature reference:

"Fully-Functional Succinct Trees" - Sadakana and Navarro. This is the big one on BP trees. Proposes range min-max tree to support the operations.
"Succinct Trees in Practice" - Arroyuelo et al . This concludes that the fully functional representation offers good practical trade-offs too.
"Simple and efficient fully-functional succinct trees" - Cordova and Navarro. Contains a refinement on the range min-max tree which may be easier to implement.

I haven't made much progress since then, instead focussing on improving the overall API and adding WaveletMatrices. There is an unpushed branch where I began with a BP implementation, but that hasn't gone very far yet. There is also the dev_dfuds branch which contains another attempt at Depth-First-Unary-Degree-Sequence encoding of a succinct tree, but I am not happy with that codebase and its performance, which is why I switched to BP (it's simpler and sufficient for most usecases).
Maybe I will continue with it in the future. Technically the dfuds branch already implements fwd_search and bwd_search, but the implementation contains bugs iirc.
Thanks for the paper references, I will have a look, especially at the last one because I am very unhappy with my current min-max tree attempts.

Thanks for your reply! I'll take a look at the branches. I'm out of my depth here as I only learned about the existence of the whole field of succinct data structures two days ago. :)
I ended up here because I was looking at optimizing xpath queries over XML of all things. BP trees seem to offer good trade-offs in that domain.
Note that the code referenced by the last paper is unfortunately not available. I asked Navarro about that yesterday - if you don't know anything about succinct data structures you don't know he's super important yet and just drop him an email.

Well, since all my pals got corona, all my weekend plans were gone, so I took the time to give BP another go. It seems to work for now, and you can find it on the now pushed dev_bp branch. Basic tree traversal operations are implemented. Feel free to have a look or experiment with the work-in-progress build.
There are still a bunch of operations that I need to implement, and a lot of testing to do, as well as benchmarking and optimization, so it will take some time before this is production ready.

Wow, this is beyond awesome!
My understanding of this approach had grown over the weekend rereading papers a lot. My understanding is that the practical implementations typically stop at a binary min max tree which already has good performance. I was pondering about the size of the buckets and lookup tables for e, m, M and such. I am so looking forward to studying your code!

I do hope your pals will be okay, though!

Here is a bit of early feedback on the branch. There's a compiler error in last_child, as self.close() can return None. I've fixed it to be:
    fn last_child(&self, node: Self::NodeHandle) -> Option<Self::NodeHandle> {
        debug_assert!(
            self.vec.get(node) == Some(OPEN_PAREN),
            "Node handle is invalid"
        );
        self.vec.get(node + 1).and_then(|bit| {
            if bit == OPEN_PAREN {
                if let Some(close) = self.close(node) {
                    self.open(close - 1)
                } else {
                    None
                }
            } else {
                None
            }
        })
    }

Clippy tells me a quite a few of the and_then can be simplified to a map() too, but maybe that's just a style opinion issue.
(one of the benches incidentally also has a compiler error, bit_set_iter1 apparently doesn't exist on RsVec.

Yeah the trait implementation is untested. I am unsure if the if let is necessary, as close can only return None at this point if the parentheses expression is unbalanced, at which point a panic due to an illegal unwrap() might be fine. On the other hand there aren't many instances were the BP implementation is fundamentally broken if it is unbalanced, so it might also be desireable to return None here and maintain a bit of consistency even on unbalanced expressions (who knows what down stream crates might want to do)
The bench compiler error is fixed on master, I just have to rebase the branch.

I'm going to give some feedback based on various papers I read. This is not criticism of the code, but a bit of analysis to see whether we can learn from these papers for future improvements, or if we deviate from it, do so consciously. I'm sure you're already aware of much of this, but it is also for my own greater understanding.
First the "Succinct Trees in Practice" paper.
In section 2.3, it mentions the block size is "b = w / 2", where "w" is the bit length of a machine pointer (w is defined in section 1). So on 64 bit machine this would mean a block size of 32 bits.
It also mentions a "superblock".  I'm having trouble figuring out what k is, but it does say "k = Θ(w/ log w)". With w 64 bits, w / log w is a bit over 15. So perhaps a superblock size k of about 16 would make sense. This would have a superblock be 1024 bits. But actually in the implementation section it says:

Storing 32-bit numbers and using, say, k = 32 and b = 512, the space is 2 × 2 · 32 · (2n)/(bk) ≈ 0.78% overhead.

So is b 32 or is b 512? I'm confused. I'm curious to explore the motivations for shorter and longer block sizes with this algorithm.
Now to go to paper "Simple and Efficient Fully-Functional Succinct Trees":
In section 2.3 "range min-max trees" it describes the simple binary tree with a base block as being the practical solution implemented for this structure (referring to "Succinct Trees in Practice" by Arroyuelo et al), so that's I think the current vers implementation as well, right?
In section 2.2 it mentions primitives:

fwdsearch, bwdsearch, rmq, rMq, mincount, and minselect

We currently implement fwdsearch and bwdsearch, but not rmq, rMQ, mincount and minselect.
mincount is used to implement degree(i) (number of children), childrank(i) (children to the left of node i).
minselect is used to be able to implement child(i, q), the qth child of i.
rmq is used to implement lca(i, j) (lowest common ancestor of i and j),
rMq is used to implement deepestnode(i) (first deepest node in subtree i) and height(i) (the height of i, distance to deepest node).
It also mentions that required are:

rank and select on 0, 1, and 10

I don't think vers has these over 10. It's used to implement leafrank(i) (number of leaves preceding node i), leafselect(k) (kth leaf of the tree), numleaves(i) (number of leaves in subtree i), and leftmostleaf(i) and rightmostleaf(i) (leftmost/rightmost leaf of node i).
I'll note that at the present time I don't think any of these additional operations vers doesn't have yet are particularly useful for my XML purposes, and they may be more trouble to implement that they're worth. The possible exceptions are degree(i) and child(i, q).
One interesting section in 2.3 is:

By using small precomputed tables that allow us to scan any block of c = (lg n)/2 bits in constant time (i.e., computing the analogous to ﬁelds e, m, M, and n for any chunk of c bits), the total time of the operations is O (b/c + lg n) bits.

It doesn't specify how in detail it could be done, and at first sight it would imply quite small block sizes in order to be able for the precomputed tables to be small. But it suggests a possibly more compact and/or efficient way to arrive at this information. An 8 bit lookup table looks doable. I'm also curious whether we couldn't calculate this information using bit twiddling - count_zeros() and count_ones() would seem useful in order to calculate excess for instance, and using rsvector's get_bits().
In section 2.3 it also has:

v.n is the number of times the minimum excess occurs in the area

In section 4.1 it has:

or 4 bytes if the ﬁeld v.n is not required, as it is used only in the more complicated operations

I see v.n is used to support mincount and minselect, so we can see it supports the operations degree, childrank, child.
In section 3 it then goes into a O(lg lg n) time solution. It immediately says in section 4 that:

Still, we further simplify some parts to speed them up in practice. As a result, our
implementation does not fully guarantee O(lg lg n) time complexity, but it turns out to be faster than the state-of-the-art
implementation that uses O(lg n) time. As this latter implementation essentially uses one binary rmM-tree for the whole
sequence, our experiments show that our new way to handle inter-bucket queries is useful in practice, reducing both space
and time.

My understanding of section 3 is that multiple mM-trees are maintained, one per bucket. The block size b is different again. Now it's

b = lg n lg lg n

which by my calculations comes down to very small block sizes compared to 512, like 36 bits for a 1 million node tree.
Then in 3.1 it describes how to do inter-bucket forward and backward searching, the details of which I haven't digested yet.
In 4.1 it says the bucket size is 4 kilobytes, which allows 16 bit integers to store the excess in the nodes in each tree. v.e (total excess) is not stored, and instead v.m. and .vM (min and max excess) are stored in absolute form relative to their current bucket. So this would allow the tree to shrink a bit.
Ah, more information about b: 512 and 1024 are practical and finally another hint about lookup table size.

Preliminary tests yielded the following values to be reasonable for b: 512 bits (with lookup tables of 8 bits) and 1024/2048 bits (with lookup tables of 16 bits). In particular, for b = 1024 our rmM-trees have height h = lg(β/b) = 5 and a sequential scan of a block requires up to 64 table lookups.

There are also interesting details on how to implement section 3.1.
The measurement sections demonstrate that the bucket approach is usually faster than the simple block-based approach, but that also depends a lot on the specifics of implementation, I think. What do you think?
The lowest hanging fruit I think is in the lookup tables or other methods to determine excess, maximum and minimum excess for a block.

As to implementing additional operations, it depends on whether they are of much practical use to implement them. I can see practical use for degree and child myself but the current set is already pretty good. Of course it depends on your use case, but there's something to be said for simplicity.
The note in "Succinct Trees in Practice" is interesting concerning rmq:

The most practical implementation we know of for rmq [9] requires 62.5% extra space on top of P [1, 2n], and this would put the representation out of competition in terms of space requirement. A theoretical, not implemented, alternative solution to lca(x, y) is given by operation double-enclose [19]. We opt, therefore, by taking parent on the less deep node until it becomes an ancestor of the deeper one, then this is the lca.

It could be simpler ways to implement rmq exist now, but it may still not be worth it. I found Practical Range Mininum Queries Revisited and Faster range minimum queries but I haven't gone into this stuff.

The bitvector has a block size of 512 for its rank/select structures because in practise that is way more worth it than adjusting it by the vector length (even though the vector is technically no longer succinct with a fixed block size).

Yes, in the implementation section it immediately goes back to using 512 and 1024 anyway! So while the buckets approach may potentially be worthwhile, we can ignore the theoretical sizes of blocks which are really all over the place.

It could be simpler ways to implement rmq exist now

I mean you can check out the "FastRMQ" implementation in vers, (which is slower than the other one, but more memory efficient :P)

Oh yeah I saw this, but I forgot again! I looked at it and couldn't find a rMq and I am still generally quite confused about this stuff. But the note about it taking extra space and reducing the competitiveness may still be valuable.

Oh well converting an rmq into an rMq is lucky pretty easy in Rust by using Reverse

The latter approach seems viable, the superblocks are just the higher tree levels, yes.

Plan of action:
Currently, I am quite sure I can support the standard navigation primitives (except child(i, q)), level-order access, DFS-order access (pre- and post-order), and some of the simple extra queries (like depth(i)).
I would like to support child(i, q) since that is a pretty important query, but it requires minselect support, and I don't want to add that just now.
So here is what I am planning to do:
I will begin benchmarking the current implementation, especially normal navigation queries. I don't think I will focus on the level-order operations, since using BP and then traversing the tree in level order sounds dumb, just use LOUDS at that point. So I am fine if level-order traversal isn't a focus for optimization.
I will then implement the lookup table optimization, because that should be relatively independent of any other optimizations and provide me with an idea of how big the block size can be.
Next, I will try to implement the bucket approach of the Simple and Efficient fully-functional Trees paper. They explain how they chose bucket sizes, as you mentioned earlier, but then later fix the bucket size to 2^15 in practice, which is obviously the best choice because it lets you fix the variable sizes in the mM-tree to 16 bit, so I will be doing that as well.
After I did that, I will see how I can support minselect. I want to keep memory footprint in mind, though, so maybe I will arrive at the conclusion that supporting child(i, q) isn't worth it. Do you need it for your work, or is it just a nice thing to have?

On level order: it may make sense to support this in a general DOM library; I had a need for it and added it to my Xot XML library for instance, even though its main axes are preorder. But it's definitely not a performance concern and I don't use it for XPath so that's fine.
On getting access to the nth child of a node and getting the total number of children of a node: sounds good to defer this to later. I need to change my xpath bytecode engine where I go through tree axes to use iterators for other reasons too.
There is a use in xpath to get a count of descendants or children quickly, but since filters are in play anyway (queries like "all nodes with this node name") the tree level support is of limited utility I think.
All this is a long way of saying: your plan sounds great! Focusing on optimization what you have over additional features sounds like the right way forward.
PS fm-index is now released using vers so I will retire my fork. I made progress in my thinking about how to best use it too. But I am only going to be active in a limited way over the holidays, and will pick it all up again in January. Happy to chat here though!

I am reading through commits, enjoying seeing the progress made.
One question I have is about the benchmarks: you mention benchmarking all the important operations and I see parent, previous sibling and next sibling, but to my surprise I saw last child rather than first child.
I am used to implementing forward axes (children, descendants, following) using first child and next sibling, and backwards axes (ancestors, preceding) using parent and previous sibling.
Maybe I read it wrong, but it made me curious - why is last child important rather than first child?

First child is trivial because in BP the nodes are ordered depth-first, so the first child of node i is always at i+1, unless i+1 is 0, in which case ì is a leaf. It's important, but not important to benchmark.

I implemented lookup tables of 8 bit, which yields 20-40% speedup depending on tree size and operation. Larger trees get less speedup because the query runtime is less dependent on the scanning of blocks in the vector, and more on the search in the mM tree.

Interesting! I saw you also added a 16 bit lookup, does that make a difference?

Still testing

Well so, I have implemented an 8-bit lookup scheme that can lookup all possible excess queries in an 8-bit block, as well as a 16-bit scheme that can only lookup if a 16-bit block contains the query result but then has to search the block. The 8-bit scheme requires 4 KiB for the table, the 16-bit scheme requires 128 KiB.
The 16-bit lookup is faster, and may allow for larger block sizes, which will reduce the size of the mM trees, however this reduction doesn't seem to affect runtime itself, so this is a consideration of memory footprint.
I have gated the 16 bit scheme behind a crate feature and intend to keep it this way to reduce binary size if the feature isn't required. At the moment there is also code to support the 16-bit scheme for 8-bit blocks but that is slower than the current 8-bit scheme and isn't possible to activate with crate features, the code just exists (it's just a few constants that are currently disabled by the 16-bit crate feature)

Cool! I saw various commits in this direction.
I am going to sit down and try to build the XML tree library with it next week. I have all the pieces to do so now I think. The XPath accelerations which brought me here are going to be more involved and require a significant rework of the XPath engine but using the new tree implementation for read only requirements should be a smaller step.
I am really curious about the implications of that: compared to the non succinct approach where each node has a previous sibling, next sibling, parent and first child reference (plus a hashmap for preorder info) some core operations will be slower. But more will fit in CPU cache plus I can get preorder without additional storage.
The real benefits have to do with the additional indexes I can provide on node name and text but as I said using those is more involved.

I will work on a bucket approach for the MMTs next, maybe optimize the MMT struct size, and then look into rmq/mincount


Paint icon with color does not work no more

When I use "generic icons" tool I can not paint icons with color (flat foreground color) - https://romannurik.github.io/AndroidAssetStudio/icons-generic.html#source.space.trim=1&source.space.pad=0&size=24&padding=8&color=33b5e5%2C100&name=ic_example
Two months before I was able to do this, so there is a regression in last few commits maybe.
Please fix that, it is too critical thing for me.
Thanks!

Duplicate of #74

I will try another browther then. Thanks for quick reply!

Works in firefox. Thanks for ypour great tool one more time man!


how to render a random episode?

Hi, Jacobkrantz ~ How do you render the 'gif' performed in the readme file? I want to see what the agents was doing closely for each action within the reconstructed scenes for a random episode. Can you give me some suggestions? Thank you~

You can save videos during agent evaluation using VIDEO_OPTION and VIDEO_DIR in your experiment config. Example:
...
VIDEO_OPTION: [disk]
VIDEO_DIR: videos
...

https://github.com/jacobkrantz/VLN-CE/blob/5ce28a9471ad86a41aac2cf709374e3d24ccae84/vlnce_baselines/config/default.py#L19
If you want to customize what the video frames show, you can look into the function that generates a single frame:
https://github.com/jacobkrantz/VLN-CE/blob/5ce28a9471ad86a41aac2cf709374e3d24ccae84/habitat_extensions/utils.py#L11


declared test_port variable to easily switch test ports

port 8080 is being used multiple times in this test file, but scenarios where port 8080 is already used by other apps forces you to change all text where "8080" is mentioned. Instead, i declared a TEST_PORT = 8080 variable that can be easily changed if port 8080 is not being used by the app

yeah that great initiative but it would be better it we added to .env instead of declared directly in the code

@hamzouvic Great remark, it is indeed a good practice to add a .env file to avoid sharing sensitive information. But adding a .env file also implies that I have to commit and share the .env file publicly in this repository. I believe it is up to the developer that will use this repository to create their own .env file to avoid sharing sensitive information on the web including API keys. Do I keep it like and merge or do I add the .env file  ?


Port remote APIs to 2.0

Tracking issue for adding the remote APIs back to dev-2.0. They were removed as the storage interface changed.

@juliusv you looked into this already. Any progress/blockers so far?

@fabxc Well, the new storage append interface (using refs) combined with the new staleness handling wrapped around it has made it more complicated and left me confused, so I didn't write any code yet. I might make an attempt this week, but I'll be gone for two weeks (June 11 - 25) afterwards, so it'd be up for grabs during that time if I didn't get to anything yet.

Are we fine with shipping an initial 2.0 with remote APIs disabled? Seems fine to me TBH, given that they are experimental. Breaking stuff we should get done before is just piling up... so I want to cut down what we can.

I don't think this is a good idea and would not be in favor of that. Having
to look at some feature matrix to understand which release supports which
feature is very user unfriendly and confusing.
On Tue, Jun 6, 2017 at 1:45 PM Fabian Reinartz<EMAIL_ADDRESS>wrote:

Are we fine with shipping an initial 2.0 with remote APIs disabled? Seems
fine to me TBH, given that they are experimental. Breaking stuff we should
get done before is just piling up... so I want to cut down what we can.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/prometheus/prometheus/issues/2811#issuecomment-306461625,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAANaE0PE2lHY0g8QeMd4UqJju9CEAltks5sBTvFgaJpZM4Nw9Jb
.

I think we need the remote APIs for a 2.0.

So who is committing to adding these? We are currently committed to:

/api/v2
CLI changes
rule group changes and migration tooling
Backup support
Deletion support

We only have so much capacity and someone has to handle

Storage migration (docs and/or tooling)
Remote APIs

Remote APIs

Let me have another look at that and I will give you more of detail about commitment or not by tomorrow.

I'll commit to handling this is @juliusv doesn't have time.  Remote APIs have been super popular, I think it would be a mistake to not include them in v2.

@tomwilkie That'd be brilliant. I don't think I'm able to commit to full PRs on those before sometime in July, as I'm unavailable during the next two weeks and have plenty of unrelated stuff to take care of. So if you want to go ahead, please do so!


[Bug]: GPTAssistantAgent None value in Instructions and Tools although assistant ID is provided

Describe the bug
when providing an assistant ID for GPTAssistantAgent. the code pathway at line 117 always has a None value for variables "instructions" and "specified_tools". this is because the data within self._openai_assistant is never copied to local variables "instructions" and "specified_tools".
Steps to reproduce
to reproduce, using 0.2.27  .... assuming an agent as a knowledge base for autogen documentation.
llm_config = {"model": "gpt-4-turbo", "api_key": os.environ["OPENAI_API_KEY"]}
gpt_assistant = GPTAssistantAgent(
name="assistant",
llm_config=llm_config,
assistant_config={"assistant_id": "XXXXXXXXX"}
)
user_proxy = UserProxyAgent(
name="user_proxy",
code_execution_config={
"work_dir": "coding"
},
human_input_mode="TERMINATE"  # Adjust as needed for your use case
)
user_proxy.initiate_chat(gpt_assistant, message="tell me 2 things about autogen?" , max_turns=1)
https://github.com/microsoft/autogen/blob/main/autogen/agentchat/contrib/gpt_assistant_agent.py
put a break point at line 121 and observe the None value.
Model Used
got-4-turbo .. but doesn't matter
Expected Behavior
the code should have loaded the existing agent in openAI with its tools and instructions.
Screenshots and logs
No response
Additional Information
No response

@IANTHEREAL could you take a look at this?

I'm not sure if I've understood this correctly.  You mean we should initilize the  self.system  using the instruction populated from existing openai agent?

Did this bug cause you to encounter any unexpected behavior? Please tell me more, will help me to understand it

Hello @IANTHEREAL,
Here is how to reproduce

(a) Using the openai.com web site
(b) create an assistant
c) create a storage unit
(d) upload files to the storage unit
(e) assign the storage unit to the assistant
Using your coding environment and using autogen
attempt to retrieve the existing assistant using the ASSISTANTID
BUG: Autogen does not retrieve the (a) instructions (b) storage unit (c) file search function
Expected Behavior: autogen should have retrieved the existing assistant with function, instructions and storage unit.

my use case was:
using openAI console, define a RAG assistant and provide it with some files to search through the storage unit
Use the RAG assistant through autogen as a knowledge agent
Autogen doesn't retrieve pre-defined storage unit and file search function for a pre-existing agent through its ID from OPENAI.com

@ekzhu if other guys can help to handle this issue, I have been pretty busy lately

I am still a bit of confusing. Maybe you can review the below and tell more about what you are expected.
import logging

from autogen import UserProxyAgent, config_list_from_json
from autogen.agentchat.contrib.gpt_assistant_agent import GPTAssistantAgent

logger = logging.getLogger(__name__)
logger.setLevel(logging.WARNING)

config_list = config_list_from_json("OAI_CONFIG_LIST", file_location="notebook")
llm_config = {"config_list": config_list}

gpt_assistant = GPTAssistantAgent(
    name="assistant",
    llm_config=llm_config,
    assistant_config={"assistant_id": assistant.id}
)

user_proxy = UserProxyAgent(
    name="user_proxy",
    is_termination_msg=lambda msg: "TERMINATE" in msg["content"],
    human_input_mode="NEVER",
    max_consecutive_auto_reply=1,
    code_execution_config=False,
)
user_proxy.initiate_chat(gpt_assistant, message="When will we get to san francisco according to our traveling plan?")

The output show it can work well on my traveling plan.
import logging

from autogen import UserProxyAgent, config_list_from_json
from autogen.agentchat.contrib.gpt_assistant_agent import GPTAssistantAgent

logger = logging.getLogger(__name__)
logger.setLevel(logging.WARNING)

config_list = config_list_from_json("OAI_CONFIG_LIST", file_location="notebook")
llm_config = {"config_list": config_list}

gpt_assistant = GPTAssistantAgent(
    name="assistant",
    llm_config=llm_config,
    assistant_config={"assistant_id": assistant.id}
)

user_proxy = UserProxyAgent(
    name="user_proxy",
    is_termination_msg=lambda msg: "TERMINATE" in msg["content"],
    human_input_mode="NEVER",
    max_consecutive_auto_reply=1,
    code_execution_config=False,
)
user_proxy.initiate_chat(gpt_assistant, message="When will we get to san francisco according to our traveling plan?")

Then let's print the instructions, tools, and tools resources
print("system message", gpt_assistant.system_message)
print("instructions", gpt_assistant.openai_assistant.instructions)
print("tools", gpt_assistant.openai_assistant.tools)
print("tool_resources", gpt_assistant.openai_assistant.tool_resources)

The output shows all properties are set correctly
print("system message", gpt_assistant.system_message)
print("instructions", gpt_assistant.openai_assistant.instructions)
print("tools", gpt_assistant.openai_assistant.tools)
print("tool_resources", gpt_assistant.openai_assistant.tool_resources)

@aosama can you take a look at IAN's comment?

I will re-execute the same scenarios again with OPENAI and will report back here


Added Tatum to builder tools

Hi,
Thanks for the PR! Can I request you to please fix the build error (JSON)?

Please let me know if you need help fixing this.


Feature Enhancements and Bug Fixes

Overview:
This PR introduces several new features and fixes to improve the user experience and functionality of the application. Key updates include enhanced interactivity, export functionalities, UI improvements, and bug fixes.
New Features:

Play on Hover:

Added functionality to play media when hovering over the entire node for better interactivity.

Export Handler:

Implemented an export handler on the main page.
handleExport function added as a parameter to the header, along with an export button for easy data export.

Upload Flow:

Introduced an "Upload Flow" button on the main page for streamlined file uploads.

User Menu:

Added a user option in the header menu for better user profile management.

Bug Fixes and UI Improvements:

Naming and Position Fixes:

Corrected naming issues and positioning of alerts in the export modal for clarity.

Button Styling:

Updated buttons in the components section header to utilize ShadCN button styles for consistency.

Select All Classes:

Resolved issues with the "Select All" functionality for improved batch operations.

Import Function:

Fixed the import function to ensure reliable data import processes.

Error Naming:

Standardized error naming conventions for better error handling and debugging.

Commits:

Added play on hover of entire node - Enhances interactivity by enabling play on hover.
Added Export handler on Main Page - Implements core export functionality.
Added handleExport as parameter of header and added button to export - Integrates export control into the header.
Fixed naming of errors - Improves error handling by fixing naming issues.
Fixed buttons not using ShadCN buttons on header of components section - Ensures consistent button styling.
Fixed naming and position of alert on Export modal - Corrects alert display issues in export modal.
Fixed select all classes - Resolves issues with the "Select All" feature.
Added Upload Flow button to main page - Introduces an upload button for file handling.
Fixed import function - Ensures reliable import operations.
Added user on header menu - Adds user options to the header for profile management.

These updates collectively enhance the application's functionality, user interface, and overall user experience.

LGTM
all testes passed


Update deprecated hardware check

Warning: Calling Hardware.is_64_bit? is deprecated!
Use Hardware::CPU.is_64_bit? instead.
/Users/pair/Library/Caches/Homebrew/Formula/pup.rb:7:in `<class:Pup>'

Ping

I don't use brew and don't have a way to test this. If youd like to submit a patch I'd be happy to review.

Oh wow, I'm really sorry. Thought this was an issue. Lgtm


Script version comment is one release behind

Describe the bug
A small thing, but it was confusing at first. It appears the 4.3.6 release has an initial comment in the script that says it is 4.3.5.
To Reproduce
Downloaded the release tarballs from GitHub,  v4.3.5.tar.gz and v4.3.6.tar.gz
A comparison reveals that v4.3.6.tar.gz contains v4.3.6, with the backwards compatibility fix. And the package.json is updated with the new version.
But, the initial comment in the JS files says v4.3.5 for both:
diff -r iframe-resizer-4.3.5/js/iframeResizer.contentWindow.min.js iframe-resizer-4.3.6/js/iframeResizer.contentWindow.min.js
1c1
< /*! iFrame Resizer (iframeSizer.contentWindow.min.js) - v4.3.5 - 2023-03-01
---
> /*! iFrame Resizer (iframeSizer.contentWindow.min.js) - v4.3.5 - 2023-03-08

And:
diff -r iframe-resizer-4.3.5/js/iframeResizer.min.js iframe-resizer-4.3.6/js/iframeResizer.min.js
1c1
< /*! iFrame Resizer (iframeSizer.min.js ) - v4.3.5 - 2023-03-01
---
> /*! iFrame Resizer (iframeSizer.min.js ) - v4.3.5 - 2023-03-08

Thank you for maintaining this very helpful library.

Fixed in v5.0.0-RC.1


Log more details if notification of promise fails in PromiseNotifier …

…and AbstractChannelHandlerContext
Motivation:
To make it easier to debug why notification of a promise failed we should log extra info and make it consistent.
Modifications:

Create a new PromiseNotificationUtil that has static methods that can be used to try notify a promise and log.
Reuse this in AbstractChannelHandlerContext, ChannelOutboundBuffer and PromiseNotifier

Result:
Easier to debug why a promise could not be notified.

@Scottmitch @nmittler PTAL

@normanmaurer LGTM

Cherry-picked into 4.1 (6bbf32134ac8efbb40e9adf177659fd8325ab596) and 4.0 (e9d5c661733108363d5ce55d9beadf9f0bab7757)


fix: #2375 tooltip rerenders on hover

Description
closes #2375
Every mounted tooltip is re-rendered on hover. This resulted in quite noticeable performance problems as our app has a lot of elements with tooltip
Here are some context-less profiles from our app:
before:

after:

Since isOpenDelayed is used only in event callbacks replacing it with ref seems like a safe and useful change
Please let me know if anything is missing or more tests with proofs are required

Do you have plan to merge this? Still happening

@chaance  Apologize for the tagging.
I believe the usage of useState internally for logical control is a common performance symptom why Radix component is slow. This leads to a lot of unnecessary re-render.
Tooltip is just being one of them.
Hence,
useState => for rendering control. (like {error && <ErrorComponent error.desc />}, the error state or description directly controls the value or display)
useRef => for internal logic state control that has nothing to do with rendering. (like function (){ if (ref.current) {}  } )


Swtich to embedded TLS roots instead of Native TLS

Mac Native TLS takes a long time to load.
https://github.com/rustls/rustls-native-certs/issues/30
This is an issue as some git operations spawn (sequentially) a large number of git-xet subprocesses. This switches reqwest to using an embedded Mozilla certificate roots.  (webpki-roots crate). This reduces push time by about 33%.

Could this be made optional? Embedding root certificates (even for internal use) is a big no-no for some Linux distributions. I package this for Arch Linux for example which has a policy against it. Since the problem is macOS specific could the option to eschew the system certificates at least be made platform specific? If this isn't a problem on Linux but the "solution" is a problem in its own right, this is a step backwards.

#195 amends this to use embedded root certs only on MacOS.

Thanks for that!


Converted proxies should be configurable

Please describe your suggestion
Currently, all converted commands use a proxy. Proxies are incompatible with reflection. Have a setting to disable automatic proxying
Please supply examples of the desired inputs and outputs
verbose-outputs: true
create-dispatcher-json: false
plugins-to-convert:
  - Essentials: ~
  - SkinsRestorer: ~
skip-sender-proxy:
  - SkinsRestorer

Implemented in commit 408354f for v5.6

Implemented in commit 408354f for v5.6


merge from template-sync/template-coveralls

package.json

chore(deps): add ^10.1.6 remove ^10.1.5 (devDependencies.@semantic-release/github)
chore(deps): add ^24.1.0 remove ^24.0.0 (devDependencies.semantic-release)

.github/workflows/ci.yml

chore: (jobs.test-node.steps)
chore: (jobs.release.steps)

.github/workflows/update_readme_api.yml

chore(actions): merge from template .github/workflows/update_readme_api.yml

.github/workflows/codeql_analysis.yml

chore(actions): merge from template .github/workflows/codeql_analysis.yml

.github/workflows/update_package_lock.yml

chore(actions): merge from template .github/workflows/update_package_lock.yml

:tada: This issue has been resolved in version 6.11.29 :tada:
The release is available on:

npm package (@latest dist-tag)
v6.11.29
GitHub release

Your semantic-release bot :package::rocket:


Bug: users avatar is not showing on the repo tab

Describe the bug
This is what it shows currently

Steps to reproduce

Go to insights.opensauced.pizza
Click on the repository tab
See error

Affected services
insights.opensauced.pizza
Platforms
Mobile
Browsers
No response
Environment
No response
Additional context
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Contributing Docs

[X] I agree to follow this project's Contribution Docs

just also realized it the same on large screens

Yeah, I think it has something to do with cloudinary

cc @bdougie @OgDev-01 @brandonroberts @0-vortex

@dev-phantom @TAKANOME-DEV this is an issue with cloudinary, cannot be solved other than removing the transformation and rounding the images from CSS 😅

I think I know why :thinking: Give a second to try explaining it :sweat_smile:

@0-vortex a workaround is to change isCached props to false - if isCached is false, the GitHub link will be used https://avatars.githubusercontent.com/u/6154722?v=4
https://github.com/open-sauced/insights/blob/5bd4e48576d5f59b27d32eed4471f58c40a96082/components/molecules/TableRepositoryName/table-repository-name.tsx#L30-L36

You are correct about caching, but the issue is on a service level, not the way we request data - simply put, if we request more than 5000 non-cached avatars an hour that will rate limit the cloudinary service and the way it has been working so far is we just ignore it and request data every hour until we cache all our users (about 1200 active and 9000 repo owners).
Because the above limitation happens outside of our control, the image rounding comes with this compromise - the only way to completely disable this bug is to stop using the 3rd party service and request the avatars directly from github, thus benefitting from the increased rate limit of the authenticated user on the frontend purely in client (browser, non SSR) mode.
When we started using Cloudinary, our hourly users and displayed data was much less; we expect our active user data to increase 5-10x in resource consumption (that is the scaling of increasing active users displaying more data we make available).
The bug can definitely be fixed but requires additional steps like applying some CSS box rounding here and there after removing Cloudinary in the frontend! 🍕 🔥

Well explained :clap: Thanks :pizza:
Do you think a pr should be raised while waiting for the input of others?

We would still have a potential issue if we have lots of traffic to public pages like the explore page. I think removing the usage of Cloudinary for the avatars for authenticated users is a good idea to offload the rate limiting. We switched to cached images before because we were running into the same issue pulling avatars directly from GitHub.

Do you think a pr should be raised while waiting for the input of others?

A PR would ideal. 5 days in and it is still broken.


Pasted objects facing inwards

Currently, objects pasted in using the Stamp or Schematics will always face inwards (when possible).
Using world.getObjectParameter(id, "direction") on the original object should allow objects to always be placed in the same orientation when pasting. If the value is nil, the object probably doesn't have a facing direction.

Fixed in commit ee80be9570dec18bf233bde8af8552ef58550113. The direction parameter is now read when pasted, rather than comparing the object position to the center of the paste. This is done only if the direction parameter is present on the object.
A related issue has since been opened: https://github.com/Silverfeelin/Starbound-WEdit/issues/11


that Struct I want to ..（just a suggestion）

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
1.9
Does this issue reproduce with the latest release?
What operating system and processor architecture are you using (go env)?
What did you do?
is just a suggest,
let's see thus,
type struct Foo {
Mywork struct bar{
Name string
}
}
var mywork Foo  #this is true
var mywork Foo.Mywork #this is false
What did you expect to see?
var mywork Foo.Mywork #this is true
I think it's so cool to use struct like 'json'
like this:
type struct Fo{
struct Foo{
struct Fooo
}
}
var bar Fo.Foo.Fooo
What did you see instead?

Hi @lluck42 ,
What you are suggesting is a language change. Typically these have to go through the proposal process (https://golang.org/s/proposal). You have to write up a proposal which is then evaluated and accepted/rejected.
I would request you to see the link above and write a proper proposal if you want your request to be accepted. Thank you.


add include and exclude cli options

fixes #12

Thank you! I will take a look and test today. Thanks again.
On Tue, 24 Jul 2018 at 8:34 am, Vincent<EMAIL_ADDRESS>wrote:

fixes #12 https://github.com/yusinto/relay-compiler-plus/issues/12
You can view, comment on, or merge this pull request online at:
https://github.com/yusinto/relay-compiler-plus/pull/13
Commit Summary

add include and exclude cli options

File Changes

M src/compiler/main.js
https://github.com/yusinto/relay-compiler-plus/pull/13/files#diff-0
(35)

Patch Links:

https://github.com/yusinto/relay-compiler-plus/pull/13.patch
https://github.com/yusinto/relay-compiler-plus/pull/13.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/yusinto/relay-compiler-plus/pull/13, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ABhO9ZWqhvvSDjDhRR5_36VsdEAYPN0uks5uJk91gaJpZM4VbzTa
.

Looks good! Merging now. Thanks again @thoughtbyte !


IRI fixes

Fixed badly formed IRIs and added comment to disease stage. #116 and #105

Adresses #116


Peer-to-peer review

reviewing my partner's portfolio repository in the morning session.

Kindly can you use icons in your social media instead of images. Icons provide a good view of your website.

Hey Esmatullah,
when you choose to use img tag I would kindly suggest you put some text in alt(<img class="tonic-project-img" src="images/third project.svg" alt="">)

Great job so far @Esmatullah12. Your project looks great. However, I noticed that your nav-menu button is missing the button interaction styles defined for your template. So kindly include this as well to improve user interactivity with your project 👍

Hey @Esmatullah12
Congratulations on your project but I kindly recommend you use icons instead of using images as icons for your social media part.


HTML output ignores --loglevel parameter

Observed behaviour
When generating a HTML report via --html and specifying a loglevel via --loglevel, said loglevel parameter is not implemented by HTML output. Compared to output generated without --loglevel set, it only differs in the (inaccurate) notice that loglevels were left out of the report.
Expected behaviour
Behaviour similar to --ghmarkdown output, that is: recognise --loglevel parameter and only include those loglevels in the report.
Resources and exact process needed to replicate
Compare output of:

--ghmarkdown issues-all.md and --ghmarkdown issues-all.md --loglevel WARN (produces expected output)
--html issues-all.html and --html issues-all.html --loglevel WARN (produces inaccurate output)

We've just noticed this issue in the Unified font repo as well.
cc @felipesanches @RosaWagner


Failed to load Kafka Extension: Undefined Symbol IsInferredStream

I am trying to load the Kafka Extension within docker. When I call
CREATE EXTENSION pipeline_kafka;
I get the following error:
ERROR:  could not load library "/usr/lib/pipelinedb/lib/pipelinedb/pipeline_kafka.so": /usr/lib/pipelinedb/lib/pipelinedb/pipeline_kafka.so: undefined symbol: IsInferredStream

This is the Dockerfile I am using:
FROM pipelinedb/pipelinedb

RUN apt-get update && apt-get install -y python && rm -rf /var/lib/apt/lists/*
RUN git clone -b 0.9.1 https://github.com/edenhill/librdkafka.git ~/librdkafka
RUN cd ~/librdkafka && ./configure --disable-ssl --prefix=/usr && make && sudo make install

RUN git clone -b 0.9.4 https://github.com/pipelinedb/pipeline_kafka.git ~/pipeline_kafka
RUN cd ~/pipeline_kafka && ./configure && make && sudo make install

ADD ./mnt/  /mnt/pipelinedb/

and the pipelinedb.conf file is a default config with kafka added to the extensions list, it is here: https://gist.github.com/jamesmintram/26ed20e6685ed066fd25d54bd5777801

Hi @jamesmintram, can you use the master branch of pipeline_kafka?
Also, moving this to: pipelinedb/pipeline_kafka#43


[SPARK-47170][BUILD][CONNECT] Remove jakarta.servlet-api and javax.servlet-api dependency scope in connect/server module

What changes were proposed in this pull request?
This is a follow up change from https://github.com/apache/spark/pull/45154, to remove redundant <scope> for both servlet-api as compile is the default scope.
Why are the changes needed?
Does this PR introduce any user-facing change?
No
How was this patch tested?
CI build
Was this patch authored or co-authored using generative AI tooling?
No

@dongjoon-hyun would you mind having a look at this, thanks :)

Thank yo, @HiuKwok . Merged to master.


Fix page title on local petitions without a postcode

If the user doesn't enter a postcode when searching from the home page or they navigate to the page directly then the page title helper doesn't have a count to pick which translation to use. For this case set the count to -1 so that the :other key is used from the translation.

This is what you currently get on production:

LGTM


example.c ends in a segfault

I am trying to use a Logitech C310 camera for an application I am working on. I am curious if people else have successfully run example.c as is.
I downloaded the code as instructed on my linux machine. I moved the example.c code into the build directory and compiled it with this:
gcc  example.c -o exampleprog -luvc
(Originally there was an access denied problem so I am running it as a root user, but that does not seem be the issue. )
When running the code it ends in, Segmentation fault (core dumped). However, when i reduce the parameters such as image size to 160x120, or fps (to 10) and sleep time (to 1 sec). Then the code will complete. I need the larger image for my application so I would appreciate advice on this.
Is the camera not set up properly or something else I could be missing...
Any advice or solutions for this?
Thank you-
RLS
UPDATE: I just noticed this print out  when the program runs- could it be related?
UVC initialized
Device found
unsupported descriptor subtype: 13
unsupported descriptor subtype: 13
Device opened
DEVICE CONFIGURATION (046d:081b/D447D130) ---

I am currently running it on a beaglebone black, and sometimes it runs fine, but sometimes it does segfault. I ran gdb on it and it seems like its crashing in a call libusb. It crashes in uvc_stop_streaming call.

It seems I've had the same trouble - my app using libuvc crashes when trying to close device with uvc_close() after starting a stream with uvc_stream_start().
The actual problem was in function called uvc_stream_stop - there is erroneous usage of libusb_cancel_transfer return value:
int res = libusb_cancel_transfer(strmh->transfers[i]); if(res < 0) {  free(strmh->transfers[i]->buffer);  libusb_free_transfer(strmh->transfers[i]);  strmh->transfers[i] = NULL; }
It is not valid to free transfer immediately after libusb_cancel_transfer returned negative result cause this transfer may still be used in uvc_iso_callback function.
So I commented out transfer freeing code in uvc_stream_stop and add transfer deletion to uvc_iso_callback for LIBUSB_TRANSFER_COMPLETED, LIBUSB_TRANSFER_TIMED_OUT, LIBUSB_TRANSFER_STALL and LIBUSB_TRANSFER_OVERFLOW cases.
Of course transfer deletion in uvc_iso_callback for these cases should happen only when strmh->running == 0.
I'm not sure if this quick and dirty solution is the best one, but it works for me - no more crashes when calling uvc_close(). My current version of stream.c is attached.
stream.zip


initial draft of terraform example code using cloud run

Adding in some example terraform code to build out a cloud run installation of the Jit application

is this helpful @losisin ?

yes, thanks @duxbuse

Thanks for this - going to use this for deploying JIT in my org..
Will add comments if I find any bugs.
Only thing I'd like to improve is listing out all the roles/permissions needed to deploy all this stuff, as it assumes you're an admin but would rather deploy all this infra least-privilege.

FYI I found the following managed roles were enough to get everything here deployed. Obviously some people might want a custom role and permissions, but I found these managed roles a good middle ground for least priv.
Artifact Registry Administrator
Cloud Run developer
Compute Load Balancer Admin
Compute Viewer
OAuth Config Editor

These were bound to the principal deploying the resources in this PR at the project level (where the resources are deployed).

This also assumes the corporate proxy is available publicly. I'm working on getting my cloud run instance set up on a vpc so it can talk to our corporate proxy. I think there are a few ways to do this stuff so hard to do a one-size-fits-all.


Resolve absolute path of out_dir

Fix #196.

Maybe other paths needs to be resolved.

Thank you for this.

Maybe other paths needs to be resolved.

The "once and for all" approach might be to resolve the paths in CPath.validate.
Either way, we need to crank up the tests a hair so we get some sensitivity on this: spaces, unicode, test with gross windows paths (UNC paths can go take a leap, though). It was my intention to get hypothesis in the loop, but was trying to get something out...


Improve building instructions

Added install instructions for Fedora

Since the OS/distribution specific parts are quite few, i think I found a compromise.


'Why this matters?' field looks like a single-line input rather than textarea

I suggest having the initial height set to 3-4 lines rather than one so people know this is where the content goes

Agree. Will do.

The post have been simplified to include just one field that can carry a 1000 characters. Hence closing.


slate theme test is resulting in a ECONNREFUSED

Problem
`# slate theme test
This may take some time...
events.js:160
throw er; // Unhandled 'error' event
^
Error: connect ECONNREFUSED <IP_ADDRESS>:443
at Object.exports._errnoException (util.js:1022:11)
at exports._exceptionWithHostPort (util.js:1045:20)
at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1087:14)`
Succinct outline of the problem or request.
Replication steps
How to replicate the problem. Screenshots or video?
slate theme test
More Information
Any additional information which might be helpful.
my network is behind a proxy, but node is configured to that. but i feel this could be the issue, i can be wrong.

Hi @ashrayvenkat -- we'll need more information in order to verify that this is actually a bug with Slate and to replicate it. Please try this on a non proxied and connection and let us know if you still have problems.


Emit declaration of class extending intersection

Classes that extend expressions will get a synthetic var declaration for
the expression. This is required for classes that extend an expression
that return an intersection type.
Fixes #14075, but not #15066, which is the full mixin scenario. You still can't export a class that inherits from a class expression that was returned from a function. That probably requires more complicated type declarations to be generated.

@sandersn, does this also address https://github.com/Microsoft/TypeScript/issues/15572?

Please port the change to release-2.3 as well.

It should fix #15572 since the error arises from incorrect flattening of an expression in extends. I'm testing it right now.

Yes, it fixes #15572. I also ported this change to 2.3


Need help understanding the proper steps.

When using this action do i first need to Run the crawler on my local files and have everything Pulled down and working including the .env file. Then upload to the repository created for this and then i can run the action?
Im a bit lost when reading the instructions on both pages for the crawler and this action.
Same goes for the crawler is it best to fork from the main site, or clone. Then Pull to my local and run the crawler, then update the repo with the full tailwind ui site, then run the action?
You guys are awesome by the way. Tailwind UI even told me in our correspondence when i requested a git,  to use the crawler and your action.
So keep up the great work and thank you for everything you have done.

Hi @JHDSonline ! If you're just after a private GitHub repository which is kept in sync with the TailwindUI site, all you need is this Action. This Action will use kiliman's TailwindUI Crawler to periodically update your repository. Just follow these instructions, and you should be good to go. Let me know if anything is unclear! The one common 'gotcha' is that new repositories now use the main branch, so you need to specify that with the branch and current_branch options.
If, however, you only want to take a copy of the TailwindUI components to a local folder, you can use the crawler directly with these instructions.

You rock thank you so much.


Handle comment + tip failure, don't re-support

PR Checklist

Please check all that apply to this PR using "x":

[X] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
[X] I have checked that this PR does not introduce a breaking change
[ ] This PR introduces breaking changes and I have provided a detailed explanation below

PR Type
What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting)
[ ] Refactoring (no functional changes)
[ ] Documentation changes
[ ] Other - Please describe:

Fixes
Issue Number: Closes #6063
What is the new behavior?
In case of failed comment, allows to re-submit the previous tip, without having to send another tip

(tried to comment twice, first tip failed, re-submitted without tipping twice)

Thanks for the PR! Can test this today. Looks like linter is failing?


build(deps): bump react-native-gesture-handler from 2.5.0 to 2.13.1

This PR resolves []
Description
Updates react-native-gesture-handler to latest and removes the patch

PR Checklist

[x] I have tested my changes on iOS and Android.
[x] I hid my changes behind a feature flag, or they don't need one.
[x] I have included screenshots or videos, or I have not changed the UI.
[x] I have added tests, or my changes don't require any.
[x] I added an app state migration, or my changes do not require one.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

bump react-native-gesture-handler from 2.5.0 to 2.13.1 - gkartalis

Need help with something? Have a look at our docs, or get in touch with us.

This PR contains the following changes:

Dev changes (bump react-native-gesture-handler from 2.5.0 to 2.13.1 - gkartalis)

  Generated by :no_entry_sign: dangerJS against 93cf8a659d643116bf215071181ba49858f4a2bb


Adds pivot table custom component

I've addressed all of my own PR comments, now working on some additional cleanup:

[ ] Add screenshots and more usage explanation
[ ] Add skuid.ui.Editor hooks to handle updates when model data is requeried, new rows are created, rows are modified, etc., and also for handling component error messages.
[ ] Would be REALLY cool to support dynamic re-pivoting via a Component Action --- e.g. add a Component API to allow for at-runtime end-user modification of the pivot columns

Old, and not applicable to V2


Reworked ISA

The old ISA was a bit too simplistic, I've refactored it into a cleaner, smarter ISA.
There is a large change to the macro codegen here, it now works on the fields of each variant rather than taking a set of fields as a whole. Eg before it would know what to do when matching
["Register", "Register"]

However we now match each field with its index. We know that (Register, 0) is masked in a certain way, as is (Register, 1) etc. Some components such as a Nibble or Literal7Bit always appears in the same place, so ordering is not important but there is a quiet implication that there can only be 1 of these (and that we do not create instructions with overlapping masked fields!). This is a pretty fragile aspect to this new macro system, it relies of knowledge of how parts of an instruction are encoded. But it will make adding a new instruction extremely fast/easy. This is the tradeoff I have taken.
A bit of misc cleanup snuck in here. I don't think it's worth rebasing out of here into different branches. I'll just merge this large change soon and try to have better hygiene as I tackle smaller/more contained tasks!

lgtm


Logs from hmr are shown multiple times in debug console

Environment
Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project):

CLI: 5.3.0
Cross-platform modules:
Android Runtime:
iOS Runtime: 5.2.0
Plugin(s):
VSCode:

Describe the bug

To Reproduce

tns create myTestApp --ts
Select launch on iOS configuration and add tnsArgs: ["--hmr"]
Make changes on .xml, .css files
Sometimes the messages from hmr are shown more than once

Expected behavior
Sample project

Additional context

I'm seeing this issue in the debug console after starting via "Launch on iOS" even without the --hmr flag. I'm running an ns angular app.

CLI: 5.3.1
Cross-platform modules: 5.3.1
iOS Runtime: 5.3.1
Plugin(s): nativescript-angular 7.2.3
VSCode: 1.32.3