Add a CP implementation variant with KV all-gather.

Description
This is a CP implementation variant with KV all-gather. Currently, it can support:

sliding window attention + causal + FlashAttention
full window attention + causal + FlashAttention
full window attention + causal + FusedAttention

Will add more functionality support later.
The KV all-gather communication is exposed, but the overheads should be small with GQA/MQA.
Type of change

[ ] Documentation change (change only to the documentation, either a fix or a new content)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Infra/Build change
[ ] Code refractor

Changes
Please list the changes introduced in this PR:

Add cp_comm_type in attention.py to allow users choose which CP implementation they want.
Add unit tests for the new implementation variant.

Checklist:

[x] I have read and followed the contributing guidelines
[ ] The functionality is complete
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

/te-ci

/te-ci pytorch

/te-ci pytorch

/te-ci pytorch

/te-ci pytorch


hitbox issue when flying

with both aqua acrobatics and wings installed

with only wings

Swimming hitbox is correctly one block high.

Fixed in 87c656e and released on CurseForge as v1.1.4.


[CosmosDB] Add change for long running operations

Small change that fixes long running operations returning unauthorized.

Hi @allenjzhang please take a look at this PR to add change for long running operations, which fixes the Unauthorized result we are currently getting. Thank you!

Hi @markcowl yes this is not part of the generated code but a fix for this issue. Meha has made a permanent change for this here but it is not deployed to Prod yet, so we would like to make this change in the mean time so we can release our PS cmdlets to customers. Thanks!

Talked offline.  There is a service-side fix currently being deployed, this is a stopgap until that deployment completes.  The service team has agreed not to update the api until the fix is deployed.


Class equivalency in RDFS

The specification of RDFS validity allows the definition of cyclic rdfs:subClassOf relationships (see RDF Issue "rdfs-no-cycles-in-subClassOf"). This constructs implies that the participating classes are to be considered equivalent.
For generating Java classes from an RDFS ontology the strongly connected components (SCC) of the inheritance forest must be detected. The SCCs are subgraphs in which every node is reachable from every other node and can be considered as equivalence classes in the above equivalence relation.

All subclass and domain/range definitions concerning the classes in a SCC must be merged into a single class, for which a Java class is generated later.

I implemented the algorithm of R. Tarjan (commit d64c3c3b5cc48e60b9d9a703d0ff72ca3704deba) for finding SCCs in the inheritance trees of an ontology.
Unfortunately the Jena RDFS reasoner used in the current version of the model builder prunes out cyclic subclass relationship without merging properties and subclass-relationships.
A possible solution would consist in finding SCCs in a ontology model without a reasoner, merge the equivalent classes and afterwards add the reasoner to the model. But this way not all subclass relations may be known during SCC detection, because they were not yet inferred by the reasoner.

As I have proposed, the SCCs of the inheritance forest are now detected on a Jena ontology model without inferencing. A single class is picked from each SCC and the subclass relationships and properties of the others in the same SCC are copied to it. Afterwards the other classes are removed from the model, which then receives a Jena RDFS reasoner.
As it seems the Jena models have problems with cyclic rdfs:subClassOf relationships. So
the methods for querying for root classes and even for all classes in the model return empty if a cycle is present.
This problem was solved by iterating the subjects and objects of rdfs:subClassOf statements from the underlying raw model.
But because no inferencing was done beforehand, the ontology view of the model does still not recognize some resources as classes.
So on each iteration a statement is inserted, declaring the subject/object of rdfs:subClassOf as rdf:type rdfs:Class. This inferencing complies to the RDFS semantics.
The general approach of detecting class equivalence on ontologies on which no full inferencing was done, has the disadvantage that not all equivalencies may be detected.
But this should be of small practical relevance, because equivalence will probably most times be defined by explicitly stating the cycle.

Note on later implementation:
The Tarjan algorithm now directly operates on Anno4j RDFSClazzobjects (and uses BuildableRDFSClazz as an "extended view") instead of the Jena OntClazz objects (see c1353ad360de7e5b8b658b1c9a1a79dc68dcc632).


Fix read tcp i/o timeout on PUT operations with persistent connections

http PUT operations with persistent connections turn out to run a Read
in parallel with the Write doing the PUT.  Because the Read is
inactive the read timeout activates and closes the connection even
though the Write is proceeding just fine.
You can see this code if you look at net/http/transport.go where you
see in Transport.dialConn
go pconn.readLoop()
go pconn.writeLoop()

Which starts the reader and the writer simultaneously.
The fix for this is for httpclient to use a single deadline for both
read and write.  This meas that an IO idle timeout will only be caused
if both read AND write timeout which is probably what the user is
expecting, rather than if read OR write timeout.

SGTM, thanks!


add validations to workload entry

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[X] Does not have any changes that may affect Istio users.

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
f9fcb55aafdf8c4d71c6140a8f5837c159dccb5b
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
f9fcb55aafdf8c4d71c6140a8f5837c159dccb5b
link
/test unit-tests_istio

integ-pilot-multicluster-tests_istio
f9fcb55aafdf8c4d71c6140a8f5837c159dccb5b
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Feat.payment amount multiplier AB#7740

@elwinschmitz some context on this last (3rd) commit

This is unfinished (but working) code, because I'm wrapping up, so you can potentially continue with it
My idea was to - instead of creating yet another endpoint for updating one specific connection attribute - to move towards some endpoint-grouping by making a generic update(Connection)Attribute endpoint
which (in current version of code) only handles the paymentAmountMultiplier
but if extended, could extend other attributes ..
.. including also customData attributes > the if / else could be extended to check for connection.customData[attribute] instead of for connection[attribute]
which could get rid of the customData endpoint(s) > I also see no reason keep a separate custom-data and custom-data/overwrite endpoint
but also of the change phone / change fsp / etc. endpoints..
In the new refactoring Diderik and I have already discussed that we want to move to endpoint minimization, where basically per entity you have e.g. one GET, one POST and one PUT endpoint, instead of the whole extravaganza of current endpoints. They could largely be grouped by using parameters/body input for this 1 endpoint.
this particular endpoint would then become the PUT endpoint for the connection entity > it's still a POST now, but this could be easily changed already I think.

@elwinschmitz I have fixed the whatsapp messages

and tested with local ngrok + twilio sandbox
but not yet for the (edge) use case of simulanteously having multiple PAs on the same phone number
and also not yet on test-vm, because only there you can test if the template is passed (the yes reply will fail there, but that doesn't matter)


[Bug]

Expected behavior
Actual behavior
Steps to reproduce the behavior
Beeftext version (e.g. Beeftext v7.0 Portable Edition).
Operating system version (e.g Windows 10)

Zero information. Closing.


Slothpixel API

We may at some point be able to use the Slothpixel API which does not require an API key for basic access. However its CORS policy currently prevents remotely querying the API from the browser using JS.

No need to implement the slothpixel api!
Hey, you do not need an api key to use the regular hypixel api (for the bazaar endpoint)! I created a pull request not too long ago removing your api key from the code (that was a really unsecure way of storing it!). I hope this comment lets you close your only open issue! I hope this helps

Thanks, tested and it does indeed work without an API key. Code updated.


[ Feature Request ] Color code search results to match comment text color

Use Case
Make it easy to distinguish search results found in code versus comments.
I often must go through multiple search result hits to find the search result in code I am looking for.

Display comment search results in green ( or whatever the syntax color is for a comment )
Displaying non-comment search results in white is fine ( IMO ).

See screenshot mock-up below:

Duplicate of #5192


Feature Request: Capture MongoDB

Since MongoDB is probably the most popular DB used with Node.js apps it makes sense to support it in this SDK.

Is there any progress in this issue?
I saw mongodb instrumentation in newrelic recently and miss it here =(
I am currently thinking about creating a patcher myself.
However that is not easy for the native nodejs mongo driver...
Anyone here who has experience with this?
Some possibly helpful sources:
[1] New Relic Instrumentation Implementation for MongoDB in NodeJs
[2] Example of an incomplete/experimental X-Ray patcher for MongoDB in NodeJs

+1

+1

Is there any plans for this? I'd be happy to contribute...

@abeMedia sorry for the delay, we do accept (and highly appreciate) PRs and we are happy to work with you to get this out the door sooner than later.

haha nice. A billion dollar corporation that will gladly take your free labor.

Please give this change some more love. It can't be that much work?

Hi,
We have this item in our backlog. Hope to prioritize this feature request soon! Meanwhile we encourage you to submit a PR and we will be helping you with any design recommendations/suggestions.

+1

Is there any progress on this?

Hi all,
Currently, the OpenTelemetry SDK for Javascript supports instrumentation of MongoDB and we are building out support for OpenTelemetry instrumentation with an X-Ray backend. This way, you can get the advantage of instrumenting MongoDB (and many other libraries) but still have traces sent to the X-Ray service. This support is currently available as a public beta, so we are open to feedback on the integration in this repo. Here's our documentation for setting up the X-Ray integration with OpenTelemetry instrumentation.

+1


Upgrade gems

Hi,
We are trying to use the gem, but this gave us a fallback on downgrading all the gems we have, specially rails.
I have cleaned up the rubocop suggestions, and I have updated faraday and hashie gems in individual commits. They seem to be the main reason we went back a major rails version.
There's also errors mentioning your traits but I can't seem to see it in any previous PR you had until now so maybe there's been a change on how FactoryBot expects traits to work.
NoMethodError:
  undefined method 'your_consumer_reference' in 'payment_details' factory
# ./spec/factories.rb:24:in `block (2 levels) in <top (required)>'
# ./spec/factories.rb:23:in `block in <top (required)>'
# ./spec/factories.rb:22:in `<top (required)>'
# ./spec/spec_helper.rb:7:in `<top (required)>'
# ./spec/judopay/web_payments/preauth_spec.rb:3:in `<top (required)>'

An error occurred while loading ./spec/judopay/web_payments/transaction_spec.rb.
Failure/Error: your_consumer_reference 123

NoMethodError:
  undefined method 'your_consumer_reference' in 'payment_details' factory
# ./spec/factories.rb:24:in `block (2 levels) in <top (required)>'
# ./spec/factories.rb:23:in `block in <top (required)>'
# ./spec/factories.rb:22:in `<top (required)>'
# ./spec/spec_helper.rb:7:in `<top (required)>'
# ./spec/judopay/web_payments/transaction_spec.rb:3:in `<top (required)>'
No examples found.

Card used:<PHONE_NUMBER>003436
{
  oneUseToken: 'FfG6GvgfWmwi0Q6Nj/TEtHyk2aBeO+EBCAzcqzmI1BXa5geVc4Nhl1fJo9ELaBKXCal5nk1y8wf2aS4bAu/m/yR2JNW20G33vPzXioyx/JQpnk98c+LyGvx5vS4anAOaJ0AaHTBOfxiie+mr5K+w1XIOVlWHc4EIU1AQPu0J7EkEODvsj+WYR3Cmx+uBJVgCaSAH38SMc9JpGMf186S1gp6H7NLFhgsh2rkc5ySLUNh5Pdek2iL30n80oLCz/DrzOaB+mtghDQ18nnRHy7SB3IUT2jkAGxcOy0Gzwmi/pGOZCTMfXfDXNTvm/1EmixlDeQWagFBL8Q59wO+HYpGreVUnxukpwGfvpNKtMcdo+7REgcQjjjwVfw7U/DbKk92IwcS3XOTpSNPWyBiQ5nlDXcMQuY2bc9osKu/leu6TvNvGih/1h9QpEPnAYf7FtXX+UZcdTtfOLSjTMua8CsX3OBUqMt69/ZNovZ7PsMZXQpP8eWGB/QGWMtUjsfYBs0XnjULr9K6YIOZzZNIPM9aWgpyBufC1luJwBDh6OhguNqYwv4c/CGd0GvRkECkC+4c1QxPCJy12jC2u105SkwkmTRHAgh3P7nrf2co0OoH/jlHPr5kST1KpPbJ4ymDPWyIYMvooITlrNQ7qr3qasZOJcnH62jHAg4ShtH65IAWkpZc=',
  YourConsumerReference: '1e55a256-89dc-477c-873b-1ff67d9faf0c',
  YourPaymentReference: '1434e788-3e4e-430e-85a2-b4c3089701de',
  JudoId: '100801-786',
  amount: 5.00,
  currency: 'GBP' ,
}

{
    "receiptId": "423778640195817472",
    "yourPaymentReference": "1434e788-3e4e-430e-85a2-b4c3089701de",
    "type": "PreAuth",
    "createdAt": "2019-03-15T09:45:01.4655+00:00",
    "result": "Success",
    "message": "AuthCode: 013707",
    "judoId": 100801786,
    "merchantName": "Alfredo Motta",
    "appearsOnStatementAs": "APL*/AlfredoMotta       ",
    "originalAmount": "5.00",
    "amountCollected": "0.00",
    "netAmount": "5.00",
    "amount": "5.00",
    "currency": "GBP",
    "cardDetails": {
        "cardLastfour": "3436",
        "endDate": "1220",
        "cardToken": "XreXEgeXWfd6e4A1bGumHMYju0r6Mc9D",
        "cardType": 11
    },
    "consumer": {
        "consumerToken": "v8XgnUKsbPSY4I1q",
        "yourConsumerReference": "1e55a256-89dc-477c-873b-1ff67d9faf0c"
    },
    "riskScore": 0,
    "risks": {
        "postCodeCheck": "UNKNOWN",
        "merchantSuggestion": "Allow",
        "merchantStatistics": {}
    }
}

This looks fine to add to our release but I made a small change of pinning the version numbers so they won't change on major version

Thanks @patey5, is it possible to release the new version on rubygems please?


add more info to the react-i18n babel plugin README

Add some more information on react-i18n babel plugin.

Separate it from the main package README to babel-plugin/README
Make it clear that there are 3 different mode in this plugin
Modify the examples to make it clear what the transform will generate

also moved the src/babel-plugin/README.md to babel-plugin.md


Fix windows symlink creation

Should fix #23, #89 , #100
According to the docs on windows we should define symlink type
Due to inactivity I am closing this PR because it goes from master (i am planning to publish it), instead I've created the same pull request in #109
Fork with fixes published here: https://github.com/LadnovSasha/serverless-plugin-typescript

Hope this will be merged some day 🤞

Hope this will be merged some day 🤞

Yeah, @schickling if you have any news about that. In the meantime, I'm forking this with your patch @LadnovSasha

Can someone please pull this in because it's causing me issues.

I fixed it by using ThomasVuillaume/serverless-plugin-typescript#master as a dependency...
When will this be merged...?

Please could this get accepted as having to do a work around using another package cloned from this.

Seems Prisma doesn't like Windows devs :D
(Psst, i've got a Linux too)

I've published fork to npm, if someoune interested https://github.com/LadnovSasha/serverless-plugin-typescript

Using a fork for such a "small" and easy-to-fix issue is not an adequate solution for me. :/
(Though I understand that you don't want to wait for a merge anymore.)

@jonasduever you can see in #130 that price is still present

Not a lot of responses from prisma, I will try their slack channel. If not will fork and publish as a new serverless plugin thats actually updated!

Ok we'll wait for your info


Memory leak: Table, TableMeta and TableProperty classes are retained in memory after destruction when using table/column modifiers or column.getValueForRow

Clone this repo and run the docs app
Enter the index route and see that there is one instance of the Table class is retained in Heap memory. This is expected.
Exit the route and enter /testing (a route without a rendered table), then re-enter the index route. Now, see that the Table class retained in memory twice.
Repeat exiting and entering the same routes, and see that for each exit of the index route, new instances of the Table class are retained in memory:

https://github.com/CrowdStrike/ember-headless-table/assets/4601554/40983c64-d87a-4bd3-944c-ef21054057e4
This is also reproducible in my own webapp whenever I use a table or column modifier, or use the column.getValueForRow helper.
Removing all the modifiers and {{column.getValueForRow row}} from demo-a.md resolves the issue, so this is most likely caused by columns not being teared down correctly.

@NullVoxPopuli Thanks!
I can verify that this is not reproducible if I run the docs-app with<EMAIL_ADDRESS>


chore: smoke test resiliance

the promise change appears to help with the below in my local windows env
[app]     Received promise rejected instead of resolved
[app]     Rejected to value: [invalid session id: invalid session id]

although its very hard to tell without running it mutliple times on CI...
the timeout also helped in my local experiments to avoid the timeout after send request, feels a bit arbitrary though :shrug:
planning to just keep hitting update branch for the next couple weeks to see if it ever breaks.

closing because didn't solve the problem


New metadata API: add MetadataInfo and TargetFile classes

This pr addresses https://github.com/theupdateframework/tuf/issues/1139, but doesn't fix it yet.
I will add a separate pr which will handle Roles and Keys classes.
Description of the changes being introduced by the pull request:
It includes the following changes:

Add a missing root use case in a couple of our tests
Make length and hashes optional in Timestamp as it is in our specification
Add MetaFile class and use it in the Timestamp and Snapshot classes
Add TargetFile class and use it in the Targets class
Rename a few instances of the update method in our classes and use a more verbose name.

Please verify and check that the pull request fulfills the following
requirements:

[x] The code follows the Code Style Guidelines
[x] Tests have been added for the bug fix or new feature
[ ] Docs have been added for the bug fix or new feature

It took me longer than expected, but I updated my pr.
I had to rebase because I dropped the commit in which I renamed update methods.
Additionally, I

added a new commit New API: Make sure we are not changing dict arg
added a new commit Fix documentation indentation as proposed by Lukas.
Addressed all comments made by Lukas.

@MVrachev and @jku have rightfully pointed out that in my hierarchic from_dict design, which recursively instantiates and assigns nested TUF metadata objects from their json/dict representation, the input data (i.e. the json/dict) is mutated while being parsed, which might be surprising to the caller.
Note that this mutation only occurs in classes that use inheritance, i.e. in Signed and its subclasses Targets/Snapshot/Timestamp. Here is a simplified/abstract demonstration of the issue:
class Parent:
    def __init__(self, x: X):
        self.x = x

    @classmethod
    def from_dict(cls, data: Dict):
        # Write back into passed 'data' dict so that we can pass it as '**data'
        # to the constructor, with the expected parsed value for 'data["x"]',
        # alongside other 'data' values that were parsed in subclasses.
        # FIXME: Mutation of 'data' (passed by reference) might surprise caller
        data["x"] = X.from_dict(data["x"])
        return cls(**data)

class Child(Parent):
    def __init__(self, x: X, y: Y):
        super().__init__(x)
        self.y = y

    @classmethod
    def from_dict(cls, data: Dict):
        # Parse and write back into passed 'data' dict so that we can hand it
        # on to the parent class for any additional parsing of 'data' values.
        # FIXME: Mutation of 'data' (passed by reference) might surprise caller
        data["y"] = Y.from_dict([data["y"]])
        return super().from_dict(data)

@MVrachev proposes to copy (probably rather deepcopy) the input data in the relevant from_dict methods. While this seems like a fair fix, it introduces unnecessary overhead. Here is an alternative solution:
class Parent:
    @classmethod
    def from_dict(cls, data: Dict):
        # Create empty object with default or parametrized constructor with
        # default arguments.
        obj = cls()

        # Parse 'data["x"]' and assign it to the empty object. Any child
        # attributes are parsed and assigned later in the child class.
        obj.x = X.from_dict(data["x"])
        return obj

class Child(Parent):
    @classmethod
    def from_dict(cls, data: Dict):
        # Call parent parse to get object with parent attributes already
        # assigned and ...
        obj = super().from_dict(data)

        # ... parse and assign any child attributes here.
        obj.y = Y.from_dict(data["y"])

        return obj

Just my 0.02 BTC as an observer:
One thing I regretted adding in my original Metadata API was native JSON decoding/encoding support as class methods. While it works well, it does not not decouple our internal Metadata objects from the data transport format (which need not be JSON).
In my new design, I use an abstract parser which can be overriden to implement different parsers for different data transport formats that nevertheless return the same type of internal Metadata objects were expect.
Anyway, please carry on, don't let me derail you, I was just making an observation based on something I caused.

Good point, @trishankatdatadog. This would be a third, more procedural option, for our considerations in https://github.com/secure-systems-lab/securesystemslib/issues/272#issuecomment-691056186. And it indeed completely decouples internal Metadata objects from external transport format.
What I liked about my proposal is that serialization/deserialization logic is organized in small chunks that are encapsulated in the related class.
But I'm really fine either way. Curious to hear what others think.

@MVrachev and @jku have rightfully pointed out that in my hierarchic from_dict design, which recursively instantiates and assigns nested TUF metadata objects from their json/dict representation, the input data (i.e. the json/dict) is mutated while being parsed, which might be surprising to the caller.
Note that this mutation only occurs in classes that use inheritance, i.e. in Signed and its subclasses Targets/Snapshot/Timestamp. Here is a simplified/abstract demonstration of the issue:
class Parent:
    def __init__(self, some_parent_attr: SomeParentAttr):
        self.some_parent_attr = some_parent_attr

    @classmethod
    def from_dict(cls, data: Dict):
        # Write back into passed 'data' dict so that we can pass it as '**data'
        # to constructor, with parsed value for 'data["some_parent_attr"]',
        # alongside other 'data' values that were parsed in subclasses.
        # FIXME: Mutation of 'data' (passed by reference) might surprise caller
        data["some_parent_attr"] = SomeParentAttr.from_dict(data["some_parent_attr"])
        return cls(**data)

class Child(Parent):
    def __init__(self,
                 some_parent_attr: SomeParentAttr,
                 some_child_attr: SomeChildAttr):
        super().__init__(some_parent_attr)
        self.some_child_attr = some_child_attr

    @classmethod
    def from_dict(cls, data: Dict):
        # Parse and write back into passed 'data' dict so that we can hand it
        # on to the parent class for any additional parsing of 'data' values.
        # FIXME: Mutation of 'data' (passed by reference) might surprise caller
        data["some_child_attr"] = SomeChildAttr.from_dict([data["some_child_attr"]])
        return super().from_dict(data)

@MVrachev proposes to copy (probably rather deepcopy) the input data in the relevant from_dict methods. While this seems like a fair fix, it introduces unnecessary overhead. Here is an alternative solution:
class Parent:
    @classmethod
    def from_dict(cls, data: Dict):
        # Create empty object with default or parametrized constructor with
        # default arguments.
        obj = cls()

        # Parse 'data["some_parent_attr"]' and assign it to the empty object.
        # Any child attributes are parsed and assigned later in the child
        # class.
        obj.some_parent_attr = SomeParentAttr.from_dict(data["some_parent_attr"])
        return obj

class Child(Parent):
    @classmethod
    def from_dict(cls, data: Dict):
        # Call parent parse to get object with parent attributes already
        # assigned and ...
        obj = super().from_dict(data)

        # ... parse and assign any child attributes here.
        obj.some_child_attr = SomeChildAttr.from_dict([data["some_child_attr"]])

        return obj

I agree with your proposal @lukpueh and will change it.
This is a more optimized way to fix that problem.

I implemented the suggestions from @lukpueh.
I had to give default function arguments for all class arguments assigned in __init__
for Root, Snapshot, Targets, and Timestamp classes.
I chose None as the easiest solution as a default argument, but
we definitely want to add proper validation which will ensure
we are not creating empty or partially populated objects.
I didn't want to create a discussion for sensible defaults
and argument validation here.
There is already an existing issue for that:
#1140
It will be awesome if we can hear the opinions of others.
@joshuagl, @sechkova?

I addressed all comments made by @joshuagl and rebased to squash some of the commits and prepare this pr for merging.

Closing to try and re-trigger GHA.

Closing to try and re-trigger GHA.

There are linter failures on the new changes, could you please take a look @MVrachev? Note: it's probable that we need to update pylint configuration for the new coding style.

There are linter failures on the new changes, could you please take a look @MVrachev? Note: it's probable that we need to update pylint configuration for the new coding style.

I added one commit where I disable inline some of the irrelevant warnings and for warning E1101 I decided to just disable it because it was creating a lot of false-positives.

I added one commit where I disable inline some of the irrelevant warnings and for warning E1101 I decided to just disable it because it was creating a lot of false-positives.

Orthogonal to this PR, given the number of linter warnings we're having to disable related to our from_dict pattern, I wonder whether we should document this (and consider other options?) with an ADR. cc @lukpueh

Agreed. I'll put something together.

Orthogonal to this PR, given the number of linter warnings we're having to disable related to our from_dict pattern, I wonder whether we should document this (and consider other options?) with an ADR. cc @lukpueh

Agreed. I'll put something together.

Updated the pr.
Added a more detailed comment about E1120 and W0212 and disabled E1101 only for tuf/api/metadata.py.
Also, added a commit with a comment for _type.
Had to rebase in order to return pylintrc back to its original state.

Updated the pr.
Added a more detailed comment about E1120 and W0212 and disabled E1101 only for tuf/api/metadata.py.
Also, added a commit with a comment for _type.
Had to rebase in order to return pylintrc back to its original state.

I updated this pr and had to rebase in order to replace the ** key-value syntax I was using when creating class instances with
directly passing the arguments needed for the __init__ functions.

I updated this pr and had to rebase in order to replace the ** key-value syntax I was using when creating class instances with
directly passing the arguments needed for the __init__ functions.

On hold, until we merge #1270.

I've converted this PR to draft until it is ready for review. Mostly to save myself from checking the discussion each time to see what the status is.

I feel like this pr has a lot of discussions and changes that are outdated compared to our current code.
I made a new branch migrating the changes from this pr and found out that: c37bdd2608dbbcce7b86c161f30243e4af8d9ed7 and the discussion we had with @lukpueh starting from here are no longer relevant to our code, commits
c37bdd2608dbbcce7b86c161f30243e4af8d9ed7 and b9c70aae06d5c16d266ff739d151ce6de0a8280d are different and
I dropped commit 383e26044ee96e8616861838d7e620c07ae89b5f.
I feel it makes more sense to close this pr and open a new one.


Incorrect OS Names

The page currently reads:

Desktop - Windows 2007
Server - 2008 R2

It should read:

Desktop - Windows 7
Server - Windows Server 2008 R2

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 20c190dc-ff1f-24c0-201a-fb8a741aaaa4
Version Independent ID: 5e7268b8-88d9-cbdd-d733-220ac08d3d3e
Content: FSLogix Overview - FSLogix
Content Source: fslogix-docs/overview.md
Product: fslogix
GitHub Login: @DougCoombs
Microsoft Alias: docoombs

Corrected, Thanks!

Are Windows 7 and 2008 R2 still supported? Or, are they end of life?
Curious if the solution will work with Windows 7 / 2008 R2 accessing the various storage options available there.

FSLogix is supported, but only in scenarios where the OS is still supported.
Thanks!
Doug
From: MrRitt<EMAIL_ADDRESS>Sent: Thursday, May 7, 2020 11:49 AM
To: MicrosoftDocs/fslogix-docs<EMAIL_ADDRESS>Cc: Doug Coombs<EMAIL_ADDRESS>State change<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/fslogix-docs] Incorrect OS Names (#1)
Are Windows 7 and 2008 R2 still supported? Or, are they end of life?
Curious if the solution will work with Windows 7 / 2008 R2 accessing the various storage options available there.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Ffslogix-docs%2Fissues%2F1%23issuecomment-625403276&data=02|01|Doug.Coombs%40microsoft.com|c7316888ee90402410a408d7f2aeeee6|72f988bf86f141af91ab2d7cd011db47|1|0|637244705457900141&sdata=2C1OAOEIBPbimqBV8m3nInkP3M2SlcEDUsmSI0rydRs%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALSRDL2ISSCDGGXXQO7YFZDRQLYA5ANCNFSM4H4SMR6Q&data=02|01|Doug.Coombs%40microsoft.com|c7316888ee90402410a408d7f2aeeee6|72f988bf86f141af91ab2d7cd011db47|1|0|637244705457910103&sdata=5KUqO6GSlUiu6jK1PkVa62KYOeW93SvdjwuPEuzFdvU%3D&reserved=0.


user12986714: Watch kukuhtekno.com

user12986714 requests the watch of the watch_keyword kukuhtekno\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

kukuhtekno\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Makyen in Charcoal HQ


Use names of registered data type to build cast functions.

Summary of the changes / Why this improves CrateDB
Checklist

[ ] User relevant changes are recorded in CHANGES.txt
[x] Touched code is covered by tests
[ ] Documentation has been updated if necessary
[x] CLA is signed
[ ] This does not contain breaking changes, or if it does:

It is released within a major release
It is recorded in CHANGES.txt
It was marked as deprecated in an earlier release if possible
You've thought about the consequences and other components are adapted
(E.g. AdminUI)

Could we workaround this issue?
Would it be a good idea to support alias types as well? Or is that too much?

Those are internal names (undocumented) and shouldn't be used directly by users. We translate the cast syntax into one of those functions because our function signature internally doesn't have a "data type type"

Could we workaround this issue?
Would it be a good idea to support alias types as well? Or is that too much?

Those are internal names (undocumented) and shouldn't be used directly by users. We translate the cast syntax into one of those functions because our function signature internally doesn't have a "data type type"

cool, thanks for explaining this.


FIX Allow passing objects to InjectionCreator::create()

Issue https://github.com/silverstripe/silverstripe-framework/issues/10533
Replacement for https://github.com/silverstripe/silverstripe-framework/pull/10539
Main difference is the use of get_class($class) instead of return $class to ensure that a new instance is always created.  I've also changed the unit testing.
I've also tidied up some of the previous  ?? '' added as part of the php 8.1 code-writing
This is technically a bugfix since it restores previous behavior of allow anonymous classes, which will unintentional, seems like it has a valid use case in unit testing.  Anonymous classes can be cleaner to use then the at times cumbersome combination of  TestOnly classes with private static $extra_dataobjects
I've put n8-dev down as a co-author

Looks good to me!

@n8-dev I've tagged 4.11.11 for you https://github.com/silverstripe/silverstripe-framework/releases/tag/4.11.11


[Feature Request] Brew install

Hi,
I really like you project as we are also in the midst of migrating our helm from v2 to 3v.
It would be really cool if you could put it on brew! It would be easy to install and maintain update as a end user.
Cheers!

@Adelbertt homebrew installation as been included!
Please give it a shot with brew install tokiwong/tap/helm-switcher

Hi,
To install it works but i'm getting,
(⎈ |N/A:N/A)➜  ~ helmswitch 2020/04/27 07:51:36 Unable to get release from repo

@Adelbertt thanks for confirming the brew install, i'll go ahead and close this issue.
As for unable to get release from repo, the current go code submits unauthenticated github api requests to gather releases, and there's currently a rate limit of 60 requests per hour, or 5000 requests per hour if you're authenticated through a git token.  The quickest workaround would be to hop on to another network or VPN and continue, but I understand that's clunky.

For unauthenticated requests, the rate limit allows for up to 60 requests per hour. Unauthenticated requests are associated with the originating IP address, and not the user making requests.
--https://developer.github.com/v3/#rate-limiting

If you have a use case for switching between helm versions multiple times within an hour (outside of initial functionality testing), please submit another issue regarding the Unable to get release from repo


Move documentation to hydrus

Instead of having separate repos for each project, we should add all documentation in the doc/ path into the hydrus repo. This way we build documentation directly with hydrus.
We should also implement the same things for other repos that need documentation.

all autogenerated doc should be with the code. Also the one specific to a repo. The ecosystem-wide documentation should have its own place.

Right, but this repo doesn't really have ecosystem wide documentation right? I was under the impression that this is only documentation related to hydrus. In which case we should move it to hydrus.


Update image-version-vm-cli.md

Fixed two typos.

@olayemio : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Looks good; thanks.


Cleanup search parameters on historical resources

Description
Adds a SQL Schema version that cleans up search parameters on historical resources.
Related issues
Addresses AB#102248
Testing
FHIR Team Checklist

Update the title of the PR to be succinct and less than 65 characters
Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
[ ] CI is green before merge
Review squash-merge requirements

Semver Change (docs)
Patch

Is not it too late? We have prior versions that rely on deleted history. They will not be able to apply if go in version order. Should we fix prior version instead?

Is not it too late? We have prior versions that rely on deleted history. They will not be able to apply if they go in version order. Should we fix prior version instead?

Good point, it should be in both. That way people who have already updated will still get it, and people who have yet to update get it sooner.

I don't see how version 73 can be successful with deleting history first. If so, I don't see the need to have special version to do this. We just need to fix 73.


consistent organization of code

What was wrong?
There was inconsistency in how code was organized in both the base implementation and the asyncio one.
How was it fixed?
Sorted out all code according to functionality and ensured that both the base and the asyncio implementation have everything organized roughly in the same order.
Also moved the compression logic and the endpoint management logic out of the Asyncio implementation as it can be shared by the trio implementation.
Also renamed some methods to be _ prefixed to signal they are private.
This should have zero meaningful functionality changes
Cute Animal Picture

:+1: I guess my intent was to say that under the assumption that EndpointAPI is our definition of public API this doesn't change anything.  I'll get release notes changes in place separately.


feat: Retrieving translations from scanner and CLI

I'm doing this to get your feedback and also share a problem I encountered during implementation.
The issue suggests using the GitHub package to retrieve the target projects. The problem is that when I use downloadAndExtract to retrieve the scanner and cli packages, an error appears. I tested on quite a few of our packages and the problem recurred on some.
To be able to continue working, I used some packages where there were no problems, including utils and ossf-scorecard-sdk.

@fraxken FYI when we pass the wrong branch the error is weird

It's because we keep doing createWriteStream even if the request fails, since the file is xx.tar.gz, it throws this error because he's waiting for gzip format

@PierreDemailly, Indeed, the problem was due to the branch

This code is not intended to be shipped in the package. Everything is devDep and must be run as separated script.

@fabnguess think to handle my review (you resolved some threads but the code didn't change, did you forget to push?)

I'll do it by tonight

Hi @fraxken ,
In our discussion with @PierreDemailly , we agreed to merge the contents of the language files from the target packages into the local language files rather than using the extendFromSystemPath API. I'm currently working on this aspect, but I can already submit my changes for your consideration.


Update offline logic to manually enable/disable offline mode

I re-wrote the logic to now not go into offline mode automatically. The current flow is:
You click on details/edit/delete and are offline:

The app will return a message that you don't have an internet connection and if you want to keep on using it you have to activate offline mode.
If the user activates offline mode the app will now modify all of the data solely in the indexed db.
I also start a polling mechanism that polls for an active internet connection. If it registers that the user is online again it shows a message to inform the user. I also added a "static" button (the message will disappear after some time) where the user can go into online mode again.
If the online mode is activated the application automatically synces all unsynced data. Except for offline created entries, those need to be completed (map markers added) to be synced.

The code is now much cleaner and a lot easier to understand than before. I will add tests for this functionality in a later PR. Otherwise this PR will be too big.

I noticed the following bug:

Go offline
Add a new tour (offline mode)
Go online
If you now click on "view" for this newly created tour, it goes to its detail page, does not find data and returns to the tourlist, while your previously created tour is now gone :D

Another bug (?):

Go offline
Click "Add tour"
The map is still rendered (without image), only when I want to submit the tour, I get the snackbar regarding the offline switch
When I now switch to offline, I move to the index page and my tour is lost.

@Tugark I created separate issues for the bugs you reported.


v2.9.0 betas have too new a DMG format

Both v2.9.0 beta 1 and 2 have their DMGs formatted as APFS, which hasn't been supported until macOS Sierra (10.12). The minimum requirement for this application is 10.8 which doesn't support the format.

Good catch!


#[GreaterThan], #[GreaterThanOrEqualTo], #[LessThan], #[LessThanOrEqualTo] works not as expected (size comparision)

✏ Describe the bug
Usage of the validation Attributes

#[GreaterThan]
#[GreaterThanOrEqualTo]
#[LessThan]
#[LessThanOrEqualTo]

is not fully compatible with the laravel implemetation of the corresponding validation rules. While the laravel documentation allows a field or a comparison value to be passed, the implementation in laravel-data always tries to evaluate the given value as a field reference.

https://laravel.com/docs/11.x/validation#rule-gt
The field under validation must be greater than the given field or value. The two fields must be of the same type. Strings, numerics, arrays, and files are evaluated using the same conventions as the size rule.

The constructor method of those validation rules looks like:
// Spatie\LaravelData\Attributes\Validation\LessThan
public function __construct(
        string|FieldReference $field,
    ) {
        $this->field = $this->parseFieldReference($field);
    }

✅ Expected behavior
When a string is passed to the constructor it is evaluated as a comparision value instead of a field reference.
🖥 Versions
Laravel: 10+
Laravel Data: 4
PHP: 8

Will be fixed in the next release, but not sure if Laravel's implementation is completely correct:
    dd(Validator::make([
        'a' => 'test',
        'b' => 42,
        'c' => 3.14,
        'd' => ['a', 'b', 'c'],
    ], [
            'a' => 'string|gte:2',
            'b' => 'numeric|gte:2',
            'c' => 'numeric|gte:2',
            'd' => 'array|gte:2',
        ]
    )->errors());

Provides:
Illuminate\Support\MessageBag {#1007
  #messages: array:2 [
    "a" => array:1 [
      0 => "The a field must be greater than or equal to 2 characters."
    ]
    "d" => array:1 [
      0 => "The d field must have 2 items or more."
    ]
  ]
  #format: ":message"
}

@rubenvanassche you're right. I can reproduce the same behaviour in laravel as you pointed out. Pretty interesting and I'm pretty sure it's a bug in the framework. Will look further into it and open a bug report in laravel-framework.


A runtime error occurred while running 'train.py'...

I encountered this error when I was training in the following configuration：
python train.py --images_dir='data/bird' --folder_distributed=True --sample_dir='samples/exp_1' --model_dir='models/exp_1'
I changed default options in train.py where
"default='os.environ['SM_MODEL_DIR'],"  to   “samples/exp_1',” "default=os.environ['SM_CHANNEL_TRAINING'],“  to   "default='data/bird',",
"default='os.environ['SM_MODEL_DIR'],"    to   “samples/exp_1',”
The dataset is loaded correctly.
but it failed in training with this error :
Traceback (most recent call last):
File "train.py", line 267, in
main(parse_arguments())
File "train.py", line 261, in main
start=args.start
File "/data/user/BMSG-GAN/sourcecode/MSG_GAN/GAN.py", line 417, in train
for (i, batch) in enumerate(data, 1):
File "/data/user/.local/lib/python3.5/site-packages/torch/utils/data/dataloader.py", line 582, in next
return self._process_next_batch(batch)
File "/data/user/.local/lib/python3.5/site-packages/torch/utils/data/dataloader.py", line 608, in _process_next_batch
raise batch.exc_type(batch.exc_msg)
RuntimeError: Traceback (most recent call last):
File "/data/user/.local/lib/python3.5/site-packages/torch/utils/data/_utils/worker.py", line 99, in worker_loop
samples = collate_fn([dataset[i] for i in batch_indices])
File "/data/user/.local/lib/python3.5/site-packages/torch/utils/data/utils/worker.py", line 99, in
samples = collate_fn([dataset[i] for i in batch_indices])
File "/data/user/BMSG-GAN/sourcecode/data_processing/DataLoader.py", line 132, in getitem
img = self.transform(img)
File "/data/user/.local/lib/python3.5/site-packages/torchvision/transforms/transforms.py", line 60, in call
img = t(img)
File "/data/user/.local/lib/python3.5/site-packages/torchvision/transforms/transforms.py", line 163, in call
return F.normalize(tensor, self.mean, self.std, self.inplace)
File "/data/user/.local/lib/python3.5/site-packages/torchvision/transforms/functional.py", line 208, in normalize
tensor.sub(mean[:, None, None]).div(std[:, None, None])
RuntimeError: output with shape [1, 128, 128] doesn't match the broadcast shape [3, 128, 128]
I think this error has nothing to do with my modification.
Could you please tell me what caused this error?

Broadcast shape (3, 128, 128) is (rgb, height, width) of image. output shape (1, 128, 128) means it's outputting one color channel, instead of 3/RGB. I think , I don't know that much about coding. Hopefully this helps.

I have the same problem, no idea why


Wrong information displaying in fields when work items are customized

We added a field above Description on a user story work item and the data displaying on the estimate page moved the descrtption content into the Acceptance Criteria field and the content of the new field was displayed in the Description field.

Hi, I'll perform a test and  get back to you.

Hi @AminTi any news on this?
We have a similar problem with customized PBIs that have 3 sections in this order:

User Story Details (eg. used for standard US format "as a user... I want to... so that...")
Description (used to more deeply describe business rules, constraints, etc)
Acceptance Criteria

when we start an estimate session what happens is the following:
"User Story Details" field's content becomes "Description" content in the estimate board
"Description" field's content is not present in the estimate board
"Acceptance Criteria" field's content is correctly shown as "Acceptance Criteria" in the estimate board
Thanks for any update
Marco


ci(Test): Simplify via pre-commit-action

Many steps of the Test workflow have been consolidated into pre-commit-action to reduce duplication across repositories. Continue to self-test action at current ref.

Oops, I didn't meant to use "v" in the version number. (Our repos don't have "v" in their tags.) Fixed!


pre-Release 2023.01.25 results in many (~30%?) of the sensors not being present anymore

I encountered a serious problem when running 2023.01.25:
About 30% of the sensors where not available anymore in the luxtronik integration.
This included most of the cooling sensors, and e.g. the domestic water target temperature number, and several pump status sensors.
I downgraded again to 2023.01.20 to resolve these problems.
Let me know if you need additional information to diagnose this.

Same issue here after upgrade to 2023.01.25.
Status doesn't see any domestic water programs and idle status.

I really don't think that using the visibilities to determine default visibility of sensors in Home Assistant is a good idea. On my system the reported visibilities from Luxtronik don't quite match up with the actual sensors / functions that are in use, and it appears that goes for more people.

I encountered a serious problem when running 2023.01.25

I can reproduce it. I provide a fix soon.

2023.01.29 should fix this. Sorry for the trouble.

Yes, I can confirm 2023.01.29 fixes this!

mayne too ;)


Deep merge when using mock_outputs_merge_with_state in a dependency block

Following from https://github.com/gruntwork-io/terragrunt/pull/1765 , it's possible to merge the existing (applied) state into the mocks (state overwrites mocks). However, this is only a shallow merge.
Let's say you have a module that outputs a map(map(string)). An existing output of that module could be
{
  "security_groups": {
    "sensitive": false,
    "type": [
      "object",
      {
        "first": [
          "object",
          {
            "arn": "string",
            "description": "string",
            "id": "string",
            "name": "string"
          }
        ]
      }
    ],
    "value": {
      "first": {
        "arn": "arn:aws:ec2:ap-southeast-1:000000000000:security-group/sg-aaaaaaaaaaaaaaaaa",
        "description": "My first security group",
        "id": "sg-aaaaaaaaaaaaaaaaa",
        "name": "my-first-sg"
      }
    }
  }
}

and let's say the usage of that module is like so:
dependency "security_groups" {
  config_path = "../security_groups"

  mock_outputs_allowed_terraform_commands = ["validate", "plan", "state"]
  mock_outputs_merge_with_state = true
  mock_outputs = {
    security_groups = {
      first = { id = "sg-mock" }
    }
  }
}

inputs = {
  something = [
    dependency.security_groups.outputs.security_groups.first.id
  ]
}

If I were to change the inputs of the dependency (the security_groups module), which adds an additional value to the output map, so that it becomes
{
  "security_groups": {
    "sensitive": false,
    "type": [
      "object",
      {
        "first": [
          "object",
          {
            "arn": "string",
            "description": "string",
            "id": "string",
            "name": "string"
          }
        ],
+        "second": [
+          "object",
+          {
+            "arn": "string",
+            "description": "string",
+            "id": "string",
+            "name": "string"
+          }
+        ]
      }
    ],
    "value": {
      "first": {
        "arn": "arn:aws:ec2:ap-southeast-1:000000000000:security-group/sg-aaaaaaaaaaaaaaaaa",
        "description": "My first security group",
        "id": "sg-aaaaaaaaaaaaaaaaa",
        "name": "my-first-sg"
      },
+      "second": {
+        "arn": "arn:aws:ec2:ap-southeast-1:000000000000:security-group/sg-bbbbbbbbbbbbbbbbb",
+        "description": "My second security group",
+        "id": "sg-bbbbbbbbbbbbbbbbb",
+        "name": "my-second-sg"
+      }
    }
  }
}

and attempt to use it BEFORE the updated dependency has been applied
dependency "security_groups" {
  config_path = "../security_groups"

  mock_outputs_allowed_terraform_commands = ["validate", "plan", "state"]
  mock_outputs_merge_with_state = true
  mock_outputs = {
    security_groups = {
      first = { id = "sg-mock" },
+      second = { id = "sg-mock" }
    }
  }
}

inputs = {
  something = [
    dependency.security_groups.outputs.security_groups.first.id,
+    dependency.security_groups.outputs.security_groups.second.id
  ]
}

We'll receive the following error from terragrunt when trying to plan
Unsupported attribute; This object does not have an attribute named "second".

This is due to the logic in getTerragruntOutputIfAppliedElseConfiguredDefault only checking the output key and not supporting a deep merge of the output values https://github.com/gruntwork-io/terragrunt/blob/cc1927746e8883322a0b37394887db4d8d6810ae/config/dependency.go#L322-L327
Would you be open to a PR or discussion on adding support for deep merging the outputs into the mock?

Allowing deep merge of mocks to state makes sense to me, and a PR to add it would be welcome. I think this probably makes the most sense as a feature flag similar to merge_strategy we have on include blocks.
I would probably add a new config mock_outputs_merge_strategy_with_state that replaces mock_outputs_merge_with_state, and can be set to no_merge, shallow, or deep, with no_merge being the default. We could also maintain backward compatibility by having mock_outputs_merge_with_state = true mean mock_outputs_merge_strategy_with_state = "shallow".


how Hide flashlight icon when press a external key

hi
how i can hide flashlight icon when press a external key?

@majidsoltani Try lv_obj_set_hidden.

this my code to draw flashlight icon :
#define GT_SYSTEM_ICONS_Y  2
#define GT_SYSTEM_ICONS_MARGIN_X  3
void gt_show_System_Icons(uint8_t buttery_state,bool flashLight)
{
uint8_t x=LV_HOR_RES - GT_SYSTEM_ICONS_MARGIN_X;
if (buttery_state==3)
{
	LV_IMG_DECLARE(gt_ico_battery_3);
	lv_obj_t *img_battery_3 = lv_img_create(lv_scr_act(),NULL);
	lv_img_set_src(img_battery_3,&gt_ico_battery_3);
	lv_obj_set_pos(img_battery_3,x-26,GT_SYSTEM_ICONS_Y);

	x=x-25-GT_SYSTEM_ICONS_MARGIN_X;
}
if (flashLight==true){
	LV_IMG_DECLARE(gt_ico_flash_light);
	lv_obj_t *img_flash_light = lv_img_create(lv_scr_act(),NULL);
	lv_img_set_src(img_flash_light,&gt_ico_flash_light);
	lv_obj_set_pos(img_flash_light,x-25,GT_SYSTEM_ICONS_Y);

	x=x-25-GT_SYSTEM_ICONS_MARGIN_X;
}

}
and use top function in main code two draw system icons.
    gt_show_System_Icons(3,true);

while(1){
	lv_task_handler();
	delay_us(10000);
}

now i want show/hide flash light icon when user pressed an external key.
i don't now how use lv_obj_set_hidden() to hide/show flashlight icon :-P

Hi,
You may use lv_obj_set_hidden(img_flash_light, true); in your step. But the object pointer img_flash_light  cannot be seen outside of function gt_show_System_Icons, you may consider to make it global or others.

@majidsoltani,

[...] when press a external key

For this purpose, you can use LV_INDEV_TYPE_BUTTON [1, 2, 3].
:clipboard: Reference

https://github.com/littlevgl/lvgl/issues/567#issuecomment-446586421
https://www.youtube.com/watch?v=dk772McmJs4
https://github.com/littlevgl/lvgl/wiki/Porting#button

i define img_flash_light as global pointer. when use lv_obj_set_hidden(img_flash_light, true) before run lv_task_handler();  The flashlight icon is hidden but if the lv_obj_set_hidden(img_flash_light, true) run after the lv_task_handler(); command, the flashlight icon will not be hidden and will still be displayed in the display. how i can refresh current screen?

@majidsoltani Please verify that you are actually entering the body of that if statement with a debugger. This sounds like a problem with your setup, rather than LittlevGL.

@majidsoltani Please try the volatile,
volatile int c = 0;
[...]

@majidsoltani Please verify that you are actually entering the body of that if statement with a debugger. This sounds like a problem with your setup, rather than LittlevGL.

i checked...i think GUI screen most be refresh after change gt_ico_flash_light hidden attribute.
but i don't khow how refresh GUI !

@majidsoltani The GUI is refreshed by lv_task_handler. If the screen is not being refreshed it means that lv_task_handler is never executed a second time.
Given the code sample you provided I would first check that delay_us actually returns, and then check whether you enter the if statement.

@majidsoltani The GUI is refreshed by lv_task_handler. If the screen is not being refreshed it means that lv_task_handler is never executed a second time.
Given the code sample you provided I would first check that delay_us actually returns, and then check whether you enter the if statement.

yes enter in if statement....I found the reason for my problem, but I still could not solve it. this problem is form ex_disp_flush (My LCD Driver Code).

@majidsoltani What is the problem in ex_disp_flush?

is use nokia 1661 LCD , this lcd use ST7735 driver.
this is my flush code :
int32_t x;
int32_t y;
setAddrWindow(x1,y1,x1,y2);
for(y = y1; y <= y2; y++) {
    for(x = x1; x <= x2; x++) {
        /* Put a pixel to the display. For example: */
 	    nlcdSendPixel(color_p->full);
        color_p++;
    }
}
nlcdSendCmd(0x00);
/* IMPORTANT!!!
 * Inform the graphics library that you are ready with the flushing*/
lv_flush_ready();

}
but i think this code not work currently for draw pixels in x,y position

Video result :

@majidsoltani It looks like there are artifacts appearing on the display. This could be memory corruption or a problem with your display driver.

I finally solved my problem
for solve this problem  i do :
1- use lv_tick_inc(3); in main while(1){}
2- in ex_disp_flush function before  send setAddrWindow command , send  NOP command
(after send NOP command , setAddrWindow Command work as correctly)

@majidsoltani I think that your problem was simply that you didn't call lv_tick_inc before. Glad to hear it is fixed.
lv_tick_inc shouldn't be called in the main while(1) loop. It needs to be called from a thread or an interrupt handler. This is because you cannot guarantee the timing of lv_task_handler in all scenarios.


Include Load Data from Ops in Influx Events

Previously, some of the data from ops events was not being included in the stats sent to InfluxDB.  In this pull request, we have included all ops data.
As discussed in #4 , we decided to separate out ops data into several events.  In this PR, a single ops event from Hapi Good will now emit:

The same ops event as before (so backwards compatibility should not be broken)
One of each of the following events for each port:

ops_requests
ops_concurrents
ops_responseTimes

One ops_sockets event

We also improved unit test coverage quite a bit, with all formatters having explicit tests.
We have been using this module in production for a number of our services and it seems to be working quite nicely.  I have Grafana graphs that query most of the ops events.  We don't use this module to report other event types just yet, so if there is some way to beta test that out it might be nice.
Special thanks to @wei-hai-ck since he actually did the bulk of the work here -- but didn't want the glory of the pull request.

How do these changes look overall?  Do we think these changes would improve the module?  Is the code clean, well tested, and easy to understand?  Any improvements I can make to the implementation?
My company has been using this version in several of our Node services in production, and it works really well for us.  Would be awesome to share it with the community if folks think it would be useful.  Several of my colleagues are familiar with Hapi Good so I can ask for some help in reviewing if it would be helpful.

@fhemberger when will this PR be merged, there some nice things in here.

Thanks @sfabriece !  If you have some time to review the changes that would be awesome since you're pretty familiar with this module.

@AlecHFerguson Can you please resolve the conflicts? Otherwise I think it's good to merge. :+1:

@fhemberger The conflicts turned out to be quite thorny so I went ahead and created a new PR.  See #12.  Closing this one.


I also ran an experiment where I ran the current implementation and the implementation from this PR. In each separate cluster, I ran StackRox in offline-mode, and I uploaded the latest "offline" vuln dump to Central. From there I found the current implementation stayed at around 3.5G for about 20 minutes, while this PR's implementation hovered around 700MB for a few minutes before going back down to about 500MB, which is its steady-state. This is a rather significant memory reduction.

Current Scanner loading all vulns (offline-mode):

This implementation loading all vulns (offline-mode):

You'll find the current Scanner requires about 3.5G while this implementation only requires ~700MB.

I added a benchmark test for the offline dumps, too:
$ go test -run=^$ -bench=^BenchmarkLoadOSVulnsFromDump -benchmem ./pkg/vulndump/
goos: darwin
goarch: amd64
pkg: github.com/stackrox/scanner/pkg/vulndump
cpu: Intel(R) Core(TM) i5-1038NG7 CPU @ 2.00GHz
BenchmarkLoadOSVulnsFromDump-8           	       1<PHONE_NUMBER> ns/op<PHONE_NUMBER> B/op	 8293226 allocs/op
--- BENCH: BenchmarkLoadOSVulnsFromDump-8
    loader_test.go:38: Loaded 134212 vulns
BenchmarkLoadOSVulnsFromDump_Offline-8   	       1<PHONE_NUMBER>5 ns/op<PHONE_NUMBER> B/op	26622319 allocs/op
--- BENCH: BenchmarkLoadOSVulnsFromDump_Offline-8
    loader_test.go:38: Loaded 415338 vulns
PASS
ok  	github.com/stackrox/scanner/pkg/vulndump	22.328s

$ go test -run=^$ -bench=^BenchmarkOSLoader -benchmem ./pkg/vulndump/
goos: darwin
goarch: amd64
pkg: github.com/stackrox/scanner/pkg/vulndump
cpu: Intel(R) Core(TM) i5-1038NG7 CPU @ 2.00GHz
BenchmarkOSLoader-8           	       1<PHONE_NUMBER> ns/op	702851656 B/op	 8293140 allocs/op
--- BENCH: BenchmarkOSLoader-8
    batch_loader_test.go:109: Loaded 134212 vulns
BenchmarkOSLoader_Offline-8   	       1<PHONE_NUMBER>0 ns/op<PHONE_NUMBER> B/op	26622223 allocs/op
--- BENCH: BenchmarkOSLoader_Offline-8
    batch_loader_test.go:109: Loaded 415338 vulns
PASS
ok  	github.com/stackrox/scanner/pkg/vulndump	20.754s

This also prints out the number of vulnerabilities we read from the JSON file, and they both match. I will merge with CI


Svelte 3 support?

This plugin doesn't seem to support svelte 3. (I got a linting error "directive values should not be wrapped")

Same: I'm getting A component can only have a default export.

Svelte 3 was very partially supported by this package indeed.
The new 1.0.0 version brings up to date Language Server and grammar, which should fix most of the existing issues in this regard.


mvn hpi:run shows java.nio.file.NoSuchFileException: .../plugin/target/classes/META-INF/annotations/hudson.Extension

I got the error said as the PR title when I try to build the source code with java11.

We can skip these errors via executing java8. I got this solution which comes from https://github.com/jenkinsci/configuration-as-code-plugin/issues/613#issuecomment-432417048.


Cybersecurity EO Requirements and Audit

See e-mail from Steve Dower.
The only part we need to worry about right now is the Software Bill of Materials. See https://www.1eswiki.com/wiki/ADO_sbom_Generator for more details. This needs to be added to our AzDO build yaml.

Reopening issue because this is needed in Pylance and Pydebug(?) as well.


task: write chapter 1

Start and finish working on chapter one then take it for review to supervisor

Resolved, wiki will be updated with relevant information


There are thumbs up / thumbs down reactions available when Cody provides a response to an explain prompt

see https://github.com/sourcegraph/jetbrains/issues/104


Investigate whethere we can use number for chain_id in N-API

In TS libraries such as ethers, viem, and @ethereumjs/common the chainId variable is represented as a number, whereas EDR uses BigInt.
We should investigate whether we can also use number in the ProviderConfig while maintaining strong typing for chain_id: u64

Should we use the type override of the N-API?
pub struct ProviderConfig {
...
    #[napi(ts_type = "number | bigint")]
    pub chain_id: BigInt,
...
}

index.d.ts typescript type:
  chainId: number | bigint


Skiplist index

CODE REVIEW
Sorry this one took so long, hung up in patent meetings :(.  This code allows us to index values in the skiplist by position.  This isn't a constant time operation and is performed in O(log n) as we apply an algorithm that's very similar to the index by value.  Indexing by position does, however, end up being about twice as fast as in doing so we get to compare two uint64s instead of calling an interface method.  This will continue to be the case as long as Golang doesn't support generics.  The basic algorithm is described here:
http://cglab.ca/~morin/teaching/5408/refs/p90b.pdf
But slightly modified by us as we support both position and value indices.  I still need to add the skiplist split logic which will allow us to split at a position and then skiplists can be dropped into the PALM tree nodes for a potential performance improvement there.
@alexandercampbell-wf @tannermiller-wf @beaulyddon-wf @rosshendrickson-wf @stevenosborne-wf @tylertreat-wf @ericolson-wf

+1

+1

+1


too many ports EXPOSEd in Dockerfile - incompatibility with GitLab CI

I try to use this image as a service in GitLab CI.
The behaviour of Gitlab CI is such that it looks up the ports EXPOSEd and checks if they are available. Unfortunately, this image's Dockerfile tells that it EXPOSEs ports 9306, 9308, 9312, and, for some reason, 9315-9325. Of course it doesn't actually listen on those 9315-9325 ports, therefore fails the GitLab's check.
Unfortunately it is not possible to "unexpose" ports using a child image (FROM manticoresearch/manticore in Dockerfile), the only option I am left with is completely forking the project, which i would like to avoid.
Is it really necessary to keep this EXPOSE 9315-9325 statement in the Dockerfile? The image users can always bind any port using docker run -p ... option.

Good point. Indeed we might not need the EXPOSE rules, especially for the replication ports (9315-9325). We'll discuss it in the team.

Fixed in https://github.com/manticoresoftware/docker/commit/1a58d367feb0c43ad4f136261e4804c2756d3f0c


Update README.md

Hi! I don't have bandwidth for full doc sets, so I just edited the README + Contributing.md—making small changes. Some suggestions for the README:
Take a look at this product analysis template (https://github.com/zalando/zalando-howto-open-source/blob/master/producttemplate.md) and use it to create an Intro section in your README that answers these questions:
— what inspired/prompted you to make this?
— do you have metrics/other evidence showing its usefulness?
— any user testimonials showing its value?
— what is this like/not like; or is it the only one of its kind?
Thanks for submitting your project. :)

Thanks again, Lauri!


Bugfix: do not attempt to enumerate over DateTimes when converting values

Previously, handle_value checked if the value was a map: is_map(value) and, when true, enumerated over the value to convert the keys accordingly. However:
{:ok, datetime} = DateTime.new("Etc/UTC")
is_map(datetime) # => true

resulting in the following error: (Protocol.UndefinedError) protocol Enumerable not implemented for <DATETIME>. This PR fixes that by just returning the value if it is a datetime.

Coverage increased (+0.02%) to 98.718% when pulling e9e1b1544a9214821c6274a39613bc5a943d0f92 on fast-radius:td-datetime into 887f3a1f3467fdc8c02e40f0da2600ea9c871c50 on sobolevn:master.

Thanks a lot!

I will release a new version soon.


Dropdown refinementlist crashes on search

🐛 Current behavior
When searching  in a dropdown refinementlist, code crashes into following error:

🔍 Steps to reproduce
Go to the attached codesandbox url, start a search with 'test' in the searchbox.
Then click on the filter button and inside the dropdown, search for a value: 'bio'
Live reproduction
https://codesandbox.io/s/keen-lake-pp46dw
💭 Expected behavior
No error
Package version
latest instantsearch.js 4.52.0 and algoliasearch 4.15.0
Operating system
macOS
Browser
Chrome
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Not sure why the error is not properly shown (possibly https://github.com/algolia/algoliasearch-client-javascript/issues/1444), but this is because you're attribute isn't set up for searching in the index configuration:
{
    "message": "Cannot search in `culinary_categories` attribute, you need to add `searchable(culinary_categories)` to attributesForFaceting.",
    "status": 400
}


Removed "Part"

Updated lab names to remove "Part 1/Part 2"

Updated lab titles to be more consistent with the file path names and the PowerPoint slides.


io.flutter.embedding.android.FlutterActivity mode under 7.0 black screen

Flutter 1.9.1+hotfix.7-pre.1 • channel stable •
https://github.com/flutter/flutter.git
Framework • revision e7527a1906 (3 weeks ago) • 2019-10-16 16:34:57 +0800
Engine • revision b863200c37
Tools • Dart 2.5.0

android system below 7.1 ,use  io.flutter.embedding.android.FlutterActivity mode change page ,Activity trigger onstop resulting FlutterTextureView or FlutterSurfaceView happen destroy,then the page open black screen

Hi @RootKatherine
can you please provide your flutter doctor -v
and flutter run --verbose?
Also, to better address the issue, would be helpful
if you could post a self contained app on github
or the steps to reproduce it.
Thank you

flutter doctor -v :

flutter activty->A

Hi again
thank you for providing your flutter doctor
could you please provide also
your flutter run --verbose
together with a a minimal code sample to reproduce the problem
thanks again

Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now. Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact descriptions what happens, logs and the output of 'flutter doctor -v'  please.
All system setups can be slightly different so its always better to open new issues and reference related issues.


Replace latest with v1 for Julia manual link

latest links were "not meant to be used" (https://github.com/JuliaLang/julia/issues/37623)
This replaces a broken link to the v1 Julia manual style guide.

@mattBrzezinski please merge


Axis annotation: XYZ table isn't clear on editable and non-editable cells

The current XYZ table has 15 cells.
Based on my test, 6 of them are editable that are supposed to control the annotations in the visualizer. Another 9 of them are non-editable, which are supposed to only display relevant information to the user.
The current design meshes these 15 cells in the same table. IMO, it's a pretty bad design choice.

It turns out all cells are editable. The trick is that you need to triple click a cell, to select all text in that cell, and then they become editable.


Can not load css for external package

This is my intent (choose one)

[x] I want to report a bug
[ ] I want to request a feature or change
[ ] I want to provide or change a feature

The problem
Following the documentation for setting up the react-day-picker in my project I try to require styles usying css-loader like this:
import "react-day-picker/lib/style.css";

but it doesn't work.
Proposed solution
🤔

Hey @lipina, thanks for this report! I am a afraid it appears that this might just be hops‘ current behavior: we are currently using css-loader with CSS modules for all CSS files.
As soon as we can merge #417 or #354 we will have a per-file opt-out for this behavior (see bc3a94a)
Could you temporarily include that component’s CSS locally in your project and wrap its class identifiers like so :global(.xxx) (see https://github.com/css-modules/css-modules/blob/master/README.md#exceptions)?

This issue can now (finally) be resolved: https://github.com/xing/hops/releases/tag/v10.3.0
@lipina please verify.

It doesn't work for me unfortunately. 🤷♀
I tried both import "react-day-picker/lib/style.css"; and import "react-day-picker/lib/style.css?global";

This has been merged into master with #688 and will be included in the next release of Hops 11 RC.


Add live test recordings

Recording the identity live tests is arguably unimportant because they're only smoke tests verifying requests are well-formed and responses deserialized without error. Both ends can be met with offline mocks.
Would require at least a little new code to scrub secrets.

I'm moving this to the backlog because there aren't any scenarios we want to add recordings for at this time. I want to keep this issue though, because we may want to transition tests from the current mocking strategy to recordings as we transition credentials to use msal.ClientApplication.


Build Android gen_snapshot as arm64 binary to run natively on Apple Silicon

On an arm64 Apple Silicon Mac, the published gen_snapshot binaries are x86_64 and therefore run with Rosetta translation.
android-arm-profile/darwin-x64/gen_snapshot
android-arm-release/darwin-x64/gen_snapshot
android-arm64-profile/darwin-x64/gen_snapshot
android-arm64-release/darwin-x64/gen_snapshot
android-x64-profile/darwin-x64/gen_snapshot
android-x64-release/darwin-x64/gen_snapshot

Compile Android gen_snapshot binaries as arm64, and publish in the arm64 Flutter install (artifacts.zip), as well as the macOS desktop artifacts that get curled when upgrading on an arm64 Mac.
macOS issue was https://github.com/flutter/flutter/issues/101138
iOS issue was https://github.com/flutter/flutter/issues/152280

@cbracken I wonder if fs path will be changed for arm64 binaries, i.e. android-arm-profile/darwin-arm64/gen_snapshot instead of android-arm-profile/darwin-x64/gen_snapshot for Apple Silicon hosts ?

My intent is to land this the same way as I did for macOS and iOS: the existing binaries will be replaced by universal binaries.
I haven't evaluated the difficulty of that approach yet as I've been working on other things so haven't started the Android side yet.

@cbracken breadcrumb for an issue that may also come up for Android: https://github.com/flutter/flutter/issues/156175


add Hungarian flag

add Hungarian flag from famfam.

Hooray Jenkins reported success with all tests good!

Oh! I see why I missed Hungarian in-game now. Before merging translations (#2510) the Hungarian language name in English was "Angol" - I was wondering what that entry was :D
This round of translation fixes straightened that out so it makes sense now. Most typical translation field that goes funny since that field needs to be in English in any language :-)
So now I see language entry as well as the flag! Huzzah!

Yes, I realized that only when I checked it out in game, sorry for the confusion :D Since all the languages came up as translations, I thought that was supposed to be "English" in the target language :)


The comma operator does not work with pup v0.4.0

Hi,
According to your example at https://github.com/EricChiang/pup#--and- pup is supposed to print :
$ cat robots.html | pup 'title, h1 span[dir="auto"]'
<title>
 Robots exclusion standard - Wikipedia, the free encyclopedia
</title>
<span dir="auto">
 Robots exclusion standard
</span>

but pup v0.4.0 shows :
$ cat robots.html | pup 'title, h1 span[dir="auto"]'
<title>
 Robots exclusion standard - Wikipedia
</title>

My mistake, robots.html has changed since :
$ cat robots.html | pup 'title, h1 span[dir="auto"]'
$


Implement JwtCredentials with custom claims

Adds the ability to create custom JWT Credentials (JwtCredentials) with custom claims from a ServiceAccountJwtAccessCredentials instance.

ServiceAccountJwtAccessCredentials will continue to provide on-demand credentials where the audience is based on the requested URI
Adds JwtCredentials class which can be directly built with a PrivateKey, privateKeyId string, and custom JwtCredentials.Claims. You can also build new JwtCredentials via JwtCredentials#withClaims(JwtCredentials.Claims) which only overrides the new specified claims fields.
Add ServiceAccountJwtAccessCredentials#withClaims(JwtCredentials.Claims) which will provide a JwtCredentials instance with custom claims
Changed the credentials cache to be keyed of the full Claims object rather than just the URI.

Note: I haven't filled out the javadoc until we work through the interface.

Why wouldn't you push the cache down as well?

The cache in ServiceAccountJwtAccessCredentials is used because the credentials are reactionary to the request URI which is used as the audience (and thus handles many audiences). You hang onto the single instance of the ServiceAccountJwtAccessCredentials for all calls you make.
When you request a JwtCredentials with custom claims, you can hang onto that new Credentials instance which can refresh itself when it expires.

The cache has a secondary benefit of async refresh as well

Actually nevermind, I never added that part. Sorry for the noise

@kolea2, @igorbernstein2, @elharo any other concerns here?


Add a README

The kids like it :smile:

I'll write one.

i put most of it in the library comment: https://github.com/dart-lang/observe/blob/master/lib/observe.dart#L5 ... is there any good tooling to sync things like that? Or just move the contents to README?

here's the live content: http://www.dartdocs.org/documentation/observe/0.13.0+2/index.html#observe/observe

sent a pull req, just moved the text to README since more people see that


[BUG] Can't get the favicon.ico icon in offline environment

Describe the bug

To Reproduce
Steps to reproduce the behavior:
1.open Harvester
Expected behavior

show favicon.ico correctly
Log

Environment:

Harvester ISO version:  0.20-rc3
Installation Mode: ISO
Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630):

Additional context
Add any other context about the problem here.

validated on master-0430.iso


Added constant predictor + test to it

Fix @implausibleDeniability bug with abstract __init__ - we must call parent constructor
Added constant predictor and test to it
Makefile with ability to load data and run test

How to use Makefile and for which reason?

How to use Makefile and for which reason?

Makefile needed for one-line commands that can automate routine tasks:

in my case, it can run GitHub CI before pushing to branch, so you can firstly check that all tests and lints passes locally and then push (this is not obligatory
also, it downloads data

How to use:

make download_data - downloads data
make test - runs tests and linters

@DanisAlukaev could you look at PR?


Platform backlog meta

Objectives
The company OKRs and engineering OKRs outline the following objectives and key results:

Shareable code artifacts

Data to dashboard via files
Rehydrate project via a single CLI command
CI workflow for artifact deployment

High quality experience

Remove Node.js

Migrate data modeller and profiling to APIs
Migrate CLI to Go

Improved error handling
Solid unit and end-to-end testing

Work breakdown
Code artifacts

[ ] #1174
[ ] Design end-to-end API workflow for manipulating and applying file artifacts (incl. invalid state)
[ ] Adapt migration and repo APIs to support several different file artifact representations (mapping up to internal objects)
[ ] Refactor/implement migrations and refresh logic for YAML artifacts

Modeller on APIs

[ ] #1175

CLI

[ ] #1176
[ ] Add ability to serve the web-local SPA
[ ] Add ability to start runtime
[ ] Setup GoReleaser for cli with nightly and/or preview builds

Avoiding new tech debt

[ ] Merge relevant parts of https://github.com/rilldata/rill-developer/pull/1064
[ ] Refactor functionality in server into a "services" layer + expand current tests
[ ] Rename drivers to a more appropriate term (such as persistence, stores, infra)
[ ] Add README in drivers explaining the stores concepts
[ ] Split runtime.proto into multiple modules
[ ] Add request validation using https://github.com/bufbuild/protoc-gen-validate
[ ] Setup e2e server tests using https://github.com/grpc/grpc-go/tree/master/test/bufconn
[ ] Setup pagination on all relevant endpoints in accordance with these guidelines
[ ] Consider running gRPC using https://github.com/bufbuild/connect-go
[ ] Configure Druid driver to not build Docker image on every test
[ ] Submit Druid authentication issue to calcite-avatica-go (regarding https://github.com/begelundmuller/calcite-avatica-go/commit/52480d9968a90893976c582449a56f2fa6c85275)
[ ] Revisit dry runs in OLAP queries – do we need them? If yes, it should check args and return schemas
[ ] Check design of the rill.runtime.Type protobuf message against Apache Arrow's schema type (link)
[ ] Disable SQL in runtime builds (for now)
[ ] Add attribution and tests to package pkg/sharedlibrary (it's loosely adapted from https://github.com/ying32/dylib)
[ ] Setup http://golangci-lint.run

Connectors

[ ] #1179
[ ] Add unified validation across frontend/backend (e.g. using JSON schema)
[ ] Support globs for local, S3 and GCS
[ ] Support NDJSON files
[ ] #1182

Better error messages

[ ] Research current vs. desired error messages from runtime
[ ] Refactor inline errors to error consts
[ ] Move to a complex error message type that can include things like stack traces, lists of errors, human-friendly messages, suggestions, docs links, etc.
[ ] Adapt gRPC error handling to emit extra error details (see these guidelines)

Cloud ready

[ ] runtime: Setup configurable CORS that works for both local and remote deployments
[ ] runtime: Add JWT-based auth inspired by https://docs.temporal.io/server/security
[ ] runtime: Setup standalone Docker image
[ ] control plane: Rename server-cloud to admin
[ ] control plane: Research and MVP authorization
[ ] meta: Design async task architecture for runtime

as I learned, protoc-gen-validate doesn't support Javascript

as I learned, protoc-gen-validate doesn't support Javascript

Yeah, but we don't need it on the client side – it's only needed to validate request parameters on the server.

@begelundmuller I am new to this repo, and after going through the tasks to understand more about this project in depth.
I feel split runtime. proto in multiple modules is a good first issue to understand more about the project.
can I pick the item and go ahead?

Hey @antimpatel, thank you for your interest in contributing – and sorry that I missed your comment. The proto refactor impacts a number of outstanding PRs, so it's something we'd prefer to do on the team. If you're still interested in contributing, I would suggest https://github.com/rilldata/rill-developer/issues/1265 as a good first issue :)


AttributeError: 'NoneType' object has no attribute 'shape'

Hello, I have encountered this problem, but I don’t know how to solve it. I hope you can give me some help. Thank you very much.
python3 train.py         --model-name zhou_full         --depth-training-loaders "kitti_zhou_train"         --train-batches-per-epoch 7293         --masking-enable         --masking-from-epoch 15         --masking-linear-increase
Starting initialization
Loading training dataset metadata:

Can use 43760 images from the kitti (zhou_split) train split for depth training
Can use 2975 images from the cityscapes train set for segmentation training
Loading validation dataset metadata:
Can use 1159 images from the kitti (kitti_split) validation set for depth validation
Can use 500 images from the cityscapes validation set for segmentation validation
Summary:
Model name: zhou_full
Logging directory: /media/disk1/xgl/SGDepth-master/Checkpoints/sgdepth_eccv_test/zhou_full
Using device: cuda (GeForce GTX 1070)
Epoch 0:
Traceback (most recent call last):
File "train.py", line 372, in
trainer.train()
File "train.py", line 340, in train
self._run_epoch()
File "train.py", line 228, in _run_epoch
for batch_idx, batch in enumerate(self.train_loaders):
File "/media/disk1/xgl/SGDepth-master/loaders/init.py", line 25, in iter
for batch_idx, *group in zip(length_iter, *infinite_iters):
File "/media/disk1/xgl/SGDepth-master/loaders/init.py", line 30, in _make_infinite
for batch in loader:
File "/home/xgl/anaconda3/envs/xgl/lib/python3.6/site-packages/torch/utils/data/dataloader.py", line 582, in next
return self._process_next_batch(batch)
File "/home/xgl/anaconda3/envs/xgl/lib/python3.6/site-packages/torch/utils/data/dataloader.py", line 608, in _process_next_batch
raise batch.exc_type(batch.exc_msg)
AttributeError: Traceback (most recent call last):
File "/home/xgl/anaconda3/envs/xgl/lib/python3.6/site-packages/torch/utils/data/_utils/worker.py", line 99, in _worker_loop
samples = collate_fn([dataset[i] for i in batch_indices])
File "/home/xgl/anaconda3/envs/xgl/lib/python3.6/site-packages/torch/utils/data/_utils/worker.py", line 99, in
samples = collate_fn([dataset[i] for i in batch_indices])
File "/home/xgl/anaconda3/envs/xgl/lib/python3.6/site-packages/torch/utils/data/dataset.py", line 85, in getitem
return self.datasets[dataset_idx][sample_idx]
File "/media/disk1/xgl/SGDepth-master/dataloader/pt_data_loader/basedataset.py", line 217, in getitem
sample = self.add_const_dataset_items(sample)
File "/media/disk1/xgl/SGDepth-master/dataloader/pt_data_loader/specialdatasets.py", line 47, in add_const_dataset_items
native_im_shape = sample[native_key].shape
AttributeError: 'NoneType' object has no attribute 'shape'

Hey there,
this is an error I usually get, if the datasets' folder structure is either not correct or if some of the images are missing/broken. In this case the opencv image loading function returns a None object, which has no attribute shape. Maybe you could double check, if the datasets are set up correctly?

Hey there,
this is an error I usually get, if the datasets' folder structure is either not correct or if some of the images are missing/broken. In this case the opencv image loading function returns a None object, which has no attribute shape. Maybe you could double check, if the datasets are set up correctly?

Thank you very much for your reply, I will check my data set according to your reply.

Hi @17853313621
I am facing the same issue like you. I am unable to find any broken images in the downloaded dataset so I am not sure what is causing the error. Were you able to solve the problem by downloading the data set again or did you do something else ?

This is because the json file is inconsistent with the folder file, and the image is missing.

Hello, I am creating an artificial intelligence algorithm and I encountered this error:

imageHeight, imageWidth = frame.shape[:2]
AttributeError: 'NoneType' object has no attribute 'shape'
can you Help Me What Should I do?


Personal Health Recommendations GUI

Personal Health Recommendations GUI
Iteration page: here
This screen will be composed of several fragments implemented using scroll panel (Horizontally).

done, made wrapper for the sites calculator


Fixed #26120 -- Made HStoreField cast keys & values to strings

The HStoreField will now convert all keys & values to string before
being saved to the database.

Does get_prep_value() also affect queries like HStoreModel.objects.filter(field__a=1)? Might be worth testing that.

@timgraham - thanks for the feedback. I've updated to use force_text, and removed the isinstance check.
The filter you mention seems to work just fine. I added a test anyway.

LGTM

@mjtamlyn @timgraham - I've updated the patch to also convert list elements to strings if a list is given to get_prep_value. This covers the case where you have a query like so:
HStoreModel.objects.get(field__has_keys=[2, 'a'])

Let me know if you have any further comments. Thanks for the feedback this far!

Looks like tests fail on Py3 now.

@mjtamlyn that's what I get for being lazy and not checking py3 myself first :/
Updated!

Should the behavior be documented in docs/ref/contrib/postgres/fields.txt?

@timgraham changed str to force_text. Will update the docs now.

I don't think we need to document the behaviour, it's equivalent to other fields.

merged in 8dea9f089dcb8aea2c417c91344c4e680431e972, thanks!


Fix a bug in in_syslog octet-counting mode

Which issue(s) this PR fixes:
Follow up https://github.com/fluent/fluentd/pull/2771
What this PR does / why we need it:
no need
Docs Changes:
no need
Release Note:
same as title.

No need to add test for \n?

No need to add test for \n?

I think so. For my understanding, this bug is off-by-one counting issue and is fixed in https://github.com/fluent/fluentd/pull/2942/commits/affd42ba34142de823aa677621b0f34c65559d63
So it's not related to \n.


Adding contributions-welcome badge to readme

Codecov Report

Merging #772 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #772   +/-   ##
=======================================
  Coverage   40.99%   40.99%
=======================================
  Files          29       29
  Lines        2747     2747
  Branches      432      432
=======================================
  Hits         1126     1126
  Misses       1542     1542
  Partials       79       79

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cc4970...6c49a99. Read the comment docs.

Isn't this redundant, considering the README has this information already?

@vishwakftw , yep sort of , but thought that something like could be more catchy.