mangle exported functions for PyPy

I run HEAD of PyO3 with HEAD of some PyPy branches, and noticed that the py3.10 branch (which implements python3.10) fails to properly build. The failure was a missing export:
 /home/runner/work/binary-testing/binary-testing/pyo3/src/exceptions.rs:715: \
    undefined reference to `PyExc_EncodingWarning'
          collect2: error: ld returned 1 exit status

So I grepped around in the code for Py_3_10 to see what new functions were added and found a few that needed PyPy-specific exports.

Could you add a news fragment as described in https://pyo3.rs/v0.18.1/contributing#documenting-changes? Thanks! (I did not trigger the CI as it will complain about the missing news fragment in any case.)
I also think it would be good to include this in #3028.

Probably we will release 3.10 in a month or so

bors r+

bors retry


Use flit tool in executor agent

PR summary
The flit tool now exists in the executor agent and can be removed from requirements-dev.txt.
GH actions requires it so install flit as a dependency in test.yml
PR Checklist
Please make sure that your PR fulfills the following requirements:

[ ] The commit message follows the
Angular Commit Message Guidelines.
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] New tests
[x] Build/CI related changes
[ ] Documentation content changes
[ ] Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

tbh I'd keep it as it is to allow local testing, otherwise we need to specify you need flit available globally or installed in venv explicitly regardless pip install

@eiri this is a good point.  Let's keep things as-is and close this.


Indicator 30: Network Data (if implemented) - Implementer test is no longer relevant / needs moving

In the DTQ there is an test for Implementer, which sits in the Project Attributes section
This may no longer be relevant to the planned Network Data indicator, so should be removed
If it is relevant, it should be moved to the Joining-up development data section of tests

@Lathrisk @michaelwood I can see this test is labelled correctly, but it still sits in the Project Attributes section, both in the DQT results screen and the csv download
Please can it be relocated to the Joining-up development data section?  Thanks


Fix issue when working with dyanmodb stream and complex types.

I think this was introduced in https://github.com/spulec/moto/pull/2605 (not a 100% sure thought).
I know this logic works properly in the v1.3.13 and it is busted in v1.3.14.
I have written a test to repo the issue, here is the relevant part of the call stack from the test failure.
File "/Users/asher/projects/moto/moto/dynamodb2/models.py", line 620, in add
  self.items.append(StreamRecord(self.table, t, event_name, old, new, seq))
File "/Users/asher/projects/moto/moto/dynamodb2/models.py", line 589, in __init__
  self.record["dynamodb"]["SizeBytes"] = len(json.dumps(self.record["dynamodb"]))
File "/usr/local/Cellar/python/3.7.4_1/Frameworks/Python.framework/Versions/3.7/lib/python3.7/json/__init__.py", line 231, in dumps
  return _default_encoder.encode(obj)
File "/usr/local/Cellar/python/3.7.4_1/Frameworks/Python.framework/Versions/3.7/lib/python3.7/json/encoder.py", line 199, in encode
  chunks = self.iterencode(o, _one_shot=True)
File "/usr/local/Cellar/python/3.7.4_1/Frameworks/Python.framework/Versions/3.7/lib/python3.7/json/encoder.py", line 257, in iterencode
  return _iterencode(o, 0)
File "/usr/local/Cellar/python/3.7.4_1/Frameworks/Python.framework/Versions/3.7/lib/python3.7/json/encoder.py", line 179, in default
  raise TypeError(f'Object of type {o.__class__.__name__} '
TypeError: Object of type DynamoType is not JSON serializable

Coverage decreased (-0.1%) to 93.921% when pulling c99bb642c631207964e91af69bdecc4e5a36d58a on asherf:dynanmodb into b8a1f85285fe28039da64005255e2c4488bc8764 on spulec:master.

@mikegrima @spulec friendly ping ;-)

Hi @asherf - you're probably right, that it was introduced by #2605. Thanks for providing a fix.
Would it make sense to add an assert to the test, checking that the stream item now has the correct size?
That probably makes the test more readable, as it's more clear what the original issue was.


New version: SBCL.SBCL version 2.2.1

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[ ] Have you tested your manifest locally with winget install --manifest <path>?
[X] Does your manifest conform to the 1.0 schema?

Microsoft Reviewers: Open in CodeFlow

@wingetbot waivers Add Policy-Test-1.8 Validation-Unapproved-URL


[HUDI-6887] Add test for Record Index and MIT queries

Change Logs
The jira creates test for RLI and MIT queries with checks for validating that data skipping is occurring.
Impact
NA
Risk level (write none, low medium or high below)
low
Documentation Update
NA
Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

This test failed: - Test MergeInto With Record Index and Data Skipping ***** FAILED *****

The test is failing in CI but passing locally. Added some debug logs.

hey @lokeshj1703 : can you summarize the cur state of this patch. and what are we waiting on.

The test added here is passing locally but failing in the CI. I have to debug and fix the CI failure.


zef: 0.21.0 -> 0.21.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/zef/versions.
meta.description for zef is: Raku / Perl6 Module Management
meta.homepage for zef is: https://github.com/ugexe/zef
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.21.1 with grep in /nix/store/i4s1h60agmm4iagd14j5ppqsm68gk7dv-zef-0.21.1
found 0.21.1 in filename of file in /nix/store/i4s1h60agmm4iagd14j5ppqsm68gk7dv-zef-0.21.1

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
zef

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/i4s1h60agmm4iagd14j5ppqsm68gk7dv-zef-0.21.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A zef https://github.com/r-ryantm/nixpkgs/archive/b18e4eaa2a541713ab8834304296d2547b657077.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/b18e4eaa2a541713ab8834304296d2547b657077#zef

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/i4s1h60agmm4iagd14j5ppqsm68gk7dv-zef-0.21.1
ls -la /nix/store/i4s1h60agmm4iagd14j5ppqsm68gk7dv-zef-0.21.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

zef

Maintainer pings
cc @stigtsp for testing.

Hey @drupol, notice that this PR also includes an additional unrelated commit https://github.com/NixOS/nixpkgs/pull/273322/commits/507902558c92350919981c1a33d1928dd11446bc
Although this is unlikely to break zef or cause any downstream issues, I think it would be nice with some additional context (i.e. is the finalAttrs pattern related to the makeBinaryWrapper change?) before it is self merged.

Hi @stigtsp,
Don't worry about these changes, they are for the greater good of the package and just like you said, this is unlikely to break the package which has been tested manually before committing those changes.
Basically:

I switched the derivation to using the finalAttrs pattern and remove the rec keyword.
I replace makeWrapper with the equivalent makeBinaryWrapper which offers a better compatibility on Darwin platforms
I added the missing phases hooks
Switched from sha256 to hash attribute
Removed the with lib;

If you prefer me to revert those changes (all at once), just let me know and I'll push the PR to revert them.

I'm not concerned about these code changes, they seem fine, and it's great that nixpkgs is receiving improvements and work like this.
But I'm a little bit uncomfortable on how they were applied:

An additional commit was added to an automated package bump without any mention in the PR title or description
The commit description was not accurate
It was self-merged a couple of hours after being pushed

Usually, I self-merge those very minor changes on minor package bump only that are awaiting being merged.
But OK, fair enough this could be improved definitely, and I will remember this for the next one.


failed to lookup address information: nodename nor servname provided, or not known

Describe the bug
A clear and concise description of what the bug is.
code:
use lettre::{AsyncTransport, Message, message::{header, MultiPart, SinglePart}};
use lettre::{transport::smtp::authentication::Credentials, AsyncSmtpTransport, Tokio1Executor};

let creds = Credentials::new("smtp_username", "smtp_password");
let mailer: AsyncSmtpTransport::<Tokio1Executor> = AsyncSmtpTransport::<Tokio1Executor>::builder_dangerous("smtp.qq.com")
            .port(587)
            .credentials(creds)
            .build();

let email = Message::builder()
    .from("xxxx@xxxx.com".parse().unwrap())
    .reply_to("xxxx@xxxx.com".parse().unwrap())
    .to("xxxx@xxxx.com".parse().unwrap())
    .subject("test mail")
    .body(String::from("test rust mailer"))
    .unwrap();

    match mailer.send(email).await {
        Ok(_) => println!("Email sent successfully!"),
        Err(e) => panic!("Could not send email: {:?}", e),
    }

cargo run , panick error message:
thread 'actix-rt|system:0|arbiter:1' panicked at 'Could not send email: Io(Custom { kind: Other, error: "failed to lookup address information: nodename nor servname provided, or not known" })'

Environment (please complete the following information):

Lettre version： lettre = { version = "0.10.0-beta.2", features = ["smtp-transport", "tokio1-rustls-tls", "builder"]}
OS ：Mac OS X 10.15.6
actix-web = { version = "4.0.0-beta.3", features = ["rustls"] }

Additional context
Add any other context about the problem here.
mail server can telnet success
 telnet smtp.qq.com 587
Trying <IP_ADDRESS>...
Connected to smtp.qq.com.
Escape character is '^]'.
220 newxmesmtplogicsvrszc9.qq.com XMail Esmtp QQ Mail Server.

502 Invalid input from <IP_ADDRESS> to newxmesmtplogicsvrszc9.qq.com

I can't reproduce the issue. I tried this both using my connection and on a VPS here in the EU and it seems to be connecting correctly to smtp.qq.com.
The error seems to indicate a DNS resolution failure, so unless something weird is going on retrying the request should fix the issue.

this issue has been resolved.
my toml config:
[email]
server = "smtp.qq.com"
port = 587
smtp_username = ""
smtp_password = ""

and my code :
let config:Toml = toml::from_str(&file_content).unwrap();

then, toml to json ,  "smtp.qq.com"  turned to ""smtp.qq.com""
thanks for your help .


Connection closed while reading from the driver

Anyone meets the problem?

Traceback` (most recent call last):
File "D:\python\lib\idlelib\run.py", line 559, in runcode
exec(code, self.locals)
File "<pyshell#2>", line 1, in
File "D:\python\lib\site-packages\deepl\deepl.py", line 85, in translate
return loop.run_until_complete(self.__translate(script))
File "D:\python\lib\asyncio\base_events.py", line 616, in run_until_complete
return future.result()
File "D:\python\lib\site-packages\playwright_impl_connection.py", line 263, in init
self.playwright_future.set_result(await self._root_object.initialize())
File "D:\python\lib\site-packages\playwright_impl_connection.py", line 206, in initialize
await self._channel.send(
File "D:\python\lib\site-packages\playwright_impl_connection.py", line 61, in send
return await self._connection.wrap_api_call(
File "D:\python\lib\site-packages\playwright_impl_connection.py", line 461, in wrap_api_call
return await cb()
File "D:\python\lib\site-packages\playwright_impl_connection.py", line 96, in inner_send
result = next(iter(done)).result()
File "D:\python\lib\site-packages\deepl\deepl.py", line 94, in __translate
async with async_playwright() as p:
File "D:\python\lib\site-packages\playwright\async_api_context_manager.py", line 46, in aenter
playwright = AsyncPlaywright(next(iter(done)).result())
Exception: Connection closed while reading from the driver

Yeah, the repo doesn't work any more.

@pH-Lis Cannot reproduce this. I'll reopen this if you provide MRE for this issue.


Can't download Canary Version

Windows Terminal version
WT1.23+
Windows build number
No response
Other Software
No response
Steps to reproduce
I try downloading https://aka.ms/terminal-canary-zip-x64
it's redirect to
https://terminalbuilds-grbmacf3f6bsbma8.z01.azurefd.net/nightly/Microsoft.WindowsTerminalCanary_latest_x64.zip
Expected Behavior
successfull downloading...
Actual Behavior
return XML:

PublicAccessNotPermitted

Public access is not permitted on this storage account. RequestId:954898a1-e01e-00a8-65fd-1f445f000000 Time:2024-10-16T18:59:19.6383023Z

I try VPN to another country, and the same problem.

We were transitioning our infrastructure, which led to a momentary outage. It once again works:

(This is the appinstaller XML file. The ZIP is likewise fixed.)


Code works on codesandbox, but not on my machine

Hi,
I am creating different examples to explore local state management with apollo. Recently, I am running into an issue where similar code work in one repo but fails in another repo.
I created a codesandbox to demostrate this issue.
Code works in this codesandbox.
https://codesandbox.io/s/v00rnlkr20
Button toggles between login and logout when we click on it.
But if I download the codesandbox code and run it on my machine, it fails with error

To make sure, it is not a problem with my machine, I requested my colleague to download code and run it on his machine. It doesn't work on his machine also, but it works on codesandbox.

Error is happening because of this line https://github.com/apollographql/apollo-link-state/blob/master/packages/apollo-link-state/src/index.ts#L76
resolverMap is undefined.
so error is thrown because of resolverMap[fieldName] access

Upgrading to the latest versions of apollo-cache-inmemory and apollo-link-state should now fix this issue! Thank you all for your patience 😀


chore(main): release sandworm-utils 1.10.4

:robot: I have created a release beep boop
1.10.4 (2023-01-10)
Bug Fixes

crash when post-processing empty graphs (94d35dd)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/sandworm-hq/sandworm-utils/releases/tag/sandworm-utils-v1.10.4 :sunflower:


Fix Lodash Imports

The lodash package takes up a decent amount of space, as we're not importing it correctly. We should try and clean these up so that we're only importing what we need.

Resolved in build 106.


Add support for BigQuery ANY TYPE data type

As referenced in #1601 , here is a PR, with a test, that verifies correct parsing of BigQuery User-defined functions using templated SQL parameters (what a mouthful :D).
More docs on the actual feature/functionality in BQ can be found here: https://cloud.google.com/bigquery/docs/user-defined-functions
Thanks in advance for the consideration!

Thanks @MartinSahlen! The changes look reasonable to me, left a couple minor comments

Thanks for the review and suggestions! I have now added the suggested changes and improvements, along with two seperate tests

test that the usage of "ANY TYPE" works in a function definition for BigQuery
test that the usage of the "ANY" type still works as a standalone type to support arbitrary or user-defined types without being restrictive. This also makes a lot of sense as the goal of this codebase is not to provide an opinionated or semantic validating parser.

LGTM! Thanks @MartinSahlen! cc @alamb

Thanks!


fix: map authentication errors to a custom error type

Fixes #565
Errors encountered during authenticate() are mapped to a custom error type with an ErrorKind enum (BadCredentials, PremiumAccountRequired, Io (wraps io errors) and Msg (generated, used as a default kind to keep unmapped errors readable)) instead of panicking.
I am not sure how backward compatibility is usually handled here however! I was thinking about adding this error mapping to a new Session::try_connect (not sure about the naming) function, while keeping the same behavior for Session::connect

If there are no complaints/suggestions, I'll merge this.

I guess ash is quite busy?
By the way I noticed you added a "breaking" label, but I had worked around breaking the api by introducing a new method, should I revert this and just update the existing method signature?

Sorry, yep LGTM!
I'd forgo the deprecation, and just update the function signature. We are anyway breaking a few other things, might as well do it all at once.

No worries, thank you for the review :) I removed the duplicated method!

I guess ash is quite busy?
By the way I noticed you added a "breaking" label, but I had worked around breaking the api by introducing a new method, should I revert this and just update the existing method signature?

As ash said, break it. Next version will be 0.2.0, probably followed by a couple of patches, then probably 0.3.0 once the tokio migration has completed along with a couple of other things.

All good then, I force pushed my branch and removed the backward compatible method!


Cleaned up some linting and removed a lingering <<<HEAD from the index.html

thanks for cleaning this up!


Drag and inertia

Hi!
First I want to congrats you guys for this wonderful library!
I'm implementing a drag interaction that require to continue after that the user end the drag: aka inertia. After looking the documentation it seems the library manage already the velocity but did not allow to continue the mouvement after the user release the draggable element.
Did you have any plan to implement something to handle it?

Hi @Spy-Seth thanks for the kind words.
I think it should rather be part of react-spring rather than react-use-gesture. I made a sandbox a few weeks ago trying to replicate inertia. You can find it right there:
https://codesandbox.io/s/inertia-fake-scroll-wjz5s
It also supports wheel, but it's not perfect on that aspect. Let me know if this helps!

Ho I didn't know the useGesture callback could be trigger after that the movement end. And I'm not sure to understand yet why it get trigger again 😅

https://codesandbox.io/s/inertia-fake-scroll-wjz5s

This example is perfect thanks! 😄

I think it should rather be part of react-spring rather than react-use-gesture.

The inertia concept is really link to user movement and it could be also natural to have helper to manage it in this package

Ho I didn't know the useGesture callback could be trigger after that the movement end. And I'm not sure to understand yet why it get trigger again

Not sure what you mean there sorry, can you elaborate?

The inertia concept is really link to user movement and it could be also natural to have helper to manage it in this package.

Valid point, but again, react-use-gesture only gives you the initial velocity and direction of the movement. What you do with it, how you animate your component depending on these two variables is up to the user and the animation library. React-use-gesture will never animate anything: it only gives you data about events.


stream.pipe is not a function

Getting a stream.pipe is not a function error when trying to upload files. I'm working on a master branch copy of the source.
Has anyone encountered the same issue?

Hey @alvin-reyes. It's working here. Which is your browser?

I'm using Firefox

Can't reproduce it either. Are you sure you're using the latest version from this repo?

Yes I am. Did you try uploading a file?

I did and it just uploaded without any issues


scrubbing of dedupe VDISK (means check disks are ok & remove old data)

dedupe VDISK needs the consumer references implemented
each VDISK os a consumer of the deduped storage pool.
there are reference lists (upto 10) which tells who is using a block.
this needs to be implemented so delete can happen
while scrubbing check that all required blocks are on the system (good for testing too)

dedupe VDISK needs the consumer references implemented

Keeping a reference list for a block is going to be very expensive. Even keeping a simple counter per block was already expensive. I think I might have found a way to do it in a deferred way, to perhaps limit how expensive it is. Also simply storing a reference wouldn't work, as a vdisk might reference the same deduped block twice or more, so you would also need a counter per reference, at which case you might as well only reference count it in the first place.

while scrubbing check that all required blocks are on the system (good for testing too)

This makes scrubbing really expensive, and will slow down the storage cluster by a lot while the scrubbing is happening. It will also take a while, so I guess you will do this only when there are no or barely any vdisks active which use that storage cluster?

scrubbing check

Is this something you want to be running in the background as a daemon, every interval. Or would this just be another command to be added to the zeroctl tool suite? Well I guess even a command could be ran as a deamon, so perhaps this question is not really an important one.

I don't think this should be done now.  First #88 and #147 should be solved.
Also the reference counting has not been re-introduce at all so this issue is just not doable at the moment.

Fairly sure this issue is related to those issues you linked though @zaibon. As @rkhamis is proposing features of the design in this issue.
This issue states that no matter the design it does need to have a consumer list. Which definitely influences both the issues you linked, in case we have to take that into account.


Changing function name for failure report

./tests_smoke/smoke.sh: line 30: _smoke_print_fail: command not found
To recreate:
Specify a file that doesn't exist using smoke_form_ok

👍


A README.rst fix + Python 2 compatibility

Tested with Python 2.7.9.

Would love a new release on PyPI if you pull these in. It's advertised as Python 2 compatible there after all :)

Thanks! I'll make a new release on pypi soon!

@estan The new version (0.4.2) is available on pypi

:thumbsup:


fix verbose error message in generate cli

When use ks generate
$ ks generate --help
...
Global Flags:
  -v, --verbose count[=-1]   Increase verbosity. May be given multiple times.

if use ks generate with --verbose(or -v), we meet error msg
$ ks generate deployed-service guestbook-ui   \
--image gcr.io/heptio-images/ks-guestbook-demo:0.1  \
--type ClusterIP \
--verbose=-1

unknown flag: --verbose
Usage of prototype-flags:
--containerPort string   Container port for service to target. (default "80")
--image string           Container image to deploy
--module string          Component module
--name string            Name of the service and deployment resources
--replicas string        Number of replicas (default "1")
--servicePort string     Port for the service to expose. (default "80")
--type string            Type of service to expose (default "ClusterIP")
--values-file string     Prototype values file (file returns a Jsonnet object)
ERROR parse preview args: unknown flag: --verbose

Actually, present ks generate command doesn't send any debug msg, however verbose flag is gobal option, then we could use it in any command.
then, I added verbose to prototype-flags.

Pull Request Test Coverage Report for Build 1232

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.002%) to 71.199%

Totals

Change from base Build 1229:
0.002%

Covered Lines:
11940

Relevant Lines:
16770

💛  - Coveralls


fix leveldb mount bug

index--->leveldb
operation:
unmount volume(vid=3)
mount volume(vid=3)
error:
I0502 16:02:19 03815 disk_location.go:59] new volume 3.dat error resource temporarily unavailable
fix:
add l.volumes[vid].close() in file storage/disk_location.go line 171 before delete(l.volumes, vid);

thanks!

use leveldb index. but after loading leveldb database, you use Btree statistics zhe deleted file size，wo don't think this is a good way.
when I loading 100 million index，Btree will use 3.6G memory，and GC don't work well。
but in my filesystem, don't care the deleted file size, so I ingore the Btree Code.
I know the deleted file size will influences Compact.

Not very clear about what you mean. Maybe let me see what you have changed in code.

func doLoading(file *os.File, nm NeedleMap, flag bool) (NeedleMap, error) {
e := WalkIndexFile(file, func(key uint64, offset, size uint32) error {
if key > nm.MaximumFileKey {
nm.MaximumFileKey = key
}
if offset > 0 && size != TombstoneFileSize {
nm.FileCounter++
nm.FileByteCounter = nm.FileByteCounter + uint64(size)
if flag {
oldOffset, oldSize := nm.m.Set(needle.Key(key), offset, size)
glog.V(3).Infoln("reading key", key, "offset", offsetNeedlePaddingSize, "size", size, "oldSize", oldSize)
if oldOffset > 0 && oldSize != TombstoneFileSize {
nm.DeletionCounter++
nm.DeletionByteCounter = nm.DeletionByteCounter + uint64(oldSize)
}
}
} else {
oldSize := nm.m.Delete(needle.Key(key))
glog.V(3).Infoln("removing key", key, "offset", offsetNeedlePaddingSize, "size", size, "oldSize", oldSize)
nm.DeletionCounter++
nm.DeletionByteCounter = nm.DeletionByteCounter + uint64(oldSize)
}
return nil
})
glog.V(1).Infof("max file key: %d for file: %s", nm.MaximumFileKey, file.Name())
return nm, e
}
add parameter flag in function doLoading，if index--->leveldb/boltdb，flag--->flase；other, flag-->true

right. using the wrong needle mapper. Please see this fix. not tested yet. please help to double check.
https://github.com/chrislusf/seaweedfs/commit/e2c7be3a2e91056a6402fc70a979aa273c15fcd2

right. need a way to do metrics better.


Implementing TTL for packets / topics - ways to go about

As I understand there is no TTL for packets and topics
meaning that outgoing packets or subscribed topics will be left
for ever in the persistence layer if they are not delivered or unsubscribed
as such. (same goes for topics)
I wish to create a management layer for the persistency layer (or above it),
according to my defined rules, so that this layer is not
part of the broker and can run in a different node process.
(most of the Erlang MQTT brokers have something of that mechanism,
in form of special actors designed for management)
my first thought on the matter is to actually add timestamp
to the packets and subscriptions, then go deeper down the rabbit hole.
I've been evaluating a few brokers (including Mosca / EMQ and VerneMQ)
and found that no broker was ever
consistent with one another, in terms of dealing with subscriptions
and retained messages.
Aedes being barebone can fit well in a larger IOT Eco-system
without dragging you down to work around poorly engineered or poorly tested
products (with too many assumptions about the usage),
and lets you design your own flow and behavior.
Would appreciate any relevant guidelines that come to mind,
if any.. )

You may want to have a look at the upcomig MQTT Version 5 specification
with regards to their definition of

Session Expiry Interval
Publication Expiry Interval

@syberkitten You can also check current packet TTL implementation in redis persistence


latest fast track, wsl 2 ubuntu app crashing. Working in powershell

Please fill out the below information:

Your Windows build number:  (Type ver at a Windows Command Prompt)

# cmd
C:\WINDOWS\system32>ver

Microsoft Windows [Version 10.0.18985.1]

# powershell
PS C:\WINDOWS\system32> [System.Environment]::OSVersion.Version

Major  Minor  Build  Revision
-----  -----  -----  --------
10     0      18985  0

In the lower right corner of the screen, it reads Windows 10 Pro; build 18985.vb_release.190913-1426
I just recently installed windows updates last night and this began happening this morning.

What you're doing and what's happening:  (Copy&paste the full set of specific command-line steps necessary to reproduce the behavior, and their output. Include screen shots if that helps demonstrate the problem.)

Opening wsl2 from powershell is working. I.e. all of the following commands, when run from powershell, running as admin, are working: wsl, ubuntu, bash.
However, running the Ubuntu app is crashing. Please see the attached image.

What's wrong / what should be happening instead:

I expect ubuntu app to work.

Strace of the failing command, if applicable:  (If some_command is failing, then run strace -o some_command.strace -f some_command some_args, and link the contents of some_command.strace in a gist here).

How to run command? I can't find the exe?

For WSL launch issues, please collect detailed logs.

Attached.
lxcore_kernel.zip
See our contributing instructions for assistance.

Scratch that, I found it in C:\Users\ahann\AppData\Local\Microsoft\WindowsApps\ubuntu.exe
Running directly from there is working.

This is still a problem in the sense that a regular Ubuntu terminal crashes, so this issue should probably be re-opened

Ok, I'm now having worse issues. WSL hangs no matter how I open it. I was using it this morning to work on a few software projects. I shut the computer down (it didn't update to my knowledge). I turned the computer back on tonight and it's not working.
When running wsl, ubuntu or bash it just hangs (from powershell). There's no output and I can't even ctrl+c to stop.
Attached are the logs.

aaaannnnndddddddd...... three restarts later and its working. Not one, not two, three was the magic number. :)
[somewhat] relevant xkcd


Hosting on WC

Website currently done with Wordpress.
Redirect to Heroku to begin with.
Shaun to set up subdomain.
Switch over to WC's digital ocean account.

Integration with existing WC site is not on the agenda for the second sprint


[QUARKS-223] Junit parity

I'm working on but little more testing needed
I did not want to call the ant.jar in gradle but was unable to add the file to the META-INF/service. Please teach me if anyone has a good idea.
I modified ServerUtil.java to avoid error when there are 2 or more console.war(in webapp directory) but does not looks good. I think this remainning in a temporarily until @dlaboss 's work

I checked it works in Linux/OSX include all junit testcase


Implementing event listener callbacks for click, hover, etc ...

I would like to use pintora in my angular app but need to be able to catch a click event as the user selects a different element of a graph to be edited dynamically
Is that part of the plans? I have seen any code related to this in the source tree
Thanks

@pdemilly  I havn't thought about it but I think it is worth a try.
Could you exapnd this with more details ?

What would you expect in the event payload ?
What do you mean to be edited dynamically ?
Will this require adding new grammar to the DSL ?

For example in mermaid there is the ability to define click event when using Security level loose. see mermaid doc
function clicked(id) {
  console.log(`id ${id} has been clicked`);
}

graph TD
    A-->B
    click A clicked "click A"
    click B alert "click B"

To answer your questions the event payload could be the node and the mouse event. What I mean by edited dynamically is to build the chart dynamically. For example clicking on a node, could pop up a drop down menu with the choice of adding a new node. It could require a change in grammar like in mermaid or could be a configuration option during initialization of the chart (probably preferable)

I see, very good advice. I should take this to the roadmap. Will take a look at it this weekend.
The event payload will include some meaningful entity, like an actor in the sequenceDiagram, or an entity in the erDiagram.
But since the event is captured in the renderer level, I need to come up with a solution to link it back to the DiagramIR level.
Not all visual elements can be easily traced back to a meaningful logic entity, say you click an arrow, it takes some work to track back to know that it belongs to an edge between two nodes.

I've opened a draft PR for this feature.
You can goto

vercel preview page to see the docs
live editor demo page and open the devtools console, click the 'DELIVERY' entity and see the event payload data.

Currently only er diagram will emit DiagramEvent

This is released in v0.5.2, only er and sequence diagram will emit DiagramEvent.


Add a request profile component

Goals

Being able to trace a request profile (response time, from where, extra metadata...) (array)
Being able to store these request profiles

Google Cloud Datastore
Elastic Search

Merged in #31.


clh: Set the BDF info of hotplugged blk devices as the drive PCIAddr

This patch sets the 'drive.PCIAddr' with the BDF info when hotplugging
block devices, and also sets the 'drive.Virtpath' as 'nil'
explicitly. In this way, the kata-agent will no longer rely on the
predicted  device path in the guest to locate the block device and
volumes, instead it will rely on the PCI BDF of the hotplugged block
device.
Depends-on: github.com/kata-containers/agent#824
Fixes: #2908
Signed-off-by: Bo Chen<EMAIL_ADDRESS>

/test-clh

/test-vfio

/test-clh

/test-vfio

/test-clh-k8s-containerd

/test-clh-k8s-containerd

@devimc Thanks for starting the VFIO CI jobs. I haven't been running them for a while. Great catch.
I noticed the actual VFIO tests are working fine in the CI, but the CI is failing during the teardown stage with the following error (full log is here ). Can you please take a look?
13:28:17 ++ sudo -E PATH=/home/jenkins/workspace/workspace/kata-containers-runtime-vfio-PR/go/bin:/usr/local/go/bin:/usr/sbin:/usr/local/bin:/usr/bin:/usr/local/sbin:/usr/sbin .ci/teardown.sh /home/jenkins/workspace/workspace/kata-containers-runtime-vfio-PR/artifacts
13:28:18 ~/workspace/workspace/kata-containers-runtime-vfio-PR/artifacts ~/workspace/workspace/kata-containers-runtime-vfio-PR/go/src/github.com/kata-containers/tests
13:28:18 gzip: /home/jenkins/workspace/workspace/kata-containers-runtime-vfio-PR/artifacts/procenv-root.log: No such file or directory
13:28:18 find: ‘/home/jenkins/workspace/workspace/kata-containers-runtime-vfio-PR/go/src/github.com/kata-containers/tests/metrics/results/’: No such file or directory
13:28:18 find: ‘/home/jenkins/workspace/workspace/kata-containers-runtime-vfio-PR/go/src/github.com/kata-containers/tests/metrics/results//new’: No such file or directory
13:28:18 find: ‘/home/jenkins/workspace/workspace/kata-containers-runtime-vfio-PR/go/src/github.com/kata-containers/tests/metrics/report/output/’: No such file or directory
13:28:18 ~/workspace/workspace/kata-containers-runtime-vfio-PR/go/src/github.com/kata-containers/tests
13:28:18 INFO: Checking log files
13:28:18 INFO: adding '\[Serial Test\]' to 'SKIP_GINKGO_PARALLEL'
13:28:18 INFO: adding '\[Serial Test\]' to 'FOCUS_GINKGO_SERIAL'
13:28:18 make -C cmd/log-parser
13:28:18 make[1]: Entering directory '/home/jenkins/workspace/workspace/kata-containers-runtime-vfio-PR/go/src/github.com/kata-containers/tests/cmd/log-parser'
13:28:18 go test .
13:28:20 ok  	github.com/kata-containers/tests/cmd/log-parser	0.010s
13:28:20 go build -o "kata-log-parser" -ldflags "-X main.name=kata-log-parser -X main.commit="1658f756ea28f0a9c420d23010d73510a4432846" -X main.version=0.0.1" .
13:28:21 install -d /home/jenkins/workspace/workspace/kata-containers-runtime-vfio-PR/go/bin
13:28:21 install kata-log-parser /home/jenkins/workspace/workspace/kata-containers-runtime-vfio-PR/go/bin/kata-log-parser
13:28:21 make[1]: Leaving directory '/home/jenkins/workspace/workspace/kata-containers-runtime-vfio-PR/go/src/github.com/kata-containers/tests/cmd/log-parser'
13:28:21 time="2020-08-28T20:28:21.27980199Z" level=debug msg="ignoring empty file \"/home/jenkins/workspace/workspace/kata-containers-runtime-vfio-PR/go/src/github.com/kata-containers/tests/kata-ksm-throttler.log\"\n" commit=1658f756ea28f0a9c420d23010d73510a4432846 name=kata-log-parser pid=30414 source=log-parser version=0.0.1
13:28:21 time="2020-08-28T20:28:21.279891276Z" level=debug msg="ignoring empty file \"/home/jenkins/workspace/workspace/kata-containers-runtime-vfio-PR/go/src/github.com/kata-containers/tests/kata.log\"\n" commit=1658f756ea28f0a9c420d23010d73510a4432846 name=kata-log-parser pid=30414 source=log-parser version=0.0.1
13:28:21 time="2020-08-28T20:28:21.279914772Z" level=debug msg="ignoring empty file \"/home/jenkins/workspace/workspace/kata-containers-runtime-vfio-PR/go/src/github.com/kata-containers/tests/kata-proxy.log\"\n" commit=1658f756ea28f0a9c420d23010d73510a4432846 name=kata-log-parser pid=30414 source=log-parser version=0.0.1
13:28:21 time="2020-08-28T20:28:21.279966753Z" level=debug msg="ignoring empty file \"/home/jenkins/workspace/workspace/kata-containers-runtime-vfio-PR/go/src/github.com/kata-containers/tests/kata-vc-throttler.log\"\n" commit=1658f756ea28f0a9c420d23010d73510a4432846 name=kata-log-parser pid=30414 source=log-parser version=0.0.1
13:28:21 ERROR: kata-log-parser: missing pid: {Count:0 TimeDelta:0 Filename:/home/jenkins/workspace/workspace/kata-containers-runtime-vfio-PR/go/src/github.com/kata-containers/tests/kata-runtime.log Line:1783 Time:2020-08-28 20:27:45.942278498 +0000 UTC Pid:0 Level:warning Msg:no such file or directory: /run/kata-containers/shared/sandboxes/vfiotest/mounts/vfiotest/rootfs Source: Name: Container: Sandbox: Data:map[]}
13:28:21 ++ handle_error 290
13:28:21 ++ local exit_code=1
13:28:21 ++ local line_number=290
13:28:21 ++ echo 'Failed at 290: ssh -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no -o IdentitiesOnly=yes -i "${ssh_key_file}" -p "${vm_port}" "${USER}@${vm_ip}" "${cmd}"'
13:28:21 Failed at 290: ssh -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no -o IdentitiesOnly=yes -i "${ssh_key_file}" -p "${vm_port}" "${USER}@${vm_ip}" "${cmd}"
13:28:21 ++ exit 1

@likebreath - it looks like the teardown is complaining due to finding an invalid runtime log entry. However, fwics the vfio CI isn't saving the build artifacts (including runtime.log), so I cannot confirm this :cry:)
@GabyCT - could you see if we need to tweak the CI settings to save artifacts for VFIO CI builds?

/test-vfio

@jodh-intel  @likebreath  VFIO CI is happy now :smile:

\o/ ;)

@likebreath - travis is failing due to the length of the subject line:
ERROR: Commit 376e2a0441ea97cf8924813248e8f659fbc9adad: subject too long (max 75, got 78): "kata_agent: Revert: \"Allow to use \"VirtPath\" as volume source for blk devices\""

How about something like:

revert: agent: Allow to use "VirtPath" as volume source for blk devices

travis is failing due to the length of the subject line:
ERROR: Commit 376e2a0441ea97cf8924813248e8f659fbc9adad: subject too long (max 75, got 78): "kata_agent: Revert: \"Allow to use \"VirtPath\" as volume source for blk devices\""

How about something like:

revert: agent: Allow to use "VirtPath" as volume source for blk devices

@jodh-intel Right. Thanks for catching that. I had a similar fix on my local commit.  ;)
Thanks for @devimc. Now as the VFIO CI is passing, I will update the PR and make sure it is ready for review/merging.

FC31 podman CI failure:
20:39:43 Error: Unable to find a match: crun-0.14.1-1.fc31.x86_64

/test-clh
/test-vfio
/test-ubuntu

/test

Rerunning failing CIs.

@likebreath I have rerun some of the CI jobs that were failing including metrics CI. Feel free to merge if those jobs pass.

As @dgibson pointed out, the proposed approach here (accepting new format in B/D/F) is not the right way to extend runtime/agent protocol. Let's follow up on the discussions in https://github.com/kata-containers/agent/issues/823. Closing the PR now.


i18n, redesign, admin panel

This pull request includes several key features to improve user experience and add more features.
Features:

Internationalization (i18n)
User management with a more populated table
Beatmap management (currently requires the user to have an API key, but we are open to better ideas)
Score uploads (pending merge of https://github.com/osuAkatsuki/bancho.py/pull/281) removed from codebase

Visual changes:

Removing the admin side panel in favor of a top bar
subtle animations
language switcher

Fixes:

Fixing a dangerous API key injection:

<script>
    window.api_key = {{ session.user_data['api_key'] | JSON }} // it was really scary!
</script>

i18n
requires node during development, we recommend using vscode for developing translation for better tooling, you will be prompted to install recommended plugins when you open the repository for the first time.
we will update the readme later to include the tutorial on managing translations.
steps

make sure you have node and yarn installed.
run yarn
create config.js from config.sample.js
run yarn i18n:build
you are good to go.

Sorry for creating a pull request this large 👩🦼

dude WHATTTTTTTTTTTTTT

afaik guweb 2.0 is already being worked on tho
Also I think it would make more sense to upgrade guweb to api v2 if you're already doing api stuff, api v1 is deprecated and that's why /submit_score won't be merged

you might wanna delete this folder?

I also see stuff like this that should not be defaulted to chinese I guess

tbh I think this PR is too big to get merged as a whole, you should trim stuff down, like redesigning stuff, making QOL changes, implementing yarn etc.

give this man some TRUE

tbh I think this PR is too big to get merged as a whole, you should trim stuff down, like redesigning stuff, making QOL changes, implementing yarn etc.

I should check the 'draft' when I created this pr.
we made these changes through out the months, simultaneously, so it's really hard to separate one changes with another.
Let's focus on addressing any problems inside the code we should fix. Then we could try to create separate pull requests in order to merge them.

you might wanna delete this folder?

I think it's better to have translations for any private server that willing to contribute leaving their translations in the repository . you'll never know when it's needed.

I also see stuff like this that should not be defaulted to chinese I guess

you are right, will change this

you might wanna delete this folder?

I think it's better to have translations for any private server that willing to contribute leaving their translations in the repository . you'll never know when it's needed.

I don't really understand what the folder is for, maybe give it a more clarifying name

you might wanna delete this folder?

I think it's better to have translations for any private server that willing to contribute leaving their translations in the repository . you'll never know when it's needed.

I don't really understand what the folder is for, maybe give it a more clarifying name

it's our translation on top of the default translation. Do you have any suggestions on what we should rename it?

you might wanna delete this folder?

I think it's better to have translations for any private server that willing to contribute leaving their translations in the repository . you'll never know when it's needed.

I don't really understand what the folder is for, maybe give it a more clarifying name

it's our translation on top of the default translation. Do you have any suggestions on what we should rename it?

Oh I see, so if you modify the frontend and add your own texts you put them in there?

I think it's better to have translations for any private server that willing to contribute leaving their translations in the repository . you'll never know when it's needed.

I don't really understand what the folder is for, maybe give it a more clarifying name

it's our translation on top of the default translation. Do you have any suggestions on what we should rename it?

Oh I see, so if you modify the frontend and add your own texts you put them in there? Why not edit the normal files instead?

so that we all private server enjoyers could share our translation, rather than copy pasting them

you might wanna delete this folder?

I think it's better to have translations for any private server that willing to contribute leaving their translations in the repository . you'll never know when it's needed.

I don't really understand what the folder is for, maybe give it a more clarifying name

it's our translation on top of the default translation. Do you have any suggestions on what we should rename it?

Oh I see, so if you modify the frontend and add your own texts you put them in there? Why not edit the normal files instead?

so that we all private server enjoyers could share our translation, rather than copy pasting them

I don't quite get what you mean. If you need to change the translation of something, you can do so in the normal language files. I feel like it's too hard to understand what your mission with that extra stuff is, users might just ignore it

you might wanna delete this folder?

I think it's better to have translations for any private server that willing to contribute leaving their translations in the repository . you'll never know when it's needed.

I don't really understand what the folder is for, maybe give it a more clarifying name

it's our translation on top of the default translation. Do you have any suggestions on what we should rename it?

Oh I see, so if you modify the frontend and add your own texts you put them in there? Why not edit the normal files instead?

so that we all private server enjoyers could share our translation, rather than copy pasting them

I don't quite get what you mean. If you need to change the translation of something, you can do so in the normal language files. I feel like it's too hard to understand what your mission with that extra stuff is, users might just ignore it

it's like your system's language setting (language packs), you can have more than one and you order them the way you like.

Leave this poor folder alone, it's just need to be renamed

You can keep the upload score stuff in, it's just that the endpoint will only be implemented in api v2

I think we accidentally formatted the whole repo in double quotes. what formatter are you using to enforce quotes? I found no formatter with configurable quotes

You can keep the upload score stuff in, it's just that the endpoint will only be implemented in api v2

y don't worry we have it in other branch. I am planning to get this merged before v2 landed so that both of us won't have to adapt it separately before merging ✌

You can keep the upload score stuff in, it's just that the endpoint will only be implemented in api v2

y don't worry we have it in other branch. I am planning to get this merged before v2 landed so that both of us won't have to adapt it separately before merging ✌

API V2 is already partly done, also I don't think this will be merged anytime soon, yet before API v2 is done

Hi, I fixed most problems you mentioned


[Antrea-IPAM] Support pre-allocating continuous IPs for StatefulSet

In order to provide better user experience, AtreamIPAM will try to
preallocate continuous IP range for StatefulSet. If unsuccesful,
IPs for the StatfulSet will be allocated on the fly, as before.
Signed-off-by: Anna Khmelnitsky<EMAIL_ADDRESS>

Codecov Report

Merging #3281 (a3edd4c) into main (12f20a7) will increase coverage by 0.49%.
The diff coverage is 54.68%.

@@            Coverage Diff             @@
##             main    #3281      +/-   ##
==========================================
+ Coverage   41.37%   41.86%   +0.49%
==========================================
  Files         199      199
  Lines       24099    24156      +57
==========================================
+ Hits         9971    10114     +143
+ Misses      13096    13005      -91
- Partials     1032     1037       +5

Flag
Coverage Δ

unit-tests
41.86% <54.68%> (+0.49%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/ipam/poolallocator/allocator.go
51.52% <0.00%> (+1.52%)
:arrow_up:

pkg/controller/ipam/antrea_ipam_controller.go
68.90% <56.45%> (-11.38%)
:arrow_down:

pkg/apiserver/certificate/certificate.go
69.44% <0.00%> (-6.95%)
:arrow_down:

pkg/apiserver/storage/ram/store.go
76.86% <0.00%> (-1.50%)
:arrow_down:

...gent/controller/noderoute/node_route_controller.go
43.71% <0.00%> (-1.10%)
:arrow_down:

pkg/agent/nodeportlocal/k8s/npl_controller.go
0.00% <0.00%> (ø)

pkg/agent/openflow/pipeline.go
21.01% <0.00%> (+0.06%)
:arrow_up:

pkg/controller/traceflow/controller.go
67.72% <0.00%> (+1.05%)
:arrow_up:

pkg/controller/networkpolicy/validate.go
34.27% <0.00%> (+34.27%)
:arrow_up:

/test-all

/test-integration
/test-flexible-ipam-e2e

Would appreciate feedback - we need to distinguish between IPAddressPhaseReserved and v1alpha2.IPAddressPhasePreallocated, or is it better to combine them?

Would appreciate feedback - we need to distinguish between IPAddressPhaseReserved and v1alpha2.IPAddressPhasePreallocated, or is it better to combine them?

@annakhm Please use IPAddressPhaseReserved, and IPAddressPhasePreallocated is deprecated.

/test-all

/test-ipv6-all
/test-ipv6-only-all
/test-integration
/test-flexible-ipam-e2e
/test-multicluster-e2e

/test-windows-all

/test-windows-networkpolicy

/test-all

/test-all

/test-flexible-ipam-e2e
/test-multicluster-e2e
/test-windows-all
/test-ipv6-all

/test-all-features-conformance

/test-all

/test-integration

/test-flexible-ipam-e2e

/test-flexible-ipam-e2e
/test-ipv6-e2e
/test-windows-networkpolicy

/test-all

/test-flexible-ipam-e2e

/test-flexible-ipam-e2e

/test-ipv6-all
/test-ipv6-only-all
/test-windows-all
/test-multicluster-e2e

/test-ipv6-only-e2e
/test-multicluster-e2e

/test-all
/test-flexible-ipam-e2e

/test-e2e
/test-flexible-ipam-e2e
/test-ipv6-only-e2e

/all-features-conformance
/test-hw-offload

/test-all-features-conformance
/test-hw-offload

All e2e failed.

/test-e2e

/test-flexible-ipam-e2e

/test-windows-all
/test-ipv6-all
/test-ipv6-only-all
/test-multicluster-e2e
/test-integration

/test-flexible-ipam-e2e

/test-windows-proxyall-e2e

Thanks @tnqn and @jianjuns for your comments, I'm refactoring the change based on those recommendations.

/test-all

/test-flexible-ipam-e2e

Thank you again @tnqn and @jianjuns, indeed when refactored according to your suggestions, the code is more straightforward and less prone to race conditions. @tnqn please note that since the goal is allocation of continuous IP range, today we don't resize preallocations based on replica number. Scaling up is unlikely to succeed (since next IP is likely to be taken), scaling down is possible though.

/test-flexible-ipam-e2e

/test-all

/test-flexible-ipam-e2e


The pg_dump file is missing when pgadmin is backed up in pgadmin container

The pg_dump file does not exist in the pgadmin container, so the backup can not be used.

Hi @ibenchu Please ref #778 , I provided another way.


Add Quantum Computing Subreddit

Add a link to the general quantum computing subreddit, in addition to the Mike and Ike sub

Thanks for the contribution, before merging could you edit it so it is in alphabetical order? Thanks!

Absolutely! Forgot which order u and l went apparently :)

Should be good now


SplitButton Visual updates and flyout fix

Description

This PR updates update some of the visuals of splitbutton and flyout in checked state.
Motivation and Context

Tab separator was visually moving on hover and pressed states of the SplitButton as well as didn't have the right color in Checked state for ToggleButton.
Border brushes were changing on hover and pressed for primary and secondary buttons what was not desired behaviour.
Fixes #4420.
How Has This Been Tested?

Manually
Screenshots (if appropriate):

/azp run

/azp run

Changes look good to me, please review with design.


Update Chinese version of README with recent changes

Several updates were made to the English version of the guide since the Chinese version was created. We need to update the Chinese translation with changes made since the March release (tracked using the v1.0.0 tag).

@rocklau, @LittleLittleCloud, or @CawaMS - Thank you for help in the past with updating the zh-CN version of this repo. I have a new batch of updates available now, would one of you happen to have some time and could help update the zh-CN version of the README with the latest changes? You can view the latest batch here:
https://github.com/jmatthiesen/dotnet-ai-resources/releases/tag/April-2024

@jmatthiesen Please check pr #11


Menu shortcuts have disappeared.

VSCode Version: 1.11.0 - insider (01091bb)
OS Version: Windows 10

-- Sorry for the English, I used Google Translator --
Menu shortcuts have disappeared.
I already uninstalled and installed again.
I installed an old version of Insiders and then I did the update and the problem continues.
I have already disabled all extensions.

Please see if you can find any logged output that could help us find the source of the issue:

run code --verbose from the command line and attach the output
in Code select Help | Toggle Developer Tools and select the Console
attach any output you see in the Console you can find

Thanks!

@bpasero Command Prompt:
[main 08:23:12] Starting VS Code in verbose mode
[main 08:23:12] from: c:\Program Files (x86)\Microsoft VS Code Insiders\resources\app
[main 08:23:12] args: { _: [],
  help: false,
  h: false,
  version: false,
  v: false,
  wait: false,
  w: false,
  diff: false,
  d: false,
  goto: false,
  g: false,
  'new-window': false,
  n: false,
  'unity-launch': false,
  'reuse-window': false,
  r: false,
  performance: false,
  p: false,
  'prof-startup': false,
  verbose: true,
  logExtensionHostCommunication: false,
  'disable-extensions': false,
  disableExtensions: false,
  'list-extensions': false,
  'show-versions': false,
  nolazy: false }
[main 08:23:14] IPC#vscode-machineId
[main 08:23:15] IPC#vscode-workbenchLoaded
[main 08:23:16] IPC#vscode:broadcast null vscode:changeColorTheme vs-dark vscode-theme-defaults-themes-dark_plus-json

In the Toggle Developer Tools did not show anything!

@Tekbr can you share your keybindings.json file?

@bpasero Is empty. I did not change the shortcuts.

@Tekbr does it reproduce in stable?

@bpasero Stable works properly. The problem began to occur in the insiders in the quoted commit.

@Tekbr does it change anything once you add a keybinding to keybindings.json?

@bpasero No. I added a default shortcut again and a modified one, and nothing happened.

-- Sorry for the English, I used Google Translator --
@bpasero Even after some updates from Insiders, I still have the problem. I installed VSCode-insiders on Windows 8 on a Virtual Machine using VirtualBox and had the same problem. Were you able to reproduce the problem?

@Tekbr no

@bpasero I use POR - PTB2 Portuguese keyboard (Brazil ABNT2).

@Tekbr does it reproduce if you stop VS Code, change to US keyboard and then start again?

@bpasero The menu shortcuts are still not displayed after changing the keyboard language and starting the VSCode again.

-- Sorry for the English, I used Google Translator --
@bpasero I installed VSCode - insiders on a virtual machine in Windows 8 in Spanish and I had the same problem.

I also installed VSCode - insiders in a virtual machine in Ubuntu 14.10 in Brazilian Portuguese and I had the same problem.

@Tekbr awesome I can reproduce when I use that language for the keybinding!

@bpasero Is it only Portuguese Brazil? As I showed in the gif with VM Windows 8 in Spanish it also does not load.
Windows 8 on the VM is entirely in Spanish. There was no installation in Portuguese and then change the language to Spanish.

@Tekbr I have a fix ready, it is likely happening in a lot more keyboard layouts.

@bpasero Okay, thank you so much for the attention.

Fixed, will be in tomorrows insider build.

Ohh, very fast. Thank you so much!!

Verified on Ubuntu + Portuguese (Brazil)


Fix MySQLUniqueViolation check to look for error dupe code more broadly

Change

Fixes MySQLUniqueViolation string matching to be less strict.

Why
As of go-sql-driver mysql v1.7.0 the MySQL error code comes back as Error {code} ({state}): {error message}. Due to strict string matching the MySQLUniqueViolation func would fail to match since it looks for Error {code}: {error message}.

Codecov Report
Base: 77.98% // Head: 71.76% // Decreases project coverage by -6.22% :warning:

Coverage data is based on head (59aa06a) compared to base (f919e76).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #265      +/-   ##
==========================================
- Coverage   77.98%   71.76%   -6.23%
==========================================
  Files          30       29       -1
  Lines         995      928      -67
==========================================
- Hits          776      666     -110
- Misses        168      239      +71
+ Partials       51       23      -28

Impacted Files
Coverage Δ

database/mysql.go
31.91% <100.00%> (ø)

database/pkger.go
0.00% <0.00%> (-55.11%)
:arrow_down:

database/migrator.go
0.00% <0.00%> (-50.00%)
:arrow_down:

database/database.go
4.54% <0.00%> (-20.46%)
:arrow_down:

database/sqlite_cgo.go

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Export zod validator creation functions

It would be super useful to be able to re-use the same zod schema on the frontend and in graphQL. It seems like the best way to do this would be to export functions from the validation plugin which you can pass in the validation rules, and it would spit out a zod schema. For example...
const badPassword = createZodSchema({ minLength: 4, maxLength: 8 });

This would then allow us to do something like this:
// Shared.ts:
export const PasswordValidation = { minLength: 4, maxLength: 8 };

// Server.js
t.arg.string({ validate: PasswordValidation });

// Client.js
useForm({
  schema: zod.object({
    password: createZodSchema(PasswordValidation)
  })
})

released in<EMAIL_ADDRESS>docs: https://giraphql.com/plugins/validation#sharing-schemas-with-client-code

Realizing I just gave you what you asked for instead of what you actually wanted.  Going to re-open this.
What I actually should do here is just allow passing in your own zod validator into the validation option.  Then you can define your validator once and re-use it.  It doesn't work well as the default (or only) option, but allowing a schema to be passed in seems pretty straight forward.

okay, better solution is implemented now.
you can pass something like validate: { schema: zod.string().max(5) } now, making it easier to re-use existing zod schemas without using the weird alternate syntax from this plugin.

oh hai @kesne 👋


can not connect in cluster mode

Environment

OS: macOS 10.15.7
Erlang/OTP:  Erlang/OTP 22
EMQ: v4.2.3

Description
I had modified emqx_auth_redis.conf file to support redis cluster. But when I recompiled emqx-rel and load the plugin, I got these error.

[error] <<"1912426236|securemode=3,timestamp=1072916711,signmethod=hmacsha1|">>@<IP_ADDRESS>:54918 [Hooks] Failed to execute {fun emqx_auth_redis:check/3,[#{auth_cmd => "HMGET mqtt_user:%u password",hash_type => plain,pool => emqx_auth_redis,super_cmd => "HGET mqtt_user:%u is_superuser",timeout => infinity,type => cluster}]}: {badarg,[{erlang,element,[1921,undefined],[]},{eredis_cluster_monitor,get_pool_by_slot,2,[{file,"eredis_cluster_monitor.erl"},{line,70}]},{eredis_cluster,query,4,[{file,"eredis_cluster.erl"},{line,116}]},{emqx_auth_redis,check,3,[{file,"emqx_auth_redis.erl"},{line,40}]},{emqx_hooks,safe_execute,2,[{file,"emqx_hooks.erl"},{line,164}]},{emqx_hooks,do_run_fold,3,[{file,"emqx_hooks.erl"},{line,143}]},{emqx_access_control,authenticate,1,[{file,"emqx_access_control.erl"},{line,77}]},{emqx_channel,auth_connect,2,[{file,"emqx_channel.erl"},{line,1181}]}]}

Looking forward to your help. Thx.

Hi @sekfung This looks like a bug inside the program. Could you share the emqx_auth_redis.conf detail?

Of course. @HJianBo
I only modified the values of auth.redis.type ,auth.redis.server and the auth.redis.password
##--------------------------------------------------------------------
## Redis Auth/ACL Plugin
##--------------------------------------------------------------------
## Redis Server cluster type
## single    Single redis server
## sentinel  Redis cluster through sentinel
## cluster   Redis through cluster
auth.redis.type = cluster

## Redis server address.
##
## Value: Port | IP:Port
##
## Single Redis Server: <IP_ADDRESS>:6379, localhost:6379
## Redis Sentinel: <IP_ADDRESS>:26379,<IP_ADDRESS>:26379,<IP_ADDRESS>:26379
## Redis Cluster: <IP_ADDRESS>:6379,<IP_ADDRESS>:6379,<IP_ADDRESS>:6379
auth.redis.server = <IP_ADDRESS>:7001,<IP_ADDRESS>:7002,<IP_ADDRESS>:7003,<IP_ADDRESS>:7004,<IP_ADDRESS>:7005,<IP_ADDRESS>:7006

## Redis sentinel cluster name.
##
## Value: String
## auth.redis.sentinel = mymaster

## Redis pool size.
##
## Value: Number
auth.redis.pool = 8

## Redis database no.
##
## Value: Number
auth.redis.database = 0

## Redis password.
##
## Value: String
auth.redis.password = 123456

## Redis query timeout
##
## Value: Duration
## auth.redis.query_timeout = 5s

## Authentication query command.
##
## Value: Redis cmd
##
## Variables:
##  - %u: username
##  - %c: clientid
##  - %C: common name of client TLS cert
##  - %d: subject of client TLS cert
##
## Examples:
##  - HGET mqtt_user:%u password
##  - HMGET mqtt_user:%u password
##  - HMGET mqtt_user:%u password salt
auth.redis.auth_cmd = HMGET mqtt_user:%u password

## Password hash.
##
## Value: plain | md5 | sha | sha256 | bcrypt
auth.redis.password_hash = plain

## sha256 with salt prefix
## auth.redis.password_hash = salt,sha256

## sha256 with salt suffix
## auth.redis.password_hash = sha256,salt

## bcrypt with salt prefix
## auth.redis.password_hash = salt,bcrypt

## pbkdf2 with macfun iterations dklen
## macfun: md4, md5, ripemd160, sha, sha224, sha256, sha384, sha512
## auth.redis.password_hash = pbkdf2,sha256,1000,20

## Superuser query command.
##
## Value: Redis cmd
##
## Variables:
##  - %u: username
##  - %c: clientid
##  - %C: common name of client TLS cert
##  - %d: subject of client TLS cert
auth.redis.super_cmd = HGET mqtt_user:%u is_superuser

## ACL query command.
##
## Value: Redis cmd
##
## Variables:
##  - %u: username
##  - %c: clientid
auth.redis.acl_cmd = HGETALL mqtt_acl:%u

## Redis ssl configuration.
##
## Value: on | off
#auth.redis.ssl = off

## CA certificate.
##
## Value: File
#auth.redis.cafile = path/to/your/cafile

## Client ssl certificate.
##
## Value: File
#auth.redis.certfile = path/to/your/certfile

## Client ssl keyfile.
##
## Value: File
#auth.redis.keyfile = path/to/your/keyfile

Maybe the list of servers is not reachable... Could you check it?

@HJianBo the servers are reachable. It can works on my other project.

I guest If servers are not reachable, the plugin can not be loaded

Yes, it really should be. But I just checked and found out that it doesn't cause the plugin to fail to start!
It's bad behavior. We try to improve in the later version

OK. Maybe the issue title is misleading. The plugin can be successful to start. the bug occurs on query some data.
Anyway, Thanks for your help.

@HJianBo Maybe I can provide more detail.
When the plugin query some data, I print the State in get_pool_by_slot func of eredis_cluster_monitor module
https://github.com/emqx/eredis_cluster/blob/61eedf2eb66dbfaec9b2b4eb7605a252f3d44daa/src/eredis_cluster_monitor.erl#L70
get_pool_by_slot(Slot, State) when is_integer(Slot) ->
    io:format("get_pool_by_slot, Slot(~p)\nState(~p)\n", [Slot, State]),
    Index = element(Slot+1,State#state.slots),
    Cluster = element(Index,State#state.slots_maps),
    if
        Cluster#slots_map.node =/= undefined ->
            {Cluster#slots_map.node#node.pool, State#state.version};
        true ->
            {undefined, State#state.version}
    end;

Here is the log
get_pool_by_slot, Slot(1920)
State({state,[{node,"<IP_ADDRESS>",7001,undefined},
              {node,"<IP_ADDRESS>",7002,undefined},
              {node,"<IP_ADDRESS>",7003,undefined},
              {node,"<IP_ADDRESS>",7004,undefined},
              {node,"<IP_ADDRESS>",7005,undefined},
              {node,"<IP_ADDRESS>",7006,undefined}],
             undefined,{},1,emqx_auth_redis,0,"123456",8,0,[]})

I found that the slots and the node pool both are undefined. So when the program try to get an element from undefined, it happens.

I don't know why the slots are undefined. I master erlang language poorly. If you can provide some help about my problem, I would appreciate it.

Perhaps we can keep track of the redis link and see if it works. After started emqx, you can:
bin/emqx attach

1> dbg:tracer(),dbg:p(all,call).
2> dbg:tp(eredis_client,x).

Then try to restart the emqx_auth_redis plugin

Here is the log

(emqx@<IP_ADDRESS>)1> dbg:tracer(),dbg:p(all,call).
{ok,[{matched,'emqx@<IP_ADDRESS>',320}]}
(emqx@<IP_ADDRESS>)2> dbg:tp(eredis_client,x).
{ok,[{matched,'emqx@<IP_ADDRESS>',13},{saved,x}]}
(emqx@<IP_ADDRESS>)3> (<0.1790.0>) call eredis_client:module_info(attributes)
(<0.1790.0>) returned from eredis_client:module_info/1 -> [{behaviour,
[gen_server]},
{vsn,"4.2.3"}]
(<0.1790.0>) call eredis_client:module_info(attributes)
(<0.1790.0>) returned from eredis_client:module_info/1 -> [{behaviour,
[gen_server]},
{vsn,"4.2.3"}]
(<0.1790.0>) call eredis_client:module_info(attributes)
(<0.1790.0>) returned from eredis_client:module_info/1 -> [{behaviour,
[gen_server]},
{vsn,"4.2.3"}]
2020-11-27 15:13:44.277 [error] <<"1912426236|securemode=3,timestamp=1072916711,signmethod=hmacsha1|">>@<IP_ADDRESS>:49701 [Hooks] Failed to execute {fun emqx_auth_redis:check/3,[#{auth_cmd => "HMGET mqtt_user:%u password",hash_type => plain,pool => emqx_auth_redis,super_cmd => "HGET mqtt_user:%u is_superuser",timeout => infinity,type => cluster}]}: {{case_clause,[]},[{eredis_cluster_monitor,get_state,1,[{file,"eredis_cluster_monitor.erl"},{line,49}]},{eredis_cluster_monitor,get_pool_by_slot,2,[{file,"eredis_cluster_monitor.erl"},{line,79}]},{eredis_cluster,query,4,[{file,"eredis_cluster.erl"},{line,116}]},{emqx_auth_redis,check,3,[{file,"emqx_auth_redis.erl"},{line,40}]},{emqx_hooks,safe_execute,2,[{file,"emqx_hooks.erl"},{line,164}]},{emqx_hooks,do_run_fold,3,[{file,"emqx_hooks.erl"},{line,143}]},{emqx_access_control,authenticate,1,[{file,"emqx_access_control.erl"},{line,77}]},{emqx_channel,auth_connect,2,[{file,"emqx_channel.erl"},{line,1181}]}]}

And it seems like it's another problem... amazing!!!

Fine... I rollback emqx to v4.2.0. It works...


Add a tip jar

This is really an exemplary open-source .NET project, and I've really appreciated it.

Thanks you for your kind words, but I don't really need or want to add tips.
If you appreciate what I'm doing and want to help out, you can spread the word, that is more than enough :)


cant run visualize_detector.py

https://github.com/Alibaba-MIIL/ImageNet21K/blob/72c822a7a30290f078a2611139a1f0bcdb668606/visualize_detector.py#L25
error:
Unknown model (vit_base_patch16_224_miil_in21k)
how to run with my own wight

@In Pytorch Image models you can find it, Try to update the timm?

you are right @Stephen-Hao
@jaffe-fly: update to latest timm version
pip uninstall timm
pip install git+https://github.com/rwightman/pytorch-image-models.git

I am training on my 17flowers dataset  and save checkpoint,.when i predict , its error!!
Traceback (most recent call last):
  File "plugin_test.py", line 28, in <module>
    ynet.predict(data)
  File "/home/wangzf/ImageNetClassify/server/plugins/imagenet/ImageNet.py", line 118, in predict
    semantic_logit_list = self.semantic_softmax_processor.split_logits_to_semantic_logits(logits)
  File "/home/wangzf/ImageNetClassify/server/plugins/imagenet/semantic/semantics.py", line 50, in split_logits_to_semantic_logits
    logits_i = logits[:, ind]
IndexError: index 40 is out of bounds for dimension 0 with size 17

My code

device = torch.device('cuda:0' if torch.cuda.is_available() else 'cpu')
semantic_softmax_processor = ImageNet21kSemanticSoftmax(imagenet_path)

labels_to_idx = {'黄水仙': '0', '雪花莲': '1', '百合谷': '2', '蓝铃': '3', '番红花': '4',
                         '鸢尾花': '5', '倾斜': '6', '郁金香': '7', '贝母': '8', '向日葵': '9', '雏菊': '10',
                         '小马队脚': '11', '蒲公英': '12', '奶牛纤维': '13', '毛茛属植物': '14', '迎风': '15', '三色堇': '16'}

model = timm.create_model('mobilenetv3_large_100',pretrained=False, num_classes=len(labels_to_idx),checkpoint_path='/tmp/model.alphamind.h5')
model.eval()
config = resolve_data_config({}, model=model)
image_path ='1.jpg'
img = Image.open(image_path).convert('RGB')
transform = create_transform(**self.config)
tensor = transform(img).unsqueeze(0)  # transform and add batch dimension
logger.info("doing semantic infernce...")
labels = []
with torch.no_grad():
    logits = model(tensor)
    semantic_logit_list = semantic_softmax_processor.split_logits_to_semantic_logits(logits)
    # scanning hirarchy_level_list
    for i in range(len(semantic_logit_list)):
        logits_i = semantic_logit_list[i]

        # generate probs
        probabilities = torch.nn.functional.softmax(logits_i[0], dim=0)
        top1_prob, top1_id = torch.topk(probabilities, 1)

        if top1_prob > 0.5:
            top_class_number = semantic_softmax_processor.hierarchy_indices_list[i][top1_id[0]]
            top_class_name = semantic_softmax_processor.tree['class_list'][top_class_number]
            top_class_description = semantic_softmax_processor.tree['class_description'][top_class_name]
            labels.append(top_class_description)

logger.info("labels found {}.".format(labels))

Where to change???

@jaffe-fly
you can't use 'visualize_detector.py' file to visualize a detector on your own dataset
it uses the specific hierarchy structure of imagenet-21k.
for your dataset, you can predict the top1 class for each image
  # generate probs
  probabilities = torch.nn.functional.softmax(logits, dim=0)
  top1_prob, top1_id = torch.topk(probabilities, 1)

it seems wrong!

i am not sure what's the problem, maybe the dim should be different, or you should do
softmax(logits[0])
align you dims by finding out what is:
print(logits.shape)
anyway, after you properly initialize the model on your transfer learning task, it's a standard timm model.
an example of general inference of timm model can be found in:
https://rwightman.github.io/pytorch-image-models/models/mobilenet-v3/

I got the same problem.
Tried following
pip uninstall timm
pip install git+https://github.com/rwightman/pytorch-image-models.git

but still error exists

thanks


File not found when python datasets/pdbbind_lm_embedding_preparation.py

Hello
Iam following instructions to set up env and running on your complexes. We ll write a jupyter notebook based on the google colab. So far, all good.
However, i tried also the Retraining DiffDock section. Probleme the zip file seems incomplete.
I did step by step (see attached file if needed). However when i reached :
python datasets/pdbbind_lm_embedding_preparation.py
it appears that the directory 1a50 is empty (i tried to download twice the zip) (see below)
Than you for your help
python datasets/pdbbind_lm_embedding_preparation.py
0%|                                        | 31/19120 [00:03<31:44, 10.02it/s]
Traceback (most recent call last):
File "datasets/pdbbind_lm_embedding_preparation.py", line 63, in
structure = biopython_parser.get_structure('random_id', rec_path)
File "/disk/prog/anaconda/envs/diffdock/lib/python3.8/site-packages/Bio/PDB/PDBParser.py", line 96, in get_structure
with as_handle(file) as handle:
File "/disk/prog/anaconda/envs/diffdock/lib/python3.8/contextlib.py", line 113, in enter
return next(self.gen)
File "/disk/prog/anaconda/envs/diffdock/lib/python3.8/site-packages/Bio/File.py", line 72, in as_handle
with open(handleish, mode, **kwargs) as fp:
FileNotFoundError: [Errno 2] No such file or directory: 'data/PDBBind_processed/1a50/1a50_protein.pdb'

Strange, maybe you could just skip that (by simply putting a Exception handler and just skip that training complex?!
It should not affect the final training significantly

Closing this issue since it seems to be resolved based on the time passed. Feel free to reopen if this is incorrect.


Update qlmarkdown to v1.3.4

Please checkout it!
https://github.com/toland/qlmarkdown/releases

Care to submit a PR? It isn’t a complex fix, and we’re here to help.

I don't know how to do it but I'm interested as well. ;)

@vitorgalvao please checkout #15459


Blank rows appear when searching for a User in the Submit Flow

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation (hyperlinked to channel name): #quality
Action Performed:

Navigate to the "Submit" flow in the application.
Enter an Amount and click Next
Enter a search query for a user
Observe the search results.

Expected Result:
The search results should display a list of users with relevant details
Actual Result:
The search results show blank rows without any username details.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Standalone
[ ] Android: HybridApp
[ ] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

are we good to close this issue since it's a not a bug in the feature per se?

I dont think so, we will use the migration script for real customers so if its indeed an issue with the migration script, other customers could face it in future.  cc @puneetlath @tylerkaraszewski Is it possible to know if the report was created when the migration script ran?

Do we know what kind of reports these are? Are they expense reports?
The only types of reports the migration script creates are Workspace Chats or Transaction Threads. Expense reports should already exist, though the migration script will make them "newdot-accessible".
What makes us think this is migration-related? Do we have the onyx data for those reports that are returning the blank rows?

Do we know what kind of reports these are? Are they expense reports?

Judging by what is said on the linked thread, this seems to come from chat reports.

Do we have the onyx data for those reports that are returning the blank rows?

@shawnborton do you have the complete Onyx data?
Here's what Shawn already posted (https://expensify.slack.com/archives/C05LX9D6E07/p1733869523321809?thread_ts=1733842803.627139&cid=C05LX9D6E07):

What makes us think this is migration-related?

The created date of the report just above:
2023-11-13

@lakchote what's the best way to get a full onyx dump for these?
Something interesting just happened - when I clicked on one of the blank rows to start a chat with, I see this now:

Do these reports exist in the db? If so, could we get the report/rnvp data for one of them?

Happy to look into that but I'm not sure how. Can someone provide some instructions please? Thanks!

Ah, that was more of a question for Lucien. To help get to the bottom of where these reports may have come from and narrow down whether this is indeed from the migration.

@lakchote what's the best way to get a full onyx dump for these?

Go to Settings > Troubleshoot and enable Debugmode.
Then click on a blank report's name, a RHP will open with a Debug item, click on it.

Then click on JSON tab and copy the data there.

Something interesting just happened - when I clicked on one of the blank rows to start a chat with, I see this now:

@shawnborton can you share in the Network tab of your browser, the result of the API call for the OpenReport command please?

Dropped lots of notes in this thread here

Ah, that was more of a question for Lucien. To help get to the bottom of where these reports may have come from and narrow down whether this is indeed from the migration.

I've created a GH to return reports/rNVP data here.

Posted findings here.

Coming from that thread. The main problem we are seeing is that we have parentReportActionID rNVPs that point to actions that do not exist. There are >300k of them:
ionatan@db1.rno:~$ sudo readdb.sh "select count() from reportnamevaluepairs rnvp left join reportactions ra on rnvp.value = ra.reportactionID where value != 0 AND name = 'parentReportActionID' AND ra.reportactionID is null;"
count()
-------
300794

We need to:

Ensure we are not saving data in the rNVP pointing to an action that does not exist
Ensure that either you can't delete an action that's being pointed to by an rNVP OR update the rNVP to not point to the action anymore
Somehow fix all the 300k rNVPS with bad data
Maybe add more protections to the code so that this bad data scenario can't happen anymore

I've investigated all the 3 report IDs that @shawnborton has reported.
All of them got updated in a migration for reports details column on Nov 23:

(Link to migration GH issue)
Could this has caused side effects in some flows that would produce the situation where we have a parentReportActionID saved in the rNVP table that does not exist in the DB?

Hey team! Just a heads up — I will be OOO starting this afternoon (December 20th) and will be returning January 6th. A handful of folks on the BZ team will be online for a few days in between the 25th and the 1st, but we'll be operating with a skeleton crew. If any action is needed from a BZ perspective, please post this issue in #expensify-open-source and someone on the team will jump in. Otherwise I'll review when I'm back in office.
Thank you and Happy Holidays!

Issue not reproducible during KI retests. (First week)

Issue not reproducible during KI retests. (Second week)


Add empty data uri if it is missing

I encountered a model whose shader is defined in the binary-gltf body but doesn't set a data-uri. I believe this is technically invalid according to the spec, but it is worth handling this case anyways.
@lasalvavida

Looks good to me, thanks @lilleyse!


OnClick outline

I'm trying to remove the black slide outline that appears when clicked or dragged. I've tried
body {
   outline: 0;
   border: 0;
}

To no avail.
Thanks!

https://github.com/akiran/react-slick/issues/1439

Solution here
https://github.com/akiran/react-slick/issues/1439#issuecomment-445664432


set version from git describe

Possibly using a similar technique as in here

There's a problem with the git describe command run from the action


vim instances in screen session windows crashing

The following was run using vim 8.1 running under Linux with kernel 5.7.   The bash shell was used.
cd temp # at initial terminal
#
sess=test
screen -d -m -S "$sess" -T xterm -U -t "$sess" # create session
xterm -T "$sess" -e screen -x "$sess" -p "$sess" &
#
title=title1 fpath=~/temp/file1
screen -S "$sess" -X screen -t "$title" vim "$fpath"
xterm -T "$title" -e screen -x "$sess" -p "$title" &
#
title=title2 fpath=~/temp/file2
screen -S "$sess" -X screen -t "$title" vim "$fpath"
xterm -T "$title" -e screen -x "$sess" -p "$title" &
#
exit # at initial terminal
#
# wait a few seconds
# click in the vim windows and the vim instances will crash

Please first try with the latest Vim. If it still crashes, cocmpile a debug version and get a stacktrace where it crashes.

Just built 8.2 which I think is the latest stable, and carried out quite a bit of testing.  It seems to be working without any problems so far.   I'm afraid I'll just have to find something else to complain about.....:-)


GDS Renderer gdspy library precision argument passing

What are the issues this pull addresses (issue numbers / links)?
Issue #611
Did you add tests to cover your changes (yes/no)?
Did you update the documentation accordingly (yes/no)?
Did you read the CONTRIBUTING document (yes/no)?
Summary
Details and comments

@bashensen , can you please add your changes to the latest commit from main?

Sorry my bad, fetched and merged my forked one now.
Still no precision argument passed upon creation of the gdspy lib


Cannot read property 'group' of undefined

Describe the bug
Problems panel doesn't work. It shows "Cannot read property 'group' of undefined".
** Log **
TypeError: Cannot read property 'group' of undefined
at eval (triggers_panel_ctrl.js:253)
at angular.js:17169
at angular.js:17217
at c.$digest (angular.js:18351)
at c.$apply (angular.js:18649)
at angular.js:20574
at p (angular.js:6428)
at angular.js:6707 "Possibly unhandled rejection: {}"
Software versions

Grafana
Zabbix
Grafana-Zabbix Plugin

6.5.1
4.4.3
3.10.4

duplicates #817


kvstore: add tests for etcd ratelimiter implementation

Increase unit tests coverage for pkg/kvstore.
This Pull Request adds tests to cover rate limiter functionality for etcd kvstore backend.
Fixes #11916

test-me-please

Hitting #13071 for net-next run.


Add all configuration params to Docker

Ability to configure the docker instance with the same params that the npm version.
@fabienvauchelles

will be in the 4.0.0

Hey there! 🌟 Exciting news! Scrapoxy 4 is ready to rock 🚀. Check it out at Scrapoxy.io (explore the "get started" guide, deployment documentation, and more 📚).
I can't wait to hear your feedback on this new version! Send me your coolest screenshots with as many proxies as possible! 📸💻
Join the Discord community if you have any questions or just want to chat. You can also open a GitHub issue for any bug or feature request 🐞✨.
See you soon!  😎
Fabien


only registers cleaner in native map when needed

Registering cleaners takes up resources and currently bumps into a global lock. The native map code is registering a cleaner for iterators, even in the case where the native code did not allocate an iterator. This code is called very frequently by scan threads.
This change does not register the cleaner in the case where the native code did not allocate a native iterator.  This should cause less contention between scan threads that are unrelated to each other.

Notice this while researching the lock contention seen in #4910.


Support connect to the Receive by query param 'receiverId'

It is necessary to support read query parameter 'receiverId' before search first receiver by API request.

v3.0.0


feat: add DateTimePicker

closes #58

I first use this package, it's looks well
but I get a error with webpack, on 6.0.0 and 5.16.0
ERROR in ./node_modules/react-hook-form-mui/dist/esm/index.js 126:0-66
Module not found: Error: Can't resolve '@mui/x-date-pickers/DatePicker' in '/Users/work/work/project/node_modules/react-hook-form-mui/dist/esm'
I don't need date time picker, so why I need install @mui/x-date-pickers/DatePicker?

@shoyuf you have to install it, even you don't use it. Your bundle size of your app will not change.


Sensu results API - Adding more information

Hey guys,
Is it possible to add more information/fields to a result passed in via the REST API?
I've got a check that runs a PowerShell script, which checks a list of contracts expiration dates and sends the results to the Sensu API, creating a single check per contract (and obviously providing a status depending upon how long is left).
Currently I'm passing in a check name, status, output and source (they all come from the source 'contract-checks' for tidiness in Uchiwa). I would like to pass in other fields, such as 'supplier', 'cost' but j get a 400 Bad Request because I assume the results via. API only accommodate the bare minimum fields?
Is there any way around this currently, or could it be a consideration for the future?
Thanks!

@absolutejam that's odd, as POST /results does support custom check result attributes https://github.com/sensu/sensu/blob/master/lib/sensu/api/routes/results.rb#L14-L26

Is it possible that you are also providing an attribute that overlaps with one that Sensu is validating?

Apologies, you're right!
It looks like my actual check name had a space in it when I'd tried adding other fields, so it gave me a 400 error. I'd later sanitized the check field but not tried adding extras again, thinking there was an issue with those!


getMetadata() not working on MB85RC64V

I have a MB85RC64V FRAM chip and although I am able to read and write it, the metadata information is not working.
The exact component I am using is this but the datasheet does not say anything about a metadata address code to send, so I would assume that it does not supply this information.
In https://github.com/RobTillaart/FRAM_I2C/blob/b536e637f21976bb7163ff4fd437c276cda71109/FRAM.cpp#L352 the number of read bytes is always 0 so the function returns -1. The datasheet says, that the device only uses 13 bits for the addresses and I am wondering if it would be necessary to have a FRAM13 class (with fixed memory size like in FRAM9) as well for this case although it does not work fundamentally different from the base FRAM class?
In addition I am wondering if it would make sense to return the number of written bytes returned by _wire->write in all the write* methods to give the user the ability to check if something went wrong during the write operation?

It won't return -1 because of the return type.
https://github.com/RobTillaart/FRAM_I2C/blob/b536e637f21976bb7163ff4fd437c276cda71109/FRAM.cpp#L344

It should not need a new class as it behaves just like 32KiB chip (FRAM class, 2 bytes memory address), while FRAM9, FRAM11, FRAM32 need special treatment because they use device address bits for memory address.

I don't think that's necessary.

@sharkydog

You are right, -1 will be mapped upon 0xFFFF which could cause errors in the calling code.
Especially getSize(), however it would set the size to 1UL << 0xFFFF which would become 0.
So not handled as it should, but no harm done.

getSize() should have an extra test at least be rewritten as:
// NOTE: returns the size in kiloBYTE
uint16_t FRAM::getSize()
{
  uint16_t size = 0;
  uint16_t density = _getMetaData(2);
  if (density != 0xFFFF)
  {
    if (0 < density) && (density < 16))  size = (1UL << density);   // only shift for valid values.
  }
  _sizeBytes = size * 1024UL;
  return size;
}

Will add a note to include this in some next release.

Agree
Had a quick look at the datasheet and it indeed uses 2 bytes for the memory address (13 for address and 3 MS bits 0).
The 3 zero bits are not used otherwise so no new class needed.

BTW The MB85RC64 type is mentioned in the readme.md. T version instead of V version, the T does implement the metadata where the V does not.

In addition I am wondering if it would make sense to return the number of written bytes returned by _wire->write in all the write* methods to give the user the ability to check if something went wrong during the write operation?

It could make sense, but writing the bytes do not guarantee that the EEPROM is written, only a verify / read back is 100%

You can skip if (density != 0xFFFF) {} as you have this (density < 16) and 65535 is certainly not lower than 16 :)
But It should also be noted that FRAM::getManufacturerID() and FRAM::getProductID() may return 0xFFFF

I will push a develop branch today with these and some more.

Pull Request created - https://github.com/RobTillaart/FRAM_I2C/pull/41

Fixed in 0.5.4


UI: Error ID in Error Messaging

Background:
Need implement backend error ids in all front end error messaging

Need to determine if we are storing error messages anywhere. Messages should be in a message store so that we can ID them and we can update them as needed.

@annalbrecht , could we discuss this ticket at the next stand up meeting? Thanks.

@annalbrecht could you change the priority from Low to High? We'd like to further discuss this ticket at the next meeting.
This ticket appears to be tracking two separate issues (12/01/2023 and 03/26/2024 comments). Also, EPA is reviewing additional requirements related to this topic and may need to add/modify the requirements.

This will be covered by other tickets in the future. Closing.


[🐛] Heroku deploy button broken

:bug: Bug report
Description

A clear and concise description of the problem...
The deploy Heroku button at https://github.com/bkimminich/juice-shop#deploy-on-heroku-free-0month-dyno is passing the incorrect link and results in an error.
It currently links to https://heroku.com/deploy
It should redirect to https://heroku.com/deploy?template=https://github.com/bkimminich/juice-shop

The button works as is, at least in my regular Chrome installation. Heroku recommends to use it this way, because that allows you to click the button on any fork of the repo, and you'll get that fork deployed. If I hardcoded the repo name, you'd always get my version.

See discussion in #1212.


Event Section

Description
Is someone working on event section ? Kindly assign it to me !!
Screenshots
No response

@Ritika122001 What changes you wants to do ?

I will improve the UI of cards. The information displaying on hovering is same as the background image . So I will remove text on hovering and include the button to link it to Youtube.

@Ritika122001 sure, work on it

Hey @SauravMukherjee44 I want to work on this issue plz assign it to me


Visualization users

Modified create_movies_from_raw_data.ipynb with the user in mind:

choose a data folder where all the experiments live
choose a current 'imaging day' folder which contains several experiments
check which child folders (experiments) contain 'DS' or 'decon' subfolders
save movies with naparimovie
-- movie will save with a file name corresponding to the name of the current folder, e.g. imaging_day_1__exp01

I manually resolved the conflicts in the json file.
This is a bit painful! Can we get a jupyter notebook diff viewer?
I kept Max's add timestamp and add scale bar functionality
the other changes were just jupyter notebook tracking and outputs


Move dispatcher sink to the beginning of the ROM to help witgen

With the introduction of the dispatcher in #392, VMs are essentially turned into dynamic block machines. They expose entry points which can be called from the outside, generating each time one block.
This introduces a difficulty for witgen: once we've computed blocks for all the calls we want, how do we fill the rest of the table?
For static block machines (with blocks of static size), one strategy is the repeat an existing block.
This is not ideal for dynamic block machines:

as the blocks have dynamic sizes, we cannot guarantee that a previous block will have a size which divides the number of remaining rows, which potentially introduces issues at the bottom of the table, as the last block will be incomplete. Not unfixable, but annoying.
witgen hugely benefits from repeated rows

What we want instead is to end up in an infinite loop.
Before #392, an infinite loop was required in user code. After #392, an infinite loop is available in the dispatcher. In pseudocode:
_jump_to_operation;
operation_0::
// body of operation_0
operation_1::
// body of operation_1
_sink::
loop;

Therefore, we want witgen to be able to run _sink to fill the rest of the table.
We could expose _sink like the other operations of this machine, but this would add another lookup for something which is actually not called, so it runs the risk of being optimised away, or just useless prover overhead.
Instead, the idea is to move _sink to the beginning of the dispatcher code, so that its operation_id is 0.
As a result, witgen can use the same strategy as for block machines which are not called: try to call them with all arguments being 0, which would work here (whatever the arguments, an infinite loop at operation_id 0 generates valid blocks)

@georgwiese can we close this?

Yeah, I'd say this was solved by #690


[SPARK-35909][DOCS] Fix broken Python Links in docs/sql-getting-started.md

What changes were proposed in this pull request?
The hyperlinks in Python code blocks in Spark SQL Guide - Getting Started currently point to invalid addresses and return 404. This pull request fixes that issue by pointing them to correct links in Python API docs.

Why are the changes needed?
Error in documentation classifies as a bug and hence needs to be fixed.

Does this PR introduce any user-facing change?
Yes. This PR fixes documentation error in https://spark.apache.org/docs/latest/sql-getting-started.html

How was this patch tested?
This patch was locally built after cloning the repo from scratch and then doing a clean build after fixing the required problems.

Can one of the admins verify this patch?

I added you to the Apache Spark contributor group and assigned SPARK-35909 to you. Welcome! :)

Thanks @dhruvildave!


Support running individual tests

This PR supports running individual tests from make (ex: make test-storage). To run all the tests, just run make test like before.

Good idea :+1:

:+1: