3.0 alpha. SurfaceTool.

Operating system or device - Godot version:
Windows 10 3.0 alpha
Issue description:
I create a generated mesh from SurfaceTool. And its not visible in Viewport, and no error message in console. Code added to MeshInstance. Here code.
extends MeshInstance

var m
var s = SurfaceTool.new()
var vert = [
Vector3(-0.5,0.5,0),
Vector3(0.5,0.5,0),
Vector3(-0.5,-0.5,0),
Vector3(0.5,-0.5,0)
]

func _ready():
	s.begin(4)

	s.add_vertex(vert[0])
	s.add_vertex(vert[1])
	s.add_vertex(vert[3])

	s.add_vertex(vert[1])
	s.add_vertex(vert[2])
	s.add_vertex(vert[3])

	s.index()
	s.generate_normals()

	m = s.commit()
	set_mesh(m)

And same with custom ConcavePolygonShape(collision shape). Code added to StaticBody. Here code.
extends StaticBody

var vert = [
Vector3(-0.5,0.5,0),
Vector3(0.5,0.5,0),
Vector3(-0.5,-0.5,0),
Vector3(0.5,-0.5,0)
]

func _ready():
	generateCollisionShape()

func generateCollisionShape():
	var shape = ConcavePolygonShape.new()
	var tri_arr = [vert[0],vert[1],vert[2],vert[0],vert[3],vert[2]]
	shape.set_faces(tri_arr)

	add_shape(shape)

Did you turned around the point where you generate that shape? Maybe it's because of backface culling?
I use SurfaceTool massively in my module and it works fine so far.

I use animation for rotate node. Here i rewrite code... and nothing changed. And even add custom normals on vertex. And i not in first time use SurfaceTool and this code work perfect in 2.1.2 :3

extends Spatial

var mesh = Mesh.new()
var s = SurfaceTool.new()
var vert = [
Vector3(-1,0,-1),
Vector3(1,0,-1),
Vector3(1,0,1),
Vector3(-1,0,1)
]

func _ready():
	s.begin(Mesh.PRIMITIVE_TRIANGLES)
	s.add_normal(Vector3(0,1,0))
	s.add_vertex(vert[0])
	s.add_normal(Vector3(0,1,0))
	s.add_vertex(vert[1])
	s.add_normal(Vector3(0,1,0))
	s.add_vertex(vert[2])

	s.add_normal(Vector3(0,1,0))
	s.add_vertex(vert[0])
	s.add_normal(Vector3(0,1,0))
	s.add_vertex(vert[2])
	s.add_normal(Vector3(0,1,0))
	s.add_vertex(vert[3])

	s.index()

	mesh = s.commit()
	$MeshInstance.set_mesh(mesh)

I see a black quad, which is ok because you have no lights in your scene and it has no UVs and no colors.

@Zylann This screenshot from 2.1.2 - of course its works. You use build from what date?
I use night build from "fixnum.org/godot/", and last build where this code works is "February 16, 2017 at 17:22" and yes it's Godot 3.0. Maybe its helps :3

I use build af282b56feb8d84049f911dd1d91d82bd2211727

So, should we close this as fixed?

Today's build still not working.

Hmmm... looks like some configurations don't work. I made a triangle that shows, but if I give it a slightly bigger size, it vanishes.

Ok, weird weird weird:
This shows a triangle:
	var s = SurfaceTool.new()
	var k = 1.0
	s.begin(Mesh.PRIMITIVE_TRIANGLES)
	s.add_vertex(Vector3(-k,0,-k))
	s.add_vertex(Vector3(1,0,-k))
	s.add_vertex(Vector3(1,0,1))
	var mesh = s.commit()
	$MeshInstance.set_mesh(mesh)

This doesn't:
	var s = SurfaceTool.new()
	var k = 1.0
	s.begin(Mesh.PRIMITIVE_TRIANGLES)
	s.add_vertex(Vector3(-1,0,-1))
	s.add_vertex(Vector3(1,0,-1))
	s.add_vertex(Vector3(1,0,1))
	var mesh = s.commit()
	$MeshInstance.set_mesh(mesh)

Lol, just tested all OK (about print Vector3()) :3

You have to test the exact same script, really, otherwise it doesn't repro. @Hinsbart got the same issue after doing that too. It's extremely fishy :'D

I think this is a bug stemming from #7815, @hpvb.
@Zylann And no, that's not the first paranormal bug with hashing either: #3843 :wink:

It's possible, but it would surprise me as I don't see how the hashing codepaths could be called in this case. I'll do a little gdb investigating this weekend.

I used the following code to successfully generate a triangle:
extends MeshInstance

func _ready():
	var tri = Mesh.new()
	var surfTool = SurfaceTool.new()
	surfTool.begin(Mesh.PRIMITIVE_TRIANGLES)
	surfTool.add_vertex(Vector3(0,5,0))
	surfTool.add_vertex(Vector3(10,5,0))
	surfTool.add_vertex(Vector3(10,5,10))

	surfTool.generate_normals()
	surfTool.index()
	surfTool.commit(tri)
	set_mesh(tri)

I have no problems with generation. Bigger meshes are also no problem, as this screenshot shows:
https://lut.im/L4wicny39A/njEtUjEIFxrszZMM.png

Ah, I didn't understand the issue at first. Since I never have vertexes with the same position hashes in a triangle, this problem never occurred for me.

I tested this right before #7815 and right after #7815 (on 36986531afe3996de05640ff02088d18b24d409c and 903a3aa5f0e128abb1fb752c10b343b34af8f799), and I can confirm that the issue is caused by it.
Testing script:
func _ready():
  print(Vector3(-1, 0, 1))
  print(Vector3(1, 0, -1))

Pre-#7815 output:
(-1, 0, 1)
(1, 0, -1)

Post-#7815 output:
(-1, 0, 1)
(-1, 0, 1)

Closing as duplicate (and another symptom of) #8081.


Ignore Models from external dbcontexts

I'm trying to build some architecture where i have a butch of common stuff in one single project and reuse them in all my other projects.
One of those things is, user management (identity framework).
I'm using the same database for all those projects
My ProjectContext looks like this:
namespace Project.Database
{
    public class ProjectContext : DbContext
    {
        public ProjectContext(DbContextOptions<ProjectContext> options)
            : base(options)
        {
        }

        protected ProjectContext(DbContextOptions options)
            : base(options)
        {
        }

        public DbSet<Entity1> Entity1 { get; set; }

        public DbSet<SC.Database.Models.Identity.ApplicationUser> User { get; set; }

        protected override void OnModelCreating(ModelBuilder modelBuilder)
        {
            base.OnModelCreating(modelBuilder);

            //modelBuilder.Ignore<SC.Database.Models.Identity.ApplicationUser>();
        }
    }
}

Entity1 looks like this:
using System.ComponentModel.DataAnnotations;
using System.ComponentModel.DataAnnotations.Schema;

namespace Project.Database.Models
{
    public class Entity1
    {
        [Key]
        public int Id { get; set; }
        public string MyProperty { get; set; }
        public string SecondProp { get; set; }
        [Required]
        public string UserId { get; set; }
        [ForeignKey("UserId")]
        public virtual SC.Database.Models.Identity.ApplicationUser User { get; set; }
    }
}

As you can see, ApplicationUser is from another dll (another context) (SC is my common project).
If I uncomment the modelBuild.Ignore line the table won't be created (👍) but the foreign keys i have neither 😒
Will creating migrations, is there a way to only ignore the CreateTable and DropTable? Instead of ignore everything related with that Model.
Further technical details
EF Core version: 2.2.0
Database Provider: Microsoft.EntityFrameworkCore.SqlServer
Operating system: Windows 10 Pro
IDE: Visual Studio Enterprise 2017 15.9.14

Duplicate of #2725


API: some comments about API changes from PR #215 review

@jlewi Hi, file this issue to track API comments from PR #215:

Reuse metadata.UID instead of RuntimeId in TfJobSpec.
Maybe we should revisit status representation: State/ReplicaState/TfReplicaStatus.

What are the properties of UID? i.e. how long is it and what characters does it use?

@jlewi Hi, It is defined here, Identifiers and Names in Kubernetes
UID: A non-empty, opaque, system-generated value guaranteed to be unique in time and space; intended to distinguish between historical occurrences of similar entities.

Great. I think you are right we can and should replace RuntimeId with the UID; although we might need to truncate it.

The v1alpha2 API (kubeflow/community#30) gets rid of runtime id.

I'm closing this issue because I think its resolved by the v1alpha2 API.


Build custom parquet extractor

Build an extractor and test with all .NET types with USQL in a set of query tests

already done


Toolbar>'Element'>'delete selected element' deletes table header when no element is selected

Describe the bug
When I have no elements selected, I can still select toolbar>'element'>'delete selected element' and it does not complain, but it deletes table header and I have to use toolbar for new elements. Also the first element (if exists) gets an ugly look.
To Reproduce
Steps to reproduce the behavior:

Open editor. There are no elements (It's normal)
Toolbar>'Element'>'delete selected element'
Select 'yes'
See bug

Expected behavior
Disable the menu-item when no element is selected, or
Show an error when I try to click it without any selected element.


States attribute "is_on" always seems to be true, how to detect if AC is really cooling?

I'm trying to detect it my AC is actually cooling, but the states object doesn't seem to have that kind of information.
As far as the attributes go, hvac_action is always the preset mode (e.g. cooling), and is_on is always "true".
So how can I detect that my AC is actually doing something?

Hi @michelcve the only thing you can look at is the (hvac) state.
The only information we get from the device is the mode it is in (off, heat, cool, heat_cool, dry, fan_only).
It doesn't provide any information if it's actually doing anything, if you have the energy sensor you might be able to use that to detect if it's actually doing anything.


I copy a Objective-C version and add 24 hour calculate method.

Hi Cardoso,
I`m very grateful for this library.
And I translate this library from SWIFT to Objective-C.
Also I just add 24 hours calculate method that for your reference.
Link for OC version: https://github.com/Nikolilol/NKBedtimeClock-master
Thank you.

Thanks, @Nikolilol. I will copy your 24 hr approach when I have time. 😄


CI fails on PRs from external contributors

Which component is your bug related to?
Forge
Foundry Version
--
What operating system are you using?
Linux
What system architecture are you using?
x86
What happened
As you can see here CI failed even though I've merged the master. There is a problem with reading the CHEATNET_RPC_URL secret I guess because forking tests are failing
Trace
No response
Is there an existing issue for this?

[x] I have searched the existing issues and verified no issue exits for this problem.

@war-in Are you working on this one? @cptartur said so, I am assigning you temporarily

@war-in Are you working on this one? @cptartur said so, I am assigning you temporarily

Unfortunately not :( Won't be able to finish this one before my holidays 😓

Just fixed it on forge's side, it's only a matter of Cheatnet rn. Removing the label


upgrade go lib to the latest version and bump csv to 0.9.0

Signed-off-by: Zhiwei Yin<EMAIL_ADDRESS>

/assign @qiujian16

/approve
/lgtm


Pooling allocator: add a reuse-affinity policy.

(Builds on #3697.)
This policy attempts to reuse the same instance slot for subsequent
instantiations of the same module. This is particularly useful when
using a pooling backend such as memfd that benefits from this reuse: for
example, in the memfd case, instantiating the same module into the same
slot allows us to avoid several calls to mmap() because the same
mappings can be reused.
The policy tracks a freelist per "compiled module ID", and when
allocating a slot for an instance, tries these three options in order:

A slot from the freelist for this module (i.e., last used for another
instantiation of this particular module);
A slot that has never been used before; or
A slot that was last used by some other module.

The "victim" module for choice 3 is randomly chosen, to avoid biases due
to the hashmap's ordering (which would be persistent across the lifetime
of the pooling allocator).
This policy is now the default when the memfd backend is selected via
the memfd-allocator feature flag.

After writing this, it occurs to me that the reuse policy as stated will choose with equal probability a module whose freelist we still from, but this does not imply equal probability for any slot to be stolen.
In other words, if we have one module with average occupancy of 500 preinitialized slots out of 1000, and 500 others with 1 slot each, and a new module comes along and wants a slot, we have only 1/501 chance of picking one of the 500.
To unbias this I should probably keep a global freelist (whole pool of choices mixed together), randomly pick from that freelist, and keep a reverse-index of slot to last-allocated module to remove the index from that module's freelist (or lazily do so next time we look at that list). I'll take a closer look at this tomorrow!

I've updated this PR now to use a better data structure/algorithm design. It performs a fair random choice of victim slot when no slots with the desired affinity are available, and it has all O(1) updates -- somewhat tricky given the need to maintain two freelists (global and per-module) and remove from both. This is done by keeping Vecs and using swap_remove, and tracking a slot's position in each freelist in a separate reverse-index. Hopefully the comments make this a little more clear.
I've added a randomized test that counts ID-reuse (a little random simulation of sorts) and verifies a reasonable hit rate (at least twice what would be expected with random reuse) as well.

The policy tracks a freelist per "compiled module ID", and when
allocating a slot for an instance, tries these three options in order:

A slot from the freelist for this module (i.e., last used for another
instantiation of this particular module), or
A slot that was last used by some other module or never before.

1..3 :eyes:

1..3 :eyes:

Incomplete edit, sorry! The distinction between the last two (empty, and then slot with other affinity) was removed because it made the data structure simpler, and in steady-state (past the first n_slot instantiations in the process) no slots will be empty.

I think I addressed all your comments; thanks @fitzgen ! This is rebased on the latest #3697 as well.


Support adding lights to the viewer

The class LeafNodeLight insert a new light that can be controlled as any other node.

Thank you Joseph.
You forgot to add file leaf-node-light.cpp.

I added the missing files.

Merged into devel branch.


key in the request is required.

It's pretty obvious that it would be, otherwise there isn't anything to renew, but I confirmed anyway that the HTTP fails if it is excluded.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7b504355-1c98-acbd-7063-273771028f26
Version Independent ID: d64bd82e-67eb-a4ed-e0dd-cb67bf7ea0bb
Content: Renew a Microsoft Store ID key - UWP app developer
Content Source: windows-apps-src/monetize/renew-a-windows-store-id-key.md
Product: windows
GitHub Login: @mcleanbyron
Microsoft Alias: mcleans

Thanks for reporting this error! I have fixed the article to reflect that the key is required, and this change should show up on the live docs site in a few days.


[Bug]: shadcn-vue  Depends on vulnerable versions of lodash.template

Reproduction
npm audit
Describe the bug
run
npm audit
and you get result:
`# npm audit report
lodash.template  *
Severity: high
Command Injection in lodash - https://github.com/advisories/GHSA-35jh-r3h4-6jhm
No fix available
node_modules/lodash.template
shadcn-vue  *
Depends on vulnerable versions of lodash.template
node_modules/shadcn-vue
2 high severity vulnerabilities
Some issues need review, and may require choosing
a different dependency.`
Could you please update lodash?
System Info
System:
    OS: macOS 14.4.1
    CPU: (10) arm64 Apple M1 Pro
    Memory: 70.14 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 21.6.1 - ~/.nvm/versions/node/v21.6.1/bin/node
    Yarn: 1.22.21 - /usr/local/bin/yarn
    npm: 10.2.4 - ~/.nvm/versions/node/v21.6.1/bin/npm
  Browsers:
    Chrome: 124.0.6367.61
    Safari: 17.4.1
  npmPackages:
    @vueuse/core: ^10.9.0 => 10.9.0
    radix-vue: ^1.7.1 => 1.7.1
    shadcn-vue: ^0.10.3 => 0.10.3
    vue: ^3.4.23 => 3.4.23

Contributes

[ ] I am willing to submit a PR to fix this issue
[ ] I am willing to submit a PR with failing tests

Thanks for pointing that out @annettedorothea ! Realized that we didnt enable Depandabot in this repo. After enabling it we see that indeed there's vulnerability https://github.com/radix-vue/shadcn-vue/security/dependabot/19

Please prioritize this issue!


Timeout is hardcoded instead of being taken from user input

https://github.com/Ice3man543/SubOver/blob/ae4a856ef22e46d6a8cdc3114bc039091a63480b/subover.go#L116

Fixed in v1.2 release. Thanks a lot @eur0pa


Add UNETI

@ArcantTheFirst The official website seems to lack significant information about the courses that are available in the university.
Please provide us with an URL of a page on the official website where the school offers an IT-related long-term (>1 year) course. Thank you!

@philipto Of course, just a small thing, the website is broken, and because all public workers are in a general leave for holy week (easter) they are only going to begin to fix it on monday.
Anyway, the courses we see as part of the PNFI (National computer training program, machine translation): https://www.uneti.edu.ve/campus/course/index.php?categoryid=8

@ArcantTheFirst Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Resin images refactor

No need to have a change log entry for this as it is only refactoring.

This is a refactoring so it doesn't need a Change-Type. Merge without that verification.


Space between items

Is there any way to decrease the spacing between the items in the sidebar (vertically)?  I tried setting the padding and margin to 0 but that didn't seem to do anything.  It seems like there is quite a bit of space between the sidebar items.

I have discovered the itemPadding and itemMargin and that generally works but when selecting items it seems to make them bigger or "pull them to the front" by increasing the padding although I have set the selectedItemPadding and margin to 0.  I will keep working on it.

separatorBuilder <<<<  It's work


Bug 2188502: Move SSH section to VM details on instancetype page

📝 Description
This PR is moving the SSH in the VM create with IT flow to live under a modal dialog instead the expandable section.
UX Doc: https://docs.google.com/document/d/1D1e8G0BmYbqokvJ7bLoo_uhvsMLATIhloQ-z2AwMiTY/edit#
NOTE: Eventually this modal dialog will be applied across the plugin
🎥 Demo
Before:

After:
https://github.com/kubevirt-ui/kubevirt-plugin/assets/67270715/4738b2bb-55ec-41e4-989e-0b23be193fd7

+1 to placing the help text below the modal title.
Thanks @hstastna

/lgtm

/cherry-pick release-4.13


[DDW-772] Update "Trezor Model T" image

This PR updates the "Trezor T" image shown on the "Pair a hardware wallet device" dialog.
Todos

[x] Update trezor.inline.svg
[x] Update trezor-ledger.inline.svg

Screenshots

Testing Checklist

Slack QA thread
[ ] Test

Review Checklist
Basics

[ ] PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
[ ] PR is updated to the most recent version of the target branch (and there are no conflicts)
[ ] PR has a good description that summarizes all changes
[ ] PR has default-sized Daedalus window screenshots or animated GIFs of important UI changes:

[ ] In English
[ ] In Japanese

[ ] CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
[ ] Automated tests: All acceptance and unit tests are passing (yarn test)
[ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
[ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
[ ] There are no flow errors or warnings (yarn flow:test)
[ ] There are no lint errors or warnings (yarn lint)
[ ] There are no prettier errors or warnings (yarn prettier:check)
[ ] There are no missing translations (running yarn manage:translations produces no changes)
[ ] Text changes are proofread and approved (Jane Wild / Amy Reeve)
[ ] Japanese text changes are proofread and approved (Junko Oda)
[ ] UI changes look good in all themes (Alexander Rukin)
[ ] Storybook works and no stories are broken (yarn storybook)
[ ] In case of dependency changes yarn.lock file is updated

Code Quality

[ ] Important parts of the code are properly commented and documented
[ ] Code is properly typed with flow
[ ] React components are split-up enough to avoid unnecessary re-renderings
[ ] Any code that only works in main process is neatly separated from components

Testing

[ ] New feature/change is covered by acceptance tests
[ ] New feature/change is manually tested and approved by QA team
[ ] All existing acceptance tests are still up-to-date
[ ] New feature/change is covered by Daedalus Testing scenario
[ ] All existing Daedalus Testing scenarios are still up-to-date

After Review

[ ] Merge the PR
[ ] Delete the source branch
[ ] Move the ticket to done column on the YouTrack board
[ ] Update Slack QA thread by marking it with a green checkmark

@mchappell I will merge this PR now but please add a screenshot of the fix in Japanese 🙏
This should be the rule for all PRs and all the changes. Thanks!


pythonPackages.flask-babel: 0.12.2 -> 1.0.0

Motivation for this change
While testing upgrading a separate package, saw there's a new version of flask-babel.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build python27Packages.flask-babel python37Packages.flask-babel python38Packages.flask-babel

Did you actually run nix-review? I tried to verify, but the build of python38.pkgs.flask_sqlalchemy failed because of this update.

Did you actually run nix-review? I tried to verify, but the build of python38.pkgs.flask_sqlalchemy failed because of this update.
I was a little premature in checking that. I'm running it right now locally in a VM and it's going terribly slow.

Result of running nixpkgs-review pr 83314:
https://github.com/NixOS/nixpkgs/pull/83314
6 package failed to build:
apache-airflow python37Packages.flask-appbuilder python38Packages.apache-airflow python38Packages.flask-appbuilder sage sageWithDoc

6 package built:
python27Packages.flask-babel python27Packages.ihatemoney python37Packages.flask-babel python37Packages.ihatemoney python38Packages.flask-babel python38Packages.ihatemoney

flask-appbuilder is fixed in follow-up #83315
apache-airflow is in pretty bad shape due to pinning too many requirements. See my previous comments and attempts to fix dr-pr-colorlog fix branch
Looking into sage now. Might just be an unpin fix, TBD. Long build :\

Did you actually run nix-review? I tried to verify, but the build of python38.pkgs.flask_sqlalchemy failed because of this update.

@timokau I didn't see flask_sqlalchemy in the dependencies when running nixpkgs-review pr 83314 (see above).

Yes, I don't see it anymore either. Maybe it was fixed by some other change in master, or maybe I somehow got it confused with flask-appbuilder.
I'm the maintainer of sage, if you upload the log as a github gist or something I might be able to help.

It builds when I just rebuilt it locally. Not sure what caused the build
fail. I built it with nix-build -A sage -A sageWithDoc, then ran
nixpkgs-review pr 83314, and got following:
https://github.com/NixOS/nixpkgs/pull/83314
4 package failed to build:
apache-airflow python37Packages.flask-appbuilder
python38Packages.apache-airflow python38Packages.flask-appbuilder

8 package built:
python27Packages.flask-babel python27Packages.ihatemoney
python37Packages.flask-babel python37Packages.ihatemoney
python38Packages.flask-babel python38Packages.ihatemoney sage sageWithDoc

Drew Risinger
On Wed, Mar 25, 2020 at 10:42 AM Timo Kaufmann<EMAIL_ADDRESS>wrote:

Yes, I don't see it anymore either. Maybe it was fixed by some other
change in master, or maybe I somehow got it confused with flask-appbuilder
.
I'm the maintainer of sage, if you upload the log as a github gist or
something I might be able to help.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/NixOS/nixpkgs/pull/83314#issuecomment-603878688, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ACNZYIYSHME2JVNTKIE2NQDRJIJ53ANCNFSM4LS7PNUQ
.

Hm. Might be some spurious timeout because nix-review was building so many things at once. That shouldn't happen, but maybe it did. Would love to see the log of the original failure. If its still there, you might be able to dig it up with
find /nix/var/log/nix/drvs/ -name '*-sage-tests*' -mtime 2

which will find all logs of the sage testsuite from builds that occurred in the last two days. You can then inspect the actual logs with nix log while stripping one slash, i.e. translate
/nix/var/log/nix/drvs/82/sxc5m1a5rn82i8rd5pmr0f2bbqssyh-sage-tests-9.0.drv.bz2

to
nix log 82sxc5m1a5rn82i8rd5pmr0f2bbqssyh-sage-tests-9.0.drv

@GrahamcOfBorg build sage

I looked for the sage-test deriv using your commands, and couldn't find anything. This was the closest I could find. Looks like tests passed. Not sure why build failed. Looks like the ofborg build passes too.
https://pastebin.com/1zkub9Ee

Hm, very weird. Either way its likely not this PR's fault.
Regarding flask-appbuilder, isn't there a way to order the commits to avoid the intermediate failure?

should just be an update, as the newest version of appbuilder uses flask-bable 1.0.0 https://github.com/dpgaspar/Flask-AppBuilder/blob/7b796071bae32c5bac30f1d2f2b29b42814b7709/setup.py#L52

@jonringer I fixed it in #83315. I think these commits basically need to be made in lockstep (i.e. same PR?) for them to not fail build. I can merge the two PRs if that'd work?

I see, I probably would have done it as part of this PR, but thats fine

Thanks for the tip. I'll keep that in mind in future.


Abseil symbolize doesn't work on Windows Bazel RBE

Abseil symbolize doesn't work on Windows (#24294). This happens on Bazel RBE only so it could be caused by RBE setup.
I ran the //test/core/extra test from the PR above on Kokoro Win2016 image and it passed properly.
$ bazel run //test/core/extra
Executing tests from //test/core/extra:extra
-----------------------------------------------------------------------------
[==========] Running 2 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 2 tests from ExtraTest
[ RUN      ] ExtraTest.Basic
get_trace()=[Stack trace:
    @   00007FF6329A1CD7  (unknown)  ExtraTest_Basic_Test::TestBody
    @   00007FF6329D62BC  (unknown)  testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test,void>
    @   00007FF6329D6062  (unknown)  testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,void>
    @   00007FF6329C041A  (unknown)  testing::Test::Run
    @   00007FF6329C0E45  (unknown)  testing::TestInfo::Run
    @   00007FF6329C14E7  (unknown)  testing::TestSuite::Run
    @   00007FF6329C7C62  (unknown)  testing::internal::UnitTestImpl::RunAllTests
    @   00007FF6329D646C  (unknown)  testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool>
    @   00007FF6329D6252  (unknown)  testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool>
    @   00007FF6329C1B04  (unknown)  testing::UnitTest::Run
    @   00007FF6329A43F1  (unknown)  RUN_ALL_TESTS
    @   00007FF6329A1FA8  (unknown)  main
    @   00007FF632A0F839  (unknown)  __scrt_common_main_seh
    @   00007FFAD50884D4  (unknown)  BaseThreadInitThunk
    @   00007FFAD523E8B1  (unknown)  RtlUserThreadStart
]
[       OK ] ExtraTest.Basic (82 ms)
[ RUN      ] ExtraTest.MultiThreading
[       OK ] ExtraTest.MultiThreading (821 ms)
[----------] 2 tests from ExtraTest (903 ms total)

[----------] Global test environment tear-down
[==========] 2 tests from 1 test suite ran. (904 ms total)
[  PASSED  ] 2 tests.

This issue is the reason why the stack-trace feature was introduced except Windows (#24245)

I'm pretty sure I know why on Bazel RBE windows (when you use the remote build) it doesn't work:

to get the stacktrace, you need the .pdb (which has debug symbols) alongside the .exe or dll.
bazel generates the PDB file correctly, but it's not copied to the RBE worker when tests are executed.
PDB is missing -> no stack trace on bazel RBE.

If you're getting the stack trace correctly with a local bazel build, but you're not getting one with remote build, this is almost certainly the reason.
Note that when using bazel RBE, AFAIK the current symbolizer (non-abseil) also doesn't work (but it works with local builds).

The issue b/160675763 has an example how to work around the missing PDB file for selected targets but unfortunately it's a bit ugly solution so we likely cannot use it routinely for all our win tests.

So if the windows symbolizer works for local bazel builds and it works with the workaround from b/160675763 (you can try it manually to be sure), we can probably go ahead with the win abseil symbolizer and get rid of our old (and a bit ugly) code from test_config.cc (e.g. https://github.com/grpc/grpc/pull/23420/files)?

Thanks, Jan for the context. It's surprising to know PDB is not supported on Bazel RBE yet, which puts it in an incompatible place. I think we should stay with a plain bazel on Window until it's addressed.

while I agree that lack of debug symbols bazel RBE windows is a problem, I think now using Bazel RBE on windows would be a big step back (our tests are way too resource greedy to be able to test quickly on a single machine, especially if it's a developer's laptop). Bazel RBE is also paramount for being able to reproduce issues. (you need a controlled environment and ability to run many many iterations of our sometimes very slow tests).

Indeed. I agree with you that RBE is super helpful to fix the flaky issue.
How about having a plain bazel test as well on Windows? Only Windows doesn't seem to have it.

I think it's fine to add a non-bazel windows bazel build-only job if you think that's useful (but so far I haven't seen a case where we were able to build with bazel RBE and not able to build with bazel locally on windows).
I don't think we should ad a local "bazel test" job as it would be too slow and we actually don't have "bazel test" jobs for C/C++ linux either (we only do "build-only" for linux on pull requests).


Uncaught Error: error: 126/?~\AppData\Local\atom\app-1.47.0\resources\app.asar.unpacked\node_mo...

[Enter steps to reproduce:]

...
...

Atom: 1.47.0 ia32
Electron: 5.0.13
OS: MIRWAISS
Thrown From: Atom Core
Stack Trace
Uncaught Error: error: 126\?\C:\Users\Alikudi\AppData\Local\atom\app-1.47.0\resources\app.asar.unpacked\node_modules\keyboard-layout\build\Release\keyboard-layout-manager.node
At electron/js2c/asar.js:138

Error: error: 126\\?\C:\Users\Alikudi\AppData\Local\atom\app-1.47.0\resources\app.asar.unpacked\node_modules\keyboard-layout\build\Release\keyboard-layout-manager.node
    at process.func [as dlopen] (electron/js2c/asar.js:138:31)
    at Object.Module._extensions..node (internal/modules/cjs/loader.js:881:18)
    at Object.func [as .node] (electron/js2c/asar.js:147:18)
    at Module.load (internal/modules/cjs/loader.js:701:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:633:12)
    at Function.Module._load (internal/modules/cjs/loader.js:625:3)
    at Module.require (/app.asar/static/index.js:72:46)
    at require (internal/modules/cjs/helpers.js:14:16)
    at customRequire (~/AppData/Local/atom/app-1.47.0/resources/app/static/<embedded>:1:735013)
    at get_KeyboardLayoutManager (~/AppData/Local/atom/app-1.47.0/resources/app/static/<embedded>:14:2676868)
    at get_manager (~/AppData/Local/atom/app-1.47.0/resources/app/static/<embedded>:14:2676970)
    at Object.getCurrentKeyboardLayout (~/AppData/Local/atom/app-1.47.0/resources/app/static/<embedded>:14:2677096)
    at e.keystrokeForKeyboardEvent (~/AppData/Local/atom/app-1.47.0/resources/app/static/<embedded>:14:1022283)
    at KeymapManager.keystrokeForKeyboardEvent (~/AppData/Local/atom/app-1.47.0/resources/app/static/<embedded>:11:1239133)
    at KeymapManager.handleKeyboardEvent (~/AppData/Local/atom/app-1.47.0/resources/app/static/<embedded>:11:1237118)
    at WindowEventHandler.handleDocumentKeyEvent (~/AppData/Local/atom/app-1.47.0/resources/app/static/<embedded>:11:284782)

Commands

Non-Core Packages

Hallo, I need please help

Im really sorry 🙏🏻I  Still don’t know how to end this work
เมื่อ จ. 25 พ.ค. 2020 เวลา 8:25 PM Mirwaiss<EMAIL_ADDRESS>เขียนว่า:

Hallo, I need please help
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/atom/atom/issues/20809#issuecomment-633546443, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/APWVE2S3CNR2AYWGJCCWGT3RTJPU7ANCNFSM4NJPG7PA
.

just reinstall

Thanks for taking the time to contribute!
We noticed that this is a duplicate of https://github.com/atom/atom/issues/21285. You may want to subscribe there for updates.
Because we treat our issues list as the Atom team's backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn't an exact duplicate but is closely related.
For information on how to use GitHub's search feature to find out if something is a duplicate before filing, see the How Can I Contribute? section of the Atom CONTRIBUTING guide.


Fix Docker Compose to use Camunda 7.7.0:tomcat

Also there seems to be an issue where some files are missing. Maybe this will fix itself by updating to that version.

@baddlan can you complete this update to the docker compose to pull the correct version?


Aws eb test bug fixes

fix excess charges issue
duplicate meter attributes - excess charges
wrapped tariff checking improvements

Merged into aws-eb-test for testing. Had no merge conflicts, but resolved on issue with bundler that I'd fixed in master.

Rebased with master, resolving merge conflicts.


Multi languages (UPLOAD-336)

Creation de Uplander multi languages with 118next.

Translation in spanish is up, i dont know if is necessary.
We will discuss global variable in each /app/components for call i18next.

This is great, thank you @jehernandezrodriguez ! Can you run yarn again to generate a new yarn.lock file and commit that, as that is currently preventing the CI checks from running?
When I'm running it locally on my machine, I still see a number of missing translations?

Excellent, CI tests are now passing. We'll do a code review and get back to you.

Hello! Thank you, I await your response. I uploaded a few changes for translations of device instructions.

@jehernandezrodriguez are you still actively working on this? Need any assistance?
I'm really looking forward to seeing i18n implemented in the Uploader.
Leet me know if there's anything you need help with.

@mrinnetmaki Hello, I hope to upload the local changes soon. Changes are not long. Then we check the translations.

@jehernandezrodriguez I think the easiest may be to put the translation files in resources/, to make sure they get copied into the final package. The path will be different between development and production, so  have a look here at how to distinguish between them: https://github.com/tidepool-org/uploader/blob/master/app/utils/drivers.darwin.js#L73-L84

Hi,
with some fiddling I was able to make the branch work in all "dev", "start" and "package" modes (tested on Linux).
As suggested by @gniezen, the easiest way to make this work is to move the locales-directory resources and adjust app/utils/config.i18next.js accordingly. Additionally, for the translation files to actually be accessible in app package, the locales-directory must be added to the build.extraResources in package.json.
No additional runtime configuration should be needed for this.
So the file layout should be something like
$projectRoot
  resources
    locales
      en
        translation.json
        translation.missing.json
      es
        translation.json
        translation.missing.json
    ...

and the backend block in configuration like
 loadPath: 'resources/locales/{{lng}}/{{ns}}.json',
 addPath: 'resources/locales/{{lng}}/{{ns}}.missing.json'

and in package.json (one added line)
"extraResources": [
   { ... },
   "sounds/",
   "locales/"
]

This results the translation files being copied as is to resulting package and thus are readable (and most probably modifiable) by user. Better solutions probably need better backend for i18next loading the resources (in place of i18next-fs-backend), and/or some kind of integration with webpack.

Hi,
with some fiddling I was able to make the branch work in all "dev", "start" and "package" modes (tested on Linux).
As suggested by @gniezen, the easiest way to make this work is to move the locales-directory resources and adjust app/utils/config.i18next.js accordingly. Additionally, for the translation files to actually be accessible in app package, the locales-directory must be added to the build.extraResources in package.json.
No additional runtime configuration should be needed for this.
So the file layout should be something like
$projectRoot
  resources
    locales
      en
        translation.json
        translation.missing.json
      es
        translation.json
        translation.missing.json
    ...

and the backend block in configuration like
 loadPath: 'resources/locales/{{lng}}/{{ns}}.json',
 addPath: 'resources/locales/{{lng}}/{{ns}}.missing.json'

and in package.json (one added line)
"extraResources": [
   { ... },
   "sounds/",
   "locales/"
]

This results the translation files being copied as is to resulting package and thus are readable (and most probably modifiable) by user. Better solutions probably need better backend for i18next loading the resources (in place of i18next-fs-backend), and/or some kind of integration with webpack.

Thank you. I've already made the changes, let's wait for gniezen's comments.

Thanks both, that's exactly what I meant! :smile:
I see the tests are now failing because it can't find the global i18n variable, probably because remote.getGlobal is only available in Electron?

Thanks both, that's exactly what I meant! 😄
I see the tests are now failing because it can't find the global i18n variable, probably because remote.getGlobal is only available in Electron?

Hi @gniezen
I think in 'devices.json' , I18next is not initialized. I uploaded a change for devices translation when is render in view.

OK, so the problem is that i18n isn't created during the test setup, because main.dev.js isn't called.
I got it to work by changing line 5 of device.js to:
let i18n = remote.getGlobal( 'i18n' );

if ((process.env.NODE_ENV === 'test') && !i18n) {
  i18n = require('i18next');
}

I don't know if there's a better way to set up the test in Jest so that remote.getGlobal returns something?

OK, so the problem is that i18n isn't created during the test setup, because main.dev.js isn't called.
I got it to work by changing line 5 of device.js to:
let i18n = remote.getGlobal( 'i18n' );

if ((process.env.NODE_ENV === 'test') && !i18n) {
  i18n = require('i18next');
}

I don't know if there's a better way to set up the test in Jest so that remote.getGlobal returns something?

Yes it's a part of the problem
I've already tried this way, but in dev and prod inext18 it doesn't initialize because reducers start first than the app in main.dev.js.
We could call and initialize 'i18next' in devices.js, but we have an asynchronous problem because in devices.js the variable 'devices' is exported before 'i18next' finishes searching for the words. I tried to wait for the 'i18next' promise but it didn't work for me.

Since i18next will always be initialized before running any app code during regular use due to it being gated by the window open, I think we can probably solve this as a test-only scenario. Experimenting locally, it seems that adding a mock for electron as follows (in __mocks__/electron.js)
const electron = jest.genMockFromModule('electron');

function getGlobal(string) {
    if(string === 'i18n'){
        return { t: (string) => string };
    }
}

electron.remote = { getGlobal };

module.exports = electron;

And adding jest.mock('electron'); just after the imports in test/app/reducers/misc.test.js allows the tests to pass as expected.

Since i18next will always be initialized before running any app code during regular use due to it being gated by the window open, I think we can probably solve this as a test-only scenario. Experimenting locally, it seems that adding a mock for electron as follows (in __mocks__/electron.js)
const electron = jest.genMockFromModule('electron');

function getGlobal(string) {
    if(string === 'i18n'){
        return { t: (string) => string };
    }
}

electron.remote = { getGlobal };

module.exports = electron;

And adding jest.mock('electron'); just after the imports in test/app/reducers/misc.test.js allows the tests to pass as expected.

Thanks @krystophv

Hi, are there any critical things still missing or could this be merged?

@jlaunonen I'm going to prioritise this for code review and QA during our next sprint.

Closing this PR in favour of #1358 , created to enable QA builds since it's not an external PR.

Closing this PR in favour of #1358 , created to enable QA builds since it's not an external PR.

Just a quick update to say that this has now shipped in Uploader v2.35.0. Thanks all!


Create Github Actions for Model Validation/Deployment

Create a github action that runs a command like:

fga model test --tests store.fga.yaml
This will help OpenFGA users run the tests as part of their CI/CD Pipelines, e.g.
https://github.com/openfga/sample-stores/blob/main/.github/workflows/main.yaml#L40

Create a github action that deploys a model to an OpenFGA store and gets the model id.

Closed by:

https://github.com/marketplace/actions/openfga-model-testing-action
https://github.com/marketplace/actions/openfga-model-deploy-action