Messages not received when registration is done after first app launch

Environment

Xcode version: 8.3.3 (8E3004b)
Firebase SDK version: 4.1.1 (happens starting from 4.0.0)
Library version: FirebaseMessaging 2.0.2
Firebase Product: messaging

Describe the problem
Steps to reproduce:
When I register for push notifications directly when the app starts for the first time (after install), the registration process works and I can send a notification to my device via the Firebase console.
However when I do not register on first app launch (i.e. launching the app for the first time, stopping it and register on second launch), the registration process seems to succeed (I can access the FCM token), but when I send a message via the Firebase console to that token, I will not receive the message.
When I use (almost) the same code (changes only in the commented out lines, due to changes to the API) with a Firebase version <4.0.0 (e.g. Firebase 3.15.0), both cases work fine.
Relevant Code:
I created a very simple project that reproduces the problem. I comment out the code for the first launch and then do the registration on the second launch, which produces the issue.
func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplicationLaunchOptionsKey: Any]?) -> Bool {
    FirebaseApp.configure()
    // use the following line for Firebase < 4.0.0
    //FIRApp.configure()

    // START: comment out the following block on first app launch
    UNUserNotificationCenter.current().delegate = self

    let authOptions: UNAuthorizationOptions = [.alert, .badge, .sound]
    UNUserNotificationCenter.current().requestAuthorization(
        options: authOptions,
        completionHandler: {_, _ in })

    application.registerForRemoteNotifications()

    let token = Messaging.messaging().fcmToken
    // use the following line for Firebase < 4.0.0
    //let token = FIRInstanceID.instanceID().token()
    print("FCM token: \(token ?? "")")
    // END

    return true
}

@pfrischmuth thanks for this. Can you note your iOS version and whether you've disabled method swizzling, since those are related to setup and may be needed for a repro?

I tested on iOS 10.3.
In the above example I did not disable method swizzling, but I also tried it with method swizzling disabled and the issue still occurs.

Hmm this could be related to a bug I'm fixing in Instance ID that was introduced in the last release, where a race condition is created on first launch. (This is being fixed for the next release)
Hmm, to confirm what you're saying:
First Launch

Don't register for push notifications
Retrieve FCM token anyway
Attempt to send push notification fails (expected behavior)

Second Launch

Register for push notifications
Retrieve FCM token
Attempt to push notifications succeeds (expected behavior)

I think I'm misunderstanding the issue, then. However, I want to clarify:

However when I do not register on first app launch (i.e. launching the app for the first time, stopping it and register on second launch), the registration process seems to succeed (I can access the FCM token), but when I send a message via the Firebase console to that token, I will not receive the message.

FCM / IID creates an FCM token whether or not you register for remote notifications, it's just that there is no APNs device token associated with that FCM token yet. When an APNs token is provided, the FCM token is updated on the backend to be associated with that APNs token, and notifications can now be sent via APNs using that FCM token.

I tried with Firebase 3.15.0, 4.0.0 and 4.1.1. With both 4.x releases I can produce the issue, with the 3.x release it works as expected (although the API is slightly different).
I don't even access the FCM token on first launch. I only call FirebaseApp.configure() on first launch, since I need this call for other Firebase features (remote config). So I do nothing cloud messaging related on first launch and of course I can not receive notifications then (as expected).
I do all the registration steps on the second launch (or later) and would expect that I can receive notifications afterwards, but this does not work for me (not with a 4.x SDK, with a 3.x SDK it works fine).
However when I complete the registration process on first launch, I can receive notifications (with all tested versions of the SDK).
I hope this clarifies my issue.

Thanks @pfrischmuth for the detailed info. Yes, it sounds like the issue that is being fixed in Instance ID for the next release of Firebase.
As a workaround for now, you should be able to call application.registerForRemoteNotifications() on first launch of your app. This is safe to do, and will not show a permissions dialog to the developer. It will provide an APNs token to you (and FCM) even on first launch. For example:
FirebaseApp.configure()
application.registerForRemoteNotifications()

Later on (in your second launch), you can always request permissions for user notifications as you have done before (i.e. UNUserNotificationCenter.current().requestAuthorization(...)).
Hope that makes sense!

OK, thanks for the response.
I will consider the workaround and look forward for a fix in the next release.

Hi @pfrischmuth I'm trying to determine if the issue I'm seeing is the same as yours. Would it be possible to clarify: when you say "when I send a message via the Firebase console to that token, I will not receive the message.", did you see an error message in the console? (I am seeing "Unregistered Registration Token").

Hi @ChrisRicca No, I do not receive an error message in the Firebase Console. I see the usual "Done" state there, but the message is never received on the device.

Fixed in Firebase 4.2.0 FirebaseInstanceID 2.0.3 released today.

Unfortunately this fix does not solve my problem.
I think I can narrow the issue down to an issue in FirebaseInstanceID, since when I try it with FirebaseInstanceID 2.0.0 it works fine. I tried the following versions:

FirebaseInstanceID Version
Status

2.0.0
working fine

2.0.1
not working

2.0.2
not working

2.0.3
not working

I have a very simple app that just executes the following code on first launch (fresh install of the app):
func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplicationLaunchOptionsKey: Any]?) -> Bool {
        FirebaseApp.configure()

        return true
    }

On second launch of the app I execute the following code:
func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplicationLaunchOptionsKey: Any]?) -> Bool {
        FirebaseApp.configure()

        UNUserNotificationCenter.current().delegate = self

        let authOptions: UNAuthorizationOptions = [.alert, .badge, .sound]
        UNUserNotificationCenter.current().requestAuthorization(
            options: authOptions,
            completionHandler: {_, _ in })

        application.registerForRemoteNotifications()

        let token = Messaging.messaging().fcmToken
        print("FCM token: \(token ?? "")")

        return true
    }

I think I can narrow it down to that calling application.registerForRemoteNotifications() needs to be done on first launch always. However this is not an option in my real application where I need to use Firebase Messaging.

I have reproduced this issue as well in our application using the latest release (Firebase 4.2.0 FirebaseInstanceID 2.0.3). At first, the push notifications silently fail as @pfrischmuth described. (I suspect over time they get cleaned up by the firebase system and start returning the "Unregistered Registration Token" error that I was seeing later.)
We can probably call  application.registerForRemoteNotifications() as suggested in didFinishLaunchingWithOptions to try to avoid this situation on installation (I am testing this now), but that won't fix the users who are currently in the "broken" state, who keep getting the same (apparently inactive) token back from Messaging.messaging().fcmToken.
Relying on the initial application.registerForRemoteNotifications() call also makes me nervous for this reason. If for whatever reason the notifications aren't setup correctly on first launch (a crash, for example), the user will be stuck in a broken state with no option but to uninstall and reinstall to fix the notifications.

@pfrischmuth and @ChrisRicca Thanks so much for the detailed info, particularly the app delegate differences between starts. I've reproduced the issue, and I'm working on a fix. Re-opening this issue.
In the meantime, the workaround is to call application.registerForRemoteNotifications() in our app start, even first launch.

I think I can narrow it down to that calling application.registerForRemoteNotifications() needs to be done on first launch always. However this is not an option in my real application where I need to use Firebase Messaging.

Curious, why is this not an option? FYI, this does not show a permissions dialog to the user, only the application.registerUserNotificationSettings or NotificationCenter.current.requestAuthorization shows the permissions dialog. You do not have to request user notification settings before calling registerForRemoteNotifications().

Relying on the initial application.registerForRemoteNotifications() call also makes me nervous for this reason. If for whatever reason the notifications aren't setup correctly on first launch (a crash, for example), the user will be stuck in a broken state with no option but to uninstall and reinstall to fix the notifications.

Yeah, I'm really sorry for the bug 😞 . Assuming your app doesn't crash while fetching an FCM token, you should be fine.

Thank you for the response.
I have two concerns regarding always calling application.registerForRemoteNotifications():

As @ChrisRicca stated, we are already using Firebase Messaging with a 3.x release. What happens with users that are updating our app? Will they be in a bad state, because they already used the app before?

I tried the approach in our app and had a strange behavior: When calling requestAuthorizationat a later point after registerForRemoteNotifications was already called, I do not receive the normal authorization dialog that I would expect, but a dialog that I should change settings for notifications in iOS settings.

@rsattar thanks for the response, and for being on the case. No need to apologize, bugs happen 🐞! We're implementing another push notification service using the raw APNS token so we can recover our users who are in a broken state, and then we'll switch back when the fix is up so I'm all set, but let me know if there's anything I can do to help. (Same to you @pfrischmuth)

Fixed in Firebase 4.2.0 FirebaseInstanceID 2.0.3 released today.

I can also still reproduce the issue in the given versions. Downgrading FirebaseInstanceID to 2.0.0 fixed it (thanks @pfrischmuth).

Same problem for me, and same solution.

Moved application.registerForRemoteNotifications() into didFinishLaunchingWithOptions (upon first time app launch).

Updated my Podfile to use FirebaseInstanceID to 2.0.0 EXACTLY.   (2.0.3 is problematic):
pod 'Firebase/Core', '~> 4.2.0'
pod 'Firebase/Messaging', '~> 4.2.0'
pod 'Firebase/RemoteConfig', '~> 4.2.0'
pod 'FirebaseInstanceID', '2.0.0'

NOTE:  Just doing #1 does NOT solve the described problem.
Tested on iOS Versions:  9, 10, 11.

Moved application.registerForRemoteNotifications() into didFinishLaunchingWithOptions (upon first time app launch).

I didn't even do that, just downgraded to 2.0.0 and everything seems fine.

`-(void)registerForPush
{
UNAuthorizationOptions authOptions = UNAuthorizationOptionAlert | UNAuthorizationOptionSound | UNAuthorizationOptionBadge;
[[UNUserNotificationCenter currentNotificationCenter] requestAuthorizationWithOptions:authOptions completionHandler:^(BOOL granted, NSError * _Nullable error) {
if(granted && !error )
{
dispatch_async(dispatch_get_main_queue(), ^{
[[UIApplication sharedApplication] registerForRemoteNotifications];
[UNUserNotificationCenter currentNotificationCenter].delegate = self;
            [[PushManager sharedInstance] registerNotificationCategories];

            if([FIRApp defaultApp] == nil)
            {
                [FIRApp configure];
            }
            [FIRMessaging messaging].delegate = self;

            DDLogDebug( @"Push registration success." );
        });
    }
    else
    {
        DDLogDebug( @"Push registration FAILED" );
    }
}];

}`
this worked for me ios11, xcode 9, firebase 4.2, firemessaging... 2.0.3

I am new to commenting on Github, so please excuse any newbie mistakes.
I am experiencing the same problem running Xcode 9. Just updated to Firebase pod v4.2.0 and forcing FirebaseInstanceId to v2.0.0
I followed Tom Kerpelman's article (https://firebase.googleblog.com/2017/01/debugging-firebase-cloud-messaging-on.html) and get to where I send a curl request to FCM and get the multicast 'Success' message back in the terminal.
Request
curl --header "Content-Type: application/json" \ --header "Authorization: key=AAAA...my_server_key...Yvtk8UR" \ https://fcm.googleapis.com/fcm/send \ -d '{"notification": {"body": "Hello from curl via FCM!", "sound": "default"}, "priority": "high", "to": "d2FIEp-BpTg:APA91bGo_hvwvLw-z...my_fcm_token...V-zr9MPUYMT"}'
Response
{"multicast_id":9208728090202853353,"success":1,"failure":0,"canonical_ids":0,"results":[{"message_id":"0:1506630341902123%a15af8c5a15af8c5"}]}
However, it does not show up on my device. The test through Apple's API works fine on the same device. Using Firebase's Notification function in the Console does not work neither when sending to the app as to a single device (using a valid FCM Token).
My podfile:
platform :ios, '10.3'
pod 'Firebase/Core', '4.2.0'
pod 'Firebase/Analytics'
pod 'Firebase/Auth'
pod 'Firebase/Crash'
pod 'Firebase/Database'
pod 'Firebase/Messaging', '4.2.0'
pod 'Firebase/Performance'
pod 'FirebaseInstanceID', '2.0.0'
pod 'Firebase/RemoteConfig'
pod 'Firebase/Storage'
pod 'SwiftMessages'
pod 'SDWebImage', '~> 4.0'
I am also firing application.registerForRemoteNotifications() before I fire FirebaseApp.configure() in didFinishLaunchingWithOptions
Any advice would be welcome. It all worked in a previous app built using Xcode 8.

I didn't even do that, just downgraded to 2.0.0 and everything seems fine.

While my tests on both of my devices here were working fine fine, I have now one user reporting that push notifications are not working at all. As it's only one user, I don't want to draw any conclusions just yet. Still thought it's worth mentioning it here.
Any ETA on when a fix will be released for this issue?

Fix released today in Firebase 4.3.0, FirebaseMessaging 2.0.4, and FirebaseInstanceID 2.0.4

Awesome, thank you!

The latest release fixes the issue for us. Thank you! :thumbsup:

@ChrisRicca  how were you able to solve your issue "Unregistered Registration Token".

I'm still getting the issue with Firebase 4.13.0, Messaging 2.2.0 and InstanceID 2.0.10. Just like @ashok1089; how do I fix the 'Unregistered Registration Token' error from the CM Console?


Troubles with loading the plugin

Can you help me with configuring this properly;
Here's my script entry:
  "scripts": {
    "custom-elements-manifest": "custom-elements-manifest analyze --config ./custom-elements-manifest.config.js"
  },

Which results in:
You are using es module syntax in a config loaded as CommonJS module. Use require/module.exports syntax, or load the file as es module by using the .mjs file extension or by setting type="module" in your package.json.
Setting extension to .mjs I get:
Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'cem-plugin-jet-brains-ide-integration' imported from C:...\custom-elements-manifest.config.mjs
And finally changing the import name to custom-element-jet-brains-integration I get:
SyntaxError: Unexpected token  in JSON at position 0
at JSON.parse ()
at file:///C:.../node_modules/custom-element-jet-brains-integration/dist/index.js:247:24
at ModuleJob.run (node:internal/modules/esm/module_job:194:25)
Which is this line:
var packageJson = JSON.parse(fs2.readFileSync("package.json", "utf8"));
What to do?

Thanks for reaching out! This project has actually moved. This new implementation may not have this issue.
https://www.npmjs.com/package/custom-element-jet-brains-integration

Can you show me how you are implementing the plugin? Make sure you are using customElementJetBrainsPlugin and not generateJetBrainsWebTypes.

import { customElementJetBrainsPlugin } from "custom-element-jet-brains-integration";

const options = {
};

// module.exports = {
//     outdir: "./wwwroot",
//     plugins: [
//         customElementJetBrainsPlugin(options)
//     ]
// }

export default {
    outdir: "./",
    plugins: [
        customElementJetBrainsPlugin(options)
    ]
};

I debug it and it was caused by BOM in package.json. Something like this happened to me on Windows a few times.


Delete csv file, move store.py

Deleted product.csv file did not need to be tracked by git
Change inventory.py to store.py and moved to dvd_store package.

Add Gene's changes to DEV.


election(engine): fix campaign keeps failing when lease is timeout

What problem does this PR solve?

Issue Number: close #5745
What is changed and how it works?
Check error when server campaign fails, reset etcd session if necessary

Can reproduce by following way

setup three server master nodes
send signal stop to all three server master nodes
After 15 seconds(default to etcd lease ttl), recover two non-leader nodes.
Observe one of the node can campaign to be leader successfully.

Check List
Tests

Unit test
Integration test

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
None

/merge


Issues with legislators-current csv data

I found my way to this repo after downloading the legislators-current.csv file in the GovTrack open data repository. The data is very thorough, but unfortunately, it's pretty difficult to use because a significant percent of the columns are misaligned.
Two causes of this that I noticed are:

Errors scraping contact and RSS feed URLS
In the rows for some legislators, URL parameters like "format=raw" or "type=rss" have ended up in their own cell, causing the remaining cells in the row to be shifted over a column.
Errors scraping addresses
Some addresses end up getting split up over two columns, and the city, state and zip code end up in the phone column, shifting the remaining cells over.

If you could fix these two issues it would make the data infinitely easier to use!

Hello. The conversion from YAML (the files here) to CSV (on GovTrack) is done by https://github.com/unitedstates/congress-legislators/blob/master/scripts/alternate_bulk_formats.py (in this repo).
Can you point out a particular line that you think is misformatted?
I am extremely overloaded at the moment so I am not likely going to be able to look closer in the near future. Maybe someone else will be able to help.

Hi! Apologies for the delayed response. I'm looking into this now and will let you know what I find.

Wow, I'm sorry about this! I don't know what I'd done to my CSV before, but I can't reproduce this. Everything looks fne with the script and the .csv file in the open data repository.


Update zhCN.lua

You are amazing @yaoenqi

Might has to fix a couple things, when you PR in the future try to keep it in one PR so it doesn't cause conflicts. Because I Messed up your PRs I think.


how can i disable chrome inspect

Dear ionic Team
how can i disable chrome inspect ?. my app released but it still inspectable.
Thanks,

This is not a bug, genymotion allows app inspection even in release mode, same as rooted phones, there is nothing we can do about it.


Add missing UserAddrMeta -> blaze_user_addr_meta conversion

We still had a todo!() in the code that could trigger when normalizing
an APK ELF file using the C APIs.
This change adds the necessary conversion to fix the potential panic.

cc @salvatorebenedetto


Client-Side Exception Occurs for Wallet Components in SDK Documentation

After using the wallet-provider component from the Sui SDK, attempting to use any other wallet components (e.g., ConnectButton) results in an error. The issue seems to be related to the documentation.
Steps to Reproduce:

Navigate to the Sui SDK documentation page for Wallet Provider.
Follow the instructions to implement the wallet-provider component in your application.
Attempt to use another wallet component, such as ConnectButton, as per the documentation.
Observe the error that occurs.

Expected Behavior:
The wallet components should integrate seamlessly, and the example code provided in the documentation should work without errors.
Actual Behavior:
When using any wallet component after the wallet-provider, the application throws an error:
Application error: a client-side exception has occurred (see the browser console for more information).

Video for reference:
Initial implementation of wallet-provider:
https://github.com/MystenLabs/sui/assets/61357747/9b702580-2311-42ca-9f3e-da77a54a5f8d

I think this should be fixed now! thanks for reporting this


Gateways never become ready/programmed when running daemonset EnvoyProxy

Description:

What issue is being seen? Describe what should be happening instead of
the bug, for example: Envoy should not crash, the expected value isn't
returned, etc.

I'm trying to run envoy proxy as a daemonset which was implemented with https://github.com/envoyproxy/gateway/pull/3092.
I think the cause of this bug is https://github.com/envoyproxy/gateway/blob/d1cc0ba4372fd7d3f8ede1a1278930e21c22b9f2/internal/gatewayapi/status/gateway.go#L163-L168 and doing a lookup on deployment vs daemonset.
Repro steps:

Include sample requests, environment, etc. All data and inputs
required to reproduce the bug.

Use the below configuration with an EnvoyProxy to trigger using a daemonset:
apiVersion: gateway.envoyproxy.io/v1alpha1
apiVersion: gateway.envoyproxy.io/v1alpha1
kind: EnvoyProxy
metadata:
  name: custom-proxy-config
  namespace: envoy-gateway-system
spec:
  mergeGateways: true
  provider:
    type: Kubernetes
    kubernetes:
      envoyDaemonSet:
        strategy:
          type: RollingUpdate
---
apiVersion: gateway.networking.k8s.io/v1
kind: GatewayClass
metadata:
  name: eg
spec:
  controllerName: gateway.envoyproxy.io/gatewayclass-controller
  parametersRef:
    group: gateway.envoyproxy.io
    kind: EnvoyProxy
    name: custom-proxy-config
    namespace: envoy-gateway-system
---
apiVersion: gateway.networking.k8s.io/v1
kind: Gateway
metadata:
  name: eg
  namespace: gateway-demo
spec:
  gatewayClassName: eg
  listeners:
    - name: http
      protocol: HTTP
      port: 80

Then the programmed status will always show as false even though the gateway is actually functional:
Status:
  Conditions:
    Last Transition Time:  2024-10-09T16:12:58Z
    Message:               Deployment replicas unavailable
    Observed Generation:   1
    Reason:                NoResources
    Status:                False
    Type:                  Programmed

Note: If there are privacy concerns, sanitize the data prior to
sharing.

Environment:

Include the environment like gateway version, envoy version and so on.

Logs:

Include the access logs and the Envoy logs.

let me take a look


e2e: clean up to test tables, endpoint-health test

/cc @heyitsanthony
Thanks.

@heyitsanthony PTAL. Thanks!

lgtm

Thanks!


[Bug] Succesful logged in but api/user return error

I succefuly logged, i get bearer token and everything OK, but then api/user return error with max_allowed_stack_size There is a loop in Laravel\Sanctum\Guard in this function "$user = $this->auth->guard($guard)->user()" ... its call user() function in Illuminate/Auth/RequestGuard and then again it call Laravel\Sanctum\Guard. Can you help me please what is wrong?
{     "message": "Maximum call stack size of 8339456 bytes (zend.max_allowed_stack_size - zend.reserved_stack_size) reached. Infinite recursion?",     "exception": "Error",     "file": "/var/www/html/vendor/laravel/sanctum/src/Guard.php",     "line": 54,     "trace": [         {             "function": "__invoke",             "class": "Laravel\\Sanctum\\Guard",             "type": "->"         }

Hey @haskadavid, as far I see in the error message, it is related to the Laravel application and not to the package. I would suggest debugging API to find a reason of infinite recursion because I am not that familiar with Laravel source code.
Also, I would like to highlight that the current version of nuxt-auth-sanctum does not work wit Bearer token and supports only cookie-based authentication.

closing this one since relevant to the backend


Chris hesketh patch 1

Creating the New Developer playbook page which includes some references to standards and how to request a few resources


Drag and Drop

Is your feature request related to a problem? Please describe
No response
Will you be willing to contribute this feature?

[ ] Yes, I'll give it a shot

Describe the solution you'd like
Hello,
Would you be capable of supporting drag and drop functionality?
It could be incorporated through: https://github.com/mwh/dragon
This would help complete the tui.
Describe alternatives you've considered
No response
Additional context
No response

Note,
It currently looks like this when used with LF:

See https://github.com/sxyazi/yazi/discussions/327


issue running aquatone

everything works fine until this starts happening
fatal error: concurrent map read and map write
goroutine 67859 [running]:
runtime.throw(0x8d9877, 0x21)
/usr/local/go/src/runtime/panic.go:617 +0x72 fp=0xc00791ab20 sp=0xc00791aaf0 pc=0x42be52
runtime.mapaccess2_faststr(0x846e00, 0xc00015a030, 0xc000e44cc0, 0x24, 0xc00791abf8, 0x2)
/usr/local/go/src/runtime/map_faststr.go:116 +0x4a9 fp=0xc00791ab90 sp=0xc00791ab20 pc=0x412609
github.com/michenriksen/aquatone/core.(*Session).GetPage(...)
/Users/michael/go/src/github.com/michenriksen/aquatone/core/session.go:129
github.com/michenriksen/aquatone/agents.(*URLScreenshotter).OnURLResponsive(0xc00015a300, 0xc000e44cc0, 0x24)
/Users/michael/go/src/github.com/michenriksen/aquatone/agents/url_screenshotter.go:43 +0x148 fp=0xc00791ac28 sp=0xc00791ab90 pc=0x7b6498
github.com/michenriksen/aquatone/agents.(*URLScreenshotter).OnURLResponsive-fm(0xc000e44cc0, 0x24)
/Users/michael/go/src/github.com/michenriksen/aquatone/agents/url_screenshotter.go:41 +0x3e fp=0xc00791ac50 sp=0xc00791ac28 pc=0x7c223e
hoping someone has came across this issue and can help

Just ran into this issue on windows, seems like it was running to many threads (?) I'm trying -threads 4, seems to be working fine.. though it hasn't finished. Thought i'd post this before I forgot to post. Hopefully it works. Seems to be. good luck and wish me luck!

i did not try to low the threads will try and add the results thanks for your feedback @webx0

i did not try to lower the threads will try and add the results thanks for your feedback @webx0

also just figured out my second problem, edited it in my post, good luck!

thanks @webx0 am on linux tho not windows but threads seems to fixed the issue i was running it on my script and it seemed to crap out when i ran it against alot of subdomains but setting the threads seemed to work.

thanks @webx0 am on linux tho not windows but threads seems to fixed the issue i was running it on my script and it seemed to crap out when i ran it against alot of subdomains but setting the threads seemed to work.

nice, setting the threads lower worked for me aswell, but didn't work after like the 4th try.. weird.. but setting -http-timeout higher (10000 ms) fixed that issue aswell, just documenting my fixes just in case someone else has these types of issues

I fixed it in my fork: https://github.com/L11R/aquatone
Code definitely had an issue with concurrent map access.


Can files be sent to Filemaker

I see that files can be retrieved, but can they also be sent?

I think FileMaker XML API doesn't have support for creating files through the API. I might be wrong here but can not find any useful information about this feature.
FM XML API spec: https://fmhelp.filemaker.com/docs/15/en/fms15_cwp_guide.pdf

AFAIK, FileMaker's CWP (Custom Web Publishing) system does not support a method to insert a file into a container (binary) field, and it's generally recommended to store an external reference. Don't think it can even be done with FileMaker's own PHP API. There may be a server-side method, or have a look at Insert From URL.

OK. Thanks very much.


[do-not-merge-yet] Pagination for postcode and address search

Merge only once acceptance tests have been updated, will break the maximum number of results test otherwise :)

Reviewed. Looks good, left some comments.


update Quickstart examples

show off new language features!

https://github.com/foundation-ui/glass/commit/42c4da07e2eaf9b67b9376b36461eb044cda0a6b


Redirect Manager: refactor code to not require service user

#3376 refactor code to remove redundant jcr:read permissions on /conf

@YegorKozlov Please rebase from master to fix the build error related to dependency-check (fixed with https://github.com/Adobe-Consulting-Services/acs-aem-commons/commit/8b86da38b0c45c9abe0f69376d3afe3c987d9b44)


Don't log price oracle failures

It's not relevant if a price oracle cannot retrieve the price, as there's already an exception returned for that

Update price oracle logs from WARNING to DEBUG

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

15 of 33 (45.45%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.07%) to 90.586%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

gnosis/eth/oracles/uniswap_v3.py
3
6
50.0%

gnosis/eth/oracles/kyber.py
0
6
0.0%

gnosis/eth/oracles/oracles.py
6
15
40.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.07%

Covered Lines:
3772

Relevant Lines:
4164

💛  - Coveralls


When 'script' type="module" fails to format properly

When type="module" all the code is on one line and cannot wrap correctly, hopefully this can be fixed.

I have the same problem


feat: Automatic optimisation of local images

We're using qwik-image as a way of replacing image paths with optimised versions based on their SRC using transformers. It's nice and simple:
export const imageTransformer$ = $(imageTransformer);

export function imageTransformer({ src, width }: ImageTransformerProps): string {
  switch (true) {
    case src.startsWith('https://static.'):
    case src.startsWith('https://static-dev.'): {
      return cloudflareTransformer({ src, width });
    }
    case src.startsWith('https://imgix.'): {
      return imgixTransformer({ src, width });
    }
    default: {
      return src;
    }
  }
}

Now we import from qwik-image to automatically optimise stuff:
import { Image } from 'qwik-image';

<Image src='https://somewhere.com/image.jpeg' width={100}>

This is great, but I've noticed that now none of the images within the repository itself are being optimised, because the paths are relative: /assets/banner.jpeg.
Looking at the qwik docs, I can see that vite-imagetools can be used to optimise images at build time by using a ?jsx suffix:
import Image from '/assets/banner.jpeg?jsx';

So with the above, I know that if I have dynamic/absolute paths I can use qwik-image and if they're local, I can use the JSX import suffix to automatically optimise them during the build process.
My problem with this, is that the frontend developer needs to know which one to use in which scenario and I feel like most developers just don't care and the internet/performance is basically magic.
In order to make it automatic and to only use qwik-image my plan was to check the current URL and prefix relative image paths (which has Cloudflare in front of it when deployed outside of localhost) and then optimise those like so:
export function createImageTransformer(url: URL) {
  return ({ src, width }: ImageTransformerProps) => {
    if (src.startsWith('/') && url.host !== 'localhost') {
      src = `https://${url.host}${src}`;
    }

    switch (true) {
      case src.startsWith(`https://${url.host}`):
      case src.startsWith('https://static.'):
      case src.startsWith('https://static-dev.'): {
        return cloudflareTransformer({ src, width });
      }
      ...
  }
}

export default component$(() => {
  const loc = useLocation();
  useImageProvider({ imageTransformer$: $(createImageTransformer(loc.url)) });
  ...
}

But I can't seem to pass in a value from useLocation to the imageTransformer$ QRL Function that is created dynamically:
Qrl($) scope is not a function, but it's capturing local identifiers: imageTransformer

Is it possible to automatically use vite-imagetools somehow within qwik-image, or is it possible to do something like the above?

Yep, an alternative solution cloud be implement you own Vite plugin with vite-imagetools and take inspiration from the official one.
Here is the code

@intellix Can we close this one?


Filtering only works at top level?

When playing with the Filter, it doesn't seem to show matching objects below the top-level of the tree.  Your example on the main page just has 4 nodes at the top level, so it works.  But when you have a more realistic tree and are trying to search for leaf nodes deep in the tree it's pretty useless.
Am I not using it correctly or is this a known problem?  If it's known, is there any workaround?

Closing this because I figured it out.  You can pass a function to filter-expression and then perform your own logic for tree leaf vs branches.  Have to modify the expandOnFilter stuff to handle the case where filterExpression isn't just a string.


Crashed on installation

Hello, thanks for the report. Can you share any screenshots or IDE version info for me to reproduce it? Do you mean the plugin crashed?

Hello!
So let me give you a bit more input:
As an IT student, I have access to several paid software and plugins. My
current Focusing on learning React, and I have taken the opportunity
install "bit more" then needed
Before it crashed, I made several adjustments to the plugin settings,I was
disabling several of the features. I assume you can see which one i
disabled from the attachment photo.
Additionally, I was using IntelliJ on a secondary monitor, which was
connected to Github in a different environment when it crashed.
I apologize for the delay  of this email, but i this give you some
information you can troubleshoot on! :P
In the attached screenshot there's a picture of all the active React
plugins when it crashed, All the disabled features of your plugin, and a
screenshot of the IntelliJ version.
On Thu, Jan 25, 2024 at 3:56 PM BeanSoft @.***> wrote:

Hello, thanks for the report. Can you share any screenshots or IDE version
info for me to reproduce it? Do you mean the plugin crashed?
—
Reply to this email directly, view it on GitHub
https://github.com/beansoft/react-native-console/issues/79#issuecomment-1910375190,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATYNWGEAEPOIJP2QD2JAGHLYQJXCJAVCNFSM6AAAAABCKTWZ4OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJQGM3TKMJZGA
.
You are receiving this because you authored the thread.Message ID:
@.***>

Hello, I need more info to check the reason for the crash, please attach the logs via the menu Help > Collect logs and Diagnostic Data if possible.

I'm relative new, so you might have to be a bit patient with me. I assume its this`?
idea-logs-20240126-1825406612698331314678563.zip

Hello, the log file is correct. However, after checking the log, I found exceptions in these plugins (the list may be incomplete):
React Buddy
Material Theme UI
JetBrains Academy
CodeGPT
but can't find any exception message caused by my plugin.
As a former full stack developer (worked with React, Java, etc), now plus my work experience in JetBrains (this plugin is my private project), I think you may only need IDEA to learn and code the React project, please disable these downloaded plugins (also you can disable my React Native Console as it's mainly for React Native developers), this way your IDE will perform more stable, sometimes plugins may cause problems. Please don't disable the bundled plugin such as JavaScript Debugger, this may make the IDE can't develop and run any React project.

Crashed on installation

The log zip file doesn't contain any crash files like java_error_in_idea_number.log or jbr_err_pid_number.log, so maybe you mean that your IDE doesn't work well after installing these plugins?

Hey again! Wow, Thanks for taking the time to reply 😊 I didn't see the
thing you wrote before now...
I ended up reinstalling entire OS, had several crashes in different
software as I didn't back up after CCleaner cleaned a bit too good
my Registry...😅
So fresh install of Jetbrains products as well, with minimum plugins as its
a bit heavy weight for my 9 old year computer. I think the best option for
me is just to disable plugins that I'm currently not using.
Anyway really good services taking your time to provide me with all this
information! I appreciate it 😊
On Sat, Jan 27, 2024 at 2:28 AM BeanSoft @.***> wrote:

Hello, the log file is correct. However, after checking the log, I found
exceptions in these plugins (the list may be incomplete):
React Buddy
Material Theme UI
JetBrains Academy
CodeGPT
but can't find any exception message caused by my plugin.
As a former full stack developer (worked with React, Java, etc), now plus
my work experience in JetBrains (this plugin is my private project), I
think you may only need IDEA to learn and code the React project, please
disable these downloaded plugins (also you can disable my React Native
Console as it's mainly for React Native developers), this way your IDE will
perform more stable, sometimes plugins may cause problems. Please don't
disable the bundled plugin such as JavaScript Debugger, this may make the
IDE can't develop and run any React project.
Crashed on installation
The log zip file doesn't contain any crash files like
java_error_in_idea_number.log or jbr_err_pid_number.log, so maybe you mean
that your IDE doesn't work well after installing these plugins?
—
Reply to this email directly, view it on GitHub
https://github.com/beansoft/react-native-console/issues/79#issuecomment-1912899750,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATYNWGH4BZANC5MM3SXWUL3YQRJ5LAVCNFSM6AAAAABCKTWZ4OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJSHA4TSNZVGA
.
You are receiving this because you commented.Message ID:
@.***>


[ENG-1614] Add placeholder routes for branded registries

Ticket: ENG-1614
Feature flag: n/a

Purpose
Add two routes registries/:provider_id and registries/:provider_id/discover
Summary of Changes
These routes are placeholders for branded components to be built in
Side Effects

QA Notes

I'm currently getting a Mirage error:
assert.js:43 Mirage: Your Ember app tried to GET 'http://localhost:8000/v2/providers/registries/osf/',
         but there was no route defined to handle this request.
         Define a route that matches this path in your
         mirage/config.js file. Did you forget to add your namespace?

I would think that fetching a provider would already be defined in mirage. Or do I need to change the way that I fetch?

@robustdj oh you know what, that no route defined mirage error is a pre-existing bug -- this here should be providers/registrations, not providers/registries
i guess this is the first time we're fetching a registration provider by id, rather than via a relationship (the api includes links for relationships, so the adapter doesn't have to build the url)

I think the build may need to be restarted from Travis? It's been pending for awhile now


Fix Cocoa Pod configuration to include XIBs, etc.

The pod seems to work fine, except when using the non-native authorizer view. The NIBs are missing.

I pushed 1.0.1 update to Cocoa trunk to include NIB file.


Playwright Test for VSCode only reads environment variables on installation

Steps to reproduce:

Install Playwright for VSCode
Add environment variables
"playwright.env": {       "baseUrl": "<url here>",       "proxyUser": "<username here>",       "proxyPass": "password here"   },

expected result:
Playwright for VsCode will use the environment variables in the following test processes
Observed result:
Playwright for VsCode does not use the environment variables in the following test processes.
It seems Playwright for VsCode only loads the environment variables when you install the extension.

We recommend dotenv for that. You can put require('dotenv').config() inside your config and then it will read your .env files.


fix an issue in memory map manager introducing a new chunk despite si…

fix an issue in memory map manager introducing a new chunk despite size 0
@amit-cliqz this should fix the issue you reported

Coverage decreased (-0.09%) to 94.84% when pulling b555f00fdb206013aa1d1db5c493c5cf98b7b379 on hendrikmuhs:fix-chunk-expansion into f27619a605a6af5065b08d699137e53d543bfe97 on KeyviDev:master.


Cloudfare Issue with CRHOY.com

CRHOY:
This is a Cloudflare issue so I don't know if this is the right place to post but if anyone can help I'd be vary thankful.

crhoy.com

Some sample urls that I have tried

crhoy.com/economia/estas-son-las-razones-por-las-que-sugef-recomienda-destituir-a-presidente-del-popular
crhoy.com/economia/empresarios-piden-avanzar-en-proyectos-para-mejorar-la-competitividad

The exact code i used to test this articles/website

import newspaper

user_agent = 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Firefox/78.0'
config = newspaper.configuration.Configuration()
config.browser_user_agent = user_agent

article = newspaper.article('https://www.crhoy.com/economia/estas-son-las-razones-por-las-que-sugef-recomienda-destituir-a-presidente-del-popular/', config=config)
print(article.text)

Site is protected by Cloudflare
I tried more complex methods with readability and selenium, even used 12ft.io and http://txtify.it

Hey Gabriel! I was having the same problem also, then I found out that the 0.9.3 updated include the addition of cloudscraper (see changelog). You can read the documentation of cloudscraper library here, it basically modifies requests to bypass Cloudflare. For using it in newspaper4k, you just have to install cloudscraper (pip install cloudscraper), as the code automatically uses it if installed.
Hope it helps!

Thanks, I added cloudscraper but sadly it still doesn't work for the site I mentioned. Did the sample URLs work for you?


[ADAP-379] [Feature] Improve startup performance

Is this your first time submitting a feature request?

[X] I have read the expectations for open source contributors
[X] I have searched the existing issues, and I could not find an existing issue for this feature
[X] I am requesting a straightforward extension of existing dbt-snowflake functionality, rather than a Big Idea better suited to a discussion

Describe the feature
Dbt is fairly slow in general for Snowflake (especially on small datasets) - and this can be particularly annoying at startup. This is largely because DBT issues a lot of metadata queries, and metadata queries are orders of magnitude slower in Snowflake than "direct queries" - even if those queries would need to look at the same metadata internally (this is I guess due to how Snowflake implements things, they chose to make explicit queries to INFORMATION_SCHEMA be much slower).
Take for example this DBT run:
09:18:31  Running with dbt=1.4.4
09:18:31  Found 9 models, 37 tests, 0 snapshots, 0 analyses, 342 macros, 0 operations, 1 seed file, 3 sources, 0 exposures, 0 metrics
09:18:31
09:18:55  Concurrency: 10 threads (target='cloud')
09:18:55
09:18:55  1 of 1 START sql table model 27ec6563-d2b5-49a6-af3b-ec321f6b655d.stats ........ [RUN]
09:18:57  1 of 1 OK created sql table model 27ec6563-d2b5-49a6-af3b-ec321f6b655d.stats ... [SUCCESS 1 in 2.21s]
09:18:57
09:18:57  Finished running 1 table model in 0 hours 0 minutes and 26.10 seconds (26.10s).
09:18:57
09:18:57  Completed successfully
09:18:57
09:18:57  Done. PASS=1 WARN=0 ERROR=0 SKIP=0 TOTAL=1

26s total runtime, 2s "useful" runtime.  Now, this was an extreme case, but it always takes a few seconds just to start. Why? Here's a hint (I modified dbt to print the queries as they are issued)
10:20:59  Running with dbt=1.4.4
10:20:59  Found 9 models, 37 tests, 0 snapshots, 0 analyses, 342 macros, 0 operations, 1 seed file, 3 sources, 0 exposures, 0 metrics
10:20:59
ADAPTER: <dbt.adapters.snowflake.impl.SnowflakeAdapter object at 0x10703f1c0>
EXECUTE SQL
    show terse schemas in database "MY_DATABASE"
    limit 10000

EXECUTE SQL
    show terse objects in "MY_DATABASE"."27ec6563-d2b5-49a6-af3b-ec321f6b655d"

10:21:03  Concurrency: 1 threads (target='cloud')

First thing it does, is "create_schemas()"; in order to see what schemas are already created, it lists existing schemas in the database. We actually can have A TON of schemas in the database - and this generally works fine with snowflake, but makes the DBT startup slow (also, if we were to have more than  10k schemas, which is not completely unimaginable, dbt would break down).
Thing is - it's completely avoidable; create_schemas() could simply "CREATE SCHEMA IF NOT EXISTS", there's no need to use "reflection"/ to list all the schemas in order to find whether the one that we're interested in exists or not.
Describe alternatives you've considered
No response
Who will this benefit?
Everybody using dbt with snowflake for development - it would make dbt builds so much faster, especially for small datasets.
Are you interested in contributing this feature?
maybe; but I don't have lots of time right now.
Anything else?
In general, it's way faster for snowflake to attempt to execute the query rather than to query the information schema explicitly. Unfortunately, from a quick glance, it seems that dbt implementation is heavily skewed towards querying the information schemas - so I don't think this is easily fixable in dbt-snowflake (and I'm not sure anybody would want to "fix"/ change the approach in dbt-core).

It's a fair question whether it's faster to run show terse schemas, versus to just run create schema if not exists. If you're running many models, the latter might need to run many times; but only one time if you're only running one model, it would run once, at most, and probably as a faster query!
I think that would look like a change to the create_schemas method in dbt-core. If len(required_schemas) == 1, then just jump straight to create schema if not exists, and skip the whole introspective step.
(An older issue in a similar vein, since it relates to the caching queries that run at startup, which tend to be among the more expensive: https://github.com/dbt-labs/dbt-snowflake/issues/83)

FYI in my tests, it was about an order of magnitude faster to run CREATE SCHEMA IF NOT EXISTSthan to run a select against INFORMATION_SCHEMA. So your test should probably be something like if len(required_schemas) > 10... and even then, it depends a lot on the actual number of schemas in your database (if you have thousands of unrelated schemas, then the show terse will actually be way slower, not just one order of magnitude).


Sagemaker add pipeline tags

Describe changes
I added tags to sagemaker pipelines
Pre-requisites
Please ensure you have done the following:

[x] I have read the CONTRIBUTING.md document.
[ ] If my change requires a change to docs, I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.
[ ] If my changes require changes to the dashboard, these changes are communicated/requested.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Other (add details above)

@bcdurak i have not tested this, so if u can test it id be grateful


jitterbug for UTM

When I use jitterbug for UTM,It prompts ‘Failed to get the task for process xxx‘ .
paid account
iPhone14 Pro
ios16.3
UTM4.1.6

Same here but with TrollStore on iOS 15.4.1, the troubleshooting section of the repo is extremely vague, it only says "This application does not have the get-task-allow entitlement. Or this is not an development app." but it doesn't say how to fix this.
Surprisingly, Sidestore which uses Jitterbug to enable JIT, does work for me with the same app, so maybe the Sidestore team implemented a fix for the "Failed to get the task for process xxx" error.

The get-task-allow entitlement relates to how the app was signed, and will open the app but hang. This is because there is no relay back (jitterbug is expected the proceed id, which it doesn’t get). I use iPAWiND and was facing this issue. To fix this, you must enable ‘compatibility mode’ when signing the app. How have you signed it?


Add a stress test profile

Objective
This adds a custom profile for testing against stress tests. Bevy seemingly gets notably faster with LTO turned on. To more accurately depict production level performance, LTO and other rustc-level optimizations should be enabled when performance testing on stress tests.
Also updated the stress test docs to reflect that users should be using it.

@james7132 once mdlint failures are fixed I'll merge this in.

@alice-i-cecile done!

bors r+


Access back references in String.replaceAll reg exps in VM

From Robert Beeger: https://groups.google.com/a/dartlang.org/group/misc/browse_thread/thread/dcbe4ef4a20d06b5/dee557885a7c4a4d?lnk=gst&q=String.replaceAll#dee557885a7c4a4d
I would like the following statement
  print('abc'.replaceAll(new RegExp('(b)'), 'd\1d'));
to print "adbdc" to the console. Unfortunately it prints "ad\1dc"
Instead of 'd\1d' I tried
'd\1d'
@'d\1d'
'd$1d'
@'d$1d'
The implementation for the Dart-VM doesn't seem to handle backreferences to groups in the regular expression.
Am I missing something? If it's not yet there, is it planned for the near future?

+1! As currently implemented, this seriously hampers the usefulness of regex!

With string interpolations, I usually don't find it to be that serious a hamper:
print('abc'.replaceAllMapped(new RegExp('(b)'), (m) => 'd${m[1]}d'));

We can't change the existing replaceAll function now, that would be breaking now. I also don't want a function that has to parse the replacement string, only to realize that it's not special most of the time.
We can add a new method that interprets its replacement string in some way. I just don't think it's particularly important.
The easiest thing to do would be having a helper function like:
replacement(String pattern) => (Match match) =>
     pattern.replaceAllMapped(new RegExp(r'\\(\d+)'), (m) => match[int.parse(m[1])]);

(Disclaimer: Can be optimized!)
Then you can just write:
print('abc'.replaceAllMapped(new RegExp('(b)'), replacement(r'd\1d')));

That makes the parsing of the replacement string happen outside of the replaceAll function, which is a much more modular approach than having one function that does everything.

Thanks for the reply. I like that replacement helper. I wonder if it might be a good idea to change replaceAllMapped to make the callback argument optional. If not passed, the replacement helper above is used by default? (You have already written it, afterall)

If you don't pass a replacement function to replaceAllMapped then you don't know what to replace with.
I don't want to change it to take either a string or a function, and switch on the type. Then it's better to make a new function with a new name instead. I just don't think that such a function is that great an idea to begin with. It would have to pick some format for the replacement string, and then it's limited to what that format allows. Using a function with a string interpolation, you don't have any restrictions at all.
I think the best solution is to make your own helper function:
replaceAllSmart(String source, Pattern pattern, String replacementPatter) =>
    source.replaceAllMapped(pattern, replacement(replacementPattern));

With a good modular design, you can build your own functions, and they will match your problems much better than any specific solution we bake into the platform libraries. Trying to solve all problems in the platform libraries with specialized code is a game of whack-a-rat with no winning condition :)

If you don't pass a replacement function to replaceAllMapped then you don't know what to replace with.
I don't want to change it to take either a string or a function, and switch on the type.

You're completely right. I must've skipped my coffee this morning...

With a good modular design, you can build your own functions, and they will match your problems much better than any specific solution we bake into the platform libraries. Trying to solve all problems in the platform libraries with specialized code is a game of whack-a-rat with no winning condition :)

I understand what you're getting at here and I mostly agree, but at the same time, this is the first time I've ever encountered an implementation of regex replace that didn't support backreferences in the replacement string. I'm just hoping for an implementation that more closely matches how every other language (that I've used) behaves.


Extra attributes

Transferred files losing their extra attributes (like +x flag on executables).
This is much more painful on Haiku, where the files can have tons of extra attributes. Any way to support to transfer them too?

I suggest you tar/zip the files before sending them. LANDrop doesn't keep file attributes because they are not cross-platform.


⚡ Standardization of rep

Hi @chrismettal, We need to adjust a few things first to move forward, OK? ✨
First, we need to update the screenshot! We need to put a screenshot.png on the root of the folder.
I ask for these changes to standardize with the other repositories see an example; this is also important because it helps other potential users who would like to contribute, too! 😁
Let me know if something isn't possible or if you have any questions! 🙂

Sure thing! I have moved the screenshot to the appropriate location.
The installation instruction screenshots have been kept under /img and there is another preview screenshot under /labplot/screenshots/ which mirrors the folder structure required in labplot itself. I hope these locations are ok?
Let me know if there is anything else that needs to be standardized.
Thank you for the quick moving of the repo!

All seems good now! Thanks! 💜


Implement list entry

Related to #92

The dot that indicates the start of the second level list is at the wrong place. It should be next to the list headline.
Expected vs implemented:

The create event is not consistent with the list of the first level.
Expected behavior:

on create, insert new item on top in expanded state and focus on the first input
on create, do not affect other list items. They keep their state, whether if they are opened or closed

https://user-images.githubusercontent.com/938244/131988403-d5961c3f-c3ae-4134-8ecd-86bb39da1567.mov

I've fixed the dot position. Regarding the behaviors, let's discuss it on Monday.

@andreasgeier @pinussilvestrus Ready for review. Includes sorting.

The sorting looks good now. The only thing that is missing is the autoFocus behavior when adding a new item. Will that be added on top?

I missed this one. I will need to add it together with a test case.

🎉


[FEATURE REQUEST] - Save LoRA information in civitAI compatible format from the CivitAI nodes.

Summary
Save Checkpoint and LoRA information in civitAI compatible format from the CivitAI nodes.
This is just about the only feature I feel like I'm missing now, at the moment I'm forced to use cute-comfy to save full civitAI compatible metadata including all checkpoints and loras used. However cute-comfy has it's own limitations because it's not a node but listener so it has no ability to tell it exactly which metadata to record if using unsupported nodes.
Basic Example
The civitAI nodes can be populated with AIR codes that are civitAI compatible for linking resources.
Reference Issues.
No response

Could you provide some examples for reference? I’m not sure how civitai recognises lora and ckpt.

https://github.com/zer0TF/cute-comfy

Alright, now I understand. Cute-comfy will write the hash value of Lora, just like the existing calculate_model_hash. The current nodes cannot read the filename or hash of Lora, so if I need to implement this feature, I will have to write a new Lora loader node.

https://github.com/civitai/civitai_comfy_nodes

Please try the latest version.

Please try the latest version.

Great job, works like a charm.


Expiration Date Format

I use some gateways that require submission as MMYYYY others as MMYY , etc etc
How can I configure card to post the format that I want?

Card doesn't provide formatting or validation — and it supports both MM/YYYY & MM/YY formats for the expiry!


Use newest version of setup script for example

The foxx service creation class creates a setup script skeleton. The setup script for this sample should use the same structure.

The warnings the generator adds are actually a bad idea because the setup is supposed to be reentrant and some parts of Foxx will run the setup script multiple times (e.g. during development mode) leading to unnecessary noise.
We should probably fix the generator, not the example.

Thank you for the PR. For legal reasons we need a signed Contributor License Agreement (CLA) before we can merge your code into the project.
You can download the form from our website: https://www.arangodb.com/documents/cla.pdf
Once you've filled out and signed it, please send it to us via e-mail<EMAIL_ADDRESS>or fax: +49-221-2722999-88.

@pluma CLA is available, can we merge?

@fceller Once the requested changes have been made, the PR can be merged.

@gregorybleiker Thanks again for your contribution. However I can't merge this without the requested changes. Can you take another look at this PR?

@pluma what is status of this PR?

@gregorybleiker I'm closing this PR as it has been inactive for over a month. Feel free to reopen this PR or open a new PR at any time if you can make the requested changes.

Oh, should I have done something?


Objects can be selected only in hierarchy

Hi, a dummy here. Why can't I select the objects in the Scene? They can be only selected in the hierarchy window ¯_(ツ)_/¯

You can't, because unity doesn't support raymarching. The shader is selfemade by SebLague.

You can't select, because unity doesn't support raymarching. The shader is selfmade by SebLague. All you can is just see it.

Can you ELI5, please?


wip: create user profile

WIP: create user profile

@sifatul vaiya i have added mongoose we need to connect to db using mongoose in other components i will change those as well

and also I have created some reusable component using formik and mui


Print OpenTelemetry Configuration

Which problem is this PR solving?

Fixes #2253

Short description of the changes

Consolidation of config factory
Addition of config.dump-otel flag
Moved zipkin host port configuration into the zipkinreceiver CreateDefaultConfig().  This mimics the way the jaegerreceiver works and removes the ZipkinHostPort field from ComponentSettings.

Notes

fmt.Println is crude but was chosen b/c it would be unaffected by config like a logger and cleanly dumps the config to stdout.
I am purposefully exiting after printing the config to protect secrets.  Otherwise it might be easy to leave this parameter in and deploy it to production and accidentally dump secrets.

Todo

[x]  Tests

@pavolloffay If you have a chance to review this and make sure I'm headed the right direction please do.  I intend to add tests and drop draft status if this change is what is desired.

@pavolloffay I think this PR is in a good spot.  Added a basic test to make sure that config factory returned an error if the dump otel flag was passed.  Let me know what you think.

crossdoc-otel job restarted.

The upstream collector does not have a default config in terms of enabled components, however each component creates a component config with default settings that are unknown to the user.
So I think this feature might be also useful in the upstream OTel collector. There might be more ways how to approach this either add a flag that prints the full config or print the component config when a component is being started.  I have filed an issue in OTEL https://github.com/open-telemetry/opentelemetry-collector/issues/1791

Sounds good, we can leave this for a bit and then close it if otel collector is ok with adding this functionality.

Going to close this PR in favor of the one linked by @pavolloffay.  The refactoring in this PR was taken care of in #2495


Android Basics: tip-calculator

URL of codelab
https://developer.android.com/codelabs/basic-android-kotlin-training-tip-calculator?continue=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-kotlin-unit-2-pathway-1%23codelab-https%3A%2F%2Fdeveloper.android.com%2Fcodelabs%2Fbasic-android-kotlin-training-tip-calculator#2
In which task and step of the codelab can this issue be found?
View Binding
Describe the problem
The code says buildFeatures {
viewBinding true
}
but it doesn't work without
buildFeatures {
viewBinding = true
}
Steps to reproduce?
Always reproducible
Versions
Android Studio Arctic Fox | 2020.3.1
Build #AI-203.7717.56.2031.7583922, built on July 26, 2021
Runtime version: 11.0.10+0-b96-7249189 amd64
VM: OpenJDK 64-Bit Server VM by Oracle Corporation
Windows 10 10.0
GC: G1 Young Generation, G1 Old Generation
Memory: 1280M
Cores: 16
Registry: external.system.auto.import.disabled=true
Non-Bundled Plugins: org.jetbrains.kotlin
Additional information

@Pwnyboy1031
Thank you for reaching out to us. The issue is fixed and will be published soon.


SpawnSpheres are not automtically put in the according SimGroup

While trying to change the default folder the SpawnSpheres are in I found:
https://github.com/GarageGames/Torque3D/blob/development/Templates/Full/game/tools/worldEditor/gui/objectBuilderGui.ed.gui#L954
This checks when creating a new SpawnSphere, if a SimGroup called "PlayerDropPoints" exists and if not it creates it.
After that "%this.objectGroup = "PlayerDropPoints";" is probably supposed to automatically make the newly created SpamSphere being put in the newly created SimGroup, but it actually does not work, the new SpamSphere is created in the root MissionGroup folder.
So is this broken or did I get something wrong?

You're not wrong, it is suppose to be placed into PlayerDropPoints SimGroup according to this code:
https://github.com/GarageGames/Torque3D/blob/development/Templates/Full/game/tools/worldEditor/gui/objectBuilderGui.ed.gui#L525-L526


Touch Screen Test Error

Hi, I am using Ubuntu 16.04 in my Development board Nvidia TX1, I am trying to integrate a touch screen to board. I have followed your steps upto install tslib, after that when i give test command it gives me error as given below,
" ubuntu@tegra-ubuntu:~/tslib/tslib$ sudo TSLIB_CONFFILE=/etc/ts.conf TSLIB_FBDEVICE=/dev/fb0 ts_test
*** Error in `ts_test': double free or corruption (!prev): 0x0000000000415040 ***
Segmentation fault"
I am using Waveshare 5inch LCD TS only, did i miss anything.
Thanks in advance.

Hi,
Sorry I can't help you, and for late answer. There might be something wrong with compiler for you processor or your environment (e.g. compiler config file, libs versions, etc.). When I googled "nvidia tx1 double free or corruption" then there came few results - check this, there might be something that help you.


tools: Add protoxform tests

For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description: Add testing for protoxform scripts. We apply golden testing method for this.
Risk Level: Low
Testing: none
Docs Changes: none
Release Notes:
[Optional Fixes #Issue] #8428
[Optional Deprecated:]

@Shikugawa LGTM, can you fix_format so that CI passes and we can merge? Thanks again for this work, this is really nice and will be a huge velocity improver for work protoxform (we can now make changes with confidence).


Is it possible to provide a demo？

First of all, I would like to thank the author for providing the react version of sortableJS, but I encountered some problems when using it. When I first used react-sortable, I found it very confused to look at the documentation. So I especially want to see some simple demos to get started quickly. I hope to be able to provide demos of various scenarios like sortableJS, and thank the author again for his hard work.

@PinelliaTime Thank you for your kindness!
There are live examples a http://sortablejs.github.io/react-sortablejs/. I'll be adding the code for each one at the start of year 2020.
There's are examples in the project. If you run the following command, it should work.
git clone git@github.com:SortableJS/react-sortablejs.git &&
cd react-sortablejs &&
yarn &&
yarn start

Thanks a lot for giving me this live examples!  I'm waiting for your code.

I know it is totally possible to assign values to the cards and calculate / display the total sum(value) of all the cards in a container?
But, I really don't know how to achieve that after hours of googling. Can you give me some hints? Thank you

Is there any update on this? Can authors publish the source code for the examples on https://sortablejs.github.io/react-sortablejs/

Is there any update on the source code for the examples on sortablejs.github.io/react-sortablejs

If you go into your browser Developer Tools > Sources (Firefox: DevTools > Debugger > Sources), you should be able to see the source code for the examples under sortablejs.github.io/examples/components.

gosh this is a joke


Exposed status is never checked properly

What?
The app fetches server for every 15 mins including today keys request and update lastChecked. The problem is that the serve refuses to return today keys. As the result, the app will always fetch today while it supposes to fetch yesterday key. Therefore, exposed status will never shown up.
    const finalize = async (status: Partial<ExposureStatus> = {}) => {
      const timestamp = new Date().getTime();
      this.exposureStatus.append({...status, lastChecked: timestamp});
    };

Suggestion

Store lastChecked as latest period that server return keys file (excluding error while downloading key file: [Error: null]) instead of current check timestamp.

The fix should be: instead of storing timestamp of last check store the last period we got keys for successfully.


[FEATURE] Incremented version to 1.2.5

Incremented version to 1.2.5 in 1.2 following from https://github.com/opensearch-project/opensearch-build/issues/1600 to prepare for the next possible release.
Backport the change to higher version branches

Closing this issue as we released 1.3.0 (Minor version).
https://github.com/opensearch-project/performance-analyzer/tree/1.3


fix: Fix component table order

Why is this pull request needed?
Eleni wants the order of the components table to be determined by the order they were added
What does this pull request change?
Fixed by switching TComponentProperties from object to array
Issues related to this change:
Closes #201

Looks good, but the order is not changed in the API yet, which is needed for this to work right?

Checked. Did not work. The components are somehow sorted during transit. Very weird.

This issue is not related to the order of the components or the API. It is related to keeping the order in the table when adding new components to the table


View Open Source Licences bug

Great library!
I found a bug with the following settings:
    <licenses
        overflow="0"
        showDefaults="false">
        <project repo="TheAndroidMaster/Attribouter" />
    </licenses>

the title of the section appears as "View @string/title_attribouter_licences".
The bug does not appear if I remove the overflow attribute.
I seems that for the translators section, for example, this bug does not appear if I set the overflow to 0.

Huh. Possible workaround is to just set the 'title' attribute to "Open Source Licenses", which is the value of that string resource. I likely just overlooked something when I wrote it, I'll try and fix it properly tomorrow.


[SR-9484] Accepts invalid where clauses for associated types

Previous ID
SR-9484

Radar
None

Original Reporter
@jepers

Type
Bug

Environment
Xcode 10.1 default toolchain and recent snapshots

Additional Detail from JIRA

Votes
0

Component/s
Compiler

Labels
Bug

Assignee
None

Priority
Medium

md5: 87628fd70d4bc413b5d6c5a47a32780d

Issue Description:
I guess the following should not compile (but it does):
protocol P {
    associatedtype A
    associatedtype B where B == A
}

protocol Q where A == B {
    associatedtype A
    associatedtype B
}

protocol R where A == (B, C) {
    associatedtype A
    associatedtype B
    associatedtype C
}

protocol S where A == (B, C) -> D {
    associatedtype A
    associatedtype B
    associatedtype C
    associatedtype D
}

This code is fine, protocol where clauses can reference the protocol's own associated types.


[BUG]: Various bug-patches

Description
The following bugs were recorded in the repository:

[ ] Broken React Plugin at gatsby-config.js
[ ] Incorrect position of seo.jsx
[ ] Incorrect linting of contributors.tsx
[ ] Correction of heading at pull_request_template
[ ] Correction of Issue Template

Patched !


Update ItineraryAttraction command in UG

Add a table to the addItineraryAttractionCommand.

Codecov Report

Merging #285 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #285   +/-   ##
=========================================
  Coverage     73.67%   73.67%
  Complexity      878      878
=========================================
  Files           123      123
  Lines          2857     2857
  Branches        445      445
=========================================
  Hits           2105     2105
  Misses          644      644
  Partials        108      108

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba74157...63ca434. Read the comment docs.


Tabs Bar Color

In Firefox 65 The Tabs Bar takes on the color that is set in windows 10.. In order to make it dark you either have to change the color settings in Windows 10 or leave out the check mark in Windows 10 Colors in Title Bars and Windows borders as shown in the image below. This will make the Tabs bar dark again, but it messes up Windows 10's Programs. If I leave the the check mark out, all programs in Windows 10 will have a bright tool bar. I use ShadowFox to get away from bright colors.
This issue became a problem with Firefox 65 as Mozilla changed something with the bars. This did not happen in Firefox 64. See the attached image link. This is not an issue with the default dark theme it is in ShadowFox. A Simple CSS script may fix this.
https://i.imgur.com/GuZWQ7i.png

I'm not entirely sure how that could be - as mentioned above, ShadowFox doesn't touch the tab bar, nor take into account any Windows based colors/themes.  The styling for that is entirely based on Firefox (how they utilize your Windows theme, I am unsure).
Based on your screen shots in https://github.com/SrKomodo/shadowfox-updater/issues/31, however, it doesn't look like you have the FF dark theme in use (the address bar, for example, is white).
Whether Firefox changed something to no longer allow you to use the default theme without a certain Windows config, I am not sure.
If that's the case I may need to look into overriding the tab color, but as it stands it is not ShadowFox causing bright colors in your tab region.

@loopy750, any insights here by chance?

I will put this as simple as I can. Beginning with Firefox 65 Firefox uses the color scheme that the user has set in Windows 10. If you have it set to Blue, The Tabs Bar at the top of Firefox will be Blue.
To fix this the Windows 10 user must change his color scheme to a dark shade to get the total dark view in Firefox. This works but it makes Windows 10 look even worse than it does. I corrected my issue by Installing That Black Theme by Madonna. All of the above being said, other users will have the same problem. In Firefox 64 this was not an issue. It is in any release greater than Firefox 64.
Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10

From: Pat Johnson<EMAIL_ADDRESS>Sent: Saturday, December 29, 2018 4:10:33 PM
To: overdodactyl/ShadowFox
Cc: GTK66; Author
Subject: Re: [overdodactyl/ShadowFox] Tabs Bar Color (#233)
I'm not entirely sure how that could be - as mentioned above, ShadowFox doesn't touch the tab bar, nor take into account any Windows based colors/themes. The styling for that is entirely based on Firefox (how they utilize your Windows theme, I am unsure).
Based on your screen shots in SrKomodo/shadowfox-updater#31https://github.com/SrKomodo/shadowfox-updater/issues/31, however, it doesn't look like you have the FF dark theme in use (the address bar, for example, is white).
Whether Firefox changed something to no longer allow you to use the default theme without a certain Windows config, I am not sure.
If that's the case I may need to look into overriding the tab color, but as it stands it is not ShadowFox causing bright colors in your tab region.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/overdodactyl/ShadowFox/issues/233#issuecomment-450520337, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ANSRmqLXi-Cmx9Tx6kl83vPU5Tchs8kcks5u99pJgaJpZM4ZkmH-.

Gotcha.
So generally speaking, in the past I've opted to stay as consistant with Firefox's look as possible, and make ShadowFox simply a complementary feature to the available dark theme rather than res-style/change things that are designed with intention for the dark theme.
I would tend to agree though that having a colored tab area doesn't fit great with ShadowFox, so maybe this is a case worth making an exception for.
I don't use Windows though, so I'm not sure how this theming fits in with their ecosystem/how users would feel about me overriding it.
I guess another possibility would be to add an option in the updater that could append something to the effect of
#TabsToolbar {
    background: var(--tone-9) !important;
}

to userChrome.css (pinging @SrKomodo in case you have any thoughts/opinions on this).
Feedback from other Windows users would be greatly appreciated as well.
Relevant reddit thread with a screenshot of how Firefox is effected:
https://old.reddit.com/r/firefox/comments/9ukhed/nightly_dark_theme_menu_bar_no_longer_dark/

It doesn't look too bad with the light theme, but does look horrible with the dark theme.
/* Dark theme */

.tab-background:not([selected]):-moz-lwtheme-brighttext,
.browser-toolbar.titlebar-color:-moz-lwtheme-brighttext {
  background-color: #0C0C0D !important;
  color: #F9F9FA !important;
}

/* Light theme */

.tab-background:not([selected]):-moz-lwtheme-darktext,
.browser-toolbar.titlebar-color:-moz-lwtheme-darktext {
  background-color: #E3E4E6 !important;
  color: #18191A !important;
}

Thanks @loopy750 and @GTK66!
I added the code above (dark theme) with the following variables:
--tab-background-color
--tab-color

which default to var(--tone-9) and var(--in-content-selected-text) respectively.
Let me know if this doesn't fix things and I'll re-open!

No this did not work unless I placed in the wrong place. I placed it at user name\AppData\Roaming\Mozilla\Firefox\Profiles\bjaip11i.default\chrome
Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10

From: Pat Johnson<EMAIL_ADDRESS>Sent: Saturday, December 29, 2018 8:12:53 PM
To: overdodactyl/ShadowFox
Cc: GTK66; Mention
Subject: Re: [overdodactyl/ShadowFox] Tabs Bar Color (#233)
Thanks @loopy750https://github.com/loopy750 and @GTK66https://github.com/GTK66!
I added the code above (dark theme) with the following variables:
--tab-background-color
--tab-color
which default to var(--tone-9) and var(--in-content-selected-text) respectively.
Let me know if this doesn't fix things and I'll re-open!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/overdodactyl/ShadowFox/issues/233#issuecomment-450532324, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ANSRmvAby5CQTdZm9Cq1fFQphbn_TBf1ks5u-BMVgaJpZM4ZkmH-.

This is what I was trying to tell you. So in order for SgadowFox to work properly from Fx 65 on out the code needs changed. See Below:
https://i.imgur.com/gXRtifc.png
Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10

From: Pat Johnson<EMAIL_ADDRESS>Sent: Saturday, December 29, 2018 8:12:53 PM
To: overdodactyl/ShadowFox
Cc: GTK66; Mention
Subject: Re: [overdodactyl/ShadowFox] Tabs Bar Color (#233)
Thanks @loopy750https://github.com/loopy750 and @GTK66https://github.com/GTK66!
I added the code above (dark theme) with the following variables:
--tab-background-color
--tab-color
which default to var(--tone-9) and var(--in-content-selected-text) respectively.
Let me know if this doesn't fix things and I'll re-open!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/overdodactyl/ShadowFox/issues/233#issuecomment-450532324, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ANSRmvAby5CQTdZm9Cq1fFQphbn_TBf1ks5u-BMVgaJpZM4ZkmH-.

Then why did this work fine with Firefox 64, It does NOT work with 65. So Firefox made a change so in order for ShadowFox to work users will have to stay on Firefox 64 or change their
Color settings in Windows 10. If this is what ShadowFox calls customer service then I do not need your program.
Don’t worry you will be getting many complaintrs.
Please do not respond as I am done with your POS product.
Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10

From: Pat Johnson<EMAIL_ADDRESS>Sent: Sunday, December 30, 2018 3:29:38 PM
To: overdodactyl/ShadowFox
Cc: GTK66; Mention
Subject: Re: [overdodactyl/ShadowFox] Tabs Bar Color (#233)
No this did not work unless I placed in the wrong place. I placed it at user name\AppData\Roaming\Mozilla\Firefox\Profiles\bjaip11i.default\chrome
It's impossible for me to know if that is the correct location for you, but it should be in your userChrome.css file.
It was added to ShadowFox in 9d59a01https://github.com/overdodactyl/ShadowFox/commit/9d59a013c712abcaa6ef8d9732f1ef2ef5181774 though, so if you use the updater/update your ShadowFox code, you will have it.
The code works on macOS to change the tab bar area... @loopy750https://github.com/loopy750 is the current version of SF working for you to adjust the tab area in Windows?
This is what I was trying to tell you. So in order for SgadowFox to work properly from Fx 65 on out the code needs changed. See Below:
That change is not relevant to ShadowFox; the significant change was that Firefox now styles the tab area based on your Windows theme. It didn't do this before, and as such I did not include any code to style that area (because the default dark theme handled it).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/overdodactyl/ShadowFox/issues/233#issuecomment-450584678, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ANSRmiEq619ZC3Eh9A54A0jWBps15_n9ks5u-SIygaJpZM4ZkmH-.

The code works on macOS to change the tab bar area... @loopy750 is the current version of SF working for you to adjust the tab area in Windows?

Hi, works fine for me...
With Shadowfox: https://i.imgur.com/RPbhxxm.png
Without shadowfox: https://i.imgur.com/4VWpugR.png

Perfect, thanks for the help and the update!


Changes on top of upstream to get rid of type errors

Fixes the class of failed unit tests  on rocm in test_base.py that fail the internal assertion Cannot convert ScalarType Float8_e4m3fn to hipDataType.
Note: We are aware of the outstanding numerical issues and are looking into it internally.

@drisspg :)

Awesome! I will take a look at this tomorrow

@vkuzo Ready for another review. Also, wanted to ask if there was an ETA or roadmap for when this functionality would be pulled into pytorch proper?

so sorry I am on holiday right now, will take a look late next week when I return, unless @drisspg wants to get to it sooner

Yeah will review tomorrow

@drisspg
test_everything.log
Fails in test_compile. However, I was aware of this failure and found that this is unrelated to my changes, rather, an issue with torch.compile on ROCm. This failure was next on my TODO's to address. I will upload a follow up PR.

just an update here, the base PR should landed yesterday

@vkuzo @drisspg
Revised/rebased drop of AMD support after the amd-support branch was merged to main

@drisspg fixed lint. But not sure what the ufmt errors are about.

@drisspg Looks like you beat me to it. Still failing on 2 files though. is there documentation on what ufmt expects? some of those changes seem purely cosmetic

The reason for this formatting is due to some internal nodes on code styling. TBH
I just run ufmt format . and dont care about the actual format.
I have also have some 'pre-commit' hooks for the repo that should be set and forget. There does seem to be 2 more lint fixes.
There seems to be 1 real test_failure:
./test/test_everything.sh: line 5: rocm-smi: command not found

I found this patch passed test_everything:
https://gist.github.com/drisspg/47a29d6bf3fcca2a2c48d09b74c564aa


Fixes RNR screen initial load and first-run UX on login screen

Please verify the following:

[x] yarn ci:test jest tests pass with new tests, if relevant

Describe your PR

Adds a default email / password to the auth store which allows the user to just click login when they first boot up their Ignited app.
Adds observer to the RNR episodes screen to fix the initial data load bug
Fixes the ESlint no unused var rule to allow _ prefixing to ignore

Visuals

Not sure what the CI failure is for. I restarted it.

Looks like it failed on npm run lint, not totally sure why as it succeeds when I run it

Looks like it failed on npm run lint, not totally sure why as it succeeds when I run it

Try running yarn lint/format from both root and boilerplate directories. Sometimes, one of the variations catches the error for me.

Looks like it failed on npm run lint, not totally sure why as it succeeds when I run it

Try running yarn lint/format from both root and boilerplate directories. Sometimes, one of the variations catches the error for me.

Turns out I was running from ignite and not from boilerplate. There are some actual linter errors after my unused-vars config change, which makes sense.
But I wonder if there's a way to have the actual output show up on CI


Add uninstall instructions

Is your feature request related to a problem? Please describe.
When I uninstall the script, it seems to modify configurations etc. And KDE acts strangely like no title bars or windows refusing to go on top of other windows
Describe the solution you'd like
Uninstall instructions or some way to make the changes not stay when turned off or removed
Describe alternatives you've considered
¯_(ツ)_/¯
Additional context

I have tried

Deleting everything in .config that references plasma or kwin
Deleting cache files
Logging in and out

You seem to use x11 and kwin has crashed in there. Try running it on the terminal "kwin_x11 --replace"

That seemed to at least get my window title bars back back I have to do this everytime restart plasma is anyway, and I am still having the issue of windows refusing to overlap each other. Also didn't see the section about testing on Wayland too, I will do that and update you. Just keep in mind I am a Nvidia user so it might not be 100% accurate to everyone else

Wayland appears to work as before, but again it being Nvidia it's still not ideal

That seemed to at least get my window title bars back back I have to do this everytime restart plasma is anyway, and I am still having the issue of windows refusing to overlap each other. Also didn't see the section about testing on Wayland too, I will do that and update you. Just keep in mind I am a Nvidia user so it might not be 100% accurate to everyone else

For some reason on x11 KDE is not loading kwin as part of the startup process. (or maybe actually loads but immeditely crashes after that) I'm not the adequate person to debug this problem or if it has to do with this script. But uninstallation should process should be just removing using the scripts configuration panel without any additional step. If that doesn't work for some reason, it should be considered a bug.

Well that didn't work, so I guess this is a X11 specific issue perhaps. Up to you if you want to fix it I guess since X11 is not officially supported by your admission which I can understand. But Wayland on NVIDIA is still not at a point where I want to use it mainly because of graphical issues that Nvidia has been radio silent on fixing as usual, probably will get a AMD card before they fix it smh

Very strange, the script should be completely managed by KWin. This comes with uninstalling properly as well. There may be some residual scripts running, but all of that should go away on a reboot. This is probably a KWin bug, especially if there is inconsistent behavior between X11 and Wayland.


Can't install Ubuntu distribution due to missing (or wrong PATH env var) files

Windows Version
Microsoft Windows [Version 10.0.22621.1635]
WSL Version
<IP_ADDRESS>
Are you using WSL 1 or WSL 2?

[X] WSL 2
[ ] WSL 1

Kernel Version
No response
Distro Version
Ubuntu 2204.31.0
Other Software
No response
Repro Steps
I had to re-installed WSL2 in my windows machine (Ubuntu was installed before).  The previous version was WSL1 upgraded to WSL2.  I followed the steps below:

Run in Powershell with admin rights: wsl --install. Got the following output:

The requested operation requires elevation.
Installing: Windows Subsystem for Linux
Windows Subsystem for Linux has been installed.
Installing: Ubuntu
Ubuntu has been installed.
The requested operation is successful. Changes will not be effective until the system is rebooted.

Restarted laptop,  Ubuntu started by itself and got the following output:
Ubuntu is already installed.

Launching Ubuntu...
Installing, this may take a few minutes...
/bin/bash: line 1: rm: command not found
/bin/bash: line 1: mkdir: command not found
/bin/bash: line 1: ln: command not found
Please create a default UNIX user account. The username does not need to match your Windows username.
For more information visit: https://aka.ms/wslusers
Enter new UNIX username:

Typed a new user name and got the error below:
/bin/bash: line 1: adduser: command not found

Additional info:
I tried to install Debian to see whether I'd get a similar problem.  Managed to install it but got the error message below:
Installation successful!
-bash: dircolors: command not found

And when I run Linux commands, e.g., ls, I get the following error:
-bash: ls: command not found
I echoed the PATH env var and could not find a path to any linux bin folder, e.g.,  /bin or /sbin.
Expected Behavior
Ubuntu installs successfully
Actual Behavior
Ubuntu fails to install due to error when creating user
Diagnostic Logs
No response

I'm having the same issue and have tried a bunch of ways to remedy it. I've tried

simple unregister, uninstall, reinstall on distributions
restarting/ resetting WSL through Apps and Features (the amount of times I have had to restart my machine to ensure that the components are also disabled and then enabled is nothing short of infuriating)
multiple distros
checking that certain lines in the config are commented out or not present

I've even found temporary work arounds. However, those temporary work around are suppose to be permanent (manually re-configuring the Unix paths by editing both the /.bashrc and /.profile files and the then making sure they should work by refreshing bash + more  and even creating new users from root; which is one of the main things that does not happen due to the issue). These didn't last past using wsl commands. It would set the path to reflect only the windows path values.
I am using the same version of WSL (<IP_ADDRESS>) but Windows Build 10.0.19045.3031.
Any assistance is appreciated.

It seems that at some point I had added the below env var to windows:

This was screwing up the PATH in ubuntu.  I removed the env var,  reinstalled ubuntu and all works fine now


gcc: internal compiler error

RocksDB says they need gcc 4.8 but the .travis.yml is using gcc 4.6. The build scripts need to be updated to use gcc 4.8.
This could provide inspiration:
https://github.com/eggs-cpp/variant/blob/master/.travis.yml

Hi, Vinnie, it seems you always arrange homeworks so difficult to me :)) they were driving me mad nearly every time :)))


Add inputId attribute to filter selector to facilitate end-to-end testing

Setting inputId field on add filter component helps to write tests by setting a stable selector. Before this change, the name generated was like react-select-#-input (Where # is a number)

This PR has no use. I will submit another one with changes on components and tests


Removing LFS from workflows

Since we are removing LFS usage from the main setup, this should also include removing it from the workflows just in case it causes issues.

Probably https://github.com/tenstorrent/tt-umd/pull/423 should go in first?

yeah, or just merge this into your series


SSL support

Added ssl and ssl_verify parameters to the pyrabbit.api.Client and pyrabbit.http.HTTPClient functions. Set using a boolean value.

@bkjones is there any support for SSL right now?


[ISSUE - 183] Enhance UI of the number solver and make it responsive

Checklist

[x] Make the website responsive
[x] When negative numbers are used, place them within brackets in the output field.
[x] Use the divide sign instead of the '/' in the output field.
[x] Make the UI more cohesive with the other solvers.

Category

[x] User Interface
[x] Enhancement/Optimization
[x] Responsive

Related Issue

Fixes #183

Screenshot (For Preview)

Guidelines (*)

[x] I have gone through the Contributing guide
[x] The name of the resource is spelled correctly
[x] The link to the resource is working
[x] The resource is added in the correct format
[x] I have tested changes on my local computer

@Spandan-Bhattacharya The Pull Request is ready for a review and merge. Kindly Review it and provide your feedback.

Good Job!


add train on cpu

Add training on cpu and config file

@vincehass Thank you for the PR. I think it would be better, both for repo organization and reviewing, if you directly make modifications to the original script to allow CPU training. What are the key changes? The optimizer? You could add a check if the model is on the CPU, then switch the default optimizer name.

Sure, I can create a new branch if you will, so basically we have:
Detailed Changes Explanation

Optimizer Name:

In train_cpu.py:
optim: str = "adamw_torch",

The optimizer is set to "adamw_torch", which is a standard AdamW optimizer implementation suitable for CPU training.

In train.py:
optim: str = "adamw_torch_fused",

The optimizer is set to "adamw_torch_fused", which is an optimized version of the AdamW optimizer that is designed to take advantage of GPU capabilities, particularly for mixed precision training. This optimizer can provide better performance on NVIDIA GPUs.

Device Handling:

In Both Scripts:

Both scripts check for the availability of CUDA and set the device accordingly. However, the handling of the optimizer based on the device is not explicitly defined in train_cpu.py.

Current Device Check:
device = 'cuda' if torch.cuda.is_available() else 'cpu' if torch.backends.mps.is_available() else 'cpu'

This line determines the device to be used for training. It checks if CUDA is available (indicating a GPU), and if not, it checks for Metal Performance Shaders (MPS) for Apple devices. If neither is available, it defaults to CPU.

Suggested Code Modification:

To improve the handling of the optimizer based on the device, we can add a conditional statement that sets the optimizer name based on whether the model is being trained on a CPU or a GPU. Here’s the suggested modification:

# .
    # Check if CUDA is available
    device = 'cuda' if torch.cuda.is_available() else 'cpu' if torch.backends.mps.is_available() else 'cpu'

    # Change optimizer if not using CUDA
    optim = 'adamw_torch' if device == 'cpu' else 'adamw_torch_fused'  # Use a valid optimizer name
#

Suggested Changes

Device Check:

The line device = 'cuda' if torch.cuda.is_available() else 'cpu' if torch.backends.mps.is_available() else 'cpu' remains unchanged. It effectively determines the device to be used for training.

Optimizer Assignment:

The new line optim = 'adamw_torch' if device == 'cpu' else 'adamw_torch_fused' introduces a conditional assignment for the optimizer:

If the device is cpu, it assigns the optimizer to 'adamw_torch', which is suitable for CPU training.
If the device is cuda (indicating a GPU), it assigns the optimizer to 'adamw_torch_fused', which is optimized for GPU training.

@vincehass was the response written by an LLM? 😄
My understanding from your response is that you only need to take care of the optimizer for cpu training to work? Please feel free to modify the PR to update the main training script instead.

@vincehass any update on this?


FAQ needs updating

Now that Linux and Mac is supported, time to update https://github.com/Microsoft/vcpkg/blob/master/docs/about/faq.md#does-vcpkg-run-on-linuxosx
I'd do a pr but figured there might be someone who knows what they want to put in there better than me putting in 'Yes!' as an answer.

Thanks for pointing that out! We really appreciate it!


Complete a full run of all popularity_refresh DAGs

Problem

This issue is used to track the completion of an initial run for both the audio_popularity_refresh and image_popularity_refresh DAGs.
Description

The DAGs should not be enabled until popularity calculations are successfully working during ingestion; this ensures that when the refresh DAGs run, no newly ingested data will be missed.
Once the DAGs have both completed for the first time, the Catalog media tables will be fully backfilled with standardized_popularity scores for all records that support it.

This has been completed!