--staged ignored, eb deploy uploading entire local version

Description
When deploying with --staged, eb deploy is uploading my entire local directory rather than just content staged in git.
Steps to reproduce
Make an obvious change to code, don't stage it, run eb deploy --staged
Observed result
Change is deployed
Expected result
Change is not deployed
Additional environment details (Ex: Windows, Mac, Amazon Linux etc)

OS: MacOS 10.15.5
EBCLI version: EB CLI 3.18.2 (Python 3.8.5)

I tested it several ways:
No files staged
Some other file staged
Same file staged but only certain changes
In each case, the unstaged change would get deployed.
I also thought maybe it was user error because I was putting --staged before my environment name. That made no difference.

@owurman Thanks for reaching out. I’ve so far been unable to reproduce the issue. I have tried it several ways and it was working as expected, so if you don’t stage your changes(run eb deploy), changes won’t be deployed and if you staged your changes(run eb deploy --staged) it will be deployed with entire local directory content.
Could you provided more details about few use cases?
What is your observed result when you don't stage your changes and run eb deploy?  (Expected result: changes don't get deployed)
What is your observed result when you stage your changes and run eb deploy --staged? (Expected result: changes will be deployed)
thanks!

Perhaps I'm misunderstanding. If I staged only certain changes/files in git
and run with eb deploy --staged, does it take the entire local contents,
not just what is staged?
Regardless, I just tested with changes in local folder, eb deploy
without --staged,
and all local, uncommitted changes were clearly uploaded. Don't know what
to tell you. This is with EB CLI 3.19.2.

@owurman thanks for confirming. So if you stage certain changes and run eb deploy --staged it will deploy newly staged content plus previously committed content (unstaged changes will not be deployed).
I have attempted to reproduce this issue with EB CLI 3.19.2 and not seeing the same behavior. Could you include an example codebase(github repo or directory archive) which reproduces this issue and exact steps to reproduce?

I don't have an example codebase, but I do run under a python venv, perhaps
that's the issue?

Nope, same behavior for me when not in the virtual env.

Could you provide exact steps to reproduce this issue?

Make a change in the code.
Run eb deploy without --staged.
Change gets deployed, anyway.
I'm really not doing anything special here.

@owurman, I am following your steps and am not seeing the same behavior. Could you provide eb deploy --verbose output before and after adding a new file in the directory?

@owurman, I am following your steps and am not seeing the same behavior. Could you provide eb deploy --verbose output before and after adding a new file in the directory?

If you want the full dump, let me know where to email it, but here's a
relevant bit:
INFO: Deploying code to  in region us-west-2
INFO: Getting version label from git with git-describe
INFO: Found .ebignore, using system zip.
INFO: Zipping up folder at location:
INFO:   -skipping: ./analysis.log
INFO:   -skipping: ./.DS_Store
INFO:  +adding: .//
INFO:   +adding: ./ssh-production-bastion.sh
INFO:   +adding: ./requirements.txt
INFO:   -skipping: ./django_db.log
INFO:   -skipping: ./test.log
INFO:   +adding: ./jpad_bug_dump.sql
...
Note git status:
Untracked files:
(use "git add ..." to include in what will be committed)
20201228_production_dump.sql
jpad_bug_dump.sql
So jpad_bug_dump.sql is getting added even though it's not checked in.
Now I ran it again, this time with staged (and not I haven't added ANY of
my changes to git yet, everything is still modified or untracked):
INFO: Deploying code to  in region us-west-2
INFO: Getting version label from git with git-describe
INFO: Found .ebignore, using system zip.
INFO: Zipping up folder at location:
INFO:   -skipping: ./analysis.log
INFO:   -skipping: ./.DS_Store
INFO:  +adding: .//
INFO:   +adding: ./ssh-production-bastion.sh
INFO:   +adding: ./requirements.txt
INFO:   -skipping: ./django_db.log
INFO:   -skipping: ./test.log
INFO:   +adding: ./jpad_bug_dump.sql
Still there!

If you want the full dump, let me know where to email it, but here's a
relevant bit:
INFO: Deploying code to  in region us-west-2
INFO: Getting version label from git with git-describe
INFO: Found .ebignore, using system zip.
INFO: Zipping up folder at location:
INFO:   -skipping: ./analysis.log
INFO:   -skipping: ./.DS_Store
INFO:  +adding: .//
INFO:   +adding: ./ssh-production-bastion.sh
INFO:   +adding: ./requirements.txt
INFO:   -skipping: ./django_db.log
INFO:   -skipping: ./test.log
INFO:   +adding: ./jpad_bug_dump.sql
...
Note git status:
Untracked files:
(use "git add ..." to include in what will be committed)
20201228_production_dump.sql
jpad_bug_dump.sql
So jpad_bug_dump.sql is getting added even though it's not checked in.
Now I ran it again, this time with staged (and not I haven't added ANY of
my changes to git yet, everything is still modified or untracked):
INFO: Deploying code to  in region us-west-2
INFO: Getting version label from git with git-describe
INFO: Found .ebignore, using system zip.
INFO: Zipping up folder at location:
INFO:   -skipping: ./analysis.log
INFO:   -skipping: ./.DS_Store
INFO:  +adding: .//
INFO:   +adding: ./ssh-production-bastion.sh
INFO:   +adding: ./requirements.txt
INFO:   -skipping: ./django_db.log
INFO:   -skipping: ./test.log
INFO:   +adding: ./jpad_bug_dump.sql
Still there!

--staged command deploy files from the local git repository, where those files are not yet committed, but rather staged.
This is how I'm testing eb deploy stage functionality:
Here are my logs from running eb deploy --verbose.
Creating application version archive "app-1234”.
INFO: creating zip using git archive HEAD
INFO: git archive output: .ebextensions/
.ebextensions/logging.config
.gitignore
EBSampleApp-PHP.iml
index.php
INFO: Uploading archive to s3 location: app/app-1234.zip

I have added new file scheduled.php and staged it(not commited).
Output from running git status:
Changes to be committed:
  (use "git restore --staged <file>..." to unstage)
	new file:   scheduled.php

After that run eb deploy --staged --verbose.
Logs:
Creating application version archive "app-12345”.
INFO: creating zip using git archive HEAD
INFO: git archive output: .ebextensions/
.ebextensions/logging.config
.gitignore
EBSampleApp-PHP.iml
index.php
scheduled.php
INFO: Uploading archive to s3 location: app/app-12345.zip

As you can see from above logs that schedule.php file is added when running eb deploy with --staged

--staged command deploy files from the local git repository, where those files are not yet committed, but rather staged.
This is how I'm testing eb deploy stage functionality:
Here are my logs from running eb deploy --verbose.
Creating application version archive "app-1234”.
INFO: creating zip using git archive HEAD
INFO: git archive output: .ebextensions/
.ebextensions/logging.config
.gitignore
EBSampleApp-PHP.iml
index.php
INFO: Uploading archive to s3 location: app/app-1234.zip

I have added new file scheduled.php and staged it(not commited).
Output from running git status:
Changes to be committed:
  (use "git restore --staged <file>..." to unstage)
	new file:   scheduled.php

After that run eb deploy --staged --verbose.
Logs:
Creating application version archive "app-12345”.
INFO: creating zip using git archive HEAD
INFO: git archive output: .ebextensions/
.ebextensions/logging.config
.gitignore
EBSampleApp-PHP.iml
index.php
scheduled.php
INFO: Uploading archive to s3 location: app/app-12345.zip

As you can see from above logs that schedule.php file is added when running eb deploy with --staged

I am experiencing the same issue where an 'eb deploy' is deploying any files that have been modified, regardless if they are staged or not. This is relatively new as it wasn't occurring a month or so ago. Not sure if this has to do with the Mac OS upgrade to Big Sur or not.

eb --version
EB CLI 3.19.3 (Python 2.7.1)

Mac OS v11.1

I am experiencing the same issue where an 'eb deploy' is deploying any files that have been modified, regardless if they are staged or not. This is relatively new as it wasn't occurring a month or so ago. Not sure if this has to do with the Mac OS upgrade to Big Sur or not.

eb --version
EB CLI 3.19.3 (Python 2.7.1)

Mac OS v11.1

I'm still on Catalina, so it's not Big Sur-specific.

I'm still on Catalina, so it's not Big Sur-specific.

@Palak I tried adding that dump file as in your case. It gets added even
without --staged:
eb deploy --verbose:
...
INFO:   +adding: ./jpad_bug_dump.sql
git status:
Changes to be committed:
(use "git restore --staged ..." to unstage)
new file:   jpad_bug_dump.sql
So... obviously this behaves differently for you and me. What could be the
differences?

@Palak I tried adding that dump file as in your case. It gets added even
without --staged:
eb deploy --verbose:
...
INFO:   +adding: ./jpad_bug_dump.sql
git status:
Changes to be committed:
(use "git restore --staged ..." to unstage)
new file:   jpad_bug_dump.sql
So... obviously this behaves differently for you and me. What could be the
differences?

@owurman I see. --staged option is tightly coupled with git stage command. Could you tell me which git version you have?

@owurman I see. --staged option is tightly coupled with git stage command. Could you tell me which git version you have?

git version 2.24.3 (Apple Git-128)

git version 2.24.3 (Apple Git-128)

Same git version for me also...

git --version                                                                                [01/25/21 12:33:33]
git version 2.24.3 (Apple Git-128)

Same git version for me also...

git --version                                                                                [01/25/21 12:33:33]
git version 2.24.3 (Apple Git-128)

Thanks for sending the information.
In my case git version is : git version 2.23.0
This could be the issue with apple git. You have a version of Git from apple.
Unfortunately I don't have apple git installed on my computer to repro this issue. Could you try installing and using official version of git and see if this issue still persists?

Thanks for sending the information.
In my case git version is : git version 2.23.0
This could be the issue with apple git. You have a version of Git from apple.
Unfortunately I don't have apple git installed on my computer to repro this issue. Could you try installing and using official version of git and see if this issue still persists?

That's really easier said than done. I'm not interested in messing up my
git environment for this, sorry.

I'm seeing this same exact issue with git 2.34.1 on Windows - thought i was going nuts!

Hi @owurman  I've tested on Amazon Linux 2 with git version 2.42.0 and did not encounter the issue you described. The eb deploy --staged command behaved as expected, deploying only the staged changes and leaving the unstaged ones behind.
My directory structure :
teststage1]$ ls -la
total 24
drwxr-xr-x 4 nihamukt amazon 4096 Oct 26 04:44 .
drwxr-xr-x 4 nihamukt amazon 4096 Oct 26 04:36 ..
drwxr-xr-x 2 nihamukt amazon 4096 Oct 26 04:45 .elasticbeanstalk
drwxr-xr-x 7 nihamukt amazon 4096 Oct 26 04:45 .git
-rw-r--r-- 1 nihamukt amazon  108 Oct 26 04:38 .gitignore
-rw-r--r-- 1 nihamukt amazon   60 Oct 26 04:44 index.html

index.html file before making changes :

Hello, World!

~
~
"index.html" 1L, 23B

Committed these changes :
teststage1]$ git commit -m "Initial commit"
[master (root-commit) ce85ba7] Initial commit
 1 file changed, 1 insertion(+)
 create mode 100644 index.html

Did  eb init  to initialize my application
Created an environment using  eb create teststage1-env
Made changes to index.html :

Hello, World!

This is an unstaged change!

~
~
"index.html" 2L, 60B

Did eb deploy --staged
teststage1]$ eb deploy --staged
Creating application version archive "app-ce85-231026_044505468793-stage-231026_044505468820".
Uploading teststage1/app-ce85-231026_044505468793-stage-231026_044505468820.zip to S3. This may take a while.
Upload Complete.
2023-10-26 04:45:06    INFO    Environment update is starting.
2023-10-26 04:45:10    INFO    Deploying new version to instance(s).

Downloaded the latest application version from the Console and index.html did not not show the "This is an unstaged change!" text, it means the eb deploy --staged command is working as expected. The command respected the Git staging area and did not deploy changes that weren't staged.
OS: Amazon Linux 2
EBCLI-Version : 3.20.10
Git version :2.42.0

This bug is so old that I'm not surprised if it's fixed by now. Sorry, but I'm past dealing with it. If it occurs again I can open a new issue.


Environments for deployment

Create environments ( dev, preprod and prod ) for MVP development
Three different account should be created for Data-As-A-Product ( Name option  can be discussed)
sandbox account will be for local testing

Dev
Preprod
Prod

Create a few issues with MP in github to create environments
Liaise with MP and create the three accounts
We will need to deploy changes in terraform through dev, preprod and prod via github workflows. Some of these pipelines will be set up by MP. Understand how much of the deployment pipeline comes set up by MP, and what we need to do ourselves.
**Deployment strategy should be gated deployment - which requires mannual approval move to environment.  ***
https://dsdmoj.atlassian.net/wiki/spaces/DE/pages/4226646354/ADR-2+Use+gates+in+the+deployment+pipeline

After we have our environments, we need to set up a deployment strategy. This will define:

how to make changes to code
how to test changes to code in an automated way
how to promote changes to code through environments
how and when to version the codebase, for the purpose of making clear changes to the data product API and infrastructure. Will we have separate versioning for the API and for the infrastructure? Example: we deploy a host of changes from a sprint to prod, to release new features such as a data out endpoint, and the version of the data platform increments from v2.6 to v3.0

https://github.com/ministryofjustice/modernisation-platform/issues/4794


Weird regenerator error not letting alias work properly

upgrading my node version fixed the issue. closing..

upgrading my node version fixed the issue. closing..

May I ask what version were you using?

May I ask what version were you using?

Was using 6.2.2 when the error was occuring


Update TheArtist crossover relics

TheArtist mod was a character mod made by Vex where the character in question could create Paintings, using those as cards.
It got removed from the Steam Workshop by Vex... until DiamSword (Steam alias) ressurrected and polished it.
So...

[x] Make relics work with the new TheArtist mod, leaving previous relics compatible with old version of Artist character on;
[x] Check if relics need changes, considering what they did before;
[x] Test;
[x] Merge;

Well surprise, all relics work .-.


Notifications never stop

I am using a fractionally modified version of the code in the example and am seeing some strange behaviour. The modification is that I have changed the OneDriveSubscription in SubscriptionController to this:-
        Models.OneDriveSubscription subscription = new OneDriveSubscription
        {
            NotificationUrl = notificationUrl,
            ClientState = "my client state",
            Resource = "01ZUA22DF6Y2GOVW7725BZO354PWSELRRZ",
            SubscriptionExpirationDateTime = DateTime.Now.AddHours(2)
        };

(My code sets the Resource and the SubscriptionExpirationDateTime because the process fails without these. I suspect that the example might be lagging behind some more recent updates to OneDrive perhaps?). The Resource refers to my OneDrive root folder but I have tried it with other folders with no difference to the behaviour.
What I see is that OneDrive continually sends notifications that the resource has changed. The notifications never stop. The example source code returns an HTTP 200 response (in the Listen method) to OneDrive and everything I have read says that this is the response that tells OneDrive that the notification has been received and it does not need to retry sending the notification. I have tried changing the HTTP response to 201 and 202 but the behaviour is unchanged.
Any ideas why the notifications never stop?
Guy

Here's an update:-
The notifications are sent just once (i.e. they behave correctly) if I deploy the example to Azure. It is only when using ngrok and running the example locally that the notifications continue endlessly. I believe that the HTTP 200 response was never reaching the Graph API and as a consequence it kept sending more notifications. I haven't found out what was preventing the responses from getting back but at least I have a working solution now.


Difftastic does not ignore whitespace changes

I'm using Difftastic 0.45.0 and I get this output:

The only things that changed are whitespace, but the diff shows everything, is this correct? I would expect it to only show significant changes.

Note the header: it's treating your file as text and doing a textual diff. What language is your test file?

Ahh, I missed that, sorry. It's C++, but even specifying --language=Cpp didn't change the diff, shouldn't it have?

Somewhat counterintuitively, --language needs an extension, not a language (I missed this glancing at the help. Still, though:
19:41:56 $ GIT_EXTERNAL_DIFF="difft --language=cpp" git diff
code/src/main.ino --- Text (2 errors, exceeded DFT_PARSE_ERROR_LIMIT)
313     digitalWrite(ALARM_PIN, LOW);                                                                  313     digitalWrite(ALARM_PIN, LOW);
314                                                                                314
315     snprintf(COMMAND_TOPIC, 128, "esplights/%08X/command", ESP.getChipId());                       315     snprintf(COMMAND_TOPIC, 128, "esplights/%08X/command", ESP.getChipId());
316     snprintf(GROUP_TOPIC, 128, "esplights/all/command");                                           316         snprintf(GROUP_TOPIC, 128, "esplights/all/command");
317     snprintf(STATE_TOPIC, 128, "esplights/%08X/state", ESP.getChipId());                           317     snprintf(STATE_TOPIC, 128, "esplights/%08X/state", ESP.getChipId());
318     snprintf(LOG_TOPIC, 128, "esplights/%08X/log", ESP.getChipId());                               318     snprintf(LOG_TOPIC, 128, "esplights/%08X/log", ESP.getChipId());
319     snprintf(HA_TEMP_TOPIC, 128, "homeassistant/sensor/%08X_temp/config", ESP.getChipId());        319     snprintf(HA_TEMP_TOPIC, 128, "homeassistant/sensor/%08X_temp/config", ESP.getChipId());

I've created #496 to add the .ino extension as C++.

It sounds like this issue is resolved? I'm going to close this, but feel free to reopen if you can see anything I've missed.

@Wilfred Yes, sorry, this is mostly resolved, though it would be good if there was some clearer documentation to say that the argument to --language is the extension, rather than a name.


Sort the files displayed when you try to open a file

I find one thing that's inconvenient when I try to open a file is that when I search up text_buffer.py, it goes to text_buffer.pyc first. It would be helpful if we could sort the files by name, and hopefully that would also fix this issue. One misleading thing right now is that when you type text_buffer.py, text_buffer.pyc is highlighted, but pressing enter would open text_buffer.py.

I just pushed a fix for the sort order. Looking at the highlighting next.

Actually it looks fixed now with the latest changes. :+1:


COMP: Use itk::Math::abs for floating point type argument

Use itk::Math::abs instead of abs for floating point type argument.
Fixes:
[CTest: warning matched]
/Users/builder/externalModules/Core/Transform/test/itkAffineTransformTest.cxx:619:11:
warning: using integer absolute value function 'abs' when argument is of floating point type [-Wabsolute-value]
      if (abs(jaffInverseJacobianPosition[i][j] - matrix3invTruth[i][j]) > 1e-13)
          ^
[CTest: warning matched]
/Users/builder/externalModules/Core/Transform/test/itkAffineTransformTest.cxx:619:11:
note: use function 'std::abs' instead
      if (abs(jaffInverseJacobianPosition[i][j] - matrix3invTruth[i][j]) > 1e-13)
          ^~~
          std::abs
[CTest: warning suppressed] 1 warning generated.

raised for example in:
https://open.cdash.org/viewBuildError.php?type=1&onlydeltap&buildid=7615457
PR Checklist

[X] No API changes were made (or the changes have been approved)
[X] No major design changes were made (or the changes have been approved)

Introduced in 7c7233f.
@dzenanz @josempozo.

I saw this morning that a few of Sean's machines produce this warning. Thanks for fixing it Jon!

fgrep -R 'abs(' ~/git/ITK | fgrep -v '::abs' | fgrep -v fabs | fgrep -v ThirdParty

finds more locations that might benefit from instead using std::abs.  Would it make sense to address these with this pull request?

Would be nice to see this one merged to get cdash greener. This PR fixes a warning that was not there yesterday.

You are welcome to make a follow-up PR @Leengit.

finds more locations that might benefit from instead using std::abs

There is also std::fabs so not sure whether we should always stick to std::fabs for non-integer types to avoid taking into account the floating point type precision:
https://en.cppreference.com/w/cpp/numeric/math/fabs

#2934 includes this fix. Feel free to close it in favor or that one, or else, in case it is deemed more secure to merge this one to have the warning go, and later merge the former as an improvement, the former will need to be rebased and the conflict fixed.

The other PR is ready to be merged, so let's close this one.


Fix resource creation while namespace in deletion issue

What this PR does / why we need it:
Currently after namespace is marked for deletion, the deletion flow would still try create resources for the sake of validation, this results in a dead-lock since resources can not be created or updated while namespace is in deletion. This PR fixes this issue.

I just briefly checked the PR - looks OK, although I think you have some formatting issues.


Inaccurate information regarding private channels

Near the bottom of this doc in the Limitations section,  this statement is made.

Channel meetings can't be scheduled.

This does not match what the user sees which clearly indicates its an administrator controlled setting.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: ce34b12b-aa50-608b-bbfa-a1fb4bb79f8d
Version Independent ID: 9ddeb6f4-f30a-1e72-fc94-ae66def91f40
Content: IT Admins - Private channels in Microsoft Teams - Microsoft Teams
Content Source: Teams/private-channels.md
Service: msteams
GitHub Login: @MicrosoftHeidi
Microsoft Alias: heidip

To make it easier for you to submit feedback on articles on learn.microsoft.com, we're transitioning our feedback system from GitHub Issues to a new experience.
As part of the transition, this GitHub Issue will be moved to a private repository. We're moving Issues to another repository so we can continue working on Issues that were open at the time of the transition. When this Issue is moved, you'll no longer be able to access it.
If you want to provide additional information before this Issue is moved, please update this Issue before December 15th, 2023.
With the new experience, you no longer need to sign in to GitHub to enter and submit your feedback. Instead, you can choose directly on each article's page whether the article was helpful. Then you can then choose one or more reasons for your feedback and optionally provide additional context before you select Submit.
Here's what the new experience looks like.
Note: The new experience is being rolled out across learn.microsoft.com in phases. If you don't see the new experience on an article, please check back later.
First, select whether the article was helpful:

Then, choose at least one reason for your feedback and optionally provide additional details about your feedback:

Article was helpful
Article was unhelpful

Finally, select Submit and you're done!

@scanum The pinned issue on this repo is 404.
You realize with a new closed feedback system you're just going to get a bunch of pull requests to fix these documentation things, right? Instead of just having a brief discussion about it.


added sacura tests to keda test job

Fixes #3711
Proposed Changes
added a script in keda-reconciler-tests.sh that will run sacura tests in it
:gift: Added sacura tests in keda job

@Cali0707 I have added the -run=kafkasource flag and also checked whether the environment is LOCAL_DEVELOPMENT or not before running sacura tests

/retest-required

/test reconciler-tests

/test reconciler-tests

/retest-required

/retest-required

/test reconciler-tests-namespaced-broker

/test reconciler-tests-namespaced-broker

/retest-required

/retest-required


cwp.py: Add library/mingw-w64/bin to PATH

This fixes https://github.com/ContinuumIO/anaconda-issues/issues/1129, although I would like to know why we cannot activate the root environment instead. IMHO, either activate/deactivate are used exclusively or they are gotten rid of entirely. Any middle ground is just bugs waiting to happen.

Current coverage is 0.00% (diff: 100%)

Merging #36 into master will not change coverage

@@           master   #36   diff @@
===================================
  Files          10    10
  Lines         915   915
  Methods         0     0
  Messages        0     0
  Branches        0     0
===================================
  Hits            0     0
  Misses        915   915
  Partials        0     0

Powered by Codecov. Last update 1e46dd1...b21e79d

@ilanschnell, @msarahan, please review, I have packages ready to upload.


instability of pyAvalonTools.InitCheckMol

The struchk initialization function in the C++ bindings to the AvalonTools package
  int initCheckMol(const std::string &optString) {     return InitCheckMol((char *) optString.c_str());   }
receives the options string as a const std::string & and casts the result of optString.c_str() to (char *) before passing it to the C implementation.
A comment in the AvalonTools code (also present in version 1.2.0 from sourceforge) includes the following warning:
Note: The opt string is modified and used to provide storage for '\0' terminated strings collected as 'argument' strings.
I suspect the current C++ initCheckMol implementation could be therefore responsible for some of the instabilities related to this struchk initialization step and that it should be therefore modified to forward a copy of the options string.

I saw these emails floating by, could you provide a test case that shows the issue?

It looks like the fix should be:
  int initCheckMol(const std::string &optString) {
    std::string optCopy(optString);
    return InitCheckMol((char *) optCopy.c_str());
  }

or perhaps without casting away const:
  int initCheckMol(const std::string &optString) {
    char *optBuffer = new char[optString.size()+1];
    optString.copy(optBuffer, optString.size());
    optBuffer[optString.size()] = '\0';
    int res = InitCheckMol(optBuffer);
    delete [] optBuffer;
    return res;
  }

Could you try this with your test?

Like other bugs that include writing things at random into someone else's dynamically allocated memory, the problem is not strictly reproducible, so I don't know if a specific test-case would make sense, the code fails at performing a basic init operation. If pyAvalonTools.InitCheckMol is passed an ill-formed random string, you may get a successful return value (that would be unexpected), garbage error messages and more rarely a segmentation fault terminating the interpreter.

Time to run valgrind :)

@rvianello I think I resolved this issue.  Could you verify?  It's been a while.

@bp-kelley apologies, I lost track of this issue on github. yes, I think it's resolved, thanks again for your help with this.


Add test-and-fix target to Makefile

Additional Notes or Comments
I realized that the fix-and-test target was actually test-and-fix, and now I've experimented with it for a few days, I use both cases, but perhaps this is extravagant.

Codecov Report
Patch coverage has no change and project coverage change: -0.05% :warning:

Comparison is base (3f7f142) 78.46% compared to head (bd303ff) 78.42%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #976      +/-   ##
==========================================
- Coverage   78.46%   78.42%   -0.05%
==========================================
  Files         100      100
  Lines        6205     6205
==========================================
- Hits         4869     4866       -3
- Misses       1336     1339       +3

see 2 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

See #408


[Feat] Add

Description
I have Considered alternatives that includes Single Sign-On with Microsoft/LinkedIn, Two-Factor Authentication, Magic Link email login.
Screenshots

Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I'm a GSSoC'24-Extd contributor
[X] I am willing to work on this issue (optional)

Hey @Richajaishwal0, that's a good suggestion, but have you noticed that major e-commerce websites mainly use phone number verification with SMS OTP? This is not feasible for us because it's a paid service, which is why we use email OTP verification for easy login and signup. I hope you understand why we’re not implementing this feature.


SSH functional tests updates

[ ] I have added the tests to cover my changes.
[x] I have updated the documentation, VERSION, and CHANGELOG accordingly.
[x] I have read the CONTRIBUTING document.

Codecov Report

Merging #36 (901107f) into develop (12295ed) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 901107f differs from pull request most recent head a9dfc49. Consider uploading reports for the commit a9dfc49 to get more accurate results

@@           Coverage Diff            @@
##           develop      #36   +/-   ##
========================================
  Coverage    52.17%   52.17%
========================================
  Files            2        2
  Lines          138      138
========================================
  Hits            72       72
  Misses          66       66

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


yamldiff can experience type coercion

Yamldiff suffers from a type coercion bug/feature from the underlying godebug library: https://github.com/kylelemons/godebug/issues/21
Example files:
0.123: "a value"

"0.123": "a value"

These two will have no diff, despite the values being different.

Diff library migrated to https://github.com/r3labs/diff/. Please reopen if still an issue.


Add route for /transactions/{txnid}/status

Codecov Report

Merging #457 (f40ac13) into main (2636cfb) will decrease coverage by 0.03%.
The diff coverage is 37.50%.

@@             Coverage Diff             @@
##              main     #457      +/-   ##
===========================================
- Coverage   100.00%   99.96%   -0.04%
===========================================
  Files          279      280       +1
  Lines        15077    15068       -9
===========================================
- Hits         15077    15063      -14
- Misses           0        5       +5

Impacted Files
Coverage Δ

internal/assets/token_pool.go
100.00% <ø> (ø)

internal/assets/token_transfer.go
100.00% <ø> (ø)

internal/batchpin/batchpin.go
100.00% <ø> (ø)

internal/contracts/manager.go
100.00% <ø> (ø)

internal/database/sqlcommon/transaction_sql.go
100.00% <ø> (ø)

internal/events/batch_pin_complete.go
100.00% <ø> (ø)

internal/events/operation_update.go
100.00% <ø> (ø)

internal/events/tokens_transferred.go
100.00% <ø> (ø)

internal/orchestrator/data_query.go
98.90% <0.00%> (-1.10%)
:arrow_down:

internal/orchestrator/orchestrator.go
100.00% <ø> (ø)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2636cfb...f40ac13. Read the comment docs.

... considering submitting my PR on events to this branch, to avoid merge hell

Thanks for looking this over. I agree timestamp is a useful field to add (anything that can be helpful for debugging).
On the ordering, I'll say that the benefit of the current order is that it should be stable between successive calls to the API, or when comparing two similar transactions. But I can see value in ordering by timestamp as well, from the angle of trying to plot when it got stuck. Will ponder some more...

Another subtle point about timestamps - the time for BlockchainEvents comes from the chain, while the time for other objects comes from FireFly. For the most part they should line up; just noting it.
Also I just realized I may not be intelligently handling large queries (such as a large Batch with a ton of Operations). Another edge case to ponder...

Also I just realized I may not be intelligently handling large queries

I feel like maybe this is ok. Feel like a restriction that your FF must be able to cope with returning small JSON snippets for the maximum number of operations you include in any transaction, within a single JSON payload, is a valid restriction.

such as a large Batch with a ton of Operations

The size of the batch in terms of messages/data wouldn't affect the overall operation count.
It's just one write for the whole batch.
For private messages, it would be the number of different parties you sent to that would scale out the ops.

https://github.com/kaleido-io/firefly/pull/60 raised to merge my changes into this branch.

Decided to go with the recommended sorting (descending by timestamp, with "pending" items at the top)

Found an issue to sort in the merge. Fixing
time="2022-01-29T02:09:05Z" level=debug msg="New batch e37d7961-58e9-4667-ad8a-d0f1a17feabd" role="batchproc-ns1::"
time="2022-01-29T02:09:05Z" level=debug msg="Adding 1 entries to batch e37d7961-58e9-4667-ad8a-d0f1a17feabd. Size=1 Seal=true" role="batchproc-ns1::"
panic:
assert: mock: I don't know what to return because the method call was unexpected.
	Either do Mock.On("InsertTransaction").Return(...) first, or remove the InsertTransaction() call.
	This method was unexpected:
		InsertTransaction(*context.cancelCtx,*fftypes.Transaction)
		0: &context.cancelCtx{Context:(*context.valueCtx)(0xc000458bd0), mu:sync.Mutex{state:0, sema:0x0}, done:(chan struct {})(nil), children:map[context.canceler]struct {}(nil), err:error(nil)}
		1: &fftypes.Transaction{ID:(*fftypes.UUID)(0xc000023360), Namespace:"ns1", Type:"batch_pin", Created:(*fftypes.FFTime)(nil), BlockchainIDs:fftypes.FFStringArray(nil)}
	at: [plugin.go:2190 txcommon.go:53 batch_processor.go:307 batch_manager_test.go:461 plugin.go:2232 batch_processor.go:286 retry.go:55 batch_processor.go:285 batch_processor.go:368 asm_amd64.s:1371]

Sadly it's timing rather than merge 🙃


Support for Xcode 8 with Swift 2.3

@matthewpalmer Hey!
It seems like release for Swift 2.3 will also be needed, cause iOS 10 SDK seems to break something in Locksmith.
For example following test succeeds on Xcode 7.3.1 with Swift 2.2 and iOS 9 SDK, and fails on Xcode 8 with Swift 2.3 and iOS 10 SDK
class LocksmithTestCase : XCTestCase {
    func testItemIsPersisted() {
        _ = try? Locksmith.saveData(["foo":"bar"], forUserAccount: "Account")
        let bar = Locksmith.loadDataForUserAccount("Account")
        XCTAssertEqual(bar?["foo"] as? String,"bar")
    }
}

I tried to debug the reason and it seems that when reading from Keychain on this line:
https://github.com/matthewpalmer/Locksmith/blob/master/Source/Locksmith.swift#L78
I receive status code -25300.
I'm not sure how to properly fix this and how it's related to #142.
I would be happy to provide more debug information, if you need it.

Update: turning Keychain Sharing on app target fixes the issue. However i don't have multiple apps, that wan't to share keychain items with, so this probably should not be a default. Maybe iOS 10 SDK changes some behavior, and accessGroup parameter gets into default options, even though it's not set?

@DenHeadless I believe the issue only happens in the simulator

Confirmed. Seems like turning on Keychain Sharing is the only way to fix tests) What's funny is that tests work even if there are 0 keychain groups in capabilities pane.
Anyway, thank you for quick response! Closing.


error:can't roslaunch husky_gazebo multi_husky_playpen.launch

Unable to run   multi_husky_playpen.launch
The following error message is displayed：
... logging to /home/sk/.ros/log/a47b8008-dbb8-11ee-b6ca-8db14025af37/roslaunch-sk-76259.log
Checking log directory for disk usage. This may take a while.
Press Ctrl-C to interrupt
Done checking log file disk usage. Usage is <1GB.
Resource not found: multimaster_launch
ROS path [0]=/opt/ros/noetic/share/ros
ROS path [1]=/home/sk/husky/src
ROS path [2]=/opt/ros/noetic/share
The traceback for the exception was written to the log file

The multi_husky_playpen launch file isn't included in the binary distribution of husky_gazebo. You'll need to build the package from source if you want to use that particular launch file, as well as install the multimaster_launch package.
Note that the multi-master simulation isn't well-supported and hasn't been actively maintained in some time.


ONYX-23323 | Spring Boot Plugin makes multiple calls to Vault when fetching secrets.

Desired Outcome
Spring Boot Plugin makes multiple calls to Vault when fetching secrets.
Implemented Changes
Describe how the desired outcome above has been achieved with this PR. In
particular, consider:

What's changed? Why were these changes made?
Modified the existing code scenario.
How should the reviewer approach this PR, especially if manual tests are required?
https://ca-il-jira.il.cyber-ark.com:8443/browse/ONYX-23323
Are there relevant screenshots you can add to the PR description?

Connected Issue/Story
Resolves #[relevant GitHub issue(s), e.g. 76]
CyberArk internal issue link: insert issue ID
Definition of Done
At least 1 todo must be completed in the sections below for the PR to be
merged.
Changelog

[ ] The CHANGELOG has been updated, or
[x] This PR does not include user-facing changes and doesn't require a
CHANGELOG update

Test coverage

[ ] This PR includes new unit and integration tests to go with the code
changes, or
[x] The changes in this PR do not require tests

Documentation

[ ] Docs (e.g. READMEs) were updated in this PR
[ ] A follow-up issue to update official docs has been filed here: insert issue ID
[x] This PR does not require updating any documentation

Behavior

[ ] This PR changes product behavior and has been reviewed by a PO, or
[ ] These changes are part of a larger initiative that will be reviewed later, or
[x] No behavior was changed with this PR

Security

[ ] Security architect has reviewed the changes in this PR,
[ ] These changes are part of a larger initiative with a separate security review, or
[ ] There are no security aspects to these changes

Jira link : https://jenkins.conjur.net/view/cyberark/job/cyberark--conjur-spring-boot-sdk/job/jira23323/


Feature Request: Split Requirements.txt into dev, doc, and actual

Is your feature request related to a problem? Please describe.
The current requirements file has everything. Split the packages into different files and remove the unwanted packages.

Closed by #16


how to create RGB <ucf101_rgb_val_list> ?

I have a pertained model and I want to test it with the data that I have. But I don't know how to manipulate data to feed the network. Can you tell me what should I do? Thanks

I have the same problem,Have you solved it？

unfortunately, I have still same problem

as of now, we would recommend you use  the MMAction package for all models related to our works and many others. It provides detailed guidance on how to use custom datasets.


Openvino optimised models don't work

The models optimised with the OpenVino compiler raise an error during prediction.
Error got:
'PytorchOpenVinoInferenceLearner' object has no attribute 'input_key'

Problem solved in #12


Apertium RDF - adding vartrans:relates property

In the translations, I would recommend to overload the "vartrans:source" and "vartrans:target" properties with "vartrans:relates", to allow for simpler queries (as we did in Apertium RDF v1.0).  E.g:
From :
:thousand_mil-num-en-sense-mil_thousand-num-es-sense-trans a vartrans:Translation;
    vartrans:source :thousand_mil-num-en-sense;
    vartrans:target :mil_thousand-num-es-sense.

To
:thousand_mil-num-en-sense-mil_thousand-num-es-sense-trans a vartrans:Translation;
    vartrans:source :thousand_mil-num-en-sense;
    vartrans:target :mil_thousand-num-es-sense;
    vartrans:relates :thousand_mil-num-en-sense;
    vartrans:relates :mil_thousand-num-es-sense.

Makes sense, but this is RDFS-inferrable (and can thus be automatically
recovered by the user with the correct end point settings).
If we really want to put this into the data, I would suggest to provide
the data in two versions: a "slim" version containing the information in a
minimal representation (better for exchange) and a "full" version that
contains inferrable information (better for querying).
There may be other pieces of duplicate information that could be dropped
from the slim version to save space and transfer efforts.
Best,
Christian
Am .07.2020, 13:00 Uhr, schrieb Jorge Gracia<EMAIL_ADDRESS>
In the translations, I would recommend to overload the "vartrans:source"
and "vartrans:target" properties with "vartrans:relates", to allow for
simpler >queries (as we did in Apertium RDF v1.0). E.g:
From :
:thousand_mil-num-en-sense-mil_thousand-num-es-sense-trans a
vartrans:Translation;
vartrans:source :thousand_mil-num-en-sense;
vartrans:target :mil_thousand-num-es-sense.
To
:thousand_mil-num-en-sense-mil_thousand-num-es-sense-trans a
vartrans:Translation;
vartrans:source :thousand_mil-num-en-sense;
vartrans:target :mil_thousand-num-es-sense;
vartrans:relates :thousand_mil-num-en-sense;
vartrans:relates :mil_thousand-num-es-sense.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Having such "slim" / "full" versions of the data makes sense to me.


Installing TeachOpenCADD on google colab

I am trying to install TeachOpenCADD on google colab using the instruction in the web page:
https://projects.volkamerlab.org/teachopencadd/installing.html
After installing conda in the notebook, the command below gives the following error:
!conda env create -f https://raw.githubusercontent.com/volkamerlab/TeachOpenCADD/master/environment.yml
CondaHTTPError: HTTP 404 NOT FOUND for url https://raw.githubusercontent.com/volkamerlab/TeachOpenCADD/master/environment.yml
Elapsed: 00:00.133251
An HTTP error occurred when trying to retrieve this URL.
The URL does not exist.
Could you give the right URL, please?
I cannot import the packages from teachopencadd. Thanks.

Hi @andresilvapimentel,
Thank you for bringing this up!
Can you please try:
https://raw.githubusercontent.com/volkamerlab/TeachOpenCADD/master/devtools/other-conda-envs/users_env.yml

@jaimergp can you help out with this Google Colab question?
I get the TeachOpenCADD environment installed but I am unsure how to activate it
!pip install condacolab
import condacolab
condacolab.install()
!mamba install -f https://raw.githubusercontent.com/volkamerlab/TeachOpenCADD/master/devtools/other-conda-envs/users_env.yml -n toc

Colab runs a Python process already, so we need to stay with the base environment. If you want to install stuff from a YML, update it after the kernel restart (separate cell).
!mamba env update -n base -f environment.yml

When I run the mamba by using:
!pip install condacolab
import condacolab
condacolab.install()
!mamba install -f https://raw.githubusercontent.com/volkamerlab/TeachOpenCADD/master/devtools/other-conda-envs/users_env.yml -n toc
I get the error: EnvironmentLocationNotFound: Not a conda environment: /usr/local/envs/toc
So, it does not work it...

You need to run these code blocks in two different cells:
First cell:
!pip install condacolab
import condacolab
condacolab.install()

Execute it and wait for the kernel to restart.
Second cell:
!mamba env update -n base -f https://raw.githubusercontent.com/volkamerlab/TeachOpenCADD/master/devtools/other-conda-envs/users_env.yml

Run it and then, in a third cell, you can import the packages.

Thanks.
It works!!!
Em seg., 6 de set. de 2021 às 12:06, Jaime Rodríguez-Guerra <
@.***> escreveu:

You need to run these code blocks in two different cells:
First cell:
!pip install condacolab
import condacolab
condacolab.install()
Execute it and wait for the kernel to restart.
Second cell:
!mamba env update -n base -f https://raw.githubusercontent.com/volkamerlab/TeachOpenCADD/master/devtools/other-conda-envs/users_env.yml
Run it and then, in a third cell, you can import the packages.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/volkamerlab/teachopencadd/issues/129#issuecomment-913715209,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AS3PBBNKO4ONUBXV5HAYHA3UATKIJANCNFSM5DE74GFA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

I get error 404

Hello, I want to use T005 (Clustering) tutorial. I tried all of the above steps but so far no success. Would any one help me out how can and what scripts should I use in Google colab notebook, to install and activate the said environment.
Best Regards

@dominiquesydow The installation procedure described above stopped running on google colab. Can you help me fixing this issue, please?
All the best. Thanks.


AS3 configuration GTM sync issue

Environment

Application Services Version: AS3 version 3.34.0 release 4
BIG-IP Version: <IP_ADDRESS>

Summary
Two Big-ip appliances are configured with autosync through sync-group. When using a POST or PATCH API on one of them with as3, the created objects are visible on the GUI of both. However, a GET API returns everything correctly only on the one used for the post/patch APIs, and returns 204 on the other one.
Steps To Reproduce

Submit the following declaration on the first sync-group member:
POST https://xxx/mgmt/shared/appsvcs/declare

{
    "class": "ADC",
    "schemaVersion": "3.25.0",
    "id": "GSLB_Sample",
    "Common": {
        "class": "Tenant",
        "Shared": {
            "class": "Application",
            "template": "shared",
            "testDataCenter": {
                "class": "GSLB_Data_Center"
            }
        }
    }
}

Submit the following declaration on both sync-group members:
GET https://xxx/mgmt/shared/appsvcs/declare?show=full

Observe different responses:
The API response is correct (200) on the first sync-group member, but it's 204 on the second one.
PATCH APIs only work on the first sync-group member.
All objects can be seen in the GUI of all sync-group members.

Expected Behavior
It should be possible to use APIs on any of the sync-group members without any difference in the responses.
Objects visible on a member should be visible on all of them, both in the GUI and in the AS3 APIs responses.
Actual Behavior
It is only possible to write on one member of the sync-group at a time without losing information.
POST APIs on other members overwrite everything on all members, while PATCH APIs only work on the one used for the last POST API.

Hi @noracb, please contact us at<EMAIL_ADDRESS>so we can prioritize this issue. Thanks.

Hi @noracb, thank you for reaching out. I have added this issue to our internal product backlog as AUTOTOOL-3695. We will notify you once it is resolved. Thanks.

@noracb cannot reproduce. Awaiting declaration to compare.


BUG: Flaky test in TestFactorized.test_singular_with_umfpack

Describe your issue.
(Is there some tool to automatically find these flaky tests by running the suite over and over until it finds them?  Or to let us flag them as false positives ("false negatives"?) within the PR that failed, and it will automatically create an issue from the failure and re-run the tests?  It's really frustrating to push a PR and see failures and have to dig through and find out they're not related to your PR at all.)
Reproducing Code Example
SciPy test suite as of commit 3c59bb7b
Error message
https://dev.azure.com/scipy-org/SciPy/_build/results?buildId=19024&view=logs&j=7902a2c1-7b88-5b2d-6408-84b88759c642&t=5471a576-12f4-5533-4de4-506800a17112&l=812
=================================== FAILURES ===================================
__________________ TestFactorized.test_singular_with_umfpack ___________________
[gw1] linux -- Python 3.9.13 /opt/hostedtoolcache/Python/3.9.13/x64/bin/python
scipy/sparse/linalg/_dsolve/tests/test_linsolve.py:89: in test_singular_with_umfpack
        autoTranspose = True
        indx       = array([], dtype=int64)
        mtx        = <5x5 sparse matrix of type '<class 'numpy.float64'>'
	with 0 stored elements in Compressed Sparse Column format>
        rhs        = array([1., 1., 1., 1., 1.])
        self       = <scikits.umfpack.umfpack.UmfpackContext object at 0x7fc894177730>
        sol        = array([0., 0., 0., 0., 0.])
        status     = 1
        sys        = 0

https://dev.azure.com/scipy-org/SciPy/_build/results?buildId=19024&view=logs&j=7902a2c1-7b88-5b2d-6408-84b88759c642&t=5471a576-12f4-5533-4de4-506800a17112&l=812
=================================== FAILURES ===================================
__________________ TestFactorized.test_singular_with_umfpack ___________________
[gw1] linux -- Python 3.9.13 /opt/hostedtoolcache/Python/3.9.13/x64/bin/python
scipy/sparse/linalg/_dsolve/tests/test_linsolve.py:89: in test_singular_with_umfpack
        A          = <5x5 sparse matrix of type '<class 'numpy.float64'>'
	with 0 stored elements in Compressed Sparse Column format>
        b          = array([1., 1., 1., 1., 1.])
        self       = <scipy.sparse.linalg._dsolve.tests.test_linsolve.TestFactorized object at 0x7fc8d3d6b340>
scipy/sparse/linalg/_dsolve/linsolve.py:517: in solve
    return umf.solve(umfpack.UMFPACK_A, A, b, autoTranspose=True)
        A          = <5x5 sparse matrix of type '<class 'numpy.float64'>'
	with 0 stored elements in Compressed Sparse Column format>
        b          = array([1., 1., 1., 1., 1.])
        umf        = <scikits.umfpack.umfpack.UmfpackContext object at 0x7fc894177730>
/opt/hostedtoolcache/Python/3.9.13/x64/lib/python3.9/site-packages/scikits/umfpack/umfpack.py:717: in solve
    econd = 1.0 / self.info[UMFPACK_RCOND]
E   RuntimeWarning: divide by zero encountered in scalar divide
        autoTranspose = True
        indx       = array([], dtype=int64)
        mtx        = <5x5 sparse matrix of type '<class 'numpy.float64'>'
	with 0 stored elements in Compressed Sparse Column format>
        rhs        = array([1., 1., 1., 1., 1.])
        self       = <scikits.umfpack.umfpack.UmfpackContext object at 0x7fc894177730>
        sol        = array([0., 0., 0., 0., 0.])
        status     = 1
        sys        = 0

SciPy/NumPy/Python version information
platform linux -- Python 3.9.13, pytest-7.1.2, pluggy-1.0.0

Is there some tool to automatically find these flaky tests by running the suite over and over until it finds them? Or to let us flag them as false positives ("false negatives"?) within the PR that failed, and it will automatically create an issue from the failure and re-run the tests?

Good question. We don't have a bot or other method of doing this automatically, someone must manually open an issue and then fix it or add an xfail/skip marker. I think scikit-learn recently added a bot though, so maybe that's worth copying.
Thanks for opening this issue @endolith!

It's really frustrating to push a PR and see failures and have to dig through and find out they're not related to your PR at all.

Yes, agreed. I think at the moment the flaky issue is secondary to breakages that are consistently happening (e.g. due to a change in numpy or another dependency) - but both are equally annoying.

Update: it's not a flaky test, it's consistently failing in that job. I'll fix that up.


Make sure that we require forwardable before using Forwardable

Hey @julianrubisch,
This PR solves #78.
Please check it out.
Thanks!

Hey @etagwerker thanks for catching this! Haven't looked here for a while... I'm sure it once did work, but it leaves me wondering... anyway, huge thanks!

@all-contributors add @etagwerker for code


Missing documentation for QueueUserWorkItem(Action, TState, Boolean) .

There is no documentation for QueueUserWorkItem(Action, TState, Boolean) that explains what bool preferLocal does.
This was raised in an SO question What is ThreadPool.QueueUserWorkItem preferLocal for?.
The answer shows that the method was added by this pull request fixing this issue. The issue's text and Damien's answer are a good starting point :

The issue is described as:

ThreadPool.QueueUserWorkItem always queues to the global queue; however it would be good to have the option to be able to queue to the current threadpool thread's local queue when a threadpool thread queues extra work items.

...

When the Thread Pool was first built, it only had a single queue of work to be done. However, when all of the Task goodness was being plumbed into the framework, they took the opportunity to introduce thread-local queues (and work stealing) alongside what was now renamed the global queue. It looks like this is clean-up work to allow specific access to these queues.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 21ac9edb-6827-475d-30d3-cfd3b52c3028
Version Independent ID: e13ed79b-e212-1d7a-f939-6086b300a399
Content: ThreadPool.QueueUserWorkItem Method (System.Threading)
Content Source: xml/System.Threading/ThreadPool.xml
Product: dotnet-api
GitHub Login: @dotnet-bot
Microsoft Alias: dotnetcontent

Thanks for your feedback @pkanavos. We're still in the process of documenting new .NET Core APIs and we added this one to a future sprint.


Using GeoConcerns in Sufia : demos of use cases and roadmap for future developme...

Using GeoConcerns in Sufia : demos of use cases and roadmap for future development
Suggested by: Darren Hardy
Presenter: Eliot Jordan
Format: Presentation
Audience: All

If code, yes for the dev track.

2017-07-29
GeoConcerns is a plugin to CurationConcerns for managing geospatial resources in a repository (geoconcerns.github.io). This presentation will give an overview and demonstration of GeoConcerns’ features and PCDM-based data model, and discuss future development such as integration with Sufia.

Title: Building a geospatial repository with GeoConcerns
GeoConcerns is a plugin to CurationConcerns for managing geospatial resources in a repository (http://geoconcerns.github.io). This presentation will give an overview and demonstration of GeoConcerns’ features and PCDM-based data model. In addition, we will discuss the code base and future development work such as integration with Sufia.
The target audience for the talk is primarily developers and managers.
Just a note that the title of the talk is different from the one proposed on the Hydra Connect wiki, and that Darren Hardy from Stanford will be co-presenting.

8/20
That's great!  As to your questions.

We're still willing. I see we're already on the schedule, so we don't really have a choice. ;)
Eliot Jordan + Darren Hardy
Recording is fine.
The description looks good.
We're both registered and ready to go.

Let us know if you need anything else.


Fix: setup fixture cleanup fails

Why is this PR needed?
The setup fixture's cleanup tries to retrieve the logs from nodes.
If the platform could not be allocated, it fails preventing the
actual cluster cleanup to be executed.
Fixes https://github.com/SUSE/avant-garde/issues/1432
Reminder: Add the "fixes bsc#XXXX" to the title of the commit so that it will
appear in the changelog.
What does this PR do?
Ignores exceptions trying to retrieve logs
Merge restrictions
(Please do not edit this)
We are in v4-maintenance phase, so we will restrict what can be merged to prevent unexpected surprises:
What can be merged (merge criteria):
    2 approvals:
        1 developer: code is fine
        1 QA: QA is fine
    there is a PR for updating documentation (or a statement that this is not needed)

All tests green, this minimalist change solving issues on OpenStack clearing resources (causing issues to QA) and strictly tied to CI. Also needed to ensure that openstack e2e tests do not over eat resources that QA needs. Merging


???

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4c0ccb95-a7bb-149b-c108-6e05bd6250cb
Version Independent ID: 100b846e-b653-e339-69b0-7fffd03bbd9a
Content: Microsoft Edge support for Microsoft Defender SmartScreen
Content Source: edgeenterprise/microsoft-edge-security-smartscreen.md
Product: microsoft-edge
GitHub Login: @dan-wesley
Microsoft Alias: kvice

@severus0629 Hello - If you would like to report a Microsoft Edge Enterprise documentation issue to the team please open a new issue and include relevant information/repro steps in the Comment section.
If you have general questions regarding Microsoft Edge please reach out on the Microsoft Edge Tech Community Forum or for Enterprise specific questions please visit the Enterprise section of the Tech Community. Thanks!


Connecting to Google Fit Consent Screen Denying one of multi permissions will not connect.

My app is trying to connect to Google Fit. The user is prompted to pick a Google Account and once picked, the "Consent Screen" shows up requiring users to accept or deny each permission. There are separate screens for each permission. Once the user has gone through each permission pop up to accept or deny, a main screen appears that shows a list of all the permissions with check marks next to the ones that the user had allowed. If the user denies one or more of the permissions, it usually closes the pop up, shows a spinner, and then restarts the consent screen pop ups to force the user to go through each permission pop up and then continues to the main pop up of the whole list of permissions.

My app is trying to connect to Google Fit. The user is prompted to pick a Google Account and once picked, the "Consent Screen" shows up requiring users to accept or deny each permission. There are separate screens for each permission. Once the user has gone through each permission pop up to accept or deny, a main screen appears that shows a list of all the permissions with check marks next to the ones that the user had allowed. If the user denies one or more of the permissions, it usually closes the pop up, shows a spinner, and then restarts the consent screen pop ups to force the user to go through each permission pop up and then continues to the main pop up of the whole list of permissions.

@kdongare
It seems like the latest style of google sign.Maybe what we see on the Internet and what we default seems to be out of date.
https://developers.googleblog.com/2018/10/more-granular-google-account.html

@codingjeremy Do you have any insight on this , I am facing the same issue .


Add CBMC patch to remove volatile qualifier from some variables

Description
The proposed patch removes the volatile qualifier from a few static global variables declared in the tasks.c file. This patch will be necessary for the majority of the incoming task pool management proofs.

Can we please write a comment in each place that a volatile has been removed to say why it is safe for the volatile to be removed.  For example, uxPendedTicks is incremented in potentially nested interrupts and decremented in multiple tasks - so we need to show an analysis of why it is ok to remove volatile, and if removing volatile is ok, also change the code that takes a non volatile copy in one location for optimization.  We also need to ensure that any future use of now non-volatile variables is not going to introduce issues accidentally as people may assume the variable is volatile.

Thanks Richard. Just to clarify---this particular PR isn't actually modifying the FreeRTOS kernel in the source tree. It is actually a patch that we apply to the kernel just before we run CBMC over it in continuous integration, but the code in the repository is not affected.
Nevertheless, your suggestion to add comments to the patch is a good one, it will help to document why it's okay to remove voliatile in each case.

Thanks @RichardBarry and @karkhaz for the suggestions.
I have now updated the patch file with an extensive comment regarding the volatile behavior in CBMC and why it is a problem for task pool proofs. Let me know if you have any questions.

/bot run checks

This fails one of the CBMC checks.

/bot run checks


textDocument/semanticTokens/full/delta doesn't work

Hello, from initialize capabilities, rust-analyzer responses with full: {delta: true}, but in my tests, rust-analyzer doesn't response for delta request:
Full request:
Sending request 'textDocument/semanticTokens/full - (22)'.
Params: {
    "textDocument": {
        "uri": "file:///Users/fannheyward/src/hello-rust/src/main.rs"
    }
}

Full response:
Received response 'textDocument/semanticTokens/full - (22)' in 6886ms.
Result: {
    "resultId": "1",
    "data": [
        0,
        0,
        2,...
    ]
}

Delta request:
Sending request 'textDocument/semanticTokens/full/delta - (37)'.
Params: {
    "textDocument": {
        "uri": "file:///Users/fannheyward/src/hello-rust/src/main.rs"
    },
    "previousResultId": "1"
}

Delta response, still full response:
Received response 'textDocument/semanticTokens/full/delta - (37)' in 21ms.
Result: {
    "resultId": "2",
    "data": [
        0,
        0,
        2,...
    ]
}

Can you show your tests? Also are you saying that it's responding with the
incorrect type or that the delta contains the full set of tokens? The spec
allows for the full set to be returned if it cannot compute a delta for
some reason. One reason for this would be that the client has requested a
refresh or we have reloaded the workspace.
On Tue, Mar 30, 2021, 5:46 AM Heyward Fann @.***> wrote:

Hello, from initialize capabilities, rust-analyzer responses with full:
{delta: true}, but in my tests, rust-analyzer doesn't response for delta
request:
Full request:
Sending request 'textDocument/semanticTokens/full - (22)'.
Params: {
"textDocument": {
"uri": "file:///Users/fannheyward/src/hello-rust/src/main.rs"
}
}
Full response:
Received response 'textDocument/semanticTokens/full - (22)' in 6886ms.
Result: {
"resultId": "1",
"data": [
0,
0,
2,...
]
}
Delta request:
Sending request 'textDocument/semanticTokens/full/delta - (37)'.
Params: {
"textDocument": {
"uri": "file:///Users/fannheyward/src/hello-rust/src/main.rs"
},
"previousResultId": "1"
}
Delta response, still full response:
Received response 'textDocument/semanticTokens/full/delta - (37)' in 21ms.
Result: {
"resultId": "2",
"data": [
0,
0,
2,...
]
}
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/rust-analyzer/rust-analyzer/issues/8253, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABBACRBI6TV76L3FWNL24F3TGGMVXANCNFSM42BUYPVA
.

The spec allows for the full set to be returned if it cannot compute a delta for some reason

I missed this.

To be clear... Does it eventually report a delta? I do want to make sure
that it's working.
On Tue, Mar 30, 2021, 7:22 AM Heyward Fann @.***> wrote:

The spec allows for the full set to be returned if it cannot compute a
delta for some reason
I missed this.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/rust-analyzer/rust-analyzer/issues/8253#issuecomment-810141080,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABBACREEWKWKWLVA5EUQO7DTGGX77ANCNFSM42BUYPVA
.

No. Client requests textDocument/semanticTokens/full, RA returns full response, after some code changed, client requests textDocument/semanticTokens/full/delta, but RA still returns full response.

That's concerning. Can you post a test or something that reproduces the
issue?
On Tue, Mar 30, 2021, 7:31 AM Heyward Fann @.***> wrote:

No. Client requests textDocument/semanticTokens/full, RA returns full
response, after some code changed, client requests
textDocument/semanticTokens/full/delta, but RA still returns full
response.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/rust-analyzer/rust-analyzer/issues/8253#issuecomment-810146704,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABBACRCRYN5QAY6MXVPXZQTTGGZB7ANCNFSM42BUYPVA
.

cargo new helloworld and cd into
code ., enable "rust-analyzer.trace.server": "verbose"
search semanticTokens/full in rust-analyzer language server trace logs
the first time, RA returns full tokens
make any changes, change Hello, world to Hello
client requests textDocument/semanticTokens/full/delta, but RA still returns full tokens


setMultiSelection(false) not working

Even when i set: setMultiSelection(false); browser allow user to select multiple files.

Same problem.

Hi
I've tried to resolve the issue, but it seems that it's a bug in the original Plupload library. All I'm doing here is passing the configuration from the server side to the client side. I will investigate this matter further. As for now, the only reliable method is to use the listeners to prevent addition of more than 1 file at once (but the browser will be able to pick more than one file).

Windows 7 and Internet Explorer 11.
I've set setMultiSelection(false) and addFilesAddedListener(..)  for block all multiple uploads.
But there is the same problem:

try to upload multiple files
block with message "Multiple files upload not supported. Please select one file only."
try to upload 1 file and pupload pluign load all files

Please help me and fix this bug.

Hi
As I've said, the issue is not with the addon, but with the original Plupload JS library. I wasn't able to fix it, but I made a workaround, that you can find in the PluploadField source code. Basically you can define a listener on file addition, that will check if there is already a file in the queue and automatically remove/ignore the new/second file.
regards
eXsio

OK perfect,
I manipulate queue of files in my FilesAddedListener.
Thanks for the support.
Regards,
Alberto


[release-0.19] Add the transformer for pingsource to keep the env vars and replicas

Cherry-pick: eaf60c26acaa42995ff456116a274e382c5d886c
Proposed Changes

Add the transformer for pingsource to keep the env vars and replicas

Add the deployment kafka-ch-dispatcher and imc-dispatcher into the transformer

Covert into the deployment

Refactor the transformer for the pingsource only

Release Note

/retest

/retest
:thinking:

/test pull-knative-operator-upgrade-tests

/retest

/test pull-knative-operator-upgrade-tests

/lgtm


Added camera position to the user's PVS

I noticed in multiple servers and even my local server that the cam
controller never rendered entities outside of the user's PVS.
In this commit I've added the SetupPlayerVisibility hook to add the
position of the active camera to the player's PVS, so they can see
entities.
Before fix:

After:

Nice

Oh hey that's a nice hook! Very cool! Is there any sort of corresponding Remove function to go with it? Maybe it auto clears every frame, or something...

I believe it's an auto-clear because after I commented out the AddOriginToPVS function with auto-refresh on it stopped rendering those outside PVS. It seems the hook calls constantly, so must clear every frame, but I notice no increase in processing.

I did not know about this hook, or I would have used it long ago. I tried to use an ugly hack using SetViewEntity instead, but that only works as long as the camera is parented.

Fix'd

Great idea. I was always annoyed with stuff disappearing from my breenrocket's view when I didn't see them myself :)

My apologizes. I noticed the localized, but for some reason I thought it was getting changed to world position after a certain function. Not sure why I thought that.
I'm glad this issue could be resolved and thank you for fixing it up for localized position. I'll be sure to do more testing before committing.

I have an idea why you thought that :)

This should fix sound/soundscape issues too right?

Yes it should. It sends all the data of the entities within the PVS, or the visleaf, and therefor the calling of sounds should occur.

Cool. I've long waited for somebody to fix this.
(Garry still needs to fix water sounds inside vehicles though; you can still hear water if you enter a seat underwater and then surface, and you don't hear water sounds if you enter a seat and submerge. Everyone can still reproduce this right?)

I've found that only occurs if you attempt to move the vehicle while underwater (thus killing the engine). Valve didn't expect players to be able to get a dead jeep out of the water without exiting it so they stop checking if the water sound should be stopped if the engine is dead for some reason. If you enter the water and exit the water with thrusters without using the w a s d keys, it won't bug out like that.


multiprocessing causes hanges due to tensorflow

Issue described here:
https://github.com/tensorflow/tensorflow/issues/8220
problem can be resolved by putting import tensorflow worker function

fixed in #67


Add logs offloading

What does this PR do ?
This PR adds a warning if there is any parameters on the meta device because of the offloading.

Apart from Zach's comment, LGTM, thanks. I assume this is in response to https://github.com/huggingface/accelerate/issues/2074?

Yes it is

Only question for me is if the warning can be raised earlier already, e.g. line 386, or if it has to be at this point.
The model is dispatched after attach_align_device_hook_on_blocks, so we can raise it after this function. I will do the modification.


Refresh Header

Task

[ ] Add the campaign.name to the header for each campaign. Corresponding components are components/CampaignCards.vue and views/campaign.vue

/assign


Native module initialisation does not work on tvOS

On React Native 0.64 I catch the error:
Error: Failed to create a new MMKV instance, the native initializer function does not exist. Is the native MMKV library correctly installed? Make sure to disable any remote debugger (e.g. Chrome) to use JSI!
which means that native C++ initialisation failed. I use Reanimated 2, so it's all good with JSI. Could somebody please give me a hint on how to debug this issue further?

For those who will stumble on this, it's due to the current version of MMKV does not target tvOS. PR was already merged to the main MMKV repo and we just wait for the new release - it will make react-native-mmkv  available to run on tvOS.


[AutoPR datafactory/resource-manager] [DataFactory] Changing arguments to object to support oneOf - this will allow param…

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/7295

This PR has been merged into https://github.com/Azure/azure-sdk-for-go/pull/5918


which cosmic-desktop-amd64.iso should I download?

in gpd-pocket2-ubuntu/gpd-pocket2-ubuntu-respin.sh
commit 7bc1ab79c7076645e8cd9e87bed6aa74d039a053
line 15
FYI
I use ubuntu mate 18.04.1, should these scripts work well?
thanks.

thanks for updating the README.md & the link to https://ubuntu-mate.org/gpd-pocket/


FIX: mne.io.read_raw_fil handling of bad channels

Reference issue
Fixes #12594.
What does this implement/fix?
Changes the ordering that the info struct is populated in read_raw_fil so that bad channels can be read straight from the channels.tsv file without raising an error.

I think I've attempted to be simultaneously too clever and not enough here. Pandas isn't a part of the minimal requirements so I should seek an alternative method to manipulate the channels.tsv file in testing.

The formatter removes those parameters because they're the defaults
but I was talking encoding=...
otherwise the encoding used will be platform-dependent


Fix some Kconfig nits

Commit messages say it all:
samples/net/lldp/Kconfig: Get rid of leftover 'option env'

'option env' is no longer required. Kconfiglib expands references to
environment variables directly.

arch: arm: kconfig: Remove redundant FLOAT dependencies

The choice that contains FP_HARDAPI and FP_SOFTAPI already depends on
FLOAT, so the choice symbols don't have to.

Codecov Report

Merging #9517 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9517   +/-   ##
=======================================
  Coverage   52.19%   52.19%
=======================================
  Files         215      215
  Lines       26010    26010
  Branches     5594     5594
=======================================
  Hits        13576    13576
  Misses      10175    10175
  Partials     2259     2259

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fe581c...6511d4f. Read the comment docs.


RUM Data Not Recorded for WebView on Android

Question
I am trying to use the example provided at https://github.com/DataDog/dd-sdk-flutter/tree/develop/packages/datadog_webview_tracking/example to record RUM data for WebView using Datadog. The recording works correctly on iOS, but it does not record anything on Android. Additionally, the following logs are displayed in the console during execution. This issue occurs on both emulators and physical devices.
Logs
E/Datadog ( 7273): [_dd.sdk_core.default]: Uncaught exception during the task execution
E/Datadog ( 7273): java.lang.NoSuchMethodError: No interface method write(Lcom/datadog/android/api/storage/EventBatchWriter;Ljava/lang/Object;)Z in class Lcom/datadog/android/api/storage/DataWriter; or its super classes (declaration of 'com.datadog.android.api.storage.DataWriter' appears in /data/app/~~XRDqsLm8VFd9s5KRvGrVLw==/com.datadoghq.flutter.webview.example-yQdeegDCeqn6nwTtReGrGw==/base.apk)
E/Datadog ( 7273):      at com.datadog.android.webview.internal.rum.WebViewRumEventConsumer$consume$1.invoke(WebViewRumEventConsumer.kt:46)
E/Datadog ( 7273):      at com.datadog.android.webview.internal.rum.WebViewRumEventConsumer$consume$1.invoke(WebViewRumEventConsumer.kt:41)
E/Datadog ( 7273):      at com.datadog.android.core.internal.SdkFeature$withWriteContext$1.invoke(SdkFeature.kt:177)
E/Datadog ( 7273):      at com.datadog.android.core.internal.SdkFeature$withWriteContext$1.invoke(SdkFeature.kt:177)
E/Datadog ( 7273):      at com.datadog.android.core.internal.persistence.ConsentAwareStorage.writeCurrentBatch$lambda$1(ConsentAwareStorage.kt:89)
E/Datadog ( 7273):      at com.datadog.android.core.internal.persistence.ConsentAwareStorage.$r8$lambda$SRgNYV2h4JQ8NXSPfSTUU6FujmQ(Unknown Source:0)
E/Datadog ( 7273):      at com.datadog.android.core.internal.persistence.ConsentAwareStorage$$ExternalSyntheticLambda0.run(Unknown Source:10)
E/Datadog ( 7273):      at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:487)
E/Datadog ( 7273):      at java.util.concurrent.FutureTask.run(FutureTask.java:264)
E/Datadog ( 7273):      at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
E/Datadog ( 7273):      at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:644)
E/Datadog ( 7273):      at java.lang.Thread.run(Thread.java:1012)

Steps to Reproduce

Clone the repository and navigate to the example directory: https://github.com/DataDog/dd-sdk-flutter/tree/develop/packages/datadog_webview_tracking/example
Follow the instructions to set up the example for both iOS and Android.
Ensure the following package versions are used:

datadog_flutter_plugin: ^2.8.0
datadog_webview_tracking: ^2.0.2
webview_flutter: ^4.8.0

Use Flutter version 3.19.0.
Run the example on an Android device.
Observe that RUM data is not recorded on Datadog for Android, while it works correctly for iOS.
Check the console logs on Android for the error messages mentioned above.

Expected Behavior
RUM data should be recorded for WebView on both iOS and Android.
Screenshots
If applicable, add screenshots to help explain your problem.
Android

iOS

Environment

flutter doctor -v
$ flutter doctor -v
[✓] Flutter (Channel stable, 3.19.0, on macOS 14.2.1 23C71 darwin-arm64, locale ja-JP)
    • Flutter version 3.19.0 on channel stable at /Users/user/fvm/versions/3.19.0
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision bae5e49bc2 (9 months ago), 2024-02-13 17:46:18 -0800
    • Engine revision 04817c99c9
    • Dart version 3.3.0
    • DevTools version 2.31.1

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/user/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: /Applications/Android Studio 2.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.11+0-17.0.11b1207.24-11852314)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.4)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15F31d
    • CocoaPods version 1.16.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2024.1)
    • Android Studio at /Applications/Android Studio 2.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.11+0-17.0.11b1207.24-11852314)

[✓] VS Code (version 1.95.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.100.0

[✓] Connected device (5 available)

[✓] Network resources
    • All expected network resources are available.

• No issues found!

Please let me know if there is any additional information or steps I can provide to help diagnose this issue. Thank you!

Hi @tksou ,
Thanks for reporting!
It looks like we may have introduced an incompatibility between the main package and the webview package because of a change on the native side. I'll try to get this fixed and release an updated version of this package next week.
If you need an immediate workaround (and want to check if this is the problem) you can force your application to take the updated native dependency by adding this to your app/build.gradle:
dependencies {
    implementation "com.datadoghq:dd-sdk-android-webview:2.14.0"
}

If you already have a dependencies section just add the one line.

Hi @fuzzybinary ,
Thank you very much for your prompt response.
As you suggested, adding the dependency resolved the issue and RUM data is now being recorded from the WebView on Android. Your assistance was very helpful in identifying the cause of the problem.

I'll try to get this fixed and release an updated version of this package next week.

Understood. I look forward to the package update.
Thanks again for your support!

Thanks @tksou!
Good to hear we have a workaround for you. I'm going to reopen though as this is still an issue that needs to be resolved. I'll close it when I release the new version.

Hi @tksou
This should now be fixed in datadog_webview_tracking version 2.1.0 which is now on pub.
Thanks for reporting and sorry for the inconvenience.

Hi @fuzzybinary ,
Thank you! I have tried it with datadog_webview_tracking version 2.1.0, and it works perfectly even after removing the workaround.
Thanks again for the quick fix!


Coveralls

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@c2363be). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master       #4   +/-   ##
=========================================
  Coverage          ?   66.09%
  Complexity        ?      593
=========================================
  Files             ?      108
  Lines             ?     3241
  Branches          ?      336
=========================================
  Hits              ?     2142
  Misses            ?     1006
  Partials          ?       93

Impacted Files
Coverage Δ
Complexity Δ

.../google/firebase/functions/FunctionsRegistrar.java
60.86% <0%> (ø)
2 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2363be...70f6cf4. Read the comment docs.


[Idea]: Achieving higher FPS from FFmpeg: Both RAW and RENDER.

Faster frame rates from FFmpeg by YUV

YUV420 vs RGB24

Hey! It looks like you've got yourself quite the well-built FFmpeg-for-Python package here. I've been down this rabbit hole myself and thought I'd share some tips for optimizing performance. The speed of FFmpeg's input to Python can be massively accelerated by use of the YUV420 format instead of RGB.
The far and away most prevalent video format on the planet today is YUV 4:2:0. MP4's, DVDs, Blu-ray even, all come packed in YUV420... This is because it stores the raw binary of each pixel within an average of 12-bits, instead of the 24-bits per pixel consumed by RGB/BGR formats. So, literally half the diskspace.
In my own testing I've found that asking FFmpeg to output YUV420 video as RGB ends up taking significantly longer than collecting the raw YUV data and transforming it to RGB within Python. And that fact is a bit unintuitive. I would certainly expect FFmpeg's multi-processor operations to handle every aspect of video faster than anything a library in Python could. But the slow down that simply can't be overcome here is in the data pipe itself.
Every frame of RGB video is twice as much data to move through memory space, compared to YUV420. And that access-speed-inhibitor is so massive that even a single-threaded, blocking operation - grabbing one frame at a time from the FFmpeg pipe, shaping that frame into a compatible NumPy array, and pushing the resulting array through an OpenCV transform matrix (YUV2RGB_I420) - is FASTER!
Benchmarks
Render

On my AMD Ryzen 2700 (6 core / 12 virtual) platform, I get about 75fps from your 'deFFcode' library when rendering a 1080p mp4 to an OpenCV window, using the sample code provided in the documentation.
On the same system, my own little script (https://github.com/roninpawn/ffmpeg_videostream/) renders about the same 74fps to a PyGame window when I set it to pull RGB in from the FFmpeg pipe.
BUT! When I allow my script to ingest as YUV, then convert to RGB using OpenCV, it renders 102fps to screen via PyGame.

RAW

When ingesting frames RAW and discarding them (no draw or other operation) using deFFcode, I see 95fps on the same 1080p clip.
Again, this matches (96fps) what my script gets when forced to ingest as RGB.
BUT! When I ingest from FFmpeg as YUV, convert to RGB using OpenCV, and then discard the frames, I get 155fps.
And the real CRUSHER is: If I ingest that mp4 as YUV, and I DON'T convert it to RGB, the entire video processes at 213fps.

Threading Possbilities for YUV -> RGB
Additionally, even higher speeds are theoretically possible, if multiple threads are established for the YUV -> RGB process separately from a RAW ingest-stacking process.
If one thread is dedicated to queueing 'up to X frames' worth of raw binary snips from the FFmpeg pipe, and another thread is established to process and queue 'up to X frames' of YUV2RGB converted frames, the ingest function ceases to block the processing function and the processing function ceases to block ingest. Resulting in the CPU spinning as fast as it can to have multiple frames ready, for whatever method might come along to ask for one.
Wrap-Up
With appropriate configuration I presume a developer could accomplish everything I've described using your library as it exists today. But I think the following are worth considering across continued development:

Implementing YUV as the default ingest for FFmpeg instead of RGB
Including stock methods for returning RGB from a raw YUV ingest
Threading those methods for maximum throughput
Communicating the benefits of YUV 4:2:0 over RGB in documentation

All that said, it really depends on how you choose to define the scope of your library whether any of this fits. I just wanted to pass the results of my own tests and development with FFmpeg in Python, along for your consideration. Again, here's the link to the script I developed atop Karl Kroening's 'ffmpeg-python' library if you care to look it over. It's short and sweet: https://github.com/roninpawn/ffmpeg_videostream/
My Current Environment

DeFFcode version:  0.2.0
Python version:  3.7.2
Operating System and version: Windows 10

@roninpawn Thank you for detailed and well-explained post. It sounds very interesting to me and you've made some very good suggestions.
But let's get down to the nitty-gritty of practically implementing these ideas. I'll focus on Wrap-up part of the post and will discuss each point one-by-one here:

Implementing YUV as the default ingest for FFmpeg instead of RGB

Yes, but currently RGB(or BGR) is the only accepted pixel format for approximately 98% of the Computer Vision Libraries that I know in Python. And that's huge, so in my opinion it RGB is most adaptable Pixel format for DeFFcode even being on the slower side. And what I think is better is to add a well-made note for the end user, explaining them to use YUV format for achieving faster raw performance while decoding and it's their choice to use frame_format="yuv420" according to their application. What you think?

Including stock methods for returning RGB from a raw YUV ingest
BUT! When I ingest from FFmpeg as YUV, convert to RGB using OpenCV, and then discard the frames, I get 155fps.

This is very good, but I need to do some benchmarks to believe this. Actually, it seems to good to be true, and I need some internal  testing to draw any conclusions. Also, I'm not going to use OpenCV at all in DeFFcode because it is designed in the first place to replace OpenCV in my vidgear library, but rather I'll be implementing a well-optimized YUV to RGB converter here myself in cython.

Threading those methods for maximum throughput

@roninpawn  That's a big no. Threading is do not mixes well with subprocess  module that DeFFcode currently uses to run its FFmpeg Pipeline from my years of experience with my other vidgear library, and will result in IO errors, missing frames, corrupted output, and other anomalies. However a buffer queue mechanism is a possibility but that will slow things down as seen vidgear's CamGear API. In my opinion as raw YUV ingested FFmpeg pipeline runs faster already, we can leave this enhancement.

Communicating the benefits of YUV 4:2:0 over RGB in documentation

Yeah, that's doable and I'm thinking the same as you. Rather than enforcing YUV in general, let the user decide what they want.

All that said, it really depends on how you choose to define the scope of your library whether any of this fits. I just wanted to pass the results of my own tests and development with FFmpeg in Python, along for your consideration. Again, here's the link to the script I developed atop Karl Kroening's 'ffmpeg-python' library if you care to look it over. It's short and sweet: https://github.com/roninpawn/ffmpeg_videostream/

Yes I'm well aware of your work and I think you did a commendable job with the things in hand. I personally wasn't in favor of ffmpeg-python, and wanted to implement solution myself to have full control over the library. I've also considered other wrappers but some have installation problems, others have no support for hardware decoding: https://github.com/abhiTronix/vidgear/issues/148

Too Good to be True
It does "seem too good to be true," doesn't it! ;) This notion that FFmpeg's insanely optimized multi-processing could have its legs swept by low-level, old-school 'bandwidth' issues, is ridiculously unintuitive! But where I presume that FFmpeg achieves its YUV>RGB transforms faster than the OpenCV library can, FFmpeg still ends up needing to push 6-million bytes of RGB through a pipe, instead of 3-million bytes of YUV -- per frame!
Which I suppose is something like deciding whether to carry an inflatable bed up from the basement, BEFORE or AFTER, you've inflated it. 😄
Benchmarks
While I know this is no supplement for the benchmarks you'll want to craft and run on deFFcode, I have these figures in pocket so I'll share them anyway. These are the results of the RAW access and PyGame-Rendered benchmarks I wrote to test the various implementations of my 'FFmpeg Videostream' class object.
Given the matched results I got testing deFFcode>RGB against my Videostream>RGB script, I would expect you to find similar results. Notwithstanding Intel vs AMD type factors.
    1920x1080:
        --- TEST #1: FFmpeg > RGB24 > RAW (no draw)
        Processed 8216 frames at (1920, 1080) resolution from 'test_video.mp4' in 85.251 seconds.
        Effective rate of 96.4 frames per second.

        --- TEST #2: FFmpeg > YUV420p > RAW (no draw)
        Processed 8216 frames at (1920, 1080) resolution from 'test_video.mp4' in 38.444 seconds.
        Effective rate of 213.7 frames per second.

        --- TEST #3: FFmpeg > YUV420p > OpenCV:RGB (no draw)
        Processed 8216 frames at (1920, 1080) resolution from 'test_video.mp4' in 52.765 seconds.
        Effective rate of 155.7 frames per second.

        --- TEST #4: FFmpeg > YUV420p > OpenCV:BGR (no draw)
        Processed 8216 frames at (1920, 1080) resolution from 'test_video.mp4' in 54.155 seconds.
        Effective rate of 151.7 frames per second.

        Begin Pygame DRAW Tests
        --- TEST #5: FFmpeg > RGB24 > PyGame
        Processed 8216 frames at (1920, 1080) resolution from 'test_video.mp4' in 110.814 seconds.
        Effective rate of 74.1 frames per second.

        --- TEST #6: FFmpeg > YUV420p > OpenCV:RGB > PyGame
        Processed 8216 frames at (1920, 1080) resolution from 'test_video.mp4' in 80.303 seconds.
        Effective rate of 102.3 frames per second.

        --- TEST #7: FFmpeg > YUV420p > OpenCV:BGR > PyGame
        Processed 8216 frames at (1920, 1080) resolution from 'test_video.mp4' in 82.463 seconds.
        Effective rate of 99.6 frames per second.

        --- TEST #8: PyGame scales frame in BGR
        Processed 8216 frames at (1920, 1080) resolution from 'test_video.mp4' in 89.591 seconds.
        Effective rate of 91.7 frames per second.

        --- TEST #9: PyGame scales frame in RGB
        Processed 8216 frames at (1920, 1080) resolution from 'test_video.mp4' in 88.831 seconds.
        Effective rate of 92.5 frames per second.

    1280x720:
        --- TEST #1: FFmpeg > RGB24 > RAW (no draw)
        Processed 3819 frames at (1280, 720) resolution from '720_test.mp4' in 15.701 seconds.
        Effective rate of 243.2 frames per second.

        --- TEST #2: FFmpeg > YUV420p > RAW (no draw)
        Processed 3819 frames at (1280, 720) resolution from '720_test.mp4' in 6.753 seconds.
        Effective rate of 565.5 frames per second.

        --- TEST #3: FFmpeg > YUV420p > OpenCV:RGB (no draw)
        Processed 3819 frames at (1280, 720) resolution from '720_test.mp4' in 10.635 seconds.
        Effective rate of 359.1 frames per second.

        --- TEST #4: FFmpeg > YUV420p > OpenCV:BGR (no draw)
        Processed 3819 frames at (1280, 720) resolution from '720_test.mp4' in 10.553 seconds.
        Effective rate of 361.9 frames per second.

        Begin Pygame DRAW Tests
        --- TEST #5: FFmpeg > RGB24 > PyGame
        Processed 3819 frames at (1280, 720) resolution from '720_test.mp4' in 21.44 seconds.
        Effective rate of 178.1 frames per second.

        --- TEST #6: FFmpeg > YUV420p > OpenCV:RGB > PyGame
        Processed 3819 frames at (1280, 720) resolution from '720_test.mp4' in 15.994 seconds.
        Effective rate of 238.8 frames per second.

        --- TEST #7: FFmpeg > YUV420p > OpenCV:BGR > PyGame
        Processed 3819 frames at (1280, 720) resolution from '720_test.mp4' in 16.04 seconds.
        Effective rate of 238.1 frames per second.

        --- TEST #8: PyGame scales frame in BGR
        Processed 3819 frames at (1280, 720) resolution from '720_test.mp4' in 17.386 seconds.
        Effective rate of 219.7 frames per second.

        --- TEST #9: PyGame scales frame in RGB
        Processed 3819 frames at (1280, 720) resolution from '720_test.mp4' in 17.493 seconds.
        Effective rate of 218.3 frames per second.

I can add to this benchmark that in an experimental build of my script I added a "Threaded Frames Extractor" method based on Benjamin Love's work here: https://github.com/bml1g12/benchmarking_video_reading_python, and liberated an extra 10-15fps over TEST 3 from the list above. The method simply stacks a threaded queue of unprocessed frames from the bytestream. I have not tested the virtue of threading the YUV > RGB process, either alone or in conjunction with this.
YUV > RGB Transform Method
I'm thrilled to hear that you mean to implement your own method(s) for color-space conversion! My first thought, once I realized the throughput benefit of ingesting as YUV, was "there's got to be a better transform than OpenCV out there!" In particular, I was hoping for a hardware implementation.
I don't know the hardware end of things, nor the difficulties of accessing dedicated GPU functions from within Python. All I know is that MP4 is decoded at a relative BLAZE even on weakly-powered tablets and phones, where manufacturers seek to advertise the many 'hours of Netflix' you can watch on a single battery charge. With that, my assumption is: modern processors include dedicated hardware for the screen-rendering and decoding of YUV420p and its common variants. But, like I say: These are darts thrown in the dark.
I'm also currently under the impression that Simple DirectMedia Layer (SDL) https://www.libsdl.org/ implements methods that render a YUV pipe direct to screen. And I intended to look into this at some point.
What do I think?
It's a difficult call. My benchmarks suggest a 25-33% performance increase with YUV ingest + local RGB conversion. And that's a LOT of performance to leave on the table. Especially knowing that most developers will never so much as dream there could be such massive benefits by this approach.
On the other hand, it is highly specific. And there are additional concerns where increased CPU usage comes into play. It's been my experience that FFmpeg, left to handle the YUV > RGB conversion on it's own consumes about 50% of my CPU while active. When OpenCV is implemented for the conversion, I see a bump of around 10% additional core usage. Which could be a factor to a given developer.
Also, 12-bit YUV is technically a lossy format, I believe. Some color information is lost in reducing the storage footprint. The human eye doesn't notice the difference, and subsampling helps maintain the accuracy of input to output. But there's no guarantee of perfect fidelity.
That's not a problem if the source is already in this -- the most-common format on the planet. But if the source is not already 12-bit YUV, implicitly forcing an RGB or BGR source to 12-bit YUV would not be suitable for fine scientific purposes, where the color-averaging that occurs across pixel quadrants would skew results. (Don't just take my word for everything in these last 2 paragraphs -- this is what I THINK I understand of it all)
With those considerations: I suppose I agree. deFFcode should not default FFmpeg's output to YUV420p.
(Acknowledging that even 24-bit RGB is implicitly lossy upon a 32-bit RGB source. And you kind of just have to pick a default.)
But I also feel that merely documenting the benefits of the proposed FFmpeg > YUV420p > RGB method isn't enough. Many will never discover that for the cost of two extra lines of code they might increase the speed of their application by a full 1/3rd; That for every hour-long job they queue, they might've been loading up the next one in just 40 minutes.
With that in mind I would propose for consideration: A public method that implements this local YUV > RGB concept. One that can be optimized and maintained by the library's developers; which implements the library's own conversion matrix, and that is perhaps even benefited by the kind of queue'd frame preparation Benjamin Love tested in his benchmarks.
Because ultimately, I see it as a public-awareness challenge that needs overcome. And by maintaining a stock-method, (especially if appropriately named) unfamiliar developers draw nearer to discovering what - in likely the MAJORITY of all use cases - is measurably the fastest, most powerful, and best solution going. Noting again that the majority of the world's video media is encoded and circulated in this format, and that the stock FFmpeg>RGB method, leaves 25-33% of attainable efficiency untapped.
Those are my thoughts.


chore(main): release 1.1.0

:robot: I have created a release beep boop
1.1.0 (2023-08-03)
Features

get json from URL (114fdf9)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/aws-samples/aws-auto-inventory/releases/tag/v1.1.0 :sunflower:


FAILED test_fib.py::test_zeroth_fibonacci - RecursionError: maximum recursion depth exceeded in comparison

RecursionError: maximum recursion depth exceeded in comparison


Add python-fsutil.

python-fsutil provides a simple and intuitive interface for common file operations:
https://github.com/fabiocaccamo/python-fsutil/

Thank you for the PR. Please see note on #208


Returning strings as numbers

Very excited to see this coming together!
While creating types to use for now based on the result data, curious why these four are strings instead of numbers?

genesis_fee
value
offset
sat_ordinal

That is because those integer values sometimes do not fit in JS's number primitive so I had to handle them as bigint, which serializes as a string when returned via a JSON object