Ability to embed spec file

Any chance you would be open to supporting an API spec which is embedded?  Would simplify the distribution of code to users w/o them needing a current api spec.
import (
    "embed"
    mw "github.com/alexferl/echo-openapi"
    "github.com/labstack/echo/v4"
    "log"
)

//go:embed internal/api/gen/api.yaml
var apiSpec []byte

func main() {
    e := echo.New()

    e.Use(mw.OpenAPIFromBytes(apiSpec))
}

Released in v1.2.0.


Add timeouts to Ironic resources

Values are just off the top of my head, some of the 10 minute ones really generally take a matter of seconds (ports, allocations) as it's just database work on Ironic's side.  Nodes and deployments are what I worry about, as they could include cleaning, inspection, and deployment. Not sure what the upper bound on those could be


Web: Broken 'NB-feeds-header-user-image' image URL

User's default head image is not accessible. it's started with 'https'.

Why use http and not https? That means that folks on https will get a mixed content warning about loading insecure content on http.

If you resubmit this without the http change, I'll accept it. But I can't have http images being served to users over https.


feat: allow for SNAPCRAFT env vars to be passed

[x] I have read the contribution documentation for this project.
[x] I agree to follow the code of conduct that this project follows, as appropriate.
[x] The changes are appropriately documented (if applicable).
[x] The changes have sufficient test coverage (if applicable).
[x] The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:
Environment variables relating to snapcraft are not currently passed through to the spawned process that runs snapcraft. This PR passes through process.env before the package sets the local related environment variables.
This means that SNAPCRAFT_BUILD_ENVIRONMENT can be passed through to disable multipass builds of snap packages via snapcraft.

I've created my own package in the meantime which allows for environment variables like SNAPCRAFT_BUILD_ENVIRONMENT to be passed through: @davidwinter/electron-forge-maker-snap


Logic.zeroExtend should return this if width is the same as newWidth, and Swizzle optimization in SV generation

Describe the bug
When zero-extending a signal, if there's nothing to zero-extend, we can just immediately return this rather than go through a Swizzle.
Additionally, when Swizzle gets only one signal with width >0, it shouldn't still add the {} around it.
To Reproduce

Call zeroExtend on a Logic with the newWidth equal to the width.  Note that it creates a swizzle unnecessarily.
Swizzle two signals, one of which is 0-width, and observe generated SV to contain {} around the one remaining signal.

Expected behavior
No response
Actual behavior
No response
Additional: Dart SDK info
No response
Additional: pubspec.yaml
No response
Additional: Context
No response

Will work on this :)


Change site_metadata to an example little dataset

Just a reminder for myself.

And remove the site_metadata and tag_releases example datasets

Done.


Apply for membership

👋 Looking to become a member.

@fredjn welcome!

How many approvals are required to merge?

We don't have a format rule about approval for PRs.
We do recommend for new members to join working group meetings or the conversation on slack / github discussions https://github.com/cdfoundation/sig-events#new-members . Looking forward to your contributions!


Replace old reference to verse

Here’s one reference to verse which should likely be strings instead!

Coverage increased (+0.03%) to 97.214% when pulling ce6a2c6cfbfec79295920a2764a92731c822448e on ddfreyne:patch-1 into 41e1edeaa3b66d59e717b03de9a7bbaf4a05d484 on piotrmurach:master.

Thanks ❤


您好，我想问这种方法是通过训练代码对wsj02_mix里所有混合语音进行训练，再在测试代码里输入wsj02_mix里的一个混合语音得到该混合语音的分离结果吗？

Dual-Path-RNN belongs to the open-setting method, so the training set and test set of this method do not overlap (the speakers are not repeated). The separation process is to input the audio of the mix (mix voice belongs to WSJ0-2mix) to separate the audio of the two speakers.

还是有点没明白训练，测试，分离三者的关系，测试和分离是否是同一个步骤？
训练代码train_rnn.py输入的训练集语音是WSJ0-2mix里单个人说话的语音？分离语音的过程就是在测试代码dualrnn_test.py里吗？
分离输入的混合语音是WSJ0-2mix自带的，还是需要我们自己人工合成？

Testing and training are separate voices.
The training input is mixed speech (in general, we are talking about the mixed speech of two speakers).
For the pre-trained model, we can use dualrnn_test.py for speech separation.
The input mixed speech is synthesized manually. WSJ0-2mix is manually mixed through the WSJ0 data set.

首先WSJ0人工合成为混合的WSJ0-2mix，然后WSJ0-2mix 的一部分用于训练，一部分用于分离（两者不重叠）是这个意思吗？

You can understand that.

This problem occurs in deep learning, which may be related to data distribution.

The timeout is automatically closed.


Merging all knowledge graphs

We need a strategy for how we are going to leverage each of these different knowledge graphs. Some of them have nice category theory principles behind them (ie. type and data flow graphs) but others are somewhat ad hoc. The combination of the dataflow graph with the type graph seems to be a productive avenue for further research. But I am not sure how to preserve the precise semantics of each graph while productively combining them. Maybe category theory holds more answers here.

I agree. We need to think about whether it makes sense to combine them, and if we want to combine them, how/why/for what use cases (as the preferred answer may vary by use case). For the last deliverable, I handled schema unification from code + markdown in the extract script, but to integrate all the disparate pieces, we need a standard api, reasonable defaults upon ingestion in cases where the type (of either vertex, and/or the edge) is not known, and a strategy for asserting semantic <-> code links. This strategy should inform and be informed by a (revised) version of our original schema. Revisions are necessary to ensure relationships are functional if we decide to leverage category theory in the ways we have discussed.
It seems to me what might be helpful are collapsable levels of precision that could be interpreted/experienced by the end-user as filters on the graph.

@kuncao0228 has been working on merging text and variable names in PR #114


Figure Out Why Line:XY Turns White After Click

Guessing it has something to do with a :visited style.

@kscoulter love the GIF here, super helpful. Also really appreciate your brainpower on this aspect of our app!
Seems like other links also have this , which suggests that we can apply a global css style. Do you have a suggestion for what color we should change it to (maybe a black, a darker purple, or another color entirely?)
cc team design @eheintzelman @mebates

How about Navy blue? Also would love to incorporate an underline on hover. Good catch, thanks!

I'm going to give this one a go.

I'm happy to do this, but want to get the details straight.  So we want both nav links and body links to be navy blue after visited and underline on hover?

@AlexandraCasser yeah, go ahead and set that as the global style and we can scope it down from there if need be.


Support for themes, monkeytype and graphs

This PR adds multiple improvements:

New WPM graph (using guptarohit/asciigraph)

Solves #3

New filter for minimum word length
Added error on the empty list (can occur after min word length is used)
Support for languages/dictionaries from monkeytype (read from GitHub repo)

More words and different dictionaries, including code-related, doesn't produce sentences

Support for themes and overall ability to change colors of text, progress bar, and graph

I personally had an issue with default untyped text being unreadable, this fixes it and adds a bit of funk

Cheers :)

Whoaaa, dude! This is some great stuff.
Thank you so much, I'm going to take a look soon.

Let me know if you want to be added as a collaborator on this repository, happy to do so! :)

@robopuff Cool, sent an invite! Thanks for all the amazing work :)


Fixing provider keys load

Closes #144 and potentially other issues related to missing/mixed api keys
$ go run . -qk 'domain:\"google.com\"' -v -provider .\providers.yaml
...
quake] <IP_ADDRESS>:443
[quake] <IP_ADDRESS>:443
...

New Changes

quake does not have a single json format and responds with entirely different format if there is a error . we include such data in err

$  ./uncover  -qk 'domain:"\google.com\"'   -v

  __  ______  _________ _   _____  _____
 / / / / __ \/ ___/ __ \ | / / _ \/ ___/
/ /_/ / / / / /__/ /_/ / |/ /  __/ /
\__,_/_/ /_/\___/\____/|___/\___/_/

		projectdiscovery.io

[INF] Current uncover version v1.0.4-dev (dev)
[quake] [:RUNTIME] failed to decode quake response: map[code:q3015 data:map[] message:查询语句解析错误：domain:"\google.com\" meta:map[]] <- json: cannot unmarshal object into Go struct field Response.data of type []quake.responseData


Unknown WKB type 49

Hi!
I get this error and backtrace when I try requesting tiles from my mapzen tile server.
<IP_ADDRESS> - - [19/Feb/2016 15:13:17] "GET /all/15/9644/12322.json HTTP/1.1" 500 -
Traceback (most recent call last):
File "/Users/divya/Documents/oneconcern/Vector-tile-server/Mapzen/tileserver/tileserver/init.py", line 187, in call
response = self.handle_request(request)
File "/Users/divya/Documents/oneconcern/Vector-tile-server/Mapzen/tileserver/tileserver/init.py", line 283, in handle_request
[])
File "/usr/local/lib/python2.7/site-packages/tilequeue-0.7.1-py2.7.egg/tilequeue/process.py", line 323, in process_coord
feature_layers = _preprocess_data(feature_layers, shape_padded_bounds)
File "/usr/local/lib/python2.7/site-packages/tilequeue-0.7.1-py2.7.egg/tilequeue/process.py", line 26, in _preprocess_data
shape = loads(wkb)
File "/usr/local/lib/python2.7/site-packages/shapely/wkb.py", line 16, in loads
return reader.read(data)
File "/usr/local/lib/python2.7/site-packages/shapely/geos.py", line 427, in read
raise ReadingError("Could not create geometry because of errors "
ReadingError: Could not create geometry because of errors while reading input.
ParseException: Unknown WKB type 49
Why am I getting this? Does this mean something is wrong with my data?  I am using psql (PostgreSQL) 9.5.0 as my db.
Thanks!

Fixed it by selecting ST_AsBinary(geom) in the query.


[Chore] Look into github-action support to get JSDocs from the TS files to the README

There might be a way to get the JSDocs from the class to be automated into the README. We should look into how this can be automated.

I more recently started using typedoc and github pages, this might be the easiest out of the box way to get documentation into a readable format without much work.
Updating title to reflect this.


Hard to comply with the coding style - suggest clang_format

It's hard to comply to the coding style, a clang-format file would help at some points:
The "nearest" style actually seems something like
Language: Cpp
BasedOnStyle: Mozilla
AlignAfterOpenBracket: DontAlign
AlignOperands: false
AlignTrailingComments: false
AlwaysBreakAfterDefinitionReturnType: None
AlwaysBreakAfterReturnType: None
BinPackArguments: true
BinPackParameters: true
BraceWrapping:
  AfterClass: true
  AfterControlStatement: true
  AfterFunction: true
  AfterNamespace: true
  AfterStruct: true
  BeforeCatch: true
  BeforeElse: true
BreakBeforeBraces: Custom
BreakConstructorInitializers: AfterColon
ColumnLimit: 0
Cpp11BracedListStyle: true
MaxEmptyLinesToKeep: 1
SortIncludes: false

(Used whatstyle to analyze).
What do you think about adding some reasonable style format?

The current formatting style is quite consistent with itself. When in doubt, looking at the surrounding code and similar sections should help to clarify things. Although, having a format spec would ease code reviews, so I'll have a look.
What do you specifically find unreasonable regarding the current formatting style?

Yes, you're right. The formatting is consistent with itself - sorry for the bad explanation/misleading topic.
My problem was that I HAVE TO look at the surrounding code to adapt a foreign code style instead of just write code and let a (formatting) tool do it's job.
Just as an example: When do you write spaces with curly braces initializions?
=> std::string index_file {"index.html"};
You've to find another place with this kind of initializion... some people write
std::string index_file { "index.html" }; or
std::string index_file{"index.html"}; or
std::string index_file{ "index.html" };
Thats annoying extra work with big chance of doing styling wrong.
I couldn't tell you which form of the above example I would write intuitively as I don't really care - I think thats the job of a formatting tool.

I can see how a formatter would make things easier. I haven't had a chance to try out clang-format yet, but I still plan on checking it out.
Interestingly, the example you provided for how spaces are formatted with uniform initialization syntax, has the following surrounding lines:
// the public directory for serving static files
std::string public_dir {};

// default index filename for the public directory
std::string index_file {"index.html"};

// socket timeout
std::chrono::seconds timeout {10};

// serve static files from public directory
bool http_static {true};

// serve dynamic content
bool http_dynamic {true};

// upgrade http to websocket connection
bool websocket {true};

It was just an proposal and the example was the first that passed through my mind.
"I couldn't tell you which form of the above example I would write intuitively".


 I got back on thinking it was just a OS issue and somehow someway even windows decided it wouldn’t even install the program after also nearly exploding my entire desktop, then I ran it on my raspberry pi cluster and the same exact thing happend, I think you really need to add some sort of threading and fix this up ALOT let alone the compilation for the code takes for EVER, even I’ve written some pretty heafty personal modules and even AI GUI applications, however they didn’t use up every bit of my resources and take 6 minutes to compile at most they took 30 seconds. golang is a very very fast language however even I know it shouldn’t take this long for the environment or code to compile itself.
To Reproduce
started on parrot OS 64 and 32 BIT
Switched too windows to try again same issue
Switched to a raspberry pi cluster server same issue
switched to my laptop same issue
Environment:
gtk3 version: newest
go version: latest
os: Debian, Unix, Windows 10, Windows 11
other stuff:
PC SPECS:
CPU: Ryzen 7 3700X
GPU: X2 MSI 1050TI’s
Coo: ZXT KRaken X53
storage: 3 Samsung 970 evo SSD’d
** other **
I know it’s not my hardware since I can read everything that’s happening upon compiling and running the code, i tried fixing it myself with my own resources and debuggers but couldn’t find the issue
also I want to note if you take in the code from the example modules, toss it into a visual studio IDE with a golang server it will tell you that there is one bug in the script where the “ os “ module is imported but not used, when you get that on your screen and you find a way to fix it 12 other errors appear in the script where it needs os arguments, and when you run the compiled fixed code you get errors like “ argument is needed upon calling GTK.run “ or whatever the module is defined as.
Please fix this before you break google itself and make the go Lang developers eyes cry

Newer issue: completely destroyed my Linux system as well, my SSD doesn’t have my original parrot os system on it- I didn’t even know a module can do this 💀

The module does take a lot to compile the first times, you just have to wait...then the next times it compiles straight forward.

yeah ive read that hence why i said that IS NOT supposed to happen, as ive said ive written my own personal modules even AI with GO and when it takes that long to compile, and then crashes your entire computer to where it collapses the OS something is wrong in that code, more than just " wait " time

IS NOT supposed to happen

This module takes a lot to compile the first time and if you see the resource monitor you'll see that there's of bunch of "gcc" running while it compiles cuz it's basically building all GTK and its go bindings (if you check the source code there's a bunch of .h files that need to be compiled), after it finishes then you can build and run the examples or your own applications faster.

yes i saw that after my PC literally exploded a whole ass card, C is a very VERY flexible language, i feel if you guys truly were able to build the bindings for it and even modify the manager you can easily control the .h files and compress them i know alot of people spue " oh well 1000 files need to be seperate " but i know if someone whoever is in charge of the header files, c files, and even the bindings needs to change it before the amount of power it takes frys someones sockets or damages someones hardware, and if you arent the orgin developers for GTK you can take GTK's source code and compress the H files yourself ive had to do it hundreds of times because developers now adays just do NOT know how to operate or work around languages.

This is certainly the most idiotic thing I've read today.


TypeLoadException with latest version of the game

hi, I get a typeloadException with the latest version of the game

I disabled all other mods except this one

I'm also getting the same error with the recent game update (patch <IP_ADDRESS>26) and narrowed it down to MinerInfo.

I'm unfamiliar with the details of DSP modding, but based on the stack trace in the error I'm guessing the bug is somewhere around inpatch to UIVeinDetailNode._OnUpdate in https://github.com/brotchie/Quality-Mods-Program/blob/43792d84380923e5c889dc1d01b720095db88051/Miner-Info/MinerInfo.cs#L46

yup same error here


Error from AbstractRetrieval references

When getting the AbstractRetrieval for 2-s2.0-85028692635 and looking at the references, I get a TypeError. I think it is enough to add TypeError in except of line 20 of utils\parse_content.py".
s = scopus.AbstractRetrieval('2-s2.0-85028692635', view='FULL', refresh=True)

s.references
Traceback (most recent call last):

  File "<ipython-input-15-5705d616f366>", line 1, in <module>
    s.references

  File "C:\anaconda3\lib\site-packages\scopus\abstract_retrieval.py", line 383, in references
    items = listify(chained_get(self._json, path, []))

  File "C:\anaconda3\lib\site-packages\scopus\utils\parse_content.py", line 19, in chained_get
    container = container[key]

TypeError: 'NoneType' object is not subscriptable`

Hey @ste210 ,  scopus.AbstractRetrieval('2-s2.0-85028692635', view='FULL', refresh=True) runs fine for me. I'm guessing you're not a Scopus subscriber? Only subscribers can access the the "FULL" view for the abstract retrieval API (https://dev.elsevier.com/api_key_settings.html). Try using view="META" and see if that works for you.

I also don't get an error - s.references is simply empty?

Thank you guys, probably my fault.. need to update


Fix status_code_and_message interop test for C++.  Change run_interop_tests.py to run this test for C++ and Go.

This depends on grpc/grpc-go#747 and helps address grpc/grpc-go#742.

It looks like this test was actually implemented in C++ (see #2808), but it was only exercising the UnaryCall part, not the FullDuplexCall part (see https://github.com/grpc/grpc/blob/master/doc/interop-test-descriptions.md#status_code_and_message for details).  I have fixed the C++ test and changed run_interop_tests.py to run it, which means that this now helps address #1416.
@a11r to make sure I've done this right.

LGTM

Qi, now that the grpc-go change has been merged, this PR is also ready to merge.  I just need an approval from you.  Thanks!

LGTM to the py script.

@stanley-cheung, it looks like the PHP client is failing the status_code_and_message interop test when run against a Go server.  Go and C++ work fine with each other (in both directions), and PHP works fine against a C++ server, so I'm not sure what the problem is.  Any idea what's wrong here?  Thanks!


[Question] setting colours in assets/styles.scss does not show an effect

Hello,
I can't seem to get setting my own CSS colours to work. I did as you described and copied assets/styles.scss to my assets folder and edited it like this:
---
title: false
styles: true
---
$accentColour: #6cb1bf;
$headingColour: #00798d;
$linkColour: #6cb1bf;
$hoverColour: #00798d;
@import "alembic";

These colour changes don't go through to the generated site, though. Am I missing something?
I tested the styles.scss file on a fresh jekyll directory to make sure that none of my other changes are at fault. Same result.
I am using jekyll 4.1.1 with Ruby 2.7.0p0 on Ubuntu 20.04, alembic theme 4.0.0 from gem install. I added Gemfile and Gemfile.lock as .txt attachments.
Gemfile.txt
Gemfile.lock.txt
I would be very glad if you could have a look at this and help me find where I went wrong.
Many thanks for your theme, I like it a lot.

I found the solution myself: Under "Site performance settings", the documentation mentions that enabling inline CSS will switch off the parsing of assets/styles.scss. This is set by default in your example _config.yml, which I had copied and modified for my purposes. Setting css_inline to false let me use the styles.scss as I wanted.

Pleased you found the solution @Vidrax, closing issue 🙂


Support for "Expects" http header

It would be nice to have support for the Expect -> 100 Continue flow. This is specially important when we are doing uploads, since we will not need to transfer the whole data before we encounter a 401, for example.
A typical use-case would be a streaming upload, with the data coming from a client and proxied on-the-fly to our destination server. Requests would read the data from the input source socket only if the destination server had already sent the 100-Continue header. When we are dealing with S3, 401 errors are common, and if the data is not read we can retry the request.
Requests can check the request headers, and if it finds an "Expect" header it will wait for the 100 Continue response from the server. If it does not come, this error should flow to the caller in a way that it can distinguish a network problem from a failed expectation error.

I think this issue can now be characterised as "impossible without massive rewrite of httplib". For that reason, I want to close this down: having issues we cannot take action on is problematic.

If anyone needs a feature like this I ended up going with a patched httplib:
http://bugs.python.org/issue1346874

@edevil Id your patched httplib available anywhere for as a package?
BTW, Amazon S3 recommends using 100-continues: http://docs.aws.amazon.com/AmazonS3/latest/dev/RESTRedirect.html

@cancan101 Sorry, no. But you have the patch in the ticket: http://bugs.python.org/file26357/issue1346874-273.patch

This is how this is supported in the AWS s3 python cli:
https://github.com/boto/botocore/blob/develop/botocore/awsrequest.py#L57
This would be useful for OpenStack Swift for the same reasons it's useful for s3: you get  a 401 back before you've uploaded any data.  This prevents wasted (potentially large) uploads and allows you to retry if your input is a stream.

We're desperately trying to avoid further patching httplib. I highly recommend trying to make this enhancement upstream if OpenStack values it: that would make it much easier for us to backport that support to earlier versions.

upstream: ie httplib?

Correct. =)

Right, it would definitely be nice and clean to have it  in there.
The patch to httplib referenced above (http://bugs.python.org/issue1346874) has been up since 2005!
Have the requests folks had any luck in fixing functionality gaps by pushing stuff upstream?

Some, but it's not been as fast as we'd like in all cases. However, our only other option is to jettison httplib entirely, which is a bit excessive and puts a substantial maintenance burden on us. Where possible, working with upstream is the ideal thing to do.

There is a code which implements chunked sending [0]
Why don't we extend it to support 100-continue?
[0] https://github.com/kennethreitz/requests/blob/v2.11.1/requests/adapters.py#L434-L448

@redixin httplib never exposes a 100-continue to us. It's not a fully-fledged response per the RFC so we never see it. We can't extend code to support something if we never see it.

@sigmavirus24 what do you mean "never exposes"? We are sending data directly to socket, and then reading response [0]. We can read and write anything we want. This may be very simple patch, just few more lines and tests.
[0] https://github.com/kennethreitz/requests/blob/v2.11.1/requests/adapters.py#L434-L465

what do you mean "never exposes"?

httplib literally sees the 100 Continue come from the server and trashes it without letting its users see it.

We are sending data directly to socket

I can assure you that lowconn is not a socket. Requests does not ever touch a socket object. lowconn is an HTTPConnection from urllib3 which wraps an httplib.HTTPConnection which encapsulates a socket object eventually.

We can read and write anything we want. This may be very simple patch, just few more lines and tests.

I assure you that we can not.
Further, that particular section of code you are referring to is only conditionally used when the body is an iterator and we cannot determine the total length of the body.

We can read and write anything we want. This may be very simple patch, just few more lines and tests.

@redixin If you believe that to be true, show us the code. Write that patch, write those tests, demonstrate that it works. But currently anyone else who would write that code believes that it is a much more substantial patch than that, and is unwilling to contribute such a patch.

Are changes to the python 2.7.x  being entertained? I'm not doubting it needs to be done as a change in httplib, but it may be difficult as I understand. Is there a bug filed in python upstream for this?

nvm, found it, it's open! as referenced above, since 2005.
https://bugs.python.org/issue1346874

@jallirs to be clear, Python 2.7 will likely never see this and the earliest version of Python to see this would be in the 3.x series (3.7, 3.8, etc.) It's not something that would likely ever be backported.


New gem version release

Hi Parker,
Please, release new gem version to rubygems.org.
We need to use new aws-sdk 2.x
Thanks

@galetahub: I'm getting there. Object data access changed in aws-sdk-2, so I'm currently working through the file#read behavior. Once that is working I'll release the next version.

@galetahub: Please try using 1.0.0-rc.1 to evaluate using AWS-SDK v2.


Fixed typo in text

I want to ask you, why don't you just use Bahasa Indonesia as a whole? I mean come on, who uses Shopee and Tokopedia if not Indonesians?

@drepram don't know, didn't think about it, don't want to think about it. Keep hustlin' 💥

Bro this PR was from like a year ago lmao


Feature to search for users

Currently users can search for events and talks. I would like to be able to add the possibility to search for users to that. This will allow users to be able to look up talks for a speaker they notice on twitter and it will allow event organisers to be able to quickly navigate to the user profile of a speaker in order to see previous talks or events. My employer (@IbuildingsNL) has given me some time to implement this feature.
I'm happy to write the implementation of this feature, but I'm unsure about the design of the search page.  Adding a third column to the search page reduces the space each column gets on desktop and tablet views, making the summaries quite small. So far I've come up with two solutions:

Adding a third column for users without adjusting any other styles

Adding a third column for users and adjusting the event summary style slightly

I would like to know what you think of this feature in general and what design solution you think is best. Any other ideas or suggestions are appreciated as well 😄

Closing as I have now merged the PR's that you opened for this.  Thank you for your contribution


Fix lessons progress styles

Closes #1419
This PR updates .badge-pill-* to .bg-*. * = any color
Before:

After:

Thanks for catching these.


Support top function on measure querying

This top function is distinct from the approximate top_n strategy based on the pre-calculation. This feature leverages the query model totally to do ad-hoc top queries.

@lujiajing1126 please use this function to support top-n queries in OAP to implement the java client. The pre-defined version will be introduced in the next iteration.


Commandeer : New workflow to deploy the lambda function #261

Opening this issue to track Upstream PR work :
https://github.com/facebookexperimental/resctl-demo/pull/261

The above PR is updated with all comments addressed and has been merged. So we can close this issue.


Allow "no test" as well as "no tests"

Easier and less to remember. Do I have to say tests or just test?
Ticket: none
Changelog: none

Thank you for submitting a pull request! Maybe @olehermanse can review this?


Use different label for array/exclude widget

Fix #62440

@roblourens OK, think this is ready for review!

Fixed all. Should be good to go.


Publish to Hackage/Stackage

Hi, if this library is functional, how about publishing it to Hackage/Stackage?

Done! https://hackage.haskell.org/package/servant-openapi3-2.0.0


Do not keep correlated symbols as SymbolReferences

Take a look at the below query:
SELECT a, (SELECT a WHERE false) FROM (VALUES 1) t(a)

Output of it should be: 1, null (currently, this fails with Given correlated subquery is not supported)
Currently all the correlated symbols are stored in subquery plan as SymbolReference, this causes:

difficulties in understanding of subquery plan as most symbols are produced by children nodes or assignment expressions, but some come from the correlation and require special handling SIC!.
issues with symbol equivalence solving. Typically when correlation is added to subquery is wrapped in Projection assignment like expr -> a, then at some point UnaliasSymboReferences maps expr -> a and keep symbol reference equivalence that expr = a, then in every place where expr occurs a is inlined. At the end, there is no way to distinguish output of correlated subquery from correlation symbols (see above query). This relates to: https://github.com/prestodb/presto/pull/8435

@sopel39
I see two issues there:

Correlated symbols are used in different plan subtrees even though they are not the same instance at the end (after ApplyNode and LateralNode are resolved). UnaliasSymboReferences doesn't correctly work with such plan (see: https://github.com/prestodb/presto/issues/8471), but there might also be problems with PredicatePushdown
Correlated symbols don't have sources. They "appear" in a middle of a plan out of nowhere. Therefore special correlation handling leaks to unrelated optimizers (e.g: InlineProjections)

I think we need to address both issues. Here is the proposal:

ApplyNode#correlation and LateralJoinNode#correlation shouldn't be a list of symbols, but rather a mapping between input (left) symbols and correlated (right) symbols. This way we are sure that same symbol won't occur in different subtrees.
We should have a special plan node, e.g: ProjectCorrelations that would pass-through input symbols, but also produce correlations. Such node correctly provide correlated symbols to downstream nodes. This way we don't have to handle correlations in other optimizers.

Ref: https://github.com/prestodb/presto/issues/8459

Plan of attack

As discussed above we will create a Map<Symbol, Symbol> for ApplyNode and LateralNode , the key would be a symbol that we would propagate(a new symbol) through the sub query and the value would be the correlated symbol for this. So now we can ensure that the same symbol won't occur in different trees.
When we try to translate these LateralNode or ApplyNode to a corresponding JoinNode or other nodes we would resolve the new symbol which we created.

Any insights about this model ?
@kokosing , @sopel39 , @martint


Use esbuild for a smaller docker container

@LarsTheGlidingSquirrel This PR is ready for review now :smile:


No timeout in the RTU client async implementation

Hi, is there any way to enable timeout in the rtu async client in the tokio-modbus?
In the sync RTU client it is possible by using "sync::rtu::connect_slave_with_timeout", but i can't find any way to do that in the async mode. Any thougths about it?

https://docs.rs/futures/latest/futures/future/fn.select.html

Ready to use: https://docs.rs/futures-time/latest/futures_time/


rippleStrokeWidth not used in Stroken Ripple Type

@@ -79,8 +79,10 @@ public class RippleBackground extends RelativeLayout{
         if(rippleType==DEFAULT_FILL_TYPE){
             rippleStrokeWidth=0;
             paint.setStyle(Paint.Style.FILL);
-        }else
-        }else{
-            paint.setStrokeWidth(rippleStrokeWidth);
           paint.setStyle(Paint.Style.STROKE);
-        }
       paint.setColor(rippleColor);

Confirmed, I also spent time looking what I did wrong so the ripple is always 2dp but it seems that the issue is in the library.

hey do you have an update relating the stroke width issue?

@drorGlucome check out my modification
"-" means remove the  current line

Thank you for the answer.
So only way is to download the code modify and use as static lib?

Thank you for the answer.
So only way is to download the code modify and use as static lib?

yes


Fix the integration test of collect_list_reduction

Signed-off-by: sperlingxx<EMAIL_ADDRESS>Fixes #5240
test_collect_list_reductions failed non-local mode, because collect_list is non-deterministic. The order may vary during merging lists.

build


work?

Does it work on MAC? It does not work at all.

Ok, I know why it did not work. The web app must be in English.


Synthesis failed for java-monitoring-dashboards

Hello! Autosynth couldn't regenerate java-monitoring-dashboards. :broken_heart:
Here's the output from running synth.py:
Cloning into 'working_repo'...
Switched to a new branch 'autosynth'
Cloning into '/tmpfs/tmp/tmpkv19ec6f/googleapis'...
Cloning into '/tmpfs/tmp/tmpkv19ec6f/synthtool'...
Switched to branch 'autosynth-self'
Note: checking out 'b8bcf3377310a7622d04bebf2bf3dff710587192'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at b8bcf33 deps: update dependency com.google.api.grpc:proto-google-common-protos to v1.18.0 (#106)
Note: checking out 'b21bc9b46e3263cd4ebe50f60c61589e3fe797f2'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at b21bc9b4 chore: set Ruby namespace in proto options
Note: checking out 'f8a9933e5e98202b04ef427f28d1d79221190fa4'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at f8a9933 chore(java): allow overriding the versioning section of the Java README (#495)
Switched to a new branch 'autosynth-self-2'
2020-05-05 21:32:31 [INFO] Running synthtool
2020-05-05 21:32:31 [INFO] ['/tmpfs/src/github/synthtool/env/bin/python3', '-m', 'synthtool', '--metadata', 'synth.metadata', 'synth.py', '--']
2020-05-05 21:32:31,265 synthtool > Executing /tmpfs/src/github/synthtool/working_repo/synth.py.
On branch autosynth-self-2
nothing to commit, working tree clean
2020-05-05 21:32:31,396 synthtool > Ensuring dependencies.
2020-05-05 21:32:31,407 synthtool > Cloning googleapis.
2020-05-05 21:32:31,408 synthtool > Using precloned repo /tmpfs/tmp/tmpkv19ec6f/googleapis
2020-05-05 21:32:31,412 synthtool > Generating code for: //google/monitoring/dashboard/v1:google-cloud-monitoring-dashboard-v1-java.
2020-05-05 21:32:31,524 synthtool > Failed executing bazel build //google/monitoring/dashboard/v1:google-cloud-monitoring-dashboard-v1-java:

Starting local Bazel server and connecting to it...
Server crashed during startup. Now printing /home/kbuilder/.cache/bazel/_bazel_kbuilder/65dc30e0e399cedff83987bc9c02e9e6/server/jvm.out
OpenJDK 64-Bit Server VM warning: INFO: os::commit_memory(0x0000000715200000, 247463936, 0) failed; error='Not enough space' (errno=12)
#
# There is insufficient memory for the Java Runtime Environment to continue.
# Native memory allocation (mmap) failed to map 247463936 bytes for committing reserved memory.
# An error report file with more information is saved as:
# /tmpfs/tmp/tmpkv19ec6f/googleapis/hs_err_pid24585.log

2020-05-05 21:32:31,525 synthtool > Wrote metadata to synth.metadata.
Traceback (most recent call last):
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmpfs/src/github/synthtool/synthtool/__main__.py", line 102, in <module>
    main()
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/tmpfs/src/github/synthtool/synthtool/__main__.py", line 94, in main
    spec.loader.exec_module(synth_module)  # type: ignore
  File "<frozen importlib._bootstrap_external>", line 678, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/tmpfs/src/github/synthtool/working_repo/synth.py", line 35, in <module>
    bazel_target=f'//google/monitoring/dashboard/{version}:google-cloud-monitoring-dashboard-{version}-java',
  File "/tmpfs/src/github/synthtool/synthtool/languages/java.py", line 310, in bazel_library
    library = gapic.java_library(service=service, version=version, **kwargs)
  File "/tmpfs/src/github/synthtool/synthtool/gcp/gapic_bazel.py", line 63, in java_library
    return self._generate_code(service, version, "java", **kwargs)
  File "/tmpfs/src/github/synthtool/synthtool/gcp/gapic_bazel.py", line 177, in _generate_code
    shell.run(bazel_run_args)
  File "/tmpfs/src/github/synthtool/synthtool/shell.py", line 39, in run
    raise exc
  File "/tmpfs/src/github/synthtool/synthtool/shell.py", line 33, in run
    encoding="utf-8",
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/subprocess.py", line 438, in run
    output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['bazel', 'build', '//google/monitoring/dashboard/v1:google-cloud-monitoring-dashboard-v1-java']' returned non-zero exit status 37.
2020-05-05 21:32:31 [ERROR] Synthesis failed
HEAD is now at b8bcf33 deps: update dependency com.google.api.grpc:proto-google-common-protos to v1.18.0 (#106)
Switched to branch 'autosynth-self'
Note: checking out 'b8bcf3377310a7622d04bebf2bf3dff710587192'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at b8bcf33 deps: update dependency com.google.api.grpc:proto-google-common-protos to v1.18.0 (#106)
Previous HEAD position was b21bc9b4 chore: set Ruby namespace in proto options
HEAD is now at a3a0bf0f BREAKING_CHANGE: Removing TimeSeriesQueryLanguageCondition as an alert condition type. The condition type is unsupported and unused. It was originally added for the Monitoring Query Language Alpha feature. refactor!: Drop support for TimeSeriesQueryLanguageCondition as an alert condition type.
Previous HEAD position was f8a9933 chore(java): allow overriding the versioning section of the Java README (#495)
HEAD is now at ab88356 fix: make .kokoro-autosynth executable (#522)
Switched to a new branch 'autosynth-91'
2020-05-05 21:32:31 [INFO] Running synthtool
2020-05-05 21:32:31 [INFO] ['/tmpfs/src/github/synthtool/env/bin/python3', '-m', 'synthtool', '--metadata', 'synth.metadata', 'synth.py', '--']
2020-05-05 21:32:31,843 synthtool > Executing /tmpfs/src/github/synthtool/working_repo/synth.py.
On branch autosynth-91
nothing to commit, working tree clean
2020-05-05 21:32:31,975 synthtool > Ensuring dependencies.
2020-05-05 21:32:31,987 synthtool > Cloning googleapis.
2020-05-05 21:32:31,988 synthtool > Using precloned repo /tmpfs/tmp/tmpkv19ec6f/googleapis
2020-05-05 21:32:31,992 synthtool > Generating code for: //google/monitoring/dashboard/v1:google-cloud-monitoring-dashboard-v1-java.
2020-05-05 21:32:32,102 synthtool > Failed executing bazel build //google/monitoring/dashboard/v1:google-cloud-monitoring-dashboard-v1-java:

Starting local Bazel server and connecting to it...
Server crashed during startup. Now printing /home/kbuilder/.cache/bazel/_bazel_kbuilder/65dc30e0e399cedff83987bc9c02e9e6/server/jvm.out
OpenJDK 64-Bit Server VM warning: INFO: os::commit_memory(0x0000000715200000, 247463936, 0) failed; error='Not enough space' (errno=12)
#
# There is insufficient memory for the Java Runtime Environment to continue.
# Native memory allocation (mmap) failed to map 247463936 bytes for committing reserved memory.
# An error report file with more information is saved as:
# /tmpfs/tmp/tmpkv19ec6f/googleapis/hs_err_pid24620.log

2020-05-05 21:32:32,103 synthtool > Wrote metadata to synth.metadata.
Traceback (most recent call last):
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmpfs/src/github/synthtool/synthtool/__main__.py", line 102, in <module>
    main()
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/tmpfs/src/github/synthtool/synthtool/__main__.py", line 94, in main
    spec.loader.exec_module(synth_module)  # type: ignore
  File "<frozen importlib._bootstrap_external>", line 678, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/tmpfs/src/github/synthtool/working_repo/synth.py", line 35, in <module>
    bazel_target=f'//google/monitoring/dashboard/{version}:google-cloud-monitoring-dashboard-{version}-java',
  File "/tmpfs/src/github/synthtool/synthtool/languages/java.py", line 310, in bazel_library
    library = gapic.java_library(service=service, version=version, **kwargs)
  File "/tmpfs/src/github/synthtool/synthtool/gcp/gapic_bazel.py", line 63, in java_library
    return self._generate_code(service, version, "java", **kwargs)
  File "/tmpfs/src/github/synthtool/synthtool/gcp/gapic_bazel.py", line 177, in _generate_code
    shell.run(bazel_run_args)
  File "/tmpfs/src/github/synthtool/synthtool/shell.py", line 39, in run
    raise exc
  File "/tmpfs/src/github/synthtool/synthtool/shell.py", line 33, in run
    encoding="utf-8",
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/subprocess.py", line 438, in run
    output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['bazel', 'build', '//google/monitoring/dashboard/v1:google-cloud-monitoring-dashboard-v1-java']' returned non-zero exit status 37.
2020-05-05 21:32:32 [ERROR] Synthesis failed
HEAD is now at b8bcf33 deps: update dependency com.google.api.grpc:proto-google-common-protos to v1.18.0 (#106)
Switched to branch 'autosynth'
Traceback (most recent call last):
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 584, in <module>
    main()
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 465, in main
    return _inner_main(temp_dir)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 574, in _inner_main
    commit_count = synthesize_loop(x, multiple_prs, change_pusher, synthesizer)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 360, in synthesize_loop
    synthesize_inner_loop(toolbox, synthesizer)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 370, in synthesize_inner_loop
    synthesizer, len(toolbox.versions) - 1
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 259, in synthesize_version_in_new_branch
    synthesizer.synthesize(self.environ)
  File "/tmpfs/src/github/synthtool/autosynth/synthesizer.py", line 115, in synthesize
    synth_proc.check_returncode()  # Raise an exception.
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/subprocess.py", line 389, in check_returncode
    self.stderr)
subprocess.CalledProcessError: Command '['/tmpfs/src/github/synthtool/env/bin/python3', '-m', 'synthtool', '--metadata', 'synth.metadata', 'synth.py', '--']' returned non-zero exit status 1.

Google internal developers can see the full log here.

Autosynth is still having trouble generating java-monitoring-dashboards. :sob:
Here's the output from running synth.py:
Cloning into 'working_repo'...
Switched to a new branch 'autosynth'
Cloning into '/tmpfs/tmp/tmpe1hhw4be/googleapis'...
Cloning into '/tmpfs/tmp/tmpe1hhw4be/synthtool'...
Switched to branch 'autosynth-self'
Note: checking out 'b8bcf3377310a7622d04bebf2bf3dff710587192'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at b8bcf33 deps: update dependency com.google.api.grpc:proto-google-common-protos to v1.18.0 (#106)
Note: checking out 'b21bc9b46e3263cd4ebe50f60c61589e3fe797f2'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at b21bc9b4 chore: set Ruby namespace in proto options
Note: checking out 'f8a9933e5e98202b04ef427f28d1d79221190fa4'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at f8a9933 chore(java): allow overriding the versioning section of the Java README (#495)
Switched to a new branch 'autosynth-self-2'
2020-05-07 07:01:46 [INFO] Running synthtool
2020-05-07 07:01:46 [INFO] ['/tmpfs/src/github/synthtool/env/bin/python3', '-m', 'synthtool', '--metadata', 'synth.metadata', 'synth.py', '--']
2020-05-07 07:01:46,692 synthtool > Executing /tmpfs/src/github/synthtool/working_repo/synth.py.
On branch autosynth-self-2
nothing to commit, working tree clean
2020-05-07 07:01:46,822 synthtool > Ensuring dependencies.
2020-05-07 07:01:46,833 synthtool > Cloning googleapis.
2020-05-07 07:01:46,834 synthtool > Using precloned repo /tmpfs/tmp/tmpe1hhw4be/googleapis
2020-05-07 07:01:46,838 synthtool > Generating code for: //google/monitoring/dashboard/v1:google-cloud-monitoring-dashboard-v1-java.
2020-05-07 07:01:46,948 synthtool > Failed executing bazel build //google/monitoring/dashboard/v1:google-cloud-monitoring-dashboard-v1-java:

Starting local Bazel server and connecting to it...
Server crashed during startup. Now printing /home/kbuilder/.cache/bazel/_bazel_kbuilder/6e5fb9eb76c6117f9d770505a3dfcca7/server/jvm.out
OpenJDK 64-Bit Server VM warning: INFO: os::commit_memory(0x0000000715200000, 247463936, 0) failed; error='Not enough space' (errno=12)
#
# There is insufficient memory for the Java Runtime Environment to continue.
# Native memory allocation (mmap) failed to map 247463936 bytes for committing reserved memory.
# An error report file with more information is saved as:
# /tmpfs/tmp/tmpe1hhw4be/googleapis/hs_err_pid17708.log

2020-05-07 07:01:46,949 synthtool > Wrote metadata to synth.metadata.
Traceback (most recent call last):
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmpfs/src/github/synthtool/synthtool/__main__.py", line 102, in <module>
    main()
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/tmpfs/src/github/synthtool/synthtool/__main__.py", line 94, in main
    spec.loader.exec_module(synth_module)  # type: ignore
  File "<frozen importlib._bootstrap_external>", line 678, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/tmpfs/src/github/synthtool/working_repo/synth.py", line 35, in <module>
    bazel_target=f'//google/monitoring/dashboard/{version}:google-cloud-monitoring-dashboard-{version}-java',
  File "/tmpfs/src/github/synthtool/synthtool/languages/java.py", line 310, in bazel_library
    library = gapic.java_library(service=service, version=version, **kwargs)
  File "/tmpfs/src/github/synthtool/synthtool/gcp/gapic_bazel.py", line 63, in java_library
    return self._generate_code(service, version, "java", **kwargs)
  File "/tmpfs/src/github/synthtool/synthtool/gcp/gapic_bazel.py", line 177, in _generate_code
    shell.run(bazel_run_args)
  File "/tmpfs/src/github/synthtool/synthtool/shell.py", line 39, in run
    raise exc
  File "/tmpfs/src/github/synthtool/synthtool/shell.py", line 33, in run
    encoding="utf-8",
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/subprocess.py", line 438, in run
    output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['bazel', 'build', '//google/monitoring/dashboard/v1:google-cloud-monitoring-dashboard-v1-java']' returned non-zero exit status 37.
2020-05-07 07:01:46 [ERROR] Synthesis failed
HEAD is now at b8bcf33 deps: update dependency com.google.api.grpc:proto-google-common-protos to v1.18.0 (#106)
Switched to branch 'autosynth-self'
Note: checking out 'b8bcf3377310a7622d04bebf2bf3dff710587192'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at b8bcf33 deps: update dependency com.google.api.grpc:proto-google-common-protos to v1.18.0 (#106)
Previous HEAD position was b21bc9b4 chore: set Ruby namespace in proto options
HEAD is now at 2fc2caaa chore: enable gapic v2 and proto annotation for bigquery/storage/v1beta2 API.
Previous HEAD position was f8a9933 chore(java): allow overriding the versioning section of the Java README (#495)
HEAD is now at be74d3e build: do not fail builds on codecov errors (#528)
Switched to a new branch 'autosynth-99'
2020-05-07 07:01:47 [INFO] Running synthtool
2020-05-07 07:01:47 [INFO] ['/tmpfs/src/github/synthtool/env/bin/python3', '-m', 'synthtool', '--metadata', 'synth.metadata', 'synth.py', '--']
2020-05-07 07:01:47,265 synthtool > Executing /tmpfs/src/github/synthtool/working_repo/synth.py.
On branch autosynth-99
nothing to commit, working tree clean
2020-05-07 07:01:47,396 synthtool > Ensuring dependencies.
2020-05-07 07:01:47,408 synthtool > Cloning googleapis.
2020-05-07 07:01:47,409 synthtool > Using precloned repo /tmpfs/tmp/tmpe1hhw4be/googleapis
2020-05-07 07:01:47,413 synthtool > Generating code for: //google/monitoring/dashboard/v1:google-cloud-monitoring-dashboard-v1-java.
2020-05-07 07:01:47,523 synthtool > Failed executing bazel build //google/monitoring/dashboard/v1:google-cloud-monitoring-dashboard-v1-java:

Starting local Bazel server and connecting to it...
Server crashed during startup. Now printing /home/kbuilder/.cache/bazel/_bazel_kbuilder/6e5fb9eb76c6117f9d770505a3dfcca7/server/jvm.out
OpenJDK 64-Bit Server VM warning: INFO: os::commit_memory(0x0000000715200000, 247463936, 0) failed; error='Not enough space' (errno=12)
#
# There is insufficient memory for the Java Runtime Environment to continue.
# Native memory allocation (mmap) failed to map 247463936 bytes for committing reserved memory.
# An error report file with more information is saved as:
# /tmpfs/tmp/tmpe1hhw4be/googleapis/hs_err_pid17743.log

2020-05-07 07:01:47,524 synthtool > Wrote metadata to synth.metadata.
Traceback (most recent call last):
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmpfs/src/github/synthtool/synthtool/__main__.py", line 102, in <module>
    main()
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/tmpfs/src/github/synthtool/synthtool/__main__.py", line 94, in main
    spec.loader.exec_module(synth_module)  # type: ignore
  File "<frozen importlib._bootstrap_external>", line 678, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/tmpfs/src/github/synthtool/working_repo/synth.py", line 35, in <module>
    bazel_target=f'//google/monitoring/dashboard/{version}:google-cloud-monitoring-dashboard-{version}-java',
  File "/tmpfs/src/github/synthtool/synthtool/languages/java.py", line 310, in bazel_library
    library = gapic.java_library(service=service, version=version, **kwargs)
  File "/tmpfs/src/github/synthtool/synthtool/gcp/gapic_bazel.py", line 63, in java_library
    return self._generate_code(service, version, "java", **kwargs)
  File "/tmpfs/src/github/synthtool/synthtool/gcp/gapic_bazel.py", line 177, in _generate_code
    shell.run(bazel_run_args)
  File "/tmpfs/src/github/synthtool/synthtool/shell.py", line 39, in run
    raise exc
  File "/tmpfs/src/github/synthtool/synthtool/shell.py", line 33, in run
    encoding="utf-8",
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/subprocess.py", line 438, in run
    output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['bazel', 'build', '//google/monitoring/dashboard/v1:google-cloud-monitoring-dashboard-v1-java']' returned non-zero exit status 37.
2020-05-07 07:01:47 [ERROR] Synthesis failed
HEAD is now at b8bcf33 deps: update dependency com.google.api.grpc:proto-google-common-protos to v1.18.0 (#106)
Switched to branch 'autosynth'
Traceback (most recent call last):
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 584, in <module>
    main()
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 465, in main
    return _inner_main(temp_dir)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 574, in _inner_main
    commit_count = synthesize_loop(x, multiple_prs, change_pusher, synthesizer)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 360, in synthesize_loop
    synthesize_inner_loop(toolbox, synthesizer)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 370, in synthesize_inner_loop
    synthesizer, len(toolbox.versions) - 1
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 259, in synthesize_version_in_new_branch
    synthesizer.synthesize(self.environ)
  File "/tmpfs/src/github/synthtool/autosynth/synthesizer.py", line 115, in synthesize
    synth_proc.check_returncode()  # Raise an exception.
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/subprocess.py", line 389, in check_returncode
    self.stderr)
subprocess.CalledProcessError: Command '['/tmpfs/src/github/synthtool/env/bin/python3', '-m', 'synthtool', '--metadata', 'synth.metadata', 'synth.py', '--']' returned non-zero exit status 1.

Google internal developers can see the full log here.

Autosynth is still having trouble generating java-monitoring-dashboards. :sob:
Here's the output from running synth.py:
Cloning into 'working_repo'...
Switched to a new branch 'autosynth'
Cloning into '/tmpfs/tmp/tmpi09o2jep/googleapis'...
Cloning into '/tmpfs/tmp/tmpi09o2jep/synthtool'...
Switched to branch 'autosynth-self'
Note: checking out 'b8bcf3377310a7622d04bebf2bf3dff710587192'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at b8bcf33 deps: update dependency com.google.api.grpc:proto-google-common-protos to v1.18.0 (#106)
Note: checking out 'b21bc9b46e3263cd4ebe50f60c61589e3fe797f2'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at b21bc9b4 chore: set Ruby namespace in proto options
Note: checking out 'f8a9933e5e98202b04ef427f28d1d79221190fa4'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at f8a9933 chore(java): allow overriding the versioning section of the Java README (#495)
Switched to a new branch 'autosynth-self-2'
2020-05-08 03:27:41 [INFO] Running synthtool
2020-05-08 03:27:41 [INFO] ['/tmpfs/src/github/synthtool/env/bin/python3', '-m', 'synthtool', '--metadata', 'synth.metadata', 'synth.py', '--']
2020-05-08 03:27:41,244 synthtool > Executing /tmpfs/src/github/synthtool/working_repo/synth.py.
On branch autosynth-self-2
nothing to commit, working tree clean
2020-05-08 03:27:41,387 synthtool > Ensuring dependencies.
2020-05-08 03:27:41,397 synthtool > Cloning googleapis.
2020-05-08 03:27:41,398 synthtool > Using precloned repo /tmpfs/tmp/tmpi09o2jep/googleapis
2020-05-08 03:27:41,403 synthtool > Generating code for: //google/monitoring/dashboard/v1:google-cloud-monitoring-dashboard-v1-java.
2020-05-08 03:27:41,514 synthtool > Failed executing bazel build //google/monitoring/dashboard/v1:google-cloud-monitoring-dashboard-v1-java:

Starting local Bazel server and connecting to it...
Server crashed during startup. Now printing /home/kbuilder/.cache/bazel/_bazel_kbuilder/e5aa574f7927ea2e9ce543b2b9204a90/server/jvm.out
OpenJDK 64-Bit Server VM warning: INFO: os::commit_memory(0x0000000715200000, 247463936, 0) failed; error='Not enough space' (errno=12)
#
# There is insufficient memory for the Java Runtime Environment to continue.
# Native memory allocation (mmap) failed to map 247463936 bytes for committing reserved memory.
# An error report file with more information is saved as:
# /tmpfs/tmp/tmpi09o2jep/googleapis/hs_err_pid27302.log

2020-05-08 03:27:41,514 synthtool > Wrote metadata to synth.metadata.
Traceback (most recent call last):
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmpfs/src/github/synthtool/synthtool/__main__.py", line 102, in <module>
    main()
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/tmpfs/src/github/synthtool/synthtool/__main__.py", line 94, in main
    spec.loader.exec_module(synth_module)  # type: ignore
  File "<frozen importlib._bootstrap_external>", line 678, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/tmpfs/src/github/synthtool/working_repo/synth.py", line 35, in <module>
    bazel_target=f'//google/monitoring/dashboard/{version}:google-cloud-monitoring-dashboard-{version}-java',
  File "/tmpfs/src/github/synthtool/synthtool/languages/java.py", line 310, in bazel_library
    library = gapic.java_library(service=service, version=version, **kwargs)
  File "/tmpfs/src/github/synthtool/synthtool/gcp/gapic_bazel.py", line 63, in java_library
    return self._generate_code(service, version, "java", **kwargs)
  File "/tmpfs/src/github/synthtool/synthtool/gcp/gapic_bazel.py", line 177, in _generate_code
    shell.run(bazel_run_args)
  File "/tmpfs/src/github/synthtool/synthtool/shell.py", line 39, in run
    raise exc
  File "/tmpfs/src/github/synthtool/synthtool/shell.py", line 33, in run
    encoding="utf-8",
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/subprocess.py", line 438, in run
    output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['bazel', 'build', '//google/monitoring/dashboard/v1:google-cloud-monitoring-dashboard-v1-java']' returned non-zero exit status 37.
2020-05-08 03:27:41 [ERROR] Synthesis failed
HEAD is now at b8bcf33 deps: update dependency com.google.api.grpc:proto-google-common-protos to v1.18.0 (#106)
Switched to branch 'autosynth-self'
Note: checking out 'b8bcf3377310a7622d04bebf2bf3dff710587192'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at b8bcf33 deps: update dependency com.google.api.grpc:proto-google-common-protos to v1.18.0 (#106)
Previous HEAD position was b21bc9b4 chore: set Ruby namespace in proto options
HEAD is now at 83816bb3 Add kokoro-specific .bazelrc file with arguments specific only for kokoro environments. This is to fix autosynth builds when it tries building older commits.
Previous HEAD position was f8a9933 chore(java): allow overriding the versioning section of the Java README (#495)
HEAD is now at 4674113 build: use Bazel 3.0.0 for autosynth builds (#529)
Switched to a new branch 'autosynth-104'
2020-05-08 03:27:41 [INFO] Running synthtool
2020-05-08 03:27:41 [INFO] ['/tmpfs/src/github/synthtool/env/bin/python3', '-m', 'synthtool', '--metadata', 'synth.metadata', 'synth.py', '--']
2020-05-08 03:27:41,845 synthtool > Executing /tmpfs/src/github/synthtool/working_repo/synth.py.
On branch autosynth-104
nothing to commit, working tree clean
2020-05-08 03:27:41,982 synthtool > Ensuring dependencies.
2020-05-08 03:27:41,993 synthtool > Cloning googleapis.
2020-05-08 03:27:41,993 synthtool > Using precloned repo /tmpfs/tmp/tmpi09o2jep/googleapis
2020-05-08 03:27:41,997 synthtool > Generating code for: //google/monitoring/dashboard/v1:google-cloud-monitoring-dashboard-v1-java.
2020-05-08 03:27:42,107 synthtool > Failed executing bazel build //google/monitoring/dashboard/v1:google-cloud-monitoring-dashboard-v1-java:

Starting local Bazel server and connecting to it...
Server crashed during startup. Now printing /home/kbuilder/.cache/bazel/_bazel_kbuilder/e5aa574f7927ea2e9ce543b2b9204a90/server/jvm.out
OpenJDK 64-Bit Server VM warning: INFO: os::commit_memory(0x0000000715200000, 247463936, 0) failed; error='Not enough space' (errno=12)
#
# There is insufficient memory for the Java Runtime Environment to continue.
# Native memory allocation (mmap) failed to map 247463936 bytes for committing reserved memory.
# An error report file with more information is saved as:
# /tmpfs/tmp/tmpi09o2jep/googleapis/hs_err_pid27340.log

2020-05-08 03:27:42,108 synthtool > Wrote metadata to synth.metadata.
Traceback (most recent call last):
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmpfs/src/github/synthtool/synthtool/__main__.py", line 102, in <module>
    main()
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/tmpfs/src/github/synthtool/synthtool/__main__.py", line 94, in main
    spec.loader.exec_module(synth_module)  # type: ignore
  File "<frozen importlib._bootstrap_external>", line 678, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/tmpfs/src/github/synthtool/working_repo/synth.py", line 35, in <module>
    bazel_target=f'//google/monitoring/dashboard/{version}:google-cloud-monitoring-dashboard-{version}-java',
  File "/tmpfs/src/github/synthtool/synthtool/languages/java.py", line 310, in bazel_library
    library = gapic.java_library(service=service, version=version, **kwargs)
  File "/tmpfs/src/github/synthtool/synthtool/gcp/gapic_bazel.py", line 63, in java_library
    return self._generate_code(service, version, "java", **kwargs)
  File "/tmpfs/src/github/synthtool/synthtool/gcp/gapic_bazel.py", line 177, in _generate_code
    shell.run(bazel_run_args)
  File "/tmpfs/src/github/synthtool/synthtool/shell.py", line 39, in run
    raise exc
  File "/tmpfs/src/github/synthtool/synthtool/shell.py", line 33, in run
    encoding="utf-8",
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/subprocess.py", line 438, in run
    output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['bazel', 'build', '//google/monitoring/dashboard/v1:google-cloud-monitoring-dashboard-v1-java']' returned non-zero exit status 37.
2020-05-08 03:27:42 [ERROR] Synthesis failed
HEAD is now at b8bcf33 deps: update dependency com.google.api.grpc:proto-google-common-protos to v1.18.0 (#106)
Switched to branch 'autosynth'
Traceback (most recent call last):
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 584, in <module>
    main()
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 465, in main
    return _inner_main(temp_dir)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 574, in _inner_main
    commit_count = synthesize_loop(x, multiple_prs, change_pusher, synthesizer)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 360, in synthesize_loop
    synthesize_inner_loop(toolbox, synthesizer)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 370, in synthesize_inner_loop
    synthesizer, len(toolbox.versions) - 1
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 259, in synthesize_version_in_new_branch
    synthesizer.synthesize(self.environ)
  File "/tmpfs/src/github/synthtool/autosynth/synthesizer.py", line 115, in synthesize
    synth_proc.check_returncode()  # Raise an exception.
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/subprocess.py", line 389, in check_returncode
    self.stderr)
subprocess.CalledProcessError: Command '['/tmpfs/src/github/synthtool/env/bin/python3', '-m', 'synthtool', '--metadata', 'synth.metadata', 'synth.py', '--']' returned non-zero exit status 1.

Google internal developers can see the full log here.


Fixed css class for mirroring local video

Minor css change to match the css found in easyrtc.css

lgtm

merged @clayton13


Submesh::From::Boundary for nonconforming mesh

Right now, both the SubMesh and ParSubMesh constructors don't allow construction from an NC parent mesh (checked in the constructor). Upon first glance, I think that if the use case is From::Boundary and the boundary is an external one (all faces have elements only on one side) that this should work just fine. I just want to check my understanding here, and also if there is an easy way to check this for the user in the constructor that the boundary attributes are true external boundaries.
Pinging @jandrej @mlstowell as the experts, thanks!

I think what you are stating here is correct. Iff the SubMesh is extracted from a boundary, the conforming and non-conforming cases are equivalent.
I did not involve a constructor from NCMesh since this class is vastly different from the regular Mesh and unfortunately requires a separate implementation of SubMesh.

OK, makes sense. I am just testing out something like the following and it seems to work fine:
diff --git a/mesh/submesh/psubmesh.cpp b/mesh/submesh/psubmesh.cpp
index b316d8b41..2a0e264a6 100644
--- a/mesh/submesh/psubmesh.cpp
+++ b/mesh/submesh/psubmesh.cpp
@@ -38,10 +38,8 @@ ParSubMesh ParSubMesh::CreateFromBoundary(const ParMesh &parent,
 ParSubMesh::ParSubMesh(const ParMesh &parent, SubMesh::From from,
                        Array<int> &attributes) : parent_(parent), from_(from), attributes_(attributes)
 {
-   if (Nonconforming())
-   {
-      MFEM_ABORT("SubMesh does not support non-conforming meshes");
-   }
+   MFEM_VERIFY(from == SubMesh::From::Boundary || !Nonconforming(),
+               "ParSubMesh does not support non-conforming meshes with From::Domain");

    MyComm = parent.GetComm();
    NRanks = parent.GetNRanks();
diff --git a/mesh/submesh/submesh.cpp b/mesh/submesh/submesh.cpp
index ac2058c57..2620bfb0f 100644
--- a/mesh/submesh/submesh.cpp
+++ b/mesh/submesh/submesh.cpp
@@ -31,10 +31,8 @@ SubMesh SubMesh::CreateFromBoundary(const Mesh &parent,
 SubMesh::SubMesh(const Mesh &parent, From from,
                  Array<int> attributes) : parent_(parent), from_(from), attributes_(attributes)
 {
-   if (Nonconforming())
-   {
-      MFEM_ABORT("SubMesh does not support non-conforming meshes");
-   }
+   MFEM_VERIFY(from == From::Boundary || !Nonconforming(),
+               "SubMesh does not support non-conforming meshes with From::Domain");

    if (from == From::Domain)
    {

As you confirm, this works when the boundary is conforming, and fails in FinalizeTopology when a face is nonconforming (which never happens so long as the boundary is not internal to the domain).

I'm not that familiar with the restrictions of NCMesh, can the boundary not have non-conforming elements? In 3D you have quads on the boundary which you can happily refine in a non-conforming manner I thought.
There should be a way to check when From::Boundary tries to use an interior boundary. Simply going through the elements and verifying that there's only one face neighbor suffices.

See #3766 for a proposed solution.

Fixed in https://github.com/mfem/mfem/pull/4476 for exterior boundary and volume submeshes.


Can't pull docker image

 Failed to launch container: Failed to 'docker -H unix:///tmp/docker.sock pull registry.mydomain.com/work/app-web-test:7': exit status = exited with status 1 stderr = Error: image work/app-web-test:7 not found

Everytime I have to connect myself and pull the image with ssh.
Am I missing something ?
Marathon 0.11.1
Mesos 0.25
Docker version 1.8.2, build 0a8c2e3

@kopax Have you seen the documentation about using private docker registries?

Yes I did, I was using that on all my docker images.
"uris":  [
  "file:///etc/docker.tar.gz"
 ]

Then I noticed that it wasn't working at all. Where should be stored the docker.tar.gz ?

As you configured, put the file in the /etc/ directory.
This might be an authentication issue as most registries sending a not found if any authentication attempt does not succeed. (seen by docker-registry and artifactory).
You have to be sure the follwing things:

You to create a valid login configuration by using "docker login <your_registry_url>"
Now follow the documention to archive the configuration files
Put the archive / Tarball to a location that is readable by the marathon user
Repeat on all mesos slave nodes (if there are any)

Ok well it was me. Following the documentation made it work.


Crash when pressing copy in the JSON formatter when output is empty

Describe the bug
Clicking copy in the json formatter output when the output is empty will cause the app to crash.
To Reproduce
Steps to reproduce the behavior:

go to json formatter
clear input, if there is any
press copy
app crashes

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Configuration (please complete the following information):

OS & Version: Windows 10 19043.1237
Theme: both
DevToys app version [e.g <IP_ADDRESS>]

Additional context
Add any other context about the problem here.

Hi,
Thank you for sharing this feedback! I've been able to reproduce it easily. I will try to fix it this weekend. :)


Relax version requirements on administrate gem

The administrate v0.3.0 has been released.
And it depends on this branch in its Gemfile.
We have to relax version requirements in order to develop administrate.

@nickcharlton Would you review this PR?

Hi @meganemura!
It's looking good so far, but I'm waiting to hear back on which is the canonical fork of this so we can handle the release. I'll be in touch soon!

@nickcharlton
Thank you for replying.
Today I found that the latest bundler (>= 1.13.0) respected local version of the gem. (Ref).
With this feature, I could bundle install without any conflicts in development.
So please don't hurry. I wait for your progress.

Hi @meganemura!
I've now gotten access to the original repo, so I'm going to delete this fork and then migrate that over. By the time you read this, I suspect we'll have a release done, too!


Renovate patching plan

Summary
Setup a meeting to discuss Renovate patch management with the team and determine how we're going to manage updates and patch PRs.

Meeting has been setup for Feb 1 at 13:30 ET.


Full URLs in AS2 messages are problematic to ISLE

We're good linked data citizens and put full urls in our AS2 messages we emit to the queue.  Problem is, those URLs cause a lot of problems for ISLE.  Depending on how you configure Drupal, they'll often inject https instead of http URLs, which breaks the TLS termination the ISLE uses.  On top of that, the URLs use the public, forward facing domain of the site, which is at odds with Docker's notion of a private network for all containers that aren't exposed to the wider web.  When generating derivatives, containers on the backend network get front end URLs, which they cannot resolve.
We can either pluginize message generation to put appropriate URLs in place, or just stuff the data we need (nids, mids, tids, etc...) into the free-form JSON blob in the message.  Or we could just stop using AS2 and pick something simpler and NOT linked data-y.

I don't think this is an issue anymore.  Closing!


Not displaying date when this.state.date is changed

I have an application that has two datepicker fields for a start and an end of a date range. I have created a popup menu which allows the user to set some preset date range like the last 7 days last 30 days etc. This menu changes the value in the state held in the application and passed to DatePicker
Expected behavior
After using DatePicker to type in a new date and then using the menu to change the state for the date used by DatePicker the new value should be displayed by DatePicker
Actual behavior
The changed state date is not displayed.
Steps to reprodcue
Use the Component below. When it has started click in the date field and change the year to 12. Then click the button labelled "Set Date". The date displayed does not change but the display of this.state.date will show that it is set to 2018-01-01
import React from 'react'
import moment from 'moment'
import DatePicker from 'react-datepicker'
import 'react-datepicker/dist/react-datepicker.css'
export default class Test extends React.Component {
constructor(props) {
super(props)
this.state = {
date: moment("2018-01-25")
}
this.handleChange = this.handleChange.bind(this)
this.setDate = this.setDate.bind(this)
}
handleChange(date) {
// const formattedDate = moment(date).format('YYYY-MM-DD')
this.setState({date: date})
}
setDate() {
this.setState({date: moment("2018-01-01")})
}
render() {
console.log(this.state)
return (

{this.props.label}

Set Date

)
}
}

Hello,
You need to surround your JSX in code block markup so it will show up and not be escaped in the browser
That said there are several values to set like selected, value, format and so on, try different combinations until it works for you... one combination that works particularly well is selected with a customInput input box's value if you want to manage state on your own
~B

sad


Document changes to the default push rules

The .m.rule.invite_for_me was moved to a higher priority section. https://github.com/matrix-org/synapse/commit/ed3979df
The .m.rule.member_event was added to stop pushing for membership changes by default. https://github.com/matrix-org/synapse/commit/3b554bda

lgtm


Does FastAPI have to pin starlette?

First Check

[X] I added a very descriptive title to this issue.
[X] I used the GitHub search to find a similar issue and didn't find it.
[X] I searched the FastAPI documentation, with the integrated search.
[X] I already searched in Google "How to X in FastAPI" and didn't find any information.
[X] I already read and followed all the tutorial in the docs and didn't find an answer.
[X] I already checked if it is not related to FastAPI but to Pydantic.
[X] I already checked if it is not related to FastAPI but to Swagger UI.
[X] I already checked if it is not related to FastAPI but to ReDoc.

Commit to Help

[X] I commit to help with one of those options 👆

Example Code
from fastapi.testclient import TestClient

TestClient(app, headers={...})

Description
FastAPI re-exports starlette TestClient which seems to be an httpx.Client connected to the asgi app under test.
starlette has recently fixed the TestClient.__init__ to follow httpx.Client.__init__ so that the earlier accepts headers=... kwarg, just like the latter.
https://github.com/encode/starlette/pull/1966
starlette has made a release 0.23.0, but the latest FastAPI pins a specific version starlette==0.22.0
Thus, as a dev, I can't use the latest "features" or more like reasonable expectations for the TestClient.
A newcomer would read the docs / source code and would expect TestClient to accept headers kwarg and get confused why that's rejected.
Thus, the question: is there a reason to pin a specific version of starlette?
Operating System
Other
Operating System Details
An issue with any OS.
FastAPI Version
0.88.0
Python Version
3.10, etc.
Additional Context
No response

FastAPI is integrated quite closely with starlette, and unfortunately starlette doesn't use semantic versioning, so it's easy for a breaking starlette change to break FastAPI. The latest version of starlette does this, for example

https://github.com/tiangolo/fastapi/discussions/2532
If Starlette released a change that FastAPI did not support and you did not pin the version every install would break and cause everyone to have to pin starlette which is not desirable.
Generally in library(which fastapi is) code you should pin your dependencies, or use a lock file to ensure that the library is getting a version of its dependencies that it is known to support. For a library having known working code for a specific version is more important than features.

I guess as long as both FastAPI and Starlette are in the 0.x.x series, we just have to live with that.
P.S. I kinda wish that FastAPI at least would graduate, because SemVer has a gotcha for 0.x.x that most devs are not aware of. At least I was not and my peers were not.


Documentation for data size limit

Could you please provide details on data size limit on each key's value and number of children? Also, is there a way to limit the number of child keys fetched from a directory?

I'm getting a 413 from etcd with no body, but I can not find any docs for what the actual limit is.  Is it written down somewhere?

Another thread asking about this:

-I didnt find any documentation about what kinds of keys and values does etcd store ?
-if i am watching a etcd  directory, how many nodes at max can be present inside it, for it to be able to watch changes to contents of that directory
-what is max numbers of keys supported
-what is max size of value supported ?

https://groups.google.com/d/msg/etcd-dev/BbgMBBCEoaE/RGTmv53PAwAJ

Though this is closed, it seems to me that the maximum number of children keys under a path/dir is not given?


Added pattern migration guide to the change log

Ping @andralex @wilzbach

@CyberShadow Fixed

Looks nice, though it's a bit weird how it's using expressions without side effects as statements on their own, as if they mutate the string like the first example.

@CyberShadow I guess that's just part of understanding range code.
I've added a note just in case.

I guess that's just part of understanding range code.

Changelogs are one part of the website that people unfamiliar with D are likely to check, to see how the language is evolving in the present day. So I think we shouldn't be scarce on details there.
Better than a note, would be to simply assign them to a dummy variable.

This should be targeting stable now. Change the target branch via the GH UI and  locally you can use e.g. git rebase --onto upstream/stable

Won't be able to get back to this until Monday. Vacation awaits!

Thanks @MartinNowak for handling this.


Fix pipeline error

Make sure documentation is present before attempting to copy it.

test-utils pipline succeeded: https://dev.azure.com/azure-sdk/public/_build/results?buildId=964785&view=results

@weshaggard : Can you please have a look at this when you get a chance? This is blocking a PR from @maorleger

Merging this PR as it now has approval and a lot of PRs are being blocked on it


CORS issue all of a sudden

Hello.
I have been using your fantastic package for a month or so now with no problem, but for some reason I now seem to be getting a CORS error for all links.
Has something changed??
Cheers!
Dave

same

Yeah, I started getting the CORS errors as well. But they seem sporadic and hard to track down.
Maybe this is the problem: it looks like the heroku proxy server that @Dhaiwat10 uses is down. https://rlp-proxy.herokuapp.com/. He explains how the heroku server makes it all run here: https://github.com/Dhaiwat10/react-link-preview/issues/14#issuecomment-1059943257

Hey, like @ptenteromano said the public proxy probably got overloaded with too many requests. Highly suggest forking it and deploying your own!

i also getting cors error how can deal with any one have answer please help

I avoided using the proxy server altogether. You can pass in your own custom fetcher prop, which collects metadata from explicitly defined values. The explicitImgSrc is used as a fallback.
Look into the docs / source code for more information.
const metaData = [{
  title: ["Example Title"],
  description: ["Example description..."],
  image: "https://example.com/image.jpg",
  url: "https://example.com/article",
  siteName: ["Example Site"],
  hostname: "example.com"
}]; // I defined the elements as a MetaData type previously.

// Adapt the loader response to the LinkPreview component
async function adapter(url: string): Promise<MetaData> {
  const data = metaData.find((d) => d.url === url) as MetaData;
  return Promise.resolve(data);
}

const urlData = {
  url: "https://example.com/article",
 explicitImgSrc: "https://images.unsplash.com/this-is-optional"
}

Then in your component, you can call it:
  <LinkPreview
    height="100%"
    url={urlData.url}
    fetcher={adapter}
    explicitImageSrc={urlData.explicitImgSrc}
  />


Port ProcKami to new word library

The new word library is stable enough for use, and barring some breaking changes is mostly compatible with old code. All old code have been modified (slightly) to work with the new word library.

Related: https://github.com/sifive/StdLibKami/pull/43, https://github.com/sifive/FpuKami/pull/4, https://github.com/sifive/Kami/pull/79.


Time range in api urls to limit check results, Vagrant provisioning fixes

Coverage increased (+0.1%) to 96.008% when pulling 305925a5c86e67eec3d27e8e16b5e1e41060da09 on MAAS-1967 into 102ac8f0f52236af1fd5b06a1f738638d88ca0ec on develop.

🌚

Coverage increased (+0.1%) to 96.008% when pulling eb70fca7455c7ea4723c78ec77cb00efcdf4da12 on MAAS-1967 into 102ac8f0f52236af1fd5b06a1f738638d88ca0ec on develop.


PHS as a backup

The Azure Active Directory Connect Documentation links to this page when describing using PHS as a backup to federation in the case of a federation failure.
https://docs.microsoft.com/en-us/azure/active-directory/hybrid/how-to-connect-install-custom#optional-features
There is no documentation that I can find on any specifics around the failover from federation to PHS in the case of a federation outage.  If that documentation exists, I'd like to see it linked on this page as well as the referrer page listed above.
Specifically, I'd like to have documented whether the failover is a automatic or manual and how long do we need to wait until any automatic failover happens (or how to manually failover).

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c900f942-4456-5238-9f4c-a7a5bd685c04
Version Independent ID: a5d7d971-765f-0977-f531-232ea5924121
Content: Implement password hash synchronization with Azure AD Connect sync
Content Source: articles/active-directory/hybrid/how-to-connect-password-hash-synchronization.md
Service: active-directory
GitHub Login: @billmath
Microsoft Alias: billmath

@grayjeremy
Thanks for your feedback! We will investigate and update as appropriate.

@grayjeremy Thank you for the feedback.  Yes you are correct.  I have a work item for this and I expect that we will have some documentation around it shortly (this coming month).  I am hoping to build on the federation tutorial (https://docs.microsoft.com/en-us/azure/active-directory/hybrid/tutorial-federation ).  At this point we can go ahead and close this and I will reopen it and let you know once we have the content in-place.  Thanks!

#please-close

Thanks, @billmath

Instructions for doing this already exist here, it just doesn't give any detail around how it knows that adfs is down (and whether I can do it manually at the start of a downtime window) or how long it will take to failover (manually or automatically).
I'm not sure the tutorial around federation is the right place to put the answer to those questions.  Tutorials seem more like 'how' documents that have links to other references explaining nuance.  Maybe a colored callout in the tutorial with a link to a sub-heading in Implement password hash synchronization with Azure AD Connect sync?  I've seen several incoming links to this document that lead me to believe this is the right place for it.
But, I recognize that I haven't read the new documentation and trust your judgement.  Thanks for all your help.

@grayjeremy Yes, I have made some head way on this but I had some issues when I attempted to re-enable my tenant for AD FS.  I believe this is just my tenant, as it has been used for a lot of different testing.  So I need to go through the steps with a clean tenant and verify it before publishing.  Because of the holidays, this may or may not get done this month because I have some time off I need to use.  This tutorial is just showing you step-by-step and builds off the federation one.  As for general guidance on using this, I have a high-availability doc for Azure AD Connect I am working on but this won't be available till sometime first quarter next year.  But to let you know, that switching over to PHS from AD FS is manual, unfortunately there is no automatic failover because you need to run some PShell against your tenant.  I will updated this again once the tutorial is live and keep you posted on the high-availability doc.  Feel free to ping me if you haven't heard as I can get busy.  Thanks!


Remove usage of Session from adapter

Description
This is the first step in removing Session from the execution layer/adapter.
It actually gets rid of Session entirely, however more work is planned to rework how the VM is using the traits from the adapter (specifically storage traits).
This is in its own version so we can commit without worrying too much about minor changes in behavior. FWIW I tested on a node syncing from when latest was introduced and it seems to work fine anyway.
However a couple of changes are coming around publishing that will need a protocol config so versioning the execution layer is a good step in that direction.
Please notice that this is a "copy" from #13000 and the massive change is just due to the copy of the execution layer
Test Plan
Existing tests. Will add more related to changes to publishing

If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)

[ ] protocol change
[ ] user-visible impact
[ ] breaking change for a client SDKs
[ ] breaking change for FNs (FN binary must upgrade)
[ ] breaking change for validators or node operators (must upgrade binaries)
[ ] breaking change for on-chain data layout
[ ] necessitate either a data wipe or data migration

Release notes

ok this is a bit crazy but I am not sure what to do. I am not sure if there is a good way to diff the changes against latest (@amnn).
Also looking for suggestion on how to make more changes in this PR and show what they are as opposed to see the entire mess

changed rem_sess to rem-sess so cargo is happy, few more things to fix though

also for context, maybe I should dump this PR and any execution version change should follow those steps:
1- create the version with no changes at all. That will be likely just trusting the PR but it would be a PR that all it does is to create a copy (the massive PR)
2- add changes as PR stacked on top of that
3- squash and merge
thoughts?
happy to dump this in favor of the other model....

Yes, what you've suggested in your follow-up is what I would do, roughly: Create the cut in its own PR and then make changes on top of that.
I would also not squash the changes into the cut PR when landing, because then you'll have the same problem in identifying what actually changed when looking at the commit history.

I am going to make the different steps as outlined above, closing this


Dart2JS optimizations for "is" follow Dart 1 semantics

Simple reproduction case:
void main(dynamic maybeAString) {
  giveMeAString(maybeAString as String);
}

void giveMeAString(String x) {
  if (x is String) {
    print('I am a String');
  }
  // Disable inlining.
  return null;
  return null;
}

... emits ...
{
  main: function(maybeAString) {
    F.giveMeAString(H.stringTypeCast(maybeAString));
  },
  giveMeAString: function(x) {
    if (typeof x === "string")
    // ^^^^^^^^^^^^^^^^^^^^^^^
    // This check could be lowered to, say, x != null.
      H.printString("I am a String");
    return;
  }
}

This is more apparent when you use non-native types:
void main(dynamic maybeAInterface) {
  maybeAInterface ??= Interface();
  giveMeAInterface(maybeAInterface as Interface);
}

void giveMeAInterface(Interface x) {
  if (x is Interface) {
    print('I am a Interface');
  }
  // Disable inlining.
  return null;
  return null;
}

class Interface {}

... emits ...
{
  main: function(maybeAInterface) {
  F.giveMeAInterface(H.interceptedTypeCast(maybeAInterface == null ? new F.Interface() :
    maybeAInterface, "$isInterface"));
  },
  giveMeAInterface: function(x) {
    if (x instanceof F.Interface)
      H.printString("I am a Interface");
    return;
  },
  Interface: {
    "^": "Object;"
  }
}

Are you saying that an incorrect Dart 1 semantics is being followed, or that there is a potential to optimize tests to something cheaper in Dart 2?
I think we would benefit from reducing the is-test for user defined classes to a null check, but we should keep the typeof tests if the tested value is used in the code controlled by the 'if', since some JavaScript engines can do more with that.

P.S. The correct way to write
foo() {
  ...
  // Disable inlining.
  return null;
  return null;
}

is
@pragma('dart2js:noInline')
foo() {
   ...
}

We make no guarantee that the two-returns version will keep working.

Thanks!


delegation does not work

roles that use delegation will fail with ansible-bender out of the box probably due to ansible-bender not using the default inventory. This is something the user should be aware of.
I'm not sure where and how this should be mentioned in the docu or if there are workarounds for that problem and how they'd look like (it can certainly be hacked somehow...).
I'd propose a section in the  README.md after the "Features" section:
### Gotchas

Since ansible-bender is creating its own inventory at runtime, roles that use `delegate_to:` will probably fail to work as intended.

I'd suggest to add the same section to the document front page right after the "Features" section.
What do you think of this?

hi Tome, thank you for your time opening this issue
I recall there was also some other issue related to roles that make them not work correctly - this is indeed something that should be fixed or even improved; starting with mentioning this in the readme sounds like a great start. If you have time, please open such PR and I'd be glad to merge it.


Common library/configuration

https://stackoverflow.com/questions/44718763/how-to-inherit-application-properties-in-spring

https://vladmihalcea.com/spring-boot-application-properties/