[SPARK-23357][CORE] 'SHOW TABLE EXTENDED LIKE pattern=STRING' add ‘Partitioned’ display similar to hive, and partition is empty, also need to show empty partition field []

What changes were proposed in this pull request?
Use 'SHOW TABLE EXTENDED LIKE pattern=STRING' command in spark-sql client,add ‘Partitioned’  display similar to hive, and if the partition is empty, also need to show empty partition field []
hive:

sparkSQL Non-partitioned table fix before:

sparkSQL partitioned table fix before:

sparkSQL Non-partitioned table fix after:

sparkSQL partitioned table fix after:

How was this patch tested?
manual tests
Please review http://spark.apache.org/contributing.html before opening a pull request.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@gatorsmile
Help to review the code.

Personally I don't think it add any value to tell whether a table is partitioned, but I don't feel strong on this.

Oh, I just think it adds to make it clearer.

Can one of the admins verify this patch?


Upgrade to linux4.4 for RPI

This is kernel upgrade to v4.4 for raspberrypi
[GDP-152] Upgrade kernel and mesa for rpi2

This commit should be merged with https://github.com/GENIVI/genivi-dev-platform/pull/6.
@jonathanmaw
The audio problem fixed. Please review again.
Thanks

Tested, and audiomanager works properly now.


Cannot open message center after upgrade from SDK 1.7 => 3.0

Xcode 7.3
iPhone 6 Plus / iOS 9.3.1
My old app Version: Apptentive iOS SDK 1.7
My new app Version: Apptentive iOS SDK 3.0
Steps:

Install and launch old app version (currently live, from App Store)
Update with new app version (debug version via Xcode)
Launch new app, wait 20 sec
Console shows "[error] Activity feed result is not NSDictionary!"
Open message center => Error "We’re attempting to connect. Thanks for your patience!"

There's definitely a bug, in that the "[error] Activity feed result is not NSDictionary!" should not be displayed (it's a normal consequence of a PUT request to the endpoint that notifies us that the app and/or SDK has been updated, which returns 204 and an empty response rather than JSON). We will get this fixed in the next release.
That message should be followed closely by "Received remote Interactions from Apptentive." in the log. It's possible that you happened to test it when our API server was under an unusual amount of load, and that the remote interactions request was taking longer than it normally would. If you relaunch the app, the interactions should download normally within the first 30 seconds or so of runtime.
Let me know if this continues to be a problem and I'll investigate further.

Same error here
iPhone 6, iOS 9.3.1, Apptentive SDK 2.1.3
But on iPhone 5, iOS 9.3.1, Apptentive SDK 2.1.3 working
Both devices are with the same app version from App store
Updated apptentive SDK to 3.0.0, same situation
It stopped to work on iPhone 6 around month ago

After some more investigation, it looks like this is a problem on our server. There are multiple API requests made at startup and this upgrade exposed a race condition in one of them.
We have a patch live that should address this on our server. If you're still seeing the issue, please let us know/reopen the issue.


Popgun API: Reposition

You can ignore the exampleApp.ts.. Looks like my sublime reformatted the tabs to spaces..
But I added an API call where a dev can call reposition on a groupId and it'll reposition the associated pop. :)

LGTM!


Qualify path for util.h to avoid conflicts with other SDK's

Qualifying the path to util.h in the templates.  Certain micro-controllers SDK's also have their own util.h.  Qualifying the path avoids conflict between them.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Issues with Mac binaries

What is wrong?
Some Mac machines can't run our produced binaries:
Binary: https://github.com/g-r-a-n-t/fe/releases/download/v_test_3/fe_mac
Error on MacOS 10.12.6

Error on MacOS 10.13.6

How can it be fixed
:shrug:

This has been resolved


"cayley http --dbpath=30kmoviedata.nq.gz" run on Windows failed

When I run "cayley http --dbpath=30kmoviedata.nq.gz" on my Windows(8.1 x64), whether start from common cmd or administrator cmd, it give me the same error as belows ("cayley repl --dbpath=30kmoviedata.nq.gz" no problem)
D:\Program_Files\cayley_0.4.0_windows_amd64>cayley repl --dbpath=30kmoviedata.nq.gz
creating new history file: ".cayley_history"
cayley>
D:\Program_Files\cayley_0.4.0_windows_amd64>
D:\Program_Files\cayley_0.4.0_windows_amd64>cayley http --dbpath=30kmoviedata.nq.gz
Cayley now listening on <IP_ADDRESS>:64210
F0107 16:30:03.649552 13808 http.go:150] ListenAndServe: listen tcp <IP_ADDRESS>:64210: bind: An attempt was made to access a socket in a way forbidden by its access permissions.
goroutine 16 [running]:
github.com/barakmich/glog.stacks(0xc082035d00, 0x0, 0x0, 0x0)
/home/barak/src/cayley/src/github.com/barakmich/glog/glog.go:810 +0xd3
github.com/barakmich/glog.(*loggingT).output(0xfda9a0, 0xc000000003, 0xc08200c0c0)
/home/barak/src/cayley/src/github.com/barakmich/glog/glog.go:761 +0x47b
github.com/barakmich/glog.(*loggingT).print(0xfda9a0, 0x3, 0xc082055ce8, 0x2, 0x2)
/home/barak/src/cayley/src/github.com/barakmich/glog/glog.go:686 +0x169
github.com/barakmich/glog.Fatal(0xc082055ce8, 0x2, 0x2)
/home/barak/src/cayley/src/github.com/barakmich/glog/glog.go:1103 +0x57
github.com/google/cayley/http.Serve(0xc082005380, 0xc08204c000)
/home/barak/src/cayley/src/github.com/google/cayley/http/http.go:150 +0x44e
main.main()
/home/barak/src/cayley/src/github.com/google/cayley/cayley.go:245 +0x967
D:\Program_Files\cayley_0.4.0_windows_amd64>
D:\Program_Files\cayley_0.4.0_windows_amd64>
Even I built from source and then run show me the similary error like the following
C:\Users\Liu.D.H\go\bin>cayley http --dbpath=30kmoviedata.nq.gz
Cayley now listening on <IP_ADDRESS>:64210
F0107 16:28:28.542981 13596 http.go:145] ListenAndServe: listen tcp <IP_ADDRESS>:64210: bind: An attempt was made to access a socket in a way forbidden by its access permissions.
goroutine 1 [running]:
github.com/barakmich/glog.stacks(0xc08202bb00, 0x0, 0x0, 0x0)
C:/Users/Liu.D.H/go/src/github.com/barakmich/glog/glog.go:810 +0xd4
github.com/barakmich/glog.(*loggingT).output(0xff7d80, 0xc000000003, 0xc08200a0c0)
C:/Users/Liu.D.H/go/src/github.com/barakmich/glog/glog.go:761 +0x48c
github.com/barakmich/glog.(*loggingT).print(0xff7d80, 0xc000000003, 0xc0863f9d50, 0x2, 0x2)
C:/Users/Liu.D.H/go/src/github.com/barakmich/glog/glog.go:686 +0x183
github.com/barakmich/glog.Fatal(0xc0863f9d50, 0x2, 0x2)
C:/Users/Liu.D.H/go/src/github.com/barakmich/glog/glog.go:1103 +0x57
github.com/google/cayley/http.Serve(0xc082002b00, 0xc08205c280)
C:/Users/Liu.D.H/go/src/github.com/google/cayley/http/http.go:145 +0x591
main.main()
C:/Users/Liu.D.H/go/src/github.com/google/cayley/cayley.go:245 +0xb10
C:\Users\Liu.D.H\go\bin>

That error message vaguely indicates the sock was blocked/denied (or in use). Do you have a firewall or an antivirus running that's possibly blocking it?

When I tried again, it worked without that problem.
ds's answser is correct. Maybe it is because my firewall or antivirus issue.
Thanks!


Enhance mountAndCheckA11Y

@aigoncharov I just merged Link. Can you update it too?

@danad02 it is for the feat/tooltip branch. We'll have to update it there if we decide to go with this approach.


fix transport to branch

mt_transport_objects is per object
sometimes not all files for the object is changed, so ignore where lstate is initial

Do the unit tests pass after this change?

did not check, sorry


clangd not recognizing std::size() from #include  header

I just ran into a weird problem where clangd does not recognize std::size() (squiggle under it). I included iterator and the code compiles and runs just fine, so I have no idea why clangd does this. The error is: "No member named 'size' in namespace 'std' clang(no_member)"
i'm using c++ 17 in my compile_commands.json file as a compiler flag. I'm using  the "Cmake Tools" extension for vscode. I'm also using the C/C++ extension for vscode by Microsoft, but I turned off all intellisense and autocompletion features so I can use clangd.
The code is really simple and was used to just test this:

System information
Output of clangd --version: 10.0.0
Editor/LSP plugin: vscode-clangd
Operating system: MacOS Mojave

how did you generate your compile_commands.json file and can you post the command entry in the DB for this main.cpp file?

After a few hours of trying all kinds of things and getting some hints on the clangd discord channel, I solved this issue.
If you choose "clang-10.0.1" as your compiler kit for Cmake-Tools in vscode, it uses the command  "/usr/bin/clang++" to compile the code. This path works fine for compiling,  but not with clangd. Clangd picks up that path for the compiler from compile_commands.json and then can't find the stdlib headers.
When you change the compiler to "unspecified" in Cmake Tools, then Cmake Tools "guesses" the compiler path and uses "/Library/Developer/CommandLineTools/usr/bin/c++"  to compile. When clangd picks up that path from compile_commands.json everything works fine.  I think this should be published somewhere (e.g. in the vscode extension text but also on the clangd website) so people do not spend hours trying get clangd running properly in vscode (or with Cmake in general) and then give up.
Or...clangd needs to be able to use /usr/bin/clang++ ("/usr/bin/c++" etc)  to figure out where the path for all the standard headers is, which, of course is the better solution. By the way, I used both clangd 10.0.0 and 11.0.0-rc1 to test this. Both have this problem. This issue seems to be the same (starting with GianUlli's comment):
https://github.com/clangd/clangd/issues/97
And here the issue is closed, but it really isn't fixed:
https://github.com/clangd/clangd/issues/338
Like I said, this issue is still there in 11 rc-1

I encountered exactly the same problem on windows, have you got any solution?

After a few hours of trying all kinds of things and getting some hints on the clangd discord channel, I solved this issue.
If you choose "clang-10.0.1" as your compiler kit for Cmake-Tools in vscode, it uses the command "/usr/bin/clang++" to compile the code. This path works fine for compiling, but not with clangd. Clangd picks up that path for the compiler from compile_commands.json and then can't find the stdlib headers. When you change the compiler to "unspecified" in Cmake Tools, then Cmake Tools "guesses" the compiler path and uses "/Library/Developer/CommandLineTools/usr/bin/c++" to compile. When clangd picks up that path from compile_commands.json everything works fine. I think this should be published somewhere (e.g. in the vscode extension text but also on the clangd website) so people do not spend hours trying get clangd running properly in vscode (or with Cmake in general) and then give up.
Or...clangd needs to be able to use /usr/bin/clang++ ("/usr/bin/c++" etc) to figure out where the path for all the standard headers is, which, of course is the better solution. By the way, I used both clangd 10.0.0 and 11.0.0-rc1 to test this. Both have this problem. This issue seems to be the same (starting with GianUlli's comment):
#97
And here the issue is closed, but it really isn't fixed:
#338
Like I said, this issue is still there in 11 rc-1

@mustiboost very impressive notes, any update on this issue?

See https://clangd.llvm.org/troubleshooting#cant-find-standard-library-headers-map-stdioh-etc for general guidance on how to get clangd to find the right standard library headers.
In my experience, --query-driver is the most reliably option and what I would recommend.
If you'd like help with a specific problem, please post clangd logs.

I'm experencing std:string error in vsoce. pkgs is managed by cmake and vcpkg. i attached log and compile_commands.json.

it occurs to me that --query-driver was able to identify the arch.

not sure where's the problem
clangd.log
compile_commands.json

yeah, That not fixed. I attached clang log here.
clangd.log

Do you get the same error in a simple project with a file containing the following?
#include <string>

std::string my_string;

no, there's not:

I think there's something happening when clangd loading from compile_commands.json. As you can see glog cannot be included successfully. but in a other minimal test, clangd works fine with vcpkg:

i attached both compile_command, both have vcpkg_installed/arm64-osx/include through vcpkg
helloworld/compile_commands.json
colmap/compile_commands.json

Could you share a log from the minimal project where std::string is resolved correctly, to compare?

Could you share a log from the minimal project where std::string is resolved correctly, to compare?

yes, attached.
helloworld/clangd.log

Well, a notable difference is that in the working case, you are using the clangd shipped with XCode (/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clangd), and in the failing case you are using the clangd downloaded by the vscode-clangd plugin (/Users/lz/Library/Application Support/Code/User/globalStorage/llvm-vs-code-extensions.vscode-clangd/install/18.1.3/clangd_18.1.3/bin/clangd).
Can you try using the XCode clangd with your real project?
Or alternatively, can you try the minimal project with the vscode-downloaded clangd and if see if you get the same error?

i tried to use XCode clangd in the real project. but it wasnt a success.
i further tested to move the minimal hello world in to the ptoject. with the structure as:

noted that playground/helloworld.cc is found , while src/colmap/exe/helloworld.cc is failed. (both was good to be compiled in shell)

you can compare line 58 and 61, where the -isystem /Users/lz/Codes/github/colmap/build/vcpkg_installed/arm64-osx/include was missing.

compile_commands.json
clangd.log

There are two entries with "file": "/Users/lz/Codes/github/colmap/src/colmap/exe/helloworld.cc" in the compile_commands.json file.
The first one is:
{
  "directory": "/Users/lz/Codes/github/colmap/build",
  "command": "/usr/bin/clang++ -DCOLMAP_CGAL_ENABLED -DCOLMAP_GPU_ENABLED -DCOLMAP_GUI_ENABLED -DCOLMAP_LSD_ENABLED -DCOLMAP_OPENGL_ENABLED -DEIGEN_INITIALIZE_MATRICES_BY_NAN -DGLOG_VERSION_MAJOR=0 -DGLOG_VERSION_MINOR=7 -I/Users/lz/Codes/github/colmap/src -arch arm64 -g -std=gnu++17 -arch arm64 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.5.sdk -fPIC -o CMakeFiles/colmap_sources.dir/src/colmap/exe/helloworld.cc.o -c /Users/lz/Codes/github/colmap/src/colmap/exe/helloworld.cc",
  "file": "/Users/lz/Codes/github/colmap/src/colmap/exe/helloworld.cc",
  "output": "CMakeFiles/colmap_sources.dir/src/colmap/exe/helloworld.cc.o"
},

and it does not have the -isystem /Users/lz/Codes/github/colmap/build/vcpkg_installed/arm64-osx/include flag.


feat: TEC-1213: laying out images according to their aspect (slim/wide)

Adding a new component 'ArticleImage'.
This component models the images present in the article content (the interception and mapping between the img tags and the React component is done in blog-post.js in fe-blogs).
The image component set itself to 'normal' or 'slim' depending on the size information coming from the HTML tag attributes or (in their absence) from the natural width/height of the image itself.

:octopus: :rainbow: :dancer: Would merge, but I'm not assigned. Nice one, using chai-sinon. Looks a lot better than adding chai assertions to results of sinon assertions, and the API is super-familiar.

now you are :)
I promise, I can make it a lot better, but I prefer to add a note for a tech debt ticket since time is starting to run out!

f*ing "Close and comment" button!

I have some comments after all, found a couple of weird classname stuff.

right, I forgot to rationalize the class names and clean it up. Done. I've also taken the chance to clean up the tests.

Decimate


Refactor section: support reuse section in editing

support reuse section in editing

PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.


runtime: x86 CPU feature optimizations dropped in Go 1.17

CL 344329 caused the runtime to no longer detect POPCNT, SSE 4.1, or FMA support on amd64. This affects the performance of math/bits.OnesCount, math.FMA, and most of the rounding functions in math.
This CL was released as part of Go 1.17, so this may be worth a back-port, or maybe the risk is too high for not enough reward.
/cc @martisch

@gopherbot , please backport to Go 1.17.

This is fixed by CL 350151.

Sorry.
Why do we think this made it to go1.17? The CL that caused the regression was submitted August 23 after go1.18 tree open. I cant see that change in the go1.17 release branch: https://github.com/golang/go/blob/21a4e67ad58e3c4a7c5254f60cda5be5c3c450ff/src/runtime/proc.go#L637

Why do we think this made it to go1.17?

Sorry, I was mistaken about that.

Worth adding GOARCH/GOOS string constants somewhere?

Possibly. We already have goarch.ArchFamily and goarch.Is* constants, but the former is a bit of a mouthful and the latter are defined as 0/1 numeric constants, which are annoying to use in contexts like this. We also don't have an equivalent of goarch.ArchFamily for goos. Maybe we should just clean all of that up.


How do react-native version relate to react versions?

This is relevant for libraries (such as redux) that depend on specific versions of react (but don't publish react-native dependencies). Also, to know which API changes / improvements from react we're able to use.

Soon https://github.com/facebook/react-native/issues/2985

Currently it's running an RC of 0.14. In awhile we hope for RN to be using React from npm.

@ide, fwiw it's not running an RC. It's running 0.14-beta1 https://github.com/facebook/react/commit/b4e74e38e43ac53af8acd62c78c9213be0194245


Fix: Add type and return type declarations to seed()

This PR

[x] adds type and return type declarations to Faker\Generator::seed()
[x] cleans up underlying code

Fixes #1934.

Build failure is unrelated.

Closing in favor of #1894.


[BEAM-11403] Cache UnboundedReader per UnboundedSourceRestriction in SDF Wrapper DoFn.

I don't have a good setup to verify whether this really gives us an improvement. So if it looks good you, I can share it with folks who are active on the discussion thread to see whether it works.
r: @je-ik

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run Java PreCommit

One more concern - the current implementation relies on CheckpointMark#hashCode and CheckpointMark#equals. It is likely that these will not have these two correctly implemented. We should stick to Coder#structuralValue for that.

because it should be impossible for single DoFn instance to read from multiple readers.
Sorry, that is not true. Single instance can process multiple sources (after split). That seems problematic. Maybe we can ignore that, but that will probably cause issues with DirectRunner, because I think it can clone sources to simulate recovery from checkpoint.

One more concern - the current implementation relies on CheckpointMark#hashCode and CheckpointMark#equals. It is likely that these will not have these two correctly implemented. We should stick to Coder#structuralValue for that.
The same holds true for UnboundedSource#hashCode and equals, we should probably not use the source in the cache key, because it should be impossible for single DoFn instance to read from multiple readers.

I was thinking about using Coder#structuralValue but I'm concerning about the additional overhead from encoding. The cacheKey is created very frequently(at least twice per element) and it's not cheap for coder to encode a value.
As you mentioned, a DoFn instance could process multiple sources especially the source allows initial split(and we cannot assume that CheckpointMark contains the source info, although in most case it does), that's why I decided to use UnboundedSourceRestriction to locate a reader. DirectRunner is using timers(InMemoryTimerInternals) and states(in memory as well) to reschedule checkpoints. It should be a reference instead of a deep copy?

btw I tested it by using Kafka + Dataflow streaming and I don't notice a performance improvement there. It might be that the cost of creating Kafka connection is really cheap.

I was thinking about using Coder#structuralValue but I'm concerning about the additional overhead from encoding. The cacheKey is created very frequently(at least twice per element) and it's not cheap for coder to encode a value.

That should not be a problem as in most cases, processing a single element in this case means emitting quite many elements downstream. The cost of the structuralValue should be pretty much amortized I would say. We could do something to calculate it only once per element?

As you mentioned, a DoFn instance could process multiple sources especially the source allows initial split(and we cannot assume that CheckpointMark contains the source info, although in most case it does), that's why I decided to use UnboundedSourceRestriction to locate a reader. DirectRunner is using timers(InMemoryTimerInternals) and states(in memory as well) to reschedule checkpoints. It should be a reference instead of a deep copy?

I don't think we can use a reference either, because the UnboundedSource is Serializable and any runner is free to clone it (which is what DirectRunner does, afaik). The best solution would seem to be to mark each initially split (via @SplitRestriction) restriction with unique ID and then transfer this ID to all residual restrictions. There should be always be at most one "active" (either currently being processed or having non-null residual) restriction, so we could use that for identifying the reader without referencing Source (which might be problematic, as implementing hashCode and/or equals for UnboundedSource will not be a common practice, I'm afraid).

btw I tested it by using Kafka + Dataflow streaming and I don't notice a performance improvement there. It might be that the cost of creating Kafka connection is really cheap.

That doesn't seem to be a surpise, because under the current implementation, it is essential for CheckpointMark to correctly implement equals and hashCode (which KafkaCheckpointMark does not), because between two successive calls to processElement the checkpoint is stored in state and therefore serialized and deserialized and so a new object is put into the cache. Second point is that, even after we fix this, it will be probably noticeable only on pipelines with very frequent checkpoints.

btw I tested it by using Kafka + Dataflow streaming and I don't notice a performance improvement there. It might be that the cost of creating Kafka connection is really cheap.

That doesn't seem to be a surpise, because under the current implementation, it is essential for CheckpointMark to correctly implement equals and hashCode (which KafkaCheckpointMark does not), because between two successive calls to processElement the checkpoint is stored in state and therefore serialized and deserialized and so a new object is put into the cache.

I verified that the reader is reused from cache in Kafka case manually.

Second point is that, even after we fix this, it will be probably noticeable only on pipelines with very frequent checkpoints.

It makes me feel like configuring split frequency from PipelineOption or Read API still has value. If comparing the way between DirectRunner invokes Unbounded Read and Unbounded SDF, the checkpoint happens every 100 elements for Unbounded Read but almost every second for SDF. Besides, SDF uses timers and states to feed back checkpoint to process, which brings more overhead for processing.

I verified that the reader is reused from cache in Kafka case manually.

Hm, are you sure? That confuses me, because looking at the code, I'm not sure how that could function with System.identityHashCode as hashCode for CheckpointMark. Provided that AutoValue delegates its hashCode as would be expected and that guava's Cache uses hashCode. Hm, maybe Dataflow is not using SplittableDoFnViaKeyedWorkItems and has some specific implementation?

It makes me feel like configuring split frequency from PipelineOption

Sure, Flink has such an option. It would be natural to either create one for generic use, or add that to respective runner's PipelineOptions.

Hm, maybe Dataflow is not using SplittableDoFnViaKeyedWorkItems and has some specific implementation?

Ah, got that. Dataflow uses cache for state access. So writing to state and reading it back can return the same identical object. But that is runner specific. Flink always serializes access to state.

I verified that the reader is reused from cache in Kafka case manually.

Hm, are you sure? That confuses me, because looking at the code, I'm not sure how that could function with System.identityHashCode as hashCode for CheckpointMark. Provided that AutoValue delegates its hashCode as would be expected and that guava's Cache uses hashCode. Hm, maybe Dataflow is not using SplittableDoFnViaKeyedWorkItems and has some specific implementation?

All changes are in SDK side, as well as the cache creation, So it will be independent from runner executions(and I'm using beam_fn_api as well).
But you are right that hashCode is not correct if it is not implemented correctly.

It makes me feel like configuring split frequency from PipelineOption

Sure, Flink has such an option. It would be natural to either create one for generic use, or add that to respective runner's PipelineOptions.

The checkpoint for SDF is different from Flink checkpoint. That says, even the checkpoint interval is not configured for Flink, the checkpoint for SDF will still happen based on how OutputAndTimeBoundedSplittableProcessElementInvoker is configured.

I did more changes to address mentioned concerns, which include:

Have DoFn keep the Cache for all created RestrictionTracker
The RestrictionTracker#tryClaim will get the reader from the cache if any.
When RestrictionTracker#trySplit happens, the reader will be cached by the latest CheckpointMark.

I'll try to have a test tomorrow.

Great, I think this covers pretty much all the topics. I have only one small concern left - because the key in cache is derived from structuralValue of RestrictionCoder, it uses SerializableCoder for encoding the source. That might not be 100% stable. I would prefer to generate a different identifier in UnboundedSourceAsSDFWrapperFn.splitRestriction for each split and then carry it along all calls to trySplit. But this might be viewed as minor concern.

I would not worry about that too much since we are using Source + CheckpointMark as the restriction, as well as the cache key.

Can we add some simple test to verify this in ReadTest?

That's my plan. I'll let you know when it's ready.

Updated with test. @je-ik

Run Java_Examples_Dataflow PreCommit

Thanks for your quick review!

Note that this solution only caches the reader for the single DoFn instance and not across DoFn instances which is common when performing parallel processing.

UnboundedSource/CheckpointMark need to state that they have to implement equals() otherwise this caching is ineffective.

Why is equals()?

UnboundedSource/CheckpointMark need to state that they have to implement equals() otherwise this caching is ineffective.

Why is equals()?

Your right in that your correctly using structuralValue its just that UnboundedSource/CheckpointMark will use the SerializableCoder most of the time but this issue can be solved by users specifying the correct coder.


Cobertura output is platform-specific

See test failure here: https://github.com/microsoft/onefuzz/actions/runs/4747747016/jobs/8433055367?pr=3034
Filename parsing is dependent on platform.
AB#140613

I think this is actually fine since analysis will always be performed on the same platform that the data was generated upon. But it's something we should be aware of.

Closing now; this can be found by search as a "reference".


[EMB-16] Route dashboard to ember-osf-web with waffle

Needs
Devops(?) create the switch (or, if wanted a flag or sample) ember_dashboard for choosing whether to use the ember or the legacy version of the dashboard (which should be functionally similar)
Purpose
Use of ember to recreate the dashboard, rerouting to ember-osf-web when a user is logged in and the waffle switch (ember_dashboard) is active.
Changes
Add use of waffle switch for serving dashboard.
Serve ember-osf-web when a user goes to route / while logged in.
QA Notes
Test functionality of logged in dashboard, should be similar to current dashboard
Side Effects
/ will lead to the Ember-app
Ticket
https://openscience.atlassian.net/browse/EMB-16

Closing because PLAT-692 will supersede this.


UpdateBlocksActivation requires 1903?

This doc mentions that UpdateBlocksActivation is available from 1809, but some users report it only works from 1903.
https://github.com/microsoft/devops-for-windows-apps/issues/25#issuecomment-500182815
Please clarify

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0e69e20f-7cfc-aa28-85b8-f2deb8a69873
Version Independent ID: c3fffd4b-4405-c347-2db8-95c5c0928de5
Content: App Installer file update settings - MSIX
Content Source: msix-src/app-installer/update-settings.md
Product: msix
GitHub Login: @mcleanbyron
Microsoft Alias: mcleans

Thanks for pointing this out. UpdateBlocksActivation was added to the schema for 1809 but it turns out it isn't actually supported by AppInstaller at run time until 1903. I have updated the article.


Using images from the asset pipeline

It would be useful for a Tailwind + Rails integration to include a way to use images from the asset pipeline. As far as I know it's not possible to use asset-url in any of the locations relevant to tailwind:

In the application.tailwind.css as a custom utility: This half-works, as asset-url is put in the tailwind.css output file. However, the asset pipeline ignores it because it isn't processed. Maybe I can enable this somehow?
In the html.erb file as an 'arbitrary value'. This doesn't work because Tailwind classes need to be hardcoded for automatic purposes.
In the tailwind.config.js. Doesn't work because the file has no relation to the asset pipeline at all.

I feel like 1. should be the 'intended' solution. However, I don't have enough knowledge of neither Rails nor the asset pipeline to write a PR for this. If someone provides me with pointers I can try creating a PR that makes it work.
There are two workarounds. The first is putting your images in the public/assets folder. However that means throwing away the advantages of the asset pipeline, including fingerprinting of the images allowing long cache times. The second is maintaining a separate CSS file that is solely responsible for images. That's not ideal, because it's confusing why you would have two CSS outputs even though you're using Tailwind. And you can't use Tailwind's after:, before:, hover:, etc.
StackOverflow question asking the same thing: https://stackoverflow.com/questions/66842651/inserting-a-background-image-from-asset-pipeline-with-tailwind.

url() is rewritten automatically since https://github.com/rails/sprockets-rails/pull/476 👍

Awesome! I'll definitely answer the StackOverflow question with the solution. Do you think this should also be documented in the README of this project? Or is this something that will eventually be 'standard practice'?

I'd be happy seeing a note in the README about it 👍


Theme Configuration/Navigation menu - Dropdown menu won't open on the first click

There is something wrong with the down arrow when i press on the Blue (default). The first time i press on it the little arrow change direction and to get the dropdown menu to open i need to press a second time.

Authentic theme version 19.75
Firefox 88.0
Windows 10

There is something wrong with the down arrow

What browser and its version you're seeing this issue on?

Authentic theme version 19.75
Firefox 88.0
Windows 10

It is already in the first comment :)

This looks to me like unresolved Firefox bug - https://bugzilla.mozilla.org/show_bug.cgi?id=1475396
The fix was easy though. Thanks for reporting!

There still seems to be some issues with the arrow. When i press on it, it will change direction from pointing down to up, but when i press on it a second time it will close the menu but the arrow will still point up. To get it to point down i need to make the whole page active.

There still seems to be some issues with the arrow. When i press on it, it will change direction from pointing down to up, but when i press on it a second time it will close the menu but the arrow will still point up. To get it to point down i need to make the whole page active.

Thanks for reporting it too!
However, I have fixed it for Chrome and other browsers with ease but it just won't work in Firefox. I suggest reporting this to Mozilla.


LANGUAGE_CODE = 'en', but default language is no English but Chinese

What I'm trying to achieve
When user opens the website on a new device, the default language is (en)English, not (zh-hans)Chinese.
Steps to reproduce the problem
LANGUAGE_CODE = 'en' was set in settings, but when new user open the website, the default language is Chinese, not English.
What I expected to happen
I would like to let en(English) as the default language.
Thank you so much for any advice~
System information
Operating system: Mac OSX/ iPhone ios
Browser: Chrome/Safari

Does the browser have a language preference set? If so, that will be respected if Saleor has that same language enabled in settings.LANGUAGES.


Fix #12695 : RangeIndex generated with pd.concat with ignore_index as True

[ ] closes #12695
[ ] tests added / passed
[ ] passes git diff upstream/master | flake8 --diff
[ ] whatsnew entry

Replaced generated indexes with RangeIndex, test still needed

tests! always start with the tests to make sure it fails first!

needs some tests (use the one from the original issue)
whatsnew entry (bug fix)

Thanks for the PR:) But I've included the fix in #12846 to refactor existing code. Pls lmk if anything.


Blur event fired out of order

Current behavior
Recently I noticed an issue apparently related to the popover component. In some circumstances, the focus event is fired in an unpredictable way, leading to bugs in components that rely on it to track focus inside it.
https://user-images.githubusercontent.com/943036/180890247-191640d4-30f5-4999-a248-102aee1aa298.mov
Related: #1659
Steps to reproduce the bug

Open sandbox: https://codesandbox.io/s/hovercard-blur-bug-m31nt6
Press tab to focus on the "Focus" button
Notice the status is not "Focused"
Press tab again to move the focus to the "External focusable area"
See the status is not "Not focused"
Press shift tab to return the focus to the "Focus" button
Notice the status is "Focused" again
Press enter to open the hovercard
Press tab to focus on the "Focus me" button inside the popup
Now, press tab to focus on the "External focusable area"
Notice the status is still "Focused"

Expected behavior
The blur and focus events firing in the correct order.
Workaround
No response
Possible solutions
No response

Thanks! As I'd imagined, that's related to the preserveTabOrder feature. This video shows how this works: Focus management with React Portal.
You can work around that by stopping the propagation of the events on these elements. Instead of targeting them, though, as they're not part of the public API, you can just stop the propagation of all events on elements that are not (or within) the anchor and the hovercard elements:
const anchorRef = useRef<HTMLButtonElement>(null);
const hovercardRef = useRef<HTMLDivElement>(null);

const stopFocusTrapEvents = (event) => {
  if (
    !anchorRef.current.contains(event.target) &&
    !hovercardRef.current.contains(event.target)
  ) {
    event.stopPropagation();
  }
};

<div onFocus={stopFocusTrapEvents} onBlur={stopFocusTrapEvents}>
  <HovercardAnchor ref={anchorRef}>Focus</HovercardAnchor>
  <Hovercard portal ref={hovercardRef}>
    <Button>Focus me</Button>
  </Hovercard>
</div>


strange freeze

Hello
There is strange freezing while browsing

miniblink_4975_x32.dll
wkexe_4975_x32.exe

No freeze if node.dll ver 2<IP_ADDRESS> is used
FREEZE.LOG

https://github.com/weolar/miniblink49/assets/20513479/88bcbecd-fe0b-43fc-936a-33cb098f5b58

No freeze if using node.dll ver 2<IP_ADDRESS>

thank you，let me see it

The same flow in Chrome
auth-preprod.ehealth.gov.ua.zip

The same flow in Chrome (HAR)
Chrome.zip

Hello, @weolar
Is there progress?

Hello, @weolar
Is there progress?

@weolar ?

@weolar ?

I still don’t understand the reason for this freeze ((


This seems like something you'd have to report to Defender (via the Windows Feedback tool), or otherwise exclude.

This seems like something you'd have to report to Defender (via the Windows Feedback tool), or otherwise exclude.
Originally posted by @BillyONeal in https://github.com/microsoft/vcpkg/issues/11854#issuecomment-641685023
also reference: https://github.com/microsoft/vcpkg/issues/11944
Why?
Microsoft/Windows Defender has done exactly what it was designed to do - flagged a script  having commands to add virus exclusions to exempt all the files/folders on C:\ and D:\ and several binaries from being scanned.
Just the script being present makes the system ripe for the picking as it is being pushed to all vcpkg instances local or not.
A nefarious person just needs to find a system with vcpkg running windows using only windows defender as malware protection.
MS Windows Defender/Powershell Commands Reference:
https://docs.microsoft.com/en-us/powershell/module/defender/Add-MpPreference?view=win10-ps
Question: why does vcpkg need to make all of the files/folders on C:\ D:\ and other processes exempt from being scanned by malware software?
I would guess performance on the azure-pipeline, but to sacrifice security for performance in today's age would be highly irregular.

That script is the script that provisions vcpkg's test machines used for PR validation here on GitHub. It is not invoked by vcpkg itself under any circumstances. The test machines, by design, build any PR submitted on GitHub, and we have no means of ensuring those PRs contain no malicious code. Example: https://github.com/BillyONeal/temp-vmss-demo/pull/1
As a result we already consider the test machines hostile entities, so information that they are infected is not interesting to us; the machines only live for a few hours at most and then are completely nuked from orbit (by outright deleting the underlying Azure VM) regularly. Moreover, leaving the AV enabled on them creates false positive / reliability problems because those machines run scripts that create thousands of binaries the AV has never seen. (That is, this script is trying to prevent the same condition on our CI machines that the script itself is creating for the reporter of the original issue)
Maybe if we rename the file with a .txt extension or something that will make the AV happy....

Just the script being present makes the system ripe for the picking as it is being pushed to all vcpkg instances local or not.

No, because anyone who could run the script could themselves run the underlying Add-MPPreference.

Is there a mechanism or one developed to have some type of a
hidden or inaccessible branch of vcpkg that is only cloned or updated if the remote system initiating the git clone or pull request is identified as an azure pipeline, using a specific account and/or falls within a certain range of ip addresses?
In other words if the remote system does not meet certain criteria then the components required for the azure pipeline PR approval process are not cloned/updated.
Please note:

The external users of vcpkg do not consider their systems hostile entities or compromised.
The external users of vcpkg also compile and link those same binaries on their machines having domain/security/system  administrators with policies in place to prevent even the existence of such a script.
Just in this day and age, developers have a hard enough time satisfying administrators, auditors, insurance underwriters and c types in what the developers are doing is safe and meets all kinds of tests, rules, acts, especially the dreaded Sarbanes Oxley Act (SOX) on financial systems.
The obstacles one has to overcome can play into a decision to propagate the adoption and use of a software package, especially open source. One less red flag makes it easier to check all the boxes.

Is there a mechanism or could one be developed to have some type of a hidden or inaccessible branch of vcpkg that is only cloned or updated if the remote system initiating the git clone or pull request is identified as an azure pipeline, using a specific account and/or falls within a certain range of ip addresses?

No. Part of doing development in the open is that the infrastructure must also be in the open. Anyone can set up their own fork with CI set up identically to ours. We also get contributors who modify that script to install additional prerequisites of some ports occasionally.
I was going to try mitigations like changing the file extension (in the normal scenario the script is passed to Invoke-AzVmCommand so it need not have a .ps1 extension on disk) or removing the C:\ entry (now that we've migrated all the interesting work to D:) but I asked Defender to explicitly scan our scripts directory and it reported no hits, so I can't really fix it to avoid the detection.

The external users of vcpkg do not consider their systems hostile entities or compromised.

That's fine, they aren't running that script. Notably that script requires administrative permissions and vcpkg does not, so it couldn't run that script even if it wanted. You can just delete the whole azure-pipelines directory.

The external users of vcpkg also compile and link those same binaries on their machines having domain/security/system administrators with policies in place to prevent even the existence of such a script.

Do they realize that the command to do the problematic part of the script you're complaining about is shorter than the script? By this logic the literal command itself can't exist because after all the code to do it is in there.

The obstacles one has to overcome can play into a decision to propagate the adoption and use of a software package, especially open source. One less red flag makes it easier to check all the boxes.

If you're in an environment with such issues you can always export a built package; you probably don't want the tool that exists to download code from the internet and execute it running in such a sensitive environment anyway. (That applies equally to npm, Conan, crate, etc. since they all run external code)

I added the following lines to my main clone/pull script from github/microsoft/vcpkg - it will solve the problem for me at this time.
git rm .\scripts\azure-pipelines\windows\provision-image.ps1
git commit -m "remove .\scripts\azure-pipelines\windows\provision-image.ps1"

@timautry Can you give the PR linked above a shot and let me know if it resolves the detection for you?
git remote add BillyONeal https://github.com/BillyONeal/vcpkg
git fetch BillyONeal
git switch mitigate_attempt

@BillyONeal It works great for me - windows defender and malwarebytes stand-alone scans did not raise any flags.
Like mentioned, I think the warning comes when the scanner sees those commands in a script type file, a ps1, cmd, bat, etc...
Thank you for taking the time to do this...
I am sorry for taking so long, I had take my automobile to the dealer for work this morning.


fine tuning

I run this code:  sh dbgpt_hub/scripts/train_sft.sh
it seems I need the dbgpt_hub.py file.
I get the following error:
sh dbgpt_hub/scripts/train_sft.sh
dbgpt_hub/scripts/train_sft.sh: line 1: wandb: command not found
Traceback (most recent call last):
File "/opt/app/mpidatasci/Sang.Hua/DB-GPT-Hub/dbgpt_hub/train/sft_train.py", line 6, in
from dbgpt_hub.llm_base.loggings import LogCallback,get_logger

ModuleNotFoundError: No module named 'dbgpt_hub'

The first error is because you don't have install  pkg   wandb , try pip install -r ./requirements.txt    .  In the requirements.txt ,it  has listed wanded include
The scconde error is because path error ,in the lated code version ,in dbgpt_hub/train/sft_train.py  ,we have add the code "
import os
import sys
ROOT_PATH = os.path.dirname(os.path.dirname(os.path.dirname(os.path.abspath(file))))
sys.path.append(ROOT_PATH)
"

I added the code below to dbgpt_hub/train/sft_train.py and I still get the error message.
import os
import sys
ROOT_PATH = os.path.dirname(os.path.dirname(os.path.dirname(os.path.abspath(file))))
sys.path.append(ROOT_PATH)

I added the code below to dbgpt_hub/train/sft_train.py and I still get the error message. import os import sys ROOT_PATH = os.path.dirname(os.path.dirname(os.path.dirname(os.path.abspath(file)))) sys.path.append(ROOT_PATH)

wandp package has installed ?

What version should I install?
pip install wandp
ERROR: Could not find a version that satisfies the requirement wandp (from versions: none)
ERROR: No matching distribution found for wandp

sorry,It's wandb, pip install wandb

I still have the same message.  Do you have the dbgpt_hub module that I can put in the right folder?  That might fix the problem.
File "/opt/app/mpidatasci/Sang.Hua/DB-GPT-Hub/dbgpt_hub/train/sft_train.py", line 6, in
from dbgpt_hub.llm_base.loggings import LogCallback,get_logger

ModuleNotFoundError: No module named 'dbgpt_hub'

I still have the same message. Do you have the dbgpt_hub module that I can put in the right folder? That might fix the problem. File "/opt/app/mpidatasci/Sang.Hua/DB-GPT-Hub/dbgpt_hub/train/sft_train.py", line 6, in
from dbgpt_hub.llm_base.loggings import LogCallback,get_logger

ModuleNotFoundError: No module named 'dbgpt_hub'

what's your command  when it reported this error ?
as our instruciton in README ,   in  DB-GPT-Hub dir , run sh dbgpt_hub/scripts/train_sft.sh , I haved tested again ,that's passed

May be you need to  get the latest version


added solverjs as a Mad science package.

By submitting this pull request, I promise I have read the contribution guidelines twice and ensured my submission follows it. I realize not doing so wastes the maintainers' time that they could have spent making the world better. 🖖
⬆⬆⬆⬆⬆⬆⬆⬆⬆⬆

I don't really see how this is "mad science".

I promise I have read the contribution guidelines twice and ensured my submission follows it.

You did not.

Ok, then can you suggest to me what is the best category for the SolverJs package.


Added a code for mobiletemplate

This is a mobile template in which on click on any mobile it will take to you on amazon site and open a page of same mobile model

@VidhiBhatt01  please check this if it is correct or not


Facilities are going away after 2024-03-30

We got a report, that we are still using the deprecated facilities key in our requests. That will go away after 2024-03-30, and we need to migrate to the metros key instead.
https://deploy.equinix.com/developers/docs/metal/locations/facilities/
https://deploy.equinix.com/developers/docs/metal/locations/metros/
While undocumented, any is a valid metro identifier, that we should migrate to.

Fixed in our fork. https://github.com/NixOS/hydra-scale-equinix-metal/commit/92712e35b1e1d4986db2cf5631752849a6748f5d


chore(open-ux-tools) ignore source map files when publishing to npm

Source map files are not needed in the tgz published to npm. Removing reduces the install size.

@devinea This change would mean we can never debug - this does not only remove during publish. We need to still be able to generate dist/tar including source maps for debugging on BAS for example.

Im not suggesting we publish with source maps, but we still need a way to generate a tgz that includes them.

That sounds like a good compromise to me.


Resource Link

Hi. Firstly, thanks for making such an amazing work open source.
I was trying to reproduce the results and train the re-ranking model using the cmd code shared in the README.md. Unfortunately, it didn't start training due to the lacking files in the "data" folder. I also couldn't download the resources due to the link in Resources section giving 404 - Page Not Found error. My question is how can I access and download those resources to train the re-ranking model?
Thanks.

Hi, thanks for your interest in our work. I somehow forgot the data link. I have updated it in the README file. Please check and feel free to drop any more questions.


time picker and birthday picker

🚀 Feature Proposal
A clear and concise description of what the feature is.
Motivation
Please outline the motivation for the proposal.
Example
Please provide an example for how this feature would be used.

I also really miss BirthdayPicker component!

@shachardevops @32penkin TimePicker is requested here #778, it's on the plan for v5 (#896)

and birthday picker
You may use Datepicker


Decouple creation of image reps from image conversion

Separate creation of image representations from conversion/creation of actual images for the image representations. A new subpackage of bia-integrator (bia-integrator-light) has been created for this. The name reflects its intended use as a lightweight temporary version of bia-converter.

Move contents of image_utils from bia-ingest/bia_ingest into bia-converter-light/bia_converter_light
Create cli.py in bia-converter-light/bia_converter_light
Move scripts for helping with selecting file references to convert to bia-converter-light/scripts

Minor changes requested, mostly to text for other users.
I'm also a bit confused about the naming/context of this package: the 'light' part - why is this more lightweight or temporary compared to the other package?

This package only deals with the case of conversions of one file reference per image representation. An image representation can have more than one file reference (we will implement this is Sprint 5 starting 26/09). However, bia-converter-light will only convert the first file reference in the list, whereas bia-converter will be able to do more complex conversion including creation of multichannel images and multi-slice images from multiple file references. We can call it bia-converter, but I wanted the name to emphasise its limited capabilities.


Change the colour scheme based on temperature / weather type #2

the PR solves issue #2
The background changes depending on the weather type

@grace-omotoso @miador Kindly confirm if the backgrounds are Okay or they need changing

It's like this

@miador @IvyJeptoo I am also in between two opinions as to whether to have the background on the whole page or just the session with the weather card. @kpham841 design-wise, which do you think is better?

Hey @IvyJeptoo, Is there any way to cover the whole background?

I can make it cover the whole background but I thought that way it looks it a bit unique with the blending in


Additional features for analysis phase

For the analysis report, have a 'decision tree' figure with the outcome and how we reach that conclusion
Can we indicate if there are any 'outliers' in our health facilities (eg certain sites with high prevalence)? This was brought up with the example of domain-level prevalence being confidently below the 5% threshold, but perhaps there are still 'high prevalence' sites that would warrant further monitoring or 'deep dives'

These have all been addressed as follows:

For the analysis report, have a 'decision tree' figure with the outcome and how we reach that conclusion (e248e203a07ac2727e86af0b89c073eca494aca5 and 8e966c9e4818c1e8aaaa844aab9d3d49a95b177a)
Can we indicate if there are any 'outliers' in our health facilities (eg certain sites with high prevalence)? This was brought up with the example of domain-level prevalence being confidently below the 5% threshold, but perhaps there are still 'high prevalence' sites that would warrant further monitoring or 'deep dives' (added as issue to DRpower because not within scope of pfhrp2/3 planner)


Go to / Peek Definition command does not work correctly for methods

The Go to Definition and Peek Definition commands doesn't seem to work correctly when it comes to disambiguating calls to a method, when multiple definitions of the method and class exist in different files within the same workspace. The behavior I'm seeing is inconsistent with a similar situation with global functions.
As an example, say there exists two definitions of global function named myfunc1(), each in separate files script1.php and script2.php. Within the global scope of script2.php is a call to myfunc1() function. Executing Peek Definition command on the myfunc1() class will display a panel listing both definitions, showing that PHP Intelephense recognizes the ambiguity. One could argue there is no ambiguity, since script2.php does not include script.php, therefore the myfunc1() definition in script1.php is the correct definition, but I'm overlooking that here.
In contrast to the 'correct' behavior for global functions, the behavior for the Peek Definition command is different, for methods of a class. As a second example, say there exists two definitions of a class MyClass, each in separate files class1.php and class2.php and both class definitions have a single method named MyMethod(). Within the global scope of class2.php, the script creates an instance of MyClass and then calls MyMethod() on the instance. If the Peek Definition command was consistent with the behavior for global functions, I would expect to see the both method definitions for both classes listed in the panel, but this is not what I see. The only definition I see is one within script1.php - the method definition with script2.php is not shown at all, even though this is the actual definition.
Apologies if description above is a little long-winded or difficult to follow. I have created a video demonstrating the above, which I hope will make things clearer:
https://www.youtube.com/watch?v=YbCoGjs7pTc

Sounds like a fair request

Is this project still active?


WIP: Boilerplate: Update to 2a6a579ee07b3df9809fe696606f1138154b4e04

Conventions:

openshift/golang-osd-operator: Update

https://github.com/openshift/boilerplate/compare/d7683e53d446d034f8224b7eba8bf6f6c65a093b...2a6a579ee07b3df9809fe696606f1138154b4e04
commit: 1c13a6d23ef92603bbae32d5fb8f543789fc579c
author: Christoph Blecker
Update image tag in test files
commit: 4d1f8a2678f70f7c64c0ae16800049e3feee64cc
author: Christoph Blecker
Update build_image script to work with RHEL8/go1.17
commit:<PHONE_NUMBER>9339ecb2f9d5d5ff7df0f43b159776
author: Christoph Blecker
Switch to RHEL8 builder image
commit: 03deceeda6b7b39b22e4eae06d59de78e5fdbbf0
author: Eric Fried
Update README for image tagging quirks
Clarify a couple of things in the README wrt image tagging:

You have to push the new tag to your origin as well as upstream.
You have to edit the tag in a couple of in-repo files as well.

commit: b1c28646013edcecdcc7ab0631bd43c3183184b4
author: Eric Fried
Fix broken link in README
The release repo moved the file where we import our backing image.
commit: 35c3064256d88136a6eaa75ced0660a7426d3c70
author: Eric Fried
Remove support for hack/generate-operator-bundle.py
Support for using a "local" (within the consuming repo)
hack/generate-operator-bundle.py script was included as a bridge while
consumers were cutting over to use the common bundle generator. That has
happened. Get rid of the old script, make targets, and support.
commit: 5f249984fba668d090b3ee2194dd0e98e506d43c
author: Ron Green
fix(CONTAINER_ENGINE): allow setting the env
after #201 didn't work, I updated it a bit
now you can set the env and it's not overriden
commit: 304c86f779a2b8cb3daf8f02ae06fc0afe158bca
author: Matt Bargenquast
Support empty SaaS repositories
commit: aa424cb414d16f5227ad15815487932f3ea7276c
author: Ron Green
fix(CONTAINER_ENGINE): allow setting the env
this allows setting the image from an external source (additional checks might be required)
commit: 2c52f542c9e5baf4bd77ed126e70c0c207829cdc
author: Christoph Blecker
Always re-pull the FROM images on container build

this was for demo purposes


fix: Double braced link for Gremlin.Net

@nschonni : Thanks for your contribution! The author, @SnehaGunda, has been notified to review your proposed change.


Tests!

We need some.

I would be happy to help with tests if this is still something clouldpebble is hoping to add.


API internal server error 500

We (dmp.wur.nl) seem to be getting an internal server error 500 when querying the API v0 plans.
We get the error with:
"https://dmp.wur.nl/api/v0/plans?&per_page=100&template[]=1038574365&template[]=1182076051&created_after=2023-04-01"
or
"https://dmp.wur.nl/api/v0/plans"
Querying statistics works without problem:
"https://dmp.wur.nl/api/v0/statistics/plans"
Any ideas what is causing this?

@Danny-dK thanks for letting us know. DMPonline is currently working on a fix for this and will have it rectified shortly. We will push the fix to the DMPRoadmap code base soon after.

@dsisu  Yep, working again. Thanks!!!


jax.lax.scan doesnt work with namedtuples as input argument

        def fun(carry, x):
            y = jnp.abs(residual_function(x,param1, param2))
            return carry, y
        error = jax.lax.scan(fun, 0, residuals)

where residuals is an array of namedtuple.  This gives a "builtins.IndexError: tuple index out of range" error in lax_control_flow.py:1173 (lengths = [x.shape[0] for x in xs_flat]) because residuals is flattened before "iterated" over in the scan.  For example, given a namedtuple, Residual, which has 3 items and x which is [Residual(p1, p2), Residual(p3,4)], the flatten will give a list which is 6 elements long instead of 2.
Documentation (https://jax.readthedocs.io/en/latest/_autosummary/jax.lax.scan.html) shows pseudocode doing "for x in xs" but xs is flattened before the iteration begins

Updated description.  Let me know if more clarity is needed.

Thanks for the question! Can you provide a minimal reproducer of the issue?

where residuals is an array of namedtuple

JAX doesn't support working with object arrays, and an array of namedtuples would be an object array (i.e. ndarray with dtype object).
Also, lax.scan scans over leading axes of arrays, not of lists. That is, in the "for x in xs" pseudocode, it's important that xs is an array!
I'm guessing that things are working as intended, except we should raise a much clearer error message here.

The last 2 sentences answer my question.  It appears this is not a bug
The model I am optimizing has 13 parameters, 2 of which are free.  I originally wrote the code in Ceres making each residual a class instantiation which is a common pattern in Ceres.  However, this pattern is a essentially a array of structures (AOS) which doesn't seem to be supported well by Jax.  In all of the examples I have seen, the data has to be structures of arrays (SOA) because Jax operates on array.

Yes, that's right, JAX really only works with a structures-of-arrays approach.


Partially match in templates

With the addition of template partial matching I'm able to create templates for my requests. However I couldn't find in the docs how to create a template match for a particular path.
Let's say I have a path that looks like this:
GET
/user/2312323/status

How can I match any user id on my template? I was expecting to be able to type something similar to this but it didn't work:
"requestTemplate": {
            "path": "/user/*/status",
            "method": "GET",
            "scheme": "http"
        },

Thanks!
-Ivan

Hey @ifuyivara,
I've encountered a similar problem to this myself. Currently, the templates do not support either wildcarding or regex. They currently match as is with the request, making it impossible to define one template for viewing multiple users.
This is definitely on our roadmap and I will be looking into adding this feature soon.

Hey @ifuyivara,
This feature was added as part of #256. This feature is now available in v0.8.2 our most recent release of Hoverfly. I hope this helps.
If you have any issues with this feature, please let us know.


[FormRecognizer] Formula object data type is incorrect

Package Name: azure-ai-formrecognizer
Package Version:  3.3.1
Operating System: Windows
Python Version: 3.8.5

Describe the bug
According to the documentation, the formula object should be type DocumentFormula instead of DocumentBarcode.
To Reproduce
Steps to reproduce the behavior:
    with open(path_to_sample_documents, "rb") as f:
        poller = document_analysis_client.begin_analyze_document(
            "prebuilt-layout", document=f, features=[AnalysisFeature.FORMULAS]
        )
    result = poller.result()
    print(type(result.pages[0].formulas[0]))

Expected behavior
The type should be DocumentFormula instead of DocumentBarcode.
Screenshots

Additional context

Hi @toothache , thanks for your contribution! We'll prepare a release for it in next month.


Cannot find Targets

Python 3.8.3 (tags/v3.8.3:6f8c832, May 13 2020, 22:20:19) [MSC v.1925 32 bit (Intel)] on win32
Type "help", "copyright", "credits" or "license()" for more information.

================= RESTART: C:\Users\Yogesh Wadhwa\Desktop\4.py =================
['"HNI Keerat Kohli"', '"HNI SAGAR GOYAL"', '"HNI Abhinav Sharma"', '"HNI SONAL MEHTA"', '"HNI Rosy Merie Cerquetna"', '"HNI Ravi Shankar Singh"', '"HNI Shobhit Kumar"', '"HNI Vikram Singh"', '"HNI Ho young Shin"', '"HNI Gaurav  Yadav"', '"HNI SARAVANAN K"', '"HNI Anuj Mighlani"', '"HNI Mayank Shekhar Dwivedi"', '"HNI Amit Aggarwal"']
Scan the QR code and then press Enter

================= RESTART: C:\Users\Yogesh Wadhwa\Desktop\4.py =================
['"HNI Keerat Kohli"', '"HNI SAGAR GOYAL"', '"HNI Abhinav Sharma"', '"HNI SONAL MEHTA"', '"HNI Rosy Merie Cerquetna"', '"HNI Ravi Shankar Singh"', '"HNI Shobhit Kumar"', '"HNI Vikram Singh"', '"HNI Ho young Shin"', '"HNI Gaurav  Yadav"', '"HNI SARAVANAN K"', '"HNI Anuj Mighlani"', '"HNI Mayank Shekhar Dwivedi"', '"HNI Amit Aggarwal"']
Scan the QR code and then press Enter
1 . Target is: "HNI Keerat Kohli"
Cannot find Target: "HNI Keerat Kohli"
2 . Target is: "HNI SAGAR GOYAL"
Cannot find Target: "HNI SAGAR GOYAL"
3 . Target is: "HNI Abhinav Sharma"
Cannot find Target: "HNI Abhinav Sharma"
4 . Target is: "HNI SONAL MEHTA"
Cannot find Target: "HNI SONAL MEHTA"
5 . Target is: "HNI Rosy Merie Cerquetna"
Cannot find Target: "HNI Rosy Merie Cerquetna"
6 . Target is: "HNI Ravi Shankar Singh"
Cannot find Target: "HNI Ravi Shankar Singh"
7 . Target is: "HNI Shobhit Kumar"
Cannot find Target: "HNI Shobhit Kumar"
8 . Target is: "HNI Vikram Singh"
Cannot find Target: "HNI Vikram Singh"
9 . Target is: "HNI Ho young Shin"
Cannot find Target: "HNI Ho young Shin"
10 . Target is: "HNI Gaurav  Yadav"
Cannot find Target: "HNI Gaurav  Yadav"
11 . Target is: "HNI SARAVANAN K"
Cannot find Target: "HNI SARAVANAN K"
12 . Target is: "HNI Anuj Mighlani"
Cannot find Target: "HNI Anuj Mighlani"
13 . Target is: "HNI Mayank Shekhar Dwivedi"
Cannot find Target: "HNI Mayank Shekhar Dwivedi"
14 . Target is: "HNI Amit Aggarwal"
Cannot find Target: "HNI Amit Aggarwal"
Successfully Sent to:  0
Failed to Sent to:  14
['"HNI Keerat Kohli"', '"HNI SAGAR GOYAL"', '"HNI Abhinav Sharma"', '"HNI SONAL MEHTA"', '"HNI Rosy Merie Cerquetna"', '"HNI Ravi Shankar Singh"', '"HNI Shobhit Kumar"', '"HNI Vikram Singh"', '"HNI Ho young Shin"', '"HNI Gaurav  Yadav"', '"HNI SARAVANAN K"', '"HNI Anuj Mighlani"', '"HNI Mayank Shekhar Dwivedi"', '"HNI Amit Aggarwal"']
I am getting above mentioned errors although contacts are there in my contact list.
could you help

Hi @youmania83, I have developed a package for easily sending WhatsApp messages in a hassle-free manner.
You must have Chrome and Chrome Driver
Installation:
pip install wappdriver
Code :
from wappdriver import WhatsApp
with WhatsApp() as bot:
    bot.send('aahnik',  # name of recipient in contacts
             'hi send by a bot')

completely hassle free. When you run this for first time, you have to input Chrome Driver path
To learn more visit website


Error on PYTHON 3.5 / Windows when testing example

There is no output because it has problems with the temporary directory
subprocess.CalledProcessError: Command '['latexmk', '-pdf', '-pdflatex=pdflatex -interaction=batchmode -halt-on-error -no-shell-escape -file-line-error %O %S', 'C:\\Users\\sruiz\\AppData\\Local\\Temp\\tmpfroqoypt\\tmpt171wtiv.latex']' returned non-zero exit status 12

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "C:\Users\sruiz\Projects\ManageQualityBetter\env\lib\site-packages\data\__init__.py", line 252, in temp_saved
    yield tmp
  File "C:\Users\sruiz\Projects\ManageQualityBetter\env\lib\site-packages\latex\build.py", line 98, in build_pdf
    raise_from(LatexBuildError(base_fn + '.log'), e)
  File "C:\Users\sruiz\Projects\ManageQualityBetter\env\lib\site-packages\future\utils\__init__.py", line 399, in raise_from
    exec(execstr, myglobals, mylocals)
  File "<string>", line 1, in <module>
latex.exc.LatexBuildError: None

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "C:\Users\sruiz\Projects\ManageQualityBetter\env\lib\site-packages\data\__init__.py", line 255, in temp_saved
    os.unlink(tmp.name)
PermissionError: [WinError 32] El proceso no tiene acceso al archivo porque est▒ siendo utilizado por otro proceso: 'C:\\Users\\sruiz\\AppData\\Local\\Temp\\tmpfroqoypt\\tmpt171wtiv.latex'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "C:\Users\sruiz\Projects\ManageQualityBetter\env\lib\site-packages\latex\build.py", line 100, in build_pdf
    return I(open(output_fn, 'rb'), encoding=None)
  File "c:\python35\Lib\contextlib.py", line 77, in __exit__
    self.gen.throw(type, value, traceback)
  File "C:\Users\sruiz\Projects\ManageQualityBetter\env\lib\site-packages\data\__init__.py", line 258, in temp_saved
    reraise(e)
TypeError: reraise() missing 1 required positional argument: 'value'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "tmp.py", line 10, in <module>
    pdf = build_pdf(min_latex)
  File "C:\Users\sruiz\Projects\ManageQualityBetter\env\lib\site-packages\latex\build.py", line 203, in build_pdf
    return builder.build_pdf(source, texinputs)
  File "<decorator-gen-1>", line 2, in build_pdf
  File "C:\Users\sruiz\Projects\ManageQualityBetter\env\lib\site-packages\data\decorators.py", line 82, in _
    return f(*bvals.args, **bvals.kwargs)
  File "C:\Users\sruiz\Projects\ManageQualityBetter\env\lib\site-packages\latex\build.py", line 100, in build_pdf
    return I(open(output_fn, 'rb'), encoding=None)
  File "C:\Users\sruiz\Projects\ManageQualityBetter\env\lib\site-packages\tempdir.py", line 25, in __exit__
    return self.dissolve()
  File "C:\Users\sruiz\Projects\ManageQualityBetter\env\lib\site-packages\tempdir.py", line 30, in dissolve
    shutil.rmtree(self.name)
  File "C:\Users\sruiz\Projects\ManageQualityBetter\env\lib\shutil.py", line 488, in rmtree
    return _rmtree_unsafe(path, onerror)
  File "C:\Users\sruiz\Projects\ManageQualityBetter\env\lib\shutil.py", line 383, in _rmtree_unsafe
    onerror(os.unlink, fullname, sys.exc_info())
  File "C:\Users\sruiz\Projects\ManageQualityBetter\env\lib\shutil.py", line 381, in _rmtree_unsafe
    os.unlink(fullname)
PermissionError: [WinError 32] El proceso no tiene acceso al archivo porque est▒ siendo utilizado por otro proceso: 'C:\\Users\\sruiz\\AppData\\Local\\Temp\\tmpfroqoypt\\tmpt171wtiv.latex'
Exception ignored in: <bound method TempDir.__del__ of <tempdir.TempDir object at 0x0000000000B4C9E8>>
Traceback (most recent call last):
  File "C:\Users\sruiz\Projects\ManageQualityBetter\env\lib\site-packages\tempdir.py", line 19, in __del__
    self.__exit__(None, None, None)
  File "C:\Users\sruiz\Projects\ManageQualityBetter\env\lib\site-packages\tempdir.py", line 25, in __exit__
    return self.dissolve()
  File "C:\Users\sruiz\Projects\ManageQualityBetter\env\lib\site-packages\tempdir.py", line 30, in dissolve
    shutil.rmtree(self.name)
  File "C:\Users\sruiz\Projects\ManageQualityBetter\env\lib\shutil.py", line 488, in rmtree
    return _rmtree_unsafe(path, onerror)
  File "C:\Users\sruiz\Projects\ManageQualityBetter\env\lib\shutil.py", line 383, in _rmtree_unsafe
    onerror(os.unlink, fullname, sys.exc_info())
  File "C:\Users\sruiz\Projects\ManageQualityBetter\env\lib\shutil.py", line 381, in _rmtree_unsafe
    os.unlink(fullname)
PermissionError: [WinError 32] El proceso no tiene acceso al archivo porque est▒ siendo utilizado por otro proceso: 'C:\\Users\\sruiz\\AppData\\Local\\Temp\\tmpfroqoypt\\tmpt171wtiv.latex'

I'll admit, Windows support is probably poor, because I don't use it at all at the moment. Also, my spanish isn't that good either =).
Could you reduce this to a minimal test-case maybe?

I'm working on both.

Let me test changing the latex builder. Now I use MkTex. I think something blocks the archive .tex. Maybe subprocess or the own MkTex.
I'm trying with TexLive on Windows

Tested with TexLive and I get the same error
Translating to english:
PermissionError: [WinError 32] The process can not access to the file because is used by other process: 'C:\Users\sruiz\AppData\Local\Temp\tmpm9t8hy00\tmpahz6_eei.latex'

Confirmed to get error in data package.
debuging till error and it's on line 105:
return I(open(output_fn, 'rb'), encoding=None)

I think it's because Windows does not allow file to be reopened in the same way that *nix does. At least that would be in line with the error message.
As I said, I do not have a Windows box ready to go at this time. A guess would be that a temporary file is supposed to be read by mklatex/pdflatex, but is still open by the latex package. If that's the case, maybe reordering things slightly and adding a close(), as well as using the volatile package (https://github.com/mbr/volatile) might fix things on the data side and that may be enough.
However, this is all speculation for now, sorry =(

There are actually two problems here, he just didn't reach the second one, yet:

On Windows, you cannot delete a folder, when there are still open handles pointing into it.
In the line
 return I(open(output_fn, 'rb'), encoding=None)

you open a file and with the return you exit the context of the TempDir object causing it to delete the directory. This will result in this error message on an English Windows system:

WindowsError: [Error 32] The process cannot access the file because it is being used by another process: 'c:\\users\\<username>\\appdata\\local\\temp\\tmp23gzgh\\tmpmx9xnk.pdf'

This can be fixed by using
 return I(open(output_fn, 'rb').read(), encoding=None)

which is less memory efficient, of course.

On Windows, access to the file of tempfile.NamedTemporaryFile is exclusive: "Whether the name can be used to open the file a second time, while the named temporary file is still open, varies across platforms (it can be so used on Unix; it cannot on Windows NT or later)" (https://docs.python.org/2/library/tempfile.html). But with
 source.temp_saved(suffix='.latex', dir=tmpdir) as tmp

you keep the temp file opened in temp_saved, thus pdflatex / latexmk cannot open the latex file.
This can be fixed in data.init.py:Data.temp_saved by explicitly closing the file before yielding it:
     tmp.flush()
     tmp.close()
     yield tmp

With these two changes, I can build PDF files on Windows. (OK, I also added this, because I don't have perl installed:
    import latex.build

    latex.build.PREFERRED_BUILDERS = [
        latex.build.PdfLatexBuilder,
    ]

but that's another story)

Thanks for the investigation. I don't have a Windows machine at the moment and it has been years since I did anything but play games on one.
The fixes look okay and I don't think reading the full file into memory is a big issue. However, I cannot test things on Windows. Would you be willingt to make a pull request?

OK, done and works for me.
I first wanted to address the issue with temp_saved in the data package, but it didn't work out well with the tests. So changing it directly in the latex package also avoids the interface semantic change. Maybe you want to leave a comment about this potential problem on Windows in the data package, though.

I've merged this for now, before the next release, I'll have to check if it still works on *nix.

The very same problem appeared on Arch Linux.
It looks like temporary directory is not created. If I remove subprocess.check_call() I meet FileNotFound for /tmp/tmp*/tmp*.aux.

Same error, I'm using MikTeX and have pdfLaTeX installed. I guess it could directly use pdflatex to build it instead of latexmk
Traceback (most recent call last):
  File "C:\Users\aadibajpai\AppData\Local\Programs\Python\Python37\lib\site-packages\latex\build.py", line 111, in build_pdf
    stderr=open(os.devnull, 'w'), )
  File "C:\Users\aadibajpai\AppData\Local\Programs\Python\Python37\lib\subprocess.py", line 328, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['latexmk', '-pdf', '-pdflatex=pdflatex -interaction=batchmode -halt-on-error -no-shell-escape -file-line-error %O %S', 'C:\\Users\\AADIBA~1\\AppData\\Local\\Temp\\tmpllaqidgp\\tmpwj0oq0wi.latex']' returned non-zero exit status 1.

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "C:\Users\aadibajpai\Desktop\ltx.py", line 263, in <module>
    latex.build_pdf(tex)
  File "C:\Users\aadibajpai\AppData\Local\Programs\Python\Python37\lib\site-packages\latex\build.py", line 232, in build_pdf
    return builder.build_pdf(source, texinputs)
  File "<decorator-gen-1>", line 2, in build_pdf
  File "C:\Users\aadibajpai\AppData\Local\Programs\Python\Python37\lib\site-packages\data\decorators.py", line 82, in _
    return f(*bvals.args, **bvals.kwargs)
  File "C:\Users\aadibajpai\AppData\Local\Programs\Python\Python37\lib\site-packages\latex\build.py", line 113, in build_pdf
    raise_from(LatexBuildError(base_fn + '.log'), e)
  File "C:\Users\aadibajpai\AppData\Local\Programs\Python\Python37\lib\site-packages\future\utils\__init__.py", line 398, in raise_from
    exec(execstr, myglobals, mylocals)
  File "<string>", line 1, in <module>
latex.exc.LatexBuildError: None


make submitblock.sh more usable

Change the commands to take named inputs that make more sense to the user.
Context, from the documentation:
./genblocks --blocks-dir blocksA > blocksA.txt
./utils/submitblocks.sh 1000 1000 blocksA.txt
In the submitblocks.sh command, the first “1000” is the height to serve the first block at (so that if blocksA.txt contains 6 blocks they will be served as heights 1000, 1001, 1002, 1003, 1004, and 1005. If the genblocks tool was used to create the blocksA file, then this argument must match what was given to genblocks, otherwise the heights in the coinbase transactions will not match up with the height lightwalletd is serving the blocks as. The second “1000” sets the value that lightwalletd will report the sapling activation height to be.

I think we should make darksidewalletd use the first block's coinbase height as the start height and the sapling activation height by default, then in most cases submitblocks.sh won't require those arguments at all, and usage would look like ./utils/submitblocks.sh blocksA.txt.
Then add --start-height and --sapling-activation switches with help information on -h or no arguments.


Shortcuts

Is there a list of shortcuts for functions, variables, comments etc?

Thank you!

Great work this should be added to the readme about page and possibly even included in the bundle

@or3lie :+1:


Handle per second rate limits

The challenge will be if multiple instances are sharing an API key.

I doubt all the config entries would be on the exact same schedule. The interval may be the same but they are not getting set up at the exact same time. Could be wrong though, something to consider for sure

Codecov Report

Merging #15 (de5e7ef) into master (267fc61) will increase coverage by 2.87%.
The diff coverage is 91.04%.

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
+ Coverage   85.18%   88.05%   +2.87%
==========================================
  Files           7        7
  Lines         324      335      +11
==========================================
+ Hits          276      295      +19
+ Misses         48       40       -8

Impacted Files
Coverage Δ

pytomorrowio/pytomorrowio.py
88.82% <90.90%> (+5.39%)
:arrow_up:

pytomorrowio/const.py
92.03% <100.00%> (+0.07%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce2cc87...de5e7ef. Read the comment docs.

I think it's better to fail in that case. If the headers are there but that particular header isn't included that's an upstream problem and we should fail the update


opengfw: init at 0.2.0 (+nix module)

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[x] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Please update the title, and squash comment

Please split the maintainers and application comment

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/4116

Result of nixpkgs-review pr 290008 run on x86_64-linux 1

1 package blacklisted:

nixos-install-tools

1 package built:

opengfw


Support new<EMAIL_ADDRESS>API

Issue
Setup:

Deno Version: 1.14.0
v8 Version: <IP_ADDRESS>
Typescript Version: 4.4.2
SuperDeno Version: 4.4

Details
With new std/http superdeno doesn't work anymore. superdeno should support new API and deprecate the old one

sicck thanks for updating it, @asos-craigmorten !

Released in<EMAIL_ADDRESS>- please reopen if have any issues!

@cmorten it seems to erase some headers?
import { superdeno } from<EMAIL_ADDRESS>import { describe, it, run } from<EMAIL_ADDRESS>import { compression } from 'https://deno.land/x/compression/mod.ts'

describe('options', () => {
  it('applies compression to a file', async () => {
    const request = superdeno(compression({ path: 'README.md', compression: ['gzip'] }))

    await request
      .get('/')
      .set('Accept-Encoding', 'gzip')
      .expect('Content-Length', '694')
      .expect('Content-Encoding', 'gzip')
  })
})

run()

yields
Error: expected "Content-Length" header field
    at Test.#assertHeader (https://deno.land/x/superdeno@4.5.0/src/test.ts:582:14)
    at Test.#assertFunction (https://deno.land/x/superdeno@4.5.0/src/test.ts:637:13)
    at Test.#assert (https://deno.land/x/superdeno@4.5.0/src/test.ts:500:35)
    at https://deno.land/x/superdeno@4.5.0/src/test.ts:475:23
    at async close (https://deno.land/x/superdeno@4.5.0/src/close.ts:47:46)

failures:

        options > applies compression to a file

test result: FAILED. 1 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out (509ms)


Introducing tests for clarity.data.utils module

Starting work on writing unittests with the functions in the clarity.data.utils module.
Paramterised the tests and have also introduced try: ... except: statements to several of the functions and checked that these are correctly raised when passed incorrect data.

I'm not entirely sure why coverage of cec1_data.py has decreased. The CodeCov report shows the lines that are no longer covered and suggests they are "indirect coverage changes" but I still can't see why this might have arisen. :shrug:

Redundant, changes are in #100


Feature Request: Crow enemy

Use Case:
Outline the use case and/or provide a user story.

"As a player, I want a crow enemy in the game to add a challenging aerial threat, enhancing the gameplay experience and encouraging strategic planning and movement"

Description:
Describe the feature you'd like to see added.

This issue involves plotting the movement and collision of the crow enemy.

From the Design document:

Flies over the screen from the top to bottom
The effect area is 3x3 tiles
Warning UI before they swoop, with visual and audio cues
If the player is in the crow’s shadow (3x3 tile) and not hiding, the crow will hit the player and they will lose all items/power ups (shields)
The crows gain one random equipped powerup for a short period of time from hitting the player
The player can either hide in a hay bale or avoid the crow

For the purpose of this issue I will only initially cover the crow movement, collision area and a warning UI when the crow spawns

Closing issue as the basic crow spawning, movement and shadow detection resolved in pull request:

#14