Create Class field for Students

Add a class field for each Student
Class field can be set for students being created/edited using a"c/" prefix
Class is a compulsory field for "add" and "edit" commands
Add tests for ClassGroup
Update existing tests to include class field

Closes #51

Codecov Report

Merging #59 (3f46b7f) into master (b012f66) will increase coverage by 0.95%.
The diff coverage is 90.00%.

@@             Coverage Diff              @@
##             master      #59      +/-   ##
============================================
+ Coverage     72.15%   73.11%   +0.95%
- Complexity      399      422      +23
============================================
  Files            70       73       +3
  Lines          1232     1302      +70
  Branches        125      134       +9
============================================
+ Hits            889      952      +63
- Misses          311      314       +3
- Partials         32       36       +4

Impacted Files
Coverage Δ

.../java/seedu/address/logic/commands/AddCommand.java
100.00% <ø> (ø)

src/main/java/seedu/address/ui/StudentCard.java
0.00% <0.00%> (ø)

...java/seedu/address/storage/JsonAdaptedStudent.java
94.00% <57.14%> (-6.00%)
:arrow_down:

...main/java/seedu/address/model/student/Student.java
95.74% <71.42%> (-1.88%)
:arrow_down:

...java/seedu/address/logic/commands/EditCommand.java
95.89% <87.50%> (-1.13%)
:arrow_down:

...n/java/seedu/address/model/student/ClassGroup.java
87.50% <87.50%> (ø)

...eedu/address/logic/commands/ClassGroupCommand.java
100.00% <100.00%> (ø)

...a/seedu/address/logic/parser/AddCommandParser.java
100.00% <100.00%> (ø)

.../seedu/address/logic/parser/AddressBookParser.java
100.00% <100.00%> (ø)

.../address/logic/parser/ClassGroupCommandParser.java
100.00% <100.00%> (ø)

... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Update add-a-text-alternative-to-images-for-visually-impaired-accessi…

…bility.portuguese.md

[ ] I have read freeCodeCamp's contribution guidelines.
[ ] My pull request has a descriptive title (not a vague title like Update index.md)
[ ] My pull request targets the master branch of freeCodeCamp.
[ ] None of my changes are plagiarized from another source without proper attribution.
[ ] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
[ ] My changes do not use shortened URLs or affiliate links.

Closes #XXXXX

@TheSirion Can you validate that Instructions section is a good translation of the same section of the English version of the same challenge?

@TheSirion Can you validate that Instructions section is a good translation of the same section of the English version of the same challenge?

Of course!

@5kytrix See @TheSirion's suggestions.  If you have any questions/concerns feel free to reply back.  If you agree with the suggestions, please use the Commit suggestion button so we can get this merged.
Thank you.

@RandellDawson can you help me in finding the Commit suggestion button?
Thank you.

@5kytrix Sorry for the confusion.  I thought @TheSirion had used the Suggestion feature, but he did not.  You will just need to create a new commit and push to the same branch patch-2 instead.

As there has been no response from your end for a while, we are closing this PR.
Feel free to request this PR to be reopened or create a new PR, if you still wish to make the changes you originally added plus any additional change requests asked of you.  Also, remember to update your fork, so you have the latest version of master in case it has changed significantly.
Happy Coding!

Sorry for disappearing. I really want to help, but I haven't been able to
organize my time in order to dedicate time to the project. Also, I've been
having some trouble with GitHub and its features so I'm constantly worried
I'm doing something wrong.
Therefore I'll be stepping back for a while, but I want to come back
eventually. Sorry and thank you for your patience.
Em qui., 28 de nov. de 2019 às 22:12, Randell Dawson <
<EMAIL_ADDRESS>escreveu:

As there has been no response from your end for a while, we are closing
this PR.
Feel free to request this PR to be reopened or create a new PR, if you
still wish to make the changes you originally added plus any additional
change requests asked of you. Also, remember to update your fork, so you
have the latest version of master in case it has changed significantly.
Happy Coding!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/freeCodeCamp/freeCodeCamp/pull/37211?email_source=notifications&email_token=AD2RZ2YDCEQNJHOA4TBC4LTQWBT65A5CNFSM4I72H3E2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFNUDKA#issuecomment-559628712,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AD2RZ26ETXB4YGQR4NNQFWLQWBT65ANCNFSM4I72H3EQ
.


Add ChunkCount() method to ChunkSeries

See https://github.com/grafana/mimir/pull/5369.

Based on tracing through the code a bit more, as well as verifying with a debugger, I don't believe EstimatedChunkCount() will ever be called on anything apart from chunkSeriesEntry.
So to simplify this PR, I've replaced the complex estimations with simple but expensive iteration of the final chunks themselves for seriesToChunkEncoder and NewCompactingChunkSeriesMerger. These should never actually be used, but if my understanding turns out to be incorrect, then these will at least still work and we can optimise if need be.

Given the approval from @krajorama, I'm going to merge this, but if anyone has any late feedback, let me know.


Projector: Permission change

Current behavior
Currently, with the group right “Can see the projector”, you can see the projector in the Autopilot and the menu item “Projector”. The last point is suboptimal, as A) the menu item potentially contains further administrative content that should not be publicly visible and B) the menu bar generally contains an item that offers no added value for following a meeting.
Wanted behavior
The group right 'Can see the projector' should only make the projector visible in Autopilot, no longer the menu item 'Projector'. The menu item should only be visible via the 'Can manage the projector' group right.
Important: The content currently projected onto the standard projector should still be visible in the Autopilot. No changes should be made in the Autopilot.

@MSoeb Please specify which information should not be visible to users without "Can manage the projector" permission. This infos should be restricted.

Talked to @MSoeb:
Wanted behavior is:

The default projector should be visible in autopilot with "can see autopilot" permission
The menu entry and the projectors are visible with the "can see projector" permission
No changes are necessary for "can manage projector" permission


fix(Timeline): show loading state if not played but duration is infinity

Instead of hiding timeline when duration === Infinity - show loading state, and hide timeline completely only if played is true and duration === Infinity

:tada: This issue has been resolved in version 1.1.2-next.1 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 1.1.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


BUG: TypeError: Cannot read properties of null (reading 'timestamp') Curve TWAP

Curve TWAP error: TypeError: Cannot read properties of null (reading 'timestamp') when trying to load page.

I think fixed it with https://github.com/VolumeFi/palomabot/pull/365. Please test it again.

Fixed with https://github.com/VolumeFi/palomabot/pull/365


Is it better to use SetValues or update a tracked entity by reference?

// Fetch the item from the database
var itemFromDatabase = await _context.Set<TEntity>().SingleOrDefaultAsync(x => x.Id == updateViewModel.Id);

// Overwrite the values on the EF tracked itemFromDatabase
_mapper.Map(updateViewModel, itemFromDatabase);

// ------------
//       VS
// ------------

// Map VM to an entity and then call SetValues instead of the above approach
var updateEntity = _mapper.Map<TEntity>(updateViewModel);
_context.Entry(itemFromDatabase).CurrentValues.SetValues(updateEntity);

How different are these? Which is preferred? I know when you use AutoMapper, your config could be newing up navigation property items. SetValues wont do that right?
Bonus question: Is saying "tracked" the same thing as saying "attached" in EF land?

@VictorioBerra I'm not familiar enough with AutoMapper to know for sure. They are both taking values from one object and applying them to another object. SetValues does it in a very simplistic way, so I would be surprised if you can't configure AutoMapper to do the same thing. You are correct that SetValues only works on the non-navigation mapped properties of the entity.
Yes, "tracked" is the same as "attached". However, attached can sometimes imply that the state is Unchanged because the Attach method does this.

@ajcvickers Thanks for taking the time to answer! One follow up question, does context.Entry() attach if an item is detached? Whats the difference betwee:
var a = _context.Attach(item);
var b = _context.Entry(item);

They both return an EntityEntry. I assume Entry wont work if the entity is not already being tracked?

@VictorioBerra See: Attach and Entry.


Idea: Upload chat history to gist

Issue
I'm not sure the best way to implement this feature request/workflow, but I thought I'd share what I'm doing today, in case it inspires others/gives me a better approach :)
I like to have the chat history that created the changes, as a result I upload the aider conversation to a gist, then link it to the diff.
My workflow is normally:

create a branch
use aider to make a bunch of changes
upload the history
Do a rebase to squash a bunch of the commits
Link the chat gist to the file.

For reference here's the gist upload code
function ghg-aider()
{
    trim_file_after_marker_to_new_file '.aider.chat.history.md' '# aider chat started at' '.aider.last.chat.md'
    gh gist create -w .aider.last.chat.md
}

Here's an example of such a diff/gist:

Link to the "feature": https://github.com/idvorkin/Settings/commit/4b1bf128a4c137dc4823d1ab00890bf257d4e0d8
Aider Chat History: https://tinyurl.com/2bwbpncz

Version and model info
No response

Sorry about that incorrect reply.
Aider support making those shared chat histories look pretty:
https://aider.chat/docs/faq.html#can-i-share-my-aider-chat-transcript

Oh sweet. Thanks!
On Mon, Aug 19, 2024 at 12:20 PM paul-gauthier @.***>
wrote:

Sorry about that incorrect reply.
Aider support making those shared chat histories look pretty:
https://aider.chat/docs/faq.html#can-i-share-my-aider-chat-transcript
—
Reply to this email directly, view it on GitHub
https://github.com/paul-gauthier/aider/issues/1108#issuecomment-2297274669,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACETFPAYJ7WZ5JHZBWCQKLZSJAP3AVCNFSM6AAAAABMUZDWW6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJXGI3TINRWHE
.
You are receiving this because you authored the thread.Message ID:
@.***>

I'm going to close this issue for now, but feel free to add a comment here and I will re-open or file a new issue any time.


LCEL not working, compared to identical invoke() call sequence

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain rather than my code.
[X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).

Example Code
I have to following chain defined:
chain = prompt | llm_openai | parser
chain_result = chain.invoke({"number": number, "topics": topicList})
result = chain_result[0]

This causes my test to fail, whereas calling the invoke() methods one is working fine:
promt_result = prompt.invoke({"number": number, "topics": topicList})
llm_result = llm_openai.invoke(promt_result)
parser_result = parser.invoke(llm_result)
result = parser_result[0]

Error Message and Stack Trace (if applicable)
Pydantic validation error
Description
IMHO using a LCEL chain should work exactly like calling the invoke() methods one by one. In my case I am unable to use LCEL because it does not work.
System Info
System Information

OS:  Linux
OS Version:  #1 SMP PREEMPT_DYNAMIC Fri May 17 21:20:54 UTC 2024
Python Version:  3.12.3 (main, Apr 17 2024, 00:00:00) [GCC 14.0.1 20240411 (Red Hat 14.0.1-0)]

Package Information

langchain_core: 0.1.52
langchain: 0.1.14
langchain_community: 0.0.38
langsmith: 0.1.67
langchain_openai: 0.1.1
langchain_text_splitters: 0.0.2

@knodlagc could you provide a minimal reproducible example? (i.e., could you include the parser definition) (https://stackoverflow.com/help/minimal-reproducible-example)


Filling shuffle buffer, this happens before the beginning of every epoch. Is there a way to avoid it?

I am following this tutorial, however I am using my own dataset stored as a csv file consisting 1265800 elements. My question is:
Before the beginning of every epoch, it shows Filling up shuffle buffer (this may take a while). I think it means that it is shuffling the dataset before feeding it to the model for training. Is there a way to not to shuffle this before every epoch because it takes time before proceeding to the next epoch.
Also, this behaviour is not seen if I run the example model on Google Colab. I also read this issue but didn't help.
Thank you for your inputs.

Shuffling is required to Train the Model with as many different Samples (Versatile data) as possible. Since your data is huge, you can use tf.data.experimental.shuffle_and_repeat, which combines the best of good performance and varied Samples. Refer this TF Link for more info.

Automatically closing due to lack of recent activity. Please update the issue when new information becomes available, and we will reopen the issue. Thanks!

Hi @rmothukuru , thank you for your suggestion. Please excuse me I could not test it earlier and respond here.
I followed your suggestion and instead of using Dataset.shuffle as used in the link, I am using Dataset.apply(tf.data.experimental.shuffle_and_repeat()) from here but the problem still is there. What still happening is, it is still filling up the buffer and for that it is consuming the CPU RAM memory which after sometime fills up and everything stops responding then I have to kill every process. My questions are,
Is this a normal behaviour and if so, then how can one shuffle a huge dataset like this? Or do I need more CPU RAM so that it can be used for filling up the shuffle buffer?

I tried to train the model without using shuffle() function. It does not fill up the buffer but the start of the model training, it throws (GPU_0_bfc) ran out of memory trying to allocate 1.37GiB (rounded to<PHONE_NUMBER>). I am not sure on how to troubleshoot this problem, I tried various batch sizes also like 1,2, 128,256,512, 1024.

Hello @rmothukuru , any updates on the issue? Because, I still can not shuffle my data before feeding it to the mode for training. :(

@rishabhsahrawat Is this still an issue.? I noticed you have opened multiple issues on this or similar topic. If this was covered in other opened issues, then please close this issue. Thanks!

Yes, this has been answered here.


Enable flink dependency enforcement and make dependencies explicit

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[ ] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[x] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[ ] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[ ] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

R: @aljoscha

Run Flink ValidatesRunner

Run Flink ValidatesRunner

Coverage increased (+0.01%) to 70.659% when pulling 89d82a1a2d3c7bccb63fb13044351c5664f74728 on iemejia:fix-flink-deps into f7d727c0f7ada7a162f5cb73f658ce52f094dd86 on apache:master.

Coverage increased (+0.003%) to 70.652% when pulling 89d82a1a2d3c7bccb63fb13044351c5664f74728 on iemejia:fix-flink-deps into f7d727c0f7ada7a162f5cb73f658ce52f094dd86 on apache:master.

I created https://issues.apache.org/jira/browse/BEAM-1993 and https://issues.apache.org/jira/browse/BEAM-1994. Would you be interested in working on these? They simply remove code and restructure the modules. I'm asking because it would affect this PR.

Sure I will take both if you don't mind after this one gets merged.

Run Flink ValidatesRunner

Coverage increased (+0.02%) to 70.669% when pulling 8c5778eacd495156b9a57d3f13b8efb6fffc9de7 on iemejia:fix-flink-deps into f7d727c0f7ada7a162f5cb73f658ce52f094dd86 on apache:master.

Yep, this still LGTM!


Pygments - scrollbar

When using pygments, there is no horizontal scrollbar when is wider than the page:

For a live example, see: http://localhost:1313/blog/2016/07/25/aspnet-core-taghelpers---a-better-addtaghelper-type-resolver/
I haven't tried the alternative (highlight.js) so not sure how horizontal scrollbars are handled in that scenario.

I don't use pygments on my site so I never would have seen this. Thanks for providing a fix, I included it in d54e167

Nice one, cheers.


@CacheResult doesn't have @InterceptorBinding and Partial-Bean Module

I'm using Deltaspike Repositories which uses Partial-Bean. Currently the interceptor for CacheResult doesn't work because it doesn't have @InterceptorBinding.
Can/Should the @CacheResult (and the others) have the @InterceptorBinding? Or the spec doens't allow it?

I found this:
/**

Service interface implemented by extensions. An extension is a service provider declared in META-INF/services.

@author Greg Luck
@since 1.0
*/
public class InterceptorExtension implements Extension {

/**

Service interface implemented by extensions. An extension is a service provider declared in META-INF/services.

@param beforeBeanDiscoveryEvent the event to register
*/
void discoverInterceptorBindings(@Observes BeforeBeanDiscovery beforeBeanDiscoveryEvent) {
beforeBeanDiscoveryEvent.addInterceptorBinding(CachePut.class);
beforeBeanDiscoveryEvent.addInterceptorBinding(CacheResult.class);
beforeBeanDiscoveryEvent.addInterceptorBinding(CacheRemove.class);
beforeBeanDiscoveryEvent.addInterceptorBinding(CacheRemoveAll.class);
}

}
so InterceptorBinding is actually added....Why it's not there in the first place?

The code from DS is the following:
Class<? extends Annotation> annotationType = annotation.annotationType();

if (annotationType.isAnnotationPresent(InterceptorBinding.class))

how can we look at the changes made by the beforeBeanDiscoveryEvent.addInterceptorBinding?
More detail: https://github.com/apache/deltaspike/blob/master/deltaspike/modules/proxy/api/src/main/java/org/apache/deltaspike/proxy/spi/invocation/DeltaSpikeProxyInterceptorLookup.java#L90

if (beanManager.isInterceptorBinding(annotationType))  <-- should do the trick...nevetheless there's still some issues with the DS partial bean integration.

Fixed on https://issues.apache.org/jira/browse/DELTASPIKE-1339.


Use objcopy instead of ld to generate rom_head.bin

This avoids the .comment section being also added by ld. This change
should increase compatibility with other GCC toolchains in which ld does
not add the .comment section, and makes sega.s file easier to
understand, because the "esoteric" 16-byte skip from the .incbin
rom_head.bin can now be removed.

Thanks for the PR !


Fix/pg notifications

it says pgNotifications on the title but files changed not correct. Please use proper branching for PRs


allow static linking

The following patch file allows static linking of libcapstone
capstoneapi.zip

Applied, thank you.


Support Custom Search Parameter in x-fhir-query

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2554
Description
Add support to consider custom search parameters during x-fhir-query execution.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: (Bug fix | Feature)
Checklist

[x] I have read and acknowledged the Code of conduct.
[x] I have read the Contributing page.
[x] I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
[x] I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
[x] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
[x] I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
[x] I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

Hi @MJ1998,
I have made the changes. Now use SearchParamDefinitionsProvider instead of FhirEngineConfiguration. Thanks for the suggestion.

@MJ1998, Could you please check now?

Hi @jingtang10, If it is ok, then could you please initiate the merge? Thanks 😊

Hi @MJ1998,
I didn't see any Kokoro Build details. Isn't it finished yet? Also, I didn't see any label about kokoro run. May be I missed something.

Hi @MJ1998,
Any update?

The kokoro label can only be added by core team with permissions.
Currently the kokoro seems to be running. Does it always run? Or does it fail? Can you tag me once the kokoro provides a status?

Hi @jingtang10,
Could you please start the Kokoro build. I didn't see any status about kokoro build. Thanks

The kokoro label can only be added by core team with permissions.
Currently the kokoro seems to be running. Does it always run? Or does it fail? Can you tag me once the kokoro provides a status?

@MJ1998,
I didn't see any details about kokoro build. Even I don't know whether kokoro is already run or not. I didn't get any status about success or failure. In my last ticket, I got email when kokoro failed and successed. Hence it seems to me that kokoro isn't started yet.

Hi @MJ1998,
Here is the Kokoro  detail. In the device test, one case failed, which is unrelated to my changes. Could you please check and guide me so that I can resolve it. Thanks
MediumPhone.arm-33-en_US-portrait com.google.android.fhir.datacapture.test.QuestionnaireUiEspressoTest#clearAllAnswers_shouldClearDraftAnswer
androidx.test.espresso.base.AssertionErrorHandler$AssertionFailedWithCauseError: expected to be empty

Hey how did you get the failed test case? These seem to pass for me locally and strangely the kokoro is never-ending
@asad-zaman

Hi @MJ1998,
Thanks for your quick response. Here is the detail of the kokoro run. Please check.
Go to the above link and navigate to the path according below screenshot and check the file named test_result_1.xml.

FYI, In my local machine, the above mentioned test case also passed.

This is merged @asad-zaman. Thanks for the PR and fixing custom search parameter in x-fhir-query.


Move Covalent Tools Repo into Covalent

Move Covalent Tools Repo into Covalent

Steven Ov to Review

Fixed in #1512 & https://github.com/Teradata/covalent-tools/pull/16


Include reference to Django's {{ block.super }}

@DanielSwain  - thanks again! merged in via 749d017


hot reloading for twig files not working?

I just tried a fresh install of this, when I update the base.html.twig or any other twig files, it doesn't update, is this possible?
So when I save a twig file, it reloads the current page (not a hot reload, just like live reload).
Does it require any specific configuration?

No, sadly it does not work this way.
maba:webpack:dev-server command scans twig files in configured directories and searches for webpack_asset function usages. It builds list of entry points and passes that to webpack configuration file. Then it starts webpack-dev-server.
It sleeps for a second and repeats the process. If entry points are changed, it restarts the process.
Hot reloading is enabled only in the webpack-dev-server itself, as it generates javascript file that does this hot-reloading. It is unaware of changes inside twig files.
So, we have some different situations:

changed config file. For example, new bundle added in AppKernel. Or new alias via config.yml file. This is totally ignored by maba:webpack:dev-server as PHP command is already loaded with previous configuration. You must manually restart PHP command to see the changes;
twig template changed. For example, text in it was changed, some tags added etc. This is not a subject to hot-reload, you must refresh page to see the changes;
twig template changed so that new asset is loaded via webpack_asset function. This initiates reloading of configuration file and restarting of webpack-dev-server process. This can take some time. While assets are compiling, you'll see 500 error if you reload the page. After assets are compiled, you must still refresh the page manually;
any asset itself is changed (js, css files). As this is handled by webpack-dev-server, this is a subject to hot-reload. Keep in mind that only some javascript files are compatible with hot-reload. For example, if you define global variable in your javascript file, hot-reload will only change the variable itself. All the references that were made earlier will not be automatically changed. Still, hot-reload should always work well with css files.

Great, thanks for confirming, I had a feeling it wouldn't work like this, but was in 2 minds as the docs state:

Watches twig templates for changes, updates entry points and restarts webpack-dev-server if webpack configuration changes.

Based on How to watch twig files with Webpack and Symfony? I did try proposed solution using watchFile-webpack-plugin. When I change twig file, webpack compilation is triggered and browser is notified. Unfortunately browser is not reloaded because of [WDS] Nothing changed..
Navigated to http://<IP_ADDRESS>:8000/
client:37 [WDS] App updated. Recompiling...
client:37 [WDS] Nothing changed.
client:37 [WDS] App updated. Recompiling...
client:37 [WDS] Nothing changed.
client:37 [WDS] App updated. Recompiling...

Is there any chance to force browser reload in this case?

What exactly do you change? Do you add new entry point, change existing one, remove one?
Could you make separate issue for this if needed?
I don't think that watchFile-webpack-plugin would be a good option with this bundle in general, as it would watch all twig files for all assets, as I imagine. Generally there could be many entry points and many twig templates, so changing one of them should not require regeneration of all entry points. Furthermore, bundle itself must process twig files to update webpack configuration as needed.


vscode: Reconnect in the background up to 5 seconds

Based on the previous commits by @mgmachado but simplified.
I also changed the threshold to error after a single attempt as the
connection has likely been borked and the user should be in the know if
they couldn't reconnect after 5 seconds.
Closes #1791

Fixed!

LGTM. Much simpler!


Docker support for running the server

Hi, I've looked into slack alternatives lately, and most of them had support for running the chat server with docker.
This feature is important to help individuals and companies check zulip out, and running it on production, as sometimes dedicating a server or raising another VM in it can be costly, whereas the cost of running another docker container is much smaller.

You can do this today with https://github.com/galexrt/docker-zulip (we should do the work to integrate that as part of the core project, though).

@timabbott, another question i've not thought about - does zulip have built-in integration for Active Directory?

Yes.  You can use the LDAP authentication backend with Active Directory.

Good. I hope I'll have time to test it out soon.

Closing this, as we now are prepared to provide official support for https://github.com/galexrt/docker-zulip (I just rewrote the package's documentation).


Table manipulation primaries

While tables are first class values in elvish, it is not yet possible to manipulate them. To break it down, it should be possible to add, remove and modify elements of a table.
We can either go the conventional way of mutable data structures or adopt immutable data structures (#11.)

It is now possible to assign to list and map elements. Tracking del support in #79.


Auto discover AA account if executen in AA

Added logic for autodiscover of AA account, and made ResourceGroupName and AutomationAccountName optional input parameter. So the logic still can be run from outside AA.

@mortenlerudjordet Thank you, this PR looked like a good idea to me. I would just ask you to do it after PR#6 is merged, to make sure Az modules are supported and not mixed with AzureRM.

@AnatoliB : I modified Update-ModulesInAutomationToLatestVersion in the AA team github instead, and split it into two parts one for importing modules from PSGallery like Az, and one for updating either all modules or only the Azure ones. Liked the recursion of the module and did the work on that instead.
https://github.com/mortenlerudjordet/runbooks/blob/Dev/Utility/ARM/Import-PSGalleryModuleToAA.ps1
https://github.com/mortenlerudjordet/runbooks/blob/Dev/Utility/ARM/Update-PSGalleryModulesInAA.ps1


[proposal] Allow Date type in autoCreatedAt/autoUpdatedAt with the 'ref' type

Until the Sails1 version, the mongo adapter stored the createdAt/updatedAt values as Date types. So to keep everything working we need to allow the same Date type in the v1 of Sails.
With this PR using the 'ref' type will allow auto generate dates with the Date type:
  attributes: {
    createdAt: { type: 'ref', autoCreatedAt: true },
    updatedAt: { type: 'ref', autoUpdatedAt: true },
    id: { type: 'string', columnName: '_id' }
  }

This PR goes with another PR in waterline-schema: https://github.com/balderdashy/waterline-schema/pull/90
Plus, we need to document this behavior that all the previous sails-mongo users will need (if they don't use the migrate: 'alter' option).

@mikermcneil This looks good to me -- allows backwards compatibility w/ earlier versions of ORM+sails-mongo that saved createdAt and updatedAt as native JS date objects, and would let postgresql and mysql users use datetime columns (w/ small updates to sails-postgresql and sails-mysql).

+100

Probably it would help if that snippet of code is added into:
https://github.com/balderdashy/sails-generate/blob/f595e7787aa92805125950b8c68a2793a90468e5/lib/core-generators/new/templates/config/models.js#L53-L59


fix VlcMediaPlayer.Dispose() Memory leak

fix bug  VlcMediaPlayer.Dispose() may cause Memory leak

Please don't mix unrelated things in your PR.
A little tip: when doing a PR, you can create a branch, like feature/dispose-leak where you put only the commits related to that PR, because when you push other commits to the same branch, they are added to the current pull request.
That being said, thanks for your contribution, I will try your first commit and try to merge that.


Remove old documentation about the new C++ plugins

Context

Fixes https://github.com/gradle/gradle-native-private/issues/257
Gradle Core Team Checklist

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation
[ ] Recognize contributor in release notes

Merging early, the only thing that we may need to look in more details is the redirect I wrote to move users from the old documentation URL to the new documentation, just in case external reference exists.


chore: add cra5, ts integ tests; run integ tests on prs as well

Description of changes

Added CRA5, TS, vue, next integ tests

Issue #, if available

Description of how you validated changes
Checklist

[x] PR description included
[ ] yarn test passes
[ ] Tests are [changed or added]
[ ] Relevant documentation is changed or added (and PR referenced)

Codecov Report

Merging #153 (60b09d5) into main (0312926) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #153   +/-   ##
=======================================
  Coverage   62.87%   62.87%
=======================================
  Files          11       11
  Lines         431      431
  Branches       94      112   +18
=======================================
  Hits          271      271
+ Misses        160      159    -1
- Partials        0        1    +1

Impacted Files
Coverage Δ

src/AmplifyMapLibreRequest.ts
64.70% <0.00%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Update ANCM versions

Propagate changes from https://github.com/dotnet/dotnet-core-website/pull/830/

We are carrying these edits for the big push on 12/4 so we can probably skip this PR


Cors bug fix

The cors config was not being parsed for json !

Readability is improved. The only thing I'm not sure about is the name getJSONFromBufferWithError; I was trying to figure out where the error was happening that leads us to this method, but it looks like it's more to do with the catch block with error logging. Also the comment "Converts a Buffer to JSON but prints out a friendly log error message saying what file error'd" makes it sound like an error is expected. Is that the case?

good feedback. I've made changes


Extend documentation to guide users through Westeros tutorials

This PR extends the documentation to guide users through Westeros tutorials.
Closes #475.
How to review

Read the diff and note that the CI checks all pass.
Build the documentation and look the tutorial page.
Look at the rendered baseline tutorial under section "Recommended order for the tutorials".

PR checklist

[x] Continuous integration checks all ✅
[x] ~Add, expand, or~ update documentation.
[x] Update release notes.

Thank you for your review @OFR-IIASA, I implemented all your suggestions.

Thank you @khaeru for jumping in - looks way better now!

Nothing further from my side; please merge if ready.


Improvements on gh-pages as per #34

This pull request is intended for branch gh-pages, not for branch master.
Unluckily, I cannot see the final result until pages are published on gh-pages.

You can see the final result by installing jekyll and running ./jekyll-serve.sh

Thank you. I installed Jekyll and solved a pair of issues.
In the header, I have added two links to demo.html and index.html just as it were a menu.

@luca-vercelli, index.html is created automatically from the readme file. So they're essentially the same thing.
Also that is why we cannot delete it or rename the demo file into index.html.

I'm not sure of what to do yet...
The two buttons "README" and "Demos" should go together. If I remove the first, I should remove the latter too. It's meaningless a menu with 1 entry only.
If you want I can remove them both.

@luca-vercelli, currently there are 2 menu items:

View on Github (same as readme)
Download

You added 2 more: README and Demo
I'm saying, since View On Github is already there and it's same as README, no need to add it. So the final menu items can be:

Demo
View on Github
Download


Deny unknown fields

Starting with hayagriva I was confused why some fields (eg. translator) that are variables in CSL wouldn't do anything when added to my entries. The answer of course is to RTFM (which I did eventually and that's where I learned about affiliated) but an error message telling me the field name was invalid would have spared my sanity quite a bit.
That's why I'm asking whether it would make sense to add #[serde(deny_unknown_fields)] to the NakedEntry struct that is used for deserialization.
I realize this could make it more annoying when using a yaml file for a newer version with an old version of hayagriva, but I for one would like to know if some information is getting omitted. The other problem I can think of is people storing additional information in those files that isn't supposed to be read by hayagriva, is that something someone does?

Yes, that would definitely work! As long as it's getting displayed somewhere


error running keybase status

i get the following error
thesheriff@CTCLP13:~$ keybase status
▶ INFO Forking background server with pid=31792
▶ ERROR dial unix /home/thesheriff/.config/keybase/keybased.sock: setsockopt: invalid argument
my log id: 70b6d5cb1459f737557a051c

cc: @oconnor663 ?

Hmm, could be unrelated, but I notice your socket file is at ~/.config/keybase/keybased.sock instead of /run/user/.../keybase/.... Have you done something interesting with XDG_RUNTIME_DIR or something like that? Could you give me the output of ls -lh /home/thesheriff/.config/keybase/keybased.sock and file /home/thesheriff/.config/keybase/keybased.sock please?

@oconnor663 I have the same issue but there is no keybased.sock file in ~/.config/keybase

@gglanzani could you run keybase log send for us please? What distro / desktop are you running?

@oconnor663 I should probably mention that I'm using Bash on Windows, and that seems to be a general issue with the go library. See https://github.com/Microsoft/BashOnWindows/issues/832
This issue seems to have been fixed in the not yet released update to Bash on Windows. Unfortunately I cannot yet test it. I think it's probably safe to close it here.
I can still send the log though!

I am also running windows bash, and I have the same problem.

Got it, thanks for clarifying. Yeah we haven't tested bash-on-windows at all. @gglanzani, let me know if you get any interesting results after MS releases that fix.

(Unless you've been testing it, @zanderz?)

@oconnor663 @averagejoey2000 @maxtaco @the4ndy This is fixed in the latest Slow ring release. I'm afraid you'll have to wait a bit to get that outside Insiders previews.


.Net: Enable package compatibility validation

Motivation and Context

Resolves: https://github.com/microsoft/semantic-kernel/issues/4294
This PR contains changes to enable package compatibility validation for packages without alpha or preview prefix. This will allow to catch breaking changes in public API earlier and resolve them before the release.
Verification:
After following test commit with new optional parameter - https://github.com/microsoft/semantic-kernel/pull/4438/commits/dd8745c14701b99453d12cadef79bd9bd97c6c57, PR build pipeline failed with following error:
https://github.com/microsoft/semantic-kernel/actions/runs/7350765480/job/20012998030?pr=4438

Contribution Checklist

[x] The code builds clean without any errors or warnings
[x] The PR follows the SK Contribution Guidelines and the pre-submission formatting script raises no violations
[x] All unit tests pass, and I have added new tests where possible
[x] I didn't break anyone :smile:

@stephentoub For compatibility validation I suppressed following errors, let me know if it's okay:

CP0003 - This error occurs due to difference in assemblies PublicKey. We set PublicKey only for Publish configuration in release pipeline, while we don't have PublicKey for Debug or Release configurations (and I'm not sure we need them when packing locally or in PR pipeline). So, I suppressed this rule for Debug and Release configurations, while it will be applied for Publish configuration in our release pipeline to check if assembly attributes are the same.
CP1002 - This error occurs only for .NET 8 SDK, when packing SemanticKernel.Core project it wants to find referenced project dll (Microsoft.SemanticKernel.Abstractions.dll) which doesn't exist. (Error can be found here: https://github.com/microsoft/semantic-kernel/actions/runs/7349585442/job/20009783098). Documentation says that it's possible to provide reference with <PackageValidationReferencePath Include="<path>" TargetFramework="<tfm>" />, but I'm not sure this reference exists, since we pack each project separately, and nupkg of each project doesn't contain dll for referenced project. Please let me know if I'm missing something.

Thanks!

@stephentoub For compatibility validation I suppressed following errors, let me know if it's okay:

CP0003 - This error occurs due to difference in assemblies PublicKey. We set PublicKey only for Publish configuration in release pipeline, while we don't have PublicKey for Debug or Release configurations (and I'm not sure we need them when packing locally or in PR pipeline). So, I suppressed this rule for Debug and Release configurations, while it will be applied for Publish configuration in our release pipeline to check if assembly attributes are the same.
CP1002 - This error occurs only for .NET 8 SDK, when packing SemanticKernel.Core project it wants to find referenced project dll (Microsoft.SemanticKernel.Abstractions.dll) which doesn't exist. (Error can be found here: https://github.com/microsoft/semantic-kernel/actions/runs/7349585442/job/20009783098). Documentation says that it's possible to provide reference with <PackageValidationReferencePath Include="<path>" TargetFramework="<tfm>" />, but I'm not sure this reference exists, since we pack each project separately, and nupkg of each project doesn't contain dll for referenced project. Please let me know if I'm missing something.

Thanks!

@viktorhofer, can you assist @dmytrostruk here? We're trying to get package validation set up for Semantic Kernel.

I'm out till Monday. cc @ericstj

CP0003 ... we don't have PublicKey for Debug or Release configuration

Seems odd, if it were me I'd just have Debug and Release use public signing with the same public key.  That minimizes the differences between configurations that run tests.  I guess you might have another reason to not sign, but if not consider using public signing.

CP1002

Interesting - I wouldn't expect that to happen.  It should be bringing the reference from ResolveReferences.  Perhaps you're packing without building so ResolveReferences doesn't run?  Let me pull this down and try.  I might be able to provide a workaround.

@ericstj

Perhaps you're packing without building so ResolveReferences doesn't run?

Actually, we pack after build by using <GeneratePackageOnBuild>true</GeneratePackageOnBuild>, so I'm not sure it's a root cause.

Let me pull this down and try. I might be able to provide a workaround.

Thank you!

Yep, I got the repro and I see the reference being passed in.  Something fishy happening where the lookup isn't working.  I'll debug a bit then report the findings.
Suppressing is OK as a workaround.  Running API Compat with references can give you more coverage; for example, when a type is forwarded outside the assembly we can compare the target type in the new assembly with the previous type.

Yep, I got the repro and I see the reference being passed in. Something fishy happening where the lookup isn't working. I'll debug a bit then report the findings.
Suppressing is OK as a workaround. Running API Compat with references can give you more coverage; for example, when a type is forwarded outside the assembly we can compare the target type in the new assembly with the previous type.

@ericstj Thanks for letting me know! For CP0003 I will check public signing. I will temporary suppress CP1002 and bring it back when the issue is resolved.

These are actually caused by the same problem.  What's happening is when loading the baseline assembly from your shipping nuget package we load Microsoft.SemanticKernel.Core, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=f300afd708cefcd3 and try to load its reference Microsoft.SemanticKernel.Abstractions, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=f300afd708cefcd3 using the right side (latest built) references.
Since your latest build is omitting the public key token, it doesn't satisfy the reference, thus the load failure.  The compiler is doing the loading for us, so we don't really have anything we can do to change this behavior in API compat.
The best way to solve both problems is using public signing.  That way you don't fiddle with the identity of your assembly.

Here's a change that fixes both warnings by enabling public-signing.  It builds for me but I haven't tested anything.  Use if you like: https://github.com/ericstj/semantic-kernel/commit/821066d9021e0ace9e8a9c55265f3da83eca957c

Here's a change that fixes both warnings by enabling public-signing. It builds for me but I haven't tested anything. Use if you like: ericstj@821066d

@ericstj Thanks a lot!


i18n: ultima KO translations

Sorry for misc, I didn't notice that ultima-un is arrived. XD

If it's helpful, you can always run npm run util -- findTranslations -l=ko -f=ui to find any translations that are missing.

That's what I looking for, I'll try it later. Thank you!


Option to mark events on calendar.

Is your feature request related to a problem? Please describe.
I am looking to use the material-ui-picker as a calendar widget and put markers on the Days.
Current example of customizing the Day component using renderDay option does work.
The issue is how to modify the dayComponent text color.
Its possible to mark badge(dots, icons) but how to modify the textcolor of Day based on condition.
Describe the solution you'd like
An option to mark events will be good.
Can someone point me how can I customize the Day component to modify text Color.
Reference Image

Found the solution, read somewhere in the docs that clone element can be used.
Pasting the code-snipet here for reference.
`renderDay={(day, selectedDate, isInCurrentMonth, dayComponent) => {
const isDeadline = isInCurrentMonth && includes(endDates, moment(day).format('YYYY-MM-DD'));
const isEvent = isInCurrentMonth && includes(eventDates, moment(day).format('YYYY-MM-DD'));
      let CustomDay = <span
        className={classNames(isDeadline && classes.deadline, isEvent && classes.event)}>
        {moment(day).format('D')}
        </span>
      // Here create a clone of the dayComponent with custom children component created above.
      // With the applied changes and styles.
      let element = React.cloneElement(dayComponent, [], CustomDay)
      return <div>{element}</div>
    }}`

I discovered that next version of the library has  component which can be customized and used.
I am using 3.9.0 currently.

@abhi11verma Thanks for sharing.

@abhi11verma can you point us to this new component in @next? I'de love to use it

@abhi11verma In case you would like to contribute, I think that your case would make a great new example in the documentation 👌

@abhi11verma In case you would like to contribute, I think that your case would make a great new example in the documentation 👌

@oliviertassinari  Would love to contribute. Could you point me in the right direction where to start from?

There is an example, even 2 with custom day renderers


fixes #33 Escape chars to prevent xss

I have added two functions :
escapeHtmlTags(html) to prevent from opening html tags leading to xss
escapeAttributeQuots(attribute) Unsued for now, it prevent from attribute injection
Feel free to change the names as they looks long, the usage of the function is only during the display

@yasinS Can you check if this is alright? Thanks

@bashz Thanks for the PR and commit! This is perfect – none of the supplied payloads are executed in the site context now.
cc @pvdsp


Update initial empty pipeline json to be valid

Currently it is missing the app_data.properties fields which
is normally added in an initial save. The contents are still added
at save, since that is a hook in Elyra, but properties is now set
to an empty dict initially.
Fixes https://github.com/elyra-ai/elyra/issues/2066
Developer's Certificate of Origin 1.1
   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Codecov Report

Merging #157 (8b35183) into master (d91f7df) will decrease coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #157      +/-   ##
==========================================
- Coverage   78.80%   78.65%   -0.15%
==========================================
  Files          41       41
  Lines        1434     1438       +4
  Branches      341      342       +1
==========================================
+ Hits         1130     1131       +1
- Misses        226      228       +2
- Partials       78       79       +1

Impacted Files
Coverage Δ

...es/pipeline-editor/src/PipelineController/index.ts
93.84% <ø> (-0.37%)
:arrow_down:

...kages/pipeline-editor/src/PipelineEditor/index.tsx
43.57% <0.00%> (-0.41%)
:arrow_down:

...e-editor/src/properties-panels/PropertiesPanel.tsx
78.37% <0.00%> (ø)

...e-editor/src/properties-panels/properties-utils.ts
100.00% <0.00%> (ø)

...itor/src/CustomFormControls/StringArrayControl.tsx
93.38% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d91f7df...8b35183. Read the comment docs.

Can't review due to https://github.com/elyra-ai/pipeline-editor/issues/158

need to update instructions on how to build and test this PR

@akchinSTC there's no special build steps for this, as for testing, as @ptitzler mentioned, there's no longer a specific test-case for this, it's just future-proofing

Don't we need to populate the pipeline type when the pipeline gets created?
Here is a diff between an empty pipeline vs saved one.

@lresende the reason we can't set the contents of properties here is because those are dynamically set in the save hook in elyra. As far as pipeline-editor is concerned there's no way to call that hook. If we want we could add another hook on elyra's side to call the save hook on open, but I felt that wasn't the best solution so instead I just did this

@ajbozarth Using 3.0.1/master these empty pipeline files are produced if one performs the following steps:

click [generic|kfp|aa] pipeline editor tile in launcher
close pipeline VPE

Note that [primary-pipeline]app_data.runtime is set for airflow and kfp but not generic pipelines.

Note that [primary-pipeline]app_data.runtime is set for airflow and kfp but not generic pipelines.

@ajbozarth is this is the case, can we make it consistent?

We can do it if we want, but iirc we were intentionally not doing that (ie leaving it unset for generic). I can't remember the reason, but I do remember discussion about it and the decision.

Perhaps because legacy pipelines didn't set this property?


Update google-apps-tutorial.md

Connector got renamed to "Google Cloud / G Suite Connector by Microsoft"

@j0eyv : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@j0eyv, could you please confirm, do we need to replace/update the name in complete document?
Google Cloud (G Suite) Connector -> Google Cloud / G Suite Connector by Microsoft

Updated,
#please-close


Fix bug/mediator restarts

Codecov Report

Merging #411 (5279196) into main (600eccf) will decrease coverage by 0.16%.
The diff coverage is 43.47%.

@@            Coverage Diff             @@
##             main     #411      +/-   ##
==========================================
- Coverage   86.62%   86.46%   -0.17%
==========================================
  Files         248      248
  Lines        5198     5217      +19
  Branches      827      834       +7
==========================================
+ Hits         4503     4511       +8
- Misses        695      706      +11

Impacted Files
Coverage Δ

packages/core/src/agent/Agent.ts
86.08% <43.47%> (-10.79%)
:arrow_down:

.../core/src/modules/connections/ConnectionsModule.ts
76.62% <0.00%> (+2.59%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 600eccf...5279196. Read the comment docs.


Fix IME key event being erased in macOS

This PR fixes IME input in macOS, especially Korean IME which calls insertText and setMarkedText at the same time.
Before:
https://github.com/godotengine/godot/assets/30334834/5af8356c-782a-4180-884f-4374c069a394
After:
https://github.com/godotengine/godot/assets/30334834/f08fb0d6-92ea-4307-b5fc-34a143cb4532
Bugsquad edit:

Addresses macOS native part of #85597

Thanks! And congrats for your first merged Godot contribution :tada:

Cherry-picked for 4.2.1.


Requester pays with --mount

I'm trying to use dsub's --mount parameter to mount a read-only bucket hosted on GCP. This bucket is not owned by me and the owner has requester pays set. I've provided --user-project, which I believe tells dsub to use this parameter and billable project with all relevant google calls. Is this information not being provided to gcsfuse?
My command (some parameters omitted for clarity):
dsub \
        --provider google-cls-v2 \
        --user-project "${PROJECT}"\
        --project "${PROJECT}"\
  ...
        --mount FILES=gs://fc-aou-datasets-controlled

Output seems to indicate that the billable project (-u) isn't provided to gcsfuse.
Opening GCS connection...
Using mount point: /mnt/data/mount/gs/fc-aou-datasets-controlled

WARNING: gcsfuse invoked as root. This will cause all files to be owned by
root. If this is not what you intended, invoke gcsfuse as the user that will
be interacting with the file system.

Opening bucket...
Mounting file system...
WARNING, bucket doesn't appear to work:  googleapi: Error 400: Bucket is a requester pays bucket but no user project provided., required

Thanks for your attention

Thanks for reporting this @ccario83 !
Yes, it looks like dsub needs to be updated to pass the gcsfuse --billing-project flag when the dsub --user-project flag has been provided. The change would be here:
      actions_to_add.extend([
          google_v2_pipelines.build_action(
              name='mount-{}'.format(bucket),
              enable_fuse=True,
              run_in_background=True,
              image_uri=_GCSFUSE_IMAGE,
              mounts=[mnt_datadisk],
              commands=[
                  '--implicit-dirs', '--foreground', '-o ro', bucket,
                  os.path.join(_DATA_MOUNT_POINT, mount_path)
              ]),

and would look something like:
      mount_command = ['--billing-project', user_project] if user_project else []
      mount_command.extend([
        '--implicit-dirs', '--foreground', '-o ro', bucket,
        os.path.join(_DATA_MOUNT_POINT, mount_path)
      ])

      actions_to_add.extend([
          google_v2_pipelines.build_action(
              name='mount-{}'.format(bucket),
              enable_fuse=True,
              run_in_background=True,
              image_uri=_GCSFUSE_IMAGE,
              mounts=[mnt_datadisk],
              commands=mount_command),

We'll look to get that into the next release.

Awesome, thank you for the support!

Just to add to this, I manually inserted a "--billing-project" flag with my project ID hardcoded in into that section of the dsub code and was able to successfully mount the same bucket (fc-aou-datasets-controlled) to a dsub VM. However, trying to list the contents of the directory leads to an Input/Output error. I'm assuming it's permissions related, but I'm not really sure how to proceed.
2023-11-13 20:18:20 INFO: mkdir -m 777 -p /mnt/data/mount/gs/fc-aou-datasets-controlled
Opening GCS connection...
Using mount point: /mnt/data/mount/gs/fc-aou-datasets-controlled
Opening bucket...

WARNING: gcsfuse invoked as root. This will cause all files to be owned by
root. If this is not what you intended, invoke gcsfuse as the user that will
be interacting with the file system.

Mounting file system...
File system has been successfully mounted.
ls: reading directory /mnt/data/mount/gs/fc-aou-datasets-controlled: Input/output error

Thanks for the report @KarlKeat.
I think that you are correct that there's something permissions related, though I too am not sure quite what it might be. I've tested the proposed change myself on a requester pays bucket (all outside of the AoU environment), and access seems to work fine.
The one thing I was going to recommend was in your --script or --command to test:

gsutil ls gs://fc-aou-datasets-controlled, and
gsutil cp gs://fc-aou-datasets-controlled/<some-file> .

I'd expect gsutil to be better at surfacing the underlying permissions issues than gcsfuse.
But do you have gsutil in your --image?
Lastly, I can suggest, from this issue adding the --debug_fuse flag in the hope of surfacing more detailed errors.

Hi @ccario83 and @KarlKeat !
We have released 0.4.10, which includes support for passing the user project to mounted buckets.
When you get the chance, please confirm if it resolves your issues.
Thanks!


Rename master to main branch

Generic Issue
The new convention for GitHub repositories is to move from master to main (https://www.techrepublic.com/article/github-to-replace-master-with-main-starting-in-october-what-developers-need-to-know/). The cookiecutter workflows expect a main branch as well.
There hasn't been much action going on here, so given that fact, I propose that once the Dependabot Pull Requests have been merged, we rename the trunk to main.
@RondeauG @sebastienlanglois any opposition?

Pas de problème pour moi !

Sounds good to me!

Done.


Create enum for socket events

Problem
We need a set of events that we can pass up to the application.
Solution
Probably an enum?
Events
At a minimum, we need:

Client Connected
Client Disconnected (only for TCP clients)
Client Timed Out
Client Reconnected (this one is a maybe, see below)
Client Connection Quality Changed

Reconnected Event
The only way we have of identifying a remote user at layer 3 is via the remote IP and remote port. There are cases where these may change, but it is the same client. We'll see this frequently when people are behind NAT, for example.
If we do get a reconnection from the same ip:port combo, we can either treat that as a reconnection and assume it is the same remote client, or we treat it as a brand new connection.
Ultimately, the application will need to embed a unique identifier for their clients in the payload part of the packets.

@fhaynes I believe there should also be a MessageRecieved event so that the user of the library has one place to handle ALL events that come through the socket.


Global_avg_pool2d TTNN op fails with low PCC error [Grayskull and Wormhole]

Describe the bug
Global_avg_pool2d TTNN operation breaks with low PCC error in some test cases, for both, Grayskull and Wormhole chips.
To Reproduce
Steps to reproduce the behavior for both chips, GS and WH:

Checkout main branch
Run unit test test_global_avg_pool2d.py  using this command:
pytest tests/ttnn/python_api_testing/non_working_unit_tests/grayskull/test_global_avg_pool2d.py

Expected behavior
There are test cases presented in the unit tests pytest tests/ttnn/python_api_testing/non_working_unit_tests/grayskull/test_global_avg_pool2d.py and they all are expected to fail with low PCC error.
Getting Additional info for the operation under test and its behavior
To get additional information and results for different combinations of input shapes, types, layouts and memory configs for which this operation was tested you can also run locally sweeps for ttnn.global_avg_pool2d and check the results. To do this you should:

Follow the Getting Started page to setup the repo, environment variables and python-env
Activate source build/python_env/bin/activate
Run sweeps by using python tests/tt_eager/python_api_testing/sweep_tests/run_pytorch_test.py -i tests/ttnn/python_api_testing/sweep_tests/test_configs/ci_sweep_tests_broken/grayskull/ttnn_global_avg_pool2d_test.yaml -o /home/ubuntu/tt-metal/ttnn-test-sweeps/global_avg_pool_2d
After the run is completed all test sweeps results should be available inside specified output directory (in this case ./result-sweeps). There you will find global_avg_pool2d_sweep.csv which holds all executed sweeps, among which you can also find the ones that failed and were recreated by the unit test, which you can get by searching unique data_seed field.

i set as p2 for now, and assign to Nick to triage.


Microsoft Teams Video Call Blur issue in browser

Describe the bug
When i join in a team's meeting from Browser (Microsoft edge or Google Chrome) the teams meeting is shaking and the quality of video decreases and the faces of people whose webcam is working will be shaking continuously.
To Reproduce
Steps to reproduce the behavior:

Go to 'teams.microsoft.com'
Click on 'join a meeting'
Scroll down to '..'
See error "Effects the presentation we see"

Expected behavior
when i try to join the meeting from team's application there is no issue when i try to join with browser then the issue starts and when we change tabs and come back to the ongoing meeting the whole presentation screen becomes stuck (Only that page and not the browser or laptop.) and after two seconds it become normal.
Screenshots
https://user-images.githubusercontent.com/75376880/197006164-34b17368-ad90-4288-ad67-579f081a8532.mp4
Desktop (please complete the following information):

Device: [Asus Tuf Gaming F15]
OS: [Windows 11 22H2]
Browser [Chrome and edge]
Version [22]

Additional context
And it increases when there are more people with their video working

🎓 Add a tag to this issue for your current education role: student, Student Ambassador or educator.
Student Ambassador, student

Thanks for sharing this feedback. Please submit your feedback here to share directly with the Microsoft Teams team.


BandPass filter help

Hey there! I'm trying to use your bandpass filter to filter an array of values (I'm trying to do heart beat detection). I'm new to signal processing and I was wondering if you could explain how to get the coefficients within your code. I see they are being called in this example on stackoverflow: https://stackoverflow.com/questions/10604690/noise-distortion-after-doing-filters-with-vdsp-deq22-biquad-iir-filter/10608609#10608609. I'm trying to create a bandpass filter between 0.667 Hz and 4.167 Hz. I have a sample rate of 30 frames per second. If you have any tips or can confirm if I could use your framework to do this that would be helpful!  Thank you!
// import Novocaine.h and NVDSP.h
#import "NVDSP/Filter/NVBandpassFilter.h"
NVBandpassFilter *BPF = [[NVBandpassFilter alloc] initWithSamplingRate:audioManager.samplingRate];
BPF.centerFrequency = 2500.0f;
BPF.Q = 0.9f;
[BPF filterData:data numFrames:numFrames numChannels:numChannels];

Hi, @ksuhr1 did you find any solution, i have also applied band pass filter to my incoming data, but not able to remove noise.


LOOP-1484: Correction ranges in therapy acceptance flow

This PR:

Adds delegate to ServiceDelegate to support saving settings from a service
Adds reusable view for an 'instructional' screen
Creates instructional screen for correction ranges
Configures CorrectionRangeScheduleEditor (and child component views) to support using it either modally or in the therapy flow

A bonus of this is that now the info icon in the editor displays instructional content when used in either configuration
In the therapy flow:

Adds instructional content on how to use the editor that is dismissed upon tapping the screen
Keeps track of if the correction range is different from that in the prescription, which is used by the parent view to configure the 'save' button appropriately

Oops, missed that userHasEdited appears to be unused now and can be cleaned up.

Oops, missed that userHasEdited appears to be unused now and can be cleaned up.

Gotcha, I'll clean that up :)


Optional link to Starkscan (or other explorer in the command output)

After invoking a transaction from the console, I would like to have the transaction hash to be printed along with the URL like:
Invoke transaction: https://testnet.starkscan.co/tx/0x019dc45b534fecbf7a285a7f768a0f54d7fc32a85a1ee185d1d6a667cd2bb1a0
So I can directly navigate to the browser and inspect the transaction. This config could be provided via an env variable.

Is this up for grab? Can I jump on this @kwkr


Open menu for set time automatically

you can open menu for setting time automatically after setting date

Resolved in f4dd117d337e8afa4c7c543159a4120c41ab3eb0.


fix: UI_REACT: UI should indicate when containers are collections

Fixes: #1747

@jpav - the code looks fine but don't we have an icon for arrays/complex containers in the angular UI??  We should try to match that if we can

FYI, this broke stories in storybook. Also, since "collection" is an Atlasmap specific concern, it would have been better not to change the models and components inside the CanvasView. I'll try to address this in a future PR.

@riccardo-forina Is there some way we can get the stories pulled into the regular build process then? Nothing indicated there was a problem. Also, not sure what you mean by the collection concern. It's certainly important for the user to know whether fields are collections are not, so not sure how to accomplish showing them that distinction otherwise. I'm probably just missing your meaning though. Could you expound a bit?

@riccardo-forina Is there some way we can get the stories pulled into the regular build process then? Nothing indicated there was a problem.

Yeah, we should improve that letting CI build also the storybooks and run the tests. I'll do that today.

Also, not sure what you mean by the collection concern. It's certainly important for the user to know whether fields are collections are not, so not sure how to accomplish showing them that distinction otherwise. I'm probably just missing your meaning though. Could you expound a bit?

All the components that are part of the Canvas and CanvasView folders are not strictly about Atlasmap; what they do is solve the rendering of html elements inside an svg with lines connecting them. Ideally those components can/will be used by other projects (eg. Syndesis) to do something similar to what we do on Atlasmap but for other domains.
For this reason these components should not address Atlasmap specific concerns - like the collection one - because it's not in scope with the components' goal.
I'll try moving those components in a new package, with their own stories to make this separation more clear.

#1781 should address building storybook (and run tests and the linter too) on CI.

And about the bit about CanvasView, it looks like we (I) cut some more corner that I'd like to admit and there are many Atlasmap specific bits there. A good way to quickly find them is to search for usages of @patternfly/react-core, we have many points where we have strings and UI elements (dropdowns, buttons) that are about Atlasmap's UI.
I guess for the moment this is ok, but I think we should revisit this in a later moment if we'll ever need to use these components in a different project (namely, Syndesis).


add sample unit test for RestMLTrainingAction

Signed-off-by: Yaliang Wu<EMAIL_ADDRESS>Description
Add sample unit test for RestMLTrainingAction
@Zhangxunmt you can use similar way to add unit test for other rest actions
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

LGTM, but needs to spotlessApply.

LGTM, but needs to spotlessApply.

Forgot to run spotlessApply, published a new commit


OnePlus X Back Camera: capturing picture does not return to calling activity when not using forceClassic()

Hello,
I'm trying to use the library, and am following the documentation. I got the activity to open, but after capturing the photo, the preview freezes for a few seconds, the capture button greys out, but instead of returning to MainActivity, the preview restarts instead. I put debug output in onActivityResult and nothing fired, and no picture shows up in the file browser either.
Here is how the intent is built:
CameraActivity.IntentBuilder b = new CameraActivity.IntentBuilder(MainActivity.this);
b.to(new File(appPicDir,"cwactest.jpg"))
                .zoomStyle(ZoomStyle.SEEKBAR)
                .focusMode(FocusMode.CONTINUOUS)
                .allowSwitchFlashMode()
                .updateMediaStore()
                .facing(Facing.BACK);

Then I started it:
startActivityForResult(b.build(),7896);
Apparently I did something wrong, but can't seem to figure out where.

I have created a new project and tried again. The issue remains. After pressing the capture button, preview freezes for a few seconds then restarts, the capture button turns from green to gray. It does not return to MainActivity.
I pasted the code here: gist.

The issue seems to be device specific (OnePlus X) and only to the back camera as I tested it again on a Nexus 5 and it works correctly.
I tried the demo and it's the same"preview freezes for a few seconds then resume, capture button grays out and it stays like that: preview running forever). After a while (literally minutes, not seconds) I then tried pressing back, which shows the welcome screen with both previous and capture button grays out. It stays like that for a while and then it automatically opens the front-facing camera. I captured that and it proceeds as intended.
Summary: OnePlus X is problematic. Front camera works correctly, Back camera does not resume to calling activity after capture finishes but stays on the preview indefinitely with capture and switch buttons disabled.
I uploaded the zip file here. Hope this helps. I can provide more information if needed.

Update: I added forceClassic() and it works perfectly. The demo-playground has the same issue with the back camera, and is also resolved by calling forceClassic()

I need the Build.MANUFACTURER and Build.PRODUCT values for the hardware on which you are experiencing the problem. For all I know, there are several devices marketed as the "OnePlus X", just as there are several Samsung Galaxy S6's.

Build.MANUFACTURER = OnePlus
Build.PRODUCT = OnePlus

That doesn't look very helpful... the phone's About screen reports its "Model number" as "ONE E1001", if that helps.

OK, thanks! That's the Chinese variant (versus the E1003 for the rest of Asia plus Europe and E1005 for North America). It does not appear likely that I will be able to get an E1001. However, I do not have any OnePlus devices in my lab, so I will try to get some OnePlus X, and I'll see if I can reproduce the problem.

OK, I can reproduce the problem on an E1005, but only in portrait mode. Two questions:

Is that what you are seeing as well, that landscape is fine but portrait freezes?

Is Build.MODEL for your device ONE E1001? Mine is ONE E1005, so I am hoping they were consistent across the models (even if they do not use Build.PRODUCT like other manufacturers seem to).

I will configure the library to force this device into classic mode by default.
Thanks!

I can confirm that it works fine in landscape mode but freezes in portrait.
Yes, Its Build.Model returns ONE E1001

Many thanks for the prompt resolution, by the way!

Addressed in 0.5.7.

Is this fix available, I was able to produce on the following device, is using forceClassic only way to fix it. If we apply this as a fix will it not affect for any other manufacturers

@protocol10 As was noted above, this was fixed, but for the E1001. Please provide me with the Build.PRODUCT value for your device, to confirm that yours is an E1003.


There is a problem with Docker installing Redis remote connection in WSL2

I tried the following command on aliyun server and WSL2:
docker run --name redis -dit -p 6379:6379 redis
Then I tried to connect to Redis using Jedis, the Aliyun server received pong normally, but WSL2 reported an error that 'redis.clients.jedis.exceptions.JedisConnectionException: Failed connecting to host <IP_ADDRESS>:6379'.
However, in addition to Redis connection failure, MySQL, MongoDB, etc. can connect normally. So I don't think it's Docker or Redis itself.

@Altair2169 It's explained here: https://docs.microsoft.com/en-us/windows/wsl/networking#connecting-via-remote-ip-addresses

@onomatopellan even <IP_ADDRESS> isn't working. i have to use my ip. this is exactly the problem i'm facing & this is my solution to it although i would like localhost or <IP_ADDRESS> to work for consistency.


Process Document Updates

Review documents in branch 20190418-process-updates

All documents reviewed.

One action item from the prior ZLC was to research who is considered a "valid voter" for the upcoming elections.....I think we all agree that committers are the voter pool but there was some question on whether it would be all committers from the beginning of the project or some filter applied (i.e., last 6 months or last 12 months for example). Many thanks to @Tbr00ksy for experimenting with a GrimoireLab dashboard on the Zowe github to allow us to look at committers over the past year.......the dashboard allows pre-canned time periods to be queried (a week, month, 90 days, etc.).
The dashboard shows 130 committers did some github "activity" over the past year - "activity" is what I consider a "meaningful action" like raise an issue, do a pull, close an issues, etc. (In comparison, if you look at the last 6 months there were 109 committers.)
I propose we set a policy of committers who have been active over the past 12 months - we still need to pick a date for starting point? Aug 1? The 130 is both a manageable number and represent a quorum of people active on the project.
Zowe Git Stats.pptx

Updated and merged


Incompatible with Recipe Cache

Please link the github for the mod that does not work, if known!
https://gitlab.com/biom4st3r/optimizedcrafting
minecraft.log

Btw. carpet-fixes has optimizedFurnaces and optimizedRecipeManager. Are these better/same as Recipe Cache? Because if so, then Recipe Cache is redundant. Although optimizedFurnaces is limited to <1.19-alpha.22.12.a. Does that mean 1.19 has its own optimizations which are better/same as the method in carpet-fixes?

Correct optimizedFurnaces and optimizedRecipeManager give better performance then the simple caching provided by that mod

Do you know of any other popular performance mods that are redundant thanks to carpet-fixes? Also, do these performance improvements conflict with the likes of Lithium? I feel like vanilla optimizations that carpet-fixes has should be included in Lithium by default. Some of the optimizations here break vanilla parity, yes, and these shouldn't be in Lithium. But other are stated in the description to be vanilla friendly and are recommended to be used.


Status line is missing

Hello
Thanks for the awesome theme, I install it and realize there are issues like:
1. Status bar is missing.
2. The left menu icons are not in the center of the box (I don't know if it's related to the original theme or pihole itself)
3. Colors are different from the screenshot you send
Edit: It turns out 1 and 3 was causing because I have DARK Reader on my browser :)

The Pi-hole is on Debian 10
Pi-hole v5.9  -  FTL v5.14   -    Web Interface v5.11

Thanks for a feedback. It should be better now (commit)


Recon InfoSec is fully remote!

Would love to be listed here, we're a heavily veteran-based team.
https://www.reconinfosec.com/careers/

Hey Eric, sure thing, will add you folks today.
Cheers

Added :-)


build: update vscode-css-languageservice

Close #119
Implementation

Update vscode-css-languageservice to v5.1.0.
Also update vscode-languageserver-types to v3.16.0 due to compatibility with vscode-css-languageservice

Both before and after updating packages, running e2e tests fail for me:
  63 passing (2m)
  1 failing

  1) OutliningSpans
       should return basic css outlining spans:

      AssertionError: expected 3 to equal 2
      + expected - actual

      -3
      +2

      at Context.<anonymous> (e2e\tests\outliningSpans.js:22:16)
      at processTicksAndRejections (internal/process/task_queues.js:93:5)

Is this expected on main branch?

Both before and after updating packages, running e2e tests fail for me:

@hantatsang i had the same issue which is a shame, are you able to update the dependencies again and I can take a look

@jasonwilliams I just to upgraded to<EMAIL_ADDRESS>(latest). Still, the same test fails 🤔

Every e2e test fails for me I don't know if they're even working properly anymore. @mjbvz do you know?

All my tests also failed at first after this upgrade. But then I cd e2e && npm i, run test again and only the 1 test above failed

All my tests also failed at first after this upgrade. But then I cd e2e && npm i, run test again and only the 1 test above failed

Yep i just noticed that too. I have the same single test failing now, thanks.

Looks like it used to return 2 spans at one point, now it returns 3. Here's what spans looks like:
[
  {
    textSpan: {
      start: {
        line: 1,
        offset: 14,
      },
      end: {
        line: 8,
        offset: 2,
      },
    },
    hintSpan: {
      start: {
        line: 1,
        offset: 14,
      },
      end: {
        line: 8,
        offset: 2,
      },
    },
    bannerText: "...",
    autoCollapse: false,
    kind: "code",
  },
  {
    textSpan: {
      start: {
        line: 2,
        offset: 1,
      },
      end: {
        line: 3,
        offset: 1,
      },
    },
    hintSpan: {
      start: {
        line: 2,
        offset: 1,
      },
      end: {
        line: 3,
        offset: 1,
      },
    },
    bannerText: "",
    autoCollapse: false,
    kind: "code",
  },
  {
    textSpan: {
      start: {
        line: 5,
        offset: 1,
      },
      end: {
        line: 6,
        offset: 1,
      },
    },
    hintSpan: {
      start: {
        line: 5,
        offset: 1,
      },
      end: {
        line: 6,
        offset: 1,
      },
    },
    bannerText: "",
    autoCollapse: false,
    kind: "code",
  },
]

@hantatsang i think the new output (above) is correct. It seems like it creates an extra span for the whole thing. So the test can be updated to accept that. Im guessing when this was originally written only the 2 inner blocks generated spans, but now it generates a span for the const q definition

Also @hantatsang does npm run compile work for you? I don't have your change checked out but i remember i was having issues before with that. Hopefully the types are now updated in tandem with css-language service

Changing to https://github.com/microsoft/typescript-styled-plugin/blob/main/e2e/tests/outliningSpans.js
        assert.strictEqual(spans.length, 3);

        const [span1, span2, span3] = spans;
        assertPosition(span2.textSpan.start, 2, 1);
        assertPosition(span2.textSpan.end, 3, 1);

        assertPosition(span3.textSpan.start, 5, 1);
        assertPosition(span3.textSpan.end, 6, 1);

works

@hantatsang could you change that file to this
        assert.strictEqual(spans.length, 3);
        // The first span represents the root
        const [_, span2, span3] = spans;
        assertPosition(span2.textSpan.start, 2, 1);
        assertPosition(span2.textSpan.end, 3, 1);

        assertPosition(span3.textSpan.start, 5, 1);
        assertPosition(span3.textSpan.end, 6, 1);
        ```

Thanks, @jasonwilliams . Updated. Hope this will get reviewed & merged.

@mjbvz are you able to look at this also?

Thanks!


Describe your bug here. If you are modding, try testing your bug in a clean version of the engine instead. Also, if you're using an older version of JSE, please try the latest version/action build. Also, be sure to check the pinned 'JS Engine: Known Issues' issue, to check if your issue hasn't already been found!
the chart does not move to the next section and continues to go on one section, even if it has ended
https://github.com/user-attachments/assets/0281ca74-2d21-431b-897e-9730042c030b
Command Prompt/Terminal/Crash logs (if existing)
No response
Have you identified any steps to reproduce the bug? If so, please describe them below in as much detail as possible. Use images if possible.
No response
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
no
If you use 1.12.0 or earlier, did you have Optimized Chart Loading turned on?
None
Did you check for any similar issues to what you're reporting? Check, then come back here. If there is a similar issue, then do not report the issue, otherwise it will be marked as a duplicate.
Yes

i wonder what causes this...

I'm going to check

oh, TYSM


[IC3 ACS Resource Provider - Calling] SDK Review - Follow up

New SDK Review meeting has been requested.
Service Name: IC3 ACS Resource Provider - Calling
Review Created By: Jorge Garcia Hirota
Review Date: 10/31/2022 3:00 PM PT
Hero Scenarios Link: Not Provided
Architecture Diagram link: Not Provided
Core Concepts Doc Link: Not Provided
APIView Links: Android,
Description: [Public Preview] [Video Background Blur / Video Effects] [ARB]
A new feature for Android and Windows to allow developers to be able to use Video Effects for local videos on their applications. The first effect to review is Background Blur.
https://skype.visualstudio.com/SPOOL/_workitems/edit/3014453
Detailed meeting information and documents provided can be accessed here

New SDK Review meeting has been requested.
Service Name: IC3 ACS Resource Provider - Calling
Review Created By: Jorge Garcia Hirota
Review Date: 11/2/2022 3:00 PM PT
Hero Scenarios Link: Not Provided
Architecture Diagram link: Not Provided
Core Concepts Doc Link: Not Provided
APIView Links: Android,
Description: [Public Preview] [Video Background Blur / Video Effects] [ARB]
A new feature for Android and Windows to allow developers to be able to use Video Effects for local videos on their applications. The first effect to review is Background Blur.
https://skype.visualstudio.com/SPOOL/_workitems/edit/3014453
Detailed meeting information and documents provided can be accessed here

SDK Review: [ACS Calling SDK Native Team] [Public Preview] [Video Background Blur / Video Effects] [ARB]
Service name: ACS Calling SDK
Key contact for this review: Jose Saurez (jsaurezlee)
Link to previous API version:
Description of the material to be reviewed/changed: A new feature for Android and Windows to allow developers to be able to use Video Effects for local videos on their applications. The first effect to review is Background Blur.
Languages for this review. Android (Java) and Windows
Artifacts per language.
Android APIView azure-communication-calling (version 1.0.0-beta.1) - BETA Background Blur / Video Effects - apiview.dev
UWP APIView Azure.Communication.Calling.WinRTProjections (<IP_ADDRESS>) - apiview.dev
Champion Scenarios Android

Start Background Blur when a call is already in progress.
Start Background Blur before joining a call.

Both are setup in the same way from the Video Effects perspective

For background blur before joining the call, the setup happens on LocalVideoStream prior setting the VideoOptions to join the call.
For background blue while the call is in progress, the setup happens after a localVideoStream.startVideo() call.

// Create event handlers for the events
private void handleOnVideoEffectStarted(VideoEffectStartedEvent args) {
    Log.i("BackgroundBlurFeature", "Effect started for effect " + args.getVideoEffectName());
}

private void handleOnVideoEffectStopped(VideoEffectStoppedEvent args) {
    Log.i("BackgroundBlurFeature", "Effect stopped for effect " + args.getVideoEffectName());
}

private void handleOnVideoEffectError(VideoEffectErrorEvent args) {
    Log.i("BackgroundBlurFeature", "Error " + args.getCode() + ":" + args.getMessage()
            + " for effect " + args.getVideoEffectName());
}}

// Obtain the Video Effects feature from the LocalVideoStream object that is sending the video.
VideoEffectsLocalVideoStreamFeature videoEffectsFeature = localVideoStream.feature(Features.VIDEO_EFFECTS);

// Subscribe to the events
videoEffectsFeature.addOnVideoEffectStartedListener(handleOnVideoEffectStarted);
videoEffectsFeature.addOnVideoEffectStoppedListener(handleOnVideoEffectStopped);
videoEffectsFeature.addOnVideoEffectErrorListener(handleOnVideoEffectError);

// Create a new BackgroundBlue Effect object.
BackgroundBlurEffect backgroundBlurEffect = new BackgroundBlurEffect();
try {
    // Start the the Background Blur Effect on the Video Effects Feature.
    videoEffectsFeature.startEffects(backgroundBlurVideoEffect).get();
} catch (Exception e) {
    e.printStackTrace();
}

Stop Background Blur video effect

// Obtain the Video Effects feature from the LocalVideoStream object that is sending the video.
VideoEffectsLocalVideoStreamFeature videoEffectsFeature = localVideoStream.feature(Features.VIDEO_EFFECTS);

try {
    videoEffectsFeature.stopEffects().get();
} catch (Exception e) {
    e.printStackTrace();
}

Champion Scenarios Windows

Start Background Blur when a call is already in progress.
Start Background Blur before joining a call.

Both are setup in the same way from the Video Effects perspective

For background blur before joining the call, the setup happens on LocalVideoStream prior setting the VideoOptions to join the call.
For background blue while the call is in progress, the setup happens after a localVideoStream.startVideo() call.

// Create event handlers for the events
private void VideoEffectsFeature_OnVideoEffectStarted(object sender, VideoEffectStartedEventArgs args)
{
String effectName = args.VideoEffectName;
}

private void VideoEffectsFeature_OnVideoEffectStopped(object sender, VideoEffectStoppedEventArgs args)
{
String effectName = args.VideoEffectName;
}

private void VideoEffectsFeature_OnVideoEffectError(object sender, VideoEffectErrorEventArgs args)
{
String effectName = args.VideoEffectName;
String errorCode = args.Code;
String errorMessage = args.Message;
}

// Obtain the Video Effects feature from the LocalVideoStream object that is sending the video.
VideoEffectsLocalVideoStreamFeature videoEffectsFeature = (VideoEffectsLocalVideoStreamFeature)localVideoStream.GetLocalVideoStreamFeatureExtension(HandleType.VideoEffectsLocalVideoStreamFeature);

// Subscribe to the events
videoEffectsFeature.OnVideoEffectStarted += VideoEffectsFeature_OnVideoEffectStarted;
videoEffectsFeature.OnVideoEffectStopped += VideoEffectsFeature_OnVideoEffectStopped;
videoEffectsFeature.OnVideoEffectError += VideoEffectsFeature_OnVideoEffectError;

// Create a new BackgroundBlur Effect object.
BackgroundBlurEffect backgroundBlurVideoEffect = new BackgroundBlurEffect();

// Start the the Background Blur Video Effect on the Video Effects Feature.
await videoEffectsFeature.StartEffectsAsync(backgroundBlurVideoEffect);

Stop Background Blur video effect

// Obtain the Video Effects feature from the LocalVideoStream object that is sending the video.
VideoEffectsLocalVideoStreamFeature videoEffectsFeature = (VideoEffectsLocalVideoStreamFeature)localVideoStream.GetLocalVideoStreamFeatureExtension(HandleType.VideoEffectsLocalVideoStreamFeature);

await videoEffectsFeature.StopEffectsAsync();

Why does this review not include iOS?

@tjprescott It's Android and Windows only for now because of resourcing and customers are asking for these platforms now. We have scheduled iOS work for Q1 2023.

Recording: https://msit.microsoftstream.com/video/02e30840-98dc-ac1e-be04-f1ed5efd16f8


Regional settings conflict with CSV export because of comma for decimals

Brief description of your issue
If I export the process list, it generates a comma-separated values block of text.
Now in my case, my regional settings say that a number with decimals goes with comma, so for example, 8,92
This creates a small problem if importing to Excel to run a Text-to-Columns operation
Not enough to get much attention, but I couldn't go without reporting
Thanks
Steps to reproduce (optional)
No response
Expected behavior (optional)
No response
Actual behavior (optional)
No response
Environment (optional)
No response

I've updated the nightly build so it'll format numbers using full stop instead. There doesn't seem to be a reliable way of escaping commas in CSV files that works for all programs. The only way seems to be removing commas from the CSV.

Great, thanks
On Mon, 16 May 2022, 10:12 dmex, @.***> wrote:

I've updated the nightly build so it'll format numbers using full stop
instead. There doesn't seem to be a reliable way of escaping commas in CSV
files that works for all programs. The only way seems to be removing commas
from the CSV.
—
Reply to this email directly, view it on GitHub
https://github.com/processhacker/processhacker/issues/1207#issuecomment-1127365154,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAP654GT7IEZMKUHR5PO4STVKH7O3ANCNFSM5VR7W62A
.
You are receiving this because you authored the thread.Message ID:
@.***>


Issue with loading companions and getting response

Hi, I'm trying to use this on my local machine. I did the setup and the first page with all the companions showing is loading as it should.
After that once I prompt it with something I get the following error:
prompt:  Hello                                                                                Failed to record analytics TypeError: fetch failed                                                                       at Object.fetch (node:internal/deps/undici/undici:11576:11)                                                          at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {                                    cause: Error: getaddrinfo ENOTFOUND ****                                                                                at GetAddrInfoReqWrap.onlookup [as oncomplete] (node:dns:108:26)                                                     at GetAddrInfoReqWrap.callbackTrampoline (node:internal/async_hooks:130:17) {                                      errno: -3008,                                                                                code: 'ENOTFOUND',                                                                                syscall: 'getaddrinfo',                                                                                hostname: '****'                                                                                }                                                                                }                                                                                - error TypeError: fetch failed                                                                                at Object.fetch (node:internal/deps/undici/undici:11576:11)                                                          at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {                                    cause: Error: getaddrinfo ENOTFOUND ****                                                                                at GetAddrInfoReqWrap.onlookup [as oncomplete] (node:dns:108:26)                                                     at GetAddrInfoReqWrap.callbackTrampoline (node:internal/async_hooks:130:17) {                                      errno: -3008,                                                                                code: 'ENOTFOUND',                                                                                syscall: 'getaddrinfo',                                                                                hostname: '****'                                                                                }                                                                                }
also when I try and load this in github workspaces no companions are loaded in, this shows instead:

and then when prompting this "empty" companion I get the following:

I've tried fixing the issue myself with no success.

I fixed the issue with the local machine by removing typo from env.local.
The github workspaces issue still persists.

what was the typo from env.local?

Double letter on accident.


Bypass event processing in the cli tool if both the input and output are value streams.

Description of changes:
At our company we are often dealing with binary Amazon ion files that are a few gigabytes large.
Sometimes we want to convert them to text for manual inspection, and it would be convenient to use the provided CLI tool for this purpose. Basically we would like to do this: ion process -f pretty -o output.txt large_binary_file.ion
Unfortunately the tool currently tries to load the whole input file into memory and even multiplies its size by converting it into an event stream. For larger files this requires more memory than is available in a typical desktop computer.
I've noticed this comment in cli.cpp:
// Would be nice to use this (especially for performance testing), but having to peek at the first value in the
// stream (to identify $ion_event_stream) rules it out.
//IONCHECK(ion_writer_write_all_values(writer_context->writer, reader_context.reader));

I think I could make it work by converting only the first value into events in ion_event_stream_is_event_stream, writing it back calling ion_event_stream_write_all, and processing the rest with ion_writer_write_all_values as the comment suggests.
The only unit test that failed is IonCli.ErrorIsConveyed. It looks like it parses "false" from "false::23" and reports error only when it reaches the first colon at index 5. The original implementation reported error immediately at index 0. I modified the test for now, but I'm not sure which one is considered the correct behavior.
Note that this does not solve the memory usage problem when the input or the output is an event stream. Solving that would require a much deeper refactor, and since that use case is not really important for us, I did not attempt to do it.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

As mentioned here. we tried to write as many events as possible while read fails. Could you take a look at this?

Thanks, I'll look into it.

I've fixed it, it passes the checks now.


Always import full chunks when querying metrics

This PR changes metrics importing to always import metrics of the configured import chunk size.
This ensures consistency in metrics being imported.

/retest

/retest

Fixes #922

/lgtm


Translation hot reload

Casdoor is using i18next as our internationalization tool, every time we want to change to other language, we click the button and Casdoor will refresh the page and load the language we want, however, I think using hot reload might be more elegant and suitable.
Since Casdoor is based on React, I think react-i18next can help us achieve that feature.
A react-i18next based demo: https://codesandbox.io/s/1zxox032q
More details:
https://github.com/i18next/react-i18next
https://dev.to/adrai/how-to-properly-internationalize-a-react-application-using-i18next-3hdb

Hot reload will bring the [object object] bug, see: https://github.com/casbin/casdoor/pull/169#issuecomment-881206568
And I don't think removing refresh is good, because changing language is very low-frequency operation, and the users need feedback like page refresh.
So closed here for now.


docs(Architecture): Added architecture guide

The guide which describes core architecture principles used in the SUI.
Especially, theming and accessibility.

Note, the vision outline has been started in the docs/vision branch.  The markdown outline is here:
https://github.com/stardust-ui/react/blob/docs/vision/VISION.md
We are iterating on this twice a week in our vision and architecture meetings.  Once complete, we should be all clear for some doc contributions based on the outline.


update git url for renaming nbinteract to nbpuller

Closes #68
Summary
Reflect renamed nbpuller (originally nbinteract) git repo in deployment settings. Updating the nbpuller to newest version.
How to test
Try to build the user image.

There seems to be a bug with an earlier function of nbpuller. Don't merge at this time!

I think I have fixed the bug :)