Missing CA certificates in jdk8u181-b13

The jdk8u181-b13 update lost roughly half of cacerts entries: it has only 80 entries while jdk8u172-b11 has 157.
This causes SSL errors like this (tried with some domains of Google and Amazon):
Caught: javax.net.ssl.SSLHandshakeException: sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target
javax.net.ssl.SSLHandshakeException: sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target
	at script_from_command_line.run(script_from_command_line:1)
Caused by: sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target
	... 1 more
Caused by: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target
	... 1 more

I tried Docker images as well as downloadable tar.gz – they both have the same version of truncated cacerts file.

Which platform were you seeing this on @detouched?

Pretty much all for "OpenJDK 8 with Hotspot" option, just double checked these all:
OpenJDK8U-jdk_x64_mac_hotspot_8u181b13.tar.gz
OpenJDK8U-jdk_ppc64_aix_hotspot_8u181b13.tar.gz
OpenJDK8U-jdk_x64_linux_hotspot_8u181b13.tar.gz
OpenJDK8U-jdk_x64_windows_hotspot_8u181b13.zip
OpenJDK8U-jdk_s390x_linux_hotspot_8u181b13.tar.gz

I also tried following Docker images where I initially faced this issue:
adoptopenjdk/openjdk8:alpine-slim
adoptopenjdk/openjdk8:jdk8u181-b13

I then compared cacerts to the one shipped in adoptopenjdk/openjdk8:jdk8u172-b11, which works fine, and found that the newer one is truncated.

I am getting following exception as well and have found out that its an issue with the certs coming in the jdk build.
javax.net.ssl.SSLHandshakeException: sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target
I am attaching an image below showing the number of certificates in Adopt jdk8u172-b11, jdk8u181-b13 and Oracle jdk 1.8.0_172 respectively for the Mac distribution.

My team is attempting to move to AdoptOpenJDK and just encountered a related error.  The issue was encountered running on MacOS.  This looks like a major bug.
[ERROR] Failed to execute goal org.sonarsource.scanner.maven:sonar-maven-plugin:<IP_ADDRESS>3:sonar (default-cli) on project esom-load-bgservice: Unable to execute SonarQube: Fail to get bootstrap index from server: sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target

After some digging, I have found that the certificate which is popular and missing in jdk8u181-b13 is "Starfield Services Root Certificate Authority" root cert, now acquired by Amazon. Oracle JDK 8 and jdk8u172-b11 bundles this certificate in cacert. Various amazon trust root CAs are listed here: https://www.amazontrust.com/repository/

As a workaround People can install the cert from Amazon Trust Repository. Following command might help with verifying whether a "Starfield Services Root Certificate Authority" cert is present or not:
echo 'changeit'|keytool -list -v -keystore $(find ${JAVA_HOME} -name cacerts) -name cacerts)|grep 'Owner'|grep 'Star'
And use the below command to install the above cert in cacert:
wget https://www.amazontrust.com/repository/SFSRootCAG2.pem && keytool -import -trustcacerts -keystore $JAVA_HOME/jre/lib/security/cacerts -storepass changeit -alias Root -import -file SFSRootCAG2.pem && rm SFSRootCAG2.pem

The nightly builds should now produce a version with the new cacerts.  The next release 8u192 should also pick up these changes (hopefully next week)

The latest available for Ubuntu14.04 is still 171 - https://launchpad.net/~openjdk-r/+archive/ubuntu/ppa
Is there a plan to release an update ?
Unfortunately, the command provided by @Ganeshgautam doesn't work, probably just minor syntax errors.

@nitinsurana YThe version available by launchpad is not by AdoptOpenJDK, you'll have to manually download from our site.

@karianna wrote:

@johnoliver - Interesting, looks like we may need to backport certs from latest 11

I ran into this very same issue today on Mac OS but for AdoptOpenJDK 11 build 11.0.5+10 (HotSpot VM) and was astonished when I read this thread and your comment that the issue should have been fixed for jdk8 by backporting certs from jdk11. Indeed, my tests with AdoptOpenJDK 8 were successfull. But JDK 11 throws an Exception:
I tried a HttpURLConnection HEAD request to https://www.google.com which failed in AdoptOpenJDK 11.0.5+10 with this exception but works very well in AdoptOpenJDK 8.
javax.net.ssl.SSLHandshakeException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target
	at java.base/sun.security.ssl.Alert.createSSLException(Alert.java:131)
	at java.base/sun.security.ssl.TransportContext.fatal(TransportContext.java:320)
	at java.base/sun.security.ssl.TransportContext.fatal(TransportContext.java:263)
	at java.base/sun.security.ssl.TransportContext.fatal(TransportContext.java:258)
	at java.base/sun.security.ssl.CertificateMessage$T12CertificateConsumer.checkServerCerts(CertificateMessage.java:641)
	at java.base/sun.security.ssl.CertificateMessage$T12CertificateConsumer.onCertificate(CertificateMessage.java:460)
	at java.base/sun.security.ssl.CertificateMessage$T12CertificateConsumer.consume(CertificateMessage.java:360)
	at java.base/sun.security.ssl.SSLHandshake.consume(SSLHandshake.java:392)
	at java.base/sun.security.ssl.HandshakeContext.dispatch(HandshakeContext.java:443)
	at java.base/sun.security.ssl.HandshakeContext.dispatch(HandshakeContext.java:421)
	at java.base/sun.security.ssl.TransportContext.dispatch(TransportContext.java:177)
	at java.base/sun.security.ssl.SSLTransport.decode(SSLTransport.java:164)
	at java.base/sun.security.ssl.SSLSocketImpl.decode(SSLSocketImpl.java:1152)
	at java.base/sun.security.ssl.SSLSocketImpl.readHandshakeRecord(SSLSocketImpl.java:1063)
	at java.base/sun.security.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl.java:402)
	at java.base/sun.net.www.protocol.https.HttpsClient.afterConnect(HttpsClient.java:567)
	at java.base/sun.net.www.protocol.https.AbstractDelegateHttpsURLConnection.connect(AbstractDelegateHttpsURLConnection.java:185)
	at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1587)
	at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1515)
	at java.base/java.net.HttpURLConnection.getResponseCode(HttpURLConnection.java:527)
	at java.base/sun.net.www.protocol.https.HttpsURLConnectionImpl.getResponseCode(HttpsURLConnectionImpl.java:334)
	at de.paginagmbh.common.internet.NetTest.URLTester(NetTest.java:82)
	at de.paginagmbh.common.internet.NetTest.testInternetConnection(NetTest.java:48)
	at de.paginagmbh.epubchecker.UpdateCheck.<init>(UpdateCheck.java:95)
	at de.paginagmbh.epubchecker.MainGUI$9.doInBackground(MainGUI.java:839)
	at de.paginagmbh.epubchecker.MainGUI$9.doInBackground(MainGUI.java:1)
	at java.desktop/javax.swing.SwingWorker$1.call(SwingWorker.java:304)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.desktop/javax.swing.SwingWorker.run(SwingWorker.java:343)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:834)
Caused by: sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target
	at java.base/sun.security.validator.PKIXValidator.doBuild(PKIXValidator.java:385)
	at java.base/sun.security.validator.PKIXValidator.engineValidate(PKIXValidator.java:290)
	at java.base/sun.security.validator.Validator.validate(Validator.java:264)
	at java.base/sun.security.ssl.X509TrustManagerImpl.validate(X509TrustManagerImpl.java:313)
	at java.base/sun.security.ssl.X509TrustManagerImpl.checkTrusted(X509TrustManagerImpl.java:222)
	at java.base/sun.security.ssl.X509TrustManagerImpl.checkServerTrusted(X509TrustManagerImpl.java:129)
	at java.base/sun.security.ssl.CertificateMessage$T12CertificateConsumer.checkServerCerts(CertificateMessage.java:625)
	... 27 more
Caused by: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target
	at java.base/sun.security.provider.certpath.SunCertPathBuilder.build(SunCertPathBuilder.java:141)
	at java.base/sun.security.provider.certpath.SunCertPathBuilder.engineBuild(SunCertPathBuilder.java:126)
	at java.base/java.security.cert.CertPathBuilder.build(CertPathBuilder.java:297)
	at java.base/sun.security.validator.PKIXValidator.doBuild(PKIXValidator.java:380)
	... 33 more

Do you have any clue why this still happens for JDK 11?

@tofi86 I dont have a Mac to test, but www.google.com is working for me with 11.0.5+10 on linux, and using the same cacert store.
If you can recreate the issue, can you give us the output of:
openssl s_client -connect www.google.com:443

On that machine.

If you can recreate the issue, can you give us the output of:
openssl s_client -connect www.google.com:443

Sure thing:
openssl s_client -connect www.google.com:443
CONNECTED(00000005)
depth=2 OU = GlobalSign Root CA - R2, O = GlobalSign, CN = GlobalSign
verify return:1
depth=1 C = US, O = Google Trust Services, CN = GTS CA 1O1
verify return:1
depth=0 C = US, ST = California, L = Mountain View, O = Google LLC, CN = www.google.com
verify return:1
---
Certificate chain
 0 s:/C=US/ST=California/L=Mountain View/O=Google LLC/CN=www.google.com
   i:/C=US/O=Google Trust Services/CN=GTS CA 1O1
 1 s:/C=US/O=Google Trust Services/CN=GTS CA 1O1
   i:/OU=GlobalSign Root CA - R2/O=GlobalSign/CN=GlobalSign
---
Server certificate
-----BEGIN CERTIFICATE-----
MIIFiTCCBHGgAwIBAgIQMtfVXJQ+SlsIAAAAAB8R3TANBgkqhkiG9w0BAQsFADBC
MQswCQYDVQQGEwJVUzEeMBwGA1UEChMVR29vZ2xlIFRydXN0IFNlcnZpY2VzMRMw
EQYDVQQDEwpHVFMgQ0EgMU8xMB4XDTE5MTExMzA5MDkxM1oXDTIwMDIwNTA5MDkx
M1owaDELMAkGA1UEBhMCVVMxEzARBgNVBAgTCkNhbGlmb3JuaWExFjAUBgNVBAcT
DU1vdW50YWluIFZpZXcxEzARBgNVBAoTCkdvb2dsZSBMTEMxFzAVBgNVBAMTDnd3
dy5nb29nbGUuY29tMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA2RjV
l+qoCQyzLWAAov9f+tX8NnopxNGvI0ZM5f2nxWDEXp2aGUPFfOwmbzU1z3GgtlhN
sxYy1/v7/z/TQfs2jp0Ih8/VbJPwcvd/MIUydjXJN98A7f+V+g21NWGhsxx/ke/0
vwu8NXkBTUj1xdBKS9XEegM9VSBz5fRc6R4c+fp4R60OhiAFO+N4KySU3ZcYjwnZ
SYj1guENKsXQ0hAGfE6q4Do7a5IlyhtrNPQJDtWrrXd0M3tOJrPVRPW90zxZXoLD
zeL48HEz4ZOeaLYF7JRC3kWpQM0QrfEdHgsAzf32i4YSJW0+QKCP1LrW2CPGCs1s
xcwucv62mSdGfoeLZQIDAQABo4ICUzCCAk8wDgYDVR0PAQH/BAQDAgWgMBMGA1Ud
JQQMMAoGCCsGAQUFBwMBMAwGA1UdEwEB/wQCMAAwHQYDVR0OBBYEFE5cH7tOZt2M
EoIrsBjGm2PW9vwcMB8GA1UdIwQYMBaAFJjR+G4Q68+b7GCfGJAboOt9Cf0rMGQG
CCsGAQUFBwEBBFgwVjAnBggrBgEFBQcwAYYbaHR0cDovL29jc3AucGtpLmdvb2cv
Z3RzMW8xMCsGCCsGAQUFBzAChh9odHRwOi8vcGtpLmdvb2cvZ3NyMi9HVFMxTzEu
Y3J0MBkGA1UdEQQSMBCCDnd3dy5nb29nbGUuY29tMCEGA1UdIAQaMBgwCAYGZ4EM
AQICMAwGCisGAQQB1nkCBQMwLwYDVR0fBCgwJjAkoCKgIIYeaHR0cDovL2NybC5w
a2kuZ29vZy9HVFMxTzEuY3JsMIIBAwYKKwYBBAHWeQIEAgSB9ASB8QDvAHYAsh4F
zIuizYogTodm+Su5iiUgZ2va+nDnsklTLe+LkF4AAAFuZD0QwwAABAMARzBFAiB/
1Vyg9oc5HyhTrum94PGFx02Qz9MpmE+w1SDPQYrS9AIhAK2V0Lgq/USGG7jpRQaL
ra4/QVyQufCypokbJRMY0Y/2AHUAXqdz+d9WwOe1Nkh90EngMnqRmgyEoRIShBh1
loFxRVgAAAFuZD0QqAAABAMARjBEAiB6XIdvV73VfsyAT2/+BF0nl5b88nV+CwkW
mIC59W9QVwIgdeqPPFsEhSFWXkbMHTUTsGZn+v6gvNOYRj06WyTsbEYwDQYJKoZI
hvcNAQELBQADggEBAFb6bdyuZVGFZie2WZErJdEmhojTXQ3L2pZ3T+jj7urMGVip
gG/zxmtPtjITQJhRwNlmTeoLgKClnI9AFIbV8WXivDyjnSW1GY+z4b3MP4aH32BO
mOwvRqf/jHSU/vo5FCBxz1LqD7HRL2cXKwQLbt1jPD+rpoXI83vE7bi77OLDitm2
kyF5s9SXka+mavAEi8/hNv1VUWYpfPalw8jnaS8iTD2t0nG7mhuA0Te67H+Q7eMz
DREKSCXYHBwateTQ8v5u6UDYpa2+ilpPEHdixllTFWPo001YVtjvSXUAug9Me5TR
ABhmx8uKbpbUitZ0S5hcWsZnFpyt8prr5b0gczc=
-----END CERTIFICATE-----
subject=/C=US/ST=California/L=Mountain View/O=Google LLC/CN=www.google.com
issuer=/C=US/O=Google Trust Services/CN=GTS CA 1O1
---
No client certificate CA names sent
Server Temp Key: ECDH, X25519, 253 bits
---
SSL handshake has read 3190 bytes and written 285 bytes
---
New, TLSv1/SSLv3, Cipher is ECDHE-RSA-CHACHA20-POLY1305
Server public key is 2048 bit
Secure Renegotiation IS supported
Compression: NONE
Expansion: NONE
No ALPN negotiated
SSL-Session:
    Protocol  : TLSv1.2
    Cipher    : ECDHE-RSA-CHACHA20-POLY1305
    Session-ID: F0DE351C6CCB5AB747833C03AE2FA2F80E8E1313C6821D3AC4257A819B6E7BFA
    Session-ID-ctx:
    Master-Key: 96AD9065E90F91625884DC18883F9494E4DBC6C2D661A89C677F4CD7ED54FD1CDA7886FB0782BED363A8BC57EE065E98
    TLS session ticket lifetime hint: 100800 (seconds)
    TLS session ticket:
    0000 - 00 df 86 45 35 63 fe a3-01 99 b8 05 60 3e 09 5d   ...E5c......`>.]
    0010 - 4d 2e a1 c2 e3 12 0a 3a-f5 fa 14 a4 43 14 7b bd   M......:....C.{.
    0020 - a5 11 53 1a 65 9a 88 4b-19 70 4f 7c dc fc bf 48   ..S.e..K.pO|...H
    0030 - 01 18 05 56 ff a6 06 4e-58 86 a4 5f c2 3c 66 d6   ...V...NX.._.<f.
    0040 - 18 a4 2d 31 62 05 3c 97-30 16 b3 b2 92 25 b1 0e   ..-1b.<.0....%..
    0050 - 67 f3 c5 35 3f 20 3e 2b-59 ca f3 80 01 d2 45 d7   g..5? >+Y.....E.
    0060 - d8 9c 39 ed 52 a3 02 ab-1c 74 cb bd 20 3f 7b b7   ..9.R....t.. ?{.
    0070 - 40 5c 69 93 20 0e 76 97-01 f0 c4 b2 60 b1 81 bb   @\i. .v.....`...
    0080 - ab 1a 51 32 8d 33 66 e7-88 ea b9 72 59 03 e5 5e   ..Q2.3f....rY..^
    0090 - 1f 39 0f b8 3f ac 8b 9c-cf 2c 2d 26 2e 73 bc 1e   .9..?....,-&.s..
    00a0 - 5a 1e d1 cb 56 2a 8d d7-b3 4e c6 b6 38 fd fa 91   Z...V*...N..8...
    00b0 - 01 1e 31 be fb 80 aa 7b-41 7a f3 f0 77 dd 44 7f   ..1....{Az..w.D.
    00c0 - 55 bf 9f ea 26 09 0c 4d-e4 22 39 f9 fd 98 41 f7   U...&..M."9...A.
    00d0 - 3a eb 33 16 cd                                    :.3..

    Start Time:<PHONE_NUMBER>
    Timeout   : 7200 (sec)
    Verify return code: 0 (ok)
---
read:errno=0

Then in the next step I tried to reproduce with an SSCCE:
import java.io.IOException;
import java.net.HttpURLConnection;
import java.net.MalformedURLException;
import java.net.URL;

public class UrlConnectionTest {

	public static void main(String[] args) throws MalformedURLException {
		URL url = new URL("https://www.google.com");

		try {
			HttpURLConnection urlConnect = (HttpURLConnection) url.openConnection();
			urlConnect.setReadTimeout(10000);
			urlConnect.setRequestMethod("HEAD");
			System.out.println(urlConnect.getResponseCode());
		} catch (IOException e) {
			e.printStackTrace();
		}
	}
}

While it failed in my program code at urlConnect.getResponseCode() with an IOException, it works fine in the SSCCE.
While digging deeper, it turned out a colleague once set this at program start:
// Workaround for SSL connection errors in Java 7 ( https://stackoverflow.com/questions/7615645/ )
System.setProperty("jsse.enableSNIExtension", "false");

in order to avoid javax.net.ssl.SSLProtocolException: handshake alert when connecting to certain SSL sites with Oracle Java 7(+).
If I add this before the try in the SSCCE it fails for AdoptOpenJDK 11 and 13, but works in AdoptOpenJDK 8.
I tried removing the setProperty(...) from my Application and it works at the moment for Oracle Java 1.7 and 1.8 and also for AdoptOpenJDK 8, 11, 13. So I'll most certainly remove this setting and bump the version requirement to Java 8 – just to be sure.
However, can you explain why the SSCCE with jsse.enableSNIExtension = false fails in AOJDK 11 but works in 8?

Hi there!
I believe I am seeing something similar.
This is from a Raspberry Pi with OpenJDK11:
$ uname -a
Linux pi.local 4.19.93-v7l+ #1290 SMP Fri Jan 10 16:45:11 GMT 2020 armv7l GNU/Linux

$ lsb_release -d
Description:	Raspbian GNU/Linux 10 (buster)

# Using javac from openjdk-11-jdk-headless (Raspbian) to compile a test program
$ wget -q https://gist.githubusercontent.com/4ndrej/4547029/raw/84d3bff7bba262b3f77baa32a43873ea95993e45/SSLPoke.java
$ /usr/bin/javac -version
javac 11.0.6
$ /usr/bin/javac SSLPoke.java
$ java SSLPoke downloads.arduino.cc 443
Successfully connected
$ java SSLPoke www.cloudflare.com 443
Successfully connected
$

# Now let's download and test AdoptOpenJDK
$ wget -q wget https://github.com/AdoptOpenJDK/openjdk11-binaries/releases/download/jdk-11.0.6%2B10/OpenJDK11U-jdk_arm_linux_hotspot_11.0.6_10.tar.gz
$ tar xzf OpenJDK11U-jdk_arm_linux_hotspot_11.0.6_10.tar.gz

$ ./jdk-11.0.6+10/bin/java SSLPoke downloads.arduino.cc 443
javax.net.ssl.SSLHandshakeException: PKIX path validation failed: java.security.cert.CertPathValidatorException: signature check failed
	at java.base/sun.security.ssl.Alert.createSSLException(Alert.java:131)
	at java.base/sun.security.ssl.TransportContext.fatal(TransportContext.java:320)
	at java.base/sun.security.ssl.TransportContext.fatal(TransportContext.java:263)
	at java.base/sun.security.ssl.TransportContext.fatal(TransportContext.java:258)
	at java.base/sun.security.ssl.CertificateMessage$T13CertificateConsumer.checkServerCerts(CertificateMessage.java:1332)
	at java.base/sun.security.ssl.CertificateMessage$T13CertificateConsumer.onConsumeCertificate(CertificateMessage.java:1207)
	at java.base/sun.security.ssl.CertificateMessage$T13CertificateConsumer.consume(CertificateMessage.java:1150)
	at java.base/sun.security.ssl.SSLHandshake.consume(SSLHandshake.java:392)
	at java.base/sun.security.ssl.HandshakeContext.dispatch(HandshakeContext.java:443)
	at java.base/sun.security.ssl.HandshakeContext.dispatch(HandshakeContext.java:421)
	at java.base/sun.security.ssl.TransportContext.dispatch(TransportContext.java:177)
	at java.base/sun.security.ssl.SSLTransport.decode(SSLTransport.java:164)
	at java.base/sun.security.ssl.SSLSocketImpl.decode(SSLSocketImpl.java:1151)
	at java.base/sun.security.ssl.SSLSocketImpl.readHandshakeRecord(SSLSocketImpl.java:1062)
	at java.base/sun.security.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl.java:402)
	at java.base/sun.security.ssl.SSLSocketImpl.ensureNegotiated(SSLSocketImpl.java:716)
	at java.base/sun.security.ssl.SSLSocketImpl$AppOutputStream.write(SSLSocketImpl.java:969)
	at java.base/sun.security.ssl.SSLSocketImpl$AppOutputStream.write(SSLSocketImpl.java:941)
	at SSLPoke.main(SSLPoke.java:28)
Caused by: sun.security.validator.ValidatorException: PKIX path validation failed: java.security.cert.CertPathValidatorException: signature check failed
	at java.base/sun.security.validator.PKIXValidator.doValidate(PKIXValidator.java:369)
	at java.base/sun.security.validator.PKIXValidator.engineValidate(PKIXValidator.java:263)
	at java.base/sun.security.validator.Validator.validate(Validator.java:264)
	at java.base/sun.security.ssl.X509TrustManagerImpl.validate(X509TrustManagerImpl.java:313)
	at java.base/sun.security.ssl.X509TrustManagerImpl.checkTrusted(X509TrustManagerImpl.java:222)
	at java.base/sun.security.ssl.X509TrustManagerImpl.checkServerTrusted(X509TrustManagerImpl.java:129)
	at java.base/sun.security.ssl.CertificateMessage$T13CertificateConsumer.checkServerCerts(CertificateMessage.java:1316)
	... 14 more
Caused by: java.security.cert.CertPathValidatorException: signature check failed
	at java.base/sun.security.provider.certpath.PKIXMasterCertPathValidator.validate(PKIXMasterCertPathValidator.java:135)
	at java.base/sun.security.provider.certpath.PKIXCertPathValidator.validate(PKIXCertPathValidator.java:237)
	at java.base/sun.security.provider.certpath.PKIXCertPathValidator.validate(PKIXCertPathValidator.java:145)
	at java.base/sun.security.provider.certpath.PKIXCertPathValidator.engineValidate(PKIXCertPathValidator.java:84)
	at java.base/java.security.cert.CertPathValidator.validate(CertPathValidator.java:309)
	at java.base/sun.security.validator.PKIXValidator.doValidate(PKIXValidator.java:364)
	... 20 more
Caused by: java.security.SignatureException: Signature does not match.
	at java.base/sun.security.x509.X509CertImpl.verify(X509CertImpl.java:456)
	at java.base/sun.security.provider.certpath.BasicChecker.verifySignature(BasicChecker.java:166)
	at java.base/sun.security.provider.certpath.BasicChecker.check(BasicChecker.java:147)
	at java.base/sun.security.provider.certpath.PKIXMasterCertPathValidator.validate(PKIXMasterCertPathValidator.java:125)
	... 25 more
$

# This results in the same error as above
$ ./jdk-11.0.6+10/bin/java SSLPoke www.cloudflare.com 443

✨
What I find particularly surprising is that the results does not change even when another cacert-file is used.
The Raspbian java is still happily validating the domains based on the cacert-file from AdoptOpenJDK.
The AdoptOpenJDK java is also consistent even when handed the Raspbian provided cacert-file:
# Testing cacert from AdoptOpenJDK with Raspbian java
$ sudo mv /etc/ssl/certs/java/cacerts /etc/ssl/certs/java/cacerts__
$ java -Djava.security.debug=all -Djavax.net.ssl.trustStore=jdk-11.0.6+10/lib/security/cacerts -Djavax.net.ssl.trustStorePassword=changeit SSLPoke www.cloudflare.com 443 2>&1 | grep 'validation succeeded'
certpath: -checker1 validation succeeded
certpath: -checker2 validation succeeded
certpath: -checker3 validation succeeded
certpath: -checker4 validation succeeded
certpath: -checker5 validation succeeded
certpath: -checker6 validation succeeded
certpath: -checker7 validation succeeded
cert1 validation succeeded.
certpath: -checker1 validation succeeded
certpath: -checker2 validation succeeded
certpath: -checker3 validation succeeded
certpath: -checker4 validation succeeded
certpath: -checker5 validation succeeded
certpath: -checker6 validation succeeded
certpath: -checker7 validation succeeded
cert2 validation succeeded.
certpath: Cert path validation succeeded. (PKIX validation algorithm)

# Testing cacert from Raspbian with AdoptOpenJDK java
$ ./jdk-11.0.6+10/bin/java -Djava.security.debug=all -Djavax.net.ssl.trustStore=/etc/ssl/certs/java/cacerts__ -Djavax.net.ssl.trustStorePassword=changeit SSLPoke www.cloudflare.com 443 2>&1 | grep 'validation succeeded'
certpath: -checker1 validation succeeded
certpath: -checker2 validation succeeded
certpath: -checker3 validation succeeded
certpath: -checker4 validation succeeded
certpath: -checker5 validation succeeded
certpath: -checker6 validation succeeded
certpath: -checker7 validation succeeded
cert1 validation succeeded.
certpath: -checker1 validation succeeded
certpath: -checker2 validation succeeded
certpath: -checker3 validation succeeded
certpath: -checker4 validation succeeded
certpath: -checker5 validation succeeded
$

I got similar results when testing jdk8u232-b09-jre on the same platform (armv7l).
Refs https://github.com/arduino/Arduino/issues/9719

I've tested the following JREs using your SSLPoke example:

JRE
arch
exact version
Builder
Working

1.8.0_232 (in IDE)
arm32
1.8.0_232-b09
AdoptOpenJDK
NO

1.8.0_232
x64
1.8.0_232-b09
AdoptOpenJDK
YES (!)

1.8.0_212 (apt-get)
arm32
1.8.0_212-8u212-b01-1+rpi1-b01
Raspbian
YES

1.8.0_222
arm32
1.8.0_222-b10
AdoptOpenJDK
NO

1.8.0_252
arm32
1.8.0_252-202002060440-b01
AdoptOpenJDK
NO

There are no AdoptOpenJDK builds for arm32 before 1.8.0_222 and the latest available from raspbian is 1.8.0_212.
Looking at the table above, at a first sight, I thought that a regression happened between 1.8.0_212 and 1.8.0_222 BUT the same release 1.8.0_232 for x64 is WORKING, so the only reasonable conclusion is that the builds made from AdoptOpenJDK for ARM 32 are buggy.
Is Raspbian applying patches? Is the java version made by raspian redistributable? In that case we may consider to bundle that one.

Sorry the previous message was not meant to be sent here, I sent it by error, my apologies.
Anyway, hope it may help to narrow down the issue.

Sorry the previous message was not meant to be sent here, I sent it by mistake, my apologies.
Anyway, I hope it helps to narrow down the issue.

Argh, I deleted it by accident, can you link to the original message?

https://github.com/arduino/Arduino/issues/9719#issuecomment-583066985

Problems with ARMv7 have been fixed some time ago. AdoptOpenJDK 15 contains a new cacerts keystore containing the same set of certificates as Firefox (and most of the Linux distributions). The October updates for 8 and 11 will get the same keystore.
If new problems appear or old ones persist, please open a new issue.


[proposal] caching queries on selectFrom

Hello
When we were on mongoose we implemented a way to cache a mongoose query with a TypeScript overload of .cache() on every query. If that can be built natively in kysely that would be a great addon. Here is how it could work:

every selectFrom() construct in kysely provides a cache() after execute() method (i.e. db.selectFrom('...').selectAll().execute().cache('my-key')
db somehow can be programmed to handle the cache (making the cache store generic):

db.onQueryCacheSet = async (key: string, queryResult: unknown) => {
   // responsibility of the developer to cache this properly
}

db.onQueryCacheGet = async (key: string) => {
  // responsibility of the developer to return data associated with the given key. return null/false to execute the query
}

.onQueryCacheGet and .onQueryCacheSet would only run if .cache is set on query. Inside these two methods, developers can use caching stores like Redis or in-memory if required.

Kysely is a query builder, not an ORM.


mgmt: hawkbit: define attributes in the user application

Attributes can now be defined in the user application by the use of a callback function.
Resolves: #37640

ping

ping @ycsin

just a rebase to the current main

I haven't really looked at this in details yet but it seems to expose a little too much to the public than I would like, i.e. all the structs and stuff that used to be internal.
I wonder if it is possible to just have a mechanism for hawkBit to get the formatted json of the attributes from the app in the form of a buffer and sent it to the server?

I haven't really looked at this in details yet but it seems to expose a little too much to the public than I would like, i.e. all the structs and stuff that used to be internal.

they are needed if the user wants to define its own config callback. but maybe they could be put in a seperate header file and not in include/zephyr/mgmt/hawkbit.h maybe include/zephyr/mgmt/hawkbit_config.h or create a new folder include/zephyr/mgmt/hawkbit/ which contains include/zephyr/mgmt/hawkbit/hawkbit.h and include/zephyr/mgmt/hawkbit/config.h ?

I wonder if it is possible to just have a mechanism for hawkBit to get the formatted json of the attributes from the app in the form of a buffer and sent it to the server?

It might be, but then we can't use the json library to encode struct json_obj_descr json_cfg_descr, only for struct json_obj_descr json_cfg_data_descr. As it is currently not possible to add a already encoded object to a json_obj_descr.

@d3zd3z should I put the change of the json lib into a seperate pr?

@ycsin With #70383 I want to go back to let the user encode struct json_obj_descr json_cfg_descr instead of just struct json_obj_descr json_cfg_data_descr, because it only contains of data and mode and no internal stuff has to be exposed. So the user can also set the mode and we don't need the change in the json lib.

just a rebase to resolve conflicts

The approach in this PR should work, I just wonder if we can keep the default implementation simple (only send device_id) but provide more flexibility by having a mechanism (another step or public function, if enabled) to "merge" any custom attributes to the record in the server.

As sending the device_id as VIN is not required by hawkBit. hawkBit doesn't use for anything special. If the user doesn't want to send that, he should be able to do so.

The approach in this PR should work, I just wonder if we can keep the default implementation simple (only send device_id) but provide more flexibility by having a mechanism (another step or public function, if enabled) to "merge" any custom attributes to the record in the server, i.e. the reason of last reboot (reset cause), die temp, stack watermark, ...

This problem is that the device attributes are only send to the server if the server requests it. This normally only happens once. the hawkBit server will only request it again, if you go in the user interface and click there on Request attributes update. It could be done to send it without the server requesting but that's outside of the scope of this PR .

This patch works - Have you considered doing this kind of one time configurations during hawkbit_init by extending it to accept an config struct? The same idea can also applies to #68806

I would prefer to not do it that way, as most subsystems in zephyr are also using this separate approach when it comes to setting callbacks.

rebased to resolve conflicts


pkg/lock: Verify file exists after lock is taken

Flock syscall does not check if file/dir pointed to by given fd exists
before taking shared/exclusive locks after blocking for a while on
exclusive in case of taking a shared lock and vice-versa.
Here verification is done by matching inode number pointed to
by fd used for locking and new fd created by reopening the file.

@rktbot ok to test

Is there a specific issue this fixes? I can definitely believe there's somewhere this logic is wrong, but I'm curious if there's a motivating breakage.
I know it used to be wrong in the gc code, but that was fixed differently (via better error handling in its code).

Not sure what could be broken in rkt due to this bug but we are using lock package at Apcera and have found the bug where blocking calls to Flock return with successful lock even though file has been deleted i.e. fd used for locking points to a nonexistent file.

@shobhit85 I think you should rebase against current master.

Rebased against latest master.

Not sure why it's broken on semaphoreci.

@shobhit85 just a flake (no space left on device), I've re-triggered it.

Arguably the check being done here should be the caller's responsibility since the only way for it to be completely correct is for the caller to be aware of this possibility and handle it appropriately.

I think I agree with @euank here. In particular, if flock succedeed the caller is returned a fd, which in @shobhit85 case may point to an open-but-unlinked file/dir and can still be used to:

perform file/dir I/O on it
call fstat on it to check if device/inode/type/mode matches with some external reference

I don't see many other ways to eliminate such a race from within library code. The only improvement I can see right now to this module is to add additional functions which directly take an fd instead of internally performing a path-based open.

@euank @lucab  I agree there is still the race. But change is not to eliminate the race as this the caller's responsibility to check what actions have been taken on a file before it acquired the lock on it. Locks are advisory locks only.
The basic use case that this change is trying to fix is, let's say there are two threads, T1 and T2 and T1 has the lock on a file and doing something with it (may be deleting it). In meanwhile T2 is blocked on the lock (using fd referring the same file). As soon as T1 is done, T2 gets the lock (flock returns). T2 assumes file is there as lock is taken. Why? because caller asked for the lock using path.
As this library is path based, user is not aware (or should not require the awareness) of the internals that the lock is taken using fd and file being referred by the fd might be gone. So caller assumes locking would fail if path doesn't exist.
The race where third thread could still delete a file without taking a lock while T1, T2 are syncing on the locks, is still there because locks are advisory only. There is no race if threads in question are using locks to operate on a file.


Onedrive Js Sdk error

I got this error while trying to setup file picker
[OneDriveSDK Error] invalid format for client id '000000004C18C50E' - AAD: 32 characters (HEX) GUID
Please help, thanks you

@as247: If you are using the v7.0 picker SDK, you need to register a new app ID through the new Microsoft developer portal: https://apps.dev.microsoft.com

Thank you @rgregg . but it's need url in https, are we able to make it work on non https pages?

The new app portal requires HTTPS redirect URLs unless the URL is localhost. You can continue to use the v6.0 picker SDK if you need a non-HTTPS end point.


Allow --async-only to be satisfied by returning a promise

The --async-only flag is intended to catch programmer error where omitting the done callback from the test function arguments causes it to become a synchronous test instead, that does nothing. However, it complains if the test returns a promise, which is unhelpful/unusable when using promises or a mix of async (callback) functions and promises.
This PR proposes changing the behavior of --async-only so that it only fails if the function does not accept a done callback or return a promise. This makes the flag even more useful since forgetting to return a promise will now report an error when using --async-only.
This results in a slight change to the behavior of --async-only: instead of failing immediately for synchronous functions, check to see if the test function returned a promise (or otherwise failed due to an assert, etc) before complaining about not having a done callback.

+1

I would consider this a breaking change since return value was previously disregarded. Specially since some languages than compile into JS (eg CoffeeScript) automatically return in the last line of functions.

+1 from me.

+1 from me as well :)
@dasilvacontin I might be entirely wrong here, but I'm thinking this would only require a minor revision bump. Maybe even just a patch.
It doesn't seem to be breaking backwards compatibility for languages like coffeescript as it only affects the result of returning a promise when using the option. Any javascript/coffescript test that returned a value other than a promise will continue to get flagged when using --async-only. Any test that returned a promise, however, will no longer be incorrectly labeled as not accepting a callback - since they do (https://github.com/mochajs/mocha/blob/ca84810498fe1b32d2ab237b1f0b98db4a9f9da5/lib/runnable.js#L267-L275) I'd see this as fixing a bug.

@mochajs/owners any thoughts on this?

It doesn't seem to be breaking backwards compatibility for languages like coffeescript as it only affects the result of returning a promise when using the option.

True, I think I didn't look at the code enough. LGTM. minor?
Reminder to update documentation if this gets merged.

@mochajs/mocha
OK, I've created branch v2.3.0 for the next major, and merged this via 7be4891412.

next major

minor?

@dasilvacontin minor :smile:

:shipit:


Missing documentation on the creation of Applications

It seems that there is no API documentation, UI or sample query that makes apparent how an application is created.
Any help would be appreciated.

Hey @wleese - we have a microsite for Iris at http://iris.claims which has an example application integration (http://iris.claims/docs/nagios.html) does that help or were you looking for more information?

Not quite. I’m specifically looking for how application keys are created.

Related to #281. Better docs are definitely needed for this setup. Applications can be created from the Iris frontend UI by any admin user (for example, the user "demo" in the dummy data). By logging in with an admin user, a "create application" button should appear in the top right of the Applications tab. This allows you to create an application and access its associated API key.
I'll try to expand on this blurb and give it a home in our official docs, but hopefully that should be enough to get you started.


Update architecture.md

Update to align definition of enterprise-scale with what we have in pptx and other documentations

@krnese : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Merged to master via a different PR.


Fix hydration of server functions that return strings with backticks in them (in development)

If a server function returns a string with a backtick in it, or an object that contains such a string, hydration will fail due to the backtick not being escaped in a console.info that only gets logged in development.
Fixes #2510

I'm facing a similar issue: ##2725
In my case is due to some routes having an id like show/2/${} which breaks as well with the console.info(...) as ${} is an invalid character.
I've created another PR #2726 which I think it fixes this issue and mine.

closed in favor of #2726


skpm link should autodetect local plugin?

I spent a few minutes trying to find out the right path argument for skpm link. I think it would be nice if it autodetected that it's being run in a plugin development folder, and do the right thing automatically (i.e: make skpm link do a skpm link . under the hood if you run it on a project folder).
Apologies in advance if I'm not making myself very clear, coffee hasn't kicked in yet : )

Oh yes good idea, I suppose it's the most common use case

fix in https://github.com/sketch-pm/skpm/commit/d0388a6136d9411824d66ace2db9e7035c3d7337

👏👏👏


draft/Castillo neurosity

add: draft of neurosity in jp and en
fix: citation and title
change: draft content
chore: update both translations

LGTM! Always thanks to you 🙏


how to prevent toasts when not in development mode

I'd like to turn off the toast when I'm not in development mode.  e.g turn off toast when deployed to prod I can't figure out how to do that.

You can do this however you want. You can check domain, or something else to prevent toasts.
Its outside of the bounds of the toastr library to figure out when/where you want to toast, though.


Trouble with irl use of train.py script

Hey, you should really work on learning parametres, coz what I got using your default train.py was just kinda very unstable validation loss (jumping literally from 0.01 to 2.0+) during the whole learning process. It makes model unable to be used in real situations..

First is your variant, but isn`t my result better? Or you just threw that script like a template?

@

Hey, you should really work on learning parametres, coz what I got using your default train.py was just kinda very unstable validation loss (jumping literally from 0.01 to 2.0+) during the whole learning process. It makes model unable to be used in real situations..

First is your variant, but isn`t my result better? Or you just threw that script like a template?

Your approach is better Can you share the model you used while obtaining these results


CLI mode

Example:
Function phpinfo() has different output between cli and cgi.
But laravoole is running under CLI mode, so far I think avoiding these functions is the only way.

So I cannot get the point of this issue... Could you explain it?

phpinfo() outputs plain text instead of HTML when using the CLI mode.
Function phpinfo() has different output between cli and cgi.
So avoiding using these functions is the best way.

Issue is not comment or document. This should be a wiki or a PR.


The ID 0x273 for child door lock ?

Hello, I'm looking for child door lock，but it is not find data in ID 0x273.  What id is for it?  Thanks.

Should be?
SG_ UI_childDoorLockOn : 16|1@1+ (1,0) [0|1] ""

Should be? SG_ UI_childDoorLockOn : 16|1@1+ (1,0) [0|1] ""

How decode it? Thanks.


Update synergy to 1.8.4,a6ff9079

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

Turns out this is incorrect. Apologies! I was so excited that I was able to get the submitter running.
The cask-repair downloaded an html file and checksummed that instead of the dmg.


ES6 Example

I was trying to get this to work with ES6 - Heres how:
Might be helpful for others if in the readme.
import { Client as client} from 'coinbase';

var coinbase = new client({
    <connection stuff here>
});

@redcap3000  I got client is not constructor, can you help?


Pickup Delivery Problem Question

Hi,
I'm currently working on the implementation of PDP using C# and I have some issues.
In my use case I have a list of orders with pickups and deliveries which should be made by the same vehicle along the same route (no depot).What I want to achieve through my implementation is :

Minimize the number of vehicles used to deliver all orders. I achieved this by using SetFixedCostForAllVehicles. However I noticed one issue when unit testing this.
If the weight matrix has same distance/time between all nodes or the difference between the distance/time values is very small. The minimization of total number of vehicles fails. For 10 orders I have a solution with 10 vehicles even if I could deliver all with just one vehicle.
Max time for a vehicle to complete the job to be 4h or around 4h.For this I used SetMax on the CumulVar for the time dimension I have setup. However in some scenarios if it's more optimal I would like to allow the algorithm to group the orders for more than 4h let's say 4h and 17 min. The SetMax it's a hard limit now and I would like to have a coefficient of flexibility.
Min time of the job to be 2h for a vehicle. I tried to use SetMin on the CumulVar of the time dimension but in this case when using SetMin and SetMax it returns no solution.
In this case the algorithm should be intelligent enough to balance the orders in routes between 2h and 4h but to be flexible.

Use case exemple:
I have 10 orders and 8 orders can be delivered in 4 hours and 2 orders in 1 hour.
My current implementation will distribute these orders to two vehicles one for 4h and one for 1h.
I would prefer that the algorithm distributes them to 1 vehicle for 5h or for 2 vehicles with 2.5h instead.
Any indication on this it will be highly appreciated.
Thanks,
Ionut

Increase the penalty.
Use soft upper bounds.
Not sure there is always a solution for these. Maybe a soft lower bound somewhere.


Images

So I've run into a bit of a wall with background images in sass loader. They are being encrypted in base64 and I can't seem to get them to link up correctly. I know this isn't a sass loader project, but was wondering if you had any recommendations on what to use along side it for the react-slingshot setup?

Should probably explain a bit more:
I am putting some background images in my scss files and running this in my config.
const getLoaders = function (env) {
  const loaders = [{ test: /\.js$/, include: path.join(__dirname, 'src'), loaders: ['babel', 'eslint'] },
  {
     test: /\.(jpe?g|png|gif|svg)$/i,
     loaders: ['file']
   }

   ];

  if (env === productionEnvironment ) {
    // generate separate physical stylesheet for production build using ExtractTextPlugin. This provides separate caching and avoids a flash of unstyled content on load.
    loaders.push({test: /(\.css|\.scss)$/, loader: ExtractTextPlugin.extract("css?sourceMap!sass?sourceMap")});
  } else {
    loaders.push({test: /(\.css|\.scss)$/, loaders: ['style', 'css?sourceMap', 'sass?sourceMap']});
  }

  return loaders;
};

what i am getting is a an image with a dynamically generated name that links to an image, but it is currently linking to:
.top-left {
    background-image: url(30898abe6ff41c413083cf5b7ef3a556.png);
}

right click to open in new tab and this is the url:
chrome-devtools://devtools/bundled/30898abe6ff41c413083cf5b7ef3a556.png
Which does not work. But if I go to:
http://localhost:3000/30898abe6ff41c413083cf5b7ef3a556.png
It works... so I am not sure what I am missing here.

Follow up, I was able to get around this by removing source maps from dev, which is a bummer. Any recommendations on how I can use sourcemaps with images in scss?

I can't imagine why the sourcemap would conflict. What gave you the idea that removing them would help?

I did a lot of googling and found some issues with image urls and libsass not playing nicely with sourcemaps. Another thing I found was an issue if the images are not relative to the sourcemap it can't find them, but I am not 100% sure on that being the cause. I'll see if I can find the issues I found again (got excited and closed all my windows). All I changed was this line:
old >> loaders.push({test: /(\.css|\.scss)$/, loaders: ['style', 'css?sourceMap', 'sass?sourceMap']});

new >>  loaders.push({test: /(\.css|\.scss)$/, loaders: ['style', 'css', 'sass']});

Love the project, my fav react starter so far!

I am wondering if I need to add anything to the build tools to copy over the images. They seem to be broken now. I reverted to using sourcemaps.

@waltercolindres Can you get latest and try again? The webpack config now handles images, so I suspect this will resolve your issue.

Ok, so interestingly, that fixed it if I do a npm run build. However, npm start still has it as a missing background image. So in prod it works, in dev the image is missing.
Is still produces an image link for dev:
.top-left {
    background-image: url(30898abe6ff41c413083cf5b7ef3a556.png);
}

When I right click the image goes here which is un-viewable:
chrome-devtools://devtools/bundled/30898abe6ff41c413083cf5b7ef3a556.png

But is viewable here:
http://localhost:3000/30898abe6ff41c413083cf5b7ef3a556.png

Another issue I've run into is that the images directory is not copying over during npm run build. Where can I place that command? They work fine during npm start/dev but once I do a build, they fall out. I can see that the images folder is not being copied over. So my inline images work in dev, but they don't get copied over for production. Which is ironic considering the first issue. :smile:
Screen of my directory setup:

Screen of my dist:

It looks like you're two steps away from success:

Try using an absolute path for your image. I assume you're currently not providing a leading slash.
Add a build step to copy the images folder. Check /tools/buildHtml.js for an example of how I'm migrating the HTML file. Same idea.

Thanks for you help Cory, definitely getting close.. This looks to be an issue with the style loader: https://github.com/vuejs/vue-loader-example/issues/43
I will close this!


subdomain redirects to www

Excuse me if im missing something here but won't this config always redirect to www.example.org, regardless of subdomain?
# non-www, subdomains redirect
server {
        listen 443 ssl http2;
        listen [::]:443 ssl http2;

        server_name .example.org;

        # SSL
        ssl_certificate /etc/letsencrypt/live/example.org/fullchain.pem;
        ssl_certificate_key /etc/letsencrypt/live/example.org/privkey.pem;
        ssl_trusted_certificate /etc/letsencrypt/live/example.org/fullchain.pem;

        return 301 https://www.example.org$request_uri;
}

This is the default if you want both www redirect and a cdn(or any cdn for that matter)
Should it not be server_name example.org instead of .example.org

Hello @eevahr!
Yes this configuration will redirect all *.example.org and example.com to www.example.org.
There is a precedence order:

exact name
longest wildcard name starting with an asterisk, e.g. “*.example.org”
longest wildcard name ending with an asterisk, e.g. “mail.*”
first matching regular expression (in order of appearance in a configuration file)

(http://nginx.org/en/docs/http/server_names.html)
So if there is an example.com or cdn.example.org block defined it should has a higher priority (and the redirection block lower).


Close connection if there is no response on auto ping

I it possible to add possibility to automatically close websocket connection it there is no pong response to the auto ping?
This would be useful to close broken connections.
For example it could be implemented like this:

idle timeout reached;
send auto ping;
if pong or other data was received - ok, do nothing;
second idle timeout reached - if no data was received between two idle timeouts - close connection;

It does that now since v19, auto send ping before idleTimeout  and close connection if no response

Ah, perfect
thank you


Assassins Creed

you can assign 4 cores to all tasks but not to TaskThread1, TaskThread2 and TaskThread3, are the main threads and if you assign more than one core per task the game not launches

You also can't assign more cores to "NGSUpdateTrhead". Othewise the game will crash at startup. I did some comparisons (running the game @544p). There is no advantage running it with Thread Optimizer. The framerate will stay completely the same (20-25 fps). Bottleneck seems to be the GPU.

Some games are programmed in way that editing attributes of some threads may break them. That is true for affinity, and especially for priority.


Voting always open

I'm not sure what you mean with this ticket. Talk voting depends on the setting on the conference object and various other criteria defined in the settings helper CONFERENCE_VOTING_OPENED().
For super users, talk voting is always possible, regardless of these settings.

Oh, my bad then!


Fix spectating for LTS

This change by @Khalmee adds spectating to LTS, and fixes https://github.com/R2Northstar/NorthstarMods/issues/501.
This might not be the best place to put the fix in, so feel free to change things around if needed

I'll take a proper look at the scripts later today (after work)
I find it weird that we aren't already doing InitialisePrivateMatchSpectatorPlayer

The changes are relatively small, can we recreate this PR, and use a branch instead? Forking across github orgs turned out to be a great pain

ohhhhh yeah i didn't realise you used your main branch for this.
yeah feel free to recreate the PR on a different branch

@GeckoEidechse
@ASpoonPlaysGames
You should be able to change it now, I moved it to my personal repo

Note to self, on merge, add
Co-authored-by: Khalmee<EMAIL_ADDRESS>

This should probably be moved over to GameStateEnter_Prematch (scripts/vscripts/mp/_gamestate_mp.nut)

I have given code review, just waiting on changes

This should probably be moved over to GameStateEnter_Prematch (scripts/vscripts/mp/_gamestate_mp.nut)

I have given code review, just waiting on changes

whoops, I overlooked that, my bad, will do the change myself rq ^^


update education, experience, and projects.

Codecov Report

Merging #61 (2191f9d) into master (79ee062) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #61   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           23        23
  Lines          223       223
  Branches        49        49
=========================================
  Hits           223       223

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79ee062...2191f9d. Read the comment docs.


md2Datepicker, minute select on IE 11 displays full timestamp

Bug, feature request, or proposal:
BUG
What is the expected behavior?
It should display numbers from 0 - 55 incremented by 5 per steps
What is the current behavior?
It displays a full timestamp "31/12/2016 00:55:00"
What are the steps to reproduce?
Open it in IE 11
Which versions of Angular, MD2, OS, browsers are affected?
Angular 4
md2: 0.0.25
Windows
IE 11

Same workaround for this ticket as for https://github.com/Promact/md2/issues/261
'this.dateLocale.minutes = this.range(60, i => String(i));'


Aborted (Core Dumped) while running aquatone-scan with --ports huge on starbucks.com

Can you post a screenshot of the error after it happens? I've scanned starbucks without issues.

@ojaschauhan44 Have you tried the xvfb-run solution that's been posted in numerous other issues filed in this project?

Yes i tried the solution but still same error.
There is even a issue thread for the same but no solution


Can't export to ONNX

When running python tools/export_onnx.py -expn=yolox-tiny and actually, whatever the experiment name, I always get the error below, and thus I can not run the script. Would you have any idea if I am doing something wrong?
AssertionError: plz provide exp file or exp name.

Thanks in advance!

changed line 56 in export_onnx.py to
exp = get_exp(args.exp_file, args.experiment_name)

any help? l also have this question


More built-in rules

Potential sources:

https://github.com/svenjacobs/leon/tree/main/core-domain/src/main/kotlin/com/svenjacobs/app/leon/core/domain/sanitizer
https://github.com/jparise/chrome-utm-stripper/blob/master/background.js
https://github.com/Smile4ever/Neat-URL/blob/master/data/default-params-by-category.json
https://github.com/lyubomyr-shaydariv/uu-webext/tree/master/src/modules
https://raw.githubusercontent.com/DandelionSprout/adfilt/master/LegitimateURLShortener.txt
https://github.com/brave/adblock-lists/blob/master/brave-lists/clean-urls.json
https://tarnhelm.project.ac.cn/rules.html
https://github.com/AdguardTeam/AdguardFilters/blob/master/TrackParamFilter/sections/general_url.txt
https://github.com/ClearURLs/Rules/blob/master/data.min.json

I would also like added support for AMP URLs. See the AmputatorBot project on GitHub or at https://amputatorbot.com for more details.

I would also like added support for AMP URLs. See the AmputatorBot project on GitHub or at https://amputatorbot.com for more details.

Discussion of AMP links has been broken out into issue 25.


Add optional bool to Command.call to bypass printing command to chat

Added by: https://github.com/The-Acronym-Coders/ContentTweaker/commit/211fac561daa40c1a9ee6f8d9cd420caaa773895


Missing partial in signups#create

Originally created by Tom Smyth at 2015-11-21 21:36, migrated from redmine-#3671

Status changed from New to Closed

By Tom Smyth at 2015-11-22 21:15


Ignore extraneous attachments

If there's an image and another thing (such as a PDF) in an emoji reaction scrapbook message, scrappy should post just the text and the image, while ignoring the PDF.

@karmanyaahm thanks for this - can you please do me a favor and describe the current (incorrect in your opinion) behavior, and the exact expected result?

Actually I'll make a PR this weekend, should be pretty easy

Just FYI I reproduced it here:
https://hackclub.slack.com/archives/C0536PRJWA0/p1701418217317499
https://hackclub.slack.com/archives/C0536PRJWA0/p1701418246639279
These two messages have the same attachments (one valid, one invalid), just in different order. One successfully gets scrapbooked, the other doesn't.
I'll fix the upload validity logic and send a PR.

oops sorry, will get to it asap


ERROR: LoadError: UndefVarError: map_splits_to_tree not defined

Hi TreeKnit team,

Thanks for this great approach!

When I am testing the TreeKnit on Mac mini (M1 chip) and MacBook pro (M1) by using the example tree files - tree_h3n2_ha.nwk, tree_h3n2_na.nwk. Both of two platforms generated the same error: “ERROR: LoadError: UndefVarError: map_splits_to_tree not defined.”

Does anyone know the solution? Thank you in advance!

/Users/xmwei/.julia/packages/TreeKnit/gOfL1/src/cli.jl:93 [Info] Parameters: OptArgs
γ: Float64 2.0
itmax: Int64 15
likelihood_sort: Bool true
resolve: Bool true
seq_lengths: Array{Int64}((2,)) [1, 1]
nMCMC: Int64 25
Tmin: Float64 0.05
Tmax: Float64 1.0
nT: Int64 100
cooling_schedule: Symbol geometric
Trange: Array{Float64}((101,)) [1.0, 0.9704869503929601, 0.9418449208830277, 0.9140482050108684, 0.8870718549931568, 0.8608916593317348, 0.8354841210835904, 0.8108264367721563, 0.7868964759210002, 0.7636727611915388  …  0.06547306980281228, 0.0635407598457967, 0.06166547824839869, 0.059845541929811855, 0.05807931748207713, 0.05636521970408556, 0.05470171017884719, 0.053087295892748944, 0.05152052789556264, 0.05000000000000001]
sa_rep: Int64 1
verbose: Bool true
vv: Bool false
/Users/xmwei/.julia/packages/TreeKnit/gOfL1/src/cli.jl:95 [Info] Inferring MCCs...
/Users/xmwei/.julia/packages/TreeKnit/gOfL1/src/main.jl:75 [Info] Initial state: 41 naive MCCs
/Users/xmwei/.julia/packages/TreeKnit/gOfL1/src/main.jl:82 [Info] --- Iteration 1 (max. 15) - 100 leaves remaining ---
/Users/xmwei/.julia/packages/TreeKnit/gOfL1/src/main.jl:85 [Info] Running optimization to find MCCs...
/Users/xmwei/.julia/packages/TreeKnit/gOfL1/src/main.jl:86 [Info] Cooling schedule: geometric / Temperature values: 101 / Total of MCMC steps: 2500
/Users/xmwei/.julia/packages/TreeKnit/gOfL1/src/SplitGraph/SplitGraph.jl:70 [Info] Sorting 2 topologically equivalent configurations.
/Users/xmwei/.julia/packages/TreeKnit/gOfL1/src/SplitGraph/SplitGraph.jl:101 [Info] Comparing 2 configurations using likelihood
/Users/xmwei/.julia/packages/TreeKnit/gOfL1/src/main.jl:95 [Info] Found 8 new mccs.
/Users/xmwei/.julia/packages/TreeKnit/gOfL1/src/main.jl:99 [Info] Proceeding based on newly found MCCs...
/Users/xmwei/.julia/packages/TreeKnit/gOfL1/src/main.jl:152 [Info] Found mccs do not cover all leaves. Pruning them from trees.
/Users/xmwei/.julia/packages/TreeKnit/gOfL1/src/main.jl:174 [Info] Resulting trees have incompatibilities (14 naive mccs left). Continuing.
/Users/xmwei/.julia/packages/TreeKnit/gOfL1/src/main.jl:82 [Info] --- Iteration 2 (max. 15) - 75 leaves remaining ---
/Users/xmwei/.julia/packages/TreeKnit/gOfL1/src/main.jl:85 [Info] Running optimization to find MCCs...
/Users/xmwei/.julia/packages/TreeKnit/gOfL1/src/main.jl:86 [Info] Cooling schedule: geometric / Temperature values: 101 / Total of MCMC steps: 1875
/Users/xmwei/.julia/packages/TreeKnit/gOfL1/src/main.jl:95 [Info] Found 4 new mccs.
/Users/xmwei/.julia/packages/TreeKnit/gOfL1/src/main.jl:99 [Info] Proceeding based on newly found MCCs...
/Users/xmwei/.julia/packages/TreeKnit/gOfL1/src/main.jl:152 [Info] Found mccs do not cover all leaves. Pruning them from trees.
/Users/xmwei/.julia/packages/TreeKnit/gOfL1/src/main.jl:174 [Info] Resulting trees have incompatibilities (7 naive mccs left). Continuing.
/Users/xmwei/.julia/packages/TreeKnit/gOfL1/src/main.jl:82 [Info] --- Iteration 3 (max. 15) - 60 leaves remaining ---
/Users/xmwei/.julia/packages/TreeKnit/gOfL1/src/main.jl:85 [Info] Running optimization to find MCCs...
/Users/xmwei/.julia/packages/TreeKnit/gOfL1/src/main.jl:86 [Info] Cooling schedule: geometric / Temperature values: 101 / Total of MCMC steps: 1500
/Users/xmwei/.julia/packages/TreeKnit/gOfL1/src/SplitGraph/SplitGraph.jl:70 [Info] Sorting 2 topologically equivalent configurations.
/Users/xmwei/.julia/packages/TreeKnit/gOfL1/src/SplitGraph/SplitGraph.jl:101 [Info] Comparing 2 configurations using likelihood
/Users/xmwei/.julia/packages/TreeKnit/gOfL1/src/main.jl:95 [Info] Found 2 new mccs.
/Users/xmwei/.julia/packages/TreeKnit/gOfL1/src/main.jl:99 [Info] Proceeding based on newly found MCCs...
/Users/xmwei/.julia/packages/TreeKnit/gOfL1/src/main.jl:152 [Info] Found mccs do not cover all leaves. Pruning them from trees.
/Users/xmwei/.julia/packages/TreeKnit/gOfL1/src/main.jl:163 [Info] Resulting trees are compatible: final decomposition found. Stopping.
/Users/xmwei/.julia/packages/TreeKnit/gOfL1/src/cli.jl:98 [Info] Found 15 MCCs (runtime 2.005045834)
/Users/xmwei/.julia/packages/TreeKnit/gOfL1/src/cli.jl:102 [Info] Resolving trees based on found MCCs...

Can you try updating TreeKnit to v0.3.3? it should be fixed there.
You may have to re-build the package after updating to change the treeknit executable. Something like
]update # should update to v0.3.3
]build TreeKnit

Thanks! It works after updating TreeKnit to v0.3.3!

Great! I had made some changes to TreeTools (dependency), but had not pushed the new TreeKnit to the general registry ...
Thanks for your interest, hope you'll find TreeKnit useful !


⚠ Bofrost.lu has degraded performance

In 4129b36, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1534 ms

Resolved: Bofrost.lu performance has improved in a4b9059 after 13 minutes.


ERROR  Waiting for selector .//span[@data-name='notify-on-app']//input failed: Waiting failed: 20000ms exceeded

this error message popped up for the first time today - worked yesterday.
am using the latest version. thanks
ERROR  Waiting for selector .//span[@data-name='notify-on-app']//input failed: Waiting failed: 20000ms exceeded

hi there - should be fixed now


Feature integration tests

What does this PR do?
This PR is raised to implement the following features: 👍 :

[x] Add integration tests for all pages
[x] Fix N+1 query performance issue
[x] Use GitFlow to introduce new features
[x] Setup rubocop and stylelint linters

Description of the tasks completed 👇

[x] Add integration tests and Fix N+1 problem
[x] Install rails gem
[x] Use the linter tool that analyzes my source code to flag programming errors, bugs, stylistic errors, and suspicious constructs. 💯

How should it be tested
Clone the repository
git clone https://github.com/UbdaNam/Blogiverse.git

Navigate to the folder
cd Blogiverse

Checkout the branch
git checkout feature_integration_tests

Run migrations
rails db:migrate

Run tests
rspec spec/integration

BEFORE FIX

AFTER FIX

Thank you @tresorsawasawa for reviewing my PR


ng-model doesn't work with check box in 1.4.7 version

Hi
i have below code which works fine with 1.2.19 but doesn't work with 1.4.7. Let me know if something i have missed.

            With Binding:
            <input type="checkbox"
                   ng-model="sport.selected"
                   ng-true-value="YES"
                   ng-false-value="NO">

            Using ng-checked:
            <input type="checkbox"
                   ng-checked="sport.selected === 'YES'">

            Current state: {{sport.selected}}

Regards,
Sandeep

This is probably from c90cefe16142d973a123e945fc9058e8a874c357 which was a breaking change in 1.3. It looks like it isn't documented in the migration guide though...


Service Bus Send Message Action isn't populating dropdown

Describe the Bug
Expected Result:
Add "Send message" action from the service bus built-in action as below and use the 2nd queue as the queue input parameter.
Actual Result :
'Not able to use the 2nd queue as the queue input parameter as the drop is not showing the 2nd queue name.
Steps to Reproduce the Bug or Issue

Create a When Messages are available in queue - service bus action
Create a Send Message -  service bus action
In the Send Message action there is no populating of the "Queue/Topic Name" parameter dropdown

Workflow JSON
No response
Expected behavior
Expected Result:
Add "Send message" action from the service bus built-in action as below and use the 2nd queue as the queue input parameter.
Screenshots or Videos

Platform And Browser
all
Additional context
No response
AB#17036810

Vendors said this was fixed in the recent test pass, will verify


first rev with binary protocol support

this should give mctop binary protocol support.

will dynamically decide if the packet is binary or ascii protocol
first rev filters opcode 1, e.g. set to extract keys
also replaces unprintable characters with '~'

thank you etsy.

I confirm that it works on Ruby 1.9.2 and Memcached 1.4.17 on Centos 5. But I had to also apply this https://github.com/etsy/mctop/pull/24 to make it work.


Updated Dep installation for Windows

( go.equinox.io  ) link is dead, doesn't go anywhere.
What does this do / why do we need it?
This allows anyone to successfully install Go dep, I think people who would have been suffering like me would need this.
What should your reviewer look out for in this PR?
Whether this is worth it
Do you need help or clarification on anything?
Nope
Which issue(s) does this PR fix?
Gives users a new installation method that works.

@googlebot I signed it!

Dep was officially deprecated earlier this year, and the proposal to archive this repository was accepted. As such, I'm closing outstanding issues before archiving the repository. For any further comments, please use the proposal thread on the Go issue tracker. Thanks!

Understood, enjoyed every use of it. Go Mod now then.
Thanks for the update


Error: ENOTDIR: not a directory, mkdir on launch

VSCode Version: Update 1.50.1
OS Version: macOS 10.15.7 Catalina

Steps to Reproduce:

Download the latest version of Visual Studio Code from https://code.visualstudio.com/Download
Copy to the Applications folder
Invoke /Applications/Visual\ Studio\ Code.app/Contents/MacOS/Electron in the Terminal.

Result
[main 2020-11-06T01:03:28.640Z] Error: ENOTDIR: not a directory, mkdir

Does this issue occur when all extensions are disabled?: Yes

Running from source works. I'm assuming it's trying to create a directory somewhere it probably can't because of a configuration option somewhere.

Apologies: This was a broken symlink inside my ~/Library/Application Support/Code folder. I was hacking sync together before it was an official and I forgot about that.


Exit with with a non-zero code if cargo does so

Fixes cargo exit code handling. Fixes #627

Ah thank you, I'm away right now so have limited time to work on tarpaulin. I'll review this later tonight :+1:

Also if you update the changelog as well please :smile:

Cool all looks good to me :+1:


Getting a "TypeError: Cannot read property 'length' of undefined" in pwmetrics 2.0.0

Hi I've updated to pwmetrics 2.0.0  few minutes ago. wanted to test things afterwards but ran straight into the following error:
$> pwmetrics https://bloomberg.com
/Users/myuser/.npm_global/lib/node_modules/pwmetrics/node_modules/lighthouse/lighthouse-core/lib/log.js:111
    const maxLength = columns - data.method.length - prefix.length - loggingBufferColumns;
                                           ^

TypeError: Cannot read property 'length' of undefined
    at Function.formatProtocol (/Users/myuser/.npm_global/lib/node_modules/pwmetrics/node_modules/lighthouse/lighthouse-core/lib/log.js:111:44)
    at CriConnection.handleRawMessage (/Users/myuser/.npm_global/lib/node_modules/pwmetrics/node_modules/lighthouse/lighthouse-core/gather/connections/connection.js:111:9)
    at WebSocket.ws.on.data (/Users/myuser/.npm_global/lib/node_modules/pwmetrics/node_modules/lighthouse/lighthouse-core/gather/connections/cri.js:78:37)
    at emitTwo (events.js:106:13)
    at WebSocket.emit (events.js:194:7)
    at Receiver.ontext (/Users/myuser/.npm_global/lib/node_modules/pwmetrics/node_modules/ws/lib/WebSocket.js:841:10)
    at /Users/myuser/.npm_global/lib/node_modules/pwmetrics/node_modules/ws/lib/Receiver.js:536:18
    at Receiver.applyExtensions (/Users/myuser/.npm_global/lib/node_modules/pwmetrics/node_modules/ws/lib/Receiver.js:371:5)
    at /Users/myuser/.npm_global/lib/node_modules/pwmetrics/node_modules/ws/lib/Receiver.js:508:14
    at Receiver.flush (/Users/myuser/.npm_global/lib/node_modules/pwmetrics/node_modules/ws/lib/Receiver.js:347:3)

I've noticed afterwards that the recommendation changed from using npm for install to yarn. I've installed version 2.0.0 with npm. but thought it wouldn't make a difference in with which app you install a module. So is it recommended to uninstall pwmetrics and reinstall with yarn? i am running npm 4.2.0 and node 7.9.0 on osx 10.11.6 and Canary Version 60.0.3076.0. Cheers r.

Yes, please reinstall via yarn. See https://github.com/paulirish/pwmetrics/issues/101 and linked issue links for more information.

@pedro93 read this thread. but it puzzles me cuz so far i thought yarn would use the same node_module folder like npm. but it doesnt as i see now. think i have to read up more on that. and the error is the same but now for the yarn folder:
$> pwmetrics https://bloomberg.com
Launching Chrome
/Users/myuser/.config/yarn/global/node_modules/lighthouse/lighthouse-core/lib/log.js:111
    const maxLength = columns - data.method.length - prefix.length - loggingBufferColumns;
                                           ^

TypeError: Cannot read property 'length' of undefined
    at Function.formatProtocol (/Users/myuser/.config/yarn/global/node_modules/lighthouse/lighthouse-core/lib/log.js:111:44)
    at CriConnection.handleRawMessage (/Users/myuser/.config/yarn/global/node_modules/lighthouse/lighthouse-core/gather/connections/connection.js:111:9)
    at WebSocket.ws.on.data (/Users/myuser/.config/yarn/global/node_modules/lighthouse/lighthouse-core/gather/connections/cri.js:78:37)
    at emitTwo (events.js:106:13)
    at WebSocket.emit (events.js:194:7)
    at Receiver.ontext (/Users/myuser/.config/yarn/global/node_modules/ws/lib/WebSocket.js:841:10)
    at /Users/myuser/.config/yarn/global/node_modules/ws/lib/Receiver.js:536:18
    at Receiver.applyExtensions (/Users/myuser/.config/yarn/global/node_modules/ws/lib/Receiver.js:371:5)
    at /Users/myuser/.config/yarn/global/node_modules/ws/lib/Receiver.js:508:14
    at Receiver.flush (/Users/myuser/.config/yarn/global/node_modules/ws/lib/Receiver.js:347:3)

installed with yarn global add pwmetrics

@rpkoller thank you, I'm stomped :/ @paulirish could you have a look at this? The stack trace is relative to lighthouse

@rpkoller could you check what version of lighthouse you have in yarn/global? Until lighthouse releases a new version (there are a bunch of fixes we need for v2) we are using a commit specific version that @paulirish provided

~/.config/yarn/global/node_modules/lighthouse says i am running version 1.6.0

@rpkoller can you try and delete all entries in  ~/.config/yarn/global/node_modules/ and run
$ yarn remove global pwmetrics && yarn add global pwmetrics to force https://github.com/paulirish/pwmetrics/pull/110 to be included in the code?

@rpkoller can you reinstall? I've published v2.0.1 with fixes. Should be working for you.

@denar90  @pedro93 honestly speaking I would and want but somehow Yarn and me had a rough start. ;) Basically I am rather confused right now. I had yarn installed with brew a while ago. Never used it so far. Then I've installed pwmetrics with yarn add global pwmetrics as it was recommended for pwmetrics 2.0.0 and I've uninstalled the npm pwmetrics version beforehand. When I check ~/.config/yarn/global/node_modules/there are a bucketload of modules there aside pwmetrics which is the only dependency listed in ~/.config/yarn/global/package.json. When I am in my home directory and try to remove the old pwmetrics version I get:
$> yarn remove global pwmetrics
yarn remove v0.23.3
error No lockfile in this directory. Run `yarn install` to generate one.

Afterwards the pwmetrics folder is still present. So basically I am unable to remove pwmetrics folder inside the yarn global folder. And i am unsure if I am allowed to just remove the whole node_modules folder there. Cuz it seems it might contain modules for yarn itself as well. Always expected that yarn and npm share the same folder for the npm_modules.  Guess I need to read up a bit more the yarn docs beforehand I suppose.
p.s. I've noticed one thing right before I wanted to submit the comment. The yarn npm_modules contain also a Lighthouse folder. But I haven't removed the npm version yet. So that might be also a possible issue?

uhhhh bummer due to the fact that i never used Yarn so far actually I forgot about to add ~/.config/yarn/global/node_modules/.bin for the global bin folder to the path in my bash_profile. :/ Dumb oversight. With that in place it is working now flawlessly already with 2.0.0 . Found while going through the yarn issues on github. Sorry for the trouble. :( But never the less one question still persists on my end which would help understanding yarn quite a bit. does the global ``~/.config/yarn/global/node_modules/`folder contain each and every module yarn needs and uses and not only those installed by the user globally afterwards like with npm? And how do you handle things. are you using two global module bases alongside? npm AND yarn? or do you stick to one of them?

Glad to hear your issue is solved. We provide both npm and yarn installations but we advise using yarn as suggested in the repo readme. There was recently an issue with npm and us using a commit-specific version of lighthouse but that should be solved as soon as a new version of lighthouse is released (scheduled for the Google I/O). I will close this issue. Please comment if you feel anything is relevant is still not done for the original problem.


New Rule for breaking long string that breaks max-line-length rule for .kts file

Expected Rule behavior

I want use Ktlint to help me break long string in build.gradle.kts file instead manually do it to follow the max-line-length.
Add break and join the two string like this:
commandLine =
    (
        "adb -s $device shell am start -n com.google.android.horologist.mediasample" +
            "/com.google.android.horologist.mediasample.ui.app.MediaActivity"
        )
        .split(" ")

Additional information

Current version of ktlint:
source code:  build.gradle.kts

if (device != null) {
    task<Exec>("appLaunch") {
        (
            "adb -s $device shell am start -n com.google.android.horologist.mediasample/com.google.android.horologist.mediasample.ui.app.MediaActivity"
        )
            .split(" ")
    }
}

command: ktlint -F
result:
17:23:58.665 [main] INFO com.pinterest.ktlint.cli.internal.KtlintCommandLine - Enable default patterns [**/*.kt, **/*.kts]
/Users/ocen/test/build.gradle.kts:3:11: Exceeded max line length (140) (standard:max-line-length)

Summary error count (descending) by rule:
  standard:max-line-length: 1

I do not think that we can find an algorithm for that, that is supported by a majority of the developers. Should the string just be broken in the middle of word? Or only at a space? Or as in your example at a /. Personally, I would dislike such a feature, as I think it depends on the specific case whether (and if so where) I want to break such a long line.

The place where the string broke did not matter as long as concat them together after the algorithm. We can break it after it went out of the maximum length.
Why do I want this feature? I prefer not to have manual work here.

I do believe that most developers will strongely disagree with such approach. At least, I would really dislike it. I do understand that when you apply ktlint on an existing project with a lot of long lines (or when decreasing the max_line_length on a project that already uses ktlint) that it is annoying to clean up. But it is a one time effort.
If you really need this functionality, you can create a custom rule for it.


fix(esbuild): add typecast to fix TS error

Current dependencies on/for this PR:

main

PR #30   👈

This comment was auto-generated by Graphite.


how do you use re-formality within a table?

I have some tables that have editable cells. html tables don't accept nested .
how do you recommend handling this case with re-formality?

Probably, one of these suggestions might work for you: https://stackoverflow.com/questions/5967564/form-inside-a-table

that helps, thanks


Updating @azure/storage-blob from v12.5.0 to 12.6.0 is causing exceptions and breaking functionality

@azure/storage-blob:
^12.6.0:
Windows 10 Pro:
[ ] nodejs

14.15.1:

[ ] browser

name/version:

[ ] typescript

version:

Is the bug related to documentation in

[ ] README.md
[ ] source code documentation
[ ] SDK API docs on https://docs.microsoft.com

Describe the bug
Updating storage-blob to v12.6.0 from v12.5.0 is implicitly updating "core-tracing" to "1.0.0-preview.11". It is also removing reference to package "opentelemetry/api" thereby breaking already existing functionality. This is not a minor update as how the documentation claims it to be.
To Reproduce
Steps to reproduce the behavior:

Update npm package @azure/storage-blob to v12.6.0

Expected behavior
This update should not be a breaking change as it is claimed to be a minor update.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Exception Stacktrace:
TypeError: _a.context is not a function\n    at Object.getSpanContext (C:\Developer\Proje
ct\DataCatalog\node_modules\@opentelemetry\api\build\src\context\context.js:70:76)\n    at getParent (C:\Developer\Project\DataCatalog\node_modules\@opentelemetry\tracing\build\src\
Tracer.js:101:16)\n

Hi @subuv, thank you so much for creating this issue.
First, I am sorry for the disruption this must have caused you - I can imagine that it can be very frustrating!

I'd love to get a bit more information about your specific configuration - could you share the dependencies and depDependencies sections of your package.json file? Not everything is important, but what I am interested in is any dependency that is @azure/<package-name> besides storage-blob of course, as well as any dependency that is @opentelemetry/<package> . Their corresponding versions would be important here as well.
I see that the error is coming from @opentelemetry itself - to confirm: are you using distributed tracing in your application?
If you have a minimal repro that you can point me to, that would really help here.

Looking forward to hearing from you!
Maor

Attaching a snip of it here.

We do not. It is coming from a dependency package of @azure/storage-blob.
Apologies I cannot a repo here.

Hi @subuv
Is this issue blocking your scenario now? Do you have a workaround for it?
We'll try to have a repro in our local environment. Will update you with any progress.
Thanks
Emma

Seems related to #13798 although that issue references<EMAIL_ADDRESS>I tried reproducing this by starting with @azure/storage-blob 12.5.0 and upgrading to @azure/storage-blob 12.6.0 and running the same bit of code that lists blobs (see below) and did not run into this error.
@EmmaZhu - have you been able to reproduce this yet?
@subuv I'm really sorry for the disruption this has caused. Unforutnately @opentelemetry/api has been in beta for quite some time, which meant that our tracing support has been in beta as well. Now that @opentelemetry/api has stabilized at 1.0 we expect this to stabilize as well; however, we do not expect to break customers that are not using tracing and if we did - I'd like to get it fixed and resolved. But I am unable to reproduce this by following the flow I described above so I need some more information:
can you share a complete stack trace if you can reproduce this?
Also, what happens if you delete node_modules and package-lock.json and run npm install again - does it reproduce?
Finally, if you ran npm ls @opentelemetry/api - can you share the output?
Here's my code snippet that worked across storage blob upgrades:
import { BlobServiceClient } from "@azure/storage-blob";
import { DefaultAzureCredential } from "@azure/identity";

async function main() {
  const client = new BlobServiceClient(
    "https://malegestorage.blob.core.windows.net",
    new DefaultAzureCredential()
  );
  const containerClient = client.getContainerClient("test");
  for await (const blob of containerClient.listBlobsFlat()) {
    console.log(blob.name);
  }
}

main()
  .then(() => console.log("done"))
  .catch((err) => console.log(err));

Hi Emma/Maor,
Thank you for getting back on this. As of now it is not a blocker for us. I have the stacktrace from when i reported this, providing it here. But if openTelemetry/api update to a stabilized 1.0 is not causing this, i will try updating @azure/storage-blob again and see if i am able to reproduce this.
Stacktrace:
TypeError: _a.context is not a function
at Object.getSpanContext (/usr/app/node_modules/@opentelemetry/api/build/src/context/context.js:70:76)
at getParent (/usr/app/node_modules/@opentelemetry/tracing/build/src/Tracer.js:101:16)
at Tracer.startSpan (/usr/app/node_modules/@opentelemetry/tracing/build/src/Tracer.js:49:31)
at Tracer.tracer.startSpan (/usr/app/node_modules/diagnostic-channel-publishers/dist/src/azure-coretracing.pub.js:55:44)
at /usr/app/node_modules/@azure/core-tracing/dist/index.js:727:27
at BlockBlobClient. (/usr/app/node_modules/@azure/storage-blob/dist/index.js:20060:30)
at step (/usr/app/node_modules/tslib/tslib.js:143:27)
at Object.next (/usr/app/node_modules/tslib/tslib.js:124:57)
at /usr/app/node_modules/tslib/tslib.js:117:75
at new Promise ()
at Object.__awaiter (/usr/app/node_modules/tslib/tslib.js:113:16)
at BlockBlobClient.BlobClient.download (/usr/app/node_modules/@azure/storage-blob/dist/index.js:20051:22)
at download (/usr/app/src/azureBlob/blobStoreClient.js:31:59)
at tryBlobAction (/usr/app/src/azureBlob/keyResilientBlobStoreClient.js:60:18)
at retrieveBlob (/usr/app/src/azureBlob/keyResilientBlobStoreClient.js:19:18)
at getCurrentVersions (/usr/app/src/catalog/entityVersion/entityVersionManager.js:60:48)
at catalogLookupRequestAdapter (/usr/app/src/controllers/catalogLookupController.js:84:65)
at Layer.handle [as handle_request] (/usr/app/node_modules/express/lib/router/layer.js:95:5)
at next (/usr/app/node_modules/express/lib/router/route.js:137:13)
at requestValidatorMiddleware (/usr/app/node_modules/express-openapi/dist/index.js:93:25)
at Layer.handle [as handle_request] (/usr/app/node_modules/express/lib/router/layer.js:95:5)
at next (/usr/app/node_modules/express/lib/router/route.js:137:13)
npm ls @opentelemetry/api:

@hectorhdzg FYI - is this the same issue as #13798 and if so, would it be resolved by updating applicationinsights to 2.1.4?

@maorleger yes updating to applicationinsigths to 2.1.4 must solve this issue

Thanks for confirming! @subuv could you try applicationinsights 2.1.4 and see if it resolves your issue? If so, feel free to close this issue.

Updating to applicationinsights 2.1.4 has solved this issue. Thank you hector, maor and emma!

We seem to be facing the same issue reported above when attempting to use azure storage but:
a) none of the fixes seem to address the problem
b) this is impacting a production system
Our packages are currently:   "dependencies": {
"@azure/storage-blob": "^12.7.0",
"@opentelemetry/api": "1.0.2",
"@opentelemetry/tracing": "^0.24.0",
"acorn": "^6.0.0",
"applicationinsights": "^2.1.5",
The code where the context issue is being triggered is:
try {
const blobServiceClient = BlobServiceClient.fromConnectionString(xxxx);
const containerClient = blobServiceClient.getContainerClient(containerName);
const createContainerResponse = await containerClient.createIfNotExists();
if (createContainerResponse) {
return containerClient;
} else {
throw new Error(
Failed to connect to storage with connection string (${xxx}).
);
}
} catch (err) {
throw new Error(
Storage Connection Error (${err.message}, connection string: ${xxx}).
);
};
As you can imagine this is pretty urgent for us so any assistance would be appreciated.....

Hey @murphyliam - I can try to help but I am unfortunately unable to reproduce this with the packages listed above.
What I tried:
set the following package.json dependencies:
    "@azure/storage-blob": "^12.7.0",
    "@opentelemetry/api": "1.0.2",
    "@opentelemetry/tracing": "^0.24.0",
    "acorn": "^6.0.0",
    "applicationinsights": "^2.1.5"

run npm install
When I check for @opentelemetry/api I see they are all on the same compatible version:
validation main % npm ls @opentelemetry/api
<EMAIL_ADDRESS>/home/mleger/workspace/azure-sdk-experiments/validation
├─┬<EMAIL_ADDRESS>│ └─┬<EMAIL_ADDRESS>│   └──<EMAIL_ADDRESS>deduped
├──<EMAIL_ADDRESS>└─┬<EMAIL_ADDRESS>  └──<EMAIL_ADDRESS>deduped

Same with core-tracing:
validation main % npm ls @azure/core-tracing
<EMAIL_ADDRESS>/home/mleger/workspace/azure-sdk-experiments/validation
└─┬<EMAIL_ADDRESS>  ├─┬<EMAIL_ADDRESS>  │ └──<EMAIL_ADDRESS>deduped
  ├─┬<EMAIL_ADDRESS>  │ └──<EMAIL_ADDRESS>deduped
  └──<EMAIL_ADDRESS>
Finally, I run the code snippet you shared and all works as expected
I have a few questions for you:

Is this happening consistently or just in one environment?
Can you reproduce this locally?
If you can reproduce this locally (or can get on a machine where this error shows up), what is the output of npm ls @azure/core-tracing and npm ls @opentelemetry/api ?
Finally, if you can reproduce this locally, does deleting the package-lock.json file and the node_modules directory and then running npm install help with that at all?

Thanks!

Thanks for the quick response; I've duplicated this post in 16947 as realised this post has been flagged as closed....to answer you initial questions:

we have 2 azure environments where this has started happening, first noticed last week
local dev machines (both Windows 10 and OS\X) the problem does not occur

..to clarify the above, the local dev machines both point to the same azure hosted storage containers. Its only the Azure hosted container running the nodejs project where we start getting the exceptions; that is an ubuntu image hosted in an azure app service.


Request for LICENSE

Would love to have a permissive license for this repo. Thanks!

Just added Artistic LIcense 2.0; seems to just about fit our goals for this project (free to use and modify, but our version remains canonical)


shift not woking

Robotgo version (or commit ref):
Go version:0.100.10
mac os 12.0.1

Yes, I have the same problem
My system is windows 10

Use hook.KeyHold instead

Use hook.KeyHold instead

Thank you. I will try this method in my spare time


invalid code blocks

README.rst
The markdown directive “code-block” belongs to Sphinx. Because we do not use Sphinx any more this directive is invalid for us. The rst equivalent name of this directive is
.. code::
Please do not use “code-block” any more.

Hi Son,
by when can I get an update from you?
Thank you,
Thomas

Hello Thomas,
This issue is solved in the pull-request #45
Thank you,
Son


promote action

Github action to promote charm taken directly from grafana-agent-k8s.

Please fix the integration test errors prior to merging this

Closing as we have a new way of doing the workflows.


Not work email mask with sign _ in email and clearIncomplete = true

Do not work email mask with clearIncomplete = true, when email contains sign "_". The email clear after change focus. Without "clearIncomplete" all work fine.

@a13x3y ,
Tested with the current version and see no problem.


key with empty value not parsed correctly

When the value of a key is empty, I mean if after equal sign there is nothing but line break, whatever goes next is not highlighted properly.

Like here. Section 2 is not highlighted at all.

Based on https://stackoverflow.com/a/9491779/152142 it seems like a "null value" is allowed. So this is a bug.


Does arch get included in the cache key?

Thanks a lot for offering this, I've found it the simplest and best way to get crates installed!

We've recently started seeing some failures in our jobs. We run jobs on both macos-14, which using aarch64 and macos-latest, which uses x86. (So 14 is actually more recent than latest...)
It looks like the cache key is the same for both, even though the binaries aren't compatible:

macos-14 job: key: cargo-install-cargo-insta-1.38.0-a4f6b43f6bcdf44918ef
macos-latest job: key: cargo-install-cargo-insta-1.38.0-a4f6b43f6bcdf44918ef

We then get an error Bad CPU type in executable (os error 86), ref https://github.com/PRQL/prql/issues/4362
It looks like this should be covered by https://github.com/baptiste0928/cargo-install/issues/20; any ideas why the key seems to be the same?

Thanks @baptiste0928 !


sched module to schedule tasks

Would https://github.com/rubiojr/risor-modules/tree/main/sched/sched.md be a welcome addition to Risor's modules set?

Hi @rubiojr, yes!


hello

pls update the exe file for download , thank you

If you want pre-compiled you can use this
https://github.com/Flangvik/SharpCollection/blob/master/NetFramework_4.5_Any/SharpMapExec.exe


ERROR Campfire HTTPS status code: 404

Greetings,
I am trying to set up a new instance with heroku. Everything but campfire seems to be working. I figured out that I need to use the room ID and not the name, and I figured out that I needed to be logged out and not to use the same user as hubot. But still getting these errors:
2014-09-03T22:48:13.961121+00:00 app[web.1]: [Wed Sep 03 2014 22:48:13 GMT+0000 (UTC)] ERROR Campfire HTTPS status code: 404
2014-09-03T22:48:13.971905+00:00 app[web.1]: [Wed Sep 03 2014 22:48:13 GMT+0000 (UTC)] ERROR Campfire HTTPS response data:
HEROKU_URL:             http://pacific-citadel-xxxx.herokuapp.com
HUBOT_CAMPFIRE_ACCOUNT:
HUBOT_CAMPFIRE_ROOMS:
HUBOT_CAMPFIRE_TOKEN:
REDISCLOUD_URL:         redis://rediscloud:wwzxxxxxljoXjjclq@pub-redis-xxxxx.us-east-1-2.3.ec2.garantiadata.com:xxxxx
Is there any way to tell what URL it is trying to use?
Thank you.
-David

A few more ideas:

if getting a 404 from campfire when connecting, log the thing that was trying to be accessed. That might make it more obvious it's a subdomain
consider changing HUBOT_CAMPFIRE_ACCOUNT to HUBOT_CAMPFIRE_SUBDOMAIN

The issue seems fixed. The doc is actually explicit about the account being the subdomain and rooms being ids.


Upgrade to React 17

Fix #40

Is this a working fix?

Forked to https://github.com/imizaac/react-cursor-position


Final PR for version 1.0

For a presentable MVP for december the 9th, here are the needed functionalities to be completed

The experience system

The inventory system

The enhanced brain

The link between the levels

The shop must allow players to buy and sell items

The player can't overweight the inventory

Players can level up their characters when the requirements are met (number of experience

points)

The players can set the difficulty to either Easy (random choices), Moderate (AI from augmented tactics which selects the best set of commands to execute from 3-4 scenarios), Hard (Advanced brain making it's own decision based on the training) or Lunatic (Enhanced brain making its own decision based on the training).

To be presentable, of course, a 2D prototype must be done via either Unity or Urho3D

Problem with actual branch (FirstPrototype).. Will merge and make another PR.


Appetite for an All Python Version of Prowler?

Hey I've done some preliminary work in my branch on an engine that could consume yaml/json checks and do some of the checking necessary. Is there an appetite for an all python version of prowler?

Hi @chalbersma sure, that would be great, I can create a new branch and you can push your code there for testing. What do you think? Thanks!

btw, we have been thinking on the possibility to allow checks based on the AWSCLI in shell script and Boto3 with Python, that would be ideal to take advantage of the existing checks.

I would very, very much like an all Python version, and I'd be willing to help work on it. I'm wrapping Prowler with Python code for my own purposes as it is. :)

I would also be keen for a movement towards python and boto, and keen to help with the work

Ya make a branch I'll push what I have in and you can take a look and see if it something that makes sense.

Ok, I'm going to create that branch from master. We have been already working on that but I don't know the actual status since @angabini has been doing some work on it, you can see his progress here https://github.com/toniblyx/prowler/projects/3 in both "To Do" and "In Progress".
To be honest, my first concern and priority on this would be support for checks in python. I know that if the core is in python it could be faster but that is not a problem today since the way it works now doesn't stress the API limits.

Here is the branch https://github.com/toniblyx/prowler/tree/python-devel

Cool I'll make a pull with what I've got so far.

https://github.com/toniblyx/prowler/pull/587
Made this. It's a reasonably large amount of stuff. hunterkitty.py (a prowler; cheesy joke) is the entry point for things and it assumes that the user has a profile that "works" to run checks against.

Going to close this one since this is not a priority at this point.

Going to close this one since this is not a priority at this point.


Create a lazuli.config.json file

We should have a config file similar to how other tools do, to give a list of mods to install and where to get them.  This should also have practical things like Minecraft version number and whether to use stable or alpha releases so that we don't need to keep specifying these from the command line.
By default, lazuli install should install all mods in the file.

It would be neat to make this have the option of either a .js or .json file, to give the option of programmatically determining options.

I still need to test this with a .js file instead of .json.

Works great!


"Reserved for custom" should everywhere be "designated for custom"

See title.  We don't say "reserved for custom" because it undermines what we want reserved to mean.

pull request to address issue
https://github.com/riscv-non-isa/riscv-iommu/pull/41


Adds series generator and exercise

Hi, this PR is to add a new exercise for series, here is a link to the problem-specifications
I'm still learning Crystal, so feel free to point out anything that needs to be change or improved.
Thanks!

Rebased with master, updated rename file. Not other changes.


Windows VM Agent Status is not ready

What are the troubleshooting checks that could be done if the Agent Status is not ready for the Windows Server?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ab75f449-661d-bd1e-3ebd-61e2384a911a
Version Independent ID: e7c93a31-6076-26b8-a53d-d36df01ec6bc
Content: Azure Virtual Machine Agent Overview
Content Source: articles/virtual-machines/extensions/agent-windows.md
Service: virtual-machines-windows
GitHub Login: @roiyz-msft
Microsoft Alias: roiyz

@Jothi3125  Thanks for the question! We are investigating and will update you shortly.

@Jothi3125 The closest thing I have been able to find is the following doc:
https://docs.microsoft.com/en-us/azure/backup/backup-azure-troubleshoot-vm-backup-fails-snapshot-timeout#the-agent-installed-in-the-vm-but-unresponsive-for-windows-vms
Essentially, if the agent is not in a ready state, it is usually due to some corruption of the agent which can be resolved by simply manually reinstalling the agent. You can find the steps to do that here:
https://docs.microsoft.com/en-us/azure/virtual-machines/extensions/agent-windows#manual-installation
So all in all, not much troubleshooting to be done. If it is not working, you should reinstall it. If it is still not working after that, there is usually something wrong with the VM image itself which would require support to look into further.

@Jothi3125 I will close this for now. If you need further assistance or have other questions just let me know and we can always reopen and continue the discussion.


get_sha_range(): find the first commit correctly, add more tests

Previous changes broke the ability to properly find the first commit in straightforward PRs.
Rather than doing a complicated search for a commit with "base" as the parent, just choose the first commit in the list. EDIT see below
This PR also adds API fixtures from several more Ceph PRs to make sure we have this behavior down correctly.
It also introduces a new-fixtures.sh shell script to provide an easy way to quickly import more test data from real-life PRs in case we need to add more test cases here.

Isn't the github order of commits something wonky?  Or is [0] really guaranteed to be the first, even if [-1] isn't the last?

I did an experiment here: https://github.com/ktdreyer/pulltests/pull/1 and it seems that GitHub's "first" commit in its list really is the first commit, even after rebasing.

welp, I found a case where this  PR still gets "first" wrong:

Create file "A" in commit "A"
Create file "B" in commit "B"
Rebase so that "B" comes before before "A"
GitHub still lists "A" as the first commit

The key seems to be that "A" and "B" should be completely separate files.

I've reworked this PR now with several more fixtures.
Rather than doing a search for a commit with "base" as the parent, determine "first" by comparing the parents to the list of commits. In particular, search for a commit that does not have a parent in our current set of commits.
Raise RuntimeError if we couldn't find a "first" commit this way, or if this method results in more than one "first".
Raise NotImplementedError if the PR contains a merge commit, because git-cherry-pick is going to bail on this range anyway without the "-m" argument.

Tagged v1.2.0 with this change.


ENYO-2736 Don't call unspot() manually in pointerMode

Issue
When we select item of ExpandablePicker with pointerMode,
we lose spotlight focus if we do not move mouse cursor.
Cause
{{closeDrawerAndHighlightHeader}} unspot its focus manually and close picker
Due to that, it does not execute onDisappear routine of Spotlight.
Fix
Remove unspot().
Selected item will lose its focus naturally according to disappear routine of Spotlight
Enyo-DCO-1.1-Signed-off-by: David Um<EMAIL_ADDRESS>

Closing in favor of #2625


Move create and delete methods to Invitation section

POST Create invitation
/invitations/create
Body: {
"type": "apartment",
"email"<EMAIL_ADDRESS>"apartmentId": "1"
} OR
{
"type": "cooperation",
"email"<EMAIL_ADDRESS>"cooperationId": "1"
}
DELETE Delete invitation
/invitations/{id}

Hey team! Please add your planning poker estimate with ZenHub @BohdanLysenko @Sorex1992 @VladyslavZhigir


Render a HEA query in Optimade.Science

Hi, I believe, this adds some additional value for a reader.

Thanks @blokhin, this is useful! Before merging, has any progress been made on https://github.com/tilde-lab/optimade.science/issues/54? It looks like this breaks the response from odbx and Materials Cloud atm. I think perhaps the providers list you use could also be updated to include the latest databases.

@ml-evs please, merge :pray:

Hi @blokhin, thanks for your efforts updating optimade.science, will merge! Hopefully those providers where this query is still broken (AFLOW, NOMAD etc.) will fix it in time.

Also @blokhin FYI, the MPDS OPTIMADE API pagination links are not correct, they are currently provided as links->next_page rather than links->next so do not work with any of the Python-based clients (that I know of)