"env.configure(remotes=1)" failed with error info "gzip: invalid checksum"

Expected behavior
I followed the official tutorial try to run my first agent. It failed when I come to "env.configure(remotes=1)"
Actual behavior
Error info bellow:
[200220]yama@nuc:~$ python
Python 2.7.12 (default, Nov 19 2016, 06:48:10)
[GCC 5.4.0 20160609] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import gym
>>> import universe
>>> env = gym.make('flashgames.DuskDrive-v0')
[2017-01-07 20:34:29,186] Making new env: flashgames.DuskDrive-v0
>>> env.configure(remotes=1)
[2017-01-07 20:34:35,130] Writing logs to file: /tmp/universe-26960.log
[2017-01-07 20:34:35,143] Ports used: []
[2017-01-07 20:34:35,144] [0] Creating container: image=quay.io/openai/universe.flashgames:0.20.21.
Home-page: https://github.com/openai/universe
Author: OpenAI
Author-email<EMAIL_ADDRESS>License: UNKNOWN
Location: /home/yama/rl/universe
Requires: autobahn, docker-py, docker-pycreds, fastzbarlight, go-vncdriver, gym, Pillow, PyYAML, six, twisted, ujson
Classifiers:
---
Metadata-Version: 2.0
Name: gym
Version: 0.7.0
Summary: The OpenAI Gym: A toolkit for developing and comparing your reinforcement learning agents.
Home-page: https://github.com/openai/gym
Author: OpenAI
Author-email<EMAIL_ADDRESS>Installer: pip
License: UNKNOWN
Location: /home/yama/.local/lib/python2.7/site-packages
Requires: requests, six, numpy, pyglet
Classifiers:
---
Metadata-Version: 2.0
Name: tensorflow
Version: 0.9.0
Summary: TensorFlow helps the tensors flow
Home-page: http://tensorflow.org/
Author: Google Inc.
Author-email<EMAIL_ADDRESS>Installer: pip
License: Apache 2.0
Location: /usr/local/lib/python2.7/dist-packages
Requires: numpy, six, protobuf, wheel
Classifiers:
  Development Status :: 4 - Beta
  Intended Audience :: Developers
  Intended Audience :: Education
  Intended Audience :: Science/Research
  License :: OSI Approved :: Apache Software License
  Programming Language :: Python :: 2.7
  Topic :: Scientific/Engineering :: Mathematics
  Topic :: Software Development :: Libraries :: Python Modules
  Topic :: Software Development :: Libraries
Entry-points:
  [console_scripts]
  tensorboard = tensorflow.tensorboard.tensorboard:main
---
Metadata-Version: 1.1
Name: numpy
Version: 1.11.0
Summary: NumPy: array processing for numbers, strings, records, and objects.
Home-page: http://www.numpy.org
Author: NumPy Developers
Author-email<EMAIL_ADDRESS>License: BSD
Location: /usr/lib/python2.7/dist-packages
Requires:
Classifiers:
  Development Status :: 5 - Production/Stable
  Intended Audience :: Science/Research
  Intended Audience :: Developers
  License :: OSI Approved
  Programming Language :: C
  Programming Language :: Python
  Programming Language :: Python :: 2
  Programming Language :: Python :: 2.6
  Programming Language :: Python :: 2.7
  Programming Language :: Python :: 3
  Programming Language :: Python :: 3.2
  Programming Language :: Python :: 3.3
  Programming Language :: Python :: 3.4
  Programming Language :: Python :: 3.5
  Programming Language :: Python :: Implementation :: CPython
  Topic :: Software Development
  Topic :: Scientific/Engineering
  Operating System :: Microsoft :: Windows
  Operating System :: POSIX
  Operating System :: Unix
  Operating System :: MacOS
---
Metadata-Version: 2.0
Name: go-vncdriver
Version: 0.4.19
Summary: UNKNOWN
Home-page: UNKNOWN
Author: UNKNOWN
Author-email: UNKNOWN
Installer: pip
License: UNKNOWN
Location: /home/yama/.local/lib/python2.7/site-packages
Requires: numpy
Classifiers:
---
Metadata-Version: 2.0
Name: Pillow
Version: 4.0.0
Summary: Python Imaging Library (Fork)
Home-page: http://python-pillow.org
Author: Alex Clark (Fork Author)
Author-email<EMAIL_ADDRESS>Installer: pip
License: Standard PIL License
Location: /home/yama/.local/lib/python2.7/site-packages
Requires: olefile
Classifiers:
  Development Status :: 6 - Mature
  Topic :: Multimedia :: Graphics
  Topic :: Multimedia :: Graphics :: Capture :: Digital Camera
  Topic :: Multimedia :: Graphics :: Capture :: Screen Capture
  Topic :: Multimedia :: Graphics :: Graphics Conversion
  Topic :: Multimedia :: Graphics :: Viewers
  Programming Language :: Python :: 2
  Programming Language :: Python :: 2.7
  Programming Language :: Python :: 3
  Programming Language :: Python :: 3.3
  Programming Language :: Python :: 3.4
  Programming Language :: Python :: 3.5
  Programming Language :: Python :: 3.6
  Programming Language :: Python :: Implementation :: CPython
  Programming Language :: Python :: Implementation :: PyPy

This can happen if the network connection is interrupted in the middle of downloading the container.
Run
$ docker pull quay.io/openai/universe.flashgames:0.20.21

to download it manually, then try again.

thank you @tlbtlbtlb !  Is it up to date?

Today the file system of my computer crashed badly, which makes me to run the memory test. Then I found that one of my memory sticks was broken. The problem gone after I remove the broken one.....
@tlbtlbtlb I am sorry for the disturbance of this issue, and thank you very much for your kind reply!
And an additional advice, I think the installation guidence should include a step for installing go-vncdriver. I realized that I need to installe go-vncdriver, after I got the error message "go_vncdriver was installed without OpenGL support"


Evolve the joystick API

I believe we should have a higher level gamepad API, that works above the existing joystick events.
Rather than subscribing to be notified when a device hits a certain key, this API should allow for profiles in order to translate events into buttons, and (ideally) should allow polling, if you wish to see which controllers are connected, listen to specific controllers only, at any point in time, check the state of a particular controller, etc.
Partially this will require implementation in Lime, and will also require new APIs to manage it either at a Lime level or in OpenFL.

Not going to track TODO items as issues :smile:


would the following be possible? alasql.fn.

Hello ALASQL team,
Would the following be possible? Basically I am asking alasql to wait for async data to return
alasql.fn.getDocuments = function(name) {
	var array = name.split(',');
	Promise.all(array.map(
	function(v){
		return $.getJSON("/myoffice/_vti_bin/ListData.svc/Documents?$filter=Id eq "+v+"&$select=Name,Title,Id",
	   {},
	   function showData(data, status) {
	   })
	}));
};
var companyProcessStepsSource = alasql('SELECT CASE ProcessInputDocuments WHEN null THEN "" ELSE getDocuments(ProcessInputDocuments) END AS ProcessInputDocuments FROM ?', [companyProcessStepsColl]);

Kind regards,
Mario

Nope. wont work.
You are not returning any value. And even if you did an async call like this can not return values to the query as .fn functions are called sync.
its hard to find out what you are doing with a promise.all wihtout a ".then" (and avoid variablenames like array)

OK. Thanks.


Fix slim image to restore graph rendering, or stop distributing it

I don't think it's useful to distribute a variant that breaks graph rendering in Jenkins. At least the docs should be super clear about this. Per #536:

… openjdk-jdk-8-headless instead of the non-headless version.

Apparently fixed by https://github.com/jenkinsci/docker/pull/657 @MarkEWaite can you confirm?

Agreed.  This is fixed.  I ran the jenkins/jenkins:lts-slim image based on Jenkins 2.190.1 and confirmed that graph rendering works as expected.


Validate references internal to schema

Supports the basic case. Still to do:

Remote references
escaped pointers

That last commit has tabs in the code. Maybe text wrangler isn’t set to use spaces instead of tabs?

:+1:


Separate highlights for separate citations

Currently, sets of citations are highlighted together. For example, "(Head 2015, Skjonsberg 2012, Kirby 2008)" is usually considered to be one citation, with links to 3 paper.
Users requested that they want to be able to click on individual ones. They say that the current behavior is particularly annoying when the list of citations is very long.
The reason this hasn't yet been implemented is because we haven't yet found a way to instrument TeX in a way that will color each of the citations independently.

I implemented a fix that I think should work as of 669ba8ce400c4c7d3a250d100d6586f176552036. Proof:

See for yourself at https://s2-reader.apps.allenai.org/?file=https://arxiv.org/pdf/1811.12889.pdf
Fyi @kyleclo, who I think might be interested in knowing there was a way to fix this :-D!


⚠ Bofrost.lu has degraded performance

In 14e1274, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 2335 ms

Resolved: Bofrost.lu performance has improved in 4a8d4c3 after 47 minutes.


Improve finding existing controller & adding model

PR comments:
This is two changes that went together. I wanted to background creating a new model.
However, when testing, I would call 'destroy-model' on the current model and then try again without manually switching, this ended up bootstrapping a new controller even though the controller was already there. I looked at the controller_provides_ctype function and couldn't tell why it was comparing model types instead of just controller cloud names, since in the clouds screen we are picking cloud names, not models. It also calls switch, which calls login() (I didn't understand why it did that either), and login() fails if there is no selected model, because it tries 'juju status' to check if juju is 'available'. Juju status only works if there's a selected model.
Hopefully this change is an improvement, but I've only had time to test it on 'localhost' (LXD) clouds, so maybe the other code was there to work around issues on other clouds? Let me know!
Fixes #139.
commit log message:
Finds existing controller even if no current model or controller is
selected. Doesn't login(), so doesn't require 'juju status' to be
working to find a controller - it won't be if no model is selected.
Backgrounds creating new model on found controller, so UI is more
responsive. It's on the juju queue, so deploys will wait for add-model
to be done.
Signed-off-by: Michael McCracken<EMAIL_ADDRESS>

I'll fix the Travis ci failure


Add a command line utility

It would be nice if a command line utility was provided.
Like something that would behave in the same as git rev-parse --sq-quote ....
If you are ok with that maybe I can come up with a PR to add one.

If anyone wants to write such a utility they can use this package, but I will not be adding any new functionality to this package. Thank you for the suggestion.


.pylintrc "enable=..." has no effect

VSCode Version: 1.20.1
OS Version: Xubuntu 16.04

Steps to Reproduce:

Putting "python.linting.pylintArgs": ["--enable=F,E,W,R,C"] in .vscode/settings.json has desired effect
Putting "enable=C,R,W,E,F" in local .pylintrc has no effect. (To make sure that the .pylintrc file is being used I tried doing "disable" of the same categories, which had the the desired effect.

In other words: "enable" statement in .pylintrc seems to be neglected of overruled by default parameters. Which is not in accordance with the following documentation; https://code.visualstudio.com/docs/python/linting

I moved this issue the to python extension's repo. Please continue the discussion there:
https://github.com/Microsoft/vscode-python/issues/949


man pages use the wrong hyphens

Triggered by a47f50629357595ddb9064d304c2a0f5c2293374 which replaced the - in the man page with -
I think it's the wrong thing to do tbh. Can't see a difference in the man page but when converting to PDF, it puts a minus sign in, instead of a hyphen. Looks wrong tbh and http://man7.org/linux/man-pages/man7/groff_char.7.html says

the ISO latin1 ‘Hyphen, Minus Sign’ (code 45) prints as a  hyphen; a minus sign can be obtained with ‘-’.

Given the double meaning of "-" on the terminal, "minus minus help" or "dash dash help", we shouldn't be using the explicit minus sign. Definitely not on concatenated words like ratbag-command which is now rendered as "ratbag minus command"
cc @skitt, any comments?

From http://liw.fi/manpages/

An unfortunate bit of arcane syntax is that dashes in options should be prefixed by backslashes. Thus, write --bits, not just --bits. The Debian and Ubuntu implementation of man treats them the same, for terminal output, but this is not portable. Technically a naked - means a hyphen, whereas - means a minus sign. Typographically these are distinct, and they are also distinct in Unicode. The typesetter is free to break a line at a hyphen, but not at a minus. For dashes in options, you should thus use minuses, but in normal text, for normal words, the hyphen.

Ok, I guess we just need to be more fine-grained than the current approach which replaced all dashes.

The general rule covers a bit more than Lars’ description copied above — basically, anything that could be copied and pasted to a terminal command line needs to escape dashes. So in a47f506, the only incorrect escape that I can see is the one before KEY_A (possibly).
See Branden’s presentation (linked from Lars’ web page above) for much more on this, and recent discussions on the groff mailing list (starting here).

In particular see Branden’s suggested clarification patch: in manpages, backslash-hyphen encodes hyphen-minus, not minus.

the one in front of -KEY_A is an explicit minus (meaning "release"), so that's the one that's definitely correct. After reading through the presentation I reluctantly agree, the escaping is necessary, thanks.


fix(migrate): --create-only flag patch

Why?
currently, if you run prisma migrate dev --create-only and the DB schema is not equal to the scema.prisma the command will ask for a reset, and it will reapply all the migrations before analyzing the new changes required.
With this modification, when a developer uses the --create-only flag, prisma migrate will skip the DB resetting and applying any migration and jump ahead to finding the diferences between the current schema and the DB's schema...
motivation?
In the case a developer is working with an existing database and trying to start using prisma migrate for the first time, they will most likely be working with a local database already in place in their local environment populated with data, and calling prisma migrate dev --create-only as it is right now, it will ask for a reset deleting everything in the DB. It should allow for a review of the SQL migration file before doing anything.
useful? when?
To allow the development of a baseline migration quickly:

prisma db pull on an existing db to create the schema
prisma migrate dev --create-only to create the first "base" migration
prisma migrate resolve --applied XXX where XXX is the name of the migration created above

Also... let's be semantic here... "create only" should not produce a "reset" nor "apply" anything...

Making explicit that this is a BREAKING CHANGE. Can not just be merged without prior discussion and handling.

what whould be the breaking portion of my fix? what breaks? im curious...

Conflicts happen when the branch you are trying to merge into changes, leading GitHub to have trouble to figure out what code goes where.
My comment re "breaking change" was not because of that, but because the behavior of the CLI changes. We and our users could rely on that behavior in CLI setups and so on, so something like this could always only be released via a major release.

Indeed, changing this behavior will need to happen in a major release.
We are aware that this is a misleading flag (we have a label for it).
It's something we want to improve in a major version one day, but before we'll need to redesign it.
So your feedback is interesting for us, how you use Migrate in your workflow, what you expect, what's missing...
If you see other problems with Migrate, you can create an issue, we'll be happy to check that out!

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Appstudio update test-simple-build-mbrb

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI/test-simple-build-mbrb-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
13 seconds
init

✅ Succeeded
13 seconds
clone-repository

✅ Succeeded
24 seconds
build-container

✅ Succeeded
46 seconds
sbom-json-check

✅ Succeeded
44 seconds
deprecated-base-image-check

✅ Succeeded
9 seconds
clair-scan

✅ Succeeded
46 seconds
inspect-image

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
29 seconds
label-check

✅ Succeeded
5 seconds
show-summary

✅ Succeeded
6 seconds
show-sbom


Test on Python 3.13-dev

Looks like an import from typing.io that should come straight from typing.

Yes, I am not sure where it is coming from. I suspect it may be

 from importlib_resources._py3 import

https://github.com/python/importlib_resources/blob/main/NEWS.rst#v521

Technically, this should be a dependency requirement on ics_vtimezones, but probably fine to set it in our package.

Uh oh, they have a version pin :joy:
    ics-vtimezones 2020.1 depends on importlib_resources<2.0 and >=1.4

We had an issue with this before, but seems OK now — see https://github.com/scientific-python/yaml2ics/pull/89

According to SPEC0, we can drop 3.8 and 3.9 if we want to.

Feel free to revert that last commit if you want to keep 3.8, 3.9 support.
I couldn't find where to change the pyupdate language version; maybe not used for this project yet.

The only place we use this is pinned to Python 3.8 (netlify).

I couldn't find where to change the pyupdate language version; maybe not used for this project yet.

requires-python = ">=3.8"


moved ember-template-compiler to optionalDependencies

Hi again,
could you please merge this change to your head and release new version?
The change contains just package.json update where I moved ember-template-compiler dependency from dependencies to optionalDependencies.
This is needed in case someone will want to use custom ember preprocessor specified by new option emberPreprocessor and so dependency to ember-template-compiler is not required.
Thanks.

done and done :)
I just release 1.8.0 on npm - please give this a pull and let me know if all is good (when you have time)


when expose an HTTPS service Kiali does not show ingress-gateway

Bug description
I have an HTTPS service inside the mesh and want to expose it through ingress-gateway. I tried 2 scenario
1- scenario one(nginx ssl enabled)- termination at service:      gateway tls mode: PASSTHROUGH
a) VS
tls:

match:

port: 443
sniHosts:

nginx.skylinenet.net
route:

destination:
host: nginx-ssl-istio
subset: v1
port:
number: 443
b) DR  tsl mode.tls: ISTIO_MUTUAL
c) PA.   mtls.mode: STRICT
everything works fine and kiali shows ingress-gateway

Scenario two (nginx ssl enabled). termination at the gateway.    gateway tls mode: SIMPLE
a) VS
http:

route:

destination:
host: nginx-ssl-istio
subset: v1
port:
number: 443
b) DR.    tls.mode : SIMPLE
c) PA.    mtls. mode: PERMISSIVE or STRICT
I can hit nginx and everything seems work except that I can see unknown source instead of ingress-gatewat that is not reasonable (edited)
image.png
image.png

[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ x] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[ ] Upgrade
Expected behavior
Kiali should show ingress-gateway instead of unknown resource
Steps to reproduce the bug
1- deploy a nginx-ssl manifest
2- define gatewat tls.mode SIMPLE
3- DR.    tls.mode : SIMPLE
4- PA.    mtls. mode: PERMISSIVE or STRICT
Version (include the output of istioctl version --remote and kubectl version --short and helm version --short if you used Helm)
How was Istio installed?
rancher-istio
istio 1.9.5
k3s v1.19.11+k3s1
Environment where the bug was observed (cloud vendor, OS, etc)
on-prem cluster rancher k3s
Additionally, please consider running istioctl bug-report and attach the generated cluster-state tarball to this issue.
Refer cluster state archive for more details.

To get peer's node metadata, for HTTP, the sidecar needs to terminate TLS and get it from header. For TCP (like what you had in the second case, where ingress sends non-istio TLS), you'd need to wrap the stream with Istio mTLS in order to get network level metadata exchange.


Efficiency Problem:  Parallelization and vectorization

Is your feature request related to a problem or challenge?
I was doing a course project on efficiency comparison. And I try on  TPC-H benchmark to compare the efficiency between datafusion and duckDB. The results indicated that There might be some efficiency issues. I also noticed that the effective CPU use time of datafusion is much higher than DuckDB, but the runtime on TPC-H is slower(seems like we did not really do parallism and I really think that's some problem comes from Tokio)
This is DuckDB's result

This is Datafusion's result

Also the flame graph shows that datafusion has a much deeper stack.
duckDB

datafusion

I kind of generated some distrust towards Tokio.
I doubt whether the slower performance is due to incomplete use of SIMD instruction so I did some statistics on SIMD instructions using PIN(may be the result is not that precise, but I expected the number of SIMD instruction generated should be comparable), the results shows below

SIMD instruction
datafusion number
duckDB number

ADDSD
34
25

CMPSD_XMM
1
6

COMISD
-
44

DIVSD
14
32

MAXSD
1
1

MULSD
21
52

PACKUSWB
5
7

PADDB
30
12

PADDD
100
33

PADDQ
291
200

PADDW
8
5

PCMPEQB
548
544

PCMPEQD
58
38

PCMPGTB
-
1

PCMPGTD
44
14

PCMPGTW
-
6

PMINUB
8
20

PMOVMSKB
1169
278

PMULHUW
1
2

PMULLW
1
2

PMULUDQ
-
4

PSHUFD
646
88

PSLLD
6
2

PSLLDQ
72
217

PSLLQ
213
16

PSLLW
30
2

PSRAD
8
-

PSRLD
3
40

PSRLDQ
39
179

PSRLQ
11
7

PSUBB
84
243

PSUBD
4
3

PSUBQ
12
4

PSUBUSB
-
6

PSUBW
-
6

PUNPCKHBW
41
7

PUNPCKHDQ
45
66

PUNPCKHQDQ
102
14

PUNPCKHWD
42
50

PUNPCKLBW
211
19

PUNPCKLDQ
94
338

PUNPCKLQDQ
353
2713

PUNPCKLWD
73
80

ROUNDSD
1
-

SHUFPD
4
20

SHUFPS
-
28

SQRTSD
-
2

SUBSD
10
19

UCOMISD
16
39

VPCMPB
56
86

VPCMPUB
206
19

VPMINUB
2
15

Total
4851
5293

Turns out that datafusion may use less SIMD instructions than DuckDB (that might be the rustc problem)
Describe the solution you'd like
I plan to do this week after next after. But got no clues yet
Describe alternatives you've considered
No response
Additional context
No response

@alamb I am kinda stuck here, could you please provide some clues about this one? Thanks

probably related: #5942

My current plan for this is to generate a vectorization instruction coverage in CI/CD to track the usage of SIMD instructions. Also I think tokio may got some bugs for this.

Hi @Lordworms  -- thank you for this analysis.

(seems like we did not really do parallism and I really think that's some problem comes from Tokio)

I do not agree with this statement in general (though it may be that TPCH parallelism could be improved), -- DataFusion uses a signfiicant amount of CPU / parallelism and while tokio results in more complicated stack traces for sure, I think overall the benfits are worth it.
We did a comparison of DataFusion and DuckDB in our upcoming SIGMOD paper (https://github.com/apache/arrow-datafusion/issues/6782) DataFusion_Query_Engine___SIGMOD_2024.pdf where we compared single core efficiency and scaling (see the results section). We found areas that each engine did better in.
If your goal is to improve the performance of DataFusion in the TPCH queries I have some thoughts:

The TPCH benchmark has many large joins. Thus the efficiency of the both the join plans and the join operators (e.g. HashJoinExec) is important for good TPCH
The level of optimization that has been invested into DataFusion joins is relatively low compared to aggregationing and filtering (see https://github.com/apache/arrow-datafusion/issues/8398 for a list of potential ideas)

I run DF on a c7i.48xlarge instance type in aws (192 cores, 384GB RAM) and during my processing I'm seeing almost 100% cpu usage across the board. So parallelism in my usecase is essentially perfect - though I can't speak for the efficiency.

I run DF on a c7i.48xlarge instance type in aws (192 cores, 384GB RAM) and during my processing I'm seeing almost 100% cpu usage across the board. So parallelism in my usecase is essentially perfect - though I can't speak for the efficiency.

Yes, I runed

Hi @Lordworms -- thank you for this analysis.

(seems like we did not really do parallism and I really think that's some problem comes from Tokio)

I do not agree with this statement in general (though it may be that TPCH parallelism could be improved), -- DataFusion uses a signfiicant amount of CPU / parallelism and while tokio results in more complicated stack traces for sure, I think overall the benfits are worth it.
We did a comparison of DataFusion and DuckDB in our upcoming SIGMOD paper (#6782) DataFusion_Query_Engine___SIGMOD_2024.pdf where we compared single core efficiency and scaling (see the results section). We found areas that each engine did better in.
If your goal is to improve the performance of DataFusion in the TPCH queries I have some thoughts:

The TPCH benchmark has many large joins. Thus the efficiency of the both the join plans and the join operators (e.g. HashJoinExec) is important for good TPCH
The level of optimization that has been invested into DataFusion joins is relatively low compared to aggregationing and filtering (see [Epic] A collection of Join Improvements #8398 for a list of potential ideas)

Hi @Lordworms -- thank you for this analysis.

(seems like we did not really do parallism and I really think that's some problem comes from Tokio)

I do not agree with this statement in general (though it may be that TPCH parallelism could be improved), -- DataFusion uses a signfiicant amount of CPU / parallelism and while tokio results in more complicated stack traces for sure, I think overall the benfits are worth it.
We did a comparison of DataFusion and DuckDB in our upcoming SIGMOD paper (#6782) DataFusion_Query_Engine___SIGMOD_2024.pdfEditSign where we compared single core efficiency and scaling (see the results section). We found areas that each engine did better in.
If your goal is to improve the performance of DataFusion in the TPCH queries I have some thoughts:

The TPCH benchmark has many large joins. Thus the efficiency of the both the join plans and the join operators (e.g. HashJoinExec) is important for good TPCH
The level of optimization that has been invested into DataFusion joins is relatively low compared to aggregationing and filtering (see [Epic] A collection of Join Improvements #8398 for a list of potential ideas)

Got it , I'll check those issues


Save streamed file

Hi,
Is there anyway to save streamed file on SD card? any suggestion how to do this?

Yes, you can enable cache, it will store the track in the SD card and keep it based on size or time limits, but for now, only Android allows it.

How we can access to cache and save the track permanently?

For now you can set maxCacheSize to a big number.
But I'll consider this issue as a suggestion, and implement in the future a proper way to store and access the track.

This has been inactive for almost an year. This feature will be a bit tricky to implement, and there is not enough support to implement it, sorry.

@Guichaguri but this is useful and if you give me directions, I'll be glad to help implementing it


oUploadSet.uploadItem(oItem) doesn't trigger upload after setting uploader aggregation

OpenUI5 version:
sap.ui.version
'1.96.0'
Browser/version (+device/version):
Google Chrome | 96.0.4664.55 (Official Build) (x86_64)
Any other tested browsers/devices(OK/FAIL):
none
URL (minimal example if possible):
N/A
User/password (if required and possible - do not post any confidential information here):
N/A
Steps to reproduce the problem:

I'm using sap.m.upload.UploadSet with a CAP nodejs backend service
Upload and download files are working fine using some custom logic because CAP expects a 2-step upload process: (1) Create entity using POST, then (2) upload the actual file using PUT
I need to have a completely custom way of handling upload from backend side, but I need the UI to send the file via Multipart Form Data. To achieve this, I need my own uploader config using sap.m.upload.Uploader.
Luckily, the sap.m.upload.Uploader has a property I can set useMultipart to true (false by default). However, as soon as I inject this in the aggregation via XML view, the upload doesn't trigger anymore after the call to oUploadSet.uploadItem(oItem).
Could this be a bug?

What is the expected result?
Uploader will work using Multipart Form Data
What happens instead?
Nothing happens. Upload didn't trigger.
Any other information? (attach screenshot if possible)
Here's sample code:
	<u:UploadSet core:require="{handler: 'com/rizing/inno/innovation/custom/fragment/handler'}"
		instantUpload="false"
		uploadEnabled="true"
		fileTypes="jpeg,jpg,png,docx,xlsx,txt,pdf"
		maxFileNameLength="30"
		maxFileSize="200"
		afterItemAdded="handler.onAfterItemAdded"
		uploadCompleted="handler.onUploadCompleted"
		items="{
				path: 'Files',
				events: {
					createCompleted: 'handler.onCreateCompleted'
				},
				templateShareable: false
			}">
		<u:uploader>
			<u:Uploader useMultipart="true" />
		</u:uploader>
		<u:items>
			<u:UploadSetItem fileName="{fileName}"
				mediaType="{mediaType}"
				url="{url}"
				thumbnailUrl="{ path: 'mediaType', formatter: 'handler.formatThumbnailUrl' }"
				enabledEdit="false"
				visibleEdit="false"
				enabledRemove="false"
				visibleRemove="false"
				openPressed="handler.onOpenPressed">

Hello @jcailan ,
With the information provided, we are not able to support you. Please provide an URL (minimal example if possible), along with the user credentials (if required and possible - do not post any confidential information here) and the steps to reproduce the problem.
Thank you in advance!
Kind Regards,
Oliver

Hi Oliver,
I have invited you to our org/repo: https://github.com/nspro-vesta/inno-app
Watch out for this commit: https://github.com/nspro-vesta/inno-app/commit/9ff4f103a5194b0c00c60d42293ebc5d0df5b162
Before the commit where I set:
		<u:uploader>
			<u:Uploader useMultipart="true" />
		</u:uploader>

Upload functionality is working fine. But after that, the upload call doesn't trigger anymore.
To reproduce the issue:

It's a Fiori Element Worklist-Object Page app using CAP nodejs backend
CAP backend needs to run with SAP HANA Cloud
Deploy DB artifacts with cds deploy --to hana
Run the app using cds watch
Create an Innovation Idea
Upload a file in the newly created idea entity (upload won't trigger as can be seen in the network trace)

Let me know if you need anything else.
Thanks and regards,
Jhodel

By the way, the UploadSet part is no longer part of the Fiori Elements template, since it's a custom extension.
Thanks in advance for your help!
Thanks and regards,
Jhodel

Hi @jcailan ,
Unfortunately I couldn't run your application because I'm missing the user credentials. However, I created a simple example in JsBin: https://jsbin.com/resebufuve/edit?html,output and the useMultipart property of the uploader doesn't seem to make any difference. Of course in this example we are missing the backend, but you can still set a breakpoint in Uploader#uploadItem to check if the method is being called.
Kind Regards,
Oliver

Hi @stoyanovski ,
Sorry forgot to mention that credentials can be found here: https://github.com/nspro-vesta/inno-app/blob/master/.cdsrc.json
I checked your sample and it works like a charm, so what I did is debugged the UploadSet.uploadItem and found that in below logic:
	UploadSet.prototype._uploadItemIfGoodToGo = function (oItem) {
		if (oItem.getUploadState() === UploadState.Ready && !oItem._isRestricted()) {
			if (this.fireBeforeUploadStarts({item: oItem})) {
				var oHeaderFields = oItem.getHeaderFields().length ? oItem.getHeaderFields() : this.getHeaderFields();
				this._getActiveUploader().uploadItem(oItem, oHeaderFields);
			}
		}
	};

The oItem._isRestricted() is true, which didn't make sense to me because before using the uploader aggregation, I can upload .png files without issues.
Thanks and regards,
Jhodel

Hi @stoyanovski
I think I figured out the root cause. The usage of oItem.setUploadUrl(sUrl) seems to make the oItem._isRestricted() to turn into true. So instead of using the original code I have, I have opted to use set the uploadUrl on the Uploader instance directly. See code logic below which I already tested working:

Could this be a bug in the framework?
Thanks and regards,
Jhodel

Hi @stoyanovski
Further debugging, I found out that one other root cause is that restricted becomes true because of the flag this._bNameLengthRestricted is true. I didn't set the property maxFileNameLength of UploadSet and according to the documentation, there's no default value for this property -- see https://sapui5.hana.ondemand.com/#/api/sap.m.upload.UploadSet%23controlProperties
	UploadSetItem.prototype._isRestricted = function () {
		return this._bFileTypeRestricted || this._bNameLengthRestricted || this._bSizeRestricted || this._bMediaTypeRestricted;
	};

Thanks and regards,
Jhodel

Hi @jcailan ,
When the maxFileNameLength property of the UploadSet is not explicitly set, it means that any files can be uploaded, regardless of their names length. In your application maxFileNameLength was set to 30 and you were probably testing with longer file names.
The issue seems to be solved now and I will therefore close this incident.
Kind Regards,
Oliver

Hi @stoyanovski
You're right, it probably threw me off track of the analysis all this while. However, don't you think there should be an error message either in UI or console to notify users of what needs to be corrected?

Hi @jcailan ,
There is actually an event fileNameLengthExceeded that is fired when the file name length is exceeded, and corresponding events for the other validations. You can use these events to display the error messages for the end user.
I hope this helps.
Kind Regards,
Oliver

Hi @stoyanovski
Okay, that makes sense. Thanks for your help, I get to understand the UI5 control much better.
Thanks and regards,
Jhodel


Not able to install 4.0.0 version. By default 3.0.0 gets installed.

$ pip install --upgrade "ibm-scc>=4.0.0"
ERROR: Could not find a version that satisfies the requirement ibm-scc>=4.0.0 (from versions: 0.0.1, 0.0.2, 0.0.3, 0.0.4, 0.0.7, 0.0.8, 0.0.9, 0.0.10, 0.0.13, 0.0.14, 0.0.15, 1.0.0, 1.1.0, 1.1.1, 1.1.2, 2.0.0, 3.0.0)
ERROR: No matching distribution found for ibm-scc>=4.0.0

@ManojDhanorkar ibm-scc has not been published to pypi yet. Trying to draw attention to this issue @gary1998


Update java docs

Codecov Report

Merging #215 (66ee82a) into master (8880561) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #215   +/-   ##
=========================================
  Coverage     70.62%   70.62%
  Complexity      595      595
=========================================
  Files            85       85
  Lines          1920     1920
  Branches        259      259
=========================================
  Hits           1356     1356
  Misses          445      445
  Partials        119      119

Impacted Files
Coverage Δ

src/main/java/seedu/intern/model/Model.java
100.00% <ø> (ø)

...c/main/java/seedu/intern/ui/PersonDetailPanel.java
0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8880561...66ee82a. Read the comment docs.


Single and group zone control

Firstly, thanks for this library @unreality , just set it up today and it's working great! :muscle:
I have the AR-WDD1E wall controller which has zone control (single and group) support, which I'd like to be able to control via ESP32.
The group feature allows grouping multiple zones and/or temperature sensors. For example, I have 2 zones (upstairs and downstairs) and have created 2 groups so the temperature sensor in the wall controller is linked to downstairs zone and the temperature sensor in the return duct is linked to upstairs zone.
Here's the bytes from debug mode for each zone and group setting:

downstairs zone on + upstairs zone on: 20 A1 58 3 80 9 0 41
downstairs zone off + upstairs zone on: 20 A1 58 2 80 9 0 41
downstairs zone on + upstairs zone off: 20 A1 58 1 80 9 0 41
day group: 20 A1 58 1 89 9 0 41
night group: 20 A1 58 2 90 9 0 41
all group: 20 A1 58 3 98 9 0 41

I've not yet figured out how to add zone control into your library and was hoping you could help or provide some guidance? :pray:
One thing to note, whenever changing zone or group settings the following error is logged:
AC ERROR RECV: 20 A1 50 2 90 9 0 41   mSrc: 32 mDst: 33 mType: 1 write: 0 login: 1 unknown: 1 onOff: 0 temp: 16, mode: 1 cP:0 uM:0 cTemp:0 acError:0
I assume this is because the library isn't aware of zone related settings?

I assume this is because the library isn't aware of zone related settings?

I havent looked at this library for a while, but to find out the group/zone commands you may want to change the debug output to print out the individual bytes in binary so you can see what bits are flipped more easily.
You may want to investigate readBuf[2] in decodeFrame() since there are a number of bits that are unknown. There may be a different 'message type' for group commands etc, and the bitmask used might need to be expanded to capture that etc
Unfortunately I dont have any group or zone capable units (or at least they are not set up for that at the moment) - so im unable to look at this directly :/

Hi j-marz,
I'm a fellow Aussie, with the same remote as you, looking to control my zone based fujitsu AC. Did you have any luck? I've built the ESPhome project as per https://community.home-assistant.io/t/fujitsu-ac-heat-pump-integration-via-esphome-esp32/407610 but I get an error I think its because, like you, im running it through a zone controller.
my wall controller: AR-WDD1E
Outdoor unit: ARTG36LHTA
zone controller: UTYCDPXZC (I think)

@LukeScerri @j-marz Did either of you every figure out zone control?

@LukeScerri @j-marz Did either of you ever figure out zone control? I'm also in the same situation.

Sorry mate no. I'm not sure how to sniff, read or decode the protocol in order to add those features to the library.
I'm happy to contribute to the project, but I need some guidance on how to start the process.

Change of priorities on my side and didn't go any deeper into reverse engineering the zone control. Hopefully in a few months i'll try to pick up this project again :pray:

Thanks both! Appreciate it


BOM pulls in OTEL 1.16.0 whereas Autoconfigure pulls in 1.18.0

Describe the bug
spring-cloud-sleuth-otel-autoconfigure overrides the version of OTEL specified in the BOM to 1.18.0 which means that it is not compatible with that is pulled from the BOM.
For example using io.opentelemetry:opentelemetry-exporter-logging pulls in 1.16.0 and that causes
***************************
APPLICATION FAILED TO START
***************************

Description:

An attempt was made to call a method that does not exist. The attempt was made from the following location:

    io.opentelemetry.sdk.trace.SdkTracerBuilder.build(SdkTracerBuilder.java:39)

The following method did not exist:

    'java.lang.Object io.opentelemetry.sdk.internal.ComponentRegistry.get(java.lang.String, java.lang.String, java.lang.String)'

The calling method's class, io.opentelemetry.sdk.trace.SdkTracerBuilder, was loaded from the following location:

    jar:file:/Users/boris.morris/.gradle/caches/modules-2/files-2.1/io.opentelemetry/opentelemetry-sdk-trace/1.16.0/43888dcd61612d0a864b8e0f8c3e92d1b54155b8/opentelemetry-sdk-trace-1.16.0.jar!/io/opentelemetry/sdk/trace/SdkTracerBuilder.class

The called method's class, io.opentelemetry.sdk.internal.ComponentRegistry, is available from the following locations:

    jar:file:/Users/boris.morris/.gradle/caches/modules-2/files-2.1/io.opentelemetry/opentelemetry-sdk-common/1.18.0/fd96e64ce139cf23dcedbbee2e58cfe93e01352f/opentelemetry-sdk-common-1.18.0.jar!/io/opentelemetry/sdk/internal/ComponentRegistry.class

The called method's class hierarchy was loaded from the following locations:

    io.opentelemetry.sdk.internal.ComponentRegistry: file:/Users/boris.morris/.gradle/caches/modules-2/files-2.1/io.opentelemetry/opentelemetry-sdk-common/1.18.0/fd96e64ce139cf23dcedbbee2e58cfe93e01352f/opentelemetry-sdk-common-1.18.0.jar

Action:

Correct the classpath of your application so that it contains compatible versions of the classes io.opentelemetry.sdk.trace.SdkTracerBuilder and io.opentelemetry.sdk.internal.ComponentRegistry

Good catch @borismorris-anaplan!


OAuth 2.0 Authentication

According to Quickbooks it isn't possible to use OAuth 1.0 for new accounts. See https://developer.intuit.com/app/developer/qbo/docs/develop/authentication-and-authorization/oauth-1.0a
It states that "new or existing developers with no previous apps must implement OAuth 2.0 and OpenID Connect." And OAuth 1.0 will no longer work after December 17, 2019.
Because of this there is no way for me to get the access credentials required. Do you already have support for OAuth 2.0 implemented?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 998a28b0-5278-73e2-7e27-b01997807797
Version Independent ID: c7a902d0-b098-0e3d-ef13-3f5f3082382d
Content: Copy data from QuickBooks Online using Azure Data Factory (Preview)
Content Source: articles/data-factory/connector-quickbooks.md
Service: data-factory
GitHub Login: @linda33wj
Microsoft Alias: jingwang

@patrickgalbraith Thanks for the question. We are currently investigating into it and will update you shortly.

@linda33wj Can you please take a look ?

This is what Quickbooks support just said about OAuth 1.0.

Thanks for contacting support. Unfortunately, it's not possible. We are deprecating OAuth 1 on Dec 17th. We can't create a new OAuth 1 app or change a OAuth 2 to 1.

This makes the Quickbooks Online connector essentially broken for any new integration. I think you need to update your documentation to make this clear.
Can you also provide an ETA on when OAuth 2.0 support will be available.

@linda33wj @ChiragMishra-MSFT  any update?

@patrickgalbraith did you find a solution to use the Quickbooks api? I'm currently trying to use a manually obtained token but it expires every hour

@fvalentiner I ended up building a custom Azure function that calls the API and handles the token refreshing. I called this function using a copy activity.

@patrickgalbraith thanks for the info. Is there a way that you could share some detail about the function to give me a push is the configuration?

@fvalentiner You will need to review the developer documentation - https://developer.intuit.com/app/developer/qbo/docs/develop/authentication-and-authorization.
Then create a developer account and a Quickbooks app, and write the code to call the API using OAuth2 for authentication.
Sorry can't really help you any more than that, it is a fair amount of work.

@patrickgalbraith Thank you. You did help a lot

Hi there, any ETA on when OAuth 2.0 support will be available in Data Factory? Also trying yo get data from QuickBooks but completely stuck here.

Is there any update on this?

@fvalentiner, is there any update on this at all?

@ChiragMishra-MSFT or @linda33wj, is anyone looking into this? StitchData is integrating with Quickbooks Online as well as Power BI.

@crisher0219 Thank you for bringing this to our attention.  I will escalate internally.

@MartinJaffer-MSFT, has anything changed? I suppose not with the holidays.

It was like my pings went into a black hole.  I'll try again now that it is the new year.

@MartinJaffer-MSFT  Thank you!

@MartinJaffer-MSFT Has there been any movement on this at all?

Thanks all for your feedback. We are aware of this issue and are working on adding OAuth 2.0 support for Quickbooks connector. Current ETA is late May.
#sign-off


[BUG]user_belongsto_role_relationship is returning an empty set.

Version information

Laravel: v5.8.9
Voyager: v1.2
PHP: 7.3.3
Database: 5.5.60-MariaDB

Description

Adding roles to user fails, relation?search=&type=user_belongsto_role_relationship&page=1 returns an empty set.
Steps To Reproduce
Steps to reproduce the behavior:

Go to 'users'
Click on 'add or edit'
Scroll down to 'roles and try to add'
No roles load, inspect element to see error in inspector

Expected behavior
add one of 12 roles to user

No roles load, inspect element to see error in inspector

Are you going to tell us which error?

Failed to load resource: the server responded with a status of 404 (Not Found) relation?search=&type=user_belongsto_role_relationship&page=1
Fresh install with roles created

... returns an empty set.

the server responded with a status of 404 (Not Found) relation?

search=&type=user_belongsto_role_relationship&page=1 returns an emptyset, chrome respond with 404 not found on that.
Route::get($dataType->slug.'/relation', $breadController.'@relation')->name($dataType->slug.'.relation');
When this queries roles, it says there are no roles.  Yet there are roles.  Works locally on php 7.1, same version, doesn't work on server.   All other aspect of voyager work on remote server, except this.

You can't both get a 404, AND a response of an empty set.... so which is it? Screenshots of the network tab may be helpful

The only reason why this line kicks in:
https://github.com/the-control-group/voyager/blob/5e175637fca405577f3b7a06ee029ec339686406/src/Http/Controllers/VoyagerBaseController.php#L680
Is because there are no editRows or the field which is passed does not exist.
Did you untick any of the fields from the user-BREAD or removed an entry?

I did not, just did a fresh migrate and voyager install and getting the same results.

Brand New Install
Centos OS 7
Php 7.3.3
same as above
The only thing in this is voyager and laravel, everything is as shipped.
Failed to load resource: the server responded with a status of 404 (Not Found)
relation?type=user_belongsto_role_relationship&page=1:1 Failed to load resource: the server responded with a status of 404 (Not Found)
app.js:1 GET http://<IP_ADDRESS>/admin/users/relation?type=user_belongstomany_role_relationship&page=1 404 (Not Found)
send @ app.js:1
ajax @ app.js:1
transport @ app.js:1
o @ app.js:1
i.query @ app.js:1
(anonymous) @ app.js:1
i.invoke @ app.js:1
i.trigger @ app.js:1
r.trigger @ app.js:1
r.open @ app.js:1
r.toggleDropdown @ app.js:1
(anonymous) @ app.js:1
i.invoke @ app.js:1
i.trigger @ app.js:1
(anonymous) @ app.js:1
dispatch @ app.js:1
g.handle @ app.js:1
3app.js:1 GET http://<IP_ADDRESS>/admin/users/relation?type=user_belongsto_role_relationship&page=1 404 (Not Found)
send @ app.js:1
ajax @ app.js:1
transport @ app.js:1
o @ app.js:1
i.query @ app.js:1
(anonymous) @ app.js:1
i.invoke @ app.js:1
i.trigger @ app.js:1
r.trigger @ app.js:1
r.open @ app.js:1
r.toggleDropdown @ app.js:1
(anonymous) @ app.js:1
i.invoke @ app.js:1
i.trigger @ app.js:1
(anonymous) @ app.js:1
dispatch @ app.js:1
g.handle @ app.js:1
app.js:1 GET http://<IP_ADDRESS>/admin/users/relation?type=user_belongstomany_role_relationship&page=1 404 (Not Found)
send @ app.js:1
ajax @ app.js:1
transport @ app.js:1
o @ app.js:1
i.query @ app.js:1
(anonymous) @ app.js:1
i.invoke @ app.js:1
i.trigger @ app.js:1
r.trigger @ app.js:1
r.open @ app.js:1
r.toggleDropdown @ app.js:1
(anonymous) @ app.js:1
i.invoke @ app.js:1
i.trigger @ app.js:1
(anonymous) @ app.js:1
dispatch @ app.js:1
g.handle @ app.js:1
3app.js:1 GET http://<IP_ADDRESS>/admin/users/relation?type=user_belongsto_role_relationship&page=1 404 (Not Found)

MariaDB [mcms]> select * from roles
-> ;
+----+-------+---------------+---------------------+---------------------+
| id | name  | display_name  | created_at          | updated_at          |
+----+-------+---------------+---------------------+---------------------+
|  1 | admin | Administrator | 2019-04-02 19:01:56 | 2019-04-02 19:01:56 |
|  2 | user  | Normal User   | 2019-04-02 19:01:56 | 2019-04-02 19:01:56 |
+----+-------+---------------+---------------------+---------------------+
MariaDB [mcms]> select * from users;
+----+---------+----------+---------------------------------+-------------------+-------------------+--------------------------------------------------------------+----------------+----------+---------------------+---------------------+
| id | role_id | name     | email                           | avatar            | email_verified_at | password                                                     | remember_token | settings | created_at          | updated_at          |
+----+---------+----------+---------------------------------+-------------------+-------------------+--------------------------------------------------------------+----------------+----------+---------------------+---------------------+
|  1 |       1 | Jeremiah |<EMAIL_ADDRESS> | users/default.png | NULL              | $2y$10$p693VG5V4FfKb8BNL6fm1O12EBWdinhUapqoSy.Jk07N2tyYaj3czu | NULL           | NULL     | 2019-04-02 19:02:52 | 2019-04-02 19:02:52 |
|  2 |       1 | jason    |<EMAIL_ADDRESS>| users/default.png | NULL              | $2y$10$VIIMArlyplWbrbsUvzAHp121276fHsJx19QIJn7xhLOqKvCZE5.hFm | NULL           | NULL     | 2019-04-02 19:03:52 | 2019-04-02 19:03:52 |
+----+---------+----------+---------------------------------+-------------------+-------------------+--------------------------------------------------------------+----------------+----------+---------------------+---------------------+
MariaDB [mcms]> select * from user_roles
-> ;
+---------+---------+
| user_id | role_id |
+---------+---------+
|       1 |       1 |
+---------+---------+
1 row in set (0.00 sec)
Both accounts where created using php artisan voyager:admin<EMAIL_ADDRESS>--create  neither inserted anything into user_roles table, so I thought that was the problem so i created a new entry for my user. Still does not work.

I found one difference, when I dd($options) under the edit-add.blade file.   Under Options
This server it works
+"model": "TCG\Voyager\Models\Role"
+"table": "roles"
+"type": "belongsTo"
+"column": "role_id"
+"key": "id"
+"label": "display_name"
+"pivot_table": "roles"
+"pivot": "0"
+"taggable": "0"
Server where it is not working
+"model": "TCG\Voyager\Models\Role"
+"table": "roles"
+"type": "belongsTo"
+"column": "role_id"
+"key": "id"
+"label": "display_name"
+"pivot_table": "roles"
+"pivot": 0
The difference being taggable.

Again, there are only 2 reasons why that method would return 404:
https://github.com/the-control-group/voyager/blob/5e175637fca405577f3b7a06ee029ec339686406/src/Http/Controllers/VoyagerBaseController.php#L646
Set a dd($dataType->editRows); just before this line, and:
https://github.com/the-control-group/voyager/blob/5e175637fca405577f3b7a06ee029ec339686406/src/Http/Controllers/VoyagerBaseController.php#L647
Set a dd($row); directly after this line.
Post both results here please.
If the first returns an empty collection - thats bad.
If the second doesn't do anything - thats bad aswell.

dd($dataType->editRows); is doing nothing
I put in a string of gibberish to see if it was even seeing it and it does.
$dataType = Voyager::model('DataType')->where('slug', '=', $slug)->first();
dd($dataType->editRows);
werwerwer
foreach ($dataType->editRows as $key => $row) {

It's not just dd var_dump($dataType->editRows) doesn't post anything either.

Then please add dd($dataType->rows); before the foreach (...) (line 645) and post the whole output.
And a screenshot of the whole bread-settings for the users table (something like http://localhost/admin/bread/users/edit)

No output, I don't even think the relation function is being called, I added a new attribute to it and nothing broke.   I know dd() works throughout other sections, but not in relation or most of VoyagerBaseController.php.
https://imgur.com/a/s7ts26M

Whatever is supposed to call relation is not calling it, I deleted the entire function and nothing changed, I deleted everything is VoyagerBaseController just to verify I was working in the right file and everything broke as it should.  I am completely flumoxed

Could this be a file permissions problem?   I am having serious file permissions problems with my server?

It did turn out to be a permissions problem. Was able to resolve.

ErrorException
Undefined property: stdClass::$scope
http://localhost/moto/public/admin/users/relation?method=add&page=1&type=user_belongsto_role_relationship

if ($options->scope && $options->scope != '' && method_exists($model, 'scope'.ucfirst($options->scope))) {
                $model = $model->{$options->scope}();

            }

this is causing the error. How do I resolve it

Please don't comment on completely unrelated issues.


GiphyMediaView sometimes renders GIF in incorrect ratio

🐛 Bug Report
I'm dealing with a UI bug, my hunch is that it might be related to GiphyMediaView but it's hard to tell as I’m using Sendbird React Native UIKit as a chat handler in my React Native app where we display the GIF so it's still a possibility the bug is on Sendbird end.
The bug is that only the last message (if it’s a GIF, does not happen for regular text or file messages) does not display in correct ratio, but as soon as there is a newer message in the chat, the GIF will render correctly.
I think it’s best shown with an example (I’ve simplified my code a lot just to show that if I render any message as a GiphyMediaView the bug will appear.):
import {
  GiphyMediaView,
  GiphyRendition,
  ResizeMode,
} from "@giphy/react-native-sdk";
import {
  MessageRenderer,
  createGroupChannelFragment,
} from "@sendbird/uikit-react-native";

const GroupChannelFragment = createGroupChannelFragment();

 <GroupChannelFragment
      channel={channel}
      onPressHeaderLeft={() => {}}
      onPressHeaderRight={() => {}}
      onChannelDeleted={() => {}}
      renderMessage={() => (
        // I also tried playing around with renditionType/resizeMode but neither fixed the bug
        <GiphyMediaView
          style={{
            height: 100,
            width: 100,
          }}
          media={{
            id: "t64oxIpnQwF8ilGfZQ",
          }}
        />

Notice how the last GIF does not fill in 100x100
If I however display a simple 100x100 red square for each message, it will not cut the view (indicating it’s not a Sendbird bug?)
 <GroupChannelFragment
      channel={channel}
      onPressHeaderLeft={() => {}}
      onPressHeaderRight={() => {}}
      onChannelDeleted={() => {}}
      renderMessage={() => (
        <View
          style={{
            width: 100,
            height: 100,
            borderColor: "red",
            borderWidth: 1,
          }}
        />
      )}
    />

And lastly here is a video showing the bug in action (I put a purple view on the parent to emphasize how big the GIF should be) and then how it’s fixed when a new message is displayed.
Here is how I actually display the GIF (as seen in the video)
   <GiphyMediaView
        media={{ id: encodeGif.id as string }}
        resizeMode={ResizeMode.Contain}
        renditionType={GiphyRendition.FixedWidth}
        style={{
          height: encodeGif.images?.fixed_width?.height || 200,
          width: encodeGif.images?.fixed_width?.width || 200,
          borderRadius: 8,
          overflow: "hidden",
        }}
    />

https://user-images.githubusercontent.com/7429825/195376148-554ab739-29ac-40e2-a10e-3380237f34a5.mov
Do you have any idea what might be happening?
Thanks for reading and let me know if you need any more information! 🫶
Your Environment

Giphy React Native SDK version: "1.11.1"
React Native version: "0.69.5"
Platform(s) (iOS, Android, or both?): iOS
Device info (Simulator/Device? OS version? Debug/Release?): Simulator iPhone 13 Pro
@sendbird/uikit-react-native: "1.1.2",

Hi, @hronnro. Thanks for reaching out.
I tried reproducing this issue with this SendBird sample. But in this sample, everything works as expected. I think it's because this example includes a header that, under the hood, adds padding to avoid overlapping the status bar.

To mimic your case, I removed the header and added a margin to the flatList. This helped me solve the problem. I think you can also try something similar:
const { top } = useSafeAreaInsets();

return (
    <GroupChannelFragment
        channel={channel}
        onPressHeaderLeft={() => {}}
        onPressHeaderRight={() => {}}
        onChannelDeleted={() => {}}
        flatListProps={{ style: {marginTop: top} }}
        renderMessage={() => (
            <GiphyMediaView
                style={{ height: 100, width: 100 }}
                media={{ id: 't64oxIpnQwF8ilGfZQ' }}
            />
        )}
    />
);

That was it! Oh wow thank you so much, I'm sorry this wasn't even a problem with Giphy 🥲
Have a good one ☺


Zod: Support for OpenApi spec 3.1.0

E.g. defining a field like:
        breed:
          type: ['string', 'null']
          # type: string
          # nullable: true

which is OpenApi 3.1.0 compliant,
will generate :
"breed": zod.string,null(),
which does not compile.
In zod terms it should be generated as: "breed": zod.string().nullable(),
which it does when using the OpenApi 3.0.x style as commented out.

cc @rmachado-studocu who has done some ZOD nullable work.

That was fast 🤩


Feat: Improve Test Consistency + Better Handle VRT Failures

Jira
http://vjira2:8080/browse/BDS-1050
http://vjira2:8080/browse/BDS-1585
http://vjira2:8080/browse/BDS-1596
Summary
Incorporates several different updates to improve overall testing consistency (ex. more predictable results when running Jest tests locally vs on Travis) in addition to better handling the results from successful / failing visual regression tests.
Details

Updates the Jest VRT reporter logic to better handle local VRT tests failing (no longer throws a now.sh token error)

Add a new summary view with links to all the failing Jest tests + VRT diff screenshots

Moves video fixtures used for testing into their own separate fixtures/videos folder so images and video assets are separated out

Reduces the total # of concurrent test suites being run on Travis down to just one at a time. Ironically, this seems to significantly reduce the overall % of Jest tests that randomly fail on Travis without significantly increasing the total time it takes to test everything (still ~11 minutes total)

Updates the Drupal Lab test suite running that compiles a fresh build and tests the results to be run one at a time to attempt to address http://vjira2:8080/browse/BDS-1596

Adds a new jest NPM script to the monorepo root that automatically adds the --maxWorkers=3 flag that I've found helps reduce local VRT test failures

Fixes a few issues with how Travis had been running our different test suites to eliminate some tests being run multiple times in different jobs

Makes a small patch to the jest-image-snapshot package we use for VRT to allow image diffs to be slightly different in pixel size and not immediately fail a test. This is a must in order if our tests are going to start clipping screenshots to the actual component's rendered dimensions.

Updates several Jest tests to try and further reduce the % of test failures due to components getting tested before they are ready / timeouts due to factors beyond our control (like 3rd party sites being slow to load). This includes updated tests for our most commonly failing tests

Blockquote component (including a few updates to increase the diversity of what's being tested)
Carousel (slightly increases the VRT failureThreshold)
Logo
Ratio (try to wait until the video / image has finished loading)
Autolink (increases max timeout)

Per discussion with @danielamorse, this PR also slightly increases the default global VRT failureThreshold config to help account for inherent differences in text rendering, etc across different environments
The global VRT config in Bolt has also been updated to automatically ignore anti-aliasing-related differences in tests
Adds a new config option to the image minification task in the Bolt build tools to allow image compression to be optionally disabled. This is now used by default when running all Jest tests to reduce potential rendering / compression differences depending on the OS
Fixes a bug in the Jest-specific .boltrc config where certain SVG images weren't always getting copied over to the build folder.
Globally reverted all Jest tests that been using Puppeteer's new (and more efficient / faster) browser.createIncognitoBrowserContext syntax back to browser.newPage() due to an upstream memory leak reported here.

@danielamorse --> this is the most likely reason why running individual Jest tests that use Puppeteer to test our Web Components mostly still passed locally but running all tests in parallel started to result in VRT diffs with missing resource-sensitive assets. Given that the Travis environment is even more resource limited than our local machines, this resource crunch likely started to cause browser instances to hang up in a way that we couldn't account for.

We've also updated the Travis config for running our Jest tests to now automatically retry running the full test suite (up to 3 times) if any individual test fails.

While this isn't ideal in my opinion (a failing test is still a failing test -- there just might not be something wrong with a component's code, per say), this should at least help us recover from the handful of ongoing issues we do still encounter: namely a few tests occasionally timing out and randomly getting unavailable port errors from the Twig renderer.

Lowered the max # of concurrent requests allowed by our Twig renderer implementation to test to see if this helps reduce the frequency of random port availability errors while we still work on a longer term fix.

How to test

[ ] Confirm Travis tests passing
[ ] Review high level changes
[ ] Test VRTs pass as expected locally by running the new yarn jest command

@sghoweri Bravo, approved 🎉

Does limiting --maxWorkers slow down tests? Still do it if it means consistency.
"automatically ignore anti-aliasing-related differences in tests" -- how'd you do that!?
Fixed missing assets in parallel tests. Woo!
Love the new test summary.
This is a beautiful thing:

Thanks @danielamorse!! To answer your questions:

Does limiting --maxWorkers slow down tests? Still do it if it means consistency.
I've found that while --maxWorkers does limit just how many testing suites get run concurrently (Cards, Buttons, Bands, Accordions, etc), in practice I haven't really seen this to add a ton of extra time to our overall build times. Regardless, turning this way down seems to seriously help with consistency!

"automatically ignore anti-aliasing-related differences in tests" -- how'd you do that!?
It's actually just one of the config options that can get passed right along to pixelmatch (which jest-image-snapshot uses under the hood), includeAA which If true, disables detecting and ignoring anti-aliased pixels. false by default.

https://github.com/mapbox/pixelmatch#pixelmatchimg1-img2-output-width-height-options


unable to parse schemata/

I use command line in Usage, but combine into a single schema error.
who can help me？

unable to parse schemata/app.json (#<JSON::ParserError: 822: unexpected token at '��{'>)
unable to parse schemata/user.json (#<JSON::ParserError: 822: unexpected token at '��{'>)
Somes files have failed to parse. If you wish to continue without them,please enable faulty_load using --faulty-load

Hmm. I'm not sure from that info. Could you share the contents of one of the files so we can reproduce? Thanks!

Now i'm using my work computer, init prmd as https://github.com/interagent/prmd README.md.And  this time "Combine into a single schema" success, but the last fail, like this:

The demo pro

Sorry for the delay, unfortunately I've always found encoding issues to be pretty hard to duplicate/debug. It looks like it might be an issue of mis-interpreting how files should be read due to the setting on the system. For instance, I found a similar error message coming from a different project here: https://github.com/imathis/octopress/issues/1391. From that I suspect that on your system, it is trying to interpret the files as GBK instead of utf-8, which may be leading to the problem. It may be that we need to add similar casts to utf-8 in our File.read. Does that make sense? Would you be willing to give that a try and see if it helps? Thanks!


File Upload File

Can we get a file upload filed in hope-ui ?

Hi, yes that's something I've planned to do. I need to figure out what the design and api should look like. But this will be part of/after the 1.0 rewrite.


Remove old dependencies

[x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?
This PR eliminates old dependencies to files that got their name changed.
Why should this Pull Request be merged?
Fixes a dependency issue when trying to build MeasurmentLink Service.vipb
What testing has been done?
Build MeasurmentLink Service.vipb from a manual folder download.

I'm still seeing these on disk. Which PR did they supposedly get deleted in? E.g.
https://github.com/ni/measurementlink-labview/blob/main/Source/Runtime/MeasurementLink Measurement Server Internal/RPC Messages/ni_measurementlink_measurement_v1_ConfigurationParameter_AnnotationsEntry.ctl

Also, I built MeasurementLink Service.vipb successfully just now.

I'm still seeing these on disk. Which PR did they supposedly get deleted in? E.g. https://github.com/ni/measurementlink-labview/blob/main/Source/Runtime/MeasurementLink Measurement Server Internal/RPC Messages/ni_measurementlink_measurement_v1_ConfigurationParameter_AnnotationsEntry.ctl

These libraries are the generated output of grpc-labview for measurement_service.proto, which hasn't changed since adding V2 support months ago. So I don't think this change is necessary.

I'm still seeing these on disk. Which PR did they supposedly get deleted in? E.g. https://github.com/ni/measurementlink-labview/blob/main/Source/Runtime/MeasurementLink Measurement Server Internal/RPC Messages/ni_measurementlink_measurement_v1_ConfigurationParameter_AnnotationsEntry.ctl

I'm still seeing these on disk. Which PR did they supposedly get deleted in? E.g. https://github.com/ni/measurementlink-labview/blob/main/Source/Runtime/MeasurementLink Measurement Server Internal/RPC Messages/ni_measurementlink_measurement_v1_ConfigurationParameter_AnnotationsEntry.ctl

This is the PR where it got deleted.
https://github.com/ni/measurementlink-labview/pull/215/files#diff-fb0edc361b57a61843f376721801c3104db3a963b944831cfd59c8291cf97e8f

Also, I built MeasurementLink Service.vipb successfully just now.

I am not sure how it works.. If you do git pull and build it works but if you download the zipcode and try to build it doesn't.
This is the bug nad how the error looks.

I'm still seeing these on disk. Which PR did they supposedly get deleted in? E.g. https://github.com/ni/measurementlink-labview/blob/main/Source/Runtime/MeasurementLink Measurement Server Internal/RPC Messages/ni_measurementlink_measurement_v1_ConfigurationParameter_AnnotationsEntry.ctl

These libraries are the generated output of grpc-labview for measurement_service.proto, which hasn't changed since adding V2 support months ago. So I don't think this change is necessary.

How do we regenerate them then?

The files of the issue are any reference.. After opening the MeasurementLink Measurement Server.lvlib and closing even without saving is impossible to reproduce.


Show current local and remote commit hashes in NeogitStatus

Is your feature request related to a problem? Please describe.
Yes, it's nice to show commit message header for local and remote sources, but in addition it would be nice to also include commit hash, so user will know if commits are identical.
Describe the solution you'd like
Show current local and remote commit hashes in NeogitStatus

Could be cool to have as an option, sure

Yeah, because with commit amend it can starts to be confusing.

Makes sense. Though, with an ammended HEAD, you'll see both the "unpulled" and "unpushed" sections appear.
Regardless, its a good idea.

I started of this in that it shows the commit ref if you are in a detached HEAD state.
Do you think that the same format could be used for the normal HEAD states? Or would you consider changing it to something else?

Thank you! I think its time to close the issue.


Clarify behavior of parallel pod management policy of stateful sets

When specifying the podManagementPolicy on a stateful set, we observed that the option only affects the behavior for scaling operations and we saw that the behavior of the rolling updates remains the same, i.e. the pods are updated one by one and each respective subsequent pod is only updated after the one before was ready. This PR improves the clarity of the docs about this behavior.
Observed on Kubernetes 1.11

Thanks for contributing, @MajorBreakfast!
/lgtm
/approve


alt key doesn't exist in macOS

module:ol/events/condition.altKeyOnly. First no mention of what this means in macOS. Probably Cmd, but that should be mentioned.
Secondly: How write the condition? I've seen condition: ol.event.condition.altKeyOnly but if you have
 import {defaults} from 'ol/interaction';
 import * as olEvents from 'ol/events';

How do you write the condition?
I tried
const dragRotateInteraction = new DragRotate({
  condition: olEvents.altKeyOnly // no error but doesn't work, but no alt
})
map.addInteraction(dragRotateInteraction);

but doesn't work with Cmd key. Maybe I'm missing the documentation for this.

Should be
import {altKeyOnly} from 'ol/events/condition'
const dragRotateInteraction = new DragRotate({
  condition: altKeyOnly,
});

With your current code olEvents.altKeyOnly is undefined, so the default condition is used.

Thank you.
And it activates with the macOS option key, not Cmd.
How would I discover this in the apidoc? ol/events doesn't mention condition. Is this something I should know from JavaScript or is it OL? ol/events/condition  takes one to the page, but I don't see how to discover this. But I am learning more. In the middle of a Udemy tutorial.

The page for DragRotate shows its available options and links to the conditions page:
https://openlayers.org/en/latest/apidoc/module-ol_interaction_DragRotate-DragRotate.html

Just because your keyboard doesn't have key labeled Alt that doesn't mean your OS doesn't know about it. https://en.m.wikipedia.org/wiki/Alt_key

Repeating myself: "First no mention of what this means in macOS. Probably Cmd, but that should be mentioned" and "And it activates with the macOS option key, not Cmd".
Macs are common enough to warrant having their key strokes listed in the documentation.

@MtnBiker Please submit a pull request with a documentation improvement - it’s in your hands.


Add contributors.md

This file will help us track all non-code contributions to the Cilium project

Hi, you should probably consider adding info about non-code changes to the README as well. Now it states If you have already contributed to the project in any way, please add yourself to the contributor file., so you could end up with multiple PRs for code contributors.

@alexkats good point. I've tried to make it more clear. What do you think of it now?

It's clear to me now. But I'd still add something to README.md for those who won't read CONTRIBUTORS.md carefully 🙂

Good point, I've added that to the README now. Does that make sense?

Yes, looks good, thanks!


Many Issues

Firstly thank you so much for your wonderful software.
I'm having a lot of problems when attempting to generate scaffolding for anything that contains any type of field other than plain strings or numbers. I've tried all kinds of versions, both the boilerplates and installing into a fresh Laravel 5.2 install as per the instructions on your website.
Are date and boolean field types supposed to be working at this point in time, because they really are not.
For example, when creating a scaffold for a model that includes a date, the scaffolding is created, and allows me to create a record which includes a date. This record is then correctly displayed in the index, but when I attempt to edit this record, the existing date information is not placed into the date field. It just shows "dd/mm/yyyy" again.
If I include a boolean field with a checkbox, there is no display of that field in the index, and when editing the record, the box is show, but it's always checked, no matter what the existing record is. If I save the record with the box unchecked, then I can see by looking at the database directly that the record is not changed.
I'd appreciate knowing if these are know issues, so that I can stop trying to solve problems that I'm not creating.
Thank you so much for your help.

Let me see if I  can help.
I  will look through the stub files and double check the stub file paths.  As for the boolean with checkbox  I  pushed the updated files a while back but only half of them look like they are there so I  will add them again.
Can you tell me what version of the repo you are using.

Hi there,
I have tried using "dev-master" and "dev-develop" in composer.json, as well as the 5.2 branches of the bootstrap and adminlte boilerplates.
Thanks so much for your help.

Regarding the issue with the date type, it looks the server is actually returning the correct date, but that the format doesn't match the one that the date field is expecting.
Please see screen capture attached for an example.

I can confirm that this is related to the date format of the HTML5 datepicker. The edit form works correctly with dates in Firefox, as the datepicker element does not seem to function at all in that browser.
The form does not work in Chrome or Microsoft Edge, where the datepicker does work. The datepicker requires two completely different date formats in those two browsers, neither of which matches the incoming format from Laravel. Chrome requires the local format "dd/mm/yyyy", while Edge requires "mm/dd/yyyy", despite them being installed on the same machine. The date from Laravel is in "yyyy-mm-dd" format.
Since the HTML5 version doesn't work at all in Firefox, and is buggy at best in other browsers, maybe it would be better to use another datepicker for the time being, where you can set the format it expects to match the format being delivered by Laravel?
Thanks again for all your help.

The date format is up to you in the bootstrap template the only one being used is the bootstrap one and it works fine in all browsers for me.  As for the version to use I would use the master branch if you do now want to dig into the functionality of the package and adjust the needed code to suite your needs which would be what the dev branch is for at the moment.  I  have testing all the fields on a fresh install and it works fine for me in the big browsers. I  guess my question would be have you tried setting the date format manually?
Something along the lines of these ones I  use:
	public function getDateAttribute($value)
    {
        return Carbon::parse($value)->format('d/m/Y');
    }

    public function setDateAttribute($value)
    {
        $this->attributes['dob'] = Carbon::createFromFormat('d/m/Y', $value)->toDateString();
    }

      /**
     * @param $date
     */
    public function setAddedDateAttribute($date){

        $this->attributes['created_at'] = Carbon::createFromFormat('d-m-Y', $date);
    }

    /**
     * @param $date
     */
    public function setPublishedDateAttribute($date){

        $this->attributes['published_date'] = Carbon::toFormattedDateString('d-m-Y', $date);
    }

can I  see your crud output by chance do you have a repo with it? or can you show me your edit.blade.php

As I said originally, I have tried multiple original versions of laravel-generator on fresh installs of Laravel 5.2, as well as downloading your bootstrap boilerplate, and the issues I'm having are the same.

When editing a model with a date, the original date does not show in the datepicker.
The boolean checkbox is never shown in the index view of records.
When editing a boolean checkbox, the changes are not saved. The checkbox is always checked.

The HTML5 date picker is known to be broken in many browsers. Even if it does work, of particular concern is the inability to set the date format. It's set automatically from the browser's language. This means that you would somehow have to get the date format that a user's browser is using, and then tell Laravel to expect/return dates in that format.
I've changed my copy of the template to use bootstrap-datepicker. It's light, simple to use, widely compatible and it's easy to set the required date format to match whichever one is used in Laravel.
http://eternicode.github.io/bootstrap-datepicker/
Apart from the date issue, the bool-checkbox is also broken. It appears in the edit form, but it does not save. It's always either checked or unchecked.

I  need to see your code to help you further. Not sure if you tried this option or not but you can always add the old attribute to your field. Here is an example of one I  used in the past.
{!! Form::file('product_name', null, ['class'=>'form-control', 'id' => 'product_name', 'value'=>Input::old('product_name')]) !!}

While I really do appreciate your efforts, I don't know what else I can do to explain the issues. I'm not sure you're understanding.
Your standard code generates broken output when it comes to both date fields and checkboxes.
Datepicker
You are using the HTML5 datepicker in your code for your date fields which will never work properly for all international users the way you are using it.

By default, when you edit a record, Laravel returns the date field from the database in whatever format has been set for the whatever database Laravel is using, for example "YYYY-MM-DD".
the HTML5 datepicker will check that returned date field to see that it matches the format it is configured for, based on the user's browser settings. For example, in my Chrome browser (in Australia) it's "DD/MM/YYYY" and you CANNOT change that expectation in code.
If the format from Laravel does not match the format that the HTML5 datepicker is expecting (as it does not in the above case), then the datepicker will reject that input and leave browser date box blank. You can see this in the error message in the browser console.
Yes, I could use a Laravel mutator in the model to alter the date format returned by Laravel to match the one I know my browser expects, but what about the next user? What if they are from the US and their HTML5 datepicker expects a different format again, like "MM/DD/YYYY"? Then the whole thing will be broken all over again.
Therefore I can't see how you can ever be certain that the database format, laravel format and browser format will match. And they MUST match if the HTML5 datepicker is ever to work and be populated from the database.

I don't know how much clearer than that I can be. You don't need to see any code from me. My code won't show you the issue. The issue only shows up in the browser.
My solution has been to implement the datepicker I listed above. Then I can control the format that the datepicker expects, and returns, by code, and match it to whatever I set in the database and/or Laravel.
Checkbox
In relation to the boolean checkbox option, your code is seems to be incomplete.  Laravel does not seem to offer this functionality automatically. You need to parse the output from the browser form and convert it to a boolean value to be stored in the database, and then do the reverse when displaying the database value in a checkbox.
The checkbox only returns a value to Laravel if it's checked. If it's not, the field is missing entirely from the fields and values returned to Laravel. You can overcome this by adding a hidden field with the same name BEFORE the checkbox. If the checkbox is not checked, the hidden field and value will be returned. If the checkbox is checked, it will override the hidden field with its own value. For example, for a checkbox named "approved": (note: I'm relatively new to php and Laravel, so please excuse my code)

        {{ Form::hidden('approved', 0) }}
        @if ($application->approved)
            {{ Form::checkbox('approved', 1, true) }}
        @else
            {{ Form::checkbox('approved', 1, false) }}
        @endif
        Active

You can then add a Laravel mutator in your model to convert "1" and "0" to numeric(boolean) 1 and 0 to be stored in the database.
public function setApprovedAttribute($value)
{
    if ($value === '1') {
        $this->attributes['approved'] = 1;
    } elseif ($value === 'false') {
        $this->attributes['isactive'] = 0;
    }
}

Also, you'll need a Laravel accessor in the model to ensure a value of either 1 or 0 is always returned.
public function getIsactiveAttribute($value)
{
    if($value === 1)
    {
        return 1;
    } else {
        return 0;
    }
}

Finally, you might want to add some other custom method to use when displaying the boolean value from the database in the index view (or just some Blade code would also work) so that rather than just "1" or "0" you get a "yes" or "no" or "true" or "false" or something else that makes sense, like a font-awesome tick or cross.
I hope this all makes some sense. I appreciate your time and effort.

type="datetime-local" will work, gives picker in chrome for date only, gives picker edge(windows 10 explorer) for both date and time. and firefox didn't give me any :( and the formatting is yyyy-mm-dd HH:MM:SS
type="datetime" also works but it don't show date-picker in all browsers
simple type="date" simply doesn't work because of opposite formatting.
firefox don't like me :(

Hi @mastermind23. Thanks so much for your suggestions.
No, I'm afraid all of the HTML5 date types use the format of the local browser. type="datetime" has been removed completely from the HTML spec, as so will soon no longer work in any browser.
Apart from that, a solution that is broken for 50% of users is not really a solution, and I think most developers would agree that those HTML5 features are very poorly implemented even in the browsers which do support them, and so should not be used.
At this stage I'll stick with the simple, lightweight and reliable solution I mentioned above.
Hope this helps.

Here is one thing I  see that you will need to adjust.

        {{ Form::hidden('approved', 0) }}
        @if ($application->approved)
            {{ Form::checkbox('approved', 1, true) }}
        @else
            {{ Form::checkbox('approved', 1, false) }}
        @endif
        Active

The boolean checkbox does not return values it returns either 0 for false or 1 for true. if you need values you need to use the normal checkbox.
Also there is not hidden field you should remove it. That is for laravel 4 not the 5+

        @if ($application->approved)
            {{ Form::checkbox('approved', 1, true) }} /* this returns boolean true 1 */
        @else
            {{ Form::checkbox('approved') }}  /* this returns unchecked boolean false 0 */
        @endif
        Active

you should not need the if statement just this for checked
{{ Form::checkbox('approved', 1, true) }}

or for unchecked
{{ Form::checkbox('approved') }}

your checkbox with the if statement would only show if its checked anyway it would not tell something its checked then show you the checkbox. not sure what you were going for.
just the checkbox by itself would do what all three code examples above accomplish. you might need to use $casts in your model to show it should be boolean but I  have not had to yet.
hope it helps.

date filed not working while edit time issue pending here. https://github.com/InfyOmLabs/laravel-generator/issues/71
Checkbox working fine


UI/Web Output gallery - add 'open folder' button (needs Mac/Linux testing)

This contains code for Mac and Linux which I have not tested so I don't know is correct. Plus the whole concept feels pretty half-assed to me, but then again I keep running from the branch I have it on and using the thing. And continually rebasing it. Soooo PR.
Motivation
It would be useful to be able to mark images in the output gallery and then filter them in or out of the gallery. Also at some stage move the ones you don't want somewhere else so they can be deleted (or move the ones you want to keep somewhere else, so you can delete what's left). I was trying to think of the simplest ways to do that whilst having the filtering persist between runs, and one of the ways I thought of was 'having marking an image move it to another subdirectory, and unmarking it move it back'.
This is not that.
This is 'Well if you're thinking of faffing about shuffling files around like that, you might as well just throw up your hands and put in a ~expletive~ button that opens the current subdir in the os file browser if you're running the UI on the same machine Shark is running, have them do it manually, and expect them to hit refresh we they're done. Wait! is that even possible?'
Apparently yes.
Changes

Adds a button that opens the currently selected subdirectory using the default OS file manager if the http request is from <IP_ADDRESS> or localhost.
Improves output gallery handling of having images deleted out from under it.
Don't show VAE or LoRA lines in output gallery parameter info panel when their value is 'None'

Problems/Concerns

I've written code to do this for Windows, Mac and Linux. I don't know that what I've written works at all on Mac or Linux. So probably DNM until someone who can test those has done so.
In Windows the first time you use in a session it the File Explorer flashes discretely to let you know it wants attention rather than immediately popping up the window.
Entirely useless if you're not on the same machine as the the browser.
Doesn't really solve the original filtering problem, because you still have to find the files you want muck about with in os file browser even tho' it is pointing at the right directory, and then you have to refresh once you're done, and... 🤷

LMK when you rebase to latest gradio and I can test on mac.

Conflict should now be fixed.


"NOVOPRIME" UI seen after kubeflow deploy finish

Hi guys,
I try to deploy kubeflow with the tutorial https://www.kubeflow.org/docs/gke/deploy/deploy-cli/ ,  after I run "kfctl apply -V -f ${CONFIG_FILE}" and finally I see "Applied the configuration Successfully!",  then I wait half an hour and try to visit "https://<KF_NAME>.endpoints..cloud.goog/" as tutorial described.
However, when I visit  my url, "http://chutkubeflow.endpoints.tchu-test.cloud.goog/Account/Login?ReturnUrl=%2F", I see a logo "NOVOPRIME  Log into your account" and ask me to input username/password. There isn't any description about how to input these information in the tutorial, and I try with my google account and not work.
Could you tell me it's normal or not?  or how should I input username/password?  I used a proxy to visit url and I am not sure whether it causes trouble,  thanks.

@linpingta Hi Chu - Thanks for your note.   We need more info i.e. which platform, which version of  Kubeflow, which version of K8s, etc.    thanks.

@jbottum , thanks for your help.
Platform:  Google Cloud Platform
kubeflow version: kfctl v1.0.2-0-ga476281
k8s version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.3", GitCommit:"2e7996e3e2712684bc73f0dec0200d64eec7fe40", GitTreeState:"clean", BuildDate:"2020-05-20T12:52:00Z", GoVersion:"go1.13.9", Compile
r:"gc", Platform:"linux/amd64"}
please tell me if not enough

@linpingta Hi, I dont think that we are formally support KF on K8s 1.18.   Can you use K8s 1.15 or 1.16 ?

Actually, I don't configure k8s version, I just configure step by step as https://www.kubeflow.org/docs/gke/deploy/deploy-cli/ described, could you tell me how to change the version of k8s?

Hi @jbottum , I find I am wrong about URL, because it should be "https://chukubeflow.endpoints.tchu-test.cloud.goog" instead of "https://chutkubeflow.endpoints.tchu-test.cloud.goog",  however, when I visit the new url, it tells "the site can't be reached".
And I try to "curl -k https://chukubeflow.endpoints.tchu-test.cloud.goog -v" , it tells :
* Rebuilt URL to: https://chukubeflow.endpoints.tchu-test.cloud.goog/
* Could not resolve host: chukubeflow.endpoints.tchu-test.cloud.goog
* Closing connection 0

Any suggestion for this problem?

it seems my problem, I try with a new oAuth and a new app, it works now, thanks.


Verify database state with retry

As mentioned in README
Docker Compose may start Clair before Postgres which will raise an error. If this error is raised, manually execute docker start clair_clair.
so I add retry in verify database to avoid exiting.

@Quentin-M, please review my PR, thanks!

@jzelinskie I think this PR can now be closed?

@ajgreenb Sure! Sorry for the late response.


test: Move back to Fedora 31 for CI test

The Fedora 32(currently rawhide) is failing a lot1 when build from
Dockerfile.
Moving back to Fedora 31 and use 'networkmanager/NetworkManager-1.22'
copr repo.

Coverage remained the same at ?% when pulling 1b5352829de554e367d332dec12b60b59e5c48ef on cathay4t:fix_ci into bc66b108c4a929a64438280bddc00a38eb409b0d on nmstate:master.

Could you please explain why we are interested in testing on fc31? nmstate-0.2 will never land there.

Could you please explain why we are interested in testing on fc31? nmstate-0.2 will never land there.

F31 is the latest stable Fedora for now which save us from the massive failure when using Rawhide.
The reason we need a Fedora: Fedora will be next version of RHEL, we'd better know big changes
before too late. For example: MAC address of bridge changed in F31.

And the code just change from rawhide to latest stable release of Fedora.

The reason we need a Fedora: Fedora will be next version of RHEL, we'd better know big changes
before too late. For example: MAC address of bridge changed in F31.

Next RHEL version will not be based on F31, I expect it to be based on F32 and then diverge.
So F31 is currently in the past and not the future.


remove averaging of nalu-wind timing

I and @jrood-nrel have noticed certain scenarios that result in some idling during MPI Send/Rcv put in to average timings across Nalu-Wind. I don't have much faith in the logic I put in, so removing it for now before anyone else runs into it.

I noticed the case of nalu/nalu without an amr-wind solver also hangs and this PR fixes that as well. I've tested this PR and I'm going to merge it.


Download wget on win7 fails because of TLS 1.2

The download of wget on windows 7 fails because https://eternallybored.org/misc/wget/current/wget.exe uses TLS 1.2 and  .NET Framework 3.5  on Windows 7 doesn't support TLS 1.2.
Error on make virtualbox/eval-win7x86-enterprise :
Exception calling "DownloadString" with "1" argument(s): "The underlying connection was closed: Could not establish trust relationship for the SSL/TLS secure channel."

The same download of wget with System.Net.WebClient on an updated Windows 7 SP1 + .Net 4.7.1 works fine.
See this KB regarding the support of TLS 1.2 on .NET 3.5.1: https://support.microsoft.com/en-us/help/3154518/support-for-tls-system-default-versions-included-in-the-net-framework

@2xyo, do you mind if I close this and mark it as a duplicate of #177?
Despite this being a bug, it'll likely be part of the fix for #177.

Ok thanks :)


.peek() reports inventory contents incorrectly and can produce stacked unstackable items. [API-7]

I am currently running

SpongeForge version:

SpongeVanilla version: 7.3.0

Java version: 8

Operating System: Windows 10

Plugins/Mods:
The plugin that contains this code.

Issue Description
Inventory.peek() is returning incorrect information. It reports multiple items with the same damage value instead of one of each, and consequently, peeking then removing just dupes the items, whereas it should cleanly remove them one at a time. I have only tested this with diamond swords of different damage values.

I also thought that sponge prevented you from creating item stacks with quantity above their max stack size, but as shown above that doesn't seem to be the case.
This is pretty bad as my plugin relies on sponge reporting the inventory contents correctly.
I am not sure if this happens in Api-8 or not.

Sponge does not prevent you from creating oversized stacks.
Its the vanilla inventories that wont accept them.
As such when offering a stack of 5 diamond swords to a normal vanilla inventory it will fill up 5 slots.
Modded inventories could choose to accept such stacks.
The logic for peek(limit) and poll(limit) only check if the items peeked/polled are the same ItemType in API7.
I agree that this felt wrong but changing it now in API7 is too late as plugins may rely on that behavior and there are ways around the issue.
The variant peek(limit) got removed in API8 as it was redundant.

The variant poll(limit) in API8 now checks if the items are equal except for quantity.
Not quite sure what you are trying to do but if you
use peek(maxSize) and then poll(maxSize) it will remove the stacks.
Alternatively using peek() without limit only returns a single slot regardless of stacksize.
Finally you could query again for the exact stack.


Unknown roSGNode 'Promise'

Thank you for this package. It has proved to be invaluable for my needs in the app I'm building.
I have had version v0.1.0 working for some time, though it has always shown a Warning in the promises_ensurePromise function , saying Cannot find name 'promises'.
I just tried the latest version v0.5.0, which appears to resolve the previous Warning, however it now throws an error Unknown roSGNode 'Promise'
I have installed this manually, having downloaded the release zip file.
I am using the VS Code extension v2.50.5 and have installed bsc-0.68.2 via npm using the extension.
Anyone have any idea how to get the latest version of @rokucommunity/promises working without the Unknown roSGNode error?
Thanks.
( Also note that the demos/simple-brightscript example is still using v0.1.0 )
Update: I have found that changing "Promise" back to "promises_Promise" makes the errors (and warning) go away. L6.
Though I have no idea why. :)

By default, ropm will install libraries with a prefix. This is to prevent collisions between different packages and also your own code. So if you followed the instructions and installed promises like this using ropm:
npx ropm install promises@npm:@rokucommunity/promises

then there will be a promises namespace/prefix in front of everything. This means all the namespace library functions will be promises.* (such as promises.create(), promises.onThen(), etc). This also means that the scenegraph node will be named promises_Promise.
So this hopefully answers your question as to why you needed to change Promise to promises_Promise.

Thanks @TwitchBronBron.
That makes sense now. :)
All the best.


Adding scenefield with breaking

https://github.com/vis2k/Mirror/pull/1577 without auto fix, user will have to update scene fields manually.

closing in favor of https://github.com/vis2k/Mirror/pull/1576


Syntax suggestion: Baseline capture group

[capture:name] expands behind the scenes to [capture:name 1+ #any].

I really believe that explicit is better than implicit.
On Tue, Sep 20, 2022, 20:26 mikaelho @.***> wrote:

[capture:name] expands behind the scenes to [capture:name 1+ #any].
—
Reply to this email directly, view it on GitHub
https://github.com/SonOfLilit/kleenexp/issues/32, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAADU7MGXOYRHUAMYLRKMXTV7HXS5ANCNFSM6AAAAAAQRJIZJI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

That is perfectly understandable. 👍🏼 ... Although, in this case, I would not consider this any more implicit than default values for keyword parameters.


Can I set custom options in configuration file and get it throughout Drogon program?

I would like to set some custom options in configuration file and use it in Drogon.
eg.
  "my-options": {
    "option1": "abc",
    "option2": "xyz"
  }

and save it to "config.json"
Can I get the "my-options" throughout Drogon if I call following?
drogon::app().loadConfigFile("config.json");
Thank you.

//custom_config: custom configuration for users. This object can be get by the app().getCustomConfig() method.
    "custom_config": {
    }


Cannot build this myself

I encounter an issue same as this in this repo

I'm getting this error too, you can just ignore this, for me it building as usual


boards: arm: msp_exp432p401r_launchxl: Remove FLASH_BASE_ADDRESS in d…

…efconfig
Since the base address for Flash memory is obtained from DT, remove the
redundant FLASH_BASE_ADDRESS config symbol which generates below warning:
warning: attempt to assign the value "0x00000000" to the undefined symbol
FLASH_BASE_ADDRESS
Signed-off-by: Manivannan Sadhasivam<EMAIL_ADDRESS>

Codecov Report

Merging #7554 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7554      +/-   ##
==========================================
- Coverage   55.25%   55.25%   -0.01%
==========================================
  Files         468      468
  Lines       51673    51673
  Branches     9893     9893
==========================================
- Hits        28554    28553       -1
- Misses      19206    19207       +1
  Partials     3913     3913

Impacted Files
Coverage Δ

lib/posix/pthread.c
69.34% <0%> (-0.51%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b56b143...8ee84da. Read the comment docs.

This got merged as #7922