[SPARK-37391][SQL] JdbcConnectionProvider must indicate if it needs lock

Augments the JdbcConnectionProvider API such that a provider can indicate that it will need to modify the global security configuration when establishing a connection, and as such, access to the global security configuration should be synchronized. Presently, access to the global security configuration is always synchronized and this creates a bottleneck for applications that rely on initiating many JDBC connections simultaneously.
What changes were proposed in this pull request?
As suggested by @gaborgsomogyi here, augments the JdbcConnectionProvider API to include a needsModifySecurityConfiguration method that can be used by ConnectionProvider to determine when SecurityConfigurationLock.synchronized is required to avoid race conditions when establishing a JDBC connection.
Why are the changes needed?
Provides a path forward for working around a significant bottleneck introduced by synchronizing SecurityConfigurationLock every time a connection is established. The synchronization isn't always needed and it should be at the discretion of the JdbcConnectionProvider to determine when locking is necessary. See SPARK-37391 or this thread.
Does this PR introduce any user-facing change?
Any existing implementations of JdbcConnectionProvider will need to add a definition of needsModifySecurityConfiguration. I'm also open to adding a default implementation, but it seemed to me that requiring an explicit implementation of the method was preferable.
A drop-in implementation that would continue the existing behavior is:
override def needsModifySecurityConfiguration(
  driver: Driver,
  options: Map[String, String]
): Boolean = true

How was this patch tested?
Unit tests, but I also plan to run a real workflow once I get the initial thumbs up on this implementation.

Can one of the admins verify this patch?

@gaborgsomogyi

This is not a work in progress as far as I am concerned/aware, but I marked it as a WIP until @gaborgsomogyi can give it an initial thumbs up.

ok to test

Test build #145734 has started for PR 34745 at commit 8a9749c.

Test build #145734 has finished for PR 34745 at commit 8a9749c.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145734/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50204/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50204/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50204/

Can one of the admins verify this patch?

Hello friends! Anything I can do to help move this PR forward? Presently my ability to upgrade past spark 3.0.x is blocked by the change in functionality that this PR aims to improve.

@gaborgsomogyi I've updated the PR to include your suggestions (really just a rename and a comment on why BasicConnectionProvider can always return false). Have another look when you have a chance, please.

Test build #146237 has started for PR 34745 at commit 5666f9e.

Test build #146237 has finished for PR 34745 at commit 5666f9e.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50711/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146237/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50711/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50711/

Have you exexuted the integration tests?

plz fix mima cheks...

Mima check has been fixed (assuming adding an exclude is the appropriate solution). Any idea if the kubernetes failures are something to worry about? I can't tell from the output if that's related to my change. Seems far removed from what I can tell, but it can be hard to tell. I've rebased from master, so perhaps that will help also.

Test build #146293 has started for PR 34745 at commit adc4453.

Test build #146293 has finished for PR 34745 at commit adc4453.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146293/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50765/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50765/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50765/

I think the k8s integration tests are generally borked. If you happen to know that's not true, let me know and I can investigate further.

Test build #146297 has started for PR 34745 at commit 80e3d8e.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50769/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50769/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50769/

Test build #146297 has finished for PR 34745 at commit 80e3d8e.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146297/

Any trick to re-run tests? The spark test that failed in Jenkins passes for me locally. Maybe a transient failure. No rush, I'll force push something if I don't hear back.

Test build #146304 has started for PR 34745 at commit 503eab1.

retest this please

@tdg5 mind taking a look at https://github.com/apache/spark/pull/34745/checks?check_run_id=4554725898 and enable Github Actions in your forked repository? Apache Spark repo uses the GitHub Actions resources of forked repository to run the build.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50776/

Test build #146306 has started for PR 34745 at commit 503eab1.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50778/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50776/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50776/

Test build #146304 has finished for PR 34745 at commit 503eab1.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50778/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50778/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146304/

SparkR test failure doesn't seem to relate to my commit... Rebased from master to force another build.
SparkR test failure seems to have been an ephemeral thing?
* installing the package to build vignettes
* creating vignettes ...Warning in file(con, "r") :
  cannot open file '/tmp/RtmpTxszZ3/xshell185ef769eca3b6': No such file or directory
Error in file(con, "r") : cannot open the connection
Error in setwd(owd) : cannot change working directory
Execution halted
sh: 0: getcwd() failed: No such file or directory

Test build #146313 has started for PR 34745 at commit 4b324b5.

Test build #146306 has finished for PR 34745 at commit 503eab1.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50785/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146306/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50786/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50785/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50785/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50786/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50786/

Test build #146313 has finished for PR 34745 at commit 4b324b5.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146313/

Some of the tests are flaky but we need a green build to merge anything so retest is the way.
Other than that plz update the description to reflect the latest code.

Description updated and another round of tests is underway.

Test build #146359 has started for PR 34745 at commit 3a2b619.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50833/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50833/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50833/

Test build #146359 has finished for PR 34745 at commit 3a2b619.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146359/

Wahoo! All tests passed on the last build. Well, not the k8s integration tests, but I don't get the impression those are blocking. 🎉

There are several manual integration tests which cover this feature, have you executed them manually?

There are several manual integration tests which cover this feature, have you executed them manually?

No, I was unaware of those. Any guidance available for running those? I will look into it next time I'm at a keyboard.

Something like this I'm guessing?
ENABLE_DOCKER_INTEGRATION_TESTS=1 \
POSTGRES_DOCKER_IMAGE_NAME=postgres:14.0 \
MYSQL_DOCKER_IMAGE_NAME=mysql:5.7.36 \
MSSQLSERVER_DOCKER_IMAGE_NAME=2019-CU13-ubuntu-20.04 \
MARIADB_DOCKER_IMAGE_NAME=mariadb:10.5.12 \
DB2_DOCKER_IMAGE_NAME=ibmcom/db2:<IP_ADDRESS>a \
ORACLE_DOCKER_IMAGE_NAME=gvenzl/oracle-xe:latest \
./build/sbt -mem 4096 -Pdocker-integration-tests "testOnly *PostgresKrbIntegrationSuite org.apache.spark.sql.jdbc.PostgresIntegrationSuite org.apache.spark.sql.jdbc.MySQLIntegrationSuite org.apache.spark.sql.jdbc.MsSqlServerIntegrationSuite org.apache.spark.sql.jdbc.MariaDBKrbIntegrationSuite *DB2KrbIntegrationSuite org.apache.spark.sql.jdbc.DB2IntegrationSuite org.apache.spark.sql.jdbc.OracleIntegrationSuite"

If so, I'm trying that now. Seems like a lib and some referenced docker images are out of date. I'm going to open another PR with those updates so I can play unit test roulette in a context I deem less time sensitive than this one.

If I identified the correct integration tests, I can confirm they all pass on this branch when run manually. I'm out of time for the moment, so will have to wait to open the PR with the changes needed to make the docker integration tests work, but here's the diff so you can validate I didn't do anything crazy: https://github.com/tdg5/spark/commit/1d6fff5e313eb35541c2c04054b9cf9291c67962

@tdg5, thanks i think it's getting closer to be merged. but just to be sure, would you mind enabling GitHub Actions in your forked repository? See also https://github.com/apache/spark/pull/34745/checks?check_run_id=4569440425. Jenkins will be retired soon, and we're currently running GitHub Actions for tests (that actually covers more correctly).
I haven't followed the changes and issue here to be honest so I will leave this to @gaborgsomogyi.

The changeset looks good, except the @since... stuff. @tdg5 just to double check the last and most important thing do you have some performance numbers how much is it improved in unsecure case?

Test build #146401 has started for PR 34745 at commit f7b6507.

I added the missing @since with a value of @since 3.1.3. I also corrected the MIMA exception that I had added because I put it in the 3.1->3.2 bucket instead of the 3.2->3.3 bucket. Not sure if the @since changes that, but the MIMA test failed w/o the exception w/ the @since in place, so I imagine it is still required.
Not sure why the GitHub actions aren't working on my fork; they are enabled. I tweaked a couple of other things. Hopefully that helps.
Since I have to play unit test roulette due to the addition of @since, I added the library changes to make the docker integration tests work to this PR also. Let me know if that's a problem or if you have any thoughts on the changes.

@HyukjinKwon , as far as I can tell, it seems I succeeded in properly enabling GitHub actions for my fork 👍🏻 If you still see otherwise, please let me know.
@gaborgsomogyi , can you offer some thoughts on what kind of performance stats are you looking for? Since this is a threading/locking issue, the speed up of being able to open more connections simultaneously can be kind of unlimited depending on how many threads are allocated to doing that kind of work. I don't mind trying to come up with some numbers, but I'm not sure what makes sense to use as a baseline.

Sorry, I think this is a dumb question, but I can't seem to find the answer with google. Is there a nightly snapshot build for 3.3 I can download somewhere?

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50876/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50876/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50876/

Test build #146408 has started for PR 34745 at commit 4aac540.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50883/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50883/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50883/

Test build #146408 has finished for PR 34745 at commit 4aac540.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146408/

Test build #146401 has finished for PR 34745 at commit f7b6507.

This patch fails from timeout after a configured wait of 500m.
This patch merges cleanly.
This patch adds no public classes.

Sorry, I think this is a dumb question, but I can't seem to find the answer with google. Is there a nightly snapshot build for 3.3 I can download somewhere?

 Here you go: https://repository.apache.org/content/groups/snapshots/org/apache/spark
POM would have to have something like:
<repository>
  <id>apache-snapshot-repo</id>
  <name>Apache Snapshot Repository</name>
  <url>https://repository.apache.org/content/groups/snapshots</url>
  <releases>
    <enabled>false</enabled>
  </releases>
  <snapshots>
    <enabled>true</enabled>
  </snapshots>
</repository>

But I think current state of CI seems fine enough to go and merge.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146401/

Test build #146443 has started for PR 34745 at commit a7e9e2e.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50919/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50919/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50919/

Test build #146443 has finished for PR 34745 at commit a7e9e2e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146443/

The updated changes related to running docker integration tests can now be found over here: https://github.com/apache/spark/pull/34979

I should have asked this earlier; how do backports work? Is there more y'all need from me in that regard? I've checked and the code in this PR doesn't cherry pick cleanly into either branch-3.1 or branch-3.2.

I should have asked this earlier; how do backports work? Is there more y'all need from me in that regard? I've checked and the code in this PR doesn't cherry pick cleanly into either branch-3.1 or branch-3.2.

Yeah, it's all as you said. When committers merge, they usually manually resolve conflicts in their local if it's minor. If there's a major conflict, usually they ask the author to create another PR to branch-3.1 or branch-3.2. While we can merge them as is first and you can create backporting PRs, it is often easier to split a PR to multiple PRs that can be backported and not backported.

Thanks @tdg5 - i like how this patch is thoroughly tested. this is a good example to follow :-).

branch-3.1 PR is here: https://github.com/apache/spark/pull/34988

Merging to master. Thank you all !


[BUG] - Build type error

NextUI Version
2.0.13
Describe the bug
Hello everyone, here Ian, nice to meet everyone
I'm having a issue when i run yarn build in my project and I really dont know how to fix it:
./node_modules/@nextui-org/system-rsc/dist/extend-variants.d.ts:22:14
Type error: Type 'CP[K]' is not assignable to type 'string | number | symbol'.
Type 'CP[keyof CP]' is not assignable to type 'string | number | symbol'.
Type 'CP[string] | CP[number] | CP[symbol]' is not assignable to type 'string | number | symbol'.
Type 'CP[string]' is not assignable to type 'string | number | symbol'.
20 | type SuggestedVariants<CP, S> = {
21 |   [K in keyof CP]?: ValidateSubtype<CP[K], string> extends "true"
> 22 |   ? { [K2 in CP[K]]?: GetSuggestedValues<S> }
   |              ^
23 |   : ValidateSubtype<CP[K], boolean> extends "true"
24 |   ? {
25 |     true?: GetSuggestedValues<S>;

I'm using the following dependencies:
"@nextui-org/react": "2.1.13",
"framer-motion": "^10.16.4",
"react": "18.2.0",
"react-dom": "18.2.0",
I already commented each component that uses next ui inside my app and still having the same
Your Example Website or App
No response
Steps to Reproduce the Bug or Issue
"dependencies": {
"@nextui-org/react": "2.1.13",
"framer-motion": "^10.16.4",
"react": "18.2.0",
"react-dom": "18.2.0",
"@reduxjs/toolkit": "^1.9.6",
"@types/node": "20.5.9",
"@types/react": "18.2.21",
"@types/react-dom": "18.2.7",
"autoprefixer": "10.4.15",
"axios": "^1.5.1",
"eslint": "^8.49.0",
"eslint-config-next": "^13.4.19",
"eslint-plugin-unused-imports": "^3.0.0",
"formik": "^2.4.4",
"mongoose": "^7.5.2",
"next": "13.4.19",
"notistack": "^3.0.1",
"postcss": "8.4.29",
"qs": "^6.11.2",
"react-icons": "^4.11.0",
"react-redux": "^8.1.3",
"swiper": "^10.2.0",
"tailwind-variants": "^0.1.14",
"tailwindcss": "3.3.3",
"typescript": "5.2.2",
"yup": "^1.2.0",
"zod": "^3.22.2"
},
"devDependencies": {
"@typescript-eslint/eslint-plugin": "^6.7.0",
"@typescript-eslint/parser": "^6.7.0",
"eslint-config-airbnb": "^19.0.4",
"eslint-plugin-import": "^2.28.1",
"eslint-plugin-jsx-a11y": "^6.7.1",
"eslint-plugin-react": "^7.33.2",
"eslint-plugin-react-hooks": "^4.6.0",
"eslint-plugin-tailwindcss": "^3.13.0",
"prettier": "^3.0.3",
"prettier-plugin-tailwindcss": "^0.5.4"
}
Expected behavior
Is supposed to build without problems, in local works correctly
Screenshots or Videos
No response
Operating System Version
macOS
Browser
Chrome

Apologies for the delayed response. Since this issue has been open for a while, we will be closing it. Please try with the latest version, and if the same error occurs, feel free to open a new issue. Thank you for reporting.


Migration Reconcile cleanup

Refactor MigMigration reconcile
Use generated names for Backup / Restore
Track the associated Backup / Restore objects within MigMigration status

I had the MigMigration reconcile trimmed down pretty well.  Adding in the generated names + Backup/Restore tracking expanded it a bit, but there may be more opportunity for trimming it down.

Before this is merged, I want to move the tracked objects out of Status and into Spec.


Hetzner DNS Challenge Support

What provider would you like to see added to NPM?
Hetzner DNS
Have you checked if a certbot plugin exists?
https://github.com/ctrlaltcoop/certbot-dns-hetzner
PyPI package available: certbot-dns-hetzner

Sorry, just noticed that Hetzner is already available..


Bump CMAKE_CXX_STANDARD to 20

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 88.9%

Totals

Change from base Build<PHONE_NUMBER>:
0%

Covered Lines:
2747

Relevant Lines:
3090

💛  - Coveralls


Use OS Default SecureRandom.

The bug causing /dev/random to be used on Linux is due to the SHA1PRNG(use of which is generally discouraged) instance of SecureRandom being used, use the OS default instance to fix this issue which should properly select /dev/urandom on Linux and have sane defaults on other systems.

@jameshilliard So I was looking at this today and we want to include it. Is it possible for you to redo it against the most recent master? At a minimum, we want to use the default SecureRandom like you suggest.
Also, could you verify that this is still an issue with JDK's 8 or later. If it still is an issue, could you update the comment with references as those bugs refer to much older JDKs
If it's no longer an issue, we won't need the comment in the readme and the build.gradle doesn't need the jvm arg, but we still want to change to using the default SecureRandom.
Also, you will notice that I changed NUID to only create a SecureRandom once and re-use it. This change made creation of a new NUID instance take only 0.02 milliseconds on average versus it used to take 1.6 millis on average (on my machine ; )
I was thinking to pull out the randoms as static to a support [package] class so it can be re-used everywhere. We don't so much need security as we need the larger set of possible numbers that the secure random gives us over regular random.

So I was looking at this today and we want to include it. Is it possible for you to redo it against the most recent master? At a minimum, we want to use the default SecureRandom like you suggest.

Rebased

Also, could you verify that this is still an issue with JDK's 8 or later. If it still is an issue when using the default SecureRandom, could you update the comment with references as those bugs refer to much older JDKs

The bug is present when using the SHA1PRNG but not the default SecureRandom, with this change the bug should be fixed.

Also, you will notice that I changed NUID to only create a SecureRandom once and re-use it. This change made creation of a new NUID instance take only 0.02 milliseconds on average versus it used to take 1.6 millis on average (on my machine ; )

Great.


[Do Not Merge] test for 0.12.1-rc1

Change Logs
Describe context and summary for this change. Highlight if any code was copied.
Impact
Describe any public API or user-facing feature change or any performance impact.
Risk level: none | low | medium | high
Choose one. If medium or high, explain what verification was done to mitigate the risks.
Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

cancelling all azure CI runs for now to investigate CI flakiness. will retrigger build once we are in stable state. sorry about the inconvenience.

@hudi-bot run azure

@hudi-bot run azure

what happened, why you can merge an empty commit ?

what happened, why you can merge an empty commit ?

It's not merge to master.


Update dates for Summit 2024

https://github.com/sqlsaturday/sqlsatwebsite/blob/b1f09fecbafda348c4526f94dbbd8c63b357f869/_data/otherevents.yml#L68
Looks like these need updated to Nov 4-8

Thanks, good catch.

fixed


ModuleNotFoundError: No module named 'playwright'

ModuleNotFoundError: No module named 'playwright'
so i posted this error to chatgpt and it said i need to install the 'playwright' module using pip, the Python package installer.
"pip install playwright"
"playwright install"
i told chat gpt that i got the same error and it said
"My apologies for the confusion, as an AI model, I'm unable to execute Python code or directly interact with your Python environment to check if the module is installed correctly. However, you can check if the Playwright module is installed correctly by running the following command in your Python environment:
python -c "import playwright"
If the command does not output any message, it means that the Playwright module is correctly installed. If it outputs an error message like ModuleNotFoundError: No module named 'playwright', it means that the Playwright module is not installed correctly."
the command does not output any messages but im still getting the same command

(sorry my post doesnt make any sense so ive edited it so now it does)
ModuleNotFoundError: No module named 'playwright'
so i posted this error to chatgpt and it said i need to install the 'playwright' module using pip, the Python package installer.
"pip install playwright"
"playwright install"
so i done that and i got the same error. i told chat-gpt and it said -
"My apologies for the confusion, as an AI model, I'm unable to execute Python code or directly interact with your Python environment to check if the module is installed correctly. However, you can check if the Playwright module is installed correctly by running the following command in your Python environment:
python -c "import playwright"
If the command does not output any message, it means that the Playwright module is correctly installed. If it outputs an error message like ModuleNotFoundError: No module named 'playwright', it means that the Playwright module is not installed correctly."
the command does not output any messages but im still getting the same error

you need to install, tbh should be on the readme doc to install first this also. I think editing the readme to include this step is acceptable and this ticket can be closed.


[#450] Get Heroku CI to play nice with headless chromedriver

This change adds the needed build-packs mentioned in the Heroku Docs
to get chrome headless to run.
That said, there might be alternative changes we could make:

since specs already ran in Travis, just skip them in Heroku
since feature specs take the longest (and already ran in travis), skip the feature specs in heroku
since specs will run in heroku, skip the specs in travis

I am not a fan of this option as setting up heroku on a repo fork is harder than setting up travis

It just seems redundant (not in a useful way) to run the specs multiple times.

I see your point. And generally agree with you. But where we can, we also like to find redundancy so that if one thing fails, we have a backup plan. (Like NASA!)
If this was very hard to do, I'd say skip tests on Heroku CI. But since you've already done it, I say we ship it and continue to CI in both places.


SecretManagement Support

This module should add an extension to support the Powershell SecretManagement.
I'd be happy to write it as a PR for HacktoberFest if you're willing to review!

That would be awesome, I've been thinking about this myself, as I've been following the development of the SecretManagement and SecretStore support.  In a way, I'm glad nothing has been done yet, since the API has changed quite a bit a few times, but I think it's pby stable enough to get started.
I'd be happy to review!


Errors on non-breaking space

I've yet to track down the source file, but compiling this folder using the following command:
sass.compile(dirname=(".", "."), output_style="compressed")

Produces the following error:
Traceback (most recent call last):
  File "C:\Users\le717\Documents\Code\Sites\Own-Domain\build-css.py", line 8, in
 <module>
    sass.compile(dirname=(".", "."), output_style="compressed")
  File "C:\Python34\lib\site-packages\sass.py", line 509, in compile
    include_paths, precision, custom_functions,
  File "C:\Python34\lib\site-packages\sass.py", line 169, in compile_dirname
    output_file.write(v)
  File "C:\Python34\lib\encodings\cp1252.py", line 19, in encode
    return codecs.charmap_encode(input,self.errors,encoding_table)[0]
UnicodeEncodeError: 'charmap' codec can't encode character '\ufeff' in position
0: character maps to <undefined>

Hmmm, this is because the open function in python 3.4 uses the preferred encoding of the system.  Since you're on windows, this is cp1252, which doesn't have a way to represent a non breaking space and turns it into the "unknown" character '\ufeff'
Basically, libsass uses filesystem encoding and you have a file on your filesystem which doesn't match :)
compile would need to grow an encoding parameter to overcome this

I am still unable to track down the file, but I may have found the source of the error:
sass.py, lines 165-169
if s:
    v = v.decode('UTF-8')
    mkdirp(os.path.dirname(output_filename))
    with open(output_filename, 'w') as output_file:
        output_file.write(v)

The file contents are being decoded from bytes to a UTF-8 string, but then are being written to file using the OS's default encoding (in our case, cp1252). Editing the open() to include an encoding parameter, like so:
with open(output_filename, 'w', encoding='UTF-8') as output_file:
Seems to fix the problem.

That'll only work in python3 (and will ignore the OS encoding).  Feels like a good thing to respect the OS's encoding though?
If we want to fix this in the way described above, the 2+3 solution is to use the open function from the io module.

Feels like a good thing to respect the OS's encoding though?

I believe the CSS spec says output is always supposed to be UTF-8 encoded.

If we want to fix this in the way described above, the 2+3 solution is to use the open function from the io module.

Interestingly, the duplicate code in sassutils.builder does just this.

OK, I just hit this bug again so I decided to do some digging and find the root of the error.
As it would turn out out, I have this file that uses \u201c, AKA a curly left double quotation mark (you can see it in use in the blockquote here). Python is chocking on this character for the exact same reason @asottile gave a few months ago: cp1252 does not have a way to represent this character, so when it tries to write the UTF-8 encoded text to file using cp1252 (as I showed in https://github.com/dahlia/libsass-python/issues/72#issuecomment-103555314), it hits the error. For testing purposes, I also added a non-breaking space as I originally thought the code was breaking on and the got the same outcome.

Feels like a good thing to respect the OS's encoding though?

I checked the spec, it is supposed to respect the file's encoding, not the OS's. However, as of 3.4.0 even Sass only outputs UTF-8 encoded CSS because they too hit encoding issues.
Honestly, I still think the best fix here is to from io import open on Py2 and write the file in UTF-8 encoding. What's going on right now is the code is encoding it to UTF-8 at all times but then writing it to file using the OS's encoding. That is me is an oversight and the file should be written using UTF-8 at all times. I know I am not the only one who uses Unicode characters in the CSS (I actually ripped the quotes from a well-known site that uses Sass).
If you would like, I can put up a PR to apply the fix.

seems fine to me, +1 for encoding='UTF-8'


September 2024 Endgame

Endgame Template

Thursday

[x] Ensure that any CI test failures have issues assigned to that area's owner.
[x] Work with the build champ to drive the build to green by fixing/disabling tests or pinging area owners to do so.

Friday

[x] Review Component Governance (Click on "microsoft/vscode-jupyter" on that page) and resolve all High/Severe issues.

[x] Focus on resolving Critical and High priority issues as others will be addressed in the debt week.
[x] Manually add any repository dependencies (if you can't add manually, refer here). Only add a cgmanifest.json if the components are not NPM or are not dev only.
Instructions on updating npm dependencies in package.json & package-lock.json can be found here.

[x] Create new release branch with format release/release-YYYY.MM.

Note: The release branch should not be changed after this step (not including hotfixes)

[x] Create a PR to main with the following changes... (Warning: this should happen right after creating the release branch. If this is deferred till later, the main and release branches can diverge significantly, which may cause merge conflicts.)

[ ] At this point, the vscode engine version should also be the same as in the release branch- will be bumped when the next release happens
[ ] Bump the version number in main to the next monthly ("YYYY.M.0") version number (e.g. if the latest is 2022.2.0, bump it to 2022.3.0).

[ ] Run npm install to update package-lock.json

Monday (Debt/Release week)

[x] Obtain VS Code stable RC for sanity testing
[x] Manually run the Stable pipeline against the release/release-YYYY.MM branch

Enable Publish Extension, you do not need an approval to build the VSIX.
DO NOT ask for approval for the extension publish step, this step should only be done after sanity testing is done and ready to release.

[x] Sanity test release candidate VSIX against VS Code RC
Tip: You can use the dev containers in the this repo for testing against linux (just open the repo and use thd command Dev Containers: Reopen in Container)

[ ] Windows

[ ] win32-x64
[ ] win32-arm64

[ ] macOS

[ ] darwin-x64
[ ] darwin-arm64

[ ] Linux

[ ] linux-arm64
[ ] linux-armhf
[ ] linux-x64
[ ] alpine-arm64
[ ] alpine-x64

[ ] Candidate bug fixes found from sanity test should be checked into main and cherry-picked to release branch

After a candidate fix is merged, a pre-release build can be released by manually running the pre-release devops pipeline against the release branch.

Satelite extensions/npm packages

[ ] Reach out to the owners of each of these to coordinate the releases (if any).

If there are no releases for each of the following, then mark them as done.
Else the ownsers of each to mark as done when they are done.

[x] JupyterHub (@DonJayamanne)

No need to pin VS Code engine
Release directly from main branch (pipeline)
PreRelease directly from main branch manually (pipeline)

[x] Jupyter (Notebook) Renderers (@DonJayamanne)

No need to pin VS Code engine (unless you want to test something against VS Code insiders and not ship to stable users)
Release directly from main branch (pipeline)

[x] Jupyter Powertoys (@DonJayamanne)

No need to pin VS Code engine (unless you want to test something against VS Code insiders and not ship to stable users, e.g. depends on some new Jupyter Extension API)
Release directly from main branch (pipeline)

[x] Jupyter Cell Tags (@rebornix)

No need to pin VS Code engine
Release directly from main branch (pipeline)

[x] Jupyter Slideshow (@rebornix)

No need to pin VS Code engine
Release directly from main branch (pipeline)

[x] Jupyter KeyMap (@rebornix)

No need to pin VS Code engine
Release directly from main branch (pipeline)

[x] Tensorboard (@DonJayamanne)

No need to pin VS Code engine
Release directly from main branch (pipeline)
PreRelease directly from main branch manually (pipeline)

[x] zeromq-prebuilt (@DonJayamanne)

Release directly from main branch (pipeline)
Release by adding a git tag and pushing it upstream (e.g. 6.0.0-beta.16.8)
Can test bundles by manually running and publishing releases to github releases (download and test the bundles manually from github releases)

[x] @vscode/zeromq (@DonJayamanne)

To be done after relesing zeromq-prebuilt
Release directly from main branch (pipeline)

[x] @vscode/jupyter-extension (@DonJayamanne)

Release directly from main/relese branch (pipeline)

[x] Gather (@DonJayamanne)

No need to pin VS Code engine
Release directly from main branch (pipeline)

Tuesday

[ ] Make sure Component Governance is happy
[ ] Release

[ ] Verify the PR Pipeline on Github actions is green against the release branch.
[ ] Approve the Publish stage of the last Stable pipeline that's successfully sanity tested.
[ ] Ensure a tag with the released version number on the commit that was released was created.

This step occurs in the Publish Stage of the stable pipeline linked above.

[ ] If any steps were unclear or changed in this endgame plan please update the endgame_plan.md file to make it clear for the next release

Wednesday/Thursday (Day of VS Code releasing the next insider version)

[ ] Bump the engines.vscode version on the main branch to point to the next version. For example, from 1.58.0 to 1.59.0

As needed

[ ] Determine if a hotfix is needed

Use the same release/release-YYYY.MM branch

[ ] Ensure the version in package.json is updated as follows:

If released version is YYYY.MM.0, then hot fix will be YYYY.MM.1
If released version is YYYY.MM.1, then hot fix will be YYYY.MM.2

[ ] Verify all candidate issues
[ ] Sanity test release candidate VSIX against VS Code RC
Tip: You can use the dev containers in the this repo for testing against linux (just open the repo and use thd command Dev Containers: Reopen in Container)

[ ] Windows

[ ] win32-x64
[ ]
[ ] win32-arm64

[ ] macOS

[ ] darwin-x64
[ ] darwin-arm64

[ ] Linux

[ ] linux-arm64
[ ] linux-armhf
[ ] linux-x64
[ ] alpine-arm64
[ ] alpine-x64

[ ] Ensure that another tag was created for the new version's commit.

If a tag was not pushed, investigate in the  Publish Stage of the stable pipeline linked above, and manually add one using: git tag -a YYYY.MM -m YYYY.MM -s -f

Sanity test for release:

[ ] Windows

[ ] win32-x64
[ ] win32-arm64

[ ] macOS

[ ] darwin-x64
[ ] darwin-arm64

[ ] Linux

[ ] linux-arm64
[ ] linux-armhf
[ ] linux-x64
[ ] alpine-arm64
[ ] alpine-x64

[ ] Web

Sanity test for release round 2:

[ ] Windows

[ ] win32-x64
[ ] win32-arm64

[ ] macOS

[ ] darwin-x64
[ ] darwin-arm64

[ ] Linux

[ ] linux-arm64
[ ] linux-armhf
[ ] linux-x64
[ ] alpine-arm64
[ ] alpine-x64

I assume this is done.


Trim usernames entered in setup screens

Trim usernames in setup views

fix #5800

:+1:
Can you please rewrite the commit messages to not include the issue number in the first line of the commit message. Please also start the message with a capital letter to be consistent with the project's style.
I typically don't include the issue number in commit messages at all, because every mention will add an entry to the timeline in the issue.

This gets especially annoying when rewriting/rebasing commits. I find it sufficient to mention the issue number at the end of the description of a pull request. See e.g. here: https://github.com/k9mail/k-9/pull/5859
Please also don't include the issue number in the title of the pull request. For the title of the pull request please describe what the change is about. Sometimes the most succinct description is "Fix [short description of the problem]". But most of the time you can come up with something more descriptive. In this case "Trim usernames entered in setup screens" would probably a good choice.

Hi, I renamed the PR and the commits. Next time I also do not use the issue number in my branch name.

Thank you :+1:


Root permission not requested

Hey I just found your app on fdroid. When I launch it I get the image "y u no allow root" but the app didnt request it. And I couldnt find a seting to manually trigger an attempt. I have a OnePlus Nord N10 5G on Android 10 with Magisk 22.1.

🤔 Interesting... I'll see what I can do about this.

Are you sure the app didn't request root? Other users have had it request fine. Is there a setting within your Magisk installation that could be preventing the dialog from appearing?
Thanks for opening an issue, btw :)

Im positive because it would show under Magisk as denied most likely since I didnt allow it. The only thing I could see possibly causing an issue is having biometric suppport on. But again, it would come up as denied root in Magisk.

@Kreuger Hmm, that's very strange that it doesn't even show up in the list.
I'll see about adding a prompt button to the "y u no allow root" page.

Cool thanks man.

@Kreuger I added some settings. See if they do the job :)
scoop-release rootpref.zip
Commit so you can see the changes: https://github.com/TacoTheDank/Scoop/commit/4d2fddc210bf6ceb805d72cb15691737e1201afa
Might as well do some testing too. Could you tell me if the permission status setting summary changes when (or I guess if) root is granted and you restart the app? That mean taking note of it saying "READ_LOGS permission is denied" first, and then it changing to "READ_LOGS permission is granted." Thanks!

Thanks for working on this. Tapping the button to request root manually doesnt seem to do anything. No toast notification and it didnt request root from what I can tell.

Thanks for working on this. Tapping the button to request root manually doesnt seem to do anything. No toast notification and it didnt request root from what I can tell.
Edit: I figured it out! In Magisk I had to "reset" the app because I had used the setting to hide it from apps looking for it. As soon as I opened Scoop after that, the toast requesting root came up and I didnt need to try manually.

Lol I had a feeling it had to do with Magisk. The settings I added launched the same commands as the app did on startup, so I figured it probably wouldn't have actually helped. Thanks for figuring it out!


Don't add completion for method if the this parameter doesn't match

Fixes #20608

Are we okay with this change if it means you can't get completions to use .call, .bind, or .apply?

I would think so because it's unusual to do a.foo.call(b) when foo is a method. (This change wouldn't affect a property.)
If you meant that we wouldn't get completions for function f() {} f./**/, I don't see why, because call has a parameter this: Function and typeof f should be assignable to Function.

Waiting for confirmation from @DanielRosenwasser

👍


chore(readme): update start command & website url

Just some small changes:

Since we have a dedicated subdomain, I've update the uptime detection badge & link
The command to start the local dev server was not correct, which is fixed now

Codecov Report

Merging #17 (bdd736f) into main (4330b39) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #17   +/-   ##
=======================================
  Coverage   70.89%   70.89%
=======================================
  Files          20       20
  Lines         292      292
  Branches       22       22
=======================================
  Hits          207      207
  Misses         85       85

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4330b39...bdd736f. Read the comment docs.


avoid openstack zone externalid equals

这个 PR 实现什么功能/修复什么问题:
修复OpenStack zone externalId相同导致同步wire失败
是否需要 backport 到之前的 release 分支:

release/2.10.0
release/2.9.0
release/2.8.0

/cc @swordqiu

Codecov Report

Merging #1265 into master will increase coverage by 0.03%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #1265      +/-   ##
=========================================
+ Coverage    7.86%   7.89%   +0.03%
=========================================
  Files         371     370       -1
  Lines       58157   58048     -109
=========================================
+ Hits         4573    4582       +9
+ Misses      53185   53067     -118
  Partials      399     399

Flag
Coverage Δ

#aFlag
7.89% <0%> (+0.03%)
:arrow_up:

Impacted Files
Coverage Δ

pkg/compute/models/wires.go
2.19% <0%> (ø)
:arrow_up:

pkg/compute/models/vpcs.go
2.11% <0%> (-0.08%)
:arrow_down:

pkg/appsrv/response.go
66.15% <0%> (-3.08%)
:arrow_down:

pkg/baremetal/tasks/baseprepare.go
0% <0%> (ø)
:arrow_up:

pkg/baremetal/tasks/bm_register.go

pkg/util/rbacutils/rbac.go
75.7% <0%> (+3.47%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d7f7bc...9f72206. Read the comment docs.

/approve
/lgtm


Verification returns {}

It will be good to have a string that confirms the verification status like "Verified" or "Email already exists" etc. This will help the client side code to determine what to do next.

Done


mobile menu categories not found problem

hi , on velocity theme when you on mobile menu and browser categories and subcategories it returns 404 not found its even on live demo .

@farshadff
please specify the bagisto version on which you are getting this issue.
Also, once take a pull from the master branch as this issue does not exist in master

@vaishaliwebkul the showing is fine but the links are broken . this bug even exits on your live demo on website i mean if you visit the site and go on mobile menu the sub menu links are all broken and 404

@farshadff
Thanks for notifying this.
bagisto demo is currently not updated, it's running on 1.1.0 version and the issue is resolved in master, so you can pull from the master branch then check.

@vaishaliwebkul yes right its fixed in new version thanks

Ok nice. I have the same problem. In Which files i have to make changes so that subcategories links works on mobile (404 error). When you say master branch-> you mean that i have to download the whole project again... No this is not a solution for me  I allready deploy bagisto to a webserver and i have made several changes. I just need to tell in which files is the issue and how to fix them More simple tell me  which files i have to take from master and replace them to my server....


Deprecating Headers matcher before removal on Traefik v3

Welcome!

[X] Yes, I've searched similar issues on GitHub and didn't find any.
[X] Yes, I've searched similar issues on the Traefik community forum and didn't find any.

What did you expect to see?
Current behavior
Headers matcher only works on Traefik v2 but is abruptly removed on Traefik v3 without deprecating it first. (https://doc.traefik.io/traefik/master/migration/v2-to-v3/#matchers)
Just like Traefik v2.10 supports both old and new API Versions (treafik.containo.us and traefik.io) the same logic should apply for this matcher rule to allow a smooth transition.
Proposed behavior
Some people may be using the Headers matcher on Traefik v2, but we need some transition versions that support both Headers and Header to migrate them without disrupting any services.
spec:
  routes:
    - kind: Rule
      match: >-
        Headers(`content-type`,`application/grpc`)
        .
        .
        .
    - kind: Rule
      match: >-
        Header(`content-type`,`application/grpc`)
        .
        .
        .

+1

Hello @rsaldano,
This issue looks to have been more or less fixed by https://github.com/traefik/traefik/pull/10339.
I'm closing it accordingly, but feel free to ask to reopen it.


The same Node but with Date

Is your feature request related to a problem? Please describe.
Your Node is so simple and easy to use. i love it. But i can not found any one that do the same with date.
I search a lot to find a node that switch with date.
Now i do it with a template node and a switch node.
Describe the solution you'd like
The same as the time node with date.

Thanks for your feedback. That's an interesting use case that could be implemented with an additional node for dates.

Thanks for your answer.
yes i think it would be great when this would be a new node.
it would also be cool when you can use some special days like "first advent", "eastern", and more.
and also an offset of days. example: first advent + 1 day.
I use this at the moment for my christmaslight and others things that only run in the summertime.
at the moment i have a template node and a switch node to do that.
in the template node i have this:
{% set first_advent = now().replace(day=25, month=12) - timedelta(days = 21 + now().replace(day=25, month=12).isoweekday() ) %}
{{ first_advent <= now() <= now().replace(day=31, month=12) or now() <= now().replace(day=8, month=1) }}

Thanks for your work.


Can't build the framework for iOS

Even specifying the platform:
carthage update --platform=ios
Only the the framework for OS X built.
What's wrong?

Oh, this is bad, I didn't realise that I broke the Carthage behaviour when adding multiple projects, will fix that asap, thanks!

This should now be fixed, please verify! :)

@blommegard Thank you. Now I can build FlagKit.framework for iOS target without any problem. But there's a warning :
*** Building scheme "FlagKit-OSX" in FlagKit.xcodeproj
*** WARNING: Skipping build for "macosx" SDK because the necessary signing identity "-" is not installed

Hum, :heart: code signing, think it should be fixed now anyway.

:+1: Thanks a lot.


Major Changes befor publishing to Pypi

Changes in this repo

Deployed docs fs_filepicker
Added GitHub actions for linting and greeting to new contributors
Adeed ISSUE_TEMPLATE and PULL_REQUEST template
Revamp setup.py for publishing to PyPi

move the several _test subdirs to a tests dir. The benefit is that we don't need to deploy them to users.

Good start for future work on this :) I look in to details later.

Local called pytest shows
FAILED tests/test_fs_filepicker.py::flake-8::FLAKE8 - AttributeError: 'Application' object has no attribute 'parse_preliminary_options'
FAILED tests/test_icons.py::flake-8::FLAKE8 - AttributeError: 'Application' object has no attribute 'parse_preliminary_options'
FAILED tests/test_testdata.py::flake-8::FLAKE8 - AttributeError: 'Application' object has no attribute 'parse_preliminary_options'
FAILED tests/test_utils.py::flake-8::FLAKE8 - AttributeError: 'Application' object has no attribute 'parse_preliminary_options'

@Mr-Sunglasses How should we proceed. We can create further issues, for the open parts and merge this one. What do you think?

Yup we can merge it, I will do some changes after then we can merge it and then we can break it down into other issues.


dvclive: Add log_image and log_plot

Closes #3013 .
P.R. for https://github.com/iterative/dvclive/pull/189
Depends on #3147

Depends on #3147

Labeling waiting-for-core-merge for now... Thanks

I think there are other references to metrics history and metrics summary in the docs. How should those be handled?

Sorry, missed that this is still in draft mode! Ping whenever you are ready for review.

Overall, I think it looks really good, and the docs are starting to read more like a full-featured (but still minimalist) ML logger! 🔥


Remove extra space

Found this while trying to search using copy and paste from the console which must be stripping the extra space

Thanks for another contribution. We only accept PR into next branch (which is a bit ahead of master). See the readme for more details.


Feature:

Feature description
Adding the best book 'Data Structures and Algorithms Made Easy by Narasimha Karumanchi' to improve DSA concepts in much less time.
👀 Have you spent some time to check if this issue has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Hey @SauravMukherjee44, Please assign me to this issue.
I am working on it.
There are some issues with the website, but my work can fix them.

I would like to work on this issue ,please assign me this issue under GSSOC-23.


Error message when opening modded week in story tab.

Describe your problem here.
I was transferring files from an older psyche engine model (ver 0.4.2) to the most recent build (ver 0.6.3) so I could have a better experience, and everything was going fine and dandy until I tried playing the first week in my mod. This showed up and I'm not sure how to handle/fix it.

Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
No response

Check ur mods/images/menucharacters


Dev week3

Added image service and blobstore so that the to do list can parse an image with a to do list on it, either hand written or printed.

hey, I tried doing what you suggested, but It looks like the merging the branch DevWeek2-Review to the master branch didn't work properly, and that may be why.

@andrewrubinstein this PR still looks kinda big. Can you try running git pull origin master and push those changes? I'm hoping that will make the diff a bit smaller.


Aggregate UDF support

Hey all,
This PR is a beginning for the aggregate UDF support with four CreateAggregateFunction() in the duckdb::Connection. These functions are based on the static interface of the built-in aggregate functions, then users must implement such interface and a structure state to create a new aggregate UDF, for instance the average function bellow:
template <class T> struct udf_avg_state_t {
	uint64_t count;
	T sum;
};

struct UDFAverageFunction {
	template <class STATE> static void Initialize(STATE *state) {
		state->count = 0;
		state->sum = 0;
	}

	template <class INPUT_TYPE, class STATE, class OP>
	static void Operation(STATE *state, INPUT_TYPE *input, nullmask_t &nullmask, idx_t idx) {
		state->sum += input[idx];
		state->count++;
	}

	template <class INPUT_TYPE, class STATE, class OP>
	static void ConstantOperation(STATE *state, INPUT_TYPE *input, nullmask_t &nullmask, idx_t count) {
		state->count += count;
		state->sum += input[0] * count;
	}

	template <class STATE, class OP> static void Combine(STATE source, STATE *target) {
		target->count += source.count;
		target->sum += source.sum;
	}

	template <class T, class STATE>
	static void Finalize(Vector &result, STATE *state, T *target, nullmask_t &nullmask, idx_t idx) {
		if (!Value::DoubleIsValid(state->sum)) {
			throw OutOfRangeException("AVG is out of range!");
		} else if (state->count == 0) {
			nullmask[idx] = true;
		} else {
			target[idx] = state->sum / state->count;
		}
	}

	static bool IgnoreNull() {
		return true;
	}
};

The new user-defined aggregate function must strictly implement the methods (Initialize(), Operation(), ConstantOperation(),  Combine() and Finalize()) with their signature shown in the example above, otherwise the UDF won't compile.
An example to create an aggregate UDF would be:
	con.CreateAggregateFunction<UDFAverageFunction, udf_avg_state_t<double>, double, double>("udf_avg");

	con.Query("CREATE TABLE doubles (d DOUBLE)");
	con.Query("INSERT INTO doubles VALUES (1), (2), (3), (4), (5)");
	con.Query("SELECT udf_avg(d) FROM doubles")->Print();

Note that the UDFAverageFunction and udf_avg_state_t are the first two template parameters for the function CreateAggregateFunction(), the others are the return and input type, the name of the UDF is passed as argument "udf_avg".
The complete interface for aggregate UDFs is the following:
	//-------------- Unary Aggregate UDF with only template paramenters --------------//
	template<typename UDF_OP, typename STATE, typename TR, typename TA>
	void CreateAggregateFunction(string name);

	//-------------- Binary Aggregate UDF with only template paramenters --------------//
	template<typename UDF_OP, typename STATE, typename TR, typename TA, typename TB>
	void CreateAggregateFunction(string name);

	//-------------- Unary Aggregate UDF using template  and arguments --------------//
	template<typename UDF_OP, typename STATE, typename TR, typename TA>
	void CreateAggregateFunction(string name, SQLType ret_type, SQLType input_typeA);

	//-------------- Binary Aggregate UDF using template  and arguments --------------//
	template<typename UDF_OP, typename STATE, typename TR, typename TA, typename TB>
	void CreateAggregateFunction(string name, SQLType ret_type, SQLType input_typeA, SQLType input_typeB);

Thanks for the PR! The code looks very good already :)
Perhaps one small caveat: an aggregate does not need to have a Combine method. For example the built-in string_agg method does not have one. This has some consequences for the aggregate (i.e. it can't be parallelized). Not very important, but perhaps we can think of a manner of implementing aggregates such that the Combine method is optional.

What about a default flag has_combine: void CreateAggregateFunction(string name, bool has_combine = true)?

I think for now it is fine to require a combine method. I will merge it as is, we can expand on it later. Thanks for the PR!


Migrate "go-helpers" repository into "go-common" repository

Pull requests

https://github.com/Senzing/go-common/pull/16


Setup image repository for helm install charts

helm3:
When helm deploys applications, can it specify the image repository, just like kubeadm does?
kubeadm config images pull --image-repository xxx

Hi, @novohool. Is this works for you?
helm install mychart ./mychart --set image.repository=newrepo

Hi, @novohool. Is this works for you?
helm install mychart ./mychart --set image.repository=newrepo

set just configures the variables that have been defined in values.yaml. What I want here is obviously to define the image mirror repository.


Refactor forward_hpu of RMSNorm

This PR removes unused code paths and imports from RMSNorm.forward_hpu.

Testing the PR: https://tf-jenkins-ctrl01.habana-labs.com/job/vLLM/job/dev-run/815/

Had to re-run the experiment due to failing sampling feature and numa configuration. New link to the experiment:
https://tf-jenkins-ctrl01.habana-labs.com/job/vLLM/job/dev-run/819/
Link to gerrit: https://gerrit.habana-labs.com/#/c/438304/2
The experiment failed with following error:
INFO 07-29 13:36:01 metrics.py:295] Avg prompt throughput: 8.4 tokens/s, Avg generation throughput: 0.2 tokens/s, Running: 1 reqs, Swapped: 0 reqs, Pending: 0 reqs, GPU KV cache usage: 0.1%, CPU KV cache usage: 0.0%.
ERROR 07-29 13:36:02 async_llm_engine.py:54] Engine background task failed
ERROR 07-29 13:36:02 async_llm_engine.py:54] Traceback (most recent call last):
ERROR 07-29 13:36:02 async_llm_engine.py:54]   File "/root/mlperf_inference/code/vllm-fork/vllm/engine/async_llm_engine.py", line 44, in _log_task_completion
ERROR 07-29 13:36:02 async_llm_engine.py:54]     return_value = task.result()
ERROR 07-29 13:36:02 async_llm_engine.py:54]   File "/root/mlperf_inference/code/vllm-fork/vllm/engine/async_llm_engine.py", line 619, in run_engine_loop
ERROR 07-29 13:36:02 async_llm_engine.py:54]     result = task.result()
ERROR 07-29 13:36:02 async_llm_engine.py:54]   File "/root/mlperf_inference/code/vllm-fork/vllm/engine/async_llm_engine.py", line 562, in engine_step
ERROR 07-29 13:36:02 async_llm_engine.py:54]     request_outputs = await self.engine.step_async(virtual_engine)
ERROR 07-29 13:36:02 async_llm_engine.py:54]   File "/root/mlperf_inference/code/vllm-fork/vllm/engine/async_llm_engine.py", line 242, in step_async
ERROR 07-29 13:36:02 async_llm_engine.py:54]     output = await self.model_executor.execute_model_async(
ERROR 07-29 13:36:02 async_llm_engine.py:54]   File "/root/mlperf_inference/code/vllm-fork/vllm/executor/habana_executor.py", line 188, in execute_model_async
ERROR 07-29 13:36:02 async_llm_engine.py:54]     output = await make_async(self.driver_worker.execute_model
ERROR 07-29 13:36:02 async_llm_engine.py:54]   File "/usr/lib/python3.10/concurrent/futures/thread.py", line 58, in run
ERROR 07-29 13:36:02 async_llm_engine.py:54]     result = self.fn(*self.args, **self.kwargs)
ERROR 07-29 13:36:02 async_llm_engine.py:54]   File "/root/mlperf_inference/code/vllm-fork/vllm/worker/worker_base.py", line 271, in execute_model
ERROR 07-29 13:36:02 async_llm_engine.py:54]     output = self.model_runner.execute_model(
ERROR 07-29 13:36:02 async_llm_engine.py:54]   File "/usr/local/lib/python3.10/dist-packages/torch/utils/_contextlib.py", line 115, in decorate_context
ERROR 07-29 13:36:02 async_llm_engine.py:54]     return func(*args, **kwargs)
ERROR 07-29 13:36:02 async_llm_engine.py:54]   File "/root/mlperf_inference/code/vllm-fork/vllm/worker/habana_model_runner.py", line 1371, in execute_model
ERROR 07-29 13:36:02 async_llm_engine.py:54]     output = self.model.sample(
ERROR 07-29 13:36:02 async_llm_engine.py:54]   File "/root/mlperf_inference/code/vllm-fork/vllm/worker/habana_model_runner.py", line 198, in sample
ERROR 07-29 13:36:02 async_llm_engine.py:54]     return self.model.sample(*args, **kwargs)
ERROR 07-29 13:36:02 async_llm_engine.py:54]   File "/root/mlperf_inference/code/vllm-fork/vllm/model_executor/models/llama.py", line 407, in sample
ERROR 07-29 13:36:02 async_llm_engine.py:54]     next_tokens = self.sampler(logits, sampling_metadata)
ERROR 07-29 13:36:02 async_llm_engine.py:54]   File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1535, in _wrapped_call_impl
ERROR 07-29 13:36:02 async_llm_engine.py:54]     return self._call_impl(*args, **kwargs)
ERROR 07-29 13:36:02 async_llm_engine.py:54]   File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1585, in _call_impl
ERROR 07-29 13:36:02 async_llm_engine.py:54]     result = forward_call(*args, **kwargs)
ERROR 07-29 13:36:02 async_llm_engine.py:54]   File "/root/mlperf_inference/code/vllm-fork/vllm/model_executor/layers/sampler.py", line 96, in forward
ERROR 07-29 13:36:02 async_llm_engine.py:54]     sample_results, maybe_sampled_tokens_tensor = _sample(
ERROR 07-29 13:36:02 async_llm_engine.py:54]   File "/root/mlperf_inference/code/vllm-fork/vllm/model_executor/layers/sampler.py", line 658, in _sample
ERROR 07-29 13:36:02 async_llm_engine.py:54]     return _sample_with_torch(
ERROR 07-29 13:36:02 async_llm_engine.py:54]   File "/root/mlperf_inference/code/vllm-fork/vllm/model_executor/layers/sampler.py", line 543, in _sample_with_torch
ERROR 07-29 13:36:02 async_llm_engine.py:54]     sample_results = _greedy_sample(seq_groups, greedy_samples)
ERROR 07-29 13:36:02 async_llm_engine.py:54]   File "/root/mlperf_inference/code/vllm-fork/vllm/model_executor/layers/sampler.py", line 288, in _greedy_sample
ERROR 07-29 13:36:02 async_llm_engine.py:54]     samples_lst = samples.tolist()
ERROR 07-29 13:36:02 async_llm_engine.py:54] RuntimeError: [Rank:0] FATAL ERROR :: MODULE:PT_LAZY Error, ValidateSyncInputTensors tensor_data is empty. Tensorid:951931 QueueStatus:ThreadPool m_tasks size: 0 irValue:id_2459742_model/31/self_attn/attn/hpu__input
Exception in callback functools.partial(<function _log_task_completion at 0x7efc839348b0>, error_callback=<bound method AsyncLLMEngine._error_callback of <vllm.engine.async_llm_engine.AsyncLLMEngine object at 0x7efc7fc5c610>>)
handle: <Handle functools.partial(<function _log_task_completion at 0x7efc839348b0>, error_callback=<bound method AsyncLLMEngine._error_callback of <vllm.engine.async_llm_engine.AsyncLLMEngine object at 0x7efc7fc5c610>>)>


impressive repo

I happened to notice that as a "used by" of kerchunk.
There are a good number of examples and even benchmarks here that seem to make kerchunk look good. Do you have any overall feedback at this stage? It would be good to publicise what is here also on the kerchunk examples page.
All are welcome to join the conversation at https://gitter.im/pangeo-data/cloud-performant-netcdf4

Thanks @martindurant!
Thanks for your work on kerchunk also - we think it is great! Will have to think a little if there are any improvements...
At one point I thought it would be cool if it was possible to have an intake driver for the kerchunk reference generation that allowed use of the neat caching that intake provides.
If I think of anything else I will raise an issue on kerchunk and take a look over the discourse.


Conditional Access not working?

i have a functional P2S VPN with native Azure Active Directory authentication, however, the Contidional Access and MFA don't seem to be working. I have configured a CA policy that should require a compliant device and MFA, however, when tested from BYOD (noncompliant device) the connection works anyway, which, I understand, isn't a correct behavior.
strangely enough, when checking the Azure VPN application Sign-Ins blade, there are no records. Yet, the connection wokrs, so this only makes me confused. Can anyone please clarify how Conditional Access should be used with Azure AD authenticated P2S VPN, or if it's actually supposed to be working at all. thx

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a3113b20-0f6c-988e-444b-eff387f3ffef
Version Independent ID: ded2a816-93c7-a4b3-1ec2-c29ce86cd492
Content: About Azure Point-to-Site VPN connections
Content Source: articles/vpn-gateway/point-to-site-about.md
Service: vpn-gateway
GitHub Login: @cherylmc
Microsoft Alias: cherylmc

@jurajgh  Thank you for reaching out. We will investigate and update the thread further.

update: so I just tried with a regular (test) user account, and the Sign-Ins blade does list sign ins for it, however, the Conditional Access policy still doesn't apply. If I reconfigure the CA policy to apply to "All applications", it starts working for Azure VPN as well. this, however, doesn't solve the problem, as we need CA policies to be applied to particular apps, instead of all of them.
not sure why my account (global admin) would be ommited from Sign-Ins blade, though...

update#2: the Sign-Ins blade reports the policy as "Not applied", while the "What if" tool in the Conditional Access "home" blade lists the policy in "Policies that will apply" list. now i'm totally confused.

@jurajgh , I have tested it out by creating a CA policy by enforcing MFA for all devices.
Connected to P2S with global account and I am able to see the Sign-in logs for the connect attempt of Azure VPN. I got a prompt for MFA as well.
Your scenario needs deeper investigation as it seems to be more specific to your environment. I would suggest you to create a post in Microsoft Q&A with the correlation ID and timestamp which you see in the sign-in logs for further analysis.

@msrini-MSFT what correlation ID? the account does NOT get logged in the Sign-Ins blade, so how do I get the correlation ID?
thx for trying to reproduce - just for clarification - did you configure you CA policy so it applies to a particular app (Azure VPN), or all apps? as for the MFA prompt - could've been triggered in your test just by simply never being MFA'd in the browser window. could you try enforcing Compliant device insteaf of MFA?

I have excactly the same issue, is there a solution or a workaround?

nope, still not working..
@msrini-MSFT any update, please? as you can see from my response, there's no correlation ID to post in Microsoft Q&A, since the records don't appear in the Sign-ins panel.

I too have this issue. Followed this tutorial step by step, double checked everything, but the conditional access policy is simply ignored.

Today I have a conf. call with Microsoft hopefully this will help else I have to find another solution

@pvdwerf any news on this, pls? you seem to be the only source of information :)

I talked with Microsoft support and they told me that this is related to my Windows 10 image witch is Azure AD (or Hybrid) joined to the domain.
All of our devices we used for test are Windows 10 - some 1803, some 1809. All are Hybrid Azure AD Joined. We wanted to use Azure AD Conditional Access for multi factor and device compliance for VPN.
"If you run dsregcmd /status on one of your clients, you get output like this:
AzureAdPrt : YES
AzureAdPrtUpdateTime : 2019-04-03 07:18:12.000 UTC
AzureAdPrtExpiryTime : 2019-04-17 07:18:25.000 UTC
So the Primary Refresh Token (PRT) is valid for 14 days, this PRT is periodically refreshed if you have a connection to Azure AD. When your devices are Hybrid Azure AD Joined, a valid MFA claim is included in the PRT and so your devices will always pass MFA and will never prompt for MFA for the user that is assigned to the Hybrid AAD Joined device.
There is no way to change this, there is no way to prompt for another MFA factor and nothing seems to be planned from the engineers - at least we haven't been told._"
Other words it seems to be related to Hybrid/Azure joined and PRT (14 days).
See https://social.msdn.microsoft.com/Forums/sqlserver/en-US/38c889c7-6b28-4559-b85f-4da4a0a369cd/conditional-access-not-prompting-users-for-mfa?forum=WindowsAzureAD for more information.

Similar situation and context:

added CA weeks after deploying the application to users.

Clients are domain joined and workplace joined (not Hybrid).

No entries in the logins pane, the policy only went into enforcement 3 days ago at the time of this post.  CA is configured to grant on MFA or "Device Marked as Compliant."
Even in other CA Apps if there is no visible-to-the-user challenge we see entries in the signin log.  I am concerned as in our case, this could be the only access log of the p2s service...  I dont even find any correlated events in the azuread audit log


rkt/matchUUID: fix match when uuid is an empty string

After the patch, if the uuid is an empty string then matchUUID(uuid string)
returns no matches instead of all the pods.
This is done to avoid rkt rm or rkt enter to delete or enter pods
without intending to.
Fixes https://github.com/coreos/rkt/issues/2806

ok to test

How does it look like with this patch when users run rkt rm "" or rkt enter ""?

rkt rm ""

rm: unable to resolve UUID: no matches found for ""
rm: failed to remove one or more pods

Maybe the second line of the error message can be avoided when there are no matches.

Two comments here:

this could benefit from using a typed error ErrNoEmptyUUID
this is killing the (only?) way to act on all pods. I'm not sure if this feature has some real usecases. If so, should we introduce a special wildcard instead?

I agree on the wildcard, but before if you were running 'sudo rkt rm ""'
rkt was not going to delete all the pods anyway. It says 'ambiguous UUID'
this just catch a typing error.
That been said, I totally agree about the wildcard, but this should be a
RFE in a different PR. Which I can do it tomorrow.
On Thursday, June 16, 2016, Luca Bruno<EMAIL_ADDRESS>wrote:

Two comments here:

this could benefit from using a typed error ErrNoEmptyUUID
https://github.com/appc/spec/blob/master/schema/types/uuid.go#L27
this is killing the (only?) way to act on all pods. I'm not sure if
this feature has some real usecases. If so, should we introduce a special
wildcard instead?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/coreos/rkt/pull/2807#issuecomment-226565670, or mute
the thread
https://github.com/notifications/unsubscribe/AGRc7ydEaG2LSqcP6ShTLJJQEyrA5fyFks5qMZCFgaJpZM4I3RWH
.

Patch updated.
@lucab I will open a specifci an issue for wildcard

New error output
sudo rkt enter ""
enter: problem retrieving pod: UUID cannot be empty

sudo rkt rm ""
rm: unable to resolve UUID: UUID cannot be empty
rm: failed to remove one or more pods

One comment inline and some additional notes:

No need to specify the function in commit title, rkt/uuid should be enough.
Can you please also add a test for this?

Patch updated. @lucab test added.

patch updated. @lucab this should be cleaner

Yes, thanks! LGTM, mergeable once builders are done.

TestRmEmptyUUID passed, fedora-23 failure seems unrelated.

@alepuccetti yes that's #2287. I'm merging this.


add ibmcloud oauth config overrides. Enables ROKS integration with IBM Cloud IAM

Solves: https://github.com/openshift/hypershift/issues/224

/hold
Till Cesars config pr goes in

/test e2e-aws

please let's make sure to squash commits and add a commit desc before shipping this

/test e2e-aws

commits squashed.

/test e2e-aws

/lgtm

/approve

/unhold


AMQNET-576: Clean out old code base for NMS AMQP client provider.

The first step to replacing the NMS AMQP client with a fully managed client based on AMQPNetLite is to remove the old implementation.

The move of legacy code was done properly now on the Apache repo, this PR needs to be rebased and squashed into one commit for review.

This looks like it could be closed now given a new PR(#2) with the client code is now open

Per the last comment, and because the old repository is gone and a new one ready to replace it, I'm closing this pull request.


Duplicate file path found in the Iceberg metadata snapshot

We have our connectors running and sinking data to our Iceberg catalog in Glue/S3. However when trying to surface the data in Snowflake a few of these iceberg tables ran into this error from Snowflake.
Duplicate file path found in the Iceberg metadata snapshot. Please check that your Iceberg metadata generation is producing valid manifest files and refresh to a newer snapshot once fixed.
We are still trying to sort out where/why this is happening by combing through the manifest and snapshot files.
But looks like the tabular connector has created some invalid duplicates within the snapshot files.

Error in full: " Duplicate file path seen in the Iceberg metadata snapshot. Please check that your Iceberg metadata generation is producing valid manifest files and refresh to a newer snapshot once fixed. File path: '//data/.parquet', SnapshotId: '<snapshot_ID>’."
Can confirm that the tabular connector is periodically writing out duplicate filepaths in the snapshots. I used the current manifest file and found the snapshot ID referenced in the error. This snapshot ID pointed to an avro file in it's "manifest-list" key. I opened that file and found 4 objects pointing to different metadata avro files. I opened the first one which had 4 objects, 2 sets of duplicates. One of the pairs pointed to the parquet file that was referenced in the error.
Tabular connector had written duplicate filepaths.
With snapshot retention set to a minimum of 1 day, that means whenever this happens my iceberg table will not be queryable for 24 hours.
This is a problem.


Tabs fullWidth inconsistent with default CSS

[x] This is a v1.x issue (v0.x is no longer maintained).
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior
The Tab component has a fullWidth prop, but the default maxWidth in the component implementation is set to 264px
https://github.com/mui-org/material-ui/blob/e221142238ebc5138dbee3c21b05abfbef67489f/packages/material-ui/src/Tab/Tab.js#L14
Current Behavior
Setting the fullWidth prop requires the user to also override the root css if they want a tab width bigger than 264px
Steps to Reproduce (for bugs)

https://codesandbox.io/embed/007nxpjz2n
make the window wider than 264 * 2 and see that they are not fullWidth

Context
The fullWidth prop is deceiving, had to chase down the unexpected behavior in devtools
Your Environment

Tech
Version

Material-UI
v1.2.2

React
16.x.x

browser
Chrome 67

etc
Sierra 10.13.2

The fullWidth prop is deceiving, had to chase down the unexpected behavior in devtools

@deltaskelta I'm having a hard time seeing a case where the max-width can be a problem. I would consider it a safeguard against displaying something unusable. Still, I do get the point that it's deceiving. Do you want to work on it?

The case I just had was that I had two tabs in a div that was just a little bit bigger than double the maxWidth. I ran through pretty much all the css on the parent elements before I realized that maxWidth doesn't mean maxWidth.
I am wondering how the lack of maxWidth could deliver something unusable?
I can work on it, but I won't be able to start right away until I finish some other stuff first. Does this maxWidth problem go much deeper than just deleting the css?

Ok, I'll make a PR soon then. Thanks!

@deltaskelta Awesome, anytime you want.


fix danger errors

Description

remove hostnames located in code.
remove renamed files to prevent errors on non-existent filenames

Issues Resolved
[List any existing issues this PR resolves]
Contribution Check List

[ ] All tests pass.
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable
[ ] New functionality has been documented in CHANGELOG.MD

          1 Error

:no_entry_sign:
Please add labels to this Pull Request

  Generated by :no_entry_sign: Danger


added navigateUrl API

Describe your changes
Added new api for navigate screen using url - navigateUrl
Screenshots [Optional]
Issue ticket number and link
Closes #
closes #314
Checklist before requesting a review

[x] I have performed a self-review of my code
[ ] I have added tests
[x] I have added a changeset pnpm changeset add
[x] I have added example usage in the kitchen sink app

If the path start with / then it will considered as start of path which will resolved with the domain name, and if path is not start with / then it will considered as a relative path and resolved with the current directory.
this is already added in this PR.

Yes i agree @sagardspeed2 but the issue arises when we are changing role-based paths like from advocate/home even if we use /manager/dashboard it only concatenates the URL afterwards like this /advocate/manager/dasboard, which is not desired output.

I suggest using window.href.location to change URL when we are changing roles specially, because otherwise using useLocation hook its not possible to be done as per my knowledge.
@evshi @sagardspeed2


ElectionMap on mobile not displayed on tab change

When user change from "สรุปข้อมูล" to "แผนที่" on mobile, map is not rendered.

I fixed it already krubb :D

Closed in 4505612f4d5d0a614d68eed2f3f2913115337330


iPad Keyboard Issue

Hello, my first time here so please forgive me if I have missed anything as far as an answer to this question/bug?
I have noticed that when using the live-data-search feature on the iPad, the keyboard will close automatically after the user enters a letter. They have to touch the input field again to enter the next letter and so on until they touch a value.
Is this normal behavior or is there a way to keep the keyboard visible while the user is typing in the search field?
This is reproducible on your demo page.

is there something new about this topic? is there already provided a fix?

Still no fix?

This appears to be fixed in iOS 12 (possibly earlier).


OpenCvSharp.NativeMethods.redirectError(CvErrorCallback errCallback, IntPtr userdata, IntPtr& prevUserdata)

windows

Please provide details of the occurred exception, your environment, code samples, etc.


Error found in evm.log file after adding a new containers provider

Description:
After adding a new Containers provider (Kubernette / Openshift), error is found in the evm.log file.
Version:
master.20150902074447_178618c

evm.log:
[----] E, [2015-09-02T07:52:12.900430 #21913:114aff4] ERROR -- : MIQ(ManageIQ::Providers::Kubernetes::ContainerManager::EventCatcher::Runner#start_event_monitor) EMS [<IP_ADDRESS>] as [_] Event Monitor Thread aborted because [undefined method split' for :authorization:Symbol] [----] E, [2015-09-02T07:52:12.900688 #21913:114aff4] ERROR -- : [NoMethodError]: undefined method split' for :authorization:Symbol  Method:[rescue in block in start_event_monitor]
[----] E, [2015-09-02T07:52:12.900804 #21913:114aff4] ERROR -- : /opt/rubies/ruby-2.2.3/lib/ruby/2.2.0/net/http/header.rb:172:in capitalize' /opt/rubies/ruby-2.2.3/lib/ruby/2.2.0/net/http/header.rb:165:in block in each_capitalized'
/opt/rubies/ruby-2.2.3/lib/ruby/2.2.0/net/http/header.rb:164:in each' /opt/rubies/ruby-2.2.3/lib/ruby/2.2.0/net/http/header.rb:164:in each_capitalized'
/opt/rubies/ruby-2.2.3/lib/ruby/2.2.0/net/http/generic_request.rb:324:in write_header' /opt/rubies/ruby-2.2.3/lib/ruby/2.2.0/net/http/generic_request.rb:126:in exec'
/opt/rubies/ruby-2.2.3/lib/ruby/2.2.0/net/http.rb:1412:in block in transport_request' /opt/rubies/ruby-2.2.3/lib/ruby/2.2.0/net/http.rb:1411:in catch'
/opt/rubies/ruby-2.2.3/lib/ruby/2.2.0/net/http.rb:1411:in transport_request' /opt/rubies/ruby-2.2.3/lib/ruby/2.2.0/net/http.rb:1384:in request'
/opt/rubies/ruby-2.2.3/lib/ruby/gems/2.2.0/gems/kubeclient-0.1.17/lib/kubeclient/watch_stream.rb:20:in each' /var/www/miq/vmdb/gems/pending/kubernetes/events/kubernetes_event_monitor.rb:33:in each'
/var/www/miq/vmdb/app/models/manageiq/providers/kubernetes/container_manager/event_catcher_mixin.rb:28:in monitor_events' /var/www/miq/vmdb/app/models/manageiq/providers/base_manager/event_catcher/runner.rb:113:in block in start_event_monitor'
[----] I, [2015-09-02T07:52:12.932489 #2874:e1f988]  INFO -- :  Following Relationship [miqaedb:/System/Event/ems_auth_valid#create]

@rananda is this still reproducible? I didn't encounter this error.
cc @simon3z

Seems to be working fine in the latest build - master.20151027090214_bf6eb93.
This ticket can be closed.

@rananda, please close it, I see I don't have permissions to close it.

@chessbyte @blomquisg @rananda can you close this? Thanks.


CLI not switching to API logs when needed

Description:

Whenever I run the product in dev mode, I am not able to switch logs between web server and api server.
Steps to reproduce:

./dev.sh
switch between server logs. and switch to api-server logs. [w]

Expected behaviour:

It should switch logs to API server.

Actual behavior:

Cant switch between logs.

Server Setup Information:

Operating System: Mac OS 14
Deployment Method:

Additional context

The bug is there due to the way <Static> element prints the logsStreamNodes to the CLI.
Let's say the current log source is "web" and logsStream has 10 logs.
Now if we press key to switch to log source "API" which let's say has 18 logs.
Then <Static> element will only show ( 18 - 10 = 8 logs ).
Now if we again switch to log source "web" which has 10 logs, the element will not show any logs.
That means <Static> element only extra logs that are added to logStream, which is expected.
One way to solve the problem is to dispatch logStream = [ ] on any input.

However, If same log source is selected again, it will compute the conversion of logStream logs to nodes again (which we can handle by logic or just ignore). Also fortunately the same log source logs will not be printed again on CLI.
We can discuss more if this approach seems fine. I will be happy to create a PR for this.

Then the <Static> element will only show (18 - 10 = 8 logs).
@Kamlesh72, thanks for this^
Maybe now we know why the <Static> element was giving us issues.
One of the behaviors that we expect from our CLI logs is that when we switch between sources, it should also print the last 50 logs from that source. If I am guessing it right, your approach will totally clear it out.
But even if it does so, please raise a PR with your existing approach, as it will fix the switching of log source issue.

@shivam-bit On any input, we are dispatching payload 2 times. 1st with [ ] and 2nd with respective logs array. Hence CLI will work as it it.
https://github.com/middlewarehq/middleware/assets/90441742/dadb2fcb-715b-4c59-a14e-6a8336d47cce


Error trying to install Toolkit: "System.InvalidOperationException: VSHiveStub.exe failed"

Computer (please complete the following information):

Windows Version:  10 Enterprise
Visual Studio Version: 2019  Enterprise
AWS Toolkit for Visual Studio Version:

Install log
4/21/2022 4:50:26 PM - 		Microsoft.VisualStudio.Community
4/21/2022 4:50:26 PM - 			Version : [16.0,17.0)
4/21/2022 4:50:26 PM - 			ProductArchitecture : x86
4/21/2022 4:50:26 PM -
4/21/2022 4:50:26 PM - 	References         :
4/21/2022 4:50:26 PM - 	Prerequisites      :
4/21/2022 4:50:26 PM - 		-------------------------------------------------------
4/21/2022 4:50:26 PM - 		Identifier   : Microsoft.VisualStudio.Component.CoreEditor
4/21/2022 4:50:26 PM - 		Name         : Visual Studio core editor
4/21/2022 4:50:26 PM - 		Version      : [16.0,17.0)
4/21/2022 4:50:26 PM -
4/21/2022 4:50:26 PM - Signature Details...
4/21/2022 4:50:26 PM - 	Extension is signed with a valid signature.
4/21/2022 4:50:26 PM -
4/21/2022 4:50:26 PM - System.InvalidOperationException: VSHiveStub.exe failed: Unknown error
at VSIXInstaller.LocationBasedSKU.SettingsManagerData.get_RegRootHiveOverride()
at VSIXInstaller.LocationBasedSKU.get_RegRootHiveOverride()
at VSIXInstaller.SupportedVSSKU.InitializeSettingsManager()
at VSIXInstaller.SupportedVSSKU.get_Host()
at VSIXInstaller.SupportedVSSKU.CreateExtensionEngine()
at System.Lazy`1.CreateValue()
at System.Lazy`1.LazyInitValue()
at System.Lazy`1.get_Value()
at VSIXInstaller.ExtensionService.GetExtensionEngineForApplicableSKU(ICommandLineData cmdLineData, SupportedVSSKU supportedSKU, IInstallableExtension installableExtension, List`1 applicableSKUs, Boolean isRepairSupported)
at VSIXInstaller.ExtensionService.GetInstallableDataImpl(IInstallableExtension extension, String extensionPackParentName, Boolean isRepairSupported, IStateData stateData, IEnumerable`1& skuData)
at VSIXInstaller.ExtensionService.GetInstallableData(String vsixPath, String extensionPackParentName, Boolean isRepairSupported, IStateData stateData, IEnumerable`1& skuData)
at VSIXInstaller.ExtensionService.ComputeInstallableExtensions(IStateData stateData, Boolean isRepairSupported, Boolean isExtensionPack, IDictionary`2 skuDataMapping, IList`1 installableExtensionsPaths)
at VSIXInstaller.App.Initialize(Boolean isRepairSupported)
at VSIXInstaller.App.Initialize()
at System.Threading.Tasks.Task`1.InnerInvoke()
at System.Threading.Tasks.Task.Execute()
--- End of stack trace from previous location where exception was thrown ---
at Microsoft.VisualStudio.Telemetry.WindowsErrorReporting.WatsonReport.GetClrWatsonExceptionInfo(Exception exceptionObject)
Any other information
I am on company VPN while installing toolkit but I tried without VPN as well. Also the same issue coming for VS 2022 toolkit installation.

Hi @joshiamit24 thank you for reaching out. Are you having similar issues installing other Visual Studio extensions?
Your installation of Visual Studio might be in a bad state. Have you tried launching the "Visual Studio Installer" from the start menu, and running Repair against your installation?

Ok let me try this.

same issue again.

Out of curiosity, does the same thing happen when you install other Visual Studio extensions?
Extensions are installed through the Visual Studio VSIX installer, you might need to reach out to the Visual Studio team for assistance - see https://developercommunity.visualstudio.com/report for details.

It seems this issue is appearing on office laptop. I tried on personal laptop and I can install AWS toolkit without any issues.
Not sure what is the issue with office laptop.

The Toolkit does require (Windows) Administrator permissions in order to install it. I am not sure if the error you are seeing would be the result of not having those permissions though.

I am admin on office laptop. As per log it fails on VSHiveStub.exe failed: Unknown error

I am facing same issue. Did anybody get a solution?


Local Auth - Admin user did have get access to the "Default" environment until another user was added as member to this environment.

Server version - Build from sep 4
Steps to reproduce the problem:
Enable local auth.
Add an admin user.
When you get authenticated as this admin user , there is no access to the "Default" environment.

After I create another user and add it as member to the project , both admin user and regular user get access to the "Default" environment.

Addressed with rancher/cattle#847

Tested with build from master - Sep 8
Admin user gets access to default environment after local Auth is enabled and admin user is created.


Searchable merge columns

I have this code below but it can only search for last_name.
I want to search for first_name, middle_name, and name_extension also, how can I do that?
Thanks!
{
         `// column definitions`
         `mData: 'last_name',`
         `"aTargets": [ 1 ],`
         `mRender:function ( data, type, row ) {`
             `// concatenate name`
             `return row.last_name+' '+row.name_extension+', '+row.first_name+' '+row.middle_name;`
         `},`
         `searchable: true,`
         `sortable: true,`
         `visible: true,`
},

Try this trick, add a hidden column first_name on your columns and it will be included in search.
columns: [
{data: first_name, visible: false},
{data: last_name},
]

Thanks for your reply but still can't search for first_name.

It's working! I changed my aoColumnDefs: [] to columns: [] and mData to data and follow the that trick. Thanks!


Application creation doesn't fall-back if there is a failure in the CORS configurations in the API request

Describe the issue:
When an application is created via REST API with incorrect input for the CORS config, an error
How to reproduce:
API request:
{"name":"testTrad","advancedConfigurations":{"discoverableByEndUsers":false},"authenticationSequence":{"type":"DEFAULT","steps":[{"id":1,"options":[{"idp":"LOCAL","authenticator":"basic"}]}]},"inboundProtocolConfiguration":{"oidc":{"grantTypes":["authorization_code"],"publicClient":false,"callbackURLs":["https://mydomain.com"],"allowedOrigins":["https:://mydomain.com"]}},"templateId":"b9c5e11e-fc78-484b-9bec-015d247561b8"}

Refer :: in allowedOrigins":["https:://mydomain.com"]}}
API returns 400, but the application is created.
Expected behavior:
The application should not be created.

Analysis:

CORS origins of an application are added in a separate transaction outside of the application creation.
When the CORS origin addition fails, we are not currently rolling back the created application or its metadata.
This leads to an error when we correct the payload and retry, as the application data (application name) still remains from the previous failure.

Short term solution

Implement the rollback at the REST API layer

Idea/Long term Solution

Do the CORS addition in the same transaction as the application creation so the rollback will automatically be handled.

Analysis:

CORS origins of an application are added in a separate transaction outside of the application creation.
When the CORS origin addition fails, we are not currently rolling back the created application or its metadata.
This leads to an error when we correct the payload and retry, as the application data (application name) still remains from the previous failure.

Short term solution

Implement the rollback at the REST API layer

Idea/Long term Solution

Do the CORS addition in the same transaction as the application creation so the rollback will automatically be handled.

The short-term solution is done.
The long-term solution is tracked by wso2/product-is#11131

The short-term solution is done.
The long-term solution is tracked by wso2/product-is#11131

We can close this with the above comment.


 Maybe you already do?

Yes, this is unrelated to Franklin but is related to LiveServer and more specifically to HTTP.jl.
One thing that seems to cause this is when you open multiple tabs pointing to localhost and refresh some of them, or close some of them. We're not quite sure.
xref: https://discourse.julialang.org/t/http-jl-ioerror-stream-is-closed-or-unusable/31320
This is a known issue, LiveServer could try to hide it but it's not exactly clear what produces it so it makes testing hard...
Anyway, long story short is you can safely ignore this issue.

Yes, this is unrelated to Franklin but is related to LiveServer and more specifically to HTTP.jl.
One thing that seems to cause this is when you open multiple tabs pointing to localhost and refresh some of them, or close some of them. We're not quite sure.
xref: https://discourse.julialang.org/t/http-jl-ioerror-stream-is-closed-or-unusable/31320
This is a known issue, LiveServer could try to hide it but it's not exactly clear what produces it so it makes testing hard...
Anyway, long story short is you can safely ignore this issue.

Fixed (hidden) by https://github.com/JuliaWeb/HTTP.jl/pull/546 ?

Fixed (hidden) by https://github.com/JuliaWeb/HTTP.jl/pull/546 ?

^ I still see it from time to time and I have HTTP 0.9.2 (the PR you mention was merged in 0.9.1), also fonsp kindly made a PR to LiveServer with that change (https://github.com/tlienart/LiveServer.jl/commit/21cef699c387f07d81f5b96acbe1e379c68354a1) but to the best of my knowledge it doesn't eliminate the problem (though it likely helps)
@cscherrer could you report which version of HTTP you're on?

^ I still see it from time to time and I have HTTP 0.9.2 (the PR you mention was merged in 0.9.1), also fonsp kindly made a PR to LiveServer with that change (https://github.com/tlienart/LiveServer.jl/commit/21cef699c387f07d81f5b96acbe1e379c68354a1) but to the best of my knowledge it doesn't eliminate the problem (though it likely helps)
@cscherrer could you report which version of HTTP you're on?

HTTP v0.8.19

HTTP v0.8.19

Ah well so then the situation is definitely worse. Maybe you have another package that blocks you from updating HTTP to 0.9+? The situation should be better with that version

Ah well so then the situation is definitely worse. Maybe you have another package that blocks you from updating HTTP to 0.9+? The situation should be better with that version


Script Resource is empty upon creation and eventually goes empty on saving

Godot version
4.1 stable
System information
Godot v4.1.stable - Windows 10.0.22621 - Vulkan (Mobile) - dedicated AMD Radeon RX 6700 XT (Advanced Micro Devices, Inc.; 31.0.14037.17019) - AMD Ryzen 7 2700 Eight-Core Processor (16 Threads)
Issue description
When creating a resource add adding a script via: Script -> New GDScript an empty script is created.
Steps to reproduce

Create resource
Select New GDScript from the RefCounted

An empty resource is created

Along with a script that says [unsaved](*)

Double click on the new resource in the FileSystem and the resource shows up

After doing edits and saving the file multiple times the script resource eventually goes empty again and the script is not saveable because it says [unsaved](*)

Minimal reproduction project
An empty project works.

I have also noticed that when saving the built-in script, the script doesn't get saved to the tres file.
So, assuming you have:
class Unit extends Node3D:
    pass

The tres file the looks like this:
[sub_resource type="GDScript" id="GDScript_mgm1v"]
script/source = "class Unit extends Node3D:
    pass
"

Once you edit the file sometimes it does update, so if you change the script to
class Unit extends Node3D:
    var test = 123

The tres file still looks like this when you save it:
[sub_resource type="GDScript" id="GDScript_mgm1v"]
script/source = "class Unit extends Node3D:
    pass
"


clean up "Firefox Data Collection & Use"

telemetry prefs together in 330's
Firefox Data Collection & Use prefs to 340's (but leave crash reports in 350s)
move app.shield.optoutstudies.enabled to 330's - this is an internal pref which controls if you get the system addon
make notes that datareporting.healthreport.uploadEnabled controls studies and ext recommendations

So I'd actually like to split the other three off into a new 351, or we could add a comment at the end of the pref?

either 1 is fine with me but I prefer the former. The rest LGTM


Drop docs/ and examples/ directories

Everything is in https://github.com/rancher/elemental-docs/ now
Signed-off-by: Klaus Kämpf<EMAIL_ADDRESS>

See also rancher/elemental-docs#28

I was doing the same for configuration files, could you also remove these files please? (I just synced with Nuno about that):
.github/workflows/docs.yaml
Vars.js
babel.config.js
docusaurus.config.js
sidebars.js
yarn.lock
src
static

Done.

I will take care about removing the unused dependencies in the package.json in a separate PR.

Thanks !

I will take care about removing the unused dependencies in the package.json in a separate PR.

Done in PR #591.


Building DB

Hi,
I would like to find out if there was a way to continue download the databases without starting from scratch every time. Also I can't seem to finish downloading the Trembl database (stops during the download) and I can't get aspera to work though it says the installation is complete.
#########################
Installing IBM Aspera Connect
Deploying IBM Aspera Connect (/home/eddy_k/.aspera/connect) for the current user only.
Unable to register protocol handler, IBM Aspera Connect won't be able to auto-launch
Unable to update desktop database, IBM Aspera Connect may not be able to auto-launch
Install complete.

Hi @eddykay310
Although we have implemented steps to download individual databases only (refseq, swissprot or trembl), we do not have an option to resume a stopped download. When you refer to a stop during download does it give any particular error message?
For aspera, could you give some details on your OS and if you can run aspera by itself from the command line? Thanks!

Hi @cruizperez
Thanks for the response. So when I say continue, I mean that in my case I am able to download kofam and swissprot but when I get to trembl it takes a while and sometimes stops during the download with no error (just stuck). So I wanted to find out if there was a way to continue downloading other databases rather than starting afresh. The only thing asked by the program is in the overwriting of existing files.. For aspera, I am using the WSL in windows. I thought it didn't install properly but the prefetch command in the sra toolkit was able to use it to download sequence files.
Thanks