Marking issues as: "good-first-issue", "help-wanted", and "beginner-friendly"

This issue will track and link issues in phetsims common code repos that we believe are good candidates for open source contributions.

In Scenery:
"good-first-issue":

https://github.com/phetsims/scenery/issues/1363
https://github.com/phetsims/scenery/issues/1262

"beginner-friendly":

https://github.com/phetsims/scenery/issues/1231
https://github.com/phetsims/scenery/issues/1208
https://github.com/phetsims/scenery/issues/1203
https://github.com/phetsims/scenery/issues/1581
https://github.com/phetsims/scenery/issues/64

"help-wanted":

https://github.com/phetsims/scenery/issues/904

Joist
"good-first-issue":

https://github.com/phetsims/joist/issues/807
https://github.com/phetsims/joist/issues/273 (this needs some more breakdown and specificity though)

"help-wanted":

https://github.com/phetsims/joist/issues/732
https://github.com/phetsims/joist/issues/557
https://github.com/phetsims/joist/issues/537
https://github.com/phetsims/joist/issues/931 (this seems like it would be straightforward to implement but needs a designer...)

Sun
"help-wanted":

https://github.com/phetsims/sun/issues/777

"good-first-issue":

https://github.com/phetsims/sun/issues/749
https://github.com/phetsims/sun/issues/659
https://github.com/phetsims/sun/issues/653
https://github.com/phetsims/sun/issues/555 (this chipaway needs to be triaged and also clarify what would be expected form a contributor)
https://github.com/phetsims/sun/issues/523 (this is another contender that needs more clarity, and also removing the instructions related to PhET-iO)
https://github.com/phetsims/sun/issues/522
https://github.com/phetsims/sun/issues/351
https://github.com/phetsims/sun/issues/200

Joist
"good-first-issue":

https://github.com/phetsims/axon/issues/334

"help-wanted":

https://github.com/phetsims/axon/issues/410
https://github.com/phetsims/axon/issues/41

Kite
"beginner-friendly":

https://github.com/phetsims/kite/issues/76
https://github.com/phetsims/kite/issues/56 (It would be easy to simplify the instructions here for a beginner to feel comfortable, but as is right now doesn't feel beginner-friendly).

Tambo
"good-first-issue":

https://github.com/phetsims/tambo/issues/87

Dot
"beginner-friendly":

https://github.com/phetsims/dot/issues/96

"good-first-issue":

https://github.com/phetsims/dot/issues/49
https://github.com/phetsims/dot/issues/38

"help-wanted":

https://github.com/phetsims/dot/issues/4 (I would want to check in with devs on this before opening it up... it has the potential to be an open source chipaway, but I feel like we just haven't made a decision on what we want. It's also incredibly old)

This is my first pass at identifying some issues. I tried to stay away from things that really involved or interacted directly with phet-io. Many will need a clear summary or explanation of next steps for someone to feel confident going into it.
My next steps will be to triage these again and add labels.
@brettfiedler are there any other common-code repos you would like me to hit that are missing here?

Issues that need outside input before they are ready for the public:

https://github.com/phetsims/scenery/issues/64
https://github.com/phetsims/joist/issues/931
https://github.com/phetsims/dot/issues/4

Over to @brettfiedler for next steps.

I love these new labels. Thanks for doing this. I found this issue while adding labels to a new repo, and had a couple thoughts here.

I was noticing that they don't adhere to our github label conventions, in which they get a prefixed "class" with a colon. Perhaps all of these could be added to type:XX? Or maybe community: or pose: if we want something new and specific to POSE. Not sure what is best, but organization sounds preferable given the complexity and size of our label system.
I also wanted to note that we already have dev:help-wanted, perhaps we should get rid of that label, and make all of those labels have this label? Not sure what's best.
It doesn't look like this was added to all repos consistently, For example phetcommon doesn't have these labels, but it is in the github label system in phet-info, so when I added "all labels to new repo" over in https://github.com/phetsims/soccer-common/issues/5, it did pick up these labels. I think that keeping consistent labels in every single repo (unless we need a label for one specific repo, like we have in chipper) is best.

@zepumph The reason they are not prefixed with a colon is because we want these labels to be picked up by github as "goog-first-issue", "help-wanted", etc. that they market to github users. Generally github has a list of issues from different open source projects that have these labels for those that may want to contribute to those projects. Adding a prefix would break this for us and our issues would no longer be bundled in there which would be very un-POSE like of us.

I also wanted to note that we already have dev:help-wanted, perhaps we should get rid of that label, and make all of those labels have this label? Not sure what's best.

That label has been used (i know by me and SR) to communicate when we might need help from another PhET dev on an issue. We used this alot for CAV. I did not eliminate it because those types of issues should not get mixed into the POSE "help-wanted" issues.

I think that keeping consistent labels in every single repo is best.

I'm fine with this. @brettfiedler would you like me to add these to every single repo?


Model updates with forceSelection enabled

Model currently gets updated as the user is entering data into the input. This shouldn't be the case if forceSelection is enabled. The model should remain the same until the user actually selects one of the items from the dropdown.
Similarly, a user hitting "esc" should leave the model value alone (back to whatever it was before they started changing it.
I'll work on a PR that makes this happen.

This is being addressed by PR #18.

Thanks for the fix man!


[🐛 BUG] Scope issue with lambda function

What went wrong? 🤔
There are issues using the lambda functions with multiple pages.
C:\Users\jacta\.conda\envs\test\Lib\site-packages\taipy\gui\utils\_evaluator.py:369: TaipyGuiWarning: Exception raised evaluating __lambda_2466438897376_1_TPMDL_0(x):

name 'create_chart' is not defined
  _warn(f"Exception raised evaluating {expr_string}", e)

(Note that this issue was first seen when trying to have multiple states for an application; this might not be the same issue)
Expected Behavior
This should work fine like the comments in the code example.
Steps to Reproduce Issue
app.py
from taipy import Gui
from page_py import page # if you add 'create_chart' in the import, then this works!

pages = {"/": "App", "page": page}

Gui(pages=pages).run()

page_py.py
import taipy.gui.builder as tgb
import pandas as pd
import plotly.express as px

x = 0

def create_chart(x):
    print("Hello")
    df = pd.DataFrame(
        {
            "Fruit": ["Apples", "Oranges", "Bananas", "Apples", "Oranges", "Bananas"],
            "Amount": [4, 1, 2, 2, 4, 5],
            "City": ["SF", "SF", "SF", "Montreal", "Montreal", "Montreal"],
        }
    )
    fig = px.bar(df, x="Fruit", y="Amount", color="City", barmode="group")
    fig.show()
    return fig

with tgb.Page() as page:
    tgb.text("Hello World")
    tgb.slider("{x}")
    tgb.chart(figure=lambda x: create_chart(x))

    # If you use the Markdown syntax, there are no issues. This works
    # tgb.chart(figure="{create_chart(x)}")

Browsers
Chrome
OS
Windows
Version of Taipy
4.0.1
Acceptance Criteria

[ ] A unit test reproducing the bug is added.
[ ] Any new code is covered by a unit tested.
[ ] Check code coverage is at least 90%.
[ ] The bug reporter validated the fix.
[ ] Related issue(s) in taipy-doc are created for documentation and Release Notes are updated.

Code of Conduct

[X] I have checked the existing issues.
[ ] I am willing to work on this issue (optional)

Should this be backported?

Is that the criteria to be backported?
It was working in 4.0.dev1 for example; I don't know if this is called a regression. Zacch had the same issue when writing its application

Fixed in 4.0.2


Updated C28719

Updated to the new format

Docs Build status updates of commit d6a343c:
:warning: Validation status: warnings

File
Status
Preview URL
Details

windows-driver-docs-pr/devtest/28719-banned-api-usage-use-updated-function-replacement.md
:warning:Warning

Details

windows-driver-docs-pr/devtest/28719-banned-api-usage-use-updated-function-replacement.md

Line 1, Column 1: [Warning: ms-date-missing - See documentation] Missing required attribute: 'ms.date'. A freshness date is required for this content set. Add a date in format MM/DD/YYYY.
Line 1, Column 1: [Warning: title-missing - See documentation] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 6, Column 13: [Warning: yaml-header-syntax-error] While parsing a block collection, did not find expected '-' indicator.
Line 1, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit ae8e159:
:warning: Validation status: warnings

File
Status
Preview URL
Details

windows-driver-docs-pr/devtest/28719-banned-api-usage-use-updated-function-replacement.md
:warning:Warning

Details

windows-driver-docs-pr/devtest/28719-banned-api-usage-use-updated-function-replacement.md

Line 1, Column 1: [Warning: ms-date-missing - See documentation] Missing required attribute: 'ms.date'. A freshness date is required for this content set. Add a date in format MM/DD/YYYY.
Line 1, Column 1: [Warning: title-missing - See documentation] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 6, Column 13: [Warning: yaml-header-syntax-error] While parsing a block collection, did not find expected '-' indicator.
Line 1, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 7f0acea:
:warning: Validation status: warnings

File
Status
Preview URL
Details

windows-driver-docs-pr/devtest/28719-banned-api-usage-use-updated-function-replacement.md
:warning:Warning

Details

windows-driver-docs-pr/devtest/28719-banned-api-usage-use-updated-function-replacement.md

Line 1, Column 1: [Warning: ms-date-missing - See documentation] Missing required attribute: 'ms.date'. A freshness date is required for this content set. Add a date in format MM/DD/YYYY.
Line 1, Column 1: [Warning: title-missing - See documentation] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 6, Column 13: [Warning: yaml-header-syntax-error] While parsing a block collection, did not find expected '-' indicator.
Line 1, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 4d8a6c0:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

windows-driver-docs-pr/devtest/28719-banned-api-usage-use-updated-function-replacement.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit e8a7c20:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

windows-driver-docs-pr/devtest/28719-banned-api-usage-use-updated-function-replacement.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@MugBergerFries - Let me know when this PR is ready to merge.

@corob-msft Hi Colin, can you check over this one?

Learn Build status updates of commit d0f2721:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

windows-driver-docs-pr/devtest/28719-banned-api-usage-use-updated-function-replacement.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


User info is fetched even when not logged in

On the info pages, user/role information is fetched on every load. This shouldn't happen unless there is a user logged in.

Problem has been fixed in develop -- added check to make sure user is authenticated before attempting to fetch user/role information.


WIP: Add coverage steps to rust workflow; remove travis

Closes #46

Try switching to https://github.com/marketplace/actions/coveralls-github-action

Replaced by #54


Change in bridge EndpointOperInfo()

For the docker1.7.0_integ branch

Signed-off-by: Alessandro Boch<EMAIL_ADDRESS>

LGTM


Cannot control the buffer tank

We can easily control the boiler which works great but we cannot control the buffer tank. Would there be any plans to add this ?

Are you able to do it through the multimatic app ?

No you can't so probably it wont be possible then
You can however on the multimatic itself (not the app) choose to have an offset, ie that in case of excess solar it increases the temperature higher in the buffer than it normally would as a way to store energy / heat

Yes, there are plenty of configuration you can't touch in the multimatic app.


Update sbt-mdoc to 2.3.0 in series/0.22

Updates org.scalameta:sbt-mdoc from 2.2.24 to 2.3.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Files still referring to the old version number
The following files still refer to the old version number (2.2.24).
You might want to review and update them manually.
website/src/hugo/content/changelog.md

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "sbt-mdoc" } ]

labels: sbt-plugin-update, early-semver-minor, semver-spec-minor, old-version-remains, commit-count:1

Actually, we now get this from sbt-typelevel-site via sbt-http4s-org.


Corporate managed cloud services UX workshop #7

Describe the issue
We have ideas from the 2019 Service Design workshops re what sort of user experience ministry teams will require when they access cloud services - we need to test assumptions and gather more information to inform our design of the service.
Which Sprint Priority is this issue related to?
Alpha version of our Managed Cloud Services Blueprint
Additional context
Initial email invitations have been sent out - need to follow up with each recipient to schedule and conduct the workshops: Justice (this one), next will be Health.
Definition of done
UEx workshop #7 conducted, and findings so far compiled on ConceptBoard.

Workshop conducted 2020-08-06 - good discussion. Strong support for self-service and investment in Communities of Practice.


Implement basic checkpointing

For actor and task restart (by supervisors) checkpoint and restore is an important option. Thus actor state can be restored at restart.
Therefore implement basic functionality for user-defined checkpointing:

[ ] checkpointing actor,
[ ] checkpoint call,
[ ] restore call

There are multiple ways to realize checkpointing with Actors:

explicit, user-defined checkpointing based on the functionality mentioned above,
use checkpoints in init! and term! callback functions,
saving intermediate results to a guarded variable, and the :guard actor does the checkpointing,
checkpoints could be served by a :genserver actor,
function memoization saved to a guarded/checkpointed Dict,
...

This leads to the impression that only the basic checkpointing functionality (1, 2) should go into Actors while the more sophisticated stuff should be realized in a framework library: Checkpoints.jl
Maybe people working in HPC like @oschulz could comment on this.

Init/terminate and restart strategy
Checkpointing can be integrated within init, term and restart callbacks:

A user can provide a termination callback taking a checkpoint of an actor's acquaintance variables upon abnormal actor exit.
A user can provide an init and/or restart callback to look for a checkpoint and to eventually restore it before actor start.
Then a monitor can be specified to call an init or restart action on actor termination.
Supervisors should do the following for actor restart:

if specified, call a restart function (must return a link to a started actor),
else if specified, call an init function (must return a link to a started actor),
else spawn an actor with the last behavior.

Enable Multilevel-Checkpointing

In-memory checkpointing has been demonstrated to be fast and scalable. In addition, multilevel checkpointing technologies ... are increasingly popular. Multilevel checkpointing involves combining several storage technologies (multiple levels) to store the checkpoint, each level offering specific overhead and reliability trade-offs. The checkpoint is first stored in the highest performance storage technology, which generally is the local memory or a local SSD. This level supports process failure but not node failure. The second level stores the checkpoint in remote memory of remote SSD. This second level supports a single-node failure. The third level corresponds to the encoding the checkpoints in blocks and in distributing the blocks in multiple nodes. This approach supports multinode failures. Generally, the last level of checkpointing is still the parallel file system. This last level supports catastrophic failures such as full system outage. (see: D6.1 Preliminary Report on State of the Art Software-Based Fault Tolerance Techniques)

The checkpointing actor should support multilevel as a combination of user-level and application-level checkpointing. The concept is as follows:

the user-actor takes application-specific checkpoints to a checkpointing actor running on the same node (under the same supervisor). This usually is an in-memory checkpoint.
Then a 2nd level checkpoint is taken at regular intervals by an aggregating checkpointing actor residing on another node. The aggregation is done from 1st-level or other 2nd-level actors.
The third level is the organization of the checkpointing and restart/restore hierarchy.

The first two levels should be realized in Actors. The third level can then be realized in a separate framework library Checkpointing.jl.

Multilevel Checkpointing Mechanism

1st level checkpoints must be inexpensive (in-memory). Thus they can be taken frequently. ¹
2nd level checkpoints can consist of arbitrary hierarchy levels.

They are usually triggered and/or saved at regular intervals (can be parametrized for each actor).
When they are triggered, they collect the current checkpoints from all inferior checkpointing actors.
2nd level checkpoints and save routines can also be triggered from inferior actors. In that case  such requests are propagated upwards in the checkpointing hierarchy until the required level is reached.
Therefore the checkpoint function must have a level argument.

The restore function also must have a level argument. The restoring then is done from the chosen level.

—————-
¹ 1st level checkpoints are triggered by a user actor. Automatic checkpointing at the 1st level must wait until Julia Atomics is ready.

Checkpointing Intervals
Update and Save intervals must be configurable and it must also be possible to turn automatic checkpointing on and off.

Detect and Handle Node Failures
Supervisors looking after actors on other workers must detect node failures and handle them appropriately.

They start a task that

polls a fetch on the RemoteChannel of the supervised actor and
forwards a ProcessExitedException to the supervisor.

They treat those exception differently since they don't contain an actor state.

Tasks on other nodes must have a supervisor actor on their node. That one can be supervised by a remote supervisor as described above.

This is not a good strategy to work with! The consequence of that requirement would be to have two supervisor levels where we need only one. Therefore:
Introduce an actor for node supervision
If a supervisor gets a child on another node, it starts another helper child, responsible for scanning regularly the connections to foreign actors.
If a connection gives ProcessExitedException or ProcessFailedException, the helper informs the supervisor about the failed PID and it thus can act accordingly restart the foreign actors on another node.


Encryption at Rest

Our database and especially anywhere we are storing user information needs to be encrypted at rest.  This will need to be tested on Staging as it broke a lot of things for Blue Box.
┆Issue is synchronized with this Jira Story
┆Sprint: Seabright Sprint 5 Electric
┆Issue Number: SEAB-42
┆Epic: Dockstore Compliance

➤ Denis Yuen commented:
FYI, closing and deleting on GitHub. This one makes less sense there


DbModel with openapiSchema

Added a new attribute openapiSchema to the DbModel. This allows passing arbitrary x-* metadata to the DbModel.
The x-scenarios attribute includes name and description. It generates constants for scenarios. The advantage is that when using this schema.yaml for the frontend with a ClientGenerator, the scenarios will be identical in both models, frontend and backend.

The DbModel has received a new attribute called scenarioDefaultDescription.
Example:
project.yaml
x-scenarios:
  - name: create
    description: Scenario create this project
  - name: update

project.php
 /**
  * Scenario create this project
  */
 public const SCENARIO_CREATE = 'create';

 /**
  * Scenario update
  */
 public const SCENARIO_UPDATE = 'update';

...
 /**
  * Automatically generated scenarios from the model 'x-scenarios'.
  * @return array a list of scenarios and the corresponding active attributes.
  */
 public function scenarios()
 {
     /**
      * Each scenario is assigned attributes as in the 'default' scenario.
      * The advantage is that the scenario can be used immediately.
      * This can be overridden in the child model if needed.
      */
     $default = parent::scenarios()[self::SCENARIO_DEFAULT];

     return [
         self::SCENARIO_CREATE => $default,
         self::SCENARIO_UPDATE => $default,
         /**
          * The 'default' scenario and all scenarios mentioned in the rules() using 'on' and 'except'
          * are automatically included in the scenarios() function for the model.
          */
         ...parent::scenarios(),
     ];
 }

For the x-scenarios, you can use your own scenarioDefaultDescription
AcceptedInputs: {scenarioName}, {scenarioConst}, {modelName}

config.php
 [
     'class' => \cebe\yii2openapi\generator\ApiGenerator::class,
     'dbModel' => [
         /** AcceptedInputs: {scenarioName}, {scenarioConst}, {modelName}. @see DbModel::$scenarioDefaultDescription */
         'scenarioDefaultDescription' => implode("\n", [
             "This scenario name: \"{scenarioName}\"",
             "This scenario const: \"{scenarioConst}\"",
             "This model name: \"{modelName}\"",
         ]),
     ],

project.php
 /**
  * Scenario create this project
  */
 public const SCENARIO_CREATE = 'create';

 /**
  * This scenario name: "update"
  * This scenario const: "SCENARIO_UPDATE"
  * This model name: "Project"
  */
 public const SCENARIO_UPDATE = 'update';

A warning is now displayed at the top of the Model class: This file is generated by Gii, do not change manually!

The Model class description now has a fallback if no description is provided. Fallback: This is the model class for table <tableName>.

The "bug with spaces" in the Model class description has been fixed, so that code style no longer complains. The description is now formatted using cebe\yii2openapi\lib\helpers\FormatHelper::getFormattedDescription.

cebe\yii2openapi\lib\items\Attribute::getFormattedDescription has been renamed to cebe\yii2openapi\lib\items\Attribute::getPropertyAnnotation.
There are two reasons for this:

The property annotation consists of: phpType + columnName + description (from the description field in model.yaml). It is not ideal to label this as "description" since it can cause confusion.
In a PHPDoc comment, the description usually explains what a class, method, or property does. However, these lines are annotations within the PHPDoc comment, using the @property tag to indicate that the model class has properties like id, name, etc. Such annotations are meant to inform tools like IDEs (e.g., PhpStorm) or documentation generators about the properties of the class, especially when these properties are not directly visible in the code (e.g., through magic methods like __get() and __set()).

The "bug with spaces" in the property annotation has also been fixed, so that code style no longer complains. The description is formatted using cebe\yii2openapi\lib\helpers\FormatHelper::getFormattedDescription.

Thank you!


DeskPad display doesn't respond like physical display

I just got an ultruwidescreen for work and was so thrilled to find this! I installed the app no problem, but when I open it, and the DeskPad display opens, I can't actually use it, i.e. I can't open my applications on it. I click on the icons in my control dock and they don't open?

First thing you need to do is position it within the OS as if it is a physical monitor. Does that mean it's to the left or right if your display? Or above or below? Set that up in your display options.
Then you drag the applications off that side of the screen, into the virtual monitor.


Headless Users addition is not working - asking for user input

Make sure your check these beforehand!

[X] Issues - https://github.com/angristan/openvpn-install/issues
[X] README and FAQ - https://github.com/angristan/openvpn-install
[X] Wiki - https://github.com/angristan/openvpn-install/wiki
[X] Discussions - https://github.com/angristan/openvpn-install/discussions

Server OS
Ubuntu 18.04 (LTS) x64
OpenVPN version
2.4.4
Client
No response
What is the bug?
I am trying both the BASH script and single-line command to add a new certificate But it is still asking for the USER input.
Here is by BASH script:
#!/bin/bash
export AUTO_INSTALL=y
export MENU_OPTION="1"
export CLIENT="nyc83"
export PASS="1"
./openvpn-install.sh

Here is the single-line command:
AUTO_INSTALL=y MENU_OPTION="1" CLIENT="nyc83" PASS="1" ./openvpn-install.sh
Please help to resolve this.

Relevant log output
No such logs. when I run the bash script or single line command, it ask for user input again by showing a menu.

@angristan @Nyr @randomshell @dumrauf can someone please help? I need your support urgently.

Figured out the issue. Things are working fine. No input is required. Thanks.

how was it fixed?

I was using an older version. It was a mistake at my end.

how was it fixed?

I was using an older version. It was a mistake at my end.

how was it fixed?

I was using an older version. It was a mistake at my end.

I see, thank you.
For future, if anyone visits this thread, I ended up using https://github.com/mimooh/ovclient/ which is a great tool to do stuff like this.


Provide a new Java Rule checking if @Override is used

com.tngtech.archunit.base.ArchUnitException$InvalidSyntaxUsageException: Annotation type java.lang.Override has @Retention(SOURCE), thus the information is gone after compile. So checking this with ArchUnit is useless.

com.tngtech.archunit.base.ArchUnitException$InvalidSyntaxUsageException: Annotation type java.lang.Override has @Retention(SOURCE), thus the information is gone after compile.


Exclude self from entity list

I've noticed that sometimes my view goes straight down when locking on. I soon figured out it's because I was included in the entity list, so I was tracking myself. This could be a simple fix I think but not too urgent.

Oh that's right. I forked it to add more entities, should've remembered it was my fault.
If you ever do add support for players then watch out for that. (I fixed it by removing the player from the list)

Sorry for the inconvenience.


chore: Minor tweaks for the Storage retry conformance tests

Merging as-is for simplicity; Amanda's comments can be looked at for future work. (There's already going to be another PR to remove some cleanup code.)


Table in society home should be responsive.

Table is the society home screen is not responsive enough, when the screen resolution is getting smaller the table can't be readable.

Since we haven't encounter further UI bug, I am closing this issue for now.


Feature: [Playground] Show href in status bar when hovering over links

When hovering over links in the Playground, the status bar – which usually appears in browser's bottom-left corner displaying the href – does not appear. Would be nice to support this standard/expected behaviour.
Outside of scope of the issue but related: arguably, the cursor should be a pointer when hovering over links. You can select within a link, yes, but clicking on the link does not position the cursor (it opens the link).

Hi I found the solution.

Are you certain? I had already tried that in my own project – the only thing it does is show the pointer on hover, doesn't show the link in the status bar? The issue seems related to the fact that the anchors are inside a contenteditable. E.g. setting contenteditable=false on the anchors regains the default behaviour.

If you want to show the actual link address on hover of the link, an easy solution is just to add the title attribute to the linke node so it shows on the a element.

Upon looking into this a little further, I think this constitutes default browser behaviour when a link is within a contenteditable.


Freya implementation

Initial attempt to replace Giraffe with Freya. See #199

Why do you want to replace giraffe with Freya?

See #199

This looks good! Thumbs up from me 👍

@alfonsogarciacaro what would it take to merge this PR? Travis failed for no good reason.

Sorry @nojaf, I'm not always watching this repo so didn't see the PR. As this is just an extra branch, I don't see any reason not to merge, so let's do it! If you want you can also send a PR to master's README to add a link to the branch for an alternative to the backend :+1:

Thanks Alfonso, I'll send a PR to the master branch.

See https://github.com/SAFE-Stack/SAFE-BookStore/pull/348


Empty command after :global/some-text/p jumps to the last match

When we do not enter any command after printing matching lines using :global, and simply press <Esc> or <Enter>, the cursor jumps to the last match shown. This is annoying.
Is there a rationale behind this?
I think this happens because the print command is performed on each match, and it ends with the last one.
Can the behaviour be changed such that the location is maintained on not entering any command?

That is specified posix behaviour

Current line: If no commands executed, set to the last marked line. Otherwise, as specified for the executed ex commands.)

Oh okay. That's fair then.


forbid any non-float value for the threshold

right now the threshold can be set by any value. We should forbid to set it by sth else than a float

integer is fine too


How to make calendars scroll horizontal?

@avcolar Hi!
Alas, but horizontal scrolling is not supported at the moment.

when will it be available?

We haven't planned this feature, so it won't be implemented in the nearest feature.


Validate bytecode at a given contract address

Builds on #810
Given an address on the ethereum chain, we should be able to get the bytecode loaded there (or no bytecode).
Method like getContractAtAddress()

[ ] Expose reading the bytecode at an address as a method on EthereumConnection
[ ] Validate the contents of a previously uploaded contract (as a test)
[ ] Verify if this is deterministic (solidity -> bytecode), always? for one version of solc? never?
[ ] Bonus: check if it is possible to reverse compile the bytecode

I think this does not belong in iov-core itself, but rather tooling (like we have for deployment), so we can make use of tons of libraries without adding all those dependencies.
Still, a useful tool to validate if a local solidity contract matches some deployed bytecode


add a note about additions to the style guide

adding a little note about adding things to the style guide
super open to feedback on my words

It came up in convo with Luke. Would you rather it work the other way? meaning things get added to the style guide first and then the work to align to it happens?

Thanks @jkodroff, that wording is better. Still, I'd like to see an example of what this workflow would actually look like in practice and how it's better than just submitting a PR that invites the same discussion. Say I wanted to propose using a particular kind of punctuation in some scenario or other. Is there some reason I shouldn't just submit a PR on this repo for that? What's better about filing an issue and a concurrent PR?

@cnunciato lets chat more about this at our next 1-1. no urgency, ill add a do-not-merge label for now.

@susanev Works for me, thanks. I’m sure there are good reasons behind the desire to have this, it’d just be clear about what they are. Thanks for the discussion.

talked with @cnunciato going to hold off on this until we have the problem surface again.
general agreement than when you are adding something to the style guide that fundamentally changes how we've done things previously that should start with an issue, slack convos, zooms, or similar.


updated utilStages to util_stages

Change Description

[ ] My PR includes a link to the issue that I am addressing

Solution Description

Code Quality

[ ] I have read the Contribution Guide
[ ] My code follows the code style of this project
[ ] My code builds (or compiles) cleanly without any errors or warnings
[ ] My code contains relevant comments and necessary documentation

Project-Specific Pull Request Checklists

Bug Fix Checklist

[ ] My fix includes a new test that breaks as a result of the bug (if possible)
[ ] My change includes a breaking change

[ ] My change includes backwards compatibility and deprecation warnings (if possible)

New Feature Checklist

[ ] I have added or updated the docstrings associated with my feature using the NumPy docstring format
[ ] I have updated the tutorial to highlight my new feature (if appropriate)
[ ] I have added unit/End-to-End (E2E) test cases to cover my new feature
[ ] My change includes a breaking change

[ ] My change includes backwards compatibility and deprecation warnings (if possible)

Documentation Change Checklist

[ ] Any updated docstrings use the NumPy docstring format

Build/CI Change Checklist

[ ] If required or optional dependencies have changed (including version numbers), I have updated the README to reflect this
[ ] If this is a new CI setup, I have added the associated badge to the README

Other Change Checklist

[ ] Any new or updated docstrings use the NumPy docstring format.
[ ] I have updated the tutorial to highlight my new feature (if appropriate)
[ ] I have added unit/End-to-End (E2E) test cases to cover any changes
[ ] My change includes a breaking change

[ ] My change includes backwards compatibility and deprecation warnings (if possible)

Fixes outstanding errors in unit tests coming from change of utilStages to util_stages and from downloading sfd dustmap.

whoops, hit return before typing, looks good, thanks Eric.


Outline button hover should apply same darken as filled button.

If you have two buttons with the same theme color next to one another, one filled and one outline, the outline button's hover state is visually confusing. When hovered it fills and matches the already filled button exactly. When the outline button it hovered the color should fill and have the same darken applied as the standard button to prevent this.
https://codepen.io/afholderman/pen/rGyqbK

Good spot, that does make it confusing.

If you would like can submit a PR altering the mixin to perform the same way as the filled button.

@afholderman please send a PR, and good catch!

PR open here: https://github.com/twbs/bootstrap/pull/24150

I agree the mixin should be updated and these colors should be customizable, but I'm going to merge the PR with the current values to keep the look of these as I originally intended. We can revisit eventually, but for now I'd like to keep the default colors.


RegexNotFoundError when fetching a Dailymotion URL

$ youtube-dl --verbose http://www.dailymotion.com/video/x20su5f_the-power-of-nightmares-1-the-rise-of-the-politics-of-fear-bbc-2004_news
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'--verbose', u'http://www.dailymotion.com/video/x20su5f_the-power-of-nightmares-1-the-rise-of-the-politics-of-fear-bbc-2004_news']
WARNING: No ssl certificates were loaded, urls that use https won't work
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2015.04.03
[debug] Python version 2.7.9 -<EMAIL_ADDRESS>[debug] exe versions: none
[debug] Proxy map: {}
[dailymotion] x20su5f: Downloading webpage
[dailymotion] x20su5f: Extracting information
[dailymotion] x20su5f: Downloading embed page
ERROR: Unable to extract video info; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/usr/lib64/python2.7/site-packages/youtube_dl/YoutubeDL.py", line 651, in extract_info
    ie_result = ie.extract(url)
  File "/usr/lib64/python2.7/site-packages/youtube_dl/extractor/common.py", line 275, in extract
    return self._real_extract(url)
  File "/usr/lib64/python2.7/site-packages/youtube_dl/extractor/dailymotion.py", line 118, in _real_extract
    'video info', flags=re.MULTILINE)
  File "/usr/lib64/python2.7/site-packages/youtube_dl/extractor/common.py", line 547, in _search_regex
    raise RegexNotFoundError('Unable to extract %s' % _name)
RegexNotFoundError: Unable to extract video info; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

You are using an outdated version of youtube-dl. Read our FAQ if you have troubles updating.


Image deletion check of notary signature can be worked around

For tags 1.0 and 2.0 with the exact same manifest.
If only 1.0 is signed, user can delete 1.0's manifest without signature check by deleting 2.0
Need to check the digest before issuing API to registry instance.

fixed in #1815


Transcription bar - Can't see 'Observation time' because it gets cropped

Issue
The observation time does not display all at once because it is too big for the field.

Hence, part of it gets cropped, making it impossible to see the entire value. This can lead to more errors (e.g. can't see that I put 'pm' instead of 'am').
Moreover, I find that re-writing the date for every transcription is a pain in the neck.
Potential solution
Turn the 'observation time' field in to a Select2. This would also make it more user friendly.

Done


Mitigate missing icons

This would fix issue #3 raised by me yesterday. Well there wasn't really an issue in the build process, it's just that it requires icons to be present to work, and this makes sure users always start out with an empty icon to begin with, so they don't end up like me, looking at the half-finished build and wondering where their app is.

@NicolasNeubauer Thanks a lot


[Issue #841 #840 #839] Expanding sync application examples

Expanding upon the description of the sync applications case by adding examples.
Updating navigator.install usage example to match most recent requirements.
Fixes #841, fixes #840, fixes #839

This fixed the question I had - I'm not an expert on the use-cases here but this seems good?


SSO v2 updates

🔧 Changes

POST /api/v2/self-service-profiles: Added new fields
PUT /api/v2/self-service-profiles/{id}/custom-text/{language}/{page}: New endpoint introduced
GET /api/v2/self-service-profiles/{id}/custom-text/{language}/{page}:  New endpoint introduced
POST /api/v2/self-service-profiles/{id}/sso-ticket: Added new fields
POST /api/v2/self-service-profiles/{id}/sso-ticket/{id}/revoke: New endpoint introduced

📚 References
https://auth0.com/docs/api/management/v2/self-service-profiles/get-self-service-profiles

🔬 Testing
All relevant test cases for modified and newly introduced endpoints have been added.

📝 Checklist

[x] All new/changed/fixed functionality is covered by tests (or N/A)
[x] I have added documentation for all new/changed functionality (or N/A)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.33%. Comparing base (89bcb9b) to head (cbaf973).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #457      +/-   ##
==========================================
- Coverage   95.81%   95.33%   -0.49%
==========================================
  Files          51       51
  Lines        8461    10304    +1843
==========================================
+ Hits         8107     9823    +1716
- Misses        236      363     +127
  Partials      118      118

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@w-kuhn Before end of this month :)


Add eAdventure v1.5

If there’s a checkbox you can’t complete for any reason, that's okay, just explain in detail why you weren’t able to do so.
After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} reports no offenses.
[x] The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

[x] Named the cask according to the token reference.
[x] brew cask install {{cask_file}} worked successfully.
[x] brew cask uninstall {{cask_file}} worked successfully.
[x] Checked there are no open pull requests for the same cask.
[x] Checked that the cask was not already refused in closed issues.

eAdventure is an authoring tool for the creation of point-and-click games, especially designed for educational purposes

It’s missing uninstall. There are scripts and documentation geared for that.

Closing for lack of reply.


example-cnf | Remove references to load balancer

SUMMARY
example-cnf's testpmd-lb-operator is deprecated and we're removing it from the repo, so removing all code related to deploying it.
ISSUE TYPE

Enhanced Feature

Tests

[x] Disconnected environment - https://www.distributed-ci.io/jobs/a533b09d-da70-477d-b4ae-7b20fac8f2e5/jobStates?sort=date
[x] Connected environment - https://www.distributed-ci.io/jobs/427c16d9-02e5-4f8a-b552-627d9e42aca4/jobStates?sort=date

Test-Hints: no-check

This is ready for review, the change is working in both connected and disconnected environments, issues in previous jobs are related to certsuite because of not using HEAD version and tests_to_verify complained, but with regards to example-cnf installation, this works fine.

recheck


Issue with PyTorch dumper script

PyTorch follow different convention than tensorflow for input image for example
PyTorch input image shape: [inDepth, height, width]
PyTorch filter shape [outDepth, inDepth, filterHeight, filterWidth].
TF input image shape:  [height, width,inDepth].
TF filter shape [filterHeight, filterWidth, inDepth, outDepth].
The Conv2d function of deeplearnjs also expect input image and filter in TF format but in the PyTorch dump script we are not transposing weights to suit Conv2d function. We should also change the shape in manifest file accordingly. But i can not find any line of code that does it. Could you please check this out.
Let me know, if i misunderstood something or issue is not clear.

I think the transposing should probably happen in user code (for now) - you can use math.transpose(). We may get to a point where we also dump the format of the weights so that we can automatically do transposing, but that will likely happen when we do more end-to-end model conversion.


Repackaging - Illumio Core (MMA to AMA Migration)

Required items, please complete
Change(s):

See guidance below

Reason for Change(s):

See guidance below

Version Updated:

Required only for Detections/Analytic Rule templates
See guidance below

Testing Completed:

See guidance below

/Package


Update ops to run planpreview cleaner at a fixed time

What this PR does / why we need it:

Fix the time to run the job to make it becomes more predictable.
This also ensures that the job will be executed once per day even if the ops was restarted or deployed.

Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

NONE

/lgtm

🚀
/approve


Please rename your module

The project refers to AngularJS but says Angular everywhere. Please rename accordingly so people don't get confused.

Thank you for pointing this out. I would be happy to look at a PR for this.

Hello! I created a PR for this https://github.com/danielstern/ngAudio/pull/211


Kernel Launcher Draft

For #10479

[ ] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
[ ] Title summarizes what is changing.
[ ] Has a news entry file (remember to thank yourself!).
[ ] Appropriate comments and documentation strings in the code.
[ ] Has sufficient logging.
[ ] Has telemetry for enhancements.
[ ] Unit tests & system/integration tests are added/updated.
[ ] Test plan is updated as appropriate.
[x] package-lock.json has been regenerated by running npm install (if dependencies have changed).
[ ] The wiki is updated with any design decisions/details.

Codecov Report

Merging #10550 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #10550      +/-   ##
==========================================
- Coverage   60.84%   60.77%   -0.07%
==========================================
  Files         579      579
  Lines       31303    31403     +100
  Branches     4453     4469      +16
==========================================
+ Hits        19046    19085      +39
- Misses      11293    11346      +53
- Partials      964      972       +8

Impacted Files
Coverage Δ

...lient/common/application/applicationEnvironment.ts
19.04% <0.00%> (-14.29%)
:arrow_down:

src/datascience-ui/react-common/arePathsSame.ts
75.00% <0.00%> (-12.50%)
:arrow_down:

src/client/common/utils/platform.ts
64.70% <0.00%> (-11.77%)
:arrow_down:

src/client/interpreter/activation/service.ts
78.40% <0.00%> (-10.49%)
:arrow_down:

src/client/datascience/jupyter/jupyterSession.ts
62.93% <0.00%> (-2.42%)
:arrow_down:

src/client/linters/pydocstyle.ts
86.66% <0.00%> (-2.23%)
:arrow_down:

src/client/datascience/debugLocationTracker.ts
76.56% <0.00%> (-1.57%)
:arrow_down:

src/client/common/asyncDisposableRegistry.ts
16.66% <0.00%> (-1.52%)
:arrow_down:

...reter/locators/services/cacheableLocatorService.ts
78.70% <0.00%> (-1.49%)
:arrow_down:

src/client/debugger/extension/adapter/factory.ts
94.28% <0.00%> (-1.43%)
:arrow_down:

... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a0fa48...75c636d. Read the comment docs.


Help installing the toolkit

Hello,
I am trying to install the toolkit but i am stuck. In Visual Studio i started a new project: Visual C#, windows form application. Via Package manager console i downloaded the latest version of the toolkit.
From this point i'm stuck. I want to make a windows application of the toolkit, can someone help me out on what to do?
Thanks, Martijn

Read the read me file.


Run multipass until 0% changes

I'm currently able to consistently run it with --multipass multiple times (like 5 or 6) until it finally says that there were 0% savings.

It's already doing so, but just limited to 10 times.

It runs multipass a max of 10 times, but not until 0% changes.

Yes, that's the point of the limit. Not to run for too long.

Yeah, but is it checking "if 0% change, end", or simply "run 10 times"? I'm having to run multipass multiple times to achieve this. I understand the desire to avoid lagging the system by running it 400 times, but there should at least be an option to run until it technically does not need to be ran again.

This feature would be nice. I assume it would have to stop eventually, right? :)
I want it "optimized", not just smaller. :)

:+1: I always have to manually run it multiple times because it always manages to optimize more even with --multipass.

Actually, there is some weird stuff happens, it may give a little profit by the quality decrease. May be a lesser precision option will give you much more.

How about an optimization level (like optipng) where it runs until it meets a threshold. My biggest concern is that running it a second time shouldn't change the file at all. When you're keeping your SVGs in version control, SVGO is a nice way to normalize them, but not if it modifies the file on every invocation.

I don't think that the authors care. It's been 7 months.

Has this been fixed?

Wouldn't fix.

Not a good decision, in my opinion (as well as others).

It'd just spend time for nothing. Ideally, there should be no changes after few iterations, but there are some rounding issues. It's not an optimization, just a picture little worse. If it's ok to you just decrease precision.

Ok. Is there an issue created for correcting the rounding issues? With that fixed, it'd nullify our thoughts on needing this issue's feature.

Only in my but head :smiley:.

Ah, then I've created an issue for it. Not that I think you'll forget, but we need a place to nag :wink:


feat: University, Nokia, Genetec, Unity sponsor logos

Looking for feedback on the layout of the logos on the mobile width of the sponsor section!
closes #84 #85

Since they're SVGs, what I normally do is throw them in Figma and use the "Resize to fit" option so the actual content/logo takes up the full viewbox.

@sttic Thanks for the tip! I've just updated the PR with all the new SVGs resized to fit.

Sorry, 1 last change request 😅 I think there should be more space under the sponsors (between it and ticket pricing section). I believe the previous "Stay tuned for more!" message was adding some margin but the margin wasn't re-added since its removal.

That's totally my bad! LOL


move rest of sumit code into here with a single common makefile

Hi @rpreen , would welcome your thoughts on this as a simplifying plan for distributing the code without all the netbeans-generated crap and without the need for separate repositories

Having edited the various makefiles, they are far more complex that they need be, and in particular by using different named sub-directories for different architectures within the dist directory they introduce a level of complexity that I don't think is justified.
I'm also not particularly convinced. about the desirability of requiring users to install cmake for creating the executables for the cpp files.
I suggest a structure something like:
src:
-- libfiles/
-- cell_suppression/
-- solver/
-- server/
-- thirdparty/ (the coin-or files with their licence)
dist/
holds the sumitlib.o, uweserver.jar, uwecellsuppresssion(.exe) and uwesolver(.exe) files
Makefile (single file at top level within src, no messing around with lower level ones with sub-directories)
all: uweserver, cellsuppression and solver as targets
Then if someone wants to add code that does something other than cell suppression, they can add new directories, pull from the lib if they want to etc.

Sounds reasonable to me.

I've forked a branch and started work on it.
pushed to avoid losing work in extremis but needs makefile completing and cpp adding from coin-or


Is it okay to have multiple set-cookie headers?

When proxying, say, HTTP/1.1, it's possible to receive a response with multiple set-cookie headers. How does this work in HTTP/2 and in this gem?
Do we need to do something to handle this?

Yes, per HTTP spec you can have multiple headers with the same name. The semantics of how such values are processed are up to the particular header. In case of Set-Cookie all values are processed.
Nothing h2 specific here.

Okay, great. I did end up looking through the code and it seem straight forward. I wasn't sure if it used a hash or an array of [key, value] pairs, but it's the latter.


avoid random random numbers by avoiding the use of std::random_device

Submission Checklist

[X] Run unit tests: ./runTests.py test/unit
[ ] Run cpplint: make cpplint
[X] Declare copyright holder and open-source license: see below

Summary:
This fixes issue #890 which reports that some tests fail occasionally. It turns out that we use random random numbers ... that is the random seed of used for the random generator in some tests were derived using the stan::random_device facility such that the random number generator stream changed from test to test. This happens to trigger once in a while test failures.
This PR now replaces the std::random_device generator with a mersenne twister seeded with seed 1. Thus we will get always the same tests whenever things are sufficiently stable. This should avoid occasionally breaking tests while we still use random numbers as needed.
Intended Effect:
Make tests reliable.
How to Verify:
Run the tests
test/unit/math/fwd/mat/fun/matrix_exp_test.cpp
test/unit/math/fwd/mat/fun/matrix_exp_pade_test.cpp
test/unit/math/mix/mat/fun/append_array_test.cpp
test/unit/math/rev/mat/fun/matrix_exp_test.cpp
test/unit/math/prim/mat/prob/lkj_cov_test.cpp
test/unit/math/prim/mat/fun/matrix_exp_test.cpp
test/unit/math/prim/mat/fun/matrix_exp_pade_test.cpp

Side Effects:
None.
Documentation:
NA
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Sebastian Weber
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

I am not sure I agree with this approach. The point of non-deterministic tests is to notice when tests are flaky or there are edge cases. I get that it is annoying when nondeterministic tests fail for an unrelated PR, but it would seem that the tolerance should be upped or the tests / implementation should be improved. The human reviewer ought to be able to recognize when that is the case.

The matrix tests do fail once in a while which is why @syclik suggested to avoid true randomness (as I understood him). We need to get our test pipeline into a stable state again.
Would it make you feel better if we introduce a STAN_TEST_SEED macro which holds some integer to be used as initializer for the rngs? Then you could at least change that easily.
The other solution would be to less strict with the tolerances for the matrix exponential, but then we would have to loosen them quite a bit. Right now they are at 1E-10, but the tests did spit out differences of up to 1E-6 if I recall right. Thus we would have to set it to 1E-5 or so.
As I say, an unreliable testing pipeline is something we need to resolve. We could also merge this and file an issue (if reviewer agrees)?

I think loosening tolerances is better than reducing randomness.
Using only deterministic tests or equivalently using a fixed seed reduces
the coverage of the tests because they only get evaluated at values that
are known to be good or bad. There is a whole movement toward fuzzing in
order to find bugs in code. It is good to know that the matrix exponential
can only be accurate to 1E-6 in some cases.
If someone's PR fails because of some unrelated non-deterministic test,
then we should re-run the tests, approve the PR, and work to improve the
test or the implementation of the thing that fails with some small
probability.
On Sun, Jun 10, 2018 at 2:10 PM, wds15<EMAIL_ADDRESS>wrote:

The matrix tests do fail once in a while which is why @syclik
https://github.com/syclik suggested to avoid true randomness (as I
understood him). We need to get our test pipeline into a stable state again.
Would it make you feel better if we introduce a STAN_TEST_SEED macro which
holds some integer to be used as initializer for the rngs? Then you could
at least change that easily.
The other solution would be to less strict with the tolerances for the
matrix exponential, but then we would have to loosen them quite a bit.
Right now they are at 1E-10, but the tests did spit out differences of up
to 1E-6 if I recall right. Thus we would have to set it to 1E-5 or so.
As I say, an unreliable testing pipeline is something we need to resolve.
We could also merge this and file an issue (if reviewer agrees)?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/stan-dev/math/pull/898#issuecomment-396069399, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADOrqqRCmWlHmib1QKjjGpPQoqfJYhxmks5t7WEPgaJpZM4UhszA
.

Would you also agree that Stan Math should have more unit testing of
mathematical identities using non-deterministic inputs?
Most of Stan Math is unit testing of a few deterministic results that are
not identities and checking for exceptions with bad input. For the former,
at least for doubles / ints, we are usually not adding much value beyond
what is already in the Boost or Eigen unit tests. Our checking the
gradients is necessary but would be better if it were based on identities.
On Sun, Jun 10, 2018 at 4:23 PM, Krzysztof Sakrejda <
<EMAIL_ADDRESS>wrote:

basically agreeing with Ben
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/stan-dev/math/pull/898#issuecomment-396079272, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADOrquGI6AHu6FL3Ue6FjVwMoKmk6Sedks5t7YBbgaJpZM4UhszA
.

@bgoodri yep, testing identities would be great, but probably needs some clever framework.
I am closing this PR at the loosened tolerances were merged

How about creating a set of random stress tests that we run intermittently?  My main concern is that we don't slow down the dev process, specifically in the case where tests fail for reasons unrelated to the change being made.
For these numerical random stress tests, I'd be OK lowering tolerances in cases where we don't have good numerical analyses (i.e., almost everywhere).
As @bgoodri points out, there is a lot of room for improved testing.
Analytic identities carry the risk of duplicating derivation mistakes in the original implementations.  Finite diffs have the nice property of checking the derivatives of the actual double-based function against the autodiff.
The double and int tests do multiple things.  For even the simple library functions like exp, they are testing instantiatability.  Lack of instantiatability, particularly for the int case when faced with templates causing ambiguity, has caused a lot of bugs in the past.  This is the point that @syclik is always stressing.
For the rest of our functions which aren't simple library functions, they're testing that we're getting the right values (or that Boost is getting the right values in some direct cases).  So I don't want to get rid of them.
Bottom line is that I'm OK with this, but it's a big enough policy decision that we should run it by @syclik for the math lib.

Whatever else we do, I like this idea:

On Jun 10, 2018, at 2:10 PM, wds15<EMAIL_ADDRESS>wrote:

Would it make you feel better if we introduce a STAN_TEST_SEED macro which holds some integer to be used as initializer for the rngs? Then you could at least change that easily.

It sounds like we really need two sets of tests:

unit tests that should pass all the time
randomized tests that may fail occasionally.

The reason to separate them out is because having intermittent failures is
really a recipe for driving developers insane. It's actually the reason
that got us testing in the first place; having things break that aren't
related to your own branch really makes it really difficult to debug.
But... there's tremendous value there if we choose to follow up on the
failures. Are we going to follow up on the failures or are they just going
to burn cycles? @bgoodri, I'd be much more inclined testing random inputs
if you're willing to help create a procedure for following up. (You don't
have to do all the work, but it would help if you could tell us what we
could do to debug.)
On Mon, Jun 11, 2018 at 8:11 PM Bob Carpenter<EMAIL_ADDRESS>wrote:

Whatever else we do, I like this idea:

On Jun 10, 2018, at 2:10 PM, wds15<EMAIL_ADDRESS>wrote:

Would it make you feel better if we introduce a STAN_TEST_SEED macro
which holds some integer to be used as initializer for the rngs? Then you
could at least change that easily.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/stan-dev/math/pull/898#issuecomment-396425100, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAZ_Fw4dSJZv-X2Z0c3L62_3q3iMC5MKks5t7wcSgaJpZM4UhszA
.

@syclik I agree that we need different sets of tests but randomization may not be what we need.  The math functions mostly run fast enough individually that for functions with a small number of arguments we can run complete tables of values to identify regions where they fail.  For functions (like the matrix exponential) that have a huge input space randomization makes a lot of sense, although even there it's probably pretty well known what causes failures (condition number and such).  Should probably continue this conversation on discourse.

Interesting. I did not expect to trigger such a discussion... which should be continued on discourse, yes. Just to make sure everyone got this: Now we have reduced tolerances for matrix_exp stuff in stan-math and we also have a ticket to follow up on this.

Yes, got it.  Thanks for fixing things so the tests pass.


Enforce the structured programming paradigm on organisms

Enforce Céu principles, trading off complete user control over the library in for organisms that fit neatly into the structured programming paradigm.

Organisms have been removed.


Null is not inserted

Inserting null with insert(KEY, null) doesn't work at the moment. The only way to delete a value is to call remove(KEY).

fixed with version 0.9.1 https://github.com/grandcentrix/tray/releases/tag/v0.9.1


feat!: move parse_type method to ethereum plugin

What I did
I am moving parse_type method from ape_utils to ape_ethereum

fixes: #
How I did it
Move the abi section of code to a new file of abi.py under ape_ethereum
How to verify it
run pytest and make sure the old test still work

See https://github.com/ApeWorX/ape/pull/1160


Exception when using DelimitedClassBuilder.

Hi,
I am trying to create the dynamic delimited record using this code:
        var classBuilder = new DelimitedClassBuilder("cls_" + Guid.NewGuid().ToString("N"), ",")
        {
            Namespace = "ns_" + Guid.NewGuid().ToString("N"),
            IgnoreFirstLines = 0,
            IgnoreEmptyLines = false
        };

        m_Context.Mappings.ForEach(map =>
        {
            string name = map.Name;
            Type type = map.Type ?? typeof (string);
            var field = classBuilder.AddField(name, type);
        });

        var recordClass = classBuilder.CreateRecordClass();

It fails on some servers with, throwing this exception:
Failed to create pipeline SomeEtlProcess: Error Compiling Expression:
Line 0: An assembly with the same simple name 'SomeAssembly, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null has already been imported. Try removing one of the references or sign them to enable side-by-side.
The class does not use SomeAssembly (types are alwayes primitives)
I am using version 3.0.46-beta.
Any ideas?
TIA,
Moti.

Hi there Moti
Are calling multiple times to CreateRecordClass ?
What about calling CreateEngine or the other methods, I will review the code to check if it tries to compile it multiple times
Thanks

Hi,
Not in the same instance.
The process is the usual ETL. Client uploads file, maps it, I create the record class and use it.
On the server where it fails, it fails every single time. On local development environment it works.
Thank you,
Moti

Hi Moti I just made a change that must fix your problem, now the library only load system assemblies and no all the referenced in the Current Domain
Can you try with the last version: http://teamcity.codebetter.com/viewLog.html?buildId=195459&buildTypeId=FileHelpersMaster&tab=artifacts
Can you confirm that it works ?
Thanks

Thank you, I will know in a couple of days.

Great, please after you test it, add your comments below

Hi Marcos,
It seems to be working now.
Thank you very much.

Happy that works now :)
Thanks for reporting
Marcos


zmq.asyncio is broken (examples inside)

This code works as expected (using normal asyncio module):
import asyncio
queue = asyncio.Queue()

async def pushing():
    while True:
        await queue.put("hello")
        await asyncio.sleep(1)

async def pulling():
    while True:
        greeting = await queue.get()
        print(greeting)

def asyncio_loop():
    import asyncio
    loop = asyncio.get_event_loop()
    tasks = [
        pushing(),
        pulling()
    ]
    loop.run_until_complete(asyncio.wait(tasks))
    loop.close()

if __name__ == '__main__':
    asyncio_loop()

Whereas the code using zmq.asyncio hangs (it's not resuming the functions):
import asyncio
queue = asyncio.Queue()

async def pushing():
    while True:
        await queue.put("hello")
        await asyncio.sleep(1)

async def pulling():
    while True:
        greeting = await queue.get()
        print(greeting)

def zmq_async_loop():
    import zmq.asyncio
    loop = zmq.asyncio.install()
    tasks = [
        pushing(),
        pulling()
    ]
    loop.run_until_complete(asyncio.wait(tasks))
    loop.close()

if __name__ == '__main__':
    zmq_async_loop()

Strangely the ZMQ Tornado IOLoop, prints a single "hello" before hanging:
import asyncio
queue = asyncio.Queue()

async def pushing():
    while True:
        await queue.put("hello")
        await asyncio.sleep(1)

async def pulling():
    while True:
        greeting = await queue.get()
        print(greeting)

def zmq_tornado_loop():
    from zmq.eventloop.ioloop import IOLoop
    loop = IOLoop.current()
    loop.spawn_callback(pushing)
    loop.spawn_callback(pulling)
    loop.start()

if __name__ == '__main__':
    zmq_tornado_loop()

Instantiating the Queue attaches to the current (default) asyncio eventloop. Then, when you later start the zmq loop, a new eventloop is created and installed, but the Queue is still attached to the first eventloop, which never runs.
To work with an alternate eventloop, the eventloop must be installed prior to anything registering listeners. Calling install() before instantiating Queue() should do it:
import asyncio

# install the zmq asyncio loop before anything
# registers listeners (e.g. creating a Queue)
import zmq.asyncio
zmq.asyncio.install()

queue = asyncio.Queue()

async def pushing():
    while True:
        await queue.put("hello")
        await asyncio.sleep(1)

async def pulling():
    while True:
        greeting = await queue.get()
        print(greeting)

def zmq_async_loop():
    loop = asyncio.get_event_loop()
    print(loop)
    tasks = [
        pushing(),
        pulling()
    ]
    loop.run_until_complete(asyncio.wait(tasks))
    loop.close()

if __name__ == '__main__':
    zmq_async_loop()

oh! Apologies for not seeing this, and wasting your time with the bug report. Many thanks for your answer. Here's my project if you're interested to see where pyzmq is being used: https://github.com/rojavacrypto/python-libbitcoin


While installing CP4D on IBM Satellite with worker running on RHCOS, the cloud-pak-crontab-ds pods are stuck in  "CreateContainerError" state for all the worker nodes.

Describe the bug
While installing CP4D on IBM Satellite with worker running on RHCOS, the cloud-pak-crontab-ds pods are stuck in  "CreateContainerError" state for all the worker nodes.
As Satellite/roks does not have MCO, deployer uses cloud-pak-crontab-ds daemon set to do the changes on all the worker nodes.
Another thing to consider here is - RHCoreOS does not have crontab, so will also have to figure out a way to set the crontab equivalent on all the worker nodes to check for any changes.
These pods are spawned by cloud-pak-crontab-ds daemon set in kube-system ns.

pods in error state

kube-system     cloud-pak-crontab-ds-2mzzh          0/1 CreateContainerError 0 7m13s <IP_ADDRESS>  corp-dev-007-ocpw-cc-vm-23 <none> <none>
kube-system     cloud-pak-crontab-ds-58lbx          0/1 CreateContainerError 0 7m13s <IP_ADDRESS>  corp-dev-007-ocpw-cc-vm-06 <none> <none>
kube-system     cloud-pak-crontab-ds-696tx          0/1 CreateContainerError 0 7m13s <IP_ADDRESS>  corp-dev-007-ocpw-cc-vm-05 <none> <none>
kube-system     cloud-pak-crontab-ds-6gr2p          0/1 CreateContainerError 0 7m13s <IP_ADDRESS>  corp-dev-007-ocpw-cc-vm-09 <none> <none>
kube-system     cloud-pak-crontab-ds-7mhl5          0/1 CreateContainerError 0 7m13s <IP_ADDRESS>  corp-dev-007-ocpw-cc-vm-25 <none> <none>

The error in the describe output
Normal  Pulled   7m          kubelet      Successfully pulled image "registry.access.redhat.com/ubi8:latest" in 748.50271ms
Warning Failed   6m45s (x8 over 8m6s) kubelet      Error: failed to mkdir /cloud-pak-node-fix: mkdir /cloud-pak-node-fix: operation not permitted
Normal  Pulled   6m45s         kubelet      Successfully pulled image "registry.access.redhat.com/ubi8:latest" in 173.638424ms
Normal  Pulling  3m1s (x25 over 8m7s) kubelet      Pulling image "registry.access.redhat.com/ubi8:latest"
oc get ds
NAME           DESIRED  CURRENT  READY  UP-TO-DATE  AVAILABLE  NODE SELECTOR  AGE
cloud-pak-crontab-ds   30    30    0    30      0      <none>     68m
ibm-inplacebootstrapper  0     0     0    0      0      <none>     3d4h
ibm-keepalived-watcher  36    36    36   36      36     <none>     3d4h
konnectivity-agent    30    30    30   30      30     <none>     3d4h

"I think it's the mix of ROKS + RHCOS that's causing the issue here. cp-deployer tries to mount/mkdir /cloud-pak-node-fix on the host, but RHCOS prohibits pods writing to the root filesystem. However, /tmp/cloud-pak-node-fix would be allowed. For the combination where the MCO isn't present and the OS is RHCOS, would it be possible to update cp-deployer to use /tmp instead?"
From slack conversation - https://ibm-analytics.slack.com/archives/C02GQMJA8JJ/p1679607833912619
To Reproduce
Steps to reproduce the behavior:
Installing CP4D on ROKS or Satellite with workers running on RHCoreOS.
Expected behavior
Deployer should be able to install cp4d on ROK/Satellite where workers are running on CoreOS.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
The deployer works on CoreOS workers if the installation is done on OCP (non ROKS cluster)

This is extremely urgent and needs to be fixed asap as it impacts highly visible Canadian Tire project. Please treat this with the highest priority and we need the fix by Monday, please. Thanks, Ani

FYI on creating the systemd timer required for RHCOS. I have been able to successfully able to create the systemd timer using a pod. I had to make changes to the cloud-pak-node-fix-scripts CM and to the cloud-pak-crontab-ds DS.
Next steps are to incorporate into the DS. That shouldn't be too much of a problem but I need to check some things that could be a security issue that I want to prevent.

Changes made, now testing.


[Refactor] Improve asynchronous test cases format

Description
Improve asynchronous test cases format

Created AsyncActions to help generate and collect results
Use of CountDownLatch to trigger requests to run concurrently
Shrunk existing test cases by 2.7 times

Issues Resolved

Follow up to some outstanding feedback from https://github.com/opensearch-project/security/pull/3583

Check List

[X] New functionality includes testing
[X] New functionality has been documented
[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@cwperks here are those improvements from the first PR, let me know what you think

@cwperks Could you take another look at this change?

Manually backported to 2.x because of the apache imports that were using v5


test: fix tests when running in cluster

Changes

:test_tube: Resetting KUBECONFIG environment variable is not sufficient if test runs in cluster.
We also must unset KUBERNETES_SERVICE_HOST environment variable, so in-cluster-config won't kick in.

/approve


Is this training speed normal?

I do not know why this is slow, thank you!

Generating the impulse responses at high reverberation takes quite a long time. In cfg.py, try lowering the upper bound of t60, or use anechoic = True (this will make the simulations reverberation-free). You could also add functionality pre-generate all your data instead of generating it each epoch.

Generating the impulse responses at high reverberation takes quite a long time. In cfg.py, try lowering the upper bound of t60, or use anechoic = True (this will make the simulations reverberation-free). You could also add functionality to pre-generate the dataset instead of generating new data each epoch.

Thank you for your help! I found that lower the upper bound of t60 can reduce the training time, and could you please explain how to pre-generate the dataset?


CI check for every commits

Fail seems to be caused by missing git submodules.

See #6

I'll treat each tag as a release and trigger builds when new tags pushed. Like moonlight-tv. What do you think?

Sounds good to me.

Tested: https://github.com/mariotaku/webos-homebrew-channel/actions/runs/778013920

It's ready to be merged :)

LGTM, thanks.


[TASK][VIEW] Homepage View

As a Site Visitor,
Reference: trending-carousel.handlebars
I WANT to view feature cards
SO THAT I can navigate to the featured persons external account
AC
GIVEN an image on the homepage
WHEN I see the image
THEN I am presented with a gif or image from the featured users twitch video
GIVEN an image
WHEN I see the image
THEN I am presented with the featured users name and the name of the game that is being shown
GIVEN an image
WHEN I click on the image
THEN I am taken to the users twitch account

Created addt'l ticket to reference styling for this task


Updated CDTP RFC terms

"consumer" replaced  with "configuration consumer" and  "provider" replaced  with "configuration provider" to make RFC more clear for readers.

Not certain about this, since we now use the same CDTP protocol to deliver OTA updates. Narrowing the language to configuration only may be a step in the wrong direction.


[acme.dnsChallenge]   not working with gandiv5: No or incorrect TXT record

Do you want to request a feature or report a bug?
Bug
What did you do?

After a change of config I noticed the client no longer gets an accepted certificate. Switching back to the previously working config didn't solve the problem, neither did downgrading to 1.6.2 or 1.6.1..
What did you expect to see?
A working letsencrypt certificate
What did you see instead?
No certificate is generated, but an error appears in the log (see below)
Output of traefik version: (What version of Traefik are you using?)

Version:      v1.6.3
Codename:     tetedemoine
Go version:   go1.10.2
Built:        2018-06-05_03:29:01PM
OS/Arch:      linux/amd64

Same results with 1.6.1, 1.6.2 and 1.6.3

What is your environment & configuration (arguments, toml, provider, platform, ...)?
[acme]
 ...
  caServer = "https://acme-v02.api.letsencrypt.org/directory"

[acme.dnsChallenge]
  provider = "gandiv5"
  delayBeforeCheck = 0
...

[[acme.domains]]
  main = "*.example.org"
  sans = ["example.org"]

[[acme.domains]]
  main = "*.example.guru"
  sans = ["example.guru"]

[[acme.domains]]
  main = "service.example.com"

The results are the same using:
caServer = "https://acme-staging-v02.api.letsencrypt.org/directory"

If applicable, please paste the log output in DEBUG level (--logLevel=DEBUG switch)
6/6/2018 11:31:34 AMGandi DNS: Zone record deleted
6/6/2018 11:31:34 AMERRO[2018-06-06T09:31:34Z] Unable to obtain ACME certificate for domains "service.example.com" : cannot obtain certificates: acme: Error -> One or more domains had a problem:
6/6/2018 11:31:34 AM[service.example.com] acme: Error 400 - urn:ietf:params:acme:error:dns - DNS problem: NXDOMAIN looking up TXT for _acme-challenge.service.example.com
6/6/2018 11:31:34 AM
6/6/2018 11:32:01 AMGandi DNS: Zone record deleted
6/6/2018 11:32:01 AMERRO[2018-06-06T09:32:01Z] Unable to obtain ACME certificate for domains "*.example.guru,example.guru" : cannot obtain certificates: acme: Error -> One or more domains had a problem:
6/6/2018 11:32:01 AM[example.guru] acme: Error 403 - urn:ietf:params:acme:error:unauthorized - No TXT record found at _acme-challenge.example.guru
6/6/2018 11:32:01 AM
6/6/2018 11:32:35 AMGandi DNS: Zone record deleted
6/6/2018 11:32:36 AMGandi DNS: DNS Record Created
6/6/2018 11:33:21 AMGandi DNS: Zone record deleted
6/6/2018 11:33:21 AMERRO[2018-06-06T09:33:21Z] Unable to obtain ACME certificate for domains "*.example.org,example.org" : cannot obtain certificates: acme: Error -> One or more domains had a problem:
6/6/2018 11:33:21 AM[example.org] acme: Error 403 - urn:ietf:params:acme:error:unauthorized - Incorrect TXT record "nYhYDZD1ENYNTDy4_eQ5bP7vhhTVY5xWKrv_8pF3r2U" found at _acme-challenge.example.org

Any idea why it was working before your config change? There is no real reason for that :thinking:

The problem disappeared again like it appeared, without me doing anything I'm having valid certs again. I hope it will stay that way. Thanks for the great product and for looking into this issue.

And the problem appeared again, wildcard certs seem to fail with "Incorrect TXT record" more often than not.

The symptoms seem to be the sme with cloudfare: https://serverfault.com/questions/916427/traefik-k8s-lets-encrypt-wildcard-ssl-cloudflare-issue

I found a work around:
Instead of:
[[acme.domains]]
  main = "*.example.org"
  sans = ["example.org"]

I use:
[[acme.domains]]
  main = "*.example.org"

[[acme.domains]]
  main = "example.org"

Hello @retog,
Many thanks for your feedback.
It seems to be related to a problem when you ask ACME to generate DNS challenge for both wildcard certificate and its root domain as mentionned in the documentation.
The tests we made with GandiV5 have generated successfully the certificates but, it looks to be flacky.
The problem is about the TXT cache timeout in DNS providers: Let's Encrypt provides the same TXT record name for both the wildcard ad the root domain but if the cache is not clear between the challenges, ACME cannot get all the values.
Solving this weird issue, or trying to help LEGO team (LEGO is library we use to create ACME challenges) to solve it, is in our agenda

Additional to separating the domain names like @retog suggessted I only got it working with gandiv5 by setting delayBeforeCheck to at least 90s. Lower than that caused the error described above.

Hello @retog  , @ntnn .
Can you try the new Træfik release candidate (1.7-RC3) please?
Indeed, this RC contains the bugfix I made (#3675).
For information, I have discussed with Let's Encrypt developer about the problem in https://github.com/letsencrypt/boulder/issues/3572.

Closed by #3675


Viewing Score or Round information in ongoing live game

Is it possible to get the score or current round from an ongoing live game? I haven't been able to find it on the docs

Found it! Sorry!
https://github.com/igorwessel/valclient.js/blob/master/docs/Player/onlineFriend.md


Hide keys/tokens on metadata record

This is probably going to get flagged in security review so we should just do this now.

How would you hide them?

Done


[Enhancement] Unify Random Forest and Extra Trees preview algorithms

Description
This unifies Random Forest and Extra Trees to a single file from the same inheritance classes to match stock scikit-learn. This reduces overall code size, and prepares for movement out of preview. This improves preview RF to meet some of the standards of sklearnex in terms of testing and verbosity. It is still an open question whether to rename extra_trees.py to forest.py, though this would be temporary before the move out of preview.
Changes proposed in this pull request:

Fix TODO associated with estimator base_estimator and estimator_
add sklearn v1.4 monotonic_cst keyword and API input
move RF algos to extra_trees.py, rename to _forest.py (matches sklearn/daal4py naming convention)
remove forest.py
subtle reorder of patching_status to exactly match daal4py RF order
remove _onedal_model attribute and focus on _onedal_estimator instead
fix testing issue with test_min_samples_leaf for daal4py

@icfaust could you please also check what RF tests will enabled with this update?

@icfaust please move sklearnex/preview/ensemble/extra_trees.py → sklearnex/preview/ensemble/_forest.py

@icfaust please move sklearnex/preview/ensemble/extra_trees.py → sklearnex/preview/ensemble/_forest.py

See https://github.com/intel/scikit-learn-intelex/pull/1440/commits/c34283060d28752f8a1428aff4eaa3b81c317cec

@icfaust please move sklearnex/preview/ensemble/extra_trees.py → sklearnex/preview/ensemble/_forest.py

See c342830

Please be careful, it seems you moved to the root of the repository :)

NOTE: THIS PR IS NOW BREAKING TESTING BY THE LAST COMMIT ON PURPOSE AND MUST BE REVERTED BEFORE REVIEW.

/intelci: run

GPU testing with deselected_tests pullback http://intel-ci.intel.com/ee4d808d-89e0-f1d4-a9d7-a4bf010d0e2e

/intelci: run

/intelci: run

/intelci: run

/intelci: run

Pre commit with GPU testing with readded deselected_tests.yaml http://intel-ci.intel.com/ee527ce8-e814-f1b2-abb8-a4bf010d0e2e

Public CI is green.

Applicable deselections have been now reapplied. Testing restored.

Pre-commit issue is due to a bad mpi infra install in one case. It is unrelated to these changes, otherwise it is all green, including private CI nightly.

/intelci: run

Private nightly rerun with change http://intel-ci.intel.com/ee534500-d546-f1f5-9a78-a4bf010d0e2e

Private nightly rerun with change http://intel-ci.intel.com/ee534500-d546-f1f5-9a78-a4bf010d0e2e

This is green. There exists now a question about the RF spmd interface. @ethanglaser  @samir-nasibli, is there anything that preview might be doing to interact with the RF SPMD interface?

/intelci: run

New nightly run for spmd change: http://intel-ci.intel.com/ee539b0d-e065-f146-84b2-a4bf010d0e2e

New nightly run for spmd change: http://intel-ci.intel.com/ee539b0d-e065-f146-84b2-a4bf010d0e2e

Non-RF algos causing failures in this run.

New nightly run for spmd change: http://intel-ci.intel.com/ee539b0d-e065-f146-84b2-a4bf010d0e2e

Non-RF algos causing failures in this run.

I see no issues with this job (possibly something sporadic that could be resolved with a re-run.

@samir-nasibli @Alexsandruss @KulikovNikita Please review, thanks!

/intelci: run

/azp run CI

/intelci: run

http://intel-ci.intel.com/ee5c8a0d-cac9-f1b7-839d-a4bf010d0e2e private ci rerun for infra issues


[RFR] Dramatically simplified mui-animation

I was planning on doing this, thanks for doing it for me :)


Nested components?

If my markdown includes a component, then that component is rendered fine.
But, if that component itself includes a child component, then that child component is not rendered (just looks like a custom tag in the HTML).
Should this work? If it should work, I'll try to provide a repro.
Thanks for this component, it's awesome!

Happy to take a look :)

Nevermind - this turned out to be due to a separate error which I fixed. Nested components seem to be working fine.
Thanks again!

Great to hear! And thanks for giving me a coffee ✨


highlight search term in viewer by default

Descriptive Summary
When a user navigates to the show view for a NewspaperPage or NewspaperIssue object from a search results page, the user's keyword search term should be automatically be highlighted in the viewer when it loads.
The keyword search parameter will need to be passed from the index view to the show view.
The keyword search parameter will need to be passed to the viewer when it is constructed.
Rationale
This helps the user quickly find the relevant portion of the object.
Expected behavior
As a non-logged-in user
When I am on the home page
And I perform a keyword search
And I click on a Newspaper item in the search results
I should see the image displayed in the viewer
And I should see my search term highlighted in the viewer
So I can easily see where my search term appears in the item
Additional info
Examples of how keyword param is included in show view link:

Welsh Newspapers
UMD Student Newspapers

Michigan Daily appears to do this using session variables? (Click on search result link to see highlighting.)
This ticket will be complete when:
User story described above is functional.

Closed via #128.


✨  Add support for custom properties (homebrew)

I have a homebrew that has a couple of custom properties for items. I would like to include these in the template.
"itemProperty": [
    {
		"name": "Herb",
		"source": "HHbH",
		"page": 5,
		"abbreviation": "Hrb",
		"template": "{@b Location:} {{item.customProperties.lcn}} {@b Requires Preparation:} {{item.customProperties.prep}}",
		"entries": []
	}
]

Hamund's Herbalism Handbook
Here is an example of an item with these properties:
{
	"name": "Sentry Bush",
	"source": "HHbH",
	"page": 30,
	"type": "Herb",
	"rarity": "common",
	"value": 100,
	"property": [
		"Hrb"
	],
	"entries": [
		{
			"type": "entries",
			"name": "Description:",
			"entries": [
				"A scraggly brush found only on high altitudes, its bitter twigs produce an incredibly potent stimulant that when brewed into a tea, can completely replace one's need to sleep. Due to its inaccessible location, but widely sought-after use, mountain clans are often found carrying them in their caravan to trade to people that need to stay awake for long periods of time."
			]
		},
		{
			"type": "entries",
			"name": "Effect:",
			"entries": [
				"After preparing this herb, you gain all the benefits of 8 hours of sleep (or the equivalent form of dormancy for your race). You still need to rest for at least 8 hours in order to benefit from a long rest."
			]
		}
	],
	"customProperties": {
		"lcn": "Mountain",
		"prep": "Yes"
	},
	"foundryType": "consumable"
}

Hamund's Herbalism Handbook

Item properties are absolutely already taken into account provided they are in the right format in _meta

@ebullient the properties for "Location" and "Requires Preparation".

"customProperties": {
	"lcn": "Mountain",
	"prep": "Yes"
}

The lcn and prep keys.

ok. A different kind of custom properties. ;)
Herb is, in and of itself, a custom Item property.

Always item template usage?

Not necessarily, if you wanted a stress test try https://github.com/TheGiddyLimit/homebrew/blob/master/magicvariant/aeyana%3B Gemstones.json
Which includes customProperties mixed with itemEntry and variant generation.
Clock the hasRefs flag.

Basically this one '''item''' explodes to 46 items on the site

See video:
https://github.com/ebullient/ttrpg-convert-cli/assets/52298102/9a0a3e25-8329-413e-aeee-f88c3a14693b


python312Packages.art: 6.2 -> 6.3

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python312Packages.art is: ASCII art library for Python
meta.homepage for python312Packages.art is: https://github.com/sepandhaghighi/art
meta.changelog for python312Packages.art is: https://github.com/sepandhaghighi/art/blob/refs/tags/v6.3/CHANGELOG.md
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 6.3 with grep in /nix/store/3vwbjny4xwjazzgwb46n7d1s20y7gm2h-python3.12-art-6.3
found 6.3 in filename of file in /nix/store/3vwbjny4xwjazzgwb46n7d1s20y7gm2h-python3.12-art-6.3

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

4 package rebuild(s)

First fifty rebuilds by attrpath

browsr
python311Packages.art
python312Packages.art

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/3vwbjny4xwjazzgwb46n7d1s20y7gm2h-python3.12-art-6.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python312Packages.art https://github.com/r-ryantm/nixpkgs/archive/ae295afacac2930ecbb7a64ad5f5dcbbafa31aca.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/ae295afacac2930ecbb7a64ad5f5dcbbafa31aca#python312Packages.art

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/3vwbjny4xwjazzgwb46n7d1s20y7gm2h-python3.12-art-6.3
ls -la /nix/store/3vwbjny4xwjazzgwb46n7d1s20y7gm2h-python3.12-art-6.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages marked as broken and skipped:

browsr
browsr.dist

4 packages built:

python311Packages.art
python311Packages.art.dist
python312Packages.art
python312Packages.art.dist

Maintainer pings
cc @figsoda for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

@ofborg eval

Result of nixpkgs-review pr 343170 at 58f8d27e run on aarch64-darwin 1

:fast_forward: 1 package marked as broken and skipped:

browsr

:white_check_mark: 2 packages built:

python311Packages.art
python312Packages.art


"Adâncata", "Călugăreni" and "Fetești" villages are listed in the drop-down menu.

Description:
The villages are listed in the drop-down menu alongside its corresponding county and commune, according to the law
Preconditions : the website (https://peviitor-ro.github.io/ui.orase/) is up and runing. After every step delete the text you typed from the search bar.

Step 1
Write in the search bar "Adâncata".

Expected results
The location is listed in the drop-down menu as "Sat Adâncata **SUCEAVA ** (Adâncata)".

Step 2
Write in the search bar "Călugăreni".

Expected results
The location is listed in the drop-down menu as "Sat Călugăreni SUCEAVA (Adâncata)".


Content changes following 23 June show and tell

Description

change the under 18 and outside of UK pages
add example to work page hint text
add examples as hint text to immune system question
adjusted labels on check your answers page
adjust wording on the opt out journey

Checklist

[ ] Tested against our testing policy (Resolution, Browser & Accessibility)
[ ] CHANGELOG entry

WIP until the first round of user research sessions finish at the end of Wednesday 24th June


feat: Tourist Guide Section included

Title and Issue number
Title : Choose a Tourist Guide
Issue No. : #887
Close #887
Description
Information of tourist guide is added in the website where customers can easily contact them with contact details.
Video/Screenshots (mandatory)

Type of PR

[X] Feature enhancement

Checklist:

[X] I have performed a self-review of my code.

[X] I have commented my code, particularly in hard-to-understand areas.

[X] I have tested the changes thoroughly before submitting this pull request.

[X] I have provided relevant issue numbers, screenshots, and videos after making the changes.

[X] I have gone through the  contributing.md file before contributing

[X] I am contributing under GSSOC'24

I will review the changes and make a new PR


https://github.com/jlord/sheetsee.js/issues/26

Kkk

edited

[ ] #[ Duplicate of #](url)

@dxa4481


feat(status-tag): show user and date/time if approved

@mediremi after consulting the moment.js api docs, I've settled on the LLL string in . See moment.js Displaying/Format docs, section Localized formats.

Because preferred formatting differs based on locale, there are a few tokens that can be used to format a moment based on its locale.

Month name, day of month, year, time
LLL
September 4, 1986 8:30 PM


scrollspy with nested divs and hidden nav links

Prerequisites

[X] I have searched for duplicate or closed feature requests
[X] I have read the contributing guidelines

Proposal
Situation:
navigation:

c1

c2

c3

it could be splitted into 2 different navs - one for case 1 and one for case 2
elements to observe:

left or top content

right or bottom content

Motivation and context
on desktop, there will be shown some links targeting the "rows" due to the horizontal alignment of the cols.
on mobile, there will be shown some links targeting the "cols" due to their vertical alignment.
It doesn't make much sense to target the "rows" on mobile - their content may be too large for one anchor
Is it possible to achieve this with the given functionality of scrollspy?
if not, may it be a possible feature for a request?

This seems as much of a how-to question as it does a feature request, so I'm not sure how to proceed. I also don't have a clear idea of what you're asking for because there is no live demo or approximation of your request.
If you're willing and able to better explain, we can revisit.


merge 6 methods into 3 methods (I can create a PR)

Hi thanks for the assignment! There are 6 methods in Skeleton Kinematics. However, they are actually 3 pairs:

Joint::joint_to_bind vs Joint::joint_to_posed
Skeleton::end_of vs Skeleton::posed_end_of
Skeleton::joint_to_bind vs Skeleton::joint_to_posed

And the functionality are very similar for the two methods in one pair. Actually, IMHO, the only difference is whether to use joint->pose or treat pose as zero.
Thus, I propose that, we can happily merge each pair of 2 methods into 1 method with a bool argument. For example:
Mat4 Skeleton::joint_to_bind(const Joint* j) const {
    return Mat4::translate(base_pos) * j->joint_to_bind();
}
Mat4 Skeleton::joint_to_posed(const Joint* j) const {
    return Mat4::translate(base_pos) * j->joint_to_posed();
}

becomes
Mat4 Skeleton::joint_to_posed(const Joint* j, bool ignore_pose) const {
    return Mat4::translate(base_pos) * j->joint_to_posed(ignore_pose);
}

If welcomed, I can create a PR!

This would make the code a bit clearer, but I think we would rather students consider the bind pose and posed transformations as entirely separate coordinate frames. Although in Scotty3D bind pose means zero joint angles, in general the bind pose can be chosen as any particular joint arrangement.

Thanks for the explanation!