Implement caching structures, closes #36

Codecov Report

Merging #40 into master will increase coverage by 1.29%.
The diff coverage is 99.14%.

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
+ Coverage   92.46%   93.76%   +1.29%
==========================================
  Files           9       11       +2
  Lines         332      449     +117
==========================================
+ Hits          307      421     +114
- Misses         25       28       +3

Impacted Files
Coverage Δ

tests/spike/test_caching.cpp
100% <100%> (ø)

include/spike/caching.hpp
97.22% <97.22%> (ø)

include/spike/simple_service.hpp
95.83% <0%> (-4.17%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b89fb8a...7937d27. Read the comment docs.


[WIP] Further query optimization for Cassandra

(Work in progress, using PR to run tests in Travis because I'm lazy; please disregard debug outputs and the related statements).
- Query cleanup
- Support for braces (generate queries using possible values)
- Quick cleanup/refactoring

This change is

Review status: 0 of 4 files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.

biggraphite/glob_utils.py, line 422 at r1 (raw file):

        i = 0
        n = len(self._glob)

It's probably worth it to libify that at some point, it's crazy that there isn't something like that already. I wonder if it would have been possible to piggy back on fnmatch.translate()

biggraphite/drivers/cassandra.py, line 62 at r1 (raw file):

DEFAULT_TRACE = False
DEFAULT_BULKIMPORT = False
DEFAULT_MAX_QUERIES_PER_PATTERN = 32

Isn't that pretty low if we expand by default ?

biggraphite/drivers/cassandra.py, line 842 at r1 (raw file):

        metric_names = []
        try:
            for query in queries:

we probably want an "execute_concurrent" here (carefully limiting the amount of queries)

Comments from Reviewable

Looks good, I'm starting to think that we should split this file in two, (cassandra_metadata.py and cassandra_data.py) at some point.
Thanks !

Review status: 0 of 4 files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.

Comments from Reviewable

Thanks. I will fix the styling issues, then we should be happy with #169 for the moment :D

Review status: 0 of 4 files reviewed at latest revision, 3 unresolved discussions.

biggraphite/glob_utils.py, line 422 at r1 (raw file):
Previously, iksaif (Corentin Chary) wrote…
> It's probably worth it to libify that at some point, it's crazy that there isn't something like that already. I wonder if it would have been possible to piggy back on fnmatch.translate()

I do not really get what you mean here. fnmatch.translate() only generates regexes, it does not parse the pattern into an abstract representation. If you look at the glob to regex function in this file you will actually see a modified version of the original fnmatch.translate :-)

biggraphite/drivers/cassandra.py, line 62 at r1 (raw file):
Previously, iksaif (Corentin Chary) wrote…
> Isn't that pretty low if we expand by default ?

My code is able to reduce the number of combinations generated to avoid generating too many requests; so I kept the previous value as a reasonable one. But if feel comfortable with a larger default count (64?) for max queries, I will go ahead and bump this value!

biggraphite/drivers/cassandra.py, line 842 at r1 (raw file):
Previously, iksaif (Corentin Chary) wrote…
> we probably want an "execute_concurrent" here (carefully limiting the amount of queries)

The limitation is why I have not been using concurrent for now. We could maybe run sequential batches of 2-5 concurrent requests? If we agree on that, I will implement it.

Comments from Reviewable

Review status: 0 of 4 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

biggraphite/drivers/cassandra.py, line 62 at r1 (raw file):
Previously, dpanth3r (Dan Forest) wrote…
> My code is able to reduce the number of combinations generated to avoid generating too many requests; so I kept the previous value as a reasonable one. But if feel comfortable with a larger default count (64?) for max queries, I will go ahead and bump this value!

It's unclear to me what queries will be generated exactly for typical queries, so it's hard to have a good idea of what is a good number of maximum queries. I guess we need to do some tests to tweak that later.

biggraphite/drivers/cassandra.py, line 842 at r1 (raw file):
Previously, dpanth3r (Dan Forest) wrote…
> The limitation is why I have not been using concurrent for now. We could maybe run sequential batches of 2-5 concurrent requests? If we agree on that, I will implement it.

execute_concurrent can take the number of concurrent queries to run in parallel as a parameter. I'd limit that to 6 or less.

Comments from Reviewable

Review status: 0 of 4 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

Comments from Reviewable

Found a bug:
$ bgutil --loglevel=DEBUG list 'a.{par,am5}.test.{cassandra,memcached}..'
2016-11-20 12:38:05,290 [DEBUG] biggraphite.drivers.cassandra: SELECT name FROM "biggraphite_metadata"."directories" WHERE component_0 = 'a' AND component_1 = 'am5' AND component_2 = 'test' AND component_3 = 'cassandra' AND component_6 = 'END' LIMIT 5001 ALLOW FILTERING;
2016-11-20 12:38:07,176 [DEBUG] biggraphite.drivers.cassandra: SELECT name FROM "biggraphite_metadata"."directories" WHERE component_0 = 'a' AND component_1 = 'am5' AND component_2 = 'test' AND component_3 = 'memcached' AND component_6 = 'END' LIMIT 5001 ALLOW FILTERING;
2016-11-20 12:38:08,226 [DEBUG] biggraphite.drivers.cassandra: SELECT name FROM "biggraphite_metadata"."directories" WHERE component_0 = 'a' AND component_1 = 'par' AND component_2 = 'test' AND component_3 = 'cassandra' AND component_6 = 'END' LIMIT 5001 ALLOW FILTERING;
2016-11-20 12:38:08,254 [DEBUG] biggraphite.drivers.cassandra: SELECT name FROM "biggraphite_metadata"."directories" WHERE component_0 = 'a' AND component_1 = 'par' AND component_2 = 'test' AND component_3 = 'memcached' AND component_6 = 'END' LIMIT 5001 ALLOW FILTERING;
2016-11-20 12:38:08,282 [DEBUG] biggraphite.drivers.cassandra: SELECT name FROM "biggraphite_metadata"."metrics" WHERE component_0 = 'a' AND component_1 = 'am5' AND component_2 = 'test' AND component_3 = 'cassandra' AND component_6 = 'END' LIMIT 5001 ALLOW FILTERING;
2016-11-20 12:38:08,325 [DEBUG] biggraphite.drivers.cassandra: SELECT name FROM "biggraphite_metadata"."metrics" WHERE component_0 = 'a' AND component_1 = 'am5' AND component_2 = 'test' AND component_3 = 'memcached' AND component_6 = 'END' LIMIT 5001 ALLOW FILTERING;
2016-11-20 12:38:08,368 [DEBUG] biggraphite.drivers.cassandra: SELECT name FROM "biggraphite_metadata"."metrics" WHERE component_0 = 'a' AND component_1 = 'par' AND component_2 = 'test' AND component_3 = 'cassandra' AND component_6 = 'END' LIMIT 5001 ALLOW FILTERING;
2016-11-20 12:38:08,403 [DEBUG] biggraphite.drivers.cassandra: SELECT name FROM "biggraphite_metadata"."metrics" WHERE component_0 = 'a' AND component_1 = 'par' AND component_2 = 'test' AND component_3 = 'memcached' AND component_6 = 'END' LIMIT 5001 ALLOW FILTERING;
2016-11-20 12:38:08,426 [DEBUG] biggraphite.drivers._delayed_writer: rebuilt the queues: 0 metrics, 0 per second

Review status: 0 of 4 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

Comments from Reviewable

forget that, not a bug, just not super efficient, but not a regression

Review status: 0 of 4 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

Comments from Reviewable

I am adding concurrent request execution to the code, and then we should be on our way to the merge :-)


Google Colab MobilenetSSD training does not use GPU

I attempted to use this notebook, https://github.com/luxonis/depthai-ml-training/blob/master/colab-notebooks/Easy_Object_Detection_With_Custom_Data_Demo_Training.ipynb, to train a model on and received the following error.
I attempted to clear all outputs, disconnect and clear out my session and tried again but with the same results when I get down to starting the training. Is there a library that should be loaded that is being skipped or a work around.
2022-11-23 20:13:47.476326: W tensorflow/stream_executor/platform/default/dso_loader.cc:55] Could not load dynamic library 'libcudart.so.10.0'; dlerror: libcudart.so.10.0: cannot open shared object file: No such file or directory; LD_LIBRARY_PATH: /usr/lib64-nvidia 2022-11-23 20:13:47.476531: W tensorflow/stream_executor/platform/default/dso_loader.cc:55] Could not load dynamic library 'libcublas.so.10.0'; dlerror: libcublas.so.10.0: cannot open shared object file: No such file or directory; LD_LIBRARY_PATH: /usr/lib64-nvidia 2022-11-23 20:13:47.476670: W tensorflow/stream_executor/platform/default/dso_loader.cc:55] Could not load dynamic library 'libcufft.so.10.0'; dlerror: libcufft.so.10.0: cannot open shared object file: No such file or directory; LD_LIBRARY_PATH: /usr/lib64-nvidia 2022-11-23 20:13:47.476810: W tensorflow/stream_executor/platform/default/dso_loader.cc:55] Could not load dynamic library 'libcurand.so.10.0'; dlerror: libcurand.so.10.0: cannot open shared object file: No such file or directory; LD_LIBRARY_PATH: /usr/lib64-nvidia 2022-11-23 20:13:47.476941: W tensorflow/stream_executor/platform/default/dso_loader.cc:55] Could not load dynamic library 'libcusolver.so.10.0'; dlerror: libcusolver.so.10.0: cannot open shared object file: No such file or directory; LD_LIBRARY_PATH: /usr/lib64-nvidia 2022-11-23 20:13:47.477072: W tensorflow/stream_executor/platform/default/dso_loader.cc:55] Could not load dynamic library 'libcusparse.so.10.0'; dlerror: libcusparse.so.10.0: cannot open shared object file: No such file or directory; LD_LIBRARY_PATH: /usr/lib64-nvidia 2022-11-23 20:13:47.477231: W tensorflow/stream_executor/platform/default/dso_loader.cc:55] Could not load dynamic library 'libcudnn.so.7'; dlerror: libcudnn.so.7: cannot open shared object file: No such file or directory; LD_LIBRARY_PATH: /usr/lib64-nvidia 2022-11-23 20:13:47.477251: W tensorflow/core/common_runtime/gpu/gpu_device.cc:1641] Cannot dlopen some GPU libraries. Please make sure the missing libraries mentioned above are installed properly if you would like to use GPU. Follow the guide at https://www.tensorflow.org/install/gpu for how to download and setup the required libraries for your platform. Skipping registering GPU devices...

CC @HonzaCuhel can you look into that please. My guess is there was some hidden upgrade again and some libraries got messed up :)
@dhartness If you don't have a particular reason to stick with the above tutorial, I would suggest you to check out our YoloV6n training tutorial in the meantime. It is newer than MobileNet SSD Lite and should provide you the best accuracy/speed trade-off on our cameras. Export process should also be easier.

@tersekmatija Thank you for the pointer on your YoloV6 training notebook! I'll give it a try!

Hi!
Using the training data I used on my last MobilenetSSD, after running it through RoboFlow, I have trained models in both YOLOv6n and YOLOv7-tiny but they're giving abysmal results compared to MobilenetSSD.
Do you have any pointers on generating a cleaner YOLO model? A lot of my detection conditions are objects in mass flow which I see YOLO is weak against.
This is my YOLOv6 model's performance:

While this is my MSSD model's performance:

Hi!
Using the training data I used on my last MobilenetSSD, after running it through RoboFlow, I have trained models in both YOLOv6n and YOLOv7-tiny but they're giving abysmal results compared to MobilenetSSD.
Do you have any pointers on generating a cleaner YOLO model? A lot of my detection conditions are objects in mass flow which I see YOLO is weak against.
This is my YOLOv6 model's performance:

While this is my MSSD model's performance:


chore: add conda env caching

Related Issues/PRs

#xxx
What changes are proposed in this pull request?
Briefly describe the changes included in this Pull Request.
How is this patch tested?

[ ] I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change any dependencies?

[ ] No. You can skip this section.
[ ] Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

[ ] No. You can skip this section.
[ ] Yes. Make sure you have added samples following below steps.

Find the corresponding markdown file for your new feature in website/docs/documentation folder.
Make sure you choose the correct class estimators/transformers and namespace.
Follow the pattern in markdown file and add another section for your new API, including pyspark, scala (and .NET potentially) samples.
Make sure the DocTable points to correct API link.
Navigate to website folder, and run yarn run start to make sure the website renders correctly.
Don't forget to add <!--pytest-codeblocks:cont--> before each python code blocks to enable auto-tests for python samples.
Make sure the WebsiteSamplesTests job pass in the pipeline.

/azp run

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 42.58%. Comparing base (d789b02) to head (26f6b2f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2207      +/-   ##
==========================================
- Coverage   47.34%   42.58%   -4.77%
==========================================
  Files         327      327
  Lines       16705    16705
  Branches     1501     1501
==========================================
- Hits         7909     7113     -796
- Misses       8796     9592     +796

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Is there a way to add this connection to search-object-graphql?

Hi - Docs give example of use with elasticsearch-chewy.
Is it possible to use this gem with RStankov's search object graphql?
I've tried, but I'm getting every query ordered by :id

I think it is impossible. But if you find out the possibility, I would be grateful to receive a pull request implementing the integration.

Hi Misha, I'm working on it. So far:
I can pass database-agnostic query operators to the wrapper...
For example, instead of
GraphQL::Connections::Stable.new(Message.all)

i pass
GraphQL::Connections::Stable.new(Message.where name: value)

It's ok. But when i need to use an SQL string, like this:
GraphQL::Connections::Stable.new(Message.where("name LIKE ?", escape_search_term(value)))

obviously this fails, the problem is the SQL string literal. However, I'm thinking I should be able to rephrase this string in a database-agnostic way with arel_table.
I will edit this reply when I make some progress, I believe this should work.


Able to attempt a submission for an emissions file with no window

On the Submit screen, users are able to select an emissions file for submittal when there is not a submission window associated with that quarter.
The Submission Window column displays "None". In this situation, the record should not be selectable.
This row should not be selectable and the user should not be able to continue with Sign & Submit.

submission_availability_cd
sub_avail_cd_description

CRITERR
Submitted with Critical Errors

DELETE
Deletion Approved

GRANTED
Permission to Resubmit Granted

NOTSUB
Did Not Submit

PENDING
Submitted, Host Update Pending

PENDUP
Updated on Client following Submission, Host Update Pending

REQUIRE
Resubmission Required

RESYNC
Resynchronization Required

UPDATED
Updated on Host

When attempting to submit an EM file with Critical Errors with no submission window, tester is rightly unable to select the file for submission.

Tester is unable to submit an EM file without Critical Errors either.

Check out 2516, UGT001 and revert to official.
Export "original" MP and reimport it along with this EM file.
Evaluate the MP and 2023 Q4 EM file (there will be critical errors for both; MP is missing a qualification which will cascade to EM evaluation).
Go to Submit module and select the Include Files with Critical Errors option.
Tester is able to select the MP for submission, but not the EM.
Revert to official.
Import this MP (includes missing qualification) and the 2023 Q4 EM file again.
Evaluate both (no critical errors should be returned).
Go to Submit module and leave the default Exclude Files with Critical Errors option.
Tester is able to select the MP for submission, but not the EM.

2516_UGT001_MP.json
2516_UGT001_EM_2023Q4.json

Verified in test for ORIS 470, Location 1: imported 2022 Q4 data from historical, evaluated, and output a Eval Status of "Critical Errors." When I searched for this configuration in the Submit module, it was not available in the Emissions section.


pacman uninstall hook missed kernel with prefix

when uninstalling a kernel, the efi-var can't be found:
# mhwd-kernel -r linux67                                                                                 ✔
...
:: Pre-transaction-Hooks werden gestartet …
(1/3) Removing linux initcpios...
(2/3) Updating EFI variables (remove)...
Can't find the builduser kernel in the EFI variables...
...

if i read the source correctly, "builduser" should be the name of the kernel to be removed?

for successful kernel uninstall, i added 2 parts in main.sh:_remove_efi_hook:
after _strings="${_strings%%/*}" added:
		local _version_backup
		_version_backup="$(echo "$_strings" | cut -d "." -f 1,2)"

and after _final="${_final#(}" added:
		if [ "$_final" == "builduser" ]; then
			_final="${_version_backup}-$(uname -m)"
		fi

i'm unsure thats going wrong, but it looks like the kernel doesn't contain the expected string


Feature Request: Read API key (application_secret) from an environment variable

It would like to set application_secret provider config via an environment variable. The docs already make use of CRUNCHY_API_KEY in the examples.
Terraform variables and TF_VAR_* environment variables can be used as a workaround.

The doc you referenced is for the Crunchy Bridge API and are referring to how someone might set an environment variable to be compatible with the curl examples used to demonstrate direct use of the API. Those examples don't really influence the function of the Terraform provider. (Some of the Terraform-specific documentation has been duplicated in the Crunchy Bridge documentation for visibility, but the Terraform registry contains the complete documentation for the provider)
As far as I'm aware, using TF_VAR_* approach isn't a workaround, it is the built-in mechanism in Terraform for configuring via the environment. It saves unnecessary duplication of custom-implementing environment variable reads on a per-provider basis and also avoids having to establish precedence rules resolving conflicts between the built-in TF_VAR mechanism and a provider custom one.
So that I can understand your use case better - what benefit are you hoping to achieve with a parallel and seemingly redundant implementation of environment variable reads?


Documentation or example on how to do mutations

I'm trying to learn how to execute mutations with graphqelm and it turned out pretty hard to figure out without some simple example or documentation. Can anyone add it, please? Probably it's something obvious for someone experienced with Elm, but I found it frustrating.

Hello @youroff, I appreciate the constructive suggestion! It's great to know what trips people up so I can improve the experience of learning about this library.
I added an example under examples/src/SimpleMutation.elm. You can also see some basic docs for the associated functions if that's helpful, like http://package.elm-lang.org/packages/dillonkearns/graphqelm/11.2.0/Graphqelm-Http#mutationRequest.
I hope that helps. Let me know if there's anything else that is confusing. Thanks!

And just to explain what's going on a bit, the way you do mutations is exactly the same except that the type of the base request is Graphqelm.Operation.RootMutation instead of Graphqelm.Operation.RootQuery, and you use Graphqelm.Http.mutationRequest instead of Graphqelm.Http.queryRequest. You can the SimpleMutation.elm example to the Starwars.elm example and see these differences. Otherwise everything else is the same. Cheers!

Thank you, @dillonkearns! I think I advanced a bit further, but still stuck, cause simple mutation doesn't involve use of arguments or input objects. Here's what I'm trying to do:
-- I have this mutation generated
tokenCreate : TokenCreateRequiredArguments -> SelectionSet decodesTo Api.Object.Token -> Field (Maybe decodesTo) RootMutation
tokenCreate requiredArgs object =
    Object.selectionField "tokenCreate" [ Argument.required "email" requiredArgs.email Encode.string, Argument.required "password" requiredArgs.password Encode.string, Argument.required "role" requiredArgs.role (Encode.enum Api.Enum.Role.toString) ] object (identity >> Decode.nullable)

I used TokenCreateRequiredArguments type for form model (as type alias), so basically it's what comes to mutation function:
mutation : LoginModel -> SelectionSet Token RootMutation
mutation model =
    Mutation.selection Token
        |> with (Mutation.tokenCreate model _???_)

So I'm not sure what should I pass as a second argument, that has a signature SelectionSet decodesTo Api.Object.Token. The problem is that this is basically first thing with side effects that I'm trying to do with Elm, so I'm very sorry if this sounds dumb. In general what would be perfect for the beginners like me is a kind of write-up describing architecture and flow such as what function does what etc.

Hey @youroff, I'm glad you figured it out! Let me know if you write a blog post, I can link to it on the Readme. I am also working on a gitbook here https://legacy.gitbook.com/book/dillonkearns/elm-graphql/detail. But I think details like this would be outside the scope of the main docs because they see more Elm fundamentals rather than grapghqelm-specific knowledge.
There are lots of friendly people willing to provide help any time in the elm-lang slack in #beginners and #graqhql, as well. I highly recommend checking that out. Cheers!

@youroff I'm in the exact position you were when you created this issue (hence this comment and not just a 👍 ). I'd love to see your write-up, or a link to any relevant elm-slack discussion. @dillonkearns Thanks for all your work!

@tennety I didn't do that yet and later had to switch to the other project for a while, but @dillonkearns's gitbook is actually a pretty good place to learn about SelectionSets, this is what I was struggling with mostly. If you want, I can create a gist with what I ended up with.

Cool, thanks both! Reading the book now (I had some issues accessing it before). I realized that the second argument to the mutation needed to be the fields I needed in the response, so I'm a little further along :)


Add knit task

Expand list of tasks so that documents kan be rendered in a fresh session using tasks. Reference: https://github.com/Ikuyadeu/vscode-R/issues/59#issuecomment-813690674.
Open an .Rmd file, run the "R: Knit" task.
I wonder:

How can we expand the task so that the rendered document is opened upon completion? Should we add an rstudioapi::xxx() call to the command line?
Do we need "Knit as HTML", "Knit as PDF", "Knit all"?
Should we eventually remap the Ctrl + Shift + K shortcut to this task

and enable it also for .R files
and also remap other shortcuts?

thought as an often emacs org-mode ESS (emacs speaks statistics) user and sometime rstudio user who would love to jump to VSC when possible:
"Knit to xxx" is good
"Knit All" is good and should knit to all formats in YAML header, of html if none.
Ctrl + Shift + K is what RStudio uses and is good unless otherwise claimed.
The YAML header of an rmarkdown document can specify one of more formats to which the document is expected to be knit, but a call to knit  can override.

In RStudio IDE, the knit button (ctrl+shift+K) behaves differently depending on how you define knit  field within the YAML frontmatter of your document.
This has been described in Customize the Knit button.
For example, the following calls bookdown::render_book() instead of the default rmarkdown::render():
index.Rmd:
---
title: Bookdown Rmd
knit: "bookdown::render_book"
output: bookdown::gitbook
---

It would be ideal if the knit task could pick up the knit metadata field within current document yaml frontmatter, and use the defined render function towards the opened file as in RStudio IDE.

@krlmlr Thanks for this PR! I'm happy to review it whenever you'd like. Adding knit HTML/PDF/all variations might be worthwhile now as they should be straightforward. You're welcome to take on other features like automatically opening the knitted document but it seems like it might be easiest to merge the basic features now and add on the more involved features in subsequent PRs.

@krlmlr,
Can I just double check what you were trying to achieve here. The current Ctrl + Shift + K shortcut already runs the Rmd in a fresh R session. I'm just wondering what the benefit of mapping it over to tasks instead would be.
To @jooyoungseo's point it also looks like the existing knit all / Ctrl + Shift + K also respects the knit frontmatter

Theres also quite a bit of chat here around different potential features we could implement is it worth extracting these to separate issues ? I would propose closing this PR considering its now outdated/incompatible with the current changes to tasks.ts.  I started putting together a new version that is compatible with the new changes but am unsure now of its value given what I've put above. @renkun-ken  any opinions ?

@gowerc I believe the customizable knit (at least my suggestion) has already been addressed in the latest version, so this is somewhat outdated.


fix/typo in process checklist

Description
Fix a typo in the Responsibility Process checklist
Motivation and Context
Type of Change
How to Test
Checklist
Please check all the boxes that apply to this pull request using "x":

[x]  I have tested the changes locally and verified that they work as expected.
[ ]  I have added or updated the necessary documentation (README, API docs, etc.).
[ ]  I have added appropriate unit tests or functional tests for the changes made.
[ ]  I have followed the project's coding conventions and style guidelines.
[ ]  I have rebased my branch onto the latest commit of the main branch.
[ ]  I have squashed or reorganized my commits into logical units.
[ ]  I have added any necessary dependencies or packages to the project's build configuration.
[x]  I have performed a self-review of my own code.

Screenshots (if applicable)
[If the changes involve visual modifications, include screenshots or GIFs that demonstrate the changes.]
Additional Notes
[Add any additional information or context that might be relevant to reviewers.]

noted on the change. would clone the dev repo and produce the zip file.


New gripper vasu3/20

This needs to be merged. Vasu's rollback caused the arm controls to swap which Justin then pressed detonating the arm

like merged now


Install Guide

How do i get this to work?
I have absolutely no idea.
Can somebody help me?

Maybe this will help: https://ritualmotion.com/rmguild/sessions/using-league-broadcast-to-level-up-your-stream/


Add support for custom s3 backend

Add support for custom s3 backend
Signed-off-by: loheagn<EMAIL_ADDRESS>

After this PR, please check the availability of an s3 bucket backend if the custom backend is s3.
Initializing the backend...
╷
│ Error: Failed to get existing workspaces: S3 bucket does not exist.
│
│ The referenced S3 bucket must have been previously created. If the S3 bucket
│ was created within the last minute, please wait for a minute or two and try
│ again.
│
│ Error: NoSuchBucket: The specified bucket does not exist
│ 	status code: 404, request id: S9C2NVQYSP3XJ5MG, host id: Svektctl/II5gmMzahsJB4qYctlDVwNDmjbZB30mjA3M+p9hHE1WCynj4BBpf+VS21Ryohi8Ynw=
│
│
│

I ran the example and I updated the region of the backend bucket to us-east-1, but the terraform init container kept poping the message as below.
➜  ~ k logs -f aws-s3-apply-vhq8z -c terraform-init

Initializing the backend...
Error refreshing state: BucketRegionError: incorrect region, the bucket is not in 'ap-southeast-1' region at endpoint ''
	status code: 301, request id: , host id:

I ran a clear configuration with the right region, it said.
➜  ~ k logs -f aws-s3-apply-2n9d5 -c terraform-init

Initializing the backend...
Error refreshing state: AccessDenied: Access Denied
	status code: 403, request id: 4RT2V6E7SN1E8VP1, host id: w6P16SqXQjGZr21xnutTw07YbFM8DgXg67A5yJyQPsxGGj56i6Pp8ES1HIgUrCPBSyf/PrSkbrY=

What should I have missed for configuring the backend state?

I ran a clear configuration with the right region, it said.
➜  ~ k logs -f aws-s3-apply-2n9d5 -c terraform-init

Initializing the backend...
Error refreshing state: AccessDenied: Access Denied
	status code: 403, request id: 4RT2V6E7SN1E8VP1, host id: w6P16SqXQjGZr21xnutTw07YbFM8DgXg67A5yJyQPsxGGj56i6Pp8ES1HIgUrCPBSyf/PrSkbrY=

What should I have missed for configuring the backend state?

@zzxwill Do you use the same bucket in the example? I think you may need to use another bucket that you have access to.

I ran a clear configuration with the right region, it said.
➜  ~ k logs -f aws-s3-apply-2n9d5 -c terraform-init

Initializing the backend...
Error refreshing state: AccessDenied: Access Denied
	status code: 403, request id: 4RT2V6E7SN1E8VP1, host id: w6P16SqXQjGZr21xnutTw07YbFM8DgXg67A5yJyQPsxGGj56i6Pp8ES1HIgUrCPBSyf/PrSkbrY=

What should I have missed for configuring the backend state?

@zzxwill Do you use the same bucket in the example? I think you may need to use another bucket that you have access to.

I used my own.

I ran a clear configuration with the right region, it said.
➜  ~ k logs -f aws-s3-apply-2n9d5 -c terraform-init

Initializing the backend...
Error refreshing state: AccessDenied: Access Denied
	status code: 403, request id: 4RT2V6E7SN1E8VP1, host id: w6P16SqXQjGZr21xnutTw07YbFM8DgXg67A5yJyQPsxGGj56i6Pp8ES1HIgUrCPBSyf/PrSkbrY=

What should I have missed for configuring the backend state?

@zzxwill Do you use the same bucket in the example? I think you may need to use another bucket that you have access to.

I used my own.

I'll check out the bug and fix it.


Api order status error causes crash (on CEXio)

PgetOrder error: Invalid Order ID
/home/tradeops/zenbot/lib/engine.js:298
order.status = api_order.status
^
TypeError: Cannot read property 'status' of undefined
at /home/tradeops/zenbot/lib/engine.js:298:40
at /home/tradeops/zenbot/extensions/exchanges/cexio/exchange.js:181:9
at Request.request [as _callback] (/home/tradeops/zenbot/node_modules/cexio-api-node/rest.js:72:16)
at Request.self.callback (/home/tradeops/zenbot/node_modules/cexio-api-node/node_modules/request/request.js:186:22)
at emitTwo (events.js:126:13)
at Request.emit (events.js:214:7)
at Request. (/home/tradeops/zenbot/node_modules/cexio-api-node/node_modules/request/request.js:1163:10)
at emitOne (events.js:116:13)
at Request.emit (events.js:211:7)
at IncomingMessage. (/home/tradeops/zenbot/node_modules/cexio-api-node/node_modules/request/request.js:1085:12)
at Object.onceWrapper (events.js:313:30)
at emitNone (events.js:111:20)
at IncomingMessage.emit (events.js:208:7)
at endReadableNT (_stream_readable.js:1056:12)
at _combinedTickCallback (internal/process/next_tick.js:138:11)
at process._tickCallback (internal/process/next_tick.js:180:9
System information

Have I written custom code (as opposed to using zenbot vanilla):
**OS Platform and Distribution : Ubuntu 16.04
Zenbot version: latest
NodeJS version: 8.9.1
Python version:
Exact command to reproduce: any trading on cexio

Exchange API responce seems to be not always correct. A patch is welcome whitch will prevent bot from crash in case of incorrect api responce

I had the same issue, apparently(in my case at least) it's caused when you activate 2FA before activating the API. Try disabling 2FA then activate the API key and try again(don't forget to reactivate 2FA when you're done). That was the solution given to me by CEX support and it fixed all my CEX API issues

No, this is not the case, my api key is already activated.

Pushed PR #956 which fixes #931

Looks so nice and stable after PR.


libopae: add enum fpga region and resources

@ibarraza I think the idea was to specify a size large enough to make memcpy_s fail; however, after looking at safe_string.h, RSIZE_MAX_MEM is actually 256MiB.  So, 65K isn't large enough.  The fn also attempts to malloc a buffer of that size, which could account for the variance in behavior between runs.  Maybe we should update this code so that we only accept up to some internal max for bitstream size?


JAVA-1257: Implement a customizable StatementFormatter.

Note to reviewers:

The core functionality is in StatementFormatter. It is only new code and should not introduce regressions in any way.
This PR also introduces EnhancedQueryLogger, an equivalent to QueryLogger where the formatting tasks are delegated to StatementFormatter.
This PR also refactors Statement.toString(). I see a huge advantage in having a common system to print statements. The problem is that it was implicitly assumed so far that toString() would print the query string, but that assumption is now broken. Users willing to retrieve the query string should always call getQueryString(). I updated the upgrade guide accordingly.

Sorry but this looks really complicated... Printing statements in the logs is a simple problem, I don't think it should require 6 new types.

I think we should step back and reconsider what we're trying to solve here. What are the things that a user could reasonably expect from the logger and are currently not possible?
We should provide a generic format that's reasonable for most users, not necessarily make everything configurable; e.g. if someone wants to use a different separator than ,, then it's probably time to write their own logger (we need to make sure that it's possible, iirc the logger uses some package-private APIs so we need a way to expose them).

Printing statements in the logs is a simple problem, I don't think it should require 6 new types.

Not so simple as that imo, if you also want to protected your code against huge statements (long query strings, tons of bound values etc.) and a the same time make the printing customizable to some extent.

Yeah it sucks; but without them, QueryLogger cannot benefit from StatementFormatter. If that's that bad, then let's simply let QueryLogger out of this PR. The workaround in this case is to create another query logger, let's call it EnhancedQueryLogger and deprecate the old one.

What are the things a user could reasonably expect from the logger and are currently not possible?

Here are a few ones:

Bound statements do not print their values (see JAVA-1256);
We currently do not print consistency level (see JAVA-1340);
Users cannot log custom statements (see JAVA-1273).

We should provide a generic format that's reasonable for most users, not necessarily make everything configurable

Here I agree, you have a point. We might not need so many configurable settings, I will give a try today and simplify these parts to the bare minimum.

My two last commits address feedback received so far:

Revert changes to QueryLogger to avoid binary braking changes;
Simplify StatementFormatter (get rid of some configurable settings to make the API less verbose)

Addressed feedback + rebased.

Squashed commits and rebased on top of current 3.x.

Squashed commits and rebased on top of current 3.x.

In the future can you hold off on squashing until the review is complete?   It is hard to understand what the recent changes are since last reviewed otherwise (unless there is an easy way to do it, my git fu can be lacking :D).

In the future can you hold off on squashing until the review is complete?

Oh I'm so sorry :( I should have waited indeed.

Note to reviewers: I push one commit (ea22959) that proposes to reduce the verbosity of printed statements by abbreviating common terms such as "CL" (consistency level) or "IDP" (for idempotence). I can revert if you think it is not desirable.

I was trying to sum up what are the needs for the different tickets that would be resolved by this PR. So, aside form the tickets that we can resolve simply without the StatementFormatter there's the ticket about bringing a customizable way to print statements.
So on the topic of providing a customizable way to print statements there seems to be 2 cases:

Printing a custom user-defined statement configurably.
Be able to configure the way the driver prints the built-in statement classes.

For 1), I believe users are in control of the class they implement, hence there is no more straightforward way, to print their own way their statement, than to just override Statement#toString(). I am trying to find what would be the advantage in usability to force the user to configure the QueryLogger + create a custom StatementFormatter + potentially a custom StatementPrinter + registering their Statement class in the StatementFormatter/registry, VS just overriding toString(). It seems like the StatementFormatter solution doesn't bring more usability from what I can see, but involves a much more complex knowledge required to do just a specialized formatting, plus overriding toString() when you want some custom formatting would seem rather natural I think for users. Also, if they override toString() they can benefit of the nice formatting, not just only in the QueryLogger, but in their application and in other places. All considering the QueryLogger calls toString() on statements when logging. One argument would be the re-usability of a StatementPrinter for different Statement classes (you register the same printer for several statement classes), but I'll get to that a little further down.
For 2), instead of having to understand what the QueryLogger, StatementFormatter, etc.. classes are for, they could just extend the driver Statement class, and override toString() as well.
Now I get that printing a Statement can be tricky as you mentioned before, the size of the query, all the different options the driver has (CL, tracing, etc..), the number of bound values, and so on. Hence I think the StatementPrinter(and StatementWriter) classes are useful, but do not necessarily need to be used via the StatementFormatter/PrinterRegistry/etc.. How about we would provide the StatementPrinter classes as standalone, so that users would be free to use them/expand them in Statement#toString() if they decide to override them. And the users would be free to reuse the same StatementPrinters in different Statement classes, and so on. And the driver uses the built-in printers in the default toString methods.
In terms of internal details/performance, that's more minor but I think using a Registry, and doing a look up of a Printer by taking the class of a given Statement class, is convoluted instead of just calling #toString().
Wdyt?

Let's not forget that the only practical way to create custom statements is to extend StatementWrapper (extending SimpleStatement should work too but I never tried). But unfortunately, StatementWrapper.toString() will never be called because of this line.
So the toString() solution is not always applicable.
But to be honest, the more it goes the less I like this PR for the same reasons as you, so I'm starting to agree that this shouldn't be merged.

I took a little look at the line you mentioned, sounds indeed like we need to unwrap the statement, because later on in logQuery there's some logic regarding the kind of Statement that needs to be logged, right? But if we keep that logic in specific StatementPrinters inside toString() of the Statement implementations, I think we don't need to do a case by case in logQuery. So the unwrapping can be removed in the QueryLogger, and StatementWrapper#toString just calls by default wrapper.toString(). That's a little like what's happening in EnhancedQueryLogger which currently delegates the formatting to StatementFormatter but here instead we'd just call statement.toString().


BC-13 # implement bm bmp create interaction ...

Added

BC-13: able to create interactions via CLI with no actions within CMS (#10, @jokeyrhyme)

all interactions created this way have "display" set to "hide" to minimise visible impact to BIC end-users (avoids unfinished interactions showing up in generated lists)

blinkm bmp create interaction <name>  creates a new hidden+active interaction locally

--type=<type> where type can be "madl" (default), or "message"

--remote immediately create a remote placeholder

Code Review Notes

ignore / skip the BC-10 commits, they'll be rebased out

it's probably easier to step through the refactoring commits one by one

lgtm :+1:


3D Sum Error on Latest Main

When running this code we get an error on latest main, while it used to work a few weeks/months back
python: /triton/triton/lib/Analysis/Utility.cpp:62: unsigned int mlir::ReduceOpHelper::getThreadOffsetOnReductionAxis(): Assertion `threadsPerWarp.size() == 2 && "Only supports 2D layouts"' failed.
Aborted (core dumped)

Code
import torch
import triton
import triton.language as tl

@triton.jit
def func(
    x_ptr,
    y_ptr,
    stride,  # how much to increase the pointer when moving by 1 row
    BLOCK_SIZE: tl.constexpr,
):
    row_offsets = tl.program_id(0) * BLOCK_SIZE + tl.arange(0, BLOCK_SIZE)
    col_offsets = tl.arange(0, BLOCK_SIZE)
    offsets = row_offsets[:, None] * stride + col_offsets

    x = tl.load(x_ptr + offsets).to(tl.float32)
    y = tl.load(y_ptr + offsets).to(tl.float32)
    x = tl.sum(x[:, :, None] * ((x * y)[:, None, :]), axis=2)

    tl.store(x_ptr + offsets, x)

x = torch.randn((32, 16), device="cuda")
y = torch.randn((32, 16), device="cuda")

grid = lambda meta: (2,)
func[grid](
    x,
    y,
    x.stride(0),
    BLOCK_SIZE=16,
    num_warps=1,
)

@zahimoud, this one assert should be easy to fix but I don't know if there are more assumptions in the code that the shape should not have more than 2D?

@zahimoud, this one assert should be easy to fix but I don't know if there are more assumptions in the code that the shape should not have more than 2D?

Yes, I'm gna look at that now, broke support by mistake after my recent refactor

https://github.com/openai/triton/pull/2460
Seems to be resolved, thanks!


Use zipfoundation for unzip

Fixes https://github.com/SwiftPackageIndex/SwiftPackageIndex-Server/issues/3137

CI tests are still broken but I know why now: https://forums.swift.org/t/amazon-linux-2023-support/66209/10
Linux test run:
❯ docker run --rm -v "$PWD":/host -w /host swift:5.10.0-amazonlinux2 swift test

warning: 'host': dependency 'swift-crypto' is not used by any target
[0/1] Planning build
...
Build complete! (14.06s)
Test Suite 'All tests' started at 2024-07-11 08:36:04.987
Test Suite 'debug.xctest' started at 2024-07-11 08:36:04.989
Test Suite 'DocUploaderTests' started at 2024-07-11 08:36:04.989
Test Case 'DocUploaderTests.test_logUrl' started at 2024-07-11 08:36:04.989
Test Case 'DocUploaderTests.test_logUrl' passed (0.001 seconds)
Test Case 'DocUploaderTests.test_reportResult' started at 2024-07-11 08:36:04.990
Test Case 'DocUploaderTests.test_reportResult' passed (0.02 seconds)
Test Suite 'DocUploaderTests' passed at 2024-07-11 08:36:05.010
         Executed 2 tests, with 0 failures (0 unexpected) in 0.021 (0.021) seconds
Test Suite 'DocUploadBundleTests' started at 2024-07-11 08:36:05.010
Test Case 'DocUploadBundleTests.test_String_pathEncoded' started at 2024-07-11 08:36:05.010
Test Case 'DocUploadBundleTests.test_String_pathEncoded' passed (0.0 seconds)
Test Case 'DocUploadBundleTests.test_init' started at 2024-07-11 08:36:05.010
Test Case 'DocUploadBundleTests.test_init' passed (0.0 seconds)
Test Case 'DocUploadBundleTests.test_issue_10' started at 2024-07-11 08:36:05.010
Test Case 'DocUploadBundleTests.test_issue_10' passed (0.0 seconds)
Test Case 'DocUploadBundleTests.test_issue_3069' started at 2024-07-11 08:36:05.010
Test Case 'DocUploadBundleTests.test_issue_3069' passed (0.843 seconds)
Test Suite 'DocUploadBundleTests' passed at 2024-07-11 08:36:05.853
         Executed 4 tests, with 0 failures (0 unexpected) in 0.843 (0.843) seconds
Test Suite 'ZipTests' started at 2024-07-11 08:36:05.853
Test Case 'ZipTests.test_unzip' started at 2024-07-11 08:36:05.853
Test Case 'ZipTests.test_unzip' passed (0.001 seconds)
Test Case 'ZipTests.test_zip_roundtrip' started at 2024-07-11 08:36:05.854
Test Case 'ZipTests.test_zip_roundtrip' passed (0.008 seconds)
Test Suite 'ZipTests' passed at 2024-07-11 08:36:05.862
         Executed 2 tests, with 0 failures (0 unexpected) in 0.009 (0.009) seconds
Test Suite 'debug.xctest' passed at 2024-07-11 08:36:05.862
Executed 8 tests, with 0 failures (0 unexpected) in 0.873 (0.873) seconds
Test Suite 'All tests' passed at 2024-07-11 08:36:05.862
Executed 8 tests, with 0 failures (0 unexpected) in 0.873 (0.873) seconds

macOS test run:
❯ swift test
warning: 'spi-doc-uploader': dependency 'swift-crypto' is not used by any target
Building for debugging...
[59/59] Applying doc-uploader
Build complete! (18.93s)
Test Suite 'All tests' started at 2024-07-11 10:36:43.422.
Test Suite 'DocUploaderPackageTests.xctest' started at 2024-07-11 10:36:43.423.
Test Suite 'DocUploadBundleTests' started at 2024-07-11 10:36:43.423.
Test Case '-[DocUploadBundleTests.DocUploadBundleTests test_init]' started.
Test Case '-[DocUploadBundleTests.DocUploadBundleTests test_init]' passed (0.001 seconds).
Test Case '-[DocUploadBundleTests.DocUploadBundleTests test_issue_10]' started.
Test Case '-[DocUploadBundleTests.DocUploadBundleTests test_issue_10]' passed (0.000 seconds).
Test Case '-[DocUploadBundleTests.DocUploadBundleTests test_issue_3069]' started.
Test Case '-[DocUploadBundleTests.DocUploadBundleTests test_issue_3069]' passed (0.501 seconds).
Test Case '-[DocUploadBundleTests.DocUploadBundleTests test_String_pathEncoded]' started.
Test Case '-[DocUploadBundleTests.DocUploadBundleTests test_String_pathEncoded]' passed (0.000 seconds).
Test Suite 'DocUploadBundleTests' passed at 2024-07-11 10:36:43.925.
         Executed 4 tests, with 0 failures (0 unexpected) in 0.502 (0.502) seconds
Test Suite 'DocUploaderTests' started at 2024-07-11 10:36:43.925.
Test Case '-[DocUploaderTests.DocUploaderTests test_logUrl]' started.
Test Case '-[DocUploaderTests.DocUploaderTests test_logUrl]' passed (0.000 seconds).
Test Case '-[DocUploaderTests.DocUploaderTests test_reportResult]' started.
Test Case '-[DocUploaderTests.DocUploaderTests test_reportResult]' passed (0.002 seconds).
Test Suite 'DocUploaderTests' passed at 2024-07-11 10:36:43.928.
         Executed 2 tests, with 0 failures (0 unexpected) in 0.003 (0.003) seconds
Test Suite 'ZipTests' started at 2024-07-11 10:36:43.928.
Test Case '-[DocUploadBundleTests.ZipTests test_unzip]' started.
Test Case '-[DocUploadBundleTests.ZipTests test_unzip]' passed (0.001 seconds).
Test Case '-[DocUploadBundleTests.ZipTests test_zip_roundtrip]' started.
Test Case '-[DocUploadBundleTests.ZipTests test_zip_roundtrip]' passed (0.002 seconds).
Test Suite 'ZipTests' passed at 2024-07-11 10:36:43.932.
         Executed 2 tests, with 0 failures (0 unexpected) in 0.004 (0.004) seconds
Test Suite 'DocUploaderPackageTests.xctest' passed at 2024-07-11 10:36:43.932.
         Executed 8 tests, with 0 failures (0 unexpected) in 0.509 (0.509) seconds
Test Suite 'All tests' passed at 2024-07-11 10:36:43.932.
         Executed 8 tests, with 0 failures (0 unexpected) in 0.509 (0.510) seconds

Will deploy this and test swift-metrics doc gen next week after we're done with Xcode 16b3 processing.


SV-Create Required typeDefs

Create required typeDefs for Apollo backend.

Created query resolvers and createUser and loginUser mutations. Created typedefs for all models and initial queries and mutations. New scalar for date still to be set up properly.


Zip files fail to expand on OSX

We've noticed that the zip files produced here fail to expand automatically when double-clicked on some Macs.  The user gets a pop-up window saying, "Unable to expand '<file.zip>' into ''. (Error 2 - No such file or directory.)".  However, the zip file will unpack just fine on the command line with unzip.
Most reports of this online are connected to too-large zip files (GBs) or corrupt files, but this happens with small files, and they open just fine on the command line.  A couple of possibly-relevant issues:

A ruby zip streamer ran into a problem with their streaming zip files, which was fixed by adjusting some headers in the zip file: https://github.com/fringd/zipline/pull/2.  See also the reported issue: https://github.com/fringd/zipline/issues/1.
A JS zip library encountered this same error message (https://github.com/gildas-lormeau/zip.js/issues/6), and fixed it by tweaking headers as well: https://github.com/gildas-lormeau/zip.js/commit/fb677d8fda1381599731c84845504c68da2946d9.

I'm going to keep poking around here, but I wanted to document what I've found so far.

I've found that Python produces different zip files depending on whether the output file handle is streaming (no seek method).  It looks like OSX is happy with the non-streaming files, but can't deal with the streaming-produced ones.
The file out.zip was created with a standard file handle.  It unzips just fine on OSX.  In contrast, out-stream.zip was created with a file handle where seek was disabled.  It doesn't unzip on OSX.


Add some Keys

Add some Keys :
CapsLock,
NumLock,
ScrollLock,

Alt,
AltRight,
Control,
ControlRight,
Shift,
ShiftRight,

Related #2041
Closes #3636
Related #3653

Hey, I'd love this feature. Any hope of getting it merged in?

This doesn't work at all in the web demo at https://egui-pr-preview.github.io/pr/5400-patch150/:

While it might not work well on the web because the browser takes focus, this isn't the issue with this commit.
We'll need an additional commit for the modifiers.


[Google Translate] Add translate selected text command

Extension
https://www.raycast.com/gebeto/translate
Description
Can you please add "translate selected text" command? Same as "Send selection to AI chat" but for translate
Who will benefit from this feature?
No response
Anything else?
No response

The Quick Translate command has already implemented this feature.

This is already exists, all you need is just add hotkey to quickly open translate to run the translate, for me it is CONTROL+T
https://github.com/user-attachments/assets/08af8491-72f1-451b-83f1-914e74f6aca2

Closing due to this feature already exists.


Remove separate six def; include the six build in the datadog-agent

build.
Simplifies build, prevents double copy of entire tree

Note I changed the file you removed in https://github.com/DataDog/datadog-agent/pull/3431
If my PR gets merged before this one, make sure to copy here the -D that I added to cmake.


fix(headless): add actionCause and customData to missing /v2 calls

https://coveord.atlassian.net/browse/KIT-2133
Every time I tried to write tests for this, I was making more steps backwards than forwards, so I give up.
This PR adds analytics.actionCause and analytics.customData to /v2 calls that didn't include it yet:

fetchPage (results per page & pager)
fetchMoreResults
fetchFacetValues (facet "show more")

Re-requested reviews since I added more tests and refactored pager tests


Tint color on button + darker color when button highlighted + possibility to add bottom offset on cell

+1 for a merge 👍

Thanks for the Pull request. I have added tintColor for icon method only.
Won't merge the others because the library already has bottomMargin property and the darker color features are too specific (i.e. other users would like to lighten color instead or darken color).


oncoplot

Describe the issue
A clear and concise description of what the issue is.
I used oncoplot to draw the waterfall plot with the following code. I included all the variants and I checked that every sample had at least one variant. However, the oncoplot with the title of 'Altered in 92% of the samples'. Do you have an idea of what is the problem here? I would expect the alteration rate to be 100%.
Thank you for your help.
Command
Please post your commands and the output (errors or any unexpected output)
advanced= read.maf(maf = var.annovar.maf,clinicalData = clinicalData,removeDuplicatedVariants = FALSE,useAll = TRUE,vc_nonSyn=vcNames)
oncoplot(maf = advanced,top = 15,draw_titv = TRUE,gene_mar = 6,fontSize = 0.5,colors = vc_cols)

Session info
Run sessionInfo() and post the output below

Hi,
The % is estimated based on the mutations that are included in the oncoplot. Try with removeNonMutated = FALSE, it should show the samples with no mutations.

Hi, Thank you for your suggestions. I tried but this still give me the # % < 100% and I actually checked the samples, all of them have at least one mutation including all the types. Any other possibility to solve this? Thank you!

Could you please post your exact commands and the oncoplot?

Sure, using this code, silent, unknown mutations, etc were included in the figure as well but still got the percentage less than 100%.
oncoplot(maf = advanced,top = 15,draw_titv = TRUE,gene_mar = 6,fontSize = 0.5,colors = vc_cols,removeNonMutated = TRUE)

So are you sure that you dont see any empty columns in the plot? Is it possible to attach the plot? You can crop out the gene names and other sensitive info. if you would like.

Hi,
Your command should be,
oncoplot(maf = advanced,top = 15,draw_titv = TRUE,gene_mar = 6,
fontSize = 0.5,colors = vc_cols,removeNonMutated = FALSE)

You have the removeNonMutated = TRUE in your command. Let me know if you still don't see any empty columns. I am pretty sure there are samples with no variants in these top 15 genes.

Hi, I see! So the percentage of just for the top 15 genes rather than all, right? I thought this is the percentage for all mutations...

Yes, the stats in the title are only for the genes included in the plot.


fix logger config and use Logger of SOFABoot rpc

Codecov Report

Merging #10 into master will increase coverage by 1.12%.
The diff coverage is 29.62%.

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
+ Coverage   48.09%   49.21%   +1.12%
==========================================
  Files          44       45       +1
  Lines        1075     1089      +14
  Branches      183      183
==========================================
+ Hits          517      536      +19
+ Misses        441      430      -11
- Partials      117      123       +6

Impacted Files
Coverage Δ

...boot/context/event/SofaBootRpcStartAfterEvent.java
100% <ø> (+100%)
:arrow_up:

.../rpc/boot/context/event/SofaBootRpcStartEvent.java
100% <ø> (ø)
:arrow_up:

...fa/rpc/boot/config/SofaBootRpcConfigConstants.java
80% <ø> (ø)
:arrow_up:

...ofa/rpc/boot/context/SofaBootRpcStartListener.java
100% <ø> (+25%)
:arrow_up:

...ay/sofa/rpc/boot/config/ZookeeperConfigurator.java
33.33% <ø> (+33.33%)
:arrow_up:

...fa/rpc/boot/container/RegistryConfigContainer.java
45.23% <0%> (+3.77%)
:arrow_up:

...ay/sofa/rpc/boot/config/LocalFileConfigurator.java
0% <0%> (ø)

...m/alipay/sofa/rpc/boot/SofaBootRpcInitializer.java
76.92% <100%> (ø)
:arrow_up:

...sofa/rpc/boot/container/ServerConfigContainer.java
59.84% <100%> (-0.76%)
:arrow_down:

...pay/sofa/rpc/boot/common/RpcThreadPoolMonitor.java
63.41% <100%> (ø)
:arrow_up:

... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a02d3a4...4ba44d9. Read the comment docs.


"Merging of more than one non-empty local vocabularies is currently not supported" on UNION

If I run this query with a really basic UNION clause it works fine.
However if I run this other query with a more complext clause that involves BINDs and FILTERs I receive this error:
Error processing query
Merging of more than one non-empty local vocabularies is currently not supported, please contact the developers

If I run an even more complex UNION which involves also a SERVICE call like in this query I get the same error. Even if I remove the BIND from inside the UNION and move it outside, the error is still there.
So I was wondering: why is the first query running and the others not? What are the current limits to what can be done inside a UNION?

Ok, after many tries I managed to make the UNION+SERVICE query work: BOTH the BIND and FILTER clauses must be after the UNION. If the BIND is before the UNION but the FILTER is inside or after, I still receive the same error.
So I guess that a limitation is that BINDs can't bee placed before UNIONs?

In addition to the open question about the limits of UNIONs, I have discovered a very strange behavior related to the same error:
If I run this query it runs without returning any error.
If I run this other query it returns an error.
The only difference between the two queries is the comment # osmrel:365331 ogc:contains ?osm. that I added before the UNION.
However if I substitute the comment above with another comment (# wololoooo, link to query) the query runs without errors.
It looks like the query engine is erroneously using the commented clause if it appears like a vaild statement.

@Danysan1 We overlooked this issue and I am seeing it only now after your follow-up comment from an hour ago. Please feel free to always send a reminder if you don't hear from us within a reasonable time.
The problems you describe have nothing to do with particular operations like UNION. The reason lies in how QLever currently implements its co-called "local vocabulary". Let me briefly explain: QLever distinguishes between literals and IRIs that occur in the input data (the normal vocabulary), and literals and IRIs that are added by a SPARQL query (the local vocabulary, one per query). For example, operations such as BIND or aggregations like GROUP_CONCAT or string functions like CONCAT can add IRIs or literals to the local vocabulary of a query.
There is currently a restriction that at most one operand of each operation can have a non-empty local vocabulary. To see the operations for a query, execute it and click on the "Analysis" button. For example, if you have a UNION where both the left and the right side introduce a new literal or IRI, you get the error message you mention. The reason for that is purely technical, an it is of course on our TODO list to lift that restriction.
In the meantime, almost all queries can be rewritten to work around this current restriction. For example, in your second query, in both sides of the UNION you bind the variable name center to a particular POINT. But there is actually no need to introduce a variable, you can put the POINT right in the FILTER. And you don't even need a UNION, but you can just have a single FILTER with a &&. Also note that there was a typo in your query (?_location instead of ?wd_location).

Ok, thanks


uaa varz endpoint reporting wrong type

The varz endpoint for uaa is returning "type":"VARZ" rather than "type":"uaa".
This could be fixed by either changing cloudfoundry/cf-release/jobs/uaa/templates/varz.yml.erb to move the "type" parameter to the top level as shown below
---
pid: /var/vcap/sys/run/uaa.pid
type: uaa
varz:
username: random_username_replaced_by_a_script
password: random_password_replaced_by_a_script
logging:
config: /var/vcap/jobs/uaa/config/varz.log4j.properties
Or by changing  cloudfoundry/identity-tools/varz/src/main/webapp/WEB-INF/varz-servlet.xml so that is gets the property from it's current location.
<bean id="varzEndpoint" class="org.cloudfoundry.identity.varz.VarzEndpoint">
	<property name="server" ref="mbeanServer" />
	<property name="staticValues">
		<map>
			<entry key="type" value="${varz.type:VARZ}" />
		</map>
	</property>
	<property name="environmentProperties" ref="applicationProperties"/>
</bean>

Jon Price
Intel Corp.

Hi there!
We use Pivotal Tracker to provide visibility into what our team is working on. A story for this issue has been automatically created.
The current status is as follows:

[ ] #99824344 uaa varz endpoint reporting wrong type

This comment, as well as the labels on the issue, will be automatically updated as the status in Tracker changes.

@jfmyers9 @mbhave @fhanik what's the status of this issue: "uaa varz endpoint reporting wrong type"?

@Amit-PivotalLabs We are planning on moving from varz to statsd now. @jmprice Bearing that in mind, we would be happy to accept a PR if the fix is simple enough.
Thanks!

Hi everyone - This was fixed quite some time ago.  Thanks for the follow-up.
Jon Price
@jfmyers9 @mbhave @fhanik @Amit-PivotalLabs


Recognizing for loops and unnecessary type casts

Version and Platform (required):

Binary Ninja Version: 3.5.4286-dev, 58311b01
OS: macos
OS Version: 13.3
CPU Architecture: arm64

Here's the pseudo-C generated by BN.
See the double-cast at 0x3906c.
Also, why is i multiplied by 2 and the whole thing cast to int32_t when everything is int32_t already?
00039030  int32_t pm_init_pbd_table(uint32_t len)

00039030  {
00039034      int32_t r0;
00039034      int32_t p;
00039034      if (len != 0)
00039034      {
0003903e          int32_t r2_1;
0003903e          p = kmem_zalloc((len << 2), 7);
00039044          PM_PBD_TAB = p;
00039046          if (p != 0)
00039046          {
00039070              int32_t i = 0;
0003906c              while (((uint32_t)((int8_t)i)) < len)
0003906a              {
00039062                  *(int32_t*)(p + (i << 2)) = 0;
00039066                  i = (i + 1);
00039066              }
00039066          }
00039050          else
00039050          {
00039050              log_30e20(6, "INFO:PM:init_pbd_table: kmem_zal…", r2_1, log_30e20);
00039054              void* log = PM_CFG_0.log;
00039056              if (log != 0)
00039056              {
0003905c                  log(4, "PM:init_pbd_table: kmem_zalloc f…");
00039058              }
0003905e              r0 = 2;
0003905e          }
0003905e      }
00039046      if ((len == 0 || (len != 0 && p != 0)))
00039046      {
00039036          r0 = 0;
00039036      }
00039038      return r0;
00039038  }

compare to IDA
int __fastcall pm_init_pbd_table(unsigned int len)
{
  void *p; // r0
  int i; // r3

  if ( !len )
    return 0;
  p = kmem_zalloc(4 * len, 7);
  PM_PBD_TAB = p;
  if ( p )
  {
    for ( i = 0; i < len; ++i )
      *(p + i) = 0;
    return 0;
  }
  log_special(6, "INFO:PM:init_pbd_table: kmem_zalloc failed!\r\n");
  if ( PM_CFG.log )
    PM_CFG.log(4, "PM:init_pbd_table: kmem_zalloc failed!\r\n");
  return 2;
}

One major difference in the example from your first message is that IDA types p as a pointer, while we have it typed as an integer. I'm not entirely sure why that is, but if you make a single type change, you wind up with much nicer output:
000039030  int32_t sub_39030(int32_t len)
000039030  {
000039034      int32_t r0;
000039034      int32_t* p;
000039034      if (len != 0)
000039034      {
00003903e          int32_t r2_1;
00003903e          p = sub_39020((len << 2), 7);
000039044          data_20053edc = p;
000039046          if (p != 0)
000039046          {
000039070              int32_t i = 0;
00003906c              while (((uint32_t)((int8_t)i)) < len)
00003906a              {
000039062                  p[i] = 0;
000039066                  i = (i + 1);
000039066              }
000039066          }
000039050          else
000039050          {
000039050              log_30e20(6, "INFO:PM:init_pbd_table: kmem_zal…", r2_1, log_30e20);
000039054              int32_t r3_1 = data_20053ed8;
000039056              if (r3_1 != 0)
000039056              {
00003905c                  r3_1(4, "PM:init_pbd_table: kmem_zalloc f…");
000039058              }
00003905e              r0 = 2;
00003905e          }
00003905e      }
000039046      if ((len == 0 || (len != 0 && p != 0)))
000039046      {
000039036          r0 = 0;
000039036      }
000039038      return r0;
000039038  }

The casts at 0x3906c are, I believe, being emitted because it's showing the explicit chain of type promotions. In my opinion, this is pretty useful because it shows:

The value of i can't ever be larger than 255 here
The value is being treated as an unsigned value, despite i being typed as signed

The underlying instruction here is a uxtb:
000039068  dab2       uxtb    r2, r3
00003906a  a242       cmp     r2, r4
00003906c  f9d3       bcc     #0x39062

...which extends a byte into a word with zeroes, so this should be the only correct interpretation. This looks a lot nicer in HLIL because we lift it as while (zx.d(i.b) u< len) using nomenclature that doesn't exist in C to disambiguate what's happening.
If you don't really care about the specifics of what's happening, you can make this look even simpler (after the change above to make it a pointer) by going to the hamburger menu in the top-right of the pane and turning off "Show Type Casts":
00003906c              while (i < len)
00003906a              {
000039062                  p[i] = 0;
000039066                  i = (i + 1);
000039066              }

It still shows as a while loop instead of a for loop, though.
I think the actionable parts of this issue are:

Why don't we recognize this as a for loop?
Why don't we recognize r0 as being a pointer instead of an integer?

The type casts are a preference for explicit information that is a feature, rather than a bug, and has a supported workaround for users that have a preference otherwise.
Does all of the above make sense and do you agree? Or, is there some other nuance or viewpoint I've missed?

I agree with the above, thank you!

The loop-recovery part of this issue is a duplicate of https://github.com/Vector35/binaryninja-api/issues/5369. The other part of the issue is also discussed and resolved in it. Closing this


Release with #255

Is there a release coming soon now that #255 has been released?
That is a feature we've been waiting for. We have a slow angular build and the --devserver-timeout flag helps us out tremendously!
I can run the cli locally with npm link but it's not feasible for everyone on the team to be forced to do that.
Thanks to everyone working on a great solution!

0.7.1 is released! 🎉


Shouldn't remove subscribers while iterating

Removing subscribers while iterating them is generally not a good idea, see here:
https://github.com/ReSwift/ReSwift/blob/5b9ebd49b166205a89d17a466f03897559379665/ReSwift/CoreTypes/Store.swift#L24
This is a less likely situation. But a problem can also happen when unsubscribing in a subscription (i.e. newState()).

Because Set in swift is a value type, this is safe behaviour. While not exactly what is occurring, one could think of forEach receiving a copy of the Set, and thus the remove() is not acting on the same copy as is being iterated.
For a more correct & descriptive reasoning, see https://stackoverflow.com/a/37998032
This also means it is safe to unsubscribe in newState(...).
If Set were a reference type (as NSSet is in Objective-C) then you would be correct, and mutating while enumerating in this fashion would likely cause a crash.

Thank you, I stand corrected. I knew about the copy-on-write semantics, but didn't realize it works with iterators too.


Update ppc64le and s390x imagestreams

CC @jmtd

With the release of the openj9 and ubi8 images, this will need to be immediately followed up with a sync to the release branch.
One remaining question is what should provide the "default" java:8 and java:11 imagestreams on Z.


PoC Implementation for Adapting vultiserver for plugin usage

Closing in favour of the work ongoing in https://github.com/vultisig/vultiserver-plugin


Fix takeaction

We should actually revert this and change the capitalization of the file so that everything is consistent.
You may need to run git config core.ignorecase false  so that the change in filename capitalization is recognized by git

Could you take the lead on this please?


the precision of timestamp(6) is lost while insert data

When I insert '2020-03-01 12:00:00.121212' into filed with timestamp(6), it's always '2020-03-01 12:00:00.000000', please check and fix, thx!

Thank you for your interest in this project.
This issue has nothing to do with MariaDB4j, this project which wraps
MariaDB; you need to take this up with the database itself, not this
wrapper.
Can I let you please close this issue?
On Sun, 1 Mar 2020, 08:57 darbean<EMAIL_ADDRESS>wrote:

When I insert '2020-03-01 12:00:00.121212' into filed with timestamp(6),
it's always '2020-03-01 12:00:00.000000', please check and fix, thx!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/vorburger/MariaDB4j/issues/339?email_source=notifications&email_token=AACI4ZWMTULIXI2KX4V5MYTRFIIQFA5CNFSM4K7CPFG2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IRO65QQ,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACI4ZXP5FKFOXODAZUY3ULRFIIQFANCNFSM4K7CPFGQ
.

Thank you for your interest in this project. This issue has nothing to do with MariaDB4j, this project which wraps MariaDB; you need to take this up with the database itself, not this wrapper. Can I let you please close this issue?
…
On Sun, 1 Mar 2020, 08:57 darbean, @.***> wrote: When I insert '2020-03-01 12:00:00.121212' into filed with timestamp(6), it's always '2020-03-01 12:00:00.000000', please check and fix, thx! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#339?email_source=notifications&email_token=AACI4ZWMTULIXI2KX4V5MYTRFIIQFA5CNFSM4K7CPFG2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IRO65QQ>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACI4ZXP5FKFOXODAZUY3ULRFIIQFANCNFSM4K7CPFGQ .

ok


--allow-downgrades in /opt/bin/setup

I had created custom AMI using AWS EC2 Image Builder which had docker and it's dependencies preinstalled. Now when I used this AMI in the machinedeployment, the /opt/bin/setup script was just giving this error.
supervise.sh[155349]: E: Packages were downgraded and -y was used without --allow-downgrades.
and due to /opt/bin/supervise.sh, the setup script just kept executing in an infinite loop and never completing the machine setup.

Relevant Files  - https://github.com/kubermatic/machine-controller/blob/e368d5ba4d3b1a85ac2cf05068d4cf591e280b11/pkg/containerruntime/containerd.go and https://github.com/kubermatic/machine-controller/blob/e368d5ba4d3b1a85ac2cf05068d4cf591e280b11/pkg/containerruntime/docker.go


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-k8s-30-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 4573

Questions ?
Please refer to the Backport tool documentation


Update PROTOCOL.md

Line 7: it doesn't get it's key id from the server, rather it derives it from the key using the same algorithm as the server.
This can cause some troubles when version don't match, it will be solved in 0.0.2-beta

lgtm


Added KEKW coin

[x] I will not ping the Discord about this pull request.

Please provide the following information for your token.
Please include change to the src/lib/.json and in the PR
At minimum each entry should have

Token Address: 2QK9vxydd7WoDwvVFT5JSU8cwE9xmbJSzeqbRESiPGMG
Token Name: Kekwcoin
Token Symbol: KEKW
Logo: https://www.kekw.io/images/logo_final_round_smallFace.png
Link to the official homepage of token: https://www.kekw.io/
Coingecko ID if available (https://www.coingecko.com/api/documentations/v3#/coins/get_coins__id_): Not yet

@bartosz-lipinski sorry to tag you this specifically, but I haven't received any suggestions so far and other projects have been merged before mine. Please remind me if I missed anything, I will make the PR change ASAP.
Many thanks for your contribution 🙇

https://github.com/solana-labs/token-list/pull/216


Order

close issue #76

Current coverage is 90.26% (diff: 76.92%)

Merging #91 into master will decrease coverage by 0.52%

@@             master        #91   diff @@
==========================================
  Files            21         21
  Lines           402        411     +9
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            365        371     +6
- Misses           37         40     +3
  Partials          0          0

Powered by Codecov. Last update 18c6eed...55d54b0


Twitter - The requested resource cannot be found

A new problem with Twitter seems to have popped up.
I don't know if it's just temporarily, but at the moment a Twitter user query only gives me:
Twitter @nasa was unable to receive or process the remote website's content! Error message: The requested resource cannot be found! Please make sure your input parameters are correct! cUrl error: malformed (3) PHP error: Undefined offset: 0
As always, I hope this can be fixed.
Thanks!

I had a similar problem and created a PR: #1686
Please try if this fixes your error too.

I had a similar problem and created a PR: #1686
Please try if this fixes your error too.

I just tried it, and it did fix it for me.

That did it, thank you!

Yes, we seem to be back on track.
Thanks for the quick fix.

I had a similar problem and created a PR: #1686
Please try if this fixes your error too.

I just tried it, and it did fix it for me.

Yup, my twitter feeds are updating again now, i.e., that PR: #1686 works for me as well.  Thanks!
.

Merged suggested PR


fix(curriculum): removed repeated word in challenge

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #45449

Removed the word "time" which is repeated twice.
Before - Now it's time time to add other details
After - Now it's time to add other details

Hi @Sumanth077. Congrats on your first pull request (PR)! 🎉
Thank you for your contribution to the page! 👍
We are happy to accept these changes and look forward to future contributions. 📝

Thank you @gikf


Added vs2019 preview support for building ponyc

#3544
This PR allows to build ponyc project using vs2019 preview.
Without my changed，It will prompt "No Visual Studio 2017+ was found in the system."

@kulibali does this need a changelog label?


Collaboration Room Right

This PR adds the following features:

Video Server
Signaling Server for editor
Judge 0 (code running and compiling)
UI for the related components
Supabase updates for closing and opening rooms
Linking to matching service

Bugs:

Language change not persistent across.

Need to ping the signaling server when a change in language happens so it is communicated to the other clients

Video "off" function only works for the client that opted to off. Partner is still able to see the video


Monthly Road Updates (FY24 Q4)

Benefit
The statewide road centerline dataset supports decision-making and is critical in business systems such as 911 and the address locators.
Acceptance Criteria

[ ] A current statewide road centerline dataset in the SGID that adheres, to the best of our ability, to our update schedule.

Notes

[x] April 2024

Date: 04/12/2024
Counties updated

Box Elder
Iron
Juab
Salt Lake
Utah
Washington
Weber

Three new addresses from this road update (for locator testing)

5245 W CANAL BLVD, American Fork 84003
784	SANCTUARY PL, Ivins 84738
425	S 1150 W, Brigham City 84302

[x] May 2024

Date: 05/9/2024
Counties updated

Piute
Salt Lake
Sevier
Utah
Wasatch
Washington
Wayne

Three new addresses from this road update (for locator testing)

1603 S LAMAR LN, HEBER CITY 84032
1110 S 1810 E, TEASDALE, 84773
3836 W 2530 S, HURRICANE, 84737

[ ] June 2024

Date: 06/13/2024
Counties updated

Cache
Davis
Iron
Salt Lake
Tooele
Utah
Washington
Wayne

Three new addresses from this road update (for locator testing)

3255 E FARMSTEAD RD, St George 84790
80 N 300 E, Hyrum 84319
8740 N DENTON AVE, Tooele 84074

after the April road grinder update, let's check these addresses again.
https://github.com/agrc/planning-queue/issues/290#issuecomment-2029799396

i created an action to test addresses in github comments 🎉
/validate addresses
- 5245 W CANAL BLVD, 84003
- 5245 W CANAL BLVD, American Fork
- 784 SANCTUARY PL, 84738
- 784 SANCTUARY PL, Ivins
- 425 S 1150 W, Brigham City
- 425 S 1150 W, 84302

feel free to run this adhoc.

/validate addresses

5245 W CANAL BLVD, 84003
5245 W CANAL BLVD, American Fork
784 SANCTUARY PL, 84738
784 SANCTUARY PL, Ivins
425 S 1150 W, Brigham City
425 S 1150 W, 84302

was this run after the most recent road grinder update (from yesterday)?

It was just run 10 minutes ago.

hmm. okay, seems odd it didn't find it. i'll check the road grinder data again.

I just checked the forklift logs and they got lifted this morning so they will ship tonight. You may want to replace the canal address since it's already matching?

/validate addresses

2465 N LA CASA CIR, St George
2465 N LA CASA CIR, 84770
784 SANCTUARY PL, 84738
784 SANCTUARY PL, Ivins
425 S 1150 W, Brigham City
425 S 1150 W, 84302

/validate addresses

1603 S LAMAR LN, HEBER CITY 84032
1110 S 1810 E, TEASDALE, 84773
3836 W 2530 S, HURRICANE, 84737
1603 S LAMAR LN, 84032
1110 S 1810 E, 84773
3836 W 2530 S, 84737

/validate addresses

3255 E FARMSTEAD RD, St George 84790
80 N 300 E, Hyrum 84319
8740 N DENTON AVE, Tooele 84074

you need to pick the city or the zip for these. the api is not expecting both.


SolidOS should not silently fail when unable to retrieve WebID during granting permission

SolidOS/Mashlib has a tab for each resource/container to modify its sharing permissions / access control lists. It allows to grant permission to an individual WebID entered by the user.
If everything goes normal, after entering WebID and clicking yes, the textbox and yes/no disappears, and an avatar corresponding to that WebID will appear as a "viewer". Then the user can drag-and-drop it to the appropriate location.
However, if the entered WebID cannot be retrieved, the textbox and yes/no disappears as well, but nothing further happens. This is very un-user-friendly...
Preferably, SolidOS should either:

Alarm the user that something wrong happened when retrieving the WebID document; or
Add the WebID as a viewer regardlessly; or
A combination of the two above (e.g. alarm, and allow proceeding regardlessly).

I haven't tried similar things on other types, but maybe worth checking if they have similar issues?

Good feedback, I lean towards (2)—adding the WebID even if SolidOS can't connect.
The Pod might be down, or the client could have lost internet. In a local-first model, SolidOS should be able to function offline, like during a plane flight.
There's definitely scope to enhance the UX with warnings as well.


Compilation errors on Debian

The compilation step of the build fails on up-to date Debian 8 with javac 1.7.0_111. I have successfully compiled the code on OSX with javac 1.8.0_77, so this is a java version issue. The erors are related to calls to the callback functions sendToIntruder, sendToRepeater, and doActiveScan. These are also the functions failing in issue #3, so this might be the cause for it.
./burp/ContextMenu.java:54: error: local variable callbacks is accessed from within inner class; needs to be declared final
                    callbacks.sendToIntruder(httpRequest.getHost(), httpRequest.getPort(), httpRequest.getUseHttps(), httpRequest.getRequest());
                    ^
./burp/ContextMenu.java:69: error: local variable callbacks is accessed from within inner class; needs to be declared final
                    callbacks.sendToRepeater(httpRequest.getHost(), httpRequest.getPort(), httpRequest.getUseHttps(),
                    ^
./burp/ContextMenu.java:85: error: local variable callbacks is accessed from within inner class; needs to be declared final
                    callbacks.doActiveScan(httpRequest.getHost(), httpRequest.getPort(), httpRequest.getUseHttps(), httpRequest.getRequest());
                    ^
./burp/Helper.java:151: error: cannot find symbol
                                + "Accept: " + String.join(",", produces) + "\n"
                                                     ^
  symbol:   method join(String,List<String>)
  location: class String
./burp/Helper.java:152: error: cannot find symbol
                                + "Content-Type: " + String.join(",", consumes)
                                                           ^
  symbol:   method join(String,List<String>)
  location: class String
./burp/Helper.java:160: error: cannot find symbol
                                + "Accept: " + String.join(",", produces)
                                                     ^
  symbol:   method join(String,List<String>)
  location: class String

This issue has no relation to #3, opposite to what i thought.


Add GB Bank Account (not working)

Adding a GB bank account currently fails with the new SDK. I have submitted a screenshot via your contact page. Here is the exception (it's not very informative):
{"Message":"Internal Server Error","Type":"other","Id":"d989139b-4980-42b8-85de-78af8a1a1cab#1476906932","Date":1476906933.0,"errors":null}
Edit: This occurs whilst using the sandbox

Hi there, this is actually a known issue with our banking supplier I'm afraid. It is only affecting sandbox though. We'd don't yet have an estimated fix date unfortunately :-(

I'm closing this ticket since it's non-SDK related. You can follow https://github.com/Mangopay/mangopay/issues/34 for updates.


generate appropriate packages/ paths for entrypoints nested within web/ or example/

Our code generation logic assumes that there is a packages/ folder next to the entrypoint. But pub-build will only have one next to the top-level folder (web/ or example/).
Code generated in example/a/b/c.html, should have references to the polyfills like this:
<html><head>
<script src="../../packages/shadow_dom/shadow_dom.debug.js"></script>
<script src="../../packages/custom_element/custom-elements.debug.js"></script>
<script src="../../packages/browser/interop.js"></script>

This issue has been moved to dart-lang/polymer-dart#381.


Find the new one-page (GitHub Page) theme for this repository

For this https://gomzyakov.github.io/laravel-blog/

NOTE: This repository is no longer supported or updated by @gomzyakov . If you wish to continue to develop this code yourself, we recommend you fork it.


Use manifest/name as canvas label, to ensure uniqueness

Fixes #3
I've just used the existing manifest variable to pass the manifest name to the two methods that write Jekyll-style Markdown headers for annotations lists. They compose the canvas label in the form manifest + '/' + name. I haven't changed the annotations in the examples to use this form; they'll only have this problem if more examples are added that use the same canvas names as one of the existing ones.
I've tested it with bnf640. The copperfield example isn't working for me (every annotation I create gets assigned to 10.json); I haven't investigated why.

Whoops, it breaks if there are already annotations for that canvas. Hang on...

It turns out it does matter if new annotations are added to a canvas that already has annotations. The list.json doesn't get updated, so it still looks for the label f10 while the updated f10.json uses the label bnf640/f10.  I'll leave it as is but if you think this is worth merging I'd be happy to update Rakefile to make sure list.json agrees with the annotation file, or else just to update all the list.json in the examples so that the problem won't arise.


Implementation Message data digits are rounded #3751

[ ] Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
changed JSON.parse with lib lossless-json pars
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

[ ] No need to
[x] Manually (please, describe, if necessary)
[ ] Unit checks
[ ] Integration checks
[ ] Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
[x] My changes generate no new warnings (e.g. Sonar is happy)
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged

Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)

@Mgrdich i can try it

@Mgrdich i remembered that i tried something like this what you send,  but it not worked because  serializing it back to JSON didn't worked


dbt-unit-testing plus Python models

We faced an issue when dbt-unit-testing package and Python models are used in one project.
The reason is ref macro we added for the package:
{% macro ref() %}
   {{ return(dbt_unit_testing.ref(*varargs, **kwargs)) }}
{% endmacro %}

I managed to fix that by modifying the code in dbt_packages/dbt_unit_testing/macros/overrides.sql:
return (builtins.ref(project_or_package, model_name, **kwargs)) ->
{{ return (builtins.ref(model_name, **kwargs)) }}

But I'm not sure how this change may affect unit tests. Is there a better way to fix the issue if we want to avoid changing ref in all models like:
select * from {{ dbt_unit_testing.ref('stg_customers') }}
Here is an example of a Python model:
def model(dbt, session):

    dbt.config(
        materialized = "table"
    )

    # get data from staging table
    sf_table = dbt.ref("my_snowflake_table")

    # describe the data
    data_profiling = sf_table.describe()

    return data_profiling

Thanks!

Another issue with Python models was related to model versions. But we fixed that by using the latest version of the package (v0.3.2) as suggested in issue #160.
Thanks for the fix.

We have faced the same issue. We resolved in a slightly different way. We use docker and rebuild the image on release so editing the dbt-unit-testing package file directly wasn't really a viable solution for us. We needed a way that we own, and hence version control.
We use the method suggested in the readme of this repo to override the ref and source macros:
{% macro ref() %}
   {{ return(dbt_unit_testing.ref(*varargs, **kwargs)) }}
{% endmacro %}

{% macro source() %}
   {{ return(dbt_unit_testing.source(*varargs, **kwargs)) }}
{% endmacro %}

We updated this to look like this:
{% macro ref() %}
   {% set python = kwargs["python"] | default (False) %}
   {% if python %}
      {{ return(dbt_unit_testing.ref(None, *varargs, **kwargs)) }}
   {% else %}
      {{ return(dbt_unit_testing.ref(*varargs, **kwargs)) }}
   {% endif %}
{% endmacro %}

{% macro source() %}
   {{ return(dbt_unit_testing.source(*varargs, **kwargs)) }}
{% endmacro %}

And then nothing needs change in your sql models, but in your python models, the signature of dbt ref calls should now be:
dbt.ref(model_name, python=True)
We haven't come across a limitation yet, and it works for us. As far as we can tell you can't set the project_or_package_name variable from the python models anyway, so setting it to none when ref() is called from within a python model should be fine.

Hey @jacksond80 ,
I have tried your solution but it is giving me this error -
08:14:25  Encountered an error:
Compilation Error
call() got an unexpected keyword argument 'python'

in macro ref (macros/unit_testing_macro.sql)
called by

I have changed the macro like this
{% macro ref() %}
{% set python = kwargs["python"] | default (False) %}
{% if python %}
{{ return(dbt_unit_testing.ref(None, *varargs, **kwargs)) }}
{% else %}
{{ return(dbt_unit_testing.ref(*varargs, **kwargs)) }}
{% endif %}
{% endmacro %}
{% macro source() %}
{{ return(dbt_unit_testing.source(*varargs, **kwargs)) }}
{% endmacro %}
and calling my Python model like this -
customers_df = dbt.ref("customers", python=True).to_pandas()
Please let me know if i'm doing anything wrong here, thanks.

@jsatyam7 I don't see anything obviously wrong, the error would suggest that you're attempted override of the ref() macro is not getting picked up. You can verify this by adding print statements to log to console so you can tell which macro gets called.
Is your macros path set correctly? (Do you have other macros that work ok in the macros folder?)


panic error on install

not sure what diagnostic information to offer.
10:50:48 ❯ steampipe plugin install theapsgroup/gitlab

panic: runtime error: index out of range [-1]

goroutine 14 [running]:
github.com/turbot/steampipe/cmd.doPluginInstall.func2(0xc000796ea0?)
	/home/runner/work/steampipe/steampipe/cmd/plugin.go:270 +0xb1
github.com/gosuri/uiprogress.(*Bar).Bytes(0xc00058c200)
	/home/runner/go/pkg/mod/github.com/gosuri/uiprogress@v0.0.1/bar.go:200 +0x288
github.com/gosuri/uiprogress.(*Bar).String(...)
	/home/runner/go/pkg/mod/github.com/gosuri/uiprogress@v0.0.1/bar.go:214
github.com/gosuri/uiprogress.(*Progress).print(0xc00070c8a0)
	/home/runner/go/pkg/mod/github.com/gosuri/uiprogress@v0.0.1/progress.go:127 +0x96
github.com/gosuri/uiprogress.(*Progress).Listen(0xc00070c8a0)
	/home/runner/go/pkg/mod/github.com/gosuri/uiprogress@v0.0.1/progress.go:114 +0x29
created by github.com/gosuri/uiprogress.(*Progress).Start
	/home/runner/go/pkg/mod/github.com/gosuri/uiprogress@v0.0.1/progress.go:134 +0x56
~
10:50:49 ❯ steampipe -v
steampipe version 0.14.4

❯ uname -a
Darwin dredl0ck 21.4.0 Darwin Kernel Version 21.4.0: Fri Mar 18 00:45:05 PDT 2022; root:xnu-8020.101.4~15/RELEASE_X86_64 x86_64

❯ go version
go version go1.18.2 darwin/amd64

No real experience with steampipe yet, so perhaps my setup isn't correct.

Not a maintainer, but still like to follow along with what APS does :)
Anyway, this is an odd one, ran into this one just now when trying to install the plugin:

panic: runtime error: index out of range [-1]

goroutine 14 [running]:
github.com/turbot/steampipe/cmd.doPluginInstall.func2(0xc000010ea0?)
        /home/runner/work/steampipe/steampipe/cmd/plugin.go:270 +0xb1
github.com/gosuri/uiprogress.(*Bar).Bytes(0xc00037ec80)
        /home/runner/go/pkg/mod/github.com/gosuri/uiprogress@v0.0.1/bar.go:200 +0x288
github.com/gosuri/uiprogress.(*Bar).String(...)
        /home/runner/go/pkg/mod/github.com/gosuri/uiprogress@v0.0.1/bar.go:214
github.com/gosuri/uiprogress.(*Progress).print(0xc0000aa5a0)
        /home/runner/go/pkg/mod/github.com/gosuri/uiprogress@v0.0.1/progress.go:127 +0x96
github.com/gosuri/uiprogress.(*Progress).Listen(0xc0000aa5a0)
        /home/runner/go/pkg/mod/github.com/gosuri/uiprogress@v0.0.1/progress.go:114 +0x29
created by github.com/gosuri/uiprogress.(*Progress).Start
        /home/runner/go/pkg/mod/github.com/gosuri/uiprogress@v0.0.1/progress.go:134 +0x56

On linux, v0.14.4, however, when I tried to install a different plugin: theapsgroup/vault and then the gitlab one it worked.
Tried with a fresh steampipe install, it also worked.
Either something is slightly off with this steampipe plugin's manifest or something, which is fixed by installing another plugin, OR there was a hiccup on the steampipe hub. My money is on the latter, but if you're still having the issue i'd be interested to know whether installing another plugin and then this one works for you.

i'd be interested to know whether installing another plugin and then this one works for you

Yes. I've setup github, and csv. Seem to work fine. I don't know go, but I'm going to see if it's something local to my workstation.

ok.. well, I'm not sure what I did, but it installed after trying it a few times.
❯ steampipe plugin install theapsgroup/gitlab

theapsgroup/gitlab   [====================================================================] Already installed

To update plugin which is already installed, please run steampipe plugin update theapsgroup/gitlab

Hi @bdmorin
I've just attempted to install this plugin to a fresh Steampipe install and it worked successfully, I would imagine it's a temporary hiccup with the hub - trying again may fix the issue.
❯ cat Dockerfile
FROM turbot/steampipe:0.14.4
USER steampipe:0
RUN steampipe plugin install theapsgroup/gitlab
ENTRYPOINT ["docker-entrypoint.sh"]
CMD ["service", "start", "--foreground"]

❯ docker build -t steampipe-test .
[+] Building 22.8s (7/7) FINISHED
 => [internal] load build definition from Dockerfile                                                                                0.0s
 => => transferring dockerfile: 217B                                                                                0.0s
 => [internal] load .dockerignore                                                                                0.0s
 => => transferring context: 2B                                                                                0.0s
 => [internal] load metadata for docker.io/turbot/steampipe:0.14.4                                                                                3.6s
 => [auth] turbot/steampipe:pull token for registry-1.docker.io                                                                                0.0s
 => [1/2] FROM docker.io/turbot/steampipe:0.14.4@sha256:893b3c1509e4035b76fc49c3577b0567ec2d5dcbefc26974676ae8b9fd6b9bea                                                                                14.4s
 => => resolve docker.io/turbot/steampipe:0.14.4@sha256:893b3c1509e4035b76fc49c3577b0567ec2d5dcbefc26974676ae8b9fd6b9bea                                                                                0.0s
 => => sha256:893b3c1509e4035b76fc49c3577b0567ec2d5dcbefc26974676ae8b9fd6b9bea 2.20kB / 2.20kB                                                                                0.0s
 => => sha256:c32ce6654453d35d0b3dde45d195adeee586ffba0a683006ee06748c077c01fa 27.14MB / 27.14MB                                                                                5.8s
 => => sha256:a48d2bd817b308b6a8835fbff62f41e70a6e9657be2dc476f54cb22429569e86 17.10MB / 17.10MB                                                                                7.2s
 => => sha256:bd2b4051a3b0ce4cc41c9a2d348907dfe3bfd770a4333b8ca287d19e1dabcee4 4.96kB / 4.96kB                                                                                0.0s
 => => sha256:cc9cb668cd0eafb9362ccda696caf5945d4316d4a364b4abe78dee052efbc57e 3.93kB / 3.93kB                                                                                0.5s
 => => sha256:be45aa42b4d350cdb36bfdd6ba32e470ec9d6e147aa81066e20d98c3d53e1931 12.54MB / 12.54MB                                                                                8.2s
 => => extracting sha256:c32ce6654453d35d0b3dde45d195adeee586ffba0a683006ee06748c077c01fa                                                                                1.3s
 => => sha256:4d4c4f733bb0c4d7c84258f6c626e479d61dc9145c0db44f480e237dee421842 108B / 108B                                                                                6.1s
 => => sha256:bf01c00a332643f65b77dd10a0b78f8b14fcb550002504fd69460ba873b85e55 45.11MB / 45.11MB                                                                                12.2s
 => => sha256:4f4fb700ef54461cfa02571ae0db9a0dc1e0cdb5577484a6d75e68dc38e8acc1 32B / 32B                                                                                7.3s
 => => extracting sha256:cc9cb668cd0eafb9362ccda696caf5945d4316d4a364b4abe78dee052efbc57e                                                                                0.0s
 => => extracting sha256:a48d2bd817b308b6a8835fbff62f41e70a6e9657be2dc476f54cb22429569e86                                                                                0.5s
 => => sha256:7f26cb3ad3608276fc6bb8003adf77490631fc242dde10056c066daabbbfb0f5 206B / 206B                                                                                7.7s
 => => sha256:415b2327cec6d158b0c294d19e532ea8dba30dd25923da975d2228360dc64366 393B / 393B                                                                                8.0s
 => => extracting sha256:be45aa42b4d350cdb36bfdd6ba32e470ec9d6e147aa81066e20d98c3d53e1931                                                                                0.4s
 => => extracting sha256:4d4c4f733bb0c4d7c84258f6c626e479d61dc9145c0db44f480e237dee421842                                                                                0.0s
 => => extracting sha256:bf01c00a332643f65b77dd10a0b78f8b14fcb550002504fd69460ba873b85e55                                                                                1.9s
 => => extracting sha256:4f4fb700ef54461cfa02571ae0db9a0dc1e0cdb5577484a6d75e68dc38e8acc1                                                                                0.0s
 => => extracting sha256:7f26cb3ad3608276fc6bb8003adf77490631fc242dde10056c066daabbbfb0f5                                                                                0.0s
 => => extracting sha256:415b2327cec6d158b0c294d19e532ea8dba30dd25923da975d2228360dc64366                                                                                0.0s
 => [2/2] RUN steampipe plugin install theapsgroup/gitlab                                                                                4.5s
 => exporting to image                                                                                0.1s
 => => exporting layers                                                                                0.1s
 => => writing image sha256:dcb48c3b9533ac87846d59affa885150d451d57a470d5774b78c58594575b1cd                                                                                0.0s
 => => naming to docker.io/library/steampipe-test                                                                                0.0s

Use 'docker scan' to run Snyk tests against images to find vulnerabilities and learn how to fix them```

@Bonemind thanks for looking into it <3

Thanks for investigating @Bonemind and @graza-io.
Appreciate your raising this issue @bdmorin ... we should never crash even if a related process failed ... sorry about that first impression!
Leaving this open so we can investigate the cause of the crash.

Closing as issue registered on https://github.com/turbot/steampipe/issues/2086