Clarified instructions

Instructions weren't inherently wrong, but if you close the Advanced Google services tab before clicking 'Okay' (i.e. when you open Google API) it doesn't save.

Hello @MisterSkilly: thank you for taking your time to contribute to this project.
Unfortunately you had some bad luck as far as timing is regarded: we have been working for some weeks on a new version of the script and I have just released it on the development branch.
If I accepted your changes as they are now they would conflict with the new changes and would require a lot of extra work to be implemented.
So before commenting the contents of the PR itself we need to solve some of these issues:

PRs should be made against the development branch instead of master (this is not your fault: I've just noticed that we forgot to document this anywhere... I'll fix this as soon as I can).
You can set which branch to base your PR on when clicking on the "new PR" green button.
you could teoretically change the target of this PR without closing it and opening a new one, but the contents of the file you are modifying are quite different in the new version, so you are probably better off:

closing this PR
deleting your branch
updating your fork with the latest changes on development
doing your changes on your fork
opening a new PR against development with the new changes

It would help knowing how well-versed you are with git and GitHub, so that we know what we can skip and what we need to explain.
Let us know if you need help with anything: @rowanthorpe, @baatochan and I will gladly answer any question you have.
Thank you again for your time and effort.

I created a new pull request in the development branch (#85), is that what you meant? I am rather new to GitHub pull requests and all I did was change the branch I was looking at to development and clicked the edit button next to README.md.
I'll close this pull request if the other one is fine :)


Resolvers input subfields with defaults resolve into nullable

Describe the bug
Resolvers input subfields with defaults resolve into nullable
Your Example Website or App
https://stackblitz.com/edit/node-ve8vhp?file=schema.graphql
Steps to Reproduce the Bug or Issue
typescript-resolvers:
overwrite: true
schema:
  - schema.graphql

documents: null
generates:
  generated-types.ts:
    plugins:
      - 'typescript'
      - 'typescript-resolvers'

and this is the schema:
type User {
  name: String
}

input GetUserArgs {
   offset: Int = 0
}

type Query {
  getUsers(getUsersArgs: GetUserArgs): [User]
}

Expected behavior
for offset arg to be wrapped with RequireFields in the. resolver type
Screenshots or Videos
No response
Platform

OS: macOS
NodeJS: 16.14.2
graphql version: 16.0.1
"@graphql-codegen/cli": "2.9.0"
"@graphql-codegen/typescript": "2.7.2"
"@graphql-codegen/typescript-resolvers": "2.7.2"

Codegen Config File
No response
Additional context
No response

The reason why the offset is nullable.
Kind is import from graphql

weird. it's undefined only when I debug it.

the real reason:
    const addOptionalSign =
      !this.config.avoidOptionals.inputValue &&
      (originalFieldNode.type.kind !== Kind.NON_NULL_TYPE ||
        (!this.config.avoidOptionals.defaultValue && node.defaultValue !== undefined));

// node.defaultValue == { kind: 'IntValue', value: '0' }

https://github.com/dotansimha/graphql-code-generator/blob/master/packages/plugins/typescript/typescript/src/visitor.ts#L297
seems that it's the expected behavior

related: #5113

generates:
  types.ts:
    plugins:
      - typescript
    config:
      avoidOptionals:
        defaultValue: true

set defaultValue to true

If user pass null as argument explicitly, it can be null, so it works as it should be.


Can not setup

My issue is the failure of installation.
I was installing from https://github.com/jacobkrantz/VLN-CE using the code
git clone --branch v0.1.7 git@github.com:facebookresearch/habitat-lab.git
cd habitat-lab
installs both habitat and habitat_baselines
python -m pip install -r requirements.txt
python -m pip install -r habitat_baselines/rl/requirements.txt
python -m pip install -r habitat_baselines/rl/ddppo/requirements.txt
python setup.py develop --all
However, I found this error below:
.....
01bfae789fa566a2be1f385d1/msgpack-1.0.7.tar.gz#sha256=572efc93db7a4d27e404501975ca6d2d9775705c2d922390d878fcf768d92c87
Best match: msgpack 1.0.7
Processing msgpack-1.0.7.tar.gz
Writing /tmp/easy_install-s3pm6ljt/msgpack-1.0.7/setup.cfg
Running msgpack-1.0.7/setup.py -q bdist_egg --dist-dir /tmp/easy_install-s3pm6ljt/msgpack-1.0.7/egg-dist-tmp-9o2qa8p4
warning: no files found matching '*.c' under directory 'msgpack'
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
zip_safe flag not set; analyzing archive contents...
msgpack.pycache._cmsgpack.cpython-36: module references file
creating /home/q84sun/miniconda3/envs/vlnce/lib/python3.6/site-packages/UNKNOWN-0.0.0-py3.6-linux-x86_64.egg
Extracting UNKNOWN-0.0.0-py3.6-linux-x86_64.egg to /home/q84sun/miniconda3/envs/vlnce/lib/python3.6/site-packages
Adding UNKNOWN 0.0.0 to easy-install.pth file
Installed /home/q84sun/miniconda3/envs/vlnce/lib/python3.6/site-packages/UNKNOWN-0.0.0-py3.6-linux-x86_64.egg
error: The 'msgpack' distribution was not found and is required by webdataset

Sorry, I posted it in the wrong repo.
My issue is the failure of installation.
I was installing from https://github.com/jacobkrantz/VLN-CE using the code
git clone --branch v0.1.7 git@github.com:facebookresearch/habitat-lab.git
cd habitat-lab
installs both habitat and habitat_baselines
python -m pip install -r requirements.txt
python -m pip install -r habitat_baselines/rl/requirements.txt
python -m pip install -r habitat_baselines/rl/ddppo/requirements.txt
python setup.py develop --all
However, I found this error below:
.....
01bfae789fa566a2be1f385d1/msgpack-1.0.7.tar.gz#sha256=572efc93db7a4d27e404501975ca6d2d9775705c2d922390d878fcf768d92c87
Best match: msgpack 1.0.7
Processing msgpack-1.0.7.tar.gz
Writing /tmp/easy_install-s3pm6ljt/msgpack-1.0.7/setup.cfg
Running msgpack-1.0.7/setup.py -q bdist_egg --dist-dir /tmp/easy_install-s3pm6ljt/msgpack-1.0.7/egg-dist-tmp-9o2qa8p4
warning: no files found matching '*.c' under directory 'msgpack'
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
zip_safe flag not set; analyzing archive contents...
msgpack.pycache._cmsgpack.cpython-36: module references file
creating /home/q84sun/miniconda3/envs/vlnce/lib/python3.6/site-packages/UNKNOWN-0.0.0-py3.6-linux-x86_64.egg
Extracting UNKNOWN-0.0.0-py3.6-linux-x86_64.egg to /home/q84sun/miniconda3/envs/vlnce/lib/python3.6/site-packages
Adding UNKNOWN 0.0.0 to easy-install.pth file
Installed /home/q84sun/miniconda3/envs/vlnce/lib/python3.6/site-packages/UNKNOWN-0.0.0-py3.6-linux-x86_64.egg
error: The 'msgpack' distribution was not found and is required by webdataset

same error


The ID of the R2 class is different from the ID of the R class

problem:
When I use more than two library modules,The ID of the R2 class will different from the ID of the R class.Why the problem is not appear when I use only one library module?
Version: 8.8.1
build.xml:
apply plugin: 'com.android.library'
apply plugin: 'com.jakewharton:butterknife-compiler:8.8.1’

dependencies {
    ......
    compile "com.jakewharton:butterknife:8.8.1"
    annotationProcessor "com.jakewharton:butterknife-compiler:8.8.1"
}

java:
findViewById(R2.id.xxx) // will get null object
findViewById(R.id.xxx) // can get object

//I debug into the code and found R2.id.xxx is not equals to R.id.xxx.

R2 is only for annotations. Use it nowhere else.


Make e2e a separate module

The e2e is part of the main module which creates unnecessary dependencies. Make e2e a separate module to remove this. Update Makefile (and other scripts) that interact with e2e.

Do we need to import operator @akijakya? Is there something specific on why that is the case?

Do we need to import operator @akijakya? Is there something specific on why that is the case?

It is used by the e2e tests to create a patch for the Vault cr so the startup secrets are updated, triggering a reload event. There might be other ways to do it though...


TypeError: pid must be a number

I'm getting this error after updating to the latest version:
prerender-3 (err): /srv/www/prerender/node_modules/prerender/node_modules/tree-kill/index.js:42
prerender-3 (err):         if (err.code !== 'ESRCH') throw err;
prerender-3 (err):                                         ^
prerender-3 (err): TypeError: pid must be a number
prerender-3 (err):     at process.kill (node.js:637:15)
prerender-3 (err):     at killPid (/srv/www/prerender/node_modules/prerender/node_modules/tree-kill/index.js:39:17)
prerender-3 (err):     at /srv/www/prerender/node_modules/prerender/node_modules/tree-kill/index.js:31:13
prerender-3 (err):     at Array.forEach (native)
prerender-3 (err):     at killAll (/srv/www/prerender/node_modules/prerender/node_modules/tree-kill/index.js:23:23)
prerender-3 (err):     at /srv/www/prerender/node_modules/prerender/node_modules/tree-kill/index.js:16:13
prerender-3 (err):     at ChildProcess.<anonymous> (/srv/www/prerender/node_modules/prerender/node_modules/tree-kill/index.js:60:17)
prerender-3 (err):     at ChildProcess.<anonymous> (/srv/www/prerender/node_modules/prerender/node_modules/tree-kill/node_modules/once/once.js:17:15)
prerender-3 (err):     at ChildProcess.emit (events.js:110:17)
prerender-3 (err):     at Process.ChildProcess._handle.onexit (child_process.js:1059:12)

After debugging, it seems to be an issue with tree-kill. I don't know why, but it gets some pid as a strings while some are numbers. I added type coercion to number and it works now. I will post an issue to the tree-kill repo.

Hmm interesting. Were you seeing it every time? Or only once in a while?
What version of node are you on? Just curious in case this crops up again.
Thanks!

@thoop It happens every time, as you can see from the PR https://github.com/pkrumins/node-tree-kill/pull/4 it is caused by error in the tree-kill code, not in Node.
I'm using Node v0.11.14, I guess they added a check to make sure that process.kill pid is a number, which caused this error to crop up.

Ah interesting. Yeah we haven't upgraded to the latest stable version of node yet (0.12)

It has been a month since I submitted a PR and the repo does not seem active so I'm re-opening this issue because I feel that node-tree-kill is not a good dependency.

Can you upgrade to node 0.12.0 and see if this is still an issue? We currently support the previous stable version of node and haven't tried upgrading past version 0.10.31

I will try to find time to upgrade it. I study full time and work part time so there's always something more important to do. I will update when I have tried it.

I totally understand! Have you tried pinging the tree-kill team again? Using that did seem to alleviate our problems with PhantomJS hanging around after it should. Maybe we can find a more elegant way to kill PhantomJS and then call worker.kill() than we were before.

@thoop This module might be a good replacement for tree-kill, https://github.com/indexzero/ps-tree it doesn't offer a kill function, but the readme displays how to use it to kill a process tree.

Interesting. Thanks!

@tuhoojabotti Funny. So I tested process.kill() in 0.10.x and 0.12.x and could not reproduce it. It accepts a string PID without issue. But in 0.11.14 this error happens. In 0.11.16, again, accepts string without complaining. How unfortunate and bizarre.
As node-tree-kill's new co-maintainer, I think I will add this coercion, simply because I would hate a future change in Node or iojs to break this module again.

Thanks @wmhilton  :)

Shouldn't be a problem in our latest version of Prerender (v4.0.3). Feel free to reopen if you run into the same issue.


uses-feature camera2 cause issues with Play Store

I've followed instructions on README and added the following to the AndroidManifest.xml
<uses-feature android:name="android.hardware.camera2.full" />
<uses-feature android:name="android.hardware.camera2.autofocus" />

However, that resulted in 0 compatible devices in Play Store and the inability to install it on any device through the Play Store.
This could be removed from README sparing some trouble to others.
@pedroSG94 was there a reason for these features? It looks like they're non-existing.
I'll be happy to submit a PR, once I get the app approved.
Thanks for the amazing library.

<uses-feature android:name="android.hardware.camera" android:required="false" />
<uses-feature android:name="android.hardware.camera.autofocus" android:required="false"/>

Add android:required="false"

That lines was for this:
https://github.com/pedroSG94/rtmp-rtsp-stream-client-java/issues/58
You can delete it. The library should work without it.

Thanks. I've currently re-uploaded it with only  and getting a crash on start intent with streaming component.
Will investigate further before making conclusions.


Context menu on tray icon of "Report Bug" doesn't do anything

Microsoft PowerToys version
0.78.0
Installation method
PowerToys auto-update
Running as admin
Yes
Area(s) with issue?
System tray interaction
Steps to reproduce

Right-Click on tray icon
Click on "Report Bug"
Wait for message that says "Bug report .zip file has been created on your Desktop"
(Note the space before the extension in the message)

✔ Expected Behavior

A browser or application window to appear to provide bug details, or....
A "Bug Report.zip" file to be created on the desktop, with instructions inside the zip for how to submit?

❌ Actual Behavior

The pop-up appears showing the message "Bug report .zip file has been created on your Desktop"
No file created
Nothing else happens

Other Software
No response

Forgot to add.... our IT organization remaps our desktop folder to OneDrive, if that is relevant.

Does anyone have a fix?


Use Django Roles to determine which experiments can be accessed by users

We may want to expose the admin interface to users, but not give them access to all experiments

@BeritJanssen do you have any scenarios in mind? Perhaps we can write it down in User Story style: As a <type of user>, I want <some goal> so that <some reason>.
Examples:

As an experiment participant, I would like to be able to see my results for the experiments that I have participated in.
As a researcher, I would like to be able to see and download all results for the experiment that I am hosting.
As a researcher-developer, I would like to be able to edit the experiments and playlists for the experiment that I am hosting.

Ah, indeed, this was rather underspecified. The user in question here is a researcher who wants to access their experiment data, while another researchers doesn't want them to be able to access theirs.
Another use for roles would be to distinguish between researchers who can create and edit experiments, while they supervise students who should only be able to download data for their analysis. Deletion rights might be yet another category restricted only to experienced users of the admin interface.


Bug fix: user handling

https://trello.com/c/EIyxewSY
Small bug fixes on adding and update users.
[Users view]

Adds confirm window when trying to add already existing user (update user instead).

[User view]

Adds users tags to input field in update form in user view.

[Both views]

Block adding multiple pre-defined tags (onclick event).
Remove length check when setting hasPassword, response contains null when password_hash missing.

Not sure how to easy determine when and if to add tags from add user form. As for now, always use tags from the input fields when updating existing user. Left empty, no tags will be assign.

Added the tags to the update user form in user view. Was previous always empty, regardless if the user already had assigned tags.

Another annoying thing. It was previous possible to add multiple tags of same type, when using the pre-defined tags in both views.


Sometimes the animation breaks

Sometimes, the JS code computes a clip of rect(5, ...) even though it should be rect(51, ...). This breaks the logo animation.

Can I help with this?

I created a PR for this. https://github.com/xr-muc/co2clock/pull/10
I also made some little improvements.

It's happening again, maybe related to #14...


Removed alt tag property from document download thumbnail

Thumbnail is decorative and does not convey important information to screen readers and has been assigned a null alt attribute to enable screen reading software to disregard it.
Ref: P16 in the DAC Accessibility report.

 Issue #1322: Download thumbnail and similar images shouldn't require alt text, as they are decorative

 Issue #1322: Download thumbnail and similar images shouldn't require alt text, as they are decorative


[YUNIKORN-64] fix zap config creation

Zap logger used the default DEV config instead of our own, changing to our config to get full control.
Cleanup of the init code of the logger including test.
This reverts changes from: YUNIKORN-62

The test written only works if we have a clean go engine to execute it. If we have executed tests before the logger will have been initialised causing the test to fail. Need to re-think how we can test this consistently.

Changes look good. My understanding is, as long as we have fixed the setup issues in k8shim side, we are good. As the core side logging is reusing the configs from k8shim.
These changes are to ensure when the core is not running with our k8shim, we still have a good zap logging setup. Correct?

Changes look good. My understanding is, as long as we have fixed the setup issues in k8shim side, we are good. As the core side logging is reusing the configs from k8shim.

yes for production cases we are good.

These changes are to ensure when the core is not running with our k8shim, we still have a good zap logging setup. Correct?

yes and also during tests.  We need to make sure the tests run a configuration as close to what we do in production. If we would have had that before we would not have seen the panic on a nil in production.

All make sense. +1.
Merging now.


Moved lib/bundler/templates to data/bundler/templates.

This complies with the Ruby Packaging Specification
(http://chneukirchen.github.com/rps/), lib/ is for code data/ is for
static data.
This also prevents YARD from throwing warning as it attempts to parse
Erb .rb files as Ruby code.

@indirect bump

Yeah, this seems like the right thing to do. Rebase plz for application? Thanks!

Rebased!

@postmodern, do you think you could fix the build? I was too quick on the merge button there. ;) http://travis-ci.org/#!/carlhuda/bundler/jobs/819806

Oops. Will work on this tomorrow.


az aks get-credentials - Error

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az aks get-credentials
Errors:
The command failed with an unexpected error. Here is the traceback:
cannot import name 'map_azure_error_to_cli_error' from 'azure.cli.command_modules.acs._helpers' (C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\lib\site-packages\azure\cli\command_modules\acs\_helpers.pyc)
Traceback (most recent call last):
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\knack/cli.py", line 231, in invoke
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/__init__.py", line 556, in execute
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/__init__.py", line 515, in load_arguments
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/__init__.py", line 313, in load_arguments
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\knack/commands.py", line 104, in load_arguments
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/command_operation.py", line 125, in arguments_loader
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/command_operation.py", line 59, in get_op_handler
  File "importlib\__init__.py", line 127, in import_module
  File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 783, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "C:\Users\SM00823089\.azure\cliextensions\aks-preview\azext_aks_preview\custom.py", line 105, in <module>
    from ._helpers import (
  File "C:\Users\SM00823089\.azure\cliextensions\aks-preview\azext_aks_preview\_helpers.py", line 7, in <module>
    from azure.cli.command_modules.acs._helpers import map_azure_error_to_cli_error
ImportError: cannot import name 'map_azure_error_to_cli_error' from 'azure.cli.command_modules.acs._helpers' (C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\lib\site-packages\azure\cli\command_modules\acs\_helpers.pyc)

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az aks get-credentials --resource-group {} --name {}

Expected Behavior
Environment Summary
Windows-10-10.0.19041-SP0
Python 3.8.9
Installer: MSI

azure-cli 2.33.1 *

Extensions:
aks-preview 0.5.70
azure-devops 0.25.0

Dependencies:
msal 1.16.0
azure-mgmt-resource 20.0.0

Additional Context

route to CXP team

@Maheshsanga1405 Apologies for the late reply. Thanks for reaching out to us and reporting this issue. I see that you are using an older version of aks-preview extension and AzCLI version.
Could you please update your aks-preview extension by running the below command ?

az extension update -n aks-preview

On a side note, you should also update your AzCLI to the most recent version. After this, you can try testing your command again. Hope this helps.

@Maheshsanga1405 I wanted to do quick follow-up to check if you had a chance to look at my above comment. Please let us know if you had any updates on this. Awaiting your reply.

@Maheshsanga1405 The action is pending on you to follow the above plan. If you need any further assistance on this issue in future, please feel free to reopen this thread. We would be happy to help.


Release version 0.7.3

@dalthviz, please take care of this one. Afterwards, we could release version 1.0, with the move to Python 3.

Note: Update RELEASE.md before the release


Add Array shuffle / general take using tasks

Implement a shuffle for arrays that can be used as a general take as well.
This is motivated by a groupby like pattern / general take that uses almost random indexes into a single dimension. This currently is done through slicing, which blows up the number of chunks and makes the result mostly unusable. Additionally, it completely overloads the scheduler if you operate a properly random indexer during the actual slicing operation.
Leveraging a shuffle like strategy gives us the option to keep the number of chunks consistent and re-order the array in a way that elements in a dimension are close together if needed.
The API would like (naming tbd):
def shuffle(arr, indexer: list[list], axis, n_chunks=None) -> arr:
    ...

Every inner list specifies a single group. We could take liberties and squash multiple groups into a single chunk without changing the order. Groupby like patterns could then do a shuffle - map_blocks for transformers or high-cardinality groupby ops.
As a first step, we will implement this using the task-based approach.
https://github.com/pydata/xarray/issues/9220
cc @dcherian for feedback

see https://github.com/dask/dask/pull/11076

(precursor: I might be missing something).
I don't think that take_along_axis solves the shuffle problem the way we would want to. We might want to put values from different chunks into the same chunk and potentially reorder between chunks, which won't work with a trivial blockwise based implementation of take_along_axis

Yes I was wrong, we need to optimize take instead of take_along_axis. See https://github.com/pydata/xarray/issues/9220#issuecomment-2256689592

Yeah I think take would call this new API under the hood in cases where it makes sense (a sorted take indexer is better suited to just use the current implementation for example). take is also a bit more general (you can select rows into more than one chunk for example), but the application is very very similar

shuffle and take have both been merged. shuffle probably needs a follow up, but closing here


Add relation label to gene product field

Hi @tmushayahama
I am working on Noctua documentation and in doing so noticed that we don't have a relation for the gene product and MF in the Default form.
Would it be possible to add (MF enabled by) to the right of Gene Product in the Gene Product field?
I think that would complete the relations for all entities and ontology terms in the form.
Thx.

@vanaukenk yes, this one can be safely added as Form 2.0 will not create macromolecular complex on the fly. I think has part terms was the issue


[RFC] Added pin map and session management helper functions to the python measurement template

[x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?
Include the helper methods used in the TestStand example in the measurement template.
Why should this Pull Request be merged?
This will enable measurement authors to reuse the helpers and perform pin map manager and session manager related operations with minimal coding.
This PR is based on the feedback from this discussion.
What testing has been done?

The ni-measurementlink-generator tests are passing.
Built the ni-measurementlink-generator, installed the .whl file and created a measurement.

Why is _helpers.py in the template folder but _internals.py is in the internal folder? It seems like both of these should be in the same folder, maybe called "support" (or something similar).

I feel like _internal.py contains fundamental classes that should be part of the ni-measurement-service package rather than added to the generator measurement.

mypy fails for ni_measurementlink_generator because it is trying to type-check the templates, but ni_measurementlink_generator doesn't depend on the packages used by the templates.
2s
Run poetry run mypy -p ni_measurementlink_generator
ni_measurementlink_generator/templates/internal/_internal.py:7: error: Cannot find implementation or library stub for module named "grpc"  [import]
ni_measurementlink_generator/templates/internal/_internal.py:8: error: Cannot find implementation or library stub for module named "ni_measurementlink_service"  [import]
ni_measurementlink_generator/templates/internal/_internal.py:9: error: Cannot find implementation or library stub for module named "ni_measurementlink_service._internal.discovery_client"  [import]
ni_measurementlink_generator/templates/internal/_internal.py:[1](https://github.com/ni/measurementlink-python/actions/runs/4820178497/jobs/8584315992?pr=252#step:9:1)0: error: Cannot find implementation or library stub for module named "ni_measurementlink_service._internal.stubs.ni.measurementlink.pinmap.v1"  [import]
ni_measurementlink_generator/templates/internal/_internal.py:14: error: Cannot find implementation or library stub for module named "ni_measurementlink_service.measurement.service"  [import]
ni_measurementlink_generator/templates/_helpers.py:3: error: Cannot find implementation or library stub for module named "ni_measurementlink_service"  [import]
ni_measurementlink_generator/templates/_helpers.py:3: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
ni_measurementlink_generator/templates/_helpers.py:4: error: Cannot find implementation or library stub for module named "nidcpower"  [import]
ni_measurementlink_generator/templates/_helpers.py:5: error: Cannot find implementation or library stub for module named "nidmm"  [import]
ni_measurementlink_generator/templates/_helpers.py:6: error: Cannot find implementation or library stub for module named "nifgen"  [import]
ni_measurementlink_generator/templates/_helpers.py:7: error: Cannot find implementation or library stub for module named "niscope"  [import]
ni_measurementlink_generator/templates/_helpers.py:8: error: Cannot find implementation or library stub for module named "niswitch"  [import]
Found [11](https://github.com/ni/measurementlink-python/actions/runs/4820178497/jobs/8584315992?pr=252#step:9:12) errors in 2 files (checked 7 source files)
Error: Process completed with exit code 1.

Potential solutions:

Rename _helpers.py to _helpers.py.mako
Update [tool.mypy] in pyproject.toml to set exclude = "templates/" or something similar that works.

General feedback. For validating with users we need to show what the impact is on the resulting measure.py. It's hard to see from the template.py changes. If we aren't ready for that then can we show the impact it would make on a shipping example?

Are we done with this PR? If so, please close it.


Glow color doesn't work in 2.0.0

I changed the color to gold, green, red....
But it's always white :P

Weird, it works when i try it. Ill look further into it.

It was in 2.0.0, I'll give it a try again in 2.0.1 and give u an notice.
Give me some minutes.

It bugs more then before :D

Are you sure you are using the right version of the plugin? API5 for 1.10.2, API6 for 1.11 and API7 for 1.12. Which version are you using?

Using API 6 for 1.11.2 :) Maybe it's bc of an shader?

Hi, just thought I'd add to this - I ran into the same issue of glow color not working on API 6 and defaulting to white. I found it occurs whenever I try to name the NPC anything other than the default "Steve". I am using version 2.0.2 of the mod.


confirm overwrite story

Pull Request Test Coverage Report for Build a2116b7de0bfc688dfae6ce605c0b85f976350b5-PR-300
Details

12 of 43 (27.91%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-3.5%) to 90.746%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/mix/tasks/dog.gen.stories.ex
12
43
27.91%

Totals

Change from base Build d815c46c49e95b347422650ee053b8dbd23195be:
-3.5%

Covered Lines:
657

Relevant Lines:
724

💛  - Coveralls


Create new labels

From issue-tracker-2020-1 created by sodemir: KodstarBootcamp/issue-tracker-2020-1#2
a label consists of a name and a color code

Closed since duplicate with #45

Closed since duplicate with #45


Support DataFrame.collect for Ballista DataFrames

Which issue does this PR close?

Closes #787.
Rationale for this change

A DataFrame from a BallistaContext should work just like a DataFrame from a DataFusion ExecutionContext. The user should be able to directly call execution methods such as collect.
What changes are included in this PR?

DataFrames created by Ballista have a custom query planner that can create Ballista physical plans.
Are there any user-facing changes?

Yes - the user no longer needs to call BallistaContext::collect.

I will plan to review this tomorrow

This is a really nice structure 👍

Thanks. It was nice that I didn't have to make any changes to DataFusion to make this work.


Debug the roles function using the local auth emulator

Is your feature request related to a problem? Please describe.
Enable local dev for role management through serverless functions
Describe the solution you'd like
Test programmatically assigned roles in local environment
Describe alternatives you've considered
Call the auth function locally with something like Postman to ensure it responds with the right roles given an input.
Use the local emulator to set custom roles at login to test how your app works with different roles.
Additional context
Tutorial: Assign custom roles with a function and Microsoft Graph

related

Possible duplicate of #306

I will look at this post-GA.
The current workaround is to print a warning if we detect the auth in the staticwebapp.config.json

What is the current status of this? I was attempting to enable role management and test locally. I expected my GetRoles function to be called but it wasn't after login. I was able to call GetRoles directly. I was hoping not to debug in a live SWA deployment.
I'm using SWA CLI ver 1.01 and C#(.net6).

Hi @c0g1t8,
We have this in our radar and will be working on this shortly. We do not have a timeline yet to commit this, but you should be seeing some update in a couple of months.
cc// @sgollapudi77

Is there any update on this?

I'd like to second this - any progress so far? At the moment trying to debug is not possible for me, as issues only seem to occur in prod, and not on a local dev machine.

I added a hack locally to<EMAIL_ADDRESS>and changed the form.submit to the following
  // store cookie info as base64
      form.submit(() => {
        event.preventDefault();
        fetch('/api/roles', {
          method: 'POST', body: JSON.stringify({
            userId: form.find("#userId").val(),
          })
        })
          .then(x => x.json())
          .then(x => {
            saveCookie(form);
            redirectToApp();
          });

      });

it's not perfect (eg you could forward on more details from the form to the roles method (and pull the roles method from the config).

Can potentially also use a
{
      "route": "/.auth/login/azureb2c/",
      "rewrite": "/auth.html"
    },

to replace the login file without manually editing


copy single row from log view

Hello,
is it possible to copy a single data record in the log display ?
Best regards
Stephan

@jesseduffield
Sorry to @ you directly, but I've been wondering the same, any way to select the log text?

sorry for the late response. To do this, I typically will hold cmd+option and drag my cursor over the text to select it. If the text spans several lines, I'll press 'm' to have the logs takeover the screen so that I can copy the lines as I would normally in a terminal

i have the same issue, i cannot copy text using text cursor, i am running ubuntu focal and lazydocker 0.18

Under Linux you can select from within Lazydocker with Shift+LeftMouseButton and Paste with MiddleMouseButton.


Check dependencies Error

when I run on Simulator, It's ok.But run on iPhone,It's show the "check dependencis"error.
Detail:
"Check dependencies
CodeSign error: code signing is required for product type 'Framework' in SDK 'iOS 9.3'"'
How to fix this?Thanks

@JolieYang  you try this: http://stackoverflow.com/questions/29836356/ios8-dynamic-frameworks-codesign-error-code-signing-is-required-for-product
In this case, you try signing to framework.

we just merged swift 3 support https://github.com/kickstarter/ios-oss/pull/26 and so now xcode 8.2 can be used. This may fix the problem.
closing this for now, let us know if you have any questions.


Adding Many Sequences to Graph Crashes with Memory Error

Dear Bifrost Team,
I recently discovered a bug using the Bifrost API for one of my own programs. It led to a memory error and a crash of the program. The bug appears when iteratively calling the add function of a ColoredCDBG object.
I have attached a minimal code example
and an input file (hard coded inside my code) to reproduce the issue. Unfortunately, the issue is not reproducible on all machines on which I tested.
Do you have a clue what is going on here? Is it really a bug in Bifrost or am I doing something wrong?
Any help is greatly appreciated.
Best,
Tizian

The bug does not yet seem to occur using Bifrost version 1.2.1.

Hi Tizian,
Sorry for the late answer, I've been on holidays when you first reached out and I haven't managed to find the time since I came back. I appreciate you reported this issue and provided a minimal example for this. To be accurate, this currently does not work (sometimes) for the latest version of Bifrost (currently 1.3.5) but seems to work with 1.2.1? Did you try to run some Valgrind on this minimal example to see if there were some incorrect memory access? Should be super fast to run given how short is the minimal code/input. You'll have to compile Bifrost in Debug mode for that.
I am currently rather busy at work and I don't know when I'll be able to take care of this issue. Hopefully soon. There is also a branch named bifrost-fastNegativeQueries which is in theory the next version of Bifrost and which should work just fine. I haven't been able to work on it for some time but it is possible it solves some of the issues that were introduced in 1.3.5 if there were any.
Guillaume

Hi Guillaume,
welcome back! I hope you had some nice holidays. :)
Yes correct, I have tested the minimal example on different Linux servers and some virtual machines in our cloud. It does not crash on all machines, but on those machines where it crashes once, it crashes always.
I have also seen other strange things going on on machines where the minimal example runs through. Things like a graph written to disc using the API which cannot be read afterwards anymore or $k$-mers extracted from a graph which cannot be found in it if you query for them using CompactedDBG<Unitig_data_t, Graph_data_t>::find. It looks like Bifrost's internal data structures are getting compromised somehow.
I have checked out branch bifrost-fastNegativeQueries, but the issue seems to persist. The minimal code example crashes here as well.
I also used branch bifrost-fastNegativeQueries for a run of Valgrind. This is what the program says.
Tizian


282 checklist round review show question

PR for #282
Changes in this PR include-

Showing round evaluation questions
Storing round evaluation feedback
Marking round review questions as checked and show comments if filled in previous round
Seeder to add round evaluation feedback to resume screening rounds

@bohraji can you add some description on what changes you made in this PR?

Please mention the issue here. Also, I see that there's no description on the issue as well. It's a bit difficult to figure out the requirements.

@rathorevaibhav I have updated the info on the PR.

Checked this PR :

[ ] For duplication.
[ ] For performance.
[ ] Usage of recursive methods, loops, and algorithms.
[ ] For readability and understanding.
[ ] For functions with multiple responsibilities.
[ ] For scope of refactoring.
[ ] For coupling
[ ] For alternative approaches to the implementation.
[ ] For how the change impacts other parts of the system.
[ ] For validations. client side and server side validations are present.

For more insights on code reviews checkout our guidelines.

@rathorevaibhav updated PR. Have a look.


Add more customization

Customize the font/color of item's title/subtitle, the font of title & button. Removed dynamic font.

This looks good! Could you please add back the dynamic type font sizes if the device is running iOS 10 or higher? Somewhere after or in configureUI you should use the following code:
if #available(iOS 10, *) {
  titleLabel.font = UIFont.preferredFont(forTextStyle: .title2)
  subtitleLabel.font = UIFont.preferredFont(forTextStyle: .body)
}

Added refreshFonts back, although I don't think it's nessesory when we can customize fonts.

Thank you @nixzhu for your contribution! 🎉


.editorconfig: Enforce tabs across repository

Rust files were already using tabs for indentation. Adding an explicit
.editorconfig file helps editors auto indent.

Friendly review ping on this one as well. Hope you don't mind @NikVolf.

Last ping here @NikVolf. Any objections to this change?


Ability to ignore Firebase/Google service or update README.md on how to create one in Firebase Console

Problem
When first starting this boilerplate, we'll get a build error that we're missing a google-services.json which we must acquire from Firebase Console.
It's not a frustration that much, but for novice users it may be misleading.
My suggested solution(s)
A clear and concise description of what you want to happen.
I would like an easy code-wise ability to fully ignore using Firebase Services (aka. google-services.json) for the time being, or to provide a guideline how to create one.
This could be a template for it: https://support.google.com/firebase/answer/7015592?hl=en
Alternatives
As described above, two of those solutions should suffice anyone, if not, maybe a way to remove Firebase entirely (someone might not need it at all)

Maybe the posibility to include a dummy file of services.json to start with out errors

I've added my google-services.json file in the latest repo, take it as a dummy, atleast the errors won't appear.


feat: support dual stack deployment of istio

Please provide a description of this PR:
Fixes: https://github.com/istio/istio/issues/44017

@Xunzhuo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
edd23e15dd43a0a49be61c8675c3277332883523
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@Xunzhuo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
edd23e15dd43a0a49be61c8675c3277332883523
link
true
/test integ-ambient

integ-ds_istio
edd23e15dd43a0a49be61c8675c3277332883523
link
true
/test integ-ds

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Xunzhuo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote_istio
1bd36db3ddd5039296334dd79436de7c12008c11
link
true
/test integ-pilot-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Xunzhuo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote_istio
1bd36db3ddd5039296334dd79436de7c12008c11
link
true
/test integ-pilot-istiodremote

integ-ds_istio
1bd36db3ddd5039296334dd79436de7c12008c11
link
true
/test integ-ds

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Besides the istiod service deployment, there should be others need to be considered, such as ingress gateway, etc.

@Xunzhuo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote_istio
1bd36db3ddd5039296334dd79436de7c12008c11
link
true
/test integ-pilot-istiodremote

integ-ds_istio
ac0d01bbbb5c86321ee13c69915c271c193a83b2
link
true
/test integ-ds

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Xunzhuo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ds_istio
3f9bf4b3326791ec6ca6090e2f1ef0c1695c68cc
link
true
/test integ-ds

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Xunzhuo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ds_istio
ac0d01bbbb5c86321ee13c69915c271c193a83b2
link
true
/test integ-ds

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Xunzhuo will you update it later? thanks,

@Xunzhuo @zhlsunshine I realize that more configuration is necessary, but it seems that something like this is required to be able to terminate IPv6 at the external gateway -- which is a much more common use case that IPv6 inside the mesh.


Add support for locale search

You can prepend !<locale-code> to the search query. For example, !id long polling or !zh +webhook/+. If no locale-code is specified, English will be used by default.

Oops! Wrong branch


derive Debug by default

Could be gated behind a feature flag. Not sure. What do you think?

@HerrMuellerluedenscheid I like the idea. Maybe instead of a feature flag it could be a runtime configuration (parameter) as well. Maybe someone does not need Serialize or Debug but other derives. Maybe it depends on the xml you want to convert. What do you think?


Faceting with uniform/semiuniform occasionally produces non-semiuniform faces

specifically, this is when a semiuniform face plane has a symmetry under which it is no longer isogonal, so you can get weird non-isogonal facetings of the semiuniform face used in the polyhedron. unsure of how much this extends to higher dimensions.

it's the element types algorithm's fault


Add DualStack support

Carry on from https://github.com/containerd/cri/pull/1272.
For https://github.com/kubernetes/kubernetes/issues/82634
This PR adds dual stack support in PodSandboxStatus and UpdateRuntimeConfig.
Several things worth noting:

2 new values .PodCIDRRanges and .Routes are supported in the cni config template. .PodCIDRRanges is a string array of all CIDRs assigned to the node; .Routes is a string array of all routes needed. They can be used to config CIDRs for dualstack in the ipam plugin, e.g.:

      "ipam": {
        "type": "host-local",
        "ranges": [{{range $i, $range := .PodCIDRRanges}}{{if $i}}, {{end}}[{"subnet": "{{$range}}"}]{{end}}],
        "routes": [{{range $i, $route := .Routes}}{{if $i}}, {{end}}{"dst": "{{$route}}"}{{end}}]
      }

IPv6 is enabled by default in the CNI config used in the CRI test and integration test. However, please note that pod startup will become slower when IPv6 is enabled, see https://github.com/containerd/cri/pull/563#issuecomment-359618326
The CNI config used in the cluster/node e2e test is also updated to use .PodCIDRRanges. However, IPv6 dual stack should only be enabled when IPv6DualStack feature gate is enabled in Kubernetes, so it shouldn't cause performance issue right now.

Anyway, please note that Enabling IPv6 will slow down pod startup, we may want to warn user about that in the release note.
/cc @aojea

Switch golangci-lint to v1.18.0 because of the OOM issue (see https://github.com/containerd/containerd/pull/3657)

SGTM
I'd love to test first it in kind though, but the build fails with the following error:

containerd: symbol lookup error: containerd: undefined symbol: seccomp_api_set

does this version has new dependencies?

@Random-Liu the pods that were created before the containerd upgrade doesn't report the additional IPs after restarting containerd, is this the expected behavior?

@aojea Yeah, that is expected. We get the ips when creating the pod, and then checkpointed the IPs. For old pods, we don't have the checkpoint.

/lgtm

Apply LGTM based on https://github.com/containerd/cri/pull/1274#pullrequestreview-290937107


Support cgroup v2

Proposed Changes

Support cgroup v2.
This PR does not add support for rootless cgroup yet. Rootless cgroup will be supported in a separate PR soon.
Types of Changes

New Feature (?)
Verification

Boot Ubuntu 20.10 with kernel cmdline systemd.unified_cgroup_hierarchy=1
Run sudo k3s server
Run sudo k3s kubectl get pods -A, and confirm that no error is happening

Linked Issues

Further Comments

rebased


Error("missing field httpMethod)

This happens on a basic example when testing through api gateway. When I test lambda it works, but when testing through GW this happens...

Is this correct in the go sdk?


usage of the cell abundance scores

I would like to use the estimated cell abundance from res$beta.
Can I use these cell abundance scores to compare across multiple samples?
Can I use these cell abundance scores between cell-types in a patient sample?
Thank you!

Can I use these cell abundance scores to compare across multiple samples?

yes!
Can I use these cell abundance scores between cell-types in a patient sample?
yes, but with less certainty. This comparison depends on the columns of the cell profile matrix correctly representing the total RNA content in each cell type. We have made every effort to ensure this with the safeTME, but our solution is undoubtedly imperfect.


Adjust broker locking order slightly

I was doing an unrelated experiment with a config that generated a warning on
validation, and I ended up flooded with warnings because we now call Open on
every broker returned from the Client, and we were revalidating the config every
single time. One thing led to another and I made several other adjustments in
the same vein.

Move the atomic AlreadyConnected check to before the config validation in
Broker.Open. Config validation is expensive and can log, no point in doing
it if we don't have to.
Move all the atomic.StoreInt32 calls to after any of their related log
messages. None of these were real problems, but it removes any possibility of
out-of-order log messages due to unusual race conditions.
Remove the double-check for AlreadyConnected after we've taken the full
lock. Initially I just removed the log message since it's not something we
need to log, but upon closer inspection I'm pretty sure this is dead code;
anything that sets opened to 0 also sets conn to nil first, and does so
while holding the lock.

@wvanbergen

:+1:


Ubuntu mirror can be parameterized

Add ability to parametrize Ubuntu mirror according current location.
Can be done as build argument for docker build command
E.g.
--build-arg UBUNTU_MIRROR=ubuntu.ethz.ch

Is there anything missing that prevents you accepting this pull request?

Oh, I forgot this one. Sorry.


Controlling more node types

Fixes https://github.com/Deltares/Ribasim/issues/398.

Here is the draft for parsing the static data for control, currently only applied to Pump.


A raw descriptor creation interface for the unvault

This is based on #10 (itself base on #15 ...), see:

cd829a3
5feaa58

This adds an interface to fix #14 .
Good news: we can apparently support threshold-based managers set.
Question news: what now ?

Ack 5feaa58fde48cb0d960778d3885fed82a42bca5f

Rebased after #10 rebase.

Thanks!

Actually it's that i (apparently) did not move it as part of the test mod.
And fwiw: bitcoin::consensus != libbitcoinconsensus.

Rebased after #10 rebase.

Rebased on master after #10 merge.


Test webhook on deployed infrastructure

Currently the tests are running locally in pytest.
There should be an additional test that deploys the webhook into Cloud Functions along with the Eventarc trigger, and it should simply upload a document and wait for a successful processing. This test would fail if a code change or dependency upgrade requires more memory in the Cloud Function deployment.
The existing "local" test is still useful to get logs for debugging.

Use gs://arxiv-dataset/arxiv/cmp-lg/pdf/9505/9505005v2.pdf for this test, it's a large document with 20 pages that requires several GiB to process


extends not working for generics as expected

TypeScript Version:  2.6.2
Code
Playground link
function function1<T extends 'a' | 'b'>(key: T) {
  switch (key) {
    case 'a': {
      console.log(key);
      return [];
    }
    default:
      console.log(key);
      return [];
  }
}

function function2(key: 'a' | 'b') {
  switch (key) {
    case 'a': {
      console.log(key);
      return [];
    }
    default:
      console.log(key);
      return [];
  }
}

(Obviously this is a minimal example, and in real work code I'd have multiple parameters using the type T in their types.)
Expected behavior:
I would expect that in either case key is of type 'a' | 'b'.
Actual behavior:
In actuality in the first example (function1 ) I have key: T extends "a" | "b" and inside the case 'a' branch key is of type never.
Alternatively maybe I'm using extends wrong, but I can't seem to find a way of specifying that T is either 'a' or 'b'. For example if I have function function1<T extends 'a' | 'b'>(key1: T, key2: T) { then I'd like to be able to specify that key1 and key2 are of the same type (either both 'a' or both 'b').

It seems extremely strange, at the least, that in the first function, key gets narrowed to never.

Yes, definitely not right that key is narrowed to never. The following should not error:
function function1<T extends 'a' | 'b'>(key: T) {
  switch (key) {
    case 'a':
      key.toLowerCase();  // Error, but shouldn't be
      break;
    default:
      key.toLowerCase();
      break;
  }
}

With the fix in #20882 the type of key is no longer narrowed in the switch statement. That is the intended behavior and matches what happens if the same logic is written as if (key === 'a'). We currently don't narrow constrained type parameters and thus, even after the fix, key isn't narrowed to type 'a' in the first example.
When a type parameter T includes a unit type U in its constraint, we could consider making U assignable to T and allow narrowing of T to U. However, that is larger change beyond the scope of this issue.


[AIRFLOW-2453] Add default nil value for kubernetes/git_subpath

Make sure you have checked all steps below.
JIRA

[ ] My PR addresses the following Airflow JIRA issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-XXX
In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a JIRA issue.

Description

[ ] Here are some details about my PR, including screenshots of any UI changes:

Tests

[ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

[ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Documentation

[ ] In case of new functionality, my PR adds documentation that describes how to use it.

When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

[ ] Passes git diff upstream/master -u -- "*.py" | flake8 --diff

Codecov Report

Merging #3350 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3350   +/-   ##
=======================================
  Coverage   76.22%   76.22%
=======================================
  Files         198      198
  Lines       14788    14788
=======================================
  Hits        11272    11272
  Misses       3516     3516

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8002760...bff139f. Read the comment docs.


add space before AM/PM timepicker

How can I modify the format that timepicker displays when I pick a time. I cannot parse the time because there is no space between the time and AM/PM

@poltographer6 Can you provide a codepen for this? And also elaborate what exactly you are trying to achieve?


Search problem in Semitic languages

Describe your problem
The search problem doesn't work properly for Semitic languages such as Persian and Arabic
Expected behavior
Search for exact words and articles
Actual behavior
Search results are actually unclear
Steps to reproduce the problem
Use Persian article to reproduce the problem
http://loremsaz.com/
Bludit version
3.8

Hi,
can you do the test in the demo site ?
https://demo.bludit.com
I created a page with the title ایپسوم then using the search plugin and I found the page.

Hello Diego,
Yes, you are right, it is OK with just one article, but if there is more than one article, it lists all of them.
https://screencast-o-matic.com/watch/cqenFa0FSP
P.S: I created 3 articles, the last 2 articles created automatically, I dunno why.

I had same issue in Vietnamese. Search plugin cannot return results
Test here
https://haykhoinghiep.com/search/marketing

Hi guys, sorry for my late answer, I improve the Fuzz algorithm to support UTF8, if you have time please test it.
https://github.com/bludit/bludit/commit/7c8bad72c574b1d2a3cd1b499f7672e231973ea3

You can download the plugin search from here, https://github.com/bludit/bludit/tree/master/bl-plugins/search

Hello Diego,
This is a very improving update, Thank you, But it needs more improvement, I mean the plugin is not smart enough, e.g: it can find the word "hello" , but it can't find the word "hello!" (in Persian I mean) , you should put all character together  to find the second word, anyway it's a great job, and I need to test more

Ok is a good point, can you give me a few examples to create two pages with some keywords and try to search ?

Could you use these words please,
`
جوملا
وردپرس
ساده
آسان
اسان
سوال؟
کلمه
قالب
پلاگین
سلام!
حال شما چطوره
چطوری؟
only the two first words are searchable, but in other words not! I don't know why.جوملا
وردپرس`
These two words are fine with the plugin

@dignajar
I have this problem too :frowning_face:

Hello, with the new version of Bludit v4.0 rc1, I would like to close the old Github issues. If you feel that your issue is not resolved in the latest version, create a new ticket.

Help and Support use the Forum https://forum.bludit.org
Bugs and new requests here in Github https://github.com/bludit/bludit/issues


issue

hii , nice work ,
i am getting following error
[ERROR] [1690993664.822849]: bad callback: <bound method Subscriber.callback of <message_filters.Subscriber object at 0xfffe947033a0>>
Traceback (most recent call last):
File "/opt/ros/noetic/lib/python3/dist-packages/rospy/topics.py", line 750, in _invoke_callback
cb(msg)
File "/opt/ros/noetic/lib/python3/dist-packages/message_filters/init.py", line 76, in callback
self.signalMessage(msg)
File "/opt/ros/noetic/lib/python3/dist-packages/message_filters/init.py", line 58, in signalMessage
cb(*(msg + args))
File "/opt/ros/noetic/lib/python3/dist-packages/message_filters/init.py", line 330, in add
self.signalMessage(msgs)
File "/opt/ros/noetic/lib/python3/dist-packages/message_filters/init.py", line 58, in signalMessage
cb((msg + args))
File "/app/test/src/yoloandopn/src/yoloopepcdetros.py", line 489, in combined_callback
scores, dt_box_lidar, types, pred_dict = proc_1.run(np_p, lidar_msg.header.seq)
File "/app/test/src/yoloandopn/src/yoloopepcdetros.py", line 454, in run
data_dict = self.demo_dataset.prepare_data(data_dict=input_dict)
File "/app/test/src/yoloandopn/src/OpenPCDet/pcdet/datasets/dataset.py", line 180, in prepare_data
data_dict = self.point_feature_encoder.forward(data_dict)
File "/app/test/src/yoloandopn/src/OpenPCDet/pcdet/datasets/processor/point_feature_encoder.py", line 29, in forward
data_dict['points'], use_lead_xyz = getattr(self, self.point_encoding_config.encoding_type)(
File "/app/test/src/yoloandopn/src/OpenPCDet/pcdet/datasets/processor/point_feature_encoder.py", line 48, in absolute_coordinates_encoding
assert points.shape[-1] == len(self.src_feature_list)
AssertionError
where is 00002.bin file

how about trying the docker?

hii thanks for reply. i want to try without docker  and it has to deploy in edge device


Change every KernelComputedField to KernelFunctionOperation

@glwagner do you see any problems downsides for this? If I understand correctly the migration will only bring upsides:

Simpler (no need for @kernel and @index)
KernelAbstrations won't be a dependence anymore
Resulting quantities are abstract operations, which are more flexible

I don't see any downsides. You'll only need KernelComputedField to do fairly non-trivial things in a kernel like unroll loops, etc.

Good. Then I'll probably start some migration soon.
I haven't used KernelFunctionOperation so I'm not familiar, but I guess if we use user-facing constructors they would return the operation itself, right? (They wouldn't return, for example, a ComputedField based on the operation, right?)

Hrmm yeah I think the minimal / easy to maintain API returns the operations and let users build ComputedField or AveragedField according to their needs.


I wonder why the code psconv.py are not consistent with the description in the paper?

x1, x2 = x.chunk(2, dim=1)
x_shift = self.gwconv_shift(torch.cat((x2, x1), dim=1))
return self.gwconv(x) + self.conv(x) + x_shift

I think the code is simply add with different dilation.

Because this code implementation is fake!The author of this code has been found to have falsified papers！！！I wasted two nights studying this shit！


Feature: Add action output to indicate if something happened

Type of feature
💡 Feature
Current behavior
We have workflows running reacting on set labels.
If a GitHub action assigns a label, no workflow is run

Suggested solution
Thus, I need a way to run another step if someone was assigned.
Draft: I would like to have if steps.assign.outputs.assigned == "yes" as condition for my next step. I would just use the same steps as when the label was manually assigned
https://github.com/JabRef/jabref/blob/25635de59496e2765ccfab19c07e91b6c48067a4/.github/workflows/on-labeled-issue.yml#L49
(This wish is similar to https://github.com/bdougie/take-action/issues/27 for the take-action).
Additional context
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Contributing Docs

[ ] I agree to follow this project's Contribution Docs

@takanome-dev Yes 🤩🤩 👍


add dropzone addedfiles event

I understand I can use the addedfile event but sometimes it's handy to use addedfiles to process all dropped files together.

Thanks for this patch @andrewharvey , I'll merge it in and post back when a new version has been released to npm.
Good to see you getting some use of this little component and getting into Vue, hope you're keeping well :)

Published to npm in v2.2.5

Thanks @rowanwins . Yes been busy lately, getting into Vue a lot more now so was really happy to see you released this component :smile:


Add intro and purpose

Description of why I created a blog in the first place.

@codejaeger self-review.


VNF: fix UI bugs and polish

Description
This PR fixes some UI bugs and polish

vnfapp details page is empty if there is no vnfnics defined. see https://github.com/apache/cloudstack/pull/8227/commits/b042fd3370b56eda5b00532ff2a83c1ba3a42392
Failed to add vnfapp details, no vm details options, and no tags. see https://github.com/apache/cloudstack/pull/8227/commits/36873c87367cedd9cacff8ec6721576c350fad55
Failed to migrate vnfapp due to wrong API passed. see https://github.com/apache/cloudstack/pull/8227/commits/4fd8a07a29ade2a2f5acd7e05ac2b03f957f1cd7
The first network is marked as Default in the summary when deploy a vnf appliance. see https://github.com/apache/cloudstack/pull/8227/commits/6261088923b1c1027ffb4addc53fd2451d6b1774
Remove attribute 'icon' from VNF detail options as it is similar as resource icon. see https://github.com/apache/cloudstack/pull/8227/commits/ebdd67d16c24f32fc0e1ebd327530ba62d088006

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)
[ ] build/CI

Feature/Enhancement Scale or Bug Severity
Bug Severity

[ ] BLOCKER
[ ] Critical
[x] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

How did you try to break this feature and the system with this change?

@blueorangutan package

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7728

@blueorangutan package

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7732

@blueorangutan package

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7746

@NuxRo @harikrishna-patnala
thanks for review. I have made 2 more small changes to this PR
this is ready for review and merge (if everything is ok)

@blueorangutan package

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15.  It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7786

[SF] Trillian test result (tid-8354)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44010 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8227-t8354-kvm-centos7.zip
Smoke tests completed. 118 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File


tests fail due to large amount of output with highish tests.iters

Description
I've noticed that some tests fail when tests.iters is set to a highish value (like 20) because stdout grows above the allowed threshold. I assume this is something we'd want to fix, but I'm not clear how to go about it exactly. Some tests I've seen fail are:  TestDemo.testIndexSearch (IndexFiles outputs the names of files as they are added to the index); TestIndexWriter.testDocValuesMixedSkippingIndex (prints a stack trace, I think it's expected?); TestTransactions  prints out an iteration count. We could work on reducing the amount of printing, but I wonder if the test framework should ideally multiply the acceptable stdout threshold by the iters?
Version and environment details
all versions, probably

Example failing test output:
org.apache.lucene.demo.TestDemo.classMethod (:lucene:demo)
    Test output: /local/home/sokolovm/workspace/lucene/lucene/demo/build/test-results/test/outputs/OUTPUT-org.apache.lucene.demo.TestDemo.txt
    Reproduce with: gradlew :lucene:demo:test --tests "org.apache.lucene.demo.TestDemo.classMethod" -Ptests.jvms=8 "Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:+UseParallelGC -XX:ActiveProcessorCount=1" -Ptests.seed=8CEBA6D040DDF9D3 -Ptests.iters=20 -Ptests.gui=false Ptests.file.encoding=UTF-8 -Ptests.vectorsize=default -Ptests.forceintegervectors=false

There is something about the way TestDocInverterPerFieldErrorInfo.testNoExtraNoise captures the info-stream that causes it to always fail when test.iters > 1.  This whole situation makes me wonder if we should occasionally run with tests.iters > 1 in some CI setting just to catch test issues like this where test fixtures leak across runs.


How do I identify which replica a client tcp connection is on, and how do I route messages with rpc to that replica？

I wrote the tcp server example and the single-process mode is fine. The new question is, in the multi-process, multi-machine, or multi-replica deployment, how do you find out which replica a given client tcp connection is on? How do you route messages to this tcp connection?
Http is used for request-response services, but for push, notification, chat, pub-sub and other types of services are based on tcp connections, and messages must be routed to the specified client tcp connection.

I looked at the Weaver project source code and found no relevant object and API exposure. If so, Weaver is only suitable for HTTP-based applications.

@wind-c, you can interact with a Service Weaver application based on whatever you can export a listener. Our examples expose a http server, but you can use something else too (e.g., a grpc server).
Now, for communication between different components we use RPCs on top of TCP. The weaver runtime is responsible to start components, and component replicas and propagate their addresses to all the other components that want to talk to.
What exactly are you trying to do?

Maybe I don't understand weaver's architecture. So there's this doubt.
I have written a tcp server example, the code file is attached.

The single process deployment worked fine:
D:\GolandProjects\ServiceWeaver> weaver single deploy weaver.toml
╭───────────────────────────────────────────────────╮
│ app        : hello.exe                            │
│ deployment : a1becea0-ac30-48f5-98a8-34861380a8c3 │
╰───────────────────────────────────────────────────╯
hello listener available on <IP_ADDRESS>:8080
app deployment_id:  e19d61b9-2b19-4b9e-9bfa-6ecc3376b2cf
wait for the client to connect ...
hello listener available on <IP_ADDRESS>:8080
reverse deployment_id:  e19d61b9-2b19-4b9e-9bfa-6ecc3376b2cf
Hello, 44605:<IP_ADDRESS>1!
wait for the client to connect ...
<IP_ADDRESS>:50644 client is connected！
server received the data： hello
D:\GolandProjects\ServiceWeaver> .\client.exe
hello
client received data： HELLO

The multi-process deployment is abnormal:
D:\GolandProjects\ServiceWeaver> weaver multi deploy weaver.toml
╭───────────────────────────────────────────────────╮
│ app        : hello.exe                            │
│ deployment : 293b392b-d73d-445e-9183-b8bb971d438e │
╰───────────────────────────────────────────────────╯
S0101 08:00:00.000000 stdout               457a567f                      │ hello listener available on <IP_ADDRESS>:8080
S0101 08:00:00.000000 stdout               91d737a8                      │ hello listener available on <IP_ADDRESS>:8080
S0101 08:00:00.000000 stdout               457a567f                      │ app deployment_id:  293b392b-d73d-445e-9183-b8bb971d438e
S0101 08:00:00.000000 stdout               457a567f                      │ wait for the client to connect ...
S0101 08:00:00.000000 stdout               91d737a8                      │ app deployment_id:  293b392b-d73d-445e-9183-b8bb971d438e
S0101 08:00:00.000000 stdout               91d737a8                      │ wait for the client to connect ...
D:\GolandProjects\ServiceWeaver> .\client.exe
hello
client received data： HTTP/1.1 400 Bad Request
Content-Type: text/plain; charset=utf-8
Connection: close
400 Bad Request
server is down and the client is also down.

Got it.
The problem is the way you're trying to send requests from the client to the server using raw TCP in case of the multi deployer. Our multi deployer implementation uses a HTTP proxy to export the hello listener, and under the hood the HTTP proxy will send the client request to one of the server replicas. Server replicas accept traffic using TCP, however, because the HTTP proxy speaks HTTP, when you send a raw TCP message the HTTP proxy gets confused and returns a BAD Request. I believe that we're using a HTTP proxy in case of the SSH deployer as well.
However, Service Weaver DOES NOT make any assumptions about the kind of traffic you can send as long as it's TCP traffic. For example, if you try your example with the Kube deployer, it will work just fine. Same for the GKE deployer.
So:

Service Weaver framework should handle any kind of traffic as long as it's TCP based
the fact that multi doesn't work for your example, is because the way we implemented the multi deployer. However, you can modify the multi deployer to have a proxy that accepts raw TCP requests (or implement your own); I will look at this thing as well, but it's not a high priority right now.
It's on my list to provide examples on how to do raw TCP and grpc traffic and hopefully will get to that soon (that might also be an opportunity to enhance the multi deployer to support raw TCP requests)
you can use the Kube deployer to run it locally in multiple processes for now. Otherwise you can tweak multi for  your usecase

Is this something that blocks you to deploy weaver in production or just playing around on your local machine?

I see.
I still hope that you can support the compatibility of the original TCP in various deployment modes, because you are more professional. Although Kube and GKE are commonly used, they are not suitable for all deployment scenarios.
Another question:

Will do. However, it's not a priority short term, because the multi deployer is intended to be used mostly for testing on the local machine. However, if this blocks you from adopting Service Weaver in production, please let us know.
Listeners are intended to be the way you interact with a Service Weaver application. In your example, the main component exports a listener that receives requests.
Number of replicas per component - the deployer computes the number of replicas. In case of multi, each component is replicated twice. The GKE/Kubernetes deployers rely on Kubernetes autoscalers to scale up/scale down then number of replicas based on load (a combination of cpu and memory usage on each pod).

@rgrandl ，thank you very much for your reply.
I really appreciate the architecture and the idea of ServiceWeaver.
I'm eager to refactor my project Comqtt(https://github.com/wind-c/comqtt) using ServiceWeaver.
My project is tcp-based mqtt broker, so supporting raw tcp in a multi-process and multi-machine deployment mode will greatly speed up my refactoring and testing.

This work has been deprioritized for now


Jaxrs2 ContainerParser Producer missing in Wildlfy 20

Describe the Bug
Starting Wildfly 20 with an application using Braves jaxrs2 I get these errors:
Unsatisfied dependencies for type HttpTracing with qualifiers @Default and
Unsatisfied dependencies for type ContainerParser with qualifiers @Default
Expected Behaviour
Works out of the box.

I'm curious what you are expecting to happen in Brave? To provide a fully configured tracing component is out of scope from consuming one, for example.
None of our instrumentation that use HttpTracing also provide it. Configuration layers should do that similar to https://github.com/smoketurner/dropwizard-zipkin
It is a good question about the ContainerParser thing. I don't know the universal pattern of providing an optional NoOp. If you can advise in a way that doesn't break others, that advice would be welcome!

Hi, for the ContainerParser I would litterly do:
@ApplicationScoped
public class BraveContainerParserProducer {

    @Produces
    @Dependent
    ContainerParser produceContainerParser() {
        return new ContainerParser();
    }
}

and for HttpTracing perhaps:
    @Produces
    @Dependent
    HttpTracing produceHttpTracing() {
        return HttpTracing.current();
    }

so brave-jaxrs definitely shouldn't produce the HttpTracing component. that is out of scope.
ContainerParser is reasonable, but we have to make sure it doesn't break something else, and that the solution is relevant for JAX-RS 2 (let's remember this can also be used in normal servlet)
Right now, there's no optional injection in the "Inject" annotation. Other containers I suppose are providing ContainerParser because it has a public no-arg constructor. That is effectively an implementation of optional injection.
Ex.
  public ContainerParser() { // intentionally public for @Inject to work without explicit binding
  }

That said, our README mentions that you need to indicate this as a singleton anyway, just in case implicit binding doesn't work.  The problem here is we are limited to jax-rs 2.0 compatible mechanics. If there's another approach that works, we can try it. You can test if it works by editing ITSpanCustomizingContainerFilter.TaggingBootstrap and removing the following:
          return new LinkedHashSet<>(Arrays.asList(
            resource,
            SpanCustomizingContainerFilter.create() // << this
          ));

Meanwhile, likely a CDI based example will help us navigate this.

https://github.com/openzipkin/brave-example/pull/39 shows a start of a CDI + microprofile example. I'm not in tune enough with this space to know what is actually needed nowadays as there seems to be yet another abstraction small rye also.
Someone who cares and is interested to complete above would be welcome!


Version v0.3.4 RC

:package: :rocket:

This change is

Builds ready [fac4ba6]builds: chrome, firefox, opera
bundle viz: background, ui, inpage, contentscript, ui-libs, bg-libs, phishing-detect
dep viz: background
all artifacts


Check content named selector

http://stackoverflow.com/questions/7614813/mink-selectors-any-way-to-get-the-element-in-base-of-the-content-inside/7658423#7658423

content works totally correct - it returns first page element, that contains specified content. In most cases it's <html/> :-)


[RELEASE] Console  v0.28.0

Console v0.28.0 has changes that impact the docs:

[x] ~Users can now share objects using an embedded service account access key PR #2827~
[ ] Fix for NGINX config for Console at a subpath PR #2818
[ ] Fix for a potential security issue with the right-to-left unicode character PR #2828

PR 2827 is being reverted to implement better a fields and flows. Do not doc.

Partially addressed with https://github.com/minio/docs/pull/921

No place to discuss 2828 outside of Github where it's already done.


Key prefixes

So we can identify keys and key identifiers without other context.

Stuff to consider:

ease of grepping
easy way of demarcating example keys

Done in #62 #66.


Activate the GitHub App Stale on the GitHub repository

This change is

Codecov Report

Merging #78 into dev will not change coverage.
The diff coverage is n/a.

@@        Coverage Diff        @@
##           dev   #78   +/-   ##
=================================
  Coverage   62%   62%
=================================
  Files        2     2
  Lines      307   307
=================================
  Hits       191   191
  Misses     116   116

Reviewed 1 of 1 files at r1.
Review status: :shipit: complete! all files reviewed, all discussions resolved

Comments from Reviewable


Add crypto_scalarmult_base

Implements crypto_scalarmult_base which can be used to compute the public key given a secret key previously generated with crypto_box_keypair().
Reference: https://libsodium.gitbook.io/doc/public-key_cryptography/authenticated_encryption#key-pair-generation

Thanks for the PR.
Not a big issue, but I think it is a good idea to keep function argument names consistent with the original libsodum names. In this particular case, names are q and n.
Also, can you spare some more time and add a test case in the companion project react-native-sodium-example?


Replace all Gitter community links with Discord

In all repos and websites, the links for Gitter should be replaced by the following Discord links, like: https://github.com/casbin/casbin

casbin: https://discord.gg/S5UjpzGZjN
casdoor: https://discord.gg/5rPsrAzK7S
casnode: https://discord.gg/d8dsAWgn43
gsoc: https://discord.gg/PD9g8wE6X9
gsod: https://discord.gg/z5TZyJC5uv

Because therer are so many repos, we may need a program to do it automatically.

For comparison, here are the badges in repo

Available styles are as follows:

I prefer
To display the number of online users, the following settings are required

Details
Official

[![Discord](https://discord.com/api/guilds/1125382348737884200/widget.png)](https://discord.gg/ayhmjFeZ9)

Shields
refer to https://shields.io/badges/discord

[![Discord](https://img.shields.io/badge/discord-join%20chat-5865F2?logo=discord)](https://discord.gg/ayhmjFeZ9)

[![Discord](https://img.shields.io/discord/1125382348737884200?label=discord&color=5865f2)](https://discord.gg/ayhmjFeZ9)

[![Discord](https://img.shields.io/discord/1125382348737884200?logo=discord&label=discord&color=5865F2
)](https://discord.gg/ayhmjFeZ9)

[![Discord](https://img.shields.io/discord/1125382348737884200?style=flat-square&logo=discord&label=discord&color=5865F2
)](https://discord.gg/ayhmjFeZ9)


patch-soaib

Description

Release required?

[ ] No release
[ ] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

/run pipeline

fixed in https://github.com/terraform-ibm-modules/terraform-ibm-watsonx-saas-da/pull/101


Handle wrong store name on OAuth flow

Currently if you use the register endpoint for starting the OAuth flow with a store and you fail to provide a valid store name the following error is thrown:
raise ValueError(f'{shop} is not a shopify shop')
Which is not handled gracefully on the front end (it throws a 500 internal server error). I think this should probably be some sort of return on this error?

This will be handled in the new oauth flow #46


More tests

Coverage increased (+1.09%) to 86.296% when pulling e0248174c7d44d1238282abc011c18ef6ab7df2f on sni/add-test-to-smoothie-2 into 4cab464c8354d8623de125df2ca01756527487d5 on master.


Add Capabilities to deploy GKE Jmeter on existing VPC

We would like to deploy Jmeter GKE on existing VPC for security and networking design practices.

Machmeter creates a VPC and a subnet inside it using Terraform. Terraform does not have the capability to detect existing resources which do not exist in the .tfstate file.
In order to support this, a different Terraform template will be required which does not attempt to create a VPC network and subnet and instead uses the user specified value.
Currently Machmeter does not support multiple Terraform templates basis the user configuration, and instead deploys a single template.
We will need to look into constructing terraform templates based on the user input to support this requirement. This will likely require restructuring portions of the code base.


Possibility to set port and set selfPeerAddress

Added possibility to set port and possibility to set selfPeerAddress. This is must have thing for services that runs in docker.

Also update dependencies, to use latest versions


Cant import via ESM

This might be user error on my part, if so I'd be really grateful to know what I'm doing wrong.
When I do this import TomSelect from 'tom-select';
I get
ReferenceError: navigator is not defined
    at \myproject\node_modules\tom-select\dist\js\tom-select.complete.js:728:28

Ignoring the precise error for a moment, this shows that the esm packages havent been loaded, but instead its used the commonjs ones.
This article seems to explain the situation well, but I dont know enough about npm or this project to recommend a course of action: https://2ality.com/2019/10/hybrid-npm-packages.html
Then, on to the error.
This is the offending line:
	const IS_MAC = /Mac/.test(navigator.userAgent);
Can we modify the codebase so its not talking to the global navigator? Or otherwise, what is my solution to import tomselect in a bundling scenario and not encounter this error?

const IS_MAC = typeof navigator === 'undefined' ? false : /Mac/.test(navigator.userAgent);
That seems a sensible solution?

Looks good. I'll get the added in just a minute.

Great, thanks!
Looking forward to the release ;)

All set!

Excellent, thanks!


[question] build error no input files

I am trying to build football on Centos 7 and am running into a build error at the super(CustomBuild, self).run() line in setup.py. It looks like the building under third_party/gfootball_engine goes fine. The full log is here: https://gist.github.com/esquires/f085e1fdb7d4b8c75183a59e1fe239ea
I originally tried building with anaconda although got some memory issues at runtime so I decided to build python, boost, and sdl2 from source. This meant I needed to make a slight adjustment to the build process with diff pasted here:
diff --git a/third_party/gfootball_engine/CMakeLists.txt b/third_party/gfootball_engine/CMakeLists.txt
index 8c825ec..a4a88ff 100644
--- a/third_party/gfootball_engine/CMakeLists.txt
+++ b/third_party/gfootball_engine/CMakeLists.txt
@@ -2,6 +2,8 @@ cmake_minimum_required(VERSION 3.1)

 set(PACKAGE gameplayfootball)

+# set(CMAKE_CXX_FLAGS " -fPIC ${CMAKE_CXX_FLAGS}")
+
 set(VERSION_MAJOR 0)
 set(VERSION_MINOR 2)
 set(VERSION_PATCH 0)
@@ -41,7 +43,9 @@ FIND_PACKAGE(SDL2_gfx REQUIRED)
 include_directories(${SDL2_GFX_DIRS})

``
+find_package(PythonInterp 3.7 REQUIRED)
 find_package(PythonLibs 3 REQUIRED)
+set(BOOST_ROOT /gv1/users/esquires3/smarl)
 message("Using Python: ${PYTHONLIBS_VERSION_STRING}")
 string(REPLACE "." ";" VERSION_LIST ${PYTHONLIBS_VERSION_STRING})
 list(GET VERSION_LIST 0 PYTHON_MAJOR)
@@ -126,7 +130,7 @@ add_library(menulib ${MENU_SOURCES} ${MENU_HEADERS})
 add_library(datalib ${DATA_SOURCES} ${DATA_HEADERS})

 set(LIBRARIES gamelib menulib datalib blunted2
-   Boost::filesystem Boost::system Boost::thread Boost::${BOOST_PYTHON_VERSION} ${PYTHON_LIBRARY}
+   ${Boost_LIBRARIES} ${PYTHON_LIBRARY}
    ${SDL2_IMAGE_LIBRARIES} ${SDL2_TTF_LIBRARIES} ${SDL2_GFX_LIBRARIES}
    ${SDL2_LIBRARIES} ${OPENGL_LIBRARIES})
 add_library(baselib OBJECT ${BASE_SOURCES} ${BASE_HEADERS}

Do you know why the final step to building the extension would fail when the building under third_party would fail or where I should look to debug? I have built the repo on Ubuntu 1804 and found that the source tree under football/build is the same as what I have for Centos 7 right before the super(CustomBuild, self).run() line except for the following 3 files which are present in the Ubuntu build:
feature_tests.bin
feature_tests.c
feature_tests.cxx

Here are 2 dockerfiles demonstrating the issues on Centos 7. The first dockerfile uses anaconda and runs into the same issue as https://github.com/google-research/football/issues/97. The second builds python (and other dependencies) from source and is not able to build football at all.
Let me know if I should change something for either dockerfile to get it running on Centos 7.
This first dockerfile has the same problem as https://github.com/google-research/football/issues/97.
FROM centos:7

WORKDIR /root

# general dependencies
RUN yum group install -y "Development Tools"
RUN yum install -y wget mesa-libGL-devel git libSM

# install anaconda
WORKDIR /root
RUN wget https://repo.anaconda.com/archive/Anaconda3-2020.02-Linux-x86_64.sh
RUN bash Anaconda3-2020.02-Linux-x86_64.sh -b

# create new env
RUN source ~/anaconda3/bin/activate && conda create -n smarl python=3.6 anaconda

# football build dependencies
RUN source ~/anaconda3/bin/activate && conda activate smarl && conda install -y boost pyopengl cmake
RUN source ~/anaconda3/bin/activate && conda activate smarl && conda install -y -c conda-forge sdl2 sdl2_image sdl2_ttf sdl2_gfx

# install football
RUN git clone https://github.com/google-research/football
WORKDIR /root/football
RUN source ~/anaconda3/bin/activate && conda activate smarl && conda install cmake
RUN source ~/anaconda3/bin/activate && conda activate smarl && pip install .

# football runtime dependencies
RUN source ~/anaconda3/bin/activate && conda activate smarl && conda install -y -c conda-forge xorg-libxrender
RUN source ~/anaconda3/bin/activate && conda activate smarl && conda install -y tensorflow-gpu==1.15.0
RUN source ~/anaconda3/bin/activate && conda activate smarl && pip install "dm-sonnet<2.0.0"
RUN source ~/anaconda3/bin/activate && conda activate smarl && pip install git+https://github.com/openai/baselines.git@master
RUN source ~/anaconda3/bin/activate && conda activate smarl && python3 -m gfootball.examples.run_ppo2 --level=academy_empty_goal_close

This second dockerfile has the following error:
    building 'brainball_cpp_engine' extension
    gcc -pthread -shared -fPIC -o build/lib.linux-x86_64-3.6/brainball_cpp_engine.cpython-36m-x86_64-linux-gnu.so
    gcc: fatal error: no input files
    compilation terminated.
    error: command 'gcc' failed with exit status 4

Here is the second dockerfile:
FROM centos:7

WORKDIR /root
RUN mkdir build srcs

WORKDIR srcs

CMD ["/bin/bash", "-c"]
ENV PATH="/root/build/bin:${PATH}"
ENV CPLUS_INCLUDE_PATH="/root/build/include:${CPLUS_INCLUDE_PATH}"
ENV C_INCLUDE_PATH="/root/build/include:${C_INCLUDE_PATH}"
ENV C_INCLUDE_PATH="/root/build/include/python3.6m:${C_INCLUDE_PATH}"
ENV CPLUS_INCLUDE_PATH="/root/build/include/python3.6m:${CPLUS_INCLUDE_PATH}"
ENV LD_LIBRARY_PATH="/root/build/lib:${LD_LIBRARY_PATH}"
ENV CFLAGS=" -fPIC "
ENV CXXFLAGS=" -fPIC "

RUN yum install -y openssl openssl-devel
RUN yum group install -y "Development Tools"
RUN yum install -y zlib-devel wget which

RUN curl https://www.python.org/ftp/python/3.6.10/Python-3.6.10.tgz -o Python-3.6.10.tgz
RUN tar xf Python-3.6.10.tgz
WORKDIR Python-3.6.10
RUN ./configure --prefix=/root/build --enable-optimizations
RUN make -j
RUN make altinstall

# venvs
RUN mkdir /root/venvs
RUN python3.6 -m venv /root/venvs/smarl
RUN source /root/venvs/smarl/bin/activate && pip install -U pip wheel setuptools

# boost
WORKDIR /root/srcs
RUN wget https://dl.bintray.com/boostorg/release/1.65.1/source/boost_1_65_1.tar.gz
RUN tar xf boost_1_65_1.tar.gz
WORKDIR boost_1_65_1

# venvs
RUN ./bootstrap.sh --prefix=/root/build --with-python=$(which python3.6) --with-python-version=3.6 --with-python-root=/root/bin/python3.6 --with-libraries=python,filesystem,thread,system
RUN ./bootstrap.sh --prefix=/root/build --with-python=$(which python3.6) --with-python-version=3.6 --with-python-root=/root/bin/python3.6 --with-libraries=python,filesystem,thread,system,chrono,date_time,atomic

RUN ./b2 install -j $(nproc --all)

# sdl2
WORKDIR /root/srcs
RUN wget https://www.libsdl.org/release/SDL2-2.0.12.tar.gz
RUN tar xf SDL2-2.0.12.tar.gz
WORKDIR SDL2-2.0.12
RUN ./configure --prefix=/root/build && make -j12 && make install

WORKDIR /root/srcs
RUN wget https://www.libsdl.org/projects/SDL_image/release/SDL2_image-2.0.5.tar.gz
RUN tar xf SDL2_image-2.0.5.tar.gz
WORKDIR SDL2_image-2.0.5
RUN ./configure --prefix=/root/build && make -j12 && make install

RUN yum install -y freetype-devel
WORKDIR /root/srcs
RUN wget https://www.libsdl.org/projects/SDL_ttf/release/SDL2_ttf-2.0.15.tar.gz
RUN tar xf SDL2_ttf-2.0.15.tar.gz
WORKDIR SDL2_ttf-2.0.15
RUN ./configure --prefix=/root/build && make -j12 && make install

WORKDIR /root/srcs
RUN wget http://www.ferzkopp.net/Software/SDL2_gfx/SDL2_gfx-1.0.4.tar.gz
RUN tar xf SDL2_gfx-1.0.4.tar.gz
WORKDIR SDL2_gfx-1.0.4
RUN ./configure --prefix=/root/build && make -j12 && make install

# cmake
WORKDIR /root/srcs
RUN wget https://github.com/Kitware/CMake/releases/download/v3.17.2/cmake-3.17.2.tar.gz
RUN tar xf cmake-3.17.2.tar.gz
WORKDIR cmake-3.17.2
RUN ./bootstrap --prefix=/root/build
RUN make -j12
RUN make install

# football environment
WORKDIR /root/srcs
RUN yum install -y git
ENV SDL2DIR="/root/build"
RUN git clone https://github.com/google-research/football
WORKDIR football
RUN yum install -y mesa-libGL mesa-libGL-devel
RUN echo 'hi'
COPY ./boost_diff.diff .
RUN git apply boost_diff.diff
RUN source /root/venvs/smarl/bin/activate && pip install .

Here is boost_diff.diff referenced in the second dockerfile:
diff --git a/third_party/gfootball_engine/CMakeLists.txt b/third_party/gfootball_engine/CMakeLists.txt
index 8c825ec..748f015 100644
--- a/third_party/gfootball_engine/CMakeLists.txt
+++ b/third_party/gfootball_engine/CMakeLists.txt
@@ -2,6 +2,8 @@ cmake_minimum_required(VERSION 3.1)

 set(PACKAGE gameplayfootball)

+set(CMAKE_CXX_FLAGS " -fPIC ${CMAKE_CXX_FLAGS}")
+
 set(VERSION_MAJOR 0)
 set(VERSION_MINOR 2)
 set(VERSION_PATCH 0)
@@ -51,8 +53,8 @@ list(GET VERSION_LIST 1 PYTHON_MINOR)
 # Unfortunately different linux distributions are using different naming.

 # Ubuntu
-FIND_PACKAGE(Boost COMPONENTS python3-py${PYTHON_MAJOR}${PYTHON_MINOR})
-if (Boost_PYTHON3-PY${PYTHON_MAJOR}${PYTHON_MINOR}_FOUND)
+FIND_PACKAGE(Boost COMPONENTS python REQUIRED)
+if (Boost_PYTHON_FOUND)
   set(BOOST_PYTHON_VERSION python3-py${PYTHON_MAJOR}${PYTHON_MINOR})
 else()
   message("python3-py${PYTHON_MAJOR}${PYTHON_MINOR} not found. Trying other names.")
@@ -76,7 +78,7 @@ endif()

 message("Using python_boost: ${BOOST_PYTHON_VERSION}")

-FIND_PACKAGE(Boost REQUIRED COMPONENTS thread system filesystem ${BOOST_PYTHON_VERSION})
+FIND_PACKAGE(Boost REQUIRED COMPONENTS thread system filesystem python)
 include_directories(${Boost_INCLUDE_DIR})

 include_directories(${PYTHON_INCLUDE_DIR})
@@ -126,7 +128,7 @@ add_library(menulib ${MENU_SOURCES} ${MENU_HEADERS})
 add_library(datalib ${DATA_SOURCES} ${DATA_HEADERS})

 set(LIBRARIES gamelib menulib datalib blunted2
-   Boost::filesystem Boost::system Boost::thread Boost::${BOOST_PYTHON_VERSION} ${PYTHON_LIBRARY}
+   ${Boost_LIBRARIES} ${PYTHON_LIBRARY}
    ${SDL2_IMAGE_LIBRARIES} ${SDL2_TTF_LIBRARIES} ${SDL2_GFX_LIBRARIES}
    ${SDL2_LIBRARIES} ${OPENGL_LIBRARIES})
 add_library(baselib OBJECT ${BASE_SOURCES} ${BASE_HEADERS}

I am also trying to install gfootball on centos and ran into some problems.
Have you solve this problem now?  If so, can you share your solution?


Add prometheus console config

Does the README need updating to use this?

Very likely; I don't really know how it works with the docker setup though - I did this with a stand-alone prometheus install.