Fix 1059 - TaskRun controller update status and labels on error

Changes
TaskRun controller update status and labels even when an error occurs.
As described in https://github.com/tektoncd/pipeline/issues/1059 the TaskRun controller, in case an error is received from reconcile, fails to update the status. The comments in the code even suggest this behaviour, but the implementation does not match them. This PR fixes that.
These are the criteria that every PR should meet, please check them off as you
review them:

[ ] Includes tests (if functionality changed/added)
[n/a] Includes docs (if user facing)
[x] Commit messages follow commit message best practices

See the contribution guide for more details.
Double check this list of stuff that's easy to miss:

If you are adding a new binary/image to the cmd dir, please update
the release Task and TaskRun to build and release this image

Reviewer Notes
If API changes
are included, additive changes
must be approved by at least two OWNERS
and backwards incompatible changes
must be approved by more than 50% of the OWNERS,
and they must first be added
in a backwards compatible way.
Release Notes
N/A - no API changes.

/approve remove

/approve cancel

/test pull-tekton-pipeline-integration-tests

Question about the use cases for this - from #1059:

When reconcile returns an error, there status, labels and annotations of the TaskRun/PipelineRun should still be sync'ed back.
In case of error, the error is returned, and no update happens.
There is only a little number of cases where this is relevant; nonetheless it should be fixed and unit test coverage added

I want to double check that we actually want to update the status in this case. I can't really think of a reason not to, however just to make sure we're on the same page about the behaviour if you look at how Reconcile is called (https://github.com/knative/pkg/blob/1a3a36a996dec7645bee7084153ef8b7273e1028/controller/controller.go#L299) if an error is returned, the item will get queued again (so theoretically it wouldn't stay in this state very long
i think part of the reasoning behind not trying to update the status also might be that if something is wrong in the underlying system, then there's a good chance the attempt to update the status itself will fail. using the multierror should at least avoid hiding that error, but im just not 100% clear that its worth updating the status

OK, I see your point. In my understanding there are two types of failures that may happen during a reconcile, recoverable and unrecoverable (or transient vs permanent). All validation type of failures - e.g. a Task is not found or a Param does not match the spec - are considered unrecoverable. When they are encountered, reconcile updates the Condition and returns nil - a change in the status is detected and the status is sync'ed via API. In very few cases reconcile returns an error:

failure to initialize the artifact storage - which could be transient
in case cancelPipelineRun fails
when createTaskRun fails
when c.makeConditionCheckContainer fails

Is it correct that the last three are "recoverable"? In any case like you said Reconcile will propagate the error and the item will be re-queued, so Reconcile will be invoked again.
I cannot think of an update that could have happened that we would miss in the next reconcile cycle, but I cannot either say I'm sure there is none, so I still think it may be worth having this.
It may be worth adding some documentation to reconcile so that it's more obvious when writing and reviewing code, when reconcile should and should not return and error.
BTW, there is also the case of dag.GetSchedulable where the error is logged but reconcile continues. I need to check further to see if that's the expected behaviour.

It may be worth adding some documentation to reconcile so that it's more obvious when writing and reviewing code, when reconcile should and should not return and error.

I think that's a really good idea - I had to go and track down the code in knative/pkg to double check :S

BTW, there is also the case of dag.GetSchedulable where the error is logged but reconcile continues.

That doesn't sound right :sweat_smile:

Is it correct that the last three are "recoverable"?

I guess it's hard to say! It would depend probably on what caused the issue - I think my rule of thumb would be if the error was something related to the user's actions (i.e. something user did incorrectly), it's "unrecoverable", but if it's not the user, if it's the underlying system (e.g. the service account running the pipelinerun controller cant create TaskRuns or something) then it's "recoverable"

Is it correct that the last three are "recoverable"? In any case like you said Reconcile will propagate the error and the item will be re-queued, so Reconcile will be invoked again.

The code assumes that these errors such as those from makeConditionCheckContainer are recoverable, and are re-queued. In #1427 we ran into a case where the error was not recoverable (a validation error when creating the container). However, since we never updated the status, and the condition was the first thing to run, users saw a blank status until the pipelinerun timed out an hour later. This leads me to think that we should attempt to update the status even when we think error is "recoverable".

I think this should be good to go once we ensure that merr is not a global variable.

Fixed that and rebased

I think this should be good to go once we ensure that merr is not a global variable.

Done!


fix: update to eye v9.10.2

fix: update to eye v9.10.2

:tada: This PR is included in version 12.9.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release
v12.9.2

Your semantic-release bot :package::rocket:


Add PHPDoc for the handlers

The handlers are currently lacking a bit of documentation on the various callback methods.

Handled in #56 and #57, finally.


Add utility: min-height

Give it the usual values and breakpoints settings. If possible, being able to specify fill-available would be great, something like
.u-min-h-fill-available {
  min-height: 100vh;
  min-height: -webkit-fill-available;
}

Also needed in defaults is min-height :0;


Text selection and scrolling is slow

Type: Performance Issue

Issue troubleshooting has identified that the issue is with Visual Studio Code.

I can reproduce it by opening a 1000-2000 line file and being on battery saver mode.
On insiders (1.86.0-insider 279872bd965e4030c81129a9bf1ce1710ff7cd55) it's still slow, but seems a bit faster than 1.85.1.
VS Code version: Code 1.85.1 (0ee08df0cf4527e40edc9aa28f4b5bd38bbff2b2, 2023-12-13T09:47:11.635Z)
OS version: Linux x64 6.6.7-arch1-1
Modes:

System Info

Item
Value

CPUs
11th Gen Intel(R) Core(TM) i7-1185G7 @ 3.00GHz (8 x 1299)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: disabled_softwarevulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
1, 1, 1

Memory (System)
15.34GB (9.22GB free)

Process Argv
--unity-launch --crash-reporter-id 38cc4293-5223-4300-8642-8985386ac132

Screen Reader
no

VM
0%

DESKTOP_SESSION
gnome

XDG_CURRENT_DESKTOP
GNOME

XDG_SESSION_DESKTOP
gnome

XDG_SESSION_TYPE
wayland

Process Info
CPU %	Mem MB	   PID	Process
    0	   157	 14352	code main
    0	    47	 14355	   zygote
    0	   189	 14391	     gpu-process
    0	    47	 14356	   zygote
    0	     0	 14358	     zygote
    0	   456	 14433	window [1] (command.rs - engine-test - Visual Studio Code)
    0	    94	 15931	window [2] (Issue Reporter)
    0	    63	 14396	   utility-network-service
    0	   110	 14452	shared-process
    0	    79	 15671	fileWatcher [1]
    0	   126	 15955	extensionHost [1]
    0	    63	 15975	     electron-nodejs (/opt/visual-studio-code/code --ms-enable-electron-run-as-node /opt/visual-studio-code/resources/app/extensions/json-language-features/server/dist/node/jsonServerMain --node-ipc --clientProcessId=15955)

Workspace Info
|  Window (command.rs - engine-test - Visual Studio Code)
|    Folder (engine-test): 14093 files
|      File types: bin(1982) gltf(1696) o(1587) bc(1552) json(813)
|                  timestamp(810) d(760) rmeta(692) rlib(369) rs(346)
|      Conf files: launch.json(1) settings.json(1) tasks.json(1)
|      Launch Configs: cppvsdbg lldb;

Extensions: none
A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30410667
py29gd2263:30899288
vsclangdf:30486550
c4g48928:30535728
dsvsc012cf:30540253
azure-dev_surveyone:30548225
282f8724:30602487
f6dab269:30613381
showlangstatbar:30737416
fixshowwlkth:30771522
showindicator:30805244
pythongtdpath:30769146
i26e3531:30792625
welcomedialogc:30910334
pythonnosmt12:30797651
pythonidxpt:30866567
pythonnoceb:30805159
asynctok:30898717
dsvsc013:30795093
dsvsc014:30804076
dsvsc015:30845448
pythontestfixt:30902429
pyreplss1:30897532
pythonmypyd1:30879173
pythoncet0:30885854
2e7ec940:30885897
pythontbext0:30879054
accentitlementst:30887150
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
aa_t_chat:30882232
dsvsc019cf:30917260
cp7184c:30925681

I searched for the version where the performance got worse and it seems it's the 1.75.1 version. 1.74.3 is fast. Insider version performs about the same as 1.75.1.

Could you please follow the steps at https://github.com/microsoft/vscode/wiki/Performance-Issues#profiling-the-renderer-process and capture a CPU profile?

Saving the profile fails with NotAllowedError, this is probably an Electron bug.
Some screenshots of the capture:

The task I zoomed in takes 120ms, and the 2nd screen is zoomed in even more around 12s.

You're right, Insiders has been updated to Electron 27 and suffers from https://github.com/microsoft/vscode/issues/200668 . Could you please capture a profile with stable?

That was 1.85.1 with Electron 25.9.7.
But I'll check tomorrow if I can save it somehow.

Profile-20231225T084134.zip
I made a profile with 1.81.1, this is the most recent version where it didn't fail.


[job-status] 🛢 Track completed steps on Job model

https://trello.com/c/nrONKfRn
And push when they change on the model.

Outstanding questions:

[ ] How does this help us resume a partial install?
[ ] How does the frontend get the job ID back so it can view progress, given that the job is sent through an enqueuer?

Answers:

"Resume" is just "Trigger the job again, with a skip list of "all the steps you've already completed". This will require some backend work to ensure that if there's a (recent?) job that already shows some steps completed, then those steps are always skippable on new jobs.
When you POST to make a new Job, you get back the Job's id. You can then query that endpoint (or listen to the websocket) to get updates to the completed_steps attribute.

OK, 2. is done in this branch.
I think 1. will require actually enforcing required steps, and then excepting that based on the previously run jobs.

I'd love to merge this before worrying about the frontend piece, as I've discovered that there's work in #93 that relies on it, and sending additional information to the frontend shouldn't break anything.


M3U Playlist Plugin example broken

Just noticed the M3U Playlist Plugin example is broken, the M3U file is no longer hosted at the location it points to.

because it's a codepen when can't edit it cc @entonbiba

We should probably remove the playlist pen from the site, cc @sundayz @katspaugh

@thijstriemstra fixed, it will now use demo.wav and stereo.mp3 from the media folder.

@thijstriemstra fixed, it will now use demo.wav and stereo.mp3 from the media folder.

#2155 fixed

#2155 fixed


[MM 40414] : Update empty states to align with new branding and changes in empty state copy

Summary
Update empty states to align with new branding and changes in empty state copy
Ticket Link
Fixes https://github.com/mattermost/mattermost-server/issues/19325
Fixes https://mattermost.atlassian.net/browse/MM-40414
Related Pull Requests
n/a
Screenshots

Release Note
UI: Empty state icons changes and related text copy changes.

Hello @VishakhaPoonia,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@VishakhaPoonia thanks for the PR! Is it ready for review?

@esethna No there are few changes left will try to close those today. Thanks

@esethna Pr is ready for review, Thanks for waiting.

For the search results empty state, can we use proper “ and ” characters for the search term?
@matthewbirtch Are you mentioning quote style, I checked in Figma you are using Metropolis font, in code we are using the same font. I can think of 2 scenario’s

Either only name is same and font used here and in Figma are different,
Font isn’t getting downloaded.

For the search results empty state, can we use proper “ and ” characters for the search term?

@matthewbirtch Are you mentioning quote style, I checked in Figma you are using Metropolis font, in code we are using the same font. I can think of 2 scenarios

Either only name is same and font used here and in Figma are different,
Font isn’t getting downloaded.

The font is correct - that's not the problem. You just need to update the quote characters to change from using " to proper opening and closing quote marks “ and ”

Adding @AshishDhama for a second dev review

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@hmhealey Have updated the Pr, please take look.

/test-e2e

I haven't taken a super deep look on this, but I'll trust @larkox and @AshishDhama's judgment here

cc// @jgilliam17 for QA review

Thanks @VishakhaPoonia
Tested manually and changes look good.
One question for UX @matthewbirtch the new graphic in dark themes doesn't show the icon "shadow" as it does in light theme. Is that ok?

Quite a few E2Es  are failing due to wording changes pinned posts > pinned messages, save > save message etc. Can you please take a look and fix the failing tests? Thanks 🙂

One question for UX @matthewbirtch the new graphic in dark themes doesn't show the icon "shadow" as it does in light theme. Is that ok?

Yes, @jgilliam17 this is expected.

Removing cloud test server for maintenance reasons. Please feel free to add it again if needed.

@VishakhaPoonia Let me know if you need any help with E2Es that failed due to the changes in this PR.

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@VishakhaPoonia let us know if you're still working on this?

@VishakhaPoonia are you able to help with teh E2E's? This PR is really close, I'd love to get it across the finish line!

@esethna Yeah I will take care of this weekend, Thanks for the reminder.

/update-branch

@VishakhaPoonia I will handle the E2e tests so we can merge this this week. Really appreciate the work you did for this feature 💯

@nevyangelova thanks @nevyangelova for the help, I do have some progress either I will create a new pr or update this one by tomorrow. If that will work.

@nevyangelova thanks @nevyangelova for the help, I do have some progress either I will create a new pr or update this one by tomorrow. If that will work.

ok we can wait no worries.

@nevyangelova thanks @nevyangelova for the help, I do have some progress either I will create a new pr or update this one by tomorrow. If that will work.

@VishakhaPoonia thanks for the great work - please keep us posted on this!

@nevyangelova have updated test cases, if you can take a look I am very new to e2e

@VishakhaPoonia thanks for updating. I see some quotes being inserted by accident it seems? Also @saturninoabril can confirm if the tests look good.
For unit tests that are failing you can run npm test -- -u

/e2e-test

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/220345

Thanks @VishakhaPoonia
Few tests are still failing. See full report here
Here are few spec files that need updating, this may not be a complete list - please check the linked report.
e2e/cypress/tests/integration/messaging/tooltips_on_top_nav_channel_icons_posts_spec.js
e2e/cypress/tests/integration/accessibility/accessibility_buttons_spec.js
e2e/cypress/tests/integration/search/clear_input_spec.js
e2e/cypress/tests/integration/search/cleared_search_term_spec.js
For test case MM-T4801, I think the change here appears to be accidental
We should continue to display “Save” on post menu in mobile view and not "Save Message" @matthewbirtch  can you please confirm

We should continue to display “Save” on post menu in mobile view and not "Save Message" @matthewbirtch can you please confirm

@jgilliam17 yes it should just be "Save", but I don't think this has anything to do with this PR though does it?

Thanks @matthewbirtch - Just checking if this was an intentional change. I agree this is not within scope of this PR, but it seems to have been accidentally changed during text updates.

@VishakhaPoonia some minor conflicts need to be resolved otherwise this is ready to go!

@nevyangelova Thanks will take care of this tomorrow.

@VishakhaPoonia how's this going? :)

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

/e2e-test

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/246975

@jgilliam17 @esethna It’s ready for testing

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@jgilliam17 Have resolved the conflicts. Could you please help me get this merged?

Thanks @VishakhaPoonia
Few tests are failing, see full report here
If you need help with Cypress please ask here or reach out in QA channel
Here are all cypress test cases that need to be updated with the new text:
MM-T1461 aria label should be updated to Pinned Messages
MM-T1722 test should look for "Select to toggle a list of Saved Messages"
MM-T3659 test should look for "Select to toggle a list of Saved Messages"
MM-T4059_5 test should look for accessible element "Select to toggle a list of Saved Messages"
MM-T4801 Change the menu item back to "Save" it is currently failing because the menu has been changed to "Save Message"
MM-T200 test should look for accessible element "Select to toggle a list of Saved Messages"
MM-T202 test should look for accessible element "Select to toggle a list of Saved Messages"
MM-T2170 test should look for accessible element "Select to toggle a list of Saved Messages"
MM-T2171 test should look for accessible element "Select to toggle a list of Saved Messages"
MM-T122 test should look for accessible element "Select to toggle a list of Saved Messages"
MM-T3352  (MM-T3353 & MM-T3354 in the same set failing) update saved posts to Saved Messages
MM-T4948_1 change back to Save for post menu item, we're not changing to Save Message
MM-T4948_2 update test text to Saved Messages
MM-T134 update test text for tooltip to Pinned Messages
MM-T368 test should look for accessible element "Select to toggle a list of Saved Messages"
Handle removed user- new sidebar test - test should look for accessible element "Select to toggle a list of Saved Messages"

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@VishakhaPoonia are you able to help with teh above test updates? ^

Adding @Rishselva to help shepherd this in

Hello @VishakhaPoonia! A gentle ping to see if there are any new updates.

Hi @VishakhaPoonia just checking in on this. I think the only thing left was addressing the E2E failing tests. @jgilliam17 can you help with this?

/update-branch

Error trying to update the PR.
Please do it manually.

@VishakhaPoonia Can you please rebase branch with master so I can trigger e2es again?
If you have nay questions about my previous post let me know. Thanks 🙂

@matthewbirtch Yeah only test are left, I will fix those and get this merged

@AshishDhama did we get the failing tests fixed? Did we need to reassign a QA team member here?

@matthewbirtch I will finish it next week, nothing much except e2e

/e2e-test

/update-branch

@VishakhaPoonia

No File yet text is not correct.

No groups yet and No members yet model does not have text aligned

@furqanmlk I think 2 and 3 should be fine, but refer to the UX team for that @matthewbirtch @asaadmahmood
for 1. I would refer to @cwarnermm

The Figma text for #1 has a different tone than the others in the series. Proposing we change "You'll see files here when someone attaches a file to a post in this channel." to "You'll see files here when someone shares files in this channel."
@justinegeffen - Would love your input on this too.

Thanks, @cwarnermm. Is this empty state for all channels including DMs and GMs? If so, something more general might work better:
"You'll see files here when they're shared in this channel."

Love your suggestion, @justinegeffen. @VishakhaPoonia - can you confirm that this text would apply to all 4 channel types, including direct messages and group messages, please?

@cwarnermm Yeah, it will be applied to all 4 cases.

The web app now lives in the webapp/channels over in https://github.com/mattermost/mattermost-server. We decided to move it to be a monorepo to make both development and our CI pipelines easier, but it's unfortunately disruptive right now. We've updated our setup docs and added some steps for migrating to working with the monorepo.
Copying the changes over there hopefully shouldn't be too hard. There's a few changes to file paths (such as the code living in a dedicated src subdirectory), but most things should look the same as they do now.
Let us know if you could use any help with this. Hopefully the process is smooth.

The web app now lives in the webapp/channels over in https://github.com/mattermost/mattermost-server. We decided to move it to be a monorepo to make both development and our CI pipelines easier, but it's unfortunately disruptive right now. We've updated our setup docs and added some steps for migrating to working with the monorepo.
Copying the changes over there hopefully shouldn't be too hard. There's a few changes to file paths (such as the code living in a dedicated src subdirectory), but most things should look the same as they do now.
Let us know if you could use any help with this. Hopefully the process is smooth.


grav.user.authorize for logged in user

I use this to show part of the page to users with ‘some.rule’ access:
{% if grav.user.authorize('some.rule') %}
My content
{% endif %}

If admin grants access while the user is already logged in, it doesn’t work. In other words, user has to logout and login to see the hidden content.

I have some plans to improve the current way by adding an event to reconstruct the user object for every request. I already use this method in a custom plugin.

@tihro Just a quick update. It looks like if you're using groups, changing group access will not require a logout.


Creating a marker at discrete progress

Am looking to create an image marker at a different points of the arc...could you give some assistance.
am using the seek bar as a plotter showing where different users left their thumb.
also when creating the seekArc  via code the setThumb method is available

Hi @ruyonga, This isn't supported at the moment, marking as enhancement for later. Feel free to send a PR.


Consider removing peerDependencies?

I just upgraded my project to use the latest rc version of react-native and when I went to npm install I got thrown an error by npm2. I found this GitHub issue which discusses how npm2 ignores rc versions when trying to reconcile peerDependencies. I was curious if you'd be open to removing the peerDependencies requirement of this project to avoid this error?

Fixed via https://github.com/rebeccahughes/react-native-device-info/commit/bea9cae1a718e8d886bddb7c3f4d49aaab372fa5 ! Woohoo!

It should be on npm now :)


Implement HTTP(S) URI Resolver

If wrappers are being hosted on a central server, addressable using a DNS based domain through HTTP(S), we should support querying them through a new URI resolver + authority.
For example, users could query a wrapper like so:
client.invoke({
  uri: "https/wrappers.domain.com/some-wrapper",
  ...
})

For reference, see this mini-hack where wrappers are being hosted at an HTTP endpoint: https://github.com/polywrap/mini-hacks/issues/23


Rate limiting

See https://github.com/meh-is/pass/blob/master/README.md
Preferably without storing user ips, or using cookies... Hmmmmmmm...

Decided to abandon this for now in favor of acccess control to link creation/sending due to complexity with regards to rate limiting.
Public requests:

HTTP GET for /
HTTP POST for /

All other requests should be considered privileged and not be permitted by a frontend proxy or similar.
Unless interest wakes up for this, this is closed from now.


plugin uninstall

Fixes https://github.com/bundler/bundler/issues/5447

I will add test cases soon.

I have added --all option. So bundle plugin uninstall --all will uninstall all the installed plugins. If no plugin is installed then it does nothing.
I will add test case for the new options in next commit.

@Shekharrajak ping on the comments?

I will look into this soon.

ping @Shekharrajak

If anyone trying to work on this issue, then feel free to take. If I see no one is currently working on this issue, I will do required changes after few weeks (I am really not able to manage time for this, because of college exams and gsoc project).

Hey @Shekharrajak, do you still intend to work on this PR?

Closing as superseded by #7409.


[FRONT] #427 hide sign in as guest button

Did you test if authInstance.onAuthStateChanged is called when loggin in anonymously this way ? The app logic relies on that

Did you test if authInstance.onAuthStateChanged is called when loggin in anonymously this way ? The app logic relies on that

Yes. I have a token and a userId setted


feat(helm): postgres credentials moved to secret

Description
If all PostgreSQL credentials are in the secret, the PostgreSQL user and database creation can be done automatically, e.g. with a database operator.
Type of Change
[ ] Bug Fix
[x] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist

[x] I have read the contributing guidelines
[ ] Existing issues have been referenced (where applicable)
[x] I have verified this change is not present in other open pull requests
[x] Functionality is documented
[ ] All code style checks pass
[ ] New code contribution is covered by automated tests
[ ] All new and existing tests pass

This is awesome, I was about to do the same thing. Thank you!

@fhirscher please solve the helm lint issue and the small comment and I think we good to go


Run stories editor without wordpress

Question
Any advice on how to go about trying to run this without WordPress?
I ran npm run dev locally, but I am not sure which JS and CSS files to serve via a index.html
Any guidance is appreciated.
Will be grateful even for highlevel thoughts or general pointers.
Has anybody made a POC that I can refer?
Thanks.
🙏

Thanks for reaching out with this great question!
While this is currently possible, it's not very easy to do and we don't have any documentation for this yet.
We're currently working on making this more feasible though (see #2918 and #4737 for instance).
You can find a POC of a standalone story editor at https://github.com/rtCamp/web-stories-playground/tree/6492647086e89bdc748b5290de20a89128ff4871/packages/playground/src already. But this is definitely not ready for primetime yet, so use at your own risk :)
There'll be an announcement once we have something more shareable with the public.


Add SnapshotLeaderSchedule to core_state

Current dependencies on/for this PR:

feature/proof-of-stake

PR #1043   👈

This stack of pull requests is managed by Graphite.


Force . as decimal separator DateTimeStamp's string representation

This commit fixes a failing test, when the default locale uses a different decimal separator character, e.g. , in German locale.

Dooh, too late and didn't sync my fork... never mind.
Although, Locale.ROOT is "is more neutral" and "is also safe against possible future changes in a country's choice of decimal separator." ... source: https://stackoverflow.com/a/5236096/1431016


Null safety

Migrate code to null-safe.
I made the assumption that return false in the event of the platform channel returning null was the right decision. I looked at the native code and didn't think that was the case, but I wanted to be safe.

Thanks for this pull request :wink:


run the program on ros system

How to run the program in real time on ros system

I copy this code and add a pixor_ros.py to use the pixor model in ros.
github
blog

github:https://github.com/hehern/PIXOR
blog:https://blog.csdn.net/hehern/article/details/104968879

Thank you very much.


Danfoss thermostats not detected correctly

I just made the switch from the legacy plugin to this one. Unfortunately my thermostats are not detected correctly:
[2016-04-13 14:58:14] Initializing platform accessory 'Flurheizung'...
  ZWayServer Got typeKey thermostat.thermostat_set_point for vdev ZWayVDev_zway_2-0-67-1 +55ms
  ZWayServer { deviceType: 'thermostat', probeTitle: undefined, probeType: 'thermostat_set_point' } +1ms
  ZWayServer WARN: Only the InformationService was successfully configured for ZWayVDev_zway_2-0-67-1! No device services available! +8ms

Response from /ZAutomation/api/v1/devices:
{
  "data":{
    "structureChanged":true,
    "updateTime":1460549486,
    "devices":[
      {
        "creationTime":1448406190,
        "deviceType":"buttonControl",
        "h":1320850420,
        "hasHistory":true,
        "id":"ZWayVDev_zway_Remote_3-0-0-B",
        "location":0,
        "metrics":{
          "icon":"",
          "title":"Button Danfoss 0-0",
          "level":"",
          "change":"downstop"
        },
        "permanently_hidden":false,
        "probeType":"",
        "tags":[

        ],
        "visibility":true,
        "updateTime":1460542651
      },
      {
        "creationTime":1448406190,
        "deviceType":"buttonControl",
        "h":-2086613195,
        "hasHistory":true,
        "id":"ZWayVDev_zway_Remote_4-0-0-B",
        "location":0,
        "metrics":{
          "icon":"",
          "title":"Button Danfoss 0-0",
          "level":"",
          "change":"downstop"
        },
        "permanently_hidden":false,
        "probeType":"",
        "tags":[

        ],
        "visibility":true,
        "updateTime":1460542651
      },
      {
        "creationTime":1448406191,
        "creatorId":8,
        "deviceType":"battery",
        "h":-592588977,
        "hasHistory":false,
        "id":"BatteryPolling_8",
        "location":0,
        "metrics":{
          "probeTitle":"Battery",
          "scaleTitle":"%",
          "title":"Battery digest 8",
          "level":66
        },
        "permanently_hidden":false,
        "probeType":"",
        "tags":[

        ],
        "visibility":true,
        "updateTime":1460549368
      },
      {
        "creationTime":1448406192,
        "creatorId":1,
        "deviceType":"thermostat",
        "h":1303340796,
        "hasHistory":true,
        "id":"ZWayVDev_zway_2-0-67-1",
        "location":2,
        "metrics":{
          "scaleTitle":"°C",
          "level":18,
          "min":5,
          "max":40,
          "icon":"thermostat",
          "title":"Flurheizung"
        },
        "permanently_hidden":false,
        "probeType":"thermostat_set_point",
        "tags":[

        ],
        "visibility":true,
        "updateTime":1460549271
      },
      {
        "creationTime":1448406192,
        "creatorId":1,
        "deviceType":"battery",
        "h":-927793024,
        "hasHistory":false,
        "id":"ZWayVDev_zway_2-0-128",
        "location":0,
        "metrics":{
          "probeTitle":"Battery",
          "scaleTitle":"%",
          "level":66,
          "icon":"battery",
          "title":"Battery 2-0 Danfoss"
        },
        "permanently_hidden":false,
        "probeType":"",
        "tags":[

        ],
        "visibility":true,
        "updateTime":1460549271
      },
      {
        "creationTime":1448406192,
        "creatorId":1,
        "deviceType":"thermostat",
        "h":-1248816165,
        "hasHistory":true,
        "id":"ZWayVDev_zway_3-0-67-1",
        "location":1,
        "metrics":{
          "scaleTitle":"°C",
          "level":21,
          "min":5,
          "max":40,
          "icon":"thermostat",
          "title":"Büroheizung"
        },
        "permanently_hidden":false,
        "probeType":"thermostat_set_point",
        "tags":[

        ],
        "visibility":true,
        "updateTime":1460542945
      },
      {
        "creationTime":1448406192,
        "creatorId":1,
        "deviceType":"battery",
        "h":-40289343,
        "hasHistory":false,
        "id":"ZWayVDev_zway_3-0-128",
        "location":0,
        "metrics":{
          "probeTitle":"Battery",
          "scaleTitle":"%",
          "level":69,
          "icon":"battery",
          "title":"Battery 3-0 Danfoss"
        },
        "permanently_hidden":false,
        "probeType":"",
        "tags":[

        ],
        "visibility":true,
        "updateTime":1460542656
      },
      {
        "creationTime":1448406192,
        "creatorId":1,
        "deviceType":"thermostat",
        "h":493994170,
        "hasHistory":true,
        "id":"ZWayVDev_zway_4-0-67-1",
        "location":3,
        "metrics":{
          "scaleTitle":"°C",
          "level":16,
          "min":5,
          "max":40,
          "icon":"thermostat",
          "title":"Wohnheizung"
        },
        "permanently_hidden":false,
        "probeType":"thermostat_set_point",
        "tags":[

        ],
        "visibility":true,
        "updateTime":1460549368
      },
      {
        "creationTime":1448406192,
        "creatorId":1,
        "deviceType":"battery",
        "h":847214338,
        "hasHistory":false,
        "id":"ZWayVDev_zway_4-0-128",
        "location":0,
        "metrics":{
          "probeTitle":"Battery",
          "scaleTitle":"%",
          "level":74,
          "icon":"battery",
          "title":"Battery 4-0 Danfoss"
        },
        "permanently_hidden":false,
        "probeType":"",
        "tags":[

        ],
        "visibility":true,
        "updateTime":1460549368
      }
    ]
  },
  "code":200,
  "message":"200 OK",
  "error":null
}

Hmm! Well, I see the problem. Have you upgraded Z-Way to 2.2.1 or 2.2.2? I haven't done that yet, I wonder if one of those changes the output, because I have Danfoss thermostats (the radiator-attached ones) and that's now how they show up.

Correct - Z-Way 2.2.2 (latest stable) + Danfoss LC-13. Pretty sure the same you use. My guess is that just 2.2.2 changed the API. I was on 2.2.1 with the legacy plugin before and it worked. I've updated Z-Way and switched to homebridge-zway at the same time and immediately blamed homebridge-zway. Probably wrongly so :)
2.2.2 changelog mentions this:
API changes:
[...]
- Setting probeType refactored (moved completely in to ZWave module).

Well, the plugin needs updating now, but yeah they changed something. Pretty easy fix and I'm used to it by now. :-)

Okay, I've added a new branch, and it's basically a one line fix (or it should be). The branch is here:
https://github.com/SphtKr/homebridge-zway/tree/z-way-2-2-2-fixes
and if you look at the commit (7eac7029ac5136a8193404645d875918a54f5d8a), you can see the one added line. If you can either download a zip of that branch and put it in place of your plugin in node_modules, or just replace index.js or just insert the one line manually, I think you'll be fixed. If you can't try it that way, I can publish the module as an alpha release that you can npm install.

With that commit the thermostats show up in HomeKit but battery and actual thermostat are somehow mangled and when trying to change the temperature the following error appears:
/usr/local/lib/node_modules/homebridge-zway/index.js:386
        return !!this.interlock.value;
                               ^

TypeError: Cannot read property 'value' of undefined
    at Object.ZWayServerAccessory.isInterlockOn (/usr/local/lib/node_modules/homebridge-zway/index.js:386:32)
    at Object.<anonymous> (/usr/local/lib/node_modules/homebridge-zway/index.js:604:25)
    at emitThree (events.js:97:13)
    at emit (events.js:175:7)
    at Characteristic.setValue (/usr/local/lib/node_modules/homebridge/node_modules/hap-nodejs/lib/Characteristic.js:155:10)
    at Bridge.<anonymous> (/usr/local/lib/node_modules/homebridge/node_modules/hap-nodejs/lib/Accessory.js:709:22)
    at Array.forEach (native)
    at Bridge.Accessory._handleSetCharacteristics (/usr/local/lib/node_modules/homebridge/node_modules/hap-nodejs/lib/Accessory.js:654:8)
    at emitThree (events.js:97:13)
    at HAPServer.emit (events.js:175:7)

Oh...whoops! That's an unrelated bug. I'll knock that out soon.

Okay, try the code in 2e82e6e3d1bbf9354296b318adbb63702fee1393 ... that should at least fix your crash on setting temperature. Can you give me a screenshot about what your seeing with the battery characteristics? That could be a result of moving from the legacy version of the plugin.

Sweet! I've patched those 2 lines and removed the accessory and persist folders to start with a fresh homebridge. All working fine now. Thanks for the quick fixes.

Fixed in 3977f25b6ec1292cb7550475087b1a464a0f0cb8.


Change "preview" in Create Project > Google Data

Describe the bug
In Create Project, the tiny "preview" that appears after each Google Sheet available for import from my Google Drive account:

is a bit small
doesn't indicate that when you click it you will open up the Google Sheet ... in Google Sheets

To Reproduce

Current Results
A surprise new tab loading the full Sheet, rather than, say, a "preview" of any kind loading inside the interface.
Expected behavior
I would suggest:

normal-size text, perhaps in brackets and italics: (Preview)
and either:
changing the link text to (Open in Google Sheets) or (Open)
or
a guiding sentence above the list, to say "Click Preview to open the Google Sheet in a new tab."

Thanks!

👍  (Open in Google Sheets)

Another possibility would be to use one of the "Open in new Window" icons with an explanatory tooltip
https://thenounproject.com/browse/icons/term/open-in-new-window/


There is a conversion problem with the oeo-full.owl file

Description of the issue
I just noticed there is a problem with the oeo-full.owl file. Apparently some axioms are not being converted properly making it not possible to parse the ontology with robot. The file seems to be working fine with Protégé. Here is an example command:
 robot convert --input build/oeo/1.12.0/oeo-full.owl --output oeo-full-round.omn --format omn
ERROR Input ontology contains 18 triple(s) that could not be parsed:
 - <http://openenergy-platform.org/ontology/oeo/OEO_00010125> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> _:genid2147486222.
 - <http://openenergy-platform.org/ontology/oeo/OEO_00010203> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> _:genid2147486241.
 - <http://openenergy-platform.org/ontology/oeo/OEO_00010203> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> _:genid2147486242.
 - <http://openenergy-platform.org/ontology/oeo/OEO_00010202> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> _:genid2147486237.
 - <http://openenergy-platform.org/ontology/oeo/OEO_00010202> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> _:genid2147486238.
 - <http://openenergy-platform.org/ontology/oeo/OEO_00010230> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> _:genid2147486256.
 - <http://openenergy-platform.org/ontology/oeo/OEO_00010122> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> _:genid2147486220.
 - <http://openenergy-platform.org/ontology/oeo/OEO_00010205> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> _:genid2147486245.
 - <http://openenergy-platform.org/ontology/oeo/OEO_00010205> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> _:genid2147486246.
 - <http://openenergy-platform.org/ontology/oeo/OEO_00010228> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> _:genid2147486254.
 - <http://openenergy-platform.org/ontology/oeo/OEO_00010200> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> _:genid2147486230.
 - <http://openenergy-platform.org/ontology/oeo/OEO_00010199> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> _:genid2147486225.
 - <http://openenergy-platform.org/ontology/oeo/OEO_00010199> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> _:genid2147486226.
 - <http://openenergy-platform.org/ontology/oeo/OEO_00010229> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> _:genid2147486255.
 - <http://openenergy-platform.org/ontology/oeo/OEO_00010124> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> _:genid2147486221.
 - <http://openenergy-platform.org/ontology/oeo/OEO_00010201> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> _:genid2147486233.
 - <http://openenergy-platform.org/ontology/oeo/OEO_00010201> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> _:genid2147486234.
 - <http://openenergy-platform.org/ontology/oeo/OEO_00010200> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> _:genid2147486229.

Ideas of solution
~Probably one has to take a look at the make scripts~

Remove all quantifiers from individual type axioms

Make the has memo item property part of a subclass of sector which is instantiated by all its users. sector with memo?
Turn Effort sharing regulation into a subclass of effort sharing  with axiom uses  Annual Emission Allocation`
Add new subclass of policy instrument with axiom uses some Allowance and instantiate European Union Emission Trading System from that.

Workflow checklist

[x] I am aware of the workflow for this repository

I noticed it is something to do with instance types:
        <rdf:type>
            <owl:Restriction>
                <owl:onProperty rdf:resource="http://openenergy-platform.org/ontology/oeo/OEO_00010232"/>
                <owl:someValuesFrom rdf:resource="http://openenergy-platform.org/ontology/oeo/OEO_00010227"/>
            </owl:Restriction>
        </rdf:type>
        <rdf:type>
            <owl:Restriction>
                <owl:onProperty rdf:resource="http://openenergy-platform.org/ontology/oeo/OEO_00010232"/>
                <owl:someValuesFrom rdf:resource="http://openenergy-platform.org/ontology/oeo/OEO_00010227"/>
            </owl:Restriction>
        </rdf:type>

This happens to every Instance Type axiom where there is multiple classes. The parser tries to make an anonymous node out of it then  tries to associate it to the class. Is that even allowed? to have quantifiers in the type of an instance? We have the properties: uses and  has memo item associated to the Type of the instance. Shouldn't these properties being associated to the instance itself?

Since this seems to be allowed by Robot in Manchester Syntax, i suspect this is a robot bug.

Before changing anything, we should check whether oeo-full.owl is created correctly.

Before changing anything, we should check whether oeo-full.owl is created correctly.

What I have already tried is take oeo-social, where these instances are being defined and convert it to owl from protégé. Then I try to convert it back  to omn with robot and I get the same error. So either, Protégé allows this axiom and it is illegal or the axiom is legal but robot is not able to parse it from an owl file.

I have been reading https://github.com/OpenEnergyPlatform/ontology/issues/858 and the implementation at https://github.com/OpenEnergyPlatform/ontology/pull/967  I think the issue has to be repoened.
My first idea of a solution was to do this:

memo item sector

SubClassOf sector
SubClassOf has memo item some memo item

sector with exclusions: A sector with exclusions is a sector with a subdivision excluded through a memo.
But everything broke apart when I tried to do the natural next step which is instantiating the memos themselves, which did not make sense from the context provided in the issue.
memo item is more of a binary property, a quality. But since the sectors are generically dependent continuant this is not something we can attach to them. I don't think the property belongs to this entity at all. Because the fact of a sector being just reported as a memo is independent of it being a sector or not.
The importance of the memo item arises when the sectors are being used in something like national inventory reports. There you can say that some quantity value reported is just extra information not being accounted towards some total (Like CO2 emissions). For example in: https://www.eea.europa.eu/data-and-maps/data/national-emissions-reported-to-the-unfccc-and-to-the-eu-greenhouse-gas-monitoring-mechanism-18

Class expressions are not in the range of rdf:type. Quoting the RDF Schema 1.1 reference:

The rdfs:domain of rdf:type is rdfs:Resource. The rdfs:range of rdf:type is rdfs:Class.

But the definitive confirmation of no quantifiers in type axioms to me is the bold part of this quote of the Owl2 Syntax Reference:

In OWL 2, classes and property expressions are used to construct class expressions, sometimes also called descriptions, and, in the description logic literature, complex concepts. Class expressions represent sets of individuals by formally specifying conditions on the individuals' properties; individuals satisfying these conditions are said to be instances of the respective class expressions. In the structural specification of OWL 2, class expressions are represented by ClassExpression.

We should discuss this in one of this in a oeo dev meeting.

Status from todays OEODEV: We need support from @OpenEnergyPlatform/oeo-general-expert-formal-ontology to formulate a definitive answer

This is no longer an issue in 1.14.0


Replace the no need Eventf() with Event()

What type of PR is this?
/kind cleanup
What this PR does / why we need it:
I replaced the no need Eventf() function with Event().
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?

NONE

/assign @kerthcet @trasc


[Bug] Tooltip does not display when hovering over an object

Description of the issue
When setting ToolTip.Tip to any object and hovering over that object, the tooltip does not appear. This issue was observed in the SukiUI demo application as well. However, if the main window is not changed to sukiWindow, the tooltip works fine. Additionally, this issue occurs with Avalonia version 11.1.0-beta2, but it works correctly with Avalonia version 11.0.11.
Package Version
6.0.0-beta6
Environment
Windows 11 22631
Expected Behavior
The tooltip should appear when hovering over the object.
Reproduction

Clone the SukiUI repository.
Open the SukiUI demo application.
Set a tooltip.tip to any object (e.g., a button).
Run the application.
Hover over the object to see if the tooltip appears.

Additional Information
No response

I have recreated this issue locally and tried to track down the source of the bug and come up with a potential fix but it evades me.
If you set the ToolTip.ShowDelay to 0 the tooltip will appear but flicker very quickly suggesting that something is appearing
Also the tooltips in the top menu items in the demo app work perfectly fine, which is very confusing.


[Question] page.waitForRequest() timing out even after completing the specified action

Code:
Page page = browserContext.newPage();
        page.navigate("https://rahulshettyacademy.com/AutomationPractice/");

        page.waitForRequest(request -> "https://www.rahulshettyacademy.com/api/course".equals(request.url()) && "GET".equals(request.method()), () ->{
            page.click("#alertbtn");
        });
 browserContext.close();
 browser.close();
 playwright.close();

Here Alert button is getting clicked, i also tried with any other action like entering value in text field. Those actions are being performed but i am getting below error:
Exception in thread "main" com.microsoft.playwright.TimeoutError: Timeout 30000ms exceeded
	at com.microsoft.playwright.impl.WaitableTimeout.get(WaitableTimeout.java:41)
	at com.microsoft.playwright.impl.WaitableRace.get(WaitableRace.java:44)
	at com.microsoft.playwright.impl.ChannelOwner.runUntil(ChannelOwner.java:109)
	at com.microsoft.playwright.impl.PageImpl.waitForEventWithTimeout(PageImpl.java:534)
	at com.microsoft.playwright.impl.PageImpl.waitForRequestImpl(PageImpl.java:1362)
	at com.microsoft.playwright.impl.PageImpl.lambda$waitForRequest$73(PageImpl.java:1351)
	at com.microsoft.playwright.impl.WaitForEventLogger.get(WaitForEventLogger.java:46)
	at com.microsoft.playwright.impl.ChannelOwner.withWaitLogging(ChannelOwner.java:78)
	at com.microsoft.playwright.impl.PageImpl.waitForRequest(PageImpl.java:1351)
	at com.microsoft.playwright.Page.waitForRequest(Page.java:6456)
	at Sample14.main(Sample14.java:13)

browser is still open and close() was not called.

The request you are waiting for is actually sent before the click. You can record a trace to see what's going on in the page. Or you can just add the following logging to your code to see all requests that are sent while page.waitForRequest is being called:
    page.onRequest(r -> System.out.println(r.url()));
    page.waitForRequest(request -> "https://www.rahulshettyacademy.com/api/course".equals(request.url()) && "GET".equals(request.method()), () ->{
            page.click("#alertbtn");
    });

Rearranging the code like this will pass the test (not sure if that's what you want though):
    page.onRequest(r -> System.out.println(r.url()));
    page.waitForRequest(request -> "https://www.rahulshettyacademy.com/api/course".equals(request.url()) && "GET".equals(request.method()), () ->{
      page.navigate("https://rahulshettyacademy.com/AutomationPractice/");
      page.click("#alertbtn");
    });

I interpreted working of page.waitForRequest() little different. It worked now, this was expected and i understood its intent as well. Thank you for quick turn around.


Onboarding - Tutorials

As part of our efforts to bolster onboarding we should offer tutorials for common workflows.
For instance, the quickstart would be made available as a tutorial.
We would ask the user during signup (after verification) if they would like to see a tutorial, and then would let them page through the steps.
The user could then re-access the tutorials through a category of commands specifically for this type of experience. Maybe it's just one command with subcommands, or maybe it's a category with a number of top level tutorials.. unsure what would be best.
They would be simple predefined output that walks a user through a concept and series of commands.

I think this takes form as a torus tutorial command which has subcommands for each tutorial.
We can choose to show or hide them from help.
We should start by converting (and updating) the quickstart: https://www.torus.sh/docs/latest/start-here/quickstart

This is a lot like the approach taken by vim through vimtutor.

I've learned to use the quickstart as the canonical source of truth, where the general docs are so 'general' that it is hard to apply them, or imagine how they apply to a problem. A tutorial would be nice, but I think it would be useful to have different chapters that can be addressed independently like they are in the quickstart.


[6.1] Skip ExtractAppIntentsMetadata when building with Xcode

6.1 cherry-pick b0a8e74f13daa664fecc2b728879e65f9f00214e

Explanation: Skips an unused phase
Scope: Build
Issue: rdar://141319632
Risk: Low, will either build or not
Testing: Builds
Reviewer: @dmbryson

@swift-ci please test

@swift-ci please smoke test


audio error in sendrecv example

** (webrtc-sendrecv:6515): CRITICAL **: file gstaudioringbuffer.c: line 2044 (gst_audio_ring_buffer_set_channel_positions): should not be reached

I got this error  recently and received no audio from web, video is ok.
why does this happen?

I ran it on Ubuntu 16.04, web browser is chrome(latest version) and the audio format is PCMA. I received audio data form chrome but it plays no sound and raise the error above.

Receiving PCMA means you've changed the program to not use opus.  We can't help you with that without at least seeing what you've changed.
Also, some useful information like OS/Platform or where you're trying to run this program would be useful to know which audio sink you're using :)


Guidance for managers

On the private to public guidance, and perhaps even on the general page, it would be helpful for line managers to have a bit of a guide for things that they should do before agreeing to sign-off a repo.
It is kind of included in the flow chart, but I think it could be easier to digest in bullet or checklist form.
Thinking like:
Things to consider in your risk assessment before going public

How sensitive are the repositories outputs?
What is your organisations risk appetite?
What is the chance of sensitive information being pushed to the repository in the future (e.g. passwords, data, company secrets)?
Were there any potential secrets stored within the repositories git history from when the repo was private?
How confident are you in the quality of the code?  - do you need to put some indicators on it, to manage users expectations e.g.

The minimal recommended steps

[ ] I have considered my organisations risk appetite
[ ] I have conducted a risk assessment on the repository identified ways to mitigate risks above the appetite level
[ ] A colleague has peer reviewed my repository for sensitive or confidential information
[ ] I believe the risks are already within tolerance, or I have implemented mitigations to bring it within tolerance
[ ] A senior colleague has peer reviewed my risk assessment and mitigations and they agree it is within tolerance

Great points made, thanks for this @ColinDaglish . Just a quick note to check if you've seen the fit for publishing checklist - it's a bit buried in reference item 3, half way down the page on the NHS website. We'll promote this a bit more in the next iteration. This checklist forms the backbone of the review. However, some of the points you have raised here are pertinent and not handled there, so we'll look at implementing your suggestion.

Yes, I think it'd be good if we could essentially replicate and reference that checklist, and put it right at the top, with a few amendments to make it more explicit.

Fit for purpose (unless you are intentionally looking for help to make it fit for purpose)
clearly documented *instructions on how to run and contribute
No credentials, secrets, or personally identifiable information left in the repository (including it's history)
No sensitive data should be stored in the repository.  (It can be quite helpful to have staged dummy or synthetic data to speed up test execution)


Replace certbot with nginx lua-resty-auto-ssl module

Currently it's quite hard to deploy letsencrypt for servers which are not yet used by the DNS. This happens for example when migrating stuff from different company or from platfrom.sh/heroku/etc to separate servers setupped by wundertools.
It would be much easier if certificates would be requested just in time from letsencrypt.
Luckily there's a nginx lua module which can be hooked into the nginx TLS handshake and used in order to request and handle the letsencrypt challenge:
https://github.com/GUI/lua-resty-auto-ssl
I would recommend us to do all https deployments like this. The certificates can also be stored in Redis so we can have multiple machines sitting in the load balancer layer.

Sounds good!


FIX: Missing dotfiles matched as root URL

Missing dotfiles for example .passwd are matched as files and split by the dot to retrieve the extension. However this means $this->url is set to empty which in turn means $this->dirParts is empty which is then matched as the root URL instead of returning a 404.
This regex modification only matches files with names. I thought this was the least intrusive way to fix this issue.

I think this pull request will need a unit test, since it covers a potentially breaking area of the code.

Bump


Odd display: highlighting LF with cursorline set

repro steps
test.vim
syntax on
normal! iabcd
call matchadd('Search', '\n')
setl cursorline

vim -Nu NONE -S test.vim

abcd  ______
    ^^ no hightlighting 2 chars

This looks odd.
For example, I think the folloings look more natural than current.
a) No highlighting 1 char, and highlighting to the end of row

b) Highlighting to the end of row

c) Highlighting 1 char (the display of nocursorline state + cursorline; simply)

And there is a derived problem.
test.vim
syntax on
vsplit
execute "normal! " . (winwidth(0)  - 1) . "ia"
call matchadd('Search', '\n')
setl cursorline
normal! o

vim -Nu test.vim
and move cursor to first line:

Window border is misaligned.


Character reference is displayed instead of character

What is the current behavior?
On https://docs.github.com/en/actions/guides , in the list of tutorials in the page content, ampsand is displayed as a character reference ("&") instead of the actual character ("&"):

What changes are you suggesting?
The character should be displayed instead of the character reference
Additional information
Using Chromium Version 91.0.4472.164 (Official Build) Arch Linux (64-bit)

@kittykat Thanks so much for opening an issue! I'll triage this for the team to take a look :eyes:

Hi @kittykat! :cat: Thanks so much for reporting this problem, I'm able to reproduce it too ✨  This has been raised with our engineering team but will need to be addressed in our internal repository.
I'll leave this issue open while it's worked on.

2222

468

536

122113

91272

333

666666

12213

127270

13216

Hi again @kittykat! Our engineering team has just shipped a fix for this. Thanks again for reporting it! ✨


Alfoa/scale6.2

Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
Closes #607
What are the significant changes in functionality due to this change request?
Added a code interface for SCALE package (TRITON and ORIGEN)

For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.

[ ] 1. Review all computer code.
[ ] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[ ] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[ ] 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
[ ] 5. If significant functionality is added, there must  be tests added to check this. Tests should cover all possible options.  Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in  XML block, the node <internalParallel> to True.
[ ] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change.  The requirements and the requirements test shall be in sync.
[ ] 7. The merge request must reference an issue.  If the issue is closed, the issue close checklist shall be done.
[ ] 8. If an analytic test is changed/added is the the analytic documentation updated/added?

@mandd The PR is ready to be reviewed.
I am adding the regression tests now but, in the meanwhile, you can start reviewing all the rest (code and documentation)

@mandd I addressed your comments and added a new test (sanitized) that test the combined sequence triton,origen.
Let me know.

Job Test linux on 6f571a6 : invalidated by @alfoa

Job Mingw Test on 6f571a6 : invalidated by @alfoa

Job Test qsubs on 6f571a6 : invalidated by @alfoa
HPC up again

Job Mingw Test on ac86a52 : invalidated by @alfoa

Job Mingw Test on ac86a52 : invalidated by @alfoa
build failed?

Job Mingw Test on ac86a52 : invalidated by @alfoa

Job Test mac on ac86a52 : invalidated by @alfoa

since @mandd approved this PR and all tests are green, I proceed in merging it.


Cppslim

Remove #include<bits/...>

Codecov Report

Merging #31 (44c7f17) into develop (94dc950) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop      #31   +/-   ##
========================================
  Coverage    95.35%   95.35%
========================================
  Files           61       61
  Lines         2994     2994
========================================
  Hits          2855     2855
  Misses         139      139

Codecov Report

Merging #31 (44c7f17) into develop (94dc950) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop      #31   +/-   ##
========================================
  Coverage    95.35%   95.35%
========================================
  Files           61       61
  Lines         2994     2994
========================================
  Hits          2855     2855
  Misses         139      139


Grabbit won't start in AEM 6.3 because JCRJobRepository uses "admin" session

Grabbit uses admin session for the JCR JobRepository implementation. In AEM 6.3, by default you cannot connect to JCR using admin session. It will throw this exception
Caused by: org.apache.sling.api.resource.LoginException: Bundle com.twcable.grabbit is NOT whitelisted

See this for more details : https://issues.apache.org/jira/browse/SLING-5135
If we want to continue to use admin for JCR JobRepository implementation, we will have to whitelist the package(s) that need it. Even better, we should come up with a way to not use admin for JCR JobRepository implementation at all. We can't really use the request session in this case, because the JobRepository connects to the JCR on bundle activation for example.
@jbornemann @jdigger

Had to make an additional config update to make sure grabbit worked(to overcome the not whitelisted issue)


ReferenceError: google is not defined with Server Side Rendering

I am getting the above error message while reloading the page (Server Side Rendering) while it works fine with client side rendering.
I am using the example from below link:
https://tomchentw.github.io/react-google-maps/basics/pop-up-window
Any solution for this ?

You have to decouple google on your own (for example, props you've passed in). I only guarantee on the library prospective.

@manoj150283 Did you come up with any solution?


Add support for building s2i-core and s2i-base from Fedora 39

[test]

Is there any reason for moving core and base to f39 just now?
If not, I would rather leave the default one being 38, as main part of our Fedora images is based on 38 and with this change the 38 image will stop getting new updates with rebuilds disabled.

@zmiklank @jplesnik is planning to add new Perl-5.38 version that exists only since Fedora 39. Pull request will be available soon.
Only from this reason, I have created this pull request.

And python-3.12 also needs Fedora 39.

According to the discussion we had at the meeting this week, we should think about how to make it possible to have more than one Fedora version here.

               q

According to the discussion we had at the meeting this week, we should think about how to make it possible to have more than one Fedora version here.

I guess, this can be done as separate pull request, right? The issue is here: https://github.com/sclorg/s2i-base-container/issues/279

Closing in favor of https://github.com/sclorg/s2i-base-container/pull/280.


Fix array out of range

Simply, the last indexes of the arrays are wrong.
Generating 16 characters or more of input at one time will destroy the other values of the structure.

@daipom Good catch! Thanks for the review!

Thanks for the merging!


Batchwise optimization takes longer times than expected to run

Could the nested loop in simulai/optimization/_optimization.py:473 be responsible ?

Could it be effective to replace it by a single loop ?
Could it be effective to vectorize it via torch.vmap ?
Could it be effective to compile the training model using the throughout torch.compile ?

torch.compile slightly reduces the execution time, but it is still does not solve the question.

The data mapping between CPU and GPU can be another bottleneck. During a batch-wise optimization loop the datasets are usually stored in the principal memory and transferred to GPU in smaller chunks. It makes sense when we are using a single GPU card and its memory is very limited when compared to the dataset size, however, there are cases in which the dataset can be entirely allocated in  GPU and it can save execution time. We just need to check this condition in the beginning of the fit method.


Arabic language text issue

simply I tried this page, and i got file.pdf
:D

I believe the font wasn't supported that's why. but with the default font:

it's better, but if you use symbols it would break the sentence


Add Broadcom APDS9922 ambient light and proximity sensor

Summary
Adds support for Broadcom APDS-9922 ambient light and proximity sensor device.
Impact
None expected.
Testing
Custom board with SAMA5D27C-D1G with 2x apds-9922 devices

@TimJTi please make sure it is compatible with the new sensor subsystem, test it with apps/testing/sensortest.
I didn't see sensor_lowerhalf_s in our code.

@TimJTi please make sure it is compatible with the new sensor subsystem, test it with apps/testing/sensortest. I didn't see sensor_lowerhalf_s in our code.

Umm...didn't know about that. I'll take a look.

@TimJTi please make sure it is compatible with the new sensor subsystem, test it with apps/testing/sensortest. I didn't see sensor_lowerhalf_s in our code.

Umm...didn't know about that. I'll take a look.

@acassis
Proximity: not really appropriate to this sensor as it does not provide meaningful data in cm (or any measure). It is more of a "near/close" sensor. Typical use is mobile phone to detect that the phone is close to your ear.
Light: The use of this sensor is not to provide periodic/accurate/timestamped precision ambient light measurements.
There are other sensors that do not "conform" to this methodology, and the sensor_test app has very poor help and no documentation.
Perhaps I COULD revisit this at a later date once the "new" sensor system is properly bedded in?

I will look an Monday and see if the sensor subsystem can co-exist or does, actually, provide for my "use case" as well as the generic one. Initial reaction was "oh no, I spent weeks getting this to work because of silly bugs. I really don't want to rework it". But perhaps bettere for me to address while its still all fresh in my mind.
I will change it to draft for now.

Hi @TimJTi the sensor subsystem is new to me as well, but I think all drivers will end-up using it. Maybe @xiaoxiang781216  and @huxiandong could give more details.

Hi @TimJTi is it done or still WIP? Please fix the commit messages, you did the interactive rebase but forgot to fix the messages

Hi @TimJTi is it done or still WIP? Please fix the commit messages, you did the interactive rebase but forgot to fix the messages

Done - hopefully just changed the name of the final commit. If not, I'm away for 2 weeks but can try and do it remotely.

Hi @TimJTi is it done or still WIP? Please fix the commit messages, you did the interactive rebase but forgot to fix the messages

Done - hopefully just changed the name of the final commit. If not, I'm away for 2 weeks but can try and do it remotely.

Now I'm back...and it seems that what I have in my local repo and what is showing in the commits to this repo are not in sync. I have no idea what I have done. or not done.
I will double check that what I have locally is, indeed, correct and working and passing all tests and will probably then withdraw this PR and resubmit a new one to be on the safe side. I will rebase to latest master as well.


material.angular.io Offline or only downloads partial contemt

Navigate to https://material.angular.io/
Then look at a component for documentation on how to use.  For example...
https://material.angular.io/components/datepicker/examples
The page only partially loads?
Same for all components.
Tested with multiple browsers and from multiple locations.
The site is clunky and very slow.
Not a very good advertisement for Angular Material.

It's working for me on Chrome, Firefox and iOS Safari. Have you tried clearing your cache? Also are you seeing any errors in the console?

Cache cleared (Chrome on Windows 10)
Reloaded site https://material.angular.io/  (takes ages to load, sometimes does not load at all)
Try to read documentation on a component.
Loading document...Loading document
Is about as far as it gets.
No errors in console.

I've tried this against several different devices in Chrome, Firefox, Safari, IE and Edge and it worked correctly everywhere. Considering that there haven't been any other reports like this, it's likely an issue on your end (network issue, browser extension etc.).


Error when using frontpage option in WordPress

Hi there,
I'm pretty new to Nextjs. This is a great starter point for getting into Nextjs combined with WP.
I am trying to set a page as the homepage. For this in WP there is this setting to set a static page as the frontpage.
When I do this, the homepage isn't changing.
If I click on one of my menu-items i'm getting the error:
Error: A required parameter (slugParent) was not provided as a string in getStaticPaths for /[slugParent]/[[...slugChild]]
I'm not sure where to start.
I have tried to change the src/pages/index.js.  But I wasn't sure if that's the right approach.
I hope someone can point me in the right direction.
Thank you!

hey @pdenissen the starter isn't configured to dynamically create a frontpage based on the wordpress setting, you would have to customize that yourself inside of Next.js by updating the index.js file like it seems like you were trying tod o
it looks like you have a menu item though that doesn't exist as a page?

Hej @colbyfayock,
Thanks for your reply. Good to know that it's best practise to set it up myself.
According the error; when I don't set a frontpage in the wp-admin, than my links to my static pages are working fine. However, when I do set it to 'frontpage' than i'm getting the error when I click on one of the links in my menu.
If you need any specific information on this, let me know.
Thanks!

@jonnymaceachern for the page template, you can take an approach similar to what i did with Archives, where you can create a Page template and use it as a component
https://github.com/colbyfayock/next-wordpress-starter/blob/main/src/templates/archive.js
https://github.com/colbyfayock/next-wordpress-starter/blob/main/src/pages/posts.js

When using graphql there is a field called isFrontPage inside the pages query. Simply add it after menuOrder on line 19 inside src/data/pages.js
Then this is my modified index.js where I added a simple if statement where the page is a frontpage.
import useSite from 'hooks/use-site';
import { getAllPages } from 'lib/pages';
import { WebsiteJsonLd } from 'lib/json-ld';

import Layout from 'components/Layout';
import Header from 'components/Header';
import Section from 'components/Section';
import Container from 'components/Container';

export default function Home({ pages }) {
  const { metadata = {} } = useSite();
  const { title } = metadata;

  return (
    <Layout>
      <WebsiteJsonLd siteTitle={title} />

        <Container>
          {pages.map((page) => {
            if (page.isFrontPage) {
              return (

{page.title}

              );
            }
          })}
        </Container>

    </Layout>
  );
}

export async function getStaticProps() {
  const { pages } = await getAllPages({
    queryIncludes: 'all',
  });
  return {
    props: {
      pages,
    },
  };
}


Bug 55 error with smooth scroll

I was finally able to reproduce the problem and made the fix of Laurent a bit more elegant (less if-statements).
Sorry, I branched from the previous branch. So that change is also in this pull request.

@kzenmatthias, could you please separate both the #54 and the #55 fixes? Thanks!


tags should not contains spaces

Describe the bug
Tags currently contain spaces, which can lead to issues with searchability, compatibility, and consistency across different systems. Tags should be formatted without spaces to improve their utility.
Expected behavior
Tags should be formatted using one of the following methods:
CamelCase (e.g., DataScience)
Underscores (e.g., data_science)
Hyphens (e.g., data-science)
Concatenation (e.g., datascience)
Screenshots

@Kajol-Kumari should we replace tags with lowercase


net/freeradius: add Service-Type

Closes #1444
I made a multi_select field with Integer 1-19, so it's a mix of both discussed solutions.

Merged, thanks!


[Update Request]: Python.Python.3.12 has incorrect metadata

What type of update are you requesting?
A change to the package metadata
Current Package Identifier
Python.Python.3.12
Package Version
3.12.0
Please describe the changes you would like to see
@spectershell - seems an update from Dumplings inserted some invalid AppsAndFeaturesEntries

.

If you mean the & and the * in the installer manifest:
& is the anchor that defines the chunk and * is the alias that refer to those chunks. Both of them are part of YAML grammar.
Previously when generating the manifest, the same AppsAndFeaturesEntry object was assigned to both the user scope and the machine scope of installer entries, causing ConvertTo-Yaml to use anchor and alias for them. Anyway this feature has been disabled since then.
If you mean Python 2 is treated as Python 3.12 by WinGet client:

It seems to be a bug from WinGet that it can not distinguish Python 2 from Python 3.4 even if I have added UpgradeCode to Python 2 some days ago. For me after WinGet failed to distinguish it simply use Python 3.12 from install records for Python 2, and since they have different install technologies it can never be updated.
2024-04-30 22:25:56.887 [REPO] Found multiple matches for installed package [{A5F504DF-2ED9-4A2D-A2F3-9D2750DD42D6}] in source [Microsoft.Winget.Source_8wekyb3d8bbwe] when searching for [Query:[none] Include:ProductCode='{a5f504df-2ed9-4a2d-a2f3-9d2750dd42d6}'[Exact] Include:UpgradeCode='{6a965a0c-6ee6-4e3a-9983-3263f56311ec}'[Exact] Include:NormalizedNameAndPublisher='python'+'pythonsoftwarefoundation'[Exact] Include:NormalizedNameAndPublisher='python(x64)'+'pythonsoftwarefoundation'[Exact]]
2024-04-30 22:25:56.887 [REPO]   Checking match with package id: Python.Python.2
2024-04-30 22:25:56.887 [REPO]   Checking match with package id: Python.Python.3.4
2024-04-30 22:25:56.887 [REPO]   Found multiple packages with strong match fields
2024-04-30 22:25:56.887 [REPO]   Appropriate available package could not be determined
2024-04-30 22:25:56.887 [REPO]  ... using tracking package: Python.Python.3.12
2024-04-30 22:25:56.887 [REPO] Performing search: Query:[none] Filter:Id='Python.Python.3.12'[CaseInsensitive]
2024-04-30 22:25:56.894 [REPO]  ... adding available package: Python.Python.3.12

If you mean the & and the * in the installer manifest:
& is the anchor that defines the chunk and * is the alias that refer to those chunks. Both of them are part of YAML grammar. Previously when generating the manifest, the same AppsAndFeaturesEntry object was assigned to both the user scope and the machine scope of installer entries, causing ConvertTo-Yaml to use anchor and alias for them. Anyway this feature has been disabled since then.

Yeah, this is what I was referring to; I'm a bit skeptical that WinGet processes it correctly, but perhaps it does

My installation on Python 3.12 got added directly to C:\.
It doesn't look related, but has anyone else faced this same issue?


2 tests failed. diff:diff across DST (2087.17) diff:diff across DST (2087.19)

Client info
Date String   : Thu May 21 2015 19:52:05 GMT-0500 (CDT)
Locale String : May 21, 2015 at 7:52:05 PM CDT
Offset        : 360
User Agent    : Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_3) AppleWebKit/600.6.3 (KHTML, like Gecko) Version/8.0.6 Safari/600.6.3

====
diff:diff across DST (2087.17)
month diff across DST, lower bound
// Expected true
// Actual   false
false === true

====
diff:diff across DST (2087.19)
year diff across DST, lower bound
// Expected true
// Actual   false
false === true

Same errors, different OS, Browser, Time zone:
Client info
Date String   : Sun Jul 12 2015 10:00:02 GMT+0300 (Jerusalem Daylight Time)
Locale String : 7/12/2015, 10:00:02 AM
Offset        : -120
User Agent    : Mozilla/5.0 (Windows NT 6.3; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/43.0.2357.132 Safari/537.36

====
diff:diff across DST (2087.17)
month diff across DST, lower bound
// Expected true
// Actual   false
false === true

====
diff:diff across DST (2087.19)
year diff across DST, lower bound
// Expected true
// Actual   false
false === true

Occurs in Internet Explorer 11 as well.
Client info
Date String   : Sun Jul 12 2015 10:04:16 GMT+0300 (Jerusalem Daylight Time)
Locale String : 7/12/2015 10:04:16 AM
Offset        : -120
User Agent    : Mozilla/5.0 (Windows NT 6.1; WOW64; Trident/7.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; .NET4.0C; .NET4.0E; rv:11.0) like Gecko

====
diff:diff across DST (2087.17)
month diff across DST, lower bound
// Expected true
// Actual   false
false === true

====
diff:diff across DST (2087.19)
year diff across DST, lower bound
// Expected true
// Actual   false
false === true

And another time zone:
Date String   : Sun Jul 12 2015 00:08:12 GMT-0700 (Pacific Daylight Time (Mexico))
Locale String : 7/12/2015, 12:08:12 AM
Offset        : 480
User Agent    : Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/43.0.2357.132 Safari/537.36

From #2480, another time zone and in FireFox
Date String   : Mon Jul 13 2015 18:50:05 GMT+0300 (Sri Lanka Standard Time)
Locale String : 7/13/2015, 6:50:05 PM
Offset        : -120
User Agent    : Mozilla/5.0 (Windows NT 6.1; rv:39.0) Gecko/20100101 Firefox/39.0

Tracking in #3021


tsserver.js Memory leak / CPU issue

VSCode Version: 1.40.2 / Insiders: 1.41.0
OS Version: Windows 7 (Also reproduced on Windows 10 and Fedora)

Steps to Reproduce:

Open or Create a new typescript project.  The bigger the better.  A new angular project should suffice.
Open taskmanager to monitor process ram usage.  Take note of current RAM usage of process for tsserver.js
Open a .ts file and type slowly.  Make mistakes.  Note that the RAM usage of tsserver.js increases (the bigger the project the faster it will increase).  Note that the RAM usage never decreases even if you leave it running for a long time.
At some point (I havn't been able to figure out what triggers this), it will suddenly balloon up in memory usage until it hits the maximum available RAM on the system.  It will ignore the max_old_space_size setting.  e.g. In my case whether I set it to 3072 or 300 when this issue happens it will rapidly use up 20.5Gb of RAM and 100% of a cpu core.

Does this issue occur when all extensions are disabled?: No, requires the TSLint extension (tested with v1.2.3)
Additional Notes:
Both regular and insiders editions have this issue.
VSCode 1.39.2 appears to be working correctly, I've been unable to reproduce.  RAM usage will increase but never shoots up so rapidly and if left alone for a few seconds the GC will kick in and usage drops drastically.
It appears these issues might be related:
#84326 - note the 98% RAM usage in screenshot)
#84585 - Complaints about RAM, CPU and unresponsive autocompletion
There are a number of other issues mentioning VSCode being "slow" in the last few weeks which leads me to believe this issue is affecting quite a few devs.

Saw similar issue in my setup also
Code Version: 1.40.2
OS Version: win 10

Please file this issue against the tslint extension since it seems to cause this

This issue should not be closed.  The same version of TSLint works perfectly fine on older versions of VSCode which indicates the extension itself is unlikely the cause.
The change might be related to how VSCode starts a new process.  The parameters passed to start the tsserver.js process have changed between 1.39.x and 1.40.x.  1.40.x now includes the parameter --max_old_space_size.  Something in the implementation of that is likely the cause.
Even if the tslint extension has a bug, surely having --max_old_space_size=3000 would force it to crash with out of memory instead of using 22Gb of RAM?

I second what @hyarionh is saying, this issues should not be closed.
We had to downgrade all our machines to VSCode to 1.39.x, since this memory leak would freeze the entire OS.


[FEATURE] Accept kwcoco as input/output

Is your feature request related to a problem? If so, Please describe.
I'd like to use a local install of dive to visualize and annotate my datasets. These are typically stored in the kwcoco format.
Describe the solution you'd like
I'd like to be able to point to a kwcoco file and ingest it, annotate or modify the data and then export to a kwcoco file.
Describe alternatives you've considered
Converting to CSV and then uploading, but I'd rather not.
Additional context
The docs aren't as pretty as DIVE, but I do think the format is superior to anything else out there on the market as a static dataset transport.
https://gitlab.kitware.com/computer-vision/kwcoco
I've cloned and am installing DIVE. I'm going to see how easy it might be for me to add this feature. I'd like to understand this codebase better.

Also, I've been taking notes and building up general feedback as I learn how to use this tool. Overall, its really slick! The responsiveness and visuals are great! The interface is usable, but I have a few notes:
https://github.com/Kitware/dive/pull/1090/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5

hey Jon, we'd like to have this too!  Here's a couple questions that might help clarify this ask.

Are you asking about web, desktop, or both?  Web (the thing you get with docker-compose) already supports kwcoco import (but not export).  The Electron desktop client does not.  Based on your pull request, it looks like you're using web, so I think this may just be a case where it wasn't clear how to use KWCOCO with your data.  Maybe you can help us make it more clear.
I agree KWCoco is a nice format to work with.  We have particular needs for this tool which prevents us from making it the de-facto standard, but first-class support on both platforms would be great.
Here's our data format documentation if you haven't seen it: https://kitware.github.io/dive/DataFormats/#coco-and-kwcoco

I'm glad you're interested in using DIVE.  Perhaps we could meet sometime to explain the current state of kwcoco support, making the UI more intuitive, and what your needs are.
Also, fwiw, I don't think the approach in Upload.vue is quite the right way to go.

Installing a development instance on the local machine (in a way that ideally allows real-time hacking)

Server development docs (hot reload) https://github.com/Kitware/dive/tree/main/server
Client development docs (hot reload) https://github.com/Kitware/dive/tree/main/client

How to ingest a dataset (ideally you can either drag/drop a kwcoco file, a directory of images, a selection of images files), or point to it via a local path on the interface.

This will differ between web and desktop because browsers are limited in how they're allowed to interact with the filesystem, mostly for security reasons.
https://kitware.github.io/dive/Web-Version/#uploading-data is the docs, but I agree they could be more clear.

I'm mainly interested in some local "development" variant. If that is a desktop app, or a local service I run on localhost, it doesn't matter. I was using the docker-compose method of running a server and then using chrome to interact with it.

All I care about is that it is easy to import / export. The format is not designed for use as a live read/write backend, so I wouldn't expect a responsive application to work with it natively. However, if you have a computer-vision use-case that the kwcoco spec doesn't support, then we should talk about extending kwcoco so there is always a 1-to-1 between what DIVE and kwcoco can handle - and that may include DIVE-specific non-schema properties, which kwcoco is designed for.

I think a meeting would be productive.
The notes I made on usability was based on trying to use the program without reading the docs first. The current design makes it fairly easy to intuit how to use the system without spending time reading documentation (users love when they don't have to read the docs), but I think there are minor tweaks that could make it easier (plus minus technical constraints).
I have no doubt that my approach to JS is wrong. I'm a fish out of water in that world. In the meeting I'm hoping I can get some help figuring out the most effective way to start hacking on this.


Basic error handling and logging

Fixes #28

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR


Ionic no alert

Plugin version:
[x] 1.x
[] 2.x
Capacitor version:
[x] 2.x
[] 3.x
Current behavior:

Not sure if this is a bug. I run
const transparencyResult = await AppTrackingTransparency.requestPermission();
        console.log("");
        console.log("");
        console.log("");
        console.log("");
        console.log("");
        console.log(transparencyResult);
        console.log("");
        console.log("");
        console.log("");
        console.log("");

in my Ionic app and it prints
[log] - {"status":"authorized"}

when running on a device. Should I not see a confirmation message at the first run of the app when I add this plugin?
$ ionic --version
6.12.4
$ node -v
v10.16.3
$ npm -v
6.9.0

Or, how can I reset the status to factory so I know I am testing from scratch?

Hey @thomashrabe,
can you please provide a sample repo to reproduce this issue?

And what iOS version is your app running on @thomashrabe?

Company repo, not public. I think I would like to know what the default behavior should be and what to expect on the happy path...
iOS 14.4.1

Device or simulator?
The expected behavior should be the native confirm dialog asking for permission. Can you reproduce this issue in a fresh ionic/capacitor app and share the repo?

Device - but same on Simulator. Sure. I can try and share.

Hi Michael, here is the link to a project I just reproduced the issue I mentioned above
https://github.com/thomashrabe/Transparency
check
https://github.com/thomashrabe/Transparency/blob/df8862f49af5a8f7531d7f77a73aa48150487b89/src/app/app.component.ts#L16
When I run this in the simulator I see no UI asking for permission, but the app prints
[log] - {"status":"authorized"}

Hi @thomashrabe,
you are using the plugin the Capacitor 3 way while your app is built with Capacitor 2. I added a link to the v1 docs to the README for clarification. This should solve your issue.

Thanks @mahnuh, I'll check it

Hi @thomashrabe, you are using the plugin the Capacitor 3 way while your app is built with Capacitor 2. I added a link to the v1 docs to the README for clarification. This should solve your issue.

What is the difference? As the only difference that I see is the use of AppTrackingTransparencyPlugin.
But it seems even with the change that @thomashrabe did on his sample project a day later, it was not enough. The Transparency sample project even crashes when I try it on a simulator (iOS 15)

@Pendrokar did you add NSUserTrackingUsageDescription to your Info.plist as described in the docs? In @thomashrabe's example repo it is missing.

@Pendrokar  @mahnuh I got it to run back then with the changes, sorry I can not share our app code.


Make Rule of Merging Pull Request

We need to make a rule of merging a pull request.
I think a simple rule is sufficient for this time.
@sergefdrv, @Naoya-Horiguchi, please give me your comments and suggestions.

A pull request must be reviewed by one of the nec-blockchain members (@sergefdrv, @Naoya-Horiguchi and @ynamiki).
The reviewer merges the request if it is fine.
If the contributor (i.e. a creator of a Pull Request) is a member of nec-blockchain, the request must be reviewed and is merged by another member.

I am absolutely fine with these rules :+1:

+1

Thanks, let's start with the rules.
If you are inconvenienced in practice, please create an issue to update the rule.

Making rule that create a new pull request for each revision is no problem for me.
I also like "clean" (e.g. no separate commits for addressing review comments) commit history (but my ideal way is slightly different from yours: use a feature branch and merge with git merge --no-ff after review). But I have no good idea to bring the way to GitHub Pull Request straightforwardly.

Good that we share the same attitude towards keeping history clean. Frankly, I don't have a strong preference between fully linear history and the approach with git merge --no-ff. Although, a linear history looks nice, the benefit of the latter approach is that if any intermediary commit in the pull request that might break build, wouldn't break git bisect completely. That is a useful property, since we don't run CI for every commit.
A way to achieve the ability to keep track of difference from revision to revision of a pull request might be like this:

Each pull request should be made using a branch (e.g. some-feature) in a fork of the repository. After the pull request is submitted, the branch commits shouldn't be changed (no force-push).
After review comments are collected, they should be addressed preferably by directly changing the corresponding commits (by doing rebase).
The updated revision of proposed changes is pushed to the fork of the repository in a new branch named with a prefix indicating the revision number, e.g. some-feature-v2, some-feature-v3 etc.
A new pull request should be submitted using that branch. The pull request should have revision indicated in the title, like "Add some feature v2". It should also reference the previous pull request, and preferably have a short summary of changes made since the previous revision.

When reviewing revision after revision, those branches can be used to compare and see the actual delta between revisions.

We might also want to summarize the rules in https://github.com/nec-blockchain/minbft#contributing or in separate file as suggested at https://help.github.com/articles/setting-guidelines-for-repository-contributors/.

@sergefdrv Thanks a lot for compiling the procedure. It is good to me.
@Naoya-Horiguchi What do you think?

I totally agree on how we prepare a branch for pull-request. I'll follow it.

What do you think about possible actions provided by "Merge button"? https://help.github.com/articles/about-merge-methods-on-github/

@sergefdrv I like the default Merge pull request option. Other options, squashing and rebasing change the well-arranged commit history (including the hash) in a pull request.

@ynamiki Sorry, I used "Rebase and merge" to merge #14. I mistakenly thought it will rebase the topic branch on top of the the master and then merge with --no-ff option. I confused it with GitLab's "Merge commit with semi-linear history" strategy which is my personal favourite... Should we then disable other options in section "Merge button" of the project settings?

@sergefdrv No problem. I have disabled squashing and rebasing in the repository settings.
https://help.github.com/articles/about-merge-methods-on-github/

Shall I close this issue and create a new issue for https://github.com/hyperledger-labs/minbft/issues/12#issuecomment-408793668?

@ynamiki creating a new issue makes sense to me. GitHub seems not to support "subtask" feature (surprising to me), but if we have it would be suitable for this case.

Shall I close this issue and create a new issue for #12 (comment)?

@ynamiki As you prefer. We actually have a rule. Documenting the rule might be considered a separate issue.

GitHub seems not to support "subtask" feature

Issues can be "linked" instead by referring to one issue in a comment to another.

Created the separate issue for the documenting.


Modify Test case  given_width_equal_3

Modified test case to satisfy requirements given in example

As we have agreed in the issue #13, there is no issue on the Java exercise, but in the documentation.
We close the PR and we fix the documentation.
Thanks @danielfeser!


Add windows release target to makefile

at the moment I released the Windows build by hand and used a Zip-archive.


empty tag created

https://app.augur.net/markets/-9623bbd75f40501c3774a898a48b13e103da7b0eaa2d9987206a80b39dbdfa61
Empty tag fields should be ignored by system when it creates the new market

Fixed in db3acc7f64897285dbc35f5beaf50929e3e04b03.


Update emacs to 26.1

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

After running update-cb3, this needs a re-rendering. As that didn't happen would re-render and bump the build number. Likely the cause of and fix to issue ( https://github.com/conda-forge/emacs-feedstock/issues/24 ). Will also need to pull the old packages.
Will be out of the office for about a week starting later today. So cannot assist personally. Will ask @conda-forge/core to intervene (and verify that this is the correct course of action).

Will also need to pull the old packages.

You mean remove from anaconda.org?