Database.database() is nil despite being nonnull

^ How could this possibly be happening? you might ask

Oh, that's why.
Guys, this is extremely uncool.  I've just wasted several hours tearing my hair out over why the completion block in observeSingleEvent is never getting executed, only to discover that my DB ref (which "can't be nil") was nil the entire time.
I'd invite you to take a moment and try to appreciate how unbelievably frustrating this is.  With this single line of code, you have ensured a terrible on-boarding experience for new developers: it's not that they hit an error, or hit a crash, its that nothing happens at all, and they have no idea why, and you are actively derailing their intuition about where the problem might be.
Please, for the love of $DEITY, don't use NS_ASSUME_NONNULL_BEGIN.

Hey @pepasflo, sorry for the troubles you're seeing.
A few questions:

Do you have a sample project or code snippet you can share to reproduce this?
What version of Firebase are you using?
Are you calling FirebaseApp.configure()
Is anything being logged to the console when you call Database.database()?

The only situation Database.database() should fail is if FirebaseApp.configure() wasn't called before, and it should never be nil. If you're not getting any exception and database() is still nil, this is 100% a bug and should be fixed right away.
If you could please help provide that information and ideally a sample project we can get it fixed right away, and with the versioning information I can hopefully point you to a version in the meantime that's working as expected.
Sorry again for the troubles and thanks for reporting this, we really appreciate it!

@ryanwilson we used to have an assertion there that would fail on access if the database instance wasn't nil. Did we remove that?

@morganchen12 I'm fairly certain we did not - we do check two things though, if the default app is configured here:
https://github.com/firebase/firebase-ios-sdk/blob/d232d1c30ce2e36dab810324ae67d8867170cc0e/Firebase/Database/Api/FIRDatabase.m#L45
and in this method (called through the database() call) we check both the app and the URL and throw an exception if either are nil:
https://github.com/firebase/firebase-ios-sdk/blob/d232d1c30ce2e36dab810324ae67d8867170cc0e/Firebase/Database/Api/FIRDatabase.m#L72

I've seen this kind of thing happen before if there's duplicate class implementations in the runtime. @pepasflo can you share a sample that reproduces this issue?

Hi @ryanwilson
Thank you for being gracious and tolerant in the face of my crankiness.
A bit of background -- we've had Firebase working in our iOS app, and I needed to spin up a little demo app to try something out.
I created a new Xcode project, installed Firebase DB via cocoapods, dragged in a copy of our plist file from google, renamed the bundle ID of the demo app to match our production app, and pasted this into AppDelegate:
    func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?) -> Bool {
        let path = Bundle.main.path(forResource: "firebase-staging-livecoverage", ofType: "plist")!
        let options = FirebaseOptions(contentsOfFile: path)!
        FirebaseApp.configure(options: options)
        let db = Database.database()
        if db == nil { fatalError("❌ db is nil") }
        let ref = db.reference(withPath: "live/9747")
        if ref == nil { fatalError("❌ ref is nil") }
        ref.observeSingleEvent(of: DataEventType.value, with: { (snapshot) in
            print("✅ firebase snapshot: \(snapshot)")
        }, withCancel: { (error) in
            print("❌ firebase error: \(error)")
        })
        window?.rootViewController = UIViewController()
        return true
    }

which fails with Fatal error: ❌ db is nil.
Pasting the same code into our production app works as expected, returning the JSON corresponding to live/9747.
My hunch is that this is 99% likely to be some sort of configuration step which I've missed or other mistake I've made while setting up the demo project.
But, rather than solving my particular problem, hopefully we can figure out the circumstances under which the db is nil and address that issue for everyone.
Happy to follow-up with more details!

No problem at all, this is an ugly bug and hopefully we can track down what's causing this.
Are you able to paste the contents Podfile.lock (just relevant Firebase lines are fine) so we can verify versions?
In the meantime I'll take a look to see if I can reproduce this.

Hmm, looks like I ended up with different versions of Firebase between the production app and the demo.
Working production app:
$ cat Podfile.lock | grep -i firebase
  - Firebase (5.15.0):
    - Firebase/Core (= 5.15.0)
  - Firebase/Analytics (5.15.0):
    - Firebase/Core
  - Firebase/Core (5.15.0):
    - Firebase/CoreOnly
    - FirebaseAnalytics (= 5.4.0)
  - Firebase/CoreOnly (5.15.0):
    - FirebaseCore (= 5.1.10)
  - Firebase/Database (5.15.0):
    - Firebase/CoreOnly
    - FirebaseDatabase (= 5.0.4)
  - Firebase/RemoteConfig (5.15.0):
    - Firebase/Core
    - FirebaseRemoteConfig (= 3.1.0)
  - FirebaseABTesting (2.0.0):
    - FirebaseCore (~> 5.0)
  - FirebaseAnalytics (5.4.0):
    - FirebaseCore (~> 5.1)
    - FirebaseInstanceID (~> 3.3)
  - FirebaseAuthInterop (1.0.0)
  - FirebaseCore (5.1.10):
  - FirebaseDatabase (5.0.4):
    - FirebaseAuthInterop (~> 1.0)
    - FirebaseCore (~> 5.1)
  - FirebaseInstanceID (3.3.0):
    - FirebaseCore (~> 5.1)
  - FirebaseRemoteConfig (3.1.0):
    - FirebaseABTesting (~> 2.0)
    - FirebaseAnalytics (~> 5.3)
    - FirebaseCore (~> 5.1)
    - FirebaseInstanceID (~> 3.3)
  - Firebase
  - Firebase/Analytics
  - Firebase/Database
  - Firebase/RemoteConfig
  Firebase: 8bb9268bff82374f2cbaaabb143e725743c316ae
  FirebaseABTesting: 1f50b8d50f5e3469eea54e7463a7b7fe221d1f5e
  FirebaseAnalytics: c06f9d70577d79074214700a71fd5d39de5550fb
  FirebaseAuthInterop: 0ffa57668be100582bb7643d4fcb7615496c41fc
  FirebaseCore: 35747502d9e8c6ee217385ad04446c7c2aaf9c5c
  FirebaseDatabase: 0621689f77528d62b47e1c06ca737c4c19275d1a
  FirebaseInstanceID: e2fa4cb35ef5558c200f7f0ad8a53e212215f93e
  FirebaseRemoteConfig: 7e11c65f0769c09bff6947997c209515058c5318

Demo with nil db:
$ cat Podfile.lock | grep -i firebase
  - FirebaseAuthInterop (1.0.0)
  - FirebaseCore (5.2.0):
  - FirebaseDatabase (5.1.0):
    - FirebaseAuthInterop (~> 1.0)
    - FirebaseCore (~> 5.2)
  - FirebaseDatabase
    - FirebaseAuthInterop
    - FirebaseCore
    - FirebaseDatabase
  FirebaseAuthInterop: 0ffa57668be100582bb7643d4fcb7615496c41fc
  FirebaseCore: ea2d1816723ef21492b8e9113303e1350db5e08c
  FirebaseDatabase: 23acb0c53cd4d4070a427b60100b2e4aaa97c45d

Hmm, I'll try recreating that demo and see if I can get it to use the latest Firebase from cocoapods.

This is super helpful, please do try the latest version and let us know if you get the same issue. I'll be away from the keyboard for a bit but back within the next hour to check in.

Oh, I think I see the versioning issue: I called for FirebaseDatabase in the demo, not Firebase/Database as in our production app.
$ cat Podfile
platform :ios, '12.1'
target 'FirebaseiOSDemo4' do
  use_frameworks!
  pod 'FirebaseDatabase'
end

which results in
$ pod install
Analyzing dependencies
Downloading dependencies
Installing FirebaseAuthInterop (1.0.0)
Installing FirebaseCore (5.3.0)
Installing FirebaseDatabase (5.1.0)
Installing GoogleUtilities (5.3.7)
Installing leveldb-library (1.20)
Generating Pods project
Integrating client project

Aha.
$ cat Podfile
platform :ios, '12.1'
target 'FirebaseiOSDemo5' do
  use_frameworks!
  pod 'Firebase/Database'
end

$ pod install
Analyzing dependencies
Downloading dependencies
Installing Firebase (5.17.0)
Installing FirebaseAuthInterop (1.0.0)
Installing FirebaseCore (5.3.0)
Installing FirebaseDatabase (5.1.0)
Installing GoogleUtilities (5.3.7)
Installing leveldb-library (1.20)
Generating Pods project
Integrating client project

Hmm, same failure in the demo with the latest firebase: Fatal error: ❌ db is nil.
I'll see if I can create a new google plist from scratch for the demo.

Nope.  Registered a new app with Firebase, new plist, changed the app ID to match (tv.flosports.ott.staging-livecoverage-demo2), db is still nil.
There must be some setup step I'm overlooking.

Instead of renaming the plist, I went with the default name (GoogleService-Info.plist) and changed the configure line to FirebaseApp.configure(), same error (db is nil)

Ok, it turns out this was due to not including Firebase/Core in the Podfile.
This:
$ cat Podfile
platform :ios, '12.1'
target 'FirebaseiOSDemo5' do
  use_frameworks!
  pod 'Firebase/Database'
end

results in the db is nil failure.
This does not:
$ cat Podfile
platform :ios, '12.1'
target 'FirebaseiOSDemo5' do
  use_frameworks!
  pod 'Firebase/Core'
  pod 'Firebase/Database'
end

Very interesting, thanks so much for tracking this down.
FirebaseCore should be getting pulled in (and I see it there as well), I'm really unsure as to why this is failing. I'll try to find out why Core isn't configuring properly when Firebase/Core isn't explicitly included.

Yep, Firebase/Core shouldn't be needed for Database to initialize properly.

Hmm, it looks like Core was already listed as a pod dependency on Database, not sure why this is happening.
    {
      "dependencies": {
        "Firebase/CoreOnly": [

        ],
        "FirebaseDatabase": "5.1.0"
      },
      "name": "Database"
    },

https://github.com/CocoaPods/Specs/blob/master/Specs/0/3/5/Firebase/5.17.0/Firebase.podspec.json#L222-L230

I created an example project, pasted the exact application(_:didFinishLaunchingWithOptions:) code above, used my own GoogleService-Info.plist and renamed it to firebase-staging-livecoverage.plist, and it did not fail.
I get a Permission Denied error on the database reference (since there's nothing there and my project has default Auth rules set up.
I tried using FirebaseDatabase in the Podfile as well, but it still succeeds.
A few other thoughts:

What version of Xcode are you running?
Which simulator?
Does this happen when you run as a regular app, or is it running as the host of a unit test / UI test?

Thanks again for trying to help us solve this, I want to make sure we can get you back up and running as well as verify all our documentation is correct.

Ok, full reproduction details:
Recreate the failing case

Create a new Single-page iOS project in Xcode, named 'JustFirebaseDatabase'
Edit the app ID to match that used by your GoogleService-Info.plist
Copy your GoogleService-Info.plist into the project
Create this Podfile:

platform :ios, '12.1'
target 'JustFirebaseDatabase' do
  use_frameworks!
  pod 'Firebase/Database'
end

run pod install

$ pod install
Analyzing dependencies
Downloading dependencies
Installing Firebase (5.17.0)
Installing FirebaseAuthInterop (1.0.0)
Installing FirebaseCore (5.3.0)
Installing FirebaseDatabase (5.1.0)
Installing GoogleUtilities (5.3.7)
Installing leveldb-library (1.20)
Generating Pods project
Integrating client project

this will result in the following Podfile.lock:
$ cat JustFirebaseDatabase/Podfile.lock
PODS:
  - Firebase/CoreOnly (5.17.0):
    - FirebaseCore (= 5.3.0)
  - Firebase/Database (5.17.0):
    - Firebase/CoreOnly
    - FirebaseDatabase (= 5.1.0)
  - FirebaseAuthInterop (1.0.0)
  - FirebaseCore (5.3.0):
    - GoogleUtilities/Logger (~> 5.2)
  - FirebaseDatabase (5.1.0):
    - FirebaseAuthInterop (~> 1.0)
    - FirebaseCore (~> 5.2)
    - leveldb-library (~> 1.18)
  - GoogleUtilities/Environment (5.3.7)
  - GoogleUtilities/Logger (5.3.7):
    - GoogleUtilities/Environment
  - leveldb-library (1.20)

DEPENDENCIES:
  - Firebase/Database

SPEC REPOS:
  https://github.com/cocoapods/specs.git:
    - Firebase
    - FirebaseAuthInterop
    - FirebaseCore
    - FirebaseDatabase
    - GoogleUtilities
    - leveldb-library

SPEC CHECKSUMS:
  Firebase: 59d557e064217fab6a03ff00baa73c06e73832e6
  FirebaseAuthInterop: 0ffa57668be100582bb7643d4fcb7615496c41fc
  FirebaseCore: c0c4befb82374d6aef64d800e569f47625352edc
  FirebaseDatabase: 23acb0c53cd4d4070a427b60100b2e4aaa97c45d
  GoogleUtilities: 111a012f4c3a29c9e7c954c082fafd6ee3c999c0
  leveldb-library: 08cba283675b7ed2d99629a4bc5fd052cd2bb6a5

PODFILE CHECKSUM: 2cef90d2435fe3ba5a9627ce213f5c36413140e7

COCOAPODS: 1.5.3

Replace AppDelegate.swift with this:
import UIKit
import FirebaseCore
import FirebaseDatabase

@UIApplicationMain
class AppDelegate: UIResponder, UIApplicationDelegate {

    var window: UIWindow?

    func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?) -> Bool {
        FirebaseApp.configure()
        let db = Database.database()
        if db == nil { fatalError("❌ db is nil") }
        let ref = db.reference(withPath: "live/9747")
        if ref == nil { fatalError("❌ ref is nil") }
        ref.observeSingleEvent(of: DataEventType.value, with: { (snapshot) in
            print("✅ firebase snapshot: \(snapshot)")
        }, withCancel: { (error) in
            print("❌ firebase error: \(error)")
        })
        window?.rootViewController = UIViewController()
        return true
    }
}

(replace reference(withPath: "live/9747") with a path which exists in your DB)

Run the app, see that it hits the fatalError with ❌ db is nil

Recreate the working case

Create a new Single-page iOS project in Xcode, named 'AlsoFirebaseCore'
Edit the app ID to match that used by your GoogleService-Info.plist
Copy your GoogleService-Info.plist into the project
Create this Podfile:

platform :ios, '12.1'
target 'AlsoFirebaseCore' do
  use_frameworks!
  pod 'Firebase/Core'
  pod 'Firebase/Database'
end

run pod install

$ pod install
Analyzing dependencies
Downloading dependencies
Installing Firebase (5.17.0)
Installing FirebaseAnalytics (5.6.0)
Installing FirebaseAuthInterop (1.0.0)
Installing FirebaseCore (5.3.0)
Installing FirebaseDatabase (5.1.0)
Installing FirebaseInstanceID (3.5.0)
Installing GoogleAppMeasurement (5.6.0)
Installing GoogleUtilities (5.3.7)
Installing leveldb-library (1.20)
Installing nanopb (0.3.901)
Generating Pods project
Integrating client project

(Notice that it installed a different set of dependencies)
This will result in the following Podfile.lock:
$ cat AlsoFirebaseCore/Podfile.lock
PODS:
  - Firebase/Core (5.17.0):
    - Firebase/CoreOnly
    - FirebaseAnalytics (= 5.6.0)
  - Firebase/CoreOnly (5.17.0):
    - FirebaseCore (= 5.3.0)
  - Firebase/Database (5.17.0):
    - Firebase/CoreOnly
    - FirebaseDatabase (= 5.1.0)
  - FirebaseAnalytics (5.6.0):
    - FirebaseCore (~> 5.3)
    - FirebaseInstanceID (~> 3.5)
    - GoogleAppMeasurement (= 5.6.0)
    - GoogleUtilities/AppDelegateSwizzler (~> 5.2)
    - GoogleUtilities/MethodSwizzler (~> 5.2)
    - GoogleUtilities/Network (~> 5.2)
    - "GoogleUtilities/NSData+zlib (~> 5.2)"
    - nanopb (~> 0.3)
  - FirebaseAuthInterop (1.0.0)
  - FirebaseCore (5.3.0):
    - GoogleUtilities/Logger (~> 5.2)
  - FirebaseDatabase (5.1.0):
    - FirebaseAuthInterop (~> 1.0)
    - FirebaseCore (~> 5.2)
    - leveldb-library (~> 1.18)
  - FirebaseInstanceID (3.5.0):
    - FirebaseCore (~> 5.3)
    - GoogleUtilities/Environment (~> 5.3)
    - GoogleUtilities/UserDefaults (~> 5.3)
  - GoogleAppMeasurement (5.6.0):
    - GoogleUtilities/AppDelegateSwizzler (~> 5.2)
    - GoogleUtilities/MethodSwizzler (~> 5.2)
    - GoogleUtilities/Network (~> 5.2)
    - "GoogleUtilities/NSData+zlib (~> 5.2)"
    - nanopb (~> 0.3)
  - GoogleUtilities/AppDelegateSwizzler (5.3.7):
    - GoogleUtilities/Environment
    - GoogleUtilities/Logger
    - GoogleUtilities/Network
  - GoogleUtilities/Environment (5.3.7)
  - GoogleUtilities/Logger (5.3.7):
    - GoogleUtilities/Environment
  - GoogleUtilities/MethodSwizzler (5.3.7):
    - GoogleUtilities/Logger
  - GoogleUtilities/Network (5.3.7):
    - GoogleUtilities/Logger
    - "GoogleUtilities/NSData+zlib"
    - GoogleUtilities/Reachability
  - "GoogleUtilities/NSData+zlib (5.3.7)"
  - GoogleUtilities/Reachability (5.3.7):
    - GoogleUtilities/Logger
  - GoogleUtilities/UserDefaults (5.3.7):
    - GoogleUtilities/Logger
  - leveldb-library (1.20)
  - nanopb (0.3.901):
    - nanopb/decode (= 0.3.901)
    - nanopb/encode (= 0.3.901)
  - nanopb/decode (0.3.901)
  - nanopb/encode (0.3.901)

DEPENDENCIES:
  - Firebase/Core
  - Firebase/Database

SPEC REPOS:
  https://github.com/cocoapods/specs.git:
    - Firebase
    - FirebaseAnalytics
    - FirebaseAuthInterop
    - FirebaseCore
    - FirebaseDatabase
    - FirebaseInstanceID
    - GoogleAppMeasurement
    - GoogleUtilities
    - leveldb-library
    - nanopb

SPEC CHECKSUMS:
  Firebase: 59d557e064217fab6a03ff00baa73c06e73832e6
  FirebaseAnalytics: 75e4bbc6417d190cc98ec1f17c41a4fad4c2c976
  FirebaseAuthInterop: 0ffa57668be100582bb7643d4fcb7615496c41fc
  FirebaseCore: c0c4befb82374d6aef64d800e569f47625352edc
  FirebaseDatabase: 23acb0c53cd4d4070a427b60100b2e4aaa97c45d
  FirebaseInstanceID: 4522aad88f69297622062c0e9ffccdee3dd9b151
  GoogleAppMeasurement: 008e04ecd8efedd97a693aea8634aefe220bd26e
  GoogleUtilities: 111a012f4c3a29c9e7c954c082fafd6ee3c999c0
  leveldb-library: 08cba283675b7ed2d99629a4bc5fd052cd2bb6a5
  nanopb: 2901f78ea1b7b4015c860c2fdd1ea2fee1a18d48

PODFILE CHECKSUM: 573b44ea9327c330f8243f128b572a217d0dc676

COCOAPODS: 1.5.3

Replace AppDelegate.swift with this:
import UIKit
import FirebaseCore
import FirebaseDatabase

@UIApplicationMain
class AppDelegate: UIResponder, UIApplicationDelegate {

    var window: UIWindow?

    func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?) -> Bool {
        FirebaseApp.configure()
        let db = Database.database()
        if db == nil { fatalError("❌ db is nil") }
        let ref = db.reference(withPath: "live/9747")
        if ref == nil { fatalError("❌ ref is nil") }
        ref.observeSingleEvent(of: DataEventType.value, with: { (snapshot) in
            print("✅ firebase snapshot: \(snapshot)")
        }, withCancel: { (error) in
            print("❌ firebase error: \(error)")
        })
        window?.rootViewController = UIViewController()
        return true
    }
}

(replace reference(withPath: "live/9747") with a path which exists in your DB)

Run the app, see that it succeeds with ✅ firebase snapshot: Snap (9747) {...

Podfile.lock differences
The only difference between these two projects seems to be the dependencies which get installed:
$ diff -urN JustFirebaseDatabase/Podfile.lock AlsoFirebaseCore/Podfile.lock
--- JustFirebaseDatabase/Podfile.lock	2019-02-22 12:43:18.000000000 -0600
+++ AlsoFirebaseCore/Podfile.lock	2019-02-22 12:49:58.000000000 -0600
@@ -1,9 +1,21 @@
 PODS:
+  - Firebase/Core (5.17.0):
+    - Firebase/CoreOnly
+    - FirebaseAnalytics (= 5.6.0)
   - Firebase/CoreOnly (5.17.0):
     - FirebaseCore (= 5.3.0)
   - Firebase/Database (5.17.0):
     - Firebase/CoreOnly
     - FirebaseDatabase (= 5.1.0)
+  - FirebaseAnalytics (5.6.0):
+    - FirebaseCore (~> 5.3)
+    - FirebaseInstanceID (~> 3.5)
+    - GoogleAppMeasurement (= 5.6.0)
+    - GoogleUtilities/AppDelegateSwizzler (~> 5.2)
+    - GoogleUtilities/MethodSwizzler (~> 5.2)
+    - GoogleUtilities/Network (~> 5.2)
+    - "GoogleUtilities/NSData+zlib (~> 5.2)"
+    - nanopb (~> 0.3)
   - FirebaseAuthInterop (1.0.0)
   - FirebaseCore (5.3.0):
     - GoogleUtilities/Logger (~> 5.2)
@@ -11,31 +23,70 @@
     - FirebaseAuthInterop (~> 1.0)
     - FirebaseCore (~> 5.2)
     - leveldb-library (~> 1.18)
+  - FirebaseInstanceID (3.5.0):
+    - FirebaseCore (~> 5.3)
+    - GoogleUtilities/Environment (~> 5.3)
+    - GoogleUtilities/UserDefaults (~> 5.3)
+  - GoogleAppMeasurement (5.6.0):
+    - GoogleUtilities/AppDelegateSwizzler (~> 5.2)
+    - GoogleUtilities/MethodSwizzler (~> 5.2)
+    - GoogleUtilities/Network (~> 5.2)
+    - "GoogleUtilities/NSData+zlib (~> 5.2)"
+    - nanopb (~> 0.3)
+  - GoogleUtilities/AppDelegateSwizzler (5.3.7):
+    - GoogleUtilities/Environment
+    - GoogleUtilities/Logger
+    - GoogleUtilities/Network
   - GoogleUtilities/Environment (5.3.7)
   - GoogleUtilities/Logger (5.3.7):
     - GoogleUtilities/Environment
+  - GoogleUtilities/MethodSwizzler (5.3.7):
+    - GoogleUtilities/Logger
+  - GoogleUtilities/Network (5.3.7):
+    - GoogleUtilities/Logger
+    - "GoogleUtilities/NSData+zlib"
+    - GoogleUtilities/Reachability
+  - "GoogleUtilities/NSData+zlib (5.3.7)"
+  - GoogleUtilities/Reachability (5.3.7):
+    - GoogleUtilities/Logger
+  - GoogleUtilities/UserDefaults (5.3.7):
+    - GoogleUtilities/Logger
   - leveldb-library (1.20)
+  - nanopb (0.3.901):
+    - nanopb/decode (= 0.3.901)
+    - nanopb/encode (= 0.3.901)
+  - nanopb/decode (0.3.901)
+  - nanopb/encode (0.3.901)

 DEPENDENCIES:
+  - Firebase/Core
   - Firebase/Database

 SPEC REPOS:
   https://github.com/cocoapods/specs.git:
     - Firebase
+    - FirebaseAnalytics
     - FirebaseAuthInterop
     - FirebaseCore
     - FirebaseDatabase
+    - FirebaseInstanceID
+    - GoogleAppMeasurement
     - GoogleUtilities
     - leveldb-library
+    - nanopb

 SPEC CHECKSUMS:
   Firebase: 59d557e064217fab6a03ff00baa73c06e73832e6
+  FirebaseAnalytics: 75e4bbc6417d190cc98ec1f17c41a4fad4c2c976
   FirebaseAuthInterop: 0ffa57668be100582bb7643d4fcb7615496c41fc
   FirebaseCore: c0c4befb82374d6aef64d800e569f47625352edc
   FirebaseDatabase: 23acb0c53cd4d4070a427b60100b2e4aaa97c45d
+  FirebaseInstanceID: 4522aad88f69297622062c0e9ffccdee3dd9b151
+  GoogleAppMeasurement: 008e04ecd8efedd97a693aea8634aefe220bd26e
   GoogleUtilities: 111a012f4c3a29c9e7c954c082fafd6ee3c999c0
   leveldb-library: 08cba283675b7ed2d99629a4bc5fd052cd2bb6a5
+  nanopb: 2901f78ea1b7b4015c860c2fdd1ea2fee1a18d48

-PODFILE CHECKSUM: 2cef90d2435fe3ba5a9627ce213f5c36413140e7
+PODFILE CHECKSUM: 573b44ea9327c330f8243f128b572a217d0dc676

 COCOAPODS: 1.5.3

My guess
Since most of this is written in Obj-C, my first guess is that if a certain dependency isn't installed, this ends up translating into an object being nil somewhere inside of Firebase, and that object is being called without being checked (which results in nothing happening at all, because Obj-c is nil-tolerant).
Of course, I haven't delved into the code, so take that with a grain of salt :)

To summarize, my understanding is that this (missing) single line in the Podfile is what causes this issue:
$ diff -urN JustFirebaseDatabase/Podfile AlsoFirebaseCore/Podfile
--- JustFirebaseDatabase/Podfile	2019-02-22 12:42:51.000000000 -0600
+++ AlsoFirebaseCore/Podfile	2019-02-22 12:49:51.000000000 -0600
@@ -1,5 +1,6 @@
 platform :ios, '12.1'
-target 'JustFirebaseDatabase' do
+target 'AlsoFirebaseCore' do
   use_frameworks!
+  pod 'Firebase/Core'
   pod 'Firebase/Database'
 end

Here's the difference in resulting installed dependencies in a bit easier to read form:
$ cat JustFirebaseDatabase/Podfile.lock | grep '-' | grep -v 'leveldb-' | awk '{print $2}' | sort | uniq > /tmp/justdb.txt
$ cat AlsoFirebaseCore/Podfile.lock | grep '-' | grep -v 'leveldb-' | awk '{print $2}' | sort | uniq > /tmp/alsocore.txt
$ diff -urN /tmp/justdb.txt /tmp/alsocore.txt
--- /tmp/justdb.txt	2019-02-22 13:11:43.000000000 -0600
+++ /tmp/alsocore.txt	2019-02-22 13:11:56.000000000 -0600
@@ -1,9 +1,23 @@
+"GoogleUtilities/NSData+zlib
+"GoogleUtilities/NSData+zlib"
 Firebase
+Firebase/Core
 Firebase/CoreOnly
 Firebase/Database
+FirebaseAnalytics
 FirebaseAuthInterop
 FirebaseCore
 FirebaseDatabase
+FirebaseInstanceID
+GoogleAppMeasurement
 GoogleUtilities
+GoogleUtilities/AppDelegateSwizzler
 GoogleUtilities/Environment
 GoogleUtilities/Logger
+GoogleUtilities/MethodSwizzler
+GoogleUtilities/Network
+GoogleUtilities/Reachability
+GoogleUtilities/UserDefaults
+nanopb
+nanopb/decode
+nanopb/encode

@pepasflo I appreciate the full set of details!
Attempting to match your setup, with any differences that matter in bold:

Created thisPodfile:

platform :ios, '12.1'
target 'DatabaseNilError' do
  use_frameworks!
  pod 'Firebase/Database'
end

Only the project name is different.

ran pod install

$ pod install
Analyzing dependencies
Downloading dependencies
Installing Firebase (5.17.0)
Installing FirebaseAuthInterop (1.0.0)
Installing FirebaseCore (5.3.0)
Installing FirebaseDatabase (5.1.0)
Installing GoogleUtilities (5.3.7)
Installing leveldb-library (1.20)
Generating Pods project
Integrating client project

Same as your output.
Podfile.lock contents:
PODS:
  - Firebase/CoreOnly (5.17.0):
    - FirebaseCore (= 5.3.0)
  - Firebase/Database (5.17.0):
    - Firebase/CoreOnly
    - FirebaseDatabase (= 5.1.0)
  - FirebaseAuthInterop (1.0.0)
  - FirebaseCore (5.3.0):
    - GoogleUtilities/Logger (~> 5.2)
  - FirebaseDatabase (5.1.0):
    - FirebaseAuthInterop (~> 1.0)
    - FirebaseCore (~> 5.2)
    - leveldb-library (~> 1.18)
  - GoogleUtilities/Environment (5.3.7)
  - GoogleUtilities/Logger (5.3.7):
    - GoogleUtilities/Environment
  - leveldb-library (1.20)

DEPENDENCIES:
  - Firebase/Database

SPEC REPOS:
  https://github.com/cocoapods/specs.git:
    - Firebase
    - FirebaseAuthInterop
    - FirebaseCore
    - FirebaseDatabase
    - GoogleUtilities
    - leveldb-library

SPEC CHECKSUMS:
  Firebase: 59d557e064217fab6a03ff00baa73c06e73832e6
  FirebaseAuthInterop: 0ffa57668be100582bb7643d4fcb7615496c41fc
  FirebaseCore: c0c4befb82374d6aef64d800e569f47625352edc
  FirebaseDatabase: 23acb0c53cd4d4070a427b60100b2e4aaa97c45d
  GoogleUtilities: 111a012f4c3a29c9e7c954c082fafd6ee3c999c0
  leveldb-library: 08cba283675b7ed2d99629a4bc5fd052cd2bb6a5

PODFILE CHECKSUM: e5fd3d51dbdd4a9923fb821fdc992f4390e4186e

COCOAPODS: 1.6.0

Difference: CocoaPods version.
Replaced the AppDelegate.swift with the exact same code. I didn't bother to place the item in the Database since it should fail before then.
Did not fail with fatalError. Output to the console:
2019-02-22 14:31:26.598912-0500 DatabaseNilError[8205:19353874] 5.17.0 - [Firebase/Core][I-COR000022] Firebase Analytics is not available. To add it, include Firebase/Core in the Podfile or add FirebaseAnalytics.framework to the Link Build Phase
2019-02-22 14:31:26.957198-0500 DatabaseNilError[8205:19353873] 5.17.0 - [Firebase/Database][I-RDB038012] Listener at /live/9747 failed: permission_denied
❌ firebase error: Error Domain=com.firebase Code=1 "Permission Denied" UserInfo={NSLocalizedDescription=Permission Denied}

The biggest difference appears to be CocoaPods 1.5.3 vs 1.6.0 which shouldn't affect this but I still want to try to reproduce it.
Does anything get logged to the console for you in the failure case?

@ryanwilson oh interesting, I've never had anything trigger that error block yet.
This is what I see in the console:
2019-02-22 16:28:02.201806-0600 JustFirebaseDatabase[83479:8944760] libMobileGestalt MobileGestalt.c:890: MGIsDeviceOneOfType is not supported on this platform.
2019-02-22 16:28:02.307509-0600 JustFirebaseDatabase[83479:8944868] 5.17.0 - [Firebase/Core][I-COR000022] Firebase Analytics is not available. To add it, include Firebase/Core in the Podfile or add FirebaseAnalytics.framework to the Link Build Phase
Fatal error: ❌ db is nil: file /Users/jpepas/projects/JustFirebaseDatabase/JustFirebaseDatabase/AppDelegate.swift, line 22
2019-02-22 16:28:05.488101-0600 JustFirebaseDatabase[83479:8944760] Fatal error: ❌ db is nil: file /Users/jpepas/projects/JustFirebaseDatabase/JustFirebaseDatabase/AppDelegate.swift, line 22

Note: what started me down this rabbit hole was trying to get Firebase working on tvOS.  I had created a similar trivial demo app, noticed that it did work, and fell back to creating a trivial iOS demo as a sanity-check (which is what let to this thread).  I'm happy to report that I have Firebase/Database working on tvOS after following the example provided with firebase-ios-sdk: https://github.com/firebase/firebase-ios-sdk/issues/10#issuecomment-466568310

I wonder if the tvOS bug is related to #2157. Is it possible your project has -ObjC missing? It shouldn't be the case, but worth a look.
Otherwise, I can help you try to step through this to debug it.
As a very brief overview, FirebaseCore has a component system to create, cache, and deallocate the singletons of each SDK. The singleton should be created as follows:

FirebaseDatabase registers as a FIRLibrary in a +load method.
a) FirebaseDatabase provides a method called componentsToRegister:, this is done in FIRDatabaseComponent.m, registering a protocol with functionality that the instance provides. In this case, it's just returning instances of Database.
FirebaseApp.configure() is called.
a) This creates a FIRComponentContainer and should call that componentsToRegister: on all registered libraries.
The user tries to access Database.database().
a) This asks the FIRComponentContainer for an instance with the above registered protocol.
b) If the instance is nil, it'll try to create it with the creation block from componentsToRegister:.
c) In Database's situation, it'll return a FIRDatabaseComponent that handles instance management.

Somewhere along those lines it's failing, it would be great if we could find out where but unfortunately I still can't reproduce it.
Here are the code locations for each associated step, if you could try to set breakpoints and follow along to see where it drops off:

https://github.com/firebase/firebase-ios-sdk/blob/2c2614e9c8dc48fdaad838ea16f40f1dbad0c06b/Firebase/Database/Api/FIRDatabaseComponent.m#L58 This must be called, if not there's no chance of Database ever being initialized.
a) Shouldn't be triggered yet, see step 2a below.

In your own code
a) https://github.com/firebase/firebase-ios-sdk/blob/2c2614e9c8dc48fdaad838ea16f40f1dbad0c06b/Firebase/Database/Api/FIRDatabaseComponent.m#L66 The database provider should be nonnull here.

With no crashes, it's at least getting to here: https://github.com/firebase/firebase-ios-sdk/blob/2c2614e9c8dc48fdaad838ea16f40f1dbad0c06b/Firebase/Database/Api/FIRDatabase.m#L82
a) The instance fetching from the componentContainer should happen here: https://github.com/firebase/firebase-ios-sdk/blob/2c2614e9c8dc48fdaad838ea16f40f1dbad0c06b/Firebase/Core/FIRComponentContainer.m#L148
b) Since the above should be nil, the instance should be created in https://github.com/firebase/firebase-ios-sdk/blob/2c2614e9c8dc48fdaad838ea16f40f1dbad0c06b/Firebase/Core/FIRComponentContainer.m#L117 This should return a valid instance now of FIRDatabaseComponent.
c)  https://github.com/firebase/firebase-ios-sdk/blob/2c2614e9c8dc48fdaad838ea16f40f1dbad0c06b/Firebase/Database/Api/FIRDatabaseComponent.m#L114 should be called now to actually create the instance of Database and return it to you.

I know this system is a little complex (tl;dr - it's needed because an instance of Database isn't valid without a FirebaseApp) but hopefully that helps summarize it. Happy to answer any questions about it or clarify further, but hopefully we can find where in that series of steps things fail for you.

@ryanwilson thanks for the details steps, I'll set some breakpoints later today

Hmm, so under the JustFirebaseDatabase project, the [FirebaseDatabase load] method breakpoint never gets hit.  Under AlsoFirebaseCore, it does.

I don't even understand how that's possible 😟

Is -ObjC included in the Other Linker Flags Build Setting?

Ahhh, it is not.
$ grep -r -I -i objc JustFirebaseDatabase AlsoFirebaseCore 2>/dev/null | grep '\.xcconfig' | grep -e '-ObjC'
AlsoFirebaseCore/Pods/Target Support Files/Pods-AlsoFirebaseCore/Pods-AlsoFirebaseCore.release.xcconfig:OTHER_LDFLAGS = $(inherited) -ObjC -l"c++" -l"icucore" -l"sqlite3" -l"z" -framework "CFNetwork" -framework "FIRAnalyticsConnector" -framework "FirebaseAnalytics" -framework "FirebaseCore" -framework "FirebaseCoreDiagnostics" -framework "FirebaseDatabase" -framework "FirebaseInstanceID" -framework "Foundation" -framework "GoogleAppMeasurement" -framework "GoogleUtilities" -framework "Security" -framework "StoreKit" -framework "SystemConfiguration" -framework "leveldb" -framework "nanopb"
AlsoFirebaseCore/Pods/Target Support Files/Pods-AlsoFirebaseCore/Pods-AlsoFirebaseCore.debug.xcconfig:OTHER_LDFLAGS = $(inherited) -ObjC -l"c++" -l"icucore" -l"sqlite3" -l"z" -framework "CFNetwork" -framework "FIRAnalyticsConnector" -framework "FirebaseAnalytics" -framework "FirebaseCore" -framework "FirebaseCoreDiagnostics" -framework "FirebaseDatabase" -framework "FirebaseInstanceID" -framework "Foundation" -framework "GoogleAppMeasurement" -framework "GoogleUtilities" -framework "Security" -framework "StoreKit" -framework "SystemConfiguration" -framework "leveldb" -framework "nanopb"

So, one of these podspecs must be setting -ObjC:
+Firebase/Core
+FirebaseAnalytics
+FirebaseInstanceID
+GoogleAppMeasurement
+GoogleUtilities/AppDelegateSwizzler
+GoogleUtilities/MethodSwizzler
+GoogleUtilities/Network
+GoogleUtilities/Reachability
+GoogleUtilities/UserDefaults
+nanopb
+nanopb/decode
+nanopb/encode

CocoaPods should be adding -ObjC automatically.

So it sounds like the situation is:

CocoaPods 1.5.3

JustFirebaseDatabase

Does not Automatically adds the -ObjC flag

AlsoFirebaseCore

Automatically adds the -ObjC flag

CocoaPods 1.6.0

JustFirebaseDatabase

Automatically adds the -ObjC flag

AlsoFirebaseCore

Automatically adds the -ObjC flag

Yep. I should have remembered https://github.com/CocoaPods/CocoaPods/pull/7946 sooner when you said you were doing tvOS.

Would it be reasonable to add -ObjC to the podspec, to prevent other users who aren't on the latest version of cocoapods from hitting this bug?

Just for some perspective, our team is actually still on cocoapods 1.4.0 (I use a more up-to-date version for personal / one-off projects).
Why would we do this?
It turns out that different versions of cocoapods, despite being essentially feature compatible, will produce very different Xcode project files.  If you have two team members using different versions of cocoapods, the result is that a tiny change to the pod file file will cause a giant amount of noise in the PR if a different version of cocoapods is used.
So there's a pressure on teams to all stick to the same version of cocoapods.  The easiest way to ensure everyone is on the same page is to add a Gemfile to the project which specifies a particular version of cocoapods.  At that point, keeping the team up-to-date with the latest version of cocoapods becomes a maintenance task, which competes with all of the other priorities of the team, and if it ain't broke...
This leads me to suspect there may be a lot of teams who are using an older version of cocoapods.

Just for reference, here is how we avoid having to type bundle exec pod all of the time, to ensure that we use the project's version of pod, and not any other version of pod (e.g. from homebrew):
We have a script called pod in our project.  If it finds a Gemfile in any parent directly, it runs bundle exec pod.  If not, it uses whatever the system pod is.
We then symlink this pod script into our $PATH.
Here is the pod script:
#!/usr/bin/env python

# A wrapper for 'pod' which detects if it should run 'bundle exec pod' or
# use the system 'pod' command, based on the presence of a 'Gemfile'.

# If a Gemfile exists in any directory above pwd, 'bundle exec pod' should
# be used.  Otherwise, the system 'pod' is used.

# Expected behavior:
#    $ pwd
#    /Users/foo/github/some_repo
#    $ pod --version
#    1.4.0
#    $ cd /tmp
#    $ pod --version
#    1.5.3

import os
import sys

def gemfile_exists():
    # Ascend up the directory tree looking for a Gemfile.
    gempath = 'Gemfile'
    while True:
        if os.path.exists(gempath):
            return True
        else:
            if os.path.abspath(gempath) == '/Gemfile':
                return False
            else:
                gempath = '../' + gempath
                continue

if __name__ == "__main__":
    if gemfile_exists():
        cmd = ['bundle', 'exec', 'pod'] + sys.argv[1:]
    else:
        scriptdir = os.path.dirname(__file__)
        pathchunks = os.environ["PATH"].split(':')
        if scriptdir in pathchunks:
            os.environ["PATH"] = ':'.join(
                filter(lambda x: x != scriptdir, pathchunks)
            )
        else:
            # We can't find an exact match in $PATH, so fall back to the
            # alternate strategy of chopping one leading component from $PATH
            # and recursing.
            # (To instead chop a trailing component, change '[1:]' to '[:1]')
            os.environ["PATH"] = ':'.join(pathchunks[1:])
        cmd = ['pod'] + sys.argv[1:]

    os.execvp(cmd[0], cmd)

@pepasflo Thanks for sharing your CocoaPods workflow and all of your input on this bug!
One approach we use to manage CocoaPods and Xcode project files is to simplify them by checking them in after running pod deintegrate.  And we're exploring taking advantage of the recently introduced CocoaPods test spec feature to eliminate checking in Xcode project files completely.
I'm hesitant to add workarounds and extra complexity to our implementation to work around a fixed CocoaPods bug, especially for tvOS which is still community supported for us.  I'd prefer to improve the documentation to address it and happy to accept such PRs.

Sounds good, thanks everyone for your prompt and friendly responses on this, especially considering my initial bad attitude.


When the inventory is full, dismantling gun attachments will cause them to disappear

Describe the bug
When the inventory is full, dismantling gun attachments will cause them to disappear
Reproducibility

[X] I reproduced this issue with as few other mods as possible installed.
[ ] I am unable to reproduce this issue consistently.

Screenshots and/or videos
No response
Logs
no logs
Debug Logs
No response
Crash Reports
No response
MWC Version
0.1.3
Forge Version
1.12.2 forge <IP_ADDRESS>60
Red Core Version
0.6 dev 3
MixinBooter Version
9.1
Java Version
1.8
Java Virtual Machine
Hotspot
Operating System
windows 11
GPU Vendor
NVIDIA
Code of Conduct

[X] I agree to follow this project's Code of Conduct

https://github.com/Cubed-Development/Modern-Warfare-Cubed/assets/130232431/c38b04f8-285c-4f79-a94d-c6f0e7288fa6

When the backpack is full, dismantling gun attachments should result in them being discarded on the ground instead of forcibly being stuffed into the backpack, as this would cause the items to disappear.


[WIP] fix: bump trufflehog action to v3.77.0

This PR updates version of Trufflehog action - secrets scanning tool.
<EMAIL_ADDRESS>is an quite old action (last update Dec 9, 2021) basaed on Trufflehog CLI version 2.2.1 (code missing on github for releases older than v3)
New action is officially Trufflehog supported action
Arguments removed:
--max-dept - trufflehog scan with default settings shall fulfill our needs (reference)
--allow - all related files (trufflehog-false-positive.json) in github are empty. If need comes for marking false positives, then inline comment trufflehog:ignore can be used
Tests negative:
https://github.com/splunk/splunk-add-on-for-servicenow/actions/runs/9280369321/job/25540435238
https://github.com/splunk/splunk-add-on-for-amazon-web-services/actions/runs/9268640851/job/25540437971
Test positive:
https://github.com/splunk/test-addonfactory-repo/actions/runs/9281576021/job/25540353760

Can we also adjust the documentation?

@mbruzda-splunk documentation updated.

:tada: This PR is included in version 4.16.6 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Release 1.0.0

It is time.
Well, it's not actually time yet. There's still a few things I need to do (once they're checked off I'll ping all of you again and if none of you have anything you want me to do or you want to do before this merge I'll merge it.

[x] Debug and finish Muke's autonomous code
[x] Implement the hand grabbing servos in both mine and Muke's code
[ ] Debug any possible errors in my human controlled code
[ ] Remove any debug logs from my code
[x] Check any TODOs
[x] Somehow keep track of control mappings
[x] Make the second controller actually vibrate when my code is done calibrating
[ ] Make sure everything's all good
[x] Give you guys time to Voice Your Opinions:tm:

@XaverianTeamRobotics/xaverianrobotsteam

What's the point of all the revert commits? Was that just a way to fix the merge conflicts?

What's the point of all the revert commits? Was that just a way to fix the merge conflicts?

No the reverts were back from when I was working on the javadoc generator and I wanted a quick way to revert back to a specific generator without having to copy and paste it

COLIN WHY ARE YOU CAUSING SECURITY VULNERABILITIES /hj

@24cteahan @MatthewL246 If you have time can you review and approve this PR?
I'm going to try to merge this with master in about an hour, so if either of you want to check this out you'll need to review it now. Michael's here and going to review this in a second, he's currently locked out of his GitHub account.

@24cteahan @MatthewL246 If you have time can you review and approve this PR? I'm going to try to merge this with master in about an hour, so if either of you want to check this out you'll need to review it now. Michael's here and going to review this in a second, he's currently locked out of his GitHub account.

My account is now back

@24cteahan +1

@24cteahan +1 (x2)

@24cteahan +1 (FINAL WARNING)

Merging without review

Awesome!
:octocat: :octocat: :octocat: :octocat: :octocat: :octocat: :octocat: :octocat: :octocat: :octocat: :octocat: :octocat: :octocat: :octocat: :octocat: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit:


TextEdit get_caret_draw_pos inconsistent result

Godot version
master (57bdddce02370af3d13e6edc583afdc17264147d)
System information
Arch Linux, Vulkan, Intel(R) HD Graphics 4000 (IVB GT2)
Issue description
calling get_caret_draw_pos in events caret_changed and/or text_changed have inconsistent results.
1. On empty line we get the centerish point of caret:

2. After Enter key we get the previous position:

i assume the standard is to return the current left/bottom position of the caret:

Steps to reproduce

create a new plugin https://docs.godotengine.org/en/latest/tutorials/plugins/editor/making_plugins.html
copy below code to plugin.gd
activate plugin (restart godot?) and edit a code file

please do correct if i'm doing this wrong:
# position an outlined rectangles left/top to get_caret_draw_pos

@tool
extends EditorPlugin

var rect

func _enter_tree ():
	print("my plugin init")
	var editor = get_editor_interface()
	var script_editor = editor.get_script_editor()
	rect = ReferenceRect.new()
	rect.size = Vector2(8, 8)
	rect.border_color = "#f00"
	script_editor.connect("editor_script_changed",Callable(self,"editor_script_changed"))

func editor_script_changed (script):
	var editor = get_editor_interface()
	var script_editor = editor.get_script_editor()
	var base_editor = script_editor.get_current_editor()
	var code_editor = base_editor.get_base_editor()
	if code_editor is CodeEdit:
		if !rect.get_parent():
			code_editor.add_child(rect)
		if !code_editor.is_connected("caret_changed",Callable(self,"caret_changed")):
			code_editor.connect("caret_changed",Callable(self,"caret_changed").bind(code_editor))
		if !code_editor.is_connected("text_changed",Callable(self,"text_changed")):
			code_editor.connect("text_changed",Callable(self,"text_changed").bind(code_editor))

func text_changed (textedit):
	rect.position = textedit.get_caret_draw_pos()

func caret_changed (textedit):
	rect.position = textedit.get_caret_draw_pos()

Minimal reproduction project
No response

Problem 2 "After Enter key we get the previous position" is already fixed in 880a0177d12463b612268afe95bd3d8dd565bf52 (or somewhere before) and we now get the same left/bottom position where the real caret is. Thank you stranger :)
I wonder if problem 1 "On empty line we get the centerish point of caret" is font/text related. Cause even a single space or tab gives us left/bottom pos.
ps. attached a test godot project test65981.zip


[v1.1.0]: React does not recognize the disableDefaultStyles prop on a DOM element

Hello, thanks for supporting awesome library.
After upgrading I noticed this error:

Hello @ApacheEx
Thank you for the issue. I am going to fix it.

@ApacheEx I published v1.1.1 to fix that bug.
I have tested Chrome and Safari on macOS.
Please re-open this Issue if it doesn't help

works like a charm, thanks for hotfix.


Use Extensions to support direct file reading support like CSV.read(dataset("..."))

It'd be great to overload some common file reader methods like CSV.read, JSON.read, Parquet.read, etc., to support reading directly from a ::DataSet reference.  Having just a handful of these would drastically simplify the use of DataSets

It'd be great to overload some common file reader methods like CSV.read, JSON.read, Parquet.read, etc., to support reading directly from a ::DataSet reference.  Having just a handful of these would drastically simplify the use of DataSets

We can couple this with 1.9 and Weak Dependencies

This is a great idea, but I am a little bit concerned about pushing all these dependencies onto pre-1.9 users right now.


Add more docs to index in a new Codespaces session

- [ ] bug report -> please search issues before submitting
- [ ] feature request
- [x] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Following the successful implementation of 'Deploying from scratch' in Github Codespaces, I ended my browser session. The next day, I wanted to add more PDF documents to the deployed index. I'm unsure about the procedure to execute predocs.sh in a new Codespaces session where all the previous environment information has been lost. How should I proceed?

HI @kail85 ,
Do you see your codespace at this link? https://github.com/codespaces
Thanks,
Matt

Thanks to point out @mattgotteiner !  Another question: is it possible to delete a environment created from azd env new.


[WIP] Single Level Reprojection

This PR intends to add the ability for ndpyramid to create individual pyramid levels.

[ ] Refactor the internals of pyramid_reproject for shared use
[ ] Create function for single level creation
[ ] Fixes #74

Performance improvement ideas:

remove for loop and map over levels
'fast path' option to generate levels from successive levels
generate weights to pass to XESMF
xr.map_blocks over non spatial dims

cc @maxrjones @andersy005 feel free to add/edit this list.

Pushed a temp version of this for testing out pangeo-forge StoreToZarr. Super messy and duplicated functionality. Needs major refactor etc. before thinking of merging.

Thanks @norlandrhagen! I can work on the refactoring, but it seems like the temporary function will be sufficient for testing out StoreToZarr - is that interpretation accurate?

@maxrjones I think so!

@norlandrhagen mind if we close this in favor of #84?


Flat Modifier Item Bonuses are not being applied and not appear in the roll dialog box

As the title says, item bonuses are not being applied when an effect is added. The easiest way to replicate this bug is to use a Quicksilver Mutagen and add the effect to a player. Use Acrobatics or make an attack roll, no item bonus is applied. When the Roll Dialog box appears, no item bonus is shown in the dialog box.
I've done some additional testing as well. If you Import Quicksilver Mutagen, go to the Rules tab and scroll down to the first Flat Modifier, you can change the bonus type to Untyped or another type. Doing so makes the effect work after the change and the effect appears in the roll dialog box.
Another example is Boots of Bounding. It gives a 5-foot item bonus to movement which is not applied unless you adjust the item to use a different bonus type like Untyped.

Try disabling Automatic Bonus Progression.

Thank you for the fix to the issue. I'll just have to wait on using ABP for now. Thanks again.


Fix headers

More like fix critical errors

Haha, how did I not notice that!

Haha it's all good, it's the first thing I look for because I see it happening often actually


Restructuring

Tree

__TESTS__

... [inherit src structure]

public
src

utils

common
tools [predicates, ...]
helpers

types
...

views

asd

asd

app

App.tsx [root react element]
AppEffects.ts [side effects, preloads, inits]
AppRoutes.tsx [top level routes]

assets

lang

*.json [language file]

scss

*.scss [global scss styles]

View <- Container <- ... <- Components


add sendmail (smtp) extension

configure a smtp server and let users send emails

Wow, great! Will review now. Congrats on first extension, sorry its taken a while to be looked at!

closed in favor of https://github.com/lnbits/lnbits-legend/pull/660


Added new feature to auto create SQL table if parameter supplied. By default this parameter is false.

Auto create SQL server table instead creating it manually with a separate SQL query.
A new parameter "autoCreateSqlTable" in the LoggerConfiguration is added and is passed on to MSSqlServerSink() constructor to be used.
Default value of autoCreateSqlTable parameter is false and the parameter is optional.
This uses DataTable returned by CreateDataTable() to create a table in the SQL server database.
This uses Connection String and Tablename parameters to determine the destination and name of the table to create.
All the string type data tables will be converted to NVARCHAR variables in the SQL table.
MaxLength property of the DataColumn determines size of the NVARCHAR, ( -1 ) means MAX.
DataColumn.DataType = System.Xml.XmlElement will create XML type of column int he SQL table.

Nice addition, thanks. We have something similar in the Elasticsearch sink and one issue we found there is that a failure to create the table/mapping etc will fail the sink creation and can fail hard. The normal logging actions are wrapped in try/catch blocks, but if a sink does not start, what should it do? See here: https://github.com/serilog/serilog/issues/556 for the discussion. How would that work in your implementation?

Hi Mivano, I have added error handling to this in order to prevent any problem. I have tested this and to me it was writing to other logs while writing to SQL server fails because of permission issue. However it may break in case the connection string is incorrect.

Thanks for the change. However, if it fails to create the table, what should it do? Continue, with the risk that the events cannot be written, or fail? Normally sink creations can fail as it happens in the startup of the app, but I would not encourage it.
At least add a SelfLog message there. The permissions to actually create the table are most likely different than the account that stores the data. On a dev machine however it is a very easy way to quickly provision a db table. But it is open for discussion what should happen when a sink cannot initialize. In this case I would go with at least a selflog and continue. But as you can see in the discussion of the Elasticsearch sink (https://github.com/serilog/serilog/issues/556) there are multiple options.

Sorry for delay in this little change. I have added SelfLog whenever there is any exception creating an SQL table in the given database.

Thanks! I tested the code and it works perfect. Merged to master and a new package will be ready soon. Thank you for your PR.


Unable to repack application with Castor 0.18.0

After updating the application from Castor 0.17.1 to 0.18.0, it is no longer possible to build the application.
vendor/bin/castor repack

Box version 4.4.0@b7e493d 2023-10-11 20:47:53 UTC

 // Loading the configuration file ".box.json".
 [ERROR] The configuration file is invalid.

In Assert.php line 1012:
  "directories" must contain a list of existing directories. Could not find "
  /projets/pere-castor/.castor".

In Process.php line 270:
The command "'/usr/sbin/box' 'compile' '--config=.box.json'" failed.

The issue is resolved if I create the .castor folder, but is it normal that it is required since version 0.18.0?

Fixed by https://github.com/jolicode/castor/pull/513


2022 Hyundai Ioniq 5 AWD Limited: Add FW to values.py

Route id: 652a446be65eb6fe|2023-03-20--12-18-40
Link to carParams: https://useradmin.comma.ai/logs?url=https%3A%2F%2Fcommadata2.blob.core.windows.net%2Fqlog%2F652a446be65eb6fe%2F2023-03-20--12-18-40%2F0%2Fqlog.bz2%3Fse%3D2023-03-20T22%253A21%253A49Z%26sp%3Dr%26sv%3D2018-03-28%26sr%3Db%26rscd%3Dattachment%253B%2520filename%253D652a446be65eb6fe_2023-03-20--12-18-40--0--qlog.bz2%26sig%3DU26vxHhP1KjNHTx0b03n4MgUVnGQNmkXsOrjI5farXQ%253D&event=carParams
The equivalent PR in OP: https://github.com/commaai/openpilot/pull/27137

This car's FW versions have been added in the latest sunnypilot/openpilot. Thanks!


User specific value for 'ID'

Hello,
When I create an object from buffalo, and I assign specific value for ID (integer ID), it was not affect to DBMS. my environment is buffalo 0.8.2 with MySQL.
Does pop support user assigned value for ID? Because my program have copied tables from other service, the ID is already exist for each record. I also considered using another name of field for copied ID but it will make the program a lot complicated.
Is there any solution?

Hello, I found this line but I could not find how can I set the id as writeable. please let me know.

Currently Pop manages ID creation, you can't set your own ID.


Production Use?

Hello,
First of all thanks a lot for this tool, it is great!
I have read the readme where it is stated:
"adminMongo connection information (including username/password) is stored unencrypted in a config file, it is not recommended to run this application on a production or public facing server without proper security considerations."
I was wondering if there is any plan on adding some sort of encryption; and/or authentication for someone who visits the UI.
Thanks!

What is your intention of use? adminMongo is a development/management tool and should not be installed on a public facing (production reference) server without locking it down using other means. It's safe to install on a local machine and use against a production MongoDB server if you wish.
It's possible to use bcrypt to store passwords but there isn't a big benefit.

Hello,
I understand. I was thinking of something like phpmyAdmin for mongoDB.
Anyways Thanks for the great tool!

I think there should be a login feature to access this tool.


Currently released pypi package doesn't match the described release on github

Thanks for writing this project, it's really simplified deploying airflow for me
The release on github suggests 1.1.2 should include your modifications to allow customising the aws batch submit kwargs, however this code isn't included with the pypi release.
Would it be possible to cut a new release reflecting this, please?

Repackaged release & closing out this issue now. Thank you for your time, sorry for the late reply.

Thanks!


Add VSCODE_PROXY_URI env var to extension host and terminal

Checklist

[x] Update CHANGELOG.md
[x] Get proxy path from the client instead of req.headers.host.
[X] Expose VSCODE_PROXY_URI to plugins
[x] Expose VSCODE_PROXY_URI to terminal

Currently on hold since I will need to rebase this on 1.57.

@code-asher remind me and @jawnsy that we should write a test for the webview fix we did here: https://github.com/cdr/code-server/pull/3895

bump @code-asher - anything I can do to help get these unblocked and ready to merge?

Uh I forgot about this, I'll rebase today.

@code-asher and I spoke offline about this. If we can get this in this week before Wednesday, great! But most likely shooting for the next release.

bump @code-asher -> think we'll be able to get this PR rebased, updated and marked ready this week

Tentatively yes.

Man, we really need to fix https://github.com/cdr/code-server/issues/4027.

(Happy to pick it up as well)

I think it is just conflicts.  I will get it sorted on Monday!

Let me know if you need help moving this forward!

Too many changes and branch out-of-date. We'll see if we can get this ready for the next release.

@code-asher what do you think about this PR? Is it at the end of it's life?

I think we can rebase it once 4.0.0 is stable.

I will re-open this when it is ready to go.


Fix permissions on publish/conda

https://github.com/energy-quants/eq-example/blob/b2a4445700a1410919be26efc2d9c1826aceb577/.github/workflows/publish-conda.yaml#L21

https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs#defining-access-for-the-github_token-scopes

Done!

https://github.com/energy-quants/eq-example/commit/7508743085ca6d253d96952614befa47a7f850ea
https://github.com/energy-quants/.github/commit/06b95fad7acdf75ff89d1fb1386ec245c5975b8e


0.15 BreachDepressions produces unmodfied output

When i run breach depressions I get output that is identical to the input.  I tested on Windows and Linux.  0.14 works correctly.

@spaceof7 There have been some changes to the BreachDepression tool in 0.15. Unfortunately, I did not document these changes in the readme.txt in the rush to publish the latest version. Essentially, I added the option to fill single-cell pits prior to breaching, and I added an option to fill the DEM post-breaching to ensure that there is complete removal of depressions. This brings the tool more inline with the original paper's algorithm, which was originally implemented in Go as part of GoSpatial.
Although I did do extensive testing of the tool before publishing the modified form, it is possible that some bug has been incorporated. Would it be possible for you to provide the details of how you ran BreachDepressions? That is, what environment were you using (Python API, QGIS or ArcGIS plugin, R API, the WB Runner GUI)? What parameters did you use? Is it possible to share your input DEM with me?

I just did another testing of the algorithm and found that it worked as expected in both full-breach and constrained breaching modes.
Original DEM:

Full-breached DEM:
/whitebox_tools --run="Breachdepressions" --wd="/Users/johnlindsay/Documents/data/Rondeau" --dem='/Users/johnlindsay/Documents/data/Rondeau/DEM_clipped.dep' --output='/Users/johnlindsay/Documents/data/Rondeau/tmp2.dep' --flat_increment=0.001 -v

Constrained-breached DEM:
./whitebox_tools --run="Breachdepressions" --wd="/Users/johnlindsay/Documents/data/Rondeau" --dem='/Users/johnlindsay/Documents/data/Rondeau/DEM_clipped.dep' --output='/Users/johnlindsay/Documents/data/Rondeau/tmp1.dep' --max_depth=10 --max_length=70 --flat_increment=0.001 -v

At first I was using the QGIS plugin but when it didnt work I started running WhiteboxTools at the command line.  Initially I was specifying max_depth and max_length but also tested it unconstrained.   Oh, also I was using the tools on .tif files, but also tested on a .dep version.
I noticed that in both examples you specified a flat_increment so i tested using the same parameters you used and it worked as expected.  I tested a few variations of parameters and it seems that if there is no flat_increment parameter specified then the ouput is unmodified.
Also, I wanted to say I really appreciate WhiteboxTools and not having to do file conversion/software switching to get the data in and out of Whitebox GAT.  Thanks!

That was a good spot @spaceof7. I just confirmed your finding; it would seem that by not specifying the flat_increment value, the output looks the same as the input. I'll spend a bit of time now digging into why this odd behaviour occurs.

Okay, I found the error. Because the tool is intended to automatically calculate an appropriate value of the flat increment, based on the input DEM elevation range, in the case that this parameter is not specified by the user, the value was initialized to NaN.
        let mut flat_increment = f64::NAN;

Later in the code, I tested to see if the value of the variable was NaN, in which case the tool was supposed to calculate the value automatically:
       let small_num = if flat_increment != f64::NAN {
            flat_increment
        } else {
            let min_val = input.configs.minimum;
            let elev_digits = ((input.configs.maximum - min_val) as i64).to_string().len();
            let elev_multiplier = 10.0_f64.powi((5 - elev_digits) as i32);
            1.0_f64 / elev_multiplier as f64
       };

The problem was that NaN != NaN in Rust. And so I needed to modify the line to read:
        let small_num = if !flat_increment.is_nan() {

This was a very subtle bug that I was unlikely to ever find had you not reported the issue. As such, I truly thank you for taking the time. The updated code has been submitted to the repository and the fix to the tool will be released with the next version (likely 0.15.1). I'm closing this issue as resolved.


Fix: removed un-used "this" from html bindings

Please rebase

@andrewseguin i have rebased PR with master.

@dharmeshpipariya can you squash this into a single commit? the script we use to merge into google's codebase is unhappy about the merge commits. sorry for the inconvenience...

@mmalerba closing this, will send a new PR


Speeding up vignettes

Vignettes are notable slow to build. Some of the heavier runs could be pre-calculated and stored to speed up.

Before this the phyloseq vignettes should be complemented with TreeSE equivalents. This is not top priority as the README & basic vignette already shows how the functionality can be used.


Fix flaky testInspectServiceEndpoint()

Sometimes DockerClient.inspectService() returns a service with
no Service.Endpoint.Spec.Ports for some reason.
Might be a race condition. Retry inspecting a service
until we get a reply with ports for up to three seconds.

cc @spotify/docker-admins

replace with a unit test instead.


[Feature] Enhance Search Functionality

Description
The current search functionality only filters subcategories, but I would like to enhance it to enable searching for individual resources. Although categories can also be included, it is not necessary at the moment due to the limited number of categories available.
Additionally, I don't believe it will impact the suggestion functionality that is currently assigned in an issue.
Screenshots

while Replit is already present:

Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue (optional)
[X] I am a GSSoC'23 contributor

Great, but how you are going to filter that out?  When search-text is matching more than one resources but not the subcategories?

Great, but how you are going to filter that out? When search-text is matching more than one resources but not the subcategories?

The current search functionality only searches subcategories. However, what I am trying to achieve is that when I type a resource title, it should display the subcategory on the left and the searched resource on the right.
@rupali-codes
Also, please answer question in #732

Great, but how you are going to filter that out? When search-text is matching more than one resources but not the subcategories?

The current search functionality only searches subcategories. However, what I am trying to achieve is that when I type a resource title, it should display the subcategory on the left and the searched resource on the right.
@rupali-codes Also, please answer question in #732

Sure

Great, but how you are going to filter that out? When search-text is matching more than one resources but not the subcategories?

The current search functionality only searches subcategories. However, what I am trying to achieve is that when I type a resource title, it should display the subcategory on the left and the searched resource on the right.
@rupali-codes Also, please answer question in #732

But i'm asking about when search-text doesn't match with any subcategory but it does match with multiple resources, so how you going to approach that?

@Anmol-Baranwal are you still willing to work on this issue? or we should assign it to someone else?

@Anmol-Baranwal are you still willing to work on this issue? or we should assign it to someone else?

Will tell you till 6th June end of day. If I don't make a PR till then, you are free to assign anyone else.

i would like to work on it

@programerr01 sure

@rupali-codes
I said till 6th June, why did you unassigned me?

@rupali-codes I said till 6th June, why did you unassigned me?
It takes time to research and write code while taking everything into account.

I reassigned you @Anmol-Baranwal

@rupali-codes  please check

@programerr01 since @Anmol-Baranwal is owner of the issue and he wants to work on it, we can assign it to you. I was misunderstood him. Could you please look for some other issues :) Appreciate your willingness for contributing in LinksHub!

@rupali-codes
I apologize for any inconvenience caused. After reviewing the codebase, I have determined that implementing this feature would require significant changes. Specifically, I would need to display the render results and create a database containing all subcategories mapped with individual resources from the database, using the name as the search query matching parameter.
Although I made a failed attempt, it would involve modifying numerous code files, and considering the potential changes involved, I don't believe it's worth pursuing. Therefore, I kindly request that you assign this task to someone else.
Regarding the merge, I'm attaching a code snippet that might assist anyone who picks up the task:
export const sidebarData: ISidebar[] = [
  {
    category: 'frontend',
    subcategory: [
      ...frontend.react.map((item) => ({ ...item, id: uuidv4() })),
      ...frontend.images.map((item) => ({ ...item, id: uuidv4() })),
      ...frontend.fonts.map((item) => ({ ...item, id: uuidv4() })),
      ...frontend.colors.map((item) => ({ ...item, id: uuidv4() })),
      ...frontend.illustrations.map((item) => ({ ...item, id: uuidv4() })),
      ...frontend.animations.map((item) => ({ ...item, id: uuidv4() })),
      ...frontend.icons.map((item) => ({ ...item, id: uuidv4() })),
      ...frontend.designInspirations.map((item) => ({ ...item, id: uuidv4() })),
      ...frontend.themesTemplates.map((item) => ({ ...item, id: uuidv4() })),
      ...frontend.uiGenerators.map((item) => ({ ...item, id: uuidv4() })),
      ...frontend.onlineCodeEditors.map((item) => ({ ...item, id: uuidv4() })),
      ...frontend.accessibility.map((item) => ({ ...item, id: uuidv4() })),
    ],
  }
]

There are other approaches, such as creating a custom small function to flatten the object that contains subcategories into a single array. However, I don't want to cloud other judgments.

Thanks @Anmol-Baranwal

@programerr01 Would you still like to work on issue

@Anmol-Baranwal are you still working on the issue?

@Anmol-Baranwal are you still working on the issue?

No, I have already explained that I will not be working on this.

@Anmol-Baranwal are you still working on the issue?

No, I have already explained that I will not be working on this.

Anmol, mentioned this here @rupali-codes.

Hello, can I work on this?

Hello, can I work on this?

Are you in GSSOC @MUK-Dev?

No @CBID2

No @CBID2

That's ok :)

While I work on this.
Can you tell me more about GSSOC23, What is this?

While I work on this. Can you tell me more about GSSOC23, What is this?

You can learn about GSSoC (Girl Script Summer of Code) here

I have finished this feature
Things I added
New search page which displays search results

In the data.ts file: I added resources for each sub-category

In the useSidebarSearch.ts: I changed the filter condition and added routing for the search page

Added a new hook useFilterSearch for searching functionality on the search page.

In the types/index.ts file: I changed the SubCategory type
export type SubCategories = {   name: string   url: string   resources: IDBData[] }
The search works for any query


On Spark 3.x, jars listed in spark.jars and spark.jars.packages are not added to sparkContext

I'm trying to migrate spark 2 to spark 3.
In my environment, on Spark 3.x, jars listed in spark.jars and spark.jars.packages are not added to sparkContext.
After driver's process is launched, jars are not propagated to Executors. So, NoClassDefException is raised in executors.
In spark.properties, the only main application jar is contained in spark.jars. It is different from Spark 2.
How to solve this situation? Is it any changed spark options in spark 3 from spark 2?

I am facing a similar problem on Spark 3.0.0, but I'm not sure it's exactly the same.
I deploy this SparkApplication with Neo4J Connector as package ref.
apiVersion: "sparkoperator.k8s.io/v1beta2"
kind: SparkApplication
spec:
  type: Python
  pythonVersion: "3"
  # ...
  deps:
      packages:
        - "neo4j-contrib:neo4j-connector-apache-spark_2.12:4.0.1_for_spark_3"

The driver Pod fails with java.lang.ClassNotFoundException: Failed to find data source: org.neo4j.spark.DataSource.
...
File "/opt/spark/python/lib/pyspark.zip/pyspark/sql/readwriter.py", line 184, in load
File "/opt/spark/python/lib/py4j-0.10.9-src.zip/py4j/java_gateway.py", line 1305, in __call__
File "/opt/spark/python/lib/pyspark.zip/pyspark/sql/utils.py", line 131, in deco
File "/opt/spark/python/lib/py4j-0.10.9-src.zip/py4j/protocol.py", line 328, in get_return_value
py4j.protocol.Py4JJavaError: An error occurred while calling o59.load.
: java.lang.ClassNotFoundException: Failed to find data source: org.neo4j.spark.DataSource. Please find packages at http://spark.apache.org/third-party-projects.html

The spark-submit launch arguments show no trace of the third-party package referenced in SparkApplication.
exec /usr/bin/tini -s -- /opt/spark/bin/spark-submit --conf spark.driver.bindAddress=<IP_ADDRESS> --deploy-mode client --properties-file /opt/spark/conf/spark.properties --class org.apache.spark.deploy.PythonRunner local:///my-app.py

I also don't see in any log any attempt to resolve and install the package.

Sorry, I think my issue is more related to #1132

@LMolr Thank you for your reply.
I think it is only happened in spark deploy mode "cluster"

I've opened the issue on apache jira also.
https://issues.apache.org/jira/browse/SPARK-35084

I've make pr in apache/spark repo about it.
https://github.com/apache/spark/pull/32397


Why license hasn't been included in js files?

License has to be included so it's better to be included in source source file!
What do you say?

How to include license?


Editing entities

As the managed objects should not cross the data manager boundary my question would be: When I would want to edit one single todo item, I only have the reference to the entity. How would you establish the connection to the corresponding managed object. I imagine holding the object id within the entity could be one solution. How do you manage this at mutualmobile?
//cc @cnstoll @jeffgilbert

Hola,
In that situation I tend to pass the object id through to identify it again later. That seems to be the most practical thing to do if you're using Core Data. As long as you maintain the convention of only using the id in the model layer for the purpose of saving changes to the data model, then I think this is a pretty reasonable thing to do :)
Thanks,

Conrad

Thanks :+1:


Show human-friendly matcher name / identity

For the future when there's multiple matcher's running, the name of the matcher that send a particular hint should be visible somewhere in the GUI, as it may be an interesting quality criterion for people.

@ waffle discussion column tagging: what's the question to be discussed here? :)
(this is design work that's open imo)
if the question is whether or not we should (given time) then that's a definitive yes :)

This has not had any discussion on it for 2 years. Maybe we should close it for now or move it to "later".


Star Projects : Instead of personal make it available for team

Right now star feature is used by person himself.
I would suggest making it available as a team function. This can be used by

Project manager to show what he is focused on
this can also be used by firm owner or service manager or relationship manager to show what's required in priority.

Changing this to Team view will trigger new problems

If group of people can do this, then Role for favorite is problem
this need to be done to all favorite APIs. as this is common module all over easycloudbooks, so change just one module is not possible
Developing time is high as this is used and coded in almost all apis, instead creating New Functionality / Add single Column ie (Priority) will take very less time with better effectiveness / clash
Although this suggested as Replacing existing Functionality, but this requires complete new coding / designing (ie. not just star design also session based coding on both side, server and frontend)
No of people use this as Personal favorite as suggested before, to filter and find what they need to do
Not sure about Other Module meaning for favorite after this implementation ie.( Contact, Company, Staff, Transaction etc)

Please Provide Clear Role, that does not depend on Other Module,
Simple Role Page Mode,
Which can do this

Project Page - Project Manager, Owner, Service Manager, Relationship Manager, special role
Contact Page - Relationship Manager, owner, special role
Company Page - Relationship Manager, owner, special role

These are very complex role that needs detail discussion ,

Star is Object wise functionality
Project Page, Review Page, Finished Page have different Roles,
and Transaction page has Unbilled Project that is completely different thing,
so I guess we need to move module to module with fine tuned Roles, and Project Star is different to Review Star that also needs to implement to clear out confussion

Mujhe konse question ka answer dena hai woh samajh nahi aa raha?


1.0 support in dumpModules

Fixes #96
/!\ UNTESTED, should work as is though unless I've been very, very dumb

That probably won't work (I actually have something similar to this locally). This bug doesn't seem to exist in 1.0.0 (or at least not in this exact shape). I'll make sure by testing right now.

@roblabla Thanks. The issue I referenced earlier quoted this offset as working, so I thougt it would like this. I do not have any means to test on 1.0 though so I'll leave that to you

Just confirming: this doesn't work.

Eh, going to close this then unless you havce any idea of how the bug work. I do not have any mean to study 1.0 kernel unfortunatelly to figure out this(nor tbh the time)

It appears on 1.0 that the bug just isn't present, it returns an error about wrong handle type iirc. Requires another way to crash loader. This isn't a kernel bug, though, it's just a loader bug.

@dark-samus https://screenshots.firefox.com/LyJlUUfQPojM2mi8/switchbrew.org
Also closing

@GovanifY sure, they're bundled with kernel, but they are still standalone :P

@dark-samus Suuuuuure but that would still require(unless you've found a pretty tricky exploit) a 1.0 console + a kexploit, and I am missing the console :/

It doesn't require a kexploit, just the decryption keys and a dump of the 819 module (which browser has access to by default) and the keys are leaked

@dark-samus Oh yeah forgot the keys were leaked, my bad. Going in the legit way would still require one to get those though, correct?

If by legit you mean not downloading leaked keys + 819 archive, yeah.

So I wasn't wrong! °^°.
Anyways stopping this discussion as this bad PR is growing much bigger than it should, thanks for the confirmation.


Error when testing the sample app on MacOS

I'm Getting a nw_resolver_start_query_timer_block_invoke [C1] Query fired: did not receive both families in time for 8c3a638c-89a9-b15b-a9e1-6826acf9ee64.local.:8009 Error in Xcode when trying to connect to a chromecast using the sample app provided. Currently testing on a mac running MacOS 10.15.4 and xcode version 11.4.1 (11E503a). Anyone have a solution for this?

For anyone coming here in the future check this thread on [Stack Overflow].(https://stackoverflow.com/questions/61814769/error-in-xcode-when-trying-to-connect-to-chromecast-google-cast-sdk)

Just wondering what you did to get this to work - receiving the same error message.


Improve the hostname that worker nodes report

A common issue people run into is nodes not being able to communicate with each other. The issue is that nodes report their hostname, but some environments don't have a DNS for the nodes to find each other based on that.
Consider:

Reporting IP address instead
Adding a config to override the reported hostname for each node in the storm.yaml

In our environment we would find this override handy.  A host's role -- its canonical CNAME -- is what matters, not its hostname nor its RDNS.


Not allowed to access local resource. White screen on launch.

simply put, this isn't working on windows 11, presenting this error when dev tools are opened.

This will never be updated. It has never worked on linux and windows support has always been really unstable.


Update demos for new sample data

I've updated the parameter files to use the new sample data and rerun the demo notebooks with this new data.

@gleckler1 @lee1043 Here are the changes for the new demo data


Add color picker

Sorry I made some mistake while I was squashing commits into one, can you repush it?

Pushed it as a single commit (also added a line in README), you can not reopen this PR. Do you think this tool has a place here? Any modifications needed?


In-line Editing: If editable text is white, it comes through the in-line editing form white as well, making the form appear empty

Hello!
I've only been playing around with Mezzanine for a few weeks(loving it so far), but have been working with Django for a while now. I really enjoy Mezzanine's in-line editing, but I found one issue.
Scenario: Let's say you're building a landing page with a full-width image and you want the text overtop of the image to be editable. The image is pretty dark, so you want the text to be white, like in the image below:

When you click the Edit button, the form appears empty, but only because the text is white, as you can see in this image:

I found a very simple one-line CSS fix, so if you all don't mind, I'd love to submit a PR for this.
I've been wanting to contribute to some open source projects and I think Mezzanine is really awesome, so I'd love for this to be my first open source contribution, if it's cool with you all.
Let me know and I'll submit a PR!

Please go for it. Note there's a CSS file specifically for this here:
https://github.com/stephenmcd/mezzanine/blob/master/mezzanine/core/static/mezzanine/css/editable.css


headerText option

Hello! Thanks for your work! I've tried to use headerPath and separate file, but if I require/import something on it I get "require/import" in my header.
So I added the possibility to set the text for the header instead of path. Example of using:
headerText: ["Type definitions for Survey JavaScript library v" + libraryVersion,                     "Project: http://surveyjs.org/",                     "Definitions by: Andrew Telnov <https://github.com/andrewtelnov/>"].join("\n")
where libraryVersion is variable version from my package.json.
Could you check it please?

LGTM!!
I will merge it and will publish a new version on npm.

@tolemac Super! Thank you! It's great feature! Can you merge it ASAP?

Done!
New 0.7.1 version abailable.

@tolemac  Great! Thanks!

@tolemac , I've just upgraded the package to 0.7.1 but unfortunately there is no appropriate code in index.js file, but index.ts file contains it. Could you check it please? May be problem with build?

I have just publish 0.7.2 version. Can you test it?

@tolemac it is ok now. Thank you!


[AutoPR compute/resource-manager] [Compute] add zone and rolling upgrade.

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/3642

(message created by the CI based on PR content)

Codecov Report

Merging #3148 into restapi_auto_compute/resource-manager will decrease coverage by <.01%.
The diff coverage is 48.88%.

@@                            Coverage Diff                            @@
##           restapi_auto_compute/resource-manager    #3148      +/-   ##
=========================================================================
- Coverage                                  56.35%   56.34%   -0.01%
=========================================================================
  Files                                       8124     8124
  Lines                                     166280   166316      +36
=========================================================================
+ Hits                                       93699    93712      +13
- Misses                                     72581    72604      +23

Impacted Files
Coverage Δ

...6_01/models/virtual_machine_scale_set_data_disk.py
38.46% <ø> (ø)
:arrow_up:

.../mgmt/compute/v2018_04_01/models/access_uri_py3.py
71.42% <ø> (ø)
:arrow_up:

...e/mgmt/compute/v2018_06_01/models/gallery_image.py
27.77% <ø> (ø)
:arrow_up:

...zure/mgmt/compute/v2018_04_01/models/access_uri.py
71.42% <ø> (ø)
:arrow_up:

...ompute/v2018_06_01/models/gallery_image_version.py
50% <ø> (ø)
:arrow_up:

...models/gallery_image_version_publishing_profile.py
50% <ø> (ø)
:arrow_up:

...perations/virtual_machine_scale_sets_operations.py
17.61% <ø> (ø)
:arrow_up:

.../models/virtual_machine_scale_set_data_disk_py3.py
38.46% <ø> (ø)
:arrow_up:

...v2018_06_01/models/virtual_machine_scale_set_vm.py
22.72% <0%> (-1.09%)
:arrow_down:

...models/virtual_machine_scale_set_update_os_disk.py
36.36% <0%> (-3.64%)
:arrow_down:

... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8819a52...920c30d. Read the comment docs.

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/2982


ython3Packages.surepy: relax constraints

Motivation for this change
Fix build (https://hydra.nixos.org/build/159266267)
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 147360 run on x86_64-linux 1

2 packages built:

python38Packages.surepy
python39Packages.surepy


finish nacl 10.1.0

there are too many outstanding issues and ideas, we need to agree on what needs to be done now and implemented ASAP (in hours)
close the other issues, its too much work to keep on tracking all of those

[ ] #231
[ ] #230
[ ] #228 YES, after discussion we can close
[ ] #229 dont understand
[ ] #227
[ ] #226
[ ] #209

has been taken care of in development_jumpscale branch


Add string.isLower() & string.firstLower()

There are such functions for uppercase, no idea why there was no lowercase counterparts.

I suppose they don't exist, because you can simply negate the upper variants.
The lower ones could also be implemented that way.

Hmm, that may be true talking about ‘isLower’.
You can’t negate ‘firstLower’ though since it modifies the string :)

Ah true. That one seems good then.


MulticoreTSNE on python 3.7.3 using conda

I am using a python 3.7 version and could not install MulticoreTSNE using conda, or using pip (pip install MulticoreTSNE) since it tries to downgrade a few installed packages, including python itself (to 3.6.8). Below is the error message.
Should we be expecting MulticoreTSNE to be compatable with python 3.7, or would you recommend installing 3.6.8? I would avoid the latter, since it means quite a bit of reloading.
Cheers
Upon trying to install:
The following packages will be DOWNGRADED:
_ipyw_jlab_nb_ext~                           0.1.0-py37_0 --> 0.1.0-py36_0
louvain                              0.6.1-py37h0a44026_2 --> 0.6.1-py36h0a44026_2
mkl-service                          1.1.2-py37hfbe908c_5 --> 1.1.2-py36hfbe908c_5
navigator-updater                            0.2.1-py37_0 --> 0.2.1-py36_0
pot                               0.5.1-py37h1702cab_1000 --> 0.5.1-py36h1702cab_1000
pycairo                          1.18.0-py37ha54c0a8_1000 --> 1.18.0-py36ha54c0a8_1000
pycurl                            <IP_ADDRESS>-py37ha12b0ac_0 --> <IP_ADDRESS>-py36ha12b0ac_0
pyqt                                 5.9.2-py37h655552a_2 --> 5.9.2-py36h655552a_2
pyreadr                              0.1.9-py37h2573ce8_0 --> 0.1.9-py36h2573ce8_0
python                                   3.7.3-h359304d_0 --> 3.6.8-haf84260_0
python-igraph                  0.7.1.post7-py37h01d97ff_0 --> 0.7.1.post7-py36h01d97ff_0
sphinxcontrib                                  1.0-py37_1 --> 1.0-py36_1

I was able to get multicore tsne on python 3.7 if you're running it on windows, you'll need to follow the instructions here  in order to get it working.

Sorry for the radio silence; I have been trying to find out what is happening. In the end I feel this is not a problem with multicoreTSNE itself but other software I need for its installation.
I am a Mac user, and also tried to install MulticoreTSNE on linux based hpc. In both, I get an error message (long) which makes me think that something is wrong with my cmake or similar. I can use it to install other packages that require cmake, and the version seems to be alright
ending with either of the following:
$ pip install multicoreTSNE
or
$ git clone https://github.com/DmitryUlyanov/Multicore-TSNE.git
$ cd Multicore-TSNE/
$ pip install .
ERROR: Command "/anaconda3/bin/python -u -c 'import setuptools, tokenize;file='"'"'/private/var/folders/qq/sgxv2d656r3c49k_bp0l696w0000gn/T/pip-install-tobo8p_u/multicoreTSNE/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(file);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, file, '"'"'exec'"'"'))' install --record /private/var/folders/qq/sgxv2d656r3c49k_bp0l696w0000gn/T/pip-record-uux_cqpb/install-record.txt --single-version-externally-managed --compile" failed with error code 1 in /private/var/folders/qq/sgxv2d656r3c49k_bp0l696w0000gn/T/pip-install-tobo8p_u/multicoreTSNE/
and includes
_cmake version 3.13.3
CMake suite maintained and supported by Kitware (kitware.com/cmake).
-- The CXX compiler identification is Clang 4.0.1
-- Check for working CXX compiler: /anaconda3/bin/x86_64-apple-darwin13.4.0-clang++
-- Check for working CXX compiler: /anaconda3/bin/x86_64-apple-darwin13.4.0-clang++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Could NOT find OpenMP_CXX (missing: OpenMP_CXX_FLAGS OpenMP_CXX_LIB_NAMES) (Required is at least version "2")
-- Could NOT find OpenMP (missing: OpenMP_CXX_FOUND) (Required is at least version "2")
CMake Warning at CMakeLists.txt:22 (MESSAGE):
  Not using OpenMP.  Performance will suffer._

When I use
$ python setup.py install
The result is a bit different, ending with
_clang-4.0: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [CMakeFiles/tsne_multicore.dir/build.make:102: /Users/onurbasak/Documents/2_Hpc_sequencing/software/Multicore-TSNE/build/lib.macosx-10.9-x86_64-3.7/MulticoreTSNE/libtsne_multicore.so] Error 1
make[2]: Leaving directory '/Users/onurbasak/Documents/2_Hpc_sequencing/software/Multicore-TSNE/build/temp.macosx-10.9-x86_64-3.7'
make[1]: *** [CMakeFiles/Makefile2:76: CMakeFiles/tsne_multicore.dir/all] Error 2
make[1]: Leaving directory '/Users/onurbasak/Documents/2_Hpc_sequencing/software/Multicore-TSNE/build/temp.macosx-10.9-x86_64-3.7'
make: *** [Makefile:87: all] Error 2
ERROR: Cannot find make? See above errors._
I am sure I have cmake, clang etc. but there might be a path problem... I will go through this with a specialist
I also tried the conda version, but couldnt make it work. The version of python for this seems to be <3.7.0:
$ conda search multicore-tsne --info
...
_multicore-tsne 0.1_d4ff4aab py36h3e44d54_0
file name   : multicore-tsne-0.1_d4ff4aab-py36h3e44d54_0.tar.bz2
name        : multicore-tsne
version     : 0.1_d4ff4aab
build       : py36h3e44d54_0
build number: 0
size        : 70 KB
license     : BSD-3-Clause
subdir      : linux-64
url         : https://conda.anaconda.org/conda-forge/linux-64/multicore-tsne-0.1_d4ff4aab-py36h3e44d54_0.tar.bz2
md5         : f14137001befebcea0988f12633f1dda
timestamp   : 2018-11-12 17:04:10 UTC
dependencies:

cffi >=1.11.5
libstdcxx-ng >=4.9
numpy >=1.9.3,<2.0a0
python >=3.6,<3.7.0a0_

$ python --version
Python 3.7.3

Ok, the issue is solved.
My conda crushed during an update, which lead me to reinstall miniconda and mange my environments a bit better. I could install MulticoreTSNE for python 3.7.3 following 'git clone...'. The conda version (conda install -c conda-forge multicore-tsne) installed in 3.6.8 my failed in 3.7.3 in my hands.
Overall this was either due to the presence of too many packages in the env, or something that was corrupted (or paths lost) on the way.
Sorry to bother with a none multicoreTSNE related issue


Remove sorting in find_perfect_hash_seed

This improves startup of a small Python file by 1.35% (instruction count from Callgrind) for me.

Okaaaay! Thanks.
This place is under test and subject to change. So I think there is no need to do optimization now...

If one want to do optimize, he can also remove sort because I just want the max value. But I use sort just because it is easy to do prototype and clear (not fast).

Yeah, reading this a bit more, I understood what you were trying to do. I have a local patch to remove the sort completely.

The new commit is an additional 3.6% win.

It looks like this is also happening a lot because the stdlib modules are eagerly constructed. I wonder if it is possible to instead just register callbacks to load them on import.

And maybe pre-compile the text modules as part of the build step?

It looks like you already kind of merged this without mentioning the issue, so not sure how relevant this change is anymore.