Keyword "assistant" Error with ShareGPT Datasets

⚠ Please check that this feature request hasn't been suggested before.

[X] I searched previous Ideas in Discussions didn't find any similar feature requests.
[X] I searched previous Issues didn't find any similar feature requests.

🔖 Feature description
On ShareGPT datasets such as shibing624/sharegpt_gpt4, some "from" values are "assistant" rather than "gpt", so, the program raises the keyword error.
✔ Solution
Maybe take both assistant and gpt as the machine's responses?
❓ Alternatives
No response
📝 Additional Context
No response
Acknowledgements

[X] My issue title is concise, descriptive, and in title casing.
[X] I have searched the existing issues to make sure this feature has not been requested yet.
[X] I have provided enough information for the maintainers to understand and evaluate this request.

I checked that linked dataset. It seems to be human/gpt.
In case you want to swap keys, please check this.
https://github.com/OpenAccess-AI-Collective/axolotl/blob/21cf09b60840ee03ba3ee4e57c2707d2296f532c/src/axolotl/prompt_strategies/sharegpt.py#L78-L90
It swaps roles using a simple dictionary map.

@NanoCode012 I said "some "from" values are "assistant" rather than "gpt"". You checked only some data from that dataset, not all.

Oh I see! You can use this kind of role_map then.
role_map = {"assistant": "gpt", "human": "human", "gpt": "gpt"}

@NanoCode012 Thanks! I'm not sure I'm doing it the way you mentioned. I updated the role_map, but still get the error. Please see the two screenshots.

I fixed this by updating SimpleShareGPTPromptTokenizingStrategy.


Refactoring PSBT with roles according to BIP 174

This is alternative implementation of PSBT roles (known previously as responsibilities, see https://github.com/bitcoin/bips/pull/989 for details) to #456 and #457. This version is more simple and straightforward.
Looking for concept (N)ACKs

After some discussions it was decided not try to implement this type of generic functionality in the library and leave it for specific wallet implementations


Make ~ fail if command is not found

This is a ticket for the Scala Center spree at Scala Wave (Gdansk, Poland).
The goal of this ticket is to fix this "behaviour" that should fail when the task is not found.
steps
Run ~myNonExistingTask.
problem
The ~ command waits for user input even if myNonExistingTask does not exist.
expectation
It should fail straight away without entering in the watch cycle. That means no user input is expected, normal error is reported to the user.
notes
sbt version: 1.0.0 (master branch)

@eed3si9n Can you label this as spree?

I've done this ticket during the Dublin Scala Spree.

See my comments in https://github.com/sbt/sbt/pull/3532#discussion_r140157900 onwards. The parser is intentionally kept relaxed so it can compose with other commands.

Fixed in https://github.com/sbt/sbt/pull/4335/commits/28aa1de32a1108e8b42cf7606c962df6e5dc6f52 looks like?

Yes. #3884 is related but not yet fixed.


bpf: Reduce BPF map memory usage

Reduce BPF map memory usage by using one BPF map for the multiple shards.
When sharding was introduced, multiple BPF maps were added for each of the shards. This is very wasteful as the kernel must preallocate and lock the memory, so it can never be paged out.
The other issue is that machines with low memory count would not have enough memory to create all the maps.
Before this commit we were using 3 shards * 256 (MAX_PID_MAP_SIZE ) * 64B * 2 (size of each row) * 250k MAX_UNWIND_TABLE_SIZE + other metadata that's not too big ~= 24.6GB.
This commit changes the sharded table scheme to just use one BPF map where they key is (pid, shard_id) with the same size, so it will roughly lock 8GB. This number is still rather large. I've reduced MAX_PID_MAP_SIZE to 100, which brings the locked memory now to 3.2GB.
The good news is that by using a single BPF map we can easily fine-tune the shard size to a more reasonable value in the future.
Memory usage should be reduced in the userspace code, too, as before we were naively adding all the shards to their buffer and then writting them. This commits reuses the created buffer and never holds the whole, BPF-friendly unwind table in memory.
Testplan

No errors:
[javierhonduco@fedora parca-agent]$ sudo bpftool prog tracelog      | grep error
^C
[javierhonduco@fedora parca-agent]$

We hit the 2nd shard
[javierhonduco@fedora parca-agent]$ sudo bpftool prog tracelog      | grep -i shard | grep -v 'Shard 1'
      postmaster-736637  [004] d.h2.  5730.961535: bpf_trace_printk:     Shard 2
      postmaster-736637  [004] d.h2.  5730.961540: bpf_trace_printk:     Shard 2
      postmaster-736637  [010] d.h2.  5731.401629: bpf_trace_printk:     Shard 2
      postmaster-736637  [002] d.h2.  5732.581626: bpf_trace_printk:     Shard 2
      postmaster-736637  [002] d.h2.  5732.581631: bpf_trace_printk:     Shard 2
      postmaster-736637  [003] d.h2.  5735.131818: bpf_trace_printk:     Shard 2
      postmaster-736637  [003] d.h2.  5735.131823: bpf_trace_printk:     Shard 2
      postmaster-736637  [001] d.h2.  5736.231871: bpf_trace_printk:     Shard 2
      postmaster-736637  [001] d.h2.  5736.231876: bpf_trace_printk:     Shard 2

Signed-off-by: Francisco Javier Honduvilla Coto<EMAIL_ADDRESS>Fixes https://github.com/parca-dev/parca-agent/issues/1031

Fixes https://github.com/parca-dev/parca-agent/issues/1031

We should have merged this against the release branch 😅 Since it's a fix. We will merge the release branch when we tag something. I will cherry-pick.

Does it really matter? We could also just merge things into main and merge everything back into the release branch. As long as it’s the latest release it doesn’t really matter does it?


Fix the link to releases

In #289 I messed up the link to releases. This points to correct location.

Codecov Report

Merging #291 (16010bf) into master (2f3c49e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #291   +/-   ##
=======================================
  Coverage   37.97%   37.97%
=======================================
  Files          33       33
  Lines        1501     1501
=======================================
  Hits          570      570
  Misses        841      841
  Partials       90       90

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f3c49e...16010bf. Read the comment docs.

Codecov Report

Merging #291 (16010bf) into master (2f3c49e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #291   +/-   ##
=======================================
  Coverage   37.97%   37.97%
=======================================
  Files          33       33
  Lines        1501     1501
=======================================
  Hits          570      570
  Misses        841      841
  Partials       90       90

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f3c49e...16010bf. Read the comment docs.

You caught me not paying attention :)

You caught me not paying attention :)

Can you rebase onto https://github.com/google/ko/pull/290 to avoid the conflict? Matt's annoying bots helpfully formatted the markdown.

Can you rebase onto https://github.com/google/ko/pull/290 to avoid the conflict? Matt's annoying bots helpfully formatted the markdown.

Thanks, PTAL :)

Thanks, PTAL :)


S3 glacier documentation + RFC

Hi,
I'm using rclone to back up stuff into an S3 bucket and was playing around with lifecycle policies in an attempt to reduce storage costs. It is easy to make old files automatically move to lower cost glacier storage (though I've yet to verify if the increased cost per operation makes it worth it in my case).
When syncing to S3 everything works fine, but when syncing/copying back objects would need to be manually restored before rclone can download them. This PR only adds documentation and an error message to that effect.
I could look into adding actual restore support but I'm not sure how it should work. Since it takes minutes to hours after restore for the files to be available, it cannot really be done as part of sync/copy - it is basically a separate operation from the normal commands. Perhaps it could be a flag to check? Something like rclone check --S3-restore-nonmatching... though that does not seem quite right.

I could look into adding actual restore support but I'm not sure how it should work. Since it takes minutes to hours after restore for the files to be available, it cannot really be done as part of sync/copy - it is basically a separate operation from the normal commands. Perhaps it could be a flag to check? Something like rclone check --S3-restore-nonmatching... though that does not seem quite right.

How about something like...  We make a new flag for s3, say --s3-glacier-restore which means if an object in the sync needs restoring then start a restore, but return an error.
You would run your sync with this flag and it would error out, however in the process it would ask for all the objects needed to be restored.
It would be up to the user to run the sync again in the future (maybe rclone could say about how long to wait in a log message if known)  when the objects were restored and the sync would then complete properly.
That would be a bit manual, but it would enable working with glacier.

@ncw I addressed your review.
I'll try implementing restore later this week if I find the time. Based on your comments I agree that a flag to copy/sync which restores would be best. I think it should copy/sync what it can, start restores for the rest and report an error at the end.

Thanks for that - I've merged it now :-)
Look forward to seeing your PR!
-- Nick


Invalid Sender

Hi, I'm getting "invalid sender" error when trying to send signed transactions using ethereum.rb + ruby-eth in a local node. Can't figure out which is the problem. Here's the code, which calls transfer method in a contract.
key = Eth::Key.new priv: "xxxxx"
contract = Ethereum::Contract.create(client: eth_ipc_client, file: route_to_contract, address: contract_address)
contract.key = key
contract.transact.transfer(to, qty)

Of course private key is correct, variables to instantiate contract are correct, params "to" and "qty" are variables with a correct ETH address and a quantity lower than sender's total balance of token. Also, sender has enough ETH to send transaction. I also tried playing with gas_limit and gas_price values with no luck (as expected, because I'm working in a local node).
Every time I run the code, I get the "Invalid Sender" error. Not sure if this is an error in ruby-eth or if it is an error in ethereum.rb, but calling contract methods that don't require to be signed, run without problem.
ethereum.rb version: 2.1.8
ruby-eth version : 0.4.6
Any ideas?. Thanks!

Ok, seems that it has nothing to do with ethereum.rb, nor ruby-eth, but with geth. In the end, the error was not showing only on the situation described above, but in every single ETH signed transaction, so I started to look further and discovered a "problem" in my geth node.
There's a fix here: https://github.com/trufflesuite/truffle/issues/595.
Basicly you have to use the same networkid param as the chainid used to start the node. Must be something related to new geth versions.


V2 migration - Create submission redirect

After a transaction resolves, the app will redirect to the page immediately after the transaction confirms.
If we don't have this, we risk the user executing a transaction twice because they'll just be sitting in the form page

Issues related to this in the past:

User sends tx, page does not redirect, user is at risk of re-submitting
Where is the data needed to enable the re-direct?


Network sync refactoring (part 5)

Another step towards https://github.com/paritytech/substrate/issues/8686
This addresses ugliness in configuration with factory method after #11412 as discussed in https://github.com/paritytech/substrate/pull/11412#discussion_r901736355
Not entirely happy with sync mode matching in multiple places, open for suggestions.

Resolved merge conflicts after #11865.
@bkchr PTAL.
I have much bigger refactoring pending submission and due to the nature of changes long delays make it harder to resolve merge conflicts.

@arkpar you were reviewing previous PR, maybe you can take a look?

I'd suggest removing sc_network::config::SyncMode and simply using sc_network_common::sync::SyncMode everywhere.
Looks good otherwise.

bot merge


OPT20033: Commentary native segmentation opf to pecha db json serializer

Description
A serializer is required to convert commentary data from Pecha OPF format into JSON for pecha.org with  api platform. While the script for the conversion has been implemented, modifications are needed to meet the required standard format and enable successful uploads to pecha.org using the provided API.
Dummy Data
Sample data is available here.
Desired Output
The JSON file, provided by Sandup after thorough testing and approval of all required formats, is now available here.
standard_commentary.json
Expected Output
Serialized JSON files for each commentary, meeting the required format, and successfully uploaded to the staging environment of pecha.org.
Implementation Steps

[ ] Manually prepare JSON files for commentary document files.
[ ] Test the JSON files with the pecha.org API.
[ ] Modify the script to generate the desired JSON.
[ ] Upload the finalized JSON files to staging.pecha.org.

Reviewer

[x] @ta4tsering

To upload the Commentary JSON files via pecha.org-api

run commentaryToJson.py script to generate links..
run pechaAPI.py script to upload text and its commenary links


Additional Port Mappings within Ingress Definition has no effect when using az containerapp update/create

This issue is a: (mark with an x)

[x] bug report
[ ] documentation issue or request
[ ] regression (a behavior that used to work and stopped in a new release)

Issue description
When trying to update the ingress definition with additionalPortMappings using the Azure CLI, the changes have no effect on the container app. No additional tcp port mappings are created.
Steps to reproduce

create a app.yaml Deployment file and added additionalPortMappings as shown here and here

...
properties:
  configuration:
    activeRevisionsMode: Single
    ingress:
      allowInsecure: false
      external: false
      targetPort: 8025
      transport: tcp
      additionalPortMappings:
        - external: false
          targetPort: 8125
          exposedPort: 8125
        - external: false
          targetPort: 8224
          exposedPort: 8224
    maxInactiveRevisions: null
...

updated containerapp/recreated containerapp using az containerapp update --name "name" --resource-group "rg-name" --yaml app.yaml

Expected behavior
Container app should expose additionally added TCP ports
Actual behavior
No additional TCP ports are exposed.
Screenshots

Additional context
This issue occurred using the azure CLI

Can you please ensure you have the latest Azure Container Apps CLI installed? az extension add -n containerapp --upgrade

You're right. Upgrading the Azure Container Apps CLI solved the issue for me. Thank you!


Introduce integration test that generates traffic

I think its time we add a test that generates traffic, makes the sink save some stuff in the database and then queries the API for the resources. My idea is that we create a test namespace, create a KAC that will archive and delete Pods and Jobs, inspect the logs from the sink to check that the filters have been updated, then create a Pod and  a Job and then query the API to check those are returned. Also check that the Job and Pod were deleted from the cluster.

I think we can use the log generators for this.


Two users should be matched by difficulty level of the question they want to work on

When starting a collaboration session, 2 users should be matched by difficulty level of the question they want to work on

Closed via #69


fix: add explicit children prop typing

The new @types/react@^18 package ships with breaking changes. One such change is that children prop is no longer automatically included as part of the React.Component typing. Components need to opt-in to the children prop now.
This PR adds explicit children prop typing to the components the library exposes.

Pinging @trevorr for review.


Mention JPEG-XL in readme

https://jpegxl.info/

Hi, thanks for the PR, this change makes sense only if prebuilt binaries contain support for JPEG-XL. I'm unsure if/when this will be, so I'll close for now.


chore: update temporary entries for cloud.google.com/go/spanner in go.mod to public versions supporting PG feature

Fixes #<issue_number_goes_here>

[x] Tests pass
[x] Appropriate changes to README are included in PR

LGTM, thanks for this fix. Please update the PR description as well though. You can simply copy paste the readme contents.


Added Dismiss Keyboard

Thnaks

Your welcome :*

On 13 Jun 2017, at 9:09 AM, Yakup AD<EMAIL_ADDRESS>wrote:
Thnaks
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/yakupad/Swift-MVVM-DesignPattern/pull/1#issuecomment-308016676, or mute the thread https://github.com/notifications/unsubscribe-auth/AWGyIiZAvOZHB87iO7gt1k_3cl6kxjexks5sDieagaJpZM4N20ND.


Fence off zsync if not available

@flexiondotorg mentioned on the stream a comment from @cowboygeneral that not every distro (Fedora 35) has zsync in the repo, and that we need to take care of that both in the gui and in quickget.
Suggestion: if zsync not found in path then set a guard that prevents zsync-only options from showing, listing or getting
Hopefully masking them out of the output of list then quickgui will just work.

All right, I'll be updating the KDE Neon stuff then - currently, the only way we download these ISOs is via zsync.

Yes, if we add logic to fall back to wget if no zsync and add some text to the README ...

in the function call would be ideal

Very good idea! If I am not mistaken, we could (in the zsync_get function) simply drop the .zsync bit of the URL and pass it on to the web_get function. That would work, wouldn't it?


Client Allocation Request for: Codberg

Client Allocation Questions
Core Information

Name: Codberg

Website / Social Media: https://codberg.co.kr

Region: Asia excl. Greater China

DataCap Requested: 1TiB

Addresses to be Notarized: f01404908

Notary Requested: MasaakiNawatani

Thank you.

Hello @jun950419
Please respond to the questions below in paragraph form, replacing the text saying 'Please answer here'. Include as much detail as you can in your answer!
Please describe the nature of your organization, project, or use case. For organizations, please include your relationship with the organization the size of the organization, and time since inception. For projects and other use cases, please link to relevant web pages or Github. Please include as much relevant detail to provide contextual information (with external links). If you have any presentation document about your business, please provide it to me.
Please answer here.

Have you been approved for a DataCap previously? If so, can you share the details of the last allocation decision (who approved your DataCap, what your plan was for spending it, how you executed on that plan)?
Please answer here.

**Allocation Strategy
Do you intend to store your data in a single geography or many?
Please answer here.

Are you aware of and do you intend to use the features you may specify (e.g. Fast Retrieval) with your storage deals?
Please answer here.

How do you plan on securing the DataCap to ensure your organization (and its delegated members) are the ones allocating the DataCap?
Please answer here.

Do you plan on allocating a substantial portion of your DataCap to a single miner, or will you spread it across many miners?
Please answer here.

For application developers, will you be acting as the client on behalf of your users or you applying as a Notary on behalf of your users? If so, how much DataCap per user are you seeking to have approved?
Please answer here.

Do you agree to use the DataCap to only store data that abides by local regulations and in compliance with the recipient miner’s terms of service?
Please answer here.

**Track Record
Have you previously received DataCap to allocate before? If so, please link to any previous decisions that have been made.
Please answer here.

Are there any disputes open against you from your previous DataCap allocations?
Please answer here.

Hello @MasaakiNawatani
Please respond to the questions below in paragraph form, replacing the text saying 'Please answer here'. Include as much detail as you can in your answer!
Please describe the nature of your organization, project, or use case. For organizations, please include your relationship with the organization the size of the organization, and time since inception. For projects and other use cases, please link to relevant web pages or Github. Please include as much relevant detail to provide contextual information (with external links). If you have any presentation document about your business, please provide it to me.

Codeberg Co. Ltd is a core technology of the Fourth Industrial Revolution, augmented reality,
experience in developing various technologies such as artificial intelligence and blockchain, planning and developing platforms,
It is an IT R&D company with abundant operational experience.

We decided Filecoin project is suitable for protect our data asset.
In order to safely store the important data information of the services we provide, we believe that the FileCoin project is appropriate.
Company Introduction-Codberg.pdf
Visit our Company Web
https://codberg.co.kr/
https://filering.app/
Have you been approved for a DataCap previously? If so, can you share the details of the last allocation decision (who approved your DataCap, what your plan was for spending it, how you executed on that plan)?

No. We have not been approved yet.
Its First apply.

**Allocation Strategy
Do you intend to store your data in a single geography or many?

Single. We built a data center in Bucheon, Gyeonggi-do.

Are you aware of and do you intend to use the features you may specify (e.g. Fast Retrieval) with your storage deals?

Yeah, We deeply aware of Filecoin System, and we have prepared a plan.

How do you plan on securing the DataCap to ensure your organization (and its delegated members) are the ones allocating the DataCap?

We will manage the fine Stringe separately to Protect the data cap.

Do you plan on allocating a substantial portion of your DataCap to a single miner, or will you spread it across many miners?

We will store in single miner.

For application developers, will you be acting as the client on behalf of your users or you applying as a Notary on behalf of your users? If so, how much DataCap per user are you seeking to have approved?

We request as clinet to seek  2TiB datacap.

Do you agree to use the DataCap to only store data that abides by local regulations and in compliance with the recipient miner’s terms of service?

Yes. Sure.

**Track Record
Have you previously received DataCap to allocate before? If so, please link to any previous decisions that have been made.

No.

Are there any disputes open against you from your previous DataCap allocations?

No

Hi @jay2400
I reviewed the information you provided and I'm ready to allocated datacap for you. However, please change your request from 10 TiB to 1 TiB. Thank you.

@MasaakiNawatani

Hi @MasaakiNawatani
I edit my document 10 TiB to 1TiB
Thank you!
sorry. Its my bad.
I use 2 account. One is my private the other is for company
Sorry.

Request Approved
Your Datacap Allocation Request has been approved by the Notary
Message sent to Filecoin Network

bafy2bzacecwr4yglfho7qipyfet64kpnqwap2pgbgqil6qwgj4xpfanc6mjqe

Address

f01404908

Datacap Allocated

NaNB

Signer Address

f1fh53sdaie3yi25qxwcqxpt5h4naex5ibdaffibi

You can check the status of the message here: https://filfox.info/en/message/bafy2bzacecwr4yglfho7qipyfet64kpnqwap2pgbgqil6qwgj4xpfanc6mjqe


diskann.RangeSearch was removed however still being called from test_diskann.cc

diskann.RangeSearch was removed however, it is still being called from test_diskann.cc - what am I missing here?

Its original implementation was removed, but diskann RangeSearch still works


Change node colors and add icons to match the design

Add icons on the left side of the node. The icons must match ones from component browser. The user should always be able to drag the node by holding by the icon.
Change node color to match the function coloring from component browser. The node's outgoing edges must also match its color.
Move node action bar (skip, freeze etc.) to the left.
Remove node names. On connected ports, show the argument name instead. When connection generates a named argument, do not show it twice.
Use dedicated style for placeholder values (_).
Change style of incoming edge connections to the self argumnet.
Separate widgets of each method argument with a pipe.
Render all argument names and non-literal expressions as lowercase and do not show any underscores separating words.
Remove type-based text coloring. Instead, apply different transparency and font weight styles depending on context.

argument names are semitransparent and thin
default values are semitransparent and bold
non-default values are white and bold

This task is started, but it has no estimate. I also believe I would take more than a week, so it should be made an epic and split into smaller task.

@Frizi We should put this task on hold in favor of #6792

Btw, @Frizi what's the progress here? How much is left to be closer to our final design? :)


added about 30 solutions in various languages

haven't shared my solutions in this repo in a while...

also (unrelated): this seems to have died a bit in the last months. 😢
any reason?

Hi @tlseabra. Thanks for submitting these!
The VPS I had set up ended up getting cut off (ran out of a free tier subscription 😅). Just haven't had the extra 30 minutes to set up a new one lately; I've definitely been looking to set aside some time to get this back up and running though!
Plus, I should just be able to run the script once to get the last few months worth of challenges.


Remove top Node version limit from package.json

What does this PR do?
Removing top range scope from package.json to allow package to be installed on Node 21 with strict engine checking.

Hi 👋
Thanks for the PR, but I don't release anything on versions I haven't tested and/or edge versions (since I never release anything for them). You can use --ignore-engines if you are testing.

Thanks for the PR, but I don't release anything on versions I haven't tested and/or edge versions (since I never release anything for them). You can use --ignore-engines if you are testing.

This may be a nice position if you are releasing some sort of standalone library or framework. But this is a plugin for Prettier 3.x and so it logically should be matching Prettier 3.x engine field that doesn't have top limiting. So I'm not sure where "versions I haven't tested" statement is logical and applicable in that case.
comment-parser (major dependency of this plugin) neither have a top scope limit for Node.js engine.
Node 21 is the current Node.js version and Prettier works just fine on it.

Hey 👋,
Yes, this is a plugin for Prettier, but that doesn't mean that if Prettier doesn't have a top engine, this shouldn't either. Odd versions never become LTS, they are not stable, and they have a shorter lifecycle, so I just wait for the next even version to become active and update before it becomes LTS.
Please understand, if comment-parser, which as you mention, doesn't have a limit, were to break on Node 21 for some unknown reason (I don't know the internals of the lib), it would possibly break the plugin, so I would have to debug and see what's the issue, maybe wait for comment-parser to publish an update for Node 21, or maybe it's a runtime issue (as odd versions are unstable)... too much work for a version that would never become LTS.
Now, believe me I understand the pain of dealing with engines (this commit is proof of it), so what I can do right now, if you don't want to use --ignore-engines, is to add this branch, and you can consume it from the repository directly:
"@homer0/prettier-plugin-jsdoc": "homer0/prettier-plugin-jsdoc#odd"

If I can, I'll try to automate it into the pipeline during the weekend, so it gets updated with every release; but I'm not publishing it on npm.
Again, I hope you can understand.
Regards.

If I can, I'll try to automate it into the pipeline during the weekend, so it gets updated with every release; but I'm not publishing it on npm.

No worries. We can't consume from a private repo, so we will do our own fork if this plugin can't follow the same engines requirement as Prettier.
Thank you for the great work!

👍yeah, not going to follow their engines, but you don’t need to consume a
private repo, this one is public and you can install from GitHub using the
syntax from my previous message.
On Tue, Apr 9, 2024 at 7:30 PM Konstantin Vyatkin @.***>
wrote:

If I can, I'll try to automate it into the pipeline during the weekend, so
it gets updated with every release; but I'm not publishing it on npm.
No worries. We can't consume from a private repo, so we will do our own
fork if this plugin can't follow the same engines requirement as Prettier.
Thank you for the great work!
—
Reply to this email directly, view it on GitHub
https://github.com/homer0/prettier-plugin-jsdoc/pull/9#issuecomment-2045744899,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABVATPV2S33XA4IALXU6TNDY4QQR3AVCNFSM6AAAAABF4UWDS6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBVG42DIOBZHE
.
You are receiving this because you modified the open/close state.Message
ID: @.***>


Skrifa charmap doesn't produce the same codepoints as hb_face_collect_unicodes

In testing migration from C++ to Rust codepoint enumeration in google3 I found some fonts where the result doesn't match:
FAIL ofl/gentiumbookbasic/GenBkBasR.ttf
FAIL ofl/gentiumbookbasic/GenBkBasB.ttf
FAIL ofl/gentiumbookbasic/GenBkBasBI.ttf
FAIL ofl/gentiumbookbasic/GenBkBasI.ttf
FAIL ofl/gentiumbasic/GenBasB.ttf
FAIL ofl/gentiumbasic/GenBasR.ttf
FAIL ofl/gentiumbasic/GenBasBI.ttf
FAIL ofl/gentiumbasic/GenBasI.ttf
4788/4796 match

Failure means the set of codepoints from hb_face_collect_unicodes differs from the set obtained via Skrifa's Charmap.mappings

I just see cmap_format_4 in ttx. I suppose HB must be doing something clever.

For example, HarfBuzz reports a bunch more codepoints for GenBasR.ttf, see https://gist.github.com/rsheeter/ab6a9ecb64e5eb746f677d517b5b0028


Fix #669

This manually adds trivial connectivity graphs into the FloodFillDetector by passing a channels attribute into the connected_components() method,  fixing issue #669 where having a null adjacency graph, or leaving a channel out, results in no temporal floodfill being carried out.

travis is broken because of some setuptools bullsh*t -- see what I did at https://github.com/kwikteam/phy/commit/1b0d145965b173564cc2f67a64ed609c753312c7

also could you please add a test case for non regression?

thoughts on a good test for non-regression? in theory if the mgraph is non-null then we're all good so would a simple assert mgraph suffice?
the actual result of the floodfill failing is a bit more involved to test (you need to simulate data with two simultaneous strong threshold crossings and check that the connected components are merged correctly, but maybe this could also serve as a test for join_size)
can I just backport your travis fix?

I think it is worth making a very minimal toy failing test case fixed by this PR, so that we're sure that future versions of the code don't have the same code (notably upcoming phy 1.0). Look at the unit tests of flood fill, there are many toy examples.

finally ready to merge @rossant

Thanks! I shall not forget to forward-port this fix to the other branch.


Improve dispatch queue usage

The way we used dispatch queue was not optimal, leading to creation of
too many threads, which can cause unneeded context switching, and lower
performance.
We use now 2 queues:

vms_queue - concurrent queue use to run accepted connections
threads. For this queue we must use concurrent queue since we want to
process requests from VMs in parallel.

host_queue - serial queue for processing events from vmnet. This queue
is used for the start and stop callback and for the events callback.

With this change we use consistent number of threads: main thread, 1
vmnet thread, 1 thread per connected vm.
Testing show no change in performance.

hardware
os
test
before (Gb/s)
after (Gb/s)

M1 Pro
14.7.1
host-to-vm
3.252
3.219

M1 Pro
14.7.1
host-to-vm-2
1.902
1.880

M1 Pro
14.7.1
vm-to-vm
1.493
1.507

M2 Max
15.1
host-to-vm
2.335
2.359

M2 Max
15.1
host-to-vm-2
1.798
1.802

M2 Max
15.1
vm-to-vm
1.275
1.266

Results are average send throughput of 10 runs. Using performance tests
from #66.
We have a performance regression on macOS 15.1. With 14.7 on same M2 Max
machine it was up ot 1.2 times faster. With 15.1 it is up to 1.4 times
slower.

Thanks, do you have a benchmark result?

Thanks, do you have a benchmark result?

I used both configurations when collecting data for #58 and I don't remember any difference. I can do another run on macOS 15 and M2 Max.

Rebased, I'll do quick test run to validate the lack of performance improvement and update the commit message.

@AkihiroSuda added test results, confirming that there is no improvement, and also showing that we have a performance regression in macOS 15.1 (not related to this change).

@AkihiroSuda added test results, confirming that there is no improvement, and also showing that we have a performance regression in macOS 15.1 (not related to this change).

What is the benefit of this PR?

What is the benefit of this PR?

Avoiding unneeded queues for initialization and shutdown - we use the single serial host queue
Avoiding the unwanted case when additional threads are created for serving vmnet traffic. Testing show that this rare enough so we don't see any effect on performance.
Improve documentation and structure of the program

We can also use the serial queue later to simpilify locking - if we dispatch add/remove connection to the serial queue, no locking is needed. However this does not solve the need for locking when forwarding packets from one vms to other vms, since it is done in one of the vms queues.
I'm using this for few months without any issues.


Add sample data

Hi @edwardoughton
Could you please share/add this file 'data/../results/percentile_50_capacity_lut.csv'

Hi Vaibhav, this should be created by the repo, so I'm just wondering why you want this provided as a file? In my opinion, the simulation model in the India5G repo is a more updated and better version to use to create these lookup tables. Best wishes, Ed

Vaibhav,
Either the file hasn't been created yet because you haven't run the script to generate this lookup table, or the file path is incorrect.
Ed

hello,
also have the same problem here,
after running the "run.py" I do see some CSV files in the folder "result", but I can not find the file "percentile_50_capacity_lut"

+1

I have the same problem. Did you manage to create the "data/../results/percentile_50_capacity_lut.csv" file?


feat(batch): query historical epoch data

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR supports "query historical epoch data", which is enabled by meta backup underneath.

frontend: support specifying query_epoch session variable.
storage: support querying data below current hummock version's safe_epoch, by querying historical hummock version from backup.

About table schema changing or table dropping:

Querying historical data from these tables is doable because meta backup contains hummock version along with table catalog. However schema change feature is not available yet, so shall we also postpone supporting such query?

Example with SET_OPTION below. More detail in test_query_backup.sh.
dev=> select * from tpch_q7;  -- query without setting query_epoch
 supp_nation | cust_nation | l_year |   revenue
-------------+-------------+--------+-------------
 IRAN        | ROMANIA     |   1995 |  84411.4801
 IRAN        | ROMANIA     |   1998 |<PHONE_NUMBER>
 IRAN        | ROMANIA     |   1997 |  59846.7019
 IRAN        | ROMANIA     |   1994 |<PHONE_NUMBER>
 IRAN        | ROMANIA     |   1993 |<PHONE_NUMBER>
 IRAN        | ROMANIA     |   1996 |<PHONE_NUMBER>
(6 rows)

dev=> set query_epoch to<PHONE_NUMBER>686463; -- query with epoch below safe_epoch
SET_OPTION
dev=> select * from tpch_q7;
ERROR:  QueryError: internal error: Failed to build executor: internal error: Storage error: Hummock error: Expired Epoch: watermark<PHONE_NUMBER>686464, epoch<PHONE_NUMBER>686463.

dev=> set query_epoch to<PHONE_NUMBER>416513; -- query with epoch above frontend's max committed epoch
SET_OPTION
dev=> select * from tpch_q7;
ERROR:  QueryError: internal error: cannot query with future epoch:<PHONE_NUMBER>416513, current committed epoch:<PHONE_NUMBER>162944

Checklist

[x] I have written necessary rustdoc comments
[x] I have added necessary unit tests and integration tests
[x] All checks passed in ./risedev check (or alias, ./risedev c)

Documentation
If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.
Types of user-facing changes
Please keep the types that apply to your changes, and remove those that do not apply.

Installation and deployment
Connector (sources & sinks)
SQL commands, functions, and operators
RisingWave cluster configuration changes
Other (please specify in the release note below)

Release note
Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.
Refer to a related PR or issue link (optional)
https://github.com/risingwavelabs/risingwave/issues/6482

The historical query works but performance is ridiculously bad, even for a simple select * that triggers #vnode concurrent tasks. Investigating BackupReader::try_get_hummock_version.

The historical query works, but performance is ridiculously bad, even for a simple select * that triggers #vnode concurrent tasks. Investigating.

It's because validate_epoch can take as long as 0.3 seconds in debug mode when returning error (HummockError::expired_epoch(safe_epoch, epoch)).
And historical query logic was implemented as executed if validate_epoch fails. Fixing.

It's because validate_epoch can take as long as 0.3 seconds in debug mode when returning error (HummockError::expired_epoch(safe_epoch, epoch)).

Caused by https://github.com/risingwavelabs/risingwave/issues/6157?

Some storage implementation detail @wenym1 @hzxa21 @Li0k @Little-Wallace :

This PR patches HummockStorage::build_read_version_tuple. It tries to read a hummock version from backup if query epoch < current version's safe_epoch, before falling back to original logic (validate_epoch raises expired_epoch error). If a query epoch is still not covered by any backup, then expired_epoch still raises.
BackupReader is used by HummockStorage to read hummock version from backup. As meta backup is written by meta node, BackupReader is implemented as subscribing meta backup manifest refresh notification from meta node, and then updating local backup cache asynchronously. So it's possible a meta backup is available but query on it is temporarily failing because of BackupReader's cache is lagging behind. It results query failure which I think is acceptable.
Currently MonitoredStateStore::get and MonitoredStateStore::iter will log it as error, which may no longer be suitable, because invalid query epoch may be provided by user now. I'd like to log expired_epoch as warning while to keep other as error, does it make sense to you?

I've added a new system schema "rw_catalog" https://github.com/risingwavelabs/risingwave/pull/6840/commits/cea5686a4cd750f7051e67ebf3893baf6565e40c.
Would you PTAL @yezizp2012 @HuaHuaY

I've added a new system schema "rw_catalog" cea5686. Would you PTAL @yezizp2012 @HuaHuaY

I think it's necessary to add some details in Documentation section and tag this PR with user-facing-changes.


Fps drop from 200 to 20 when tibialyzer is open

Hey, i dont know whats wrong but this issue started today and i didint change anything. Without tibialyzer my tibia got around 200 fps, when i open tibialyzer its dropped to 20-25. Whats wrong and how can i fix this?

seems like its because of hud bar, because when i turn it off there is no fps drop

Are you using Tibialyzer 1.4.3 or an older version of Tibialyzer?

1.3.0

Try downloading the latest version of Tibialyzer (1.4.3) and see if that resolves your problem.
On Dec 7, 2016, 22:28, at 22:28, bulamen7<EMAIL_ADDRESS>wrote:

1.3.0
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/Mytherin/Tibialyzer/issues/254#issuecomment-265578665

did it and same issue. No idea whats wrong lol.

it might be some issue with my graphic card seems like..

Hey, could you help me find out whats the problem ? I installed every driver , tried to solve this issue and nothing happen. STill got fps drop.


Integrate Python Toolbox

We are developing a python toolbox and want to see how easy it is to use it for our existing projects. this is a kehrwoche task.

[x] install python toolbox in repo and add config files
[ ] fix lint issues
[ ] fix typecheck issues
[ ] start using toolbox commands to run tests
[ ] ci wokflows
[ ] do releases with toolbox
[ ] additional stuff?

1 day work


然而，由于您没有使用英语，我们很难进行处理。如果可能，请您将此问题描述修改为英文。请您直接编辑此问题，不要提交回复或新问题。
请注意，机器翻译服务通常无法处理用于讨论软件问题所需的技术性语言，所以我们推荐您寻找一位熟悉相关技术的人来协助翻译。
如果您无法做到，没有关系。此问题已经被标记为需要翻译，等待社区成员志愿进行翻译。

Thanks for creating this issue!
Unfortunately, as the description is not in English, it's hard for us to work on. If possible, please edit the original issue to be in English.
In our experience, automatic translation services are not able to handle the technical language needed to effectively communicate about software issues, so we recommend finding a human translator who is familiar with our technology to help.
Otherwise, we have marked this as needing translation and a community member may be able to help out.

Translation:
The code can run, but after the update, the edit page is showing lots of red underlines ("like crazy").

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.
Happy Coding!

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Fix: captureTransaction should return emptyId when transaction is discarded

:scroll: Description
Fix: captureTransaction should return emptyId when transaction is discarded
:bulb: Motivation and Context
Fix https://github.com/getsentry/sentry-dart/issues/712
:green_heart: How did you test it?
:pencil: Checklist

[X] I reviewed submitted code
[X] I added tests to verify changes
[ ] I updated the docs if needed
[X] All tests passing
[X] No breaking changes

:crystal_ball: Next steps

Codecov Report

Merging #713 (00ccde1) into main (ea5c733) will increase coverage by 5.44%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #713      +/-   ##
==========================================
+ Coverage   90.70%   96.15%   +5.44%
==========================================
  Files         104        2     -102
  Lines        3335       52    -3283
==========================================
- Hits         3025       50    -2975
+ Misses        310        2     -308

Impacted Files
Coverage Δ

dart/lib/src/sentry_client.dart

flutter/lib/src/sentry_asset_bundle.dart

.../lib/src/navigation/sentry_navigator_observer.dart

dart/lib/src/sentry_user_feedback.dart

flutter/lib/src/sentry_flutter.dart

dio/lib/src/tracing_client_adapter.dart

dart/lib/src/protocol/sentry_browser.dart

dio/lib/src/sentry_dio_client_adapter.dart

flutter/lib/src/sentry_flutter_options.dart

dart/lib/src/http_client/sentry_http_client.dart

... and 92 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea5c733...00ccde1. Read the comment docs.


Can the editor of Wink be used as a seperate package?

I know that the editor uses Quill under the hood.
But the modifications are looking very very good, and i was wondering if and how this can be used as a stand-alone package for laravel for projects with less needs that wink is offering solutions to them.
Thanks.

I think this is possible, but no plans for it at the moment, maybe when the editor is more mature, still have plans for it :)

Thanks man!


Fix deprecated libp2p peerstore

Description
Refactored the code to replace following packages

github.com/golang/protobuf  --->  google.golang.org/protobuf/proto
github.com/multiformats/go-multiaddr-net ---> github.com/multiformats/go-multiaddr/net
github.com/libp2p/go-libp2p-peerstore  ---> github.com/libp2p/go-libp2p-core/peerstore

Changes include

[x] Bugfix (non-breaking change that solves an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes
No breaking changes
Checklist

[x] I have assigned this PR to myself
[x] I have added at least 1 reviewer
[x] I have tested this code
[ ] I have updated the README and other relevant documents (guides...)
[ ] I have added sufficient documentation both in code, as well as in the READMEs

@munna0908 Congratulations on your first pull request! 🍰  Please resolve the merge conflicts with the develop branch so that we can run the test suites to ensure that everything is operating normally.
Thanks!

@lazartravica i have re

@munna0908 Congratulations on your first pull request! 🍰 Please resolve the merge conflicts with the develop branch so that we can run the test suites to ensure that everything is operating normally.
Thanks!

@lazartravica merge conflicts resolved


Changes to integrate the cattle auth framework with the external go service for github and saml provider

The github provider code has been decoupled and now served via rancher-auth-service.
APIs /token and /identities should work as is against cattle
/v1/githubconfig is deprecated now.
/v1-auth/config is the new API to set the auth provider's configuration

@ibuildthecloud can you please review the pr for auth integration. Changes added are for supporting both external github and saml providers.
The changes include:

Removing all code related to github and githubconfig
Addition of new ExternalServiceAuthProvider and util classes
Changes to hookup the ExternalServiceAuthProvider in the existing auth framework - IdentityManager, TokenResourceManager, ApiAuthenticator etc
Needed few changes in GenericWhiteListedProxy class to add the access_token header, changes needed to relay the POST data for 'application/x-www-form-urlencoded' content type
The setting table column 'value' needs to be changes to mediumtext to be able to hold big stuff like SAML certificates/metadata etc
web.xml changes for AuthService and PreProxy filter

Tests passed for v2.
For v1, I see errors "Failed to Scheduling for instance" - not related to the PR, see this error a lot in general.
Can the v1 tests be re-run?

@ibuildthecloud @deniseschannon this is the update cattle PR for auth integration.
Newly addressed changes:

Removed db changes for changing 'setting' table
Remove comment
The  POST form fixes are now enabled only for /v1-auth/
This also has new fix for saml - GET /token returns  Token with the userIdentity and userType corresponding to the jwt token present in the request cookie.


Exclude NuPkg's from robots.txt

http://searchengineland.com/a-deeper-look-at-robotstxt-17573 + add rel="nofollow"

Google recommends and abides by this:  https://support.google.com/webmasters/answer/96569?hl=en


Uncaught RangeError: Maximum call stack size exceeded

I'm generating a quite complex flowchart, and I get the above error. It seems be be caused by the showPosition function. The flowchart generates OK, but the error means that the text used to generate the flowchart is not hidden. Is there any way to skip this function call? (without editing the underlying code)

Sorry for late response. How large is this diagram? Have not been able to reproduce the issue?

Close it since no more feedback.


CTECH-1592: Adds whitespace to check forked PR flow.

Signed-off-by: Paul Saunders<EMAIL_ADDRESS>Pull Request Checklist

[x] Read the contributing guidelines
[x] Tests pass

Description of the PR
Test MR to check that the forked PR process works. Close unmerged is expected when everything works.

/LGTM

Closing. Looks good to go.


🐞 Text gets misaligned as it is typed

Description
Thank you so much for all of your hard works! This project is amazing...
Here are few things I found from the latest alpha release in basic text editing.

Vertical text alignment is off somehow

At the beginning of text edit, no colorization of text (in my case, .swift file) until 10th line did happen

When the file you're editing is short and blank spaces are there at the bottom of the file, you cannot click there to move the edit cursor to the most bottom line

I hope this report helps future improvement...
Environment: MBP 14-inch, 2021, M1P, Ventura 13.2.1
To Reproduce
make a new text file, open it in CodeEdit, start edit it then you would see all three.
Expected behavior

It should be aligned vertically.
Live interpreter(?) should detect the file format and highlight keywords in the editor
Should be able to click the empty part of the file on editor to make the text editor cursor jump to the bottom line

Version information
CodeEdit: [Version 0.0.2-alpha (27)]
macOS: [13.2.1]
Xcode: [14.2]
Related issues

#152
#20

@ryohajika can you confirm this is still happening on the latest release?

@lukepistrol @luah5 now this error is gone I guess! Thanks so much for your effort:)
(now there's another error with the CodeTextEditApp 0.0.3-alpha.32 release that you get your text glitched and destroyed when you edit some text and do undoing. I may setup another error report on the repo for the app.)

Glad to know that this is fixed @ryohajika!


Adding the "Display My IP" app

A really simple app that will fetch the public IP of the network the Tidbyt is connected to and display it. Partially I did this to learn Starlark, and partially because my IP changes so often I find myself using a bash alias to print it, and thought this would be a decent use of the Tidbyt.

I have read the CLA Document and I hereby sign the CLA


Artist form: Field Amount Local not read-only

Artist form: Field Amount Local not read-only
You can enter something which is confusing

Fixed in SVN Rev 100


Could not create ResponseStatusDetails.

System Info
ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: CheckedFromJsonException
Could not create ResponseStatusDetails.
There is a problem with "type".
Invalid union type "cancelled"!
#0      _$ResponseStatusDetailsFromJson (package:openai_realtime_dart/src/schema/generated/schema/schema.freezed.dart:11526:7)
#1      new ResponseStatusDetails.fromJson (package:openai_realtime_dart/src/schema/generated/schema/response_status_details.dart:52:7)
#2      _$$ResponseImplFromJson (package:openai_realtime_dart/src/schema/generated/schema/schema.g.dart:139:35)
#3      new _$ResponseImpl.fromJson (package:openai_realtime_dart/src/schema/generated/schema/schema.freezed.dart:1370:7)
#4      _$ResponseFromJson (package:openai_realtime_dart/src/schema/generated/schema/schema.freezed.dart:1150:20)
#5      new Response.fromJson (package:openai_realtime_dart/src/schema/generated/schema/response.dart:41:7)
#6      _$$RealtimeEventResponseDoneImplFromJson (package:openai_realtime_dart/src/schema/generated/schema/schema.g.dart:1803:26)
#7      new _$RealtimeEventResponseDoneImpl.fromJson (package:openai_realtime_dart/src/schema/generated/schema/schema.freezed.dart:45795:7)
Related Components

[ ] doc-loaders
[ ] doc-transformers
[ ] prompts
[ ] llms
[ ] chat-models
[ ] output-parsers
[ ] chains
[ ] memory
[ ] stores
[ ] embeddings
[ ] retrievers
[ ] agents

Reproduction
after RealtimeEventType.conversationInterrupted
Expected behavior
No errors

Hey @andreiavornic ,
Are you using the latest version (v0.0.3)?
As far as I can see the current code handles cancelled already:
https://github.com/davidmigloz/langchain_dart/blob/d2723976c3f0c36c95115b4b756492e223ffe812/packages/openai_realtime_dart/lib/src/schema/generated/schema/response_status_details.dart#L22-L36

I'll close this issue for now, please feel free to reopen it if you can still reproduce it with the latest version.


Device with serial number '$validserial' is not a door.

Hello,
I'd like to interface with a MYQ-G0301. Call attempts result in ERR_MYQ_INVALID_DEVICE. The serial is correct -- in that it is identical to what's displayed in the myq smart phone application. Have I encountered a bug or am I trying to use the API for an unsupported device?
Happy to provide serial if needed.
MyQError: Device with serial number '$validserial' is not a door.
    at MyQ.getDoorState (/Users/$user/Git/myq-alexa/node_modules/myq-api/src/MyQ.js:245:15)
    at processTicksAndRejections (<node_internals>/internal/process/task_queues.js:93:5)
    at async doorStatus (/Users/$user/Git/myq-alexa/index.js:17:22)
    at async Object.handle (/Users/$user/Git/myq-alexa/index.js:106:40) {name: 'MyQError', code: 'ERR_MYQ_INVALID_DEVICE', stack: 'MyQError: Device with serial number 'GW230000…Users/$user/Git/myq-alexa/index.js:106:40)', message: 'Device with serial number '$validserial'' is not a door.'}
index.js:20

code:'ERR_MYQ_INVALID_DEVICE'
message:'Device with serial number '$validserial' is not a door.'
name:'MyQError'
stack:'MyQError: Device with serial number '$validserial' is not a door.\n    at MyQ.getDoorState (/Users/$user/Git/myq-alexa/node_modules/myq-api/src/MyQ.js:245:15)\n    at processTicksAndRejections (internal/process/task_queues.js:93:5)\n    at async doorStatus (/Users/$user/Git/myq-alexa/index.js:17:22)\n    at async Object.handle (/Users/$user/Git/myq-alexa/index.js:106:40)'
__proto__:Error
constructor:class MyQError extends Error {\n  /**\n   * Construct an error to be returned by the myQ API.\n   *\n   * @param {string} message Error message\n   * @param {string} code Error code\n   * @param {object} _serviceError Optional raw service error\n   */\n  constructor(message, code, _serviceError) {\n    super(message);\n    this.name = this.constructor.name;\n    this.code = code;\n    if (_serviceError !== undefined) {\n      this._serviceError = _serviceError;\n    }\n  }\n}

Hi there @TheseArmsRSnakes,
The MYQ-G0301 is the model number for the myQ Smart Garage Hub. You want to be calling this API with the serial number of your garage door, not the hub. myQ treats these as separate devices.
I suggest you call getDevices() via this API to get all the devices on your account. Find the device that has the device_family field set to "garagedoor" - that is the device you're looking for. Try seeing if the associated serial number for that device does the trick.

Thank you @thomasmunduchira. Works!


Auto corrected by following Lint Ruby Style/CaseLikeIf

Auto corrected by following Lint Ruby Style/CaseLikeIf
Click here to configure it on awesomecode.io

Coverage remained the same at 96.207% when pulling f2c5dbb6d4be59b55098ebfd59e4baf4fc4cec84 on awesomecode-lint-ruby-style-caselikeif-47798 into 0c95f632cc3c589422c9230095cc74ae01015b54 on master.

Coverage remained the same at 96.207% when pulling f2c5dbb6d4be59b55098ebfd59e4baf4fc4cec84 on awesomecode-lint-ruby-style-caselikeif-47798 into 0c95f632cc3c589422c9230095cc74ae01015b54 on master.


Make action name consistent

Every other action is called *Action so perhaps this one should match.

Thanks for the PR!  It needs the example in examples/client.go updating before I can merge it; feel free to update the PR with that, or I'll do it next time I have the code open myself.

Merged, thanks for the PR!


New Crowdin updates

What does it need to merge all these translations?

Closing in favor of more recent https://github.com/berty/berty/pull/4675 .

Aren't website translations different from application translations?


Single Hatch entity DWG loads in True View but not in ACadSharp

Hi Dom,
When I read this DWG the BoundaryPath Edges and Entites are empty. I can't find any vector information in the hatch entity. It loads in True View and another cad package. Could you take a quick look and tell me if the data is there or not?
Thank you
Hatch.zip

Hi @mattbrownfaro,
I've looked at the file, it seems that there are some errors in the Hatch reading for dwg, I'll open a branch to solve this issue.
Thanks

Thank you Albert
From: Albert Domenech @.>
Sent: Friday, August 5, 2022 1:29 AM
To: DomCR/ACadSharp @.>
Cc: Matt Brown @.>; Mention @.>
Subject: Re: [DomCR/ACadSharp] Single Hatch entity DWG loads in True View but not in ACadSharp (Issue #49)
CAUTION: This email originated from outside the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
If you have clicked a link in this message with unexpected results, call IT immediately
Hi @mattbrownfarohttps://github.com/mattbrownfaro,
I've looked at the file, it seems that there are some errors in the Hatch reading for dwg, I'll open a branch to solve this issue.
Thanks
—
Reply to this email directly, view it on GitHubhttps://github.com/DomCR/ACadSharp/issues/49#issuecomment-1206186924, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACJHMISDPA5MN5HZBYXCLQDVXTGETANCNFSM55T7NKPQ.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>


Respect the workspace if it exists

When ziggy builds his targets, the used folder is $PWD/target. When in a workspace, the target directory will be at the root of the workspace. This makes that we cannot use things like cargo clean -p to clean a single crate instead of recompiling everything.
The idea is either to implement cargo ziggy clean or use the same target directory as the workspace

Started working on this in https://github.com/srlabs/ziggy/tree/respect-workspace.
There are multiple problems when doing this:

By default, AFL++ and our runner both build a binary file in ${target}/debug/${name}.
This means that they will overwrite themselves. I have not yet found a workaround.
On the positive side: both react in the correct way to cargo clean -p package_name, so once this is solved, we're good to go.

honggfuzz-rs does build-directory shenanigans of it's own, and cargo clean -p package_name does not work.
TBD whether we can fix this.

Couldn't we follow the same idea as cargo targets with multiples "bin" targets. Runner, afl, honggfuzz? Kind of same as now, but in the workspace target directory? The only incompatible thing would be that those targets are not included in the Cargo.toml. Or does that break cargo clean -p as its not canonical?


Fix @FilesParam example

Example of usage of @FilesParam wasn't correct

Coverage remained the same at 82.428% when pulling 6a7e2fee271613a1e3d33910bc68db61bda84ecc on iojichervo:fix-filesparam-example into 7b0bc8f7d38a37514bb309643d443c099820d5bd on thiagobustamante:master.


How do I launch a bot?

What command should I run to run?

Bot is currently under development. Main functionality is not ready yet.


Floats can lose precision when loading to BigQuery

The float precision is set here: https://github.com/pydata/pandas-gbq/blob/d251db03b159447331ac9ae63e13d295d75bad70/pandas_gbq/load.py#L22
This is insufficient to represent all 64 bit floats without losing precision. For example 26/59 should be represented as 0.4406779661016949 but under this it is represented as 0.440677966101695.
This was added intentionally here to fix a different issue but it causes us some issues as we need perfect reconciliation between systems. It seems like it should be possible to get the best of both worlds and output the correct number of digits in all cases.
The original suggestion was to use %g but this was changed to %.15g – it's not clear to me what the rationale is for that, it seems like %g is strictly better but I'm sure I'm missing something.

@max-sixty I was wondering if you might be able to provide some help / guidance here?

@danielchatfield
Not sure if this is helpful, but I think one of the issues as explained here is that a conservative choices is made in the number of significant digits.
A possible solution if you do need to have larger precision is to use .parquet format instead, as suggesed here?

Thanks @dkapitan

Would %.16g avoid the precision issues?

The original suggestion was to use %g but this was changed to %.15g – it's not clear to me what the rationale is for that, it seems like %g is strictly better but I'm sure I'm missing something.

According to https://docs.python.org/3.6/library/string.html#formatspec

A precision of 0 is treated as equivalent to a precision of 1. The default precision is 6.

I think that would result in too much rounding on some systems.

According to https://en.wikipedia.org/wiki/IEEE_754#Character_representation 17 digits are precision are required to preserve the original binary value. 16 digits was not enough in my testing of https://github.com/pydata/pandas-gbq/pull/336


CEX.IO Backfill issue.

Seems to be a bug when trying to backfill Zenbot for CEX.IO USD.
./zenbot.sh backfill cexio.BTC-USD --days 14
This should return only 14 days worth, however, it starts downloading from 2014. I think this might be the case when backfilling other pairs from CEX.IO too.

I confirm

I confirm that it backfills tradeid's not time. So I don't find simple approach to extract days. Need help.

Are you still experiencing this problem?  If not, consider closing this.

same issue here


Revert "Fix Env (#18)"

This reverts commit 8569ab547f1b0128d3259ee0d88a66a56358947e.

Description:

Linked issues:

Screenshots:

How to test:


Low model fit while ran genomescope2

Hello,
I ran the genomescope 2.0 based on a HIFI data with k=31.
And the histo file was obtained by the instruction.
Other diploid genomes can get good results by defalut parameters.
But this is look so weird beacuse of the low model fit.
I have tried the different "Average k-mer coverage for polyploid genome" number with default, 51, 57 which I could see in the issues.
The result looks like this
http://qb.cshl.edu/genomescope/genomescope2.0/analysis.php?code=H2gZHt6f9jrRA8myt1Zp
I dont know the depth because I dont exactly know the genome size.
But I got ~60G HIFI data which means I may get sufficient data (probably I think).
Can you give me some advices about how to deal with the low model fit?

Hi Lan,
Using the command line version, I get a pretty good fit using this command:
$ ./genomescope.R --start_shift 2 --typical_error 2 -l 5 -i
~/Desktop/data.txt -o ~/Desktop/out -k 21 -p 2
This converges with these values:
Model converged het:0.00193 kcov:6.26 err:0.0024 model fit:0.0839
len:4808938880
This uses some special options to deal with very low coverage sequencing.
But in general I would recommend at least tripling your amount of coverage
so that the main peak is over 30x
Good luck!
Mike
On Tue, Apr 12, 2022 at 4:50 AM Lan @.***> wrote:

Reopened #74 https://github.com/schatzlab/genomescope/issues/74.
—
Reply to this email directly, view it on GitHub
https://github.com/schatzlab/genomescope/issues/74#event-6416846464, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AABP342AMMYG2OBVNAP4PRTVEU2NJANCNFSM5TFGA7GA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Thanks for your help！！
This estimated genome size was similar to the hifiasm`s outputs.


BRAINSFitTest_ROIBSpline Needs updated reference dataset

@aghayoor   Please update the reference data set for BRAINSFitTest_ROIBSpline.  A recent improvement in ROI generation has caused improved results, so now we need updated baselines.
Please complete this ASAP.
Thank you.
hans

Fixed!
https://github.com/BRAINSia/BRAINSTools/commit/d3bc2210a6f8f66d637b256a83e74193519c6e9c


[Bug] Env returns readonly in typescript

Describe the bug
I am trying to configure my Next.js (<13 and using pages API) to utilize a local model.
#310 and documents refer to using
env.allowRemoteModels = false

which returns an warning as the following.
Cannot assign to 'allowRemoteModels' because it is a read-only property.ts(2540)

I also see that with the current documentation of adding PiplineSingleton to global, global seems to have an error of
Element implicitly has an 'any' type because type 'typeof globalThis' has no index signature.ts(7017),
is there a way to get around this like the prisma client?
let PipelineSingleton: any
if (process.env.NODE_ENV !== 'production') {
  // When running in development mode, attach the pipeline to the
  // global object so that it's preserved between hot reloads.
  // For more information, see https://vercel.com/guides/nextjs-prisma-postgres
  if (!global.PipelineSingleton) {
    global.PipelineSingleton = P()
  }
  PipelineSingleton = global.PipelineSingleton
} else {
  PipelineSingleton = P()
}
export default PipelineSingleton

Is there some kind of typing to get around these problems?
How to reproduce
Steps or a minimal working example to reproduce the behavior
create a next app with this as a server utility, and calling it in API routes.
// let PipelineSingleton: any

import {
  PreTrainedTokenizer,
  Processor,
  PreTrainedModel,
  AutoTokenizer,
  AutoProcessor,
  AutoModel,
  env,
} from '@xenova/transformers'

env.allowRemoteModels = false

const P = () =>
  class PipelineSingleton {
    private static task: string = 'zero-shot-image-classification'
    private static modelID: string = 'Xenova/clip-vit-base-patch16'

    private static tokenizer: PreTrainedTokenizer | null = null
    private static processor: Processor | null = null
    private static model: PreTrainedModel | null = null

    public static async getInstance(progress_callback: (x: number) => void): Promise<{
      tokenizer: PreTrainedTokenizer
      processor: Processor
      model: PreTrainedModel
    }> {
      if (this.tokenizer === null && this.processor === null && this.model === null) {
        this.tokenizer = await AutoTokenizer.from_pretrained(this.modelID)

        this.processor = await AutoProcessor.from_pretrained(this.modelID)
        this.model = await AutoModel.from_pretrained(this.modelID)
      }

      return {
        tokenizer: this.tokenizer!,
        processor: this.processor!,
        model: this.model!,
      }
    }
  }

let PipelineSingleton: any
if (process.env.NODE_ENV !== 'production') {
  // When running in development mode, attach the pipeline to the
  // global object so that it's preserved between hot reloads.
  // For more information, see https://vercel.com/guides/nextjs-prisma-postgres
  if (!global.PipelineSingleton) {
    global.PipelineSingleton = P()
  }
  PipelineSingleton = global.PipelineSingleton
} else {
  PipelineSingleton = P()
}
export default PipelineSingleton

Expected behavior
A clear and concise description of what you expected to happen.
Typing error goes away
Environment

Transformers.js version: 2.6.2
Operating system (if applicable): Mac

@kungfooman, have any ideas? 😇


Change tests to pytest

Convert unittests to pytest and simplify test code using fixtures

@chrisjsewell I've reimplemented the tests in pytest with regression. How does this look?

Also, worth noting that I had the same issue noted on myst-parser - autouse doesn't seem to work for pytest fixtures in contest.py. Tried using usefixture in a pytest too, with no luck.

In which case, I guess it could be used to run the build and regression checks for each test without calling them in the test function

In the long run, we may not want to run this fixture for every test. But we'll cross that bridge when we come to it


Added class_name reference

this enables the user to manipulate 3dtext class when needed

Works for me. Thank you for contributing! :)


[Snyk] Security upgrade alpine from 3.9 to 3.19

This PR was automatically created by Snyk using the credentials of a real user.![snyk-top-banner](https://github.com/andygongea/OWASP-Benchmark/assets/818805/c518c423-16fe-447e-b67f-ad5a49b5d123)
Snyk has created this PR to fix 3 vulnerabilities in the dockerfile dependencies of this project.
Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.
Snyk changed the following file(s):

build/ks-apiserver/Dockerfile

We recommend upgrading to alpine:3.19, as this image has only 0 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.
Vulnerabilities that will be fixed with an upgrade:

Issue
Score

Improper Certificate Validation SNYK-ALPINE39-OPENSSL-1089232
  184

Improper Certificate Validation SNYK-ALPINE39-OPENSSL-1089232
  184

Integer Overflow or Wraparound SNYK-ALPINE39-OPENSSL-1089235
  148

Integer Overflow or Wraparound SNYK-ALPINE39-OPENSSL-1089235
  148

NULL Pointer Dereference SNYK-ALPINE39-OPENSSL-1089231
  128

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
Max score is 1000. Note that the real score may have changed since the PR was raised.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 NULL Pointer Dereference

🎉 Snyk hasn't found any issues so far.
✅ code/snyk check is completed. No issues were found. (View Details)


Error importing messages different than std_msg

Hi, inside std_msgs there is another folder called detail, that contains the header_struct msg among several others.
For my project I'm using nav_msgs, so I've added rules to build nav_msgs and geometry_msgs (as it depended on them) but now I'm facing this error:

In file included from bazel-out/k8-fastbuild/bin/external/ros2_common_interfaces/cpp_geometry_msgs_cpp/geometry_msgs/msg/accel_with_covariance_stamped__type_support.cpp:7:
bazel-out/k8-fastbuild/bin/external/ros2_common_interfaces/cpp_geometry_msgs_cpp/geometry_msgs/msg/detail/accel_with_covariance_stamped__struct.hpp:19:10: fatal error: std_msgs/msg/detail/header__struct.hpp: No such file or directory
   19 | #include "std_msgs/msg/detail/header__struct.hpp"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

I think maybe this block inside common_interfaces.BUILD.bazel isn't accounting for subfolders inside std_msgs?
ros2_interface_library(
    name = "std_msgs",
    srcs = glob(["std_msgs/msg/*.msg"]),
    deps = ["@ros2_rcl_interfaces//:builtin_interfaces"],
    visibility = ["//visibility:public"],
)

thanks in advance!

Hi Pablo,
Unlike ROS1 genmsg that requires deps to be correctly set up, ROS2 doesn't require this (or I didn't set it up correctly yet). Therefore, if deps aren't correct, you'll only see that in C/C++ compilation stage.
I added handling of geometry_msgs and nav_msgs in 3510f62378e520c07c5c4d8d04ba20268d43edec.


Particle system functionality

I'm having some issues with particle systems. They either seem to not render at all, or render through all geometry.
Here's a video:

Do yo have a guide on how to use particle systems? Or is this a bug?
I'd appreciate your help. 👋

What shader does the particle material use? You should check that the particle material use VXGI/Particles/Standard Unlit shader. Then, make sure that the Albedo texture contains correct alpha value for transparency. You can also post an image so I can look for myself.

So, I have recently added this standard particle shader with minimal support. For now, you can use Additive rendering mode for these particles. I will look into supporting other rendering mode as well in the future.

Thanks for the reply @Looooong !

What shader does the particle material use? You should check that the particle material use VXGI/Particles/Standard Unlit shader.

I've been using VXGI/Particles/Standard Unlit, you should be able to see it in the video.

Then, make sure that the Albedo texture contains correct alpha value for transparency.

I've been using the built-in Default-Particle, but I also tried opaque textures which don't need alpha. They have the same issues.

So, I have recently added this standard particle shader with minimal support. For now, you can use Additive rendering mode for these particles. I will look into supporting other rendering mode as well in the future.

That would be great. My particle systems always show up through walls - are you sure I'm not doing anything wrong? 😅

That would be great. My particle systems always show up through walls - am I doing something wrong, or is this 'intended'?

Now that you say it, I realized that I forgot to set depth texture when rendering forward transparent pass (which includes particles). That's why the particles are always drawn on the screen. I'll fix it now.

I have fixed the bug in #52. You can pull the newest code for the fix.

@Looooong Wow, thanks! That was quick. I'll try it as soon as I can.

Works like a charm now, good job!


⚠ Samsung has degraded performance

In a2d9425, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2024 ms

Resolved: Samsung performance has improved in 9ee7043.


[Suggestion] createTeam color improvement

In team.js, createTeam will pick random colors between a range in a while loop. The downsides to this approach are:

Can theoretically run forever (though practically impossible)
Can pick the same color for two different teams, or colors that are near indistinguishable

Consider one of these approaches:

Store an array of all the colors you want to use, then pick one based on the team index (either passed in, or tracked  by a variable in the file)
Have a baseline color (like <48, 48, 48>). Figure out how large the steps between color can be (there should be a maximum team size, since Discord only lets you have 500 channels per server). Treat the array like a set of digits, and keep increasing it until you reach the lightest color. Then, go back to your baseline color, and start again. For example, if your step size is 20, the colors would be <48, 48, 48>, <48, 48, 68>, ..., <48, 48, 248>, <48, 68, 48>, ...

Then, you can either pass in the team index, or track it in the file.

I could pre-define an attractive set of colors and then iterate through them, though there would still be repeating across different brackets ( / team ranges). do you think that would be okay?


extract another round of diffs from pg PR

I rule and have completed some work on Case Manager that's ready for review!
Some gentle, non-feature-y diffs from the great postgresizing.
This pull request makes the following changes:

non-essential changes from postgres conversion - lots of cleanup and quality of life changes

no view changes
It relates to the following issue #s:

stems from #2072

For reviewer:

Adjust the title to explain what it does for the notification email to the listserv.
Tag this PR:

feature if it contains a feature, fix, or similar. This is anything that contains a user-facing fix in some way, such as frontend changes, alterations to backend behavior, or bug fixes.
dependencies if it contains library upgrades or similar. This is anything that upgrades any dependency, such as a Gemfile update or npm package upgrade.

If it contains neither, no need to tag this PR.

we'll just do this in the course of regular pg work


Make it compile with ZIO 2.0

This PR does the minimal amount of changes to get this library too compile against the latest ZIO 2.0 milestone release.
I can include the implicit ZTraceElement and updating any ZIO returning functions to take in parameters by name in this PR or hold off and do it in a followup PR once this is merged.

@adamgfraser rebased (no changes) the branch and changed the target branch.


ObjectSelector: pick first of objects if no default supplied?

For an ObjectSelector with default of None and some objects in its list, seems like it would make sense to set its value to the first from the list
Then, instead of:
dates = [StartEndDates(),Duration()]

class SomeFn(param.ParameterizedFunction):
    date_range = param.ObjectSelector(default=dates[0],objects=dates)
    def __call__(self,**params):
        p = param.ParamOverrides(self,params)
        print(p.date_range.get())

I could do this:
class SomeFn(param.ParameterizedFunction):
    date_range = param.ObjectSelector(objects=[StartEndDates(),Duration()])
    def __call__(self,**params):
        p = param.ParamOverrides(self,params)
        print(p.date_range.get())

Should think carefully about it, but maybe add a default_to_first-like argument to ObjectSelector. But default_to_first would need to default to False to avoid changing behavior for existing code that uses ObjectSelector with a default of None but a non-empty list of objects (something to consider for a new release).

Will be able to remove code from paramnb (https://github.com/ioam/paramnb/commit/df12e4b37e040963086cbf12c885a909af2b412c) when this is implemented.

We added Selector with this semantics, and for this reason it's preferred over ObjectSelector, but we kept ObjectSelector's semantics the way it was for backwards compatibility.


getLanguages return empty array if file doesn't include any keys

:tada: This issue has been resolved in version 1.14.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


add config options for git clone and resolve filename too long in Windows

in Windows, if the cloned project directory is long enough, the clone may fail.
Add a default Git configuration here to solve this problem.
I haven't found a related issue yet.
ref: https://stackoverflow.com/questions/22575662/filename-too-long-in-git-for-windows/40909460

Thank you very much for submitting this pull request. While this change would add the configuration value that would enable the repository to be cloned, some source control related functionality might still be broken after the repository has been cloned. Over the years I have not seen many issues around long paths so for the time being I will go ahead and close this pull request.


Appinsight reporting

Set up a class that takes as its one parameter the instrumentation key of an azure app insight.
https://docs.microsoft.com/en-us/azure/azure-monitor/app/opencensus-python
You can use the snippets from here to set up the app-insights and get that key:
https://github.com/atc-net/atc-snippets/tree/main/azure-cli/monitor
The new class, maybe named AtcInsightsReporter, should take any arguments that are serializable, to json, and add them as properties to a log entry that is sent to the appinsights. Importantly, the class should use the job introspection available in atc-dataplatform to also add a link to the correct workspace and job-run, so that one can find the way back to the line that caused the log.
The class should be usable as a context manager, where it catches all exceptions and reports them to log analytics.
This will allow for developer attention, while also letting the job run to successful completion.

I have started working on this in the branch feature/insights-reporter if anyone is interested in collaborating.


Mapillary Service not showing detection

Brief
Mapillary detection regulatory--no-left-or-u-turn--g1 id onl6dawx1eewdar8qqngo2l8al doesn't appear in iD.
Shows up correctly in Mapillary website link
Here is the iD link to reproduce the problem. Find the detection shown in the screenshot and click on it.

API inspection
The objects api, returns 4 detections matching the image_key k19D_nntbe3AHcc6Ab-MCg. This is what iD uses to show detections.
However, if you directly query the /images/id/detections API, you get a total of 5 detections (the new one being regulatory--no-left-or-u-turn--g1).
Though it directly affects iD users, I feel this is a problem on mapillary side. Is there a repository I can post it on?

Tracking it here https://github.com/mapillary/mapillary_issues/issues/2697


how to mock design data comming from a promise

hi @David-Desmaisons
im using a RelayResultCommand and a promise on view side. i need to get some mocked data to work on design time. however if i save the vm.cjson there will be no errors when calling the RelayResultCommand there are no exceptions so i can catch it and provide my own mocked version of the data.
is there a elegant way of hanlding this? what im doing is to manually modify a flag the vm.csjon to tell its design time so he shouldnt use the promise
thanks in advance

is there a elegant way of hanlding this? what im doing is to manually modify a flag the vm.csjon to tell its design time so he shouldnt use the promise

Could you explain better?
I will try to find an improved way to deal with command in design mode.

On Fri, 10 Apr 2020, 16:09 David Desmaisons<EMAIL_ADDRESS>wrote:

is there a elegant way of hanlding this? what im doing is to manually
modify a flag the vm.csjon to tell its design time so he shouldnt use the
promise
Could you explain better?

Just we dont get any data out from command in design mode. So need to do it
with workarounds.

I will try to find an improved way to deal with command in design mode.

Alright thanks, for now i will use some properties to simulate the return
data of the command.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/NeutroniumCore/Neutronium/issues/140#issuecomment-612021167,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAH6HSADF2IWARXNMTZMSD3RL4LAHANCNFSM4ME3XCOA
.

Check version 1.4.0 of neutronium-vm-loader
https://github.com/NeutroniumCore/neutronium-vm-loader

Cool thanks
On Sun, 26 Apr 2020, 20:17 David Desmaisons<EMAIL_ADDRESS>wrote:

Closed #140 https://github.com/NeutroniumCore/Neutronium/issues/140.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/NeutroniumCore/Neutronium/issues/140#event-3273161530,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAH6HSGOVTP6JVPSF2HPHVDRORUEHANCNFSM4ME3XCOA
.


[Question]: Markers doesn't change on filtering geojsondata

Hello, I'm very new to Angular and Leaflet. Sorry for my second question :)
I followed the example of iH8 from this question at Stackoverflow: how make ng-model="search" have influence on leaflet directive?
If this event is fired
function receiveMessage(event){
$scope.geojson.data = $filter('filter')($scope.data, 'name', 'some Value');
}
from another tab or frame with postMessage:
receiver.postMessage('value', 'URL')
the view changes and everything works fine. If I call this function locally or any other function with
$scope.geojson.data = $filter('filter')($scope.data, 'name', 'some Value');
nothing changes. Can someone explain me why?
Thanks in advance!

This issue was moved to angular-ui/ui-leaflet#96

I'm going to rework&redesign angular-leaflet-directive to be compatible with Leaflet v1.0. It will mantain almost all its functionality, and will be compatible with the current features of the directive, but I must start from a fresh point, so I'm going to close this issue. If you think it must be worked with the new version, please reopen it.


[QUESTION] How to retain the current layer with one key and swap it with another?

Sorry to raise an issue for this but Discussions are not enabled in this repo. Allow me to illustrate what I have in mind:

Hold spacebar -> layer X
Tap shift -> layer Y
Tap shift -> layer Z
Tap shift -> layer X (more tapping repeats the layer loop)
Release spacebar -> main layer

This could be a good alternative to what I was trying to achieve in #738. I tried using swapm to trigger a space but, because I am still holding it, it seems it does not trigger. Any pointers would be very much appreciated.

Never mind, I just realised I did not properly understand how swap works. That's all I needed. Thanks!


Update datepickers build to webpack 4

This updates datepickers to use webpack 4. Doesn't save much space, but it is more consistent with other modules.
I didn't test this at all, because I have never used it. Hope it still helps a little to release 3.0.0.

Legend, thanks so much @anajavi!


MAP-INFO Cannot read mod

Is this some kind of bug? The version is 1.51.2
I don't know if there are some more mods it didn't read,
but I found this: "Players have 60% Non-Curse aura" is missing on the MAP-INFO

Yes, it's a recent bug. Thanks for reporting, it should be the only mod that doesn't work (it's because of the hyphen in "non-curse").
If it's an important mod for your builds, you can edit the data\english\map-info.txt file to fix it for now (there won't be any updates until after Christmas):

search for noncurse in the file, place the hyphen, then save it

fixed in v1.52.0


Opening on all desktops on 2016 MBP w/ TouchBar

Hey guys, new to GitHub so forgive me if I'm doing anything wrong, but I am having an issue where the Desktop Player is staying open on all desktops (unless I put it in full screen mode). This just started happening today. I have tried rebooting the computer, force quitting the app, resetting the NVRAM, and everything else I can think of. To better describe the problem, I have 8 separate virtual desktops on my MacBook Pro. Normally, I can have 8 different applications open on separate desktops and swipe between them with the 3 finger gesture on the trackpad. However, what is happening now is when I swipe between them, the application stays open. No matter what I try. Thanks in advance for any help.
Edit: The version of Google Play Music Desktop Player that I am using is 4.1.1
-->
OS:
macOS Sierra 10.12.3
2016 MacBook Pro with TouchBar
Issue Descriptions:
See above
Steps to Reproduce:
Issue occurs every time I open the application.

Sounds very much like an OS (sierra) bug, I can't reproduce on either of my macs, can you provide a screencast of what you are seeing?

Thanks for the very quick response. Here is a link to a screencast I just recorded. It could be a bug with Sierra but it doesn't occur with anything else.
https://www.youtube.com/watch?v=tkAcJxt9AAY

Can you try the default Electron application and see if it exhibits the same behavior
https://github.com/electron/electron/releases/download/v1.4.12/electron-v1.4.12-darwin-x64.zip

How does one do that?

If this is what you are referring to I'm having trouble getting it to work.

@litgvng I linked the download before, simply download that zip file and launch the application

Ok, I did that and it is not exhibiting the same behavior.

I've investigated this as far as I can and I can't reproduce on any machine I have available to me (including the 2016 MBP).  The best I can suggest is turn off any custom Window Managers if you are using them and if not hope that a Chromium update will handle the issue.


[bug] API client is not thread safe

Current behavior
Crashes when performing multiple api calls using same *cloudflare.API client
Expected behavior
Safely perform multiple api calls using the same client in parallel
Explanation
*cloudflare.API.request is not thread safe and will crash when multiple api requests are made from different goroutines . (This obviously holds true for all of the higher level methods that call it).
The problem happens because we reuse the same http.Header struct across all requests, and http.Header.Set are essentially writes to the underlaying map[string][]string which are not thread safe.

Submitted a PR fixing the issue: https://github.com/cloudflare/cloudflare-go/pull/89


Equipment category schema rationalization

There's a general schema for links to other entities that looks like this:
"equipment_category": {
  "index": "armor",
  "name": "Armor",
  "url": "/api/equipment-categories/armor"
},

But most of the subcategories in 5e-SRD-Equipment.json look like this instead:
"armor_category": "Light",

The one exception to this is gear_category:
"gear_category": {
  "index": "standard-gear",
  "name": "Standard Gear",
  "url": "/api/equipment-categories/standard-gear"
},

My initial thought was that the categories that were represented as simple strings weren't found in 5e-SRD-Equipment-Categories.json, but nope:
{
  "index": "light-armor",
  "name": "Light Armor",
  "equipment": [
    {
      "index": "padded",
      "name": "Padded",
      "url": "/api/equipment/padded"
    },
    {
      "index": "leather",
      "name": "Leather",
      "url": "/api/equipment/leather"
    },
    {
      "index": "studded-leather",
      "name": "Studded Leather",
      "url": "/api/equipment/studded-leather"
    }
  ],
  "url": "/api/equipment-categories/light-armor"
},

I'm not sure what the policy is for breaking changes.

Can I put up a PR to fix this?
Since all of the subcategory types (gear_category, armor_category, vehicle_category, tool_category, weapon_category) appear at first glance to be mutually exclusive, can this be consolidated as an equipment_subcategory field?

I actually think that kind of makes sense? I'm not even sure where the concept of Standard Gear came from. It's not in the SRD at all.
We play a little fast and loose with breaking changes. Probably more than we should. If you want to do this right, I'd break this PR into two separate PR.

Add the equipment_subcategory field
Remove the extra category fields

This allows us to make a deprecation announcement between them and space out when we merge them.

To be clear, I think we should definitely do this.

I'll get there at some point if you (or someone else) doesn't beat me to it. I'm not working on integrating SRD data sets right now, so further data cleanups have been bumped to the back burner for me, but you'll know next time I do. :slightly_smiling_face:

Sounds great! I'm sure someone will get to it!

It appears that "arrow" equipment which might be a special case but it's in 3 different categories. "adventuring-gear", "ammunition", and "standard-gear". So I would actually suggest that "equipment_category" becomes a list instead of just adding a "equipment_subcategory".

@MikkelPaulson I had an idea related to this in another issue where it might make more sense to combine these like so:
  "equipment_categories": [{
    "index": "weapon",
    "name": "Weapon",
    "url": "/api/equipment-categories/weapon"
  }, {
    "index": "martial-melee-weapons",
    "name": "Martial Melee Weapons",
    "url": "/api/equipment-categories/martial-melee-weapons"
  }, {
    "index": "martial-weapons",
    "name": "Martial Weapons",
    "url": "/api/equipment-categories/martial-weapons"
  }, {
    "index": "melee-weapons",
    "name": "Melee Weapons",
    "url": "/api/equipment-categories/melee-weapons"
  }],

@MikkelPaulson I had an idea related to this in another issue where it might make more sense to combine these like so:
  "equipment_categories": [{
    "index": "weapon",
    "name": "Weapon",
    "url": "/api/equipment-categories/weapon"
  }, {
    "index": "martial-melee-weapons",
    "name": "Martial Melee Weapons",
    "url": "/api/equipment-categories/martial-melee-weapons"
  }, {
    "index": "martial-weapons",
    "name": "Martial Weapons",
    "url": "/api/equipment-categories/martial-weapons"
  }, {
    "index": "melee-weapons",
    "name": "Melee Weapons",
    "url": "/api/equipment-categories/melee-weapons"
  }],

@bagelbits If we did this, and we waited for a second PR to eliminate the old fields, then we'd have something like the following, right?
  {
    "index": "club",
    "name": "Club",
    "equipment_category": {
      "index": "weapon",
      "name": "Weapon",
      "url": "/api/equipment-categories/weapon"
    },
    "equipment_categories": [{
      "index": "weapon",
      "name": "Weapon",
      "url": "/api/equipment-categories/weapon"
    }, {
      "index": "simple-melee-weapons",
      "name": "Simple Melee Weapons",
      "url": "/api/equipment-categories/simple-melee-weapons"
    }, {
      "index": "simple-weapons",
      "name": "Simple Weapons",
      "url": "/api/equipment-categories/simple-weapons"
    }, {
      "index": "melee-weapons",
      "name": "Melee Weapons",
      "url": "/api/equipment-categories/melee-weapons"
    }],
    "weapon_category": "Simple",
    "weapon_range": "Melee",
    "category_range": "Simple Melee",
    "cost": {
      "quantity": 1,
      "unit": "sp"
    },
    "damage": {
      "damage_dice": "1d4",
      "damage_type": {
        "index": "bludgeoning",
        "name": "Bludgeoning",
        "url": "/api/damage-types/bludgeoning"
      }
    },
    "range": {
      "normal": 5
    },
    "weight": 2,
    "properties": [
      {
        "index": "light",
        "name": "Light",
        "url": "/api/weapon-properties/light"
      },
      {
        "index": "monk",
        "name": "Monk",
        "url": "/api/weapon-properties/monk"
      }
    ],
    "url": "/api/equipment/club"
  },

The initial PR would look pretty clunky with both an "equipment_category" and an "equipment_categories" field. Would we be okay with this for the initial PR?

I think it's not that clunky it's like the primary equipment category and then the set of secondary categories. I have not thought of all of the downstream effects this change would have. Consumers of the data would all need to change to support a list of categories.

I agree this will be quite the change for consumers. We should definitely depreciate the old format first. As long as the above code looks acceptable, I think I'll get cracking on a build.

@mpeck451 I'm not sure your example removed any old fields. But that is what the interim state would look like. I assume the final result after the second PR would just be:
  {
    "index": "club",
    "name": "Club",
    "equipment_categories": [{
      "index": "weapon",
      "name": "Weapon",
      "url": "/api/equipment-categories/weapon"
    }, {
      "index": "simple-melee-weapons",
      "name": "Simple Melee Weapons",
      "url": "/api/equipment-categories/simple-melee-weapons"
    }, {
      "index": "simple-weapons",
      "name": "Simple Weapons",
      "url": "/api/equipment-categories/simple-weapons"
    }, {
      "index": "melee-weapons",
      "name": "Melee Weapons",
      "url": "/api/equipment-categories/melee-weapons"
    }],
    "cost": {
      "quantity": 1,
      "unit": "sp"
    },
    "damage": {
      "damage_dice": "1d4",
      "damage_type": {
        "index": "bludgeoning",
        "name": "Bludgeoning",
        "url": "/api/damage-types/bludgeoning"
      }
    },
    "range": {
      "normal": 5
    },
    "weight": 2,
    "properties": [
      {
        "index": "light",
        "name": "Light",
        "url": "/api/weapon-properties/light"
      },
      {
        "index": "monk",
        "name": "Monk",
        "url": "/api/weapon-properties/monk"
      }
    ],
    "url": "/api/equipment/club"
  },


Fix function comments based on best practices from Effective Go

Hi, we updated some exported function comments based on best practices from Effective Go. It’s admittedly a relatively minor fix up. Does this help you?

Codecov Report

Merging #9 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master     #9   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           1      1
  Lines         152    152
=====================================
  Hits          152    152

Impacted Files
Coverage Δ

merkle.go
100% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84ec7ce...8d95ef1. Read the comment docs.