Progress HUD not shown: iOS 8

Hello
Unfortunately I found out a regression in the progress HUD. Everything is working fine under iOS 7, but under iOS 8 I cannot see the progress HUD displayed and what I get in my output window is:

2015-02-26 12:00:09.407 Angel[6336:100953] Unable to simultaneously satisfy constraints.
Probably at least one of the constraints in the following list is one you don't want. Try this: (1) look at each constraint and try to figure out which you don't expect; (2) find the code that added the unwanted constraint or constraints and fix it. (Note: If you're seeing NSAutoresizingMaskLayoutConstraints that you don't understand, refer to the documentation for the UIView property translatesAutoresizingMaskIntoConstraints)
(
"<NSLayoutConstraint:0x792c4740 H:[UIImageView:0x792cf380(-50)]>",
"<NSLayoutConstraint:0x792d6890 H:[UILabel:0x792c8480'Loading...']-(20)-|   (Names: '|':UIImageView:0x792cf380 )>",
"<NSLayoutConstraint:0x792df990 H:|-(20)-[UILabel:0x792c8480'Loading...']   (Names: '|':UIImageView:0x792cf380 )>"
)
Will attempt to recover by breaking constraint
<NSLayoutConstraint:0x792d6890 H:[UILabel:0x792c8480'Loading...']-(20)-|   (Names: '|':UIImageView:0x792cf380 )>
Make a symbolic breakpoint at UIViewAlertForUnsatisfiableConstraints to catch this in the debugger.
The methods in the UIConstraintBasedLayoutDebugging category on UIView listed in <UIKit/UIView.h> may also be helpful.
2015-02-26 12:00:09.407 Angel[6336:100953] Unable to simultaneously satisfy constraints.
Probably at least one of the constraints in the following list is one you don't want. Try this: (1) look at each constraint and try to figure out which you don't expect; (2) find the code that added the unwanted constraint or constraints and fix it. (Note: If you're seeing NSAutoresizingMaskLayoutConstraints that you don't understand, refer to the documentation for the UIView property translatesAutoresizingMaskIntoConstraints)
(
"<NSLayoutConstraint:0x792c4740 H:[UIImageView:0x792cf380(-50)]>"
)
Will attempt to recover by breaking constraint
<NSLayoutConstraint:0x792c4740 H:[UIImageView:0x792cf380(-50)]>
Make a symbolic breakpoint at UIViewAlertForUnsatisfiableConstraints to catch this in the debugger.
The methods in the UIConstraintBasedLayoutDebugging category on UIView listed in <UIKit/UIView.h> may also be helpful.
I tried to move
[KVNProgress setConfiguration:[self customKVNProgressUIConfiguration:_deviceScreenSize]];
    [KVNProgress<EMAIL_ADDRESS>nil)];

in "viewDidAppear" method instead of in "viewDidLoad" method. The first time I am able to display the progress HUD, but from the second one I get the same "warning message" in the output window and I was not able to see the progress HUD.
Could you try to fix it?
Thank you very much.

Hello @foffux, can you show me the KVNConfiguration you use exactly? So I can try reproduce it and fix it.

here also.. i've implemented it on a other uiview loaded at runtime. when i init kvn it says 'Unable to simultaneously satisfy constraints.' ... maybe you should do a version without autolayout? if something is not so correct it messes up all the things and kvn wont show up.

Hello Kevin.
I think @justvanbloom could be right, in fact today with same code with same test, I cannot reproduce that issue anymore, even my self...
My
KVNProgressConfiguration

is really a basic one:
- (KVNProgressConfiguration *)customKVNProgressUIConfiguration:(NSInteger)deviceScreenSize
{
	KVNProgressConfiguration *configuration = [[KVNProgressConfiguration alloc] init];

    CGFloat circleSize;
    CGFloat statusFont;
    CGFloat lineWidth;
    if (deviceScreenSize == SCREEN_SIZE_IPAD_CLASSIC) {
        circleSize = 220.0f;
        statusFont = 30.0f;
        lineWidth = 2.0f;
    } else {
        circleSize = 110.0f;
        statusFont = 15.0f;
        lineWidth = 1.0f;
    }

	// See the documentation of KVNProgressConfiguration
	configuration.statusColor = [UIColor whiteColor];
	configuration.statusFont = [UIFont fontWithName:@"Play-Bold" size:statusFont];
	configuration.circleStrokeForegroundColor = [UIColor whiteColor];
	configuration.circleStrokeBackgroundColor = [UIColor colorWithWhite:1.0f alpha:0.3f];
	configuration.circleFillBackgroundColor = [UIColor colorWithWhite:1.0f alpha:0.1f];
	configuration.backgroundFillColor = [UIColor colorWithRed:0.173f green:0.263f blue:0.856f alpha:0.9f];
    configuration.backgroundTintColor = [UIColor colorWithRed:43/255.0f green:183/255.0f blue:185/255.0f alpha:1.0f];
    configuration.successColor = [UIColor whiteColor];
	configuration.errorColor = [UIColor whiteColor];
	configuration.circleSize = circleSize;
	configuration.lineWidth = lineWidth;

	return configuration;
}

Also for me: maybe you should do a version without auto layout? Or at least think about it?
Thank you very much.

HA! its magic! ok.
so it's gone! it was a faulty autolayout issue by me. opened in xcode beta (latest) and i saw the broken things. sry. for all others: use masonry pod to get rid of..

Hello @justvanbloom, what did you do to make this issue go away?
Is it related to Xcode 6.3 beta, or to Masonry pod?
Thanks for the enlightenment!

I do not think it is due to Xcode 6.3 beta because I am not using it but
standard release. So I think it is Masonry pod, even if I do not know what
it is exactly.
I have to check.
Thank you anyway.
2015-02-18 8:50 GMT+01:00 Kevin Hirsch<EMAIL_ADDRESS>
Hello @justvanbloom https://github.com/justvanbloom, what did you do to
make this issue go away?
Is it related to Xcode 6.3 beta, or to Masonry pod?
Thanks for the enlightenment!
—
Reply to this email directly or view it on GitHub
https://github.com/kevin-hirsch/KVNProgress/issues/29#issuecomment-74825415
.

So do we agree on closing this issue?

If I was you I would wait. Let me try that Masonry pod. Then I will tell
you and after that you will close it.
Thank you.
2015-02-18 9:02 GMT+01:00 Kevin Hirsch<EMAIL_ADDRESS>
So do we agree on closing this issue?
—
Reply to this email directly or view it on GitHub
https://github.com/kevin-hirsch/KVNProgress/issues/29#issuecomment-74826451
.

Okay, I wait for your review then, thanks a lot ! :+1:

hello @justvanbloom: could you please let us know how to use masonry pod tougher with KVNProgress?
Because, in my project, I am not using auto layout at all. So I cannot understand if this issue is related to KVNProgress that uses auto layout and so it must use it with masonry pod (in this case, how), or something else.
Can you get what I told? Is it clear?
Thank you.

Ok. So ist easy. Make a broken autolayout element in storyboard, after this view is displayed, kvn wont show normally. I'll make a pull these days. Just for be sure :)

Ok I will wait for your pull then to see if this issue had been solved.
Kevin, me too I want to make a pull. It is a simple change I need and I
guess it could be helpful. I have never done before. How am I suppose to do
that? Thank you.
Il mercoledì 18 febbraio 2015, JustVanBlooM<EMAIL_ADDRESS><javascript:_e(%7B%7D,'cvml','notifications@github.com');>> ha scritto:

Ok. So ist easy. Make a broken autolayout element in storyboard, after
this view is displayed, kvn wont show normally. I'll make a pull these
days. Just for be sure :)
—
Reply to this email directly or view it on GitHub
https://github.com/kevin-hirsch/KVNProgress/issues/29#issuecomment-74877520
.

I'll make a pull these days

You mean you'll make a pull of last Masonry commits to be sure this issue is not fixed?

Hello guys.
Any news about that pull that would fix this issue?
I am testing it on my real device and as soon as something goes wrong this controller is not shown anymore. iPhone 5s with iOS 8 is the device.
If it cannot be fixed, I have  unfortunately to swap on another progress hud.
I look forward to a positive answer.
Thank you so much

@foffux:
Same here. I thought i had fixed but its still not fixed. Can you post a log what goes wrong? Is it also a nslayout issue before?

I will try to reproduce it.
I do not think in the we.
As soon as I can anyway and let you know
Thank you

any news on this?

Here I am.
I cannot write you directly from inside github, I do not know how...
What I can see testing it directly in my reals device, but just with iOS 8,
is the following:
2015-02-23 14:00:02.999 Angel[346:34741] Unable to simultaneously satisfy
constraints.

Probably at least one of the constraints in the following list is one you
don't want. Try this: (1) look at each constraint and try to figure out
which you don't expect; (2) find the code that added the unwanted
constraint or constraints and fix it. (Note: If you're seeing
NSAutoresizingMaskLayoutConstraints that you don't understand, refer to the
documentation for the UIView property
translatesAutoresizingMaskIntoConstraints) *

(

"<NSLayoutConstraint:0x174487990 H:[UIImageView:0x1741fcd00(-50)]>",*

"<NSLayoutConstraint:0x174487210
H:[UILabel:0x1356938b0'Loading...']-(20)-|   (Names:
'|':UIImageView:0x1741fcd00 )>",*

"<NSLayoutConstraint:0x1744873f0
H:|-(20)-[UILabel:0x1356938b0'Loading...']   (Names:
'|':UIImageView:0x1741fcd00 )>"*

)
*Will attempt to recover by breaking constraint *
<NSLayoutConstraint:0x174487210 H:[UILabel:0x1356938b0'Loading...']-(20)-|
(Names: '|':UIImageView:0x1741fcd00 )>
Make a symbolic breakpoint at UIViewAlertForUnsatisfiableConstraints to
catch this in the debugger.
The methods in the UIConstraintBasedLayoutDebugging category on UIView
listed in <UIKit/UIView.h> may also be helpful.
2015-02-23 14:00:03.000 Angel[346:34741] Unable to simultaneously satisfy
constraints.

Probably at least one of the constraints in the following list is one you
don't want. Try this: (1) look at each constraint and try to figure out
which you don't expect; (2) find the code that added the unwanted
constraint or constraints and fix it. (Note: If you're seeing
NSAutoresizingMaskLayoutConstraints that you don't understand, refer to the
documentation for the UIView property
translatesAutoresizingMaskIntoConstraints) *

(

"<NSLayoutConstraint:0x174487990 H:[UIImageView:0x1741fcd00(-50)]>"*

)
*Will attempt to recover by breaking constraint *
<NSLayoutConstraint:0x174487990 H:[UIImageView:0x1741fcd00(-50)]>
Make a symbolic breakpoint at UIViewAlertForUnsatisfiableConstraints to
catch this in the debugger.
The methods in the UIConstraintBasedLayoutDebugging category on UIView
listed in <UIKit/UIView.h> may also be helpful.
I hope this can help to understand how to fix this problem.
Let me know.
2015-02-23 10:32 GMT+01:00 JustVanBlooM<EMAIL_ADDRESS>
any news on this?
—
Reply to this email directly or view it on GitHub
https://github.com/kevin-hirsch/KVNProgress/issues/29#issuecomment-75511854
.

Yep. Exactly this is it. So it seems autolayout is broken..
@kevin ?

Sorry for yesterday. I wasn't available.
So, to be clear, it is just an auto layout issue on iOS 8 that has nothing to do with another library like Masonry and it happens every time you show the KVNProgress HUD, no matter when in the app lifetime. Am I right ?
And, when you talk about iOS 8, you mean 8.0+ or a newer version ?

Hello guys:
yes is an auto layout issue on iOS 8, anyway every logs I retrieved I have already attached them to this issue so you can have a look at them.
I am using iOS 8.1.2.
It does not happen every time but very often. In iOS 7 no issue at all, never. Yes, no matter when in the app lifetime.
Okay thank you very much, because I really need this controller and I would keep using it.

Thank you for the details! I will check that tonight (GMT+1) ;)

Okay, have a nice chase... :-)
Let me know if you need something, I would be able to close this issue in a few time.

Thanks!

Great! i will also use this controller for a few projects. Ofc including Acknowledgments in AppSettings / info!

It seems that there is a problem coming from the width constraint on the contentView:
NSLayoutConstraint: @"H:[UIImageView(-50)]"

It shouldn't be -50. It should be a positive number.
I was not able to reproduce the bug using Simulator iPhone 5 and 6 on iOS 8.1 and my own iPhone 6 device on iOS 8.1.3 using Xcode 6.1.1 (6A2008a). I tested all orientations also.
@foffux, can you precise some things for me, please:

The Xcode version you are using
The KVNProgress version you are using
The device you tested/reproduced the bug on (Simulator, iPhone 5, ...)
The orientation you tested/reproduced the bug with

Thanks for the details.

Xcode Version 6.1.1 (6A2008a)
iPhone 6 and 6 Plus
KVNProgress latest from pods
Portrait..
Same :) ok. so ist just this?

Xcode: same version you used if I ma not wrong. I have to check.
Kvnprogress: latest from cocoa pods
Device: iPhone 5 s, iOS 8.1.2
Orientation: just portrait
Pay attention: it does not happen every time. But when happens then it won't show anymore.
It happens more often in the device than in the simulator. But always with iOS 8 not in iOS 7.
When happens in the console you can see logs I attached.
Question: if you think problem is what you highlighted, give me a debug version with traces on, I will test it for you. Okay?
Thanks
Inviato da iPhone

Il giorno 24/feb/2015, alle ore 23:39, Kevin Hirsch<EMAIL_ADDRESS>ha scritto:
It seems that there is a problem coming from the width constraint on the contentView:
NSLayoutConstraint: @"H:[UIImageView(-50)]"
It shouldn't be -50. It should be a positive number.
I was not able to reproduce the bug using Simulator iPhone 5 and 6 on iOS 8.1 and my own iPhone 6 device on iOS 8.1.3 using Xcode 6.1.1 (6A2008a). I tested all orientations also.
@foffux, can you precise some things for me, please:
The Xcode version you are using
The KVNProgress version you are using
The device you tested/reproduced the bug on (Simulator, iPhone 5, ...)
The orientation you tested/reproduced the bug with
Thanks for the details.
—
Reply to this email directly or view it on GitHub.

Strange, I am not able to reproduce it. If you want to debug it, I created a branch invisible-hud. Just checkout the branch and change use the KVNPRogress.m file to have the logs. Thanks!

Here I am.
I am able to reproduce this bug systematically, at least in my project.
Here you are logs you inserted:
2015-04-01 12:02:09.109 Angel[5591:104643] ===== SHOWING HUD
2015-04-01 12:02:09.412 Angel[5591:104643] ===== SHOWING HUD
2015-04-01 12:02:09.413 Angel[5591:104643] ==== SETTING UI
2015-04-01 12:02:09.413 Angel[5591:104643] ===== SETTING BASE CONSTRAINTS
2015-04-01 12:02:09.413 Angel[5591:104643] = bounds: {{0, 0}, {0, 0}}
2015-04-01 12:02:09.413 Angel[5591:104643] = statusInset: 10.000000
2015-04-01 12:02:09.413 Angel[5591:104643] = fullScreen: 0
2015-04-01 12:02:09.414 Angel[5591:104643] = contentWidth: -50.000000
2015-04-01 12:02:09.414 Angel[5591:104643] ===== FINISH SETTING BASE CONSTRAINTS
2015-04-01 12:02:09.414 Angel[5591:104643] ==== FINISH SETTING UI
2015-04-01 12:02:09.415 Angel[5591:104643] ===== FINISH SHOWING HUD
2015-04-01 12:02:11.569 Angel[5591:104643] ==== DISMISSING HUD
2015-04-01 12:02:11.975 Angel[5591:104643] ==== FINISH DISMISSING HUD
Issue seems to be exactly in the place you talked about:
2015-04-01 12:02:09.414 Angel[5591:104643] = contentWidth: -50.000000
Another occurrence, maybe this log can help you more:
2015-04-01 12:01:28.499 Angel[5591:104643] ===== SHOWING HUD
2015-04-01 12:01:28.500 Angel[5591:104643] ===== ADDING TO SUPERVIEW: <UIWindow: 0x7c1503d0; frame = (0 0; 0 0); hidden = YES; gestureRecognizers = <NSArray: 0x7c11b200>; layer = <UIWindowLayer: 0x7c146da0>>
2015-04-01 12:01:28.501 Angel[5591:104643] ===== FINISH ADDING TO SUPERVIEW: <UIWindow: 0x7c1503d0; frame = (0 0; 0 0); hidden = YES; autoresize = W+H; gestureRecognizers = <NSArray: 0x7c11b200>; layer = <UIWindowLayer: 0x7c146da0>>
2015-04-01 12:01:28.501 Angel[5591:104643] ==== SETTING UI
2015-04-01 12:01:28.501 Angel[5591:104643] ===== SETTING BASE CONSTRAINTS
2015-04-01 12:01:28.501 Angel[5591:104643] = bounds: {{0, 0}, {0, 0}}
2015-04-01 12:01:28.501 Angel[5591:104643] = statusInset: 10.000000
2015-04-01 12:01:28.501 Angel[5591:104643] = fullScreen: 0
2015-04-01 12:01:28.501 Angel[5591:104643] = contentWidth: -50.000000
2015-04-01 12:01:28.506 Angel[5591:104643] Unable to simultaneously satisfy constraints.
Probably at least one of the constraints in the following list is one you don't want. Try this: (1) look at each constraint and try to figure out which you don't expect; (2) find the code that added the unwanted constraint or constraints and fix it. (Note: If you're seeing NSAutoresizingMaskLayoutConstraints that you don't understand, refer to the documentation for the UIView property translatesAutoresizingMaskIntoConstraints)
(
"<NSLayoutConstraint:0x7c16f870 H:[UIImageView:0x7c16cd30(-50)]>",
"<NSLayoutConstraint:0x7c1a05e0 H:[UILabel:0x7c1bf210'Comunicazione avvenuta']-(20)-|   (Names: '|':UIImageView:0x7c16cd30 )>",
"<NSLayoutConstraint:0x7c1a0640 H:|-(20)-[UILabel:0x7c1bf210'Comunicazione avvenuta']   (Names: '|':UIImageView:0x7c16cd30 )>"
)
Will attempt to recover by breaking constraint
<NSLayoutConstraint:0x7c1a05e0 H:[UILabel:0x7c1bf210'Comunicazione avvenuta']-(20)-|   (Names: '|':UIImageView:0x7c16cd30 )>
Make a symbolic breakpoint at UIViewAlertForUnsatisfiableConstraints to catch this in the debugger.
The methods in the UIConstraintBasedLayoutDebugging category on UIView listed in <UIKit/UIView.h> may also be helpful.
2015-04-01 12:01:28.507 Angel[5591:104643] Unable to simultaneously satisfy constraints.
Probably at least one of the constraints in the following list is one you don't want. Try this: (1) look at each constraint and try to figure out which you don't expect; (2) find the code that added the unwanted constraint or constraints and fix it. (Note: If you're seeing NSAutoresizingMaskLayoutConstraints that you don't understand, refer to the documentation for the UIView property translatesAutoresizingMaskIntoConstraints)
(
"<NSLayoutConstraint:0x7c16f870 H:[UIImageView:0x7c16cd30(-50)]>"
)
Will attempt to recover by breaking constraint
<NSLayoutConstraint:0x7c16f870 H:[UIImageView:0x7c16cd30(-50)]>
Make a symbolic breakpoint at UIViewAlertForUnsatisfiableConstraints to catch this in the debugger.
The methods in the UIConstraintBasedLayoutDebugging category on UIView listed in <UIKit/UIView.h> may also be helpful.
2015-04-01 12:01:28.507 Angel[5591:104643] ===== FINISH SETTING BASE CONSTRAINTS
2015-04-01 12:01:28.535 Angel[5591:104643] ===== UPDATING BACKGROUND CONSTRAINTS
2015-04-01 12:01:28.535 Angel[5591:104643] = fullScreen: 0
2015-04-01 12:01:28.535 Angel[5591:104643] = status: Lotteria...
2015-04-01 12:01:28.535 Angel[5591:104643] = contentViewWidth: -50.000000
2015-04-01 12:01:28.536 Angel[5591:104643] ===== FINISH UPDATING BACKGROUND CONSTRAINTS
2015-04-01 12:01:28.536 Angel[5591:104643] ==== FINISH SETTING UI
2015-04-01 12:01:28.536 Angel[5591:104643] ===== FINISH SHOWING HUD
Hope this can help you solving this blocking issue.
Thank you.

Thank you very much! The problem is now obvious:
bounds: {{0, 0}, {0, 0}}

This is not normal. I will look at it tomorrow ;)

Ah okay, of course:
bounds: {{0, 0}, {0, 0}}

is not a good value...:-)
Perfect.
I will look forward to seeing what was the actual problem.
Thank you.

Ah! Digging into it later..

Hello guys
Any good news?
Think you

In the method addToView: the constraint are set to the key window if displaying in fullscreen. Maybe the problem here is that your projects are not using auto layout. Can you confirm that, @foffux & @justvanbloom?

I use autolayout in xib based things and mixed in code something with, something absolute positioned.. Well, just check in view.bounds for 0,0,0,0 on creation?

Absolutely, I am not using auto layout in all my projects and I do not want to use them, at least at the moment. So if your controller could work also without auto layout it should be very nice and helpful.
Thank you very much and let us know how it proceeds.

@foffux: I don't want to remove auto layout from my project but I will do a new commit tonight (GMT+1) with a fix. You will be able to test it and tell me if it solves your problem ;)

Okay okay no problem at all with auto layout. The only thing I am interested in is that I am able to use your controller. Just that.
No problem with testing your fixing commit, but unfortunately I am not at home untill next tuesday. So I will test it on that day. I do not know if in the meantime @justvanbloom can test it too. Anyway, as soon as I will come back home I will test it.
Thank you.

@foffux: no problem!

Can test it asap:)

ok great
see you soon then with this issue closed, I hope

I made a new commit to try to fix this issue. You can test it by pulling branch invisible-hud.
I also add a new log just after:
===== ADDING TO SUPERVIEW:

to check that the superview bounds are correct:
= superview bounds:

Hopes it solves the problem. Keep me updated. Thanks!

hmm.. current state:
===== SHOWING HUD
2015-02-28 19:29:36.606  -beta1[487:68980] ===== ADDING TO SUPERVIEW: <UIWindow: 0x156d0db40; frame = (0 0; 0 0); hidden = YES; gestureRecognizers = <NSArray: 0x174441ce0>; layer = <UIWindowLayer: 0x17442bf40>>
2015-02-28 19:29:36.606  -beta1[487:68980] = superview bounds: {{0, 0}, {0, 0}}
2015-02-28 19:29:36.611  -beta1[487:68980] ===== FINISH ADDING TO SUPERVIEW: <UIWindow: 0x156d0db40; frame = (0 0; 0 0); hidden = YES; autoresize = W+H; gestureRecognizers = <NSArray: 0x174441ce0>; layer = <UIWindowLayer: 0x17442bf40>>
2015-02-28 19:29:36.612  -beta1[487:68980] ==== SETTING UI
2015-02-28 19:29:36.613  -beta1[487:68980] ===== SETTING BASE CONSTRAINTS
2015-02-28 19:29:36.614  -beta1[487:68980] = bounds: {{0, 0}, {0, 0}}
2015-02-28 19:29:36.614  -beta1[487:68980] = statusInset: 10.000000
2015-02-28 19:29:36.615  -beta1[487:68980] = fullScreen: 0
2015-02-28 19:29:36.616  -beta1[487:68980] = contentWidth: -50.000000
2015-02-28 19:29:36.618  -beta1[487:68980] Unable to simultaneously satisfy constraints.
(
"<NSLayoutConstraint:0x174489ab0 UIImageView:0x156d7da80.width == -50>",
"<NSLayoutConstraint:0x174489790 UIImageView:0x156d7da80.trailing == UILabel:0x156d7dbc0.trailing + 20>",
"<NSLayoutConstraint:0x17448a690 UILabel:0x156d7dbc0.leading == UIImageView:0x156d7da80.leading + 20>"

)
Will attempt to recover by breaking constraint
<NSLayoutConstraint:0x174489790 UIImageView:0x156d7da80.trailing == UILabel:0x156d7dbc0.trailing + 20>
Make a symbolic breakpoint at UIViewAlertForUnsatisfiableConstraints to catch this in the debugger.
The methods in the UIConstraintBasedLayoutDebugging category on UIView listed in <UIKit/UIView.h> may also be helpful.
2015-02-28 19:29:36.621  -beta1[487:68980] Unable to simultaneously satisfy constraints.
Probably at least one of the constraints in the following list is one you don't want. Try this: (1) look at each constraint and try to figure out which you don't expect; (2) find the code that added the unwanted constraint or constraints and fix it. (Note: If you're seeing NSAutoresizingMaskLayoutConstraints that you don't understand, refer to the documentation for the UIView property translatesAutoresizingMaskIntoConstraints)

(
"<NSLayoutConstraint:0x174489ab0 UIImageView:0x156d7da80.width == -50>"

)
Will attempt to recover by breaking constraint
<NSLayoutConstraint:0x174489ab0 UIImageView:0x156d7da80.width == -50>
Make a symbolic breakpoint at UIViewAlertForUnsatisfiableConstraints to catch this in the debugger.

why this? before i have a broken constraint added to uiview.. and if its there it wont show.
2015-02-28 19:29:36.606 -beta1[487:68980] = superview bounds: {{0, 0}, {0, 0}}
i've added KVN AFTER the broken contraint from the other view is shoed.. if it gets added before there is no probelm showing KVN.
So simply checking superview bounds for nil eg. {{0, 0}, {0, 0}} and grad uiapplication mainscreen size should solve it or?

so the fix is:
superview = [UIApplication sharedApplication].keyWindow;
if (!superview) {
superview = [[UIApplication sharedApplication].windows objectAtIndex:0];
}
in

(void)addToView:(UIView *)superview
{
#warning fix
superview = [UIApplication sharedApplication].keyWindow;
if (!superview) {
superview = [[UIApplication sharedApplication].windows objectAtIndex:0];
}
NSLog(@"===== ADDING TO SUPERVIEW: %@", superview);

Will attempt to recover by breaking constraint
<NSLayoutConstraint:0x1742896f0 UILabel:0x13fd12b80.width == 217>
Make a symbolic breakpoint at UIViewAlertForUnsatisfiableConstraints to catch this in the debugger.
The methods in the UIConstraintBasedLayoutDebugging category on UIView listed in <UIKit/UIView.h> may also be helpful.
2015-02-28 19:45:15.220 beta1[493:71552] -[MasterViewController hideSettingsView] [Line 3176] hide
2015-02-28 19:45:15.473 beta1[493:71552] __40-[MasterViewController hideSettingsView]_block_invoke1563 [Line 3191] Animation finished
2015-02-28 19:45:19.942 beta1[493:71552] -[MasterViewController icloudsync:] [Line 3298] icloud sync
2015-02-28 19:45:19.956 beta1[493:71552] ===== SHOWING HUD
2015-02-28 19:45:19.958 beta1[493:71552] ===== ADDING TO SUPERVIEW: <UIWindow: 0x13fe0b2b0; frame = (0 0; 414 736); autoresize = W+H; gestureRecognizers = <NSArray: 0x17024b880>; layer = <UIWindowLayer: 0x170220f20>>
2015-02-28 19:45:19.958 beta1[493:71552] = superview bounds: {{0, 0}, {413.99999999999994,<PHONE_NUMBER>0000011}}
2015-02-28 19:45:19.965 beta1[493:71552] ===== FINISH ADDING TO SUPERVIEW: <UIWindow: 0x13fe0b2b0; frame = (0 0; 414 736); autoresize = W+H; gestureRecognizers = <NSArray: 0x17024b880>; layer = <UIWindowLayer: 0x170220f20>>
2015-02-28 19:45:19.966 beta1[493:71552] ==== SETTING UI
2015-02-28 19:45:19.966 beta1[493:71552] ===== SETTING BASE CONSTRAINTS
2015-02-28 19:45:19.967 beta1[493:71552] = bounds: {{0, 0}, {413.99999999999994,<PHONE_NUMBER>0000011}}

Hello guys
So if I can understand, the state of art is that this issue is still there. Right?
@kevin: any news after latest comments made in your fix?
Thank you

@foffux: temporally fix: search -(void)addToView
Insert fix
-(void)addToView:(UIView *)superview
{
#warning fix
superview = [UIApplication sharedApplication].keyWindow;
if (!superview) {
superview = [[UIApplication sharedApplication].windows objectAtIndex:0];
}
#warning fix

Okay thank you I will try as soon as I will come back home. Should this fix the issue? Have you already try it?

Jep. This fixed it.

@justvanbloom: when adding the full screen HUD, it is calling:
- (void)addToCurrentWindow
{
 UIWindow *currentWindow = nil;

 NSEnumerator *frontToBackWindows = [[[UIApplication sharedApplication] windows] reverseObjectEnumerator];

 for (UIWindow *window in frontToBackWindows) {
 	if (window.windowLevel == UIWindowLevelNormal) {
 		currentWindow = window;
 		break;
 	}
 }

 if (self.superview != currentWindow) {
 	[self addToView:currentWindow];
 }
}

So changing the way to get the current window to yours should resolve the problem:
- (void)addToCurrentWindow
{
 UIWindow *currentWindow = [UIApplication sharedApplication].keyWindow;

 if (!currentWindow) {
 	NSEnumerator *frontToBackWindows = [[[UIApplication sharedApplication] windows] reverseObjectEnumerator];

 	for (UIWindow *window in frontToBackWindows) {
 		if (window.windowLevel == UIWindowLevelNormal) {
 			currentWindow = window;
 			break;
 		}
 	}
 }

 if (self.superview != currentWindow) {
 	[self addToView:currentWindow];
 }
}

Do you agree? Can I make a new commit with these modifications so you can check that everything works correctly?

ah! yep.

I think doing the for through all views is better instead of [[UIApplication sharedApplication].windows objectAtIndex:0] but I will put a new commit with my code above so you will be able to test it and validate that it works, okay for you?

[[UIApplication sharedApplication].windows objectAtIndex:0] is topview.. ok wayne! both works! great.

Great!
@foffux: can you confirm this works for you too?
I will merge it to develop and make a new cocoa pods version tomorrow night ;)

Hello
I can test if today in the afternoon.
Can you tell what exactly I have to take it to test the state of art?
Thank you
Inviato da iPhone

Il giorno 03/mar/2015, alle ore 09:52, Kevin Hirsch<EMAIL_ADDRESS>ha scritto:
Great!
@foffux: can you confirm this works for you too?
I will merge it to develop and make a new cocoa pods version tomorrow night ;)
—
Reply to this email directly or view it on GitHub.

@foffux: You just have to pull the invisible-hud branch and change the source file KVNProgress.m in your project by the one from invisible-hud branch and test ;)

Hello
I was testing your latest fixes.
It is not simple to explain, but the very latest fix (6139b95) I do not think is a good fix for every situation. In particular, I can see in some situation that the HUD is first shown but suddenly it disappears and it is not good at all. But in some other situation this does not happen.
In my opinion this could happen when another view is shown in the same time (at about) or immediately after, like alert view or ADS.
Instead, with just this fix and without the latest one:
// Fix for non autolayout project
self.frame = superview.bounds;

I can see everything is okay. Tomorrow I will make some other tests. But could you please explain me the latest fix (6139b95) and think about what I told about other view shown (alert, ADS), and also think about do not commit fix 6139b95 but just the line of code I highlighted above?
Thank you very much.
P.S.
But after HUD is dismissed, is current window status reestablished as it was before? Because when also ADS is displayed in my opinion something mess up the current window status and after HUD is dismissed ADS, for example, cannot be show at least until a new banner is loaded.
This is what I have seen, I tell you just to add some more information.

Hello @foffux,
You are right, I think that displaying UIAlertView is adding a UIWindow with the alert view inside and this window is set as the keyWindow with a window.windowLevel == UIWindowLevelAlert.
So displaying KVNProgress too quick after displaying an alert view is adding the HUD to the alert view window and this is not correct.
@justvanbloom: I'm wondering, where do you call KVNProgress in your code? How is it possible that
NSEnumerator *frontToBackWindows = [[[UIApplication sharedApplication] windows] reverseObjectEnumerator];

for (UIWindow *window in frontToBackWindows) {
	if (window.windowLevel == UIWindowLevelNormal) {
		currentWindow = window;
		break;
	}
 }

is not working for you and that your logs prints ===== ADDING TO SUPERVIEW: ; layer = > like ; layer = > was a view not set where the layer equals nothing.
What I have in the log looks like this: ===== ADDING TO SUPERVIEW: <UIWindow: 0x7fad40c997e0; frame = (0 0; 375 667); gestureRecognizers = <NSArray: 0x7fad40c9a170>; layer = <UIWindowLayer: 0x7fad40c96a10>>

Hello Kevin.
So, your advice, if I can understand, is to keep all your current fixes in
invisible-hud and pay attention to not call KVNProgress too quick when
alert view is still present. Am I right?
I will try it, hoping to solve my problems.
I will let you know as soon as possible.
Thank you.
2015-03-04 23:30 GMT+01:00 Kevin Hirsch<EMAIL_ADDRESS>
Hello @foffux https://github.com/foffux,
You are right, I think that displaying UIAlertView is adding a UIWindow
with the alert view inside and this window is set as the keyWindow with a window.windowLevel
== UIWindowLevelAlert.
So displaying KVNProgress too quick after displaying an alert view is
adding the HUD to the alert view window and this is not correct.
@justvanbloom https://github.com/justvanbloom: I'm wondering, where do
you call KVNProgress in your code? How is it possible that
NSEnumerator *frontToBackWindows = [[[UIApplication sharedApplication] windows] reverseObjectEnumerator];
for (UIWindow *window in frontToBackWindows) {
if (window.windowLevel == UIWindowLevelNormal) {
currentWindow = window;
break;
}
}
is not working for you and that your logs prints ===== ADDING TO
SUPERVIEW: ; layer = > like ; layer = > was a view not set where the layer
equals nothing.
What I have in the log looks like this: ===== ADDING TO SUPERVIEW:
<UIWindow: 0x7fad40c997e0; frame = (0 0; 375 667); gestureRecognizers =
<NSArray: 0x7fad40c9a170>; layer = <UIWindowLayer: 0x7fad40c96a10>>
—
Reply to this email directly or view it on GitHub
https://github.com/kevin-hirsch/KVNProgress/issues/29#issuecomment-77264548
.

@foffux, what I am saying is that I think I should undo commit 6139b95 because it is indeed messing with alert views but I want to be sure to resolve @justvanbloom's problem who needs commit 6139b95.
@justvanbloom, any news for my comment above?

Ah okay kevin. But then, we have not solved the main problem yet because even if I told you with just the fix related to setting bounds it è was disappeared, in fact this is not true because unfortunately I can see the same issue with the same debug traces dispyed. So do we need to restart   the chase?
Let me know guys.
Inviato da iPhone

Il giorno 05/mar/2015, alle ore 18:26, Kevin Hirsch<EMAIL_ADDRESS>ha scritto:
@foffux, what I am saying is that I think I should undo commit 6139b95 because it is indeed messing with alert views but I want to be sure to resolve @justvanbloom's problem who needs commit 6139b95.
@justvanbloom, any news for my comment above?
—
Reply to this email directly or view it on GitHub.

Weil, besides my fix worked for fullscreen. I'll make later a fix for controller in uiview als kevin mantione my pull request wont fix this.
Stay tuned.
Von meinem iPhone gesendet

Am 06.03.2015 um 07:39 schrieb foffux<EMAIL_ADDRESS>Ah okay kevin. But then, we have not solved the main problem yet because even if I told you with just the fix related to setting bounds it è was disappeared, in fact this is not true because unfortunately I can see the same issue with the same debug traces dispyed. So do we need to restart the chase?
Let me know guys.
Inviato da iPhone

Il giorno 05/mar/2015, alle ore 18:26, Kevin Hirsch<EMAIL_ADDRESS>ha scritto:
@foffux, what I am saying is that I think I should undo commit 6139b95 because it is indeed messing with alert views but I want to be sure to resolve @justvanbloom's problem who needs commit 6139b95.
@justvanbloom, any news for my comment above?
—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub.

@foffux: If you still have the problem, can you put here the logs you have in your console please?

Hello Kevin.
I tested more in depth my app. Here you are my conclusions.
All fixes you did in
 invisible-hud

are good because now I can see HUD in almost every scenarios with good logs. Take a look below:
 2015-03-16 12:00:10.917 Angel[3432:116073] ===== SHOWING HUD
2015-03-16 12:00:10.918 Angel[3432:116073] ===== ADDING TO SUPERVIEW: <UIWindow: 0x7a76d600; frame = (0 0; 320 480); autoresize = W+H; gestureRecognizers = <NSArray: 0x7a76de10>; layer = <UIWindowLayer: 0x7a76d7b0>>
2015-03-16 12:00:10.918 Angel[3432:116073] = superview bounds: {{0, 0}, {320, 480}}
2015-03-16 12:00:10.919 Angel[3432:116073] ===== FINISH ADDING TO SUPERVIEW: <UIWindow: 0x7a76d600; frame = (0 0; 320 480); autoresize = W+H; gestureRecognizers = <NSArray: 0x7a76de10>; layer = <UIWindowLayer: 0x7a76d7b0>>
2015-03-16 12:00:10.920 Angel[3432:116073] ==== SETTING UI
2015-03-16 12:00:10.920 Angel[3432:116073] ===== SETTING BASE CONSTRAINTS
2015-03-16 12:00:10.920 Angel[3432:116073] = bounds: {{0, 0}, {320, 480}}
2015-03-16 12:00:10.920 Angel[3432:116073] = statusInset: 10.000000
2015-03-16 12:00:10.920 Angel[3432:116073] = fullScreen: 0
2015-03-16 12:00:10.921 Angel[3432:116073] = contentWidth: 270.000000
2015-03-16 12:00:10.921 Angel[3432:116073] ===== FINISH SETTING BASE CONSTRAINTS
2015-03-16 12:00:11.084 Angel[3432:116073] ===== UPDATING BACKGROUND CONSTRAINTS
2015-03-16 12:00:11.084 Angel[3432:116073] = fullScreen: 0
2015-03-16 12:00:11.085 Angel[3432:116073] = status: Lotteria...
2015-03-16 12:00:11.085 Angel[3432:116073] = contentViewWidth: 270.000000
2015-03-16 12:00:11.085 Angel[3432:116073] ===== FINISH UPDATING BACKGROUND CONSTRAINTS
2015-03-16 12:00:11.085 Angel[3432:116073] ==== FINISH SETTING UI
2015-03-16 12:00:11.085 Angel[3432:116073] ===== FINISH SHOWING HUD
2015-03-16 12:00:11.086 Angel[3432:116073] sendingDataToServer
2015-03-16 12:00:11.545 Angel[3432:116073] ===== SHOWING HUD
2015-03-16 12:00:11.856 Angel[3432:116073] ===== SHOWING HUD
2015-03-16 12:00:11.856 Angel[3432:116073] ==== SETTING UI
2015-03-16 12:00:11.857 Angel[3432:116073] ===== SETTING BASE CONSTRAINTS
2015-03-16 12:00:11.857 Angel[3432:116073] = bounds: {{0, 0}, {320, 480}}
2015-03-16 12:00:11.857 Angel[3432:116073] = statusInset: 10.000000
2015-03-16 12:00:11.857 Angel[3432:116073] = fullScreen: 0
2015-03-16 12:00:11.858 Angel[3432:116073] = contentWidth: 270.000000
2015-03-16 12:00:11.858 Angel[3432:116073] ===== FINISH SETTING BASE CONSTRAINTS
2015-03-16 12:00:11.859 Angel[3432:116073] ==== FINISH SETTING UI
2015-03-16 12:00:11.860 Angel[3432:116073] ===== FINISH SHOWING HUD
2015-03-16 12:00:14.039 Angel[3432:116073] ==== DISMISSING HUD
2015-03-16 12:00:14.444 Angel[3432:116073] ==== FINISH DISMISSING HUD

There is just a scenario where I can see problems, but I do not think related to same issue. This scenario is when I launch HUD after tapping an alert button. In this scenario the bad thing is that the HUD suddenly disappear before it had to. But also in this case your logs are good, take a look (iOS 8):
 2015-03-16 12:06:06.095 Angel[4795:151930] ===== SHOWING HUD
2015-03-16 12:06:10.165 Angel[4795:151930] ===== ADDING TO SUPERVIEW: <_UIAlertControllerShimPresenterWindow: 0x7c98d6a0; frame = (0 0; 320 480); opaque = NO; autoresize = W+H; gestureRecognizers = <NSArray: 0x7c9c3d30>; layer = <UIWindowLayer: 0x78f0c950>>
2015-03-16 12:06:10.166 Angel[4795:151930] = superview bounds: {{0, 0}, {320, 480}}
2015-03-16 12:06:10.167 Angel[4795:151930] ===== FINISH ADDING TO SUPERVIEW: <_UIAlertControllerShimPresenterWindow: 0x7c98d6a0; frame = (0 0; 320 480); opaque = NO; autoresize = W+H; gestureRecognizers = <NSArray: 0x7c9c3d30>; layer = <UIWindowLayer: 0x78f0c950>>
2015-03-16 12:06:10.167 Angel[4795:151930] ==== SETTING UI
2015-03-16 12:06:10.168 Angel[4795:151930] ===== SETTING BASE CONSTRAINTS
2015-03-16 12:06:10.168 Angel[4795:151930] = bounds: {{0, 0}, {320, 480}}
2015-03-16 12:06:10.168 Angel[4795:151930] = statusInset: 10.000000
2015-03-16 12:06:10.168 Angel[4795:151930] = fullScreen: 0
2015-03-16 12:06:10.168 Angel[4795:151930] = contentWidth: 270.000000
2015-03-16 12:06:10.169 Angel[4795:151930] ===== FINISH SETTING BASE CONSTRAINTS
2015-03-16 12:06:10.294 Angel[4795:151930] ===== UPDATING BACKGROUND CONSTRAINTS
2015-03-16 12:06:10.294 Angel[4795:151930] = fullScreen: 0
2015-03-16 12:06:10.294 Angel[4795:151930] = status: Lotteria...
2015-03-16 12:06:10.295 Angel[4795:151930] = contentViewWidth: 270.000000
2015-03-16 12:06:10.295 Angel[4795:151930] ===== FINISH UPDATING BACKGROUND CONSTRAINTS
2015-03-16 12:06:10.295 Angel[4795:151930] ==== FINISH SETTING UI
2015-03-16 12:06:10.295 Angel[4795:151930] ===== FINISH SHOWING HUD
2015-03-16 12:06:10.295 Angel[4795:151930] sendingDataToServer
2015-03-16 12:06:10.746 Angel[4795:151930] ===== SHOWING HUD
2015-03-16 12:06:11.073 Angel[4795:151930] ===== SHOWING HUD
2015-03-16 12:06:11.074 Angel[4795:151930] ==== SETTING UI
2015-03-16 12:06:11.074 Angel[4795:151930] ===== SETTING BASE CONSTRAINTS
2015-03-16 12:06:11.074 Angel[4795:151930] = bounds: {{0, 0}, {320, 480}}
2015-03-16 12:06:11.074 Angel[4795:151930] = statusInset: 10.000000
2015-03-16 12:06:11.075 Angel[4795:151930] = fullScreen: 0
2015-03-16 12:06:11.075 Angel[4795:151930] = contentWidth: 270.000000
2015-03-16 12:06:11.075 Angel[4795:151930] ===== FINISH SETTING BASE CONSTRAINTS
2015-03-16 12:06:11.075 Angel[4795:151930] ==== FINISH SETTING UI
2015-03-16 12:06:11.076 Angel[4795:151930] ===== FINISH SHOWING HUD
2015-03-16 12:06:13.275 Angel[4795:151930] ==== DISMISSING HUD
2015-03-16 12:06:13.677 Angel[4795:151930] ==== FINISH DISMISSING HUD

In iOS 7, instead:
2015-03-16 12:00:09.272 Angel[5146:60b] ===== SHOWING HUD
2015-03-16 12:00:09.273 Angel[5146:60b] ===== ADDING TO SUPERVIEW: <_UIModalItemHostingWindow: 0x7b6de790; frame = (0 0; 320 480); gestureRecognizers = <NSArray: 0x7b6dec90>; layer = <UIWindowLayer: 0x7b6de910>>
2015-03-16 12:00:09.273 Angel[5146:60b] = superview bounds: {{0, 0}, {320, 480}}
2015-03-16 12:00:09.276 Angel[5146:60b] ===== FINISH ADDING TO SUPERVIEW: <_UIModalItemHostingWindow: 0x7b6de790; frame = (0 0; 320 480); autoresize = W+H; gestureRecognizers = <NSArray: 0x7b6dec90>; layer = <UIWindowLayer: 0x7b6de910>>
2015-03-16 12:00:09.277 Angel[5146:60b] ==== SETTING UI
2015-03-16 12:00:09.277 Angel[5146:60b] ===== SETTING BASE CONSTRAINTS
2015-03-16 12:00:09.278 Angel[5146:60b] = bounds: {{0, 0}, {320, 480}}
2015-03-16 12:00:09.278 Angel[5146:60b] = statusInset: 10.000000
2015-03-16 12:00:09.279 Angel[5146:60b] = fullScreen: 0
2015-03-16 12:00:09.279 Angel[5146:60b] = contentWidth: 270.000000
2015-03-16 12:00:09.279 Angel[5146:60b] ===== FINISH SETTING BASE CONSTRAINTS
2015-03-16 12:00:09.361 Angel[5146:60b] ===== UPDATING BACKGROUND CONSTRAINTS
2015-03-16 12:00:09.361 Angel[5146:60b] = fullScreen: 0
2015-03-16 12:00:09.362 Angel[5146:60b] = status: Lotteria...
2015-03-16 12:00:09.362 Angel[5146:60b] = contentViewWidth: 270.000000
2015-03-16 12:00:09.362 Angel[5146:60b] ===== FINISH UPDATING BACKGROUND CONSTRAINTS
2015-03-16 12:00:09.362 Angel[5146:60b] ==== FINISH SETTING UI
2015-03-16 12:00:09.362 Angel[5146:60b] ===== FINISH SHOWING HUD
2015-03-16 12:00:09.363 Angel[5146:60b] sendingDataToServer
2015-03-16 12:00:12.995 Angel[5146:60b] MOPUB: MoPub HTML banner did load
2015-03-16 12:00:13.053 Angel[5146:60b] ===== SHOWING HUD

I do not see anything wrong. Do you agree? I thought it could be caused by the fact that I was not updated my alert view to new alert view controller, but it happened also in iOS 7...
In my opinion, you could merge what you did in the master (also with my pull request) and from that, we can start to analyze also this problem. Certainly, latest code is much more usable than before and even if there is this kind of problem is not a big issue, at least at the moment.
This is what I think.
What do you think? @kevin-hirsch, @justvanbloom: do you agree?

@foffux, everything seems great except for the window the KVNProgress is added on, on iOS 8:
_UIAlertControllerShimPresenterWindow

and on iOS 7:
_UIModalItemHostingWindow

Do you have the same logs with the same windows without code from commit 6139b95?
Also, when are you calling KVNProgress after a UIAlertView: alertView:clickedButtonAtIndex: or alertView:willDismissWithButtonIndex:?
You should call it in the alertView:didDismissWithButtonIndex: to be sure your alert is completely dismissed before showing KVNProgress ;)

Yes yes yes yes
You definitively did it!!!
My terrible mistake on uialert view. Now launching hud after dismiss,
everything works like a charm.
Take a look at attached files.
I think you can close this issue and also merge invisible-hud branch,
without traces. Also my old pull request, so that I can get the same
current and working environment.
Thank you so much.
Inviato da iPhone
Il giorno 06/mar/2015, alle ore 18:46, Kevin Hirsch <
<EMAIL_ADDRESS>ha scritto:
@foffux https://github.com/foffux, everything seems great except for the
window the KVNProgress is added on, on iOS 8:
_UIAlertControllerShimPresenterWindow
and on iOS 7:
_UIModalItemHostingWindow
Do you have the same logs with the same windows without code from commit
6139b95
https://github.com/kevin-hirsch/KVNProgress/commit/6139b95ee691abe68f07718c3c29b3f6b9db1b8f
?
Also, when are you calling KVNProgress after a UIAlertView:
alertView:clickedButtonAtIndex: or alertView:willDismissWithButtonIndex:?
You should call it in the alertView:didDismissWithButtonIndex: to be sure
your alert is completely dismissed before showing KVNProgress ;)
—
Reply to this email directly or view it on GitHub
https://github.com/kevin-hirsch/KVNProgress/issues/29#issuecomment-77602300
.

@foffux: Great! I'm glad it fixes your problem :)
I will merge invisible-hud tommorow and create a new pod version ;)
You are talking about your old pull request, which one is it and what do you want me to do?

Okay perfect. I will be waiting for it.
Just talking about that pull that let you choose the alpha background tint color value, but I think you have already merge it. Am I right?
Thank you for everything.
Inviato da iPad

Il giorno 07/mar/2015, alle ore 20:05, Kevin Hirsch<EMAIL_ADDRESS>ha scritto:
@foffux: Great! I'm glad it fixes your problem :)
I will merge invisible-hud tommorow and create a new pod version ;)
You are talking about your old pull request, which one is it and what do you want me to do?
—
Reply to this email directly or view it on GitHub.

Yes I have merged it already, good idea by the way! :+1:


update readme with new vegetarian rule

Testing out the new git-democracy changes that should start a new vote if the PR is modified.

Testing vote comment update on closing PR.

Testing update PR with new comment and having it reflect the 1 vote in the last vote when closing it.

It worked!


[Flutter 2]: Maybe there's something wrong with Flutter's accessibility code

Logs
Fatal Exception: java.lang.StackOverflowError: stack size 8MB
       at java.lang.reflect.Method.invoke(Method.java)
       at io.flutter.view.AccessibilityViewEmbedder$ReflectionAccessors.getChildId(AccessibilityViewEmbedder.java:532)
       at io.flutter.view.AccessibilityViewEmbedder$ReflectionAccessors.access$500(AccessibilityViewEmbedder.java:429)
       at io.flutter.view.AccessibilityViewEmbedder.addChildrenToFlutterNode(AccessibilityViewEmbedder.java:171)
       at io.flutter.view.AccessibilityViewEmbedder.convertToFlutterNode(AccessibilityViewEmbedder.java:145)
       at io.flutter.view.AccessibilityViewEmbedder.getRootNode(AccessibilityViewEmbedder.java:94)
       at io.flutter.view.AccessibilityBridge.createAccessibilityNodeInfo(AccessibilityBridge.java:562)
       at android.view.View.populateVirtualStructure(View.java:9364)
       at android.view.View.populateVirtualStructure(View.java:9367)
       at android.view.View.populateVirtualStructure(View.java:9367)
       at android.view.View.populateVirtualStructure(View.java:9367)
       at android.view.View.populateVirtualStructure(View.java:9367)
       at android.view.View.populateVirtualStructure(View.java:9367)
       at android.view.View.populateVirtualStructure(View.java:9367)
       at android.view.View.populateVirtualStructure(View.java:9367)
       at android.view.View.populateVirtualStructure(View.java:9367)
       at android.view.View.populateVirtualStructure(View.java:9367)
       at android.view.View.populateVirtualStructure(View.java:9367)
       at android.view.View.onProvideVirtualStructureCompat(View.java:8785)
       at android.view.View.onProvideVirtualStructure(View.java:8766)
       at android.view.View.dispatchProvideStructureForAssistOrAutofill(View.java:9432)
       at android.view.View.dispatchProvideStructure(View.java:9379)
       at android.view.ViewGroup.dispatchProvideStructure(ViewGroup.java:3665)
       at android.view.ViewGroup.dispatchProvideStructure(ViewGroup.java:3738)
       at android.view.ViewGroup.dispatchProvideStructure(ViewGroup.java:3738)
       at android.view.ViewGroup.dispatchProvideStructure(ViewGroup.java:3738)
       at android.view.ViewGroup.dispatchProvideStructure(ViewGroup.java:3738)
       at android.app.assist.AssistStructure$WindowNode.<init>(AssistStructure.java:519)
       at android.app.assist.AssistStructure.<init>(AssistStructure.java:2047)
       at android.app.ActivityThread.handleRequestAssistContextExtras(ActivityThread.java:3398)
       at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1911)
       at android.os.Handler.dispatchMessage(Handler.java:106)
       at android.os.Looper.loop(Looper.java:214)
       at android.app.ActivityThread.main(ActivityThread.java:7094)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:494)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:975)

Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel stable, 2.0.4, on Microsoft Windows [Version 10.0.19042.867], locale pt-BR)
[√] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
[√] Chrome - develop for the web
[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.9.3)
[√] Android Studio (version 4.1.0)
[√] VS Code (version 1.55.1)
[√] Connected device (4 available)

• No issues found!

Background:
On a app with ~500k installs, there are 311 crash events affecting 162 users in the last 30 days, after upgrading to Flutter 2.

@JCKodel
The stacktrace is very similar to another open issue, https://github.com/flutter/flutter/issues/38063
Please follow-up there for updates. Closing this as duplicate.
If you disagree, write in comments and I'll reopen it.
Thanks.

@darshankawar I don't use Google Maps in this project, but if you think is related, that's fine.
Nevertheless, here's my pubspec.yaml:
name: meucronogramacapilar
description: Meu Cronograma Capilar
version: 20.2104.0613+2021040613
publish_to: 'none'

environment:
  sdk: ">=2.9.0 <3.0.0"

dependencies:
  flutter:
    sdk: flutter
  flutter_localizations:
    sdk: flutter
  admob_flutter:
    path: ../plugins/admob_flutter-1.0.1
  firebase_auth:
    path: ../plugins/firebase_auth-0.20.1
  dash_chat:
    path: ../plugins/dash_chat-1.1.15
  flutter_foreground_plugin:
    path: ../plugins/flutter_foreground_service_plugin-master
  flutter_local_notifications:
    path: ../plugins/flutter_local_notifications-master/flutter_local_notifications
  zefyr:
    path: ../plugins/zefyr-0.12.0
  before_after: ^2.1.0
  cached_network_image: ^2.5.0
  connectivity: ^2.0.2
  datetime_picker_formfield: ^1.0.0
  device_info: ^1.0.0
  diacritic: ^0.1.1
  dio: ^3.0.10
  firebase_analytics: ^7.0.1
  firebase_auth_web: ^0.3.3
  firebase_core: ^0.7.0
  firebase_crashlytics: ^0.4.0+1
  flutter_alert: ^0.4.0
  flutter_device_type: ^0.3.2
  flutter_email_sender: ^4.0.0
  flutter_facebook_login: ^3.0.0
  flutter_image_compress: ^0.7.0
  flutter_jailbreak_detection: ^1.4.0
  flutter_masked_text: ^0.8.0
  flutter_mobx: ^1.1.0+2
  flutter_speed_dial: ^1.2.5
  flutter_svg: ^0.19.1
  flutter_svprogresshud: ^0.0.6
  google_api_availability: ^2.0.4
  google_sign_in: ^4.5.9
  html: ^0.14.0+4
  image_cropper: ^1.3.1
  image_picker: ^0.6.7+21
  in_app_purchase: ^0.5.1
  intl: ^0.17.0
  jaguar_jwt: ^2.1.6
  json_table: ^1.4.0
  launch_review: ^2.0.0
  material_design_icons_flutter: ^4.0.5855
  mobx: ^1.2.1+4
  package_info: ^0.4.3+2
  path_provider: ^1.6.27
  photo_view: ^0.10.3
  sign_in_with_apple: ^2.5.4
  sqflite: ^1.3.2+2
  sticky_headers: ^0.1.8+1
  table_calendar: ^2.3.3
  timeago: ^2.0.29
  timeago_flutter: ^0.3.0
  timezone: ^0.5.6
  url_launcher: ^5.7.10
  uuid: ^2.2.2
  webview_flutter: ^2.0.2
  youtube_player_flutter: ^7.0.0+7

dev_dependencies:
  build_runner: ^1.10.13
  mobx_codegen: ^1.1.2

dependency_overrides:
  intl: 0.17.0

flutter:
  uses-material-design: true
  assets:
    - assets/svg/
    - assets/images/

@JCKodel
The title of the original issue could be misleading, but if you look at the labels it has, platform-views, accessibility, it should suffice to be a related to yours.


Pressing play sometimes hangs

The Issue
Tried to play a random video. Sits on the "awkward" loading screen indefinitely
Steps to reproduce

Pick a random video you dont already have
Click play
Possibly be on Windows

Expected behaviour
15-20 sec pause followed by streaming
Actual behaviour
load screen hangs indefinitely yet file is downloading in Downloads
If you return to the specific file page after Downloads, it shows as downloading and plays fine
System Configuration

LBRY Daemon version:
LBRY App version:
LBRY Installation ID:
Operating system:
Win 10

Anything Else

Screenshots

@finer9 this should be in the lbry-app repo. Moving it there: https://github.com/lbryio/lbry-app/issues/181


feat: add minorUnitToMajorUnitOffset to realtime price query/subscription

~currencyUnit now is an Enum (default is MINOR but adds the option to include/return MAJOR based on a param)~
Add minorUnitToMajorUnitOffset to realtimePrice query and subscriptions

closed in favor of https://github.com/GaloyMoney/galoy/pull/2439/


Generalize the JSON perf tests to Codable

@swift-ci please benchmark

Build comment file:
Build failed before running benchmark.

@swift-ci please smoke benchmark

@swift-ci please smoke benchmark

Build comment file:
Performance: -O

TEST
MIN
MAX
MEAN
MAX_RSS

Added

PlistPerfDecode
630
635
632
—

PlistPerfEncode
590
593
591
—

Performance: -Osize

TEST
OLD
NEW
DELTA
RATIO

Regression

CharacterLiteralsLarge
100
111
+11.0%
0.90x

Added

PlistPerfDecode
639
644
641
—

PlistPerfEncode
587
590
588
—

Performance: -Onone

TEST
MIN
MAX
MEAN
MAX_RSS

Added

PlistPerfDecode
708
712
710
—

PlistPerfEncode
615
620
617
—

✅
Benchmark Check Report

⚠Ⓜ
PlistPerfDecode has very wide range of memory used between independent, repeated measurements.  PlistPerfDecode mem_pages [i1, i2]: min=[143, 151] 𝚫=8 R=[24, 0]

⚠Ⓜ
PlistPerfEncode has very wide range of memory used between independent, repeated measurements.  PlistPerfEncode mem_pages [i1, i2]: min=[1477, 1461] 𝚫=16 R=[50, 20]

How to read the data
The tables contain differences in performance which are larger than 8% and
differences in code size which are larger than 1%.
If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.
Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

--------------

@swift-ci please smoke test and merge

@swift-ci please smoke test and merge

@swift-ci please smoke test and merge

@swift-ci please smoke test and merge

@swift-ci please smoke test and merge

@swift-ci please test and merge

@swift-ci please test and merge

@swift-ci please test and merge

@swift-ci please test and merge

@swift-ci please test and merge


Error: EISDIR: illegal operation on a directory, read

I get the following error when i try to run the jscpd command
Please note I'm running on a mac OS.
`$ cd ios-code/
$ jscpd
info:    jscpd - copy/paste detector for programming source code, developed by Andrey Kucherenko
info:    Preprocessors running time: durationMs=1241
info:    Scanning 3163 files for duplicates...
fs.js:733
var r = binding.read(fd, buffer, offset, length, position);
^
Error: EISDIR: illegal operation on a directory, read
at Error (native)
at Object.fs.readSync (fs.js:733:19)
at tryReadSync (fs.js:488:20)
at Object.fs.readFileSync (fs.js:536:19)
at Strategy.detect (/usr/local/lib/node_modules/jscpd/lib/strategy.js:32:19)
at Detector.start (/usr/local/lib/node_modules/jscpd/lib/detector.js:17:23)
at JsCpd.run (/usr/local/lib/node_modules/jscpd/lib/jscpd.js:45:30)
at Object. (/usr/local/lib/node_modules/jscpd/lib/cli/cli.js:52:11)
at Object.cli.main (/usr/local/lib/node_modules/jscpd/node_modules/cli/cli.js:957:14)
at Object. (/usr/local/lib/node_modules/jscpd/lib/cli/cli.js:47:7)
at Object. (/usr/local/lib/node_modules/jscpd/lib/cli/cli.js:56:4)
at Module._compile (module.js:570:32)
at Object.Module._extensions..js (module.js:579:10)
at Module.load (module.js:487:32)
at tryModuleLoad (module.js:446:12)
at Function.Module._load (module.js:438:3)`

Thank you for reporting, try to use the new version of jscpd with the following command
npx<EMAIL_ADDRESS>
I will investigate the issue and fix if it is possible

I have the same issue. This is because that some folder's name has an ext-like suffix, such as 'normalize.css'. I have made a PR.

hey @kucherenko, it seems like issue is still here:
$ jscpd -v
jscpd v0.6.25

this is how I launch it:
jscpd --path src --languages=css,javascript,jsx --reporter=json --output=report

directory report exists.


Attributes handled through custom C accessors

Hello,
When wrapping a C structure foo, which exposes an attribute bar, one exposes this attribute by defining methods "bar" and "bar=" on the foo-wrapping Ruby class.
To that purpose, rb_define_method() is invoked with VALUE()() and VALUE()(VALUE) C functions for the foo-wrapping class.
yardoc will then display methods bar() and bar=() and not an attribute bar, which is obviously an expected behaviour.
A trick with rdoc is to:

use the :nodoc: decorator on the methods,
add a fake invokation of rb_define_attr() in a C comment.

Unfortunately neither seem handled by yardoc, which won't display an attribute, nor hide the raw methods.
A similar, ideally cleaner :) solution would be much appreciated.
--
Pierre

Hey Pierre, I opted for RDoc's "hack" method of placing the rb_define_attr in a /* */ comment block for now. We will be revisiting this for 0.8.0 though-- there's a good chance we will be refactoring the C parser to create a real AST and go through the handler architecture, because right now CRuby is missing a lot of things pure ruby does, like macro support and other goodies.


【BUG Report】accelerate method remove_hook_from_module can't remove cpu_offload hook.

System Info
First I wanna cpu offloaded model back to cpu.
so i first call the method accelerate.cpu_offload(module, CUDA_0) to offload module to cuda.
then I want my module back to cpu, as i called remove_hook_from_module(module, recurse=True)
and remove method tells me NoneType error.
if tensor_name not in module._parameters and tensor_name not in module._buffers:
AttributeError: 'NoneType' object has no attribute '_parameters'
so i check the code, and found that.

the hook detach method should return changed module. Also I see the Base Hook definition `ModelHook`.

so the only thing is, class AlignDevicesHook not support it well for not return module out.

Information

[ ] The official example scripts
[X] My own modified scripts

Tasks

[ ] One of the scripts in the examples/ folder of Accelerate or an officially supported no_trainer script in the examples folder of the transformers repo (such as run_no_trainer_glue.py)
[ ] My own task or dataset (give details below)

Reproduction

call accelerate.cpu_offload(module, CUDA_0)  to offload some module to cuda
call remove_hook_from_module(module, recurse=True) to remove offload hook.

Expected behavior
detach  hook success.

Thanks for the detailed report @MeJerry215 ! I've created a PR that will solve this bug.


Add Azure Login Extension for virtual machines

Is there an existing issue for this?

[X] I have searched the existing issues

Community Note

Please vote on this issue by adding a :thumbsup: reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description
create the AADLoginExtension for VM's
New or Affected Resource(s
azurerm_virtual_machine_extension
Potential Configuration file
No response
References
No response

hi @schoenr79 this feature should be available with the "generic extension" capability we added,  as exhibited in here:
https://github.com/aztfmod/terraform-azurerm-caf/blob/56c322ba4758824de049992de9b855af96259206/examples/compute/virtual_machine/214-vm-generic_extensions_complex/configurations.tfvars#L46
Please reopen the issue if not working :)


Update/Add Cocoapods

Tool name
Cocoapods
Tool license
MIT
Add or update?

[ ] Add
[X] Update

Desired version
1.16.0
Approximate size
No response
Brief description of tool
No response
URL for tool's homepage
No response
Provide a basic test case to validate the tool's functionality.
No response
Platforms where you need the tool

[ ] Azure DevOps
[ ] GitHub Actions

Runner images where you need the tool

[ ] Ubuntu 20.04
[ ] Ubuntu 22.04
[ ] Ubuntu 24.04
[ ] macOS 12
[ ] macOS 13
[ ] macOS 13 Arm64
[ ] macOS 14
[ ] macOS 14 Arm64
[ ] macOS 15
[ ] macOS 15 Arm64
[ ] Windows Server 2019
[ ] Windows Server 2022

Can this tool be installed during the build?
No response
Tool installation time in runtime
No response
Are you willing to submit a PR?
No response

Hi @cyrilcolinet We will look into this issue.Will keep you posted with updates.

Hi @cyrilcolinet ,
We will begin our weekly deployment for macOS on Monday, and the current CocoaPods version 1.16.1 will be available within 3-4 days after that. Will post an update here once the VM rollout is complete.

Hi team, any update on this? Or any ETA for rollout?
Thanks

Hi @cyrilcolinet , There is a deployment issues and we are working on it. Will update here once VM rollout is complete.

Hi @sureshe456 thanks for update.
Good luck!


InterconnectError when calling manager.remove

ERROR runner{config=Config { crypto_mode: Normal, decode_mode: Decrypt, preallocated_tracks: 1 }}: songbird::driver::tasks::mixer: Mixer thread cycle: InterconnectFailure(Event) thread '<unnamed>' panicked at 'FATAL: No way to rebuild driver core from mixer.: "SendError(..)"', /home/spencer/.cargo/git/checkouts/songbird-bfb5fd0fe254c2b1/f222ce9/src/driver/tasks/mixer.rs:234:22 note: run with RUST_BACKTRACE=1 environment variable to display a backtrace'
I am unsure as to what is causing this error, but it seems to occur everytime i call manager.remove.  It doesn't seem to cause any problems, (that I know of), but regardless, it still exists

I've been seeing it too, I think it's an overzealous (and noisy) panic. It's caused by the core task exiting before the driver -- it should be harmless, but it's annoying to see yes.

Is there a way it can be re-ordered to exit the driver first, or would it be better to just suppress the error


Added describe instance types

I think next step should be to use fixtures system I implemented here https://github.com/spulec/moto/pull/423 ?

thanks!


Add lint "no-deprecated" rule based on @deprecated JSDoc tag

Cross-posting issue from https://github.com/gajus/eslint-plugin-flowtype/issues/367
Not sure if this is best implemented as part of flow, or eslint-plugin-flowtype?

I'd like to add a new lint to https://flow.org/en/docs/linting/rule-reference/
This is similar to the existing tslint rule deprecation:

https://palantir.github.io/tslint/rules/deprecation/
https://github.com/palantir/tslint/issues/825

I'm willing to do the work and submit a PR, if there's any interest in this?

Implementation Goals

[ ] implement lint warning on @deprecated functions/methods

  // @deprecated
  function foo(): void;
  // @deprecated use baz instead
  function bar(): void;
  /**
   * @deprecated see http://example.com/1234
   */
  function baz(): void;

  foo(); // Warning: 'foo' is deprecated.
  bar(); // Warning: 'bar' is deprecated. use baz instead
  baz(); // Warning: 'baz' is deprecated. see http://example.com/1234

[ ] implement lint warning on @deprecated type declarations

  // @deprecated use Foozy in new code.
  type Foo = string;
  type Foozy = 'foo' | 'bar' | 'baz';

  declare var foo: Foo; // Warning: type 'Foo' is deprecated. use Foozy in new code

[ ] implement lint warning on @deprecated modules

  // from misc.js
  /**
   * Collection of misc utility functions
   * @deprecated use `foo` and `bar` modules instead.
   */
  const foo = () => ...;
  const bar = () => ...;
  export default { foo, bar };

  // from `otherFile.js`
  import utils from 'misc'; // Warning: 'misc' is deprecated. use `foo` and `bar` modules instead.

closing issue. I found that import/no-deprecated works well enough for my needs!


[Bug] JetBrains Rider cannot preview SukiWindow

Check the following items

[X] I have looked up relevant Issue

Description of the issue
rt, when I look at the preview window after building, a white window is displayed first, and then the following error appears:
"C:\Program Files\dotnet\dotnet.exe" exec --runtimeconfig D:\Code\CSharp\Test\Test\bin\Debug\net8.0\Test.runtimeconfig.json --depsfile D:\Code\CSharp\Test\Test\bin\Debug\net8.0\Test.deps.json D:\NuGet\packages\avalonia\11.2.0-beta1\buildTransitive\..\tools\netstandard2.0\designer\Avalonia.Designer.HostApp.dll --transport tcp-bson://<IP_ADDRESS>:3972/ --method avalonia-remote D:\Code\CSharp\Test\Test\bin\Debug\net8.0\Test.dll
Initializing application in design mode
Obtaining AppBuilder instance from Test.Program
Sending StartDesignerSessionMessage
Fatal error. System.Runtime.InteropServices.SEHException (0x80004005): External component has thrown an exception.
Repeat 2 times:
--------------------------------
   at SkiaSharp.SkiaApi.sk_canvas_draw_rect(IntPtr, SkiaSharp.SKRect*, IntPtr)
--------------------------------
   at SkiaSharp.SKCanvas.DrawRect(SkiaSharp.SKRect, SkiaSharp.SKPaint)
   at SukiUI.Utilities.Effects.EffectBackgroundDraw.Render(SkiaSharp.SKCanvas, SkiaSharp.SKRect)
   at SukiUI.Utilities.Effects.EffectDrawBase.Render(Avalonia.Media.ImmediateDrawingContext)
   at Avalonia.Rendering.Composition.Drawing.Nodes.RenderDataCustomNode.Invoke(Avalonia.Rendering.Composition.Drawing.Nodes.RenderDataNodeRenderContext ByRef)
   at Avalonia.Rendering.Composition.Drawing.ServerCompositionRenderData.Render(Avalonia.Platform.IDrawingContextImpl)
   at Avalonia.Rendering.Composition.Server.ServerCompositionDrawListVisual.RenderCore(Avalonia.Rendering.Composition.Server.ServerVisualRenderContext, Avalonia.Platform.LtrbRect)
   at Avalonia.Rendering.Composition.Server.ServerCompositionVisual.Render(Avalonia.Rendering.Composition.Server.ServerVisualRenderContext, System.Nullable`1<Avalonia.Platform.LtrbRect>)
   at Avalonia.Rendering.Composition.Server.ServerCompositionContainerVisual.RenderCore(Avalonia.Rendering.Composition.Server.ServerVisualRenderContext, Avalonia.Platform.LtrbRect)
   at Avalonia.Rendering.Composition.Server.ServerCompositionDrawListVisual.RenderCore(Avalonia.Rendering.Composition.Server.ServerVisualRenderContext, Avalonia.Platform.LtrbRect)
   at Avalonia.Rendering.Composition.Server.ServerCompositionVisual.Render(Avalonia.Rendering.Composition.Server.ServerVisualRenderContext, System.Nullable`1<Avalonia.Platform.LtrbRect>)
   at Avalonia.Rendering.Composition.Server.ServerCompositionContainerVisual.RenderCore(Avalonia.Rendering.Composition.Server.ServerVisualRenderContext, Avalonia.Platform.LtrbRect)
   at Avalonia.Rendering.Composition.Server.ServerCompositionDrawListVisual.RenderCore(Avalonia.Rendering.Composition.Server.ServerVisualRenderContext, Avalonia.Platform.LtrbRect)
   at Avalonia.Rendering.Composition.Server.ServerCompositionVisual.Render(Avalonia.Rendering.Composition.Server.ServerVisualRenderContext, System.Nullable`1<Avalonia.Platform.LtrbRect>)
   at Avalonia.Rendering.Composition.Server.ServerCompositionContainerVisual.RenderCore(Avalonia.Rendering.Composition.Server.ServerVisualRenderContext, Avalonia.Platform.LtrbRect)
   at Avalonia.Rendering.Composition.Server.ServerCompositionDrawListVisual.RenderCore(Avalonia.Rendering.Composition.Server.ServerVisualRenderContext, Avalonia.Platform.LtrbRect)
   at Avalonia.Controls.CompositionBorderVisual+ServerBorderVisual.RenderCore(Avalonia.Rendering.Composition.Server.ServerVisualRenderContext, Avalonia.Platform.LtrbRect)
   at Avalonia.Rendering.Composition.Server.ServerCompositionVisual.Render(Avalonia.Rendering.Composition.Server.ServerVisualRenderContext, System.Nullable`1<Avalonia.Platform.LtrbRect>)
   at Avalonia.Rendering.Composition.Server.ServerCompositionContainerVisual.RenderCore(Avalonia.Rendering.Composition.Server.ServerVisualRenderContext, Avalonia.Platform.LtrbRect)
   at Avalonia.Rendering.Composition.Server.ServerCompositionDrawListVisual.RenderCore(Avalonia.Rendering.Composition.Server.ServerVisualRenderContext, Avalonia.Platform.LtrbRect)
   at Avalonia.Rendering.Composition.Server.ServerCompositionVisual.Render(Avalonia.Rendering.Composition.Server.ServerVisualRenderContext, System.Nullable`1<Avalonia.Platform.LtrbRect>)
   at Avalonia.Rendering.Composition.Server.ServerCompositionTarget.RenderRootToContextWithClip(Avalonia.Platform.IDrawingContextImpl, Avalonia.Rendering.Composition.Server.ServerCompositionVisual)
   at Avalonia.Rendering.Composition.Server.ServerCompositionTarget.Render()
   at Avalonia.Rendering.Composition.Server.ServerCompositor.RenderCore(Boolean)
   at Avalonia.Rendering.Composition.Server.ServerCompositor.RenderReentrancySafe(Boolean)
   at Avalonia.Rendering.Composition.Server.ServerCompositor.Render(Boolean)
   at Avalonia.Media.MediaContext.SyncCommit(Avalonia.Rendering.Composition.Compositor, Boolean, Boolean)
   at Avalonia.Media.MediaContext.ImmediateRenderRequested(Avalonia.Rendering.Composition.CompositionTarget, Boolean)
   at Avalonia.Rendering.Composition.CompositingRenderer.Paint(Avalonia.Rect, Boolean)
   at Avalonia.Rendering.Composition.CompositingRenderer.Paint(Avalonia.Rect)
   at Avalonia.Controls.TopLevel.HandlePaint(Avalonia.Rect)
   at Avalonia.Controls.Remote.Server.RemoteServerTopLevelImpl.RenderAndSendFrameIfNeeded()
   at Avalonia.DesignerSupport.Remote.PreviewerWindowImpl.Resize(Avalonia.Size, Avalonia.Controls.WindowResizeReason)
   at Avalonia.Controls.Window.ArrangeSetBounds(Avalonia.Size)
   at Avalonia.Controls.WindowBase.ArrangeCore(Avalonia.Rect)
   at Avalonia.Layout.Layoutable.Arrange(Avalonia.Rect)
   at Avalonia.Layout.LayoutManager.Arrange(Avalonia.Layout.Layoutable)
   at Avalonia.Layout.LayoutManager.Arrange(Avalonia.Layout.Layoutable)
   at Avalonia.Layout.LayoutManager.Arrange(Avalonia.Layout.Layoutable)
   at Avalonia.Layout.LayoutManager.Arrange(Avalonia.Layout.Layoutable)
   at Avalonia.Layout.LayoutManager.Arrange(Avalonia.Layout.Layoutable)
   at Avalonia.Layout.LayoutManager.Arrange(Avalonia.Layout.Layoutable)
   at Avalonia.Layout.LayoutManager.Arrange(Avalonia.Layout.Layoutable)
   at Avalonia.Layout.LayoutManager.Arrange(Avalonia.Layout.Layoutable)
   at Avalonia.Layout.LayoutManager.ExecuteArrangePass()
   at Avalonia.Layout.LayoutManager.InnerLayoutPass()
   at Avalonia.Layout.LayoutManager.ExecuteLayoutPass()
   at Avalonia.Layout.LayoutManager.ExecuteQueuedLayoutPass()
   at Avalonia.Media.MediaContext.FireInvokeOnRenderCallbacks()
   at Avalonia.Media.MediaContext.RenderCore()
   at Avalonia.Media.MediaContext.Render()
   at Avalonia.Threading.DispatcherOperation.InvokeCore()
   at Avalonia.Threading.DispatcherOperation.Execute()
   at Avalonia.Threading.Dispatcher.ExecuteJob(Avalonia.Threading.DispatcherOperation)
   at Avalonia.Threading.Dispatcher.ExecuteJobsCore(Boolean)
   at Avalonia.Threading.Dispatcher.Signaled()
   at Avalonia.Controls.Platform.ManagedDispatcherImpl.RunLoop(System.Threading.CancellationToken)
   at Avalonia.Threading.DispatcherFrame.Run(Avalonia.Threading.IControlledDispatcherImpl)
   at Avalonia.Threading.Dispatcher.PushFrame(Avalonia.Threading.DispatcherFrame)
   at Avalonia.Threading.Dispatcher.MainLoop(System.Threading.CancellationToken)
   at Avalonia.DesignerSupport.Remote.RemoteDesignerEntryPoint.Main(System.String[])
   at Avalonia.Designer.HostApp.Program.Main(System.String[])
Process terminated with exit code -1,073,741,795

Package Version
6.0.0-beta8
Environment
Windows 11 22631
Expected Behavior
SukiWindow can be previewed using Rider IDE
Reproduction
Use Rider IDE, follow the documentation to install SukiUI, and see the preview of MainWindow
Additional Information
No response

This is a limitation of Rider's (already quite flawed) XAML previewer. It never worked particularly well for WPF, subsequently it works even less competently for Avalonia. In this case it's because we use some Skia APIs for rendering and the previewer doesn't seem to support them.
It's not something we're in a position to fix unfortunately, my only advice would be to avoid using the previewers for any SukiWindow.

Just thought I'd quickly follow up, I'd like to know if this happens in VS too. Rider's AXAML previewer is actually part of a 3rd party plugin so if that's the source of the issue I'd like to chase that up rather than trying to implement workarounds on our end.

I fail on the same code pathway in VS using SukiUI.Demo

I just downloaded Visual Studio 2022 Community to try it out and it also doesn't work for SukiWindow
Avalonia=11.2.0-beta1
SukiUI=6.0.0-beta8

Excellent. I'll get a minimal repro together and push this up to Avalonia. If this isn't something they can or want to fix then we have some scope to implement workarounds if they're necessary (though I'd rather not) or in the worst case document this issue clearly.

Looks like this is by design and in fact platforms such as web do actually require software rendering fallbacks.
I'll take a look at this tomorrow, hopefully I can put together a gracefull fallback that will allow the previewer to work and open up the opportunity to support web possibly in the future as well as apparently Linux/MacOS VM's which tend to fall back to software rendering.

doesn't work for     <sukiUi:SukiSideMenu>         <sukiUi:SukiSideMenu.HeaderContent>         </sukiUi:SukiSideMenu.HeaderContent>     </sukiUi:SukiSideMenu>


Broken on latest VRChat builds

Hello, This dll is broken on the most recent builds of VRChat, it only displays "Auto Hook" and nothing else alongside it.
There are no options to force clone anyone in the game.
I downloaded MelonLoader as well, but it didn't make any difference, just says "Auto hook"

There is not anymore a button to force clone the avatars, you can just now clone them as you normally would, if you prefer the old method please use version 1.0.9.


Plugins broken in snap version

Hi! For the moment the plugins do not work on the snap version (tested on ubuntu 22.04). Are there plans to fix this in the next build?

Thank you for your work Vlad !

Hi,
seems it doesn't work for me, no change with the new build. Did I miss something ?
`Copyright (C) 2009-2100  C o r o n a   L a b s   I n c .
Version: 3.0.0
Build: 2100.9999
WARNING: Cannot create path for resource file 'resource.car (/snap/solar2d/9/usr/local/bin/Solar2D/Resources/resource.car)'. File does not exist.
Loading project from: /home/me/Bureau/mySolarApp
Project sandbox folder: /home/me/snap/solar2d/9/.Solar2D/Sandbox/mySolarApp
ERROR: Runtime error
/root/parts/solar2d/src/platform/resources/init.lua:931: module 'plugin_utf8' not found:
no field package.preload['plugin_utf8']
no file '/home/me/snap/solar2d/9/.Solar2D/Plugins/plugin_utf8.lua'
no file '/home/me/Bureau/mySolarApp/plugin_utf8.lua'
no file '/home/me/Bureau/mySolarApp/plugin_utf8.lua'
no file '/home/me/snap/solar2d/9/.Solar2D/Plugins/plugin_utf8.so'
no file './plugin_utf8.so'
no file '/home/me/Bureau/mySolarApp/plugin_utf8.so'
no file '/home/me/snap/solar2d/9/.Solar2D/Plugins/plugin_utf8.so'
no file './plugin_utf8.so'
no file '/home/me/Bureau/mySolarApp/plugin_utf8.so'
stack traceback:
[C]: in function 'require'
/root/parts/solar2d/src/platform/resources/init.lua:931: in function 'require'
/home/me/Bureau/mySolarApp/main.lua:20: in main chunk`

Try but plug-in please. I don’t think utf8 is built for Linux yet

Ok (currently I got the same result with  openssl, imageCrop, qrscanner and zip plugins)

For now only plugin.bit is built for linux. Hoping utf8 and some others
also will be ready soon.
On Tue, Apr 26, 2022 at 10:30 PM zeed27 @.***> wrote:

Ok (currently I got the same result with openssl, imageCrop, qrscanner and
zip plugins)
—
Reply to this email directly, view it on GitHub
https://github.com/coronalabs/corona/issues/379#issuecomment-1110170720,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABI7FJCUN7LPZD2F6YWJWTLVHA75RANCNFSM5T7VB2WA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Add optional hdfs.confDir config

When graph.hdfs.confDir is passed in, all properties inside of the directory will be returned as part of the hadoop configuration.

LGTM, can you squash. Then you can merge to master.


⚠ AlphaRatio has degraded performance

In 640826a, AlphaRatio ($AR) experienced degraded performance:

HTTP code: 200
Response time: 4770 ms

Resolved: AlphaRatio performance has improved in 1fc7fbe after 6 minutes.


Subtitle remain stucked after loading a new source

Have you read the FAQ and checked for duplicate open issues?:
Yes
What version of Shaka Player are you using?:
2.4.4
Can you reproduce the issue with our latest release version?:
The latest stable yes
Can you reproduce the issue with the latest code from master?:
I didn't tested it
Are you using the demo app or your own custom app?:
demo
If custom app, can you reproduce the issue using our demo app?:
What browser and OS are you using?:
Firefox 62.0
What are the manifest and license server URIs?:
//storage.googleapis.com/shaka-demo-assets/sintel-mp4-only/dash.mpd
What did you do?

go to: https://shaka-player-demo.appspot.com/demo/#asset=//storage.googleapis.com/shaka-demo-assets/sintel-mp4-only/dash.mpd;lang=en-US;play;build=compiled
enable subtitles
seek to 7 minutes 34 seconds
pause
press load button

What did you expect to happen?
I expect the subtitles to be removed when I load a new source (even if it is the same)
What actually happened?
the subtitles shown on the previous video remains for too much time.

Is this what you mean?

On macOS, I am also able to reproduce in Firefox 62. Doesn't happen on Chrome 69.

This looks like a Firefox bug.  https://bugzilla.mozilla.org/show_bug.cgi?id=1491045

Closing this stale external (non-Shaka) issue. If you disagree, please reply with @shaka-bot reopen, and it will be automatically reopened.


[$1000] Chat - Message sent without space but while edit comment a single space is shown

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to https://staging.new.expensify.com/
Tap any report
Enter<EMAIL_ADDRESS>Tap send
Long press the sent message
Tap edit comment

Expected Result:
The user sent message without space<EMAIL_ADDRESS>and so while editing also, the message must be shown without space<EMAIL_ADDRESS>Actual Result:
The user sent message without space<EMAIL_ADDRESS>but while editing, the message is shown with space

<EMAIL_ADDRESS>
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[x] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.56-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/9752547c-1c27-47a1-8930-eebc0368f8a0
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0101564ea93c635e12
Upwork Job ID:<PHONE_NUMBER>841062400
Last Price Increase: 2023-08-22

Proposal
Please re-state the problem that we are trying to solve in this issue.
Quote message was sent without leading space but while editing comment, a single space is shown in the composer.
What is the root cause of that problem?
When we send a quote message, the parser removes all leading spaces.
And when we edit a quote message, htmlToMarkdown function of ExpensiMark class adds a leading space to markdown text.
https://github.com/Expensify/expensify-common/blob/7735de14112a968fd6a4f5af710d2fbaefc8809d/lib/ExpensiMark.js#L314
If we save the updated quote message, the parser removes that appended leading space again.
What changes do you think we should make in order to solve the problem?
If we want to change this, we need to update htmlToMarkdownRules of expensify-common repo by removing a leading space.
const resultString = g2.replace(/\n?(<h1># )/g, '$1')
                        .replace(/(<h1>|<\/h1>)+/g, '\n')
                        .trim()
                        .split('\n')
                        .map(m => `>${m}`)
                        .join('\n');

What alternative solutions did you explore? (Optional)
N/A

I think we should proceed with the proposal from @Krishna2323 - it covers all the scenarios preserving none, one or multiple spaces after the quote sign
The proposal from @akamefi202 is limited: it always show quote without spaces in edit mode, even if there were some spaces originally
🎀 👀 🎀 C+ reviewed

@akamefi202 I think quotes are special case where want to preserve original formatting

okay sooooooo if we choose to fix this, I think @Krishna2323's solution makes sense.
However, I'm not entirely sure it needs to be fixed. For example, Slack also automatically adds a space if there isn't one (it also collapses spaces down, so:

no spaces -> 1 space
1 space -> 1 space
2 spaces -> 2 spaces (1 in the quote, one not visible except on edit)
3 spaces -> 3 spaces (2 in the quote, one not visible except on edit).

I think we might be fine as is, sort of a middle ground - at the very least I think this would end up being a new feature request not a bug. What do you think, @kevinksullivan? Should we just trim/expand to one space?

Yeah it's harder to tell with the live preview. Try changing your preferences (Preferences > Advanced) to "Format messages with markup". That's closer to how ours works since we don't have the preview (yet).

Thanks for breaking this down @dangrous . After your summary I tend to agree, that this is really a new feature rather than a bug. I'm going to close this out.


Pick a Minimum Supported Rust Version

Most Rust projects choose a MSRV and enforce it by doing builds on that version in CI.
Let's pick one or agree that we're all going to upgrade every time a new stable release comes along. Otherwise, we'll hit regular breakages (i.e. #137).

For what it's worth, I really like some of the features that have arrived in recent versions:

Rust 1.51 added const generics, array::IntoIter, and a new cargo feature resolver
Rust 1.50 added Ord::clamp and slice::fill

At some point I added to the README:

Rust 1.48 or later is also required.

So I guess for now 1.48 is it? I still intend to add a test that runs 'cargo check' on 1.48, so I'll leave this open to track that.

Since commit 82725725f, the README says

[Rust] 1.52 or later is also required.

So that's it for now.


Fixed bugs with HCG, added tests

Wow, sorry about absent .gitignore.
You should skip this commit, because it includes node_modules folder, which is not a part of the lib.

I don't know how to update repo in github windows.
I close this pull request.


Add autocomplete to hometown search for onboarding by adding Google Places API

Overview
Added Google Places API so that we can search for cities/state/country
Screenshots (delete if not applicable)

Shanghai
Boston

Closing for now in favor of using Apple Maps


[EN] Feedback for: /web/tools/chrome-devtools/?hl=en

source format button: if it is clicked twice, the content is blank. Is it a bug?

@ianzhengnan are you still seeing this behavior? If so, please open a bug on crbug.com.


ZEPPELIN-852 fixed the fields float outside the box.

What is this PR for?
If added multiple fields in either of keys, groups or values boxes of settings button in results section of a paragraph to plot a graph or any representation, the fields floats outside the box.
What type of PR is it?
[Bug Fix]
Todos
What is the Jira issue?
ZEPPELIN-852
How should this be tested?
Open a notebook and a paragraph.
Run a paragraph with a query providing many columns to be added in any of the box.
Try adding multiple fields and check if it floats outside the box or not.
Screenshots (if appropriate)
Before fix -

After fix -

Questions:

Does the licenses files need update?NO
Is there breaking changes for older versions?NO
Does this needs documentation?NO

LGTM!

Merging this if no more discussion.

LGTM


Flow Renderer: Grid of seed points changes depending on  variable

Changing the number of variables seems to affect the gridded seed distribution.
To reproduce:

Load our current DUKU VDC and create a Flow renderer
In the Seeding tab, reduce the Integration Steps to 10
Enable the renderer and note the 3x3x3 grid of seeds (we should see 5x5x5?)
In the Variables tab, set the V and W variables to "none"
Note that we now see a 5x3x4 grid of seeds (we should see 5x5x5?).

Hey Scott, can you do me a favor to shrink the grid box boundary a bit before step 3, and then see if the seed number change behavior is still there? @sgpearse

@shaomeng sorry I didn't get back to you sooner.  I do still see the 3x3x3 grid of seeds, after reducing the minimum X coordinate of the Box.

@shaomeng sorry I didn't get back to you sooner. I do still see the 3x3x3 grid of seeds, after reducing the minimum X coordinate of the Box.

No worries. Can you try increase the the minimum X, instead of reducing it? In other words, make minimum X, Y, Z a little larger, and maximum X, Y, Z a little smaller?


Export default async function

It seems like that when you export a async function by default:
export default async function somefun(x) { ...
The async keyword is not recognized in this case.
I will try to take a look in the source, but I do not know a lot on vim syntax files. (any resources would be welcome!)
Thanks in advance!

Should work fine


chore: add custom RPC section in chains page (docs)

Changes

Added "Custom RPC" section in chains page to show users how you can specify your own RPC for each chain

@magiziz I think we'd want to move this to Installation instead, maybe with a section under "Additional build tooling setup" like Preparing to deploy. I'd also use Wagmi's Transports language to be more clear, because Custom RPC typically refers to adding a network on the wallet. I think we would want to explain why devs should use a production node like Alchemy or Quicknode there.


[Nav] Menu item height in Settings menu looks kind of random

Screenshot

Description

There should be more space around dividers
There should be space between the bottom and the last menu item

Design input
[describe any input/collaboration you'd like from designers, and
tag accordingly. For design review, add the
label design:review. If this includes a design proposal,
include the label design:suggest]

@ktmud Do you think that looks better? I decreased margin for item group title and increased margin for the last element of item group.

Looks good! Thanks for taking on this.


Some odo functionality does not work with an ARM cluster

An odo binary for ARM is available, however odo not been tested in conjunction with an ARM cluster.  Neither the odo-init container nor the Service Binding Operator are available on ARM, therefore odo functionality dependent thereon will not work with an ARM cluster.

/lifecycle frozen

Service Binding Operator (from Red Hat, not the community version) is now available for ARM, and can be installed through the web console OperatorHub starting with OpenShift Container Platform 4.9.10.


Refactor imagediff and fix regression bug

Fix #30683
Regression of #30140

Where exactly was the bug?

Where exactly was the bug?

https://github.com/go-gitea/gitea/issues/30683#issuecomment-2076469994

Where exactly was the bug?

In the issue's screenshot https://github.com/go-gitea/gitea/issues/30683#issue-2261038989

So the bug was basically a missed ?., right?

So the bug was basically a missed check if a queried element existed?

I think so.


[sival,kmac] chip_sw_kmac_kmac_key_sideload

This commit adds the chip_sw_kmac_kmac_key_sideload test. In this test, a sideloaded key is used in KMAC. The output is stored in retention SRAM, a reset is performed, and it is checked whether the same KMAC output is generated.

Thanks for the review @vogelpi & @engdoreis.


create *.svg icon pack for all supported in Zafira platforms

At the moment we have 14 platform icons:
9 of them are already in *.svg format (safari, chrome, firefox, edge, xbox, ps, ie, android, ios);
5 are still taken from single *.png template (api, appletv, androidtv, tizen, unknown (N/D))

appletv and androidtv both don't use their original logos because it didn't seem possible to squeeze those logos in 20x20 pixels space. So, any other more graceful solution is welcome here (same for api and unknown). At least current version of *.png icons should be converted into vector, and the rest of *.svg ones reviewed for possible improvements.
As a result it would be nice to have a pack of icons in a common style.
Current versions of images are attached below.
platform_icons.zip

_icons_platform.zip


Error when modifying firewall interface attributes on a parent firewall interface with sub-interfaces

def config_comment(fw_obj):
    x = ['ethernet1/1']

    try:
        EthernetInterface.refreshall(fw_obj)
        AggregateInterface.refreshall(fw_obj)
    except PanDeviceError as e:
        print(e.message)

    for interface_name in x:
        if 'ae' in interface_name:
            try:
                target_int = fw_obj.find(interface_name, AggregateInterface)
            except PanDeviceError as e:
                print(e.message)
        elif 'ethernet' in interface_name:
            try:
                target_int = fw_obj.find(interface_name, EthernetInterface)
            except PanDeviceError as e:
                print(e.message)
        else:
            print('Invalid interface {0}'.format(interface_name))

        target_int.comment = 'test comment'

        target_int.apply()

Error:
Traceback (most recent call last):
  File "/home/admin/venvs/auto_venv_py3.6/lib64/python3.6/site-packages/pandevice/base.py", line 3447, in method
    super_method(self, *args, **kwargs)
  File "/home/admin/venvs/auto_venv_py3.6/lib64/python3.6/site-packages/pan/xapi.py", line 741, in set
    self.__type_config('set', query, extra_qs)
  File "/home/admin/venvs/auto_venv_py3.6/lib64/python3.6/site-packages/pan/xapi.py", line 805, in __type_config
    raise PanXapiError(self.status_detail)
pan.xapi.PanXapiError:  interface 'ethernet1/1.2' is already in use

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "enable_lldp.py", line 154, in <module>
    main()
  File "enable_lldp.py", line 151, in main
    config_lldp(firewall, lldp_ints)
  File "enable_lldp.py", line 122, in config_lldp
    target_int.apply()
  File "/home/admin/venvs/auto_venv_py3.6/lib64/python3.6/site-packages/pandevice/base.py", line 3001, in apply
    super(VsysOperations, self).apply()
  File "/home/admin/venvs/auto_venv_py3.6/lib64/python3.6/site-packages/pandevice/base.py", line 561, in apply
    child._check_child_methods("apply")
  File "/home/admin/venvs/auto_venv_py3.6/lib64/python3.6/site-packages/pandevice/base.py", line 518, in _check_child_methods
    getattr(self, "child_"+method)()
  File "/home/admin/venvs/auto_venv_py3.6/lib64/python3.6/site-packages/pandevice/base.py", line 3012, in child_apply
    return self._create_apply_child()
  File "/home/admin/venvs/auto_venv_py3.6/lib64/python3.6/site-packages/pandevice/base.py", line 3019, in _create_apply_child
    self.create_import('vsys1')
  File "/home/admin/venvs/auto_venv_py3.6/lib64/python3.6/site-packages/pandevice/base.py", line 3050, in create_import
    device.active().xapi.set(xpath, element, retry_on_peer=True)
  File "/home/admin/venvs/auto_venv_py3.6/lib64/python3.6/site-packages/pandevice/base.py", line 3464, in method
    raise the_exception
pandevice.errors.PanDeviceXapiError:  interface 'ethernet1/1.2' is already in use

Python Module Versions:
pan-python       0.15.0
pandevice        0.11.1

@smatt241
Seems your firewall has multiple vsys.
In the firewall, there are, in general, three places where something could exist:

not in a vsys
in a vsys
not in a vsys directly but imported into a vsys

Interfaces fall into that 3rd category, but they are special in that PAN-OS cannot use an interface unless it's imported into one, so interfaces are always imported.  When you are using pandevice to deal with vsys importables, it imports based on self.vsys, which keeps on checking up the object hierarchy until it hits an object that authoritatively answers, "what vsys does this belong in," which can be set either on the pandevice.firewall.Firewall object itself or a pandevice.device.Vsys object.  So when you call .create() or .apply() on an interface (or any importable), it will first create the thing and then performs the specified vsys import.
In your case, if your intent is not to change the vsys that each (sub)interface is imported into, then you should use fw_obj.organize_info_vsys().  This will do a few queries as to which importables are in which vsys, and re-configure fw_obj's object tree as appropriate.  What I would recommend is to make use of the fact that .refreshall() returns a list of objects found, and to build up a list of both ethernet interfaces and aggregate interfaces that you could then iterate over to update the comment on the interfaces.


Use vector constructor to initialize Array2D.

Current constructor of Array2D calls resize to initialize the inner vector of
Array2D and follows up with a Fill call. This can be replaced with a simple
call to vector constructor. Vector constructor might also be more efficient.

Can one of the admins verify this patch?

@hawkinsp please review.

@hawkinsp Thanks for the review!

@hawkinsp will create a PR for Array3d to address the same issue.

@tensorflow-jenkins Test this please


fix(testing-karma): fixes test coverage reporter

move from karma-coverage-istanbul-reporter to karma-coverage
Closes #1164

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

This would be a breaking change since the coverageIstanbulReporter object in the karma config would now become coverageReporter. There are also a couple of other API changes to this. Since it's hard to figure out the last version of this package that worked, I'm unsure if the output of the coverage reports has regressed, so do let me know if I need to make any changes!

packages/karma-esm/package.json also uses karma-coverage-istanbul-reporter as a devDependency.  I think this is the only package which uses old versions of istanbul libs but it's difficult to know for sure without eliminating that dependency.  This also causes weird hoisting in the monorepo.

This is indeed a breaking change, and commit message should reflect that
Docs should also be updated inline and on the site
Thanks :D

@coreyfarrell addressed the karma-esm package
@bennypowers added in the BREAKING CHANGE message to commit and updated documentation
Let me know if I missed anything else!

Do you think it is at all possible to avoid a breaking change? Specifically, could we carry over the coverage thresholds from the old config?

Do you think it is at all possible to avoid a breaking change? Specifically, could we carry over the coverage thresholds from the old config?

with the same thresholds, it's still a breaking change, unless we copy coverageIstanbulReporter options to coverageReporter options

I'd still like to see this land

My apologies, I've been caught up in actual work work, so haven't had much time to address this. I should have some time this week to make this backwards compatible!

Is this ready to go?

Looks good to me!

I'd love to see this land a.s.a.p. 👍
I'm currently running into issues that my tests are ran twice (or at least reports twice). As far as I can see this change is fixing my issues too.
NOTE:
I noticed it when I add the following pieces of code to one of my test files:
  before(() => console.log('before')); // Will print twice

or...
Object.keys(window.__karma__.files).forEach(file => console.log(file));

This will list all files Karma loads and all files will be listed twice. Removing karma-coverage-istanbul-reporter fixed the duplication, adding karma-coverage did not result in the same duplication as I saw before.

gentle bump *
Any updates?

Rebased the PR, and fixed some linting errors. Sorry this one took so long to get through, we had some discussions within the team about whether we want to do a breaking change to the karma config at this point.


NPM source is different than Github source.

Any reason as to why the code that we get from npm is different than the source found here? If this was a larger library I'd say that's quite misleading as it could contain malicious code that's not easily found.

The one on the npm repository is just an older version. The current code on github needs a little bit of refactoring. As soon as I have time to do that, I'll update the npm packet too.


added nd.ts

I always appreciate emojis in the code!  🏓

Merged, thank you @heyAyushh

Thanks for merging


fix display strings and node choice

Fixes issues:

forcing the placeholder task and the subtasks to run on the same node;
and ensure the subtask display strings are visible in jenkins so we can see which job is claiming the executor.

@wieben @trol73 thanks!


Problem using two component instances on Android

On android, if I put two Youtube components together and try to play one while another ois paused, they dont work and in some seconds the app crashes.

this is un-adressable right now.. I might add a wrapping around this library in the future

I had similar constraints of having multiple youtube players in one screen. The only way to go about this seems to be to use webviews in app. The library mentioned above also seems to use the web player.
I've written a simple wrapper around the webplayer with react-native-webview. You can check it out https://github.com/LonelyCpp/react-native-youtube-iframe :)


excludes should be removed from manifest.yml generated from NewStarterRugProject

Currently the resulting manifest.yml contains an excludes block that shouldn't be there.

This is done.