C++11 support for linux build - needed to compile creature2d module

I've been trying to build godot with support for creature2d. The author of creature 2d has kindly made a module for godot.
it however needs C++11 support. How do I get godot to compile with c++11 support?
https://github.com/kestrelm/Creature_Godot/issues/1
So far I learned that I need to edit the sconstruct file. This however is much too complicated for me. Help much appreciated!

I'm creating a module to integrate a library that uses C++11 features, and I'd like to know as well how to properly ensure it compiles correctly on all platforms.

You don't need to enable it for the whole build, just for your module on
the SCsub, something like this:
module_sources=['file1.cpp', 'file2.cpp']
env_mymodule = env.Clone()
env_mymodule.Append(CXXFLAGS=['--enable-c++11', '-D_SOME_MODULE_DEFINE'])
env_mymodule.add_source_files(env.modules_sources, module_sources)
That will add the compiler flags only to your sources and not to the rest
of the build. Keep in mind that not all compilers use the same flags
obviously (maybe there's a scons option to enable c++11 that is more
portable), the point is whatever you do to that environment won't affect
the rest of the build (which means if you enable or disable the module it
won't trigger a recompile of all the sources, only the ones specifically
affected by your module)
On 29 April 2016 at 22:56, Marc<EMAIL_ADDRESS>wrote:

I'm creating a module to integrate a library that uses C++11 features, and
I'd like to know as well how to properly ensure it compiles correctly on
all platforms.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/godotengine/godot/issues/4490#issuecomment-215923920

@punto-
this is the SCsub file:

SCsub
Import('env')
env.Append(CPPDEFINES=['_USE_MATH_DEFINES'])
env.Append(CPPPATH='#modules/creaturegodot/glm')
env.Append(CPPPATH='#modules/creaturegodot/gason')
env.add_source_files(env.modules_sources,"*.cpp") # just add all cpp files to the build

How do I alter it exactly? I dont have much experience with scons

All of those calls can go in a new env (along with the parameter to enable
c++11), since they don't affect the rest of the build
On 30 April 2016 at 06:22, Todor Imreorov<EMAIL_ADDRESS>wrote:

@punto- https://github.com/punto-
this is the SCsub file:
SCsub
Import('env')
env.Append(CPPDEFINES=['_USE_MATH_DEFINES'])
env.Append(CPPPATH='#modules/creaturegodot/glm')
env.Append(CPPPATH='#modules/creaturegodot/gason')
env.add_source_files(env.modules_sources,"*.cpp") # just add all cpp files
to the build
How do I alter it exactly? I dont have much experience with scons
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/godotengine/godot/issues/4490#issuecomment-215948789

@punto- I can't get it to compile at all. Could you post how you would change his build script so it builds at least?
Getting it to work is more important to me

env_module = env.Clone()
then do to "env_module" everything you do to "env", like in my first
example.
On 30 April 2016 at 06:47, Todor Imreorov<EMAIL_ADDRESS>wrote:

@punto- https://github.com/punto- I can't get it to compile at all.
Could you post how you would change his build script so it builds at least?
Getting it to work is more important to me
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/godotengine/godot/issues/4490#issuecomment-215949755

@punto-
Here is the file so far:

SCsub
Import('env')
env_module = env.Clone()
env_module.Append(CPPDEFINES=['_USE_MATH_DEFINES'])
env_module.Append(CPPPATH='#modules/creaturegodot/glm')
env_module.Append(CPPPATH='#modules/creaturegodot/gason')
env_module.Append(CXXFLAGS=['--enable-c++11', '-D_SOME_MODULE_DEFINE'])
env_module.add_source_files(env.modules_sources,"*.cpp") # just add all cpp files to the build

it fails to build with this error:

scons: Building targets ...
g++ -o modules/creaturegodot/register_types.x11.tools.64.o -c --enable-c++11 -D_SOME_MODULE_DEFINE -g2 -Wall -DDEBUG_ENABLED -DDEBUG_MEMORY_ENABLED -DFREETYPE_ENABLED -DOC_X86_ASM -DDEBUG_MEMORY_ALLOC -DSCI_NAMESPACE -DOPENGL_ENABLED -DGLEW_ENABLED -DALSA_ENABLED -DJOYDEV_ENABLED -DPULSEAUDIO_ENABLED -DX11_ENABLED -DUNIX_ENABLED -DGLES2_ENABLED -DGLES_OVER_GL -DMUSEPACK_ENABLED -DOPENSSL_ENABLED -DSQUISH_ENABLED -DVORBIS_ENABLED -DOPUS_ENABLED -DTHEORA_ENABLED -DTHEORALIB_ENABLED -DPNG_ENABLED -DDDS_ENABLED -DPVR_ENABLED -DJPG_ENABLED -DWEBP_ENABLED -DSPEEX_ENABLED -DTOOLS_ENABLED -DGDSCRIPT_ENABLED -DMINIZIP_ENABLED -DXML_ENABLED -DETC1_ENABLED -DPNG_ARM_NEON_OPT=0 -D_REENTRANT -D_USE_MATH_DEFINES -Icore -Icore/math -Itools -Idrivers -I. -Iplatform/x11 -I/usr/include/freetype2 -Imodules/creaturegodot/vorbis -Imodules/creaturegodot/glm -Imodules/creaturegodot/gason modules/creaturegodot/register_types.cpp
cc1plus: error: unknown pass c++11 specified in -fenable
scons: *** [modules/creaturegodot/register_types.x11.tools.64.o] Error 1
scons: building terminated because of errors.

I am using this version of g++ btw:
g++ --version
g++ (Ubuntu 5.3.1-14ubuntu2) 5.3.1 20160413

@punto-
Using this line:
env_module.Append(CXXFLAGS=['--std=c++11'])
still fails to compile the module.

yeah, --enable-c++11 is just an example I made up, you have to find the
right option..
On 30 April 2016 at 07:53, Todor Imreorov<EMAIL_ADDRESS>wrote:

@punto- https://github.com/punto-
Using this line:
env_module.Append(CXXFLAGS=['--std=c++11'])
still fails to compile the module.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/godotengine/godot/issues/4490#issuecomment-215954791

I tried numerous different options and nothing seems to do it :(
On Sat, Apr 30, 2016 at 3:52 PM, punto-<EMAIL_ADDRESS>wrote:

yeah, --enable-c++11 is just an example I made up, you have to find the
right option..
On 30 April 2016 at 07:53, Todor Imreorov<EMAIL_ADDRESS>wrote:

@punto- https://github.com/punto-
Using this line:
env_module.Append(CXXFLAGS=['--std=c++11'])
still fails to compile the module.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
<https://github.com/godotengine/godot/issues/4490#issuecomment-215954791

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/godotengine/godot/issues/4490#issuecomment-215971280

What's the error with --std=c++11? It's the proper tag for gcc, so there error should be different than the one with --enable-c++11 where it parsed it as a gcc --enable-stuff standard option.

The tag for C++11 in gcc is actually -std=c++11, with only a single -.
I have managed to compile a module in C++11 for Godot before, but it was not easy since some of Godot's headers are not C++11 compatible. I had to make a C++99 wrapper of my module.

The tag for C++11 in gcc is actually -std=c++11, with only a single -.

 So @blurymind, try:
 env_module.Append(CXXFLAGS=['-std=c++11'])

If you keep the c++11 flag only to your module, you shouldn't have a
problem with the rest of the headers of the engine..
On 30 April 2016 at 12:46, Rémi Verschelde<EMAIL_ADDRESS>wrote:

The tag for C++11 in gcc is actually -std=c++11, with only a single -.
 So @blurymind https://github.com/blurymind, try:
env_module.Append(CXXFLAGS=['-std=c++11'])
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/godotengine/godot/issues/4490#issuecomment-215974337

If the compiler is different, what is the good practice? Is there an if to write with two different flags?

@punto- , @akien-mga  Thank you for the help so far. It still fails to compile unfortunately.
this is the SCsub file of the creature module so far:

SCsub
Import('env')
env_module = env.Clone()
env_module.Append(CPPDEFINES=['_USE_MATH_DEFINES'])
env_module.Append(CPPPATH='#modules/creaturegodot/glm')
env_module.Append(CPPPATH='#modules/creaturegodot/gason')
env_module.Append(CXXFLAGS=['-std=c++11'])
env_module.add_source_files(env.modules_sources,"*.cpp") # just add all cpp files to the build

and this is the compile error message (the last few lines - as it is long):

.....
In file included from /usr/lib/gcc/x86_64-linux-gnu/5/include/emmintrin.h:31:0,
from modules/creaturegodot/glm/detail/setup.hpp:616,
from modules/creaturegodot/glm/detail/type_int.hpp:32,
from modules/creaturegodot/glm/fwd.hpp:32,
from modules/creaturegodot/glm/glm.hpp:88,
from modules/creaturegodot/MeshBone.h:44,
from modules/creaturegodot/CreatureModule.h:41,
from modules/creaturegodot/creaturegodot.h:7,
from modules/creaturegodot/register_types.cpp:5:
modules/creaturegodot/glm/./gtx/simd_vec4.inl: In member function 'glm::detail::fvec4SIMD& glm::detail::fvec4SIMD::swizzle()':
modules/creaturegodot/glm/./gtx/simd_vec4.inl:178:3: error: function template-id 'mask<((((W << 6) | (Z << 4)) | (Y << 2)) | (X << 0))>' in nested-name-specifier
mask<(W << 6) | (Z << 4) | (Y << 2) | (X << 0)>::value);
^
In file included from /usr/include/glm/detail/func_integer.hpp:232:0,
from /usr/include/glm/integer.hpp:35,
from /usr/include/glm/glm.hpp:117,
from modules/creaturegodot/glm/./gtx/../detail/intrinsic_integer.hpp:32,
from modules/creaturegodot/glm/./gtx/simd_vec4.hpp:49,
from modules/creaturegodot/glm/ext.hpp:134,
from modules/creaturegodot/MeshBone.h:49,
from modules/creaturegodot/CreatureModule.h:41,
from modules/creaturegodot/creaturegodot.h:7,
from modules/creaturegodot/register_types.cpp:5:
/usr/include/glm/detail/func_integer.inl:50:23: note: 'template T glm::detail::mask(T)' declared here
GLM_FUNC_QUALIFIER T mask(T Bits)
^
scons: *** [modules/creaturegodot/register_types.x11.tools.64.o] Error 1
scons: building terminated because of errors.

Of course everyone is free to go and check out the module's code and try to compile it themselves here:
https://github.com/kestrelm/Creature_Godot

its perhaps worth noting that the module depends on glm and gason - but they are included in it's build folder

It looks like issues with the module itself, you should probably take it to the upstream developer directly.

Ok, I build it successfully but had to add a line to SCsub from @blurymind's version because some header file wasn't being found:
# SCsub
Import('env')

env_module = env.Clone()
env_module.Append(CPPDEFINES=['_USE_MATH_DEFINES'])
env_module.Append(CPPPATH='#modules/creaturegodot') # Added to find headers
env_module.Append(CPPPATH='#modules/creaturegodot/glm')
env_module.Append(CPPPATH='#modules/creaturegodot/gason')
env_module.Append(CXXFLAGS=['-std=c++11'])
env_module.add_source_files(env.modules_sources,"*.cpp") # just add all cpp files to the build

I tested with the sample provided and it's working fine.

@vnen  Awesome stuff. It's compiling now and looks promising.
I forwarded this solution to creature2d's dev and will be testing out his addon later today.
For anyone curious, there are a number of example files you can try to load into godot:
http://www.kestrelmoon.com/creaturedocs/Animation_Samples_And_Examples/Samples_And_Videos.html

If you keep the c++11 flag only to your module, you shouldn't have a
problem with the rest of the headers of the engine..

There was something to the effect of:
puts(__FILE__":"__LINE__);

In a Godot header. It could not compile since the syntax is ambiguous with C++11's user-defined literals. When my module included a header from Godot (one of those to register types) it failed to compile due to lines like this.
It might not be there anymore, but just pointing out that it is possible to have compile errors even if only your module is using C++11.

He committed the changes to master. Thanks everyone :D

Oh right, we've seen this, you just have to add spaces to the macro, like
this:
puts(FILE ":" LINE);
On 30 April 2016 at 15:08, Todor Imreorov<EMAIL_ADDRESS>wrote:

He committed the changes to master. Thanks everyone :D
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/godotengine/godot/issues/4490#issuecomment-215984415

Btw there was a nasty crash with the creature node where if you put a wrong directory, it crashes godot entirely. It is fixed now.
The plugin is really damn nice. It's so good to see smooth sprite deformation 2d animation in godot.
Can only hope to see godot's native animation editor catching up to that soon. Visually it is a huge improvement to have that

Is there something that needs to be fixed in Godot? The original issue was proven to not be related to the engine but @Kazuo256 is making a point here. WDYT @punto-?

I don't think so.. there may be some instances of that macro error where
you need to add spaces (I remember a patch for that a while ago tho), and
maybe the module docs could include this method of adding compile options
only for the module, other than that probably not..
On 30 April 2016 at 23:16, George Marques<EMAIL_ADDRESS>wrote:

Is there something that needs to be fixed in Godot? The original issue was
proven to not be related to the engine but @Kazuo256
https://github.com/Kazuo256 is making a point here. WDYT @punto-
https://github.com/punto-?
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/godotengine/godot/issues/4490#issuecomment-216008459

I just compiled Godot with CCFLAGS='-std=c++11'. Got a lot of warnings because of the macro (among other things) but it finished without errors. So I consider there's no issue anymore.


InjectionToken type should allow abstract classes

Abstract classes currently need symbols & annotations to be able to resolve in a constructor (similar to interfaces). IMO there's no reason for this limitation to exist, since the runtime knows about the type. The token shouldn't have the concrete constructor constraint at all for this case.
Example:
abstract class Logger {}
class ConsoleLogger extends Logger {}

@injectable()
class App {
  constructor(logger: Logger) {}
}

container.registerType(Logger, ConsoleLogger);
container.resolve(App);

This works perfectly if we remove the abstract keyword from the Logger class, but that isn't ideal since we don't want it to be instantiated.
It also works if we suppress the compiler error when registering the type:
Argument of type 'typeof Logger' is not assignable to parameter of type 'InjectionToken<Logger>'.
  Type 'typeof Logger' is not assignable to type 'constructor<Logger>'.
    Cannot assign an abstract constructor type to a non-abstract constructor type.ts(2345)

I recall we tried to implement this once before, but we found a bug where we couldn't prevent it from actually instantiating the abstract class (!) at runtime. Maybe this deserves another look.

We've just run in to this, but I believe there are specifics involved:
These don't work:
abstract class A {}

class B extends A {}

@injectable
class C {
  constructor(b: B) {}
}

abstract class A {
  constructor() {
    // do some stuff
  }
}

class B extends A {}

@injectable
class C {
  constructor(b: B) {}
}

These do work:
abstract class A {}

class B extends A {
  constructor() {
    // do some stuff
  }
}

@injectable
class C {
  constructor(b: B) {}
}

abstract class A {
  constructor() {
    // do some stuff
  }
}

class B extends A {
  constructor() {
    super();
    // possibly do something else
  }
}

@injectable
class C {
  constructor(b: B) {}
}

The reason for this is that if B doesn't have its own constructor, the constructor of A is used. This can't work for DI as we need to override the constructor, hence the problem trying to instantiate an abstract class. Even in the first example (the same situation as described by the OP) the constructor being used is implicitly that of A, which automatically has an empty one created. In that case B doesn't because A already has an empty one.
In fact, I'd recommend implementing constructors in all classes that extend an abstract class in Typescript, otherwise you can find unexpected side effects, where supposedly separate classes actually share the same prototype at run time.

@pnkp when trying your code, I still get Type 'typeof FileStorage' is not assignable to type 'constructor.`
but I do get the ExampleStorage from container.resolve(FileStoreage)

@pnkp when trying your code, I still get Type typeof FileStorage' is not assignable to type 'constructor<FileStorage>.
but at runtime, I do get the ExampleStorage from container.resolve(FileStoreage).
I would like to register the abstract classes, and get my implementation, but without typescript complaining. I still dont get, why that should not work? Any explanation would be appreciated :)

@Manuelbaun In my example above I just showed the problem 😄 It is not the solution

I am too using abstract classes as interfaces, just as @pnkp.
I ended up creating a simple utility function asImplementation, defined as:
import { InjectionToken, ClassProvider } from 'tsyringe';

type AbstractConstructor<T> = abstract new (...args: any[]) => T;
type ConcreteConstructor<T> = new (...args: any[]) => T;

export const asImplementation = <T>(
  InterfaceClass: AbstractConstructor<T>,
  ImplementationClass: ConcreteConstructor<T>
): [InjectionToken<T>, ClassProvider<T>] => {
  return [
    InterfaceClass as ConcreteConstructor<T>,
    {
      useClass: ImplementationClass,
    },
  ];
};

This is used as:
interface Engine {
  start(): void;
}

abstract class Engine {}

class V8Engine implements Engine {
  start(): void {
    // start the engine
  }
}

container.register(...asImplementation(Engine, V8Engine));

One problem with that is that it doesn't prevent the abstract class from being instantiated, as @MeltingMosaic mentioned.
One workaround I can think of is create a decorator like @interfaceOnly() that would override the abstract class constructor and prevent it from being instantiated in runtime.
import { container } from 'tsyringe';
import { asImplementation } from './lib/tsyringe/asImplementation';

const interfaceOnly = <
  TFunction extends abstract new (...args: any[]) => any
>() => {
  return (target: TFunction) => {
    return class {
      constructor(...args: any[]) {
        throw new Error(`Cannot instantiate ${target.name} interface`);
      }
    } as unknown as TFunction;
  };
};

describe('interfaces', () => {
  test('@interfaceOnly() throw error when trying to instantiate an abstract class acting as interface', () => {
    interface Engine {
      foo: string;
    }

    @interfaceOnly()
    abstract class Engine {}

    expect(() =>
      container.resolve(Engine as new (...args: any[]) => Engine)
    ).toThrowError();
  });

  test('asImplementation register implementation of an interface', () => {
    interface Engine {
      type: string;
    }

    @interfaceOnly()
    abstract class Engine {}

    class V8Engine implements Engine {
      type = 'V8';
    }

    container.register(...asImplementation(Engine, V8Engine));

    expect(
      container.resolve(Engine as new (...args: any[]) => Engine)
    ).toBeInstanceOf(V8Engine);
  });
});

The following solution seems to work, I don't see the abstract class being instanciated.
import 'reflect-metadata';
import { container, injectable, registry } from 'tsyringe';

type NonAbstractClass<T> = new (...args: unknown[]) => T;

let myAbstractClassIsInstanciated = false;
let myConcreteClassIsInstanciated = false;

abstract class MyAbstractClass {
  constructor() {
    myAbstractClassIsInstanciated = true;
  }
}

@injectable()
@registry([
  {
    token: MyAbstractClass as NonAbstractClass<MyAbstractClass>,
    useClass: MyConcreteClass,
  },
])
class MyConcreteClass implements MyAbstractClass {
  constructor() {
    myConcreteClassIsInstanciated = true;
  }
}

describe('tsyring dependency injection with abstract class', () => {
  it('Shoud only instanciate MyConcreteClass', () => {
    container.resolve(MyAbstractClass as NonAbstractClass<MyAbstractClass>);
    expect(myAbstractClassIsInstanciated).toEqual(false);
    expect(myConcreteClassIsInstanciated).toEqual(true);
  });
});


[Question] Is zookeeper necessary packages for this role?

Hi !
I tried playbook . In the TASK "Install Debian OS packages" (I use Ubuntu), zookeeper* packages sometimes were not installed. With "install_recommends" option, these are installed. entries are missing with_items: ? or can we setup without zookeeper with current configuration of role?
BTW requirements section in readme says "zookeeper" is necessary package for this role.
appreciate if any reply.

Yes, zookeeper is required for Mesos. You can either use an existing ZK installation or use the ansible-zookeeper role provided by AnsibleShipyard.


feat: support pdf file generation

Merge first this and then update transform dependency here
How to try:
npm i -g<EMAIL_ADDRESS>yfm --input $inputPath --output $outputPath --pdf-file

I got this error running on Ubuntu

Found explanation:
https://github.com/puppeteer/puppeteer/blob/main/docs/troubleshooting.md#running-puppeteer-in-docker

The bundled Chromium that Puppeteer installs is missing the necessary shared library dependencies.
To fix, you'll need to install the missing dependencies


Add helper function for listing all terraform commands to which locking applies.

Here's a common recommended terraform.tfvars:
terragrunt = {
   ...
   terraform {
     # Force Terraform to keep trying to acquire a lock for up to 20 minutes if someone else already has the lock
      extra_arguments "retry_lock" {
         commands = [
            "init",
            "apply",
            "refresh",
            "import",
            "plan",
            "taint",
            "untaint"
         ]
      }
   }
}

But this list of terraform commands that apply to locks is non-obvious. It'd be nice if we could add another helper command here that generates this array for you. It would make the terraform.tfvars look something like:
terraform {
   extra_arguments "retry_lock" {
      commands = [ get_terraform_commands_that_need_locking() ]
   }
}

Should be fixed by #205.


Docsreview

I can't see any instruction related installation of Azure CLI 2.0 and login instruction for it.

Also, I add one review. kubectl suddenly comes up.  I add instruction and links for it.

I noticed, if I use az acs kubernetes install-cli it downloads old version. So I add some notice.

Like this. Just use --client-version for this issue.
.\kubectl.exe version
Client Version: version.Info{Major:"1", Minor:"4", GitVersion:"v1.4.5", GitCommit:"5a0a696437ad35c133c0c8493f7e9d22b0f9b81b", GitTreeState:"clean", BuildDate:"2016-10-29T01:38:40Z", GoVersion:"go1.6.3", Compiler:"gc", Platform:"windows/amd64"}
Server Version: version.Info{Major:"1", Minor:"5", GitVersion:"v1.5.3", GitCommit:"029c3a408176b55c30846f0faedf56aae5992e9b", GitTreeState:"clean", BuildDate:"2017-02-15T06:34:56Z", GoVersion:"go1.7.4", Compiler:"gc", Platform:"linux/amd64"}

Thanks for the review Tsuyoshi!  I'd like to defer all of the CLI setup to Task 1 Step 1 versus explicit walkthrough to avoid having to maintain those steps. ;) https://docs.microsoft.com/en-us/azure/container-service/container-service-kubernetes-walkthrough

That said - the kubectl version option comment you added could be useful.  If you submit that PR to the public repo, I would approve that change :)


Build failed with branch rocksdb-only?

I make it on my mac and failed.
error is

Building sparsehash
tar: Error opening archive: Failed to open '/Users/nali/dev/ardb/src/../deps/sparsehash-sparsehash-2.0.3.tar.gz'
/bin/sh: line 0: cd: /Users/nali/dev/ardb/src/../deps/sparsehash-sparsehash-2.0.3: No such file or directory
/bin/sh: ./configure: No such file or directory
make[2]: *** No rule to make target `src/sparsehash/internal/sparseconfig.h'.  Stop.
make[1]: *** [/Users/nali/dev/ardb/src/../deps/sparsehash-sparsehash-2.0.3/src/config.h] Error 2
make: *** [all] Error 2

There is no file named sparsehash-sparsehash-2.0.3 in deps folder.

u can download it  at https://github.com/sparsehash/sparsehash/releases

@yinqiwen rocksdb-4.3.1.tar.gz not found.

@yinqiwen  i can download it at https://github.com/facebook/rocksdb/releases/tag/v4.3.1

but, can u push them to them repository?

this branch is still in developing, all dependency would be ready when it's stable enough .


Typo in Eq. 9.4, line 30, page 397, Section <IP_ADDRESS>, version 2023-04-01

a ∝ symbol is missing from this equation, compared to Eq. 17.50 on page 610 of "Machine Learning: A Probabilistic Perspective"

fixed


Range request out of bounds.

Issue: requesting byte range greater than the content-length of the file.
Let's say a file has a content-range of 815957.  doing a curl -r 0-1048575 "http://simpleserver/file.bin" will return a curl error of 18 and
Content-Range: bytes 0-1048575/815957
Content-Length: 1048576
This is the amount requested, but more than the length of the file.
Apache http for example will return correctly the maximum amount of the file:
Content-Range: bytes 0-815956/815957
Content-Length: 815957
This line in the code blindly takes the range... without comparing it to the entry.size.. so fileEndOffset I think should be the lessor of entry.size-1 or parseInt(rparts[1])
https://github.com/terreng/simple-web-server/blob/ef693aee1ab8f09ec2995d9ca9f2040404433e79/WSC/handlers.js#L839

Whoops, thanks for the catch

Will be fixed soon in 1.2.14. Thanks!


Any character opens Dropdown menu

components: Dropdown
reactstrap version 6.5.0
import method es
react version 16.5.2
bootstrap version 4.1.3

What is happening?
Any key (including e.g.; Esc or Shift) opens the Dropdown menu
What should be happening?
open the Dropdown (aria menu) only when Enter is pressed (from WAI ARIA 1.1)
Steps to reproduce issue

keyboard nav to put focus on the DropdownToggle (the button tag)
press a key

Code

I've started working on a fork. 85% satisfied (leaving on road trip tmrw). Hoping to get a PR out early next week to address wai-aria/keyboard-nav improvements to Dropdown. The WiP Branch is here.
Gist of changes:

[x] Home/End key jumps
[x] up/down wraps
[x] spacebar enter interchangeable
[x] aria [role=menuitem]
[x] 1st item gets focus on menu expand
[x] misc focus mgmt
[ ] more tests
[ ] memoize some stuff

It should default to how bootstrap does it. You can allow for extra props to control extra ability.
Bootstrap doesn't do any of these:

Home/End key jumps
up/down wraps
spacebar enter interchangeable
1st item gets focus on menu expand

d'oh! I'd been checking the PR Thread for feedback instead of here 🤕

Bootstrap doesn't do any of these:

Home/End key jumps
up/down wraps
spacebar enter interchangeable
1st item gets focus on menu expand

Apologies. I've only recently become familiar with project history and at time of submission hadn't understood the implied goal: functional parity with Bootstrap.

Home/End key jumps

👍 not a feature in BS4
🗯WAI-ARIA1.1 optional, but required "If arrow key wrapping is not supported"[1]

up/down wraps

👍 not a feature in BS4
🗯WAI-ARIA1.1 optional

spacebar/enter

👎this does activate the menu button in BS4[2]
🗯WAI-ARIA1.1 requires space and enter to "open the menu"[3]

1st item gets focus on menu expand*

👍 not a feature in BS4
🗯WAI-ARIA1.1 "place focus on the first menu item"[3][4]

IMO 2 is a bug and  must be supported in reactstrap. Actually any of the following keyCodes: ESC, ENTER, SPACE, UP_ARROW, DOWN_ARROW open the menu in BS4 (and only those keys). This behavior should be replicated as BS4.1 does this.
WAI ARIA requires either 1 or 2, but BS4 fails this... what is the path to ARIA compliance here? (Same for 4). Raise in BS4.x, wait for fix, replicate here?


global: Flask-Security refactoring

INCOMPATBILE Refactors code to use Flask-Security instead of
custom implementation.

Signed-off-by: Lars Holm Nielsen<EMAIL_ADDRESS>

@SamiHiltunen please have a look at new structure of Invenio package as proposed in the PR.

The change is huge. Are there some particular area you wish for even more review?

@kaplun Thanks. I think right now it's probably not necessary, as we anyway need some further iterations over it before it makes sense to review closer. I think by beginning of November we will have the first versions ready where it will make sense to review it. It's pretty much in line with what has been discussed previously of moving fully to Flask-Security. Also note the PR is for next branch, so won't affect master yet.

@lnielsen It looks good. Please have a look at my comments above and you can add Reviewed-by: me.


[RPi/armv7] Server lagging and crashing with recent updates

Hello, I've noticed lately that my server running off of my Raspberry Pi 4B (armv7 image) has been effectively unusable for the past few versions. I'm not quite sure what suddenly is the problem, but worlds are very laggy, and chunks are slow to load, with server crashes occasionally happening.
 Is the server overloaded? Running 15655ms or 313 ticks behind" or "[Server Watchdog/FATAL]: A single server tick took 60.00 seconds (should be max 0.05)"
Was just wondering if others are experiencing this as well with the armv7 branch.

Please double check using the multiarch tag since I have deprecated the armv7 branch/tag and consolidated into multiarch. With that said, starting with 1.15 the minecraft server seems to be considerably more resource intensive in general :(

Thanks, I switched over to the multiarch tag but the same issues remain. Ugh yeah I'm wondering if the recent updates need more resources, because my poor Pi server crashes me out after a few minutes of connecting.

Yeah, I had to give up using my RaspberryPi 3 B+ :( Luckily I also have an Intel NUC running Ubuntu, so that has worked out well.

Just an FYI, there is an open bug filed with Mojang about apparent server performance issues with 1.16.


default --jobs parameter to zero

solved #28

Based on this commit, I believe we should abandon this PR and chose a different approach to correct issue #28.

Based on this commit I do not believe sending --jobs=0 to git clone is a good idea.
Our target OSes do not contain the fixed release, 2.40.


Problem in simulating threshold-switching models

Hi Junior,
Hope everything is going well.
Recently I have been using RISE to build Markov-switching models with endogenous probabilities, and I am particularly interested in the threshold-switching model, where the regime is determined by whether a variable takes a value above or below some threshold level. It seems that RISE can solve but cannot simulate such kind of models.
As an example, the endogenous probabilities in such models are
! ocb_tp_1_2  = 1 - normcdf(var, 0, sigma)
! ocb_tp_2_1  = normcdf(var, 0, sigma)
where var is just an endogenous or exogenous variable. Ideally, to build a threshold-switching model, the parameter sigma should approach zero. When I set a high value for sigma (e.g. 0.1), the model can be solved and be simulated. But when I set a low value for sigma (e.g. 0.01) the model can only be solved by cannot be simulated.
Initially I thought the problem was coming from the algorithm you used, so I wrote a Matlab code myself to solve and simulate a model with threshold switching using exactly the algorithm you introduced in Maih (2015). Fortunately, it worked even for very low values of sigma (e.g. 0.0001). But then I don't understand the reason why it doesn't work in RISE. Do you have any thoughts on where the problem is coming from? Also, could you tell me where to find the Matlab codes for algorithms MFI, MN and MNK in the toolbox? Thanks!
Best,
Zexi

Hi Zexi,
Can you send me a copy of the model you are not able to simulate?
If you cannot post it directly to the forum, send it to me privately.
NB: I do not have extra time on hands right now. I am currently teaching an
intensive course and might not be able to get back to you swiftly.
Cheers,
J.
On Tue, Apr 25, 2017 at 10:35 AM, Zexi Sun<EMAIL_ADDRESS>wrote:

Hi Junior,
Hope everything is going well.
Recently I have been using RISE to build Markov-switching models with
endogenous probabilities, and I am particularly interested in the
threshold-switching model, where the regime is determined by whether a
variable takes a value above or below some threshold level. It seems that
RISE can solve but cannot simulate such models
To be specific, The endogenous probabilities in such models are
! ocb_tp_1_2 = 1 - normcdf(var, 0, sigma)
! ocb_tp_2_1 = normcdf(var, 0, sigma)
where var is just a endogenous or exogenous variable. Ideally, to build a
threshold-switching model, the parameter sigma should approach zero. When
I set a high value for sigma (e.g. 0.1), the model can be solved and be
simulated. But when I set a low value for sigma (e.g. 0.01) the model can
only be solved by cannot be simulated.
Initially I thought the problem was coming from the algorithm you used, so
I wrote a Matlab code myself to solve and simulate a model with threshold
switching using exactly the algorithm you introduced in Maih (2015).
Fortunately, it worked even for very low values of sigma (e.g. 0.0001).
But then I don't understand the reason why it doesn't work in RISE. Do you
have any thoughts on where the problem is coming from? Also, could you tell
me where to find the Matlab codes for algorithms MFI, MN and MNK in the
toolbox? Thanks!
Best,
Zexi
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jmaih/RISE_toolbox/issues/49, or mute the thread
https://github.com/notifications/unsubscribe-auth/ACagz8McA2vEoyZoIZr-ixQllw8z37Fiks5rzbBfgaJpZM4NHKVT
.

Hey Junior,
Thanks so much for your reply!
I think I've found where the problem came from. Previously I defined two variables prob12 and prob21 to track endogenous probabilities. Then, in the threshold-switching case, the endogenous probabilities are specified as
prob12 = 1 - normcdf(var, 0, sigma)
prob21 = normcdf(var, 0, sigma)
! ocb_tp_1_2 = prob12
! ocb_tp_2_1 = prob21
It turned out that if I choose a very low value for sigma in such specification (e.g. 0.001) then the simulation does not work (Error message: Problem in transition matrix).
However, if I specify endogenous probabilities directly as
! ocb_tp_1_2 = 1 - normcdf(var, 0, sigma)
! ocb_tp_2_1 = normcdf(var, 0, sigma)
then even when the value of  sigma is very low, the model can be simulated!
I don't know exactly why this would happen, but I guess it might have something to with the approximation of the endogenous probabilities.
Finally, if possible, could you send me some course materials you used for other intensive courses from time to time? I wish to learn RISE more!
Many thanks,
Zexi


SNOW-1775480: Update cloudpickle dependency to allow >=3.0

What is the current behavior?
Cloudpickle dependency is pinned at <=2.2.1
What is the desired behavior?
Allow a wider dependency range for cloudpickle which includes versions >=3.0
How would this improve snowflake-snowpark-python?
The newer release is a requirement for the popular distributed computing library dask: https://github.com/dask/dask/blob/7ab0c93cfca0af130c778f9c1baec29a1f10b616/pyproject.toml#L33
Older versions of dask are compatible with the old cloudpickle versions, but there are many fixes and improvments in dask that have since been released since the 2024.08.1 release. A couple of those specific fixes that I would like to pick up are the crux of my issue.
Additionally, if support of python version 3.12 is intended at some point for the snowpark project, then the cloudpickle 3.0 version would likely be ideal (as this is the first release with official, tested support for python 3.12)
References, Other Background
I can see that the current snowpark pyproject references challenges on the support on the backend: https://github.com/snowflakedb/snowpark-python/blob/5a0aca281c480f41bfde534f667e027837248037/setup.py#L23-L24
It would be helpful to understand if this is something that can't easily be supported by the snowpark library, or if this can be supported but will take some time. Thanks for you help!

Hello @CSRessel ,
Thanks for raising the issue, the support for python 3.12 with snowpark will be added tentatively end of Nov 2024.
Regards,
Sujan


Retry logging tweaks

Existing logging can be quite noisy when using an error aggregator like Rollbar; improve retry logging so we have more control over it.

Thank you!


[MM-61124] Add diagnostics data to the Support Packet

Summary
When a Support Packet gets generated, the plugin now includes diagnostics data via a diagnostics.yaml file into the Packet.
Example content of playbooks/diagnostics.yaml:
version: 2.0.1+74aea618
total_playbooks: 1
active_playbooks: 1
total_playbook_runs: 2

Requires https://github.com/mattermost/mattermost/pull/28833 on the server side. https://github.com/mattermost/mattermost-plugin-playbooks/pull/1956 needs to be merged first.
See https://mattermost.atlassian.net/wiki/spaces/CLOUD/pages/3083108354/Diagnostics+data+from+Core+Plugins+to+the+Support+Packet for more context.
Ticket Link
https://mattermost.atlassian.net/browse/MM-61124
Checklist

[x] Telemetry updated
[x] Gated by experimental feature flag
[x] Unit tests updated

@wiggin77 Gentle reminder to review the PR

Per discussion with @raghavaggarwal2308, QA testing will happen post merge.


Error during installation

Getting the following error trying to install via go 1.16.5 on Manjaro 20.
go install github.com/maintainer-org/maintainer@latest
go: downloading github.com/maintainer-org/maintainer v1.0.5
go: finding module for package github.com/gaocegege/maintainer/cmd
go: downloading github.com/gaocegege/maintainer v1.0.5
go: found github.com/gaocegege/maintainer/cmd in github.com/gaocegege/maintainer v1.0.5
go: finding module for package golang.org/x/oauth2
go: finding module for package github.com/spf13/cobra
go: finding module for package github.com/google/go-github/github
go: finding module for package github.com/spf13/viper
go: downloading github.com/spf13/cobra v1.2.1
go: downloading github.com/spf13/viper v1.8.1
go: downloading github.com/google/go-github v17.0.0+incompatible
go: downloading golang.org/x/oauth2 v0.0.0-20210628180205-a41e5a781914
go: found github.com/google/go-github/github in github.com/google/go-github v17.0.0+incompatible
go: found github.com/spf13/cobra in github.com/spf13/cobra v1.2.1
go: found github.com/spf13/viper in github.com/spf13/viper v1.8.1
go: found golang.org/x/oauth2 in golang.org/x/oauth2 v0.0.0-20210628180205-a41e5a781914
go: downloading github.com/magiconair/properties v1.8.5
go: downloading github.com/pelletier/go-toml v1.9.3
go: downloading github.com/spf13/afero v1.6.0
go: downloading golang.org/x/net v0.0.0-20210405180319-a5a99cb37ef4
go: downloading golang.org/x/text v0.3.5
go: finding module for package github.com/google/go-querystring/query
go: downloading github.com/google/go-querystring v1.1.0
go: found github.com/google/go-querystring/query in github.com/google/go-querystring v1.1.0
# github.com/gaocegege/maintainer/contributing
mygo/pkg/mod/github.com/gaocegege/maintainer@v1.0.5/contributing/contributing.go:109:47: not enough arguments in call to client.Repositories.Get
        have (string, string)
        want (context.Context, string, string)

I asked some co-workers to check and they ran into the same issues using both this and GO111MODULE=on go get github.com/maintainer-org/maintainer.
There was a migration on April 20th, maybe something broke around then? I also can't get the Docker image to work (yells about config files).
Guidance appreciated, thanks :)

Thanks for your report, I will have a look ASAP.

@ravindk89 The problem was fixed in #43

Much appreciated!


403 error

https://vod-secure.twitch.tv/0d5291b425e51bb9be1d_yhs0502_1140680427_1630967160/chunked/index-dvr.m3u8
youtube-dl is up-to-date (2021.06.06)
USER:~ USER$ youtube-dl https://vod-secure.twitch.tv/0d5291b425e51bb9be1d_yhs0502_1140680427_1630967160/chunked/index-dvr.m3u8
[generic] index-dvr: Requesting header
WARNING: Could not send HEAD request to https://vod-secure.twitch.tv/0d5291b425e51bb9be1d_yhs0502_1140680427_1630967160/chunked/index-dvr.m3u8: HTTP Error 403: Forbidden
[generic] index-dvr: Downloading webpage
ERROR: Unable to download webpage: HTTP Error 403: Forbidden (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

Checklist

[ ] I'm reporting a broken site support issue
[ ] I've verified that I'm running youtube-dl version 2021.06.06
[ ] I've checked that all provided URLs are alive and playable in a browser
[ ] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[ ] I've searched the bugtracker for similar bug reports including closed ones
[ ] I've read bugs section in FAQ

Verbose log

PASTE VERBOSE LOG HERE

Description

WRITE DESCRIPTION HERE

Do not make duplicate report. https://github.com/ytdl-org/youtube-dl/issues/29927#issuecomment-915689798


ISPN-6118 CacheNotifierImplInitialTransferDistTest random failures

https://issues.jboss.org/browse/ISPN-6118
Generate many more keys to make sure we get one with the right owners.

Looks fine, pulling...

Integrated into master, thanks @danberindei !


Sticky notes GUI

Aim

A simple GUI based application in Python that helps you to create simple remember lists or sticky notes.

@vikashkumar2020 assigned to you.

@vikashkumar2020 updates?

I will complete it by today it is in progress


Add Gcaptcha validation filter

Purpose

Add Gcaptcha validation filter

Codecov Report

Merging #29 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #29   +/-   ##
=======================================
  Coverage   30.35%   30.35%
=======================================
  Files          42       42
  Lines         883      883
  Branches      137      137
=======================================
  Hits          268      268
  Misses        561      561
  Partials       54       54

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29ca13e...e9c1448. Read the comment docs.


How to map multiple JSON properties to another realm model in the current model?

Your JSON dictionary:
{
  "userName": "Jack",
  "id": 10086,
  "userID": 123,
  "content": "This is an album content!"
  "userAvatar": "https://useravatarurl.png"
}

The userName userID userAvatar are for the owner of the album, which are in UserModel.
The id content are for album.
Your model:
The model is RealmSwift Object Model:
class UserModel: Object, Mappable {
  var id = 0
  var userName: String = ""
  var avatarUrl: String?

  init(_ map: Map) {
    id <- map["id"]
    avatarUrl <- map["avatar"]
    username <- map["userName"]
  }
}

class AlbumModel: Object, Mappable {
  var id = 0
  var content: String = ""
  var owner: UserModel?

  init(_ map: Map) {
    id <- map["id"]
    content <- map["content"]
    // owner <- map["id"] ?? How could I map userID, userName, userAvatar into a realm object?
  }
}

Thanks for any help.

I think I have got my answer.
What I need is to map the json twice, one for AlbumModel, and the other for UserModel.
In AlbumModel, I map the userID in json into UserModel-type property owner.


Fix JSONModel Objective-C compilation with  Xcode 8.3

@billinghamj can you publish a release with this fix for CocoaPods users?


Bug: ErrorException #1 Uncaught ErrorException: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in /usr/share/nginx/sites/vtrans/system/Validation/FormatRules.php:253

PHP Version
8.1
CodeIgniter4 Version
CodeIgniter: 4.1.5
CodeIgniter4 Installation Method
Composer (as dependency to an existing project)
Which operating systems have you tested for this bug?
Linux
Which server did you use?
fpm-fcgi
Database
MariaDB 10.2
What happened?
{PHP internal code}   —  CodeIgniter\Debug\Exceptions->shutdownHandler ()
Uncaught ErrorException: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in /usr/share/nginx/sites/vtrans/system/Validation/FormatRules.php:253
246      */
247     public function valid_ip(?string $ip = null, ?string $which = null): bool
248     {
249         if (empty($ip)) {
250             return false;
251         }
252
253         switch (strtolower($which)) {
254             case 'ipv4':
255                 $which = FILTER_FLAG_IPV4;
256                 break;
257
258             case 'ipv6':
259                 $which = FILTER_FLAG_IPV6;
260                 break;
Steps to Reproduce
Post request
In controller Use this
$this->session->setFlashdata('alert-msg', 'Email and Password required.');
return redirect()->to(base_url());
Expected Output
It should redirect with flash message
Anything else?
No response

https://github.com/codeigniter4/CodeIgniter4/issues/5436


TypeError: Adapter is not a constructor

I have such a setup file:
import * as Enzyme from 'enzyme';
import * as Adapter from '@wojtekmaj/enzyme-adapter-react-17';

Enzyme.configure({ adapter: new Adapter() });

in package I have:
"@wojtekmaj/enzyme-adapter-react-17": "^0.6.1"
"enzyme": "^3.11.0"
and my jest output is:
Test suite failed to run

    TypeError: Adapter is not a constructor

      2 | import * as Adapter from '@wojtekmaj/enzyme-adapter-react-17';
      3 |
    > 4 | Enzyme.configure({ adapter: new Adapter() });
        |                             ^

      at Object.<anonymous> (src/setupTests.js:4:29)

Test Suites: 1 failed, 1 total
Tests:       0 total
Snapshots:   0 total
Time:        2.466 s

Please help me to figure out this error

You're not importing the adapter as described in documentation.

You're not importing the adapter as described in documentation.

It works, thank you!

I think I have a somewhat similar issue:
  ● Test suite failed to run

    TypeError: enzyme_adapter_react_17_1.default is not a constructor

       6 | import {configure, shallow} from 'enzyme';
       7 | import Adapter from '@wojtekmaj/enzyme-adapter-react-17';
    >  8 | configure ({ adapter: new Adapter() });

Dependencies:

"@wojtekmaj/enzyme-adapter-react-17": "^0.6.5",
"enzyme": "^3.11.0",
"jest": "^27.3.1",
"react": "^17.0.2",
"react-dom": "^17.0.2",


Glue: get/delete/list_registries, get/update_schema

Fixes #5816
Implements Glue:
get_registry()
delete_registry()
list_registries()
get_schema()
update_schema()
Also moves Glue to a region-based implementation, as it should - it was erroneously implemented as a global service before.

Codecov Report

Merging #5849 (415a533) into master (a179569) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5849      +/-   ##
==========================================
- Coverage   96.18%   96.18%   -0.01%
==========================================
  Files         754      754
  Lines       74263    74307      +44
==========================================
+ Hits        71431    71472      +41
- Misses       2832     2835       +3

Flag
Coverage Δ

servertests
36.93% <14.51%> (-0.02%)
:arrow_down:

unittests
96.12% <100.00%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

moto/glue/models.py
97.10% <100.00%> (+0.12%)
:arrow_up:

moto/glue/responses.py
99.68% <100.00%> (+0.02%)
:arrow_up:

moto/batch/models.py
91.06% <0.00%> (-0.37%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


RTL backup

I'm getting an error when trying to down a backup from RTL (Lightning > Backup).
RTL version 0.8.4-beta
Reading File Failed!
Error Code: -2
Error Message: ENOENT
API URL: ./api/conf/file?channel=ALL

I can reproduce this bug. Looking at the RTL logs it says:
Sep 21 15:00:05 raspberrypi node[17746]: [1B blob data]
Sep 21 15:00:05 raspberrypi node[17746]: ERROR: Conf(207) => Reading File Failed!

This error gets thrown by RTL here:
https://github.com/Ride-The-Lightning/RTL/blob/1b86a8bc84fae5708ec364711fbe26b22507906b/controllers/RTLConf.js#L207
@saubyk how can we make sure reading the file correct?

I had the same error, still want to be able to download a backup though... will try a scp command instead.

Pinging @shahanafarooqui

Above error only explains that the file doesn’t exist at the location. Just take the backup first and it will download the file.
You need to click on the ‘Backup All’ button to take the backup first. Once that button is clicked, the backup file will be saved in the backup folder and the file will be available for download after that.
We have updated the error message to make it clearer. @saubyk, this is the same UX issue which we discussed two days back. We can backup channels if the file doesn’t pre-exist then download. But, you were not in favor to include these two actions in a single click.

@ShahanaFarooqui I just checked ... when I first click on "Backup All" I get a "all channels backuped sucessfully" but when I then click the "Download Backup" I still get the error described above.
I checked ... the files gets created and is readable for all users:

@ShahanaFarooqui I also clicked first to "Backup all". Still the same error. Maybe, because it runs never before here?
With Thunderhub the backup is still working.

Restore looks for backup file in:
Restore folder location: /home/rtl/RTL-SCB-backup-/restore
Files are located in: /home/rtl/RTL-SCB-backup-

This bug fix will be released with next RTL version (https://github.com/Ride-The-Lightning/RTL/issues/536). It was due to case sensitive Unix file system. It is searching for file as ‘channel-ALL’ and unable to find the file.
@NilByte The restore feature requires the user to place file in the ‘restore’ folder but this bug is about downloading the backup file on the local machine.

OK tested the backup again on new RTL 0.10.1 release included in v1.7RC1 --> not getting a error, but my backupfile is just 3 bytes @ShahanaFarooqui is there anything further to be changed/fixed?

In my latest tests in preparation of the v1.7.1 of RaspiBlitz I see the backup now also on the local directory with 0 bytes:

@rootzoll The issue has been fixed with release 10.0 and I am unable to reproduce the issue anymore. Can you please check if you are getting any error in RTL console related to channel backup?

@openoms Thanks a lot for detailed testing and instructions. I was finally able to reproduce and fix the issue with your help :).
The bug has been fixed and will be released with RTL v0.12.0.


Broken Biome Source Tutorial is outdated (I believe)

I followed the tutorial to fix the biome source being wrong, after updating a modpack that added BetterEnd in said update.
Apparently "betterend:better_end_biome_source", did not exist, and upon making a new world and inspecting its level.dat, It's instead "bclib:end_biome_source".
I would have assumed this is due to general modpack crustiness, until I saw on the CurseForge page that BCLib is a required dependency of BetterEnd, meaning that the prefix has probably actually just changed and you guys haven't updated the tutorial yet.
Please update it, as it would save probably more people than just me a lot of headache lmao.

This tutorial was made for 1.16 version, in modern versions BCLib fixes biome source automatically. Probably tutorial require some updates


invalid prometheus metric warnings

Describe the bug
A clear and concise description of what the bug is.
{"level":"warn","ts":"2021-03-10T11:35:58.617-0800","msg":"error in prometheus reporter","error":"descriptor Desc{fqName: \"\", help: \" gauge\", constLabels: {}, variableLabels: [cadence_service operation domain active_cluster]} is invalid: \"\" is not a valid metric name","logging-call-at":"metrics.go:138"}
{"level":"warn","ts":"2021-03-10T11:35:58.617-0800","msg":"error in prometheus reporter","error":"descriptor Desc{fqName: \"\", help: \" gauge\", constLabels: {}, variableLabels: [operation cadence_service domain active_cluster]} is invalid: \"\" is not a valid metric name","logging-call-at":"metrics.go:138"}
{"level":"warn","ts":"2021-03-10T11:35:58.617-0800","msg":"error in prometheus reporter","error":"descriptor Desc{fqName: \"\", help: \" gauge\", constLabels: {}, variableLabels: [cadence_service operation domain active_cluster]} is invalid: \"\" is not a valid metric name","logging-call-at":"metrics.go:138"}
{"level":"warn","ts":"2021-03-10T11:35:58.617-0800","msg":"error in prometheus reporter","error":"descriptor Desc{fqName: \"\", help: \" gauge\", constLabels: {}, variableLabels: [cadence_service operation domain active_cluster]} is invalid: \"\" is not a valid metric name","logging-call-at":"metrics.go:138"}
{"level":"warn","ts":"2021-03-10T11:35:58.617-0800","msg":"error in prometheus reporter","error":"descriptor Desc{fqName: \"\", help: \" gauge\", constLabels: {}, variableLabels: [cadence_service operation domain active_cluster]} is invalid: \"\" is not a valid metric name","logging-call-at":"metrics.go:138"}
{"level":"warn","ts":"2021-03-10T11:35:58.617-0800","msg":"error in prometheus reporter","error":"descriptor Desc{fqName: \"\", help: \" gauge\", constLabels: {}, variableLabels: [operation domain active_cluster cadence_service]} is invalid: \"\" is not a valid metric name","logging-call-at":"metrics.go:138"}
{"level":"warn","ts":"2021-03-10T11:35:58.617-0800","msg":"error in prometheus reporter","error":"descriptor Desc{fqName: \"\", help: \" gauge\", constLabels: {}, variableLabels: [domain active_cluster cadence_service operation]} is invalid: \"\" is not a valid metric name","logging-call-at":"metrics.go:138"}

To Reproduce
Is the issue reproducible?

yes

Steps to reproduce the behavior:
./cadence-server --env development_prometheus start

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here, E.g. Stackstace, workflow history.

https://github.com/uber/cadence/pull/4043

https://github.com/uber/cadence/pull/4047


Changed add connection -> new connection

This PR fixes #19242
Do I need to change this in the other langpacks as well? Not quite sure how that works.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 41.894%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/sql/workbench/contrib/objectExplorer/browser/serverTreeView.ts
0
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
27856

Relevant Lines:
62042

💛  - Coveralls


Deleting with DEL-Key not working in Lego Project.

Added filtering for bricks in the delete function. Works now.


bug: Walletconnect + trutwallet + alchemy + usePrepareSendTransaction = 400 error "Unsupported method: test"

Is there an existing issue for this?

[X] I have searched the existing issues

Package Version
0.11
Current Behavior

Connect to app with Trust wallet on iOS (using wallet connect QR)
dApp says things are fine
400 network error in console (and SOME Trust wallet versions show an error message in app but not all)
Nothing actually works

The usePrepareSendTransaction seems to call the alchemy api with:
{
    "id": 1,
    "jsonrpc": "2.0",
    "method": "test",
    "params": []
}

to which alchemy responds:
{"jsonrpc":"2.0","id":1,"error":{"code":-32600,"message":"Unsupported method: test. See available methods at https://docs.alchemy.com/alchemy/documentation/apis"}}`

I have checked with Rainbow at rainbow-me/rainbowkit/issues/1040 but they indicate not to use that endpoint.
Alchemy don't seem to know what is going on. Which leaves something the Wagmi hook does.
Note: I do not see this issue with other wallets.

Steps To Reproduce

Open this codesandbox
Replace ALCHEMY_KEY on line 10 with any alchemy key
Open console and/or network tab
Click connect button
Use Trust wallet to connect

Link to Minimal Reproducible Example (StackBlitz, CodeSandbox, GitHub repo etc.)
https://codesandbox.io/s/rainbowkit-forked-s9mssc?file=/src/App.js
Anything else?
No response

Hope you don't mind a direct tag @tmm, is there anything I can do to clarify this issue?

Looks like this is coming from Trust's implementation of WalletConnect v1.
I'd suggest to try upgrade to WalletConnect v2, and try again.
https://wagmi.sh/react/connectors/walletConnect

For context in case someone lands here: Rainbowkit are aware that they need to support WalletConnect v2 and are adding it in the next patch. See these release notes.


Table Footer Formula

Hey,
I've noticed is that the formula doesn't work as expected for the "Total" table function. For example, I'm using sum function in the image below:

Shouldn't the last column (a derived metric as percentage) be calculated by the formula as well? I mean, first sum the column values and then apply the formula (sum(agg1)/sum(agg3))?
Thanks!

Hi !
At the moment, the total function is defined by kibana. I will see if i can override it.
Thx for your report =)

@tcharlot-datasweet Hey, I fixed this bug in #14!
Feel free to comment and suggest changes 🙂


Isoforms defined by reads with high fraction A (>0.5)

We are currently filtering out models that have supporting reads with evidence of internal priming.
I've seen a case for permissive where the model's 3' boundary is defined by a read that has fracA > 0.5 that so happened to be added first to the TALON database.
Is this the correct behaviour of TALON as it seems risky to build novel isoforms based on reads that might result from internal priming? I admit it is a genomic category so probably should exclude it anyway.   If you wish for these reads to not be used to generate transcript models I would perhaps try to filter your sam / bam alignments for those that have high A content at the 3' end before running TALON, as that might get you closer to your desired output.

Yes, we are proceeding now to do this after the TALON label step and remove such reads and then start TALON.
Thank you for the reply


support multiple files, including shell regular expressions

This is a quick implementation for #2 - I've made it support variadic file/directory names. The summary isn't perfect, but I think we'd need to rework the async/await stuff with cipher() for that, and to be honest, I'm not sure why you're using async/await there.
This will work with shell regular expressions; so you can run commands like
$ warshield encrypt *.secret

$ warshield decrypt {foo,bar}files

$ warshield encrypt $HOME/secret-project-*

Closed because of architecture reworking - this PR will be reworked tho


Possible Memory Leak with IE 11

Simply visiting the below page in IE 11 and the clicking on the DateTimePicker menu item in the top navigation menu to reload the page will cause IE11 to consume vast amounts of memory. I can replicate this issue on multiple machines and I am able to replicate it on other sites that use this datetime control. I do not have access to IE less that 11, so I am not sure if the issue occurs there as well. I do not see the issue in Firefox or Chrome.
https://xdsoft.net/jqplugins/datetimepicker/

Your date/time picker has serious memory leak issues with IE11. Any plans to fix this?

destroy method should consider all event handler.
let destroyDatetimepicker = () => {
    let $datetimepicker = $input.data('xdsoft_datetimepicker');
    if ($datetimepicker) {
        $datetimepicker.off();
        $datetimepicker.find('*').off();

        $input.datetimepicker('destroy');
    }
};

This is still a huge issue in IE 11. Your own website proves this point. I can load your website on IE 11 on any machine I use and when I refresh the page the memory footprint goes up and up.


Reason variables

This is a companion PR for https://github.com/reasonml-community/graphql-ppx/pull/175.
That PR makes it possible for hooks and client methods now accept t_variables instead of Raw.t_variables. The advantage of this is that records can be the primary way of passing variables and makeVariables is a convenience function for when you want to only pass a few optional variables. Using Raw. t_variables before allowed you to explicitly pass null arguments, however. To accommodate this, you can now pass a mapNullVariables (name?) function to anything that takes t_variables. Something like this:
  let queryResult = ExampleQuery.use(
    ~mapNullVariables=(jsVars => {
      ...jsVars,
      explicitNullableArg: Js.Nullable.null
    }),
    {id: "1": explicitNullableArg: None}
  );

I'm only really concerned with being able to pass t_variables at the call site, so everywhere else things are typed as Raw.t_variables. I think that's fine and perhaps even preferable in some cases.

Ah that's nifty!

Wanna pull the trigger on this?

Ah that's nifty! Maybe just mapRawVariables?

That feels more accurate. What about mapJsVariables? I've avoided raw in favor of Js in the types :shrug:

Wanna pull the trigger on this?
Let's do it!

That feels more accurate. What about mapJsVariables? I've avoided raw in favor of Js in the types 🤷

Yes, sure


Compatibility with Textmaker Firefox add on

Hello I have used this extension and it is very useful to handle articles etc. My problem is in relation to manage highlights. I would like the extension to be compatible, recognize and download the highlights of this extension https://addons.mozilla.org/es/firefox/addon/textmarkerpro/?utm_source=addons.mozilla.org&utm_medium=referral&utm_content=search
It would be amazing to be able to combine them to have an online version of the underlines and at the same time offline.

Unfortunately, there isn't really a good way to convert multicoloured highlights to markdown. I could add <mark> support (i.e. converting <mark> to ==, or even just skipping <mark> so it remains in the markdown), but I'll keep that as a separate issue.
I'm not sure how that extension works exactly, but I'd assume it would just add in <mark> tags with specific styling.
The other issue is that extension is deprecated and no longer supported.
So I'm going to close this issue as not planned, but I do plan to support <mark> in future, which may actually make this work for you.


Edge case bug with lifted functions in flows

Only the chain line changes:
import { lift, chain } from 'hyperlane'

const ar = [ 'a', 'b', 'c']
const peek = lift(x => {console.log(x); return x})
chain(peek, peek, peek)(ar)

(produces no output)
import { lift, chain } from 'hyperlane'

const ar = [ 'a', 'b', 'c']
const peek = lift(x => {console.log(x); return x})
chain(peek(), peek, peek)(ar)

[ 'a', 'b', 'c' ]
[ 'a', 'b', 'c' ]
[ 'a', 'b', 'c' ]
import { lift, chain } from 'hyperlane'

const ar = [ 'a', 'b', 'c']
const peek = lift(x => {console.log(x); return x})
chain(peek, peek(), peek)(ar)

[Function]
[Function]

nice catch!.. This inconsistency have been bugging me for a while, but I wasn't able to quite narrow it down to a simple test case

Should be fixed

Looks good


Outbound channel shouldn't unmute at the end of log rotation if it was muted due to request by another worker

When a worker completes its log rotation, it currently unmutes everything as part of the completion phase.
If more than one worker is doing rotation at the same time, this can lead to premature unmuting, which breaks safety assumptions around watermarks in the log file.

We no longer use the old log rotation approach.  Closing.


[Fabric 1.20.1] Indium/Culling incompatibility.

Whenever a mod that culls blocks is loaded, the slabs and stairs placed differently than vanilla appear invisible, and when broken, have missing texture particles. (Additionally, I played on Quilt Loader 0.53, if that has anything to do with this.)

that sounds like the mods might be messing with how block models are grabbed from the modelshaper. which is odd, since they shouldn't need to. I've been working on some neat stuff off the repository relating to the block models though, so I won't investigate this until after it's done.

Coolio

I just checked this morning and i think i just needed to update my stuff. Sorry for opening this issue.


💡 [FEATURE] - Add Assembly language complete resources.

Idea Contribution

[X] I have read all the feature request issues.
[X] I'm interested in working on this issue
[X] I'm part of GSSOC organization

Explain feature request
No response
Explain your solution
I want to add assemble lang programming section complete resources..
Any alternative approaches/features
No response
Additional Context
No response

You can work on this if you want


Removed the CRON job from Docker publish action

Do we really need to have a cron job for the Docker publish action?

I quite like having the nightly builds, they've caught quite a few dependency errors before if deps aren't following sermver it gives a decent heads up.


[QueryStringStatic] service

closes #2673
This is WIP (no updated documentation yet) and is based on PR #3012

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @mbarkhau!

:book:

Thanks for contributing to our documentation. We :heart: our documentarians!

  Generated by :no_entry_sign: dangerJS against 45a9b72d78fe3673b1ad7fc4edbdb5a925d2fa99

I updated the PR title so the service tests will run starting with the next build.

So I guess the next step here is to update the shields.io page and add documentation for this. Should it be more like the endpoint badge, on a separate page, or should it be a widget similar to the current static badge, or something else?
Maybe the most simple thing would be to add another output url on the current static widget.

Maybe the most simple thing would be to add another output url on the current static widget.

Yea, seems fine to do the simple thing for now.
That text is in flight in #3032 so perhaps best to get that merged first.

3aca1ef adds a snippet on the front page, which looks like this

I'm not sure how you want to treat the new static urls vs the old ones. With the commit f9b5c20 I've updated the fronted to use the /static/v1.svg urls everywhere, which may be a bit much, idk.
In order to keep the history linear I usually like to do git rebase and assuming nobody else is working on this branch I then do git push --force. Since this branch has merge conflicts with master again, how would you like that to be resolved? Should I merge master to this branch and give up on the linear history?

In order to keep the history linear I usually like to do git rebase and assuming nobody else is working on this branch I then do git push --force. Since this branch has merge conflicts with master again, how would you like that to be resolved? Should I merge master to this branch and give up on the linear history?

We keep PRs to single units of work and use a squash merge workflow, and as a result can optimize the history in PRs for people who are following the PRs. So please merge master into your branch, and we'll squash it down when it's done.

Thanks for carrying this forward!

3aca1ef adds a snippet on the front page, which looks like this

Looks good!
I'd like to ship a second version of the URL path version that is a bit friendlier. But this feature is intended for (1) easy programmatic generation and (2) complicated text that is otherwise hard to escape. So, could you put the new text below instead of above?
Also I don't think there's a need to label it beta. We've been thinking about this for a long time and I'm feeling confident in the changes you're making. 😁

I'm not sure how you want to treat the new static urls vs the old ones. With the commit f9b5c20 I've updated the fronted to use the /static/v1.svg urls everywhere, which may be a bit much, idk.

Again some of the code you're changing is in flight in #3032; so apologies, but I think we need to land that first. I'd lean toward using the old badge everywhere else because the URLs are more readable than query strings. If we get a more streamlined URL-path version down the line we could switch them over.

I'd lean toward using the old badge everywhere else because the URLs are more readable than query strings.

Sounds reasonable. I'll revert f9b5c20.

I swaped the ordering of the urls and removed the "(beta)" text. Anything else this needs before a merge?

It looks good! Did you merge in the changes from #3032? That should make it quick to merge this after that lands.
The query param changes landed in #3042; I'll leave a comment about that.

This PR is now pending on the merge of #3032 since I merged consolidate-badge-gen.

Thanks for the updates! Will approve and merge when #3032 is in.


No repeats please | Test failing, but console is showing the correct and expected result

I've tested my solution in jsfiddle and for the given test cases, it is working correctly.
When adding my code to FCC, the first case "permAlone("aab") should return a number." is successful and the console shows 2, but fails at permAlone("aab") should return 2.
This happens with the other cases as well:

My code below:
`var permArr = [], usedChars = [];

var permute = function(input) {
  var i, ch;
  for (i = 0; i < input.length; i++) {
    ch = input.splice(i, 1)[0];
    usedChars.push(ch);
    if (input.length === 0) {
      permArr.push(usedChars.slice());
    }
    permute(input);
    input.splice(i, 0, ch);
    usedChars.pop();
  }
  return permArr;
};

function permAlone(str) {
	var chars = str.split('');
	var perms = permute(chars);
  var permStr = [];

  //create array of strings
  var i, temp=[];
  for (i = 0; i<perms.length; i++){
  	temp.push(perms[i].join(''));
  }

  // Test for no repeat
  var uniqueArray = temp.filter(function(elem, pos) {
  	if (/(.)\1+/.test(elem) === false){
    	return elem;
    }
  });

  return uniqueArray.length;
}

`permAlone('abfdefa');``

Using global variables to store function specific things is a bad idea. Please post to the Help Chat if you need further assistance as Github issues are not for challenge help.

I've found a similar case searching through Github issues and was able to apply it.


Fix wording about ack in .NET/C# Client API Guide

Fix 2 things in .NET/C# Client API Guide (https://www.rabbitmq.com/dotnet-api-guide.html#basic-get)

Rename noAck to autoAck
Reference: https://github.com/rabbitmq/rabbitmq-dotnet-client/pull/297

Fix the wording
noAck = false
⇒ no manual acknowledgements = false
⇒ manual acknowledgements = true
Reference: https://github.com/rabbitmq/rabbitmq-dotnet-client/issues/255#issuecomment-323133972

For reference, same guide for Java: https://www.rabbitmq.com/api-guide.html#getting

Thank you!


Send Message to "@channel"

Hello.
I configured integration, but have a huge need to send messages to #xpto_channel and then alert all members with @channel.
I tried to enter the the channel in the message, but it is presented as text, not as a call to the entire channel.
You can implement this function?
Thanks in advance

Hi,
You can highlight everyone in the channel that you send the message to using the following text inside of your message:
<!channel>

which should expand to "@channel" and highlight everyone, per the following Slack documentation:
https://api.slack.com/docs/formatting
Cheers,
Eric


Before pull request

A flow-based framework.
In flow-based programming, applications are defined as networks of black-box components that exchange data across predefined connections. These components can be reconnected to form different applications.
ctapipe-flow executes ctapipe processing modules in a sequantial or multiprocessus environment.
Documentation here: http://jacquemier.github.io/ctapipe/flow/index.html
2 examples provided:

complex  flow-based with fork : examples/flow/switch.json
calibration (based on examples/calibration_pipeline.py  ) examples/flow/calibration.json
Warning: calibration create PDF wtih matplotlib figure. multiprocessus mode only work on Linux.
OsX isssue : "the_process_has_forked_and_you_cannot_use_this_corefoundation_functionality___you_must_exec()"

Is the forking problem something internal to the multiprocessing module, or do you call fork() explicitly?
It probably won't make a difference, but multiprocessing is slowly being replaced by the concurrent.futures module, which provides a more common API for multi-process/threading/etc.  I would imagine the implementation is pretty much the same though.

The forking problem is  internal to the multiprocessing. I do not call fork() explicitly,

It seems there is a pull request in matplotlib to fix this, so it may not be an issue soon:
https://github.com/matplotlib/matplotlib/pull/6637

in any case, since this doesn't conflict with other modules, I will merge it in so people can play with it at the next workshop.

I currently study python Dask framework. http://dask.pydata.org
I will try to prepare a comparative with my own development version for the next workshop.


MINOR: Typographical error corrected in the StreamsBuilder Javadoc.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/6887/
Test PASSed (JDK 7 and Scala 2.11).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/6873/
Test FAILed (JDK 8 and Scala 2.12).

cc @mjsax  for review.

LGTM. Merged to trunk.


Eigen as submodule

Would be nice, using hg-git: http://hg-git.github.io/
So we don't need to package eigen directly in the source code, we can track their devel branch, ....
Exists as package in your favorite linux distro (https://packages.debian.org/sid/vcs/mercurial-git), but a bit more work is required for windows users (https://github.com/cosmin/git-hg#dependencies)
-> considering multi-plateform support, not sure it is the best solution. What do you think ?

we could use this , as suggested by charly :  https://github.com/RLovelett/eigen

Sounds good.

Do we agree to restrict on the latest release branch ?
https://github.com/RLovelett/eigen/tree/branches/3.3

Fixed by 62e1712fb1d633f6ab14b953c89e0c6b6b6ecc95. Closing


Add: PR Template, CONTRIBUTING.md, and LICENSE

GitHub Issue: https://github.com/Islandora-CLAW/CLAW/issues/1173 and https://github.com/Islandora-CLAW/CLAW/issues/1188 and https://github.com/Islandora-CLAW/CLAW/issues/1202
What does this Pull Request do?

Adds pull request template
Adds a CONTRIBUTING.md that conforms to the Islandora 8 standard
Adds a LICENSE file matching the license cited in the readme.

How should this be tested?

Verify the pull request template is suggesting the right group and looks like the one from here
Check CONTRIBUTING.md against the one from the core CLAW repo.
Check that the LICENSE matches the one listed in the readme.

Interested parties
@Islandora-Devops/committers

Travis failed on Build crayfish code including dependencies:
Loading composer repositories with package information
Installing dependencies from lock file
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Installation request for ocramius/proxy-manager 2.2.2 -> satisfiable by ocramius/proxy-manager[2.2.2].
    - ocramius/proxy-manager 2.2.2 requires php ^7.2.0 -> your PHP version (7.1.30) does not satisfy that requirement.
  Problem 2
    - ocramius/proxy-manager 2.2.2 requires php ^7.2.0 -> your PHP version (7.1.30) does not satisfy that requirement.
    - doctrine/migrations v1.8.1 requires ocramius/proxy-manager ^1.0|^2.0 -> satisfiable by ocramius/proxy-manager[2.2.2].
    - Installation request for doctrine/migrations v1.8.1 -> satisfiable by doctrine/migrations[v1.8.1].

Hrm... not testing on 7.2? I'll take a look.
On Jul 2 2019, at 1:05 pm, Rosemary Le Faive<EMAIL_ADDRESS>wrote:

Travis failed on Build crayfish code including dependencies:
Loading composer repositories with package information
Installing dependencies from lock file
Your requirements could not be resolved to an installable set of packages.
Problem 1

Installation request for ocramius/proxy-manager 2.2.2 -> satisfiable by ocramius/proxy-manager[2.2.2].
ocramius/proxy-manager 2.2.2 requires php ^7.2.0 -> your PHP version (7.1.30) does not satisfy that requirement.
Problem 2
ocramius/proxy-manager 2.2.2 requires php ^7.2.0 -> your PHP version (7.1.30) does not satisfy that requirement.
doctrine/migrations v1.8.1 requires ocramius/proxy-manager ^1.0|^2.0 -> satisfiable by ocramius/proxy-manager[2.2.2].
Installation request for doctrine/migrations v1.8.1 -> satisfiable by doctrine/migrations[v1.8.1].

—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub (https://link.getmailspring.com/link/2D922FC1-B186-40D9-8AA1-779B36ADD3A2@getmailspring.com/0?redirect=https%3A%2F%2Fgithub.com%2FIslandora-Devops%2Fansible-role-crayfish%2Fpull%2F26%3Femail_source%3Dnotifications%26email_token%3DAE6PSH52R6DSZISU6U3RE23P5N4GNA5CNFSM4H44USI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZBYSNI%23issuecomment-507742517&recipient=cmVwbHkrQUU2UFNIN1hNR0lRTEhPTjdCSVRPWUYzRkNaV05FVkJOSEhCWEhJSlFZQHJlcGx5LmdpdGh1Yi5jb20%3D), or mute the thread (https://link.getmailspring.com/link/2D922FC1-B186-40D9-8AA1-779B36ADD3A2@getmailspring.com/1?redirect=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAE6PSH7Y47YDB3QS23LZDEDP5N4GNANCNFSM4H44USIQ&recipient=cmVwbHkrQUU2UFNIN1hNR0lRTEhPTjdCSVRPWUYzRkNaV05FVkJOSEhCWEhJSlFZQHJlcGx5LmdpdGh1Yi5jb20%3D).

I think this one will close out all three issues 😄

ping @whikloj - it looks like the PHP version of 7.1 that was added in May is no longer working. Do you know why we pinned to a specific PHP version and if we have to, can we bump it to 7.2?

We pinned a specific version as the default Ubuntu box was installing PHP 7.0 and we wanted to have 7.1.
You can alter the php_versions variable to 7.2 now.
I tried to set it in one place and have it propagate out but it didn't work so I just left it defined in multiple locations.


Resubmitting

Checklist

[x] I ran npm test locally and it passed without errors.

[x] I only edited the _data/pixels.json file.

[x] I entered the username in the pixels.json that I'm also using to create this pull request.
[x] I acknowledge that all my contributions will be made under the project's license.

It keeps thinking that I also added the line for user PJijin, which is not me - I've tried editing the json file in Atom and in vim, not sure what I'm doing wrong... Opensuse Leap 15.1 latest with pretty standard config - git version 2.16.4 - Node v10.16.3 - (both from he main Leap15.1 rpm repository)

OK, I noticed in the diff that that there was a re-ordering of the lines surrounding user PJijin, so I resubmitted, but edited to remove the re-ordering, but it doesn't seem to have helped.
I'm not giving up, but I'll have to think about this!

Closing as a duplicate


Update docker file apache-http-php software versions

Previous version's vc11 and php cannot be downloaded.

@neilpeterson

Hey @mrdotmoon, have you been able to build and run an image from the dockerfile? IT built find for me, but is throwing an error when hitting the http endpoint.
I've only done a very quick test, and have not dug into any potential. Issue. I can look at it as soon as I have some time.

Warning: Unknown: failed to open stream: No such file or directory in Unknown on line 0

Fatal error: Unknown: Failed opening required 'C:/www/index.php' (include_path='.;C:\php\pear') in Unknown on line 0

Yes, I build it and find the same issue.. After some investigation, if I recreate the folder c:\www in container after running the container, the issue will be gone. So I believe it maybe possible bug for windows container.. I have not compared the ACLs that created in dockerfile and directly in container, but I think it may be the root cause.

Yep, that lines up with a know ACLs bug. I will check status and also see if there is a potential work around for the dockerfile.

@mrdotmoon I'm going to merge this in. The issue is related to the resulting container and not the Dockerfile. This sample was built in TP4, the issues is specific to TP5. We have engineers looking at the bug now.
Thanks.


Redundant documentation in interface+implementation, or errors

With an interface defining a method and a class implementing it, both must have nearly identical doc blocks. If the implementation has no doc block on the method, or it's missing the summary or @param tags, phpDocumentor2 sees that as an error (in the CLI, with a nasty looking red background, and on the "Errors" report page).
Errors notwithstanding, the doc block from the interface does show up in the generated documentation for the implementation, as it should. As far as I can see, there is no way to silence this type of error.
Is my understanding correct that I have to choose between maintaining two largely identical copies of a method doc block, or living with lots of error messages? When there are lots of non-critical warnings, they tend to get ignored, and any legitimate warning will probably go unnoticed.
/** The IThing interface summary. */
interface IThing
{
    /**
     * Method summary (in interface).
     *
     * Method description (in interface).
     *
     * @param  string  $foo  a parameter
     * @return  string  some string
     */
    public function methodOne($foo);
}

/** The Thing class summary. */
final class Thing implements IThing
{
    // need at least summary + @param here
    public function methodOne($foo) { /*...*/ }
}

The same basic question also applies to inherited properties and methods.

With @inheritdoc you can import the summary. But there is no way to copy all tags. We will have a look if and how we can achieve this.

I am struggling with the same problem. Since all methods should have a docblock, it would be nice to simply have an "@inherit" annotation that inherits the docblock of the parent. I'm not sure if this is considered in PSR-5?
In PSR-5 there is a part about inheritance but it seems a bit too unclear to me. I'm not sure if @inheritDoc inherits only the summary (because {@inheritDoc} does) or if inherits the other tags as well?
https://github.com/php-fig/fig-standards/pull/169/files

I checked that for you. But I can't find anything in de code of phpdocumentor about the @inheritDoc tag. So I'm not sure how this works. {@inheritDoc}  is implemented.
Good to know is that there is a difference in the implementation. Between summary and description. Summary is concidered to be a single line. So when you place {@inheritDoc} it will just get that line. In the description the tag is replaced with the description of the parent element.
@inheritDoc takes both summary and description.
@inherit sounds like a good idea. But here will be situations where you might need to modify some of the tags or add others. So we will need to define how this should work. For all supported tags.

For PSR-5 we have had discussions with the maintainers of Doctrine on how to approach this issue.
Historically {@inheritDoc} could only be used in the description and would import the parent description into that location. Summaries don't support the braced inline tag style and if a summary was omitted then the use of {@inheritDoc} was considered to be invalid according to the specs of phpDocumentor.
Since phpDocumentor 1 came out Doctrine and Symfony have adopted the use of {@inheritDoc} to mean 'inherit everything from the parent element' when used on its own in a DocBlock.
Like this:
/**
 * {@inheritDoc}
 */

With phpDocumentor 2 we have adopted that behaviour to prevent confusion with users that produced that style of documentation.
When I wrote PSR-5 I had discussions with Ocramius if we could somehow 'rectify' the inconsistency of {@inheritDoc}'s usage as the body of the DocBlock and we came up with the tag @inheritDoc.
Tags are allowed to be used without a Summary and Description according to the PHPDoc syntax and @inheritDoc would then mean 'apply inheritance as if no DocBlock is present'.


install instructions on releases page

It would be nice if in each release there were instructions on how to easily install, for example coreos does this well with etcd: https://github.com/coreos/etcd/releases

@jfrazelle The most recent release gets close to doing this: https://github.com/kubernetes/helm/releases/tag/v2.0.0-alpha.4
However, the script is a little broken, at least for me, I think it should be:
export HELM_OS=darwin; wget https://github.com/kubernetes/helm/releases/download/v2.0.0-alpha.4/helm-v2.0.0-alpha.4-$HELM_OS-amd64.tar.gz && tar -zxvf helm-v2.0.0-alpha.4-$HELM_OS-amd64.tar.gz && cd $HELM_OS-amd64

cc @technosophos

Coping my comments in #1184:

Consider adding a &&:
$ HELM_OS=linux && wget https://github.com/kubernetes/helm/releases/download/v2.0.0-alpha.4/helm-v2.0.0-alpha.4-$HELM_OS-amd64.tar.gz && tar -zxvf helm-v2.0.0-alpha.4-$HELM_OS-amd64.tar.gz && cd $HELM_OS-amd64

or simply remove $HELM_OS:
$ wget https://github.com/kubernetes/helm/releases/download/v2.0.0-alpha.4/helm-v2.0.0-alpha.4-linux-amd64.tar.gz && tar -zxvf helm-v2.0.0-alpha.4-linux-amd64.tar.gz && cd linux-amd64

@technosophos can we do this for alpha.5. We really should fixup alpha.4 too.

Fixed on Alpha.4, and will do the same with Alpha.5.
I just used @janetkuo 's version (which was essentially @philips's version). Thanks!


Add in_progress and queued to WorkflowJobStepConclusion enums

Resolves #169

Behavior
Before the change?
When a workflow_job.completed with a failed conclusion event is deserialized it fails because steps can have in_progress and queued status which are not included in the WorkflowJobStepConclusion enums

After the change?
The in_progress & queued  status steps can be deserialized for a workflowflow completed event with a failed conclusion and steps that are in_progress or queued.

Other information

Additional info
Pull request checklist

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)
[x] Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

[ ] Yes (Please add the Type: Breaking change label)
[x] No

If Yes, what's the impact:

N/A

Pull request type

Please add the corresponding label for change this PR introduces:

Bugfix: Type: Bug
Feature/model/API additions: Type: Feature
Updates to docs or samples: Type: Documentation
Dependencies/code cleanup: Type: Maintenance

@mattdjones do you know if there's documentation somewhere specifying the possible states here? I can't seem to find it, unfortunately.

I believe they may have been taken from @octokit/webhooks, and those were taken from  some examples submitted from real payloads.

Hmm, I'm not seeing it here; am I looking in the wrong place?

The PR addresses the conclusion for the steps in a WorkflowJob event.
Not to be confused with the conclusion for the WorflowJob itself
https://github.com/octokit/webhooks/blob/master/payload-schemas/api.github.com/common/workflow-step-completed.schema.json
https://github.com/octokit/webhooks/blob/master/payload-schemas/api.github.com/common/workflow-step-in_progress.schema.json

hey @kfcampbell sorry I can't the staes detailed in the docs

Understood, thank you both!

hey @kfcampbell  & @wolfy1339  do I need to add anything else to get this merged?

I'm not a maintainer for the .NET packages, so I cannot help here.
Although, it looks fine to me.

thanks @kfcampbell  no problem, do you mean add it to this PR description?


[WIP] added support for azure devops

[x] Added support to detect X-Azure-DevOps-EventType in request header
[x] Parse payload for push and pull event
[x] Created connection with client using pat
[x] Get the files inside .tekton directory
[x] Ran a successful pipelinerun
[x] Set the status; currently tested pending/failed/successful on push
[x] Write implementation of missing methods (acl.go, CreateToken, GetFileInsideRepo)
[x] Write test cases
[ ] Do complete e2e testing on both pull and push

/ok-to-test

/test go-testing

@chmouel any update on review?

@chmouel we will appreciate if you can please review it; as we would like this be merged into main branch! can you confirm when you can review it?

@chmouel any updates on this? we are really surprised how poor the response time is! I will appreciate if we can hear back

@chmouel any updates on this PR? It’s quite frustrating that we've been trying to follow up without receiving any response. We would appreciate it if you could let us know your plans for this PR.

@chmouel any updates on this? We would like it to be merged


SCD bindings do not support custom/vendor customization elements

I wrote a number of XJC plugins, some of these plugins can be customized via binding files.
For instance, I can do the following:
<jaxb:bindings version="1.0" xmlns:jaxb="http://java.sun.com/xml/ns/jaxb" 	xmlns:xs="http://www.w3.org/2001/XMLSchema" 	xmlns:jsonix="http://jsonix.highsource.org/customizations" 	jaxb:extensionBindingPrefixes="jsonix">

	<jaxb:bindings schemaLocation="w3c/1999/xlink.xsd" node="/xs:schema">
		<jsonix:packageMapping packageName="org.hisrc.w3c.xlink.v_1_0" spaceName="XLink_1_0"/>
	</jaxb:bindings>
</jaxb:bindings>

If my Jsonix plugin is activated, XJC will know that jsonix:packageMapping is a customization element for Jsonix (plugin API allows saying what your customization namespace URI is and which local names you expect).
SCD seems to be a more advanced way to address schema elements. I.e.
<jaxb:bindings scd="x-schema::xlink" xmlns:xlink="http://www.w3.org/1999/xlink" ... />

addresses the XLink schema logically via namespace URI. Forget the files, this is perfect. Much more versatile than schemaLocation and node. I guess episodes would not work without SCD in first place. For my scenarios it would for instance help with #1047.
My problem is that SCD does not allow custom elements. So this:
<jaxb:bindings version="1.0" xmlns:jaxb="http://java.sun.com/xml/ns/jaxb" 	xmlns:xs="http://www.w3.org/2001/XMLSchema" 	xmlns:jsonix="http://jsonix.highsource.org/customizations" 	jaxb:extensionBindingPrefixes="jsonix">

	<jaxb:bindings scd="x-schema::xlink" xmlns:xlink="http://www.w3.org/1999/xlink"> 		<jsonix:packageMapping packageName="org.hisrc.w3c.xlink.v_1_0" spaceName="XLink_1_0"/>
	</jaxb:bindings>
</jaxb:bindings>

I get the following error:
[ERROR] Error while parsing schema(s).Location [ file:/C:/Projects/workspaces/ogc-ng/w3c-schemas/xlink/1999/src/main/resources/xlink-v_1_0.jsonix.xjb{8,89}].
org.xml.sax.SAXParseException; systemId: file:/C:/Projects/workspaces/ogc-ng/w3c-schemas/xlink/1999/src/main/resources/xlink-v_1_0.jsonix.xjb; lineNumber: 8; columnNumber: 89; cvc-elt.1: Cannot find the declaration of element 'jsonix:packageMapping'.

Clearly, SCD does not process custom configuration elements whereas schemaLocation plus node do process.

+1


Linking issues on WSL Ubuntu.

Introduction
I'm running on the WSL version of Ubuntu with all the required dependencies and uses the toolchain from scons toolchain . When I do a scons run there are issues when linking.
The logs
$ scons run
scons: Reading SConscript files ...
scons: done reading SConscript files.
scons: Building targets ...
Assembling [src/bootloader/stage1/boot.asm]
Linking    [build/i686_debug/stage1_fat32/stage1.bin]
Assembling [src/bootloader/stage2/crti.asm]
Compiling  [src/bootloader/stage2/main.cpp]
Compiling  [src/bootloader/stage2/cpp/NewDelete.cpp]
Compiling  [src/bootloader/stage2/mem/Stage2Allocator.cpp]
Compiling  [src/bootloader/stage2/arch/i686/BIOSDisk.cpp]
Assembling [src/bootloader/stage2/entry.asm]
Assembling [src/bootloader/stage2/arch/i686/Disk.asm]
Compiling  [src/libs/core/Assert.cpp]
Compiling  [src/libs/core/Debug.cpp]
Compiling  [src/libs/core/Memory.cpp]
Compiling  [src/libs/core/String.cpp]
Compiling  [src/libs/core/cpp/CppSupport.cpp]
Compiling  [src/libs/core/dev/RangeBlockDevice.cpp]
Compiling  [src/libs/core/dev/TextDevice.cpp]
Compiling  [src/libs/core/fs/FATFileSystem.cpp]
Compiling  [src/libs/core/fs/FileSystem.cpp]
Compiling  [src/libs/core/arch/i686/E9Device.cpp]
Compiling  [src/libs/core/arch/i686/VGATextDevice.cpp]
Compiling  [src/libs/core/fs/fat/FATFile.cpp]
Compiling  [src/libs/core/fs/fat/FATFileEntry.cpp]
Assembling [src/libs/core/MemoryAsm.asm]
Assembling [src/libs/core/arch/i686/IO.asm]
Archiving  [build/i686_debug/libs/core/libcore.o]
Ranlib     [build/i686_debug/libs/core/libcore.o]
Assembling [src/bootloader/stage2/crtn.asm]
Linking    [build/i686_debug/stage2/stage2.elf]
build/i686_debug/stage2/main.o:(.rodata._ZTV15CharacterDevice[vtable for CharacterDevice]+0x10): undefined reference to `__cxa_pure_virtual'
build/i686_debug/stage2/main.o:(.rodata._ZTV15CharacterDevice[vtable for CharacterDevice]+0x14): undefined reference to `__cxa_pure_virtual'
build/i686_debug/stage2/mem/Stage2Allocator.o:(.rodata._ZTV9Allocator[vtable for Allocator]+0x8): undefined reference to `__cxa_pure_virtual'
build/i686_debug/stage2/mem/Stage2Allocator.o:(.rodata._ZTV9Allocator[vtable for Allocator]+0xc): undefined reference to `__cxa_pure_virtual'
build/i686_debug/stage2/arch/i686/BIOSDisk.o:(.rodata._ZTV11BlockDevice[vtable for BlockDevice]+0x10): undefined reference to `__cxa_pure_virtual'
build/i686_debug/stage2/arch/i686/BIOSDisk.o:(.rodata._ZTV11BlockDevice[vtable for BlockDevice]+0x14): more undefined references to `__cxa_pure_virtual' follow
collect2: error: ld returned 1 exit status
scons: *** [build/i686_debug/stage2/stage2.elf] Error 1
scons: building terminated because of errors.$ scons run
scons: Reading SConscript files ...
scons: done reading SConscript files.
scons: Building targets ...
Assembling [src/bootloader/stage1/boot.asm]
Linking    [build/i686_debug/stage1_fat32/stage1.bin]
Assembling [src/bootloader/stage2/crti.asm]
Compiling  [src/bootloader/stage2/main.cpp]
Compiling  [src/bootloader/stage2/cpp/NewDelete.cpp]
Compiling  [src/bootloader/stage2/mem/Stage2Allocator.cpp]
Compiling  [src/bootloader/stage2/arch/i686/BIOSDisk.cpp]
Assembling [src/bootloader/stage2/entry.asm]
Assembling [src/bootloader/stage2/arch/i686/Disk.asm]
Compiling  [src/libs/core/Assert.cpp]
Compiling  [src/libs/core/Debug.cpp]
Compiling  [src/libs/core/Memory.cpp]
Compiling  [src/libs/core/String.cpp]
Compiling  [src/libs/core/cpp/CppSupport.cpp]
Compiling  [src/libs/core/dev/RangeBlockDevice.cpp]
Compiling  [src/libs/core/dev/TextDevice.cpp]
Compiling  [src/libs/core/fs/FATFileSystem.cpp]
Compiling  [src/libs/core/fs/FileSystem.cpp]
Compiling  [src/libs/core/arch/i686/E9Device.cpp]
Compiling  [src/libs/core/arch/i686/VGATextDevice.cpp]
Compiling  [src/libs/core/fs/fat/FATFile.cpp]
Compiling  [src/libs/core/fs/fat/FATFileEntry.cpp]
Assembling [src/libs/core/MemoryAsm.asm]
Assembling [src/libs/core/arch/i686/IO.asm]
Archiving  [build/i686_debug/libs/core/libcore.o]
Ranlib     [build/i686_debug/libs/core/libcore.o]
Assembling [src/bootloader/stage2/crtn.asm]
Linking    [build/i686_debug/stage2/stage2.elf]
build/i686_debug/stage2/main.o:(.rodata._ZTV15CharacterDevice[vtable for CharacterDevice]+0x10): undefined reference to `__cxa_pure_virtual'
build/i686_debug/stage2/main.o:(.rodata._ZTV15CharacterDevice[vtable for CharacterDevice]+0x14): undefined reference to `__cxa_pure_virtual'
build/i686_debug/stage2/mem/Stage2Allocator.o:(.rodata._ZTV9Allocator[vtable for Allocator]+0x8): undefined reference to `__cxa_pure_virtual'
build/i686_debug/stage2/mem/Stage2Allocator.o:(.rodata._ZTV9Allocator[vtable for Allocator]+0xc): undefined reference to `__cxa_pure_virtual'
build/i686_debug/stage2/arch/i686/BIOSDisk.o:(.rodata._ZTV11BlockDevice[vtable for BlockDevice]+0x10): undefined reference to `__cxa_pure_virtual'
build/i686_debug/stage2/arch/i686/BIOSDisk.o:(.rodata._ZTV11BlockDevice[vtable for BlockDevice]+0x14): more undefined references to `__cxa_pure_virtual' follow
collect2: error: ld returned 1 exit status
scons: *** [build/i686_debug/stage2/stage2.elf] Error 1
scons: building terminated because of errors.
``

There is an easy fix described in this article. Basically, __cxa_pure_virtual  is a function that gets called if a pure virtual function is called (but the compiler should complain about that and not allow it).
Assuming you are in the cpp-refactoring branch, just add this to src/libs/core/cpp/CppSupport.cpp:
EXPORT void __cxa_pure_virtual()
{
    arch::i686::Panic();
}

@chibicitiberiu Compiling now works but I'm having the same problem in #36

You mean the missing --offset parameter? Usually that means your mkfs.fat tool is too old. In some distros it's named mkfs.vfat, maybe that works for you. Otherwise, you could try to modify the script so that it creates a file for the partition, and then copies it into the image file at the correct offset. Alternatively, you could use losetup to attach the image file as a loop device, and then simply do mkfs.fat /dev/loopNp1 (replace N with whatever losetup gives you).


Create unique context for each item in a collection?

We have an unusual use case where having this functionality would be useful to us:
module Draper
  class CollectionDecorator
    module UniqueContext
      def decorate_item(item)
        item_decorator.call(item, context: context.clone)
      end
    end

    prepend UniqueContext
  end
end

As you can see we've currently monkey patched. Would there be any interest in a PR?

We have an unusual use cache…

I agree that it's not a common case. That's why pulling this in seems unreasonable. It will slow down every one else's code and increase memory footprint for no reason.
Moreover, a context that's not shared seems counter intuitive for me 🤔 It looks like you want it to modified on per item basis that makes it something more than a collection context, IMO.

That's a fair comment. It's been over 4 years since I raised this and with four more years of experience mutating the context doesn't seem right to me either