Pressable has unchangeable delay for opacity effect (onPressIn)

Description
The <Pressable /> component has an unchangeable delay between pressing and visual feedback.
See:

Pressable
TouchableOpacity

As you can see, the TouchableOpacity has instant visual feedback when I press it, where as the Pressable takes about 120ms (wild guess).
I though https://github.com/facebook/react-native/commit/49b2a6e9cd95b74375f51fda87b87430073ec20e should fix this delay?
React Native version:
info Fetching system and libraries information...
(node:46144) Warning: Accessing non-existent property 'padLevels' of module exports inside circular dependency
(Use `node --trace-warnings ...` to show where the warning was created)
System:
    OS: macOS 10.15.5
    CPU: (16) x64 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
    Memory: 6.86 GB / 32.00 GB
    Shell: 5.7.1 - /bin/zsh
  Binaries:
    Node: 14.4.0 - /usr/local/bin/node
    Yarn: 1.22.4 - /usr/local/bin/yarn
    npm: 6.14.6 - /usr/local/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  Managers:
    CocoaPods: 1.9.3 - /usr/local/bin/pod
  SDKs:
    iOS SDK:
      Platforms: iOS 13.5, DriverKit 19.0, macOS 10.15, tvOS 13.4, watchOS 6.2
    Android SDK:
      API Levels: 25, 28, 29
      Build Tools: 28.0.3, 29.0.2, 29.0.3, 30.0.0, 30.0.0, 30.0.0
      System Images: android-29 | Google APIs Intel x86 Atom, android-29 | Google Play Intel x86 Atom
      Android NDK: 21.2.6472646
  IDEs:
    Android Studio: 4.0 AI-193.69<IP_ADDRESS>14223
    Xcode: 11.5/11E608c - /usr/bin/xcodebuild
  Languages:
    Java: 1.8.0_252 - /usr/bin/javac
    Python: 2.7.16 - /usr/bin/python
  npmPackages:
    @react-native-community/cli: Not Found
    react: 16.13.1 => 16.13.1
    react-native: 0.63.1 => 0.63.1
  npmGlobalPackages:
    *react-native*: Not Found

Steps To Reproduce
Provide a detailed list of steps that reproduce the issue.

Create <Pressable /> component
Give it an opacity effect with the new style function that supplies the pressed argument
See delay between press and effect

Expected Results
The opacity effect/visual feedback should appear instantly, like on the TouchableOpacity.
Snack, code example, screenshot, or link to a repository:
PressableOpacity.ts:
import React, { useCallback } from 'react';
import { Pressable, PressableProps, PressableStateCallbackType, StyleProp, ViewStyle } from 'react-native';

export interface PressableOpacityProps extends PressableProps {
	disabledOpacity?: number;
}

export type StyleType = (state: PressableStateCallbackType) => StyleProp<ViewStyle>;

export default function PressableOpacity(props: PressableOpacityProps): JSX.Element {
	const { style, disabled, disabledOpacity, ...passThroughProps } = props;

	const getOpacity = useCallback(
		(pressed: boolean) => {
			if (disabled) return disabledOpacity ?? 1;
			else return pressed ? 0.6 : 1;
		},
		[disabled, disabledOpacity],
	);
	const _style = useCallback<StyleType>(({ pressed }) => [style, { opacity: getOpacity(pressed) }], [getOpacity, style]);

	return <Pressable style={_style} disabled={disabled} {...passThroughProps} />;
}

Now just use it:
App.js
export default function App() {
  return (<PressableOpacity style={{ width: 200, height: 30 }} onPress={() => console.log('hello!')} />);
}

Still finding this same problem with 0.63.1, and so far the only work around is to monkey patch it to add a default 0 delay.
Note that I'm seeing the odd delay even with TouchableOpacity, not just with Pressables

@cristianoccazinsp How did you patch the delay on the Pressable?

I have only patched the Touchable components since I didn't migrate to Pressable (yet), but I'm seeing the exact same issue, and I would guess that Touchables are using Pressable behind the scenes?
My only work around was to patch the default props like this:
TouchableOpacity.defaultProps = TouchableOpacity.defaultProps || {};
TouchableOpacity.defaultProps.delayPressIn = 0;
TouchableWithoutFeedback.defaultProps = TouchableWithoutFeedback.defaultProps || {};
TouchableWithoutFeedback.defaultProps.delayPressIn = 0;

I am having the same problem. TouchableOpacity is not using Pressable but Pressabilitty API (The same one TouchableOpacity use). That said, Pressable use a hook to use the API, TouchableOpacity is a Class comoponent so it uses the class alternative to use the API. (i don't know if there is any difference between them). Looking to the source code, I can't find a prop or even a reference to a "press in delay". I hope the add such a prop, otherwise Pressable is not usefull for me.

https://github.com/facebook/react-native/blob/master/Libraries/Pressability/Pressability.js#L76-L79 contains the prop. Changing this manually (e.g.: on a TouchableOpacity) will remove the delay, and everything works as expected. On a  component, you can't set this prop (yet), making it unusable.

#29395 I've created a pull request to add "delayPressIn" to Pressable.

I seem to be getting a delay for onPressIn for all TouchableOpacity, will verify if also affects TouchableWithoutFeedback

I believe the change was made on Pressability API, which all Touchables use. But you can set delayPressIn={0} to fix it.
The problem is with Pressable, cause you can`t change it there.

While not much better than a monkey-patch, you can use patch-package to change these defaults that should globally to everything affected by this recent change.
We recently upgraded from 61.4 to 63.1 and immediately noticed a significant difference in all of our touch handling (we primarily use `TouchableOpacity).
Looks like this delay option was added here with a sensible default of 0. It seems like this default may not have been intended, and it was fixed here.
I'm guessing the idea of this delay is to avoid a technically incorrect visual response of a touch on a child touchable during a scroll swipe, since the touch events first goes to the child before being correctly captured by the parent ScrollView. I agree with this desire, but it seems very difficult to do on the JS side without introducing noticeable delay to nearly all touches, as this thread shows.
Either way it's a significant change from the previous default, unintended or not, that should either by identified on changelog (I checked a few times and didn't see it), or reverted and re-introduced with the change made clear to developers.

@jehartzog That's the only use case that would make sense, and even then an opt-in would be a way better option. If I actually have the use case of the scroll view, I can manually increase the pressable's delay instead of the other way around.

This seems like a major regression, especially when navigation is involved.
Buttons don't have a chance to highlight before new screens render, making the entire interface feel static and non interactive.
Note that we don't even use Pressable at all, just react-native-paper and react-navigation. Any UI elements with an onPress that navigate somewhere don't highlight properly since updating to RN 0.63.1. On RN 0.62 it was fine.
Adding delayPressIn={0} to react-native-paper buttons (which use TouchableHighlight or TouchableNativeFeedback behind the scenes) fixes it. But this is nonetheless a major regression.
Perhaps @yungsters might know more about this?

Thanks for the tag, @andreialecu.
I'd like to share some history, the purpose of the delay, what changed recently, and what I propose that we do next.
The default "press in" delay of 130ms was always in Touchable.Mixin, but it was accidentally always overridden to zero by TouchableWithoutFeedback, et al.
The purpose of this delay is to prevent accidental activations when a user initiates a scroll gesture. For example, if you have a <ScrollView> and a <Pressable> within it, we do not want the <Pressable>'s "pressed" style to be displayed if the user only happened to press it as the start of a scrolling / swiping gesture. The 130ms delay creates enough time for the <ScrollView> to emit a cancel event if a scroll gesture is detected.
Keep in mind that when a "press out" is detected within the 130ms, we immediately fire onPressIn and onPressOut. However, as mentioned above, we still have a problem in which a user who quickly taps an interactive element does not experience any visual feedback. This is because when onPressIn and onPressOut fire instantaneously, the onPressIn visual side effect is not visible. To fix this, we introduced a minimum press duration so that onPressOut will always fire at least 130ms after onPressIn (to give people time to see the visual feedback of the element being pressed).
The fix for preserving the default press in duration was only intended for <Pressable>. But when TouchableWithoutFeedback (et al) was refactored to use Pressability, I forgot to inherit the original bug. We can fix that.
There is still the remaining question of what the default behavior for <Pressable> should be. I recognize the concerns around unnecessary delays, but I also want to highlight the purpose of the delay (to avoid accidental activations on scroll gestures). We could certainly introduce a delayPressIn prop to <Pressable>, but I think we should avoid it if possible because I believe the only use case would be setting delayPressIn={0}.
One thing we could do is change <Pressable> to default to 130ms only when nested within a <ScrollView>. The downside of this approach is that if the scrolling container is rendered by a parent view (outside of React Native), <Pressable> may not know about that and will not behave correctly.
Curious to hear what everyone thinks. Thanks!

@yungsters Thanks for writeup.
There are many cases where having this press in delay will cause undesired impacts, even if the delay is refactored to intelligently only apply when it detects itself inside a <ScrollView>. Any CTA style button at the bottom of a ScrollView which triggers a navigation event will have no animation response to a touch which immediately triggers a navigation event. If the code is well designed, the transitions animations should begin firing well before this 130ms delay is over. There is no way for the framework to know if a developer is using this element to trigger a navigation transition vs just altering some local UI state, so I can't think of any way to just fix this perfectly for everyone.
I do recognize the desire to avoid the undesired press animation on a touch that ends up captured by the parent ScrollView, but I don't believe there is a way to do this automatically without making it excessively complicated, and requiring each developer to understand how it's implemented in order to avoid the pitfalls.
My recommendation:

Revert back to the pre RN 63 behavior of default delayPressIn={0} for all Pressability derived components, including Pressable.
Add the delayPressIn as an optional prop for Pressable.
Add to the documentation of Pressable that it's recommended to set delayPressIn={130} for Pressable components inside of ScrollViews, and the reason for doing so. Have a line in there that mentions they may want to avoid this for actions that trigger screen transitions.

Developers who care to actually clean up their UI as much as possible will be able to opt-in to this when needed, and there are no chances of missing the much more important onPress animation on the pressed component itself. I'd much rather get the extra onPress animation briefly on something I'm scrolling with, than risk pressing on something and getting no visual response.
If you do decide to add the behavior to auto apply delayPressIn={130} when inside ScrollView, this should be mentioned in docs (and not just source code) so developers are warned that if they fire navigation events from this, they will not get the expected onPress animation.

One thing we could do is change  to default to 130ms only when nested within a . The downside of this approach is that if the scrolling container is rendered by a parent view (outside of React Native),  may not know about that and will not behave correctly.

I'm not sure this would help. In my experience most pressables would be nested inside ScrollViews.
The most noticeable issue I saw from the added delay in 0.63 was that TouchableHighlights that were rendered as list items were not changing their background prior to triggering a navigation somewhere else. Since they were already in a FlatList, this fix wouldn't help in that case and I would still need to set delayPressIn={0}.
It would also make it inconsistent and I feel users wouldn't understand what's going on.
I have been looking at how other apps do it for a bit, and I noticed that in Outlook for iOS for example, when you tap an email, there's a slight delay (several miliseconds) before it navigates to the screen that shows the email. It's enough time to show visual indication that you tapped on something. And there are no "accidental activations" when scrolling.
Note that I have no experience with Pressable yet, so I'm writing this from a Touchable* perspective.
How about something like this:

When the user releases the tap, the Touchable*'s visuals are immediately updated to show feedback of the tap.
A very small amount of time later (timeout of 10ms? requestAnimationFrame?), onPress is called.

Would this not work?

Thanks for the thoughtful (and extremely prompt) responses.
Let me first respond to @andreialecu. Your realization that onPress is "delayed" in Outlook for iOS begins to touch upon a pretty fundamental disconnect between how React Native (and websites) handle touch feedback for navigation, and how Apple's Human Interface Guidelines handles touch feedback for navigation. It isn't something we can resolve with only changes to Pressable, but I do believe we need to eventually cross that road. (The gist of the guidelines is that the touch feedback should deactivate after the navigation has been reversed / popped.)
As for next steps, we feel pretty strongly that the delay should be the new default in Pressable. The reason for this default is that someone who is testing a new interactive user interface is much more likely to notice that the touch feedback is delayed as opposed to testing whether the new interactive element accidentally triggers during a scroll or swipe gesture. But when they realize and want to override that delay, they should be able to do so (or learn why it exists and maybe leave it).
If this makes sense, my proposal is the following:

Remove the default 130ms delay from Pressability (which affects TouchableWithoutFeedback, Pressable, etc.).
Change Pressable to introduce the 130ms delay when it is enclosed within a ScrollView.
Change Pressable to introduce a new prop, pressDelay?: ?('default' | 'none'). When set to none, there will be no press delay (regardless of whether it is enclosed within a ScrollView).

As a net effect, TouchableWithoutFeedback and its composing libraries will continue to work as they did before. However, Pressable will start with the new behavior (delay by default in ScrollView) but can be configured otherwise (to have no delay).
Does this seem reasonable?

Would it not work to keep the delay as it is and add an additional delay before onPress as per my suggestion above? That should theoretically give it enough time to render with the active state before the handler issues the navigation.

@andreialecu We do not actually want to delay the navigation, though. That would make the end user experience worse by actually delaying the navigation and initialization of the next surface.

@yungsters I'm a fan of your proposal, as it is likely to improve future UI without requiring a full audit of existing TouchableWithoutFeedback uses to ensure that the onPress animation is still working as expected. Pressable is a far newer addition and unlikely to lead to large amounts of regressions in existing code bases.

@yungsters would it be noticeable though? If it can be made fast enough that onPress triggers just immediately after the tap is released and the element is highlighted it shouldn't make much difference.
In my experience react native click handlers actually somehow feel too fast compared to other (native) apps when initiating navigation (using react-navigation). In other apps there seems to be an additional delay of several milliseconds (10ms?) which I associated with them waiting to ensure the feedback is displayed.

@yungsters Here's a possibly better explanation since I was on mobile yesterday:
Scenario A:

Tap is detected, the 130 ms timer starts.
If tap is released sooner than 130 ms, the active state renders briefly (1 frame)
onPress is called, and the app can trigger the navigation.

Scenario B

Tap is detected, the 130 ms timer starts.
If the tap is held for longer, the 130 ms timer triggers and the active state renders.

I think scenario A is preferrable for when pressables are nested inside ScrollViews.
pressDelay: "default" can be kept to add the extra 1 frame delay between step 2 and 3 in Scenario A. pressDelay: "none" would keep current RN63 behavior of no delay (but possibly no feedback displayed).
Wouldn't this be much better for UX?

@andreialecu not everyone wants an additional delay for Pressables. In some (most) cases you want the onPress event to fire immediately, if you do need extra delay, wait those 10ms using a setTimeout in your onPress handler.

@mrousavy that won't work in most cases unfortunately. There are thousands of pre-existing react native libraries using Touchables. They can't be all be reasonably updated to add the delay.
The delay I'm proposing should be absolutely non-noticeable and would make react-native touchables behave more like native-native touchables. To keep it inline with @yungsters's proposal, the delay could be smart and only be applied when nested in a ScrollView. And still be disabled with pressDelay: "none" if necessary.
Additionally, someone could handle onPressIn instead, which would have no delay.

Delaying onPress is out of the scope for the current issue because we have a path forward. I think that if we want to make that part of React Native feel more like the platform, we should do it for real (and actually hook it up to navigations).

Apologies but I don't understand. I feel we may not be talking about the same issue. I tried rereading this:

(The gist of the guidelines is that the touch feedback should deactivate after the navigation has been reversed / popped.)

I'm not sure what this has to do with anything. By reversing/popping the navigation I understand going back to a previous screen.
The issue at hand is that buttons don't get a chance to update to active/touched state before navigating to a new screen ("pushing" a screen) or before going back ("pulling").
The issue here is not isolated to navigation though. I noticed it in a lot of other components that are unrelated to navigation, and which need to be nested in ScrollViews.
With your proposed approach there's still no way to have Touchables behave properly within ScrollViews. They would still show no feedback unless delayPressIn={0} is specified manually. But in that case scroll or swipe gestures would still temporarily show the button as activated.
What am I missing?

GIF to demonstrate the problem:
New delay as per RN 63:

Using .patch by @jehartzog above to revert the 130ms delay back to 0:

This is a "Drawer" type screen which is not necessarily navigation. (Arguably it's not in a ScrollView here.)

we should do it for real (and actually hook it up to navigations).

But consider a "call to action" button as part of a ScrollView below, maybe "Open Details" -> which also opens this side drawer, but it's not navigation, just an animated overlay. Would hooking it up to navigations make any difference and automatically handle this?

I don't know how, but when I add onPress handler to Pressable. dealy suddenly gone

I feel like compensating for being inside a scrollable container is the more unusual case (I checked several RN codebases I maintain and it was something like 5:1), which makes me think the default behaviour should be no delay, with a prop that can be used to add a delay if required. Maybe something like pressDelay: number | 'scroll' = 0.

I can confirm that the quick workaround suggested by @EhsanSarshar is working for me too (i.e. adding an onPress handler to Pressable and the delay to the UI feedback is eliminated)
FYI, I am using react-native of v0.63.0 on an Android tablet (SDK level 28 if it is helpful to know)

I can confirm that the quick workaround suggested by @EhsanSarshar is working for me too (i.e. adding an onPress handler to Pressable and the delay to the UI feedback, i.e. Android ripple in my case, is eliminated)
FYI, I am using react-native of v0.63.0 and I am testing my app on an Android tablet (SDK level 28 if it is helpful to know)

That's not s workaround, that's not expected behavior. Adding or not an onPress handler should not change the press in delay.

That's not a workaround, cause that's not expected behavior. Adding or not an onPress handler should not change the press in delay.

Yes - I actually meant "quick hack" (to eliminate the delay) instead - editing to avoid confusion.
And I agree that this should be fixed properly instead (say, by exposing an optional prop delayPressIn as discussed above) and the press in delay should be orthogonal to the onPress handler

FWIW, sharing how UIKIt handles this: by default, press interactions on buttons are delayed when they're inside of scroll views (and not otherwise). UIScrollView exposes a delaysContentTouches property (default on) which controls this behavior. But of course, you don't really want to hard-couple scroll views and buttons; the mechanism is more general. At the UIGestureRecognizer level, this controls the delaysTouchesBegan property on the scroll view's UIPanGestureRecognizer.

I have a new project where I used the new Pressable component in several places, but then I started noticing the delay discussed here. After reading through the comments, I've replaced all the Pressable components with TouchableOpacity components with delayPressIn={0}. Everything is working great now. But I'd love to move back to Pressable (mostly for the hitSlop prop) once this is cleared up.

Thanks for the thoughtful (and extremely prompt) responses.
Let me first respond to @andreialecu. Your realization that onPress is "delayed" in Outlook for iOS begins to touch upon a pretty fundamental disconnect between how React Native (and websites) handle touch feedback for navigation, and how Apple's Human Interface Guidelines handles touch feedback for navigation. It isn't something we can resolve with only changes to Pressable, but I do believe we need to eventually cross that road. (The gist of the guidelines is that the touch feedback should deactivate after the navigation has been reversed / popped.)
As for next steps, we feel pretty strongly that the delay should be the new default in Pressable. The reason for this default is that someone who is testing a new interactive user interface is much more likely to notice that the touch feedback is delayed as opposed to testing whether the new interactive element accidentally triggers during a scroll or swipe gesture. But when they realize and want to override that delay, they should be able to do so (or learn why it exists and maybe leave it).
If this makes sense, my proposal is the following:

Remove the default 130ms delay from Pressability (which affects TouchableWithoutFeedback, Pressable, etc.).
Change Pressable to introduce the 130ms delay when it is enclosed within a ScrollView.
Change Pressable to introduce a new prop, pressDelay?: ?('default' | 'none'). When set to none, there will be no press delay (regardless of whether it is enclosed within a ScrollView).

As a net effect, TouchableWithoutFeedback and its composing libraries will continue to work as they did before. However, Pressable will start with the new behavior (delay by default in ScrollView) but can be configured otherwise (to have no delay).
Does this seem reasonable?

Will you add this to a coming release?

Yes, definitely.

Sorry for the radio silence. Let me share my latest plans on this.
In order to avoid the unwanted breaking changes, I am going to rollback the default delay in the upcoming release. In addition, I am adding a new unstable_pressDelay prop to Pressable for anyone who — like we do at Facebook — wants to experiment with adding a press delay to prevent unwanted activations on scroll gestures.

There is an awesome component by the name of RectButton inside react-native-gesture-handler which have performant ripple animation in android and highlight animation in ios. I know that it's not related to this thread but maybe it helps some one

After providing delayPressIn={0} to touchable opacity I am still getting the delay in my entire app and it is really a frustrating thing. This delay increases with usage , the more i press buttons delay it is providing to me in next press.
Please suggest a workaround ,need it urgent.

I used the Pressable onTouchStart event to remove the delay for onPressIn Events

Is it resolved or should i downgrade my react native version? Because it is really annoying.

@GuleriaAshish The <Pressable> component works like a charm for me now.

Fixed in v0.63.3, recommend closing this issue:

Removed default 130ms delay from Pressability and Pressable. (86ffb9c41e by @yungsters)


Bump up go-client to fix auth plugin panic

Fixes #240
This PR is relying on bugfix in go-client kubernetes/kubernetes#97095

@sabbox thanks a lot for this.
have you had a chance to verify this to see if panic still occurs or not?

@sabbox thanks a lot for this.
have you had a chance to verify this to see if panic still occurs or not?

@ahmetb no more panic, it's working now
but I have to admit that working w/ kube/config in read-only mode does look ok when you have an expired access token but very weird when you have an expired refresh token.
the usual flow w/ kubectx and kubens.bash.version is the following:

when refresh token is expired user interacted log-in process is initiated, web browser is involved
we get the token and kubectx saves it to kube/config for the next re-use
if we happen to use kubens.go.version against the expired refresh token it will get the new one nothing unusual here but it won't save it to kube/config.

long story short if I call kubens.go.version again I have to re-do the very same log-in process.
but I guess the first step is to stop the bleeding and get rid of nasty panicing

@ahmetb no more panic, it's working now
but I have to admit that working w/ kube/config in read-only mode does look ok when you have an expired access token but very weird when you have an expired refresh token.
the usual flow w/ kubectx and kubens.bash.version is the following:

when refresh token is expired user interacted log-in process is initiated, web browser is involved
we get the token and kubectx saves it to kube/config for the next re-use
if we happen to use kubens.go.version against the expired refresh token it will get the new one nothing unusual here but it won't save it to kube/config.

long story short if I call kubens.go.version again I have to re-do the very same log-in process.
but I guess the first step is to stop the bleeding and get rid of nasty panicing

long story short if I call kubens.go.version again I have to re-do the very same log-in process.
but I guess the first step is to stop the bleeding and get rid of nasty panicing

Yeah this improvement is already better.
I tend to assume people use kubectls before/after kubens, so that will get/save new token next time.
It sounds like Azure's authentication model is just poor from a user experience perspective of having offline applications (like kubectl) that renew a token with refresh_token.
We can't fix that, but, in the future we might figure out a way to merge changes from the updated in-memory config file with our own changes (and re-save it even if kubens didn't make changes), so that probably will fix the issue long-term.


styling: areas do not support columnWidth=0

The feature "areas:center:columnWidth: 0" has no effect.

Fixed on master (v2.3.0) and release-2.2.x (v2.2.1).


SecondsToTimestamp format padding issue

What is the current behavior?
When generating VTT files from utterances, the timestamps are incorrectly formatted for anything under 10 seconds. Here's a snippet of the most recent VTT I've generated:
1
00:00:1.814 --> 00:00:5.423
Test one, two, three. I'm testing transcripts

2
00:00:6.318 --> 00:00:8.333
to see that they come through accurately

Steps to reproduce
Calling ToWebVTT on a PreRecordedResponse.
Expected behavior
As you can see in the example above, the first timestamp is: 00:00:1.814, and should be 00:00:01.814 according to the WebVTT Spec:

Two ASCII digits, representing the seconds as a base ten integer in the range 0 ≤ seconds ≤ 59.

Please tell us about your environment

Operating System/Version: Macos Ventura, M1
Language: Go v1.18 and v1.20
Browser: N/A

Other information
I'll link up my PR for the proposed fix, Go's float formatting requires you specify the total number of digits as the first number (including the decimal point) and the decimal precision as the second number:
return fmt.Sprintf("%02d:%02d:%02.3f", hours, minutes, seconds)

Should be:
return fmt.Sprintf("%02d:%02d:%06.3f", hours, minutes, seconds)

Thanks @NickBeukema I approved and merged your PR.


file-loader corrupts output images

Do you want to request a feature or report a bug?
Bug

What is the current behavior?
file-loader outputs a corrupted image.  It cannot be opened either in the web browser or the local file browser.  Attempting to open it with an image viewer returns an error that the file is corrupt.  Additionally, the output file in /dist is larger than the file in /src.
Output file size: 115.1 kB
Input file size: 63.6 kB
If the current behavior is a bug, please provide the steps to reproduce.
Proceed exactly with the Webpack official tutorial up to and including this point (this part is where the failure occurs): https://webpack.js.org/guides/asset-management/#loading-images

What is the expected behavior?
file-loader should copy the image from /src to /dist and plug it in to the web page when the page is loaded.
If this is a feature request, what is motivation or use case for changing the behavior?
Please mention other relevant information such as the browser version, Node.js version, webpack version and Operating System.
Node.js - v8.6.0
Webpack - 3.6.0
OS - Ubuntu 17.04 MATE

We are aware of this :) Please ensure to fix your file-loader dependency version to 0.11.2 until file-loader #183 lands and close the issue here

@michael-ciniawsky Somebody literally just linked me to the bug report on file-loader like a minute after I posted this.  I didn't realize file-loader was a separate repo.  Thank you, and my apologies to the webpack team for this waste of a report!


Update to latest version of administrate

Removed unused deps
Added rspec
Fixed specs to work with latest administrate version

@acrogenesis ?


Python face mesh module: Use tuples rather than sets in order to preserve connection ordering

Face mesh connectivity is presently stored in sets, which are unordered and therefore make recovery of the mesh very difficult. It would be better just to use immutable tuples to convey this information.

@googlebot I signed it!

@googlebot I signed it!


use String instead of &'static str so that it may be defined at runtime

Currently all the methods would need to know all the information at the time of writing the program, this allows more flexibility. I made it String because doing &str would involve lifetimes and I think the smaller the change the better, however the end result might be closer to the current use by using &str.

Hi,
Thanks for the PR.  I did an alternative change instead to use &str instead of &'static str This will allow you to use String from the outside instead of wanted but also allow to use str as before.
Here is an example of how to use it with String
https://github.com/emoon/dynamic_reload/blob/master/src/lib.rs#L650
I hope this is good enough for your use case?

Yes that would be good enough, sorry I forgot to fix the tests, it was around 3 am when I wrote it and I was going quick because I needed it to build for a hackathon project. Thank you

Alright. no problem :)

Thank you very much :)

np! Let me know if you have any more issues with the lib so I can improve it.


Re-enable skipped tests

There are three tests that are currently skipped. We should probably work on re-enabling them
https://github.com/sveltejs/kit/blob/7f0004f1ee16fd5b7935a22c808f25c6f23ff191/packages/kit/test/apps/basics/src/routes/errors/__tests__.js#L7
https://github.com/sveltejs/kit/blob/7f0004f1ee16fd5b7935a22c808f25c6f23ff191/packages/kit/test/apps/basics/src/routes/errors/__tests__.js#L183
https://github.com/sveltejs/kit/blob/7f0004f1ee16fd5b7935a22c808f25c6f23ff191/packages/kit/test/apps/basics/src/routes/accessibility/__tests__.js#L6

The skipped tests are now:
https://github.com/sveltejs/kit/blob/6c9b73977f7cb54902c55ccc395510b7ac3eb35b/packages/kit/test/apps/basics/test/test.js#L574
https://github.com/sveltejs/kit/blob/6c9b73977f7cb54902c55ccc395510b7ac3eb35b/packages/kit/test/apps/basics/test/test.js#L1538

scrolling tests were temporarily skipped as well as part of the playwright migration, but I have a PR to re-enable those: https://github.com/sveltejs/kit/pull/3197/files#diff-35da857c87de7945a1a14898efa59865955ced32f6ede60e298a3386be524dd6R92

I can't find the previously mentioned skipped tests anymore. Here are the ones I've found:
https://github.com/sveltejs/kit/blob/3d98c37c09aa53d1bf8e5dcf12aef62a43afcae8/packages/kit/src/runtime/server/page/csp.spec.js#L186
https://github.com/sveltejs/kit/blob/3d98c37c09aa53d1bf8e5dcf12aef62a43afcae8/packages/kit/test/apps/amp/test/test.js#L66


Test and document podman version of the helper

For testing on RHEL, it would be interesting to test by aliasing podman with docker commands to test this scenario for podman support.

I'm doubtful that aliasing would work, since the Agent does not use the shell to interact with Docker. Instead it uses a Go language binding to access the Docker API. In the most recent release they intended to use the latest podman, which apparently provides a true Docker API for the first time, but they encountered (and reported) issues with that API so I don't think that works currently. I'm not sure if that situation has changed since I last heard about it.


New files for Tensorflow Lite Micro Speech Example targetting the Eta…

… Compute ECM3531 evaluation board

CLA has been signed again

I signed it

Is there something else we need to do to trigger the remaining checks that haven't completed? /cc @gunan

So only the copybara check is required.  Is there a way to kick that off?
Alos, what is the protocol here, should I reply to your emails on Gmail or
on Github?
On Sun, Dec 16, 2018 at 5:29 PM Pete Warden<EMAIL_ADDRESS>wrote:

The failure in the MacOS Python2 and CC test appears to be unrelated to
any code here:
==================== Test output for //tensorflow/core:platform_port_test:
Running main() from test_main.cc
[==========] Running 5 tests from 3 test cases.
[----------] Global test environment set-up.
[----------] 2 tests from Port
[ RUN      ] Port.AlignedMalloc
[       OK ] Port.AlignedMalloc (0 ms)
[ RUN      ] Port.GetCurrentCPU
tensorflow/core/platform/port_test.cc:38: Failure
Expected: (cpu) >= (0), actual: -1 vs 0
[  FAILED  ] Port.GetCurrentCPU (0 ms)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/pull/24222#issuecomment-447696185,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Aq2lOPBF2k45td88eNLz0I2yVqzYTRbuks5u5vN-gaJpZM4ZI_Co
.

I believe somebody internal should take care of the copybara check once the tests pass, and I've just seen that Gunhan was able to kick off tests by adding the kokoro:force-run flag, so I've tried doing the same to see if we can rerun the tests. Thanks for your patience, hopefully we'll have this through soon!

The stub .sh file caused an error internally because it didn't have a copyright notice, so I've removed that and will rerun the tests.

Should I check in the  test_ecm3531_binary.sh file with the copyright added?

No, I removed it already so I think we're good.

There are 3 checks now that are failing but earlier today it showed that all the tests passed.  What gives?

One point about removing the test_ecm3531_binary.sh file is that the
makefile complains about not finding the file and will report that the make
failed.  It will generate the .elf file though.  So this script was added
just to satisfy the makefile and not confuse the user who may else thin
that there was a compilation error.  So it will be good to have this file
checked in.  But I dont know if the checks that the tensorflow build is now
complaining about is related to this or not.
make: tensorflow/lite/experimental/micro/testing/test_ecm3531_binary.sh:
Command not found
/home/hari/tensorflow_fork/tensorflow/tensorflow/lite/experimental/micro/tools/make/Makefile:171:
recipe for target 'test_micro_speech' failed
make: *** [test_micro_speech] Error 127
On Mon, Dec 17, 2018 at 2:19 PM Pete Warden<EMAIL_ADDRESS>wrote:

The stub .sh file caused an error internally because it didn't have a
copyright notice, so I've removed that and will rerun the tests.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/pull/24222#issuecomment-448019303,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Aq2lOC4_apfrJxD7MW6BLq2CJP126r1Iks5u6BhegaJpZM4ZI_Co
.

The previous errors were for Windows but now the MacOS and Ubuntu builds show errors.   None of the errors are related to the files I checked in.  So how does one make this process converge?

There were build breakages merged to master branch.
Now they are fixed, I will retrigger your tests.

Thanks.  This time the "MacOS Contrib" check has failed as earlier, but the "Ubuntu contrib" test which passed before now fails.  But two of the earlier checks that failed, now pass ("MacOS Python2" and "Ubuntu Python3").


Customizable "Members Only" box

Give users more control over the appearance of the gray box that appears on Coil Members Only pages for non-monetized visitors.
Ideas for customization include, but aren't limited to:

Allowing users to add images to the box
Changing the color of:
-- the box itself
-- the horizontal rule
-- the text
-- the button fill*
-- the text within the button*

*So long as it doesn't affect how the button appears in the voluntary donation bar or list of pages/posts. We'll need to rethink this if the button always pulls its styling from the same resource.

We are going to close this as we have plans to update the plugin with new designs.


Add succeeded() condition to dependent jobs

Without checking for succeeded() these jobs will run regardless of the success or failure of the TagRepository step.

@vhvb1989 the CI is failing because of test flakiness, when talking to httbin. We should figure out a way to run tests without relying on an external rest client.
https://dev.azure.com/azure-sdk/public/_build/results?buildId=720998&view=logs&j=becb4c78-6d46-5b40-696d-491037a3748a&t=2f50a9a2-8ce5-5e5c-0f66-5b7a93b3f955&l=3021
12: [ RUN      ] CurlConnectionPool.connectionPoolTest
12: unknown file: error: C++ exception with description "Fail to get a new connection for: httpbin.org. Couldn't resolve host name" thrown in the test body.
12: [  FAILED  ] CurlConnectionPool.connectionPoolTest (10 ms)
12: [----------] 1 test from CurlConnectionPool (10 ms total)

/check-enforcer override


Start a client

This PR uses changes made in https://github.com/keep-network/keep-core/pull/3129 to use the locally deployed artifacts. Now install.sh will build the client with the local artifacts. Also, start.sh can be used now to start a client.
To start a client we need to:
Manually configure config.toml in the /configs dir. Providing contract addresses is no longer required for "development" env. Next:

run scripts/install.sh
run scripts/initialize.sh --stake-owner <address>
run scripts/start.sh

Available params for start.sh

KEEP_ETHEREUM_PASSWORD env var. If not provided, "password" is used
flag: --config-dir path to the config file. /configs is default

Refs https://github.com/keep-network/keep-core/issues/3135

@nkuba A lot of the above comments were related to namings. I've changed everything in one commit 65dc748 so it was easier to test everything during the run.


mycorrhiza: 1.9.0 -> 1.11.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/bouncepaw/mycorrhiza/releases.
meta.description for mycorrhiza is: "Filesystem and git-based wiki engine written in Go using mycomarkup as its primary markup language"
meta.homepage for mycorrhiza is: "https://github.com/bouncepaw/mycorrhiza"
meta.changelog for mycorrhiza is: ""
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.10.0 with grep in /nix/store/csq5y049m24yfkk5gmdvb685xmvxrrmb-mycorrhiza-1.10.0
found 1.10.0 in filename of file in /nix/store/csq5y049m24yfkk5gmdvb685xmvxrrmb-mycorrhiza-1.10.0

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
mycorrhiza

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/csq5y049m24yfkk5gmdvb685xmvxrrmb-mycorrhiza-1.10.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A mycorrhiza https://github.com/r-ryantm/nixpkgs/archive/d78d44d8eed4613e702360e08c63e74a0afb5251.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/csq5y049m24yfkk5gmdvb685xmvxrrmb-mycorrhiza-1.10.0
ls -la /nix/store/csq5y049m24yfkk5gmdvb685xmvxrrmb-mycorrhiza-1.10.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

mycorrhiza

Maintainer pings
cc @chekoopa for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/bouncepaw/mycorrhiza/releases.
meta.description for mycorrhiza is: "Filesystem and git-based wiki engine written in Go using mycomarkup as its primary markup language"
meta.homepage for mycorrhiza is: "https://github.com/bouncepaw/mycorrhiza"
meta.changelog for mycorrhiza is: ""
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.11.0 with grep in /nix/store/z3pnybj6h2hc1cq7k0z8025fpw2xy742-mycorrhiza-1.11.0
found 1.11.0 in filename of file in /nix/store/z3pnybj6h2hc1cq7k0z8025fpw2xy742-mycorrhiza-1.11.0

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
mycorrhiza

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/z3pnybj6h2hc1cq7k0z8025fpw2xy742-mycorrhiza-1.11.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A mycorrhiza https://github.com/r-ryantm/nixpkgs/archive/36efb08db4fd6168ff2b38dea4dac50c6143c219.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/z3pnybj6h2hc1cq7k0z8025fpw2xy742-mycorrhiza-1.11.0
ls -la /nix/store/z3pnybj6h2hc1cq7k0z8025fpw2xy742-mycorrhiza-1.11.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

mycorrhiza

Maintainer pings
cc @chekoopa for testing.

Result of nixpkgs-review pr 183558 run on x86_64-linux 1

1 package built:

mycorrhiza


prebuild npm scripts order

Hi Cory,
I'm using this starter kit quite a lot and i find myself often changing the order of the prebuild scripts.
Currently it will run clean-dist first and then run lint and test.
"prebuild": "npm run clean-dist && npm run lint && npm run test"
I think if i have lint errors or failed tests (or any other things that may break my build) it shouldn't really do any build related processing, like deleting the dist folder.
By the way, sometimes on windows you can get an error if you try to build, and it fails, then try to build again.
I'm not sure but i think it is due to how windows is handling the I/O. maybe the process who deleted the folder didn't finished yet and another process is trying to re-create it. I'm not sure this is why i got errors but these errors are the reason i started changing the order in the first place, needless to say that it solved my problem.
My suggest is to just re-order the scripts calls, let the clean-dist run only if the build isn't broken:
"prebuild": "npm run lint && npm run test && npm run clean-dist"

Great point. I'd welcome a PR for the change.

done #510

Thanks!

No problems, and thank you!


Configure karma/jasmine to fail tests with no expectations

Pull Request
🤨 Rationale
A test with no expectations typically indicates a problem with the test. We'd like to detect this situation automatically.
See similar PR for SystemLinkShared
👩💻 Implementation
Set client.jasmine.failSpecWithNoExpectations: true in each package's karma.conf.js
🧪 Testing
Locally verified that a test with no expectations would pass before but fails now.
✅ Checklist

[x] I have updated the project documentation to reflect my changes or determined no changes are needed.

When verifying that this was working I realized we already have it, it's just configured differently than in SystemLinkShared. Abandoning


Add 4 more items - Company, Contact Us etc

Add 4 more items - Company, Contact Us etc
This has just a few items and adding a few more items will make it more usable

Good point, I will also make it resizable to accept more items.


Hessian vector product for stax neural network loss

Hi,
suppose I define a simple  neural network using stax
net_init, net_apply = serial(
        Dense(N1),
        Tanh,
        Dens(1)
)
in_shape = (-1, 1)
out_shape, net_params = net_init(rng, in_shape)

and a loss function
def loss(params, net, x, y):
       f = net(params, x)
       return np.mean((f-y)**2)

I want a function for the hessian vector product for the loss ( hessian with respect to network paramameters).
I tried different implementations but without success.
I need it because usually for small network I use scipy L-BFGS-B, but I want to try also the newton conjugate gradient.
Alberto

Here's a function that computes hessian-vector products thanks to Justin Gilmer (@jmgilmer).
from jax.tree_util import tree_map, tree_multimap
def hvp(loss, params, batch, v):
  """Computes the hessian vector product Hv.

  This implementation uses forward-over-reverse mode for computing the hvp.

  Args:
    loss: function computing the loss with signature
      loss(params, batch).
    params: pytree for the parameters of the model.
    batch:  A batch of data. Any format is fine as long as it is a valid input
      to loss(params, batch).
    v: pytree of the same structure as params.

  Returns:
    hvp: array of shape [num_params] equal to Hv where H is the hessian.
  """

  loss_fn = lambda x: loss(x, batch)
  return jvp(grad(loss_fn), [params], [v])[1]

def _tree_sum(tree_left, tree_right):
  """Computes tree_left + tree_right."""
  def f(x, y):
    return x + y
  return tree_multimap(f, tree_left, tree_right)

def _tree_zeros_like(tree):
  def f(x):
    return np.zeros_like(x)
  return tree_map(f, tree)

Thanks!
  AlOa

@sschoenholz could you please elaborate on why do we need two helper functions _tree_sum and _tree_zeros_like considering that (at least on the surface level) they seem to not be used in the hpv implementation?

Haha, I think you're right, they aren't necessary.


[BUG] Python 3.10 can't install triton 1.0.0

Describe the bug
When I validate my install and see which extensions/ops your machine is compatible with, there is a warning that I cann't use sparse attention:
[WARNING]  using untested triton version (2.0.0), only 1.0.0 is known to be compatible.
However, my Python version is 3.10.9 and it seems that I can only install triton version >= 2.0.0.
ds_report output
DeepSpeed C++/CUDA extension op report
NOTE: Ops not installed will be just-in-time (JIT) compiled at
runtime if needed. Op compatibility means that your system
meet the required dependencies to JIT install the op.
JIT compiled ops requires ninja
ninja .................. [OKAY]
op name ................ installed .. compatible
async_io ............... [NO] ....... [OKAY]
cpu_adagrad ............ [NO] ....... [OKAY]
cpu_adam ............... [NO] ....... [OKAY]
fused_adam ............. [NO] ....... [OKAY]
fused_lamb ............. [NO] ....... [OKAY]
quantizer .............. [NO] ....... [OKAY]
random_ltd ............. [NO] ....... [OKAY]
[WARNING]  using untested triton version (2.0.0), only 1.0.0 is known to be compatible
sparse_attn ............ [NO] ....... [NO]
spatial_inference ...... [NO] ....... [OKAY]
transformer ............ [NO] ....... [OKAY]
stochastic_transformer . [NO] ....... [OKAY]
transformer_inference .. [NO] ....... [OKAY]
utils .................. [NO] ....... [OKAY]
DeepSpeed general environment info:
torch install path ............... ['.../anaconda3/envs/py310/lib/python3.10/site-packages/torch']
torch version .................... 1.13.0
deepspeed install path ........... ['.../anaconda3/envs/py310/lib/python3.10/site-packages/deepspeed']
deepspeed info ................... 0.9.2, unknown, unknown
torch cuda version ............... 11.6
torch hip version ................ None
nvcc version ..................... 11.6
deepspeed wheel compiled w. ...... torch 1.13, cuda 11.6

DeepSpeed currently only supports triton 1.0.0, which was released on Jul 2021 that doesn't have wheels prebuilt for  Python >= 3.10. https://pypi.org/project/triton/1.0.0/#files So pip by default resolves the latest triton version (2.0) that's compatible with Python 3.10.
A workaround is to disable sparse_attn DS_BUILD_SPARSE_ATTN=0 or use Python 3.9.
@loadams is there any timeline for supporting newer triton version in DeepSpeed?


Reskin Treasury page

https://www.figma.com/file/9hUYtvCKjOyB92vt8ukYtD/Product-Handoff?node-id=122%3A13461&mode=dev

Closed as of #1620


Create ConfigMap from http source

Is this a request for help? (If yes, you should use our troubleshooting guide and community support channels, see http://kubernetes.io/docs/troubleshooting/.): no
What keywords did you search in Kubernetes issues before filing this one? (If you have found any duplicates, you should instead reply there.): "from-file" "http"

Is this a BUG REPORT or FEATURE REQUEST? (choose one):
FEATURE REQUEST

Kubernetes version (use kubectl version):
Client Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.4", GitCommit:"5ca598b4ba5abb89bb773071ce452e33fb66339d", GitTreeState:"clean", BuildDate:"2018-06-06T08:13:03Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.2", GitCommit:"81753b10df112992bf51bbc2c2f85208aad78335", GitTreeState:"clean", BuildDate:"2018-04-27T09:10:24Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/amd64"}

Environment:

Cloud provider or hardware configuration:
bare-metal, 3 masters, 6 worker nodes, kubespray
OS (e.g. from /etc/os-release):

root@master1:~# cat /etc/os-release
NAME="Ubuntu"
VERSION="16.04.4 LTS (Xenial Xerus)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 16.04.4 LTS"
VERSION_ID="16.04"
HOME_URL="http://www.ubuntu.com/"
SUPPORT_URL="http://help.ubuntu.com/"
BUG_REPORT_URL="http://bugs.launchpad.net/ubuntu/"
VERSION_CODENAME=xenial
UBUNTU_CODENAME=xenial
root@master1:~#

Kernel (e.g. uname -a):
Linux master1 4.4.0-130-generic #156-Ubuntu SMP Thu Jun 14 08:53:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Install tools:

Others:

What happened:
cbluth@dl7490:~/x$ kubectl -n platform create configmap nets-config --from-file=https://raw.githubusercontent.com/pires/kubernetes-nats-cluster/master/nats.conf
error: error reading https://raw.githubusercontent.com/pires/kubernetes-nats-cluster/master/nats.conf: no such file or directory
cbluth@dl7490:~/x$

What you expected to happen: I thought this would work
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know:

/kind feature
/sig cli
/area kubectl
/priority P3

/remove-lifecycle stale


CoinMarketCap API Version 1 will be taken offline soon.

Heads up! A note at the top of the CMC API Documentation page reads "Public API Version 1 will be taken offline on November 30th, 2018"... so we'll have to port the CoinMarketCapExchange code over to Version 2.

I know this is an old issue, but now v2 also is already deprecated:
https://api.coinmarketcap.com/v2/ticker/
I guess this issue can be closed in favor of #2900


Recycler is broken

doesn't work ever since the construction refactor

Closing as it works to an extent now and linked issues are more descriptive.


sh make.sh error

when I compiler the make.sh----‘sh make.sh', I got the error:
Compiling nms kernels by nvcc...
cffi.error.CDFError: parse error 31:1: Illegal character '\r'
Compiling roi pooling kernels by nvcc..
cffi.error.CDefError: cannot parse "int roi_pooling_forward(int pooled_height, int pooled_width, float spatial_scale," 29:82 Illegal character '\r'
and "Compiling roi align kernels " has the same error
Thanks!

the error is like that

@HURB hey, I've got the same problem, have you solved it? How? thanks

@WangTianYuan not yet ,   I still have the problem 。。。

@HURB which version of pytorch are you using?


Have Rainbow Grades parse and use JSON files instead of text files

Implemented in commit #350 . Removed txt export in TAGradingServer and import in RainbowGrades.


Underscores in field labels are not replaced with spaces

The label for a field called "first_name" should be generated as "First Name" but its being generated as "First_name".
https://docs.djangoproject.com/en/dev/ref/models/fields/#verbose-name

The last commit should give you proper verbose names. Let me know if it doesn't work.


Freeze on accelerate.gather if tensors are not places to different devices

System Info
- `Accelerate` version: 0.26.1
- Platform: Linux-4.18.0-513.5.1.el8_9.x86_64-x86_64-with-glibc2.28
- Python version: 3.9.18
- Numpy version: 1.24.4
- PyTorch version (GPU?): 2.0.1+cu117 (True)
- PyTorch XPU available: False
- PyTorch NPU available: False
- System RAM: 62.84 GB
- GPU type: NVIDIA GeForce RTX 3060
- `Accelerate` default config:
        - compute_environment: LOCAL_MACHINE
        - distributed_type: MULTI_GPU
        - mixed_precision: no
        - use_cpu: False
        - debug: False
        - num_processes: 2
        - machine_rank: 0
        - num_machines: 1
        - gpu_ids: all
        - rdzv_backend: static
        - same_network: True
        - main_training_function: main
        - downcast_bf16: no
        - tpu_use_cluster: False
        - tpu_use_sudo: False
        - tpu_env: []

Information

[ ] The official example scripts
[X] My own modified scripts

Tasks

[ ] One of the scripts in the examples/ folder of Accelerate or an officially supported no_trainer script in the examples folder of the transformers repo (such as run_no_trainer_glue.py)
[X] My own task or dataset (give details below)

Reproduction
`
model, optimizer, data_loader, scheduler = self.accelerator.prepare( model, optimizer, data_loader, scheduler )
for epoch in range(5):
for data, label in enumerate(data_loader):
data = data.cuda()
label = label.cuda()
pred = model(data)
label = label.to(device_0) #error in the code
out = {"pred": pred, "label": label}
out = accelerator.gather(out) #Here code stalls
`
Expected behavior
Expected behavior would be to produce an error message that would indicate that there are Tensors we asked to be gathered that belong to the same device or even better gather them despite the issue (if possible). Similar message could be useful when gathered info is not Tensor.

I could not reproduce the error, could you please give more details?

full code to reproduce
accelerate config
how you launch the script
what hardware setup you use

device_0 should be replaced with  self.accelerator.device


[spaceship] Collapse markdown codeblocks on spaceship documentation

🤓 Just some markdown format fixes on the documentation of spaceship. https://github.com/fastlane/fastlane/pull/6975

[x] Run bundle exec rspec from the subdirectory of each tool you modified. Alternatively, run rake test_all from the root directory.
[x] Run bundle exec rubocop -a to ensure the code style is valid
[x] Read the Contribution Guidelines
[x] We currently don't accept new actions, please publish a plugin instead, more information in Plugins.md

Before submitting a pull request, we appreciate if you create an issue first to discuss the change :+1:

Thanks for the follow-up! 🚀

Beautiful, thanks 👍


I have a problem

Hello, a question, I try to export the model but it doesn't show me anything. I copy and paste. It turns out I see everything invisible. do you have any ideas?
I can't change textures either

@kingbit1999 need configure valid fgd/wad path's

This probably works better in newbspguy. I removed the import/export stuff in master for now.


[TASK][MEDIUM] JDBC result format negotiation for Arrow or Thrift

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Search before creating

[X] I have searched in the task list and found no similar tasks.

Mentor

[ ] I have sufficient knowledge and experience of this task, and I volunteer to be the mentor of this task to guide contributors to complete the task.

Skill requirements

Knowledge about JDBC
Basic Knowledge with Scala Programming

Background and Goals
Arrow is one of supported JDBC result format which helps to maximize the fetching performance with verticalization, while Thrift is remained as default result format. Arrow requires Kyuubi Hive driver support. Currently, the result format can be switched via kyuubi.operation.result.format config, by session configs from client side, or can be set on server side configs. This requires pre-connection assertions and lack of flexibility for both client and server side.
To introduce result format negotiation, the server provides an mechanism to minimize the gap for prefered result set.
Implementation steps

Add preferred result format list on server side config. For example. arrow, thrift implies that server will prefer to use Arrow if no client preferred format information, while thrift is also support.
And if client set kyuubi.operation.result.format config, it means the server tries to follow the dedicated result format. When the server fails to lookup targeted result format in supported list config, the server should throws unsupported exceptions.

Additional context
Original reporter is @bowenliang123

I'd like to tackle this task.

Thanks, it would be great to bring this feature to the end users with server-side config and negotiation.


Question: Updating Notification

How can I update notification count after component rendered?

My mistake, closing.
this.bar.setNotification(value, itemIndex);

I love issues that are solved by their autho, great job @Acanguven 😄


Example reading lines from big text file

It could be interesting to see an example on how to do efficient text file reads using Free IO and Conveyor, if line-by-line reading is something that Free IO and Conveyor can do efficiently.

Hi! I'll try to include a more complex example of file processing in a release soon. For now, the streaming IO example (https://github.com/spebbe/dartz/blob/master/example/streaming_io/example.dart) shows the basics.
Also, please be aware that Conveyor is highly experimental. While it can definitely be used for many real world tasks, it is currently not fully stack safe in all situations. As for efficiency, while it has been improved a lot over time, using Dart's File Streams will often produce faster programs.
Having said that, using Conveyor can greatly improve composability and testability over Stream though, so please try it out!

I've added a new streaming IO example https://github.com/spebbe/dartz/blob/master/example/streaming_io/example2.dart to the repo. While the actual example doesn't read any big files, the techniques should work equally well for arbitrarily large files. The example does however demonstrate the testability of Free IO, which at least in my mind is superior compared to Dart Streams. Hope it helps!


spiralpower bin size dependence

Spiral power as calculated by disk.spiralpower appears to be inversely proportional to the radial bin-size.  This seems like an artifact.  Double check the algorithm used to calculate spiral power.

This may be due to summing spiral power along the radial direction, rather than integrating (i.e. not multiplying by dr)


Feature/imp fixer analyzer usage

FYI @IMFTool & @MarcAntoine-Arnaud

Works on my end.
But from the usability point of view, I see a slight risk users will associate the exceptions thrown for analysis errors with an irregular termination of Photon as opposed to an issue with the IMP under test.


Invoking server methods from a client instead of just receiving

Is the invocation of server methods from a client currently supported? If so, is there an example available?
Edit: To clarify, I'm referring to a C# client like a console application.

At the moment the .NET Client only supports receiving invocation of client methods.
But creating an invocation and passing it to the server is something rather trivial. Take a look at how you do it in TypeScript and if you want to contribute, add this to the .NET Client.
Will keep this issue open if you or anyone would like to implement this in the .NET Client.
Thanks!

This is very old and inaccurate. We now have two-way communication between C#/JS Client <-> Server.


RChain Development for Bounties: VM primitives, CI integration

Jira Bounties

Story ROS-271 | Integrate into CI Pipeline
Bug ROS-270 | Fix C++ Rosette builds
Story ROS-266 | Make C++ Rosette VM read in an RBL file in addition to boot.rbl
Story ROS-253 | Create primitive definitions located in RBLString.cc
Story ROS-251 | Create primitive definitions located in RblStack.cc
Story ROS-250 | Create primitive definitions located in RblAtom.cc
Story ROS-247 | Create primitive definitions located in Queue.cc
Story ROS-246 | Create primitive definitions

The work on these issues requires that the community engage with the core development team. @dckc has experience with this engagement. So you can ask him how that goes.
Please, ask @MParlikar how to engage and how to become assigned to a ROS.
Please put regular comments hereunder, so that it's visible for the other members that you're working.

Please advise which ticket you wish to work on, and your Discord handle will be added to the ticket - so no one else will work on the ticket.

Wow,
You're fast as light. I didn't even finish my intro email to you ;-)
--
Cheers,
HJ
On Fri, Nov 17, 2017 at 11:26 PM, MParlikar<EMAIL_ADDRESS>wrote:

Please advise which ticket you wish to work on, and your Discord handle
will be added to the ticket - so no one else will work on the ticket.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rchain/Members/issues/176#issuecomment-345382771, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AB0x9-nBD0yThAl0rNsBbcWyljOdoeRFks5s3ggegaJpZM4QisjR
.

I spent a little time orienting myself to work on ROS-271 but eventually discovered @KentShikama has done the bulk of it: PR 52
For reference: https://travis-ci.org/rchain/rchain build logs

After discussion with @KentShikama, I put some more time in: https://github.com/rchain/rchain/pull/54
time log: about 3 or 4 hrs tonight.

Here is the wiki page for the Bounty tickets:
https://rchain.atlassian.net/wiki/spaces/CORE/pages/105938971/Bounties+for+Development+work

@rchain-travis are you the same person as @travismorehead ??

No, it's the build system.  https://travis-ci.org/

the build system made https://github.com/rchain/Members/issues/176#issuecomment-348283808 ???

Oh, must have been Alex or Medha while logged into that account.

It was my bad.  I was logged in there and didn't realize it until after I
made the comment.
On Mon, Dec 4, 2017 at 8:31 AM, Mike Stay<EMAIL_ADDRESS>wrote:

Oh, must have been Alex or Medha while logged into that account.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/rchain/Members/issues/176#issuecomment-349017479, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADcF_YUVfDhEKJ5qv7DZAIE-BrxCw9cEks5s9B5egaJpZM4QisjR
.

@dckc how does it go please, want to see what contributions I can make to help resolve this issue

@MParlikar please would likewise want to know how to engage and be assigned to a ROS please .

@BelovedAquila which of the Jira bounties most interests you?
Before you start making any changes, have you checked out the code and gotten the tests running in your development environment?

@dckc no I haven't how do I do that

@BelovedAquila this issue is about collaborative software development in scala (or perhaps C++). Do you have experience with that? I can't tell from your github profile whether you do.
You check out the code like any other github project; see Propose changes to someone else's project. Then use sbt test in any of the subprojects under https://github.com/rchain/rchain.

@lapin7 @dckc @MParlikar
There must be something  wrong for the budget and reward for this issue. @dckc vote 640$ for this issue, I guess he must want apply all budget for work done for this month, because if the total budget for this issue is 640$, and then the percentage of my work is 5%, then my reward is 32$. So I vote 25000$ for this budget so that, my reward is about 16*40 = 640$.

Yes, $640 is good.
There was a large budget left over from previous months at the time I
entered what I did.
On Feb 1, 2018 1:29 AM, "Abner Zheng"<EMAIL_ADDRESS>wrote:

@lapin7 https://github.com/lapin7 @dckc https://github.com/dckc
@MParlikar https://github.com/mparlikar
There must be something wrong for the budget and reward for this issue.
@dckc https://github.com/dckc vote 640$ for this issue, I guess he must
want apply all budget for work done for this month, because if the total
budget for this issue is 640$, and then the percentage of my work is 5%,
then my reward is 32$. So I vote 25000$ for this budget so that, my reward
is about 16*40 = 640$.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/rchain/Members/issues/176#issuecomment-362181506, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAJNyojizY8Wxe8W_vj04XPgV8Q2a2_rks5tQWfbgaJpZM4QisjR
.

What needs to be done in order to fix this?  @dckc @lapin7 How does the budget roll over from last month?

@MParlikar I'm inclined to see the big spreadsheet as a useful prototype and retire it. See #260 for a next prototype.

"budget 201801" & "rewards 201801" are frozen and can only be changed be me
at the moment.
Please check and eventually enter correct entries for #176
I've changed the entries manually to
3,072.00 Member
0.00 lapin7
0.00 MParlikar
2,432.00 dckc
0.00 rchain-travis
0.00 pyrocto
0.00 BelovedAquila
640.00 AbnerZheng
0.00 kaka56
0.00
0.00
0.00
The roll over is like: "budget rollover" = "budget 201801" - "rewards
201801"
The new budget is like: "new budget" = "budget rollover" +  "budget 201802"
--
Cheers,
HJ
On Thu, Feb 1, 2018 at 8:50 PM, Dan Connolly<EMAIL_ADDRESS>wrote:

@MParlikar
http://t.sidekickopen08.com/e1t/c/5/f18dQhb0S7lC8dDMPbW2n0x6l2B9nMJW7t5XZs2zhDwMW5v_SgK2zWN1RW1p1hXH56dLy3f6WHqqH02?t=https%3A%2F%2Fgithub.com%2Fmparlikar&si=5281391242641408&pi=421525da-e669-422e-8d68-9c0d0035fa27
I'm inclined to see the big spreadsheet as a useful prototype and retire
it. See #260
http://t.sidekickopen08.com/e1t/c/5/f18dQhb0S7lC8dDMPbW2n0x6l2B9nMJW7t5XZs2zhDwMW5v_SgK2zWN1RW1p1hXH56dLy3f6WHqqH02?t=https%3A%2F%2Fgithub.com%2Frchain%2FMembers%2Fissues%2F260&si=5281391242641408&pi=421525da-e669-422e-8d68-9c0d0035fa27
for a next prototype.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
http://t.sidekickopen08.com/e1t/c/5/f18dQhb0S7lC8dDMPbW2n0x6l2B9nMJW7t5XZs2zhDwMW5v_SgK2zWN1RW1p1hXH56dLy3f6WHqqH02?t=https%3A%2F%2Fgithub.com%2Frchain%2FMembers%2Fissues%2F176%23issuecomment-362381709&si=5281391242641408&pi=421525da-e669-422e-8d68-9c0d0035fa27,
or mute the thread
http://t.sidekickopen08.com/e1t/c/5/f18dQhb0S7lC8dDMPbW2n0x6l2B9nMJW7t5XZs2zhDwMW5v_SgK2zWN1RW1p1hXH56dLy3f6WHqqH02?t=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAB0x9_LBfIrfgB1lEG2gI7qUuEHqj7yoks5tQhWYgaJpZM4QisjR&si=5281391242641408&pi=421525da-e669-422e-8d68-9c0d0035fa27
.

@lapin7 The reward for my work is right. Thanks.

@lapin7 in the scope of this ticket, my only contributions in January were coordination, onboarding, and guiding.
My coding work was mostly in #185.

I have made a PR for ROS-247 and ROS-314. @lapin7 @MParlikar Please assign someone to review it, thank you.
https://github.com/rchain/rchain/pull/218

Soon I will produce a total list of payments per person.
Before actual payments start, I can receive feedback and make adjustments
if it's needed.
The attention for the payment system has increased enormously. :-)
And I'm happy to improve the system with all your insights and suggestions.
--
Cheers,
HJ
On Fri, Feb 2, 2018 at 9:52 AM, Dan Connolly<EMAIL_ADDRESS>wrote:

@lapin7 https://github.com/lapin7 in the scope of this ticket, my only
contributions in January were coordination, onboarding, and guiding.
My coding work was mostly in #185
https://github.com/rchain/Members/issues/185.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/rchain/Members/issues/176#issuecomment-362524300, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AB0x9-rJ3NQXJzQv_XrUCNo14tZ2RfR0ks5tQsy7gaJpZM4QisjR
.

After i rebased dev branch, there was something wrong with this pull-request #218. So i made a new pull-request here. #296..

Medha is making new issues for more recent contributions to the core development work.


Errors in decoding requests in cordova applications

It seams that node-fetch has issues when used in cordova applications.
Spceifically I am meeting this problem:
https://stackoverflow.com/questions/19438884/incorrect-header-check-when-using-zlib-in-node-js.
It is due to incompatibility between node-fetch and cordova applications; moreover we met the same error ones in our applications and for this reason we are using isomorphic-fetch instead of node-fetch.
This PR addresses this problem: #103

We are not using the library anymore in the client


What's New Box for CAMPD

Discussions to continue on CAMPD Side. Would like to be a shared component so Travis + Chris can update as they please. Same design as on ECMPS, but discussions of functionality to happen soon.

Do some solutioning to discuss functionality and to control the content on the page

Work was done on the emissioners side and will be added to the Shared Library


Feature/ebay

eBay project is ready for review.

Thanks for the PR. Responding to your comment from the other thread, I believe what we have here is close enough to the original eBay for a demo. We don't need to copy the look/feel completely :)

@addyosmani
When you review this PR, please give some feedback at the project README.

Thanks for the PR. Responding to your comment from the other thread, I believe what we have here is close enough to the original eBay for a demo. We don't need to copy the look/feel completely :)

Yes, sounds good.
https://adaptive-loading.web.app/react-ebay-network-aware-code-splitting/
From this we can check the demo on firebase.

@addyosmani
For network aware code splitting like this, we don't use React hooks but the lazy loading pattern with navigator.connection.effectiveType directly.
const Product = lazy(() => {
  return new Promise(resolve => {
    navigator.connection ? resolve(navigator.connection.effectiveType) : resolve(null);
  }).then(
    effectiveType => {
      console.log('effectiveType => ', effectiveType);
      switch (effectiveType) {
        case '4g':
          return import(/* webpackChunkName: "magnific-product" */ './MagnificProduct');
        case '3g':
        case '2g':
        case 'slow-2g':
          return import(/* webpackChunkName: "simple-product" */ './SimpleProduct');
        default:
          return import(/* webpackChunkName: "magnific-product" */ './MagnificProduct');
      }
    }
  );
});

For network aware code splitting like this, we don't use React hooks but the lazy loading pattern with navigator.connection.effectiveType directly.

I think that's fine!

Overall LGTM with some very minor comments 👍

Thank you for reviewing.

@addyosmani
All comments are handled. Please review again and let's get this merged soon for the upcoming PRs.


sc-2370 use consistent fixtures

This changes fakerize.py to use more consistent fixtures by creating instances of random.Random with predefined seeds. The idea is that the make_ functions take in a random.Random which by default uses a random seed but can be overwritten by the parent to produce consistent pseudorandom values based on the VASP or CertReq name. I also added some QoL things to fakerize.py such as basic CLI so that we can easily copy the fixture archive to pkg/gds/testdata.
A lot of changes were required in the test code, mostly updating the expected values to the newly generated ones, but hopefully we shouldn't have to do this as much in the future since the fixtures are more consistent.

Codecov Report

Merging #259 (ee1275a) into main (29c7d77) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #259      +/-   ##
==========================================
- Coverage   44.02%   43.99%   -0.04%
==========================================
  Files          53       53
  Lines        6071     6071
==========================================
- Hits         2673     2671       -2
- Misses       2922     2923       +1
- Partials      476      477       +1

Impacted Files
Coverage Δ

pkg/gds/gds.go
61.82% <0.00%> (-0.68%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29c7d77...ee1275a. Read the comment docs.


Unable to Establish Connection Between Base Agents After Adding Tenants Module

Overview
I am encountering an issue when attempting to establish a connection between two different base agents after integrating the Tenants module in my implementation of the AFJ (Aries Framework JavaScript) version 0.4.0. This issue arises while initializing an agent using the provided configuration.
Steps to Reproduce
To reproduce the issue, follow these steps:

Use AFJ version 0.4.0 in the @aries-framework/core and @aries-framework/tenants packages.
Initialize an agent with the following configuration:

const agent1 = new Agent({
  config: agent1Config,
  modules: {
    tenants: new TenantsModule(),
    indySdk: new IndySdkModule({ indySdk }),
    connections: new ConnectionsModule({
      autoAcceptConnections: true,
    }),
  },
  dependencies: agentDependencies,
});

Attempt to establish a connection between two different base agents.

Expected Behavior
I expect the connection between the two base agents to be successfully established, allowing for further interaction and communication.
Observed Behavior
Instead, I am encountering the following error:
Error: Couldn't determine tenant id for inbound message. Unable to create context.
This error prevents the successful establishment of the connection.
Additional Information
I have ensured that all required dependencies and configurations are properly set up. Prior to integrating the Tenants module, I did not experience any issues with establishing connections between base agents.
Environment
@aries-framework/core Version: 0.4.0
@aries-framework/tenants Version: 0.4.0
Node.js Version: v16.19.1
Operating System: Ubuntu 18.04.6 LTS Bionic
Possible Solution
I have attempted to troubleshoot this issue by reviewing the documentation and searching for related discussions, but have not been able to identify a solution. I suspect there may be a misconfiguration or a missing step in setting up the Tenants module or its dependencies.
Impact
This issue prevents me from establishing connections between base agents, which is a critical functionality required for my project. Resolving this issue is crucial to proceed with the development and deployment of my application.
I appreciate any assistance or guidance in resolving this issue.

Do you have a full reproducible repository to recreate this issue? "establishing a connection between two base agents" can be done in many ways

Yes, but I'm looking for a solution to this particular issue of why is it that I am not able to establish a connection between two different agents if I am using new Tenants() module while initializing the agent.
Or please let me know where I'm doing wrong.
Error: Couldn't determine tenant id for inbound message. Unable to create context.

Do you have a full reproducible repository to recreate this issue? "establishing a connection between two base agents" can be done in many ways
Yes, but I'm looking for a solution to this particular issue of why is it that I am not able to establish a connection between two different agents if I am using new Tenants() module while initializing the agent.

Or please let me know where I'm doing wrong.
Error: Couldn't determine tenant id for inbound message. Unable to create context.

Do you have a full reproducible repository to recreate this issue? "establishing a connection between two base agents" can be done in many ways

Yes, but I'm looking for a solution to this particular issue of why I cannot establish a connection between two different agents if I am using the new Tenants() module while initializing the agent.
Or please let me know what I'm doing wrong.
Error: Couldn't determine tenant id for inbound message. Unable to create context.

I know. But without a reproduction environment it is impossible for us to solve. The error and use case are too vague to find the root cause.

Closing as a lot has changed. If the issue still persists with latest 0.5.0 alphla, node 18/20 and 0.2.0 of the shared components, please open a new issue. Thanks!


On opt-in basis, keep track of DCA performance

Someone opted the idea to let Bitcoin DCA report how your DCA strategy is performing. Ideally the app would write the transactions to some sort of database and when the user would request statistics, fetch the current price and show how much % the user has progressed.

There is already some sort of logging build into the app right? When you provide the tag (-t) argument to the buy command, the buy is attached to a tag (https://bitcoin-dca.readthedocs.io/en/latest/tagged-balance.html#tagged-balance). This info is written down in a JSON file in de application dir /var/storage/balance.db
My idea:

Add enviroment variable (boolean) to enable logging all buy transactions (or call it a portfolio feature maybe)
When enabled, a new record is written into a JSON with the amount of bought btc and the timestamp (and maybe also the price in fiat you paid)
To check the performance overall, an interface (application) would be ideal which reads all the info from the json and a API is used to get the current btc price. This interface/application could be fully client-side, so you can easily open this at anytime without any use of Docker.

I like this idea. Yet, isn't SQLite better? Using JSON as a (growing) database isn't very efficient since the code has to parse the entire file every time a line should be added. This would also help in the event of a web interface as SQLite offers basic query functions like GROUP BY and SUM, offloading this logic to presumably more efficient (than PHP) native functions.

I agree using a SQLite database is better, but then we need a Docker container to run this database I think?
Another question arises to me, is it possible to query this database from the client / application (Javascript)? Make use of an library like https://github.com/sql-js/sql.js (I don't have expierence with that)? Or perhaps using IndexedDB is an option?


Transfer to beneficiary after transfer_on_hold

The order of balance transfers from the contract's accounts during termination is changed so that balance on hold is transferred to the origin before the contract's free balance is transferred to the beneficiary. This way we let the contract's account be reaped when the account is emptied.
The struct Charge is updated so that the bool terminated becomes status which is a new ContractStatus enum.
/// The beneficiary of a contract termination.
type BeneficiaryOf<T> = AccountIdOf<T>;

/// The status of a contract.
///
/// In case of termination the beneficiary is indicated.
#[derive(RuntimeDebugNoBound, Clone, PartialEq, Eq)]
pub enum ContractStatus<T: Config> {
	Alive,
	Terminated(BeneficiaryOf<T>),
}

bot merge


限制抓取时间在1分钟（master里的抓去模块，超时自动杀死线程）

限制抓取时间在1分钟（master里的抓去模块，超时自动杀死线程）

参考教程：

https://blog.csdn.net/captain5339/article/details/128360804

Exception in thread Thread-1 (spin):
Traceback (most recent call last):
  File "/usr/lib/python3.10/threading.py", line 1016, in _bootstrap_inner
    self.run()
  File "/usr/lib/python3.10/threading.py", line 953, in run
    self._target(*self._args, **self._kwargs)
  File "/home/tony/EE211_ws/src/tb4_find_pickup_place/tb4_find_pickup_place/master.py", line 1037, in spin
    rclpy.spin(controller)
  File "/opt/ros/humble/local/lib/python3.10/dist-packages/rclpy/__init__.py", line 222, in spin
    executor.spin_once()
  File "/opt/ros/humble/local/lib/python3.10/dist-packages/rclpy/executors.py", line 739, in spin_once
    self._spin_once_impl(timeout_sec)
  File "/opt/ros/humble/local/lib/python3.10/dist-packages/rclpy/executors.py", line 736, in _spin_once_impl
    raise handler.exception()
  File "/opt/ros/humble/local/lib/python3.10/dist-packages/rclpy/task.py", line 239, in __call__
    self._handler.send(None)
  File "/opt/ros/humble/local/lib/python3.10/dist-packages/rclpy/executors.py", line 437, in handler
    await call_coroutine(entity, arg)
  File "/opt/ros/humble/local/lib/python3.10/dist-packages/rclpy/executors.py", line 351, in _execute_timer
    await await_or_execute(tmr.callback)
  File "/opt/ros/humble/local/lib/python3.10/dist-packages/rclpy/executors.py", line 107, in await_or_execute
    return callback(*args)
  File "/home/tony/EE211_ws/src/tb4_find_pickup_place/tb4_find_pickup_place/master.py", line 295, in pickup_cb
    print(1/0)
ZeroDivisionError: division by zero


runtime/trace: execution trace doesn't include pprof labels

Labels set through runtime/pprof.SetGoroutineLabels don't show up in execution traces. In the CPU and goroutine profiles, samples include the labels from the sampled goroutine. Labels are quite useful for associating CPU usage with trace span IDs, HTTP endpoints, user IDs, etc.
It would be useful to have these labels in execution traces as well. For example, since execution traces now include timestamped CPU profile samples, trace events could be associated with an application-level trace span ID using labels to get a breakdown of on-CPU and off-CPU time for an individual request. We can further bridge runtime/pprof and runtime/trace by making labels, which are already available in some profiles, available in traces as well.
Arguably there's already support for something similar to this through trace.WithRegion and trace.NewTask. However, these values are one-dimensional and seem to be intended for breaking down a process into steps (read an event stream, query a database, etc...). To record additional contextual information, like a specific distributed trace ID or user ID, you'd need to do something ad-hoc like pack that information into the task name, or show it in a designated trace.Log category.
Perhaps profile labels could be added to the trace as a new event that is emitted whenever the labels for a goroutine are updated? (See this comment)
See also #41554

Thanks. I think this is addition makes sense. How should these labels be surfaced in the current UI?

We could also have a command-line option to filter the trace event stream by specific label sets before its read into the UI.
Also, if we have labels in the event stream, the labels could also be added to the pprof profiles that are generated from the trace.

+1 to both of these options for now.
In the future Perfetto should be able to display and filter events based on labels in the UI if we go in that direction. But I haven't tested it.

I've mailed https://go-review.googlesource.com/c/go/+/456239 to demonstrate adding pprof labels in a trace event stream to pprof profiles derived from the stream. You'll get profiles with the labels attached to samples, which you can see in the pprof graph UI like in the screenshot below from a trace-derived network latency profile. You can also filter by labels (a.k.a "tags") with options like go tool pprof -tagfocus=....

I'm still working on a demonstration of filtering/focusing on events within the UI based on labels, but I'll mail something once I get a good solution.

We could also have a command-line option to filter the trace event stream by specific label sets before its read into the UI.
Also, if we have labels in the event stream, the labels could also be added to the pprof profiles that are generated from the trace.

Both of these sound good to me as well.

You'll get profiles with the labels attached to samples, which you can see in the pprof graph UI like in the screenshot below from a trace-derived network latency profile.

Very cool! Slightly tangential, but it reminds me that I think eventually we're going to want to document these features at like, go.dev/doc/diagnostics (you don't need to do that now). I'll go scribble that down somewhere else...

I've also mailed https://go-review.googlesource.com/c/go/+/460095 (marked WIP) to highlight events in the UI based on goroutine labels. Compared to adding labels to profiles derived from the trace, I think exploring the trace UI based on labels is much more open-ended. There are different use cases.
One might be to scope in on a particular request, where the label of interest is a particular request ID, with a much more focused view similar to the task ID-oriented view:

Another would be to highlight all work related to a specific endpoint on a web app with multiple mostly-independent endpoints:

The CL I sent adds query parameters to the trace endpoint to specify label keys and values, and highlights events related to goroutines with those labels while greying out the others. I think you might want to still have other events visible but less emphasized. The CL doesn't add a way to filter the trace from the main page, though, just adds the query parameters for now. I've played with a page to build a list of label filters and then take you to the viewer with those filters:

It's pretty rough though, and how we do this probably deserves more discussion.

Kicking to Backlog since this didn't make Go 1.21. Not punting to Go 1.22 since IIUC this has been deprioritized. It still would be nice to have this alignment between these diagnostic formats, but it doesn't seem urgent.
Please comment if you plan to work on it for Go 1.22, and I'll move it to that milestone. Thanks!


Add IAsyncEnumerable support to MVC

Edit: @rynowak hijacking top post for great justice
This would include adding support for returning IAsyncEnumerable<> from an action method and letting MVC do the buffering for you because giving the data to the formatter.
This would require integrating with JsonResult and ObjectResult

For 3.0, we're doing a fairly scoped change viz to add support for IAsyncEnumerable<T> in MVC. Using https://github.com/aspnet/AspNetCore/issues/11558 to track further work based on the initial issue and ideas suggested in this issue.


Adding ICGC Storage and Synapse File Provisioning

Storing large reference files on S3 is easy but incurs hosting and data transfer charges.  It also means important reference files are stored in private AWS accounts, which can be shutdown.
A better approach is to host large reference files on a service like Synapse or the ICGC Storage System.  Both of these are considered public repositories, can handle large files, and Synapse is a complete self-served model.
Both require user registration/tokens so it's not quite as nice as a free place to host HTTP-based files.  But the benefits of Synapse (free hosting/transfer) and general importance of the ICGC Storage System make it worthwhile to support these.

@spacime I temporarily assigned you this.  If it's something you can work on it would be great.

I think ICGC Storage is largely functional, I'll take a look Synapse file provisioning when I get a chance.

ICGC Storage exists, Synapse is now implemented


CosmosDB DocumentDBConverter Fixed

Removed @Slf4j as it is adding LOGGER field which is not mapped to properties in BasicPersistentEntity.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Viswa Teja Nariboina seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


splice Function doesn't include number case to documentation

VS Code Version: 1.55.0
OS Version: Windows 10 20h2

Steps to Reproduce:
Wrong issue.

Does this issue occur when all extensions are disabled?: Yes

Wrong issue.


Runtime error archiving

          Original issue by @gametimebuildserver - Imported from fastlane/gym#113

The following build commands failed:
Libtool /Users/bserver/Library/Developer/Xcode/DerivedData/Gametime-afosxnghsgtxcyajgrkdraetxdxg/Build/Intermediates/ArchiveIntermediates/Beta/IntermediateBuildFilesPath/Pods.build/Beta-iphoneos/Braintree.build/Objects-normal/arm64/libBraintree.a normal arm64
(1 failure)
[17:52:18]: Exit status: 65
/Library/Ruby/Gems/2.0.0/gems/gym-0.8.4/lib/gym/error_handler.rb:52:in `handle_build_error': Error building the application - see the log above (RuntimeError)
	from /Library/Ruby/Gems/2.0.0/gems/gym-0.8.4/lib/gym/runner.rb:80:in `block in build_app'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane_core-0.18.2/lib/fastlane_core/command_executor.rb:51:in `call'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane_core-0.18.2/lib/fastlane_core/command_executor.rb:51:in `execute'
	from /Library/Ruby/Gems/2.0.0/gems/gym-0.8.4/lib/gym/runner.rb:76:in `build_app'
	from /Library/Ruby/Gems/2.0.0/gems/gym-0.8.4/lib/gym/runner.rb:10:in `run'
	from /Library/Ruby/Gems/2.0.0/gems/gym-0.8.4/lib/gym/manager.rb:8:in `work'
	from /Library/Ruby/Gems/2.0.0/gems/gym-0.8.4/lib/gym/commands_generator.rb:41:in `block (2 levels) in run'
	from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/command.rb:178:in `call'
	from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/command.rb:178:in `call'
	from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/command.rb:153:in `run'
	from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/runner.rb:428:in `run_active_command'
	from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/runner.rb:68:in `run!'
	from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/delegates.rb:15:in `run!'
	from /Library/Ruby/Gems/2.0.0/gems/gym-0.8.4/lib/gym/commands_generator.rb:58:in `run'
	from /Library/Ruby/Gems/2.0.0/gems/gym-0.8.4/lib/gym/commands_generator.rb:14:in `start'
	from /Library/Ruby/Gems/2.0.0/gems/gym-0.8.4/bin/gym:6:in `<top (required)>'
	from /usr/local/bin/gym:23:in `load'
	from /usr/local/bin/gym:23:in `<main>'

command I was running:
gym --workspace "projname.xcworkspace" --scheme "Beta" -o $HOME/Desktop/build/ --use_legacy_build_api --clean

I have the same problem. Once in a while i got Exit status: 65 but next day is everything ok. This happens when I run Fastlane through Jenkins on our build machine. When I run it directly on build machine everything is ok. I don't understand to this ...

@tomassliz In my case was a run script I had, if you do ir on Xcode in the CI machine in the output of the build tells you what failed :)

I know what failed but I don't know why. This happens only sometimes and in irregular intervals. This is the shortened output:
...
▸ Copying Business/StubbedResponses/LoanOffer.xml
▸ Copying Business/StubbedResponses/LoanSubmit.xml
▸ Compiling PanelCollectionCell_FullLink.xib
▸ Compiling AmountTableViewCell.xib
** ARCHIVE FAILED **

The following build commands failed:
CodeSign /Users/hudson/Library/Developer/Xcode/DerivedData/Business-fhkbkcejohabqnahaylrfetrlhdm/Build/Intermediates/ArchiveIntermediates/Individual\ Sit1-Release/IntermediateBuildFilesPath/UninstalledProducts/iphoneos/Tachometer.framework
(1 failure)
[21:07:49]: Exit status: 65

I see the error after add asking for permission for sending notifications

We ran into a similar issue recently with the fastlane suddenly failing on developer laptops with this error towards the last stage of the build.
==
** ARCHIVE FAILED **
[12:23:31]: Exit status: 65
It worked fine for many weeks for our developers.  Our jenkins build server did not see this error with the same fastfile. We investigated potential changes and differences. We added a couple of new pods to our ap recently and we always run Xcode on the developer machines. On the build server we don't run the Xcode App although we do use some of the Xcode command line tools.  Xcode versions are same on both.
The workaround in our case was to drop the Xcode derived data directory on the developer laptops after first exiting Xcode App.
rm -rf /Users/vamsee/Library/Developer/Xcode/DerivedData/Onkore-cqhdpxkmthcxrffvifokbmbpdrxi/
After this the "Exit status: 65" problem went away.

@lakamsani Thanks for sharing. Glad to hear you got up and runnign 👍

I ran into a similar issue today, we are using Crashlytics in a Script Phase, and Jenkins as a runner for the build.  The Crashlytics build phase would through the Archive failed with Exit status: 65 if there was a space in the Jenkins project name.  I removed the space from the project name, and the Exit status went away.
Just putting this here for additional information in case someone else has the same issue.