Please add musl-dev to Alpine images

Hi,
As it seems that the Docker containers for Home Assistant are built using Alpine, please add the musl-dev libraries to the Docker images when deploying.
This should be a non-breaking change, and makes things a lot easier for those of us that are using custom components on Docker.
An example would be the NHC2 custom-component, which still hasn't been added to the main integrations library.
For transparency purposes, I have included the issue I got with the latest version of the HA container, which would not load the NHC2 custom-component as it relies on some libraries which are compiled at installation time using PIP.
Building wheels for collected packages: netifaces
  Building wheel for netifaces (setup.py) ... error
  ERROR: Command errored out with exit status 1:
   command: /usr/local/bin/python -u -c 'import io, os, sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-rmcf8olu/netifaces_aedbbec520204a85a3c2a27036bee050/setup.py'"'"'; __file__='"'"'/tmp/pip-install-rmcf8olu/netifaces_aedbbec520204a85a3c2a27036bee050/setup.py'"'"';f = get
attr(tokenize, '"'"'open'"'"', open)(__file__) if os.path.exists(__file__) else io.StringIO('"'"'from setuptools import setup; setup()'"'"');code = f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' bdist_wheel -d /tmp/pip-wheel-ttgl631s
       cwd: /tmp/pip-install-rmcf8olu/netifaces_aedbbec520204a85a3c2a27036bee050/
  Complete output (20 lines):
  running bdist_wheel
  running build
  running build_ext
  checking for getifaddrs...not found.
  checking for getnameinfo...not found.
  checking for socket IOCTLs...not found.
  checking for optional header files...none found.
  checking whether struct sockaddr has a length field...no.
  checking which sockaddr_xxx structs are defined...none!
  checking for routing socket support...no.
  checking for sysctl(CTL_NET...) support...no.
  checking for netlink support...no.
  building 'netifaces' extension
  gcc -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -fno-semantic-interposition -fno-builtin-malloc -fno-builtin-calloc -fno-builtin-realloc -fno-builtin-free -DTHREAD_STACK_SIZE=0x100000 -fPIC -DNETIFACES_VERSION=0.10.9 -I/usr/local/include/python3.9 -c netifaces.c -o bu
ild/temp.linux-x86_64-3.9/netifaces.o
  In file included from netifaces.c:1:
  /usr/local/include/python3.9/Python.h:11:10: fatal error: limits.h: No such file or directory
     11 | #include <limits.h>
        |          ^~~~~~~~~~
  compilation terminated.
  error: command '/usr/bin/gcc' failed with exit code 1
  ----------------------------------------
  ERROR: Failed building wheel for netifaces
  Running setup.py clean for netifaces
Failed to build netifaces

After running apk add musl-dev directly in the container, and checking if these packages could be installed, everything was working again.
Thanks in advance!
Best regards,
Steve Gilissen

It is not efficient to ship development packages.
Instead, we have a repository available for custom components (in our org), that allows us to pre-build Python wheels.
Please add your custom component to that repo instead.


Bug-fix; typo in the name of atomic species

I fixed the typo.

Can one of the admins verify this patch?

I think no one would complain about this modification.


Adding headers to validate the API

The API I'm working on requests an header, but I saw that the library doesn't support this feature at the moment. Cause of this, I'm not able to validate the API since I get back a 403.
E.g., in curl it would be:
curl -XPOST -v -H "Content-Type: application/json" **--header "keyHeader: valueHeader"** 'http://localhost:8080/myEndpoint' -d '{"foo": "bar"}'

The changes would consist in adding a new method to parse the headers in endpoint-builder.js and to integrate it in endpoint-checker.js.
I've already made all the changes in a branch to support this functionality, happy to open a PR in case.
Any thoughts?

Hi @ericaovo this is great!
Feel free to open the PR, just remember to add tests for the functionality 🙂

It's published now! https://www.npmjs.com/package/raml-js-validator

Thanks a lot @joanvila !


Allow to restart a server

It's my first attempt, when the button is pressed the server is stopped/started again.
Fixes #117
I also tried to add a command to the CLI but didn't really see how I could talk to the backend controlling the server instances through the CLI (As far as I could see it wasn't really possible).
I had an idea using a POST to Start/Stop the specific server in the CLI.

I've rebased with master and fix the conflicts
Fixed 2 issues I found during rebasing (thanks to Vue.js 2 warnings)

Hi @JanStevens,
Thank you for the PR.
I have mixed feelings about this feature. On one side, it would be 1 click to restart vs 2 clicks to restart with the toggle button. But on the other side, it would add a little bit of noise to the interface.
For the moment, and it's purely subjective, I prefer to keep the UI minimalist.
May change in the future if it's an issue.
PS: Vue 2.0 warnings fixes are welcome


Title says all.

The commit above implements sounds based on items in general, not just the sword - I can't really find a fitting sound in vanilla Minecraft, and I am not including any custom sounds with the mod itself.
Will also add sounds.json entries for the hotbar soon so that you can customize the draw sound separately.


Align connects metrics

This PR address https://github.com/twmb/franz-go/issues/670 but in the monitoring implementation introduced in this module by #460.
It changes Kafka connection metrics, instead of relying on 2 different metrics to report Kafka connections successes and failures, use only a single metric with distinct outcome attribute based on the outcome. This implementation does not guard this new behaviour under a flag, like I did for the contribution to franz-go as I don't think it's useful is a specialized implementation like we have here. But still this introduces a breaking change in the kafka package monitoring so I'm open to revisit this decision if we want to keep backwards compatibility.
Metric messaging.kafka.connect_errors.count has been removed.
Attribute outcome has been added to messaging.kafka.connects.count with 2 possible values: success and failure.

Upon internal feedback this PR now does not remove a metric but only adds dimensions & emit connects metric also on failure. Removing the old metric will happen in a future update.

Added a follow up issue to keep track of removing messaging.kafka.connect_errors.count.


Remove reference to $PATH

Describe the bug
Swift: Path describes the default to "search in $PATH".  This does not make sense on Windows, where in cmd it would be %Path%, or $env:Path or ${env:Path} with PowerShell.  We should use generic terms to describe this rather than platform specific terminology.
To Reproduce
Steps to reproduce the behavior:

Go to 'Settings'
Scroll down to 'Swift: Path'
See error

Expected behavior
Use of generic or platform specific descriptions
Environment

OS: Windows
Swift version: compnerd.org Swift version 5.9-dev (LLVM 4d1942b06350403, Swift 49e928406444aa1)
Visual Studio Code version: 1.79.2
vscode-swift version: v1.3.0

Additional context

What about "The path of the folder containing the Swift executables. The default is to look in the PATH environment variable.

@adam-fowler I personally prefer directory over folder due to my Linux background but that’s exactly what I had in mind.


Constraints on parameters that have identical "internal" names

Discussed in https://github.com/janluke/cloup/discussions/77

Originally posted by Mitmischer July 16, 2021
Hello,
not sure if that is a feature request or if it already exists, so I'm starting it as discussion :)
Consider the following minimal example:
import cloup
import cloup.constraints

@cloup.command()
@cloup.option_group(
    "group",
    cloup.option("--a", "a"),
    cloup.option("--b", "a"),
    constraint=cloup.constraints.mutually_exclusive
)
def main(**kw):
    pass

(As it is, the CLI does not make sense. My use case is that a should contain a list of files, but the user may also specify a folder. In that case, I'll convert the folder content to a list of files. I'd personally prefer two parameters, but I'm moving from an argparse CLI to click and I want to keep changes minimal in order to sell it)
Running the example gives the following error ...
python3 main.py --a "hello"
Usage: main.py [OPTIONS]
Try 'main.py --help' for help.

Error: the following parameters are mutually exclusive:
  --a
  --b

... which is not surprising if arguments are found by name. Are there plans to get this (corner case) into cloup?

Closing because I've no intention to fix this, at least not in the general case described. I may open another issue in the future regarding the particular case of "feature switches".


input 等元素 没有结束标签 会显示不出来

错误写法:
<input type="text">
正确写法：
<input type="text"/>

This PR/issue doesn't received response since Weex migrated to Apache two years ago and this repository is no longer active yet.
Feel free to ask question in new repository and thanks for your contribution.

This issue is outdated for a long time and will be closed now. You can create a new one if you still have questions.


The best MAE loss is 4.29 (compared to 3.2). Is there an issue with this result?

lr-1e-3, aug-false, bacth-16
No other parameters have been modified.

Have you tried using augmented data and training more epochs?

这是来自QQ邮箱的假期自动回复邮件。你好，你的邮件我已收到！


Subscriber methods are invoked even after the object is unregistered

The Context
I've an Android app built using MVP design. The Presenter unregisters itself from the EventBus, onDestroy of its associated activity.
I've a MediaPlayer service that posts events, some of whose consumers are in one Presenter (say PresenterA of ActivityA) and the others in another Presenter (PresenterB of ActivityB).
Now when I move from one ActivityA to ActivityB (via MainActivity that has options to navigate to any of these two activities), I see that the subscribed methods of supposedly lost Presenter gets invoked inspite of it being unregistered successfully.
I tested this unregisteration state by doing it twice, to get the below warning in my log:
W/EventBus: Subscriber to unregister was not registered before: ...
The Issue (as I see it)
Now because the EventBus holds stale reference to this Presenter, this method gets invoked and throws NPE like below:
E/EventBus: Could not dispatch event: class com.demo.MediaPlayerPreparedEvent to subscribing class class com.demo.presenters.PresenterA
java.lang.NullPointerException: Attempt to invoke interface method ...

I'd appreciate your advice on this.

I assume you are calling resgister(this) in onCreate() and unregister(this) in onDestroy().
Are you aware that the new activity will go up to onResume() while the old activity remains in onPause()? Only after that the old activity will be stopped and destroyed. See Coordinating activities in the Android Activity Lifecycle documentation.
However, the error message sounds like something in your subscriber method can be null before unregister() in onDestroy() is called.
-ut

Your assumption is right on when I (un)register Eventbus.
"However, the error message sounds like something in your subscriber method can be null before unregister() in onDestroy() is called." has more likelyhood in my case. The MediaPlayer service updates its media play progress (say in the interval of every 500 milli-seconds) by way of EventBus event that the Presenter subscribes to.
I typically set the view to null in my presenter's onDestroy() after Eventbus.unregister(..). The question is after the unregister(..) of Eventbus is called the possibility of NPE shouldn't exist.
I see the unregister method definition like below:
List<Class<?>> subscribedTypes = typesBySubscriber.get(subscriber);
        if (subscribedTypes != null) {
            for (Class<?> eventType : subscribedTypes) {
                unsubscribeByEventType(subscriber, eventType);
            }
            typesBySubscriber.remove(subscriber);
        }
        ...

Would executing typesBySubscriber.remove(subscriber); before the for loop help resolve this issue?
And FYI, I resolved this issue by wrapping the view in presenter with WeakReference<>. Even as this issue is resolved this way, I'm just wondering that this issue could be resolved at EventBus.
Let me know your thoughts.

Your suggested change should not make a difference. When posting only subscriptionsByEventType is used to determine the subscribers that should receive the event.
Great to hear the issue is resolved.
-ut


Json Results with sub-datas ?

Hi, i try to use results prop with this JSON sample :

My columns definition :
		const relationshipsColumnsMetadata = [
				{
					"columnName": "person_first_name",
					"displayName": "Firsname"
				},
				{
					"columnName": "person.last_name",
					"displayName": "Lastname"
				},
				{
					"columnName": "title",
					"displayName": "Title"
				}
			]

			const options = {
				columns: ['title', 'person.first_name', 'person.last_name'],
				columnMetadata: relationshipsColumnsMetadata
			}

Its seems that Griddle can not process datas with sub-object. Here is a way to do this ?

There is a workaround using customComponent.  See my stackoverflow answer: http://stackoverflow.com/a/40051633/1824669

Duplicates issue #213

Thanks @cniesen . This is a basic use case, Do you plan to solve in 1.0.0 ?

I'm not a griddle developer.  Like you I ran into the same issue with Griddle 0.6 and needed a solution.


Convert query escapes to stringByAddingPercentEncodingWithAllowedCharacters

Since watchOS requires us to use stringByAddingPercentEncodingWithAllowedCharacters, we've migrated over to that. We're also using the logic that has been baked in to AlamoFire.
Note this does have one backwards compatible issue. / and ? are no longer encoded in the query parameters, per RFC 3986.
 In RFC 3986 - Section 3.4, it states that the "?" and "/" characters should not be escaped to allow
 query strings to include a URL. Therefore, all "reserved" characters with the exception of "?" and "/"
 should be percent-escaped in the query string.
    - parameter string: The string to be percent-escaped.
    - returns: The percent-escaped string.

@cnoon want to take a look?

This looks good to me dude! 👍🏼

It would be better if we can have a flag for that :)


chore(deps): update dependency @types/node to v11

This PR contains the following updates:

Package
Type
Update
Change
References

@types/node
devDependencies
major
^10.12.18 -> ^11.0.0
source

Renovate configuration
:date: Schedule: At any time (no schedule defined).
:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.
:recycle: Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".
:no_bell: Ignore: Close this PR and you won't be reminded about this update again.

This PR has been generated by Renovate Bot.

Coverage remained the same at 94.35% when pulling 637cb5d378cb5438707ff62ddd0a16ff4d1ffa0a on renovate/node-11.x into 9e6d20ea671fbd61b0fa60edae8e38cacd76b926 on master.

Renovate Ignore Notification
As this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for any future 11.x releases. However, if you upgrade to 11.x manually then Renovate will then reenable updates for minor and patch updates automatically.
If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.


Investigate dependence detection problem when using Candl in Pluto

I assume it would be something related to the OpenScop I generate, especially the those flipped signs in the access relations.


Do not create LocalChanges when inserting synced resources

Fixes #300

https://github.com/google/android-fhir/pull/294 has been merged. So please rebase your branch onto master (or merge master into your feature branch if rebase is too difficult) and follow this section in the developer's guide to set up your environment to use the new coding conventions. Thanks!

thanks @deepankarb :)
same in this PR: what tests should we have had that should have failed for this code change?

@jingtang10 Individually both resource sync and local change management work fine. Integration tests for resource sync are missing :)

can you create an issue and link here?


Add equation to input page

The input page has no info on the equations used. We should add the equation on the input page.

First pass at addressing this: https://github.com/fire-library/openfire/pull/19
Note that I have not added introductions to all of the methods. We can go back and do that once we have agreed that the current design is the way to go. Have a look. I'm going to merge now and create a new release.


you have to be inside an angular-cli project in order to use the serve command

Hi everyone,
recently i cloned a repository from bitbucked made by myselft in angular 2, but after clone i executed npm install, and install modules but when i try to run "ng serve" tell me:
you have to be inside an angular-cli project in order to use the serve command
in the machine where was created works very well

Please keep GitHub issues for bug reports / feature requests. Better avenues for troubleshooting / questions are stack overflow, gitter, mailing list, etc.


The warm up task: fetch records from airtable

This is an initila airtable fetch action.
How to test it:
Url:  https://deploy-preview-38--wehelpvip.netlify.app/cars
The table should be displayed

Perfect!


Fix for accessory state switch error

The accessory state would be error if control with Home App and Siri together. As the log bellow, control by Home App, state will be 1 or 0. But by Siri, state will be true or false.
[5/1/2017, 12:09:06 PM] [Broadlink RM] TV On/Off setSwitchState: true
[5/1/2017, 12:09:06 PM] [Broadlink RM] TV On/Off setSwitchState: already true
[5/1/2017, 12:09:18 PM] [Broadlink RM] TV On/Off setSwitchState: 0
[5/1/2017, 12:09:18 PM] [Broadlink RM] TV On/Off sendHex (<IP_ADDRESS>; ****)
[5/1/2017, 12:09:20 PM] [HomeAssistant] Received event: ping
[5/1/2017, 12:09:27 PM] [Broadlink RM] TV On/Off setSwitchState: false
[5/1/2017, 12:09:27 PM] [Broadlink RM] TV On/Off sendHex (<IP_ADDRESS>; ****)
[5/1/2017, 12:10:01 PM] [Broadlink RM] TV On/Off setSwitchState: false
[5/1/2017, 12:10:01 PM] [Broadlink RM] TV On/Off setSwitchState: already false

How odd - good catch!


Buggy speakers page dialogs on  small screen touch devices

On a desktop, when the user hovers a person the extended dialog appears detailing the sessions and other details of that particular speaker. As soon as the user hovers away, the dialog closes and the user can view the details of any other speaker.
However, while using a mobile browser, there is an erratic behaviour wherein opening a dialog of a speaker(by clicking on his/her picture) opens the dialog.
This is where the issue comes in. There is no way of closing that dialog, unless some other speaker's picture is clicked.
Furthermore due to a single speaker occupying the entire screen in horizontal as well as portrait mode the speaker immediately below the selected speaker gets blocked completely and can't be clicked on to view any details. All these quirks lead to a rather buggy experience.
All this can be fixed by implementing a simple fix.
On clicking the selected speaker again the dialog should close and the user may continue to browse the page.
To make the issue more clear here is an example on how to generate it:

There are two speakers visible right now. If a user clicks on the first one(Abdul Rauf), the dialog opens revealing the details but completely blocking the next speaker (Abhishek Agrawal) as shown here :

The only way to close the first dialog is to click on the third or any other speaker , thereby leading to an overall buggy experience.
I would like to work on this.

@CosmicCoder96  Great find. Please go Ahead. Thanks!!

Make sense @CosmicCoder96, Thanks :)


Turn on all vectors

go back to evaluating all selectors for all sims as it looks like 6.3.1 fixed it

After little bit of testing it looks like it is still shitty...


Add option for uploading files in message edit.

This is another half of PR by @tommyip, currently, I've rebased on top of latest master and resolved merge conflicts.
Next task is to split this into more sensible commits.
@timabbott FYI.

Link to the previous PR: #5752
I think this is how it looks earlier(as no GIF is available in the previous PR)

Thanks for working on this @shubhamdhama!  I did some work to extract this into smaller refactor pieces, and merged the 4 commits ending in 6638c12aef13428bdec5ae3b7cd13f17c7237f8e.  What remains is on the timabbott/upload-rebase branch, and feels pretty clean.
What I don't get is that neither your branch nor mine works on my Chrome with Linux system; any idea why?  Copying @tommyip in case he can help debug.

What I don't get is that neither your branch nor mine works on my Chrome with Linux system; any idea why? Copying @tommyip in case he can help debug.

@timabbott interesting because I'm working on Chrome with Linux too, and the GIF posted above is from the same. Do you mean icon to upload files isn't showing up or it's failing while uploading?

What happens for me is that I click the paperclick icon in the message edit UI, and then I select a file and it closes that dialog, but no link link appears in the message edit textarea...
(Can you grab the branch from my repo and sync it here?  You'll need to use git remote add to access it easily).

@timabbott here is the GIF of the branch from your fork and it's working fine.

Hmm, it still doesn't work for me.  Can you update the PR from my branch?  I want to try asking another developer to test this to see whether anyone else can reproduce it working (or not), and might as well have them start with a version without merge conflicts.

Updated from timabbott/upload-rebase and rebased to latest master.

@shubhamdhama can you rebase, and also mark this as fixing #198 in the commit message?
I think the next thing to try is test-deploying it on nightly to simplify debugging why it doesn't work for me but does for you.  @aero31aero can you help with that?

Currently I'm away from computer(for next 3days due to exams), I will ping Rohit when rebased.

Updated and still working locally. @aero31aero can you test deploy this on nightly. Thanks.

@shubhamdhama can you rebase this?

@timabbott Rebased.
(looks like zulipbot is down)

@shubhamdhama I tested just now, and for me at least, I don't get anything appearing in either the compose or file upload area.

Is this updated PR deployed on chat.zulip.org?

Hey! Sorry I was away from the computer and didn't check github notifs. Does this still need deploying?

Test-deploying the new version on chat.zulip.org.

@timabbott Fixed the bug and manually tested for many cases:

upload using pencil-icon
upload using left-arrow key
upload using i+enter

I hope this will work now for you :crossed_fingers:

Nice, this is great.  Merged, thanks @shubhamdhama!  And thanks @tommyip for getting this started.


Slides: UT Snippets Added

Description
Added slides UT snippets using Google Identity Services.
Below fixes:
b/233569364 - slides_copy_presentation
b/233569581 - slides_create_image
b/233569831 - slides_create_slide
b/233569725 - slides_create_textbox_with_text
b/233569583 - slides_create_presentation
Has it been tested?

[X] Development testing done
[X] Unit or integration test implemented

Checklist

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have performed a peer-reviewed with team member(s)
[ ] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[X] Any dependent changes have been merged and published in downstream modules

This and #97 both have the same changes and are way too large -- lots of files and several unrelated changes. Please reapply these as smaller units. A large # of files is OK if making the same change repeatedly. But when that's mixed in with other changes and unrelated files, it gets a little unwieldy.

Out of sync so closing PR


Question : replay attacks - Fake-TLS vs Secure randomized-packet-size

I have two question.
Does this project have Protection from replay attacks ???
I have a VPS and I run a website with https on this server. For preventing from DPI detection, Fake-TLS protocol (use my website domain for fake tls domain) is better or secure mode with randomize packet size (Specially in countries like Iran) ????

Fake TLS is more secure


Consider releasing Pydantic V2 under a different python package name.

Initial Checks

[X] I confirm that I'm using Pydantic V2 installed directly from the main branch, or equivalent

Description
As projects across our org (Netflix) have been pulling the v2 release, they are breaking in pretty significant ways. Would the project maintainers consider renaming the python package to pydantic2 (probably core as well) so users can install both at once and start migrating safely and incrementally? It appears you are already doing branch based development so the patch to release to a new package name should be straightforward, although there are a few non relative imports that would have to be fixed. Understood that purging existing 2.x artifacts might be tough - doing this before the 2.x release would have been easier. A potential way to work around that would be to start releasing 1.x to pydantic1 (and emulate what ES does where the non versioned package name is always the latest major, but libraries can pin to their major version as well to cohabitate)
In particular, I'm a maintainer of a library which uses pydantic, and it's somewhat difficult to write and test code that works with both v1 and v2 consumers of the library. If they were different package names it would just work. I've seen this approach from FastAPI to try to work around this and stay compatible, but that just seems exceptionally unfortunate.
The technique of using a separate package name for major API changes is successfully used across the python ecosystem, examples are the boto -> boto3 transition, the Elasticsearch clients have done it since 5.0.
Example Code
No response
Python, Pydantic & OS Version
$ .tox/py/bin/python -c "import pydantic.version; print(pydantic.version.version_info())"

             pydantic version: 2.0.2
        pydantic-core version: 2.1.2 release build profile
                 install path: <venv path>
               python version: 3.8.10 (default, May 26 2023, 14:05:08)  [GCC 9.4.0]
                     platform: Linux-5.15.0-76-generic-x86_64-with-glibc2.29
     optional deps. installed: ['typing-extensions']

Selected Assignee: @samuelcolvin

Also I'm aware of #5402 but I just wanted to surface just how much pain this is causing at least for our organization and provide a forum for others to surface the pain as well. Application owners have been scrambling to fix builds all week. For a library owner, there is no way forward other than building the compatibility shims or coordinating with consuming applications to perform the upgrade.

I'm very sorry about the breaking changes that come with Pydantic V2; unfortunately most are unavoidable consequences of fixing quirks in V2 behaviour, the rest are results of the comprehensive rewrite we've tried very hard to limit these

I and others here really love pydantic and I'm sure that the V2 changes are great, it has made its way into many projects here because developers really find value in this package (and fastapi). Let me start by saying I understand how hard open source maintenance is, and I appreciate your efforts. This issue was to surface the user pain and ask for a reasonably small ask that would relieve a large amount of that pain, and probably relieve a large amount of pain for the maintainers because you don't have to deal with all the "you broke me" issues.

We're not going to release a pydantic2 package, and the right place to discuss such things is on the existing issues https://github.com/pydantic/pydantic/discussions/5402 and https://github.com/pydantic/pydantic/discussions/4649 which already have a lot of detailed discussion.

Yeah I found those, and I just wanted to surface this is a real issue and how accurate @tlambert03 is in their arguments. As a library owner trying to support both applications that have v1 and v2 is difficult. The standard way in the python ecosystem to release a backwards incompatible library is to rename the package so the versions can cohabitate. I'd be surprised if other people are not running into this as well.

I'm very surprised that a large, knowledgeable organisations like Netflix have had problems with V2 breaking things unexpectedly. Do you not pin dependencies and write unit tests?

Some applications have unit tests and only their builds broke (which is still work) - some applications don't have thorough test coverage and broke in production (not assigning blame, just sharing experiences).
Most software at large companies doesn't do max version pinning since we want to stay on latest, and usually when large major breaking API changes are introduced the packages are renamed to avoid large amounts of user pain. Netflix is a relatively small Python shop (mostly does Java), but at my previous company Yelp which had 10+ million lines of python, library authors were forbidden from breaking their public API without a package name change due to the hundreds of hours of work that go into upgrading when libraries break compatibility.

Even if you are having those problems, releasing a pydantic2 package wouldn't help - running pip install pydantic would still install pydantic >2. It goes without saying that yanking or deleting Pydantic V2 releases in PyPI, conda-forge and the many linux distributions that ship pydantic is an absolute non-starter.

This is not accurate reasoning. With a separate package name, libraries can depend on the major API they depend on, and then applications can pick whatever version is best for them. With different names, different parts of the apps don't have to agree instead major versions can cohabitate. Even if you just released the old packages with a version number suffix (like Elasticsearch has done) that would resolve it because the library can dep pydantic1, until you release pydantic2 and then they can dep that. Releasing a pydantic2 package in addition would also help folks move forwards because we can forward roll libraries to pydantic2 while apps stay pinned to pydantic<2. I can

if you're using pydantic as an application, pin to <2 until you have time to upgrade

Yup we've already been going through and pinning applications to <2 (since most folks don't pre-emptively max pin) and are now scheduling a few engineering weeks of time to go upgrade all the broken applications since we would like to stay on latest - I fear though that a lot of folks will just say pinned down for a long time.

if you're using pydantic as a package, either pin to <2 or implement separate logic to support both V1 and V2 as FastAPI has done

Pinning to <2 breaks any including application that has upgraded to >=2. The only path forward for a library is to do the (frankly complex) hacks that FastAPI has done to cohabitate. The simpler thing from a maintenance perspective would actually be to vendor the package in entirety and rename the package to pydantic1 ourselves (like you did in v2 with the pydantic.v1 package).

in either case you can use from pydantic.v1 import BaseModel, ... to continue to use pydantic V1 while you're upgrading to V2

No this doesn't solve the problem for libraries since the don't control the version that is installed by the application. Most applications are just pinning fwiw since they don't want to introduce the changes that can break.

use bump-pydantic to help automate the upgrade to V2, I've heard people have found it very useful

Yes for applications this is useful, thank you to whoever built that. For libraries it is not useful because the library doesn't control the installed version.

sorry to hear you're hurting here...

No this doesn't solve the problem for libraries since the don't control the version that is installed by the application. Most applications are just pinning fwiw since they don't want to introduce the changes that can break.

doesn't it help a little bit?  For our libraries we've been doing this somewhere internally
try:
    from pydantic import v1 as pydantic
except ImportError:
    import pydantic

so, if you end up with v2, you're fine, and if you end up with v1, you're also fine

To make try to make some positive light of this conversation, I think it would be really helpful if you could share specifics on how things broke, either publicly or privately, if that’s easier. Something like X number of applications hit errors related to this change, Y applications were broken by this other change, etc. That data would be really useful in identifying ways we can make the upgrade less likely to break things in the first place. Like Samuel said some changes are unavoidable but they can be soften by adding shims with deprecations warnings or at least documenting clearer migration paths.

sorry to hear you're hurting here...

No this doesn't solve the problem for libraries since the don't control the version that is installed by the application. Most applications are just pinning fwiw since they don't want to introduce the changes that can break.

doesn't it help a little bit? For our libraries we've been doing this somewhere internally
try:
    from pydantic import v1 as pydantic
except ImportError:
    import pydantic

so, if you end up with v2, you're fine, and if you end up with v1, you're also fine

It does help by avoiding the <2 version pin in the library, which is obviously a non-starter since that then breaks including apps that have upgraded. It doesn't allow the libraries to upgrade and move before the applications, as the library has to wait for all consuming applications to bump to v2, then they can release a version of the library that deps v2.

To make try to make some positive light of this conversation, I think it would be really helpful if you could share specifics on how things broke, either publicly or privately, if that’s easier. Something like X number of applications hit errors related to this change, Y applications were broken by this other change, etc.

I don't think we've been centrally tracking this, but from looking at support requests this week I can estimate around ~10 applications were broken, and from dependency reports it seems there are around ~54 apps/libraries that depend on pydantic. Most folks are pulling it through central libraries which depend on pydantic (transitive deps). We've just been introducing <2 pins into consuming applications preemptively to try to stem the tide since the central libraries can't <2 pin.
I think most breaking issues are coming from more strict validations on input data, which are (maybe?) good.
For example a cli that automates SSHing across a fleet of machines broke in production with a validation error because a particular target application didn't have a field set:
__pydantic_self__.__pydantic_validator__.validate_python(data, self_instance=__pydantic_self__)
pydantic_core._pydantic_core.ValidationError: 1 validation error for AppAttributes
monitorBucketType
  Field required [type=missing, input_value={'name': '<redacted>'], 'tags': ['']}, input_type=dict]
    For further information visit https://errors.pydantic.dev/2.0.1/v/missing

I believe the issue there is the field was Optional but didn't declare a proper default due to a typo dafault instead of default (monitor_bucket_type: Optional[str] = Field(dafault=None, alias="monitorBucketType")). The test cases always provided the field so the unit tests didn't catch it a.k.a didn't have full test coverage. The code receiving that object handled None or non-None values, and the record wraps a remote JSON API so strict validation is probably not wise as it is.
The issue I personally ran into was while trying to make an unrelated change to the service-capacity-modeling library we use for capacity planning tests failed because previously 436.5 was being cast to 436 and everything was fine
service_capacity_modeling/hardware/__init__.py:23: in load_hardware
    return Hardware(**hardware)
E   pydantic_core._pydantic_core.ValidationError: 1 validation error for Hardware
E   instances.`i4i.large`.drive.size_gib
E     Input should be a valid integer, got a number with a fractional part [type=int_from_float, input_value=436.5, input_type=float]
E       For further information visit https://errors.pydantic.dev/2.1.2/v/int_from_float

This just broke builds, the upstream application had already pinned to <2 so no production issues there. While working on these fixes I started asking our central Python team "how am I supposed to support both v1 and v2" and that lead here because it was basically "we're pinning all apps to <2 until we can schedule the time to upgrade and test each of these apps".

how am I supposed to support both v1 and v2

yeah, this is really the tough thing for libs.  I've been creating per-package pydantic_compat modules like this one that allow me to support both v1 and v2.  But, it's a lot of work, and a different part of the API for each package (so efforts to centralize my "pydantic-compat" strategy have been hard)

I acknowledge this problem, we (the pydantic) team have had it too.
If there's a clever way around this, we're happy to consider it, but I fear this is just how it is.

As a tip/something-helpful, I've found using poetry can help fir cases like this, as it can use semantic versioning to figure out which library versions to pull.
It can read the requirements of each library/dependency recursively and figure out exactly what libraries to install for the local project.  If there is a conflict, where two versions of the same dependency need to be installed it will indicate it up-front while updating the project dependencies to new versions.
It's standard practice with poetry to pin to the major version number.  When you do a poetry add pydantic, it will do this in the projects dependency list:
pydantic = "^2"

This tells poetry that it can use any version of pydantic as long as it's at least 2.0.0 but <= to 3.0.0.   Using semantic versioning practices like this with all your dependencies can really help prevent your projects from upgrading to a version of a dependency that might have a breaking change.
Every so often I ask poetry if there is any major version that is available that I have not upgraded to yet via:
poetry show --outdated

Which then shows me exactly what I have not updated to yet (including an major changes that could have breaking changes).
I would not necessarily know that pydantic had a new major version if it changed its package name each time.  So I appreciate them using the same package name, so I can easily discover when they have new major versions.


Add swap-task command

Features added

swap-task command has been introduced to allow for tasklist reording via swapping
Constructor of a Module now requires a Set<Person> argument, in line with the introduction of persons in each Module
Constructor of a JsonAdaptedModule now also requires a Set<JsonAdaptedPerson> argument
JsonAdaptedModule now stores a  Set<JsonAdaptedPerson> argument to facilitate with storage of a module's associated persons

Data file will be discarded if the "persons" : [ ] field is absent

To dos from v1.2 feedback

Refactoring of error messages in add-task and delete-task into the Messages class
Reuse messages defined by @cheeheng with regards to invalid module codes for add-task and delete-task commands
Refactor magic constants in AddTaskCommandTest and DeleteTaskCommandTest
Correcting of non-zero positive integer to positive integer in error message regarding task indexes

Bug fixes

Miscellaneous grammatical and typo errors

Codecov Report
Base: 75.40% // Head: 76.76% // Increases project coverage by +1.35% :tada:

Coverage data is based on head (4f66006) compared to base (912c796).
Patch coverage: 94.83% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #90      +/-   ##
============================================
+ Coverage     75.40%   76.76%   +1.35%
- Complexity      645      679      +34
============================================
  Files           106      108       +2
  Lines          1952     2079     +127
  Branches        220      237      +17
============================================
+ Hits           1472     1596     +124
+ Misses          401      400       -1
- Partials         79       83       +4

Impacted Files
Coverage Δ

...main/java/seedu/address/commons/core/Messages.java
0.00% <ø> (ø)

.../java/seedu/address/storage/JsonAdaptedModule.java
94.23% <80.00%> (-5.77%)
:arrow_down:

...address/logic/commands/SwapTaskNumbersCommand.java
93.75% <93.75%> (ø)

...in/java/seedu/address/logic/parser/ParserUtil.java
97.18% <95.45%> (+3.18%)
:arrow_up:

...a/seedu/address/logic/commands/AddLinkCommand.java
93.54% <100.00%> (+0.21%)
:arrow_up:

...a/seedu/address/logic/commands/AddTaskCommand.java
91.66% <100.00%> (ø)

...eedu/address/logic/commands/DeleteLinkCommand.java
91.42% <100.00%> (+0.25%)
:arrow_up:

...eedu/address/logic/commands/DeleteTaskCommand.java
95.00% <100.00%> (ø)

...edu/address/logic/parser/AddTaskCommandParser.java
100.00% <100.00%> (ø)

.../seedu/address/logic/parser/AddressBookParser.java
75.00% <100.00%> (+8.33%)
:arrow_up:

... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Feat: snap points with <Drawer.SnapPoint />

First of all, thank you Emil for your amazing work.
I tried the snap points feature and it wasn't a good solution for me as the expected snap points weren't the same when i tried Firefox, also there's no way to handle the responsive part as the snap points would not be the same (or it will be a small headache with useMediaQuery)
Ideally, a perfect solution for me would be like this
<Drawer.Root>
  <Drawer.Trigger>Open</Drawer.Trigger>
    <Drawer.Portal>
      <Drawer.Content>
        {/** some content **/}
        <Drawer.SnapPoint />
        {/** some content **/}
        <Drawer.SnapPoint />
        {/** some content **/}
        <Drawer.SnapPoint />
      </Drawer.Content>
      <Drawer.Overlay />
    </Drawer.Portal>
</Drawer.Root>

If you are okey, i would like to work on this 😊
Any thoughts?

Please be clearer and more specific in terms of what your proposal is. As it is, i for one have no idea.

The idea was to make a discussion on how to implement it 😊.
i was thinking about something like this
cosnt SnapPoint = () => {
  const { parentRef, setSnapPoints } = useContext(drawerContext)
  const ref = useRef(null)
  useEffect(()=>{
    // calculate the offset and set it
  },[])

  return <div ref={ref} />
}
```

I like this. Snap points based on content height instead of hard-coded values

I like it, feel free to code a PR.


Tutorial Page iot-part3-posting-data-hana.md Issue. PROD

Tutorial issue found: https://github.com/SAPDocuments/Tutorials/blob/master/tutorials/iot-part3-posting-data-hana/iot-part3-posting-data-hana.md contains invalid primary tag.
Your tutorial was not created. Please double-check primary tag property.
Each tutorial md-file shall have primary tag provided above. Example:
---
title: Text Bundles within Node.js SAP HANA applications
description: Working with text bundles in Node.js
primary_tag: products>sap-hana
tags: [ tutorial>intermediate, products>sap-hana, products>sap-hana--express-edition ]
---
Affected server: PROD

corrected.


ARROW-11320: [C++] Try to strengthen temporary dir creation

Make the random generator seed a bit more unique.
When a temporary name already exists, retry with another one instead of bailing out.

cc @westonpace Do you want to review this?

cc @westonpace Do you want to review this?

Travis-CI build: https://travis-ci.com/github/pitrou/arrow/builds/213944945 . Will merge.

Travis-CI build: https://travis-ci.com/github/pitrou/arrow/builds/213944945 . Will merge.


.length not always working on strings

eg.
Input:
var st = 'testing';
var hmm = st.length;
console.log(st.length);

Output:
$st = 'testing';
$hmm = strlen($st);
$console->log(count($console));

I am working on a fix.

This is partially fixed in my other pull request
https://github.com/endel/js2php/pull/29

Thanks for the pull-request, @2pha! 👏
Just released 0.1.1 with your fixes.


Crash during image saving to camera roll

If gallery item was created with itemWithImage gallery crashes when user tries to save image to camera roll.
This happens here in saveImages method of MHShareViewController classs
 [self getAllImagesForSelectedRows:^(NSArray *images) {
        for (MHImageURL *dataURL in images) {

            if ([dataURL.image isKindOfClass:[UIImage class]]) {

images array contains UIImage and dataURL.image crashes everything

I am going to fix this next week guys.

Hello @mariohahn, Thanks for this library
Do you have any news concerning this issue?
I use your library in a Messaging app, i already use SDWebimage to download and Cache images previously in the app. When I tap on the image to enlarge it, i use your browser but i dont want to reload the image through your library.
So i can find the image in my SD Cache and just display it through [MHGalleryItem itemWithImage:], but there is this share issue...
Thanks for your help

I encountered the same problem today. I think the problem is that an MHImageURL instance is not created when the MHGalleryItem is instantiated with itemWithImage
I suggest to make the following change to fix this problem:
Line 876 of file

MHShareViewController.m

MHImageURL *imageURLMH = [MHImageURL.alloc initWithURL:item.URLString
                                                                 image:item.image];
                [weakSelf addDataToDownloadArray:imageURLMH];

Thanks!


IOW place names when dealing with HAM

The IOW place names are not being seen when I am updating the HAM PARMS. IOW is a subset of HAM.

@geoffj-FUG Should IOW be incorporated into HAM or remain as a separate county?

Kirk
IOW is part of HAM. But it can be enumerated as IOW or HAM.
We need the Chapman Code model of level 2 HAM level 3 HAM or IOW for validation of POBs.
As far as PARMS is concerned they can be one County.
PARMS and validating are using the same Gazetteer for 2 different purposes.
Geoff

Kirk
All good
These are now linked
This can be closed
Geoff
From: Kirk Dawson @.>
Sent: Wednesday, March 31, 2021 2:52 AM
To: FreeUKGen/FreeCENMigration @.>
Cc: geoffj-FUG @.>; Mention @.>
Subject: Re: [FreeUKGen/FreeCENMigration] IOW place names when dealing with HAM (#1162)
@geoffj-FUG https://github.com/geoffj-FUG  deployed
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/FreeUKGen/FreeCENMigration/issues/1162#issuecomment-810418446 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AKCPIFMJXHBPRMMWISMICEDTGH6RPANCNFSM4X56VPYA .  https://github.com/notifications/beacon/AKCPIFMOIXG3NDTTBCAVAQTTGH6RPA5CNFSM4X56VPYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOGBHACDQ.gif


Copy clipboard feature

Following features should be added

cp, copy  : Copies password of given item to clipboard.
cpf, copy-forget  : Copies password of given item to clipboard and clears clipboard after x seconds.

09921ffbf60fb1b4b2e56458f17f2117809be9b2 and 6d1b9941e5f511105d5abe0c6b36e79396894d6e


jenv java-version to source control

for consideration:
We call out jenv for use in the README, so consider including the .java-version in source control. If it means anything I see other projects committing .java-version to source control (https://github.com/nebula-plugins/gradle-netflixoss-project-plugin/blob/master/.java-version)
(... also I wanted a PR to test out the previous commit just to make absolute sure actions was working as intended, https://github.com/openrewrite/rewrite-java-8/commit/86437e1a8a4ff4b9a4f71c9bd13be712194ccb1a)
feel free to close whenever

I personally am for checking in .java-version files, or at least some indicator of what JDK to use, as so many projects omit it and then you have to play a guessing game to figure out what it actually needs to build...


Minor-copy-edit

Summary
Super minor, but it kept on bothering me.
Please update the same at https://learn.microsoft.com/en-us/samples/dotnet/samples/performance-allocations/?source=docs

I think the orleans lint issues have been fixed. Closing and reopening for a fresh build.

@BillWagner Awesome! Thank you for looking into it. 👍


Show plotting statistics

Column Moving: I would love it if I could drag columns left and right to where I desire. There's a lot of columns and scrolling to see what I want is a little annoying.
Average Time: Forgive me if this already exists, but it would be useful to have column that shows average plotting time for each plotter. I'm assuming you already do this in the background to determine if a plot is running "slow". It would be nice to see this for ourselves.

+1 and hiding columns.  Also to persist the column sizing during restarts as well.

Reordering columns: https://github.com/grayfallstown/Chia-Plot-Status/issues/36#issuecomment-843351280

There is a new Menu Entry for Statistics in the next release.

This is in the 0.10.1 Release


Do not trigger unhandled promise rejections in BidiMapper

Use catch instead of reject.
Closes #411

@sadym-chromium PTAL.

This is now fully ready for re-review


Tools for serial ports as container

It should be possible and easy for a Leda user to configure and troubleshoot serial ports.
Example use cases:
Enabling GPS HAT requires testing via "AT" commands on serial port.
Vendor documentaiton of the GPS HAT often is based on RaspiOS tutorials, which can rebuild .c files natively, and serial terminals like minicom are either preinstalled or can easily be installed via apt.
On Leda, it's much harder to get the tools installed. Our concept for that is containers. But there are no prebuilt containers for such tools (or they are very outdated, or for wrong platform etc.).
Leda should provide tutorial / documentation / preconfigured container descriptor or maybe even container images with the following tools (list is not exclusive):

minicom - good for manual testing
qmicli - mentioned/used in the Waveshare GPS HAT docs and scripts)
maybe there are tools for "probing" serial ports (like nmap). If not, we may implement a simple one with pyserial, just probing for GPS or Modems by using "AT" commands.

It's also good to document how to configure the containers, e.g. do they need to run in privileged more, or can serial devices be mapped into Kanto containers etc. How does the sysfs filesystem under /sys mapped into the containers. Does it require write access or additional Linux capabilities (permission).
Current manual workflow:
for each serial device:
 stty -F 115200 /dev/ttyUSB3
 cat /dev/ttyUSB3
 echo "AT" > /dev/ttyUSB3

Let's focus on specific GPS and GSM devices.

I would suggest picocom instead of minicom. It has less dependencies and does the job. There is also a recipe available. stty is part of the system anyway.
If gpsd should run on the host, it would be good to have those tools also available on the host system.
Depending on how Kanto provides serial access to containers, this could also help with debugging.
Another thought: Usually serial devices can only be used by one process exclusively, I don't know if that will work out with multiple containers that want to access the same device. BTW, this is one of the reasons, why software like gpsd exists.

Hm that's a good point.
The conceptual idea is to have services containerized, e.g. a "Location Service" which can be deployed or undeployed at runtime depending on the needs of the current situation. We also don't know whether the GPS module will be on the same device, or whether it is on another device in the vehicle network (a separate CCU, a separate HPC, ...)
The services expose their interface using a standardized higher-level API to vehicle applications (VSS via Kuksa.VAL databroker).
In our example here, it could look like this:
CAN -> NMEA2000 -> [container: gpsd + kuksa gps2val]  -> [container: VSS databroker] -> [container: vehicle app]
or another setup:
Serial -> NMEA2000 -> [container: gpsd + kuksa gps2val]  -> [container: VSS databroker] -> [container: vehicle app]
or even this kind of setup:
(CCU) -> Proprietary Location Information -> Some/IP via vehicle network (automotive ethernet) -> [container: custom2val]  -> [container: VSS databroker] -> [container: vehicle app]
For the first two scenarios, the difference is only the configuration of gpsd, which is easily done via environment variable or config files mounted into a container. It's not a "static" system configuration per device model any more, but becomes part of the cloud-managed system configuration ("Desired State").
For the third scenario, the interface may be a customized, proprietary implementation, but from the viewpoint of the vehicle app, it's still the same interface. (These kind of things happen a lot in commercial setups)
The general idea of the SDV container layer is to "shrink" the layers related to the base system (OS, drivers, ...) and put more responsibility or flexibility into the top layers, which are more dynamic in nature.
Regarding the "the serial port can only be used by one process" topic: in production mode (eg once configured correctly), it would only be accessed by gpsd. in dev mode, I would stop the gpsd container and start the "serial-tools" container. This is great for development time, troubleshooting, hackathons etc.
And I would only install the deployment descriptors if I have a gps device.

graph TD;
    app-->databroker;
    databroker-->gps2val;
    gps2val-->gpsd;
    gpsd-->serial;
    gpsd-->CAN;
    databroker-->custom2val;
    custom2val-->SomeIP;
    SomeIP-->LocService;

Tio can probe serial ports and work as a simple (good enough) terminal. Implemented in https://github.com/eclipse-leda/meta-leda/pull/198
With this I think the current issue can be closed.


Repair note on deferred deletion

Updated the note text as recommended per the original commit:
https://github.com/docker/docker.github.io/commit/4d09936aefa3a86b96cbf57b4636e0187a04442c
Fixes #4679

FWIW LGTM


[cppbindings] External application build fails if WTF_PTHREAD_THREADED is not defined

The failure is undefined reference to "PlatformGetThreadLocalEventBuffer".
It is inlined in pthreads platform header (https://github.com/google/tracing-framework/blob/master/bindings/cpp/include/wtf/platform/platform_aux_pthreads_threaded_inl.h#L42) which is only included in case WTF_PTHREAD_THREADED is defined:
https://github.com/google/tracing-framework/blob/master/bindings/cpp/include/wtf/platform.h#L52
Could you please clarify whether defining WTF_PTHREAD_THREADED is required while building external application (in this case it would be nice to document it somewhere)..
Thanks!

I don't have the source on this device to check but I believe you are right
with respect to needing that define. I think that if no threading macro is
defined, it just tries to use the std c++ library for threading -- but that
has varying levels of support, even on platforms that otherwise support
c++11.
I'll add some documentation about how to integrate it into other projects.
Tbh, the makefile was just written to allow us to build it standalone
outside of our build environment, so it has not gotten a ton of love.
On Feb 12, 2017 11:39 AM, "Ihor Ivlev"<EMAIL_ADDRESS>wrote:
The failure is undefined reference to "PlatformGetThreadLocalEventBuffer".
It is inlined in pthreads platform header (https://github.com/google/
tracing-framework/blob/master/bindings/cpp/include/wtf/
platform/platform_aux_pthreads_threaded_inl.h#L42) which is only included
in case WTF_PTHREAD_THREADED is defined:
https://github.com/google/tracing-framework/blob/master/
bindings/cpp/include/wtf/platform.h#L52
Could you please clarify whether defining WTF_PTHREAD_THREADED is required
while building external application (in this case it would be nice to
document it somewhere)..
Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/google/tracing-framework/issues/583, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAeKgMZ-w9LFvqYwhj9qsYJ4KCZXv9KZks5rb1_ugaJpZM4L-lsb
.

I finally could figure out the confusing part, in Makefile THREADING defaults to pthreads:
https://github.com/google/tracing-framework/blob/master/bindings/cpp/Makefile#L19
however in platform.h THREADING defaults to std:
https://github.com/google/tracing-framework/blob/master/bindings/cpp/include/wtf/platform.h#L52

I've just pushed some updates to the README and Makefile that address this issue. The default threading library is "std" and the Makefile was confusing because it defaulted to "pthread" (this has been a moving target over the life of this library). Afaik, the only popular platform which needs "pthread" instead of "std" is Android. This has been called out in both the Makefile and README. If that doesn't apply to you, then there should be no additional settings or compile time defines needed.


Improve implant autocomplete

When searching for implants to show as suggestions, it should be more accurate now. Instead of accepting any implants that contains the query we only look at implants names that begin with the query.
I also elected to remove support for accepting partial queries. With the improved autocomplete suggestions, it seems a bit superfluous to keep it in.

I want the autocomplete to perform as a search and not just looking from the start.  An example could be trying to find Combat Surgeon and searching with Surgeon since you forgot the first part, or getting a list of which implants have perfect versions.
Support for partial queries exist mainly as a fallback in the event that autocomplete fails and we don't get the expected input.  Discord does seem to have improved the UX so that isn't as prevalent, but it's still a nice to have


config: Improve default value message

This follows the advice from https://github.com/crc-org/crc/pull/3694#discussion_r1213896610

added a commit to try to see why microshift is failing.

/retest

@cfergeau can you please remove the "CI debug" commit, we can merge this, the microshift CI issue is at least not happening locally on the mac


Bug fix 3.5/fix internal issue 4451

Scope & Purpose
This PR re-enables Dump & Restore suite

Fixed failed Foxx test.
Fixed restore of users.

Backports for 3.4 / 3.6 (devel) are required.

[x] The behavior in this PR can be (and was) manually tested (support / qa / customers can test it)
Yes, execute ./scripts/unittest dump_authentication --cluster true

[x] The behavior change can be verified via automatic tests
Yes, they will run in Jenkins again.

Related Information
(Please reference tickets / specification etc )

[x] There is an internal planning ticket:  #4451
[x] There is a ES-383 (In case a customer was affected / involved):

Testing & Verification
This change is already covered by existing tests, such as (please describe tests).

[x] dump & restore suite

Jenkins: http://jenkins01:8080/view/PR/job/arangodb-matrix-pr/7380/

Next try: http://jenkins01:8080/view/PR/job/arangodb-matrix-pr/7405/

Tests blue!


Implemented UseConfigureAwaitFalse analyzer and code fix

Fix #235

Build is passing: https://ci.appveyor.com/project/code-cracker/code-cracker/build/<IP_ADDRESS>4.

Overall it looks good, it is pretty late now in Brazil, I will finish checking it tomorrow.


Workaround for kubectl desc ns bug

WHAT
The same as title.
Check the indentation in advance not to crash kubecolor when kubecolor describe namespaces with the Resource Quota in the ns.
WHY
kubecolor always assumes that every kubectl describe indentation is made of "2 spaces" because of the implementation.
However, the Resource Quota section in kubectl describe ns output has only 1 space at the head.
This is an issue already reported and the PR was submitted. (As of this kubecolor fix PR submission it is not merged yet.)
It must be checked before the print process.
Related issue (if exists)
https://github.com/dty1er/kubecolor/issues/36

Codecov Report

Merging #39 (b8104f7) into main (7aa7c0f) will increase coverage by 0.65%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   84.28%   84.93%   +0.65%
==========================================
  Files          16       16
  Lines         528      531       +3
==========================================
+ Hits          445      451       +6
+ Misses         74       72       -2
+ Partials        9        8       -1

Impacted Files
Coverage Δ

printer/kubectl_describe.go
94.28% <100.00%> (+9.91%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7aa7c0f...b8104f7. Read the comment docs.

Codecov Report

Merging #39 (b8104f7) into main (7aa7c0f) will increase coverage by 0.65%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   84.28%   84.93%   +0.65%
==========================================
  Files          16       16
  Lines         528      531       +3
==========================================
+ Hits          445      451       +6
+ Misses         74       72       -2
+ Partials        9        8       -1

Impacted Files
Coverage Δ

printer/kubectl_describe.go
94.28% <100.00%> (+9.91%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7aa7c0f...b8104f7. Read the comment docs.

Self-approval...

Self-approval...


InheritableBehaviour: empty child data produces unexpected behaviour

I reported this as a cake bug http://cakephp.lighthouseapp.com/projects/42648-cakephp/tickets/3469-saving-with-empty-fields#ticket-3469-3 which affects InheritableBehaviour
On Cake 2.2.3 I have class B extends class A using CTI.
The problem is that, if I save class B with all class B's fields empty and only setting class A fields, afterSave is not trigger and so nothing gets saved.
Ideally, an empty model B row should be added and then the afterSave trigger should save model A data.

Closing this one, please reopen if needed or send a PR with the unit test added. Thank you


Don't create server directory for embedded Tomcat

Rationale
Not sure what the point of the server directory is here but it creates a different folder structure when deploying an embedded distribution vs just deploying directly with Gradle. This discrepancy causes a lot of trouble for various tests and gradle tasks.
Related Pull Requests

Changes

Don't create server directory for embedded Tomcat

@ankurjuneja Do you recall why this server directory is created? It's been causing a lot of problems when running on TeamCity.


[create] add haunted option

When using npm init @open-wc, users should have the option to choose between LitElement and haunted. LitElement should stay the default recommendation though.

I would also like to contribute to this!

not stale, working on it


List of UI actions that do not capture user identity inside MySQL

Currently, if a user made an UI edit inside the Datahub UI, I can see a new aspect being persisted to MySQL. In the field createdby, I could see the urn of the user who made the change.
However, there are some actions which bafflingly shows the default UNKNOWN_ACTOR identity. We are hoping to use MySQL as a source of truth to see the edits done inside Datahub. The list below is what we found that do not log the identity and uses UNKNOWN_ACTOR:

Create Glossary Node/Term via UI
create domain in UI
add/edit/deactivate policies
edit dataset description (This is pretty critical for us as editing description is a common usecase, and we're trying to see how to patch it. Any advice is appreciated)
create new tag (though, the tag has an aspect ownership which shows the person who created it)

In addition,
All hard delete actions (glossary terms, nodes, domains, policies) will result in records being dropped and we do not know who did it.

@xiphl Thank you for reporting this! We are working internally to prioritize auditing these cases.
Hard delete actions will result in records being dropped, yes. Is the desire to have this event logged in kafka?

For hard deletes, I would prefer that the records be stored on another table inside the datahub schema, that way I only need to refer to MySQL to see what happens. Also, I could still copy records back to the main table if necessary. Does that make sense?

Ie the deleted record table would have 2 more fields to capture the delete time and the user who deleted it. Retention of records can be decided by the DB admin, to prune by date or something

hi @jjoyce0510 when we merged latest changes recently (previously running on early Jun 2022 code), we noticed that the behavior for "creating new tags" have changed. Now, new tags created in UI do not have an owner automatically assigned. Is this a deliberate change? (The changes came from one of the Batch Actions PR)
Because, I currently have policies that only allow tag owners to edit their own tags and add additional owners to the tag. Now, if I were to update my instance, I will end up having to manually assign owners to new tags.

hey @xiphl! we just addressed this issue where we weren't properly setting createdby on changes properly. I just confirmed that all of the actions you listed above are now setting createdby properly so that should be settled now (PR just got merged this morning: https://github.com/datahub-project/datahub/pull/5788)
We also addressed the situation where users creating tags were not longer being added as an owner, also merged in this morning: https://github.com/datahub-project/datahub/pull/5787

Nice! I will check and verify later this week, thanks!

tested and verified, thanks!


Having Offline Issues

hi there, i can't launch the VSCode application when i am offline. any help with that would be very much appreciated.

nope!

Did you at least try digging into the issues proposed by the duplicate detection bot? You provide no info upon your problem, what is your OS, what even your offline means (Airplane mode on? no hardware card? wifi enabled but not connected? etc), or any other info than simply "nope! - it's not what any of the discussion about VSCode not opening in offline mode talked about!".
Have you taken a look at this comment (found using the first link of the bot) : https://github.com/Microsoft/vscode/issues/7570#issuecomment-422815878 ? What did you try? To make it short, there seems to be a problem in electron that messes up the telemetry services, but the newer versions of Electron (which is present in the build provided in the comment I linked) should not have this problem. Did you try using this build to see if your problem still happens?
Without any further information, I'd consider this as a Duplicate of #7570.
Sorry if I sound passive-aggressive in this comment. I just can't understand when developpers file issues not explaining any of the steps they did themselves. What if you were the one to receive this issue? How would you try to help someone filing this issue? There's 0 more information in here that wasn't already discussed in another issue.


Use LibGit2Sharp

Hopefully faster than multiple git calls...

Looks like we are still using git.exe and given that MS has switched with VS 2017 to use git.exe instead of some variant of libgit, maybe we just close this issue?

Fasterness option 1: #208
Fasterness option 2: Powerline with PSGet


Header parsers should omit invalid values as opposed to erroring

Following the robustness principle, in HeaderUtil.ts, we might want to omit invalid headers values from the parsed result as opposed to throwing.

Due to the design flaw of #471 indicated in #743 does that mean that this issue should be closed at least for the moment when the design will be changed ?

No, this one still stands regardless.


add terms for thick/thin pulmonary alveolus wall

add terms for thick/thin pulmonary alveolus wall
increased/decreased pulmonary alveolus wall thickness
child of abnormal pulmonary alveolus wall morphology MP:0010903
PMID:37890669 and a number of existing annotations

Reopening issue to fix typo in the textual definition of MP:0010903 and its new child terms.
For MP:0010903, current definition reads as: any structural anomaly in the tissue that encloses the aveolar space of the lung. This is propagated in the increased/decreased pulmonary alveolus wall thickness terms. Change to "alveolar".

Typo has been fixed.


get_query_info function doesn't use partition_column parameter

System information

Modin version (modin.__version__): 18dc8f83e2ce4668e44042c56954ba15cc893e4f

Describe the problem

get_query_info function doesn't use partition_column parameter which may cause incorrect behavior of experimental read_sql.
The function is in modin/experimental/engines/pandas_on_ray/sql.py file.

Confirmed that this is still present on master - @anmyachev should we assign someone to this? Could you include some context for what kind of bugs this can result in?


Create a recipe for unit testing

Create a model or recipe for a unit test case.

@ashakunt Can you assign this to Alapan? To be completed by 4 March

@Alapan is working on it already.

First recipe for unit testing was pushed to "tests" branch. @Alapan  can provide more details about how to run and its dependencies.

I wrote the tests with Jasmine and Velocity. The commands I used to install them were:
meteor add sanjo:jasmine
meteor add velocity:html-reporter
When starting the localhost application by 'meteor --settings PATH-TO-apinf.config.json', the Velocity UI should show the test results.

For testing the template events I added a new package:
meteor add xolvio:template-isolator

@Alapan Will you open a PR on this task?

@bajiat A pull request was created.

I created a new pull request with branch 'test-recipes' and deleted the 'tests' branch. This was because the earlier branch had conflicts since it was mistakenly created on top of the 'master' branch, and not 'develop'. The commits from 'tests' were cherry-picked to 'test-recipes', and the earlier pull request referencing this issue was closed.

@bajiat @brylie should this be closed now?
cc: @Alapan

Jep.

In the future, include the following text in PR descriptions:

Closes #[issue number]

Github will then automatically close the issue when the PR is merged.


add csi-driver-lvm to storageclasses

Wow. So many new services! Do you have some docs for me to read about them? :D
PR looks good to me.

Wow. So many new services! Do you have some docs for me to read about them? :D
https://kubernetes.io/blog/2019/01/15/container-storage-interface-ga/ :-)


[EDS-573] conditionally show box number

Some folks won't have a box number, check for the data first, then show/not show.
Closes  EDS-573

Hmm, not sure why adding this line to the test above didn't work...
assert html.find(string=re.compile("Last name is"))

Should I see a web driver report in the tests folder?

I keep getting this error
FAILED ../tests/blueprints/test_search_blueprint.py::TestSearchBlueprint::test_render_full_no_box_number - AssertionError: Expected to find a  tag with text including 'download vcard' in
Code is in this commit


update slack to 2.1.1

fixes #179

Thanks!!!
On Friday, August 26, 2016, Christian<EMAIL_ADDRESS>wrote:

Merged #180 https://github.com/jfrazelle/dockerfiles/pull/180.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jfrazelle/dockerfiles/pull/180#event-769242430, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABYNbCAUyGjf9Yb83zR3E5yYzeiRLwSfks5qjykqgaJpZM4JuTtf
.

--
Jessie Frazelle
4096R / D4C4 DD60 0D66 F65A 8EFC  511E 18F3 685C 0022 BFF3
pgp.mit.edu http://pgp.mit.edu/pks/lookup?op=get&search=0x18F3685C0022BFF3


THRIFT-5492: Add readEnd to TBufferedTransport

client: cpp
Add a readEnd implementation to TBufferedTransport which resets the consumed
message size.  Without this it was noticed that calls to the transport's
consume method would slowly decrement the remainingMessageSize_ and the
remainingMessageSize_ was never reset.  A client could send many messages to
the server, eventually bringing remainingMessageSize_ below zero causing an
EOD_OF_FILE exception.

This stage failed.

Job
Xcode
ENV
OS
State

7919.3

SCRIPT="cmake.sh"
Linux
failed

7919.4

SCRIPT="cmake.sh"
Linux
failed

7919.5

SCRIPT="cmake.sh"
Linux
failed

7919.6

SCRIPT="cmake.sh"
Linux
failed

7919.7

SCRIPT="cmake.sh"
Linux
failed

7919.8

SCRIPT="cmake.sh"
Linux
failed

7919.9

SCRIPT="cmake.sh"
Linux
failed

7919.10

SCRIPT="cmake.sh"
Linux
failed

7919.11

SCRIPT="cmake.sh"
Linux
passed

7919.12

SCRIPT="cmake.sh"
Linux
failed

7919.13

SCRIPT="cmake.sh"
Linux
passed

7919.14
xcode11.3
SCRIPT="cmake.sh"
macOS
passed

@Jens-G thanks for pointing out the failures.  Looking at several of them it appears to be because I added to test/StessTest.thrift but only updated test/cpp/src/StessTest.cpp and NOT lib/d/test/stress_test_server.d so there is an unimplemented function.
The fix I made was only under the c++ server; let me see if adding a test under lib/cpp/test/ would be better contained and cover only the c++ server.

Do you think Message Size check is implemented the right way ?
Is this not a protocol concern, rather than a distributed protocol / transport responsibility ?
The functionality is implemented through transport base class function definition. Don't you think it would be better to move these to a different object which responsibility would be to check message size validity ?
Several functions in the implementation are never called (in production code, I haven't checked the tests), code is hard to read and some paths are never reached (resetConsumedMessageSize(long newSize = -1) with actual newSize value).
I do not know enough about the whole Virtual protocol / transport implementation to propose relevant changes to the code, but the current one (I use version 0.14.3) broke my program !

I've moved from 0.11.0 to 0.20.0 and encountered the issue described here, fix in this PR seems to solve it, is there a plan for this change to be merged?

I merged the fix part in 86b05bf, but left the rest, as there are unfortunately still open questions etc.

Thank you, I guess this will be in next thrift release, when do you plan it?

Is the remainder of this PR still valid? Anyone able to comment on the remaining issues?

Thanks @Jens-G for merging the fix; I'm glad it could be of help to a few others.
I've not had time to get back to this issue and update the test; with the fix merged though I think this PR can be closed.  The changes to update the test in this PR need to be reworked to be specific to the c++ server and, if anyone is able, can be taken up in a separate PR.


Question about items value

Items value and label are the same thing in this package? what to do when there are duplicated labels?

Thanks for issue! Released label support in 0.3.0.


Nuxt 3 support

Would it work right away when Nuxt 3 version arrives https://nuxtjs.org/v3/ or further development is needed?
Thanks

I have tested it right now. It doesn't work right now.

Fixed by #65


How to fine tune pretrained  ResNet model in slim with tensorlayer?

I can set network by tl.layers.SlimNetsLayer and can also restore model. My question is  how to set logits to 'restore=False' without modifying the code in resnet_v1.py. Or is there a way to modify?
Thanks for your help.

Solved

@donproc I also met with this problem. Could you give me a detailed discription on how to finetuning?

@baiyancheng20 Hello, did you solve the problem, I want to extract feature of image from resnet, do you know the methods?


Event on point selection change

🚀 Feature
An event we could connect to when the point selection changes
Motivation
Making point selection changes triggers for custom behaviour in plugins
Pitch
Alternatives
There is currently a highlight event we can use but it is less discoverable/intuitive
Additional context

This came up when working on point manipulators in napari-threedee
We might be able to use our existing Selectable model
cc @kevinyamauchi

#5691 implemented psygnal Selection for points selection:
https://psygnal.readthedocs.io/en/latest/API/containers/#psygnal.containers.Selection
As a result, the requested event is already implemented:
https://psygnal.readthedocs.io/en/latest/API/containers/#psygnal.containers._selection.SelectionEvents
I tested and the following can be used
viewer.layers['Points'].selected_data.events.items_changed.connect()
Can we close this?


hasMany deletion error

GORM Playground Link

https://github.com/go-gorm/playground/pull/88
Description

User have some slice properties
Company hasMany Users

In this case panic will occur if we try to delete.
Expected to be able to delete without panic.
This issue occurs when trying to compare structs that cannot be compared.

Slice, map, and function values are not comparable.

https://golang.org/ref/spec#Comparison_operators
Structs with these cannot be compared and will crash at here.

Fixed, thank you for your report, but better to use &user when deleting


Language not set by NotFoundPage attribute

I use the attribute [BVNetwork.NotFound.Core.NotFoundPage.NotFoundPage]
Request URL is "/sv/patrik-testing-invalid-url"
I get pages in master language "en", but I want to get them in "sv"

Start page exists and is published in "sv":

Am I doing something wrong or is this a bug?

I have fixed it. I have uploaded NuGet packages to the Episerver feed but have to wait for those to be approved. Versions: [11.2.2], [10.4.2]

Great, looks nice!


Bumped version to v3.16.0

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 88.597%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
11468

Relevant Lines:
12944

💛  - Coveralls


fix: ignore otp.verified v1 event for usersessions

:tada: This PR is included in version 1.0.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


adding support for multimers via residue_index hack

I'm not sure if I implemented RoPE() residue index offset correctly.
within RoPE() if I use (original behavior):
position = torch.arange(residue_index.shape[0]).cuda()
sinusoid = torch.einsum("..., d->...d", position, self.inv_freq)
sin, cos = torch.sin(sinusoid), torch.cos(sinusoid)

The multimer is correctly predicted

if I instead use: (where the residue_index is offset by 200 between chains)
position = residue_index

it completely fails:

to summerize:

position = 500 + torch.arange(total_length)

Also works!
So it's not an absolute thing... but it seems you need to preserve the relative encoding for OmegaFold to work.

I'm beginning to suspect that the reason why homo-oligomers work is that there are "fused" examples in the language model training set.

Hi @sokrypton,
Thanks for this info, we'll take a look into it.
Best

Hi Dr. @sokrypton,
Would you care to give us an example input for this pr?

Two copies:
>tmp
PIAQIHILEGRSDEQKETLIREVSEAISRSLDAPLTSVRVIITEMAKGHFGIGGELASK:PIAQIHILEGRSDEQKETLIREVSEAISRSLDAPLTSVRVIITEMAKGHFGIGGELASK

Four copies:
>tmp
PIAQIHILEGRSDEQKETLIREVSEAISRSLDAPLTSVRVIITEMAKGHFGIGGELASK:PIAQIHILEGRSDEQKETLIREVSEAISRSLDAPLTSVRVIITEMAKGHFGIGGELASK:PIAQIHILEGRSDEQKETLIREVSEAISRSLDAPLTSVRVIITEMAKGHFGIGGELASK:PIAQIHILEGRSDEQKETLIREVSEAISRSLDAPLTSVRVIITEMAKGHFGIGGELASK

Hi Dr. @sokrypton,
We have reproduced your results and agree that it is really peculiar. We are going to take a deeper look into the reason for this.
As for the training set of the language model. We directly take them from Uniref 50 sequences.

Since the LM was trained on single-chains. There is no reason to expect it to generalize to proteins it hasn't seen before, especially protein multimers. I suspect it sometimes works for protein multimers when the multi-chain protein looks like a multi-domain protein in the LM training set.

Hi,
We have been looking into this issue and found one problem with RoPE not necessarily regarding this problem, namely that it is symmetric, which may not be what we want and we are phasing it out soon.
But still this problem persists and we do not really have an idea yet.

@sokrypton @RuiWang1998 As a hungry user, are the problems with the current branch technical or scientific?


Code Quality: Migrated GetCursorPos to CsWin32

Resolved / Related Issues

[X] Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
Part of #14505, #15000

Validation
How did you test these changes?

[X] Did you build the app and test your changes?
[ ] Did you check for accessibility? You can use Accessibility Insights for this.
[ ] Did you remove any strings from the en-us resource file?

[ ] Did you search the solution to see if the string is still being used?

[ ] Did you implement any design changes to an existing feature?

[ ] Was this change approved?

[ ] Are there any other steps that were used to validate these changes?

Sorry, I am on the phone and probably messed the license at NativeMethods


chore(deps): update rust crate ariadne to 0.4.0

This PR contains the following updates:

Package
Type
Update
Change

ariadne
dev-dependencies
minor
0.3.0 -> 0.4.0

ariadne
dependencies
minor
0.3.0 -> 0.4.0

Release Notes

zesterer/ariadne (ariadne)
v0.4.0
Breaking changes

Added missing S: Span bound for Label::new constructor.

Previously labels with backwards spans could be constructed and
only resulted in a panic when writing (or printing) the report.
Now Label::new panics immediately when passed a backwards span.

Added

Support for alternative string-like types in Source

Changed

Memory & performance improvements

Fixed

Panic when provided with an empty input

Invalid unicode characters for certain arrows

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - "after 8am and before 4pm on tuesday" in timezone Etc/UTC.
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.

This PR has been generated by Renovate Bot.

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.


feat: add FluentAssertions extensions

Add extension methods for IFileSystem for the FluentAssertions-Library

Will be implemented in a separate repository Testably.Abstractions.FluentAssertions.


Missing documentation on how to install and run GUI.

The documentation is not stated on the README so it is not easily found.
How do one install and run the GUI ?

Hi @mluis
You can find deployment scripts using Docker Compose here: https://github.com/genieacs/genieacs/wiki/Docker-Installation-with-Docker-Compose
It includes genieacs-gui, of course
Have a nice day.


Support resize embeddings

What does this PR do?
As per title.

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Thank you!


implement onTapOutside

It would be great to handle an onTapOutside event (just like for regular textfields), so that developers would not need to create a global GestureDetector on Android to get rid of the textfield's focus on tapping outside.

Duplicate https://github.com/lzhuor/auto_size_text_field/pull/52


feature request - WizardCoder-Python-34B-V1.0

https://huggingface.co/WizardLM/WizardCoder-Python-34B-V1.0

I added support for CodeFuse (in my local fork/branch) which is supposed to be slightly better than the WizardCoder. (Link to comparison and link to model)


Fix cache issue causing undefined error

Found a potential bug linked to timeseries data (when grabbing the CSV files from  Johns Hopkins repo for example)
Parser reports warning:
⚠  Cannot go back in time to get https://raw.githubusercontent.com/CSSEGISandData/COVID-19/master/csse_covid_19_data/csse_covid_19_time_series/time_series_19-covid-Deaths.csv, no cache present

and throws a caught error:
TypeError: Cannot convert undefined or null to object

It appears we are not grabbing any timeseries data causing this line in scrappers.js:31 to throw as it assumes that cases will not be empty:
let latestDate = Object.keys(cases[0]).pop();

Traced the lack of data in cases to fetch.js:52:
if (await fs.exists(filePath)) {
	// stuff
else if (new Date(date) < new Date(transform.getYYYYMD())) {
	console.log('  ⚠  Cannot go back in time to get %s, no cache present', url);
	body = '';
}

For timeseries data, when no cached files are present, the first equality is false and the second is tested. The date parameter is set to false for timeseries data.
This causes new Date(false) => 1970-01-01, making the equality true. This short-circuits the fetch and we return an empty body.
Changing else if (new Date(date) < new Date(transform.getYYYYMD())) { to else if (date && new Date(date) < new Date(transform.getYYYYMD())) { fixes the issue.

DOH! I was seeing this crop up while working on timeseries generation and was scratching my head. Thanks for the fix!


[SNAP-1194] explicit addLong/longValue methods in SQLMetrics

What changes were proposed in this pull request?
Add methods taking primitive values help in avoiding boxing/unboxing overhead as well as better chance of being inlined by JVM.
How was this patch tested?
snappydata precheckin

Looks good.


[Bug] /mcdc whitelist  Should be set to admin only

Checks

[X] I confirm that I have searched for existing issues / pull requests before reporting to avoid duplicate reporting.
[X] I confirm that I followed the MCDC Docs and read the Changelog, but this problem still exists.
[X] I confirm that I noted that if I don't follow the instructions, the issue may be closed directly.

Minecraft Version
1.20.1
MCDiscordChat Version
Latest Build
Description
In the current version MCDC lets any player use /mcdc whitelist and add players to the whitelist.


PMS Redirector Issues with upgrades

This is a description of the issue, it contains details of what the current issue is and potential workarounds and any helpful advice for anyone that might be in a position that they can make changes themselves, while the incident is being investigated.

Test comment

Here I can add more comments to watchers.


[ISSUE #[DLedgerCommitLog] Fix type conversion exception] Fix type conversion exception

#3118
What is the purpose of the change

Solve the problem of abnormal type conversion when batch sending triggers pending full.

Brief changelog

First judge whether pendingFull is triggered, and then turn to BatchAppendFuture when append is normal

Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Coverage increased (+0.09%) to 54.155% when pulling 8e287bb03e818dd15c47dba9d433b281b2125998 on Git-Yang:batch_bug_fix into 9a5ec9082f6611629fc6c7459e32ac606a893c4d on apache:develop.


Compiler allows bad return values from a function when a spread operator is used (version >= 4.1

Bug Report

🔎 Search Terms

spread operator
function return

🕗 Version & Regression Information

This changed between versions 4.0 and 4.1

⏯ Playground Link

Playground link with relevant code
💻 Code

// Correctly flags error
function test1(a: any, b: any): { one?: number; two?: number } {
  return {
    one: "one",
  }
}

// Should flag error, but does not
function test2(a: any, b: any): { one?: number; two?: number } {
  return {
    one: "one",
    ...(b && { two: 2 }),
  }
}

// Should flag error, but does not
function test3(a: any, b: any): { one?: number; two?: number } {
  return {
    ...(a && { nonExistent: true }),
    ...(b && { notValid: true }),
  }
}

🙁 Actual behavior
Typescript does not flag the erroneous keys and/or values being returned
🙂 Expected behavior
Typescript should flag the erroneous keys and/or values being returned (it does this correctly in versions prior to 4.1)

The unsoundness only happens because your a and b are any. Prior to 4.1, there was a bug in && binary expressions that assumed any was always truthy, so the widened type of a && { nonExistent: true } was { nonExistent: boolean }. But any can include all manner of falsey values, so this was incorrect. The most accurate type for the expression would be the union of all falsey types and { nonExistent: boolean }, but a large union like that is expensive and is inconsistent with the way any infects other types (any & T is any), so we fixed the type of a && { nonExistent: true } to be any. So consequently the type of your return expression in all these is just any, which is not perfect, but that is exactly what you sign up for when you mix any into stuff.

unknown will work just as well for your callers; it just might be a bit of a pain to work with internally as it doesn’t narrow under most circumstances.

The real function I was writing had a few in-line checks in it, such as
if (a && a.something) {
  // do something
}
if (b && typeof b.somethingElse === "string") {
  // do something else
}

That's why any was more convenient in this case. Unless maybe there's some other paradigm for those kinds of things that I haven't seen yet? (Note that for most runtime validations I use runtypes. In this case, I also used runtypes, but there was some additional stuff I had to do that required some pre-arranging/checking.)


GET /v2/users/:guid/summary is very slow when the user is in many orgs

Issue
If a user is in 100 orgs, the GET /v2/users/:guid/summary is very slow and high CPU consumption.
Context
The user summary is generated from https://github.com/cloudfoundry/cloud_controller_ng/blob/main/app/presenters/api/user_summary_presenter.rb.
Assuming a user is in 1000 orgs with manager, billing manager and audit manager roles, each org has 1 space and with the same quota definition, I think it will trigger many queries to multiple tables, as below:
query number | table name
4                    | organizations
4000                |  quota_definitions
4003                | spaces
4001                 |  users
I think so many queries slows down this API call, and the map operation in these Presenters consumes a lot of CPU.
Steps to Reproduce

Have user is in 1000 orgs with manager, billing manager and audit manager roles, each org has 1 space and with the same quota definition
run "cf curl /v2/users/:guid/summary"

Expected result
Expect the GET /v2/users/:guid/summary is fast and consume less CPU.
Current result
Some users are in about 1000 orgs, when the API GET /v2/users/:guid/summary was called many times in parallel, the CPU usage of CC got increased from 20% to 90%, and the CC thread pool was exhausted, then CC could not handle any other requests.
Possible Fix
If the organization object queried from database can be cached in memory, I think maybe that could reduce the queries significantly.
For the above example, the query number possible will be low:
query number | table name
4                    | organizations
1000                |  quota_definitions
1003                | spaces
1001                 |  users
Any other ideas to improvet he performance? thanks.

Hi @JimmyMa ,
At this point v2 has been deprecated so we're not making changes to the v2 endpoints. In the new structure of users and roles the user summary endpoint information can be accessed via the v3/roles?user_guids=:guid endpoint, where organization and space can be passed to the include query parameter.
This new endpoint is paginated, while the v2 user summary endpoint was not, which should help mitigate the load from a single call. I have also run the v3/roles query with the max page size (5000 resources per page) and the /v2/users/:guid/summary query against an environment populated as detailed above, and it takes about half as long to retrieve the data when leveraging the v3 endpoint.

@JimmyMa  can you provide a few more details about the structure of your database?  How many users do you have?  And approximately how many roles per user?
I am also not able to reproduce this with a single user in 1000 orgs with 3 roles per org.  However, I tested this on MySql.  Perhaps it is an issue with Postgres...

Closing due to lack of response