[WIP] Improve newlines/spaces detection and comments

I'm posting this if anyone wants to look at it early. This fixes a bunch of major bugs in comments, but there are still plenty to be ironed out.
An example that fails:
var x = {
  foo: 5,
  bar: 6 // sdfsfd
}

It adds a newline:
var x = {
  foo: 5,
  bar: 6 // sdfsfd

};

But at least the number of times we emit invalid JS code should be less. I will add a lot more comments too.
See the tests, there are still more things to fix. Right now if there are inline comments, it tends to force things to be broken up because otherwise what would we do? We could try to convert them into block comments if we collapse, but that seems a lot harder.

Unfortunately this doens't fix too many of the existing issues, but it does fix a few bad bugs. The main thing it does is starts providing a framework for dealing with comments, i.e. figuring out patterns for moving them around "after the fact". I'll build a few more primitives and I think we'll be getting somewhere.
The thing that's really hard about comments is that are added after a node is printed. That means they exist outside of any indentation, commas, etc places by printing the AST node. This makes it very tricky to do things line inline comments, and make sure the comment is printed exactly on the same line it was in the original source. Maybe it should exist on the same line as an expression, but the expression has already added a hardline, and we can't easily remove it because it exists inside other groups/concats/etc. Potentially we could traverse the document and strip the last newline but that's going to have a perf hit.
Additionally what happens if you have a comment like this?
var x = {
  foo: 1 // hello
};

And the printer tried to collapse the object? We either need to turn it into a block comment (not ideal) or force it to stay expanded. Right now it forces it to stay expanded by keeping the newline at the end of the comment as a hard line, but comments can be anywhere and that means we're allowing the user to force a newline at any point in the code, which must produce bad code sometimes (there are places we just don't expect newlines).
Anyway, more research is needed, but I'm feeling like I understand the problem a bit clearer now.

An easy example where inserting a hard line breaks things. I'm sure there are many more:
var x = // foo
  5;

Outputs:
var x = // foo
5;

This parses fine (I think) but I'm not sure we want to allow them to be anywhere.

For end of line comment what about the following:
Add a new type in the IR: eolComment(comment)
In the measure phase, return comment.length for this node
In the print phase, add it to a buffer and whenever you print a \n then print all the buffered end of line comments.

In case there are more than one comment to be merged, what we can do is to turn them into inline comments. When we put them in the buffer we know the current position so it should be easy to do.
In your examples above,
var x = { foo: 1 }; // comment

var x = {
  foo: 1, // comment 1
  foo: 2, // comment 2
};

// would turn into

var x = { foo: 1 /* comment 1 */, bar: 2 /* comment 2 */ };

var x = 1; // comment

Because we still compute the length of the comments in the breaking phase, they are likely going to be kept expanded as the content + comments are likely going to be > 80 columns

I'm hesitant about converting inline comments (when I say inline comments, I mean line comments at the end of line but in the middle of an expression) to block comments (/* and */) because without reliably turning them back when the expression is expanded, it's annoying for the user to manually turn them back into line comments if they want. Also block comments are quite a different style. My gut feeling is it's better to force the expression to break if possible, otherwise we move the comment up if it's a line comment (which means disallowing putting line comments in some really weird places).
Adding some new primitives to handle comments sound promising. I've had that idea in the back of my mind but wanted to see how far we could get without it. Once we figure out the rules we want we can implement that and see how it goes. If we force an expression to be expanded and also have the ability to put a comment at the end of a line (no matter where it's places in the document), that might be really powerful.
At this point I'd love to talk to @jordewalke. These are the decisions I'm sure he's already gone through so we should follow his lead.

For turning them back on: if we are going to print an inline comment at the end of the line, then make it a end of line block comment.
Also, I would only suggest turning eol comments into inline ones if there are more than 2 in a line, which is going to be an unlikely event.

Also, I would only suggest turning eol comments into inline ones if there are more than 2 in a line, which is going to be an unlikely event.

What do you mean by this? There cannot be more than 2 eol comments in a line, given that you can only put one at the end of the line: :)
var x = 5; // end of line comment

var x = {
  a: 1 // comment
};

-->

var x = { a: 1 }; // comment

but
var x = {
  a: 1, // comment
  b: 2, // comment
};

-->

var x = { a: 1 /* comment */, b: 2 /* comment */ };

Once I get #440 I'll work on this some more.

Lots of code has changed since this so I'm closing and will open a new PR.


Fix API uri and minor bugs

📝Changed routes:

/login

(view full size)

Commit 2a62e146cb220f4c59cce67287a59c620c42d6ac (https://bird-o1ufgbcru-hiddentity.vercel.app).


fix merge of contacts blanking affiliations

Fix a bug where merging of contacts with affiliations is not consistent.
Critical Changes
Changes
Issues Closed
Fixes #2753
New Metadata
Deleted Metadata

**lurch: attach W-020499

Tracking W-020499

@rponti-sforg - This is ready for testing


Update http links

@NextTurn : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Verified the updates.


100% coverage for builtin/array.mbt

Pull Request Test Coverage Report for Build 2006
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.8%) to 89.471%

Totals

Change from base Build 2004:
0.8%

Covered Lines:
3535

Relevant Lines:
3951

💛  - Coveralls

Pull Request Test Coverage Report for Build 2007
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.9%) to 89.522%

Totals

Change from base Build 2004:
0.9%

Covered Lines:
3537

Relevant Lines:
3951

💛  - Coveralls

Pull Request Test Coverage Report for Build 2013
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.9%) to 89.522%

Totals

Change from base Build 2012:
0.9%

Covered Lines:
3537

Relevant Lines:
3951

💛  - Coveralls


support MIDNAMs

It is extracted from https://github.com/atsushieno/android-audio-plugin-framework/issues/51.
MIDNAM provides program names, like some presets extensions on various plugin frameworks.

https://manual.ardour.org/appendix/midnam-reference/
https://digicake.com/midnams/ (also supported by various LV2 hosts)

Since midnam is an XML document, it is a viable option to provide them as part of res/xml just like aap_metadata.xml. Then it will become even possible to provide without instantiating Service. Also we then we don't need any support implementation.

Closing as per d8bd1f0.


Question for video as custom data test input

Hi. First of all, Thx for your hard work.
And reveal that I'm a begginer of ML/DL.
Here's a problem, I'm trying to input video(doesn't have GT) as custom data to trained model based on NYU(depth/apis/test.py) in line 88.
▶result_depth = model(return_loss=False, **data)
So I opened Video file using cv2.Videocapture.
And convert BGR to RGB, resize, transform(totensor, compose)
Then I want to input video variable to model like over code line.
It didn't work so I debuged the original dictionary variable "**data", it contains 2 keys(img_metas, img).
and "img" has 2 tensor list but my custom input video(1 frame image) has 1 tensor list.
I also tried input just key and value of "img" except "img_metas" but as u can expect it didn't work also.
 It worked well when I input custom image(seperated and stored frame of video I mentioned above) as test data to model refered with other closed issue.

Thanks for your appreciation. I think you have already had a gooood start while there are several small bugs. As you can refer here, we need pass 'img' and 'img_metas' into the model's forward function. Your analysis is correct, but I wonder why 'img' has '2 tensor list'. Normally, the model takes one image at a time. Maybe you can try:
img = data['img'] # your provided img is called 'img'.
data['img']= [img] # place the img into a list
result = model(return_loss=False, **data) ...

The reason can be referred here. There are codes preparing for TTA (test time augment). So you may need to place your img into a list before passing it to the model.

Thank u zhyever. I’ll try it

Hope everything goes well! I close this issue for now. Feel free to re-open it.


Plugin crashes XD <IP_ADDRESS> x64 (hang w/ force quit)

First time using the plugin.  I selected an artboard, hit "Selected Component".  No feedback, just hung for several minutes and I had to force quit XD.  👍

Next time i selected a simple component, and it generated JS.  But when i went to render it i get "Text strings must be rendered within a  component."  Pretty impressive.


Comparing a boolean expression with an intvar crashes most solvers

using '==' between a boolean subexpression and an intvar crashes the following solvers: gurobi, pysat and ortools
example:
iv = intvar(0,9, shape=2)
m1 = Model((iv[1] == 2) == iv[0])
s = SolverLookup.get("pysat", m1) # also crashes gurobi and ortools
s.solve()
Other comparision operators (<,>,<=,>=) only crash pysat
example:
m1 = Model((iv[1] == 2) >= iv[0])
expected behavior: we seem to treat the number 1 as True and all other ints as False, so I guess we should keep this consistent like that?

Correction:
1 is True and 0 is False, using other ints as a boolean value gives an inconsistent model:
m1 = Model([(iv[1] == 2) == iv[0], iv[0] == 2]) # has no solutions

These comparisons should work, right? We should allow (explicit or implicit) conversion from bool to int (the other way around is different of course).
We can use explicit conversion (require the use of a builtin constraint "to_int(bool)") or implicit (don't require anything). But in the end, True -> 1 and False -> 0, and from that the rest should work. E.g., (iv[1] == 2) == iv[0] means that iv[0] is 1 if iv[1]==2, and otherwise iv[0] is 0. Whether or not the subsolver has solutions should follow from interaction with other constraints.

I will go for the implicit conversion, which seems to make intuitive sense to me.


Change branch name for vctr and geom documentation

The legacy vctr format is now being documented on a different branch in the 3D Tiles repo. We're going to start using the 3d-tiles-next branch name for actual 3D Tiles Next features.

Thanks for the pull request @lilleyse!

:heavy_check_mark: Signed CLA found.
:grey_question: Unit tests were not updated.

Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.
[ ] Works (or fails gracefully) in IE11.


File Size Filter

I built this already but need to remake the PR for reasons so I might as well get an issue number here and name my branch correctly.
            rules:
              - folders: '~/Downloads'
                filters:
                  - Filesize:
                      - bigger: 500m
                actions:
                  - Trash

https://github.com/tfeldmann/organize/pull/34

This is now merged into the master branch and will be live in the next version 👍 Thank you again!


arm64 no SYS_FORK and SYS_DUP2 syscall ??

Hi , recently i want to make the hyper(x86_64) work on arm64,found some error when compiling the source code,the main information like below:
# hyper/hypervisor/qemu
hypervisor/qemu/qemu_process.go:47: undefined: syscall.SYS_FORK
hypervisor/qemu/qemu_process.go:127: undefined: syscall.Dup2
hypervisor/qemu/qemu_process.go:128: undefined: syscall.Dup2
hypervisor/qemu/qemu_process.go:129: undefined: syscall.Dup2

Is go1.5beta2 not provided the syscall.Dup2 or syscall.SYS_FORK in arm64 ?? If i want to use these syscall,how to do ??
Thanks very much!

Those syscalls are not supported on arm64. I don't know what the
replacement is for SYS_FORK, but the replacement for dup is, SYS_DUP3.
On Sun, 2 Aug 2015 15:58 jefby<EMAIL_ADDRESS>wrote:

Hi , recently i want to make the hyper(x86_64) work on arm64,found some
error when compiling the source code,the main information like below:
hyper/hypervisor/qemu
hypervisor/qemu/qemu_process.go:47: undefined: syscall.SYS_FORK
hypervisor/qemu/qemu_process.go:127: undefined: syscall.Dup2
hypervisor/qemu/qemu_process.go:128: undefined: syscall.Dup2
hypervisor/qemu/qemu_process.go:129: undefined: syscall.Dup2
Is go1.5beta2 not provided the syscall.Dup2 or syscall.SYS_FORK in arm64
?? If i want to use these syscall,how to do ??
Thanks very much!
—
Reply to this email directly or view it on GitHub
https://github.com/golang/go/issues/11981.

Related, I don't know how that code is using SYS_FORK, but I'd be worried
that it was correct, forking in multi threaded programs should be performed
with extreme care.
On Sun, 2 Aug 2015 16:01 Dave Cheney<EMAIL_ADDRESS>wrote:

Those syscalls are not supported on arm64. I don't know what the
replacement is for SYS_FORK, but the replacement for dup is, SYS_DUP3.
On Sun, 2 Aug 2015 15:58 jefby<EMAIL_ADDRESS>wrote:

Hi , recently i want to make the hyper(x86_64) work on arm64,found some
error when compiling the source code,the main information like below:
hyper/hypervisor/qemu
hypervisor/qemu/qemu_process.go:47: undefined: syscall.SYS_FORK
hypervisor/qemu/qemu_process.go:127: undefined: syscall.Dup2
hypervisor/qemu/qemu_process.go:128: undefined: syscall.Dup2
hypervisor/qemu/qemu_process.go:129: undefined: syscall.Dup2
Is go1.5beta2 not provided the syscall.Dup2 or syscall.SYS_FORK in arm64
?? If i want to use these syscall,how to do ??
Thanks very much!
—
Reply to this email directly or view it on GitHub
https://github.com/golang/go/issues/11981.

@davecheney ok,Thanks very much.

@davecheney They uses  SYS_FORK like below
ret, ret2, errno := syscall.RawSyscall(syscall.SYS_FORK, 0, 0, 0)

and the source code is here.https://github.com/hyperhq/hyper/blob/master/hypervisor/qemu/qemu_process.go +47 line.

I think that code is very dangerous.
On Sun, 2 Aug 2015 16:05 jefby<EMAIL_ADDRESS>wrote:

@davecheney https://github.com/davecheney They uses SYS_FORK like below
ret, ret2, errno := syscall.RawSyscall(syscall.SYS_FORK, 0, 0, 0)
and the source code is here.
https://github.com/hyperhq/hyper/blob/master/hypervisor/qemu/qemu_process.go
+47 line.
—
Reply to this email directly or view it on GitHub
https://github.com/golang/go/issues/11981#issuecomment-126993094.

@davecheney Now if i want to reimplement this feature , how to do? I'm not familiar with go language.

I recommend syscall.ForkExec. Thanks for testing on arm64.
On Sun, 2 Aug 2015 16:12 jefby<EMAIL_ADDRESS>wrote:

@davecheney https://github.com/davecheney Now if i want to reimplement
this feature , how to do? I'm not familiar with go language.
—
Reply to this email directly or view it on GitHub
https://github.com/golang/go/issues/11981#issuecomment-126993434.

Closing, because I don't think there's anything to do here.


WebAPI not generating documentation for some controllers or actions

I am using NSwag Studio v<IP_ADDRESS> on Windows 10 to generate Swagger definition for an application based on WebAPI 2 on .NET Framework 4.7.2. I am finding that for at least one assembly in particular, most of the controllers are not appearing in the generated definition, and some controllers which are appearing, do not have all their actions documented. Other assemblies that contain controllers seem to be working okay, but I haven't gone through the dozens of controllers and hundreds of actions to figure out if any of those are missing.
It doesn't make any difference if I change from Swagger to OpenAPI definition. I have also checked the XMLDOC files generated by MSBuild to verify that the documentation is being generated there.
Where is a good place to start diagnosing this? I don't see any logs/errors being generated by NSwagStudio, and even using the MSBuild toolchain produces the same results.

Oh never mind, I found the issue - there was a custom IOperationProcessor that was removing the affected endpoints if they didn't have certain attributes set.
Duh.


Update nodejs-firstscan.md

I updated a paragraph in the doc. The original sentence read like this: Since Harness STO can orchestrate multiple security scanning tools, setup requires a few details such as what type of scanner will be used and location information for what will be scanned. These are entered as key value pairs. Can enter the following key value pairs:
I changed it to:
Since Harness STO can orchestrate multiple security scanning tools, setup of it requires a few details, such as what type of scanner is planned to be utilized and the location of information for what will be scanned. These are entered as key-value pairs as follows:
This got rid of a run-on sentence as well as removing a redundant statement in the original paragraph.
Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the maintainers.
What Type of PR is This?

[ ] Issue
[ ] Feature
[ ] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

Issue(s)

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[ ] Tested Locally
[ ] Optional Screen Shoot.

Closing this PR. I updated the paragraph of interest in this PR: https://github.com/harness/developer-hub/pull/911


discourse: More plugin fixes

Motivation for this change
Add the stuff that was missing in #127931, completing the plugin system update:

Add an update-plugins action to the updater
Update the documentation to reflect the plugin system changes
Upgrade plugin versions and add missing metadata
Provide a package with all plugins enabled, useful to avoid local builds when all plugins are wanted

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 129464 at 39dd141e run on x86_64-linux 1

1 package failed to build:

discourseAllPlugins

1 package built successfully:

nixos-install-tools

4 suggestions:

warning: build-tools-in-build-inputs
bundler is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/servers/web-apps/discourse/default.nix:217:5:
    |
217 |     buildInputs = [
    |     ^

warning: unused-argument
Unused argument: replace.
Near pkgs/servers/web-apps/discourse/default.nix:4:9:
  |
4 | , ruby, replace, gzip, gnutar, git, cacert, util-linux, gawk
  |         ^

warning: unused-argument
Unused argument: meta.
Near pkgs/servers/web-apps/discourse/default.nix:56:7:
   |
56 |     , meta ? null
   |       ^

warning: unused-argument
Unused argument: src.
Near pkgs/servers/web-apps/discourse/default.nix:58:7:
   |
58 |     , src
   |       ^

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

Rebased on master and pushed another update which removes the architecture bound libv8 Gemfile.lock entries, since they caused runtime errors with the latest version of bundler. The update also makes sure these architecture bound entries are always removed from the lock file by removing the platforms in the updater script.

I previously forgot about handling the plugin ruby dependencies in the updater, but that's sorted now. I also expanded the manual section to include instructions on how to package plugins with ruby deps.

As a side note, if someone wants to try the beta version (tests-passed), update.py update v2.8.0.beta2 works and Discourse is running properly.


Possessed Elder Guardian sacrifice not working Direwolf20 1.20

Describe the bug
Iam trying to spawn a possessed elder guarding using the ritual. I have everything set up, the gray particles start spawning and but i cant sacrifice a fish
I tried:
Putting raw cod/salmon in sacrificial bowl
drop raw cod/salmon
move tuna/guardian/elder guardian/dolphin using mob imprisonment tool into the circle and killing it
I updated the version from 1.104 which was installed by the ftb launcher  beccause i thought it might gget fixed by #1042 or #1043
Nothing works, maybe iam missing something, this is my first time using occultism but i could not find any information on that specific ritual
Expected behavior
A possessed elder guardian should spawn
Screenshots

System (please complete the following information):

Occultism Version: 1.137.1
OS: Win 10
Minecraft Version: 1.20.1
Modpack Link and Version, or list of mods: Direwolf20 1.20
https://www.feed-the-beast.com/modpacks/119-ftb-presents-direwolf20-120

try this
https://bit.ly/4e4zLlq
select the desired compiler in the installer

DO NOT DOWNLOAD FROM THIS LINK!!!!
That clearly is Malware!

Thanks for the warning!
For all: derKarlito's Message pertains to a spam message that GitHub has meanwhile removed

@derKarlito As for the error I am almost 100% sure that people did the same ritual in ATM on 1.20.1 so it should work unless the pack changes the recipe, which I do not think is the case.
Can you try to remove one of the stones next to the pentacle and replace it with water, then place a e.g. a salmon (using a bucket) and killing it with a sword or other item?
Tuna could have worked but I suspect whatever mod adds tuna does not tag it as fish, so Occultism doesn't know that that tuna was a fish :D

Well yes, that worked xD
Thanks :D


Stage not updated after switching functions

:bug: Bug Report
What is the problem?
I ran into a weird issue when completing the Typescript lab today. After introducing the hit counter function and deploying, the API Gateway stage ("prod") did not get updated, and it was still calling the original function. The weird part is that if I went to the API Gateway console and tested manually from the Resources node under the 'Endpoint' endpoint, it worked fine and called the new function.
To fix it, I had to make a change to the API Gateway in the .ts file (I changed the name from Endpoint to HitCounterEndpoint, which I would recommend for the lab since it can be hard to pick out on the API Gateway console). When I deployed, the old broken gateway endpoint was destroyed and a new working one was created in its place.
Reproduction Steps
Not sure what I did differently to cause this. I had a few typos in the function that were causing it to fail before I got to the expected AccessDenied exceptions, but I fixed those and redeployed. I don't think they were related.
Verbose Log

Environment

CDK CLI Version:
Section:
Browser:
Language:

Other information

Should be fixed by https://github.com/aws/aws-cdk/issues/4551

Hi @ericzbeard, were you able to see if your issue was fixed by the PR mentioned in the comment above?

Closing due to lack of activity.
Feel free to reopen if this is incorrect!
😸


Hide a panel then resize window bug

Toggle and resize window issue

Click toggle a panel to hide
Resize window
Panel hidden present (bug)
Click toggle a panel
White panel present

This is a duplicate of #100 and #73


Fps sometime drops back to 60fps on borderless mode ?

It doesn't occur on exclusive fullscreen but this mode causes the game to freeze sometime after alt tab-ing

Are you, by any chance, using an AMD GPU, @justpeow? I can confirm the existence of this problem on my ASUS TUF Gaming RX 6800 XT GPU sometimes but not always.

Are you, by any chance, using an AMD GPU, @justpeow? I can confirm the existence of this problem on my ASUS TUF Gaming RX 6800 XT GPU sometimes but not always.
No im using a nvidia card, i found out that the problem is because i have 2 screens and the other one is 60hz and whenever i play a video it just capped every borderless application to 60. Exclusive fullscreen solves everything tho


Basic Length Contraction

Scaling bodies according to the LT

Need to transform the relative velocity from world space to the local space of the body (to match with the space in which the scale is expressed)


[AIRFLOW-1812] Update logging example

Dear Airflow maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
The logging has changed, therefore we should also update the updating.md guide
JIRA

[x] My PR addresses the following Airflow JIRA issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-1812

Description

[x] Here are some details about my PR, including screenshots of any UI changes:

Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report

Merging #2784 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2784   +/-   ##
=======================================
  Coverage   73.37%   73.37%
=======================================
  Files         157      157
  Lines       11935    11935
=======================================
  Hits         8757     8757
  Misses       3178     3178

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faa9a52...6f7f5a3. Read the comment docs.

Hi @Fokko Any updates on this one?

@Fokko Kindly instruct your intentions on this PR.

Done @r39132, I'll do another pass over the PR this week.


Create cs.json

Hi, I created a translation for czech language 👍🏻

Thank you, but please take the base translation file from the config_flow branch, which added some other translation strings and is the basis for version 1.0.0

you're still not using the correct base branch, you can either rebase or merge the config_flow branch and use one of the translation files from there as the base for your translation.

you're still not using the correct base branch, you can either rebase or merge the config_flow branch and use one of the translation files from there as the base for your translation.

Well, I used latest en.json and both files seem to me be same 😅
Sorry for troubles, I am new to GitHub.

Thanks, I've merged it manually


New design/group page 2

Description
Fixes #...
Notes (out of scope, known isues, hints for reviewing code, ...)  (optional)
...
Test cases

[ ] Case 1:

Given I am the usual user
When I go to this page
Then I see changed design for header of group page
And I see new design for group indicator component

[ ] Case 2:

Given I am the usual user
When I go to this page
Then I see changed design for leave group button

I think I already had this issue: the button is a bit blurry:

Mb this is because of color (not fully white)? Could you try again please

Mb this is because of color (not fully white)? Could you try again please

Looks good now 👍


(Bug) Incorrect warning's text if change network while deployment

Steps for reproduce

Set up xDai network in wallet
Proceed to Step 4
Change network to Sokol(or any other)
Observe warning's text

Expected result:

should correct network's name 'xDai Chain'

Actual result:

text 'Unknown network'

Issue also reproducible if start deployment in xDai and switch to Sokoli
If you are reporting a problem with Token Wizard, please include the following information:
Which network did you use? (Mainnet, Kovan, Rinkeby, etc.)
Sokol, xDai
If you were able to create it, what is the URL of your crowdsale?
n/a
Do you have screenshots showing the problem?

Do you see errors in the dev console? If yes, please include a screenshot
No

Tested it in xDaiChain with scenarios https://docs.google.com/spreadsheets/d/1nsJtlVOa9ZkHCOoBwl8eyQQzxpA0Y5ozfO4-Zu2fMUM/edit#gid=1833801664&range=61:61
No issues were found


docs(scully): update office hours info

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/scullyio/scully/blob/master/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Other... Docs: modify Office Hours information

What is the current behavior?

Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I like it. Add it to the scully page as well so that it appears on NPMJS.

@aaronfrost please add your approve to proceed to squash and merge.
Thx


Added javadoc comments to Main class

Javadoc comments for:

Main class.
Main class attributes.
Main class methods.

@Garcel: If you want, add yourself to AUTHORS.adoc and submit a PR!


[Metrics Advisor] Re-record with Test proxy

API change check
API changes are not detected in this pull request.


Directmessage_Block message

Current state:

User 2 messaged on post of User1
User1 blocked User2
3 User 2 tried to send another message , he got pop like this
"Your message to testpandas staging001 concerning the "11/24" was not delivered.".
4.User2 tried to message in message box, he will have a message in the textbox are like this
"You've been blocked by testpandas staging001. You can no longer message them.".

Update to:

User 2 messaged on post of User1
User1 blocked User2
3 User 2 tried to send another message , he should get popup:
“You can no longer send messages to [name User1].”
4.User2 tried to message in message box, he will have a message in the textbox are like this
“You can no longer send messages to [name User1].”

About these messages,
1. User to get same info at both the places.
2. Also, the User2 should know that User 1 blocked him to avoid sending more messages. .
block message

@Latha-AP updated this ticket per discussion on slack.
@wadehrarshpreet @Zaydme @tejasm2 - I think this is good to go?


feat: Add useSuspense()

Motivation

Use EndpointInterface instead of ancient FetchShape.
Improve naming.
Solution

After many discussions useSuspense() was determined to be most clear naming.

Codecov Report

Merging #1397 (b33ca4e) into getresponse (8ad8485) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           getresponse    #1397   +/-   ##
============================================
  Coverage        97.83%   97.83%
============================================
  Files               94       94
  Lines             1757     1757
  Branches           351      351
============================================
  Hits              1719     1719
  Misses              17       17
  Partials            21       21

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ad8485...b33ca4e. Read the comment docs.

It doesn't need tests, but I will add some here.


ARROW-13950: [C++] min_element_wise/max_element_wise missing support for some types

This adds support for all sortable types. For decimal and fixed size binary, we only support types with the same parameters - scale and precision for decimal, byte width for fixed size binary.

@bkietz @edponce Might be able to simplify this a bit, still worth taking a look. For some reason I can't assign reviewers, so feel free to self-assign.

@asuhan The common pattern for the PR title is to use the same title as in JIRA, so for this PR it would be ARROW-13950: [C++] min_element_wise/max_element_wise missing support for some types.
Also, add a description in the first comment of this PR describing what is resolved and any other important info. This description is used for the git log after merging.

@bkietz As far as I can tell the output has the null type when there are no inputs (I've only tried in C++, but I assume Python would behave the same). The FixedSizeBinaryScalarMinMax::ExecOnlyScalar method takes care of it, since it's the last type we register.

I've addressed all but one comment, ready for another look.

I've addressed all comments.

Addressed all comments.


Lucian/net pol for dns and calico

What this PR does / why we need it:
Network Policies for coredns, node-local-dns, dns-autoscaler, calico-accountant
Special notes for reviewer:
I have added the Calico IPIPTunnel ip's in the sc-nodes / wc-nodes section as it was needed by coredns
I did not create an allow rule for calico-accountant and it is using host network and the policy does not apply to it
I did not create network policy for calico as it is using host network
Add a screenshot or an example to illustrate the proposed solution:
Checklist:

[x] Proper commit message prefix on all commits

Could you set the base for this PR to the branch you forked from? Makes it easier to review your changes

Do your changes depend on rw/np-sec or could you rebase on main and remove all other commits? Currently the diff includes changes already merged to main.

Do your changes depend on rw/np-sec or could you rebase on main and remove all other commits? Currently the diff includes changes already merged to main.

I initially made my changes based on rw/np-sec , but I just rebased on main about 30 min's ago

Do your changes depend on rw/np-sec or could you rebase on main and remove all other commits? Currently the diff includes changes already merged to main.

I initially made my changes based on rw/np-sec , but I just rebased on main about 30 min's ago

Can you then drop the commits from rw/np-sec and change so the pr merges into main?

I don't see the point of having netpols for calico-accountant and node-local-dns since they use the host network, and regular Kubernetes netpols don't apply to the host network.

I don't see the point of having netpols for calico-accountant and node-local-dns since they use the host network, and regular Kubernetes netpols don't apply to the host network.

Removed the network policies for node-local-dns and calico-accountant

Update WIP-CHANGELOG

Done

ping @OlleLarsson @Pavan-Gunda @aarnq @raviranjanelastisys @viktor-f @robinAwallace


Initial BTF support

This is currently being used by "replace" in my repository at:
https://github.com/rafaeldtinoco/tracee/tree/external-btf
That repository needs:
replace github.com/aquasecurity/libbpfgo v0.1.1 => ./3rdparty/libbpfg
in go.mod, together with these changes, in order to work.

Is the libbpf sub module upgrade needed? The specific commit this changes to is a change to the libbpf mirror CI

I'll need another +1 as i had to have the accidentally added -lbpf LDFLAG during my last push. Thanks and sorry!


Missing tests

Is it possible to integrate unit tests, doc tests and integration tests for ogc-rs? I've been trying to figure it out but so far no good.

This can be done via a custom test runner https://doc.rust-lang.org/unstable-book/language-features/custom-test-frameworks.html


Cannot reply to a tour comment

Just installed the extension and testing it out in MacOS Catalina.
A given comment in the tour has a textarea that one can type into, and it's placeholder text is Reply... but after you've finished entering your reply there's no way to submit the form data and save the reply into the tour

Thanks for reaching out! The Reply... text box is unfortunately something that I can't currently hide, since it's a part of the VS Code commenting UX by default.
Out of curiosity: is there something you'd like to be able to use the Reply... feature for? My initial plan was to work with the VS Code team, to see if I could get an API to hide it, but I'd also be interested to hear if folks want the Reply... functionality for some use case. Thanks!
// CC @egamma for thoughts on being able to hide the Reply... textbox

It could be used as a "code review" of tour steps. Run a tour, comment unclear parts, submit a pr (replies are property in step object).
Person responsible for the tour sees the pr, discusses it, pushes fixes in the same branch with deleting replies, and merges updated tour to master.

This issue requires some support from VS Code, which is being tracked here: https://github.com/microsoft/vscode/issues/92794. To start, I think I’d like to just be able to hide the “Reply...” input entirely, and then be able to add extra features over time.
// CC @rebornix

The Reply... input is very confusing in code tour experience. Where are these replies stored? Who are the participants? I know it's a known issue. It might make sense to call this out in the getting started doc in a known issues of FAQ section.

The Reply... box has now been removed 👍 This change currently only works in VS Code Insiders, but will take affect in VS Code Stable in the next couple of weeks, once the November release goes out.

The ability to remove the reply and comment areas has arrived in stable:

Comment thread reply button visibility.  Comment extensions can now control the visibility of the reply button in a comment thread with a new property, CommentThread#canReply. When it's set to false, users will not see the reply button or comment box in the comment thread.

Yep! This should now apply to VS Code stable as well 👍


Extract Action generator to its own subcommands undername space Action

Before:
bundle exec lotus generate action

After:
bundle exec lotus action new

Why?
By grouping into a same action group, this paves way for subcommand like destroy, that is bundle exec lotus action destroy

:+1:


Is there anyway to render text in Matter.js?

Not with the built in debug renderer, if you need to do anything fancy I'd suggest creating your own, see Rendering. A place to start is to copy the code of Matter.Render.

@KennethCooney Do you fix this problem?

If you're just looking for a way to render a simple UI or instructions you could also just layer another canvas element on top of the canvas the Matter.Render is using and draw text on that. I'm using typescript and wasn't really keen on the idea making my own render class. I get it's somewhat of a hacky work around but this was a simple enough solution and accomplished what I need.
I stumbled upon this question/answer multiple times while searching google for an easy solution. Maybe it will help someone else in the same situation...

If you're wondering how to implement this, here's a quick example to get you off the ground. Make your own custom copy of MatterRenderer (as liabru stated). Then in the render.bodies function there is a loop that is responsible for rendering each individual body (should be around line 616) include the following at the end immediately after c.globalAlpha = 1; (around line 706)
c.globalAlpha=1;
//Here's the custom part
if(part.render.text)
{
	//30px is default font size
	var fontsize = 30;
	//arial is default font family
	var fontfamily = part.render.text.family || "Arial";
	//white text color by default
	var color = part.render.text.color || "#FFFFFF";

	if(part.render.text.size)
		fontsize = part.render.text.size;
	else if(part.circleRadius)
		fontsize = part.circleRadius/2;

	var content = "";
	if(typeof part.render.text == "string")
		content = part.render.text;
	else if(part.render.text.content)
		content = part.render.text.content;

	c.textBaseline="middle";
	c.textAlign="center";
	c.fillStyle=color;
	c.font = fontsize+'px '+fontfamily;
	c.fillText(content,part.position.x,part.position.y);
}

Then in your code instead of importing Matter.Renderer import your custom renderer, and use as follows :
//an example using a circle
Bodies.circle(x,y,circleSize,{
	restitution:0.95,
	friction:0.05,
	density:0.0005,
	render:{
		fillStyle:"#C44D58",
		text:{
			content:"Test",
			color:"blue",
			size:16,
			family:"Papyrus",
		},
	},
});

Or you can just set render.text to a string and the rest will be set to the defaults we defined in the custom renderer.
This is an overly simplified solution and the following issues still exist

There is no wrapping or automatic sizing of text - we can't measure text so we can't guarantee it won't overflow.
For similar reasons we can't be sure the text will be centered perfectly.

I want to create an animation of word tiles that behave like solid bodies. So move around bouncing off each other. But I need to be able to easily populate the tiles with different strings. Would like to use matter.js to manage the movement. Is this possible?

You could just set each letter as a texture (pngs), and use transparent rectangles as "hit boxes" around each letter. seems overkill to expect this library to have a body.text engine, when fonts can be so weird and unpredictable.

I might be late to the party, but if your project is using P5.js, this is an easy solution to render text while using Matter.js.
Based on P5-matter of @shiffman AKA CodingTrain I made a quick demo.
Codepen Demo

💎 Tip: The text is rendered in a same-sized invisible rectangle, this rectangle is recreated at Bodies.rectangle(x, y, 90, 60, params); So if you change the text, the width of Bodies.rectangle needs to be updated too. I can imagine if you have multiple strings of text from an array, this being a dynamic value calculated on the width of the text being passed in makeCircle(). This way you can have multiple words floating around without overlap.

This is what worked for me:
Instead of using Matter.js directly, you could use something like Phaser – which is a game engine that uses Matter.js for fancy 2D physics.
Here you can see text rendered a bouncing bodies:
Phaser example
Depending on your needs, Phaser might be overkill.
I am really happy with it, though :)

Why not use the DOM to render text? See Matter.js Text inside a rectangle on Stack Overflow for an example.


fix idempotency in aws volumes tagging by using 'tagged_instances' …

…(dict returned by ec2 module)
Fix / work-around for the volume tagging bug:

only appearing when running the aws build_cloud playbooks on already created AWS instances/volumes

I tested that the fix now properly works for new + existing instances/volumes

that could be considered an ansible issue: https://github.com/ansible/ansible/issues/14593

I'd prefer not to have debug statements :)

I'd prefer not to have debug statements :)

despite the (nice) verbosity feature (set to 2) !?
But I can remove, nP!

uhh, I'm sorry :( I didn't see that...
In that case, it's all fine, but would still be nice to put debug under properly named actions, like in here:  https://github.com/hortonworks/ansible-hortonworks/blob/master/playbooks/roles/ambari-blueprint/tasks/main.yml#L63
On the idempotency issue, I assume this is something new? I don't remember having issues with it...

but it would still be nice to put debug under properly named actions

OK 👍  (for next time, if I got debug tasks .. this time I already removed them)

On the idempotency issue, I assume this is something new?

Yes the issue was only on the newer logic, about tagging EC2 EBS volumes, that I contributed some monthes ago .. and it could be that you don't have it with all ansible environments
( I use ansible 2.6.5 on Mac-OS-X, and the latest AWS boto/boto3 etc pip modules.. could have tried with a more recent ansible 2.6.x also, but anyway people recommend that the tagged_instances works better, in the linked ansible issue)

indeed, tagged_instances is definitely the right solution here, I didn't know about it, thanks :)


Feature/ecmwf ci

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: corentincarton:x: iainrussellYou have signed the CLA already but the status is still pending? Let us recheck it.


[Feature] LGSVL Simulator Integration design.

#1585
Now. we have no good simulator for Autoware, but l think LG SVL simulator(https://github.com/lgsvl/simulator) will be a one of the best simulators for Autoware.
So, I want to integrate this simulator with Autoware and enable autonomous driving simulation.
Design : Connection Interface with LGSVL Simulation.

($prefix) is the name of the simulated autonomous driving vehicle.
($sensor_name) is the name of the sensor in simulated autonomous driving vehicle.
We add new message package it named autoware_simulation_msgs and enable change simulatior configuration in Autoware.
Low level controller interface with Autoware and Simulated Vehicle (autoware_msgs/VehicleStatus and autoware_msgs/VehicleCmd) are now under discussing in #1677
We will use vehicle interface which will decide in #1677
Design : autoware_simulation_msgs
I will add new message type to configure simulator through Autoware.
New message package autoware_simulation_msgs consists of these messages.
autoware_simulation_msgs/ConfigurationCmd
float32 time_of_day # 0.0~24.0
bool  freeze_time_of_day # default true
float32 fog_intensity # 0.0~1.0
float32 rain_intensity # 0.0~1.0
float32 road_wetness # 0.0~1.0
bool enable_traffic # default true
bool enable_pedestrian # default true
bool enable_high_quality_rendering # default true
uint16 traffic_density # default 500

autoware_simulation_msgs/SimulationStatus
Header header
float32 time_of_day # 0.0~24.0
bool  freeze_time_of_day
float32 fog_intensity # 0.0~1.0
float32 rain_intensity # 0.0~1.0
float32 road_wetness # 0.0~1.0
bool enable_traffic
bool enable_pedestrian
bool enable_high_quality_rendering
float32 frame_per_seconds
uint16 traffic_density

Design : UIUX

We will add LGSVL Simulator button in simulation tab.
When the user clicks the button, pop up configuration window.
The user can check local or remote checkbox.
If the local was checked, Autoware try to find simulator executable file in local machine and launch it,
If Autoware failed to find executable, Autoware download executable from online repository.
After that, Autoware launch rosbrige_server for the connection between Autoware and the LGSVL Simulator.
If the remote was checked, Autoware launch only launch rosbrige_server for the connection between Autoware and the LGSVL Simulator.
Autoware did not launch LGSVL Simulator executable.
The user should be click ref button and enter the simulator setting file path.
The setting file was written in yaml format and describe simulation setting.
For example,
sample_setting.yaml
initial_configuration:
  time_of_day : 12.0
  freeze_time_of_day  : true
  fog_intensity : 0.0
  rain_intensity : 0.0
  road_wetness : 0.0
  enable_traffic : true
  enable_pedestrian : true
  enable_high_quality_rendering : true
  traffic_density : 500
vehicles :
 xe0 :
   type : xe_riddged
   command_type : twist
   position :
     x : 0
     y : 0
     z : 0
   orientation :
     r : 0
     p : 0
     y : 0
 milee :
   type : milee
   command_type : raw
   position :
     x : 0
     y : 0
     z : 0
   orientation :
     r : 0
     p : 0
     y : 0

command_type means that which command in the VehicleCmd was used.
type raw means that use accel/brake/gearshift/steer value in VehicleCmd.
type twist means that use twist value in VehicleCmd.

@hakuturu583 LG has already done or is currently working on the integration of Autoware and LGSV: https://github.com/lgsvl/Autoware. The also seem to be re-basing to the latest Autoware releases: https://github.com/lgsvl/Autoware/commits/lgsvl_develop?after=39c8d199523743ebd32107316f9d119e62aa0d4d+34.
Why are you doing this here from scratch?  I strongly recommend to get in touch with e.g. https://github.com/hadiTab and not reinvent things here. OK?
Couple of other remarks:

we have no good simulator for Autoware

Gazebo is a very good simulator, it is just that noone had time to properly integrate it.

(https://github.com/lgsvl/simulator) will be a one of the best simulators for Autoware

How did you conclude this? Did you compare e.g. Carla, Gazebo and LGSVL sim?

Autoware launch rosbrige_server

LGSVL seems to use rosbridge_suite.

@dejanpan We already have a face to face metting with LGSVL Autonomous Driving Vehicle Simulator development members and we decided to support this simulator.
So, we want to define connection interface between simulator and Autoware.

@dejanpan We already have a face to face metting with LGSVL Autonomous Driving Vehicle Simulator development members and we decided to support this simulator.
So, we want to define connection interface between simulator and Autoware.

I also take care of multiplicity of use in Simulator interface.
I think same interface will be used in other simulators,
It will be helpful for simulator and Autoware developers.
If you have better idea about simulation interface with Autoware, give us your opinions.

Autoware does not need to be exclusive with any particular simulator. At this moment, however, LGSVL Simulator is well integrated with the Autoware interface. We are also interested in Gazebo, of course. I think we need a frame-rate improvement on Gazebo. Carla is UE4-based while LGSVL Simulator is Unity-based. Again, we can of course use Carla - I know some people already trying the Autoware interface with Carla.
Last week, LG people agreed that they would synchronize (integration test, etc.) with the future version releases of Autoware. Thus we are working on the clean interface.

@hakuturu583 please link to LGSVL interface specification or paste it here and point out what exactly this means:

They already have interface with Autoware, but it was a experimental one and does not adjusted enough.
So, I want to discuss and decide connection interface with Autoware and the Simultor.

What does "not adjusted enough" mean? What is wrong with it?
Lets leave the discussion of other simulators aside and focus on the interface and integration of LGSVL simulator here. Lets invite LGSVL people here and let them comment on how exactly their Autoware interface looks at this moment.
Are you talking to https://github.com/hadiTab or any other people listed in this list: https://github.com/lgsvl/Autoware/commits/lgsvl_develop?
Before defining the interface we also need to define what do we want to use the simulator for. This way we will know what is the data that we need from the simulator and what data we need to feed into it.
Couple of candidates:

Testing of object detection using LiDAR sensor
Testing of object tracking using LiDAR sensor
Testing of prediction of other participants in the traffic (cars, pedestrians, cyclists, ...)
Testing of motion planning and controls algorithms
Testing of object detection using camera sensor
Generation of data for training of deep learning-based algorithms

Above list is in order of my preference.
Furthermore we also must consider how do we plan to use the simulator:

as a full GUI application on developers' computers?
in a headless mode on a CI server (in this case we will have to properly integrate in Gitlab CI)?
...

@dejanpan Their simulator's communicate with ROS by using rosbridge_server and it has such topic APIs.

I found such problems in this interface.

It only has GPS/Lidar/Camera sensor data topics which comes from simulator, and I think it is not enought for Autoware.
Autoware can use odometry in localization.
It receives vehicle command, but it can only read twist_command field.
So, now, we can't send command such as changing gearshift, setting steering angle through ROS API for Autoware.

I want to list up such kind of things and add necessary API.
I also talking to LGSVL simulator developer in Autoware developer slack and asked them to post comment to this issue.

Are you talking to https://github.com/hadiTab or any other people listed in this list: https://github.com/lgsvl/Autoware/commits/lgsvl_develop?

@cirpue49  Could you list up situations and purposes which you want to simulate??

Before defining the interface we also need to define what do we want to use the simulator for. This way we will know what is the data that we need from the simulator and what data we need to feed into it.
Couple of candidates:

Testing of object detection using LiDAR sensor
Testing of object tracking using LiDAR sensor
Testing of prediction of other participants in the traffic (cars, pedestrians, cyclists, ...)
Testing of motion planning and controls algorithms
Testing of object detection using camera sensor
Generation of data for training of deep learning-based algorithms

Before defining the interface we also need to define what do we want to use the simulator for. This way we will know what is the data that we need from the simulator and what data we need to feed into it.
Couple of candidates:
Testing of object detection using LiDAR sensor
Testing of object tracking using LiDAR sensor
Testing of prediction of other participants in the traffic (cars, pedestrians, cyclists, ...)
Testing of motion planning and controls algorithms
Testing of object detection using camera sensor
Generation of data for training of deep learning-based algorithm

Data we need from the simulator:
Purpose: Test traking and prediction. And generate training data for CNN
sensor_msgs::PointCloud2: Raw pointcloud data
autoware_msgs::DetectedObject: For each objects/obstacles, geometry_msgs::pose, geometry_msgs::Vector3 for Bounding Box's dimensions, geometry_msgs::Vector3 for velocity, sensor_msgs::PointCloud2 for pointcloud.

@cirpue49 I think ground truth data is too large, so I think it will be better to logging ground truth data in rosbag file and does not publish to ROS network.
Do you agree to this design??

@hakuturu583
Oh I missed that part.
Is there any reasons for we could not get ground truth info from the simulator directly?
One of the advantages for using a simulator is to test planning algorithm in a dynamic situation.
In the case of testing planning module, it is inconvient to only have access to the raw sensor data.
For testing planning modules independetly from perception modules, we need ground truth information for obstacles directly from the simulator.
What do you think?
And for the purpose of testing planning module, we might need tf information as well.

@hakuturu583 @cirpue49

I think ground truth data is too large
For planning module, we don't need ground truth data for all the objects.
If we have ground truth autoware_msgs::DetectedObject just for people and vehicles(i.e. moving obstacles), that would be very useful to test planning module.

Hello All,
We are very pleased to hear that our Simulator tends to be very useful for Autoware developers. @hakuturu583 thanks for the proposal, I'd like to re-assure that we are fully committed to support it.
And there are a few points I'd like to suggest, Let's separate integration into 3 different issues:

Basic integration: will include launch Simulator button, static yml file configuration for simulator, odometry messages and other required information.
Advanced integration: will include dynamic configuration for weather and other parameters
Training with Simulator: Ground truth collection and extra topics publishing.

Since we are time constrained, I would suggest to make sure we complete 1) before next release in Dec and proceed with 2) and 3) during subsequent release.
@hakuturu583 what do you think? Do you mind to split this issue into 3?

We can keep this one, but move requirements for dynamic Simulator configuration and ground truth collection into another 2 issues.

@cirpue49 Thanks! I also think it is necessary for us publish ground truth in real time.
So, I want to add new field and solve this problem.
float32 time_of_day # 0.0~24.0
bool  freeze_time_of_day # default true
float32 fog_intensity # 0.0~1.0
float32 rain_intensity # 0.0~1.0
float32 road_wetness # 0.0~1.0
bool enable_traffic # default true
bool enable_pedestrian # default true
bool enable_high_quality_rendering # default true
uint16 traffic_density # default 500
bool publish_ground_truth #default false

If the publish publish_ground_truth command was true, the simulator publish all ground truth data which contains rosbag file.

@mitsudome-r I think this simulator is used for not only planning.
So, it is important for us to publish or log data as much as possible.

@zelenkovsky OK !! I split issues about Ground Truth collection.

@dejanpan we have been in touch with the Autoware team and have been collecting requirements and developing features required for this integration. We consider the simulator to be a work in progress and appreciate all the feedback we can get which will be taken into account for future development.
At the moment the simulator runs as a GUI applications, either on the developer’s machine or on another machine. Moving forward we may add other modes of operation based on requirements. We understand that it would be useful to be able to test individual modules with the simulator and supporting this is on our road-map (i.e. providing ground truth data). I believe much of the requirements you have proposed fall into this category.
As for the Autoware fork we are maintaining on github, it includes modifications intended to facilitate the use of Autoware with the simulator. With the integration proposed here users should be able to use the simulator with the official Autoware repository.

@hakuturu583 Thanks. I'll keep commenting in other 2 issues after split. Just last 2 cents regarding Ground Truth.

@cirpue49 Thanks! I also think it is necessary for us publish ground truth in real time.
So, I want to add new field and solve this problem.

I would suggest that we always publish ground truth in Training Mode via ROS messages and prepare a separate script for developer to collect and synchronize between messages. We have similar script already and we successfully used that to complete End-To-End Navigation training using camera and steering wheel. But let's details after issues are split, there are few other good ideas.

@zelenkovsky
I changed message namespace a little.
I forgot that the prefix is necessary for ObjectBbox2D message.

@zelenkovsky @cirpue49 @hadiTab @hakuturu583 thanks for your inputs, this is exactly what I was hoping for. Fruitful discussions like this were happening way too little in Autoware.
I will first reply to each of you and then add an item on my own.

@hakuturu583:
By rosbridge_server you mean: http://wiki.ros.org/rosbridge_server?

I think ground truth data is too large, so I think it will be better to logging ground truth data in rosbag file and does not publish to ROS network.

I am not exactly sure what do you mean here but the way that rosbag record works in ROS 1 is that it subscribes to rostopics and then stores the data onto the harddrive. So the data still goes through TCP or UDP.
It is another thing if you use rosbag API but I do not think that you refer to it, right?

@cirpue49

Purpose: Test traking and prediction. And generate training data for CNN

Do you mean that you would like to:

test tracking and prediction of your algorithms?
generate data for training of CNNs?

Is this any different from the items in my list?

One of the advantages for using a simulator is to test planning algorithm in a dynamic situation.
In the case of testing planning module, it is inconvient to only have access to the raw sensor data.
For testing planning modules independetly from perception modules, we need ground truth information for obstacles directly from the simulator.

I think that this is a great idea. I would suggest to open another ticket and to describe exactly:

Which motion planning algorithms do you plan to test
Which nodes are involved
Which data you need from and into the simulator (e.g. object list with ego motions, free space, ...)
What kind of world in the simulator you need
What kind of scenarios do you want (e.g. your car driving around the parked car on the lane, pedestrians crossing the street, ...) and how do you want them randomized
What kind of metrics do you want to test against  (cross track error, number of collisions, distance to other objects, ...)

@zelenkovsky regarding your comment:
I would like to see a bigger picture, for instance something like this: http://gazebosim.org/tutorials?tut=ros_overview&cat=connect_ros. Gazebo is the best integrated ROS simulator and many robots are supported. It has matured for > 10 years to come to this architecture.
There is also no shame or hard feelings if we just copy Gazebo design.
As you can see there is:

stand alone simulator Gazebo
gazebo_ros package with API and paths plugin that can start/stop/pause the simulator and provide basic topics (clock, link and model states), services (start/stop/pause) and parameters (whether to run in sim clock mode or not). It also provide various worlds.
gazebo_msgs
gazebo_plugins (for sensor data, dynamics and dynamic reconfigure)

Gazebo also has a complete documentation which with the architecture above makes it really easy to add/remove things to the integration.
With that in mind I would propose a following tweak to your plan:

Basic integration: will include launch Simulator button, static yml file configuration for simulator, odometry messages and other required information.

Advanced integration: will include dynamic configuration for weather and other parameters

Training with Simulator: Ground truth collection and extra topics publishing.

Comment on whether above is possible and create an architectural diagram (ala https://bitbucket.org/osrf/gazebo_tutorials/raw/default/ros_overview/figs/775px-Gazebo_ros_api.png) (this ticket)
Copy and adjust https://github.com/ros-simulation/gazebo_ros_pkgs (separate ticket)
Basic integration: will include launch Simulator button, static yml file configuration for simulator, odometry messages and other required information  (separate ticket)
Advanced integration: will include dynamic configuration for weather and other parameters  (separate ticket)
Training with Simulator: Ground truth collection and extra topics publishing  (separate ticket)

In the further tickets we could then proceed on to support various other use cases listed in https://github.com/CPFL/Autoware/issues/1724#issuecomment-441739827.

@zelenkovsky @hadiTab I have also 2 more questions:

In what language do you guys model your worlds and cars?  Gazebo is using  http://gazebosim.org/tutorials?tut=ros_urdf&cat=connect_ros for both.

How do you guys publish tf information?

@dejanpan Yes, you are right, I also think ground truth data will be huge size for rosbridge server.
So, I seted the default value of publish_ground_truth field's as false.
float32 time_of_day # 0.0~24.0
bool  freeze_time_of_day # default true
float32 fog_intensity # 0.0~1.0
float32 rain_intensity # 0.0~1.0
float32 road_wetness # 0.0~1.0
bool enable_traffic # default true
bool enable_pedestrian # default true
bool enable_high_quality_rendering # default true
uint16 traffic_density # default 500
bool publish_ground_truth #default false

I think when the user want to use ground truth while ruining simulator, they turn on this parameter.

@dejanpan I agree architecture diagram would be very helpful. I'll work on that and publish it in our GitHub repo. I'll provide a link afterwards. Regarding the rest of questions, let me tackle them one by one:

There is no argument that Gazibo has a long history and a lot of good ideas to borrow. We definitely should consider that while making architectural decisions. Gazibo is a general purpose robot simulator with full ROS support and good ROS integration. In the contrary, LGSVL Simulator is not a general robot simulator and we are not trying to be general robotics simulator. We are trying to be Autonomous Vehicle simulator with simple and clear goals: make automotive platform developer's life easier, support most popular open source platforms, be out-of-the-box solution. We expect that we do hard work of integration and world creation, provide existing available on the market set of sensors for developer to choose. Also we want to allow developers to collect data for training and create test cases scenarios. That's the goal of the project so far. I'd like to emphasize that we would like to support several autonomous vehicle platform, even through Autoware is among our favorites.

Taking all mentioned above into account, let's continue. We do not link against ROS or ROS2 libraries directly, but rather use ROSBridge to communicate with AD system. That gives a lot of flexibility: we can support ROS1, ROS1+Protobuf and ROS2 almost without any efforts from the Simulator side. We can run Simulation on Windows, which provides performance and visual benefits, since Unity3D engine is better optimized for NVidia drivers on Windows than Linux.

We definitely want to support dynamic simulator configuration and control (weather, start/stop and etc.) from AD side, but I suggest to think about that interface a little bit more. Since our goal is to be AD independent, maybe this interface should not be even based on ROS. That could be HTTP REST API or anything else. I'll keep it as open question for now.

Data collection and training: This feature is one of important tasks for AD developer and environment for data collection usually is a bit different than simply for simulation. Data collection could be done slower then real-time or faster then real-time, it does not affect the quality of the data. Usually developer does not ran AD while collecting the data or runs it in a simplified way. At the same time Simulator should produce a lot of extra information, usually not generated during ordinary run. So we are planning to have a separate Training Mode for the Simulator, but has not decided yet, how it should look like. Right now we export already semantically segmented images, images from depth camera and few other things. We want to export the data in a platform independent way, plus for developer that could be more convenient to use existing tools to record and manipulate ROS bags. This is why we suggest to use rosbag command line and further process the ROS bag with the set of our scripts to do message association (synchronization).

We model our environment in Unity3D, use C# and C++ for low level code. We create vehicle models in Maya or other 3D designer tools.

Yes we publish tf map base_link transform. Actually you can press F1 during simulation to see list of topics we publish and subscribe. Each vehicle has it's own unique number of sensors and control topics. Actually we assume that developer (at least for now) who wants to modify vehicle should open our Simulator code in Unity3D editor and change the configuration of the vehicle prefab. It is quite easy, plus Unity Editor is very good for visualizing sensor position and so on.

So far I believe I tackled most of questions, please let me know if there is anything missing ;)

@hakuturu583
I have few questions regarding your uploaded image.

The /clock topic seems to be published from Autoware to the simulater.
Isn't this the other way around?

Why do you include $(prefix)/$(sensor_name) namespace for object_2d, whereas object_3d?

What kind of information is included in object_3d? Does it include all the objects in the world including buildings, signs, etc.? I think including static objects is over-informed and moving objects are enough.

@hakuturu583
The /clock topic seems to be published from Autoware to the simulater.
Isn't this the other way around?

@mitsudome-r

The /clock topic seems to be published from Autoware to the simulater.
Isn't this the other way around?

It was my mistake, right connection diagram is here.

@zelenkovsky thx for reply.
I will provide a very long answer. Before I do so, can you just confirm that when you talk about ROSBridge you mean https://github.com/RobotWebTools/rosbridge_suite/tree/develop/rosbridge_server ?

That's correct. That is the original rosbridge for ROS1 that we use in our LGSVL simulator to connect to Autoware.
Note that we recommend using our forked version here: https://github.com/lgsvl/rosbridge_suite
It has few modifications to improve performance. But the original should also work fine.
Additionally our fork has extra modifications to be able to talk to Apollo over ROS. Apollo uses  modified ROS1 - where they added support for protobuf as message serialization. We implemented some minimal support for protobuf message serialization and unserialization in rosbridge_suite python code. This is not needed for Autoware.
And if you are interested in ROS2, then you need to use following implementation: https://github.com/RobotWebTools/ros2-web-bridge
It does same things as rosbridge_suite - supports exactly same JSON protocol over websocket to outside. It is implemented in Node.js, not Python.

@zelenkovsky @martins-mozeiko my reply to above 2 comments from you.
Let me just pre-face all of this that I do not want to suggest what and how you should do things in LGSVL simulator but I read some things in your comments which do not fit to my understanding of robotics and AD which I gathered over the last 15 years.
I am also not advocating for Gazebo, I am just comparing to what I know the most.

Gazibo is a general purpose robot simulator with full ROS support and good ROS integration. In the contrary, LGSVL Simulator is not a general robot simulator and we are not trying to be general robotics simulator. We are trying to be Autonomous Vehicle simulator with simple and clear goals: make automotive platform developer's life easier, support most popular open source platforms, be out-of-the-box solution. We expect that we do hard work of integration and world creation, provide existing available on the market set of sensors for developer to choose.

In my understanding an autonomous car is a robot: it has many sensors, it has actuator(s), it has a set of ECUs and it needs to do sense-plan-act job. A simulator that supports such a use case must in my POV have these components:

dynamics and kinematics simulation
3D graphics for rendering
sensor models
robot (car) models
middleware for internal message passing
some tools for e.g. editing of worlds and introspection of processes
IO to external frameworks such as ROS
mechanism for extensibility (e.g. for adding a new car or a new sensor model)

Do you agree with it? If yes in what way LGSVL simulator then specializes to be the Autonomous Vehicle simulator?

sensor models for sensors used in AD?
world models that include roads (cities, highways)?
world models that are generated from (or consistent with) AD maps?
1 ...

Gazebo supports 1 and 2 above but AFAIK not 3.

We do not link against ROS or ROS2 libraries directly, but rather use ROSBridge to communicate with AD system.

Gazebo also does not link to either ROS 1 or ROS 2 directly. It does so over  https://github.com/ros-simulation/gazebo_ros_pkgs.  In case of https://github.com/lgsvl/rosbridge_suite, the rosbridge_suite links to either ROS 1 or ROS 2.
So either way you can not avoid linking against a framework you are integrating into at some point. But you do not link against the simulator itself.
The other problem that I have with rosbridge_suite is that it does JSON string serialization/de-serialization. I have never seen that be performant enough for large data, e.g. see also Table 1 here.
I have not used rosbridge_suite in several years but I would be curious if it supports this throughput (typical AD car) which ROS 2 natively does:
Large Data:

3 Topics with 1.6 MB size @ 30Hz, 1 pub to 1 sub for each
1 Topic with 6 MB size @ 10 Hz, 1 pub to 1 sub
1 Topic with 0.5 MB size @ 120Hz, 1 pub to 1 sub
5 Topics with 0.25 MB size @ 40Hz, 1 pub to 1 sub

Small Data:

100 Topics with 256 Byte size @ 100Hz, 1 publisher to 50 subscribers

We can run Simulation on Windows, which provides performance and visual benefits, since Unity3D engine is better optimized for NVidia drivers on Windows than Linux.

ROS 2 now also runs on Windows, so at least for the LGSVL Simulator integration into https://gitlab.com/AutowareAuto/AutowareAuto we could use a clone of https://github.com/ros-simulation/gazebo_ros_pkgs/tree/ros2.

Since our goal is to be AD independent, maybe this interface should not be even based on ROS. That could be HTTP REST API or anything else.

To be honest 80% of industry is using ROS and rightfully so since it is the best framework overall. For Autoware.ai and Autoware.Auto there is no need to think about non-ROS solutions. Hence my proposal to replicate gazebo_ros project stands.

We want to export the data in a platform independent way, plus for developer that could be more convenient to use existing tools to record and manipulate ROS bags. This is why we suggest to use rosbag command line and further process the ROS bag with the set of our scripts to do message association (synchronization).

What is your definition of a platform? OS, Schema Language, Data Encoding, Backend Storage?
In any case rosbag is not platform independent, however for Autoware a preferred and widely accepted option. There is also a plethora of tools for rosbag manipulation and viewing. rosbag2 will also have significant improvements.

We create vehicle models in Maya or other 3D designer tools.

I am sorry, I should've been more specific. What I mean by a model is a format where you describe car's kinematic and dynamic properties. In ROS URDF or SDF are used.
Also where or how do you specify coordinate transforms for sensors, wheel joints, map and base_link. In ROS, again, you use  URDF or SDF are used. This then serves as input to robot_state_publisher to get the tf transforms onto the tf topic.
To recap I think that the most important features for the integration into Autoware (ROS) are:

we can transport at least above mentioned amount data from the simulator into our algorithms
it should be easy to define car model (kinematics, dynamics)
it should be easy to change coordinate transforms
we should be able to use standard ROS messages
it should be easy to write new sensor models
it should be possible to start/stop/pause the simulator as well as start it headlessly

@hakuturu583
I'm changing parameters file (sample_setting.yaml) to better align with the recent changes in Simulator (we are separating sensors for different vehicles)
So it will be something like this:
initial_configuration:
  map : SanFrancisco
  time_of_day : 17.0
  freeze_time_of_day  : true
  fog_intensity : 0.1
  rain_intensity : 0.6
  road_wetness : 0.5
  enable_traffic : true
  enable_pedestrian : true
  traffic_density : 300
vehicles :
  - type : XE_Rigged-autoware
    address : localhost
    port : 9090
    command_type : twist // not supported yet
    enable_lidar : true
    enable_gps : true
    enable_main_camera : true
    enable_high_quality_rendering : true
    position : // not supported yet
      x : 0.0
      y : 0.0
      z : 0.0
    orientation : // not supported yet
      x : 0.0
      y : 0.0
      z : 0.0
  - type : XE_Rigged-apollo
    address : localhost
    port : 9091
    command_type : twist // not supported yet
    enable_lidar : false
    enable_gps : false
    enable_main_camera : false
    enable_high_quality_rendering : false
    position : // not supported yet
      x : 0.0
      y : 0.0
      z : 0.0
    orientation : // not supported yet
      x : 0.0
      y : 0.0
      z : 0.0

I will also place sample config file to the root of the simulator source on github.
Simulator should be launched like this:
./simulator --config autoware/ros/src/.config/simulator/static_config_sample.yaml

@andytolst Thanks!!
Now, your simulator cannot set initial position of Autonomous Driving Vehicle??

@hakuturu583 we are still discussing what’s the best way of providing initial position.
Setting arbitrary x,y in virtual world coordinate system is easy, but it could easily lead to placing the car inside the building, and there is no easy way to know coordinates without launching Unity editor.
UTM or lay/lon makes more sense IMO, but it has its own complications

@andytolst I think it is better to spawn Autonommous Driving Vehicle without open Unity Editor.
It is very easy to convert car position in Autoware to UTM pose.
Is it difficult for your simulator to spawn Autonomos Driving Vehicle through ROS API or parameters??

@hakuturu583 It should not be very hard, Unity coordinate system is in meters, so it's just a matter of adding/subtracting a proper offset for UTM coordinates. I'll try that.
spawning Vehicle dynamically through ROS API (or some other API) should be possible, but this must be handled as separate task.


Metrics show in Graphite but not Values

I found out that vCloud Director controlled VMs are shown in Graphite but the chart says "no data" when you try to render it. All non vCD VMs work fine, so I assume it has something to do with the name under which they appear.

Commit 888349ed533c1f40911f4dc5df6058c1c82fe6db solved it. Looks like the parenthesis around the vCD UUID broke it.


fix: Update references to "mix.cli" to "mix-cli"

Update references to "mix.cli" to "mix-cli"

:tada: This PR is included in version 2.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add a test workflow on CI

To make sure tests are run on PRs and commits.

Merging as-is so we can pick it up in #5


PowerRegisterSuspendResumeNotification error on Azure App Services with go 1.13.7 [1.14 backport]

@networkimprov requested issue #37149 to be considered for backport to the next 1.14 minor release.

@gopherbot please backport. It's another instance of this regression...

Any Go program fails to start in certain restricted environments when running Windows.  Cherry pick approved.


Using NMT-Keras how could we create a model that can perform bi-directional translation

Using NMT-Keras how could we create a model that can perform bi-directional translation I..e. the model should be able to translate from French to English and then back from English to French.
How could we set up training of such a model using NMT-Keras?

Hi,
I already answered you in a previous issue (https://github.com/lvapeab/nmt-keras/issues/51). Please, do not open duplicated issues.


use xml files to make the configs more versatile.

can try maven or gradle

or Json .. or some such thing.
parquet


Gizmo is visible during GridMap editing

Godot version
4.0 dev (340ad7d74869e71d88f6ce7dcb1cf20e924faed2)
System information
MacOS, Macbook Air M1
Issue description
Current tool gizmo is visible when editing a GridMap, you can't use it but it steals input events and is visually in the way.

Steps to reproduce
N/A
Minimal reproduction project
No response

Could you please upload a minimal reproduction project ?

This likely needs special casing in the code that displays the manipulation gizmo to disable its drawing when a GridMap node is selected. I'm not fond of this solution as it would prevent add-ons from doing the same for their own nodes though.


refactor: Move Application backend around

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 49.30%. Comparing base (236c474) to head (262895c).
Report is 2 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #110   +/-   ##
=======================================
  Coverage   49.30%   49.30%
=======================================
  Files          52       52
  Lines        3296     3296
=======================================
  Hits         1625     1625
  Misses       1532     1532
  Partials      139      139

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Generation of point-and-direction surface

🔍 Before submitting the issue

[X] I have searched among the existing issues
[X] I am using a Python virtual environment

🐞 Description of the bug
When creating a surface. the following
surface = session.results.surfaces surface.plane_surface['plane-0'] ={     'methods': 'point-and-normal',     'point_vector': [-0.2, -0.15,  0.0],     'point_normal': [1.0, 0.0, 0.0],     'compute_from_view_plane': True,     'surface_aligned_normal': ''}
Creates a surface with the right normal but completely incorrect point.
Tested both
Fluent 23.1 and 23.2
PyFluent '0.12.dev13'
📝 Steps to reproduce
Execute above command in any case
💻 Which operating system are you using?
Windows
🐍 Which Python version are you using?
3.9
📦 Installed packages
NA

The issue is reproducible in PyConsole also

I have a Fluent side PR to fix this.

There might also be a duplicate. I remember this kind of issue being there a long time ago.

Fix merged in Fluent


HasDefaultValue type casting

Steps to reproduce
Add a property to your entity that is a short, specify an integer as a default value:
entity.Property(e => e.SomeShortProperty).HasDefaultValue(3);

The issue
This worked in RC1, but in RTM:

It looks like in RTM, EF7 doesn't try to type cast, so it sees an int as an invalid value for a short.
Changing the code to this works:
entity.Property(e => e.SomeShortProperty).HasDefaultValue((short)3);

I think it would be better if the type can be safely cast, then to handle that automatically.
Further technical details
EF Core version: (RTM)
Operating system: Windows 8
Visual Studio version: 2015

:+1:  thanks :-)


CRS.ObjectNameSuffix adds Suffix in procedures to objects parameters if procedure name ends with "action"

If you use a procedure in a page extension which name ends with "action", the suffix will be added to the parameter if the expected parameter is an object.
Codeunit
    procedure MyProcedureNameEndsWithaction(var test: Record "Sales Header")
    begin

    end;

Page Extension Before Saving
    trigger OnOpenPage()
    var
        TestCodeunit: Codeunit "Testcodeunit SUFFIX";
    begin
        TestCodeunit.MyProcedureNameEndsWithaction(Rec);
    end;

Page Extension After Saving
    trigger OnOpenPage()
    var
        TestCodeunit: Codeunit "Testcodeunit SUFFIX";
    begin
        TestCodeunit.MyProcedureNameEndsWithaction("Rec SUFFIX");
    end;

I will look at it - but these are insanely complex (for me ..) regex I have to deal with.
The problem here is the combinartion "page" object type and the word "action" .. which will indeed add suffixes.  I hope I can narrow it down thanks to this example...

meanwhile - please don't end your proc names with "action" ;-)


Fix compare

let's see if this works...

This fixes #12 and increases coverage to 100%. I will not stop bragging about 100% coverage soon.


Pausing the animation

Hi Ben, I'm Sonny, is there a way to stop & start the gradient animation?
My use case is a button that starts the gradient when held & stopped when let go.
I would also love to get my hands dirty with the source code, but not sure where to start, any guidance as far as implementing that myself or some other form would be appreciated, cheers!

@sonnyvesali
thanks for the feature request, just added AnimatedMeshGradientController in version 1.1.4. feel free to check out the README to see how it works.