Android Gradle Plugin 7.3.1 causes 'Instrumentation run failed due to Process crashed'

Describe the bug
Running instrumentation test with upgraded Android Gradle build tools results in error.
To Reproduce
Steps to reproduce the behavior:

In provided packages/patrol/example/android/build.gradle change classpath "com.android.tools.build:gradle:7.2.2" to classpath "com.android.tools.build:gradle:7.3.1"
Run patrol test --target integration_test/notifications_test.dart
At the end of the test you will get Test run failed to complete. Instrumentation run failed due to Process crashed.
See error.

Expected behavior
Exit code 0.
Device information

Device: Any
OS version: Android 33
Does it also both on physical and virtual devices? didn't check
Please include as much detail as possible

Additional information

Flutter 3.7.1 • channel stable • git@github.com:flutter/flutter.git
Framework • revision 7048ed95a5 (7 days ago) • 2023-02-01 09:07:31 -0800
Engine • revision 800594f1f4
Tools • Dart 2.19.1 • DevTools 2.20.1

0.10.9

patrol_cli v0.9.3

Additional context
Add any other context about the problem here.

Thanks for the report - I reproduced it.

Yes, it is a bug that got introduced in patrol_cli 0.9.1 specifically, hence my previous issue #891 .

Here's a diff between tag patrol_cli-0.9.0 and tag patrol_cli-v0.9.1.
I'll investigate it.

I think it's something caused by us passing --dart-defines:
This works:
./gradlew :app:connectedDebugAndroidTest -Ptarget=/Users/bartek/dev/leancode/patrol/packages/patrol/example/integration_test/notifications_test.dart

This crashes:
./gradlew :app:connectedDebugAndroidTest -Ptarget=/Users/bartek/dev/leancode/patrol/packages/patrol/example/integration_test/notifications_test.dart -Pdart-defines=UEFUUk9MX1dBSVQ9MA==,UEFUUk9MX1ZFUkJPU0U9dHJ1ZQ==,UEFUUk9MX0FQUF9QQUNLQUdFX05BTUU9cGwubGVhbmNvZGUucGF0cm9sLmV4YW1wbGU=,UEFUUk9MX0FQUF9CVU5ETEVfSUQ9cGwubGVhbmNvZGUucGF0cm9sLkV4YW1wbGU=,UEFUUk9MX0FORFJPSURfQVBQX05BTUU9UGF0cm9sIGV4YW1wbGU=,UEFUUk9MX0lPU19BUFBfTkFNRT1QYXRyb2wgZXhhbXBsZQ==,UEFUUk9MX1RFU1RfTEFCRUw9bm90aWZpY2F0aW9uc190ZXN0LmRhcnQ=


Docker compose bug fix and change to host networking

What this PR does / why we need it:

Change docker compose file to use host based. This avoids having an inconsistency between default configuration and docker compose configuration.
Fix bug with application.yml typo
Fix port configuration bug for postgres

Which issue(s) this PR fixes:

Hopefully fixes all bugs in #652, but more changes are required to close the issue
Does this PR introduce a user-facing change?:

None

There is one concern though - host network mode only works on Linux host machine. Mac users will not be able to use this.

There is one concern though - host network mode only works on Linux host machine. Mac users will not be able to use this.

Damnit I keep forgetting about that limitation. Isn't there a workaround that doesnt involve using private networks?

The workaround i used personally, is to do port mapping on 9092 for Kafka. If i want to test using local jupyter notebook, i edit my etc hosts such that kafka:9092 points to localhost:9092 (so that it matches the advertised listener host). I do agree this is not a pretty workaround, though.

Removed host networking.


Add death rate

Addressing #17.
This adds sex- and age-related death rates based on the SAS model (but not the exact numbers yet).
Still pending:

[x] Checking the performance of the age selection and possibly replacing it
[ ] Reading in values from a file
[ ] Tests on death rate

Will tackle more tests and reading in from file in a separate PR, to avoid this and #35 becoming too complex and interlinked.


Applisting!

@aaustin @shortstuffsushi

:+1:

@aaustin Could you please take a look at my latest commits? It's actually about throwing error for !hasUser in processNextQueueItem. Sorry about the mix, but since it's a small change, want to squeeze it into this PR.

nice catch @shortstuffsushi

:+1:

I'd say we can go ahead and push this Qinwei


onEndReached call multiple times & not correct

Hi there, you library is very cool except onEndReached not working correctly. I know you guys will fix it in the future. My question is when you will develop it. I really really need onEndReached feature. So any suggestion? Appreciated it!

I don't have an timeframe for a fix, this is a known issue.
In my apps I'm using a flag to tell that I'm currently loading more data to avoid doing it multiple times and it works well for my use case. It looks like:
_onEndReached = () => {
  if (!this.state.loading) {
    // load more
  }
};

This way even if onEndReached is called multiple times it still works.

@janicduplessis this works man! thanks by you comment!!

@janicduplessis If you Threshold is short... that state it is not enough, because change that state is async and in that async time _onEndReached  can be dispatched multiple times


RAdam for pytorch official

I am curious, why hasn't RAdam been included official in pytorch?
https://github.com/pytorch/pytorch/issues/24892

This paper shows that "the Rectified Adam (RAdam) algorithm can be characterized as four steps of momentum SGD, followed by Adam with a fixed warmup schedule." So, we may use the Adam with a warmup schedule instead when we need RAdam.
My implementation: https://github.com/Tony-Y/pytorch_warmup

Hi @Tony-Y, I'm curious why you prefer to use Adam with a warmup instead of RAdam.
I think the very basic fact both papers agree on, is that it's necessary to include warmup to handle the variance of adaptive learning rate. Their linear warmup schedule of 2/(1−β2) steps is just a further approximation to our derived first-order approximation.
Thanks for the question @brando90 and thanks for pointing me the PR. It is really an encouragement to me seeing that PR.
From my perspective, I don't think being included as an official module in PyTorch matters that much. The initiative of our study is to show the adaptive learning rate may cause some problems (the strongest evidence is the controlled experiments, i.e., Adam-2k v.s. Adam w.o. warmup). RAdam serves as a role to further verify our intuition on this matter. Although I'm very happy to see our optimizer helped & inspired many researchers, our optimizer is still experimental. It takes a lot of efforts to take the optimizer really to the next level.
We have been working on something new these two years, stay tuned : -)

Hi Liyuan,
Great to hear form you!
I am curious, what do you mean by "It takes a lot of efforts to take the optimizer really to the next level."? There aren't many hyperparameters to tune so I am curious what that means.
Looking forward to your next opitmizer!

@Tony-Y I am also curious to know why you prefer warm up vs RAdam - especially since RAdam seems quite robust and remove hypoer parameters (which are the ML researcher's nightmare!)

I think that a new approach introduced by RAdam is only a nonlinear warmup. Such nonlinear warmups may outperform the untuned linear warmup sometimes.

@Tony-Y the original paper you cited "On the Adequacy of Untuned Warmup for Adaptive Optimization" claims that RAdam is just equivalent Adam + Warm up. From that perspective it makes no difference which one of the too I use. Isn't it simpler to just fork then git clone this repo and then use RAdam?
The other alternative is to use the hugging face warm up https://huggingface.co/transformers/main_classes/optimizer_schedules.html?highlight=cosine#transformers.get_cosine_schedule_with_warmup and then use the linear schedule the paper you linked suggested.
In the end with the claim that they are "equivalent" either algorithm is fine. I will go with RAdam for now since it's already downloaded in my code and it's just as simple to use compared to the other. If you think warm up is better perhaps a tutorial on how to use your warm up version would be great to make it just as simple to plug in as RAdam. :)
I am looking forward to see how this debate on optimizers on transformers progresses.


MSVC can't handle constexpr INVALID_HANDLE_VALUE

Causes error C2131: expression did not evaluate to a constant
note: failure was caused by unevaluable pointer value

Thanks a lot!


Record

I did not understand how do you set up the txt record ?

That depends on the DNS server and the inventory mode you're using.
Let's say you're using the default mode of operation (the one that uses a DNS zone transfer to acquire the records) and you want to add a record for the host from the first example in the README file.
For bind9 you would edit the DNS zone file for the infra.local zone and add something like:
app01      IN           TXT         "OS=linux;ENV=dev;ROLE=app;SRV=tomcat_backend_auth"

For dnsmasq this would require a line in the configuration file:
txt-record=app01.infra.local,"OS=linux;ENV=dev;ROLE=app;SRV=tomcat_backend_auth"

In the future I plan to add support for something like a key-value store (etcd, Consul) or a local SQLite database to hold these records, so that you're not required to have a DNS server to use this tool.
Now, if your question is about the format of the TXT records themselves then there is no real "right" way to set them up.
You have five available attributes that any host can have. You then add a TXT record to your DNS server for every host that should be managed by Ansible, setting these attributes according to what role these hosts play in your infrastructure.
For example, if you have a Linux host with a Nginx reverse proxy that is related to your production environment then its TXT record might look like this:
OS=linux;ENV=prod;ROLE=proxy;SRV=nginx

Now you have a group that you can use to address all proxies (prod_proxy) and all Nginx proxies (prod_proxy_nginx) in your production environment
You can take this further and make the service identifier (the SRV attribute) more specific. Let's say your Nginx proxy deals with requests to some file storage service. You can transform its TXT record into something like this:
OS=linux;ENV=prod;ROLE=proxy;SRV=nginx_filestorage

You now have an additional group that this host belongs to: prod_proxy_nginx_filestorage. So now you can also address all Nginx proxies in your production environment that relay requests to your file storage service.
What's also important is the fact that all these groups belong to one branch of one big group tree so the prod_proxy_nginx group inherits variables from the prod_proxy group, the prod_proxy_nginx_filestorage group inherits from the prod_proxy_nginx group and so on.
You can have any number of these branches of any length and all this is done automatically, you just have to set the host attributes.

Thanks, mate


Make time budgeted retries always execute at least once

If a time budget of zero is given, this would previously not run the
retried code at all. This is awkward if we want to say "don't block" but
do want to try at least once.
This was breaking EventQueue which uses MessageQueue.put(..., timeout=0)
for non-blocking sends.
Do you think this messes up the concept of a total time budget too much? or is it
more surprising that the code wouldn't run at all?
:eyeglasses: @bsimpson63 @ckwang8128

I think it's more surprising that the code wouldn't run at all.
I don't think it's too weird for 0 to be a special case. I think it might make sense for it to be treated as the same as the no budget case (infinite retries).

:haircut: i don't think negative is actually gonna be an issue since the first execution will be usually almost instant between the two calls to time.time but either way i've added a max(0, time_remaining) to guard against the case. i tried a few alternatives and still feel this is probably right.
i agree that not executing at all is more surprising. i'm not sure that infinite retries would be a good idea with a time budget of zero though (and that'd specifically break the message_queue stuff)

🐟

67bb8dc5d2f65170e3551fcfed14d3dff695ea96


CNV-40317: Update SSH access via VirtCTL popover in VM SSH details page

📝 Description
Fixes:
https://issues.redhat.com/browse/CNV-40317
Make SSH access using VirtCTL section's popover more clear, add more info incl link to the related doc:
https://docs.openshift.com/container-platform/4.15/virt/getting_started/virt-using-the-cli-tools.html
🎥 Screenshots
Before:
Not quite clear SSH access popover text:

After:
More details in the popover, incl. documentation link:

@avivtur @pcbailey @upalatucci @metalice please review


Number of videos per trial

Hi there,
May I kindly ask for which part of code that regulate the number of videos saved is always 25?

Please see scripts for details; we save video for every trial evaluated and we perform grid-based evaluation.


PHP Fatal error:  Declaration of DElfimov\Translate\Loader\LoaderInterface::has($language) must be compatible with Psr\Container\ContainerInterface::has(string $id): bool

Hello!
When i use the following code to initialize translate:
$t = new DElfimov\Translate\Translate(
        new DElfimov\Translate\Loader\PhpFilesLoader(realpath($_SERVER["DOCUMENT_ROOT"])."/translations"),
        ["default" => $_ENV["DEFAULT_LANGUAGE"], "available" => explode("|", $_ENV["AVAILABALE_LANGUAGE"])]
    );

I get the following error:
 PHP Fatal error:  Declaration of DElfimov\\Translate\\Loader\\LoaderInterface::has($language) must be compatible with Psr\\Container\\ContainerInterface::has(string $id): bool
Am i missing a module or something like that?
Thank you in advance!

Figured it out:
It looks like this problem's happening because of the static typing added to psr/container between v1.0.0 and v.1.1.0 released to deprecate PHP < 7.2.
Added "psr/container": "1.0.0" to my composer.json in require and run a composer update solved the issue.


Validate account name input length (#511)

LGTM.
Might just be me, but feels a bit jarring to get the 'red/error' treatment after entering just one character? It's a small detail but essentially every user will see it and it's a first impression kind of thing.
Thoughts @marcinbodnar @kcole16 @vgrichina ?

but feels a bit jarring to get the 'red/error' treatment after entering just one character? It's a small detail but essentially every user will see it and it's a first impression kind of thing.

I agree

agree, it seems a bit unnecessary

@marcinbodnar @Patrick1904  Can we add a short delay to the validation? Alternative is onBlur, but I'm wondering how well this will work with a single input and disabled "Submit" button.

@marcinbodnar @Patrick1904 Is there a good way to solve this? Alternative is onBlur, but I'm wondering how well this will work with a single input and disabled "Submit" button.
Looks good other than that though!

We could hide the label while typing?

I will check hiding the label and delay options, see what works best.

@kcole16 @Patrick1904 ready, with additional changes that we were talking about on Slack

These improvements are really great. Some minor things:

Seems it easily gets stuck at ‘checking availability…’ (can we also make C uppercase) when only one character. Can probably default to ‘Username must be between 2 and 64 characters’ when value length is one.
‘Checking availability…’ doesn’t make much sense for non-account-creation cases. Maybe ‘Checking…’ for all other cases?
Can we also add some spacing between label and input on ‘send’ page please?

Thoughts @marcinbodnar @kcole16

@Patrick1904 @marcinbodnar Agree with those points.
Re: getting stuck on checking availability..., seems that the error shows correctly if you enter one character into the empty input, but will get stuck if you enter 2+ characters then delete back to just 1.

@kcole16 @Patrick1904
Done.
Additionally, I refactored requestStatusBox component (get rid of semantic-ui, simplify css - it was causing troubles) and made a proposition for showing requestStatus on Send Money and Create Account so the bottom content will not jump. On Create account I change:

margins - now the gap between small title and input is the same as between input and recaptcha text - I feel like recaptcha text belongs more to button, additionally input will be better visible
font size - changed to 12px - we have color on border that indicates status, so I feel like big text is not necessary
requestStatus text is now closer to the input.

Let me know what you think. It can be easily removed with the last commit.

@marcinbodnar Changes look good!
Last nit is that the text flips back to "Checking availability..." while waiting for the account creation transaction to confirm.

Great call on adding space between input and button to fix the jumping.
In regards to the label, I suggest we keep the 14px font size to maximize legibility since we expect user to actually read this :) The light blue color makes it especially hard to read with 12px font size. I’d also add a bit more space between the label and input: margin-top: -20px —> margin-top: -15px (seems to fix it).

@Patrick1904 @marcinbodnar @kcole16 any reason we aren't merging this?

@Patrick1904 @marcinbodnar @kcole16 any reason we aren't merging this?

My bad. I was thought this was merged already.


Add HOWTO explaining how to set up fully reproducible experiments

While JAX's RNG design is motivated to enable fully reproducible runs, this is still not always trivial due to multi-host training, or interaction with other libraries such as TFDS, which use a different RNG setup.
It would be useful to explain general strategies on how to set up a fully reproducible experiment. (See also https://github.com/google/flax/issues/291)

Closing this due to inactivity.


Ruff check?

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.46%. Comparing base (c2acd77) to head (97475ad).
Report is 787 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #156   +/-   ##
=======================================
  Coverage   94.46%   94.46%
=======================================
  Files         369      369
  Lines       12416    12416
  Branches     1296     1296
=======================================
  Hits        11729    11729
  Misses        556      556
  Partials      131      131

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Update shorter SwarmConfig's constructure

Motivation
By reading code flow to generate validator-set's configuration, I realized that the SwarmConfig's constructure is too long and difficult to understand. Proposed to make it shorter by using Builder paradigm called function for building each config instead.
Have you read the Contributing Guidelines on pull requests?
Yes,
Test Plan
Build the validator-set's config then build and run validator-set.
Related PRs
None.

Note:
After push changed in this PR I found that sometimes circle CI is unexpected failed unit test. (Build#2366)
I try look for reason behind by execute:
$RUST_BACKTRACE=1 cargo test --all --exclude testsuite
$RUST_BACKTRACE=1 cargo test -p network --lib
But both unit test executions are passed on my bench.
Then I simply reduced space line as commit dada500 to trigger circle CI to execute again then unit test passed. (Build#2370)


Aligining images

What is the best way to align pictures in your post? For example, center them. Or even float the left or right from your text?

Abridge has an img shortcode which accepts a class argument: https://abridge.pages.dev/overview-images/
You could specify a class when using the img shortcode, and you could add any manner of classes to the scss extra file:
https://github.com/Jieiku/abridge/blob/master/COPY-TO-ROOT-SASS/_extra.scss
This question or request has not come up before but I think it is common use for enough people that it should probably be added to abridge directly and update the example content to showcase it.
I would probably end up adding the extra classes to the modifiers section:
https://github.com/Jieiku/abridge/blob/c36fd6cca1070a671084ea0701ee783b3a97df2b/sass/abridge.scss#L1401
Once I get a little free time I will add the additional classes.

I think I could probably do this now before work, there should be enough time, one moment.

This is completed: https://github.com/Jieiku/abridge/commit/4dab5b9538f76cd56f53e6a68f34f505234e30ed
Hopefully that covers all the use cases you were after but if not then let me know.

I see you even added the left and right float. I'm a backend developer I'm just llm'ing myself through this frontend stuff :)

yes, and the one to center images, the class is  ci  (short for center image)


always check for can-be-merged

Check if PR can be merged on any PR action

Report bugs in Issues
The following are automatically added:

Add reviewers from OWNER file (in the root of the repository) under reviewers section.
Set PR size label.
New issue is created for the PR. (Closed when PR is merged/closed)

Available user actions:

To mark PR as verified add /verified to a PR comment, to un-verify add /verified cancel to a PR comment.
verified label removed on each new commit push.
To cherry pick a merged PR add /cherry-pick <target branch to cherry-pick to> to a PR comment.

Support only merged PRs

To add a label by comment use /<label name>, to remove, use /<label name> cancel

Supported labels

hold
verified
wip
lgtm
approve
target-version-

/verified

/verified


Update virtual-machines-disks-incremental-snapshot.md

added context and clarified install for windows vs linux.

@larryclaman : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@larryclaman : Thanks for your contribution! The author(s) have been notified to review your proposed change.

It's my pleasure to help out!

@larryclaman Thanks for making the adjustments. :)
Everything looks good so:
#sign-off

@Jak-MS : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Remove verb-timing callback, return verb-timings as Run Result

General question, should we do all this changes on a new version of datashaper? 0.25?

General question, should we do all this changes on a new version of datashaper? 0.25?

Yes, that will happen once this is at a point where we want to cut a release. When we change pyproject.toml's version number, once that hit main it will cut a release, and I want to avoid that for now


Static links on ./docs/api page are not rendered

Describe the bug
This is a continuation of https://github.com/heartexlabs/label-studio/issues/728 for the ./docs/api page. See that issue for more details.
When using the option --host argument with a base URL (ie --host "http://ls.domain.com/subdomain/") the href's on the ./docs/api page that start with /static need to be changed (I count 5 instances on the page) to either a relative page (starting with ./) or, as has been done on all the other pages,  give the full URL to the resources (ie href="http://ls.domain.com/subdomain/static/..."
As it is currently coded the ./docs/api page is not rendered by the browser.  This may cause follow on issue when using the API, but I have not tested that functionality yet.

@laynr Thank you for your report.
At first sight it looks like not a simple task, because API docs are generated by drf-yasg and I'm not sure it supports the host url replacement.

I can confirm that issue.

Related https://github.com/heartexlabs/label-studio/pull/2303

Do you have any ideas how to fix it?

Do you have any ideas how to fix it?

Maybe FORCE_SCRIPT_NAME does not reach /api/docs
https://drf-yasg.readthedocs.io/en/stable/settings.html#default-api-url
https://drf-yasg.readthedocs.io/en/stable/openapi.html#custom-spec-base-url

For example the script locations are missing the subpath.

@juliusvonkohout is this issue critical for you? You also can check api docs here:
https://api.labelstud.io.

@juliusvonkohout is this issue critical for you? You also can check api docs here:
https://api.labelstud.io.

More critical is the general iframe incompatibility, but even this alone here is a bad user experience.


404 - Incorrect path while calling any method

Hi there this used to work, but somehow now is failing with 404. I have the following code:
  val coinGecko = CoinGeckoClient.create()
  println(coinGecko.ping().geckoSays)

Yields:
drewcarlson.coingecko.error.CoinGeckoApiException: CoinGeckoApiError(code=404, message=Incorrect path. Please check https://www.coingecko.com/api/)
	at drewcarlson.coingecko.CoinGeckoClientImpl.ping(CoinGeckoClientImpl.kt:382)
	at drewcarlson.coingecko.CoinGeckoClientImpl$ping$1.invokeSuspend(CoinGeckoClientImpl.kt)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
	at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:164)
	at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:469)
	at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:503)
	at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:986)
	at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
	at io.ktor.server.netty.EventLoopGroupProxy$Companion.create$lambda-1$lambda-0(NettyApplicationEngine.kt:260)
	at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
	at java.base/java.lang.Thread.run(Thread.java:831)

Tried with version 0.4.0 and 0.4.1-SNAPHOST

I'm unable to reproduce this error, does it still occur for you?  Do you have a VPN or Proxy configured?
If you still experience this issue, could you enable HTTP Call logging and share the request log?

This is resolved in v0.4.1 which will be available soon or the 0.4.2-SNAPSHOT builds are usable now.


lib.webworker.d.ts doesn't include canvas related types

lib Update Request

Configuration Check

My compilation target is ES2015 and my lib is webworker, es2019.
Missing / Incorrect Definition

Canvas-related types, such as CanvasState, are not present in lib.webworker.d.ts in any of the latest releases (4.5.5, 4.6.0-beta etc.). They are only present in lib.dom.d.ts.
This prevents the use of @types/offscreencanvas in webworker sources build.
Somehow confusingly, the missing types are there in your main and release-4.6 (in lib.webworker.d.ts), but not in actual releases in NPM.
Sample Code

Installing @types/offscreencanvas and using "types": ["offscreencanvas"]. No code is needed, because this will fail on its own if webworker lib is used (instead of dom).
Build failure:
Error: node_modules/@types/offscreencanvas/index.d.ts:14:53 - error TS2304: Cannot find name 'CanvasState'.

14 interface OffscreenCanvasRenderingContext2D extends CanvasState, CanvasTransform, CanvasCompositing,
                                                       ~~~~~~~~~~~

Error: node_modules/@types/offscreencanvas/index.d.ts:14:66 - error TS2304: Cannot find name 'CanvasTransform'.

14 interface OffscreenCanvasRenderingContext2D extends CanvasState, CanvasTransform, CanvasCompositing,
                                                                    ~~~~~~~~~~~~~~~

Documentation Link

MDN specifically mentions that OffscreenCanvas is available in web workers.

This really is a blocker for anyone using webworkers in combination with offscreencanvas anywhere in the code.

Maybe fixed by #51300?

Is there a workaround for this?

This was fixed in #51300, yes.


[Backend] Build the runtime against stdlib v0.1.0

Build the runtime against the latest version of qir-runner.

Looks good, can you adjust the github action such that it caches this build ? :)


Completed Ex 4!

Sorry there are two of them again, I had to go back and fix my mistake!

Please only view the most recent one! I went back and watched the video from class and was then able to do this properly.

It seems like you got most of the way there, with the merge and importing a main function from a module. You also used functions well to break the problem down into smaller pieces. It seems, though, like it's missing a groupby and aggregation step to count the number of units within each ward, and a filter to sum only the units within a certain range of AMI. The group office hours video from this past Tuesday, now posted on ELMS, may be helpful to look back at.


LEAN-3071: TNE-040 - Display table notes - FE implementation

@nghazzawi-atypon, please check https://github.com/Atypon-OpenSource/manuscripts-body-editor/pull/166/commits/a0c857c6a24e313dff0d93822deb05f8e0cfd476


[Bug][Plugin] GitHub Test API Endpoint Degraded

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
When performing a connection test for GitHub providers, the BE API does not respond with the proper response payload when a Valid Connection token is added, instead it only gives a username in the response body, response.success is missing.
What you expected to happen
All Connection Test responses regardless of provider should respond with the following payload:
{
  "success": true,
  "message": "success"
}

In the case of GitHub, when a single personal token is provided it's expected that username information also be included
{
  "success": true,
  "message": "success",
  "login": [USERNAME]
}

In the case of GitHub, when multiple personal tokens are provided it's expected that username information also be included, along with errors if any of the tokens are invalid. Using a key called $login may not be ideal. Usernames need to be returned by Token Index for a multi-token scenario. Technically the validation message would need to be either an array or object keyed by Token ID as well.
{
  "success": true,
  "message": "Token #1 is invalid...., Token #2 Invalid",
  "usernames": {
    1: [USERNAME_TOKEN_ID_1],
    2: [USERNAME_TOKEN_ID_2]
  }
}

How to reproduce
Test a GitHub Connection with 1 valid Connection Token.
Screenshot

Version
main
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hmmm, from issue #2367 ,we should test connection one by one for github

Hmmm, I can add that info right now

Hmmm, I can add that info right now

Thanks @warren830 for getting this patched up.


Improve select menu

Improve select menu for choosing "y" or "yes".

Agree. Also exception message.


[vcpkg] always pass VSCMD_SKIP_SENDTELEMETRY=1

Fixes #10468

Alright, I'll merge at 4 if nobody has any complaints.


Feature Request: log scale for y-axis

It would be nice if y-axis could optionally have a log scale, e.g. below (electricity power consumption)

This would be a great feature.  Ideally, you could select between log-10 and log-2 (or maybe an arbitrary value, but those are the most common).

Please see here and give your feedback ! Thanks !


create fixnoise code

Creates fixnoise code. I am not sure if this is the correct way, so I summon @EiffL and/or @aguinot to review. This is really just a short few lines of code. I get the mean and std of the images, create noise images based on them, shear just the same, and then I rotate them by 90 degrees before adding to the main image.

I am not sure about your implementation. Here are a few things that are important:

Your implementation does not include psf deconvolution/reconvolution
From my understanding, you are measuring the noise on sheared images which is bad for 2 reasons:

Your input noise image will be different for all sheared version and that is a big problem!
You are not using the true noise but the deconv/reconv image that is also an issue because the noise on this image is already correlated.

Since you are using randoms here, one of your input should be a seed or a random generator for reproducibility and doing tests consistently. (I prefer personally prefer random generator. It easier to handle mass processing).

I would encourage you to look at the implementation in ngmix which is actually even simpler than yours. Basically you leave your method generate_mcal_image as it is (without the fixnoise addition). then you do the following:
def get_fixnoise_mcal(img, psf, rng):
    """
     Get mcal image using fixnoise correction.
     param:
         img: galaxy stamp
         psf: corresponding psf
         rng: either seed or random generator
     output:
         mcal_images
     """
     mcal_img = generate_mcal_image(img, psf)

     # handle the noise
     noise_img = get_noise(img, rng)
     input_noise = rot90(noise_img)
     mcal_noise = generate_mcal_image(input_noise, psf)
     # rotate back the noise
     final_noise = rot90(mcal_noise, k=-1)

     # correction
     final_result = mcal_img + final_noise

     return final_result

You can have a look at their implementation here
Also, given the autodiff framework I am not sure if what I proposed above work as it is or if it require some changes. I guess generating randoms within the autodiff part is not ideal so you will probably need to that outside the function (generating the noise image). Which make sense since in a more realistic context the noise will be provided by the step before the metacal.

Apart for the comment I left, the rest looks good to me


fix: fix link

What ❔
fix link
Why ❔
404
Checklist

[x] PR title corresponds to the body of PR (we generate changelog entries from PRs).
[x] Tests for the changes have been added / updated.
[x] Documentation comments have been added / updated.
[x] Code has been formatted via zk fmt and zk lint.
[ ] Spellcheck has been run via cargo spellcheck --cfg=./spellcheck/era.cfg --code 1.

Thank you for your contribution. We are refactoring this part now, and we will update the docs as well. cc: @EmilLuta

@Tleaoo thanks for the contribution but this has been resolved in #869


Freez when chat opens

Hi thanks for this amazing mod, can you add a way to clear the chat ? because the chat freez the game every time the chat opens because reloading chat content, the only way is to disconnect and reconnect

No it cannot be done via server side, a client side mode has to be made for that.
It's a VRising issue, not the mod issue.


Create Annotations

A brief description of the usage of annotations in java.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Oh Manish , this was my first time contributing to open source, hence I
didn’t know that there was formatting required. Will follow it hence forth
On Fri, 7 Dec 2018 at 2:41 PM, Manish Giri<EMAIL_ADDRESS>wrote:

@Manish-Giri requested changes on this pull request.
Hi @ShashwathJS https://github.com/ShashwathJS
Please review the style guide for guide articles
https://github.com/freeCodeCamp/freeCodeCamp/blob/master/docs/style-guide-for-guide-articles.md
for the right way to create and edit guide articles.
Please edit your PR to add the correct formatting to your changes.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/freeCodeCamp/freeCodeCamp/pull/23534#pullrequestreview-182602485,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AqQEj6wT3GSKcurz0wgtdKlxGeqnkZjGks5u2jDVgaJpZM4Xxa0-
.


Sliding panes - Andy Matuschak

Description of the new feature / enhancement
TLDR; a sliding window management system for FancyZones similar to this community plugin for the Obsidian app for users who want the productivity boost that tiling can bring while keeping valuable screen real estate. With this, you no longer need to choose between no screen space without minimizing and ample screen space with messy windows; you can have both.
I come from Obsidian.md where they offer a community plugin which organizes the window panes from within their app in a unique and really useful way. I haven't seen any other window manager do this other than in this app. Basically, the windows don't tile, they stack in a cascaded fashion with the focused window sliding over the others like a card in a deck. It's beautiful. I tried to set something similar up in FancyZones but it just doesn't work well. Super clunky with windows covering other windows, unable to find one of the windows in the 'deck', etc. The good news is this unique feature is already coded and done, it just needs to be applied to the windows window manager as an option in FancyZones.
How it might work:
Go take a look at the github page for the plugin I referenced. There is a video which perfectly demonstrates its usage. It might be difficult to implement the horizontal scroll bar, but you don't even need it because clicking on the window bar on the left of the window automagically moves the other windows out of the way with a really pretty animation. I'm unsure if moving the titlebars on the left of the window is easy or not, but it would complete the look, I think. Although this could easily work by just adding a thin clickable line to the window you want to focus, and the other cards just move out of the way (see the video). It really is beautiful and so clean.
It's a tall order but this would revolutionize windows window manager in my opinion. Not even Apple has thought of this and they're all about user experience. Windows 11 was a great step in the right direction but it needs more than some window snaps and a center bar. This would be a game changer.
Scenario when this would be used?
Why?
Tiling allows you to work on many different windows at once, which is great for getting a lot done, but it can be distracting. For people who have many different programs open at once, but don't want to minimize or shrink their screen real estate with tiling, this works perfectly. It puts the focus on one window, and allows for easy access to the other windows.
Supporting information
The plugin on obsidian has 160k downloads as of now, and that's just the Obsidian userbase. Andy Matuschak also uses this method in his notes website.
If this was done like the sliding panes plugin, it wouldn't be too much of a stretch to do it vertically as well. It could be extended even further too by allowing screen space for a sliding system as well as a static system. For example, sliding panes for the left 3/4 of the screen and the other 1/4 right can have pinned windows that don't slide.

 Please make it stop.  Please make it stop.  This is a feature request...It's not even implemented.

Well, I have a bug where my windows are sliding to the left/resizing/snapping to the left of the selected zone/sliding off-screen perhaps related to display-scaling and I was blind with rage when I typed that so

Well, you're also an idiot because again, this function you're referring to is the standard function of the app. The whole point is to have windows snap automatically to the configuration you've set using the keybindings and mouse shortcuts. Second, this isn't the general issues thread you're commenting on; it's my own feature request, not a bug report, so your complaining isn't wanted here. Third, if you're going to rage that hard over an app you could always just uninstall, you should get some help.

@daamiian Please watch your language and follow our Code of conduct.
@tristansly If you think you found a bug with PowerToys please open a new issue

This would deem this a new utility i think vs fancy zone integration.  I also think if that app works for you, please use that app
@tristansly please watch your language and be kind to everyone.  PowerToys is a safe haven to share ideas and thoughts.

@crutkas It could definitely qualify as a fancy zone integration. Make a zone that allows windows to stack like a deck of cards. You already have the useless focus zone, which is on the right path to being something like this suggestion but not really useful. Also, I do use Obsidian, and it's a note taking app, having nothing to do with window management. I was just using it as an example for what functionality this request was asking for.

I would rather think of it outside FZ, integration is bonus points.
When I see this functionality it is more full blown window manager vs FZ which has very targeted purpose.

Great idea, but I think it would better fit for separate apps, such as File Explorer, but not for the whole windows management system. For example, how would it handle fullscreen windows, confirmation popup windows, existing snap layout features?


Add reset function to useAlgoliaSearch()

Is your feature request related to a problem? Please describe.
When having the search in something like a popup / modal I would like the search to reset when closing it. Unfortunately even tho my search component gets unmounted, the next time it gets mounted it already shows the previous result.
Another use case is that I want to reset the search when the input is empty.
Describe the solution you'd like
Add a useAlgoliaSearch should return a 'reset()` function that can be called e.g. onUnmounted().
Example:
const searchInput = ref('');
const { result, search, reset } = useAlgoliaSearch('products');

watchDebounced(
  searchInput,
  async () => {
    if (searchInput.length < 4) {
         reset();
         return;
    }

    await search({
      query: searchInput.value,
    });
  },
  { debounce: 200, maxWait: 500 },
);

onUnmounted(() => {
  reset();
});

Hey there,
Thanks for reporthing this feature request. I do like this idea but I wonder if maybe you could do something like this already:
const searchInput = ref('');
const { result, search, reset } = useAlgoliaSearch('products');

watchDebounced(
  searchInput,
  async () => {
    if (searchInput.length < 4) {
         result.value.hits = [];
         return;
    }

    await search({
      query: searchInput.value,
    });
  },
  { debounce: 200, maxWait: 500 },
);

onUnmounted(() => {
  result.value.hits = [];
});

You can even wrap it around with a function reset that could work just like you showed in the example. I think that if I would implement this reset function as a part of the composable, it would essentialy do the same thing and considering that I all do here is just setting hits to empty array.
Let me know what you think about it :)

Let me check! :)
I would kinda expect the compostable resets when the component is unmounted tho.
There is also a problem that it flickers when I remove the search result when the input is empty and when it then comes again it shows the previous result for a split second. So a reset is very much required imo. I will check if I can set the hits to an empty array BUT I already have a message "No results found" when the array is empty. So it would be better if the whole result is empty again like before the first search.

So I tried and result.value.hits = []; would be an option BUT I think it would be better to reset the whole result on unmounted. On reason is that I use result.value.hits.length === 0 to display a non results message but also result contains more stuff (like highlighted items) that also need to be resetted.
I made a PR that should do the trick, optionally this could be done by an configurable option.


Features/projectable fields addition

@NRBPerdijk @jhkuperus Please review

That is the leftover of another implementation I was trying out. I missed it in the review. Will commit a fix right away

👍  Leaving it open for @NRBPerdijk to review it as well.


120 - route display

Seemed something went wrong with the 120 route display when I chose "by route" , it showed as this;

But when I refreshed the site and tried again it displayed correctly - not sure if this is a bug or not

Claire, are you able to recreate this? I have seen it once or twice but I cannot do it consistantly.

I managed to recreate it for all routes by - clicking on a route - it displays correctly - then click on "all routes" - and I got this image;

I can recreate this. Will include a fix for this in the next test release.

This can be recreated by doing the following workflow:

Open the application
Zoom in 3-5 levels towards Moorehouse Ave
Click the 'By Route' dropdown and choose route 140
The map zooms out and leaves marker symbols still displaying


Fixes - KEY is already defined in argument scope error …

when the _sign() method is called it throws an error because the function had an argument and var both named 'key'. on ACF 11.

@timmaybrown Well that looks like a bug in ACF11 but it's a work around I guess... Another work around would be to use Lucee instead :wink:
Thanks for the pull request.


PyQt5/QtCore.so: undefined symbol: “PySlice_AdjustIndices”

If anybody is seeing PyQt5/QtCore.so: undefined symbol: “PySlice_AdjustIndices” when running gui_tool see this issue -> https://www.riverbankcomputing.com/pipermail/pyqt/2018-July/040511.html
This is not a bug in gui_tool but in PyQt5

A suggested workaround:
sudo pip3 install -Iv PyQt5==5.10.1

Should we update setup.py?

Probably. Unfortunately I'm not able to contribute to this repository. Sorry.

Closing as obsolete as this bug in PyQt was fixed long ago.


Cannot start scrcpy with Xiaomi redmi note 11

Could you please help me how to solve this?
http://imgway.cz/s/4Jei

See #833.
Also, please do not post screenshots of text (just post the text instead).


Disable PSP in logging-operator

The PSP API is deprecated in recent k8s versions, so we need to disable it.
Closes: #444

API is not yet removed in the latest k8s 1.24, so we don't need to do this yet.