replace interface{} to any, add fuzz test and fi… …x bug -0

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.49%. Comparing base (46373d4) to head (04ffa4e).
Report is 2 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
+ Coverage   92.38%   92.49%   +0.10%
==========================================
  Files         124      124
  Lines        6726     6731       +5
==========================================
+ Hits         6214     6226      +12
+ Misses        408      402       -6
+ Partials      104      103       -1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


More idiomatic domain types for privval responses

Description
The privval gRPC protocol responses have the same structure and convention: they either have the usable value field, or the error field present. This looks very much like the Rust Result type, and the tendermint-rs domain type should also be an enum with a conversion to Result, if not straight Result (unfortunately, it's not possible to define Protobuf conversions for the latter).
Definition of "done"
These types in tendermint are changed to enums to represent either a success value or a RemoteSignerError variant:

proposal::SignedProposalResponse
public_key::PubKeyResponse
vote::SignedVoteResponse

In TryFrom conversions from the tendermint-proto structs, presence of both fields is treated as an error.

FWIW here's how I've handled this elsewhere: https://github.com/iqlusioninc/iqkms/blob/2ac999e/iqkms-ethereum/src/error.rs#L58-L62
It defines a conversion from an Error type to tonic::Status, as gRPC responses are modeled as Result<T, Status>.
There's quite a bit of rich error information you can potentially return as a tonic::Status.
See also: #1147.
Also I take it this whole issue is hypothetical as #1227 is blocked on https://github.com/tendermint/tendermint/issues/9256, unless you're talking about a prospective tendermint-privval crate? (#1152)


Package does not appear in pub search results

This issue was originally filed by<EMAIL_ADDRESS>
This is the package, it does exist and I can add it to dependencies on projects with no problem https://pub.dartlang.org/packages/dtmark
However if I search for it (for example with this link) https://pub.dartlang.org/search?q=dtmark there are no search results.

This issue has been moved to dart-lang/pub-dartlang#371.


pull request for e2e test at 01/09/2017 14:56:09

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


"failed to compile bootimage v0.4.3"

I cant cargo install bootimage it throws out these errors
error: expected one of , or as, found ::
--> .cargo\registry\src\github.com-1ecc6299db9ec823\bootimage-0.4.3\src\config.rs:27:17
|
27 |     use std::{fs::File, io::Read};
|                 ^^ expected one of , or as here
error: expected one of ; or as, found ::
--> .cargo\registry\src\github.com-1ecc6299db9ec823\bootimage-0.4.3\src\config.rs:27:17
|
27 |     use std::{fs::File, io::Read};
|                 ^^ expected one of ; or as here
error: expected item, found ;
--> .cargo\registry\src\github.com-1ecc6299db9ec823\bootimage-0.4.3\src\config.rs:27:34
|
27 |     use std::{fs::File, io::Read};
|                                  ^

Seems like your compiler doesn't understand nested import groups. They were added in Rust 1.25, so maybe you're using a too old compiler?

yep updated rust nightly and it worked thanks also you should probably close solved issues


UI fixes for Dark theme

This PR fixes some UI errors found while testing in dev deployment.
This PR also includes a lot of changes to "hard-coded" colors to CSS variables
Spec: https://github.com/NuGet/Engineering/pull/5209
Main Issue: https://github.com/NuGet/NuGetGallery/issues/8773
Statistics page

README

Vulnerable/Deprecated tags

The new copy button is so beautiful for multi-line installation instructions!!! 😂


Inline Literal color

I installed the theme and I am using it to create local custom documentation.
But for some reason the inline literals are rendered with color black instead of red:

To check if the problem was  my setup I cloned this repo and I built the docs_demo:

And it works as expected, rendering the inline literals with red.
Is there something I am missing?
These are my changes to the conf.py:
# The theme to use for HTML and HTML Help pages.  See the documentation for
# a list of builtin themes.
html_theme = 'sphinx_rtd_theme'

# Theme options are theme-specific and customize the look and feel of a theme
# further.  For a list of options available for each theme, see the
# documentation.
#html_theme_options = {}

# Add any paths that contain custom themes here, relative to this directory.
html_theme_path = [sphinx_rtd_theme.get_html_theme_path()]

I just found this:
https://github.com/snide/sphinx_rtd_theme/issues/203
So the solution is in a commit merged into master after the 0.18 tag. In order to test it locally I removed the theme and install it again, pointing to an specific commit:
sudo  pip install git+https://github.com/snide/sphinx_rtd_theme.git@66d865d9c452152a2aec45b82ff7b4dc8a2194b5

Hope that helps to someone else.


Editable

add: setting value in color picker from outside (works after component creating).
add: edit property for numberboxes.
Please, try it, i think it may be useful.

Looks  great, the only thing, again, is the "test/test.pro.user" file - maybe add it to .gitignore so it doesn't keep getting added
(if it's not something that has to be in the source control, that is)?


Add e2e test for CPU Scaler

Proposal
https://github.com/kedacore/keda/tree/main/tests
Use-Case
No response
Anything else?
No response

Hi @JorTurFer Is anyone working on this issue? If not, I'll be happy to take this up.

Nobody is working on this AFAIK, so feel free to do it :)
Thanks for it!!

Hi @JorTurFer Added the Cpu test . PTAL


Plan Perfboard layout

The following images show the planned perfboard

the following is the first part of the perfboard

Back is on top and front is under

The following is the second perfboard

soldered everything after


sqz cli commands throw error message

Bug Report Template -----------------------------------------------
Squeezer Framework Version information ( squeezer-cli version ) :

Squeezer CLI version: 1.1.14
Node version: 6.11.0
Operating system: Windows 10 Pro, version 1703, OS Build 15063.413

Expected Behavior:
I expect that the commands in the cli should execute without any problems, i.e: "sqz create --project my-first-project --template aws-api-nodejs --email<EMAIL_ADDRESS>should create a new project with the name "my-first-project" based on the AWS generic API Hello World template.
Actual Behavior:
All sqz commands throw the same error message in the cli. The error message can be seen below:
module.js:471
throw err;
^
Error: Cannot find module 'C:\Users\Bogdan\AppData\Roaming\npm\node_modules\squeezer-cli\bin/lib/common/cli/error'
at Function.Module._resolveFilename (module.js:469:15)
at Function.Module._load (module.js:417:25)
at Module.require (module.js:497:17)
at require (internal/module.js:20:19)
at Object. (C:\Users\Bogdan\AppData\Roaming\npm\node_modules\squeezer-cli\bin\bin.js:10:13)
at Module._compile (module.js:570:32)
at Object.Module._extensions..js (module.js:579:10)
at Module.load (module.js:487:32)
at tryModuleLoad (module.js:446:12)
at Function.Module._load (module.js:438:3)

@goldsteinrazvan I've found the issue , it seems that is related to a path load issue on Windows , is seems the cli works well on OSX and Linux . I've added added in milestone https://github.com/SqueezerIO/squeezer/milestone/3

Squeezer looks good to me. Unfortunately I have the same error on OS X (10.12.6.).

thanks for the update @jensneuhaus , you should see the fix on next release .

Also observing this on Linux, node version 6.11.4.

thanks for feedback @thewtex ! it will be fixed on the next release , you can add a repo watch and grab the fix instantly :)
Cheers !


Eye notification on resolve

We receive eye updates when processes crash, but I was wondering if it was possible to then receive an notice when the crash has been resolved.

@phoolish have you looked at using eye-http? we do state and state-transition monitoring via polling of the eye-http port as seen here, which i think would address this?

@nathwill interesting solution.  I don't think it is plausible in the short term to setup API access and add the necessary security layer for our monitoring, but I am interested in that approach as a long term solution.

i not think this should be by default, but you can easy do it with custom trigger:
class Eye::Trigger::FixCrash < Eye::Trigger::Custom
  param :times, Fixnum, nil, 1
  param_default :to, :up

  def check(_)
    # process states here like this: [..., :starting, :down, :starting, :down, :starting, :up]
    states = process.states_history.states

    # states to compare with
    compare = [:starting, :down] * times + [:starting, :up]

    if states[-compare.length..-1] == compare
      process.notify(:info, "yahho, process up")
    end
  end
end

Eye.app :bla do
  trigger :fix_crash

  process :a do
    pid_file '/tmp/1.pid'
    start_command "ruby -e 's = `cat /tmp/bla`; exit(1) unless s =~ /bla/; loop { sleep 1 } '"
    daemonize!
  end
end


DropdownButtonFormField does not update

Hi,
DropdownButtonFormField does not update from a later call of setState
the call is made by some data change in my app, but i get the same result by running the code underneath (same thing works fine with DropdownButton)
The DropdownButtonFormField  never changes from a.
code:
class DropdownExampleListWidged extends StatefulWidget {
  @override
  _DropdownExampleListWidgedState createState() =>
      _DropdownExampleListWidgedState();
}

class _DropdownExampleListWidgedState extends State<DropdownExampleListWidged> {
  List<String> list = ['a', 'b', 'c', 'd'];
  String selected;
  void initState() {
    setState(() {
      selected = list[0];
    });
    Future.delayed(const Duration(milliseconds: 3000), () {
      setState(() {
        selected = list[3];
      });
    });
    super.initState();
  }

  @override
  Widget build(BuildContext context) {
    print(selected);
    return DropdownButtonFormField<String>(
      value: selected,
      onChanged: (String newValue) {
        setState(() {
          selected = newValue;
        });
      },
      items: (list).map<DropdownMenuItem<String>>((String value) {
        return DropdownMenuItem<String>(
          value: value,
          child: Text(value),
        );
      }).toList(),
    );
  }
}

console output:
Reloaded 9 of 1012 libraries in 1,490ms.
V/ViewRootImpl[MainActivity](15691): debug enqueueInputEvent: event = MotionEvent { action=ACTION_DOWN, actionButton=0, id[0]=0, x[0]=31.970398, y[0]=167.92523, toolType[0]=TOOL_TYPE_FINGER, buttonState=0, metaState=0, flags=0x2, edgeFlags=0x0, pointerCount=1, historySize=0, eventTime=351164558, downTime=351164558, deviceId=1, source=0x1002 },processImmediately = true,mProcessInputEventsScheduled = false, this = ViewRoot{4ba4c65 com.example.ehsfocus/com.example.ehsfocus.MainActivity,ident = 0}
V/ViewRootImpl[MainActivity](15691): debug enqueueInputEvent: event = MotionEvent { action=ACTION_UP, actionButton=0, id[0]=0, x[0]=31.970398, y[0]=167.92523, toolType[0]=TOOL_TYPE_FINGER, buttonState=0, metaState=0, flags=0x2, edgeFlags=0x0, pointerCount=1, historySize=0, eventTime=351164630, downTime=351164558, deviceId=1, source=0x1002 },processImmediately = true,mProcessInputEventsScheduled = false, this = ViewRoot{4ba4c65 com.example.ehsfocus/com.example.ehsfocus.MainActivity,ident = 0}
I/flutter (15691): enviroment
V/ViewRootImpl[MainActivity](15691): debug enqueueInputEvent: event = MotionEvent { action=ACTION_DOWN, actionButton=0, id[0]=0, x[0]=283.73727, y[0]=375.83267, toolType[0]=TOOL_TYPE_FINGER, buttonState=0, metaState=0, flags=0x2, edgeFlags=0x0, pointerCount=1, historySize=0, eventTime=351166142, downTime=351166142, deviceId=1, source=0x1002 },processImmediately = true,mProcessInputEventsScheduled = false, this = ViewRoot{4ba4c65 com.example.ehsfocus/com.example.ehsfocus.MainActivity,ident = 0}
V/ViewRootImpl[MainActivity](15691): debug enqueueInputEvent: event = MotionEvent { action=ACTION_UP, actionButton=0, id[0]=0, x[0]=283.73727, y[0]=375.83267, toolType[0]=TOOL_TYPE_FINGER, buttonState=0, metaState=0, flags=0x2, edgeFlags=0x0, pointerCount=1, historySize=0, eventTime=351166186, downTime=351166142, deviceId=1, source=0x1002 },processImmediately = true,mProcessInputEventsScheduled = false, this = ViewRoot{4ba4c65 com.example.ehsfocus/com.example.ehsfocus.MainActivity,ident = 0}
I/flutter (15691): enviroment
I/flutter (15691): a
I/flutter (15691): d

Hi @RaulBR
running the code above with the latest master the issue doesn't seem to occur

code sample
import 'package:flutter/material.dart';

/// source [https://gist.github.com/iapicca/34af401a8977828c338d61022dd1e0e7]

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) =>  MaterialApp(
    home: MyHomePage(),
  );
}

class MyHomePage extends StatefulWidget {
  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  final GlobalKey _formKey = GlobalKey<FormState>();
  static const List<int> _list = [0, 1, 2, 3];

  int _value = _list.first;

  @override
  Widget build(BuildContext context) =>
  Scaffold(
    body: Center(
      child: Form(
        key: _formKey,
        child: DropdownButtonFormField<int>(
          value: _value,
          icon: Icon(Icons.arrow_downward),
          iconSize: 24,
          elevation: 16,
          style: TextStyle(
              color: Colors.deepPurple
          ),
          onChanged: (int newValue) => setState(() => _value = newValue),
          items: [
            for (int i in _list) DropdownMenuItem(
              value: i,
              child: Text('$i'),
            )
          ],
        ),
      ),
    ),
    floatingActionButton: FloatingActionButton(
      onPressed: () => setState(() => _value = _list.first),
      child: Icon(Icons.update),
    ),
  );
}

doctor
[✓] Flutter (Channel master, 1.19.0-2.0.pre.131, on Mac OS X 10.15.4 19E287, locale en-EE)
    • Flutter version 1.19.0-2.0.pre.131 at /Users/nevercode/development/flutter_master
    • Framework revision 478d4c9c1a (6 hours ago), 2020-05-19 20:22:01 -0700
    • Engine revision 2d4e83921d
    • Dart version 2.9.0 (build 2.9.0-9.0.dev 40f7a11d89)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/nevercode/Library/Android/sdk
    • Platform android-29, build-tools 29.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.3.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.3.1, Build version 11C504
    • CocoaPods version 1.9.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 3.6)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 45.1.1
    • Dart plugin version 192.7761
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)

[✓] VS Code
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.10.2

[✓] Connected device (3 available)
    • Pixel 3a   • 965AY0WP5C • android-arm64  • Android 10 (API 29)
    • Web Server • web-server • web-javascript • Flutter Tools
    • Chrome     • chrome     • web-javascript • Google Chrome 81.0.4044.138

• No issues found!

does this code represent the issue you are describing?
Thank you

hi @iapicca  it has been fixed in master a few days ago, I just verified that unfortunately, I have other issues not related to this one
https://github.com/flutter/flutter/issues/27821

I believe this is a duplicate of https://github.com/flutter/flutter/issues/56898 which was fixed by https://github.com/flutter/flutter/pull/57037

Channel maste

You are right an update solved it!
Thank you!


problem with new animation

Unexpected page flashes when loading welcome page: login page appears for a moment before welcome page scrolls down (when first launch or back from any other pages)
Exit button can sometimes exist after (clicking exit button and) back to welcome page

Yes, this is what I expected.
I tried millions of ways to solve it resulting in failure...


Matplotlib/scipy/numpy from apt sources required for Docker builds

This allows a successful Docker build on the RPi3 (and likely a successful Docker build on other debian variants as well). Tested in the last few days and no issues found. So the "hard way" compilation is no longer required.
Updating to Golang 1.12 might be interesting here as well.

Great, that looks good!


Upgrade to 9.1 - hangs on 0% compiling

🐞 Bug report
Command (mark with an x)

[ ] new
[ ] build
[x] serve
[ ] test
[ ] e2e
[ ] generate
[ ] add
[ ] update
[ ] lint
[ ] xi18n
[ ] run
[ ] config
[ ] help
[ ] version
[ ] doc

Is this a regression?
Yes, the previous version in which this bug was not present was: 9.0.7
Description
Yesterday I was working on<EMAIL_ADDRESS>and today there was update to 9.1 which I did.

Same here, it was fine with<EMAIL_ADDRESS>and<EMAIL_ADDRESS>Note that src/__ngcc_entry_points__.json is created in application workspace, is this intended ?

Thanks for the extra info... we should not be writing that file to src directory. It should be going into the node_modules folder. So something is not right. This might not be the cause of your build hanging though.
Could you provide more information about your project setup? Ideally a repository that I can clone and use to debug the problem.

I cannot provide You my repository - it's quite big CRM system :/
I got back to angular 9.0.7 and everything is ok

Thanks for the extra info... we should not be writing that file to src directory. It should be going into the node_modules folder. So something is not right. This might not be the cause of your build hanging though.
Could you provide more information about your project setup? Ideally a repository that I can clone and use to debug the problem.

In @nrwl/nx case it is being written to /libs directory.


Setup offline usage

https://squidfunk.github.io/mkdocs-material/setup/building-for-offline-usage/

Not sure how feasible this until there is a single release since there is a limitation with the versioning plugin https://squidfunk.github.io/mkdocs-material/setup/building-for-offline-usage/#limitations


Add condition for rendering dropdown icon

Added a conditional check to render the dropdown chevron icon only when the input field is enabled. This prevents the chevron from being displayed and potentially misleading the user when the dropdown is not selectable.

Dropdowns do have the icon. It's disabled though.

This is how you do it. https://github.com/JetBrains/jewel/blob/6de2fd7d8cd3a80f99c53919ca263088c8ce71f6/core/src/main/kotlin/org/jetbrains/jewel/Link.kt#L309

this pr is not more needed, because you can achieve the same result by overriding the theme with a color transparent for a disabled state. i'm going to close this!

@fscarponi did you read my comment? Even the intention behind this change is wrong


Fix integer overflow for window ROWS frame

For window ROWS frame, if a large preceding/following value (int32/int64) is used, integer can overflow during the computation for rawFrameBounds (int32), which produces invalid frame and then wrong result.

@aditi-pandit, could you please spare some time to review this pr? Thanks!

@aditi-pandit, thanks so much for your review!
I just updated this PR.

For constant preceding, check whether integer overflow can happen, and if it can, pre-compute the start index begins overflow. If not possible, goes into the original frame bound setting (std::iota). Thus, we can avoid the overflow check for every row.
For column preceding/following, I think we have to do the check one row by one row. As it is different from constant, their implementations are still separate.
Added more test cases.

Hi @aditi-pandit, could you spare some time to review again? Thanks!

@mbasmanova, could you review this pr also? Thanks!

@aditi-pandit Aditi, thank you for helping to review this PR.
@PHILO-HE Please, ping me when Aditi's comments are addressed.

Friendly ping @aditi-pandit, could you please review again? Thanks!

Friendly ping @aditi-pandit, could you please review again? Thanks!

Apologize for the delay. I was out for a work conference last week.

Friendly ping @aditi-pandit, could you please review again? Thanks!

Apologize for the delay. I was out for a work conference last week.

@aditi-pandit, no problem. I just updated the code and posted some clarification. Could you help check again? Thanks!

I think I have fixed all comments from Aditi. @mbasmanova, could you review further? Thanks!

Hi @kagamiori, could you please review this pr? Thanks!

Hi @PHILO-HE, could you rebase this PR onto the latest main? Thanks!

Hi @PHILO-HE, could you rebase this PR onto the latest main? It's needed for committing it. Thanks!

Hi @kagamiori, just rebased. Thanks!


Update Report Generator to 4.3.2

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: anshii03 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Basic login functionality

Incl. spotify api call, backend REST call, and redirection to either overview page (routing to /overview) or to an error screen
Completes dev tasks:
#32 #33 #35 #34

please fix:
format code
pull request onto dev
delete old comments
change route dynamically


This doesn

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: a61c633b-db69-b9c1-93f1-9798f15ec242
Version Independent ID: 2a693b7e-7459-bfea-2494-ccfcfa18194d
Content: Tutorial: Query data with notebooks - Azure Databricks
Content Source: databricks/getting-started/quick-start.md
Service: azure-databricks
GitHub Login: @mssaperla
Microsoft Alias: saperla

UnityCatalogServiceException: [RequestId=ad6552fe-6620-4a33-b1b8-b129dd146060 ErrorClass=INVALID_PARAMETER_VALUE] GenerateTemporaryPathCredential uri /mnt/delta/diamonds is not a valid URI. Error message: INVALID_PARAMETER_VALUE: Missing cloud file system scheme.

@sfc-gh-phoran It's not clear what the problem is here or how it relates specifically to the documentation. Please provide more detail and context.

This is supposed to be a "hands-on tutorial".  If you follow the instructions exactly as written, you get the error I pasted into the first message. It doesn't appear to have been thoroughly tested...

Thanks for providing feedback that helps improve our documentation. We've created an internal work item (DOC-13744) to address your feedback. The timeline for resolution varies based on resourcing.
#please-close


fix CHF: thousands separator in en-US should be ,

ping @smirzaei

Hi
The currencies.json file is not based on en-US. It's not based on any specific locale to be honest. It's based on the country's locale of that currency and useful for when you don't know the user's locale.
There are quite a few issues with this approach, for example a lot of countries have multiple locales.
Anyways what you're trying to achieve can be easily done through localeFormats.json without breaking it for the existing users.
I'll add the en-US locale in a moment.
And here's how you can use it:
currencyFormatter.format(1234.56, { code: 'CHF', locale: 'en-US' });


Add Build dir to openjdk-tests repo

build/ansible/<contents from the openjdk-build/ansible dir, & tweak playbooks for test machines>
build/jenkins/<eventually contains jenkinsfiles for each platform... Jenkinsfile_x86-64_linux, etc>
Could also have a Jenkinsfile_x86-64_linux_docker file (which does not refer to specific nodes/labels so our Docker image of this test build still works).
Look at taking parameters into the groovy script and organize the stages to reuse the same Jenkinsfile to run just sanity tests for PR builds and all tests for nightlies (triggered off the successful completion of openjdk_build_x86-64_linux builds).

Build/ansible/playbooks/ubuntu_14_x86.yml has been updated to install the additional test tools required, so we are good to try and bring up additional Jenkins test agents.
Other platform playbooks still need updates.

Initial Build dir, jenkinsfiles and ansible scripts are in, will tweak scripts for each platform as we turn them on.


pythonPackages.sqlalchemy: follows upstream, use "sqlalchemy7" for lecagy

Things done:

[x] Tested via nix.useChroot.
[x] Built on platform(s): x86_64-linux.
[ ] Tested compilation of all pkgs that depend on this change.
[ ] Tested execution of binary products.
[ ] Fits CONTRIBUTING.md.

Extra
I still miss a rebuild of all the derivations that depend on sqlalchemy, which could make sense before merging that.
Feedbacks welcome to validate that it is preferable to call sqlalchemy the most up to date branch and keep legacy releases with distinct names for those who need it.

Please note, that points are not mandatory.
This makes pythonPackages.sqlalchemy the most up to date revision (it
was called sqlalchemy_1_0 before), and maintains the various “legacy”
versions available as pythonPackages.sqlalchemyX for X in {7,8,9}.
All derivations that required sqlalchemy_1_0 now require sqlalchemy
while those that required sqlalchemy now require sqlalchemy7.
The derivations are not changed, only the attribute names they are
bound to.

:+1: on latest sqlalchemy as default version.
Be careful though with the overrides.  It might be better to just not use any overrides here.

Actually, I maintained them here since they were already present. Getting rid of them could be another work. Actually, getting rid of all the non necessary legacy versions, but this requires a lot more testing to be sure not to break anything.

Update: I maintained the overrides for legacy versions (sqlalchemy7, sqlalchemy8 are defined as overrides of sqlalchemy9) which shall never be updated (only deleted). The main sqlalchemy is independant and can evolve on its own without impacting previous versions.

@FRidh I completely removed the overrides.

Let's rather merge this into python-wip so we can test it at headcounter.org/hydra/jobset/iElectric/python-wip

Is it OK if I merge myself in the python-wip branch ? (I usually avoid merging my own work)

@lancelotsix you can force push to python-wip

I don't think anyone else is using that branch at the moment.

ok, it have been rebased on top of master and pushed on the python-wip branch. I’ll check hydra within a few days.

According to https://headcounter.org/hydra/eval/311097#tabs-now-fail it seems quite fine. The 6 new failing jobs are not sqlalchemy-related (xen and acme).


Add SITL target for starting airsim

Describe problem solved by this pull request
Previously, to run Airsim with PX4 SITL both simulations need to be run separately. The steps involve multiple steps and creates confusion always when starting / closing each processes on multiple terminals.
Also, since SITL is run completely independent of Airsim, it is hard to enforce which models were supported or not. Currently only the iris model is supported.
Describe your solution
This PR sets a make target that automatically starts Airsim when it is stored somewhere as a package. The procedure is as the following.

Down the latest Linux distribution and one of the environments of Airsim: link Lets assume, we have downloaded the most simple Blocks environment
Extract the zip file
Run the following command to specify the runscript

export AIRSIM_APPLICATION_PATH=<path_to_blocks>/Blocks/Blocks.sh

Run the following target to start airsim and px4 sitl

make px4_sitl airsim_iris

Additional context
The latest Airsim release does not include the latest lockstep fixes, therefore we need to wait for a new release from the Airsim side. Expected ETA <1 week as of https://github.com/microsoft/AirSim/issues/2477

That's cool. Does this work on all platforms - and what happens if it is not supported/available?
We should add this information to:

http://dev.px4.io/master/en/simulation/airsim.html
http://dev.px4.io/master/en/setup/building_px4.html#make_targets - the viewer section
Anywhere else?

We also need to make it clear that the simulation is very heavyweight.
@Jaeyoung-Lim @julianoes We currently link to "external" instructions in http://dev.px4.io/master/en/simulation/airsim.html
Is this working for us/is it time to move these into our own instructions.

@hamishwillee I believe so, but it would be dependent on what gets released on the Airsim side.
Once Airsim has a new release and we can check that it is functional, we should move the instructions internally. I guess the instructions are external because we never wrote it down properly?

Once Airsim has a new release and we can check that it is functional, we should move the instructions internally. I guess the instructions are external because we never wrote it down properly?

The instructions are external because it was developed by microsoft and it was never clear how the work would be maintained. That kind of still isn't clear. If we're going to support this, is there any way to get some basic testing done on CI (e.g. just to check that it can be set up and build successfully?)

@bkueng

ctrl-c closes both px4 and airsim. Would it be possible to restart only px4 without affecting the simulator?
Since this is running a binary release, we don't need to configure the json file

@hamishwillee I think thats a good point. We should definitely check this in CI. I will see what we can do about this. I think just checking if upstream master works with Airsim properly will be enough

Would it be possible to restart only px4 without affecting the simulator?

That's what I'm asking you. The simulator needs to handle it. As it's a TCP connection, it knows then the px4 goes down.

Since this is running a binary release, we don't need to configure the json file

Ok, so changing to a HIL config would not be possible either?

OK, keep me posted re CI. I'll try track this and think about docs when it is done. Feel free to ping me though in case I miss it.

@Jaeyoung-Lim this is cool but I'm concerned because the airsim releases on GitHub are outdated and don't support lockstep. The Linux one is so old it crashes due to a "wrong" mavlink message. If we are to support that we also need to have builds or build instructions available, right?

@julianoes good news, AirSim 1.3.0 just released.

Looking forward airsim_px4_vision

@bys1123 Airsim can only support one airframe, which is mapped to iris. This is a limitation coming from airsim

Thanks for explains.

@julianoes good news, AirSim 1.3.0 just released.

Oh that's awesome!

This link is broken, should be https://microsoft.github.io/AirSim/px4_sitl/ now.

@Jaeyoung-Lim Are you saying we need to update our links to Airsim docs to https://microsoft.github.io/AirSim/px4_sitl/ "now"? Irrespective of other changes in this PR?

@hamishwillee https://github.com/microsoft/AirSim/pull/2507

I’m trying to run PX4 1.11 (w/ cygwin toolchain) + AirSim 1.3.0 on windows
I got this waring:

pxh> WARN [commander] Takeoff denied! Please disarm and retry
WARN [PreFlightCheck] Preflight Fail: Compass Sensor #0 missing
WARN [PreFlightCheck] Primary compass not found
WARN [PreFlightCheck] Preflight Fail: Accel Sensor #0 missing
WARN [PreFlightCheck] Primary accelerometer not found
WARN [PreFlightCheck] Preflight Fail: Gyro Sensor #0 missing
WARN [PreFlightCheck] Primary gyro not found
WARN [PreFlightCheck] Preflight Fail: Baro Sensor #0 missing

my settings.json:
{
   "SettingsVersion": 1.2,
   "SimMode": "Multirotor",
   "Vehicles": {
       "PX4": {
           "VehicleType": "PX4Multirotor",
           "UseSerial": false,
           "UseTcp": true,
           "TcpPort": 4560,
           "ControlPort": 14580,
           "params": {
               "NAV_RCL_ACT": 0,
               "NAV_DLL_ACT": 0,
               "LPE_LAT": 47.641468,
               "LPE_LON": -122.140165,
               "COM_OBL_ACT": 1
           }
       }
   }
}

@bys1123 I believe that the issue is caused by https://github.com/PX4/sitl_gazebo/pull/411
The multirate sensor publishing should be added to the Airisim side

Closing as stale


v5 with ODPI ?

Hi @rana,
I've been experimenting with ODPI-C (github.com/oracle/odpi), a new wrapper around OCI by cx_Oracle's author, Anthony Tuininga (@atuininga).
I've implemented all what Go 1.9 requires, and with those additions maybe the standard library's functionality is enough, no specifics needed!
Should I release this code (under the "dpi" branch ATM) here as ora.v5, or somewhere else?
Thanks,
Tamás Gulácsi

I would recommend creating another independent project, to avoid confusion. The effort to make an interface for oci-odpi-go is valuable and promising.
But the ORA driver is also valuable, unless you plan to abandon this effort.
for you consideration.

Thanks, agreed.
I don't plan to abandon the ora driver yet, as I'm using it in production.
Tge migration from it will be a years length effort - I'll have to stabilize the new driver, and rewrite tgulacsi/oracall to use it.
So I'll maintain it, as I can (it's quite a mess, esp. the documentation).

@jmptrader is there anything in particular that is valuable in ORA that could be in /dpi?

Ok, I've resurrected go-goracle/goracle, and the new driver based on odpi has borned:
https://gopkg.in/goracle.v2

@cjbj For be fair, ODPI is comparable with OCILIB ( https://github.com/vrogier/ocilib )
Both are wrapper for oci in programming language C.
ORA is an effort in golang world for get native driver for Oracle Database, i.e. an wrapper for oci in programming language Go.  go<-->[ora+cgo]<--->oci<--->db;
ORA have one interface native that potentially can access all the power oci.h exploiting features of the Oracle Database.
An big promise de ORA is/was that support two operations types:  native and database/sql.
At end of day, I think, that is better have an package for database/sql complaint and other specific database in parallel at level of the interface programming.
Theorical example,
"gopkg.in/rana/ora/sql"        (compliant with  Database/sql)
"gopkg.in/rana/ora/native"  (specific features, not compromise with Database/sql)
Now,
a) the package Database/sql interface is good practice for making transportable code between several databases (with few changes to dml / ddl).
b) if I need specific features beyond the basics ( advanced queues, native data types, external credentials, array parameters, connection/session pooling, RAC connections, etc),  I would use an specialized package.
---- x ----
Considering that at point a) @tgulacsi is working, maybe your team can help the community at point b.
---- x ----
JM

@jmptrader why do you think the separation is good?  Would that make it harder for people to migrate from the 'basic' Database/sql interface to the advanced one?


Partially fix #819

For contravariant INotification.
For IRequest and IStreamRequest i would like to get some help

I'll try with requests and streamrequests tomorrow to do all of that in one go

Waiting for review

Can you write some tests? I'm not sure what cases this is fixing.

Yes, I'll do, however I'll be able to next week

I'll reopen PR


Production Cluster

As a developer, I need my deployment of Jackson to be updated everytime I make a change to my Jackson HLD.
AC: setup a production ready project jackson cluster on jack5on.io and document the process taken.

Related: #225 , #207

Related: https://github.com/Microsoft/bedrock/issues/242


Observatory crashes on application with FFI

Steps to reproduce:

Load any library var lib = DynamicLibrary.open('...');
Lookup any function  lib .lookupFunction<..., ...>('...');
Run application with observatory
dart --observe=22222  --pause-isolates-on-exit --pause-isolates-on-unhandled-exceptions app.dart
Open observatory and click cpu profile
Application crashes:

Observatory listening on http://<IP_ADDRESS>:22222/3Wyn9c4cC1o=/
c:\b\s\w\ir\cache\builder\sdk\runtime\vm\object.cc: 6184: error: unreachable code
version=2.3.0-dev.0.3 (Tue Apr 23 12:02:59 2019 -0700) on "windows_x64"
thread=12396, isolate=main(000002688E8261A0)
  pc 0x00007ff6bc1a7a8c fp 0x000000c861cfc080 Dart_IsPrecompiledRuntime
-- End of DumpStackTrace

I imagine I ran into a similar problem.
When debugging via VS Code plugin,
dart_hello_def = mylib.lookup<NativeFunction<rust_hello_def>>("goodbye_dart").asFunction();  throws the exact same error

c:\b\s\w\ir\cache\builder\sdk\runtime\vm\object.cc: 6184: error: unreachable code

However, running from the command-line dart bin/main.dart yields the expected result.
Running Windows 10, dart-sdk 2.3.1

Could you take a look @dcharkes ?


Request money fails when requesting from unknown user after sign out and sign back in

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:
Break down in numbered steps

Create a chat with someone you haven never chatted before (UserB)
Log out and a log back in as (UserA)
Request money from the userB

Expected Result:
Describe what you think should've happened
It works
Actual Result:
Describe what actually happened
It fails with 404 payerAccountID and policyID not found because the payer email is sent in place of a debtor email
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: me
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01a0df7ee356c8a435
Upwork Job ID:<PHONE_NUMBER>551967744
Last Price Increase: 2023-07-11

no update yet

focusing on other bugs.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Request Money fails after creating a new chat with a new user and doing logout + login
What is the root cause of that problem?
When it is a new user the server responds with a personalDetailsList that only includes displayName:
e.g.
{
  "accountID": 15077730,
  "avatar": "https://d2k5nsl2zxldvw.cloudfront.net/images/avatars/default-avatar_7.png",
  "displayName"<EMAIL_ADDRESS>}

Then in the method requestMoney payerEmail is built with participant.login which is undefined in this case:
https://github.com/Expensify/App/blob/272d921d4fbd3f6bf98e6b124c8cc53eefdafc3b/src/libs/actions/IOU.js#L307-L308
This ends up in a request without debtorEmail which causes the failure.
What changes do you think we should make in order to solve the problem?
There are 2 ways of solving this:

Return the login attribute directly from the backend
As a fallback generate the login in the participant using the displayName. Participants are created using

https://github.com/Expensify/App/blob/272d921d4fbd3f6bf98e6b124c8cc53eefdafc3b/src/libs/OptionsListUtils.js#L220-L226
We could use something like this on line 224. Still, this is just a workaround for solution 1.
const login = detail.login || participant.login || detail.displayName;

What alternative solutions did you explore? (Optional)
Just trying to "generate" the login until found the right place based on personalDetails list

Thanks Daniel, i think this makes sense but its not clear to me if the logins can be returned. I believe that is the new design now for privacy concern and we only deliver the accountIDs if the users are not knows
The displayName is also not safe is it? If the debtor sets their display name, then there will be no email returned for such user from the backend will it? (Until the users are "known")

This is waiting for discussion with Alex and Puneet about how to handle these cases

You are right @mountiny  definitely a  user with a display name makes the "workaround" fail. This is a structural issue that needs to be solved via backend or via a unified ID with optimistic and server response in the personalDetailsList object in onyx.


Add market depleted filter to getMarkets getter

from Joey in Discord:
That sort should show markets that don't appear in the current hourly liquidity ranking but did in the average one
// rerun this hourly
// will need to store in local storage or w/e
if(time.now() - last_updated >= 1 hr ago):
hourly_rankings[current hour day year] = do_liquidity_calcs()
last_updated = time.now()
ranking = sum(hourly_rankings.trailing24hr.only_nonempty) / len(hourly_rankings.trailing24hr.only_nonempty)
https://gist.github.com/joeykrug/f61596d7b51cf66252c01b599bc3f0f6
Gist
Liquidity ranking
Liquidity ranking. GitHub Gist: instantly share code, notes, and snippets.
from ^
so take ranking above and hourly_rankings[current hour day year], remove any duplicates in ranking by removing ones that are also in hourly_ranking Whatever is remaining in the ranking list is therefore markets that were liquid > 1 hr ago but aren't now, and thus need liquidity replenished and should appear under the "needs liquidity" filter
no timestamp imo, it's just a filter
cc @achapman if any algorithms questions

@joeykrug we need a little clarity on this feature. @adrake33
Is what is proposed a filter in the UI where there's an option in the liquidity spread filter, and only markets that have had liquidity recently depleted? like within the last hour, day, week?
add new recently depleted option here


Feature request: Support absolute path import with "baseUrl" setting

Firstly thank you very much for this extension, I have searched for days to find one to help me import css/scss file with suggestions in React code, finally found this one.
I have a feature request is that currently this extension only supported absolute path import to the workspace (starting with /), can you add support for absolute path import base on "baseUrl" setting in jsconfig.json/tsconfig.json ?
Thank you very much.

Hi @midoriki ,
have you tried to configure the pathMappings ?
"path-autocomplete.pathMappings": {
    "/test": "${folder}/src/Actions/test", // alias for /test
    "/": "${folder}/src", // the absolute root folder is now /src,
    "$root": ${folder}/src // the relative root folder is now /src
    // or multiple folders for one mapping
    "$root": ["${folder}/p1/src", "${folder}/p2/src"] // the root is now relative to both p1/src and p2/src
}

https://github.com/ionutvmi/path-autocomplete#options

Hi @ionutvmi,
Thank you for your suggestions, it worked really well.
FYI, for anyone run into this problem like me:
I'm working on 2 projects: the first is a next.js project where source files are in the project's root directory, and the other is a CRA project where source files are in src directory. You can set it up like this and you can use absolute path import file that isn't JS/TS in both projects.
"path-autocomplete.pathMappings": {
    "$root": ["${folder}", "${folder}/src"]
}

glad it helped


AmbientCapabilities in unbound.service.in and futher hardenings

Main change is an intro of AmbientCapabilities, which allow to bind to privileged ports (1-1024) without super-user privileges, thus it's possible to further harden the process.
I'm testing other hardening options, probably will contribute soon.

The service still starts as root so this change may only decrease security in current state. SystemCallFilter and CapabilityBoundingSet changes should be explained somewhere.

The service still starts as root so I don't see actual hardening effect of this change. SystemCallFilter and CapabilityBoundingSet changes should be explained somewhere.

Ok, let me refine the changes and I'll open another pull request.

Note that starting the service as non-root isn't an option either because it would break existing setups. I think those changes belong to downstream where you control specific execution environment.

Ерфтл

There is alternative portable service which may be better target for running unprivileged.

Thanks! I'll try to play around with it and yeap, running unbound as unprivileged service is a headache


Cosmos DB Connections should have icons

Discussed offline. Filing an issue so we don't forget

You should probably just use the same two icons as in the Cosmos DB extension:

Fixed by PR #654


Manga Demon

Source information
Manga Demon
Source language
English
Source new URL
https://manga demon.org
Other details
Fix extension old domain BUT webview new domain

Acknowledgements

[X] I have updated all installed extensions.
[X] I have opened WebView and checked that the source URL has not changed yet.
[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I will fill out all of the requested information in this form.

Duplicate of #4770
Search the existing issues first before opening a new one, and acknowledging that you did when you clearly didn't.
Also that's not the right URL, even compared to your own screenshot of the redirected page in WebView

Duplicate of #4770
Search the existing issues first before opening a new one, and acknowledging that you did when you clearly didn't.
Also that's not the right URL, even compared to your own screenshot of the redirected page in WebView

Then fix it rather than you yapping

Damn, moody one aren't you.
There's already a proposed fix from another contributor, it's pending review & merge to the repo. Contributors are all volunteering their free time to provide fixes/new extensions. I've contributed a few quick fixes to give back to the community/repo, don't whine if you don't understand.

Then fix it rather than you yapping

Let me refund you the 0 dollars you paid us


Allow {Key, proplists:proplist()} entries to be converted

Changed embedded proplists (not just lists of proplists) to be passed through from_proplist/1 as well.
Currently from_proplist/1 doesn't handle nested values that might also happen to be proplists. Similar in nature to "lists of proplists", the goal is to make the following 3 things equivalent (basically):
% proplists:proplist()
[
  {foo, [
    {bar, 1},
    {baz, 2}
  ]}
]).

% props:props()
{[
  {<<"foo">>, {[
    {<<"bar">>, 1},
    {<<"baz">>, 2}
  ]}}
]}.

{
  "foo": {
    "bar": 1,
    "baz": 2
  }
}

Thanks!

Sure thing! Thanks for merging it. :)


how do i build this?

electron electron-starter
fails on windows 7
app provided is not a vallid electron app.

help?


How can I navigate in unity using ros#?

[ ] I am at the right place and my issue is directly related to ROS#. General technical questions I would post e.g. at ROS Answers or Stack Overflow. For library-specific questions I would look for help in the corresponding library forums.
[ ] I have thoroughly read the Contributing Guideline and writing this issue is the right thing to do in my case.

I have a question!

[ ] I searched the Wiki, open and closed issues for an answer. I tried my best to find the answer by myself without success. I believe that the discussion we will have in this issue, and the solutions we might find, will help me, and likely other community members who have a similar problem.

Here is my question:

I found a bug!

[ ] I am using the latest ROS# version available here on the master branch.

[ ] I am adding all required information, code and data files, screenshots and log files so that you can reproduce the problem.

My OS is:

My Unity Version is:

My ROS Distribution is:

My Build Target Platform is:

Here is my bug description:

Perform the following steps reproduce the bug:

Observed results:

Expected results:

Relevant Code:
<!-- Insert code here. Optionally attach code or data files to this issue. -->

I have a feature request!
I want to do this:

For being able to do it, I wish ROS# had the following feature:

I can get the map by move the robot,but what should i do to navigate in unity?

Hi @837910164 !
congratulations! This is the point where your implementation work begins.
You can now use ROS# to communicate from Unity to ROS how you want to navigate your robot.
You can e.g. use MoveIt Motion Planning API to tell your robot to navigate via topics and actions (i.e. MoveGroup Action.
Concerning the ROS-Unity communication interface ROS# everything works as for receiving the map: just communicate other topics now. For further help concerning navigation please refer to the respective projects.


Use shorter dev names on older LXD releases

@tomponline the detection works but the storage-disks-vm test fails just a bit later:
+ echo '::warning::5.21/edge detected, using a shorter name'
Warning: 5.21/edge detected, using a shorter name
+ LONG_DEVICE_NAME=notSoLongName
+ lxc init ubuntu-minimal-daily:24.04 v2 --vm
Creating v2
+ lxc config device add v2 notSoLongName disk source=/opt/lxd-test-restricted/allowed1 path=/mnt/bar1
Device notSoLongName added to v2
+ lxc start v2
+ waitInstanceReady v2
+ set +x
+ lxc exec v2 -- mountpoint /mnt/bar1
/mnt/bar1 is a mountpoint
+ lxc config device remove v2 notSoLongName
Error: Failed to stop device "notSoLongName": Failed to detach path device after 10s: Chardev 'lxd_notSoLongName' is busy
+ cleanup
Test failed

Should I convert the hot-unplug by a cold unplug when working around?

@tomponline I ended up disabling all the disk hot plug/unplug part of the storage test which I think is OK for a temporary workaround.
It's currently as green as it gets considering the ZFS vol activation regression that should be addressed by https://github.com/canonical/lxd/pull/13662. There's also the ZFS rounding issue that's still not completely backported all the way down to 5.0/edge.

I ended up disabling all the disk hot plug/unplug part of the storage test which I think is OK for a temporary workaround.

Can we keep hotplug tests? I don't think we will ever back port the fix to 5.0

There's also the ZFS rounding issue that's still not completely backported all the way down to 5.0/edge.

It should be now since https://github.com/canonical/lxd/pull/13659

I ended up disabling all the disk hot plug/unplug part of the storage test which I think is OK for a temporary workaround.

Can we keep hotplug part of tests? Just not hot unplug, i don't think we will ever back port the fix to 5.0

Sure, done.


Cannot load graph inside a modal

Describe the bug
We have a graph component names as fundal height & was trying to load another graph content named print view from the print button in a modal.
As you can see in the video below, I already have a graph on my main div & on click of a Print button, a modal opens up but the graph doesn't load inside it. When I try to close the modal, the component updates & get the print graph content on the main div.
The expected behavior can be seen in the second part of the video where I have navigated to my table layout & then click on the print button which gives me the perfect orientation of the graph.
Link to the issue video:
https://cernerprod.sharepoint.com/sites/Terra/Shared Documents/Carbon Graphs/carbon-issue.mov
Link to CodeSandbox
Link to the fundal height main project: https://github.cerner.com/aeon-womenshealth/fundal-height-js/tree/BLRWH-8471
Link to the pregnancy base graph (Custom Wrapper to carbon): https://github.cerner.com/aeon-womenshealth/pregnancy-base-graph-js/tree/destroy-test
Link to the places where graph component is called:
Main Screen: https://github.cerner.com/aeon-womenshealth/fundal-height-js/blob/b9903f7a2196d4dfc85737fe488e0f264892957e/src/fundal-height/components/FundalHeightView.jsx#L260
Print Modal: https://github.cerner.com/aeon-womenshealth/fundal-height-js/blob/b9903f7a2196d4dfc85737fe488e0f264892957e/src/fundal-height/components/FundalHeightPrintView.jsx#L45
Expected behavior
The graph should load inside the modal & not attach to the background div
Things tried till now
I have tried to dynamically pass graph Id & load graph in two different graph Ids but its throws me this error: TypeError: can't access property "style", t is null
I have tried to add a destroy function on componentWillUnmount() to destroy the main screen graph instance & hopefully load the new graph inside a modal but it did not work.

I am able to load the graph in two different divs by passing graphId
const [graphValue] = graphValues;
graphValue.bindTo = '#print';
I couldn't change the graphId somehow in my helpers js file but changed it at the last consuming layer of our project.


just for debugging - do not merge

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Issue resolved


could you upload Walker2d-v2 and Humanoid-v2 PPO pretrained model?

thanks!

@jiameij with regards to your second question that's most likely due to offline Visdom server. See the training section of the readme.

@inoryy thank you!

@jiameij yes, it's because of visdom. I'm a little bit busy this and next week. I will try to upload the models in the end of the next week.

@ikostrikov ok, thank you for your share!


Are we able to customize the dashboard UI?

Are we able to customize the dashboard UI to add some chart SVG's, controls, etc?
(Searched everywhere for this simple question although I can't find an answer to such a simple question. Forgive me for my ignorance)

@pfftdammitchris Can you give an example (screenshot, link, etc.)? What do you actually want the charts and controls to show or do?

@tech4him1 for example if we are able to customize the dashboard to have widgets like everything on this page:
http://wrapbootstrap.com/preview/WB0573SK0
Are we only limited to working with the default dashboard, or the default UI?
How would we change the sorting of items in each collection by date, and also list the date on each item? Currently only the title is shown on each item. In the screenshot below the blue dates would be an example of customizing the UI:

Yeah it's not that kind of admin interface, it's purpose built for Netlify CMS collection display.
That said, you should be able to swap in your own components to replace interfaces like this one, we're just not there yet.

It would be nice to add the ability to output any field from the collection. I have a list of news and I would like to see which of them are displayed on the main.

I think this turned out to be a duplicate of #2019.
I get that there are many customizations besides the EntryCard, but it's by far the most requested one. (besides some filtering and ordering of the list).
I do have some code done, with examples below, but I'm too short on time right now to contribute it back. If anyone is interested, please don't hesitate to copy (: and contribute it upstream here.

the language is pt-BR, but I guess you can figure it out.the article can link to a editorial (the colored tag on top) and many

||
|
|
|:--:|:--:|:--:|
|articles|editorials|authors|

@leonardodino Amazing stuff ! Just what I was looking for ! I can't wait to see it on live 💃

@leonardodino agreed, this became about entry card customization. The original issue is about dashboard customization, eg. creating an actual data driven dashboard, but Netlify CMS doesn't have a dashboard at all, so I'm thinking this should be closed. Would you mind porting your last comment to #2019 so we can close this?

done! @erquhart

Can we have a pull request on this? I think this update helps a lot...

@calpa See https://github.com/netlify/netlify-cms/issues/1498#issuecomment-465302384.

@leonardodino Where is this registerEntryCard method registered? I tried using it, but I'm getting a WEBPACK_IMPORTED_MODULE error that it's not a function. I then thought you had added it custom to the campus-online codebase, but I can't find it anywhere there either. What am I missing? :(

@adamtaylor13, registerEntryCard only exists in my fork.
Unfortunately I haven't had the time to make a PR upstream. 😕
You probably didn't find it because github search doesn't work on forks.
(unless they have more stars than the upstream repo)
you can find it on the master branch in the following files:

netlify-cms-core/src/components/Collection/Entries/EntryListing.js
netlify-cms-core/src/components/Collection/Entries/EntryListing.js

or: just follow the diff/patch in the PR.
It also includes some basic docs that will help on getting your PR merged.

You, and anyone interested in contributing this code to the upstream netlify-cms have my permission and rights to use the code, no attribution needed (:

I'd also like to request ability for a solarized mode of the CMS UI.
UseCase: The stark white computer screen hurts my eyes while composing blogs. It'd be great to have solarized light and solarized dark theme.

@numoonchld https://github.com/netlify/netlify-cms/issues/1727


[mrview] fix http test

COUCHDB-2824
Now all couch_mrview eunit tests should pass:
$ export BUILDDIR=`pwd` && rebar -r eunit apps=couch_mrview
...
=======================================================
  All 104 tests passed.
==> rel (eunit)
==> couchdb (eunit)

Friday was a bit rushy (: LGFM, but could you please make a better commit message? There is no need to tag it with mrview as it belongs to mrview repository and only.
P.S. Travis fails with a good reason, but not related to your changes. I'll handle that once I get back home.

Thanks!


Add repository.json

If you add a repository.json, it is very easy to install this addon for users. Then users only have to add a repository URL to their Home Assistant installation and can easily install and update the addon.
Developers guide can be found here:
https://developers.home-assistant.io/docs/add-ons/repository/

Thanks. Will look into it. Got loads on my plate now thanks to you 😄

I hope it is okay if I keep on reporting bugs and submitting feature requests. I don't want to be unkind and make demands, but I want to help to improve / extend the software.

Please do keep them coming. I'm also trying to extend the software. As much as an amateur that I am, not everybody can produce the crappy code I "designed" 😜
Hopefully it gets better and more people can use it

Then thank you very much for your work. I really appreciate it!

also I want to say thank you very much!  we really appreciate your work.

Added in upcoming 0.1.7

tryed to install this way, got an error
20-07-06 14:31:15 INFO (SyncWorker_13) [supervisor.docker.interface] Pull image lolouk44/xiaomi-mi-scale tag 0.1.7. 20-07-06 14:31:16 ERROR (SyncWorker_13) [supervisor.docker.interface] Can't install lolouk44/xiaomi-mi-scale:0.1.7 -> 404 Client Error: Not Found ("manifest for lolouk44/xiaomi-mi-scale:0.1.7 not found").
i think no tag 0.1.7 in docker hub, i see only 0.1.6 and latest tags

lol that's why I said "upcoming" :D
I'm still building the docker image...
Once done I'll update the release on the repo

oh I so much prefer bat timing than bad timing 🤣

Try now it should work


Remove IScopedInstance - use AsyncLocal for ActionContext and

ActionBindingContext
This change replaces IScopedInstance in favor or IActionContextAccessor
and IActionBindingContextAccessor. In the spirit of IHttpContextAccessor,
these are both singletons which use AsyncLocal for storage.
This change allows the invoker factory to be cached which results in some
significant perf gains.

/cc @davidfowl

In both of these data, 100% is set to the time spent inside of Routing + MVC. All percentages are relative to that.
Before

Notice here the 10% of time spent just creating the logger. Also 5% doing the service resolve for the invoker factory/providers.
After

I super duper don't understand this, but I like the perf gain :smile:
@davidfowl please review.

I super duper don't understand this, but I like the perf gain :smile:

TLDR: scoped is viral. Lots of stuff we MUST use every request touches scoped stuff. If we do it less we'll have more ability to cache things we use every request, and to do further optimizations

Thanks. In principle the code looks :shipit: to me - it seems like a fairly straightforward, if viral, change.

This would depend on net46 being part of mono which is currently blocked due as the reference source was not updated on github.

This would depend on net46 being part of mono which is currently blocked due as the reference source was not updated on github.

The code that's actually using AsyncLocal<T> is if-defed for coreclr. We'd consider adding an if-def and build target for 4.6 if more of these things pile up.

@rynowak why's you close this?

why's you close this?


Inadequate introductory paragraph on k8s.io/docs/reference/access-authn-authz/webhook/

This is a Bug Report

Problem:
The introductory paragraph of https://kubernetes.io/docs/reference/access-authn-authz/webhook/ does not say what the page is about --- which is using a webhook for authorization.  The introductory paragraph just defines the generic idea of a webhook.  A reader reading that gets no idea of the relevance of that page.
Proposed Solution:
Make the page start out by saying that the page is about using a webhook to do authorization.
Page to Update:
https://kubernetes.io/docs/reference/access-authn-authz/webhook/

A very good idea!
/priority backlog

/language en


Add docs on API stability and deprecation table

Adding these in preparation for GA. I'm not sure if we have features we're in the process of deprecating, but I can add them in if we do!
These follow the policy described here.
Ref https://github.com/sigstore/sigstore-website/issues/119

I think you can be a bit more generous! Most of the key based stuff is GA today. I think it's documented in the readme.

Thanks @dlorenc ! Added in those details :)


Set up GitHub Pages

The baseurl in the config will likely need to be changed and tested, etc., once we have the domain.

Seems to be working OK, closing.


Poor dark mode drawing performance in Firefox - 116.0.2 on Ubuntu/Linux

I am experiencing very poor performance using dark mode under Firefox
Dark mode : ~5-10 fps drawing changes,
Light mode : Snappy performance, ~60fps, did not measure, but feels great.
Firefox Context:
Version : 116.0.2 (64-bit)
Mozilla Firefox Snap for Ubuntu.
Running atop Ubuntu 22.04.
If there are any metrics or logs i can collect to help debug / develop,
i am more than happy to assist.
Tested in Chrome on the same machine both Dark and Light mode performance is superb.
Also Mentioned in this issue.
https://github.com/excalidraw/excalidraw/issues/6876#issue-1848508928

i have the same problem!

Same issue, works great on Chrome but not firefox in dark mode.
OS
Distributor ID: Neon
Description:    KDE neon 5.27
Release:        22.04
Codename:       jammy

Firefox
122.0 (64-bit)

I'm also having this problem, KDE neon 6.0, Firefox 127.0.2 (64-bit). I'm also having it in light mode, but it seems a little worse in dark mode. Performance is fine in Chromium on the same computer and Firefox on my iPhone (so webkit-based browser).

Throwing my report in the ring:
Firefox 127.0.2 (64-bit)
Arch Linux x86_64
xfce4
Kernel: 6.9.7
Light mode, perfectly fine
Dark mode, poor performance
I didn't find any errors in the console or network traffic. I am unfamiliar with Memory Snapshots or performing profiling.

This also occurs on Windows 11.

Same issue :(
Firefox: 131.0.3 (64-bit)


User/sachinta/fix deployment manager telemetry (#2802)

Fix DeploymentManager Initialize Activity's incorrect event name

Fix DeploymentManager Initialize Activity lifetime

Co-authored-by: Santosh Chintalapati<EMAIL_ADDRESS>

/azp run


WHAT a USELESS WebSite !

I cannot BELIEVE how USELESS this whole arrangement is !!!
I have Excel.
I have a need for an explanation of e.g. the use of a particular function.
I click on "Help" and get sent to this USELESS WebSite !
e.g. here:-
https://docs.microsoft.com/en-us/office/vba/api/overview/excel
I am told that
"This reference contains conceptual overviews, programming tasks, samples, and references to help you develop Excel solutions."
and it shows "Concepts", "How to" and "Reference" - but taht is all !  No Links, NOTHING.  And not even a HINT as to how to access these !
1/10 - not even trying.
Bottom of the class.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1346c144-90c6-3c01-b2f7-555910efc581
Version Independent ID: 101b99a2-ed7c-879f-36ca-2b9c439f6afe
Content: Excel VBA reference
Content Source: api/overview/Excel.md
Product: vba
GitHub Login: @o365devx
Microsoft Alias: o365devx

Hi Robin, we're sorry that you're having a bad experience with the user interface of our site. Have you tried clicking through the table of contents (TOC) in the left navigation pane? You can also add a keyword in the "Filter by title" box at the top of the TOC to help you find what you're looking for. Hope this helps.


Enable integration tests of gadgets

This PR enables the file that tests all custom gates in a single circuit. It adds a flag to the sub/add functions to allow the user to concatenate rows of ForeignFieldAdd's or include the final Zero row as well including the result.
Merge after https://github.com/MinaProtocol/mina/pull/13664/ does
Checklist:

[ ] Dependency versions are unchanged

Notify Velocity team if dependencies must change in CI

[ ] Modified the current draft of release notes with details on what is completed or incomplete within this project
[ ] Document code purpose, how to use it

Mention expected invariants, implicit constraints

[ ] Tests were added for the new behavior

Document test purpose, significance of failures
Test names should reflect their purpose

[ ] All tests pass (CI will check this if you didn't)
[ ] Serialized types are in stable-versioned modules
[ ] Does this close issues? List them

Closes #0000

Closing because custom gates will be done in o1js directly


Add Data-testid attributes to support agent config e2e tests

Needed for https://github.com/rancher/dashboard/pull/9247

I've rebased off recent other work and added some comments explaining changes other than the data-testid attributes. I made some tweaks to the payload sent to better align with the rke2 side of things because I thought it'd be nicer UX if the two forms that look the same behaved exactly the same under the hood. I can revert these changes (and add a second set of payload comparison data on the dashboard side) if you think it's messy to include as part of testing PRs


#SWARM-365 Enable module loading for Keycloak 1.9.1

Change modules layers prefix to system prefix and cut layer in module resolver methods.

merged


Lpeglabel15

Merge this branch into master

Codecov Report

Merging #141 into master will decrease coverage by 0.25%.
The diff coverage is 100%.

Impacted Files
Coverage Δ

titan-compiler/lexer.lua
98.38% <100%> (+0.02%)
:arrow_up:

titan-compiler/syntax_errors.lua
100% <100%> (ø)
:arrow_up:

titan-compiler/parser.lua
95.61% <100%> (-0.12%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dddd13...e6497d4. Read the comment docs.


Add installer support for Genuitec Angular IDE

It seems that the Lombok installer won't recognize Angular IDE (the default vanilla install downloaded from Genuitec's website -- I tried on Windows 10), I'm guessing because it has its own executable name in Windows (angularide.exe).  Also by default it gets installed under the user's AppData folder rather than the standard Windows program files location, so that may be another hitch to get it auto-detected by the lombok installer.  Having this supported out of the box would be a nice feature.

Thanks for the suggestion.


Line stats missing from JSON coverage report

Expected Behavior
[path].l should exist in the JSON coverage report, similar to "s", "f", "b".
Observed Behavior
[path].l is missing from the JSON coverage report.
Forensic Information
Operating System: Ubuntu 16.04
Environment Information

Node v6.9.1
npm v3.10.8
nyc v9.0.1
babel-plugin-istanbul v3.0.0

@gotwarlost I feel like there was another thread related to this elsewhere; is this expected behavior?

Same issue here.
node: v6.0.0
npm: 3.8.6
nyc: 10.0.0
OS: MacX

Just wandering if a PR will be accepted with this change?
Happy to have a stab at this!

@renegare I would happily accept a patch 😄 would love to bring some more folks up to speed on this project.
@frostiebot sorry for dropping this on the floor for so long; thank you for the initial reproduction.
@renegare if you want to coordinate with me in slack, this can be a good way to make sure we move forward -- sometimes I get a bit buried in issues.

Hi,
I have the same issue, is it planned to fix it?
Best regards,

Is this still an issue with the current version of nyc?  If so can someone please post a repository with a minimal reproduction?


Distribution of Encryption in Framework

The logic for en- and decryption is distributed in several classes in DECODE_KEY and ENCRYPT_KEY macros (e. g. ZCL_ADF_SERVICE, ZCL_ADF_SERVICE_BLOB, ZCL_ADF_SERVICE_EVENTHUB, ZCL_SSF_UTILITY).
As this logic is an essential ingredient it should be centralized in one class for the sake of maintainability. I think the class ZCL_SSF_UTILITY had the original intention to do so but seems to be unfinished.

Hello Christian @lechnerc77 @Microsoft/abapsdk   ,
Thank you for the valuable feedback.
we are in the process of extending the class ZCL_SSF_UTILITY as it was initially designed to encrypt all kinds of keys and method to decrypt the same in our current landscape. This class is no longer used in SDK as currently we are encrypting keys automatically from the maintenance screen of table ZADF_CONFIG using logic embedded with table events.
we will keep you posted on the extended class once it is completed and reused in the service classes( e.g ZCL_ADF_SERVICE_EVENTHUB) of SDK.
Thanks,
Krishna

I also just stumbled upon the macros, looking at the code I guess the macros were added for security reasons, as macros cannot be debugged, while this is true, I think the specific implementation is debuggable,
For something like
https://github.com/microsoft/ABAP-SDK-for-Azure/blob/73de27af27cadeed927e9193b5cb0b8598f532b7/src/zadf/zcl_adf_service_blob.clas.abap#L120 a user debugging can set a break point inside function module SSFC_BASE64_DECODE to get lv_decoded_xstr, so I agree with @lechnerc77 above, this should be optimized for maintainability instead

Hi @lechnerc77
We upgraded our repo with latest version and ZCL_ADF_SERVICE is used as base class and other ZCL_ADF* classed are extending its methods. Please let us know if you need more information.
Regards,
Vikas


STORM-2805: Clean up confs in TopologyBuilders

@srdo I think I have addressed all of your comments.  I also found a few places were an NPE could happen, and one where the TopologyBuilder was not setting the resource configs correctly.  I fixed it and the corresponding test failures.

@srdo I have fixed the issues you called out
@Ethanlm I fixed the issue you saw.

Thanks, +1

@srdo thanks for the review you found a lot of bugs and made this a lot better.

Thanks, happy to help :)


Basic view for selecting a subtitle to edit

Resolves #582
Adds a new main menu option "Subtitles" and a view where you can select a subtitle to edit or add based on a predefined list.
TODOs:

Any sort of actual functionality
Configuration
More equal spacing of buttons when wrapping over multiple rows
Exception handling for non-country codes

A few initial thoughts:

Not sure if it's just me, I think it's a bit confusing to use a Closed Captions icon but then use the term subtitles for the button description
I probably do not care about the segment count on the overview page and would not put it there
Maybe use some CSS like text-overflow: ellipsis;  overflow: hidden; for very long titles?

* Not sure if it's just me, I think it's a bit confusing to use a Closed Captions icon but then use the term subtitles for the button description

Maybe we should ask a couple more people opinions. Otherwise, this is the most accurate free fontawesome icon I found .D

* I probably do not care about the segment count on the overview page and would not put it there

The idea here was to give the user a sense of how finished each of the subtitles are, without them needing to click on each one to check. I don't mind dropping this either way, it was just an idea.

* Maybe use some CSS like `text-overflow: ellipsis;  overflow: hidden;` for very long titles?

Seems like the easiest solution, given that we don't expect many long titles anyway.

Closing in favor of https://github.com/opencast/opencast-editor/pull/638, where this PR is included in.


Sending out email about career mentorship to grads and ITP trainees

The only steps we previously took towards announcing career mentorship opportunity was slack posts
now that we have several mentors available I'm going to send an official email to everyone eligible to get them all an equal chance of getting their mentors
This is the email I'm going to send:
https://docs.google.com/document/d/1vsmTTZXaIjtbdQwXFhkHqsI_lkDBLnFbSpThC8Og3Ow/edit?tab=t.0

I have sent out emails to all eligible grads and trainees on this list:
https://docs.google.com/spreadsheets/d/1LfQWzC5f-7Mezst7V-laLLZLyhnMb1GvpDYkadCSSw4/edit?gid=0#gid=0


Broken link of LICENSE fixed in README

Fixed the broken link of LICENSE in README.
This PR fixes #140

@Kaushik080
I hadn't realized the link was incorrect. Thank you for finding and fixing it!


Standard logrus logger logs to stdout

This breaks the drop-in replacement with the stdlib logger as that uses stderr by default https://golang.org/src/log/log.go?s=8113:8157#L58

This is a good observation. I'm afraid of breaking this for too many people currently, but we may do this for a 1.0.

Done


[ADLA - ADLS] - [BUGFIX] - Fixing x-ms-odata parameters

These x-ms-odata parameters were not updated in a prior PR

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[x] The title of the PR is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[x] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[x] If applicable, the PR references the bug/issue that it fixes.
[x] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[x] I have read the contribution guidelines.
[x] My spec meets the review criteria:

[x] The spec conforms to the Swagger 2.0 specification.
[x] The spec follows the guidelines described in the Swagger checklist document.
[x] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

@veronicagg There is no issue associated with this.  Thank you!

@ro-joowan ok, how did you figure out there was an issue? Next time I'd recommend opening one.

@veronicagg Good question :)  -- I was working on new APIs for catalog.json that involved x-ms-odata, and it occurred to me that this wasn't addressed in a previous/recent work for job.json/account.json

@veronicagg I'll keep the idea of issues in mind next time

@ro-joowan ok, since the model is changing for the odata extension, it may cause a breaking change in some of the generated code, have you checked any of the SDKs? are you ok with that?

@veronicagg Thanks for noting this.  I am okay with this breaking change because this is technically a bugfix.  That is, the server hasn't been returning the extra fields in JobInformation that are not in JobInformationBasic, and so I cannot imagine this having a considerable impact as a breaking change.

No modification for AutorestCI/azure-sdk-for-node

 https://github.com/Azure/azure-sdk-for-python/pull/1542

 https://github.com/Azure/azure-sdk-for-ruby/pull/1060


trident IPSec support

Describe the solution you'd like
ONTAP supports IPSec as the only data in transit encryption option for iSCSI.
Context: https://docs.netapp.com/us-en/ontap/networking/configure_ip_security_<EMAIL_ADDRESS>However, the IPSec configuration is tedious and complicated. It requires ONTAP security policy database(SPD) configuration as well as IPSec configuration on the host machine. To separately manage both these configs are a lot of pain for ONTAP end user.
It would be good if trident can add a IPSec support so that user can provide a data subnet range, and then trident can

Generate a separate security key for each node CSI driver will be running
Automatically talk to ONTAP api and generate the necessary SPD entry with the key and ip.
Automatically configure Host machine to enable IPSec using software like strongSwan
Dynamically add or remove SPD entry when cluster scales.

This would be a great solution for users that have stricter security restriction.
Wondering if this is a solid solution and worth putting time to implement.
/cc @msau42 @bswartz

+1


Automatically include polyfills for common methods that are valid typescript

Not a bug-- feature proposal.
In my clasp projects, I often include a polyfill.js file that adds common ES6/ES7 methods to strings & arrays. For example:

String.includes
String.startswith
String.endswith
Array.includes

When writing GAS code in TypeScript, calling myString.startsWith("text") looks perfectly valid / doesn't raise any warnings in my editor, but when pushed & run GAS crashes, saying that function is not defined.
I think it could be a cool feature if clasp automatically detected some of those common methods being used in your code and created a polyfill.js, preventing run-time errors. I believe webpack does something like this?
Additionally / alternatively, clasp could warn you about methods in your code that won't run on GAS and can't be easily polyfilled.
I am willing to work on this if it seems like an appropriate addition!
Here is an example of a polyfill I often add:
polyfill.js
/**
 * Add "startsWith" method to strings
 * From: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/startsWith
 */
if (!String.prototype.startsWith) {
  Object.defineProperty(String.prototype, "startsWith", {
    value: function(search, pos) {
      pos = !pos || pos < 0 ? 0 : +pos;
      return this.substring(pos, pos + search.length) === search;
    }
  });
}

For reference, here is a draft cheat sheet with status of various ecmascript features and thier support in GAS https://docs.google.com/spreadsheets/d/1ClWEIgFJy22svbtkRWnRvTfJ7w_-Ofs48Pi9Ky4_DII/edit?usp=sharing
Also worth referencing, this es6 shim for GAS, bundled as a library. http://ramblings.mcpher.com/Home/excelquirks/gassnips/es6shim

@dustinmichels if you have idea on how it should be implemented, I am all ears.

@dustinmichels this issue should now be irrelevant with V8 engine support and PR #739

Amazing!


[DO NOT MERGE] Adds SRI to js and css files

Trello card
This will add security checks to verify that the content being served on GOV.UK hasn't been modified by third parties:

upgrades sprockets-rails to version 3.2.0 so that we can use the SRI check feature
adds integrity: true to javascript_include_tag and stylesheet_link_tag

Explicitly setting config.assets.digest to false, as the default value is set to true since sprockets-rails 3.0: rails/sprockets-rails@3cb84ea
Depends on:

government-frontend: https://github.com/alphagov/government-frontend/pull/331
govuk_template: https://github.com/alphagov/govuk_template/pull/294

Why does this PR depend on https://github.com/alphagov/government-frontend/pull/331?

@fofr The changes to SRI are added together in government-frontend, static and govuk_template.
government-frontend uses static to receive some assets + layout
static receives some assets from govuk_template that it passes on to government-frontend.
Therefore these three projects have to go together and be tested together.

@h-lame I've moved the changed from PR 1041 here

The CI failures here are because we need the fix in https://github.com/alphagov/govuk_template/pull/305 to be released (see: https://github.com/alphagov/govuk_template/pull/307)

Note that this is on hold while we investigate a firefox issue with SRI (see https://github.com/alphagov/government-frontend/pull/368)

See https://github.com/alphagov/govuk_template/pull/308 and https://github.com/alphagov/govuk_template/pull/301 for discussion on impact.  We're holding off on SRI until there are fewer users using the version of Firefox that has an issue with calculating SRI.

Should we close this for now?

Closing while SRI is on hold.


Navigation2 install/setup problem - turtlebot3_fake_node build error

Describe the bug
Seems to be a bug with the colcon build process building the turtlebot3_fake_node package
To Reproduce
Steps to reproduce the behavior:

Follow the steps for installing Navigation 2 for ROSOnWindows
Get to the step "Build and Activate the Navigation 2 Workspace"

Expected behavior
I expected the colcon build process to complete without errors so I could proceed to activating the workspace
fake_node build error log
stdout_stderr.log
Environment information:

OS version: Build 19042.985
Chocolatey Versions: choco list --local-only

choco list --local-only
Chocolatey v0.10.15
chocolatey 0.10.15
chocolatey-core.extension <IP_ADDRESS>
chocolatey-dotnetfx.extension 1.0.1
chocolatey-visualstudio.extension 1.9.0
chocolatey-windowsupdate.extension 1.0.4
dotnetfx <IP_ADDRESS>90930
erlang 22.3
fselect 0.7.4
fzf 0.26.0
git 2.32.0
git.install 2.32.0
KB2919355 1.0.20160915
KB2919442 1.0.20160915
KB2999226 1.0.20181019
KB3033929 1.0.5
KB3035131 1.0.3
kubernetes-helm 3.5.4
python 3.9.4
python3 3.9.4
ripgrep 13.0.0
vcredist140 14.28.29325.2
vcredist2015 14.0.24215.20170201
vcxsrv <IP_ADDRESS>
visualstudio-installer 2.0.1
visualstudio2019-workload-vctools 1.0.1
visualstudio2019buildtools <IP_ADDRESS>
yarn 1.22.4
27 packages installed.

Console output

**********************************************************************
** Visual Studio 2019 Developer Command Prompt v16.10.2
** Copyright (c) 2021 Microsoft Corporation
**********************************************************************
[vcvarsall.bat] Environment initialized for: 'x64'

C:\Windows\System32>c:\opt\ros\foxy\x64\setup.bat

C:\Windows\System32>c:\opt\ros\foxy\x64\share\gazebo\setup.bat

C:\Windows\System32>set "SDF_PATH=c:\opt\ros\foxy\x64\share\sdformat\1.6"

C:\Windows\System32>mkdir c:\nav2_ws\src

C:\Windows\System32>pushd c:\nav2_ws

c:\nav2_ws>curl -o nav2.repos https://raw.githubusercontent.com/ms-iot/ROSOnWindows/master/docs/ros2/navigation2_foxy.repos
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   385  100   385    0     0    385      0  0:00:01 --:--:--  0:00:01  1540

c:\nav2_ws>vcs import src < nav2.repos
...
=== src\turtlebot3/turtlebot3 (git) ===
Cloning into '.'...
=== src\turtlebot3/turtlebot3_simulations (git) ===
Cloning into '.'...
=== src\utils/DynamixelSDK (git) ===
Cloning into '.'...

c:\nav2_ws>pushd c:\nav2_ws

c:\nav2_ws>colcon build
[3.350s] root DEBUG Using proactor: IocpProactor
Starting >>> dynamixel_sdk
Starting >>> turtlebot3_description
Starting >>> dynamixel_sdk_custom_interfaces
Starting >>> turtlebot3_cartographer
Starting >>> turtlebot3_example
Starting >>> turtlebot3_fake_node
Starting >>> turtlebot3_gazebo
Starting >>> turtlebot3_navigation2
Starting >>> turtlebot3_teleop
Finished <<< turtlebot3_example [4.20s]
Finished <<< turtlebot3_teleop [4.14s]
Finished <<< turtlebot3_cartographer [31.1s]
Finished <<< turtlebot3_navigation2 [31.1s]
Finished <<< turtlebot3_description [32.4s]
Finished <<< dynamixel_sdk [34.7s]
Starting >>> turtlebot3_node
Failed   <<< turtlebot3_fake_node [44.5s, exited with code 1]
Aborted  <<< turtlebot3_node [25.7s]
Aborted  <<< dynamixel_sdk_custom_interfaces [1min 47s]
Aborted  <<< turtlebot3_gazebo [2min 7s]

Summary: 6 packages finished [2min 9s]
  1 package failed: turtlebot3_fake_node
  3 packages aborted: dynamixel_sdk_custom_interfaces turtlebot3_gazebo turtlebot3_node
  1 package had stderr output: turtlebot3_gazebo
  4 packages not processed

Thanks for the report - I'll take a look.

Sorry for the delay.
It looks like there was a change in the upstream repo for Foxy, so snapped our repos file to it:
https://github.com/ms-iot/ROSOnWindows/blob/master/docs/ros2/navigation2_foxy.repos

Thank you!


Delete confirmation text incorrectly says "web app"

When clicking the delete button in the new navigation, the following confirmation appears:

The app is a function app, not a web app. Also as of right now it cannot have deployment slots. The text needs to be updated.

Fixed.


tile38 How to calculate the distance between two points

now i have two points p1 and p2 How to calculate the distance between p1 and p2

Tile38 does not allow you to calculate the distance between two points. You can use the formulae to calculate the haversine distance independently from tile38.


CI: Need containers to assist with Conan packages in build/publish pipeline

Currently, we specify build configurations that are not cached by Conan for Ubuntu, macOS, and Windows. Due to this, our builds are less than stellar time-wise, and we've had to switch macOS to not shipping RelWithDebInfo completely (as it causes 1hr+ build times due to building every required package from source).
:^)
We'll want to see about getting these packages cached in a docker container so that when it is time to build, we can use the container as part of our pipelines to speed up the build process and get macOS in-line with the other OSes. (Locally, unless someone wants to use our container we'd expect them to build from source once via Conan, and their Conan cache will handle the rest).

We could also try to separate the cache into its own pipeline and use GH's caching support to carry them over per build, but there's an expiry limit that we'd have to work around.

Update: May be trying to move off Conan after MVP, so this is on hold for now.


Avoids creating a Tokio Runtime if one already exists

Thank you so much for this library. I allowed myself to also fix some typos


Watch kapp-controller-config configmap and apply updated config

Describe the problem/challenge you have
Currently, kapp-controller loads and applies the kapp-controller-config configmap at startup. This means if the configmap is updated, the kapp-controller pod will need to be restarted in order to pick up that changes.
Describe the solution you'd like
kapp-controller should dynamically reconfigure itself if there are updates to the configmap.
Anything else you would like to add:
N/A

Vote on this request
This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.
👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"
We are also happy to receive and review Pull Requests if you want to help working on this issue.

👍

@ewrenn8 @jessehu
Just trying to gauge the impact of this feature request.  How disruptive is the current process that requires a kapp-controller restart? How often would you expect the kapp-controller-config configmap to change (when kapp-controller would not be restarting)?

@ewrenn8 @jessehu any thoughts on the above?

For now, prioritizing this as priority/important-longterm. It would be great to hear more about the impact of this feature request, though.

Hey @shyaamsn, wanted to see if you might be able to provide more information to Aaron's comment above.

Just trying to gauge the impact of this feature request. How disruptive is the current process that requires a kapp-controller restart? How often would you expect the kapp-controller-config configmap to change (when kapp-controller would not be restarting)?

Kapp controller should detect the change in the kapp-controller-config and dynamically should reload its runtime config/certs.
Bouncing the pod on every such change in the secret is not a good user experience and difficult to write operators managing kapp controllers.
This issue is essential because kapp controller is installed first and then the packageRespository is added.
So every time a new repository that has cert-based auth is added to the cluster we should bounce the pod so that the kapp controller can pick up the latest config.
The solution for this would be to implement a reconciler which would periodically fetch the config and dynamically reloads the certs in runtime.


Jsoncpp Crashes on linking

The jsoncpp library make the application crash on load. The application builds but doesn't run. I'm not able to find debug messages either.
What could be the fix?

Thanks for reporting. Is this on real hardware or on PPSSPP? I have seen crashes on the latter.

Thanks for reporting. Is this on real hardware or on PPSSPP? I have seen crashes on the latter.

This was PPSSPP. I'll get back to you as I check on the actual actual hardware.

So I checked the app on my psp and the same issue is present. The app instantly crashes on start. There's not even any exception shown in psplink.

Thanks for testing, I'll look into it.

I am able to reproduce this.

I am able to reproduce this.

Thanks for confirming. I was afraid I built the libraries wrongly. Please update if you are able to pinpoint the error.

I'm having a bit of a hard time figuring this one out. I'm trying to debug it, but gdb is giving me a strange error. I don't know if this means gdb is broken or that this is showing the actual problem:
wouterwijsman@XPS13:~/Sources/hello-json-cpp$ psp-gdb ./hello_world
GNU gdb (GDB) <IP_ADDRESS>10718-git
Copyright (C) 2021 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Type "show copying" and "show warranty" for details.
This GDB was configured as "--host=x86_64-pc-linux-gnu --target=psp".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<https://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
    <http://www.gnu.org/software/gdb/documentation/>.

For help, type "help".
Type "apropos word" to search for commands related to "word"...
Reading symbols from ./hello_world...
(gdb) target remote :10001
Remote debugging using :10001
_start (args=0, argp=0x0) at crt0_prx.c:102
102    crt0_prx.c: No such file or directory.
(gdb) bt
#0  _start (args=0, argp=0x0) at crt0_prx.c:102

I'm using this project for testing: https://github.com/sharkwouter/hello-json-cpp

Just to confirm, you're running this over in psplink right?

Is this still the case? I saw you use jsoncpp in one of your projects. Did you do anything specific to get it working?

I believe this is still the case.
The compilation finishes with no issues, but the app crashes if there's any call to the Json namespace, so I don't define any usage of this library when building for the PSP.
I would like to test this with an older SDK version since the package you created must have worked at that specific time. This might be worth investigating.

Last time I tested this, this was not always the case. I'm not sure what makes it so at all. Perhaps the coming newlib changes would improve this.

A bit unrelated, but for JSON parsing, on PS4 homebrews I've been using this cJSON library: https://github.com/DaveGamble/cJSON
I can try to port this simple ANSI C library to pspsdk, at least to offer a working alternative to JSON parsing while we fix this Jsoncpp. (also useful for anyone who doesn't want to use C++)

Actually, this was fixed. Cjson should work as well, though. Would be cool to have a port of it.


allow draft pr configuration

Hello!
Loving this plugin, thanks for making it.
This change allows for a draft PR boolean to be passed to octokit.
I copied the happy path test and fixture pretty much verbatim, except for switching the new draft boolean to true.  Please let me know if this warrants generating a new fixture, I'm not sure.

@gr2m I think I've got this all cleaned up now, please let me know if there's anything else you're looking for in the pr.


B. 🥊 Decentralized Hole Punching

eta: 2023Q2
Why:  P2P networks can have a combination of both public and private nodes. While private nodes can dial nodes on the public Internet, they are unreachable from the outside as they are behind a NAT or a firewall. We need a mechanism to dial them. A previous DHT crawl found that almost 63% of the network was undialable.
Goal: Implement Decentralized Hole Punching in js-libp2p and bring it to parity with the Go and Rust implementations.

[ ] https://github.com/libp2p/js-libp2p/issues/1005
[x] https://github.com/libp2p/js-libp2p/issues/1029
[ ] https://github.com/libp2p/js-libp2p/issues/1459
[ ] https://github.com/libp2p/js-libp2p/issues/1460

can we clarify that this is for js-ipfs in the title please?

@momack2 Any reason to include js-ipfs specifically? This work is not progressing with it in mind. We will need it for Helia but I would still not include any project in the title since it's better to remain product agnostic

sorry - I think I meant "js-libp2p" - the reason is because each of these cards shows up with out the repo title in starmaps - so otherwise you have many "holepunching" milesotnes without knowing they are for different libp2p implementations

@momack2 we could include the repo-name on milestone cards in starmap to help mitigate this problem?

Didn't see the replies above but I support adding the repo-name to the milestone cards

Yeah, I think that would help a lot
On Tue, May 9, 2023 at 2:39 AM Prithvi Shahi @.***>
wrote:

Didn't see the replies above but I support adding the repo-name to the
milestone cards
—
Reply to this email directly, view it on GitHub
https://github.com/libp2p/js-libp2p/issues/1461#issuecomment-1539150846,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEXAF7RQHPNSIA76WOYPQLXFHRALANCNFSM6AAAAAARKTHWP4
.
You are receiving this because you were mentioned.Message ID:
@.***>

JS Colo 2024 discussion
We don't do hole-punching in TCP, hole-punching is much more successful with UDP (timing is more reliable)
TCP: ~30% success
UDP: ~70% success

Things left to do:

Incorporate QUIC transport
Implement missing parts of DCUtR (the half after unilateral connection upgrade)