Selection boundaries move during widget scroll on desktop

Steps to Reproduce

Run the test desktop app with an expandable TextField (maxLines: null) with limited height constraints so scrolling is enabled.
Paste multi-line content so that scrolling is needed.
Start selection using horizontal drag (vertical drag not working per #28676).
Scroll using mouse wheel and move the mouse cursor a bit.

Expected results: Selection baseOffset stays the same as upon the first tap down.
Actual results: Selection boundaries move

Code
import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(primarySwatch: Colors.blue),
      home: MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  MyHomePage({Key? key, required this.title}) : super(key: key);

  final String title;

  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  final _controller = TextEditingController();

  @override void initState() {
    super.initState();
    String text = '';
    for (int i = 1; i < 100; i++)
      text += 'Air plant authentic post-ironic kogi slow-carb flannel microdosing'
        ' hexagon shoreditch chicharrones $i.\n';
    _controller.value = TextEditingValue(text: text);
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(title: Text(widget.title)),
      body: Center(
        child: Container(
          constraints: BoxConstraints(maxHeight: 400),
          child: TextField(
            controller: _controller,
            keyboardType: TextInputType.multiline,
            maxLines: null,
            decoration: InputDecoration(
              labelText: 'Test',
              hintText: 'Enter some text'
            ),
          ),
        ),
      ),
    );
  }
}

Logs
> flutter doctor -v
[√] Flutter (Channel dev, 1.24.0-3.0.pre, on Microsoft Windows [Version 10.0.18362.1139], locale en-GB)
    • Flutter version 1.24.0-3.0.pre at C:\flutter
    • Framework revision 2783f8e2e1 (7 days ago), 2020-10-22 09:36:06 -0700
    • Engine revision defa8be2b1
    • Dart version 2.11.0 (build 2.11.0-242.0.dev)

[X] Android toolchain - develop for Android devices
    X Unable to locate Android SDK.
      Install Android Studio from: https://developer.android.com/studio/index.html
      On first launch it will assist you in installing the Android SDK components.
      (or visit https://flutter.dev/docs/get-started/install/windows#android-setup for detailed instructions).
      If the Android SDK has been installed to a custom location, please use
      `flutter config --android-sdk` to update to that location.

[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.7.5)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.7.30523.141
    • Windows 10 SDK version 10.0.18362.0

[!] Android Studio (not installed)
    • Android Studio not found; download from https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/docs/get-started/install/windows#android-setup for detailed instructions).

[√] VS Code, 64-bit edition (version 1.50.1)
    • VS Code at C:\Program Files\Microsoft VS Code
    • Flutter extension version 3.15.1

[√] Connected device (1 available)
    • Windows (desktop) • windows • windows-x64 • Microsoft Windows [Version 10.0.18362.1139]

! Doctor found issues in 2 categories.

code sample
import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  MyHomePage({Key key, this.title}) : super(key: key);

  final String title;

  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  final _controller = TextEditingController();

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text(widget.title),
      ),
      body: Center(
        child: Container(
          constraints: BoxConstraints(maxHeight: 400),
          child: TextField(
            controller: _controller,
            keyboardType: TextInputType.multiline,
            maxLines: null,
            decoration:
                InputDecoration(labelText: 'Test', hintText: 'Enter some text'),
          ),
        ),
      ),
    );
  }
}

multiple flutter doctor -v
[✓] Flutter (Channel dev, 1.24.0-3.0.pre, on Microsoft Windows [Version 10.0.19041.572], locale en-US)
    • Flutter version 1.24.0-3.0.pre at C:\Code\flutter_dev
    • Framework revision 2783f8e2e1 (7 days ago), 2020-10-22 09:36:06 -0700
    • Engine revision defa8be2b1
    • Dart version 2.11.0 (build 2.11.0-242.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at C:\Code\sdk
    • Platform android-30, build-tools 30.0.2
    • ANDROID_HOME = C:\Code\sdk
    • Java binary at: C:\Code\android-studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[✓] Visual Studio - develop for Windows (Visual Studio Community 2019 16.7.6)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.7.30611.23
    • Windows 10 SDK version 10.0.18362.0

[✓] Android Studio (version 4.1.0)
    • Android Studio at C:\Code\android-studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[✓] VS Code (version 1.50.1)
    • VS Code at C:\Users\Taha\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.15.1

[✓] Connected device (4 available)
    • Windows (desktop) • windows    • windows-x64    • Microsoft Windows [Version 10.0.19041.572]
    • Web Server (web)  • web-server • web-javascript • Flutter Tools
    • Chrome (web)      • chrome     • web-javascript • Google Chrome 86.0.4240.111
    • Edge (web)        • edge       • web-javascript • Microsoft Edge 86.0.622.51

• No issues found!

[✓] Flutter (Channel master, 1.24.0-4.0.pre.118, on Microsoft Windows [Version 10.0.19041.572], locale en-US)
    • Flutter version 1.24.0-4.0.pre.118 at C:\Code\flutter_master
    • Framework revision 3b9ef2e8de (20 hours ago), 2020-10-28 12:11:58 -0700
    • Engine revision 64e6599910
    • Dart version 2.11.0 (build 2.11.0-260.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at C:\Code\sdk
    • Platform android-30, build-tools 30.0.2
    • ANDROID_HOME = C:\Code\sdk
    • Java binary at: C:\Code\android-studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[✓] Visual Studio - develop for Windows (Visual Studio Community 2019 16.7.6)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.7.30611.23
    • Windows 10 SDK version 10.0.18362.0

[✓] Android Studio (version 4.1.0)
    • Android Studio at C:\Code\android-studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[✓] VS Code (version 1.50.1)
    • VS Code at C:\Users\Taha\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.15.1

[✓] Connected device (4 available)
    • Windows (desktop) • windows    • windows-x64    • Microsoft Windows [Version 10.0.19041.572]
    • Web Server (web)  • web-server • web-javascript • Flutter Tools
    • Chrome (web)      • chrome     • web-javascript • Google Chrome 86.0.4240.111
    • Edge (web)        • edge       • web-javascript • Microsoft Edge 86.0.622.51

• No issues found!

The behaviour is the same on MacOS so we can probably add platform-mac. Didn't test on Linux but I'd assume it's no different.

Hi @tgucio
Yep, I can also see the issue on Linux, Popos 20.10, and Mac, it's just a general desktop mouse issue

flutter doctor -v
[✓] Flutter (Channel master, 1.24.0-4.0.pre.165, on Linux, locale en_US.UTF-8)
    • Flutter version 1.24.0-4.0.pre.165 at /home/taha/Code/flutter_master
    • Framework revision e444b1e3fa (10 hours ago), 2020-10-30 00:41:52 -0400
    • Engine revision 99cc50dfff
    • Dart version 2.11.0 (build 2.11.0-266.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /home/taha/Code/sdk
    • Platform android-30, build-tools 30.0.2
    • ANDROID_HOME = /home/taha/Code/sdk
    • Java binary at: /home/taha/Code/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at google-chrome

[✓] Linux toolchain - develop for Linux desktop
    • Ubuntu clang version 11.0.0-2
    • cmake version 3.16.3
    • ninja version 1.10.0
    • pkg-config version 0.29.2

[!] Android Studio (not installed)
    • Android Studio not found; download from
      https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/docs/get-started/install/linux#android-setup
      for detailed instructions).

[✓] VS Code (version 1.50.1)
    • VS Code at /usr/share/code
    • Flutter extension version 3.15.1

[✓] Connected device (3 available)
    • Linux (desktop)  • linux      • linux-x64      • Linux
    • Web Server (web) • web-server • web-javascript • Flutter Tools
    • Chrome (web)     • chrome     • web-javascript • Google Chrome
      86.0.4240.111

! Doctor found issues in 1 category.

flutter doctor -v
[✓] Flutter (Channel master, 1.24.0-4.0.pre.165, on Mac OS X 10.15.7 19H2
    darwin-x64, locale en-GB)
    • Flutter version 1.24.0-4.0.pre.165 at /Users/tahatesser/Code/flutter_master
    • Framework revision e444b1e3fa (9 hours ago), 2020-10-30 00:41:52 -0400
    • Engine revision 99cc50dfff
    • Dart version 2.11.0 (build 2.11.0-266.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/tahatesser/Code/sdk
    • Platform android-30, build-tools 30.0.2
    • ANDROID_HOME = /Users/tahatesser/Code/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.1, Build version 12A7403
    • CocoaPods version 1.10.0.rc.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.50.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.15.1

[✓] Connected device (4 available)
    • Taha’s iPad (mobile) • 00008020-000255113EE8402E • ios            • iOS 14.1
    • macOS (desktop)      • macos                     • darwin-x64     • Mac OS X
      10.15.7 19H2 darwin-x64
    • Web Server (web)     • web-server                • web-javascript • Flutter
      Tools
    • Chrome (web)         • chrome                    • web-javascript • Google
      Chrome 86.0.4240.111

• No issues found!

[web] I have an issue connected with that.
When a multiline text field is in some scrollable widget, Scrolling with mouse wheel [web] is not possible when the cursor is over the text field. It is annoying that scrolling stops when the multiline text field hits the mouse cursor. We need to remove the cursor from the text field to continue scrolling.
Expected behavior:

Using the mouse wheel is possible even if the cursor is over multiline text field.
If the text field is scrollable(more lines than maxLines). It first scrolls text inside the text field to the bounds(start/end) and then scrolls the widget containing text filed

Created https://github.com/flutter/flutter/pull/79144 to address this.


PICO_SDK_PATH must be specified for flash boot

I have trouble running $make V=1 (the third step in Installation from README). I am using Ubuntu LTS 20.04 WSL2 on Windows 10. I would be grateful for any help.

Thank you very much in advance.

I don't believe that error message isn't coming from pico-sdk - perhaps it's a problem with "nuttx" ? :man_shrugging:

If you're installing the SDK on Windows you might want to look at this third-party installer which simplifies things quite a bit.

Thank you both for your comments. I am installing the SDK on WSL2, and also building and compiling the code there. I have found the line of code where the problem happens.

Unfortunately, I still can't figure out the main reason, because the PICO_SDK_PATH should be correct. A picture from the same terminal window is below.

Again, that's code that comes from an external repo, so you'll need to open an issue there.

Oh. Sorry, but there is no official support for installing the SDK under Windows Subsystem for Linux at this time. Our official installation route for users running Windows is using the Windows native instructions in Chapter 9 of the Getting Started book. This is the method the third-party installer I mentioned above takes.


Feature Proposal: Syslog Blacbox Monitoring Tools

Thanks for your submission!
Here are some guidance for submitting your issue.
Tell us why you are submitting?

[ ] I found a bug - here are some steps to recreate it.
[x] I have an idea for a new feature - please document as "As a user, I would
like to..."
[ ] I am having trouble getting setup, understanding documentation, or using
Loggregator in some way - please highlight any resources you are using.
[ ] This is an architecture change that will result in cleaner more efficient
code - Tell us why you think this is a good idea.

We review issues and PR's on a weekly basis and try to schedule and prioritize
items. If you are wondering about status of an item feel free to contact us on
our slack channel.
Problem Summary
It is hard for developers and operators to identify if loss of logs in a syslog drain is due to Loggregator performance or the performance of their drain. Even sending a known amount of logs to a specified drain does not effectively rule out the potential of logs as it leaves the platform.
Solution Summary
Provide an application or set of applications similar to cf-logmon that which uses a blackbox approach to measure loss to a user provided drain. To do this the application will need to receive syslog data. Ideally this would be available in all supported protocols.
See feature proposal.

8c229f30440d5ccdb75e0a32441ef2f2ec902687886c5bd863377784d6912968

Closing, stale.


write_buf/read_buf not object safe

In general this may not be too bad but it means that Box<AsyncRead> won't actually use any optimizations implemented below

Is there anything that can be done about it?

One option would be to provide read_vec and write_vec on AsyncRead and AsyncWrite. The default impl would be to pass that to read_buf and write_buf (by wrapping the provided iovec array in a buf implementation).
Then there could be an impl of read_buf on Box<AsyncRead> that calls read_vec under the hood, which then gets back to read_buf on the other side...
A little convoluted.

Oh one option is to remove the generics and use trait objects as well. That is:
trait AsyncRead {
    fn read_buf(&mut self, buf: &mut BufMut) -> Poll<usize, std_io::Error> {
        // ...
    }
}

I'd prefer to avoid trait objects as the argument. I think using AsyncRead as a trait object will be less likely.

We can always layer such a method over the current read_buf, giving it a default impl that just invokes read_buf with the trait object.

@aturon could you provide an example of what you mean? I'm not following.
On Thu, Mar 9, 2017 at 3:55 PM Aaron Turon<EMAIL_ADDRESS>wrote:

We can always layer such a method over the current read_buf, giving it a
default impl that just invokes read_buf with the trait object.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/alexcrichton/tokio-io/issues/22#issuecomment-285524040,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAYJCQx_4kk94gWyzcuz7AA0IZdBZZ1ks5rkJFzgaJpZM4MV-LP
.

I believe:
fn read_buf1<T: BufMut>(&mut self, buf: &mut T) -> io::Result<usize>
    where Self: Sized
{
    self.read_buf2(buf)
}

fn read_buf2(&mut self, buf: &mut BufMut) -> io::Result<usize> {
    // current implementation of `AsyncRead::read_buf` on master
}

Is there an example of this in std? What are the pros / cons?
On Fri, Mar 10, 2017 at 9:33 AM Alex Crichton<EMAIL_ADDRESS>wrote:

I believe:
fn read_buf1<T: BufMut>(&mut self, buf: &mut T) -> io::Result
where Self: Sized
{
self.read_buf2(buf)
}
fn read_buf2(&mut self, buf: &mut BufMut) -> io::Result {
// current implementation of AsyncRead::read_buf on master
}
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/alexcrichton/tokio-io/issues/22#issuecomment-285732827,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAYJDKO_aCLUKlwduUnq6d_ln1nmVvdks5rkYlbgaJpZM4MV-LP
.

AFAIK no, the pro is that it supports everything but the con is complexity, unfortunately.

Has this ended up being an issue in practice?

Is this still an issue or should it be closed?

Ok let's close.


Any tips on how to speed up build of a very large table? (~1500 rows)

First off - thanks for the awesome project 🙏🏼
I use the mkdocs-material + python-markdown integration quite heavily with the docs I build and I am running into a corner case which I'm not quite sure how best to improve / optimize.
We have a super large markdown table (~1500 rows with 3 columns, with md links in each cell) that is auto-generated and when trying to build with mkdocs build, it hangs specifically on the python-markdown bit and takes ~30min just to build that one file 😅
The last debug print I see before the ~30min wait until the next file are some Successfully imported extension and Successfully loaded extension from core.py within this package:
 DEBUG    ][ MARKDOWN ][ core.py:126  ] Successfully loaded extension "markdown.extensions.toc.TocExtension".
[ DEBUG    ][ MARKDOWN ][ core.py:126  ] Successfully loaded extension "markdown.extensions.tables.TableExtension".
[ DEBUG    ][ MARKDOWN ][ core.py:126  ] Successfully loaded extension "markdown.extensions.fenced_code.FencedCodeExtension".
[ DEBUG    ][ MARKDOWN ][ core.py:126  ] Successfully loaded extension "markdown.extensions.meta.MetaExtension".
[ DEBUG    ][ MARKDOWN ][ core.py:126  ] Successfully loaded extension "markdown.extensions.admonition.AdmonitionExtension".
[ DEBUG    ][ MARKDOWN ][ core.py:126  ] Successfully loaded extension "markdown.extensions.attr_list.AttrListExtension".
[ DEBUG    ][ MARKDOWN ][ core.py:126  ] Successfully loaded extension "markdown.extensions.footnotes.FootnoteExtension".
[ DEBUG    ][ MARKDOWN ][ core.py:126  ] Successfully loaded extension "markdown.extensions.md_in_html.MarkdownInHtmlExtension".
[ DEBUG    ][ MARKDOWN ][ core.py:163  ] Successfully imported extension module "pymdownx.highlight".
[ DEBUG    ][ MARKDOWN ][ core.py:126  ] Successfully loaded extension "pymdownx.highlight.HighlightExtension".
[ DEBUG    ][ MARKDOWN ][ core.py:163  ] Successfully imported extension module "pymdownx.snippets".
[ DEBUG    ][ MARKDOWN ][ core.py:126  ] Successfully loaded extension "pymdownx.snippets.SnippetExtension".
[ DEBUG    ][ MARKDOWN ][ core.py:163  ] Successfully imported extension module "pymdownx.details".
[ DEBUG    ][ MARKDOWN ][ core.py:126  ] Successfully loaded extension "pymdownx.details.DetailsExtension".
[ DEBUG    ][ MARKDOWN ][ core.py:163  ] Successfully imported extension module "pymdownx.tabbed".
[ DEBUG    ][ MARKDOWN ][ core.py:126  ] Successfully loaded extension "pymdownx.tabbed.TabbedExtension".
[ DEBUG    ][ MARKDOWN ][ core.py:163  ] Successfully imported extension module "pymdownx.saneheaders".
[ DEBUG    ][ MARKDOWN ][ core.py:126  ] Successfully loaded extension "pymdownx.saneheaders.SaneHeadersExtension".
[ DEBUG    ][ MARKDOWN ][ core.py:163  ] Successfully imported extension module "pymdownx.keys".
[ DEBUG    ][ MARKDOWN ][ core.py:126  ] Successfully loaded extension "pymdownx.keys.KeysExtension".
[ DEBUG    ][ MARKDOWN ][ core.py:163  ] Successfully imported extension module "pymdownx.tasklist".
[ DEBUG    ][ MARKDOWN ][ core.py:126  ] Successfully loaded extension "pymdownx.tasklist.TasklistExtension".
[ DEBUG    ][ MARKDOWN ][ core.py:163  ] Successfully imported extension module "pymdownx.arithmatex".
[ DEBUG    ][ MARKDOWN ][ core.py:126  ] Successfully loaded extension "pymdownx.arithmatex.ArithmatexExtension".
[ DEBUG    ][ MARKDOWN ][ core.py:163  ] Successfully imported extension module "pymdownx.inlinehilite".
[ DEBUG    ][ MARKDOWN ][ core.py:163  ] Successfully imported extension module "pymdownx.highlight".
[ DEBUG    ][ MARKDOWN ][ core.py:126  ] Successfully loaded extension "pymdownx.highlight.HighlightExtension".
[ DEBUG    ][ MARKDOWN ][ core.py:126  ] Successfully loaded extension "pymdownx.inlinehilite.InlineHiliteExtension".
[ DEBUG    ][ MARKDOWN ][ core.py:163  ] Successfully imported extension module "pymdownx.superfences".
[ DEBUG    ][ MARKDOWN ][ core.py:163  ] Successfully imported extension module "pymdownx._bypassnorm".
[ DEBUG    ][ MARKDOWN ][ core.py:126  ] Successfully loaded extension "pymdownx._bypassnorm.BypassNormExtension".
[ DEBUG    ][ MARKDOWN ][ core.py:163  ] Successfully imported extension module "pymdownx.highlight".
[ DEBUG    ][ MARKDOWN ][ core.py:126  ] Successfully loaded extension "pymdownx.highlight.HighlightExtension".
[ DEBUG    ][ MARKDOWN ][ core.py:126  ] Successfully loaded extension "pymdownx.superfences.SuperFencesCodeExtension".
[ DEBUG    ][ MARKDOWN ][ core.py:163  ] Successfully imported extension module "pymdownx.emoji".
[ DEBUG    ][ MARKDOWN ][ core.py:126  ] Successfully loaded extension "pymdownx.emoji.EmojiExtension".

After this last print it hangs for ~30min until moving onto the next file.
Main questions

I cant tell which extension is taking a long time...any tips on how to see more granular debug prints (or is the best way here to add my own to each extension?)
Is there some trick to speed up build times here for super large tables?

With #1375 I'm able to see where it is getting stuck. Looks like it is in the markdown.treeprocessors that is getting stuck:
[ DEBUG    ][ MARKDOWN ][ core.py:236  ] Converting markdown file to serialzed XHTML or HTML
[ DEBUG    ][ MARKDOWN ][ core.py:249  ] Split document into lines
[ DEBUG    ][ MARKDOWN ][ core.py:252  ] Running preprocessor prep for pymdownx._bypassnorm
[ DEBUG    ][ MARKDOWN ][ core.py:252  ] Running preprocessor prep for pymdownx.snippets
[ DEBUG    ][ MARKDOWN ][ core.py:252  ] Running preprocessor prep for pymdownx.superfences
[ DEBUG    ][ MARKDOWN ][ core.py:252  ] Running preprocessor prep for markdown.preprocessors
[ DEBUG    ][ MARKDOWN ][ core.py:252  ] Running preprocessor prep for pymdownx._bypassnorm
[ DEBUG    ][ MARKDOWN ][ core.py:252  ] Running preprocessor prep for markdown.extensions.meta
[ DEBUG    ][ MARKDOWN ][ core.py:252  ] Running preprocessor prep for pymdownx.superfences
[ DEBUG    ][ MARKDOWN ][ core.py:252  ] Running preprocessor prep for markdown.extensions.md_in_html
[ DEBUG    ][ MARKDOWN ][ core.py:255  ] Parse the high-level elements of the file
[ DEBUG    ][ MARKDOWN ][ core.py:258  ] Run the tree-processors
[ DEBUG    ][ MARKDOWN ][ core.py:260  ] Running treeprocessor for markdown.extensions.footnotes
[ DEBUG    ][ MARKDOWN ][ core.py:260  ] Running treeprocessor for pymdownx.highlight
[ DEBUG    ][ MARKDOWN ][ core.py:260  ] Running treeprocessor for pymdownx.tasklist
[ DEBUG    ][ MARKDOWN ][ core.py:260  ] Running treeprocessor for markdown.treeprocessors

Looks like its the InlineProcessor tree processor:
[ DEBUG    ][ MARKDOWN ][ core.py:258  ] Run the tree-processors
[ DEBUG    ][ MARKDOWN ][ core.py:260  ] Running treeprocessor for markdown.extensions.footnotes:FootnoteTreeprocessor
[ DEBUG    ][ MARKDOWN ][ core.py:260  ] Running treeprocessor for pymdownx.highlight:HighlightTreeprocessor
[ DEBUG    ][ MARKDOWN ][ core.py:260  ] Running treeprocessor for pymdownx.tasklist:TasklistTreeprocessor
[ DEBUG    ][ MARKDOWN ][ core.py:260  ] Running treeprocessor for markdown.treeprocessors:InlineProcessor
[ DEBUG    ][ MARKDOWN ][ treeprocessors.py:345  ] Running inline treeprocessor

Ah it looks like the InlineTreeprocessor skips AtomcStrings. I'll see if I can adjust our table generation logic to only use atomic strings then.

Ah it looks like the InlineTreeprocessor skips AtomicStrings. I'll see if I can adjust our table generation logic to only use atomic strings then.

I doubt that will work. Atomic strings are simply an instance of a custom Python class. They would not be retained in a external text file. They are intended to be used internally to instruct the parser that that string is fully parsed and to ignore it in any future parsing.

@waylan ok, thanks! Any suggestions on how to fix this issue then? Or speed up the InlineTreeprocessor?

The InlineTreeProcessor is simple a wrapper around all inline processors (see inlinepatterns.py. It could be anything in there.
Although, I have to wonder it perhaps there is an issue with the syntax of your tables. If you have the table extension enabled, then the large table should have converted all of the table syntax already and the contents of each cell would then need to be parsed. Table cells usually tend to have pretty simple content, so this is not usually an issue. Unless you have some unusual cell content...
Or it could be that stepping through all of the many thousands of cells is what is slowing things down. And come to think of it, the InlineTreeProcessor does some extra shenanigans to support some sophisticated nesting (as explained here; in fact, it could be that the entire discussion in #798 is related to this). Running that for each cell on thousands of cells could add up. Although, I can't imagine ~30 minutes for that.

Unless you have some unusual cell content...

@waylan inside each cell is either one link (e.g. [text](link.html)) or a list of links in one line (e.g. [text](link.html)*;* [other text](link2.html)*;*).  The auto-generator tool we use inserts those funky *;* in between each link, could that trip up the inline processors somehow? I might be able to adjust it to just be a normal ;.
Not sure if it matters either but VS Code markdown preview utility can render the table just fine very quickly.

I don't see any obvious reason for the slowdown from what you have provided. Again, take a look at #798. Even if the specific issue there is not relevant, our general approach to performance issues and priorities are discussed in detail.
It could be that you have hit an edge case on some regex which we could tweak or it could be that a fix would require completely rewriting how inline parser works. Python-Markdown is very old and back when its structure was first designed very few extensions existed in any implementation. Therefore, it doesn't always work well for some newer syntax. We haven't rewritten as that would require us to abandon the rich ecosystem of existing third party extensions.

We have a super large markdown table (~1500 rows with 3 columns, with md links in each cell) that is auto-generated and when trying to build with mkdocs build, it hangs specifically on the python-markdown bit and takes ~30min just to build that one file 😅

Correct me if I'm wrong, and I definitely might be, as I don't have enough information on what you're trying to achieve, but if you're generating the table, why not just generate HTML and omit Markdown processing completely?

why not just generate HTML and omit Markdown processing completely?

@squidfunk this was going to be my "plan b" if we cant figure it out here 😅

@flynneva if you're dealing with a lot of data, it might be a scalable approach 😉 However, I understand that you might want to keep Markdown parsing inside of table cells, e.g. text formatting, icons, etc., which would require some extra work.

@waylan just figured it out 🙃 it isn't an issue at all with this repo. Its the generator we have.
The issue was that just before the md table, there is an HTML link in the file (e.g. `), without an empty line between it and the table, causing the parser here to not consider it a table...and instead treat it as one huge paragraph I think 🙃
Removing that link, or adding a space between it and the table fixes my issue.
Closing this as it is resolved.
Big thanks for helping me find the root cause 🙏🏼  @waylan @squidfunk

why not just generate HTML and omit Markdown processing completely?

That may or may not help; it depends on what the issue is. The Markdown parser will still parse all of the raw HTML (as HTML) only to find the end of the block of text it should ignore. However, it uses the HTML parser in the Python standard library which is generally fast enough but does have a few weird edge cases of its own. That said, all inline processing is avoided, so the current slowdown would be avoided.


Upgrade connect

Motivation
To suppress below warning while installation
warning<EMAIL_ADDRESS>connect 2.x series is deprecated

Test Plan
Have no idea as of now.
CI only?
Release Notes
[INTERNAL] [MINOR] [package.json] - Upgrade connect to v3.6.5

Thanks for the PR!
Could you just update the test plan to explain how you tested that it still works after updating connect, it's a major version bumb so there could be breaking changes. I'm not sure where we use this dependency but you could grep the codebase and make sure to test those features rapidly.

Thanks for your comment!
Okay, then I'll dig more deeply where it's used and update the test plan.

Have you tried it before submitting the PR?
Because using ´yarn resolutions´ I was able to try to use<EMAIL_ADDRESS>and the packager closed itself with the error: connect.compress is not a function


Add parsing task add and delete command functionality

Codecov Report

Merging #95 (913d1e5) into master (13bd68f) will increase coverage by 0.10%.
The diff coverage is 78.04%.

@@             Coverage Diff              @@
##             master      #95      +/-   ##
============================================
+ Coverage     67.31%   67.41%   +0.10%
- Complexity      408      416       +8
============================================
  Files            82       82
  Lines          1343     1375      +32
  Branches        145      152       +7
============================================
+ Hits            904      927      +23
- Misses          404      407       +3
- Partials         35       41       +6

Impacted Files
Coverage Δ

...dress/logic/commands/categoryless/ExitCommand.java
100.00% <ø> (ø)

...ss/logic/parser/tasks/TaskDeleteCommandParser.java
62.50% <57.14%> (-37.50%)
:arrow_down:

...dress/logic/parser/tasks/TaskAddCommandParser.java
64.28% <61.53%> (-35.72%)
:arrow_down:

...ic/parser/contacts/ContactDeleteCommandParser.java
87.50% <85.71%> (-12.50%)
:arrow_down:

...u/address/logic/commands/tasks/TaskAddCommand.java
83.33% <100.00%> (+33.33%)
:arrow_up:

...ddress/logic/commands/tasks/TaskDeleteCommand.java
75.00% <100.00%> (+25.00%)
:arrow_up:

...ain/java/seedu/address/logic/parser/CliSyntax.java
90.00% <100.00%> (+6.66%)
:arrow_up:

...in/java/seedu/address/logic/parser/ParserUtil.java
97.36% <100.00%> (+0.14%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Incorporating structural schema information

Dear valentine devs,
I was wondering about losing the structural information found in json / dictionaries when normalizing them into pandas data frames. To my understanding, coma3 would usually use this information in a matching process to improve the results. What do you think about supporting a nested (JSON) data source? I guess one would need to transform it to xml to be able to use it with coma ect.
All the best, and thanks for the great work!

Hi @overflw  and thanks for your comment and support!
Valentine is a python package designed for supporting matching on tabular datasets only. Support for other file formats such as .json/.xml and for methods that can handle them (like COMA) is not straightforward, thus it can be seen as the goal of another project in the future. However, we could include support for such file formats in a future release, given the demand. And, of course, we are open to any contributions by the community!

Closing this one! @overflw in case you want to contribute something, we would be happy to guide you through the process.


the CdsShortTimestamp datetimes are now timezone aware

Codecov Report
Base: 95.63% // Head: 95.56% // Decreases project coverage by -0.08% :warning:

Coverage data is based on head (2f10978) compared to base (da5fb1d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
- Coverage   95.63%   95.56%   -0.08%
==========================================
  Files          75       75
  Lines        5870     5888      +18
==========================================
+ Hits         5614     5627      +13
- Misses        256      261       +5

Flag
Coverage Δ

unittests
95.56% <100.00%> (-0.08%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

spacepackets/ecss/tm.py
92.51% <ø> (ø)

tests/ecss/test_pus_tm.py
100.00% <ø> (ø)

spacepackets/ccsds/time.py
83.42% <100.00%> (-2.38%)
:arrow_down:

tests/ccsds/test_time.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Timestep doesn't take refresh rate into account

Setup

Have two monitors, one 160hz and the other 60hz
Open Newton's Cradle demo listed in readme (Link)
Run demo, and move chrome window from one monitor to the other

Observe
The demo runs twice as fast on the 160hz monitor than it does on the 60hz monitor
GIF
I recorded it on my phone to show the difference in simulation speed
https://gfycat.com/HugeAmusingChameleon
I believe this is because of an assumption that requestAnimationFrame target FPS is 60, where as on a higher refresh rate RAF can be called at 140fps

Same issue occurring for me and others

I've been trying to find out how to fix this as well. Running a game, using MatterJS physics, on 2 different monitors (144hz and 60hz) is like putting on fast forward.

I had this issue with my users a while back and I fixed it by altering the deltaMin and deltaMax so that it didn't assume 60 fps.
I then had one other issue regarding monitor refresh rate and differing performance which may be worth mentioning here: setting velocity via setVelocity() currently does not normalize the velocity parameter. It currently sets the velocity to units-per-delta-time-of-last-frame, which differs with varying refresh rates. See https://github.com/liabru/matter-js/issues/637 for the issue I opened for that one.

@wmike1987 how did you go about fixing deltaMin and deltaMax so they do not assume 60 fps? I'm also interested in how you fixed the velocity issue.

PR #1254 includes updates relating to this issue, see details in that branch if you wish to try it out.

Since PR #1254 has been open for a while I decided to write my own loop, it's a fixed time step (so you won't lose determinism) that updates up to 144 times per second and has the same perceived speed on different refresh rates.
let isRunning = true;
let lastUpdate = performance.now();
const fixedDelta = 1000 / 144;
const runnerFunc = () => {
    const now = performance.now();

    while (progress < now) {
        Matter.Engine.update(engine, fixedDelta);
        lastUpdate += fixedDelta;
    }

    if (isRunning) {
        requestAnimationFrame(runnerFunc);
    }
}
requestAnimationFrame(runnerFunc);

you removed let progress in your last edit but your while loop still contains progress < now

Hey @davidreis97, thanks for sharing this! Would you mind breaking down this code to help us understand how this solves issues associated with different monitor framerates? Thank you!

@epurban I asked GPT and the response was good enough:
The given code snippet addresses the issue of different monitor framerates by decoupling the physics simulation update rate from the frame rendering rate. Here’s how it solves the problem:

Fixed Time Step: The fixedDelta constant is set to 1000 / 144, which means that the physics engine updates at a fixed interval of approximately 6.94 milliseconds. This corresponds to a rate of 144 updates per second. By using a fixed update step, the physics calculations become deterministic and consistent, independent of the monitor's refresh rate. This is crucial for maintaining consistent physics behavior across different systems.
Accumulated Time: The while loop inside the runnerFunc function uses lastUpdate and compares it to the current time now to determine how many physics updates are needed. If lastUpdate is less than now, it means that there is still time "debt" that needs to be compensated with additional physics updates. This ensures that the physics engine processes all necessary updates for the elapsed time since the last frame.
Decoupling from Frame Rate: By updating the physics engine in a loop based on accumulated time rather than directly within the animation frame callback, the physics simulation is kept consistent regardless of the rendering frame rate. This is particularly important in scenarios where the frame rate might drop below the target (e.g., due to complex rendering tasks or lower hardware capabilities), as the physics simulation will continue to update correctly and consistently.
Continuity with requestAnimationFrame: The use of requestAnimationFrame(runnerFunc) ensures that the runner function is called before the next repaint. requestAnimationFrame also provides the benefit of running the updates at an optimal rate for the browser, helping in managing CPU/GPU load efficiently. However, since the physics updates are managed separately within the while loop, the actual rendering frame rate does not disrupt the physics calculations.

In summary, this method allows for a stable and consistent physics simulation that is not affected by varying refresh rates across different monitors. This is particularly useful in gaming or any real-time interactive applications where consistent physics behavior is essential for a fair and uniform user experience.

@davidreis97 there is a problem with this code if my goal is to run physics steps less frequent than frame update. In your case, physics step will always run at least once for every frame.
const physicsDelta = 1000 / 144;
let lastUpdate = 0;
const runnerFunc = () => {
    while (lastUpdate + physicsDelta < performance.now()) {
        lastUpdate = performance.now();
        Matter.Engine.update(engine, physicsDelta);
    }
}
requestAnimationFrame(runnerFunc);

The following loop will catch up regardless whether physics delta of frame delta is higher.

A proper solution would be to run in a fixed timestep. Keep in mind that frame rate can be dynamic, i.e. change at any time during single game.

I have implemented the last and "best" solution in my work project where I am creating Plinko.
I have encountered that physics engine behaves differently on different frame rate screens. I think that I have implemented everything correctly, but balls are insanely slow and collisions are not happening or happening very rarely:
`  let t = 0.0;
let dt = 0.01;
let currentTime = Date.now();
let accumulator = 0.0;

let previous: { [x: number]: Vector } = [];

const render = () => {
  this.checkBoundaryCollision();
  ctx.clearRect(0, 0, canvas.width, canvas.height);
  this.showObjects(ctx);
  this.ballsArr.forEach((ball) => ball.body.position);
  this.checkPegBallCollision();
};

const interpolate = (alpha: number, current: Vector, prev: Vector) => {
  if (prev) {
    return {
      x: current.x * alpha + prev.x * (1.0 - alpha),
      y: current.y * alpha + prev.y * (1.0 - alpha),
    };
  }
  return current;
};
const update = () => {
  let newTime = Date.now();
  let frameTime = newTime - currentTime;
  if (frameTime > 0.25) frameTime = 0.25;
  currentTime = newTime;

  accumulator += frameTime;

  while (accumulator >= dt) {
    this.ballsArr.forEach((ball) => {
      previous[ball.body.id] = structuredClone(ball.body.position);
    });
    Engine.update(this.engine, dt);
    console.log(this.ballsArr[0]?.body.position === previous[this.ballsArr[0]?.body.id]);
    t += dt;
    accumulator -= dt;
  }

  const alpha = accumulator / dt;
  this.ballsArr.forEach((ball) => {
    const prevBall = previous[ball.body.id];
    ball.body.position = interpolate(alpha, ball.body.position, prevBall);
  });

  render();
  animationFrameId.current = requestAnimationFrame(update);
};

animationFrameId.current = requestAnimationFrame(update);`

As of 0.20.0 there is now built in Matter.Runner support for fixed timestep with high refresh displays see https://github.com/liabru/matter-js/pull/1300.
Closing this one. Thanks all!


Dotnet core 6 support for lambda

From the code, it looks like the example provided works for dotnet3.1. However, AWS already deprecated it and LTS version is 6.x
Does the existing example just works? I presume so. Please revert if you think otherwise.
Thank you.

.NET support was released as part of Extension v2.3.13. Please use dotnet layers as found here


[Feature] Service instance dependency

Please answer these questions before submitting pull request

Why submit this pull request?

[ ] Bug fix

[x] New feature provided

[ ] Improve performance

Related issues
#3829

New feature or improvement

Storage ServiceInstanceRelationServerSideMetrics and ServiceInstanceRelationClientSideMetrics
Add and update  ServiceInstanceInventory#mappingServiceInstanceId
Add getServiceInstanceTopology(clientServiceId: ID!, serverServiceId: ID!, duration: Duration!): ServiceInstanceTopology  to TopologyQuery

Sorry, because I deleted the fork repository branch by mistake, I can only open a new PR.
Ref #3950

works like this:

Generally, it is good. Please add test in e2e.

Codecov Report

Merging #3978 into master will decrease coverage by 0.58%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #3978      +/-   ##
==========================================
- Coverage    27.9%   27.32%   -0.59%
==========================================
  Files        1122     1127       +5
  Lines       24341    24860     +519
  Branches     3528     3588      +60
==========================================
  Hits         6792     6792
- Misses      16949    17468     +519
  Partials      600      600

Impacted Files
Coverage Δ

...ch7/cache/ServiceInstanceInventoryCacheEs7DAO.java
0% <ø> (ø)
:arrow_up:

...tion/service/ServiceRelationServerSideMetrics.java
0% <ø> (ø)

...tion/service/ServiceRelationClientSideMetrics.java
0% <ø> (ø)

...elation/service/ServiceCallRelationDispatcher.java
0% <ø> (ø)

...nstance/ServiceInstanceCallRelationDispatcher.java
0% <0%> (ø)

...er/service/ServiceInstanceMappingSpanListener.java
0% <0%> (ø)

...ser/listener/endpoint/MultiScopesSpanListener.java
0% <0%> (ø)
:arrow_up:

...dbc/h2/dao/H2ServiceInstanceInventoryCacheDAO.java
0% <0%> (ø)
:arrow_up:

...ance/ServiceInstanceRelationServerSideMetrics.java
0% <0%> (ø)

...alking/oap/server/core/cache/CacheUpdateTimer.java
0% <0%> (ø)
:arrow_up:

... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdc0609...0f6ad18. Read the comment docs.

From the latest query protocol.

E2e cluster is not yet complete.

@Fine0830 This PR is closing to be merged, once it is done. We could work on the UI side to see the instances relationship(add a button on the line metrics tab, then open a box to show the relationship of instances)

Let's add a new e2e cluster test without a gateway. We could check the service instance relationship in a more widely used case.

@kezhenxu94 @dmsolr @JaredTan95 Please review this PR.


Computing Routes Failed

Sorted the private key issue out, now I am faced with this not able to use the RPC/Jupiter Connection.

Im using https://arbprotocol.genesysgo.net as an RPC to test, as youve mentioned it before, yet still failing. Ive also tried the standard Solana Serum RPC to no avail.

Hi! 😄  Sorry to hear that, hope it works now

Hi mate, all sorted. Didn't realize it throws this error if the settings aren't compatible.


Getting datatype with its dialect

Related to issue https://github.com/apache/incubator-superset/issues/2382 to fix datatype with relative dialect.

It's not clear if it does fix the issue for you?

Coverage remained the same at 69.142% when pulling ff5d56f5689768842ca164f7fa169693dc7df213 on datinho:dialect_types into e22aecb0d1244bae49d3e5b36ef2f9ddc7517c1a on apache:master.

Coverage remained the same at 69.142% when pulling ff5d56f5689768842ca164f7fa169693dc7df213 on datinho:dialect_types into e22aecb0d1244bae49d3e5b36ef2f9ddc7517c1a on apache:master.


Feature Request: Documenation on how to construct media paths to recordings.

Is your feature request related to a problem? Please describe.
This is a documentation request. The issue is that I can't construct the media path to the recordings. I would like to expose the recordings of my cameras (which I can see in the media folder) in a gallery card:
https://github.com/TarheelGrad1998/gallery-card
I tried many different paths, but none worked successfully. I also don't know where I can try out some of these paths in home assistant, so I can't say for sure if the issue is coming from the gallery card of the Topo extension.
Describe the solution you'd like
Only thing I would like is a documentation on the media path to the recordings.
Describe alternatives you've considered
There are other plugins that create media paths from filesystem. But it seems like an overkill since the recordings are already available as media. I also considered running a separate web server, but that also seems a bit much.
Additional context
Thank you for your help, you have done a terrific job! I love the extension!

Hi,
Media paths in www folder are randomly generated and the files are deleted after a short period on purpose - to protect the privacy of users because the www folder is not password or Auth protected at all.
Files are stored in cold storage that is not accessible to browser in .storage folder using the entry_id of configured device as a folder name.

Hi developer, I'm trying to add a cold storage path to my network storage (a synology NAS) to remove the TF card on the camera. But I have an issue of constructing that cold storage path.
Now I have added the network storage using CIFS, let's say the name is storage_1, and the remote share is folder\recordings, and the server is 192.168.x.xxx, what should be the format of that cold storage path? I have tried:

\storage_1\folder\recordings
192.168.x.xxx:folder\recordings
storage_1
None of these can download videos to my NAS, instead, a new folder named with the same string as all my above tested name occurs in the path: /homeassistant

Can anyone help me with this problem?

You will need to mount the folder via HA first and then provide the path from ha.
Recordings are saved to SD card first, if you remove it there will be nothing to sync.

Hi Juraj, thank you for the reply! Yes, as you mentioned, I have mounted my NAS folder to the HA, and it has the following configurations:

Name: storage_1
Server: 192.168.x.xxx
Protocol: CIFS
Remote share: folder\recordings

My confusion comes at the

then provide the path from ha

part. What would be the path under such circumstance? I'll be greatly appreciated your generous help! Thank you!

Hi, see https://www.home-assistant.io/common-tasks/os/#network-storage .
My path is for example /share/InsideCameras/Bedroom.


ogc: Support Additional WMS 1.3.0 URL Parameters

Is your feature request related to a problem? Please describe.
Some of the URL parameters defined in the WMS 1.3.0 spec are not included in the ocg package. I recently tried to use this package to implement a WMS layer with a time-enabled WMS 1.3.0 service, but wasn't able to add the time URL parameter. Additionally, the srs URL parameter needed to be named crs for this particular WMS endpoint.
Describe the solution you'd like
I'd like to submit a PR that adds support for the following:

referring to the reference system as either crs or srs. E.g., the URL parameter would support either &crs=EPSG:3857 or &srs=EPSG:3857.
add exceptions as an optional URL parameter
add time as an optional URL parameter
add elevation as an optional URL parameter
add a rest parameter in the WmsMapType function that allows users to send non-spec URL parameters / override existing URL parameters as needed.

Describe alternatives you've considered
I tried to append the URL parameters I wanted to use onto the end of the url property passed into the WmsMapType function. That function prepends ? to its list of URL parameters, so I could not do something like url: "https://www.mrlc.gov/geoserver/NLCD_Land_Cover/wms/?time=12345", or it would result in a final URL like https://www.mrlc.gov/geoserver/NLCD_Land_Cover/wms/?time=12345?bbox=12.34,56.78&....
Additional context
I really appreciate the work that's gone into this package—I wouldn't have even known where to start without it! If my proposed changes are something that might fit well with the ogc package, I'd be quite glad to put in the work to make this happen.

Still willing to make the PR, if this is a good direction for the library.


Animation Performance Issues

Investigate issues with perf. Removing the header seems to help.

http://www.html5rocks.com/en/tutorials/speed/high-performance-animations/

I think the bubbles are slowing things down a ton. Let's move them to CSS transforms rather than abs positioning.


Typestatification

(Please ignore the "Move crypto operations" commit, this is just based on #127).
In the high level API (edhoc.rs is left for later, turned out to work easily that way), passing the initiator by &mut is replaced by passing it by value, and receiving a new object with different APIs in return. This ensures at build time that functions are only called when suitable -- previously this would have the low-level implementation's checks at runtime. As a side effect, the Copy+Clone derives (that could easily be used to break EDHOC's security) could be removed, obsoleting #114 bit by bit.
This picks up discussion from around https://github.com/openwsn-berkeley/edhoc-rs/issues/99#issuecomment-1748436544.
In order to make this practical, the C API is removed; it may later be reintroduced using higher level abstractions.
Current state: So far this only alters the initiator, not the responder. It also doesn't change  API too much. Seeing whether this breaks anything that I did not test; next steps (maybe right in this PR) is typestating the responder.

Thanks for this PR! I went through and it looks good to me.

Same comment as here, just waiting for a hax build.

Same as this comment, no issues with hax.

@malishav I am ok with merging this. Do you wish to provide any input?


Using Captcha at the last step of a form

Hi,
I've created a simple 2-step form using two form types.
The form type has included:
$builder->add('recaptcha', EWZRecaptchaType::class, [
                'validation_groups' => ['manual', 'anonymous'],
                **'mapped' => false,**
                'attr' => [
                    'options' => [
                        'theme' => 'light',
                        'type' => 'image',
                        'size' => 'normal',
                        'defer' => true,
                        'async' => true,
                    ],
                ],
            ]);

But the validation never triggers, even though it's in the flow definition of steps:
protected function loadStepsConfig(): array
    {
        return [
            [
                'label' => 'Add',
                'form_type' => UNPSubmissionType::class,
                'form_options' => [
                    'anonymous_submission' => true,
                    'validation_groups' => ['anonymous']
                ]

            ],
            [
                'label' => 'Submit',
                'form_type' => UNPSubmissionTypeAnonymous::class,
                'form_options' => [
                    'anonymous_submission' => true,
                    'validation_groups' => ['anonymous']
                ]
            ],
        ];
    }

I don't get it why it doesn't trigger? When I add the field to the mapped entity, it just works but that's wrong.

You need to add some validation constraint directly to the unmapped field. Like this (untested):
use EWZ\Bundle\RecaptchaBundle\Validator\Constraints\IsTrue as RecaptchaTrue;

$builder->add('recaptcha', EWZRecaptchaType::class, [
	'mapped' => false,
	'constraints' => [
		new RecaptchaTrue([
			'validation_groups' => ['manual', 'anonymous'],
		])
	],
	'attr' => [
		'options' => [
			'theme' => 'light',
			'type' => 'image',
			'size' => 'normal',
			'defer' => true,
			'async' => true,
		],
	],
]);

nopes, it simply does not trigger

When I added a recaptcha field to the Entity, it started validating, but it always triggered an error. Dis weird :/

oh darn! It worked, the private key was wrong :/


Mock redis for tests

Right now, I believe our CI tool is mocking redis. I would like to investigate replacing it either with a simple in memory get/set redis mock, or a maybe using a librry like fakeredis

Also worth considering https://pypi.python.org/pypi/redislite, which is quite mature.

Thanks for the suggestion @OriHoch , actually I run redis very easily on my mac with brew services start redis, the problem isn't running it, it's that I think a good unit test doesn't test the third party dependency (although that integration test is very useful), but the logic of the code it's testing.
I also like the idea of people being able to contribute to the project without having to install docker, redis, or any third party dependency.

Fixed


Problem with decimal conversion on non different culture settings (german)

With the current release conversion of dicom values which have decimals in them can fail when non-english culture settings are enabled.
So in my case when converting a decimal value a dot would be changed to a comma which in return would be stripped when parsing.
It becomes noticeable when your trying to make measurements with the viewer (wrong scale, or particularly when reconstructing a ct with mpr.
The necessary fixes are primarily in the JsonDicomConverter.cs and XmlDicomConverter.cs
When parsing values with the  System.Globalization.CultureInfo.InvariantCulture  parameter, local  user settings which would affect the conversion are ignored.
See pull request #77

@nutzlastfan thanks for reporting and the PR.  I've cherry picked the commits from the JSON converter and squash merged into dev.
I didn't see a fix for the XML converter that address this issue, the XML commits seems to address the encoding problem. I could be wrong but the commits don't have a descriptive message so I can't tell. Please consider providing a descriptive message with each commit.

The XML converter doesn't seem to have an issue with decimals.
I added the second issue for the character problem and made a new pull request. The last commits should now hopefully have a final commit description.

This is merged now. Thanks!


dxgui as a submodule

Maybe having the dxgui folder work as a submodule would be better for your codebase? I'm not sure if it automatically clones it when you're downloading release zips though.

That's exactly the problem, downloading or cloning it would simply download an empty folder. I have the folder as a repo locally, but git-ignoring 'dxgui/. git*'. This is somewhat a workaround for the submodule issue.

Fair enough


WIP adding mesa and X11

Please see the repo readme for directions on how to make PRs on this repo.
Checklist:

[ ] if you have added a CDT, it appears in the cdt_slugs.yaml file
[ ] if you have changed the CDT generator code (rpm.py), you have bumped
the build number in conda_build_config.yaml and have remade all of the
recipes via running python gen_cdt_recipes.py
[ ] if you have added a custom CDT recipe, you have added the name of the CDT
with custom: true in the cdt_slugs.yaml file.
[ ] all CDT recipes have build number set by {{ cdt_build_number }} for
old-style/legacy CDTs or {{ cdt_build_number|int + 1000 }} for new-style CDTs
[ ] if you see a warning about a CDT not having a license, you have added the
license_file key in the cdt_slugs.yaml file with the path to the appropriate
license in licenses/

I need to double-check that the recipes match and make sure to archive the old feedstocks.


[Doc Update][Message-extension-8]

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/toolkit/add-capability.md
94
5
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 044430a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/toolkit/add-capability.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/build-and-test/app-studio-overview.md
86
42
link
:white_check_mark:

msteams-platform/resources/bot-v3/bots-cards.md
86
2
link
:white_check_mark:

msteams-platform/resources/bot-v3/bots-overview.md
88
11
link
:white_check_mark:

msteams-platform/toolkit/TeamsFx-CLI.md
88
32
link
:white_check_mark:

msteams-platform/toolkit/add-capability.md
94
5
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit d8115ff:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/build-and-test/app-studio-overview.md
:white_check_mark:Succeeded
View

msteams-platform/resources/bot-v3/bots-cards.md
:white_check_mark:Succeeded
View

msteams-platform/resources/bot-v3/bots-overview.md
:white_check_mark:Succeeded
View

msteams-platform/toolkit/TeamsFx-CLI.md
:white_check_mark:Succeeded
View

msteams-platform/toolkit/add-capability.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 7452f39:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/build-and-test/app-studio-overview.md
:white_check_mark:Succeeded
View

msteams-platform/resources/bot-v3/bots-cards.md
:white_check_mark:Succeeded
View

msteams-platform/resources/bot-v3/bots-overview.md
:white_check_mark:Succeeded
View

msteams-platform/resources/bot-v3/bots-test.md
:white_check_mark:Succeeded
View

msteams-platform/resources/messaging-extension-v3/create-extensions.md
:white_check_mark:Succeeded
View

msteams-platform/resources/messaging-extension-v3/messaging-extensions-overview.md
:white_check_mark:Succeeded
View

msteams-platform/resources/messaging-extension-v3/search-extensions.md
:white_check_mark:Succeeded
View

msteams-platform/toolkit/TeamsFx-CLI.md
:white_check_mark:Succeeded
View

msteams-platform/toolkit/add-capability.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/build-and-test/app-studio-overview.md
86
42
link
:white_check_mark:

msteams-platform/resources/bot-v3/bots-cards.md
86
2
link
:white_check_mark:

msteams-platform/resources/bot-v3/bots-overview.md
88
11
link
:white_check_mark:

msteams-platform/resources/bot-v3/bots-test.md
84
24
link
:white_check_mark:

msteams-platform/resources/messaging-extension-v3/create-extensions.md
90
17
link
:white_check_mark:

msteams-platform/resources/messaging-extension-v3/messaging-extensions-overview.md
81
7
link
:white_check_mark:

msteams-platform/resources/messaging-extension-v3/search-extensions.md
84
47
link
:white_check_mark:

msteams-platform/toolkit/TeamsFx-CLI.md
88
32
link
:white_check_mark:

msteams-platform/toolkit/add-capability.md
94
5
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/TOC.yml
98
4
link
:white_check_mark:

msteams-platform/concepts/build-and-test/app-studio-overview.md
86
42
link
:white_check_mark:

msteams-platform/resources/bot-v3/bots-cards.md
86
2
link
:white_check_mark:

msteams-platform/resources/bot-v3/bots-overview.md
88
11
link
:white_check_mark:

msteams-platform/resources/bot-v3/bots-test.md
84
24
link
:white_check_mark:

msteams-platform/resources/messaging-extension-v3/create-extensions.md
90
17
link
:white_check_mark:

msteams-platform/resources/messaging-extension-v3/messaging-extensions-overview.md
81
7
link
:white_check_mark:

msteams-platform/resources/messaging-extension-v3/search-extensions.md
84
47
link
:white_check_mark:

msteams-platform/toolkit/TeamsFx-CLI.md
88
32
link
:white_check_mark:

msteams-platform/toolkit/add-capability.md
94
5
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 763f463:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/TOC.yml
:white_check_mark:Succeeded
View

msteams-platform/concepts/build-and-test/app-studio-overview.md
:white_check_mark:Succeeded
View

msteams-platform/resources/bot-v3/bots-cards.md
:white_check_mark:Succeeded
View

msteams-platform/resources/bot-v3/bots-overview.md
:white_check_mark:Succeeded
View

msteams-platform/resources/bot-v3/bots-test.md
:white_check_mark:Succeeded
View

msteams-platform/resources/messaging-extension-v3/create-extensions.md
:white_check_mark:Succeeded
View

msteams-platform/resources/messaging-extension-v3/messaging-extensions-overview.md
:white_check_mark:Succeeded
View

msteams-platform/resources/messaging-extension-v3/search-extensions.md
:white_check_mark:Succeeded
View

msteams-platform/toolkit/TeamsFx-CLI.md
:white_check_mark:Succeeded
View

msteams-platform/toolkit/add-capability.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 451a136:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/TOC.yml
:white_check_mark:Succeeded
View

msteams-platform/concepts/build-and-test/app-studio-overview.md
:white_check_mark:Succeeded
View

msteams-platform/resources/bot-v3/bots-cards.md
:white_check_mark:Succeeded
View

msteams-platform/resources/bot-v3/bots-overview.md
:white_check_mark:Succeeded
View

msteams-platform/resources/bot-v3/bots-test.md
:white_check_mark:Succeeded
View

msteams-platform/resources/messaging-extension-v3/create-extensions.md
:white_check_mark:Succeeded
View

msteams-platform/resources/messaging-extension-v3/messaging-extensions-overview.md
:white_check_mark:Succeeded
View

msteams-platform/resources/messaging-extension-v3/search-extensions.md
:white_check_mark:Succeeded
View

msteams-platform/toolkit/TeamsFx-CLI.md
:white_check_mark:Succeeded
View

msteams-platform/toolkit/add-capability.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/TOC.yml
98
4
link
:white_check_mark:

msteams-platform/concepts/build-and-test/app-studio-overview.md
86
42
link
:white_check_mark:

msteams-platform/resources/bot-v3/bots-cards.md
86
2
link
:white_check_mark:

msteams-platform/resources/bot-v3/bots-overview.md
88
11
link
:white_check_mark:

msteams-platform/resources/bot-v3/bots-test.md
84
24
link
:white_check_mark:

msteams-platform/resources/messaging-extension-v3/create-extensions.md
90
17
link
:white_check_mark:

msteams-platform/resources/messaging-extension-v3/messaging-extensions-overview.md
81
7
link
:white_check_mark:

msteams-platform/resources/messaging-extension-v3/search-extensions.md
84
47
link
:white_check_mark:

msteams-platform/toolkit/TeamsFx-CLI.md
88
32
link
:white_check_mark:

msteams-platform/toolkit/add-capability.md
94
5
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.


Fix ipmi.console.Console docstring

Taking a handler or tuple of handles was deprecated in 2014.
https://github.com/openstack/pyghmi/commit/e9000313f2cef935edd3eb9a9c57128995b5c0be
Make iohandler docstring match current behavior.
Launchpad Bug #1719665

Thank you for contributing to openstack/pyghmi!
openstack/pyghmi uses Gerrit for code review.
If you have never contributed to OpenStack before make sure you have read the
getting started documentation:
http://docs.openstack.org/infra/manual/developers.html#getting-started
Otherwise please visit
http://docs.openstack.org/infra/manual/developers.html#development-workflow
and follow the instructions there to upload your change to Gerrit.


Resolve merge conflicts from PR #8941

Resolves all merge conflicts that have crept in from #8941 since the last commit to that
branch.
This commit does not attempt to resolve any comments on the original PR, nor
have I even run the tests on this branch yet.  No promises that I haven't
botched the merge conflict resolutions either.

Results (887.91s (0:14:47)):
    2242 passed
       2 failed
         - tests/unit/test_routes.py:19 test_routes[None]
         - tests/unit/test_routes.py:19 test_routes[pypi.io]
    1815 error


Unable to fetch tails registry if the schema name contains spaces

When fetching the tails URL is the schema name has spaces in it iOS (not confirmed on Android) will fails because the URL is not recognized:
Card:CL_ACCUM:41e28904-4584-4250-a274-3723f628256b
 ERROR  ERROR: Error while retrieving tails file from URL https://tails-test.vonx.io/2K2h7kf8VGTLtfoxJgWazf:4:2K2h7kf8VGTLtfoxJgWazf:3:CL:814555:Member Card:CL_ACCUM:41e28904-4584-4250-a274-3723f628256b {
....
    "code": "ENSURLERRORDOMAIN-1002",
    "message": "unsupported URL",
    "domain": "NSURLErrorDomain",

I think we should add encodeURI() just before line 69 here. It can be added earlier in the calls stack to effect all other platforms but since nobody else is complaining it may be on RN only.

Interesting. In general spaces aren't allowed in urls, so this should probably be fixed at the issuer side.
I'm fine with adding this change, as it can't hurt

@TimoGlastra Noted. Will fix also.


Add a way to identify or clean up AWS resources

When deploying into production we generate AWS resources using:
python <workflow>.py --with retry step-functions create

The most basic workflow:
from metaflow import FlowSpec, step

class TestFlow(FlowSpec):
    @step
    def start(self) -> None:
        print("hello world!")
        self.next(self.end)

    @step
    def end(self) -> None:
        pass

if __name__ == "__main__":
    TestFlow()

creates a AWS Batch job definition (metaflow_<some-hash>) and a AWS Step Function state machine with the same name as the FlowSpec class (TestFlow in this case). All of these resources are created transparently and (as far as I can tell) there is no way to track them in Metaflow or through AWS APIs. This makes it difficult to maintain visibility on all of the resources being created by users and to eventually go back and clean them up if necessary.
Either AWS resources created by Metaflow commands should be tagged with an AWS tag that can logically group resources together (even better if the user can specify them), and/or the step-functions subgroup command should provide a way to destroy created resources.
I'm personally more in favor of the former because it would also allow costs to be tracked along with identifying resources.

Makes sense. Although not all resources can be tagged by Metaflow - for example, the underlying ECS instances used by AWS Batch can't be tagged because they will time-share with other applications.

Any updates on this?

Interested in this as well...we track all our resources with tags and it's a big limitation that we can't use them on deployed step functions.

metaflow sets tags on all AWS Batch jobs which AWS takes into account for cost reporting.


Build failure: Static graph-based restore failed with exit code .* but did not log an error.

Build
https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=709057
Build leg reported
Build / windows-arm64 Release NativeAOT / Build product
Pull Request
https://github.com/dotnet/runtime/pull/103519
Known issue core information
Fill out the known issue JSON section by following the step by step documentation on how to create a known issue
 {
    "ErrorMessage" : "",
    "BuildRetry": false,
    "ErrorPattern": "Static graph-based restore failed with exit code .* but did not log an error.",
    "ExcludeConsoleLog": false
 }

@dotnet/dnceng

Release Note Category

[ ] Feature changes/additions
[ ] Bug fixes
[ ] Internal Infrastructure Improvements

Release Note Description
Additional information about the issue reported
No response

Known issue validation
Build: :mag_right: https://dev.azure.com/dnceng-public/public/_build/results?buildId=709057
Error message validated: [Static graph-based restore failed with exit code .* but did not log an error.]
Result validation: :white_check_mark: Known issue matched with the provided build.
Validation performed at: 6/20/2024 11:56:24 PM UTC

Report

Build
Definition
Step Name
Console log
Pull Request

773118
dotnet/runtime
Build product
Log
dotnet/runtime#106139

772983
dotnet/runtime
Build product
Log
dotnet/runtime#105737

772220
dotnet/runtime
Build product
Log
dotnet/runtime#105288

771840
dotnet/runtime
Build product
Log
dotnet/runtime#106225

771691
dotnet/runtime
Build product
Log
dotnet/runtime#106217

771062
dotnet/runtime
Build product
Log
dotnet/runtime#106083

770060
dotnet/runtime
Build product
Log
dotnet/runtime#106155

769979
dotnet/runtime
Build product
Log
dotnet/runtime#106014

768998
dotnet/runtime
Build product
Log

768489
dotnet/runtime
Build product
Log
dotnet/runtime#106072

2509726
dotnet-runtime
Build product
Log

2509225
dotnet-runtime
Build product
Log

766348
dotnet/runtime
Build product
Log
dotnet/runtime#105958

764315
dotnet/runtime
Build product
Log
dotnet/runtime#105887

2507378
dotnet-dotnet
Build
Log

2506996
dotnet-runtime
Build product (linux_arm64)
Log

762890
dotnet/runtime
Build product
Log
dotnet/runtime#105781

2506608
dotnet-runtime
Build product
Log

761775
dotnet/runtime
Build product
Log
dotnet/runtime#105734

2506124
dotnet-runtime
Build product
Log

760176
dotnet/runtime
Build product
Log
dotnet/runtime#105689

760106
dotnet/runtime
Build product
Log
dotnet/runtime#104849

760081
dotnet/runtime
Build product
Log
dotnet/runtime#105676

759847
dotnet/runtime
Build product
Log
dotnet/runtime#105652

759311
dotnet/runtime
Build product
Log
dotnet/runtime#105633

758553
dotnet/runtime
Build product
Log
dotnet/runtime#105612

757500
dotnet/runtime
Build product
Log
dotnet/runtime#105584

2503522
dotnet-runtime
Build product
Log

757371
dotnet/runtime
Build product
Log
dotnet/runtime#105581

756948
dotnet/runtime
Build product
Log
dotnet/runtime#105341

756906
dotnet/runtime
Build product
Log
dotnet/runtime#104307

756867
dotnet/runtime
Build product
Log
dotnet/runtime#105110

756284
dotnet/runtime
Build product
Log
dotnet/runtime#104502

755881
dotnet/runtime
Build product
Log
dotnet/runtime#105403

755747
dotnet/runtime
Build product
Log

755306
dotnet/runtime
Build product
Log
dotnet/runtime#105424

755296
dotnet/runtime
Build product
Log
dotnet/runtime#104562

2502396
dotnet-runtime
Build product
Log

755046
dotnet/runtime
Build product
Log
dotnet/runtime#105308

755035
dotnet/runtime
Build product
Log
dotnet/runtime#105394

2501780
dotnet-runtime
Build product
Log

753811
dotnet/runtime
Build product
Log
dotnet/runtime#105410

753487
dotnet/runtime
Build product
Log
dotnet/runtime#105396

753279
dotnet/runtime
Build product
Log
dotnet/runtime#105327

2501307
dotnet-runtime
Build product
Log

753012
dotnet/runtime
Build product
Log
dotnet/runtime#105378

2501257
dotnet-runtime
Build product (linux_bionic)
Log

752944
dotnet/runtime
Build product
Log

752834
dotnet/runtime
Build product
Log
dotnet/runtime#105351

752616
dotnet/runtime
Build product
Log
dotnet/runtime#105313

752577
dotnet/runtime
Build product
Log

752566
dotnet/runtime
Build product
Log

748425
dotnet/runtime
Build product
Log
dotnet/runtime#105170

2500896
dotnet-runtime
Build product
Log

Summary

24-Hour Hit Count
7-Day Hit Count
1-Month Count

0
0
54

This is the same issue as https://github.com/dotnet/runtime/issues/103526 but moved to infrastructure/dnceng

This appears fixed but I don’t have contributor permissions on this repo. @markwilkie  can you open up issue permissions to the whole org?


fast translation issue

I tried turn on fast translation in config/kestrel-stixshifter-config.yml, then the following statement returns an empty variable.
phishing_candidates = GET process
                      FROM stixshifter://bh22-windows-<IP_ADDRESS>
                      WHERE parent_ref.name = 'WinMail.exe' AND binary_ref.name != 'WinMail.exe'
                      START 2022-07-01T00:00:00Z STOP 2022-08-01T00:00:00Z

If I remove the AND binary_ref.name != 'WinMail.exe' part, it works.
Need further debug.

Not an issue any more with Kestrel v1.7.3 (stix-shifter 6.0.3, firepit 2.3.25) and the current e2e testing on 07/28/2023.


Update to yew 0.21.0

@griffobeid thanks for doing this! Why did you decide to delete the cargo.lock?
I am worried that without this file, dependencies will self-update without our consent

https://doc.rust-lang.org/cargo/faq.html#why-have-cargolock-in-version-control
I guess library consumers only receive the Cargo.toml file so it gives you a false sense of security that your library is working. It's better to always pull the latest because that's what your consumers will receive


Correct log location in README

Unless I'm missing something, the correct location for these logs is actually in the ~/.cache/nvim/codeium folder not ~/.cache/nvim. That's where I found the logs on my machine anyway.
Let me know if you're seeing the logs in a different place.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Update ibm_catalog.json - remove dependencies section

Description
Due to various issues in the way catalog handles dependencies in the UI, we are going to remove that section from the metadata. The outcome will be this:

There would only be one dropdown (version) and all the variations would appear under that dropdown

Release required?

[ ] No release
[ ] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

/run pipeline

:tada: This issue has been resolved in version 1.9.3 :tada:
The release is available on:

GitHub release
v1.9.3

Your semantic-release bot :package::rocket:


BUG: Depreciation Warning with Ray 2.0 for pd.read_parquet when installing Modin from Github

Modin version checks

[X] I have checked that this issue has not already been reported.

[X] I have confirmed this bug exists on the latest released version of Modin.

[X] I have confirmed this bug exists on the main branch of Modin. (In order to do this you can follow this guide.)

Reproducible Example
import pandas
import modin.pandas as pd

pdf = pandas.DataFrame({"a": [0]})
pdf.to_parquet("/tmp/for_deprecation_warning.parquet")
print(pd.read_parquet("/tmp/for_deprecation_warning.parquet"))

Issue Description
Just wanted to give you guys a heads up that for reading in parquet files ray will throw a deprecation warning for every read parquet function that is called when I install modin from the Github Branch and use it with Ray 2.0.
Expected Behavior
No warnings throwing
Error Logs

(_apply_func pid=482969) FutureWarning: DataFrame.set_axis 'inplace' keyword is deprecated and will be removed in a future version. Use obj = obj.set_axis(..., copy=False) instead
(_apply_func pid=482969) FutureWarning: DataFrame.set_axis 'inplace' keyword is deprecated and will be removed in a future version. Use obj = obj.set_axis(..., copy=False) instead

Installed Versions

INSTALLED VERSIONS
commit           : 7871c7bc5adeeaca9b6fc4b88482be8b18333faa
python           : 3.9.10.final.0
python-bits      : 64
OS               : Linux
OS-release       : 5.14.0-70.26.1.el9_0.x86_64
Version          : #1 SMP PREEMPT Fri Sep 2 16:07:40 EDT 2022
machine          : x86_64
processor        : x86_64
byteorder        : little
LC_ALL           : None
LANG             : en_US.UTF-8
LOCALE           : en_US.UTF-8

@benaurelschill thank you for reporting this bug. I really appreciate that you caught a bug that, AFAICT, only appeared on the latest commit to Modin. I edited your code so it's a complete reproducer.
I'm investigating what it will take to fix the bug.

Hey @mvashishtha Thanks for the quick response. I have just seen that somebody opened a similar issue and is already working on this. #5092 So i think we can close this issue.

Duplicate of #5092


Rewrite bcc::Rotation

bcc::Rotation is supposed to represent a fixed-point of ShiftedBCC::arrow(), but it's buggy. It only has four values, but there are actually eight fixed points, which are in one-to-one correspondence with bcc:Residual. Delete it and start again.
First, improve test long_chain() so that it actually finds the bug! It is currently passing by pure luck.

Fixed in 934b35fd50.


[main] Add Konflux configurations

Add Konflux components and pipelines

/hold

prowgen is deleting 1.35 openshift/release config https://github.com/openshift/release/pull/59243

/unhold


gqltesting not retrieving data from mongodb

I'm confused on how to get the data from mgo in gqltesting.RunTests.
I'm getting the data as expected in graphiQL, but gqltesting retrieves a FAIL. Could anyone please tell me what I'm doing wrong or how to debug this?

not found
--- FAIL: TestPost (0.00s)
--- FAIL: TestPost/post_query (0.00s)
testing.go:51: got:  {"post":{"id":"","slug":"","title":""}}
testing.go:52: want: {"post":{"id":"","slug":"second-post","title":"Hello second post"}}

func TestPost(t *testing.T) {
	rootSchema := graphql.MustParseSchema(gqlSchema.GetRootSchema(), &gqlResolver.Resolver{})
	slug := "second-post"
	title := "Hello second post"
	t.Run("post query", func(t *testing.T) {
		gqltesting.RunTests(t, []*gqltesting.Test{
			{
				Schema: rootSchema,
				Query: `
					{
						post(slug:"` + slug + `") {
							slug
							title
						}
					}
				`,
				ExpectedResult: `
					{
						"post": {
							"slug": "` + slug + `",
							"title": "` + title + `"
						}
					}
				`,
			},
		})
	})
}

// [...]
func (r *Resolver) Post(args struct{ Slug string }) *postResolver {

	oneResult := &post{}

	session, collection := mongo.Get("post")
	defer session.Close()

	err := collection.Find(bson.M{"slug": args.Slug}).Select(bson.M{}).One(&oneResult)
	if err != nil {
		fmt.Println(err)
	}

	if s := oneResult; s != nil {
		return &postResolver{oneResult}
	}

	return nil
}
// [...]

I have not used mongo connector in golang before.
But I am curious is there any db mocking tools for mongodb or is the connector connected with your db when running your test

Hmm I didn't realize people were using gqltesting externally.
Is this common? Have you found the package helpful?
If so, perhaps this could be a separate repository in the organization?

@OscarYuen I made a gist here and my project "lychee" is kind of an extended version of that gist. I'm quite new in Go and not sure how to achieve the connection you are talking about for running tests.
@tonyghita I found gqltesting helpful especially when testing with some hard coded mock data. Just having issues to understand how to test with real mongodb data. I'm not experienced enough to advise to separate the repo or not, but I definitely like the package.
Btw thanks to both of you as your projects graphql-go-example and go-graphql-starter are actually my main inspiration for learning cool new things and creating lychee.

@astenmies I do not see a problem with gqltesting. You have a problem with writing tests in general. It is very difficult to test anything either when you have global variables that are not explicitly passed to the function.
In your case, I would use the context to pass the variable "mongo".
func main() {
	session, _ := GetMongo()
	middleware := mongoContextMiddleware(session)
	http.Handle("/graphql", middleware(cors.Default().Handler(&relay.Handler{Schema: graphqlSchema})))

	...
}

func mongoContextMiddleware(mongo *mgo.Session) func(http.Handler) http.Handler {
	return func(next http.Handler) http.Handler {
		return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
			ctx := r.Context()
			ctx = context.WithValue(ctx, "mongo", mongo)
			r = r.WithContext(ctx)

			next.ServeHTTP(w, r)
		})
	}
}

type Resolver struct{}

func (r *Resolver) Post(ctx context.Context, args struct{ Slug string }) *postResolver {
	mongo, ok := ctx.Value("mongo").(*mgo.Session) // <---
	if !ok {
		// Could not get "mongo" from the context.
	}

	// One result is a pointer to type post.
	oneResult := &post{}

	...
}

test:
func TestPost(t *testing.T) {
	mongo := ... // <---
	ctx := context.WithValue(context.TODO(), "mongo", mongo) // <---
	rootSchema := graphql.MustParseSchema(gqlSchema.GetRootSchema(), &gqlResolver.Resolver{})
	slug := "second-post"
	title := "Hello second post"
	t.Run("post query", func(t *testing.T) {
		gqltesting.RunTests(t, []*gqltesting.Test{
			{
				Schema: rootSchema,
				Context: ctx, // <---
				Query: ...,
				ExpectedResult: ...,
			},
		})
	})
}

For myself, I write interfaces and pass them either through context (as above) or within a resolver:
func main() {
	session, _ := GetMongo()
	graphqlSchema = graphql.MustParseSchema(Schema, &Resolver{
		mongo: session, // <---
	})
}

type Resolver struct{
	mongo *mgo.Session // <---
}

func (r *Resolver) Post(args struct{ Slug string }) *postResolver {
	session, collection := r.mongo.Get("post") // <---
	...
}

test:
func TestPost(t *testing.T) {
	mongo := ...
	rootSchema := graphql.MustParseSchema(gqlSchema.GetRootSchema(), &gqlResolver.Resolver{
		mongo: mongo  // <---
	})
	slug := "second-post"
	title := "Hello second post"
	t.Run("post query", func(t *testing.T) {
		gqltesting.RunTests(t, []*gqltesting.Test{
			{
				Schema: rootSchema,
				Query: ...,
				ExpectedResult: ...,
			},
		})
	})
}

I accidentally realized that the test I initially posted in this issue is actually working when the containing file is placed alongside main.go (top level of the app). Thus without context...
Does anyone pls have more insight on why?

You've probably got some global state leaking between tests in the same package. Is there another test in the top level?

I don't think this issue is specific to this library, so I'll close it for now.


Users cannot see their function apps

It looks like some apps created form Visual Studio have their kind property set to "functionApp" instead of "functionapp".  So we just need to update our list filter logic to be case-insensitive.

Fixed.


The module no longer appears

Good morning,
Since this evening, I have noticed that the Tidy 5e sheet module no longer appears at all in my list of modules.
An uninstallation-reinstallation does not solve the problem.
I'm on Foundry VTT 10.291 and DnD5e 2.2.2, hosted on The Forge
Thank you in advance for your answer.
Sincerely

The last supported Tidy 5e Sheet version for Dnd5e 2.2.2 can be installed using this manifest URL:
https://github.com/sdenec/tidy5e-sheet/releases/download/0.9.19/module.json
I have not used Forge yet, but I believe you can install this version using the "Install from Manifest" button:

Also, Tidy 5e Sheets version 1 is soon to be released for dnd5e 2.4.x, and after that, I am preparing it for dnd5e 3.x and Foundry V11+.

Reposting from discord:
Tidy 5e Sheets Version 2.0.0-beta.1 Released
Github release: https://github.com/kgar/foundry-vtt-tidy-5e-sheets/releases/tag/v2.0.0-beta.1
module.json: https://github.com/kgar/foundry-vtt-tidy-5e-sheets/releases/download/v2.0.0-beta.1/module.json
:rotating_light: For dnd5e 3.0.x :rotating_light:
The Tidy Open Beta for dnd5e 3.x is Here :dragon:
The URL-only open beta for Tidy 5e Sheets support in dnd5e 3x has begun. There are a number of things to polish, and there are whole features to implement from scratch (such as containers and hiding unidentified item content). There are migrations to make (dnd5e 3.x now has Age, Eyes, Skin, etc.; so Tidy will be retiring its own version of those fields).
I will be aggregating a full list of features and planned updates in this milestone as the days go by: https://github.com/kgar/foundry-vtt-tidy-5e-sheets/milestone/3
The goal of this beta is for dnd5e 3.x users, or those who have been ready to go to 3.x, to be able to try out the sheets in the latest dnd5e system version. I will be addressing any issues that arise and can/will release additional beta pre-releases. In the background, while I wait, I will be working down those milestone feature rollouts.
As always if you are jumping to a new version of dnd5e, don't forget to backup your world.
Feel free to file issues if something isn't quite right when compared to the legacy sheets. I request you mention dnd5e 3.0.x in the title, such as bug: (dnd5e 3.0.x) Vehicles Fail to Polymorph into Liches.
Cheers, everyone.
Forge Users: This Release Might Show Up in Your Options
If you are using Forge, you might see the v2.0.0-beta.1 version appear in your options. I have not published an official package for v2 Tidy to Foundry, so this may come from some other factor. Be advised that Tidy v2.0.0-beta.1 is for dnd5e 3. If you accidentally update Tidy, you can safely downgrade back to v1.x Tidy.

I am also getting this issue too, the module is not showing up in game when i try to enable it, however the modules list says it's installed.

Update: Installing from manifest URL did work properly. I noticed this issue because when i updated the module dissipated (was no longer enabled and stopped working) from my world

To help me troubleshoot, can you tell me

Foundry Version
dnd5e system version
Tidy 5e Sheets version
Are you using Forge? Are you installing via Forge?

Can you take some screenshots of the installation screen and the modules list when logged into the Foundry world?
Is the web console showing any errors?

@Melkyor were you able to perform a URL-only installation?
@MsVella are you all set, now?

@Melkyor were you able to perform a URL-only installation?

Hi,
In the meantime, I updated Foundry VTT to version 11 (patch 13 - build 315) and also that for DnD 5e 3.0.3.
The Tidy 5e sheet module now works again but... the new character sheets in the DND system are really beautiful and work quite well!
In these conditions, I will put Tidy aside for the moment.
In any case, thank you for your responsiveness and for the work you have accomplished.

Glad to hear things are working again. Enjoy the new default sheets! They are working on new NPC sheets in 3.1, too.
Closing as completed.


Suggestion: Custom notification sound

Hey Man,
First off thanks so much for putting this in the plugin hub! It means a lot to have an alternative to the windows tray notifications!
One feature I've always wanted is the option to use a different sound effect for the notifications instead of the windows system alert, would this be possible to implement at some stage?
Thanks for you work on this plugin! 😊
P.s. Sorry for misusing the issues page for suggestions!

This is already possible! You can change the notification sound to CUSTOM in the RuneLite config, then add a file called notification.wav to %userprofile%\.runelite if you want to use a different custom sound.