Some metrics are missing

Hi
I try to monitoring CF with prometheus-boshrelease
currently I set up cf exporter, firehose exporter
Most metrics are collected with this exporter
but some metric were not show in prometheus DB
Ex)
firehose_counter_event_gorouter_bad_gateways_delta
firehose_counter_event_gorouter_bad_gateways_total
firehose_counter_event_gorouter_rejected_requests_delta
firehose_counter_event_gorouter_rejected_requests_total
firehose_counter_event_bbs_* metrics empty, except two metrics "firehose_counter_event_bbs_request_count_delta", "firehose_counter_event_bbs_request_count_total"
ENV)
cf : 238
diego : 0.1476.0
cf_exporter, version 0.4.3 (branch: master, revision: 9e37d9069bbb87d739d2c326981fed917ec016e4)
build user: root@1d21624
build date: 20170216-02:38:17
go version: go1.7.5
firehose_exporter, version 4.1.0 (branch: master, revision: 95333eab4c8295bf727faa564add32422f5d71c6)
build user: root@387dfcd
build date: 20170216-01:18:51
go version: go1.7.5

Those metrics are only started to be reported by the gorouter when there's a 1st occurrence of that metric. So, if there aren't yet any rejected request or a bad gateway, the gorouter will not report them.

Thank you I can see that clearly
but counter_event bbs metrics not coming yet
What can i do to solve this problem
Shared grafana Dashboard(CF:BBS)

Do you have any app running? Most of those metrics are related to LRPs, so if you don't have app, then there's no LRP.

Of cource we have running applications
container metrics (cpu/memory/disk) are all work well

Are you able to get any firehose_counter_event_bbs_convergence_lrp_runs_total data at the prometheus console?

No .. I didn't see any "firehose_counter_event_bbs_convergence *" metrics
Only metric i can get is "firehose_counter_event_bbs_request_count_total, firehose_counter_event_bbs_request_count_delta"

@mjsjinsu I'm unsure why you don't get those metrics. Theoretically, Diego 0.1476.0 should emit those metrics according to the code (for etcd and sqldb). Can you check if the the vm that has the bbs job has also the metron_agent collocated?

@frodenas Yes, i check diego deployment, all deployed status normal
As you said me, bbs and metron_agent collocated in diego database job
database_z1/0
|   etcd                                                     | running |
|   bbs                                                      | running |
|   consul_agent                                      | running |
|   metron_agent                                     | running |
However during reviewing manifest
In the diego manifest I found there is null properties on bbs cert (ca_cert, client_cert, and key )
I think bbs cert key is cause this problem
how about your thinks?
bbs:
api_location: bbs.service.cf.internal:8889
ca_cert: nil
client_cert: nil
client_key: nil

@frodenas
I tested in other cloudfoundry platform env with bbs cert key inserted
all metrics are exported normaly and grafana dashboards are good status
Thank you for answer


Visualize MIDI/typing keyboard states

Helps with making YouTube tutorials when the audience can see what you're doing visually.

Mostly done.


chore(main): release 1.5.3

:robot: I have created a release beep boop
1.5.3 (2024-01-02)
🧰 Other

bump the deps group with 2 updates (dc1ef92)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/lederniermetre/shortcut/releases/tag/v1.5.3 :sunflower:


update symfony/ux-twig-component

fixes #1524

Very late, but this is finally merged. Thanks Christian


Treat a "No compatible version found" error as ENOTSUP

I've noticed people open issues on the npm tracker for dependency issues related to something they're trying to install, and someone usually has to redirect them to the issue tracker appropriate to what they're installing.
In such a case, npm directed these users to create an npm issue in the error message. This changes the error output to make it clearer that a dependency can't be installed with the current engines.

I just saw a hint that the next version of npm will have better messages in this situation - I hope I didn't step on any toes implementing this, it was just a quick hack.

Since GitHub kindly won't allow me to change the target branch of this, I'm going to close and open a new pull request based on the tar-js branch which seems to be where current development is...


Make it runnable with Python3

Hello @chengchingwen , would you please open a new branch and send a PR again?
something like the following:
git reset HEAD~
git stash
git checkout -b make-it-runnable-with-python3
git stash apply
git push origin make-it-runnable-with-python3

and then open the pr .
Great thanks for the PR!

This PR has been repaced by #5 .


feat: upgrade wrpc, async-nats, wasmtime

Feature or Problem

This PR is massive - but unfortunately, I don't really see a simple way forward here, which would minimize the change set due a few technical debt issues in existing design that are now fixed and the fact that pre-MVP wRPC version was adopted in various areas of wasmCloud.

Update to latest wRPC version

update wasmtime to enable that (wasmtime 22)
update async-nats to enable that (async-nats 0.35.1)

switch to async-nats-wrpc, until async functionality is exposed by the crate https://github.com/nats-io/nats.rs/pull/1267#issuecomment-2209422981 fork at https://github.com/wrpc/nats.rs

Migrate blobstore providers to use wit-bindgen-wrpc, which now supports async
Add support for custom resources by virtue of upgrading wRPC (disabled in the runtime currently, but it's a quick additive change once this massive PR is merged)
Change link and target storage to associate instances (be it an interface, root, nested interface etc) to targets
Minimize cloning and heap allocations of long-lived strings (like lattice and component IDs) on the hot path by using Arc<str> instead of String
Remove Handler abstraction and use wRPC functionality directly in the runtime

Pass ReplacedInstanceTarget through the context to the host to deduplicate native wRPC instance call from a replaced one

Respect max_instances for components by using a semaphore and a task set.
Avoid compiling components on fetch, only do so if required for fresh start (otherwise, clone the existing pre-compiled one)
Remove the wasmcloud core wRPC client - the wrpc_transport_nats client is now used directly, with support for passing headers as context per invocation and native .timeout available in InvokeExt trait https://bytecodealliance.github.io/wrpc/wrpc/transport/trait.InvokeExt.html#method.timeout

Related Issues

closes #2433
closes https://github.com/wasmCloud/wasmCloud/pull/2432
Release Information

Consumer Impact

There are breaking changes in wRPC protocol! Namely:

encoding of non-ASCII char values (strings are fine, only concerns "raw" char types)
encoding of flag values for types containing over 7 cases, encoding the bits 8 and further

This should be transparent for most users
Testing

Unit Test(s)

Acceptance or Integration

Manual Verification

cargo test mostly and the CI bingo

force-pushed to resolve the Cargo.lock merge conflict (diff https://github.com/wasmCloud/wasmCloud/compare/f6a3dd1af207afe1d8c9d1d92a667540bd5aea6d..8377aefbb273b15c4fa90ba71fa861cfbff71958)


Ide helper doesn't work properly

Hello, I've got a problem with IDE-helper. I've installer everything correctly, but for example, when I insert this command: Hash::make('pasword'), it will prints an error and also autocomplete doesn't work (of course)

Method 'make' not found in Illuminate\Support\Facades\Hash

One possible solution is to change use Illuminate\Support\Facades\Hash; to use \Hash;, but then it tells me, that

Import '\Hash' is never used

Why is it happening and how to fix this issue?

We also couldn't make this work without modifying _ide_helper.php.
A solution for PhpStorm (and other IDEs, I suppose) would be placing the IDE helper classes into the Illuminate\Support\Facades namespace:
namespace Illuminate\Support\Facades {
	exit("This file should not be included, only analyzed by your IDE");
...

And excluding vendor/laravel/framework/src/Illuminate/Support/Facades in Settings | Directories.

Can you try with the latest dev version (2.x@dev)?

@barryvdh old support issue, I suggest to close it :}


Accessoires from homebridge not responding in apple homekit

Current Situation

Accessoires are working in homebridge but not responding in apple homekit
Logs
No response
Config
No response
Homebridge UI Version
Latest
Homebridge Version
Latest
Node.js Version
20_10
Operating System
Official Homebridge Raspberry Pi Image
Environment Info
None
Raspberry Pi Model
Raspberry Pi 3 B+

A couple more details would be appreciated
ie new installation or other recent changes
Also any changes to your network recently ?

Recently had to do a hard reset off the router, have had yo remove the home bridge hub from apple home kit and re added it. After that moment this is the status everything works in homebridge but in apple homekit the are added but not responding

Which mdns advertiser are you currently using?

Same issue here after updating to v18. Using avahi for mDNS.

At this moment ciao but have tried all the others

With dns discovery it shows up but homebridge.local is not working

I just noticed after the update to homebridge v1.8 I was getting the following error:
The selected advertiser, "avahi", isn't available on this platform. Reverting to "bonjour-hap"
Installing avahi directly on my ubuntu host doesn't seem to have helped though.

Changed to Ciao everything works again


stopOnEntry does not stop when debugging gdb <-> gdbserver

The issue lies in the stopping reason handling for entrypoint-hit code where we determine it isn't an entry point and fire the wrong AD7 stopped event, which is causing VS to not stop. We need to figure out which case this is and fire the correct entrypoint-hit reason.

https://devdiv.visualstudio.com/DevDiv/_queries/edit/751954

Offending line: https://github.com/microsoft/MIEngine/blob/f4a38f145a31a50d6a8d25c6c39d5e90e2222eb0/src/MIDebugEngine/Engine.Impl/DebuggedProcess.cs#L1136


Theme changer button should be pointer

pls assign me this issue

Not accepting minor changes @AnshuPathak-88825


Move/Resize doesn't work when Numlock is on.

After researching, editing, testing, I still don't understand why it is so.
But this can be considered a feature instead of a bug. when you need to move/resize turn numlock off, otherwise turn it back on


The code in data.js needs to be abstracted

Example: the code for adding together certain fields in the scouting data and creating a new field with the sum needs to be abstracted. Currently, the code will only work for fields specific to last years competition, so we need some new code that creates "sum" fields out of specified strings in a Function or Class.

Essentially, we need to get as much competition specific code out of the csv creation function as possible.
let csv = items.map(row => {
        var highestLevel = 0;
        var ballCount = 0;
        var hatchCount = 0;
        let rowData = header.map(fieldName => {
            if (fieldName.startsWith('rocket-')) {
                if (row[fieldName] > 0) {
                    var currentHighestLevel = ROCKET_LEVELS.indexOf(fieldName.split('-')[2]) + 1;
                    highestLevel = highestLevel < currentHighestLevel ? currentHighestLevel : highestLevel;
                }
            }

            if (fieldName.startsWith('rocket-ball-')) {
                ballCount += row[fieldName];
            } else if (fieldName.startsWith('rocket-hatch-')) {
                hatchCount += row[fieldName];
            }
            return JSON.stringify(row[fieldName], replacer);;
        }).join(',');
        rowData += ',' + hatchCount + ',' + ballCount + ',' + highestLevel;
        return rowData;
    });
    header.push('hatches-rocket', 'balls-rocket', 'highest-level');
    csv.unshift(header.join(','));
    csv = csv.join('\r\n');


WEBAPP-393: Remove dependencies from endpoint package

The only depencies are now lodash, moment and mormalize-path
I also refacatored the feedback endpoint here.

@klinzo oh missed your PR comments :/ Will fix them in an other PR


set-state and set-output workflow commands have been deprecated

Describe the bug
Version

[x] I have checked releases, and the bug exists in the latest patch version of v1 or v2.
[ ] v2
[x] v1

Runners

[x] GitHub Hosted
[ ] Self Hosted

Operating systems

ubuntu-latest

PHP versions
n/a
To Reproduce
See https://github.com/sebastianbergmann/phpunit/blob/9.5.25/.github/workflows/ci.yml:
jobs:
  coding-guidelines:
    name: Coding Guidelines

    runs-on: ubuntu-latest

    steps:
      - name: Checkout
        uses: actions/checkout@v3

      - name: Install PHP
        uses: shivammathur/setup-php@v2
        with:
          php-version: 8.1
          extensions: none, iconv, json, phar, tokenizer
          coverage: none
          tools: none

      - name: Run PHP-CS-Fixer
        run: ./tools/php-cs-fixer fix --dry-run --show-progress=dots --using-cache=no --verbose

Expected behavior
No deprecations
Screenshots/Logs
See https://github.com/sebastianbergmann/phpunit/actions/runs/3233102102/jobs/5294525446#step:3:14:

Additional context
See https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Are you willing to submit a PR?
Sure!

Fixed in https://github.com/shivammathur/setup-php/commit/0575a32108978260a650e390d7008ce2c95b43e3
I will create a new release this weekend.

Thank you, @shivammathur!

Came here to report the same, only to see it already fixed. Thanks @shivammathur !

Wil this be a v3 release or an update of v2?

This will be an update of v2.

Released 2.22.0 with the fix.


[JN-867] Improved question editing UI

DESCRIPTION
This condenses a lot of the question editing UI to make it friendlier for browsing and less wall-of-texty.  The main goal was putting multiple choices in a tabular format that makes vertical scanning easier.  Erin and I still aren't happy with how many info icons there are, the long term solution will probably be to extract all the info icon content into a zendesk page linked from the top of the deisgner, but this is good enough for now.
BEFORE:

AFTER:

TO TEST:  (simple manual steps for confirming core behavior -- used for pre-release checks)

this has no functional changes, so just go to forms and surveys, pick a survey, and click on some questions and see how it looks.

test failure is unrelated failure in testPopulateHearthive()


Timing of logs

Hi, please advise how you can make the log file more detailed. I mean, how can I make the input/output to time reference in the log file?

Hi, do you mean adding datetime info to input/output?

Yes, it would be great for analytics. What time did the person enter

Sure, added a simple logic to track the datetime along with the person move_in/move_out data. You can download the updated log and check it out

There is a small problem, the data is not written to csv.
And can you please make the time of arrival only by time was?
Sorry, I'm a bit of a student and do not understand everything

It almost worked, but I can't figure out how to link log_time to move_in

You don't really need to link log_time to the remaining data as it's not meant to be (it just shows the end time when the log is saved). You can ignore it and if you only need move_in and time data, it is enough to change these lines:
line 46:def log_data(move_in):
line 49: data = [move_in]
line 63: wr.writerow(("(Move In, Time)", ""))
line 319: log_data(move_in)

Yes, I did. But I don't understand how I can separate the data
so that move_in from Time will be separate

Implemented in this commit

Thank you! That's just what I needed! Have a great day!


rbd: switch to blocklist and make it to be compatible to the old blacklist style

Signed-off-by: Xiubo Li<EMAIL_ADDRESS>

@idryomov
Done and fixed them all.

LGTM. I don't have merge rights on this repo but IIRC you do. Feel free to merge!

Thanks Ilya.


ref(helm): mix bag of syntax cleanup in cmd/helm

Clean up clean up everybody everywhere.
Clean up clean up everybody do your share.


Support for Fragment in FormSection

Are you submitting a bug report or a feature request?

Is most likely a feature request, but could be seen as a bug as well.
What is the current behavior?

When using FormSection component and providing the component to render as, Fragment will render an error message like this:
proxyConsole.js:72 Warning: Failed prop type: Invalid prop `component` supplied to `FormSection`.
    in FormSection (created by SimpleForm)
    in SimpleForm (created by Form(SimpleForm))
    in Form(SimpleForm) (created by Connect(Form(SimpleForm)))
    in Connect(Form(SimpleForm)) (created by ReduxForm)
    in ReduxForm
    in div
    in Provider

The rendered output, both in the DOM and in the redux store although works as expected.
What is the expected behavior?
That there is no error message.
Sandbox Link

https://codesandbox.io/s/rmr11kmkxo
What's your environment?

Redux form version: v.7.4.2.
Chrome: 65
Other information

#3859 fixed this. However, Fragments are JS Symbols, so this only works if the version of React in use in your app matches the version of react-is that redux-form depends on (currently 16.4.1).
Demonstrated in this sandbox: https://codesandbox.io/s/p5wvqqnw3j
Works fine with react 16.4.1, if you bump React to 16.4.2 or any other version, it gives a prop type error.
Not completely sure how to fix this. All I can think of is making react-is a peer dependency to pick up the consumer's version of it. Not sure if that would actually work though.


Update _index.md

Summary

Re-did the install, and found out you do not need to use a Rosetta mode Terminal. But you do need to run xCode in Rosetta mode.

Ticket Link

none

awesome thank you


StateMachine: Fix sync mode

Fix #26540

I think this should be cherrypicked for 3.1.
@akien-mga CC

Thanks!

Cherry-picked for 3.1.1.


NEW Expand block preview

Resolves https://github.com/silverstripe/silverstripe-elemental-blocks/issues/43
Block is not expandable:

Block is expandable and expanded; the preview is hidden

Block is expandable and not expanded; the preview is shown

Changes in this PR...

add a FormBuilder component
add a Summary component
both of the above are injected into Content and rendered by it
move the prior Content unit tests into the Summary test file, since the latter is handling this logic now
add new unit tests for the Content component
add unit tests for Element component

Design review by @clarkepaul still outstanding.
The expand button has been tested on Edge 17, IE 11 (browser stack), Chrome 11, Firefox 61, and Safari 11 . It is keyboard accessible on all of these browsers, expect Safari.
Also, the styling is slightly off on Edge 17:

Note to self, rewrite the Behat tests!


Sidecar resource not updated properly

Describe the bug
When a Sidecar resource is modified, it does not seem to update correctly.
Expected behavior
Applying a new config should have the same effect as deleting the config, then applying the new config, but it does not.
Steps to reproduce the bug
Turned on global.outboundTrafficPolicy.mode=ALLOW_ANY (not sure if related)

No Sidecar - all external traffic is blocked (curl google.com 404s)
Apply Sidecar resource

apiVersion: networking.istio.io/v1alpha3
kind: Sidecar
metadata:
  name: default
spec:
  egress:
    - hosts:
      - ./*

After this external traffic works

kubectl apply same config, changed to hosts: [] - external traffic still works
kubectl remove the Sidecar - traffic blocked
kubectl apply the config with  hosts: [] - traffic blocked

Step 3 and 5 should have the same result.
Version
Istio 1.1 Snapshot 6
Installation
Helm
Environment
GKE
@rshriram

I think the title should be updated to be clearly  Sidecar resource influence outbound traffic

step 5 implies that the code generating the config is working as expected. step 3 implies that something in the system is ignoring the config update notifications. This part of the system is in ads.go or discovery.go where there is some dampening logic.. cc @costinm who knows the details of this..
To me, 3 seems like a config update is being ignored. I have seen this issue surface every now and then with other networking configs as well.

I think we do not allow empty Hosts
		if len(i.Hosts) == 0 {
			errs = appendErrors(errs, fmt.Errorf("sidecar: egress listener must contain at least one host"))
		}

I donot know why 4 influence the rxternal traffic.

./* is valid @hzxuzhonghu ..

Not specifying any host for egress as described in step 3 above, makes the sidecar config invalid but we do not catch it. PR #12233 adds sidecars to the resources being monitored by the validating web hook in Galley to address this.

Without the fix in #12233, it looks like:

Valid sidecar gets applied. (Step 2). This goes through Galley and Pilot and gets processed.
Invalid sidecar gets applied (Step 3). Config Validator misses it, but it gets filtered out in Pilot's validation. Internal config state of Pilot doesn't change.
Resource is removed (Step 4). Valid configuration change. Pilot changes its internal state to remove and push.
Reapply  invalid sidecar (Step 5). Config validator misses, it, but it gets filtered out in Pilot's validation. Internal config state doesn't change (i.e. its empty).

I tried this locally with #12233 applied, and it looks like config validator is filtering out and returning an error during kubectl apply.
Am I missing anything? I don't see any other issues in this particular bug? (Feel free to correct me).
If there are no other issues? Can we close this one?

Sounds like it is fixed! Closing this now


Made ClusterSingletonSettings sendable

Using ClusterSingleton's host function with latest strict concurrency will result in an error:
Sending 'self'-isolated value of type 'ClusterSingletonSettings' with later accesses to actor-isolated
context risks causing data races

As ClusterSingletonPlugin is an actor and settings cross isolation in host function—it's better, and think safe, to mark it as Sendable.

Thank you!


Inconsistency of checks?

I am stuck with a "failed check".
Checking my package  concstats  with pkgcheck on my local machine a came across the following issue:
In the summary popped up a failed check due to .. continuous integration, however, I have github actions for rmd check and (now) for pkgcheck
On github the bot (of pkgcheck?) the continuous integration check passed, however, it popped up a failed check for .. "Function names are duplicated in other packages"? I don't know where to look at or what function names are duplicated (I cannot check thousands of packages). This failed check does not appear on the local check (console).

Oh yes, another very good question! @assignUser You may well have better suggestions than me, so please chime in. The meta-problem is #30, acknowledging that we need to restructure the documentation here. This issue indicates a clear need to explain the process for understanding failed checks. The action generates full information, but can't put it all directly on the workflow output. It nevertheless creates an "artefact" with all the information you need. To see it you need to:

Go to the GitHub actions page with the failed check
Look at the artefacts at the bottom and download the "results":

Extract those results and open the HTML file locally. That has lots of fold-out sections. The one you want to know about looks like this:

Alternatively, just run the checks locally as checks <- pkgcheck(path), and then run checks_to_markdown(checks) to automatically open the full report in your browser, as  explained in the main README. Continuous Integration doesn't seem to be any issue, as those GitHub actions checks don't fail there.
I'll keep this issue open until we've clearly documented this general workflow.

@mpadge maybe we should switch summary-only's default to false?

@mpadge maybe we should switch summary-only's default to false? That way the issue should contain everything except the network...

I've tried that, but it's not really intelligible that way - it's generally hundreds of lines of guff with very ilttle visual structure. Would it be possible to put a simple note in the workflow telling people to download the artefacts for details of failures?

In my testing it had the same html summary fold out thingies... so it was a bit longer but not fa full CVS-receipt... let me check

@mpadge like this: https://github.com/assignUser/octolog/issues/14 this is 3 months old though so maybe something changed with the output?

Oh yeah, sorry, my bad there. Yes, we definitely need summary_only: false. @schneiderpy you just need to follow this example from the docs and you'll get the full explanations of your failing checks in the issue:
jobs:
  check:
    runs-on: ubuntu-latest
    steps:
      - uses: ropensci-review-tools/pkgcheck-action@main
        with:
          summary-only: false

Forget what i said above about artefacts; you don't need to worry about that.

What I have done so far:

changed the pkgcheck.yaml as indicated above ... added summary-only:
false (worked fine .. in my opinion as a newbie, this should be the default)

However, I still encounter differences:
On my local machine summary(checks) give me the following output on my
console:
-- concstats 0.1.2
√ Package is already on CRAN.
√ has a 'codemeta.json' file.
√ has a 'contributing' file.
√ uses 'roxygen2'.
√ 'DESCRIPTION' has a URL field.
√ 'DESCRIPTION' has a BugReports field.
√ Package has at least one HTML vignette
√ All functions have examples.
x Package has no continuous integration checks.
√ Package coverage is 79.6%.
√ R CMD check found no errors.
√ R CMD check found no warnings.
i Current status:
x This package is not ready to be submitted.

checks_to_markdown(checks, render = TRUE)

processing file: pkgcheck64c494d2745.Rmd                        (as an
attached file)
.................................................................................................................................
First, this structure is consistent with the README, but not with the
output file from "checks_to_markdown()

the output (html) from the local machine has no "4. other checks" ...
(see attached file).
the output (local machine, console) has no check "Function names are
duplicated in other packages" (also not mentioned in README)
collateral: checks_to_markdown(.., render = TRUE) renders html, but also
(each and every line) on (my) the console.
( I don't know if this is an open ISSUE)

Second, the local output (console and html) throws an error for "CI check"
(see above), but on GITHUB (bot) the test passes ..
On GITHUB (bot) appear a test for "Function names ... " (failed) which does
not appear for the local check (console and html)
All this is somehow confusing ..
Well, in my particular case I suppose that I have to change/rename all my
function names? (and examples, documentation ... )
Something like this  .... concstats_hhi, concstats_gini, ...?
[image: Mailtrack]
https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality11&
Remitente
notificado con
Mailtrack
https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality11&
17/06/22,
20:28:26
El vie, 17 jun 2022 a las 6:56, mark padgham @.***>)
escribió:

Oh yeah, sorry, my bad there. Yes, we definitely need summary_only: false.
@schneiderpy https://github.com/schneiderpy you just need to follow this
example from the docs
https://github.com/ropensci-review-tools/pkgcheck-action#workflow-parameters
and you'll get the full explanations of your failing checks in the issue:
jobs:
check:
runs-on: ubuntu-latest
steps:
- uses: @.***
with:
summary-only: false
Forget what i said above about artefacts; you don't need to worry about
that.
—
Reply to this email directly, view it on GitHub
https://github.com/ropensci-review-tools/pkgcheck-action/issues/32#issuecomment-1158755551,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASTA3FYNUPQW4ZWJXZHKJB3VPRKWXANCNFSM5ZASBJNA
.
You are receiving this because you were mentioned.Message ID:
@.***>

@schneiderpy I'm not really sure what your questions are in the above? Please note that GitHub issues respect all markdown formatting, so you should please use that. In other words, please run checks_to_markdown(), and paste the markdown-formatted result directly in any issue comments.
The inconsistencies between standardised checks via pkgcheck-action and your local checks could be due to any number of things. If you're not seeing local CI checks, that likely suggests that you don't have your GitHub authorization token set up properly. That's explained on the pkgcheck README.
The inconsistences between what you see directly on your console screen and the markdown-formatted versions are an unavoidably consequence of compromises necessary in trying to convey a lot of information in compact ways. The most complete version is always the markdown/html version generated by checks_to_markdown(), while the screen version will generally be only an abbreviated version of that.
Finally, regarding function names, I would suggest  in your case that yes, you ought to rename a lot of them as many of the names are quite generic. A standard package-specific prefix is the generally recommended approach. This is often some abbreviated form of a full package name, although in your case the function names are generally quite short, so yes, prefixing with concstats_ would seem like a reasonable approach. Note also https://github.com/ropensci-review-tools/pkgcheck/issues/144 - once that's been implemented these namespace conflicts won't necessarily be an outright fail, but again in the case of your package i would suspect that  reviewers would likely suggest what I'm suggesting here regardless.

Thank you for your prompt reply. I thought you were on vacation ...
Actually these are not questions .. it's more like an observation. But I'll
come to this later, if I'll still encounter these issues (using Github
issues?)
(e.g. just look at the readme file of the pkgcheck() package, section:
"what is checked" ... unique_fs_names is not listed, and so in the
summary() which appear on the console screen .... but appears in the html
version ..)
However, I have another question: I have almost changed all functions
(consistently prefixed all with concstats_xxx) ..
Am I right that I have to do a new CRAN / Zenodo submission? (prob. with a
new version number) .. at least that sounds somehow logical to me
Regards,
Andreas
[image: Mailtrack]
https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality11&
Remitente
notificado con
Mailtrack
https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality11&
12/07/22,
20:07:04
El mar, 12 jul 2022 a las 7:41, mark padgham @.***>)
escribió:

@schneiderpy https://github.com/schneiderpy I'm not really sure what
your questions are in the above? Please note that GitHub issues respect all
markdown formatting, so you should please use that. In other words, please
run checks_to_markdown(), and paste the markdown-formatted result
directly in any issue comments.
The inconsistencies between standardised checks via pkgcheck-action and
your local checks could be due to any number of things. If you're not
seeing local CI checks, that likely suggests that you don't have your
GitHub authorization token set up properly. That's explained on the
pkgcheck README https://github.com/ropensci-review-tools/pkgcheck#setup.
The inconsistences between what you see directly on your console screen
and the markdown-formatted versions are an unavoidably consequence of
compromises necessary in trying to convey a lot of information in compact
ways. The most complete version is always the markdown/html version
generated by checks_to_markdown(), while the screen version will
generally be only an abbreviated version of that.
Finally, regarding function names, I would suggest in your case that yes,
you ought to rename a lot of them as many of the names are quite generic. A
standard package-specific prefix is the generally recommended approach.
This is often some abbreviated form of a full package name, although in
your case the function names are generally quite short, so yes, prefixing
with concstats_ would seem like a reasonable approach. Note also
ropensci-review-tools/pkgcheck#144
https://github.com/ropensci-review-tools/pkgcheck/issues/144 - once
that's been implemented these namespace conflicts won't necessarily be an
outright fail, but again in the case of your package i would suspect that
reviewers would likely suggest what I'm suggesting here regardless.
—
Reply to this email directly, view it on GitHub
https://github.com/ropensci-review-tools/pkgcheck-action/issues/32#issuecomment-1181654691,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASTA3F655IZ2T7H5UZQWY2TVTVKU5ANCNFSM5ZASBJNA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Am I right that I have to do a new CRAN / Zenodo submission?

That's entirely up to you, and not related either to this issue, nor to pkgcheck-action in general, so I'm going to close this for now. Your questions seem to be more ones of general package development workflow, for which there are several good references. In particular, for potential submissions to rOpenSci, please refer to our general package development guide, as well as our statistical software guide.


How to use NBT crafting?

So a feature I really hoped would have helped me is NBT crafting recipes. The idea of finally being able to create proper custom crafting recipes that show the result with the correct NBT data was incredible. Only problem I don't know how to put the nbt data into the recipe json.

I need to work on better documentation, so I'll pin this issue until I get that sorted out.
So in the result, there's an additional tag element, so it'd end up looking something like this
{
	"type": "crafting_shapeless",
	"ingredients": [
		{
			"item": "minecraft:diamond_sword"
		}
	],
	"result": {
		"item": "minecraft:diamond_sword",
		"count": 1,
		"tag": {
			"display": {
				"Name":"\"Shiny Diamond Sword\"",
				"Lore": ["{\"text\":\"It's Shiny!\",\"color\":\"gold\"}"]
			},
			"Enchantments": [{}]
		}
	}
}

The same thing can be used on the result of a shaped recipe, as well as smithing recipes although I haven't tested that one thoroughly.


Confusing behavior when you forget to specify config.forge with file-based config in multi-package.json hierarchies

Pre-flight checklist

[X] I have read the contribution documentation for this project.
[X] I agree to follow the code of conduct that this project uses.
[X] I have searched the issue tracker for a bug that matches the one I want to file, without success.

Electron Forge version
6.0.0-beta.61
Electron version
12.0.16
Operating system
macOS 11.5.1
Last known working Electron Forge version
No response
Expected behavior
Electron Forge searches in the nearest package.json directory as its bestGuessDir, not the last one it searched.
And either:

Electron Forge prints a warning / hint that you maybe forgot to set config?.forge in the nearest package.json
If config?.forge? is undefined, look for a file named forge.config.js in the same directory that the package.json file that Electron Forge is added as a dependency is in. Make setting config?.forge optional, only if you want to change the search path.

I'd prefer 2⃣ , but either one would be less confusing than the current behavior.
Actual behavior
Electron Forge throws an error saying that it couldn't find any Electron packages in devDependencies:
An unhandled rejection has occurred inside Forge:
Error: Could not find any Electron packages in devDependencies
    at getElectronModuleName (/Users/mnquintana/code/platform/desktop/ui/node_modules/@electron-forge/core/src/util/electron-version.ts:62:11)
    at getElectronVersion (/Users/mnquintana/code/platform/desktop/ui/node_modules/@electron-forge/core/src/util/electron-version.ts:99:23)
    at _default (/Users/mnquintana/code/platform/desktop/ui/node_modules/@electron-forge/core/src/api/start.ts:52:11)
    at /Users/mnquintana/code/platform/desktop/ui/node_modules/@electron-forge/cli/src/electron-forge-start.ts:58:19

Electron Forge was terminated. Location:

Steps to reproduce

Have a repo with a folder structure that looks like:other-app/package.json
package.json

Ensure that /package.json doesn't have any Electron dependencies in it
Initialize a new Electron Forge project in other-app
Copy Electron Forge config into other-app/forge.config.js
Delete the config key in other-app/package.json
Run npm start in other-app

Additional information
$ DEBUG=electron-forge* npm start

><EMAIL_ADDRESS>start /Users/mnquintana/code/platform/desktop/ui
> electron-forge start

WARNING: DEBUG environment variable detected. Append the electron-forge:lifecycle namespace
to the value of DEBUG in order to view progress indicators.
  electron-forge:async-ora Process Started: Checking your system +0ms
  electron-forge:check-system checking system, create ~/.skip-forge-system-check to stop doing this +0ms
  electron-forge:async-ora Process Succeeded: Checking your system -- after 191ms +192ms
WARNING: DEBUG environment variable detected. Append the electron-forge:lifecycle namespace
to the value of DEBUG in order to view progress indicators.
  electron-forge:async-ora Process Started: Locating Application +0ms
  electron-forge:project-resolver searching for project in: /Users/mnquintana/code/platform/desktop/ui +0ms
  electron-forge:project-resolver electron-forge compatible package.json found in /Users/mnquintana/code/platform/desktop/ui/package.json +2ms
  electron-forge:async-ora Process Succeeded: Locating Application -- after 2ms +3ms
  electron-forge:async-ora Process Started: Preparing native dependencies +3ms
  electron-forge:async-ora Process Renamed: Preparing native dependencies  -->  Preparing native dependencies: 0 / 1 +762ms
  electron-forge:async-ora Process Renamed: Preparing native dependencies: 0 / 1  -->  Preparing native dependencies: 1 / 1 +2ms
  electron-forge:async-ora Process Renamed: Preparing native dependencies: 1 / 1  -->  Preparing native dependencies: 1 / 2 +2ms
  electron-forge:async-ora Process Renamed: Preparing native dependencies: 1 / 2  -->  Preparing native dependencies: 2 / 2 +1ms
  electron-forge:async-ora Process Succeeded: Preparing native dependencies: 2 / 2 -- after 767ms +0ms
  electron-forge:start Electron binary path: /Users/mnquintana/code/platform/desktop/ui/node_modules/electron/dist/Electron.app/Contents/MacOS/Electron +0ms
  electron-forge:async-ora Process Started: Launching Application +6ms
  electron-forge:async-ora Process Succeeded: Launching Application -- after 5ms +5ms
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>start: `electron-forge start`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      /Users/mnquintana/.npm/_logs/2021-09-18T20_25_31_775Z-debug.log

From running with DEBUG on, I was able to see why this was failing – when config.forge is unset, Electron Forge walks up the directory tree looking for a package.json with config.forge – when it doesn't find one, it uses it's bestGuessDir, which is always the last search path it checked: https://github.com/electron-userland/electron-forge/blob/master/packages/api/core/src/util/resolve-dir.ts#L40
This works fine in projects with only one package.json, or projects with only sibling package.jsons, but in projects where there are package.jsons in parent folders, this results in this confusing behavior.

Let me know if there's any more info I could add that'd be helpful! 🙇🏽

This might be out of scope, but some validation around the config format in package.json would be really helpful – I somehow managed to set this:
  "config": {
    "forge": {
      "path": "./forge.config.js"
    }
  }

instead of:
  "config": {
    "forge": "./forge.config.js"
  }

Totally on me for magically inventing path, but I was surprised that Electron Forge didn't print any warnings about the invalid config schema – instead it tried launching the app with a non-existent config, and errored out for that reason.

This is fixed in 6.0.0, we now infer the forge path based on a package.json with config.forge or a package.json with an @electron-forge/cli dependency


Crashed: com.douban.audio-streamer.event-loop EXC_BAD_ACCESS 0x0000000005c123d9

Happens seemingly randomly and is frequent enough to be annoying. From what I can tell, audio_file_read buffer may not be the right size under certain circumstances...
Thread : Crashed: com.douban.audio-streamer.event-loop
0  libsystem_platform.dylib       0x206009a0 _platform_memmove + 159
1  MyApp                     0xd3acf audio_file_read (DOUAudioPlaybackItem.m:88)
2  AudioToolbox                   0x228f3f63 Seekable_DataSource::ReadBytes(unsigned short, long long, unsigned long, void*, unsigned long*) + 230
3  AudioToolbox                   0x228e6b67 GetFPosForNextSyncWordDS(DataSource*, short&, long long, long long*, unsigned long*, unsigned long*, unsigned long*, double*, unsigned long*) + 526
4  AudioToolbox                   0x228e8edb MPEGAudioFile::ScanForPackets(long long, DataSource*, bool) + 382
5  AudioToolbox                   0x228e7593 MPEGAudioFile::ReadPackets(unsigned char, unsigned long*, AudioStreamPacketDescription*, long long, unsigned long*, void*) + 126
6  AudioToolbox                   0x228f05d5 AudioFileReadPackets + 168
7  MyApp                     0xc4a77 decoder_data_proc (DOUAudioDecoder.m:313)
8  AudioToolbox                   0x228a5c95 AudioConverterChain::DirectCallInputProc(unsigned long*, unsigned long*, AudioBufferList*, AudioStreamPacketDescription const**) + 252
9  AudioToolbox                   0x228a5ac9 CodecConverter::CallInputProc(unsigned long&) + 212
10 AudioToolbox                   0x228e40ad CodecConverter::DecoderFillBuffer(unsigned long&, AudioBufferList&, AudioStreamPacketDescription*) + 628
11 AudioToolbox                   0x22894153 AudioConverterChain::RenderOutput(CABufferList*, unsigned long, unsigned long&, AudioStreamPacketDescription*) + 82
12 AudioToolbox                   0x22894083 BufferedAudioConverter::FillBuffer(unsigned long&, AudioBufferList&, AudioStreamPacketDescription*) + 342
13 AudioToolbox                   0x228a10a7 AudioConverterFillComplexBuffer + 354
14 MyApp                     0xc4929 -[DOUAudioDecoder decodeOnce] (DOUAudioDecoder.m:380)
15 MyApp                     0xab69b -[DOUAudioEventLoop _handleStreamer:] (DOUAudioEventLoop.m:464)
16 MyApp                     0xab973 -[DOUAudioEventLoop _eventLoop] (DOUAudioEventLoop.m:532)
17 MyApp                     0xaba21 event_loop_main (DOUAudioEventLoop.m:544)
18 libsystem_pthread.dylib        0x20606c7f _pthread_body + 138
19 libsystem_pthread.dylib        0x20606bf3 _pthread_start + 110
20 libsystem_pthread.dylib        0x20604a08 thread_start + 8

Do you repaired this bug? it's also happened in my app,it worked good in background，but if i locked the screen，crashed many seconds after...


⚠ Bofrost.de has degraded performance

In afd50b6, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1416 ms

Resolved: Bofrost.de performance has improved in 13ab1e6.


Basic TransitionMotion

I'm trying to animate in/out a single component when mounted, however am struggling to find a basic example that doesn't animate a list/internal state/etc.
I might be misunderstanding how react-motion works, is this possible in a simple way?

// Transition container
class Transition extends React.Component {
  willLeave() {
    return {opacity: spring(0)}
  }

  willEnter() {
    return {opacity: spring(1)}
  }

  getStyles() {
    return [{key: 'one', style: {opacity: spring(1)} }]
  }

  render() {
    return (

        <TransitionMotion styles={this.getStyles()} willLeave={this.willLeave} willEnter={this.willEnter}>
          {int =>
 hello there
}
        </TransitionMotion>

    )
  }
}

// Main container
export default class Container extends React.Component {
  constructor(){
    super()
    this.state = {
      openCard: false,
    }
  }

  openCard(props) {
    this.setState({ openCard: !this.state.openCard })
  }

  render() {
    return
 {this.state.openCard ? <Transition/> : null }

    )
  }
}

I am using it for Route transitions, which is essentially the same thing (swapping out a single component). Here is my full RouteTransition component:
import React from 'react';
import { TransitionMotion, spring } from 'react-motion';

const willEnter = () => ({
  opacity: 0,
  scale: 0.98
});

const willLeave = () => ({
  opacity: spring(0),
  scale: spring(1.02)
});

const getStyles = () => ({
  opacity: spring(1),
  scale: spring(1)
});

const RouteTransition = ({ children: child, pathname }) => (
  <TransitionMotion
    styles={ [{
      key: pathname,
      style: getStyles(),
      data: { child }
    }] }
    willEnter={ willEnter }
    willLeave={ willLeave }
  >
    { (interpolated) =>

        { interpolated.map(({ key, style, data }) =>
          <div
            key={ `${key}-transition` }
            style={ {
              ...styles.wrapper,
              opacity: style.opacity,
              transform: `scale(${style.scale})`
            } }
          >
            { data.child }

        ) }

    }
  </TransitionMotion>
);

var styles = {
  wrapper: {
    position: 'absolute',
    width: '100%'
  }
};

export default RouteTransition;

It is used like this:
<RouteTransition pathname={ location.pathname }>
  { this.props.children /* current route component */ }
</RouteTransition>

Hmm i've reused what you've suggested, however it doesn't seem like 'willEnter' and 'willLeave' are being triggered. The component is mounted, but no animation takes place.
  const willLeave = () => ({
    opacity: spring(0)
  })

  const willEnter = () => ({
    opacity: 0
  })

  const getStyles = () => ({
    opacity: spring(1)
  })

const Transition = ({ children, key }) =>

<TransitionMotion
    styles={[{ key: 'key', style: getStyles(), data: children }]}
    willLeave={willLeave}
    willEnter={willEnter}>
      { int =>

          {int.map(({ key, style, data }) =>
            <div key={`${key}-transition`} style={{opacity: style.opacity}}>
              {data}

          )}

}
  </TransitionMotion>

Do you think it might have something to do with the way I'm using it?
        {this.state.openCard ? <Transition>
Hello There
</Transition> : null }

Thanks for your help!

You are removing the Transition component when this.state.openCard is false. Try:
<Transition>{this.state.openCard ?
Hello There
 : null }</Transition>

Still isn't working as expected!  what version of react-motion are you using?

Still isn't working as expected! what version of react-motion are you using?

**Disclaimer: I have only begun programming a few months ago so take everything with a grain of salt.
**
I believe TransitionMotion needs to receive dynamic changes for it to trigger.
{this.state.openCard ? <Transition>
Hello There
</Transition> : null }
This would just render the Transition component and neither TransitionMotion nor it's container animates itself.  Only TransitionMotion's children are animated if they receive dynamic changes, state/props.
<Transition>   { this.state.openCard ?
Hello There
 : null } </Transition>
Transition is not receiving any changes that would incur it to animate, that is because the RouteTransition component is the one that gets animated, not the child directly, so you have to pass dynamic data to RouteTransition component to get the animation to trigger.
So if you were to pass different children dynamically or a different key like key: Date.now() + 'coerceToString' it would trigger a render which would trigger the animation.
The way TransitionMotion itself works is a bit harder for me to grok since it keeps a removed child around until the component reaches the willLeave's  value so I am unable to confirm the required uniqueness of key, whether it can be a unique but static value.
I hope someone will provide a better response as I hope to understand how TransitionMotion works as well.

My component is guaranteed to have a child, but yours isn't.
// this array should be empty if there are no children
styles={[{ key: 'key', style: getStyles(), data: children }]}

You would have to do something like:
styles={ children ? [{ key: 'key', style: getStyles(), data: children }] : [] }

Perfect, working now! thank you both for your help

What is the full example? I'm strugling to piece it together from above.

const willLeave = () => ({
opacity: spring(0)
})
const willEnter = () => ({
opacity: 0
})
const getStyles = () => ({
opacity: spring(1)
})
const Transition = ({ children }) =>
<TransitionMotion
styles={ children ? [{ key: 'key', style: getStyles(), data: children }] : [] }
willLeave={willLeave}
willEnter={willEnter}>
{ int =>

{int.map(({ key, style, data }) =>

{data}

)}
}


Test : Rename null safety strong mode flag

Currently the null safety strong mode flag is controlled by the flag --no-null-safety / --null-safety.
From offline discussion, we find that this is suboptimal: When a developer opts out of sound/strong checking with --no-null-safety they will still get some null safety (e.g. static analysis), but the flag name makes it sound like they are loosing all of null safety.
We'd thus like to rename this flag to --no-sound-null-safety / --sound-null-safety.
Source for --no-null-safety
Source for --null-safety

@munificent  Can you help assign this to the right person?

Sorry for the delay. I'm not sure what the task is here. What tools is this about?

Sorry for the delay. I'm not sure what the task is here. What tools is this about?

I think there are test or test related files that has the old flag that need a search and replace.

The test runner doesn't have a separate flag for this. Instead, it has three modes:
--nnbd=legacy // Opted out.
--nnbd=weak // Opted in, weak checking.
--nnbd=strong // Opted in, string checking.

I can change this if you think it's important, but this tool is only used internally by people on the Dart team, so I don't think it adds much value.

@mit-mit WDYT?

Closing this because I don't think we plan to or need to take action on it.


Missing lower bound in normalize_electrostatics

Hi,
Thank you for this great repository, it has been very useful so far. Working with it, I noticed an issue as highlighted below in the following function:
https://github.com/LPDI-EPFL/masif/blob/0657ec97cf9a0162988e172d08376f459f0f8689/source/masif_modules/read_data_from_surface.py#L251
The electrostatics are upper-bounded to 3, but not lower-bounded to -3. I don't think this was intentional.

Dear vsomnath,
Sorry for the late reply!
Indeed this is  a bug! I think the impact shouldn't be too large, because the magnitude of the values was already decreased by a factor of 10, but I will retrain just in case to see if it changes a lot.
Thank you very much!!


Fix a mini memory leak in Bytes on a racy promotion from vec to arc

Hi,
I was looking around trying to understand the implementation of Bytes when I found something that puzzled me in fn shallow_clone_vec(...)
https://github.com/tokio-rs/bytes/blob/ed1d24e57079a86c6201b5fd6be6f789265f0e6a/src/bytes.rs#L1042-L1047
It seems that this code create a memory leak (ref_cnt: AtomicUsize::new(2) is not deleted).
Or maybe I missed something,  in this case maybe a more explicit comment may be welcomed.
I created a PR to fix this leak.
This this just to make this code more correct - because this leak is tiny add should be rare (only when the promotion from arc to vec is performed by several threads at the same time)

Thanks for the PR. I will try to review early next week. However, I would recommend adding a loom test to validate the original leak and the fix. Loom (github.com/tokio-rs/loom) is able to test the rare edge conditions. I think there already are loom tests in the repo, but if you aren't able to figure it out, I (or someone else) can provide more guidance next week.

I think the code doesn't currently leak. Theres a move out of the box, which will free it. And then we forget the shared on the stack.

Yes, I missed the point of the move of the Shared on the stack; and because only the _vec member implement Drop everything is fine.
Sorry for the disturbance.
By the way, thanks for your quick feed back and for all the great job done on those valuable components.
Should I close this PR or you will handle this?

No worries, I can close it. Better to report when unsure than to ignore a mem leak :+1:


Use Bool.asProp for coercions

Fixes #2043.

Required mathlib changes are manageable, as expected: https://github.com/leanprover/std4/compare/pr2060?expand=1 https://github.com/leanprover-community/mathlib4/compare/pr2060?expand=1

!bench

I really like this but please post something on Zulip when merging since this looks like some significant update changes. A few quick hints might help too. Please remember that mathlib is not the only thing downstream 😄


Remove wait from excluded dependencies

After upgrading from 1.14.3 to 1.15.1, I am getting this error:
The import org.testcontainers.containers.wait.Wait cannot be resolved

It seems like this comment in the build.gradle was ignored before the latest release:
https://github.com/testcontainers/testcontainers-java/blob/1.15.1/core/build.gradle#L92
Any chance you can re-include them?

It was deprecated for many releases and got removed.
Use org.testcontainers.containers.wait.strategy.Wait instead.

I see, thanks!  👍


Hello World in Java by Zach

What the program do ?
It prints out Hello World
In what programming language it is written?
java

This pull request do not contains files in specific folders. Please fix it and reopen

Ok, I will fix that. Sorry about that.
On Tue, Oct 16, 2018, 10:48 AM aniket sharma<EMAIL_ADDRESS>wrote:

Closed #3411 https://github.com/Hacktoberfest-2018/Hello-world/pull/3411
.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Hacktoberfest-2018/Hello-world/pull/3411#event-1907044404,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Af2Ur_RB8_MhD-Qavs8F0Mg9wo0WBLyJks5ulfGwgaJpZM4Xcf5g
.

I'm sorry to bother you, but this is my first time doing this. How do you
reopen a pull request? I tried searching online but I got no definitive
answer. Most said that I can't reopen a pull request if I am not the owner.
Thanks,
Zach
On Tue, Oct 16, 2018, 10:50 AM szmu chen<EMAIL_ADDRESS>wrote:

Ok, I will fix that. Sorry about that.
On Tue, Oct 16, 2018, 10:48 AM aniket sharma<EMAIL_ADDRESS>wrote:

Closed #3411
https://github.com/Hacktoberfest-2018/Hello-world/pull/3411.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Hacktoberfest-2018/Hello-world/pull/3411#event-1907044404,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Af2Ur_RB8_MhD-Qavs8F0Mg9wo0WBLyJks5ulfGwgaJpZM4Xcf5g
.

Ok, thanks.
On Tue, Oct 16, 2018, 12:27 PM aniket sharma<EMAIL_ADDRESS>wrote:

hey you have to open a new pull request with a fixed version of your
branch you can directly fix in your forked repo and open a pull request
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Hacktoberfest-2018/Hello-world/pull/3411#issuecomment-430304653,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Af2Ur37RKtyu-MiBj6HSBJn2r4ss_lzqks5ulgjygaJpZM4Xcf5g
.


Firebase 3.x API with Emberfire 2.x fails to authenticate using Torii

I am upgrading an app that has used Emberfire 1.x (and using the Firebase 2.x API) to the latest and greatest. To my great disappointment, I can not authenticate using the Emberfire/Torii combination. The error I get is:

TypeError: Cannot read property 'open' of undefined

And more explicitly, it appears this is the code sequence that is failing:

The provider is set to 'firebase' and the options is set correctly with:
{
  provider: 'password',
  email: email,
  password: password
}

I had seen somewhere in the discussion of other issues that some people were having problems explicitly with ember-source 2.13.0 so I tried reverting to 2.12.2 where it had been working with emberfire 2.x API but the problem seems to be identical.

I can now verify that moving back to Ember 2.11.3 does bring this back to a working state. That is true for emberfire 2.x and 1.x (and the corresponding Firebase version).

I guess the mechanism for getting owner or factory has been changed in Ember 2.13.

@Cryrivers yes i believe that is right. Specifically I think they enforce the official way of doing it (now that there is one). The official is just off of Ember:
Ember.getOwner(this).lookup('service:xxxxx');

What's the status of this? Has it been updated to work with ember 2.13? Happy to submit a PR if not. Currently locked at 2.12.0, anything above that throws this exact torii error.

+1

Also seeing this issue. Perhaps related to this? https://emberjs.com/deprecations/v2.x/#toc_migrating-from-_lookupfactory-to-factoryfor

+1

+1

Seems like it;s actually a torii issue, Ive started using this user's torii fork and it works perfectly on 2.13.1 https://github.com/Vestorly/torii/pull/355

Good to know. Fingers crossed the PR is brought in soon.

released in 0.8.3 of torii this afternoon 🎉

Any ideas when ember fire will upgrade to 0.8.3?

@QuantumInformation I'll take a peek at this when I introduce Firebase 4.0 support, as it will have some API changes. Should have some time in the next week, though I still need to get access to our build system.
In the meantime, happy to accept PRs :)

I don't know this for sure but I had thought that the API changes were pretty non-existant between 3.x and 4.x.

I'm still getting that error on authentication via google provider after choosing account for authentication.
"The Torii adapter must implement open for a session to be opened"
Ember  2.13.4
Ember Data : 2.14.9
Firebase   : 3.9.0
EmberFire  : 0.0.0
Torii 0.9.5

@jamesdaniels I'm really excited for that 4.0 support, when I saw you pushed something up earlier. :+1: