fix(keys): refactor retrigger mechanism

should fix #286.

I did already fix that, no?
I use mini.ai myself with those keybiondings and it works as expected

yes, you fixed the main problem. However consider this case:

you have the string "hello"
if you try to ciw with the cursor on the character h, you'll actually end up performing the action on the previous character " which happens to be a word in vim

I suspect this happens because c operator enters insert mode so when you retrigger to re-enter normal mode, the cursor shifts backwards by one position.

I've got a possible different fix in this branch

Thank you for the clarification. Will need to check this PR with some issues from the past related to keymaps.
I'm  also not that sure of the vim.schedule in there

Yeah. I agree with the sentiment about using vim.schedule.
I've got another solution via this branch which uses expr and remap to retrigger the original keymap.

I implemented the solution you propose a while back, but it failed some issues people had in the past. Although, I did not add that <ignore>.
What I'll do first, I'll add a bunch of unit tests for those issues I'm talking about, so we have something to test this with. Will do so on Monday.

Understood. From my various "tests" it works pretty well:

loading multiple plugins with one keymap. e.g gzaiw[char] loads mini.surround then mini.ai for me
count works as expected

yes, you fixed the main problem. However consider this case:

you have the string "hello"
if you try to ciw with the cursor on the character h, you'll actually end up performing the action on the previous character " which happens to be a word in vim

I suspect this happens because c operator enters insert mode so when you retrigger to re-enter normal mode, the cursor shifts backwards by one position.

When will this pr be merged?
I also encountered this issue.

I still need to check existing issues related to keymaps and make sure they still work as expected. If you want to help, add a comment to this PR linking to existing issues I should re-check with this PR

AFAICT, these are the more relevant issues regarding the keys handler:

#308
#307
#286
#252
#71
#28

All of these seems to be fixed using neovim master but not on neovim stable (0.8.x). Particularly:

keys need to be pressed twice(sometimes)

Upon opening neovim, When I perform any(literally) action, subsequent registered keys need to be pressed twice to trigger

keys are pasted when triggering in visual mode.

ok, thanks. I'll try to look into it later today. I do think the pending keys probably need to be added to your PR, but I'll see if it's needed when I encounter issues

I checked all existing issues and these changes indeed seem to work for all of them. Thanks for fixing this!

Happy to help! Though I did mention that there were some issues with neovim stable. Were you able to verify this?

It all seemed to work for me on stable. What issue in particular didnt work on stable for you?

This one seems to work on nightly, but not on stable. https://github.com/folke/lazy.nvim/issues/511
Will look into it


Battery Percentage is not showing correctly in Taskbar Icon

I am using latest 2.1.5 version of Battery Percentage Icon and facing this issue. The battery of my laptop is 30% but it shows 78%. I have attached some screenshots and details below for the reference.
App version: 2.1.5
Runtime version: .NET 9.0.0
Runtime architecture: win-x64
Screenshot 1: Battery Percentage shown in Windows Settings along with taskbar with Battery Percentage Icon

Screenshot 2: Details tab of Battery Percentage Icon (Showing correct battery percent) along with taskbar Icon

Screenshot 3: About tab of Battery Percentage Icon

Laptop was not awake from sleep or hibernate neither did signout, still getting this issue. Also sometime the icon disappears i.e. the app stops automatically.

I am also facing the same issue.


[sw/host/opentitanlib] Add SFDP signature check

My CW310 FPGA is producing 256 0xff bytes for the SFDP buffer instead of
something valid. As a result, we're parsing a signature of 0xffffffff
instead of the expected 0x50444653.
This commit changes Sfdp::try_from() to fail fast with an informative
error message about the invalid header, rather than blunder on and fail
farther down the line with "attempt to add with overflow".
Fixes #13477
Signed-off-by: Dan McArdle<EMAIL_ADDRESS>

OK, that round of review should be done. Merge at your convenience!

(Really done now. The last push just updated the commit message to include Fixes #13477 like the PR description does.)

sorry just to chime in a bit, is the SFDP failure by any chance a bug with the spi_device that only manifests in fpgas..?
or have you guys tracked it down to something else already?

Haven't tracked it down yet, but I left issue #13477 open for that purpose!

sorry just to chime in a bit, is the SFDP failure by any chance a bug with the spi_device that only manifests in fpgas..?
or have you guys tracked it down to something else already?

I wouldn't expect this to be a widespread issue since we are using the same protocol everywhere to catch issues like this as early as possible. CI seems to be OK.


Parsing of headings in MediaWiki changed

The parsing of headings with non ASCII characters changed. For example == Übungsaufgaben == is now parsed to

 Übungsaufgabe

Because of this we have two bugs

[x] The  needs to be removed from the html
[x] The excluding of some headings does not work any more

Argh, this is why we need our own parser :P

should be fixed now.

So the typo fix (1d60509b3065a49c85a874c109260fb63b6c9fe7) solved the problem that sections were not excluded anymore?

As far as I can tell.. The example book looks correct to me.


missing AppModuleNgFactory

The main.aot.ts has a dependency to './app/app.module.ngfactory' but there is no such a file in this directory

This is causing not compiling on dev, I don't know why but it throws me the error that AppModuleNgFactory does not exist (and it is right) I'm running npm run build:dev and at the end is not compiling due to the lack of this file...


New VZ cli repository

Sets up barebones for cli repo:

pre commits
yarn
github deployment
eslint
typescript
1 cli command for vz-combine-legal-csv

@giacaglia we could - but in some repos we add it because it speeds things up

Got it!

@dmattia @giacaglia could i get an approval?


Public Comment: Create a Link between Map and Data using Study Areas

Create View Map option from Parking Data page that switches page to Parking Map and zooms to selected Study Area.

hold

When I select a Study Area and View Map, the home page is presented. If I click go back, then I see the map zoomed into the Study Area I selected.

Issue has been resolved.


fix typo

Can one of the admins verify this patch?

Coverage decreased (-0.1%) to 66.101% when pulling cf2a7c6eeddd8baf21ae91901f6f18bce2b65b0c on chlins:master into 0273d736808cb9272cf1013646baec892b84dc40 on go-chassis:master.


Passenger fetching

As a user, I would like the option of being "tracked down" via my mobile, and reminded that my flight is boarding/departing soon if I'm elsewhere in the airport and lost track of time.

Similar to Singapore's 2020 program but more reliant on technology than personnel.


[arrow] Update to 12.0.1

[x] Changes comply with the maintainer guide
[x] SHA512s are updated for each updated download
[x] The "supports" clause reflects platforms that may be fixed by this new version
[x] Any fixed CI baseline entries are removed from that file.
[x] Any patches that are no longer applied are deleted from the port's directory.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is added to each modified port's versions file.

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

Tested all feature on the following triplets:

x64-windows
x86-windows
x64-windows-static


Support path or filename which inclued chinese character.

paddleX or Gui ,doesn't support path or filename which inclued chinese character.
According to the lint given by the error info, I just changed the file
https://github.com/PaddlePaddle/PaddleX/blob/7acf4f36eabef8d892a63b4e0ac86562df68a30f/paddlex/cv/transforms/det_transforms.py#L112
to use the fuction following
def read_image_bgr(path):
    image = np.asarray(Image.open(path).convert('RGB'))
    return image[:, :, ::-1].copy()

i don't know whether this works ok or not.
Suposing to fix it, especially the GUI used pyd.

paddleX or Gui ,doesn't support path or filename which inclued chinese character.
According to the lint given by the error info, I just changed the file
https://github.com/PaddlePaddle/PaddleX/blob/7acf4f36eabef8d892a63b4e0ac86562df68a30f/paddlex/cv/transforms/det_transforms.py#L112
to use the fuction following
def read_image_bgr(path):
    image = np.asarray(Image.open(path).convert('RGB'))
    return image[:, :, ::-1].copy()

i don't know whether this works ok or not.
Suposing to fix it, especially the GUI used pyd.

Thanks for your suggestion, I'll try your method in PaddleX to see if this problem can be solved. But in PaddleX-GUI, it involves lots of problems with chinese character, we are still working on it.


Bump :lang markdown

Bump :lang markdown
https://github.com/jrblevin/markdown-mode/commit/051734091aba17a54af96b81beebdbfc84c26459 -> https://github.com/jrblevin/markdown-mode/commit/ac9ea26b941eef512a3c206375a6404625c229ed
https://github.com/seagle0128/grip-mode/commit/98d566db769b865f102a0c6802a08ebce8ae5e7f -> https://github.com/seagle0128/grip-mode/commit/28552059c4643f571ef0883ad543270a48241572

Sorry, I just read the commit message format. Already rebased and should be fine now.

Thanks for the help! And for adhereing to the bump commit format!


DynamicData is not working properly when classes have empty constructor and private setters. version 2.2.6 onwards

Description
When you use dynamic data of a class with an empty constructor and a private setter, the value is of the property is reset to default value (null,0,mindate,etc)
Steps to reproduce
Create a class with an empty constructor and a private setter property, and use it in dynamic data:
        public static IEnumerable<object[]> TestCasesClass2()
        {
                 yield return new object[] { new Class2("1", 1, new DateTime(1, 1, 1)) };
        }

        [DynamicData(nameof(TestCasesClass2), typeof(DynamicDataTest), DynamicDataSourceType.Method)]
        [DataTestMethod]
        public void TestDynamicDataClass2(Class2 item)
        {
            Assert.AreEqual(new DateTime(1, 1, 1), item.Date);
            Assert.AreEqual(1, item.Num);
            Assert.AreEqual("1", item.Str); // **this line fails because Class2.Str has a private setter and an empty constructor**
        }

Expected behavior
it should work as it does in version 2.2.5 and lower - values should be as they were created in the testCaseMethod
Actual behavior
values are reset to default value (null,0,mindatetime,etc)
Environment
Tests code is exactly the same except for the version of the nugets

repo with sample code can be seen at:
https://github.com/eliranShema/mstestDynamicDataIssue

Hi,
This is expected since since the data you provide must be serializable. You can opt-out of this behavior as described https://github.com/microsoft/testfx/issues/905#issuecomment-907775327 by adding following to your solution:
[assembly: TestDataSourceDiscovery(TestDataSourceDiscoveryOption.DuringExecution)]


Logs are still created when log level = off

Issue: Logs (specifically es_launch_stderr.log and es_launch_stdout.log) are still created when the log level is set to off. In fact, it seems to be stuck in verbose mode.
Reproduction: Go to MAIN MENU -> SYSTEM SETTINGS -> FRONTEND DEVELOPER SETTINGS -> LOG LEVEL , then launch a game. The log files will be created at system/logs.
I'm putting it under here as it's ES itself which is producing these logs. But do let me know if this issue report would be more appropriate on Batocera's issue tracker instead.

es_launch_stderr.log and es_launch_stdout.log are not emulationstation logs, but configgen logs.


Possible solution to Issue #698 (Custom ProvisiningExtensibilityHandl…

Q
A

Bug fix?
yes

Related issues?
fixes #698

What's in this Pull Request?
This PR is a propossed solution for issue #698
This code was wrong, as doing the Union with OfType resulted in an empty collection, as the custom handler was implmenting the new interface.
foreach (var handler in template.ExtensibilityHandlers.Union(template.Providers).OfType<Provider>()

Also, in the ExtensibilityManager class, there was an issue with this header:
public IEnumerable<TokenDefinition> ExecuteTokenProviderCallOut(ClientContext ctx, Provider provider, ProvisioningTemplate template)

as the Provider object was wrong, and it has to be a ExtensibilityHandler object.
I'm not checkeing if the custom Handler is using the new or the old interface here, as the Tokens thing is only supported by the new interface, so here we never hit with an old Provider object.
Hope that makes sense.
Thanks!

Hi Luis,
Thanks for your contribution. The proposed solutions makes sense and looks good. Merged!

Many thanks Paolo !


Return virtual index when creating and getting a log entry

Use the virtual index when signing an entry on creation, and return that to the end user.
There shouldn't be any observable difference here at the moment, until we actually shard the log.

Summary

Ticket Link

Fixes
Release Note

Codecov Report

Merging #725 (ed27e97) into main (982ebd7) will increase coverage by 0.11%.
The diff coverage is 72.72%.

:exclamation: Current head ed27e97 differs from pull request most recent head cae670c. Consider uploading reports for the commit cae670c to get more accurate results

@@            Coverage Diff             @@
##             main     #725      +/-   ##
==========================================
+ Coverage   47.56%   47.68%   +0.11%
==========================================
  Files          65       66       +1
  Lines        5670     5681      +11
==========================================
+ Hits         2697     2709      +12
+ Misses       2683     2681       -2
- Partials      290      291       +1

Impacted Files
Coverage Δ

pkg/sharding/log_index.go
72.72% <72.72%> (ø)

pkg/types/tuf/v0.0.1/entry.go
43.82% <0.00%> (+0.74%)
:arrow_up:

pkg/types/alpine/v0.0.1/entry.go
62.01% <0.00%> (+0.77%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 982ebd7...cae670c. Read the comment docs.

/hold

hey @bobcallaway for sure, made a couple changes:

removed the pointer from api.logRanges so it can't be modified
made logRanges.ranges private so it can only be accessed/modified via function call

I'm testing this branch on top of #623 and got an index of 0 even though I have a few populated shards already:
[rekor@fedora rekor]$ rekor-cli upload --artifact tests/testfile06.txt --signature tests/testfile06.txt.sig --pki-format=ssh --public-key=/home/rekor/.ssh/id_rsa.pub --rekor_server http://<IP_ADDRESS>:3000
Created entry at index 0, available at: http://<IP_ADDRESS>:3000/api/v1/log/entries/7a9cbf47251dff69ed600735513c7ead7a7fe9d6d0c127581707031a352bc45d7d823db5a42e0345

I may be doing something wrong, though, my brain is a bit fried. If you don't mind waiting to merge until I can double check on it tomorrow, that would help!

@lkatalin lmk if it still isn't working. I tried with #623 and it seems to be working as expected for me.

It was user error / usage ambiguity: I was not manually passing in a logRangeMap, only a tlog_id, and so the VirtualLogIndex() did not detect multiple shards. I think we should implement a way to build up the logRangeMap internally to avoid problems like this (the user could still pass it in on the CLI at startup as well but tbh this would become redundant as there's no meaningful manual "override" for the actual shard map).

I can rebase #727 on top of this once it's merged.

@bobcallaway is this good to merge now?


[RFC] Allow taking draft orders into vouchers usage calculations

Problem
We aim to optionally calculate and validate vouchers within draft orders. While it's currently possible to add vouchers to these orders, they aren't computed as used.

1. General Assumptions
The proposed solution should build upon the current VoucherCode implementation. This strategy is chosen to avoid conflicts since the VoucherCode framework changes the manner we handle vouchers details.
Acceptance Criteria

Functional use case:

Error handling: Voucher related errors should be handled accordingly.
Other use-cases: Voucher codes can be used to identify voucher validity.

2. API changes
Mutations

Code Reference: saleor/graphql/order/mutations/draft_order_create.py

class DraftOrderInput(BaseInputObjectType):
    # deprecate old voucher field
    voucher = graphene.ID(
        description="ID of the voucher associated with the order.", name="voucher"
    )
    # new field
    voucher_code = graphene.String(description="Code to use the voucher.")

Extend validation in to return proper information about vouchers.

Code Reference: saleor/graphql/order/mutations/draft_order_complete.py

class DraftOrderComplete(BaseMutation):
    def perform_mutation(self):
        validate_draft_order(order, country, manager)

Types
Extend Channel.order_settings with new include_draft_order_in_voucher_usage field
class OrderSettings(ObjectType):
    include_draft_order_in_voucher_usage = graphene.Boolean(
        required=False,
        description=(
            "Turn this on to instantly apply vouchers to draft orders."
            "Please be careful, as this will reserve the voucher and might affect the time it takes for users to complete their transactions."
        ),
    )

This will be added while using npm run build-schema

type OrderSettings {
    includeDraftOrderInVoucherUsage: Boolean!
}

3. Database changes
Migration is needed to provide new field for our flag.

Code Reference: saleor/channel/models.py

class Channel(ModelWithMetadata):
    ...
    include_draft_order_in_voucher_usage = models.BooleanField(default=False)

This step also involves changes in saleor/graphql/channel/mutations/utils.py populating particular settings needs to be reflected in whole application.
Recently settings was changed from global to per Channel, this is the new approach in Saleor and should be reflected in that way.

4. Changes in the code

draftOrderCreate and draftOrderUpdate mutation already enables voucher assignment. However, there's a need to enhance its functionality to ensure the voucher hasn't been previously utilized. This requires the following:

Augment the validation on the voucher field in DraftOrderCreate/DraftOrderUpdate. Utilize clean_voucher() to verify the voucher's status.
clean_voucher()

Update voucher usage statistics when it's integrated into a draft order. For the correct computation and application of discounts, adjust the perform_mutation function in the DraftOrderComplete mutation. This requires a function similar to _process_voucher_data_for_order().

Code Reference: saleor/checkout/complete_checkout.py

  def _process_voucher_data_for_order():
      if voucher.usage_limit:
          ...
      if voucher.apply_once_per_customer:
          ...

and adjusting validate_draft_order() function to return proper validation errors.

Adjustments are required to modify voucher usage metrics when a draft order is expunged. Specifically, the DraftOrderDelete mutation's perform_mutation function should be adapted to utilize our flag, determining voucher calculations. While release_voucher_usage was the initial function, in the current VoucherCode version, it's replaced by release_voucher_code_usage.

Code Reference: saleor/discount/utils.py

release_voucher_code_usage()

5. To Do list
### Tasks
- [ ] https://github.com/saleor/saleor/issues/14120
- [ ] https://github.com/saleor/saleor/issues/14178
- [ ] https://github.com/saleor/saleor/issues/14179
- [ ] https://github.com/saleor/saleor/issues/14180
- [ ] https://github.com/saleor/saleor/issues/14181
- [ ] https://github.com/saleor/saleor/issues/14287

6. To Test

[ ] Verify the proper calculation of vouchers in draft orders.
[ ] Validate the correct error handling for voucher-related issues.
[ ] Ensure compatibility with existing voucher codes and systems.
[ ] E2E validate one per customer functionality added by admin then check if user gets validation error that this voucher was already used.

Other

Checkout mutations that are involved with vouchers should recognize the new site settings. Given that draft orders don't currently contain a direct checkout, the CheckoutCreateFromOrder mutation can potentially instantiate a checkout from a draft order. It's pivotal to evaluate and discuss the appropriateness of this approach.

👍 from me

Ad. 3.
Should we use OrderSettings instead of CheckoutSettings?
Should we store this field in OrderSettings instead of Channel?

@fowczarek changed. The setting will be added to Channel.order_settings

We should also consider what should happened when include_draft_order_in_voucher_usage is changing from True to False. IMO we should decrease voucher usage for all orders that are draft


[Bug] Screen Height wrong when Android Notch is activated

When the Android Notch is activated on the device the returned 'Screen Height' is not considering the notch size. So if you are using this size to make a screen animation for example. It will not work correctly.

It has been fixed on version 1.0.6
implementation 'com.mctech.library.keyboard:visibilitymonitor:1.0.6'
implementation 'com.mctech.library.keyboard:visibilitymonitor-ktx:1.0.6'


deprecate or warn about downloads over unencrypted HTTP

Describe the problem you are trying to solve

In light of recent developments in the Java ecosystem I think Rust should follow that and also mark "http" sources as deprecated or warn about them in some way.
Describe the solution you'd like

Correct me if I'm wrong here, but pulling sources from http:// instead of directly from crates.io, likely via git does require putting it in its own Toml section either way, right?
One could then require a switch similar to allow-unencrypted-http = true.
In a first step just outputting a warning/deprecation notice if this is not set but the source is http:// should be fine, and after some time one could then switch to this aborting the build.
Notes

This would in the second stage break builds, with the fix being a configuration option.

Hi,
In case this issue land into the git tree, it is probably a good idea to keep http download when we can provide a signature hash to verify the integrity of the file after download, because https is expensive and the issue is the absence of integrity check somewhere, and https is a mitigation that is not perfect with regard to that.

An opt-in https mode would resolve this and not break environments which require insecure connections.
A warn would encourage better practices.

This sounds good to me. Once Cargo gets https://github.com/rust-lang/cargo/issues/12115 landed and has its own lint control system, we could start rolling out this kind of warning.


Laravel 10 support :)

Hey, I noticed the composer.json doesn't allow laravel/framework 10 as of yet. Is this something you need help with? I reckon it's mainly adding ^10.0 to laravel/framework in composer.json :)

As mentioned this package isn't actively maintained or supported anymore. I just merged a PR that ads L10 support.

thanks nonetheless :D


Incorrect file is selected and renamed when using keyboard arrows and keyboard context menu to select file for renaming

VSCode Version: 1.52.1
OS Version: Windows 10 Pro 10.0.19042

Steps to Reproduce:

Open folder with project containing .gitmodules
Rename one of any files (except .gitmodules) by clicking it directly with the cursor
Select any other file (except .gitmodules) by using arrows
Open context menu by using keyboard context menu key
Select Rename option and hit Enter

Does this issue occur when all extensions are disabled?: Yes

Result
No matter what file is selected using keyboard, the .gitmodules file is being selected and renamed.
Even though the focus is on the selected file.
See the following:

/duplicate of #100151 and is fixed in 1.54 Insiders


2.0 branch

Hi, i did some work for making AssetCompress compatible with 2.0 CakePHP branch. Please, take a look if it could be merged in.
Needs some testing, though, because now I have only Windows box available.

This has all been merged in :)

Nice =)


[Q] ModuleNotFoundError: No module named 'wandb.keras'

hey! I am using wandb==0.15.3 and keep getting a ModuleNotFoundError when trying to execute
from wandb.keras import WandbMetrcsLogger.
When trying to execute
wandb.login()
I am getting an AttributeError:
module 'wandb' has no attribute 'login'
Both code chunks used to work a month ago within the same conda environment. Am I missing something?
I appreciate any help!

Hi @marlens123 thanks for reporting this issue. Could you please try to do the following two things then try to run the script again:

Check to see if there is a wandb.py within the same directory that may be conflicting with wandb and move the file into a different directory

Uninstall and reinstall wandb in same virtual environment

Would any of these work for you?

Hi @thanos-wandb thanks for the reply! I have another wandb project set up, though on a different drive. Reinstallation does not help, unfortunately.

Hi @marlens123 sorry this didn't work for you. Could you please provide some more information where you're running your script, is it in your local machine, external cluster or a notebook? Would it be please possible to share a screenshot from your terminal? and also try to list all files in your current working directory and check for any scripts that you might have named them as wandb.py?

WandB Internal User commented:
thanos-wandb commented:
Hi @marlens123 thanks for reporting this issue. Could you please try to do the following two things then try to run the script again:

Check to see if there is a wandb.py within the same directory that may be conflicting with wandb and move the file into a different directory

Uninstall and reinstall wandb in same virtual environment

Would any of these work for you?

WandB Internal User commented:
thanos-wandb commented:
Hi @marlens123 sorry this didn't work for you. Could you please provide some more information where you're running your script, is it in your local machine, external cluster or a notebook? Would it be please possible to share a screenshot from your terminal? and also try to list all files in your current working directory and check for any scripts that you might have named them as wandb.py?

Hi @marlens123 just checking in here to see if that issue still persists for you, or if it's been resolved? Could you please provide us with some additional information requested in previous message? Thank you!

Hi @thanos-wandb sorry for the delayed message! I am running on my local machine and attached my terminal and directory content. Thank you!

Hi @marlens123 thanks so much for reporting this issue. Could you please try to pip install --upgrade wandb as this issue seems to have been resolved in our newer versions?

Hi @thanos-wandb thank you for coming back to me! I just pip upgraded wandb and reactivated the environment, but unfortunately the error still persists:

Hi @marlens123 thanks for trying this. Could you please provide us with your keras and tensorflow versions too?

hi @thanos-wandb, I am using keras==2.10.0 and tensorflow-gpu==2.10.0

Hi @marlens123 I wasn't able to recreate the issue using same wandb, keras, and tensorflow versions. Could you please try to create a new virtual environment and check again? Would the following code work for you?
import random
import numpy as np
import tensorflow as tf
from wandb.keras import WandbMetricsLogger, WandbModelCheckpoint

# Simple Keras Model

# Launch 5 experiments, trying different dropout rates
for run in range(5):
    # Start a run, tracking hyperparameters
    wandb.init(
        project="keras-intro",
        # (optional) set entity to specify your username or team name
        # entity="my_team",
        config={
            "layer_1": 512,
            "activation_1": "relu",
            "dropout": random.uniform(0.01, 0.80),
            "layer_2": 10,
            "activation_2": "softmax",
            "optimizer": "sgd",
            "loss": "sparse_categorical_crossentropy",
            "metric": "accuracy",
            "epoch": 6,
            "batch_size": 256,
        },
    )
    config = wandb.config

    # Get the data
    mnist = tf.keras.datasets.mnist
    (x_train, y_train), (x_test, y_test) = mnist.load_data()
    x_train, x_test = x_train / 255.0, x_test / 255.0
    x_train, y_train = x_train[::5], y_train[::5]  # Subset data for a faster demo
    x_test, y_test = x_test[::20], y_test[::20]
    labels = [str(digit) for digit in range(np.max(y_train) + 1)]

    # Build a model
    model = tf.keras.models.Sequential(
        [
            tf.keras.layers.Flatten(input_shape=(28, 28)),
            tf.keras.layers.Dense(config.layer_1, activation=config.activation_1),
            tf.keras.layers.Dropout(config.dropout),
            tf.keras.layers.Dense(config.layer_2, activation=config.activation_2),
        ]
    )

    model.compile(optimizer=config.optimizer, loss=config.loss, metrics=[config.metric])

    # Add WandbMetricsLogger to log metrics and WandbModelCheckpoint to log model checkpoints
    wandb_callbacks = [
        WandbMetricsLogger(),
        WandbModelCheckpoint(filepath="my_model_{epoch:02d}"),
    ]

    model.fit(
        x=x_train,
        y=y_train,
        epochs=config.epoch,
        batch_size=config.batch_size,
        validation_data=(x_test, y_test),
        callbacks=wandb_callbacks,
    )

    # Mark the run as finished
    wandb.finish()

Hi @marlens123 I wanted to follow up with you regarding your support request as we have not heard back from you. Please let us know if we can be of further assistance or if your issue has been resolved.

Hi @marlens123 since we have not heard back from you we are going to close this request. If you would like to re-open the conversation, please let us know and we will be happy to keep investigating!

This has happened to me with wandb-0.17.0
Solved by importing as:
from wandb.integration.keras import WandbMetricsLogger

@iguillenp Thanks it worked for me in 0.17 version


[REFACTOR] Remove JDBC reference from executor code

Descriptions
Executors are not expected to use jdbc connections. However, we currently are passing JdbcLayerInterface references to them. This creates a few issues:

#398 was caused by this and more bugs may come up in the future.
It is also misleading since executors should not need to make any jdbc connections at all.

Thus, we should refactor the code to remove jdbc references from being passed down to executors, keeping it clean and avoiding future bugs.

See also #324 for a related bug on this issue (and #314 before that, which was resolved).

Downgraded to Normal priority since there is no functional or performance impact.


Porting the code to clojurescript

How difficult will it be to port the code to clojurescript?

One additional (major) problem here is that our tests are using Midje which does not have a ClojureScript port...

+1
Clojurescript support would be really neat !

@xsc
Thought I'd give you a heads up. I'm currently working on a ClojureScript port :)
The good news is that I haven't spent more than a day or so, but got quite a lot of it up and running. The bad news perhaps is that I've gone down the route of creating a rewrite-cljs rather than the cljx route.
A couple of selfish reasons for that;

I have no experience with cljx. With cljc gaining traction/maturity that might be a better option in the longer run.
My primary use case is for using the lib from Light Table to provide clojure/clojurescript refactoring support and perhaps/hopefully better paredit support in LT. LT unfortunately currently uses a very old ClojureScript version, that probably wont change in the very near future.
My current macro foo is very much non-existing (workin on it) (: All macros would have to be extracted into separate clj files I think, and rewritten to emit only valid cljs when targeting ClojureScript. I haven't really had any time yet to see consider how one would best address that
Although I want to make sure I can use the lib from LT, it should of course still not be tied to that in any way, so if someone would like to use the lib from any clojurescript app, they should/would be able to

Since I haven't really commited that much effort into it yet, It's not to late to turn the ship around though.
Several options and I'd like to hear your thoughts !

I continue with a rewrite-cljs (obviously refererring/linking to rewrite-clj). Full freedom for my part, but gives me the headache of trying to keep the lib up to date with your lib. Lot's of duplication etc. Even if we go down this path, I suppose we should/could have the long term goal of back-porting
Opt for cljx. Pull request from me, and you would take ownership of ClojureScript support. (I'd still be contributing given this route of course). A few challenges here though;

Probably quite a bit more effort from me
You would have to be willing to take on the extra effort of supporting cljs !
To keep ones sanity I suppose moving from midje to clojure.test or perhaps expectations for testing might make sense (quite a bit of effort initially ?)
I had to hack the clojurescript reader to support an IndexingPushBackReader ( I used https://github.com/kanaka/clojurescript as a starting point). I saw a tweet from David Nolen yesterday asking for contributions on supporting cljs bootstraped in JS. I guess this would mean potentially a better reader might surface in the not to distant future among other things :)

Opt for cljc. Perhaps the most futureproof option

would limit both clojure and clojurescript version support
many of the same challenges as cljx

Let me know what you think !
cheers
Magnus

@rundis I'd say, go for a 'rundis/rewrite-cljs' (maybe forking this repo so the necessary changes are documented?). Once Clojure 1.7. is out and adoption increases we can have another look at the cljc way.
Thank you for taking that matter into your hands!

Cool !
You can track the progress of your lib's lesser sibling here: https://github.com/rundis/rewrite-cljs

Now that we have both .cljc and a cljs port of tools.reader, any thoughts on moving this forward? As I understand it, .cljc will break compatibility with clj <1.7, and midje will need to go.
Maybe rewrite-cljc deserves its own project?

Now that we have both .cljc and a cljs port of tools.reader, any thoughts on moving this forward? As I understand it, .cljc will break compatibility with clj <1.7, and midje will need to go.

I'm using rewrite-clj in refactor-nrepl and I'd love to see support for consuming cljc files.

Maybe rewrite-cljc deserves its own project?

Most the community has opted to adopt cljc without worrying about consumers running other versions of clojure.  Given that, I don't think the extra effort is warranted.  I tried keeping refactor-nrepl backward compatible but that was completely hopeless if I ever wanted access to new functionality.  Thankfully upgrading clojure to a new version is relatively painless, given core's attention to backward compatibility.

@xsc The world has moved on and Clojure 1.7 and ClojureScript 1.7 is starting to become more and more mainstream. Maybe it's time to bring ClojureScript  support to rewrite-clj.
I think it's worth considering bringing rewrite-cljs back into rewrite-clj (where it belongs imho). rewrite-cljs has had it's place up until now, but it seems wasteful to continue duplicating efforts.
The two projects have diverged somewhat over time, but in essence they are mostly still similar.
what are your thoughts ?

@rundis I agree that adoption has spread and there's nothing speaking against integrating the ClojureScript version (and the Clojure version has generative tests now which should be easier to port to CLJS than the midje ones).
As I wrote in another ticket, I'm currently re-evaluating my projects. Now, rewrite-clj, I wrote it for a specialized purpose - upgrading dependencies in project.clj files - which is covered by the existing functionality; so I'm not as invested in further development as I probably should be. I feel this provides a frustrating experience both to contributors (who I'm very much indebted to) and me.
So, I'll just ask: Seeing the awesome work you've done for rewrite-cljs, would you want to take over this project?

@xsc Sorry for the late reply. I've got to think this through. Since I did rewrite-cljs I've sort of joined the Light Table open source team and have to consider how to handle my already limited spare time.
When I find a chunk of time I can have a shot at bringing rewrite-cljs back into rewrite-clj. If that works out and I feel relatively confident about the codebase in rewrite-clj I'll reassess. If you find someone else willing and capable to take over rewrite-clj that's great :-)

@rundis No problem, and thanks for your reply!

Can this ticket be closed?


Event ID 1201 info incorrect

The events table says:
1201 | This event is written each time a user is locked out.Activity ID: %1XML: %2
This is incorrect.  Event 1201 is "The Federation Service failed to issue a valid token"  Maybe it was supposed to be for event 1210.
ref: https://adfshelp.microsoft.com/AdfsEventViewer/GetAdfsEventList

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f0238d6f-4073-172e-de62-e2d973d993b7
Version Independent ID: 3789bcce-bebd-8a9d-c814-45ce6c1bfe47
Content: Configure AD FS Extranet Smart Lockout Protection
Content Source: WindowsServerDocs/identity/ad-fs/operations/Configure-AD-FS-Extranet-Smart-Lockout-Protection.md
Product: windows-server
Technology: ad-fs
GitHub Login: @billmath
Microsoft Alias: billmath

#assign:robinharwood
Thanks for your dedication to our documentation. Unfortunately, at this time we have been unable to review your issue in a timely manner and we sincerely apologize for the delayed response. The requested updates have not been made, although there have been further updates with subsequent releases which supersede the updates in your issue. We are closing this issue for now, but if you feel that it's still a concern, please respond and let us know. If you determine another possible update to our documentation, please don't hesitate to reach out again. #please-close


fix watch fallback for non git/hg projects

Summary
Whenever you run jest --watch in a non git/hq repository you will see the following error:
Determining test suites to run...Error: This promise must be present when running with -o.
    at /path/to/node_modules/jest-cli/build/search_source.js:192:17
    at next (native)
    at step (/path/to/node_modules/jest-cli/build/search_source.js:20:362)
    at /path/to/node_modules/jest-cli/build/search_source.js:20:592
    at /path/to/node_modules/jest-cli/build/search_source.js:20:273
    at SearchSource.getTestPaths (/path/to/node_modules/jest-cli/build/search_source.js:204:10)
    at /path/to/node_modules/jest-cli/build/run_jest.js:45:31
    at next (native)
    at step (/path/to/node_modules/jest-cli/build/run_jest.js:24:380)
    at /path/to/node_modules/jest-cli/build/run_jest.js:24:540

To make it work I would like to do the following:

Warn that there is an issue for non git/hq projects
exit

Since #4737 --watch doesn't work anymore. This MR contains the fix for it.
Test plan

Create a new node project
Create a simple test file
Run jest --watch
An error occurs

Thanks for tackling this!
Can you rebase on master?

Codecov Report

Merging #4865 into master will increase coverage by 1.15%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4865      +/-   ##
==========================================
+ Coverage   59.24%   60.39%   +1.15%
==========================================
  Files         200      200
  Lines        6647     6631      -16
  Branches        3        4       +1
==========================================
+ Hits         3938     4005      +67
+ Misses       2709     2626      -83

Impacted Files
Coverage Δ

packages/jest-cli/src/run_jest.js
51.85% <100%> (+51.85%)
:arrow_up:

.../src/get_no_test_found_related_to_changed_files.js
0% <0%> (ø)
:arrow_up:

packages/jest-cli/src/get_no_test_found_verbose.js
0% <0%> (ø)
:arrow_up:

packages/jest-cli/src/test_result_helpers.js
12.9% <0%> (+3.22%)
:arrow_up:

...ackages/jest-cli/src/reporters/summary_reporter.js
15% <0%> (+6.66%)
:arrow_up:

packages/jest-cli/src/test_scheduler.js
27.61% <0%> (+12.68%)
:arrow_up:

packages/jest-cli/src/pre_run_message.js
66.66% <0%> (+16.66%)
:arrow_up:

packages/jest-cli/src/reporters/base_reporter.js
100% <0%> (+25%)
:arrow_up:

packages/jest-cli/src/reporter_dispatcher.js
75% <0%> (+50%)
:arrow_up:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a2429e...89516ac. Read the comment docs.

@Journerist Have you tested that this change works in the jest repo (just ./jest --watch in root) and in a project without VCS?

@SimenB Yes, it runs successfully when using --watch (and runs only affected tests using information from git/hg). And if there is no repo (for example no .git directory) then the message gets printed out.


Add ability to generate events from alerts on weather/measure probes

Next step after https://github.com/kalisio/kMap/issues/108 has been implemented.
Could simply allow to define a mapping between internal service events coming from loosely coupled applications using https://github.com/kalisio/feathers-distributed and event templates to be used to create event objects. Could also rely on webhooks.

[x] actions + layer to manage alerts from the catalog activity
[ ] real-time update of alerts layer
[ ] automated events triggering related to alerts

Fixing https://github.com/kalisio/kCore/issues/143 first could help.


Minify JS for Production

Currently in production we are serving full JS without minification. Figure out why it isn't be minified and perhaps ensure multiple copies of JS aren't being inserted.
https://scholarsphere.psu.edu/assets/application-6d4e6a8da32a16b332d0e868d9dbfc036accb6178a4b89b37fb373143c912e17.js

Looks like the compressors are commented out in production: https://github.com/psu-stewardship/scholarsphere/blob/develop/config/environments/production.rb#L69

CSS is compressed by default using sass-rails, however, I don't think that the JS is compressed by default.
https://guides.rubyonrails.org/configuring.html#configuring-assets

Looks like this was started here: https://github.com/psu-stewardship/scholarsphere/tree/i%231459-minify-js


Remove chainerx dependency from test backends

I think these are not necessary.

Jenkins, test this please

Jenkins CI test (for commit 28a0f959e3dc5ca515c6d86c78d177a5b0ce3c47, target branch master) succeeded!

Hm, I'm failing to build ChainerX on my mac after this change with undefined symbols while linking backend0.so, backend1.so (if CHAINERX_BUILD_TEST=ON). Strangely, it works on linux.


How to access methods within the component?

I know that I can add properties in config, but let's say if I want to destroy (by using destroy method) the carousel based on some condition, how do I do that? Can you provide us an example of how to use a method from within a component? @JayChase

The swiper object is available as a property on the component so you can using a local template to get to it in the component and call any API function you need on it. https://plnkr.co/edit/Oqx8Hw?p=preview


Added gobuster to Network section

Hi @mentix02!
Great tool! I updated your PR: e66d61d (multiple Network chapters).
:+1:


feat(next): default vite.config.ts

#440  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hi-ogawa and the rest of your teammates on  Graphite

Hmm, probably it's just easier to auto generate vite.config.ts when not found.
Let's think about init command to do that instead.


Move systemd code to linux-only built files

This moves systemd activation to a build tagged file to allow skydns to be built on Windows.  For issue #212

@fanatic  can you install this on windows? I always get error when install on windows (the problem is about systemd)

Yeah, this change disables the systemd activation code when built on Windows - but there are some other code that assumes Linux (like reading from /etc/resolv.conf to determine default dns settings).  However, since this allows skydns to be built on Windows, I'm able to use it as a library in my Go code.

@fanatic  thanks, but i still can not install skydns. I think some other part code may also  use the package "systemd".  I don't know how to fixed that.

@JaysLiang i has tested to compile @fanatic code on windows without error


Revert "[SvgIcon] Add themeable color"

This reverts commit 7aaec5eefed693d34ba5c5c32700b70a8670a5d1 ( #4561 ) which was mistakenly applied on 0.15-stable instead of master.
@oliviertassinari I could also hard reset 0.15-stable but I'm afraid that would mess up some peoples work leading to me loosing my head :sweat_smile: :sweat_smile:

Warnings are failing tests >.> This is a commit revert. I can't change anything here. So we should merge a red light for now. :grin:

@alitaheri Nice!


Meeting Sasa&Nick&Gökhan&Iman

Gökhans pointers

Choose a suitable level of researchy vs practical work.
Limit the scope from trying out everything to a few things.

E.g. compare pros and cons of LQR and PID with tPC state estimation.

Implement in steps:

Estimation without control

Does the system behave as expected?

Add control

General remarks

LQR we require a model of the system. I.e. $C$ and thus states must be sensible.
PID is more robust to model errors and we only care about observations.
Magnets for modifying physical system.
Don't worry about MPC for now.

Regarding the uncertain tracking of the state

The system is optimising for too many outputs/parameters
Try fixing C matrix to I for example

Control Scheme

Compare performance with PID and LQR
With PID output of the state estimator does not need to be outputting the exact state
With the changing model (A) LQR will show interesting results
As the Second order information is produced in the estimator good to send them to LQR
LQR is time invariant so this is good. (MPC is not as it is iterative)

Regarding the research

Limit the scenario to a one line of story to help publications within 6 months


Handle -[UIApplication keyWindow] deprecation

This was deprecated on iOS 13. It’s not currently a warning because the library’s deployment target is iOS 12, but it’ll be soon - plus it can be a warning if integrating the library via submodule or using the source code directly.

Thanks for submitting this @marcelofabri!
@jhneves Mind taking a look at this one? I don't think this will cause any issues, but want to make sure we aren't missing anything around apps that don't use scenes.

This was fixed in #116. Thanks for this PR @marcelofabri!


State with nested collection schema data broken after patch

Our room state contains nested collection schema data and is breaking after initial connection and state synchronisation when the gateway sends the first state patch down. We're seeing this issue intermittently, only happening directly after every 3 or 4 connections, but this is probably unrelated to the core issue when the state is patched.
We traced the issue to the room state patching MapSchema and ArraySchema objects. After state patching, MapSchemas and ArraySchemas are being corrupted, losing their internal indexing. The cause is that during a MapSchema.Clone() or ArraySchema.Clone() the main data and callbacks are copied or assigned but the internal indexes are not.
The fix is to ensure that the internal indexes are also assigned or copied in Clone() methods.
Adding this issue so pull request with fix can reference it.

Thank you so much for the fix @gregharding 🙌  Just released 0.15.12 with your fix.


Handle Skill Swap move

Sample log:
|move|p2a: Drifblim|Skill Swap|p1a: Azumarill
|-activate|p2a: Drifblim|move: Skill Swap
|-endability|p2a: Drifblim|Aftermath|[from] move: Skill Swap
|-endability|p1a: Azumarill|Thick Fat|[from] move: Skill Swap

Add a MoveData flag to track this move, and an AbilityData flag to note which abilities can't be swapped.
In the PSEventHandler, the -activate can be ignored and the -endability events should be translated to a new RevealAbility event for the useMove.ts SubParser, which should take the two events and apply the skillswap effect appropriately.
After handling the move effect, the useMove SubParser should then expect the abilities to activate their on-start effects (onStart() in activateAbility.ts). There are some weird exceptions, though, so for now make them optional by removing the absent() callback when using the EventInference helpers.

Covered by #321.


https support (self-managed App Search with SSL enabled)?

I don't see any certificate path (e.g., certificate_authorities) settings available for this plugin.  I have a SSL-enabled App Server instance (7.3.0) and have configured the url to https.  Is https connection to an App Server not currently supported by this plugin?  thx!
@jsvd

the app search java client doesn't seem to support this either. You can pass an https url and it will likely use the certificates in your java keystore, that lives in $JAVA_HOME/lib/security/cacerts

I am able to use javax settings to point it to the JKS truststore of App Search to get this to work:
-Djavax.net.ssl.trustStore=/Users/pius/Elastic/AppSearch/7.3.0/app-search-7.3.0/config/appsearch_truststore.ks
-Djavax.net.ssl.trustStoreType=jks
-Djavax.net.ssl.trustStorePassword=password

+1

Error: <LogStash::ConfigurationError: Failed to connect to App Search. certificate verify failed>
Couldn't connect to self-managed App Search with self-signed certificate


Cleanup after unit tests

Unit tests produce a lot of entities (customers, payments, subscriptions etc.). Mollie sends email notifications to the same address as for production usage.
We can use metadata to mark test entities on creation and remove them when tests are finished.

An example of cleanup function: https://github.com/millmobile/adgoji-campaign-server-proto/blob/main/test/clj/integration/utils/data.clj#L94-L116


[fastlane] Version bump

Updated spaceship to support the new 2-factor auth flow
Updated activesupport dependency, so you can install fastlane out of the box on system Ruby

:+1:


fix json issue in notebooks/plot_ngs_read_thresholding.ipynb

Thanks for bringing this notebook back to life!
Can you update the installation cell to match the rest of the notebooks? (with comments)

Done


A couple of fixes

This PR fixes two issues:

dired-aux should be loaded before dired-guess-default is patched to avoid compilation issues.
Various changes to make sure that user-emacs-directory is used when loading init.el to allow emacs configuration to be in XDG_CONFIG_* for example (I am trying to declutter my home directory).

Thanks!


Predicitive back support

I can't find anything conclusive about predictive back navigation in Android 14, but it is listed under new features in the changelog so maybe it will be enabled by default for everybody (instead of being behind a toggle in developer settings like in Android 13).
Harmonic already opts in into predictive back and has some code in place for it, but doesn't actually implement it properly. I strongly recommend using Android 14 preview for testing instead of 13 as there are significant changes between them. Here's current status for Harmonic:

Screen
Status
Notes

Welcome
✅
-

Stories
⚠
Works outside of search. Search ui doesn't have nice animations and the code can be improved a bit

Comments
❌
No predictive back animation. Adds callback for webview and exit animation. There's a codelab with correct implementation for webview (steps 5 and 6).

Submissions
❌
No predictive back animation. Adds callback for exit animation

Writing a comment
❌
No predictive back animation. Adds callback for displaying confirmation dialog when there's text in the input field. Perfect scenario for predictive back, just need to implement properly.

Settings
❌
No predictive back animation.  Adds callback for restarting activity/app and exit animation. No good ideas how to implement it right now

About
⚠
Shows animation, but it looks terrible. See note about translucent activities

One problem I've found is that navigating back to a translucent activity looks terrible because the activity behind it (i.e. stories screen) is also visible. It works fine with non-translucent activities, but any activity that uses swipeback (so, almost every one) has to be translucent. A workaround that seems to work is to set translucent=false when navigating forward from a translucent activity and set it back to true in onResume.
Regarding animations, there's a new api overrideActivityTransition but I haven't looked into it too much.
Finally, settings screen does interesting stuff with restarting activities which is not the intended purpose of OnBackPressedCallback, so it requires a different approach. But at least (I assume) it's not a frequently visited screen, so supporting predictive back here doesn't feel so important.

Yeah everything definitely needs to be done with Android 14 as you say, up until now I just activated the flag the get the main screen animation on Android 13 with the developer option enabled. Thanks for the API tips also, those will come in handy.
What were you thinking with the ComposeActivity thing? To not have the dialog show at all on Android 14? Because that might be a reasonable solution.
I should note that I am planning to remove the SwipeBack stuff from everything except for CommentActivity in the near future, partially inspired by predictive back which treats this much better. Do you think it should be removed from CommentActivity also? Or is it too engrained in the users by now?

What were you thinking with the ComposeActivity thing? To not have the dialog show at all on Android 14? Because that might be a reasonable solution.

No, the dialog is still necessary to explain user why back didn't work. But I hope that it can be shown with some animation when user triggers predictive back.

I should note that I am planning to remove the SwipeBack stuff from everything except for CommentActivity in the near future, partially inspired by predictive back which treats this much better. Do you think it should be removed from CommentActivity also? Or is it too engrained in the users by now?

I'm sure somebody will be very unhappy if you remove it from comments, so no (at least not yet). Though as a user I don't care because I have it disabled. And as a developer I don't like having to support it, but that's just part of the job.
Interestingly enough, Google has its own implementation of SwipeBack that's called SlidingPaneLayout and uses a completely different approach. But it doesn't support either fragments or predictive back out of the box, so while it has its advantages it's not strictly better.

Okay I see, I sure hope it is not too much work to set up the dialog showing animation for ComposeActivity - that could really be an issue.
Also the SlidingPaneLayout thing - I've seen it mentioned for a long time but watched a video on it now that you mentioned it and learned more about it. The fact that it has the dragging thing is really nice - the SwipeBack library that is used now is really shady I think. It would be nice to migrate to it if predictive back worked nice out of the box and whatever the fragment issue is could be worked around...

the SwipeBack library that is used now is really shady I think

I agree. The approach used is very clever, but I doubt os developers ever intended it to be used like this.
So I've experimented with SlidingPaneLayout a bit and it works, but not great. The main problem so far is lagginess of comments opening animation. Also, I couldn't get integration with fragments' lifecycles working and I suspect that's the reason for lags.
I'll continue working on this for now, but this might take a while

Okay that is a very big undertaking but could be nice if it worked! For now, I've got the translucent=true thing you recommended working and I am activating/deactivating the OnBackPressed callback dynamically as the app is used to trigger the back animation when it is appropriate. Consequently, I think we now have OK predictive back working throughout the app! Key commits for this were https://github.com/SimonHalvdansson/Harmonic-HN/commit/6d86b4f32f4b68fa9b5f3a554550eef44133db9d, https://github.com/SimonHalvdansson/Harmonic-HN/commit/bd3839f447f341a5dac5431f85aa94417b08c486 and https://github.com/SimonHalvdansson/Harmonic-HN/commit/8661c5299d85122af9e5b444f42ccc626d0021f9.

I've realized there's one more problem with SlidingPaneLayout - it doesn't support more than two child views. This means you can't open another story while reading comments and then swipe back to the first story. So I guess you're stuck with SwipeBack for now

Hm yeah I guess that would require starting a new activity which of course we would not want to have transparent background on.
I am sort of envisioning that once people get on Android 14 they'll like the predictive back animation so much that they might disable SwipeBack. As I see it, this is sort of Googles main idea for predictive back as it solves the same problem (peek and see the old thing).
So yeah let's stick with SwipeBack if there's no easy alternative.

I think there's a bug in comments, there's no animation when webview can go back and "use device back for webview"=false
Also I've updated current status in the OP. Great job getting everything to work!

Yes good catch, fairly sure it is fixed by https://github.com/SimonHalvdansson/Harmonic-HN/commit/757ece7ce3dc472bc56f4863235ab049cf461ece

I sort of feel with the latest 2.0 update that things are as good as they're going to get for a while. Until Android starts supporting predictive back for dialogs I am not going to be attempting this. The only possible improvement is Search but this comes for free once we transition to SearchBar or whatever the name of the material component is. As such, I am tempted to close this issue and leave the search improvements to https://github.com/SimonHalvdansson/Harmonic-HN/issues/18

Until Android starts supporting predictive back for dialogs I am not going to be attempting this

Maybe I am understanding Google's guidance or your comment wrong, but afaik in this case it is expected that there is no preview/animation.
In other words: Only when some navigation event should occur, there should be a preview animation. A dialog being shown does not fall under this.

Until Android starts supporting predictive back for dialogs I am not going to be attempting this

Maybe I am understanding Google's guidance or your comment wrong, but afaik in this case it is expected that there is no preview/animation.
In other words: Only when some navigation event should occur, there should be a preview animation. A dialog being shown does not fall under this.

This feels reasonable, especially as Google has not implemented such as animation anywhere themselves. I guess the only thing missing to mark this issue as fully completed would be the SearchView rework.


Server Requires Pretty-Printed JSON Requests Otherwise, Sign Requests Fail

Hello,
We noticed that sign requests require pretty-printed JSON. Otherwise, we either get BAD REQUEST or issues with signing roots being incorrect, which is misleading.
Minimal reproduction:
The case below fails:
curl -X POST http://localhost:9000/api/v1/eth2/sign/0xaf9a90183267b2edf725a30e37470de12bb7fef53c78b32a37ae4c3219604c640c7ccac40b97e4e337653c1f8dcd522b -H 'Content-Type: a
pplication/json' -d  '{"type":"aggregation_slot",
  "fork_info":{
      "fork":{
        "previous_version":"0x00000001",
        "current_version":"0x00000002",
        "epoch":"61650"
      },
      "genesis_validators_root":"0x9436e8a630e3162b7ed4f449b12b8a5a368a4b95bc46b941ae65c11613bfa4c1"
  },
  "signingRoot":"0xce1eaa2cb81e7b5e0ae824cbd94ac0541eb6ebb2b2207486d9a1f1db76f1d9e7",
  "aggregation_slot":{
    "slot":"3113048"

  }

}'

The case below passes:
curl -X POST http://localhost:9000/api/v1/eth2/sign/0xaf9a90183267b2edf725a30e37470de12bb7fef53c78b32a37ae4c3219604c640c7ccac40b97e4e337653c1f8dcd522b -H 'Content-Type: a
pplication/json' -d '{
  "type": "aggregation_slot",
  "fork_info": {
    "fork": {
      "previous_version": "0x00002009",
      "current_version": "0x01002009",
      "epoch": "61650"
    },
    "genesis_validators_root": "0x9436e8a630e3162b7ed4f449b12b8a5a368a4b95bc46b941ae65c11613bfa4c1"
  },
  "signingRoot": "0xce1eaa2cb81e7b5e0ae824cbd94ac0541eb6ebb2b2207486d9a1f1db76f1d9e7",
  "aggregation_slot": {
    "slot": "3113048"
  }
}'

The same goes for non-prettified JSON requests, such as those created by calls to json.Marshal() from the Go standard library. The server should not have these requirements for requests.

Hi,
I've tried the failing request example and it looks like the signing root is incorrect in that request so I don't think there is problem with web3signer not handling non-pretty printed json. I crafted another request to verify that it works with formatting you had by updating the fork info in that request to match what is in your 2nd request and it is working for me.
This the modified version of the failing request I used with the fork info updated changing the previous_version and current_version fields to match what is in the 2nd working request.
curl -X POST http://localhost:9000/api/v1/eth2/sign/0xaf9a90183267b2edf725a30e37470de12bb7fef53c78b32a37ae4c3219604c640c7ccac40b97e4e337653c1f8dcd522b -H 'Content-Type: application/json' -d  '{"type":"aggregation_slot",
  "fork_info":{
      "fork":{
        "previous_version":"0x00002009",
        "current_version":"0x01002009",
        "epoch":"61650"
      },
      "genesis_validators_root":"0x9436e8a630e3162b7ed4f449b12b8a5a368a4b95bc46b941ae65c11613bfa4c1"
  },
  "signingRoot":"0xce1eaa2cb81e7b5e0ae824cbd94ac0541eb6ebb2b2207486d9a1f1db76f1d9e7",
  "aggregation_slot":{
    "slot":"3113048"

  }

}'


Added links to verify differentiation & integration

Added links to verify differentiation and integration using maths

Apologies for the delay! I've been heads down at work and haven't reviewed this repo in nearly a year. Looks like we're getting 54k monthly active users. Thanks for contributing!


[Plugins] Ability for plugin to switch file and go to specific line

API
{
 type: 'editor',
 function: 'goToLine'
 value: {
     fileName: fileName,
     line: line,
     column: column
 }
}

that'll use:
fileManager.switchFile(name)
editor.gotoLine(line, col)

I tried to think a bit more about the API, and maybe you are right with this approach.

the type seems to represent an address (like which "entity" is addressed to do something)
the function seems to say what type of message or operation is requested to happen
the value is the data or payload associated with the message or operation

We would probably need to specify the API a plugin maker can use.

To me, the message or operation type in the example above seems to be goToLine
the address or part of the app that is responsible to process the message or operation is editor

another example could be:

Maybe the remix-ide could allow a plugin to switch the content of a dropdown

the compile, run and settings tab have dropdowns
so a plugin might specify the message or operation type as selectInDropdown
the value might contain the new value for the dropdown
the address would be e.g.compileTab/dropdown, run/dropdown, settings/dropdown

If the type is to be understood as a message, then value would describe a payload or data
If the type is to be understood as an operation, then value would describe arguments
So a request could look like:
var args = { fileName, line, column }
var event = { type: 'goToLine', key: 'editor', val: args }

event.type // describes the kind of "message" or "operation/command"
event.key // describes the "address" of the apps part or component which should process the request
event.val // describes the "data" or "payload" or "arguments" for the message or operation

Defining component like ['compileTab', 'dropdown'] would mean that the plugin could directly update ui core component of remix, that should not be the case. function or operation (in your case) should only be high level execution.
Given that I don't really see the point of having this finegrained definition of targeted components ...
But yeah that might be needed in the future.
we could support both
var event = { key: ['editor'], op: 'goToLine', val: { fileName, line, column } }
var event = { key: 'editor', op: 'goToLine', val: { fileName, line, column } }
would mean the same.
OK for operation but I would prefer to keep type for that component name.

+1 i think supporting both is nice
otherwise - i'm not saying that plugins would be allowed to have all this "fine grained control", but that i would of course ask the user to grant permissions first and also to be able to revoke permissions later
This is super important i think.
Also, it's one thing that a plugin specifies something like 'compileTab', 'dropdown' and another whether in browser-solidity we listen to that path and allow it or prompt the user or not.
So I'm not proposing to grant this kind of access automatically


MGDOBR-458 Extend Bridge creation timeout in integration tests

Signed-off-by: Karel Suta<EMAIL_ADDRESS>MGDOBR-458
PR owner checklist
Please make sure that your PR meets the following requirements:

[x] Your code is properly formatted according to this configuration.
Run mvn clean verify -DskipTests so that imports are correctly set.
[x] Your commit messages are clear and reference the JIRA issue e.g: "[MGDOBR-1] - $clear_explanation_of_what_you_did"
[x] All new functionality is tested
[x] Pull Request title is properly formatted: MGDOBR-XYZ Subject
[x] Pull Request contains link to the JIRA issue
[x] Pull Request contains link to any dependent or related Pull Request
[x] Pull Request contains description of the issue
[x] Pull Request does not include fixes for issues other than the main ticket

PR reviewer(s) checklist

[ ] Check if code and Github action workflows have been modified and if the modification is safe
[ ] If the modification is safe, add the safe to test label

How to trigger pipelines and use the bots:

Run the end to end pipeline
Annotate the pull request with the label: safe to test. If you want to run the pipeline again, remove and add it again.

Rebase the pull request
Comment with: /rebase.

Please be aware of https://github.com/5733d9e2be6485d52ffa08870cabdee0/sandbox/pull/480
At the moment when a Bridge/Processor is requested we trigger work to provision it immediately.
After the referenced PR is merged provisioning will not start immediately but on the first poll of a "work queue".
Polling is every 30s at 0s and 30s on the minute.
I see you've doubled the time-out so you may not be affected.. just FYI.

Timeout reached while creating topic and granting access to topic
Rerunning the tests, hopefully it was just a short term outage

@jiripetrlik I rather prefer current solution with declared timeout, that makes the step explicit and without hidden functionality/configuration.

@jiripetrlik I do agree with @sutaakar. Steps to be as explicit as possible on what is happening.


Highligth code issue

I was adding some css like:
div > .yourclass {...}
but that is not highlight on the previewer
if you write:
ul > li {...} that work.
Is that a bug?

I created a test.css file and added
div > .yourclass {}
ul > li {}

which is highlighted correctly.
It's not really clear to me what you meant with previewer, but since this had no answer and to me works fine, I close this.
FYI there is this issue which is about to differentiate tags and custom classes: https://github.com/adobe/brackets/issues/12558


Best way to have more support for termURL in json related to tabular files ?

Having termURL fields as described here is great, but it seems limited to the column names and not e..g. to the categorical Levels.
For example, imagining we have the group column in our tabular data for participants and want to indicate different subgroups of Alzheimer's subjects (AD, MCI, NC)  with a term URL for each, how we would do that ?
  "group": {
      "Description": "Alzheimer's subgroups",
      "Levels": {
          "AD": "Alzheimer's disease", # want to indicate `termURL` http://terminology/AD.html here
          "MCI": "Mild cognitive impairment" # want to indicate `termURL` http://terminology/MCI.html here
          ...
      }
  }

Is the only solution for now to replace the level description with the URL itself ? Are there any developments planned for a more formal description ? A first step could be nested description/termURL for levels as in:
  "group": {
      "Description": "Alzheimer's subgroups",
      "Levels": {
          "AD": {
            "Description": "Alzheimer's disease",
            "termURL": "https://terminology/AD.html"
           }
          "MCI": {
            "Description": "Mild cognitive impairment",
            "termURL": "https://terminologyMCI.html"
          }
          ...
      }
  }

Note that it could  be useful to also have this feature applied to Units as in:
"volume": {
    "Description": "Volume of X",
    "Units": {
      "Description": "millilitre",
      "termURL": "https://terminology/mL.html"
    }
}

Yes, the insufficiency of our column descriptions has come up recently. I like the idea of expanding plain-text descriptions to description fields that allow richer annotations. Thus "AD": "Alzheimer's disease" becomes shorthand for "AD": {"Description": "Alzheimer's disease"} and tools can easily perform this conversion and enable addition of new fields.
@surchs I would be interested in your thoughts here.
There's a general problem in BIDS, which is that we don't want to make it difficult to start structuring your data, but it would be good to find ways to enable "promoting" first-pass annotations to rich annotations. I would also like to do this with dataset authors...

potentially related to this: https://github.com/bids-standard/bids-specification/issues/615


Overhaul example(s) with CoMUDF and descan error compensation

In particular descan error compensation has been requested often! It would be great to showcase the recent improvements by updating the example(s)

We could also think about updating the code generated by the notebook template feature of the GUI by @twentyse7en to use UDFs where it makes sense.


Folder node selected only support

This could be done by handling the event to your liking, I think. Or perhaps I don't understand the feature exactly?

Closing, please re-open if this is still something you'd like to discuss.


Alex commits

Added Automatic Detection For CPU Architecture...

You'll need to change the UI here to remove the selections from the UI along with removing the associated selection variables from the entry point


[Collaboration] Monstorlogy

https://github.com/ReconVirus/Monstrology
Hello, I am the developer of Monstrology and I  would appreciate your interest in collaborating with me. Your project Super Chargerd Links looks very impressive and I think it could enhance the functionality of my plugin. I would be happy to explain to you how my plugin works and how we can make it compatible with yours.
My plugin ihas a unique feature that lets users turn a code block into a element or monster icon, Simply as using something like ele:FIre or mon:Beast
The problem is that when I try to use my plugin alongside your's, it seems to interfere with the monster icon feature. The icons do not render properly, leave just the mon;Beast . I think this is because your plugin modifies the code block’s HTML structure and attributes, which affects how my plugin recognizes and transforms the code block into an icon.

To solve this problem, I think we need to do two things:
First, we need to make sure that your plugin does not alter the code block’s original content or metadata, such as its id, class, or style. This way, my plugin can still identify and process the code block correctly.
Second, we need to make sure that your plugin does not overlap or conflict with the monster icon’s HTML elements, such as its div, img, or svg tags. This way, the icon can still display and function properly.
I hope this explanation helps you understand how my plugin works and what we need to do to make it work with yours. If you have any questions or suggestions, please let me know. I look forward to hearing from you and working with you on this exciting project. Thank you for your time and cooperation.

Hey! I admit I don't immediately grasp the idea of your project. Feel free to open a pull request solving the issues in Supercharged Links that conflict with yours.

what my plugin does is turn a code block  into a rendered icon. What im tryng to do is use that code block within Supercharged links, but instead of seeing a code block, the actual icon is render instead. thats being appened or deppended to the link. .

You can probably achieve something with this by generating a CSS file. See this https://github.com/mdelobelle/obsidian_supercharged_links#css-custom-properties-css-variables link for examples. Just make sure you assign the right properties to the yaml, I guess.


multi: Add autoclient.

I believe there is an effort to move the rest of the dcrwallet/internal/vsp code here, so making an issue to track those changes.
Sample code from @jholdstock https://github.com/jholdstock/vspd/compare/dcr-deps...jholdstock:vspd:internal-vsp?expand=1

@jholdstock if you are busy I can pr this up?


File upload implementation to support docs & forms

Camps need file uploading module, for documents (doc,xls,csv) mainly.

[x] need a bucket , key & secret. (update: we have the bucket named alex.spark)
[ ] implement express-fileuploader-s3 package

need a bucket , key & secret.

I can do that bu need more details..

@OriHoch @mtr574
For file upload:

On the edit camp http://localhost:3000/he/camps/1/edit we need to add another section:
Files. (Current we have two tabs: Basic Information, Basic Details) , we will add File Upload
On this section we will have various of File Types to upload.
(Add on the camps/edit.jade one file option, we will add as much as we want)
Install the express-fileuploader-s3 to the node modules.
upon uploading files, we will use the uploaded files, and store them on the AWS-S3: https://www.npmjs.com/package/express-fileuploader-s3 (for a working example)
Saving the files/urls on the DB (still waiting to understand how we do that)
On the Manage Camps, at Documents & Forms, we will see a list (Grid Table) of all documents available, with camp and status of document (Can be filtered by camp, or status), and ability to change the status of the file.

@asihud - great spec, but I think I'm missing something
could you please provide links / reproduction steps on the staging server?
currently if I go to: http://sparkstaging.midburn.org/he/camps/1/edit
It's stuck..

@OriHoch
I am not working on the sparkstaging, so i do not know. maybe to ask alex or omer.
dont you have your own local copy ?
i am just asking guy to create all the front end first,
and then we will ask you to complete this task.

@asihud  - it would be best to have issues reproducible on staging / test server
otherwise, it's hard to know what's the status of your local copy, which branch you are on, is it updated etc. etc...

the problem is that i do not have permission to merge to master, and not in charge of the staging.
and still dont know how to do that on github.. :)

If the bug is reproduced on a specific branch then include that step in the reproduction steps...
But it would be better to work on master branch

@OriHoch
Please update your branch with guy changes or even from asihud/Spark fork, to your branch.
It is include the file upload ui.
now need to implement it. please tell me that you are on this issue, and grabbed it.

@asihud  - you instructions are very ambiguous..
what is "guy changes"? what is "asihud/Spark fork" - a fork contains many branches
what is "my branch"? I don't have a single branch, I have a fork
it would be helpful to have full reproduction steps from start to finish

@OriHoch ,
sure. to sync:

go to PULL REQUEST , ask for NEW PULL REQUEST
on the Compare Changes page, press the compare across forks.
select for base fork: asihud/Spark base: master  to head fork (your fork)
sync changes.
implement the upload code.
we all happy!

@asihud  - I appreciate your work and trying to be clearer but the issue is still very confusing (to me..)
If you (AKA spark team / AKA midburn) would like to involve more volunteers in the project I believe you need to have clearer issues, requirements and working flow
However, I might be mistaken and maybe it's not needed and you will be able to have volunteers help you.. in that case, you are welcome to continue working as you (AKA spark team / AKA midburn) did before..
For me personally, it's very hard to work like this and I will probably be able to help less when the issues are not clear..

@OriHoch ,
No Problem.
I will try to set up better spec.
Hope to see you tommorow at the meeting at iron source, so we can sync.

@asihud,
I’ll take this, as we discussed.
I’ll hit you up on Slack if I have any Qs

@elad-lachmi ,
very good. I am assigning you once you will approve yourself as collaborator!
yeh, way to go!!!

@elad-lachmi
Okay, to make it more usable:

[ ] add a field on event array on the constants, that hold files upload for communities:
it should be like this:
'MIDBURN2018': {
bundles: [
ticketType.SUPPORT_TICKET,
ticketType.ADULT_TICKET,
ticketType.CHILD_TICKET,
ticketType.ADULT_DIRECT_SALE_TICKET,
ticketType.YOUTH_TICKET,
ticketType.LOW_INCOME_TICKET,
ticketType.INTERNATIONAL_DIRECT_SALE
],
files: {
theme_camp: [
{
id: 'safety_docs',
name_he: 'תיק בטיחות',
name_en: 'Safety Doc',
start_date: 0,
end_date: 0
},
{},
{},
],
art_installation: {
      },
      prod_dep: {

      }
  }

[ ] On the file upload tab on edit camp page, we need to add the file upload option in the gui, (by the community group type), and to add a list of files

[ ] Uploading file will upload it

[ ] Display safe the file content with option to view/download it (after upload)

@asihud
Sounds good.
Just another thing I think is worth implementing is the option to replace or delete a file, which has already been uploaded.
The camp manager will be able to upload/delete/replace a file until the end date and an administrator can upload/delete/replace a file regardless of the end date.


JRuby build is intermittently failing

From @perlun

I think the root cause here is that our code is not really thread safe, and that's why JRuby (which is much more concurrent than the evil-GIL-threaded MRI) triggers these errors.
[..]
The error:
Error: test_git_init_bare(TestThreadSafety): Git::GitExecuteError: git '--git-dir=/tmp/d20180328-6779-88i76v/.git' init '--bare'  2>&1:fatal: GIT_WORK_TREE (or --work-tree=) not allowed without specifying GIT_DIR (or --git-dir=)
...indicates that something goes wrong; it does specify the --git-dir but git still complains about this.
I read this SO thread but I couldn't see the GIT_WORK_TREE variable being set on the Travis machines.

I believe this was fixed in #403 and released in v1.6.0.pre1


Vickel: Watch togeldana.sardengeprek.ac.id

Vickel requests the watch of the watch_keyword togeldana\.sardengeprek\.ac\.id. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

togeldana\.sardengeprek\.ac\.id has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by VLAZ in Charcoal HQ


Will there be support for C# on .NET Core?

Related: https://github.com/Azure/draft/issues/84

Closing as a duplicate of #84 but please let me know if this is a separate request and we can happily re-open this. Thanks!


implement MeanQualityByCycle in dataflow

depends on https://github.com/broadinstitute/hellbender/issues/409

no action


small correction to T10_PropertySetting.snippet

I think line 41 of T10_PropertySetting.snippet should be:
get { return $helper$.Read<$type$>(nameof($name$), default($type$)); }
instead of
get { return $helper$.Read<$type$>(nameof($name$), default()); }

Cool. What is your opinion about removing the T10_ prefix?

As I am a beginning developer and not so sure about what goes where and how it is called.
I love the T10_ prefix, it gives me a list of everything there is to help me while maintaining the thinking pattern of using the template. So I vote for keep the prefix.
Also, I'm learning about the Mvvm pattern I hoping to propose an addition to the snippets that helps building new viewmodels. I'm not sure but I think it would be a nice addition.


align included license files with current Rust project best practices

Hi! I'm currently working on packaging this crate for Fedora Linux as a dependency of hashbrown v0.14.0 and bumpalo, and noticed that the setup for license files in this repository is currently quite unusual for a Rust project (and also non-compliant with the Apache-2.0 license, since it requires the full license text to be included, not only the header).
I've made some changes to align this project with other Rust projects and best practices, i.e. renamed license files to LICENSE-APACHE, LICENSE-MIT, and removed the COPYING file which is redundant with the ## License paragraph from the README (and which also included the wrong paths for the Apache-2.0 / MIT license texts).
The end result is equivalent to the setup in the repo for the proc-macro2 crate (which I took as a reference because both proc-macro2 and allocator-api2 are reimplementations of Rust features), and the rust-lang/rust project itself - notable changes include:

include full Apache-2.0 license text in LICENSE-APACHE (without appendix; see ¹ and ²)
remove copyright from MIT license (this is an anachronism and a noop; see ³ and ⁴)

¹ https://github.com/rust-lang/rust/commit/2ccf65c7eba519dcc407cb76f08d04ac00d05851
² https://github.com/dtolnay/proc-macro2/commit/37e89e109c367a2ab88407d297f344e72897bcbb
³ https://github.com/rust-lang/rust/commit/2a8807e889a43c6b89eb6f2736907afa87ae592f
⁴ https://github.com/dtolnay/proc-macro2/commit/f633e3106c2cf107925c25e56165d1105020fb14

Thank you for the contribution

Thanks for merging! 💯


Exception trace with different log level

In most cases the trace log is not on by default, but we want to know, if an unexpected exception was thrown. So it would help to trace "only" the exceptions. This could be done, if e.g. the log of exception would use "Info" or "Warn" level (or configurable), instead of the "Trace" level, as for entry and exit.
In the logger we then can activate this level by default.

The reason for logging exception as a trace is that it gets logged as the "result" of the method call. So if an exception occurs deep in the application in gets logged as the return value of the methods in the call stack until it gets processed by an exception handler.  It would probably make sense to log the first occurrence of the exception as info/warn and the rest still can be trace. Or all exceptions should go to trace, even if its just a repetition? What's your take on it?

I think, it make sense to log not only the first occurrence of exception. It would need less change on the current tracer.
My intention is to be able to log unexpected exception as INFO/WARN (that we probably overlooked during development) and have the possibility to turn TRACE on, if we try to reproduce the error. Permanently turn TRACE on produce too much data and lower application performance.
Sometimes we get exceptions from external components / controls (Xamrin.Forms) that we not expect. We don't want to decorate all methods with try/catch manually to track this errors.
E.g. we have an MVVM Command with Execute and CanExecute methods in ViewModels. The Commands are triggered by UI components. We see in log only, that the error happen in the Command binding property. So in our error log we don't see which of the ViewModels is involved.


feat(routing): manual mediator pickup lifecycle management

Small update on Mediation Recipient module to allow stopping message pickup loop, and then restarting it anytime by calling initiateMessagePickup() manually.
An optional parameter has been added to initiateMessagePickup method in order to let start the agent with a None messagePickupStrategy (so it will not attempt to connect to mediator at the beginning) and be able to start the pickup afterwards (using any strategy we want).
So it can be used in the following way:

Start agent normally (with whatever Mediation Strategy you already have). It will initiate Pickup loop (V1, V2 or Implicit)
Call stopMessagePickup() to pause this process (e.g. when agent is offline)
Call initiateMessagePickup() to restart the process (e.g. agent goes online)

In case that default pickup strategy is set to None, of course, initiateMessagePickup should be called after 1 using parameters defaultMediator and the desired strategy (and the same in 3)
And I'm not completely sure, but it might also help with some failures in test suites when shutting down agents.
Resolves #753

Codecov Report

Merging #989 (600400f) into main (d8a30d9) will decrease coverage by 0.07%.
The diff coverage is 58.82%.

@@            Coverage Diff             @@
##             main     #989      +/-   ##
==========================================
- Coverage   88.18%   88.10%   -0.08%
==========================================
  Files         487      487
  Lines       11544    11559      +15
  Branches     1921     1924       +3
==========================================
+ Hits        10180    10184       +4
- Misses       1304     1315      +11
  Partials       60       60

Impacted Files
Coverage Δ

packages/core/src/transport/WsOutboundTransport.ts
11.42% <0.00%> (-0.17%)
:arrow_down:

...ckages/core/src/modules/routing/RecipientModule.ts
62.01% <46.66%> (+0.40%)
:arrow_up:

...re/src/modules/routing/services/MediatorService.ts
91.57% <92.85%> (-0.98%)
:arrow_down:

packages/core/src/agent/Agent.ts
95.34% <100.00%> (+0.02%)
:arrow_up:

...ackages/core/src/modules/routing/MediatorModule.ts
81.63% <100.00%> (+0.78%)
:arrow_up:

packages/core/src/logger/ConsoleLogger.ts
55.55% <0.00%> (-22.23%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

This is a great improvement. One thing I'd like to see but is probably much more work is that you can stopMessagePickup for a specific mediator. that is probably something we can add later on.
another thing we should do as a change to 0.3.0 (feel free to open a pr 😄) is to make the public api take mediator id's instead of the records.

Thanks! I've been thinking about the management of individual message pickup loops but, as you said, requires some complexity and I think it will be better to develop it in a refactored MediationRecipient / MessagePickup module for 0.3.0.
I'll start working on these refactoring ideas (including the usage of mediatorId / connectionId) so we can discuss about it shortly.

Awesome, merged! Thanks for all the contributions lately :)


:bullettrain_front: Use optimised OpeningTimes

The PR in moment-opening-times will need merging and packaging before this is merged.
The moment-opening-times dependency in packages.json will also need updating.
Timings in connecting-to-services with the optimised OpeningTimes code:
experimental/exceptional-opening-times
Nearby
happy path
✓ should return an object with nearby and open services (132ms)
master
Nearby
happy path
✓ should return an object with nearby and open services (101ms)

Note: getOpeningHoursMessage has been cut and pasted from OpeningTimes. It probably needs to be removed from the there and the tests need to be added to connecting-to-services.

 Add exceptional opening times/dates

I'm going to move the getOpeningHoursMessage method out into a separate lib file and add the tests.

Open for review but not merge.
Once the moment-opening-times PR is merged and a release 2.0.0 created I'll make one last commit to update package.json to reference that release.

We should be good to go with this.
It would be worth getting Tom to re-run the performance tests once this is in staging. Even better if we were able to run them ourselves.


Question: Some questions about spread syntax

Is goja going to implement spread Spread syntax in the near future?
I'm trying to implement it and submit contributions, but I need your help: Should ArrayLiteral's spread operation be at compile time or at runtime? Can you tell me where I can find the relevant code (in any language)?

All ECMAScript features are in scope, however I cannot give any estimates. As for the spread syntax, I haven't looked into it yet, so can't answer your question. When implementing a new feature you should follow the specification: http://www.ecma-international.org/ecma-262/. Sometimes it also helps to look at the relevant tc39 tests: https://github.com/tc39/test262

All ECMAScript features are in scope, however I cannot give any estimates. As for the spread syntax, I haven't looked into it yet, so can't answer your question. When implementing a new feature you should follow the specification: http://www.ecma-international.org/ecma-262/. Sometimes it also helps to look at the relevant tc39 tests: https://github.com/tc39/test262

thank you :smiley:

thank you :smiley:


appearance?.dayLabelWeekdayOutTextColor : myColor[dotIndex] - fatal error: Index out of range

[x] I have verified there are no duplicate active or recent bugs, questions, or requests
[x] I have verified that I am using the latest version of CVCalendar.
[x] I have given my issue a non-generic title.

Expected Behavior

Current Behavior

Possible Solution

Steps to Reproduce (for bugs)

I run CVCCalendar Demo on Xcode 8
Then I pressed date with three dotMarker (sometimes two dotMarker and two action)
Then I swipe next month
And I get this Fatal error

Context

Your Environment

Version used (Cocoapods spec):
Device used i.e. iPhone 6S:
Physical device (y/n): n
Link to your project (if available):

Fixed in #384


Policy Versions

Shows policy version history in a new tab on the policy page
Closes #123

It doesn't seem like the version history is fetched again after a policy update changes the Rego. Although I do see the new version after a refresh.

I believe this is because of the SWR hook. I can look into forcing the call after creation so you don't have to refresh to see the data


ESLint config being generated when ESLint is not installed

Describe the bug
When running wxt prepare, ESLint config is generated even when eslint isn't installed.
Reproduction
https://github.com/aklinker1/github-better-line-counts/tree/2660c4f1f7c47a1e2ace8d410e76931082507986
Steps to reproduce
bun i

And .wxt/eslintrc-auto-import.json will be created.
System Info
System:
    OS: macOS 14.2.1
    CPU: (8) arm64 Apple M1 Pro
    Memory: 4.91 GB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.20.3 - ~/.asdf/installs/nodejs/18.20.3/bin/node
    npm: 10.7.0 - ~/.asdf/plugins/nodejs/shims/npm
    bun: 1.1.31 - ~/.bunv/bin/bun
  Browsers:
    Chrome: 129.0.6668.101
    Safari: 17.2.1
  npmPackages:
    wxt: ^0.19.11 => 0.19.11

Used Package Manager
bun
Validations

[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

This probably just needs to be changed to undefined instead of defaulting to 8. Should probably return undefined from getEslintVersion in this case as well, instead of an empty tuple.
https://github.com/wxt-dev/wxt/blob/b14c9107fe8a44d273912b9d349c9aadeb5f12a6/packages/wxt/src/core/resolve-config.ts#L388-L389

Released in v0.19.17


Update Android Quickstart with the new interface

Resolves https://github.com/hypertrack/issues/issues/1565

I need new interface in core sdk, there is no necessary updates in current sdk version.


Update to use BoxComponent.new

Change instances of render Box to render(BoxComponent.new).

Thanks!


HTTPS w/TLS support

Dear all,
Does this library support establishing connections to a JSON-RPC server over HTTPS?
I am currently using RPC4Django that implements a JSON-RPC interface over HTTPS (externally handled by Apache).
Thanks, Ricardo.

Dear Ricardo,
This library does not depend on http/https protocol, it is purely transport implementation. Let me address your questions in details.

If the use-case is to connect to json-rpc server, than there is no point to use any "json-rpc-like" library. Python requests would do the job. Even though this library supports client connection, I personally think it is overhead to use "json-rpc" for client side.
If use-case is to implement json-rpc server, this library would be helpful.

In terms of protocol usage, "json-rpc" does not limit developers to any of them. One may possible to use it with http/https (Django/Tornado etc.) as well as message queue servers (RabbitMQ+pika). As a benefit, it does not require developer to choose specific framework.

As I understood from your question, Django works as a web server on tcp port, https connections are proxied via Apache. In this case https implementation is purely on Apache side, while Django does not know anything about it (well, except settings, such as secure cookie handler).
This library would handle this case, in fact optional Django connector would simplify views development. Please refer to the documentation for more information: https://json-rpc.readthedocs.org/en/latest/django_integration.html

Thanks @pavlov99 , that answers my question for sure.


Hackerearth support

Checklist:

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[x] Have you successfully ran tests with your changes locally?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?

Issues Solved
User function template to run users logic code
Fixes #54

Hi! Thanks for PR.
Make sure you have checked points in PR Template correctly.
(Powered by GitMate.io)

Done

As per the hackerEarth testcases we need to have an input and a checker file which will run the inputs on users logic and problem setters logic and match them to give a suitable score.


Not working on Production environment

Hi there!
The library successfully updates all the metatags if it's running on the dev environment. But when it's running on Production - metatags are not updated.
The @stencil/helmet dependency is located in the "dependencies" object of the package.json file. Version - 0.3.2.
Any suggestions on what is wrong?
Thank you!

Updating to the 0.3.3-0 version fixed my issue but there are appeared some unwanted console logs. Fixed it in #28

Closing this issue as it appears to be fixed per the issue author.


feat: support new akmod signing key in just files

This add secure boot signing key for akmods to the main.just and renames the legacy version of the command in nvidia.just to be specific for older nvidia-only key.

Keeping this  draft until akmods stuff is building and ready to go.

This should be merged before https://github.com/ublue-os/main/pull/234


fix(metarepos): Ignore dirty report

What this PR does
It ignores reports that can't exist but don't know why.
Which issue(s) this PR resolves
Resolves #518
Anything else
Include any links or documentation that might be helpful for reviewers.

Codecov Report
Patch coverage: 82.35% and project coverage change: -0.01 :warning:

Comparison is base (f1d6d0a) 62.22% compared to head (fe2a550) 62.21%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #520      +/-   ##
==========================================
- Coverage   62.22%   62.21%   -0.01%
==========================================
  Files         133      133
  Lines       18490    18504      +14
==========================================
+ Hits        11505    11513       +8
+ Misses       6416     6415       -1
- Partials      569      576       +7

Impacted Files
Coverage Δ

internal/metarepos/raft_metadata_repository.go
77.26% <82.35%> (+0.29%)
:arrow_up:

... and 7 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


update message class add

begin for adding message class to client user.
TODO:

extend user class for userId can I get it a another way then search or message group?
POST send, update, leave, API endpoints

Solved by #13


samples: lightdb_stream: add twister runtime test with pytest

Add basic pytest runtime test, which runs:
  $ goliothctl $GOLIOTHCTL_OPTS stream listen $GOLIOTH_DEVICE_NAME
and verifies if temperature measurements are received. Right now an arbitrary number of 10 events is expected, before considering test as passed.
TODO:

[ ] document which environment variables should be set before running this by twister with runtime test (not just build time)
[ ] figure out if there is a better way of passing credentials than via environment variables fetched from Kconfig
[ ] add runtime tests to CI, so that this code actually gets used

Covered as part of #287 and #294


Bug when expanding collapsible widgets on iOS Safari

Open http://responsivebp.com in Safari on iPhone
Tap the hamburger icon
The navbar expands, collapses, and then expands again. It should instead expand only once and remain expanded until interacted with further.

Thanks, seems like something is causing a repaint on Safari before it should.
Do the samples for the dropdown and accordion do the same?
http://responsivebp.com/javascript/dropdown/

Yes, the dropdown and the accordion suffer from the same bug.

Thanks. Just confirmed it on Safari on desktop also. Gotta love these Safari bugs eh?

I wouldn't normally do a release as quickly as this but I think it was such a fundamental issue that it was best to.