newest dependency check is passing Jackson-bom 2.15.2 transitively which in turn passes Jackson-core 2.15.2 which includes java 19 compiled class.

Describe the bug
Jackson-bom 2.15.2 which is being passed in transitively by dependency check includes Jackson-core 2.15.2 which seems to contain a file that was compiled by file version 63 (aka java 19)
Version of dependency-check used
The problem occurs using version 8.3.1 of the gradle (cli, gradle plugin, maven plugin, etc.)
Log file
When reporting errors, 99% of the time log file output is required. Please post the log file as a gist and provide a link in the new issue.
java.util.concurrent.ExecutionException: org.gradle.api.GradleException: Failed to create Jar file /root/.gradle/caches/jars-9/87491e8cdb0229bafcb7120e23222513/jackson-core-2.15.2.jar
Caused by: java.io.IOException: Failed to process the entry 'META-INF/versions/19/com/fasterxml/jackson/core/io/doubleparser/FastDoubleSwar.class' from '/Users/saitx/.gradle/caches/modules-2/files-2.1/com.fasterxml.jackson.core/jackson-core/2.15.2/a6fe1836469a69b3ff66037c324d75fc66ef137c/jackson-core-2.15.2.jar'
at org.gradle.internal.classpath.InstrumentingClasspathFileTransformer.lambda$visitEntries$1(InstrumentingClasspathFileTransformer.java:161)
at org.gradle.internal.classpath.ClasspathWalker.visitJarContents(ClasspathWalker.java:91)
at org.gradle.internal.classpath.ClasspathWalker.visit(ClasspathWalker.java:55)
at org.gradle.internal.classpath.InstrumentingClasspathFileTransformer.visitEntries(InstrumentingClasspathFileTransformer.java:148)
at org.gradle.internal.classpath.InstrumentingClasspathFileTransformer.lambda$instrument$0(InstrumentingClasspathFileTransformer.java:139)
at org.gradle.internal.classpath.ClasspathBuilder.buildJar(ClasspathBuilder.java:66)
at org.gradle.internal.classpath.ClasspathBuilder.jar(ClasspathBuilder.java:53)
... 9 more
Caused by: java.lang.IllegalArgumentException: Unsupported class file major version 63
at org.objectweb.asm.ClassReader.(ClassReader.java:199)
at org.objectweb.asm.ClassReader.(ClassReader.java:180)
at org.objectweb.asm.ClassReader.(ClassReader.java:166)
at org.gradle.internal.classpath.InstrumentingClasspathFileTransformer.lambda$visitEntries$1(InstrumentingClasspathFileTransformer.java:151)
... 15 more
To Reproduce
Steps to reproduce the behavior:

use on a project that is configured for any project that is not using java 19 or above.

Expected behavior
Runs with no errors
Additional context
Add any other context about the problem here.

Jackson is a multi-release jar, which should be fine in any environment that uses a supported java version. Classes under META-INF/versions/ indicate that they should be ignored on any environment  not supporting that java major version and ignored by the rest.

See https://openjdk.org/jeps/238

And see also https://github.com/gradle/gradle/issues/24390

Ah so upgrading gradle wrapper to 7.6 might fix this. Let me try that out.

I'm not much in the gradle ecosystem. Would you be able to verify if gradle 6.9.4 yields the issue?
If not I would still consider it an issue of gradle, but would be good to have the clarity whether all 'current maintained revisions' of gradle are working fine.

Hmm... given https://docs.gradle.org/current/userguide/feature_lifecycle.html#eol_support it appears that 6.9.4 would be an anomaly (as in released despite 8.x was already there so it would typically be seen as EOL) due to the severity of log4shell... I suppose it won't get fixes should it also have the multirelease-jar-support issue.

Same problem here with a gradle 6 multi project, and we can't easily migrate to higher gradle version (will be done later this year).
I found this solution https://github.com/gradle/gradle/issues/24390#issuecomment-1486870261 to force jackson-core version and this works, but forces this version for all dependencies of the gradle sub-projects.
Is there a way to only enforce a specific jackson-core version for the owasp dependency check gradle plugin?

I'm not sure if there is another way to force the version of jackson for ODC. Maybe use classpath instead of all - but I doubt that will work cleanly.
I apologize about issue everyone is facing - I was forced to upgrade the project to gradle 7.x. With making no changes other then incrementing the version of ODC-core the build started failing due to https://github.com/dependency-check/dependency-check-gradle/issues/339
initscript {
    // Temporary workaround
    gradle.allprojects {
        buildscript {
            configurations.classpath {
                resolutionStrategy.force 'com.fasterxml.jackson.core:jackson-core:2.14.2'
            }
        }
    }}

As Hans pointed out - gradle 6 is EOL...

I've upgraded Gradle from version 7.4.2 to 7.6.2, and the issue is fixed.


Cant navigate from RadSideDrawer to Tabview pages

I cant navigate o specific page in my angular app, in this case i want to navigate to (tabs/market-palce/fornecedores) from app.component.ts
Error: Cannot match any routes. URL Segment: 'tabs/market-palce/fornecedores'
and if go from other page thats not app.component.hmtl and print the url it show this
/tabs/default/(marketTab:market-place/fornecedores//cartoesTab:cartoes/default//profileTab:profile/default//experienciaTab:experiencia/default)
im trying this in app.comoponent.ts
 this.routerExtensions.navigate(['tabs/market-place/fornecedores', { relativeTo: this.activeRoute });
here are my routing Modules.
app-routing.module (RadSideDrawer)
 const routes: Routes = [

        {   path: "",
            redirectTo: "/login",
            pathMatch: "full"
        },

        {   path: "login",
            component: LoginComponent
        },

        {
            path: "tabs",
            loadChildren: "~/app/tabs/tabs.module#TabsModule"
        }
]

tabs routing (Tabview)
const routes: Routes = [

    {
        path: "default", component: TabsComponent, children: [

            {
                path: "market-place",
                component: NSEmptyOutletComponent,
                loadChildren: "~/app/market-place/market-place.module#MarketPlaceModule",
                outlet: "marketTab"
            },
            {
                path: "cartoes",
                component: NSEmptyOutletComponent,
                loadChildren: "~/app/cartoes/cartoes.module#CartoesModule",
                outlet: "cartoesTab"
            },
            {
                path: "profile",
                component: NSEmptyOutletComponent,
                loadChildren: "~/app/profile/profile.module#ProfileModule",
                outlet: "profileTab"
            },
            {
                path: "experiencia",
                component: NSEmptyOutletComponent,
                loadChildren: "~/app/experiencia/experiencia.module#ExperienciaModule",
                outlet: "experienciaTab"
            }
        ]
     }
];

market-place Routing (Tabview sub pages)
const routes: Routes = [
    {path: "", redirectTo: "default" },
    {path: "default", component: MarketPlaceComponent},
    {path: "fornecedores", component: FornecedoresComponent }

];

Hi @hitmacreed,
Can you share with us the project or sample one, where the issue can be reproduced?

Well i had  to join my RadSideDrawer with my tabview in one place and then
this.router.navigateByUrl('/tabs/default/(marketTab:market-place/fornecedores')


Adjustments to json-editor

Many files, but really just

"Shortened path to JSON editor": Moved src\components\json-editor\assets\json-editor\monaco-editor to src\components\json-editor\assets\monaco-editor
"Remove unused editor options": Deleted Monaco editor's "languages" other than JSON
"Enable Monaco editor's i18n support": Added configuration in json-editor.html to load Monaco editor's language support

Nice!


allow users to register quay.io images without associated automated builds (will need to manually point at github CWL)

requested by UCSC to support the likes of https://quay.io/repository/ucsc_cgl/samtools

You can manually add quay repos with no automated builds as long as they have quay tags.
However, if the builds were found automatically (quick registered), the qit url will always be blank as the refresh grabs the git url from build info, which won't include any git url.


The more precise search bar, using ALT + SPACE shows that bug

Microsoft PowerToys version
<IP_ADDRESS>
Installation method
PowerToys auto-update
Running as admin
None
Area(s) with issue?
General
Steps to reproduce
Version: <IP_ADDRESS> OS Version: Microsoft Windows NT 10.0.22000.0 IntPtr Length: 8 x64: True Date: 11/07/2024 12:45:27 Exception: System.ArgumentException: Value does not fall within the expected range.    at Wox.Plugin.Common.Win32.NativeMethods.DwmSetWindowAttribute(IntPtr hwnd, Int32 attr, UInt32& attrValue, Int32 attrSize)    at PowerLauncher.ViewModel.MainViewModel.ToggleWox()    at PowerLauncher.ViewModel.MainViewModel.b__147_0()    at System.Windows.Threading.Dispatcher.Invoke(Action callback, DispatcherPriority priority, CancellationToken cancellationToken, TimeSpan timeout)    at System.Windows.Threading.Dispatcher.Invoke(Action callback)    at PowerLauncher.ViewModel.MainViewModel.OnHotkey()    at PowerLauncher.ViewModel.MainViewModel.ProcessHotKeyMessages(IntPtr wparam, IntPtr lparam)    at PowerLauncher.MainWindow.ProcessWindowMessages(IntPtr hwnd, Int32 msg, IntPtr wparam, IntPtr lparam, Boolean& handled)    at System.Windows.Interop.HwndSource.PublicHooksFilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)    at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)    at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
✔ Expected Behavior
No response
❌ Actual Behavior
No response
Other Software
No response

/bugreport

Fixed in the latest version. Please update to 0.82.1
/dup #33504


chore(main): release xcm-analyser 1.3.2

:robot: I have created a release beep boop
1.3.2 (2024-08-30)
Miscellaneous Chores

Perform montly check ✨ (3f20805)
Remove unused standard-version package 🔨 (f36f10c)

Continuous Integration

Integrate Codecov PR comments 💬 (220da1b)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

xcm-analyser-v1.3.2
:sunflower:


HTTP::Server::Async!parse does not handle all legal header configurations.

The parse() method at line 120 (as of this writing) does not support all possible header formats.
It fails for repeated/duplicate headers and also for headers whose values are split across multiple lines.  See [HTTP spec, section 4.2.] (http://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html#sec4.2).
The code my %h           = @lines.map({ .split(':', 2).map({.trim}) }); is used to unpack headers.
Any lines with leading spaces need to be trimmed and concatenated with the preceding line.  This should be doable with a  boring-ish for loop and indexes.  There may be a sexier perl6y way to do the same, but I don't know it.
As for duplicated headers, there are a number of choices, keep using a hash and make your code append rather than overwrite duplicate values.  Also, you could make a hash-like type that handles these multiple values cases.
Furthermore, thanks for writing this.

@daotoad I'll update this and push, thanks for bringing this up

@daotoad this should work as expected now.


add: solid state chemistry questions

I wonder if for materials science, we can think of some things like:

describing a phase diagram and then interpreting it
you measure a TGA and observe certain features, how do you interpret them?

Also wondering if questions like: lists of potential boiling/melting/glass transition temperatures could make sense (as some orderings will clearly be non-physical) - i.e. glass transition after melting makes no sense

@n0w0f maybe you can rename the files?

also, the name field in the jsons is the same for all 3 questions

@kjappelbaum maybe this speaks to having a name field validator?

also, the name field in the jsons is the same for all 3 questions

what is the preferred choice ? there are dir with same name for all jsons.

I wonder if for materials science, we can think of some things like:

describing a phase diagram and then interpreting it
you measure a TGA and observe certain features, how do you interpret them?

good idea

also, the name field in the jsons is the same for all 3 questions

what is the preferred choice ? there are dir with same name for all jsons.

I think what we have done so far is say that filepath has to be unique by definition and use this as a name. I am open to other suggestions, but we would then perhaps need to apply them to the others. Seems like a separate new issue to me.


Text on Import Partners references storage locations.  It should not.

Summary
The text on import partners references storage locations.  It shouldn't.  Fix it.
Why
Avoid new bank confusion
Details
Partner Agencies | Import Partners

The text in "Upload your CSV file" and at the bottom refers to storage locations.  It should refer to partners.
I'm pretty sure this is in a shared layout, so you'll need to be careful not to change the text for storage locations.
That also implies there may be other imports that use it.  They'll need to be addressed as well.
Criteria for completion

[ ] Import partners text refers to partner agencies
[ ] Import storage locations still refers to  storage locations
[ ] Check for other code using this  and make them accurate
[ ] tests to support

@cielf I would like to work on this one

You got it, good luck!


UUID v4 generation

Random UUIDs are specified in RFC 4122 Section 4.4. There are six bits with a fixed value that either give the version number or are reserved for future use. The random UUIDs generated by this crate and labeled v4 are completely filled with random bytes and thus differ from the RFC. I am aware that it is possible to set the values with set_version and set_variant and get RFC conforming UUIDs. I think the crate should only generate RFC 4122 UUIDs so the version and variant field can be read. At least the new_v4 should be renamed to another name like new_random.

Sounds reasonable to me! Would you like to send a PR?

Sorry, the crate already generates correct UUIDs: I only missed the implementation of Rand for Uuid. :confused:


Bug: Articles on web/mobile are not reloaded when page is reloaded

Describe the bug
When going to any project article page (such as https://blanke.tech/articles/website-design) and then reloading that page then a 404 not found error occurs even though that page exists and was just visited. Going back in browser history does not help the issue.
To Reproduce
Steps to reproduce the behavior:

Go to https://blanke.tech/articles/website-design
Reload the page
See 404 error

Expected behavior
Page and article should load correctly
Screenshots

Desktop (please complete the following information):

OS: Windows 10
Browser: Chrome

Smartphone (please complete the following information):

Device: OnePlus 5
OS: Android
Browser: Chrome

Creating this issue to document the error.

Creating this issue to document the error.

Further investigation revealed that the favicon might have something to do with the bug.

Further investigation revealed that the favicon might have something to do with the bug.

I think this is casued by Nuxt being built in SPA mode, since this will affect how 404's are handled.
Try changing to universal mode and see if that resolves the issue.
https://github.com/andSubmarine/andsubmarine.github.io/blob/b26a79694fa126db0c75829299d8c1e8c6ad7772/nuxt.config.js#L6

I think this is casued by Nuxt being built in SPA mode, since this will affect how 404's are handled.
Try changing to universal mode and see if that resolves the issue.
https://github.com/andSubmarine/andsubmarine.github.io/blob/b26a79694fa126db0c75829299d8c1e8c6ad7772/nuxt.config.js#L6

@niclashedam I tried your idea, but it, unfortunately, did not resolve the issue. But I also think you're correct that this bug is due to some weird configuration issue.

@niclashedam I tried your idea, but it, unfortunately, did not resolve the issue. But I also think you're correct that this bug is due to some weird configuration issue.

If you generate your site with the current configuration, you'll see that it compiles an index.html, but not the articles directory. This means that for GitHub Pages to serve your site, it must know where to route the article URL dynamically. Therefore you should investigate either to statically generate the pages, so the HTML for the articles exist or route 404 via your Nuxt router.

If you generate your site with the current configuration, you'll see that it compiles an index.html, but not the articles directory. This means that for GitHub Pages to serve your site, it must know where to route the article URL dynamically. Therefore you should investigate either to statically generate the pages, so the HTML for the articles exist or route 404 via your Nuxt router.

Further investigation revealed that dynamic routes such as those for articles were not being generated automatically although Nuxt supposedly uses a crawler to do so. A fix has been introduced with commits 4a2ba47ab280bd16dd4258401499314ab951ae5e and fd690d447d06d464030ab667850bd6da8c6d558a.
@niclashedam thanks for your ideas and help - much appreciated!
This issue will now be marked as closed. For future reference, the estimated time spent on solving this issue was approx. 4 hours in total.


SonarQube SonarTsPlugin report not showing any Issues on Typescript files

Hi,
I installed sonarqubbe 6.2 on ubuntu 14.04, and my SonarQube Scanner version is <IP_ADDRESS>8, which I configured in jenkins. I have installed SonarTS plugin version 1.1.0. The issue I am facing is, The report generated has the issue recorded for .js files but it showing 0 issues on all .ts files.
my sonar-project.properties files as follows
sonar.projectKey=Test
sonar.projectVersion=2.0
sonar.projectName=Test
sonar.sourceEncoding=UTF-8
sonar.sources=/jenkins1/slave02/workspace/Sonar-test/src
sonar.ts.tslint.projectPath=/jenkins1/slave02/workspace/Sonar-test/tsconfig.json
sonar.ts.tslintpath=/jenkins1/slave02/workspace/Sonar-test/node_modules/tslint/bin
sonar.exclusions=/jenkins1/slave02/workspace/Sonar-test/node_modules/**
sonar.ts.tslint.configPath=/jenkins1/slave02/workspace/Sonar-test/tslint.json
I have configured Path to tslint as /usr/local/bin/tslint in sonarQube server UI.
appreciate any help on this.

Hi can any one help on this?
I am seeing the tslint is executing against the *.ts files but it is not generating any issues. but If I run the command 'npm lint' manually it is showing lots of issues.
I am not  able to fix this issue.

Solved the issue. Downgrade the plugin  to 1.0.0


fixed close popover when closeByOutside is false and removeOnClose is true

fixed popover close by outside when remove on close is true

Notes:

When popover property removeOnClose is true and closeByOutside is false, the popover didn't close correctly
Fixed this issue

Hi there,
I just fixed an issue with closeByOutside property.
I found it out while I was developing a plugin for Framework7, which I sent to @nolimits4web for checking.
Framework7 Plugin Tour Guide: https://github.com/razekteixeira/Framework7-Plugin-Tour-Guide
Please take a look on this change and if possible take a look at the plugin ;)
If it is worth it, I'll ask for help on how to publish that :+1:
Best Regards,
César Teixeira

Looks good, thanks!


Use accelerate to clip gradient norm

Follows best practice here: https://huggingface.co/docs/accelerate/v0.1.0/accelerator.html.
Should only really make a difference in case accelerator uses the following:
 if self.state.use_fp16 and self.native_amp

@lvwerra already added it in #546 :) https://github.com/lvwerra/trl/blob/a21d2c2d22e0045dfc845ef2f5b0ff8f02bf9c5d/trl/trainer/ppo_trainer.py#L1004-L1006

Oops! Thanks @vwxyzjn!

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Adds support for Swift Package Manager

Checklist

[x] All tests are passed.  (https://developer.apple.com/library/mac/documentation/Xcode/Reference/xcode_markup_formatting_ref).
[x] Searched existing pull requests for ensure not duplicated.

Fixes #23

Thank you!


Adding partial_optimize functionality, a NonNegative variable class, and a small change to the Variable class.

Could you make this a pull request to the develop branch instead? Things have gotten too complicated (many pull requests and features in progress) to develop on the master branch.

Also, it may take me a little while to merge this in. I may want to implement partial_optimize in a different way. I need to think about it.
I don't like changing deepcopy. It would be much better to just copy the LinOp tree manually. I'll help you with this on the cvxstoch repo.


improve error message for failed overload matching

addresses #140
This is not perfect, but shows the direction in which the error messages should go in my opinion. Even better would be to include the signature that the method tried to match. Hints at how to best achieve this would be appreciated ;-)

have a look at the matchreport method. It shows how to obtain the argument types.

Actually, I can find no place where the HostRef is transformed to a String. I see I can query HostEnv about it, but can I also get the type? I can't even find a way to convert HostRef to JType. All the instances I have seen are a JType checking that the HostRef can be converted to it, the JType converting it. In order to properly display what arguments were given, I need to be able to print the type without having a signature beforehand, if that makes sense.

Your pull request doesn't compile. See the Travis output.

Think this has been addressed by #172


Fix Camera Anchor Indicator

Fixes #113

Solution

Replace the gizmo with a UiImage visible only on the correct camera.
Added this MIT licensed placeholder icon to use as image.

It's good to go :+1:


Add --verbose mode to etl command

We're making spelling mistakes quite often when calling the DAG using etl mystep and what we often get back is just All datasets are up to date without knowing what's going on under the hood. This is hard to debug. This got recently improved with raising error when no steps are found, but I was thinking that maybe having --verbose/-v flag logging what steps are already completed (and perhaps other info) could be useful.

@wcox13 do you think this would be useful or would it be just adding useless code to our codebase?

what exactly would be the new info/format here? i thought we already had some output describing which steps are run
maybe which steps are up to date / not run?

oh sry, just reread— i just suggested what you wrote already
i think no harm in adding useful logging. does it need to be under a verbose flag? could just have it on by default, i don’t think one line per step would be too noisy. but either way works

Thanks, you're right in that there's no harm, but also probably not much to gain... So low priority, anyway, leaving this open if we come up with something more interesting to log.


Randomly missing SVG and XY points output from .toDataURL('image/svg+xml') and .toData()

Do you want to request a feature or report a bug?
Possible bug. Unfortunately, we are unable to re-create it, but we wanted to check if other users are experiencing it to gather more data and help with debugging.
What is the current behavior?
We export user-inputted signature in PNG, SVG and XY points and save it in the backend.
Randomly, SVG and XY points will be empty, but PNG is still generated correctly. It's happening for about 3 out of every 100 signatures we collect.
SVG output from .toDataURL('image/svg+xml') is empty except for the svg headers.
XY Points output from .toData() is only an empty array.
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://jsfiddle.net or similar (template: https://jsfiddle.net/szimek/h80phxyr/).
Unfortunately, we are unable to re-create it, but we wanted to check if other users are experiencing it or have stumbled upon it.
What is the expected behavior?
SVG and XY points are consistently exported together with the PNG.
Which versions of SignaturePad, and which browser / device are affected by this issue? Did this work in previous versions of SignaturePad?
SignaturePad version 2.3.2
SignaturePad version 2.1.0
Not tied to specific browser or device based on the failures we have reviewed.

That's strange :/
When .toDataURL is used to generate PNG or JPEG image, it simply delegates to canvas element to generate this image - it's not using collected point data at all. .toDataURL('image/svg+xml') on the other hand uses the same data that is returned from .toData method to generate SVG, that's one if .toData returns an empty array, .toDataURL('image/svg+xml') generates an empty SVG.
This internal data structure (SignaturePad#_data) is (or rather should be) only cleared when SignaturePad#clear is called.

This is due to the SVG generation code and HiDPI devices.
The ratio will be >1, and it makes the resulting maxX and maxY smaller than the generated SVG it created using the canvis width and height.
Editing the code to remove the ratio makes it work as expected. I imagine also using the ratio adjusted maxX and maxY values when you create the SVG would also fix the problem.
There is no function options passed into SVG, so currently you cannot override any of this like you can for the other image formats.

I think this issue still not fix. We just experience missing svg attributes also svg end tag from the .toDataURL('image/svg+xml'). any work around for this issue? I hope this get fixed.

@junardoclarit are you able to reproduce this and provide steps to reproduce the issue?

closing as stale


How to build templates server side

Is there a way to do this functionality server side completely. I'm actually trying to run a cron job to generate emails to be sent to my users. This package is amazing to iterate on email templates but I'm having a hard time figuring out how to install all of this functionality in something like firebase functions.
What's the best workflow for this ?

nvm I think I found out what needs to be done. The steps would be:

use the starter repo.
Iterate on your email template
export out the js code
import in your backend and just call the function with right props for substitution.

Here's an example of what @rahulravindran0108 listed out above in case anyone is struggling with this:
import EmailComponent from "path/to/component";
import { render } from "@react-email/render";

const html = render(EmailComponent({prop1: 'value'}))

hey @zachgoll
error -<EMAIL_ADDRESS>(10:17) @ render
error - react_dom_server__WEBPACK_IMPORTED_MODULE_0__.renderToStaticMarkup is not a function


protoc-gen-go: generate Setters for oneof fields

The library provides only Getters for oneof fields. Because of this, setting oneof fields is painful.  For example:
message RequestWrapper {
    string request_id = 1;
    string session_id = 2;

    oneof request {
		actions.BuyStocksFromExchangeRequest buy_stocks_from_exchange_request = 3;
		actions.CancelAskOrderRequest cancel_ask_order_request = 4;
		actions.CancelBidOrderRequest cancel_bid_order_request = 5;
                . . .
    }
}

message ResponseWrapper {
    string request_id = 1;

    oneof response {
		actions.BuyStocksFromExchangeResponse buy_stocks_from_exchange_response = 3;
		actions.CancelAskOrderResponse cancel_ask_order_response = 4;
		actions.CancelBidOrderResponse cancel_bid_order_response = 5;
                . . .
    }
}

message DalalMessage {
    oneof message_type {
        RequestWrapper request_wrapper = 1;
        ResponseWrapper response_wrapper = 2;
        DataStreamUpdateWrapper data_stream_update_wrapper = 3;
    }
}

Here, The Response messages themselves have oneof fields. Creating a DalalMessage type, then, has to be done in this manner:
dm := &socketapi_proto.DalalMessage{}
dm.MessageType = &socketapi_proto.DalalMessage_ResponseWrapper{
	ResponseWrapper: &socketapi_proto.ResponseWrapper{
		Response: &socketapi_proto.ResponseWrapper_BuyStocksFromExchangeResponse{
			BuyStocksFromExchangeResponse: response.(*actions_proto.BuyStocksFromExchangeResponse),
		},
	},
}

This is clearly painful. Instead, if setter methods are provided, the same code would be much shorter and readable:
rw := &socketapi_proto.DalalMessage_ResponseWrapper{}
rw.SetResponse(response.(*actions_proto.BuyStocksFromExchangeResponse))

dm := &socketapi_proto.DalalMessage{}
dm.SetResponseWrapper(rw)

Of course, this can be shortened further if protobuf does not wrap the fields inside a oneof field, but I assume that will break a lot of people's code. I also don't know the side effects of not wrapping oneof fields.
Even if the oneof fields stay wrapped, I believe that providing Setters will neither break anyone's code, nor will cause any side effects.
Sample output after adding a Setter:
// Generated already
func (m *DalalMessage) GetRequestWrapper() *RequestWrapper {
	if x, ok := m.GetMessageType().(*DalalMessage_RequestWrapper); ok {
		return x.RequestWrapper
	}
	return nil
}

// Generated as per this proposal
func (m *DalalMessage) SetRequestWrapper(rw *RequestWrapper) {
	m.MessageType = &DalalMessage_RequestWrapper{
		RequestWrapper: rw,
	}
}

I'm sure there are others facing this issue. (https://github.com/golang/protobuf/issues/205).

Your example is already somewhat more verbose than necessary.  It can be written today as:
dm := &socketapi_proto.DalalMessage{
  MessageType: &socketapi_proto.DalalMessage_ResponseWrapper{
    &socketapi_proto.ResponseWrapper{
      Response: &socketapi_proto.ResponseWrapper_BuyStocksFromExchangeResponse{
        response.(*actions_proto.BuyStocksFromExchangeResponse),
      },
    },
  },
}

It would be somewhat simpler if https://github.com/golang/go/issues/12854 were accepted.  Then your example could be written:
dm := &socketapi_proto.DalalMessage{
  MessageType: &socketapi_proto.DalalMessage_ResponseWrapper{{
    Response: &socketapi_proto.ResponseWrapper_BuyStocksFromExchangeResponse{
      response.(*actions_proto.BuyStocksFromExchangeResponse),
    },
  }},
}

Hmm, I wasn't aware that we could omit the field name if there was only one field. Also, the golang/go#12854 PR would make it much simpler, but I still don't see how a setter could harm. It would provide a nice uniform interface - this way there'd be no need to access the oneof field, instead we could directly access the 'children' - so to say. So in the above, I could simply call dm.SetResponseWrapper()  instead of even knowing about existence of MessageType.
Also, setters are available in other languages.

I too find this more painful than it needs to be.
Curious why is a wrapper type generated for oneof fields? As far as I can tell the wrapper types all just implement an interface isXYZ_Type.

Hmm, I wasn't aware that we could omit the field name if there was only one field. Also, the golang/go#12854 PR would make it much simpler, but I still don't see how a setter could harm.

@thakkarparth007 I think this is a good point, and it doesn't really look to me like golang/go#12854 will be accepted any time before Go2, if then, whereas we could have a setter today.
I'm trying to clean up some sprawling, overloaded protobufs with too many fields by replacing with oneofs which more accurately describe each use case, but I am concerned that other developers in my project will reject the awkwardness required to wade through this nesting.  It's really not ergonomic at all.  For me, what gogo provides in its "onlyone" extension (https://github.com/gogo/protobuf/tree/master/plugin/union) is what I'm looking for, but I don't want to switch out to that if I can help it.

onlyone is a solution I enjoy using, but unfortunately it also only works if your union is between different field types.  So I have sympathy for fixing this in the general case.
gogoprotobuf really struggled coming up with a better solution for oneof
https://github.com/gogo/protobuf/issues/168
The current generated code is far from something that I want to use (so I avoid using oneof), but coming up with a good solution in a language which does not support tagged unions is really hard.
My advice is to stop using Go ;)

@aajtodd how the current implementation works is by generating a field for the one-of, rather than the children of one-of. For example:
message Foo {
    oneof bar {
        uint32 apples = 1;
        string oranges = 2;
    }
}

This creates a struct Foo with one field "bar". So if both "apples" and "oranges" - of types uint32, and string respectively are to be assigned to the same field "bar", then they must have the same type. That is achieved by wrapping them into a empty interface of a common name. That allows you to set bar to an integer, or to a string, or whatever you have inside the "oneof".

Your example is already somewhat more verbose than necessary. It can be written today as:

@bcmills @thakkarparth007 FWiW I finally got around to trying this, and go vet flags it:
.../blah.go:100: bg/common_msg.Blah_Blah composite literal uses unkeyed fields

So for us it's a non-starter, as the rest of our codebase is vet clean.

I believe a dedicated setter would be a great improvement.
A setter would make the messages less verbose AND it would allow proto file providers to document an API usage pattern that won't break if a oneof block is removed or added in the future.
For Java, C++, JavaScript and Python the way you set parameters for messages doesn't change if the proto file uses oneof blocks or doesn't use them. For Go, since there is no dedicated uniform setter method style, a users code will break if there is a removal or an insertion of a oneof definition. You're essentially locked into that definition with Go, but with other protobuf languages you can change it over time.
I would like to use oneof and I'm willing to commit to not taking them out in the future, but it's so absurdly verbose, I think users will be put off from using the client library all together. A setter method would be a great way for the message building process to still be manageable to someone learning a new library.
Below is an example of with and without oneof.
        operator := &pb.OperatorRequest{
		LeftGeoms:&pb.OperatorRequest_LeftGeometryBag{&serviceGeometry},
		RightGeoms:&pb.OperatorRequest_RightGeometryBag{&cutterGeometry}}

	operator := &pb.OperatorRequest{
		LeftGeometryBag:&serviceGeometry,
		RightGeometryBag:&cutterGeometry}

I'm new to Go, so I maybe misunderstanding how to use protoc generated code.

The current solution is certainly not ideal, but I'm going to put this on hold for until there's a resolution on golang/go#19412.

@dsnet, I recently read most (but not all) of golang/go#19412, and it seems:

There's not any sort of concrete plan to go forward with that proposal.
It would exclusively target Golang 2.

Golang 1.x seems likely to be around for a long time; a solution now would benefit many implementors at least for several years to come.  Could this be designed in such a way that it's not obviously clashing with the aforementioned proposal?

So after a good hour or so of copy/pasting, I now have setters on my messages.
Hay at least in Go, you can add methods to a type in another file:)
extra.go:
func (r *Req) SetXXXReq(req *XXXReq) {
	r.Body = &Req_XXXReq{XXXReq: req}
}

func (r *Rsp) SetYYYRsp(rsp *YYYRsp) {
	r.Body = &Rsp_YYYRsp{YYYRsp: rsp}
}

By default we cannot enable this feature since the "SetXXX" method could conflict with an actual field named "SetXXX". This is not a hypothetical scenario, but a real problem.
At best, this would be a generator option that one can opt-into.

Don't know if this was already answered, but I saw this question asked couple of times, why is it necessary to have a wrapper around other messages in an oneof? I do understand why you need the message for the primitives but not sure why for messages. Because of that an unnecessary extra allocation is needed.
I know may be too late to change but want to understand if I miss something

By default we cannot enable this feature since the "SetXXX" method could conflict with an actual field named "SetXXX". This is not a hypothetical scenario, but a real problem.
At best, this would be a generator option that one can opt-into.

It seems you could work around method name conflicts the same way other name conflicts are handled - append an underscore or something.
I have no problem with an option but I disagree that setters would need to be an opt-in at best.

It sounds like how to handle the conflict in a case like the following is the main complication of the proposal:
message Collection {
  Collection set_of_numbers = 1;
  oneof contrived_oneof {
    Bar of_numbers = 2;
  }
}

type Thing struct {
  SetOfNumbers *Collection // should this be called SetOfNumbers_, or should the setter be called SetOfNumbers_(?
  ContrivedOneof Thing_ContrivedOneof
}
// ...
func (m *Thing) SetOfNumbers_(v *Bar) { /* ... */ }

/// OR

type Thing struct {
  SetOfNumbers_ *Collection
  ContrivedOneof Thing_ContrivedOneof
}
// ...
func (m *Thing) SetOfNumbers(v *Bar) { /* ... */ }

There is probably logic in the reflection package that is relevant to handling the edge case, perhaps among other places.

https://github.com/lcmaguire/protoc-gen-go-setters
there is a plugin if you want auto generated setters


Hint at how to properly close issues with pull requests

Mentioning issues in your PR with some magic keywords can automatically close these issues when the PR is merged. We even hint at this in our PR-template already.
However, GitHubs implementation of this does not work super well with our release/branching model. Specifically, it only works if the PR is merged into the default branch, which is develop in our case.
It can be made to work in our situation if the magic phrases are mentioned in commit messages alternatively or in addition to the PR description, because we regularly forward merge the release branches.
This patch adds a corresponding note about this to the PR template.

The information is already in the linked documentation. I'm not sure trying to turn the checklist into additional documentation (especially since this is copied into every pull request) is a good idea. If you want it in here, maybe just turn it into a very short instruction of what to do instead? Something like:

[ ] close an accompanying issue if one exists. E.g. put fixes #123 in the commit message

If you think a longer explanation is required, I suggest putting that one into the developer documentation and linking it from here instead of linking to the GitHub documentation? That allows you to properly explain what's going on and how this works given Opencast's branching model.

I second @lkiesow opinion.

IIRC that was the tenor in the technical as well. I got it, I will do it, but it's rather low on my list rn. ;D

I Like @JulianKniephoff description, but also Lars link suggestion to keep it as a link for tidiness. The description on the GitHub page is not as clear as Julian's.
Could it be possible to add Julian's explanation to the documentation and make a link to the GitHub PR template?

Finally got to this again. (*Tries to get stuff off their plate.)
(Re-)requesting review from everyone who complained. xP

Fixed the conflicts, which required me to move the blurb somewhere else. I hope this is fine. To not drag this out any further I will just merge it now without another round of reviews. It has a review, others had the chance, and this is basically a docs PR anyway. 🤷♀


Add jobs & mailers to default Rails/ActionFilter config

They use the same filter/action API.

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
n/a Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
n/a If this is a new cop, consider making a corresponding update to the Rails Style Guide.

Can you provide a link to the official documentation on these jobs and mailers filter / action API?

https://edgeguides.rubyonrails.org/action_mailer_basics.html#action-mailer-callbacks and actionmailer/lib/action_mailer/base.rb:    include AbstractController::Callbacks
Yeah, thinko about jobs, API is different there.


setup-pgvector.sh is corrupting /etc/sudoers file

Running the script will result in the /etc/sudoers file containing only "ray ALL=(ALL:ALL) NOPASSWD:ALL"
need to modify the line "echo 'ray ALL=(ALL:ALL) NOPASSWD:ALL' | sudo tee /etc/sudoers
"
to "echo 'ray ALL=(ALL:ALL) NOPASSWD:ALL' | sudo tee -a /etc/sudoers"

This needs a 'hot fix'. I modified the line with echo 'ray ALL=(ALL:ALL) NOPASSWD:ALL' | sudo tee /etc/sudoers.d/ray instead.


Error parsing data group from zarr filenames

When using zarr files loaded from the web, and the data group is not explicitly set in the filename, this is incorrectly parsed and causes an error when getting the source data.

Fixed with PR #18


Windows: Module build failed: Error: Couldn't find preset "es2015" relative to directory "."

I get this build error when I try to npm start
Module build failed: Error: Couldn't find preset "es2015" relative to directory "."

Which node version are you using?
node -v

If you can, please use 6.x.x

I use: v4.2.4
On the Node website they state this:
Current version: v4.5.0 (includes npm 2.15.9)

So @stylesuxx you want me to get version 6 and also run on a beta version of npm? (version 3) ?

4.5.0 is LTS
6.x.x is Current
And the generator should work with node >= 4.5.0. Also since node 5.0.0 npm 3.x.x is used. It is not beta, it is the version node is "bundled" with. You can check the node release history here => https://nodejs.org/en/download/releases/ it also lists the npm version it came bundled with.

@stylesuxx Now I have this setup:
node: 3.10.8
npm: 3.10.8

still I get this error when running npm start
ERROR in ./src/index.js
Module build failed: Error: Couldn't find preset "es2015" relative to directory "."

I have done npm install before doing this...
I am running windows 7.

Node 3.10.8? I guess that is a typo. Point why I am asking for your versions is, so that I can play it through with the exact versions. Last weekend I tried with node v.4.5.0 all the way up to v6.5.0, with 3.x npm without a problem.
The following might help (I'd still rather debug the current problem):
npm install babel-preset-es2015

Thank you. It solved the problem!
I want to share this info however. I got this note as I did the npm start:
This preset is no longer necessary and can be replaced by the following:
        presets: [
                ["es2015", { "modules": false }]
        ]

So perhaps something should be changed in the generator. Have a great day! :-) You may mark this issue as solved.

hi, just stumbled over this. @netsi1964 the deprecation warning can be solved by updating your .babelrc to read like this. This is already fixed in the base template repo, but afaik not yet published.
Concerning the npm install babel-preset-es2015: I've also started hitting that lately (on two build servers, not locally). We might have to check whether something changed in the type of dependencies, that lets babel-preset-es2015 miss all the sudden. Would definitely be an issue on the template repo (I'll file and check it there).

I tried to uninstall the babel-preset-es2015 and updated the .babelrc and then ran the npm start.
I then got an error again.
I then reinstalled the babel-preset-es2015 and did a npm start again which lead to the app working and without getting any messages related to the .babelrc settings.

@netsi1964 that is expected. The deprecation warning and the error are two separate issues. The npm install gets the error out of the way, the updated .babelrc the deprecation warning.


error[E0425]: cannot find value serialized_resource_str in this scope

Cargo dependency
bevy-persistent = { version = "*", features = ["ron", "pretty"] }

Compilation Errors
   Compiling bevy-persistent v0.3.0
error[E0425]: cannot find value `serialized_resource_str` in this scope
   --> _<PATH HIDDEN>_\.cargo\registry\src\index.crates.io-6f17d22bba15001f\bevy-persistent-0.3.0\src\format.rs:174:36
    |
174 |                 ron::from_str::<R>(serialized_resource_str).map_err(|error| {
    |                                    ^^^^^^^^^^^^^^^^^^^^^^^ help: a local variable with a similar name exists: `serialized_resource`

error[E0425]: cannot find value `serialized_resource_str` in this scope
   --> _<PATH HIDDEN>_\.cargo\registry\src\index.crates.io-6f17d22bba15001f\bevy-persistent-0.3.0\src\format.rs:181:36
    |
181 |                 ron::from_str::<R>(serialized_resource_str).map_err(|error| {
    |                                    ^^^^^^^^^^^^^^^^^^^^^^^ help: a local variable with a similar name exists: `serialized_resource`

For more information about this error, try `rustc --explain E0425`.
error: could not compile `bevy-persistent` (lib) due to 2 previous errors

Temporary Solution
Add feature "toml". This will trigger the macro at line number 141 and will create serialized_resource_str
I tried to modify the line 141 (add feature = "ron"), but this seems to be more complicated issue.

Ron was added later and feature checks was forgotten it seems. CI architecture for every feature combination would be too complicated and time consuming so unfortunately it's not easy to test.

Should be fixed with https://crates.io/crates/bevy-persistent/0.3.1 :wink:

good good 👍


xserver.nix generates faulty xserver.conf on nvidia+amd hybrid graphics systems

Describe the bug
As the title suggests xserver.nix is broken, and I'm not skilled enough to troubleshoot it. while reading through it I did see that it was supposed to create a device and screen section per driver, but what it does instead is make 3 device sections, one duplicate and it also creates a duplicate screen section for the amd device but no nvidia screen

Steps To Reproduce
Steps to reproduce the behavior:
    services.xserver.videoDrivers = [
      "nvidia"
      "amdgpu"
     ];

Expected behavior
the xserver.conf file isn't malformed and actually functions
xserver.conf  snippet
Section "ServerLayout"
  Identifier "Layout[all]"
  Option "AllowNVIDIAGPUScreens"

  # Reference the Screen sections for each driver.  This will
  # cause the X server to try each in turn.
  Screen "Screen-amdgpu[0]"
Screen "Screen-amdgpu[0]"

EndSection

# For each supported driver, add a "Device" and "Screen"
# section.

Section "Device"
  Identifier "Device-amdgpu[0]"
  Driver "amdgpu"

EndSection

Section "Screen"
  Identifier "Screen-amdgpu[0]"
  Device "Device-amdgpu[0]"

EndSection

Section "Device"
  Identifier "Device-amdgpu[0]"
  Driver "amdgpu"

  BusID "PCI:50:0:0"

EndSection

Section "Screen"
  Identifier "Screen-amdgpu[0]"
  Device "Device-amdgpu[0]"

EndSection

Section "Device"
  Identifier "Device-nvidia[0]"
  Driver "nvidia"

  Option "SidebandSocketPath" "/run/nvidia-xdriver/"
  BusID "PCI:1:0:0"

EndSection

Additional context

Metadata

system: "x86_64-linux"
host os: Linux 6.6.63, NixOS, 25.05 (Warbler), 25.05.20241205.d0797a0
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.25.2
channels(root): "nixos-24.05, unstable"
nixpkgs: /nix/store/nr5nl3zwzl02x3rnikjbry3s5xy7bm1d-source

Notify maintainers

Note for maintainers: Please tag this issue in your PR.

Add a :+1: reaction to issues you find important.

I made this issue while sleep deprived and described the problem poorly, edited now to make it more coherent.


Ops-Eng Python Refactor: repository.py to move_users_to_teams.py

Create a united code base
As a developer
I want refactor the existing code into the script and utilise the GH Service layer code
so that this code follows the code standard for this repository
Code will exist either in script or in the service layer
Functional Requirements:

Move the repository.py code into move_users_to_teams.py
Refactor the code across move_users_to_teams.py and github_service.py
Add / move the tests to reflect these changes.
Do not replace the current code until organisation.py is also ported to move_users_to_teams.py

Acceptance Criteria:

Code is moved over from repository.py to move_users_to_teams.py.
Test pass in move_users_to_teams.py and github_service.py
Current move_users_to_teams.py tests will pass.

Notes:

See commit.


EXC_BAD_ACCESS Crash When Calling Delegate

I've created a WebView which responds to a URL change event.
The crash happens most often when calling a delegate multiple times very quickly, but have been able to reproduce when my WebView isn't completely instantiated on first load as well (although rare). If I click a button in my WebView that changes the URL even three times very quickly, I get the crash every time.
Since EXC_BAD_ACCESS commonly relates to referencing an object which no longer exists, I saw this line as suspect in MochaJSDelegate:
var dynamicFunction = eval('(function (' + args.join(', ') + ') { return dynamicHandler.apply(this, arguments); })')

If I replace with this, it works flawlessly:
delegateClassDesc.addInstanceMethodWithSelector_function_(selector, function() {
     func.apply(delegateClassDesc, arguments);
})

Somewhere along the way of using eval and calling the two anonymous functions (see also dynamicHandler function), a disconnect exists with memory management. Note that with my workaround, I'm unable to access the function parameters in my delegate function, so it's not a real solution for the MochaJSDelegate library.
As a result I ended up creating the class delegate manually myself (allowing me to access arguments), but it'd be nice if I could have both arguments and no crashing in the current lib so I don't have to do it manually in my app.
If you have any ideas with that broad overview let me know! I can setup an example if you aren't sure just based on that information where the issue is.
Thanks!

Thanks for the detailed issue! This is interesting, as I've seen similar issues, but been unable to track down the exact point of error. Will look into this.

 What I listed above about a race condition / memory allocation issue is still valid, but I've tracked down a telling side effect.
In Googling some more about unrelated issues, I noticed a closed issue in this repo about a delegate having the wrong number of parameters crashing the application. Sure enough, I removed some of the parameters off the delegate and I was able to determine that I can only reliably depend on the first two parameters here:
https://developer.apple.com/reference/webkit/webframeloaddelegate/1501451-webview?language=objc
The third parameter, seconds, is unreliable when triggering the delegate many times if short succession.
That can either help track down the issue, or introduce a try/catch to continue gracefully if the parameter doesn't exist :)


[Import]: path to request attachment is incorrect for imported conversation

EPAM AI DIAL chat version
0.4.2
What happened?
Steps:
1 create conversation based on request with attachment, e.g. GPT-4 Vision model
2 export conversation
3 delete conversation and file attachment from bucket
4 import conversation and try to download attachment -> path to attachment api/files/bucket/filename not found
Expected result: correct path is api/files/bucket/imports/conversation_name/filename

Confidential information

[X] I confirm that do not share any confidential information

cannot reproduce on staging env


Form validation > investigate 'native widget' announcements

"The Email, Option checkboxes and terms and conditions checkbox are detected as native widget functions, but First name, Last name and Also known as fields aren't"

@mjbp - Can you remember the context of this one?  I think it was from the AX audit of the patterns, but I couldn't find the sheet to see if there was more info there

@sarah-storm It was from that audit. The audit file has moved from the link location I have so I don't have any further context on device combination, etc, but I do recall this one - at the time I suspected it was a false positive, describing the way the screen reader was announcing different input types and it was the expected behaviour (also nothing sensible we can do to change it).
I'll close it with this comment.


Portuguese / Spanish not working

I have test to portuguese language but it's not working. Why?
Traceback (most recent call last):
  File "synonyms2.py", line 8, in <module>
    token = nlp('prices')[0]
  File "/home/gleidson/.local/lib/python3.8/site-packages/spacy/language.py", line 439, in __call__
    doc = proc(doc, **component_cfg.get(name, {}))
  File "/home/gleidson/.local/lib/python3.8/site-packages/spacy_wordnet/wordnet_annotator.py", line 17, in __call__
    wordnet = Wordnet(token=token, lang=self.__lang)
  File "/home/gleidson/.local/lib/python3.8/site-packages/spacy_wordnet/wordnet_domains.py", line 31, in __init__
    self.__lang = fetch_wordnet_lang(lang)
  File "/home/gleidson/.local/lib/python3.8/site-packages/spacy_wordnet/__utils__.py", line 35, in fetch_wordnet_lang
    raise Exception('Language {} not supported'.format(lang))
Exception: Language pt not supported

And for Spanish, the synonyms were in English.

Hi,
Portuguese support was added very recently to master and we have not yet tested it so it's not available when installing from pip.
We will test this and also the issue with Spanish that you mention.

Nothing yet for installing from pip? I changed by my self and works great. Please, test and update. I can't use this way I'm doing because I need to build container from pip.

Hi  @gleidsonh, we apologise for not taking care of this before.
We have been testing this in master and it works for Spanish and Portuguese.
Regarding the synonyms appearing in English (I imagine you've sorted this out already), there's certainly a confusion with the example in the README, for getting lemmas in other languages you should pass the language to the nltk wn synset method (e.g., s.lemma_names('por')), will add examples in other langs now:
economy_domains = ['finance', 'banking']
enriched_sentence = []
sentence = nlp(text)

# For each token in the sentence
for token in sentence:
    # We get those synsets within the desired domains
    synsets = token._.wordnet.wordnet_synsets_for_domain(economy_domains)
    if not synsets:
        enriched_sentence.append(token.text)
    else:
        lemmas_for_synset = [lemma for s in synsets for lemma in s.lemma_names('por')]
        # If we found a synset in the economy domains
        # we get the variants and add them to the enriched sentence
        enriched_sentence.append('({})'.format('|'.join(set(lemmas_for_synset))))

# Let's see our enriched sentence
print(' '.join(enriched_sentence))
# >> Eu (querer|desejar|esperar) retirar 5.000 euros

Could you please point us to the change you have done before installing on your Dockerfile?
We apologise for not catching up with the pip release, will do that before the end of next week. Meanwhile have you tried to pip install from master? Like:
pip install -U git+https://github.com/recognai/spacy-wordnet.git
Again sorry for the inconvenience, we've had no time to publish on pypi.

Hi  @gleidsonh, we apologise for not taking care of this before.
We have been testing this in master and it works for Spanish and Portuguese.
Regarding the synonyms appearing in English (I imagine you've sorted this out already), there's certainly a confusion with the example in the README, for getting lemmas in other languages you should pass the language to the nltk wn synset method (e.g., s.lemma_names('por')), will add examples in other langs now:
economy_domains = ['finance', 'banking']
enriched_sentence = []
sentence = nlp(text)

# For each token in the sentence
for token in sentence:
    # We get those synsets within the desired domains
    synsets = token._.wordnet.wordnet_synsets_for_domain(economy_domains)
    if not synsets:
        enriched_sentence.append(token.text)
    else:
        lemmas_for_synset = [lemma for s in synsets for lemma in s.lemma_names('por')]
        # If we found a synset in the economy domains
        # we get the variants and add them to the enriched sentence
        enriched_sentence.append('({})'.format('|'.join(set(lemmas_for_synset))))

# Let's see our enriched sentence
print(' '.join(enriched_sentence))
# >> Eu (querer|desejar|esperar) retirar 5.000 euros

Could you please point us to the change you have done before installing on your Dockerfile?
We apologise for not catching up with the pip release, will do that before the end of next week. Meanwhile have you tried to pip install from master? Like:
pip install -U git+https://github.com/recognai/spacy-wordnet.git
Again sorry for the inconvenience, we've had no time to publish on pypi.

I'm not so good on python, so I didn't know install this way you tell me. Anyway, the only change I did on Dockerfile was adding pt='por' to utils.py this way:
RUN sed -i "s/__WN_LANGUAGES_MAPPING = dict(es=__DEFAULT_LANG, en='eng')/__WN_LANGUAGES_MAPPING = dict(es=__DEFAULT_LANG, en='eng', pt='por')/" ${FUNCTION_DIR}/spacy_wordnet/utils.py
I don't know how install from master will works on built image, since all requirements is installed from requirements.txt.
RUN --mount=type=cache,target=/root/.cache/pip pip install -r ${FUNCTION_DIR}requirements.txt --target ${FUNCTION_DIR}
Anyway, if something wrong happens I'll tell you. Thanks for your help and you time. =]

I'm not so good on python, so I didn't know install this way you tell me. Anyway, the only change I did on Dockerfile was adding pt='por' to utils.py this way:
RUN sed -i "s/__WN_LANGUAGES_MAPPING = dict(es=__DEFAULT_LANG, en='eng')/__WN_LANGUAGES_MAPPING = dict(es=__DEFAULT_LANG, en='eng', pt='por')/" ${FUNCTION_DIR}/spacy_wordnet/utils.py
I don't know how install from master will works on built image, since all requirements is installed from requirements.txt.
RUN --mount=type=cache,target=/root/.cache/pip pip install -r ${FUNCTION_DIR}requirements.txt --target ${FUNCTION_DIR}
Anyway, if something wrong happens I'll tell you. Thanks for your help and you time. =]

Thanks for your understanding.
In principle you could include this in the requirements.txt
https://stackoverflow.com/questions/16584552/how-to-state-in-requirements-txt-a-direct-github-source
Let us know how it goes but in any case we'll try to publish the new
version on pypi as soon as possible.
El mié., 6 ene. 2021 18:20, Gleidson<EMAIL_ADDRESS>escribió:

I'm not so good on python, so I didn't know install this way you tell me.
Anyway, the only change I did on Dockerfile was adding pt='por' to
utils.py this way:
RUN sed -i "s/__WN_LANGUAGES_MAPPING = dict(es=__DEFAULT_LANG,
en='eng')/__WN_LANGUAGES_MAPPING = dict(es=__DEFAULT_LANG, en='eng',
pt='por')/" ${FUNCTION_DIR}/spacy_wordnet/utils.py
I don't know how install from master will works on built image, since all
requirements is installed from requirements.txt.
RUN --mount=type=cache,target=/root/.cache/pip pip install -r
${FUNCTION_DIR}requirements.txt --target ${FUNCTION_DIR}
Anyway, if something wrong happens I'll tell you. Thanks for your help and
you time. =]
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/recognai/spacy-wordnet/issues/4#issuecomment-755439079,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIOJJ5AJOTJ2EEUZ76Q7X3SYSLU7ANCNFSM4NDAE4JQ
.

Thanks for your understanding.
In principle you could include this in the requirements.txt
https://stackoverflow.com/questions/16584552/how-to-state-in-requirements-txt-a-direct-github-source
Let us know how it goes but in any case we'll try to publish the new
version on pypi as soon as possible.
El mié., 6 ene. 2021 18:20, Gleidson<EMAIL_ADDRESS>escribió:

I'm not so good on python, so I didn't know install this way you tell me.
Anyway, the only change I did on Dockerfile was adding pt='por' to
utils.py this way:
RUN sed -i "s/__WN_LANGUAGES_MAPPING = dict(es=__DEFAULT_LANG,
en='eng')/__WN_LANGUAGES_MAPPING = dict(es=__DEFAULT_LANG, en='eng',
pt='por')/" ${FUNCTION_DIR}/spacy_wordnet/utils.py
I don't know how install from master will works on built image, since all
requirements is installed from requirements.txt.
RUN --mount=type=cache,target=/root/.cache/pip pip install -r
${FUNCTION_DIR}requirements.txt --target ${FUNCTION_DIR}
Anyway, if something wrong happens I'll tell you. Thanks for your help and
you time. =]
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/recognai/spacy-wordnet/issues/4#issuecomment-755439079,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIOJJ5AJOTJ2EEUZ76Q7X3SYSLU7ANCNFSM4NDAE4JQ
.


Adding in support for Metagenomes

Other todo: Update https://github.com/kbaseapps/ProkkaAnnotation/blob/master/README.rst if you can
Other todo: Update ReleaseNotes


Fix replace in parse_first_call_result

Hi, I noticed when salt ends with 's=' (in my case it did), replace will remove it and that breaks the salt.
Fixed it to only replace first occurrence and just to be sure I added it to other 2 replace calls.

Hi Vojtěch,
Great catch!
I created a new branch with a slightly modified version of your commit.  This branch has a separate commit to apply isort and black formatting and passes all tests.
Please take a look at the branch and let me know if you see any issues:
https://github.com/rick-jennings/phable/tree/scram_first_call_fix
Do you think we should add any related tests for the scram module now?  (see link below)
https://github.com/rick-jennings/phable/blob/main/tests/test_scram.py
Note:  If you want we can hold off adding any new tests for now.  In the future I am thinking about using Haxall as a test server for Phable.
Thanks,
Rick

Looks good, It would be good to have some test of the scram auth, but this was pretty lucky that the password chosen ended like that and broke the replace. It was pretty well hidden bug and not really well testable I feel like.

Thanks.  I merged the branch.  Closing this PR.


Case: 100+ KafkaStreams threads on 3.5k+ topics/partitions with exactly_once_v2 guarantee

hi folks!
currently I'm working on KafkaStreams based app. the idea is to stream from one source topic to 3.5k+ topics using processing.guarantee: exactly_once_v2 mode.
source topic is an endpoint and a single source of truth for all incoming messages. messages are different with different content and the goal is to split those incoming messages by content and write to a specific topic. for instance, type1 messages to type1-topic, type2 to type2-topic and so forth.
                   / ----------- type1-topic
                  / ------------ type2-topic
source-topic ---- ...
                  \ ------------ typeN-topic

details

5 brokers;
source topic has 630 partitions;
at the moment there are 3,500 types of messages and the number will grow;
the total flow of messages is about 2.5-3 millions messages per second, average message size is 860b (max size is up to 250kb), which gives 2-2.4gb per second;
the frequency of messages is unevenly distributed: some types occur very frequently, some rarely;
destination topics are mostly single partition, but for high-flow messages topics have 10 partitions.

questions

is this even a good idea?
I mean, I like the idea because of its simplicity and elegance. but I also feel that the implementation cannot be reliable and stable.

how Kafka handles multiple ongoing transactions at time on one specific partition?
I found a lot of articles with explanation how Kafka transaction works, but all of them are about one-thread stream with one ongoing transaction at a time. but I've not idea how TransactionCoordinator works when a bunch of threads run transactions on same set of topics/partitions. as instance, thread-1 performs transaction on type1_topic-0, type2_topic-0, type3_topic-0 and at the same time there are a bunch of thread performing transactions on same topics type1_topic-0, type2_topic-0, type3_topic-0.
are the partitions blocked for writing until the transaction ends? are other transactions waiting in line?

is it even possible to make this solution solid and durable?

also, I will separately describe the current state.
configs
### KAFKA STREAMS SECTION ### ------------------------------------------------------------------------------------------
application.id: kafka-splitter
bootstrap.servers: kafka1.host:9092,kafka2.host:9092,kafka3.host:9092,kafka4.host:9092,kafka5.host:9092
# tried up to 16
num.stream.threads: 4

processing.guarantee: exactly_once_v2

num.standby.replicas: 1

topology.optimization: none
auto.offset.reset: latest

# 2gb
statestore.cache.max.bytes:<PHONE_NUMBER>
# 7sec, tried 100ms-60000ms
commit.interval.ms: 7000

### KAFKA CONSUMER SECTION ### -----------------------------------------------------------------------------------------
poll.ms: 60000
max.poll.interval.ms: 900000
max.poll.records: 50000000

# 2gb
fetch.max.bytes:<PHONE_NUMBER>
fetch.max.wait.ms: 10000
# 100mb
fetch.min.bytes: 104857600
# 5mb
max.partition.fetch.bytes: 5242880

### KAFKA PRODUCER SECTION ### -----------------------------------------------------------------------------------------
compression.type: zstd

# 5min, tried to reduce and increase
linger.ms: 300000
# 2mb, tried to reduce and increase
batch.size: 2097152

# 10min, tried to reduce and increase
max.block.ms: 1200000
# 2gb
buffer.memory:<PHONE_NUMBER>

# 2gb
max.request.size:<PHONE_NUMBER>

# 30min, tried to reduce and increase
delivery.timeout.ms: 1800000
# 15min, tried to reduce and increase
transaction.timeout.ms: 900000
# 15min, tried to reduce and increase
producer.transaction.timeout.ms: 900000

# 20min, tried to reduce and increase
task.timeout.ms: 1200000
# 20min, tried to reduce and increase
request.timeout.ms: 1200000

the logic that I mostly follow when selecting configs https://stackoverflow.com/a/74518032
errors handlers
public class KafkaSplitterProductionExceptionHandler implements ProductionExceptionHandler {
    @Override
    public ProductionExceptionHandlerResponse handle(ProducerRecord<byte[], byte[]> record, Exception exception) {
        ...
        return ProductionExceptionHandlerResponse.FAIL;
    }

    @Override
    public void configure(Map<String, ?> configs) {}
}

public class KafkaSplitterStreamsUncaughtExceptionHandler implements StreamsUncaughtExceptionHandler {
    @Override
    public StreamThreadExceptionResponse handle(Throwable exception) {
        ...
        return StreamThreadExceptionResponse.REPLACE_THREAD;
    }
}

errors
randomly happens and producer can not recover
[] ERROR 2023-09-18 20:48:14,680 [processor.internals.RecordCollectorImpl, kafka-producer-network-thread | kafka-splitter-b4222843-7a39-4a6a-83e4-e422217ac6cb-StreamThread-1-producer] : stream-thread [kafka-splitter-b4222843-7a39-4a6a-83e4-e422217ac6cb-StreamThread-1] stream-task [0_337] Error encountered sending record to topic *TOPIC* for task 0_337 due to:
org.apache.kafka.common.errors.InvalidPidMappingException: The producer attempted to use a producer id which is not currently assigned to its transactional id.

also sometimes partitions leaders change on brokers side
[] WARN  2023-09-18 20:48:12,756 [producer.internals.Sender, kafka-producer-network-thread | kafka-splitter-b4222843-7a39-4a6a-83e4-e422217ac6cb-StreamThread-2-producer] : [Producer clientId=kafka-splitter-b4222843-7a39-4a6a-83e4-e422217ac6cb-StreamThread-2-producer, transactionalId=kafka-splitter-b4222843-7a39-4a6a-83e4-e422217ac6cb-2] Got error produce response with correlation id 13414 on topic-partition *TOPIC-0*, retrying<PHONE_NUMBER> attempts left). Error: NOT_LEADER_OR_FOLLOWER
[] WARN  2023-09-18 20:48:12,756 [producer.internals.Sender, kafka-producer-network-thread | kafka-splitter-b4222843-7a39-4a6a-83e4-e422217ac6cb-StreamThread-2-producer] : [Producer clientId=kafka-splitter-b4222843-7a39-4a6a-83e4-e422217ac6cb-StreamThread-2-producer, transactionalId=kafka-splitter-b4222843-7a39-4a6a-83e4-e422217ac6cb-2] Received invalid metadata error in produce request on partition *TOPIC-0* due to org.apache.kafka.common.errors.NotLeaderOrFollowerException: For requests intended only for the leader, this error indicates that the broker is not the current leader. For requests intended for any replica, this error indicates that the broker is not a replica of the topic partition.. Going to request metadata update now

is this even a good idea?
I mean, I like the idea because of its simplicity and elegance. but I also feel that the implementation cannot be reliable and stable.

It does sound like a large scale deployment (and EOS will make it a little bit more tricky), however, given the simplicity of the application, I am quite confident that it's possible and would not call it a "bad idea".

how Kafka handles multiple ongoing transactions at time on one specific partition?
That's not an issue. Kafka TX are designed for this pattern.

are the partitions blocked for writing until the transaction ends? are other transactions waiting in line?
No, all TX will happen in parallel, and as a matter of fact, the write of different TX are still interleaved.

is it even possible to make this solution solid and durable?
I believe yes. (cf my first reply) -- Might require some fine tuning of course (but not sure what your requirement are, so hard to advice.)

About the "errors" -- for the first one, you exception handler should restart the StreamThread and thus you should get recovery?  Or is this overall behavior not good enough? -- Btw: what version are you using (both broker / KS): newer version got significant fixes to make EOS more robust.
For the warn logs: I am not a broker expert, so not sure why the leader moved, but in general it's a "normal" thing and it seem the client did handle it well, refreshing it's metadata. It's no error but a warn log, so wondering why it bothers you?

@mjsax thank you for your reply!

you exception handler should restart the StreamThread and thus you should get recovery?

I expect yes, because of return StreamThreadExceptionResponse.REPLACE_THREAD;. or should I do something else to recover failed thread? I also can see that consumer for failed thread is working (not sure if it was recovered one in new thread or it is just wasn't failed), but producer is not.

 Or is this overall behavior not good enough?

it performs well until an error occurs. and after error producer is not able to continue producing. and error The producer attempted to use a producer id which is not currently assigned to its transactional id sounds for me like TX is already done (doesn't matter was it committed or aborted), but producer is still trying to run TX with same ID.

Btw: what version are you using (both broker / KS): newer version got significant fixes to make EOS more robust.

we use 3.5 Kafka brokers and Kafka Streams

but in general it's a "normal" thing and it seem the client did handle it well, refreshing it's metadata

yeah, I also understand that it should be normal thing, but there were a lot errors and long retries. but I believe because of long delivery.timeout.ms: 1800000. there also was severe degradation on brokers side, unfortunately, I've already lost logs, but for bunch of topics leaders were skewed and data was under-replicated. maybe it happened because of long retries...

but not sure what your requirement are, so hard to advice

what specific information would you like to know to be able to advice something?

Thanks. -- When a thread is replace, we literally start a new one which creates a new producer and calls initTransaction() what should put everything into clean state. There is one known issue (https://issues.apache.org/jira/browse/KAFKA-14567) which results in fencing, but it seems to be different to your report.
Guess we would need detailed Kafka Streams, producer, and broker logs to figure out what is happening.
Not sure if the high TX-timeout you configures has anything to do with it 🤔. On the other hand, even with the large timeout, calling initTransaction on the new producer (if we re-use a TX-id as mentioned on the ticket above) should abort any pending TX for this TID and we should get a clean producer state. -- We might need to get some input from EOS experts. \cc @jolshan

hey @mjsax @jolshan.
sorry for the delayed response.
here are application logs from all instances and also some metrics.
app was running on 6 servers with 6 threads on each, so 36 threads in total.
after ~2 hours something went wrong and 4 producers (one on each of 1, 2, 5, 6 hosts) could no longer send messages.
app_logs_hosts1,2.zip
app_logs_hosts5,6.zip
app-logs_hosts3,4.zip

Hey sorry for the delay. Catching up on the situation.
I will try to answer the questions posed to me, but let me know if I missed something.

(is this even a good idea?)
In theory I think it is doable, but it could be tricky depending on the load for specific partitions and configurations.

(how Kafka handles multiple ongoing transactions at time on one specific partition?)
So a single producer can only work on a single transaction at a time. This transaction can contain multiple partitions. Other producers can also concurrently write to the same partitions as part of separate transactions. So I'm not exactly sure how your Thread maps to producer instances, but each transaction needs its own producer.

As for writing, there is no blocking writes on the same partition. We do block read_committed reads. Each partition has something called the LSO. This is the first offset in the log that contains an uncommitted transaction. Read-committed consumers can not read past the LSO, so if you have transaction A and transaction B in the log like this:
(A message 1) (B message 1) (B message 2) (B message 3) (B commit)
The LSO would be at A message 1 and even though B is committed, you would not be able to read it until A is also committed.
(A message 1) (B message 1) (B message 2) (B message 3) (B commit) (C message 1) (A commit)
At this point LSO is at C message 1 and A and B transactions are readable.

See 1. :)

As for some of the followups I saw:
The leadership errors should be retriable on metadata refresh and you shouldn't have to worry about that.
InvalidPidMapping happens when the transactional id expires. This happens when a transactional producer is left idle for the expiration period (transactional.id.expiration.ms) and the default is 7 days. (Note: the time starts when the transaction is idle, and we will never expire when the transaction is ongoing.)
As for the timeouts, I don't think it is good for your transactional timeout to be less than your delivery timeout.

Thanks @jolshan

So I'm not exactly sure how your Thread maps to producer instances, but each transaction needs its own producer.

With EOSv1 (deprecated) there would be a producer per task, and a StreamThread might have multiple assigned tasks. For EOSv2, there is one producer per StreamThread.

thank you for your replies @jolshan @mjsax!
@jolshan as for transactional.id.expiration.ms, we have default value for it.
also, regarding transactional timeout, it was more than delivery timeout for my last run (details are here).
and still there were a lot of InvalidPidMappingException's (for instance, on host2, logs are provided above), as well as  ProducerFencedException's (for instance, on host1). for some reasons producers were not able to recover.
as far as I understand, ProducerFencedException is something that can happen time to time, but  InvalidPidMappingException doesn't seem so.  and InvalidPidMappingException might be the root of problem, but it's only a suggestion.


Orientation of simplicial complexes

The Problem
Simplicial complexes are often used with an arbitrary reference orientation in mind, e.g., when considering edge flows. Consider this simple example:
from toponetx.classes import SimplicialComplex

SC = SimplicialComplex()
SC.add_simplex((2, 1), flow=10)

The user should expect that the edge (2, 1) is added with exactly this orientation, i.e., with an edge flow of 10 from node 2 to node 1. However, TopoNetX does not handle orientation, it transforms the edge into canonical form (1, 2) without any thought about associated data that might be orientation-aware.
Possible Actions

Full-fledged orientation support. This is a big undertaking, especially for when already existing simplices are re-added with a different orientation. A priori it is not clear how to deal with already existing data, as we cannot infer whether arbitrary user-data is relative to the orientation or not. For data that is relative to orientation, we might have to change the sign, for other data (with may also be numeric), we must not alter them.
Offload the cannocalization and appropriate sign-changes of data to the user. SimplicialComplex.add_simplex calls are only allowed for pre-sorted tuples.

A priori it is not clear how to deal with already existing data, as we cannot infer whether arbitrary user-data is relative to the orientation or not. For data that is relative to orientation, we might have to change the sign, for other data (with may also be numeric), we must not alter them.

We can work around this issue by replacing the attributes of existing simplices instead of updating/extending them. If we go that round, we should make this change consistently across all complexes though.

@ffl096 what do you mean across all complexes ? how do we make sense of orientation of combinatorial complexes? I think the difference is not trivial. Even for simplicial complex, having orientation per simplex is an assumption and abstract simplicial complexes do not come with orientation on each simplex by default. Orientation is only defined when one needs to define a matrix rep for the boundary operator.
I suggest the following : create a class called OrientedSimplex, and OrientedSimplicialComplex, what do you think?

what do you mean across all complexes ? how do we make sense of orientation of combinatorial complexes?

I didn't say that combinatorial complexes have an orientation. However, if we go the route of replacing vs. updating attributes, this change should be made across all complexes, even though the need only arises for (oriented) simplicial complexes.

I suggest the following : create a class called OrientedSimplex, and OrientedSimplicialComplex, what do you think?

No. There is no harm in having an orientation-aware simplicial complex even though you don't make use of orientation as an user. Maintaining both would be a nightmare.


Add Zulu

Adding a language
Add Zulu

[x] The code displays "Hello World"
[x] I have updated the readme to include the new language
[x] I have incremented the language count in the readme

Dang it need a newer fork


Make UART test usable without EDU

Description
This means two threads, one for EDU one for UCI and it should use suspendUntilDataReady() and maybe a timeout, etc.
File
Tests/HardwareTests/Uart.test.cpp

I don't really know/remember/understand what this issue is for.


Remove duplicate error code table of meshery-server in Error Code Ref…

Title:
[UI] [Bug] Remove duplicate error code table of meshery-server in Error Code Reference #11942
Description:
This PR addresses the issue #11942 where the error code table for meshery-server was duplicated in the Error Code Reference page. The duplicate table has been removed, and the page now correctly displays a single table for meshery-server error codes.
Notes for Reviewers:
Please review the changes to ensure that the duplicate error code table has been removed and that the remaining content is accurate and correctly displayed.
Signed commits

[x] Yes, I signed my commits.

🚀 Preview for commit 95345efd4e0c84c4af1cb458015ee44e9a36f2a1 at: https://66e04b9eb04f413599ed743e--meshery-docs-preview.netlify.app

Thank you @102vansh
Let's discuss this PR on Meshery development call today. Adding it as an agenda item to the meeting minutes.
Timing: 9:00 AM CT
Meeting minutes: Google Docs
Meeting link: meet.layer5.io/meshery

@102vansh build is failing. Have you fix the endif syntax which is coming in build error and also mentioned by @leecalcote


units naming inconsistent for miles on rings tab

When using DD on the rings tab.  The name for the distance units will vary depending on how the rings were created.  In interactive mode the name for miles is Mile_USs  vs entering input values the name for miles is Miles.  See screen grab below.
Interactive mode:

Input mode:

@pHill5136 unable to verify this on build 1622

Slightly better but still a typo on build 1622.  See graphic.  @nfeuerstein I dont think this is a show stopper can this be moved to version after next?

fixed typo pleas verify

@pHill5136 as of build 1624 (the 1pm build) this is still an issue.  See the screen grab below.

@pHill5136 this has been fixed in build 1625.


simple-socks-chromeapp stops working after resuming from suspend on OS X

Running recent commit from this morning (f5cd630 Merge pull request #192 from uProxy/trevj-tcp-integration), on Chrome 41.
To reproduce:

Start Simple SOCKS app.
Run curl command: curl -x socks5h://<IP_ADDRESS>:9999 www.example.com
Suspend OS: top-left Apple icon -> Sleep
Resume.
Re-run curl command. Gives error.

Log messages from steps 1-2:
I [1/12 14:12:36.667] Reused port chrome-extension://mahepceckogcnnfjahfdkjopempkheig/lib/loggingprovider/loggingprovider.json0.19507943373173475
freedom-for-chrome.js:1111  simple-socks I [1/12 14:12:39.196] SocksToRtc listening on: {"address":"<IP_ADDRESS>","port":9999}
freedom-for-chrome.js:1111  simple-socks I [1/12 14:12:39.196] curl -x socks5h://<IP_ADDRESS>:9999 www.example.com
freedom-for-chrome.js:1111  simple-socks I [1/12 14:12:39.212] RtcToNet ready
freedom-for-chrome.js:1111  SocksToRtc I [1/12 14:12:42.473] created new session c0
freedom-for-chrome.js:1111  SocksToRtc I [1/12 14:12:42.608] discarded session c0 (0 remaining)
Log messages from steps 3-4:
PeerConnection I [1/12 14:12:47.572] unnamed-1: close freedom-for-chrome.js:1111
PeerConnection I [1/12 14:12:47.573] unnamed-1: close freedom-for-chrome.js:1111
(2) PeerConnection I [1/12 14:12:47.574] unnamed-2: close freedom-for-chrome.js:1111
PeerConnection I [1/12 14:12:47.575] unnamed-1: close freedom-for-chrome.js:1111
PeerConnection I [1/12 14:12:47.576] unnamed-2: close freedom-for-chrome.js:1111
No log messages from step 5. The curl output:
$ curl -x socks5h://<IP_ADDRESS>:9999 www.example.com
curl: (7) Failed connect to www.example.com:9999; Connection refused

Thanks for the report. I think this is a nice-to-have for Simple SOCKS, which was never intended to be a tool you can run all day.
For uProxy, handling suspend is obviously very important but I think the "ping protection" that @dborkan recently added will at least trap this error (along with other sub-systems that don't handle suspend very well, e.g. XMPP).

I do wonder how system suspend is exposed (if at all) to Chrome and Firefox extensions. This issue certainly seems related:
https://github.com/uProxy/uproxy/issues/821

There is no way to detect an impending suspend in Chrome.  There have been
proposals for an "onWake" event, but it hasn't been implemented yet.
However, RTCPeerConnections in Chrome do close, and fire a corresponding
event, before impending suspend.  This uniquely indicates suspend (nothing
else will cause this), and there is usually enough time to send some data
out over HTTP.
Firefox's behavior is of course entirely different, and I'm not familiar
with it in detail.
On Tue, Feb 17, 2015 at 10:47 AM, trevj<EMAIL_ADDRESS>wrote:

I do wonder how system suspend is exposed (if at all) to Chrome and
Firefox extensions. This issue certainly seems related:
#821 https://github.com/uProxy/uproxy/issues/821
—
Reply to this email directly or view it on GitHub
https://github.com/uProxy/uproxy/issues/903#issuecomment-74689189.

Just a note that I personally would find this useful so I can browse all the time on my laptop - like I do on my desktop - with Simple SOCKS.


CC0 1.1 w/o gendered pronouns

Fixes
Partial fix for #1143 - no updates to non-English versions.
Description
Changes all "he or she" and "his or her" references to use singular they.
Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the default branch of the repository (main or master).
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[n/a] I added tests for the changes I made (if applicable).
[n/a] I added or updated documentation (if applicable).
[n/a] I tried running the project locally and verified that there are no
visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

As the OP on the underlying issue, I took a broader look and only see this happening elsewhere in CC-PDDC ("A certifier, moreover, dedicates any copyright interest he may have in the associated work..."), though I was literally searching for " he " and not doing a deep dive on all the license texts.

You can use grep -P '\b(he|she|his|her)\b' to look a bit more thoroughly - the \b looks for a word/non-word boundary and so will find these words at the start or end of a line as well as the middle.

You can use grep -P '\b(he|she|his|her)\b' to look a bit more thoroughly - the \b looks for a word/non-word boundary and so will find these words at the start or end of a line as well as the middle.

Google has a little CI script based on the AOSP Coding with Respect guidelines to check for this stuff - see https://github.com/google/amber/pull/897 . We are planning to integrate it into our CI soon and hopefully others will, or similar checks, as well. Above I was just searching on the website. Fortunately lawyers do not tend to use contractions :-)


Coolest WD Feature :)

🛠 Fixes Issue (Number)

👨💻 Changes proposed and Brief Description

✅ Check List (Check all the applicable boxes)

[ ] My code doesn't break any part of the project
[ ] This PR does not contain plagiarized content.
[ ] My Addition/Changes works properly and matches the overall repo pattern.
[ ] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers

📷 Screenshots

File:01 - Drum Kit/main.js
File:10 - Emoji Switcher like Discord/script.js
File:100 - Coin Game/script.js
File:109 - Number Facts/index.html
File:112 - Maze Game/script.js
File:999 - Hackathon Scripts/CodeBERT_CodeReviewer_v1.0.py
File:999 - Hackathon Scripts/test.js
code looks good


Show all vector drawable thumbnails in your project, new plugin for Android Studio

https://plugins.jetbrains.com/plugin/10741-vector-drawable-thumbnails

I have added this plugin but i'm getting compatibility problem with newer android studio or gradle. Please check for any such issues

Will check AS 3.0, thanks for the details

Hello Ignacio,
your plugin is working great. If you could add the ability to preview vector drawables with referenced color values it would be awesome. Thanks!


[Docs] Update Developer Guide

For now, work on Implementation (proposed features) and Appendix (product scope & user stories) sections for now.

Add some use cases


v1.11 Backports 2023-06-08

[ ] #25907 (@jrajahalme)
[ ] #25893 (@pchaigno)
[ ] #25936 (@joamaki)

Once this PR is merged, you can update the PR labels via:
for pr in 25907 25893 25936; do contrib/backporting/set-labels.py $pr done 1.11; done

or with
make add-labels BRANCH=v1.11 ISSUES=25907,25893,25936

This is blocked by v1.11 complexity issue.

/test-backport-1.11

The same bad news: ci-multicluster-1.11 fails due to complexity

/test-1.19-4.9

/test-1.23-4.9

/test-1.21-5.4

/test-upstream-k8s

The same bad news: ci-multicluster-1.11 fails due to complexity

However, can be ignored for now as it should be fixed by https://github.com/cilium/cilium/pull/25993 and is not marked as Required

Fixed the backport error in https://github.com/cilium/cilium/pull/26007/commits/0fdb27d6103cff4e4a2a929d0784c4ac0a59a467. TL;DR: kubeProxyReplacement=probe is still valid in this branch.

/test-backport-1.11

k8s-1.21-kernel-4.9: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.21-kernel-4.9/45/console

Timeout while waiting for VM provisioning. Let me retry.

k8s-1.21-kernel-5.4: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.21-kernel-5.4/28/testReport/junit/Suite-k8s-1/21/K8sDatapathConfig_Transparent_encryption_DirectRouting_Check_connectivity_with_transparent_encryption_and_direct_routing/

Concerning error observed. I'll retry to see it is flake or not and check sysdumps as well in parallel.

/test-1.21-4.9

/test-1.21-5.4

For k8s-1.21-kernel-5.4, the same error with exactly the same test case was reported by Tobias last December (https://github.com/cilium/cilium/issues/17010#issuecomment-992348526). Looks like the issue was closed as it did not happen for a while. I'll reopen the issue.

all the required tests passed. merging ✅


Q1 & Q2 Reports

Draft quarterly reports to be sent out with the July monthly report:

[ ] Q1
[ ] Q2

Text from the contract: The Contractor shall provide a Quarterly Progress Report, which is a rollup of the Monthly
Progress Reports. These reports shall include the key statistics on the implementation of the
product as mentioned below in and include extended comments on the projects, highlight the
upcoming key events and recommend any changes to the Product Management Plan.

Quarterly Reports are drafted and can be found here:
https://gwu0.sharepoint.com/sites/PredictMod-GRP/Shared Documents/Forms/AllItems.aspx?id=%2Fsites%2FPredictMod-GRP%2FShared Documents%2F04_Regular Reports%2FQuarterly Reports&viewid=9bd8e9cf-ba0f-413e-b13a-a5b506639bfc


Release vscode-quarkus 1.13.0

This involves (eclipse/lsp4mp, vscode-microprofile, redhat-developer/quarkus-ls) as well.

Closed in #600


Create News Reported.md

📝 Description
Add a brief description.
💣 Is this a breaking change (Yes/No):

[ ] Yes
[x] No

🚧 How to migrate?
Don't need.
📝 Additional Information
lol

Dear @aniketmdinde ,
Thank you very much for your contribution. Maybe you want to create an AI Agent like the screenshot shows. Please check it.

If there are any other questions, please feel free to comment on this PR or contact us via Discord. And we will introduce the creation method and common questions of AI Agent live on 2023.10.18. Welcome to ask questions and interact in the live . You can follow our Discord notification or Youtube channel for live broadcast information.


Revert "Lite obfuscation"

Reverts Samsung/CredData#54

https://github.com/Samsung/CredSweeper/pull/465 let remove the workflow enterelly to avoid a data leakage.

The PR is not necessary. Moreover, it fails benchmark workflow. Just remove --lite_obfuscation

I agree with this. Let just remove --lite_obfuscation option. Not to remove the workflow of CredSweeper.
It's too much..

I created the PR #57 for remove --lite_obfuscation option only.
Please check.


vmap(fori_loop(...)) should not batch the loop counter

This led to a significant performance problem in the threefry2x32 implementation when it was changed to use a dynamic_slice as part of its implementation and when batched as part of the gamma implementation. If we cannot prove that i is equal across batch elements, x[i] turns into a relatively expensive gather of scalars, but if we know x and i are unbatched, it remains a dynamic slice.

Is this a duplicate of #1188 ?
By the way, we have a much improved vmap of while_loop/fori_loop waiting in the no-more-tuples branch. That branch needs at least another couple days of work though...

I don't know. We should try it once that branch lands; maybe we can close both issues at the same time.

We fixed this in #1224 (or soon thereafter):
In [10]: make_jaxpr(vmap(lambda x: lax.fori_loop(0, 4, lambda _, x: x + 1, x)))(np.arange(3))
Out[10]:
{ lambda  ;  ; a.
  let b c d = while[ cond_nconsts=0
                     cond_jaxpr={ lambda  ;  ; a b c.
                                  let d = lt a b
                                  in [d] }
                     body_nconsts=0
                     body_jaxpr={ lambda  ;  ; a b c.
                                  let d = add a 1
                                      e = add c 1
                                  in [d, b, e] } ] 0 4 a
  in [d] }

Notice that the cond_jaxpr just operates on a scalar (you have to do some mental shape inference) and doesn't have a reduce_or in it.


A CC like the command se but it can add fields

Nit: File name should be camelCased to follow the other files in this repo (improvedEmbedCC vs ImprovedEmbedCC).

Done :)


Add Hakuneko-Nightly

Hakuneko is a open source comic reader
They have a deb available from their website.
https://github.com/manga-download/hakuneko/releases/download/nightly-20200705.1/hakuneko-desktop_8.3.4_linux_amd64.deb

Sorry, we won't be accepting any daily/nightly, beta or pre-release software. Please see:

Add guidelines for what packages are acceptable for inclusion