CRAM support

I sent a note to the mailing list but thought I would post here too:
Is there going to be any possibility of running multiple CRAM files at once directly with FreeBayes? Thanks.
Tychele

Never mind. I updated FreeBayes and it did the trick. Thank you!


Must select at least one claim type from the checkboxes

https://www.pivotaltracker.com/story/show/84934174

Currently users can progress without selecting. It should validate and force users to select at least one.

Hold your horses on this one @dan-palmer im still waiting on confirmation form Dan T

ok @dan-palmer this has been a false start. From a legal point of view a claim will be accepted if nothing is ticked on this page as long as claim details have been filled in. So, given that we have validation on the claim details section, we don't need validation on the claim type page.  @michaelelwin the copy can remain as is, because encouraging then to tick one is fine.


Add container environment variables table

ref : https://github.com/ManageIQ/manageiq/pull/3327

@simon3z Added a table with the env variables and an expanding functionality. (can be used application wise by using the same table partial)

@DNNX Thanks for the comments, still need to get used to haml :+1:

@alongoldboim, couple of comments on look and feel of the table based on the screenshot:

Type column at the moment seems redundant. All env variables have "value" in the type column.
The expand/collapse done with +/- is misleading. Typically +/- are used for add/remove.
If the Type column is here to stay, it is too wide. I suggest making it narrower, making more room for the value column.
The value column name needs to be capitalized like other column names.
Table title seems partial  - "Environment variables" will be more clear than just "Environment".

@abonas regarding you comments:

Its redudant only in this exmaple.
I can change to fa-angle-right and fa-angle-down, do you find it better?
Fixed, would actually like to replace text with icons but didn't find appropriate ones.
Fixed.
Fixed.
The table will increase its height.

@abonas Thanks for the comments:

Please use 'reply to' otherwise there's a lot of scrolling up/down to understand which comment/item you are referring to.

Its redudant only in this exmaple.

can you elaborate more what do you mean?

I can change to fa-angle-right and fa-angle-down, do you find it better?

yes

Fixed, would actually like to replace text with icons but didn't find appropriate ones.\

it's currently not the standard in miq summary pages, but I agree that it could be nice.

Fixed.
Fixed.
The table will increase its height.

which means the entire page will be scrollable, is that correct?

@alongoldboim please attach an image with (expanded) long environment variables.
If you are using molecule take a look at a container named 'registry'.

please also note, we are supposed to work with Patternfly look and feel / components.
So for example, the relevant icons should be from here: https://www.patternfly.org/styles/icons/

@miq-bot add_label ui, providers/containers, enhancement

Regarding your comments:

In the example i have taken there were no environment variables with type = REFERENCE, in general there could be.
Fixed.
The entire page will be scrollable.
Screenshot was update.

@alongoldboim note this currently does not fix #5617. Css selectors in this patch are applied only to the table created for environment using 'table-fixed' class so the other examples from #5617 using textual multilabel are not fixed.
I think one way to change this is: in case the text is not expandable (items[:expandable] => :false) add the text in a class that will enable these changes ( including div.expanded to have the text always expanded).
Other then that this issue pr looks good to me now. Adding @epwinchell that addressed similar issues before.

@moolitayer didn't mean to fix #5617(refed it by mistake, meant to ref this https://github.com/ManageIQ/manageiq/pull/3327).
if we do want to fix #5617 i advise doing it in a separate pr dedicated to that problem.

@moolitayer didn't mean to fix #5617(refed it by mistake, meant to ref this #3327).
If we do want to fix #5617 i advise doing it in a separate pr dedicated to that problem.

In that case a separate pr is probably a good idea.

@simon3z

Removed hard coded values.
Added a js function to evaluate the needed table cells.

@simon3z
Removed hard coded values.
Added a js function to evaluate the needed table cells.

Thanks! LGTM :+1:
@alongoldboim do you need to update the screenshot? Make it easy to understand what's the final look (arrows or +/- signs, etc.) and then get @serenamarie125 approval.
@zeari @abonas please review.

@simon3z screenshot was updated.

@simon3z screenshot was updated.

@alongoldboim please contact @serenamarie125 to get her review.

LGTM

@alongoldboim please rebase, cc @chessbyte ready for merge

Ping @chessbyte LGTM :+1: ready for merge

@dclarizio @martinpovolny @h-kataria Would you please review as this PR is mostly in the UI code.

@dclarizio after this will be merged, i can make this an application wide change for all tables, is that something we would be interested in?

@alongoldboim please rebase, I think this is good to go.

@dclarizio done.


Refactor optimism_payload into smaller, reusable functions

Reopening this PR for further feedback/revisions.
This PR aims to increase the the re-usability of the default OptimismPayloadBuilder logic, which is useful when implementing a custom OP Stack Payload builder.
ref #11040

sorry for the delay.
took some ideas but approached this differently in https://github.com/paradigmxyz/reth/pull/12229

No problem, thanks for the update and I am looking forward to changes in the new PR.
Ill keep my eye out on the open issues for PRs to pick up in the future!


All kotlinx synthetic view accessors should be referenced in the inflated layout

It's a common mistake to load a different view from a different layout with the same id and spend a lot of time trying to figure out what the error is.
There shouldn't be any reference to any view out of the activity/fragment layout.

Thank you @Tylos for such a great rule idea 💃


isso comments visible to bots, SEO

hi,
this is a question, not an issue
are isso comments visible to bots?
the question relates to SEO obviously, I need the comments to be indexed by search engine bots,
in the isso main page demo (https://posativ.org/isso/) they are not in the source code
thanks in advance

That depends on the bot and whether it evaluates JavaScript. There's nothing in isso that intentionally tries to hide comments from bots.

bots don't index javascript really - it's a myth
I still curse myself for doing my site with a js framework several years ago. had to to a 'bot version' especially, ending up with maintaining 2 versions for 1 thing
but could I just fetch the comments content from the sqllite db and show them to bots?


Build fails with "too many open files" error when using theme dependencies.

Bug Report or Feature Request (mark with an x)

[x] bug report -> Did, could not find a suiting solution/answer.
[ ] feature request

Versions.
@angular/cli: 1.0.0-rc.2
node: 6.10.0
os: linux x64
@angular/common: 2.4.9
@angular/compiler: 2.4.9
@angular/core: 2.4.9
@angular/forms: 2.4.9
@angular/http: 2.4.9
@angular/platform-browser: 2.4.9
@angular/platform-browser-dynamic: 2.4.9
@angular/router: 3.4.9
@angular/cli: 1.0.0-rc.2
@angular/compiler-cli: 2.4.9

System:
$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 14.04.4 LTS
Release:        14.04
Codename:       trusty

Repro steps.

Create angular-cli project,
Add a purchased theme, for example Metronic <- make sure it contains a lot of assets dependencies.
Check what your system's open file limit is (mine is 1024 by default) ulimit -a | grep 'open -> open files (-n) 1024
Run build command, mine is ng build --target=development --environment=staging

The log given by the failure.
$ ng build --target=development --environment=staging
 95% emittingfs.js:640
  return binding.open(pathModule._makeLong(path), stringToFlags(flags), mode);
                 ^

Error: EMFILE: too many open files, open '/home/forge/accp-products.caroga.nl/src/assets/metronic-bootstrap/assets/global/plugins/jquery.min.js'
    at Error (native)
    at Object.fs.openSync (fs.js:640:18)
    at Object.fs.readFileSync (fs.js:508:33)
    at Object.source (/home/forge/accp-products.caroga.nl/node_modules/@angular/cli/plugins/glob-copy-webpack-plugin.js:31:26)
    at Compiler.writeOut (/home/forge/accp-products.caroga.nl/node_modules/webpack/lib/Compiler.js:322:26)
    at /home/forge/accp-products.caroga.nl/node_modules/mkdirp/index.js:48:26
    at FSReqWrap.oncomplete (fs.js:123:15)

Desired functionality.

Successful build, without errors.

Mention any other details that might be useful.

ng serve does compile and serves successfully.

ng serve
** NG Live Development Server is running on http://localhost:4200 **
Hash: fc298eaefcd765c7d4fd
Time: 27248ms
chunk    {0} polyfills.bundle.js, polyfills.bundle.js.map (polyfills) 156 kB {4} [initial] [rendered]
chunk    {1} styles.bundle.js, styles.bundle.js.map (styles) 1.08 MB {4} [initial] [rendered]
chunk    {2} main.bundle.js, main.bundle.js.map (main) 60.9 kB {3} [initial] [rendered]
chunk    {3} vendor.bundle.js, vendor.bundle.js.map (vendor) 3.72 MB [initial] [rendered]
chunk    {4} inline.bundle.js, inline.bundle.js.map (inline) 0 bytes [entry] [rendered]
webpack: Compiled successfully.

Altering my system's open file limit does not work, I've quadrupled the size and still the error occurs. Make me think there might be something else at play.

$ ulimit -a | grep open
open files                      (-n) 4096

The system's diskspace and available inodes are sufficient. No problem there:

$ df -h
Filesystem      Size  Used Avail Use% Mounted on
udev            996M   12K  996M   1% /dev
tmpfs           201M  428K  200M   1% /run
/dev/xvda1       20G  6.9G   12G  37% /
none            4.0K     0  4.0K   0% /sys/fs/cgroup
none            5.0M     0  5.0M   0% /run/lock
none           1001M  4.0K 1001M   1% /run/shm
none            100M     0  100M   0% /run/user

$ df -ih
Filesystem     Inodes IUsed IFree IUse% Mounted on
udev             249K   388  249K    1% /dev
tmpfs            251K   335  250K    1% /run
/dev/xvda1       1.3M  720K  561K   57% /
none             251K     2  251K    1% /sys/fs/cgroup
none             251K     1  251K    1% /run/lock
none             251K     2  251K    1% /run/shm
none             251K     2  251K    1% /run/user

Both project and global Angular-cli versions match each other.
A list of the plugins:

Maybe even the most important one: I have NOT included all of these plugins in my config. They are just sitting there. I've only included the following inside my styles.scss:

/* BEGIN GLOBAL MANDATORY STYLES */
@import "assets/metronic-bootstrap/assets/global/plugins/font-awesome/css/font-awesome.min.css";
@import "assets/metronic-bootstrap/assets/global/plugins/simple-line-icons/simple-line-icons.min.css";
@import "assets/metronic-bootstrap/assets/global/plugins/bootstrap/css/bootstrap.min.css";
@import "assets/metronic-bootstrap/assets/global/plugins/bootstrap-switch/css/bootstrap-switch.min.css";

/* BEGIN THEME GLOBAL STYLES */
@import "assets/metronic-bootstrap/assets/global/css/components.min.css";
@import "assets/metronic-bootstrap/assets/global/css/plugins.min.css";

/* BEGIN THEME LAYOUT STYLES */
@import "assets/metronic-bootstrap/assets/layouts/layout2/css/layout.min.css";
@import "assets/metronic-bootstrap/assets/layouts/layout2/css/themes/blue.min.css";
@import "assets/metronic-bootstrap/assets/layouts/layout2/css/custom.min.css";

This is weird as it fails on assets/metronic-bootstrap/assets/global/plugins/jquery.min.js while I've not included this yet. I also don't see anything inside my .angular-cli.json that might suggest such inclusion:
{
  "$schema"<EMAIL_ADDRESS>  "project": {
    "version": "1.0.0-beta.32.3",
    "name": "product-builder"
  },
  "apps": [
    {
      "root": "src",
      "outDir": "dist",
      "assets": [
        "assets",
        "favicon.ico"
      ],
      "index": "index.html",
      "main": "main.ts",
      "polyfills": "polyfills.ts",
      "test": "test.ts",
      "tsconfig": "tsconfig.json",
      "prefix": "app",
      "styles": [
        "styles.scss"
      ],
      "scripts": [],
      "environmentSource": "environments/environment.ts",
      "environments": {
        "dev": "environments/environment.ts",
        "prod": "environments/environment.prod.ts",
        "staging": "environments/environment.staging.ts"
      }
    }
  ],
  "e2e": {
    "protractor": {
      "config": "./protractor.conf.js"
    }
  },
  "lint": [
    {
      "files": "src/**/*.ts",
      "project": "src/tsconfig.json"
    },
    {
      "files": "e2e/**/*.ts",
      "project": "e2e/tsconfig.json"
    }
  ],
  "test": {
    "karma": {
      "config": "./karma.conf.js"
    }
  },
  "defaults": {
    "styleExt": "scss",
    "component": {}
  }
}

Excluding the folder inside tsconfig.json proves no success either:

{
  "compilerOptions": {
    "baseUrl": "",
    "declaration": false,
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    "lib": [
      "es2016",
      "dom"
    ],
    "mapRoot": "./",
    "module": "es2015",
    "moduleResolution": "node",
    "outDir": "../dist/out-tsc",
    "sourceMap": true,
    "target": "es5",
    "typeRoots": [
      "../node_modules/@types"
    ],
    "exclude": [
      "./assets/metronic-bootstrap"
    ]
  }
}

Your config is setup to copy everything within the assets directory to the build output.

@clydin Understood, but not really workable? Would the underlying copy mechanism not use some sort of graceful fs move method?
As I would be needing these dependencies in time and don't see another way of copying in this myself (cause, yeah: pipelines are for that).
Can you advice on this?

We mostly just add these files to the Webpack watched assets. Then webpack takes care of reading and watching it<EMAIL_ADDRESS>There might be a hard limit somewhere that's not only the system. This needs some investigation.
How many files do you have total in assets/ right now?
But you are copying an awful lot of files... not to say you shouldn't, nor that we shouldn't support it. Just saying that it's not optimal.
A better way of doing it is to actually import the styles and scripts you need specifically into the scripts and styles array instead of adding everything there to be copied wholesale. Cause yeah, pipelines are also for that.

I have this issue as well. For my application I'm depending on the cldr-data npm package. From an API, I'm receiving the configuration for grid columns. In the tool it's possible to specify any locale for a column, so I need all the locale information in the package.
In my .angular-cli.json file I have added the package to the assets configuration so that I can load the needed files dynamically:
"assets": [         "assets",         "favicon.ico",         "../node_modules/cldr-data/main"       ]
This package contains so many locales that I'm getting the Error: EMFILE: too many open files error as well when running ng build. When I'm running ng serve everything works as expected.
My setup:
@angular/cli: 1.0.0
node: 7.7.4
os: win32 x64
@angular/common: 4.0.1
@angular/compiler: 4.0.1
@angular/core: 4.0.1
@angular/forms: 4.0.1
@angular/http: 4.0.1
@angular/platform-browser: 4.0.1
@angular/platform-browser-dynamic: 4.0.1
@angular/router: 4.0.1
@angular/cli: 1.0.0
@angular/compiler-cli: 4.0.1

@Caroga Hello I fix it by change config in .angular-cli.json at
"assets": [         "assets",         "favicon.ico"       ],
to
"assets": [         "favicon.ico"       ],
after build completed
I make a junction link to dist

ln -s /project/src/assets /project/dist/assets

(or you can copy folder to dist path)

Hi, I tried to replicate this with the latest version of the CLI (7.1.1). I added 4,500 files and was unable to replicate this.
If the problem persists, please open a new issue following our submission guidelines.
A good way to make a minimal repro is to create a new app via ng new repro-app and adding the minimum possible code to show the problem. Then you can push this repository to github and link it here.


fix(endpoints): update practices from deprecated ioutil to os in main.go

Description
Fixes Internal b/345845601
Also fixes ST1005: error strings should not be capitalized required by go staticcheck.
Checklist

[x] I have followed Contributing Guidelines from CONTRIBUTING.MD
[ ] Tests pass:   go test -v ./.. (see Testing)
[x] Code formatted:   gofmt (see Formatting)
[x] Vetting pass:   go vet (see Formatting)
[ ] These samples need a new API enabled in testing projects to pass (let us know which ones)
[ ] These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
[ ] This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
[ ] This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
[x] Please merge this PR for me once it is approved

@OremGLG Kokoro CI is failing due to
2024/11/29 15:31:01 Temporary error: datastore: could not find a free project

@OremGLG Kokoro CI is failing due to
2024/11/29 15:31:01 Temporary error: datastore: could not find a free project


Page should update after connecting to Amazon S3 account

Reported on the 0.43 trello board by @jinluyuan
Link: https://trello.com/c/paXFY0Qz/104-page-should-update-after-connecting-to-amazon-s3-account
Steps

Go to osf.io
Go to your user settings
Click the "Connect Account" link next to Amazon S3
Go through the account connection process

Expected behavior
I expected that after I successfully connected to my account, the page would refresh & update, and I would see "Amazon S3 authorized by Jinlu Yuan" with a green success message below and a red "Disconnect Account" link.
Actual behavior
The only change is a green "Settings Updated" text appears. If I refresh the page, I can see the expected format.

I believe this was expected functionality for this refactor (?) given the different approach to connection for S3. But considering how to make it function more consistently with others is worthwhile.

Will be considered when we refactor S3 addon.


added the necessary things

Current behavior

Proposed changes

Checks

[ ] All commits in this Pull Request are signed and Verified by Github.
[ ] All commits in this Pull Request follow the Ockam commit message convention.
[ ] There are no Merge commits in this Pull Request. Ockam repo maintains a linear commit history. We merge Pull Requests by rebasing them onto the develop branch. Rebasing to the latest develop branch and force pushing to your Pull Request branch is okay.
[ ] I have read and accept the Ockam Community Code of Conduct.
[ ] I have read and accepted the Ockam Contributor License Agreement by adding my Git/Github details in a row at the end of the CONTRIBUTORS.csv file in a separate pull request to the build-trust/ockam repository. The easiest way to do this is to edit the CONTRIBUTORS.csv file in the github web UI and create a separate Pull Request, this will mark the commit as verified.

@Salonikansal2 adding the HACKTOBERFEST-ACCEPTED even though we rolled the changes into one PR.


looks similar to neverlose.cc

🤔

😭

what the flip? toggles = neverlose? are you okay? do you need to talk to someone?


policy

good

Hi @thepowerzero, I'm closing this as off topic. Please see our Contributing.md for the types of feedback we're looking for on our Site Policies in this repo.


Manual validation feature for http-01 and tls-sni-01 challenges

When we cannot run an ACME client on the target server a "manual" mode for the http-01 and  tls-sni-01 challenges would be helpful.
Adding --manual flag to run command can be a solution imho.
Btw, Let's Encrypt client has a plugin for this.

I had a quick look at what the "manual" plugin does for the official client.
Am I right with the assumption that lego would need to output curl commands for example which a user could use to run them on a distant machine?

Curl commands are not necessary. I think just printing the challenge with some instructions and waiting user's action to continue would be sufficient.
For example, something like this for http-01:
$ lego --domains example.com --email<EMAIL_ADDRESS>run --manual
...
A HTTP get request to url
    http://example.com/.well-known/acme-challenge/{token}
must return the following string in the response body
    {jws string here}

Press ENTER when your server is ready.

+1

+1

Is there a way to use this for an automated process of what an admin would do with it?

@gaillard Why not get a SAN cert for the 20 subdomains and then distribute them across your machines?

Wondering if this is still necessary anymore; and even if so, if it is a good idea at all. The goal is to automate the process of managing certificates. If there a manual step is possible, then we fall short of that and people continue to rely on manual ways.


Adding CRUD

Thank you for putting this together. Any chance we can add CRUD features to this?

Sorry for the late response. Would it be possible to add button/buttons to edit data using a modal or inline edit? Also sorting and pagination would be nice.

Pagination is available via undocumented props:
  showPagination={true}
  count={50}
  rowsPerPage={10}
  page={1}


Update sbt-assembly to 1.2.0

Updates com.eed3si9n:sbt-assembly from 1.1.1 to 1.2.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.eed3si9n", artifactId = "sbt-assembly" } ]

labels: sbt-plugin-update, early-semver-minor, semver-spec-minor, commit-count:1

Codecov Report

Merging #378 (aaea5f8) into main (2f5c84e) will increase coverage by 0.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #378      +/-   ##
==========================================
+ Coverage   96.48%   96.66%   +0.17%
==========================================
  Files           9        9
  Lines        1138     1138
  Branches      105      105
==========================================
+ Hits         1098     1100       +2
+ Misses         40       38       -2

Impacted Files
Coverage Δ

core/shared/src/main/scala/cats/parse/Parser.scala
96.72% <0.00%> (+0.21%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f5c84e...aaea5f8. Read the comment docs.


Set proxies according to the *_PROXY environment variables

The [protocol]_PROXY and NO_PROXY environment variables are commonly used to configure proxies in applications. Wget and Emacs are two examples. Python's requests library also respects HTTP_PROXY and HTTPS_PROXY out of the box.
It would be great if we could have a helper method like HTTP::Proxy::Client.use_env that would do the followings

When used, it would automatically load the appropriate settings from ENV and create the corresponding HTTP::Proxy::Client objects.
It would then monkey-patch the HTTP::Client class in the standard library so that the clients use the appropriate proxies in all requests.

Here's an example implementation I used in my project. I will be happy to submit a PR if you think it's a good idea.

Looks good for me! :+1:
However, the get_proxy method could return nil, resulting in the following error
In src/utils/proxy.cr:33:26

 33 | client.set_proxy get_proxy uri
                       ^--------
Error: expected argument #1 to 'HTTP::Client#set_proxy' to be HTTP::Proxy::Client, not (HTTP::Proxy::Client | Nil)

This error can of course be easily avoided
        if prxy = get_proxy(uri)
          client.set_proxy prxy
        end

Thanks!

@kojix2 Which specific piece of code are you referring to?


Include WAF best practices for on-premise to Azure application traffic

Based on the Zero-Trust model, on-premise inbound traffic over vpn or ExR should be processed by a WAF either on-premise or in Azure. Can you please add literature that reflects this?

@smithers54 This issue is missing the template text that points to a specific article. Can you provide a URL for the article where this suggestion applies?

Without details on the article the suggestion applies to, I'm going to have to close this issue. Feel free to open a new request with more specifics. #please-close


Links with redirects result in flaky errors

Links like this, result in flaky errors like below which are thrown only sometimes,
"https://blog.openshift.com/federated-prometheus-with-thanos-receive/" not accessible; status code 0: Get "https://www.openshift.com/blog/federated-prometheus-with-thanos-receive/": context deadline exceeded (Client.Timeout exceeded while awaiting headers)

It would be great to tackle this one. Often it causes intermittent test build failures.


Update making-your-github-app-available-for-github-enterprise-server.md

Fix typo

Why:
Closes:

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

[ ] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

[ ] For content changes, I have completed the self-review checklist.

@FrenkenFlores Thanks so much for opening a PR with this fix! I'll update the branch and get this merged once tests are passing 🍏


added support for vendors as git submodules

Background: So earlier today I got a private invite from pagodabox and they have support for Symfony2! Yey. The catch is we have to deploy our apps in github and pagoda clones them. Now, the problem are the vendors in symfony-se dist because we're not suppose to include them with our repo. And pagoda does not have ssh support so we can install the vendors via cli. The good thing is they support git submodules. Currently there is no easy way to sync submodules' version from deps.lock, until now. So I made this PR so we can do something like below with just editing our deps file.
$ bin/vendors install --submodules

The catch is you have to commit every vendor top level directory to git so next time services like pagoda can checkout the right version. As a consequence the script requires us to remove /vendor entry in .gitignore.

Closing as we are now using Composer.


feat(dart): add snippet for freezed plugin

freezed is a very popular package in Dart & Flutter developer community for generating immutable data and model classes. It also allows us create Union & Sealed classes as well, however it requires some boilerplate code to be written in order to generate necessary code.
It becomes quite tiring to write the same boilerplate for each model over and over again, hence adding support for snippets would greatly boost productivity.
Snippets

[x] Freezed class.
[ ] Union/Sealed class.

Looks good so far. Feel free to ping me once you're ready for a review :sunglasses:


delete external macro

I would prefer to just have one way of using common snippets.

My preference is to keep snippets separate from partial guide parts. A snippet can be used from nearly any guide, but partial guides only make sense as part of a "base" guide that N (2 or more, but likely not many) build from. Putting the files in N+1 guides subdirectories keeps everything logically connected.
At a minimum, I'd like to go back to my initial suggestion where we keep partial guide adoc files under src/docs/common/partial (or some other subdirectory name)


Refine implicit priority change warnings

Fixes #21036
Fixes #20572

We now miss the following change:
trait A[T]
trait B[T] extends A[T]

given b[T]: B[T] = ???
given a[T]: A[T] = ???

val y = summon[A[String]] // changes from `b` in 3.5 to `a` 3.6 as expected but without warning in either

It seems we really do need to know whether the cand we are filtering out early would have been a SearchSuccess to decide whether or not to report a warning.
I guess an alternative solution would be to just disable the filtering of candidates for which compareAlternatives changes between the two modes.

This should be part of 3.5.0 RC4.


[stable/prometheus] Add cluster.advertise-address to alertmanager cmd args

What this PR does / why we need it:
Which issue this PR fixes

fixes broken prometheus alertmanager startup by adding the command argument cluster.advertise-address #6507

Special notes for your reviewer:
Checklist

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

/ok-to-test
/lgtm

/retest

/retest

/lgtm

/ok-to-test
/lgtm


custom createContainer

In 3.4.5, select2 uses the createContainer function to render the arrow which activates the dropdown list, like here: https://select2.github.io/examples.html#placeholders
I would like to have a different icon for that arrow. Is there any way to override the createContainer function?

Select2 3.4.5 is no longer supported, and questions about Select 3.5.4 are best directed to the community.

This appears to be more of a usage question than a bug report or common feature request.  As we continue to keep the Select2 issue tracker geared towards these two areas, bug reports and common feature requests, we are redirecting usage questions to other communities such as the mailing list, IRC, or Stack Overflow.


make use of unbounded channel to store xds response, in case forward …

…to envoy is slower than pilot sender
Please provide a description of this PR:

@hzxuzhonghu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-operator-controller_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-operator-controller

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-operator-controller_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-operator-controller

integ-pilot-multicluster_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-pilot-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-operator-controller_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-operator-controller

integ-pilot-multicluster_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-pilot-multicluster

integ-ambient_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-operator-controller_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-operator-controller

integ-pilot-multicluster_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-pilot-multicluster

integ-ambient_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-ambient

integ-pilot-istiodremote_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-pilot-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-operator-controller_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-operator-controller

integ-pilot-multicluster_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-pilot-multicluster

integ-ambient_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-ambient

integ-pilot-istiodremote_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-pilot-istiodremote

integ-telemetry-istiodremote_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-telemetry-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-operator-controller_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-operator-controller

integ-pilot-multicluster_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-pilot-multicluster

integ-ambient_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-ambient

integ-pilot-istiodremote_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-pilot-istiodremote

integ-telemetry-istiodremote_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-telemetry-istiodremote

integ-telemetry-mc_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-telemetry-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-operator-controller_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-operator-controller

integ-pilot-multicluster_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-pilot-multicluster

integ-ambient_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-ambient

integ-pilot-istiodremote_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-pilot-istiodremote

integ-telemetry-istiodremote_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-telemetry-istiodremote

integ-telemetry-mc_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-telemetry-mc

integ-telemetry_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-telemetry

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-operator-controller_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-operator-controller

integ-pilot-multicluster_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-pilot-multicluster

integ-ambient_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-ambient

integ-pilot-istiodremote_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-pilot-istiodremote

integ-telemetry-istiodremote_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-telemetry-istiodremote

integ-telemetry-mc_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-telemetry-mc

integ-telemetry_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-telemetry

integ-ds_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-ds

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-operator-controller_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-operator-controller

integ-pilot-multicluster_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-pilot-multicluster

integ-ambient_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-ambient

integ-pilot-istiodremote_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-pilot-istiodremote

integ-telemetry-istiodremote_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-telemetry-istiodremote

integ-telemetry-mc_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-telemetry-mc

integ-telemetry_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-telemetry

integ-ds_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-ds

integ-cni_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-operator-controller_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-operator-controller

integ-pilot-multicluster_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-pilot-multicluster

integ-ambient_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-ambient

integ-pilot-istiodremote_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-pilot-istiodremote

integ-telemetry-istiodremote_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-telemetry-istiodremote

integ-telemetry-mc_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-telemetry-mc

integ-telemetry_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-telemetry

integ-ds_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-ds

integ-cni_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-cni

integ-basic-arm64_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-basic-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-operator-controller_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-operator-controller

integ-pilot-multicluster_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-pilot-multicluster

integ-ambient_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-ambient

integ-pilot-istiodremote_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-pilot-istiodremote

integ-telemetry-istiodremote_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-telemetry-istiodremote

integ-telemetry-mc_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-telemetry-mc

integ-telemetry_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-telemetry

integ-ds_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-ds

integ-cni_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-cni

integ-basic-arm64_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-basic-arm64

integ-distroless_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-distroless

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-operator-controller_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-operator-controller

integ-pilot-multicluster_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-pilot-multicluster

integ-ambient_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-ambient

integ-pilot-istiodremote_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-pilot-istiodremote

integ-telemetry-istiodremote_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-telemetry-istiodremote

integ-telemetry-mc_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-telemetry-mc

integ-telemetry_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-telemetry

integ-ds_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-ds

integ-cni_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-cni

integ-basic-arm64_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-basic-arm64

integ-distroless_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-distroless

integ-ipv6_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-ipv6

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-operator-controller_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-operator-controller

integ-pilot-multicluster_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-pilot-multicluster

integ-ambient_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-ambient

integ-pilot-istiodremote_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-pilot-istiodremote

integ-telemetry-istiodremote_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-telemetry-istiodremote

integ-telemetry-mc_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-telemetry-mc

integ-telemetry_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-telemetry

integ-ds_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-ds

integ-cni_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-cni

integ-basic-arm64_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-basic-arm64

integ-distroless_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-distroless

integ-ipv6_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-ipv6

integ-pilot_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-pilot

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-operator-controller_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-operator-controller

integ-pilot-multicluster_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-pilot-multicluster

integ-ambient_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-ambient

integ-pilot-istiodremote_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-pilot-istiodremote

integ-telemetry-istiodremote_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-telemetry-istiodremote

integ-telemetry-mc_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-telemetry-mc

integ-telemetry_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-telemetry

integ-ds_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-ds

integ-cni_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-cni

integ-basic-arm64_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-basic-arm64

integ-distroless_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-distroless

integ-ipv6_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-ipv6

integ-pilot_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-pilot

integ-telemetry-discovery_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-telemetry-discovery

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-operator-controller_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-operator-controller

integ-pilot-multicluster_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-pilot-multicluster

integ-ambient_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-ambient

integ-pilot-istiodremote_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-pilot-istiodremote

integ-telemetry-istiodremote_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-telemetry-istiodremote

integ-telemetry-mc_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-telemetry-mc

integ-telemetry_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-telemetry

integ-ds_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-ds

integ-cni_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-cni

integ-basic-arm64_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-basic-arm64

integ-distroless_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-distroless

integ-ipv6_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-ipv6

integ-pilot_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-pilot

integ-telemetry-discovery_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-telemetry-discovery

integ-pilot-istiodremote-mc_istio
2b7d02407d5f87a52eef7dd03b0e9091ec05c1a1
link
true
/test integ-pilot-istiodremote-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

can you take a look @howardjohn

This is based on the envoy is slow processing the xds response  reported from https://github.com/istio/istio/issues/48517, see my analysis https://github.com/istio/istio/issues/48517#issuecomment-1869858439
We simply make istiod not affected by one particular client pressure, leaves the backpressure all to client side. In other words this is to make the system control plane more reliable, rather than less

What data do we have to suggest this is an improvement?
For example, if we used envoy directly without xds proxy it would behave like the proxy without this PR.
It's not clear why we should remove back pressure which can lead to unbounded memory usage and OOM

What data do we have to suggest this is an improvement?

istiod can never block sending, and bo goroutine leak.
I can understand your theory is based on that you prefer blocking from the source rather than client message accumulation.  My view is based on that source here istiod is a shared component, while the client is per workload, a slow client should not consume server resources.

What data do we have to suggest this is an improvement?

istiod can never block sending, and bo goroutine leak.
I can understand your theory is based on that you prefer blocking from the source rather than client message accumulation. My view is based on that source here istiod is a shared component, while the client is per workload, a slow client should not consume server resources.

I don't think it's a good practice to entirely remove back pressure. Under high load, istiod can push repeatedly and accumulate GBs of unprocessed data which will trigger OOM. Clients must protect themselves.
I agree the server side is not ideal, but we should discuss proposals on how to better handle that IMO - I've thought about it before and don't have any great ideas, but I am sure there are some improvements we could make.

Isn't what we do here just like istio dataplane for workload's requests? We can apply ratelimit for traffic between C/S, or set buffer limit for them. And even set timeout, actually these three ways are all open to users.
Here we are merely normal users, we face the same situation as users of istio.

Envoy sidecar proxy is not indefinitely buffering up requests without sending them (I don't think ever, but certainly not in Istio's configuration).

This is a good reason, make sense


Cannot migrate 2nd connection postgres database. Thinks migration table does not exist, then tries to make it, and fails because it does exist.

Laravel Version: 9.17.0

PHP Version: 8.0.19

Database Driver & Version: pgsql, Postgresql 12 &  Timescale 13.7 for the 2nd connection in question

Description:
After updating to laravel 9, suddenly our migration script stopped working for our 2nd DB connection. You can see in the screenshot that I can query the migrations table, however status cannot find the table. So the migrate attempt itself will fail, because it tries to create the migrations table, but then errors because ofcourse that table already exists.

database.php
 'connections' => [

        'pgsql' => [
            'driver' => 'pgsql',
            'host' => 'db',
            'port' => '5432',
            'database' => 'tenant',
            'username' => 'username',
            'password' => 'password',
            'charset' => 'utf8',
            'prefix' => '',
            'prefix_indexes' => true,
            'search_path' => 'public',
            'sslmode' => 'prefer',
        ],

        'audits' => [
            'driver' => 'pgsql',
            'host' => 'db2',
            'port' => '5432',
            'database' => 'audits',
            'username' => 'username',
            'password' => 'password',
            'charset' => 'utf8',
            'prefix' => '',
            'prefix_indexes' => true,
            'search_path' => 'public',
            'sslmode' => 'prefer',
            'options' => [
                PDO::ATTR_EMULATE_PREPARES => true,
            ],
        ],

    ],

Steps To Reproduce:
I'm not sure. Have 2 db connections, both postgres, and try to migrate the 2nd connection?

Hey there,
Can you first please try one of the support channels below? If you can actually identify this as a bug, feel free to open up a new issue with a link to the original one and we'll gladly help you out.

Laracasts Forums
Laravel.io Forums
StackOverflow
Discord
Larachat
IRC

Thanks!

Classic.

I'm having the same problem as well

@yairmishnayot  I was not able to find the time to look into it any deeper, and I felt I provided enough details to show that it seems like a Laravel framework code problem. Good luck, not sure if they will open the issue, we got the dreaded copypasta immediately so. 🤷

So what do you do in order to keep the development with postgres? Rolled back to laravel 8?

In our unique circumstance, we were lucky enough that we did not need to migrate the 2nd table to continue, so we literally are just treading water and luckily our second table does not need migrations right now. No solution was found.


Hookup and tests for WDL metadata

Working on #1414 based on current examples found via https://github.com/search?q=author+email++language%3Awdl&type=Code

will likely need tests to make this more robust for malformed WDL

Coverage decreased (-65.4%) to 10.431% when pulling 8cb830e4660ea6c7f71aa8137a67b3d871152684 on feature/wdl_metadata_hookup into d4dd5028949905272934356648cde280ee4c8cd8 on develop.


No margin for main bottom nav on iPhone 12

@titanous reports on #4365:

[…] Additionally, the margin for the "home swipe bar" appears to be missing.

and adds at https://github.com/zulip/zulip-mobile/issues/4365#issuecomment-752779450 :

It only reproduces in the simulator for the 12/12 Pro/12 Pro Max and on my physical 12. The simulator 12 mini, and various models of the 11 have the correct margin. This is another case where the App Store version has the correct margin on my physical 12, but all local builds are broken.

The symptom is reminiscent of #3066. It seems like there's a new behavior with the layout of the iPhone 12 screen (but not the 12 mini), which we're not handling properly.
As for why local builds differ from the version in the App Store -- those local builds were with Xcode 12.3, whereas the latest App Store version was built with Xcode 11.7 (or possibly earlier). For the main issue of #4365, @titanous suggests

I wonder if perhaps the App Store version was built against an older SDK version or with an older version of Xcode and so there's a compatibility layer that's being inserted?

and that seems quite plausible here too -- i.e. perhaps as long as the app was built with Xcode 11, the iPhone 12 doesn't expect it to know about the iPhone 12's new behavior, and treats it with a compatibility mode.

@gnprice Can I work on this issue?

@gnprice Can I work on this issue?

This was fixed in 12284502bb68df733ed1f384bd5da5944b56e7fe; see my comment at https://github.com/zulip/zulip-mobile/commit/12284502bb68df733ed1f384bd5da5944b56e7fe#commitcomment-45962457.

This was fixed in 12284502bb68df733ed1f384bd5da5944b56e7fe; see my comment at https://github.com/zulip/zulip-mobile/commit/12284502bb68df733ed1f384bd5da5944b56e7fe#commitcomment-45962457.

No worries @chrisbobbe Will start working on another issue 👍

No worries @chrisbobbe Will start working on another issue 👍


add support for default values with a field that is a pydantic model

In this PR, I am adding support for having a pydantic model be a default value for a field on an input.  Previously this would not generate the proper schema.
Description
My original fix was modifying code in from_input_field inside of the schema converter.  This is the point where we are instantiating a graphql input type, and I was checking to see if the default value had a model dump method on it.  This seems a little better since it is still within the pydantic specific code.  The issue I'm trying to solve is that when we print the schema from within print_input_value we use ast_from_value on the default value.  We fall into the is_input_object_type case and then we check if there is an object definition for the value.  If is_input_object_type evaluates to True then we call strawberry.asdict.  I think we'd want to do something similar with a pydantic instance.  Today we fail the check and end up returning None which causes the default value to not be printed in the schema.  What I'm doing in this MR is detecting if our default value is a pydantic instance, and if it is then I am storing the serialized value for the pydantic model as the default value.
I'm curious to know if there is a better way to plug into the printing process because that feels more inline with what we are doing with dataclasses today.  I could add code that I had previously into either print_input_value or ast_from_value, but that felt a little more hacky since we are putting pydantic specific stuff in higher level code.
Types of Changes

[ ] Core
[x] Bugfix
[ ] New feature
[ ] Enhancement/optimization
[ ] Documentation

Issues Fixed or Closed by This PR
This fixes #3285
Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@ppease is there any reason why this is draft? just double checking!

@ppease is there any reason why this is draft? just double checking!

This fix resolves my original issue.  The only reason I made it a draft is I just wanted to make sure the fix made sense architecturally, and there wasn't a more preferred way to fix the issue.

@ppease I think the fix is fine! 😊

@patrick91 Sounds good!  Thanks for reviewing it!  I went ahead and marked it as ready.

@ppease thanks! looks like the tests all passed here, so I merged it
Mypy sometimes does weird things locally with pydantic :D


Align the Q / DQ datatype before & after BN + Relu & MaxPool & BN for ITEX model

Type of Change
feature
Description
Jira: ILITV-2939
Expected Behavior & Potential Risk
Fix specific pattern for ITEX
How has this PR been tested?
PreCI, Extension
Dependency Change?
No

Extension test for TF ITEX OOB100: https://inteltf-jenk.sh.intel.com/view/lpot-validation/job/inc-itex-integration-validation-top-extension/35/

@chensuyue: ITEX requests,  this PR needs to be merged into master by today.


Standardize paths.ignore usage

...In order to set the variable once and not have to modify based on project folder, function or task.
An easy fix is to use use cwd to set directories so source and ignore paths can be clearly stated.

It doesn't appear that the file object in the watch task can be expanded like most other tasks--that is at least one exception/obstacle.


[Bug] Rule 0302 is not Title Case

What happened?
Rule 0302 says, its title case:

According to title case definition (wikipedia and others) its not.
Capitalizing each word != Title Case
Depending on what type of Title Case is used, some words must be lowercase.
-> The rule for real title case would be quite some implementation. Also, you can also change the rule to first_word_capitalized, so the warning should read:
wrong-case-in-keyword-name: Keyword name does not adhere to "each_word_capitalized/first_word_capitalized"
PS: The same is probably true for other 03xx rules.
Operating System
Documentation (=everywhere)
Robocop version
stable

Hi, thanks for raising the issue (and sorry for the late reply). I agree that rule warning does not  adhere to title case definition. It should probably read "Keyword name does not follow case convention". I will look into it.

I think that the only problem is with the rule's message which says it's title case while we check each word to be capitalized. So I updated the message to what @bhirsz proposed: "Keyword name '{{ keyword_name }}' does not follow case convention".
IMO Everything else is fine.

Thanks @KUGA2 for the report. I updated the message for the rule. The fix should be released along with the Robocop v.2.1.0 soon.


[SMALLFIX] Clarify alluxio.master.startup.block.integrity.check.enabled

reason to have this PR is to clarify that alluxio.master.startup.block.integrity.check.enabled not available in 1.7.0, which users reported confusion.

@calvinjia , I addressed your comments. I prefer to have a separate PR to change the default value. As I want to cherry-pick this PR to 1.7 branch.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/19211/
Test PASSed.

Merged build finished. Test PASSed.


Do Not merge yet: Qod-profiles

Adding support for QoS profiles

Sorry.  I meant to create a PR on my fork, not this repo.


Text changed: Criteration => Performance and Params to Parameters

https://github.com/DoHaiSon/InSI/commit/e5837c443981cb5fd1b9d55776751123755fa5aa


Move big data generator to a separate module

This moves the data generator out of the integration_tests module and into its own module, making it simpler to pull in as a dependency and more focused if we decide to publish the build artifact later.

build

build


SPFx. 1.15 Node version

According to the release notes for SPFx 1.15.0, Node.js v.16 is not supported, but according to this page, that's not the case.
Which one should I go by?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 25459e4a-2488-302d-9906-cfacfdc4639a
Version Independent ID: 339fbcec-873c-9c47-fd9c-cf5f505132ac
Content: SharePoint Framework development tools and libraries compatibility
Content Source: docs/spfx/compatibility.md
Service: sharepoint
Product: sharepoint
Technology: sharepoint-framework
GitHub Login: @VesaJuvonen
Microsoft Alias: vesaj

Dupe of https://github.com/SharePoint/sp-dev-docs/issues/8224


AttributeError: 'DatasetDict' object has no attribute 'shard' when running SimHash deduplication

When I run
!python -m text_dedup.simhash
--path "/content/A"
--output "/content/deduplicated.csv"
--column "question"
--batch_size 10000
--use_auth_token false
I have a issue. Can you help me to solve this?
Generating train split: 382951 examples [00:39, 9804.19 examples/s]
Map (num_proc=2): 100% 382951/382951 [00:40<00:00, 9521.03 examples/s]
SimHashing... (num_proc=2): 100% 382951/382951 [04:45<00:00, 1343.27 examples/s]
Iterating SimHashes...:   0% 0/1 [00:00<?, ?it/s]
Traceback (most recent call last):
File "/usr/lib/python3.10/runpy.py", line 196, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/usr/lib/python3.10/runpy.py", line 86, in _run_code
exec(code, run_globals)
File "/usr/local/lib/python3.10/dist-packages/text_dedup/simhash.py", line 466, in
main()
File "/usr/local/lib/python3.10/dist-packages/click/core.py", line 1157, in call
return self.main(*args, **kwargs)
File "/usr/local/lib/python3.10/dist-packages/click/core.py", line 1078, in main
rv = self.invoke(ctx)
File "/usr/local/lib/python3.10/dist-packages/click/core.py", line 1434, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/usr/local/lib/python3.10/dist-packages/click/core.py", line 783, in invoke
return __callback(*args, **kwargs)
File "/usr/local/lib/python3.10/dist-packages/text_dedup/utils/args.py", line 61, in wrapper
return func(*args, **kwargs, io_args=io_args)
File "/usr/local/lib/python3.10/dist-packages/text_dedup/utils/args.py", line 85, in wrapper
return func(*args, **kwargs, meta_args=meta_args)
File "/usr/local/lib/python3.10/dist-packages/text_dedup/utils/args.py", line 183, in wrapper
return func(*args, **kwargs, simhash_args=simhash_args)
File "/usr/local/lib/python3.10/dist-packages/text_dedup/simhash.py", line 371, in main
with timer("Total"):
File "/usr/local/lib/python3.10/dist-packages/text_dedup/utils/timer.py", line 18, in exit
raise exc_val
File "/usr/local/lib/python3.10/dist-packages/text_dedup/simhash.py", line 395, in main
with timer("Clustering"):
File "/usr/local/lib/python3.10/dist-packages/text_dedup/utils/timer.py", line 18, in exit
raise exc_val
File "/usr/local/lib/python3.10/dist-packages/text_dedup/simhash.py", line 402, in main
embedded_shard = embedded.shard(
AttributeError: 'DatasetDict' object has no attribute 'shard'. Did you mean: 'shape'?

It seems that the path is pointing to a DatasetDict instead of Dataset. You can modify the loading code to use a specific split.

Thank you very much. I fixed it!


Fix AccessSummaryAnalysis to handle @convention(block) in nested noescape closures.

This analysis uses a whitelist so we can be sure not do miss any diagnostics. Naturally there are some very unusual cases that weren't part of that original whitelist. As I've already pointed out, these kind of assumptions should be ratified in SILVerifier, but that will need to come in a subsequent commit.

@swift-ci test.

Thanks Andy! This looks great.

Thanks. Refactor error.


prqlc: 0.13.0 -> 0.13.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/prql/prql/releases.
meta.description for prqlc is: CLI for the PRQL compiler - a simple, powerful, pipelined SQL replacement
meta.homepage for prqlc is: https://github.com/prql/prql
meta.changelog for prqlc is: https://github.com/prql/prql/blob/0.13.2/CHANGELOG.md
Updates performed

Rust version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.13.2 with grep in /nix/store/6i60zmp2l5vshybpwaji5paxira0lwij-prqlc-0.13.2
found 0.13.2 in filename of file in /nix/store/6i60zmp2l5vshybpwaji5paxira0lwij-prqlc-0.13.2

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

prqlc

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/6i60zmp2l5vshybpwaji5paxira0lwij-prqlc-0.13.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A prqlc https://github.com/r-ryantm/nixpkgs/archive/44503c3ca3a305d5ddecbc1a457d6d5950029d2a.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/44503c3ca3a305d5ddecbc1a457d6d5950029d2a#prqlc

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/6i60zmp2l5vshybpwaji5paxira0lwij-prqlc-0.13.2
ls -la /nix/store/6i60zmp2l5vshybpwaji5paxira0lwij-prqlc-0.13.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 1 package built:

prqlc

Maintainer pings
cc @dit7ya for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 349047

aarch64-darwin

:white_check_mark: 1 package built:

prqlc


Still no contributing.md

https://github.com/ripple/rippled/pull/3955
https://github.com/ripple/rippled/issues/3312
https://github.com/ripple/rippled/pull/3922
Why?

Honestly, this is just a guess but I think the maintainers want to write a complete and understandable contributing page for devs to refer to. The contributing.md that I provided is a good base format to start off, but it looks complete to me and understandable to me.

Just linking so that anyone coming across this issue has context: #4214

Fixed by https://github.com/XRPLF/rippled/pull/4214. (I'd close this issue, as well as https://github.com/XRPLF/rippled/issues/3312, but I don't have permission.)

Fixed by #4214. (I'd close this issue, as well as #3312, but I don't have permission.)

Thank you! And you should have permission now :)


Add "Open in Google Cloud Shell" button to README file.

The build instructions using the Docker image work. I haven't tried installing the dependencies separately.

@SurferJeffAtGoogle So what's the decision on this PR?

@noerog Thanks for the PR. I tried that link, but I must say it's just more confusing to users for several reasons.

User starts from the top level directory in the repo while the UI shows the README in iot/mqtt-ciotc
I don't know what to do. Should I follow the instructions for installing the dependencies? or Should I follow the Docker instructions?
Even after that, I don't know what to do.

I suggest that you add a special README file for "Open in Google Cloud Shell" so that the user experience will be greater.

Closing due to inactivity


sample code won't run

Hello,
getting this error while trying to run it. I guess I am missing install for OAuthSettings.
Can you help?
ERROR in src/app/auth.service.ts:9:31 - error TS2307: Cannot find module '../oauth'.
9 import { OAuthSettings } from '../oauth';
~~~~~~~~~~
src/app/app.module.ts:17:31 - error TS2307: Cannot find module '../oauth'.
17 import { OAuthSettings } from '../oauth';

I see there is an item which need to be rename. closing issue


Adding option so MaxRequestsPerHost can be configurable

increasing default to 200

Coverage increased (+0.08%) to 93.254% when pulling 98087eeb7451fd742df0edbed92a7c019ce38d31 on tlisonbee:max-requests into 2f8287a5a6e5de5756e5de9d4c4e37c11216c75c on Nike-Inc:master.

Coverage increased (+0.08%) to 93.254% when pulling 7ffdd8b0614a65cd2a258045de1bef47e3ba1224 on tlisonbee:max-requests into 2f8287a5a6e5de5756e5de9d4c4e37c11216c75c on Nike-Inc:master.


route /signin-oidc produces 404 when running production build in iis

Hi,
i recently build a project that uses the plugin to connect to our identityserver. When using 'au run --watch' and navigating to the app with http://localhost:9000 everything works fine.
But when i create a production build and place it within a IIS folder to test it there, the redirection from identityserver back to the app fails with a HTTP Error 404.0 - Not Found.
I tried the provided samples but the result is the same.
IIS tries to resolve the following url:
http://pcname/prod/client/signin-oidc#id_token=eyJhbGciOiJSUzI1NiIsImtpZCI6IjU2NTg3MTViNzY2NzYyYTA5OWJjZGM1Y2M3YTMzNDM2IiwidHlwIjoiSldUIn0.eyJuYmYiOjE1NjgyOTQyMjksImV4cCI6MTU2ODI5NDUyOSwiaXNzIjoiaHR0cHM6Ly9kZW1vLmlkZW50aXR5c2VydmVyLmlvIiwiYXVkIjoiaW1wbGljaXQiLCJub25jZSI6IjhkNjcwMjg4ZDRkOTQxYTM5NzBmMWYxMTRhMjc0MzFiIiwiaWF0IjoxNTY4Mjk0MjI5LCJzaWQiOiIyYjZkMTI1MmFhODAwM2I1Njg2YWVkNGY0YTY1Y2RkYyIsInN1YiI6IjExIiwiYXV0aF90aW1lIjoxNTY4MjkzNzIzLCJpZHAiOiJsb2NhbCIsIm5hbWUiOiJCb2IgU21pdGgiLCJnaXZlbl9uYW1lIjoiQm9iIiwiZmFtaWx5X25hbWUiOiJTbWl0aCIsImVtYWlsIjoiQm9iU21pdGhAZW1haWwuY29tIiwiZW1haWxfdmVyaWZpZWQiOnRydWUsIndlYnNpdGUiOiJodHRwOi8vYm9iLmNvbSIsImFtciI6WyJwd2QiXX0.iU1X4nh6xovF2pFTwP08atAT1G0JwZXDfmj0O_3U60e38fO4sNnY4zDDZ0SUDp40j9B0QOmDq6cZHudtlLr56TaQg8AxiqkpeT3ah-L6ZcKmmxBryPPUOmCJedHUJBGrdMJivjMUTS2uYSuRxHwiObsTA2oe8uG18v7zg-r5MvUM-Ua7LDQeCll4QkbX6XGU-42x3DoDeNEF5rs7WIoGARqxWimkhJyShtKlHGJYFd6nWzawmJwkOGyhzwd3r3_LJbgrVAzFesrf93EH2wGtN2LzfWTRQfp6L7aO5VYzx_SmQa0zuQpKXxYHVo7XACyJLynpUB-cY0763mxdhJSYqQ&scope=openid%20email%20profile&state=7b34342c7d3849c481448bb09dfa5a9f&session_state=k_k_03A6a3UDZkaIwTpgfHd29xM-8EYSSjyjC4u1p54.b3be8e29db5e46b1320e0140bce22933
In the aurelia-app sample when publishing and opening i got a white page at first, but after i disabled the pushsstate within routerconfig i got to see the sample and tried to login. The above issue occured.
if i have config.options.pushState = true; i'm not being redirected to the login page, but when i comment it(//config.options.pushState = true;) i do get redirected.
The app is being run for example from this location: http://pcn-walter/profilename/product/client/
i tried url rewrite as found in another topic, but that did not help as the problem stayed.
@shaunluttin or anyone else is this a known issue, and if so, is there a solution available?
Kind regards,
Walter

So after someone on gitter suggested to install url rewrite and helped me figure out the appropiate web.config i managed to get the redirection to work.
I really hope some other fix will be made but for now this 'temp' fix will do.
the blogpost that helped me: https://weblog.west-wind.com/posts/2017/Apr/27/IIS-and-ASPNET-Core-Rewrite-Rules-for-Static-Files-and-Html-5-Routing

IIS URL rewriting is a perfectly valid way to handle this, it avoids that your initial request must pass through the .NET Core pipeline and is therefore probably the most performant way to handle this.
If you want to avoid configuring pushstate through IIS, the following code in your .NET Core startup.cs should suffice:
 // This method gets called by the runtime. Use this method to configure the HTTP request pipeline.
        public void Configure(IApplicationBuilder app, IHostingEnvironment env)
        {
            app.Use(async (context, next) =>
	        {
		        await next();

		        if (context.Response.StatusCode == 404
		            && !Path.HasExtension(context.Request.Path.Value))
		        {
			        context.Request.Path = "/index.html";
			        await next();
		        }
	        });

	        app.UseStaticFiles();
        }

This basically routes everything .NET Core can't find to your index.html file, so your local routing kicks in.

Thank you!
So thanks to your answer i am wondering something.
If i were to use the index.html as my aurelia redirect url for my identityserver clients(instead of http:nameofserver/client/signinoidc)., would that also help? Thinking about testing that this week.

It wouldn't work, when you configure this plugin on the router, the signin-oidc path is added as a valid route, when identityserver redirects to this url, the plugin code coupled to this route executes and logs the user in, using the information in the singin-oidc url fragments.
So if you would just redirect to your app root, this code would never execute, and you user would never be logged in

whoops forgot about that.
thnx for the dotnet core solution.  Will look into that.
Thnx!

I'm closing this, because I think you got the info you needed, feel free to reopen if you have additional questions!


Minor v2 fixes

Changed listOf() to emptyList(). This is more idiomatic and performant (although it doesn't matter here).
Updated the setLayerOpacity() documentation. It's not true that the API is a no-op, since the opacity does change and the changed opacity can be used in the future.

Thanks, I like quality changes like these.


make guarantees about orphaned processes

updates workerpool to v6.0.2, which guarantees child processes exit before Pool#terminate() resolves
cleanup test/integration/options/parallel.spec.js

@segrey this will make the guarantee about the worker processes you were asking about in #4403.

Ref: josdejong/workerpool#176

Coverage remained the same at 93.959% when pulling 56fe9c56c34a89b6bf37c8921329219b93571b67 on boneskull/update-workerpool into 8f5d6a9e642f12f98201f90015f525578d14881e on master.

@mochajs/core any review will do, this one is not big. here is what you should look at


[explore]filter placeholder push out in IN and NOT IN

super minor cosmetic issue in new ad hoc filter popover.
to reproduce:

create a new chart
add a filter from the SIMPLE tab
select operator IN , NOT IN
select multiple values -see placeholder overflow

resolved

resolved


test: add e2e test for examples in documentations

Signed-off-by: Jinjing.Zhou<EMAIL_ADDRESS>

Please ping me if it is ready to review.

@gaocegege PTAL


RUNNING ERROR

How to solve the problem below.
Episode 0
Total Reward: -19.0
E:\profession\pycharm\tensorflow\pytorch-nec-master\nec_agent.py:96: UserWarning: invalid index of a 0-dim tensor. This will be an error in PyTorch 0.5. Use tensor.item() to convert a 0-dim tensor to a Python number
action = torch.cat(q_estimates).max(0)[1].data[0]
d:\anaconda\lib\site-packages\h5py_init_.py:34: FutureWarning: Conversion of the second argument of issubdtype from float to np.floating is deprecated. In future, it will be treated as np.float64 == np.dtype(float).type.
from ._conv import register_converters as _register_converters
Traceback (most recent call last):
File "E:/profession/pycharm/tensorflow/pytorch-nec-master/run_nec.py", line 35, in
main(args.env, args.embedding_size)
File "E:/profession/pycharm/tensorflow/pytorch-nec-master/run_nec.py", line 23, in main
reward = agent.episode()
File "E:\profession\pycharm\tensorflow\pytorch-nec-master\nec_agent.py", line 179, in episode
self.update()
File "E:\profession\pycharm\tensorflow\pytorch-nec-master\nec_agent.py", line 133, in update
embedding_index = dnd.get_index(state_embedding)
File "E:\profession\pycharm\tensorflow\pytorch-nec-master\dnd.py", line 42, in get_index
self.commit_insert()
File "E:\profession\pycharm\tensorflow\pytorch-nec-master\dnd.py", line 80, in commit_insert
torch.cat([self.values.data, self.values_to_be_inserted], 0))
RuntimeError: invalid argument 0: Tensors must have same number of dimensions: got 2 and 1 at c:\programdata\miniconda3\conda-bld\pytorch-cpu_1532498166916\work\aten\src\th\generic/THTensorMath.cpp:3607
Process finished with exit code 1

I

The problem above have been solved.
What is LRU property? And what's  the role of  'self.move_to_back' in dnd.py


docs: Give examples for ugettext_lazy

Added examples to make sure that the reader knows exactly what we are talking about and just don't skip through it.

This is great, merged, thanks @hackerkid!


Javadoc fixes

Fixing javadoc errors in azure-common and eventhubs.

Can one of the admins verify this patch?

@JonathanGiles Done. Created: https://github.com/Azure/azure-sdk-for-java/issues/3435
I had a knee jerk reaction to go ahead and fix a lot of these errors last too. 🤔 The amount of spew is incredible.


Add the ability to run scripts on scale

Right now the .deployment file supports running a script on build.  But there are times where I would like to run separate actions when new nodes are created.
On top of command, maybe it might be nice to have a scale as well?

Kudu deals with deployment, but not runtime changes like scaling. forum is the better place to discuss this, though as it stands, the answer is that I don't think this is supported.

Gotcha, thanks! :)


Experiments

Type of change
Just an experiment.

/test ?

/test e2e-cluster-density-v2-single-node


0.138.x causes go-getter syntax to fail

When using version 0.138.x, when using go-getter syntax the following is produced:
Error: non-absolute URLs should be in form of repo_name/path_to_chart, got: git::https://...

When I switch back to 0.137.0, the error does not occur.
Helm version: 3.5.1

@kevin-lindsay-1 Thanks for reporting!
This seems like a regression introduced via https://github.com/roboll/helmfile/pull/1629/files#diff-7e4e87a1e777423a3d9a915e00fb78a9c4fc2f4c476863f60b67e89b9c635697R990.
I'll certainly fix this in next patch version of helmfile.

@kevin-lindsay-1 Thanks for reporting!
This seems like a regression introduced via https://github.com/roboll/helmfile/pull/1629/files#diff-7e4e87a1e777423a3d9a915e00fb78a9c4fc2f4c476863f60b67e89b9c635697R990.
I'll certainly fix this in next patch version of helmfile.

This should be fixed via #1667

FYI v0.138.3 has been released for #1667

Closing this as resolved. Please reopen if necessary


etcd security model page has a link that returns 404

On this page:
https://coreos.com/etcd/docs/latest/security.html
3rd paragraph in, "and we provide a full example using the tool at here". The link "here" 404s when viewed on coreos.com. The link is functional when viewed on github.

We need to make sure all links to documentation outside the Documentation folder are absolute, not relative.
Overall, we need to stop putting docs outside of the main location. They aren't discoverable or easy to sync to other locations.


Merge python 3.5 compatability fork

https://github.com/dongweiming/redisco/commit/aa93f31f81bf3f163b29f2783a70748ec4479f22
Without it one gets an Import Error can not import * from base.

merge it soon i realy need it
thanks


Packages dependencies on function deploy

Packages on sls deploy -f function_name

@logandk I was going to hold this because of this https://github.com/serverless/serverless/pull/3344 but I guess a full review of deployment hooks will be needed, so here goes...

Coverage decreased (-6.3%) to 93.651% when pulling 87ea5b01b75e480eaaa7387e8c3a1e55651feffb on lucascosta:package_function_deploy into 76c4404f4c55f0a549b877274a44661988211bdf on logandk:master.

Thanks Lucas! I agree, let's merge this now and review the deployment hooks when that gets released in Serverless...


test-branch/execute-job/wrong-commit-sha-on-pr/341d9ed2-a15c-479e-806a-497177f42707

PR for testing ad4b986b22552e6b39f52adfb067c017b5ed40bf

/canonical/self-hosted-runners/run-workflows 24f56729ec8c678802eff7dd465e91b324a86f42


Add an implementation of "Learning Multi-agent Communication with Backpropagation" to Flow

It would be interesting to port a few basic communication environments/training procedures to Flow. In particular, a popular communications baselines is "Learning Multi-agent Communication with Backpropagation" (https://arxiv.org/abs/1605.07736). As a request for research, we'd appreciate it if someone added the training procedure from this paper to our codebase. For open source reproductions of the training process, you can look here: https://github.com/KornbergFresnel/CommNet
To be clearer what would be great is:
(1) Take any of our existing environments, add vehicle to vehicle communication to them as part of the action space.
(2) Add a script to train in the new environment and use the Commnet as the model.

Hi Eugene, I'm interested in contributing. Would I be able to be an assignee for this feature?

Oh my god yes that'd be amazing. I've assigned you.

Please reach out if you get stuck or need help.

Hi Eugene, I've noticed that we currently use ray.rllib for the reinforcement learning algorithm. Do you suggest implementing CommNet from scratch to replace the existing RL algorithms supported by ray.rllib?

Hi Jenna,
So in this case of the CommNet, there isn't an algorithmic change, it's just a model. So you would just need to implement the model; the actual construction of a policy gradient would just be handled by rllib.

Dear all, was it finally implemeted? :)

Nope!  Still would love someone to do this.

Excellent, I will probably work on that since I definitely need to add some communication between my agents. I was also thinking on implementing the model proposed in "Connectivity-driven Communication in Multi-agent Reinforcement Learning through Diffusion Processes on Graphs". I will keep you in-the-loop. Thanks.

Please! We'd love any implementation you have, I've been meaning to play around with communication in these environments for YEARS.

Any updates on this!


[WIP] Notion import

Fixes dw-210

TEMP Notion database: https://www.notion.so/bankless/6b3a4ffc3bb146a7873e654f1209d979

Closing this PR because I had too many conflicts ...
I've recreated a clean version here https://github.com/BanklessDAO/bankless-website/pull/255


Background Mode

Is there anyway to have a background mode? Or maybe add a task to be executed when the watch plugin starts?
I'm trying to use it with another plugin (ratpack) that does not hand off control, similar to this plugin. Been trying to figure out how to do either:
a. Tell watch to run a task after it the task has started. For example:
watch {
  //configuration
 startAtEnd = "someOtherTask"
}

b. Tell watch to  go to background mode:
watch {
  // configuration
  background = true
}

Has there been any progress on this / plans for the future?  This would be a very lovely feature!


@conda-forge-admin, please add bot automerge

@conda-forge-admin, please add bot automerge

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/itables-feedstock#2.


Won't Let Me Install

When I try to install this through the terminal, it gives me an error

module.js:327
throw err;
^
Error: Cannot find module 'npmlog'
at Function.Module._resolveFilename (module.js:325:15)
at Function.Module._load (module.js:276:25)
at Module.require (module.js:353:17)
at require (internal/module.js:12:17)
at /mnt/shared/sbin/npm:18:11
at Object. (/mnt/shared/sbin/npm:75:3)
at Module._compile (module.js:409:26)
at Object.Module._extensions..js (module.js:416:10)
at Module.load (module.js:343:32)
at Function.Module._load (module.js:300:12)
Command failed: /mnt/shared/sbin/npm.

Please post your concerns here in this thread: https://community.c9.io/t/cannot-find-module-npmlog-when-trying-to-install-scala-plugin-for-cloud9/6846/6
This is a current but in cloud9's plugin system. It affects all plugins.


readproto is working on Julia 0.3 but does not work on Julia 0.4

I've just started to Julia so this may not be a problem, i have no idea.
It works on Julia 0.3
julia> conn = RedisConnection(;host="<HOST>", port=<PORT>, db=<DB>)
Redis.RedisConnection("HOST,"",DB,TCPSocket(open, 0 bytes waiting))

julia> symbolbuf= get(conn, "<KEY>")
"\bÈ\u90\x01\x12\rF_ONRPQ0916S0\x1a\x1cONRPQ Eylul 2016 Vadeli (S0)X\x02a\0\0\0\0\0\0\0\0j\n30.09.2016r\x05ONRPQ\u81\x01\0\0\0\0\0\0\0\0\u89\x01\0\0\0\0\0\0\0\0±\x02{\x14®Gáz\u84?"

julia> io = PipeBuffer(symbolbuf.data)
IOBuffer(data=UInt8[...], readable=true, writable=true, seekable=false, append=true, size=117, maxsize=Inf, ptr=1, mark=-1)

julia> result = readproto(io, DerivativeMessage());
ERROR: EOFError: read end of file
 in read_sub at /Applications/Julia-0.4.0.app/Contents/Resources/julia/lib/julia/sys.dylib
 in skip_field at /Users/niluferbidik/.julia/v0.4/ProtoBuf/src/codec.jl:295
 in readproto at /Users/niluferbidik/.julia/v0.4/ProtoBuf/src/codec.jl:318
 in readproto at /Users/niluferbidik/.julia/v0.4/ProtoBuf/src/codec.jl:308

Is there some way to reproduce this locally?
You could also get some more details by flipping the comments here to switch on logging: https://github.com/tanmaykm/ProtoBuf.jl/blob/51fbf7607b6ecb732e48d0b2317a5927335323c5/src/ProtoBuf.jl#L32

You can use proto file below
"\bÈ\u90\x01\x12\rF_ONRPQ0916S0\x1a\x1cONRPQ Eylul 2016 Vadeli (S0)X\x02a\0\0\0\0\0\0\0\0j\n30.09.2016r\x05ONRPQ\u81\x01\0\0\0\0\0\0\0\0\u89\x01\0\0\0\0\0\0\0\0±\x02{\x14®Gáz\u84?"

Derivative.txt

Could you also post a binary file for the serialized data?
I suspect the data will get corrupted when moved back and forth as a
string. And if that's what you are receiving from redis, it could be
causing this error. Julia strings underwent significant changes between
Julia 0.3 and 0.4 and that could explain the breakage.
On Fri, Nov 20, 2015 at 1:59 PM, nilbdk<EMAIL_ADDRESS>wrote:

You can use proto file below
"\bÈ\u90\x01\x12\rF_ONRPQ0916S0\x1a\x1cONRPQ Eylul 2016 Vadeli (S0)X\x02a\0\0\0\0\0\0\0\0j\n30.09.2016r\x05ONRPQ\u81\x01\0\0\0\0\0\0\0\0\u89\x01\0\0\0\0\0\0\0\0±\x02{\x14®Gáz\u84?"
Derivative.txt
https://github.com/tanmaykm/ProtoBuf.jl/files/39857/Derivative.txt
—
Reply to this email directly or view it on GitHub
https://github.com/tanmaykm/ProtoBuf.jl/issues/52#issuecomment-158321746
.

And, if you must store it as a string, you could encode and decode it
appropriately (e.g. base64)
On Fri, Nov 20, 2015 at 2:31 PM, Tanmay K. Mohapatra<EMAIL_ADDRESS>wrote:

Could you also post a binary file for the serialized data?
I suspect the data will get corrupted when moved back and forth as a
string. And if that's what you are receiving from redis, it could be
causing this error. Julia strings underwent significant changes between
Julia 0.3 and 0.4 and that could explain the breakage.
On Fri, Nov 20, 2015 at 1:59 PM, nilbdk<EMAIL_ADDRESS>wrote:

You can use proto file below
"\bÈ\u90\x01\x12\rF_ONRPQ0916S0\x1a\x1cONRPQ Eylul 2016 Vadeli (S0)X\x02a\0\0\0\0\0\0\0\0j\n30.09.2016r\x05ONRPQ\u81\x01\0\0\0\0\0\0\0\0\u89\x01\0\0\0\0\0\0\0\0±\x02{\x14®Gáz\u84?"
Derivative.txt
https://github.com/tanmaykm/ProtoBuf.jl/files/39857/Derivative.txt
—
Reply to this email directly or view it on GitHub
https://github.com/tanmaykm/ProtoBuf.jl/issues/52#issuecomment-158321746
.

Tried both readproto and writeproto with the spec file and found them working. I suspect this error is because of data corruption as suggested above. Closing this as not a ProtoBuf.jl issue.
Please reopen if you still see it.


Add deepActiveElement getter to the DomApi.

According to the current spec,
http://w3c.github.io/webcomponents/spec/shadow/#active-element
Document.activeElement returns "adjusted" element, i.e.
when the real focused element is within a shadow tree, it returns
the top-most shadow host in the Document treescope.

(https://github.com/w3c/webcomponents/issues/104)

I did author commit https://github.com/MartinMoizard/polymer/commit/8906b449723dc5b0b63c33b432434faa6765c8e8 and https://github.com/MartinMoizard/polymer/commit/83cc34391fcc65b0f14fe8352ce83d628aa8885f


HELP

Hello? I have a problem that How can i merge the two or more cell into one?

Thank you for your kind reply.  I will try to use other methods to do this. Thanks a lot


Bugfix. Get E-Mail if only userPrincipalName

There was a spelling mistake in userPrincipalName. If onyl userPrincipalName was availible. The object was null.
It is related to bug #5

Btw. compliment to your code 👍 . Was very easy to read.

Hey @bastiW, thanks for taking the time to write this PR. I'm happy to merge this but I'm not able to push the latest package version- I no longer work with meteor. If you're interested in taking responsibility for this package, I'm happy to discuss this with you.

Hi @djluck - Our company is developing meteor apps for internal use and need to integrate with AzureAD. I'm willing to take on responsibility for the package if you'd like.

Hey @luzlab, that might be for the best- I don't have any spare time to look after this these days and I don't spend any time playing with Meteor.

You can add me as a collaborator on this repo so I can push changes and approve PRs. For the atmosphere package, you can run meteor admin maintainers wiseguyeh:azure-active-directory --add additivegenius. This is from https://stackoverflow.com/questions/29267399/how-to-add-collaborator-for-meteor-package-in-atmosphere.
Let me know when you add me, and I'll accept this PR and update the atmosphere package.

@luzlab thanks for digging out that command. That's been done now, sorry for the delay. Let me know if there's anything else I need to do.

@djluck Thank you - I'll be able to update the package on atmosphere. But can you add me as a collaborator to this git repo too? Otherwise, Ill have to point the atmosphere package to a fork of this repo.

@djluck This is fixed in the latest release on Atmosphere.


difficult to describe MF: microtubule sliding brake

I want to describe the activity of acting as a brake to microtubule sliding.
The mechanism is like this:

As overlapping microtubules
start to slide apart, Ase1 molecules become compacted in the
shrinking overlap and the sliding velocity gradually decreases in
a dose-dependent manner. Compaction is driven by moving
microtubule ends that act as barriers to Ase1 diffusion.
any suggestions?
I can't see anything suitable under
https://www.ebi.ac.uk/QuickGO/term/GO:0003674

microtubule lateral binding
negatively_regulates 'plus end directed microtubule sliding'? I think the direction is correct.
'regulation of microtubule-based movement'

OK I wondered if to do that, but I thought that we wanted to have "non-binding" only molecular functions if we knew more about the mechanism than "microtubule binding"?
@pgaudet was that correct?
Anyway I can do it like this for now.
So in this case are we no longer using  "positive" and "negative" regulation of process terms?
I would like to be consistent with what we have done previously and request
'negative regulation of plus end directed microtubule sliding'
If we are using "negatively_regulates" to link functions to processes rather than have "regulation" process terms  we should  do it across all the annotation consistently?

I think adding the negative regulation term would be ok if it is still within scope. I didn't list it because we didn't have it. That's why I made the GO-CAMesque expression in the second line. With respect to the binding function, I thought about the desire not to use them and the only other thing I could think of was the 'protein binding, bridging term' and then having an input of a tubulin or microtubule. It's not inhibiting the kinesin and it's not really cross-linking. It's just kind of getting in the way. That's why I went with lateral binding.

Do you want me to add ''negative regulation of plus end directed microtubule sliding'?

Yes I don't think there is any obvious way to describe this activity. I will do as you suggest, yes please can I have
negative regulation of plus-end directed microtubule sliding

It is plus-end right, because the kinesin moves to the minus end?

Do you have a PMID?

PMID:21892183

yes the sliding is plus-end directed.


adapter.useNamedPipe not working with the new CloudAdapter (Node.js SDK)

Our docs are only teaching us how to use the adapter.useNamedPipe to inject named pipes to enable DL ASE in node.js SDK- Configure Node.js bots for Direct Line App Service extension in the Bot Framework SDK - Bot Service | Microsoft Learn
However, that method is no longer working with the new CloudAdapter introduced with BotBuidler V4.15.

As such, what is the new method compatible with the new CloudAdapter?
Can you provide a full sample as well please (with all the parameters required)?
Can we update the documentation as well, to make customers aware that the useNamedPipe method is working only with BotFrameworkAdapter, and also introduce a new sample specific to CloudAdapter?

IcM link: https://portal.microsofticm.com/imp/v3/incidents/details/347795623/home

Closing as the PR with the sample was merged and the docs were updated.


BBreadcrumbItem non-active items do not display

Inactive breadcrumbs do not show up when rendered using the  component
Take for example the following example (from Bootstrap Vue 2, but looking at your source code, it should be similar for BV-3)

      Home

    Foo
    Bar
    Baz

Outputs the following :

The expected behavior is that these inactive crumbs show up as links. If you used the items prop with a data variable, then the breadcrumb renders as it should.
Env:
"bootstrap": "^5.2.0",
"bootstrap-vue-3": "^0.3.5",
"vue": "^3.2.13",

There's a bug on the  element... bar in vue, it renders "foo" instead of "bar". This should not be happening. Regardless, it is fixed https://github.com/cdmoro/bootstrap-vue-3/pull/715


Added unicode include as its used below in source

Added missing include to unicode used below;

@bruvzg

It is already included via other headers, so should not be necessary:
https://github.com/godotengine/godot/blob/161d028ae89acb578cfcd4f29bfe9ac205459e8b/modules/text_server_adv/text_server_adv.h#L98-L109
And if there's any reason to include it directly (some specific config of OS wide ICU?), it probably should be done in the same place as other ICU headers as well.

I think I may be missing something, I'm not seeing how it's been included


[BugFix] Restart fe failed with InsufficientLogException

What type of PR is this：

[x] bug
[ ] feature
[ ] enhancement
[ ] others

Which issues of this PR fixes ：

Fixes #5642
Problem Summary(Required) ：

When fe has been stopped for a long time, the logs in bdb will be too far behind. On this case, bdb will throw the InsufficientLogException. We should catch this exception and refresh the log from master.

[FE PR Coverage check]
:disappointed: fail : 13 / 22 (59.09%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/journal/bdbje/BDBEnvironment.java
0
4
00.00%

:large_blue_circle:
com/starrocks/journal/bdbje/BDBJEJournal.java
13
18
72.22%

[FE PR Coverage check]
:disappointed: fail : 13 / 22 (59.09%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/journal/bdbje/BDBEnvironment.java
0
4
00.00%

:large_blue_circle:
com/starrocks/journal/bdbje/BDBJEJournal.java
13
18
72.22%


⚠ Bofrost.de has degraded performance

In a411de3, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1447 ms

Resolved: Bofrost.de performance has improved in 020cd82 after 18 minutes.


[MECHANIC]: Anti-Gravity Ball

Description of what will be added or updated
This yarn ball has no gravity to it after you shoot; it floats around the air, but objects and yarn balls can affect it by knocking it towards the ground with force or trying to hit it in different directions while it has no gravity.
Additional Information
No response

Done; camera rework necessary to prevent these from becoming impossible to see