Mute/unmute video properly.

Now muting turns the camera off instead of sending blank frames.

Start audio call, press unmute-mute video button a few times, get a crash:
call-panel.jsx:360 Error opening your camera and/or microphone: Cannot read properties of undefined (reading 'getSenders')
| handleGetUserMediaError | @ | call-panel.jsx:360
-- | -- | -- | --
  | Promise.catch (async) |   |
  | unmuteVideo | @ | call-panel.jsx:464
  | handleToggleCameraClick | @ | call-panel.jsx:473

Muting video freezes the picture but does not clear the screen to default (gray background with the avatar in the middle).

Start a call, press unmute-mute video button a few times, get a crash:
call-panel.jsx:360 Error opening your camera and/or microphone: Cannot read properties of undefined (reading 'getSenders')
handleGetUserMediaError	@	call-panel.jsx:360
 	Promise.catch (async)
 	unmuteVideo	@	call-panel.jsx:464
 	handleToggleCameraClick	@	call-panel.jsx:473

Fixed.

Muting video freezes the picture then the screen start flipping between two states:

I'm calling between FF and Chrome.
Audio must be enabled, otherwise it stays in the freeze-frame state.

Does the video freeze on FF? Or on both Chrome and FF?

Start a call, press unmute-mute video button a few times, get a crash:

Fixed

Now crashes in a different place (tested in FF):
Error opening your camera and/or microphone: pc is undefined call-panel.jsx:361:16
handleGetUserMediaError call-panel.jsx:361
unmuteVideo call-panel.jsx:466
handleToggleCameraClick call-panel.jsx:480
React 23
 index.js:46
 index.dev.js:21663
 index.dev.js:21665

Are you seeing any errors in either's console?

Are you seeing any errors in either's console?

Nothing in the console, just flashes once every 3-5 seconds on Chrome. Stays frozen-frame on FF.

Chrome still crashes with
Error opening your camera and/or microphone: Cannot set properties of null (setting 'srcObject')

Are you seeing any errors in either's console?

You are probably changing state (this.setState()) in response to some WebRTC event.

I just sent you a video of flashing through GPhotos

still crashing when i press video button in on the caller's end in chrome:
call-panel.jsx:362 Error opening your camera and/or microphone: Cannot read properties of undefined (reading 'getSenders')

| handleGetUserMediaError | @ | call-panel.jsx:362
-- | -- | -- | --
  | Promise.catch (async) |   |
  | unmuteVideo | @ | call-panel.jsx:467
  | handleToggleCameraClick | @ | call-panel.jsx:481


Deprecate Debian Jessie

We'll no longer build packages for it as part of a release. I removed
the "how to install" directions for it given it's not supported.
N.B. Jessie was EOL'd on June 6, 2018
Closes #3062

I just resolved the merge conflicts. We'll let this pass through CI again to make sure I didn't botch the conflict resolution.

I resolved another conflict.

Ugh this got messed up with other commit.

I'm going to redo this.


Create 'Settings' page

Settings page should consist of at least 3 rows:

Toggle sounds On/Off.
Change sound volume 0% - 100% (Should only be touchable when 1 is on).
Toggle flash On/Off.

Needs a big decoration.
Please sit with me @chai00xxdd


Only scans up to 30 ip addresses

For some reason scan is only checking the first 30 ip addresses on the subnet (x.x.x.1 - x.x.x.30).  My Pi is at (x.x.x.55), so is not found.
If I run razzmaster info --host x.x.x.55 the output looks correct.
I'm running ubuntu 14.04 on my PC.

Ah, it looks like this is the same as issue #2.  I tried editing find.js as suggested.  Scanning up to 100 was successful.  Scanning to 200 was not, it crashed with too many processes.

Yep. I need to rewrite this section. I can't just up it to 255 because of process limits so it will need to go in batches.


Trailing commas not allowed

Thanks for a great library! 😃
While playing around with this library today, I noticed that it returns an Unexpected token \"RBRACE\" error when it encounters a trailing comma, e.g.
{
  foo,
  bar,
  baz,
}

However, the GraphQL spec (§2.1.5) says that all commas should be insignificant, and trailing commas should be allowed.
I put together a gist to the issue: https://gist.github.com/bdchauvette/e84b9ff1925e58950a339783b8d093ae

Actually, even something like that should work:
{
  foo,   , , , , , , ,
  bar
  baz
}

§2.1.7 Quote:
Before and after every lexical token may be any amount of ignored tokens including [...]


Change bibliographicdate if technicaldate is changed.

Since 7.3 at the metadata Tab the Biographical date is shown.
This date is only changed when you edit the technical Date out of the Adminui(Scheduling-Tab).
But not within the Rest-APIs.
This Patch fixes this behaviour. The bibliographical date is always updated if the scheduling technical date is edited through the scheduler-service.

@CGreweling can you add/update the  junit to verify that changing the capture agent (spacial) without changing the start and end time updates the episode catalog Ok?

@CGreweling Unclear if this patch should resolve this, but testing a merge of this and #1122 exposed an issue where the scheduling data is inconsistent when changed from the admin ui's metadata page.
If I change the start and/or duration on the metadata page, it persists correctly, but does not(!) update the schedule.  The scheduling tab in the admin ui retains the original data (ie, matching the scheduling data retrieved from the calendar endpoint), while the metadata tab retains the changed data (ie, matching the changes which were just made).

@gregorydlogan Here begins the wired metadata things. I don't know if i unterstand your point correctly.
I was told, that the biographical Date (Schown on the matadata TAB), could be different to the techincal Date (Shown in the scheduling TAB). Exept the Scheduling Date is changed, than the bibiographical Date should be the same as the technical Date.
So if anybody can give me the right way, of handling these dates. I would add this to this patch. :)

@gregorydlogan & @CGreweling  Metadata start and technical start can be different AFTER ingest without impacting processes. But before ingest, if metadata/bibliographic start does not reflect the technical start, live published events are negatively impacted. The student might miss the technical start of the live event.
Our site prevents the user from changing the metadata's tab's start date and forces them to user the Scheduler tab to change the start date in the one location, to change both dates.

Since this is not changing the behaviour within the UI, but rather fixing a mismatch between what the UI does, and what the REST endpoints do, I'm going to merge this as is.


[Request] Less messages in chat

It would be nice if there was an option to have less messages in chat. The message that someone starts or stop concentrating aren't really necessary for my games at least. Would be nice if those could be turned off, as the concentration effect already shows if they are or aren't concentrating on something.
Also a thank you for your hard work so far for the community Zhell. Good Job 👍

Added in 10.1.2.


Consolidate Makefiles

Fixes #254
Proposed Changes

Move packaging -> build/
Modified creating-a-release.md common.mk path
Cancel .gitignore /build

Hi @zhangwt-cn Thank you for the PR!
Unfortunately, this is only a piece of the needed changes. We will also need to modify our Makefiles before we can introduce this change. Otherwise, our build output will still go to the build/ directory and be mixed together with the packaging folder.
I corrected the formatting on the original issue so that it is hopefully more clear. I'll leave this open and continue to review any additional changes you make. Thanks again for working on this!

Thank you for your reminder, I modified it. If there are any other problems, I will be happy to improve it.

Hey @zhangwt-cn,
Let's take a look at the Makefile in the project's root also. Looking at it I can see the following still:

Move/Remove the global variables at the top of the file so they are all in build/common.mk and shared throughout the project
Update the global variables so they are correct. i.e. PACKAGING_DIR should now point to the Makefile in build/packaging
Remove duplicate targets that already exist in build/packaging/Makefile. i.e. deb, rpm, cross-*, etc

Thanks!


Bug: improper codegen for varags + wrong calling convention

Which crate is this about?
windows, windows-sys
Crate version
0.33.0
Summary
Several windows SDK APIs expect varags.  However, equivalent generated rust fns lack any rest: ... parameters.  Additionally, despite said APIs being explicitly cdecl, they are marked as extern "system" (stdcall on 32-bit windows) in the generated Rust code, which is the wrong calling convention.  The difference between caller and callee stack cleanup should cause issues quickly.
A non-exhaustive list of concrete examples follows:
winsqlite3.h
// C:\Program Files (x86)\Windows Kits\10\Include\10.0.19041.0\um\winsqlite\winsqlite3.h
SQLITE_API int SQLITE_CDECL sqlite3_config(int, ...);
SQLITE_API int SQLITE_CDECL sqlite3_db_config(sqlite3*, int op, ...);
SQLITE_API char *SQLITE_CDECL sqlite3_mprintf(const char*,...);
SQLITE_API char *SQLITE_CDECL sqlite3_snprintf(int,char*,const char*, ...);
SQLITE_API int SQLITE_CDECL sqlite3_test_control(int op, ...);

https://github.com/microsoft/windows-rs/blob/32c7eea14faabd083f5d3e6f0f03530a38ba2113/crates/libs/windows/src/Windows/Win32/System/SqlLite/mod.rs#L2957-L2959
https://github.com/microsoft/windows-rs/blob/32c7eea14faabd083f5d3e6f0f03530a38ba2113/crates/libs/sys/src/Windows/Win32/System/SqlLite/mod.rs#L135
WinBer.h
// C:\Program Files (x86)\Windows Kits\10\Include\10.0.19041.0\um\WinBer.h
WINBERAPI INT BERAPI ber_printf( BerElement *pBerElement, _In_ PSTR fmt, ... );

https://github.com/microsoft/windows-rs/blob/74350264eab09bcb62cafe00c611efcc52725ff8/crates/libs/windows/src/Windows/Win32/Networking/Ldap/mod.rs#L1240-L1245
Rtutils.h
// C:\Program Files (x86)\Windows Kits\10\Include\10.0.19041.0\um\Rtutils.h
DWORD
__cdecl
TracePrintfW(
    IN  DWORD       dwTraceID,
    IN  LPCWSTR     lpszFormat,
    IN  ...         OPTIONAL
    );

DWORD
__cdecl
TracePrintfExW(
    IN  DWORD       dwTraceID,
    IN  DWORD       dwFlags,
    IN  LPCWSTR     lpszFormat,
    IN  ...         OPTIONAL
    );

https://docs.rs/windows-sys/0.33.0/windows_sys/Win32/NetworkManagement/NetManagement/fn.TracePrintfW.html
https://docs.rs/windows-sys/0.33.0/windows_sys/Win32/NetworkManagement/NetManagement/fn.TracePrintfExW.html

Ahh, found previous issues in win32metadata (was only searching this repository)

https://github.com/microsoft/win32metadata/issues/33
https://github.com/microsoft/win32metadata/issues/800

Yes, it looks like we could support such functions in Rust if the metadata actually supported them, which it does not at present.

Transferring this to the win32 metadata repo as there's nothing I can do to fix these functions until the metadata provides some hint about this.


first request documentation update

Current switch-based dart code gives error while adding provider as per the documentation.
It can be replaced with  .when( block.

As explained in the issue, the switch usage here is correct.
To begin with, the CI would fail if it didn't work :)


Create a proper controller to serve files.

So that the service middleware chain is used when handling serve file requests.

Fix #134


pekko 1.1

relates to #102

Pull Request Test Coverage Report for Build<PHONE_NUMBER>2
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 88.976%

Totals

Change from base Build<PHONE_NUMBER>2:
0.0%

Covered Lines:
113

Relevant Lines:
127

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>2
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 88.976%

Totals

Change from base Build<PHONE_NUMBER>2:
0.0%

Covered Lines:
113

Relevant Lines:
127

💛  - Coveralls

So I have deliberately pinned this project to use Pekko 1.0.x as to not accidentally use any new functions from Pekko 1.1.x, I am fine with leaving this up for testing but I am not going to merge it as unlike the other Pekko projects there is no benefit that this project will get from incrementing the version (inlining cannot happen because its not a core pekko project).


[RFC] OpenSearch.org search functionality

Tracking Issue: https://github.com/opensearch-project/OpenSearch/issues/696
Overview
We plan to introduce search capabilities for end user documentation, javadocs etc on opensearch.org . The current search functionality is based on client side lookup to local index file. We want to power this search functionality with an OpenSearch cluster (well, why not!) and provide a reference implementation so that other users can reuse it to power their own app search using OpenSearch.
We are looking for feedback and to discuss this potential solution.
Tenets

Opensource first. Users should be able to fork, customize, play and contribute to project.
Easy to setup and manage.

Requirements

Able to search using a simple search query.
Extensible  :  Should be able to support searching over different assets like blogs, webinars,  javadocs etc. besides documentation.
Granularity : User should have flexibility to search across multiple components (OpenSearch, OpenSearch Dashboards, plugins) or just a specific component, for e.g., search only Alerting plugin docs.
Fast : Should return results with low latency.
Availibilty : No downtime when upgrading the infra or changing configurations. Resilience against outages.
Consistent experience across geographies : The search experience should stay consistent across different geographies. Users from different geographic regions should experience same latency and results.
Security:

Search endpoint should be read only
Prevent users from running broad queries that can overload the cluster
Prevention against Denial of Service attacks - legitimate queries from users should go through while those from robots should be throttled and/or blocked

Monitoring: We need mechanism to monitor the health and functionality OpenSearch cluster, create alarms and take action based on those alarms to prevent any downtime and degradation
Deployment: Easily to scale the backend, upgrade to new OpenSearch versions
Analytics: Collect metrics on what the popular search queries are, what particular feature users are interested most
Other good to have requirements [optional]:

Auto-suggestion: Should support suggestions in real time as user is typing.
Keyword highlight in results

How would it work?

Search indexes will be built at website build time in the CI pipeline. This can be done for every commit or periodically at a given time.
The built indexes will be ingested into OpenSearch cluster.
The javascript code executing in the browser will interact with a  frontend that translates search query into DSL, queries OpenSearch with this DSL, fetches the results. The javascript renders the results for the user on webpage.

Proposed Architecture
A common way to create a search application with OpenSearch is to use web forms to send user queries to a server. Then you can authorize the server to call the OpenSearch APIs directly and have the server send requests to OpenSearch cluster.
We can write a client-side code that doesn't rely on a server, however, we should compensate for the security and performance risks. Allowing unsigned, public access to the OpenSearch APIs is inadvisable. Users might access unsecured endpoints or impact cluster performance through overly broad queries (or too many queries).  For example see #687 and #1078.
NOTE: We will be using AWS for infrastructure, but users are free to use other cloud providers that provide similar functionality or use self-hosted solutions.
Based on above requirements, we have come up with a minimal set of components to achieve the search functionality.

Components
1. OpenSearch cluster
The OpenSearch cluster will comprise of set of data nodes and master nodes each inside their own auto-scaling groups. The nodes will hosted on EC2. Auto-scaling groups (ASG) will prevent against node drops by replacing with a new node.
To prevent against availability zone outages (AZs), all nodes within an ASG will spread across at-least 3 AZs. This configuration atleast 3 data nodes and 3 master nodes.
A Network Load Balancer (NLB) will balance the incoming requests to data nodes and provides a single endpoint to access the cluster. All the resources will be created in a private subnet, and thus not reachable over internet.
2. AWS API Gateway

Allows for exposing different endpoints

Read only API for search with CORS enabled, obfuscates the OpenSearch endpoint (7.a)
Read/write API for indexing and perform cluster operations

Support for throttling (7.c)
Mitigation from DDoS by using Cloudfront distribution with WAF instead of using Edge optimized endpoint.
Provides useful API metrics : API call count, rate , latency etc.

3. AWS Lambda (for search)

Since we would be exposing a custom search API, we introduce a search AWS lambda function will act as a middleware that translates user search query to OpenSearch query DSL.
We can’t expose those credentials in the open on website pages via persistent web storage such as cookies. We also need a way inject scoped credentials to make search queries to OpenSearch. We would passing them as ENV variables to Lambda Function
Lambda has a cold start problem, to make searches with low-latency we plan to use Provisioned Concurrency to reduce initialization latency and make sure function is always hot.

4. AWS Lambda (for monitoring)
A monitoring Lambda function will allow us to continuously monitor the OpenSearch cluster for any problems like Red health, master issues, missing search indices, search sanity checks. This function will be triggered periodically by Cloudwatch Events (typically every minute) and emit Cloudwatch Metrics which we then be used to create Cloudwatch Alarms. The user can take appropriate action based on those alarms.
5. VPCLink
This feature allows us to map API Gateway endpoints to NLB and acts as a proxy. We use to this for ingestion/operations path. With HTTP Proxy Integration, API Gateway passes the entire request and response between the frontend and the backend.
6. Security, Authentication and Authorization
Security is the top-most priority. We will use OpenSearch security plugin to manage controlled access to cluster.
For initial implementation we will use Basic HTTP auth (username, password) based authentication. We will create individual users based on the below use cases that will be scoped to limited set of OpenSearch APIs using roles.
Since all the Lambda functions, NLB and nodes are in private subnet. We will be disabling HTTPS on security plugin.

Search (Read): For the search request/response flow no auth credentials will be passed from browser. To restrict what indices can be searched, basic HTTP auth credentials will injected into Lambda via environment variables. This user will be mapped to backend roles that is read only and limits to certain indices (AuthC). Rotating credentials for search will require updating them both on Lambda function and backend, which requires disrupting live traffic and not meet our availability goals. Credentials will be seldom rotated or not rotated at all.
Operations/Ingestion(Read/write) : A dedicated user for ingestion/operations. The credentials for this user will be rotated on a periodic basis.
Monitoring (Read): A user to probe cluster for health-checks. Credentials for this user will be seldom rotated or not rotated at all.

7. AWS Secrets Manager
We will use AWS Secrets Manager to create and rotate credentials. The credentials will be encrypted at rest using AWS KMS key. Only certain users can fetch those secrets with restricted IAM policies attached to that user.
Apart from security plugin credentials, we will store private keys to ssh data nodes and master nodes.
8. Logging
In order for the service team to properly monitor service for security and operational issues, and in order for security teams to investigate issues, logs  must be recorded and stored appropriately. Relevant logs should be built intentionally with security use cases - monitoring and investigations - in mind. Logs are both consumed by automation, and read by humans, and should address the needs of both.
Will will enable logging in the following places:

From
Where

API Gateway : Execution and access logs
Cloudwatch Logs

AWS Lambda (search and monitoring)
Cloudwatch Logs

NLB logs
S3 bucket

OpenSearch logs
Cloudwatch Logs

Audit logs on OpenSearch cluster using security plugin
Cloudwatch Logs

Security logs form bastion hosts (commands that are run)
Cloudwatch Logs

9. Bastion Hosts
For operations, users may require access to nodes. Since all the cluster nodes are in private subnet, we need bastion hosts to limit access to SSH port from restricted IP ranges (typically corporate VPN). This will be done by setting appropriate rules via Security Groups (SG).
We will create one bastion host in at-least three AZs to safeguard against AZ outages.
Artifacts
As a part of this implementation we will provide users with AWS CDK (infra as code) to spin up there own infra and other auxiliary tools to setup and manage that infra. This artifacts will hosted in a separate public Github repository. (Don't forget the tenets :wink: )
Future Enhancements

Client certificate based authentication instead of basic HTTP auth. The key problem to solve here is the PKI infra needed to create, sign and rotate certificates.
The OpenSearch cluster could be cross-region replicated using CCR plugin, offering CDN like experience for faster searches based on geographies. Alternatively, if not using CCR, we can choose to index multiple clusters during website build.

Shouldn't this RFC be in project-website

This design doc is a good example of deep dive. I have a couple of high-level comments/questions:

Can we weigh in the comparisons of using AWS Code Deploy?
Can we see if we want to deploy container based OS cluster instead of deploying it in vanilla EC2 instances? Containers require less memory management, as they consume fewer system resources and don't include OS images.
To provide the support for supervising the OS process on each node (container?), we might require a database which persists the status of the health check performed for each of the process. Also, maybe do you think we need a supervisor to do that kind of health checks on each node?

Shouldn't this RFC be in opensearch-project/project-website?

We generally get more eyeballs on this repo, and since I wanted this to be a reference implementation for opensearch, I wanted eyes that would be here on it :)  But happy to move it over in a bit, because you're right, that's where the rubber will hit the road.
Thanks!
/C

@CEHENKLE It's also being tracked on project-website #229. I understand the 'higher profile' but, to a degree, this sits between several repos.
From the perspective of someone trying to find or comment on it, I think it belongs in project-website or documentation-website.

Architecturally, this is pretty Amazon centric. For someone to recreate this service they would pretty much have to be on AWS. This seems to defeat tenet #1.
I think there is some very interesting things that are not in the diagram nor description. How do you get search queries to this search service? How do you take web pages and extract content from them for OpenSearch, etc.?
Also, am I correct that the only real code here lies in Lambda and the rest is configuration?

Architecturally, this is pretty Amazon centric. For someone to recreate this service they would pretty much have to be on AWS. This seems to defeat tenet #1.

This repository provides a lot of resources which use AWS resources to create and manage different products. If we add investment to this proposal and get it added to AWS, it will be another feather in the cap of Open Search.

Architecturally, this is pretty Amazon centric. For someone to recreate this service they would pretty much have to be on AWS. This seems to defeat tenet #1.

Opensource in #1 implies all the CDK code and other code artifacts to be public. Users are free to use other cloud providers that provide similar functionality or use self-hosted solutions.

How do you get search queries to this search service?

Clients (browser) uses the exposed search endpoint (provided by API Gateway) and renders results based on response from search service.

How do you take web pages and extract content from them for OpenSearch, etc.?

It is left to the user on how to extract content from their website and ingest to cluster(general idea). They can either crawl the web pages and extract content or directly use the content if they have the source.
We will be using the latter approach.
The project website is currently built via AWS CodePipeline. We have jekyll plugin that outputs a json with the docs . We plan to add another step in the pipeline which uses a Lambda function that takes json and bulk ingest to the  search service. This will be done on every commit on the repo branch we are tracking.

Also, am I correct that the only real code here lies in Lambda and the rest is configuration?

Mostly true.

I think there is some very interesting things that are not in the diagram nor description. How do you get search queries to this search service? How do you take web pages and extract content from them for OpenSearch, etc.?

Thanks @stockholmux . I will add more details/diagrams to showcase those parts.


Only report coverage metrics for unit tests

Summary
Limit collection of coverage metrics to unit tests only.
Details and comments
Agreed with team of key contributors (@rathishcholarajan, @kt474) team that we we want to start with coverage metrics for unit tests only.
This avoids that PR comments like this report decreased test coverage (because we compare the aggregated coverage of unit tests & integration tests (run for push events) against the coverage for unit tests only (run for pull_request events).

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
198 unchanged lines in 17 files lost coverage.
Overall coverage decreased (-5.7%) to 58.074%

Files with Coverage Reduction
New Missed Lines
%

qiskit_ibm_runtime/accounts/account.py
1
93.02%

qiskit_ibm_runtime/ibm_backend.py
1
60.0%

qiskit_ibm_runtime/runtime_program.py
1
88.68%

qiskit_ibm_runtime/api/auth.py
2
74.19%

qiskit_ibm_runtime/utils/backend_decoder.py
2
47.54%

qiskit_ibm_runtime/api/clients/base.py
4
88.03%

qiskit_ibm_runtime/utils/converters.py
6
18.97%

qiskit_ibm_runtime/api/rest/program_job.py
9
60.87%

qiskit_ibm_runtime/api/rest/cloud_backend.py
11
37.5%

qiskit_ibm_runtime/ibm_runtime_service.py
11
79.75%

Totals

Change from base Build<PHONE_NUMBER>:
-5.7%

Covered Lines:
2014

Relevant Lines:
3468

💛  - Coveralls


Jorge/assignment

Hi,
I was looking into the left guard. I am able to parse something of the form
term op &theory_name { ... }
where term is a term (not a theory_term) and op is a theory_op different from :-
I have a question regarding the creation of theory_atoms. They require a theory_term and not a term.
Is there anyway to create a theory_term from a term?
libgringo/tests/left_guard.py
contains a test using the python api

It is very important to me to keep the language clean and uniform. I will not accept a solution that involves a term as left guard and a theory term as right guard. I think that the language extension you are looking for requires a different parser. Something like https://github.com/taocpp/PEGTL might work. Changing the parser would be a quite bit of work. Furthermore, we need to ensure that it is fast enough; we have to ensure that it reads facts fast enough.
I was thinking to rewrite the input module of clingo at some point to provide a nicer API for working with ASTs. Then, I can have a look at parsing too. This is rather a long term project that requires some planning ahead. There is no plan to start right away.

Ok, a theory term on the left is a requirement requires infinite lookahead, so it seems that a new parser is needed.

Ok, a theory term on the left is a requirement requires infinite lookahead, so it seems that a new parser is needed. One can also use a two phase parser, but it seems less clean. For instance, that is the reason why python transition to PEG.

PEGs give more control at the expense of more backtracking. I like LR parsers so much because they only accept unambiguous grammars. I don't know of any other parser generator/library that offers this feature. It's the only approach that is fully declarative. :wink: Furthermore, the generated parsers are fast. I don't think that either point will be an issue for clingo. We have a large set of unit tests + a small performance hit should not matter. I'll look into this once I have a bit more time. Your feature request is stacked and I'll keep you in the loop. It still has to wait though.

You may find interesting the insights of the python transition from LL(1) to PEG. In particular, regarding performance, they say that "we find that the new parser is slightly faster but uses slightly (about 10%) more memory."
https://peps.python.org/pep-0617/

Funny, how they ruled out LR(1) at the end. As far as I know, it accepts a much larger class of grammars as compared to LL(1). I think they really did not like the tools. For example, we get left and right recursion without any fuzz. For clingo, memory consumption with PEG parsers should not be an issue. We just need a library that allows for marking backtrackable parts, which should be standard.

One thing that came to my surprise is how bad are both LL and LR algorithms at parsing something that as human is very natural. The problem we have in gringo with left guard is very similar to the problem of assignments mentioned in python. Humans understand infix notation very well and focus on the the infix connective first, while parses seem to have problems if the left part is complex.


barrel file moduleSuffix for type exports

When working with tsx I get issues with ESM interoperability due to the types not using explicity import paths. This PR fixes this and makes exports more consistent such that both types & implementations are exported with explicit moduleSuffix if specified.

Should I add a changeset. Please let me know if this PR is welcome.


steps 1-8 repeat

Information for steps 1-8 repeat

To see why the repeating part of the numbered list went undetected for so long, check out the numbered list (16 points) in

https://docs.microsoft.com/windows-server-essentials/migrate/migrate-windows-small-business-server-2003-to-windows-server-essentials

and remember that even if a numbered list in MarkDown contains numbers out of order, MarkDown will ignore the given numbers and show consecutive numbers as long as the list continues uninterrupted.

See also: #4082, #4083, #4084


Superusers are able to hijack any other user including superusers

Django-hijack's current implementation allows superusers to hijack any other user, including superusers.   This is an issue in some applications, where different superusers have access to different tables in django-admin (this could happen when a company's devops engineers have access to more tables than their regular engineers, but both still need superuser access).  In this case, a superuser with fewer permissions could hijack a superuser with more permissions and gain access to tables that they ordinarily should not have access to.

You could implement your own hijack function, see HIJACK_AUTHORIZATION_CHECK http://django-hijack.readthedocs.io/en/stable/configuration/#custom-authorization-function. There is an example as well.


i am facing the issue while building over ios

app loads successfully til splash screen after that above error comes in simulator

@Fredrik1234 A common solution for this is to uninstall/reinstall or update watchman
## Uninstall Watchman
npm r -g watchman

## Install Watchman via NPM
npm i -g watchman

## Install Watchman via Homebrew
brew install watchman


Wallet keep relocking

Hello,
Everytime I launch my wallet I see that staking is not possible because the wallet is locked. When I unlock it and close the wallet, it relocks automatically and the staking reshow "not possible".
How can I make sure that I'm staking while m wallet is closed (ex: pc offline).
Thanks for help

You cant. Staking requires that the wallet be online 24/7.
If you don't want to run your PC online for 24/7 i would suggest either sending your coins to a staking pool, or waiting until the web wallet is released.

Web wallet is released @tigeredo. You can close this issue.


Grunt giving problems with minimized file

For my projects i'm using grunt to build all javascript into one large file. However when i use bower install dexie it will use the minified source.
"main": "dist/latest/Dexie.min.js",

I would like to suggest to change this line (bower.json) into the not minified version.
My error when trying to build with grunt is:
Running "ngAnnotate:dist" (ngAnnotate) task
Generating ".tmp/concat/scripts/vendor.js" from ".tmp/concat/scripts/vendor.js"...ERROR
>> error: couldn't process source due to parse error
>> Line 43462: Unexpected token in
Warning: Task "ngAnnotate:dist" failed. Use --force to continue.

I have reproduced this error on an other dexie project.

This issue could be due to that the Dexie.min.js had a leading BOM in earlier versions which is removed since some versions now. Can I close this issue?

This seems to be fixed! thanks


Fix typos in flex.md

Task: task-[work-item-number]
Link: preview-[pull-request-number]
Fix typos in flex.md
align-xxx-flex-center -> align-xxx-center
align-xxx-flex-baseline -> align-xxx-baseline
align-xxx-flex-stretch -> align-xxx-stretch
align-content-flex-space-around -> align-content-space-around
align-content-flex-space-between -> align-content-space-between

Thanks for reviewing @wibjorn @homing1


Don't see code related to comments

https://github.com/ChornyiOleg/RubyHW/tree/master/HW8Comments/blog

What's on Heroku???

What's on Heroku???

I've pushed to Heroku, but didn't update correctly my push to Git)
Already resolved)


make did not build docker image by default Makefile

.PHONY: all
all: fmt lint build
https://github.com/intel/sriov-network-device-plugin/blob/master/Makefile#L49
All did not contain image building,make could not build docker image.

@xuguozhen make image should be able to build docker image, make only build the binary.

@zshi-redhat I think this is still the appropriate behaviour. Can we close this?


RPC serialization and its mutex locks and/or shared_ptr use are unclear and likely crash

The RPC mechanism has unclear use of locks to protect it and shared_ptr's to hold its resources. The current code in v2.21.2 is not consistent enough for me to infer the intent. Therefore, I ask for clarity in intention by showing the code that concerns me.
I can definitely miss something in my code review. Please do point out any mistakes I made.
Setup

all compilers, os, platforms
depthai-core and several versions earlier too

Code review
pimpl->rpcStream
I see no code that uses pimpl->rpcStream. Why does it exist?
https://github.com/luxonis/depthai-core/blob/125feb8c2e16ee4bf71b7873a7b990f1c5f17b18/src/device/DeviceBase.cpp#L625-L629

line 626 creates a shared_ptr<XLinkStream>
line 626 then assigns that shared_ptr to pimpl->rpcStream which no code will meaningfully use.
line 627 creates a new shared_ptr rpcStream and copy assigns pimpl->rpcStream to it. So now the XLinkStream has two (2) shared_ptrs pointing to it. Why do we need two?
line 629 lambda COPY captures rpcStream. So now there are three (3) shared_ptrs pointing to the XLinkStream.
auto rpcStream, the one outside the lambda, goes out of scope at the end of init2(). It had no purpose to exist.
pimpl->rpcStream is eventually set to nullptr in Device::close(). Nothing ever used it. It had no purpose to exist.

In addition to no purpose, having the extra 2 refs on the shared_ptr adds minor unneeded code and cpu use.
I suggest...

remove pimpl->rpcStream. I see no need for it.
merge line 626 and 627 to a single auto rpcStream = ...
change line 629 to be a move capture like rpcStream = std::move(rpcStream)
Could put the make_shared in the capture to eliminate the local if OK with a long/wrap capture. It will emplace construct rather than move.

pimpl->rpcMutex
pimpl->rpcMutex seems to be used to protect RPC activity. It is used only one place...
https://github.com/luxonis/depthai-core/blob/125feb8c2e16ee4bf71b7873a7b990f1c5f17b18/src/device/DeviceBase.cpp#L630-L632
Yet, the resources on which the RPC mechanism depends, like rpcStream and rpcClient are not protected by this mutex. Of most concern is the code in Device::close()...
https://github.com/luxonis/depthai-core/blob/125feb8c2e16ee4bf71b7873a7b990f1c5f17b18/src/device/DeviceBase.cpp#L429-L430
The intention to set both those to nullptr is unclear. What is it? Yes, something is related to above rpcStream discussion.
I'll explore rpcStream below. pimpl->rpcClient is tracked separately in issue #805

[this is what the code currently does] Release 1 refcount of shared ownership to the thing pimpl->rpcStream points.
Set the value of the thing pimpl->rpcStream points to nullptr or an empty XLinkStream...which doesn't exist as there is no default constructor for XLinkStream

I think the first (1) is useless. pimpl->rpcStream is used by no code. The pimpl->rpcClient lambda captured the XLinkStream itself. That lambda XLinkStream continues to live. pimpl->rpcStream = nullptr has no affect on its lifetime.
If we instead want to do the second (2)...which is impossible...then I would want to lock pimpl->rpcMutex and then set its value with *pimpl->rpcStream = XLinkStream(), and add code into the lambda to check+throw on invalid XLinkStream.
If we take a step-back and blur intention...there could also be a threading issue. Image two threads. And there is no predicting which thread is first, last, fastest, slowest, when each or both are paused in the middle, etc.
Thread 1
Calls a Device api which cascades to a call to the RPC lambda which contains the above mutex lock. The lambda then uses rpcStream to write and read data to/from XLink. Please note the lambda itself is contained within rpcClient.
Thread 2
Calls Device::close(). This function has code...
https://github.com/luxonis/depthai-core/blob/125feb8c2e16ee4bf71b7873a7b990f1c5f17b18/src/device/DeviceBase.cpp#L429-L430
What happens? 💣Nothing good. Maybe errors. Maybe a crash. Unpredictable. Why?....

Issue #805 crash scenrios (two so far I've identified)
Thread 1 needs a valid rpcStream value during the entire call of the lambda
Thread 2 sets rpcStream = nullptr with no coordination with the RPC lambda via rpcMutex. But what was the intention?
If the intention of Thread 2 was to somehow destruct the rpcStream that it used within the lambda, then this is dangerous withuot mutex coordination. The null/destruct could happen at the start of the lambda before the XLink write, or between the XLink write and XLink read.

In PR #809

Temporarily includes minor fixes to DeviceBase to fix the crash-after-close regression and to move RPC resources into the RPC lambda itself
TEST_CASE("Multiple devices created and destroyed in parallel") will readily show USB devices failing to successfully startup with 2 or 3 OAKs attached.

I am trying to discern the XLinkDeviceState_t of the USB devices at the moment of failure. Perhaps there is a clear pattern. It is reproducible now so hopefully I can bring more information so Luxonis can help on the device/firmware side of the issue.
My guess is that no-delay shutdown/reboot/boot/startpipe is failing sometimes due to timeouts/watchdogs. However, I have not eliminated the possibility of a bug in XLink with multithreaded client/host activity.


Fails to build due to old Firebase dependency

[!] CocoaPods could not find compatible versions for pod "Firebase/CoreOnly":
  In Podfile:
    ar_flutter_plugin (from `.symlinks/plugins/ar_flutter_plugin/ios`) was resolved to 0.6.2, which depends on
      ARCore/CloudAnchors (~> 1.32.0) was resolved to 1.32.0, which depends on
        ARCore/GARSession (= 1.32.0) was resolved to 1.32.0, which depends on
          Firebase/RemoteConfig (< 10.0, >= 8.0) was resolved to 8.0.0, which depends on
            Firebase/CoreOnly (= 8.0.0)

    firebase_core (from `.symlinks/plugins/firebase_core/ios`) was resolved to 2.14.0, which depends on
      Firebase/CoreOnly (= 10.10.0)

try making this change to ios/ar_flutter_plugin.podspec on line 23:
  s.dependency 'ARCore/CloudAnchors', '~> 1.38.0'
  s.platform = :ios, '15.0'


Rename non-renewable primary energy demand in output files

To be consistent with #301 and #306, the embodied, operational and mobility non-renewable primary energy demand in the corresponding csv output files need to be renamed as E_nre_pen, O_nre_pen and M_nre_pen, respectively.

https://github.com/architecture-building-systems/CEAforArcGIS/pull/317/files
In this pull request, the file operation.py is not changed. I think we didn't check the files after the merge and forgot to check in a file...
I am re-opening the issue.

Fixed this on pull request #328 . As soon as that goes through I'll close this issue.

please make sure the scenario plots also work with your changes.

is this issue done? #328 was merged. Can you check all the changes are now in master and the plots work? Then we can close this task!

Everything works fine. Closing the issue now.


Entering Chinese in the chat box will turn into a "?" symbol.

Describe the bug
In Monster Hunter Rise, Chinese-related Lua content is displayed normally, but Chinese characters cannot be entered in the chat box. Once entered, it will turn into a "?" symbol. Copying and pasting from an external source can be sent normally.
Upload logs and any crash dumps
None have.
Identify the REFramework version
REFramework2024.3.30 at https://www.nexusmods.com/monsterhunterrise/mods/26
To Reproduce
Steps to reproduce the behavior:

During the investigation, after deleting dinput8.dll, everything is back to normal.But there is no function and no joy.
Desktop and VR (please complete the following information):
Steam WHR, just use dinput8.dll
**
I know #457 ,But the problem is that you can’t input chat, which is a different problem from display.
and I know #496 too，the difference is that the input method drop-down list displays Chinese characters correctly, but after selecting the content you want to enter, the "?" symbol jumps to the input box.

re2_framework_log.zip
re2_fw_config.zip
If I can help, that would be great.


fix: update component workload tolerance and node affinity

Signed-off-by: qinyer<EMAIL_ADDRESS>
What type of PR is this?

/kind bug
What this PR does / why we need it:
The core component should be scheduled to the master node first, even if the node has a NoSchedule taint.
Compatible processing for each version of k8s.
Which issue(s) this PR fixes:

Fixes #
Special notes for reviewers:

Does this PR introduced a user-facing change?

Additional documentation, usage docs, etc.:

Codecov Report

Merging #520 (cc0f200) into master (da345b6) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #520   +/-   ##
=======================================
  Coverage   14.08%   14.08%
=======================================
  Files         124      124
  Lines       18086    18085    -1
=======================================
  Hits         2548     2548
+ Misses      15255    15254    -1
  Partials      283      283

Impacted Files
Coverage Δ

pkg/component/metallb/metallb.go
4.21% <0.00%> (+0.01%)
:arrow_up:

need to cherry-pick the release-1.3 branch

/lgtm
/approve
/cherrypick release-1.3


cpack x64 CI fix

Fixes #395 for good. Original proposal by @bhess.

Fixes #395 for good.

"For good" is a pretty strong guarantee. :)


[Feature request] Pass date to todoist for filtering

I'd like to be able to pass a date to Todoist to for use as a filter. Maybe this is somehow possible, but I haven't been able to figure it out if so.
The usecase is like this:

I have a @@TODOIST@@ tag in my daily note template for the purposes of pulling in the todoist task associated with the date of the note. However, this only works if I'm creating the note day-of.
Say the current date is 08/01/2022, but I need to create a future daily note for the purposes of placing some information there.
I create the daily note for future date 08/08/2022 on 08/01/2022.
The daily template fires, triggering the @@TODOIST@@ mention, which collects tasks for "today|overdue"
My 08/08/2022 note is embedded with tasks dated 08/01/2022.

Ideally, I would be able to tell the app to collect tasks from todoist with the filter "{{date}}|overdue", so a daily note created for a future date would call in the correct todo tasks automatically. (I tried this but it does not appear to work).
Alternatively, if there were an option to create a separate keyword that would prompt for a specific date on replacement, I could just delete the tasks from the wrong date and repopulate with the correct date in cases where that would be necessary.
Currently, it seems as though my only option would be to go into the settings of the plugin, create a unique keyword and unique filter hardcoded with the desired date if I want to pull in tasks from an arbitrary date. Maybe I'm wrong about this though!

Todoist filters support multiple ways of pulling tasks from dates. For instance, here is one of my filters for planning (next 14 days &!@routine*).
According to the Todoist docs, here are the currently supported ways of filtering by dates:

Specific date: 10/5/2022, Oct 5th 2022
Specific date and time: 10/5/2022 5pm, Oct 5th 5pm
Relative date: today, tomorrow, yesterday, 3 days (due in the next 3 days), -3 days (due in the past 3 days)
Days of the week: Monday, Tuesday, Sunday

None of these quite fit your specific use case, but days of the week may work as a work around for your use case.
For instance, you could make a tag for each day of the week, ie @@Monday@@ which pulls in tasks for Monday, but this would only work for pulling tasks for the next Monday if the current day is not Monday. The good news is that I tested next monday, and that does work for pulling the data from the following week, which means this isn't limited to just 6 days in the future. However, it does still have a limitation of only allowing you to pull up to 13 days in the future.


Updated go 1.17 -> 1.18 in template.yml

Description
I updated go 1.17 to 1.18 in template.yml. This is extremely minor, but I was really confused when I first saw the template.yml message and started looking for the right branch or git repo with 1.18, since I depend on generics.
How Has This Been Tested?

No changes to testing.
How are existing users impacted? What migration steps/scripts do we need?
They get up-to-date docs
Checklist:
I have:

[x] updated the documentation and/or roadmap (if required)
[x] read the CONTRIBUTION guide
[x] signed-off my commits with git commit -s
[x] added unit tests

That bot was... surprisingly helpful. I've now signed off on the change.

Hi @Koeng101
Thanks for reporting and fixing this. I also updated the other template in this repo.
Your changes are in #80.
Regards
Han


Add encryption & protection flags support

There is a reasonable description of this available at https://www.cs.cmu.edu/~dst/Adobe/Gallery/anon21jul01-pdf-encryption.txt and https://www.cs.cmu.edu/~dst/Adobe/Gallery/
Some further details are available at https://github.com/pdfcpu/pdfcpu

There is a sample encrypted file available from https://johnaugust.com/2014/try-to-open-this-pdf
And a discussion of opening/cracking it (including the code) at https://blog.didierstevens.com/2017/12/26/cracking-encrypted-pdfs-part-1/


Document changes to UserGrant structure

Documents the new UserGrant scheme that uses null/read_only/read_write
permission levels for all entity classes.

Coverage remained the same at 71.27% when pulling 425856c4113a9a57517bf7844ae79f07cfedb3b3 on Dorthu:feature/rework-grants into a8c4b2ed50ecc749a0ae3853b993053c44f79a5b on linode:pending-docs-updates.


Ref #3088: Split JSON dataformats test

Fixes #3088

@ldrozdo Many thanks for stepping in :+1: Help is very much appreciated :smiley:
This PR adds value by further insulating data format tests.
Do you think they could be even more isolated with having each data format in their own maven project ?
So for instance, we would be sure that a given data format is not covering bugs from another one...

Oh, sorry for not being clear enough in the issue description. The objective is indeed the one @aldettinger mentioned above: to split the current integration-tests/dataformats-json Maven module into as many Maven modules as we have Json dataformats. We already have something similar for compression, AWS and others. The concept is described in our developer docs: https://github.com/apache/camel-quarkus/tree/main/integration-test-groups/aws2 Please do not hesitate to ask (or improve the above docs section) if there is something unclear.

This pr is already a good first step in this direction. I would merge this one and then we could have other prs following maybe.

Hi @ppalaga and @aldettinger, sorry, I thought that I understood the issue description well and I didn't :smiley:  I will check the examples and I will implement it according to them. If you want to merge this one it's ok with me. Thanks for you help and explanation :) I will ask if something is unclear.

Ok, let's merge this one then. To further insulate tests the aws2-grouped way, one may need to copy the JsonBaseTest logic in all modules, or maybe create something like a camel-quarkus-integration-tests-support-json.


Packages and plugin IDs should reflect the Play framework hosting domain

The URL of the Play framework is https://www.playframework.com/. Packages and plugin IDs should reflect that: com.playframework will be used.

Sounds good to me. I've sent an email to Lightbend regarding usage of com.playframework.

I made the change to get it out of the way.

This LGTM, do we just need to block this until we hear back?

// TODO: Will require adjusting the publishing information in build.gradle.kts.
pluginBundle {
    website = "https://www.playframework.com/"
    vcsUrl = "https://github.com/gradle/play"
}

We decided to go with org.gradle.

@pioterj I was looking at the proposed prefix a little closer. I don't think we'll be able to use it...at least for the plugin ID. The reason is that you can omit org.gradle when applying standard Gradle plugins.
For example:
plugins {
    id 'play'
}

and
plugins {
    id 'org.gradle.play'
}

are pointing to the same plugin. If we'd go with the proposed plugin ID then we'd have a naming conflict. We'll need to come up with a (maybe just slightly) different solution. Potentially something like org.gradle.community.play could work.

It was decided to go with org.gradle.playframework to ensure a unique plugin ID pattern.

Implementation: https://github.com/gradle/play/commit/423796bbc15d278fc8710331e48de1c8287ddb06


feat: move network component into mempool infra and add a communicati…

…on interface trait

This change is

Codecov Report
Attention: Patch coverage is 83.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 52.91%. Comparing base (2acb88e) to head (55f1ef9).

Files
Patch %
Lines

crates/mempool_infra/src/network_component.rs
83.33%
0 Missing and 2 partials :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
+ Coverage   52.33%   52.91%   +0.57%
==========================================
  Files          12       12
  Lines         386      395       +9
  Branches      386      395       +9
==========================================
+ Hits          202      209       +7
  Misses        178      178
- Partials        6        8       +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


warnings

Hi there!  I really like your colorization model.  I'm using it on old images and I think it works better than the other currently available options, except sometimes red color is too strong.  When I run it as python script I get a couple of warnings I want to ask if there are any ways to avoid these warnings thanks!
2024-03-15 17:43:21,771 - modelscope - INFO - PyTorch version 2.2.1+rocm5.7 Found.
2024-03-15 17:43:21,797 - modelscope - INFO - Loading ast index from /home/rubing/.cache/modelscope/ast_indexer
2024-03-15 17:43:21,824 - modelscope - INFO - Loading done! Current index file version is 1.13.1, with md5 bf5a0cac5e5265c888d1b6453711fc56 and a total number of 972 components indexed
2024-03-15 17:43:25,009 - modelscope - WARNING - Model revision not specified, use revision: v1.02
2024-03-15 17:43:25,743 - modelscope - INFO - initiate model from /home/rubing/.cache/modelscope/hub/damo/cv_ddcolor_image-colorization
2024-03-15 17:43:25,745 - modelscope - INFO - initiate model from location /home/rubing/.cache/modelscope/hub/damo/cv_ddcolor_image-colorization.
2024-03-15 17:43:25,748 - modelscope - INFO - initialize model from /home/rubing/.cache/modelscope/hub/damo/cv_ddcolor_image-colorization
2024-03-15 17:43:29,373 - modelscope - INFO - Loading DDColor model from /home/rubing/.cache/modelscope/hub/damo/cv_ddcolor_image-colorization/pytorch_model.pt, with param key: [params].
2024-03-15 17:43:29,658 - modelscope - INFO - load model done.
2024-03-15 17:43:29,737 - modelscope - WARNING - No preprocessor field found in cfg.
2024-03-15 17:43:29,779 - modelscope - WARNING - No val key and type key found in preprocessor domain of configuration.json file.
2024-03-15 17:43:29,781 - modelscope - WARNING - Cannot find available config to build preprocessor at mode inference, current config: {'model_dir': '/home/rubing/.cache/modelscope/hub/damo/cv_ddcolor_image-colorization'}. trying to build by task and model information.
2024-03-15 17:43:29,782 - modelscope - WARNING - No preprocessor key ('ddcolor', 'image-colorization') found in PREPROCESSOR_MAP, skip building preprocessor.
2024-03-15 17:43:29,785 - modelscope - INFO - load model done

你好，感谢喜欢我们的工作！如果想要避免运行时的这些警告，你可以通过本地推理或者使用 HuggingFace 推理，这样就不会

Hello, thanks for liking our work!
To avoid these warnings, you can run the model through inference locally or inference with HuggingFace.
Also, regarding the color preference of coloring, try the different models here to see if they work better in specific scenarios.


vjp, jvp, grad, and value_and_grad don't take closure that returns Result<_, Exception>

Resolved in #116


SignatureError raised because client.new_preauthorization_url uses more url params when generating signiture

I am trying to "confirm a new pre-auth" in sandbox.
I generate a url using gocardless.client.new_pre_authorization_url, then I am confirming with gocardless.client.confirm_resource when the user clicks the form submit button.
More specifically, I am doing the following:
       # generate the link
        return gocardless.client.new_pre_authorization_url(
            max_amount=1000.00,
            interval_length=1,
            interval_unit='month',
            name='A Name',
            state=user.id,
            calendar_intervals=True,
            user={
                'first_name': user.first_name,
                'last_name': user.last_name,
                'company_name': self.name,
                'email': user.email
            }
        )

This creates a url to give to the user that links to a nice pre-populated form. So far so good.
However, on confirmation the problem start:
        # confirming
        gocardless.client.confirm_resource(request.GET.dict())

At this point the gocardless library raises SignatureError("Invalid signature when confirming resource") here
I see that new_pre_authorization_url generates the hmac signature using more of the url params than are used by confirm_resource:
# params used by new_pre_authorization_url [here](https://github.com/gocardless/gocardless-python/blob/master/gocardless/urlbuilder.py#L152)
{
    'client_id': <client_id>,
     'nonce': <nonce>,
     'pre_authorization': {
         'calendar_intervals': True,
         'interval_length': 1,
         'interval_unit': 'month',
         'max_amount': 1000.0,
         'merchant_id': '<merchant id>',
         'name': 'Monofox Ask Peers',
         'user': {
             'company_name': u'A Name',
             'email'<EMAIL_ADDRESS>             'first_name': u'jimmy',
             'last_name': u'jam'
         }
     },
     'state': 13L,
     'timestamp': '2015-05-28T18:50:05Z'
}

whereas when we confirm the pre auth
# params used by `confirm_resource` [here](https://github.com/gocardless/gocardless-python/blob/master/gocardless/client.py#L332)
    {
        u'state': u'13'
        u'resource_uri': u'https://sandbox.gocardless.com/api/v1/pre_authorizations/<merchant id>',
        u'resource_type': u'pre_authorization',
        u'resource_id': u'<resource id>'
    }

When these params are each passed to hmac.new here, of course they will return different signitures.
The params payload passed to hmac.new are so vastly different that this makes me think I might be using the api incorrectly?

Hi @richtier!,
The params are meant to be different here - you generate one signature in new_pre_authorization_url which we use to check the link hasn't been manipulated, and then we generate a new signature for the return parameters (state, resource_uri, resource_type, and resource_id) so that you can verify that this customer really completed our payment pages.
It looks like you're using the right parameters, so the SignatureError most likely indicates that the library wasn't initialised correctly. At the point where you're calling confirm_resource, check that  gocardless.environment and gocardless.set_details are configured in exactly the same way as they were when generating the link and you should find that it confirms without errors.
If you're still having issues, just send over the resource ID you're trying to confirm to<EMAIL_ADDRESS>and we'll help you to debug!


run with python version 3.10, get issue.

thanks for your code, but i think some issue from my end, suppose the JSON part can't parse
My code :
privkey = seed_to_privkey(seed, path="m/44'/118'/0'/0/0")
tx = Transaction(
    privkey=privkey,
    account_num=account_number,
    sequence=1,
    fee=0,
    gas=80000,
    memo="",
    sync_mode='BROADCAST_MODE_SYNC',
    chain_id='korellia'
)
tx.add_transfer(
    recipient="kyve13nwxn4tuszwk6s93vk73xxe6xwf3ssauk5hhde", amount=10000
)
pushable_tx= tx.get_pushable()

api_base_url = "https://api.korellia.kyve.network"
headers = {'content-type': 'application/json'}
result = requests.post(api_base_url + "/cosmos/tx/v1beta1/txs", data=pushable_tx, proxies=proxies,headers=headers)
print(result.status_code, result.text)

The result :
400 {
  "code": 3,
  "message": "invalid empty tx",
  "details": [
  ]
}

the Json print:
{
  "tx": {
    "msg": [
      {
        "type": "cosmos-sdk/MsgSend",
        "value": {
          "from_address": "kyve1t5jjcj9terudp8serzcrsud86zgq8ad5zxxxx",
          "to_address": "kyve13nwxn4tuszwk6s93vk73xxe6xwf3ssaukxxxx",
          "amount": [
            {
              "denom": "uatom",
              "amount": "10000"
            }
          ]
        }
      }
    ],
    "fee": {
      "gas": "80000",
      "amount": [
        {
          "denom": "uatom",
          "amount": "0"
        }
      ]
    },
    "memo": "",
    "signatures": [
      {
        "signature": "yZ1Muoe1fQTdwD9wM56hs0mCJEO6S9sxDPEQaCxuL/ZF86zXRqlXMaip0wyKPh1isghjsichoUVoJPLN+KYHTA==",
        "pub_key": {
          "type": "tendermint/PubKeySecp256k1",
          "value": "A38+HgWr2p+qRCvMRuAMwNw6S3gdcGOoprByctGzqhrv"
        },
        "account_number": "26553",
        "sequence": "1"
      }
    ]
  },
  "mode": "BROADCAST_MODE_SYNC"
}

There has been some fundamental changes in how the transaction needs to be submitted. That's why the current version isn't working anymore.
#32 is currently the pr for a fix. You could install it directly from the branch if you want or wait until it's completed and merged

Thanks a lot,  The first transfer transaciton already on chain,
and one more query, #32 will include below delegate related support ?
{
  "txBody": {
    "messages": [
      {
        "type_url": "/kyve.registry.v1beta1.MsgDelegatePool",
        "value": "CitreXZlMTNud3huNHR1c3p3azZzOTN2azczeHhlNnh3ZjNzc2F1azVoaGRlEAAaK2t5dmUxYWVuZjhoODYzZGY4eGFxMmFobjZ5bDR4ZTA3dWwzcTA5ZjM2NzMggJTr3AM="
      }
    ],
    "memo": "",
    "timeoutHeight": "0",
    "extensionOptions": [],
    "nonCriticalExtensionOptions": []
  },
  "authInfo": {
    "signerInfos": [
      {
        "publicKey": {
          "typeUrl": "/cosmos.crypto.secp256k1.PubKey",
          "value": "CiED3/YCpuxOCZWLCbryNINRhy4ccbQaIFTeavu+Exhq+4E="
        },
        "modeInfo": {
          "single": {
            "mode": "SIGN_MODE_DIRECT"
          }
        },
        "sequence": "170"
      }
    ],
    "fee": {
      "amount": [
        {
          "denom": "tkyve",
          "amount": "0"
        }
      ],
      "gasLimit": "458845",
      "payer": "",
      "granter": ""
    }
  },
  "chainId": "korellia",
  "accountNumber": "11647"
}

thanks again.


create gitter channel and put link in readme

Closing via https://github.com/Capgemini/mesos-ui/pull/34


chore(ci): update kernel-testing related matrix comment if already existent

What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area CI
Does this PR require a change in the driver versions?
What this PR does / why we need it:
Same as #2017 for kernel testing create comment workflow.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/milestone 0.18.0

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Change LoggingThreadPool to run actions that take a state argument

Right now it only runs Action, we should run Action<T> to prevent creating closures in places like https://github.com/aspnet/KestrelHttpServer/blob/7b6384635796d99bdb74ba24d80dbdc50731fd5e/src/Microsoft.AspNetCore.Server.Kestrel/Http/Connection.cs#L157

Issue is it already takes a object as parameter which is the logger :cry:

I'm thinking of closing this. Not worth the time investment. The closure is not created on a critical code path so there's no perf impact.
cc @muratg @halter73 @mikeharder @davidfowl

Sounds fine to me

:+1:

ofc could always have an event on the threadpool that could be listened to rather than crashing the process, then it would free up the slot https://github.com/dotnet/coreclr/issues/2144


Change listener not being called when new data is inserted

What happened?
I have established a listener to identify any modifications within a collection. The listener is activated when updates or deletions occur on existing models, however, it does not respond to the insertion of new data.
Repro steps

Create a model then run build_runner

@RealmModel()
class _UploadMetadataModel {

  @PrimaryKey()
  late ObjectId id;
  late String sourceFilePath;
  late String targetFilePath;
  late String uploadStatus;
}

Create a Realm instance

final realm = Realm(Configuration.local([UploadMetadataModel.schema]))

Add a change listener for the UploadMetadata collection

realm.all<UploadMetadataModel>().changes.listen((event) {
   // Expect to receive newly inserted upload metadata model
});

Insert new UploadMetadata in realm

 realm.write(() => realm.add(uploadMetadata));

Unfortunately, Step 4 does not trigger the change listener
Version
Dart 2.19.2/Flutter 3.7.3
What Atlas Services are you using?
Local Database only
What type of application is this?
Flutter Application
Client OS and version
Android 13
Code snippets
No response
Stacktrace of the exception/crash you're getting
No response
Relevant log output
No response

Hi @DominicOrga, thanks for reporting!
Your code looks absolutely correct. Can you try adding some small delay after subscribing to the changes and before the writing?
You can see how it is written in our tests
I hope this will help!

Hey @desistefanova , making the Realm setup asynchronous seems to have done the trick.
Thanks! I'll close this issue now.

Hey @desistefanova , making the Realm setup asynchronous seems to have done the trick. Thanks! I'll close this issue now.

@DominicOrga How to setup async?


feat: table: update table hover color, fix accordion hover overflow

SUMMARY:
feat: table: update table hover color, fix accordion hover overflow
GITHUB ISSUE (Open Source Contributors)
JIRA TASK (Eightfold Employees Only):
CHANGE TYPE:

[ ] Bugfix Pull Request
[ ] Feature Pull Request

TEST COVERAGE:

[ ] Tests for this change already exist
[ ] I have added unittests for this change

TEST PLAN:

Codecov Report

:exclamation: No coverage uploaded for pull request base (main-next@e60dc56). Click here to learn what that means.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             main-next     #255   +/-   ##
============================================
  Coverage             ?   88.37%
============================================
  Files                ?      384
  Lines                ?    10323
  Branches             ?     3453
============================================
  Hits                 ?     9123
  Misses               ?     1180
  Partials             ?       20

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e60dc56...048d40d. Read the comment docs.


Feature Request

Hi there, i just want to Request a Feature : Intranet
I want the posibility to make the server and not have any problem to start server and connect the clients to that specific server ip.
Because i had days trying to connect in intranet the "Ephinea" offline server, but looks like are make to not work on internet mode, just SinglePlayer or Internet mode.
If possible you can add a mini tool to change the ip the client of phantasy star blue burst is connecting because i had make Hexadecimal edition just for change the ip of the target server.
Well that's is all , thank you for read

For that you just have to set the right (internal) IP address, the one given to the computer hosting the server by the router.
Changing the IP address of the client is out of the scope for this repo.
We have another repo which is for changes in the client performed via an "injected" DLL
https://github.com/Solybum/Blue-Burst-Patch-Project
Although that project is still a work in progress, eventually that will help you do that.

Thank you very much, i had download Tethealla Server, and config manually the ip and works fine. thank for that tool :D


Github pages dont find params image

The site https://romainguarinoni.github.io/mastermind/ sever can't render the wheel png for the params

https://webpack.js.org/plugins/copy-webpack-plugin/


admonition-panels seem to no longer exist

https://github.com/Zyrohex/admonition-panels

Can confirmed

Seems like the author had deleted the repo.

close https://github.com/logseq/marketplace/commit/b3201f7e2c8c5cd5913ef044877510ff39630b27


[LLVM] Update to llvm-project@1f20eee6dc367bd202895e3eedb03974a628ef16

This pulls in the AMDGPU backend support for the gfx950 target.

@zhanglx13 @antiagainst @sjw36
This is related to https://github.com/triton-lang/triton/pull/5281 though it doesn't break without this.

We need to send a pull request to update llvm-head branch's hash first to trigger building llvm package for downloading. See https://github.com/triton-lang/triton/pull/5179 and https://github.com/triton-lang/triton/pull/5180.

We need to send a pull request to update llvm-head branch's hash first to trigger building llvm package for downloading. See #5179 and #5180.

Thanks, I misunderstood it.


[metadata] Add dump to Metadata.

We dump the following information:

The Kind.
Pointer to the value witnesses.
Pointer to the class object if one is available.
Pointer the type context description if one is available.
Pointer to the generic arguments if one is available.

This makes it significantly easier to poke around Metadata.
rdar://34222540

@swift-ci smoke test and merge


[rmf_traffic_schedule] Failed to correctly load participant registry: yaml-cpp

This is a known issue but documenting it as it has been hard to get a .rmf_schedule_node.yaml file from others who reported this error. I've attached the file as a .txt in this ticket.
Steps:
Did a clean source build after pulling in the latest main from all repos but I did not purge the old .rmf_schedule_node.yaml file. This following error gets thrown when launching a demo.
The solution is to delete the .rmf_schedule_node.yaml file from the active directory in the terminal that launched the demo.
[rmf_traffic_schedule-1] [FATAL] [1664934417.785397476] [rmf_traffic_schedule_primary]: Failed to correctly load participant registry: yaml-cpp: error at line 9, column 16: bad conversion
[rmf_traffic_schedule-1]
[rmf_traffic_schedule-1] terminate called after throwing an instance of 'std::exception'
[rmf_traffic_schedule-1]   what():  std::exception

rmf_schedule_node.txt

This problem was plaguing me, and not entirely sure why, I "solved" it by deleting the build/install dirs and using gcc instead of clang for a compiler; not entire sure why that worked, or if the second step was necessary.


Order PCB

Hi, did you plan an other batch of PCB, i see that nothing is available to order from your website ? Or did you plan to make the PCB layout opensource ?
Bests, thanks for the amaizing work

Hey, yes nothing is available at the moment because I am still working on the new version of the main board, then I will be selling the PCB and panels as I was before with the first version. So the first version is not going to be available anymore to focus only on v2.

Thanks for your work

Hey, so you know, the project enters a beta testing phase, so hopefully v2 is available soon.


JAWS React Front-End Module: Design Specs & Help Wanted

This thread is for discussing the JAWS-site-react module's design and finding developers who want to help build it
Overall, JAWS should support all front-end frameworks.  There has been a lot of demand for JAWS + React support.  So, let's start with React!
JAWS already comes with a site module.  But you should be able to swap this out with another site module that is focused on a specific front-end framework.  So, I'm proposing a new JAWS-site-react module/repo, which will contain JAWS + React boilerplate.  Here are some design considerations:

Keep It Simple:  There should be little bloat in this module.  This module is for convenience, not strong opinions and obscure React patterns.  Make it the best possible starting point for a React project, that is all.

Make It Extendable  While this module is meant for convenience, there should be some mechanism for plugging in other JAWS + React modules.  There have been lots of requests to do AWS stuff without API Gateway, since many tasks can be accomplished by using the AWS JS SDK in the browser to interact directly with AWS services.  For example, a JAWS-site-react-s3-upload module would be incredibly useful and fast since it would upload from the browser, directly to S3.  This module needs to also contain config files for the AWS Browser JS SDK and make them accessible to other JAWS + React modules.

Integrate With JAWS REST API  JAWS will have Swagger integration finished soon.  There should be some service that allows you easily interact with your JAWS REST API.  Keeping this simple again is key.  Perhaps we can get the JAWS-cli to automatically scaffold this for you based on your Swagger JSON.

These are just my opinions.  Please contribute your thoughts/ideas/advice.  Also, I'm not a great React developer, so I'm looking for some better people to take the lead on this.  If you'd like to do that, please say so here :)

Add me to this list

@ac360 I'm definitely interested. I think site should be where all complied FE modules live so that the cli can have a simpler time of deploying the FE assets.
Have you thought much about how basic you want these modules to be? Are we talking a simple set of entry point files, are we talking a fully fledged build system?

@ac360 My first idea was to build an opinionated example with some of the battle tested tools like Gulp, JQuery, Moment, Lodash, JSPM, Mocha and so on... But after read your post, I thought about it and finally I agree with you. We have to keep it most simple as possible in order to the futur adopters don't have to learn an other tool than the tool which they are interested (JAWS + React in this case).
However, about extensibility, I reminds that React is a framework for View only, and is not supposed to be responsible for the calls to the backend. So, if we want build an example simple and clean too I think, we will need a structuration framework (Reflux for example or an other).

opening pandora's box with flux implementation @mbreton lol this is where the real debate starts,
@ac360 made a great comment about "Currently, I think JAWS should support multiple front-end frameworks, and each should have their own repo within the JAWS organization"
utilizing modules is the way to go under the jaws organization. I think for demo purposes simple hello with basic routes implemented, but if other maintiners want to add addional modules with implementation I think that is under consideration :), that way we have the freedom to implement any bleeding edge technologies modules with various implementations, add that my vote +1

Just finished a poc react ssr jaws demo.
Currently it is using api gateway tied to a lambda to render markup react side.
If you have react inspector installed you'll notice that the html head and body elements are all actually react components rendered server side and bootstrapped on the client.
The build pipeline is explained in more detail over at jaws-stack/JAWS-cli/issues/9
Here is the live demo
Here is the source if anyone is looking for inspiration
It uses the same IAM and .env config as JAWS.

Update 8/13/15:
We’re currently working on a document that outlines the specifications for JAWS v1.0.0.
A proposed resolution to this issue in particular is included in that document.
Today or tomorrow, we will share the document for everyone to comment on because your feedback is essential.

Outdated


Add aria and stately docs for numberfield

Any ideas for handling this?
next line seems poor, hard to see the association
making it wider seems bad as well, what if something longer comes along
making the badge smaller is also counter to what we want, it'd be less visible
maybe same size with just A in it and an aria-label of alpha?

Any ideas for handling this?
next line seems poor, hard to see the association
making it wider seems bad as well, what if something longer comes along
making the badge smaller is also counter to what we want, it'd be less visible
maybe same size with just A in it and an aria-label of alpha?

oh weird I don't see that locally... did you bump up the font size or something?

oh weird I don't see that locally... did you bump up the font size or something?

Just double checked, i have it zoomed at 100%

Just double checked, i have it zoomed at 100%

Ah, figured out why i'm seeing that Alpha tag issue, I have scrollbars on because of my external mouse


Select Stage Dependencies with Selectors

Checklist

[X] I've searched the issue queue to verify this is not a duplicate feature request.
[X] I've pasted the output of kargo version, if applicable.
[X] I've pasted logs, if applicable.

Proposed Feature
Allow Stage dependencies (spec.requestedFreight[].sources.stages) to be selected by selector (labels or something similar) allowing for dynamic stage dependency mapping.
Motivation
I aim to replace my usage of AppSet Progressive Syncs with Kargo to manage and maintain our cluster addons. To achieve this simplistically, each cluster is either marked as dev, stage or prod. These clusters are automatically generated as a Kargo Stages through an AppSet with Cluster generator (pending #339). My clusters are dynamic and may change, but I want to enforce my stage dependencies automatically.
Right now my stage dependencies are set manually as this is a static list of known stages.
Suggested Implementation
Being able to use a labelSelector (or similar) allows me to label stages with the environment and have them automatically map the dependencies. Whilst #339 states dependency mappings, I feel this is a smaller change and something that could provide value whilst the full StageSet implementation is designed out.

cc @jessesuen in relation to our chat at Kubecon - thank you for your time!

Today, we support explicit references:
  requestedFreight:
    - origin:
        kind: Warehouse
        name: guestbook
      sources:
        direct: false
        stages:
          - ab-test-a
          - ab-test-b

The proposal is to support something like:
  requestedFreight:
    - origin:
        kind: Warehouse
        name: guestbook
      sources:
        direct: false
        selector:
          matchLabels:
            env: preprod


Provide File object on mounted event

I am trying to provide ImageUploader's component a javascript File object on my template mounted event.
My first try was to access with vanillajs using document.getElementById('inputfile').value = myFile but then I receive a warning from vue about accessing/using an asset no longer available.
Looking at ImageUploader.vue source code, it doesn't seams like there is a way to achieve such thing.
One similiar behaviour I could see in a similar project (thinking about vue-picture-input) is the use of a prefill function:

prefill: (image url or File object, optional) use this to specify the path to a default image (or a File object) to prefill the input with. Default value: empty.

I might be missing something obvious, but could propose a PR if no options yet.

Hi. You're right, I don't think this would currently be possibly, but the functionality seems reasonable. And the props-solution you referenced a good way to go about it.  Unfortunately I don't have time for the next month or so to do anything myself, but please feel free to open a PR.
Cheers

I came up with a way to construct the file object from the image for upload.
uploadImage () {
      var vm = this
      vm.saving = true
      fetch(vm.image.dataUrl)
        .then((res) => { return res.arrayBuffer() })
        .then((buf) => { return new File([ buf ], vm.image.info.name, { type: vm.image.type }) })
        .then((file) => {
          return this.$store.dispatch('profileImage/upload', file)
            .then(() => {
              vm.showModal = false
              vm.image = null
              vm.hasImage = false
            })
        })
        .catch((e) => {
          console.log(e)
        })
        .finally(() => {
          vm.saving = false
        })
    }


[Feature proposal] Android intent arguments

Hello dear Koin users,
I was talking to people using Koin, about setProperty to help set a Koin property in your app. But an overuse of this feature can lead to putting all your arguments data between activities/fragments in Koin properties, whereas we should respect the Android approach: keep argument data in intents.
I would like to give some "Android extra" help on intent, to help set up arguments on Android and avoid misuse with Koin properties.
I propose a startActivity and withArguments :
startActivity<WeatherDetailActivity> {
            withArguments(
                    PROPERTY_WEATHER_DATE to date,
                    PROPERTY_ADDRESS to address,
                    PROPERTY_WEATHER_ITEM_ID to id)
        }

and on receiving activity or fragment, argument binding:
class WeatherDetailActivity : AppCompatActivity() {

    // Get all needed data
    val address by argument<String>(PROPERTY_ADDRESS)
    val now by argument<Date>(PROPERTY_WEATHER_DATE)
    val id by argument<String>(PROPERTY_WEATHER_ITEM_ID)

This will bind those properties with the underlying intent. This feature is sort of borderline with Koin goals, but I think we are still in "assembling" components subject.
Source: https://github.com/Ekito/koin/blob/0.9.0/android/koin-android/src/main/java/org/koin/android/ext/android/Extras.kt
Sample app with intent arguments: https://github.com/Ekito/koin-samples/blob/master/samples/android-weatherapp-mvvm/
Feature available in Koin 0.9.0-alpha-5.
--
Just put some 👍, other emojis or comments :)
Thanks for your feedback.

Good idea!
but you only allow serializable arguments which are very slow on android platform.
maybe you could provide multiple types especially parcelable

Good things have been made with Anko intents - https://github.com/Kotlin/anko/wiki/Anko-Commons-–-Intents

I can understand why made this proposal but don't you feel that this shouldn't be part of this library?

Yes, That's also why I make a proposal :)


"5b8eb51" git revision testing thread

Good day, @prochazkaml ! Finally I've tested the latest MichalOS ;-)
Please take a look at my observances:

ARCADE.APP - there's just a "sorryAss" entry, which - if launched - gives a green screen and blinking _
EDIT.APP - maybe it should filter out the file extensions, for which it is known that a text editor can not open them properly: .APP, .DRO, .RAD, ...
FONTEDIT.APP - maybe present a graphical char choosing menu, which is possible to navigate while seeing the character icons. + if I create a character, there's only SAVE and I don't know where it is saved, perhaps should be SAVE AS ---> ask for a character save number
MEMEDIT.APP - a small confusion around sd/shxxx & od/ohxxxx commands (dec/hex). How to choose between dec or hex?
MUNCHER.APP - when it prints "BASIC PROGRAM ENDED" , B is at the right edge of screen
PLAYER.APP - .DRZ file format is not described at PLAYER.APP right panel. Is it 7-zipped .DRO ?
RDTSC.APP - CPU speed in kHz is printed in a weird format - sometimes the spaces instead of numbers:

249  48
249  02
249 487
249  4
249 3 0
249 4 7
249 37

EDIT: maybe it's caused by my edit of "5" character on a previous step, so now it can't be seen at console?

SNAKE.APP - I cannot exit by pressing ESC, had to reboot by a power button
STARS.APP - the starfield isn't random enough ;-) stars are weirdly grouped by lines
SUDOKU.APP - maybe could be randomized using some "valid sudoku generator" algorithm

Luckily the holidays are coming soon - more time for testing a favorite floppy :+1:

Hi @merinfor2021, nice to see you here again!
Also, holy cow, I haven't worked on this project for a while now. But you know how it goes – you work on a project, then you find a fun little side project, then another one, then another one etc. and you end up in project hell.
Anyway, here's what I have to say:

There's only one game for now, The idea behind this app was to consolidate all of the tiny games into one app, since files on FAT12 (in this configuration) are stored in 512-byte units, so having multiple tiny files is just wasting precious floppy space.
There are also these boot-sector games, which are tiny (they have to fit in 512 bytes or less!) and primitive but endlessly fun, so they wouldn't be too hard to add to this app. That is still something I'd love to do.
The games that could be added was already discussed in the discussions tab in this repo, but I'd love to hear from you if found some others!
(I should also rename SorryAss. The word "ass" in this case (at least I hope) is supposed mean "donkey", but most people already forgot this meaning. Perhaps the name "Donkey" could do, since that's the actual name of the game that this game is inspired by. If you have any ideas for a better name, please let me know! 😀)

Here's the thing: the text editor as a whole sucks. It can't open files over 28 K (not a big deal, but still, some MichalOS apps can already use en entire 64 K segment for file loading, so it would be nice to implement here as well), can't properly handle binary files (!), can't support over 79 characters per line (!!!), redraws the entire screen when moving the cursor (especially annoying on slow (virtual) machines) etc.
I'd love to make a new text editor, which could do all of these things (and not be totally broken), but when a binary file would be loaded, it would also serve as a hex editor. (Of course, the text and hex edit mode could be swapped by a hotkey). I know that this sounds a bit ambitious, but I believe that it would be the best option.
However, what could also be implemented (perhaps a bit more easily), would be a hotkey in the file selector to disable the filter. In that case, most users wouldn't accidentaly open a binary file, but advanced users can do whatever they want.

This app was made for development purposes to speed up font editing, it's not even in the main menu. (Imagine that I had to do the first font iteration by typing out binary by hand.) It's nowhere near being a full-featured app (it's basically a hacked-up pixel art editor). However, I should definitely make the app more user-friendly.
The character selector sort of already exists in the ASCII art editor, so it shouldn't be too hard to implement.

sd, od, dd and wd accept a decimal number, while sh, oh, dh and wh accept a hex number.

Stupid mistake, already fixed by the time I post this.

DRZ is a LZ7-compressed DRO file, which has first been split into 64 kB segments. Already added the mention for it now.

If you edit a character in the Font editor, the character will change system-wide, so yes, that is very likely what's going on.

This app was full of weird key handling and stack hacks for exiting, fixed now.

It's a 16-bit pseudo-random number generator, there's sadly nothing much we can really do about that.

If I can find some algorithm that can do that (and it was relatively easy to implement in assembly), I'd definitely go for it, but I can see that it would be quite the challenge.

To-do list based on your feedback:

Add more games to the Arcade app
Rename SorryAss
Make another text editor/hex editor
Add a hotkey for toggling the filter
Improve the font editor
Find a better pseudo random number generator (?)
Find an algo for generating sudokus of varying difficulty

I'm sorry that I can't do all of these right now as I don't have much time, however, I'll definitely look into these tomorrow.
Other things I'd like to add:

Make the input dialog escapable (→ be able to press Escape when in the text input). That would require properly modifying all of the apps which use the function, but it would be immensely useful (ie. when selecting Open in the Font editor and you forgot to save your changes, you can say goodbye to them).

Looking forward to hearing back from you! Luckily the holidays are coming soon – more time for development 😁

@prochazkaml Nice to see you there! :wink: Thank you for fixing a couple of problems, I've just put a new floppy into my BIOS. MichalOS looks quite polished and gives a deep nostalgia/retro feels. Thank you so much for such a great OS - together with Kolibri it's my best favorites :smiley: Please also add to your to-do "Fix a SorryAss" since it's not working for me: if launched - gives a green screen and blinking _ . I'm also looking forward for the holidays, to have a happy time with the stuff we love :santa:

@merinfor2021 No problem, and thank you!
Donkey (renamed from SorryAss – made the commit 3 days ago, but forgot to push it, it's on here now) uses a weird text video mode, so it'll have to be entirely rewritten in either the standard text mode or some more common graphics mode. 🤷
Will take a look at it (along with all of the other issues I've put in my to-do list) some time soon. Can't tell you when exactly, however, I'll try my best to do it during the next week (or even tomorrow! – the afternoon classes that were supposed to take place at school have been dropped for some reason, so I have a couple of extra free hours on my schedule tomorrow, might as well put them to good use 😏).
Also, thank you for sticking around for such long time, you were here basically since the project has been first published, and have reported heaps of feedback making the OS overall way better! 😁

Alright, so I've at least worked on the Font editor today and made it actually usable – I quite like it, actually. I've implemented the character picker from the ASCII art editor, the font now automatically reloads upon saving the character and I've also implemented the new file menu (in the corner) + corrected its terminology, to make more sense. As always, thank you for your feedback! 😁

@prochazkaml Dear Michal, Happy New Year! :santa: Wish you a strong health, happiness, and may all your wishes come true :wink:

Hi, @merinfor2021, and I wish you a Happy New Year as well! (well, technically, over here were still stuck on December 31th in the absolute dumpster fire that was 2021, but that will change in 5 minutes... 😁)
Of course, may your days continue to be filled with good health, even in these awful times, hopefully, it will soon end... 🙂


feat(Lezer grammar): Add new tokens

This adds a new token called VariableName that we expose in variable declarations using the let keyword. We use this token for highlighting the variable name in CodeMirror.

F_string have been renamed to FormatString to match the upstream Python grammar.
R_string have been renamed to RawString to match the upstream Rust grammar.
S_string have been renamed to ServerString to match upstream convention.
Ident have been renamed to Identifier to match SQL grammar.
The ArithOp, CompareOp and LogicOp tokens are now highlighted.

This adds a new token called VariableName that we expose in variable declarations using the let keyword. We use this token for highlighting the variable name in CodeMirror.

This sounds good!

F_string have been renamed to FormatString to match the upstream Python grammar.

R_string have been renamed to RawString to match the upstream Rust grammar.

S_string have been renamed to ServerString to match upstream convention.

But I think "format string" is actually something slightly different, namely in python "{}.{}".format(name, suffix), rather than with a leading f. Is that not your understanding? https://docs.python.org/3/library/string.html#formatstrings

For s-string, if we really had to put a word there, it would be "SQL String". But adding another name to something means we need to learn two names. And "s-string" is quite clear in form.
OTOH, "SQL String" does describe its function quite clearly, so we could change its name in PRQL. CC @PRQL/prql-team

Overall, I think we should match names of things in the grammar with PRQL itself, and only change the name to match other projects if we change it everywhere.

But I think "format string" is actually something slightly different, namely in python "{}.{}".format(name, suffix), rather than with a leading f. Is that not your understanding? https://docs.python.org/3/library/string.html#formatstrings

I wanted to get away from using underscores in token names in order to match conventions of upstream grammars which use camel case and pascal case. FormatString is name of the token used by the upstream Python grammar for f"test" (try on https://lezer-playground.vercel.app/)

For s-string, if we really had to put a word there, it would be "SQL String". But adding another name to something means we need to learn two names. And "s-string" is quite clear in form.
OTOH, "SQL String" does describe its function quite clearly, so we could change its name in PRQL. CC @PRQL/prql-team
Overall, I think we should match names of things in the grammar with PRQL itself, and only change the name to match other projects if we change it everywhere.

I just assumed that the S in "s-string" was for server, but I guess I my assumption was wrong. Still, I feel that "ServerString" is a better name than "SQL String" because I see SQL as just one of potentially many query languages that PRQL could transpile to.

FormatString is name of the token used by the upstream Python grammar for f"test" (try on https://lezer-playground.vercel.app/)

I'm guessing that an f-string is formatted the same as a format string in the python grammar. But our f-string is not actually a format string, and so we shouldn't name it the same as that, particularly when it's incompatible with the PRQL language.

I wanted to get away from using underscores in token names in order to match conventions of upstream grammars which use camel case and pascal case

Unless you feel quite strongly, how about doing FString or fString for all of these, rather than changing the name?

I'm guessing that an f-string is formatted the same as a format string in the python grammar. But our f-string is not actually a format string, and so we shouldn't name it the same as that, particularly when it's incompatible with the PRQL language.

No '{1}'.format(a, b) is a CallExpression(MemberExpression(ArgList))).

Unless you feel quite strongly, how about doing FString or fString for all of these, rather than changing the name?

We cannot change it to fString because with a lower case it is not exported, so it must start with an uppercase letter. We can name it FString or Fstringthough. Either would be fine with me.

We cannot change it to fString because with a lower case it is not exported, so it must start with an uppercase letter. We can name it FString or Fstringthough. Either would be fine with me.

I think FString would be great, that would be standard!

No '{1}'.format(a, b) is a CallExpression(MemberExpression(ArgList))).

OK interesting. Though the python docs (link above) do call a "format string" something different from "f string"...

Okay, I have now renamed:

FormatString to FString
RawString to RString
ServerString to SString


Please release version 1.6.8 on PyPi

Hi,
Can you release 1.6.8 to PyPi please, @aleontiev? The fix in bcf9c6cf4a5e2d740b3526a1af75a00ceea419de is not released so I'm getting:
ContextualVersionConflict: (Django 1.11.5, Requirement.parse('Django<=1.11,>=1.8'), set(['dynamic-rest']))
Thanks!

i think it should be 1.6.9


Add permission for process command during CreateApplicationVersion

This fixes the permissions error when running the command nullstone push ... to a beanstalk environment.
This is necessary because we're using the process flag when running the CreateApplicationVersion command

Nice find!


Ensure That if Music.app Was Not Running before NAS / Sonos / iTunes Sync Runs That It Is Not Running afterwards

When nas-sonos-itunes-sync runs, if Music.app was not running beforehand it should not be running afterwards.

Closed with #2.


[FLINK-12173][table] Optimize SELECT DISTINCT

What is the purpose of the change
This is to optimize SELECT DISTINCT query from using GroupAgg to DeDuplicate.
Brief change log

Implements a new Calcite rule that does the following:
Check if the user is running SELECT DISTINCT query.
If so, converts the current plan from StreamPhysicalDeduplicate instead of StreamPhysicalGroupAggregateRule in rowtime.
Modify existing tests to reflect the new optimizer.
We decided that because of this bug, https://issues.apache.org/jira/browse/FLINK-35792, we will avoid optimizing for this particular case.

Verifying this change
Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.
This change is already covered by existing tests in the table/planner module. For example:
flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/common/PartialInsertTest.xml
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): ( no )
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: ( no )
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)

@flinkbot run azure

@flinkbot run azure

@flinkbot run azure

@flinkbot run azure

@flinkbot run azure

@flinkbot run azure

@xuyangzhong can I get your review for this PR? The Github UI is not letting me add new reviewers.

Hi @xuyangzhong, @wuchong @lincoln-lil, could I get your feedback on this PR?
I don't have access to add you as reviewers, therefore pinging here. Your in-time feedback will be deeply appreciated.

@xuyangzhong I noticed you discussed some of this changes with @jnh5y in FLINK-35792
Would be great to see your thoughts here as well especially about usage of physical rule in logical set (I'm still confused by this)
//cc @lincoln-lil (i think you might be interested in this as well)

Reviewed by Chi on 12/12/24. appears that this PR is healthily progressing