possible implicit any error

TypeScript Version:  2.2.0-dev.20161209
Code
// A *self-contained* demonstration of the problem follows...
interface IQResolveReject<T> {
        (): void;
        (value: T): void;
}

interface IPromise<T> {}

interface IQService {
        // if the order of these two definition were swapped it will compile fine
        <T>(resolver: (resolve: IQResolveReject<T>) => any): IPromise<T>;
        <T>(resolver: (resolve: IQResolveReject<T>, reject: IQResolveReject<any>) => any): IPromise<T>;
}

let $q: IQService;
$q((resolve, reject) => { console.log("promise!") });

Expected behavior:
it compiles correctly (it compiles correctly in version 2.0.10)
Actual behavior:
test.ts(19,5): error TS7006: Parameter 'resolve' implicitly has an 'any' type.
test.ts(19,14): error TS7006: Parameter 'reject' implicitly has an 'any' type.

This is a duplicate of https://github.com/Microsoft/TypeScript/issues/12733. You can find more details in https://github.com/Microsoft/TypeScript/issues/12733#issuecomment-265616142

also more documentation available at: https://github.com/Microsoft/TypeScript/wiki/Breaking-Changes#implicit-any-error-raised-for-un-annotated-callback-arguments-with-no-matching-overload-arguments

@mhegazy I think the problem is that the documentation needs to highlight that overload resolution is order-dependent. Currently, https://www.typescriptlang.org/docs/handbook/functions.html only says "its customary to order overloads from most specific to least specific". With this change this ordering seems to be required.

@mhegazy Actually, the error message doesn't make sense. If the call is resolved to the first overload, I can understand how reject will be typed as any, but why is the first parameter resolve also any?

@mhegazy the implicit any error does seem to be a duplicated of #12733, but there's still quite a bit of confusions/other unexpected behaviors with the example. I have updated the Expected Behavior section to summarize the issues mentioned in the conversation above.

The reason why this happens is related to how the compiler does overload resolution and how contextual types work.
you can read more about this in https://github.com/Microsoft/TypeScript/blob/master/doc/spec.md#4152-type-argument-inference.
the short version is function expressions get a contextual type from the call signature (e.g. resolve and reject in the example above) but to know that, overload resolution has to occur first, so that the compiler knows what overload to use to contextually type (i.e. which overload in IQService in the example above), but it needs the type of the argument to do the overload resolution.
The compiler processes the overloads in order, and it is important to note that once a contextual type is applied, it cannot change, since this has implications on the types of every expression inside the function.
Since the first argument of the first overload in IQService does not match the correct count or expected arguments, the compiler decides is not safe to use it as a source of contextual typing, this is when it sets the types to any. and the error is reported. previously, it would not have reported the error. but the types would still be any.
as for this sample, the first overload should not be there.. IQService should be declared as:
interface IQService {
        <T>(resolver: (resolve: IQResolveReject<T>, reject: IQResolveReject<any>) => any): IPromise<T>;
}

@mhegazy In that case, I would expect the same error whether I remove the second overload, but that's not the case. Looks like the second overload is only ignored for contextual typing?

if the first overload does not exist, the compiler uses the second signature for contextual typinging, it is argument count does match, so you get the correct contextual type.

@mhegazy I'm talking about only keeping the signature with resolve. In the presence of both, I'd expect the second to be ignored for all checks, but that doesn't seem to be the case.

not sure i follow what you mean by that.

interface IQResolveReject<T> {
        (): void;
        (value: T): void;
}

interface IPromise<T> {}

interface IQService {
        <T>(resolver: (resolve: IQResolveReject<T>) => any): IPromise<T>;
}

let $q: IQService;
$q((resolve, reject) => { console.log("promise!") }); // Argument of type '(resolve: any, reject: any) => void' is not assignable to parameter of type '(resolve: IQResolveReject<{}>) => any'.

gives a different error than
interface IQResolveReject<T> {
        (): void;
        (value: T): void;
}

interface IPromise<T> {}

interface IQService {
        <T>(resolver: (resolve: IQResolveReject<T>) => any): IPromise<T>;
        <T>(resolver: (resolve: IQResolveReject<T>, reject: IQResolveReject<any>) => any): IPromise<T>;
}

let $q: IQService;
$q((resolve, reject) => { console.log("promise!") }); // Parameter 'resolve' implicitly has an 'any' type. Parameter 'reject' implicitly has an 'any' type.

so it seems that the second overload is not completely ignored?

You need the second overload, and not the first.
You should not have overloads for an overload unless you are using function.length at runtime. otherwise, you want the one with most arguments, since at runtime this is how the call back is invoked.

@mhegazy I understand. I was just expecting the same typechecking behavior with and without the redundant overload.

without the overload you get an assignablity error, as you are saying you can not call me and expect more than one argument in a call back.

@mhegazy Right, but if the overload resolves to the first overload, shouldn't I still get an assignability error regardless of whether the second overload exists?

no. the issue i was describing above is only applicable for multiple overloads, with context sensitive arguments (e.g. function expressions with no explicit type annotations).

@mhegazy I see. I still think this behavioral difference is a bit subtle though :)


Level/Used top-middle bar doesn't have enough space for localization

Some automatic layout should be implemented (something like @Ttxman suggested in #113).
Or... other way of displaying information could be considered. Maybe use of icons, where on hover over icon, tooltip could be even more comprehensive as simple "Level", "Used" labels.
Also label for Class combobox is missing, while Help document is referring to it.
Same problem is with bottom bar having labeled textbox'es. Which I temporally fixed by moving “PoEURL It!” button to Tools menu, but still it can cause problem for other languages in future.
Don't remember the exact numbers, but best practice for making localizable UI labels, is to add 50% or 75% of space to UI element. So, when you fit some English label into 100px, it should have width at least 150px or 175px to allow some space for translated label.

I like icons for some things as they take up less space and can make the UI look better, but in this case I'm not sure we can come up with good icons for "Level" and "Used". Not without confusing a lot of users at least.
The best route would be to go for the automatic layout, but that is also the most amount of work.

Hmm.. something like this for level? :)) http://www.vectorstock.com/royalty-free-vector/level-icon-vector-741047

And points used something like this:
https://www.google.com/search?q=icon+points+used&tbm=isch&imgil=HKHSNG4WXUP8wM%253A%253BP5akRPSJHghwUM%253Bhttp%25253A%25252F%25252Fplanetside.wikia.com%25252Fwiki%25252FCertification_Points&source=iu&pf=m&fir=HKHSNG4WXUP8wM%253A%252CP5akRPSJHghwUM%252C_&biw=1680&bih=913&usg=__n3rvVtAgTpJfnBu9SD9LuYdiWCs%3D&ved=0CCsQyjc&ei=JMWLVa6ADYKksAH9lKr4Bg#imgrc=HKHSNG4WXUP8wM%253A%3BP5akRPSJHghwUM%3Bhttp%253A%252F%252Fvignette3.wikia.nocookie.net%252Fplanetside2%252Fimages%252F0%252F0b%252FIcon_resource_certpoints_128.png%252Frevision%252Flatest%253Fcb%253D20121030221606%3Bhttp%253A%252F%252Fplanetside.wikia.com%252Fwiki%252FCertification_Points%3B128%3B128&usg=__n3rvVtAgTpJfnBu9SD9LuYdiWCs%3D
circle with inward arrow

I'm not sure icons are right way to do it. If we really want the touch screen support, then hover and tooltips are out of question. And there are no widely used icons for "level" nad "used" that everyone knows.

A plus sign or up arrow are pretty good indicators of level up. Most games
us some version of those symbols. Used points however is a bit harder. We
could just rearrange the top bar there and see where that goes.
On Jun 25, 2015 6:56 AM, "Ladislav Šeps"<EMAIL_ADDRESS>wrote:

I'm not sure icons are right way to do it. If we really want the touch
screen support, then hover and tooltips are out of question. And there are
no widely used icons for "level" nad "used" that everyone knows.
—
Reply to this email directly or view it on GitHub
https://github.com/EmmittJ/PoESkillTree/issues/129#issuecomment-115265457
.

This has been solved by simply removing the text and adding it to a hover display


Show scroll bar in some places such as, when selecting an account, or a token in de send flow, and allow scrolling on the change "network page".

I was under the impression we do not show a scroll bar for a clean look of the product. It is also possible this is a bug. At the moment I am missing a scroll bar on several pages even when I hover to the side with the mouse it does not appear.
These are the pages identified thus far:

Account selection page
Selecting a token to send
receiving token list (also needs a filter)
Change network page

Related discussion: https://trustmachines.slack.com/archives/C069V6G48F7/p1724194546535279

We intentionally hide the scroll bar for aesthetic reasons.
Scrolling definitely still works but perhaps we can reach out to this user (Prince Troy (PrinceTroyC} on Twitter ) and ask for more information?
Perhaps it is an actual bug on the platform they are using, in which case we should fix it

I will reach out to them.

Reaching out to the user lead to my twitter account getting suspended :exploding_head:
Without speaking to this particular user, I have seen reports like this before and in those cases they didn't realize how to scroll because they do not see the scroll bar. Probably mostly due to conditioning and doing it a certain way. Sometimes a user doesn't have a scroll wheel (or way to swipe) but that is rare.
In case you can't swipe or scroll through, they are locked. In addition some users in the past have complained that it was inefficient scrolling when you have to go through hundreds of tokens or accounts it is much faster to click the scroll bar and move it down with the mouse.

It is working as intended and will not be changed.

Adding my update from Slack:
Can you double double check that on a Windows laptop, with no mouse that you can scroll using the trackpad?

I've confirmed that this works on a MAC but I can't test it on windows

We could consider a possible enhancement whereby if users have say 100+ accounts then we show the scroll bar

before doing that it would be interesting to know what % of our user base this is

I get that they would be frustrated trying to access account 250. If this is a large proportion of users we could also investigate adding pagination


clean selected field values when switching data source on create page

Description
This pr includes three things:

update Data Source card title to Select Data on create page to avoid confusion with MDS support
clean selections on create page when switching data sources
only append dataSourceId to the create page url when MDS is enabled

https://github.com/opensearch-project/anomaly-detection-dashboards-plugin/assets/41348518/e9c3e6f4-bcb3-47d4-a772-113c913a7ede
Issues Resolved
[List any issues this PR will resolve]
Check List

[x] New functionality includes testing.

[x] All tests pass

[ ] New functionality has been documented.
[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

UT failed, need to update snapshots


ignore contrail vrouter interfaces being down

Juniper Contrail will produce alarms when vrouter interfaces are down. This commonly happens when an instance is off.
It is believed this behavior is intended by Juniper, the contrail_analytics_alarms will often produce false positives. We should make it ignore Contrail alarms for vrouter interfaces that are down.

(by addyess)
Release Available here: https://jaas.ai/u/llama-charmers-next/openstack-service-checks/9


[SDK] Add character limit to chunks

We should limit the size of inputs passed to pgml.embed() and pgml.transform() as to avoid overly large inputs. We need to ensure that the chunker produced parts that are not too large and not too small. If we allow large amounts of text to be sent in one call, the call has a higher probability of failure.

I think this is an application issue, not something we can reasonably control at the extension level.


adding backend resulted in blocking error

Describe the bug
after building some front end, I asked for a backend and it suggested Prisma with SQL lite. However, it was not able to get the prisma commands to run, and the app no longer runs at all
Link to the Bolt URL that caused the error
https://bolt.new/~/sb1-vxkwga
Steps to reproduce
app does not run
Expected behavior
content appears on the screen
Screen Recording / Screenshot

Platform
Browser name = Chrome
Full version = <IP_ADDRESS>
Major version = 131
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
performance.memory = {
  "totalJSHeapSize": 65344692,
  "usedJSHeapSize": 60237468,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}
Username = gotrhythm88
Chat ID = f2a019ee75c8

Additional context
No response

Prisma won't work in Bolt because it uses WebContainers which just allows you to have a virtual Node environment in the browser. It doesn't actually give you a server running on you computer hence why Prisma doesn't work. Prisma needs a Node server in order to do the queries. This is why many of the community is using things like Supabase and Firebase for their backend.


chore: release  operator-chart 0.1.4

:package: Staging a new release
0.1.4 (2023-03-15)
Bug Fixes

mp-spdz: trigger workflow (5ab6139)
operator-chart: rename chart to make publication workflow work (#47) (b529207)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/carbynestack/klyshko/releases/tag/operator-chart-v0.1.4 :sunflower:


Fix/applics 736 welsh translation register have your say update text

Describe your changes
Welsh text change

https://pins-ds.atlassian.net.mcas.ms/browse/APPLICS-736

Useful information to review or test

Type of change 🧩

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update
[ ] Other (please explain in the description section above)

Checklist before requesting a review

[ ] I have performed a self-review of my own code
[ ] I have double checked this work does not include any hardcoded secrets or passwords
[ ] I have made corresponding changes to the documentation
[ ] I have provided details on how I have tested my code
[x] I have referenced the ticket number above
[ ] I have provided a description of the ticket
[ ] I have included unit tests to cover any testable code changes

:tada: This PR is included in version 2.28.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.34.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Question: Thumbnail resize options

Is this correct, that only resizing with X and Y values is possible atm?
Could sth like the following work?
in nuxt.config.js at the imageStyles:{ ... }
thumbnail: { actions: ['gravity|Center', 'resize|320|auto', 'extent|320|180|+0|+90'] },
or
thumbnail: { actions: ['gravity|Center', 'resize|320|*', 'extent|320|*|+0|+90'] },

Hi @dev7ch
You should be able to use any of the graphicsmagick option for the convert command.
The docs are here: http://www.graphicsmagick.org/convert.html although they do take a bit of grokking with a bit of trial-and-error to understand and get working as you want. All of these options should work, but I've only tried some of them.
In particular, there are few of the options you may want to look at:
http://www.graphicsmagick.org/GraphicsMagick.html#details-resize
http://www.graphicsmagick.org/GraphicsMagick.html#details-crop
http://www.graphicsmagick.org/GraphicsMagick.html#details-extent
Does this help?
Barry

Thank you @barryrld , yes it should be there some where. Thanks for sharing the specific links.
On a first look i wasn`t able to see how it can be done, very complex docs ... .. i ll have deeper look once it comes up again.


Warn before interaction with live theme

Is your feature request related to a problem? Please describe.
Currently, when you watch or deploy to a theme and it's the live theme you get a message "Warning, this is the live theme on..." but it doesn't impose any checks to confirm you want to move forward
Describe the solution you'd like
I would prefer if there was a way for the CLI to ask "Are you sure you want to continue?" or something to that nature. Is there any way to implement a feature like this within the tool or using another package like commander/yargs?

So I generally try to stay out of the users way while they work. So in the past I added a configuration to make a configuration readonly. You can set your live theme config as readonly so that no changes can be made to it no matter what command is run.


Added the new domain model guide blog

Added the blog that guides about the unified experience on SAP Cloud Platform cockpit.
[A Step by Step guide to the unified SAP Cloud Platform Cockpit experience]

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Godot 4: export variable in Visual Script can't be turned off once turned on

Godot version
v4.0.alpha2.official [79077e6c1]
System information
Windows 11, Vulkan Clustered, Intel UHD Graphics 620 v<IP_ADDRESS>0
Issue description
An export variable in Visual Script can't be turned off once turned on, as shown in the screen recording below:
https://user-images.githubusercontent.com/1403194/153779664-6c829498-1ff3-4ef0-9675-ca4ac52c602b.mp4
This is a regression from Godot 3.4, as shown in the screen recording below:
https://user-images.githubusercontent.com/1403194/153779715-3ad2f7be-42a4-4f09-bccb-164405c71ac3.mp4
I expect the export variable to work as it should be.
Steps to reproduce

Add a variable in Visual Script.
Make it an export variable.
Turn the export off. You won't be able to turn it off.

Minimal reproduction project
No response

cc @Gallilus

I'll see if I can make a board to tracking Visual Script issues.

@kreaninw Is this issue still active?

@kreaninw Is this issue still active?

Yes, as of Godot v4.0.alpha5.official [d7d528c15], as shown in the screen recording below:
https://user-images.githubusercontent.com/1403194/161395447-4d280ac0-e71b-4568-b571-2d5e4f156ad6.mp4

O the toggle work? Then I think it is the same as #58158

O the toggle work? Then I think it is the same as #58158

Yes, the toggle works as expected but it has no effect in the inspector tab.

Closing as duplicate of #58158 (the variable is exported even if you don't tick the checkbox)


n

m!

I'm excited by your intention of opening this issue, and hope you'll come back to elaborate!

No idea where this came from. Sorry about that! 🤷🏻♂🙂


IDbCommandTreeInterceptor: NavigationProperties not present

From @gentledepp on August 12, 2014 14:19
Hi!
I modified jbogards EntityFramework.Filters which adds the support for "global filters" to an EF DbContext. (see https://github.com/jbogard/EntityFramework.Filters)
As I am trying to get this to work with a simple join expression, I stumbled over a problem.
I my scenario, I have an "AccessPredicate" table which contains an id of an IResource (Document or Chapter) and the id of a User.
Now what I am trying to achieve is to filter the Documents and Chapters a User is not allowed to see like so
    modelBuilder.Conventions.Add(FilterConvention.Create<IResource, long>("UserId",
                (e, userId) => e.AccessPredicates.Any(@as => @as.UserId == userId)));

What I had to change in EntityFramework.Filters in order to support this was the ParameterReplacer.VisitLamda method, as it tries to always return a lamda expression of type Func<TEntity, bool>, but as I have a sub-lamda (as.UserId == 2l) I have to add a type-check:
           protected override Expression VisitLambda<T>(Expression<T> node)
            {
                var arg1 = typeof (T).GetGenericArguments().FirstOrDefault();
                if(arg1 != null && !arg1.IsAssignableFrom(typeof(TEntity)))
                    return base.VisitLambda<T>(node);

                var body = Visit(node.Body);
                return Expression.Lambda<Func<TEntity, bool>>(body, node.Parameters[0]);
            }

so now it blows up in the second last line of FilterQueryVisitor.Visit(...)
var output = result.Predicate.Accept(normalizer);

with the error: A first chance exception of type 'System.ArgumentOutOfRangeException' occurred in EntityFramework.dll
Additional information: No property with the name 'AccessPredicates' is declared by the type 'CodeFirstDatabaseSchema.Document'.
AccessPredicates is a navigationproperty on Document, however the EdmType (I debugged entity framework where the error is thrown: System.Data.Entity.Core.Common.CommandTrees.ExpressionBuilder.Internal.ArgumentValidation.ValidateProperty)
only has two items in its "Member" collection: "Id" and "Title"
However, if I do not use the filter, and write the query manually like so:
var x = ctx.Documents
                .Where(@d => @d.AccessPredicates.Any(@a => @a.UserId == userId))
                .Take(1).FirstOrDefault();

then the "Member" collection contains "Id", "Title", "AccessPredicates" and "Chapter" as I'd expect.
Do you have any idea how that can be?
It seems to me that EntityFramework constructs the StructuralTypes (which inherit EdmType)
for every query it parses and when I add my filter, I misses something... :/
For ease of debugging, I added a test project: http://1drv.ms/1BbrBAL
Just run "update-database" in package-manager and then hit F5.
I do not know if this is a really EF issue, but I do not know any other place where people could help me with that amount of insight into EF internals that you have. I really hope you can help me on this one :/
Copied from original issue: aspnet/EntityFramework#515

From @BrennanConroy on August 25, 2014 17:52
Investigation:
In order to filter with foreign key relationships you need to use the IStoreModelConvention. EntityFramework.Filters uses Configuration Conventions which doesn't know about Independent Associations (IAs) and therefore when you try filter on a foreign relationship it won't know what you are trying to access.

From @gentledepp on September 23, 2014 15:27
Could you please elaborate a bit (or even better: much more) on that? :)
I looked through the code and I cannot find any "Configuration Convention" things... or I do not know what that is.
Additionally I have the problem, that EntityFramework.Filters seems to change the query before it gets cached. This is because when I change the filter in another DbContext instance and then look into the generated SQL, the parameter value is still the old one.
In order to get this to work, I had to disable QueryCaching.... Quite bad...
Is this also because EF.Filters uses Configuration Convention instead of StoreModel Configuration?
Any hints how this can be solved? E.G.: when to replace parameters of a cached query, etc.
A short code listing would be greatly appreciated! :)

Note for triage: I have just moved here this EF6 issue that had been on my investigate queue for a long time.
Unfortunately I never made progress on responding to the customer, but it seems to me that Brennan's original response was correct and from the last comment about query caching it seems that the approach taken by EntityFramework.Filters could only ever work in simple scenarios with EF6.
At this point I think we can close this issue. The filtering scenario described in EntityFramework.Filters:

Filters allow you to define a parameterized filter at configuration time. At runtime, you turn on the filter and apply parameters, and every query for that entity will include the filter.

Is something we can address in the future, in particular using EF Core. Currently it is tracked as part of lifecycle hooks (https://github.com/aspnet/EntityFramework/issues/626) but we can consider having a separate time.


Coordinate columns labeled Latitude and Longitude but hold data in UTM (mostly).

The CSV from the "Download Application Data" link uses columns titled "GPS_LATITUDE" and "GPS_LONGITUDE" to hold the UTM y and x values. The Data Origination section explains that its in UTM Zone 12N NAD83, but some users are thrown off by having "latitude" and "longitude" in the field names. Can these names be changed to something like "UTM_Y" and "UTM_X", or are they set by the data provider?

They are set by the data provider

Yeah, I figured that might be the case. Just wanted to pass along what I'd
heard from users.
On Tue, Oct 22, 2019 at 4:03 PM steveoh<EMAIL_ADDRESS>wrote:

They are set by the data provider
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/agrc/Crash-web/issues/60?email_source=notifications&email_token=AJDGLXSNXIJNOXPEO3GUG73QP52C7A5CNFSM4JDYL5K2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB7LRPA#issuecomment-545175740,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJDGLXXVZZCEDUQMAFSHPXLQP52C7ANCNFSM4JDYL5KQ
.

You could approach clancy black about it.


Fix index donations made label when change to english

Coverage increased (+0.03%) to 80.599% when pulling 1dafdf1ef266136cdae6d139d2d9ab1138d04a0e on fix/layout-en into 4f957b85de1fec0def9e8fed0e9f03215a4cb027 on master.


Destructuring objects is not implemented on merger

Similar to issue #52, when declaring a new variable as a destructuring object (using { ...array }), merger gets broken because it expects text (any, string, number...) but it finds strange characters. For instance:
    return {
      size: this.pageable.pageSize,
      searchTerms: { ...this.arraySample},
    };

Being arraySample the following:
 arraySample: {} = {
    id: undefined,
    name: undefined,
    surname: undefined,
    age: undefined,
  };

Breaks the merger. The workaround is manually adding all the attributes from arraySample.

I have just tested with the latest version and I was not able to reproduce this error.


Error

Not working...
`Diamond has launched.
AdjustTokenPrivileges error: 0x00000006
2020-06-04 18:38:50,241 - pymem - DEBUG - Process 24276 is being debugged
Traceback (most recent call last):
File "diamond.py", line 41, in
main()
File "diamond.py", line 13, in main
client = pymem.process.module_from_name(pm.process_handle, "client_panorama.dll").lpBaseOfDll
AttributeError: 'NoneType' object has no attribute 'lpBaseOfDll'`

Valve renamed client_panorma.dll to client.dll. Fixed in commit ddf1ea0a41379d6493a1d979593a023f73957502. Thanks for the report.


When the context is expanded, C code cannot be seen.

If the expanded context puts the C code off the bottom end of the screen, you are unable to scroll down to view the remaining code.
https://decomp.me/scratch/MeTIZ
^ An example on my screen.

Closing since it's already going to be handled in #32 . Thanks for the report!


Update UML sequence diagram for linkloan command

Fixes #67.
Adds a UML sequence diagram for the execution of the linkloan command, which includes the Logic and Model components.
Format is similar to the sequence diagram for delete, as shown here.

Thanks for reviewing! The diagram mainly traces out the sequence flow in the Logic and Model components. For other components (e.g. Person/Loan, Commons), I'm planning to add another sequence diagram for this in the future!


Missing link

For the paragraph below the last sentence says follow this quickstart but doesn't link to anything.
Enable Azure Cosmos DB analytical store
To run large-scale analytics into Azure Cosmos DB without impacting your operational performance, we recommend enabling Synapse Link for Azure Cosmos DB. This function brings HTAP capability to a container and built-in support in Azure Synapse. Follow this quickstart to enable Synapse Link for Cosmos DB containers.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d30f0988-e1d1-70fd-2a5e-313a5bfa1b50
Version Independent ID: 562dbdd6-31ef-a9c5-363e-151a7151e24f
Content: Connect to Azure Synapse Link for Azure Cosmos DB - Azure Synapse Analytics
Content Source: articles/synapse-analytics/quickstart-connect-synapse-link-cosmos-db.md
Service: synapse-analytics
Sub-service: ****
GitHub Login: @ArnoMicrosoft
Microsoft Alias: acomet

@jackwynne Thanks for your contribution, I've addressed this issue in PR: https://github.com/MicrosoftDocs/azure-docs-pr/pull/117547
The changes should be live EOD or tomorrow. We will now close this issue. In future, if you see any minor bug fixes in the doc, feel free to click on the edit button and submit a PR to update. we love to take community contributions.


[MI-2711]: Create Countdown component

Ticket ID:
https://brightscout.atlassian.net/browse/MI-2711
Description:

Add countdown component

Screenshots:
Default

Custom

@SaurabhSharma-884 do changes as discussed


Link broken

Hello your demo link is broken for the IMU data.
https://github.com/ioteratech/bluetera-firmware/blob/master
Just wondering if you have any kind of calibration for the IMU in your SDK? I would require accurate IMU data with very little drift. With at least some way of correcting drift.
Thanks

Hi,
Thanks for the heads up about the link!
Currently we are calibrating the gyro at first startup to minimize the
drift as much as possible, but there will always be some gyro drift.
However, we do implement sensor fusion on-board, which can incorporate the
accelerometer (6-axis fusion) to compensate for the gyro drift on the roll
and pitch axes, and compass (9-axis fusion) for the yaw axis drift. So with
a calibrated compass, theoretically, you should have almost zero drift, as
long as there are no local magnetic interference.


S3 client ignores http configuration

Describe the bug
S3Client::operator= was introduced in the commit which does not properly reinitialise base class. m_httpclient uses default timeouts in this case
Expected Behavior
Configuration (and timeouts) are respected. Code below outputs 30000
Current Behavior
Timeouts are not respected as inner m_httpclient is initialised with default configuration. Code below prints ~150
Reproduction Steps
Aws::SDKOptions options;
Aws::InitAPI(options);
{
    Aws::Client::ClientConfiguration clientConfig;
    clientConfig.connectTimeoutMs = 30'000;
    clientConfig.httpRequestTimeoutMs = 30'000;
    clientConfig.requestTimeoutMs = 30'000;
    clientConfig.proxyHost = "localhost";
    clientConfig.proxyPort = 1234;

    // ok
    // Aws::S3::S3Client client = Aws::S3::S3Client(clientConfig);

    // not ok since 1.11.212
    Aws::S3::S3Client client;
    client = Aws::S3::S3Client(clientConfig);

    Aws::S3::Model::GetObjectRequest request;
    request.SetBucket("test_bucket");
    request.SetKey("test_key");

    auto start = std::chrono::system_clock::now();
    auto outcome = client.GetObject(request);
    auto end = std::chrono::system_clock::now();

    auto now_ms = std::chrono::duration_cast<std::chrono::milliseconds>(end - start);

    std::cout << now_ms.count() << std::endl;
}
Aws::ShutdownAPI(options);

Possible Solution
No response
Additional Information/Context
No response
AWS CPP SDK version used
1.11.212
Compiler and Version used
Visual Studio
Operating System and version
Windows 11

sorry,  I should have been more specific. It was tested on 1.11.331 and I just tried on the latest master - still doesn't work.
From the commit that you provided, I don't see changes around m_httpclient (in AWSClient or S3Client)

This should be fixed with this PR: https://github.com/aws/aws-sdk-cpp/pull/2977
Please update to the latest version of this sdk and let us know if you run into any problems

Confirmed, it is fixed now. thanks!


Update CLI extensions available doc

Update CLI extensions available doc.
Triggered by Azure/azure-cli-extensions - TRAVIS_BUILD_ID=454085226
https://github.com/Azure/azure-cli-extensions/commit/a800a5f2d8b2cc45a1c32b17b24f81b4721108f0

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/azure-cli-extensions-list.md
:white_check_mark:Succeeded
View (azure-cli-latest) View (azure-cli-2017-03-09-profile) View (azure-cli-2018-03-01-hybrid)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[Feature] Admin search for users

Proposal
Connect into elastic search to be able to search for users. This will also display a list of the found users.
Repercussions
No longer need to find users on the OSF by using its search utility. Centralizing authority.

Closing for now. Definitely not a priority since this is on the OSF.


When crafting in the storage scanner, the items in the scanned inventories disappear rather than craft.

As title says, unfortunately this is all I can provide but it seems easily repeatable as I have done it multiple times. Resonant Rise version: <IP_ADDRESS>-b. RFTools version: "RFTOOLS-1.1X-6.10"
Video: https://www.youtube.com/watch?v=GR_b6TK8A-s

Hmm this has been reported before but I have never been able to reproduce it. Where was that gold stored? What kind of block is that?

https://github.com/McJty/RFTools/issues/1231

What version of Minecraft is that btw? Also I suppose the medium storage crate is from Actually Additions? What version?

It was inside a actually additions crate however, it would remove all items from chests also. Minecraft version 1.10.2 Actually Additions version: "ACTUALLYADDITIONS-1.10.2-R105"

I will see if I can reproduce it in a creative world

I am unable to replicate with just the barrels and chests in a fresh creative and survival world. I can only think that I had an active void miner filling a crate on the scanner at the same time, so that may cause problems as I said I do not know.

I'm seeing if I can simply rewrite the code to be more robust

I think I have a fix. Even though I cannot reproduce the problem. I will publish a new version soon and I hope you will be able to test it to see if it ok now

I hopefully fixed this in 6.12. Let me know if the fix helps

After updating rftools, the problem seems to be fixed, thanks :D

Ok good to know!

I think this bug is back.
Version:
rftools-1.12-7.61
rftoolsctrl-1.12-1.9.3
rftoolsdim-1.12-5.64
Modpack: Enigmatica 2 Expert v1.58
Video:
https://www.youtube.com/watch?v=33jpI62BGnI
The weird thing is that it only deletes 2 torches instead of 4 that the recipe needs.
The red background when you don't have the required items never appears in this scanner for all recipes. I thought it was removed until I checked a scanner with only 1 chest in a new save.
Also, note that I don't have any oak wood. Only birch.
When I swap to birch wood in the recipe it works.

@Senjar In my case I think it was the forestry workbench that were causing issues. After removing them it would stop dissapearing the items and it was showing the red background. I also removed the bibliocraft bookshelfs but I don't think it was that.


Update ERC-2334: Move to Review

See discussion at https://ethereum-magicians.org/t/erc-2333-erc-2334-erc-2335-bls12-381-key-generation-deterministic-account-hierarchy-keystore/19566
ERC-2334 is a defacto standard, required for staking tools and implemented in all consensus clients.
Ideally this is fast-tracked to Final.

Same deal as #364


Soft timer limit is too short for RTC PGE

Checked for duplicates
Yes - I've already checked
Describe the bug
Currently the soft timer limit for RTC PGE is 14400 seconds which is 4 hours. We are seeing that some files require more than that time. We had been told that SLC should take 3-4 hrs. We will add one more hour to make it 5 hrs to add buffer and test.
What did you expect?
SLC PGE to run to completion without errors.
Reproducible steps
1.
2.
3.
...

Environment
Release 2 ER 2

The RTC PGE execution took about 3084 secs after changing the EC2 instance type from c5a.large to c6a.2xlarge.  So there is no need to change the soft time limit.


Documentation examples still use md components...

Your doc is updated with the use of mat prefix instead of md, yet your examples are still using md prefix.
Quite misleading...

You have to clear the cache manually.
The following instructions assume you're running Chrome.
Either:

Open Chrome DevTools on https://material.angular.io
Hold the reload button. There should be the following options: Reload, Hard Reload and Empty Cache and Hard Reload. Click on the Hard Reload menu item.

Or (not tested yet):

Press Ctrl+Shift+Delete (or Cmd+Shift+Delete for Mac) to go to the Clear Browsing Data dialog.
Check the Cached images & Files option:

Click on the Clear browsing data button.

Closing since you're probably getting cached content.

Indeed that was the issue.
However having the user to empty his/her cache is not a solution to me, this has to be done on your side... Like everywhere else on the Internet :)


Added untriaged issue workflow.

Coming from https://github.com/opensearch-project/.github/issues/133, create a GitHub workflow for labelling untriaged issues. Please ensure that an untriaged label with color  exists before merging.

We already have https://github.com/opensearch-project/search-processor/blob/main/.github/workflows/add-untriaged.yml which looks the same as the PR submitted here. Is there a difference I'm not seeing or can we close?

@dblock Please reopen the PR if I missed a difference between what we already have and this PR. Thanks!

Yeah, the PR was auto-generated and I think we have CR/LF differences.


Remove sc_network::NetworkService::register_notifications_protocol

polkadot companion: https://github.com/paritytech/polkadot/pull/2048
Close #6827
This PR removes the register_notifications_protocol method from sc_network.
Instead of registering new protocols after the networking has started (like register_notifications_protocol allows), it is now mandatory to mention the protocol name in NetworkConfiguration.
This has never been done because Polkadot used to make use of this method as well, and getting rid of it would have been a bit tricky. This is no longer the case, and Polkadot does it through NetworkConfiguration.
This change is, in my opinion, not only more correct, but will also simplify the implementation of #7374, as it guarantees the possibility to know in advance the number of notifications protocols.
Consequently, I've also removed setup_disabled_grandpa whose only effect is to register the protocol.
This hack, where the network doesn't start until initialization of the service is complete, is still in place and is still necessary because we grab event streams (using NetworkService::events_stream()) during the service initialization. Calling events_stream() after the networking has started could lead to events being missed. This problem is covered by https://github.com/paritytech/substrate/issues/6403.

Grandpa tests are failing because the tests initialize Grandpa only half-way through the test, and thus miss messages. This is a bit infuriating.

Note for myself: tests::force_change_to_new_set is apparently also failing, but inconsistently.

bot merge

bot merge

Could someone also approve https://github.com/paritytech/polkadot/pull/2048 ? :pray:

bot merge


Fix NUL string error

https://github.com/ericphanson/LicenseCheck.jl/pull/6 with a test added.
Closes #6
(I tried pushing a commit but it made a local branch instead, hence this separate PR)

I wanted to add also a test that makes sure license_table fails when validate_strings=false

But besides that, the test is perfect :slightly_smiling_face:

Good call! Added


s18n() should optionally modify the html lang attribute of localized documents

Done: https://github.com/bitjson/s18n/commit/3cb2d7cf6b366a2358272642ca07020bb3e5afc1


Fix/huggingface usage

The ModelShell class helps build the model in 3 steps - embedder, core_model (all layers up till the lm_head), model_head (lm_head which projects the hidden_dim (H) to vocab_size (V). This means that core_model(X) should return an output that is of shape B,T,H. The model head will then convert this output of shape (B,T,H) into (B,T,V).
However, the former HFTransformerCore returned outputs of (B, T, V) which resulted in an error in the ModelShell's forward pass.
To resolve this, I made two changes in the huggingface.py file.

Firstly, I added additional codes to HFTransformerCore to extract the main body of the model that is everything up till the layer before the language modelling head.
Secondly, I also added codes to HFLMHead to ensure only the language model head of the given huggingface model is used.

Together, these 2 steps ensure that the ModelShell continues to perform the same steps and outcomes.

Why is this necessary? where does the rest of the codebase assume that the transformer core is returning in shape (B,T,H) exactly?

Referencing to the AutoregressiveLMHead, you would see that our core_models stick to outputs of shape (batch, context window, hidden_dim).
class AutoregressiveLMHead(torch.nn.Module):
    """
    Generic autoregressive language model head.
    """

    def __init__(self, model_cfg):
        super().__init__()
        self.layer_norm = build_normalization(
            normalization_name=model_cfg["lm_head"]["normalization"],
            dim=model_cfg["hidden_dim"],
            bias=model_cfg["lm_head"]["bias"],
        )
        self.linear = torch.nn.Linear(
            in_features=model_cfg["hidden_dim"],
            out_features=model_cfg["vocab_size"],
            bias=model_cfg["lm_head"]["bias"],
        )

    def forward(self, x):
        """
        Pass the input through the model.
        Args:
            x: torch.tensor(B, S, H)
        Returns:
            x: torch.tensor(B, S, V)
        """

Hey Dylan, I've updated them. Mind helping me check through?

 Fixes for the Huggingface model imports (hugging_face.py).


Fix "pages dev" --env param not being considered

When running wrangler pages dev --env <myenv> ..., the file .dev.vars. is not being picked up.
After investigation, it looks like is because the env CLI argument was not being propagated downwards.
I didn't create a GH issue, due to this being a trivial fix.
Author has included the following, where applicable:

[ ] Tests
[X] Changeset (Changeset guidelines)

Any update on this?

Hi, thanks for your PR. Unfortunately, --env is not a feature that we're looking to implement at the moment, whilst we figure out the long-term environments story of Pages & Workers convergence.


Tiles become blank after loading with latest leaflet in example

When using the leaflet.wms example with the latest version of leaflet (either git master or the 0.8-dev zip file), in the tiled mode the tiles load visibly and then become blank within about one second (their opacity gets set to 0).
When zooming the map in and out or moving the map around, the tiles become visible again.
It does not happen with the version of leaflet that comes with leaflet.wms.

I am seeing this same problem. Image mode works fine, but tiled mode does not display the tiles even though I can see the images being returned from the server.

This appears to be working with Leaflet 1.0.0-rc.2, let us know otherwise.


fix: missing returns in new python lightgbm model methods

Missed adding returns to the new model methods for getting booster properties in recently merged PR https://github.com/Azure/mmlspark/pull/1024.  Also noticed some of them were calling the wrong underlying method when testing them out.

/azp run

/azp run

/azp run


FileAppendTransaction: transaction did not have exactly one node ID set or list is locked if setNodeAccountIds is specify.

Description
When creating a large fileId to deploy a contract I get the error "transaction did not have exactly one node ID set".
If I try to add a setNodeAccountIds to the transaction I get a new error "list is locked".
This problem occurs on FileAppendTransaction and I also get this error when trying to set a nodeAccountIds on a fileCreateTransaction.
Steps to reproduce
This is the code i'm running using React and the hashgraph js sdk.
          onClick={async () => {
          let helloHedera = require("../MyNFT.json");
          const bytecode = helloHedera.bytecode;
          let byteCodeArray = [];
          for (let i = 0; i < Math.trunc(bytecode.length / 2048); i ++) {
            byteCodeArray.push(bytecode.substring(i * 2048, (i + 1) * 2048));
          }
          const signer = hc.getSigner(AccountId.fromString(fromAccountId));
          const fileCreateTx = await new FileCreateTransaction()
            .setContents(byteCodeArray[0])
            //.setNodeAccountIds([AccountId.fromString("0.0.3")])
            .freezeWithSigner(signer)

          const executeFileTx = await fileCreateTx.executeWithSigner(signer);
          const receipt = await executeFileTx.getReceiptWithSigner(signer);
          const fileId = receipt.fileId;
          console.log("fileId", fileId);

          const nodeId = [];
          nodeId.push(new AccountId(3));

          let i = 1;
          while (i < byteCodeArray.length) {
            const fileAppendTx = await new FileAppendTransaction()
              .setFileId(fileId as any)
              .setContents(byteCodeArray[i])
              //.setNodeAccountIds(nodeId)
              .setMaxTransactionFee(new Hbar(2))
              .freezeWithSigner(signer);
            const signAppendTx = await fileAppendTx.signWithSigner(signer);
            const executeAppendTx = await signAppendTx.executeWithSigner(signer);
            const appendFileReceipt = await executeAppendTx.getReceiptWithSigner(signer);
            console.log("appendFileReceipt", appendFileReceipt.status.toString());
            i++;
          }
        }}

Additional context
No response
Hedera network
testnet
Version
v2.40.0
Operating system
None

Hello RaphaelMessian,
We've tried to reproduce the issue using the snippet below in a new node project but we couldn't:
What we've done:

Generated a large bytecode enough to be chunked, and executed the example but we got UNAUTHORIZED error
Then we used setKeys() method in FileCreateTransaction to set the keys which must sign any transactions modifying this file. This is required.
Then we executed the example again and the it passed successfully
Also we used setNodeAccountIds() method to set different number of node account ids and again it passed successfully

The bytecode that we used was chunked to 29 chunks. You can try the example below with your bytecode and see if it will be appended correctly.
The difference between your and our example is the signer. You're getting the signer from hashconnect, and we're setting it locally with Wallet. Which makes me think the problem comes from there but we'll need more time to investigate.
`
import {
AccountId,
PrivateKey,
Wallet,
LocalProvider,
FileAppendTransaction,
FileCreateTransaction,
Hbar,
} from '@hashgraph/sdk';
import dotenv from 'dotenv';
dotenv.config();
async function main() {
// Ensure required environment variables are available
if (
!process.env.OPERATOR_ID ||
!process.env.OPERATOR_KEY ||
!process.env.HEDERA_NETWORK
) {
throw new Error('Please set required keys in .env file.');
}
// Configure client using environment variables
const operatorId = AccountId.fromString(process.env.OPERATOR_ID);
const operatorKey = PrivateKey.fromStringDer(process.env.OPERATOR_KEY);
const wallet = new Wallet(
    operatorId,
    operatorKey,
    new LocalProvider()
)

let bytecode = ''
let byteCodeArray = [];
for (let i = 0; i < Math.trunc(bytecode.length / 2048); i ++) {
    byteCodeArray.push(bytecode.substring(i * 2048, (i + 1) * 2048));
}

const fileCreateTx = await new FileCreateTransaction()
    .setKeys([wallet.getAccountKey()])
    .setContents(byteCodeArray[0])
    .freezeWithSigner(wallet)

const executeFileTx = await fileCreateTx.executeWithSigner(wallet);
const receipt = await executeFileTx.getReceiptWithSigner(wallet);
const fileId = receipt.fileId;

// const nodesIDs = [[ new AccountId(3) ]];

let i = 1;
while (i < byteCodeArray.length) {
    const fileAppendTx = await new FileAppendTransaction()
        .setFileId(fileId)
        // .setNodeAccountIds(nodesIDs)
        .setContents(byteCodeArray[i])
        .setMaxTransactionFee(new Hbar(2))
        .freezeWithSigner(wallet);
    const signAppendTx = await fileAppendTx.signWithSigner(wallet);
    const executeAppendTx = await signAppendTx.executeWithSigner(wallet);
    const appendFileReceipt = await executeAppendTx.getReceiptWithSigner(wallet);
    console.log("appendFileReceipt", appendFileReceipt.status.toString());
    i++;
}

}
main();
`

@RaphaelMessian is this still an issue or can we close?

@SimiHunjan I don't have any feedback from hashpack team, the problem seems to be coming from their signer.
I've opened a ticket on their discord and I'm still waiting for an answer.

Closing for now


Cleanup for v1

Fixes #{issue ref}
Description

deno fmt
deno lint
updates dependencies
add ci workflows

Other Notes

Do not review all at once lol, would be best to review commit by commit, excluding the deno fmt and deno lint commits

ehhhhh i'll fix tomorrow

ok ready for review

finally adding #63 @Guergeiro ;)

i see the following comment sprinkled throughout:
// @ts-ignore Because Drash expects results from getBodyParam to be a string. An issue should probably be made for this

getBodyParam() has the following return types:
string | { [key: string]: unknown } | Array<unknown> | boolean | null

Is this an issue with the realworld app or drash?

i see the following comment sprinkled throughout:
// @ts-ignore Because Drash expects results from getBodyParam to be a string. An issue should probably be made for this

getBodyParam() has the following return types:
string | { [key: string]: unknown } | Array<unknown> | boolean | null

Is this an issue with the realworld app or drash?

Ah this was from a while ago, i did make an issue and add a PR to it so those comments and the code can be addressed

@crookse https://github.com/drashland/deno-drash-realworld-example-app/pull/100/commits/ce48d93afc9514c050ef580030eae0b54ebab53f

Commenting out linter because deno lint has a bug, ill make an issue for this instead of waiting for a release

I'm done @crookse, the PR is finalised


docs: add WPF/WinForms Blazor Hybrid Documentation to FluentUI Integrations Page

🙋 Documentation Request
There is only documentation regarding getting the library working with Blazor Hybrid MAUI. Having WPF/WinForms documentation would be useful as, right now, it is hard to tell what to do.
💁 Possible Solution
Not too sure how to get it working but needs to be added the instructions alongside MAUI.

In v3 the static assets config is no longer needed for Blazor Hybrid. There is however one (temporary) workaround needed which is described here:  https://preview.fluentui-blazor.net/#tempory-workaround-for-mauiwpfwindows-forms-issues


Bypass rustup wrapper in testsuite

perf record --call-graph=dwarf cargo test && perf report
+   33.53%     0.00%  .rustup-wrapped  [unknown]                                  [.] 0xffffffffffffffff                                                                                ◆
+   27.12%     0.03%  .rustup-wrapped  .rustup-wrapped                            [.] rustup::dist::manifest::Manifest::parse                                                                                ▒
+   26.40%     0.01%  .rustup-wrapped  .rustup-wrapped                            [.] rustup::config::Cfg::find_or_install_override_toolchain_or_default                                                             ▒
+   26.12%     0.00%  .rustup-wrapped  .rustup-wrapped                            [.] rustup::dist::manifestation::Manifestation::load_manifest                                                                      ▒
+   26.05%     0.00%  .rustup-wrapped  .rustup-wrapped                            [.] rustup::toolchain::DistributableToolchain::get_toolchain_desc_with_manifest                                                    ▒
+   24.69%     0.00%  .rustup-wrapped  .rustup-wrapped                            [.] toml::de::from_str                                                                                ▒
+   23.81%     0.01%  .rustup-wrapped  .rustup-wrapped                            [.] rustup::cli::proxy_mode::main                                                                                ▒
+   22.82%     0.00%  regression_chec  [unknown]                                  [.] 0xffffffffffffffff                                                                                ▒
+   17.57%     1.51%  .rustup-wrapped  .rustup-wrapped                            [.] toml::de::Deserializer::tables

We should bypass the rustup wrapper by doing something like rustup which once (but also make sure that we can fallback to not-rustup cargo/rustc if cargo/rustc are not installed with rustup)

fixed by #50dc094ddd3e24a3cbc023023238414404be4086


[BUG] Blinking cursor at end of Dialog title after resize

Describe the bug
Upon resizing the terminal window, a blinking cursor is visible at the end of a Dialog's title.
To Reproduce
Using: https://github.com/gyscos/cursive/blob/main/cursive/examples/dialog.rs
Expected behavior
The terminal would resize and the cursor would not be visible blinking, in the same way it was when the terminal window was first created when the program was run.
Screenshots
Before resizing:

After resizing:

Note the grey blinking cursor at the end of the text 'Cursive'
Environment

Operating system used: Windows 10
Backend used: crossterm v0.23.2
Cursive version: from git

Additional
Perhaps this is as a result of my terminal settings, although I did try to reset everything to default.

Hi, and thanks for the report!
I don't have a windows computer to try easily, so I'm not totally sure what's going on. Will investigate a bit to see if there's a special thing we should do after a resize.


Update addresses.md

Fixes PoliCheck issue https://dev.azure.com/msft-skilling/learn-platform-policheck/_workitems/edit/109078

Acrolinx Scorecards
A minimum Acrolinx score of 80 is required.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology.

Article
Acrolinxscore
Word andPhrases Score
CorrectnessScore
Scorecard
Processed

globalization/locale/addresses.md
74
100
82
link
:white_check_mark:

More information about Acrolinx

Install Acrolinx locally for VSCode
False positives or issues
Troubleshooting issues with Acrolinx

#sign-off

#sign-off

@jowilco Another PoliCheck fix, hope you can merge this or let me know if any concerns. Thank you!

@JnHs Done.


Maven Package Creation - v2.0.4

Bump Selenium version from '4.1.2' to '4.1.3'.
Bump WebDriverManager version from '5.1.0' to '5.1.1'.
Maven Package Creation - v2.0.4.

Codecov Report

Merging #25 (c94e38e) into main (1053678) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main      #25   +/-   ##
=========================================
  Coverage     98.46%   98.46%
  Complexity       20       20
=========================================
  Files             1        1
  Lines            65       65
  Branches          6        6
=========================================
  Hits             64       64
  Misses            1        1

Impacted Files
Coverage Δ

...java/io/github/abhinavminhas/ShadowRootAssist.java
98.46% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1053678...c94e38e. Read the comment docs.


Hosts can upload to themselves

This probably shouldn't happen. A simple IP comparison would prevent it, it's just a question of where and how.

I'm going to add to this problem: multiple pieces of the same file can end up on the same host, and it's actually likely given that we're planning on keeping the active pool from which we draw hosts relatively small. We need some way to avoid this.
Additionally, I might argue that it's not a bad thing to upload at least 1 piece to yourself. The idea is to put the file in the cloud, and if you are a host then you are part of the cloud.  Supposedly you are doing more than just backing up your data and are planning on recovering it from anywhere.

That logic seems mostly sound to me. I think it's worth adding a config setting though.


obj.metadata.selfLink is always None

Example:
from hikaru.model.rel_1_16 import *
d = Deployment(metadata=ObjectMeta(name='somename', namespace='somens')).read()
print(d.metadata.selfLink)

I tested this on the latest released version of Hikaru. Let me know if you need more information to reproduce.
As a sidenote, thank you very much for the work you did on the CRUD API. We've updated most of our code to use Hikaru's CRUD methods instead of directly using the K8s Python client. We're very happy with the API.

I don't think you've found a bug here, I think you're stubbing your toe on a planned Kubernetes deprecation. Looking at the pure K8s client Deployment object in the debugger (V1Deployment), it also shows a None for self_link (which Hikaru knows to map to selfLink), so Hikaru isn't being handed anything useful on my testbed.
Further, this Kubernetes issue from Jul 2019, https://github.com/kubernetes/enhancements/issues/1164, says that selfLink is to be deprecated. It's unclear as to the timing of that, but the availability of the field is probably dependent on the version of the server you're running, and perhaps the version of the underlying K8s Python client. My k3s infra says it's following 1.20 which is well in the range where the field would no longer be provided. Even if it was previously populated it sounds like it's a bad idea to rely on it since it's targeted for deprecation. I'll leave this open until I hear back from you, but my inclination is to close this issue.

Hi, you can close this. You're correct about the deprecation. I can confirm on my own cluster that selfLink no longer exists by running kubectl get deployment -o yaml.
As an aside, here is what tripped me up: When I originally opened this issue I first verified that selfLink existed on my cluster and was only missing from Hikaru... But I performed the check using the Lens client and apparently Lens is patching in selfLink even when it doesn't exist on the API Server. See https://github.com/lensapp/lens/pull/1804/files


caveats: highlight PKG_CONFIG_PATH if exists

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you successfully run brew tests with your changes locally?

We keep getting issues every now & again about people being confused that keg_only includes hiding the pkg-config files. Perhaps seems reasonable to start pointing out those exist when they do & a hint on how to access them.
This could be complicated a little more by ensuring we only ever print one PKG_CONFIG_PATH hint if pkg-config files exist in both lib/pkgconfig and share/pkgconfig but I'm not aware of a situation like that with any existing formula.
Hidden behind a which check to avoid redundant messages, although pkg-config is an incredibly popular formula. Ran some time tests, no appreciable difference from the status quo.
If accepted:
Closes https://github.com/Homebrew/homebrew-core/issues/4669.

Good call 👍


Theme Primary color can't save

After I save it, click 'Edit' or 'Default Settings'

@G-lin The theme takes effect immediately only when the administrator changes the theme of the organization to which the administrator belongs. If the global administrator changes the theme of another organization, the theme does not take effect on the current management page.

Same problem, when the page is modified'colorPrimary ', the page is refreshed and displayed as the default color. I guess it should be a problem with the front-end components, not showing the configured value.

@AloneFire where did you configure theme and what UI do you expect to change? Maybe you have configured the wrong place. Can you share a video?

@AloneFire where did you configure theme and what UI do you expect to change? Maybe you have configured the wrong place. Can you share a video? 您在哪里配置主题以及您希望更改哪些 UI？可能是你配置错了地方。你能分享一个视频吗？

https://github.com/casdoor/casdoor/assets/20330223/ea72ff0b-8317-4da6-885c-5d086525b482


WIP: Add a list of playground components, on click navigate to playground test

Just a possible way to improve playground. Check it out and let me know what you think @mrtnzlml

@tbergq I like the idea. I wanted to implement this on my project as well but I had one problem. Since hot reloading doesn't work you always need to click the component again to see it. Is there a way to workaround it? (so it's open all the time)
Also, do you know how to find these tests automatically in the future?

@mrtnzlml check now, added WithStorage saving the last clicked route

Also, do you know how to find these tests automatically in the future?

I do not know how to solve ^^

@tbergq Looks alright, please continue. I will do better CR later (after WIP).

@mrtnzlml please check


feat!: merge predict and test tasks

Related issue
closes FL-1205
Summary

The predict task does not exist anymore. The evaluation of a model is done in a single task.
Strategy implement an evaluate method, with the @remote_data decorator, to compute the evaluation of the model. The evaluate method is the same for all strategies.
BREAKING: the perform_predict method of Strategy changed in favor of perform_evaluation that calls the new evaluate method.
BREAKING: metric_functions are now passed to the Strategy instead of the TestDataNode.
BREAKING: the predict method of Algo has no @remote_data decorator anymore. It signatures does not take prediction_path anymore, and the predictions are return by the method.

Can be reviewed commit by commit.


fix(pdk): request.get_raw_query

Summary
Avoid accessing ngx.var.args and fetch the raw query string from the request_uri instead.
Alternatives could be restricting access to happen only via ngx.var.* or implementing some index clearing logic in lua-kong-nginx-module by patching set_uri_args().


⚠ Bofrost.lu has degraded performance

In 727d930, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1143 ms

Resolved: Bofrost.lu performance has improved in f031c68 after 9 minutes.


Add the option for word separator of Resource id

Case of underscore used to separate words in the resource id ( e.g. /agency_report), generated resources were like Agency_report.
So, I want to add the option sep for word separator of URIs.
Then, with --sep=_ option, I'll be able to handle underscore.

@hiramatsutaku
Method of JS is lcc one, so it can be force convert to lcc.
So, you don't need to add sepalater options, it's OK to fix camelize.
Because this PR is not suitable, let's send another PR. 🙇


Upgrade project to use sass for style file

https://stackoverflow.com/questions/40726081/angular-cli-from-css-to-scss
rename all css fiel to scss file !!

to update it type the following command
ng g schematics-scss-migrate:scss-migrate
this will do the following set auto.

Renamed all the stylesheets in the src folder recursively.
Altered the styleUrls value to point to the new file names for the stylesheet in the component classes relative to the component style files.
Updated the component styles schematics value in the angular.json file or creates one if the schematic does not exist.
And renamed styles.css references to .scss in the angular.json file

ref

I got error

Can you do it for me ?

i too
we have to go manually

I got issue for that

I willclose this own-- we have to reduce issues as soon as possible


So buggy library

Bug
No drawing shapes with line path
import {
  Surface,
  LinearGradient,
  Path,
  Text,
  Shape,
  Group,
  RadialGradient,
} from '@react-native-community/art'

  const surfaceWidth = Dimensions.get('window').width - 16
  const surfaceHeight = surfaceWidth

  const path = new Path()
    .moveTo(0, 0)
    .lineTo(100, 100)
    .lineTo(200, 420)
    .line(150, 80)
    .line(150, -80)
    .line(40, -200)
    .line(-190, 120)

      return <Surface visible={true} opacity={1.0} width={surfaceWidth} height={surfaceHeight}>
        <Group visible={true} opacity={1.0} x={surfaceWidth / 2 - 90} y={surfaceHeight / 2 - 70}>
          {/* <Shape visible={true} opacity={1.0} strokeWidth={12} stroke="#000" d={path} /> */}
          <Shape visible={true} opacity={1.0} d={path} strokeWidth={12} stroke="#000" />
        </Group>
      </Surface>

but when you change imports to react-native core like this
import {ART} from 'react-native'
const {
  Surface,
  LinearGradient,
  Path,
  Text,
  Shape,
  Group,
  RadialGradient,
  // } from '@react-native-community/art'
} = ART

all is working fine.
However ART still present in react-native core, you should use it instead @react-native-community/art, because second is still so buggy library.

Those 2 versions of the lib are roughly the same. There shouldn't be any breaking changes. Can you create a repository with reproduction of this exact issue?


Screen jumped back to the first page screen after selecting a row on second page

I used single selection with option button.  When I selected a row in any page other than the first page, the screen jumped to the first page.  Can it stay on the page where I made the selection?

@jbp17 sorry for lately reply, it's seem a bug, do you enable the remote mode?

Please kindly give more information for me to reproduce, thx

Yes.  I only enable remote cell-editing because I have to save data to database.  But selecting function should not be limited to local and should remember the page it was on.

@AllenFang
Hi, here is a a minimal and simple code at codesandbox.io to reproduce the problem.  If you don't think this is a bug, can you tell me what I did wrong?
https://codesandbox.io/s/3x3m28y9q6
Thanks!

@jbp17 it's simple, You table get rerender everytime....
import React from "react";
import ReactDOM from "react-dom";

import "./styles.css";
import BootstrapTable from "react-bootstrap-table-next";
import paginationFactory from "react-bootstrap-table2-paginator";
import cellEditFactory, { Type } from "react-bootstrap-table2-editor";
import filterFactory, { textFilter } from "react-bootstrap-table2-filter";
import { isNullOrUndefined } from "util";
import "react-bootstrap-table-next/dist/react-bootstrap-table2.min.css";

export const productsGenerator = (quantity = 5, callback) => {
  if (callback) return Array.from({ length: quantity }, callback);

  // if no given callback, retrun default product format.
  return Array.from({ length: quantity }, (value, index) => ({
    id: index,
    name: `Item name ${index}`,
    price: 2100 + index
  }));
};

export default class App extends React.Component {
  constructor(props) {
    super(props);
    this.state = {
      data: [],
      selected: []
    };

    this.handleTableChange = this.handleTableChange.bind(this);
  }

  handleTableChange = (type, { data, cellEdit }) => {
    setTimeout(() => {
      // Handle cell editing
      if (type === "cellEdit") {
        const { rowId, dataField, newValue } = cellEdit;
        const result = data.map(row => {
          if (row.id === rowId) {
            const newRow = { ...row };
            newRow[dataField] = newValue;

            //Save to database
            //  this.updateData('/Employer/Employers/EditEmployer', newRow);
            return newRow;
          }
          return row;
        });
        this.setState(() => ({
          data: result,
          errorMessage: null
        }));
      }
    }, 2000);
  };
  render() {
    const products = productsGenerator(87);
    const columns = [
      {
        dataField: "id",
        text: "Product ID"
      },
      {
        dataField: "name",
        text: "Product Name"
      },
      {
        dataField: "price",
        text: "Product Price"
      }
    ];

    //SelectRow
    const selectRow = {
      mode: "radio",
      clickToSelect: true,
      clickToEdit: true,
      classes: "selection-row",
      selected: this.state.selected,
      onSelect: (row, isSelect, rowIndex, e) => {
        console.log(row.id);
        console.log(isSelect);
        console.log(rowIndex);
        console.log(e);
        if (isSelect) {
          //Clear all the currently selected row
          this.setState(() => ({
            selected: []
          }));

          //Set the selected to currently selected row
          this.setState(() => ({
            selected: [...this.state.selected, row.id],
            selectedEmployerId: row.id
          }));
        }
      }
    };

    //display total rows
    const customTotal = (from, to, size) => (

          Showing {from} to {to} of {size} Results

    );

    const options = {
      paginationSize: 4,
      pageStartIndex: 0,
      showTotal: true,
      paginationTotalRenderer: customTotal,
      sizePerPageList: [
        {
          text: "5",
          value: 5
        },
        {
          text: "10",
          value: 10
        },
        {
          text: "50",
          value: 50
        },
        {
          text: "100",
          value: 100
        }
      ] // A numeric array is also available. the purpose of above example is custom the text
    };
    const cellEditProps = {
      mode: "dbclick",
      blurToSave: true,
      errorMessage: this.state.errorMessage
    };
    return (

          <BootstrapTable
            remote={{
              cellEdit: true
            }}
            keyField="id"
            data={products}
            columns={columns}
            selectRow={selectRow}
            pagination={paginationFactory(options)}
            filter={filterFactory()}
            cellEdit={cellEditFactory(cellEditProps)}
            onTableChange={this.onTableChange}
            caption="Products"
            headerClasses="header-class"
            striped
            hover
            condensed
          />

    );
  }
}

const rootElement = document.getElementById("root");
ReactDOM.render(<App />, rootElement);

Thanks!

Hi @AllenFang ,
Is the issue of screen resetting to page 1 always after selecting row on second page resolved?
I am also working on the very same functionality, and facing the same issue. Could you please provide the solution, if this issue was resolved?


Release 3.4.1

This is mainly to have the latest version not use python2
This adds the PRs #1908, #1889, #1901, #1900, #1910 (only one commit) to 3.4.1.
I drafted a release here, please also check it out.
EDIT: I removed the -Wnoexcept-type fix since this erros on travis with an older ubuntu distro. This shouldn't matter for users anyway, since we no longer have -Werror outside of travis.

Fixed the travis error.


Vacuum out timing belt housing

This should be done before the Sandia projects start. Also a reminder that the maintenance schedule needs to be finalized and adhered to.

Also see #1.


For #26 - Adds some additional logging and options for verbosity.

I wanted to make this a PR instead of just committing directly because of one notable thing:
I removed musl from the BUILD_PACKAGES of the Slim images. When Apk was done doing its thing, it would refuse to remove musl because it's required for everything, causing warnings even when -q was used. So I just wanted to make sure there's no particular reason we had it that way.

I don't think there was a specific reason we had musl on the BUILD_PACKAGES but like you said its pretty much required by everything in Alpine. Are we still keeping it? Should we add it to the PACKAGES?

Ah, okay. Then I think we can remove it entirely, musl is already installed on every Alpine container. I think the only thing us trying to install it again would do is upgrade it, which we don't necessarily want in case they make any API changes in it that break everything.
-------- Original Message --------
On May 27, 2018, 09:55, João Ferreira Loff wrote:

I don't think there was a specific reason we had musl on the BUILD_PACKAGES but like you said its pretty much required by everything in Alpine. Are we still keeping it? Should we add it to the PACKAGES?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

If that's the case then we should move forward with it! Perhaps we could also change the other tags to remove musl from it


Version

Is it compatible with version 3.1?

@rezajatnika Unfortunately not! We are currently working on upgrading the gem so that is compatible with version 3.1. We will keep you posted, it should be coming soon!

Thanks @keenanpayne .

any news on gem for 3.1?

Just to let you know and for other users as well, currently this project is not supported and I don't have any plans to support it in the future, however, anyone who would like to take the task is very welcome. For now, I'll be focusing in the framework and all the add-ons.


How many words can Porcupine detect?

Expected behavior
Actual behavior
Steps to reproduce the behavior
Please include enough details so that the issue can reproduced independently by the resolver.
Is it a set number of words? Is there a list somewhere of all possible words I can use? Is it just any words that are in the english language?

There is no list. For open source it is what optimizer can generate. For commercial customers it is pretty much anything.


Failed to produce diagnostic for expression

Description
Failed to produce diagnostic for expression; please submit a bug report (https://swift.org/contributing/#reporting-bugs)
When I ran the code, I got this error on line 4 of NavigationExperiment.
Reproduction
NavigationExperiment
import SwiftUI

struct NavigationExperiment: View {
    var body: some View {
        VStack {
            NavigationStack {
                NavigationLink("Push Me!")  to redirect to the MyApp page. However, when I tried to run it, it said it was unable to produce a diagnostic.
Environment
swift-driver version: <IP_ADDRESS> Apple Swift version 5.10 (swiftlang-<IP_ADDRESS> clang-15<IP_ADDRESS>)
Target: arm64-apple-macosx14.0
I was using Swift Playgrounds, "Keep Going with Apps"
Additional information
No response

@God2525 could you please check whether this is fixed in the latest thunk development toolchain from swift.org?


traceparent in meta tag not used

Please answer these questions before submitting a bug report.
What version of OpenTelemetry are you using?
v0.16.0 (with document-load v0.13.0) and v0.14.0
Open
What version of Node are you using?
v14.15.4
Please provide the code you used to setup the OpenTelemetry SDK
opentelemetry-js/examples/tracer-web/examples/document-load
What did you do?
For the v0.14.0 test:

Clone repository
Navigate to opentelementry-js/examples/tracer-web
git checkout v0.14.0
Execute npm install
Execute npm start

I also tried checking out v0.16.0 and manually changing the document-load plugin to v0.13.0 in the package.json (Which gave the same result)
If possible, provide a recipe for reproducing the error.
Open up Chrome (In my case Chrome 88.0.4324.146 ) and navigate to: http://localhost:8090/document-load/
What did you expect to see?
I expected a trace for the load of the page with the same traceid as given in the meta tag of the index.html example:
ab42124a3c573678d4d8b21ba52df3bf
What did you see instead?
Only other traceids
Additional context
If  I understand the explanation under: "Optional: Send a trace parent from your server" in this readme: https://github.com/open-telemetry/opentelemetry-js-contrib/blob/v0.13.0/plugins/web/opentelemetry-plugin-document-load/README.md correctly I should be able to create a single trace with server and browser part combined. For this, I assume, the generated trace from the browser should use the traceid from the traceparent meta tag.
Add any other context about the problem here.

v0.16 is not compatible with contrib v0.13

v0.16 is not compatible with contrib v0.13

I'm working on an update to contrib right now

adding readme info -> https://github.com/open-telemetry/opentelemetry-js/pull/1920

Confirmed, I've successfully tested this:
Clone repository
Navigate to opentelementry-js/examples/tracer-web
git checkout v0.14.0
Edit package.json: Change plugin-document-load and plugin-user-interaction on lines 44-45 to use version "^0.13.0" instead of "^0.12.0"
Execute npm install
Execute npm start
Open up Chrome and navigate to: http://localhost:8090/document-load/ with the console open
Observed traceId is the same as in html meta tag

Thanks for quick clarification!


Unexpected kwarg matching when splatting an array of hashes

Input
With --ruby3-keyword-args
→ View on sorbet.run
# typed: true
extend T::Sig

hashes_1 = [{ bar: "1" }, { bar: "2" }]
hashes_2 = [{ bar: "1" }, { baz: "2" }]

def foo(*hashes, baz: nil)
  puts hashes.to_s + ", baz: #{baz}"
end

foo(*hashes_1) # LSP error: Unrecognized keyword argument `bar` passed for method `Object#foo`
foo(*hashes_1, baz: "10")
foo(*hashes_2)

Observed output

# typed: true
extend T::Sig

hashes_1 = [{ bar: "1" }, { bar: "2" }]
hashes_2 = [{ bar: "1" }, { baz: "2" }]

def foo(*hashes, baz: nil)
  puts hashes.to_s + ", baz: #{baz}"
end

foo(*hashes_1)
foo(*hashes_1, baz: "10")
foo(*hashes_2)

editor.rb:11: Keyword argument hash without ** is deprecated https://srb.help/7033
    11 |foo(*hashes_1)
        ^
    editor.rb:11: This produces a runtime warning in Ruby 2.7, and will be an error in Ruby 3.0
    11 |foo(*hashes_1)
        ^
  Autocorrect: Use `-a` to autocorrect
    editor.rb:11: Insert **
    11 |foo(*hashes_1)
        ^

editor.rb:11: Unrecognized keyword argument bar passed for method Object#foo https://srb.help/7004
    11 |foo(*hashes_1)
        ^^^^^^^^^^^^^^

editor.rb:13: Keyword argument hash without ** is deprecated https://srb.help/7033
    13 |foo(*hashes_2)
        ^
    editor.rb:13: This produces a runtime warning in Ruby 2.7, and will be an error in Ruby 3.0
    13 |foo(*hashes_2)
        ^
  Autocorrect: Use `-a` to autocorrect
    editor.rb:13: Insert **
    13 |foo(*hashes_2)
        ^
Errors: 3

Expected behavior
With --ruby3-keyword-args, the keys in the hashes should not be matched against foo's keyword arguments:
irb(main):001:0> hashes_1 = [{ bar: "1" }, { bar: "2" }]
=> [{:bar=>"1"}, {:bar=>"2"}]
irb(main):002:0> hashes_2 = [{ bar: "1" }, { baz: "2" }]
=> [{:bar=>"1"}, {:baz=>"2"}]
irb(main):003:0>
irb(main):004:1* def foo(*hashes, baz: nil)
irb(main):005:1*   puts hashes.to_s + ", baz: #{baz}"
irb(main):006:0> end
=> :foo
irb(main):007:0>
irb(main):008:0> foo(*hashes_1)
[{:bar=>"1"}, {:bar=>"2"}], baz:
=> nil
irb(main):009:0> foo(*hashes_1, baz: "10")
irb(main):010:0> foo(*hashes_2)
[{:bar=>"1"}, {:bar=>"2"}], baz: 10
[{:bar=>"1"}, {:baz=>"2"}], baz:
=> nil

I believe Sorbet is faithfully implementing the Ruby 2.7 behavior here; a Ruby 2.7 irb session produces for me:
irb(main):001:0> hashes_1 = [{ bar: "1" }, { bar: "2" }]
=> [{:bar=>"1"}, {:bar=>"2"}]
irb(main):002:0> hashes_2 = [{ bar: "1" }, { baz: "2" }]
=> [{:bar=>"1"}, {:baz=>"2"}]
irb(main):003:1* def foo(*hashes, baz: nil)
irb(main):004:1*   puts hashes.to_s + ", baz: #{baz}"
irb(main):005:0> end
=> :foo
irb(main):006:0> foo(*hashes_1)
Traceback (most recent call last):
        5: from /Users/froydnj/.rbenv/versions/2.7/bin/irb:23:in `<main>'
        4: from /Users/froydnj/.rbenv/versions/2.7/bin/irb:23:in `load'
        3: from /Users/froydnj/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/irb-1.2.6/exe/irb:11:in `<top (required)>'
        2: from (irb):6
        1: from (irb):3:in `foo'
ArgumentError (unknown keyword: :bar)

Are you testing this behavior with Ruby 3?  Sorbet does not yet implement the Ruby 3 keyword argument behavior.

Yes I tested it with Ruby 3 but I also passed the --ruby3-keyword-args flag in the playground. Isn't that going to make the keyword argument behavior match Ruby 3?

The implementation of this option is incomplete.  It implements the warning that you see above, but not the full keyword argument passing behavior.

I see, thank you. I currently workaround the issue with something like T.unsafe(self).foo(*hashes_1).
Should I leave this issue open, or close it as not planned?


Add ability for JS to switch audio/video track

This, like the rest of the JS, assumes only one audio or video track is being streamed up to the SFU. This should close #11.

One thing I need to track down is to ensure that when the track is swapped out, it is recognized as a new SSRC rather than re-using the old one. This is specified as a SHOULD in RFC 3550, and that RFC does specify that that a single SSRC can change encodings on the fly. Adding a new track and removing the old track seems closer to the intention of the RFC, though.

@sax I think that both secnarios (adding/removing and replacing SSRC) require from us an ICE restart.
I think that we could also add some kind of notification that some track has been replaced. It might be useful in some cases.
Regarding changing codecs. Yeah, we were analyzing this some time ago and it looks like each side can use any codec accepted by the peer so if e.g. in the offer there is audio track with 4 codecs
m=audio 120 121 122 123

and response accepts, let's say 3 off them
m=audio 120 121 122

then each of this codec can be used and sender can switch between them without renegotiation.
However this feature is quite tricky and we don't support it.
Could you link relevant sections from RFC 3550. I cannot find them.

@mickel8 Some links to RFC3550 that jump out to me:
2.1 - Simple Multicast Audio Conference: In this section is the following reference:

The RTP header indicates what type of audio encoding (such as PCM, ADPCM or LPC) is contained in each packet so that senders can change the encoding during a conference, for example, to accommodate a new participant that is connected through a low-bandwidth link or react to indications of network congestion.

3 - Definitions: The definition for SSRC has the following reference:

Examples of synchronization sources include the sender of a stream of packets derived from a signal source such as a microphone or a camera

A synchronization source may change its data format,  e.g., audio encoding, over time.

It also specifies this:

If a participant generates multiple streams in one RTP session, for example from separate video cameras, each MUST be identified as a different SSRC.

So by one reading of this, switching cameras does not create "multiple streams," so it might be fine if it retains the same SSRC on the backend. I think my concern comes in with multiple streams, in this flow:

User joins a multimedia session with camera A
User switches to camera B
User adds a second video track, with camera A

If the camera switch retains the same SSRC, and the second video track winds up being in the same RTP session, but somehow gets the same SSRC, it might be detected as a loop. I'm not sure if this is a problem, but just want to make sure that the device switching doesn't leave loose ends.

I think I see your point.

but somehow gets the same SSRC

This shouldn't be possible. Each time we create a new track we choose some random SSRC and we check wheather it is already used by any other track. We repeat the whole process until we generate the proper SSRC.
Does it answer your question?
The only thing I think we should add is ability to update track metadata while replacing it. Let's assume the following scenario
addTrack(some_track, metadata: {source: cameraA})
replaceTrack(some_other_track) // here we want to update metadata as source is no longer cameraA

In such a case we should also add some notification that track has been updated passing to the user new metadata.
cc @mat-hek

Agreed, I think that replaceTrack could just accept optional metadata argument replaceTrack(old_track_id, new_track, optional_metadata)

Just pushed the change to require the old track id when replacing a track.
It seems to me that updating the metadata will require a new MediaEvent type, no? Right now metadata and tracksMetadata only come in on the join media event.
Could the feature to update metadata be split out into a separate issue? If there was a more generic ability to change metadata and tracks metadata, publicly exposed on the client, then passing optional track metadata could just call that function.

Could the feature to update metadata be split out into a separate issue? If there was a more generic ability to change metadata and tracks metadata, publicly exposed on the client, then passing optional track metadata could just call that function.

Sounds good to me!

Could the feature to update metadata be split out into a separate issue?

Sure, I will make an issue
IMO, we can merge this PR


ClientSideAssets missing

Category

[x] Question
[ ] Typo
[ ] Bug
[ ] Additional article idea

When is the library "ClientSideAssets" being provisioned?
I have ensured the following things:

Get-SPOTenantCdnOrigins -CdnType Public shows */CLIENTSIDEASSETS
I have set the includeClientSideAssets to true
I'm on SPFx version 1.4
No problems running gulp bundle --ship and gulp package-solution --ship
(the sppkg contains the folder "ClientSideAssets" containing the correct files)
No problems during upload to a Site Collection App Catalog (target "SharePoint Online")
No problems during installation of the app

Problem
Once I want to embed my Web Part on a page, it will not find any resource:
Failed to load URL 'https://publiccdn.sharepointonline.com/xxx.sharepoint.com/sites/xxx/ClientSideAssets/ef662331-3b85-4aba-9ba9-1095624c8d13/xxx_en-us_47306258fbcefb00a929ec44b120beab.js' for resource 'XXX' in component 'dc35a537-2de5-4463-806d-5a3972dd2817' (XXX). There was an error requesting the file.
Did I miss something here? Do I have to create the library on my own?
Thanks for helping!
Dirk

same issue here

According to @VesaJuvonen the site collection app catalog does not support yet the asset packaging. This issue might be related with it. https://github.com/SharePoint/sp-dev-docs/issues/1131

Yes, I was trying to use it with site collection app catalog.

Just to copy the status from the duplicate (#1131) . This capability is currently rolling out and is already available with a subset of tenants. It should be available worldwide within a week.


Bypass API #889

This PR adds the bypass API feature mentioned on issue #889.
I moved the logic to a static class, BypassHandler, and call its methods from the RollupService. Also exposed the bypass methods in global methods (so the subscriber can use the API) on the rollup service class.

I'm super confused by this, but think it can solve a problem I am experiencing. Is there documentation on usage for this?


Patch for 5.3

Hi,
do you think missing patch files can be added to the repository?
Plus I think it makes sense to replace the source to
https://github.com/qzed/linux-surface/commits/master
since the original one is not maintained for a long time.
Best Regards and thank you for hard work!

Addressed. Default master branch has been updated to track qzed's fork. jakeday branch will continue to track the original repository.


[improve][pcip] PCIP-1 Add the development process for pulsar-java-contrib project

Add the development process for pulsar-java-contrib project

LGTM

LGTM

LGTM

Mailing List discussion thread: https://lists.apache.org/thread/z4bx7207cmprvp0vj8mgf1jhs7q2s4vn
Mailing List voting thread: https://lists.apache.org/thread/mmd65whp3g9yd6p5n1ytbqws2gt4cmrl

@liangyepianzhou mailing List vote is passed, help me merge this pr


Nuxt3使用unocss时，flex布局问题

div使用flex布局，div的子元素会自动生成flex：1 1 auto

We temporarily close this due to the lack of enough information.
Please provide a minimal reproduction to reopen the issue.
Thanks.

Why reproduction is required


Use headers for v1 pubsub block topic

This PR rebases the following commit of https://github.com/MinaProtocol/mina/pull/12534 :
Use headers for v1 pubsub block topic
Receive headers on a new pubsub topic and propagate them all the way
through to catchup, as alternative to block.
Existing synchronization code relies heavily on full blocks becoming
available, hence a hack was made: when a valid and relevant header
enters catchup system, download of a block will be requested and only
when the full block is available, processing will continue.

I did my best to split in several commits but I didn't manage to make them all compile.

!ci-build-me

!ci-build-me

!ci-nightly-me

!ci-nix-me

!ci-build-me

!ci-nightly-me


Ensure Dimension clone copies all parameters

The onlychanged=True check in param doesn't appear to be working at least in some cases. So using redim in certain cases drops Dimension parameters on clone. It's also not clear to me why onlychanged was there in the first place, there shouldn't be any harm in passing all of them along.
Fixes #3561

I'm ok with this change but it sounds like the real fix would be to address this in param. I don't see why it should only be the changed params either so I'll go ahead and merge.


Can you update this implementation to C++17?

The std::"result_of" is deprecated in C++ 17. Can you update this to a new version? Thank you.

I've fixed it here :
https://gist.github.com/supercairos/2893684c639610f04f67658780182c8b

I've fixed it here :
https://gist.github.com/supercairos/2893684c639610f04f67658780182c8b

hey @supercairos ,
Im new to github.I visited the link you provided which shows the link to file Threadpool.h
But, could tell me how to know the fix,I mean which file/repo to take diff from..?

I've fixed it here :
https://gist.github.com/supercairos/2893684c639610f04f67658780182c8b

Thank you so much.


Restructure the SecondOrderODE tests

Codecov Report

Merging #76 (b20d91d) into main (fe9de39) will increase coverage by 0.01%.
The diff coverage is 100.00%.

:exclamation: Current head b20d91d differs from pull request most recent head ddc3f0c. Consider uploading reports for the commit ddc3f0c to get more accurate results

@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
+ Coverage   87.88%   87.89%   +0.01%
==========================================
  Files          23       23
  Lines         916      917       +1
==========================================
+ Hits          805      806       +1
  Misses        111      111

Impacted Files
Coverage Δ

src/perform_step.jl
93.89% <100.00%> (+0.04%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe9de39...ddc3f0c. Read the comment docs.


getblocktemplate does not show SigWit feature in Stratum

This might need changes on either Stratum or lbcd side, such as magic number, coin symbols, etc.

Update:
Stratum tries to parse the rules field to find the segwit support, but lbcd only append segwit to rules if the blocktemplate includes any segwit transactions.
Will update again after consulting BIP 145.

Update:

The "segwit" of the rules field is optional when there's no SegWit transactions (inputs) in the template.
The default_witness_commit field is optional when there's no SegWit transactions (inputs) in the template.

lbcd does correctly implement the above behaviors - populate both fields when SwgWit inputs are included in the template, and omit both of the fields otherwise. However, the default_witness_commit returned is raw commitment instead of the witness script. (see issue #20)
This poses 2 questions:

How come lbrycrd always populates SegWit fields in getblocktemplate response?
Does Stratum mandate the presence of SegWit fields?

The Segwit related fields such as default_witness_commitment and rules ["segwit"] is required only when a template includes SegWit transactions.


Implement integration test for TableAdmin::DropRows*() against the Cloud Bigtable Emulator

We need to have #32 completed before we can write a useful integration test for TableAdmin::DropRowsByPrefix() and TableAdmin::DropAllRows(), this issue is to track the missing integration tests only.

Integration test for only these functions TableAdmin::DropRowsByPrefix() and TableAdmin::DropAllRows() is required?
No other function from TableAdmin class?

Correct.  There are already integration tests for the other functions in TableAdmin:
https://github.com/GoogleCloudPlatform/google-cloud-cpp/blob/master/bigtable/tests/admin_integration_test.cc#L115
If you are curious, we wrote those when ReadRows() was not implemented so it was not possible to write integration tests for Drop*Rows* at that time.

For this point I made some changes in the admin_integration_test.cc, like variable naming, test case naming, used common functions from table_integration_test.cc

Fixed in #289, I typed the magical "fixes" string incorrectly.


Fix local api setup and README instructions

Description
Updated readme for updating to the newest vercel version, linking to the carbonmark-api vercel project, pulling the env variables, upgrading from previous version and running carbonmark-api locally in dev mode.
Updated path to the folder and variables created by the newest vercel cli.
Related Ticket

Resolves #1338
Checklist

[X] I have run npm run build-all without errors
[X] I have formatted JS and TS files with npm run format-all

@0xemc I saw your comment about changing to process.cwd in app.ts, but can't find it on here(?). Did you delete and is that change no longer needed?

@0xemc I saw your comment about changing to process.cwd in app.ts, but can't find it on here(?). Did you delete and is that change no longer needed?

Hey no problem for now, there were other issues in the serverless version so I reverted it


@eessex => [Middleware] Skip AB test middleware in test

This is kind of messy but fixes an issue where based on an AB test, some acceptance specs are failing. Skipping this AB middleware entirely will result in those AB test values not being set, so that would generally result in the control path being used in the UI.
An alternative would be to update our acceptance specs to be able to also stub an AB test value, and then possibly update any fixtures, in order to make the tests deterministic.
I wasn't able to figure out a clean way of stubbing that though, in our existing setup. So went with this for now.

+1 to using default A/B paths in test modes.
Is skipping the middleware altogether actually safe though (e.g., might client code refer to values set within that skipped code)? If there's a way to execute the middleware but consistently select the default path in test mode (unless the test explicitly selects an alternative), that might be preferable.


[Star Tree] Multiple Star Trees and Added Tests

Description
This changes allows us to make multiple star trees (2 for now) per segment. This test also includes the tests to validate multiple star trees.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]

Check List

[ ] Functionality includes testing.
[ ] API changes companion pull request created, if applicable.
[ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Multi Star Tree fixes are taken over here: https://github.com/opensearch-project/OpenSearch/pull/16380


wide intermaxillary suture

wide intermaxillary suture
DEF: an abnormally increased width of the anterior median suture between the two maxillae of the upper jawbone for age-related norms
SYN: broad intermaxillary suture
SYN: broadened intermaxillary suture
SYN: widened intermaxillary suture
SYN: large intermaxillary suture
SYN: wide spaced intermaxillary suture
Annotation in J:228708

wide intermaxillary suture MP:0030425


Add Empty State

When there are no reminders set (for example when opening the app for the first time), it is just a blank screen. It would probably be a good idea to add some sort of empty state. Either an image or some sort of text that indicates that the user should click the FAB to create a Reminder.

Added a text view instructing users to click the FAB when there are no reminders set.
Thanks for the feedback!


Tests also for cblas/clapack detection ?

We have Fortran tests for blas/lapack. Shouldn't we add analogous tests for "<clapack.h>", "<cblas.h>"
? Would be good to verify proper autocmake's detection of C-blas/lapack librares.

I guess it would be good. But rather than baking it into math_libs.cmake we should IMO
split that module and create isolated cblas and clapack modules and then also test those.

Fine. First I would try to make a very simple cc_cblas test without touching math_libs.cmake. I assume (hope) that the math_libs.cmake detection works also with the C language in the same way as it works with Fortran.

Sure just go ahead.


[WIP] Testing Codecov Integration

📲 What
A description of the change.
🤔 Why
Some background context on why the change is needed.
🛠 How
More in-depth discussion of the change or implementation.
👀 See
Trello, screenshots, external resources?

Before 🐛
After 🦋

♿ Accessibility

[ ] Tap targets use minimum of 44x44 pts dimensions
[ ] Works with VoiceOver
[ ] Supports Dynamic Type

🏎 Performance

[ ] Optimized Blended Layers (screenshots)

✅ Acceptance criteria

[ ] Steps to test this feature
[ ] Environment to test on
[ ] Issues to look out for

⏰ TODO

[ ] Got planned refactors to come
[ ] Will add more tests
[ ] Need feedback on a design

@yatriks let's set up some time to get this merged 👍